TC's "sbt test" build step succeed even though it throws an exception during initialization

We have that TC Version 2017.1.2 (build 46812) succeeds the CI even though it was unable to initialize and run all of the test. We created a minimal sbt project that reproduces this behavior. The full project is at https://github.com/jsancio/teamcity-test. Requirements:

Include sbt-tc-logger version 0.4.0.
Force the test initialization to fail by throwing an exception during object initialization.

When you run the test using the normal sbt behavior this is what we get:
$ sbt test
[info] Loading project definition from /home/jose/work/teamcity-test/project
[info] Set current project to Hello (in build file:/home/jose/work/teamcity-test/)
[info] HelloSpec:
[info] The Hello object
[info] example.HelloSpec *** ABORTED ***
[info]   java.lang.ExceptionInInitializerError:
[info]   at example.HelloSpec.$anonfun$new$1(HelloSpec.scala:7)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.FlatSpecLike$$anon$1.apply(FlatSpecLike.scala:1682)
[info]   at org.scalatest.TestSuite.withFixture(TestSuite.scala:196)
[info]   at org.scalatest.TestSuite.withFixture$(TestSuite.scala:195)
[info]   at org.scalatest.FlatSpec.withFixture(FlatSpec.scala:1685)
[info]   ...
[info]   Cause: java.lang.IllegalArgumentException: Test TC sbt logger plugin
[info]   at example.Hello$.trickCompiler(Hello.scala:10)
[info]   at example.Hello$.<init>(Hello.scala:6)
[info]   at example.Hello$.<clinit>(Hello.scala)
[info]   at example.HelloSpec.$anonfun$new$1(HelloSpec.scala:7)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.FlatSpecLike$$anon$1.apply(FlatSpecLike.scala:1682)
[info]   ...
[error] Could not run test example.HelloSpec: java.lang.ExceptionInInitializerError
[info] Run completed in 292 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 1
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] *** 1 SUITE ABORTED ***
[error] Error during tests:
[error] 	example.HelloSpec
[error] (test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 1 s, completed Jul 9, 2017 4:40:08 PM

$ echo $?
1

Trying to run this test with the TC logger enable results in:
$ TEAMCITY_VERSION=ignore sbt test
[info] Loading project definition from /home/jose/work/teamcity-test/project
[info] Set current project to Hello (in build file:/home/jose/work/teamcity-test/)
##teamcity[compilationStarted compiler='Scala compiler in Test' flowId='-946421287']
##teamcity[compilationStarted compiler='Scala compiler' flowId='-946421287']
##teamcity[compilationFinished compiler='Scala compiler' flowId='-946421287']
##teamcity[compilationFinished compiler='Scala compiler in Test' flowId='-946421287']
##teamcity[testSuiteStarted name='example.HelloSpec' flowId='27']
[info] HelloSpec:
[info] The Hello object
[info] example.HelloSpec *** ABORTED ***
[info]   java.lang.ExceptionInInitializerError:
[info]   at example.HelloSpec.$anonfun$new$1(HelloSpec.scala:7)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.FlatSpecLike$$anon$1.apply(FlatSpecLike.scala:1682)
[info]   at org.scalatest.TestSuite.withFixture(TestSuite.scala:196)
[info]   at org.scalatest.TestSuite.withFixture$(TestSuite.scala:195)
[info]   at org.scalatest.FlatSpec.withFixture(FlatSpec.scala:1685)
[info]   ...
[info]   Cause: java.lang.IllegalArgumentException: Test TC sbt logger plugin
[info]   at example.Hello$.trickCompiler(Hello.scala:10)
[info]   at example.Hello$.<init>(Hello.scala:6)
[info]   at example.Hello$.<clinit>(Hello.scala)
[info]   at example.HelloSpec.$anonfun$new$1(HelloSpec.scala:7)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.FlatSpecLike$$anon$1.apply(FlatSpecLike.scala:1682)
[info]   ...
[error] Could not run test example.HelloSpec: java.lang.ExceptionInInitializerError
##teamcity[message status='ERROR' flowId='-946421287' text='Could not run test example.HelloSpec: java.lang.ExceptionInInitializerError']
##teamcity[testSuiteFinished name='example.HelloSpec' message='null' details='|[Ljava.lang.StackTraceElement;@2511a2c3' flowId='27']
[success] Total time: 1 s, completed Jul 9, 2017 4:43:28 PM

$ echo $?
0

Even thought the logger is printing an error message in:
##teamcity[message status='ERROR' flowId='-946421287' text='Could not run test example.HelloSpec: java.lang.ExceptionInInitializerError']

It results in the build step succeeding  in TeamCity.

We've run into the same issue, when forked tests fail (with sbt.ForkMain 37823 failed with exit code 255) it get suppressed and the build succeeds anyway (resulting in not all tests being executed without notice!).


How is verify_tls utilized?

I see that verify_tls is an argument to the constructor of a Hole object, but cannot determine where its value is utilized or honored.
Can you provide some clarification?

I guess that I never implemented it here.


NUKE client-side vertex arrays

Use VBOs/IBOs everywhere. Literally any other way of uploading buffer data is better than client-side vertex arrays.

What is the performance impact of this change? Is it dead code? Does everyone support vbos?

What do you mean by client-side vertex arrays? It seems that this is only used by SurfIsOffscreen to convert a surface into triangles without actually drawing it.

What is the performance impact of this change? Is it dead code? Does everyone support vbos?

None, it is pretty much dead code (the one part of the code that was using it shouldn't be doing so), yes.

Please add to commit message

Seems redundant, but sure I can add it.

What do you mean by client-side vertex arrays?

I mean the client-side vertex arrays, i. e. not VBOs.

It seems that this is only used by SurfIsOffscreen to convert a surface into triangles without actually drawing it.

It works fine without the skipVBO part, and with or without it it should do pretty much the same thing i. e. essentially nothing.

LGTM to the code itself. I don't think the commit/pull request messages do a good job of describing why it is right though.
The intention of the removed code is to avoid running some unnecessary code in Tess_SurfaceVBO in the case of processing a surface that we never intend to actually draw. The non-intending-to-draw case is with portal surfaces. But the if ( !vbo || !ibo ) early return in TessSurfaceVBO always triggers anyway because R_CreateWorldVBO() avoids setting VBOs/IBOs for portal surfaces. So the 2nd early return with tess.skipVBO turns out to be dead code.

I've updated the commit description. Another thing to add here is that core 3.2+ profile removes the ability to use client-side vertex arrays anwyay.


Set upper bound pymc 5.16

Expected breaking changes for RandonVariables in the next release, see https://github.com/pymc-devs/pytensor/releases/tag/rel-2.23.0

📚 Documentation preview 📚: https://pymc-marketing--725.org.readthedocs.build/en/725/

Thank you for https://github.com/pymc-labs/pymc-marketing/pull/725/commits/9870be7afc8237ae0173ea441fbb01939df5415c copilot and chatgpt!


Cryptix OpenPGP incompatability

Outlook2013:
The switch settings are now stored in this version and the switch successfully suppresses the error message that was there before, but the mail is not decrypted.
Is it possible only the error is suppressed, but the plug-in still does not attempt with the decryption of the mail?

Should be fixed in BETA 53. Finally found a reproduction case. Issue was related to the 10 year old Cryptix pgp library for java.

Please re-open if bug is not fixed.


Parsing russian.cntv.cn  domain

If you have "russian.cntv.cn" for parsing in line:
tldIndex = domainString.IndexOf("." + MatchingRule.Name, StringComparison.InvariantCultureIgnoreCase);
https://github.com/danesparza/domainname-parser/blob/master/DomainName.Library/DomainName.cs#L145
you will get:
tempSudomainAndDomain = "russian"
TLD = "cntv.cn"
Is this error?

Looks like .cn exists in publicsuffix.org -- and I don't think that the behavior you described is expected.  So yeah -- I think it's a bug.

The bug occurs with any domain name that matches the start of a TLD.
For example with www.comscore.com, domainname-parser thinks the TLD is comscore.com, because it looks for the first index of .com in the string.
It looks like the fix would be to update line 145 of DomainName.cs to use LastIndexOf instead of IndexOf?

Yep.  I think changing this code would probably be the right approach.  We should probably add this edge case to the unit tests.
@alexwarren :star: Great catch!

Wow -- it's been a while since I looked at those unit tests, too.  They should be refactored to use Arrange / Act / Assert.


Added gamma to LBFGSState

This PR adds a new attribute to the LBFGState named tuple, gamma.
This attribute is needed when one wants to use the approximation of the Hessian inverse after the algorithm has run using inv_hessian_product.
Indeed I realized that in this implementation, the initial value of the approximation of the Hessian is recomputed at each iteration, as suggested by Nocedal (something that is not present in scipy to the best of my knowledge and understanding of Fortran).
The application I have in mind for the approximation of the Hessian inverse is https://arxiv.org/abs/2106.00553.
(I didn't write an issue first because it's such a small PR, and I was going to write this part anyway for my own xps)

One aspect I am not too sure about though in the arguments of inv_hessian_product is start.
It indeed seems like it's used to perform the matrix multiplication in a certain order, but I don't understand why that's necessary.
Is it because with numerical errors the additions become non-commutative?

One aspect I am not too sure about though in the arguments of inv_hessian_product is start

We use a circular buffer to maintain the history without lists.

I think I don't have access to the logs of the copybara failure, or at least I am not sure how to access them in order to correct the failure.


smoothly moving pieces - as done on chess.com

I am would like to get my chess pieces to move like on chess.com which seems to be a bit better user experience.
as of now when I drag and drop a piece it goes back to the square it came from then is re-uploaded to the square I drop it on (on a legal move)
is there anyway to have the piece be hidden after  drop it on a legal move? and then only appear on the square I dropped it on? and not appearing on the square it came from ?
import React, { useEffect, useState } from 'react'
import Square from './Square'
import Piece from './Piece'
import { useDrop } from 'react-dnd'
import { handleMove } from './Game'
import { gameSubject } from './Game'
import Promote from './Promote'

import { useSelector } from 'react-redux'

import { auth, db } from './firebase'

import firebase from "firebase/app";
import { useDispatch } from "react-redux";

export default function BoardSquare({ piece, black, position,isFromSquare,isToSquare}) {

  const dispatch = useDispatch();

  const [promotion, setPromotion] = useState(null)

var whiteTime = useSelector(state => state.user.whiteTime)

var blackTime = useSelector(state => state.user.blackTime)

const DateNowFireStoreServerTimeStamp = useSelector(state => state.user.DateNowFireStoreServerTimeStamp)

const FirestoreServerTimeStampForLastMove = useSelector(state => state.user.FirestoreServerTimeStampForLastMove)

var gameStarted = useSelector(state => state.user.status)

  const [, drop] = useDrop({

    accept: 'piece',
    drop: (item) => {

      if (gameStarted === "waiting"){
        return
      }

      const [fromPosition] = item.id.split('_')

      const pieceType = item.id.split('_')[1]

    var DateNowFireStoreServerTimeStamp;

var ref = db.collection("users").doc(auth.currentUser.email).collection("serverTimestampOnMove").doc("serverTimestampOnMove")

    ref.set({ serverTimestamp: firebase.firestore.FieldValue.serverTimestamp()}).then(()=>{

      ref.get()
      .then(doc => {

        DateNowFireStoreServerTimeStamp = doc.data().serverTimestamp

        if(DateNowFireStoreServerTimeStamp){

    var difference = DateNowFireStoreServerTimeStamp - FirestoreServerTimeStampForLastMove

    var convertdifferenceToMatch1000perSecond = difference * 1000

        whiteTime = whiteTime - convertdifferenceToMatch1000perSecond
        blackTime = blackTime - convertdifferenceToMatch1000perSecond

           handleMove(fromPosition, position,whiteTime,blackTime,DateNowFireStoreServerTimeStamp, pieceType)

        }
       })
    })

    }
  })

  useEffect(() => {
    const subscribe = gameSubject.subscribe(
      ({ pendingPromotion }) =>
        pendingPromotion && pendingPromotion.to === position
          ? setPromotion(pendingPromotion)
          : setPromotion(null)

    )

    return () => subscribe.unsubscribe()

  }, [position])

  return (
    <div className="board-square" ref={drop}>
      <Square black={black}
     isFromSquare={isFromSquare}
     isToSquare={isToSquare}

      >
        {promotion ? (
          <Promote promotion={promotion}
           fromPosition={null}
           position={position}
           //OLD CODING below - new coding will convert the time in the next function
          // whiteTime={whiteTime - (DateNowFireStoreServerTimeStamp - FirestoreServerTimeStampForLastMove)}
          // blackTime={blackTime - (DateNowFireStoreServerTimeStamp - FirestoreServerTimeStampForLastMove)}
          //NEW CODE

        //  34r~) continue on below pass these values then do the timestamp calculations in a following func

          whiteTime={whiteTime}
          blackTime={blackTime}

          DateNowFireStoreServerTimeStamp={DateNowFireStoreServerTimeStamp}
          pieceType={"q"}
          FirestoreServerTimeStampForLastMove={FirestoreServerTimeStampForLastMove}

           />
        ) : piece ? (
          <Piece piece={piece} position={position} />
        ) : null}
      </Square>
    </div>
  )
}

Im not a contributor but chess.js is only the chess logic, not the board.

You can do this using react-reanimated library.
Check my repo:
https://github.com/anti-duhring/chess

I think what you want here is a change in the actual UI code. I guess you're using one like react-chessboard. You could add an animated 'prop' or create an animated to that wraps around their UI component


Private Figma files

Close #8
type: "figma" designs now support PAT(Personal Access Token) or OAuth2 authentication via credential field.
CAUTION: Since this approach only uses front-end tech, there are security risks. Use it at your own risk.
// with PAT
{
  designs: {
    type: 'figma',
    // Only URLs with node-id would work
    url: 'https://www.figma.com/file/Klm6pxIZSaJFiOMX5FpTul9F/storybook-addon-designs-sample?node-id=2%3A5',
    credential: {
      personalAccessToken: 'YOUR_PERSONAL_ACCESS_TOKEN'
    }
  }
}

// with OAuth2
{
  designs: {
    type: 'figma',
    // Only URLs with node-id would work
    url: 'https://www.figma.com/file/Klm6pxIZSaJFiOMX5FpTul9F/storybook-addon-designs-sample?node-id=2%3A5',
    credential: {
      oauthClientId: 'YOUR_CLIENT_ID',
      oauthClientSecret: 'YOUR_CLIENT_SECRET'
    }
  }
}

For OAuth2 callback URL, set http(s)://your/storybook/path/addon-designs-oauth.html.
ex) hosting Storybook at https://my-project/storybook/ and developing at http://localhost:6006,  set https://my-project/storybook/addon-designs-oauth.html and http://localhost:6006/addon-designs-oauth.html.
I'll add the docs.

I didn't include any examples of this feature since it goes completely public.

@pocka Is there any documentation surrounding this feature?

@jpmarra https://pocka.github.io/storybook-addon-designs/?path=/docs/docs-figma-examples--embed-private-file#embed-files
No specific installation, because private embed is same as public ones.


Bidirectional model?

Hello,
Thanks for the great paper! If I understand correctly, Mamba model is similar to a one directional LSTM. Is there a way to implement it in not causal but bidirectional way, so the model can see information from both sequence ends? It would be similar to BERT encoder architecture in that sense I guess.

There are many approaches to this. You can implement a variety of naive methods to incorporate information from both ends, such as in this PR: https://github.com/state-spaces/mamba/pull/52.
There are some slightly more clever methods that are in progress. Stay tuned!

Hi! Thank you for your awesome work! I am also interested in using Mamba with different bidirectional methods. Besides PR #52, is there any new features related to the more advanced methods you mentioned? Thanks!


V2.2: Build scripts failing

the builds scripts are failing following an update to the raspi os list json. Build currently failing at bad indexing in build/rpi-image, but correcting indices does not fully correct new the build issues.

Build script updated to dynamically index raspi os list json.


Load the appinsights connectionstring from an environment variable

This works when I build it locally with:
APP_INSIGHTS_INSTRUMENTATION_KEY=1234 node prepEnv.js simple && vite build
The key is now available for the client when I serve it (http-server dist).
Todo: Make a commit that prints the key in main.ts to check if it is available for the client when built on Azure.


Analyzer doesn't generate an error for missing getter

In language_2/setter_no_getter_test.dart, the analyzer does not produce any error for when a composite operator is called without a getter being defined.
set topLevel(var value) {}

class Example {
  set foo(var value) {}
}

main() {
  print(topLevel++);
  //    ^
  // [cfe] Getter not found: 'topLevel'.

  Example ex = new Example();
  print(ex.foo++);
  //       ^
  // [cfe] The getter 'foo' isn't defined for the class 'Example'.
}

In the review below, analyzer lines were added manually.
https://dart-review.googlesource.com/c/sdk/+/116825 for reference.
cc @leafpetersen

I cannot find the test mentioned (I'm sure it's just been renamed), but we now produce the same two errors as CFE.


Guide for creating new targets is ambiguous

This guide is ambiguous and doesn't provide good information for developers to create their own targets.
Things that are missing/broken:

[x] an outline of available properties for pxtarget.json
[x] outline of how a pxt.json file is structured and how it functions
[ ] a guide for adding and removing api's in their own directories in /libs
[ ] docs for creating a simulator?
[ ] Instructions in the guide don't correspond to how sample target sources is structured (there's no libs/sample project)
[ ] Static File Drops page is missing

Some progress here: https://makecode.com/targets/pxtarget


Close websocket

Issue
When I implemented the current react-client example on a long-running server instance, I saw exploding memory usage but no CPU usage. The memory hung for a long time but was never released. I checked my console network tab, and the connections were never being closed.
This pull request
I believe there need to be calls made to close the web sockets, or else there will be a build up of memory on the server.
I added calls to close the web socket on component unmount and page exit/reload

@kaisalmen @CGNonofr I made the change to lspWebSocket?.close();!


Query effective rather than global git configuration

Recent versions of git support additional configuration files e.g. $XDG_CONFIG_HOME/git/config. When setting user.name and user.email in this file (as I do), it is not reported by git config --global.
I don't really see a reason to explicitly query the global git configuration instead of the effective git configuration, which is what a plain git config user.name does.

@kynan Good point, thanks a lot. If you want to add yourself to AUTHORS.rst, I'll merge then this PR.

Thanks for merging and sorry for the slow response! Do you want me to submit a separate pr for the AUTHORS file?

I can also add you, no problem. What's the mail address you want to use?

OK, thanks. Please use the email address from my commit.


set tls.Config.ServerName in the http3/client.go/newClient()

fix #3865
bug caused by: https://github.com/quic-go/quic-go/commit/d683b841c4aa8b8b1434ebd27cebc43be7c2ba16#diff-4b667feae66c9d46b21b9ecc19e8958cf4472d162ce0a47ac3e8386af8bbd8cfL231-L239
Copied this logic into http3 package.

@kgersen Could you check if this PR fixes the regression you reported?

partially. it works for simple cases. but when the connection is reused, for instance when following a redirect, it panics:
go run example/client/main.go -q https://www.google.com/

ok
but
go run example/client/main.go -q https://google.com/

panic: connection already exists.
it's the default behavior of std lib http client to follow redirects so http3 client should too.
I haven't looked further why this panic occurs. if @Glonee can look at too ? otherwise I'll try to fix it.
v0.34.0 was fine and handled the redirect fine.
side note: the new 'Transport' (quic.Transport) introduced in v0.35.0 add a bit of confusion. In  std lib, Transport is usually understood as http.Transport (or http2.Transport), ie the implementation of HTTP/x protocol over TCP. Here it's called http3.RoundTripper and quic.Transport is something not specific to HTTP/3.
It's fine, it is just names and different packages but it's not very consistent with the stdlib.

@kgersen Thanks for testing.

panic: connection already exists.

The panic comes from here: https://github.com/quic-go/quic-go/blob/v0.35.0/multiplexer.go#L59. It shows that the http3 package is not using the quic.Transport correctly. That's a very annoying oversight, and shouldn't have made it into the final release. We definitely should have a test case for that (I'll create one right away).

side note: the new 'Transport' (quic.Transport) introduced in v0.35.0 add a bit of confusion. In std lib, Transport is usually understood as http.Transport (or http2.Transport), ie the implementation of HTTP/x protocol over TCP. Here it's called http3.RoundTripper and quic.Transport is something not specific to HTTP/3.

Noted. Improving documentation (both GoDoc and README) is on my TODO list.

@kgersen Can you check if the problem still exists?

seems ok. thanks.
Both the provided example and our product (once we adapted / changed from using net.UDPConn to using quic.Transport) worked fine.
We didn't launch extensive tests, just our basic ones. I'll conduct more tests next week.

@Glonee Can you split the last 2 commits into a separate PR? It would also be great if we had a HTTP integration test that dials two QUIC connections. Any idea?

@marten-seemann  localhost and <IP_ADDRESS> are considered as different server names. Maybe we can dial to localhost and <IP_ADDRESS> to make two QUIC connections?

Sounds like a good idea. You could change the self-signed certificate to be valid for both the IP and localhost: https://github.com/quic-go/quic-go/blob/fce0261c3433532fecc88bd322f985b55c2381df/integrationtests/tools/crypto.go#L46


update the Avalonia Control Gallery in windows store

https://www.microsoft.com/store/productId/9PGHN6QNJ3RP?ocid=pdpshare

discussed here: https://github.com/AvaloniaUI/Avalonia/discussions/10035#discussioncomment-4754738

closing this as duplicate -

/cc @danwalmsley


Merge addon: scrolling performance are low

I'm using the merge addon with:
        this.codeMirror = CodeMirror.MergeView(target, {
            value: this.props.value,
            orig: this.props.base,
            lineNumbers: false,
            lineWrapping: true,
            mode: 'gitbook+markdown',
            showDifferences: true,
            collapseIdentical: false
        });

But scrolling performance are very low (it makes it unusable), The content is the same as the content of this file.
The file is smaller than the example at https://codemirror.net/demo/merge.html
Once the content is identical in the 2 panels, the scrolling became fluid.
I'm using CodeMirror 5.12.0; on the latest version of Chrome, Mac mini (3 Ghz)

More investigation:

Fast and fluid on Safari and Electron
Fluid on Firefox while not editing
Slow on Chrome (Version 48.0.2564.116) on 2 different macs:

Mac mini 3Ghz
Macbook Pro 2.7Ghz

Seems okay on Chrome Linux as well. So I'd be tempted to blame a particular issue with those Chome versions. If you can find a root cause that CodeMirror can avoid, I'll happily consider patch. But I'm not going to dig into this myself.


Completely not working

I'm using Atom 1.6.1 on OSX 10.11.4
I installed vim-mode and it's simply not working. I'm presented with a square cursor. I can only move around the cursor with the arrow keys.
VIM "arrow" keys do not respond and pressing i or v does not seem to enter insert nor visual mode. No keypress seems to be registered.
I attempted disabling all other installed packages and restarting multiple times. There does not seem to be any related error printed in the console.
Any idea what I can try?

I'm getting the same issue with 1.6.2 any thoughts ?

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


layout algorithm merges non-adjacent text lines

Running pdf2txt on the attached PDF(which came to me from @joelostblom via https://github.com/0xabu/pdfannots/pull/24) produces output in the wrong order.
Expected output (from Poppler pdftotext):
Heading
Link to heading that is working with vim-pandoc.
Link to heading “that is” not working with vim-pandoc.

Subheading
Some “more text”

1

Actual output (from pdf2txt.py with defaults):
Link to heading that is working with vim-pandoc.

Link to heading “that is” not working with vim-pandoc.

Heading

Subheading

Some “more text”

1

It is possible to get the correct result by disabling the default layout detection algorithm. After applying #657, we can use pdf2txt.py --boxes-flow=disabled and get the output in the expected order.

Since I spent some time digging into this, I thought it might be useful to document here what goes wrong in the default case. The relevant code in [`LTLayoutContainer.group_textboxes](https://github.com/pdfminer/pdfminer.six/blob/7254530/pdfminer/layout.py#L705-L784) tries to iteratively merge text lines that are close together into text groups, until everything is in one sorted group. Lines to merge into groups are chosen using a "distance" function (`dist`) defined as area of the bounding box containing both text lines minus the area of the two text lines. By minimising this distance, the algorithm tries to select lines that are "close" together.
On this page, the lines are:

Heading (I'll call this short)
Link to heading that... (I'll call this long)
Ling to heading "that is" ... (long)
Subheading (short)
Some "more text" (short)
The final page number "1"

The algorithm first:

group short lines 4 and 5
group long lines 2 and 3

Now we have:

Line 1 ("Heading") which is short
The group of long lines 2 and 3
The group of short lines 4 and 5
The page number line

So far so good, but here the problem arises. Because line 1 is short, its distance (defined as above as area difference) from the second group of short lines is smaller than the distance from the long lines that actually follow it, so it is merged incorrectly with the short group, producing the final order:

The group of short lines 2 and 3
A merged group of "Heading" (line 3) followed by lines 4 and 5
The page number line

It looks like a mistake to group lines purely based on distance, in particular when there are objects in between the two (the "long" group, in this case). Indeed, the helper function isany can detect such objects, but it is never called brecause skip_isany is never True. I suspect #315 may have regressed this.

This appears to be a regression from #315 or 2bee7d8dcfd536a88c690a0cd74b0e2dae1947ef. The commit immediately prior (6cc78ee1249558fa3a5e0cc8f296ed736460905d) produces the correct output.


Link attributes seem not to work

I am referring to the link macro described in asciidoctor documentation.
When I try to use this syntax, the extension does render the brackets content as if it were the entire text content:
link:http://discuss.asciidoctor.org/[*mailing list*^, role="green"]

Renders as:

Instead of:

Thanks for the detailed issue.
It's most likely a RegExp issue in Opal...
The following is working as expected:
link:http://discuss.asciidoctor.org/[*mailing list*^]

I can reproduce this issue in Atom.
@mojavelinux I think this is where I should look: https://github.com/asciidoctor/asciidoctor/blob/673500f6103b1e6714026238463a77c51527a8d4/lib/asciidoctor/substitutors.rb#L849-L922 (in Asciidoctor.js) ?

You must enable the linkattrs document attribute to use named attributes in
a link macro.
I think there's an open issue to switch this attribute on by default (when
not running in compat mode).

Understood, thanks! 👍

Here's the upstream feature: https://github.com/asciidoctor/asciidoctor/issues/2059. I'm interested in your thoughts as a user. Should we just go ahead and enable this by default (when compat mode is not on).

I do not know if this an asciidoctor-only feature and I am not well aware of the options strategy.
But indeed without browsing the doc (and I missed it), I felt it weird I could not add roles on links like I would do on code blocks or admonition for example.

That's the input I was looking for. Thanks!


Rules -  Problems when evaluating two global variables using "AND" or "OR"

I need your help once again.
When I define a rule it can't evaluate two variables with "AND" or "OR". The rule only responds to the first variable, in this case global.lluvia but not global.presencia
Attached screeshot

You can help me?
Thank you very much for your interest

I'am working on a solution. Because this entails extensive changes, it may take some time to complete.

I can also confirm this behavior when using multiple messages as conditions.

It is fixed in the development branch.

solved with Version 1.1.0


Warn client when Invocation fail

Before the relay panics when the function did
not respond in time or something breaks.
Instead of breaking, we send back a warning to the
invoking client.
Furthermore I fixed a small bug I found in the invoker:
If the RPS is larger than 1000 the duration is 0.
The timer will not trigger any request.
Now the Invoker can handle RPS up to microseconds.
Furthermore, if the RPS is too high it will
warn the user

The PR depends on https://github.com/vhive-serverless/vSwarm-proto/pull/72.
Once It is merged we must update the version of vSwarm-proto


Add cyclictest workload for RT performance

Signed-off-by: Sai Sindhur Malleni<EMAIL_ADDRESS>

This PR adds support for running cyclictest to determine realtime latencies through the benchmark-operator.
Few points:

This test is intended to run only on Baremetal node with realtime kernels
I have intentionally not invested any time in building tests as we cannot really effectively test this workload in CI unless it's running on baremetal with a realtime kernel
benchmark-wrapper integration to follow later, the intention is to first get the workload into benchmark-operator.

Is there anything we can add for a CI test script in tests/test_cyclictest.sh ?

Unforunately you need a BM setup with performance add-on operator and a real time kernel installed to get this to run. Not sure a test is really useful here, except checking this doesn't break the rest of the workloads.

benchmark-wrapper integration has now been added at https://github.com/cloud-bulldozer/benchmark-wrapper/pull/222


[WEB-CLIENT] Limit available languages in language selector

Describe the bug
Currently, we only offer support for 4 languages (English, Spanish, French, Portuguese).
Having every possible language in the selector is a bit misleading and confusing for now, at least until we machine translate those languages.

To Reproduce
Steps to reproduce the behavior:

Go to https://app.staging.reach4help.org/
Click on the language selector

Expected behavior
For now, just have these languages in the selector: English, Spanish, French, Portuguese.
This will of course expand as the need arises, but we should be clear about what we officially have translated now.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

Closing the ticket as the user can now only choose from the 4 different languages.


Issue running mta build on our mta project

Hello Team,
We would like to switch from our mta archive builder to new cloud mta build tool.
We are currently building .mtar files using mta archive builder.
I followed the steps in the manual to download and install the cloud mta build tool  and GNU Make in my windows system. Then set GNU make to my PATH environment variables.
https://sap.github.io/cloud-mta-build-tool/download/
The link to our mta.yaml file https://github.wdf.sap.corp/CSI/outbound/blob/master/mta.yaml
On running the mbt build command, we get the following error.
[2019-09-20 11:05:26]  INFO generating the "Makefile_20190920110526.mta" file...
[2019-09-20 11:05:26]  INFO done
[2019-09-20 11:05:26]  INFO executing the "make -f Makefile_20190920110526.mta p=cf mtar= strict=true mode=" command...
[2019-09-20 11:05:28]  INFO validating the MTA project
[2019-09-20 11:05:28] ERROR the "mta.yaml" file is not valid:
line 60: the "outbound-service" provided property set name is already in use; a module was found with the same name on line 46
make: *** [Makefile_20190920110526.mta:30: pre_validate] Error 1
Error: could not build the MTA project: could not execute the "make -f Makefile_20190920110526.mta p=cf mtar= strict=true mode=" command: exit status 2
Best Regards
Abhishek

Hi Abhishek,
Thank you for using the tool. Ans I am glad that your tool setup phase passed smoothly.
The error you get indicates that your mta.yaml is invalid. Specifically, one of your modules "provides" property set with a name of a module in line 46. It is not allowed. The names of artifacts that can be "required" in other modules or resources: modules, provided property sets, resources, must be unique within the mta.yaml. It guarantees that once this artifact is required, this configuration can unambiguously be resolved.  Unfortunately, there was a bug in the old MTA Archive builder that did not validate it properly. Please rename either module or provided property set and make sure that where the name appears in "requires" now you use the correct artifact.
Regards
Natalia


Import Multiple events at once

Im using the importer to set old data into mixpanel, but im doing it one event at the time, which is quite expensive for a couple of thousands events, is there a way to import multiple events at once, their docs say they support a JSON Array but couldnt figure it out on how to call the importer to send an Array

+1

:+1:

:+1:

import_batch is now available in v0.2.0.

yay thanks @tdumitrescu !

 And to those who've been waiting on this, apologies for the delay: we're starting to work through the backlog of issues and are taking them one at a time.


Can't build VSIX locally with VS 15.8 or later installed

Tried changing korebuild.json to extend the VS version range ("versionRange": "[15.0.26730.03, 15.9)") but that leads to numerous restoration failures when building tooling\Microsoft.VisualStudio.RazorExtension\Microsoft.VisualStudio.RazorExtension.csproj with msbuild.exe.
Current workaround is to build with /p:BuildVsix=false and the above VS version range extension. (Tests fail whether building the VSIX or not when msbuild.exe isn't found.) Not sure how to clean up restore errors seen in VS…
Suspect I'm missing something that must change when extending the VS version range. Either that or the latest build tools (msbuild.exe et cetera) have a bug affecting restore operations.

Not sure it's related. But, what's with the following build output (right near the end of a successful build)?
WARNING: Unnecessary exclusion in Microsoft.AspNetCore.Razor.Design
Issue: NEUTRAL_RESOURCES_LANGUAGE
Instance: tools/Newtonsoft.Json.dll

WARNING: Unnecessary exclusion in Microsoft.AspNetCore.Razor.Design
Issue: VERSION_INFORMATIONALVERSION
Instance: tools/Newtonsoft.Json.dll

/cc @rynowak @NTaylorMullen
Note 59baad17da (a git merge into master) reduced the VS version range to exclude all 15.8 versions. Odd since 63af9221dc set the upper limit at 15.9. Is there a known problem in the 15.8 range?

I know there was a problem at some point. VS/unittesting/msbuild frequently break on prerelease builds. No idea about the current status.

I opened this issue for two reasons

Builds fail on my machine because I only have VS 15.8 installed. The root cause may be an inability to find msbuild unless 15.7 or lower is available.

Would be great if discovering msbuild were independent of the VSIX support checks.
Error is

.dotnet\buildtools\korebuild\2.2.0-preview1-17102\modules\vstest\module.targets(108,5): error : Test group UnitTests/netcoreapp2.2 failed with exit code '1'. [.dotnet\buildtools\korebuild\2.2.0-preview1-17102\KoreBuild.proj]

Changing korebuild.json to include VS 15.8 in the supported versions (i.e. "versionRange": "[15.0.26730.03, 15.9)") cleans up the test failure above. But, restore fails with 41 errors, starting with

tooling\Microsoft.VisualStudio.RazorExtension\Microsoft.VisualStudio.RazorExtension.csproj : error NU1100: Unable to resolve 'Microsoft.VSSDK.BuildTools (>= 15.7.109)' for '.NETFramework,Version=v4.6'. [dotnet\buildtools\korebuild\2.2.0-preview1-17102\KoreBuild.proj]
tooling\Microsoft.VisualStudio.RazorExtension\Microsoft.VisualStudio.RazorExtension.csproj : error NU1100: Unable to resolve 'System.Composition (>= 1.0.31)' for '.NETFramework,Version=v4.6'. [.dotnet\buildtools\korebuild\2.2.0-preview1-17102\KoreBuild.proj]
tooling\Microsoft.VisualStudio.RazorExtension\Microsoft.VisualStudio.RazorExtension.csproj : error NU1100: Unable to resolve 'System.Text.Encoding.CodePages (>= 4.3.0)' for '.NETFramework,Version=v4.6'. [C:\Users\dougbu\.dotnet\buildtools\korebuild\2.2.0-preview1-17102\KoreBuild.proj]
tooling\Microsoft.VisualStudio.RazorExtension\Microsoft.VisualStudio.RazorExtension.csproj : error NU1100: Unable to resolve 'System.ValueTuple (>= 4.3.0)' for '.NETFramework,Version=v4.6'. [.dotnet\buildtools\korebuild\2.2.0-preview1-17102\KoreBuild.proj]

Closing this as done!


backend parameters passed to session are being ignored if Backend instance is also provided to the session

The problem
The docs describe ignored_parameters like this
session = CachedSession(ignored_parameters=['auth-token'])

and they also describe passing a custom backend by instnace like this
backend = RedisCache(host='<IP_ADDRESS>', port=6379)
session = CachedSession('my_cache', backend=backend)

However these two are incompatible, since the ignored_parameters are actually not a session variable, but a backend variable and the session only passes these values to the backend if the backend is constructed by the session  (that was a mouthful... I hope I am clear).  If the instance of the backend is passed to the session, then the ignored_parameters is being silently ignored.  This is confusing, and since it doesn't raise an exception or log an error, and everything works (except the parameters are not ignored...) it is very easy to miss.
Note this is probably true for other backend parameters, but this "ignored_parameters" affected me and I haven't checked the others.
Expected behavior

Do not silently ignore the backend parameters,  if a backend instance is passed and also backend parameters are passed to the session then raise an exception.
Fix the session documentation and preferably also the function parameters so that is extra clear, something like passing "backend_parameters" will make it clearer

# this is fine - the backend_parameters are passed when the backend is constructed inside
session = CachedSession('my_cache',  backend_parameters={"ignored_parameters": ["secret_token"]}))

# should raise exception that the backend parameters are not used
session = CachedSession('my_cache',  backend=my_backend_instance,  backend_parameters={"ignored_parameters": ["secret_token"]}))

Workarounds
Yes,  the user who constructs the backend can pass the parameters there and not to the session.

While this would work for the ignored_parameters param, it is skipping the work done in the constructor,
so passing include_get_headers or cache_name will not be set to their correct instance variables (match_headers and name, respectively)

One way around that would be to handle the deprecated include_get_headers kwarg via a property, and change BaseCache.name to BaseCache.cache_name. If that sounds reasonable to you, here's a PR for that: #447

I'll close this for now since I think that PR mostly address the issue, but you're welcome to open another issue if you have more ideas or suggestions. Thanks!


Add net-ingressv2 controller

This patch adds ingressv2 controller which creates Ingress v2 (HTTPRoute) from Knative Ingress.
The github action runs networking conformance tests but enabled
basic|grpc|hosts|timeout|websocket|ingressclass only.
The rest of tests will be enabled by TLSRoute support and Istio's bug fix in
the follow-up patch.
/cc @tcnghia @ZhiminXiang @markusthoemmes

Closing as we migrate test code like https://github.com/knative-sandbox/net-ingressv2/pull/8 instead of adding new controller.


Install failed 2019

Hey there,
I just trying to install vue-cli but he doesn't work.
Please check screenshot here - https://pasteboard.co/I7Gff6M.png

try sudo npm install -g @vue/cli


indent marks and highlights on blanklines and context highlight doesn't change

I'm seeing indent characters on blank lines and block highlights instead of simple line highlights. Also, the context highlight doesn't change at all. It just stays at the first level no matter where I am in the code.
Is this intended behavior? Here's neovim with treesitter and indent-blankline
https://user-images.githubusercontent.com/79408161/129454740-413297b3-f3d2-4e0d-92ef-8113baf0a31e.mp4
Here's VSCode in contrast.
https://user-images.githubusercontent.com/79408161/129454749-6c2a60d1-6e08-4e44-a61c-9e52216fb6c8.mp4

The first issue you are having, the weird highlight on blanklines, is a bug in Neovim. There is an issue open for indent-blankline here #59, which has a workaround to fix it for now.
The second issue, that the context doesn't update, is because you have to set the patterns that you want to see.
Take a look at :help g:indent_blankline_context_patterns
For your example, you probably want to add for and ^if.


Support for multiple indexes in a vector store

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[ ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

[ ] I added new unit tests to cover this change
[ ] I believe this change is already covered by existing unit tests

Suggested Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

Sorry for the delay on this! Being totally honest, I'm not sure this will get merged (or at least not anytime soon).
I really appreciate the effort to get this working. Not 100% sure I agree with the implementation just yet, but also, nothing wrong with installing/maintaining your fork if you need this functionality.
For transparency, we are currently focusing on some multimodal refactors that we really need to get in first


server: remove registered userdata when cleanup an account

Description
This PR fixes the leftover of userdata when delete an account

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6576

@blueorangutan test

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-7180)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48649 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7777-t7180-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_list_vms_metrics_admin
Error
3610.18
test_metrics_api.py

test_list_vms_metrics_history
Error
5.45
test_metrics_api.py

test_list_volumes_metrics_history
Error
5.55
test_metrics_api.py

test_01_migrate_VM_and_root_volume
Error
83.86
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
54.51
test_vm_life_cycle.py

@blueorangutan test

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-7193)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7777-t7193-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_migrate_VM_and_root_volume
Error
78.82
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
52.34
test_vm_life_cycle.py

@blueorangutan test keepEnv

will test manually, but maybe we should have a cleanup marvin test (for accounts but also domains)?


Website [Components Overview/Gallery] Create thumbnail illustrations

Objective
Shixie created content for the following pages, and the overview pages need to include the following component information for both the Table list view and Gallery view.

Card in card
Carousel
Content group – banner
Tab extended
Tab extended with media

Task

[x] Add the descriptions and links of the new components to the Table list
[x] Add the new components thumbnail illustrations to the Gallery view
[x] Create PR and review with designers
[x] Finalize the designs

Acceptance criteria

[ ] New information and illustrations are live on the website

PR opened.


New initializer for drawing the grid in a specific size

moved grid cell generation code to a static function on the Generator struct.
Added initializer and relevant functions to fit the HexGrid into a HexSize.

[Edited to remove commit message from already merged commit.]

This is a draft because it includes #11, so that'll need to get merged before this can be reviewed on its own.

So far it looks fine. Would you mind to add also tests for newly introduced fitGrid() function?

Yes! I will add some tests in the next few days. 💯

@fananek This is ready for review again.
I added a test with a few values.
I also fixed a bug in updatePixelDimensions() where a minimum X or Y value might be greater than zero, so zero was reported as the minimum incorrectly. This was happening with triangle grids where the orientation was .flatOnTop. I didn't write a test for it, but I could imagine that as a nice additional enhancement. There are probably a lot of edge-case values we could (should?) add to the test suite.
As an aside, (and this deserves it's own issue, which I'll be adding later), I don't think the rectangle style grid creation functions are correct. I haven't looked into it yet, but you can see the problem more easily now in my SKHexGrid project.

Note that the head of SKHexGrid is broken unless you use this branch for its package dependency (which you can do by dragging a checkout of this branch into the project).


Cannot use symphonia ReadOnlySource due to no seek support

I'm trying to run a basic scenario of playing an MP3 stream from network by using a ReadOnlySource from symphonia.
This is my current usage:
use rodio::decoder::Decoder;
use rodio::OutputStream;
use symphonia::core::io::{MediaSourceStream, ReadOnlySource};

fn main() {
    let (_stream, stream_handle) = OutputStream::try_default().unwrap();
    let url = "http://example.com/stream.mp3";
    let response = reqwest::blocking::get(url).unwrap();
    let ros = ReadOnlySource::new(response);
    let source = MediaSourceStream::new(Box::new(ros), Default::default());
    let decoder = Decoder::new(source).unwrap();
    let sink = rodio::Sink::try_new(&stream_handle).unwrap();

    sink.append(decoder);
    sink.set_volume(1.0);
    // ...
}

While this does compile, it fails with:
$ cargo run
thread 'main' panicked at /home/yuval/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rodio-0.18.1/src/decoder/wav.rs:185:48:
called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "source does not support seeking" }

What would be the right way to use a non-seeking source? Ideally would like to use any available pre-existing traits from symphonia/rodio, but can also implement any custom traits as necessary.

That's actually a different kind of seek :)
The problem is your MediaSourceStream does not implement the right IO traits. Instead of fixing that you might be better of using something like: https://github.com/aschey/stream-download-rs
If you want to do this yourself take a look at what the decoder needs. Basically you'll have to write a struct that wraps the reqwest output and implements the Read and Seek traits while it is also Send and Sync. Thats not easy as you want to download while playing so you need multiple threads.
Ive been working on something like this myself but its not fully done yet

@dvdsk thanks for the quick response! Would stream-download-rs be the right approach even if I'm doing blocking IO / threads? Generally speaking I don't require async, but I do want the easiest interface for hooking up a stream to rodio.
I've bumped into the recommendation in #439 but minimp3 seems to be a rather broken approach.

I recommend you read through https://tokio.rs/tokio/topics/bridging. Almost all of rusts io-libs (reqwest::blocking in your code snippet above does the same as described in the article above. ) are async under the hood, even if the provide a blocking API. Once you get the whole bridging async and non-async code bit it isn't a big deal anymore.

Appreciate the clarification, indeed stream-download-rs does the job and has great useful examples.


WIP: Add support for Phi-2 via Ollama

This is a rework of https://github.com/continuedev/continue/pull/699 to use preview instead of main.
I've followed the steps here, though skipping modelData.ts changes as noted here.
As for prompts (in index.ts), I'm not sure what your preference is. Was thinking about adding to this block vs creating new prompt type or re-using one. Thoughts on this?

All looks good, thank you! As for prompt type, I've not actually used phi2 before so would defer to you to verify this, but it looks like the model expects a prompt template that is different from any of the others that we have already implemented. If this is right, then we should add the chat template here and edit template here. Happy to make this change if it's easier, lmk!

I took a stab at adding the chat/edit templates. For Chat, I tried to use a phi-2 specific prompt, whereas for Edit, I reused the Simplified prompt. (In the docs for Phi-2 the code usage expects to be completion of code described in comment, but I think simplified works better with the arbitrary highlighting context. Thoughts?

I think this sounds good as a start, and if response quality ends up saying otherwise after a bit of usage then it will be no problem to make the adjustment. Thanks for such a comprehensive PR!


LeftIcon Crashes Xaml Previewer

I had a typo in the LeftIcon property and it crashed the xaml previewer. I assume because there is no exception handling in there =]

Possibly not, I'm also open to PR if anyone wants to improve the library further. I think this would be small change to implement some better exception handling.
Although within the code I am checking the identifier:
 int identifier = Context.Resources.GetIdentifier(                             entryExt.LeftIcon,                             "drawable",                             PackageName);                         if (identifier != 0)                         { // Do something with the image if it exists }
By the way the Xamarin Live Preview is as bugger as heck, so the issue could lay in that as well, but I don't use it anymore.

Thanks,
Are you open to PRs for feature changes? Specifically, I would like to change the interface of IconLeft to : Icon + IconLocation (which would be an enum of Left or Right).
Monte
From: Leonard Harris<EMAIL_ADDRESS>Reply-To: LeoJHarris/EnhancedEntry<EMAIL_ADDRESS>Date: Monday, August 6, 2018 at 1:54 PM
To: LeoJHarris/EnhancedEntry<EMAIL_ADDRESS>Cc: Monte Hansen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [LeoJHarris/EnhancedEntry] LeftIcon Crashes Xaml Previewer (#10)
Possibly not, I'm also open to PR if anyone wants to improve the library further. I think this would be small change to implement some better exception handling.
Although within the code I am checking the identifier:
int identifier = Context.Resources.GetIdentifier( entryExt.LeftIcon, "drawable", PackageName); if (identifier != 0) { // Do something with the image if it exists }
By the way the Xamarin Live Preview is as bugger as heck, so the issue could lay in that as well, but I don't use it anymore.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yup that would be fine. Create a branch for this. PR once that's done. Ill review and merge afterwards.

Last I was at with this lib I was working on a toggle for password between show and I hide and I have been meaning on that which might do some additional stuff on that this weekend coming

Hi there, I noticed the project was not building, there was a reference to an old version of Xamarin.Forms.<IP_ADDRESS>4934 in the SampleApp.Android.csporj. I have resolved the issue and also updated to latest Xamarin.Forms.<IP_ADDRESS>7729
You can do a fetch and pull on the repo.

Yeah I noticed that too. Thanks I will pull again.
From: Leonard Harris<EMAIL_ADDRESS>Reply-To: LeoJHarris/EnhancedEntry<EMAIL_ADDRESS>Date: Tuesday, August 7, 2018 at 3:17 PM
To: LeoJHarris/EnhancedEntry<EMAIL_ADDRESS>Cc: Monte Hansen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [LeoJHarris/EnhancedEntry] LeftIcon Crashes Xaml Previewer (#10)
Hi there, I noticed the project was not building, there was a reference to an old version of Xamarin.Forms.<IP_ADDRESS>4934 in the SampleApp.Android.csporj. I have resolved the issue and also updated to latest Xamarin.Forms.<IP_ADDRESS>7729
You can do a fetch and pull on the repo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Cool any questions or issues let me know. Thanks


[🐛] illegal callback invocation from navite module when tap twice by photo on iOS

Description
Hi there!
Thank you for this awesome library, but I found a small issue.
When the user open gallery with photos by launchImageLibrary method and tap twice by any photo, the red screen with error will appear.
The full error message is: illegal callback invocation from navite module. This callback type only permits a single invocation from native code.
I have a custom button, there is a code below:
const DEFAULT_OPTIONS = {
  quality: 1,
  cameraType: 'back',
  mediaType: 'photo',
  allowsEditing: false,
  storageOptions: {
    skipBackup: true,
    path: 'images',
    waitUntilSaved: true,
    cameraRoll: false,
  },
  noData: true,
};
const someImagePickerCallback = async () => {
  ... some code here
};

<Button
  onPress={() => {
    ImagePicker.launchImageLibrary(DEFAULT_OPTIONS, someImagePickerCallback)
  }}
/>

How to repeat issue and example

Create a Button with onPress handler
inside onPress should call ImagePicker.launchImageLibrary (like code above)
gallery with photos will appear
tap twice to any photos inside this gallery
see red screen with error, which I described above

Additional Information

Image Picker version: ^2.3.1
React Native version: ^0.63.3
Platform: iOS
Development Operating System: MacOS
Dev tools: Xcode Version 12.2

If you need more info please let me know.
Thank you!

Able to reproduce on the following:
React Native: v0.61.0
Image Picker: v3.1.3
iOS: v14.2

Able to reproduce on the following:
React Native: v0.61.0
Image Picker: v3.1.3
iOS: v14.2

Same issue

Same issue

Same issue

Same issue

Any update here?

getting the same issues, need some solution urgently...

Same issue 💀

Same issue

Can reproduce in
<EMAIL_ADDRESS><EMAIL_ADDRESS>

same

i do not let user to click UI button twice but the bug still happens
It happens when user double clicking in the native gallery cause picker closes some time later after photo select

You can fix ios "illegal callback invocation from navite module" as i suggest here


FEATURE REQUEST: Location Data

I have read everything I can and I see that this was never implemented (in an automated way).  This is a huge deal for me and I want to help but I am still in the VERY early stages of learning programming and this beautiful program is far above me.  But, I wrote a PowerShell program that reports the devices location every 3 seconds and I would live to add that to the meshcentral installer so that the device (at least windows for now) will report its location or at least a close location with IP decoding if the GPS is not implemented.  How can I/We help get this option implemented?

are u talking about location data in the android app? as android cant run powershell.
also this is the android app repo, not the windows agent
but you can already run location in the console tab of a device and it uses ipinfo.io to get details about the ip and location and returns a JSON value for you

Dang it... Sorry about that.


Add PR write permissions to the comment bot

This is required to post a comment after the latest changes in GH api.

The comment job runs from the context of the main branch, so this has to bee merged before it can be properly tested


Where can I get the data?

Where can I get below files?
'data_file': './downsamp_1x_sel.npy',
'attr_file': './wforms_table_sel.csv',

Or can I get an access to the sample of the data so that I can have a glimpse into how data look like?
Thank you for sharing your works in public!

For the purpose of debugging, I made a hot fix regarding this issue as below -

prepare for waveforms file and save it as .npy file
prepare for the corresponding metadata.csv file as well

Note that this metadata should include columns of "mag", "dist", "vs30"
Which respectively stands for source_magnitude, distance between source and station, and vs30 information

Since my purpose is fulfilled,  closing the issue.


[BUILD] Use right branch when checking against Hive

Right now we always run hive tests in branch-1.4 PRs because we compare whether the diff against master involves hive changes. Really we should be comparing against the target branch itself.

Merged build triggered.

Merged build started.

Test build #34142 has started for   PR 6629 at commit 450fbbd.

Alright, tested this in #6630 I'm merging this.

LGTM.

Test build #34142 has finished for   PR 6629 at commit 450fbbd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


Delete explore.ipynb

We've now incorporated explore.ipynb into https://github.com/alan-turing-institute/plankton-dsg-challenge/blob/main/notebooks/1_explore_catalog.ipynb, so suggest we remove it. What do you think @reblackwell, @acocac?

Nice work.


Updated [dev] dependencies to match nomad-lab.

Relaxed/updated required package versions of dependencies and infrastructure in pyproject.toml to match nomad-lab.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.176%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
6324

Relevant Lines:
7172

💛  - Coveralls


feat: add ignore_tags option

Resolves (#36)
Description

As discussed in #36, added ignore_tags option.
Motivation and Context

Sometimes users want to carry over commits instead of dropping them as skip_tags option does.
How Has This Been Tested?

Just tested in my local environment.
Although I tried to add tests in changelog.rs and integration_tests.rs, I thought it's impossible to test ignore_tags there.
I'd like to discuss in this PR a way to add automated tests.
Screenshots / Output (if appropriate):
$ git clone git@github.com:kenji-miyake/git-cliff.git
$ cd git-cliff
$ cargo run | tail -n 30
(omitted)
## [0.1.0-beta.2] - 2021-06-14

### Bug Fixes

- Install musl-tools for musl builds

$ git checkout add-ignore-tags
$ sd 'ignore_tags = ""' 'ignore_tags = "v0.1.0-beta.2"' config/cliff.toml
$ cargo run | tail -n 30
(omitted)
## [0.1.0-beta.3] - 2021-06-14

### Bug Fixes

- Install musl-tools for musl builds

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[ ] Refactor (refactoring production code)
[ ] Other

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Tentatively, I've added a test using GitHub Actions. ee85a9b988f6818cecccbd0ecf19aa143f67b5a9
@orhun Do you have any other ideas to test this?

Tentatively, I've added a test using GitHub Actions. ee85a9b @orhun Do you have any other ideas to test this?

Absolutely liked this approach. I think we can leave it as is, just one suggestion: maybe rename the folder as fixtures and also rename the workflow to something like test-fixtures? I'm not sure though.
About the unit tests, I think I can work on that after merging the PR.


⚠ RPC server - Arbitrum Rinkeby has degraded performance

In fb03d2d, RPC server - Arbitrum Rinkeby ($ARBITRUM_RINKEBY_RPC_URL) experienced degraded performance:

HTTP code: 404
Response time: 181 ms

Resolved: RPC server - Arbitrum Rinkeby performance has improved in e5b6e08.


VSCode doesn't automatically pick up on the virtual environment

The .vscode/settings.json is intended to automatically pick up on the virtual environment that has been created.
However, a test is currently running that will ignore the setting there, for more information: https://github.com/microsoft/vscode-python/wiki/AB-Experiments
To make sure the template works properly opt out of the experiment as follows:
You can opt out of any experiment by opening the user settings.json file (View > Command Palette… and run Preferences: Open Settings (JSON)) and set the “python.experiments.optOutFrom” setting to [“All”], or to specific experiments you wish to opt out from.

This issue has been solved with the newest vscode versions where the python path has been standardized.


Could not resolve source if working dir is outside of template Path

Fixes #27
If you Invoke-Plaster with a working directory outside of the TemplatePath, Plaster does not Join the TemplatePath and Folder to be recursed. So when it resolves the path, it resolves to the current working directory and it errors because it can't find the path.
The fix Joins the TemplatePath and Source Relative Path Parent.

Hi @gerane, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Oh wait, was 465 supposed to change, let me recheck that.

I think that one should still be
$parent = Split-Path $parent -Parent

I haven't looked to see how you are handling the Filter, so wanted to make sure that goes back to parent. I assume this is covering things like Dir\**\Dir or Dir\*.txt
What exactly would the '?' be for the filter?

I guess that would also mean you are only covering a depth of one directory back, unless I am overlooking something outside of this function.
Dir\**\Dir\Dir or Dir\**\Dir\Dir\*.txt might not catch?

This function is currently limited to Foo\Bar\** and Foo\Bar\**\*.ps1xml.  It doesn't support arbitrary placement of **.  Do you think we need that?
The ? is one of the wildcard metacharacters along with * that you can use in the Get-ChildItem -Filter value.  The change looks good. I'll merge it in.

Ok, got ya, that makes sense.

And no, I don't think it needs anything like that.

I've tested latest Build and this is now working correctly.
Thanks.
Stefan

Thanks for verifying!


[WFCORE-3609]:Fix milliseconds format in configuration changes operation date

Displaying always the milliseconds for configuration changes operation dates
Jira: https://issues.jboss.org/browse/WFCORE-3609

Core - Full Integration Build 6700 outcome was FAILURE using a merge of 464ef7a06bf1e23cb632933ef1a0c8caf882d565
Summary: Tests failed: 1 (1 new), passed: 4265, ignored: 143 Build time: 01:49:02
Failed tests
org.jboss.as.test.integration.deployment.dependencies.ear.InterDeploymentDependenciesEarTestCase.testWithRestart: MgmtOperationException{operation={
    "operation" => "redeploy",
    "address" => [("deployment" => "app1.ear")]
}, result={
    "outcome" => "failed",
    "failure-description" => "WFLYCTL0441: Management operation failed: "WFLYCTL0441: Operation has resulted in failed or missing services
WFLYCTL0184:    New missing/unsatisfied dependencies:
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.START (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".moduleDeploymentRuntimeInformationStart, service jboss.deployment.unit.\"app2.ear\".WeldEndInitService, service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".deploymentCompleteService]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInstantiator (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.START]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInterceptorBindingsService (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInstantiator]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".deploymentCompleteService (unavailable) dependents: [service jboss.deployment.unit.\"app2.ear\".deploymentCompleteService]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".jndiDependencyService (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.START, service jboss.deployment.unit.\"app2.ear\".WeldStartService]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".weld.weldClassIntrospector (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".ee.ComponentRegistry]
      service jboss.deployment.unit.\"app2.ear\".WeldStartService (unavailable) dependents: [service jboss.deployment.unit.\"app2.ear\".weld.weldClassIntrospector, service jboss.deployment.unit.\"app2.ear\".WeldEndInitService, service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInterceptorBindingsService, service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".weld.weldClassIntrospector, WFLYCTL0208: ... and 4 more ]
      service jboss.deployment.unit.\"app2.ear\".weld.weldClassIntrospector (unavailable) dependents: [service jboss.deployment.unit.\"app2.ear\".ee.ComponentRegistry]
      service jboss.naming.context.java.jboss.exported.app2.hello.\"LogAccessBean!org.jboss.as.test.integration.deployment.dependencies.ear.LogAccess\" (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".jndiDependencyService]
"
MgmtOperationException{operation={
    "operation" => "redeploy",
    "address" => [("deployment" => "app1.ear")]
}, result={
    "outcome" => "failed",
    "failure-description" => "WFLYCTL0441: Operation has resulted in failed or missing services
WFLYCTL0184:    New missing/unsatisfied dependencies:
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.START (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".moduleDeploymentRuntimeInformationStart, service jboss.deployment.unit.\"app2.ear\".WeldEndInitService, service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".deploymentCompleteService]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInstantiator (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.START]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInterceptorBindingsService (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInstantiator]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".deploymentCompleteService (unavailable) dependents: [service jboss.deployment.unit.\"app2.ear\".deploymentCompleteService]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".jndiDependencyService (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.START, service jboss.deployment.unit.\"app2.ear\".WeldStartService]
      service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".weld.weldClassIntrospector (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".ee.ComponentRegistry]
      service jboss.deployment.unit.\"app2.ear\".WeldStartService (unavailable) dependents: [service jboss.deployment.unit.\"app2.ear\".weld.weldClassIntrospector, service jboss.deployment.unit.\"app2.ear\".WeldEndInitService, service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".component.LogAccessBean.WeldInterceptorBindingsService, service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".weld.weldClassIntrospector, WFLYCTL0208: ... and 4 more ]
      service jboss.deployment.unit.\"app2.ear\".weld.weldClassIntrospector (unavailable) dependents: [service jboss.deployment.unit.\"app2.ear\".ee.ComponentRegistry]
      service jboss.naming.context.java.jboss.exported.app2.hello.\"LogAccessBean!org.jboss.as.test.integration.deployment.dependencies.ear.LogAccess\" (unavailable) dependents: [service jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".jndiDependencyService]
",
    "rolled-back" => true
}}
	at org.jboss.as.test.integration.management.ManagementOperations.executeOperation(ManagementOperations.java:67)
	at org.jboss.as.test.integration.management.ManagementOperations.executeOperation(ManagementOperations.java:37)
	at org.jboss.as.test.integration.deployment.dependencies.ear.InterDeploymentDependenciesEarTestCase.testWithRestart(InterDeploymentDependenciesEarTestCase.java:176)
------- Stdout: -------
 [0m11:04:19,723 INFO  [org.jboss.as.repository] (management-handler-thread - 2) WFLYDR0001: Content added at location /store/work/tc-work/29472398f1ae6497/full/testsuite/integration/basic/target/wildfly/standalone/data/content/1b/3344dc604016430ffceb5f61b23db63397fc1d/content
 [0m [0m11:04:19,724 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-6) WFLYSRV0027: Starting deployment of "app2.ear" (runtime-name: "app2.ear")
 [0m [0m11:04:19,727 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-1) WFLYSRV0207: Starting subdeployment (runtime-name: "hello.jar")
 [0m [31m11:04:19,727 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 2) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "app2.ear")]) - failure description: {
    "WFLYCTL0412: Required services that are not installed:" => [
        "jboss.deployment.unit.\"app1.ear\".deploymentCompleteService",
        "jboss.deployment.unit.\"app2.ear\".PARSE"
    ],
    "WFLYCTL0180: Services with missing/unavailable dependencies" => [
        "jboss.deployment.subunit.\"app2.ear\".\"hello.jar\".PARSE is missing [jboss.deployment.unit.\"app1.ear\".deploymentCompleteService, jboss.deployment.unit.\"app2.ear\".PARSE]",
        "jboss.deployment.unit.\"app2.ear\".PARSE is missing [jboss.deployment.unit.\"app1.ear\".deploymentCompleteService]"


Any plans to use XML as a desktop layout?

layout use xml

Why? It defeats the whole point I think.

Why? It defeats the whole point I think.

Yeah... this is Jetpack Compose. The entire reason it was created is to avoid xml layouts and define UI using a declarative style in code.

Yeah... this is Jetpack Compose. The entire reason it was created is to avoid xml layouts and define UI using a declarative style in code.

As the progenitor of Compose, I can say that avoiding XML was not "the whole point".  The original syntax I proposed for invoking composables actually looked a lot like XML embedded into Kotlin.  The primary objective was (and still is) to encourage a declarative API instead of an imperative one and to ensure top-down data flow.
Most people, when they request XML, are requesting it because they've been taught that "separation of concerns" is a best practice.  They are correct, you do want to separate concerns, but they've erroneously conflated distinct technologies with distinct concerns.  Maybe I'll write a post with my own thoughts on the topic at some point, but in the mean time, this author does a pretty good job: https://medium.com/madhash/rethinking-separation-of-concerns-with-react-7e5de1b5c0f7
All this is to say, no, we don't intend to add XML because the Kotlin DSL we use already adequately provides the separation of concerns we're trying to achieve.

As the progenitor of Compose, I can say that avoiding XML was not "the whole point".  The original syntax I proposed for invoking composables actually looked a lot like XML embedded into Kotlin.  The primary objective was (and still is) to encourage a declarative API instead of an imperative one and to ensure top-down data flow.
Most people, when they request XML, are requesting it because they've been taught that "separation of concerns" is a best practice.  They are correct, you do want to separate concerns, but they've erroneously conflated distinct technologies with distinct concerns.  Maybe I'll write a post with my own thoughts on the topic at some point, but in the mean time, this author does a pretty good job: https://medium.com/madhash/rethinking-separation-of-concerns-with-react-7e5de1b5c0f7
All this is to say, no, we don't intend to add XML because the Kotlin DSL we use already adequately provides the separation of concerns we're trying to achieve.

@jimgoog the link that you shared (https://medium.com/madhash/rethinking-separation-of-concerns-with-react-7e5de1b5c0f7) is behind a paywall. Is there an alternative link that you can share?

@jimgoog the link that you shared (https://medium.com/madhash/rethinking-separation-of-concerns-with-react-7e5de1b5c0f7) is behind a paywall. Is there an alternative link that you can share?

Wow, since when did medium start putting up paywalls?  Terrible.
Thanks for the heads up, and thanks for finding the alternative source!

Wow, since when did medium start putting up paywalls?  Terrible.
Thanks for the heads up, and thanks for finding the alternative source!

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Was cluster removed?

Yes, It was removed years ago, but I don't remember why at this point. I think you can do everything and more with PM2 module nowadays. I might add PM2 to Hackathon Starter in the near future.

Sounds awesome! I first saw the native code for clustering, then i saw someone use throng saying it takes away all the pain and now we have pm2 , i had a look at it, seems like a very extensive lib, hopefully you are able to add it with the existing project


TSI socket does not obey read limits or write buffer high-watermarks

The current TSI socket implementation has the following problems:

It uses a default max frame size - 1MB defined in gRPC ALTS TSI implementations. It is considered too large and also inconsistent with SSL socket, which is 16KB.
TsiSocket doRead() does not obey read limits by doing an unbounded read from a raw socket.
TsiSocket doWrite() has the problems of 1) inefficient memory usage by protecting full input data into an internal buffer and 2) potentially losing the data stored in the internal buffer that has yet been flushed to the network.

F.Y.I. @htuch, @jiangtaoli2016, @antoniovicente

ALTS / TSI is for the most part only used by Google.  I assume your team will drive the fixes to this component.

While Google is the developer of ALTS, it's actually used by many GCP users, so anyone running Envoy on GCP probably has some interest in this bug resolution.


How to use with rocket framework

Is your feature request related to a problem? Please describe.
unable to use socketio with rocket server.How to use socketio with rocket server?
Describe the solution you'd like
provide example code to use socketio with rocket server.
Describe alternatives you've considered
Unable to find any alternative.

Currently, Socketioxide works with hyper & hyper based web servers like Axum, Warp, Salvo etc.
So I would recommend you to use them for working with socketioxide.

I might work on an adapter based on the answers on this thread: https://github.com/rwf2/Rocket/discussions/2650

I might work on an adapter based on the answers on this thread: rwf2/Rocket#2650

According to the answer of the maintainer of the lib, we are going to wait for the release of rocket 0.6. When rocket will support tower layers. We will add a corresponding example.


DNS and LB in different accounts

Hi!
I have the requirement to actually have a centralized DNS in one AWS account, and the load balancer in another account.
With the current approach it seems that I can have only one account configured.
Is there a workaround to specify two access keys for DNS and LB separately?
Thanks a lot in advance.
Best Regards,
Sebastian

Not without manually editing the code. For now this issue is probably a wontfix.

@kickino my 2 cents: I haven't tried this yet, so I don't know if it works with Route 53 in particular, but it is possible to delegate certain permissions cross-account. Using this, you may be able to get access to the DNS and LB using the same account.


Methods and test to email GitHub user on sign up.

This addresses the sign up part of #529.
Signed-off-by: Jason Dossett<EMAIL_ADDRESS>

Current coverage is 98.26% (diff: 100%)

Merging #533 into master will increase coverage by 0.01%

@@             master       #533   diff @@
==========================================
  Files            40         40
  Lines          1032       1038     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1014       1020     +6
  Misses           18         18
  Partials          0          0

Powered by Codecov. Last update 2e1763f...97557ca


Adding Tests

Closes #4
This introduces a pytest suite of tests along with some configuration. So far, a number of unit tests have been written to cover all of the AylaApi methods that do not make any external web request. More tests can be added to this PR, or a new one could be created in the future to extend this baseline.
I'd also be happy to integrate the tests into a new github actions workflow to run on pull requests, however, I lack the permissions. Proper authentication/integration tests would also likely require a valid Shark login to be stored as a repository secret.

@JeffResc looks good to me but since you had been working more closely with the tests could you take a look as well?

Hi @travipross - Thanks for the PR, I really appreciate it! I don't have time to review this right this second, but I just wanted to reach out and say thank you. I should have time later this week and definitely by the end of this weekend to give this a look.

No rush on my end! I'll probably keep tinkering away until then

We're a little lacking on coverage, but it's definitely a start! Thanks @travipross 👍


change to html

Coverage increased (+0.02%) to 93.595% when pulling 4d1e25dcbdbe7c3e147b075427bf13ce438f14a3 on Zhangxinguo:master into 52b870ca86fdb8b704d584f00a9f788286a4cbf0 on dangdangdotcom:2.0.6.

Coverage increased (+0.02%) to 93.595% when pulling bbdf3d0200a24e462a08f4db235cb276dfce3f35 on Zhangxinguo:master into 52b870ca86fdb8b704d584f00a9f788286a4cbf0 on dangdangdotcom:2.0.6.


Added Support for ReasonML

Added support for ReasonML including some new css classes for ReasonML specific syntax.
Also added a variant of the One Dark Syntax theme with support for the additional reason syntax (chose to add a new style as I've changed some of the styles in the existing Atom One Dark to work nicer with the new classes)

Hi,
I don't mean to put pressure on anyone, I know how much work it is to support OSS, but was just curious if there is anyone picking up these PRs?
Thanks for your time,
Gidi

Obviously as the author of this code I can't alleviate security concerns, but perhaps if you explain what sort of security concerns you have encountered in the past I can comment on the issue?

Obviously as the author of this code I can't alleviate security concerns, but perhaps if you explain what sort of security concerns you have encountered in the past I can comment on the issue?

Oh, I seem to recall there being possible XSS issues with RegExp in this project... but I might be mistaken.

Interesting, I'm un familiar with a Regex based XSS in JS, so can't say...
All I know is that I have no intention of committing a possible XSS 🤷♂

All I know is that I have no intention of committing a possible XSS 🤷♂

heh, it's not you I'm worried about :)

Haha good to know :)
I thought the concern was with the Regexs I had added ^_^
Where is your concern then?

Where is your concern then?

Where is your concern then?

Sorry for not being clear.
If I'm recalling correctly, in the past, there was an attack on a RegExp within this project (again, I might be thinking of a different project!). My concern is that any RegExp could be attacked, so we need folks to be checking them closely (or avoided if at all possible).

Ah I see. That would be an interesting thing to look at, if you find a reference to the original issue I'm happy to see if I can identify a vulnerability in how I structured the Regexs, but without context it's hard to tell.

The regex security note is interesting. I'd also like to know what exactly the issue was so I can check the regexes in #1798.

Apologies, I think I got confused with a different open source project about the regexes.

Brilliant, in that case, will we be merging the PR? 😁

Ok, let’s get this shipped. Can you please resolve the merge conflict?

I will be able to next week, I'm afraid I'm traveling over the weekend. I'll try and get this sorted out on Tuesday.
Thanks for approving the PR 😁

No problem! Thanks for doing the hard work. If I can jump on a computer, I’ll try to do it. But also unlikely till Monday.

Haha brilliant, its a race.
We'll see who gets there first. 😁


Support #[pyfunction] inside #[pymodule]

It struck me as strange that #[pyfn] exists at all when it should be possible to use #[pyfunction] inside pymodule.
This PR adds exactly that. Maybe this is a road to deprecating / removing #[pyfn] so as to make the overall API simpler? (Just one #[pyfunction] attribute instead of two.)
TODO:

[ ] Update documentation

one reason to have separate #[pyfn] and #[pyfunction] attributes is for when you want a function that's not automatically added to a Python module.

#[pymodule]
fn pyfunction_module(_py: Python, module: &PyModule) -> PyResult<()> {
    #[pyfunction]
    fn foobar() -> usize {
        101
    }

    Ok(())
}

Hmm... :thinking:
It's confusing for me that pyfunction automatically adds itself to module.
I think we need alternative syntax if we want to do this kind of automatic module declaration.
E.g.,
#[pymodule]
mod pyfunction_module {
    #[pyfunction]
    fn foobar() -> usize {
        101
    }
}

one reason to have separate #[pyfn] and #[pyfunction] attributes is for when you want a function that's not automatically added to a Python module.

Is there any case where you would write a #[pyfunction] inside a #[pymodule] but not want it automatically added to a module?
This PR doesn't change the fact that #[pyfunction]s outside of a #[pymodule] still need to be manually added.

I think we need alternative syntax if we want to do this kind of automatic module declaration.

I can add mod syntax if that's preferable.
However, my original motivation is that we don't seem to need two differently-named attributes #[pyfn] and #[pyfunction].

@kngwyu I see what you mean by automatic adding being confusing. I realise now this PR is probably a breaking change, as this is already valid code, but does not add foobar to the module:
#[pymodule]
fn pyfunction_module(_py: Python, module: &PyModule) -> PyResult<()> {
    #[pyfunction]
    fn foobar() -> usize {
        101
    }

    Ok(())
}

I think the solution is instead to add an attribute #[add_to_module(module)]. I'll rework this PR later today.

I see what you mean by automatic adding being confusing. I realise now this PR is probably a breaking change, as this is already valid code, but does not add foobar to the module:

I mean that few users expect that the generated code uses unrelated local variable module.
Not about the breaking change.

Does this seem better?

Hmm... :thinking:
I'm sorry but I feel diffult to understand why it's better.

Ok 👍
Let's pull back on this idea for now. I still think it would be potentially worth having just #[pyfunction] so that users don't have to learn two different attribute syntaxes for almost exactly the same thing. I'll leave that in #694 .


Fix YAML related tests

Symfony dropped the implicit conversion so we need to do it by ourselves 😉

@Ocramius fixed, thanks

Green! :ship:


[FLINK-4213] [gelly] Provide CombineHint in Gelly algorithms

VertexDegrees has changed from using a ReduceFunction to using a GroupReduceFunction as in directed TriangleListing.

Looks good to me.
How much faster does it get with the hash combiner?

Depends how much faster we can make sorting in the NormalizedKeySorter :)
I'll keep working on a comparison, I've been running into the deadlock in FLINK-4163.

Does the deadlock occur only with the combiner, or also with the sorter?

Yes, and the job plan attached to the ticket shows the only combine as a "Sorted Combine" (from distinct).


Switch kube-proxy from iptables mode to ipvs mode

Kubernetes v1.11 marked kube-proxy IPVS mode as GA. Evalute its readiness

https://github.com/poseidon/terraform-render-bootkube/pull/84
Kubernetes blog
Calico v3.2 IPVS support

I've found a number of issues with kube-proxy IPVS mode. It is not yet ready for use (I will note IPVS itself has been ready since 2004).
These issues are independent of cloud provider and CNI provider, pointing a finger the underlying iptables rules. Even with IPVS mode, both CNI plugins and kube-proxy manage iptables rules.
Service IPs inaccesible
Cluster components cannot access the Kubernetes apiserver via its Service IP (<IP_ADDRESS>). Here, kube-proxy is just one example service IP, but the first sign of trouble.
Service IP unavailable from pods on workers (e.g. flannel, nginx-ingress, calico).
# kube-state-metrics
F1023 01:03:05.022783       1 main.go:112] Failed to create client: ERROR communicating with apiserver: Get https://<IP_ADDRESS>:443/version?timeout=32s: dial tcp <IP_ADDRESS>:443: connect: connection refused

Service IP unavailable from worker nodes.
curl https://<IP_ADDRESS>:443
curl: (7) Failed to connect to <IP_ADDRESS> port 443: Connection refused

Notably, the kube-apiserver pod (i.e. IPVS real server) is routable.
Prot LocalAddress:Port Scheduler Flags
  -> RemoteAddress:Port           Forward Weight ActiveConn InActConn
TCP  <IP_ADDRESS>:443 rr
  -> <IP_ADDRESS>:6443           Masq    1      1          0

curl -k https://<IP_ADDRESS>:6443  -> JSON 401 Unauthorized (expected)

Observations:
Seems to be related to pods with hostPort 80 and 443 running on the affected nodes (e.g. nginx-ingress). Removing the nginx-ingress deployment, those hosts (and pods on them) can access apiserver via the service IP.
Issues:

IPVS with hostPort: https://github.com/kubernetes/kubernetes/issues/66103 (open)

https://github.com/kubernetes/kubernetes/pull/66590

https://groups.google.com/forum/#!topic/kubernetes-sig-network/Hw9mmMoF_88

From Google Groups:

On further investigation, this turns out to be basically a bug in the
CNI HostPort plugin; it was assuming that "--dst-type LOCAL" would cause
it to only receive packets addressed for the node's "real" IP addresses,
but at least with some CNI plugins, it ends up matching service IPs as
well, and so the HostPort processing was intercepting packets that it
didn't want. If this bug wasn't there then it wouldn't matter what order
the kube-proxy and CNI rules were added in because they wouldn't ever
match the same packets.

NodePort no longer accessible from node localhost
kube-proxy IPVS mode continues using iptables to setup NodePort Services. Creating a NodePort service with kube-proxy in iptables mode means the node port was accessible from a node, but its no longer is with IPVS mode.
ssh core@NODE
curl <IP_ADDRESS>:30010  (no longer works with IPVS mode)
curl publicIP:30010    (still works)

Notably, kube-proxy logs show the NodePort is known.
# kube-proxy logs
I1022 02:22:31.581300       1 proxier.go:1657] Opened local port "nodePort for default/hello:http" (:30010/tcp)

Netstat shows the bound address on the host.
tcp6       0      0 :::30010                :::*                    LISTEN      -

Its a change in kube-proxy behavior. So maybe upstream ought to be informed.
kube-proxy spurious logs removing IPv6 address
kube-proxy IPVS tries to delete the IPv6 address on the interface it creates. IP parsing and address deletion is suspect.
E1023 01:32:19.750072       1 proxier.go:1591] Failed to unbind service addr fe80::d468:98ff:fe01:627f from dummy interface kube-ipvs0: error unbind address: fe80::d468:98ff:fe01:627f from interface: kube-ipvs0, err: cannot assign requested address

kube-ipvs0 interface always has MTU 1500
kube-proxy IPVS mode always creates a kube-ipvs0 interface with MTU 1500. I don't have clear evidence this causes problems, but the correct behavior is probably to detect the MTU of the default route's interface.

https://github.com/kubernetes/kubernetes/issues/68546

Filed the kube-proxy spurious logs removing IPv6 issue and found the source (though a solution might take different approaches). https://github.com/kubernetes/kubernetes/issues/70113


TimeSpan.Equals throws when passed value

When you pass any value that isn't another TimeSpan to TimeSpan.Equals it throws a JS error.
Reproduced here: https://deck.net/c801d809d6c8f68ef82213c1ab14f290
Expected Result
false

Actual Result
JS error

The issue has been fixed and merged upstream. It will make it to Bridge 16.5.0!


Feature/workflow api

Coverage increased (+1.31%) when pulling b988eb8ff036c9e70f1a17be9176784dc924f88a on feature/workflow-api into 54c1104cb1b100866b181e979aa663f9cc240124 on master.

Coverage increased (+1.31%) when pulling faf1dba6948e579a690fb576e6fe1ddfb8b958d6 on feature/workflow-api into 54c1104cb1b100866b181e979aa663f9cc240124 on master.


Download link not working

Azure Data Studio Version:
OS Version: macos

Steps to Reproduce:

Download link not working.

Does this issue occur when all extensions are disabled?: Yes/No

The links seem to work fine to me so I'm closing this, please provide the link that's not working and what error you're setting if you're still seeing this and we can investigate!


Remove dynamic library path from RenderToolbox3 "hints" struct.

Currently we specify platform-specific dynamic library path information as part of the RenderToolbox3 configuration.  These are initialized in InitializeRenderToolbox.m and appear in "hints" structs returned from GetDefaultHints().
It turns out these are not always necessary.  And when they are necessary, they are renderer-specific as well as platform specific.  So it doesn't make sense to put this configuration at the top level, for all of RenderToolbox3.
A better design would be to leave path configuration up to the individual renderer plugins.  Indeed, the required library path can often be chosen relative to the executable.  So renderer plugins can "just know" the relative path that they should use to find required libraries.

For Version 3, we are planning to put renderer binaries on our Archiva server.  We are also considering using Docker as an additional way to distribute binaries and associated configuration.
So Version 3 seems like a good time to revisit this question about library paths.

Closing this issue.  It should be addressed in RenderToolbox4:
https://github.com/RenderToolbox/RenderToolbox4


Allow BaseRequest subclasses to override empty value handling

This change introduces an empty_value property on the BaseRequest class, enabling subclasses to override the default value assigned to arguments when an empty value is encountered.
For backwards-compatibility, the existing empty string value remains the default, and an implementor would have to specifically override this in order to see a change in behaviour.
Resolves #1799

History behind the urls module is that it was meant as a compatibility for urllib between Python 2 and 3. Adding more differences between the built-in versions and these is not ideal, since I'd like to reduce the dependence on Werkzeug's versions over time.
If your project needs this level of special processing, and you don't want to write your own from scratch, Werkzeug is BSD-3-Clause licensed, you're welcome to copy the function along with the license and change it to use in your Request.args subclass.


#9 | + STDIN support for print command | #patch

merge #9

only works with backend+ui right now, see
https://github.com/mitsuhiko/dialoguer/issues/93

Issue that I raised was still not solved. Issue has been moved:
https://github.com/mitsuhiko/console/issues/76
It is probably an error with the tty (/dev/tty?) issue.
Thoughts: STDIN filedescriptor 0 instead of $(</dev/stdin)?