Single Route File

Description
Being able to define the entire routing of the app in a single file.

How about following design.
/pages/index/index.page.js
/pages/about/index.page.js
/pages/product/index.page.js
/pages/product-list/index.page.js
/routes.js

// /routes.js

export default {
  routes: [
    '/pages/index/index.page.js',
    '/pages/about/index.page.js',
    {
      path: '/pages/product/index.page.js',
      route: '/product/@id'
      /* Or a Route Function:
      route: pageContext => {
        // ...
      }
      */
    },
    {
      path: '/pages/product-list/index.page.js',
      route: '/products'
    },
  ],
  // By default all routes need to be listed in `/routes.js` (if `/routes.js` exists).
  // Set to `true` to allow routes to be skipped (we recommend against this).
  allowUnlistedRoutes: false
}

function Menu() {
  return <>
    <Link to="index" /> // =>
    <Link to="about" /> // =>
    <Link to="product" id={42} /> // =>
    <Link to="product-list" /> // =>
  </>
}

Open question: how to make it work with TypeScript? So that TypeScript complains upon <Link to="unknown-page" /> or <Link to="product-list" id={"42"} /> (because "42" is a string but should be a number).
I can see negative reactions about this design. Feel free to criticize.

One option could be to use a tagged template literal string. Which has typescript support. It would also allow to eliminate the documentation /  comment in the aforementioned example, since it would be more direct.
function Menu() {
  return <>
    <Link to=`/` />
    <Link to=`/about` />
    <Link to=`/product/${42}` />
    <Link to=`/products` />
  </>
}

I see there’s some precedence to the API that I suggested: https://solito.dev/usage/link#wrapper-components

Open question: how to make it work with TypeScript? So that TypeScript complains upon <Link to="unknown-page" /> or <Link to="product-list" id={"42"} /> (because "42" is a string but should be a number).

Does Solito has such TypeScript support?

One option could be to use a tagged template literal string.

So far, I can't see how TypeScript's template literal strings would help.
One aspect of Single Route Files that is interesting is that the user can change the URL without having to modify each link. That's why I'm leaning towards <Link to="product" id={42} /> . But I can see that to be a matter of taste and use case. Small apps don't need that.

Does Solito has such TypeScript support?

It doesn't seem like it. It simply replicates NextJS' API.

So far, I can't see how TypeScript's template literal strings would help.

On second glance, I think you're right. TypeScript Template Literal Types that I linked to are a different thing. What I had in mind - type checking inside tagged template literal strings -  is still an open TypeScript issue (not very likely to get implemented, it seems): https://github.com/microsoft/TypeScript/issues/29432

change the URL without having to modify each link

I see. I think the general web native way of doing it - and what Rails did - is to simply provide a re-route to the new URL.  That way, outdated links in ones app would work the same as the outdated links to one's page that had already been shared on the web: they would be re-routed to the new URL.

Open question: how to make it work with TypeScript? So that TypeScript complains upon  or <Link to="product-list" id={"42"} /> (because "42" is a string but should be a number).

Did some more research into this, since you mentioned it is a blocker.
In addition to pathpida, check out next-type-safe-routes or nextjs-routes or next-typed-routes for inspiration.
The API of next-type-safe-routes seems the nicest (clearest, most straightforward/intuitive, least boilerplate). The automatic route listing (route autocomplete) is quite nice.

next-type-safe-routes parses the /pages folder in your Next.js app and generates types for all the pages and API routes in the application. These types can then be used to ensure that you only link to pages (and only use API routes) that actually exists in your application.

due to the strictness, we can also determine which parameters are needed for dynamic routes.

So, the only issue with using either of those directly is that they all presume filesystem routing (being for NextJS).
Maybe typesafe-routes what you're looking for?
Actually, it turns out you can use TypeScript Template Literal Types to get type checking inside tagged template literal strings, like I  had in mind. This library does it, see the GIF animation in that repo.
As long as it is possible to wrap the  component that vite-plugin-ssr provides, so that a Solito.dev like library could be developed on top, for universal/crossplatform-app support. With the goal of having vite-plugin-ssr (Vite) instead of NextJS (Webpack) as the base for such crossplatform apps.

Neat. Indeed, infer with template literal types is a solution.
We can even make the route types defined by the user in route.ts available globally by using declare module (e.g. https://telefunc.com/typescript#getcontext).
I think we can make it work.
Although Route Functions routes cannot be typed, but that's expected.

As long as it is possible to wrap the component that vite-plugin-ssr provides

Yes, that's the idea. So far, I don't see a problem with that.

Came across this. Could be potential inspiration for typesafe routes.

solito’s useParam() hook takes in a parse() function to let you turn the string → number. i’ve found it to be nice for dealing with numbers and validating enums it comes with type safety + inference too: https://solito.dev/usage/params#parsing-values from Fernando's tweet

react-router-url-params is another one, for typesafe query parameters. It was made this summer.

My idea is that TypeScript for query params just works if we treat param serialization as implementation detail defined by the user.
// `order` is typesafe
<Link to="product-search" order={"desc"} />

// /routes.js

export default {
  routes: [
    {
      Page: '/pages/product-search.page.js',
      toUrl: ({ order }: { order: 'asc' | 'desc' }) => `/product/search?order={order}`,
      route: '/product/search'
    },
  ]
}

I'm a big fan of Tanstack React Location and upcoming Tanstack Router. I think it's API is quite well thought. See this single route file example from Tanstack Router: https://github.com/TanStack/router/blob/572318b1b132307be02857b97ae05b2040363ccf/examples/kitchen-sink/src/index.tsx#L91
I really like how React components can be used instead of file path as proposed in this issue. Also, pending state feature sounds incredible.

The API of React Location looks a lot like the API of (Remix and) React Router v6 :
https://gist.github.com/redbar0n/f6ec12264ff9d58e243cc516e4e3f41b?permalink_comment_id=4312122#gistcomment-4312122

The overall design is starting to crystalize (it also includes better support for nested layouts).
One open question: https://stackoverflow.com/questions/73957822/get-import-path-of-dynamic-import-as-typescript-string-type, in case someone knows this. I don't think it's possible, but who knows with TypeScript 😅.

blitz-js has another way to achieve typesafe routing which looks quite neat:
https://twitter.com/aleksandrasays/status/1559157742559825920?s=20&t=uaV2ruG_UcOlWxDwGhk9yQ

blitz-js has another way to achieve typesafe routing which looks quite neat:
https://twitter.com/aleksandrasays/status/1559157742559825920?s=20&t=uaV2ruG_UcOlWxDwGhk9yQ

👍 Neat idea to make the link target a TS object, so you can definition-jump directly to the route file. Neat.

@redbar0n Yes I'm also not too fond of their verbosity. While I share the sentiment to keep things succinct, I'm thinking multi-dimensional arrays are a bit too extreme, i.e. not explicit enough. Let's see if the solution I come up with is succinct enough (so far I think so).

Ok, excited to see how it will look. I wonder how much explicitness is needed if we can have some Convention over Configuration.

Coming from React Router I use their Javascript Route Definitions which allows me to dynamically create and pre-filter routes, and render navigation from the definitions.

For folks who need/want Single Route File, please PM on discord.

FFR, here is a thread with people who don't like file based routing: https://twitter.com/t3dotgg/status/1583285667768827904

I think SolidStart is taking a great approach with the dynamic <FileRoutes /> component https://start.solidjs.com/core-concepts/routing

I think SolidStart is taking a great approach with the dynamic <FileRoutes /> component https://start.solidjs.com/core-concepts/routing

Yeah, I agree, with one exception. To quote it:

Under the hood, SolidStart traverses your routes directory, collects all the routes, and makes them accessible using the  component. The  component only includes your UI routes, and not your API routes. You can use it instead of manually entering all your Routes inside the  component in root.tsx. Let the compiler do the boring work!

I think it makes more sense to expose the file routes through some other means than as a UI component. Maybe as a function (e.g. import getFileSystemRoutes() like the getRoute that next-type-safe-routes does).
You then use it to import the default routes derived from the file system, which you are then able to overwrite in the routes file. Or you could choose to not import it and rather manually write out all the routes if you'd like. I think it could be the best of both worlds: convenience of filesystem routing (aka. file based routes) + the power and customizability of a single route file.
It would also allow vps to remain render library agnostic.

I'm actually thinking of increasingly focusing on single route files, and I'm increasingly thinking that it's superior than Next/Solid/Remix's approach. That said, so far, I think still supporting basic FS routing makes sense (like what VPS already does today), but I'll likely won't focus much on it.

TanStack Router vs. React Router DOM vs. Next.js comparison page is out, as per demand. It has a good overview of potentially desirable features for a routing solution.

TanStack Router vs. React Router DOM vs. Next.js comparison page is out, as per demand. It has a good overview of potentially desirable features for a routing solution.

Other than typesafe links (which is quite lovely), is there something you'd miss if using VPS's built-in router?

Ticket for typesafe links: https://github.com/brillout/vite-plugin-ssr/issues/698.

Now that the V1 design is out, this ticket should be fairly easy to implement.
To increase the priority of this ticket, add a comment here with the reasons why you want this.

My approach to the Single Route File would be to use it into my framework, I'd like to have a File Routing System but I like it in my own style, that's why I would probably in a Single Route File declared in the renderer folder, use import.meta.glob or something like Chokidar.
I like the idea of +config being the way to define routes, as I've seen in the documentation, you already can define the Page and if I remember well even onBeforeRender on the +config file, I'd think making it an object of paths would be an optimal way to make it.
// +config.js
export default {
  routes: {
    "/:id": {
     Page: UserPage,
     onBeforeRender: onBeforeRenderUser,

     "/activities": {
       Page: UserActivitiesPage,
       onBeforeRender: onBeforeRenderUserActivities
     }

     // ...etc
    }
  }
}

I'm not that sure about the naming of the property "routes"  as I don't know how it would be to separate API Routes and UI Routes.

Hello,
I would be interested to get a single file routes definition to increase maintenability and also getting better git diff when updating routes.
I think fsr Is a bad idea as I said for git diff but also it forces the ecosystem to use specific file convention and it's not that flexible.
It's also more user dev friendly to have a file to defined all routes, dev can quickly read it and understand what is going on at a specific url. I think vps is a plug and play ssr plugin for vite sooo imo it need to be as flexible as he can be.
I just want to be able to define my urls and get it strongly typed when I'm using a link. I also think child routes are not that good for readability I prefer to have a full relative url on each route.
Hope it can be helpful, sry for bad english. Also hope it's understandable.

it's not that flexible

Do you mind elaborating?

A good example would be, where routes are managed externally from the code, in applications with multi project setup. Having the flexibility to define route pages without being forced to use file based routing, would be a great feature that Vite-Plugin-SSR could implement.

Vite-Plugin-SSR could implement

Definitely and especially now with the V1 design header files.

where routes are managed externally from the code, in applications with multi project setup.

Curious: what's your motivation for organizing your code like that?
The more I know about use cases, the better.

Vite-Plugin-SSR could implement

Definitely and especially now with the V1 design header files.

where routes are managed externally from the code, in applications with multi project setup.

Curious: what's your motivation for organizing your code like that?
The more I know about use cases, the better.

It could be useful in projects where same codebase is used for multiple projects, and is managed externally via some kind of CMS. Pages, entire features are configurable without requiring a release.

Vite-Plugin-SSR could implement

Definitely and especially now with the V1 design header files.

where routes are managed externally from the code, in applications with multi project setup.

Curious: what's your motivation for organizing your code like that?
The more I know about use cases, the better.

Do you know of any short term solution which could allow me to configure routes without file based routing?

same codebase is used for multiple projects

Makes sense. What is it you're building? Let's PM. Let's also talk about sponsoring, which can make sense for your company as you'll be using a unique added value of VPS.
It's actually already implemented by config.extends. But you can't currently provide pages (i.e. routes). This ticket is precisely about enabling defining pages/routes in +config.h.js and therefore providing pages with extends.
For others reading this: if your company is up for sponsoring, definitely PM me. I prioritize features by the needs of sponsors.

I'm currently not considering implementing Single Route File for the https://github.com/brillout/vite-plugin-ssr/labels/v1 release %3Astar2%3A.
AFAICT it's about two things:

Being able to quickly glance over the entire routing of the app.
Being able to define pages by external npm packages.

Are there other use cases? If so, let me know.
The thing is that I've a solution in mind that doesn't require Single Route File for both 1. and 2. and that's why, so far, I'm inclined to not implement this. But I'm happy to be convinced otherwise: let me know about your use case.

The alternative solution for 1. is a command $ vite-plugin-ssr routes that prints all routes. This command will automatically be run at the end of $ vite build.

For me this would be an awesome feature for localization.
I could then dynamically change the routing based on the localization of the user.
For instance:
in english this would be
/home
/customer-data

in german
/home
/kunden-daten

It would make my life much easier to define this in a single file instead of in multiple files.

@brillout my statement holds true though. I really would prefer to define my routes in a single file instead of having filesystem routing. If I can help to implement this let me know where I could get started.

A Single Route File also has its drawbacks. It isn't a perfect solution. I think I understand the appeal of it and I still have mixed feelings about it.
I'm thinking at this point the best is to first try to solve all issues without Single Route File and then later reconsider whether we want to add support for it.
That said, feel free to elaborate and why exactly you'd prefer a Single Route File over Filesystem Routing. (Your previous comment was more related to #1000. FYI I've a design in mind about i18n which I'll share if I'm still happy about it in a couple of days.)

That makes a lot of sense.

I could have a single API

That's quite appealing indeed.
Actually, the V1 design needs a rudimentary implementation of a Single Route File. I'll see if I can get something useable for users.

I'll see if I can get something useable for users

@brillout if it helps you can also point me into a direction where and maybe "how" I could get started on, since I am need of the feature I would be willing to help out to maybe build a first implementation of this. I guess you have a lot of work to do with the V1 Design. However, I also know that first contributors can often cost more time than they bring to the table.
So if contribution are welcome (and possible) I could have a look in coming up with an implementation if you have ideas for architecture maybe we can discuss them closer per pm (discord)? But I can also see that as maintainer you want to implemt this kind of core feature yourself.

I definitely appreciate the intention but, yeah, this one is quite a subtle one so I think it's best I implement it. (There are other tickets that are well suited for getting started with contributing: https://github.com/brillout/vite-plugin-ssr/issues?q=is%3Aissue+is%3Aopen+label%3A"contribution-welcome+%3Atwo_hearts%3A" — in case any of it is appealing to you.)

This would also be useful for any plugin that wants to build an abstraction above Vike/VPS . The Single Route File could be generated by them yet still be transparently visible/editable by the user. Be it an abstraction that provides the boilerplate for an API layer, internationalized routes, etc.

@doeixd You're right and that's the plan: https://vite-plugin-ssr.com/extends. (The rudimentary Single Route File implementation I mentioned earlier needed for the V1 design is actually precisely for enabling extensions to define pages.)

@redbar0n
Each + file can live in a different environment which was a primary motivation for the V1 design; some of your ideas aren't implementable without code extraction (wich I believe to be an anti-pattern).
As for increased flexibility around Filesystem Routing I agree that'd be nice, but it isn't a priority at the moment. That said, I'm happy to revisit prioritisation upon blockers and/or sponsoring.

Latest design for defining all routes in a single file: https://github.com/vikejs/vike/issues/341#issue-1274652261.

some of your ideas aren't implementable without code extraction

I presume you mean «Code Extraction: The act of separating the code and creating server and client code bundles». But doesn’t Vike already do this to an extent?
If the problem with having all routes in a single file is that client side routing and server side routing would need to be extracted from that file, what about 2 files: a single route file for the client, and a single route file for the server? Could make it clearer. E.g. So if you want to SSR a particular page you’d move it to the single route file for the server.

@redbar0n I'm afraid it isn't that simple. In general, design needs an holistic understanding of a lot of problems at once. I'd be happy to elaborate but that would require 2-3 pages of text. As you can imagine, prioritization is crucial for Vike to grow.
That said, it's paramount that users communicate their pain points and what they try to achieve (the goals), and I'm more than happy to hear (critical) feedback here. The resulting design (how to achieve the goals) is a work that only Vike maintainers can do.


ROS2 Humble testing

Testing what we need to do to get dev environments up to Humble. Galactic is end-of-life in November, Humble has 5 years of service.

[x] Test our package pipelines
[ ] Test hardware drivers
[ ] Test sim
Update: Sim is borked with Humble, will have to investigate why

Update: Sim no longer borked. just having 2 envs with conflicting stuff breaks - i think i build airsim while in humble env and it was weird. Reset envs and it worked


Module breaks when AMD loader is present but implementation is simple

Subject of the issue
The requireJS module is present on the page, resulting in a true for the check typeof define === 'function' && define.amd. The factory function is now executed when the module is loaded using require. However, the angular app does not use the AMD loader. The presence of the AMD loader on the page is required for other reasons.
Your environment

version of angular-translate: 2.11.0
version of angular: 1.5.9

Steps to reproduce

Load requirejs or a different AMD loader using a script tag in the <head> of the HTML file
Create an angular module with a dependency on translate and include it in a script tag at the bottom of the <body>
Include the angular translate module using a script tag at the bottom of the <body>.
Alternatively, build the angular sources together into a single javascript file (concat file sources)

Expected behaviour
The Angular translate module should be properly registered, even though the module is not loaded with the AMD loader.
Actual behaviour

The Angular translate module is not registered.
An error is thrown due to the fact that the module is not loaded through AMD but in a script tag: Mismatched anonymous define() module

I don't get it. If you have a truthy (typeof define === 'function' && define.amd) expression, it will use this function define. What is the problem with that?
The only missing point here: The library does not require AngularJS, therefor you have to configure the dependency to AngularJS in your own (via shim).

when it uses the define I need to require the translate file in order for the module to be registered (it runs factory() only when the module is required). Since my angular app is not using require or any other AMD loader I cannot load the translate module.
A fix here could be to run factory() before the define([], function () { return factory(); }), but that still does not fix the error Mismatched anonymous define() module which happens when you load the file not via the AMD loader but by using a script tag (since no name is provided in the define, i.e. define('pascalprecht.translate', [], function () { ... }).

Still not get your problem.
https://github.com/angular-translate/bower-angular-translate/blob/2.11.0/angular-translate.js#L7-L19 is not using require anywhere; only define is being used, but conditionally by the expression already mentioned.
If there is no AMD context (i.e. RequireJS) available, the define function will not be invoked. If it is invoked, then you have a AMD context.
Is it possible you have run into this issue? This would mean you have an AMD context, but load the files without it.

Mismatched anonymous define() module actually means you have an AMD context. If you don't use it, you should consider not loading it.

See these fiddles :)
Good: No requirejs present: https://jsfiddle.net/0vxw61xy/2/
Bad: With requirejs present: https://jsfiddle.net/keoqdhyw/

So you are using actually RequireJs, but not using it to load the files (because you have inject them on your own via <script>, and this all within an AngularJS application which does not support a real module system?
Well, I got your point. But why you are doing such a stunt? We are using a common UMD header which means you will get this problem with the next library tomorrow again.
Despite this: We can evaluate adding names into the define configuration. This must work in all published angular-* sub modules correctly. And the impact for existing solutions should be as minimum as possible.

That's indeed what is happening. The reason it's like this is that it's being used on a corporate website which features angular stuff and legacy non-angular stuff based on AMD modules. Our angular app is using a build process that wraps all files together, the libs itself (i.e. angular, translate) included.
I think adding names into the defines may actually be more complicated than it seems.
Would it not be possible to align with angular or ui-router in terms of implementation? Since angular is kinda weird in terms of module scoping I'm not sure how much actual benefit the AMD wrapper provides. The AMD effect can be achieved by configuring requireJS to load the file as non-AMD source. I do understand that would be a breaking change though.
Maybe adding an unwrapped version in the dist is easiest?

Well, I see your issue. But honestly: Even if we fix this here, you will get this issue in the next library which is using such an UMD header. It is not uncommon. Perhaps it is better you scope your Javascript "mini-apps" into dedicated context scopes instead of attaching everything into one single page context.

Maybe adding an unwrapped version in the dist is easiest?

Maybe you can make PR adding such files into the build process? Perhaps for angular-translate.js: angular-translate.raw.js.

Hello,
in part of a "Spring Cleaning 2017", we are closing this issue as part of several others. The meta discussion is available here for full transparency.
 Said this, we must keep the focus and scope on the project.
We are grateful and appreciate to everyone for each made contribution (regardless being code, idea, documentation, and support).
We are deprecating/closing all issues which fulfills a specific set of criteria: mainly outdated, nice-to-have, or just out-of-scope.

Although the list has been curated to the best of our's knowledge, there will be some lack of understanding.
Okay, there a different stories behind all open issues, but we do not have the time for everything:

Support: Because we have only limited resources, we cannot handle support questions any more. Please use appropriate boards like Stackoverflow.
Feature requests or ehancements: Altough it is probalbly a great idea (otherwise it would be closed already), we can not giving more resources to things out of scope or which are useful for too specific scenarios only.
Bugs: Filed a long time ago, this bug either has a reasonable workaround, no effective solution without harming all others, or is lacking additional information/use-case.
Docs: All documentation efforts not matching English will be abonded.

Thank you.
angular-translate team

FAQ
"But this is really important!"
Well, we are all humans. Maybe we have overseen an important issue. If we missed something, we hope you are reaching as again filing a new issue with the reference to the old one. But please be aware: A bug without further details and a demo included will be rejected again.
"But this would a great feature!"
Reconsider: Are we really required to add something in order to make this feature happen? Or could you also create a project on your own utilizing this project?


Check a lang attribute exists in the  tag

A lang attribute should exist in the <html> tag, which signifies to the screen reader what language the page is in.
Evidence: https://www.w3.org/WAI/standards-guidelines/act/rules/html-page-lang-b5c3f8/

Do we need to refactor this feature to check for empty lang attributes too? I.e. lang="".

@jackdomleo7 I think so. I'm pretty sure CSS equates lang and lang="" to lang=true which means that an empty lang check would technically pass, even though that's invalid.

Ok, awesome, we'll leave this as re-opened so it can be added to.
Proposed solution
html:not( [lang] ) body,
html[lang=""] body {
  ...
}

html:not( [lang] ) body::before,
html[lang=""] body::before {
  ...
}

Opened a new pull request for checking for empty lang: https://github.com/jackdomleo7/Checka11y.css/pull/25


[1.3.0] BUG   worker exits from panic: runtime error: invalid memory address or nil pointer dereference

2023/11/27 07:45:46.596630 [ants]: worker exits from panic: runtime error: invalid memory address or nil pointer dereference
goroutine 93 [running]:
runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x5e
github.com/panjf2000/ants/v2.(*goWorkerWithFunc).run.func1.1()
        /go/pkg/mod/github.com/panjf2000/ants/v2@v2.9.0/worker_func.go:56 +0x85
panic({0x146e960?, 0x2316f00?})
        /usr/local/go/src/runtime/panic.go:914 +0x21f
main.setMetrics({0xc000048e40, 0x30})
        /code/main.go:259 +0xfed
main.getMetrics.func1({0x13d7220?, 0xc000800070?})
        /code/main.go:369 +0x31
github.com/panjf2000/ants/v2.(*goWorkerWithFunc).run.func1()
        /go/pkg/mod/github.com/panjf2000/ants/v2@v2.9.0/worker_func.go:67 +0x97
created by github.com/panjf2000/ants/v2.(*goWorkerWithFunc).run in goroutine 22
        /go/pkg/mod/github.com/panjf2000/ants/v2@v2.9.0/worker_func.go:48 +0x5c

Thanks for bring this up @jicki .
Does this happen immediately or crash loop after awhile.
Also could you share your values.yaml file so I can reproduce?


Data Science with Python : Data Cleaning

Welcome to 'DSWP' Team, good to see you here
This issue will helps readers in giving all the guidance that one needs to learn about Data Cleaning. Tutorial to Data Cleaning and how it's applied using sample code.
To get assigned to this issue, add your serial numbers mentioned in the spreadsheet of "Data Science with Python", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
If you had referred any resources, add them up in "DS Resources". Similarly if you had used datasets, include them in "DS Datasets".
Domain : Machine Learning
Mentors Assigned : Aishani Singh / Peehu Saxena
Points to Note :
The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Changes should be made inside the Datascience_With_Python/ directory & Datascience_With_Python branch.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'GWOC' contributors of 'DSWP' domain.
All the best. Enjoy your open source journey ahead. 😎

Hello, I am Deepthi M with serial number:172, Batch-2. I would like to do documentation on this issue.

Name: Ayushi Shrivastava
S No: 811
Approach to be followed:

Documentation
Proper code and explanation for a sample dataset with missing or null or inappropriate data values to clean and balance the dataset so that it can be used for data training & model creation.Also improve the performance of the project.

@prathimacode-hub Kindly assign :)

You both are so active. This is done on contributors request. If not claimed, you both can choose. But priority goes to person who has asked for this issue. All issues created now are from requests. @ashish-reddy-20-08 @deepthi1107

Issue assigned to @ayushi424 for documentation. You both can choose audio / video. @ashish-reddy-20-08 @deepthi1107

@prathimacode-hub , I will do video mam

Hello, I am Deepthi M with serial number:172, Batch-2. I would like to do audio on this issue.
my approach: a detail explanation .

Ok. Issue assigned to @ashish-reddy-20-08 for video and @deepthi1107 for audio contribution.

Name: Saloni Thete
S.No: 821
Batch-19
Type: Documentation
Approach: Provide Resources for data cleaning and steps to perform the process.
@prathimacode-hub Kindly assign :)


[Sticky] Sticky causing content below to "jump" on load

I first reported this on Slack - sorry its taken me so long to write up the issue!
You can see what I mean here: http://recordit.co/4CMl1P4mJB
The markup is:
<div data-sticky-container>
<div class="site-header sticky" data-sticky data-options="marginTop: 0; anchor: page;">
</div>
</div>

I discussed this with @andycochran on Slack - this is the full conversation:
andycochran [3:27 PM]
@brettsmason: I've noticed that too. Maybe add the .sticky class via js in a .ready()?

brettsmason [3:32 PM]
@andycochran: thanks for the suggestion. Just tried that and still get the problem though. I think it might be to do with the height being set on `.sticky-container`

[3:35]
Yep that's whats causing it. I set the height of `sticky-container` in my stylesheet to match what the sticky plugin was setting and the problem goes away.
I wonder if there's a way to fix this in Sticky? Hopefully a knowledgeable JS Yetinaut may know :smile:

andycochran [4:50 PM]
@brettsmason: Maybe .sticky shouldn't be `position: absolute;` by default. The plugin could position it.

brettsmason [5:00 PM]
@andycochran: I like that idea. I'm not very familiar with how Sticky works, but does it even need `position: absolute;` on the base `sticky` class?

andycochran [5:01 PM]
@brettsmason: Only if we intend to support it being used w/o JS. Which I don't think we do.

This issue in summary seems to be coming from the sticky container height/absolute positioning, as setting the sticky-container height in my stylesheet sorted out the jump.

After further testing this seems like its caused by the position: absolute set on the .sticky class. As Andy said in the chat above, this isn't needed if we only support using .sticky through the sticky JS plugin.
@kball @rafibomb What do you guys think? Can we remove the position: absolute declaration?

2 thoughts.

I think it is fine to only support .sticky through the JS plugin.  There's a bunch of behavior in it that requires JS, after all.
I prefer to, as much as possible, have styles applied by classes rather than directly with javascript.  If the active version of sticky needs position:absolute, perhaps the plugin should be adding .is-active (if it isn't already) and that should apply position:absolute

@kball I agree with you on the class approach.
However from looking at the code isn't this how it already works? When an element becomes stuck it gets the .is-anchored class, which also adds the position: absolute. So as far as I can see the styling for the .sticky class isn't needed at all - all it does is add the jumping as the element gets taken out of the flow with position: absolute until the JS loads.

Great, so perhaps just removing the position absolute will work.  @colin-marshall put together a set of tests for sticky, so perhaps this is already covered or perhaps not, but lets try and see.

Yeah Colins opinion would be great as he knows it well. I'm not sure if any of the other styling elements for .sticky do anything or not either - I'm thinking they are there purely for non-js use.
I'll try removing all the styles and go through the tests to see if there's any difference.

@brettsmason @kball sorry for the late response! All sounds good with this approach. I will test this out this week and report back. Thanks guys!

I've got a site suffering from this too. Any news on how the tests are going... or how I can implement a temporary fix? Many thanks,

You guys are 25 days ahead of me.
I just ran into this, tracked it down, and then found this issue. Whoops :-)

@brettsmason:
So as far as I can see the styling for the .sticky class isn't needed at all - all it does is add the jumping as the element gets taken out of the flow with position: absolute until the JS loads.

I agree completely.
Not sure what the original purpose for position: absolute would have been either.
@peterbournecommunications
The simplest fix is to add an override in your own stylesheet.
.sticky {
    position: relative;
}

I believe this was fixed by https://github.com/zurb/foundation-sites/pull/9298


Use sslsplit with the mode of tproxy, and find that sslsplit send request to server with its own IP as source.

Use sslsplit with the mode of tproxy, and find that sslsplit send request to server with its own IP as source. I read codes, and find that no operation is done when connecting to real server.
Here is my command:
sslsplit -e tproxy -d tcp <IP_ADDRESS> 8081
iptables -t mangle -N DIVERT
iptables -t mangle -A PREROUTING -p tcp -m socket -j DIVERT
iptables -t mangle -A DIVERT -j MARK --set-xmark 0x${MARK_ID}/0xffffffff
iptables -t mangle -A DIVERT -j ACCEPT
MARK_ID=1
RULE_TID=200
PORTS=80
PLAIN_PORT=8081
iptables -t mangle -A PREROUTING -p tcp -m tcp --dport ${PORTS} -j TPROXY --on-port ${PLAIN_PORT} --tproxy-mark ${MARK_ID}
ip rule add fwmark ${MARK_ID} table ${RULE_TID}
ip route add local default dev lo table ${RULE_TID}

That is expected. If the manual page is not clear enough on this, I am happy to take a pull request against the current develop branch in order to clarify the manual page wording.

Thanks for reply so soon. I got it.


Use ansible-runner to run Providers Operations

These are the issues we will need solved, so we can use ansible-runner instead of ansible-playbook
Blockers:

[x] allow --extra-vars parameter https://github.com/ansible/ansible-runner/issues/46 (we can use the new --cmdline, but it stores the extravars content under private_data_dir/env/cmdline)
[x] can't pass extra-vars with values having nested array/dictionary/multi-line string https://github.com/ansible/ansible-runner/issues/62
[x] can't pass --tags and --skip-tags https://github.com/ansible/ansible-runner/issues/63
[x] getting JSON response from stdout https://github.com/ansible/ansible-runner/issues/4

Nice to have:

[x] running roles directly https://github.com/ansible/ansible-runner/issues/52
[x] need empty project dir https://github.com/ansible/ansible-runner/issues/88
[x] JSON output in not valid https://github.com/ansible/ansible-runner/issues/89
[ ] return code of command line doesn't fit https://github.com/ansible/ansible-runner/issues/95
[ ] error format and blank stderr  https://github.com/ansible/ansible-runner/issues/96

These are the issues that need to be solved for running async ansible-runner:
Blockers:

[x] Default timeout 120s silently kills the job https://github.com/ansible/ansible-runner/issues/99
[x] --role doesn't run in background https://github.com/ansible/ansible-runner/issues/100
[ ] Strange behavior of is-alive stop https://github.com/ansible/ansible-runner/issues/101

@miq-bot remove_label stale

@Ladas @agrare @Fryguy what is the status of this issue?

All the blockers have been fixed and the integration with ansible-runner is in production for a while.
I am not sure if if ever used the async version, @agrare you did the worfklow for long running jobs without it I think?
In any way, I think this can be closed now. Feel free to reopen if needed (maybe opening new issue for the remaining issues if needed)


 To silence this warning, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    from pandas._libs import testing as _testing

tests/system/test_auth.py:66
  /root/project/tests/system/test_auth.py:66: PytestUnknownMarkWarning: Unknown pytest.mark.local_auth - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/mark.html
    @pytest.mark.local_auth

tests/system/test_auth.py:82
  /root/project/tests/system/test_auth.py:82: PytestUnknownMarkWarning: Unknown pytest.mark.local_auth - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/mark.html
    @pytest.mark.local_auth

tests/system/test_auth.py:94
  /root/project/tests/system/test_auth.py:94: PytestUnknownMarkWarning: Unknown pytest.mark.local_auth - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/mark.html
    @pytest.mark.local_auth

../../opt/conda/envs/test-environment/lib/python3.7/site-packages/pandas/core/indexes/base.py:378: 6 warnings
tests/system/test_gbq.py: 297 warnings
tests/unit/test_gbq.py: 7 warnings
tests/unit/test_load.py: 8 warnings
tests/unit/test_timestamp.py: 5 warnings
  /opt/conda/envs/test-environment/lib/python3.7/site-packages/pandas/core/indexes/base.py:378: DeprecationWarning: `np.bool` is a deprecated alias for the builtin `bool`. To silence this warning, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    elif issubclass(data.dtype.type, np.bool) or is_bool_dtype(data):

tests/system/test_gbq.py: 54 warnings
  /root/project/pandas_gbq/gbq.py:536: UserWarning: A progress bar was requested, but there was an error loading the tqdm library. Please install tqdm to use the progress bar functionality.
    **to_dataframe_kwargs

tests/system/test_gbq.py: 12 warnings
tests/unit/test_gbq.py: 5 warnings
  /opt/conda/envs/test-environment/lib/python3.7/site-packages/pandas/core/frame.py:7616: DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. To silence this warning, use `object` by itself. Doing this will not modify any behavior and is safe.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    if dtype != object and dtype != np.object:

-- Docs: https://docs.pytest.org/en/stable/warnings.html

---------- coverage: platform linux, python 3.7.10-final-0 -----------
Coverage XML written to file /tmp/pytest-cov.xml

=========================== short test summary info ============================
FAILED tests/system/test_gbq.py::TestReadGBQIntegration::test_ddl[env] - Attr...
FAILED tests/system/test_gbq.py::TestReadGBQIntegration::test_zero_rows[env]
FAILED tests/unit/test_gbq.py::test_to_gbq_wo_verbose_w_new_pandas_no_warnings
FAILED tests/unit/test_gbq.py::test_to_gbq_with_verbose_old_pandas_no_warnings
= 4 failed, 162 passed, 8 skipped, 3 deselected, 400 warnings in 233.09s (0:03:53) =

The dtype errors are possibly fixed if we bump the minimum version of pandas? Not sure what the extra warning we're getting in to_gbq is. Maybe?
tests/unit/test_gbq.py: 5 warnings
  /opt/conda/envs/test-environment/lib/python3.7/site-packages/pandas/core/frame.py:7616: DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. To silence this warning, use `object` by itself. Doing this will not modify any behavior and is safe.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    if dtype != object and dtype != np.object:


Email, avatar and publishing configuration support

Hi there!
I've added support for the email address by utilising the /users/:username.json endpoint.
Next to that I also made the avatar field take the avatar_template field and turn it into a proper link with a config option for the image size.
I also published the configuration file.
And updated the README.md as well to include my changes.

Apologies, discovered some issues with the changes I made. Guessing it was because I first used the same client id which I used before and that probably already had access to "read:all". Fixed them all in the later commits. (Don't ask me what happened with the force pushes)


Drilled down view to account transactions

[x] Period automatically switched to 'today' (Transaction wise).

Issue Closed


⚠ Bofrost.lu has degraded performance

In 6e81175, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1819 ms

Resolved: Bofrost.lu performance has improved in 93f561d after 1 hour, 1 minute.


[Loc] update to sql-database-projects

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.61%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27086

Relevant Lines:
59040

💛  - Coveralls


All geometry rendered through shaders is marked as "opacity"

Describe the bug

This bug initially showed up in Barnyard, where I noticed that all geometry (characters, terrain, etc.) that was rendered with shaders is marked as "opacity". Using the Opaque debug mode shows that it's all marked this way.

It shows up in The Simpsons: Hit and Run as well on anything handled by shaders. Basically, the one thing in common is shaders

dxvk-remix-876eb35-419-debugoptimized

bridge-remix-0bc8984-54-debugoptimized

RTX 3090

546.33

The Simpsons Hit and Run (Retail)

Barnyard (Retail)

To Reproduce
Steps to reproduce the behavior:

Load the games
Get in-game using the latest shared rtx.conf files in each game's project channel
Turn on the debug mode to view opacity
Toggle "Capture Verticies from Shader"
Observe correlation

Expected behavior

These objects being marked as opacity could be a serious blow to performance. Handling them properly would be ideal.

Screenshots
"Capture Verticies from Shader" On:

"Capture Verticies from Shader" Off:

The game is probably rendering characters with blending turned on, even though they're opaque. The runtime has to assume that the blend state is correct, since we can't detect that the meshes are actually fully opaque, so they come out on the RT side with opacity enabled. Unfortunately it's somewhat common for games to get this state wrong sometimes, since it doesn't cause visual problems.
Marking closed since we can't really do much about this. If you think that's an error feel free to comment/reopen. Thanks!

@nsubtil I understand your final decision, however I'm still curious about one thing.
I was told previously that having many objects marked as opacity could be very detrimental to performance. If this is indeed the case, is there a way to forcibly override it globally for a game? In the case of Barnyard, everything is marked as opacity and performance is quite bad, yet disabling opacity in a mod.usda file does not appear to work.

A global toggle would likely lead to incorrect rendering elsewhere (like the foliage in the background in your screenshots). It's also likely that the blend state for characters is set that way for a reason, even if it's not completely efficient: some character meshes may have translucent portions that would render incorrectly under a global toggle.
In this case, I don't expect the cost to go up by a significant amount in practice. These meshes are "opaque blended", which still uses the opaque material. Traversal still needs to return the same first hit as fully opaque, and it's up to the material shader to determine whether to continue the ray --- if the mesh is fully opaque, the shader will always stop traversal. The extra cost here compared to the non-blended path is pulling in the alpha value and an extra bit of logic to determine that it's actually fully opaque, which isn't that significant.
The guidance to keep opacity down holds in general, for a few reasons: jumping to the translucent material (as opposed to opaque + blending) increases cost much more significantly, and things like alpha-blended particles go into a separate BVH which makes traversal more expensive.

I was thinking in regards to the global toggle that it'd be easier to effectively whitelist transparent objects, rather than going through one by one to blacklist everything.
But given your explanation of performance, it seems that's not too necessary. Thank you 🙂


Debug Key #3 (QOL Feature)

What feature do you want to get added on the base engine?
Maybe it is a little too late to ask for this, but it would be a nice QOL feature to have the Stage Editor have it's own configurable key.
I think it should be turned off by default, but having the option for those who need it to rebind it in settings.

To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

They said that thay won't be creating a stage editor for PE. If you are capable to create it, good luck. Also, you can add new keybinds by adding them on the controla file.

This feature request was for the pre-release build of Psych Engine, which DOES add a stage editor.
Thanks for the tip anyways.


experiment: reduce compile times

[ ] remove lazy_static -> OnceCell
[ ] feature-flag "heavy" middleware: compression tower-http (requires lots of compression algos), add to docs instructions how to enable the feature if turning on.

to analyze

[ ] tracing-subscriber (7s, lots of default features)
[ ] fs-err (5s, remove/alternative?)
[ ] make Storage optional including object_store (since object_store is heavy), when people need it they can add-in a feature flag

Can we also maybe feature flag the queue implemetations? Or are they needed for emails?


❓ Orientation switching on device rotation causes momentary preview freeze

Question
How can we prevent the preview video connection from freezing momentarily when switching orientation by changing the vision camera  orientation property.
What I tried
Only  looking at iOS at the moment..
I implemented the hook useDeviceRotationSensor as described in 624. I also created an alternative local patch for iOS and providing  the same capability in swift. In both cases the result is the same. Rotate the device, the orientation for the video connection (AVCaptureVideoDataOutput) is changed. However, changing the orientation seems to  disconnect the current data writer, re-allocate buffers  and reconnect the data writer.
There must be a strategy to accomplish this since expo-camera does so as well as the iOS Camera app.
VisionCamera Version
2.15.4
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

In case others would like the camera to behave as in iOS Messages app (which is my goal)...
The momentary pause is caused by an orientation listener that is forcing a change to the camera output connection (buffer reallocation etc) when the device is rotated. To prevent this I have patched the iOS implementation to avoid the orientation listener under certain conditions and have added an output connection settings change to be done immediately prior to taking a photo and starting video recording. This works reasonably well - it's good enough for me to take to production. Android suffers a similar issue and so I'm working on that solution as well.  I'll issue a PR when I'm ready. In the mean time you can checkout my fork if you're interested - and make improvement suggestions ;-)

Please see PR 1619 for a native implementation.

I encountered the same error where the freezing issue arises only when the frame processor is connected. @ajp8164, could you kindly verify whether you have attached any frame processor to validate my observation?
Additionally, the same behavior is found in V3.

Android works ok without freeze on orientation change. Tested on Galaxy S10.

I found that the problem was from the attached videoOutput : AVCaptureVideoDataOutput.
In both cases where I set frameProcessor or video={true}, then the freeze occurred.
Now I noticed that the frame processor internally processes video recording to do its job.
And it leads me to consider that the freeze is not a trivial bug
because it's hard to say that the transition in the orientation of the videos being recorded has to be done smoothly.

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖

Hey - I'm tracking Orientation in this feature request/issue now: https://github.com/mrousavy/react-native-vision-camera/issues/1891 ✨
Make sure to upvote or sponsor to support this feature, and leave a comment if you have any additional thoughts/ideas.


Feature request: Config to enable auto-saving files after a short period of inactivity, or loss of focus

Similar to how settings are saved, we could also save files if the user is done typing. The delay may or may not be configurable.
Auto-save should disable the "file changed" UI hint, to avoid distracting flashing.

The "loss of focus" part of this request isn't present yet, should I create a new issue for that? Really love that feature :)

Issue #1884


Logo design

Other NPM packages have cool logos. This should have one too!

This is included with v4.0.0


io.UnsupportedOperation: fileno when running from Jupyter notebook

I'm trying to run the neural compressor from a Jupyter notebook like:
quantizer.model = common.Model(os.path.join(output_dir, "frozen"))
quantizer.calib_dataloader = common.DataLoader(dataset, batch_size)
quantizer.eval_dataloader = common.DataLoader(dataset, batch_size)
quantizer.metric = common.Metric(metric_cls=Accuracy)

q_model = quantizer()

While running this, I'm getting following error:
2021-10-19 22:20:14 [INFO] Pass Quantization elapsed time: 5277.63 ms
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/neural_compressor/adaptor/tf_utils/graph_converter.py", line 558, in quantize
    with CaptureOutputToFile(tmp_dump_file):
  File "/usr/local/lib/python3.8/dist-packages/neural_compressor/utils/utility.py", line 343, in __init__
    self.orig_stream_fileno = stream.fileno()
io.UnsupportedOperation: fileno

I think this is due to the way that the notebook routes stdout and stderr output streams to be seen in the notebook. The same script runs fine outside of the notebook (just using python).
Is there a way to workaround this to run the neural compressor quantization from a notebook?

No feedback over 2 weeks, closed at first.

@dmsuehir
I met same issue 2 years ago.
Recently, I find it's disappeared.
Maybe due to upgrade of 3rd part software.
I use pip install：
pip install --upgrade pip
pip install neural-compressor runipy notebook

Here is my software list, please refer:
neural-compressor        1.14.1
jupyter_client           7.4.2
jupyter-core             4.11.1
jupyter-server           1.21.0
jupyterlab-pygments      0.2.2
notebook                 6.5.1
notebook_shim            0.2.0
Thank you!


Added support for content import from markdown & html file

Partially fixes #23

This is an amazing contribution @kenanchristian well done!


Operation not permitted errors

Hi,
first, thanks for this library. I have found it very useful. I have been processing some large NetCDF files and all has been going really well. However, I've now run into a NetCDF file which throws "Operation not permitted" errors, but I cannot work out why. The same operation on other NetCDF files works just fine. I am only trying to read the files, not write to them.
One specific example I've traced to trying to read the 'endianness' attribute from a variable object. The attribute is there (it is listed if I do a for (let k of Object.keys(nc.root.variables[latitude])) ... but if I try to access the value, I get an "Operation not permitted" error. If I ry to dump the objects to console.dir() I get the same error. All of theses operations work fine with other NetCDF files I'm processing, so it is something different with this version of NetCDF files, but I am not sure what. Any clue or help you can provide would be appreciated. Have you seen this before or are there some known limitations etc?
The file is 14.8Mb in size, so I cannot upload it, but happy to share it if that would help (just need somewhere I an send/upload it).
thanks,
Tim

Hi Tim,
Hmm, hard to say anything in general here. Do you have any way of transferring your file? E.g. dropbox public link, OwnCloud, ...?
Cheers,
Sven

Hi Sven,
I can probably do dropbox public link - never used it, but will have a
look and let you know.
Tim
Sven Willner<EMAIL_ADDRESS>writes:

Hi Tim,
Hmm, hard to say anything in general here. Do you have any way of transferring your file?
E.g. dropbox public link, OwnCloud, ...?
Cheers,
Sven
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

--
Tim Cross


Iphone is not work.

When I open it with iphone 12, it's not work in ios .

Should be fixed with https://github.com/utsuboco/r3f-perf/pull/47 I believe.


feat: add support for remote update subcommand

I was missing the update subcommand for git remote so I added it. (Reference)

@ldez thanks for the quick review and the addition of the remote specification, totally missed this on my quick&dirty solution.


Does the internal LDAP Server redirect to other LDAP sources?

Hello there,
I got a quick question that isn't quite explained in the web docs. I got a test scenario that has a 2nd authorization application acting as a forward-auth proxy connected to a running Casdoor installation through its internal LDAP server. Casdoor has a configured organization that is hooked up to another external LDAP source (= on-prem AD) to get its users. The users are all properly synced and the communication between the two apps works.
While a direct login through Casdoor works without any issues, the login on the 2nd authorization platform only works with manually added users and not the synced AD users. Judging by the logs, the users are being detected, but the password is apparently always wrong. Since the password is visible in plain text, I can tell that it should be valid. I don't have any password hashes set and I do know that Casdoor doesn't save any passwords for the users that are synced through LDAP in its own database.
Does the internal LDAP server not redirect the password validation to the organizations connected LDAP source in this case? Or is it just a configuration issue on my part? I just wanna make sure before spending even more time troubleshooting this scenario.

@dsp-active you should debug Casdoor code to check. It should be sending password to LDAP server for checks

@dsp-active you should debug Casdoor code to check. It should be sending password to LDAP server for checks

Thanks for clarifying! It does seem to be a problem with my configuration of Casdoor itself, because I checked the LDAP server using ldapsearch inside of the container and it shows the same exact behaviour - manually added users work, synced users don't.
Since direct logins through Casdoor and OIDC work, it can't be a problem with how the AD is hooked up to it. The issue only happens using the LDAP protocol on the internal LDAP server and there aren't a whole lot of configuration options for that. I'm just scratching my head at this point.~

ldap_bind: Invalid credentials (49) - password or code is incorrect

Are there recommended ways of debugging Casdoor in more detail than what's revealed in the logs? I'm not too versed in actually analyzing sent and received packages but I could also check the server hosting the AD for the request package that Casdoor sends to it.

@hsluoyz Hey there, I think I found the issue and it might actually be in need of a fix. Look at this:
This is how the LDAP server calls the object function to check the bind:
/ldap/server.go
bindUser, err := object.CheckUserPassword(bindOrg, bindUsername, bindPassword, "en")
This is how the internal auth controller calls the same function:
/controllers/auth.go
user, err = object.CheckUserPassword(authForm.Organization, authForm.Username, password, c.GetAcceptLanguage(), enableCaptcha, isSigninViaLdap, isPasswordWithLdapEnabled)
As it stands right now, the "LDAP server > other LDAP sources" auth chain will always run into the following issue:
/object/check.go
if !isSigninViaLdap && !isPasswordWithLdapEnabled {     return nil, fmt.Errorf(i18n.Translate(lang, "check:password or code is incorrect")) }
because it never actually changes these 2 bool parameters during function calling and they're False by default. The auth controller has a few lines of code to check these vars beforehand.

Opened up a PR - Link
I got it to work on my end, so I'll close this issue for now.


Optimize QR-code complexity

Try to have 21x21 blocks, instead of 25x25.
Consider encoding channelID on 4 chars instead of 5, if it helps.
Try different values of correctLevel when calling qrcode.js .
Try if specifying "numeric chars only" helps.

Very related to issue #50 [Micro QR-code]

Possible error correction levels are L, M, Q, H.
Default seems to be H.

Error correction "Level M (Medium) 15% of codewords can be restored" is enough for our use case, because the display won't be degraded except by the small red logo in the center.

The new settings should theorically let us encode up to 34 decimal digits. The qrcodejs library however lets us encode only 11 "characters", and above yields 25x25 QR-code.
Well, 11 chars (maybe not only digits) should be enough anyway to have a wide range of difficult to guess values, e.g. 62^11 combinations or 72^11 or even more.

This discovery minimizes the QR-code size (21x21 is not that bad), but importantly it makes impracticable for an attacker to guess a random qrKey displayed by someone else.
Thus :

#54 [Longer, unguessable channel ID] mechanics might be reverted. No need for a server-generated ticket, if brute force guessing is improbable.
idem for #9 Current sessions in Memcache + Datastore
idem for #77 Reject action if more than 1 listener on channel
#15 and #73 about "Block brute" are greatly mitigated

See big changes of #108


Updating readme to point to correct task

Should be suggesting UseDotNet at this point not the older installer

bump

bump


Esc key lag

Switching from Insert to Normal mode is pretty slow.    I think it has to do with the way we are handling the keys in main.rs.

fixed with #61


Bump steve version and update affected calls to AdminClient

The AdminClient call now needs an extra parameter.  This change adds that.
Requires https://github.com/rancher/steve/pull/70 to be merged first and then update go.mod in this PR  This has merged
Issue:  https://github.com/rancher/rancher/issues/39413

rebased hoping ci will finally pass


Export mv gpm object

Refactor GPM export function so that it can export projects with/without content.

I don't understand this part, do we have now a new BCL application which should use for the directory name?


Update _clusters.py

A change so clusters returns a list of cluster objects.

@bixb0012 Thank you!

No problem.  I kept getting a list, just not a list of cluster objects.  After rooting around for a bit, I realized the block of code that builds the list of cluster objects was never actually getting executed.
Neat product/project, thanks for all of your work on it as well.

@bixb0012 i looked at my test script and I just had it check to ensure it wasn't None, that's why I missed it.


Flagged operations

ARC for adding flagged operation opcodes to Aleo instructions.

@d0cd If the opcode was documented in https://developer.aleo.org/aleo/opcodes as having some halting behavior,
it made the list.
Specifically, the bhp opcodes halt if the input is too small.
The ped opcodes halt if given a Struct that is too large.
The keccak and sha3 opcodes don't halt.
The process of developing tests for the flagged operations should exhibit the halting cases,
and it is possible there is a doc bug and we will need to take something off the list.
If anyone sees that or finds more halting opcodes please add a comment here.


Option to show cursor location among anchors

While the comment anchors sidebar provides a nice overview of how a file's code is organized, it does not display the current location of the user's cursor relative to the comment anchors. In order for the user to find out what part of the code they are inside of, they must scroll up until they see a comment anchor, and then find that comment anchor's comment name inside the comment anchors sidebar.

This issue proposes a toggle-able option that will inject a comment anchor icon for the user's cursor into the sidebar, and always unfold any sections necessary to display that icon in the sidebar. A button for this icon could be put next to the existing collapse all button.
Here are some visual examples using a REVIEW anchor in place of the proposed automated USER anchor.

Visually, this issue proposes the USER anchor look like the above images, except that the REVIEW text would either be dropped or replaced by USER and the green anchor would be replaced by a more traditional user icon. Similar to the image below.

Hey!
I've gone ahead and implemented your suggestion, I hope it's as you expected it to be!
Thanks!

@macjuul Thanks for the speedy response, that looks great! I'd like to verify this change's behavior, however the latest commit I can see in this repo is from 7 days ago. Is there a way I can try out this fix now, or will I need to wait until this change is merged into the live extension?

I see this fix has now been put in https://github.com/ExodiusStudios/vscode-comment-anchors/commit/d5741ae9aab18f8d98c0408c66512565e4562749 and is contained in release 1.9.4 . Ending this discussion for now.


Redesigned the FFT polynomial API for better integration with the STARK prover

Redesigned the FFT polynomial API for better integration with the STARK prover
Description
Currently the FFT API can't properly handle polys with N amount of coefficients, with N being a non power of two, and null polynomials. Also the prover will need a way to select how many evaluations it needs from a polynomial. This PR aims to solve both problems via a redesign of the API.
Type of change

New feature

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #299 (67a797d) into main (df9e07f) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   96.43%   96.29%   -0.14%
==========================================
  Files          92       92
  Lines       11525    11459      -66
==========================================
- Hits        11114    11035      -79
- Misses        411      424      +13

Impacted Files
Coverage Δ

fft/src/ops.rs
40.00% <100.00%> (-60.00%)
:arrow_down:

fft/src/polynomial.rs
92.71% <100.00%> (-1.31%)
:arrow_down:

math/src/field/traits.rs
78.37% <100.00%> (-1.63%)
:arrow_down:

math/src/polynomial.rs
92.92% <100.00%> (+1.96%)
:arrow_up:

proving_system/stark/src/prover.rs
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Check protection before burning something.

This may leave floating objects, but it could save someone some grief.

Normally it would be a good idea but the initial protection check for blast centre will do for now...  Checking every node being destroyed will lag when blast happens, and with dungeon lords causing a lot of damage that will affect servers.


Support Google Analytics

Either somewhere to dump their html tags or just their GA ID would be great

Hmm, collecting this data in GA would require some kind of privacy policy as well :/ At least a link would be required for that as well.

Does Google provide a generic one?

I think they provide some general information on a page to link to. I think the best would be to have a generic Privacy policy within the tool (also explaining what data the tool is processing itself) and adding a GA section, if it is configured, automatically. In that way, server hosters could also change the wording if needed.


Pagination class bug

On \system\libraries\Pagination.php line 357 need to change
if (is_array($params['attributes'])
to
if (is_array($params['attributes']) && !empty($params['attributes']))
without this check attributes from pagination config will erased on pagination->initialize if new attributes not sent

Sorry, I don't understand what the problem is.

don't worry,if $params['attributes'] is empty ,is_array($params['attributes'])==false.

Depends on what is meant by "empty". is_array(array()) will return true.
That still doesn't explain what the problem is though. Closing after 2 months without feedback.


Tapping on placeholder text doesn't add caret.

Not sure if this has always been the case, but if the TextView has placeholder text, users are forced to tap on the empty space, they cannot tap the placeholder to start typing. This is especially an issue with longer placeholders, it makes the box seem un-responsive and difficult to edit.
Would really appreciate a fix, or workaround! 🙏😊

PR #36 should fix this issue

PR #36 should fix this issue

Thanks a tonne, @ejensen! We'll wait for it to be merged. 😊

Thanks a tonne, @ejensen! We'll wait for it to be merged. 😊

Weirdly, we're seeing this issue pop-up again, but only in once instance, where we have a TextView within a sheet . 🤷


Modularize CLI bindings

The CLI bindings can be their own module, with a configurable backend.
It can be a separate project, pulled in via git submodule or something using luarocks into this repo.
This repo would set up the Go plugin backend as the CLI backend.

Haven't found any real use for it.


ls --color and vim incorrect colors

From @nickolasclarke on July 29, 2017 8:20

Your Windows build number:  (Type ver at a Windows Command Prompt)
Microsoft Windows [Version 10.0.16232.1000]

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)

when I use ls --colors all subsequent prompts have a highlighted background applied to them when using hyper terminal and vs code terminal. This also happens when I use vim in those terminals.
Hyper:

VS Code:

vim on the BashOnWindows terminal and in Hyper (same thing happens in vscode):

What's wrong / what should be happening instead:

there should not be a alternative background color applied to all lines, and it should not remain after the  the command completes.
I'm honestly at a bit of a loss on how to troubleshoot this. I thought it my be my some things I did with LS_COLORS and .dircolors, but I've backed everything out of those and its still doing this. I dont believe it is an issue with the hyper terminal since I am seeing it from the VS Code terminal as well.
Copied from original issue: Microsoft/WSL#2378

From @zadjii-msft on July 31, 2017 20:53
It's probably an issue with mintty if it's affecting both hyper and vscode. They both mintty to attach to a conhost instance.
I don't believe there's any terminal out there that's figured out a way to get conhost's RGB colors working quite yet. We don't plan on changing the API surface, so they can't query the contents of the buffer to get RGB colors back out, instead we round the color to the nearest color table entry.
As an example, vi in hyper (top) vs vi in gnome-terminal (bottom left), vs vi in conhost (bottom right):

@mintty can comment more, I don't know too much about the solution space for this issue.

From @nickolasclarke on July 29, 2017 8:50
update: This also happens if I try to use fish and git

You know, this might just be a close-by-design now. The original post might predate us announcing conpty in the first place. Hyper (et al) should be using conpty if they want to act as Terminal emulators. Using the Console API to try and get color and text information out of the buffer simply isn't going to work the way they want.


KeepIdentity "Table does not have the identity property. Cannot perform SET operation"

I'm running into an issue where we are using HiLo sequences for Entities to generate primary keys beforehand. The problem is this bit of code tries to execute to set the Identity insert to ON:

This results in the error being thrown stated in the title. If I clone the repo and remove this code it resolves the issue.
Here is a few snippets I used to produce this issue:
Create an entity with a HiLo sequence:

Insert entities with SqlBulkCopyOptions set to KeepIdentity:

I believe the solution would be to use the Model MetaData on the DBContext to determine if this entity/entities we are trying to insert contains a HiLo sequence to prevent this code from executing while still preserving the identities.

Fixed with 6.4.3


Error when I try to run server.js on local machine

Erro message:
[ERR_REQUIRE_ESM]: Must use import to load ES Module
To Reproduce
Steps to reproduce the behavior:

Go to project directory
Run npm run server
See error

Screenshots

Desktop (please complete the following information)

OS: MacOS

Additional context
I googled it and someone says it's a specific bug of node 12.11.0 and so I just upgrade node to 12.16.0 but the err still exists.

Since I want to work on issue #590, I want to fix this A.S.A.P.

Yeah and it still raises that error...

Can you try using NVM https://github.com/nvm-sh/nvm?
I'm running v12.4.0 of node here and it works fine. Let me know if installing that version of node with nvm works for you

Can you try using NVM https://github.com/nvm-sh/nvm?
I'm running v12.4.0 of node here and it works fine. Let me know if installing that version of node with nvm works for you

Thanks! I used nvm and set node version to 12.4.0 and it worked!


Website quickstart title fixes

fixed, thanks!

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Split script navigation state and edit state

Right now when you move in script editor history, the editor will store everything, including bookmarks, breakpoints and current highlighter. This actually leads to some bugs, e.g. old bookmarks can be restored if you go back to previous script.
This PR adds a navigation state, which is a subset of script edit state. Script editor history will use it instead.
Helps #63515

Thanks!


Connector calls don't wait until its initialized

Any pointers to code would be appreciated.
I thought I had already accomplished the right flow via these lines of code:
dataSource.connector.connect(callback);
...
ESConnector.prototype.connect = function (callback) {
...
if(self.settings.mappings) {
  self.setupMappings(callback);
}
...

But apparently not.

connectors emit a connected event once the connecter has finished initialising. Are connectors supposed to queue up their queries somehow until the connected event has been emitted?
As a workaround in our application, we have a boot script like this which ensures that queries are not made against the connector until it is truly ready:
'use strict';

var logger = require('../modules/fc/logger');

module.exports = function (app, cb) {
  logger.debug('Boot waiting for ElasticSearch initialization...');

  // As soon as the datasource has been connected, move on.
  app.dataSources.elasticsearch.once('connected', function () {
    logger.debug('ElasticSearch connected, boot continuing');
    cb();
  });

};


perf: improve type declaration hinting

Give default export a name so that editors can give users hints when they try to import "NiceModal".

Codecov Report

Merging #68 (6aab5b1) into main (22a6a4e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          185       186    +1
  Branches        29        29
=========================================
+ Hits           185       186    +1

Impacted Files
Coverage Δ

src/index.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a6a4e...6aab5b1. Read the comment docs.

Nice! Thanks @SevenOutman !


markdown image

@sebescudie
...I just tried to capture one that had an image in it, and the resulting markdown considers them as links. which is already cool, but would it be possible to add a ! just before so that it displays it as an image? Instead of [image.png](https://linktoimage), would be ![image.png](https://linktoimage). ofcourse one can easily edit the resulting markdown, just a suggestion :)

image, audio and video messages are now converted to their corresponding html tags.
only image seems to be 'standard' as ![... notation. therefore audio and video elements are still converted to normal md links

thanks!


"first" mode on "find" causes exception if no elements found

Describe the bug
When using the find method on the Soup class, and there are no results found, an exception is thrown if you used mode="first".
To Reproduce
Code to reproduce the behaviour:
from gazpacho import Soup
s = Soup("
test
")
s.find("a", mode="first")

Expected behavior
It should return None.
Environment:

OS: Linux - Ubuntu
Version: 19.10

Additional context
None

Fixed in 0.9.2! Thanks for the Issue!! 🤙


MSS110RTL not supported

[8/31/2021, 3:35:34 PM] [Meross] [Windows RDP] is currently not supported, do create a github issue https://git.io/JtfVC with info:
{"uuid":"2103293980508651855348e1e96809a6","onlineStatus":1,"devName":"Windows RDP","devIconId":"device001_eu","bindTime":1623418705,"deviceType":"mss110rtl","subType":"eu","channels":[{}],"region":"eu","fmwareVersion":"4.1.14","hdwareVersion":"4.0.0","userDevIcon":"","iconType":1,"skillNumber":"","cluster":1,"domain":"mqtt-eu.meross.com","reservedDomain":"mqtt-eu.meross.com","firmware":"4.1.14","hbDeviceId":"2103293980508651855348e1e96809a6","model":"MSS110RTL"}

Hi @Kannebecker
If you install the beta version of the plugin, currently v6.9.3-beta.0, this device should start working!
Thanks

Thank you,
I have no idea how to install the beta package :)
have homebridge running in docker.

You can update through the UI or there’s also specific commands for docker, see
https://github.com/bwp91/homebridge-meross/wiki/Beta-Version
let me know how you get on!

Yes it works !!!
Thank You !


fix Issue 14715 - Add README.md to the tools Repository

https://issues.dlang.org/show_bug.cgi?id=14715

could you list the other tools as well

catdoc, detab and tolf are internal tools executed as part of the build process and don't need to be publicly documented.

still, those are dtools, even if there are only used by the build process.
AFAIK this readme.md is only visible on github and is supposed to help devs. may this be dlang devs or app devs

Added

thank you


Titles- Supporting Partner Accessibility Fixes - Level A- Page Titled

User Story
**As a Supporting Partner I need to each page title to describe the topic or purpose so that I can understand what to expect on each page
Context:

Theses  issues were uncovered through accessibility audit via CITZ.
Detailed Spreadsheet for Student s inserted inline and also attached here: 2024_Supporting Information_Audit.xlsx
Web pages have titles that describe topic or purpose.

The Problem

Not all pages have a title / heading 1.

Acceptance Criteria

[ ] Assign a unique title to each page in the Supporting Partner Portal (Who decides tittles- BA's? )
[ ] Welcome to StudentAid BC
[ ] Login with BC Services Card
[ ] Welcome! (Start submission)
[ ] Search for application
[ ] Supporting information form

@HRAGANBC @CarlyCotton @Joshua-Lakusta  Who decides titles- BA's?

@michesmith This is possibly something that needs to be addressed at the code level and not solely as a forward facing content piece. This seems to be referring to the actual title tag on pages highlighted below. They all seem to be defaulted to "StudentAid BC".

@CarlyCotton to be completed using URL paths to propose page titles.
Not urgent

@CarlyCotton @michesmith Proposing we close this as #3083 will implement by adding H1 tags.


bug:  "attempt to call method 'flatten' (a nil value)"

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
nvim v.0.10.0-dev-1471+ga8aebcff5-Homebrew
Operating system/version
MacOS Sonoma 14.4.1
Describe the bug
I am attempting to load the Mofiqul/vscode.nvim, and am getting a failure: ".local/share/nvim/lazy/lazy.nvim/lua/lazy/help.lua:16: attempt to call method 'flatten' (a nil value)". I noticed that there were some changes added in today's release in regards to the flatten() method and was wondering if this is a bug and if so how I could go about fixing it? Here's a screenshot

The colorscheme still loads but when I run the Lazy Update command I get the error described above.
(update) I realized I get the same error when loading other plugins like nvim-tree
Steps To Reproduce
Install lazy
Attempt to load https://github.com/Mofiqul/vscode.nvim :
return {
'Mofiqul/vscode.nvim'
config = function()
vim.cmd([[ colorscheme vscode ]])
end,
}
I've also tried other alternatives which worked previously but it leads to the same failure
Expected Behavior
I would expect the update command to run without failures when running :Lazy and selecting "U" to update
Repro
No response

either use a recent nightly, or a stable neovim versions.
I'm not going to support old nightlies

Could this be caused by the latest neovim 0.10.0 release (out yesterday?) This seems to reproduce in my 0.10.0 installation while it does not show up on the v0.9.5.

some error!

as folke said above
you're using an old nightly version
either update to 0.10 stable or 0.11 nightly

@dfszb @MichaelC001 upgrading to 0.11 worked for me!

sorry @smsossah upgrading to 0.11 did not help for me .
Had tried both 0.10 and 0.11 nightly as well
still having same error
[lspconfig] unhandled error: ...al/share/nvim/lazy/nvim-lspconfig/lua/lspconfig/util.lua:266: attempt to call method 'flatten' (a nil value)
if it helps
nvim --version                                                                                18:21:24
NVIM v0.11.0-dev-49+g10601ac5f
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068
Run "nvim -V1 -v" for more info

lazy version
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "https://github.com/folke/lazy.nvim.git",
    -- "--branch=main", -- latest stable release
    "--version=v10.20.5",
    lazypath,
  })

will try again to check if  i missed anything

That's strange, I assumed it was a bug with 0.10.0 once I got it working on another version. Were you able to get it working or is it still causing the issue @ehrktia? Aside from changing versions I'm not sure what else could fix it since I'm fairly new to neovim/lazy

That's strange, I assumed it was a bug with 0.10.0 once I got it working on another version. Were you able to get it working or is it still causing the issue @ehrktia? Aside from changing versions I'm not sure what else could fix it since I'm fairly new to neovim/lazy

there is a version check in nvim-lspconfig https://github.com/neovim/nvim-lspconfig/issues/3172#issuecomment-2129133404


[NNVM][TEST] Numgrad: fix nan and multioutput

This PR fixes a couple of bugs in numerical gradient checking:

Raise an exception when there is NaN or infinity in gradients.
Fix shape and dtype inference for functions with multiple outputs.

@kazum @kevinthesun @srkreddy1238 could you please review?

@yzhliu @kevinthesun can you followup and https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly?

Thanks @kevinthesun @yzhliu @kazum @sgrechanik-h , this is now merged


Styling tweaks

Some specific details (exact size/px) still missing from #45 but created this PR with some tweaks

Reduce Font Size: Only Header / H1 size (will update with exact size)

Changed the size of the H1 record title on the record detail page. And tweaked the line-height a bit too. Feel free to suggest tweaks!

Dates on Record Detail: Month (written out), Day, Year (ie. January 10, 2023) Linked to https://github.com/amy-jung/collectivedaoarchives.catalog/issues/35

Fixed!

Typography: “Display”(Title of Records Page and Titles in Home Page) should be “Cooper Hewitt bold” and the rest should be “Inter”. All html text in Records long form content should be “Inter”. Headers of titles in home page and results page should be “Cooper Hewitt bold”.

Changed font to Cooper on records title (teaser)

Decreased the font size a bit

(dev) Abstracted the "record teaser" to a component

Font is now Inter for all the record content HTML.

Fixed the overflowing link from #35

Reduce Padding and overall size of Site Top Header (will update with exact px)

Tweaked the spacing a bit in the header (external padding, gap between logo / name)

cc @amy-jung: don't hesitate to suggest any tweaks here! Check the live preview from Vercel and let me know.
Fixes #45 #35

Looks amazing :)


Limit to/from in TokenHandler transactions to wallets from product cluster

moved wallet to token handler, good enough for now


[VrtNU] fix empty title in json test

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

fixes download issue where internal JSON has empty title
fixes #2146
internal json has empty title >> adapt test to test if key exists:
{'duration': 3121060, 'skinType': 'vod', 'title': '', 'shortDescription': None, 'drm': 'vrt|2021-12-28T.....Z|.../...', 'drmExpired': '2021-12-28...', 'aspectRatio': '16:9', 'posterImageUrl': None, 'channelId': None, 'targetUrls': [{'type': 'mpeg_dash', 'url': 'https://remix-cf.lwc.vrtcdn.be/remix/0603b9c1-b117-4caf-a4c1-xxx/remix.ism/.mpd'}, {'type': 'hls_aes', 'url': 'https://remix-cf.lwc.vrtcdn.be/remix/0603b9c1-b117-4caf-a4c1-xxx/remix_aes.ism/.m3u8'}, {'type': 'hls', 'url': 'https://remix-cf.lwc.vrtcdn.be/remix/0603b9c1-b117-4caf-a4c1-xx/remix.ism/.m3u8'}], 'playlist': {'content': [{'eventType': 'ONBOARDING', 'duration': 3000, 'skippable': False}, {'eventType': 'STANDARD', 'duration': 3121060, 'skippable': True}]}}

The title returned by extractor should never be empty

Hi @pukkandan , thanks for your feedback
If I understand the code correctly, this empty title field is returned by the vrtnu/canvas backend.
https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/extractor/canvas.py#L73-L85
The check on title here only seems to be an error-check to identify if the logon / authorization was OK.
I also tried to remove the complete if-block completely > this works:
https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/extractor/canvas.py#L79-L85
In other words the if is dead code as the actual logon is handled elsewhere:
https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/extractor/canvas.py#L284-L315
This PRQ tried to be as conservative a possible, because there are multiple URLs supported for that exractor.
Please advise on how to tackle the issue.


add chef_env to graphite_to_zabbix queries

https://github.com/bloomberg/chef-bach/pull/1059
backport to release-3.0

@lchen4891 Looks good to me; feel free to self-merge unless you want a particular review from Allan too.


ng-click

@ShaneChesnutt actually you need to add the following to your example:
constructor(props) {
  super(props);

  // TODO: express this in terms of Redux
  this.state = {
    foo: 'bar'
  };

  this.handleClick = this.handleClick.bind(this);
}

handleClick() {
  console.log(this.state.foo); // => 'bar'
}

Can add a note saying "you'll need to bind the click handler to the class so that the this context (and, therefore, the component state) is accessible.

@ShaneChesnutt you're going to kill me, but I just realized one more thing we need to document with this section... how do you pass in the target data member with the click handler? For example, let's say you have the following data structure:
[{
  first: 'john',
  last: 'doe',
  email<EMAIL_ADDRESS>}, {
  first: 'Mary',
  last: 'doe',
  email<EMAIL_ADDRESS>}]

and you ng-repeat it with an <button ng-click='vm.edit(row)>editfor edit row, how doesvm.editfunction know which array item to setrow.editMode = true` for. We know this is rather easy in angular by looking for the index of the item in the larger array, but how would this work in React?

Okay I'll make sure to add that in
On Sun, Dec 11, 2016, 10:04 PM Matthew Vita<EMAIL_ADDRESS>wrote:

@ShaneChesnutt https://github.com/ShaneChesnutt you're going to kill
me, but I just realized one more thing we need to document with this
section... how do you pass in the target data member with the click
handler? For example, let's say you have the following data structure:
[{
first: 'john',
last: 'doe',
email<EMAIL_ADDRESS>}, {
first: 'Mary',
last: 'doe',
email<EMAIL_ADDRESS>}]
and you ng-repeat it with an <button ng-click='vm.edit(row)>editfor edit
row, how doesvm.editfunction know which array item to setrow.editMode =
true` for. We know this is rather easy in angular by looking for the index
of the item in the larger array, but how would this work in React?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoTeamEpsilon/angular-to-react/pull/42#issuecomment-266333404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE9XHq974m1oO3awaPuLHjgeDMkKb0Mwks5rHLmngaJpZM4LKIeA
.


Netty OOM with pooled allocator

If you are using pooled allocator (even with default maxMemoryDirect) there are still places in Netty code where you use unpooled allocator.
For example HttpObjectEncoder:
import static io.netty.buffer.Unpooled.directBuffer;

    // ...
    private static final ByteBuf CRLF_BUF = unreleasableBuffer(
            directBuffer(2).writeByte(CR).writeByte(LF)).asReadOnly();
    private static final ByteBuf ZERO_CRLF_CRLF_BUF = unreleasableBuffer(
            directBuffer(ZERO_CRLF_CRLF.length).writeBytes(ZERO_CRLF_CRLF)).asReadOnly();

The method directBuffer is from Unpooled class. It goes through following path:
io.netty.buffer.AbstractByteBufAllocator#directBuffer(int)
io.netty.buffer.AbstractByteBufAllocator#directBuffer(int, int)
io.netty.buffer.UnpooledByteBufAllocator#newDirectBuffer
io.netty.buffer.UnpooledByteBufAllocator.InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf#InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf
io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf#UnpooledUnsafeNoCleanerDirectByteBuf
io.netty.buffer.UnpooledUnsafeDirectByteBuf#UnpooledUnsafeDirectByteBuf(io.netty.buffer.ByteBufAllocator, int, int)
io.netty.buffer.UnpooledDirectByteBuf#UnpooledDirectByteBuf(io.netty.buffer.ByteBufAllocator, int, int)
io.netty.buffer.UnpooledByteBufAllocator.InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf#allocateDirect
io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf#allocateDirect
io.netty.util.internal.PlatformDependent#allocateDirectNoCleaner

The method allocateDirectNoCleaner:
    public static ByteBuffer allocateDirectNoCleaner(int capacity) {
        assert USE_DIRECT_BUFFER_NO_CLEANER;

        incrementMemoryCounter(capacity);
        try {
            return PlatformDependent0.allocateDirectNoCleaner(capacity);
        } catch (Throwable e) {
            decrementMemoryCounter(capacity);
            throwException(e);
            return null;
        }
    }

It's the same method that is used by pooled allocator and the memory counter used in incrementMemoryCounter is common for both allocators. That creates a possibility where pooled allocator may OOM with OutOfDirectMemoryError thrown in:
    private static void incrementMemoryCounter(int capacity) {
        if (DIRECT_MEMORY_COUNTER != null) {
            long newUsedMemory = DIRECT_MEMORY_COUNTER.addAndGet(capacity);
            if (newUsedMemory > DIRECT_MEMORY_LIMIT) {
                DIRECT_MEMORY_COUNTER.addAndGet(-capacity);
                throw new OutOfDirectMemoryError("failed to allocate " + capacity
                        + " byte(s) of direct memory (used: " + (newUsedMemory - capacity)
                        + ", max: " + DIRECT_MEMORY_LIMIT + ')');
            }
        }
    }

since some bytes are consumed by pooled allocator. Here a screen of a heap dump with default pooled allocator:

As you can see we have 7 bytes consumed by unpooled one. Those 7 bytes later are needed by pooled allocator.
The HttpObjectEncoder is one of the class where unpoooled allocator is used, but there are others. There are 33 production code usages of direct unpooled usage, I believe all of them should be investigated/fixed:

Expected behavior
No OOM.
Actual behavior
OOM.
Steps to reproduce
Not relevnat
Minimal yet complete reproducer code (or URL to code)
Not relevnat
Netty version
4.1.X
JVM version (e.g. java -version)
Not relevnat
OS version (e.g. uname -a)
Not relevant

Hi @krzysztofslusarski !
I don't see that a problem given that such allocations will live till the duration of the mentioned class life cycles (they are actually, proper constant!), or am I misunderstood what you mean?

till the duration of the mentioned class

Those are static fields, so the allocation is hold till unloading of a class / JVM kill.

Yep, but why it should be a problem?
are you suggesting to use Pooled allocations for them?

The scenario I just saw today is like that:

maxMemoryDirect = 512 MB
Netty already allocated 127 of 4MB off heap buffers through pooled allocator
Netty tries to allocate one more 4MB through pooled allocator - that should succeed, since 4*128 = 512
OODME is thrown since: newUsedMemory > DIRECT_MEMORY_LIMIT is true in incrementMemoryCounter

The problem is that DIRECT_MEMORY_COUNTER should be 12741024*1024 = 532676608 in that case, but it has higher value since unpooled allocator allocated 7 bytes:

Regarding suggestion I see 2 way of dealing with it:

Remove the direct usages of unpooled allocator and switch to "current active in the system"
Add a method like allocateDirectNoCleanerWithoutIncreasingCounter

Yeah, but the problem is...such off-heap memory should be accounted somewhere and OOM on Netty (when you specify limits for it, implicitly or not) shouldn't be that different from what the JVM does.
With the JVM if you allocate direct memory, it won't care if you pool/make it constant or not, it's jus memory used, till will be released, if ever will be released.
Afaik the purpose of the Netty counter was the same as per the JVM, to enforce software limits that would make easier to track what a OOM killer would do, in a much less verbose and informative way.

Let's see if @normanmaurer or @chrisvest got a different idea to help you on this

Thinking about it, I see that what we can do to help users distinguish constant off-heap footprint (let's call it baseline, but is not a fair term, given that per class loaded, it can increase) is to use a specific method to allocate those constants and track both direct memory and constant direct memory (a new counter) per them.
Given that these are constant, the performance impact about adding 2 counters updates, shouldn't be a problem.
The results is that users, exposing such telemetry, are able to track what's the dynamically allocated memory vs the constant one (as a difference).
Why not using 2 separate counter per dynamic vs constant?
Because we still need a global limit as we do now, to not break existing users.

yes, it is, because HttpClientCodec has a constant footprint in term of direct memory usage that is (correctly) accounted in the Netty direct memory limit (as said; similarly to the JVM limits there is not distinction between "constant" and "dynamic")

Consider that as soon as you create the pipeline (unless dynamically changed handlers types), the "constant" footprint should be already stable.

OK. So I believe I need to trace some memory leak in that application (not necessary in Netty, maybe some other library causes leak by not releasing acquired buffers).
Thank you for the explanation.

Closing the issue. The memory leak was found with -Dio.netty.leakDetection.level=advanced, nothing related to Netty. Thank you for your explanations, that gave me better understanding of your allocators behavior.

Good job with -Dio.netty.leakDetection.level=advanced BTW :)


Add nerdlandbot tests

#177 Should be merged before this PR
Add startup tests

#177 Should be merged before this PR

I think you mean the other way around since you want to merge this branch into the branch from #177?

#177 Should be merged before this PR

I think you mean the other way around since you want to merge this branch into the branch from #177?

I believe the #177 PR includes files that are needed to let this commit work


THORN-2360: fix MySQL JDBC driver autodetection

Motivation
The XA datasource class in the MySQL JDBC driver has changed
between versions 5.1 and 8.0. We currently always set
the XA datasource class for version 5.1, which doesn't work
when version 8.0 is present.
Modifications
Set the correct XA datasource class of the MySQL JDBC driver
based on presence of the 8.0 class. If the 8.0 class is present,
it will be used, otherwise the 5.1 class will be set.
Result
MySQL JDBC driver autodetection works fine with MySQL JDBC driver
versions 5.1 and 8.0.

[x] Have you followed the guidelines in our Contributing document?
[x] [v2] Have you created a JIRA and used it in the commit message?
[ ] [v4] Have you created a GitHub Issue and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

@juangon This is a proper fix, thanks again for the bug report!


Direct access of d-under members outside the containing class should be forbidden

..., and access using their mangled names should be allowed.
Environment data

Language Server version: 2021.9.3-pre.1
OS and version: Windows 7
Python version (& distribution if applicable, e.g. Anaconda): 3.8.11 Anaconda

Sample code
class C:
    __var: object = None

c = C()

_ = c.__var  # Line A
c.__var = 0  # Line B

_ = c._C__var  # Line C
c._C__var = 0  # Line D

Expected behavior
Line A & line B are invalid, while line C and line D are valid.
Actual behavior

Pylance is emitting errors for Line C & D (as it should), but it's not reporting errors on A & B. So I agree this is a false negative because A & B will result in runtime exceptions.
For what it's worth, the current behavior is consistent with mypy. That doesn't mean it's correct.

Actually, pylance does correctly emit errors on A & B if you enable the reportPrivateUsage diagnostic rule. This rule is disabled by default in basic type checking mode. So I think the behavior is correct.

Ah, I've forgot that I disabled reportPrivateUsage because I needed to access s-under members across different classes. Closing.