[HELP NEEDED] Menu not updated during recreation

Hi,
While using Moxy faced task to defer view state recreation in Fragment to certain point (in my case when menu is loaded).
In order to achieve this, I created AttachableMvpFragment, which allows subclasses to attach at certain point (code in the end).
Now, when I make recreation, methods that manipulate menu are re-called as needed, however Menu is not updated. Despite this, when these methods are called when user clicks UI button, menu is changed correctly.
I know this is not direct issue with Moxy, however you may have witnessed it before and may have solution?
In case of code below, manipulateMenu is recalled after orientation change, but menu is not getting updated.
BarView.java
public interface BarView extends MvpView {
   void manipulateMenu();
}

FooFragment.java
public class FooFragment extends AttachableMvpFragment implements BarView {
private Menu menu;
@InjectPresenter RandomPresenter presenter;

public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
   this.menu = menu;
   onCustomAttachPointReached();
   ...
}

// called from presenter
public void manipulateMenu() {
   menu.findItem(R.id.some_item).setDrawable(null);
}
}

AttachableMvpFragment.java
import android.app.Fragment;
import android.os.Build;
import android.os.Bundle;

import com.arellomobile.mvp.MvpDelegate;
import com.arellomobile.mvp.MvpFragment;

/**
 * Date: 19-Dec-15
 * Time: 13:25
 *
 * @author Yuri Shmakov
 * @author Alexander Blinov
 * @author Konstantin Tckhovrebov
 */
@SuppressWarnings("ConstantConditions")
public class AttachableMvpFragment extends Fragment {

    private boolean mIsStateSaved;
    private MvpDelegate<? extends MvpFragment> mMvpDelegate;

    private boolean isCustomAttachPointReached;

    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        getMvpDelegate().onCreate(savedInstanceState);
    }

    public void onCustomAttachPointReached() {
        mIsStateSaved = false;

        getMvpDelegate().onAttach();
        isCustomAttachPointReached = true;
    }

    public void onSaveInstanceState(Bundle outState) {
        super.onSaveInstanceState(outState);

        mIsStateSaved = true;

        getMvpDelegate().onSaveInstanceState(outState);
        getMvpDelegate().onDetach();
    }

    @Override
    public void onStart() {
        super.onStart();
        if (isCustomAttachPointReached && isDetached()) {
            mIsStateSaved = false;

            getMvpDelegate().onAttach();
        }
    }

    @Override
    public void onResume() {
        super.onResume();
        if (isCustomAttachPointReached && isDetached()) {
            mIsStateSaved = false;

            getMvpDelegate().onAttach();
        }
    }

    @Override
    public void onStop() {
        super.onStop();

        getMvpDelegate().onDetach();
    }

    @Override
    public void onDestroyView() {
        super.onDestroyView();

        getMvpDelegate().onDetach();
        getMvpDelegate().onDestroyView();
    }

    @Override
    public void onDestroy() {
        super.onDestroy();

        //We leave the screen and respectively all fragments will be destroyed
        if (getActivity().isFinishing()) {
            getMvpDelegate().onDestroy();
            return;
        }

        // When we rotate device isRemoving() return true for fragment placed in backstack
        // http://stackoverflow.com/questions/34649126/fragment-back-stack-and-isremoving
        if (mIsStateSaved) {
            mIsStateSaved = false;
            return;
        }

        // See https://github.com/Arello-Mobile/Moxy/issues/24
        boolean anyParentIsRemoving = false;

        if (Build.VERSION.SDK_INT >= 17) {
            Fragment parent = getParentFragment();
            while (!anyParentIsRemoving && parent != null) {
                anyParentIsRemoving = parent.isRemoving();
                parent = parent.getParentFragment();
            }
        }

        if (isRemoving() || anyParentIsRemoving) {
            getMvpDelegate().onDestroy();
        }
    }

    /**
     * @return The {@link MvpDelegate} being used by this Fragment.
     */
    public MvpDelegate getMvpDelegate() {
        if (mMvpDelegate == null) {
            mMvpDelegate = new MvpDelegate(this);
        }

        return mMvpDelegate;
    }
}

I came to conclusion that this issue is not related to Moxy.


Add network port support for glances component.

Description:
Glances supports network port monitoring, but the home assistant component does not. Added support for one tcp port, one web host and one icmp per instance of each glance sensor. These elements can be configured using the three new keywords shown below. Note that only one of each type is supported: it finds the first of each type, saves that record, and breaks out of the loop. This approach is required because the glances api offers no way to directly address each port entry.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10085
Example entry for configuration.yaml (if applicable):
  - platform: glances
    host: <IP_ADDRESS>
    name: My Test Server
    version: 3
    resources:
      - 'network_ping'
      - 'network_port'
      - 'network_web'

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @wellspokenman,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@wellspokenman are you planning to continue here?

To get this merged, the CI has to pass.

It's also require a rebase now as the glances integration supports config flow.

Let's close here. There's been no response or movement for two months.

A new PR is welcome when there's time to continue.


[FEAT] CI should cache and use prior develop builds when building develop

:bulb: Feature request
Feature Name
Incremental Develop Builds
The Desired Behavior
I would like develop builds to be a bit faster.

Prior Work
NX may have some inspiration or insight into accomplishing this.

Closed by #2420 #2419 #2418


Fix for cpp examples in mxnet/cpp-package.

Refactored makefile
Added macro to check for using GPU/CPU
Changed cpp files to use correct data set
Added error checking for data files
Added few more instructions in ReadMe.md

There is still two issues remaining:

inception_bn.cpp still fails on InferArgsMap
lenet.cpp uses
const char *train_data_path = "./train.csv";
Need to determine where to get .csv file from.

github issue: https://github.com/apache/incubator-mxnet/issues/9814
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Thanks for fixing these, that's great! As commented in the file, it would be nice to factorize all this similar code into a utils function that can be loaded in each test to make future updating easier. I was wondering if we could have an integration test that builds and run these examples to make sure we don't end up again in a situation where it is completely broken?

@nihui  I was trying to get appropriate .rec files, but couldnt get a hand on .rec and .lst  which works. If you know where I can  get these files, I can give it a shot.

@szha  Could you please review the change ?


feat: add execution info V1 syscall

Codecov Report
Attention: Patch coverage is 0% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 77.10%. Comparing base (d479f5c) to head (fe426a3).

Files
Patch %
Lines

...blockifier/src/execution/native/syscall_handler.rs
0.00%
50 Missing :warning:

Additional details and impacted files
@@               Coverage Diff               @@
##           native2.6.3      #84      +/-   ##
===============================================
- Coverage        77.45%   77.10%   -0.36%
===============================================
  Files               78       78
  Lines            10771    10821      +50
  Branches         10771    10821      +50
===============================================
  Hits              8343     8343
- Misses            1895     1945      +50
  Partials           533      533

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Write simple fingering enumeration algorithm

We need to write an algorithm that enumerates fingering states for a given set of notes.
Input: An array of type Note[] containing all the notes being played at a given time
Output: A array of type FingeringState[] containing all the possible fingering states for the given set of notes.
Current constraints:

The hand cannot move.
Fingers cannot cross over one another.

Specifics:

Returns an error if the notes cannot be played with the given constraints

https://docs.google.com/document/d/1gBkU89XLWgaahsnRjlPmHvMwvkgi4K4KTkR29OqLoHo/edit


Made php example configurable

Signed-off-by: Villu Roogna<EMAIL_ADDRESS>

Superseded by #26


Ros2

@civerachb-cpr This should be ready to merge.  Not sure what you want to do about the conflicts but if you're not too attached to your changes you could just over write them with this.
I would squash merge to clean up commits as well.

@mhosmar-cpr  I've reverted the 2 changes I made. I think this is ready to merge.


ScrollAnywhere crash

After? some recent updates
after clicking on ScrollAnywhere icon to disable it
supermium crashing
at least in single process mode
(not checked on "fresh" profile)

This is the result of a permissions issue where the main process is blocked from loading the extension URLs (only dedicated extension processes can do so). This will be fixed so the main process can load the extension URLs in single-process mode.

yep crashing fixed
but there is glitches on turn on/off
it can't be temporally turn off
even if open new tab
and now after several restarts it turns off and doesn't turn ons
but it displays that it turn on
and switch doesn't save position...


adding 8 new connectors for Tableau

Coverage remained the same at 98.913% when pulling 301422ab260070d8830554594e35a11cbd49fd0b on RalucaAPascu:patch-4 into a93717242f671815ef282ce404afbfdcb406aa91 on tableau:master.


Dragging folder to iCloud results in multiple errors about a feed that can’t be found and can’t be added

I dragged my Programming folder from Feedbin to iCloud. The app read a bunch of feeds — I could tell because the unread count went way up.
But I got about a half-dozen error dialogs: “The feed couldn’t be found and can’t be added.”
Afterwards: I still see a Programming folder in Feedbin, and I don’t see that folder in iCloud.
But I do see a bunch of unread articles in All Unread that would be coming from the Programming folder in iCloud.

Later — I went to quit, and got the same long delay previously reported. I’ve put that sample in #2726.

Later — I went to quit, and got the same long delay previously reported. I’ve put that sample in #2726.

  That is why you get that error message.  We've never copied dead feeds in any account type before.  Do we want to start copying dead feeds?

  That is why you get that error message.  We've never copied dead feeds in any account type before.  Do we want to start copying dead feeds?

When copying feeds in the sidebar to the iCloud account, all the feeds should copy. Even if they’re dead, even if they return 404 or whatever.
We should display that error message only when manually adding a feed to the iCloud account.

When copying feeds in the sidebar to the iCloud account, all the feeds should copy. Even if they’re dead, even if they return 404 or whatever.
We should display that error message only when manually adding a feed to the iCloud account.

I assume you want this change for all account types?  This isn't an iCloud specific issue.

I assume you want this change for all account types?  This isn't an iCloud specific issue.

Duplicate of #2725

Duplicate of #2725


Strange behavior after last upgrade - Wifi issue

I can explain why it's happening but I upgraded some months ago to the latest release and the Wifi was not working so one or two days later you posted a new release. I downloaded, reverted the changes, and did the upgrade. The first day everything was fine wifi and Bluetooth but after a normal shutdown and boot the wifi exclamation mark appeared.
Today I downloaded the latest release, disabled SIP, and did the post patch process. My system stoped booting. So I changed the EFI files for the files on my personal flash drive (backup) and the system booted normally with wifi and Bluetooth working. So to test I rebooted the Mac and wifi and Bluetooth stoped working again, without any changes.
Any clue about how could I debug or investigate to understand why that's happening?

From the currently installed version:

If I install the latest (5.01) EFI.OpenCanopy.AudioDxe.zip the system doesn't boot even reverting the patching process.

If I patch the currently installed the Wifi works but Bluetooth doesn't.

You can try disabling SIP to debug:
csr-active-config -> data -> 03080000
NVRAM -> Add -> 7C436110-AB2A-4BBB-A880-FE41995C9F82 -> boot-args (add the parameters): amfi=0x80 ipc_control_port_options=0 gfxrst=1 -brcmfxbeta
Making above changes will break external monitor support. Sometimes I got the error with wifi, so I used 2 active EFI. Plugged in with SIP enabled and ethernet cable and on the go with SIP disabled. Didn't find a definitive solution for the issue and  bought a MacBook Pro 16" M1. Dell G5 is with my wife now, but I have a working sonoma in a backup disk. When I have spare time I'll update OpenCore to see if the issue is resolved with latest version.

With that config I got the Bluetooth working, the external USB-C monitor is working but the Wi-Fi is not.
It's crazy that the Open Patcher says that SIP is enabled.

I cleaned the machine, and installed the Ventura version, so now to upgrade to Sonoma I need to install the latest version or the one before the latest?

Before and after upgrade to the latest image:

Try to run the update with EFI.OpenCanopy.AudioDxe.zip using OpenCore 0.9.4. And confirm in OpenCore Legacy Patcher if there's no root patches applied because it generate update issues when enabled.


CommonJS Support Does Not Work with Webpack

Hello,
I use webpack and I wanted to try out the repeater, so I did something like:
var $ = require("jquery/dist/jquery");
require("fuelux/dist/css/fuelux.css");
require("fuelux/js/repeater.js");

However, the error from webpack is:
ERROR in ./~/fuelux/js/repeater.js
Module not found: Error: Cannot resolve module 'fuelux/combobox' in C:\workspace\app\node_modules\fuelux\js
 @ ./~/fuelux/js/repeater.js 17:2-112

I can see in repeater.js, the code like this:
define(['jquery', 'fuelux/combobox', 'fuelux/infinite-scroll', 'fuelux/search', 'fuelux/selectlist'], factory);

In order to work with webpack, I believe it could be like below. Why does it need those fuelex prefixes? Doesn't seem right.
define(['jquery', './combobox', './infinite-scroll', './search', './selectlist'], factory);

Alternatively, you could change your wrapper to have the module.exports clause first:
if (typeof exports === 'object') {
	// Node/CommonJS
	module.exports = factory(require('jquery'));
} else if (typeof define === 'function' && define.amd) {
    }

I have seen some projects do it that way.
For more information about how webpack handles this situation, see this issue.

@dlandis I agree that they should be using relative paths, but this library was built with requirejs's amd in mind, where typically you'd define a path for fuelux in your config.  I'm sure a pull request here would be welcome.
https://github.com/exacttarget/fuelux/blob/master/DETAILS.md#amd-support
The equivalent approach in webpack would be to use an alias.
resolve: {
  alias: {
    fuelux: __dirname + '<path to deps>/fuelux/js' // This would be different depending on your package manager.
  }
}

Note: You'll have some additional trouble including individual modules, as the modules don't declare any of their bootstrap dependencies either.


What about white space?

I read through the README, looking to see if values are trimmed of white space.  From the fact that there are no spaces around the equals, I could assume that white space is not trimmed (because if there was a space after the equals, it would be the first character of the value).  But from the fact that I saw a comment after a value, I could guess that white space after the value (and before the comment) is trimmed.
Perhaps you could talk about trimming white space, or not, in the README.

You cannot have whitespace right of the equals sign until you quote the value. This will result in a parse error. If you are ever in doubt of the behaviour, checkout the tests. They are the best documentation! :)

Yes, whitespace around both names and their values is removed. If the value is quoted, then whitespace inside the quotes is preserved. https://github.com/vlucas/phpdotenv/blob/v5.3.0/src/Parser/EntryParser.php#L73


remove function creating credential add command

What does this change
Delete unused porter credentials add stub command
What issue does it fix
Closes #891
Checklist

[x] Unit Tests
[ ] Documentation

[x] Documentation Not Impacted

/azp run porter-integration


Ensure we install tmux

tmux is a widely used software, and usually we install it manually as
soon as we jump on a host. It was included only on controller-0, but we
also use it from the hypervisor directly.
Let's make that software available anywhere.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/lgtm


⚠ Samsung has degraded performance

In a588722, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2386 ms

Resolved: Samsung performance has improved in 50ca4c3.


Added missing test case to test extraction with naming strategy and strategy

It should increase coverage just a small bit

Thanks, @webimpress!


GS updates

Testing a git flow, you've seen the changed in this pr before

The failed CI test is the same one that failed in https://github.com/dwavesystems/dwave-ocean-sdk/pull/198


fix: pagination: Issues with VisiblePagerCountSize

SUMMARY:

Currently, we show at least 10 pages before we show the quick previous and quick next arrows. This is not suitable for smaller UIs with limited width like a Chrome Extension.

Solution: SHORT_LIST_THRESHOLD is set to 10 right now. To address the issue, we allow to change this limit to 8 pages in case visiblePagerCountSize is set to 5

When visiblePagerCountSize is 5, there is also another bug where some of the page numbers are not visible even though they are active. See the 5th page number in the below video

https://user-images.githubusercontent.com/106535945/235666857-58341b86-f7ec-44ff-8a14-6b2cb7c8709b.mov
Solution: EDGE_LIST_THRESHOLD is set to 5 right now. To address the issue, we allow to change this limit to display 3 pages between Quick Previous and Quick Next buttons in case visiblePagerCountSize is set to 5

Clean up

Removed an option which allowed  visiblePagerCountSize to be 3 as it doesn't make any visual sense in terms of UI/UX to the user, nor do we use it in any of our products
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-51566
CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:
Test case 1:

Switch to the branch of PR
Run storybook
Go to pagination
Set visiblePagerCountSize to small, pageSize to 10, total to 80
8 pages should be displayed

Test case 2:

Switch to the branch of PR
Run storybook
Go to pagination
Set visiblePagerCountSize to small, pageSize to 10, total to 81
9 pages should be displayed with Quick Previous and Quick Next

Test case 3:

Switch to the branch of PR
Run storybook
Go to pagination
Set visiblePagerCountSize to small, pageSize to 10, total to 81
Switch to 5th page by clicking on next button only
You should see the 5th page active.

@rnori-eightfold
"Removed an option which allowed visiblePagerCountSize to be 3 as it doesn't make any visual sense in terms of UI/UX to the user, nor do we use it in any of our products"
Let's deprecate it and remove in v3.0.0 as part of the next major release. Octuple usage is such that any change to the API contracts must only be made as part of major releases.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6db0dc9). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Current head d2d2ba1 differs from pull request most recent head f371049. Consider uploading reports for the commit f371049 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage        ?   84.63%
=======================================
  Files           ?      795
  Lines           ?    17503
  Branches        ?     6232
=======================================
  Hits            ?    14814
  Misses          ?     2623
  Partials        ?       66

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Limit memory usage of thresholds statistics

This PR contains changes that make it possible to limit threshold statistics by rounding the "decision" value that thresholds are based on.  This allows a user to effectively reduce the number of thresholds that are stored in revscoring.Model.info for probability based models.
https://phabricator.wikimedia.org/T177544

A late followup: I've smoke tested on a small training set, and the threshold rounding worked perfecftly at both 3 and 2 decimal places.


KeyValueType should be Record<string, any> instead of Record<string, string>

https://github.com/dapr/js-sdk/blob/8bfda5b1e6ea46a8ca02ac22481e3ffec0dde4bd/src/types/KeyValue.type.ts
should be changed to string, any instead of string, string

Would it make more sense to use the unknown type for this? https://devblogs.microsoft.com/typescript/announcing-typescript-3-0-rc-2/#the-unknown-type


Plug.Conn being created with remote_ip as local?

hi!
https://github.com/mtrudel/bandit/blob/26900d097c35741430c30b6b7fae68c5e3451fd2/lib/bandit/pipeline.ex#L42
I've tried switching Phoenix recently to use Bandit (and am loving it), but I noticed that the remote IP address in my access logs are now showing as my local address, rather than the actual remote/peer address.
I think this is the culprit -- here in build_conn(), should sockname instead be peername?

Yep, that is indeed the culprit; looks like I introduced this a few months ago during a refactor. I don't really see a clear way to get this under test since both the peer and local are localhost, but I'll figure something out.
In the meantime this is fixed in b3a0552 and released in 1.0.0-pre.15. Thanks for the bug!

Thanks for the quick fix! (And yes, I'm also curious to see how to address it in tests, without resorting to something heavy like a multi-host docker-compose sandbox, etc.)


[DECISION-318] Change log path in log4j file

:shipit:

Comment accepted. Will treat it ASAP on Jenkins

Rebase && testing in progress

Comment accepted. Will treat it ASAP on Jenkins

Rebase && testing in progress

Comment accepted. Will treat it ASAP on Jenkins

Rebase && testing in progress


fix not linking to dbus

I have been wondering why this did not cause problems before but dbus is not linked in the shared library.
#4 is also happening now for me (new mpv version).
[mpv_inhibit_gnome] C plugin error: '/app/etc/mpv/scripts/mpv_inhibit_gnome.so: undefined symbol: dbus_bus_get'
[mpv_inhibit_gnome] Could not load SO plugin /app/etc/mpv/scripts/mpv_inhibit_gnome.so

It would be nice if makefile honored CFLAGS/LDFLAGS env variables. Currently it unconditionally adds -g and doesn't use any compiler/linker optimization

@Erick555 what do you think of building with meson, instead :smile:
https://github.com/Deminder/mpv_inhibit_gnome/blob/meson-build/meson.build

Well, it depends on what is upstream preference. BTW: why prefix=/etc?

why prefix=/etc?

For a default (non-flatpak) system-wide install.
./install.sh flatpak installs to flatpak config dir https://github.com/Deminder/mpv_inhibit_gnome/blob/meson-build/install.sh

Nice work, LGTM. I'll tag a new release with this fix in a few hours.

It would be nice if makefile honored CFLAGS/LDFLAGS env variables. Currently it unconditionally adds -g and doesn't use any compiler/linker optimization

What should it look like?
Would simply doing
CFLAGS += $(shell pkg-config --libs --cflags dbus-1)

be enough?
Or should we also change the compilation commands to also use LDFLAGS?

For a default (non-flatpak) system-wide install.

The project README says system-wide install path is /usr/share/mpv/scripts.

What should it look like? Would simply doing
CFLAGS += $(shell pkg-config --libs --cflags dbus-1)

Yeah, it should work like that

be enough? Or should we also change the compilation commands to also use LDFLAGS?

Maybe like below:
CFLAGS += $(shell pkg-config --cflags dbus-1)
LDFLAGS += $(shell pkg-config --libs dbus-1)
then:
gcc $(CFLAGS) $(LDFLAGS) ...

Would you mind opening a PR with your suggestions? Otherwise I'll do that myself in a few days.

I'm pretty busy right now so It's possible that I wouldn't find the time before you do :smile:

No worries!


Add more tests for newly added features (incomplete)

I plan to add tests for the new command !!/scan and the post analysis in !!/report.
When complete, I'll drop the notice in the title.

Coverage remained the same at 64.657% when pulling c49e2fbad7b994ab3b2af27d1d254d4fc9b96b17 on iBug:patch-4 into f9ecbe6d6872a9c9ed8bf9499441817032ae0568 on Charcoal-SE:master.

!!/approve


Greedy meshing stretches textures

When using the greedy masher textures are stretched across a face instead of tiling.

Fixed in 51b26a


[cailbre] Calibre add-on can access all of the /config directory

calibre
Which addon?
calibre
Describe the solution you'd like
Currently the calibre add-on uses /config/addons_config/calibre as it's directory for both the library and all of the app config. This ends up giving the add-on full access to the home-assistant config directory. I'm fairly new to add-on development, but would it not be possible to use the share mount to read/ write the database rather than exposing all my Home Assistant data to the add-on?

Hi, just set the UID and PGID in your addon to a specific user. The addon will load with those credentials and it won't be able to access the other config files. Currently all my addons use the config folder for their storage so it would be too complex to move all of them... I could add an option to define the location of the data directory, but as the config folder is still mounted it will only hide the issue and not replace it. And removing the access to config is not an option as it would mean all other users will lose access to their data... In short I think using uid/gid, although inconvenient as your files will need to have the same permissions, is the best way to prevent calibre from accessing to your HA config files


docs: Add examples for simple cloudfront issue

Description
This pull request includes a new example under the examples/ directory demonstrating how to utilize the module.
Motivation and Context
The introduction of this example addresses a gap in documentation, offering users another example to understanding the module's functionality.
Changes Introduced

New Example Added: A comprehensive example has been added to the examples/ folder. This example illustrates the module's use in a typical deployment scenario, ensuring users have a practical reference.
Documentation Updated: Relevant documentation has been updated to reflect the addition of the new example, ensuring all references and instructions are current.

Breaking Changes
This change does not break backward compatibility with the current major version of the module. The modifications are additive and solely focused on expanding the existing documentation and examples.
How Has This Been Tested?

I have added a new example under examples/ which users can deploy to understand the changes.
The changes have been tested locally by deploying the new example, ensuring that it performs as expected without disrupting existing functionality.
Additionally, pre-commit run -a has been executed to validate the changes against the repository's existing tests and coding standards.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This practical test will help in understanding the impact of the changes and confirming that there are no disruptions to the expected behavior.

I don't see enough value in such reduced example.
More info - https://github.com/terraform-aws-modules/terraform-aws-cloudfront/issues/141#issuecomment-2093065612


submit .NET SDK for attestation

This the .NET SDK for attestation

@shleiAmy, please make sure all checks pass.

all the check pass.

@erich-wang all the check pass. please approve this pull request, Thank you.

@erich-wang Hi, erich, could you please approve this pull request? all the checks pass. I was waiting for the pull request to close to publish nuget package. Thank you.

@erich-wang it still shows Merging is blocked, could you please merge this pr ? Thank you.


Convert to BDD tests

I decided to move away from XCTest to Quick and Nimble mainly for:

Easy to read tests
Better failure messages

The down side is

you will need to do carthage checkout to setup the project
Possible too many nested context

Current coverage is 100% (diff: 100%)

Merging #13 into master will not change coverage

@@           master   #13   diff @@
===================================
  Files           3     3
  Lines          21    21
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           21    21
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 6cd00c0...f4fd856


docs: add containerd private registry configuration

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Add containerd private registry configuration.

Related Issue
Fixes #1065

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Chinese docs https://github.com/dragonflyoss/Dragonfly2/blob/main/docs/zh-CN/runtime-integration/containerd/mirror.md


[BUG] - 2.12 auth redirect resets query

Describe the bug
When a user is forced through auth redirects either for initial login or reauth after timeout the query they were navigating to or previously loaded is lost and they are directed back to the homepage of dashboards
To Reproduce
Steps to reproduce the behavior:

Setup an openid provider
Hook up to dashboards
Navigate to a known query URL assuming you do not have active auth
Get directed to home

Expected behavior
It load whatever you were on before the redirect took effect
OpenSearch Version
2.12
Dashboards Version
2.12
Plugins
Inbuilt Security One
https://github.com/Aiven-Open/prometheus-exporter-plugin-for-opensearch

I believe this is likely to be the relevant part of the config. We install via the helm chart approach in case that matters
opensearch_dashboards.yml: |
    opensearch.hosts: [https://opensearch-cluster-client:9200]
    opensearch.ssl.verificationMode: none
    opensearch.requestHeadersWhitelist: [authorization, securitytenant]

    opensearch_security.multitenancy.enabled: false
    opensearch_security.multitenancy.tenants.preferred: [Private, Global]
    opensearch_security.readonly_mode.roles: [kibana_dashboards]
    opensearch_security.cookie.secure: true
    opensearch_security.auth.type: "openid"
    opensearch_security.openid.connect_url: "https://dex.${env}.${infra_domain}/.well-known/openid-configuration"
    opensearch_security.openid.client_id: "opensearch"
    opensearch_security.openid.client_secret: "${opensearch_client_secret}"
    opensearch_security.openid.base_redirect_url: "https://logs.${env}.${infra_domain}"
    opensearch_security.openid.scope: "openid email profile groups offline_access"
    server.host: '<IP_ADDRESS>'

[Triage] @dhumphries-sainsburys Thank you for filing this issue and providing your configuration.
There was a PR that went into 2.12 that is related to nextUrl for openid that should resolve the issue, but I see that you are using 2.12.
Could you post the network calls on login during the issue? You can contact maintainers on the OpenSearch Slack with details.

I have the same problem on 2.12. I think "redirectHash" is getting dropped during the redirect to the IDP.
In the call to /auth/openid/login?nextUrl=%2Fosd%2Fapp%2Fdata-explorer%2Fdiscover&redirectHash=true, I noticed that the returned cookie has redirectHash set to false
{ oidc:
   { state: '...',
     nextUrl: '...',
     redirectHash: false },
  authType: 'openid' }

Then once the IDP redirects the browser to /login?code=whatever, I don't see /auth/openid/redirectUrlFragment ever getting called after.
Doesn't schema.boolean() at routes.ts#L102 convert the string to an actual boolean, so the strict equality test at routes.ts#L138 always fails ?

I can confirm that this bug occurs in 2.12.0 and 2.13.0, it essentially breaks login flow for deploying the dashboard on a subpath since after logging the user end up on / (which in my case has nothing running).

I can confirm this bug continues to still be present in 2.15.0 .

This bug still exists on 2.15.0

Still around on 2.17.1 just in case anyone stumbles across this issue and has hope


Documentation for Card Upgrade Example revised

This PR closes #760.
The card upgrade example documentation now aligns with the documentation for other components and also compares pf3 and pf4:
| PF3 Class | Applied To | PF4 Class | Applied To | Outcome |
Also edit the pf4 card to update with the latest handlebars params.

Deploy preview for pf-next ready!
Built with commit 8295d7cd2db9066608ac668669b4de3a43ffe22d
https://deploy-preview-761--pf-next.netlify.com

The .md file looks like it's good. I'm seeing a weird thing where if I go to another page and back here, the styling changes, possibly being affected by PF3 styles? I'm not really sure what's going on.

@srambach I think you are referring to nav styles changing, thats a workspace styling change that Dana is eventually going to make once we work out what to do with the demos!

This looks good to me. I think eventually we will want to revisit what the PF3 example should be revised. This should come up with the migration work that @LHinson and @mcarrano are working through.


Fix typechecking

Pull Request Description

Fix issue where playwright-report/ is being typechecked by npm run typecheck in the dashboard, causing CI to fail
Attempt to fix flaky dashboard test

Important Notes
To test that typechecking isn't completely broken, it's recommended to intentionally create a type error in the dashboard code base.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@PabloBuchu would be nice to get this merged in soonish btw - it fixes a test that is causing failures (due to flakiness) on other PRs

oh nvm


#1289 Env swarm parameter lost on the eval help message

A clean version of PR1326 - I've since redid the branch from CLI, the tool messed up the origin tracking.

LGTM

/cc @nathanleclaire

Would you mind squashing these commits?  Thanks!

Done and done :+1:

LGTM

/cc @nathanleclaire

Hi, giving this PR a bump, it's been over a month, and all checks are green - anything else one should do to get it in?

I'm sorry to be so late to say this, but I'm pretty hesitant about this.  I'd prefer to keep the logic around this section as simple as possible since it's already kind of hairy and needs to work on several different platforms.  Do you feel like it's confusing for users who want to activate their swarms that they need to remember --swarm flag?

Also note that with this PR, you have to use --swarm flag with env to get the hint in that text, which naturally implies that you already know about it.
I think that if the concern is around notifying users how to connect to a newly created swarm master (which is what --swarm option for env is used for), we might be better off simply adding a new comment line to a created master, which says something like:
$ docker-machine env kitematic
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://<IP_ADDRESS>:2376"
export DOCKER_CERT_PATH="/Users/nathanleclaire/.docker/machine/machines/kitematic"
export DOCKER_MACHINE_NAME="kitematic"
# Run this command to configure your shell:
# eval "$(docker-machine env kitematic)"
# If you want to talk to the Swarm master, remember to use the --swarm flag with env.

An updated PR can be found here. It fixes the problem with --swarm and --no-proxy and fixes the hint printed for fish shell.

I think this is fixed in master with a @dgageot PR.  Please re-open if that is not correct.


⚠ Bofrost.de has degraded performance

In c0d6a85, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1302 ms

Resolved: Bofrost.de performance has improved in 97f959b after 8 minutes.


ArchetypeStore is Disposed when new World is destoryed.

In MagicTweenInitializationSystem, ArchetypeStore.Initialize() and ArchetypeStore.Dispose(), is calling when any World is created and disposed.
It cause the NativeArry coreComponentTypes disposed, after any World disposed. This will cause the following error when using MagicTween later:
ObjectDisposedException: The Unity.Collections.NativeArray`1[Unity.Entities.ComponentType] has been deallocated, it is not allowed to access it
Suggestion:

Add a checking for the World created and disposed.
Don't use static for coreComponentTypes, created it in every World.
Make Initialize() and Dispose() public to users.

BTW, good job for the library. I like it very much.

From v0.1.2, a World check was added to the initialization process of MagicTweenInitializationSystem to prevent it from being called multiple times.
(This works, but may not be a very good solution. I'm still working on the design when using multiple worlds.)


Triple attachment support non-ASCII characters (#12904)

What is the purpose of the change
fix #12904
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #12905 (f4d9c76) into 3.2 (ceae48e) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12905      +/-   ##
============================================
- Coverage     69.81%   69.46%   -0.35%
+ Complexity      341        2     -339
============================================
  Files          3523     1648    -1875
  Lines        167515    68404   -99111
  Branches      28043     9993   -18050
============================================
- Hits         116953    47518   -69435
+ Misses        40473    16301   -24172
+ Partials      10089     4585    -5504

see 1909 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I suggest to URLencode the value directly.

already done. I thought too complicated before

I suggest to URLencode the value directly.

Sorry I didn't understand what more controllable means, could you please be more specific?
the dubbo protocol does not need URLencode, is it not convenient to judge protocol in the filter?


feat(satp-hermes): update message formats to reflect latest SATP core version

Update message types according to latest draft: draft-ietf-satp-core-02, available at: https://datatracker.ietf.org/doc/draft-ietf-satp-core/
For example, for the Lock Assertion Receipt Message ( section  8.2.), the specification requires a  message_type with content: "urn:ietf:satp:msgtype:assertion-receipt-msg".
The current implementation calls the lock assertion receipt as "lock evidence claim": packages/cactus-plugin-odap-hermes/src/main/json/openapi.json (line 269). One needs to change the wording in open-api.json and update it throughout the code.
@petermetz please assign it to me. @AndreAugusto11 and I are managing these tasks.
--
draft-ietf-satp-core-02

@RafaelAPB Assigned, thank you again!

@petermetz can i suggest you add a "P" to the label, as in "IETF-SATP"? Thank you!

@petermetz can i suggest you add a "P" to the label, as in "IETF-SATP"? Thank you!

@RafaelAPB Yup, I renamed it just now! Thanks for the suggestion!

working with @ AkashWarlocks on this

working with @AkashWarlocks on this

@RafaelAPB I can only assign issues to people who have commented on it, e.g.: I can update the assignment to contain both of you as soon as @AkashWarlocks drops a comment here as well.

Thanks @RafaelAPB. Will update!

Thanks @RafaelAPB. Will update!

@AkashWarlocks Thanks for the comment, now I was able to assign the task to you as well!


java.util.UnknownFormatConversionException: Conversion = ';' from GitHubChecksPublisher.publish

Seen in https://ci.jenkins.io/job/Plugins/job/jjwt-api-plugin/job/PR-21/1/console building https://github.com/jenkinsci/jjwt-api-plugin/pull/21:
 [GitHub Checks] GitHub check (name: Jenkins, status: COMPLETED) has been published
 java.util.UnknownFormatConversionException: Conversion = ';
 	at java.base/java.util.Formatter.checkText(Formatter.java:2732
 	at java.base/java.util.Formatter.parse(Formatter.java:2718
 	at java.base/java.util.Formatter.format(Formatter.java:2655
 	at java.base/java.util.Formatter.format(Formatter.java:2609
 	at java.base/java.lang.String.format(String.java:2897
 	at io.jenkins.plugins.util.PluginLogger.log(PluginLogger.java:47
 	at io.jenkins.plugins.checks.github.GitHubChecksPublisher.publish(GitHubChecksPublisher.java:92
 	at io.jenkins.plugins.checks.status.BuildStatusChecksPublisher.publish(BuildStatusChecksPublisher.java:63
 	at io.jenkins.plugins.checks.status.BuildStatusChecksPublisher.access$000(BuildStatusChecksPublisher.java:42
 	at io.jenkins.plugins.checks.status.BuildStatusChecksPublisher$JobCheckoutListener.lambda$onCheckout$0(BuildStatusChecksPublisher.java:174
 	at java.base/java.util.Optional.ifPresent(Optional.java:183
 	at io.jenkins.plugins.checks.status.BuildStatusChecksPublisher$JobCheckoutListener.onCheckout(BuildStatusChecksPublisher.java:174
 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:150
 	at …

I see, java.util.logging.Logger has a log(Level level, String msg, Throwable thrown) method that takes a literal string, but PluginLogger has only log(String format, Object... args).  BuildStatusChecksPublisher then calls both with the same string.
https://github.com/jenkinsci/github-checks-plugin/blob/1c4caf9289437bfe54dc304e50d485d24c56e6d3/src/main/java/io/jenkins/plugins/checks/github/GitHubChecksPublisher.java#L89-L93
PluginLogger.log has a @FormatMethod annotation, though. Would that allow the bug to be detected in static analysis?

Why not just bypass PluginLogger in this case and print directly to the build log however you prefer?

Which is preferable anyway in the case of an unexpected exception. Typically via https://javadoc.jenkins.io/hudson/model/TaskListener.html#error-java.lang.String- + https://javadoc.jenkins.io/hudson/Functions.html#printStackTrace-java.lang.Throwable-java.io.PrintWriter-

AFAIK, this can be called from BuildStatusChecksPublisher.JobScheduledListener.onEnterWaiting before there is a Run and a build log.

We don't have direct access to the task listener here -.-
Looks like more a bug with plugin-util-api-plugin @uhafner.
If there's no args being passed we shouldn't try and format it?
It's a shame we don't have the actual io exception either, i guess it's in the system log if anyone wants to dig it out

I expect buildLogger.log("%s", message + e) would suffice here.

it's in the system log if anyone wants to dig it out

No idea. I do not have access. Whatever the original error was, it seems to have been transient, as a simple rebuild worked.

I expect buildLogger.log("%s", message + e) would suffice here.

yes probably


Made file structure compatible with HACS

With this pull request a user can install this repository via a custom repo in HACS.
In order for this to work the repo needs a tag, but no release! Otherwise HACS will not import it correctly. You can look at my fork (my fork is amazing) how the tag should look.
https://hacs.xyz/docs/publish/start

I made a new PR with the correct branch selected


Changing ID field using isId not working for admin-bro-mongoose

It is a common pattern to replace the "_id" field of mongoose by the given "id" virtual when calling toObject or toJSON on a mongoose model instance to have a clean and concise API output. Using admin-bro with admin-bro-mongoose, I tried to change the id field accordingly using isId:
const adminBro = new AdminBro({
  resources: [
    {
      resource: User,
      options: {
        listProperties: ['name', 'email', 'id', 'role'],
        properties: {
          id: {
            isId: true, // <--- expect this to force adminBro to use this as the actual identifier
          },
        },
      },
    },
...

But it does not have an effect. I can not access any resource in show or edit mode or delete it via the action buttons as it fails finding the id field. It produces links like http://localhost:3000/admin/resources/User/records/show missing the id path param. After further investigation, it seems like the "_id" attribute is a hard coded constant and I could not find out if using PropertyOptions will successfully overwrite it or not: https://github.com/SoftwareBrothers/admin-bro-mongoose/blob/master/src/property.ts
Please someone fix this issue or tell me how I can change the ID field using mongoose, as I don't want to output the "_id" field in my json outputs.
Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Expected behavior
When setting isId: true, I expect the field to be used as the identifier for accessing the show, edit and delete actions.

Hey team, I am facing this same issue, in my case I can't even list the items, because it is missing the ID - Is there any workaround to at least show the items?


Add OpenTelemetry library and expose metrics for Witsml requests

Fixes
#2290
Implements OpenTelemetry metrics:

witsml_requests_duration_seconds (histogram)
witsml_requests_active (counter)

Description
The histogram has been set up with the following buckets: 0.5, 1, 3, 5, 10, 15, 30 and 60 seconds.
When used in an application using the library, the metrics can be added within the AddOpenTelemetry method added by the OpenTelementry SDK:
services.AddOpenTelemetry()
            .WithMetrics(builder =>
            {
                builder.SetResourceBuilder(ResourceBuilder.CreateDefault().AddService("MyApplication"));
                builder.AddWitsmlInstrumentation();

                builder.AddPrometheusExporter();
            });

Example from prometheus export:
# TYPE witsml_requests_duration_seconds histogram
# UNIT witsml_requests_duration_seconds seconds
# HELP witsml_requests_duration_seconds Time spent during requests to a Witsml server
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="0.5"} 31251<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="1"} 31691<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="3"} 31911<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="5"} 31941<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="10"} 31943<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="15"} 31944<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="30"} 31944<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="60"} 31944<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1",le="+Inf"} 31945<PHONE_NUMBER>618
witsml_requests_duration_seconds_sum{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1"} 1171<PHONE_NUMBER>618
witsml_requests_duration_seconds_count{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="1"} 31945<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="0.5"} 27621<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="1"} 27876<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="3"} 27979<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="5"} 27993<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="10"} 27993<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="15"} 27993<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="30"} 27994<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="60"} 27994<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1",le="+Inf"} 27994<PHONE_NUMBER>618
witsml_requests_duration_seconds_sum{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1"}<PHONE_NUMBER>333618
witsml_requests_duration_seconds_count{host="witsml.somewhere.com",method="GetFromStore",objectType="risk",resultCode="1"} 27994<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="0.5"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="1"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="3"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="5"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="10"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="15"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="30"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="60"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_bucket{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2",le="+Inf"} 2<PHONE_NUMBER>618
witsml_requests_duration_seconds_sum{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2"} 0<PHONE_NUMBER>618
witsml_requests_duration_seconds_count{host="witsml.somewhere.com",method="GetFromStore",objectType="log",resultCode="2"} 2<PHONE_NUMBER>618

# TYPE witsml_requests_active gauge
# HELP witsml_requests_active Number of active requests
witsml_requests_active{host="witsml.somewhere.com",method="GetFromStore",objectType="log"} 1<PHONE_NUMBER>618
witsml_requests_active{host="witsml.somewhere.com",method="GetFromStore",objectType="risk"} 2<PHONE_NUMBER>618

All metrics are tagged with host, method and objectType. If available, resultCode is also added as a tag.
Note: This has only been tested in a .NET 8 application.
Type of change

[ ] Bugfix
[x] New feature (non-breaking change which adds functionality)
[ ] Enhancement of existing functionality
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Impacted Areas in Application

[ ] Frontend
[ ] API
[x] WITSML
[ ] Other (please describe)

Checklist:
Communication

[ ] I have made corresponding changes to the documentation
[ ] PR affects application security

Code quality

[x] I have self-reviewed my code
[x] No new warnings are generated

Test coverage

[ ] New code is covered by passing tests

If this is only supported with .NET 8, we will also need to update the version in the dockerfile for our internal server setup. We should also give a heads up and enough time for anyone else using Witsml Explorer that we will no longer support version 7. At least unless it's possible to only enable this when using .NET 8.

If this is only supported with .NET 8, we will also need to update the version in the dockerfile for our internal server setup. We should also give a heads up and enough time for anyone else using Witsml Explorer that we will no longer support version 7. At least unless it's possible to only enable this when using .NET 8.

Good call. I'm not sure if I'm able to fully test this in a .NET 7 environment since I have .NET 8 sdk installed (the Witsml library seems to support multiple versions, currently .NET 6 and 7 although I added .NET 8 in this PR). I'll see if I can create a dummy .NET 7 project and reference a locally built witsml package and see how it goes.
That being said, .NET 8 is the latest LTS release and should be favored over .NET 7. I've also added a PR for updating to .NET 8 here: https://github.com/equinor/witsml-explorer/pull/2293

This PR also fixes an issue with duplicate references in Witsml.csproj that was not discovered in the previous PR (#2293). Discovered in the action that builds and publishes the package after merge.


Add more flexibility to the API

Thank you for the nice package, I add some changes to make it more flexible which fit in my use case without breaking the existing API.
The changes will allow the following:

in appsTransport.go: instantiate AppsTransport without parsing the private key if it is available.
in transport.go: reuse an existing AppsTransport to create a Transport for an installation.

Thanks for the PR, what’s the use case if you don’t mind me asking?

Thank you for your reply.

For the NewAppsTransportFromPrivateKey function: I do load the private key from a package that handles configuration. Since I have the key parsed in *rsa.PrivateKey format; there is no need to reload it when I use this package.
For the NewFromAppsTransport function: I have a webhook listener that needs to create a Transport on each event for the concerned installation, thous no need to recreate the  AppsTransport on each received event from Github.

@wlynch I'd love a +1 on this, happy to handle it, but if you have a moment in the next day or two, could you spare 5 minutes to double-check?

Thank you! Merged!

I’ll leave a note to self to push a new release in the next few days.

@wlynch I'd love a +1 on this, happy to handle it, but if you have a moment in the next day or two, could you spare 5 minutes to double-check?

Sorry about the delay (holidays over here in the US). +1 from me. In particular I'm a fan of the reuse of AppsTransport to create the Installation Transport. ^_^

Thanks @wlynch, are you able to push a 1.1 release by any chance? My server
is down for a bit, else, I’ll release when I fix it in the next day or so.
On Sun, 1 Dec 2019 at 4:03 am, Billy Lynch<EMAIL_ADDRESS>wrote:

@wlynch https://github.com/wlynch I'd love a +1 on this, happy to
handle it, but if you have a moment in the next day or two, could you spare
5 minutes to double-check?
Sorry about the delay (holidays over here in the US). +1 from me. In
particular I'm a fan of the reuse of AppsTransport to create the
Installation Transport. ^_^
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bradleyfalzon/ghinstallation/pull/33?email_source=notifications&email_token=AAN74UI4J32ZWZMRYICBOJDQWKPXZA5CNFSM4JSOHXPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQPBZY#issuecomment-560001255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN74UIDQEFOPQZ6TKVWSJDQWKPXZANCNFSM4JSOHXPA
.

--
Bradley Falzon
<EMAIL_ADDRESS>

Thanks @wlynch, are you able to push a 1.1 release by any chance? My server is down for a bit, else, I’ll release when I fix it in the next day or so.

Yup! I can handle this today.

Champions @suhaibmujahid and @wlynch !


How to quickly train the model based on the original model for the audio data of the new speaker？

How to quickly train the model based on the original model for the audio data of the new speaker

What do you actually mean by "quickly" and "data of the new speaker"?


Add branch name and filenames in autosuggest list for commit message editor

This will remove the need for copy pasting branch name and filenames in the commit message. Just type the first letter and press Control+Space to complete.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


warning about field not present in invalid association, but field is present

Elixir version
1.14.4
Database and Version
Yes
Ecto Versions
3.9.1
Database Adapter and Versions (postgrex, myxql, etc)
0.16.5
Current behavior
defmodule A do
	defmodule C do
		schema "table_a" do
			field :"company_#{:id}"
		end
	end
end

defmodule B do
	schema "table_b" do
		has_many :table_as, A.C, foreign_key: :"company_#{:id}"
	end
end

results in warning during compile time:
warning: invalid association `table_as` in schema B: associated schema A.C does not have field `company_id`

Expected behavior
should work fine, right?

Can you provide a small app that reproduces the error?

fwiw I tried this out and can't reproduce
Mix.install([
  {:ecto, "~> 3.9"}
])

defmodule A do
  defmodule C do
    use Ecto.Schema

    schema "table_a" do
      field :"company_#{:id}"
    end
  end
end

defmodule B do
  use Ecto.Schema

  schema "table_b" do
    has_many :table_as, A.C, foreign_key: :"company_#{:id}"
  end
end

defmodule Main do
  def main do
    IO.inspect(%B{})
  end
end

Main.main()

#%B{
#  __meta__: #Ecto.Schema.Metadata<:built, "table_b">,
#  id: nil,
# table_as: #Ecto.Association.NotLoaded<association :table_as is not loaded>
#}

% elixir -v
Erlang/OTP 24 [erts-12.2.1] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1]

Elixir 1.13.2 (compiled with Erlang/OTP 24

I need to take some time to try and re-create it in a repo that I can share. I can see it happen in my own larger project but I need to make it into a smaller example. I promise to come back to this when I have time, if I can't reproduce it in a small example I will let you know.

I can't reproduce the error and it stopped showing up in my code, must have been my mistake, sorry!


syscall/js: Behavior of String method on null and undefined values

What version of Go are you using (go version)?

$ go version
go version go1.12beta1 freebsd/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/sternix/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="freebsd"
GOOS="freebsd"
GOPATH="/home/sternix/go"
GOPROXY=""
GORACE=""
GOROOT="/opt/go/1_12_b1/go"
GOTMPDIR=""
GOTOOLDIR="/opt/go/1_12_b1/go/pkg/tool/freebsd_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build182700344=/tmp/go-build -gno-record-gcc-switches

What did you do?

// +build js,wasm

package main

import (
        "fmt"
        "syscall/js"
)

func main() {
        null := js.Null()

        //panic: syscall/js: call of Value.Int on null
        //fmt.Printf("Int: %d\n",null.Int())

        //panic: syscall/js: call of Value.Float on null
        //fmt.Printf("Float: %f\n",null.Float())

        //panic: syscall/js: call of Value.Bool on null
        //fmt.Printf("Bool: %t\n",null.Bool())

        //String: null
        fmt.Printf("String: %s\n", null.String())

        undefined := js.Undefined()

        //panic: syscall/js: call of Value.Int on undefined
        //fmt.Printf("Int: %d\n",undefined.Int())

        //panic: syscall/js: call of Value.Float on undefined
        //fmt.Printf("Float: %f\n",undefined.Float())

        //panic: syscall/js: call of Value.Bool on undefined
        //fmt.Printf("Bool: %t\n",undefined.Bool())

        //String: undefined
        fmt.Printf("String: %s\n", undefined.String())
}

What did you expect to see?
a panic or string's zero value ""
What did you see instead?
"null" on null values
"undefined" on undefined values

/cc @neelance

Hmm, I could have sworn that at some point in the past I saw tests that covered this case, precisely because (in contrast to the current implementation of GopherJS) we want to push any implicit type conversions back onto the call (i.e. force them to do the equivalent of String(null) if that's what they want). But clearly I'm imagining those tests....

@katiehockman - @neelance is the owner of the WASM port.

Great, thanks @myitcv.

/cc @alexbrainman (feel free to redirect to more appropriate person)

Sorry, but I do not know much about syscall/js package. I am pretty sure @neelance is your man.
Alex


show code

Which issue does this PR close?
No PR to Close
But it about #7601
Rationale for this change
What changes are included in this PR?
only show some result
Are these changes tested?

Are there any user-facing changes?

Marked as draft and kicked off CI

The issue seem to be solved by another PR.
I will close this PR


Feat: Want to add the backend API with database for new questions and want to create the model for that and want to fix bug with the signin not working correctly

Describe the feature
I want to integrate the complete backend with the mongo db database for new questions
I also want to create the collection model for that
Add ScreenShots
N/A
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@Ayushmaanagarwal1211 issue acknowledged! You are assigned.


routeRules doesn't work

Environment
routeRules doesn't work
Reproduction
nitro: {
    devProxy: {
        '/sapi': {
            target: 'https://xx',
            // target: 'http://localhost',
            changeOrigin: true,
            prependPath: true,
        },
        '/bit/gooes': {
            target: 'https://www.bitgoose.top/',
            changeOrigin: true,
            prependPath: true,
        },
    },
    routeRules: {
        '/sapi/**': { proxy: 'https://xx/**' },
        '/bit/gooes/**': { proxy: 'https://www.bitgoose.top/**' },
    },
},

Describe the bug
Doesn’t work after online build
Additional context
No response
Logs
No response

Would you see if you can reproduce this in pure Nitro (reproduction sandbox), and if so, raise there? 🙏

waiting

Already updated, never encountered the error, I was using nuxt2 before and it worked fine,

So proud of your team's enthusiasm to help!

Okay, so it's not reproducible any more?

Why do I get errors when initializing a new project?
link

npx serve .output/public will just serve the static files.
To run a server, run node .output/server/index.mjs.

Same, so can you try it? It's still a project engineering problem. I've invited you. The switching method is still the same, so I don't know if it's a bug in nuxt3.

I'm closing as there's no reproduction - but that may just be a mistake as it seems like you might have tried to create one. Let me know if you have a reproduction and I'll happily reopen 🙏


Add six monts to the default exclude date

Hi,
Set default date value for self exclusion exclude from feature.
Note: Haven't tested well.

@nuruddeensalihu test failed, npm is quite instable recently

@qingweibinary i referenced a yet to exist function. That's why.

@nuruddeensalihu Did you use the latest name of the call?


center-side is not centered if left-side is none and right-side is not none

MWE
#import "chic-hdr.typ": *

#show: chic.with(
  chic-header(
    center-side: "Chic-header example",
    right-side: chic-heading-name(),
  ),
)

= h1
#pagebreak()
== h1.1
#pagebreak()

Gives:

A workaround is to set left-side to "" .

Now the Issue should be solved (I've made a typo in the commit 😅). Thank you for telling me the bug ;)