Third party extensions

JupyterLab will hold the base-level Webpack config for its externals library configuration and a script used to generate the externals for a given third party extension.
The script recursively concats the externals of the upstream jupyter lab extensions, where an extension is a dependency that has a valid ['jupyter']['lab'] config in its package.json.
A third party extension specifies its entry point in ['jupyter']['lab']['main'] and may optionally provide a custom externals configuration in ['jupyter']['lab']['externals'] if something other than the default behavior is desired.
In the cookecutter template, we provide a path to bridge lab and notebook by using the ['jupyter']['notebook'] config, which will assume an all-amd environment.
We propose using labextension to differentiate from nbextension.
The default stance for a third party library is an AMD bundle that exports its API.
Externals synchronously imported by JupyterLab itself will use script tags with accompanying SystemJS config.
Asynchronous imports in JupyterLab will use SystemJS.
The server can use the semver Python library to validate all of the extensions while populating the html template.
Open questions:
How to enable third party extensions to override a default plugin?
cf https://github.com/bollwyvl/widget-cookiecutter/tree/jupyterlab-extension for what a consumer might look like (still a wip).

I verified this works by consuming a jupyter-js-services bundle created this way from the web2 example in ipywidgets, and I got the appropriated objects from jupyter-js-services.

cc @SylvainCorlay @jasongrout

cf https://github.com/jupyter/jupyter-js-services/pull/162

Here's what I did (after copying the jupyter-js-services bundle to the folder):
diff --git a/jupyter-js-widgets/examples/web/index.js b/jupyter-js-widgets/examples/web/index.js
--- a/jupyter-js-widgets/examples/web/index.html
+++ b/jupyter-js-widgets/examples/web/index.html
@@ -1,5 +1,6 @@
 <html>
     <head>
+        <script src="jupyter-js-services.js"></script>
         <script src="index.built.js"></script>
     </head>
     <body />
index 616f3e4..5039983 100644
--- a/jupyter-js-widgets/examples/web/index.js
+++ b/jupyter-js-widgets/examples/web/index.js
@@ -2,6 +2,8 @@
 // Create a widget manager instance.
 var WidgetManager = require('./manager').WidgetManager;
 var uuid = require("jupyter-js-widgets").uuid;
+var services = require('jupyter-js-services');
+console.log(services);

 document.addEventListener("DOMContentLoaded", function(event) {
     var manager = new WidgetManager(document.body);
diff --git a/jupyter-js-widgets/examples/web/webpack.config.js b/jupyter-js-widgets/examples/web/webpack.config.js
index 94b1b74..f29fd91 100644
--- a/jupyter-js-widgets/examples/web/webpack.config.js
+++ b/jupyter-js-widgets/examples/web/webpack.config.js
@@ -1,4 +1,7 @@
 module.exports = {
+  output: {
+    libraryTarget: 'umd'
+  },
   module: {
     loaders: [
       { test: /\.css$/, loader: "style-loader!css-loader" },
@@ -7,4 +10,7 @@ module.exports = {
       { test: /\.(jpg|png|gif)$/, loader: "file" },
     ]
   },
+  externals: {
+    'jupyter-js-services': 'umd jupyter-js-services'
+  }
 }

More thoughts:
Define the public api - all of phosphor and jupyter-services, and an api file in jupyterlab
Third party extensions make sure to exclude these from their published webpack bundle.
We can require their bundle at runtime.

This is blocked on the monorepo, since it will depend on packaging up lots of the phosphor things.

I found this, which we can use to assemble the pieces: https://www.npmjs.com/package/webpack-system-register

This allows us to use System.import instead of global variables.

Theoretically, we could use System.bundle to do the whole thing, but we'd be trading away all the work we've done so far in configuring WebPack loaders and bundles.

I think we'll want to switch away from global variables anyway. I'll talk
to you about it in Monday, but basically we should be able to load
dependencies like underscore and backbone. Not sure if that works
currently...
On Sat, Aug 20, 2016, 09:26 Steven Silvester<EMAIL_ADDRESS>wrote:

Theoretically, we could use System.bundle to do the whole thing, but we'd
be trading away all the work we've done so far in configuring WebPack
loaders and bundles.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyterlab/issues/224#issuecomment-241200051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALwZkNsg5vBEVvph4TjJujlrniszhYxks5qhwCWgaJpZM4JDsGD
.

We don't have a way to provide things like underscore yet.  My thinking is that third party extensions could provide their own dependencies if they are not already available from upstream.  Basically, we'd be providing a federated npm that is dynamically loaded.

Proposed design goals:

Automated and simple to reason about for third party extension authors
Robust
Use semver
No global variables
Load only one module of each version
Support multiple versions if necessary
Load from multiple directories
Support CSS and JSON
Support resolving modules dynamically (e.g. comm targets, CodeMirror modes/addons)

More thoughts:

Stick with Webpack for node resolution and loaders

We need everything available synchronously to WebPack

So, keep the jupyter.externals namespace

Add version mangling to the externals (e.g.) jupyter.externals['phosphor^0.5.0']

If downstream depends on an incompatible version of a lib, that version gets included in its bundle.

We explicitly list the modules we provide using find_imports

This is what we use to build each shim

Actually, webpack-system-register will take care of making things synchronously available to each bundle, so we can use SystemJS for the infrastructure instead of the global var.

A recap of a conversation we just had on gitter.

Use Webpack and AMD for everything, rather than fighting too much between different module loaders.
Add a shim that re-exports internal modules using define or a require config.
We shim all of the modules that we explicitly use and all of our own internal modules.
Each extension adds itself and any of its imports that are not already provided.
If an extension depends on a conflicting version of a library, we warn loudly and do not export those modules.
This could be used in jupyter/notebook, since it results in bundles that have their individual paths exported using AMD

If an extension depends on a conflicting version of a library, we warn loudly and do not export those modules.

If we have two plugins independently providing, say, d3, this won't help.
It'd be nice if there was an AMD semver require, where I could require a semver of a particular module, and it would resolve to the relevant version of the module. At load time, every version provided would be available, and on require, it would resolve to the newest one that satisfied the semver. I think you mentioned something like this at some point.

As in, jspm :smile:?

Uh, I guess? Nice!

More notes from conversations with @blink1073. We have externals and shims - shims are things we are providing, and externals are the way to resolve to what we are providing.

Explicitly list things we are providing (i.e., things shims will be built for). Generally list the things we think dependencies will need to share and not have their private copies. For the ipywidgets, provide jupyter-js-widgets, and maybe backbone and underscore? Each provided library generates a separate webpack bundle. This gets a bit tricky because the webpack configs for each library you are providing needs to manually state what dependency externals will be provided by the plugin itself. (so the widgets lab extension will have to configure jupyter-js-widgets to rely on an external of backbone and underscore...). The bundle includes the library name and version. The library bundle includes all accessible modules in the library. The bundle also has to include a manifest giving what externals it is assuming (and the appropriate semvers for those externals).

Shims are built to load into a global package registry (jupyter.externals) the package name, path, and version number for each module in the external library.

The externals webpack helper walks the ancestor tree and mangle imports to include a semver version of the library (pulled from package.json). The resolver calls a runtime function with the library name, path, and semver, and the runtime function resolves to a loaded package in jupyter.externals. E.g., jupyter.resolve('phosphor/lib/ui/widget', '^0.6.0')

Loading bundles on a page: webpack assumes things are provided synchronously. Loading using script tags means the server has to resolve the dependency tree (with semver). Each plugin package has an extension manifest file that lists each external bundle it provides, and the externals dependencies for that bundle (with semver). This manifest file ...

Each npm package can provide multiple external bundles. Each npm package provides at most one plugin. The plugin manifest lists for each bundle:

name (an npm package name)
version number
list of externals it assumes (with their semvers)
TODO: some way of saying what to load to get the IPlugin data structure.

Initial boostrap: server templates a bunch of script tags to load bundles in order. Gets each IPlugin on the page somehow (maybe through requirejs?). Then the application is loaded and given the list of IPlugins, and then we call application.run()
Externals we are providing - if the library has a package.json main entry point, that is what we export. Otherwise we provide all .js and .css files in the package.json directory.lib directory.

FYI There is a plugin for RequireJS that allows you to return a promise in the define() block.
https://github.com/jokeyrhyme/requirejs-promise
Great example here:
http://stackoverflow.com/a/26445338

I played with the WebPack DLLPlugin:
Pros:

Does not execute any code
Auto-creates shims for all modules
Modules are available synchronously

Cons:

The dll needs to export a global variable
We would need to figure out how to dynamically use the manifest(s)

My current plan is to not export anything explicitly from the bundles, but have them only define() each module using a shim that we create.
The WebPack externals would mangle to amd foo, and use these defined modules.

Closing in favor of #728.


How to register a function so that it runs repeatly?

I tried to use the js! macro, it seems to work. However, according to the js! doc, any callbacks passed to js must be manually dropped to prevent memory leaking. Iif I follow this instruction, then an error will accur. If I do not drop the callback closure manually, everything seems to be ok.
Maybe there is other more ``official'' method to register a function to run repeatly? If so what is it?

Could you give more details about what you're trying to do?

I'm just trying to display an animate on a canvas. More detailly, I'm going to implement the game of life

Okay, so you'll want to use requestAnimationFrame, like this:
fn game_loop<F>(callback: F) -> where F: FnMut(f64) + 'static {
    js! { @(no_return)
        var callback = @{callback};

        function loop(time) {
            requestAnimationFrame(loop);
            callback(time);
        }

        requestAnimationFrame(loop);
    }
}

And now you can use it like this:
game_loop(|time| {
    ...
});

Note: the above game loop never ends. I can write a version that ends, if you want, but it's more complicated.
Also, you can adapt it to use setTimeout instead, if you want, though I don't recommend doing that.
requestAnimationFrame is much more efficient than setTimeout, but it's locked to the monitor's refresh rate (which is usually 60 FPS).
However, you can compare the old time to the new time to "throttle" it so it fires slower than the monitor's refresh rate:
// 30 FPS
const FPS: f64 = (1000.0 / 30.0);

let mut old_time = None;

game_loop(move |time| {
    if old_time.map(|old_time| (time - old_time) >= FPS).unwrap_or(true) {
        old_time = Some(time);

        // Your code goes here
    }
});

Note: the above is completed untested, and may not be the best way to accomplish that.

Also, here is the version which can be ended:
#[derive(Debug)]
pub struct GameLoop(Value);

impl GameLoop {
    pub fn new<F>(callback: F) -> Self where F: FnMut(f64) + 'static {
        GameLoop(js!(
            var callback = @{callback};

            function loop(time) {
                state.id = requestAnimationFrame(loop);
                callback(time);
            }

            var state = {
                callback: callback,
                id: requestAnimationFrame(loop)
            };

            return state;
        ))
    }
}

impl Drop for GameLoop {
    fn drop(&mut self) {
        js! { @(no_return)
            var state = @{&self.0};
            cancelAnimationFrame(state.id);
            state.callback.drop();
        }
    }
}

The above is a common pattern with stdweb when using callbacks.
Now you can use it like this:
// When `game_loop` is dropped it will stop the game loop
let game_loop = GameLoop::new(|time| {
    ...
});

Thanks a lot!
I will try your solution.


Docker Registry

#closes https://github.com/near/pagoda-relayer-rs-fastauth/issues/46

@anshal-savla I do not have access to this repo. We need to add GCP_CREDENTIALS_DEV to secrets.

Since this is an open-source repo, I think Docker Hub or GHCR would suit better here

@volovyks I am not able to change to read and write permission for the actions workflow. @nearlysean Can you help with this?

I have a 🚫 no entry icon when trying to change it, as well.

It looks like  it needs to be set at the org level first. I'm a little more nervous to make that change at the NEAR org level.

@nearlysean @anshal-savla we solved this issue, and now it works without extra permissions.

Great, thanks for working around it. 👍

@volovyks curious, what was the workaround?

@anshal-savla GitHub actions could not create a new registry, but it worked once we made it manually. Pushing to it is allowed.
@itegulov thanks for the advice.


HYGEN_TMPLS does not work as documented

hygen does not use the value in HYGEN_TMPLS as expected.
For example:
$ cd /dev/project
$ HYGEN_TMPLS=/home/me/_templates hygen

should look for templates in /home/me/_templates.
Actual behavior:  hygen looks for templates in  /dev/project/home/me/_templates.
(perhaps change path.join(cwd, process.env.HYGEN_TMPLS || '_templates'), to process.env.HYGEN_TMPLS  in template-resolver.js?)

Thanks! new version is currently building 👍

Great stuff Ron!
Really awesome, and can save a ton of time!
If you'd like to be featured under the hygen toolset, let me know. Currently there's

hygen-add - adds packages from the outside world

We could make this into something like hygen-create or something like this.
There will be a section for ecosystem, as I'm getting a ton of requests and ideas from people all around, so this might be great for it!
Also if you're in TLV, I'd be happy to meet and see how you're using hygen 😎

Thanks Jon - I'm glad you like it.
hygen-create sounds like a perfect name - and it would be great to have it featured as part of the toolset.  I'll rename it accordingly.
👍 meeting.  I'm usually in the Herzliya area.  Will reach out privately so we can coordinate.


fix: Add onClick to button element in getInteractiveElement

I'm going to add another test from GridTable to ensure this prop is handled correctly.


Fix wave speed bug

Wave speed measurement would crash if the diode tdms was empty. Now it
returns a happy 0 instead.

Merge wave speed measurement bug fix


Packaging, default exports

It would be nice if react-router provide the ability to use default exports.
In redux:
import applyMiddleware from 'redux/lib/applyMiddleware';
import combineReducers from 'redux/lib/combineReducers';
import createStore from 'redux/lib/createStore';

In router5:
import RouterProvider  from 'react-router5/modules/RouterProvider';

In history:
import createBrowserHistory from 'history/createBrowserHistory';

In material-ui
import Card from 'material-ui/Card';
import CardContent from 'material-ui/Card/CardContent';
import CardMedia from 'material-ui/Card/CardMedia';
import CardActions from 'material-ui/Card/CardActions';

I am not sure why default exports are not used in react-router, maybe there are specific reasons. I personally prefer avoiding named exports.

You can currently cherry pick exports.
// commonjs<EMAIL_ADDRESS>import Link from 'react-router-dom/Link'
// es6<EMAIL_ADDRESS>import Link from 'react-router-dom/es/Link'

That said, I think that named exports are "the future" in the sense that Rollup is going to take over package bundling. With that, packages will be distributed as single files, so most of the exports will be named exports.

You cannot do above with react-router-redux.
For example, routerReducer
import { routerReducer } from "react-router-redux/es/reducer"
``

It is not about "future", it is about having a clear mapping between module and export. If using bundlers that benefit f using named expoert is dismishing since you bundle into one anyway.

In some cases it makes sense to expose module with multiple named exports (constants, actions) but in many cases is better to have 1 to 1 mapping.


Transfer workflow with history

Transfer check-ss3-models-run.yml from the workflows repo to this repo; delete call-check-ss3-models-run.yml.

Part of issue #416 in the stock-synthesis repo.

Successful gh-action run here

This action has passed here, not sure why it's not finishing in this PR.

@kellijohnson-NOAA since we are bringing in the history of this workflow, would it still be a good practice to squash and merge like we typically do or keep the commits separate?

This action has passed here, not sure why it's not finishing in this PR.

I am not sure but I did notice that actions are not ran upon changes to the GitHub action files, only changes to the model files. You might want to add the .yml file to the file list in the action.
Regarding squashing and merging, you would not want to do that here because then you would lose the file history that you worked so hard to get. Squashing and merging takes all the commits listed in this feature branch and "squashes" them down into one single commit. So, you might want to do that for the last three commits where you made some changes to the files but you will have to do that locally with
git rebase -i head~3

and choose squash for the commits that you want to meld into the parent commit. Then force push
git push -f origin transfer-workflow-with-history

back to this feature branch. This would be a fine thing to do here because it would remove the history of adding the feature branch to the branches listed in the action, which we do not really need to keep track of.


Android: Cannot send data to the server. CLEARTEXT communication to not permitted by network security policy

Your Environment

Uploader Version Number: 0.7.1
Your Android Phone Model Name (e.g. Samsung J1 Ace): Xiamo Mi9
Android Version Number (e.g. use 4.4 for 4.4.4): 10 QKQ1
Network Connection at the time the issue occurred (Wi-Fi, Mobile): WiFi / Mobile
Nightscout website version (e.g. 0.8.4 Funnel cake, master / dev branch): nightscout
version 0.11.1

Brief Explanation of Issue
When trying to upload data to Nighscout, it throws error:
Android: Cannot send data to the server. CLEARTEXT communication to not permitted by network security policy
Uploader Error Code
Android: Cannot send data to the server. CLEARTEXT communication to not permitted by network security policy
Steps to Reproduce (for bugs)

Setup nighscout URL and API key
Connect Countour uploader USB
Wait for data loading from Countour
Throws error when trying to upload to Nighscout

Your Nightscout URL address in the uploader needs to be in this form:
https://sitename.herokuapp.com

I do not have https on my nightscout page. I am not using heroku or other cloud.

Ah ok , the uploader will only work with https.
You can build the uploader with the follow changes to make it work with http:
Add src\main\res\xml\network_security_config.xml file with the following content:
<?xml version="1.0" encoding="utf-8"?>
<network_security_config xmlns:android="http://schemas.android.com/apk/res/android">
    <domain-config cleartextTrafficPermitted="true">
    </domain-config>
</network_security_config>

Add this line into AndroidManifest.xml as part of the  declarations:
android:networkSecurityConfig="@xml/network_security_config"

Hi I'm not a developer and struggle during AndroidStuidio setup.
Both Fabric and BugFender aren't available right now and if i try do build the project without them i get a gradle sync error.
is ther an easier way to build the apk with the changes above?

@Fix3l did you upgrade gradle by accident?

Hm the first errors told that fabric isn't reachable or something. Androidstudio recommended to work in offline mode.
After that the gradlesync error appears.


Fixed support for multiple tables & order resetting

Rewritten everything to simplify table specific data saving.
Added a third state to reset the order of the table.

Fixed third state as per #1


Build failure: python3.12Packages.paramiko

Steps To Reproduce
Steps to reproduce the behavior:

build azure-cli

Build log
       > /nix/store/wfbjq35kxs6x83c3ncpfxdyl5gbhdx4h-python3-3.12.6/lib/python3.12/importlib/__init__.py:90: in import_module
       >     return _bootstrap._gcd_import(name[level:], package, level)
       > azure/cli/core/tests/test_keys.py:9: in <module>
       >     import paramiko
       > /nix/store/hdsahpv8zxkcgl16gmkkxnks1f0dv8xw-python3.12-paramiko-3.5.0/lib/python3.12/site-packages/paramiko/__init__.py:22: in <module>
       >     from paramiko.transport import (
       > /nix/store/hdsahpv8zxkcgl16gmkkxnks1f0dv8xw-python3.12-paramiko-3.5.0/lib/python3.12/site-packages/paramiko/transport.py:99: in <module>
       >     from paramiko.ed25519key import Ed25519Key
       > /nix/store/hdsahpv8zxkcgl16gmkkxnks1f0dv8xw-python3.12-paramiko-3.5.0/lib/python3.12/site-packages/paramiko/ed25519key.py:22: in <module>
       >     import nacl.signing
       > E   ModuleNotFoundError: No module named 'nacl'
       > =============================== warnings summary ===============================
       > azure/cli/core/tests/test_breaking_change.py:14
       >   /build/azure-cli-2.64.0-src/src/azure-cli-core/azure/cli/core/tests/test_breaking_change.py:14: PytestCollectionWarning: cannot collect test class 'TestCommandsLoader' because it has a __init__ constructor (from: azure/cli/core/tests/test_breaking_change.py)
       >     class TestCommandsLoader(AzCommandsLoader):
       >
       > azure/cli/core/tests/test_help_loaders.py:13
       >   /build/azure-cli-2.64.0-src/src/azure-cli-core/azure/cli/core/tests/test_help_loaders.py:13: PytestCollectionWarning: cannot collect test class 'TestCommandLoader' because it has a __init__ constructor (from: azure/cli/core/tests/test_help_loaders.py)
       >     class TestCommandLoader(AzCommandsLoader):
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > ERROR azure/cli/core/tests/test_keys.py
       > !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
       > ================== 2 deselected, 2 warnings, 1 error in 3.55s ==================

Additional context
N/A
Notify maintainers

@katexochen @ulrikstrid
Metadata
I ran into this issue while building my the package in my CI system : https://github.com/cterence/nixos-config/actions/runs/11358813907/job/31604868207?pr=7. I haven't updated the flake on my device to avoid the build error.

Add a :+1: reaction to issues you find important.

Fixed by https://github.com/NixOS/nixpkgs/pull/345326, which is currently in staging-next

Fix is now in unstable.


Update optentelemetry-lambda repository link to tag: layer-collector/0.12.0

Description:
Updates Git sub-module link for opentelemetry-lambda to layer-collector/0.12.0.
There are some updates to the upstream repository which I would like to be able to use in the ADOT layer - in particular the addition of support for secretsmanager references in the collector config.
Link to tracking Issue: N/A
Testing: N/A
Documentation: N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Aneurysm9 @vasireddy99 can I get a review?


Add seq_classification shark module to run seq_classification

on hugging face supported models.

Also, let's try to remove the ALBERT test from CI until it's green all the way.


p2pool: 1.7 -> 1.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for p2pool is: "Decentralized pool for Monero mining"
meta.homepage for p2pool is: "https://github.com/SChernykh/p2pool"
meta.changelog for p2pool is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/ybc7jdy6ahnc5r9rccr0fbkx6jzw43gg-p2pool-1.8/bin/p2pool had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.8 with grep in /nix/store/ybc7jdy6ahnc5r9rccr0fbkx6jzw43gg-p2pool-1.8
found 1.8 in filename of file in /nix/store/ybc7jdy6ahnc5r9rccr0fbkx6jzw43gg-p2pool-1.8

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
p2pool

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ybc7jdy6ahnc5r9rccr0fbkx6jzw43gg-p2pool-1.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A p2pool https://github.com/r-ryantm/nixpkgs/archive/25878107b418beb9491464fda77c18209d627e54.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ybc7jdy6ahnc5r9rccr0fbkx6jzw43gg-p2pool-1.8
ls -la /nix/store/ybc7jdy6ahnc5r9rccr0fbkx6jzw43gg-p2pool-1.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

p2pool

Maintainer pings
cc @ratsclub for testing.

Result of nixpkgs-review pr 162235 run on x86_64-linux 1

1 package built:

p2pool

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/450


Re-enabling narrowing errors

Fixes narrowing conversion build errors in test_common
Removing disable of narrowing errors in main CMakeLists.txt
and moving it down to specific test_conformance suite's
CMakeLists.txt where there are many more build errors revealed
from this fix.
Fixes a few simple issues under test_conformance in the process.
Contributes #787
Signed-off-by: Ellen Norris-Thompson<EMAIL_ADDRESS>

Any comments on here?

@ahesham-arm This is failing the CI. It may require a rebase and/or fixes.

@kpet Rebased and all CI checks are now passing.

Merging as discussed in the October 8th teleconference.


Set revealOutputChannelOn to Never in the VSCode extension

The VSCode terminal becomes hard to use if the language server sends a bunch of error messages in quick succession, as the editor keeps switching over to the Output tab automatically.
Setting revealOutputChannelOn to Never disables this behavior. Note that the user can still manually switch to the Output to view logs and error messages from the language server.

if the language server sends a bunch of error messages in quick succession

What were the errors about? Is there something else we could fix here?

@swift-ci please test

The issue I ran into was that deleting the .build directory in a project (to perform a clean build) caused the language server to crash:
sourcekit-lsp: /home/build-user/swift/lib/Sema/TypeCheckStmt.cpp:491: bool typeCheckConditionForStatement(swift::LabeledConditionalStmt *, swift::DeclContext *): Assertion `!E->getType() && "the bool condition is already type checked"' failed.
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.
Stack dump:
0.	While performing new completion
1.	While evaluating request CodeCompletionSecondPassRequest(source_file "...", )
2.	While evaluating request TypeCheckASTNodeAtLocRequest(0x7f2b1c372450 AbstractFunctionDecl name=handle(message:from:) : (no type set), )
3.	While type-checking statement at ...
[Info  - 6:24:37 PM] Connection to server got closed. Server will restart.

Not sure if this really fixable, as the compiler might rely on the user not changing any build files while running.

Not sure if this really fixable, as the compiler might rely on the user not changing any build files while running.

There may be some cases with clang modules and header changes that are hard to fix in the current setup, but other than that I would expect us not to crash.  The specific case you mentioned doesn't sound like that though, so worth a bug report if you can reproduce it.


[Task]: Implement doc system for TSDoc comments

Task description
Right now we have TSDoc comments in some places but not all.
Requirements

[ ] Create conventions for writing these comments (esp. for functions... also probs best not to write these until functions are finalized or task is nearly complete).
[ ] Design automated system for keeping documentation up-to-date (or is documentation generated each commit, merge, PR, etc.)
[ ] Write TSDoc comments for the necessary code components (e.g. functions, interfaces, types, constants, stores)

Acceptance criteria
Meets the above requirements.
Creation checklist

[X] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

Closing as task has been dissolved into other tasks.


Revert python backend POC

🗣 Description
Revert Python backend POC PR. This is no longer needed as we plan to transition to python without node backend still running.
💭 Motivation and context
This PR is breaking the Backend pipeline because it is makes the lambda build too large. We don't need this anymore.
🧪 Testing
Passes pre-commit and github checks.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[x] Revert dependencies to default branches.
[x] Finalize version.

✅ Post-merge checklist

[x] Create a release.

It's still failing the test step of the backend pipeline. I think these lines in backend/package.json are to blame.

Good catch will fix that now!


refactor!: restructure container operations

This PR restructures container operations and merges them under the daggers/containers package to increase the UX and maintainability of the code.
Breaking change: Package path changes
Depends on #48

Squashed all commits since commit history wasn't following conventional commits

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 8.125%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
13

Relevant Lines:
160

💛  - Coveralls


can't navigate!

i am getting this error when i navigate from my WelcomePage widget to another page
[ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: Navigator operation requested with a context that does not include a Navigator.
E/flutter (28256): The context used to push or pop routes from the Navigator must be that of a widget that is a descendant of a Navigator widget.

here is my main file
void main() {
  runApp(DevicePreview(builder: (context) => MyApp()));
}

class MyApp extends StatelessWidget {
  final GoogleSignIn _googleSignIn = GoogleSignIn();

  @override
  Widget build(BuildContext context) {
    return MultiProvider(
      providers: [
        ChangeNotifierProvider<UserModel>(
          create: (_) => UserModel(),
        ),
        StreamProvider<FirebaseUser>.value(
            value: FirebaseAuth.instance.onAuthStateChanged),
      ],
      child: MaterialApp(
        builder: (context, widget) => ResponsiveWrapper.builder(
          WelcomePage(),
          maxWidth: 1200,
          minWidth: 450,
          defaultScale: true,
          breakpoints: [
            ResponsiveBreakpoint(breakpoint: 450, name: MOBILE),
            ResponsiveBreakpoint(
                breakpoint: 800, name: TABLET, autoScale: true),
            ResponsiveBreakpoint(
                breakpoint: 1000, name: TABLET, autoScale: true),
            ResponsiveBreakpoint(breakpoint: 1200, name: DESKTOP),
            ResponsiveBreakpoint(breakpoint: 2460, name: "4K", autoScale: true),
          ],
          background: Container(
            color: Color(0xFFF5F5F5),
          ),
        ),
        debugShowCheckedModeBanner: false,
      ),
    );
  }
}

my WelcomePage file
class WelcomePage extends StatefulWidget {
  @override
  _WelcomePageState createState() => _WelcomePageState();
}

class _WelcomePageState extends State<WelcomePage> {
  final _googleAuth = GoogleSignIn();

  @override
  void initState() {
    super.initState();
    googleSignInSilent();
  }

  void googleSignInSilent() {
    _googleAuth.signInSilently(suppressErrors: false).then((account) {
      if (account != null) {
        setState(() {
          // the error happens from here
          Navigator.pushReplacement(
            context,
            MaterialPageRoute(builder: (context) => FirstPage()),
          );
        });
      }
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SingleChildScrollView(
        child: Container(
          padding: EdgeInsets.symmetric(horizontal: 20),
          height: MediaQuery.of(context).size.height,
           Column(
            crossAxisAlignment: CrossAxisAlignment.center,
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              Text(
                'In Bed Ideas',
                style: TextStyle(fontSize: 30, fontWeight: FontWeight.bold),
              ),
              SizedBox(
                height: 80,
              ),
              _submitButton(),
              SizedBox(
                height: 20,
              ),
              _signUpButton(),
              SizedBox(
                height: 20,
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Please put the WelcomePage() in your MaterialApp's home parameter.
MaterialApp's builder field is only for widgets and behaviors you want to apply to all MaterialApp children. The actual pages of your app need to go in home or a route.

i added it but nothing changed.

i fixed it by adding BouncingScrollWrapper.builder(context, widget) to builder method as a child, but i don't have a responsive UI!

The builder method expects a (context, widget) => widget value.
You need to use MaterialApp's home parameter for all your widget construction. Please place your app's widgets in the home parameter.
Set ResponsiveWrapper.builder as the Builder method. The code in the demo app might help https://github.com/Codelessly/FlutterMinimalWebsite

okay got it, thank you.

Okay got it, thank you.


FEAT: Monte Carlo

Is your feature request related to a problem? Please describe.
We would like to implement the monte carlo algorithm, and see if we keep it or mix it with min max
Describe the solution you'd like
Implement it.

Dropping the idea of implementing the monte carlo solution following some discussions.


Encoding URL for rename source file

Description
resolves #37777
SDK could not handle when source file contained unicode escape character "\u200B", adding same logic as beginCopy to encode the source file url before calling rename().

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-storage-file-share


Patch number is not part of OS X platfroms, so use Major.Minor versio…

Patch number is not part of OS X platfroms, so use Major.Minor version in platform name of OS X platforms instead of full version number.
So instead of "OS X Yosemite (10.10.5)", the platform name is "OS X Yosemite (10.10)".
This will help to track platform names in graylogy easily via "quick values".

@sarigalin if you mind to sign the CLA we could merge your change - without that I will close this PR in a week.

@jalogisch  I just signed it.

@jalogisch I just signed it.


Add test tile server for colors

This PR adds an extra tile server just for testing. It is hosted on port 9005.

/{color}.* returns a solid color tile. This is useful for spotting the small nested color that is difficult to locate in the speckled case.
/speckled-{color}.* returns a speckled color tile. This is useful to ensure perspectives are not warped and identifying when zooming retrieves new tiles compared to using interpolated scaling.

color is one of "red", "blue", "green", or "yellow"

Can this be shimmed into the Dataset architecture? Or does it have to be a special case usage of these particular tile service endpoints?

This service doesn't represent a real dataset because a tile is always returned regardless of the path. This allows representing an infinitely large and zoomable image. Our current endpoints only allow viewing image files. These will always have a finite dimension and number of tiles. This is a separate service because of this difference.

I guess I was thinking more like: can we rig a Dataset with a specific ID (or name, or whatever) that triggers a special path in the tile server logic that "shunts" those datasets to this endpoint? If so, we can treat these data sources like any other (creating an Investigation that features them, for example).

We could incorporate it in some way. It would also require implementing a response for our tile metadata endpoint. This endpoint returns things like dimensions, number of zoom levels, etc. We'd need to consider what these data would look like.

What if we just made some big tiffs with the colored tiles and added those to the populate script as datasets?

What if we just made some big tiffs with the colored tiles and added those to the populate script as datasets?

That's the easiest way to do this, I think.

That wouldn't get us the nifty infinite zoom feature the tile servers give us, but if it gets us most of the way there for testing and demo purposes, I think it's a good bang for the effort.


How to deploy a smart contract on minikube?

Hello,
I am trying to deploy a smart contract using truffle. So I created a network on truffle-config.
k8s: {
      provider: () => new PrivateKeyProvider(privateKey, "http://<IP_ADDRESS>:8545"),
      gas: "0x1ffffffffffffe",
      gasPrice: 0,
      network_id: "*"
    },

But it doesn't work. I know to interact with the Blockchain I need to minikube ssh.  How to deploy a contract with truffle?
Thanks In Advance

Should I install truffle and clone the project repository inside minikube(after  minikube ssh) to deploy the contract?

Hello @yehia67
I'd suggest looking at some tutorials of kubernetes networking works eg: https://itnext.io/an-illustrated-guide-to-kubernetes-networking-part-1-d1ede3322727
Basically you need to be able to connect to your rpc endpoint from wherever you are running the contract from (eg IDE, local host etc).
If your nodes are on minikube the only way in from outside the cluster is :

a nodeport service like the monitoring examples, bear in mind that a node ports services' port range is 30000-32767 so 8545 wont work and you need to map it to 30045 for example. Look at the grafana service in the examples for reference
ingress controllers
Both of the above use the minikube IP address - get this by doing minikube ip. So you config should be :
  provider: () => new PrivateKeyProvider(privateKey, "http://<minikube_ip>:<port>"), ...

The above will work if your contract is being run from IDE or the like (outside the nodes)
If you deploy your contract as another pod inside the cluster what you've got will work perfectly fine - suggest using the node service ip as an env var rather than a fixed ip - in the event the pod goes down the contract wont work.
Hope this helps


ModuleNotFoundError: No module named 'RestrictedPython'

when running example from README:
promptimize run ./examples

here is what helped:


added resposiveness and animation

This PR adds hover animation over elements of sidebar and also makes website responsive to different screen sizes.
Fixes #53
Test:

Go to the sidebar.
hover over different items of sidebar and see the animated hovering.

hover.webm

@Pratham-Onkar-Singh This branch has a conflict, so please resolve it to get the code merged.


New package: Wintun v0.1.0

Registering package: Wintun
Repository: https://github.com/shuaixing86/Wintun
Created by: @shuaixing86
Version: v0.1.0
Commit: 8fa30cea1d03757c5c17e846922cc790a4d036e5
Git reference: main
Release notes:

In the windows system, Julia drives the TUN/TAP driver for Wireguard - wintun

Closing in favor of https://github.com/JuliaRegistries/General/pull/112370


Migration to docusaurus

Description
Please include a summary of the change and which issue was fixed by it.
Fixes # (issue)
Type of change
Please delete the option that is not relevant.

[ ] Signature (please update title to "Signature 'your name'")
[ ] Propose Update to Manifesto (please update title to "Propose Update to Manifesto - 'update description'")

hello @bdfinst thanks for the comment, I opened a discussion in #323.
From my perspective, here are my thoughts:

The current look and feel is quite outdated and the website is not really welcoming to be consumed. Docusaurus (infima) will allow us to be more up to date.
React is as well-known language in the industry, so there is a smaller learning curve for contribution. I have tried to fight multiple times with the templating model of hugo and is complex.
React also allows more dynamic content to be created inside the page, and it also has many libraries we could use to animate for example CICD proceses, or even show maturity models.
The maintenance of templates in Hugo tends to be low, and only a few that are paid products are heavily maintained and act upon contributions (I have tried to contribute to some, and the release cycle varies a lot).
Hugo you depend a lot on individual conventions in templates, so if we ever are to move out of the current template it is almost a rewrite as a template dominates the content structure.

Toward your concerns, React is a very active project many companies depend on, it will probably be taken care of sooner than later, and actually, we will get Dependabot to notify us abut those vulnerabilities.
I have seen the opposite of you this last year, I have seen 2 companies ditch Hugo in favour of docusaurus.

Look and feel: I'd be open to migrating to Google's Docsy or the theme I'm building for my company, which is a fork of Docsy. That would be a much less intrusive change.
I'm not sure how comfortable the rest of the core team is with React, but I've been developing in it for several years. My company is converting from Docusaurus due to the toil of keeping up with React CVEs in secure environments. Not an issue here, but it's the reason I mentioned it.
Hugo also allows for dynamic content within the page. I've been building shortcodes for the same for the last week to extend those features in my company's fork of Docsy. :) What dynamic content do you think is missing from MinCD?
I've had a PR open on Docsy for the past three weeks, so I get where you're coming from. Since the underlying tech is Hugo itself, unless something is broken in the theme, there's very little maintenance required. With Docusaurus, you need to keep dependencies current.
I've migrated between Hugo templates before. It's not a huge problem. My personal site and a few other sites I administer are also Hugo. In fact, i migrated my personal site from an older theme to my company's theme and only needed to modify some custom templates I'd created, not the documentation.

The base tradeoff of generic static code generators like Hugo/Jekyll/Hexo/... is that the driving factor of the site is not the site itself, but the theme behind it. While It's true, it's possible to create short codes, those short codes are just HTML snipped that are resolved at compile time with small support for JS (no real complexity is allowed).
I have worked with Docsy before, Personally my opinion is more than changing a few configurations there is not too much control over the content of the page, specially the landing or any intermediate page you want to create navigation for. For example, to actually do some real modifications, you had to fork and create your own theme.
Answering your question about dynamic content missing in minimal CD, if we were in docusaurus/astro/... we could, for example, use a library like react flow to generate dynamic content showing how CI/CD works that will be engaging similar to this kafka visualization from softwaremill.
With this in mind, we can push collaborations of the bigger community if we use a mainstream language that allows development by anyone without a new learning curve. If we stick to Hugo, the issue is that community and that knowledge is more siloed & complex.
We need to take in count that the end goal of this group is to create engagement in the community to push forward CD if we can create more dinamic and engagement materia with things like react flow & also grow the capability for others to create easier the engagement material is a win win.
Getting back to the main point of this PR docusaurus helps us:

Create more engaging content.
Reduce the entrance learning curve for collaboration.

This seems like a huge lift for a hypothetical PR for an animated TBD workflow. Do you have one you're wanting to add?
If someone wants to flex their artistic muscles, this  would be a lot less code and would align with the minimalism we get so many compliments on.

@bdfinst I have given a few more reasons, it is up to you and the rest of the group to decide if this makes sense.
The resume of why I think this is as good move are:

Docusaurus is Website-centric.

No need to modify a template to later modify the content.

Docusaurus uses mainstream technology.

It improves the capability for people to contribute.
Extensive documentation
Extensive ecosystem
Frequent updates and security patches.

Docusaurus is better maintained than any of the templates of generic systems.

Again, this is not about flexing artistically or hypotheticals. It's about using a technology that has stagnated for the last 2 years with a small community (Hugo) vs another that still growing and has large adoption (React). At the end, both compile markdowns into HTML, but one is more flexible and extensible than the other.
Overall, this PR is about community engagement and capabilities to become part of the group and collaborate.

also playing with 2 new possible logos

I've used Docusaurus, Gatsby, Jekyll, and Hugo quite a bit.
"No need to modify a template to later modify the content."
I find this confusing. It's Markdown.
"Docusaurus uses mainstream technology."
Go is pretty mainstream. It's been around for over a decade. In addition, Hugo has more contributors than Docusaurus, so it's hard to argue that the latter is better supported.
"It improves the capability for people to contribute."
All contributions to date have been Markdown. All static site generators have the same user experience where that's concerned.
"Extensive documentation"
https://gohugo.io/documentation/
"Extensive ecosystem"
They all do.
"Frequent updates and security patches."
No security patches are required for Hugo. I just created a Docusaurus site and got the following
added 1112 packages, and audited 1113 packages in 34s

204 packages are looking for funding
  run `npm fund` for details

22 vulnerabilities (4 moderate, 18 high)

This is what I get on the current site
added 128 packages, and audited 129 packages in 1s

40 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

It's also significantly faster to build the current site locally. I'm in the process of replacing Docusaurus with Hugo at work so I'm feeling the pain of the build time difference there.
"Docusaurus is better maintained than any of the templates of generic systems."
The current template requires no maintenance.
"Docusaurus has a great integration for search with algolia that enables our users to get better access to our documentation."
Many site generators do
There are a couple of significant problems with this PR.

It doesn't add missing features.
The main feature, the content, cannot be code reviewed.

The structure of the main page has been optimized to ensure that any changes to the core content that people are signing on that they agree with have easily verifiable changes. That's why the signature, contributor, and other additional content on the main page are generated from other resources rather than simply part of the main page. This PR destroys that traceability.
I understand you prefer React, but the fact that there are many React developers is not a huge deal for goals of this project. I've talked to the rest of the team and they are also a bit confused about the value. We do appreciate the enthusiasm and would love help with the content, but we don't think this particular PR is in the best interests of the project goals.

If those are your thoughts we are not going to get anywhere, and i dont feel this is my place to cooperate when there is 0 reflection and all is being defensive.
So best of luck.

If those are your thoughts we are not going to get anywhere, and i dont feel this is my place to cooperate when there is 0 reflection and all is being defensive. So best of luck.

Get more experience with open-source contributions. Go convert Docusaurus to Angular and see what they say. ;)

btw...not sure if you noticed, but you compare apples with pears 😛. A node project vs the broken link checker and the MD linter 🤷

Hugo is a dev dependency, so there are no CVEs. This is an apples-to-apples comparison.
To reiterate:

The PR removes traceability of the valuable part of the project, the content. Considering the care we take to maintain that traceability, that immediately removes any possible value from this PR.
Making it easier for a React developer to modify the infrastructure doesn't make it easier to improve the content.
Docusaurus requires more maintenance toil than Hugo. Since that toil falls on the core team and not you, trying to ram this down our throats isn't good behavior.

Collaboration doesn't consist of trying to bully people into accepting your PR.
Do you understand the irony of making a PR like this to something like MinimumCD?
It's not small. It's not evolutionary. It adds features that aren't needed but that require extra maintenance.
To add to that, the theme you picked is still beta.


New Installation Screen

This PR will replace https://github.com/divio/django-cms/pull/4326
Add page will be replaced with the new wizard once it's merged

Step 1

you get automatically redirected to the admin: ´´/en/admin/login/?next=/en/´´. The screen above is shown when you have javascript disabled.
Step 2

after login, you'll get back to the previous screen, the modal will open automatically:

after you login, if you close the modal - can you somehow reopen it or would you need to refresh?

:+1:

:+1:


Implement Blade directives

As on Blade UI Kit this package will need its own blade directives for styles and scripts.

Implementing directives was not a good idea. We chose to use Blade Stacks instead.


C++11 support

HI,
I am trying to use the cppflow libs to build standalone application with c++11? is there any workaround for it?

See #108

I am not planing to make the code compatible with previous c++ standards. But you can take a look to #108. There shouldn't be many changes to do.


(re)introduce consolidate blocks pass

Summary
This commit reintroduces the ConsolidateBlocks transpiler pass for consolidating a series of gates on two qubits into a single Unitary dag node.
This was previously introduced in #2134, but reverted due to bad import behavior.. But now that #2198 gave us the ability to compute circuit unitaries without relying on BasicAer, we can have this pass again.

@ajavadia can you double check that running the Aer tests with this branch don't fail like last time?

@chriseclectic it works fine now.


Pointer: NFD Feature request for MultiCluster environments

Hey Cluster-inventory-api developer/maintainers, just wanted to bring your attention to:

https://github.com/kubernetes-sigs/node-feature-discovery/issues/1423

Please don't comment on this issue, let's take the conversation on the NFD issue
Have a great day!
Cheers!

/remove-lifecycle stale

/close


500 System Error

Hello,
I'm trying to install Password Manager on a Server but unfortunately without success. I was able to follow all install steps successfully but I get the error 500 System Error when I'm calling the site via the browser.

For this installation, I created a virtual host where only Password Manager will be used. In Apache2, DocumentRoot points to the public folder. I don't get any error message from Apache2 and I don't find any log on Password Manager.
Virtual Host configuration:

Do you know what the 500 System Error message means? How can I troubleshoot here?
Many thanks,
Nicolas

Check apache error log and storage/logs/laravel logs.

Apache Error Log is empty and storage/logs I don't find any laravel log file.

Do you know what the 500 System Error checks in the program?

Is running your server as nico user? You must set the project owner as web server user.

Also, set APP_DEBUG=true in .env file to view the error log detail.

I just added my user into the group www-data and change the group owner to all files and folders and this is working. I didn't think to enable the APP_DEBUG in .env. BTW, I still don't have any folder named storage/logs/laravel. I don't know if this is normal.
Many thanks so far.
New issue and I think this is an issue with the pictures. Any idea?

Do you have the correct URLs at APP_URL and ASSET_URL?
storage/logs/laravel only exists if errors occurs.


W5500 Ethernet shield intermittent connection lost

Having some issues with my S3 relay and w5500 Ethernet shield. The device randomly disconnects over 10 times a day, for anywhere from 3-10 mins then connects again. Ethernet code is as follows
ethernet:
   type: W5500
   clk_pin: GPIO10
   mosi_pin: GPIO12
   miso_pin: GPIO11
   cs_pin: GPIO09
   interrupt_pin: GPIO13
   reset_pin: GPIO14
   clock_speed: 25Mhz

   # Optional manual IP
   manual_ip:
     static_ip: <IP_ADDRESS>
     gateway: <IP_ADDRESS>
     subnet: <IP_ADDRESS>

First use the arduino code to test, if the arduino code test does not work, then report to esphome.


GXT tokens?

There are some tokens in GXT which is for icons. Has them been imported into the project?
Also there are additional parsing work to do. Some tokens has special meanings works like escape character. I may need some time to test it in game and research on how to handle it.

For now, let's just import gxt text. We'll parse tokens later.

Sure.


Fixed typo in swagger-model

In swagger-model.js (line 208), the variable parts is undefined. I believe this should be changed to buffer, such that: buffer.push(getType(schema.items));

Thanks for contribution


[EnderZoo <IP_ADDRESS>] With [JourneyMap 5.1.5] Owls showing on JourneyMap as hostile mobs.

Well, the changelog for Ender Zoo says that it fixes owls spawning/showing as hostile mobs. Apparently, Journey Map doens't think so (This has been bugging me a lot because I would never know the difference between a Shoggoth or an owl. It's freaky).

Unfortunately I don't think there's much that can be done about this. The
owls actually appear on both the animal and hostile groups in journey map.
From a coding view, it is possible to easily tell if something is a passive
animal (eg sheep, cow) but there is no way to tell if something is hostile
to players. I think journey map tries to determine this based on attack
damage. It makes the assumption that an attack damage greater than 0 means
it is hostile. This works in most cases but not for the owl, as it will
attack spiders, and thus can deal damage.
I will have a look and see if I can atleast include an icon for it.
On 7 May 2016 7:56 AM, "Insufficient-Charge"<EMAIL_ADDRESS>wrote:

Well, the changelog for Ender Zoo says that it fixes owls spawning/showing
as hostile mobs. Apparently, Journey Map doens't think so (This has been
bugging me a lot because I would never know the difference between a
Shoggoth or an owl. It's freaky).
[image: 2016-05-06_18 54 04]
https://cloud.githubusercontent.com/assets/13188566/15088638/26f8dd46-13bc-11e6-9f5f-da612935f844.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/SleepyTrousers/EnderZoo/issues/133

There is now an API for JM for 1.9.4 so I should be able to fix it


Document the cmake build system

Describe the bug
Our documentation does not explain to users how the build system works and how to customize it for their needs
Expected behavior
A clear description and possibly some graphics showing how the different cmakelists files link with each other and how dependencies flow.
From CFS-40: Document dependencies based on features used (xxd for "embedded" files)
https://github.com/nasa/cFE/blob/e80aae94e0f56b868657daba965c590766a4dc57/cmake/target/CMakeLists.txt#L229
It might make more sense to move this into the github.com/nasa/cFS instead
Additional context
Related to conversation started in https://github.com/nasa/cFE/pull/751
Reporter Info
Gerardo E. Cruz-Ortiz

@JandlynBentley-at-NASA this might be a good one for you to tackle

I'd like to second the need for this. I'm having a heck of a time figuring out what's needed to customize a build to my needs. @astrogeco What docs do your recommend right now that I could use?

I'd like to second the need for this. I'm having a heck of a time figuring out what's needed to customize a build to my needs. @astrogeco What docs do your recommend right now that I could use?

I'd like to second the need for this. I'm having a heck of a time figuring out what's needed to customize a build to my needs. @astrogeco What docs do your recommend right now that I could use?

I'll have to defer to @jphickey since I can't think of anything other than the comments in the files inside cmake/sample_defs

I'd like to second the need for this. I'm having a heck of a time figuring out what's needed to customize a build to my needs. @astrogeco What docs do your recommend right now that I could use?

I'll have to defer to @jphickey since I can't think of anything other than the comments in the files inside cmake/sample_defs

OK great! In the meantime I can look over those comments.
On Mon, Jan 11, 2021 at 9:23 AM Gerardo E. Cruz-Ortiz <
<EMAIL_ADDRESS>wrote:

I'd like to second the need for this. I'm having a heck of a time figuring
out what's needed to customize a build to my needs. @astrogeco
https://github.com/astrogeco What docs do your recommend right now that
I could use?
I'll have to defer to @jphickey https://github.com/jphickey since I
can't think of anything other than the comments in the files inside
cmake/sample_defs
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nasa/cFE/issues/760#issuecomment-757983172, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7NUNV2LT43TSUJAKISSJTSZMCW7ANCNFSM4OG7LZUA
.

OK great! In the meantime I can look over those comments.
On Mon, Jan 11, 2021 at 9:23 AM Gerardo E. Cruz-Ortiz <
<EMAIL_ADDRESS>wrote:

I'd like to second the need for this. I'm having a heck of a time figuring
out what's needed to customize a build to my needs. @astrogeco
https://github.com/astrogeco What docs do your recommend right now that
I could use?
I'll have to defer to @jphickey https://github.com/jphickey since I
can't think of anything other than the comments in the files inside
cmake/sample_defs
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nasa/cFE/issues/760#issuecomment-757983172, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7NUNV2LT43TSUJAKISSJTSZMCW7ANCNFSM4OG7LZUA
.

@CraigKnoblauch - feel free to post a question here if there is something in particular you are struggling with.  There's a handful of issues that I've marked as "questions" where specific behavior was explained, and getting a better sense of where the challenges are would help with identifying specific documentation needs.

@CraigKnoblauch - feel free to post a question here if there is something in particular you are struggling with.  There's a handful of issues that I've marked as "questions" where specific behavior was explained, and getting a better sense of where the challenges are would help with identifying specific documentation needs.

@astrogeco @skliper I remember a version of cFS that had a setvars.sh script. Where is that file now? Or a better question, has that file's functionality been replaced by something else? Also, where can I find information about how I should set up my mission directory? It's obvious that I should have one, as a vanilla build is complaining about that, but I'm not sure where to start setting it up and telling the build system about it. Do you guys have any ideas?

@astrogeco @skliper I remember a version of cFS that had a setvars.sh script. Where is that file now? Or a better question, has that file's functionality been replaced by something else? Also, where can I find information about how I should set up my mission directory? It's obvious that I should have one, as a vanilla build is complaining about that, but I'm not sure where to start setting it up and telling the build system about it. Do you guys have any ideas?

setvars.sh was used in the "classic build" system before we transitioned to CMake.  It is no longer necessary, and has been replaced by CMake.  I'm not sure what you are asking about "mission directory", do you mean customizing "sample_defs" for your mission?  If so I recommend starting from the "sample_defs" using the quick start steps documented in the https://github.com/nasa/cFS README, and replacing/updating whatever you need to for your mission.

setvars.sh was used in the "classic build" system before we transitioned to CMake.  It is no longer necessary, and has been replaced by CMake.  I'm not sure what you are asking about "mission directory", do you mean customizing "sample_defs" for your mission?  If so I recommend starting from the "sample_defs" using the quick start steps documented in the https://github.com/nasa/cFS README, and replacing/updating whatever you need to for your mission.

Being new to this project and external, I agree that some doc on how the CMake ist structure would be very helpful.
Right now, it is not clear to me why the cfe/CMakeLists.txt is used recursively. (I don't grasp why it has to be so)
I have seen this strategy (to deal with multiple platform) in a few project before, but it turned out to be an anti pattern. It tend to confuse people and IDE. @astrogeco do you have some more information on this ?


Update README.md

Date update 😅

Hey @galbraithmedia1, the 2022 and beyond is correct. (it's when we started the package)


Disney+

Hi,
The plug-in doesn't work with DisneyPlus. It doesn't recognize the video stream

Hey @StriletsMax, thanks for reporting this! I don't have a subscription to Disney Plus at the moment but I'll see what I can do!

Hello, I appreciate the extension you made. But I recently found it is not working on Disney+. Is there any progress on this issue?

Hey @mws221, thanks for bringing this up again. I'm really busy at the moment but I'll try to work on it this week. Should I forget, please remind me kindly.

Just a quick littel update. I wasn't able to purchase Disney Plus because my credit card didn't match my country it seems. So, if someone wants to give me access to their Disney Plus, I will try to find a fix, otherwise this issue will remain open unsolved for now.


Bugfix/home page typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: donwolfga sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Update 3.x to include current master

I merged master into our very stale 3.x branch. There are some spots I'm not sure about, I'll comment them directly (it was only one).
@iainbeeston In general we should come up with a decision about how to go on with v3. What is your current opinion on that?

The 1.9 job failed because it tries to install a too new json gem version. Does someone now how fix that?

I think that the 3.0 branch is defunct - the two things that were in 3.0 that weren't in master were the removal of ruby 1.8 support, and removing support for alternative json back-ends. We've already removed ruby 1.8 support (in #340 ) and I've extracted out @pd 's commit to remove json backends in #339 . I think that once #339 is merged and released, we can close this PR and delete the 3.0 branch.
I think more generally we should continue making refactoring in master in minor releases, and once we're ready to make breaking changes (like removing caching and class variables) we should do that in a new 3.0 release. But we're not ready for that yet and maintaining a 3.0 branch is hard work.

@RST-J I just noticed the ruby 1.9 build issue too - I'll fix that

I thought, we already had more in 3.0, but under this circumstances I agree with you.
So we need two phases, the first for cleaning up the code while remaining backwards compatible and then at some point we need to introduce all the changes we think are important for 3.0. That actually could help focusing on the respective goal, rather than doing both at the same time or interleaved.
Nevertheless, when we start developing/merging the breaking changes, this should ideally be within a relativly short time frame or we'll run in the same or a similar problem again.

I agree. Can we close this pull request for now?
I should probably delete the 3.0 branch too - until (as you said) we're ready to make a short set of breaking changes for 3.0.


[MRG] test against numpy dev

This is work in progress for a fix for #5379 building upon the work done for numpy/numpy#6493.
/The current scipy test fails with:
======================================================================
ERROR: test_spearmanr (test_mstats_basic.TestCompareWithStats)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/scipy/stats/tests/test_mstats_basic.py", line 974, in test_spearmanr
    r, p = stats.spearmanr(x, y)
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/scipy/stats/stats.py", line 3314, in spearmanr
    t = rs * np.sqrt((n-2) / ((rs+1.0)*(1.0-rs)))
RuntimeWarning: invalid value encountered in sqrt

======================================================================
ERROR: test_tie1 (test_stats.TestCorrSpearmanrTies)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/scipy/stats/tests/test_stats.py", line 673, in test_tie1
    sr = stats.spearmanr(x, y)
  File "/home/travis/virtualenv/python3.5.0/lib/python3.5/site-packages/scipy/stats/stats.py", line 3314, in spearmanr
    t = rs * np.sqrt((n-2) / ((rs+1.0)*(1.0-rs)))
RuntimeWarning: invalid value encountered in sqrt

----------------------------------------------------------------------

It might be revealing a regression in numpy master or it might be caused by something that I don't understand.
I am wondering if we should put this numpy dev entry of the scipy build matrix in allow_failure.
I have not had the opportunity to test the upload section of this PR yet as the tests fail.

Those tests error because they give warnings that should be filtered out, and numpy master converts DeprecationWarning and RuntimeWarning to errors to nudge us to do that filtering.
I don't see these warnings locally, but it's easy to filter with warnings.filterwarnings, there's a lot of examples in test_stats.py that can be copied.

allow_failure may make sense, so we don't get all PR statuses red if numpy master has a temporary issue. I can't find an example of what a failed allow_failure would look like right now though.

I can reproduce the runtime warning with numpy master. Will have to investigate.

It's not at all visible now that the test actually failed. I suspect that no one will now look at the test result against numpy master, and hence it doesn't help much. So I guess just failing is better - if numpy master has a regression that takes a while to fix, we can temporarily disable the test run. Does that make sense?

@rgommers ok I removed the allow_failures configuration. Furthermore I changed the spearmanr code to not launch warnings on seemingly the valid inputs of test_stats. However that might also silence warnings that one might have considered legit when the inputs are invalid.

I have amended my commit to use the shorter travis-dev-wheels.scipy.org URL instead of the long rackcdn.com URL. If the tests pass, I think this is ready for merge. The real upload mechanism can only be tested once we merge this PR to master though.

While it's a minor quibble, I do think it's better to filter the warnings in the tests rather than the library code (https://github.com/scipy/scipy/issues/5621#issuecomment-167611301 lists the exact warnings).

@ev-br you mean catch the warnings using e.g. warnings.catch_warnings(record=True) and then check to make sure that any caught warnings have one of the accepted messages (or some accepted message forms)?

Or just this: https://github.com/scipy/scipy/blob/master/scipy/stats/tests/test_stats.py#L153

IIUC the specific issue here is that scipy is using numpy.testing, and numpy.testing actually has different warning handling behavior depending on whether numpy is a released version or not. This seems kinda wrong, though -- surely what we actually want is that numpy.testing should act differently depending on whether the code being tested is a released version or not. For numpy itself it doesn't make any difference because we're using numpy.testing to test numpy, but when numpy.testing is testing scipy then it does make a difference. Maybe we should fix that?
(This is of course separate from the more general issue of how we want to handle breakage caused by numpy skew, allow_failure, etc.)

@ev-br IMHO, scipy.stats.spearmanr should not raise any warning for valid input.
With numpy 1.10.2 the following does not raise a warning:
>>> from scipy import stats
>>> stats.spearmanr([1.0, 2.0, 3.0, 4.0], [1.0, 2.0, 2.0, 3.0])
SpearmanrResult(correlation=0.94868329805051377, pvalue=0.051316701949486225)

while it does with numpy master.
The problem with the fact that numpy.testing turns warnings into exception is a separate issue but at least it revealed a problem in the scipy code base IMHO.

For reference here is the behavior observed in a shell (outside of the testing environment) with numpy master:
>>> import numpy as np
>>> from scipy import stats
>>> stats.spearmanr([1.0, 2.0, 3.0, 4.0], [1.0, 2.0, 2.0, 3.0])
/Users/ogrisel/code/scipy/scipy/stats/stats.py:3314: RuntimeWarning: invalid value encountered in sqrt
  t = rs * np.sqrt((n-2) / ((rs+1.0)*(1.0-rs)))
/Users/ogrisel/code/scipy/scipy/stats/_distn_infrastructure.py:1748: RuntimeWarning: invalid value encountered in greater
  cond1 = (scale > 0) & (x > self.a) & (x < self.b)
/Users/ogrisel/code/scipy/scipy/stats/_distn_infrastructure.py:1748: RuntimeWarning: invalid value encountered in less
  cond1 = (scale > 0) & (x > self.a) & (x < self.b)
/Users/ogrisel/code/scipy/scipy/stats/_distn_infrastructure.py:1749: RuntimeWarning: invalid value encountered in less_equal
  cond2 = cond0 & (x <= self.a)
SpearmanrResult(correlation=0.94868329805051388, pvalue=0.051316701949486114)

I find this really confusing for the user. The input is valid. The fact that the internals of spearmanr compute stuff with non-finite quantities on the diagonal of the correlation matrix is not the users problem as those quantities are not returned as part the output of the function call.
Here are the details of an ipdb session on numpy master:
ipdb> p rs
array([[ 1.       ,  0.9486833],
       [ 0.9486833,  1.       ]])
ipdb> p 1.0 - rs
array([[  0.00000000e+00,   5.13167019e-02],
       [  5.13167019e-02,  -2.22044605e-16]])
ipdb> p (n-2) / ((rs+1.0)*(1.0-rs))
array([[             inf,   2.00000000e+01],
       [  2.00000000e+01,  -4.50359963e+15]])

The close to zero negative value on the diagonal looks like a usual rounding issue to me.

Here is an alternative fix that does not change the warning handling:
diff --git a/scipy/stats/stats.py b/scipy/stats/stats.py
index 505fe92..36b44ca 100644
--- a/scipy/stats/stats.py
+++ b/scipy/stats/stats.py
@@ -3311,7 +3311,8 @@ def spearmanr(a, b=None, axis=0, nan_policy='propagate'):

     olderr = np.seterr(divide='ignore')  # rs can have elements equal to 1
     try:
-        t = rs * np.sqrt((n-2) / ((rs+1.0)*(1.0-rs)))
+        tmp = (n - 2) / ((rs + 1.0) * (1.0 - rs))
+        t = rs * np.sqrt(tmp.clip(0))
     finally:
         np.seterr(**olderr)

I can update my PR if you think this is the right fix.

Yeah, the ideal would actually be that numpy.testing acts the same regardless of whether you're using a dev version of numpy... and that tests on scipy dev versions would always convert warnings into errors, regardless of what version of numpy they were running against.

@njsmith I agree. The behavior of the numpy warnings could be configured in the runtests.py utility, maybe with additional commandline flags.

I went on and pushed the clip-based fix. Let me know what you think about it.

OK, spearmanr glitch is somewhat parallel to uploading wheels. I'll merge this to get the latter ball rolling, and we can keep discussing the former, if needed. Thank Olivier, all.

Thanks!

See also numpy/numpy#6901, which changes numpy's test-runner to always default to release mode.

Great to have this merged. I see that Python 3.5 wheels are appearing at http://travis-dev-wheels.scipy.org/. Something is not quite right there though - only the very latest wheel should be kept. Now pip will have no way of knowing what the most recent one is right?

IIUC it keeps the most recent 5, and inserts a timestamp into the version
number so that pip can sort them properly.
On Dec 30, 2015 1:40 AM, "Ralf Gommers"<EMAIL_ADDRESS>wrote:

Great to have this merged. I see that Python 3.5 wheels are appearing at
http://travis-dev-wheels.scipy.org/. Something is not quite right there
though - only the very latest wheel should be kept. Now pip will have no
way of knowing what the most recent one is right?
—
Reply to this email directly or view it on GitHub
https://github.com/scipy/scipy/pull/5609#issuecomment-167967616.

Does pip sort the file names? Or is the part following + just ignored?

IIRC pip just takes a random one. But maybe it got smarter recently?
If there are only 5 files, they'll all be recent. But it's still possible that you would fetch a numpy and a scipy wheel from the wheelhouse that are incompatible - there's a pretty decent chance of that happening actually at the moment that numpy adds something to its API.

Interesting question! I can't find anything definitive in a quick search, but https://bitbucket.org/pypa/pypi-metadata-formats/issues/37/ordering-of-local-segments suggests that at some point the relevant people at least decided that pip should sort the local version specifiers in the way that we want.

Based on my tests pip picks up the latest version including some deterministic ordering on the local version segment which is why I made wheelhouse_uploader an upload timestamp as a prefix for the local segment.
By default it keeps the last 5 most recent dev builds (per-project / python version / platform tags). So this should all be fine.

okay, thanks for confirming @ogrisel


Contribution Guide

I think there should be a guide for those who would like to contribute to the library - it would help increase adoption.

Certainly a good idea, first question is what could people contribute? Maybe some formats and levels and different database configs. A contribution guide would probably consist of

clone the repo
read the source
run the tests
code your changes
write tests for the changes
write the PR

That's a good start. It should also include the commands for each task. I'm not sure what people would contribute, but I think a good start is including some quick-setup commands that set up logging and connect it to a database for sqlite, postgres, and mysql.

I'll submit a pull request with that guide formatted in markdown w/ commands.


Stirling occassionally segfaults on GKE

I'm running standalone mode of Stirling and then deploying it on GKE. I noticed that it occassionally segfaults. I only noticed this when using the default google container optimized image that gets deployed on GKE. My other cluster that is using Ubuntu-based image on GKE seems to not have this issue.
It might be related to this issue that I filed few weeks back: https://github.com/pixie-io/pixie/issues/314
In my cluster, I only enabled Cassandra and Postgresl tracing (stirling_enable_cass_tracing and stirling_enable_pgsql_tracing set to true).
The postgres workload that I run is similar to the one I posted in #314. For cassandra workload, I installed temporal helm chart, which internally installs a cassandra cluster): https://github.com/temporalio/helm-charts
I am unable to get the symbol of the backtrace, but it seems to point to the dynamically linked library.
E1008 16:52:52.605655 402931 signal_action.cc:63] Caught Segmentation fault, suspect faulting address 0x249300. Trace:

PC: @     0x7fde97440f8b  (unknown)  (unknown)
PC: @          0x5641abf  (unknown)  threadstacks::StackTraceCollector::Collect()
@          0x561095e  (unknown)  px::SignalAction::SigHandler()
@     0x7fdebec2b110  (unknown)  __restore_rt
@     0x7fde975d9225  (unknown)  (unknown)
@     0x7fde974aad71  (unknown)  (unknown)
@     0x7fde97440f8b  (unknown)  (unknown)

@yzhao1012 @oazizi000
I've created a container image of the binary that just registers a callback from stirling and logs the records. I have uploaded it in dockerhub. index.docker.io/haroldkf/simple_binary:0.1.0-142d720
This is the daemonset yaml I used to deploy the binary on my GKE cluster.
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: simple-binary
  namespace: simple
spec:
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app.kubernetes.io/instance: simple-binary
      app.kubernetes.io/name: simple-binary
  template:
    metadata:
      labels:
        app.kubernetes.io/instance: simple-binary
        app.kubernetes.io/name: simple-binary
    spec:
      containers:
      - args:
        - --stirling_enable_cass_tracing=true
        - --stirling_enable_dns_tracing=false
        - --stirling_enable_http_tracing=true
        - --stirling_enable_http2_tracing=true
        - --stirling_enable_kafka_tracing=true
        - --stirling_enable_mysql_tracing=false
        - --stirling_enable_nats_tracing=false
        - --stirling_enable_pgsql_tracing=true
        - --stirling_enable_redis_tracing=false
        env:
        - name: TCMALLOC_SAMPLE_PARAMETER
          value: "1048576"
        - name: PL_HOST_PATH
          value: /host
        image: index.docker.io/haroldkf/simple_binary:0.1.0-142d720
        imagePullPolicy: Always
        name: binary
        resources: {}
        securityContext:
          capabilities:
            add:
            - SYS_PTRACE
            - SYS_ADMIN
          privileged: true
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
        volumeMounts:
        - mountPath: /host
          name: host-root
          readOnly: true
        - mountPath: /sys
          name: sys
          readOnly: true
      dnsPolicy: ClusterFirstWithHostNet
      hostNetwork: true
      hostPID: true
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 10
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/master
      - effect: NoExecute
        operator: Exists
      - effect: NoSchedule
        operator: Exists
      volumes:
      - hostPath:
          path: /
          type: Directory
        name: host-root
      - hostPath:
          path: /sys
          type: Directory
        name: sys
  updateStrategy:
    rollingUpdate:
      maxSurge: 0
      maxUnavailable: 20
    type: RollingUpdate

I've also attached the source and BUILD file of the binary.
source.tar.gz
On my 3 node GKE cluster:
Currently you'll see that there is 1 pod that has 1 restart:
kubectl get pods -n simple
NAME                  READY   STATUS    RESTARTS   AGE
simple-binary-4jtxv   1/1     Running   0          7h3m
simple-binary-9wq68   1/1     Running   0          7h3m
simple-binary-xsnft   1/1     Running   1          7h3m

If we get the previous log of that pod with the restart:
kubectl logs -n simple simple-binary-xsnft -p

...
E1121 19:48:33.400875 632218 signal_action.cc:63] Caught Segmentation fault, suspect faulting address 0x249300.  Our systems are not on Kubernetes in this case and we specifically want the HTTP/HTTP2/kafka tracing.
is it possible to do it ? And how should  I build the binary ?


Deploy ERC1967Proxy.sol is not working.

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.0.2 (f908ce4 2024-08-29T00:24:00.853692000Z)
What command(s) is the bug in?
forge script script/Proxy.s.sol:ProxyScript --zksync --rpc-url $RPC_URL --broadcast -vvvv
Operating System
macOS (Apple Silicon)
Describe the bug
When I run the deployment script that deploys ERC1967Proxy, it's failed due to the following error.
Here is my sample script file. It works fine with the vanilla foundry to deploy to base sepolia.
https://gist.github.com/wshino/9b0bb6f5a20597b7b54a5ff0ac6bc7e2
In addition, I use ERC1967Proxy in my project script files since before. I believe it worked before with foundry zksync to zksync sepolia because actually I can see the txs which created contracts 1 month or 2 months ago. Why it's not working? I'd like to know how to solve this issue.
% forge script script/Proxy.s.sol:ProxyScript --zksync --rpc-url $RPC_URL --broadcast -vvvv
[⠆] Compiling...
No files changed, compilation skipped
[⠃] Using zksolc-1.5.0
[⠰] Compiling (zksync)
No files changed, compilation skipped
Traces:
  [68612] ProxyScript::run()
    ├─ [0] VM::envUint("PRIVATE_KEY") [staticcall]
    │   └─ ← [Return] <env var value>
    ├─ [0] VM::startBroadcast(<pk>)
    │   └─ ← [Return]
    ├─ [0] → new <unknown>@0xD1681dD3Bd32d684c5bdc132D4c9F0216130365E
    │   └─ ← [Return] 32 bytes of code
    ├─ [0] → new <unknown>@0x1Cb2dC61775134Ed4532190cdd4f2FD73191c1c5
    │   └─ ← [Return] 32 bytes of code
    ├─ [0] VM::stopBroadcast()
    │   └─ ← [Return]
    └─ ← [Stop]

Script ran successfully.

## Setting up 1 EVM.
==========================
Simulated On-chain Traces:

  [0] 0x0000000000000000000000000000000000000000::fallback()
    └─ ← [Continue] <empty revert data>

  [0] 0x0000000000000000000000000000000000000000::fallback()
    └─ ← [Continue] <empty revert data>

==========================

Chain 300

Estimated gas price: 0.060873511 gwei

Estimated total gas used for script: 1017396

Estimated amount required: 0.000061932466597356 ETH

==========================
⠂ Sequence #1 on 300 | Sending transactions [0 - 1]
    ⠁ [00:00:00] [----------------------------------------------------------------------------] 0/2 txes (0.0s)
    ⠁ [00:00:00] [------------------------------------------------------------------------] 0/2 receipts (0.0s)The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: ErrorResp(ErrorPayload { code: 3, message: "execution reverted", data: Some(RawValue("0x4c9c8ce3000000000000000000000000d1681dd3bd32d684c5bdc132d4c9f0216130365e")) })
Location: /Users/runner/work/foundry-zksync/foundry-zksync/crates/script/src/broadcast.rs:81

This is a bug. Consider reporting it at https://github.com/foundry-rs/foundry

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   2: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   3: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   4: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   5: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   6: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   7: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   8: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   9: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  10: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  11: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  12: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  13: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  14: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  15: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  16: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  17: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  18: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  19: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  20: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  21: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  22: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  23: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
zsh: abort      forge script script/Proxy.s.sol:ProxyScript --zksync --rpc-url $RPC_URL  -vvv

Hey @wshino thanks for opening the issue. Could you try the same but with --slow flag? Zksync doesn't support batching and the lack of the flag can lead to this error. I tried your script from my end and the deployment completed successfully.
forge script script/Proxy.s.sol:ProxyScript --zksync --rpc-url $RPC_URL --broadcast -vvvv --slow
==========================

Chain 300

Estimated gas price: 0.050000001 gwei

Estimated total gas used for script: 1010640

Estimated amount required: 0.00005053200101064 ETH

==========================

##### 300
✅  [Success]Hash: 0x9fcea647d062cfaa090bd88e4a737b46793a380a216c0878b64f56629c6e6e6f
Contract Address: 0x2314d202141eB3e2838A7899a5E3dE714121BE5C
Block: 3704056
Paid: 0.00002437015 ETH (974806 gas * 0.025 gwei)

##### 300
✅  [Success]Hash: 0x1905bfb80c86ce89eeea28e4328e241ef2a9f6b8cbc96ecd33daafbf69a6372e
Contract Address: 0xB504eC969886758214f21e011D710FD92F2401c8
Block: 3704057
Paid: 0.001272628175 ETH (50905127 gas * 0.025 gwei)

✅ Sequence #1 on 300 | Total Paid: 0.001296998325 ETH (51879933 gas * avg 0.025 gwei)

==========================

ONCHAIN EXECUTION COMPLETE & SUCCESSFUL.

@Jrigada Thank you so much. I added --slow option then I've succeeded to execute the sample script.
And I completely succeeded to deploy contracts using create2 factory.
relates to this issue


Add is_xmon_native_gate method to complement is_xmon_native_operation

When interactively working it's odd to create a qubit when what i really want to know is whether the Gate is an xmon supported gate, not whether the op is.

I'm willing to work on this.
@dabacon I can add a new function called is_native_xmon_gate next to is_native_xmon_op which checks if the provided Gate is an instance of one of the gates native to the xmon. I will then write a test for it, along with docstrings for both is_native_xmon_gate and  is_native_xmon_op which is currently lacking documentation. Does that sound good to you?

Sounds good to me.

Thanks for the invite, I just accepted it.

This issue can now be closed right? Or is there anything missing?


Setting timeout per service/router

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
I am hosting a service that needs a higher (or better disabled) read timeout for its requests. Currently I can't find a possibility to set this.
It would be very helpful, so I can host those services alongside with others, that shouldnt be exposed to CVE-2024-28869 vulnerability. (#10622)
Is there any plan to integrate this feature? NGINX supports this out of the box, I just switched to traefik a few months ago, because I like those comfort features it provides, but feels its lacking some details.
The same issue already existed in Apr. 2020 and got mentioned in the traefik community forum, but never had a reaction:
https://community.traefik.io/t/setting-timeout-per-service-router/5650
Hope its possible to implement that feature in the future.
Have a good one!

Hello @da-wilky and thanks for opening this issue,
This is an interesting idea,
If you or another community member would like to build it, let us know, and we will work with you to make sure you have all the information needed so that it can be merged.
Don’t forget to check out the contributor docs and to link the PR to this issue.

@kevinpollet I'd like to work on this :)

Hello @sreeram-venkitesh, thanks! Please go ahead :)

@kevinpollet I'd also be interested in working on this, but I think it's not clever to have this solved by a group? Would be interested in your opinion. In case this should better be done by a single dev I think @sreeram-venkitesh will do a great work!

Hey @sreeram-venkitesh and @da-wilky, it is up to you if you want to collaborate :)

@da-wilky I'm open to working with you if you'd like to do that. Else if you want to implement it on your own, I'm good with that too! Let's discuss how we can proceed :)

@sreeram-venkitesh On the free choice I'd like to collaborate with you. Currently I've never worked on an opensource project/public repo, so I hope to learn it with this task and the contributor docs. In case you got any advice I'd be happy to learn from you :)
I dont know the best practice - should this issue be the place to communicate or another messaging software, e.g. discord?

@da-wilky Awesome, we can collaborate together over Discord/Slack. Please let me know which works best for you. This would be my first time working on a feature in Traefik, but I've made other open source contributions before, so hoping we can learn from each other :)

@sreeram-venkitesh Currently im not using Slack but it wont be a problem to start with it. Just see that the messages are only hold for 90 days but think that should still be fine. If you like you can send me a message @da-wilky on Slack. Or do you need my registered e-mail?

@da-wilky Which workspace are you part of in Slack? I'm part of slack.cncf.io and slack.kubernetes.io. My Slack username is sreeram-venkitesh. If Discord is easier for you, you can add me, my username is fillerink.

Just chiming in on a use-case for this (also I think this is definitely a needed feature).
We've got a number of "typical" services behind Traefik... and then we have Sonatype Nexus. This service hosts our private Nuget and Docker repositories which in turn can contain very large files.
Clients of this service need to have more time to upload / download data. And I mean a LOT of time, sometimes. A Docker image for a Windows container can have humongous layers (think 8+GBs!) - yes, Docker for Windows is a wee bit "meh", but it's still better than no Docker at all - but that's beside the point.
So right now I had to set these vastly increased timeouts for ALL of our Traefik services, even if only one service actually requires it.

Just chiming in with a use-case for this (also I think this is definitely a needed feature).
We've got a number of "typical" services behind Traefik... and then we have Sonatype Nexus. This service hosts our private Nuget and Docker repositories which in turn can contain very large files.
Clients of this service need to have more time to upload / download data. And I mean a LOT of time, sometimes. A Docker image for a Windows container can have humongous layers (think 8+GBs!) - yes, Docker for Windows is a wee bit "meh", but it's still better than no Docker at all - but that's beside the point.
So right now, if I wanted to expose this service via Traefic, I'd need to set these vastly increased timeouts for ALL of our Traefik services, even if only one service actually required it. But since I don't want to expose all of our services to DDOS attacks I need to use our aging firewall for this service instead...

This feature request might be more appropriate for that use-case: https://github.com/traefik/traefik/issues/10611

This feature request might be more appropriate for that use-case: #10611

I'd be fine either way, really. At this time there's no way to set this without increasing timeouts for all services...


How to fit a face to get the FLAME parameters?

With BFM, I use the 68 landmarks points to get the parameters (shape, expression, etc,..). How can I do the same thing with FLAME?

You can use this https://github.com/YadiraF/DECA


Matrix multiplication bottleneck at branch oop-style

At the oop-style branch, forward pass function in Layer class is abnormally slow. Specifically the matrix multiplication code slows the model down. The reasons are unknown. The background algorithm belongs to Vectorgebra library. The said code is around 15 to 20 times slower than the Vectorgebra algorithm. Solve the speed issue, document the reasons behind it.

Issue solved with commit 7633ee1d9591d143d3d0a539f28a6a47ea3d2bd2 on pop-style branch.


adding a new column (taxon_ids) into mod table

We will need to create an end point to return the mod to taxonIDs mapping and also update the UI to get rid of hard-coded taxon ID to species name mapping and instead to get the mapping from API. @azurebrd

Sounds good @sweng66 , so this is just one part.  But do we still need somewhere in the database a place to set which taxon is the default taxon ?

It is set when we applied the alembic file @azurebrd

Thanks @valearna


chore: [CHAOS-3048]: Adds docs for breaking lci changes

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
Adds docs for breaking LCI changes
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6572f16c5345c17413843bd0--harness-developer.netlify.app


[remove] waffle.io badge

Coverage decreased (-15.2%) to 66.584% when pulling 9ab06ec0bf9889a3c264046cafdae38586dda605 on itowtips:badge into 232f4907b9805a304b640a65779f0e2c53d0a8df on shirasagi:master.