Refactor entity name data

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ec5d62b) 90.42% compared to head (27ac7cf) 90.46%.
Report is 10 commits behind head on devel.

Files
Patch %
Lines

hahomematic/platforms/device.py
94.44%
1 Missing :warning:

hahomematic/platforms/entity.py
88.88%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1437      +/-   ##
==========================================
+ Coverage   90.42%   90.46%   +0.04%
==========================================
  Files          49       49
  Lines        6037     6074      +37
==========================================
+ Hits         5459     5495      +36
- Misses        578      579       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Including DCO with automated manifest updates

Description
Including DCO with automated manifest updates
Issues Resolved

Can be used to avoid a rebase like was done in https://github.com/opensearch-project/opensearch-build/pull/1515

Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Do we have to include a actual human user name? We can include the signature from the bot account. Thanks.

@peterzhuamazon / @abhinavGupta16 Could you provide the name and email you want this to?

Do we have to include a actual human user name? We can include the signature from the bot account. Thanks.

@peterzhuamazon / @abhinavGupta16 Could you provide the name and email you want this changed to?

Can you try to see if this runs?
opensearch-ci-bot<EMAIL_ADDRESS>

Codecov Report

Merging #1528 (fa3c54f) into main (0dbada0) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1528      +/-   ##
============================================
- Coverage     94.32%   94.16%   -0.16%
  Complexity       12       12
============================================
  Files           146      146
  Lines          3152     3152
  Branches          8        8
============================================
- Hits           2973     2968       -5
- Misses          172      177       +5
  Partials          7        7

Impacted Files
Coverage Δ

src/system/temporary_directory.py
83.87% <0.00%> (-12.91%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbada0...fa3c54f. Read the comment docs.


fix RigidBody without Collider problem

Applying a force to a RigidBody without colliders the body escapes from Joints.
Resolve this issue:
https://github.com/DanielChappuis/reactphysics3d/issues/388
The functionality was broken by this commit:
https://github.com/DanielChappuis/reactphysics3d/commit/8f46764e4bc5e7a60e028accb4ce2f6d0ab8ec47

Thanks a lot for taking the time to fix this issue. It's very helpful. I have merged it into the develop branch. This will be available in the next release of the library.


Does PowerBI and Azure egress apply for gateway scenarios?

This document is missing explicit mention of following aspects
-> Does egress charges apply in context of gateway taking care of pulling data from azure and pumping to powerbi
-> What does the charges of egress look like.. any link is much appreciated

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0577c02-6c3e-870c-ddee-d93cafef9206
Version Independent ID: b9c65245-32e4-8bc9-8971-e76bff0ad837
Content: Power BI and Azure egress - Power BI
Content Source: powerbi-docs/service-azure-egress-power-bi.md
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Adding assignees to help clarify - thanks for your comments and questions.

@arthiriyer - can you comment on this one, and let me know if we need a doc update.

Gateway by itself doesn't have any additional charges.  I don't think we need doc updates here.


i18n module missing it seems

🐛 Bug Report
I'm getting error as below when running the with this module.
`
Cannot find module 'next/dist/next-server/lib/i18n/normalize-locale-path' from 'node_modules/next-page-tester/dist/utils.js'
Require stack:
  node_modules/next-page-tester/dist/utils.js
  node_modules/next-page-tester/dist/getPageObject/makeRouteInfo.js
  node_modules/next-page-tester/dist/getPageObject/index.js
  node_modules/next-page-tester/dist/page/getPageInfo.js
  node_modules/next-page-tester/dist/page/index.js
  node_modules/next-page-tester/dist/getPage.js
  node_modules/next-page-tester/dist/pure.js
  node_modules/next-page-tester/dist/index.js
  __tests__/HomeTest.js

  at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
  at Object.<anonymous> (node_modules/next-page-tester/dist/utils.js:16:33)

`
Reproduction
Please provide a link to a minimal GitHub repo reproducing the issue (we won't be able to provide support otherwise).
Expected behavior
NextJS expect i18n but next-page-tester lacking it
Jest patch
Have you patched Jest as described here?

[ ] yes
[ x] no

Run npx envinfo --preset jest
`npx: installed 1 in 0.885s
System:
OS: Windows 10 10.0.19042
CPU: (16) x64 11th Gen Intel(R) Core(TM) i9-11900KF @ 3.50GHz
Memory: 50.58 GB / 63.68 GB
Binaries:
Node: 14.16.1 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.14.12 - C:\Program Files\nodejs\npm.CMD
Managers:
pip3: 20.2.3 - C:\Python39\Scripts\pip3.EXE
Utilities:
Git: 2.31.1. - C:\Program Files\Git\mingw64\bin\git.EXE
IDEs:
VSCode: 1.55.2 - C:\Users\jyk20\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
Visual Studio: 15.9.28307.1500 (Visual Studio Community 2017)
Languages:
Bash: 4.4.23 - C:\Program Files\Git\usr\bin\bash.EXE
Perl: 5.32.1 - C:\Program Files\Git\usr\bin\perl.EXE
Python: 3.9.4 - C:\Python39\python.EXE
Browsers:
Edge: Spartan (44.19041.906.0), Chromium (90.0.818.46)
Internet Explorer: 11.0.19041.1
`

It seems that your project is using non matching version of next and next-page-tester. See here.
Closing since not enough information is provided to give support.


Initialize class property that has no initializer with this.prop

Currently class properties with no initializer are set as null and un-writable, which is problematic especially for Angular 2 apps that utilize decorators often.
class SomeComponent {
  @Input() prop;
}

According to the ES Class Fields and Static Properties proposal, no initializer should be treated as an initializer with this.prop.

@loganfsmyth I'm still not sure about this line.
const property = t.isLiteral(node.key) ? node.key : t.stringLiteral(node.key.name);

Does it allow string/number literals to be class properties like the following? I tried them but babel raised errors.
class Foo {
  @dec
  123;

  @dec
  "hello";
}

Eww, are you really monkey patching Babylon? That's so fragile, why would you do that... If it's not on a standards track somewhere, monkey-patching it in and telling people to use it is just going to cause pain for your users in the future :(
The objective of this module is the emulate the existing behavior of Babel 5. What does Babel 5 do in this case? My current position is that anything that wasn't in Babel 5 should wait until the new revision of the decorators spec is available.
The const property applies to all class method/prop nodes. In the case of class properties, the parser only supports parsing identifiers in that location.

@loganfsmyth I have given up the parameter decorator support and will stop monkey-patching in the repo.
Anyway, as far as I researched, Babel 5 works as same as this plugin does. It sets a decorated property with no initializer undefined and makes it un-writable.
function dec() {
}

class Foo {
  @dec withDec;
  withoutDec;
}
Foo.prototype.withDec = 'with';
Foo.prototype.withoutDec = 'without';

var foo = new Foo();
console.log(foo.withDec); // undefined (should be 'with')
console.log(Object.getOwnPropertyDescriptor(foo, 'withDec')); // { value: undefined, writable: false, enumerable: true, configurable: true } (should be writable)
console.log(foo.withoutDec); // without
console.log(Object.getOwnPropertyDescriptor(foo, 'withoutDec')); // undefined (should be defined)

I understand that this plugin is for emulating the behavior of Babel 5's decorator support. But it's not only about decorators here. It messes up the behavior of class properties.
Which way do you think I should take? Should I make a PR to the babel repo and come back here when it's merged?

What will be probably the future behaviour of decorators? Will they be un-writable?

According to the proposal, it should be same as @Input() prop = this.prop; and of course not un-writable.
Actually there two separate issues.

decorated property with no initializer gets un-writable
(the proposal) no initializer should be same as this.prop

Ok thanks. Currently it is really annoying to set default values everywhere to get the appropriate behaviour especially as you said when you want to work with angular2.
Anyway, a changelog would be nice it took me some time to find this fundamental change in behavior.

Is it only pending on a changelog?

Any update on this? It breaks @lazyInject from Inversify


NIFI-5909

added optional settings for date, time, and timestamp formats used to write Records to Elasticsearch
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

No unit tests have been added/modified, as existing tests verify only the URL used to call ES, but not the content. I'm thinking of adding a callback hook to the realRequest inside PutElasticsearchHttpRecordTestProcessor.createElasticsearchClient() to do any custom content assertions

Yes, I do plan to add them - time permitting, as there's some infrastructure coding I need to do first, to make content assertions possible.


Xamarin.UITest on iOS stopped restarting the app even with StartApp

What App Center service does this affect?
Xamarin.UITest
Describe the bug
Running iOS tests locally sometimes won't restart/reset my app, even when I call StartApp before each test. This makes my tests fail occasionally because the app is just opened in a different screen.
I don't recall this happening before (not sure when it started because I can't test older versions with XCode 10.2), so it looks like something that changed in recent versions.
To Reproduce
Steps to reproduce the behavior:

Clone this project: https://github.com/akamud/KickassUI.Traveler
Change the device UDID to your local iPhone X simulator on AppInitializer.cs
Run the tests once
Run the tests again

Expected behavior
The second test fails because the app is not restarted.
Note: this might happen on any run, but this was the most easy way I found to reproduce the problem.
Smartphone (please complete the following information):

Device: iPhone X Simulator
OS: 12.2
XCode: 10.2

Additional context
Xamarin.TestCloud.Agent: 0.21.8
Xamarin.UITest: <IP_ADDRESS>2-dev

I'm seeing this behavior in all of my apps with UITests, even apps I used to run before with no problems.

Thanks for mentioning this, this is a known issue. We have a workaround by forcing the iOS simulator to restart between each test case:

Environment.SetEnvironmentVariable("UITEST_FORCE_IOS_SIM_RESTART", "1");

Here's an implementation by placing that variable just before your ConfigureApp.iOS method: https://github.com/King-of-Spades/AppCenter-Test-Samples/blob/master/Xamarin.UITest/UITestDemo/UITestDemo.UITest/AppInitializer.cs#L35-L36

Is the restart going to be the default in new versions or should I be using this workaround forever?

@Akamud we have an active bug report for the issue, but I don't have an ETA for the fix currently. When a fix is made it should be mentioned in the release notes for the Xamarin.UITest package, unless the fix is applied to the Test Cloud Agent instead (but I don't think the cause is directly in there.)

Awesome, thanks!

Sorry to bring bad news, we still haven't made progress on this part. I will update when we know more.

Actually, restarting the simulator, will bring another issue when having multiple tests:

in case the simulator doesn't start fast enough, the test will fail with
SetUp : System.Net.Http.HttpRequestException : Connection refused
----> System.Net.Sockets.SocketException : Connection refused

Tried with our sample from here https://github.com/King-of-Spades/AppCenter-Samples/tree/master/Xamarin.UITest/FormsGallery
The only workaround I could find was to set UITEST_FORCE_IOS_SIM_RESTART to 0

Hmm...sounds like a bit of a catch-22. I don't consistently see that Connection refused error when using the SIM_RESTART method, but I do see it intermittently, so your observations are reasonably credible to me.

@King-of-Spades we have received some reports that this is happening constantly with these conf:
Xcode: 10.3 (10G8)
Nunit: 2.6.4
Xamarin.UiTest: 3.0.1
Visual Studio for MAC: 2019 (currently Up-To-Date, no available updates are suggested)
Mac OS: 10.14.6
Xamarin Forms Version we use for building the application: <IP_ADDRESS>8606
Mono JIT compiler version <IP_ADDRESS>1
Any idea why this might happen? This started after VS4m was updated to latest 8.2.
On my machine, with same config, I can only see it intermittently when moving between tests or when you have multiple tests.

Looks to be a regression in Mono 6.x https://github.com/mono/mono/issues/15830

Actually, restarting the simulator, will bring another issue when having multiple tests:

in case the simulator doesn't start fast enough, the test will fail with
SetUp : System.Net.Http.HttpRequestException : Connection refused
----> System.Net.Sockets.SocketException : Connection refused

Tried with our sample from here https://github.com/King-of-Spades/AppCenter-Samples/tree/master/Xamarin.UITest/FormsGallery
The only workaround I could find was to set UITEST_FORCE_IOS_SIM_RESTART to 0

oh thank good I'm not the only one, I could not find anything related to this problem. I got the connection refused all the time and cannot start the tests at all. Really frustrating since we are close to release...

@cheles Thanks for the data. I'll see if I can match my environment to yours and if that seems to influence how often this issue is occurring. With your observation of the Mono regression, did downgrading Mono seem to help with the symptoms?

I am seeing the Connection Refused error consistently now and am currently experimenting with workarounds.

as mentioned in above bug, downgrading to mono 5.x would be one workaround. the thing is  latest VS 4 mac will complain every time if Mono is not 6.x.

This downgrade works for me. (Gathered from https://versions.internalx.com/products):
Visual Studio Community 2019 for Mac
Version 8.1.5 (build 9)
Installation UUID: f63ec00d-8c4e-415e-86b3-06ebd839d9ac
GTK+ 2.24.23 (Raleigh theme)
Xamarin.Mac <IP_ADDRESS> (d16-0 / 50f75273)
Package version: 518010028

Mono Framework MDK
Runtime:
Mono <IP_ADDRESS> (2018-08/223ea7ef92e) (64-bit)
Package version: 518010028
Trying a few more experiments though.

8.1 works with 5.x but from 8.2 it will require every time to pick Mono 6.x and then downgrade. Net/Mono to 5.x

Yup, downgrading both is the only workaround I've been able to confirm.

I think it's this issue: https://github.com/microsoft/appcenter/issues/421
It looks like a slightly cleaner solution is here: https://github.com/microsoft/appcenter/issues/421#issuecomment-515018570
Basically within VSMac Preferences, you can switch the version of Mono. I suspect it comes up because between major version changes it doesn't overwrite the previous major version. Also, there's an existing bug filed for the issue against Mono here: https://github.com/mono/mono/issues/15830
^ That should just about cover the problem @cheles encounters. I think, once those symptoms are worked around; the behavior in this original bug report is still valid.

Haha, the mono bug points back to UITest. Well, the silver lining is still that it looks like it's being worked on :D

Internal tracking id for this issue: 52641

Did this get any update?

Any new news? This still seems to be an issue which makes the UI tests for our company useless.
Thanks in advance!

Hi, is this being handled?

^ @Oddj0b any news?

@King-of-Spades @Oddj0b is Xamarin.UITest deprecated? If not, why hasn't this been addressed? This issue was opened 2 years ago, and Im constantly hitting connection refused.
Issues like this waste hundreds of hours for developers. It would be better to just deprecate Xamarin.UITest if you can't make a stable version. Its one of the reasons why we are looking to move away from Xamarin entirely.

Hi @JohnHDev sorry for the frustration. I'm no longer on the App Center Test team, in fact I'm leaving Microsoft soon most likely. Xamarin.UITest did have a new version come out 5 days ago, though I don't see any explicit indicators that the issue has been updated: https://www.nuget.org/packages/Xamarin.UITest/
My best research, based on my limited remaining access (ending May 31st) indicates that the internal bug was canceled when the team (perhaps incorrectly) believed the reports on the issue dried up.
One of the nuances of these symptoms is that they can disappear or reappear with updates. The problem at a fundamental level is that many times in the past, Apple's Xcode updates (even minor ones) would break basic Xamarin.UITest functionality and require patching. To some extent this could be a challenge for Google's Android updates, but not nearly as much to the same degree. (Other tooling dependencies can also have an impact, but Xcode / Android updates are the most common).
I suspect the best way to get the spotlight on your case is to do the following:

Fork / clone etc. this sample: https://github.com/microsoft/appcenter-Xamarin.UITest-Demo
Update to the latest packages (I used to maintain it, but as I said I'm not part of the team anymore.)
Modify the sample if needed to demo your issue / the failure state.
Log into App Center & Contact support with your version of the sample that reproduces the issue.

The reason this is effective is that it dramatically narrows the expected behavior & demonstrates reproducibility. App Center Test never had a formal public bug tracker. If other devs like you are wanting to more collectively get attention on this you could always share the same "copy" of the sample to reproduce along with the tickets you open.
This strategy is also ideal, where feasible, for highlighting any other bugs you want to report.
Lastly, I'm really really sorry that it's so frustrating. I supported Xamarin Test Cloud / App Center Test for many years and always tried to advocate for fixing bugs, reducing issues that trip up developers, etc...It wouldn't be appropriate for me to say more about that, beyond my apology...but I wish you folks using the tooling all the best.

@King-of-Spades I very much appreciate your candour, and I would like to apologise for my tone in my previous reply. I have no excuse other than the frustrating nature of some of the MS products can feel like banging my head against a wall.
I wish you the best in your future endeavours! Thank you for all your efforts with AppCenter and Xamarin.UITest.
As an aside I did get this working, and it is now working well. I don't know why it was failing for me, but I won't rule out user error on my part.

@JohnHDev No worries, 7 years in support also gave me a quite thick skin. :D
My own philosophy on user error is, it's really great when we can design software tools that follow the philosophy "falling into the pit of success" described in this article: https://blog.codinghorror.com/falling-into-the-pit-of-success/
It's not always possible to design tools in such a way as to reduce user confusion and/or user error...but oftentimes the pain and damage from those things can be reduced by being clearer about basic tool usage & debugging. That was actually part of the inspiration for creating the sample I shared, and a few other samples I've created over the years.
Actually, it's how I'm hoping to retool my career: I'm trying to find roles in documentation writing and/or management full-time because over that 7 years in support I've found that most engineers asking for help or reporting bugs have similar experiences to you: they just want the information to be unblocked and get back to building things. Most engineers don't even need "all the answers" just useful context that isn't easily discoverable from their perspective.

@King-of-Spades that sounds like a good plan.
Actually, considering the internal bug for this has been closed, would you mind closing this too? Otherwise it leads to confusion where developers find an issue, google it, see an open bug with no recent movement and blame the tools, sometimes too quickly.

I've come up with what seems like a reliable workaround
        const string FullPathToIPA = "/Users/jm/repos/ourapp/ourapp/iOS/bin/iPhoneSimulator/Debug/ourapp.iOS.app";

                // Deleting and re-installing the app basically clears app data.
                // Delete app
                var processUninstall = Process.Start("xcrun", "simctl uninstall booted " + IpaBundleId);
                processUninstall.WaitForExit();

                // Install app
                var processInstall = Process.Start("xcrun", "simctl install booted " + FullPathToIPA);
                processInstall.WaitForExit();

                _app = ConfigureApp
                    .iOS
                    .DeviceIdentifier(SimIdiPhone8iOS124)
                    .PreferIdeSettings()
                    .AppBundle(PathToIPA)
                    //.InstalledApp(IpaBundleId)
                    .StartApp(AppDataMode.Clear); // Currently only supported in Xamarin Test Cloud.

I think the FullPathToIPA might be slightly different beyond the obvious with the additional iOS folder.
Also I'm betting the path can be derived from the current home folder etc.


Using ImportC instead of direct D binding

At the time when bindings were written ImportC wasn't even there yet but now it's in somewhat working condition
I think it'd be mich more viable to use it to directly import C header instead of tracking down each change

I did a bit of tests and it seems it works fine if you add this defines to header, but can't fully tell unless we fix #57 and mangle with ABI a lot

Would be great once it gets all cleaned up!

Would this be attempting to use the C++ stuff they have in their tutorials then? Or something else?

Original gdextension header is a simple C header that declares stuff so it shouldn't really pose much problems, but it all depends on ImportC

Apparently now gdextension interface can be dumped with godot binary too

@Superbelko I got ImportC working (albeit needed fix that I said in here) and now I'm facing some troubles with variant of all things. It seems godot defines it's own abi variant?
In any case, I'm getting these errors and would like your help if I won't be able to fix it til you notice:
    Starting Performing "debug" build using /usr/bin/dmd for x86_64.
    Building godot-dlang ~master: building configuration [library]
src/godot/variant.d(525,67): Error: function pointer `(*_godot_api).get_variant_from_type_constructor(GDExtensionVariantType p_type)` is not callable using argument types `(VariantType)`
src/godot/variant.d(525,67):        cannot pass argument `VariantType.rid` of type `VariantType` to parameter `GDExtensionVariantType p_type`
src/godot/variant.d(525,67): Error: function pointer `(*_godot_api).get_variant_from_type_constructor(GDExtensionVariantType p_type)` is not callable using argument types `(VariantType)`
src/godot/variant.d(525,67):        cannot pass argument `VariantType.array` of type `VariantType` to parameter `GDExtensionVariantType p_type`
classes/godot/object.d(24,27): Error: template instance `godot.api.bind.GodotMethod!(String)` error instantiating
Error /usr/bin/dmd failed with exit code -4.

Also gonna push the thing into new branch

VariantType is internal to Variant D wrapper, GDExtensionVariantType is probably just an int, we shouldn't really break type safety but seems like this hack should fix it enum VariantType : int
https://github.com/godot-dlang/godot-dlang/blob/68cab82d56ffb707e95e944d18070059cd4a68ff/src/godot/variant.d#L84
But this will break type safety as D is quite happily converts int types leading to "funny" bugs but not enum to int.
--- OR ---
A better fix would be to explicitly add cast  to GDExtensionVariantType in such places, though this can be quite annoying if this will pop up all over the code base.
https://github.com/godot-dlang/godot-dlang/blob/68cab82d56ffb707e95e944d18070059cd4a68ff/src/godot/variant.d#L525
auto Fn = _godot_api.get_variant_from_type_constructor(cast(GDExtensionVariantType) VarType);

I'd rather prefer explicit casts then haha funny 10 year debug session

I think I got it
Adding cast to GDExtensionVariantType to those lines
https://github.com/godot-dlang/godot-dlang/blob/68cab82d56ffb707e95e944d18070059cd4a68ff/src/godot/variant.d#L525
https://github.com/godot-dlang/godot-dlang/blob/68cab82d56ffb707e95e944d18070059cd4a68ff/src/godot/variant.d#L496
Adding cast to GDExtensionVariantOperator on first argument on this line
https://github.com/godot-dlang/godot-dlang/blob/68cab82d56ffb707e95e944d18070059cd4a68ff/src/godot/variant.d#L650
And removing nothrow on these functions since _godot_api.print_error is not nothrow
https://github.com/godot-dlang/godot-dlang/blob/68cab82d56ffb707e95e944d18070059cd4a68ff/src/godot/api/output.d#L45
https://github.com/godot-dlang/godot-dlang/blob/68cab82d56ffb707e95e944d18070059cd4a68ff/src/godot/api/output.d#L13
Allows me to compile without any errors, gotta do testing now

What did I event expect
../../src/godot/api/register.d(316,13): Error: cannot implicitly convert expression `& callMethod` of type `extern (C) void function(void* methodData, void* instance, const(void**) args, const(long) numArgs, void* r_return, __tag149* r_error) @system` to `extern (C) void function(void* method_userdata, void* p_instance, const(void*)* p_args, long p_argument_count, void* r_return, __tag149* r_error)`
../../src/godot/api/wrap.d(475,39): Error: cannot implicitly convert expression `0u` of type `uint` to `GDExtensionVariantType`
../../src/godot/api/register.d(376,13): Error: template instance `godot.api.register.register!(Asteroids).register.registerMethod!(_ready, null)` error instantiating
../../src/godot/api/register.d(183,21):        instantiated from here: `register!(Asteroids)`
../../src/godot/api/register.d(316,13): Error: cannot implicitly convert expression `& callMethod` of type `extern (C) void function(void* methodData, void* instance, const(void**) args, const(long) numArgs, void* r_return, __tag149* r_error) @system` to `extern (C) void function(void* method_userdata, void* p_instance, const(void*)* p_args, long p_argument_count, void* r_return, __tag149* r_error)`
../../src/godot/api/wrap.d(475,39): Error: cannot implicitly convert expression `0u` of type `uint` to `GDExtensionVariantType`
../../src/godot/api/register.d(376,13): Error: template instance `godot.api.register.register!(Player).register.registerMethod!(_ready, null)` error instantiating
../../src/godot/api/register.d(183,21):        instantiated from here: `register!(Player)`
source/asteroids.d(14,1):        parent scope from here: `mixin GodotNativeLibrary!("asteroids", Asteroids, Player)`

Now Godot itself complains
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.stable.arch_linux
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /usr/lib/libc.so.6(+0x38f50) [0x7fa096051f50] (??:0)
[2] /usr/bin/godot(+0x47427b8) [0x55d463f987b8] (??:?)
[3] /g/godot-dlang/examples/asteroids/project/libasteroids.so(_D5godot7variant7Variant__T2asTSQBe6object11GodotObjectZQBdMxFZQBg+0x5a) [0x7fa08c9a8676] (??:0)
[4] /g/godot-dlang/examples/asteroids/project/libasteroids.so(_D5godot7variant7Variant__T2asTSQBe11rigidbody3d11RigidBody3DZQBjMxFZQBm+0x15) [0x7fa08c9a860d] (??:0)
[5] /g/godot-dlang/examples/asteroids/project/libasteroids.so(_D9asteroids9Asteroids8_processMFfZv+0xd8) [0x7fa08c97fc04] (??:0)
[6] /g/godot-dlang/examples/asteroids/project/libasteroids.so(_D5godot3api4wrap__T13MethodWrapperTC9asteroids9AsteroidsS_DQxQp8_processMFfZvZQCh10callMethodUPvQcxPPvlQjPS3__C8__tag149Zv+0x279) [0x7fa08c9a99ed] (??:0)
[7] /g/godot-dlang/examples/asteroids/project/libasteroids.so(_D5godot3api4wrap__T13MethodWrapperTC9asteroids9AsteroidsS_DQxQp8_processMFfZvZQCh11virtualCallUPvxPPvQgZv+0x44) [0x7fa08c9a9ae8] (??:0)
[8] /usr/bin/godot(+0x2c616b9) [0x55d4624b76b9] (??:?)
[9] /usr/bin/godot(+0x10155d8) [0x55d46086b5d8] (??:?)
[10] /usr/bin/godot(+0x4743cf8) [0x55d463f99cf8] (??:?)
[11] /usr/bin/godot(+0x2c313b6) [0x55d4624873b6] (??:?)
[12] /usr/bin/godot(+0x2c824ee) [0x55d4624d84ee] (??:?)
[13] /usr/bin/godot(+0xf39fe4) [0x55d46078ffe4] (??:?)
[14] /usr/bin/godot(+0xee01a3) [0x55d4607361a3] (??:?)
[15] /usr/lib/libc.so.6(+0x23790) [0x7fa09603c790] (??:0)
[16] /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7fa09603c84a] (??:0)
[17] /usr/bin/godot(+0xeee9b5) [0x55d4607449b5] (??:?)
-- END OF BACKTRACE --
================================================================

I will take a look later.

api/register.d(316,13): Error: cannot implicitly convert expression & callMethod of type extern (C) void function(void* methodData, void* instance, const(void**) args, const(long) numArgs, void* r_return, __tag149* r_error) @system to extern (C) void function(void* method_userdata, void* p_instance, const(void*)* p_args, long p_argument_count, void* r_return, __tag149* r_error)

when this happens it is easy to miss actual problem, in such situation i just take this message part and put on different lines in text editor, turn the line wrapping off, and visually compare them.
smth like this:
extern (C) void function(void* methodData, void* instance, const(void**) args, const(long) numArgs, void* r_return, __tag149* r_error) @system

extern (C) void function(void* method_userdata, void* p_instance, const(void*)* p_args, long p_argument_count, void* r_return, __tag149* r_error)

p_args doesn't match, it has different const levels - fully constant const(void**) and reassignable outer pointer const(void*)*

Changing constness didn't help and it was first thing I tried.
Also re-tried it, godot is still crashing

Does currently master builds works on Linux at all? I've stepped your importc branch through debugger and I don't see anything crazy, however all arguments messed up and probably 'this' too.

Ye, I've tested master branch and it works
Also to note that I can't test it on windows since dub complains about paths for some reason
And another note is that I'm using both latest D and Godot

There should be some minor subtle issue like missing export(C) or wrong parameters order because it looks almost ok.
As for windows you need to clean up this old overrides, they are proven to be quite messy, better to use dub lock file even if it is more tedious to set up for every project.

@al1-ce psst, did you seen the fix? I wrote this just in case if editing messages doesn't have notification.

@Superbelko please review pull request
ImportC branch is now kind of stable, but I'd like you to see it before blindly merging
Also on same topic, what to do with header file? Should we manually update it in repo or do same thing as we do with GDExtension API and pull it from godot?

Yes let's keep it how it is, now since godot is more or less stable it shouldn't take much time to maintain current gdextension interface.
As for ImportC, it is kind of cool that D can do that, however setting tons of dependencies just for one tiny header is silly, especially on Windows where there isn't even a better way other than running your builds with VS developer console (cl.exe).
The real value of ImportC is for CI integration, this way we can save the hassle of manually update headers for every build and instantly know when they've messed up with godot again.
I have been working on CI but kind of dropped because of lack of time.

I meant do we keep header and preprocessed file in repo or we remove it and make it be dumped with gdextension api
Actually nothing prevents us from using ImportC if to keep header coz it's a part of D compiler and doesn't require any deps
Only problem with it is preprocessing (aka dumping gdextension.i file) which needs gcc (and not a problem on linux), but I can just update it on each version manually

Though I might need to do some trickery to make it effortless. Maybe separate files for both windows and linux
Actually, if you're on windows, does ImportC branch compile fine? My concern is import paths in .i file which I don't know if they work on windows

No, they are generated anyways.
Also I think we should have "importc" as version specifier for now and continue using manually created bindings, we still need to develop the project itself and looking every time in original header can be PITA as there is no IDE support at all.
IIRC yesterday I only tried to build it and the build was green, but I haven't run anything yet.
just for further reference, to preprocess header using VC compiler do this from developer command prompt and it outputs preprocessed .i file.
cl /P gdextension_interface.h

No ide support for C headers? That's new
Imho manual bindings are PITA and I'll still be looking on how to ease ImportC usage (which is bottlenecked by windows since linux is has "build-essentials" or something similar)

Oops, of course I meant configuration for it.
Yeah like I said now when it stabilized it just a 5 minutes update once in a while.
Anyway, let's just keep it optional for now, we can also switch how it works later.

Ok, gonna test fixed variant/register/wrap with manual bindings then
If it all works I'm gonna make a module with public import to both manual bindings and header (but gonna keep import for header commented for now)

Fixed stuff as you suggested in review for PR in #117
For now ImportC will be a "version" that you can use if you want, determined here:
https://github.com/godot-dlang/godot-dlang/blob/153b5d001f2209cc120b8fcbf3724e560aca4781/src/godot/abi/gdextension.d#L3-L7
And can be used by adding dflag or custom build type like so:
https://github.com/godot-dlang/godot-dlang/blob/153b5d001f2209cc120b8fcbf3724e560aca4781/examples/asteroids/dub.json#L20-L25
BUT I can't merge branch into main yet, because there's some wierd problems now with properties, both bindings and header currently crash playmode and they do not update some of properties (but some are updated)
How properties behave:
Property - successfully updates and adds " ~ hello from setter/getter!" string each time
Number - resets to 2
Only Getter - does nothing
Long node path - prints message but path is always empty
My Str - can't test since cannot enter play mode, but can set it and it will be kept as is
Only Setter - always outputs 0 (which is incorrect)
Freal - resets to 0
Dreal - resets to 0

Commented out problematic line (157) in example.d in test project for now and now it fails at several points:
240: assert(vLongBack == 1L)
247: assert(vUbyteBackL == 250L);
250: assert(vUbyteBack == ubyte(250));
257: assert(vAssignedBack == -33);
401: assert(a[1 .. $].equal(Array.make("two", NodePath("three"), 4.01)[]));
And so on
Since it all involves calling godot's .as at some point it might be of concern that something broken with GDExtensionClassMethodCall and others, which might've resulted in properties going crazy
And have no idea how to fix it all

Have you updated manual bindings up to 4.0.1?

Ok I'll look into it later.

The fun fact is that Variant.as() for NodePath is broken.
No idea what's wrong, I will have to debug it on windows later.

Wow, it looks like variant was actually broken since early alpha days, back then it had confusing names, I did something and it worked, or so it was seems.
Fixed, tested play/editor both test and asteroids both ImportC and master.
patch for simplicity, variant.d around line 505.
  src/godot/variant.d | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/godot/variant.d b/src/godot/variant.d
index 3aade56..b740494 100644
--- a/src/godot/variant.d
+++ b/src/godot/variant.d
@@ -503,10 +503,8 @@ struct Variant {
             import core.stdc.string;
             memset(&ret, 0, ret.sizeof);

-            // auto fn = _godot_api.get_variant_to_type_constructor(VarType);
-            auto fn = _godot_api.get_variant_from_type_constructor(cast(GDExtensionVariantType) VarType);
-            // fn(cast(void*)&ret, cast(void*)&_godot_variant); // old
-            fn(cast(void*)&_godot_variant, cast(void*)&ret); // new
+            auto fn = _godot_api.get_variant_to_type_constructor(cast(GDExtensionVariantType) VarType);
+            fn(cast(void*)&ret, cast(void*)&_godot_variant);

             static if (directlyCompatible!R)
                 return ret;

I'll check this fix, thanks
And that's why I consider ImportC to be crucial, coz it's stricter and enforces stuff to be right (plus less pain in tracking header for manual bindings)
If I didn't try doing that we might've not found those issues earler and they would've been much harder to debug

Implemented by #116

Don't get me wrong but I already hate this feature, it is not bad but there is practically zero usability and tooling sucks, after all it was ended up wasting my time debugging this mess. Add to that a very unique macro/template style of godot itself and I'm already want drop godot-d and never look back.

Sorry to hear as much
Wish I could contribute much more and rely much less on you, but I have really hard time understanding more low level parts
About importc, now it's just there and nothing more, it's easily disableable and so on
And I'll try to attract more people in, eventually, I hope

There isn't much can be done, D community is not that big and even less there are people interested in making games with D.
Like I said I don't blame anyone or the importc, I just saying godot4 itself looks like it is just bolted together into something that works, then I took original godot-d which was made similar way, it is work of a genius indeed but extending it turn out to be a mess.
Just look at the comments I left in code when updating stuff, eww...
We are make tons of tech debt here, full rewrite won't give anything and is out of question, and in its current shape nobody will want to dig through this pile of junk either.
Something needs to be done but no one have idea where to start and what to do, it is all intertangled - variant-wrap-register-api .... this is the core of it but it basically becomes one big ugly monolith.
Heck we don't even have string/stringname properly refcounted yet, D added copy constructors because oops postblit was a mistake, we have postblits/coypctors mixed up in all base types now... Another problem is that I updated generator to be  used with postblits and when we use copyctors it breaks in infinite copy construction cycle as this new() methods need to be decoupled.
And there is issues like that in practically every aspect.

And what's your proposal? Abandon it and go to somewhere like Dagon or suffer with awful C bindings?
Godot together with D creates a really small niche, but if there's nice solution there might come more people, maybe even new ones
Idk, personally I like godot and I love D and I don't really want to write entire engine from zero and there isn't much of anything except said Dagon or C bindings for raylib or stuff like that
But that's me, dunno about you, dunno about others. I just want to be able to enjoy some good engine with good language
And for geniuses, there are some and they might help, both webfreak and arsd might give a bit of help if to be very convincing

For starters string/stringname needs to be fixed, we have few open issues as well.
More complex issues is decoupling of said new() factory methods and getting rid of postblits where possible.
I'll try to write more detailed issues and proposed fixes.
Now I have to work, I will try to point out further problem in new issues.

Thank you, again


Normalize URLs in OidcServiceWorker.js

Issue and Steps to Reproduce
Currently URLs in comparisons are not normalized, which can cause certains calls to fail; e.g.
url === oidcServerConfiguration.tokenEndpoint

this will return false if one URL contains a port and the other does not (some IDPs include a port).
I can create a merge request if needed; we could use a package normalize-url to solve it, or implement only a subset of the rules.
Versions
<EMAIL_ADDRESS>

Hi @meesvandongen , thank you very much for your issue.
Do you have a full sample of rigth and l'est equality side?
It would be a please to accept your pullrequest.
I would like to not include package dependency. I prefer to add clean unit test and resolve your case.
I am trying to remove all depency at all for many reason (security are part of).

An example would be https://idp.com/token === https://idp.com:443/token

@guillaume-chervet perhaps this can be reopened. I mistakenly thought this was the only place where such a check was made, but that is not correct. It is also made in getCurrentDatabasesTokenEndpoint and perhaps other places. I still believe it is a good idea to normalize the URL: the URLs received by the fetch event listener are also not exactly equal to the URLs provided to a fetch request:

with the following code:
_self.addEventListener("fetch", handleFetch);
const handleFetch = async (event) => {
  const originalRequest = event.request;
  const url = originalRequest.url;
  console.log(url);

Anyway, if we want to proceed with this it must be decided where the URLs should be normalized; I would suggest as early as possible, so right after handleFetch, as well as right after obtaining the values from the openid configuration endpoint. But, the openid configuration is retrieved in the client package, so that would result in potential code duplication. Other possibility is right before the configuration is saved to a variable in the service worker; then the client package will not have to change, but there may be potential differences in behaviour between the two modes. What do you think?

hi @meesvandongen , do a proposition with a code PullRequest.
I'am lacking of time. I prefer something not perfect that work than nothing :)

Thank you so much to make some feedback and help!


Cybersecurity 4.9 ROT13 #3649

Cybersecurity 4.9 ROT13 done by prithwish #3649

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #3649

Type of change 📝

[X] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)

Domain of Contribution 📊

[X] Cyber Security

Checklist ✅

[X] I follow Contributing Guidelines & Code of conduct of this project.
[X] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.
[X] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Great Work! @prithwishpramanik

Thank you😊


Should emit diagnostics using shared reference of compilation

Some stages in plugin, it can only access shared reference of compilation, but we need mutable ref to push diagnostics

Which test blocked by this?

configCases/css/conflicting-order should emit warnings

bump

We can return diagnostics and make caller to handle diagnostics


feat(tekton): tekton pipeline run list sort

Tracks : https://github.com/janus-idp/backstage-plugins/issues/237
Screenshots:

Pipeline Run List with data

Empty state (will show warning if unable to fetch resource else just empty state)

do we disable the dropdown if there's only one cluster ?

do we disable the dropdown if there's only one cluster ?

we have similar experience in topology as well, we can take it up as a separate PR

Are we not showing the "Pipeline Runs" heading anymore when the list is not empty ?

verified the changes locally.
LGTM !


problems when using workon inside .env file

Upon changing directory to the project's root where the .env lives, the file is sourced and seem to work fine, but when changing to directories inside the project, autoenv_cd dir will not work (no error messages) while builtin cd dir works normally.

What does work is to call like this:
source ~/.virtualenvs/$PROJECT_NAME/bin/activate

workon should behave properly, but that is also a perfectly acceptable solution.

Agreed.


Break down to modules

There must be separated modules for core, io, math, logic, and text.
Name of the core modules must be io.github.kerelape.reikai (without core).

There must be separated modules for core, io, math, logic, and text.

What does it mean?

There must be separated modules for core, io, math, logic, and text.

What does it mean?

Different artifacts for each module

There must be separated modules for core, io, math, logic, and text.
Different artifacts for each module

How it can be done? I am not so familiar with Java/Kotlin, Maven, and its artifacts system. Can you explain?

@Masynchin you can see this repository, it uses the system

@Masynchin well, I think this can wait


typescript always has a alert

VSCode Version: Code 1.9.0 (27240e71ef390bf2d66307e677c2a333cebf75af, 2017-02-02T08:31:00.827Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.0.18

project-manager
alefragnani
0.13.2

jquerysnippets
donjayamanne
0.0.1

vscode-html-css
ecmel
0.0.33

autofilename
JerryHong
0.1.3

vscode-simple-icons
LaurentTreguier
0.9.0

vscode-JS-CSS-HTML-formatter
lonefy
0.2.2

filenamecomplete
qinjia
0.0.3

sass-indented
robinbentley
1.3.0

jsx
TwentyChung
0.0.1

JavaScriptSnippets
xabikos
1.2.0

Steps to Reproduce:
1.when i create a new js file ,this alert shows,like this

I tied to find the problem in my settings,  I found the setting as default;

// 指定包含要使用的 tsserver 和 lib*.d.ts 文件的文件夹路径。
"typescript.tsdk": null,
"typescript.check.tscVersion": true
I think the problem is caused here ,i change the  value of "typescript.check.tscVersion" as false, but
it still check,so  I want to change the value of  "typescript.tsdk", but  I cant get the correct value。

@Moriarty02 do you work against a network share?

No,this problem makes me unable to write code with vscode,thanks

@Moriarty02 are you working on a folder that is on a Sharepoint drive maybe?

@bpasero  no,I close my project and find some  js files to open with vscode, it still alert

@Moriarty02 ok thanks, any chance you could translate the alert into english and post it here? or can you switch to english locale quickly and post another screenshot?

the alert is ：
Path “D:\software\Microsoft VS Code\resources\app\extensions\typescript\node_modules\typescript\lib ” does not point to a valid tsserver installation and will disable the typescript language function，
the second alert is ：
In the past 5 minutes, the typescript service has been unexpectedly interrupted for the last 5 times, consider enabling the bug report

@bpasero  I tried to  disable all extentions,but no use

Thanks

Thanks @Moriarty02. From the symptoms, this looks like a duplicate of #19814. In that case, some antivirus program was deleting VSCode's TypeScript server files. Reinstalling VSCode should fix this.
If you see this again, please add the typescript path mentioned in the error message to the exemption list for the antivirus program. You can also bring your own version of TypeScript: https://code.visualstudio.com/Docs/languages/typescript#_using-newer-typescript-versions


[demoing-storybook] webpackFinal is not working

Hi team, I just tested the latest demoing-storybook and it seems that webpackFinal option from storybook's official documentation  is not working at all.
I have checked the discussion threads and noticed that the storybook here is like a mixed version with original storybook and es-dev-server, so I am not sure whether it's related or not. Any information is helpful here, thanks.
// .storybook/main.js
console.log('you can get log here')

module.exports = {
  stories: ['../stories/*.stories.{js,mdx}'],

  // Addons to be loaded, note that you need to import
  // them from storybook-prebuilt
  addons: [
    'storybook-prebuilt/addon-actions/register.js',
    'storybook-prebuilt/addon-knobs/register.js',
    'storybook-prebuilt/addon-a11y/register.js',
    'storybook-prebuilt/addon-docs/register.js',
    'storybook-prebuilt/addon-viewport/register.js',
  ],

  webpackFinal: (config) => {
    console.log('this function wont be executed, so no log here');
    return config;
  },

  // Configuration for es-dev-server (start-storybook only)
  esDevServer: {
    nodeResolve: true,
    open: true,
  },
};

ref: https://github.com/open-wc/open-wc/issues/1374

yes indeed the @open-wc/storybook version uses storybook-prebuilt and there is actually no webpack involved at all anymore 😬
therefore any webpack specific options are not going to work 😅

oh i see ... so thanks for the info @daKmoR . If I really wanna do so, it means that maybe I need to fork it and use the storybook (not the prebuilt one) by myself, right. Any hint is appreciated 🙇

if you wanna use webpack I would go directly with @storybook/web-components

ok i see, thanks for the information :) Feel free to close this thread if you want :)

thx 🤗


API Codegen failure

Populating a simple model (following the tutorial with different contents) when I attempt to Generate API Code I get the following exception:
java.lang.NullPointerException
at com.iawg.ecoa.xmlprocessor.XMLProc0Types.processTypeFile(XMLProc0Types.java:122)
at com.iawg.ecoa.xmlprocessor.XMLProc0Types.updateSystemModel(XMLProc0Types.java:263)
at com.iawg.ecoa.SystemModelManager.processTypes(SystemModelManager.java:412)
at com.iawg.ecoa.SystemModelManager.processFiles(SystemModelManager.java:287)
at com.iawg.ecoa.ECOA_System_Model.(ECOA_System_Model.java:59)
at com.iawg.ecoa.ECOA_API_Code_Gen.(ECOA_API_Code_Gen.java:62)
at tech.ecoa.osets.eclipse.plugin.common.GenerateAPIAction.run(GenerateAPIAction.java:64)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:473)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:565)
at org.eclipse.jface.action.ActionContributionItem.lambda$4(ActionContributionItem.java:397)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4118)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3931)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3534)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1170)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1059)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:667)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:597)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:656)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:592)
at org.eclipse.equinox.launcher.Main.run(Main.java:1498)
The only types file is:

Not sure what github is doing with the text. If I click edit I can see the whole message. Odd.
ANyhow the rest is:

So the file that you attached worked perfectly for me, but I decided to investigte a bit further.
I introduced an error into the file (changed type to "booleadn8") and re-generated code by right clicking on blank initial assembly file. The code still generated OK, which is odd!
If I exit and restart eclipse and then try generating the code, I get the error you originally posted, which incidentally is caused by the code generator incorrectly detecting when the XML is invalid. What actually happens is that a null object is passed along to the next stage and it falls over with the original error.
So that's the first problem, which I think requires a bit more sorting out of the error philosophy...so I haven't got a fix for this at present.
The other problem, where it is not 'updating' the model I think confirms the theory I had a while ago that the implementation of the XML processor is using 'static' lists in certain parts. What this means is that the plugin maintains the previous version in memory, even when you have changed the XML provided. This can be VERY confusing if you don't realise it is happening.
Removal of the 'static' from the lists in the XML processor files and regenerating the plugin fixes this. My fork of the repository includes this fix now: https://github.com/ECOA-developer/Open_Source_ECOA_Toolset_AS5. A pre-built plugin in a zip file is attached - had to rename it from zip to txt to get it to upload though.
osets-plugin.txt

Just a follow up on the error reporting. It seems that if you run the plugin in debug from another eclipse instance, then you get the exception reported from the eclipse running the plugin (as you observed), but you also get the following from the 'main' eclipse instance:
12:32:27.834 [main] INFO  com.iawg.ecoa.SystemModelManager - WARNING - config file not found using default tool config and searching directories...
12:32:27.834 [main] INFO  com.iawg.ecoa.SystemModelManager - INFO - using default output directory of D:\runtime-EclipseApplication\jps\target\Steps\output
12:32:27.834 [main] INFO  com.iawg.ecoa.SystemModelManager -
12:32:27.834 [main] INFO  com.iawg.ecoa.SystemModelManager - Starting parse of types file Test.types.xml...
12:32:27.897 [main] INFO  com.iawg.ecoa.xmlprocessor.XMLFileProcessor - There have been no validation errors...
12:32:27.897 [main] INFO  com.iawg.ecoa.xmlprocessor.ECOAFile - Namespace for this types file is "Test"...
12:32:27.897 [main] INFO  com.iawg.ecoa.xmlprocessor.XMLProc0Types - ERROR: Type: booleadn8 Not Found.
12:32:27.897 [main] INFO  com.iawg.ecoa.xmlprocessor.XMLProc0Types - ERROR: Referenced Type: booleadn8 Not Found.
So it appears that the error reporting is in there, but just not being output to the correct place, so all you see is the null pointer exception.
Needs some looking at to sort out how to fix it.

I use your updated plugin,but still get this error when generating UID and platform code:
java.lang.NullPointerException
at com.iawg.ecoa.xmlprocessor.XMLProc5cDeployment.updateSystemModel(XMLProc5cDeployment.java:104)
at com.iawg.ecoa.SystemModelManager.processDeployment(SystemModelManager.java:280)
at com.iawg.ecoa.SystemModelManager.processFiles(SystemModelManager.java:300)
at com.iawg.ecoa.ECOA_System_Model.(ECOA_System_Model.java:59)
at com.iawg.ecoa.ECOA_UID_Gen.(ECOA_UID_Gen.java:44)
at tech.ecoa.osets.eclipse.plugin.common.GenerateUIDAction.run(GenerateUIDAction.java:63)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:473)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:565)
at org.eclipse.jface.action.ActionContributionItem.lambda$4(ActionContributionItem.java:397)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
so, it seems to be the problem about "updateSystem Model" still exists.
anybody active in this project?


Compressed vs. uncompressed

Would it be possible to have access to private key uncompressed in wallet?

Hey,
Sorry for not replying to this suggestion sooner, I've been pretty busy at work, had my computer fail on me and then xmas.
Your address provided on screen when you log-in to the wallet section of coinb.in (http://coinb.in/#wallet) is a compressed address, there is no use to having a uncompressed key when the uncompressed address is not shown.
If you could explain why you think we need this feature im all ears, otherwise I don't see a point in adding it....

what I meant was base58 wallet import format (so that the private key can we swept easily)

If you want access to your private key on the wallet page, https://coinb.in/#wallet you much click the "keys" button below your address and qrcode. You will then see your key in a WIF format, and below it an encrypted WIF.
Hope this helps.


[Docs][Coding Guide] Add coding guide

Purpose of this pull request
close #2994

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

How about adding some module introductions, our current modules may take some time for new contributors to understand

#3004


is there any api to create smtp user? [Looking for help]

Hello, I started using postal recently. I found API in postal but they are not for creating SMTP Credentials.
Is there any way I can create SMTP credential through API? or what command should I run to create a SMTP user?
How can I create SMTP user without user interface

Is there any command by which executing I can create smtp credential?

Credentials can only be managed in the web UI.

I mean, script also execute some command? :/

This is the only way to add an SMTP credential

Okay thank you.


Sentry – LivesessionError: Cannot read properties of null (reading 'getAttribute')

Hello,
I'm catching this error in sentry:
LivesessionError: Cannot read properties of null (reading 'getAttribute').
Presumably the problem is in some extension for chrome.
Have you come across one of these?
Is there any way to fix it on our side or yours.
Or is the only option is to ignore it?
"@livesession/sdk": "^1.1.4"

Hi @aleksandr-shevchenko-0 thank you for reaching out us.
Do you know if this issue crash your app? If you have more details (e.g list of sessions where this happened) please contact with us via Intercom or an email<EMAIL_ADDRESS>to give us more information.
While a fix for that can be easy it's better to know if it cause more problem, more than error logs on Sentry.
Best,

Hi @zdunecki
Any news?

@aleksandr-shevchenko-0
Let's in touch on email.

@aleksandr-shevchenko-0
I'm going to close this issue. If you still have problems, just get back to us.
Best


Testing GitHub Issues Features

Github Issue Basics

[x] Create an issue
[x] Create this task list in initial comment of issue
[ ] Convert the following two tasks into issues:

[ ] #3
[ ] #6

[ ] #7

Github Flavored Markdown in Issue Comments

[ ] Paste a screenshot into a comment
[ ] Reference lines of code with a canonical URL
[ ] Add a fenced R code block
[ ] Mention a Github user on your team
[ ] Use emoji in a comment

Reference Issues

[ ] Mention in issue comment another issue that is in the same repo
[ ] Mention in issue comment another issue that is in a different repo
[ ] Mention in git commit message an issue in the same repo

This is another comment :)


useGaia hook causes a catastrophic app error if your network is disconnected upon page load

The useGaia hook causes a catastrophic app error if your network is disconnected upon page load:
TypeError: Failed to fetch```

I've implemented a simple illustration of the error using the example app:

https://github.com/aviculturist/micro-stacks-examples/commit/361583be1d09729ed2c7719214ae60998ec81b62

To trigger the error, unplug your network prior to loading the app.

I don't know how to use useGaia. The example crashes even with network.


LRS to ZRS Live Migration not supported if SMB Multichannel enabled?

Recently learned that SMB-multichannel can't be enabled when migrating LRS to ZRS via Live Migration.
Can we add this to the documentation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66ebb48e-c896-a747-bc42-aa203978a1cd
Version Independent ID: 6e7bfefb-e67c-b5d5-89f7-6f1b6a2e8b61
Content: Change how a storage account is replicated - Azure Storage
Content Source: articles/storage/common/redundancy-migration.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@jsimsmsft
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@tamram
Can you please check and add your comments on this doc update request as applicable.

#reassign: @jimmart-dev

Thank you for your dedication to our documentation.
We sincerely apologize for the delayed response. After a careful review, we are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close

Thanks for your dedication to our documentation.
We sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary due to various constraints. Therefore, we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close


Add support for Google Chromebooks

Some ARM Chromebooks support running Debian and the Pixel desktop of RPi OS.
This commit adds support for them

Please release a new version after merging, so that it would reach the users.

How about now?

Looks good, thanks!


Just FYI (Facets)

Facets Enumerable#mash or #graph.
http://rubyworks.github.com/facets/doc/api/core/Enumerable.html#method-i-graph
"mash" stands for map-hash, whereas "graph" is the original name I used when I first wrote it.
Feel free to contribute improvements / make suggestions.

On Sat, Jun 11, 2011 at 12:04 AM, ronen
<EMAIL_ADDRESS>wrote:

oh, didn't know about that. nice, but subtly different semantics -- #mash can return an arbitrary hash, whereas #hashify does the specific case of a hash whose keys are the enumerable's elements.
if you think #hashify would be a good addition to Facets, i'd be happy to fork Facets and put it in,

Just to let you know that I added the method.


I cant build it

Sorry for the late response.
This error is caused by missing dependencies, one of which is atom_core. This project uses nix package manager to manage dependencies. However it is not available on windows. You can use WSL (Windows Subsystem for Linux) or manually provide dependencies) on windows.
The build process for different environments will be specified in the documentation. However, I'm running tight on time this month, so I might not be able to do it right away.
Also I might switch to docker instead of nix in the future to support windows as well.

Ahh okay, thanks for the reply! I kind of figured that itd for linux, but i really wanted to take a look in the engine, looks very interesting!

Sure, I'll message here once the documentation is up or I implement docker.


Add Los Rios Community College

@skytto This domain is blacklisted because the college allows to register an email address there even if you are not a student of the college. If you are the student of this college, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


[swiper] Current match invisible

First of all let me thank you for this awesome theme!

It looks like the two faces colliding here are swiper-line-face which inherits from highlight and swiper-match-face-2 inheriting from isearch. Personally I think it makes more sense to change swiper-line-face to something darker but I don’t have any strong opinion here or a good suggestion on which face would make sense.

Whoops! I agree, that's definitely an oversight. I'll experiment a little and push something up in a couple minutes.

Just pushed a fix for this; I darkened swiper-line-face and customized each of the ivy+swiper faces to fit in better with doom-one as a whole. Let me know if you find another conflict!

Thanks!


Update ShellCheck download URL in Dockerfile

see koalaman/shellcheck#1871

FYI, the failed CI jobs aren't related to the changes here.


Bridge Reconnect during set_value is faing

I'm updating the ISY nodeserver written by @timekillerj and referencing your dev branch for testing.  It all works great until it needs to reconnect to the bridge.  The call below is executing:
 return self.controller.mainloop.run_until_complete(self.sb.set_value(device, value))
But fails with BridgeDisconnectedError even though it says reconnect is happening?   Is this a bug or am I doing something wrong?
2020-10-03 18:16:35,709 Controller polyinterface      INFO     LutronCasetaNodes:send_command: send_command result: None
2020-10-03 19:23:44,111 Controller polyinterface      INFO     LutronCasetaNodes:setClose: setClose: command {'address': 'device8', 'cmd': 'DOF', 'query': {}}
2020-10-03 19:23:44,111 Controller polyinterface      INFO     LutronCasetaNodes:send_command: Sending value to Smart Bridge for device 8: 0
2020-10-03 19:23:44,112 Controller polyinterface      INFO     LutronCasetaNodes:send_command: is_connected=True
2020-10-03 19:23:44,114 Controller pylutron_caseta.leap DEBUG    leap:request: sending b'{"CommuniqueType": "CreateRequest", "Header": {"ClientTag": "b45c573b-19d3-4bf9-8ffd-b84f6a816e22", "Url": "/zone/4/commandprocessor"}, "Body": {"Command": {"CommandType": "GoToLevel", "Parameter": [{"Type": "Level", "Value": 0}]}}}'
2020-10-03 19:23:44,116 Controller pylutron_caseta.leap DEBUG    leap:request: sending b'{"CommuniqueType": "ReadRequest", "Header": {"ClientTag": "600479c8-72e6-4990-9edf-b39cee083173", "Url": "/server/1/status/ping"}}'
2020-10-03 19:23:44,117 Controller pylutron_caseta.smartbridge WARNING  smartbridge:_monitor_once: LEAP session ended. Reconnecting...
2020-10-03 19:23:46,120 Controller pylutron_caseta.smartbridge DEBUG    smartbridge:_monitor_once: Connecting to Smart Bridge via SSL
2020-10-03 19:23:46,127 Controller polyinterface      ERROR    polyinterface:_parseInput: _parseInput: failed device8.runCmd(DOF) name 'pylutron_caseta' is not defined
Traceback (most recent call last):
  File "/home/pi/development/udi-poly-lutroncaseta/lutron_caseta_nodes/LutronCasetaNodes.py", line 30, in set_value
    return self.controller.mainloop.run_until_complete(self.sb.set_value(device, value))
  File "/usr/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
    return future.result()
  File "/home/pi/development/udi-poly-lutroncaseta/pylutron_caseta/smartbridge.py", line 282, in set_value
    "Parameter": [{"Type": "Level", "Value": value}],
  File "/home/pi/development/udi-poly-lutroncaseta/pylutron_caseta/smartbridge.py", line 235, in _request
    timeout=REQUEST_TIMEOUT,
  File "/usr/lib/python3.7/asyncio/tasks.py", line 416, in wait_for
    return fut.result()
  File "/home/pi/development/udi-poly-lutroncaseta/pylutron_caseta/leap.py", line 60, in request
    return await future
pylutron_caseta.BridgeDisconnectedError

You should get a BridgeDisconnectedError if your request is in flight when the connection is lost because there is no way to know whether the command reached the bridge.
Also, with the current implementation I think you will get a BridgeDisconnectedError if you try to send new commands before the bridge has reconnected. Maybe requests starting while a connect is in progress could wait for a new connection to be established, but the time to successfully establish a connection is usually so short it shouldn't matter unless somebody wants to retry a failed command ASAP.

Thanks, so it is failing when I call set_value, should I just retry again when I get the BridgeDisconnectedError?

Do you know why you're needing to reconnect? I think I need to reconnect less than once a week.

No I have no idea, nothing shows before that in the log. I had worked on adding more debugging to your code a while back, but could never figure out why. From what I remember, it seems the ping was not working? But I could be thinking about something else all together.

I see run_until_complete(self.sb.set_value(device, value)) in the traceback. Are you maybe only running the event loop for milliseconds at a time when you are interacting with the bridge? The event loop periodically wakes up and sends a ping to the bridge to keep the TCP connection alive and detect if the bridge is still there (sometimes the bridge reboots itself for updates). If the event loop is only running intermittently, the bridge may be dropping the connection, or pylutron_caseta may be interpreting the lapses in execution as ping timeouts and dropping the connection itself, or maybe even the receive buffer is filling up because the event loop is also necessary for processing messages sent from the bridge.
pylutron_caseta does not require it's own dedicated thread, but if you're not already using asyncio you will need a thread to run the event loop.
Alternatively, if you don't care about the bridge pushing status updates, you could disconnect from the bridge between requests. Every time you wanted to interact with the bridge you would need to connect first.

Yes, I run the bridge in it's own thread
    async def _bridge_connect(self):
        self.sb = Smartbridge.create_tls(hostname=self.lutron_bridge_ip,
                                         keyfile='./caseta.key',
                                         certfile='./caseta.crt',
                                         ca_certs='caseta-bridge.crt',
                                         )
        await self.sb.connect()
        if self.sb.is_connected():
            LOGGER.info("Successfully connected to bridge!")
        else:
            LOGGER.error("Could not connect to bridge")
        self.connecting = False

    def _bridge_start(self):
        try:
            mainloop.run_until_complete(self._bridge_connect())
        except:
            LOGGER.error("Bridge connect failed")

    def bridge_connect(self):
        self.connecting = True
        self.connect_thread = Thread(target=self.__bridge_start)
        self.connect_thread.start()

Is anything logged when the ping runs?  I expected to see something but I never do.

If you have the debug logging enabled you should be seeing the ping messages being sent.
Your thread only runs as long as the bridge takes to connect. You probably want to do something like this instead:
    async def _bridge_connect(self):
        self.sb = Smartbridge.create_tls(hostname=self.lutron_bridge_ip,
                                         keyfile='./caseta.key',
                                         certfile='./caseta.crt',
                                         ca_certs='caseta-bridge.crt',
                                         )
        await self.sb.connect()
        if self.sb.is_connected():
            LOGGER.info("Successfully connected to bridge!")
        else:
            LOGGER.error("Could not connect to bridge")
        self.connecting = False

    def bridge_connect(self):
        self.connecting = True
        self.connect_thread = Thread(target=mainloop.run_forever)
        self.connect_thread.start()
        mainloop.call_soon_threadsafe(_bridge_connect)

call_soon_threadsafe will let you enqueue work to the event loop from outside. This code doesn't deal with cleaning up the thread, so if you call bridge_connect multiple times you'll get multiple threads.

Thank you!  I tried real quick and get
2020-10-04 14:34:22,527 Thread-1   py.warnings        WARNING  warnings:_showwarnmsg: /usr/lib/python3.7/asyncio/events.py:88: RuntimeWarning: coroutine 'LutronCasetaController._bridge_connect' was never awaited
I'm leaving now but will look again when I return.

Hmm https://docs.python.org/3/library/asyncio-dev.html#concurrency-and-multithreading says it should be asyncio.run_coroutine_threadsafe(self._bridge_connect(), mainloop) instead of mainloop.call_soon_threadsafe(_bridge_connect).

That works perfectly!  Thank you very much.  I use that to change the settings as well which work great
        result = asyncio.run_coroutine_threadsafe(self.sb.set_value(device, value), self.controller.mainloop)
And now when I open and close from the app I get the callback's right away.  Very cool.


Some QA prompts do not join the documents

While deepset/question-answering performs a documents join in the prompt:
https://github.com/deepset-ai/prompthub/blob/7af13102ae10a72b190664f3bde6b018f0499eec/prompts/deepset-question-answering.yaml#L3
some other QA prompts do not.

deepset/question-answering-check: https://github.com/deepset-ai/prompthub/blob/7af13102ae10a72b190664f3bde6b018f0499eec/prompts/deepset-question-answering-check.yaml#L4
deepset/question-answering-with-document-scores: https://github.com/deepset-ai/prompthub/blob/7af13102ae10a72b190664f3bde6b018f0499eec/prompts/deepset-question-answering-with-document-scores.yaml#L6

Is this by design?

Hey @ZanSara, after some experiments, I can say that this difference is by design.
In fact, for deepset/question-answering, it makes sense to consider the entire joined text to generate an answer.
Other prompts need to consider different documents separately.
Let's see for example deepset/question-answering-check: it checks whether each Document contains the answer to the question.
from haystack.nodes import PromptNode
from haystack import Document

docs = [Document("Rome is the capital of Italy."), Document("Berlin is the capital of Germany.")]
pn = PromptNode()
print(pn.prompt(prompt_template="deepset/question-answering-check",
                query="What is the capital of Italy?", documents=docs))
# ['yes', 'no']

I am closing this issue. Feel free to reopen it if something is unclear.


Fuse --strong into --preview-dart-2 option.

This patch had a very regressive impact on a wide number of benchmarks, notably dart2 aot snapshot size,  and release size. It also caused the dart2 ios benchmarks to stop reporting.

We are investigating why the iOS benchmarks have stopped reporting, the benchmarks seem to run locally


Signal should be replace with Reactive

Signal name is used in different web frameworks so Javascript should choose a different name. Like Promise is a separate name , reactive Behavior should also have a separate name: Reactive

Hm, I really think this issue would be better contributed to https://github.com/tc39/proposal-signals/issues/148, in which your proposed alternative is already mentioned. Let's try to keep the conversations tidy!


photon compatibility

Environment

Operating System: Darwin
Node Version:     v21.6.2
Nitro Version:    2.9.1
Package Manager<EMAIL_ADDRESS>
Reproduction
N/A
Describe the bug
If a wasm contains imports from relative path, the module name will have foreign unintended characters.
For context, photon-rs has some imports from relative path, and using it causes the following error:
(inject plugin) rollup-plugin-inject: failed to parse ~/Developer/play/nitro-wasm/routes/wasm/photon_rs_bg.wasm. Consider restricting the plugin to particular files via options.include
routes/wasm/photon_rs_bg.wasm (6:2) Error when using sourcemap for reporting an error: Can't resolve original location of error.

[nitro 6:22:17 PM]  ERROR  RollupError: Unexpected token .. Expected identifier, string literal, numeric literal or [ for the computed key (Note that you need plugins to import files that are not JavaScript)

4: import { base64ToUint8Array } from "unwasm:helpers";
5: const _imports = {
6:   ./photon_rs_bg.js: {
     ^
7:     __wbindgen_object_drop_ref: () => { throw new Error("./photon_rs_bg.js.__wbindgen_object_drop_ref is not provid...

This issue is resolved when moduleName is json-stringified at L180 in https://github.com/unjs/unwasm/blob/67a94a9d4f203db9a9864fcb0b8c2d0912c575c1/src/plugin/runtime.ts#L180-L186
Additional context
No response
Logs
No response

There are probably easier ways to include a repro, but I ran in to the same problem with Prismas new database adapters.
Here's a repro-link codesandbox.io.
If you try yourself with prisma, it does require you to have generated the prisma client before building:
node_modules/.bin/prisma generate

I'm not able to reproduce this at  the moment; but @Zn4rK 's reproduction aligns with the issue I had

I will be able to provide a repro for photon by Sunday, as it happened on my work pc; And i couldn't make it happen again on my personal one.
The issue so far is that key in imports object should have been enclosed by quotes.

Repro: mukundshah/nitro-wasm#photon


Move metadata package in carbon-core

There are two metadata packages in carbon-core module, this PR merge them.

retest this please


fixed scratchGDB problems and Jenkins run issue

Fixed issues where scratch GDB was going to testdata folder.
Also changed test to run on Jenkins
Description
Made changes to test cases to check if scratchGDB exited in utils/tests, and create one there if not.
TestKickStart.bat now runs 'python' instead of 'py'.
Related Issue
N/A
Motivation and Context
scratch data was created in wrong place and never removed.
Tests were not being run on Jenkins.
How Has This Been Tested?
Cannot test Jenkins fix until integrated into dev branch.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

@ACueva Just an FYI that this one is still waiting.... 😈

@mfunk Merging!

Showing Avi how to merge a commit. ;)


Pub Revision

This PR contains the code for this repo as it will be shared in our upcoming pub.
It would be great to get feedback on:

What code needs to be revised to get this to MVP status
How much more documentation we need to make this mostly reproducible
How to present this work in alignment with the Icebox and Software team narratives
Anything else you think is important to go over!

I'm hoping to make this repo public after we merge this PR so that I can start tinkering with Binder, which requires the repo to be public.

@mezarque ugh ReviewNB doesn't post my comments. I'll try to post via GitHub brb


Tasks: Run Task taking indeterminate number of seconds to appear in UI

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70/1.71
OS Version: Ubuntu 18.04

Steps to Reproduce:

Ctrl+Shift+P -> Tasks: Run Task
The UI popup with my Workspace Tasks fails to show up. Sometimes it shows up after a few seconds, other times it just doesn't show up. If I do it repeatedly sometimes it'll then pop multiple times.

Unclear what log I even need to be looking at to see any errors about this. Disabling extensions had no effect however it appears when I don't use my remote SSH workspace I don't see this issue.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.72.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Fixed in insiders


Envoy crashes on any non-empty MULTI transaction when proxying Redis Cluster

Title: Envoy crashes on any non-empty MULTI pipeline when proxying Redis Cluster
Description:
When envoy is configured to talk to an upstream Redis cluster, any MULTI-EXEC transaction causes it to segfault.
Repro steps:
Please refer to https://github.com/untitaker/envoy-redis-pipeline-segfault for exact configuration.

have a redis cluster
tell envoy to proxy that redis cluster
send MULTI\n<anything>\nEXEC\n via netcat (or use a normal redis client to create a transaction), and watch envoy segfault after EXEC

Since the crash is reproducible in a clean test environment, I am not attaching admin/stats output.
Config:
toggle
admin:
  access_log_path: /tmp/admin_access.log
  address:
    socket_address:
      protocol: TCP
      address: <IP_ADDRESS>
      port_value: 1936
static_resources:
  listeners:
  - name: listener_0
    address:
      socket_address:
        protocol: TCP
        address: <IP_ADDRESS>
        port_value: 6379
    filter_chains:
    - filters:
      - name: envoy.filters.network.redis_proxy
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.redis_proxy.v3.RedisProxy
          stat_prefix: redis_proxy
          settings:
            op_timeout: 1s
            enable_redirection: true
          prefix_routes:
            catch_all_route:
              cluster: redis_cluster
              #request_mirror_policy:
                #cluster: redis_cluster
                #exclude_read_commands: true
  clusters:
  - name: standalone_redis
    connect_timeout: 3s
    type: STRICT_DNS
    dns_lookup_family: V4_ONLY
    load_assignment:
      cluster_name: standalone_redis
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: host.docker.internal
                port_value: 6379
  - name: redis_cluster
    connect_timeout: 3s
    cluster_type:
      name: envoy.clusters.redis
    dns_lookup_family: V4_ONLY
    load_assignment:
      cluster_name: redis_cluster
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: host.docker.internal
                port_value: 6000

Logs + Call Stack:
toggle
[2022-10-25 12:41:43.179][21][critical][backtrace] [./source/server/backtrace.h:104] Caught Segmentation fault, suspect faulting address 0x5d5bf60a000
[2022-10-25 12:41:43.179][21][critical][backtrace] [./source/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers):
[2022-10-25 12:41:43.179][21][critical][backtrace] [./source/server/backtrace.h:92] Envoy version: 15baf56003f33a07e0ab44f82f75a660040db438/1.24.0/Clean/RELEASE/BoringSSL
[2022-10-25 12:41:43.179][21][critical][backtrace] [./source/server/backtrace.h:96] #0: __restore_rt [0x7f211ba84420]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #1: [0x5631a570cb54]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #2: [0x5631a570bbcb]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #3: [0x5631a5705577]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #4: [0x5631a57064ed]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #5: [0x5631a6f3f1e5]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #6: [0x5631a6f383e8]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #7: [0x5631a6f36282]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #8: [0x5631a6f2bb81]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #9: [0x5631a6f2cf4d]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #10: [0x5631a7042540]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #11: [0x5631a7040e81]
[2022-10-25 12:41:43.180][21][critical][backtrace] [./source/server/backtrace.h:98] #12: [0x5631a6761134]
[2022-10-25 12:41:43.181][21][critical][backtrace] [./source/server/backtrace.h:98] #13: [0x5631a722bfd3]
[2022-10-25 12:41:43.181][21][critical][backtrace] [./source/server/backtrace.h:96] #14: start_thread [0x7f211ba78609]
ConnectionImpl 0x5d5bf1bba80, connecting_: 0, bind_error_: 0, state(): Closed, read_buffer_limit_: 1048576
socket_:
  ListenSocketImpl 0x5d5bf0ddb00, transport_protocol_:
  connection_info_provider_:
    ConnectionInfoSetterImpl 0x5d5bf1bc698, remote_address_: <IP_ADDRESS>:7001, direct_remote_address_: <IP_ADDRESS>:7001, local_address_: <IP_ADDRESS>:48438, server_name_:
make: *** [envoy] Error 139

Additional Notes
There's mixed information on the internet as to whether Envoy supports transactions or not. It seems that transaction support was recently added via https://github.com/envoyproxy/envoy/issues/22162, but the docs don't mention this.
This was previously reported to envoy-security, and I was instructed to post it here (given reasoning: this crash is unlikely to be caused by untrusted input)

cc @asheryerm can you please take a look at this?

@untitaker @mattklein123
For the redis-cluster configuration it is important that you add the line
lb_policy: CLUSTER_PROVIDED to the envoy configuration, because this is one of the criteria that envoy uses to determine if this is a cluster:
  is_redis_cluster_ = info->lbType() == Upstream::LoadBalancerType::ClusterProvided &&
                      cluster_type.has_value() && cluster_type->name() == "envoy.clusters.redis";

If I add this line, everything works fine. Without this line I get this output:
$redis-cli -p 1998
<IP_ADDRESS>:1998> multi
OK
<IP_ADDRESS>:1998(TX)> get foo
(error) MOVED 12182 <IP_ADDRESS>:30003
<IP_ADDRESS>:1998(TX)> exec
(error) EXECABORT Transaction discarded because of previous errors.
<IP_ADDRESS>:1998>

So basically redirection of the first command doesn't take place and the transaction fails. I was not able to reproduce the segmentation fault.

@asheryerm noted the lb_policy, but I can reproduce the crash either way. the crash cannot be reproduced using redis-cli, the commands have to be pipelined (such as what the redis python library does, or the netcat command I provided)

@untitaker ok, got it. I can reproduce the crash with pipelining, I will check.

In fact it seems like the redis cluster doesn't even have to be running in order to repro

@untitaker I've reproduced the issue and opened a PR with a fix. The transaction client was closing prematurely which caused the segmentation fault. The fix is fairly simple. Thank you for bringing this issue to my attention.

So I think this is fixed by https://github.com/envoyproxy/envoy/pull/23710


Update RussellBanks.Komac.Nightly to v2.0.0

cc @russellbanks
Microsoft Reviewers: Open in CodeFlow

/rerun

/Re-run

/run


[portfolio] On retire form, show red ring around invalid fields

Would be helpful if @theprofessora can just do a quick example text input component somewhere in figma for us to reference
It could be a red ring, or a red text label, or red star...
Currently its not very clear which input is invalid

@0xMakka see professor's design system update above.
My understanding is that we should be able to apply this change to the component and then that will update this across all the forms in the app.
Please let me know if you need any additional requirements or clarifications?

@jabby09 Is this still a valid ticket? Just looking at the same fields that atmos posted and when an invalid address is entered I see a red border around the input field?

@0xMakka yes agreed, seems resolved on RETIRE and BUY forms for pool projects from project details.
However, take a look at the RETIRE form from Portfolio...looks like we need to apply the same logic still on this form.

@0xMakka yes agreed, seems resolved on RETIRE and BUY forms for pool projects from project details.
However, take a look at the RETIRE form from Portfolio...looks like we need to apply the same logic still on this form.

Thanks for this @jabby09, will get working on adding to this form.


Javascript Group Project

Opened an Issue regarding the Javascript Group Project. I should be a team of two people but my partner this week let me know he was going to face some hardware difficulties that prevent him from working. Suggesting I'd look for another partner. For the time being, I would be solo, in theory.

Hi @Arch-Noize 👋,
You're doing a good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

Correct Kanban template is used ✔
All task cards exist ✔

Required Changes ♻

Until you get approval from student success regarding your team member you'll have to add them to the repo and assign each team member a card as shown below 👇

Also please make sure to assign all cards in a fair way ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
You can also consider:

N/A

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @Arch-Noize, @pushkar1995 & @mumbereh  👋,
Great work on making the changes requested by a previously 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights

All team members are assigned cards ✔
Correct Kanban template is used ✔
All task cards exist ✔

Required Changes ♻

I noticed the group tasks haven't been assigned to any team member as I mentioned previously please make sure to assign all cards to a team member.

Optional suggestions

N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi team,
Your project is complete!  There is nothing else to say other than... it's time to merge it 🥳
Congratulations! 🎉
Status: Approved✔
Highlights

All cards assigned to memebers
Good follow-up with the previous reviewers.

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Unify language codes in the i18n file names.

I think it would be better to use ISO language codes for all file names in emoji-picker-element/i18n/*.js so it would be easy to use with window.navigator.language. At this moment some of them has double ISO name like pt_BR, some not like: pl, en, etc.

Yeah this is a historical result of which languages folks decided to add translations for. And some of the translators decided to specify e.g. Brazilian Portuguese rather than just Portuguese. (I'm not an expert on Portuguese, so I deferred to the translator's judgment.)
There is also some trickiness with "languages" with vastly different writing systems or vocabulary. Like we have zh_CN but if we had traditional Chinese or Cantonese it would probably look very different.

BTW this would be a breaking change.

BTW this would be a breaking change. Assuming what you're asking for is for all the language codes to just be the two-letter version and not the double ISO names?

I think double ISO names are better. Broser variable window.navigator.language already contains double name (but with dash not underscore) this could be used directly to initialize language.

You should differentiate here between language and locale. An iso language code is a two letter code like "de", "en" and so on. A locale code consists of a language and a country (region). This is needed to distinguish between countries and languages. As example english is spoken in multiple countries. So as example we have en-GN and en-US. If you now want to display special units for number values, there might be different rules for US and GB. Therefore a locale is needed here. If you only want to translate things without applying special rules to numbers or dates, ..., the two character language code is enough. Regarding a underscore or hyphen in locale codes. Based on RFC 4646 the hyphen is the standard. But codes with underscore are also used frequently.


EES-577 Updated readme to point to Docker Hub

Image for the latest version is already in Docker Hub.

+1

:+1: