Add hooks and deprecate batch, put & del events

Adds postopen, prewrite and newsub hooks that allow userland "hook functions" to customize behavior of the database. See README for details. A quick example:
db.hooks.prewrite.add(function (op, batch) {
  if (op.type === 'put') {
    batch.add({
      type: 'put',
      key: op.value.foo,
      value: op.key,
      sublevel: fooIndex
    })
  }
})

More generally, this is a move towards "renewed modularity". Our ecosystem is old and many modules no longer work because they had no choice but to monkeypatch database methods, of which the signature has changed since then.
So in addition to hooks, this:

Introduces a new write event that is emitted on db.batch(), db.put() and db.del() and has richer data: userland options, encoded data, keyEncoding and valueEncoding. The batch, put and del events are now deprecated and will be removed in a future version. Related to Level/level#222.
Restores support of userland options on batch operations. In particular, to copy options in db.batch(ops, options) to ops, allowing for code like db.batch(ops, { ttl: 123 }) to apply a default userland ttl option to all ops.

No breaking changes, yet. Using hooks means opting-in to new behaviors (like the new write event) and disables some old behaviors (like the deprecated events). Later on we can make those the default behavior, regardless of whether hooks are used.
TODO:

[x] Benchmark
[x] Write tests
[x] Documentation for batch argument of prewrite hook function
[x] Canary-test memory-level
[x] Canary-test classic-level

Closes https://github.com/Level/community/issues/44.

Initial batch benchmarks (on memory-level) look good. If you're not using hooks or events, the hooks branch of abstract-level is faster than main. If you are using events, db.batch() with a write event listener is 3-4% slower than db.batch() with a batch event listener (on either branch). Which is fair; the write event has more data.

db.put() performance is good too (after a tweak that I've yet to push). The hooks branch is faster than the main branch if no events are used. As expected, it becomes slower when you use events or prehooks. In the table below, events.put=1 means the benchmark had one listener for the put event. Similarly, hooks.prewrite=1 means one prewrite hook function, and hooks.prewrite=100 means it did:
for (let i = 0; i < 100; i++) {
  db.hooks.prewrite.add(function () {})
}

benchmark put on<EMAIL_ADDRESS>win32 x64
<EMAIL_ADDRESS>n=1M concurrency=4 valueSize=100B keys=random values=random

1  memory-level#hooks                      36588 ops/s ±8.51%  fastest
2  memory-level#main                       35837 ops/s ±8.12%   +1.70%
3  memory-level#hooks  hooks.prewrite=1    35286 ops/s ±6.51%   +1.75%
4  memory-level#main   events.put=1        35508 ops/s ±7.47%   +2.01%
5  memory-level#hooks  events.write=1      34692 ops/s ±6.83%   +3.69%
6  memory-level#hooks  hooks.prewrite=100  34302 ops/s ±8.28%   +6.05%

In classic-level, adding a prewrite hook function has a bigger effect. Which is not a blocker for this PR but we may want to look into optimizing batches at some point.
$ level-bench plot put
benchmark put on<EMAIL_ADDRESS>win32 x64
<EMAIL_ADDRESS>n=1M concurrency=4 valueSize=100B keys=random values=random

1  classic-level#main                     30548 ops/s ±7.59%  fastest
2  classic-level#hooks                    30424 ops/s ±7.32%   +0.16%
3  classic-level#hooks  hooks.prewrite=1  28070 ops/s ±7.55%   +8.08%

There's one remaining issue to fix (or not). If you do:
const data = db.sublevel('data')
const users = data.sublevel('users')

data.on('write', function (ops) {
  const wrongKey = ops[0].key
})

data.batch().del('alice', { sublevel: users })

Then the wrongKey emitted by the data sublevel is !data!!users!alice rather than !users!alice. This is a result of how sublevels work in general and I don't yet have a solution.

I have a solution and a PoC implementation, but it'll hurt performance for nested sublevels. Given users = db.sublevel('data').sublevel('users'), instead of users forwarding its operations directly to db, it'll forward to the data sublevel which in turn forwards to db. I.e. users.batch([]) calls data.batch([]) which calls db.batch([]).
I have to benchmark that and see what tweaks can be made, but even if performance is significantly worse (and I think it will be) it might be worth it. Because it benefits both events and hooks: users.batch([]) would trigger the prewrite hook of users, then of data, then of db. Same for the write event. So, no matter what kind of database you have (sublevel or not, nested or not) it works the same. Which should benefit modularity.

@juliangruber @ralphtheninja any objections? The batch, put and del events are 10 years old, so I don't want to take removing them lightly.

I have to benchmark that

Results for db.put() on memory-level, comparing no sublevel, 1 sublevel (!foo!), 2 sublevels (!foo!!bar!) and more:

Click to expand
$ level-bench plot put
benchmark put on<EMAIL_ADDRESS>win32 x64
<EMAIL_ADDRESS>n=1M concurrency=4 valueSize=100B keys=random values=random

1   memory-level#hooks                             35781 ops/s ±7.11%  fastest
2   memory-level#main                              35794 ops/s ±8.69%   +1.43%
3   memory-level#hooks  !foo!                      30701 ops/s ±7.04%  +14.15%
4   memory-level#main   !foo!                      30183 ops/s ±5.55%  +14.40%
5   memory-level#main   !foo!!bar!                 29386 ops/s ±5.66%  +16.75%
6   memory-level#hooks  !foo!!bar!                 28865 ops/s ±5.07%  +17.76%
7   memory-level#main   !foo!!bar!!baz!            28813 ops/s ±5.46%  +18.22%
8   memory-level#main   !foo!!bar!!baz!!bam!       28720 ops/s ±5.48%  +18.49%
9   memory-level#main   !foo!!bar!!baz!!bam!!boo!  27970 ops/s ±5.96%  +20.98%
10  memory-level#hooks  !foo!!bar!!baz!            27796 ops/s ±5.59%  +21.20%
11  memory-level#hooks  !foo!!bar!!baz!!bam!       26067 ops/s ±6.95%  +27.04%
12  memory-level#hooks  !foo!!bar!!baz!!bam!!boo!  25255 ops/s ±5.33%  +28.22%

At a depth of 2 sublevels, the difference between main and hooks is negligible. But it gets progressively worse the deeper you go. That's partially explained by having to copy longer prefixes, but main has a more consistent performance between sublevel depths.
With support of db.sublevel(['foo', 'bar']) (marked by flat below) we can recover:

Click to expand
1   memory-level#hooks                                   35781 ops/s ±7.11%  fastest
2   memory-level#main                                    35794 ops/s ±8.69%   +1.43%
3   memory-level#hooks  !foo!                            30701 ops/s ±7.04%  +14.15%
4   memory-level#main   !foo!                            30183 ops/s ±5.55%  +14.40%
5   memory-level#main   !foo!!bar!                       29386 ops/s ±5.66%  +16.75%
6   memory-level#hooks  !foo!!bar!                       28865 ops/s ±5.07%  +17.76%
7   memory-level#main   !foo!!bar!!baz!                  28813 ops/s ±5.46%  +18.22%
8   memory-level#hooks  !foo!!bar!!baz!!bam!!boo!  flat  29008 ops/s ±6.28%  +18.30%
9   memory-level#main   !foo!!bar!!baz!!bam!             28720 ops/s ±5.48%  +18.49%
10  memory-level#main   !foo!!bar!!baz!!bam!!boo!        27970 ops/s ±5.96%  +20.98%
11  memory-level#hooks  !foo!!bar!!baz!                  27796 ops/s ±5.59%  +21.20%
12  memory-level#hooks  !foo!!bar!!baz!!bam!             26067 ops/s ±6.95%  +27.04%
13  memory-level#hooks  !foo!!bar!!baz!!bam!!boo!        25255 ops/s ±5.33%  +28.22%

Sorry @vweevers, I don't have time to review this ATM :|

OK! Thanks for letting me know. FWIW I'll probably mark the hooks API as experimental (before v2 goes out the door) so there will be room for changes.


[FEATURE REQUEST] copy job_submit.lua file if provided to slurm controller

Be able to deploy a custom, locally provided job_submit.lua file for slurm controller, which also needs to be configured in slurm.conf
Context
Since the job_submit.lua script can be heavily customized, it doesn't make sense to try to provide  it's own template within bluebanquise collection, but the file does need to be deployed within bluebanquise slurm role.
Recommend using ansible.builtin.template rather than copy on the off chance users are templating within their script.
Feature
In collections/hpc/roles/slurm/tasks/controller.yml
- name: Copy job_submit.lua file if indicated
  when: slurm_job_submit_lua_file
  ansible.builtin.template:
    src: "{{ slurm_job_submit_lua_file }}"
    dest: /etc/slurm/job_submit.lua
    owner: "{{ slurm_user_uid }}"
    group: "{{ slurm_user_gid }}"
    mode: "0444"

- name: Check JobSubmitPlugins contains lua for slurm.conf if intending to use the job_submit.lua file
  when: slurm_job_submit_lua_file
  ansible.builtin.assert:
    that: slurm_job_submit_plugins is search("lua")

In collections/hpc/roles/slurm/templates/slurm.conf.j2
{% if slurm_job_submit_plugins is defined and slurm_job_submit_plugins is not none %}
JobSubmitPlugins=slurm_job_submit_plugins
{% endif %}

Additional data

Dear @vedmonds
Thank you for this feature request :blush:
I will try to add this in the next PR pack, should be quick.

Dear @vedmonds
Here is the requested feature, does it match your needs ? :blush:
https://github.com/bluebanquise/bluebanquise/pull/937/commits/4a8b53508c02484d36cc5b685aeedab6ad02aedd

Yes thank you!

Thanks a lot for the feedback. PR is merged :blush:
Please reopen this issue if you encounter any issues.


feat(settings): Provide VSCode setting for the catalogUrl

Based on https://github.com/KaotoIO/vscode-kaoto/pull/596 from @apupier
Context
Add a ´catalogUrl´ setting to point to a specific kaoto catalog version
Note
In this PR we're updating the ´@kaoto/kaoto´ version to ´2.1.0-RC3´ so we can handle the case of an empty catalogUrl

Currently there is just kick-off test which set the custom catalog url using settings and then check the number of items is higher then 1 (because 1 item per each runtime should be the default value when no catalog is used)
TODO: in next iteration it would be nice to add test which will

set the catalog using  settings
pick some different version of catalog in katoto editor
and check that eg some components are now available


Todo's in addQuestion partial

ToDo :  Input form to take tags for question in addQuestion.html

ToDo : Padding and other styling to be added in addQuestion.html


Add EH console to tools

Integrate Olivier's tool in code base. it is very useful for diagnostics purposes, and possibly more. code is currently on 'ehconsole' branch, under 'EHConsole' directory.

Done at ehconsole branch.

Merged with master.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 89a6c26, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 13483 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in da9eab6 after 16 minutes.


Transport text log does not contain timestamps

Describe the bug
when following the documentation here
https://docs.microsoft.com/en-us/aspnet/signalr/overview/testing-and-debugging/enabling-signalr-tracing#enabling-tracing-in-the-net-client-windows-desktop-apps
enabling signalr Server side tracing does not produce a log file with timestamps, this makes troubleshooting issues difficult.
using Microsoft ASP.NET Core version <IP_ADDRESS>
enable client side tracing referenced above for net framework 4.6.1 asp.net web app in web.config
generate traffic
open transport.log and note that no entries contain timstamps
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '...'
Run this code '....'
With these arguments '....'
See error

Expected behavior
it is expected when looking at trace information that timestamps would be included

Moving this to SignalR/SignalR as this is an issue in ASP.NET SignalR.

This issue was moved to SignalR/SignalR#4359


Change flame graph ordering of frames from by-name to by-total

Description
Changes frame ordering from by-name to by-total in flame graphs.
Motivation and context
Usually when someone is using flame graphs, they are looking for performance problems. If there is a large number of frames, it is near impossible to visually make out the most expensive one. This orders them by total time, which is much easier to read.
How has this been tested?
I habe been using this for some time for profiling/debugging.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

One disadvantage of grouping by total is that it makes comparing two flame graphs side by side more difficult since minor differences in timing can result in big changes in the shape of the flame graphs.

@aalexand Ok, I can see your point, which tells me that it should probably be configurable. It's just changing one line based on config.

@exi Thank you for your proposal.
Indeed, there are reasons for by-total ordering, but there are reasons for alphabetic ordering as well. Which one is better is subjective. I personally find alphabetic order more convenient: it is stable and easier to read; classes from the same package and related methods come next to each other; frames of the same type are grouped together, logically splitting graph into flames of the same color, whereas a graph may look motley with by-total ordering. When searching for a pattern, alphabetic ordering is also preferable, since highlighted frames are often grouped close to each other rather than being scattered.
The mentioned problems are not relevant for the tree view. Note that the tree visualization already has child frames sorted by the number of samples.
From the technical perspective, the PR is incomplete, as it touches only built-in flame graph generator, but not the flame graph converter.
If you still wish to propose the feature (which I admit is useful in some cases), I suggest adding an option both in the flame graph generator and in the converter. Even better alternative would be to add a flame graph button that switches sort order of the already rendered frames. In this case, users can generate one flame graph and then switch frame order back and forth right in their browser.

@apangin i like the idea of the in-graph sorting! I'm not sure I'll have time for it in the coming days though since I already fixed the reason why i needed the profiler in the first place.
Would it be ok to report back in a couple of days to see if I can give it a shot?

Yes, absolutely!

Ping me pls to port it into #944 ) sounds really great)


knife ssh should support gssapi/kerberos

Would be nice if knife ssh supported GSSAPI/Kerberos based auth. Many organizations use Kerberos for authentication and they could use knife ssh + passwordless auth without having to push SSH keys around. The net-ssh-kerberos gem (https://github.com/cbeer/net-ssh-kerberos) adds GSSAPI support to net-ssh.

Agreed - we use kerberos and gssapi-with-mic would be a great alternative to have to distribute private keys to other team members.

I have a PoC of knife ssh working with net-ssh-kerberos. I need to get it properly integrated and I will send a PR.

Great - I'm happy to help as well. Let me know.

I was just working on the same thing this morning but randomly checked this issue to see if anyone had made progress.
@eheydrick I can help you test as well.

This is what I have so far. You'll need the net-ssh-krb gem installed and this patch to the ssh code:
https://gist.github.com/eheydrick/75185e22facb1f18feec
I made Kerberos an option because ssh fails when Kerberos fails i.e. if you don't have a valid TGT. It should probably fall back to trying other auth methods when that happens.

Why was this closed?  Has this been fixed?  As far as I can tell, knife ssh still doesn't support Kerberos auth.


Addition of Nickname Moderation CC

Please describe the changes this PR makes and why it should be merged:
I made a custom command on nickname moderation, more details on the CC itself can be seen in the comment at the beginning.
I would appreciate if it would be put into the repository.
Status

[x] Code changes have been tested on an instance of YAGPDB, or there are no code changes
[x] I have read and followed the contribution guide

By the way, this is the first pull request I have ever done, so apologies if something is wrong.

Hmm, you are never checking for arg no. 1 (index .CmdArgs 1) so it errors >
. Also I prefer so the prefix is not a manual variable.

Thank you for the super helpful tips! I made some edits to the code. Am I all set now?

I'll take a quick look, just a moment.
Thanks for the fast reply!

There will be an error when sending an image without message text, this can be prevented by disabling Errors as CC response however.

And error handling is not possible? Sounds like a hack to me...

It is, I'll add it real quick. {{if .CmdArgs}} should do the job.

Gotcha, then add it and I'll review your PR 👍🏾

Done.

Very nice, let me take a look.

Looks like the fix is not working, it errors when saving. Sorry, I'll have a look again.

Hit me up when you've fixed it! I'll wait for the time being.

I've done some testing, it's not giving errors anymore. This should be it 👍

@DaviiD1337 , do you want to go over it or is it ready to merge?


Rename ScssLint gem (#351)

if I run bundle exec rspec for git version 2.11.0, I get:

warning: empty strings as pathspecs will be made invalid in upcoming releases. please use . instead if you meant to match all paths

Additionally, if you set LANGUAGE to ru_RU.UTF-8 did not pass the test:
Failed examples:

rspec ./spec/overcommit/git_repo_spec.rb:408 # Overcommit::GitRepo.branches_containing_commit when no branches contain the commit should be empty

Failures:

  1) Overcommit::GitRepo.branches_containing_commit when no branches contain the commit should be empty
     Failure/Error: it { should be_empty }
       expected `["(HEAD", "отделён", "начиная", "с", "a8473d7)"].empty?` to return true, got false
     # ./spec/overcommit/git_repo_spec.rb:408:in `block (4 levels) in <top (required)>'
     # ./spec/overcommit/git_repo_spec.rb:378:in `block (4 levels) in <top (required)>'
     # ./spec/support/git_spec_helpers.rb:22:in `block in repo'
     # ./spec/support/git_spec_helpers.rb:35:in `chdir'
     # ./spec/support/git_spec_helpers.rb:35:in `block (2 levels) in directory'
     # ./spec/support/git_spec_helpers.rb:33:in `chdir'
     # ./spec/support/git_spec_helpers.rb:33:in `block in directory'
     # ./spec/support/git_spec_helpers.rb:32:in `tap'
     # ./spec/support/git_spec_helpers.rb:32:in `directory'
     # ./spec/support/git_spec_helpers.rb:13:in `repo'
     # ./spec/overcommit/git_repo_spec.rb:373:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:52:in `block (3 levels) in <top (required)>'
     # ./lib/overcommit/utils.rb:260:in `with_environment'
     # ./spec/spec_helper.rb:51:in `block (2 levels) in <top (required)>'


moved anastasia and varahmihir directories into blocks along with mis…

…sing meta.json file for varahmihir
Zero To Mastery - Webblocks 2022 📦📦
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
PR contains:

directory fixes see snapshot below 🤜
directories moved to /src/blocks/
Renamed sales pitch directory to Contributor name, and added missing meta.json file linked to users Github account

Breaking changes

Root directory fixes

Screenshots

Sorry, I just fixed this on the train, so I didn't see that you tackled it, too.
IHMO we can close this PR.

Perfect 👏 happy to close this too. Thanks @sophiabrandt hope the train journey went well 🤜


[WIP] Enable Auth over TLS connections

Fixes #1549

Codecov Report

Merging #1552 into master will decrease coverage by 0.03%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master    #1552      +/-   ##
==========================================
- Coverage    98.4%   98.36%   -0.04%
==========================================
  Files          58       58
  Lines        2821     2815       -6
==========================================
- Hits         2776     2769       -7
- Misses         45       46       +1


what is homopolymer size?

hi,
I  am currently testing MSIsensor, and confused on a parameter in msisensor scan or msi, homopolymer size. anyone can give me some tips?

Homopolymer runs are where you have the same nucleotide appear consecutively, some number of times.  These parameters allow you to select how large the homopolymer run should be for it to be included in your analysis.


Separate global cache/registry and bin/package management directories and files

Problem
Mixing these together is definitely not a great idea. It makes automated setups harder as they have to go for specific files/subdirs instead of just one directory, if you don't want to copy random package cache between machines. It also makes cleanup etc. harder and more confusing as can be seen by e.g. the advice here: https://github.com/rust-lang/cargo/issues/3289#issuecomment-260368352 (and the whole issue has been hanging on "needs input" status for few years now).
Proposed Solution
Separate these directories and allow separate environment variables for them, e.g. CARGO_HOME and CARGO_CACHE.
Some examples from other package managers:

npm/yarn: https://docs.npmjs.com/cli/v8/using-npm/config#cache
PHP's Composer: https://getcomposer.org/doc/03-cli.md#composer-cache-dir
C#'s NuGet: https://learn.microsoft.com/en-us/nuget/consume-packages/managing-the-global-packages-and-cache-folders

Notes
No response

If I'm understanding correctly, this appears to be a duplicate of #1734

Not quite, it's a similar request which I also support, but it's related.

Solving this kind of problem needs to be done in the context of #1734, so I'm closing in favor of that.  We wouldn't want to design part way on this and realize there is a problem.  Granted, if we decide support for these variables is important, it'll likely be stable in one of the earliest stages of the effort.


v-bind DOM property and attribute inconsistent binding

Version
3.2.11
Reproduction link
sfc
Steps to reproduce
 <div .domProp=a ^domAttr=b>
  </div>

return (_ctx, _cache) => {
  return (_openBlock(), _createElementBlock("div", {
    ".domProp": _unref(a),
    "^domAttr": "b"
  }, null, 8 /* PROPS */, _hoisted_1))
}
}

a dom property or attribute can binded using the shorthand syntax.
for property .domProp  for attribute ^domAttr
when using the property shorthand the expression is bounded
when using the attribute shorthand the expression is not bounded
What is expected?
both property and attribute shorthand should be consistent.
either both are bounded or both are not bounded.
What is actually happening?
only a dom property is bounded

notes:
hypothetically if both shorthand for property and attributes are not bounded by default
^domAttr="hello"
.domProp="hola"

then when binding is needed, the following syntax can be used
note that currently this syntax only actually works for the dom attribute :^.
:. for  the dom property will be completely ignored )
:^domAttribute=helloVar
:.domProperty=holaVar

its also possible that we want to keep this behavior as is, but I am not sure if this was intentional.
and if it is, perhaps this should just be documented.

^ is not a documented shorthand.
The only supported shorthands for v-bind are : and ..
^ is only supported as a prefix when using manual render functions because there are no modifiers when using render functions.


Lesson 6; brownie attaching error with ganache: not getting able to get local RPC client to listen at the local network

I've tried adding the network manually with brownie networks add Ethereum ganache-local host=http://<IP_ADDRESS>:7545 chainid=5777 but that didn't work
Everything worked before hand and followed by clicking quick start just as in the video but it just seems like it's not recognizing ganache

Fixed the issue, needed to go to the Ganache GUI settings -> server and change the port number to 8545 and network id to 1337.
After, deleted the original local network that wasn't working with...

brownie networks delete ganache-local

then, added the local ganache network to brownie with...

brownie networks add Ethereum ganache-local host=http://<IP_ADDRESS>:8545 chainid=1337

... once I restarted the Ganache client Brownie attached to the client and deployed the script fine.

Thanks , it worked

Thanks! had the same issue


add a lake update at blueprint initialization, remove it from CI

Before this PR:

when creating a new project and using leanblueprint new, then pushing the resulting commit, doc build fails.
At the end of the leanblueprint new procedure, the manifest pushed does not contain doc-gen
CI has a step in which it updates checkdecls.

Tested here: https://github.com/RemyDegenne/test2 (only 2 commits: initial commit then automatically generated "setup blueprint" commit).
The idea: CI should not update any dependency, but should use the same manifest file as in local. Therefore, we should ensure that the leanblueprint new command generates and commits a good lake-manifest.
Changes:

add a lake -R -Kenv=dev update at the end of the leanblueprint new procedure, to make sure that we generate and then push a full manifest, including doc-gen.
remove the lake update step from CI
add a -R flag to the doc build step, because it is needed.
remove -Kenv=dev options where they are not needed.

New version tested here: https://github.com/RemyDegenne/test (only 2 commits: initial commit then automatically generated "setup blueprint" commit).

Thanks Rémy! I ended up implementing a slightly different version because yours could have done damage to a project whose Lean part was already underway because it updated Mathlib. Since I also wanted Pietro’s fixes from the other PR, it was simpler to start from his version, so I’m closing this PR.


Automate and Improve status page when the service degrades

When a service degrades and the status is updated to reflect the same, the status page reverts to normal (Green) in some time (~4 hours?) even if the degraded service is back again. This causes lot of confusion to people.
We should also automate update of status messages for degrades like package validation,  CDN issues, service unavailability etc.
Ideally if our monitoring systems are able to find out an issue with the service, the following should happen:

A GitHub issue should be filed for the service degrade
Status page messaging should reflect the corresponding service degrade. It should link to the above mentioned issue.
When all is well, the Github issue should be closed (auto/manual) and that should trigger the degrade message to be marked as operational again.

this was done.

this was done.

Does it work like this now?
Having 1 package, which have been stuck in validating for 1 hour now and there is nothing to see on https://status.nuget.org/

@renemadsen , we had an outage in the validation pipeline this morning. Your package should already be published. Please let me know if it wasn't.
Here are the updates that appeared on status page:


[Suggestion/Discussion] Consider local ".eslintignore" file to evaluate open files

I noticed that the extension only checks opened files.
Is it possible to add support for checking only files not ignored by ".eslintignore" file?
Is this suggestion valid for the intention of the extension and the creator?
Thanks!

This is definitely something that should be a part of this extension-- thank you for your suggestion!
This should also be easily implemented since I already have the traversing of directories to find config relative to the file being linted logic in place. (they should be similar)
Question:
The traversing of directories to find the .eslintignore file doesn't have to be as deep as finding the config, no?
Up to and including solution root should be enough? (much like the old find config behavior)

addressed and implemented in #17
please open a new issue on GitHub if you you experience any problems.

A new version 1.0.185 will soon be available on the Marketplace.


feat(testrunner): async suite descriptions

Alternative to #4721
Does this work?

Does this work?

@JoelEinbinder This mangles test order, basically top-sorting them. Consider running this snippet: https://gist.github.com/aslushnikov/93a8fa25655063187c64767969c33ae8
You'd expect tests to run sequentially, but in fact they run as 1, 4, 2, 3.
The suggestion is very fascinating though, thank you for bringing it up! 👍
Comparing to #4721:

I don't like it because this is not how other test runners work. It makes test description asynchronous in a unique way - you don't know in which context and which point of time they are executed.
I don't like it because it's a conceptual change driven by a rare use case that affects all users.
I don't like it because debugging experience will suffer (can't step over spec definitions, stack traces are not nice)
I like it because it drops the need for top-level await for descriptions
I like it because it makes it harder to forget to await test suite, like in #4721

So far I still lean towards #4721 primarily due to the ratio of simplicity / effort / importance, but I'm open to be convinced otherwise.
P.S. There's an interesting discussion on async testsuites in jest https://github.com/facebook/jest/issues/2235

So far I still lean towards #4721 primarily due to the ratio of simplicity / effort / importance, but I'm open to be convinced otherwise.

...convinced otherwise, especially if the importance of this proves to be significant

Does this work?

@JoelEinbinder This mangles test order, basically top-sorting them. Consider running this snippet: https://gist.github.com/aslushnikov/93a8fa25655063187c64767969c33ae8
You'd expect tests to run sequentially, but in fact they run as 1, 4, 2, 3.

My bad, I didn't realize that addSuite and addTest were separate.

Closing, this was just a discussion prop.


Test requirements improvements

As per https://docs.conan.io/2/reference/conanfile/methods/build_requirements.html#test-requires, the lines in https://github.com/jeremy-rifkin/cpp-template/blob/7a728415fcf1ffb4317443f387a8900affd3af61/conanfile.py#L16 should be part of the build_requirements() method, and should be of the form self.test_requires("gtest/...")

Thanks! Fixed :)


feat: pass variant and variants props to a styled component

Resolve #184

Hi @nandorojo ,
Any changes needed to validate this PR ?
Thanks,

Released in 4.2.0.


Added "Sub Low" playlist to registry

Added the Sub Low playlist.

Looks good, thanks for contributing!


Exception that crashes application when PC was in idle for a while

Describe the bug
After some time when PC was idle, an exception occurs.

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot read the array length because "elementData" is null
	at java.base/java.util.ArrayList.add(ArrayList.java:453)
	at java.base/java.util.ArrayList.add(ArrayList.java:467)
	at androidx.compose.ui.CommandList.add(CommandList.desktop.kt:49)
	at androidx.compose.ui.ComposeScene$attach$4.invoke(ComposeScene.skiko.kt:279)
	at androidx.compose.ui.ComposeScene$attach$4.invoke(ComposeScene.skiko.kt:279)
        ....
	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@4f655745, SwingDispatcher@647b3f51]
Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot invoke "Object.getClass()" because "original" is null
	at java.base/java.util.Arrays.copyOf(Arrays.java:3481)
	at java.base/java.util.ArrayList.toArray(ArrayList.java:369)
	at java.base/java.util.ArrayList.addAll(ArrayList.java:670)
	at androidx.compose.ui.CommandList.perform(CommandList.desktop.kt:62)
	at androidx.compose.ui.ComposeScene.render(ComposeScene.skiko.kt:709)
        ...
	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@1588d015, SwingDispatcher@647b3f51]

Affected platforms

Desktop

Versions

Kotlin version*: 1.8.20
Compose Multiplatform version*:  1.4.0
OS version(s): Windows 11
JDK (for desktop issues): JDK 17 adopt

To Reproduce
This is not really reproducible

Hey @Walingar , you should consider implementing null safety or incorporating default values.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Please support a bg and fg color combo

Even a rudimentary support would improve the readability greatly. Many thanks in advance.
Just FYI, terminal file manager nnn now has a plugin to read books from Project Gutenberg: https://github.com/jarun/nnn/blob/master/plugins/gutenread
epr is the suggested utility for those who (like myself) prefer the epub format.
Great utility! Keep up the good work!

Wow, couldn't believe the jarun, the man behind buku and googler, would be here. Been a big fans of them cli apps, thanks for them.
And regarding color combo, indeed color scheme (and separated config & statesaving files) came to mind some times ago, but I got bad sector in my HDD, so it's been too long since the last time I check epr. But now since I just upgraded to SSD, I'll try to get back at it soon. Tho probably I'll start with simple dark/light switch.
And thanks for recommending epr in nnn plugins, totally appreciate it.

Oh and a little fun fact: Buku, as you stated, means close to heart in your language. But in my language (Indonesian) it means book.

Just doing my part to make the terminal great again! ;)
I really like epr and nowadays I'm reading Edgar Allan Poe in it using the gutenread plugin. It would really help if I could tweak the colors a little.

But in my language (Indonesian) it means book.

Yes, I heard it earlier too. Still makes sense given bookmarks originated from books. :)

Hello there, just added dark/light color switch... Though for now it only involves 2 colors, foreground and bakcground, no syntax highlighting. And customizing those colors can only be done inside the source.
See the updated README.MD...

Cool!

I love the light color scheme! Can you please add a program option to pass the value so users don't have to press c each time they open the reader?

Updating the thread in case you have missed the request for a program option...


add tests

all but src/cli.ts is sufficiently tested in https://github.com/zenodraft/zenodraft/tree/dbd7bbb68a18877b677f85ff8af503963e1bfcfa, closing


Easier Lind Updater

Right now we have to manually update all branches to develop when launching a new container, can we automate this in the Makefile or mklind?

Implemented with last PR

Implemented with last PR


Update status of Logs OTLP and Logs Data model to stable

OTLP Logs are now Stable: https://github.com/open-telemetry/opentelemetry-proto#maturity-level
Log Data model is also Stable: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md

The OTLP-logs status is automatically extracted from the spec (currently at v1.11.0). But even in the spec @HEAD, the status is still showing as beta, see https://github.com/open-telemetry/opentelemetry-specification/blame/main/specification/protocol/otlp.md#L57:

Logs: Beta

So an issue would need to be open over the spec. Would you like for me to create one?

Where does the "log data model" status show up in the status page?

So an issue would need to be open over the spec. Would you like for me to create one?

Created: https://github.com/open-telemetry/opentelemetry-specification/pull/2565

2. Where does the "log data model" status show up in the status page?

See "The data model is experimental and released as part of the OTLP protocol.":

@tigrannajaryan - how about if I update that bullet to read the following instead:

The data model is released as part of the OTLP protocol

@chalin sounds good, thanks.

Closed by #1464
Optional items moved to #1492


Replacing Stack Overflow as primary forum for TypeScript discussion

TypeScript project is wonderful and something the whole JavaScript community benefits tremendously from. Unfortunately, the current official discussion channel, Stack Overflow, does not do it proper justice.
Stack Overflow is a good place for small focused questions. But in the case of TypeScript questions, you often want to hear different angles to solutions. Many times the answer is "it depends" and warrants further discussion. For this kind of dialogue Stack Overflow is not adequate and the moderators over there make it very clear by their actions.
Gitter chat, on the other hand, is useful but it is not very searchable. Instead, something organized around discussion threads would be more suitable.
Could Stack Overflow be complemented with a dedicated TypeScript forum?
(Yes anybody could start one, but the best changes for something like this to succeed is if the initiative comes directly from the project.)
PS. It's sad to see the last message on CodePlex deals with exactly the same topic. http://typescript.codeplex.com/discussions/645941
Possible solutions, open for discussion

Google Groups
dedicated forum software (Discourse, etc.)
revive CodePlex
Reddit

Just saying this explicitly since we've gotten flak about it before: Stack Overflow is not a discussion forum, official or otherwise.
On the topic at hand, there's already /r/TypeScript, and probably discussions happening elsewhere as well. We talked about starting something more official but not staffed to run our own discussion forum at this point - we have our hands completely full between managing the activity on the GitHub issue tracker and doing Actual Work.

I'm a bit puzzled about Stack Overflow not being official. On the old CodePlex discussions site it states:

"..we're moving the forums.. for questions use Stack Overflow.. "

But good to hear that this issue is being talked about.

+1 for dedicated forum

I agree there should be a forum.  Stack Overflow is strictly for questions with definite answers.  If I want to ask whether people think this is a good idea or a good style or suggestions for tools or whatever, Stack Overflow would immediately shut such a question down.  A forum is needed.

Try out the TypeScript Gitter channel it is actually rather active.

Already did.  Haven't gotten an answer to my query yet.

There's also a discord now. We are not staffed to moderate an additional forum.


Unexpected MissingEndParenthesisInMethodCall

Method call parsing fails when it should not
Steps to reproduce
PS /Users/vors/dev/ZLocation> $response.Send($service.Get() | ConvertTo-Json)
At line:1 char:30
+ $response.Send($service.Get() | ConvertTo-Json)
+                              ~
Missing ')' in method call.
At line:1 char:47
+ $response.Send($service.Get() | ConvertTo-Json)
+                                               ~
Unexpected token ')' in expression or statement.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : MissingEndParenthesisInMethodCall

Expected behavior
parses fine
Actual behavior
parsing error
Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.5
OS                             Darwin 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu...
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

$response.Send($service | ConvertTo-Json) failed too.
Do we really support a pipe as method parameter?

Shouldn't that be $response.Send(($service | ConverTo-Json))?

Method arguments must be expressions, they can't be a pipeline.
If a pipeline were allowed, there would be some ugly ambiguities to resolve, e.g.
$obj.Method(Get-Thing 1,2)

Does this pass Get-Thing 1 and 2 to Method (2 arguments) or the result of Get-Thing 1,2 (one argument).

Can we write more clear error message in the case?

Ah I see.
I think it's worth to go an extra mile to write a special case error message as @iSazonov suggested.


[Bug]: failed to flashback an object in recyclebin

ODC version
4.2.3
OB version
not related
What happened?

select an object and click 'flashback' button.

give the object another name:

click 'submit' button, the object can be flashback normally.

select another object and click 'flashback' button:

click submit button:

What did you expect to happen?
I can flashback the object normally
How can we reproduce it (as minimally and precisely as possible)?
follow 'what happened'
Anything else we need to know?
No response
Cloud
No response

the pic of the step 4 and step 5 got some problems, I can give a brief a desp:

step 4: the object name in table is different from the selected one;
step 5: the request object is different from the selected one;

Fixed In Commit d159ed302f3b0dc56ea571c7166e65cf8a72ae94
------
咏和
Sun Dec 10 10:59:51 2023 +0800

PASS


Strengthen name check

This ticket is for issue #4676
Testing Plan:
In terms of testing to make sure that illegal names were properly checked, only manual tests were done, as there was no existing unit tests for this.
A notable change to tests was that the original format used for generating test full names created illegal characters under the new requirements. Instead of a pretty solution, as these are simply unit tests, when generating full_names the user email is stripped of illegal characters, as opposed to the previous replacement by underscores.

Changes were based on RFC standards 5322 and 6532, with regards to the display name and unicode support respectively.

Fixed slight regression to coverage in zerver/lib/users.py

Based on recent new findings, I am going to overhaul this pull request in an attempt to remove most of the newly added values from NAME_INVALID_CHARS. Additional conversation regarding this will go in the issue itself.

These new changes take into account the fact that quoted strings exist for email headers. Reducing the new illegal characters to only " and \ as they are the ones that cannot be allowed still.
This however, will not properly handle unicode strings, and formataddr will garble them in a way that parseaddr cannot decode. Besides restricting full_name to only be ascii, I think that shifting over to the python3.6 email api will be needed in order to support full unicode.

After further consideration of RFC's and looking into what is supported by different email providers, the 2231 encoded strings provided by formataddr are properly handled by the two biggest email providers (gmail, outlook). As well as Thunderbird, and Protonmail (I have not personally tested others) This gives enough assurance that this will not break in the common case.
This pull request should now be ready to resolve issue #4676

Squashed commits into one.

I was suggested to @timabbott in order to get a final pr check before merge?

I fixed the migration issue above, split this into two commits to match our style (one for the name enforcement, the other for formataddr) and merged this.  Huge thanks for doing this @cbondurant!


🐛 [firebase_auth] Device language is not used by default

Bug report
According to documentation the device language should be used by default in email templates. Based on my tests it uses English always unless the language is explicitly set with setLanguageCode.
Same issue both in iOS 15.6.1 and Android 12.
Steps to reproduce

Set device language to Finnish (fi). App is also localized to Finnish and the current app language is Finnish.
Call e.g. sendSignInLinkToEmail

    await _auth.sendSignInLinkToEmail(
        email: email, actionCodeSettings: actionCodeSettings);

Expected behavior
User is sent the email in Finnish.
Actual behavior
User is sent the email in English.
Additional context
I believe you can reproduce the issue with any language (other than English).
If you set the language explicitly to "fi", it works as expected.
    await _auth.setLanguageCode("fi");
    await _auth.sendSignInLinkToEmail(
        email: email, actionCodeSettings: actionCodeSettings);

Flutter doctor
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.3.0, on Microsoft Windows [Version 10.0.19043.1889], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.7)
[√] Android Studio (version 2021.1)
[√] VS Code (version 1.70.2)
[√] Connected device (4 available)
[√] HTTP Host Availability

• No issues found!

Flutter dependencies
firebase_auth: 3.7.0

According to documentation the device language should be used by default in email templates

@kinex Thanks for the report. Can you share the documentation link ?

Here is the link: setLanguageCode method
Actually I just noticed that maybe the plugin expects the setLanguageCode must be called with null even if you want to use the device language. This would be slightly unnecessary and confusing especially because language returns null if setLanguageCode has not been called at all. I assumed that the device language is used automatically if you don't call it at all.
Also, the first sentence in the documentation "When set to null, the default Firebase Console language setting is applied." is wrong information (compared to the rest of the documentation and to what the code tries to do).

Thanks for the link and update. Using steps to replicate provided above, I am seeing the same behavior as reported.
Similar / related: https://github.com/firebase/flutterfire/issues/7829


Enhancement to the catalog to make it easier to see what is new

How about adding a 'version' column to the details of eash item showing when it was added ? Or a mechanism to show what is new in a release, currently the front page shows the version numbers but it would be nice to see what is shiny and new :) Failing that, some release notes would help.

+1


Double build on Bitbucket incoming webhook

Details

Project URL: https://readthedocs.org/projects/mir-spec/
Build URL (if applicable): https://readthedocs.org/projects/mir-spec/builds/
Read the Docs username (if applicable): petar.maric

Also checked the Bitbucket project configuration, only a single RTD related webhook is present.
Expected Result
A RTD build is triggered on a Bitbucket incoming webhook.
Actual Result
Two RTD builds are triggered on a Bitbucket incoming webhook.

I have the same problem, but with GitHub. Not sure what else to try!

@petarmaric @guillochon can you try this https://github.com/rtfd/readthedocs.org/issues/3255#issuecomment-373564346?

Yep that looks like the fix! Thanks @stsewd!

Sorry @stsewd, I can't test it as my project hasn't had any builds recently.

Closing for now then, sounds like this is a configuration issue with GitHub/Bitbucket webhooks, not RTD.
@petarmaric feel free to reopen if you are still noticing the issue once you commit to your repo


Android Basics: tip-calculator

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-tip-calculator
In which task and step of the codelab can this issue be found?
Step 4 - Get the tip percentage
Describe the problem
Just a typo: should be like this
At this point, the calculateTip() method should like this:

@yalematta
Thank you for reaching out to us. The issue is fixed and published.


Driver change

replaced all drivers with a single new implementation, based on go-redis v9
updated travis settings
made it a Go module

And again, lol. Didn't noticed that Github by default creates pull request to a repository I forked from. Sorry.

@skaurus no problem! Actually, we can discuss pulling your changes up here, if you wish.

Some of them are straightforward - like mod init, or travis.yml update.
But using go-redis/redis v9 driver requires changing method signatures to include context.Context
If this is fine with you, I can indeed update other drivers files to include it, and submit a pull request.


Add a basic material slider

The slider in this patch works, but it's missing animations and many subtle
touches.

@HansMuller @Hixie

LGTM with minor comments


🌱 Bump docker tag for new release.

Signed-off-by: Spencer Schrock<EMAIL_ADDRESS>I've manually tested the action, as the steps in RELEASE.md don't actually test any new changes since the docker image is pinned to a version.
I've tested with this command and confirmed the original bug (https://github.com/ossf/scorecard/pull/2557) is fixed.
docker run -e INPUT_REPO_TOKEN="$GITHUB_AUTH_TOKEN" \
    -e INPUT_POLICY_FILE="/policy.yml" \
    -e INPUT_RESULTS_FORMAT="sarif" \
    -e INPUT_RESULTS_FILE="results.sarif" \
    -e INPUT_PUBLISH_RESULTS="false" \
    -e GITHUB_WORKSPACE="/github/workflow" \
    -e GITHUB_REF="refs/heads/main" \
    -e GITHUB_EVENT_NAME="branch_protection_rule" \
    -e GITHUB_EVENT_PATH="/testdata/test.json" \
    -e GITHUB_REPOSITORY="nginxinc/nginx-kubernetes-gateway" \
    -e GITHUB_API_URL="https://api.github.com/" \
    -v $PWD:/github/workflow \
    gcr.io/openssf/scorecard-action:latest

I think the RELEASE.md needs to move the section on testing to after we've updated the tag

Until the release happens, the newly tagged Docker image won't exist. So doing it after the tag but before the release also won't work.
I think we need a test version of action.yaml which uses gcr.io/openssf/scorecard-action:latest

I think the RELEASE.md needs to move the section on testing to after we've updated the tag

Until the release happens, the newly tagged Docker image won't exist. So doing it after the tag but before the release also won't work.

Yeah, I meant after release as well. But too late f it's broken.

I think we need a test version of action.yaml which uses gcr.io/openssf/scorecard-action:latest

What is latest in this case? It still points to an old scorecard release, does it not?
Or we need to cut a v1.2.3-rc and use that instead to test before the actual release?

I think we need a test version of action.yaml which uses gcr.io/openssf/scorecard-action:latest

What is latest in this case? It still points to an old Action release, does it not?
Or we need to cut a v1.2.3-rc and use that instead to test before the actual release?

So right now RELEASE.md mentions a manual dispatch of scorecards.yml which calls our public action.yaml
https://github.com/ossf/scorecard-action/blob/e38b1902ae4f44df626f11ba0734b14fb91f8f86/.github/workflows/scorecards.yml#L23-L26
But ossf/scorecard-action@main is pinned to a specific docker version, so it will always run an old docker release:
https://github.com/ossf/scorecard-action/blob/e38b1902ae4f44df626f11ba0734b14fb91f8f86/action.yaml#L54-L56
I think we need to change scorecards.yml to use a private action which references the latest docker image, which will have the changes we're trying to test. We need to setup a private action which has the following lines
runs:
  using: "docker"
  image: "docker://gcr.io/openssf/scorecard-action:latest"


A wish: Single-page full documentation, offline-friendly

https://rakudocs.github.io/perl6.html
It hasn't been updated for looong.

When we recreate the big page, it won't be done as part of the website, but as a separate epub doc, most likely; that work will be done off the main doc repo (or a new separate project like this one just for the epub build).

Note that the github IO address above isn't from this project. It's generated from the raw content and managed separate from docs.raku.org (which this site is intended to replace)

It was a design goal of my Collection tool kit to enable the generation of different types of output. I have now demonstrated that the OgdenWebb design (Altai-man's site) and the MoritzLenz design (the original site) can be generated using Collection. The change is made by changing plugins and templates.
A single page website was used to generate an epub. This is easily possible using Collection. I will need help with the templates to get epub output.


HUB-595: Tear down sign-in hint AB test & make hint part of the journey

https://govukverify.atlassian.net/browse/HUB-595
What
These are the front-end changes required to turn of sign-in hint
We need to tear down the current signin hint AB test once 2 weeks have elapsed (after Monday 20 April).
Depending on 's analysis, we should either:
revert to the control (A), which has no signin hint
ship the variant (B), which has the signin hint
Why
Because we'll know whether the hint was successful or not, so we should now either implement it or not.
How
This PR ships variant (B) as live in place of variant (A), we have decided variant (B) is successful.

The copy on the hint is incorrect - it should look like this:

The copy has been updated in my commit


Thread - Thread report name is parent message owner's name when originates from group chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Log in to New Expensify
Create group chat
Send a message in the chat
Hover over the message > click on Reply in thread

Expected Result:
Thread report name should be the thread parent message
Actual Result:
Thread report name is the parent message owner's name
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/704b4302-8c04-4fd0-ac49-73e424baa713
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp

@kevinksullivan  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
The thread created from a group chat doesn't show the parent message as the report name.
What is the root cause of that problem?
When it's a group chat, we use getGroupChatName to get the name.
https://github.com/Expensify/App/blob/2b592a2f93af827afa6ca0b438efab2235935249/src/pages/home/HeaderView.tsx#L92
The group chat condition checks for the chat type whether it's group or not.
https://github.com/Expensify/App/blob/2b592a2f93af827afa6ca0b438efab2235935249/src/pages/home/HeaderView.tsx#L79
A thread will always inherit the chat type of its parent, this happens on every type of report, so inside the thread, isGroupChat() is still true.
This doesn't happen before when we still use the old condition to check for group chat (isDeprecatedGroupDM) because it excludes thread chat.
https://github.com/Expensify/App/blob/2b592a2f93af827afa6ca0b438efab2235935249/src/libs/ReportUtils.ts#L5312
The getGroupChatName will return the participants name sorted alphabetically with a limit, but the logic to show the parent message for a thread is in getReportName.
What changes do you think we should make in order to solve the problem?

We can move the group chat condition to getReportName to have a single place of the report name logic. This way, the thread parent message will be prioritized based on the current logic of getReportName.
https://github.com/Expensify/App/blob/2b592a2f93af827afa6ca0b438efab2235935249/src/libs/ReportUtils.ts#L2845-L2929
We will add a new case for group chat at the bottom.
if (isGroupChat(report) || isDeprecatedGroupDM(report)) {
    formattedName = getGroupChatName(report?.participantAccountIDs ?? [], shouldApplyLimitForGroupChat);
}

And replace this
https://github.com/Expensify/App/blob/2b592a2f93af827afa6ca0b438efab2235935249/src/pages/home/HeaderView.tsx#L92
to:
const title = ReportUtils.getReportName(reportHeaderData, undefined, true);
We need to apply this in OptionRowLHN, ReportSettingsPage, and potentially other places that I haven't discovered yet.
What alternative solutions did you explore? (Optional)
Return false in isGroupChat if it's a thread.

asking about where this fits
https://expensify.slack.com/archives/C05RECHFBEW/p1712358384520919

I'll help take a look at this on Monday.

Testing this locally against https://github.com/Expensify/App/pull/39757 and it appears to be fixed so going to assign myself here. We've already got @s77rt helping on the C+ review so adding them here too.

Waiting for the next deploy, but this one should be fixed now.


Incompatibility with Canvas Export and Webpage Export Plugin

For some reason if I try and export a full canvas image or export using the Webpage Export Plugin while using the border theme it doesn't export correctly. I'm using a sandbox vault in all the images, and have installer version 1.1.9

Canvas
The full page canvas export does not render correctly and seems to random other aspects of obsidian, the viewport export works fine however.

Canvas pre-export

Canvas post-export

Webpage Export Plugin
The theme completely breaks exporting, you end up with just a little bit of text and no content, the content itself does appear in the html 'code' still however, it doesn't render.

Note pre-export

Note post-export

The first issue has been resolved in the latest version.
The cause of the second issue may be due to the use of SVG images in border theme. I am unlikely to remove all the SVGs used in the theme because of this plugin. Therefore, submitting an issue to the plugin repo may be more helpful.

The first issue has been resolved in the latest version. The cause of the second issue may be due to the use of SVG images in border theme. I am unlikely to remove all the SVGs used in the theme because of this plugin. Therefore, submitting an issue to the plugin repo may be more helpful.

Well.
I have the same issue and :
https://github.com/KosmosisDire/obsidian-webpage-export/issues/65#issuecomment-1575060573
Let the ping-pong play begins XD


Go to previous/next page

As mentioned in #18, it would be great to have a keybinding for 'prev', 'next' links.
This is useful for navigating forums, github issues, long articles, etc. On VimFx, the keybindings were [, and ].

Just wanted to share my experience with this feature from VimFx, both as a user and as an implementor:
This is a VimFx feature I kinda liked, but also disliked a bit. The thing is that you more or less have to learn which pages it works on. When you press ] in VimFx, one of three things happen:

You’re taken to the next page as expected.
You’re taken to an unexpected page (because some link happened to match a “next” pattern).
Nothing at all happens.

So I mostly didn’t use it. Only on a few forums I often visit, for github issues listings, and for search results on a couple of pages.
Another weakness of the feature is that users mostly have to customize the default patterns for their language. For example, adding “nästa” as a “next” pattern and “föregående” as a “previous” pattern for Swedish.
Here’s the VimFx implementation. It’s mostly regex search. But also nasty a hardcoded hack to make things work on Google.

https://github.com/akhodakivskiy/VimFx/blob/376486f4dc61d75add1c26263d1f4baf39d3abd4/extension/lib/commands-frame.coffee#L484-L539
https://github.com/akhodakivskiy/VimFx/blob/376486f4dc61d75add1c26263d1f4baf39d3abd4/extension/lib/parse-prefs.coffee#L50-L69
https://github.com/akhodakivskiy/VimFx/blob/376486f4dc61d75add1c26263d1f4baf39d3abd4/extension/lib/defaults.coffee#L151-L152
https://github.com/akhodakivskiy/VimFx/blob/376486f4dc61d75add1c26263d1f4baf39d3abd4/extension/lib/defaults.coffee#L177-L180 (https://github.com/akhodakivskiy/VimFx/commit/b4e73c77b7b026a3bf5430f001c992f745e5066d)

Here are some tricky issues:

https://github.com/akhodakivskiy/VimFx/issues/836
https://github.com/akhodakivskiy/VimFx/issues/792

I guess what I’m trying to say is that copying VimFx is not super difficult. But then you also inherit that half-good experience, and open a can of worms. You can also try to come up with a better heuristic for finding the links. Or make a database of selectors for every site, like the old Autopagerize extension/userscript: http://wedata.net/databases/AutoPagerize/items_all.json. It also feels like machine learning would be appropriate for this challenge ... how far down this rabbit hole can we go?

I would be fine with it only working when there's a <link rel=prev/next/first/last> (which honestly is how it should be implemented by websites anyway).
I agree with you that it was annoying that it didn't always work, but hey, that's not the plugin's fault necessarily.

I think even with the shortcomings that @lydell mentioned, it was a great feature, I would be perfectly okay with that implementation.

Placeholders for these commands actually already exist in Saka Key's source code. I'll probably end up porting VimFX's implementation when I get around to it.
https://key.saka.io/dev_docs/adding_commands

How about implementing the commands as site plug-in?
Access to Site mode on Space, and [ and ] commands to go to the previous and next page.
A global and naive implementation could be added.
The site could hijack the global implementation.
Interactive creation of plug-in would be neat for non-developers.
It would seamless allow the Next / Previous page functionalities creation.
All that on-the-fly.

@alexherbo2 FYI, rel=next/prev/etc... is in the standard: https://www.w3.org/TR/html5/links.html#sequential-link-types (for what that's worth, anyways).

Yep, I don’t know for you, but none of the sites I use use that. XD

Ah. Sorry, I assumed you wanted sites to implement this. I agree it would be nice to be able to override commands (really, all commands) for arbitrary websites. However, I believe that discussion belongs in #45.

Since searching "bing" in buglist gave me nothing, I would like to mention the prev and next page does not work on Bing. It seems to be because their prev/next buttons don't have any text, and also lack something like rel="next".
I have created a greasyfork to have those buttons get the rel="prev" and rel="next" attribute needed to make them work with Saka:  https://greasyfork.org/en/scripts/390762-bing-rel-next-prev
But it's a mystery for me why while the next button works perfectly with Saka (]), the prev button ([ here) also acts as a prev. Where's the bug? I already double checked the greasyscript and my mapping in Saka for [ and ].


Add panes for layers

Overview
Putting each layer in a pane allows for more control over individual layers because leaflet
creates separate HTML elements for each pane. They can be referenced by the class name leaflet-{pane label}-pane. For example, the basemap pane can be selected with leaflet-basemap-pane.
Closes #52
Demo

Notes
I was not able to get the reference layer to use a pane. I tried wrapping it in a featureGroup like the user polygon layer, but removed all the edit controls and the image was non-interactive. For now, it seems to work well enough to place all the other layers around that one.
TODO:  From #52:

When multiple are visible, the topmost one should receive all mouse events

As is, things seem to be working well. Edit handles can be selected over other layers. The only problem is that you cannot add a polygon over the reference image. This is probably due to this line from Leaflet Distortable Image:
https://github.com/publiclab/Leaflet.DistortableImage/blob/main/dist/leaflet.distortableimage.css#L6
Testing Instructions
Adding this feature allows the layers to be ordered based on their zLevel. Previously the municipal boundaries layer would show above the reference image. To test this:

Toggle both the reference image and the municipal boundaries layers on
Move the reference image to some municipal boundaries and ensure they appear above them.

Checklist

[ ] fixup! commits have been squashed
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
[ ] README.md updated if necessary to reflect the changes
[ ] CI passes after rebase

@rajadain I didn't end up using layer groups as described in #52, so I wanted to check in with you before proceeding with the click event stuff.

Taking a quick look

@rajadain I'm incline to have the reference layer and tools layered above the boundary polygon. They can use the opacity to set the transparency lower. The user would then toggle the reference layer on/off and adjust polygon accordingly.

Hmm, but if the reference layer is in front of the polygon, they can't edit the polygon while looking at the reference layer. Wouldn't editing a transparent polygon on top of a reference layer be easier?

From a conversation with @mstone121 it seems that all interactive parts (distortion toolbar, polygon vertices, reference image vertices) are drawn on a different pane than the drawn parts (the polygon, the reference image), which makes it difficult to put the distortion toolbar behind the polygon layer.
Another thing we could do is see if we can make the distortion tools only visible when the reference layer is in "focus", but that may make the tool more complicated, as it would add the concept of an active or inactive layer.

Another thing we could do is see if we can make the distortion tools only visible when the reference layer is in "focus", but that may make the tool more complicated, as it would add the concept of an active or inactive layer.

This is actually sort of built into the tool already. If you click away from the Reference Image the edit tools should disappear, but the image is still visible.

Ah nice! @gatesgodin let's see if the three of us can huddle tomorrow morning on this to set the immediate direction.

I am okay with the active / inactive "focus" function as long as the reference layer is clickable. The tools would disappear by clicking away and re-appear when clicking on the reference layer. Once the reference image is aligned correctly on the map, the tools will no longer be necessary. I am also imagining that they would toggle the boundary off when adjusting the reference layer. So I think as you have it now is pretty close to that functionality.
Sounds good, let's huddle in the morning! @mstone121 @rajadain

Summary of discussion:

We'll keep the implementation above as is, with the reference image layer being beneath the polygon, and the distortion toolbar only becoming visible when the reference image layer is selected
This implementation gets us most of the way there, can make little tweaks later
There is no current implementation in the works for the "popout" feature of the reference image layer. That will be tested by simulation in the user research sessions, and if deemed worthy, will be wireframed first, and implemented after.

Will take another look once rebased

Taking a look

I added a pane for the labels in https://github.com/azavea/iow-boundary-tool/pull/57/commits/e6ffd438b00d57091da972a769996d7e11b44e46.

Taking another look

I can't seem to draw a polygon over the Municipal Boundary Layer either. Have you seen this? I only see notes about this for the Reference Image Layer

I can't seem to draw a polygon over the Municipal Boundary Layer either. Have you seen this? I only see notes about this for the Reference Image Layer

Yep. It happened to me too. Fixed here.


Request rename repo to cde

@hcook
I think the api-config-chipsalliance is a legacy name schema, which has been abandoned, maybe switching to cde is more reasonable.

@hcook I found I can do this. Just did it to save your time. :)


Add OpenCV and Tensorflow Lite dependencies to application

OpenCV: https://www.geeksforgeeks.org/how-to-add-opencv-library-into-android-application-using-android-studio/

Tensorflow Lite:
https://www.tensorflow.org/lite/guide/android


Unexpected token '?' in MudBlazor.min.js

Bug type
Component
Component name
MudBlazor.min.js
What happened?
On Some Browsers (e.g. Android/Edge, Android/Brave) i cant run a website using MudBlazor.
It seems like these Browsers dont understand null-coalescing operator "??".
Expected behavior
Let it work on these browsers:)
Reproduction link
https://mudblazor.com/
Reproduction steps

Use Free Brave Browser on android (i am using V.1.5.5, Chromium 79.0.3945.136)
open "https://mudblazor.com/"
See error abouit "Unexpected token '?'" in MudBlazor.min.js
...

Relevant log output
No response
Version (bug)
6.0.2
Version (working)

What browsers are you seeing the problem on?
Other
On what operating system are you experiencing the issue?
Android
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sorry, we can't support every browser. But it is supported by every major browser: https://caniuse.com/?search=%3F%3F
That's why we will keep it like that. But you can create a PR if you want.

See https://github.com/MudBlazor/MudBlazor/issues/3537


net: openthread: platform: Removed double-buffering in UART send.

Putting data to local buffer before transmission was removed to optimize operation.
Local buffering was not needed, as passed buffer cannot be modified until sending is finished.
Signed-off-by: Kamil Kasperczyk<EMAIL_ADDRESS>

Just some nits, but it seems to overlap with #26633, we need to push that one forward.

Yes I know it partially overlaps #26633, because I wanted to make it easier to merge with this change. Moreover I didn't know which PR will be merged first and I didn't want to make one change wait for the other.

#26633 was just merged, you could rebase to simplify the diff.

@rlubos Thanks, it's rebased.

Please do not merge it yet. I found a bug during tests and I have to fix it.

Bug fixed, everything is working properly.


prim_pulse_sync.sv functional issues

The current implementation of the prim_pulse_sync.sv present 2 functional issues

The source and dest resets are not effecting eachother and if only one is applied, the toggle state is not initilized which creats a wrong pulse. This issue was detected in the RNG logic which has 2 clocks system, RNG (SYS) and RCLK (TLUL).
When the cell is handling a pulse and a new one is introduced an ASSERT is issued, if enabled. The new pulse is not blocked and breaks the first puls function. The ASSERT will Error if enabled by after synthesis it will not! Blocking and busy indication is needed to make sure the cell function is not broken.

An alternative cell, ast_pulse_sync.sv was added to the AST to address the above issues.

Triaged for tlul. If I understand correctly, the solution described by @Jacob-Levy works for M2.5, but we may want to revisit this for future releases? If so, I suggest https://github.com/lowRISC/opentitan/labels/Type%3AFutureRelease. CC @GregAC


[3915] Guid parsing is slow

Fixes #3915
If use the following test case as base then deserialization time was improved (on my local machine) from 5570 ms to 3089 ms
https://deck.net/b672e0b116e7d773b6d0a942535726d3

I added two extern helpers classes for native RegExp. They are marked as internal, so it is not visible outside Bridge assembly

https://dev.deck.net/afdabbf583bafa1f55482d93111c92d1

Thanks for the Deck, @rootflood. Your approach has similar deserialize performance to what the optimization reached, yet it does a noticeable faster serialization from ~2800ms to ~1600ms on my side.
The optimization introduced by this pull request is irrelevant to the deck you provided -- running it either in a patched or non-patched version of Deck results in similar performance -- so it may be used as a means to workaround the slow performance in Bridge 17.7.


Frigidaire failing to configure/reconfigure

Core - 2024.1.3
Supervisor - 2023.12.1
Operating System - 11.4
Frontend - 20240104.0
Logger: homeassistant.config_entries
Source: config_entries.py:406
First occurred: 12:16:51 AM (3 occurrences)
Last logged: 9:10:14 AM
Error setting up entry frigidaire for frigidaire
Traceback (most recent call last):
File "/config/custom_components/frigidaire/init.py", line 20, in setup
hass.data[DOMAIN][entry.entry_id] = frigidaire.Frigidaire(
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/frigidaire/init.py", line 246, in init
self.authenticate()
File "/usr/local/lib/python3.11/site-packages/frigidaire/init.py", line 282, in authenticate
auth_response = self.post_request('/authentication/authenticate', data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/frigidaire/init.py", line 430, in post_request
return self.parse_response(response)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/frigidaire/init.py", line 404, in parse_response
raise FrigidaireException(f'Request failed with status {response.status_code}: {response.content}')
frigidaire.FrigidaireException: Request failed with status 403: b'{"message":"Forbidden"}'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 406, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/frigidaire/init.py", line 28, in async_setup_entry
await hass.async_add_executor_job(
File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/frigidaire/init.py", line 26, in setup
raise data_entry_flow.AbortFlow from err
TypeError: AbortFlow.init() missing 1 required positional argument: 'reason'

I've been running into the same thing--"integration fails to setup," "needs attention."

Same here.  I have a dehumidifier that I deleted because it wasn't connected, and now can't re-add it.

I think this is mine as well. The 403 with the 'reason' message.

After 24 hours, new entities popped up. I haven't used the integration for a few months, so maybe that's why the old entities didn't work? The new entities (climate.office_ac_2 as the new version of climate.office_ac) seems work, but the temperature scale is in F instead of C. That's a different issue.
The issue here for me has cleared up.


Draft: Support for DynamoDB

This makes a lot of assumptions about how to use DynamoDB.
The schema used for the table can be found here.
TODO:

[x] Make AWS Region configurable
[ ] Make DynamoDB table configurable
[x] More efficient DynamoDB query
[x] Handle range gets/wildcard look ups

Ok, what currently breaks is the Go 1.2 tests because the AWS SDK uses the Timeout field on the http.Client.
All AWS settings can be configured either via environment variables or EC2 specific instance profiles.
The only thing missing is to make the table configurable. Would like some input on that. Should I just stick it into Config?

@bracki I think we should be able to move past go 1.2 at this point.

@bracki I've merged this but we may need to clean it up a bit before the next confd release.

@kelseyhightower Cool! What exactly do you think needs to be cleaned up? Just let me know and I'll take care. BTW we are using this in production on a 30+ instance auto scaling group.


In cli examples --config  fieldsConfig.json needs { "fields": ["color", "model"] }  not just ["color", "model"]

Just change in examples for cli json2csv --config option.

In closed 456#issuecomment-618741944 it mentioned:
{
"fields": ["product","price","color"]
}

The json file can have multiple lines as well...
{"fields":
  [
	"color",
	"price"
  ]
}

In closed 456#issuecomment-618741944 it mentioned:
{
"fields": ["product","price","color"]
}

The json file can have multiple lines as well...
{"fields":
  [
	"color",
	"price"
  ]
}

Instructions
Please follow the instructions below so we can help you best.
Before filing an issue

Make sure there isn't already an issue present, i.e. you can search the issues.
Make sure it's not an issue with your data. Check the validity of your JSON using something like http://jsonlint.com
Make sure you're using the latest version of json2csv (your issue might already be resolved).
Know what's wrong? Submit a Pull Request instead with a failing test and/or a fix.

Filing an issue

Include the version of json2csv used.
Include your node version/browser vendor and version.
Include the command or code you used.
Include a sample dataset that we can test against.
Include your output/error.

Instructions
Please follow the instructions below so we can help you best.
Before filing an issue

Make sure there isn't already an issue present, i.e. you can search the issues.
Make sure it's not an issue with your data. Check the validity of your JSON using something like http://jsonlint.com
Make sure you're using the latest version of json2csv (your issue might already be resolved).
Know what's wrong? Submit a Pull Request instead with a failing test and/or a fix.

Filing an issue

Include the version of json2csv used.
Include your node version/browser vendor and version.
Include the command or code you used.
Include a sample dataset that we can test against.
Include your output/error.


Dev/danglingdomainchanges

Adding script and code to azure docs to detect dangling domain in Azure

Hi @AzureDanglingDNS - Thanks for your pull request. A member of the content team will review it.

@AzureDanglingDNS, since you've moved this to a better location you should close this PR.

Hi, @AzureDanglingDNS thanks for your contribution! This information is available here. https://docs.microsoft.com/azure/security/fundamentals/subdomain-takeover


Support reference data international symbols endpoints

Adds support for these endpoints: https://iexcloud.io/docs/api/#international-symbols
This PR also includes some cleanup requested by black iexfinance.

[x] closes nothing
[x] tests added / passed
[x] passes black iexfinance
[x] passes git diff upstream/master -u -- "*.py" | flake8 --diff
[x] added entry to docs/source/whatsnew/v0.5.0.txt

Thanks. Starting to work on this project this week.

Thanks.


Cannot install dlib==19.5.0 in both Linux and MacOS

Ubuntu 18.04 & python 3.6.9
MacOS 10.15.3 & python 3.7
Installing dlib==19.5.0 on both environment failed with same issue.
(venv) ➜  3DDFA git:(master) ✗ pip3 install dlib==19.5.0
Collecting dlib==19.5.0
  Using cached dlib-19.5.0.tar.gz (46.8 MB)
Building wheels for collected packages: dlib
  Building wheel for dlib (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /home/jarvis/bench-tony/faceModel/3DDFA/venv/bin/python3.6 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-d2v1rlm3/dlib/setup.py'"'"'; __file__='"'"'/tmp/pip-install-d2v1rlm3/dlib/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-kgvl7h9n
       cwd: /tmp/pip-install-d2v1rlm3/dlib/
  Complete output (85 lines):
  running bdist_wheel
  running build
  Detected Python architecture: 64bit
  Detected platform: linux
  Configuring cmake ...
  -- The C compiler identification is GNU 7.5.0
  -- The CXX compiler identification is GNU 7.5.0
  -- Check for working C compiler: /usr/bin/cc
  -- Check for working C compiler: /usr/bin/cc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Check for working CXX compiler: /usr/bin/c++
  -- Check for working CXX compiler: /usr/bin/c++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
    Imported targets and dependency information not available for Boost version
    (all versions older than 1.33)
  Call Stack (most recent call first):
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
    /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:61 (FIND_PACKAGE)
    CMakeLists.txt:9 (include)
  CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1626 (message):
    No header defined for python-py34; skipping header check
  Call Stack (most recent call first):
    /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:61 (FIND_PACKAGE)
    CMakeLists.txt:9 (include)
  -- Could NOT find Boost
  CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
    Imported targets and dependency information not available for Boost version
    (all versions older than 1.33)
  Call Stack (most recent call first):
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
    /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:63 (FIND_PACKAGE)
    CMakeLists.txt:9 (include)
  CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1626 (message):
    No header defined for python-py35; skipping header check
  Call Stack (most recent call first):
    /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:63 (FIND_PACKAGE)
    CMakeLists.txt:9 (include)
  -- Could NOT find Boost
  CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
    Imported targets and dependency information not available for Boost version
    (all versions older than 1.33)
  Call Stack (most recent call first):
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
    /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:66 (FIND_PACKAGE)
    CMakeLists.txt:9 (include)
  CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1626 (message):
    No header defined for python3; skipping header check
  Call Stack (most recent call first):
    /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:66 (FIND_PACKAGE)
    CMakeLists.txt:9 (include)
  -- Could NOT find Boost
  CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
    Imported targets and dependency information not available for Boost version
    (all versions older than 1.33)
  Call Stack (most recent call first):
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
    /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
    /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:69 (FIND_PACKAGE)
    CMakeLists.txt:9 (include)
  -- Could NOT find Boost
  -- Found PythonLibs: /usr/local/lib/libpython3.5m.a (found suitable version "3.6.9", minimum required is "3.4")
  --  *****************************************************************************************************
  --  To compile Boost.Python yourself download boost from boost.org and then go into the boost root folder
  --  and run these commands:
  --     ./bootstrap.sh --with-libraries=python
  --     ./b2
  --     sudo ./b2 install
  --  *****************************************************************************************************
  CMake Error at /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:116 (message):
     Boost python library not found.
  Call Stack (most recent call first):
    CMakeLists.txt:9 (include)
  -- Configuring incomplete, errors occurred!
  See also "/tmp/pip-install-d2v1rlm3/dlib/tools/python/build/CMakeFiles/CMakeOutput.log".
  error: cmake configuration failed!
  ----------------------------------------
  ERROR: Failed building wheel for dlib
  Running setup.py clean for dlib
Failed to build dlib
Installing collected packages: dlib
    Running setup.py install for dlib ... error
    ERROR: Command errored out with exit status 1:
     command: /home/jarvis/bench-tony/faceModel/3DDFA/venv/bin/python3.6 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-d2v1rlm3/dlib/setup.py'"'"'; __file__='"'"'/tmp/pip-install-d2v1rlm3/dlib/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-66wc9vih/install-record.txt --single-version-externally-managed --compile --install-headers /home/jarvis/bench-tony/faceModel/3DDFA/venv/include/site/python3.6/dlib
         cwd: /tmp/pip-install-d2v1rlm3/dlib/
    Complete output (86 lines):
    running install
    running build
    Detected Python architecture: 64bit
    Detected platform: linux
    Removing build directory /tmp/pip-install-d2v1rlm3/dlib/./tools/python/build
    Configuring cmake ...
    -- The C compiler identification is GNU 7.5.0
    -- The CXX compiler identification is GNU 7.5.0
    -- Check for working C compiler: /usr/bin/cc
    -- Check for working C compiler: /usr/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Check for working CXX compiler: /usr/bin/c++
    -- Check for working CXX compiler: /usr/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
      Imported targets and dependency information not available for Boost version
      (all versions older than 1.33)
    Call Stack (most recent call first):
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
      /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:61 (FIND_PACKAGE)
      CMakeLists.txt:9 (include)
    CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1626 (message):
      No header defined for python-py34; skipping header check
    Call Stack (most recent call first):
      /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:61 (FIND_PACKAGE)
      CMakeLists.txt:9 (include)
    -- Could NOT find Boost
    CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
      Imported targets and dependency information not available for Boost version
      (all versions older than 1.33)
    Call Stack (most recent call first):
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
      /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:63 (FIND_PACKAGE)
      CMakeLists.txt:9 (include)
    CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1626 (message):
      No header defined for python-py35; skipping header check
    Call Stack (most recent call first):
      /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:63 (FIND_PACKAGE)
      CMakeLists.txt:9 (include)
    -- Could NOT find Boost
    CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
      Imported targets and dependency information not available for Boost version
      (all versions older than 1.33)
    Call Stack (most recent call first):
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
      /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:66 (FIND_PACKAGE)
      CMakeLists.txt:9 (include)
    CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:1626 (message):
      No header defined for python3; skipping header check
    Call Stack (most recent call first):
      /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:66 (FIND_PACKAGE)
      CMakeLists.txt:9 (include)
    -- Could NOT find Boost
    CMake Warning at /usr/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):
      Imported targets and dependency information not available for Boost version
      (all versions older than 1.33)
    Call Stack (most recent call first):
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
      /usr/share/cmake-3.10/Modules/FindBoost.cmake:1558 (_Boost_MISSING_DEPENDENCIES)
      /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:69 (FIND_PACKAGE)
      CMakeLists.txt:9 (include)
    -- Could NOT find Boost
    -- Found PythonLibs: /usr/local/lib/libpython3.5m.a (found suitable version "3.6.9", minimum required is "3.4")
    --  *****************************************************************************************************
    --  To compile Boost.Python yourself download boost from boost.org and then go into the boost root folder
    --  and run these commands:
    --     ./bootstrap.sh --with-libraries=python
    --     ./b2
    --     sudo ./b2 install
    --  *****************************************************************************************************
    CMake Error at /tmp/pip-install-d2v1rlm3/dlib/dlib/cmake_utils/add_python_module:116 (message):
       Boost python library not found.
    Call Stack (most recent call first):
      CMakeLists.txt:9 (include)
    -- Configuring incomplete, errors occurred!
    See also "/tmp/pip-install-d2v1rlm3/dlib/tools/python/build/CMakeFiles/CMakeOutput.log".
    error: cmake configuration failed!
    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/jarvis/bench-tony/faceModel/3DDFA/venv/bin/python3.6 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-d2v1rlm3/dlib/setup.py'"'"'; __file__='"'"'/tmp/pip-install-d2v1rlm3/dlib/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-66wc9vih/install-record.txt --single-version-externally-managed --compile --install-headers /home/jarvis/bench-tony/faceModel/3DDFA/venv/include/site/python3.6/dlib Check the logs for full command output.

You can try a higher version of Dlib

pip install dlib==19.17 works on Ubuntu 18.04.

@yuxwind Thanks for your feedback. BTW, I recommend 3DDFA_V2, with a much better face detector.

@cleardusk Thanks for your recommendation. Actually, I came from 3DDFA_V2. As it has not provided the data preprocessing for training yet, I hope to get them here. Would you plan to release its training recently?


bug: adapter doesn't recursively create directories

This adapter requires a directory to work, but if the directory is nested ie /tmp/storage/dir and storage doesn't exist, this adapter throws an error. This adapter should instead recursively create the directories.

Fixed in f0dc9437c6561a2d246491e1f1ae0a961c619406


Smoothing of unused bars (Suggestion)

When trying to match the monstercat visualizer on their youtube channel, I noticed that unused bars which on the rainmeter skin are at volume 0 are otherwise smoothed out in youtube. For example when playing Who's Got Your Love, the last few bars often are resting at 0, when in the video they seem to decay downwards to smooth it out.

Thanks for your feedback!
I've already tried this in the past with no real results, as the problem is that the visualizer in these videos is prerendered and the skin is realtime and thus it will look better because it can propertly calculate the heights of the bars. This is not that easily achievable on the skin as it needs additional CPU usage which might destroy the performance on lower-end machines.
I will take a look in the next few days if i can implement something similar, but it might simply not possible to do.

If it's possible, it would be a nice feature for those who do have good enough CPUs. Maybe an ultra version or some other alternate release could be done if it isn't too much work for you?


Exported object names not minified since 5.79

Discussed in https://github.com/webpack/webpack/discussions/17988

Originally posted by vjhebbar January 21, 2024
Hello,
Since I updated to webpack 5.79+ in my project, bundle sizes have increased because some exported object names are not minified.
It turns out that this is due to those objects being destructured in modules where they are imported.
Refactoring the code to remove the object destructuring minimizes the name again.
Prior to 5.79, the names were minified regardless of the use of destructuring.
Is this behavior aligned with #16941?
If this is not expected behavior, I'll share my configs and minimum reproducible code.
Looking forward to your thoughts and suggestions.
The latest version where the issue is reproducible is 5.90.

Repo: https://github.com/vjhebbar/webpack579test

The root is that canMangle is set to false in lib/dependencies/HarmonyImportDependencyParserPlugin.js.
Should this flag be set according to the mangleExports optimization value?


LOWERREAGENTCOST Not work good (2 Issue)

Hello i have Two issue connected on LOWERREAGENTCOST
.set LOWERREAGENTCOST 10 and LOWERMANACOST 10 to a robe, for now all right:

After i equip and check if correct "bonus" placed on char whit item equipped by xshow LOWERMANACOST  and LOWERREAGENTCOST

LOWERREAGENTCOST not set on char when item equipped.
Second issue:
I manual set LOWERREAGENTCOST on a char and for now all ok.
I make two test:
.set LOWERREAGENTCOST 100
Ok i can cast whitout reags.
.set LOWERREAGENTCOST 50
Some time tell me no reags and is ok other time (50% of LOWERREAGENTCOST) try to cast but frizz (call @abort spell trigger)

Fixed the first issue, will pull it soon.
But I can't replicate the second one (Abort)

I Confirm Issue 1 fixed.
For issue 2 i make some accurate test and make a way for reproduce it.
For now i can close issue.
Thx for fix


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2023-04-07)
Features

add mapz,slicez,stringz,zz (1b63b72)
add pathz (271f591)
add string util (4f2f4e9)
init readme (23985b6)
reduce complexity (78f6148)
try another update when not accept change (bfa389a)
update string test (7728079)
update string2 (dfd44bb)

Bug Fixes

module name (637f4f4)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/zev-zakaryan/go-util/releases/tag/v1.0.0 :sunflower:


[GSSoC'23] Wrong redirection on the logo Link

On clicking the logo UMatter on the Home Page redirects it to the 404 page.
I would like to fix the issue by redirecting it to the correct page.

I would like to work upon this issue , as I had already made some websites and had done that work .Please assign this issue to me under GSSoC'23


No spray for spray can

You can see people's spray cans but they don't do the motion for spraying the can or shaking it when they have it.

Need another packet for this, it's a bit more complex than I initially thought it'd be. I'll look at it when I'm able to.

(We didn't need another packet)


Only 1 block is dropped

I'm using PaperMC which is a Spigot fork, and when I chop the bottom block for trees it only provides that block and makes all others disappear.. I'm sure this isn't intended and would like some help getting it to work as it should.

What do you mean by that it only "provides" that block?

What do you mean by that it only "provides" that block?

The block you break to get the whole tree to "fall" is the only piece of the tree that drops. So if a tree has 4 blocks of oak you only get 1/4 oak logs.

This is an issue with papermc


Use hash_tree_root everywhere

And get rid of merkle_root. This is possible because of SSZ tuples.

I don't see how this can be valid python. hash_tree_root for non-SSZ-containers doesn't distinguish between fixed size and variable size lists, but the spec does. Maybe add an optional typ argument to hash_tree_root ?

I defined a new SSZ object :)

I'll make sure this runs in the executable spec before merging

lol found a couple of other bugs when running the state transition through many empty epochs! patching a fix in another PR


Which feature extractor do you use to get the result in table2?

It seems that the feature extractor is not claimed for the results in table2. Should it be graph wavenet (GWN)?
I would be grateful if you could provide clarification on this problem.

In Table 2, we did the ablation study based on GRU feature extractor.

Does this imply that the optimal result for ST-GFSL was achieved using GRU as the feature extractor?

Nope, ST-GFSL is a universal framework, which can be combined with any feature extractor.

I'm sorry that I fail to clearly clarify my confuse. Of course I know that ST-GFSL is a universal framework. What I mean is which feature extractor is combined with to get the result for ST-GFSL on Table 2?
I believe that you choose the proper feature extractor to make the ST-GFSL achieve the best result.

In Table 2, we directly use GRU model as feature extractor. ST-GFSL shows consistently performance improvement in most feature extractors.

Thank you for your patient reply !


compilation warning when building on windows

libyara\filemap.c(155,21): warning C4293: '>>': shift count negative or too big, undefined behavior

I'm cross compiling with clang-cl with /O2, and this is definitively causing UB for me.
The code in question is the following:
// filemap.c
#if defined(_WIN32) || defined(__CYGWIN__)

YR_API int yr_filemap_map_fd(
    ...,
    off_t offset,
    ...,
    ...)
{
     ...
    MapViewOfFile(
        ...,
        ...,
        offset >> 32,
        offset & 0xFFFFFFFF,
        ...);
    ...
}

#endif

It turns out that on windows, off_t is a 32bit integer on both x86 and x64, and the C standard specifies that shifting any type by its size or more is UB.
On x64 with /O2, LLVM emits a warning but optimizes it away and never resets r8 (third arg) to 0 before calling MapViewOfFile. r8 being considered as volatile by the ABI, its value is whatever the previous function call left in it, which is garbage, and MapViewOfFile then fails with "invalid size" as an error.
I'm creating a PR to fix this.


nasa-veda regenerate CD credentials

Fixes #2434

Sigh Error: API rate limit exceeded for installation ID ....

Tested with manual staging deploy per issue