[JA DateTime] How to suggest spec bug fix?

Is your feature request related to a problem? Please describe.
I'm glad that this project has excellent translated Japanese DateTime Spec even though Patterns have some Chinese-only phrases and grammar which is clearly not Japanese ones...
However, I found some bugs on spec. Let's take a look at an example on DatePeriodParser.json:
  {
    "Input": "10月2日から10月22日まで不在にします。",
    "Context": {
      "ReferenceDateTime": "2016-11-07T00:00:00"
    },
    "NotSupported": "dotnet",
    "NotSupportedByDesign": "javascript,python,java",
    "Results": [
      {
        "Text": "10月2日から10月22日まで",
        "Type": "daterange",
        "Value": {
          "Timex": "(XXXX-10-02,XXXX-10-22,P20D)",
          "FutureResolution": {
            "startDate": "2017-10-02",
            "endDate": "2017-10-22"
          },
          "PastResolution": {
            "startDate": "2016-10-02",
            "endDate": "2016-10-22"
          }
        },
        "Start": 12,
        "Length": 25
      }
    ]
  },

Extracted string doesn't begin at index 12, it's from the beginning. And length is 15, not 22. This kind of bugs are easily fixable, I believe. A bit tough example is something like this:
  {
    "Input": "私は1日の日曜日に戻ります",
    "Context": {
      "ReferenceDateTime": "2017-09-27T00:00:00"
    },
    "NotSupportedByDesign": "dotNet, javascript, python, java",
    "Results": [
      {
        "Text": "1日の日曜日",
        "Type": "date",
        "Value": {
          "Timex": "2017-09-03",
          "FutureResolution": {
            "date": "2017-09-03"
          },
          "PastResolution": {
            "date": "2017-09-03"
          }
        },
        "Start": 2,
        "Length": 6
      }
    ]
  },

Here we can see "1日の日曜日" but let's see another example on same spec file:
  {
    "Input": "7月の第1金曜日に戻ります。",
    "Context": {
      "ReferenceDateTime": "2016-11-07T00:00:00"
    },
    "NotSupported": "dotnet",
    "NotSupportedByDesign": "javascript,python,java",
    "Results": [
      {
        "Text": "7月の第1金曜日",
        "Type": "date",
        "Value": {
          "Timex": "XXXX-07-WXX-5-#1",
          "FutureResolution": {
            "date": "2017-07-07"
          },
          "PastResolution": {
            "date": "2016-07-01"
          }
        },
        "Start": 13,
        "Length": 24
      }
    ]
  }

Way of describing 'nth weekday' in Japanese form is later one, not previous one. This kind of grammatical error on Spec needs to be fixed, I believe.
Toughest ones might be something like this:
  {
    "Input": "私は2016年04月21日の午後8:00に戻ります",
    "Context": {
      "ReferenceDateTime": "2016-11-07T00:00:00"
    },
    "NotSupportedByDesign": "dotnet,javascript,python,java",
    "Results": [
      {
        "Text": "04/21/2016, 8:00pm",
        "Type": "datetime",
        "Value": {
          "Timex": "2016-04-21T20:00",
          "FutureResolution": {
            "dateTime": "2016-04-21 20:00:00"
          },
          "PastResolution": {
            "dateTime": "2016-04-21 20:00:00"
          }
        },
        "Start": 2,
        "Length": 18
      }
    ]
  },

Extracted string should be 2016年04月21日の午後8:00. Input text is well translated. But, unfortunately, result text part isn't translated.
Describe the solution you'd like
I personally made some patches to fix these bugs, but since I'm a Python user and there isn't Python Japanese DateTime model available yet, I'm not sure the way to validate my patch.
Even worse, I only have a Ubuntu machine, so it's not easy for me to figure out how to run some tests on other Programming languages, such as DotNet. (I found that there is some problem running DotNet package of this project on Ubuntu, some kind of version problem.)
So I need a guide how to create a pull request with ensured quality check.
Describe alternatives you've considered
Or someone other than me could fix those bugs in Spec and make proper full request... I made a dirty script fix_spec_error.zip to automatically fix some trivial Spec error. Of course this lacks with some other spec bug fix.
Additional context
Of course, it would be very appreciated if someone would guide me how to make pull request by my own. Of course I've already read Contributing guide but it only tells about JavaScript and DotNet, not about other Programming language, and I'm keep failing to run DotNet ones on my local machine...
Thanks for reading.

Unfortunately Japanese datetime is not complete in any platforms, so there's no way to validate spec changes.
But we would be very happy to review your changes and merge them in. Could you create a PR just changing the relevant specs?

@tellarin Of course. I'll create one within 48 hours :)

Oops. 48 hours become more than 72 hours.

No worries, @combacsa. Thanks a lot!


DataWedge data output

Hi,
I have xamarin forms app using zebra scanner.
Every scan is supposed to populated the listview only.
But beside the listview , every entry box with focus is getting populated .
Any reason ?
In the main activity , i have 👍 _broadcastReceiver = new DataWedgeReceiver();
App scannerApp = new App();
_broadcastReceiver.scanDataReceived += (s, scanData) =>
{
MessagingCenter.Send<App, string>(scannerApp, "ScanBarcode", scanData);
};
In my contentPage i have :
MessagingCenter.Subscribe<App, string>(this, "ScanBarcode", (sender, arg) => {
var message = arg.ToString();
Device.BeginInvokeOnMainThread(() => {
                if (JobsCollection.Any(p => p.TicketNo == message.Trim())) { return; }
                JobsCollection.Add(new Job { TicketNo = message.Trim() });
                scanPage.Title = "Scanned:" + JobsCollection.Count();
            });

        });

Thanks

Hi,

But beside the listview , every entry box with focus is getting populated .

You probably have the keystroke output turned on in your DataWedge profile, you need to use Intent output and configure your application broadcast receiver appropriately

Hi,

But beside the listview , every entry box with focus is getting populated .

You probably have the keystroke output turned on in your DataWedge profile, you need to use Intent output and configure your application broadcast receiver appropriately

Hi,
Is turning off keystroke output  enough ?
How can I use Intent output and configure your application broadcast
receiver  using xamarin ?
Or do I have to do that in profile ?
Thanks
On Thu, Jan 21, 2021 at 2:57 AM Darryn<EMAIL_ADDRESS>wrote:

Hi,
But beside the listview , every entry box with focus is getting populated .
You probably have the keystroke output turned on in your DataWedge
profile, you need to use Intent output and configure your application
broadcast receiver appropriately
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/darryncampbell/DataWedge-Intent-Example-1/issues/1#issuecomment-764453583,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVJCIM7BQYHSGBMIEF6TLS27NABANCNFSM4WLI2DGA
.

--
CISSE M. Y.
Sofware/Web Developer
Phone :(347) 443-9028

Hi,
Is turning off keystroke output  enough ?
How can I use Intent output and configure your application broadcast
receiver  using xamarin ?
Or do I have to do that in profile ?
Thanks
On Thu, Jan 21, 2021 at 2:57 AM Darryn<EMAIL_ADDRESS>wrote:

Hi,
But beside the listview , every entry box with focus is getting populated .
You probably have the keystroke output turned on in your DataWedge
profile, you need to use Intent output and configure your application
broadcast receiver appropriately
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/darryncampbell/DataWedge-Intent-Example-1/issues/1#issuecomment-764453583,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVJCIM7BQYHSGBMIEF6TLS27NABANCNFSM4WLI2DGA
.

--
CISSE M. Y.
Sofware/Web Developer
Phone :(347) 443-9028

Please take a look at this guide to help get started: https://medium.com/@darryncampbell_83863/getting-started-with-datawedge-on-zebra-devices-9af2cdd1110c

Please take a look at this guide to help get started: https://medium.com/@darryncampbell_83863/getting-started-with-datawedge-on-zebra-devices-9af2cdd1110c


Filter order issues

In ExtensionLoader , user's <dubbo:service /> filters always after @Activate filters ,
Why not order them together?
@Activate doesn't means that it's internal, also may be user's custom filter, right? Now, when I have @Activate and <dubbo:service /> config both, the order is not work between them any more.

@wujun8 IMO, if your Filter with Annotation Activate, it will be activated by default. You do not need to config like <dubbo:service filter="f1,f2"/>.
@Activate doesn't means that it's internal, also may be user's custom filter, right?
/// Yes, u r right. But once your filter with this annotation, it will be performed.
u can refer this doc: http://dubbo.apache.org/zh-cn/docs/dev/impls/filter.html
If you want to activate a filter on a specify service, don't use the annotation.

OK, annotation only applies to certain filter that exec before filters on a specify service, or don't use annotation.


Remove unused tags variable from network module

It appears the tags variable was added to the network module in error. Additionally, it's not possible to add tags to a network or subnet.

add to whitelist


Upgraded Event hubs SDK

Upgrade the Event Hubs SDK from Microsoft.Azure.EventHubs to Azure.Messaging.EventHubs.

:white_check_mark: Build ServiceBusExplorer 5.1.0-UpgradeEventHubsSdk.2.build.740 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/f654ae5956 by @)

:white_check_mark: Build ServiceBusExplorer 5.1.0-UpgradeEventHubsSdk.7.build.748 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/6c99cab0b5 by @)

:white_check_mark: Build ServiceBusExplorer 5.1.0-UpgradeEventHubsSdk.7.build.748 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/6c99cab0b5 by @)

:white_check_mark: Build ServiceBusExplorer 5.1.0-UpgradeEventHubsSdk.8.build.749 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/84828c04ae by @)

:white_check_mark: Build ServiceBusExplorer 5.1.0-UpgradeEventHubsSdk.8.build.749 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/84828c04ae by @)

:white_check_mark: Build ServiceBusExplorer 5.1.0-UpgradeEventHubsSdk.9.build.750 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/56135edac8 by @ErikMogensen)

:white_check_mark: Build ServiceBusExplorer 5.1.0-UpgradeEventHubsSdk.9.build.750 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/56135edac8 by @ErikMogensen)

@SeanFeldman can you please approve the change when you have time? Thanks :)

@SeanFeldman can you please approve the change when you have time? Thanks :)


raw git commands are failing with git exception

After updating to the latest version of git wrapper any raw git commands I attempt are failing.
For example:
$git = $this->gitWrapper->workingCopy($release);
$branch = $git->getBranches()->head();
$this->gitWrapper->git('push --set-upstream origin ' . $branch, $release);

I am sure there is a command to set the upstream but I had implemented this manually and after updating it now fails.

I don't use this repository lately, so I can't investigate propprely.
Where exactly it broke?

I am not sure. I know that the problem is probably that raw commands are getting parsed differently.
// built in command:
$branch = $git->getBranches()->head();
// result:
"exec '/usr/bin/git' 'rev-parse' '--abbrev-ref' 'HEAD'"

// raw command:
$this->gitWrapper->git('push --set-upstream-to origin ' . $branch, $release);
// result:
"exec '/usr/bin/git' 'push --set-upstream-to origin release/20190515-113224'"
// expected:
"exec '/usr/bin/git' 'push' '--set-upstream' 'origin' 'release/20190515-113224'"

I will have to step back through the code to figure out why this is getting parsed wrong. But if you know where that might be happing and can give me a pointer that would help.

I was able to get around this by using workingCopy->run() instead.
So this works for me:
$git = $this->gitWrapper->workingCopy($release);
 $branch = $git->getBranches()->head();
 $git->run('push', ['--set-upstream', 'origin', $branch]);

But any attempt to just run a raw git command is failing for me. I can see that absolutly no parsing happens on the command when using this method. Maybe the input simply needs a step to explode the input on spaces and implode it back to gether with ' ' as the glue or something like that.

Seeing the same problem over here after upgrading from version 2.1.0 to 2.2.0
I was able to trace the problem back to this PR: https://github.com/cpliakas/git-wrapper/pull/165
Reverting those changes makes it work again over here.
Bit strange, since the PR looks fine to me, so not exactly sure what the correct solution would be here ...

In our case, it's a pretty easy fix in our code to make it work in version 2.2.0:
-        $command = sprintf('ls-remote --heads %s %s', $repo, $branchName);
+        $command = new GitCommand('ls-remote', '--heads', $repo, $branchName);

-        $result = $this->getGitWrapper()->git($command);
+        $result = $this->getGitWrapper()->run($command);

Could you send PR?

@TomasVotruba: the code above is from our own codebase, not the one from this repo, that might not have been very clear.
I'm not sure what the best way would be to fix this in this repo to be honest.

In our case, it's a pretty easy fix in our code to make it work in version 2.2.0:
-        $command = sprintf('ls-remote --heads %s %s', $repo, $branchName);
+        $command = new GitCommand('ls-remote', '--heads', $repo, $branchName);

-        $result = $this->getGitWrapper()->git($command);
+        $result = $this->getGitWrapper()->run($command);

This still appears to be an issue. The adjustment to the above worked for me as well.
Running
$gitWrapper->git('status -s');

Yields an error stating that 'status -s' is not a command. Internally the argument isn't being broken up. This makes the README inaccurate as well.
Here's a bit more of what I did to get it working in case it helps someone.
$gitWrapper = new GitWrapper($git_binary_path);
$gitWrapper->setEnvVar('HOME', $home_path);
$command = new GitCommand('status', '-s');
$command->setDirectory($cwd);
return $gitWrapper->run($command);

The PR that fixes it has not been merged yet so it's pretty normal that it's still an issue...

What PR?

#174 but it depends on #176 to fix compatibility with the current version of symfony.


Update README.md

Hello World
Checklist

[ ] I have ensured my pull request is not behind the main or master branch of the original repository.
[ ] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[ ] I have written a commit message that passes commitlint linting.
[ ] I have ensured that my code changes pass linting tests.
[ ] I have ensured that my code changes pass unit tests.
[ ] I have described my pull request and the reasons for code changes along with context if necessary.

Hello World


GT Dungeon section on tracker

Support for a dungeon item for GT. This would replace the multi-Aga item and return it to be solely for Aga1.
GT has 20 item locations. Additionally all of the current checks for Aga(1) would now need to check for Aga1 or for GT to be completed.
Though most runners stop tracking items once in Go Mode, this would allow for completionists to continue to track all the way until the end, or for Entrance Randomizer runners to utilize the tracking in GT should it come up earlier in the game.

Completed with #16.


adapting a "Classification" network into a "Detection" network

Dear all,
I would like to adapt an existing network (e.g. Lenet) which is designed for the classification task into a network which will be used for object detection purposes (such as DetectNet). Any help on the steps to follow is greatly appreciated.
In particular, the adapted .prototxt file of Lenet for detection is very much welcome.
many thanks,
Shervin

@ShervinAr you can't do that with DIGITS. I recommend you to take a look at https://github.com/BVLC/caffe/blob/master/examples/net_surgery.ipynb and start from there. Also, the caffe-users group might be a better place to ask such things: https://groups.google.com/d/forum/caffe-users

Closing as this is not an issue in DIGITS.


Automated cherry pick of #6423: fix: 避免仅同步一个region时，其余region状态变为准备中

Cherry pick of #6423 on release/3.0.
#6423: fix: 避免仅同步一个region时，其余region状态变为准备中

Codecov Report

Merging #6426 into release/3.0 will increase coverage by 0.05%.
The diff coverage is 13.92%.

@@              Coverage Diff               @@
##           release/3.0   #6426      +/-   ##
==============================================
+ Coverage         6.85%   6.90%   +0.05%
==============================================
  Files              540     541       +1
  Lines            91509   91726     +217
==============================================
+ Hits              6270    6338      +68
- Misses           84719   84866     +147
- Partials           520     522       +2

Flag
Coverage Δ

#aFlag
6.90% <13.92%> (+0.05%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/appsrv/workers.go
65.46% <ø> (-0.25%)
:arrow_down:

pkg/baremetal/manager.go
0.50% <0.00%> (-0.01%)
:arrow_down:

pkg/baremetal/tasks/base.go
13.59% <0.00%> (-0.41%)
:arrow_down:

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/modelbase.go
1.44% <ø> (+0.02%)
:arrow_up:

pkg/cloudcommon/db/tenantcache.go
1.31% <0.00%> (ø)

pkg/cloudcommon/policy/policy.go
1.58% <0.00%> (+0.04%)
:arrow_up:

pkg/cloudprovider/cloudprovider.go
1.57% <ø> (ø)

pkg/compute/baremetal/diskconfig.go
60.14% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.80% <0.00%> (ø)

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6627a33...575545d. Read the comment docs.


Remove readability for the teams entity set

This PR:

Fixes https://github.com/microsoftgraph/msgraph-metadata/issues/237
Removes the GET operation for /teams
Ensures that the GET operation for /teams{team-id} remains.

PR is temporarily blocked by: https://github.com/microsoftgraph/msgraph-metadata/issues/282


ThorVG: Sync with upstream 0.8.0

Fixes: https://github.com/godotengine/godot/issues/58898

Checking on a bug https://github.com/Samsung/thorvg/issues/1205 upstream.

Thanks!


What if perform full page redirect instead of showing session lost error?

Currently if I press a morphed link after server restart (i.e. start/stop an app) an exception on console appears: Session lost. Server replied with a different session ID that was already set..
What if make full page redirect instead of showing that error?

I agree that this is a problem that needs to be solved. The proposed solution might be desired in production mode, but it masks the problem instead of solving it. And I am not sure if it is actually a problem.
A. It masks the problem instead of solving it
What you proposed is simply:

Client asks: give me /people/person/5
Server says: here is what you wanted, session id: AAAA
Client asks: please change the FirstName$ of this person
Server says: here is something, session id: BBBB
Client asks:  give me /people/person/5
Server says: here is what you wanted, session id: CCCC

Response at point 4 is only potentially a problem, because we don't know if this something is something we can trust to be a valid response. Did the server reset the session (which is probably an error) or does it only renew the session ID (which is probably fine)?
Currently, in this case, client shows an ugly error message Session lost.
B. I am not sure if it is actually a problem
As said above, renewing session ID is probably fine, as long as the server performs what it was asked to do. So instead of showing the error, the client should just apply the patch and replace this.remoteUrl with the new session id.
I think the real problem comes from the fact that server replaces the root object and that is something which should show an error or at least a warning.
@tomalec WDYT?

What about:

A.4.a. (server renewed same session, and identified both view-models)
Server says: here is what you wanted, change FullName, new session id: BBBB

A.5.a. Client applies patch, and updates this.remoteUrl

A.4.b. (server restarts the session, as something went wrong)
Server says: here you have full JSON viewm-model, and new session id: BBBB

A.5.b. Client may show an error.

@warpech but what should we do with "change the FirstName$" Patch in reset case?

The remaining question is how to identify the error case (b):

It is an error if a party replaces the root object
It is an error if a party sends a version number (_ver#s) lower or equal than the previously sent version number. So that after sending _ver#s: 5 it is considered an error to send _ver#s: 0

Solution 1 is somehow limiting but makes sense to me... Session is like serving food in one bowl. You can serve the food, replace the food, rename the bowl, wash the bowl to put new stuff there - but this is the same instance of the bowl (in our words: the same session root). Once you replace the bowl, the state is broken and this is an error.
Solution 2 relies on OT being enabled, which can be an additional check, but we cannot rely only on it.

:stew: I like the food story :)
Ad. 2. JSON Patch Queue already throws an error - https://github.com/PuppetJs/JSON-Patch-Queue/blob/gh-pages/src/json-patch-queue.js#L61

I propose the following solution:

If server replies with a patch that replaces the root (any patch where op is add/replace/delete and path is an empty string), PuppetJs calls console.error with Puppet error. The server replaced the session and then applies the patch.
The above situation should be overridable with a custom <template> which displays a friendly error message on the screen. Inside this template we may even put a <puppet-redirect url="current"> to achieve the solution proposed by @miyconst in his first message.
If server replies with a new session ID (remoteUrl), it is fine. PuppetJs should take it and replace the previous remoteUrl

WDYT?

I like the idea, but I'm not sure how would you override PuppetJS Js behaviour with HTML template

PuppetJs allows to provide a callback and PuppetDom uses that callback?

but Puppet-dom is still a pure JS script  not a custom element, and have nothing to do with template

PuppetDom is DOM-aware, as the name says... So it can support stamping out templates that are provided via options or as a child element of <puppet-client>.

Related: https://github.com/Starcounter/Starcounter/issues/3084

Right now Session is maintained with empty patches every 15 seconds. Closing this issue as outdated.


License metadata seems to be ignored

When I made the latest release of python-dateutil, it came along with a license change from BSD to Apache / BSD dual licensed.  I updated the license= metadata in setup.py, but I forgot to update the trove classifiers.
The page on PyPI shows the license as "Apache 2.0" as I would expect. The page on warehouse shows the license as "BSD License". I'm assuming it's pulling that from the trove classifier? Shouldn't it pull it from the license field if that is populated?

Thanks for raising @pganssle, this was indeed a small bug with the way we were handling the presence of licenses in both the Classifier field and the License field.
Based on the specification above, I would suggest the following setup.py for future releases:
setup(
    ...
    classifiers=[
        ....
        'License :: OSI Approved :: BSD License',
        'License :: OSI Approved :: Apache Software License',
        ....
    ],
    license = 'Dual License'
    ...
)

Which will show up on pypi.org as:

License: BSD License, Apache Software License (Dual License)

Also, in #pypa on IRC you said:

Did I screw this up? https://test.pypi.org/project/python-dateutil/
I'm listed as Author.
But setup.py has me as maintainer: https://github.com/dateutil/dateutil/blob/master/setup.py#L33

But looking at the metadata for the 2.7.0 source distribution, all I'm seeing is:
Author: Paul Ganssle
Author-email<EMAIL_ADDRESS>
which leads me to think that this was changed after you made the distribution file, but let me know if you're still having issues with it.

I think distutils or maybe setuptools has a bug where if you specify a maintainer it sets that as the author in the metadata.
Sent from my iPhone

On Mar 12, 2018, at 7:50 PM, Dustin Ingram<EMAIL_ADDRESS>wrote:
Thanks for raising @pganssle, this was indeed a small bug with the way we were handling the presence of licenses in both the Classifier field and the License field.
Based on the specification above, I would suggest the following setup.py for future releases:
setup(
...
classifiers=[
....
'License :: OSI Approved :: BSD License',
'License :: OSI Approved :: Apache Software License',
....
],
license = 'Dual License'
...
)
Which will show up on pypi.org as:
License: BSD License, Apache Software License (Dual License)
Also, in #pypa on IRC you said:
Did I screw this up? https://test.pypi.org/project/python-dateutil/
I'm listed as Author.
But setup.py has me as maintainer: https://github.com/dateutil/dateutil/blob/master/setup.py#L33
But looking at the metadata for the 2.7.0 source distribution, all I'm seeing is:
Author: Paul Ganssle
Author-email<EMAIL_ADDRESS>which leads me to think that this was changed after you made the distribution file, but let me know if you're still having issues with it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@di Thanks for the response. I updated the trove classifiers, I think your idea of changing license= to Dual License is a good idea, I'll do that shortly.
With regards to the maintainer/author thing, I've opened an issue about it: pypa/setuptools#1288, I'm also going to open one for distutils.

Yeah, that seems like a bug. Warehouse will correctly handle the presence of any or all of the Author/Maintainer metadata fields, if they're correctly provided.


adding three files and changing nevbar#156

Pull Request Format
PR Title:adding three files and changing nevbar
Issue #156 : creating different web pages for Game Controllers,VR Accessories and adding functionality to nav bar . #156 solved
Type of PR

Add X in the box to specify the improvement type.
[] Bug fix
[ X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): ___________

Description
i had created additional web pages for VR accossories,game controlling and for other section and improving nev bar where login button is not in sequence
Screenshots / Videos (if applicable)
Before:

After:

Checklist

Add X in the box to specify.
[] I have performed a self-review of my code.
[ X] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional Context
in nev bar nev items are in a line after change it is a asequence
Thank you for reviewing my pull request!

@Abhishek89chauhan Check if there is any problem with the css file.

please check it out i have fix it

sir please give a level

Mereg conflict. Solve that


jei support and levitation potion fix #1 #2

no clues on JEI support but https://github.com/Shadows-of-Fire/Apotheosis have implemented it

jei support was really easy in fact https://mcforge.readthedocs.io/en/latest/advanced/accesstransformers/

Hi, I didnt see this until now unfortunately. I will implement this when I update my mods. Thank you very much (I wont merge as the code style was messed up, probably due to an automatic cleanup by your ide)

fyi i've been using this patch and working well in my server since I made the PR so u know is well headed


AZCopy from Windows App Service Instance not working (ok if I use copy from Microsoft download page)

Which version of the AzCopy was used?
AzCopy 10.10.0
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
azcopy.exe  sync "E:\logfiles\GE" "https://xxx.file.core.windows.net/logs/?sv=xxx" --recursive
What problem was encountered?
I am developing a webjob, currently testing it locally on my development machine. I got the AzCopy.exe for Windows 64-bit from :
https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-v10
and this works locally (running debug from within VS 2019).
AZCOPY_WORKING.txt
However after publishing the webjob, it was not working, no errors given. I could see my logs for started job, completed job but I could not see any information regarding az copy being executed (i.e. Files Scanned at Source , at Destination, etc
So I downloaded the "AzCopy.exe" from within the Windows App Service instance at D:\devtools\AzCopy\AzCopy.exe (which also appears to be AzCopy 10.10.0), and again tested the webjob locally running on debug and it is not working, again no errors and I can see my logs as everything being completed but no file transfer is occurring.
AZCOPY_NOT_WORKING.txt
If I put back the AzCopy.exe that I got from  https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-v10, then everything starts to work and I can see the files being scanned, transferred, etc
Any help will be greatly appreciate

So for reference, manually placing azcopy into the app service works? Are you perhaps not packaging it with your app service on accident?
Hit properties on the executable in VS and make sure you have copy to output directory set to either "Always copy" or "Copy if newer".

I did not test that. My intention was to use the AzCopy that is already within the app service dev tools, rather than deploying another one (which in theory is the same?) with the webjob, Maybe I should conduct this test as a work around solution.
I would really like to understand why they are behaving differently even though they appear to be the same version, or another way of asking, is the AzCopy.exe within the app service devtools the same as the one we can download from microsoft download page?

I also use azcopy in an Azure App Service. I found out that the vm has two versions of azcopy, both old:
D:\home>D:\devtools\AzCopy\AzCopy.exe /?
------------------------------------------------------------------------------
AzCopy 6.3.0 Copyright (c) 2017 Microsoft Corp. All Rights Reserved.
------------------------------------------------------------------------------

D:\devtools\AzCopy>D:\devtools\AzCopy8\AzCopy.exe /?
------------------------------------------------------------------------------
AzCopy 8.1.0-netcore Copyright (c) 2018 Microsoft Corp. All Rights Reserved.
------------------------------------------------------------------------------

So I had to ship my own version of azcopy.


I got a message ERROR 404.

Hello, I got some errors and I try your code on postman and its not worked.
my URL was http://localhost:8080/jwtrest/api/auth/login, firstly I changed my base_url to http://localhost:8080/jwtrest/ Please help me, I am looking forward for your help

can you be more specific please ?
actually you don't need to change your base_url, because it's already dynamic.

@mokongs now you can use it without index.php. i've add htdocs file


[Removal]: Hidden Blue Ant

Hotspot Name
hidden-blue-ant
Hotspot b58 Address
11QN78zNFye3UvnPLfvPrbJmkkf3Wyxi2CesZdeyJ5bvqJNy9SY
Discord Handle
No response
Hotspot Manufacturer
PantherX
Removal Reason
I set up the hotspot in the real location to provide the real coverage
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
hi helium team, I have just started mining crypto coins and wanted to get in on helium. so, i bought 4 miners from the secondary market and get them yesterday. But soon after i realized it could not mine and had no activity, i thought it was an issue on my end. After that I discovered about the deny list and all the miners were on it… (probably why it was so cheap) please check my location again with your algorithm, i set up my miners in real locations to provide the true coverage. This one was set up yesterday on the roof of my house with an antennas.

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Adds versioned benchmarking

Allows the benchmarking project to reference Nest.v7 and so makes it easier for us to benchmark proposed changes.
Isolated from #4172 and #4191 which both grew to be too big to review

@codebrain @russcam please review this first, opened a bunch of PR's today but this one is one that I would really like to be in tomorrow so I can start doing PR's with benchmarks.

I opened https://github.com/elastic/elasticsearch-net/pull/4213 to address the integration test failures in this PR.


Encoding issues when displaying entities

see http://infolis.gesis.org/infolink/api/textualReference/74b597d0-914f-11e5-b6a5-7ff80ae297d2)
is it an issue when displaying or before that?

I'll check whether it's stored right.

src/test/resources/examples/minimal-txt/41da55fa6d533c726ec1d543ac18978a: Non-ISO extended-ASCII text, with LF, NEL line terminators
It's obviously not UTF-8 encoded, like several other files under src/test/resources/examples.
Would a conversion to UTF-8 fix the problem?

it is stored with the broken umlauts:
{
        "_id" : "74b597d0-914f-11e5-b6a5-7ff80ae297d2",
        "leftText" : "�ber unionsb�rgerschaftsrelevante Einstellungen gibt das",
        "rightText" : "aus dem Jahr 1996. Die",
        "reference" : "Eurobarometer 46.0",
        "pattern" : "http://infolis.gesis.org/infolink/api/infolisPattern/d2ec7fc0-8f48-11e5-9bfb-37e8acc5d407",
        "mentionsReference" : "http://infolis.gesis.org/infolink/api/entity/744808f0-914f-11e5-b6a5-7ff80ae297d2",
        "rightWords" : [
                "aus",
                "dem",
                "Jahr",
                "1996.",
                "Die"
        ],
        "leftWords" : [
                "�ber",
                "unionsb�rgerschaftsrelevante",
                "Einstellungen",
                "gibt",
                "das"
        ],
        "__v" : 0
}

@stweil Those were generated by the same tools we're using for pdf-to-text. If we fix these test files our unit tests might work, but the problem isn't solved.

setting the java default file encoding to utf8 did the trick to solve encoding issues for textextraction on the server, lets see whether it can help here as well
(export JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF-8), see https://github.com/infolis/infoLink/issues/28

This was fixed by setting the JAVA_TOOL_OPTIONS. Fix is documented in our devop pad, closing for now. Open a new issue if you encounter encoding issues on new resources.


When testing CANotifier we need user accounts for ourselves so we can QA and usability test.

What?

Without SMS we can't validate our accounts
We need to have everyone an account with their email that is active and can be used.

Why?

if we are going to review and test it we need to be able to get into the system
if we are going to have people Usability test we need to grant them access

@YedidaZalik @sboots @brdunfield @AntoineGarciaSuarez @damcom333  please make accounts on notifier.cdssandbox.xyz

Everyone should now make and have accounts on Notification.cdssandbox.xyz as per the comment in the Platform slack channel.


feat: add config settings to support PR #72

Description
All of the actual work is over in craft-plugin-vite!

Thanks for the PR! A few comments:

I wonder if we can just use the manifestPath here rather than add a new dist property? They will both always point to the same thing, and we can just strip the manifest.json off of it, and things will "just work" without people needing to reconfigure anything or adding a mostly redundant additional config setting.

(In retrospect, it would have made sense from the beginning to have just a dist property, and determine the manifest from there but... alas that ship has sailed).

This plugin has both a Craft v3 and a Craft v4 version, so I'll need to port any changes to develop to develop-v4 also, or you can do dual PRs

The documentation needs to be updated for both Craft v3 and Craft v4

I'm happy to do the latter 2 bullet points, but want to figure out the first one before proceeding

I wonder if we can just use the manifestPath here rather than add a new dist property? They will both always point to the same thing, and we can just strip the manifest.json off of it, and things will "just work" without people needing to reconfigure anything or adding a mostly redundant additional config setting.

Stripping manifestPath makes sense to me! The new config does seem a bit redundant (isn't hindsight a bastard) and the impact will be minimal, as it only affects people using this new option!

Do you want to make the changes to the PR? You have a test case that you can confirm works, ya?


encoder_hidden_states error since upgrade?

This was working earlier today. I upgraded ConmfyUI & all custom nodes & now I get this when it hits the KSampler
VanillaTemporalModule.forward() missing 1 required positional argument: 'encoder_hidden_states'
Entire error:
[AnimateDiffEvo] - INFO - Removing motion module adStabilizedMotion_stabilizedHigh.pt from cache
!!! Exception during processing !!!
Traceback (most recent call last):
File "E:\ComfyUI\execution.py", line 152, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "E:\ComfyUI\execution.py", line 82, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "E:\ComfyUI\execution.py", line 75, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "E:\ComfyUI\nodes.py", line 1270, in sample
return common_ksampler(model, noise_seed, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, denoise=denoise, disable_noise=disable_noise, start_step=start_at_step, last_step=end_at_step, force_full_denoise=force_full_denoise)
File "E:\ComfyUI\nodes.py", line 1206, in common_ksampler
samples = comfy.sample.sample(model, noise, steps, cfg, sampler_name, scheduler, positive, negative, latent_image,
File "E:\ComfyUI\custom_nodes\ComfyUI-Impact-Pack\modules\impact\sample_error_enhancer.py", line 9, in informative_sample
return original_sample(*args, **kwargs)
File "E:\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\sampling.py", line 161, in animatediff_sample
return wrap_function_to_inject_xformers_bug_info(orig_comfy_sample)(model, *args, **kwargs)
File "E:\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\model_utils.py", line 162, in wrapped_function
return function_to_wrap(*args, **kwargs)
File "E:\ComfyUI\comfy\sample.py", line 97, in sample
samples = sampler.sample(noise, positive_copy, negative_copy, cfg=cfg, latent_image=latent_image, start_step=start_step, last_step=last_step, force_full_denoise=force_full_denoise, denoise_mask=noise_mask, sigmas=sigmas, callback=callback, disable_pbar=disable_pbar, seed=seed)
File "E:\ComfyUI\comfy\samplers.py", line 785, in sample
return sample(self.model, noise, positive, negative, cfg, self.device, sampler(), sigmas, self.model_options, latent_image=latent_image, denoise_mask=denoise_mask, callback=callback, disable_pbar=disable_pbar, seed=seed)
File "E:\ComfyUI\comfy\samplers.py", line 690, in sample
samples = sampler.sample(model_wrap, sigmas, extra_args, callback, noise, latent_image, denoise_mask, disable_pbar)
File "E:\ComfyUI\comfy\samplers.py", line 630, in sample
samples = getattr(k_diffusion_sampling, "sample_{}".format(sampler_name))(model_k, noise, sigmas, extra_args=extra_args, callback=k_callback, disable=disable_pbar, **extra_options)
File "D:\Python\Python310\lib\site-packages\torch\utils_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "E:\ComfyUI\comfy\k_diffusion\sampling.py", line 137, in sample_euler
denoised = model(x, sigma_hat * s_in, **extra_args)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "E:\ComfyUI\comfy\samplers.py", line 323, in forward
out = self.inner_model(x, sigma, cond=cond, uncond=uncond, cond_scale=cond_scale, cond_concat=cond_concat, model_options=model_options, seed=seed)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1501, in call_impl
return forward_call(*args, **kwargs)
File "E:\ComfyUI\comfy\k_diffusion\external.py", line 125, in forward
eps = self.get_eps(input * c_in, self.sigma_to_t(sigma), **kwargs)
File "E:\ComfyUI\comfy\k_diffusion\external.py", line 151, in get_eps
return self.inner_model.apply_model(*args, **kwargs)
File "E:\ComfyUI\comfy\samplers.py", line 311, in apply_model
out = sampling_function(self.inner_model.apply_model, x, timestep, uncond, cond, cond_scale, cond_concat, model_options=model_options, seed=seed)
File "E:\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\sampling.py", line 535, in sliding_sampling_function
cond, uncond = calc_cond_uncond_batch(model_function, cond, uncond, x, timestep, max_total_area, cond_concat, model_options)
File "E:\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\sampling.py", line 431, in calc_cond_uncond_batch
output = model_function(input_x, timestep, **c).chunk(batch_chunks)
File "E:\ComfyUI\comfy\model_base.py", line 63, in apply_model
return self.diffusion_model(xc, t, context=context, y=c_adm, control=control, transformer_options=transformer_options).float()
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "E:\ComfyUI\custom_nodes\FreeU_Advanced\nodes.py", line 173, in __temp__forward
h = forward_timestep_embed(module, h, emb, context, transformer_options)
File "E:\ComfyUI\comfy\ldm\modules\diffusionmodules\openaimodel.py", line 61, in forward_timestep_embed
x = layer(x)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
TypeError: VanillaTemporalModule.forward() missing 1 required positional argument: 'encoder_hidden_states'

This error typically happens when you have both AnimateDiff-Evolved extension as well as the ArtVentureX version. Check your custom_nodes folder that you only have ComfyUI-AnimateDiff-Evolved and not ComfyUI-AnimateDiff

Another potential conflict is if you have "FreeU_Advanced" installed (reported by Dr. Lt. Data on discord).

I disabled the ArtVentureX but the problem persists.
Now I have deleted the folder & also del'd the FreeU.
Now it worked fine. Thanks.

Hey, I think FreeU Advanced custom node will now work if you pull latest version of AnimateDiff-Evolved! Let me know if it works for you now!


AMQ-8049: Failed to start Apache ActiveMQ (mKahaDB / JMX)

When using filtered adapter for topics or queues with perDestination on catch all, after restart it is possible to have duplicated adapters when there are destinations in metadata and as a result start will fail. Perdestination should not start adapter for directory read from filesystem which is already defined in configured adapters.

Let me take a look on this one. For the tests, it's possible we still have some flaky tests, let me do a pass on these tests.

How does the error occur when the adapters are added via directory listing? There should not be duplication.

When you have configuration like:
<persistenceAdapter> 	<mKahaDB directory="${activemq.data}/kahadb"> 		<filteredPersistenceAdapters> 			<!-- kahaDB per destinations --> 			<filteredKahaDB perDestination="true"> 				<persistenceAdapter> 					<kahaDB> 						... 					</kahaDB> 				</persistenceAdapter> 			</filteredKahaDB> 			<filteredKahaDB topic="STOMP.>"> 				<persistenceAdapter> 					<kahaDB> 						... 					</kahaDB> 				</persistenceAdapter> 			</filteredKahaDB> 		</filteredPersistenceAdapters> 	</mKahaDB> </persistenceAdapter>
On first start everything works fine, but after restart in
org.apache.activemq.store.kahadb.MultiKahaDBPersistenceAdapter#doStart
you first go through 'matchAll' and for this example topic store in
org.apache.activemq.store.kahadb.MultiKahaDBPersistenceAdapter#registerExistingAdapter
you register and start adapter (as destinations.size() != 0)
and when you get to
   File[] candidates = template.getPersistenceAdapter().getDirectory().listFiles(destinationNames);         if (candidates != null) {             for (File candidate : candidates) {                 registerExistingAdapter(template, candidate);             }         }
in mentioned 'doStart' then it will try to register same adapter second time and corrupt index.
And after that another restart will make AMQ fail to start because of that corrupted index.

@jbonofre - Did you have time to take a look?

@jbonofre - any news? :D

I'm resuming my test/investigation on this one.


Update docstrings and examples | datapipes

Codecov Report
Patch coverage is 100.00% of modified lines.

Files Changed
Coverage

src/gravitorch/datapipes/factory.py
ø

src/gravitorch/datapipes/iter/batching.py
ø

src/gravitorch/datapipes/iter/dictionary.py
ø

src/gravitorch/datapipes/iter/factory.py
ø

src/gravitorch/datapipes/iter/path.py
ø

src/gravitorch/datapipes/iter/shuffling.py
ø

src/gravitorch/datapipes/iter/source.py
ø

src/gravitorch/datapipes/iter/saving.py
100.00%

:loudspeaker: Thoughts on this report? Let us know!.


Could not Parse Json or t is null

Repo gives error could not parse json or t is null  if the ls.get has a blank data and the further code do not run. i think repo tries to parse a blank data if ls.get data has null value then repo should not try to decrypt the data, this problem occurs only in Mozilla Firefox version 61, i have not tested in older versions
Also the library is not working in Internet Explorer and Microsoft Edge with the invalid argument error
I initialized the object SecureLs in head, i successfully stored the data in local storage with aes is encryption, i closed my browser and opened again and when i reached the page it says t is null, but i was surprised that this happens only in Mozilla Firefox (works fine in chrome and safari)

Fixed in v1.2.0

Still getting Could not parse JSON

Maybe you're doing something wrong, working fine for me, make sure you set the
isCompression to true or false do not leave it blank, i'm have set it to true
Go to console and fine the line where error comes Could not parse json, and print the variable in library and check what type of data you are getting

@yogeshjain999 Please clear the localStorage first and then try again. It should work.


GeoWaveInputFormat: setAdapter and setIndex overrides QueryOptions

QueryOptions should be the defacto correct value for indices and adapters.
Perhaps this is a good time to just have the setIndex and addAdapter to pull out the QueryOptions and modify it, rather than having a 'separate' option.

Reviewed
There are two things going on.  It looks like he consolidated a few of the parameters, and then he also added QueryOptions as a parameter and remove Adapter ID and Index ID as parameters. (which compose QueryOptions)
Didn't see any huge issues .. few comments

Yes.  In testing the QueryOptions with the analytics, I noticed some of the parameters were missing from a prior commit, so I fixed them here.
Now queryoptions fall under a command option class that is a delegated from another command option class.  In the analytics case, the delegate option tag is 'query' (e.g. --query.adapters adapter1,adapter2)


[DARGA] Replace corrupted PNGs

Corrupted images generated toast errors.
relates to: #6623

@miq-bot add_label ui,bug

@epwinchell please add a link to the PR on master to fix same issue


Update numpy 1.21.6

Updates support to latest numpy
Needed to support deepsparse numpy version upgrade from neuralmagic/deepsparse#1094
The deepsparse change was made to support a ragged sequence being created in question answering pipeline during spans_extra_info computation; landing this diff along with   https://github.com/neuralmagic/sparseml/pull/1623 also fixes a few google colab errors we were seeing before.

Hello!
I'm still not able to install deepsparse with numpy>=1.22 with pip install.
The pipy version does not seem to include the modification
ERROR: Cannot install deepsparse and numpy>=1.22 because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested numpy>=1.22
deepsparse 1.5.2 depends on numpy>=1.16.3
onnx 1.12.0 depends on numpy>=1.16.6
sparsezoo 1.5.2 depends on numpy<=1.21.6 and >=1.0.0


Refactoring for line extractor with nms usage

Refactoring of the Line Detection module to include NMS.
Changes inlcude:

Removing indexing of keypoints using indices, and use line endpoint coordinates instead as line representation in gluefactory/eval/hpatches_extended.py and gluefactory/eval/megadepth1500_extended.py.
Update JPLDD [pass keypoint descriptors, return lines as endpoint coordinate pairs instead of keypoint indices, return lines and valid lines as torch tensors instead of lists] in gluefactory/models/extractors/joint_point_line_extractor.py.
Minor fixes in gluefactory/models/lines/line_refinement.py to ensure GPU usage for line NMS
Update gluefactory/models/lines/pold2_extractor.py to

Apply NMS on output lines depending on config flag use_nms
Return lines as endpoint coordinates instead of keypoint indices

Update gluefactory/models/matchers/nn_point_line.py to access line descriptors directly from model output dictionary instead of indexing keypoint descriptors

Eval script changes look good to me.

@RaphaelKreft went through all the comments and resolved.
Let me know if looks good to merge.


training with reset-position-ids and reset-attention-mask

Hi, I am trying to use flash-attention in megatron and I am wondering if I am pretraining with reset-position-ids and reset-attention-mask, how should I pass the customized block-wise diagonal attention-masks to use flash-attention?
For example, without reset attention mask, the attention mask matrix will be:
0. -inf -inf -inf -inf
0  0     -inf -inf -inf
0  0     0.    -inf -inf
0  0     0.    0     -inf
0  0     0.    0     0

as we are resetting attention mask (say one sentence ends at position 2), the attention matrix will become block-diagonal:
0    -inf   -inf   -inf  -inf
0     0     -inf   -inf  -inf
-inf -inf   0      -inf  -inf
-inf -inf   0      0     -inf
-inf -inf   0      0      0

For a typical input with batch size B, we will have B different block-diagonal attention masks (as each sequence has different resetting positions), what is the right API that I should use? From megatron-LM, the implementation is:
https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/model/transformer.py#L393
        output = flash_attn_unpadded_func(
            q, k, v, cu_seqlens_q, cu_seqlens_k, seqlen_q, seqlen_k,
            self.dropout_p,
            softmax_scale=self.softmax_scale, causal=is_causal
        )

I believe this is not really correct, as it is using a lower triangular mask, but not really the case of reset-attention-mask that I was describing.
Could you help me by pointing to the right API to use in megatron-LM or is this functionality implemented at all. I tried to use xformers but it will throw weird NANs when using cutlass based ops:
https://github.com/facebookresearch/xformers/issues/722
Thanks in advance! I personally think this should be related with the new features of support attention bias as described in your roadmap, e.g. block-diagonal is a pretty common customized attention bias. To implement attention bias like ALiBi, I believe your API will allow pass in a customized attention bias mask by any means?

Hi, this ticket can be closed. I implemented with the flash_attn_unpadded_func. As long as we calculated the cu_seqlens_q correctly, we can get the correct block diagonal matrix.

As long as we calculated the cu_seqlens_q correctly, we can get the correct block diagonal matrix.

I am using alibi, megatron-lm, and flash-attn. When I enable both reset-position-ids and reset-attention-mask at the same time, I can't get the correct loss. However, when I enable reset-attention-mask, the loss becomes normal. Could I know some details about your implementation process?

However, when I enable reset-attention-mask, the loss becomes normal.

If you are using megatron-lm post-processing logic and flash attention at the same time, and your loss is not working as expected, you are probably getting something wrong.
The post-processing logic with reset-attention-mask probably does not help with flash attention, as it does not use the attention mask at all. It used the cu-seqlens?

Are you using the customized attention mask to implement with your alibi? I heard some people are using the triton version of flash-attn v2 and it is working fine


Add nodes from inbound pings to routing table

fixes #104
What was wrong?
When we receive and inbound ping we should be adding the node to the routing table.
How was it fixed?
Now when an inbound ping is retrieved the client will ensure we have their ENR record and then will add them to the routing table.
Cute Animal Picture

@lithp The test I removed in #cad24b8 was turning flaky, and it was a really bad test to begin with.  The class of functionality it was testing already isn't well tested, and if we want to do it well, we'd probably need to execute on #99 so that each of those pieces can be tested in isolation as they end up interfering with each other.  Just wanted to mention both why it was removed and why I think it's ok to remove it.

Unfortunately I cannot test this because there is a version conflict when installing:
    python:   Running setup.py develop for ddht
    python: ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.
    python:
    python: We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.
    python:
    python: trie 2.0.0a4 requires rlp<=2.0.0-alpha.1,>=1, but you'll have rlp 2.0.0a2 which is incompatible.
    python: py-evm 0.3.0a19 requires rlp==2.0.0-alpha.1, but you'll have rlp 2.0.0a2 which is incompatible.
    python: Successfully installed Faker-4.7.0 Jinja2-2.11.2 MarkupSafe-1.1.1 Pygments-2.7.1 SecretStorage-3.1.2 Sphinx-1.8.5 alabaster-0.7.12 apipkg-1.5 asn1crypto-1.4.0 async-generator-1.10 async-service-0.1.0a11 attrs-20.2.0 babel-2.8.0 backcall-0.2.0 black-19.10b0 blake2b-py-0.1.3 bleach-3.2.1 bump2version-1.0.1 bumpversion-0.6.0 cached-property-1.5.2 cffi-1.14.3 click-7.1.2 coincurve-10.0.0 cryptography-3.1.1 cytoolz-0.11.0 ddht decorator-4.4.2 distlib-0.3.1 docopt-0.6.2 docutils-0.16 entrypoints-0.3 eth-bloom-1.0.3 eth-enr-0.3.0 eth-hash-0.2.0 eth-keys-0.3.3 eth-typing-2.2.2 eth-utils-1.9.5 execnet-1.7.1 factory-boy-2.12.0 filelock-3.0.12 flake8-3.8.3 hexbytes-0.2.1 hypothesis-4.57.1 ifaddr-0.1.7 imagesize-1.2.0 incremental-17.5.0 iniconfig-1.0.1 ipython-7.18.1 ipython-genutils-0.2.0 isort-5.6.1 jedi-0.17.2 jeepney-0.4.3 keyring-21.4.0 lru-dict-1.1.6 lxml-4.5.2 mccabe-0.6.1 more-itertools-8.5.0 mypy-0.782 mypy-extensions-0.4.3 netdisco-2.8.2 netifaces-0.10.9 outcome-1.0.1 parso-0.7.1 pathspec-0.8.0 pathtools-0.1.2 pexpect-4.8.0 pickleshare-0.7.5 pkginfo-<IP_ADDRESS> pluggy-0.13.1 plyvel-1.2.0 prompt-toolkit-3.0.7 psutil-5.7.2 ptyprocess-0.6.0 py-1.9.0 py-ecc-4.1.0 py-evm-0.3.0a19 pycodestyle-2.6.0 pycparser-2.20 pycryptodome-3.9.8 pydocstyle-3.0.0 pyethash-0.1.27 pyflakes-2.2.0 pytest-6.0.1 pytest-forked-1.3.0 pytest-randomly-3.1.0 pytest-trio-0.6.0 pytest-watch-4.2.0 pytest-xdist-2.0.0 python-dateutil-2.8.1 pytz-2020.1 readme-renderer-26.0 regex-2020.9.27 requests-toolbelt-0.9.1 rfc3986-1.4.0 rlp-2.0.0a2 sniffio-1.1.0 snowballstemmer-2.0.0 sortedcontainers-2.2.2 sphinx-rtd-theme-0.5.0 sphinxcontrib-serializinghtml-1.1.4 sphinxcontrib-websupport-1.2.4 text-unidecode-1.3 toml-0.10.1 toolz-0.11.1 towncrier-19.2.0 tox-3.19.0 tqdm-4.50.2 traitlets-5.0.4 trie-2.0.0a4 trio-0.16.0 trio-typing-0.5.0 twine-3.2.0 typed-ast-1.4.1 typing-extensions-<IP_ADDRESS> upnp-port-forward-0.1.1 upnpclient-0.0.8 virtualenv-20.0.33 watchdog-0.10.3 wcwidth-0.2.5 zeroconf-0.28.5

Bit of a dependency mess on our side that we have to untangle.  cc @cburgdorf just for visibility.

Yep, a lot of the projects have the RLP library fixed to 2.0.0.a1 which is causing the headache. I send PRs to all affected projects to relax the bounds. Here's the one for Py-Trie: https://github.com/ethereum/py-trie/pull/119


Sub groups

I added the new tests to verify the change to a new unit test class, as that seemed to be the best place for them.

@Ron2 Here's the pull request we talked about. Let me know if you see changes that need to happen.

Thank you very much, Jason. That was a lot of work on your part and the unit tests were well-written. I reviewed the changes and they look good but then when I ran the full test suite, another unit test failed -- ModifyChildDocumentExternally in TimelineEditorTests. I'm looking into what is going on there.

Never mind about that unit test -- it fails in our current release and in our work-in-progress branch on my computer. I suspect it's somehow related to Windows 8.1 or my laptop somehow. Anyway, I merged in your changes. Thanks again!

Thanks Ron,
Glad to help. I've been really impressed with ATF, and have enjoyed
being able to contribute. Hope to do so again in the future when the
need arises!
Cheers,
Jason
On 6/9/2015 6:03 PM, Ron wrote:

Never mind about that unit test -- it fails in our current release and
in our work-in-progress branch on my computer. I suspect it's somehow
related to Windows 8.1 or my laptop somehow. Anyway, I merged in your
changes. Thanks again!
—
Reply to this email directly or view it on GitHub
https://github.com/SonyWWS/ATF/pull/40#issuecomment-110549645.


Performance worsens greatly when downloading blobs with long breaks in between

Package Name: azure-storage-blob
Package Version: 12.6.0 (but it also happens on 12.13.1)
Operating System: linux (but it doesn't really matter, it happens on my mac too)
Python Version: 3.8

Describe the bug
When using the asyncio SDK, if we wait more than 10 seconds between blob downloads the download time becomes 10-100 times slower.
To Reproduce
I wrote this script to demonstrate the issue:
import random
from asyncio import gather, sleep, run
from time import perf_counter
from azure.storage.blob.aio import BlobServiceClient, ContainerClient

all_times = []

async def download(client: ContainerClient, path: str):
    s = perf_counter()
    downloader = await client.download_blob(path)
    await downloader.readall()
    e = (perf_counter() - s) * 1000
    all_times.append(e)
    print(f"download took {e}ms file={path}")

def get_url_and_key():
    ### censored for security reasons ###

async def do():
    account_url, account_key = get_url_and_key()
    blob_client = BlobServiceClient(account_url, account_key)
    container_client = blob_client.get_container_client('some-container')

    file_pool = []
    async for x in container_client.list_blobs():
        if len(file_pool) > 50:
            break
        file_pool.append(x.name)

    for i in range(30):
        files = set()
        while len(files) < 3:
            files.add(file_pool[random.randint(0, len(file_pool) - 1)])
        await gather(*[download(container_client, file) for file in files])
        await sleep(20)

    await container_client.close()
    await blob_client.close()

    print(f"average is {sum(all_times) / len(all_times)}ms")

run(do())

what this script essentially does:

find the names of 50 blobs that exist in the container
randomly choose 3 of them to download
download them asynchronously (gather 3 tasks) and print the download times
sleep a certain amount of seconds
repeat (30 times) and print the average download time

if the sleep time is set to 10 seconds or below I get expectedly low download times:

download took 23.274756036698818ms file=+1b2+N3X7cgkoaajoUSlCA==
download took 31.523440033197403ms file=+/K/vccgIKxIsFW6tk8l3Q==
download took 44.199715834110975ms file=+/dVLONMzj3tMtql+Zv7Jg==
download took 33.404441084712744ms file=+/UeV81yZRT+Eh5jeUKlOA==
.
.
.
download took 12.770875822752714ms file=+16GIyseiqsaO8T+mrXLQg==
download took 9.113383013755083ms file=+1YF6MfP5Xb+sWEqgr36LQ==
download took 7.825685199350119ms file=+/ZJM5EQ40nni2+zKjJA4A==
download took 7.158686872571707ms file=+1b2+N3X7cgkoaajoUSlCA==
average is 20.692046359181404ms

but if I set it to 20 seconds for example, the download times become insanely high (beyond the first batch):

download took 9.756594430655241ms file=+0huQr/6tn7zw5+p2fT/2A==
download took 20.794587209820747ms file=+1b2+N3X7cgkoaajoUSlCA==
download took 45.60287203639746ms file=+1h1V/YFgN130/9kzcIygQ==
download took<PHONE_NUMBER>129507ms file=++nRJgH2HUF30/9kzcIygQ==
download took<PHONE_NUMBER>459075ms file=+1YF6MfP5Xb+sWEqgr36LQ==
download took<PHONE_NUMBER>330963ms file=+/soiSTB/5Wb0zHn28+O6Q==
.
.
.
download took<PHONE_NUMBER>901779ms file=+1ZAwh3CRGuuBvav8e/34w==
download took<PHONE_NUMBER>172736ms file=+1QWh0iEdgVt/VX2PlPDpw==
download took<PHONE_NUMBER>40989ms file=+/FxOL5ySAQaO8T+mrXLQg==
download took<PHONE_NUMBER>721961ms file=++O8gZmF/40FPYL5+VRhAA==
download took<PHONE_NUMBER>743495ms file=+/soiSTB/5Wb0zHn28+O6Q==
download took<PHONE_NUMBER>135283ms file=++zejjUIwmWuBvav8e/34w==
average is<PHONE_NUMBER>503374ms

I've run this countless times with different sleep times on my own machine (macOS) and on the production machine (linux) at different traffic loads and with different storage accounts - and always got the same results, so we can rule out load issues on the azure blob storage, or file size variance.
It seems to me that after waiting a certain amount of time the connection with the azure blob storage dies and takes forever to revive. It seems like a bug to me, but if there's a way to tweak that so the connection stays live for 3 minutes of inactivity for example (eliminating the need to revive it), it would solve the issue for now.
We've moved to the async SDK to be able to download many files asynchronously and reduce our response time, but it seems like the opposite has happened and it greatly increased it, to the point this SDK is unusable to us. Quick assistance will be greatly appreciated.

Hi @asafalon1 thank you for the feedback, we'll get back to you asap.

Update: I wrote the same logic using the non-async SDK using a thread pool executor, and the results were great, further affirming that the issue is a bug in the async SDK and not some system/usage issue.
import random
from asyncio import gather, sleep, run, get_event_loop
from concurrent.futures import ThreadPoolExecutor
from contextvars import ContextVar
from uuid import uuid4
from time import perf_counter
from typing import Tuple
from azure.storage.blob import BlobServiceClient, ContainerClient

all_times = []
client: ContextVar[Tuple[str, ContainerClient]] = ContextVar("client")

def get_url_and_key():
    ### censored for security reasons ###

def create_client():
    account_url, account_key = get_url_and_key()
    blob_client = BlobServiceClient(account_url, account_key)
    client_id = str(uuid4())
    client.set((client_id, blob_client.get_container_client('some-container')))
    print(f"client_created {client_id}")

executor = ThreadPoolExecutor(max_workers=10, initializer=create_client)

def get_file_pool():
    account_url, account_key = get_url_and_key()
    blob_client = BlobServiceClient(account_url, account_key)
    container_client = blob_client.get_container_client('some-container')
    file_pool = []
    for x in container_client.list_blobs():
        if len(file_pool) > 50:
            break
        file_pool.append(x.name)
    container_client.close()
    blob_client.close()
    return file_pool

def download(path: str):
    s = perf_counter()
    client_id, blob_client = client.get()
    blob_client.download_blob(path).readall()
    e = (perf_counter() - s) * 1000
    all_times.append(e)
    print(f"download took {e}ms    file={path}    client_id={client_id}")

async def do():
    file_pool = get_file_pool()
    loop = get_event_loop()

    for i in range(20):
        files = set()
        while len(files) < 3:
            files.add(file_pool[random.randint(0, len(file_pool) - 1)])
        await gather(*[loop.run_in_executor(executor, download, file) for file in files])
        await sleep(20)

    print(f"average is {sum(all_times) / len(all_times)}ms")

run(do())

client_created 3a44a5dd-f587-49b0-b35d-8bad288f1eb3
client_created 34f6c710-133d-45fa-9066-d38e2088802d
client_created 14ac5d66-128e-459c-99f5-db5406db4ee8
download took 40.091779083013535ms    file=+1b2+N3X7cgkoaajoUSlCA==    client_id=3a44a5dd-f587-49b0-b35d-8bad288f1eb3
download took 33.937398344278336ms    file=++gHmm6FBqPRU3BlU4/rJQ==    client_id=14ac5d66-128e-459c-99f5-db5406db4ee8
download took 93.85131718590856ms    file=+/dVLONMzj3tMtql+Zv7Jg==    client_id=34f6c710-133d-45fa-9066-d38e2088802d
download took 13.473261147737503ms    file=+1b2+N3X7cgkoaajoUSlCA==    client_id=3a44a5dd-f587-49b0-b35d-8bad288f1eb3
download took 12.802662793546915ms    file=+0/fKSukSOuuBvav8e/34w==    client_id=14ac5d66-128e-459c-99f5-db5406db4ee8
.
.
.
download took 14.066467061638832ms    file=++83HDhOOtxKVTQz0XMVjg==    client_id=14ac5d66-128e-459c-99f5-db5406db4ee8
download took 57.9378642141819ms    file=+/dVLONMzj3tMtql+Zv7Jg==    client_id=3a44a5dd-f587-49b0-b35d-8bad288f1eb3
download took 25.819737929850817ms    file=+0huQr/6tn7zw5+p2fT/2A==    client_id=34f6c710-133d-45fa-9066-d38e2088802d
download took 26.553436182439327ms    file=+1tWvJpKpXdKVTQz0XMVjg==    client_id=14ac5d66-128e-459c-99f5-db5406db4ee8
download took 29.68962863087654ms    file=+/K/vccgIKxIsFW6tk8l3Q==    client_id=3a44a5dd-f587-49b0-b35d-8bad288f1eb3
average is 36.957062470416226ms

Hi @asafalon1, thanks for the report. We have been able to reproduce this on our end but the cause is not obvious so we will investigate and get back to you. Thanks!

Hi @asafalon1, we have done some fairly extensive investigation into this issue, and we believe this is mainly being caused by TCP Connection re-use in the aiohttp layer.
When a TCP Connection is first opened to the server, it takes additional time to establish that connection. Additionally, if configured, an existing TCP Connection can be kept open (alive) for a period of time where the connection will not need to be re-established and can be re-used. For aiohttp, the HTTP library behind our async library, the default value for this this idle timeout is 15 seconds. So, when we sleep for 20 seconds, the TCP connection that was open by the first set of requests is closed and it takes time to reopen this request on the next set of downloads. Additionally, my guess for why this affects all executing threads is probably because there would be one connection per thread in this case.
What we don't fully understand yet is why the additional download time is not fixed and seems to scale with the blob size. The time taken to establish a TCP connection should be fixed but it seems there is something additional happening in aiohttp causing this additional time to scale with the response size.
The good news is that this idle timeout is configurable on the aiohttp side and we have found that increasing it beyond how long you are sleeping, seems to fix the issue. Currently the best way to configure this would be to provide and configure your own ClientSession object to the BlobServiceClient. This can be done like this:
from aiohttp import ClientSession, TCPConnector

connector = TCPConnector(keepalive_timeout=120)
session = ClientSession(connector=connector)
blob_client = BlobServiceClient(account_url, account_key, session=session)

The one caveat here is that you are no longer using the default Session that azure-core provides for you which may mean missing out on some of our default configuration. Currently we don't add much additional configuration beyond the defaults so it may not be a problem. You can see where azure-core constructs the ClientSession here so you may want to consider adding this additional configuration as well. We are currently thinking about ways to improve specifying this configuration.
Hopefully that information helps you. Please let me know if you have any further questions. Thanks.
CC @xiangyan99 and @annatisch


Close #801

update doc on useFieldArray with newly added rules prop

close #801

thanks @Moshyfawn pretty much it's your update ahhaha


Categories Docker images for industry trends

I have an idea. There are millions of Docker images in Docker hub. Say, I come from storage background and want to know what Docker images are available for storage industry. Same case could be if I am working for hardware industry I would be interested to know what system management tools are available. The only option I have is browsing through the tools one after another and that might consume time once Docker repo gets large and large. Why not classify it in terms of industry trends(say, server, cloud, networking, storage, system management, big data, hadoop etc.) so that user can quickly know what containers are present for respective point of interest.
I am not sure if this is the right place but yes, do redirect this thread accordingly.
Thank You.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Sounds like a good idea. Here are my 2 cents: Instead of categorizing based on industry, why not do it based on App ecosystem. I mean, that's the basic stuff we are trying to do, right? Making apps deployment easier. So,  as you said we can categorize them accordingly like cloud apps images, storage apps images, infrastructure apps etc. Let me know what you think about that.

Hi Peeyush,
Thanks.You have put it in the right way. I agree with your views.
Ajeet
On 4 Aug 2015 10:17, "Peeyush gupta"<EMAIL_ADDRESS>wrote:

Sounds like a good idea. Here are my 2 cents: Instead of categorizing
based on industry, why not do it based on App ecosystem. I mean, that's the
basic stuff we are trying to do, right? Making apps deployment easier. So,
as you said we can categorize them accordingly like cloud apps images,
storage apps images, infrastructure apps etc. Let me know what you think
about that.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/15280#issuecomment-127477476.

Thanks for creating this proposal @ajeetraina, however, issues and feature requests regarding Docker Hub are not handled in this repository (it's managed by a different team). Usually, you'll have to report those via https://support.docker.com, however, because Docker Hub has just gotten a makeover, you could try opening a feature request in this repo; https://github.com/docker/hub-beta-feedback
I'm going to close this issue here, because there's nothing the maintainer here can do about this, but feel free to comment here after closing


Fields in groups ignore typical table naming convention (postgres)

Link to reproduction
No response
Payload Version
3.0.0
Node Version
18
Next.js Version
15
Describe the Bug
I have a collection with a group info and a set of nested fields.
I named these fields following the camelcase convention used throughout the Payload docs:
{
  name: 'info',
  type: 'group',
  fields: [{ name: 'phoneNumber', ...}]
}

Normally the db-postgres adapter translates the camel-cased name to snake-case e.g. phoneNumber becomes phone_number in the Postgres table.
However, when the field is nested within a group the convention is suddenly ignored and you end up with something like info_phoneNumber instead of info_phone_number. This is unexpected to me as I'm still using the exact same field configuration but moving it inside of a group, so the two following a different convention for the same property seems odd.
I want to maintain consistent naming conventions in the db so I used snake-case in the field config name (phone_number), but that leaves in inconsistent with the conventions used for everything else.
Additionally I tried using the dbName property on the field to workaround this while keeping the same convention for name but that seems to have no effect, the resulting property name is still info_phoneNumber.
{
  name: 'info',
  type: 'group',
  fields: [{ name: 'phoneNumber', dbName: 'phone_number' /* <- Does nothing */ }]
}

Reproduction Steps

Setup Payload project with db-postgres
Create a collection with a group and a nested field with camel-cased name
Note the difference in convention of the resulting db property name
Attempt to override with dbName prop to fix.
Note dbName doesn't work.

Adapters and Plugins
No response

This has been fixed in the latest beta.
{
  name: 'info',
  type: 'group',
  fields: [{ name: 'phoneNumber', type: 'text' }],
},

now results in


Does Modal support using this instead of $scope

I was playing around with the modal and tried using this instead of $scope, but it broke the items list and the ok and cancel buttons. Am I doing something wrong, or is this not supported?
http://plnkr.co/edit/wnDk17aEMkYJrTsh4BpB?p=preview
In the console I am seeting errors about
Unknown provider: $modalInstanceProvider

You actually want to pass the controller information via the options object passed into the $modal service - here is a working example of your Plunker.


Color changes only on page load, and flashes on a website

Great extension! I LOVE IT.
One thing I've noticed though: in my website I have a dark mode switch. I'm gonna use it to describe the behavior I'm experiencing.
A little background: my system, Firefox and the extension are working on dark mode right now (it's night time here at the moment of testing the extension). I have the Dark Reader extension installed, but I disabled it completely from Firefox extensions to track down the problem properly.
I got 2 problems:

When I'm in dark mode in the website, everything works fine. However, if switch to the light theme, it doesn't change the tab colors right away. I need to refresh or get into a link to make it change.
If I leave it in light mode, it flashes in dark and then goes to the proper color again (light).

I can tell you that the meta theme-color in my website is set via javascript at the very beginning of loading the website. The flashing problem does not happen in Chrome or similar browsers in Android where the tabs color changes according to the current webpage theme, and they switch dynamically as well.
I could say that the flashing problem might be because the theme-color tag is being processed a few milliseconds late, but still the javascript code is running even before the DOM is processed I guess. The problem does not happen in Android browsers because they process the theme-color tag a bit late and, in the meantime they retain the previous color, I guess?
EDIT: the flash issue seems to happen, at least to me, in the homepage, here, and any product page. It does not happen, however, here, or at least not so frequently, which may hint a race condition problem as I mentioned.
And an optional issue, which I don't really know if that's part of the scope of what the extension is able to do:

The SVG favicon in my webpage is able to switch between dark and light mode depending on the system color scheme (I'm guessing more precisely Firefox color scheme). So, it won't change according to the current theme chosen in the website, which is desirable given that it has to go along the color scheme of the whole browser. Thing is, the extension does change the whole look of the borders and tabs.

Does it have the ability to switch the SVG colors in the favicons? To give more information, SVG uses the media query (prefers-color-scheme: dark) to change the fill color within the icon. It is embedded in the SVG file.
Thank you!

The color flashes also happen in these sites with their own dark and light themes:

https://www.joshwcomeau.com/
https://www.leagueofgraphs.com/
https://github.com/

@Arecsu
Thanks for such a detailed issue, and I truly appreciate how deep you have dug! After some testing, I sometimes also see some flashing when I open or refresh a website, no matter in dark mode or light mode. I think that’s because the add-on tries to get the theme color, but the website is not completely loaded. I’ll try to rebalance between speed and accuracy.
Sometimes the favicon isn’t rendered in the right color scheme, that’s because the add-on overrides the color scheme of the browser.
Also, thanks for the list of URLs. It helps a lot with the debugging.
By the way, I really love the design of your website and also the artwork you’re making.

Hey @YS-Wong, thank you so much for your kind words about my site! Hopefully it will keep growing as time goes by 😊
I've been trying to dig more into the flashing problem. So far, I've changed these parts of the code which are responsible of the flashing problem to be a bit more  "readable"
// background.js
// Colorize tab bar after defined theme-color or computed background color
function changeFrameColorToBackground() {
  chrome.tabs.query({ active: true, currentWindow: true }, function (tabs) {
    chrome.tabs.sendMessage(tabs[0].id, { message: 'remind_me' }, function (response) {
      if (!response.responseColor) {
        let windowId = tabs[0].windowId;
        resetFrameColor(windowId);
        reject("NO responseColor, may be about:pages")
      }
    });
  });
}

//content_script.js
chrome.runtime.onMessage.addListener(
   function (request, sender, sendResponse) {
      if (request.message == 'remind_me') {
         if (responseColor != "") {
            sendResponse({ responseColor: true });
            findColor();
         } else {
            sendResponse({ responseColor: false });
         }
      }
   }
);

As far as I'm concerned, in some sites responseColor will be empty probably because the site hasn't loaded the proper css/meta tags to get the correct color. Thus, triggering resetFrameColor(windowId) and making it flash.
If resetFrameColor(windowId) is commented, the problem dissapears, but about:pages no longer will change color.
I tried to get around this issue by using some await async functions, but I'm pretty sure I'm doing it wrong (I always screw them over 😅). What I was trying to do is delaying any message response until responseColor got a non-empty value that can be correctly processed.

Ok, I think I solved this issue in the most simple and "dirty" way:
// background.js
if (response == undefined) {
  // checks if it's an about or addons.mozilla.org
  if (url.startsWith("about:") || url.startsWith("addons.mozilla.org")) {
    resetFrameColor(windowId);
  }
console.log("NO CONNECTION TO CONTENT SCRIPT\nMay be about:pages");
}

:)
So far, no flashing problems at all and everything works just fine. Gonna to make a pull request!

@Arecsu
Thanks for your fix! It’s included in the latest version, v1.3.4.
You’re right. The add-on always reset tab bar color to its default, when the content script returns no response. I think that’s because before v1.2, content script can return undefined in some cases. If that happens, the tab bar resets its color. After v1.2, theoretically, only pages protected by browser and loading page returns undefined. So, your fix isn’t “dirty” at all, instead rather fit.
It always surprises me when people actually dig into my codes, even though they are more like Java than JavaScript. That’s because I learned Java, but not JavaScript.

@Arecsu the add-on is now responsive to color scheme switching on your website (needs “dynamic color update” turned on).

Wooow that's so cool!! Thank you so much for that feature, definitively handy and feels awesome 😊😊😊

Hey hey,
I've got some issue with certain favicons, here github and raindrop.
Any idea why?

Thanks


Feature Request: Hue oozie workflow support one click copy function

Hue oozie workflow is really cool, especially the virtualised workflow editor.
The is one issue. for many cases, we need copy an exist workflow, while current does not support.
There is the use case for this feature request:

someone create a demo workflow, other's just need to copy it and change the copied one to quickly setup another workflow
someone need to setup and try a new version of the current workflow, he/she do not want to change the current online workflow, because the workflow does not support revert and virtualised  version function.
someone need to temperately run partial of current workflow,   he/she do not want to edit and recover the workflow, that's to fuzzy and easy to make mistake. this is a similar which run partial workflow when workflow run into error.

I am gonna to recommend  our teams to migrate the cronjob into hue oozie job system. And this feature will helps a lot.

There is a 'copy' button on the list of workflows page but you would rather have even after opening an existing workflow? (in the menu bar you highlighted)

Thanks, Found the copy function in list page. please resolve it:)

Glad to hear :)


Mongoose Traveller 2E - Addition of trade rules and vehicle section

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[x] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Addition of trade rules for passengers, freight & speculative trading
Addition of Vehicle section
General tidy up of CSS and HTML here and there

Note: Permission has been given by Mongoose Publishing for these trade rules to be implemented. Please see MongoosePermission.png.

Character Sheet Info Roll20 Internal Use only.


Address FutureWarning related to Timestamp

Currently our tests produce some FutureWarnings on newer Pandas versions, as timestamp + int will no longer be allowed and needs to be replaced with timestamp + int * freq.

Running cat logs.txt | grep FutureWarning | sort | uniq yields:
  /var/lib/jenkins/workspace/gluon-ts-cpu-py3/src/gluonts/dataset/artificial/_base.py:654: FutureWarning: Addition/subtraction of integers and integer-arrays to Timestamp is deprecated, will be removed in a future version.  Instead of adding/subtracting `n`, use `n * self.freq`
  /var/lib/jenkins/workspace/gluon-ts-cpu-py3/src/gluonts/evaluation/_base.py:176: FutureWarning: Addition/subtraction of integers and integer-arrays to Timestamp is deprecated, will be removed in a future version.  Instead of adding/subtracting `n`, use `n * self.freq`
  /var/lib/jenkins/workspace/gluon-ts-cpu-py3/src/gluonts/evaluation/backtest.py:71: FutureWarning: Creating a DatetimeIndex by passing range endpoints is deprecated.  Use `pandas.date_range` instead.
  /var/lib/jenkins/workspace/gluon-ts-cpu-py3/src/gluonts/model/seasonal_naive/_predictor.py:85: FutureWarning: Addition/subtraction of integers and integer-arrays to Timestamp is deprecated, will be removed in a future version.  Instead of adding/subtracting `n`, use `n * self.freq`
  /var/lib/jenkins/workspace/gluon-ts-cpu-py3/test/evaluation/test_evaluator.py:579: FutureWarning: Creating a DatetimeIndex by passing range endpoints is deprecated.  Use `pandas.date_range` instead.
  /var/lib/jenkins/workspace/gluon-ts-cpu-py3/test/model/test_seasonal_naive.py:60: FutureWarning: Addition/subtraction of integers and integer-arrays to Timestamp is deprecated, will be removed in a future version.  Instead of adding/subtracting `n`, use `n * self.freq`
  /var/lib/jenkins/workspace/gluon-ts-cpu-py3/test/test_transform.py:110: FutureWarning: Creating a DatetimeIndex by passing range endpoints is deprecated.  Use `pandas.date_range` instead.


Build error

Hi all, I'm getting an error from CMake in my attempt to build a recent version of luv for OpenWrt.
Essentially I'm using the makefile here: https://github.com/openwrt/packages/blob/master/lang/luv/Makefile and amending the version number and hash to 1.36 or 1.34. Whereas 1.22 builds, more recent version builds fail with this message:
CMake Error at /home/ubuntu/wrtbuilder/openwrt/staging_dir/host/share/cmake-3.11/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Lua (missing: LUA_INCLUDE_DIR)
Call Stack (most recent call first):
  /home/ubuntu/wrtbuilder/openwrt/staging_dir/host/share/cmake-3.11/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /home/ubuntu/wrtbuilder/openwrt/staging_dir/host/share/cmake-3.11/Modules/FindLua.cmake:193 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:111 (find_package)

Is there something basic that I'm doing wrong? Or has something changed between 1.22 and 1.34+ that I need to incorporate. Libuv appears to building fine.
Thanks!

The find_package(Lua) changed to use REQUIRED in https://github.com/luvit/luv/commit/1a7012058fe5d0661301e4f467b9f9d5bf7f9196
This might have been a mistake with PUC Lua, since presumably it's failing to find the libraries, not the headers, and we only actually link against the libraries on Windows. So, the REQUIRED should probably be removed for find_package(Lua).

Thanks for this squeek502. I've tried rebuilding with your patch applied atop 1.36.0 and voila, a slightly different error:
-- Could NOT find Lua (missing: LUA_INCLUDE_DIR)
CMake Error at CMakeLists.txt:128 (message):
  Failed to find Lua headers.  Variable `LUA_INCLUDE_DIR' expected to be
  defined.

Whereas the previous error at line 111 was caused by the find_package call in CMakeLists.txt, I cannot see what's causing this

Could you try the following patch:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 357d7f6..9b7ff1d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -112,9 +112,6 @@ else (LUA)
       else()
         find_package(LuaJIT)
       endif()
-      if(NOT LUAJIT_INCLUDE_DIR)
-        message( FATAL_ERROR "Failed to find LuaJIT headers. Variable `LUAJIT_INCLUDE_DIR' expected to be defined.")
-      endif()
       include_directories(${LUAJIT_INCLUDE_DIR})
     else (USE_LUAJIT)
       # We only link the libs on Windows, so find_package fully succeeding
@@ -124,9 +121,6 @@ else (LUA)
       else()
         find_package(Lua)
       endif()
-      if(NOT LUA_INCLUDE_DIR)
-        message( FATAL_ERROR "Failed to find Lua headers. Variable `LUA_INCLUDE_DIR' expected to be defined.")
-      endif()
       include_directories(${LUA_INCLUDE_DIR})
     endif (USE_LUAJIT)

I expect it to fail to find the headers at compile time, but if it doesn't, then that's worth knowing, as it means something stranger is going on.

as you suspected, it fails to find the headers:
/home/ubuntu/wrtbuilder/openwrt/build_dir/target-mips_24kc_musl/luv-1.36.0-0-rt1/src/luv.c:20:10: fatal error: compat-5.3.h: No such file or directory
 #include "compat-5.3.h"

so i'm glad it's picking up a real issue :) am i missing an obvious package?
$ apt list --installed | grep lua

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

liblua5.1-0/bionic,now 5.1.5-8.1build2 amd64 [installed]
liblua5.1-0-dbg/bionic,now 5.1.5-8.1build2 amd64 [installed]
liblua5.1-0-dev/bionic,now 5.1.5-8.1build2 amd64 [installed]
liblua5.2-0/bionic,now 5.2.4-1.1build1 amd64 [installed,automatic]
liblua5.3-0/bionic-updates,bionic-security,now 5.3.3-1ubuntu<IP_ADDRESS> amd64 [installed,automatic]
liblua5.3-dev/bionic-updates,bionic-security,now 5.3.3-1ubuntu<IP_ADDRESS> amd64 [installed]
lua-any/bionic,now 24 all [installed,automatic]
lua-compat53/bionic,now 0.3-3 amd64 [installed]
lua-sec/bionic,now 0.6-4 amd64 [installed]
lua-socket/bionic,now 3.0~rc1+git+ac3201d-4 amd64 [installed,automatic]
lua5.1/bionic,now 5.1.5-8.1build2 amd64 [installed]
luarocks/bionic,now 2.4.2+dfsg-1 all [installed]

That is not the header I expected it not to be able to find (I was expecting lua.h or some other Lua header). We provide compat-5.3.h in our release tarball, and add it to the include paths here:
https://github.com/luvit/luv/blob/9054ac8b024c79c5fbec5a256049c183e5318aca/CMakeLists.txt#L160-L166
so I'm not really sure how its failing to find that...

I made a mistake with the packaging and lost lua-compat-5.3 my bad!
However, interestingly, the combination of your small patch on top of your pull request builds flawlessly, and leads to a working build:
root@OpenWrt:~# lua helloworld.lua
Now quitting.
root@OpenWrt:~#

Strange, that means that CMake's FindLua.cmake is failing to find the Lua headers but your C compiler is succeeding. Do you know the path of the lua.h that is being used?

Does the following fix it?
  if(NOT LUA_COMPAT53_DIR)
    set(LUA_COMPAT53_DIR ${CMAKE_SOURCE_DIR}/deps/lua-compat-5.3)
  endif()

Re-opening this because, while I think #489 is the correct fix for what I understand the problem to be, I still want to investigate what's going on here since #489 won't fix @lePereT's problem without the patch in https://github.com/luvit/luv/issues/488#issuecomment-623225310, but that patch shouldn't be necessary. I want to try to understand how CMake can fail to find the Lua headers while the C compiler succeeds.

Hi Squeek, could you tell me how I might do that? Simply look for lua.h on the Ubuntu build server?

The best place to look would be the CMakeFiles/libluv.dir/depend.make generated in your CMake build directory and look for a line like CMakeFiles/libluv.dir/src/luv.c.o: /usr/include/lua5.1/lua.h.
If you can't find that, then try:
ls -d /usr/include/*/lua.h
ls -d /usr/include/lua*
ls -d /usr/local/include/*/lua.h
ls -d /usr/local/include/lua*


Branch update landing page

Updated version number also

Codecov Report

Merging #124 (68a02fa) into master (43681f4) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #124   +/-   ##
=========================================
  Coverage     65.47%   65.47%
  Complexity      658      658
=========================================
  Files           114      114
  Lines          2323     2323
  Branches        271      271
=========================================
  Hits           1521     1521
  Misses          716      716
  Partials         86       86

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/UiManager.java
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Can I get size of buffered image?

I want to render image blocks and then combine them into big one. To do this I need to calculate width and height of buffered images. I wrote this code with images manipulations that I looking for

Issues is not a good place to ask questions. Use discussions

Issues is not a good place to ask questions. Use discussions

Couldn't find on mobile (I can see discussions section in React-Router, but can't in there)

Couldn't find on mobile (I can see discussions section in React-Router, but can't in there)

Am I missing something?

Weird, I created welcome one. Please check once again https://github.com/elixir-mogrify/mogrify/discussions


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2020-11-26T13:07:14+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.7
1b687b595d3fe9d12f1b1c3e15f802dee2e850dd
link
/test lint_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Automated cherry pick of #2717: fix: bucket list access accessUrl nil pointer panic

Cherry pick of #2717 on release/2.11.
#2717: fix: bucket list access accessUrl nil pointer panic

AccessUrls

/approve
/lgtm

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@8100b2a). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2718   +/-   ##
==============================================
  Coverage                ?   7.22%
==============================================
  Files                   ?     470
  Lines                   ?   74365
  Branches                ?       0
==============================================
  Hits                    ?    5374
  Misses                  ?   68539
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.22% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/buckets.go
1.44% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8100b2a...35700b9. Read the comment docs.


BYOL (Bring Your Own Leaflet) version

It would be REALLY REALLY nice to have a version that doesn't bundle Leaflet.
With Carto.js and Mapbox.js and now MapZen.js all including Leaflet.js it makes it very difficult to mix and match services.
I realize that there are probably technical or logistical reasons to bundle Leaflet.js, but it'd be great to have a version that doesn't include it so I can bring my own copy of Leaflet.js, and make a MapZen map with a Carto animation, or an existing Mapbox basemap or something.
Update: Mapbox does actually does provide a mapbox.standalone.js, it'd be great to have a standalone mapzen.js too.

Thanks @stuporglue! Can you provide a code sample or two of how this might work? We decided to bundle Leaflet because Tangram is sensitive to the version used.
While both Leaflet and Mapzen.js are waiting for a blessed 1.0 release, we may keep it as-is due to the sensitivity to breaking changes in pre-1.0 libraries.

Hey @stuporglue thanks for the issue. I worked on building standalone version of mpazen.js on this branch : https://github.com/mapzen/mapzen.js/tree/hanb/standalone
You can build a standalone version of mapzen.js using npm run build-standalone command.
I also added an example using mapbox geocoder with mapzen.js , which is examples/standalone.html.
This standalone one should make mapzen.js to work with other plugins based on Leaflet in theory. However, since we put our priority on easy use of all mapzen products through mapzen.js, some parts might not work as expected. (ex. mapzen.js puts Tangram tile layer on top of the map by default. mapzen.js doesn't have the api to change its default tile yet.)

Thanks!
@migurski, I understand the version sensitivity issues, especially so close to a stable release.
@hanbyul-here Thanks for the quick work of splitting it out to a standalone version!
I'm excited to play with this!