[SIP-34] Proposal to establish a new design direction, system, and process for Superset

[SIP-34] Proposal to establish a new design direction, system, and process for Superset
Motivation
In August, 2019, a project was kicked off to re-imagine the design of Superset, and create a “North Star” for the interface, flows, and visual aesthetic of Superset. The primary goal of the project—and this SIP—is to create a new visual design framework for Superset's user interface.
Since its inception, Superset has rapidly grown in scope, size, audience, and complexity thanks to the work of this community. This growth has led to an accumulation of “design debt” in forms including problematic user flows, inconsistencies in interface elements, or general complexities that may be simplified/clarified by revisiting the design of Superset holistically.
The intent of this undertaking was to smooth out the user experience of Superset, targeting all of the following:

Supporting most use cases and functionality currently in use by known Superset users in the design process, while reducing dead-ends and friction in these flows. Features and flows removed or deprecated are listed under "Removals and deprecations" below
Focusing on the “objects” of superset (namely Datasets, Queries, Charts, and Dashboards) and how those are structured/accessed throughout the flows of Explore and SQL Lab
Smoothing out and simplifying the general experience, making Superset easier to use for new users, and faster for more experienced ones
Creating a more consistent design and experience throughout the product, with a well defined style guide, and coherent design system

Participants in this project included:

Preset, Inc. - a startup founded by @mistercrunch to offer Superset as a hosted service, acting as primary sponsor of this design effort
Cartel - a digital product design firm focusing on research, strategy, and UX design for the next generation of enterprise software companies
Various members of this community, including Airbnb, Lyft, and others

We hope that this new design direction will carry Superset forward for the foreseeable future, and create a unified design system upon which to build future features. Community feedback is welcomed, and when this SIP is voted in, further efforts will be undertaken to break down the design into smaller units of work.
Process used in this effort:
Efforts began with the announcement of a call for volunteers in a design interest group, via the Superset dev mailing list, and on the Superset Slack workspace. The search for members of this small group targeted individuals who were able to commit 2+ hours per week, have a history of involvement/merit with the project, have a sense of design, and understand Superset users and use cases.
A "Superset Design Group" email was set up, as well as a private channel on the Superset Slack workspace, to maintain an open line of communication throughout the duration of the project
A kickoff meeting of the resulting group was held on September 4th, 2019. This initiated the creation and iteration of core user stories. This was quickly followed by an effort to assess the Analytics / BI marketplace, resulting in a competitive analysis report (this research is proprietary, and cannot be shared publicly).
Weekly design sync meetings took place each Thursday, allowing Cartel to get feedback on their latest design proposals from the team/community, and gather insight/direction on "big question" issues about the product's direction. After each session, prototypes were circulated, and feedback gathered via the slack and email channels. Each 1-week design sprint was comprised of ongoing work on larger concepts (e.g. the relationship between SQL Lab and Explore, or controls used to build data visualizations) as well as smaller, more specific tasks.
Summary of key findings
A product audit of Superset, user personas, and general product recommendations are available in an Experience Brief.
Special thanks
This process involved significant time and involvement from the following members of the Superset community for their participation:

Grace Guo (Airbnb / @graceguo-supercat)
Vyl Chang (Airbnb)
John Bodley (Airbnb / @john-bodley)
Sylvia Tomiyama (Airbnb)
Eli Brumbaugh (Airbnb / @elibrumbaugh)
Michelle Thomas (Airbnb / @michellethomas)
Maxime Beauchemin (Preset / @mistercrunch)
Rob DiCiuccio (Preset / @robdiciuccio)
Aaron Suddjian (Preset / @suddjian)
Tai Dupree (Preset / @nytai)
Beto Dealmeida (Lyft / @betodealmeida)
Micah Delfino (Cartel)
Jef Bekes (Cartel)

Proposed Changes
Notable changes to design and functionality
Visual Design

All UI fonts are changed to Inter UI for increased legibility, and fixed-width numeral options for tabular data. Code fonts have been changed to Fira Code. Both of these fonts are open source (license information below).

New default color palettes for dataviz. These have been checked for accessibility issues. Old palettes will be supported for backward compatibility.

A full style guide is available in the prototype, with specs for a variety of UI element interaction states, layout spacings (all based on an 8 pixel grid)

Style Guide (see abridged InVision)

Simplified global navigation.

Links to Home (see next item), Dashboards, Charts, Explore, SQL Lab, and Data

Current
New

Dashboards

New list/card view of all dashboards with ability to favorite dashboards, filter them by owner/status/dataset, search by name, sort by various metrics, or perform bulk actions.

New card view displays cards with rendered previews of the dashboard

Individual dashboards include new tools for each chart indicating data recency and  filters applied

Edit a chart's display options directly from the dashboard

New tab UI with dropdown overflow menu when there are too many tabs to display

New UI modal to define/edit global filters, with bulk action support

Current
New

New "Home" page

Offers the ability to view Dashboards, Charts, and Queries, sorted by popularity, recency, favorites, and ownership.

Activity steam, showing who did what in a Superset instance

Current
New

Explore

Visualization type selector, with viz plugins broken out into categories (e.g. timeseries, distribution, composition, etc)

Left panel for dataset selection and resulting display of fields

Updated query panel, with visualization controls utilizing new "pills" containing field metadata and controls (e.g. aggregation, sorting)

New Save/Save As controls, highlighting potential implications from overwriting an existing chart

Dataset preview area, including data profiling in the column headers (i.e. histograms, null value count, statistical rollups, etc)

New Chart Options drawer in the top right, focused on visual aspects of the resulting chart

New UI to edit a dataset's source, fields, metrics, and more

History timeline with icons denoting query "run" and "save" events

New Time Picker input modal, with quick selection of various time ranges and granularities

Current
New

SQL Lab

Left panel has tabs for Data (a picker for databases/tables/fields) and Saved (a selector for saved Queries)

Data preview table with headers containing data profiling information (histograms, composition, etc)

Chart area to build quick/simple data viz to preview query results and/or add viz to a dashboard. Viz options here are limited in scope/complexity. If your needs expand beyond these simplified viz options, there's an option to move over to Explore.

Explore button, allowing users to take their SQL queries into Explore for more advanced viz options with expanded controls

History panel with icons and data-rich tooltips indicating when queries were run or saved, and the details thereof

Full Query history with timeline, query preview, and option to group by session

Current
New

Data section

Contains sortable/searchable/filterable card or list views of Datasets (i.e. "physical" static/tablular datasets or "virtual" dynamic query results), Databases, Saved Queries, and Query History. Each of those tabs displays various metadata (e.g. access statistics) and actions (edit, delete, etc) for the resulting items

Viewing a Physical or Virtual Database displays its Fields, Metrics, and Usage tabs displaying various statistical and historical/analytic metadata details

Current
New (Datasets)
New (Fields)

Charts

New list/card view of all charts with data source display, ability to favorite items, sorting (e.g. by time last updated), and filtering by ownership and status.

Current
New

Global Search

Improved search and discovery of dashboards, queries, dataset titles, and possibly more

Results can be filtered by type

Default (prior to typing) list of recent or commonly accessed items

Current
New (default, no input)
New (search results)

N/A

Design proposals, in the form of InVision prototypes, are encapsulated in the deliverables available here:

Select screens (key features and concepts)
Unabridged screens (contains some details yet to be entirely fleshed out)

Removals and deprecations

Tabs in SQL Lab have been removed (See related SIP).

Maintenance and improvement of design assets
For maintaining the new design work (and assets stemming from it), the current proposal is to maintain the creation of a Superset team on Abstract. The latest Sketch files will be made public and open source, and managed via Abstract's version control system. PMC members from the Superset community may reach out to the PMC mailing list to submit designers or design teams to be added to the Abstract team to contribute to the design. The latest master version of the files will be maintained in the public InVision prototype, maintained by Preset (though interested parties may request comment or write access, granted on a case-by-case basis).
User testing and validation plan
Design and feature proposals submitted herein were conducted using the Superset Design Group as a focus group, making sure that functional and visual changes to the UI address the issues and use case criteria of those involved in the discussion. It is our intent, and belief, that these designs push the usability of Superset forward greatly. We anticipate that individual features and UI elements will require further input and discussion, as this "north star" for design begins to play out. Our hope is that this round of design will provide a foundation to test further iterations/variations, and those results will bear out in additional SIPs and PRs on a case-by-case basis.
Updates to Superset documentation
Documentation and Screenshots for Superset exists in a number of places, most notably on the Apache website and on the Github repo. A best effort should be made to update these resources with updated screenshots and/or instructions as relevant as PRs are written to move the project toward this new UI. If any changes are encountered that require large scale changes to documentation, those changed should be discussed in an additional SIP.
New or Changed Public Interfaces
TBD — Impact will be minimized on existing interfaces, but implementation of workflows and features may require changes to how APIs and metadata are structured and/or accessed.
New dependencies
The scope of third party dependencies is not entirely known at this time, but will be defined and assessed in future PRs as the work is broken down into smaller tasks. An effort will be made to make sure all licenses are compatible with Apache License v2.0.
Some known licenses thus far include:

Inter UI (font) — SIL OpenFont license (needs to be labeled in ASF releases)
Fira Code (font) — SIL OpenFont license (needs to be labeled in ASF releases)

Migration Plan and Compatibility
Due to the broad scope of design and functional changes, several core sections of the codebase — both frontend and backend — will need to be modified in functionality and/or refactored. This will likely lead to a significant number of required database migrations. While breaking changes in backward compatibility will be made as minimal as possible, they may occur in subsequent PRs as this work is further scoped and ticketed, and should be tracked with semantic versioning in future releases.
For frontend implementation, it should be noted that an older version of React-Bootstrap is used in existing Superset UI components. This older version is built upon Bootstrap 3, which is built with LESS (as is much of Superset, allowing shared styles/variables). Upgrading components to a newer React-Bootstrap (and thus Bootstrap 4) would require migrating the bulk of the CSS codebase over to SASS, which is not ideal. The implementation of this SIP should iterate toward deprecating the React-Bootstrap dependency, in favor of bespoke components with custom LESS styles built around this new design system.
All changes, in the design and implementation of new components, should be "atomic" in nature, steering toward a more unified design/component system, targeting reusability and consistency.
Rejected Alternatives
No alternatives at this time. We've considered previous design-related SIPs in this process, and have reached this proposal with input from several active PMC members. We're open to feedback, however, so please feel free to leave constructive feedback below. This work is to be considered foundational, and will undoubtedly continue to evolve with the ongoing support of the Superset community.

FYI - I kicked off a vote on the dev@ mailing list

🎉 🎉  Congratulation on passing the SIP! Will there be another SIP soon to discuss the frontend solution to implement this? It seems there are a lot of unclosed items in this thread.

@ktmud There will probably be several SIPs as this gets parceled out, but there are a few worth noting right now:
SIP-37 deals with using CSS-in-JS to migrate away from LESS and restructure how and where styles are applied
SIP-30 tackles the removal of SQL Lab tabs
SIP-38 deals with visualization plugins, which is at least part of the puzzle toward this SIP.

Thanks for the links, @rusackas !
I think one of the most important questions still not clear to me is, are we going to completely migrate away from react-bootstrap and FAB? And

Should we use another full-fledged UI library like Lunar or Ant Design and build a custom theme?
Or, if we are to build all UI components by ourselves, will we consider using a primitive UI component library such as Rebass,  React components and Theme UI?

This seems to warrant its own SIP.

@ktmud SIP-37 takes on a little of this discussion, so perhaps that's a better place for it, but one key idea is that we should remove the need for Bootswatch/Cosmo, which at least then provides the opportunity to at least upgrade react-bootstrap. After that, I think the situation is worth reassessment, and possibly another SIP. My thought would be to start whittling away react-bootstrap using custom components - at least where it's easy/pragmatic to do so, just to reduce reliance on that dependency. I'm hesitant to embrace another full library, but with CSS-in-JS, it should be possible to make a transition if necessary, or even mix and match more easily, if needed.

I am very concerned that the proposed major re-designs proposed (and approved) appear to add significant complexity for SuperSet administrators and end users.  Also, a big concern about a push to "custom components", rather than more standardized open source components provided with the open source kit now.  Statements by @rusackas "whittling away react-bootstrap using custom components" and by @ktmud "if we are to build all UI components by ourselves" suggest that this is what is underway.   @rusackas "The implementation of this SIP should iterate toward deprecating the React-Bootstrap dependency, in favor of bespoke components with custom LESS styles built around this new design system."   The comment by @gbrian "merge SQLAB and Chart Explore" seems to decomponentize the design; it does not retain separation of GUI concerns for the user.
Deprecating major technologies like React-Bootstrap in the name of "simplification" for developers will introduce yet another reactive framework, and delay the user community getting a version 1.0 product.  It adds a lot of complexity for end users who just want to stand up something quickly that scales in performance and functioality, and is highly usable.
This complete redesign completely torpedoes a lot of standard functionality provided "out of the box" that is required to almost effortlessly stand up a running system with minimal effort.  We want a completely working system that includes all servers, subsystems, data connectors, and a decent looking GUI that requires NO customization to get running, and provides tool to customize from a working system.
This product has been "incubating" for several years already.  The proposed redesign will require Apache "re-incubation" for another year or two.    If it ain't broke, don't fix it.
What is really going on here?  It appears like commercial professional software consultancies wanting to add complexity to a product to guarantee job security for staff, or perhaps guaranteeing that SuperSet v1.0 never finishes incubating, and always requires experts to set up.  This is reminiscent of the ways that Oracle, IBM, and Microsoft wage in IEEE, ASTM, and ISO fight standards wars by putting technical staff on IEEE, ASTM, and ISO standards committees to guarantee that a standard specification is never implemented.  The likely culprits in this advanced analytics and business intelligence open source war for software are Tableau, Tibco, Microsoft, and other BI advanced analytics vendors who don't want more open source competition.  They would love to stall Superset more or less permanently.
Users DO NOT WANT a complex expert-driven procedure to stand up a Superset system or tailor it.
We need a SIMPLER process to stand up a Superset instance, NOT MORE COMPLEX.   We need a simple one-step installation to get up and running and configuring "sensible default" dashboards.  Something as simple as "docker pull" followed by "docker run", point your browser here, and open your first visualization.
Remember to target end users (analysts and dashboard assemblers, not programmers) in 95% of all work that you do, because that's who going to be using it the most.
Finish incubating and shipping v1.x of SuperSet before a doing total redesign.

Is this currently being worked on? Does anyone know when we are likely to see these changes being implemented?

Hi @rplescia, yes, the team at Preset is working on it. We'll be releasing in small increments, the first pieces of refactored UI should be out (behind a feature flag) in the next 4-8 weeks

@benceorlai That's super, thanks for the update!

@rusackas it looks great looking ui  takes the charts to the large extend

when will this new design be available to us?

we are rolling out the new design in phases, you should expect major
changes like home screen, cardview layout and minor cosmetic UI changes
coming soon. Global filter, navigation and search, dataset UI and more are
in the pipeline. :)
On Fri, Aug 14, 2020 at 6:47 AM Steven Sun<EMAIL_ADDRESS>wrote:

when will this new design be available to us?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/issues/8976#issuecomment-674082897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQFR5UZMOGEXAK44RHNP22DSAU6A7ANCNFSM4KHMFP5A
.

@isunix It's also worth mentioning that several incremental improvements (though not all of them) are linked to in threads above your comment... e.g. we're slowly rejiggering components in a "horizontal" approach, while taking "vertical" approaches to things like the list views, which are available now under a feature flag.

Sorry for any Github notification noise, but I made a small attempt at finding recent PRs that were in service of this SIP. As we go forward, hopefully we can keep adding the mentions, to keep people informed here about progress being made.

@rusackas should we just add ad SIP-34 label to those PRs or create a SIP-34 project?

Is there a Docker container available that just runs successfully on Windows 10, i.e., is Windows 10 supported yet?
If Can someone provide a pointer to a video tutorial to set up Superset on Windows 10?

@rusackas should we just add a SIP-34 label to those PRs or create a SIP-34 project?

A label is a good idea for sure, but my main intent was to show forward motion on this issue's thread. There seemed to be a pattern around issue mentions already, particularly the "Has associated issue:" checkbox, which is what got me thinking the mentions might be a good idea. A project might also be helpful, but I didn't want to add more overhead work.

Is there a Docker container available that just runs successfully on Windows 10, i.e., is Windows 10 supported yet?
If Can someone provide a pointer to a video tutorial to set up Superset on Windows 10?

Not to my knowledge, but there are a number of issues touching on the topic, or you can open a new issue specifically about that.


Start deduce_memory_cell method

@Juan-M-V please update the files

This function wont be implemented until deduction rules are in place


Transformation not applied when there are multiple nodes/meshes with different skins

As soon as I use several meshes with different skins that are parented to a transformed node, the meshes in the converted usdz file all seem to end up in the same place.
The picture below shows the issue which occurs when converting a gltf file (left side) to usdz (right side) with this tool.

Here are the gltf and usdz files where the issue happens: model.zip

This is roughly how the nodes in gltf file are structured:

column_base (static mesh)
column_middle (scaled on the y axis)
column_head_plate (translation on y axis)
module (empty node with translation/rotation)

module_plate_armature (empty node)

module_plate (mesh with skin)
top (joint, top part of the module plate)
bottom (joint, bottom part of the module plate)
module screws ...

module (same as above but different transformation)

Besides that, there is a shading issue when I only have a skinned mesh in the scene.


How to get value programmatically on date selected?

Hello!
I am trying to get updated value after user choses date or closes the popup.
In jquery ui they provide onSelect option
which allows to bind event handler with value argument.
Is there any similar option?

P.s. I've read Events section in documentation, but I am not sure if they are
appropriate and how to subscribe for example to dp.change() event.
Could you please provide quick example?
Thanks!

It should work like this.
$('editor').on('dp.change', function(e) {
  var date = !e.date ? null : e.date.toDate();
});

Note that e.date is falsey or a moment instance, hence you have to call toDate() to get the javascript Date instance.


Unable to run rc_test_servos on latest image release.

When trying to run rc_test_servos on the latest beaglebone image release (AM3358 Debian 10.3 2020-04-06 4GB SD IoT) on a Beaglebone Blue, the error below is returned.
debian@beaglebone:~$ sudo rc_test_servos -c 1 -p 0.0
ERROR in rc_pru_stop while writing to remoteproc state: Operation not permitted
ERROR in rc_servo_init, failed to start PRU1

Can you try the V1.0.5-RC2 release?

Hey @ansarid was your issue solved or is there any new errors you are facing?
Kindly close this issue if your issue has been solved

@DhruvaG2000 @jadonk The issue no longer exists, and I forgot about this issue, sorry!

Hi, I had the same issue as shown below. But the scenario is as follows: Had three boards one with older version ad other two with 1.0.5 version updated. The older version has -v option enabled where as the 1.0.5 version is removed and seem to have hard coded. the two biards with 1.0.5 version , the same procedure followed for updating OS and librobo. But one board has no issue but anither board failed giving the the following messgae. Great if some one helps.
debian@beaglebone:~$ sudo rc_test_servos -c 1 -p 0.0
ERROR in rc_pru_stop while writing to remoteproc state: Operation not permitted
ERROR in rc_servo_init, failed to start PRU1


Working PropertyTemplateOutline using embedded Resource Template in PropertyPanel Component

As documented in issue #388, in the current master branch, for embedded resource templates in a PropertyPanel is not rendering the Resource Template, like Has Bibframe Instance below:

This PR adds that rendering support:

Remaining TODOs:

[x] Add support for InputLookupQA
[x] Deduplicate this.state.output
[x] CSS and/or HTML changes to reduce left margin.
[x] Unit tests for this expansion

Coverage decreased (-1.02%) to 76.233% when pulling 32bd2015502f30a9e875d79da05eb7c3e65b1e8d on internal-rt-outline into 949781d0078ed1e27979ef44d791e9fdda12797f on master.

LGTM! I'd just like to see a bit higher coverage if possible on the one test mentioned 👆if possible.


./log4jscan.sh: 104: Syntax error: word unexpected (expecting ")")

Like it says... I get a:
./log4jscan.sh: 104: Syntax error: word unexpected (expecting ")")

Hi,
Thanks for the feedback.
Seems like the bash version you are using is not supporting arrays.
what version do you use?
lines 100-105 (of the current version - v1.0.1) are used to avoid from printing info about files already found during the scan.
You can try to remove them, the scan itself won’t be affected, but you might see the same result multiple times.

$ /bin/bash --version
GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
Should be pretty standard/up-to-date
Anyways if I remove lines 100-105 I get:
./log4jscan.sh: 67: Bad substitution

Hi,
I have managed to reproduce the errors you got by executing the script like this: sudo sh ./log4jscan.sh
Is it possible that the script is not being executed by bash in your environment?
Could you please share how you execute the script?
Also, could you please share the output of ls -l /bin/bash?

OMG.. you're right. I AM ashamed.. .thank you for your support.

No worries :)
Feel free to reach out if you encounter additional issues.


Remove scalaz dependency?

It seems that coursier is only using \/ and Task from scalaz - and only a very limited subset of the features of Task, to the point that the scalajs lib already has its own Task implementation...
And \/ is just not a big enough incentive, the standard Either could replace it.

A step toward (or tangent to) that in https://github.com/alexarchambault/coursier/commit/e20b93326d9a1beb8e0d7672c67e1cc4e47aee45... makes the core module depend only on scalaz-core (for Monad), no more on scalaz-concurrent (now depended upon by coursier-files, that supplies Task as Monad to core).
If :cat: had an equivalent of scalaz.concurrent.Task, it could just replace scalaz here.

Some library authors do copy-paste of external code to keep dependencies at minimum. Perhaps taking monix Task until cats get one.

monix & cats interoperate well. remove / in favor of either?

this is causing problems with sbt-ensime, I'll link in a moment

I'm not sure if this is still happening at some point, but I'm still waiting on this to happen before including Coursier inside Ammonite.

@lihaoyi I'll see if I can publish JARs of coursier that would shade scalaz. It's too slow to do with the current version of sbt-shading, but that could be circumvented I think.
Or maybe you could shade coursier plus its dependencies from Ammonite (provided that that can be done fast enough with sbt-shading). Could that be a solution for you? It's done in ensime-sbt here.

we leave our scalaz dependency transitive because it is too slow.

A Coursier jar with a shaded version of Scalaz would be great, and I'd use it

vote to close, shading works great!

Is this fixed? coursier-cache doesn't bring in scalaz anymore
$ coursier fetch io.get-coursier:coursier-cache_2.12:1.1.0-M6
/Users/ollie/.coursier/cache/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.12.6/scala-library-2.12.6.jar
/Users/ollie/.coursier/cache/v1/https/repo1.maven.org/maven2/io/get-coursier/coursier_2.12/1.1.0-M6/coursier_2.12-1.1.0-M6.jar
/Users/ollie/.coursier/cache/v1/https/repo1.maven.org/maven2/io/get-coursier/coursier-cache_2.12/1.1.0-M6/coursier-cache_2.12-1.1.0-M6.jar
/Users/ollie/.coursier/cache/v1/https/repo1.maven.org/maven2/org/scala-lang/modules/scala-xml_2.12/1.1.0/scala-xml_2.12-1.1.0.jar

Yes, it's fixed. Closing!


Write binary form

Should be able to take an AST and encode it in the straw proposal binary form.

This has been fixed.


Different Nvidia drivers for each image?

Is it not possible to use the same Nvidia driver versions across ALL of your images. Otherwise as it stands I need to create a completely different AWS image for each docker container I want to run, given that the docker containers only seem to work when you have the precise point version of the Nvidia drives on the host.

Potentially, but using the latest version from a package manager is a moving target. The recommended installation method - the runfile - at least represents an unambiguous setup. If you can come up with reproducible steps (accounting for potential prior installations of CUDA on the host) then feel free to submit a PR.
NVIDIA provides their own solution for allowing a range of driver versions with NVIDIA Docker, but I will be sticking with a pure Docker solution for now (see https://github.com/Kaixhin/dockerfiles/issues/6 for more discussion).

Had a bit of a look at the nvidia docker but it looks like their own fork... Which doesn't interest me either....  ;-)


Game time doesn't reset when new game is started.

Expected behavior
The game time of each player should reset to the default game time that was set for each game everytime a new game is started.
Actual behavior
The game time does not reset and continue to countdown from the old game time even when chess piece colour are changed between players.
How to reproduce

Install app from playstore
Click on play
Click on the settings icon slider (3 dots beside option) at the top right corner.
Click on “set clock” and select any time apart from no clock option
Play the game for some time
Click on icon “new” among the icons present at the bottom of the chess board and click ok to reset the game (you may decide to change some options such as chess piece colour for easier spotting)

It will be observed that the even though the game has been reset, the time from the previous /old game was retained. Hence,the bug.

Browser/App version: Chess version 8.8.3
*Operating system: Android 6.0

Recording Of The Bug
https://youtu.be/HDIlfhuS24Y

This should finally be fixed now, thanks for posting.


pico: Fix default screen mode

Someone needs to setup blit::screen... Unbreaks everything that uses the "default" mode, which includes a lot of the examples :facepalm:
(Err, whoops)

Eek! Thank you. New release needed, I guess!

The worst part was that I'd already fixed the exact same thing in the SDL code in the PR.
There were quite a few combinations to test there though, so only missing one was pretty good.


feat: Added semantic.yml file and release

Have a green release step. This should trigger a release to rubygems I believe.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove deprecated prepare_data_per_node in Trainer

What does this PR do?
Part of https://github.com/PyTorchLightning/pytorch-lightning/issues/12521
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Not sure if the doc here needs changing? Would appreciate any advice here, thanks.
https://github.com/PyTorchLightning/pytorch-lightning/blob/cf65ca25b0230df89eec77c218c5e928c8141840/pytorch_lightning/core/hooks.py#L364

this should be good:
In DDP ``prepare_data`` can be called in two ways (using ``prepare_data_per_node``):

since there is already a reference for it right below :)


API Rename resources to _resources

Fixes https://github.com/silverstripe/silverstripe-framework/issues/7932
Requires https://github.com/silverstripe/vendor-plugin/pull/25
Also all other modules will need to have their vendor-plugin dependency bumped to ^2 as well. My suggestion is to get the module merged first and migrate the modules one at a time.

To discuss:

4.x or 5.x?
soft-code or hard-code?
_resources as a default or something else?

4.x or 5.x?

I don't see how this wouldn't be a breaking API change :( .

soft-code or hard-code?

+1 for making this name configurable in 5.x. Can we do some composer.json configuration to make that work?

I tend to agree with @ScopeyNZ. This will be very disruptive to our module ecosystem. Can we not do this but just make it configurable at the project level from SS5 on?

Looks like we'll need to soft-code it. If it's not configured, it'll need to default to resources (per the constant), but we will probably need to do it in 5.x if existing 4.x code assumes the hard-coded value.

https://github.com/silverstripe/silverstripe-framework/pull/8364 should supersede this PR I think. Unless someone has objections, I'll close this one.

Closing in favour of #8519


Keep track of emitted in emitter.

Issue #, if available:
Description of changes:
In #278, we try to avoid having a long-standing lock around all emissions in a subtree. It causes a race where subsegments may be emitted multiple times. This is because the current emitted isn't being kept track of by the emitter actually, it's set by the caller. This PR splits into emitted, which is intended to prevent double-emission, and ended, which is intended to prevent mutation of an ended entity.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #279 (7c9b078) into master (57c11db) will decrease coverage by 0.30%.
The diff coverage is 35.00%.

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
- Coverage     59.57%   59.26%   -0.31%
+ Complexity     1210     1207       -3
============================================
  Files           131      131
  Lines          5046     5060      +14
  Branches        586      589       +3
============================================
- Hits           3006     2999       -7
- Misses         1767     1786      +19
- Partials        273      275       +2

Impacted Files
Coverage Δ
Complexity Δ

...a/com/amazonaws/xray/entities/DummySubsegment.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../main/java/com/amazonaws/xray/entities/Entity.java
100.00% <ø> (ø)
3.00 <0.00> (ø)

...zonaws/xray/strategy/DefaultStreamingStrategy.java
87.09% <ø> (-0.41%)
14.00 <0.00> (ø)

...n/java/com/amazonaws/xray/emitters/UDPEmitter.java
31.42% <14.28%> (-21.91%)
5.00 <0.00> (-2.00)

...n/java/com/amazonaws/xray/entities/EntityImpl.java
88.01% <14.28%> (-1.70%)
68.00 <0.00> (ø)

...java/com/amazonaws/xray/entities/DummySegment.java
15.09% <100.00%> (-3.01%)
3.00 <1.00> (-3.00)

.../java/com/amazonaws/xray/entities/NoOpSegment.java
98.79% <100.00%> (+0.01%)
79.00 <1.00> (+1.00)

...va/com/amazonaws/xray/entities/NoOpSubSegment.java
94.80% <100.00%> (+0.06%)
68.00 <1.00> (+1.00)

.../java/com/amazonaws/xray/entities/SegmentImpl.java
87.50% <100.00%> (ø)
22.00 <0.00> (ø)

...va/com/amazonaws/xray/entities/SubsegmentImpl.java
75.00% <100.00%> (ø)
15.00 <0.00> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c11db...7c9b078. Read the comment docs.


glsl-to-spv-worker: use output_dir and other fixes

Fix glsl-to-spv-worker and runspv to consistently use the output_dir parameter, instead of sometimes writing files to the current directory.
runspv: remove final accidental of writing to "logfile".
Base output directory on job name.
Clear output directory before start; avoids name clashes from previous results; avoids having to delete individual files that could be missed.
Do not use os.chodir.
Fix skip_render flag for legacy host.
Fix #317 files may clash with previously pulled files.
Fix #352 skip render flag not passed on legacy host.
Fix #353 some files are still written to current directory instead of output dir

I marked some failing tests as skipped; they are transparency issues, plus the spirv-opt test fails for me; possibly a bug in my device's drivers, as the image do indeed look slightly different.


Add @inquirer/prompts to Command Line Prompts

This is the modern version of inquirer (and powers the legacy API behind the scenes.)
Before submitting your pull request, please make sure:

[x] To use the exact package name as it appears on NPM (and npm install <package-name>)
[x] The packages are listed in alphabetical order
[x] The package doesn't already exist in a different category
[x] Description doesn't have a dot (.) at the end
[x] To format with Prettier before committing (npm run prettier)

Thanks @SBoudrias ! The new inquirer package is now live at https://nodejstoolbox.com/categories/command-line-prompts


Error opening file

I get an error message when trying your software. After looking for brd files i found one on github, which resulted in the error described.
https://github.com/sparkfun/Si4703_FM_Tuner_Evaluation_Board/blob/master/Hardware/SparkFun_Si4703_Eval.brd

This is an eagle cad file that just happens to share the same extension as the files we use.  They are not intended to be compatible.  I'm guessing you should close this issue.  Here is an example of a file that does work.
LB#820-2530 Macbook_13_A1278_K24.zip

thanks for the infos

If anyone is actually interested in eagle cad files, please open a new issue


Changes to Hedwig.Message

Hey Hedwig adapter folks!
@jwarlander @bryanjos @jeffweiss
I've just pushed some changes to Hedwig based on some irritations I found with my implementation and I wanted to get things squared up before pulling the trigger on 1.0.
Here are the changes: https://github.com/hedwig-im/hedwig/commit/18273f14fb8a6d5869551f0c7a3d2eebb2b3662a
All you'll need to do for your adapters is remove the adapter key from the %Hedwig.Message{} struct. The rest should be transparent.
If you have any other feedback...I would love to hear it!

@scrogson :+1: corresponding change in hedwig_irc is jeffweiss/hedwig_irc@43e414435bdbead002113a7e889a9d8168806f2e

@scrogson :+1: works perfectly!


GitHub Releases are not shown (except to repo owner)

In https://github.com/fohrloop/wakepy/releases all releases are marked as Drafts and they're not connected to any existing tags.
This requires two fixes:

[x] Publish the already made releases under the correct tags
[ ] Fix the publish-a-release workflow to make the releases correctly from now on

Possibly related: https://github.com/fohrloop/wakepy/issues/328

This requires two fixes:

Publish the already made releases under the correct tags
Fix the publish-a-release workflow to make the releases correctly from now on

Okay now it's not possible to run the release workflow in any other way than selecting a tag which starts with "v". Or, at least running it on main won't work:

It seems to work now!

Title is correct
Tag is correct
Status is Draft (waits for changelog edit)

Have to still add the pypi publishing back


Fix regression in i2c_master_read() which rejected all data lentghs.

Thanks @PerMalmberg . I've pushed these into our internal review & merge queue.
For future reference, fixes like these are very welcome but please open separate PRs for unrelated issues/fixes.

Ah, I see that the commit for logging was maybe introduced here by mistake and duplicated in #1444. As these are very small fixes I'll delete the other PR and we'll try to merge these both as one.

@projectgus Oh, GitHub doesn't take into consideration what commit the PR was created from. Good to know. Thanks for not making me redo the PR. :)


Unclear how to set "splinter-screenshot-dir" to send failure screenshots to a particular directory

Hello, thank you for the great project!
I'm trying to get failures to go to a specified ignored folder so they don't clutter up my project root, but I can't get it to work.
In my .pytest.ini, I've tried things like this:
-splinter-screenshot-dir = tests/acceptance/failure_screenshots

but this gives the error
.venv/lib/python3.11/site-packages/_pytest/config/__init__.py:1373: PytestConfigWarning: Unknown config option: -splinter-screenshot-dir

    self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

I've also tried passing it in command-line args, e.g:
pytest -splinter-screenshot-dir blah my_test.py
pytest -splinter-screenshot-dir=blah my_test.py
pytest splinter-screenshot-dir=blah my_test.py
pytest tests/acceptance -splinter-screenshot-dir=tests/acceptance/failure_screenshots
But still get
===========================
pytest-splinter screenshots
===========================
png:  /Users/jeff/Documents/Projects/lute_v3/tests.acceptance.test_smoke/test_hit_main_page-browser.png
html: /Users/jeff/Documents/Projects/lute_v3/tests.acceptance.test_smoke/test_hit_main_page-browser.html

The folder I'm using exists.
I've read the docs and searched, but can't see how to do it correctly.  Advice appreciated.  Thank you!

Ha, hilarious.  The docs at https://pytest-splinter.readthedocs.io/en/3.3.2/#example have the options with a single dash.  Copy-paste:
–splinter-screenshot-dir
pytest-splinter browser screenshot directory. Defaults to the current directory.

but the actual setting needs to be a double dash:
pytest tests/acceptance --splinter-screenshot-dir=tests/acceptance/failure_screenshots

So the docs need a fix.  I'll check this repo.

It's just the readthedocs docs that need the fix.  The docs in this repo at https://github.com/pytest-dev/pytest-splinter/blob/master/README.rst are correct.  Well that was a waste of time.
ref https://github.com/sphinx-doc/sphinx/issues/9871 - double dash shows up as single em dash.
If you'd like I can PR to this repo to add double-single-backticks around each of these items, which should fix it for readthedocs as well.

(and thanks again for the great project :-P )


Add silent flag to validate() to allow or disallow printing includes

Currently, when _validate_include() is called, included validators are printed to stdout. This is noisy and slows down validation for deeply nested schemas.
For example, suppose I have this schema:
id: int(min=1)
title: str()
content: list(include('headingT'), include('paragraphT'))
---
headingT:
  heading: str()

paragraphT:
  paragraph: str()

and this file:
id: 1
title: This is a title
content:
- heading: This is a heading
- paragraph: This is some text

Validating this file will produce the following output:
>>> import yamale
>>> _ = yamale.validate(yamale.make_schema('schema.yaml'), yamale.make_data('data.yaml'))
('heading', String((), {}))
('paragraph', String((), {}))
('heading', String((), {}))
('paragraph', String((), {}))
>>>

This change turns this off by default:
>>> import yamale
>>> _ = yamale.validate(yamale.make_schema('schema.yaml'), yamale.make_data('data.yaml'))
>>>

Pass silent=False to validate() to get the old behavior:
It's possible the print() (see this line) was just a debugging artifact, in which case, it would probably be better to just delete it.

This print statement was an oversight. I've just removed it in #26

Thanks for the quick response!

No problem, thanks for pointing this out. :+1:


rtmros_hironx: 1.1.10-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository rtmros_hironx to 1.1.10-0:

upstream repository: https://github.com/start-jsk/rtmros_hironx.git
release repository: https://github.com/tork-a/rtmros_hironx-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 1.1.7-0

hironx_calibration

No changes

hironx_moveit_config

No changes

hironx_ros_bridge
* use stupid code instead of using termcolor #437
* Contributors: Kei Okada

rtmros_hironx

No changes

Retriggering Travis...


All default Machete maps should be DateTimeOsset instead of DateTime

All maps that are defined within Machete should be DateTimeOffset instead of DateTime. Imagine parsing the following:
20170502173021.1212-0800
Using DateTime the time zone component (i.e. -0800) would be lost, thus, going against the primary tenant of the parser not being destructive. However, with using DateTimeOffset you get the same functionality of DateTime and the accuracy of the time zone component.
For developers wanting to go against this recommendation in user-define maps we should provide the following extension methods:
DateTimeOffset ConvertTo(this Value< DateTime > value)
DateTime ConvertTo(this Value< DateTimeOffset > value)

already done. closing


Couldn't save active energy

I save workout sample like this:
let workoutOptions = {
                end: endDate,
                totals: {
                    energyBurned: calories,
                    activeEnergyBurned: calories,
                },
}

await HealthKit.saveWorkoutSample(66, [], startDate, workoutOptions);

It saves workout but not an active energy.
if calories are 100, apple health app shows related sample 100kcal total active energy, but when i click it, active energy page is empty.

I haven't saved workouts with active energy myself. Are you sure it's not just a matter of how it's presented by the Apple Health app?
One thing I've noted before is when manually (as a user - in the Apple Health app) adding active energy it doesn't seem to affect the Apple Watch rings (which I guess makes sense from a cheating standpoint :). Might be a related pattern.

@SergiOnGit Do you mind sharing how you request authorization for saving a workout sample, and how you configured the plugin in app.config.js? I have been trying everything to get the workout write authorization to work, but nothing works for me. Thank you.

@SergiOnGit Do you mind sharing how you request authorization for saving a workout sample, and how you configured the plugin in app.config.js? I have been trying everything to get the workout write authorization to work, but nothing works for me. Thank you.

const permissions = {
    read: [],
    write: [
        HKQuantityTypeIdentifier.height,
        HKQuantityTypeIdentifier.bodyMass,
        HKQuantityTypeIdentifier.activeEnergyBurned,
        HKWorkoutTypeIdentifier,
    ],
};

await HealthKit.requestAuthorization(permissions.read, permissions.write);

This is how I request authorization. I don't have anything in app.config.js, I simply add important keys to info.plist like this:
<key>NSHealthShareUsageDescription</key> 	<string>Read and understand health data.</string> 	<key>NSHealthUpdateUsageDescription</key> 	<string>Share workout data with applekit.</string>

I haven't saved workouts with active energy myself. Are you sure it's not just a matter of how it's presented by the Apple Health app?
One thing I've noted before is when manually (as a user - in the Apple Health app) adding active energy it doesn't seem to affect the Apple Watch rings (which I guess makes sense from a cheating standpoint :). Might be a related pattern.

I am not sure if it should be as it is, users started complaining about it, so I think there is a problem.


ConfigManager folder location

The ConfigManager location for Integration Manager version 5.2.7697.1 is C:\Program Files\Microsoft Integration Runtime\5.0\Shared, not C:\Program Files\Microsoft Data Management Gateway\2.0\Shared.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 205b724d-450d-7112-3f2e-523d8ae79e07
Version Independent ID: cfe15589-168f-3520-2cbb-309a900a22e6
Content: Data Management Gateway for Data Factory - Azure Data Factory
Content Source: articles/data-factory/v1/data-factory-data-management-gateway.md
Service: data-factory
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@dbreit7
I have assigned the issue to the content author for further review and update the doc as appropriate.

Thanks for catching this and helping improve our documentation @dbreit7!  I updated this doc to correctly reflect the path and current version's service name.  It should appear later today.  I will close this issue out now but if you have other questions or need to continue the discussion you can reply here still.
#please-close


Build System

Ok for now I am going to hook up my teamcity server to GiveCRM repo and build it from there - i will also make a test site on my server and push deploys to there
i will work along the assumption of check in causes deployment for now
that way you can all monitor the progress - if anyone has any objections say ay!
Paul

i will work along the assumption of check in causes deployment for now
Sounds great! Will you be putting "gates" in place so that failed builds and test failures prevent that change from being deployed?

for sure - a successful build and successful unit test run (I will be adding a lot more of these) will cause a build and deploy :)

Cool! Some of us got round to writing tests, others didn't. The way of the weekend, I guess.

CI is good. Thanks Paul!

Ok the build will be on my build server
teamcity.paulstack.co.uk:8000
there is a giveCRM user
user: givecrm
pw: givecampuk
you can monitor the build on there
More to come on this

Any chance we can have a CI build for GiveCRM.Admin too please?
We'll have the same database project dependency that we have for GiveCRM by the way (Mark built both DB layers identically).

@stack72 Thanks for setting this up!  One question: how are the builds triggered?  I just checked TeamCity and there were two changes pending that had been sat there since yesterday evening.  I ran a build manually...
Not sure why Chris' change didn't fix the build either.

C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v10.0\TeamData\Microsoft.Data.Schema.TSqlTasks.targets" was not found
there is another reference to those TeamData GAC references - the build is now triggered by VCS checkin

@robinminto of course - i will set that one up in a bit (during lunch!)

Ah, sorry about that, looks like that file references two others in the program files directory.
If no-one objects i'll add the files and push to the repo.

@chris - go for it mate

I've added the files, but the build failed with a new error, looks like a library that comes with VS2010.

Ewwww, I feel dirty just reading the line,

The only way to do this and be in line with the licensing and support is to install a local copy of VS Pro or higher on your build box if not using TFS.

We are not installing VS on a build server - I just cannot allow it!

I love CI and I applaud the notion that we don't want to install VS on the build server, although it's a line I've never managed to hold (there are just too many good extensions that use it..) In this case though since portability of the project is important I think we have to keep a "no installing anything on the build server" rule intact.  That may mean we have to take a different approach to databse schema management.  For example, I've used an approach on our commercial products that is a PITA but ensures we can always upgrade databases at runtime when applications are fired up.

Based on our email discussions, @markrendle has some plans around the database and Simple.Data that would remove our dependency on the database projects.

Ok I have had to not include the DataBase project as part of the build - this means that we now have a successful build using PSake :)
I will tidy the script and then start auto deploy script to test.givecrm.org.uk


We want dhclient to go in to the background and manage the interface that gets the first DHCP offer. Using just -1 will make dhclient try once and exit with code 2 if it fails, otherwise daemonize it self and manage DHCP as usual.
@roymarantz @Primer42 @byxorna

:bullettrain_side: LGTM

:+1:
BTW, any idea why -timeout 15 is there?  AFAIK we are in no rush :-)

At first i thought dhclient would just keep sending DHCPDISCOVERs until it got a reply, but the default timeout seems to be a minute before giving up. I'll get rid of the timeout flag.

lgtm


refactor: ignore case of http request path

ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #96 (db55200) into dev (e7d02a7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev      #96      +/-   ##
==========================================
- Coverage   41.79%   41.78%   -0.02%
==========================================
  Files          48       48
  Lines        5780     5782       +2
==========================================
  Hits         2416     2416
- Misses       3141     3143       +2
  Partials      223      223

Impacted Files
Coverage Δ

pkg/filter/dt/filter_http.go
3.33% <0.00%> (-0.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d02a7...db55200. Read the comment docs.

LGTM

LGTM

LGTM


Hi thanks for the great work, how do i write a .numbers file back after some processing ?

Unfortunately it's not possible without very significant work. There is some early work on by @SheetJSDev for SheetJS which could be adapted but it's not something I've picked up yet.

@captanlevi what kind of processing did you have in mind? It's trivial to resave the document (I now have a branch for it) but different tasks will have different levels of complexity. Changing names and data without adding rows/columns is probably easiest. Adding rows and columns next level of difficulty and adding new sheets or tables the hardest.


Getting an error while trying to run inference.

Describe the bug
I'm not able to run inference with the command I've attached. Is the default code not pulling the latest docker images?
Steps/commands/code to Reproduce
python run.py --model_name gpt4 \
  --per_instance_cost_limit 2.00 \
  --config_file ./config/default.yaml

Error message/results
RuntimeError: Failed to create conda environment: Channels:
 - defaults
 - conda-forge
Platform: linux-aarch64
Collecting package metadata (repodata.json): ...working... /root/miniconda3/etc/profile.d/conda.sh: line 1:   262 Killed                  ( "$CONDA_EXE" $_CE_M $_CE_CONDA "$@" )

WARNING  ❌ Failed on pvlib__pvlib-python-1606: Failed to create conda environment: Channels:
          - defaults
          - conda-forge
         Platform: linux-aarch64
         Collecting package metadata (repodata.json): ...working... /root/miniconda3/etc/profile.d/conda.sh: line 1:   262 Killed                  (
         "$CONDA_EXE" $_CE_M $_CE_CONDA "$@" )

INFO     Beginning environment shutdown...
INFO     Agent container stopped
INFO     Found image sweagent/swe-agent:latest with tags: ['docker.io/sweagent/swe-agent:latest'], created: 2024-04-15T19:20:51.646667378Z for linux arm64.
DEBUG    Starting container with command: docker run -i --rm --name sweagent-swe-agent-latest-26cb2aa199 sweagent/swe-agent:latest /bin/bash -l -m
INFO     🌱 Environment Initialized
INFO     ▶  Beginning task 10
INFO     pvlib__pvlib-python not found in container, cloning...
INFO     pvlib__pvlib-python__0.9 conda env not found, creating...

System Information
MacOS M1
Checklist

[X] I'm running with the latest docker container/on the latest development version
[X] I've searched the other issues for a duplicate
[X] I have copied the full command/code that I ran
[X] I have copied the full log file/error message that was the result (if applicable)
[X] I have enclosed code/log messages in triple backticks (docs) and clicked "Preview" to make sure it's displayed correctly.

Please provide the full command that you ran.

Hi @klieret - I was able to resolve the issue. I had to manually do a docker pull as I somehow had a stale image from before. I'm closing this issue for now.


All the feeds are empty.

That can't be good, can it?

And now

An error occurred in the application and your page could not be served.

Thanks for reporting this, I'm on holiday at the moment but will look into it as soon as I can.

Most appreciated. I'll make do in the meantime.

oauth.v2.InvalidApiKey: Invalid ApiKey

Will check the configuration.

Should be fixed now, many thanks for the report.

Seems all good now. Thanks!


Fixed example in readme.

+ makes definitely for a prettier function, and it's in line with the toy example in the Intro.

Good catch! Thanks for your contribution :)

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   86.32%   86.32%
=======================================
  Files          22       22
  Lines        1667     1667
=======================================
  Hits         1439     1439
  Misses        228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151e3b0...d570fe4. Read the comment docs.


Final cucumber cleanup

I've moved the steps around a bit, and done a couple of renames. But frankly I want to leave this as is for a while and see what others think. And also move onto some actual feature work / bug fixes

ping @tgaff - Happy for this refactor to go in (Will probably cut the release after this)


Question: How to trigger the convo.ask callback only if the user mentions the bot

By default, the ask callback is triggered the next time the target user enters any message. I'd like to only trigger this callback if the target user's reply mentions the bot.
Desired behavior:
bot: @user how are you?
user: @bot great!
bot: @user you said "great!"

bot: @user how are you?
user: talking to someone else
# no response from bot
...
user: @bot doing fine now!
bot: @user you said "doing fine now!"

At a glance, I didn't see any properties in the response or convo that indicated whether the response included a mention or not. Thanks!

@ljfranklin try convo.source_messsage. It should have an event property which will be direct_message, direct_mention, ect.

I think is not possible so the ask callback will be triggered always BUT... you can check the response in the callback function and if this response don't start with @bot use convo.silentRepeat(), you know?
Try this:
´´´
convo.ask('how are you', function(response, convo){
if("CHECK THE response.text AS YOU WANT"){
convo.next();
}else{
convo.silentRepeat()
convo.next();
}
});
´´´

Closed as answered

@EloyRedondo thanks! Checking to see if the text contains bot.identity.name should do the trick.


Support for lexicons

AWS Polly allows lexicons (customized pronunciation files) to be used, but aws-tts doesn't support using these as far as I can tell. Any chance support for this could be added, even if users need to upload the lexicons separately through the console?

Absolutely. At the very least it could accept an argument to be passed to Polly's LexiconNames parameter.

A lexicon option is available in the v1.3.0 release now.


Opening Balances Best Practices

Can you please help share when opening balances are being created what fields are mandatory and which a desirable to fill in?
I ask this as when you create a config package (for AR opening balance for example) you end up getting many rows of data to be populated and it would be good to get some official guidance from MS on what fields should be filled in including weather a negative value should be used. Eg AP opening balances.
This page is detailed but no guidance is offered around best practices.
Thank you
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 168537d4-aab5-bc33-24f3-2808d30478ac
Version Independent ID: f568493d-e549-f834-3385-ddf5db8f44c1
Content: Migrate Customer Data - Business Central
Content Source: business-central/admin-migrate-customer-data.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: edupont

Hello Ben,
Thank you for your feedback! When you work with data in Excel, you can't tell which fields are required. But you can see that in the equivalent page in Business Central. For example, on the G/L Account Card page, you can see that only the No. field is required, though obviously it would only make sense if you also specified a name and whether the account must be used for the income statement or the balance sheet, and so on.
In general, we do not provide best practices for how to define general ledger accounts, or how to design your chart of accounts. This is because best practices depend on many factors, including industry, location, and, in some cases, personal habits or preferences of the accountant. So I'm closing this feedback entry as a Won't Fix.


chore: update deno_doc

LGTM

@kt3k there have been some additions to deno_doc that will be needed to be added to doc_components.
Also, had to update deno_doc in apiland, so want it to be everywhere in the website pipeline to be up to date as well, just to avoid issues.


Example not working with AEM 6.1

Hello,
I found this repo via AEM docs: https://docs.adobe.com/docs/en/aem/6-0/develop/extending/customizing-page-authoring-touch.html#Add a New Page Action
I want to add a new Page Action and it does not work. I use AEM 6.1 (no beta load!)
The nodes are all there and look good, but the overlay does not apply here and I cannot see the backtosites arrow.
When I compare the underlying classes, the one responsible for consuming this page action overlay is /libs/cq/gui/components/authoring/headerbar/headerbar.jsp
And I think this jsp does not use the ResourceMerger. You can also see that there is old coding style. compare with one of following. There the ResourceMerger works and I can do overlays under /apps.
/libs/granite/ui/components/foundation/layouts/cardview/cardview.jsp
/libs/granite/ui/components/foundation/hyperlink/hyperlink.jsp
   (node to overlay: /libs/cq/core/content/nav/publications)
/libs/granite/ui/components/foundation/layouts/multilayouts/multilayouts.jsp
  (node to overlay: /libs/wcm/core/content/sites/jcr:content/body/content/content/items/childpages/layout/layouts/card)

Do you agree that this example is not working with AEM 6.1?
I used following rev for my build: https://github.com/Adobe-Marketing-Cloud/aem-authoring-extension-header-backtosites/commit/fa76753dbcf8dd9aa41b0c470aef46244f0487b7

Agreed, I have tried this as well and it isn't working in 6.1.

The example is actually already working on AEM 6.1 (since fa76753); the documentation page from 6.0 is linked to the previous version of the package. The package from https://docs.adobe.com/docs/en/aem/6-1/develop/extending/customizing-page-authoring-touch.html#Add a New Page Action is working fine for me on AEM 6.1

Fair enough, although that's the one I was using too.
Just to make sure there wasn't an issue with my aem instance I recreated a fresh install, out of the box (Adobe Experience Manager Quickstart (build 20150521)), ran the maven command and installed the package. Nothing is showing. Although the JS clientlibs are coming through in the rendered HTML.

So I managed to get it to show, however I had to manually copy it to:
/libs/wcm/core/content/editor/jcr:content/content/items/content/header/items/headerbar/items
I obviously don't want to leave it there. I wonder if some inheritance somewhere is broken.

Hi, pinging this thread as it seems to have not had activity for a while. I just tried installing this demo on 6.1 as well with no luck. Was anyone else able to confirm working or not working with no additional steps?
Version: <IP_ADDRESS>50528

Update: after installing SP1, the example worked as expected. I was told that installing either the TouchUI feature pack or Service Pack 1 for 6.1 would correct the issue. I'm unsure as to what changed, but this is just so anyone else that might come across this can have a resolution-path.

Hi, I never really found a solution or got an answer. However I managed to make something happen using javascript in a client library folder with the category: cq.authoring.editor.hook
Good news on SP1, I'll try that.
Cheers,
ALex

The client library is actually already using the "hook" category name: https://github.com/Adobe-Marketing-Cloud/aem-authoring-extension-header-backtosites/blob/master/src/main/content/jcr_root/apps/wcm/core/components/backtosites/clientlibs/.content.xml.
Could you share more details on how it is not working? (Is the code loaded at least? Is there any JS error?)

@martinischeery
Experienced the same issue. When using 6.1 without the Touch UI feature pack or Service Pack 1: the sling resource merger does not find the headerbar --> items in apps.  Only those found in libs.  The js hook works fine.


Vcpkg installs dependencies after module source scan

Describe the bug
Vcpkg installs dependencies after the compiler scans for C++20 module dependencies, leading to build failure.
Environment

OS: Windows 11 26100
Compiler: VS 17.12 Preview 2.1

To Reproduce
Steps to reproduce the behavior:

Create a VS project using C++20 modules, and Vcpkg manifest mode. Have one of the ixx file import a header from a vcpkg dependency.
Build the project with the dependencies not yet installed.
Observe that vcpkg installs dependencies after source is scanned for dependencies, leading to build failures

Expected behavior
Vcpkg should install dependencies first and I should not have to built the project twice to get a successful build.
Failure logs
1>------ Build started: Project: TranslucentTB.Core, Configuration: Debug x64 ------
1>Scanning sources for module dependencies...
1>CoreThread.ixx
1>WinEventHookWatcher.ixx
1>EventQueue.ixx
1>RootHandler.ixx
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(6,8): error C1083: Cannot open header unit file: 'member_thunk/member_thunk.hpp': No such file or directory
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(503,5): warning MSB8074: Cannot read Module Dependencies file x64\Debug\WinEventHookWatcher.ixx.module.json: Expecting element 'root' from namespace ''.. Encountered 'None'  with name '', namespace ''.  The build order might be incorrect.
1>windows.h
1>base.h
1>thread
1>memory
1>functional
1>queue
1>algorithm
1>list
1>Installing vcpkg dependencies to Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\vcpkg_installed\x64-windows\
1>"Z:\vcpkg\vcpkg.exe" install  --x-wait-for-lock --triplet "x64-windows" --vcpkg-root "Z:\vcpkg\\" "--x-manifest-root=Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\\" "--x-install-root=Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\vcpkg_installed\x64-windows\\" --overlay-ports="Z:\TranslucentTB\vcpkg\ports"
1>A suitable version of cmake was not found (required v3.30.1).
1>Downloading https://github.com/Kitware/CMake/releases/download/v3.30.1/cmake-3.30.1-windows-i386.zip
1>Extracting cmake...
1>A suitable version of 7zip was not found (required v24.8.0).
1>Downloading https://github.com/ip7z/7zip/releases/download/24.08/7z2408-extra.7z
1>Extracting 7zip...
1>A suitable version of 7zr was not found (required v24.8.0).
1>Downloading https://github.com/ip7z/7zip/releases/download/24.08/7zr.exe
1>Detecting compiler hash for triplet x64-windows...
1>Compiler found: C:/Program Files/Microsoft Visual Studio/2022/Preview/VC/Tools/MSVC/14.42.34321/bin/Hostx64/x64/cl.exe
1>The following packages will be built and installed:
1><EMAIL_ADDRESS>-- Z:\TranslucentTB\vcpkg\ports\member-thunk
1>Restored 0 package(s) from C:\Users\Sylveon\AppData\Local\vcpkg\archives in 511 us. Use --debug to see more details.
1>Installing 1/1<EMAIL_ADDRESS>1>Building<EMAIL_ADDRESS>1>Z:\TranslucentTB\vcpkg\ports\member-thunk: info: installing overlay port from here
1>-- Downloading https://github.com/sylveon/member_thunk/archive/3acf1402af87de495f073233c9b842c230a7fb12.tar.gz -> sylveon-member_thunk-3acf1402af87de495f073233c9b842c230a7fb12.tar.gz...
1>-- Extracting source Z:/vcpkg/downloads/sylveon-member_thunk-3acf1402af87de495f073233c9b842c230a7fb12.tar.gz
1>-- Using source at Z:/vcpkg/buildtrees/member-thunk/src/c230a7fb12-78beb49d8f.clean
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/default_heap.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/default_heap.impl.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/function_traits.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/heap
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/heap/memory.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/heap/memory.impl.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/heap/region.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/heap/region.impl.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/list.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/list.impl.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/thunk
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/thunk/thunk.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/thunk/thunk.impl.arm64.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/details/thunk/thunk.impl.x64.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/exception.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/heap_not_empty.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/invalid_memory_layout.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/page_executable.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/page_full.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/region_full.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/region_not_empty.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/error/win32_error.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/heap.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/heap.impl.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/lock
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/lock/null_lock.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/lock/slim_lock.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/member_thunk.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/page.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/include/member_thunk/page.impl.hpp
1>-- Installing: Z:/vcpkg/packages/member-thunk_x64-windows/share/member-thunk/copyright
1>-- Performing post-build validation
1>Stored binaries in 1 destinations in 77.9 ms.
1>Elapsed time to handle member-thunk:x64-windows: 1.3 s
1>member-thunk:x64-windows package ABI: 5b87550bf59f783c896ac3115a8b8874a1b1af4de582342aa5ede638a4105433
1>Total install time: 1.3 s
1>member-thunk is header-only and can be used from CMake via:
1>
1>  find_path(MEMBER_THUNK_INCLUDE_DIRS "member_thunk/default_heap.hpp")
1>  target_include_directories(main PRIVATE ${MEMBER_THUNK_INCLUDE_DIRS})
1>
1>Compiling...
1>memory
1>WinEventHookWatcher.ixx
1>base.h
1>queue
1>thread
1>list
1>algorithm
1>functional
1>windows.h
1>Z:\Projects\ttb-rewrite\TranslucentTB\packages\Microsoft.Windows.ImplementationLibrary.1.0.240803.1\include\wil\result_macros.h(4095,20): message : sorry: 'inline' function definition for 'HRESULT wil::details::ResultFromExceptionSeh(const wil::DiagnosticsInfo &,void *,wil::SupportedExceptions,wil::details::IFunctor &) noexcept' could not be written to module due to unrecognized expression or statement at 'Z:\Projects\ttb-rewrite\TranslucentTB\packages\Microsoft.Windows.ImplementationLibrary.1.0.240803.1\include\wil\result_macros.h(4098,9)'.
1>Z:\Projects\ttb-rewrite\TranslucentTB\packages\Microsoft.Windows.ImplementationLibrary.1.0.240803.1\include\wil\result_macros.h(4095,20): message : If possible please provide a repro here: https://developercommunity.visualstudio.com
1>(compiling source file 'WinEventHookWatcher.ixx')
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(5,13): error C7612: could not find header unit for 'map'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(6,39): error C7612: could not find header unit for 'member_thunk/member_thunk.hpp'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(7,22): error C7612: could not find header unit for 'winrt/base.h'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(8,37): error C2230: could not find module 'TranslucentTB.Core.EventQueue'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(15,23): error C2061: syntax error: identifier 'EventQueue'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(45,13): error C2143: syntax error: missing ';' before '*'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(45,3): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(45,22): error C2238: unexpected token(s) preceding ';'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(46,3): error C2653: 'member_thunk': is not a class or namespace name
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(46,22): error C3646: 'm_Thunks': unknown override specifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(46,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(49,28): error C2039: 'map': is not a member of 'std'
1>    C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.42.34321\include\new(20,1):
1>    see declaration of 'std'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(49,3): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(49,39): error C2065: 'EventType': undeclared identifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(49,28): error C7568: argument list missing after assumed function template 'map'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(49,28): error C2062: type 'unknown-type' unexpected
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(49,67): error C2334: unexpected token(s) preceding '{'; skipping apparent function body
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(16,12): error C2065: 'queue': undeclared identifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(17,13): error C2653: 'member_thunk': is not a class or namespace name
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(17,27): error C3861: 'allocate_page': identifier not found
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(16,4): error C2614: 'TranslucentTB::Core::WinEventHookWatcher': illegal member initialization: 'm_Queue' is not a base or member
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(17,4): error C2614: 'TranslucentTB::Core::WinEventHookWatcher': illegal member initialization: 'm_Thunks' is not a base or member
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(19,25): error C2065: 'm_Thunks': undeclared identifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(19,15): error C2737: 'handler': const object must be initialized
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(20,97): error C3536: 'handler': cannot be used before it is initialized
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(20,32): error C2664: 'HWINEVENTHOOK TranslucentTB::Core::WinEventHookWatcher::CreateHook(DWORD,DWORD,WINEVENTPROC)': cannot convert argument 3 from 'int' to 'WINEVENTPROC'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(20,97):
1>    Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or parenthesized function-style cast
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(29,24):
1>    see declaration of 'TranslucentTB::Core::WinEventHookWatcher::CreateHook'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(20,32):
1>    while trying to match the argument list '(int, int, int)'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(21,30): error C2664: 'HWINEVENTHOOK TranslucentTB::Core::WinEventHookWatcher::CreateHook(DWORD,DWORD,WINEVENTPROC)': cannot convert argument 3 from 'int' to 'WINEVENTPROC'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(21,84):
1>    Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or parenthesized function-style cast
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(29,24):
1>    see declaration of 'TranslucentTB::Core::WinEventHookWatcher::CreateHook'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(21,30):
1>    while trying to match the argument list '(int, int, int)'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(22,25): error C2664: 'HWINEVENTHOOK TranslucentTB::Core::WinEventHookWatcher::CreateHook(DWORD,DWORD,WINEVENTPROC)': cannot convert argument 3 from 'int' to 'WINEVENTPROC'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(22,74):
1>    Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or parenthesized function-style cast
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(29,24):
1>    see declaration of 'TranslucentTB::Core::WinEventHookWatcher::CreateHook'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(22,25):
1>    while trying to match the argument list '(int, int, int)'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(23,29): error C2664: 'HWINEVENTHOOK TranslucentTB::Core::WinEventHookWatcher::CreateHook(DWORD,DWORD,WINEVENTPROC)': cannot convert argument 3 from 'int' to 'WINEVENTPROC'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(23,86):
1>    Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or parenthesized function-style cast
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(29,24):
1>    see declaration of 'TranslucentTB::Core::WinEventHookWatcher::CreateHook'
1>    Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(23,29):
1>    while trying to match the argument list '(int, int, int)'
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(25,4): error C2065: 'm_Thunks': undeclared identifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(31,11): error C2653: 'winrt': is not a class or namespace name
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(31,18): error C3861: 'check_pointer': identifier not found
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(38,25): error C2065: 's_EventTypeMap': undeclared identifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(38,20): error C2737: 'it': const object must be initialized
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(38,53): error C3536: 'it': cannot be used before it is initialized
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(38,59): error C2065: 's_EventTypeMap': undeclared identifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(40,6): error C2065: 'm_Queue': undeclared identifier
1>Z:\Projects\ttb-rewrite\TranslucentTB\TranslucentTB.Core\WinEventHookWatcher.ixx(40,25): error C2065: 'Event': undeclared identifier

Please provide a test case, thank you.

@jimwang118 clone https://github.com/sylveon/vcpkg-modules-issue, and open the solution in a VS IDE with vcpkg integration enabled vcpkg integrate install
Build the solution once, observe failure because Scanning sources for module dependencies... happens before Installing vcpkg dependencies:
Build started at 03:58...
1>------ Build started: Project: ConsoleApplication2, Configuration: Debug x64 ------
1>Scanning sources for module dependencies...
1>ConsoleApplication2.ixx
1>Z:\Throwaway\ConsoleApplication2\ConsoleApplication2.ixx(1,8): error C1083: Cannot open header unit file: 'fmt/format.h': No such file or directory
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(503,5): warning MSB8074: Cannot read Module Dependencies file ConsoleA.eb99e311\x64\Debug\ConsoleApplication2.ixx.module.json: Expecting element 'root' from namespace ''.. Encountered 'None'  with name '', namespace ''.  The build order might be incorrect.
1>Installing vcpkg dependencies to Z:\Throwaway\ConsoleApplication2\vcpkg_installed\x64-windows\
1>"Z:\vcpkg\vcpkg.exe" install  --x-wait-for-lock --triplet "x64-windows" --vcpkg-root "Z:\vcpkg\\" "--x-manifest-root=Z:\Throwaway\ConsoleApplication2\\" "--x-install-root=Z:\Throwaway\ConsoleApplication2\vcpkg_installed\x64-windows\\"
1>Detecting compiler hash for triplet x64-windows...
1>Compiler found: C:/Program Files/Microsoft Visual Studio/2022/Preview/VC/Tools/MSVC/14.42.34226/bin/Hostx64/x64/cl.exe
1>The following packages will be built and installed:
1><EMAIL_ADDRESS>1>  * vcpkg-cmake:x64-windows@2024-04-23
1>  * vcpkg-cmake-config:x64-windows@2024-05-23
1>Additional packages (*) will be modified to complete this operation.
1>Restored 3 package(s) from C:\Users\Sylveon\AppData\Local\vcpkg\archives in 61.5 ms. Use --debug to see more details.
1>Installing 1/3<EMAIL_ADDRESS>1>Elapsed time to handle vcpkg-cmake-config:x64-windows: 2.45 ms
1>vcpkg-cmake-config:x64-windows package ABI: 4e85a7fb39d4b005ff9c2c93fd745b9880e0ed0d9c578a05e1c409843145e5b2
1>Installing 2/3<EMAIL_ADDRESS>1>Elapsed time to handle vcpkg-cmake:x64-windows: 2.71 ms
1>vcpkg-cmake:x64-windows package ABI: 846de83b4df1dad300f045832b9f15280edba5be7ae3cc9cfbf8b2fcc6b35425
1>Installing 3/3<EMAIL_ADDRESS>1>Elapsed time to handle fmt:x64-windows: 7.46 ms
1>fmt:x64-windows package ABI: cc6434228732dc0525c9e3010f69f0700c69bdd80dcb7c44190908b39adbcd73
1>Total install time: 12.7 ms
1>The package fmt provides CMake targets:
1>
1>    find_package(fmt CONFIG REQUIRED)
1>    target_link_libraries(main PRIVATE fmt::fmt)
1>
1>    # Or use the header-only version
1>    find_package(fmt CONFIG REQUIRED)
1>    target_link_libraries(main PRIVATE fmt::fmt-header-only)
1>
1>Compiling...
1>ConsoleApplication2.ixx
1>Z:\Throwaway\ConsoleApplication2\ConsoleApplication2.ixx(1,22): error C7612: could not find header unit for 'fmt/format.h'
1>Z:\Throwaway\ConsoleApplication2\ConsoleApplication2.ixx(5,5): error C2653: 'fmt': is not a class or namespace name
1>Z:\Throwaway\ConsoleApplication2\ConsoleApplication2.ixx(5,10): error C3861: 'print': identifier not found
1>Done building project "ConsoleApplication2.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
========== Build completed at 03:58 and took 04.007 seconds ==========

Build the solution again, and notice it now works because the dependency was installed during the previous failing build:
Build started at 04:02...
1>------ Build started: Project: ConsoleApplication2, Configuration: Debug x64 ------
1>Scanning sources for module dependencies...
1>ConsoleApplication2.ixx
1>Compiling...
1>ConsoleApplication2.ixx
1>LINK : Z:\Throwaway\ConsoleApplication2\x64\Debug\ConsoleApplication2.exe not found or not built by the last incremental link; performing full link
1>ConsoleApplication2.vcxproj -> Z:\Throwaway\ConsoleApplication2\x64\Debug\ConsoleApplication2.exe
1>'pwsh.exe' is not recognized as an internal or external command,
1>operable program or batch file.
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
========== Build completed at 04:02 and took 01.795 seconds ==========

This should not be happening, the first build from a clean clone should succeed, i.e. vcpkg should install dependencies before the source scan.

@jimwang118 sorry, forgot to push, should be there now

I reproduced this problem locally. But the VS compiler prompts as follows: C++ IntelliSense support for C++20 Modules is currently experimental. Help improve the experience by reporting any issues at https://aka.ms/CppIntelliSenseModules. Affected file 'F:\vcpkg-modules-issue\ConsoleApplication2.ixx'.
This should be a compiler problem. You can submit the issue at https://aka.ms/CppIntelliSenseModules.


Update message on non-existing shared hooks. :anchor:

Coverage increased (+0.1%) to 80.074% when pulling 2cbd8a011b71350ed95fc031478f0ca3db90dc11 on feature/improve-message-on-non-existing-hook into 1da3c6b7e3d34006e162eed0c16740721b6b3bd9 on main.


Upgrade to ggicci/owl 0.4.0 and required go version from 1.19 to 1.20

Replaces https://github.com/ggicci/httpin/pull/74

Upgrades ggicci/owl from v0.1.7 to v0.4.0 (https://github.com/ggicci/owl/compare/v0.1.7...v0.4.0)
Upgrades from go 1.19 to 1.20
Switches owl.ReplaceDirectiveExecutor(name, exe) to owl.RegisterDirectiveExecutor(name, exe, true)

@alecsammon Thanks a bunch for the patch. Could you please upgrade the Go version of the GitHub Action as well?

Updated now - sorry I missed that!

Thank you for the quick merge!


version 0.2.3

@rabernat lots of new stuff in the master branch. I'd like to have it released.
is there some issues that need to be tackled before new release?
some issues need longer dev time (cs support,...) and may need to be postponed
to following release.

A good way to proceed would be to edit your comment above to include a checklist of

[ ] all
[ ] the
[ ] issues

you would like to resolve before the next release.

A new install of xmitgcm from conda-forge is broken because the current release does not work with xarray > 0.12.0 (#123).
It would be good to issue at least a bugfix release soon.

Let’s release as soon as #146 and #147 are merged.


[1.10.2] Jetpack energy isnt being taken when jetpack is used..

Hello,
So i charged my Tier 1 Conductive-Iron Jet-pack using a Mekanism Wind Generator, and when using the Jet-pack i could have infinite flying as the energy wasn't decreasing.
Forge: <IP_ADDRESS>6
SimplyJetpacks-2: <IP_ADDRESS>
Mekanism: <IP_ADDRESS>1
If you need any more information please just ask i will be happy to provide some :D

Ok, after more testing it seems to be when charged with anything and seems to be any jetpack not just the  Conductive-Iron Jet-pack, would you like a mod list?

ok i downgraded to <IP_ADDRESS> and it seems to be working there :D

Version 2.1.3 is currently under review by Curse, in about 5 or 10 minutes it should be available. It fixes the issue.
You can also download it here right now from my jenkins-dev-server: http://adf.ly/1eeGmt

Thanks great work :)


Technical Maintenance

Description
As part of the normal product maintenance, a couple of improvements/technical support items/needed upgrades are identified which are planned to take place.
Backend

.NET 8 upgrade https://github.com/eclipse-tractusx/portal-backend/issues/456
Move keycloak seeding script from portal-backend to IAM repository - https://github.com/eclipse-tractusx/portal-backend/issues/555
cleanup swagger docu of mandatory and nullable parameters per endpoint - ongoing

Frontend

deprecated react-scripts to be cleaned up/removed https://github.com/eclipse-tractusx/portal-frontend/issues/537; https://github.com/eclipse-tractusx/portal-frontend/issues/506
cleanup duplication: merge multiple implementations of API calls https://github.com/eclipse-tractusx/portal-frontend/issues/587
CSS Definitions: Remove duplicate / unused css definition - https://github.com/eclipse-tractusx/portal-frontend/issues/583
publish code guidelines & link them inside the pr checklist
update used naming convention (currently inconsistent) for

typescript
variables
overlays
etc.

clean-up locales/translation files and add missing translation
portal fe MUI integration https://github.com/eclipse-tractusx/portal-frontend/issues/582
fix shared component linter failing
remove unused code (e.g. overlays) https://github.com/eclipse-tractusx/portal-frontend/issues/578
improve client role handling across multiple clients (Security issue) - https://github.com/eclipse-tractusx/portal-frontend/issues/502

IAM

keycloak version upgrade 23 https://github.com/eclipse-tractusx/portal-iam/issues/62
publish keycloak project to nuget

Impact

Additional information

[x] I'm willing to contribute to this feature

Hello @jjeroch , @evegufy
Since the feature is a 24.05 feature and the development phase for 24.08 is coming to an end, we need a status on the feature. Can you please update the status?

[ ] Currently you are assigned (Responsible) → Is this correct? If not, please assign the correct contact person
[ ] Please check whether the status (backlog, work in progress ...) is set correctly
[ ] Please comment on the current status of the feature
[ ] Are all SubTasks (issues from other repositories that deal with the feature) linked? → The easiest way is to mention the feature here in the issue (via the ID) so we can see which teams/repositories are involved.
[ ] Is there a spillover planned?

If you need any clarification, please get in touch, thank you very much.
Stephan

milestone removed ,ticket will be reviewed and rescheduled if necessary

Closed by NSC because no progress. Please reopen and assign an upcoming release if needed.


App crashes immediately after pressing sync button

Whether I'm running as admin or not. Tried completely deleting files and appdata, downloading again, and running but it does the same thing. The weird part is it worked once, then I tried to export something and now when I try to sync again it crashes.
=====   osu!Sync Crash | 2016-04-08 16:28:57   =====

// Information
An exception occured in osu!Sync. If this problem persists please report it using the Feedback-window, on GitHub or on the osu!Forum.
When reporting please try to describe as detailed as possible what you've done and how the applicationen reacted.
GitHub: http://j.mp/1PDuDFp   |   osu!Forum: http://j.mp/1PDuCkK

// Configuration
{"application":{"isElevated":"False","lastUpdateCheck":"08-04-2016 04:26:34","version":"<IP_ADDRESS>"},"config":{"downloadMirror":"0","updateInterval":"3"},"language":{"code":{"long":"en_US","short":"en"}},"system":{"cultureInfo":"en-US","is64bit":"True","operatingSystem":"6.3.9600.0"}}

// Exception
System.Reflection.TargetInvocationException: An exception occurred during the operation, making the result invalid.  Check InnerException for exception details. ---> System.IO.IOException: Invalid string tag
   at osu_Sync.OsuReader.ReadString()
   at osu_Sync.MainWindow.BGW__Action_Sync_GetIDs_DoWork(Object sender, DoWorkEventArgs e)
   at System.ComponentModel.BackgroundWorker.OnDoWork(DoWorkEventArgs e)
   at System.ComponentModel.BackgroundWorker.WorkerThreadStart(Object argument)
   --- End of inner exception stack trace ---
   at System.ComponentModel.AsyncCompletedEventArgs.RaiseExceptionIfNecessary()
   at osu_Sync.MainWindow.BGW__Action_Sync_GetIDs_RunWorkerCompleted(Object sender, RunWorkerCompletedEventArgs e)
   at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Hello llaver,
the problem occured while syncing - i.e. reading the osu!.db file.
I tried to recreate your issue and at first failed. However, after starting osu! and restarting it because of its update I ran into the problem too. After having a look at the release notes (b20160409.3) I came to the conclusion that this issue is because of an update of the format how osu! stores its cached data.
I will try to find I solution though I don't know how long it will take.

Reason. Incompatible osu!.db due to changes
Solution. n/a
Solution (Dev). {
:: Update to new file format
:: (Re-)Enable old "Folder-Detection-Sync" as fallback }


Who to set metter over 230% or over 500 range ?

Its me again i am thankful to u 👏👏👏👏👍👍👍💯💯
I am desining sensor network
I am unable to set metter value over 100 %
I need to display 230 volt ac in metter
And 2000 c temperature
Pls help thanks in advance 👏👏👏
I am new to web design   ..,...👍👍👍✊

Data total fix the issue ??? If i put 500 metter range from ,0 to 500??

See very last example in doc.html.
data-percent:              0
data-total:                250
data-used:                 230

For max 250V and 230V indicating

thanks but i unable display over 100%  it stops at 100
i need to display 230 ++

You may share your code on jsfiddle so I can assist if needed.

thanks  one again for fast replay it working  now

thanks


how to set DayView margin

i want to change Mothview Overallheight,but i also hope DayView is Square。
we try change tileheight and tilewidth is very urgly，background is
Twinkle Twinkle。。
i am chinese。。i dont know how to change Dayview Margin

Maybe using decorators? The margin should be updated when setting tile width or height, that's the recommended solution.


orchestra/remote: raise FileNotFoundError in read_file

Raise FileNotFoundError exception if the file passed to
remote.read_file was not found.
Signed-off-by: Kyr Shatskyy<EMAIL_ADDRESS>

@susebot run deploy

https://github.com/ceph/ceph/pull/36211#issuecomment-687554201

If the #1557 merged earlier this PR can be closed.

@susebot run deploy


Send only one ERR

When e.g. sending a completely invalid command like FAIL it would make more sense as a client dev to only get one -ERR back. Otherwise we need to "try" and read out a potential second -ERR to let any subscribers know of all possible -ERR ops, which to me makes no sense to me. If we should fail fast, then one -ERR should mean: "optionally check state and/or reconnect according to what the client has been configured to do".
Sample
Send FAIL and you can get:

-ERR Uknown Protocol Operation
-ERR Parser Error

We do swiftly close the connection since the server can not recover, but I agree we only need one ERR. Thanks, will see about a fix.


Support sending inputStream directly to source()

Currently the only way to source the the database is by accessing the file system based on the classpath. However for better coverage I would like to suggest supporting sending an inputStream to the source methods instead of just a file path. This can at least help in cases where there needs to be some special handling on the file before sending it to the system. There are probably more use cases for this as well.
Requirements for this should be simple as all the source methods just wrap on a protected run method.

@Molyna any useful contributions to this open source project via Pull Requests are very welcome!

Sure, I'll get one sorted over the next few days.

@asbachb contributed this in #274 for #273.


Fix nth-child() by check previousElementSibling

This is necessary as in some cases such as:

It will miscount the nth-child.

Hey,
@aidenybai thank you very much for your contribution! Could you add a test to this PR to catch this edge case?

Should be done. Also added classname escaping + tests


paper1111: Watch gertrudex.beep.com

paper1111 requests the watch of the watch_keyword gertrudex.beep.com. See the Metasmoke search here and the Stack Exchange search here.

Coverage remained the same at 64.046% when pulling 0418d3a7e26a90941f55defe18b346afd6f5e8fd on auto-blacklist-1512201179.5703735 into 8ea5fffd1ffc3ed76ae4b370d165775cc1c4c710 on master.

!!/approve