[soundcloud] 401 Unauthorized

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.03.01. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2019.03.01

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://soundcloud.com/kuzuryuu-fuyuhiko/kikuo-ft-shikabane-no-odori']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.6.7 (CPython) - Linux-3.14.0-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 3.4.4, ffprobe 3.4.4, phantomjs 2.1.1
[debug] Proxy map: {}
[soundcloud] kuzuryuu-fuyuhiko/kikuo-ft-shikabane-no-odori: Resolving id
[soundcloud] kuzuryuu-fuyuhiko/kikuo-ft-shikabane-no-odori: Downloading info JSON
ERROR: Unable to download JSON metadata: HTTP Error 401: Unauthorized (caused by <HTTPError 401: 'Unauthorized'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/home/ealgase/.local/lib/python3.6/site-packages/youtube_dl/extractor/common.py", line 605, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/ealgase/.local/lib/python3.6/site-packages/youtube_dl/YoutubeDL.py", line 2215, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 532, in open
    response = meth(req, response)
  File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.6/urllib/request.py", line 570, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

Description of your issue, suggested solution and other information
Soundcloud download fails with 401 error (link isn't dead).

youtube-dl https://soundcloud.com/kuzuryuu-fuyuhiko/kikuo-ft-shikabane-no-odori
[soundcloud] kuzuryuu-fuyuhiko/kikuo-ft-shikabane-no-odori: Resolving id
[soundcloud] kuzuryuu-fuyuhiko/kikuo-ft-shikabane-no-odori: Downloading info JSON
[soundcloud] 114989672: Downloading track url
[soundcloud] 114989672: Downloading m3u8 information
[soundcloud] 114989672: Downloading m3u8 information
[soundcloud] 114989672: Checking http_mp3_128_url video format URL
[soundcloud] 114989672: Checking hls_mp3_128_url video format URL
[soundcloud] 114989672: Checking hls_opus_64_url video format URL
[download] Destination: Kikuo Ft. 初音ミク Shikabane No Odori-114989672.mp3
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 3468k  100 3468k    0     0   671k      0  0:00:05  0:00:05 --:--:--  815k
[curl] Downloaded 3552234 bytes
[download] 100% of 3.39MiB in 00:05

Wow, sorry about that.  youtube-dl, for some reason, didn't update properly, and I didn't check the version manually.


[WIP] skel: Replace pkg_resources.resource_filename

Part of issue https://github.com/intel/dffml/issues/783

@Nishikoh I was just about to to say that this looks tricky. I think I'd missed the part about .path not working on directories. I think you've got the API_JS_BYTES part correct, but we might be able to turn that into a one liner using importlib.resources.read_binary
As for skel, I'm sadly not optimistic on that one. There seems to be no good way to iterate over resources within a subdirectory of a package (which is what we're looking for here).

@pdxjohnny  Do you think this will make it better?

@Nishikoh The issue that you'll face with that is that

The iterable does not recurse into subdirectories.

From: https://docs.python.org/3/library/importlib.html#importlib.resources.contents which is a wrapper around the calling of that method so far as I can tell
Also: https://github.com/python/cpython/blob/038827d0f59076f52e9797018ead12b1295cddc2/Lib/importlib/resources.py#L241-L259
Where it does os.listdir...


[Issue 222] Date information added to metadata  field

Fixes #222
Description

I have so far made changes in the code to include date taken and date uploaded in the metadata field. Verified that those values are being stored together with the description in the tsv file generated when the wikimedia_commons.py file is executed.
Other information

Tests are yet to be written
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I accidentally clicked the ready for review button after creating a draft PR. Please consider this as a draft version. I just need to get what I have done so far reviewed.

I checked few source files to see whether the date taken and date uploaded mappings make sense for the given interpretations. The files I checked and the corresponding values are as follows:

111-SC-21412_-NARA-55202524(cropped).jpg Date taken - 1918, Date uploaded - 2020-02-29 01:04:04

1970_Buick_Wildcat_Custom_Coupé(01).jpg Date taken - 2017-11-22 17:26, Date uploaded - 2020-02-29 01:11:36

1970_Buick_Wildcat_Custom_Coupé(02).jpg Date taken -2017-05-25 15:47, Date uploaded - 2020-02-29 01:14:16

ATaylor_Marles_Wood_Chert_Core_(FindID_562373).jpg Date taken - between 6500 BC and 2900 BC, Date uploaded - 2020-02-29 00:05:41

A_hand_forged_iron_possible_lance_called_a_contus_of_probable_Roman_date,50-200_AD(FindID_562412).jpg Date taken - between 335 and 337, Date uploaded - 2020-02-29 00:02:13

Abraham_Bloemaert_-Apollo_and_Diana_Punishing_Niobe_by_Killing_her_Children-Google_Art_Project(Edit).jpg Date taken - 1591, Date uploaded - 2020-02-29 00:29:00

"Den_Hoed",molenaar_bij_maalbak-Kruiningen-20128156-_RCE.jpg Date taken - 1965-02, Date uploaded - 2020-02-29 01:13:33

As you mentioned before, the 'date uploaded' value seems to depict the date of most recent modification of the file within Wikimedia Commons. Therefore the mapping for date uploaded may not be appropriate.
I have doubts regarding the 'date taken' mapping as well because as you can see, for some files it returns values such as 6500 BC and 1591. The mapping appears to reflect the actual date the picture was taken only for some images, but for the rest, it could be the date of creation of the original object (such as for a painting) or the era to which an object may belong (such as for prehistoric period).
The date uploaded happens to be in a consistent format but as per the examples I have mentioned, the date taken can take arbitrary forms.

I updated an existing test to verify that date taken/date uploaded are properly stored (please see the latest commit). Should I write more tests for this or is this adequate?

Thanks for the great info on the interpretation of these pieces of data!  I think the best would be to modify the keys in the meta_data dict on our end to match with these interpretations.  I'm thinking:

last_modified_at_source (instead of date_uploaded)
date_originally_created (instead of date_taken)
Or other keys, if you prefer, as long as they're easy to interpret later.

I updated an existing test to verify that date taken/date uploaded are properly stored (please see the latest commit). Should I write more tests for this or is this adequate?

I think that suffices.

I made the changes as requested. Please let me know if further changes are required

Hey, @ChariniNana In the future, please re-request review using the GH functionality (click the circle-arrow icon near my username under reviewers).  This helps me sort PRs from general comments and mentions in my workflow.  Thank you!


Revert "docs: add 'endpointRoutes.enabled=true' to aws-cni"

This reverts commit 437e2bbd745a074b6dd140e4bd17208e3ba499f0. The original issue has been fixed, and hence this can be removed (c.f. https://github.com/cilium/cilium/pull/16227).

(Shouldn't the needs-backport/1.10 label have added the PR to the 1.10.3 project? :thinking:)

We've validated the change manually and have CI covering it now, so no need to wait for cilium/aws. Merging.


contour: fix points undo methods calls

r? @typesupply

I'll merge this into the master, but I pulled generic undo support in the ufo3 branch. Between writing the UFO 2 and UFO 3 versions, I realized that undo needs are very environment/application specific (a kerning editor doesn't need the same undo stack as a features editor). So, it needs to be handled by subclasses. After thinking about it a bit more, the base classes should have some sort of serialization by default so that everyone doesn't have to invent that on their own. I'll open an issue for that.

Sounds good, I’ll probably be moving to ufo3 before release.


the demo JavaKeywordsAsync.java have a bug

There is a bug in class JavaKeywordsAsync.java. The method multiPlainChanges() does not exist. The method must be replaced by method plainTextChanges()
public void start(Stage primaryStage) {
        executor = Executors.newSingleThreadExecutor();
        codeArea = new CodeArea();
        codeArea.setParagraphGraphicFactory(LineNumberFactory.get(codeArea));
        Subscription cleanupWhenDone = codeArea.multiPlainChanges()
                .successionEnds(Duration.ofMillis(500))
                .supplyTask(this::computeHighlightingAsync)
...

It exists. You're probably using the wrong RTFX version (there isn't a stable release that includes that method yet) or have an issue with your dependencies' cache.

Since I haven't heard back from you and the latest stable release 0.9.0 includes the API, I'm closing this issue.


Class 'Yajra\DataTables\Facades\Datatables' not found

I have problem with the class, it gives error "Class 'Yajra\DataTables\Facades\Datatables' not found"

This is my config/app.php
Provider :
Yajra\DataTables\DataTablesServiceProvider::class,
Facade:
'DataTables' => Yajra\DataTables\Facades\DataTables::class,

System details

Operating System : Ubuntu 16.04
PHP Version : 7.2.5
Laravel Version : 5.5.40
Laravel-Datatables Version : 8.6.0

Datatables was updated to DataTables, notice the the capital T. See https://yajrabox.com/docs/laravel-datatables/master/upgrade for details. Thanks!

thanks @yajra


Cannot sign in on Ubuntu 1804

Storage Explorer Version: 1.3.1
Platform/OS Version: Linux Ubuntu 18.04
Architecture: x64
Steps to Reproduce:

./StorageExplorer
Add an account, sign in
Enter password; 2FA phone auth
Multi-factor auth is successful; "waiting for authentication" exits as if it's successful
No account information appears in the side bar

Expected Experience:
Subscriptions to be loaded in the side bar after successful MFA.
PS: Tried running with sudo, deleting the config cache, ignoring cert errors, etc. Not sure what else there is to do from the TSG.

We haven't moved support up to 18.04 just yet, so we don't have any guarantees that everything should work.
That said, do you get any error messages in the F12 console window? If you launch Storage Explorer from the command line, do you get any error messages from the output?

Tell me more about your network/environment. Are you running in a Docker container? Working behind a proxy? Using alternate certificates?

None of the above. Just MSFT corpnet. Anywho, I think this is a gnome-keyring issue. Tried reinstalling it completely to no avail for now.

Hi ehotinger, I am having the exact same issue. Did you perhaps find a solution, or workaround?

Hello, I have the exact same issue on Linux Mint 19 (Ubuntu 18.04).
The login windows stays on after entering my password to "Waiting for authentication" and nothing happens.
At first, it was asking for my credentials every time but I could just continue use the app.
Then I decided to follow the troubleshooting guide and deleted the cache and identity folder and now I cannot log in anymore. (it was working on Linux Mint 18.3 (Ubuntu 16.04)).
Nothing in the debug console.

Storage Explorer Version: 1.4.2 (installed from this AUR)
Platform/OS Version: Arch Linux (current)
Architecture: x64
Same steps to reproduce, same outcome.
$ gnome-keyring version
gnome-keyring: 3.28.2

I get this error upon startup:
Debug.js:39 Unexpected end of JSON input
error @ Debug.js:39

It's still an issue with 1.4.2 release on Ubuntu 18.04 for me.

See #600 for possible workaround.

It is highly unpractical when dealing with more than a couple storage accounts :(

@rnsc, not really sure what you're referring to. If you look a little further in the conversation, @oh54 suggests running the following on the command line:
sudo apt install libgnome-keyring-common libgnome-keyring-dev

https://superuser.com/questions/1233459/error-running-gitkraken-even-though-dependencies-installed/1255172
Again, please keep in mind that we do not officially support Linux 18.* as of yet.

Hey @craxal, those packages are installed on my system and still, it doesn't work.
I'm willing to help if you need more info.

I observe the same issue with the latest release of Azure Storage Explorer (1.6.1) on the following platforms:

ArchLabs (Arch Linux with Openbox WM) - with latest Dotnet Core (2.2.101) from AUR;
Debian 9 - clean install with only Dotnet Core 2.2.101, Azure CLI and ASE;
Mint 18.3 xfce (based on Ubuntu 16.04) - clean install with only Dotnet Core 2.2.101, Azure CLI and ASE;
ASE works fine for me on Windows 7 and on Windows 10.

Could you please make sure you have the following dependencies installed?  Quoted from the Troubleshooting guide:
For Linux distros other than Ubuntu 16.04, you may need to manually install some dependencies. In general, the following packages are required:
.NET Core 2.x
libsecret
libgconf-2-4
Up-to-date GCC
Depending on your distro, there may be other packages you need to install. The Storage Explorer Release Notes contain specific steps for some distros.

Hello @jinglouMSFT
Here are the deps I have installed on U 18.04:
Package: aspnetcore-runtime-2.1 Status: install ok installed Priority: standard Section: devel Installed-Size: 70803 Maintainer: Microsoft<EMAIL_ADDRESS>Architecture: amd64 Version: 2.1.6-1
Package: libgconf2-4 Status: install ok installed Priority: optional Section: oldlibs Installed-Size: 364 Maintainer: Ubuntu Desktop Team<EMAIL_ADDRESS>Architecture: amd64 Multi-Arch: same Source: gconf Version: 3.2.6-4ubuntu1
Package: libsecret-1-0 Status: install ok installed Priority: optional Section: libs Installed-Size: 347 Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Architecture: amd64 Multi-Arch: same Source: libsecret Version: 0.18.6-1
Package: gcc Status: install ok installed Priority: optional Section: devel Installed-Size: 50 Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Architecture: amd64 Source: gcc-defaults (1.176ubuntu2.1) Version: 4:7.3.0-3ubuntu2.1
And still, it doesn't work.

Am running in to same issue: asks me to sign in, then "Waiting for Authentication", then that screen disappears and no account details appear in the explorer. Here is a screenshot of the console error:

@shikharsg Could you please try the workaround outlined in #1142?  Thanks.

@jinglouMSFT, thank you for that link, it works now

Been a while since this issue had any comments.
With regards to Ubuntu 18 support here's where we stand:

we now have a storage explorer snap, it is the recommended way of installing storage explorer on linux, please use it!
we still have the .tar.gz, but you need to install the dependencies manually

If anyone is still having ubuntu 18 problems, please open a new issue. Thanks!


Consider ot-ctl history for easily repeating previous commands

This provides equivalency to various other CLI tools like terminal or chip-tool interactive mode.
Pressing up/down should pre-populate previous commands in the history. Right now, its interpretted as a separate keystroke:
> ^[[A^[[B

Closing stale issue.


[BUG] Conflicts With Immersive Portals and Optifine

Version: 1.17.1 - 0.10.4
How to reproduce: Build an end portal or enter a world where player is in the end.
Immersive Portals: https://github.com/qouteall/ImmersivePortalsMod/issues
Log: latest.log

Looks like issue happens somewhere in portals rendering, I'm not sure

I changes sky rendering code, it will probably will work

This should also fix issues with optifine (probably), this requires testing

This probably should work in latest release, if not - please reopen this issue


MenuPool ProcessKey() Weirdness

Hello, I'm trying to setup the menu to use the numpad controls.
I had done this for each menucontrol like this:
Pool.SetKey(UIMenu.MenuControls.Up, Keys.NumPad8);
But that doesn't press the keys to control the menu, so on the keyDown, I put in:
Pool.ProcessKey(Keys.NumPad8);
Pool.ProcessKey(Keys.NumPad2);
Pool.ProcessKey(Keys.NumPad5);
Pool.ProcessKey(Keys.NumPad0);
Pool.ProcessKey(Keys.NumPad4);
Pool.ProcessKey(Keys.NumPad6);

But this makes the main menu not move, and the submenus it will skip by 6 every time. The UIListItems' will sometimes skip by 6 or 1, and checkboxes will press twice making them pointless.
This does not affect the default arrow key controls, and they work the same.
And as a side issue, it does not act like the arrow key controls with the sensitivity, it is very sensitive.

use         public void SetKey(MenuControls control, Control gtaControl)

SetKey is the right way to do... but Pool is the Menu you're building or the MenuPool? if it's the MenuPool.. try using SetKey directly in the Menu declaration.
Eg:
 UIMenu example = new UIMenu("Example", "Wow this is a description");
 example.SetKey(UIMenu.MenuControls.Up, Keys.NumPad8);

Do you have some code that can be used to repro this? I feel that this might be related to the other menu elements.


Fixed Room makes PropagationCost = 1

Hi!
I think I ran into a bug: if Fixed Room is checked in the script Audio Object, the PropagationCost will be 1, even if the listener is standing directly outside of an open portal. When I turn Fixed Room off, it seems to be calculating PropagationCost as expected again.
I noticed a related issue in the ambience system, where PropagationCost = 1 for any ambience coming out of a portal -- only if it is assigned a Spatial Audio Room in the Ambience Area script. Possibly it's the same thing.
Let me know if I'm misunderstanding something about this or set it up incorrectly - thank you! :)
Ian

I took a quick look at this, and it indeed was the case that on update the instances with fixed rooms weren't added to the list of instances with known rooms. Let me know if the simple fix I pushed fixes whole issue for you.

Ville


Pass Open Folder Result

I would like to be able to get the folder uid_validity using the idle
command and this seems to be the only way I've seen.

Hi @eknowlton ,
many thanks for your pull request and sorry for the long waiting time.
I was hesitant to merge your changes. The folder initially parsed doesn't has to be the one associated to the folder you've called idle() from.
If you need to access the folder, you can always call Message::getFolder() and be sure you are accessing a valid instance.
Best regards,


Pokestops and gyms showing but not Pokemons?

I've been trying to use the map for the last week but pokemon dont show up except pokestops and gyms. I used a PTC account that already accepted the Terms and Conditions and I also caught my first pokemon. I have no idea whats wrong with the map. It would sometimes say "Upserted 1-2 pokemon" but nothing shows up.
https://gyazo.com/227f28962831dca3e877bb7806946630

Had that issue previously, now the map is completely empty for me -_-

I have the same issue and sometimes I don't have pokestops and gyms too.
2016-08-08 13:27:24,489 [ search_worker_0][ auth_ptc][ INFO] PTC User Login successful.
2016-08-08 13:27:24,499 [ search_worker_0][ auth_ptc][ INFO] Request PTC Access Token...
2016-08-08 13:27:24,650 [ search_worker_0][ auth_ptc][ INFO] PTC Access Token successfully retrieved.
2016-08-08 13:27:25,563 [ search_worker_0][ models][ INFO] Upserted 0 pokemon, 0 pokestops, and 0 gyms
2016-08-08 13:27:35,587 [ search_worker_0][ search][ INFO] Search step 2 beginning (queue size is 125)
2016-08-08 13:27:35,792 [ search_worker_0][ models][ INFO] Upserted 0 pokemon, 0 pokestops, and 0 gyms
2016-08-08 13:27:45,811 [ search_worker_0][ search][ INFO] Search step 3 beginning (queue size is 124)
2016-08-08 13:27:46,271 [ search_worker_0][ models][ INFO] Upserted 0 pokemon, 0 pokestops, and 0 gyms
2016-08-08 13:27:56,289 [ search_worker_0][ search][ INFO] Search step 4 beginning (queue size is 123)
2016-08-08 13:27:56,501 [ search_worker_0][ models][ INFO] Upserted 0 pokemon, 0 pokestops, and 0 gyms
2016-08-08 13:28:06,518 [ search_worker_0][ search][ INFO] Search step 5 beginning (queue size is 122)
2016-08-08 13:28:06,721 [ search_worker_0][ models][ INFO] Upserted 0 pokemon, 0 pokestops, and 0 gyms


[Storage] Fix #16979: az storage container create fails when providing storage container metadata

Description

Fix #16979
az storage container create has command validator validate_client_auth_parameter which will suppress all argument validators including validate_metadata. As a result, metadata can't be parsed properly.
Testing Guide

az storage container create -n testcontainer --metadata k1=v1 k2=v2

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Storage

Could you add --metadata check?

There's no specialized test for storage container create. So I added --metadata in a test which used storage container create.


[move-prover] framework-friends

This is a duplication of #8668 trying to resolve the CI issues.

Closing as the problem has been solved


Add @DisplayName that defines which property to use in the UI when showing a bean, enum or similar

Describe your motivation
If you want to show a bean in the UI, like a Person, City, Company, Country, Book, ... you want to show some textual representation of the bean like the person's full name, the book title etc. It is impossible to know which property to pick from a bean automatically
Describe the solution you'd like
The user should be able to indicate which property to use, e.g.
public class Book {

@DisplayName
private String title;

...
}

There can be only one @DisplayName on either a field or a getter in a class. Multiple ones cause an exception. Combining two properties requires adding a new getter for that.
Similarly it should be possible to define the display name for enum constants, e.g.
    public enum Matcher {
        EQUALS("="), CONTAINS("Contains"), LESS_THAN("<"), GREATER_THAN(">");

        private String humanReadable;

        private Matcher(String humanReadable) {
            this.humanReadable = humanReadable;
        }

        @DisplayName
        public String getHumanReadable() {
            return humanReadable;
        }
    }

In TypeScript, there should be a way for getting the display name property for a given bean model, e.g. through the meta data
Describe alternatives you've considered
No response
Additional context
No response

Specifying how things should be displayed in the frontend (rather than in the backend) also has the advantage of allowing the same bean to be represented differently in different UIs.


The vehicle doesn't change.

i want to increase density of vehicles in highway-v0 just like #81 .But no matter how I adjust the "initial_spacing",  the density of vehicles does not seem to have any changed, just the initial position of the green vehicle has changed.
How can I increase the density of the blue vehicle when the green vehicle is running?
By setting a low value for the "initial_spacing"?
thanks for your reply.

Hi @dx2919717227,
Indeed, my answer to #81 was wrong: initial_spacing is only applied to the controlled vehicle(s), and not every vehicle. It was meant to ensure that the ego-vehicle would not start in a near-crash situation, while still having a dense traffic for other vehicles.
I'll add a separate configuration for other vehicles.

You can now use the vehicles_density config

thank you very much.:smile:


[Question] Integrate with VSC

Is there anyway to integrate with Visual Studio Code for suggestions? Regarding smart contract available APIs. Is there an npm package that contains the definitions for available APIs?

as of now there is no such package available, you can refer to the wiki: https://github.com/harpagon210/steemsmartcontracts/wiki/Smart-Contracts-API


PyPI project iris: Does anyone here have access to the account that owns it? (Urgent)

Hi! I'm sorry for intruding with a message that's only tangentially related to this project, but I'm one of the moderators for pypi.org, the Python Package Index. In https://github.com/pypa/pypi-support/issues/180 someone has requested a transfer of https://pypi.org/project/iris/ to a different owner. PEP 541 requires attempting to get in touch with the current project owner before that can happen.
The email address listed for iris bounces. The owner of the project also owns https://pypi.org/project/illumon-jpy/, which lists this repository as its homepage. I'm opening this issue in the hopes that someone here can help us get in touch with the owner and facilitate resolving the issue. If you are the owner or can contact them, the PyPI admins would appreciate it if you could respond to https://github.com/pypa/pypi-support/issues/180. (In https://github.com/bcdev/jpy/issues/11 it looks like @forman may have been involved.)
Thank you!

Hi @jamadden,
Thanks again for reaching out. I've replied to https://github.com/pypa/pypi-support/issues/180 - https://github.com/bcdev/jpy is not the owner of https://pypi.org/project/iris/, so I think this ticket can be closed.
Thanks,
-Devin

Good that this could be clarified.


False positive for guard clause?

I have a case where I believe RuboCop is reporting a false positive:
$ cat foo.rb
def foo
  if a
    b = 1
    c = 2
    d = 3
    p b, c, d
  end
end

When running RuboCop on the above file, I get the following offense reported:
$ rubocop foo.rb
Inspecting 1 file
C

Offenses:

foo.rb:2:3: C: Use a guard clause instead of wrapping the code inside a conditional expression.
  if a
  ^^

1 file inspected, 1 offense detected

There are multiple statements inside the above if statement, I don't see how that can be replaced with a guard clause.
I'm running the following version of RuboCop:
$ rubocop -V
0.43.0 (using Parser <IP_ADDRESS>, running on ruby 2.1.5 x86_64-darwin15.0)

Here's another example that passes with 0.42.0 but fails with 0.43.0:
def write_assets_manifest
  if Dir.glob(assets_glob).empty?
    FileUtils.mkdir_p(assets_directory)
    FileUtils.touch(assets_manifest_path)
    @assets_manifest_path = assets_manifest_path
  end
end

These look fine to me, it wants you to do this:
def foo
  return unless a

  b = 1
  c = 2
  d = 3
  p b, c, d
end

And this:
def write_assets_manifest
  return unless Dir.glob(assets_glob).empty?

  FileUtils.mkdir_p(assets_directory)
  FileUtils.touch(assets_manifest_path)
  @assets_manifest_path = assets_manifest_path
end

Hmm, ok, I see. Looks like it got a bit smarter between 0.42.0 and 0.43.0.


I can't trigger to open left or right side by button action.

I followed instructions for storyboard and I set controllers correctly.
class Example: UIViewController, DrawerControllerDelegate {
override func viewDidLoad()  {
        super.viewDidLoad()
        self.drawerController?.delegate = self
        self.drawerController?.options.isAnimation = false
        self.drawerController?.setTransition(DrawerFloatTransition(), for: .left)
}

When I try to trigger open left side with this code block, drawerController throws nil error and crash.
if self.drawerController!.drawerSide == .none {
            self.drawerController?.openSide(.left)
                .subscribe()
                .disposed(by: disposeBag)
        } else {
            self.drawerController?.closeSide()
                .subscribe()
                .disposed(by: disposeBag)
        }

What version are you using?

@kawoou
XCode Version: Version 9.3.1
Swift Version:  4.1
Pods:

RxCocoa (4.1.2):

RxSwift (~> 4.0)

RxSwift (4.1.2)
KWDrawerController (4.1.6):

KWDrawerController/Core (= 4.1.6)

KWDrawerController/Core (4.1.6)

What class is calling the code that calls openSide method?

I followed instructions for storyboard and I set controllers correctly.
class Example: UIViewController, DrawerControllerDelegate {
override func viewDidLoad()  {
        super.viewDidLoad()
        self.drawerController?.delegate = self
        self.drawerController?.options.isAnimation = false
        self.drawerController?.setTransition(DrawerFloatTransition(), for: .left)
}

When I try to trigger open left side with this code block, drawerController throws nil error and crash.
if self.drawerController!.drawerSide == .none {
            self.drawerController?.openSide(.left)
                .subscribe()
                .disposed(by: disposeBag)
        } else {
            self.drawerController?.closeSide()
                .subscribe()
                .disposed(by: disposeBag)
        }

I have the same problem, could you solve it?

I have the same problem, I follow the readme manual but I have the same crash, the self.drawerController is nil, any suggest?
best regards

Also having issues with self.drawerController?.openDrawer(.left) and self.drawerController?.closeDrawer(). In my case, both the left and centre have UINavigationContoller's embedded in them, each with a single UIViewController embedded as the rootViewController. Each has a left bar button item in the Navigation Bar that calls a private function that just calls the open or close. In both cases, the private function is getting called, but the DrawerController isn't responding. I've logged out the self.drawerController, it's not nil. I've also setup my view controller as the DrawerControllerDelegate, none of the delegate methods are getting called. My DrawerController was setup in storyboard, just in case that's relevant.

Just call self.drawerController?.openSide(.left, completion: nil), The completion: nil do the trick.


Revert "Revert "Update README.md""

Reverts paritytech/companion-for-processbot-staging#29
companion: https://github.com/paritytech/companion-for-processbot-staging/pull/28

bot merge


JWT verify return an invalid algorithm for JWT Token signed with RS256

Bug report
Describe the bug
I've got a problem when I try to upload a file with storage-api.
The JWT token in my platform signed with RS256 algorithm. Here is an error
{"level":"info","time":"2022-08-10T05:02:30.129Z","pid":23,"hostname":"storage-0","reqId":"req-5","req":{"method":"POST","url":"/bucket","hostname":"storage:5000","remoteAddress":"<IP_ADDRESS>","remotePort":56482},"msg":"incoming request"}
JsonWebTokenError: invalid algorithm
    at /app/node_modules/jsonwebtoken/verify.js:121:19
    at getSecret (/app/node_modules/jsonwebtoken/verify.js:90:14)
    at Object.module.exports [as verify] (/app/node_modules/jsonwebtoken/verify.js:94:10)
    at /app/src/utils/index.ts:37:9
    at new Promise (<anonymous>)
    at verifyJWT (/app/src/utils/index.ts:36:10)
    at /app/src/utils/index.ts:59:28
    at step (/app/dist/utils/index.js:33:23)
    at Object.next (/app/dist/utils/index.js:14:53)
    at /app/dist/utils/index.js:8:71

To Reproduce

Generate secret/keys of supabase with RS256 algorithm.
Make a request to storage-api of subapase deployment.

Expected behavior
The storage should be successful with file uploaded.
I've created PR to resolve this issue. Please review here https://github.com/supabase/storage-api/pull/176

@fenos I've updated my PR by remove PGRST_JWT_SECRET_IS_BASE64.
Please check.
Thank you.


borgbackup: 1.1.16 -> 1.1.17

Motivation for this change
https://github.com/borgbackup/borg/blob/1.1.17/docs/changes.rst#version-1117-2021-07-12
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 130051 run on x86_64-darwin 1

1 package marked as broken and skipped:

borgbackup

I couldn't figure out why nixpkgs-review said that borgbackup was broken for darwin.
On another note, it doesn't need to be part of this PR, but how about using installShellCompletion instead of the explicit manipulation.
 Not a big deal, but would have been better if they were separated.

I couldn't figure out why nixpkgs-review said that borgbackup was broken for darwin.

Can you build it with nix-build and provide a normal log?

On another note, it doesn't need to be part of this PR, but how about using installShellCompletion instead of the explicit manipulation.

I'd rather leave that for someone else. I changed what I'm comfortable with.

 Not a big deal, but would have been better if they were separated.

Can still separate them if you see a reasonable value in it.

The discussion was still going, not exactly sure why you would just merge when there is an indication about breakage on any platform, when the changes are so extensive.

What breakage? There was no breakage mentioned.
darwin is not being build by ofborg because some dependency does not support it.
The other two points are nits.

I was waiting for feedback from @happysalada what the issue with darwin on his end was.

I'm guessing it was a dependency issue. I'm a little bit concerned since at present I definetly have and use borgbackup on darwin. When this is release, I'll have a look at why this breaks. I'll mention in the PR when I have a look (if you don't mind of course)
Don't worry about the formatting thing. It really is a tiny thing, just if you have time next time.
Thank you for doing the PR!

Here is the stacktrace
error: Package ‘fuse-3.10.4’ in /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/os-specific/linux/fuse/common.nix:86 is not supported on ‘x86_64-darwin’, refusing to evaluate.

       a) To temporarily allow packages that are unsupported for this system, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowUnsupportedSystem = true; }
       in configuration.nix to override this.

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowUnsupportedSystem = true; }
       to ~/.config/nixpkgs/config.nix.

       … while evaluating 'handleEvalIssue'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/stdenv/generic/check-meta.nix:188:38:

          187|
          188|   handleEvalIssue = { meta, attrs }: { reason , errormsg ? "" }:
             |                                      ^
          189|     let

       … from call site

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/stdenv/generic/check-meta.nix:302:14:

          301|       handled = if !validity.valid
          302|         then handleEvalIssue { inherit meta attrs; } { inherit (validity) reason errormsg; }
             |              ^
          303|         else true;

       … while evaluating the attribute 'handled'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/stdenv/generic/check-meta.nix:301:7:

          300|       # Throw an error if trying to evaluate an non-valid derivation
          301|       handled = if !validity.valid
             |       ^
          302|         then handleEvalIssue { inherit meta attrs; } { inherit (validity) reason errormsg; }

       … while evaluating the attribute 'buildInputs' of the derivation 'python3.8-pyfuse3-3.2.0'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/stdenv/generic/make-derivation.nix:203:11:

          202|         // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          203|           name =
             |           ^
          204|             let

       … while evaluating the attribute 'out.outPath'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/customisation.nix:156:13:

          155|             drvPath = assert condition; drv.${outputName}.drvPath;
          156|             outPath = assert condition; drv.${outputName}.outPath;
             |             ^
          157|           };

       … while evaluating the attribute 'propagatedBuildInputs' of the derivation 'borgbackup-1.1.17'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/stdenv/generic/make-derivation.nix:203:11:

          202|         // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          203|           name =
             |           ^
          204|             let

       … while evaluating the attribute 'out.outPath'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/customisation.nix:156:13:

          155|             drvPath = assert condition; drv.${outputName}.drvPath;
          156|             outPath = assert condition; drv.${outputName}.outPath;
             |             ^
          157|           };

       … while evaluating the attribute 'passAsFile'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/build-support/buildenv/default.nix:77:5:

           76|     # XXX: The size is somewhat arbitrary
           77|     passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
             |     ^
           78|   }

       … while evaluating the attribute 'passAsFile' of the derivation 'system-applications'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/stdenv/generic/make-derivation.nix:203:11:

          202|         // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          203|           name =
             |           ^
          204|             let

       … while evaluating the attribute 'value'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:392:44:

          391|       defnsByName' = byName "config" (module: value:
          392|           [{ inherit (module) file; inherit value; }]
             |                                            ^
          393|         ) configs;

       … while evaluating 'dischargeProperties'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:609:25:

          608|   */
          609|   dischargeProperties = def:
             |                         ^
          610|     if def._type or "" == "merge" then

       … from call site

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:538:137:

          537|         defs' = concatMap (m:
          538|           map (value: { inherit (m) file; inherit value; }) (builtins.addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))
             |                                                                                ^
          539|         ) defs;

       … while evaluating definitions from `/nix/store/nb2kapr1yf12ra2x3jmdbm2lwfh9c1pr-source/modules/system/applications.nix':

       … while evaluating anonymous lambda

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:537:28:

          536|         # Process mkMerge and mkIf properties.
          537|         defs' = concatMap (m:
             |                            ^
          538|           map (value: { inherit (m) file; inherit value; }) (builtins.addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))

       … from call site

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:537:17:

          536|         # Process mkMerge and mkIf properties.
          537|         defs' = concatMap (m:
             |                 ^
          538|           map (value: { inherit (m) file; inherit value; }) (builtins.addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))

       … while evaluating the attribute 'values'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:650:7:

          649|     in {
          650|       values = concatMap (def: if getPrio def == highestPrio then [(strip def)] else []) defs;
             |       ^
          651|       inherit highestPrio;

       … while evaluating the attribute 'values'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:551:9:

          550|       in {
          551|         values = defs''';
             |         ^
          552|         inherit (defs'') highestPrio;

       … while evaluating the attribute 'mergedValue'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:557:5:

          556|     # Type-check the remaining definitions, and merge them. Or throw if no definitions.
          557|     mergedValue =
             |     ^
          558|       if isDefined then

       … while evaluating the option `system.activationScripts.applications.text':

       … while evaluating the attribute 'value'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:525:9:

          524|     in warnDeprecation opt //
          525|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          526|         inherit (res.defsFinal') highestPrio;

       … while evaluating anonymous lambda

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:140:72:

          139|           # For definitions that have an associated option
          140|           declaredConfig = mapAttrsRecursiveCond (v: ! isOption v) (_: v: v.value) options;
             |                                                                        ^
          141|

       … from call site

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/attrsets.nix:301:20:

          300|               then recurse (path ++ [name]) value
          301|               else f (path ++ [name]) value;
             |                    ^
          302|         in mapAttrs g set;

       … while evaluating 'g'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/attrsets.nix:298:19:

          297|           g =
          298|             name: value:
             |                   ^
          299|             if isAttrs value && cond value

       … from call site

       … while evaluating the attribute 'activationScripts.applications.text'

       … while evaluating the attribute 'value'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:392:44:

          391|       defnsByName' = byName "config" (module: value:
          392|           [{ inherit (module) file; inherit value; }]
             |                                            ^
          393|         ) configs;

       … while evaluating 'dischargeProperties'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:609:25:

          608|   */
          609|   dischargeProperties = def:
             |                         ^
          610|     if def._type or "" == "merge" then

       … from call site

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:538:137:

          537|         defs' = concatMap (m:
          538|           map (value: { inherit (m) file; inherit value; }) (builtins.addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))
             |                                                                                ^
          539|         ) defs;

       … while evaluating definitions from `/nix/store/nb2kapr1yf12ra2x3jmdbm2lwfh9c1pr-source/modules/system/activation-scripts.nix':

       … while evaluating anonymous lambda

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:537:28:

          536|         # Process mkMerge and mkIf properties.
          537|         defs' = concatMap (m:
             |                            ^
          538|           map (value: { inherit (m) file; inherit value; }) (builtins.addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))

       … from call site

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:537:17:

          536|         # Process mkMerge and mkIf properties.
          537|         defs' = concatMap (m:
             |                 ^
          538|           map (value: { inherit (m) file; inherit value; }) (builtins.addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))

       … while evaluating the attribute 'values'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:650:7:

          649|     in {
          650|       values = concatMap (def: if getPrio def == highestPrio then [(strip def)] else []) defs;
             |       ^
          651|       inherit highestPrio;

       … while evaluating the attribute 'values'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:551:9:

          550|       in {
          551|         values = defs''';
             |         ^
          552|         inherit (defs'') highestPrio;

       … while evaluating the attribute 'mergedValue'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:557:5:

          556|     # Type-check the remaining definitions, and merge them. Or throw if no definitions.
          557|     mergedValue =
             |     ^
          558|       if isDefined then

       … while evaluating the option `system.activationScripts.script.text':

       … while evaluating the attribute 'value'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:525:9:

          524|     in warnDeprecation opt //
          525|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          526|         inherit (res.defsFinal') highestPrio;

       … while evaluating anonymous lambda

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/modules.nix:140:72:

          139|           # For definitions that have an associated option
          140|           declaredConfig = mapAttrsRecursiveCond (v: ! isOption v) (_: v: v.value) options;
             |                                                                        ^
          141|

       … from call site

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/attrsets.nix:301:20:

          300|               then recurse (path ++ [name]) value
          301|               else f (path ++ [name]) value;
             |                    ^
          302|         in mapAttrs g set;

       … while evaluating 'g'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/lib/attrsets.nix:298:19:

          297|           g =
          298|             name: value:
             |                   ^
          299|             if isAttrs value && cond value

       … from call site

       … while evaluating the attribute 'activationScripts.script.text'

       … while evaluating the attribute 'activationScript' of the derivation 'darwin-system-21.11.20210713.dac74fe+darwin4.007d700'

       at /nix/store/xni1qpy1nsrpmjfhjz71j1gg4chspasg-source/pkgs/stdenv/generic/make-derivation.nix:203:11:

          202|         // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          203|           name =
             |           ^
          204|             let

It seems to be the llfuse dependency.
I am checking what has changed. It doesn't seem to be a borg PR.

Actually pyfuse3 is introduced in this pr. We can make it conditional I guess.

The build is starting. I'll update when it finishes.

I already made the change in #130171 and ofBorg said it was fine.

Cool, thank you!
I'm confirming by running nixpkgs-review, I'm sure it will run fine.


Invite screen part 4

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
#738
✅ Checklist

[x] Github issue details are up to date for people to QA.
[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Added:

Invite link dialog
Transaction fail snackbar

🙈 Screenshots

1
2
3
Fail

👯♀ Paired with
"nobody"

Usually snackbar have an X to closed it?

I think these are design cosiderations that Jason should be asked, the defualt snackbar is only text and hides after a few seconds.

Usually snackbar have an X to closed it?

I think these are design cosiderations that Jason should be asked, the defualt snackbar is only text and hides after a few seconds.

true we should ask Json. But I voted for the X (: . users should have the option to closed it if they want to.

Ui needs some fixing.

missing $ symbol.
overflow.

Tell me if the overflow was corrected, I can't reproduce it on my device.


[SPARK-12318][SPARKR] Save mode in SparkR should be error by default

@shivaram  Please help review.

Test build #47649 has started for PR 10290 at commit 4f2e56b.

Test build #47649 has finished for PR 10290 at commit 4f2e56b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47649/
Test PASSed.

Document this change into migration guide?

Make sense, will do.

Test build #47713 has started for PR 10290 at commit 3e71b06.

Test build #47713 has finished for PR 10290 at commit 3e71b06.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47713/
Test PASSed.

I don't think we have a migration guide section in SparkR programming guide but we should, like sql:
http://spark.apache.org/docs/latest/sql-programming-guide.html#migration-guide

@felixcheung yes, there's no migration doc for R. So I just put the doc in the data frame example. I can create migration section if necessary.

Yeah lets create a migration section -- This also came up in another PR and I think is useful to have.

Test build #47719 has started for PR 10290 at commit d72a3af.

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <Re: [spark] [SPARK-12318][SPARKR] Save mode in SparkR should be error by default (#10290)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Test build #47719 has finished for PR 10290 at commit d72a3af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47719/
Test PASSed.

One minor thing is that I'm not sure its very good to hard code these version numbers here. For example we could have a RC3 and then this might be in Spark 1.6
cc @JoshRosen Are there known good practices on how to handle documentation changes of this form ?

Cc @marmbrus it'll be good to have this PR in rc3. There are some unaddressed docs comments but I can fix them up while merging ?

Sorry, RC3 has already been cut.

Test build #47768 has started for PR 10290 at commit 8eb181c.

Test build #47768 has finished for PR 10290 at commit 8eb181c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47768/
Test PASSed.

LGTM. Merging into master (and not branch-1.6 as we probably don't want to change the API in a minor release like 1.6.1).

@shivaram actually, i'm going to have to cut RC3 again.  You get a second chance if you merge now!

Oh sure cherry picking now

Done ! Thanks @marmbrus for the heads up


add the controlCrosshairImg option to GeotagPhoto

poking @bertspaan

@Abbe98 Thanks for this PR! This raises an older problem: I'm no longer at the NYPL, and no one there I think will merge this PR. We should move this repo to a new location! I have a fork that we can use (https://github.com/bertspaan/Leaflet.GeotagPhoto), or we can find a different location. Do you have suggestions?

I think that's a okey location, but it would be nice if it wasn't a fork as forks aren't searchable etc.

I can reach out to someone at NYPL and see if they can move the repo to my account

@bertspaan that would be great, otherwise a git clone with a new remote would work to.


Resolve #182

Disable drop zone if control is disabled.

/cc @AlekseyMartynov

:shipit:

resolve #182


In the visual studio code, a malfunction occurs when i input korean

I use visual studio code release 1.30.0
After update, The upper line is copied when i type korean and press any other keys

@chulpyo What OS are you using?


ERROR: IllegalStateException

Use case:
ERROR: IllegalStateException
Feature description:
执行语句
ALTER TABLE s_56.d_695_codes SET (number_of_shards = 1);
错误信息：
ERROR: IllegalStateException: index s_56.d_695_codes must have all shards allocated on the same node to shrink index
怎么样看了这个
https://crate.io/docs/crate/reference/en/4.6/sql/statements/alter-table.html#sql-alter-table-reroute
不知道怎么使用啊！

Hi @zhangyatao123456,
thanks for writing in. @jayeff responded to your request at https://github.com/crate/crate/issues/11576#issuecomment-893247576 already. Hope this helps!
With kind regards,
Andreas.

如何移动 SHARD 啊，能提供一个示例吗？


Add enhancements/ directory

I added an enhancement template and a first SEP that discusses the process

@dgn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_sail-operator_main
367594c4881fe21cd710034cf5683045ea932116
link
true
/test gencheck

lint_sail-operator_main
367594c4881fe21cd710034cf5683045ea932116
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

I think we need to add also a reference in the read me file to link to this enhancements directory

LGTM, should we update the status to Done?

Yes, we can update this at the same time that we add the reference for this documentation in the read me file.


KEP-2170: Implement skeleton webhook servers

What this PR does / why we need it:
I implemented the skeleton webhook servers for v2 operator.
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #2209
Checklist:

[ ] Docs included if any changes are user facing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

21 of 21 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
66

Relevant Lines:
66

💛  - Coveralls

/assign @kubeflow/wg-training-leads

@andreyvelich I addressed the comments. The only remaining point is https://github.com/kubeflow/training-operator/pull/2251#discussion_r1750580887.

Thank you for this @tenzen-y! /lgtm /approve

Thank you!


Photos not visible in Photos section of profile.

Photos not visible in Photos section of profile.
Kindly assign me this issue under #SWOC24 @Mayuresh-22

Yes, @raghav1482 I am assigning this issue to you. You can start working on it.

@raghav1482 are you still working on the issue?

yes i am .

I have completed it ... minor changes left


UTM Kali linux arm64: terminal doesn't open

Describe the issue
I can't open terminal, only can use the serial device, gnome-terminal process appear and disappear after few seconds.
Configuration

UTM Version: 4.4.5
macOS Version: Sonoma 14
Mac Chip (Intel, M1, ...):  M1

EDIT: terminal work only with fxce to me.

I think this is related to #5749. Try disabling wayland and using x11


Remove Config function in favor of Validate and ApplyTo

This PR removes Config function in the options package in favor of Validate and ApplyTo functions, as proposed by this comment.

yeah, that's what I want
/lgtm
for some reason it wants the pull updated on master.  weird.


how to make inference on ted dataset

hello， thanks for excellent work!
I wander how to make inference on Ted dataset, when I try default setting like Vox using Ted pretrained model, the generated video is terrible, may you show some examples on it?
Thanks!

+1

Make these changes in your demo.ipynb code:
import torch
import os
os.environ['CUDA_VISIBLE_DEVICES']='3'
# edit the config
device = torch.device('cuda:0')
dataset_name = 'ted' # ['vox', 'taichi', 'ted', 'mgif']
source_image_path = '####'
driving_video_path = '#####'
output_video_path = './generated.mp4'
config_path = 'config/ted-384.yaml'
checkpoint_path = 'checkpoints/ted.pth.tar'
predict_mode = 'relative' # ['standard', 'relative', 'avd']
find_best_frame = False # when use the relative mode to animate a face, use 'find_best_frame=True' can get better quality result

pixel = 256 # for vox, taichi and mgif, the resolution is 256*256
if(dataset_name == 'ted'): # for ted, the resolution is 384*384
    pixel = 384

Any updates to this? Even with config suggested above, results are very bad.


Display a Table of Contents on large displays

The ToC is displayed through javascript on the left side when the display is large enough:
--

The ToC position is fixed so that it doesn't scroll with the rest of the page and remains always at the same place:
--

On smaller displays, the ToC is hidden via display: none.
Alternative
Put it on the right side and use absolute instead of fixed positioning:
--

Unresolved Questions

Too much visual clutter?
Design improvements?
Should we also display it on smaller displays?
Fade the ToC out until the mouse hovers it again?

Please make it fixed.


how to play video on client

how to play video on client web page. please help me

That is not something you can do with this library, it only allows capturing of the events produced by the camera.


[feature request] Rate-Limiting

Feature request
Could you please add rate-limiting? Some tasks have to be executed "slowly" to not overstress system capabilies or to comply with external specifications, e.g. a rate limit on an API.
One example would be mass mailing via Amazon SES. Only 14 mails per second are permitted here.

Thanks for this feature request—it's a very relevant addition.
Here's a preliminary idea of how this could implemented;
I could integrate rate limiting directly into the entrypoint decorator, allowing each task to specify its own rate limits. This approach leverages Python's flexibility and makes it straightforward for developers to manage task-specific rates.
Example:
@qm.entrypoint("send_email", rate_limit=RateLimit(per_second=14))
async def send_email(job: Job) -> None:
    # Send email logic here

This syntax would define a rate limit of 14 emails per second for the send_email task. The actual rate limiting logic would be handled within the job dispatch system, ensuring compliance with the specified rates.
I'm still exploring the best ways to implement this, considering the challenges with the NOTIFY approach. Your input on this would be really valuable as we refine the concept!

Is there maybe a rough timeline for when this might be implemented? Rate limiting is the last feature I need for my project to migrate to PgQueuer, really looking forward to giving it a go.

Is there maybe a rough timeline for when this might be implemented? Rate limiting is the last feature I need for my project to migrate to PgQueuer, really looking forward to giving it a go.

Currently, there is no set timeline for implementing global rate limiting, as it requires further research to ensure stability and accuracy. Implementing global rate limiting has proven more challenging than anticipated. I'm currently exploring more robust solutions and any suggestions or insights are highly welcome.

@LLYX I have an PR that is stable on my local tests, is there any chance you could test the new approach as well?
PR: https://github.com/janbjorge/PgQueuer/pull/63


If the target cluster has its config mounted into containers, we can't know the file's true location

Wanted to capture this while it's still fresh in my mind in case anyone else runs into this. I'm using https://github.com/fusor/origin3-dev/ for my example ocp3 cluster, which brings up an ec2 vm and runs oc cluster up to launch a cluster via docker containers. The cluster's configuration files are stored in a non-default location on the vm, and are mounted into possibly different locations inside the containers.
What this means is that when I run the tool against the cluster, we read the master config and see that htpasswd is configured to be at /etc/origin/master/htpasswd. In reality, that file actually exists at /tmp/openshift.local.clusterup/kube-apiserver/htpasswd on the vm, but it's mounted into the container at /etc/origin/master/htpasswd.
I don't see how we can figure out the true location of the source files if the values in the master config differ from where they actually are on the machine.
@jwmatthews, is this just a product of our particular origin3-dev setup, and we're unlikely to encounter this scenario with the production environments we're migrating? Or is this something we need to address?

Wanted to capture this while it's still fresh in my mind in case anyone else runs into this. I'm using https://github.com/fusor/origin3-dev/ for my example ocp3 cluster, which brings up an ec2 vm and runs oc cluster up to launch a cluster via docker containers. The cluster's configuration files are stored in a non-default location on the vm, and are mounted into possibly different locations inside the containers.
What this means is that when I run the tool against the cluster, we read the master config and see that htpasswd is configured to be at /etc/origin/master/htpasswd. In reality, that file actually exists at /tmp/openshift.local.clusterup/kube-apiserver/htpasswd on the vm, but it's mounted into the container at /etc/origin/master/htpasswd.
I don't see how we can figure out the true location of the source files if the values in the master config differ from where they actually are on the machine.
@jwmatthews, is this just a product of our particular origin3-dev setup, and we're unlikely to encounter this scenario with the production environments we're migrating? Or is this something we need to address?

@eriknelson I will see if I can get a definitive answer.  I assigned this issue to myself and will follow up when I have spoken to some folks on OCP side.
I was thinking perhaps when OCP 3.x clusters were installed from containers and not RPMs maybe there could be a difference in file paths, but unsure.  I've only installed OCP 3.x from rpms.

It'd be interesting to see if oc rsync <pod-name>:/remote/dir/filename ./local/dir would help.
Perhaps we consider  'oc rsync' opposed to the sftp approach for the referenced files?
This needs more vetting

@jwmatthews, @eriknelson, we've seen the limitation of sftp, and rsync would have the same issue if the root user is not allowd through ssh meanwhile we can implement it using ssh commands and sudo.
But the question remains, it this a typical customer use case?

In this case user can fetch files manually and provide them to CPMA. Can we close the issue?

Unfortunately the oc rsync <pod> approach cannot be used for nodes.
The ssh/sudo approach works for now and otherwise local mode to be used.
Closing it, re-open if needed.


[Feature] Re-entrancy guard

Add a re-entrancy guard on executeTransaction

https://github.com/checksig-custody/trusty-contracts/commit/d2de3bc9f39c7302c57f8a2ff91a4355115c4ade


IOS: Keyboard not work correctly in editable HTML block

To add a HTML editor, the common way is to set contentEditable attribute to a block.
However, in the ionic webview ios plugin, when interact with such an editor, keyboard can't stay as show there when focus on different content, instead, it open on one click and close on next click.
Andriod version works well.
To test, just insert following code into ionic page.

This is a pure text line.

This is a div tag

man, I'm experiencing the same thing here. any workaround !?

@nurfgun I've no idea till now. No reply from offical team. I suspect if it is a bug of WKWebview, none sense of the PLUGIN itself.

Is there no movement on this @ionic?

@netsesame2 - Are you now able to use this now?
@IonicProSupport Any Suggestions/fix for getting out of this?

Is there anyone has any solution for this

@jgw96  Any solution for this issue


AppSync GraphQL Transform - update mutation returning null for connection directive field

Describe the bug
Executing an update mutation for a model that uses the connection directive is returning null data, even though the underlying DynamoDB data exists and is correct.
Amplify CLI Version
4.13.1
To Reproduce
I used amplify add api to  create the following GQL schema:
type Position @model {
  id: ID!
  title: Title @connection
}
type Title @model {
  id: ID!
  name: String
  description: String
}

In the AppSync console, I am able to populate data in my DynamoDB Position and Title tables just fine with the generated create mutations,  but when I run the following update mutation it returns null for title, even though when I look in my Position table it contains the correct value for the corresponding positionTitleId field. Here is a sample update mutation request and response.
Request:
mutation UpdatePosition {
  updatePosition(input: {id: "88e92d80-fa6e-41b1-866f-48e48341506b", positionTitleId: "de3c8105-8b59-46c8-a7c5-5180d7d1bf9e"}) {
    id,
    title {
      id
    }
  }
}

Response:
{
  "data": {
    "updatePosition": {
      "id": "88e92d80-fa6e-41b1-866f-48e48341506b",
      "title": null
    }
  }
}

But in Dynamo the positionTitleId field is correctly set to de3c8105-8b59-46c8-a7c5-5180d7d1bf9e
Expected behavior
The expected response would be this:
{
  "data": {
    "updatePosition": {
      "id": "88e92d80-fa6e-41b1-866f-48e48341506b",
      "title": {
        "id": "de3c8105-8b59-46c8-a7c5-5180d7d1bf9e"
      }
  }
}

Desktop (please complete the following information):

OS: Mac Catalina 10.15.3
Node Version: 11.14.0

Additional context
The same thing happens with the Apollo client in my code: the network response says null for title so I'm unable to display the correct data in my app. But since it's happening in AppSync console too, I'm guessing it doesn't have anything to do with my code, but rather with the way the API was created/generated.

Unable to reproduce today.

I am having the same issue with the latest version, I believe it's from the generated code.  Do you have any updates for this?


[ruby] Update Ruby version to 2.2.5

It looks like 2.3.1 is the latest - any reason not to do the full upgrade?

Main reasoning being this is intended for a point release.

I just know there have been a bunch of upstream fixes for Ruby in Windows land, so I wonder if it makes sense bumping now. We have bumped in point releases before, and there are already a number of other "non-pointy" things in master, so I would just jump to latest. Keep in mind that we'll need to upgrade RubyEncoder for the plugin as well /cc @mitchellh

:+1:

I'm not sure if RubyEncoder is available for ruby versions > 2.2

Their website seems to say 2.2... Let's check that

Going with latest 2.2 for now. Will revisit 2.3 next time.


BCM94360NG uplink speed is very low

Love the awesome work!
I been a hackintosh fan for ages and have some experience since old days with random builds.
Since a few years back I've been running MacOS on Dell XPS 9360 7500u. With mixed satisfaction.
I took in the advice to change my dw1560 to BCM94360NG and it does work OOB, but lately I've been bugged by the fact that the uplink speed is very low.
I have 150/150 ISP and have invested tons in Unifi stuff. So I know the quality of the WIFI, signal and what not is good to not be the source.
Download speeds are satisfactory, but upload doesnt ever reach 10Mbit.
(Since I discovered this, coincidently TimeMachine (running on Synology in same network) has started to missbehave as well, so no backups suddenly!)
I've reenabled AirportBrcmFixup as well but still bad.
Any advice would be much appreciated!

Thank you for getting back!
I have identical set of kexts. So it must be hw related I guess. Any hints on how to check wifi logs or logs for this specific card? Maybe its firmware problem?
best,
Filip

I don't know much about checking that, no. Did you open it back up and ensure the antenna are hooked up properly? If it were me I'd start there. Maybe even buy a second one to see if it works better and send one back.

Thank you! What I did was to put the DW1560 back in, and surprisingly it just started without issues and I have no speed issues. So happy right now. Once I get bored, I will probably buy a new NG and test. :)


Remove usage of user32-sys crate

user32-sys is no longer used with winapi 0.3: https://github.com/retep998/winapi-rs#should-i-still-use-those--sys-crates-such-as-kernel32-sys

Another option would be to switch to using windows/windows-sys: https://github.com/microsoft/windows-rs


Different Doctrine types name format

Hi @BenMorel,
thanks a lot for your work and this library.
During my last development I noticed that the names you used for Doctrine types is different from the Doctrine DBAL standard naming.
In the Doctrine official library the types are named this way:
[...]
    public const DATE_IMMUTABLE       = 'date_immutable';
    public const DATEINTERVAL         = 'dateinterval';
    public const DATETIME_MUTABLE     = 'datetime';
    public const DATETIME_IMMUTABLE   = 'datetime_immutable';
    public const DATETIMETZ_MUTABLE   = 'datetimetz';
    public const DATETIMETZ_IMMUTABLE = 'datetimetz_immutable';
[...]

while in your library you use the camelCase notation:
[...]
final class LocalDateTimeType extends Type
{
    public function getName(): string
    {
        return 'LocalDateTime';
    }
[...]

Can I ask you why? Would you consider to change this if I open a pull request for this change?
Hope to hear from you soon

Hi, no particular reason, but personal preference. I don't think it hurts much, we use it this way in our codebase at work, but let's see what others think about it?

Hi! Yes, I don't see any problem with this either. I was asking just for a uniformity purpose.
Let's see what everybody else thinks. 😁


Mark non-foreign entry points of @objc dynamic methods in generic c…

…lasses dynamically_replaceable
class Generic<T> {
  @objc dynamic func method() {}
}

extension Generic {
  @_dynamicReplacement(for:method())
  func replacement() {}
}

The standard mechanism of using Objective-C categories for dynamically
replacing @objc methods in generic classes does not work.
Instead we mark the native entry point as replaceable.
Because this affects all @objc methods in generic classes (whether there
is a replacement or not) by making the native entry point
[dynamically_replaceable] (regardless of optimization mode) we guard this by
the -enable-implicit-dynamic flag because we are late in the release cycle.
rdar://63679357

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 7e921493f67a9667e30c1a61c387a6a24421cf10

Build failed
Swift Test Linux Platform
Git Sha - 7e921493f67a9667e30c1a61c387a6a24421cf10

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 7e921493f67a9667e30c1a61c387a6a24421cf10

Build failed
Swift Test Linux Platform
Git Sha - 7e921493f67a9667e30c1a61c387a6a24421cf10

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 1339e12a1128f6767ab0b297866104ffc65d8785

Build failed
Swift Test OS X Platform
Git Sha - 1339e12a1128f6767ab0b297866104ffc65d8785

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 67220d8b251f8262d4596423f90dfcc2900ff9d6

Build failed
Swift Test Linux Platform
Git Sha - 67220d8b251f8262d4596423f90dfcc2900ff9d6

@swift-ci Please test windows

@swift-ci Please test source compatibility

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 7632f7e290ee33e6904b53d69428f3af153f5e7c

Build failed
Swift Test OS X Platform
Git Sha - 7632f7e290ee33e6904b53d69428f3af153f5e7c


build: update merger filename

Thanks for raising this PR but that TODO is what I have been wondering about, as the whole PostCSS/config may be in CJS syntax and/or Nuxt 2 projects may be in CJS. The MJS is explicit and helpful no? What shortcomings were there specifying that extension?

The error is not coming from loading the merger.js file. Even when I update it to be .mjs, the same warnings are logged.

@ineshbose Seems we have a regression somewhere in that deps upgrade (though not, apparently, in the module-builder update)...


Add quotes so it's valid YAML on php7.2

Without you'll get a page saying something is broken when using php7.2
Should also fix #27

@Padrio are you still using Beta 7(.2)? I need to know this as it will determine if I need to create a patch for legacy usage.

We are about to archive this extension as abandoned in favor of the planned merged extensions via Flagrow space. With that being said, we are no longer merging PR's.
Please consider upgrading your Flarum version to support future development of newer and updated extensions :)


Tracker: Benchmarking codegen hacks

This issue is about things to change in code generation which are just hacks to make benchmarking easier. The idea is to avoid manual modifications to the output C++ code so we can directly evaluate what we generate. The spirit behind these hacks is not elegance; we just need to get the job done by any means necessary in the easiest possible way.
Here's what I am aware of so far:

[ ] Software integers. It's useful for debugging purposes to compile the "HLS" output code using a normal software compiler (i.e., gcc or clang). This means that the code needs to avoid using ap_int when doing that. I can see several ways to do that:

Insert an #ifdef (which activates only in an HLS compiler) around a template hack to replace ap_int with int.
Add a new backend mode, called like vivado-sw or something, that just generates int in place of ap_int.
Like the above, but use ac_int, as mentioned in https://github.com/cucapra/seashell/issues/105#issuecomment-475416029. (This would be nice but not in the spirit of a dumb-as-possible hack.)

[ ] SDSoC pragmas. We need to add the #pragma SDS nonsense that makes the whole SDSoC compiler toolchain go. An easy, inelegant way to do this would be to add a construct to the language that just specifies a string to output before the function declaration; we pass this string through unchanged.
[ ] Trip count pragmas for estimation. In estimation mode (but not when generating real hardware), the HLS tool wants to know the estimated trip count for while loops (which it obviously can't deduce by itself) so it can estimate the time the execution will take. We could also use the pass-through string approach for this.

For Software integers I'm adding
#ifdef __SDSCC__
#include "ap_int.h"
#else
template < int N >
using ap_int = int;
#endif

Moved character literals to #105. I'm closing this issue, since we've done the big ones—there are still outstanding differences in the manually-hacked C++, but we can open individual issues for those after we understand them.


Fix reading elf section from file buffer

This pr fixes a bug where reading elf sections from the file buffer would read less data than intended.
@adrian-prantl

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test macOS

@swift-ci smoke test Linux

@adrian-prantl all checks passed, but I double-checked the code and there was still a possible bug there, so I had to push again.

@swift-ci smoke test

@adrian-prantl Some other PRs seem to have the tests running now. Could you try restarting the tests here one more time please?

Actually, looks like the linux build just started.


Support scope/language-specific fontFamily, lineHeight

The flight-manual lists a very limited set of Language Specific Configuration Settings.
As discussed, it would be great, if fontFamily and lineHeight could be supported as well. Then you could e.g. do:
".gfm.source":
  editor:
    lineHeight: 2

Or is there any way a package like my atom-markdown-editor-simple-style could increase lineHeight – but only for markdown files?


Improve support for internal packages by resolving path aliases

🔍 Search Terms
Internal packages
Path alias
Resolve paths
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
Add a tsconfig.json to the exports field in package.json so that internal packages can share their TypeScript config especially their path aliases.
// ./libs/math/package.json
{
  "name": "@repo/libs-math",
  "version": "1.0.0",
  "private": true,
  "main": "./src/index.ts",
  "types": "./src/index.ts",
  "exports": {
    // exports local tsconfig.json so consumers can resolve local path aliases
    "./tsconfig.json": "./tsconfig.json",
    ".": {
      "import": "./src/index.ts",
      "require": "./src/index.ts",
      "types": "./src/index.ts"
    }
  }
}

📃 Motivating Example
Please find a reproduction example here: https://github.com/zirkelc/typescript-internal-packages

Install all dependencies with pnpm install in the project root. Then open apps/foo/src/index.ts and you will see that TypeScript cannot resolve the dependency to @repo/libs-with-alias correctly.

I'm using internal packages to share code in my monorepo. An internal package is package which is NOT published to NPM and which is NOT explicitly compiled with TypeScript before it can be used by other packages. It exports the source TypeScript *.ts files from the package.json via the main, types, and exports fields:
// ./libs/math
{
  "name": "@repo/libs-math",
  "private": true,
  "main": "./src/index.ts",
  "types": "./src/index.ts",
  "exports": {
    ".": {
      "import": "./src/index.ts",
      "require": "./src/index.ts",
      "types": "./src/index.ts"
    }
  }
}

// ./libs/math/src/index.ts
export const add = (a: number, b: number) => {
	return a + b;
};

This internal package is meant to be installed by other packages in the same repo:
// ./apps/foo
{
  "name": "@repo/apps-foo",
  "dependencies": {
    "@repo/libs-math": "workspace:*"
  }
}

And can be used like a normal dependency which resolve to the original uncompiled TypeScript code:
// ./apps/foo/src/index.ts
import { add } from '@repo/libs-math'
//              ^?  Imports the typescript code from the internal package

Everything good so far. This pattern works well as long as none of the internal packages is using TypeScript path aliases. However, let's re-structure the internal package and use path aliases like ~/math:
// ./libs/math/tsconfig.json
{
  "extends"<EMAIL_ADDRESS>  "compilerOptions": {
    "paths": {
      "~/math": ["./src/math/index.ts"],
    },
  },
  "include": [ "src"]
}

The path alias ~/math points to the sub-folder ./src/math/index.ts. The previous ./src/index.ts becomes a simple barrel file  exports
// ./libs/math/src/index.ts
export * from '~/math'
// ^? Exports from local path alias pointing to ./libs/math/src/math/index.ts

Now, the internal package @repo/libs-math uses path aliases which are defined its own local tsconfig.json. However, the previous import in ./apps/foo will now start to fail:
// ./apps/foo/src/index.ts
import { add } from '@repo/libs-math'
//               ^? Module '"@repo/libs-math"' has no exported member 'add'

TypeScript doesn't find the function anymore, even though go to definition to @repo/libs-math still works.
I assume the reason is the following: TypeScript resolves the imports starting from the app ./apps/foo/src/index.ts to the internal package ./libs/math/src/index.ts. However, TypeScript still works inside the ./apps/foo/tsconfig.json and is not aware of the path aliases defined by the ./libs/math/tsconfig.json. It would need a way to recognize it is in a different package now and must look for the right tsconfig.json in ./libs/math.
That's where my idea of exporting the tsconfig.json in the package.json comes in. TypeScript would notice it is working in a different package when it was moving from ./apps/foo/src/index.ts to ./libs/math/src/index.ts. Then it sees this new package has a local TypeScript config exported from the local ./libs/math/package.json. It sees the path aliases and applies these aliases for all paths inside ./libs/math/*.
💻 Use Cases
There are two possible workarounds:

global path alias: create a root-level tsconfig.paths.json which defines all path aliases for the entire project. Each package-level tsconfig.json extends from this config. There are two disadvantages to this workaround:

packages cannot define package-level path aliases as they would overwrite the inherited root-level aliases
each package can import from every other package via path aliases. that means you could accidentally import from the internal package @repo/libs-math via a typescript path alias instead of a node package (workspace) import.

project references: typescript project references can solve this issue, but they add a lot of complexity due intermediate build steps and overhead in extra multiple tsconfig.json. The package @repo/apps-foo has a node dependency to @repo/libs-math via package.json. For project references, this dependency must be replicated again in the tsconfig.json via references. So the dependency graph of package.json must be repeated for every new internal package.

@zirkelc I'm not sure if you are dealing with the same problem: I'm trying to NOT use the tsconfig paths and use only native module resolution of node.
My understanding is that things we can use are:

subpath import: `import Foe from '#api/Foe'
module alias import: `import type Foe from '#types/Foe'

While the first seems to work with nodenext, the latter seems to be broken and tsc complains about
error TS2307: Cannot find module '@ts-repro/types/User' or its corresponding type declarations.

Is there a way to proper deal with this? Having relative imports and avoid using tsconfig paths?

@damianobarbati indeed my issue is only related to TS and how it resolves the paths.
Sub-path imports are a Node.js feature and I assume they are resolved by Node from within tsc, but import type is TypeScript-specific. I guess when TS sees import type it uses its own resolution algorithm to resolve #types/Foe as a path alias.
Maybe this will be supported in the future. Here is another issue where you might be able to ask for help: https://github.com/microsoft/TypeScript/issues/52460


fresh image when receive commit event

Fix: https://github.com/docker/swarm/issues/1540
Signed-off-by: Xian Chaobo<EMAIL_ADDRESS>

@jimmyxian engine-master still have issues, but engine-stable should be good, as long as this one is green, we can merge.

@vieux Yeah. I will check the integration test (a little busy recently)   :)

@jimmyxian even is the refresh images is triggered right after a commit, you might need to wait for it to finish, before calling docker images

@vieux
Image that we build can not be refreshed , even we can receive commit event when building image on engine side.
Receiving commit event do not mean "build finished"
So, this can not fix: https://github.com/docker/swarm/issues/1540
I have rewritten the test
docker build on engine side ---->  docker commit on engine side)
I think It's OK to merge this PR.  :)

@vieux or @jimmyxian I might be wrong but it seems like this would fix #1540 (or at least me issue I think)
I try to start an intermediate image in from a build. Once the commit event is emitted, and I run docker images, the image I want shows up in the list.
so if e.RefreshImages() does what I think it does (runs docker images after getting the commit event) this should fix the issue I was having :)

@anandkumarpatel
Ehm. this PR can solve start an intermediate image.
Can you try this and see if it works. Thanks.

LGTM ping @abronan
@jimmyxian any plan to fix build ?

LGTM

@vieux
Yeah, try to find the way to solve. :)


Fail to infer recursively defined Json type

Example:
// "typescript": "^4.0.5"

type Json =
  | string
  | number
  | boolean
  | null
  | Array<Json>
  | { [key: string]: Json }

const json = [{ y: "" }, { x: "" }]

// NOTE Add type annotation would work:
// const json: Json = [{ y: "" }, { x: "" }]

const _: Json = json

Error report:
[8:30:16 PM] File change detected. Starting incremental compilation...

src/test.ts:16:7 - error TS2322: Type '({ y: string; x?: undefined; } | { x: string; y?: undefined; })[]' is not assignable to type 'Json'.
  Type '({ y: string; x?: undefined; } | { x: string; y?: undefined; })[]' is not assignable to type 'Json[]'.
    Type '{ y: string; x?: undefined; } | { x: string; y?: undefined; }' is not assignable to type 'Json'.
      Type '{ y: string; x?: undefined; }' is not assignable to type 'Json'.
        Type '{ y: string; x?: undefined; }' is not assignable to type '{ [key: string]: Json; }'.
          Property 'x' is incompatible with index signature.
            Type 'undefined' is not assignable to type 'Json'.

16 const _: Json = json
         ~

[8:30:17 PM] Found 1 error. Watching for file changes.

This is a result of #19513. Check the inferred type of json, it contains optional properties. As a result it's not assignable to your Json type, because undefined (of the optional properties) is not a valid type anywhere.
You can just explicit type your initial variable already:
const json: Json = [{ y: "" }, { x: "" }]

Alterantively, if you replace Array<Json> with ReadonlyArray<Json> you can use const contexts:
const json = [{ y: "" }, { x: "" }] as const

Lastly you could create some elaborate conditional type that would remove all undefined properties (I wouldn't follow this path).

I'd categorize this under "Working as Intended".

Thanks for your reply, and the link to the PR.
My concern is cleared now.


Intellij connection problem with jenkins

Jenkins and plugins versions report

Environment

Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?
I'm using intelij ultimate version 2024.1.6 in ubuntu 20
Reproduction steps
I installed the plugin via marketplace in IntelliJ. Then I connected to my Jenkins server, but nothing appeared in the interface, just the message "Nothing to show", the same one shown in the screenshot. I reinstalled IntelJ, installed other versions and it's still the same, the screen to connect to the server didn't even appear again. How do I fix this?
Expected Results
I expected that achievements and missions would appear in the intellij interface
Actual Results

Anything else?
No response
Are you interested in contributing a fix?
No response

Yes, I am interested.


Give moldy food the "Trash" tag

About the PR
Added the "Trash" tag to allow moldy food to be collected by the Janitors' trash bags.
Why / Balance
Moldy food is generally considered garbage, but was unable to be collected by the Janitor.
Refer to issue #29375.
Technical details
Changes only affect the FoodBreadMoldySlice and FoodPizzaMoldySlice prototypes.
Media
https://github.com/space-wizards/space-station-14/assets/34698192/fba2499f-4223-4bc4-9757-e5afcdd52790

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
No breaking changes anticipated.
Changelog
:cl:

fix: Moldy food can now be collected in the Janitors' trash bags.

We could make the argument that all food items could technically have the 'Trash' tag the same way lightbulbs do. If that's the preferred route, I can adjust.

Add
Fixes #29375
to your post so that the issue is automatically closed if this is merged


Renamed AlgoliaSearchSymfonyDoctrineBundle to AlgoliaSearchBundle, Fixed configuration issue that prevented tests from running on Travis

The build is failing because environment variables defined on Travis are not used when testing pull requests. Builds fine on my fork though :)


Fix alternative formula syntax in markdown

https://chat.congusto.ai/public/049eace2-32fb-4520-a478-6fbc3b49f47a

Related:
https://github.com/remarkjs/remark-math/issues/39
https://github.com/micromark/micromark-extension-math/issues/9


DayViewDecorator doesn't work as it should

So, I want disable dates by DAY_OF_WEEK field. I pass an array of integer to addDecorator() method and these integers represents the fields 'DAY_OF_WEEK' that SHOULDN'T be disabled.
Suppose days array equals [2, 3, 4, 5, 6], that means: Monday, Tuesday, Wednesday, Thursday and Friday.
My code:
void addDecorator (final int[] days) {
        mcv.addDecorator(new DayViewDecorator() {
            @Override
            public boolean shouldDecorate(CalendarDay day) {
                Log.i(TAG, "shouldDecorate: " + days);
                HashSet<CalendarDay> dates = new HashSet<CalendarDay>();

                for (int i : days) {
                    if (day.getCalendar().get(Calendar.DAY_OF_WEEK) != i) {
                        dates.add(day);
                    }
                }
                return dates.contains(day);
}

            @Override
            public void decorate(DayViewFacade view) {
                view.setDaysDisabled(true);
            }

My calendar builder:
private void buildMaterialCalendar() {
        Calendar today = Calendar.getInstance();
        final LocalDate localDate = new LocalDate(today);
        mcv = (MaterialCalendarView) findViewById(R.id.calendarView);
        mcv.state().
                edit()
                .setFirstDayOfWeek(MONDAY)
                .setMinimumDate(today.getTime())
                .setMaximumDate(localDate.dayOfMonth().withMaximumValue().toDate())
                .setCalendarDisplayMode(CalendarMode.MONTHS)
                .commit();
    }

NOTE: I'm using joda LocalDate object
My XML:
<com.prolificinteractive.materialcalendarview.MaterialCalendarView xmlns:app="http://schemas.android.com/apk/res-auto"
            android:id="@+id/calendarView"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            app:mcv_arrowColor="?attr/colorPrimary"
            app:mcv_calendarMode="month"
            app:mcv_dateTextAppearance="@style/CustomDayTextAppearance"
            app:mcv_firstDayOfWeek="monday"
            app:mcv_headerTextAppearance="?android:attr/textAppearanceMedium"
            app:mcv_monthLabels="@array/custom_months"
            app:mcv_selectionColor="?attr/colorPrimary"
            app:mcv_titleAnimationOrientation="vertical"
            app:mcv_weekDayLabels="@array/custom_weekdays"
            app:mcv_weekDayTextAppearance="?android:attr/textAppearanceMedium"
            tools:layout_editor_absoluteX="8dp"
            tools:layout_editor_absoluteY="0dp" />

Screenshot:

The result is all dates disabled! What is wrong with my logic?
The expected result is to turn off every Saturday and Sunday.
Sorry but english is not my first language!

I would verify your decorator and compare it to the sample app. We also provide great info in the wiki.


Interactive editing of grid

As a user, I want to be able to modify the layout of the world (e.g. where tree stumps are placed) in order to test out different code.
Akzeptanzkriterium: The objects in the grid can be manipulated using UI, including placing and removing objects.

#3