Large-V3 does not appear to be a supported option

When running: docker run -it --gpus all -p 9000:9000 -e ASR_MODEL=large-v3 -e ASR_ENGINE=openai_whisper onerahmet/openai-whisper-asr-webservice:latest-gpu
It does not accept large-v3 as a parameter. And outputs this error:
Wrong index found for <|0.02|>: should be None but found 50366.
[2023-11-28 01:34:45 +0000] [8] [ERROR] Exception in worker process
Traceback (most recent call last):
  File "/app/.venv/lib/python3.10/site-packages/gunicorn/arbiter.py", line 589, in spawn_worker
    worker.init_process()
  File "/app/.venv/lib/python3.10/site-packages/uvicorn/workers.py", line 66, in init_process
    super(UvicornWorker, self).init_process()
  File "/app/.venv/lib/python3.10/site-packages/gunicorn/workers/base.py", line 134, in init_process
    self.load_wsgi()
  File "/app/.venv/lib/python3.10/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi
    self.wsgi = self.app.wsgi()
  File "/app/.venv/lib/python3.10/site-packages/gunicorn/app/base.py", line 67, in wsgi
    self.callable = self.load()
  File "/app/.venv/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
    return self.load_wsgiapp()
  File "/app/.venv/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
    return util.import_app(self.app_uri)
  File "/app/.venv/lib/python3.10/site-packages/gunicorn/util.py", line 359, in import_app
    mod = importlib.import_module(module)
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/app/webservice.py", line 65, in <module>
    whisper_model = whisper.load_model(whisper_model_name).cuda()
  File "/app/.venv/lib/python3.10/site-packages/whisper/__init__.py", line 112, in load_model
    raise RuntimeError(f"Model {name} not found; available models = {available_models()}")
RuntimeError: Model large-v3 not found; available models = ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large']
[2023-11-28 01:34:45 +0000] [8] [INFO] Worker exiting (pid: 8)
[2023-11-28 01:34:47 +0000] [7] [INFO] Shutting down: Master
[2023-11-28 01:34:47 +0000] [7] [INFO] Reason: Worker failed to boot.

When using just large it also appears to only be downloading v2 still and not v3.
Also would like to test the faster-whisper v3 integration but when I run the large-v3 option with faster_whisper it appears to only downloads the large-v2.pt
Thoughts? Am I running something incorrectly?

Can you double check that the latest Docker image was used? If so, maybe a mistake was made when building and publishing the newest image.

Can you double check that the latest Docker image was used? If so, maybe a mistake was made when building and publishing the newest image.
You can always build the image yourself to test. I'll be doing this in a couple hours when I am home.

It does appear to be pulling from the latest I ran docker pull onerahmet/openai-whisper-asr-webservice says its on latest and also shouldnt onerahmet/openai-whisper-asr-webservice:latest-gpu part of the docker run command always reference the latest docker hub build?
Good idea I will give it a shot building myself now.

also shouldnt onerahmet/openai-whisper-asr-webservice:latest-gpu part of the docker run command always reference the latest docker hub build?

Yep, just sanity checking.

UPDATE:
Building the image locally from the GitHub repo worked for me!
Maybe its something wrong with the docker hub image?
Excited to test out V3 stuff!

@blundercode please ensure that you pull the image before running the command; otherwise, it will run the cached image that you pulled previously.
docker pull onerahmet/openai-whisper-asr-webservice:latest-gpu

@ahmetoner
Alright that fixed it I was running docker pull onerahmet/openai-whisper-asr-webservice I guess I needed the  :latest-gpu tag on the end of it good know. My bad sorry for the false alarm!
I was just using the default docker pull onerahmet/openai-whisper-asr-webservice command on the dockerhub. Might be worth updating the docs to idiot-proof it so people like me don't bother you haha
Thanks for the updates and quick responses from both of you


Add docker example

Add an example showing how to create a docker image that contains a Theia-based application with the vscode-trace-extension.

I'm not sure if this contribution might fit-in better in repo theia-trace-extension? It's quite similar to the Docker example we already have in there, except this one here uses the Trace Viewer for VSCode from open-vsx, instead of using the Theia Trace Viewer extension from npm.
Alternatively, since neither example application directly depend on the content in either repository, we might consider creating a new repo for them both, e.g. "Trace Viewer example applications" ?
@frallax  @bhufmann WDYT?
P.S. one potential argument to have this contribution in this repo here: we would need to try to confirm, but it's possible that the repo's tests, currently used against openvscode server running the vscode trace viewer, could be easily re-used on the containerized example Theia app running the same.

@marcdumais-work not sure if this can be used for the tests you mention above, mainly because the Theia application is not picking the "latest vscode-trace-extension master" but one of the released prebuilt vsix packages.
I think it belongs to this repo just to provide an example of how the artifacts produced by this repo can be used.
But this is just my opinion.

not sure if this can be used for the tests you mention above, mainly because the Theia application is not picking the "latest vscode-trace-extension master" but one of the released prebuilt vsix packages.

I agree - but the goal would not be to test the trace viewer extension (it's already being tested), but rather to test the example application itself, to detect if it breaks. It's just a little bonus, if we can do that re-using the existing tests in the repo, like we did for the example application in theia-trace-extension.

I'm not sure if this contribution might fit-in better in repo theia-trace-extension? It's quite similar to the Docker example we already have in there, except this one here uses the Trace Viewer for VSCode extension from open-vsx, instead of using the Theia Trace Viewer extension from npm.
Alternatively, since neither example application directly depend on the content in either repository, we might consider creating a new repo for them both, e.g. "Trace Viewer example applications" ?
@frallax @bhufmann WDYT?
P.S. one potential argument to have this contribution in this repo here: we would need to try to confirm, but it's possible that the repo's tests, currently used against openvscode server running the vscode trace viewer, could be easily re-used on the containerized example Theia app running the same.

I think that this docker example should be in the theia-trace-extension repository, since it's a Theia application. @frallax could you please contribute it there?

@bhufmann before following your advice, I'd like to understand the rationale of having this example in the theia-trace-extension repo. What is proposed in this pull request is an example of how to use the artifact created by this repo (vscode-trace-extension). That's why I contributed it to this repo.
The fact that the artifact is wrapped in a Theia application does not sound as a reason to have it in the theia-trace-extension repo. Maybe I should change it to a VSCode application, but then, would that really make a difference? Aren't we just changing the way we wrap an artifact created by the vscode-trace-extension repo?
Thanks for the explanation and help in advance!


Increase pip default timeout

Motivation and context

To be able to download tensorflow fully before timeout. The full package is 394.8 MB large.
#47 24.62   Downloading tensorflow-2.4.0-cp38-cp38-manylinux2010_x86_64.whl (394.8 MB)
#47 69.32 ERROR: Exception:
#47 69.32 Traceback (most recent call last):
#47 69.32   File "/opt/venv/lib/python3.8/site-packages/pip/_vendor/urllib3/response.py", line 425, in _error_catcher
#47 69.32     yield
#47 69.32   File "/opt/venv/lib/python3.8/site-packages/pip/_vendor/urllib3/response.py", line 507, in read
#47 69.32     data = self._fp.read(amt) if not fp_closed else b""
#47 69.32   File "/usr/lib/python3.8/http/client.py", line 458, in read
#47 69.32     n = self.readinto(b)
#47 69.32   File "/usr/lib/python3.8/http/client.py", line 502, in readinto
#47 69.32     n = self.fp.readinto(b)
#47 69.32   File "/usr/lib/python3.8/socket.py", line 669, in readinto
#47 69.32     return self._sock.recv_into(b)
#47 69.32   File "/usr/lib/python3.8/ssl.py", line 1241, in recv_into
#47 69.32     return self.read(nbytes, buffer)
#47 69.32   File "/usr/lib/python3.8/ssl.py", line 1099, in read
#47 69.32     return self._sslobj.read(len, buffer)
#47 69.32 socket.timeout: The read operation timed out

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage decreased (-0.04%) to 70.256% when pulling 93a81de5118ba1a7701b15edc8c9aa31bedeb380 on sbekbulaeva:add-pip-timeout into 473554bd59b6f78d6cbf0ba3aa540d2045c724ff on openvinotoolkit:develop.

Coverage decreased (-0.04%) to 70.256% when pulling 93a81de5118ba1a7701b15edc8c9aa31bedeb380 on sbekbulaeva:add-pip-timeout into 473554bd59b6f78d6cbf0ba3aa540d2045c724ff on openvinotoolkit:develop.

@sbekbulaeva , why should we increase it only for CI?
@azhavoro , what is your opinion here?

@sbekbulaeva , why should we increase it only for CI?
@azhavoro , what is your opinion here?

@sbekbulaeva Does this mean that the build can be frozen for up to 1000 seconds without any output?
This timeout doesn't not mean the max time to download the package, so I have 2 comments:
I believe 1000s is to long for socket read timeout (default is 15s);
I'm ok to increase this timeout, but it should be added to the main Dockerfile.

@sbekbulaeva Does this mean that the build can be frozen for up to 1000 seconds without any output?
This timeout doesn't not mean the max time to download the package, so I have 2 comments:
I believe 1000s is to long for socket read timeout (default is 15s);
I'm ok to increase this timeout, but it should be added to the main Dockerfile.

@sbekbulaeva , please create an issue and describe what you want to fix. We didn't see such problems in our infrastructure (CI tests are run every day multiple times). I will close the PR.

@sbekbulaeva , please create an issue and describe what you want to fix. We didn't see such problems in our infrastructure (CI tests are run every day multiple times). I will close the PR.


h265e: returned utility macro for parameters copy

Maybe it's time to abandon macros? I believe templates here would give safer solution.

how you suggest to implement such thing without macro? Currently c++ doesn't have reflection. The original request came from @ogolikov, she wants to see all parameters listed in a way I did in current commit


Unable to resume execution after hitting breakpoint in Flutter app (Hello World)

I'm working on Flutter integration for Dart Code and mostly reusing the existing Dart debugging code. I'm running the Hello World app from the repo and have restructured the code slightly for testing debugging/stepping. Code looks like this:
import 'package:flutter/widgets.dart';

void main() {
  const t = const Text('Hello, world!'); // <-- Breakpoint on this line
  const c = const Center(child: t);
  runApp(c);
}

I launch the app (with --start-paused) and connect to observatory and send a resume command and the app begins, hits my breakpoint, and sends back the PauseBreakpoint event. However, when I then send a resume, nothing happens.
Here's the relevant parts of the communication with observatory:
// Resume execution (started with --start-paused)
[4:23:30 PM]: <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"Resume","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/816748097","name":"app.flx$main","number":"816748097"},"timestamp":1497108209798}}}

// Hit breakpoint
[4:23:30 PM]: <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointResolved","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/816748097","name":"app.flx$main","number":"816748097"},"timestamp":1497108209805,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints\/1","breakpointNumber":1,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16455461\/scripts\/file%3A%2F%2F%2Fm%3A%2FCoding%2FApplications%2Fflutter%2Fexamples%2Fhello_world%2Flib%2Fmain.dart\/15c929a5c8f","uri":"file:\/\/\/m:\/Coding\/Applications\/flutter\/examples\/hello_world\/lib\/main.dart","_kind":"script"},"tokenPos":17}}}}}
[4:23:30 PM]: <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseBreakpoint","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/816748097","name":"app.flx$main","number":"816748097"},"timestamp":1497108209805,"pauseBreakpoints":[{"type":"Breakpoint","fixedId":true,"id":"breakpoints\/1","breakpointNumber":1,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16455461\/scripts\/file%3A%2F%2F%2Fm%3A%2FCoding%2FApplications%2Fflutter%2Fexamples%2Fhello_world%2Flib%2Fmain.dart\/15c929a5c8f","uri":"file:\/\/\/m:\/Coding\/Applications\/flutter\/examples\/hello_world\/lib\/main.dart","_kind":"script"},"tokenPos":17}}],"topFrame":{"type":"Frame","kind":"Regular","location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16455461\/scripts\/file%3A%2F%2F%2Fm%3A%2FCoding%2FApplications%2Fflutter%2Fexamples%2Fhello_world%2Flib%2Fmain.dart\/15c929a5c8f","uri":"file:\/\/\/m:\/Coding\/Applications\/flutter\/examples\/hello_world\/lib\/main.dart","_kind":"script"},"tokenPos":17},"function":{"type":"@Function","fixedId":true,"id":"classes\/1148\/functions\/main","name":"main","owner":{"type":"@Library","fixedId":true,"id":"libraries\/@16455461","name":"","uri":"file:\/\/\/m:\/Coding\/Applications\/flutter\/examples\/hello_world\/lib\/main.dart"},"_kind":"RegularFunction","static":true,"const":false,"_intrinsic":false,"_native":false},"code":{"type":"@Code","fixedId":true,"id":"code\/4d161e59-72e97b927540","name":"main","kind":"Dart","_optimized":false,"_intrinsic":false,"_native":false},"vars":[],"index":0}}}}

// Send step
[4:23:34 PM]: ==> {"id":"356","method":"resume","params":{"isolateId":"isolates/816748097","step":"Over"}}

// Nothing ever comes back

This is the same debugging code I'm using for Dart apps which seems to work without any issues. If I try to open the Observatory web app it just never responds (and then when I terminate the process, I immediately get a connection error).
How do I debug the debugger? =)
The exact code I'm using to hit/test this is https://github.com/Dart-Code/Dart-Code/tree/d91964aa3ced258effeb5b6d7f4647b9228c693e
(cc @devoncarew)

cc @a-siva

Hmm, there should really be no differences in terms of debugging a flutter app and a command-line app. You're sending the messages to the correct isolate above (816748097), which was the only thing I could think of to check.

@devoncarew That's the first thing I checked too. I'm not really sure how to debug any further; esp as I can't load the observatory page in the browser when it's in this state! This is currently the only thing outstanding on shipping a flutter version for testing so any help appreciated!

Hmm. Just to try a few things out, what if you don't start with --start-paused? You won't hit breakpoints in main(), but should be able to hit them on event callbacks.

Didn't try that; I'll give it a go (probably tomorrow evening now) and post back.

Could you also try to issue the resume command without the step parameter, currently is seems to send 'step: Over'

Using different steps doesn't make any difference, they're all the same :(
However! ... I just did some testing with another app (Stocks example) and the debugger is working fine!
Can someone test this in another IDE using the hello_world example from the flutter repo? I changed the main method slightly to multiple lines:
void main() {
  const t = const Text('Hello, world!');
  const c = const Center(child: t);
  runApp(c);
}

Breakpoint on the first one; then try to step. Does it work?

As user that's testing the flutter integration in Dart Code hit this too, see https://github.com/Dart-Code/Dart-Code/issues/318#issuecomment-308381884
So maybe it's not isolated to hello world. Would be good if someone on the flutter/Dart team was able to try and repro, I think it's going to be very difficult for us to debug from the outside.

@DanTup, I did verify this works with IntelliJ. Perhaps a race condition with isolates and startup in the vscode impl? An app that takes less time to start up (like hello-world) may hit this more frequently.
If you do see this with IntelliJ, it's likely a more wide-spread issue.

@devoncarew It's possible though I don't think we do anything immediately (and I'm not sure it could cause behaviour like this - we've hit a breakpoint and had info from Observatory, then asked it to resume).
I'll see if I can repro in a simple script or another IDE. The only other significant traffic in my log is that we send setLibraryDebuggable for every library (except dart:_...); I wonder if there's something weird in flutter that's causing problems here (we have to send them all because the default value for setLibraryDebuggable hasn't been consistent); I'll try disabling and see if that affects things.

Seems like this issue might be isolated to the main method. If I'm at a breakpoint elsewhere, I can step. But in main I can't.
Interesting the stack trace doesn't show me as being in main when I stop at a breakpoint there:

I removed all my setLibraryDebuggable calls and it made no difference. It seems that breakpoints outside of main method are fine - I can step from them. Anything in main method just causes a hang.

Ok, it's not isolated to main... Here is a log showing I performed a step over after hitting a breaking and it worked then the very next step over did not (I tried several times, nothing back):
[8:43:35 PM]: ==> {"id":"14","method":"resume","params":{"isolateId":"isolates/770257893","step":"Over"}}
[8:43:35 PM]: <== {"jsonrpc":"2.0", "result":{"type":"Success"},"id":"14"}
[8:43:35 PM]: <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"Resume","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/770257893","name":"app.flx$main","number":"770257893"}...
[8:43:35 PM]: <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseBreakpoint","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/770257893","name":"app.flx$main","number":"770257893"}...
[8:43:36 PM]: ==> {"id":"17","method":"resume","params":{"isolateId":"isolates/770257893","step":"Over"}}
[8:43:38 PM]: ==> {"id":"18","method":"resume","params":{"isolateId":"isolates/770257893","step":"Over"}}
[8:43:38 PM]: ==> {"id":"19","method":"resume","params":{"isolateId":"isolates/770257893","step":"Over"}}

I'm not sure how I could cause this behaviour even if I wanted to (a step worked, then the very next step on the same isolate got no response). I think something bad is happening inside observatory but I have no idea how to debug (or get logs from) that.

I'm trying to recreate the same issue using the flutter_gallery example and observatory:

I've added the same two extra lines in the main.
I've started the flutter_gallery app using --start-paused
I've added the breakpoint
Continue
Next
Next
Next
The program reached the end of the main function

On the wire we can see the messages:
{"id":"525","method":"resume","params":{"isolateId":"isolates/157434430"}}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"Resume","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476608762}}}
{"jsonrpc":"2.0", "result":{"type":"Success"},"id":"525"}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointResolved","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476608805,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints\/1","breakpointNumber":1,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":25}}}}}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseBreakpoint","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476608806,"pauseBreakpoints":[{"type":"Breakpoint","fixedId":true,"id":"breakpoints\/1","breakpointNumber":1,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":25}}],"topFrame":{"type":"Frame","kind":"Regular","location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":25},"function":{"type":"@Function","fixedId":true,"id":"classes\/1148\/functions\/main","name":"main","owner":{"type":"@Library","fixedId":true,"id":"libraries\/@16394289","name":"","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart"},"_kind":"RegularFunction","static":true,"const":false,"_intrinsic":false,"_native":false},"code":{"type":"@Code","fixedId":true,"id":"code\/329960061-9fd782a0","name":"main","kind":"Dart","_optimized":false,"_intrinsic":false,"_native":false},"vars":[],"index":0}}}}
...
{"id":"535","method":"resume","params":{"step":"Over","isolateId":"isolates/157434430"}}
{"jsonrpc":"2.0", "result":{"type":"Success"},"id":"535"}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"Resume","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476616683,"topFrame":{"type":"Frame","kind":"Regular","location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":25},"function":{"type":"@Function","fixedId":true,"id":"classes\/1148\/functions\/main","name":"main","owner":{"type":"@Library","fixedId":true,"id":"libraries\/@16394289","name":"","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart"},"_kind":"RegularFunction","static":true,"const":false,"_intrinsic":false,"_native":false},"code":{"type":"@Code","fixedId":true,"id":"code\/329960061-9fd782a0","name":"main","kind":"Dart","_optimized":false,"_intrinsic":false,"_native":false},"vars":[],"index":0}}}}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseBreakpoint","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476616687,"pauseBreakpoints":[],"topFrame":{"type":"Frame","kind":"Regular","location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":35},"function":{"type":"@Function","fixedId":true,"id":"classes\/1148\/functions\/main","name":"main","owner":{"type":"@Library","fixedId":true,"id":"libraries\/@16394289","name":"","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart"},"_kind":"RegularFunction","static":true,"const":false,"_intrinsic":false,"_native":false},"code":{"type":"@Code","fixedId":true,"id":"code\/329960061-9fd782a0","name":"main","kind":"Dart","_optimized":false,"_intrinsic":false,"_native":false},"vars":[{"type":"BoundVariable","name":"t","value":{"type":"@Instance","class":{"type":"@Class","fixedId":true,"id":"classes\/1795","name":"Text"},"kind":"PlainInstance","id":"objects\/62"},"declarationTokenPos":24,"scopeStartTokenPos":31,"scopeEndTokenPos":60}],"index":0}}}}
...
{"id":"540","method":"resume","params":{"step":"Over","isolateId":"isolates/157434430"}}
{"jsonrpc":"2.0", "result":{"type":"Success"},"id":"540"}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"Resume","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476619114,"topFrame":{"type":"Frame","kind":"Regular","location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":35},"function":{"type":"@Function","fixedId":true,"id":"classes\/1148\/functions\/main","name":"main","owner":{"type":"@Library","fixedId":true,"id":"libraries\/@16394289","name":"","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart"},"_kind":"RegularFunction","static":true,"const":false,"_intrinsic":false,"_native":false},"code":{"type":"@Code","fixedId":true,"id":"code\/329960061-9fd782a0","name":"main","kind":"Dart","_optimized":false,"_intrinsic":false,"_native":false},"vars":[{"type":"BoundVariable","name":"t","value":{"type":"@Instance","class":{"type":"@Class","fixedId":true,"id":"classes\/1795","name":"Text"},"kind":"PlainInstance","id":"objects\/70"},"declarationTokenPos":24,"scopeStartTokenPos":31,"scopeEndTokenPos":60}],"index":0}}}}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseBreakpoint","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476619118,"pauseBreakpoints":[],"topFrame":{"type":"Frame","kind":"Regular","location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":47},"function":{"type":"@Function","fixedId":true,"id":"classes\/1148\/functions\/main","name":"main","owner":{"type":"@Library","fixedId":true,"id":"libraries\/@16394289","name":"","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart"},"_kind":"RegularFunction","static":true,"const":false,"_intrinsic":false,"_native":false},"code":{"type":"@Code","fixedId":true,"id":"code\/329960061-9fd782a0","name":"main","kind":"Dart","_optimized":false,"_intrinsic":false,"_native":false},"vars":[{"type":"BoundVariable","name":"t","value":{"type":"@Instance","class":{"type":"@Class","fixedId":true,"id":"classes\/1795","name":"Text"},"kind":"PlainInstance","id":"objects\/71"},"declarationTokenPos":24,"scopeStartTokenPos":31,"scopeEndTokenPos":60},{"type":"BoundVariable","name":"c","value":{"type":"@Instance","class":{"type":"@Class","fixedId":true,"id":"classes\/1334","name":"Center"},"kind":"PlainInstance","id":"objects\/72"},"declarationTokenPos":34,"scopeStartTokenPos":45,"scopeEndTokenPos":60}],"index":0}}}}
...
{"id":"545","method":"resume","params":{"step":"Over","isolateId":"isolates/157434430"}}
{"jsonrpc":"2.0", "result":{"type":"Success"},"id":"545"}
{"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"Resume","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/157434430","name":"app.flx$main","number":"157434430"},"timestamp":1497476621385,"topFrame":{"type":"Frame","kind":"Regular","location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries\/@16394289\/scripts\/file%3A%2F%2F%2Fusr%2Flocal%2Fgoogle%2Fhome%2Fcbernaschina%2FGit%2Fflutter%2Fexamples%2Fflutter_gallery%2Flib%2Fmain.dart\/15ca88f855f","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart","_kind":"script"},"tokenPos":47},"function":{"type":"@Function","fixedId":true,"id":"classes\/1148\/functions\/main","name":"main","owner":{"type":"@Library","fixedId":true,"id":"libraries\/@16394289","name":"","uri":"file:\/\/\/usr\/local\/google\/home\/cbernaschina\/Git\/flutter\/examples\/flutter_gallery\/lib\/main.dart"},"_kind":"RegularFunction","static":true,"const":false,"_intrinsic":false,"_native":false},"code":{"type":"@Code","fixedId":true,"id":"code\/329960061-9fd782a0","name":"main","kind":"Dart","_optimized":false,"_intrinsic":false,"_native":false},"vars":[{"type":"BoundVariable","name":"t","value":{"type":"@Instance","class":{"type":"@Class","fixedId":true,"id":"classes\/1795","name":"Text"},"kind":"PlainInstance","id":"objects\/82"},"declarationTokenPos":24,"scopeStartTokenPos":31,"scopeEndTokenPos":60},{"type":"BoundVariable","name":"c","value":{"type":"@Instance","class":{"type":"@Class","fixedId":true,"id":"classes\/1334","name":"Center"},"kind":"PlainInstance","id":"objects\/83"},"declarationTokenPos":34,"scopeStartTokenPos":45,"scopeEndTokenPos":60}],"index":0}}}}
...

Can you confirm that with observatory it works?

I'll try ad to it manually with Observatory tonight. I posted in the vm-dev group about this too and was asked to try and get a stack trace using gdb so I'll give that a go too.

Attached is the stack traces from the stocks app when this happens (as well as the observatory log). I don't know if the stack traces are for the correct process (but it's the only one that looked like the apps process in the emulator).
There's also a discussion about this in the vm-dev group: https://groups.google.com/a/dartlang.org/forum/?fromgroups#!topic/vm-dev/Hrwa_flhsCA
observatory.txt
gdb.txt

There is something strange with your logs.
You are setting two breakpoints:

at line 66 of main.dart
at line 66 of package:stocks/main.dart (which doesn't exists)

Line 66 is the theme getter and not the beginning of the main function
The observatory log that you generated is not the same of the one generated by the observatory connected to our test phone.
How did you generated them?
 Are you opening it using flutter run --observatory-port=65432 --start-paused and going to http://localhost:65432?

You are setting two breakpoints:

This is a workaround for an issue https://github.com/Dart-Code/Dart-Code/issues/134; only one of them will resolve but if I don't do this then the breakpoint may not be hit depending on how the user imports the file. If there's a better way to do this, I'd love to know; though I removed it while testing this and it didn't seem to make any difference (it's also been there for a long time in the Dart debugging and never caused any problems)

at line 66 of package:stocks/main.dart (which doesn't exists)

package:stocks maps back to ./lib according to .packages, since stocks is the name of this app, so package:stocks/main.dart is the same as ./lib/main.dart? However I don't think it's imported, I can remove the sending of that breakpoint without affecting the issue (same goes for all the setLibraryDebuggable calls; I can strip them and it still happens).

Line 66 is the theme getter and not the beginning of the main function

That's correct; this issue is most reproducible in the main method but it actually happens a lot all over the place. This line is where my breakpoint is and I'm trying to Step Over once it's hit.

The observatory log that you generated is not the same of the one generated by the observatory connected to our test phone.

Do you mean the format, or the content? The format is Dart Code's own logging (I don't/didn't know if Observatory can generate logs itself).

How did you generated them?

I'm just logging all communication over the websocket to Observatory and prefixing with timestamps and direction.

 Are you opening it using flutter run --observatory-port=65432 --start-paused and going to http://localhost:65432?

Pretty much. I'm starting as flutter run -observatory-port=0 --start-paused then waiting for the app.debugPort notification and then connecting to the wsUri (then logging all communication over that websocket).
(These logs are from the web socket; I didn't get chance to try this directly using observatory but I hope to get time to try this today).

Ok, I just repro'd in observatory. I ran flutter run --start-paused --observatory-port=0, opened obseravtory and set a breakpoint on main.dart:66 then did continue and I got this:

I don't know a lot about this, but looking at the stack trace that error doesn't look like an error in the stocks app code, so I wonder if this is the crash that's breaking observatory? If so, is this a flutter issue or should I re-raise this in the sdk repo?

Er actually, this looks like an error in the web interface and I suspect a red herring?!

I'm trying to reproduce it on our development devices unsuccessfully.
I kindly ask you some information to reduce the number of variables:

Which version of flutter are you using? flutter --version
Given the stocks application, which are the minimum number of changes to its source code to reproduce the bug?

Flutter • channel master • https://github.com/flutter/flutter.git
Framework • revision 7ada46677b (2 days ago) • 2017-06-14 11:25:03 -0700
Engine • revision 4f5d6fab11
Tools • Dart 1.24.0-dev.6.7
I've made 0 changed to the stocks app; it's totally reproducible for me using the stock code in the repo.
I'm on Windows and I'm running it on an Emulator, most recently this (I had the same thing on an Android 7 one originally):

Is there any way to get Observatory to write diagnostic logs that might be useful?

Just tested on my phone (Moto X Play running Android 6) and I was able to step a couple of times before it stopped, but it did then stop responding the same.
[8:35:13 PM]: ==> {"id":"17","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:13 PM]: <== {"jsonrpc":"2.0", "result":{"type":"Success"},"id":"17"}
[8:35:13 PM]: <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"Resume" // ...
[8:35:13 PM]: <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseBreakpoint" // ...
[8:35:13 PM]: ==> {"id":"18","method":"getStack","params":{"isolateId":"isolates/695261680"}}
[8:35:13 PM]: <== {"jsonrpc":"2.0", "result":{"type":"Stack" // ...
[8:35:13 PM]: ==> {"id":"19","method":"getStack","params":{"isolateId":"isolates/695261680"}}
[8:35:13 PM]: <== {"jsonrpc":"2.0", "result":{"type":"Stack" // ...
[8:35:15 PM]: ==> {"id":"20","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:17 PM]: ==> {"id":"21","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:18 PM]: ==> {"id":"22","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:19 PM]: ==> {"id":"23","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:20 PM]: ==> {"id":"24","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:20 PM]: ==> {"id":"25","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:21 PM]: ==> {"id":"26","method":"resume","params":{"isolateId":"isolates/695261680","step":"Over"}}
[8:35:22 PM]: ==> {"id":"27","method":"resume","params":{"isolateId":"isolates/695261680"}}
[8:35:22 PM]: ==> {"id":"28","method":"resume","params":{"isolateId":"isolates/695261680"}}
[8:35:23 PM]: ==> {"id":"29","method":"resume","params":{"isolateId":"isolates/695261680"}}
[8:35:24 PM]: ==> {"id":"30","method":"resume","params":{"isolateId":"isolates/695261680","step":"Into"}}

Are you able to reproduce the same anomalous behavior on another machine? (the machine you run Flutter from)
On your current machine which version of Windows are you running?
Do you have some custom Windows Firewall rules?
Do you have a custom Firewall application or an Antivirus installed?
If yes, which one? and, can you try to disable it?
I ask this because some Antivirus or Firewall software can interfere with websocket communications.
The logs you sent us not always stop at the same request (the first unanswered request).
If these software are blocking the communication between Observatory and the VM, the VM pause at the breakpoint, but it is not able to actually receive the successive step requests.

I don't have another machine to test it on, but some of the people helping test are seeing the same issue.
I was wondering if something might be interfering with the connection, that's why I was hoping to try and enable some logging in the observatory side.
I'm running Windows 10, with no 3rd party firewall/AV. I don't have any custom rules in the firewall but I'll try disabling both Windows Firewall and Defender(?) when I can next get some time on this. I've also asked  others seeing this issue what platforms they're on.

Disabling Windows Firewall and turning off Windows Defender made no difference, same behaviour.
An additional thing I noticed - seems to be time-based...  If I wait a few seconds, then the first one doesn't work.
I don't think this helps understand the problem, but it seems consistent.

I added some more logging, including writing the state of the websocket on every send, and according to the npm ws library the socket is still in the open state (though I don't know if this is reliable, or how the port forwarding from the host to the device might affect it).

This issue isn't restricted to Windows; someone testing sees the same issue on Mac:
https://github.com/Dart-Code/Dart-Code/issues/318#issuecomment-309266980
I keep stepping through my debug adapter code and adding more logging (if it happens across platforms and no other IDE sees it, it sounds like my issue) but I just can't find anything that might result in this sort of behaviour.
In the absence of other ides, next week I might try and extract the relevant code from Dart Code into a simple npm js file that repros that would be easier to run on different machines without all of VS Code + Dart Code.

Ok, I just ran flutter with some additional flags: ["run", "--machine", "--record-to", "bugreport", "--verbose", "--trace-startup"].
I got a bunch of output that ended with this just before I hit a breakpoint:
[11:40:35 AM]: <== [     +815 ms] DevFS: Starting sync from Instance of 'RecordingDirectory'
[11:40:35 AM]: <== [            ] Scanning project files
[11:40:35 AM]: <== [       +8 ms] Scanning package files
[11:40:35 AM]: <== [      +97 ms] Scanning asset files
[11:40:35 AM]: <== [       +1 ms] Scanning for deleted files
[11:40:35 AM]: <== [      +50 ms] Updating files

I stepped a few times (it works if I do it quickly after hitting the breakpoint, but it hangs) and then right after the last successful step I got this:
[11:40:43 AM]: <== [    +8282 ms] DevFS: Sync finished
[11:40:43 AM]: <== [{"event":"app.progress","params":{"appId":"3cedad04-32e5-483e-a1af-68d0ba9cf4bc","id":"2","progressId":null,"finished":true}}]
[11:40:43 AM]: <== [            ] Synced 6.1MB.

I don't know whether this is a cause or symptom, but it spat out exactly at the time the debugger became unresponsive. The record-to generated a lot of other files so I'll run through them and see whether there's anything useful in there around the same time.

The only log that has timestamps in the bugreport folder does not have anything interesting around the same time (note: timestamps are 1hr out) is this:
06-18 10:40:39.000 V/DownloadManager( 2473): Deleting /data/data/com.android.providers.downloads/cache/libAppDataSearchExt_x86.v7-1.so via provider delete
06-18 10:40:40.774 I/Dialer  ( 2443): OmtpVvmCarrierCfgHlpr - OmtpEvent:CONFIG_STATUS_SMS_TIME_OUT
06-18 10:40:40.775 I/Dialer  ( 2443): RetryPolicy - discarding deferred status: configuration_state=4
06-18 10:40:40.776 I/Dialer  ( 2443): VvmTaskExecutor - no more tasks, stopping service if no task are added in 5000 millis
06-18 10:40:40.780 I/Dialer  ( 2443): VvmTaskReceiver - task received
06-18 10:40:40.781 I/Dialer  ( 2443): VvmTaskReceiver - TaskExecutor already running
06-18 10:40:40.782 I/Dialer  ( 2443): Task.createTask - create task:com.android.voicemail.impl.ActivationTask
06-18 10:40:40.782 I/Dialer  ( 2443): RetryPolicy - retry #1 for com.android.voicemail.impl.ActivationTask@2d0dc22 queued, executing in 5000
06-18 10:40:40.782 I/Dialer  ( 2443): VvmTaskExecutor - com.android.voicemail.impl.ActivationTask@2d0dc22 added
06-18 10:40:40.782 I/Dialer  ( 2443): VvmTaskExecutor - minimal wait time:4999
06-18 10:40:40.783 I/Dialer  ( 2443): VvmTaskExecutor - sleep for 4999 millis
06-18 10:40:43.099 I/ActivityManager( 1467): Killing 3641:com.google.android.talk/u0a54 (adj 906): empty #17
06-18 10:40:45.787 I/Dialer  ( 2443): VvmTaskExecutor - executing task com.android.voicemail.impl.ActivationTask@2d0dc22
06-18 10:40:45.788 I/Dialer  ( 2443): PreOMigrationHandler - ComponentInfo{com.android.phone/com.android.services.telephony.TelephonyConnectionService}, [e2f7d48dd2b5ca523e7313cf4ba0f6ea830b6281], UserHandle{0} already migrated
06-18 10:40:45.827 I/Dialer  ( 2443): VvmActivationTask - VVM content provider configured - vvm_type_cvvm
06-18 10:40:45.828 I/Dialer  ( 2443): OmtpVvmCarrierCfgHlpr - OmtpEvent:CONFIG_ACTIVATING
06-18 10:40:45.852 I/Dialer  ( 2443): TelephonyMangerCompat.setVisualVoicemailSmsFilterSettings - using TelephonyManager
06-18 10:40:45.855 I/Dialer  ( 2443): TelephonyMangerCompat.sendVisualVoicemailSms - using TelephonyManager

It seems unrelated (it's all marked Dialer), yet it seems a huge coincidence that this line is literally at the same second that the debugger went tits:
06-18 10:40:43.099 I/ActivityManager( 1467): Killing 3641:com.google.android.talk/u0a54 (adj 906): empty #17

Something is being killed at the time Observatory becomes unresponsive?

Just reset and did the same thing again.
[11:51:41 AM]: <== [     +532 ms] DevFS: Starting sync from Instance of 'RecordingDirectory'
[11:51:41 AM]: <== [            ] Scanning project files
[11:51:41 AM]: <== [       +9 ms] Scanning package files
[11:51:41 AM]: <== [      +91 ms] Scanning asset files
[11:51:41 AM]: <== [            ] Scanning for deleted files
[11:51:41 AM]: <== [      +50 ms] Updating files

// Debugger became unresponsive here (literally as the below text was output)

[11:51:46 AM]: <== [    +5773 ms] DevFS: Sync finished
[11:51:46 AM]: <== [{"event":"app.progress","params":{"appId":"24e5ce7a-27b1-4200-b6f0-bbe3c3456018","id":"1","progressId":null,"finished":true}}]
[11:51:46 AM]: <== [            ] Synced 6.1MB.

This time there was nothing at this time in the other log (there was a line about killing a talk process, but it was over ten seconds earlier) so probably that line it was just a big coincidence!

Ok, I can perfectly reproduce this in a script without Dart Code. I send a Step over 300ms after every time we pause and it just fails to get responses after a certain amount of time (if I reduce the 300ms there will be more successful steps before it hangs).

main.ts
I don't think I can progress this any more; if I'm doing something wrong then I need some assistance in knowing what.

Could it be the same as this raised by @jensjoha?
https://github.com/dart-lang/sdk/issues/29568

So it seems that it gets stuck after approximately 7 and a half seconds, after which is does nothing.

Thank you for the Script.
We are finally able to reproduce it on out workstations.
In your example you start interacting with the service protocol when you capture the app.debugPort event from the flutter CLI.
If you wait the app.started event instead everything should work fine.

Thank you for the Script.
We are finally able to reproduce it on out workstations.

Excellent! I probably should've done that sooner =D

If you wait the app.started event instead everything should work fine.

I actually thought I changed to app.started to test that earlier but got the same results; though I'll try that again today if I get chance in case I overlooked something. I'll post back with the results.
Is this still something you'd consider a bug and fix? It seems to work and still steps, suggesting that everything was ready. It seems weird to work for a while and then become broken, if you connected too early? (It even provides the script name etc. back in the rootLib section suggesting it's all loaded).

I can't figure out what I did wrong yesterday, because using app.started appears to be working fine today!
So, this totally solves my issue; however this does still feel like a bug that should be fixed (and maybe dart-lang/sdk#29568 is similar issue?). I wonder whether a simple fix would be not to send debugPort until immediately before app.started (or move wsUri on to app.started) so that it's not possible for someone to do this incorrectly? Obviously I don't know the internals; this might not make sense.
Thanks for the help anyway; very happy to have this working! :-)

Thanks very, very much @DanTup for all time spent on this; very happy to hear you have it working!
I'll let the VM folks answer your 'feel like a bug' comment (but I agree that it would be better to fail explicitly or make it work).

@DanTup we sent you this information to allow you to continue the development and testing of Dart Code.
We are still actively working on it to understand the origin of the problem, fix it or prevent it.

Sure; my comment was as much a question than a statement. I appreciate the help! 👍

We are working on a fix inside https://github.com/flutter/engine/pull/3833

@B3rn475 that issue description suggests this only occurs during a hot reload, but in this case there was no hot reload involved?

@DanTup they are the symptoms of the same race condition.
Your were starting debugging before some procedures, that are in common between HotReload and Start-Up, were completed.

@B3rn475 Great, thanks for confirming!
I subscribed to that case so you're free to close this as a dupe if you don't wish to have both open.

Oops, that's a PR not an issue, nevermind!

Fixed in flutter/engine#3833


feature request to work with recycleview

do you plan to make it available for the extension of recycleview?

I think that there are already libraries for that - https://github.com/kanytu/android-parallax-recyclerview
Please tell me if its working for you.


Fiddler no longer finds the API token for Tidal

It's not present at all. Even after following the instructions here:
https://openbase.com/js/tidalapi/documentation

Nevermind, after about 90 minutes of trying it out. I finally got the token for desktop.tidal.com... I had to basically attempt to play songs and log in and out multiple times but finally I found in Fiddler.


more verbose error message

Because "root of a project" was a little unclear to me.
cc @eseidel

How about, "This command should be run from the root of your Flutter project." (changed "a" to "your".)
Also, I believe it's eventually supposed to be work to update the Flutter directories (especially the samples) by running flutter upgrade at the root of the flutter tree. This was not working when I tried earlier this week. The workaround is to run dev/update_packages.dart.

see issue #339

Thanks @Hixie . ptal

I would probably output the last sentence only if we detected that that's what had happened somehow, and otherwise would say "The current directory does not have a pubspec.yaml file." instead.
But either way, LGTM.

Agreed, we could do more detection here.


restic-browser: init at 0.3.1

https://github.com/emuell/restic-browser
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 348387 run on x86_64-linux 1

1 package built:

restic-browser

the package builds for me, tho on run-time i still get:
ac: Unknown GPU, using 0 for raster_config
Cannot find target for triple amdgcn-- Unable to find target for this triple (no targets are registered)
[1]    1672486 segmentation fault (core dumped)  results/restic-browser/bin/restic-browser --help

hm, still getting the same thing on run-time, so i wonder if that's on me.
fwiw, lshw describes my GPU as follows (as the error mentioned that):
           *-display
                product: amdgpudrmfb
                physical id: 0
                bus info: pci@0000:04:00.0
                logical name: /dev/fb0
                version: c5
                width: 64 bits
                clock: 33MHz
                capabilities: bus_master cap_list fb
                configuration: depth=32 driver=amdgpu latency=0 resolution=1920,1200
                resources: iomemory:fc0-fbf iomemory:fc0-fbf irq:48 memory:fce0000000-fcefffffff memory:fcf0000000-fcf01fffff ioport:1000(size=256) memory:d0300000-d037ffff

Looks like #343806? Do you have this issue in any other tauri/electron/chromium apps?
Current commit works fine for me on my rdna3 amd gpu

that seems my issue yes. i could retry once 24.11 hits and i've caught up on mesa versions, tho hopefully someone else can test before.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 348387

x86_64-linux

:white_check_mark: 1 package built:

restic-browser

thanks! it looks like it's working well for me now :)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/2161


Update shape under paddle api paddle

Update shape under paddle api paddle

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: JZ-LIANG:x: rootroot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Receiving via LNURL link is not working

When we tried to scan the lnurl QR code from the Phoenix wallet's Recieve via lnurl's link, it always said "Error Processing Lnurl" We tried with another wallet and it is working there.
In further debugging we found this error in our Lnd node:- "2024-07-19 14:20:40.164 [INF] CRTR: Payment 45cce64e133ce96c06d1ffd58b357c7a89a786109db0e94426d67fa8d1b4c682 failed: final_outcome=error, raw_err=InvalidOnionPayload(type=0, offset=0)@2"
So, please check this issue and let me know if needed further information.

In Phoenix, are you able to reach the step where you have scanned the LNURL-withdraw code, reached the screen with the withdrawals details (including the amount), and triggered the withdrawal? If not, then check the LNURL withdraw code you've generated is valid with https://lightningdecoder.com/.
The error in your LND node seems related to a payment attempt. If it's related to the withdrawal, then it means you have successfully completed the lnurl-withdraw flow, and are now in the final payment step which is just a regular LN payment. If so, it's likely a problem in LND.


[Bug] Bot applies account warning when encountering objectionable content

Last week I noticed that all of INPC's posts were being flagged by the Tagr Bot and then then yesterday I noticed the same issue happening for https://njump.me/note15tw0pr35wt6umuhgs7ptt2ywtzq42hhdtyh6xjk3fv9550jgt2ysv6p7az - posts.
Steps to reproduce:

Follow the tagr-bot and use Nos
Follow a test account
Log into another app with the test account
Post objectionable content to the test account
Post 3-5 other bland posts with no objectionable content.
Return to your original account and scroll through your feed.
Issue: all posts by the test account will have a label that the account itself is causing harassment. Instead of flagging the individual post.

See these slack threads for examples:
https://planetary-app.slack.com/archives/C041FUVEHJ6/p1723722558635889
https://planetary-app.slack.com/archives/C041FUVEHJ6/p1723317658852099

@setch-l I'm also not able to reproduce this. Are you? I think we need to catch this again and gather more data. If you can export the database from the Settings screen before the app relaunches and export the logs then I think we'll have enough info to fix this.
I looked through the code as well and couldn't spot any issues. I have opened a small PR to add some logging here. But I think we should add a blocked label to this ticket until we get more data and send it to the backlog.

@mplorentz @dcadenas - maybe it is contextually aware but I can't even get the tagr-bot to tag posts that are offensive. you can see all of the posts that I posted on this npub: npub1pakthrykgnpcw5zwf7glhffs3mun9kfngymwwh3lgshzxxk4nn8qewdysx
I followed tagr-bot after posting some of them. And then posted some more and the tagr-bot is not catching any of them. I follow the tagr-bot.
So no I can't reproduce but I think it's bc the tagr-bot is not working immediately. Perhaps there is a delay and if you look at these posts later today they will be tagged.
The thing I'm looking for on the posts is: Did the bot tag for a content warning or a user warning. The bug is for a user warning. And I don't think that is accurate.

@setch-l I think Tagr-bot is only guaranteed to look at notes mentioning other Nos users (who have opted into push notifications), so you may try mentioning your main account?
I agree with Daniel that this looks like an iOS display bug. I don't think Tagr is actually publishing labels for the whole account. I think Nos is mistakenly saying that it did.

@dcadenas @mplorentz - My understanding of Tagr-bot is that it tags everything of the people you follow that is offensive. It's not limited to mentions or replies. But let me know if I'm incorrect.

@setch-l The content that is automatically analyzed comes from a single source, which is determined by the filters set up in the notifications service. These filters only listen to notes in which Nos users were tagged.
So, it's not analyzing everything posted on the network. The code does not include any logic to automatically flag accounts, so a bug related to this is not possible. Accounts can only be flagged manually, either through the Slack-based interaction or via the public flagging button.

@setch-l I'm referring to this comment.
I’m talking about tagging from the event's perspective, where tags are used to attach metadata. Specifically, when a user replies to another, the event in the thread should include the p pubkey tag to identify the user being replied to. We filter only by those in the notification service here:
https://github.com/planetary-social/nos-notification-service-go/blob/e26e9c8b96dd24243765f417c287bfd267ddd377/service/app/downloader.go#L393-L413
I traced this decision to this PR which mentions high firestore usage which I assume would also be happening if we expanded the filter to all the network.
This may be a good reason to rewrite the service or refactor the need of firestore

@dcadenas - Thanks for sharing this. And yes I agree we need to re-write this service. It's way too confusing now and I'm not sure how much value it is providing in it's current state as Matt noted in his later comments in Notion (which I missed).

@mplorentz @dcadenas - I tracked down an example of Tagr-bot flagging a user.
Here's the note id: note1wdd26ptwrpls8y8z8ad9ym6vgwmextnnw87v5wjnrur5s75k9xnsau5pvx
Here's the npub: npub1mxq4j8sw5c2nhp58k2hdvu9t0kdkcwksrz3kpv5zpv70pa7q4cmsqgfcal
Here's a screenshot of the ovelay


Unable to download XML: HTTP Error 403: Forbidden (caused by HTTPError())

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.08.04. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ ] I've verified and I assure that I'm running youtube-dl 2018.08.04

Before submitting an issue make sure you have:

[ ] At least skimmed through the README, most notably the FAQ and BUGS sections
[ ] Searched the bugtracker for similar issues including closed ones
[ ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2018.08.04
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
I can't download video files  from bbc iplayer anymore. I'm using ExpressVPN. I can still watch video in iplayer directly though.
Here is the output:
youtube-dl --verbose https://www.bbc.co.uk/iplayer/episode/b0bgb0dm/red-rock-series-3-episode-20
[debug] System config: [u'-f', u'best', u'--write-sub', u'--convert-subs', u'srt', u'--embed-subs', u'--prefer-ffmpeg']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://www.bbc.co.uk/iplayer/episode/b0bgb0dm/red-rock-series-3-episode-20']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.08.04
[debug] Python version 2.7.13 (CPython) - Linux-4.10.0-42-generic-x86_64-with-Ubuntu-17.04-zesty
[debug] exe versions: ffmpeg 3.2.4-1build2, ffprobe 3.2.4-1build2, rtmpdump 2.4
[debug] Proxy map: {}
[bbc.co.uk] b0bgb0dm: Downloading video page
[bbc.co.uk] b0bgb0dm: Downloading playlist JSON
[bbc.co.uk] b0bgb0c3: Downloading media selection XML
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b0bgb0c3: Downloading MPD manifest
WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden
[bbc.co.uk] b0bgb0c3: Downloading MPD manifest
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 503: Service Temporarily Unavailable
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 503: Service Temporarily Unavailable
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b0bgb0c3: Downloading MPD manifest
WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden
[bbc.co.uk] b0bgb0c3: Downloading MPD manifest
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: <urlopen error [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:661)>
[bbc.co.uk] b0bgb0c3: Downloading m3u8 information
WARNING: Failed to download m3u8 information: <urlopen error [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:661)>
[bbc.co.uk] b0bgb0c3: Downloading captions
[bbc.co.uk] b0bgb0c3: Downloading captions
ERROR: Unable to download XML: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 599, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2211, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 435, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 473, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

Hi,
I have updated the youtube-dl to todays edition, but I am still getting the same error. Here is the output:
kostas@kostas-SIPrecision:~$ youtube-dl --verbose https://www.bbc.co.uk/iplayer/episode/b094d490/swallows-and-amazons
[debug] System config: [u'-f', u'best', u'--write-sub', u'--convert-subs', u'srt', u'--embed-subs', u'--prefer-ffmpeg']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://www.bbc.co.uk/iplayer/episode/b094d490/swallows-and-amazons']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.08.22
[debug] Python version 2.7.13 (CPython) - Linux-4.10.0-42-generic-x86_64-with-Ubuntu-17.04-zesty
[debug] exe versions: ffmpeg 3.2.4-1build2, ffprobe 3.2.4-1build2, rtmpdump 2.4
[debug] Proxy map: {}
[bbc.co.uk] b094d490: Downloading video page
[bbc.co.uk] b094d490: Downloading playlist JSON
[bbc.co.uk] b088p8ld: Downloading media selection XML
[bbc.co.uk] b088p8ld: Downloading captions
[bbc.co.uk] b088p8ld: Downloading captions
ERROR: Unable to download XML: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 599, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2211, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 435, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 473, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)


[Alerts][pcsup-21253]Add maximum value accepted for alert triggering

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--prisma-cloud-docs--hlxsites.hlx.page/
After: https://main--prisma-cloud-docs--hlxsites.hlx.page/
Worker: https://prisma-cloud-docs-production.adobeaem.workers.dev/?branch=pcsup-21253

Note update signed-off by Vinay Kumar M on PCSUP-21253


Improve frontend build

The frontend build takes ages.
Adding issue not to forget.

Some perhaps helpful references: https://github.com/babel/babel-loader#babel-loader-is-slow

This seems to have been fixed magically with the latest release. 😄


Versioning on the website is broken

Cache issue, will probably resolve itself.

I mean, it's also broken in private mode 🤔

If you disable cache and reload it works again: (bottom right checkbox)

🤔

Yeah, that works. Also nice to know that exists.

I've purged the cache via the Cloudflare dashboard. It seems to work now, even in a Firefox private window.


Critical projects list list

Add a file that links off to relevant information on identifying critical projects

Seem okay to merge?
@dlorenc - note that this points to the Open Source Project Criticality Score program

Ha! When I first read "list list" I thought it was a typo. But then I looked and it's accurate :)


Organization secret scanning setting not available

What article on docs.github.com is affected?
Managing secret scanning for your organization
What part(s) of the article would you like to see updated?
Note: Secret scanning for private repositories is currently in beta and subject to change.

This setting is not present in our organization settings. Does beta mean this feature is not available to all organizations?

Hi @PatMyron - thanks for getting in touch.
Secret scanning is only available in public repositories, and in private repositories owned by organizations with an Advanced Security license. The Secret scanning controls should be displayed on the Security & analysis page for your organization if you have public repositories, or you have private repositories and you have an Advanced Security license.
I don't have access to your organization settings (linked above). Could you provide a little more information about whether you have public repos or an Advanced Security license? Thanks.

Hi @PatMyron - thanks for getting in touch.
Secret scanning is only available in public repositories, and in private repositories owned by organizations with an Advanced Security license. The Secret scanning controls should be displayed on the Security & analysis page for your organization if you have public repositories, or you have private repositories and you have an Advanced Security license.
I don't have access to your organization settings (linked above). Could you provide a little more information about whether you have public repos or an Advanced Security license? Thanks.


Replacing validate_evacuate method by supports :evacuate

Purpose or Intent
This pull request intends to remove the usage of validate_evacuate method and replaces it by the new method supports_evacuate which is supported by SupportsFeatureMixin.
This is in continuation with PR: https://github.com/ManageIQ/manageiq/pull/9683
The original method validate_evacuate is kept as it is for backward compatibility of code, but the body of the function internally relies on supports_evacuate method.
Steps for Testing/QA
Below are the outputs from relevant Rspec tests.
bundle exec rspec spec/models/manageiq/providers/openstack/cloud_manager/vm_spec.rb
Randomized with seed 18019
.........................
Finished in 2.56 seconds (files took 5.79 seconds to load)
25 examples, 0 failures
Randomized with seed 18019
bundle exec rspec spec/models/vm_or_template_spec.rb
Randomized with seed 52558
..............................................................................
Finished in 6.32 seconds (files took 5.68 seconds to load)
78 examples, 0 failures
Randomized with seed 52558

Updated PR with review changes and didn't find any other instances making old method calls (validate_evacuate).

Changed old comments to denote new method call.

Put more elaborate titles for rspec tests.

@durandom any way to trigger the travis again? Seems like non-code specific issue.

any way to trigger the travis again? Seems like non-code specific issue.

yes. close/reopen the PR or push to the branch (this can be an empty amend commit)

@gauravaradhye try to reproduce this CI failure locally. Maybe rebasing your PR on current master helps

The travis failure is because of an issue unrelated to this PR. I can see some other builds failing because of the same issue.

The travis failure is because of an issue unrelated to this PR. I can see some other builds failing because of the same issue. I am hitting some issues trying to run the tests locally.

but when I run the failed spec on master it does not fail, so it's a problem with this PR

The travis failure is because of an issue unrelated to this PR. I can see some other builds failing because of the same issue. I am hitting some issues trying to run the tests locally.

This seems to be fixed just now :)
https://github.com/ManageIQ/manageiq/commit/495795c8f0f0fee5aa4b0c67011e034cc1c61245

@durandom Passed now on travis, have also rebased with latest master.

@gauravaradhye coming close :+1:
I think you are close to the :checkered_flag:

@durandom Included both the changes mentioned above, tests passed locally, waiting for travis to confirm.

@miq-bot add_label darga/no
@Fryguy @chessbyte this is good to go! Final review and merge?

Rebased with latest master.

@gauravaradhye great!
@chessbyte good to go :+1: merge?

Rebased with latest master.


New version: JetBrains.YouTrack version 22.3.65372

Result: Installation Failed

Manifest
Add/Remove Programs

Name
JetBrains YouTrack

Version
22.3.65372

Publisher
JetBrains

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 6183
Microsoft Reviewers: Open in CodeFlow

Modifies Tools/Arp-Difference.json.


fix: All property control renders when JS toggle button is clicked

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes #11040

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=e283504

/ok-to-test sha=9b741ed

/ok-to-test sha=1a0cbc4

/perf-test sha=7b52c7d

@aswathkk , any performance numbers?

@SatishGandham I found the scripting time reduced from ~50ms to ~25ms after clicking on the JS toggle.

/ok-to-test sha=ab2b231

/ok-to-test sha=ab2b231

/perf-test sha=ab2b231

/ok-to-test sha=824cdd1

/perf-test sha=ab2b231

/perf-test sha=ab2b231


Allow using '%' character for linkifier urls.

https://chat.zulip.org/#narrow/stream/19-documentation/topic/linkifier/near/967173
We cannot use the % character in linkifier format strings currently. We should either document this or fix this.
Example: https://trac.example.com/epic/%(num)s/hello%25world is an invalid format string.

I also can't use a literal @ character. This makes URLs with an @ in them impossible to output from a linkifier, which basically makes it impossible to linkify URLs of the form https://observablehq.com/@jrus/sinebar.

I also can't use a literal @ character. This makes URLs with an @ in them impossible to output from a linkifier, which basically makes it impossible to linkify URLs of the form https://observablehq.com/@jrus/sinebar.

Here is the spec: https://url.spec.whatwg.org

The URL code points are ASCII alphanumeric, U+0021 (!), U+0024 ($), U+0026 (&), U+0027 ('), U+0028 LEFT PARENTHESIS, U+0029 RIGHT PARENTHESIS, U+002A (*), U+002B (+), U+002C (,), U+002D (-), U+002E (.), U+002F (/), U+003A (:), U+003B (;), U+003D (=), U+003F (?), U+0040 (@), U+005F (_), U+007E (~), and code points in the range U+00A0 to U+10FFFD, inclusive, excluding surrogates and noncharacters.

The fragment percent-encode set is the C0 control percent-encode set and U+0020 SPACE, U+0022 ("), U+003C (<), U+003E (>), and U+0060 (`).

The query percent-encode set is the C0 control percent-encode set and U+0020 SPACE, U+0022 ("), U+0023 (#), U+003C (<), and U+003E (>).

Whereas the current validator supports only: [/a-zA-Z0-9#_?=&;~-]*, which does not match the above.
https://github.com/zulip/zulip/blob/master/zerver/models.py#L751-L769

Perhaps [/a-zA-Z0-9#_?=&;~-]* could be changed to [-!$&'()*+,./:;=?@_~\w"#<>`]* or the like.

Here is the spec: https://url.spec.whatwg.org

The URL code points are ASCII alphanumeric, U+0021 (!), U+0024 ($), U+0026 (&), U+0027 ('), U+0028 LEFT PARENTHESIS, U+0029 RIGHT PARENTHESIS, U+002A (*), U+002B (+), U+002C (,), U+002D (-), U+002E (.), U+002F (/), U+003A (:), U+003B (;), U+003D (=), U+003F (?), U+0040 (@), U+005F (_), U+007E (~), and code points in the range U+00A0 to U+10FFFD, inclusive, excluding surrogates and noncharacters.

The fragment percent-encode set is the C0 control percent-encode set and U+0020 SPACE, U+0022 ("), U+003C (<), U+003E (>), and U+0060 (`).

The query percent-encode set is the C0 control percent-encode set and U+0020 SPACE, U+0022 ("), U+0023 (#), U+003C (<), and U+003E (>).

Whereas the current validator supports only: [/a-zA-Z0-9#_?=&;~-]*, which does not match the above.
https://github.com/zulip/zulip/blob/master/zerver/models.py#L751-L769

Perhaps [/a-zA-Z0-9#_?=&;~-]* could be changed to [-!$&'()*+,./:;=?@_~\w"#<>`]* or the like.

I've encountered the same issue with bang (!) characters, which are used in Icinga2 resource URLs. I don't understand why a second validation is needed when the URL submitted is already run through the standard URLValidator. Many valid characters are needlessly blocked...

Another requested character is .: https://chat.zulip.org/#narrow/stream/9-issues/topic/linkifier.20with.20period/near/1264973
(Though I agree with @jcharaoui that we probably shouldn't be applying a regex like this at all.)


age gate screen

Issue: https://github.com/project-vagabond/covid-green-app/issues/483
Updates to https://github.com/project-vagabond/covid-green-app/pull/494

Looks good just one issue I mentioned on Slack last night that the accessibiliy focus seems to no longer work. On Android 9 it focuses nothing, on Android 6 it focuses the image, so I guess the accessibility focus is happening too soon before the image is fully registered and that is causing the text to lose focus?
useFocusRef({timeout: 1000}) works on both my Android devices so maybe go with 1250 just to be sure.
Also, I didn't spend much time on adding the focus ref before handing over, do you think it's the best approach? Might it be better to focus on the button and use the "I am over 18 or..." text as the button's accessibility label and "I consent" as the hint, with the text block ignored by screen readers?

@AlanSl The good thing is that it works on iOS (not that it would matter a lot). We can go with any timeout value here (i'll do 1250) as it doesn't matter the only thing i'm worried about if for the focus not to be set automatically on a certain element and then we focus on the text - actually that's fine, not ideal but fine.
On the 2nd part: it's ok to focus the text only, they'll discover the button (with a role) after.


Debug github actions

Description

github actions were not triggered this aims to fix that
Related issues

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Changes Made

fixes github actions syntax to adhered to git hooks
updated a package with npm audit fix

Testing

[x] Tests do not apply

Mentions

Thanks! I'll rebase this to base branch and add some typo fixes.


Prevent invalid characteristic values

Characteristics have a specific type (string, float, ...) and may have a min and max. We should prevent invalid values; e.g. 24 for values which have a max of 20.

Fixed with commit 613373b


Add Hypercomments system.

Add support for Hypercomments system instead of Disqus.
Hypercomments support

Anonymous comments.
Inline comments like Duoshuo (u can select any text and make comment for this text).
Share selected text with title in social (Facebook, Twitter, VK).
Copy quotes (when u copy selected text from site it will appear at quotes tab in comments).
Stereocommets (mode with moderators’ avatars/mode with company logo)
Categories (will help users to add a comment to the appropriate section e.g.'Сriticism', 'Reference', 'Request' etc.).
Emoji in comments. :relieved:
Real-time online post views.
Real-time moderation.

U can see and test live demo of hypercomments here.

Thanks. :+1:

赞，现在多说已经太不靠谱了。

这个跟disqus比起来怎么样呢？希望比较稳定

试了试，好用

能否支持简体中文？为何显示的是繁体中文。。
can it support Chinese Simplified? i don't understand why it use Chinese Simplified ....and i can't find where set.

@Keldos-Li this is 3rd party service. All langs loading from HC server, so, need to ask it on they site, not here.

这个好用，但是，要是有简体中文就更好了，真是忧伤~~

can it support Chinese Simplified? i don't understand why it uses Chinese Simplified ....and i can't find where set.
I ask about Chinese language to HC maintainers and he's said Chinese language is supported. As i understand, Chinese and Chinese Simplified - are not the same and they not support Chinese Simplified, but support Chinese right? I can talk him again about this. Also, if anybody can help with translate HC into Chinese Simplified, we may give this translate to him.

Thanks


Fix can't find Subscription from SubscriptionPayment

I want to listen to the SubscriptionPaymentSuccess, SubscriptionPaymentFailed, and SubscriptionPaymentRecovered events. Still, it does not work, the $this->findSubscription($payload['data']['id']) always returns null, then I look at my webhooks records and see the SubscriptionPaymentSuccess event's data.attributes.subscription_id same as my database's Subscription lemon_squeezy_id, so this PR is to fix this.
Reference
The SubscriptionPaymentSuccess, SubscriptionPaymentFailed and SubscriptionPaymentRecovered events both are Subscription Invoice object in Webhooks Event types:

And trace to Subscription Invoice object has the subscription_id field:

Good find! Thanks. I'll tag this now.


Rendering problems with CustomCellTypeDefinitions in newest version

Thank you for your great work! I just updated to the latest version which resolves issues regarding scrolling and adds the feature for frozen rows/cols.
Unfortunately I noticed that the custom view/editor rendering using CustomCellTypeDefinitions isn't working correctly anymore. It's even not rendered at all when the cell is in the frozen area.
Can you please check?

Hi @audacity76 yes you are correct and it can even be seen on the example site. I'll look into this.


Source code for the model

Hi,
Just curious: will Stability release the source code that was used to build the model? I know without weights/training set that source won't be of much use, but I would still like to see the source code so that we know what's under the hood.
Thanks,
Vivek

Based on their config files and the fact they use the GPT-NeoX architecture I'd bet they trained using EleutherAI's gpt-neox repo. It's possible they used their own fork of it as well.


THRIFT-3885 PHP: Error when readI64 in TCompactProtocol

fix bug when readI64 in TCompactProtocol of php.
see https://issues.apache.org/jira/browse/THRIFT-3885

Please create an Apache Jira ticket in the THRIFT project to cover the defect, and put a link to the pull request in there.  In the future if you open a ticket first and put the name of the Jira item (like THRIFT-3855) into the pull request comments, it will get linked to the Jira ticket automatically.

I'm also wondering if this was causing any "make cross" errors that have been ignored and whether we can re-enable some of those tests.

I believe this is duplicate of THRIFT-3827 (#1008) and the correct fix is there too.
As PHP cross test has been useless, I'm verifying the fix in THRIFT-3886 (#1054).

@nsuke Yes, I agree.
It also can simply be $hi |= (($byte & 0x7f) >> 4); because of the shift is only 28 that satisfy the condition.
But according to the algorithm of writeVarint, I think
elseif ($shift > 25) {   $hi |= (($byte & 0x7f) >> (32 - $shift)); }
to be the best.
(When the shift is 25, the 7 bit only fill in the low 32bits. so the condition should be $shift > 25.)
Thanks for reading.

// Shift hi and lo together.
if ($shift < 28) {
  $lo |= (($byte & 0x7f) << $shift);
} elseif ($shift == 28) {
  $lo |= (($byte & 0x0f) << 28);
  $hi |= (($byte & 0x70) >> 4);
} else {
  $hi |= (($byte & 0x7f) << ($shift - 32));
}

@czm1989 @lnn1123 Thought ?
Otherwise I'd apply @lnn1123 's patch but keeping > 25.

Also I noticed that if (true) part below inside the existing function seems completely redundant.
else code even uses different set of variables.
We can clean it up without losing any value, right ?


SuSE: README

In addition to the already available documentation SuSE recommended to add a README file which contains information with links to the existing documentation. In particular how a user can identify a good use-case, and what to do if the performance is not as expected. The README should also contain a reference to the document describing which functions are supported and which not.

I think the CAPI User's guide very nicely reflects how the code should be used.


Operator microservice headers missing

Setup:
We have a Hugo site hosted on Netlify here - https://www.stardog.com/
CMS works as expected.
We have added a subsite called Stardog Labs:
It's on Netlify here - https://stardog-labs.netlify.app/
On the main site _redirects file we are doing a reverse proxy
/labs/* https://stardog-labs.netlify.app/:splat 200!
This allows for our Labs subsite to render as expected here -
https://www.stardog.com/labs/
Goal:
We can continue to access the Labs CMS admin portal here https://stardog-labs.netlify.app/admin/
We would like to to access here - https://www.stardog.com/labs/admin/
Problem:
We keep receiving the following errors

Additional setup info
Here is the config.yml setup for the Labs site

Closing questions:
Is there something wrong with our config to allow this to work?
Are we missing a header like the 400 error indicates?

There error is coming from here https://github.com/netlify/git-gateway/blob/a9002bf23ca22242e6959c266ac3a37f30318478/api/middleware.go#L26

@ccampb13, can you share the network traffic after clearing cache/from private mode and include the requests/responses to the identity service (please redact any auth tokens)?

hey @erezrokah here is what I see post clearing cache related to the identity service.

When you click login there should be a request to the identity service settings.
Do you mind sharing that and the entire login flow requests until you get that git/settings one?

Hey @erezrokah here's a recording of the Network requests that I'm seeing. Not seeing any additional requests to the identity service settings.
https://recordit.co/6886WfqM9x

Actually @erezrokah, I cleared my local storage again and have a few extra network requests to show here.

@ccampb13  The identify_url config is ignored when using identity widget to authenticate. To use your  identity_url config option, try logging in without the identity widget by removing the identity script from your index file <script src="https://identity-js.netlify.com/v1/netlify-identity-widget.js"></script> .  You should be presented with simple email and password inputs login.

Awesome, thanks @barthc! That did the trick!
Will we lose any functionality with this setup?

Will we lose any functionality with this setup?

Nope I don't think so.

Will we lose any functionality with this setup?

Nope I don't think so.

sweet. thanks again, @barthc!

Thanks @barthc, I think the CMS should set the identity url for the widget if the scripts exists in that case.
WDYT?
Re-opening so I can investigate further

@erezrokah  we will need to handle setting the URL in the cms code, and also for the  netlify plugin.

Update the description to better reflect the issue.
See workaround https://github.com/netlify/netlify-cms/issues/1027#issuecomment-596603284


Missing template options

Describe the bug
No template content in side bar
Steps To Reproduce
Steps to reproduce the behavior on latest release:

create new page and save it
go back in and no content in templates from side bar

Hi @chrisnewmanuk,
I would assume that no templates have been configured in your system and you also do not have permission to create new templates.

Thanks - got it now!  Hiding in the "admin" permissions :)


Calendar scrolling to wrong month

Here's how to reproduce.

Run example program.
Switch to vertical.
Scroll to March 2015.
Using settings screen, select April 3rd.
Tap on March 31st.

At this time the calendar will move to May instead of March.

Try the new version in master branch

Thanks Wenchao - looks good.
I’d like to submit a couple of “wish list” items.  Should I enter it on github as an “issue” or send it to you as an email?
Thanks,
Bob.
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Apr 7, 2015, at 3:56 AM, Wenchao Ding<EMAIL_ADDRESS>wrote:
Closed #20 https://github.com/f33chobits/FSCalendar/issues/20.
—
Reply to this email directly or view it on GitHub https://github.com/f33chobits/FSCalendar/issues/20#event-274941332.

Hey, Bob:
I can't imagine there could be a 'list'. Are there a list of bugs?
I won't care too much about the way you submit the issues, each of them would be ok. As long as I can control my off hours, I'll fix them one after another

Hi Wenchao -
No, these are not bugs - they’re “wish list” items.  Things that would be helpful to me.

Animate on _fsCalendar.selectedDate when selection causes a change in month.  I've got a button on my toolbar titled “Today”.  It’s kind of jarring when the calendar just changes from one month to the current month without animation.

More delegate methods.  I’d like the ability to override the default colors by date (all of them).

And back to the zig-zag.  It doesn’t really look so good having the dates be different height depending on whether there’s a subtitle.  Can you change the routine so that just the date has the background and the subtitle is always outside the background?  I would be ok doing away with the event indicator if that would make enough room.  Basically working like the Apple iPhone calendar where the dot would be replaced with a subtitle.

I understand that I’m asking you to do quite a bit here.  I’d be happy to pay you for your time.  Just let me know what your rate is and how long these changes would take.  I really like the work you’ve done here Wenchao and am looking forward to incorporating it into my app.
Thanks,
Bob.
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Apr 8, 2015, at 1:37 AM, Wenchao Ding<EMAIL_ADDRESS>wrote:
Hey, Bob:
I can't imagine there could be a 'list'. Are there a list of bugs?
I won't care too much about the way you submit the issues, each of them would be ok. As long as I can control my off hours, I'll fix them one after another
—
Reply to this email directly or view it on GitHub https://github.com/f33chobits/FSCalendar/issues/20#issuecomment-90807005.

Hey Wenchao -
One other thing.  I’m getting this warning in fscalendarcell.  Is this a bug?
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Apr 8, 2015, at 1:37 AM, Wenchao Ding<EMAIL_ADDRESS>wrote:
Hey, Bob:
I can't imagine there could be a 'list'. Are there a list of bugs?
I won't care too much about the way you submit the issues, each of them would be ok. As long as I can control my off hours, I'll fix them one after another
—
Reply to this email directly or view it on GitHub https://github.com/f33chobits/FSCalendar/issues/20#issuecomment-90807005.

It indeed needs more customization.
Let's talk via skype. My ID is "wenchao.ding", no quotes

Hi Wenchao - where do you live - more importantly what time zone?  I’m in New York.  Actually going to sleep now.  When you tell me where you are we can schedule a Skype call.
Thanks,
Bob.
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Apr 8, 2015, at 9:57 PM, Wenchao Ding<EMAIL_ADDRESS>wrote:
It indeed needs more customization.
Let's talk via skype. My ID is "wenchao.ding", no quotes
—
Reply to this email directly or view it on GitHub https://github.com/f33chobits/FSCalendar/issues/20#issuecomment-91089373.

I'm in Beijing, China.

OK - so you’re 12 hours ahead of me.
I’m available to talk anytime between 10am and 10pm New York time.  Let me know what works for you and I’ll contact you via Skype.
Thanks,
Bob.
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Apr 8, 2015, at 10:15 PM, Wenchao Ding<EMAIL_ADDRESS>wrote:
I'm in Beijing, China.
—
Reply to this email directly or view it on GitHub https://github.com/f33chobits/FSCalendar/issues/20#issuecomment-91092877.

As for the email I just sent.  Today I won’t be available until 2pm New York time (about 3 hours from now).
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Apr 8, 2015, at 10:15 PM, Wenchao Ding<EMAIL_ADDRESS>wrote:
I'm in Beijing, China.
—
Reply to this email directly or view it on GitHub https://github.com/f33chobits/FSCalendar/issues/20#issuecomment-91092877.

9pm at New York time would be ok. It should be 9 am in Beijing time

Great. I'll call you then.
Sent from my iPhone

On Apr 9, 2015, at 7:39 PM, Wenchao Ding<EMAIL_ADDRESS>wrote:
9pm at New York time would be ok. It should be 9 am in Beijing time
—
Reply to this email directly or view it on GitHub.


add error for import statement after other top level decl

[ ] ~error when import statement isn't the first top level decl in a file (except for root export decl and other import statements)~
[ ] ~error for redundant import statements~

After more consideration, I think that both of these ideas are out of line with Zig's design. One example is that it is perfectly possible to something like:
const foo = getTheImport(some_param);

fn getTheImport(a: bool) {
    return if (a) @import("foo") else @import("bar");
}


Add integration test cases for checking the behavior of generated code

This test cases are useful for when we are integrating Kotlin base
dispatcher. Does test cases make sure the code we generated are
correctly working. The test cases doesn't care what kind of code we
generate.
Concern

I created test-v13 module but it seems this test case doesn't care v13 or not. We may need to add them to test module.
This is the first time I used Roboletric+PowerMockito. I may not understand them incorrectly. Please check the test cases carefully.

Thanks

Thx! let me take a look.

#340 is blocking this PR.

one more plus, I checked carefully but I can't assure we've covered all test cases in this PR. So it'd be fine to add coverage report service integration to detect uncovered part of code base(of course that's not necessary for this PR!).

we're gonna add Kotlin support how we can test it?

These are the class written in Kotlin

ActivityWithAllAnnotationsKt
FragmentWithAllAnnotationsKt
SupportFragmentWithAllAnnotationsKt

Are you going to change the interface of calling the method? Then, we can change the test cases.

coverage

One big problem is this test cases are testing generated code, not existed code. I have no idea there is a library for that.

Thanks @aurae I renamed them.

https://github.com/hotchemi/PermissionsDispatcher/pull/339#issuecomment-314376678
ic. so let's keep existing test cases and have a Jacoco integration to monitor a coverage!

Is it ready to merge?

Not yet. i will rename file names and squash commits

Renamed Extentions.kt to Extensions.kt and squashed commits.
Now it ready to merge this PR!

@shiraji thx! About Jacoco I'll work on it!