Cleanup props and callbacks for OptionsList

Details
There were a number of minor things I did here, nothing major.

Removed a lot of props that were no longer used
Simplified some of the props (like hideAdditionalOptionStates which was only used along with customIcons so it wasn't necessary)
Changed a lot of callback to follow our standards
Rename a couple props to be more specific

Fixed Issues
This PR is partially for https://github.com/Expensify/Expensify/issues/228943 but is not a full fix. It is just a bunch of cleanup.
Tests
Most of the tests are going to be general regression tests. The best way to test these is to compare them against production for style and general behavior.
Report Participants Page

On a group chat, click the header of the report (where the participants are listed) to view the report participants
Verify users are listed, they are all visually displayed the same, clicking on a row takes you to the user's profile

Report Search Page

Click on the search icon in the left-hand-navigation
Verify that searching for different things shows the proper results. All results should be visually displayed the same

IOU Pages
Split a bill from the floating-action-button:

From the floating-action-button, create a bill split
Enter an amount
Verify that people are listed and there could be two groups: "Recents" and "Contacts"
Verify that all options are styled the same
Verify that the search works
Select a few people and click Next
On the final confirmation page, verify that the people are listed and CANNOT be selected/deselected and they show up in two groups: "Who paid?" and "Who was there?"

Create a split from a group chat:

Go to a group chat
Click the + button in the left side of the comment composer
Enter an amount and click Next
On the final confirmation page, verify that the people are listed and CAN be selected/deselected and they show up in two groups: "Who paid?" and "Who was there?"

IOU Currency Selection

Split a bill with someone
On the step for entering an amount, click on the currency symbol
Verify you can search for different currencies
Verify the currencies are listed properly and all visually displayed the same

Request Money

Click on the floating-action-button and select Request money
Enter an amount
Verify you can search for people and select them then click Next
Verify that the people are listed properly and all visually displayed the same

New Chat Page

Try creating both a new chat and a group chat
Verify that people are listed and there could be two groups: "Recents" and "Contacts"
Verify that searching for different things shows the proper results. All results should be visually displayed the same

Workspace Invite

Go to a workspace settings and go to Manage Members
Click the Invite button
Verify that you can search for users, they are all visually displayed the same, can be selected

[ ] Verify that no errors appear in the JS console

Offline tests
When offline, some of the avatars might only be displayed as a default or blank avatar. This is normal and expected.

QA Steps
Same as all the tests above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/1228807/205716187-f85afe01-f03e-4c68-bcba-6a76f85ec0cd.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/1228807/205718565-132430ab-648f-464e-a9c3-add07a0678c7.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/1228807/205720049-558dccb9-95bb-4a32-8b76-c7ea59deca61.mp4

Desktop

https://user-images.githubusercontent.com/1228807/205720426-53a43975-b42f-455d-aef8-f2c7d0e94331.mp4

iOS

https://user-images.githubusercontent.com/1228807/205719608-4b79dbba-6219-4e73-96d5-379644ffb57b.mp4

Android

https://user-images.githubusercontent.com/1228807/205717707-49ada02d-ff9a-4bbf-b9ad-72bb6dd929bf.mp4

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I think the Tests for IOU Pages are slightly incorrect. I'm not able to select/deselect participants when I make the bill split from the group chat, but I am able to select/deselect when making the bill split from the FAB.
I'm going to resume testing but wanted to mention that.

I'm getting an error when testing this on web.
Warning: Failed prop type: Invalid prop `onConfirmSelection` of type `boolean` supplied to `BaseOptionsSelector`, expected `function`.

Going to try this on main to see if this is caused by this PR.

OK, thanks for the reviews, and I'll look into some of those prop warnings.
Regarding the logic for select/deselect participants, it's a bit murky. I actually have an open PR that flips some of the logic for when participants can be modified. Maybe we should put this PR on HOLD until that is merged so that we are all clear on what the correct logic is? I think that will help me, so I'll go ahead and do that, but let's keep reviewing this.

I'm seeing that we pass an almost identical method to OptionsSelector each time via the onChangeText prop. Do you think it's worth making another pass or a followup PR to reduce some of that repetition?

I thought about this too. The conclusion that I came to is that I couldn't really think of a very good solution. Each of those methods is unique enough and modifies the state of the parent component, so it's not something that could be generalized inside of OptionsList and I don't think it would make sense to move it to a utils file either. The logic that most of those functions use is already in a utils file, so it's been DRYed up quite a bit already.

OK, well... that's been merged already today, so I will go through here and try to clean up the testing steps a little to denote when you should and shouldn't be able to select people

Updated! I fixed the prop warning that Luke found.
I also checked the tests and they did have the right logic, it's just the code hadn't been updated with the correct logic. Now that the other PR was merged, this code has the correct logic, so the tests will be correct for when you can select/deselect people.
I found a bug that the OptionRow wasn't being memo'ed properly. I found this out because it wouldn't let me select/deselect people (so just keep an eye out for that).
Lastly, the warning about the keys in virtualized list, that appears to be unrelated to these changes and it happens from the ReportActionsList in some situations (mostly when you're starting brand new chats). So, I would consider that out-of-scope of this PR to fix, but you can open a new GH for it 👍

I'll resume testing/review this one this evening.

OK done with Web QA and blockers so I'm back on the review for this.

OK! Looking good except for that last thing. Happy to merge as soon as that's taken care of.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I am tagging this PR to highlight an issue fixed here. All conditions in ternary expressions or left-hand operands on conditional renders, should be boolean. This PR is one of the PRs that uses conditional render with string operands, hence I am tagging it here for the contributors to check.
We've also updated the item in the checklist with this PR to avoid this issues in the future.


fix(mount): avoid warning when stubbing

Now that we "properly" register stubs
(see this commit https://github.com/vuejs/vue-test-utils-next/commit/bb8023fc2dd1757f0358d3a8f2967a1064019540),
a bunch of warning are logged by Vue when a test tries to stub an already registered component.
For example, vue-router-mock register RouterView and then stubs it
(see https://github.com/posva/vue-router-mock/blob/v2/src/injections.ts#L37-L41).
So if you use vue-router-mock (or a similar pattern) in your test, Vue logs:
[Vue warn]: Component "RouterView" has already been registered in target app.

because when a component is stubbed, we re-register it in VTU-next, and Vue warns us that it might be a mistake.
This is a quite naive fix, as it removes the already registered component before registering the stub.

Superseeded by #504


Flux 4.0.0 Beta 2 load issue

When loading Flux Beta 2 for 1.15.1, it says your MC mods.toml is missing. I do not believe Beta 1 had this issue.
Forge 30.0.18
MC-1.15.1

There is a small naming mistake made by IDE. I was refactoring "Minecraft-Flux" names to "Flux" (because CurseForge won't allow me to publish mod with "Minecraft" in title). Forge tries to find "flux" mod while "mcflux" was described in mods.toml file.
Fix is coming in the next update. I'm closing this issue manually since i won't publish source code to this repository until Preview Version is complete.


🆕 Software Suggestion | Hetzner

Basic Information
Name: Hetzner Cloud
Category: Providers\Hosting
URL: https://hetzner.[de/com]
Description
Hetzner is a Germany-based cloud hosting service offering VPS, Dedicated Servers, managed hosting, etc. They run off of green energy.
Via privacy badger I have yet to find any trackers on their site and they claim to use Matomo and they allow you to opt out too.
They send the following data to third parties:
Credit Card information
Domain registration
Both are required to handle this software and I think it's reasonable.
Why I am making the suggestion

Hetzner is an outstanding host. I have yet to find one better than it in terms of value and I much appreciate that it's carbon neutral and that it seems to be much more privacy friendly compared to Vultr, DigitalOcean, Azure, GCP, etc.
My connection with the software
I have been actively using Hetzner for around a month now and have multiple friends who endorse it too.

[x] I will keep the issue up-to-date if something I have said changes or I remember a connection with the software.

Hetzner does seem to host a lot of spammers. At least the density of SPAM I find on my mail servers originating from Hetzner IPs does make it unlikely that all of it is from poor victims of intrusion and malware.
If you send an e-Mail to<EMAIL_ADDRESS>providing full details in a professional manner, you will be ignored and directed to using their web form for reporting abuse. That has two major deficiencies:

A reporter is unable to upload a problematic email in .eml format. The website does only accept other formats such as .txt
They claim that they will only respond if you agree to forwarding all details to the customer holding the IP. That may make sense if the customer is an intrusion/malware victim and professional enough to handle this. If the customer is a criminal offender, this is counter productive.

Overall, in my view, this behavior is DISGUSTING and a SHAME. It does not warrant any recommendation of such provider.

I was unaware of that. Thanks for letting me know.


HCA - Please make dcp29 the default production release.

Please make dcp29 the default production release.
Approvals are in this Slack thread.
The release contains 386 datasets. 20 new, 2 re-released, 4 updated.
No datasets were withheld or withdrawn.

dcp29 has been approved for release:  https://humancellatlas.slack.com/archives/C9XD6L0AD/p1687981010768359?thread_ts=1687965154.556919&cid=C9XD6L0AD


Looking Envoy as a daemon set in kubernetes

This is not a issue.
Instead of using multiple envoy as a container in side a PoD, its looks like a anti pattern for container platform specially in kubernetes plarform. Special challenge when we will do scaling of pod.
Why not use Envoy as a daemon set in host & point application to the pod (daemon set)

This happened to come up at GopherCon last month in conversation. @kelseyhightower told me "because security"

So this could be enhancement.

Just to clarify, the sidecar is an anti-pattern or the per node is an anti-pattern?
When scaling a pod, can you detail the challenges that you faced with the per pod sidecar?

My understanding (and previous thoughts) was that a sidecar required for all pods (mainly in the context of a network mesh) was an anti-pattern. One could use a daemon set.
Brendan Burns wrote of the sidecar as a design pattern. https://www.usenix.org/system/files/conference/hotcloud16/hotcloud16_burns.pdf
In terms of security of daemon set vs sidecar...
Imagine I have found an exploit in the container (envoy / lilnkerd). If it's a daemon set, I might be able to analyze all the traffic going through that pod. If it's a sidecar, then I have only compromised my sidecar and should not be able to see what others are doing. Having the sidecar means that we are still using the isolation that containers and private networking provide. If different tenants data or traffic are passing through a shared container, we have a larger security surface.
Looking forward some amount of time, most users shouldn't have to concern themselves with the sidecar. A) it should be light weight like Envoy  B) We can inject it into pods automatically with dynamic values determined form introspection.
https://github.com/kelseyhightower/istio-initializer
(p.s. How are you doing Chris?)

Yes the initializer work should be present for the 0.2 release. This should inject into the pod as tee kube-inject command does today.
I'm not certain on the distinction of a "design pattern" in regards to Istio. I glance over that referenced article section and this basically aligns with how the Envoy proxy is utilized today.
I'm not certain how the per-pod requirement would be an anti-pattern. It feels especially important in the service-mesh use-case. Performance is of paramount importance in Envoy and you want to be sure that the metrics it is exposing per pod are accurate.

Why I am saying as anti-pattern because of scalability point. When scale up pod, inside of pod Envoy pod will be plus one (+1). Which will do same before scale up.

in theory we could support that deployment model but we would need to rework the networking and it has multi-tenancy like issues (where 1 pod may affect the other pods through the shared side car)
I'm tempted to close this but maybe we can leave it open as documentation of "why not"

is envoy as daemon set in kubernetes  not recommended now?


Move to mamba

Mamba is a fully(?) compatible conda replacement, written in C++. It promises to be more performant in solving dependencies and to support multi-threaded downloading.
There is also micromamba, the equivalent to miniconda but being C++ only, it comes without preinstalled Python. However, it is presently still marked as experimental.

Ping @willirath and @kathoef

If I recall correctly, @kathoef is actively using mamba in some of her environments already. I'm using it in managing test envs for, e.g., Xoak. Also, Binder and Pangeo are using Mamba already.
So I'd go for it.

If I recall correctly, @kathoef is actively using mamba in some of her environments already. I'm using it in managing test envs for, e.g., Xoak. Also, Binder and Pangeo are using Mamba already.
So I'd go for it.

Are they also using micromamba?

Binder / Repo2Docker uses only mamba: https://github.com/jupyterhub/repo2docker/blob/b609424f5dacf0a08c3302072b21aed4a9dcbf94/repo2docker/buildpacks/conda/install-miniforge.bash
They've not (yet ?) moved to micromamba, however: https://github.com/jupyterhub/repo2docker/pull/919#issuecomment-661020577

Yes, I am using something like this
RUN wget https://repo.anaconda.com/miniconda/${MINICONDA_VERSION} --quiet --directory-prefix ${HOME} \
 && bash ${HOME}/${MINICONDA_VERSION} -f -b -p ${TARGET_DIR} \
 && rm -rf ${HOME}/${MINICONDA_VERSION} \
 && ${TARGET_DIR}/bin/conda install -n base -c conda-forge mamba \
 && source ${TARGET_DIR}/etc/profile.d/conda.sh && conda activate base \
 && mamba install -n base -c conda-forge ...

and it works very well. I do not have any experience with micromamba. The documentation says,

Note that micromamba is still in early development and not considered ready-for-general-usage yet! It has been used with great success in CI systems, though, and we encourage this usage.

Thinking about it, I would argue that using Jupyter from a container environment is very close to classic CI workflows, so it's probably safe to use micromamba as we are not administrating a very complex set of several conda environments?
Also, Singularity containers are mostly read-only and even Docker-only workflows would be targeted rather at changing a container's default environment package list (and rebuilding from scratch), than occasionally and interactively adding packages (i.e. the classic interactive conda usage, which might be the thing that is not yet fully supported, see @willirath's comment).

OK, so let's move to Mambaforge as a first step and maybe later switch to micromamba to have no Python in the base environment.

From my experience, mamba is not a drop-in replacement for conda. Some crucial things are still missing today, such as full environment management options. Better to postpone the move to micromamba for now.


How to check if a stream is ongoing or finished?

Is there a way to check if a stream is still going on or finished?

Is there a way to check if a stream is still going on or finished?

You question was already answered.
https://github.com/alfianlosari/ChatGPTSwift/issues/15


Adding the timer based QR code

Problem Statement
We want to add a timer-based QR code in Inji, which can show a QR code that can

Auto-store credentials shared by residents after they perform selfie authentication.
Display the credential for 5 seconds and then reshow the QR code.

Steps

A relying party wants to use the application to collect the credentials of residents who avail the relying party's services
The relying party keeps the application stationed at a place for the residents to use after opening this QR code.
The resident scans the QR code
The resident performs a selfie authentication and shares the credential
The resident's credentials are shown on the relying party's app and are saved automatically
The credential on the UI disappears after 5 seconds and the QR code is shown on the relying party's app.

Additional context
This feature was available in an older version of Inji. Now, this feature can be added to the current version as well. A video of the implementation is available here.
https://user-images.githubusercontent.com/44160407/222541832-172077a2-8de3-42c3-b4b5-9c6ee9b471e9.MP4

For this to happen, we need to have verifiable credentials that needed to be as small as possible for them to transported within 5 seconds. What happens if there is a VC transfer that in progress?


fix: use default progress bar announcement text when a non-string lab…

Description
This change corrects a bug in the progress bar component where progress announcements were incorrect if a something other than a string was passed to the label prop. Now if something other than a string is passes as a label, the progress announcement defaults to only reading the percentage. This is similar to previous behavior in which no label is passed where the progress would read : <percentage>
How has this been tested?
This was tested via unit tests. A unit test was added to ensure this works, and existing unit tests related to this code area continue to work. The announcement was also read successfully via a screen reader by altering the "with-updates-page" and testing that experience.

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hello Cooper, I believe https://github.com/cloudscape-design/components/pull/1449/ solved this issue.
I'm closing this PR.
Thank you!


No custom logs are written to GCP

Hi
In my app I enable DB scripts to be logged as Log::info().
after adding this package I cannot see those logs (actual db queries) on the cloud logging.
I’m  using App Engine
thanks
Bilal

Hi,
Same here. How we can know the project id & credentials is match or error?


Reload problem with previewHtml

VSCode Version:1.0.3
OS Version: ubuntu 14.04

I'm writting some visualization capabilities via vscode.previewHtml. I found that my page will be reloaded when toggling editors. Here is a gif which recording the process:

How can I disable it?

You cannot. The previewHtml isn't designed to build custom UI but to render a document. When not visible (like changing tabs) we will dispose the state.

@jrieken
Is there other way to write HTML document?

No, we don't have an UI-extensibility story


Ambiguity of references

$container = new Container([
    'color' => Red::class,
]);

$factory = new Factory($container, [
    'color' => Green::class,
    Circle::class => [
        '__construct()' => [Reference::to('color')],
    ],
])

What is color of circle? Unclear.
May be need create special for factory new reference ContainerReference for create reference to definition in container? This will allow us to determine where to take definition: from factory (Reference from yiisoft/definitions) or from container (new ContainerReference from yiisoft/factory).

I think in this case it should be green without other options.

There are services you get as dependencies defined in container and objects you create defined in factory. In an artificial scenario these may be the of the same interface. In a real scenario, though, the situation you describe is close to be impossible. At least I've tried hard to come up with a case for it and failed.


DeskBands: Cannot re-open desk band

A deskband can be shown, hidden, but not reshown. The re-showing seems to call `CloseDWbut notOpenDW``.

Closing stale issues to focus on ones with end-user activity.


How compile for android

This is a continuation from this issue
I have a repo here:
https://github.com/mamcx/RustStoreNix/tree/nixify
I must compile on macOS, Linux with targets windows, linux musl, android, ios. But my major problem is with android. I need:
def archTriplets = [
        'armeabi-v7a': 'armv7-linux-androideabi',
        'arm64-v8a'  : 'aarch64-linux-android',
]

I tried with:
❯ nix --version
nix (Nix) 2.18.1

{
  inputs.nixify.url = github:rvolosatovs/nixify;

  outputs = {nixify, ...}:
    nixify.lib.rust.mkFlake {
      src = ./.;
      name = "rust-workspace";

      build.workspace = true;
      clippy.workspace = true;
      test.workspace = true;
    };
}

And get :
❯ nix develop
warning: Git tree '/Users/mamcx/Proyectos/Apps' is dirty
(nix:nix-shell-env) bash-5.2$ cargo build
+ command cargo build
   Compiling ring v0.17.6
   Compiling zstd-sys v2.0.9+zstd.1.5.5
   Compiling generic-array v0.14.7
   Compiling globset v0.4.14
   Compiling rustix v0.38.26
   Compiling pin-project v1.1.3
   Compiling walkdir v2.4.0
   Compiling libsqlite3-sys v0.27.0
   Compiling tracing-subscriber v0.3.18
   Compiling thiserror v1.0.50
   Compiling phf_codegen v0.11.2
   Compiling phf v0.11.2
   Compiling parse-zoneinfo v0.3.0
error: linking with `cc` failed: exit status: 1

Thank you for the report!
I've file a PR to your repo https://github.com/mamcx/RustStoreNix/pull/1 with an example.
At this time it is assumed that Cargo.toml resides at src, but in your case there are two separate workspaces in the repository and no top-level Cargo.toml, which is not currently supported - I flipped it around and moved RustStore to top-level to work around that.
I am still waiting for arm and Android builds to finish locally due to slow toolchain builds, but that should work unless some runtime deps are required for build

Thank you!
I have checked and it works. The modifications in your PR are acceptable to me.
A few questions:

Is likely that the support for the targets for Android 'armeabi-v7a',  'arm64-v8a' could be made to work (on both linux/macOS M1)? What is the block for them?
How to take advantage of caching to reduce (re)build times (especially in CI)


Feature Request: Allow customizing the automatic placeholder tables

Allow customizing this (text, color, settings, etc.):

I think you can style it via CSS already. You just need to make your rules more specific than the default CSS that ships with the plugin. For example if I define a rule for .auto-input-table, you can define a rule for body .auto-input-table and overwrite my settings. Then you include your CSS file, by adding something like the following in your mkdocs.yaml:
extra_css:
    - path/to/your-custom-style.css

You can find the default styles at https://github.com/six-two/mkdocs-placeholder-plugin/blob/main/src/mkdocs_placeholder_plugin/generic/generic_style.py. Everything containing the class auto-input-table is related to automatically generated placeholder tables.
Does this work for you?

body .auto-input-table {
    border-color: var(--md-primary-fg-color);
}
body .auto-input-table .auto-table-title {
    background-color: var(--md-primary-fg-color);
}

.auto-input-table .auto-table-title .settings_button {
    display: none;
}

.auto-input-table .expandable_contents .table-div b {
    display: none;
}
.auto-input-table .expandable_contents .table-div::before {
    margin: 3px auto 10px auto;
    padding: 0px 5px;
    content: "Please update and verify the following fields, then press Enter.";
}

Not super pretty, but this worked! Thank you for the information.


Windows

Can NNPACK support windows?

Here is a list of obstacles to Windows support:

NNPACK is written in C99, and Microsoft compilers still do not support this 17 years old standard.
It is possible to compile NNPACK with Clang with Microsoft codegen from the recent Visual Studio version, and the current configure.py has incomplete initial support for this configuration. However, linking would fail because the runtime library does not support _Complex float functions from C99 standard library. These functions are widely used in the reference implementation of FFT functions in NNPACK, and thus it is impossible to link the unit tests without them.
NNPACK uses pthreadpool library for multi-threading, and pthreadpool is implemented on top of pthreads and GCC-specific intrinsic functions for atomic operations. pthreads interface is not natively supported on Windows. Probably github.com/GerHobbelt/pthread-win32 can be leveraged to pthreads on Windows, but I didn't try.

Other options to try:

Compilation of NNPACK with Cygwin might work, but would be incompatible with most of Windows ecosystem.
Compilation of NNPACK with mingw would solve problems 1 and 2, probably problem 3 as well.
Compilation to NNPACK with Intel compiler for Windows should fix problems 1 and 2. pthreadpool dependency on pthreads would need to be resolved manually.

That said, I don't have plans (and time) for Windows port, but such contribution would be welcome!

It's very helpful.

Is it possible that I  can easily compile NNPACK with Intel compiler for Windows if I just use
enum nnp_status nnp_convolution_inference(
                               enum nnp_convolution_algorithm algorithm,
                               enum nnp_convolution_transform_strategy transform_strategy,
                               size_t input_channels,
                               size_t output_channels,
                               struct nnp_size input_size,
                               struct nnp_padding input_padding,
                               struct nnp_size kernel_size,
                               struct nnp_size output_subsampling,
                               const float input[],
                               const float kernel[],
                               const float bias[],
                               float output[],
                               pthreadpool_t threadpool,
                               struct nnp_profile* profile)

for deployment and don't use the multi-thread feature within it(simply assign threadpool = null)?

@knsong I think it will work. You'll have to remove nearly all implementation code from the thread pool.

I converted the c99 AVX2 convolution part to a native windows c++ dll. I used the microsoft ppl functionaltiy for a replacement of the threadpool. Many thanks for your great library! Whitout using any preallocation I more than doubled my training speed! :)
Filip

@zeno40 could you please create a PR?

Well a I  made a public repository
https://github.com/zeno40/nnpack


[1.3.0] Constructor overloads are incorrectly formatted

Expected Behavior

KtLint should retain the top level constructor () when an overloaded constructor exists and calls this()

Observed Behavior

KtLint removes the default empty class level constructor when a secondary overloaded constructor exists.
Steps to Reproduce

Given:
class Foo() {
    constructor(foo: String) : this() {
        // N/A
    }
}

KtLint produces the following Kotlin class where the default class level constructor is removed which breaks the overloaded constructors ability to call this()
class Foo {
    constructor(foo: String) : this() {
        // N/A
    }
}

Your Environment

Version of ktlint used: 1.3.0
Relevant parts of the .editorconfig settings: I'm able to reproduce with an empty editor config.

Nice find. An empty VALUE_PARAMETER_LIST should only be disallowed in case the class does not contain a secondary constructor.


feat(WorkerQueue): support queue.wait_for

Summary

Test Plan

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

Current dependencies on/for this PR:

main

PR #4765   👈

PR #4718

This stack of pull requests is managed by Graphite.


Integration testing

Add various things to the project, including:

unit tests
fully functional shovel
more invoke tasks
circle CI integration

No longer required.


libinfer7 moved to a different place

the new url is https://developer.download.nvidia.com/compute/machine-learning/repos/ubuntu1804/x86_64/

Also the specific xformers version wheel is hard to find. I used https://github.com/AbdBarho/stable-diffusion-webui-docker/releases/download/5.0.0/xformers-0.0.17.dev449-cp310-cp310-manylinux2014_x86_64.whl

@hrkrx thank you for the new link!! Will update with next push

New build script have removed the necessity to import externally built libraries


Rebrand for Xebia

This assumes a few things:

Xebia is interested in maintaining this library
The project is moved to the https://github.com/xebia organization
The project would be re-published to Maven Central with updated coordinates

Closes #3 I think

Cancelling as the project seems abandoned: https://github.com/PGSSoft/HttpClientMock/issues/3#issuecomment-1667437387


Add tests for fsevent

Not ready for merge
I adapted these from the rsnotify tests but use a timeout and don't enforce event order.
I haven't been able to get these to pass at all though.
No matter where I insert thread::sleep after the file creation the watched file always gets an event with flags ITEM_CREATED | ITEM_MODIFIED | IS_FILE
In the current state here is the test failure:
 > cargo test
     Running target/debug/fsevent-bcd99ee57f058d7e

running 1 test
Will observe now
Will append to file now
test validate_watch_single_file ... FAILED

failures:

---- validate_watch_single_file stdout ----
	Just created file
actual: Event { event_id: 11952012, flag: ITEM_CREATED | ITEM_MODIFIED | IS_FILE, path: "/private/var/folders/00/135tr000h01000cxqpysvccm004cqb/T/dir.s9ofVm78kMkO/out.txt" }
thread 'validate_watch_single_file' panicked at 'actual: Event { event_id: 11952012, flag: ITEM_CREATED | ITEM_MODIFIED | IS_FILE, path: "/private/var/folders/00/135tr000h01000cxqpysvccm004cqb/T/dir.s9ofVm78kMkO/out.txt" } not found in expected: [("/private/var/folders/00/135tr000h01000cxqpysvccm004cqb/T/dir.s9ofVm78kMkO/out.txt", ITEM_MODIFIED | IS_FILE)]', tests/fsevent.rs:35

stack backtrace:
   1:        0x10f0fe565 - sys::backtrace::write::hf5ea20500b66cd24uns
   2:        0x10f101e23 - panicking::on_panic::hbe02cb0d925cad49iGw
   3:        0x10f0f3c42 - rt::unwind::begin_unwind_inner::h12ba0ba9dffdecc2uow
   4:        0x10f06f935 - rt::unwind::begin_unwind::h13335596912956014251
   5:        0x10f05dec1 - validate_recv::h616d85b7c74985a8zaa
   6:        0x10f073bf4 - validate_watch_single_file::hafcd4e05aad43812nga
   7:        0x10f0c06e0 - boxed::F.FnBox<A>::call_box::h11070975173153378549
   8:        0x10f0c361f - boxed::F.FnBox<A>::call_box::h1372358435100094416
   9:        0x10f0c0ee7 - rt::unwind::try::try_fn::h5361545742513409503
  10:        0x10f103b48 - rust_try_inner
  11:        0x10f103b35 - rust_try
  12:        0x10f0fd4a5 - rt::unwind::try::inner_try::h480e3107f6a4b5b9nkw
  13:        0x10f0c1118 - boxed::F.FnBox<A>::call_box::h12826721353945353732
  14:        0x10f100a1d - sys::thread::Thread::new::thread_start::hdb3d925f69c5da4aHIv
  15:     0x7fff92440267 - _pthread_body
  16:     0x7fff924401e4 - _pthread_start

failures:
    validate_watch_single_file

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured

thread '<main>' panicked at 'Some tests failed', ../src/libtest/lib.rs:255
stack backtrace:
   1:        0x10f0fe565 - sys::backtrace::write::hf5ea20500b66cd24uns
   2:        0x10f102095 - panicking::on_panic::hbe02cb0d925cad49iGw
   3:        0x10f0f3c42 - rt::unwind::begin_unwind_inner::h12ba0ba9dffdecc2uow
   4:        0x10f09f676 - rt::unwind::begin_unwind::h17788042703409534955
   5:        0x10f0a1323 - test_main::he3317e9b11453a96I1a
   6:        0x10f0a7b41 - test_main_static::h818c3572a7d0c571d4a
   7:        0x10f07ca9c - __test::main::h4a46bda5e9d5f9fcdka
   8:        0x10f103b48 - rust_try_inner
   9:        0x10f103b35 - rust_try
  10:        0x10f1029f3 - rt::lang_start::hd8f037e4034ec509fBw
  11:        0x10f07cafe - main

Even though I haven't had much success making a passing test I wanted to share in case it was helpful for anyone else's debugging.

Thanks, I'll use that :)

Funnily, on my machine, letting some time to Rust to actually create the files let the test pass.
`
diff --git a/tests/fsevent.rs b/tests/fsevent.rs
index 3e7d311..515b450 100644
--- a/tests/fsevent.rs
+++ b/tests/fsevent.rs
@@ -83,7 +83,7 @@ fn validate_watch_single_file() {
{
let dst = dst.clone();
let _t = thread::spawn(move || {

 thread::sleep_ms(1000); // Wait a while after create above before observing.

 thread::sleep_ms(10000); // Wait a while after create above before observing.
 println!("Will observe now");
 let fsevent = fsevent::FsEvent::new(sender);
 fsevent.append_path(dst.as_path().to_str().unwrap());

@@ -94,7 +94,7 @@ fn validate_watch_single_file() {
{
let dst = dst.clone();
let t3 = thread::spawn(move || {

 thread::sleep_ms(1500); // Wait another 500ms after observe.

 thread::sleep_ms(12000); // Wait another 500ms after observe.
 println!("Will append to file now");
 let mut file = OpenOptions::new().write(true).append(true).open(dst.as_path()).unwrap();
 file.write_all(b"foo").unwrap();

`
Without the timeout, I receive:
ITEM_CREATED ITEM_MODIFIED IS_FILE
As a single event.

Interesting indeed.
I was hoping to isolate the create and modify to test that each occurred.
I didn't expect ITEM_CREATED to show-up after the long wait after creating it. I'm not sure if it does because of FSEevent coalescing or if it's due to the append actually being reported as a modify + create at the same time.
I think it's more likely because of coalescing because before I used OpenOptions.append I was also seeing the ITEM_REMOVED flag from time to time which would imply that I fixed the file being replaced rather than appended to.
I played around with file.sync_all in place of write_all but saw no significant change, except that it panicked sometimes!

fsevent_watch from brew show the same sequence as the one we have in the test:
30440452	0x00011100=[created,modified]	/private/var/folders/h0/vp5g3p354cqgk6dc3r7jcwvc0000gn/T/dir.2Ig6gqQZ9sug/out.txt
30440455	0x00011100=[created,modified]	/private/var/folders/h0/vp5g3p354cqgk6dc3r7jcwvc0000gn/T/dir.2Ig6gqQZ9sug/out.txt

Note that the test only receives the second event, which contains a [created modified] nonetheless.

Cool! That's a nice debugging tool.
I think that points to me being mistaken about the behavior of:
 let mut file = OpenOptions::new().write(true).append(true).open(dst.as_path()).unwrap();
       file.write_all(b"foo").unwrap();
``

I tried `echo a >> /Users/jakerr/watch/a` to an existing file and get

12922468	0x00011000=[modified]	/Users/jakerr/watch/a
So a real append does not have `created`.

There must be a better rust api to append some bytes to a file without re-creating it.

Curiously, this sample code behaves correctly https://gist.github.com/octplane/cc39bb26c0c6d445e317
We see that the event are send the right way.
[130] 18:09:38 Tirlipinpon:~/src/fsevent-rust > fsevent_watch -n -F ../plop
30567229	0x00011300=[created,removed,modified]	/Users/octplane/src/plop/test.txt
30567232	0x00011000=[modified]	/Users/octplane/src/plop/test.txt

However, it seems there is some latency in the fsevent events, even in this case...

And finally, more stuff around this shows that there is some lag even with fsevent_watch:

My suggestion: Add timeouts !

I have merged most of your suggestions in the library. Thanks for all that :)

Nice, I'm glad that was useful! Thanks for sharing all the debugging you did as well. I learned a lot about fsevent from this thread.
:white_check_mark: Pulled and ran the tests which pass here as well!


suppress jump to top-of-page on most UI links

By default the browser sends you to the top of the page when clicking on a link, but for most buttons in the UI we want the interface to stay scrolled to the same position.

Tweaked the settings, seems to work better as intended but might require further adjustment (the footer links scroll back to the top, but not quite all the way). Closing.


Autocomplete in TypeScript displays type error with multiple={true} and options + onChange

[x ] The issue is present in the latest release.
[ x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
If I add options as a string array, and declare the onChange new value to be a string array, I get a type error that the options parameter should be string[][].
Expected Behavior 🤔
You shouldn't get a type issue, because the component works when receiving a string array of options.
Steps to Reproduce 🕹
Here's a code example that will reproduce the issue:
export const AutocompleteTypeError = () => {

    const [selectedValues, setSelectedValues] = useState<string[]>([])

    return (
        <Autocomplete
            multiple={true}
            options={["A", "B", "C"]}
            value={selectedValues}
            onChange={(event: ChangeEvent<{}>, newValue: string[] | null) => setSelectedValues(newValue ?? [])}
        />
    )
}

Context 🔦
This forces me to use // @ts-ignore

Tech
Version

Material-UI
v4.9.14

React
16.13.1

Browser
Chrome

TypeScript
3.9.3

Material-UI lab
v4.0.0-alpha.53

Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!


Support setting Terraform provider features

What problem are you facing?
We are creating multiple large compositions using this provider, and they all create resource groups with many resources within the RG. we want to be able to set the features section of the terraform provider to allow for bypassing the safety limits created by Azure. the main use case for us is to eanble the feature: prevent_deletion_if_contains_resources under the resource_groups feature key. This would allow for deleting the resource group to also delete all resources in that group. by doing that we can change our management policies to only have delete on the resource group which saves alot of time, and it also helps in covering use cases like AKS clujsters where we want to delete the resource group in order to have all PV backed disks and load balancers deleted automatically for us.
While this specific feature is what we currently need, the ability to set via providerConfig a features block like in terraform would unlock a lot of options.
Currently we have had to go down the approach of using the crosplane terraform provider to create the resource group with that setting and everything else we then do via the azure family providers but this is a slower, suboptimal and more cumbersome solution then we hoped for

@vrabbi On initial evaluation of this request, enabling this capability would be in violation of the high-fidelity principal of the Crossplane Resource Model: https://github.com/crossplane/crossplane/blob/master/design/one-pager-managed-resource-api-design.md#high-fidelity
Apart from this we are not confident that allowing end-users to modify behavior of the underlying Terraform provider is a good idea, as it could likely result in issues in the code we generate which expects things to work in a specific manner.

Wouldnt not enabling the features of the terraform provider for a resource be what is in contradiction to the high fidelity goal for crossplane?
Its unfortunate that the terraform provider doesnt have this setting in the resource itself but i dont see that changing as there are dizens of features using in the providers configuration in the TF provider for many resources.
I get the risk of enabling making changes to the config but at least from an end user perspective this makes it much more likely we will not be able to move to crossplane for azure projects and may need to evaluate other options as so much functionality will be lost for us making it a very difficult choice to go with.
The crossplane terraform provider is not a solution for long term in our case especially at scale, and without this type of functionality we cant move to the crossplane azure provider which is unfortunate

I can't help but agree with @vrabbi. If the underlying provider for this kind of resource is terraform-provider-azurerm then it "...should expose everything that provider exposes to its users as much as possible".
As pointed out there are other reasons to not expose this option, but it seems backwards to say no and justify it by pointing to a principal that aspires to expose every possible knob.


[JAV-508] & [SCB-11] Metrics Auto Publish

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [JAV-XXX] Fixes bug in ApproximateQuantiles, where you replace JAV-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

JAV-508 & SCB-11 Metrics Auto Publish
If user include metrics in dependency,the metrics service would auto publish with Java Chassis Producer,also use same transport and endpoint config.
For example if user config rest address <IP_ADDRESS>:8080 in microservice.yaml,then the metrics service will available at http://:8080/metrics

Changes Unknown when pulling a3f28f70e632c62cf030fabee19839d3dab5df0d on zhengyangyong:JAV-508&SCB-11 into ** on apache:master**.

this will be improve after this PR : https://github.com/apache/incubator-servicecomb-java-chassis/pull/451,we had fully discuss via mail


When the step has been set to a number other than 0, the value is always set to zero on iOS.

Steps to reproduce the issue (iOS)

get the prop to any value like so step={10}
then currentValue to any value by simulating an api with a settimeout.
Result : the current value stays at 0.

here is my code:
<Slider
disabled={!edittable}
ref={sliderRef}
style={styles.slider}
minimumValue={minValue}
maximumValue={maxValue}
tapToSeek={true}
lowerLimit={!edittable ? currentValue : undefined}
upperLimit={!edittable ? currentValue : undefined}
value={currentValue}
step={10}
onSlidingComplete={update}
onValueChange={val => {
if (edittable) {
setCurrentValue(Math.round(val));
}
}}
thumbTintColor={edittable ? THEME.ORANGE : THEME.GREY_50}
minimumTrackTintColor={edittable ? THEME.ORANGE : THEME.ORANGE_TWO}
maximumTrackTintColor={THEME.GREY_50}
/>

@KelvinPortuphy Can you provide me with some more information, so I can try to reproduce the issue? Can you elaborate on what the scenario is that you mention?

@KelvinPortuphy Can you provide me with some more information, so I can try to reproduce the issue? Can you elaborate on what the scenario is that you mention?

I've updated the description 👆

Hello @KelvinPortuphy!
I'm not sure if I understand the issue as I can't reproduce it with the scenario you described.
Can you check the repro implementation I linked to this issue and provide me with feedback regarding your issue so we have a common understanding?

Closing due to no reproduction possible and no response from author.
Please let me know in case of issue still being valid.


Add Ability to quickly toggle all Live Notifications while livestreaming

What should be added?
Ability to mute / unmute Live Notifications without the need to remove / add them again.

Possibillity to toggle it in streamer mode

Why should it be added?
I want to be notified when people are going live. But when I'm streaming myself I want to turn off all Live Notifications so my stream is not Interrupt.

@Praaug would adding a toggle for Live Notifications in General Settings -> Streamer Mode suit your needs? I feel like this is something that would fall under this category and it can be used along with "Detect OBS" option in Streamer Mode.

@Praaug would adding a toggle for Live Notifications in General Settings -> Streamer Mode suit your needs? I feel like this is something that would fall under this category and it can be used along with "Detect OBS" option in Streamer Mode.

That would be totally fine.
I'm not 100% sure and need to test the sound muting.
But if you use desktop capture, you would still get the banner.

That would be totally fine.
I'm not 100% sure and need to test the sound muting.
But if you use desktop capture, you would still get the banner.

@Praaug I made a PR (#2342) for this issue. If you're on Windows, please try version from PR and let me know if it solves this (I don't trust myself that I've patched all kinds of notifications 🙂) as I can't test this because I'm on Linux.

@Praaug I made a PR (#2342) for this issue. If you're on Windows, please try version from PR and let me know if it solves this (I don't trust myself that I've patched all kinds of notifications 🙂) as I can't test this because I'm on Linux.

@zneix I have to setup my dev environment and get the sources. Will do it after work today and come back to you with the results

@zneix I have to setup my dev environment and get the sources. Will do it after work today and come back to you with the results

@zneix I have to setup my dev environment and get the sources. Will do it after work today and come back to you with the results

If you don't want to go through the hassle of setting up a dev environment, you could also download the PR artifact built by Github Actions.

@zneix I have to setup my dev environment and get the sources. Will do it after work today and come back to you with the results

If you don't want to go through the hassle of setting up a dev environment, you could also download the PR artifact built by Github Actions.

@zneix I have to setup my dev environment and get the sources. Will do it after work today and come back to you with the results

If you don't want to go through the hassle of setting up a dev environment, you could also download the PR artifact built by Github Actions.

I didn't think about that.
@zneix just testet it with 3 channels. Sound as well as Banner Notifications are not shown if the feature is enabled and OBS is running. If OBS is not running, I get the sound as well as the banner.
Works exactly like it should be.

@zneix I have to setup my dev environment and get the sources. Will do it after work today and come back to you with the results

If you don't want to go through the hassle of setting up a dev environment, you could also download the PR artifact built by Github Actions.

I didn't think about that.
@zneix just testet it with 3 channels. Sound as well as Banner Notifications are not shown if the feature is enabled and OBS is running. If OBS is not running, I get the sound as well as the banner.
Works exactly like it should be.


ISPN-14217 Add test for RESP endpoint to ensure unknown command is th…

…rown
https://issues.redhat.com/browse/ISPN-14217

Merged, thanks


Black Crusade Spelling.json

Changes / Comments
-Fixed spelling mistakes.

@clevett did you notice the conflicts that appeared after you approved this PR?

Greetings @KriosMerew
I'm going to close this pull request. I actually made these changes in a hot fix last week. Thanks for bringing them to out attention.

Cassie


question: what wrong this test case?

how to do can be success to run this test case?
git clone https://github.com/laravel/framework.git
compose install --verbose
vendor/phpunit/phpunit/phpunit --filter testRefreshCommandCallsCommandsWithProperArguments DatabaseMigrationRefreshCommandTest tests/Database/DatabaseMigrationRefreshCommandTest.php --debug`

Runtime:       PHP 7.1.12 with Xdebug 2.6.0beta1
Configuration: D:\web\github\laravel\framework\phpunit.xml.dist

Test 'Illuminate\Tests\Database\DatabaseMigrationRefreshCommandTest::testRefreshCommandCallsCommandsWithProperArguments' started
Test 'Illuminate\Tests\Database\DatabaseMigrationRefreshCommandTest::testRefreshCommandCallsCommandsWithProperArguments' ended

Time: 156 ms, Memory: 10.00MB

There was 1 error:

1) Illuminate\Tests\Database\DatabaseMigrationRefreshCommandTest::testRefreshCommandCallsCommandsWithProperArguments
Mockery\Exception\NoMatchingExpectationException: No matching handler found for Mockery_2_Illuminate_Database_Console_Migrations_ResetCommand::run(object(Symfony\Component\Console\Input\ArrayInput), object(Illuminate\Console\OutputStyle)). Either the method was unexpected or its arguments matched no expected argument list for this method

Objects: ( array (
  'Symfony\\Component\\Console\\Input\\ArrayInput' =>
  array (
    'class' => 'Symfony\\Component\\Console\\Input\\ArrayInput',
    'properties' =>
    array (
    ),
  ),
  'Illuminate\\Console\\OutputStyle' =>
  array (
    'class' => 'Illuminate\\Console\\OutputStyle',
    'properties' =>
    array (
    ),
  ),
))

D:\web\github\laravel\framework\vendor\mockery\mockery\library\Mockery\ExpectationDirector.php:92
D:\web\github\laravel\framework\src\Illuminate\Console\Command.php:198
D:\web\github\laravel\framework\src\Illuminate\Database\Console\Migrations\RefreshCommand.php:104
D:\web\github\laravel\framework\src\Illuminate\Database\Console\Migrations\RefreshCommand.php:55
D:\web\github\laravel\framework\src\Illuminate\Container\BoundMethod.php:29
D:\web\github\laravel\framework\src\Illuminate\Container\BoundMethod.php:87
D:\web\github\laravel\framework\src\Illuminate\Container\BoundMethod.php:31
D:\web\github\laravel\framework\src\Illuminate\Container\Container.php:549
D:\web\github\laravel\framework\src\Illuminate\Console\Command.php:183
D:\web\github\laravel\framework\vendor\symfony\console\Command\Command.php:252
D:\web\github\laravel\framework\src\Illuminate\Console\Command.php:170
D:\web\github\laravel\framework\tests\Database\DatabaseMigrationRefreshCommandTest.php:68
D:\web\github\laravel\framework\tests\Database\DatabaseMigrationRefreshCommandTest.php:41

Welcome to Laravel! We are glad to have you as part of the community.
Unfortunately GitHub is not an appropriate platform for general application issues. This is only for issues/bugs with the framework code itself.
Please close your issue, and instead try asking your question on one of the many great community support areas that will likely give you a better answer more quickly:
Laravel Slack (https://larachat.co/)
Laravel.io Forum (https://laravel.io/forum)
Laracasts Forum (https://laracasts.com/discuss)
StackOverflow (http://stackoverflow.com/questions/tagged/laravel)
Thanks!

ok, thanks.
ps: i have try to run in linux. all are ok.
but, mabe have a small problem.
if i running with root.
tests/Filesystem/FilesystemTest.php::testIsWritable will failure.
because root can be write all?


fix csv parsing

Currently there is a panic if a csv line contains nothing but whitespace.

Presuming the bats tests pass this LGTM.


Cannot use git-commit-id-plugin with java-microprofile stack

Is your feature request related to a problem? Please describe.
I tried to use the git-commit-id-plugin maven plugin to capture git repo information in my java-microprofile project. It doesn't work because the project's .git folder is not mounted into the container.  The plugin needs this folder to work.
I am able to use git-commit-id-plugin in a java-spring-boot2 project because that stack mounts the entire project into the container so the .git folder is available.  I don't know why the java-microprofile stack doesn't work the same way.
From what I understand maven-git-commit-id-plugin is a popular maven plugin so I imagine others will eventually have this issue.
https://github.com/git-commit-id/maven-git-commit-id-plugin
Describe the solution you'd like
Change the way the java-microprofile stack mounts the user's project into the container so that side folders such as the .git folder are available.
Describe alternatives you've considered
None
Additional context
None

We are currently working on some stack updates to use liberty-maven-plugin dev mode to watch for changes rather than appsody, which should make it easier to mount the whole directory, which would seem to solve this.

I'm going to close this as a special case of #554.   Though it's a valid issue in its own right, in practice we'll probably either fix the broader issue (solving this too) or not fix it at all.
Note the new java-openliberty, evolved from the earlier java-microprofile stack, should not have this issue (though I haven't tested personally).


OSError: [Errno 28] No space left on device

When running Circle-Map Realign in a conda environment
Circle-Map Realign -t 24 -i sorted_candidates.A.bam -qbam qcircle.A.bam -sbam sorted_circle.A.bam -fasta ref.fa -o final_circle.A.bed
I get an OSError:
File "/global/home/users/diplockn/.conda/envs/circle/lib/python3.7/site-packages/pybedtools/bedtool.py", line 3256, in cat
TMP.write(str(f))
OSError: [Errno 28] No space left on device
This doesn't appear to be a ram issue since the cluster I'm running on does not give an out of memory error
I get the same error when using python /global/home/users/diplockn/Circle-Map/circlemap/circle_map.py Realign -t 24 ...

Dear @diplockn,
Thanks for posting your question.  As you pointed out, the issue is not RAM problem. The problem is caused because apparently Circle-Map is writing a substantial amount of temporary files on disk. In the end, if you exceed the amount of available temp disk space, you get the error. Coincidentally, the issue#27 found a similar problem a week ago.
To solve your issue:
At the stage the software is right now:
I suggest you to run Circle-Map using less threads. I think that setting it to 16 should reduce the amount of temp files on disk, avoiding the OSError.
Long term solution:
You and another user (issue #27 ) have reported similar problems. I have tried to reproduce the error on my cluster, but it seems to work fine for me. However, if this causes problems to many users it should be handled and fixed at some point. At this moment I am busy with other projects (there is a PhD that needs to be finished). But if you or anybody else reading this keeps getting the error after reducing the number of threads, write a comment and I will increase the priority to fix the problem.
Best wishes,
Iñigo

Hey Iñigo,
It seems like Circle-Map Realign puts temporary files in the home directory of the cluster I'm working on by default. I used TMPDIR to make a temporary directory in our clusters scratch storage:
source activate circlemap
export TMPDIR=/global/scratch/diplockn/${sample}
mkdir -p $TMPDIR
Circle-Map Realign -t 24 -i sorted_candidates.${sample}.bam -qbam qcircle.${sample}.bam -sbam sorted_circle.${sample}.bam -fasta /global/scratch/users/diplockn/ref.fa -o final_circle.${sample}.bed
conda deactivate
and it worked no problem with 24 threads.
Best,
Nate

Dear Nate,
Sounds great. Glad to hear that changing the tempdir worked. I did not consider changing the TMP folder to a custom folder during the whole software execution. But to be honest, it seems a very reasonable way of handling the issue. Thanks a lot for the idea. I am  going to leave the issue open until I fix the problem.
Best,
Iñigo

Hi Iñigo,
If you have yet to adjust the directory for temporary files, I just thought that I'd mention that the TMPDIR solution above only redirects some of the temporary files.
I am modifying TMPDIR as diplockn does above.
Within my TMPDIR location, I see many "pybedtools.xxxxxxxx.tmp" files, as well as a couple "pymp-xxxxxxxx" directories.
However, in my working directory, I also see multiple directories of "temp_files_xxxxx".
Would it be possible to generate all temporary files in the same location?
This would be beneficial on my cluster setup, where I have a large storage allowance specifically for temporary files.
Additionally, it would stray file clean-up easier in case a compute job terminates early.
Thanks as always,
Michael


fix: check VSCODE_RESOLVING_ENVIRONMENT env variable

The January 2023 release of VSCode added a new VSCODE_RESOLVING_ENVIRONMENT variable (https://code.visualstudio.com/updates/v1_75#_new-vscoderesolvingenvironment-environment-variable) that is set to 1 when resolving user's shell environment.
Related to #1, this fixes the same issue for VSCode version >= 1.75.

I believe test "$TERM_PROGRAM" != 'vscode' still work on VSCode version >= 1.75? There's no mention about they're deprecating $TERM_PROGRAM for $VSCODE_RESOLVING_ENVIRONMENT?

Unfortunately my tests suggest otherwise. Not sure why TERM_PROGRAM is not set anymore during initialization. To duplicate the issue and see what the ENV is during VSCode initialization do the following (this is on MacOS Ventura VSCode 1.75.0):

Open Automator app, click Application
Search "Run Shell Script"
Set the script to open -a "Visual Studio Code.app" --args --crash-reporter-directory /Users/yourusername/vscode-dump/ --log trace
Close VSCode
Set set -U fish_tmux_autostart true && set -U fish_tmux_autostart_once true
Go to /Users/yourusername/Library/Application Support/Code/logs, there should be multiple log folders named something like 20230208T114023. Remove them )
Run the automator script, this opens vscode with trace logging enabled.
Go to the latest log folder. Run cat main.log
Look for a log line starting including getUnixShellEnvironment#env, this doesn't include TERM_PROGRAM anymore, only VSCODE_RESOLVING_ENVIRONMENT

❯ cat main.log | grep 'getUnixShellEnvironment#env'
2023-02-08 14:07:30.310 [trace] getUnixShellEnvironment#env {"PWD":"/Users/yourusername","MallocNanoZone":"0","USER":"yourusername","SECURITYSESSIONID":"186b4","COMMAND_MODE":"unix2003","__CFBundleIdentifier":"com.microsoft.VSCode","PATH":"/usr/bin:/bin:/usr/sbin:/sbin","LOGNAME":"yourusername","SSH_AUTH_SOCK":"/private/tmp/com.apple.launchd.MHgmPoHg3a/Listeners","SHLVL":"1","HOME":"/Users/yourusername","SHELL":"/opt/homebrew/bin/fish","_":"/usr/bin/open","TMPDIR":"/var/folders/yl/51y2f87n5jlfxmfffdt_c_080000gn/T/","LaunchInstanceID":"192329C3-C256-4F14-B27D-63319C8AE4C2","__CF_USER_TEXT_ENCODING":"0x1F5:0x0:0x0","XPC_SERVICE_NAME":"application.com.microsoft.VSCode.32703206.32703212","XPC_FLAGS":"0x0","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","VSCODE_CWD":"/","VSCODE_NLS_CONFIG":"{\"locale\":\"en-gb\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_CODE_CACHE_PATH":"/Users/yourusername/Library/Application Support/Code/CachedData/e2816fe719a4026ffa1ee0189dc89bdfdbafb164","VSCODE_IPC_HOOK":"/Users/yourusername/Library/Application Support/Code/1.75.0-main.sock","VSCODE_PID":"27380","ELECTRON_RUN_AS_NODE":"1","ELECTRON_NO_ATTACH_CONSOLE":"1","VSCODE_RESOLVING_ENVIRONMENT":"1"}

Code/logs/20230208T140730 on ☁  (eu-west-1)
❯ cat main.log | grep 'TERM_PROGRAM'

On earlier versions TERM_PROGRAM was set, on 1.75.0 it seems that it is not.

Okay, thanks for the PR!


Nullables

This PR is on top of my previous PR #28 and it contains 2 small fixes for cached XNames and support for C#8 nullable refs.
Fixes to #19
When testing nullable refs I noticed bugs introduced by my previous XName caching. They are fixed in the first 2 commits of this PR.

Derived classes sometimes need to access parent field names in BuildElementDictionary. Because those fields were private the generated code doesn't compile.
I fixed this by making the XName fields internal instead of private and added EditorBrowsable.Never so that they don't show up as static members for users.

The second problem is a warning in generated code. When a new member is generated, hiding a parent property, the field didn't have the new modifier and so C# warned against it.
I fixed that by adding a new modifier to the XName field if the property has a new modifier.

Nullable refs
This required a lot more work around it than the feature itself.
First this is opt-in because nullable annotations don't work in previous compilers. So you need to put <NullableReferences>true</NullableReferences> in your config file for this to be enabled.
I changed the syntax for nullable values to use ? instead of Nullable<T> and then I simply used the exact same logic when the type is a reference if nullables are enabled. Practically a 2 LoC change.
When testing this I encountered an unexpected issue: C# doesn't apply your project nullable settings to auto-generated code (this is actually documented -- never paid attention). No matter how your project is configured, auto-generated code must opt-in in with a #nullable pragma.
This is a pain because you can't add pragmas with CodeDom, I had to create the PragmaHelper.cs hack to add them in post-prod. :(
I tried #nullable enable but quickly discovered that the nullability of list backing field is incorrect. I attempted to fix it but it's a real pain using CodeDom that doesn't have real nullable types support.
I was also worried that other generated code pattern I'd miss during my tests would also create nullable warnings.
So instead I used #nullable enable annotations.
In this mode you're allowed to use C# nullable annotations (so all properties that are optional are correctly annotated with ?) but the compiler will not report any warning from code in this context (so the generated code might be incorrect with respect to those annotations -- everything still works as before anyway).
I think that's the easiest way to get what brings value to us (type-checked nullable reference properties for users) without the trouble of changing the internal code generation.
Here's an optional string property from wss.xsd:
-            public virtual string DisplayName {
+            public virtual System.String? DisplayName {
                get {
                    XAttribute x = this.Attribute(DisplayNameXName);
-                    return XTypedServices.ParseValue<string>(x, XmlSchemaType.GetBuiltInSimpleType(XmlTypeCode.String).Datatype);
+                    return XTypedServices.ParseValue<System.String?>(x, XmlSchemaType.GetBuiltInSimpleType(XmlTypeCode.String).Datatype);
                }
                set {
                    this.SetAttribute(DisplayNameXName, value, XmlSchemaType.GetBuiltInSimpleType(XmlTypeCode.String).Datatype);
                }
            }

Risks?
First this is an opt-in feature. As long as you don't enable it you should get the same codegen as before.
When you enable it, only properties are typed with nullables, but as I said the generated code is not checked by C# compiler so no new warning should come from generated code.
The annotations are correct but there might be edge cases where something nullable isn't annotated so?
In my tests I noticed one case that's not good: lists.
They are non-nullable, and that's fine for the getter as the generated code will always produce an empty list instance; but they have nullable setters (which remove all list contents). For now you'd have to use List = null! or maybe use a different pattern List.Clear() but I think there's a better solution with an extra attribute that I'm gonna investigate.

And that last point with lists is done, it was quite easy.
I added [AllowNull] on list properties.
That's a special C# attribute that allows setting the property to null even though its getter is typed as non-null.

@mamift That is as far as I intend to go for now.
We are currently building new xml parsers/builders, so I'd appreciate if you could release a nuget package with those changes, thanks 🙇

Thanks for your contributions.


Run service as particular user for systemd and launchd

Nice crate you have here! In our project, we were looking for a cross platform solution for managing services and this crate seemed a great fit, but it was just lacking the ability to specify which user the service runs as, so I decided to submit a PR.
It's important to be able to specify which user the service runs as, particularly in a Linux-based environment. Therefore, the ServiceInstallCtx is extended with an optional username field.
It's also possible to run services on Windows with a non-Administrator user account, and I tried hard to get this to work. I could get the service created with another account, but it would not start. I ended up just submitting my PR with support for macOS and Linux.
New system tests were provided, with the base test being extended to check if the service process is running as the user specified in the ServiceInstallCtx definition. It just does this by checking the service definition. I tried to check the running service process to see if it was running as the correct user, but this proved to be difficult to do in a cross platform way.
Running with a different user only applies to system-wide services.
I made a small change to the way the plist file was constructed for launchd, preferring to use the plist crate rather than a hard coded string.

Thanks for the contribution! I'll give your PR a review over the next couple of days, but in the meantime going to kick off some tests. Conceptually, what you described sounds fine to me, so let's see if we can get it integrated and a new release pushed shortly.

@jacderida it looks like the FreeBSD vm action I was using is now broken, so I tried switching to a different one on the primary branch, but that one is hitting https://github.com/cross-platform-actions/action/issues/61#issuecomment-1767300734.
So I'll most likely disable the FreeBSD test action. Once I do so, pull in those changes and rebase on top. We can work from there!

@jacderida it looks like the FreeBSD vm action I was using is now broken, so I tried switching to a different one on the primary branch, but that one is hitting cross-platform-actions/action#61 (comment).
So I'll most likely disable the FreeBSD test action. Once I do so, pull in those changes and rebase on top. We can work from there!

OK cool. I ran the tests on my fork before I submitted the PR and couldn't get that one working, but I didn't think it was caused by any of my changes.

@jacderida something I forgot to do was ask you to amend the changelog with a note about this PR. Would you like to submit a second PR with the change documented? If not, I'll add it later this week and then publish a new version under 0.4.0.

Ah sure, no problem! I'll do it later today.


[GPTQ] Add GPTQ python implement.

Please add license head in new files.

Please add license head in new files.

Added.

@pujiang Add only Python code. Will request GPTQ cpp code in another PR.


Revoking a user across multiple teams

Hello,
Is there a way to revoke access to a user for multiple teams at once? When having a lot of teams removing a single user can get pretty tedious by changing teams, managing users, searching, removing, repeat...
Thanks!

There is a method in the code that is intended to delete a user from anything they belong to:
https://github.com/gristlabs/grist-core/blob/8853e095bb09afdfaa984de271736b6edd36114c/app/gen-server/lib/Doom.ts#L92
Nobody has built a UI for it yet though.

Maybe this is a chance to offer a global settings and administration screen that is independent from teams or user accounts?

There is an admin panel these days @almereyda, at /admin. So far it has accumulated diagnostics but no one has put configuration there yet. I expect continued evolution, and would welcome more work here.


Need new and more checkpoints for Pirate Chain to make it easier and faster to sync with network

Right now the checkpoints for Pirate chain are with the difference of 100k to sync with the network, and the last or recent one starts from height 1,000,000. Whereas the current height is somewhere about 1,390,000+. That's near to 400k block headers which needs to download and make mobile wallet sync with the network.
I used this file to get required blockheight and sapling_tree relevant data to update the dependency of this iOS wallet updated:
https://raw.githubusercontent.com/piratenetwork/piratewallet-light-cli/merge_upstream/coin-checkpoint.json
Checkpoints set for this iOS wallet, based on blocks info taken from piratewallet-light-cli:
https://github.com/Meshbits/ZcashLightClientKit/blob/shield-funds-poc/ZcashLightClientKit/Stencil/WalletBirthday+saplingtree.stencil
I need more checkpoints with the same info to add to the list, which will make syncing wallet faster with the network:
height: 300000,
hash: "000000001598dc03f64b36169a482dfa3d85a10d42cde06aa6cc6a75707389b2",
time:<PHONE_NUMBER>,
sapling_tree: "01d7243618851dc06cc59ec16c6d77d8e352af3793cd21c0a9938372bb7157670500120001945ae5bdc14a29faa8e2fd50f01ef6a3a8da167584ce9e82063d4ed17416196f0103ed7a6d19f12d1c442c0057fd078903ef6cd3e3306044d7c0f8fdd36f6fe06a01447f859be85701d6871e2480b5036ea63b6f47c144cf29436e7294be603e1c3001b4ec68e46936f3aebb175fb332509326e8d2a182d1449d53777b4a7e2c29fa5801cfc6e9fbf8f0ca810b0e45cdcebc6e765faaaeb8fa0be187be895e683f0504540000000152ccf74ce6806b561418faa131c772506c83acd3b896cab2663fcfb94d09a45801d5ad937c911d34f096261bf38ccee013ccf89dd50bfe5e54465e3b9506a8a62a01984f57016d4a2bd43c417aab49679e5dd79daba0e1caa26f1f3ce84cf18a54260000013953b793f6fae2bab55d9ab9f8ae549285e768bd97b55e2720922a13c470084e0000013fe4d9c4934ce4be54bd7e7b988c600405efd8ff50c137f63c386f7eab596a0d"

https://github.com/PirateNetwork/piratewallet-light-cli/blob/master/coin-checkpoint.json
This file has newer checkpoints

https://github.com/PirateNetwork/piratewallet-light-cli/blob/master/coin-checkpoint.json
This file has newer checkpoints

Thanks @CryptoForge!
I also got other checkpoints from local debug log file of piratewallet-lite-cli lite client, and used them in the iOS wallet as well. Now wallet syncs up with network very quick! 👍
Here's relevant git commit link: https://github.com/Meshbits/ZcashLightClientKit/commit/e425414fdeb98f057cbd52602589e4add80d5189


Commands

This pull request adds the initial CLI implementation for Dodl using the Cobra framework. It includes the root command, create command, init command, and sets up the basic project structure to support future development.
Key Changes:

Added cmd/create.go to implement the create command, allowing users to create new documents with specified types, topics, and dates.
Added cmd/init.go to implement the init command, which initializes a new Dodl workspace.
Defined the root command in cmd/root.go to serve as the entry point for the application.
Added go.mod and go.sum for module and dependency management.
Created models/command.go to define the CommandContext struct, which standardizes data passing between commands and the core logic.
Updated main.go to execute the root command.

These additions form the foundation of Dodl’s command-line interface and establish the structure for further development.

This addresses most of https://github.com/matthewchivers/dodl/issues/5


Sammeluch/libgit2 CVE

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[ ] The toolchain has been rebuilt successfully (or no changes were made to it)
[ ] The toolchain/worker package manifests are up-to-date
[ ] Any updated packages successfully build (or no packages were changed)
[ ] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[ ] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[ ] All package sources are available
[ ] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[ ] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[ ] All source files have up-to-date hashes in the *.signatures.json files
[ ] sudo make go-tidy-all and sudo make go-test-coverage pass
[ ] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Change Log

Change
Change
Change

Does this affect the toolchain?

YES/NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX

Test Methodology

Pipeline build id: xxxx

Old PR: https://github.com/microsoft/CBL-Mariner/pull/8045

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/CBL-Mariner/pull/8092

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=514061&view=results


Plans to support influxdb 0.9.x?

Is anyone working on modifying chef-influxdb to support influxdb 0.9.x?
Thanks

Hey @rberger, could you elaborate a bit more on what you mean here? Are there backwards-incompatible changes you're anticipating? I'm not familiar with the 0.9.x release at present, I admit.

The Configuration file has changed some. I think that may be it.
I'm taking a stab at making it work. Will send a pull request if I get it to work. Hopefully make it work with pre and post 0.9.x, or will send questions if I can't make it work :-)
Trying to figure out how to set default[:influxdb][:config] differently for the different versions but still allow attribute overrides of components default[:influxdb][:config]  in wrapper cookbooks / roles, etc and make it backwards compatible.
Was mainly wondering if anyone else has tried to make the cookbook work before I get too deep in my own attempt.

Ahhh okay. Well yeah a PR would be super! There are no efforts on our front, anyway. Trying to think about the "feature flip" there, but I admit I'm out of ideas. I'll continue thinking about it today and report back if I've got an idea.

The major blocker for using this cookbook for 0.9.0 right now is the influxdb gem which most of the LWRP's are built on. It does not yet support 0.9.x. Source: https://github.com/influxdb/influxdb-ruby
Aside from a minor config issue, installing the 0.9.0 package & starting the service seems to work fine, but any of the other LWRP's that use the gem will probably be broken.
I know for sure that influxdb_database doesn't work - it returns "404 page not found" when trying to call get_database_list.  I wouldn't be surprised if the other resources have problems also with all of the API changes that were made.

influxdb/influxdb-ruby#77 should be closed soon, it might unblock support for 0.9.x

influxdb/influxdb-ruby#92 as been merged into master, so now influxdb-ruby should support 0.9.x .
Is there anything else blocker?

The 0.2.x versions of influxdb-ruby work with influxdb 0.9.x now, but the gem API was changed in the process.  https://github.com/SimpleFinance/chef-influxdb/pull/66 addresses additional changes in the LWRP's that would be needed.

Any updates?

+1

Hi everyone!
Happy to review that PR and will do so today. Apologies that it's been sitting there, my fault. In a strange twist, we don't actually use this cookbook or InfluxDB at all! We experimented with it (hence this cookbook), but never ended up deploying it. With that said, we could use a contributor or two if someone is interested in that role. If not, that works too, but review will be a bit slower. Sorry for the delay and thanks for understanding!

bleeding edge as far as I know supports 0.9.x. reopen if there are issues.


test: move to koji-osbuild-tests package

This is similar to how other osbuild packages are testing: everything
that's needed for testing is included in the tests package or a
dependency of it. The test runner then runs every executable in
/usr/libexec/tests/. This gives a simple test API to
projects depending on this package (notably osbuild-composer).
Note that because all tests are now installed, this commit breaks using
the same containers for rapid iteration local testing. Combining the two
use-cases was unfeasible for the time being. Tests can still be run
locally via building the package and using something like
osbuild-composer's tools/deploy-qemu (though with a larger iteration
time).

I think with a few tweaks we could support the local dev workflow.

You are absolutely right of course. I've changed it according to your suggestions and explained it differently in the commit. This makes it even simpler :)


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit b584024:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-10-11-04-00-52 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-10-11-04-00-52

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Use the atom-text-editor tag instead of the editor class.

In styles/git-plus.less: Use the atom-text-editor tag instead of the editor class.

Atom is moving to the .editor selector in future releases. Check out #537.

I have seen this from atom --dev as a deprecation warning.


oidc-kubeconfig-service image bump

Description
New fsnotify library image bump: #43
Changes proposed in this pull request:

oidc-kubeconfig-service image bump

Related issue(s)
See also: #43

/meow


fix a few spelling errors in README.md

:wave: just a few typo fixes

/ok-to-test
You have to sign the CLA

/ok-to-test You have to sign the CLA

Sorry about that. Should be good to go now.

/lgtm
/approve
Thanks