Missing API functions related to SpyCall

The following SpyCall API functions are missing:
spy.notCalled  # true if the spy was not called
spy.calledImmediatelyBefore(anotherSpy); # Returns true if spy was called before anotherSpy, and no spy calls occurred between spy and anotherSpy.
spy.calledImmediatelyAfter(anotherSpy); # Returns true if spy was called after anotherSpy, and no spy calls occurred between anotherSpy and spy.
spy.getCalls()  # Returns an Array of all calls recorded by the spy.
spyCall.calledOn  # Returns true if obj was this for this call.
spyCall.* # ... etc there are many more

spyCall.calledOn  # Returns true if obj was this for this call.

During the time I implement Sinon.py, I didn't implement any function related to scope(this), because the concept of scope between Javascript is totally different from Python. (JavaScript is a functional programming language, however, Python is a OOP language.)
For example:
In JavaScript, there is closure concept(without bind(this)):
Obj = {
    foo: function() {console.log("foo")},
    bar: function(runThisFunc) {runThisFunc()},
    baz: function() {
        this.bar(function() {
            this.foo()
        })
    }
}
{foo: ƒ, bar: ƒ, baz: ƒ}
Obj.baz()

You will got this error.
Uncaught TypeError: this.foo is not a function

However, in Python
class Obj:
    def foo(self):
        print("foo")
    def baz(self):
        def func(): self.foo()
        self.bar(func)
    def bar(self, run_this_func):
        run_this_func()

o = Obj()
o.baz()

It won't give any error.
Thus based on the difference between Python and JS, I didn't implement this feature.

The one I followed previously is not the newest version.
I have not checked other missing function precisely, but I am pretty sure the newest Sinon.js changed and added lots APIs. Since I contributed part of new version's SinonJS document.
Feel free to list those new features you think can benefit this library, I am willing to extend current library :)

Thus based on the difference between Python and JS, I didn't implement this feature.

That's a good point. Conversely, it makes sense to add some things to Sinon.PY, like kwargs. I will update the issue.

You are right, kwargs is a tricky thing in Python.
There are some part of my code need to be refactored about kwargs and args.
Because, for any function call of object, while it called by args, the first arguments will be object itself, later the arguments. On the other side, while it called by kwargs, the first arguments will be called argument.
For example:
class Obj(object):
   def func(a=0, b=0, c=0):
       pass
o = Obj()
o.func(1,2,3)
# args is (Obj, 1, 2, 3)
o.func(a=1, b=2, c=3)
# args is (Obj), kwargs is {'a': 1, 'b': 2, 'c': 3}

But, the above might meet some exception in some edge cases based on current implementation
I think there is a way to split args into 2 part, one for module/class, the other for pure args.
Also, this needs big efforts too, it impacts several places.


custom module not updating in SIGRTMIN

i have this custom module in my waybar:
"custom/screenshot": {
    "exec": "/home/carnager/.bin/test.sh",
    "on-click-right": '/home/carnager/.bin/test.sh delay",
    "return-type": "json",
    "interval": "once",
    "format": {},
    "signal": 9
},

the script being run is this:
#!/bin/bash
#
#
if [[ $1 == "delay" ]]; then
    pid=$(pidof waybar)
    foo="Sending signal to PID"
    jq -n --arg str "$foo" '{"text": $str}'
    kill -SIGRTMIN+9 "$pid"
    exit
fi

echo "{\"text\": \"foobar\"}"

The output of the script is as follows:
carnager@caprica ~ > ./test.sh
{"text": "foobar"}
carnager@caprica ~ > ./test.sh delay
{
  "text": "Sending signal to PID"
}

waybar debug log shows that it received the signal:
[2024-03-23 09:38:56.759] [debug] Received SIGCHLD in signalThread
[2024-03-23 09:38:57.676] [debug] Task (2) ./test.sh test [Alacritty] <Amif> changed
[2024-03-23 09:38:57.716] [debug] Task (2) zsh2 ~ [Alacritty] <Amif> changed
[2024-03-23 09:38:57.796] [debug] Received SIGCHLD in signalThread

However the module does not react to the signal at all. I expected it to change text to "Sending signal to PID"

I think it's not a bug of Waybar or related to the signal you send, I suspect it has to do with how the script output is buffered.
Possibly related to https://github.com/Alexays/Waybar/discussions/3046 or https://github.com/Alexays/Waybar/discussions/2358 (for a python script)

Also you have a typo in your sample config:
-    "on-click-right": '/home/carnager/.bin/test.sh delay",
+    "on-click-right": "/home/carnager/.bin/test.sh delay",


Grpc unary caching interceptor

Implement a generic caching interceptor for API entity caching, to be used form unary requests within api extension calls.

In review, rolling over to sprint 4


Best approach to keep the container warm

@tj what do you think of the best approach to keep the container warm, the cold start in my case took 8s to serve the first request.
i thought of a scheduler that run a request every x minutes, the problem is that i don't know how much time the container is kept before aws destroy it.
thank you.

AWS peep mentioned to me just pinging it on a cheap route. Every minute should be cheap/good enough.

Increasing the .lambda.memory can dramatically reduce the cold start for Node apps, all the require()s are pretty slow with 128mb.
Other than that you could use Cloudwatch Events to request every few minutes. Might bake that into Up at some point too if it's useful, Go app cold start seems negligible (~5000-800ms), no require()s though.
You could also try a JS bundler to mitigate that if you're not already.

@kaihendry i agree about using a cheap route, in my case, the route return a simple json.
@tj  i agree with you, in fact i tested but i observed that when the container is up my app use max 118mb, so it will help just in cold start but not in normal case plus it will increase the bills.
i will use Cloudwatch Events and see how it will behave
Thank you

+1 for more documentation on the cold start issue. Never new this was even an architectural issue with lambda until I started using up.
I ended up bumping my lambda functions memory to 1024mb and creating a cloudwatch event to trigger my functions every minute.
Everything is running very fast now.

@huangbong yea I'll add some more docs soon! It's typucally only really an issue for Java, and Node with tons of require()s. When creating the next.js example in up-examples I noticed it was significantly slower than the others as well, but I don't know the guts so I can't comment on why.

thought I had an issue already, but nope! Opened #361

should be https://github.com/apex/up/issues/577 not https://github.com/apex/up/issues/361 ? @tj

oops :D hahahah yes


extremely long wait time connecting to saved servers or executing simple queries and high system memory use

Issue Type: Bug
hello this is happening consistently regardless of which server I connect to using either Recent or Saved connections
Azure Data Studio version: azuredatastudio 1.26.1 (796abbdf5fdd341e3528e30a6b777c93e115eb02, 2021-02-24T23:42:55.085Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz (8 x 2304)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.69GB (0.96GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

import
Mic
1.2.0

powershell
ms-
2020.4.0

sql-prompt
Red
0.2.6

@Olga-B Thanks for opening the issue. Could you please elaborate the problem you're facing? What happens when you try to connect using Recent or Saved connections?

@abist Sorry for the delayed response.
It depends. Often it just hangs indefinitely.
Just now, I tried opening a new querying editor and connecting to a server using a recent connection and it's been "connecting" for 5 minutes. During that time I've opened a new query editor in SSMS, connected to the same server and ran use to connect to a staging db and then a simple select top 10 from a table. After another ten minutes or so, I got the following connection error from ADS: "TypeError: Cannot read property 'connectionProfile' of undefined"

I just tried connecting using a saved connection instead of a recent one and got the following error this time (log file attached):
An unexpected error occurred while connecting. Please [file an issue](command:workbench.action.openIssueReporter) with the title 'Unexpected Error Occurred while Connecting' and include the log file [C:\Users\OBlyumin\AppData\Roaming\azuredatastudio\logs\20210316T111806\renderer1.log](command:workbench.action.openLogsFolder)
renderer1.log

Hi @Olga-B, what authentication method are you using to connect to these DBs?

@cssuh Authentication Type is "SQL Login"

fwiw, the frequency of this issue comes and goes with no changes on my end. sometimes it is happening constantly with every new connection or after running one or two queries shortly after opening a connection. other times much more sporadically.

I also get problems where a simple query that should take less than one second to run may take several seconds before I get the result. I can do the same thing in SSMS and it's much faster there.

This issue has been addressed in the latest insiders build, updated here: https://github.com/microsoft/azuredatastudio/issues/7440#issuecomment-1692517196
Closing as resolved.


Size of Youtube icon

Description

The size of Youtube icon(in the footer section of main page) is not increasing  on hovering
Expected Behavior

Other icons (example Instagram and others) in the footer section are increasing in size when they are hovered. But only the Youtube icon is not increasing in size. I can increase the size of the icon so that it will look same as other icons in the vicinity .
I would like to work on this issue .Can you assign it to me?
Screenshots

Enviroment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Hey Can I work on this issue with @dhawansolanki under GSSOC 2023

Hey @Shreyans2004 , thanks for noticing it, pls resolve this issue


"Error: contract not deployed" when all indications say it is deployed

In a js test, I'm deploying a contract the same way I always do, but I keep getting "Error: contract not deployed" when I try interact with it.

The console.log ablove prints the contract object (fully populated, wallet, provider, bytecode, abi etc).
But as soon as I try fire a function against the contract, I get the error.

Ganache says a contract is deployed:

But no matter what I do it will not let me interact with the contract.
Project set up:
    "bignumber.js": "9.0.0",
    "dotenv": "8.0.0",
    "etherlime": "2.2.0",
    "etherlime-lib": "1.1.3",
    "ethers": "4.0.31",
    "solc": "0.5.10"

🤦♀Hadn't implemented all inherited functions. All gucci


[$1000] Chat - Context Menu - User can move emotion reactions row

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/18365
Action Performed:

Go to URL https://staging.new.expensify.com/
Login to ND.
Open any chat with a history of messages.
Right click on any message that is close to the header.
Click and drag on the context menu, specifically the quick emoji reactions row and ensure that the window does not move.

Expected Result:
Emoji reactions row and window does not move.
Actual Result:
User can move emotion reactions row.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/236939027-3d9abf55-9a94-44cc-a466-24c4e4ba2ef8.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ea82eb69ee3a04ea
Upwork Job ID:<PHONE_NUMBER>426883584
Last Price Increase: 2023-05-12

I am unable to reproduce:
https://github.com/Expensify/App/assets/38236554/363e3005-d2de-486d-9ac6-00a47bc4e3c1
@kbecciv are you still able to reproduce this?

Proposal
Please re-state the problem that we are trying to solve in this issue.
The reactions row (and other contents) in the context menu modal is drag-able even though it has the #no-drag-area id and shouldn't be drag-able.
What is the root cause of that problem?
The property -webkit-app-region in the code below doesn't prevent the user from dragging components, it only specifies that the region cannot be used to drag the window.
https://github.com/Expensify/App/blob/d516b637f64e6e487497a93a0f6694537c9cbca5/web/index.html#L37-L42
What changes do you think we should make in order to solve the problem?

To solve this problem we can use the property -webkit-user-drag. After this the content will still be drag-able if the text is selected first, to prevent this we can use the property user-select.
#no-drag-area {
    -webkit-app-region: no-drag;
    -webkit-user-drag: none;
    user-select: none;
}

What alternative solutions did you explore? (Optional)

An alternative solution would be to call the preventDefault() function on the mouseDown event on the modal.

@bfitzexpensify you can also try selecting text in the context menu to reproduce this. I believe the reaction bar is being selected somehow after which it becomes drag-able (explained in my proposal).
Screencast from 09-05-23 10:18:32 PM IST.webm

@huzaifa-99 sorry I didn't get you. I applied it to anything with the id #no-drag-area so this fixes other components that have similar issues, consequently these properties also apply to the components descendants that includes the reaction row as well as the text below it.

Yep, after trying this a bunch, I was eventually able to reproduce.

I don't think this is a bug or something that we should be concerned about. Anything that is selectable is dragable.
@thienlnam @bfitzexpensify Can we close this?

I think I agree, it doesn't seem like a significant issue. Happy to close if you are @thienlnam

Let's close this out


Error in data, Nevada on 2/11

For Nevada on 2/11, the people_tested field has some invalid characters ("221343â€¬")

Yep, I get this too in some Python code of mine:
ValueError: could not convert string to float: '221343\u202c'

There is a UTF-8 encoded Unicode Character 'POP DIRECTIONAL FORMATTING' (U+202C) after the number, for some reason.


[C-1814] Add a new role "User"

user feedback
right now, there is only view-only and admin as roles but something in the middle like "view & enrich & create/edit tasks" would be cool to have, for example. Admin seems to have access to integrations etc. which is not ideal but we'll do it for now.
Suggestion
Add a new role called "User" (besides "Read-only" and "Admin").
Users will be able to:

View all parts of the app (all permission of "Read-only")
Enrich members
Create/edit tasks
Create/edit notes
Create/edit automations
Invite other users
Use Eagle Eye

User won't be able to:

Edit integrations
Change plan

From SyncLinear.com | C-1814

@jonathimer can you please assign this to me? Thanks!

Hi @jonathimer @Ashutosh-Bhadauriya, let me know about the progress and if I could be of any help in creating it! Cause won't want to create a pull request causing conflicts!
Also, could you elaborate a little on what you mean about users not able to "change plan", like what plan are we talking about here, most probably not a subscription fee?
Also, I am new to the repository, I am covering the contributing.md, but to get a quick/indepth view of how things are working in crowd.dev, are there any new launches or new update videos covering the UI/UX structures and if you could point me to the same?
Thanks(pardon for the tags)

@Bhardwaj-Himanshu you can take this, I am facing issues setting up the project locally

Let me help you with the problems in setting up the project @Ashutosh-Bhadauriya, let me know if there is something I could do to help!
Meanwhile, pardon for the retag but as me also being new, could you also mention the lines in code or example that are in creation of a new role of any kind in the codebase so that I have a reference of what is being asked and how to implement it here? @jonathimer


fix: Upgrade wrangler used for the install proxy

@richtera @Wolmin @Hugoo Before merging, we should update https://github.com/lukso-network/tools-lukso-cli/blob/main/CHANGELOG.md for this

@richtera @Wolmin @Hugoo Before merging, we should update https://github.com/lukso-network/tools-lukso-cli/blob/main/CHANGELOG.md for this

The changelog should be managed by release-please.


Build for x86_64-linux-android with generated/unix/ code

This enables building for x86_64-linux-android targets, which is particularly useful for running under an Android emulator.
For reference here I first explicitly ran structgen (built for x86_64-linux-android to with the latest r25 Android NDK toolchain) on an Android emulator and compared the output to the existing generated/unix/ code, which was identical.
This was how I double checked the output of structgen cross-compiled for x86_64-android-linux on an Android emulator:
export ANDROID_API_LEVEL=31
export ANDROID_ARCH=x86_64 # | i686
export ANDROID_ABI=x86_64 # | x86
export HOST_OS=linux # | windows
export EXT="" # | .bat

"$ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/$HOST_OS-x86_64/bin/clang++" \
    -DANDROID \
    --target=$ANDROID_ARCH-linux-android$ANDROID_API_LEVEL \
    -std=c++14 \
    -DNDEBUG \
    -DPX_PHYSX_STATIC_LIB \
    -static \
    "-I" "physx/physx/include" \
    "-I" "physx/pxshared/include" \
    "-I" "physx/physx/source/foundation/include" \
    "-o" "./structgen" "src/structgen/structgen.cpp"

# Install emulator via Android SDK
$ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager$EXT --update
$ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager$EXT "system-images;android-$ANDROID_API_LEVEL;default;$ANDROID_ABI"
$ANDROID_HOME/cmdline-tools/latest/bin/avdmanager$EXT create avd -n pixel_4_$ANDROID_ABI -k "system-images;android-$ANDROID_API_LEVEL;default;$ANDROID_ABI" -d pixel_4

$ANDROID_HOME/emulator/emulator -avd pixel_4_$ANDROID_ABI -no-window

adb push ./structgen /data/local/tmp/structgen
adb shell "cd /data/local/tmp && ./structgen"
adb pull /data/local/tmp/{structgen_out.hpp,structgen_out.rs} .

Changelogs please, then I think we're G2G!


how do i make another peer?

i would like to use this script on 2 pcs and cant seem to do that
1 peer forwards the ports
and the 2nd one dosent

but currently the script accepts only 1 client on the server side i want it to have 2 client configs is that possible?
thanks for answering btw :)

No, but you can use the same client credential on multiple device.

Now the script supports multi peers, however you need to tell the port range to forward when creating a peer.


Add Man0sh-r0y

Adding My GitHub  Man0sh-r0y to the README

Just forgot to follow the Alphabetical Order.  That's why I closed it


ISPN-5474 Transactions created when applying state should never be re…

…plicated
https://issues.jboss.org/browse/ISPN-5474
Add an explicit check for state transfer transactions in
BaseRpcInterceptor.shouldInvokeRemotely.

Please integrate on the 7.2.x branch as well.

Pulling...

Integrated into master & 7.2.x, thanks @danberindei !


While configuring company communicator we are getting errors

Hi @chethankumarsg ,
Thanks for raising the query. The screenshot shows the multiple deployment failures.

Could you please share the details of the error.
What are the resources that are failed in the latest deployment?

Please check the detailed error screen shot for the same.

@chethankumarsg , please open this

Please find the requested screenshot

Please find the resource details...

Please find the above screenshots for the requested details.

Hi @chethankumarsg ,
Thanks for sharing the relevant screenshots. There are two issues observed.

First issue is roleassignment one. For this please utilize this link to generate 7 new guid's. Click on re-deploy option, keep all the parameters as it is and update the last 7 parameters with new guids and go for re-deployment again. This will solve the role assignment issue.

There are two other resources prep-function and data-function got failed. Caution- First perform the above step related to role-assignment issue and then perform the below steps.
To overcome the failed resources, Go to azure portal-->Go to resource group(Where the deployment has been done)-->Select prep-function(or failed resource) from list of resources-->Go to Deployment Center-->Click on Settings. Below is the screenshot for reference.

If the resource is not pointing to intended repository and  showing empty. Please connect to the external Git and point to the official repository(like above)
Once the status turns to Success(active) in the logs section then good to proceed with remaining steps of deployment.
Please do the same for other failed resource as well.
After performing the above steps, don't attempt for re-deploy again

We are working on this we will update the status.

Please find the screen shot for your reference

Hi @chethankumarsg ,
Once you update the last 7 guid's that you highlighted and re-deployed, any resources got failed?

guid's are created
Please find the details below
1caf4285-b5eb-4e81-8704-059f238c9705
a21e4d65-424d-4889-83aa-a5e24bca4b03
12e1cdc7-3c27-4428-8dab-a3a5aab0c72e
a2e3f433-08a9-4d37-b235-366118b4eb60
125dbfbd-dc4f-4b59-b661-745e08974c02
4d14f17d-8c0e-433d-bcca-66816e3a590d
5016c767-066b-4bf3-87ed-36a688d70dd7

Can i get any update on this one.

After adding the newly generated GUID's in the template, any resources got failed in the redeployment?

We are checking with our internal team will update you

“Yes, we have seen the one Key vault resources fail we have seen the error like conflict and duplicate. So we have removed all the resources in the resource group and re-deployed from scratch onwards. After re-deploying with our new GIUDs and again  we are facing the errors, which we have already shared with you”

No, after deploying the resources with new GUID's I dont see any screenshot containing failed resources. Could you please share them

We are working on this, we will let you know the status.

Please keep us posted

we are working on this we will update you

Can we connect

Could you please share the details of the error here that you are encountering

“Yes, we have seen the one Key vault resources fail we have seen the error like conflict and duplicate. So we have removed all the resources in the resource group and re-deployed from scratch onwards. After re-deploying with our new GIUDs and again we are facing the errors, which we have already shared with you”
We dont have the error screen shot

can i get any update on this

Hi @chethankumarsg ,
Please change the base resource name and do the deployment. Keep us informed


In which currency is price set?

Listing configuration doesn't inform how price is set.
If I set a price in USD, will it stay in USD or will it be converted to BTC and vary its price in USD according to market price?
Shouldn't both these options be available?

The price set in the listing will always be the price.
If the price is set in a fiat currency, it will be the converted to BTC at the time of purchase.
ie: if you set a listing to be $100 USD, when that item is purchased the equivalent amount of BTC will be paid, based on the conversion rate at that time.

This information should be displayed on edit listing page. User should also be able to set his listing prices in BTC while OB is set to display prices in fiat currency (without having to change his OB currency in settings).

FWIW, in v2 this is the case - you are able to specify the currency when creating / editing a listing.

I believe the API allows setting the currency per listing, so it would be possible to change the v1 client to do that.


Debug firefox stuttering issues

This branch creates some logging for the web build that will help to root cause the stuttering issues in firefox that were reported on discord.

If the stuttering is happening only on Windows and you're using WebGL to output your image, I would suggest replacing the WebGL context with an HTML5 Canvas instead as a worst case scenario. I know it sounds silly, but the level of abstraction WebGL can go through can sometimes be much greater than HTML5 Canvas even despite supposedly being a hardware API. (See ANGLE and Chrome as an example of what this means - https://en.wikipedia.org/wiki/ANGLE_(software) )
That being said, if you need anyone to produce profile data for you, feel free to ping me! :) Good luck on this problem, I know you can figure it out!!!

This was debugged to be because of firefox truncating timers to 100ms resolution when the experimental browser fingerprinting prevention feature was enabled.


Callback for writing predictions

🚀 Feature
Add a callback to log the predictions of the model in the evaluation stage.
Motivation
When someone is developing a model, it can be helpful to look at its predictions. It can be pretty wasteful to run predictions during evaluation (generation for thousands of examples with a very large model) and then run the exact same model once again using a different script to get those predictions. I suggest logging the predictions after each evaluation loop.
Pitch
Sometimes aggregated metrics are not enough and we need to see with our own eyes what our models predict. Can you please add a tool that will allow us to do that during training?

@yuvalkirstain How did you imagine this feature to be used?

@yuvalkirstain Would something like this work for you? It is hard to generalize this, because outputs can be of varying types, but with extending this existing callback you should be ready to go pretty fast :)

@mathemusician Thanks for the help! :)
How the feature should be used:
I'd like to pass an argument as to which predictions should be saved, similarly to which checkpoints should be saved. For example, I want to save only the predictions from the validation epoch in which the model performed best, or I want to save the predictions from all validation epochs. Then, I will be able to access those predictions and know their corresponding step/epoch (similarly to the way we can access the saved checkpoints).
If we consider only text-to-text models (like GPT and T5) it should be easy to aggregate their inputs and predictions during validation and then to save those predictions. For example, if we consider translation, the compute_generate_metrics function is a good place to add the inputs and predictions, and after the validation epoch ends it can automatically save those predictions.
@justusschock Thanks for the help! :)
Is there an existing example that uses this class to log predictions that are generated during validation? I am not sure how to extend this base class for my purposes.

@yuvalkirstain I am not sure if we have an official example other than the one given in the documentation I linked. I am afraid, that it currently only supports predictions generated with trainer.predict because the indices of the current batch are not available during validation.
If you have your own logic on how to calculate them, you could use something like this however:

class ValidationPredictionWriter(BasePredictionWriter):
        def on_validation_batch_end(
            self,
            trainer: "pl.Trainer",
            pl_module: "pl.LightningModule",
            outputs: Optional[STEP_OUTPUT],
            batch: Any,
            batch_idx: int,
            dataloader_idx: int,
        ) -> None:
            """Called when the validation batch ends."""
            if not self.interval.on_batch:
                return
            # TODO: replace ... with your custom logic or None if you don't need this for saving.
            batch_indices = ... # originally: trainer.predict_loop.epoch_loop.current_batch_indices
            self.write_on_batch_end(trainer, pl_module, outputs, batch_indices, batch, batch_idx, dataloader_idx)

Such custom logic could for example be to include the batch indices in your batch.

@justusschock Thank you so much for this suggestion! I will sometime soon probably try to add it to my script. If it will work well I will post it here and close the issue.

We implemented it and it was easier than we thought. Thanks of much for the help. I'm posting it here in case someone will want to use it :)
class PredictionWriter(BasePredictionWriter):
    def __init__(self, dir_name: str, write_val_preds: bool):
        super().__init__()
        self.val_out_file = None
        self.write_val_preds = write_val_preds

        if self.write_val_preds:
            self.val_output_dir = Path(dir_name) / "val"
            os.makedirs(self.val_output_dir, exist_ok=True)

    def on_val_batch_end(self, trainer, pl_module, outputs, batch, batch_idx, dataloader_idx):
        if self.write_val_preds:
            _write_outputs(self.val_out_file, outputs)

    def on_val_start(self, trainer, pl_module):
        if self.write_val_preds:
            self.val_out_file = open(self.val_output_dir / 'val_preds.jsonl', 'w')

    def on_val_end(self, trainer, pl_module):
        if self.write_val_preds:
            self.val_out_file.close()

def _write_outputs(out_file, outputs):
    for output in outputs:
        out_file.write(json.dumps(output) + "\n")


test: clean and sort snapshots

While doing #902 I realised we've got a couple of packages using snapshots but not cleaning them up afterwards - this changes that; I've also opened #903 adding a script to check all packages using snapshots are cleaning them.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.17%. Comparing base (ca67f63) to head (e482d41).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
- Coverage   63.37%   63.17%   -0.21%
==========================================
  Files         145      145
  Lines       11883    11883
==========================================
- Hits         7531     7507      -24
- Misses       3885     3907      +22
- Partials      467      469       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Generate BAML schema from pydantic schema

Is is possible to generate BAML supported typescript schema from standard json/pydantic schema. If yes, how can we do that. I wasn't able to figure it out from doc and codes.

We continued the discussion on this reddit thread: https://www.reddit.com/r/LocalLLaMA/comments/1esd9xc/comment/lidjile/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
Closing the comment!


CesiumTileMapServiceRaster load TMS false  v1.81

I can load TMS in V1.70  but V1.81 only show Color fast , not show Image ,please help Me    MinLevel:0, Maxlevel:17, Material Layer Key:Overlay1, space Errow:2 Texture Size:512 or 2048 , Tile Loads:20, Cache Bytes:16777216 .Output log has no error.Please Help me .thank!

@yuanlei88 I tried two TMS tilesets with these URLs, and both worked correctly in v1.8.1:

https://sandcastle.cesium.com/images/cesium_maptiler/Cesium_Logo_Color/tilemapresource.xml
https://sandcastle.cesium.com/CesiumUnminified/Assets/Textures/NaturalEarthII/tilemapresource.xml

I'm not quite sure what you mean by "only show Color fast , not show Image", so it may help if you can provide some more details. If it's possible for us to try out your actual TMS server, that would be the quickest way to see what is going wrong.

<TileMap version="1.0.0" tilemapservice="http://tms.osgeo.org/1.0.0">
<Title>R-CN-JSCZS-2020-1M</Title>
<SRS>EPSG:3857</SRS>
<BoundingBox miny="3652828.486212716" minx="13261824.407478109" maxy="3771661.834271001" maxx="13380148.927263588"/>
<Origin y="3652828.486212716" x="13261824.407478109"/>
<TileFormat width="256" height="256" mime-type="image/png" extension="png"/>
<TileSets profile="global-mercator"/>
<TileSet href="0" units-per-pixel="20037508.34" order="0"/>
<TileSet href="1" units-per-pixel="10018754.17" order="1"/>
<TileSet href="2" units-per-pixel="5009377.085" order="2"/>
<TileSet href="3" units-per-pixel="2504688.5425" order="3"/>
<TileSet href="4" units-per-pixel="1252344.27125" order="4"/>
<TileSet href="5" units-per-pixel="626172.135625" order="5"/>
<TileSet href="6" units-per-pixel="313086.0678125" order="6"/>
<TileSet href="7" units-per-pixel="156543.03390625" order="7"/>
<TileSet href="8" units-per-pixel="78271.516953125" order="8"/>
<TileSet href="9" units-per-pixel="39135.7584765625" order="9"/>
<TileSet href="10" units-per-pixel="19567.87923828125" order="10"/>
<TileSet href="11" units-per-pixel="9783.939619140625" order="11"/>
<TileSet href="12" units-per-pixel="4891.9698095703125" order="12"/>
<TileSet href="13" units-per-pixel="2445.9849047851562" order="13"/>
<TileSet href="14" units-per-pixel="1222.9924523925781" order="14"/>
<TileSet href="15" units-per-pixel="611.4962261962891" order="15"/>
<TileSet href="16" units-per-pixel="305.74811309814453" order="16"/>
<TileSet href="17" units-per-pixel="152.87405654907226" order="17"/>
</TileMap>
  For reasons of confidentiality, I cannot provide you with the address, please forgive me, here is the content of my loading image and xml above, please help me!
------------------ 原始邮件 ------------------
发件人:                                                                                "CesiumGS/cesium-unreal"                                                                                @.>;
发送时间: 2021年12月10日(星期五) 晚上6:19
@.>;
<EMAIL_ADDRESS>主题: Re: [CesiumGS/cesium-unreal] CesiumTileMapServiceRaster load TMS false  v1.81 (Issue #705)
@yuanlei88 I tried two TMS tilesets with these URLs, and both worked correctly in v1.8.1:
https://sandcastle.cesium.com/images/cesium_maptiler/Cesium_Logo_Color/tilemapresource.xml
https://sandcastle.cesium.com/CesiumUnminified/Assets/Textures/NaturalEarthII/tilemapresource.xml
I'm not quite sure what you mean by "only show Color fast , not show Image", so it may help if you can provide some more details. If it's possible for us to try out your actual TMS server, that would be the quickest way to see what is going wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

I can't see anything wrong with your tilemapresource.xml. Also, very little changed in the TMS support between v1.7.0 and v1.8.1. You can see all the differences here:

https://github.com/CesiumGS/cesium-native/compare/v0.9.0...v0.10.0 (then click Files Changed, then 121 changed files, then Cesium3DTilesSelection/src/TileMapServiceRasterOverlay.cpp)
https://github.com/CesiumGS/cesium-unreal/compare/v1.7.0...v1.8.1 (then click Files Changed, then 34 changed files, then Source/CesiumRuntime/Private/CesiumTileMapServiceRasterOverlay.cpp

If you can't share the problematic TMS (even if it's a different one that exhibits the same problem), there's not much to go on here, so I'm not sure I'll be able to help. Maybe try some basic diagnostics:

Are you sure the only thing that changed when it went from working to not-working was the Cesium for Unreal version?
What kind of tileset are you attaching the overlay to? Does the overlay work on other tilesets (such as Cesium World Terrain)? Do other overlays work on this tileset?

Also I still don't know what you mean by "color fast", so I'm not even clear on what problem you're actually seeing.

http://<IP_ADDRESS>:3001/image/tms/2104da80566311ec8869e5ab91863e49/tilemapresource.xml
---Original---
From: "Kevin @.>
Date: Fri, Dec 10, 2021 19:55 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [CesiumGS/cesium-unreal] CesiumTileMapServiceRaster load TMSfalse  v1.81 (Issue #705)
I can't see anything wrong with your tilemapresource.xml. Also, very little changed in the TMS support between v1.7.0 and v1.8.1. You can see all the differences here:
@.*** (then click Files Changed, then 121 changed files, then Cesium3DTilesSelection/src/TileMapServiceRasterOverlay.cpp)
v1.7.0...v1.8.1 (then click Files Changed, then 34 changed files, then Source/CesiumRuntime/Private/CesiumTileMapServiceRasterOverlay.cpp
If you can't share the problematic TMS (even if it's a different one that exhibits the same problem), there's not much to go on here, so I'm not sure I'll be able to help. Maybe try some basic diagnostics:
Are you sure the only thing that changed when it went from working to not-working was the Cesium for Unreal version?
What kind of tileset are you attaching the overlay to? Does the overlay work on other tilesets (such as Cesium World Terrain)? Do other overlays work on this tileset?
Also I still don't know what you mean by "color fast", so I'm not even clear on what problem you're actually seeing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Thanks! I can confirm this is working in CesiumJS, but not in Cesium for Unreal. I'll investigate.

(by the way, by replying to my email you've posted the link to a public github issue. You may want to visit github and delete it.)

Ok, I think I see the problem. I'll work on a proper solution, but here's a workaround in the meantime: set the "Maximum Screen Space Error" to a much smaller value. Setting it to 0.01 looks about right to me. You'll need to set it back to 2.0 after the bug is fixed.

Just to be clear, set the "Maximum Screen Space Error" property on the TMS overlay, not the Tileset!

Thanks for helping me reproduce the problem @yuanlei88. I opened CesiumGS/cesium-native#414 to fix it.
Our build server is building a version of Cesium for Unreal with the change now. Keep an eye on https://app.travis-ci.com/github/CesiumGS/cesium-unreal/builds/243257310 and when it's complete, you can download the build by visiting https://github.com/CesiumGS/cesium-unreal/tree/non-global-lod, clicking the green tick near the top, and then clicking the "Details" button next to either UE4.26-AllPlatforms or UE4.27-AllPlatforms. Then exctract the zip file to C:\Program Files\Epic Games\UE_4.26\Engine\Plugins\Marketplace or equivalent. If you changed "Maximum Screen Space Error", change it back before installing this build!

   Thank you very, very much for your help


Minor changes to create-app check

This commit contains the following changes:

Test http response of route instead of service IP.
Test project creation using the project-request template.

https://jira.coreos.com/browse/SREP-2277
https://jira.coreos.com/browse/SREP-1859

I tested unique project creation and project/pod name lengths. I don't think there's much room for naming collisions, given that the datestamp now includes seconds. And there is a unique ID for each namespace (in the event that multiple namespaces are created in the same second).
<EMAIL_ADDRESS>~]# oc get pods --all-namespaces |grep sre-app
sre-app-check-20191025-235425-hj   build-20191025-235425-hj-1-5kxh5                 1/1       Running     0          3m
sre-app-check-20191025-235745-uk   pull-20191025-235745-uk-1-vxt7x                  1/1       Running     0          6s


[Loc] update to arc and sql-migration.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 42.448%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26739

Relevant Lines:
57058

💛  - Coveralls


Assign appropriate result type

Summary
Details and comments
Fixes #499, Fixes #493

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

24 of 30 (80.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 63.92%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/estimator_result_decoder.py
9
11
81.82%

qiskit_ibm_runtime/runtime_job.py
4
6
66.67%

qiskit_ibm_runtime/sampler_result_decoder.py
9
11
81.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
3118

Relevant Lines:
4878

💛  - Coveralls

I just noticed that https://github.com/Qiskit/qiskit-ibm-runtime/issues/493 is a duplicate of https://github.com/Qiskit/qiskit-ibm-runtime/issues/362. Does this PR close https://github.com/Qiskit/qiskit-ibm-runtime/pull/455? The latter was opened to fix #362 .

https://github.com/Qiskit/qiskit-ibm-runtime/pull/455 has specialized code to covert the mitigation overhead from mthree to the standard deviation upper bound. Is that handled correctly here?

I just noticed that #493 is a duplicate of #362. Does this PR close #455? The latter was opened to fix #362 .

Just noticed this too, #455 handles #493 and I'll have this PR just take care of #499

@t-imamichi can you take a look? #455 is causing the integration tests to fail

Thank you for fixing the issue related to my PR. It looks good.

I'm not familiar with the decoder part, but the other part looks good.


Theme: Allow to set up theme to follow system theme.

Currently it only works when the change of the theme in application occurs
(or when the application starts) as WPF (probably) doesn't have any event exposed
to react when the change occurs in real time.
This (probably) closes #898

Have you tried to listen to SystemEvents.UserPreferenceChanged ?

@NickeManarin Yes, It's been firing multiple times with no info about the theme, but maybe with the regestry reading it could be done. Let me re-check that again.

@NickeManarin actually it worked. I was looking for something like ThemeChanged info in UserPreferenceChangedEventArgs but it was all the time General. But with this event and reading the registry application is reacting real time to theme changes.

Thanks.


Crash while placing ME conduit

Is there an existing issue for this?

[x] I did not find any existing issues.

Current Behavior
Game crashed while placing ME conduit. Rejoined the game and placed in the same location without another crash.
Expected Behavior
No crash
How to Test

hold ME conduit in off hand
Vibrant conduit in main hand
place against floor in a line

Local Environment

Operating System: Windows
Java version: 17.0.8
Minecraft Version: 1.20.1
Version: 6.2.1-beta
Other Mods: Monifactory mod pack. AE2 and EnderIO relavent

Any Additional Information?
Havent been able to reproduce, but I thought the log might be useful.
https://bytebin.lucko.me/rV2vojbUDS

You wouldn't happen to have the full game log for when this happened, would you?

2024-10-29-1.log.gz
Crash at around 21:05. Hope that helps


chore: added pluraization helper

So I pulled the pluralization into a helper as suggested in #216. However I couldn't find a way to test this natively without "mocking" it out. It seems plugins are registered/used during the test runs so I have to do some hacks to mock out the defined helper. I'm not very familiar with Nuxt so do you know a way around this? I searched and this is the only solution I've found so far.
Thoughts?

Yeah, if we go the plug in route for this, it’s definitely going to need to be mocked. I’ll think on this some more and get back to you. Thanks for working on it!

This is great! Made some very minor adjustments and updated the multi-search input component to use the helper.


:swapname prints different string at different occasions

What steps will reproduce the problem?

1. % vim -u NONE -U NONE --noplugin
2. :edit a_file.txt
3. :swapname           -> prints ".a_file.txt.swp"
4. :q!
5. % vim -u NONE -U NONE --noplugin a_file.txt
6. :swapname           -> prints "/home/user/.a_file.txt.swp"

What is the expected output? What do you see instead?

Prints the path of the swapfile as relative or absolute path, depending on when
I called the command. Since I use the output in a script, it would be nice if
the output would be consistent.

What version of the product are you using? On what operating system?

Both Vim 7.2 and Vim 7.4 on Linux.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 23 Apr 2015 at 1:06

After all, you can easily work around it so it's not a big deal.

Yes, it can easily be worked around:
:echo swapname('%')->fnamemodify(':t')

See:

:h swapname()
:h fnamemodify()


Diann update

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

LFQ is failing @daichengxin

Weird, seems to work now. Conda hiccups are normal though.

@jpfeuffer Can I merge now and convert your comments into issue ;)

Yes:

MSstats TMT weird code and import of MSstats
Changelog and docu
double check usage of empirical vs insilico library in module descriptions

#183 issue created by @jpfeuffer


Install Error: "alsa/asoundlib.h: No such file or directory"

terry@zeus:~$ go install github.com/ayoisaiah/focus/cmd/focus@latest
github.com/hajimehoshi/oto
go/pkg/mod/github.com/hajimehoshi/oto@v0.3.1/driver_linux.go:23:10: fatal error: alsa/asoundlib.h: No such file or directory
23 | #include <alsa/asoundlib.h>
|          ^~~~~~~~~~~~~~~~~~
compilation terminated.
terry@zeus:~$

Hi, you will need libasound2-dev package to compile.
From package README

Thanks @nandalopes will add to the readme.
@tmack8080 Please install the required library.


Gets Rid of Startup Screen

[X] Did you check Readme and existing issues?

Describe the bug
Gets rid of the neovim default startup screen. Doesn't really completely gets rid of it, but it looks like it creates a buffer on top of it once neovim opens.
To Reproduce
Steps to reproduce the behavior:
Config:
return {
  "smoka7/multicursors.nvim",
  event = "VeryLazy",
  dependencies = {
    "nvim-treesitter/nvim-treesitter",
    "smoka7/hydra.nvim",
  },
  opts = {
    hint_config = false,
  },
  cmd = { "MCstart", "MCvisual", "MCclear", "MCpattern", "MCvisualPattern", "MCunderCursor" },
  keys = {
    {
      mode = { "v", "n" },
      "<leader>m",
      "<cmd>MCstart<cr>",
      desc = "Create a selection for selected text or word under the cursor",
    },
  },
}

Open up neovim.
Expected behavior
Opens up neovim in the default startup menu.
Screenshots
Behavior with plugin:

Without plugin:

Nvim version:
0.9.1
Multicursor version:
Latest

Found out that this is caused by event = "VeryLazy"


Dockerfile-based application breaks with "dokku restart" -- 502 Bad Gateway

It seems that the ports aren't forwarded correctly after a "dokku restart" of a Dockerfile based application.
Steps to reproduce:

Clone dokku-alt-phpmyadmin revision 3aa68c6b60e984f9821ded1fa29d4bcd6961ab3c (due to upstream bug ayufan/dokku-alt-phpmyadmin#1)
Push to dokku
Confirm that the application is running and phpmyadmin is accessible
Run dokku restart phpmyadmin
Notice that the app is unreachable now, 502 Bad Gateway -- also notice that the entrypoint (php) is actually up
Run dokku rebuild phpmyadmin
Application works again

On step 4 dokku calls docker restart -- by executing the docker restart command manually we have the same issue.
Whose bug is it? Dokku doing something wrong on restart, or docker not starting the application correctly?

i observe the exact same behaviour with app that relies on buildpack (ruby one), not Dockerfile
after each deploy or manual restart i need to run rebuild for the app to start up properly
any clues?
thanks


chromium: 57.0.2987.133 -> 58.0.3029.110 + build fixes

Motivation for this change
Security upgrades.
Things done
Updated versions and fixed the build for linux x86-64
Unfortunately, there were two build breakages from 57 -> 58.
One of them is about the bootstrapped gn, built during chromium's build. The following patch is needed, until the fix in master has come downstream to stable: https://github.com/NixOS/nixpkgs/commit/bafcf4226ead4a6bdc5d652164e4d18509af35a7
The other one is about nodejs, which is used during the build to generate stuff. There is a script to download .../bin/node but it doesn't seem to work (anymore ?) in our build. Failing to get a response from chromium devs, I just tried softlinking our node binary into the build tree and it actually works: https://github.com/NixOS/nixpkgs/commit/1fe7bd9ed6a5dd780e4991241b75fc0640576b2b
There are two open issues with this, though:

[ ] is this solution durable?
[ ] does the build work in linux x86-32

cc @aszlig

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

If nobody got any better ideas, please get this merged and cherry-pick it to stable as well. We need to keep our users protected.

Merging, given lack of feedback of any kind from maintainers until now. Thank you


feat(app-cmds): support min/max length for string options

Summary
This adds support for the newly added min_length and max_length fields in Slash Command options.
More information about this: https://github.com/discord/discord-api-docs/pull/5143
Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.
[ ] I have run task pyright and fixed the relevant issues.

[ ] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

_ApplicationCommandOptionOptional in nextcord.types might need to be updated


Lensflare playground demo is broken

Describe the bug
Lensflare seems to be broken on v4
Cannot destructure property 'registerCamera' of '(intermediate value)(intermediate value)(intermediate value)' as it is undefined.

Reproduction
Run local playground
Steps to reproduce
No response
System Info
System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M1 Pro
    Memory: 51.02 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 8.15.4 - ~/Library/pnpm/pnpm
    bun: 1.0.2 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 125.0.6422.142
    Safari: 17.5
  npmPackages:
    @tresjs/core: 4.0.0-rc.2 => 4.0.0-rc.2
    @tresjs/leches: ^0.14.0 => 0.14.0

Used Package Manager
pnpm
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

I think this is a problem with nodeOps in the core:
      const { registerCamera } = child?.__tres?.root as TresContext;

The optional chaining (?) signals that one might expect undefined is sometimes returned. undefined can't be destructured:
$ node
> { foo } = undefined
Uncaught TypeError: Cannot destructure property 'foo' of 'undefined' as it is undefined.

On the team Discord, @garrlker and I were just briefly talking about passing in context in order to factor out some of this optional chaining and long lookups.
I'll go ahead and open a PR for that refactor today. It should fix this issue.

There wasn't a camera in the demo and that made v4 nodeOps throw.
It'd be great if we always had a dummy camera.

I'll close this one, if this is not complete please feel free to re-open @andretchen0


Typescript in v5?

Is your feature request related to a problem? Please describe.
According to #2648 (which I can't comment on due to lock), it looks like there's some consensus with moving RBP to typescript! But, unless I'm missing it, I don't see any branch started.
Describe the solution you'd like
I'm just wondering where I can follow the typescript progress and/or contribute. Very much looking forward to it.
Describe alternatives you've considered
@Can-Sahin's Fork
Additional context
Add any other context or screenshots about the feature request here.

Not aware of any Typescript branches either.
Personally I'm still ambiguous on Typescript, in part because it makes the learning curve even bigger.
I like the idea of a fork so that it keeps it optional. How up-to-date is the TS fork? Can we start by upgrading that?

TS fork is currently ahead of the master. I couldnt wait styled components v5 and merged the dev with my master to get the hooks and stuff. So its fully up to date. There are all the tests in TS. Only missing thing is immer which I still intentionally dont use coz of readonly alternatives in TS. But easy to implement. So its fully  TS fork for now. You can easily merge it.
Personally TS makes learning curve bigger but overall development faster. Now I cannot write any js code. Without ts I feel like without any limbs. Its so faster to refactor the code build things that I dont look at weeks and can comeback and implement bug free features right away. TS is definitely a MUST for projects more complicated than 2-3 page web apps for me. It makes the whole process easier. We switched fully into TS in my company thats the reason I wanted to make a TS fork.

TS can be optional, it should run only if you have TypeScript files, otherwise it is still JS. And I agree with previous comment, you need TS if you create something bigger than landing page. It is one of the leading languages nowadays.

Yeah currently its optional, its extra layer transpiling layer. . Js code works as normal. I just dont write it anymore :)

There are several problems with maintaining a fork though.
One of them is the fact that certain design decisions that make sense with the absense of strict typing, don't quite hold up when looked at through the prism of TypeScript. That leads to increased difficulty in merging, when the upstream updates (one example) and holds the fork back.
Another thing to keep in mind: the purpose of the fork (according to GitHub guidelines) is to be eventually merged into the upstream, otherwise there's no reason to keep a fork status on a project. While said status is in effect though, the work of the contributors does not show up on their profile page correctly (since it's expected to be merged to the upstream), which is a bit discouraging.
The solution would be to remove the fork status, but, returning to this specific discussion, for the main TS fork of this project that would only make sense if there was a clear concensus on the future of upstream being JavaScript.
I assume the decision would be collectively made by the core project members, so I'm looking forward for the contunuation of this discussion.

That makes a lot of sense. IMO we have two options going forward:

Merge the fork into react-boilerplate and have it become the official project. With TypeScript optional.
Make it an official but separate project in the react-boilerplate organization.

Thoughts?

Merge the fork into react-boilerplate and have it become the official project. With TypeScript optional.

Merge as in create separate branch for TypeScript? Or actually merge into master, with allowJs: true in tsconfig.json?

Well I guess first as a branch to "finalize" it locally (docs, maybe some config?). Then eventually into dev and then into master when it would be released, perhaps as v5.

On a sidenote, there are several very outdated versions of packages used in project's utility scripts, versions before types were even added there, so substantial rework might be required. In the fork, we are now pretty much forced to use any for these, to avoid large conflicts with the upstream, which is suboptimal.

first as a branch to "finalize" it
Works for me. @Can-Sahin , I suppose we should bring the fork to a "mergeable" state, create separate branch (in case some changes will be added before the transfer finishes) and then give the go-ahead?
Some other technicalities, perhaps?

Make it an official but separate project in the react-boilerplate organization.

I see several problems with this approach. Given it won't be a fork anymore (even though changes from the upstream would still be merged), there will be essentially 2 identical codebases, one with types, the other without. That would - second problem - lead to situations when a change, proposed to TS version, would be better first applied to upstream (something not TS-specific), so the contributor would have to be redirected there, etc etc.
So, indeed, the former option would be preferrable.

I agree. The first option is preferable.
There's only two reasons I'm personally on the fence:

I still hear so much ambiguity on TS and feel like the jury is still out on how much it brings to a project vs the cost of using it.
It makes the barrier to entry much higher. (And also, on a more personal note, I've never used it so it prohibits me from contributing until I've taken the time to learn it.)

I think javascript-typescript optional is a pretty good idea.
(assuming that merging is gonna happen) @GrayStrider yes definitely lets arrive to a mergeable state in ts fork. (But as I said can you take the non-ts changes as a side note to implement later after we merge into a dev branch or something. Because I still need to pull in from the upstream. Don't wanna drive apart so much. Would be soo easier if we merge first into a dev branch or something then carry on there.
@julienben I don't think getting used to typescript gonna be hard. I admit it was hard for me in the beginning but already solved all the issues pretty much and packages are getting more suitable for typescript everywhere. Been maintaining it actively over a year now. Potentially people could still commit with js-like code and we could fix the typings etc (if its really necessary). I can do comparison and entrance guide to typescript version (like whats is added and how is it used) so would be even easier for core developers to track whats going on, to get onboard.

people could still commit with js-like code and we could fix the typings

Yes, I second this. It doesn't stop you or anyone from contributing, but perhaps passing the PR review might be a bit trickier, which isn't necessarily a bad thing:)
As another example of TS goodness: there are a few tests present that are simply redundant with TS, since the testing scenarious would fail at compilation anyway.

@GrayStrider @lsanders @julienben
For this issue, I think for now the best thing to do is move typescript fork into this organization and remove the fork status (sending request to github). What do you think ?
I dont think merging typescript into this and maintaining a hybrid system isn't doable in near future. There are quite a lot of typescript only features and these will be conflicting the original source code and will eventually lead us to make separate folders with the app folder. On top of it, seeing ts and js mixed could potentially make newcomers confused and walk away (especially if not familiar with ts). I think starting with the boilerplate is already complicated for beginners.
Any feedback ?

I moved my fork to this organization and removed fork dependency. So I will be maintaining it here and any help would be so nice if you are interested. Closing this issue. We can discuss on another issue when merging two becomes possible ;)


All Contributors - Contribution links do not properly list contributions through issues

Currently we do not override the default contribution type links, so defaults come from the master config: https://allcontributors.org/docs/en/bot/configuration . These defaults do work well for a single-repo tracing, but not for our multi-org multi-repo tracing. To be replaced by contribution queries

Hi @oleg-nenashev I would love to look into this issue . Mind providing me to relevant links to help me better understand what's meant by contribution queries

Sorry for missing the comment. It is just a hackfest repo issue which is fairly minor. I suggest to focus on the Jenkins documentation and UX, we can handle the hackfest tooling for the next event

Will consider it doing for the next event


bwctl post hook information is out of date

From @arlake228 on March 14, 2015 12:50
Original issue 1056 created by arlake228 on 2015-01-27T14:19:34.000Z:
The information that bwctl passes to the post hook was never updated after non-throughput, and 'reverse' tests got added to bwctl. This means that the results being passed are either wrong, or confusing.
Copied from original issue: perfsonar/project#1054

Comment #1 originally posted by arlake228 on 2015-01-27T15:13:24.000Z:
<empty>


Stop gt 255 filenames breaking export

OK so even if Bulkrax is suggesting a filename that is guaranteed to be <=255 chars, zip uses tmpfile which uses tmpdir which uses prefixes and suffixes that will take it back over 255 chars. After looking at the tmpdir source code (!) my understanding is that it'll get date-number-random_number_base64 appended to what we've supplied from bulkrax (or more importantly 8chars-1char-6chars) so reducing the limiting we do in bulkrax ([0...(255-ext.length)]) by 17 would work... but let's do 35 for safety's sake...

label: bug-fix please


[Distributed] expose underlying identity in type eraser

We missed to expose the underlying, making checking the actual type hard on the send path.

replaced by more complete PR https://github.com/apple/swift/pull/38998


No audio output in iOS simulator

Hi,
I'm trying to test the demo, using the heroku app server.
I changed get user media to be false for video and true for audio.
I connect to a room in the simulator, and connect to the same room in web browser.
In web browser, I get audio feedback loop from microphone.
In simulator, I get no audio from microphone input on web browser, but the camera video does appear in simulator.

don't know about simulator, you better not test on it. especially video.
you can try disable video totally, see:
https://github.com/oney/react-native-webrtc/issues/155#issuecomment-257252039


Debian oval links are not working

The endpoints at
https://github.com/nexB/vulnerablecode/blob/eec05bb0f796d743e408a1b402df8abfc8344669/vulnerabilities/importers/debian_oval.py#L64-L67
are giving 403.
This is why documentation tests are failing (invalid link): https://github.com/nexB/vulnerablecode/actions/runs/6040203878/job/16390554826
I talked to them over IRC:
20:07 <hritik> Hello, we're working on an open source vulnerabilites database and have been using debain oval sources. Although the endpoints at https://www.debian.org/security/oval/oval-definitions-{release}.xml have started giving 403. Has something changed ?
20:07 <jcristau> yes
20:08 <jcristau> tools using these endpoints were DoSing our infrastructure
20:10 <hritik> jcristau: We try to be as polite as possible. Our project is under development at github.com/nexB/vulnerablecode/ Is there an alternative data source that we can use for oval definitions ?
20:12 <jcristau> hritik: i don't know.  though please 1) set appropriate user-agent, 2) download oval-definitions-{release}.xml.bz2
20:12 <kaiorafael[m]> hritik: you can build this, but I had to do this https://matrix.to/#/!pvJfJpKAVgcLkInkLv:matrix.org/$169357400414234YFyZi:matrix.org?via=matrix.org&via=kde.org&via=ru-matrix.org
20:13 <kaiorafael[m]> Not sure if there is a better way to put these files altogether
20:14 --> HritikVijay[m] (~hritikvma@) has joined #debian-security
20:15 <hritik> kaiorafael[m]: I could not see your message. It says "Tried to load a specific point in this room's timeline, but you do not have permission to view the message in question"
20:16 <-- jandrusk<EMAIL_ADDRESS>has quit (Ping timeout: 480 seconds)
20:17 <kaiorafael[m]> Sorry, pasting here for reference:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/AQEbLRsSQzwMxEEGXJqxRbLZ>)
20:18 <hritik> jcristau: thank you. We will work on setting an appropriate user agent from now on.
20:19 <hritik> jcristau: https://www.debian.org/security/oval/oval-definitions-wheezy.xml.bz2 Also gives 403. it appears that all endpoints under /security/oval/* are 403 :(
20:19 <kaiorafael[m]> My request for the Debian Security folks is that these steps needs to be bit clear so anyone can build their own Oval. Maybe, there is a better way
20:19 <kaiorafael[m]> s/needs/need/
20:22 <hritik> kaiorafael[m]: Cloning (and generate.py) the repositories on regular basis sounds like a cumbersome task. It will also waste the bandwidth for the clones (from both sides). Is this approach a recommendation from Debian Security ?
20:24 <kaiorafael[m]> I don't know. I am a Debian user only and I have no authority to speak on their behalf, but I found this way to generate it. Let's see if they can bring a better solution.
20:25 --> jandrusk<EMAIL_ADDRESS>has joined #debian-security
20:27 <hritik> Is there an issue tracker/mailing list I should raise this at ? Chats on IRC might get lost.
20:27 <jcristau> hritik: thanks.  we'll probably make the bz2 files available again soonish.
20:29 <hritik> jcristau: thank you. we'll check back in soonish ;)

TL;DR
Following are the 2 suggestions from debian security

Use .bz2 links
Set proper useragent

Related:

https://github.com/nexB/vulnerablecode/issues/410

@Hritik14 Thanks! There is something tickling me though... the oval data seems to be entirely generated from some other data in a Git repo?
If this is the case, may be we would be better served by using the original data?

Based on chats with @Hritik14 @pabs3 and others on the #debian-security IRC and here is the gist of things:

the ultimate origin of debian data is https://salsa.debian.org/security-tracker-team/security-tracker/tree/master/data ... everything else is derived from that data.

various scripts there generate a sqlite database

... and also  https://security-tracker.debian.org/tracker/data/json

https://salsa.debian.org/webmaster-team/webwml/-/blob/master/english/security/oval/generate.py generates the Oval data

The docs are at https://security-team.debian.org/security_tracker.html

@pabs3 reported that we have an issue: the hard-coded list of Debian codenames is out of date, it is missing bookworm https://raw.githubusercontent.com/nexB/vulnerablecode/main/vulnerabilities/importers/debian_oval.py

@Hritik14 therefore we should consider going further up the food chain rather than using oval data IMHO


update summit build

fixing PR https://github.com/CompFUSE/DCA/pull/237

This has become obsolete


[Hotfix] Storage usage fork bug

Purpose

Changes

QA Notes
Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation

Side Effects

Ticket

Also add a check for storageLimitStatus.text in this condition, otherwise I think we'll get similar weird behavior in the is_public = True but OVER_PRIVATE case

rolled into admin app PR


[test] Add visual regression test for SpeedDIal

Test

adds a visual regression test for the SpeedDial

Fixes

tooltips of SpeedDialActions not being displayed if it was mounted with open tooltipOpen

Funnily enough, I had a visual regression test as part of the original PR, but it got deleted. It wasn't nearly as comprehensive as this one though!


Julia: add binding for runtime feature detection

Ref: #13549
julia> mx.features_enabled()
8-element Array{MXNet.mx.MXFeatures.Feature,1}:
 CPU_SSE::Feature = 5
 CPU_SSE2::Feature = 6
 CPU_SSE3::Feature = 7
 CPU_SSE4_1::Feature = 8
 CPU_SSE4_2::Feature = 9
 CPU_AVX::Feature = 11
 F16C::Feature = 15
 LAPACK::Feature = 21

julia> mx.features_enabled(Symbol)
8-element Array{Symbol,1}:
 :CPU_SSE
 :CPU_SSE2
 :CPU_SSE3
 :CPU_SSE4_1
 :CPU_SSE4_2
 :CPU_AVX
 :F16C
 :LAPACK

julia> mx.features_enabled(String)
"CPU_SSE, CPU_SSE2, CPU_SSE3, CPU_SSE4_1, CPU_SSE4_2, CPU_AVX, F16C, LAPACK"

@mxnet-label-bot add [pr-awaiting-review]

https://github.com/apache/incubator-mxnet/pull/13964

so... features_enabled has gone?

New API:
julia> mx.libinfo_features()
30-element Array{MXNet.mx.MXRuntime.LibFeature,1}:
 ✖      CUDA
 ✖      CUDNN
 ✖      NCCL
 ✖      CUDA_RTC
 ✖      TENSORRT
 ✔      CPU_SSE
 ✔      CPU_SSE2
 ✔      CPU_SSE3
 ✔      CPU_SSE4_1
 ✔      CPU_SSE4_2
 ✖      CPU_SSE4A
 ✔      CPU_AVX
 ✖      CPU_AVX2
 ✖      OPENMP
 ✖      SSE
 ✔      F16C
 ✖      JEMALLOC
 ✖      BLAS_OPEN
 ✖      BLAS_ATLAS
 ✖      BLAS_MKL
 ✖      BLAS_APPLE
 ✔      LAPACK
 ✖      MKLDNN
 ✖      OPENCV
 ✖      CAFFE
 ✖      PROFILER
 ✖      DIST_KVSTORE
 ✖      CXX14
 ✖      SIGNAL_HANDLER
 ✖      DEBUG

And I want to add a comparison method like:
:CUDA in mx.libinfo_features()

to let user check a feature enabled or not.

What is ":CUDA" in Julia? is it an atom like in erlang?

Yes the new API just returns a list of struct with boolean field indicating enabled or not.

yeah, :CUDA is a Symbol in Julia, exactly the same as atom in Erlang.

LGTM % I don't know Julia.

Finally, I decide to make this:
julia> mx.isenabled(:CUDA)
false

julia> mx.isenabled(:CPU_SSE)
true

I guess this can be resumem  when you have some bandwidth.

okay, I updated it.

Needs rebase

rebased

well, the ci status blocks the merge button.

could you try another rebase? CI had a hiccup a couple of days ago.

sure


fix: fixes casbin error

this locks the version of casbin to a specific version that should (hopefully) fix the error in doorway staging

@YazeedLoonat curious about this change, the lock file has version "5.27.1" for casbin?

@emilyjablonski yeaa the issue is that in doorway we don't seem to be using the yarn.lock and are instead pulling in a much more recent version which is what is causing the issues with doorway staging


Fix build

The build won't fail, but it'll throw an error at run time currently:
SyntaxError: import.meta may only appear in a module

… still digging.

Merging this PR will not publish a release.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Array map entrySet throws on remove / removeAll

This is just one example, but it will throw on all calls of remove / removeAll since *ArrayMap.EntrySet inherits from AbstractObjectSet which implements remove as throwing UnsupportedOperationException.
  @Test
  public void testEntrySetSupportsRemoveAll() {
    Int2IntMap map = new Int2IntArrayMap();
    assertFalse(map.entrySet().removeAll(Collections.singleton("TEST")));
  }

Yes, as I said the implementation of array map was quick and dirty. Fixed.


Current 2.4.0-RC2 based master is incompatible with (at least) Cassandra 2.1.2

Hi,
I was trying to understand an issue since I moved to Akka 2.4.0-RC2 and the master branch of the akka-persistence-cassandra (it was previously working fine on Akka 2.4-M2 and a previous version of wip/akka-2.4).
The symptoms were that one specific actor wasn't recovering correctly, no messages were read from cassandra.
I created a reproducible test that produces the following unique message in akka.messages:

persistence_id
partition_nr
sequence_nr
used
message

 game-provisioning-SW |                 0 |                     1 | True |  0x0a3508bef5fad7f...

Notice how Used is true.
While debugging the problem (well it took me a looooong time), I found that the query that tries to find the highest sequence number for a partition gives a wrong result (see findHighestSequenceNr):
cqlsh:akka> SELECT sequence_nr, used FROM akka.messages WHERE persistence_id='game-provisioning-SW' AND partition_nr = 0 ORDER BY sequence_nr DESC LIMIT 1;

 sequence_nr | used
-------------+------
           1 | null

Notice how it returned null. Removing the DESC or the LIMIT 1 makes the query return the correct True value for used, but using both not.
So, since the code needs to see True, a 0 sequenceNr is returned and nothing is read back from the journal, and no recovery happens.
I'm not able yet to upgrade to another version of Cassandra to check if this issue is fixed, but I will update this issue with my findings.

Thanks for raising this.
I found that static columns were broken for limit queries on low 2.1.* versions of Cassandra. I raised this with cassandra-Dev and they confirmed it was fixed. Any version less than 2.1.6 isn't suitable for production but we should document this to stop others hitting the issue and wasting time on it.

On 15 Sep 2015, at 15:43, Brice Figureau<EMAIL_ADDRESS>wrote:
Hi,
I was trying to understand an issue since I moved to Akka 2.4.0-RC2 and the master branch of the akka-persistence-cassandra (it was previously working fine on Akka 2.4-M2 and a previous version of wip/akka-2.4).
The symptoms were that one specific actor wasn't recovering correctly, no messages were read from cassandra.
I created a reproducible test that produces the following unique message in akka.messages:
persistence_id	partition_nr	sequence_nr	used	message
game-provisioning-SW	0	1	True	0x0a3508bef5fad7f...
Notice how Used is true.
While debugging the problem (well it took me a looooong time), I found that the query that tries to find the highest sequence number for a partition gives a wrong result (see findHighestSequenceNr):
cqlsh:akka> SELECT sequence_nr, used FROM akka.messages WHERE persistence_id='game-provisioning-SW' AND partition_nr = 0 ORDER BY sequence_nr DESC LIMIT 1;
sequence_nr | used
-------------+------
1 | null
Notice how it returned null. Removing the DESC or the LIMIT 1 makes the query return the correct True value for used, but using both not.
So, since the code needs to see True, a 0 sequenceNr is returned and nothing is read back from the journal, and no recovery happens.
I'm not able yet to upgrade to another version of Cassandra to check if this issue is fixed, but I will update this issue with my findings.
—
Reply to this email directly or view it on GitHub.

@chbatey thanks for confirming the issue. I will upgrade Cassandra on my test VM to check if that solves the issue.
:+1:  changing the README would be a good idea :)

I indeed confirm that the problem is fixed in Cassandra 2.1.9.


Relock Analysis Showing Large df p2p values while readout noise looks normal

HI all, a few days ago (with no clear origin), one of our wafers started showing a very low number for "good tracking channels", shown in the relock analysis plots (very large df p2p, see plots below). Despite this, readout noise looks quite reasonable. Possible that flux ramp drive parameters are off? Some help interpreting this would be great-- IV curves and bias steps for this UFM look great (it is Mv12 on srv SO4 (Mv12 is the photo with 411 good channels).
Although the other UFMs show a higher percentage in the green "good" range, several others show similar columns extending into high df p2p values.
@msilvafe @jlashner Max asked me to send this to you both :)
Kyohei Yamada first found this issue and can comment more on how it started.

Hi Sam, I believe we've generally increased the df_ptp allowed range in our device cfgs from 50 to 100 (here: https://github.com/simonsobs/sodetlib/blob/26b1e7ab02b21b797d8a618bf68217baed5fda42/sodetlib/det_config.py#L76), but in these plots it looks like the cutoff is 50 kHz (the old value).
We've changed this in the defaults, so new device cfgs should use that larger range. Any chance the device cfgs you're using are copied from an older version? If so I think you should just be able to update them such that df_ptp_range=[0, 100].

Thanks Jack, I actually just checked the det_config files and it looks like the range is already set to [0,100]. How do we change the plotting to reflect this?

oh I see, I was confused, sorry I was looking at the sodetlib/sodetlib/det_config.py file. I'll change those device configs now.
Thanks!

Ah ya I can see how that's confusing. Hope that works!

I'm closing this, but if the problem isn't fixed feel free to re-open.


Sites generated by this tool aren't well adapted to mobile screens

Problem
As described in the title, sites generated by this tool aren't well adapted to mobile screens

What I think would be a great experience for mobile

Hey, I applied the fix on my personal blog so I decided to open an issue and a PR here as well :) this tool is awesome! I think a better mobile experience would be incredible


Ability to merge multiple analyzer / scanner results into a single report

We are using ORT to extract licenses and export dependency graphs from our microservices.
Summarizing, our workflow is to periodically run ORT on each microservice before doing a release while having separate process generate aggregated reports of all our services. Currently we are generating individual reports for each repo, but we would like to have an aggregated report instead.
Would it be possible to merge several results from ORT Analyzer and ORT Scanner into one file so that we can export a single report for our entire codebase ?

I've changed the title to make more clear that the ask is not to merge a single analyzer result with a single scanner result (which, as explained here, is not necessary as the scanner result includes the analyzer result).
Instead the request seems to be to merge multiple ORT result files (be it analyzer or scanner result files) into one in order to pass it to the reporter to create a single report.
As outlined in the similar issue https://github.com/oss-review-toolkit/ort/issues/4364 and the review of PR https://github.com/oss-review-toolkit/ort/pull/5317 which tried to implement merging of analyzer result files as a helper-cli command, this approach has various issues. One of them is that ORT result files can only record a single repository from which it was created, and when merging results, it would be unclear which one that should be.
That's why I've proposed to instead create a special reporter that can take multiple ORT result fields as input and creates a single combined attribution document as the output.
So, @arieltorti, would you be fine with closing this and continuing the discussion as part of https://github.com/oss-review-toolkit/ort/issues/4364?

Sounds good, it's the exact same use case and the solution you proposed works for us.
I'm fine with closing this issue.

@arieltorti I think this should be a duplicate

@sschuberth sorry if I'm not getting this, I'm confused: #4364 is Open but the PR is merged. What's the current status of the functionality? Does it still require some development? (we can help here)

@dgutson, the PR is not merged, but it was closed unmerged. Basically the same PR was recreated about 3 times due to the contributor having problems with Git, which makes things a bit hard to track. But long story short, there is no helper-cli command to merge analyzer results yet.

So the only thing to get this working is https://github.com/oss-review-toolkit/ort/pull/5519 ? I want to know if there is more to be done, so we could help.

So the only thing to get this working is #5519 ?

Yes, that's currently your best bet.

I want to know if there is more to be done, so we could help.

That for offering help! Most of the ORT contributors are on summer vacation currently, so reviews will be slowed down a bit... but if you're interested in the feature, I'd say you could try out #5519 and review the code / leave feedback in the PR discussion.


Tilda fingerprint has changed

Service name
Tilda fingerprint has changed to "Please go to the site settings and put the domain name in the Domain tab."
Proof
https://tilda.cc/ru/answers/a/domain-has-been-assigned/

Would you be willing to submit a pull request for this? Thanks!

HTTP response code would be better fingerprint, 403 for not vulnerable and 404 for vulnerable
http://non-existent-page.tilda.ws/ is also vulnerable but doesn't have 'Domain has been assigned' message


[Filter Panel]: Deprecate  component

The problem
The <dds-filter-panel-heading> component is presently required to be used with <dds-filter-panel-composite>, and is effectively hidden, its child nodes (typically a text node) harvested via the slotchange event, for use composed with the number of selected values.
Slots are best suited for things that are directly reflected into the shadow DOM. It's current use results in an over complicated, hard to follow implementation.
The solution
Introduce a new heading attribute for the <dds-filter-panel-composite> component to fulfill the same purposes as the <dds-filter-panel-heading> component. Mark the <dds-filter-panel-heading> component as deprecated, to be removed in the next major version.
Application/website
ibm.com
Business priority
Low Priority = release date is not dependent on fix or not upcoming
What time frame would this ideally be needed by (if applicable)
No hard dates here.
Examples
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

@kennylam kennylam closed this as completed 8 minutes ago

@kennylam I think this is still an open issue? Unless we're closing as "won't fix"?

Oh sorry about that. I thought it was fixed in the referenced PR.

No worries. Thanks. I'll come back around to this on a rainy day.


Updated kubernetes api and resource limits

@mridulrb and I have updated the Kubernetes API in the deployment files for each service

@MaxShapiro32 the final build is queued but everything is working a-ok

Build passed

@MaxShapiro32 Build has passed


feat: make kakarot smart contract (zkEVM) an upgradable contract

As part of the maintainability effort for Kakarot, we'd want the master Kakarot smart contract to be upgradable.

For testnet, the address being owner for upgrade will be owned by the core team leaders
For mainnet, the address having rights to upgrade Kakarot will be owned by a governor account

To claim this issue, please propose an implementation plan:)!

@TotalPizza is on it!

As part of the maintainability effort for Kakarot, we'd want the master Kakarot smart contract to be upgradable.
* For testnet, the address being owner for upgrade will be owned by the core team leaders

* For mainnet, the address having rights to upgrade Kakarot will be owned by a [governor account](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/docs/modules/ROOT/pages/governance.adoc)

Sorry, I overlooked this issue.
My implementation plan is be pretty slim:
Instead of deploying the Kakarot itself, we declare the contract and use it as an implementation for a proxy.
I'd use the standard OZ proxy contract.
Regarding ownership on testnet:
I'd be against a multisig contract and rather integrate the OZ access control library in order to give team members access to upgrade the implementation.

@TotalPizza is taking a break from contribution. He'll come back stronger soon hopefully 🤞🔥.

I believe we shouldn't take too much time no, as after the cairo1 migration is coming soon


[Addition]: Hummingbird selfwitnessing cluster

Hotspot b58 Addresses
1123sKLAwu3GjKT5EJ9F7rva1dsWpqpN1SsjaW9pxPKEW6DW3WnK
1125kpkkoK6b8dfDcu5aypdDxEXQNLBz3cxPVqKhU2DYiQQUfK5d
112hiu1hmvaHA4ywdDoWdefSBmNSMPbNTK7eKWzmPTerhDefwcpr
112qCbtahNHfRwRHAYMQjk6uW9WHUtT6y27Kwx9eyGDshb6QryKX
112zcTo4YkhUnNQmWj1Ay8QaVRBrig6mZ4XYBrhrzzjhUf79oF3
113bz1k6ftNZWZ91XVD7LWzTAUiUEqTG5CHvLugtSZSk9VeKD2j
11aAsuGWvJw2VjHWUPThr9vQhknZqzDkuyTddBEsR8rnCRfSpPR
11aBrz5itZ7sEfpqiXNKxtXmcsn7v6ysSdY5euRM6qL8dSjomVq
11ALTZp3NSJhvYaoULqT62rM8SRZTf8XKNfavDhwAYecuRSM2yd
11h6T1Xi94axeCFv5kGZwgCT5u8h3TdagSZzs3BAwASXc8dj4J4
11HUhFGsj9R5Mdq22JuKYfRYx77Kg3srfTr5NbYx3LQxd82k7w8
11ihjt3ze9ghxzwB4TXcGajSKKBqTvKJMTwRGHnjpC5QW5j8GKn
11im8nk7kkwAiNLaUEjK9SzTQkwak23YSkW4UrSXLcnkyB1yY99
11k6dHqcX82ctgdcmr21kxSzmPoXjJu9fBtvUoLCQ555xqGyTRe
11pJg3RZ6KbKp7iAANktHLbZ67ibPqcH3NXmCmR6Mx2Vfb2RsGH
11qYPRDphRS4QyrHMFtKLnzH7rpydZrp546rYNpn1XXJx2AXE3s
11sxCNPAQJAJAXw2nHgy1bTfVTS5iYxjW92ydUocWdEtx2tCxFR
11Vc9Scb1gFNJiQKuaGfvunHBkLhSht21p4exRH3aP4e2qRv2Qk
11XhGNv4KVdYqmsUwsGvQCqp1aWNnHMBDwfKnPRSs7ixANtwBrK
11YAxmJQSD63j2dhJAsnDuUEZ6tsVg8KK8KfPbLudnrpNVMfjT1
Discord Handle
No response
Reason(s)

All but 1 account for all Hummingbird gateway's didn't show any data transfers.
So data transfer is possible! only 109 out of 3853 showed packet transfer data, all these 109 are in same account.
the gateway's in that account are part of a selfwitnessing cluster so they probably all heared the same
signal.

Most of all Hummingbird gateway's witness only Hummingbird gateway's.

We iterated the witnesses of the witnesses to find the clusters.
We used the node-red server we setup for this to get the results out of api.

All HNT stolen with the total amount of 21067 HNT as by todays date/time.

We conclude that out of the 3852 gateway's we inspected only 109 gateway's in 1 account showed accidental
data transfer. so data transfer for gateway's Hummingbird is possible.

We conclude that out of the 3852 gateway's we inspected only a couple of accounts showed communication with other makers. so communication with other makers for Hummingbird gateway's is possible.

Rssi/ distance / SNR calculations are to perfect, we have found some invalids -59 dbm but we suspect they are from cables touching eachother.

We haven't targetted any maker, it was the result of a count WHERE actors1.actor_role = 'witness'
AND actors2.actor_role = 'challengee' are in same account.

Resolved in https://github.com/helium/denylist/pull/4048


Automatic table configuration via Annotation Processing

This pull request adds an annotation processor that examines annotations at compile time and generates a function that adds cached config information for all tables to the DAO Manager.  This is intended to replace textual config files, with the advantage that it is generated automatically every build.  All reflection is done at compile time, so there is no runtime cost.  Simple inputs and outputs are included as automated unit tests.

Hi guys,
thanks @NCrouther for this. I am actually working on an OrmLite android Plugin. The plugin is ready but uses the ORMLite Config Util class to generate the ormlite configuration file. And this approach has several limitations that would all be removed by using an annotation processor.
The android plugin : https://github.com/stephanenicolas/ormlite-android-gradle-plugin
The plugin works fine, but with several limitations. Nevertheless, it is production ready and we already use it at Groupon internally. We got large speed improvements but it twists a bit our build cycle and it creates some problem at the SCM tree level (basically the ormlite config file, which is now generated has still to be part of the tree). An annotation processor would get rid of those twists and SCM troubles.
The annotation processor is really the way to go but I didn't have time to look into it. I am glad someone could find some time and spent some effort on this.
I plan to review the PR this week, if you are fine with that @j256 .
Also, @j256 , I think this all should be merged in ORMLite : both the annotation processor and the android gradle plugin.

Generally speaking, a gradle example is missing. It should use aptplugin to configure the annotation processor.

I have a few comments, but I think this PR is really great ! I hope it can be made stable and merged soon to ORMLite.

Thanks for all of the detailed feedback.  I knocked out all of the easy stuff today, I should have time to tackle the rest of it later this week.  A couple of open questions:
How should we handle the new dependency on a java code generation library (Velocity or JavaPoet)?
I was hesitant to use a library since currently the Android JAR has no runtime dependencies.  I know I have used ORMLite by just adding the JAR to an eclipse project, and I would guess other users do this as well; I didn't want to add too much complexity for those users.  My research on the issue pointed me to the maven shade plugin which looks like will bundle the dependency into the single JAR.  Is this a good way to go?  Is there anybody familiar with it that can point me in the right direction?
Should the annotation processing code be in a separate JAR?
The gradle apt plugin looks like it is built around having a JAR with just the code for annotation processing so it can load it during compile but not add it to the output JAR.  I can see the benefit, but since the annotation processing code is pretty small for now, I figured it would be simpler to keep it all one project.  If we decide to split it, is that something I should do (i.e. I would create a project for it and the j256 repo would fork it), or should this repo split it out?  My gut feel would be to keep it together for now and if the annotation processing grows (such as if we do more code generation to eliminate reflection when populating query result objects), @j256 would create the new project and migrate the annotation processing code there.
Thoughts?

I went ahead and added JavaPoet and used the maven shade plugin to eliminate the added dependency.  It does bump the size of the annotation processing code from ~10KB to ~70KB which adds some more motivation to split the annotation processing into a separate JAR that can be discarded at runtime
TODOs:

investigate strategies for splitting into two JARs
create gradle example

Open Questions:

Should we split into two JARs, and how should it be handled?
Where should the gradle example go?  I would guess that upon release it should be added to the main project website.

I looked at how Dagger handles creating two JARs and they use a maven multipke module project, which seems like the best way to go.  There are a couple of areas that I could use some guidance:

I am pretty new to maven, so I'd like to have somebody experienced who fully understands the existing POM look over the 3 poms that I split it into to make sure I did it right.
Currently I have Javadoc links from some main JAR classes to annotation processor JAR classes, so javadoc is giving warnings (and I assume the links are broken).  Is there a good way to handle this?  Possibly by merging the Javadoc from the two maven subprojects somehow so the links properly resolve?

Hi @NCrouther ,
you are right, for the jar management. It's better to use modules. I would suggest the following : (but in a different PR as it involves changing orm lite android's pom)

a parent module (ormlite-android-parent) that contains stuff related to dependency and plugin management, release and quality plugins
a child (ormlite-android) that contains the lib
a child (ormlite-android-processor) that contains the processor
if necessary, to avoid a cycle : a child module (ormlite-android-core) that defines common data structures.

But this might be a little long and should maybe be addressed in a different PR. Already, this, which is quite a change, and has to be merged.
For Javadoc, I don't know.
@j256 @kpgalligan What do you think of this ?

Thanks for the confirmation.  I solved the javadoc issue by using the aggregate-jar target for the javadoc plugin in the parent pom.  I have the project split into the modules you describe and everything seems to be working properly.  However, there are still sections of the POM (such as the sourceforge and sonatype profile sections) that I don't understand, so they will definitely need heavy review.  Should I commit the changed pom (along with moving all source files to appropriate folders) to this PR or wait and create a new PR?

I don't know what the plan of @j256 is. The easiest would be a PR against your branch, not an additional commit and a link to follow up on the PR (which is gonna be in your repo).
Good work ! Sonatype and sourceforge stuff should not be modified. But they should bubble up to root level.

Thanks for the advice.  I'm really new to Git/GitHub, so I appreciate the hand-holding, I'm learning a lot.    I followed your recommendation and put the initial version of the module-split pom into a separate branch/PR in my repo: https://github.com/NCrouther/ormlite-android/pull/2.  Based on the JARs created, functionally everything seems good, but I am sure the POMs can use some further refactoring.

I only saw this PR now, but it's really similar to a project I started last Friday: https://github.com/koesie10/ormlite-processor. It's basically the same, but without changing the project's code and it has some limitations.

Getting a build error from the JavaPoet.  I think the build needs to be 1.7, but changing to that throws a different issue.  JavaPoet related issue:
[ERROR] /Users/kgalligan/Dropbox (Touch Lab)/devel_git/ormliterefactor/ormlite-android/src/main/java/com/j256/ormlite/android/processor/OrmLiteAnnotationProcessor.java:[453,18] cannot access java.nio.file.Path
[ERROR] class file for java.nio.file.Path not found
Also, how do you add to a gradle project?  Example?  Working on this today.

Didn't mention @NCrouther directly in last message.  Not sure if you'll see it...

Sorry for the delay, I was away from email over the holiday weekend.
I didn't realize that JavaPoet would increase the required JRE/JDK version.  Hopefully the impact will be small since I am splitting it into two separate JARs.  The main JAR can retain 1.5 compatibility, and the annotation processor JAR can target the higher version that is necessary.
I am doing some experiments on the branch with the pom changes: https://github.com/NCrouther/ormlite-android/pull/2
I incorporated the animal sniffer plugin (http://mojo.codehaus.org/animal-sniffer/) to verify that the code is not using any newer APIs than are present in the declared java version.  It seems like everything is fine on 1.6.  This change should fix the java.nio.file.Path not found problem, the real issue will be figuring out the other error you ran into when changing that.  Let me know what happens when you try to build the latest from that branch.

To add to gradle (for the branch with the annotation processing split into a separate JAR):
compile files('libs/ormlite-core.jar')
compile files('libs/ormlite-android.jar')
provided files('libs/ormlite-android-annotation-processor.jar')

Once this version is deployed to maven central, it will be:
compile 'com.j256.ormlite:ormlite-android:4.49'
provided 'com.j256.ormlite:ormlite-android-annotation-processor:4.49'

You should add a project type dependency it will handle both cases.
Let me know if I can review the code.
S.
Le 2015-05-26 7:11 PM, "Nathan Crouther"<EMAIL_ADDRESS>a
écrit :

To add to gradle (for the branch with the annotation processing split into
a separate JAR):
compile files('libs/ormlite-core.jar')
compile files('libs/ormlite-android.jar')
provided files('libs/ormlite-android-annotation-processor.jar')
Once this version is deployed to maven central, it will be:
compile 'com.j256.ormlite:ormlite-android:4.49'
provided 'com.j256.ormlite:ormlite-android-annotation-processor:4.49'
—
Reply to this email directly or view it on GitHub
https://github.com/j256/ormlite-android/pull/45#issuecomment-105722531.


Prebuilt binary for linux/macOS system?

This language-server implementation is amazing, and thank you for your hard work.
I wonder if you can provide a pre-built binary that can work out-of-box. It is somewhat complicated to build from sources in linux or macOS systems.

There is no single pre-built binary. However, there is a prebuilt package that Python extension downloads and unpacks. It is nuget (zip). Extension source is
https://github.com/Microsoft/vscode-python/blob/master/src/client/activation/languageServer/languageServerPackageRepository.ts
https://github.com/Microsoft/vscode-python/blob/master/src/client/activation/languageServer/languageServerPackageService.ts
Example URL for Mac
https://pvsc.blob.core.windows.net/python-language-server-beta/Python-Language-Server-osx-x<IP_ADDRESS>.nupkg

This is working. Thank you for the information!

How do I get the latest release version?

@contrun - prebuilt binary or in VS Code or... ?

@MikhailArkhipov Sorry for the ambiguity. prebuilt binaries.

URLs are as above and there is Python extension sample code linked there. Extension downloads latest available.

The previous url my linux distribution was using was:
https://pvsc.azureedge.net/python-language-server-stable/Python-Language-Server-linux-x<IP_ADDRESS>.nupkg which fails.
I tried bumping the version number to 0.3.66 to no avail. Our build infrastructure relies on fetching a nuget file so I would like to find a nuget but I have no idea where to look: I thought https://www.nuget.org/packages?q=python-language-server would give me some results but I couldn't find anything, please help :)

Those links are only intended to be used for the VS Code Python extension to install/update the language server, not general consumption (note "pvsc" in the URL). We periodically remove older builds from the bucket once we know that the extension will not download them anymore.
The latest stable version is 0.4.24, so you may be able to bump it for now, but if you need to depend on a specific version, you'll likely want to be building it from source or mirroring the file in a more stable location. We may consider publishing on nuget for full persistence at some point, but we still haven't fully "released" the language server and haven't had the time to get that fully set up and versioned.

Alternatively, you can look at how extension picks the latest here https://github.com/microsoft/vscode-python/tree/master/src/client/activation/languageServer


figure out which theme to use

Currently:

default

doesn't provide search

material

consistent with theme we use with mkdocs
integrates lunr search
doesn't work with groups

Fixed in #15.