Show control measure template and example

The control measure SVGs contain a hidden template and an example. It would be nice to be able to show this information in the symbol browser. Maybe in a modal window?

You probably already know this, but this will essentially require you to edit this line of the svg:
<g id="template" display="none">
to remove the  display="none" not sure how you might do that on a web client though, unless you are able to create/load an svg from a string.

I have tested this, and managed to manipulate an SVG before displaying it. It was easier than expected. I hope to have a solution ready soon.


fix: run yamllint on all files

The current CI setup ignores hidden directories. (e.g. .github)
This PR fixes it.
NOTE: merge #38144 first, otherwise the CI will report errors.

comment to remove stale tag

@clalancette Can you review?


The color of the icon displayed in the EmptyView of the Favorites screen is different from Figma.

https://github.com/DroidKaigi/conference-app-2024/blob/98cdcf2bcd1b2efafdb8ee712371f2320b34f927/feature/favorites/src/commonMain/kotlin/io/github/droidkaigi/confsched/favorites/section/FavoriteSheet.kt#L153-L158
https://www.figma.com/design/XUk8WMbKCeIdWD5cz9P9JC/DroidKaigi-2024-App-UI?node-id=55521-44698&t=U0Y9WYLKYOmTCVrL-4

I'll take care of this 🙋


[code-infra] index.ts generator

[x] I have followed (at least) the PR section of the contributing guide.

This closes https://github.com/mui/material-ui/issues/33987
The script is not versatile, but ready to become so. The problem is that other projects (say, mui-material or mui-base) have some thing  that need to be addressed: e.g., both ts and js files, or uncommon exports. I think that instead of making lots of changes in every project, it's better to try it here and think of expanding if it works well.
Also, making this script a pre-commit hook might be a good idea.

Label check is failing, but there's nothing I can do with that. Is it intended or am I missing something?

This looks relevant for all npm packages.

I'd leave this to @mui/code-infra.

Personally I don't think the benefits outweigh the added complexity. But I think it's up to the product teams to decide whether they want to incorporate this extra step in their workflow. For Toolpad packages I'd prefer to keep hand-editing these sort of files. If anything, I'd be more interested in a code formatter (eslint rule?) that orders the exports alphabetically.
From a code infra perspective, should we go forward with this, I have the following concerns:

This should use a self-documenting CLI and named arguments like https://github.com/mui/material-ui/blob/65408b1f3e9a022c9baf51eb8d5af7285da72a65/scripts/buildTypes.mjs#L147
This needs to be covered by a check in CI otherwise it will be forgotten about. e.g. like https://github.com/mui/material-ui/blob/65408b1f3e9a022c9baf51eb8d5af7285da72a65/.circleci/config.yml#L218

Since PR is inactive and there's no response from the author, I'll close it.

Well, there's no response from the author, because there's nothing I'm supposed to reply to. There was a task, but when I solved it, turned out "it's up to the product teams to decide whether they want to incorporate this extra step in their workflow". I believe you should close the task as well if it's not needed.

Sorry, I didn't read this carefully and only focused on the two bullet points mentioned.
As for the feature request, I don't find it very useful right now. In our products, we use @mui/material, where we don't frequently add new components. @mui/base is no longer maintained, and @mui/joy is on hold regarding its future. These are our main UI projects, so I think manually editing these files works fine.

Apologies, I think my review could have been more explicit. What I meant is, I don't think the solution is a great one in terms of DX. It creates pockets of uneditable code. My advice is to instead check it in a lint step.
A review was ask from code infra, and from that perspective I'm not keen on maintaining the solution proposed in this PR. I don't want to own it. But if the product team disagrees and wants to own it, I'm not blocking it.

Okay, this PR is already closed, we're all set here. I guess it'll be nice to finalize the expected result in the task, but it's up to you.


scrollLoop

Coverage decreased (-0.003%) to 3.879% when pulling 9c1f7590501c8258cbb1f7757f1a88d84dee13b2 on adreyfus:feature/scroll_loop into eb08f0ef2576621ee843bf26a38715b3b2f62962 on chafey:master.

Coverage decreased (-0.02%) to 3.866% when pulling d98a1c84b767ed2b436018234c7063086a0f39aa on adreyfus:feature/scroll_loop into eb08f0ef2576621ee843bf26a38715b3b2f62962 on chafey:master.


Azure App Service Container

I have deployed the Docker VSTS agent in an Azure App Service (Linux) deployed from the Docker registry https://hub.docker.com/r/microsoft/vsts-agent/  but I'm getting errors on startup.
Everything appears to be correct but when the container starts up and tries to update the VSTS agent installed in the container it throws errors.  Looks to me like the installer is trying to change permissions / ownership of the files but fails.
Output Logs:
2018-03-23 15:06:15.293 INFO  - Issuing docker pull: imagename =microsoft/vsts-agent
2018-03-23 15:06:15.783 INFO  - Issuing docker pull: imagename =microsoft/vsts-agent
2018-03-23 15:06:16.179 INFO  - Issuing docker pull microsoft/vsts-agent
2018-03-23 15:06:16.843 INFO  - docker pull returned STDOUT>> Using default tag: latest
latest: Pulling from microsoft/vsts-agent
Digest: sha256:d4f0a1d0ebdba5ec7b8c98f8e3808d3760466c55d34799c4009b19da04c61077
Status: Image is up to date for microsoft/vsts-agent:latest
2018-03-23 15:06:16.863 INFO  - Starting container for site
2018-03-23 15:06:16.864 INFO  - docker run -d -p 20696:80 --name cgvstsagent1_0 -e WEBSITES_ENABLE_APP_SERVICE_STORAGE=true -e WEBSITE_SITE_NAME=CGVSTSAgent1 -e WEBSITE_AUTH_ENABLED=False -e PORT=80 -e WEBSITE_ROLE_INSTANCE_ID=0 -e WEBSITE_INSTANCE_ID=bfb6d68afc38e295e465fa6926b0da6265f60eaf3bbbf914428aa5e9ada70f10 -e HTTP_LOGGING_ENABLED=1 microsoft/vsts-agent
2018-03-23 15:06:25.580 INFO  - Container logs
2018-03-23T15:06:18.301379873Z Downloading and installing VSTS agent...
2018-03-23T15:06:21.767446265Z tar: ./externals/vso-task-lib/README.md: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.767967086Z tar: ./externals/vso-task-lib/node_modules/q/README.md: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.768656313Z tar: ./externals/vso-task-lib/node_modules/q/CHANGES.md: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.769001527Z tar: ./externals/vso-task-lib/node_modules/q/LICENSE: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.769298739Z tar: ./externals/vso-task-lib/node_modules/q/package.json: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.769596950Z tar: ./externals/vso-task-lib/node_modules/q/queue.js: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.770303879Z tar: ./externals/vso-task-lib/node_modules/q/q.js: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.770596990Z tar: ./externals/vso-task-lib/node_modules/q: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.771424923Z tar: ./externals/vso-task-lib/node_modules/minimatch/README.md: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.771830839Z tar: ./externals/vso-task-lib/node_modules/minimatch/node_modules/brace-expansion/README.md: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.776863839Z tar: ./externals/vso-task-lib/node_modules/minimatch/node_modules/brace-expansion/node_modules/balanced-match/.npmignore: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.776889440Z tar: ./externals/vso-task-lib/node_modules/minimatch/node_modules/brace-expansion/node_modules/balanced-match/README.md: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.776902541Z tar: ./externals/vso-task-lib/node_modules/minimatch/node_modules/brace-expansion/node_modules/balanced-match/package.json: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
** Truncated for brevity **
2018-03-23T15:06:21.901879109Z tar: ./externals/vso-task-lib/taskcommand.js: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.902123119Z tar: ./externals/vso-task-lib/lib.json: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:21.902251724Z tar: ./externals/vso-task-lib: Cannot change ownership to uid 2399381, gid 1049089: Invalid argument
2018-03-23T15:06:24.267808665Z tar: Exiting with failure status due to previous errors
2018-03-23 15:06:25.580 ERROR - Container cgvstsagent1_0 for site cgvstsagent1 has exited, failing site start

This image has not been tested with Azure App Service. My assumption is that they require the container do not run as root, and the image assumes that it is running as root.

@stepro Any thoughts on possible solutions?  Does the container really need root access and/or could the permissions on the files be set differently when the container is created to resolve this issue?

Ok, I decided to see if I could trick App Service into thinking the VSTS agent was a web site just enough to keep it running, and that turned out to be quite easy. If you try to browse to the web site, e.g. my-vsts-agent.azurewebsites.net, it will redirect you to the agent pool configuration page in your VSTS account. This same HTTP response is used by App Service itself to decide that the container is healthy, so it stays running.
In addition to the VSTS_ACCOUNT and VSTS_TOKEN environment variables, you'll probably want to also set the following in your App Service application settings:
VSTS_AGENT_IGNORE=APPSETTING_VSTS_AGENT_IGNORE,APPSETTING_VSTS_TOKEN,WEBSITE_AUTH_ENCRYPTION_KEY,WEBSITE_AUTH_SIGNING_KEY

This will prevent secret values from appearing in the VSTS agent pool portal.
Lastly, don't set the VSTS_AGENT environment variable to a value that could be the same across instances of the agent. If you try to scale or upgrade your App Service, it will try to create multiple agents with the same name and VSTS doesn't like that.
I'll ping this thread when the images on Docker Hub have been updated.

I've updated the images on Docker Hub - please try it out and see if it works for you.

This is working Great now for our .Net Core builds.  Thanks!!!
It's worth noting for others this is a Linux docker containers so the VSTS Agent in Docker can only build .Net Core projects.  A Windows build server for .Net 4.x builds.
@stepro Are there plans to create a Windows docker container for this at some point?

The scaffolding for building your own Windows containers exists in this repo but I haven't been maintaining it so it's likely to be quite out of date. See #1 for more information.


Event messages generated during library init get dropped

I have a CFE based project that uses multiple libraries, which are loaded in the startup script as a CFE_LIB rather than a CFE_APP.
Today I found that one of the library initialization routines was failing.  Despite generating an Event using CFE_SendEvent on the condition, no event was reported on the console.
The issue is that library init routines are called from the main thread context, and therefore not in the context of an Executive Services task.  This causes CFE_ES_GetAppId to fail - which is probably correct.
However this causes CFE_EVS to effectively drop the message on the floor, and it is entirely silent in this case.
This might be intended behavior but it caught me off guard since I got no output whatsoever.  One possible fix is to just stick to CFE_ES_WriteToSysLog during library init functions but perhaps we should consider having event services actually do this, so the message at least goes somewhere visible.

Imported from trac issue 206.  Created by jphickey on 2017-09-28T12:42:08, last modified: 2019-03-01T15:27:58


CF::Number - Float comparison

Ensure comparison of floating point values are correct on CF::Number.

Fixed in b4e871d4e2bd3360b6298988e50f405eacdee824.


Legacy UI on Rancher 2.6.5 is not displaying "containers in this pod" page correctly

Rancher Server Setup

Rancher version: 2.6.5
Installation option (Docker install/Helm Chart):

terraform modules rancher2 and rke using RKE1

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.23.6-rancher-1
Cluster Type (Local/Downstream):

Problem affects local and downstream clusters, both clusters are rancher 2.6.5 and using kubes v1.23.6-rancher-1 and created with terraform

User Information

What is the role of the user logged in? (Admin)

Describe the bug
The legacy UI on Rancher 2.6.5 is not displaying "containers in this pod" page correctly.
To Reproduce

Navigate to local or downstream cluster.
Look at the System project
Go to fleet-agent workload (or any other workload)
Click into one of the pods

Result
A page without any "containers in this pod" is displayed
Expected Result
A list of containers in this pod should be displayed.
Screenshots
Problem in 2.6.5:

What it is supposed to look like:

Additional context
First thank you for all the hard work you all put in.
We have a rancher cluster running over 17000 deployments, these are organised into 100 namespaces with around 150 deployments each.
We would love to use the new UI but sadly the new UI has some small issues with this volume of deployments and the user experience is poor (we have hundreds of users).
Here is the issue preventing us from using the new UI:
https://github.com/rancher/rancher/issues/38312
Since the new UI is a poorer user experience and the legacy UI is broken on this page we are a bit stuck with upgrading from Rancher 2.5.* to Rancher 2.6.*. We would also like to keep the legacy UI working to give our users time to get used to cluster explorer.

https://github.com/rancher/dashboard/issues/3591 this issue is related.
We are still facing the same issues even with 2.7


after fresh golang installation GOARCH=386 (not amd64) (GOHOSTARCH=amd64)

What version of Go are you using (go version)?
go version go1.15.10 windows/amd64
Does this issue reproduce with the latest release?
yes (the lastest 1.15 release)
What operating system and processor architecture are you using (go env)?
go env Output
C:\Users\gekigek99>go env
set GO111MODULE=auto
set GOARCH=386
set GOBIN=
set GOCACHE=C:\Users\gekigek99\AppData\Local\go-build
set GOENV=C:\Users\gekigek99\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\gekigek99\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\gekigek99\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set GO386=sse2
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m32 -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\gekigek99\AppData\Local\Temp\go-build417896366=/tmp/go-build -gno-record-gcc-switches

What did you do?
installed golang on windows 10 64 bit
What did you expect to see?
GOARCH to be set to amd64
What did you see instead?
GOARCH=386 (even though GOHOSTARCH=amd64)
Comment
I can set GOARCH=amd64 manually, but some tools while compiling do not do it automatically and this results in an error

why using 32bit binary toolchain in 64bit windows?

The only way i could get GOARCH to say 386 is if I used the 386 binary or set GOARCH manually.
Please check your env var configs to make sure it is not being set somewhere.
Also try go env -u GOARCH to make sure it is not being set in the go env file.
Else there needs to be clearer repro instructions than "install go on windows"

if I used the 386 binary or set GOARCH manually.

i did not do any of those, I installed the amd64 version and didn't set GOARCH
There was actually the file C:\Users\gekigek99\AppData\Roaming\go\env which contained
GOARCH=386
GO111MODULE=auto
GOOS=windows

and I removed the file (is it ok to just remove it right?)
now it appears to be working
just one question... why when I uninstall golang the go env file is not removed?
(so that when I reinstall golang the installation is truly fresh?)

It does not remove files in the %USERPROFILE% directory and only removes from the install directory.

it's seems quite inconvenient to me to have an incomplete uninstallation... Is it something I can suggest to the devs or is there a reason for this behaviour? (maybe just to remove the env file and leave other directories which might contain important files?)
any way thanks a lot I've been banging my head over this for more than a week now

You could make a proposal issue for a checkbox in the installer to optionally remove config and other files, I think that is reasonable tho I have no authority on it. As for why it's not removeing them, I would argue that it is more inconvenient to remove config files every install in the general case.

I would argue that it is more inconvenient to remove config files every install in the general case.

yea you are probably right, but I like the idea of a checkbox during installation to remove old config files, I think I'll create an issue for that
Thanks again for the suggestion and support


Would you know how to use this in swift?

Your design is awesome for this pod. I really want to use it but I am having trouble converting to swift. Do you have any idea?

Hi,
I haven't tested this in swift. What kind of problem you faced?

Mainly problems with converting the code and initializing

I've already implement it using swift. Just do like this:
let shareBubles: AAShareBubbles = AAShareBubbles.init(centeredInWindowWithRadius: 100)
shareBubles.delegate = self
shareBubles.bubbleRadius = 40
shareBubles.sizeToFit()
shareBubles.showFacebookBubble = true
shareBubles.showTwitterBubble = true
shareBubles.addCustomButtonWithIcon(UIImage(named: "twitter"), backgroundColor: UIColor.whiteColor(), andButtonId: 100)
shareBubles.show()

But I don't know why, I only create facebook and twitter bubble, but it shows 3 bubbles

that's why you see 3 buttons
shareBubles.addCustomButtonWithIcon(UIImage(named: "twitter"), backgroundColor: UIColor.whiteColor(), andButtonId: 100)


Use dirs for placing the config in $XDG_HOME/.config

If you're just going to make the config not configurable, then this doesn't make sense. :)

I think it makes sense like this:

rename config.toml to apps.toml, update main.rs accordingly
read options from cli arguments (1. priority) and optional config.toml (2. priority)

Currently, the only option is to skip commands that require user interaction to finish, but I am sure there will be more.
Let me know if you're interested in moving forward with the PR this way!

Sure


libdnf: 0.73.0 -> 0.73.1

Description of changes

Update libdnf to 0.73.1.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 300969 run on x86_64-linux 1

Duplicate of https://github.com/NixOS/nixpkgs/pull/299880?


ABCA4 Retinopathy

Mondo term (ID and Label):
MONDO:0800406 ABCA4 Retinopathy
Suggested new label:
this is supposed to be
ABCA4-related retinopathy

https://github.com/monarch-initiative/mondo/issues/6168


Request for filter search preview

Feature Request
It would be nice to have preview when doing file filter search (CMD+P), so that I can see what file I'm trying to look for. Specially nice when having multiple files with the same name under different folders.

You can open the file behind the quickopen popup with the right arrow key (or another key of your choosing). Does that help?

I was suggesting more of a preview, so if I pressed escape it would go back to how it was before I started the search, and whenever a file is selected it pops open temporarily until I hit enter. Hitting the right arrow opens the file which is not necessarily convenient. Hope that helps explain it. ha

I see. I think this is covered by https://github.com/Microsoft/vscode/issues/12892


Bank value precision and exact value options

Modified Bank Title updating to force update when the config is changed.
Modified StackFormatter to have more precision for values over 1M &
instances where the integer portion of the value is 3 digits.
Apologies for the 3 commits - I didn't have my formatting options set according to this project.

Added in https://github.com/runelite/runelite/commit/fd09843bb69f2cd930ae11082e33dd8a609af855


⚠ Adacta-fintech.com has degraded performance

In ddb700d, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 200
Response time: 2310 ms

Resolved: Adacta-fintech.com performance has improved in d957d77.


channels_last support ?

Hi,
In your readme you are saying that your function supports only channels_first volume, but in your code I see that you are using channel_last forself._data_format = "NDHWC" ? So is your code supporting channels_last ?
Thanks for your contribution.

Yes, since the last commit, the DepthwiseConv3D class also supports channels_last inputs. So you can use it as a standard Keras layer without the need of transforming the activation map tensors before using it.
Best,


feat(framework): urldecode path params

Query parameters were already urldecoded but path params weren't.

@mkroli thanks!


Fix: VisionCamera session is not deinitialized/recycled when screen gets unmounted on native-stack

@mountiny @ishpaul777 @chiragsalian
Details

Fixes an issue with<EMAIL_ADDRESS>where the CameraSession doesn't get de-initialized and/or recycled, when the screen gets popped/unmounted from the Navigation stack in @react-navigation/native-stack.

[!NOTE]
This PR is needed in https://github.com/Expensify/App/pull/37891

Since the fixing patch is based on another patch that we introduced in https://github.com/Expensify/App/pull/45289, we can't (yet) create an upstream issue for this.
I raised this issue Margelo-internally so we can fix this once react-native-vision-camera is fully migrated to the New Architecture.
We should also think about updating react-native-vision-camera to the latest (stable) version, because there are some new changes related to New Arch support.
Fixed Issues

$ https://github.com/Expensify/App/issues/49988
$ https://github.com/Expensify/App/pull/37891
PROPOSAL: https://github.com/Expensify/App/pull/37891#issuecomment-2383283177
Tests

[ ] Verify that no errors appear in the JS console

Open the App on a physical iOS device
Click the FAB and go to "Submit expense"
Make sure the camera starts up.
Navigate back to the Home screen
Make sure, the "green camera indicator" in the iOS StatusBar/Dynamic Island/Notch disappears.
Go to "Submit expense" again and make sure the camera starts up again.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@chrispader it seems like the ios build failed in the vision camera step https://github.com/Expensify/App/actions/runs/11125757985

@mountiny not sure why the iOS build fails, the throwing line is not changed by the patch, but i just re-applied the patch and removed some unused code.
Could you please trigger another ad-hoc build?

@chrispader running a new build. Can you check this out, please? https://github.com/Expensify/App/actions/runs/11143292660

@mountiny @ishpaul777 just updated the patches. Now it should work!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


React Router v3

Fix issue #172

cc @seanyesmunt

Any idea of when you will be able to look into this? I might be able to give it a try if you think it will be a while.

very very shortly (like over the weekend maybe). About to start on a 50+ route app with this.
Short Term Goals: make a better boilerplate

react router 3, or v4 with an addon
webpack 2 beta, transpile the server
chokidar to watch server folder for changes, and handle restarts
drop redial for redux-taxi, so you can declare data at component level instead of at the route level
decide on glamor vs. aphrodite
a client-only prototype env and npm script
react-storybook
jest, ava
docs

Long Term Goals: wrap this up into a framework + cli

Looks awesome, v4 react router would be sweet! Thanks

@seanyesmunt are you using this kit at Walmart?

@jaredpalmer No, just using it for a side project I am working on with a friend. https://github.com/seanyesmunt/universal-js

Closing this. Moving to 4. #212


chore(main): release 1.5.1

:robot: I have created a release beep boop
1.5.1 (2024-11-20)
Bug Fixes

tidied adult keywords (3e6e3b2)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.5.1
:sunflower:


deprecate kctf chal debug docker

with kind its kindof redundant

I think kctf chal debug docker should be left in, as when debugging challenges i occasionally did have issues where the challenge ran correctly in docker but not on kind.
Not a great example, but in one scenario kind did not think i had system resources available to run the challenge so it was left indefinitely in a "Pending" state. seeing that the challenge worked correctly in kctf chal debug docker helped me diagnose that issue.

offtopic: @arxenix how did you diagnose that issue? I currently have an issue that sounds similar - even a dockerfile that essentially does nothing is not launched by kctf chal start on the local kind cluster, but works with kctf chal debug docker. Would be cool to know how to confirm this is the issue (and perhaps even how to make it work anyway)

@lucidBrot it's been some time so I don't remember the details, but a quick search through my browser history shows this being my last visited link on the topic. I also suggest trying to run it on a different machine or cloud instance


Feature suggestion: Execute on Save Failed/Passed

Description: I would love the addition of a 'After Save Failed' and 'After Save Passed' option in the execute macro box as there doesn't seem to be a way to only execute a macro if the item succeeds.
Example usage:

I.E. create a macro to move a target 10m closer, and add it to the Gust spell with the execute option 'After Save Failed'. Now if the target fails their save, it activates the macro and moves the target 10m closer, but only if the target fails their save.

+ After Save Failed
+ After Save Passed

You might be mixing up module functionalities. This is a MIDI menu for its own macro execution, not controlled by Item Macro.


Question: Is there any easy way to get all hrefs from a page?

Hi all, very nice project!!!
I'm trying to get all links "href" from an HTML page, but unfortunately without success. Is there any example that I could follow?
Thanks in advanced.


Support custom 404 page

Describe the bug
I know that Jupyter Book will not work predictably with custom Sphinx extensions, but I've been trying to integrate this Sphinx Not Found Page extension into my Jupyter Book so that I can have a custom 404 page. And I think this could be potentially useful for all Jupyter Book users.
Anyway, when I use this extension, I get the following error:
An error happened in rendering the page 404.
Reason: ValueError("'/' does not start with '/Users/melaniewalsh/mybookname'")

@humitos has been helping me debug this issue and usefully identified that there seems to be a problem in sphinx-book-theme in the function find_url_relative_to_root, which is called from generate_nav_html.
So I was wondering if there were any suggestions about how to make the Sphinx Not Found extension work with the Sphinx Book Theme. Thanks!
To Reproduce

Add Sphinx Not Found Page extension to _config.yml

sphinx:
  extra_extensions:
  - notfound.extension
  config:
    notfound_context:
        body: "
Page not found.
"
    notfound_no_urls_prefix: True

Build Jupyter Book
See error

An error happened in rendering the page 404.
Reason: ValueError("'/' does not start with '/Users/melaniewalsh/mybookname'")

Expected behavior
Custom 404 page is built that preserves CSS and JavaScript from Sphinx Book Theme
Environment

Python Version [e.g. 3.7.1]: 3.8
Package versions or output of jupyter-book --version:
Jupyter Book: 0.8.2
MyST-NB: 0.10.1
Sphinx Book Theme: 0.0.36
MyST-Parser: 0.12.10
Jupyter-Cache: 0.4.1
NbClient: 0.4.0
Operating System: Mac OS

Sorry I just realized that a custom 404 page was previously mentioned by @chrisjsewell #221! The Sphinx Not Found Page extension wouldn't be necessary if a custom 404 page was integrated in a different way

Oh yeh was going mention.
I didn't know about this extension though so thanks for pointing it out 😀
Will have at look to see if any of it's implementation should be incorporated here, or we just allow for comparability with it

I'm the author of the [sphinx-notfound-extension](https://github.com/readthedocs/sphinx-notfound-page/). Let me know if I can be useful in some way here.
I don't see specific needs in #221 that won't allow people using sphinx-book-theme to use the extension. In fact, in the description of the issue, the linked project using a custom 404 page is using the sphinx-notfound-page :smile:
If there is anything needed to be added to the extension to make it compatible with the sphinx-book-theme, I'd be happy to incorporate it.

thanks @humitos!
Yeh I'm sure we can work out the issue to support this extension and will let you know 😄

Hey! I just wanted to share that I was finally able to get the sphinx-notfound-extension working and create a custom 404 page in my Jupyter Book.
I needed to add a "url prefix" to my own repository, which I did in the config_.yml file here.
You can see an example of the custom 404 page here.
Thanks for the great extension, @humitos!

ah that's very cool! Thanks for sharing your solution!

@melaniewalsh - any interest in making a quick post to the jupyter book discussions board that shows off this pattern? Maybe others would find it useful!

Thanks @melaniewalsh for sharing the solution!

any interest in making a quick post to the jupyter book discussions board that shows off this pattern? Maybe others would find it useful!

Hehe, I was about to suggest adding an entry in the FAQ of the sphinx-notfound-page project at https://sphinx-notfound-page.readthedocs.io/en/latest/faq.html
Either work to me. So, happy to have it documented somewhere.

@choldgraf Sure, I'd be happy to write a quick post for the Jupyter Book discussion board! Also @humitos I could add an entry to the sphinx-notfound-page FAQ, too.
But yes I think this issue is closed 🎉

amazing! thanks for being so helpful @melaniewalsh :-)


UI for orderable orchestration templates

Implemented:

don't display non-orderable orchestration templates in orch. templates catalogs view
new read-only screen showing stack's orchestration template + spec
new button to make a template orderable + spec
new button to copy a template as orderable + spec
button to take the user from the stack's orch. template page to the orch. template view in catalog controller

Fixes: #6600
https://bugzilla.redhat.com/show_bug.cgi?id=1302810

@miq-bot remove_label wip

@bzwei @h-kataria @martinpovolny Review?

@bzwei can you try this in UI, tested in my environment LGTM.

@mzazrivec from the stack summary page I don't see the template appears in the Relationships table when the template is not orderable. So I cannot test the feature to convert or copy to orderable.

@bzwei once @mzazrivec removes the check on https://github.com/ManageIQ/manageiq/pull/7822#discussion-diff-59410190R59, it should show links to both orderable & non-orderable templates.

@bzwei @h-kataria I removed the check preventing from displaying non-orderable
template in UI.
Regarding the new screen -- the requirements, as they were described in the ticket -- were mentioning
a new screen for both orderable & non-orderable templates. There's a button to take you to
the template in catalog explorer. Plus, after you create a copy of a template, you'll be also taken
to catalog explorer to the newly created template.

@bzwei please re-test

@mzazrivec
Tested the copy as orderable feature. It does not create a new template, instead the old template got renamed and orderable flag set to true. With this feature a new template is expected, leaving the existing one untouched.
Tested the make template orderable feature. I saw message "Orchestration Template is now orderable". But the configuration menu does not change. It still looks as if the template is not orderable. Even worse the template got deleted from the database. I am doing some debugging too to see whether this is a backend problem.

@mzazrivec I confirmed there is a backend bug. Please do not merge this PR until the backend issue is cleared.

marking it WIP until back end issue is fixed.

@bzwei So what probably happened with the OT copy you described above was that a new template (the copy) was created and the old one was deleted.

@mzazrivec no, I verified from database that the stack still referenced to the old template but it got renamed and flagged.

@bzwei That's strange, because this is the controller code doing the copy:
ot = OrchestrationTemplate.new(
  :name        => params[:templateName],
  :description => params[:templateDescription],
  :type        => original_template.type,
  :content     => params[:templateContent],
  :draft       => params[:templateDraft] == "true",
)
begin
  ot.save_as_orderable!
rescue StandardError => bang
  ...
else
  ...
end

I'm not sure how this can create the results you're describing.

@mzazrivec then it must be caused by the same backend bug. I am able to create a PR. Will update here.

@mzazrivec I understand the problem now. For a copied template, if the user modifies the content before save, a new template will be generated. If the user only renames, all the changes (name and orderable flag) will be applied to the existing template. This is according to design. So this is not a real problem. The reasoning behind it is we don't allow two templates to have the same content.

@miq-bot remove_label wip

@bzwei I fixed the problem with re-rendering the screen after making a non-orderable template orderable.

@mzazrivec The problem still exists. After the template gets converted to orderable, the view in a catalog menu is gray out, and the other two menus are enabled. Also I suggested change the text to View this Orchestration Template in Catalogs because Catalogs is a valid tab under Services.

@bzwei Fixed.

Tested and looks good now. :+1:


warzone2100: fixup build after vulkan update

#250795
https://github.com/Warzone2100/warzone2100/pull/3353

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@fgaz this doesn't pull the PR.

Huh, I guess I saw the URL and my brain went "ah yes, fetchpatch".
Anyway, the PR got merged, so there is a patch we can fetch now.

I'm not up to resolving that
       > patching file lib/ivis_opengl/gfx_api_vk.cpp
       > Hunk #2 succeeded at 527 (offset -28 lines).
       > Hunk #3 succeeded at 1546 (offset -220 lines).
       > Hunk #4 succeeded at 1610 with fuzz 1 (offset -220 lines).
       > Hunk #5 succeeded at 1743 (offset -229 lines).
       > Hunk #6 FAILED at 2026.
       > Hunk #7 FAILED at 2245.
       > Hunk #8 FAILED at 2362.
       > 3 out of 8 hunks FAILED -- saving rejects to file lib/ivis_opengl/gfx_api_vk.cpp.rej
       For full logs, run 'nix log /nix/store/v4qikgp2cznrlrsg242agq1wrgzh3zcx-warzone2100-4.3.5.drv'.

Ow. Yeah, let's just replace the string then. I'll try to remember to remove it on the next update.


feat(api): tell user if API thinks it's a v1 or v2 protocol

Overview
The 3.19.0 update removed the print statements from the simulate output per some user requests (#5847). This feature request proposes a single print statement is added back in to inform the user of the API version.
Implementation details
Some changes were made to block the import of v1 modules in v2 protocols (#5859), but this left a weird edge case (#6015). Rather than try and stay one step ahead of the user in guessing all of the possible ways to malform a protocol, the API should just print the apiLevel it has decided to use for the protocol in question and let the user figure out why nothing else happens in their simulation.
A positive side effect is that this print statement might help nudge users towards considering the apiLevel they have chosen for their code.
Design
Simulating
from opentrons import robot
def run(protocol):
    pipette1 = protocol.load_instrument('p1000_single_gen2', 'left', tip_racks=nonexistant)
    pipette1.pick_up_tip()

results in the following output from the simulate utility
$ opentrons_simulate bad_protocol.py
Executing using API Version 1.0

$

Acceptance criteria
API version is displayed to users when simulating

No longer applicable due to PAPIv1 end-of-life


TimeSource sample enhancements

Show alternative implementations

return a simple String on the @InboundChannelAdapter method instead of MessageSource<String>
Use SI Java DSL

Change application.yml to reference outputChannelName instead of inputChannelName

This is not applicable anymore.


Create Diagnostic Container Component

Task
Use the mockup in the design directory to create a Diagnostic container component called DiagnosticContainer.js
This is the component that is below the Calendar component in design/wireframes/CORONATRACKER UI - #1.png
It will hold four sub-components:

The chart to track temperature over time -> Chart.js
Average Temperature display -> Temperature.js
Toggle between symptoms and temperature -> ToggleInfo.js
Symptoms component (needs clarification) -> Symptoms.js

In the design directory, it's above the Tab Bar.
What done looks like
We have a Diagnostic.js component in /components.
We have a Diagnostic.css file to style the Diagnostic.js component in /css.
Design considerations
We have decided to use regular CSS files to keep things simple for now. This allows for more contributors and less time to upskill to contribute.
Once MVP is done the team can discuss if we want to transition it to styled-components or something like CSS modules.
Folder paths
CSS is located in /client/src/css
Components are located in /client/src/components
Style guide for CSS files:
Naming convention:
Component -> Diagnostic.js
CSS file -> Diagnostic.css
To avoid naming collisions:
prefix class names with the name of component and link with kebab case.
Class name -> .Diagnostic-header { ... }
How to handle state:
If you can use redux, use it.
Create action and reducer with an appropriate name.
Testing
No need to worry about testing for now.
If you choose to add tests, please place in client/src/tests

@tesla809  thanks for redirecting me! I'll get on it.

@pavel-ilin is working on the sub-component for this. See #54.

Hi, looks like Pavel has the Chart.js sub-component in hand. I'll tackle the temp.js and toggle.js sub-components.

For the temperature section

I was thinking that it would be awesome to increase the width of the chart,  and we can move the "Average Temperature" to sit either above or beneath the temperature itself.

I'll work on simply filling the full screen with this component as well as better positioning the "sign out" button


Bookstore: Use Redux in React components

In this milestone, I did the following:

Implemented react-redux to connect store and access state variables and state modifiers
Wrapped the entire app with the Provider component
Passed the configured store into the Provider component
Displayed books received from the slice, in a reusable component
Dispatched actions using useDispatch hook

@mukhammadrizooff, thank you very much, sir.


Grammar railroad diagram

Using this page https://meimporta.eu/tree-sitter/json2ebnf.html we can get a navigable railroad diagram for tree-sitter grammars like this project.
See also https://github.com/tree-sitter/tree-sitter/issues/2268 .
Cheers !

Thank you ! This is a very useful tool !


Enable Miri to emit warnings without halting execution

For some things it might be nice if Miri could emit a warning, but go on executing the program. For example, Stacked Borrows / validity invariant violations could be turned into a warning. Or we could warn when a memory access is sufficiently aligned just because its integer version is sufficiently aligned -- which might be pure luck on the side of the program.
This could even replace flags like -Zmiri-disable-validation with -Avalidation-failure or so! It would be a uniform way to handle extra checks that we sometimes want and sometimes not. (Though in particular for -Zmiri-disable-validation we also want the performance benefit of not doing all these checks.)
Some thoughts from Zulip on how warnings could be emitted in a reasonable way:

S: Just put it on stderr and prefix it with [MIRI] and you're good as far as un-mixing it goes.
R: not sure if we can make the rustc diagnostic printing stuff do that
S: In that case print only once that miri has more to say and provide a key to print the entire thing

Or maybe we don't want to point to a span here, then we can just eprintln! ourselves directly, an we can easily manage the allow/warn/error flags.

S: I think the information about the situation presented to the user can be summarized as "MIRI has detected behavior that might depend on memory addresses chosen at runtime. You may need to re-run it several times to detect an error." which is a single print and should only be done once

Cc https://github.com/rust-lang/rust/issues/62420

If we want to emit backtraces for warnings, we'll have to fiddle some information through AllocExtra. One possible API would be to pass an impl Fn(InterpErrorInfo<'tcx>), so we don't expose the InterpCx to stacked borrows directly.
Less intrusive would be to have a global store of things to report that is filled before going into stacked borrows and that stacked borrows can push things into. This is similar to tls::tcx in the compiler.

If we want to emit backtraces for warnings, we'll have to fiddle some information through AllocExtra

I assume that is specifically for parts of the code that don't have access to the ecx?

Less intrusive would be to have a global store of things to report that is filled before going into stacked borrows and that stacked borrows can push things into. This is similar to tls::tcx in the compiler.

That sounds reasonable. Also I wouldn't want full backtraces by default anyway, that seems excessive -- but it seems like a reasonable option.

With https://github.com/rust-lang/miri/pull/1127 we have the basis for a scheme like that, but there is no good "lint management" yet. Right now Miri only emits warnings/notices on explicit request, so this is fine; if we ever want to warn about something by default (like if we adapt https://github.com/rust-lang/miri/issues/1074 as default behavior), we have to improve.

In https://github.com/rust-lang/miri/issues/1363, @Robbepop made the great proposal to also use the scopes of the currently running code to cotnrol Miri error reporting:
fn foo() {
    // code that is checked with default settings
    #[miri::warn(stacked_borrows)]
    {
        // code that is checked with stacked borrows turned into warnings instead of errors
    }
    // code is checked with default settings at this point again
}

One interesting question here is whether this should take into account the call stack. Like, should the following code warn or error about stacked borrows during the execution of bar?
fn bar() { ... }

#[miri::warn(stacked_borrows)]
fn foo() { bar() }

I think the answer is "yes the call that should be taken into account" and "it should warn". That seems most consistent. But it is pretty different from how rustc/clippy use the lint system, so it could be challenging to implement.
We do have MIR soruce info for every stack frame, so we can iterate up that frame and... well, maybe somehow get the lint levels from that source info?

We do have MIR soruce info for every stack frame, so we can iterate up that frame and... well, maybe somehow get the lint levels from that source info?

Yes, but I think only for the current crate. SourceInfo.scope -> SourceScope.local_data.lint_root. (SourceScope.local_data is ClearCrossCrate)

It would be great to have this feature! It would also be useful to have some additional attributes:

#[miri::ignore(leaks)], which ignores errors without printing anything to the console. In this example, ignores leaks since we might be leaking on purpose
#[miri::expect(leaks)], which makes the test fails with an error if something doesn't happen. Obviously, when an UB happens, the execution of the test is always halted, but if we're expecting it the test should be successful. In this example, fails if a leak doesn't happen, which might be useful to test a certain corner-behaviours of your unsafe code, like a panic in safe code called from unsafe code

For the former, we do have -Zmiri-ignore-leaks. Attributes would be more elegant indeed, but the problem is that this is a global toggle, whereas attributes are attached to a piece of code, so this does not quite match up very well.

the problem is that this is a global toggle, whereas attributes are attached to a piece of code

Yeah, this is the problem indeed. However, it would also be super-useful to be able to fail a test if a UB doesn't happen. Is there any possibility of seeing this added in the future?

The trouble is, Miri doesn't even have the concept of a test. Miri just runs a binary. That that binary happens to be a test runner is entirely oblivious to Miri.

The trouble is, Miri doesn't even have the concept of a test. Miri just runs a binary. That that binary happens to be a test runner is entirely oblivious to Miri.

Oh, I see the problem here. Since there is the possibility to annotate a test with #[should_panic], wouldn't it be possible to make something like #[miri::panic(leaks)] instead of #[miri::expect(leaks)]?
(or even #[miri::panic(leaks, message="custom panic message")])
So using it will be like:
#[test]
#[should_panic(expected = "oh no leaks")]
fn foo() {
    #[miri::panic(leaks, message="oh no leaks")]
    {
        // code that leaks
    } // Here we check for leaks
}

A "leak" is defined as "after the program finished executing, there is still some memory left that has not been deallocated".
So it is not even clear what it means for a single function to have a leak. Presumably something involving "allocations done by this function or its callees", but (a) we don't have any infrastructure to track that, and (b) what if a function spawns another thread that keeps running; do the allocations made by that thread count? What if the thread is joined at some point?
Basically what I am saying is, someone needs to do a bunch of design work to even figure out what it should mean to apply such an attribute to a function.

Leaks are not UB. :)
We do have a flag to turn some "unsupported" messages into a panic. Presumably we could do something similar for some kinds of UB, though (a) the code might be written assuming (correctly) that memory accesses do not panic, and (b) how to best do this without making our code harder to maintain -- I do not know.

Leaks are not UB. :)

The fun part is that I knew it and decided to use the term UB for leaks anyway 🙃. I definitely need more sleep.

(a) the code might be written assuming (correctly) that memory accesses do not panic, and (b) how to best do this without making our code harder to maintain -- I do not know.

Yeah, I also think that's the problem. Maybe something like the following might works (?)
fn panic_on_ub<F, R>(f: F) -> R
where
    F: FnOnce() -> R,
{
    // Miri built-in which panics, but still have problem (a) since panic_on_ub returns R
}

// Or even
fn try_and_report_ub<F, R>(f: F) -> R
where
    F: FnOnce() -> Result<R, UBType>,
{
    // Miri built-in which doesn't have problem (a) since it returns a Result instead of panicking
}

(names should be definitely improved)
The problem is that this way Miri would have to add library functions, but at least now it would know what to do in case of UB.


Fix FlaskApp exception handlers

Fixes #1787
In the FlaskApp, the error handlers were still registered on the underlying Flask app instead of on the ExceptionMiddleware, which led to them not following the documented behavior.
The documentation was also incorrect about ignoring error handlers registered on the flask application. We are only ignoring the default error handlers registered by Flask itself.
This is a breaking change, however, since this functionality was not following the documented behavior, and 3.0.0 was only recently released, I propose to release this as a patch version.

coverage: 94.271% (+0.03%) from 94.237%
when pulling 070374f0916fc6324377d29eec698e1b38ab81d0 on bugfix/exceptions
into bcf4c63b32835eddd624d6b936abfccad1646908 on main.


feat: redis supports multiple DocumentArrays

Goals:
This PR will add support for storing multiple DocumentArrays in the one Redis server instance according to https://github.com/jina-ai/docarray/issues/507

[x] add code for redis multiple DocumentArrays
[x] modify related tests
[x] update documentation

@JoanFM @alaeddine-13 please review again

@alaeddine-13 why u think tests are failing?

@JoanFM @alaeddine-13 can you review again?

@alaeddine-13 why u think tests are failing?

I'm inspecting push/pull failure but still no idea about failure in prepare environment

Hey @AnneYang720 ,
can u try rebasing your code against master?
I am not sure why the tests fail. But another PR has them passing #548

Hey @AnneYang720 ,
can u try rebasing your code against master?
I am not sure why the tests fail. But another PR has them passing #548

actually this PR is already up-to-date

Hey @AnneYang720 ,
can u try rebasing your code against master?
I am not sure why the tests fail. But another PR has them passing #548

Okay now I get why it was not passing. The github secret is not set on external contributor CI.
tests passed on this PR.
I mistakenly force pushed to this branch so waiting for @AnneYang720  to push back her work so we can merge the PR


ShopifyAPI::Errors::NoWebhookHandler for mandatory webhooks

Issue summary
Before opening this issue, I have:

shopify_api version: 14.3.0
Ruby version: 3.0.7
Operating system: Linux

After upgrading my shopify_app to 22.2.1 and shopify_api to 14.3.0 I continue seeing the ShopifyAPI::Errors::NoWebhookHandler for mandatory webhooks like customers/redact.
Worth to say that I have upgraded from a very old versio to 14.0.1 first and the same error happened, I upgraded to 14.3.0 in hope it was fixed, but the error continues.
ShopifyAPI::Errors::NoWebhookHandler
No webhook handler found for topic: customers/redact.

I did found a issue about this which mentions that old versions were working:
https://github.com/Shopify/shopify_app/issues/1756
But it seems that new versions of the API are not handling it okay.
Expected behavior
The mandatory webhhoks should be handled okay.
Actual behavior
The error.
Steps to reproduce the problem

Create a new app
Simulate a webhook call (yarn shopify webhook trigger)

Debug logs
shopify_api (14.3.0) lib/shopify_api/webhooks/registry.rb in process at line 193
sorbet-runtime (0.5.11478) lib/types/private/methods/call_validation_2_7.rb in bind_call at line 687
sorbet-runtime (0.5.11478) lib/types/private/methods/call_validation_2_7.rb in block in create_validator_procedure_fast1 at line 687
shopify_app (22.2.1) app/controllers/shopify_app/webhooks_controller.rb in receive at line 10
actionpack (<IP_ADDRESS>) lib/action_controller/metal/basic_implicit_render.rb in send_action at line 6
actionpack (<IP_ADDRESS>) lib/abstract_controller/base.rb in process_action at line 195
actionpack (<IP_ADDRESS>) lib/action_controller/metal/rendering.rb in process_action at line 30

My customer redact job:
class CustomersRedactJob < ApplicationJob
  extend ShopifyAPI::Webhooks::Handler

  queue_as :default

  class << self
    def handle(topic:, shop:, body:)
      perform_later(topic: topic, shop_domain: shop, webhook: body)
    end
  end
...

I've tried use the new extend ShopifyAPI::Webhooks::WebhookHandler but the problem remains.

Thank you for raising this, we'll look into it!

hi @overallduka, this PR https://github.com/Shopify/shopify-app-template-ruby/pull/137 should fix the issue. You can follow the file changes to register your webhook handler. You might need to change https://github.com/Shopify/shopify-app-template-ruby/pull/137/files#diff-426ab93ca0ca0b0481e4a62a91efe2750cdfc3436c977eb33537962cb54c2bc3R83 to your custom redaction job. See webhook documentation for more details on how to add webhook handlers to your app.

Thanks @sle-c ! It worked after add the add_privacy_webhooks method to shopify initializer, and now is receiving correctly the mandatory webhooks.
Just one adjustment that needs to be done in the documentation:
Here: https://github.com/Shopify/shopify-api-ruby/blob/main/docs/usage/webhooks.md#create-a-webhook-handler
Where it says:
module WebhookHandler
  extend ShopifyAPI::Webhooks::WebhookHandler

  class << self
    def handle_webhook(data:)
      puts "Received webhook! topic: #{data.topic} shop: #{data.shop} body: #{data.body} webhook_id: #{data.webhook_id} api_version: #{data.api_version"
    end
  end
end

It should be:
  class << self
    def handle(data:)
      puts "Fired handle_webhook"
      puts "Received webhook! topic: #{data.topic} shop: #{data.shop} body: #{data.body} webhook_id: #{data.webhook_id} api_version: #{data.api_version}"
      perform_later(topic: data.topic, shop_domain: data.shop, webhook: data.body)
    end
  end

The handle_webhook method does not exist in ShopifyAPI::Webhooks::WebhookHandler, it should be handle, also had a little syntax error.

Thanks @sle-c ! It worked after add the add_privacy_webhooks method to shopify initializer, and now is receiving correctly the mandatory webhooks.
Just one adjustment that needs to be done in the documentation:
Here: https://github.com/Shopify/shopify-api-ruby/blob/main/docs/usage/webhooks.md#create-a-webhook-handler
Where it says:
module WebhookHandler
  extend ShopifyAPI::Webhooks::WebhookHandler

  class << self
    def handle_webhook(data:)
      puts "Received webhook! topic: #{data.topic} shop: #{data.shop} body: #{data.body} webhook_id: #{data.webhook_id} api_version: #{data.api_version"
    end
  end
end

It should be:
module WebhookHandler
  extend ShopifyAPI::Webhooks::WebhookHandler

  class << self
    def handle(data:)
      puts "Fired handle_webhook"
      puts "Received webhook! topic: #{data.topic} shop: #{data.shop} body: #{data.body} webhook_id: #{data.webhook_id} api_version: #{data.api_version}"
      perform_later(topic: data.topic, shop_domain: data.shop, webhook: data.body)
    end
  end
end

The handle_webhook method does not exist in ShopifyAPI::Webhooks::WebhookHandler, it should be handle, also had a little syntax error.

+1 on this - very confusing.

Thanks for flagging I put up a PR to resolve this!
We also welcome PRs for docs, or any updates, so feel free to open a PR for this sort of thing!


Systemtests fix clean iot

Type of change
Fix iot config cleanup

Bugfix

Description
IoT manager cannot delete iotconfig because it tried to remove it from non exists namespace. I changed building of iot config in systemtest to add namespace into metadata.
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[x] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests profile=acceptance test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: acceptance
TEST_CASE:
TOTAL: 41
PASS: 39
FAIL: 0
SKIP: 2


Update sqlx to 0.8

Would you mind providing a PR description that explains why the trait HasArguments is getting replaced with the Database one, and what (if any) breaking changes are introduced by sqlx 0.8?


compile problem

when make
/home/wzl/tiscamera/src/gstreamer-1.0/gsttcambin.cpp: In function ‘GstStateChangeReturn gst_tcam_bin_change_state(GstElement*, GstStateChange)’:
/home/wzl/tiscamera/src/gstreamer-1.0/gsttcambin.cpp:1257:14: error: ‘GST_STATE_CHANGE_PLAYING_TO_PLAYING’ was not declared in this scope
case GST_STATE_CHANGE_PLAYING_TO_PLAYING:
^
In file included from /usr/include/gstreamer-1.0/gst/gst.h:54:0,
from /home/wzl/tiscamera/src/gstreamer-1.0/gsttcambin.h:20,
from /home/wzl/tiscamera/src/gstreamer-1.0/gsttcambin.cpp:17:
/home/wzl/tiscamera/src/gstreamer-1.0/gsttcambin.cpp:1259:75: error: ‘gst_state_change_get_name’ was not declared in this scope
GST_INFO("Changing state: %s", gst_state_change_get_name(trans));
^
/usr/include/gstreamer-1.0/gst/gstinfo.h:546:31: note: in definition of macro ‘GST_CAT_LEVEL_LOG’
(GObject *) (object), VA_ARGS);    \

That is strange, because it is defined in element.h:
https://github.com/alessandrod/gstreamer/blob/master/gst/gstelement.h, see line 257.
Did you install all dependencies with ./scripts/dependency-manager install after cloning?
Which Ubunutu version do you use? I tested on 18.04, 20.04 and 20.10
Stefan

Hi,
Same problem here. I've run all the dependencies

In function ‘GstStateChangeReturn gst_tcam_bin_change_state(GstElement*, GstStateChange)’:
/home/corealis/tiscamera/src/gstreamer-1.0/gsttcambin.cpp:1257:14: error: ‘GST_STATE_CHANGE_PLAYING_TO_PLAYING’ was not declared in this scope
case GST_STATE_CHANGE_PLAYING_TO_PLAYING:
^
In file included from /usr/include/gstreamer-1.0/gst/gst.h:54:0,
from /home/corealis/tiscamera/src/gstreamer-1.0/gsttcambin.h:20,
from /home/corealis/tiscamera/src/gstreamer-1.0/gsttcambin.cpp:17:
/home/corealis/tiscamera/src/gstreamer-1.0/gsttcambin.cpp:1259:75: error: ‘gst_state_change_get_name’ was not declared in this scope
GST_INFO("Changing state: %s", gst_state_change_get_name(trans));
^
/usr/include/gstreamer-1.0/gst/gstinfo.h:546:31: note: in definition of macro ‘GST_CAT_LEVEL_LOG’
(GObject *) (object), VA_ARGS);
^
/home/corealis/tiscamera/src/gstreamer-1.0/gsttcambin.cpp:1259:13: note: in expansion of macro ‘GST_INFO’
GST_INFO("Changing state: %s", gst_state_change_get_n
^
src/gstreamer-1.0/CMakeFiles/gsttcambin.dir/build.make:62 : la recette pour la cible « src/gstreamer-1.0/CMakeFiles/gsttcambin.dir/gsttcambin.cpp.o » a échouée
make[2]: *** [src/gstreamer-1.0/CMakeFiles/gsttcambin.dir/gsttcambin.cpp.o] Erreur 1
CMakeFiles/Makefile2:716 : la recette pour la cible « src/gstreamer-1.0/CMakeFiles/gsttcambin.dir/all » a échouée
make[1]: *** [src/gstreamer-1.0/CMakeFiles/gsttcambin.dir/all] Erreur 2
Makefile:149 : la recette pour la cible « all » a échouée
make: *** [all] Erreur 2

I'm running 16.04 LTS 32 bits version. Could it be the problem ?
Thank you for your time, Théo

Hello

I'm running 16.04 LTS 32 bits version. Could it be the problem ?
Maybe, but I think, it is rather not the issue. Did you run an apt-get update and apt-get updated in order to update the installed packages?

Stefan

Hello,
Yes the installation of the linux has been made just before and the procedure has been followed multiples times and always the same error.
Thank you for your rapid answer, have a nice day
Theo

Hello Theo
I searched in the internet for that error and found https://askubuntu.com/questions/1144952/can-not-open-setting-in-ubuntu-18-04
maybe this helps.
Stefan

Problem was solved installing 20.04 LTS on a new 64 bits PC work perfectly. I've followed exact same procedure. I'm thinking if it's not the 16.04 or the 32 bits who was the problem.
Thanks you, Théo


What did 0.12 change?

We found out that version 0.12 was released today, but not as usual, the change log contains almost nothing about what have changed.
Where can we find the change log? We need it to guide our upgrade process.

Hopefully @ide will add some more info over time. It's a community effort, got to be patient :)

FYI I'm focusing on the 0.13 release. @mkonicek has a better idea of what's in 0.12 than I do.

can Version 0.12  support load remoteJS by url?

@yipengmu Not yet on Android but there's a open PR which we can cherry-pick to 0.13.

Anyone still on this?

@mkonicek +1 for cherry-picking it

For reference that PR is https://github.com/facebook/react-native/pull/3189
We're focused on the 0.13 release now, for now your best bet is looking at the commits, sorry there are no detailed release notes for 0.12: https://github.com/facebook/react-native/releases/tag/v0.12.0

Getting lots of weird errors after upgrading from 0.11.4 to 0.12. I feel there are some required upgrade aspects that are not documented and that are not solved by simply removing node-modules/react-native and reinstalling

This sometimes helps, but not in this case

Close Xcode
rm -rf ~/Library/Developer/Xcode/DerivedData/*
cd $TMPDIR
rm react-packager-cache-*

First, I get a syntax error in packager.js that is basically the parser not recognizing es6 object literal shorthand. After I manually fix this, I get
Error: Error validating module options: child "platform" fails because ["platform" is required]
	at /Users/Shared/java/projects/project/node_modules/react-native/packager/react-packager/src/lib/declareOpts.js:60:13
	at /Users/Shared/java/projects/project/node_modules/react-native/packager/react-packager/src/Server/index.js:161:20
	at tryCallOne (/Users/Shared/java/projects/project/node_modules/react-native/node_modules/promise/lib/core.js:37:12)

So, I'm assuming some undocumented external dependency needs to be updated

https://github.com/facebook/react-native/issues/2645


Revert "feat(federation): when federation is activated, use cluster mode"

Reverts gravitee-io/gravitee-api-management#7962

revert to add the additionnal plugin automatically


Transactions between two databases

Can I make a transaction between two databases with rollback in case one of them fails? I am inserting the same information in two databases, Mysql and SQL SRV

Sorry, the repo is not open for support questions. Please open one in the forum.


Potential IP spoofing vulnerability with AWS ELB (x-forwarded-for)

Before diving in, I should mention that I haven't used nax-ipware, but while reading up on it, I noticed something that could be an issue.
It seems that the nax-ipware makes some assumptions that might not be correct. Amazon's docs state:

Elastic Load Balancing stores the IP address of the client in the X-Forwarded-For request header and passes the header to your server. If the X-Forwarded-For request header is not included in the request, the load balancer creates one with the client IP address as the request value. Otherwise, the load balancer appends the client IP address to the existing header and passes the header to your server. The X-Forwarded-For request header may contain multiple IP addresses that are comma separated. The left-most address is the client IP where the request was first made. This is followed by any subsequent proxy identifiers, in a chain.

This isn't written very clearly - with regard to spoofing, we're concerned with the case in which the X-Forwarded-For request header is included in the request (the "Otherwise..." sentence above).
In this case, the client's IP address is not the leftmost. However, regarding X_FORWARDED_FOR , nax-ipware's docs state:

Load balancers or proxies such as AWS ELB (default client is left-most [<client>, <proxy1>, <proxy2>])

Some experimentation confirms that the client's IP address is not left-most in the case in which the header is provided. I added a spoofed IP address to the header in question in my test app using the following:
xhr.setRequestHeader('x-forwarded-for', '<IP_ADDRESS>');

Once the request comes in to my app from ELB, the x-forwarded-for header value is "<IP_ADDRESS>, w.x.y.z", where "w.x.y.z" is my actual client's IP address.
Am I misinterpreting the nax-ipware docs? It seems that the quote from the docs above might be more accurately written as:

Load balancers or proxies such as AWS ELB (default client is left-most [<client>, <proxy1>, <proxy2>]), but only if the header was originally empty.

It seems that if there's a chain of proxies and a forged x-forwarded-for header, the value of the header would really be something like <forged>, <client>, <proxy1>, <proxy2>.
Are you seeing things differently on your end? Looking forward to hearing your thoughts on this - seems there's some disagreement/confusion online due to the clumsy wording of the AWS docs.

@rinogo nax-ipware doesn't detect ip spoofing out of the box. However, it can be configured to detect it.

When X-Forwarded-For is detected, the initial order is left-most as per

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For
You can change this behaviour by passing in right-most as the order of ips
https://github.com/neekware/fullerstack/blob/04d63fed73e9424eb5133048e725fd36b6ee809d/libs/nax-ipware/src/lib/ipware.model.ts#L23

Spoofing is possible when one of the proxies is rouge

Use trusted proxies, along with proxy count, to bring "trust" to your connection path

It seems that <forged>, <client>, <proxy1>, <proxy2>, is coming through proxies, and the last proxy is not trusted, otherwise, it wouldn't have injected a bad ip address.

Please have a look at the test cases! all scenarios have been covered.  If a test doesn't provide proper options, but injects spoofed data, ipware will happily report the spoofed data.  So, pass the proper option in.
Feel free to raise PRs should you find a bug! If they are security related, you can email the issue instead of raising an issue.
Hope this helps


how to get pcontext-full dataset

Thanks for you great work! I met a problem when i prepare the dataset

What value should I set for anno dir?
i guess the anno dir should be set "dataset/pcontext-full/VOCdevkit/VOC2010/Annotations" but "xml" is not compatible with 'mat' which assigned in code?
what should i do?

You can download it from here. http://www.eecs.berkeley.edu/Research/Projects/CS/vision/grouping/semantic_contours/benchmark.tgz

oh!  Thanks


Fix build fail if auto-generated headers doesn't exists

Build failing after project clone. Issue is that auto-creating headers are not executed before compilation of files that are dependent on them.
src/help.c:3:10: fatal error: src/misc/default_font.h: No such file or directory
    3 | #include "src/misc/default_font.h"
src/br_shaders.c:9:14: fatal error: src/misc/shaders.h: No such file or directory
    9 | #    include "src/misc/shaders.h"

Fix - creating of auto-generated headers before compilation of source files are enforced by including them as prerequisites for all object files.
Btw, great job!

Nice, thanks :)


chore(cloud-sources): add telemetry for cloud sources

Description
Add telemetry for the number of cloud source integrations as well as the different types.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
N/A.
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Current dependencies on/for this PR:

#10053  👈
master

This stack of pull requests is managed by Graphite.

Do you mind running a local test targeting the development telemetry project?

@0x656b694d can confirm with a local test on the dev telemetry key that we receive the expected properties:

/retest


[fix][test] Fix SimpleProducerConsumerTest.testMultiTopicsConsumerImplPauseForManualSubscription

Fixes #23485
Motivation
After calling pause(), there are still messages retained in incomingMessages because the internal consumer has already pre fetched a message and placed it in incomingMessages.
When calling pause(), these pre fetched messages are not immediately cleared, causing instability as messages can still be received during testing.
Modifications
A larger receiverQueueSize allows more messages to be prefetched and cached, ensuring that messages in the buffer are effectively managed after a pause operation, without causing message interference during testing.
In a multi topic consumer environment, the receiverQueueSize should be set reasonably. For multi topic consumers, the receiver Queue Size should be large enough to ensure that each internal ConsumerImpl instance can independently perform message prefetching without interfering with each other.
receiverQueueSize  1 -> 6
Verifying this change

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.32%. Comparing base (bbc6224) to head (2cd1dfb).
Report is 713 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23546      +/-   ##
============================================
+ Coverage     73.57%   74.32%   +0.75%
- Complexity    32624    34331    +1707
============================================
  Files          1877     1943      +66
  Lines        139502   147050    +7548
  Branches      15299    16209     +910
============================================
+ Hits         102638   109299    +6661
- Misses        28908    29313     +405
- Partials       7956     8438     +482

Flag
Coverage Δ

inttests
27.37% <ø> (+2.78%)
:arrow_up:

systests
24.32% <ø> (-0.01%)
:arrow_down:

unittests
73.72% <ø> (+0.87%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 654 files with indirect coverage changes


Sample results is weird during lcm training

Hi everyone, I'm trying to train a LCM model based on sd1.5, but I'm encountering blurry sample images during the training process.
I have mostly followed the official training codes, with the exception of adding some size and cropping conditions, similar to what was done in sdxl.
Here is an example, around 20k iterations.

Hello, have you solved this problem? I encountered a similar problem.

+1


HI i want pull request

thanks m8

First off, this branch is not being used, also, if you are going to make a pull request please git rebase first to sync the changes.


[improve](table function) opt explode/explode_map/explode_json table function

before get_value, it's will insert one row into column once,
now could insert many result into column once, could reduce some virtual function call
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


Adding NAT EIPs in ES access policy (whitelist)

In order to send logs to Elasticsearch using NAT service, we have to whitelist NAT EIPs

Looks like you broke a unit test or two. Also there should probably a unit test that explicitly makes sure those values are getting added.

👍


[Solved] Grid creator issue #328

Solved Issue
Files To Check

modules/grids/grid_328_Jakkam_Akshitha.html

Added Assets

modules/grids/images_and_icons/issue_328_icon_1.jpg

modules/grids/images_and_icons/issue_328_icon_2.jpg

modules/grids/images_and_icons/issue_328_icon_3.jpg

modules/grids/images_and_icons/issue_328_icon_4.jpg

Thank you for the help.
I have one more issue to be reviewed. Could you please check that:
https://github.com/KwickerHub/WebCraftifyAI/pull/795
User name: Akshitha-Jakkam
Thank you
Akshitha
On Wed, Nov 29, 2023, 9:06 AM github-merge-queue[bot] <
@.***> wrote:

Merged #793 https://github.com/KwickerHub/WebCraftifyAI/pull/793 into
dev.
—
Reply to this email directly, view it on GitHub
https://github.com/KwickerHub/WebCraftifyAI/pull/793#event-11096900270,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAPEJR5T7YGYT4YOLMQXFVDYG46NHAVCNFSM6AAAAAA7TTCUM2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGA4TMOJQGAZDOMA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


unable to run

spfx 1.10.0 , latest chrome on windows. i saw "Initialized ClientSideExtensionHelper" in debugger, but i also have this error:
suiteux.shell.plus.56e22b40b087f443cfc8.js:144 Refused to load the script 'https://r4.res.office365.com/footprint/v3.2/scripts/fp-min.js' because it violates the following Content Security Policy directive: "script-src 'self' https://contentstorage.osi.office.net https://swx.cdn.skype.com https://res.delve.office.com https://lpcres.delve.office.com https://static.sharepointonline.com https://widget.uservoice.com https://by2.uservoice.com https://www.bing.com/api/maps/ https://www.bing.com/rms/ https://spoprod-a.akamaihd.net https://fabriciss.azureedge.net https://publiccdn.sharepointonline.com https://ajax.aspnetcdn.com https://spoprod-a.akamaihd.net/files/odsp-next-prod-webpack_2020-02-28-sts_20200310.001/ https://r1.res.office365.com https://webshell.suite.office.com https://shellux.msocdn.com https://shellprod.msocdn.com https://shellppe.msocdn.com https://mem.gfx.ms https://amcdn.msftauth.net https://shellprod.msocdn.com https://c1-excel-15.cdn.office.net https://c1-onenote-15.cdn.office.net https://c1-powerpoint-15.cdn.office.net https://c1-visio-15.cdn.office.net https://c1-word-view-15.cdn.office.net 'unsafe-eval' 'nonce-1f480e64-1d78-4c7f-af5e-897e52a73600'". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.
so my extension can't run, please help
thanks
Peter

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbc14882-1021-df0e-73c1-95d049f091d7
Version Independent ID: eda24750-4e60-f05c-a6bb-0cc017dfe9ed
Content: Build your first Field Customizer extension
Content Source: docs/spfx/extensions/get-started/building-simple-field-customizer.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Hi! Can you please provide more information for your issue? Are you able to share the code you are using by chance?
Based on the error, my initial thoughts are it looks as though you may be trying to do inline scripting which is bad practice and being blocked by the browser.

As @bcameron1231 implies, impossible to help without more context, seeing the code, etc.


Add ContributingGuidelines.md

The Contributing Guideline documentation will contain set of guidelines that will help contributors during the contribution process.
File type markdown.

@apoorvaron Could you please assign this issue to me under GSSOC 23.
Thank you!

Okay ! Start Contributing

@apoorvaron Added PR #36
Please review it.

@shanvijha30 done

Tag me there


Replace usage of is_tiled with tests of block shapes

This future proofs rio-cogeo and makes it more strictly conforming to what the official GDAL COG checker does.
Background: https://github.com/rasterio/rasterio/discussions/3014.

thanks @sgillies 🙏
really appreciate you putting time on this. Merci


Automate docker hub update

Currently the Action can only be manually triggered. It would be best to automatically publish a :latest on all commits to master and tagged versions when you publish tags/releases (+ optionally a stable tag for the stable releases).

Hi @NicolasCARPi I did this today.
The way it works is:

Whenever a push is made to master in the backend or frontend repository, there is a push to dockerhub with latest

For the frontend repository, and extra latest-syc-base is also published, with the /syc/ backend settings.

When a release is made from the backend / frontend, an image tagged with the version number is published, as well as a prod tagged image.

In the frontend the syc-base versions are also included

This means that:

latest: latest master
prod: latest release

In this repository, for the image that combines both frontend and backend, it's similar but I will still trigger the releases by hand, just to make sure that both frontend and backend are in sync with each other, so you can use latest and prod as before, as well as the release tag. Also, the release contains info of the release tags of backend and frontend.
A bit confusing admittedly but I think the tags in docker-hub are self-explaining:
https://hub.docker.com/repository/docker/manulera/shareyourcloning/tags

You can also access the version in the app now:
https://shareyourcloning.org/ At about > App version
And in the API:
https://shareyourcloning.api.genestorian.org/version

Hey @NicolasCARPi how is it going? Do you think you can give me a version to start from sometime soon?

I will come back to you soon, yes.


Controller Binding (web view loads blank)

Blank unity project.
Import SteamVR
Save+Gen Input
Create new action set (per hand)
add a few actions in
Save+Gen Input
open UI bindings
click Edit for current binding
loads blank page... just solid dark blue background.
http://localhost:8998/dashboard/controllerbinding.html?app=application.generated.unity.steamvr.exe
I delete the added action set, save+gen input, open bindings / edit current and it opens as it should.
not sure what is causing the blank loading.. anyone else having this problem?
Unity 2018.2.11f1 + latest git of SteamVRUnity

looks like we've got a bug with capital letters in action sets. We'll get that fixed soon. There's some other bugs that we've fixed relating to the binding ui in the SteamVR Beta, are you in that branch?

yes, I'm using SteamVR Beta.

Days I'd say

On Friday I was able to set bindings for the Touch, Knuckles and Wands, but I had to deal with a similar issue. The web application would work right up to the point where I would try to assign a binding to the trigger.  After that, I would always get a blank page when trying to edit my bindings. After looking at the javascript in the web application, I noticed that it was throwing an error "Cannot read property 'length' of undefined" when trying to access the SelectedActionSetHaptics property.
My XXXXXXXXXXXXXXXXXX_legacy.bin file looked like this after I created a fresh binding with the web application.
{
   "app_key" : "application.generated.unity.testing.exe",
   "bindings" : {
      "/actions/default" : {
         "sources" : [
            {
               "inputs" : {},
               "mode" : "none",
               "path" : "/user/hand/left/input/trigger"
            }
         ]
      }
   },
   "controller_type" : "knuckles",
   "description" : "",
   "name" : "My [Testing] configuration for Knuckles Controller"
}

I compared that to a working .bin file and I noticed that the haptics, poses and skileton properties were not present. So I added them and the web application started working.
{
   "app_key" : "application.generated.unity.testing.exe",
   "bindings" : {
      "/actions/default" : {
         "haptics" : [],
         "poses" : [],
         "skeleton" : [],
         "sources" : [
            {
               "inputs" : {},
               "mode" : "none",
               "path" : "/user/hand/left/input/trigger"
            }
         ]
      }
   },
   "controller_type" : "knuckles",
   "description" : "",
   "name" : "My [Testing] configuration for Knuckles Controller"
}

I am using SteamVR beta with Unity 2018.2.10f1. I was able to recreate the problem in a test application.
I wonder if this is the same problem that @KavanBahrami is experiencing?

Perhaps, though my actions/default has those properties, with the default inputs/paths
 "poses" : [             {                "output" : "/actions/default/in/pose",                "path" : "/user/hand/left/pose/raw"             },             {                "output" : "/actions/default/in/pose",                "path" : "/user/hand/right/pose/raw"             }          ],          "skeleton" : [             {                "output" : "/actions/default/in/skeletonlefthand",                "path" : "/user/hand/left/input/skeleton/left"             },             {                "output" : "/actions/default/in/skeletonrighthand",                "path" : "/user/hand/right/input/skeleton/right"             }          ],

The latest<PHONE_NUMBER> SteamVR Beta fixed the black screen problem for me. However now when I press the "Open binding UI" button in the SteamVR Input inspector it goes to the "Choose an application to edit" page, instead of my project's binding page. There doesn't seem to be a way to get to the project binding page from the binding home page.
The URL in the browser points to:
http://localhost:8998/dashboard/controllerbinding.html?app=application.generated.unity.InputTestProject.exe

Yeah @Clavilux, looks like there's an issue where that link is no longer resolving properly. We'll get that fixed up.

This should be fixed from last night's beta. Anybody still having issues? @Clavilux @KavanBahrami @jcrapsey

I'm on 3227723 beta and are getting a blank screen when hitting the Open binding UI button

@AndersMalmgren Is this in a new project or one you've modified? If modified can you post your actions.json?

@zite Hey Zite, its a new project only loaded the demo and tested it and are now starting to look into how to apply this to our pretty advanced game (Tons of feedback for you guys :D).
I added my own action if that counts as modified. Here it is
{
  "actions": [
    {
      "name": "/actions/default/in/InteractUI",
      "type": "boolean"
    },
    {
      "name": "/actions/default/in/Teleport",
      "type": "boolean"
    },
    {
      "name": "/actions/default/in/GrabPinch",
      "type": "boolean"
    },
    {
      "name": "/actions/default/in/GrabGrip",
      "type": "boolean"
    },
    {
      "name": "/actions/default/in/Pose",
      "type": "pose"
    },
    {
      "name": "/actions/default/in/SkeletonLeftHand",
      "type": "skeleton",
      "skeleton": "/skeleton/hand/left"
    },
    {
      "name": "/actions/default/in/SkeletonRightHand",
      "type": "skeleton",
      "skeleton": "/skeleton/hand/right"
    },
    {
      "name": "/actions/default/in/Squeeze",
      "type": "vector1",
      "requirement": "optional"
    },
    {
      "name": "/actions/default/in/MyGrab",
      "type": "boolean",
      "requirement": "suggested"
    },
    {
      "name": "/actions/default/out/Haptic",
      "type": "vibration"
    },
    {
      "name": "/actions/platformer/in/Move",
      "type": "vector2"
    },
    {
      "name": "/actions/platformer/in/Jump",
      "type": "boolean"
    },
    {
      "name": "/actions/buggy/in/Steering",
      "type": "vector2"
    },
    {
      "name": "/actions/buggy/in/Throttle",
      "type": "vector1"
    },
    {
      "name": "/actions/buggy/in/Brake",
      "type": "boolean"
    },
    {
      "name": "/actions/buggy/in/Reset",
      "type": "boolean"
    }
  ],
  "action_sets": [
    {
      "name": "/actions/default",
      "usage": "single"
    },
    {
      "name": "/actions/platformer",
      "usage": "single"
    },
    {
      "name": "/actions/buggy",
      "usage": "single"
    }
  ],
  "default_bindings": [
    {
      "controller_type": "vive_controller",
      "binding_url": "bindings_vive_controller.json"
    },
    {
      "controller_type": "oculus_touch",
      "binding_url": "bindings_oculus_touch.json"
    },
    {
      "controller_type": "knuckles",
      "binding_url": "bindings_knuckles.json"
    },
    {
      "controller_type": "holographic_controller",
      "binding_url": "bindings_holographic_controller.json"
    }
  ],
  "localization": [
    {
      "language_tag": "en_US",
      "/actions/default/in/InteractUI": "Interact With UI",
      "/actions/default/in/Teleport": "Teleport",
      "/actions/default/in/GrabPinch": "Grab Pinch",
      "/actions/default/in/GrabGrip": "Grab Grip",
      "/actions/default/in/SkeletonLeftHand": "Skeleton (Left)",
      "/actions/default/in/SkeletonRightHand": "Skeleton (Right)",
      "/actions/default/in/Pose": "Pose",
      "/actions/default/out/Haptic": "Haptic",
      "/actions/buggybuddy/in/Steering": "Steering",
      "/actions/buggybuddy/in/Throttle": "Throttle",
      "/actions/buggybuddy/in/Brake": "Brake",
      "/actions/buggybuddy/in/Reset": "Reset",
      "/actions/platformer/in/Move": "Move",
      "/actions/platformer/in/Jump": "Jump",
      "/actions/default/in/MyGrab": "Grab 2"
    }
  ]
}

Hmm, I don't see anything odd there, can you open the javascript console in your browser and tell me what the errors are when you see the blank binding ui?

Yeah sure. here it is
Failed to load resource: the server responded with a status of 404 (Not Found)
controllerbindingui.6e8c11c0582d21f993d1.js:5 FAILED TO INITIALIZE BINDINGUI Error: Request failed with status code 404
    at FtD3.e.exports (vrwebui_core.b96aeed388571ce90310.js:18)
    at e.exports (vrwebui_core.b96aeed388571ce90310.js:13)
    at XMLHttpRequest.f.(:8998/dashboard/anonymous function) (http://localhost:8998/dashboard/vrwebui_core.b96aeed388571ce90310.js:13:124524)
:8998/dashboard/localization/webhelper_swedisn.json:1 Failed to load resource: the server responded with a status of 404 (Not Found)

This should be fixed from last night's beta. Anybody still having issues? @Clavilux @KavanBahrami @jcrapsey

Sorry @zite , I was off the weekend. I just updated to SteamVR Beta<PHONE_NUMBER>) and everything seems to work perfectly now. Thank you for your help!

Yeah sure. here it is
Failed to load resource: the server responded with a status of 404 (Not Found)
controllerbindingui.6e8c11c0582d21f993d1.js:5 FAILED TO INITIALIZE BINDINGUI Error: Request failed with status code 404
    at FtD3.e.exports (vrwebui_core.b96aeed388571ce90310.js:18)
    at e.exports (vrwebui_core.b96aeed388571ce90310.js:13)
    at XMLHttpRequest.f.(:8998/dashboard/anonymous function) (http://localhost:8998/dashboard/vrwebui_core.b96aeed388571ce90310.js:13:124524)
:8998/dashboard/localization/webhelper_swedisn.json:1 Failed to load resource: the server responded with a status of 404 (Not Found)

Can you try to uninstall and reinstall steamvr? It sounds like something may have failed to update properly. And make sure when you reinstall you're on the beta.

@zite Hey again. I uninstalled it an reinstalled. Then moved to beta., Its says im on 3230788
Same error
Failed to load resource: the server responded with a status of 404 (Not Found)
controllerbindingui.874a5d58a2d28d4a451a.js:5 FAILED TO INITIALIZE BINDINGUI Error: Request failed with status code 404
    at FtD3.e.exports (vrwebui_core.f6de8fe4f12486ddd792.js:18)
    at e.exports (vrwebui_core.f6de8fe4f12486ddd792.js:13)
    at XMLHttpRequest.f.(:8998/dashboard/anonymous function) (http://localhost:8998/dashboard/vrwebui_core.f6de8fe4f12486ddd792.js:13:124527)
:8998/dashboard/localization/webhelper_swedisn.json:1 Failed to load resource: the server responded with a status of 404 (Not Found)

Any news on this guys? This hinders my work on porting to 2.x greatly

Can you open the binding ui from the SteamVR menu? SteamVR App Menu -> Devices -> Controller Input Binding

I believe we've found the issue @AndersMalmgren, typo in the Swedish language filename. Fix should be coming in the next beta.

Ok this should be fixed in the beta released a few hours ago. Can you retest?

@zite I'm away over the weekend, will try first thing when I'm back

@zite It seems to work for me know.

Hey there !
I'm experiencing the same problem with my Unity Project when trying to Create/Edit a binding. I can open the Binding UI, but then, when clicking on Create Binding or simply Edit Binding, it just renders an empty screen ...

Just to give you all the info, I've removed all the actions sets that I didn't use (So default, buggy and platform) and created my own in the same actions.json.

Hey @zite , no I was on the legacy one, not on the alpha. I just switched to it, I'll try it in the next days and come back to you then ! Thanks :)

Got the same issue. I applied a workaround by fixing the JS file so now the binding page loads correctly. But the problem I am facing is, I want to publish a SteamVR app over Steam in a few days and a) that's not a solution for my customers and b) I cannot rely on the beta version either because the users will probably sit on the main branch. So my question is: if the fix works in the beta when will the fix be merged into the main branch?
Another question. How can I delete a controller binding? I have added a test binding that I cannot seem to get rid of. I re-installed SteamVR and searched my AppData directories for any files but the test binding is still there.

@glock00  can you elaborate on how you fixed the js file?
because in my case the interface seems to have trouble loading the file as well.
It just says loading and then quits the process and goes back to default window. (see my Post #197 for details)

@Intersebbtor
Basically you need to find the correct JS file by checking the error with the browser console and find the correct file on your system.
There's a post in the OpenVR repo that handles the JS issue too:
Error description:
https://github.com/ValveSoftware/openvr/issues/852#issuecomment-412298274
I then pretty much followed the advice given from: https://github.com/ValveSoftware/openvr/issues/852#issuecomment-418202107
Make sure to "shift"-reload the page in order to see the changes. Hope that helps.


FUSETOOLS2-1822: UI test for value update with debugger

Related: https://issues.redhat.com/browse/FUSETOOLS2-1822
Test result:

test looks fine, but it would be nice to handle SonarCloud code analysis report


Document public API surface area

The docs website should contain API documentation for every exported member of the core compiler and standard library. Most important (I believe) are:

The shape of the type graph (especially Types)
The exported members of the program interface
The program host object (since using FS directly is an anti-pattern)

est: 8


Update DEPLOY with answer to XX1: can <IP_ADDRESS> be location of server

No!
It appears on the client side, Tor will refuse to ask an exit to connect to <IP_ADDRESS>.

Nice that actually i tested it and run into it :)