Add logical && and ||. Rename R.and -> R.both, and R.or -> R.either

Fixes #843
Decided to skip ! for now.

:thumbsdown: from me for the reasons given here and here.
If we are to make this change I strongly believe R.not should change as well.

If we are to make this change I strongly believe R.not should change as well.

:+1: to that. If not nix, maybe anti will do.
Otherwise, I am fine with this; I understand @davidchambers 's objections to the JS-iness of it. But it seems essential to me to be able to compose with these kinds of truthy comparisons. If you must force to Boolean, you could always compose(Boolean, or)('moo', 'cow')

Yeah. It seemed off to reject it just it just because it has all the problems that the JS one does. We don't reject R.add because it works on strings

Yeah. It seemed off to reject it just it just because it has all the problems that the JS one does. We don't reject R.add because it works on strings

:+1:
This library will always exist in some tension between being familiar to JS developers and being comfortable for developers more familiar with more strongly-FP languages.  I don't know that there are any overall guidelines, but to me this decision is pretty easy: these functions are meant to work like add, modulo, etc., producing functions that act like language operators.  That these ones can't quite do that is the only thing that makes me hesitate (https://github.com/ramda/ramda/issues/843#issuecomment-76114415) but on balance they still seem worth having.
That they can be used to create bad code bothers me very little.  Heck, we include forEach, which I would much rather not have, as I think that's much more likely to lead to bad code, but certain exigencies forced it on us.

@jethrolarson can you please squash to one commit? then i think we are good to go.
Sorry @davidchambers you can't win them all -- and you have been on a winning streak!

aw, bugger, it's out of date. @jethrolarson can you please rebase & amend? i will merge promptly

@buzzdecafe Done.


Serializer type name for anonymous classes

This addresses #6344.  A helper static method is introduced that walks up the class chain to find a usable class name.  Existing Java tests are modified and a Scala test is added.

cool thanks i will test this shortly.


Creating various stored procedures

System information:

Operating system: Ubuntu 19.04
DBeaver version: 6.1.0

Connection specification:

Database name and version: Informix

Describe your question:
I'm having a problem similar to #2692, trying to execute large scritps with many create procedure statements, but semicolons in the body of the procedures break the automatic execution. Is there any workaround other than exectuing each block separately? Delimiter statement is not working either

Is it still actual for you?

It was a particular problem I solved at the moment, I can't provide any query as it is already solved


Update how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md

Clarify how limits are applied to address some customer's inquiry.
Category

[x] Content fix
[ ] New article
[x] Example checked item (delete this line)

DELETE THIS LINE BEFORE SUBMITTING | For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

DELETE THIS LINE BEFORE SUBMITTING | If this fixes (aka: closes) or references an issue, please reference it here. This helps maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.

What's in this Pull Request?

DELETE THIS LINE BEFORE SUBMITTING | Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Submission guidelines

!!IMPORTANT!! - All submissions must complete the baseline sections included in this template. Ignoring or deleting this template may result in closing the issue with the label type:incomplete-submission.
Follow our guidance on How To Create Good Pull Requests.
Target the master branch of this repo. Released documents are in live branch.

DELETE THIS SECTION BEFORE SUBMITTING

Docs Build status updates of commit fa6c10a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Unable to delete previously used media

Describe the bug
A clear and concise description of what the bug is.
I am unable to delete used media from one particular day. I am able to hide the media, and am able to add new media and delete the new media, but able to delete 5 photos.
To Reproduce
Steps to reproduce the behavior:

Add media
Click on delete
See error "Cannot Delete File!

Expected behavior
To be able to delete the media
Screenshots
I have included a screenshot of the error.

Desktop (please complete the following information):

Windows version 11
No other info about my environment.

I also uninstalled the program and reinstalled it to make sure I had the updated version and the photos were still in the program after uninstalling it from the computer and reinstalling it.

@FowlerColorado Perhaps you don't have permission to delete the images. Can I suggest you open the media folder and see if they can be deleted from there? Proceed as follows: Click the folder icon at the bottom right of the OnlyM window to open the File Explorer window. Try to delete the relevant images from within File Explorer noting any error messages.

We have been able to delete files for the past 4-6 months. It is only these 5 images that we cannot delete. I can add more images and delete them ok. And even hide the undeletable images and add new ones and show and then delete those. However I will attempt your suggestion today and see if it works!Sent from my iPhoneOn Jul 2, 2023, at 6:59 AM, Antony Corbett @.***> wrote:
@FowlerColorado Perhaps you don't have permission to delete the images. Can I suggest you open the media folder and see if they can be deleted from there? Proceed as follows: Click the folder icon at the bottom right of the OnlyM window to open the File Explorer window. Try to delete the relevant images from within File Explorer noting any error messages.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@FowlerColorado Did you manage to resolve this issue, please?

Salve anche a noi in Sala si presenta lo stesso tipo di problema con 2 foto e un video che si possono nascondere nonostante nella cartella non sia presenta alcun tipo di file. A casa ho il programma e non mi succede.

So I finally was able to delete the photos from the OnlyM program. And the way I was able to was I had to delete the photo’s from the computer itself in files, and then after I did that the photos disappeared from the program.
Sent from my iPhone

On Aug 13, 2023, at 5:35 AM, AlainDema @.***> wrote:
Salve anche a noi in Sala si presenta lo stesso tipo di problema con 2 foto e un video che si possono nascondere nonostante nella cartella non sia presenta alcun tipo di file. A casa ho il programma e non mi succede

@FowlerColorado Thanks - that's the way most users manage the media files, i.e. in Windows File Explorer (which you can access via the folder button bottom right in OnlyM).


Make significant docs change part of (bi)weekly announcements

Include in weekly announcements the docs changes. Talk to Lucas W

I will inlcude a PR to this week announcement and understand how easy it is and it is worthy to automate it

By now I have a reminder to add the docs addition to the weekly announcement. For now I search the docs contributtions using is:pr is:closed closed:>2023-12-21 in the input and getting the message manually. example

This good enough by now, so I close.


Make Merge public again and rename it to Merger

We need to make Merge public again, because the Merge receiver has more methods than a plain Receiver, in particular stop(), which users need to use for guaranteed cleanup.
But in this case it is better to introduce a breaking change to make sure users update to using the new merge() function, so we rename it to Merger. Also using a noun for the name is more in line with the other classes.
This also means now the merge() function returns the Merger instance instead of an abstract Receiver.
Additionally there are a couple of small unrelated cleanups:

Remove darglint-related stuff, it was replaced by pydoclint a while ago.
Remove cookiecutter template TODO comment.

Enabling auto-merge


Hikari for Oracle warning

I am using spring boot 1.4.1 with managed Hikari version 2.4.7.
The Oracle JDBC driver version is <IP_ADDRESS>.
During applicaiton startup, I get following warning:
com.zaxxer.hikari.pool.PoolBase          : HikariPool-1 - Driver does not support get/set network timeout for connections. (oracle.jdbc.driver.T4CConnection.getNetworkTimeout()I)
Is there anything I need to worry about?

Network time out helps in closing broken connections (within specified time) in case of network outage. If not supported, connection may not be notified and removed from pool for 'longer' time (typically os or db level socket time)
upgrade hikaricp to 2.4.9 and If you can not upgrade driver,
you may set following as datasource properties:
config.addDataSourceProperty("oracle.net.CONNECT_TIMEOUT",  N );
config.addDataSourceProperty("oracle.jdbc.ReadTimeout",  N );
specify N in millis and 10 seconds more than maxLifetime
HTH

@dapengdevs Just FYI, I am not seeing that log output when using the Oracle JDBC driver version <IP_ADDRESS>, so it seems to be a limitation with the Oracle JDBC driver version 11.x. I would suggest upgrading the driver.

I've done some perf test with different oracle jdbc clients thin mode on both tcp/sdp modes and...
<IP_ADDRESS> is faster one
<IP_ADDRESS> is -5%
<IP_ADDRESS>.1 is -10%
Please consider also that usually X.1 versions of oracle are something like beta...
since my 7.0... was always same history :))


updating release-0.5 branch to cut a new release

What this PR does / why we need it:
Updating the release 0.5 branch to update go version to go1.21.9 and k8s client libraries to 0.29.4.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/ok-to-test

/lgtm

/retest-required

/lgtm

/approve

/lgtm
/approve


Add Solidity linting and improve coverage for formatting in CI

No linter is currently run on the Solidity code in CI.
Cargo.toml files in examples are not currently covered by Cargo sort.
Cargo.lock files are not ensured to not change.

We should add Slither as well https://book.getfoundry.sh/config/static-analyzers?highlight=remappings#slither


fix: copy from https://github.com/oxalica/rust-overlay/pull/122

resolves https://github.com/shazow/foundry.nix/issues/19

Thank you for finding this, and for the handy comment!


Collecting data?

Are you already running the program to collect data, that we can show at the presentation. Or should I run it the over the next weeek?

2017-02-07T20:43:38+01:00 INFO: Start Analyting Radio stations

That means yes.

Ye, want a spoiler what radiostation repeats songs the most?

Sure ;)

Antenne Charts, only 50 different songs played, and two songs already repeated 32 times


openvpn3: 20 -> 21

Here's the changelog for openvpn3-linux: https://github.com/OpenVPN/openvpn3-linux/releases/tag/v21
I also upgraded openvpn3-core from 3.7.2 to 3.8.4: https://github.com/OpenVPN/openvpn3/compare/release/3.7.2...release/3.8.4
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

openvpn3

It turns out there are DNS lookup domain related bugs in v21 that make it so that I don't want to use it myself. Between that and the glib issues, I guess it's best for nixpkgs to just wait for openvpn v22. Closing this PR.


Does not follow cursor in Vim mode

Describe the bug
When using the built-in Vim mode in VS Code, the preview does not follow the cursor, only if clicking the code.
To Reproduce

Activate Vim mode in VS Code
Start preview
Move the cursor using Vim movement keys

Expected behavior
The preview should move with the cursor.
Package/Software version:
VSCode version(Help -> About):
Version: 1.85.2
Commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
Date: 2024-01-18T06:40:19.222Z
Electron: 25.9.7
ElectronBuildId: 26354273
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.14.0-362.13.1.el9_3.x86_64

typst-preview extension version:
Name: Typst Preview
Id: mgt19937.typst-preview
Description: preview your typst document in instant
Version: 0.10.6
Publisher: mgt19937
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=mgt19937.typst-preview

iirc it also dont track cursor in non-vim mode

we may allow user customize this: sync preview when keyboard/mouse triggered selection change. currently we only respond to mouse events

That would be great, as I never use the mouse for navigation. I think that goes for most people who use the Vim mode.

There is a finished branch, https://github.com/Enter-tainer/typst-preview/tree/scroll-sync-by-keyboard
But I'm not sure whether you will like it, because typst doesn't provide perfect span, so it doesn't scroll your content smoothly.
There is also another solution, you can bind a shortcut to typst-preview.sync, and stroke the key to scroll content. I believe you mostly do writing in a same page.
https://github.com/Enter-tainer/typst-preview/blob/674d203de5bcc2a2b76820efbddf4477e4b02892/addons/vscode/package.json#L67-L73

But I'm not sure whether you will like it, because typst doesn't provide perfect span, so it doesn't scroll your content smoothly.

After testing a bit, I recall that the blocker of this feature, scrolling content by keyboard events, is not inperfect spans, but inaccurate scrolling. Though it is not quite perfect, it is ready to use since we had improved accuracy of scrolling content.

It is merged in https://github.com/Enter-tainer/typst-preview/pull/233.

close since #233


Added cilium script

used cilium cli instead of helm
becuase we need to install helm cli and then install the cilium using helm
instead for now its much better and easier to install the required binary which is in this case cilium
still open for inputs

I have not checked it by running I hope it works
If possible can you check if it works?

@dipankardas011 LGTM! Thank you
I like your approach of using the Cilium CLI instead of Helm and of verifying the SHA.
There is one minor change I'd like to make to use a var for the Cilium version for consistency. I can add that in my branch.

@dipankardas011 LGTM! Thank you
I like your approach of using the Cilium CLI instead of Helm and of verifying the SHA.
There is one minor change I'd like to make to use a var for the Cilium version for consistency. I can add that in my branch.

Sure 😃


PHPMNT-100 Support PHPUnit 9.5 or 10

What?
Reinstate support for PHPUnit 9.5 so we can use the latest injector in bcapp until its PHPUnit version is upgraded.
Tickets / Documentation
Add links to any relevant issues and documentation.

PHPMNT-100

Just curious if we have captured the need to "undo" this anywhere in order to not forget doing so once PHPUnit is upgraded in BcApp?


[CI] Addition of tests for Meshery UI (Umbrella issue)

Description

We have already integrated the Cypress testing framework. Let's start adding more & more tests for our UI.
Tests to be written
Integration Tests(Routes):

[x] ~provider (#1778)~
[ ] /management
[ ] /performance
[x] ~/userpreference (#1853)~
[ ] /smi_results
[ ] /results
[ ] /settings (Environment (#2316), Service Meshes (#2317), Metrics, Performance)
[ ] /index (#2315)
[ ] /configuration (#4582)

E2E Tests(Routes):

[ ] /management
[ ] /performance
[x] ~/userpreference (#1862)~
[ ] /smi_results
[ ] /results
[ ] /settings (~Environment (#2139)~, ~Service Meshes (#2218)~, Metrics, Performance)
[ ] /index
[ ] - [ ] /configuration (#4582)
[ ] Add integration tests for /configuration/applications route
[ ] Add integration tests for /configuration/filters route
[ ] Add integration tests for /configuration/patterns route
E2E Tests (these are more usecase or scenario wise as they'll touch multiple routes and multiple pages in each child issue with actual server responses):
[ ] Add E2E tests to Deploy Applications/Filters/Patterns Configuration through Meshery UI (#4826)
[ ] Add E2E tests to Edit Applications/Filters/Patterns Configuration through Meshery UI
[ ] Add E2E tests to Delete Applications/Filters/Patterns Configuration through Meshery UI"

Additional Context

@kushthedude I can contribute. I will take a look and share the component which I can cover.

@kushthedude I can contribute. I will take a look and share the component which I can cover.

Great! AFAIK provider-ui can work without server, performance page, settings page & results page can render if the server is not working.

@kushthedude I want to contribute to creating tests for the provider-ui. Should I create an issue for this specific route or how can we coordinate this?

@kushthedude I want to contribute to creating tests for the provider-ui. Should I create an issue for this specific route or how can we coordinate this?

Hi @ramrodo , Provider-UI only has single route so I guess we don't need to create a different issue and you can just refer your PR with this issue 😄

@kushthedude I added the label for parent issue given that the title and description call for any number of child issues to be created. It’d be nice to breakout this work into sub-issues.

Let me break the issue down and mention each and every route/tests in the issue description so that we can track the progress as a whole/

@ramrodo it would be great to get a short overview and demo from you on Cypress on Friday's community call. Most community members are unfamiliar with this. Are you available to attend this Friday's community meeting? 10am to 11am Central?

@ramrodo it would be great to get a short overview and demo from you on Cypress on Friday's community call. Most community members are unfamiliar with this. Are you available to attend this Friday's community meeting? 10am to 11am Central?

Sounds good! 11am central works better for me.

Ok, understood. Here is the community calendar with the various meetings we have each day - https://bit.ly/2SbrRhe. Any of the Wednesday, Thursday, or Friday meetings would work.

Also, https://layer5.io/community#meet

Oh I see. So, Wednesday November 4th is ok for me (the Friday one overlaps with other job meeting)

The issue had been split into 14 milestones, please comment on which one would you like to accomplish so that we may assign you the one.

@kushthedude I want to start with /userpreference in the meantime I get familiarized more with the product.

Great !

@kushthedude I want to start with the E2E test for /userpreference also. Could you assign to me that one?

Great progress on this, @ramrodo. Are you still good with this single, epic issue or will the addition of smaller, child issues help?

Great progress on this, @ramrodo. Are you still good with this single, epic issue or will the addition of smaller, child issues help?

I think we can split and detail the results and performance tests in order to cover all the cases. The others don't seem so complicated.

@kushthedude could you assign to me e2e tests /settings, please? I want to start working on that.

I'll be creating small issues addressing each path of this umbrella issue.
Please assign the issue yourself you're going to work on.

I'll be creating small issues addressing each path of this umbrella issue.
Please assign the issue yourself you're going to work on.

@sudo-NithishKarthik fyi

@leecalcote @sudo-NithishKarthik I've started to read up on cypress, I'll try to write a test soon.

That's awesome @warunicorn19  🎉
Actually, there's going to be some major architectural changes in Meshery UI and it would make more sense for us to delay the process of writing tests for sometime so that we don't find ourselves repeating the work.

@sudo-NithishKarthik alrighty😃, just letting you know that whenever we do write tests, Im interested in doing so.😄

That being said, nothing's stopping you from exploring cypress, we still are going to cypress for E2E and integration testing, so, being competent in that would be really helpful.

@sayantan1413 , @warunicorn19
This blog might be helpful i believe.
Also, can one of you guys make an effort to reference this blog in our meshery-ui contribution docs ?

@sudo-NithishKarthik sure, I'll make it a part of the suggested reading, yes?

@sudo-NithishKarthik sure, I'll make it a part of the suggested reading, yes?

Sounds good

This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go.


Missing html tags

In your examples <head> tag is missing. You should put <style> there.
You also need to close using the </body> the body

I followed the convention of the examples available on d3js.org, as you can see here: http://bl.ocks.org/mbostock/4062006#index.html

Didn't know that... Thanks for the clarification!


Revert "Force discarding mode in with_fanout without rewindowing."

Reverts apache/beam#23828
Reason: caused a memory increase for one of internal customers. Reverting while the investigation is happening.

R: @robertwb @kerrydc


branch-2.0 fix some bugs about delete sign (#25712)

Proposed changes
Issue Number: close #xxx
cherry-pick #25712
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.25 seconds
stream load tsv:          557 seconds loaded<PHONE_NUMBER>9 Bytes, about 128 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size:<PHONE_NUMBER>8 Bytes


bugfix/gp_matern52_cov-translation-fails

Description
This is in reference to stan-dev/stan#2739 that's failing on stan-dev/stan.
I'm getting some compilation error that throws because I've used a function name as a variable name.
Expected Output
stan-dev/stan passes all tests.
Current Version:
v2.19.0

@drezap, can you add more detail about what this bug is? I'm looking at the PR and there isn't information about the bug here. It looks like there's some description in the Stan repo, but it's not specific enough for me to understand what's going on.
Is there a test case that fails before the change is applied?


docker install impossible to sign-up

I've installed the stable release of convos with docker. (version 6.34)
Container is starting fine without any issues.
When I go to http://ip:port I see the convos page with the Signup page
After entering email adress & password I receive following error:
Failed fetching operationId "registerUser": ReferenceError: body is not defined
Tried different browser (edge, firefox) / Also rebuilt the container but still the same issue

No reverse proxy. I launched following docker and tried to access it directly with http://localhost:3133
https://imgur.com/1oNMeLO
docker run -d --name=convos
-p 3133:3000
-v /mypath/convos:/data
--restart always
convos/convos:stable

You can follow the progress at https://github.com/convos-chat/convos/actions/runs/1355095629

Finally 6.36 is available. (Had some issues while trying to speed up the docker build)


add test for default constructor

#31 was a regression that went undetected because we where missing this test, see also #32.
this test will prevent the problem from coming up again.

i locally tested that i indeed do get failures if i recreate the state of v1.1.0 .

Just wondering: Is there a special reason that in some php-http packages phpspec is used while others have tests based on PHPUnit?

hm. true, we started with phpspec. i guess familiarity with tools of people that wrote tests? would make sense to be consistent. but the rest of the tests in here are phpunit as well, so we should still merge this.

@xabbuh The reason is that most of the integration tests are ported from ivory http adapter, while new tests withing php http are written in phpspec. Although, writting integration tests using SpecBDD would be quite a huge contradiction. So the thumb rule is that unit tests are written using specs, integration tests are written using phpunit.

I guess this can be merged.


[WIP] [tests] Increasing test coverage

GCI task: https://codein.withgoogle.com/dashboard/task-instances/5562866431164416/

@nemesisdesign I know did it becuase I was getting this and I didnt know how to handle this (now I know because @atb00ker showed how to handle it

)

@OltarzewskiK you can do so by doing git rebase origin master, I suggest you to learn more about git when you finish your current task, we have added a videocourse in our tasks

@nemesisdesign Unfortunately git rebase origin master didn't work in my case I had to do other stuff too


Modern Challenges: unwanted bracket renders at end of async test messages

As first raised by @r1chard5mith in #16312, any async test in the modern challenges (React, Redux, React-Redux) has an unwanted closing bracket that renders as text at the end of the test case message:

@BerkeleyTrue this seems to be new since we changed the async test syntax. Any idea what's going on here?
@r1chard5mith did you ever have any luck figuring this out?

@ninadingole nice job! I hate regexp, so I commend you for taking this on 😄


docs: update link to ps1 file

Update link from silent-debloat-softwares.ps1 to Use-DebloatSoftware.ps1, reading the script this file looks the right one now.

This commit was turned to the develop branch, thanks for the contribution.


Use with different models?

Thanks for this plugin — I implemented it and it's working very smoothly! However, in my experiments so far, the quality of the results it returns is hit or miss (it labels a lot of things "Curtain", for example). Would it be possible / easy to experiment with other models besides MLKit? Or to let the consumer specify their own model?

HI @stevengoldberg  Are you able to compile it in iOS?

@stevengoldberg I was just asking is it working fine or not, I'm still getting errors which I mentioned in issue #2 and also I'm working on simulators,
Is it working for simulator?

Yes, you are right I modified becouse  Vision Camera not fully Supporting Orientation https://github.com/mrousavy/react-native-vision-camera/issues/1891. When supports all I will update that.

Update — I discovered that the issue I was encountering only happened with some camera formats. On those, the labeler produced garbage output; almost always "Curtain, Pattern, Textile," regardless of the input. With other formats, it produced more reasonable output.
However, once I passed pixelFormat="rbg" to the Camera component, both formats started producing the same results (it was "yuv" before).
So that seems to solve my immediate problem. It would still be neat to try dropping in different ML models, however!


Upping jtwig-core version

Coverage increased (+19.9%) to 97.826% when pulling d3d7d3d6ddf747dd12bd3b2e90cdcdbdf8aa4341 on lyncodev:master into 86cfabb839b87a9bf380be066f64f341ace3ba67 on jtwig:master.


tag typo

What's wrong with the existing documentation
The tag "Medium" for the level of issue is misspelt as "Midium".
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[x] I want to work on this issue

I can fix this issue.

What's wrong with the existing documentation
The tag "Medium" for the level of issue is misspelt as "Midium".
Add ScreenShots

Record

[x]  I agree to follow this project's Code of Conduct
[x]  I'm a GSSOC'24 contributor
[x]  I want to work on this issue

Oops, It's my mistake you can't change it. I will do it. thank you


Next

:tada: This PR is included in version 1.0.0-rc.3 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0-rc.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


JavaScript Console Errors on Non-Customizer Pages Throughout Kanboard

This issue appears to occur since the customizer.js file gets loaded throughout the site when you're using Customizer and should show up in the Chrome DevTools Console:

The fix I've been applying on my end after each update to Customizer has been to wrap the following lines in customizer.js:
https://github.com/creecros/Customizer/blob/master/Assets/js/customizer.js#L84-L164
With an if statement:
if (document.getElementById('loginpanel_color'))
{
        // Existing lines 84 - 164 should be in here now
}

Those lines cause the issue on the non-Customizer pages throughout Kanboard since they end up running no matter what, versus the other code in customizer.js being triggered on events/functions. Since those elements for the Customizer config don't exist in the other parts of Kanboard, they result in the errors being triggered since the elements don't exist so the if statement works around that by first checking for the existence of the loginpanel_color element and if it doesn't exist then everything in that if statement won't get run unnecessarily.

You want to take care of it and make a PR, or you want me to do it?

Put together a quick PR for you.


Docs: SSR Page

Draft proposal: SSR Page
Provided some contextual information surrounding Client-side rendering, and server side rendering, sought to bring the two together.

Sorry for not delivering on this, there are a lot of high prio things going on right now. I'll have some more time after I release Vike's MVP.
Closing in the meantime.

Hey Rom, no worries my friend, Im likewise trapped with working on XElement docs atm, however a promise made is a promise kept, and once I finish, if you dont mind I will be coming back to here and helping in anyway I can.
If there is anything else you want of me in the mean time, do let me know 👊

👌 I will


Add skip option for errorLogger

It would be really helpful to be able to conditionally skip logging in the errorLogger just like in the default logger, e.g. in unit tests.
For now I'm doing the hacky level: process.env.NODE_ENV === 'test' ? 'silly' : 'error'.

I don't really want to enable per-error skipping of error logging, which is what a skip option would do. I think that error logging should be all or nothing (because errors are that important).
It sounds like your use case (unit tests) is also an all-or-nothing scenario. Is there any reason not to just add an if statement around your setup of the error logger? I'm thinking the following is easy/comprehensive enough that it doesn't need to be handled in-module:
if (process.env.NODE_ENV !== 'test') {
  app.use(expressWinston.errorLogger({
    // ... other options here
  }))
}

Let me know if there's something I'm missing about this.

Yeap you're totally right, this is mostly a code style thing. Just thought since skip is available in logger it would produce cleaner/more consistent code, for example:
const requestLogger = expressWinston.logger({
  ...
  skip: () => process.env.NODE_ENV === 'test'
});

const errorLogger = expressWinston.errorLogger({
  ...
  skip: () => process.env.NODE_ENV === 'test'
});

app.use(logger.requestLogger);
app.use('/', routes);
app.use(logger.errorLogger);

instead of wrapping everything (or half) in if statements.
Anyway just food thought, nothing too major. Thanks for taking the time to respond! :)

Yeah, your example is definitely cleaner. I'll admit that! Thanks for the feedback.

I too was looking for a way to skip certain errors.
I'm using custom validation errors.  This has resulted in much cleaner code for us, but I don't want these custom errors logged in the same way as exceptions.
My use case was adapted from these articles:

https://gist.github.com/slavafomin/b164e3e710a6fc9352c934b9073e7216
http://gunargessner.com/subclassing-exception/

This is my current errorLogger config
expressWinston.errorLogger({
    transports: [
      new winston.transports.Console({
        colorize: true,
        level: 'error',
        handleExceptions: true,
        humanReadableUnhandledException: true,
      }),
      new winston.transports.DailyRotateFile({
        filename: `${logDirExceptions}/log`,
        datePattern: 'yyyy-MM-dd_error.',
        prepend: true,
        level: 'error',
        handleExceptions: true,
        humanReadableUnhandledException: true,
      }),
    ],
  })

Is there any way to have control of which exceptions are logged?

Disregard previous post.
I see the skip functionality will soon be added in this pull request
https://github.com/bithavoc/express-winston/pull/147
Great news!


Make weights and keepdims arguments in Variable.mean keyword-only

Following the policy
Introduced in #7670
axis is left because it's common to give the corresponding argument in numpy.mean as positional.

Jenkins, test this please


Enhancement: Add Token user

In order to sign tokens we need a special user that has permissions to just create tokens and nothing else.

[ ] Change spring-accounts-context.xml to add new user type, following AdminSchema as the example
[ ] Create resources/content/schema/token/token-auth.json.  Only "token" : "cr" should be supported (and probably "schema" : "r")
[ ] Create SampleDataStartupV2 to add token account with uuid = "token".  Use https://github.com/rancherio/cattle/blob/09e6bc5b7891cb43fee913c2e57213194c143b41/code/implementation/sample-setup/src/main/java/io/cattle/platform/sample/data/SampleDataStartupV2.java as example
[ ] Add 'token' to https://github.com/rancherio/cattle/blob/fdc113f5affc4dca223bebf95474f62ada45bc8e/tests/integration/cattletest/core/common_fixtures.py#L72
[ ] Create token_client() following example https://github.com/rancherio/cattle/blob/fdc113f5affc4dca223bebf95474f62ada45bc8e/tests/integration/cattletest/core/common_fixtures.py#L96
[ ] Add tests to ensure token user is only allowed access to token example: https://github.com/rancherio/cattle/blob/fdc113f5affc4dca223bebf95474f62ada45bc8e/tests/integration/cattletest/core/common_fixtures.py#L96  Also ensure that the only types in the schema is token.

This is a sub task of https://github.com/rancherio/cattle/issues/62

Closed in favor of rancher/rancher#3828


Add a default limit of deferred FATE transactions

This commit adds support for limiting the number of FATE transactions that can be deferred at the same time. If the number reaches the maximum then the overflow flag is set and the deferred map will be cleared so that the next run by FATE through the transactions will run all of the outstanding operations and not defer. New transactions won't be added to the deferred map until the executor runs through the transaction list and clears the flag.
This condition should not occur frequently but if it does it will tell FATE to try and catch up and work off the backlog of deferred transactions.
The default limit was set at 100k but this could be changed. For testing, I added two tests. One test is for the store itself and just verifies at the store level the map is cleared and flags are set properly when they should be. I only tested the Accumulo store as it's all common code so the ZK store would be the same. I also added a test to FateIT (which will run for both ZK and Accumulo) to verify that things work. The test works by setting a low deferred maximum and then submitting deferred transactions up to that limit. The test verifies the map is not cleared and overflow flag not set, then submits some more delayed transactions to trigger the overflow and verifies the map is cleared and flag is set. After that it verifies everything processes and executes. The test would timeout if the overflow did not work as when the fate executor ran the transactions it would find 30 second delays. It also would timeout because the test waits and verifies that the overflow flag status is correct and the map size is correct.

Noticed #4181 while reviewing this PR, but its not related to this PR.


Anonymous embedded structs aren't supported

It seems when using anonymous embedded structs, field values are not transmitted. For example, given the following types:
type B struct {
    I int
}

type A struct {
    B
    J int
}

If A is sent on a channel, values for the anonymously embedded B struct are not sent.

Is this still an issue? I went to add a unit test to track this down and it appears to work.
https://github.com/Shelnutt2/libchan/commit/6a229ba8bb3b444d4e6b7c28b5c95958dbd645b1

I do expect this to work as well with the latest encoding change. I would try to make this test work with the spdy package since that will hit the encoder. The in mem should not be a problem since it is only passing along a reference.


Keep playlist / song when i change settings

When i change my settings, player reset current playing song.
I'll be cool if current song whould be keeping 😊
PS: thx for your work. Just a awesome idea 👍 ! I'll make PR soon for features and bugs fixed !

Thanks for the report. What browser and OS are you experiencing this in? I was unable to reproduce in Safari and Chrome on macOS.

It's a know bug when you change Bitrate (Changing the bitrate will cause the page to reload.)
Keep sound in localstorage or somethink like this will be cool :)

Yeah, changing the bitrate currently triggers a full reload because the bitrate setting is only writable when calling MusicKit.configure.

I will look at saving current playlist + song in localstorage.

It was my first idea 👍

@zachomedia FWIW documentation is lacking for bitrate. You can set the bitrate without reloading, but it will not take effect until the next track is started.
MusicKit.getInstance().bitrate = MusicKit.PlaybackBitrate.HIGH

Thanks @jaehess. I'll update it then to change that value.
Just note, the docs do say that's a readonly value (https://developer.apple.com/documentation/musickitjs/musickit/musickitinstance/2992702-bitrate).


Online position not synchronised

Since authentication was refactored,the synchronisation of login to position has no longer been working correctly

Fixed in https://github.com/vatger/atciss/commit/fd3c7e8674f06bf4c687de3511c9451b969b9232


Player wrapper escape

027f67c39b
Players escape wrapper on disconnect / reconnect, player has to be kicked to fix (twice, if they logged back in before you could kick there phantom)
does not seem to effect players logging out and back in properly .

61a1f6f
appears fixed, no longer able to recreate

Managed to recreate, now occurs on player lag-out, or hard disconnect (pulling LAN cable form PC, or other network link, ending starbound process forcefully) this would be something i consider to be a security hole as it allows a player to bypass such things as planet protections.


Should parser response data be of type QueryDict or dict?

Maybe this is related to the structure of DRF, but I still wanted to write it here.
I am sending data like this;
post_data={
"detail":"Address detail",
"address.address":"Street 10",
"address.lat":"10",
"address.lng":"10"
}

Here is the desired result:
{
  "detail":"Address detail",
  "address":{
    "address":"Street 10",
    "lat":"10",
    "lng":10"
    }
  }

serializers.py
class ContentAddressSerializer(serializers.ModelSerializer):
    class Meta:
        model = ContentAddressModel
        fields = ['address', 'lat', 'lng']

class ContentSerializer(serializers.ModelSerializer):
    address = ContentAddressSerializer(required=False, allow_null=True)

    class Meta:
        model = ContentModel
        fields = [ 'id', 'detail', 'address' ]

    def to_internal_value(self, data):
        #print("+" * 100, data)
        d = super().to_internal_value(data)
        #print("+" * 100, d) {"detail":"Address detail"} # no address!!

        return d

But, in the to_inernal_vale() method of ContentSerializer, it comes out as follows;
{"detail":"Address detail"} # no address!!
The data from your parser is as follows;
<QueryDict: {'detail': ['Address detail'], 'address': [{"address":"Street 10", "lat":"10","lng":10"}]}
As seen QueryDict comes. As I said, maybe it is related to the structure of DRF.
It works fully when I extend your parse() method and make the following change;
class NesteMultipartParser(DrfNestedParser):
    def parse(self, stream, media_type=None, parser_context=None):
        data = super().parse(stream, media_type, parser_context)
        dict_data = data.dict() #!!!!HERE!!!
        return dict_data

here i changed the return value to dict

it is better to use jango's querydict,however drf works very well with a normal dict,i will add a querydict option for convert output of parser to querydict or not

# settings.py
DRF_NESTED_MULTIPART_PARSER = {
    ...
    "querydict":True
}

by default output is convertedto querydict , you can disable it ( querydict: False)

v1.4.1


Missing plus button for dc content link

I went through the process of trying to include the option to add links to content items in my editor. The docs say to just add a contentTypes property which is an array of the content types. It says an icon should show up by default, but I don't see any icon or ability to add content items in my editor.

As you can see, all of the icons are visible except one for dc-content-link.
Is this a bug? If not, can the docs be updated to describe the process of getting this working?
"properties":{
"textBox":{
"type": "array",
"ui:extension":{
"url":"https://amplience.github.io/dc-extension-rich-text/index.html",
"params": {
"language": "json"
},
"tools": {
"whitelist": ["undo", "redo", "strong", "em", "code", "link", "lift", "bullet_list", "ordered_list", "image", "blockquote", "heading", "paragraph", "code_block", "horizontal_rule", "clear_formatting", "dc-image-link", "dc-content-link"],
"dc-content-link": {
"contentTypes": ["https://demo.com/content/type/text-banner"]
}
}
}
}
},

Hi @lukeharrisontravis
tools object should be inside params block.


Added Live Keylogger

ref: #492
see todo in FrmKeylogger.cs for possible improvement in keylogger

This is practically done for the implementation of the live logger.  @MaxXor, what are your thoughts on moving the html format to a text parsing based system?  Is that something you would want in the future?

Thanks, but I'll add this after release of v<IP_ADDRESS>. :) It's time to fix some bugs. As of now I think the HTML logs are fine, I don't plan moving to another format soon.

Sounds good.  I'll do some cleaning up with the keylogger logic and retrieving the logs.  The HTML formatted logs are quite hefty in size (nearly double the size of what they could be with an improved system), however migrating to a newer parsed based system might not be viable considering previous logs would have to be accounted for to be formatted properly on the server-side.
I'll close this branch/pr for now and reopen it when the time is right.


FIX: Follow the changes of PyVista 0.31.2

This PR fixes the error:
RuntimeError: Render window interactor must be initialized before processing events.

reported in https://github.com/mne-tools/mne-python/pull/9468#issuecomment-865685608

The pip-pre jobs seem to be stuck during dependency resolution.

They both give up after downloading python-dateutil

how does this compare to CI status in main branch?

The same happens on main indeed.

What do we do about pip pre tests?


Add new option

Add the option -a, --ssh-arguments to directly pass arguments to the ssh command.
I personally use this option mostly for port forwarding or configuring a ssh proxy socks.

Hey, thanks a lot for contributing!
Not sure if it works with multiple arguments, did you tried?

Nice catch. Indeed, it was not working. Now it should. I have tried with multiple arguments

It will not work if you have something like -a"--something 'a b c'". Use a library like shlex (it's archived but works well).

Ok I will give it a look and do this properly.

The last commit is now using shlex.  The arguments are properly sent to ssh:

Fantastic ! Thanks ❤


Add support for a re-entrant lock that spin waits keeping other tasks running.

One missing feature in task manager is the ability to handle reentrant locking within a task. For example, that means suppose we have a lock on I2C for example, that we lock in method A, and then method A then callls method B, which again locks I2C, which should succeed as it's locked by the same running task. However, a lock from any other task would have to spin wait by calling back into the task manager yield function.
This requires the currently running task to be exposed on the task manager object.

Will be in the next release due shortly

Needs more thought before putting it into the code base for the sake of compatibility.

Internally questioning if this is the right approach, certainly cannot be done as currently implemented.

We've got this now, allowing task wide locks is working, and we've added an asynchronous mode too, so if the locks are in an observer -> observable pattern it can still work by making one side async.

This is now in extended testing, releasing soon


MGMT-18219: Update go version to 1.22

/cc @eranco74 @tsorya

/retest

Please also make sure you run make bundle and commit the changes if there's anything other than the timestamp.

/approve
/lgtm

/hold

This was my concern :worried:
Pulling image brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.22 ...
Trying to pull brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.22...
Warning: Pull failed, retrying in 5s ...
Trying to pull brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.22...
Warning: Pull failed, retrying in 5s ...
Trying to pull brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.22...
Warning: Pull failed, retrying in 5s ...

/retest

/retest

/unhold

/lgtm

/retest

/unhold


ci: fix deployments

Issues
Fixes #
Reviewer Suggestions
Where should the reviewer start?
Additional Comments
Anything else?

:tada: This issue has been resolved in version 1.2.37 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


pl.show() still not working (?) in interactive mode

I am using the latest code from main. If I run this code as a script, the plot is shown. If I set a breakpoint (I am using PyCharm) in the line with pl.render_points()..., and then run that line in the Python interactive console, then no plot is shown and I need to call plt.show() explicitly. I think the bug was once fixed, maybe it slipped in again.
from spatialdata import SpatialData
from spatialdata.models import PointsModel, ShapesModel
from shapely import polygons, linearrings
from geopandas import GeoDataFrame
import pandas as pd
import geopandas as gpd
import numpy as np

def _make_points():
    """Helper function to make a Points element."""
    coordinates = np.array([[10, 10], [20, 20], [20, 30]], dtype=float)
    return PointsModel.parse(
        coordinates, annotation=pd.DataFrame({"genes": np.repeat("a", len(coordinates))}), feature_key="genes"
    )

def _make_squares() -> polygons:
    centroid_coordinates = np.array([[10, 10], [10, 80], [80, 20], [70, 60]])
    half_width = 6
    linear_rings = []
    for centroid in centroid_coordinates:
        min_coords = centroid - half_width
        max_coords = centroid + half_width

        linear_rings.append(
            linearrings(
                [
                    [min_coords[0], min_coords[1]],
                    [min_coords[0], max_coords[1]],
                    [max_coords[0], max_coords[1]],
                    [max_coords[0], min_coords[1]],
                ]
            )
        )
    s = polygons(linear_rings)
    polygon_series = gpd.GeoSeries(s)
    cell_polygon_table = gpd.GeoDataFrame(geometry=polygon_series)
    sd_polygons = ShapesModel.parse(cell_polygon_table)
    return sd_polygons

def _make_circles() -> GeoDataFrame:
    centroid_coordinates = np.array([[10, 10], [10, 80], [80, 20], [70, 60]])
    radius = 10
    circles = ShapesModel.parse(centroid_coordinates, geometry=0, radius=radius)
    return circles

points = _make_points()
squares = _make_squares()
circles = _make_circles()
import spatialdata_plot
sdata = SpatialData(points={'p': points}, shapes={'s': squares, 'c': circles})
sdata.pl.render_points().pl.render_shapes().pl.show()
# import matplotlib.pyplot as plt
# plt.show()

It seems like the bug resurfaced. By running the code of this comment here (please delete the Interactive() calls) https://github.com/scverse/napari-spatialdata/pull/175#issuecomment-1793767601, in a Python console, the plots are shown only if plt.show() is called explicitly.

It seems like that the check:
# Manually show plot if we're not in interactive mode
# https://stackoverflow.com/a/64523765
if not hasattr(sys, "ps1"):
    plt.show()

doesn't cover the case in which we are in Python console.
II think that the solution proposed in https://github.com/scverse/spatialdata-plot/issues/71, would solve both bugs: I suggest to add a parameter show: bool = None. If ax is not None, show is set to False, otherwise it is set to True.
Then I would replace the line if not hasattr(sys, "ps1"): with if show:.
I think this should fix the issue.

You could also look into plt.ion()/plt.ioff().
If interactive mode is activated, figures will be shown and redrawn automatically on each update. In jupyter notebooks, this is active by default.
I lean towards reducing the number of options like show =False and instead educate the users about such matplotlib options in the tutorials.


Add compatability with VE Outposts

Currently, the Outposts are unable to send deliveries to the moons/space station

This is not going to happen to the main RimNauts mod, but rather in expansions


Qbittorrent 4 5 0 update

qBittorrent update to version 4.5.0
For 64-bit version only, last 32-bit qBittorrent version will remain 4.4.5
Description
I made necessary changes to files:
automatic/qbittorrent/qbittorrent.nuspec
automatic/qbittorrent/tools/VERIFICATION.txt
automatic/qbittorrent/tools/chocolateyinstall.ps1
Motivation and Context
choco will update to 4.5.0 on 64-bit systems
How Has this Been Tested?
powershell
Screenshot (if appropriate, usually isn't needed):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[x] My change requires a change to documentation (this usually means the notes in the description of a package).
[x] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[x] I have updated the package description and it is less than 4000 characters.
[x] All files are up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

@pauby please review here :-)

@pauby please review here :-)

Please don't reference other people for a review. Reviews happen when people have time to do so, not when being referenced by other people.

@AdmiringWorm I totally understand why I should not reference people to review. This time I made an exception merely because @pauby was reviewing the PR #2070 and then just when he was about to approve the merge, he noticed that I had not created a branch, so he asked for a new PR from a branch. I did another PR, closed the old one and that's the only reason why I referenced him - because he was doing the previous PR, which he almost merged too.
I meant no disrespect or to hurry anyone or to make it stressful. And I will not repeat this even if anything similar hapens.
Thank you for your patience with me.

@gobalius Can you leave a comment on issue #2073?
This way we can assign the issue to you (so we know who is working on it and to prevent it from being closed).

:white_check_mark: Package verification completed without issues. PR is now pending human review

:white_check_mark: Package verification completed without issues. PR is now pending human review


[CT-1218] [Bug] The query-comment statement not included in incremental Merge query

Is this a new bug in dbt-snowflake?

[X] I believe this is a new bug in dbt-snowflake
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
When reviewing the query text in snowflake for incremental model executions the query-comment is not present in the MERGE command but it is present in the CREATE temp table command.
Expected Behavior
I would expect all queries executed by dbt to include the defined query-comment
Steps To Reproduce

dbt-snowflake version 1.1
define a query-comment in the dbt-project.yml
create an incremental model
run the incremental model first to build the table and a second time to invoke a merge action.
review dbt logs or snowflake query logs

Relevant log output
No response
Environment
- OS:macOS 11.6.6
- Python: 3.8.6
- dbt-core: 1.1.0
- dbt-snowflake: 1.1.0

Additional Context
No response

Hey @pempey - I believe this was fixed (https://github.com/dbt-labs/dbt-snowflake/pull/153)!
That fix was included in v1.2 — could you try upgrading, and see whether you see the query comment show up on the merge statement as well?

@jtcohen6 I can confirm that upgrading to v1.2. solved the issue.  Not sure why I did not see the other issues but thank you for helping me resolve this.


Warn if vendor exists before dep init nukes it?

I understand why dep manages the vendor directory, and for ensure, etc, it makes sense that it does whatever it needs to do with it. However for a new user, having dep init potentially delete unsaved changes is a poor first impression. People may be trying it out just to see what it does, and their first tentative command for a tool shouldn't perform a destructive op without warning.
I'd like to see dep init detect if vendor exists, and either prompt the user to continue. Or if we don't like prompts, at least backup the original vendor and inform the user.

I think backing up an existing vendor dir is an easy win with very little downside. So:

If vendor already exists and is non-empty, then move it to vendor-$TIMESTAMP
If, by crazy chance, that dir exists, consider it a hard failure and abort
Otherwise, inform the user of the renamed dir regardless of whether -v was specified. This message is crucial, and should be one of if not the last message that dep init outputs.


[cinder-csi-plugin] Add http endpoint of CSI container

What this PR does / why we need it:
Add http endpoint of CSI container , it will be used for metris later
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

# kubectl get pods  -n kube-system -o wide
NAME                            READY   STATUS    RESTARTS   AGE   IP           NODE        NOMINATED NODE   READINESS GATES
csi-cinder-controllerplugin-0   6/6     Running   0          6s    <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>
csi-cinder-nodeplugin-2j5gg     3/3     Running   0          6s    <IP_ADDRESS>    <IP_ADDRESS>   <none>           <none>
kube-dns-58fd9b49f7-ffn4b       3/3     Running   0          59s   <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>
root@jjtest1:~/go/src/github.com/cloud-provider-openstack/manifests# kubectl run -i --tty curl1 --image=curlimages/curl --restart=Never
 -- sh
If you don't see a command prompt, try pressing enter.
/ $ curl <IP_ADDRESS>:8080/metrics
# HELP process_start_time_seconds [ALPHA] Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.6124993369e+09

the result looks like this

/retest

/retest

/retest

/retest

@lingxiankong @ramineni can you help review this ?
openlab/cloud-provider-openstack-acceptance-test-csi-cinder is not run any more  so no impact

@jichenjc Do you have a rough idea of what kind of metrics are going to be supported? To me, the idea here seems should be included in a sidecar.

not sure worthy a side car . usually side car used for service mesh or init? we are only providing metrics such as how many calls performed against openstack .. just like OCCM https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/metrics.md

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

@lingxiankong thanks for update the test, seems all test passed now.., can you help review again?

/lgtm
I'm not 100% sure if we should follow this way, @ramineni please take a look.

@ramineni please let me know your comments on this , thanks

@jichenjc sorry for the delay. Ill review it on priority this week. Thanks.

@ramineni  Please help to review this at your conveneince (so I can add follow up PR) :)  thanks a lot for your help

not sure worthy a side car . usually side car used for service mesh or init? we are only providing metrics such as how many calls performed against openstack .. just like OCCM https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/metrics.md

sorry my bad, clicked wrong button

/test cloud-provider-openstack-multinode-csi-migration-test

/retest

/retest

/retest

/test cloud-provider-openstack-e2e-test-csi-cinder

/test cloud-provider-openstack-e2e-test-csi-cinder

@jichenjc Thanks for the PR. Some comments inline.
If its not much code, could you add the code retrieving the metrics in same PR. That way release notes can be added and we can track what all changes went into this feature at one place. As github doesnt have dependency tracking, it would be difficult to track full changes of feature later if anyone wants to check.
Please include detailed documentation and how to retrieve metrics, it would be helpful. (Im ok with different PR for this)

@jichenjc Thanks for the PR. Some comments inline.
If its not much code, could you add the code retrieving the metrics in same PR. That way release notes can be added and we can track what all changes went into this feature at one place. As github doesnt have dependency tracking, it would be difficult to track full changes of feature later if anyone wants to check.
Please include detailed documentation and how to retrieve metrics, it would be helpful. (Im ok with different PR for this)

ok, thanks for the comments, will update later on

/test cloud-provider-openstack-e2e-test-csi-cinder

looks like we have
# HELP cinder_csi_openstack_api_request_duration_seconds Latency of an OpenStack API call
# TYPE cinder_csi_openstack_api_request_duration_seconds histogram
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.005"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.01"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.025"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.05"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.1"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.25"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.5"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="1"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="2.5"} 2
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="5"} 2
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="10"} 2
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="+Inf"} 2
cinder_csi_openstack_api_request_duration_seconds_sum{request="volume_list"} 1.955777479
cinder_csi_openstack_api_request_duration_seconds_count{request="volume_list"} 2
# HELP cinder_csi_openstack_api_requests_total Total number of OpenStack API calls
# TYPE cinder_csi_openstack_api_requests_total counter
cinder_csi_openstack_api_requests_total{request="volume_list"} 2

create a PV makes it
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="0.005"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="0.01"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="0.025"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="0.05"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="0.1"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="0.25"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="0.5"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="1"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="2.5"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="5"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="10"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_create",le="+Inf"} 1
cinder_csi_openstack_api_request_duration_seconds_sum{request="volume_create"} 0.2780239
cinder_csi_openstack_api_request_duration_seconds_count{request="volume_create"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="0.005"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="0.01"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="0.025"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="0.05"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="0.1"} 3
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="0.25"} 7
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="0.5"} 8
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="1"} 8
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="2.5"} 8
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="5"} 8
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="10"} 8
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_get",le="+Inf"} 8
cinder_csi_openstack_api_request_duration_seconds_sum{request="volume_get"} 1.1464854389999999
cinder_csi_openstack_api_request_duration_seconds_count{request="volume_get"} 8
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.005"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.01"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.025"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.05"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.1"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.25"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="0.5"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="1"} 4
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="2.5"} 6
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="5"} 6
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="10"} 6
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volume_list",le="+Inf"} 6
cinder_csi_openstack_api_request_duration_seconds_sum{request="volume_list"} 5.043539682
cinder_csi_openstack_api_request_duration_seconds_count{request="volume_list"} 6
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="0.005"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="0.01"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="0.025"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="0.05"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="0.1"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="0.25"} 0
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="0.5"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="1"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="2.5"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="5"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="10"} 1
cinder_csi_openstack_api_request_duration_seconds_bucket{request="volumeattachment_create",le="+Inf"} 1
cinder_csi_openstack_api_request_duration_seconds_sum{request="volumeattachment_create"} 0.425105702
cinder_csi_openstack_api_request_duration_seconds_count{request="volumeattachment_create"} 1
# HELP cinder_csi_openstack_api_requests_total Total number of OpenStack API calls
# TYPE cinder_csi_openstack_api_requests_total counter
cinder_csi_openstack_api_requests_total{request="volume_create"} 1
cinder_csi_openstack_api_requests_total{request="volume_get"} 8
cinder_csi_openstack_api_requests_total{request="volume_list"} 6
cinder_csi_openstack_api_requests_total{request="volumeattachment_create"} 1

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/test cloud-provider-openstack-acceptance-test-csi-manila

/test cloud-provider-openstack-acceptance-test-csi-manila

/close
please feel free to reopen , if you would like to work on it in future

@ramineni @jichenjc @chrigl it looks like discussion around cinder csi metrics started in year 2020. However, one reason why we do not have metrics yet is comment https://github.com/kubernetes/cloud-provider-openstack/issues/1392#issuecomment-800858903 it is pretty difficult to implement. As I see it: we have already multiple components (occm+cinder-csi), why we should have common endpoint to retrieve metrics from all components? Why we cannot have own metrics endpoints for csi and occm?
So I am kind of asking: could we just use different way to provide metrics? Now we do not have anything.

https://github.com/kubernetes/cloud-provider-openstack/commit/dd83566951efa9e892d60e697b49f6f04a1bdfab
few things that we should think of:

it does not have any authentication, how easy it is use similar authentication method than occm has?
should cinder-csi component fetch other csi sidecar metrics internally and provide them?


Add case conversion to ImplicitDefaultLocale

Fix #2515

The execution of ./gradlew build results in an updated doc.
https://github.com/arturbosch/detekt/blob/master/docs/pages/documentation/potential-bugs.md

The doc should be updated now.

Yep 👍
That looks good. The test case description could be updated to be compliant with other test descriptions.


selinuxenabled not defined

Hi,
Looks like selinuxenabled is not defined:
https://github.com/aws-samples/amazon-eks-custom-amis/blob/main/files/functions.sh#L150

@yongzhang - thanks for filing an issue. Can you provide the operating system and version you are hitting this issue with?

@yongzhang - thanks for filing an issue. Can you provide the operating system and version you are hitting this issue with?

I'm using ubuntu18.04, I think the function func selinuxenabled() should be added somewhere.

@yongzhang I believe the issue happens because SELinux is not installed on Ubuntu as Ubuntu uses AppArmor. This command failing shouldn't stop the build. In fact, that command failing triggers the proper behavior which prevents enabling SELinux in Docker.


Issue Report: Bug in Obsidian Immersive Translate Plugin

Dear Plugin Developer,
I would like to begin by extending my heartfelt gratitude for your exceptional plugin. It has been an invaluable asset to my academic pursuits, and I truly appreciate the dedication and effort you've put into it.

Issue 1: Inability to Disable or Hide the Floating Ball
I've encountered a challenge where I am unable to disable or hide the floating ball feature of the plugin. As shown in the screenshot below, this issue persists despite my attempts to adjust the settings.

Issue 2: Customization of Shortcut Keys
Another obstacle I'm facing is the inability to customize the shortcut keys within the Immersive Translate plugin for Obsidian. The default browser consistently opens, which interferes with any attempts to modify or adjust settings within the plugin. The screenshot below illustrates this issue.

I am hopeful that these issues can be addressed in a future update. Your continued support and improvements to the plugin are greatly appreciated by the user community.
Thank you once again for your outstanding work.
Warm regards,
Zhentong Ye
<EMAIL_ADDRESS>

hi @1235357
感谢反馈 🙏 当前翻译插件直接引入使用的 immersivetranslate.com 的 js-sdk。
针对Customization of Shortcut Keys 的问题，js-sdk 里是跳转到其官方页面，引导用户使用浏览器插件版本的（浏览器插件版本支持设置自定义快捷键），这里我看看有没有办法实现拦截，将一些设置通过 obsidian 插件设置页面 进行设置。
针对 Inability to Disable or Hide the Floating Ball 的问题，我看当前版本的 js-sdk 里，点击上述按钮的时候，相关的元素上并没有 onUpdateFloatBallEnable 方法，导致 js 报错，这里我进一步定位看看。目前情况下（在 obsidian 内使用本插件），暂时不支持保留翻译功能的同时隐藏悬浮球。（有改进方案，待我进一步确认）


Handling of NaNs and differences between SSE and NEON

Looking at https://github.com/nemequ/simde/blob/master/simde/x86/sse.h#L2203 it looks like minps on x86 is directly mapped to vminq_f32 on arm. However these two instructions have different behavior.
minps(NaN, 0.0) = 0.0
vmin(NaN, 0.0) = default NaN

Is this considered a bug? What are the expectations for such cases?
Thanks!

Frankly, I've been pretty lax about this.
I think most people don't really worry too much about NaN, treating them almost like undefined behavior.  The vast majority of code I've seen smply doesn't really deal with NaNs, or deals with them by avoiding them.
For the vast majority of code I'm not sure it's worth the overhead to check for NaNs and reproduce the Intel API's behavior exactly.  That said, I'd certainly be open to allowing people to opt in to more faithful NaN handling.  Maybe by defining a preprocessor macro before including SIMDe (SIMDE_FAITHFUL_NANS?), or possibly even calling a different function (e.g., simde_nan_mm_min_ps instead of simde_mm_min_ps, or some other name)?
For example, in this case I think you'd need a couple of vceqq_f32s to check for NaNs, plus the vminq_f32, then you'd have to blend everything together.  That's a pretty big performance hit, and I suspect the percentage of code that would benefit from it is vanishingly small.  If we could do it more efficiently I'd be much more interested.
I'm definitely open to having my mind changed here. Are you actually havinge a problem with this, or just bringing up somethnig you noticed?
I should definitely document this somewhere…

Thanks for the detailed response!

For example, in this case I think you'd need a couple of vceqq_f32s to check for NaNs, plus the vminq_f32, then you'd have to blend everything together. That's a pretty big performance hit, and I suspect the percentage of code that would benefit from it is vanishingly small. If we could do it more efficiently I'd be much more interested.

Agree that in most cases it wouldn't be noticeable, and in order to faithfully replicate behavior it would be require many more instructions and be a lot slower.

I'm definitely open to having my mind changed here. Are you actually havinge a problem with this, or just bringing up somethnig you noticed?

This came about as we were thinking of #76 . WebAssembly aims to be portable and deterministic, so it's important that we get the same results on all architectures. And so when we were looking at SIMDe from this angle, a co-worker noticed this difference in NaN handling.
Thus, when implementing WebAssembly functions, we will need to ensure the same behavior (even without the hypothetical SIMDE_FAITHFUL_NANS), i.e. a wasm_f32x4_min cannot be simply lowered to minps. (zeux/wasm-simd nicely documents the instruction sequence difference for various Wasm instructions, particularly see f32x4 or f64x2 instructions which map directly to a single ARM instruction, but requires more work on x86).

I should definitely document this somewhere…

Yea! I think it would be nice to point this out in the README, with this issue linked as an example? It would be tiring to try and list it out exhaustively :)

Maybe it would be more appropriate to invert the logic, and instead have people define SIMDE_UNFAITHFUL_NANS (or likely something else, I haven't really thought about the name at all)?  Safe defaults with an opt-in to sacrifice compatibility for speed (kind of like -ffast-math) is probably better than unsafe-by-default.
TBH, I was thinking about this more from the perspective of getting existing SSE/AVX code to run fast on other CPUs, which I think is going to be the common case for the Intel implementations.
However, for other architectures (including WebAssembly) using SIMDe to make it easier to write software targeting that architecture is a very important use case.  I know I'd love to be able to develop WASM, NEON, POWER, etc. code on my x86 desktop without an emulator, interpreter, cross-compiler, etc.  That's actually one of the main use cases for SIMDe, and for that case I think safe by default makes a lot of sense.
I don't think it would be particularly difficult to start adding NaN test cases to eliminate this type of issue, though it would be rather time-consuming.
Thanks for bringing this up.  Obviously I haven't spent nearly enough time thinking about this issue :/

Maybe it would be more appropriate to invert the logic, and instead have people define SIMDE_UNFAITHFUL_NANS (or likely something else, I haven't really thought about the name at all)? Safe defaults with an opt-in to sacrifice compatibility for speed (kind of like -ffast-math) is probably better than unsafe-by-default.

SIMDE_UNFAITHFUL_NANS sounds like a great band name :)
It does seem more natural to follow what gcc/clang does with -ffast-math - correctness by default, and opt-int to speed (which sacrifices accuracy)

I don't think it would be particularly difficult to start adding NaN test cases to eliminate this type of issue, though it would be rather time-consuming.

Yea agree, there is a manageable pair of "interesting" constants we will want to test for:

-0.0, 0.0
0.0, -0.0
qNaN, 1.0
1.0, qNaN
sNaN, 1.0
1.0, sNaN

This should be sufficient to uncover a lot of differences

Thanks for bringing this up. Obviously I haven't spent nearly enough time thinking about this issue :/

Ofc, no problem at all. Thanks for your thoughtful response, it's great to hear about your motivation, and how responsive you are to our feedback. And credit to @Maratyszcza for noticing these differences.

Okay, this is finally fixed in master (with 1957409d941998d97221bc91b76ca7cf12398b8d), sorry it took so long.
_mm_min_ps was actually substantially simpler than I'd feared; it doesn't treat NaNs as < normal numbers, it really behaves like (a < b) ? a : b.  (NaN, normal) returns normal, and (normal, NaN) returns NaN.  I just used vcmpltq_f32 (plus a couple masks), so it's faster than I was expecting.
For the unfaithful NaNs stuff, I went with SIMDE_FAST_NANS.  I also noticed that GCC and clang define __FINITE_MATH_ONLY__ to 1 if you use -ffinite-math-only, which is included in -ffast-math.  Since it does exactly the same thing as SIMDE_FAST_NANS I went ahead and defined SIMDE_FAST_NANS if __FINITE_MATH_ONLY__ == 1, unless you override that by defining SIMDE_NO_FAST_NANS.
I also added a few other SIMDE_FAST_* settings, one for the rounding mode and one for how to round ties, but neither actually does anything yet.
Defining SIMDE_FAST_MATH (or passing -ffast-math to the compiler) enables all the SIMDE_FAST_* options, but I might take SIMDE_FAST_ROUND_MODE out of that and require the user to explicitly define it.  IMHO SIMDE_FAST_ROUND_TIES definitely makes sense, though.


for node.js without a browser context

Hi, mourner
At first, really THANKS for this excellent work.
I'm working on porting simpleheat to node and rendering the heatmap with node-canvas.
As simpleheat is designed for browsers at the first place,  I have done some revisions to make it work on node-canvas.
Everything works fine except the method to create canvas is not in the best way as the codes show.
Cheers

@mourner
done some updates as you advised.
Please have a check.

Tested manually in node and all kinds of browsers.
Maybe consider to write some test codes? I can have a try. :)

Looks great! I'll look into adding some tests/CI.

hi @mourner ,
Could you publish a new version on npm to take this PR on board?
Thank you very much!
:)


canonical

Issue template
If you are reporting a new issue, make sure that we do not have any
duplicates already open. You can ensure this by searching the issue list for
this repository. If there is a duplicate, please close your issue and add a
comment to the existing issue instead.
General support information
GitHub Issues are reserved for actionable bug reports and feature requests.
General questions should be sent to the
S3 scality server Forum.
Bug report information
(delete this section if not applicable)
Description
Briefly describe the problem you are having in a few paragraphs.
Steps to reproduce the issue
Please provide steps to reproduce, including full log output
Actual result
Describe the results you received
Expected result
Describe the results you expecteds
Additional information: (Node.js version, Docker version, etc)
Feature Request
(delete this section if not applicable)
Proposal
Describe the feature
Current behavior
What currently happens
Desired behavior
What you would like to happen
Use case
Please provide use cases for changing the current behavior

No issue stated. Please reopen with description of issue.


3D Improved UNet for segmenting 3D prostate data - Nathan King (47399718)

Hello Teaching Team,
This is my pull request for the COMP3710 Project Semester 2 2024 to merge my topic-recognition branch to Shakes' topic recognition branch.
I completed the 3D Improved UNet task (Task 4) to segment the 3D prostate MRI dataset (https://data.csiro.au/collection/csiro:51392v2?redirected=true) with all class labels achieving a minimum dice similarity coefficient of 0.7. Regarding the dice similarity coefficients for the test data, I managed to produce 0.9911 for background, 0.9741 for body, 0.8620 for bone, 0.8717 for bladder, 0.7443 for rectum and 0.7318 for prostate. Additionally, the multiclass dice similarity coefficient produced was 0.8625.
All relevant files for this task are contained in the '3D Improved UNet for segmenting 3D prostate data - Nathan King (47399718)' folder. These files are listed below.

readme_assets: This folder contains visual assets for the README.md file.
README.md: This file contains documentation of the project, including model explanations, script instructions, training plots and example visualisations.
modules.py: This script constructs the individual modules of the 3D Improved UNet Model. Additionally, the individual modules are combined to build the entire model.
dataset.py: This script contains a function used to downscale and load the training, testing and validation data from the MRI and label .nii files.
train.py: This script executes the training, validating, testing and saving process of the 3D Improved UNet Model. Additionally, accuracy, loss, multiclass dice coefficient and dice similarity coefficient plots are created and saved to visualise the performance of the model.
predict.py: This script executes the loading and testing process of the trained 3D Improved UNet Model. Additionally, examples showing the input, true segmentation and predicted segmentation are visualised and saved to depict the performance of the model.

Please read the script running instructions to successfully use train.py and predict.py.
Thank you,
Nathan King 47399718

This is an initial inspection, no action is required at this point
Recognition problem: total 20 Marks
Problem Solving: (5)
•	Algorithm solves the problem and achieves a Dice score of above 0.73 for all labels.
Algorithm implementation: (3)
•	Algorithm implemented in Tensorflow for the improved UNet3D model and functions.
Design: Good coding design (1)
Commenting: Clear and sufficient comments throughout the code (1)
Difficulty: 3D Improved UNet – Hard (10)

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
Header blocks.
Recognition Problem
Good solution to problem.
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found.
Difficulty : Hard. UNet3D (Hard Difficulty)
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Good.
Model/technical explanation :Good.
Description and Comments :Good.
Markdown used and PDF submitted. PDF checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). On time submission.
No Feedback required.
Request Description is good.
TOTAL0

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

Segmentations not one hot encoded -2 additionally

Correction, segmentations do use one-hot encoding +2


Stop using deprecated URI.parser

Describe the change
Use recommended way to get the parser URI::DEFAULT_PARSER instead of deprecated URI.parser
Why are we doing this?
It has been deprecated in https://github.com/rails/rails/pull/39733
Benefits
Stops throwing a warning on 6.1 alpha.
Drawbacks
None
Requirements
Put an X between brackets on each line if you have done the item:
[] Tests written & passing locally?
[x] Code style checked?
[] Rebased with master branch?
[] Documentaion updated?

Hi Dainius,
Thanks for using loaf and submitting this PR!
Please see my comment re using unescape directly. Could you please verify that this change works and if it does resubmit PR? I will review and merge.

Hi Piotr,
I have actually made a mistake in the previous commit. It was supposed to be URI::DEFAULT_PARSER and not URI.DEFAULT_PARSER, sorry about that. In regards to your message about not using this default parser, I believe that the internal implementation you have linked to was also deprecated in ruby 2.7 https://github.com/ruby/ruby/blob/ruby_2_7/lib/uri/common.rb#L133 and removed in ruby 3 here https://github.com/ruby/ruby/commit/abbd3241522495e8d8634c0c01a42453f76ce6b8 :)

I'm persuaded. Thanks for providing references, learnt something new about Ruby.
Would you have time to add a note in the changelog file as well?

Changelog updated 👍

@dsazup Taking this opportunity, I'd like to get your thoughts on this issue https://github.com/piotrmurach/loaf/pull/42. I'm undecided (my thoughts are in the thread) and would like to resolve it one way or the other before I cut a new release.

Coverage remained the same at 96.939% when pulling ffc5242d2f59cb1cdae6b498c6d18fbd966df166 on dsazup:uri-parser into 8f6a74c6ae3fd3ad5500dfbce28cc9c4fc28e35a on piotrmurach:master.

Thank you! ❤

Released v0.10.0 with your contribution. Another notable change is this version is lighter and only relies on railties.


How to have multiple approvers in paralel

How to accomplish following scenario. Please update the docs.
In company there are two bosses., Eather one or eather second must approve. (Not AND, it is OR)
Both bosses/approvers are added to the group. With same sequence number.
But both are asked to approve (in this example scenario, if one approves, the other does not need to do anything)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0bfbcf9b-e03f-6f8f-a3c6-3096a88659e5
Version Independent ID: bd264840-a48d-de2d-728a-23e8e4ad9225
Content: How to Set Up Workflow Users - Business Central
Content Source: business-central/across-how-to-set-up-workflow-users.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Hello @hkusulja,
Our apologies for the delay in responding to this question. If you want to use the "native" workflow engine, you can set up one of the two approvers as the substitute approver.
Alternatively, you can build quite elaborate workflows using Microsoft Power Automate that includes a number of templates, such as this one: https://docs.microsoft.com/en-us/power-automate/parallel-modern-approvals. You can then use the built-in connector to integrate with Dynamics 365 Business Central.

Please update the offical docs about this info / scenario to avoid confusion.


Shared Preferences

Description
Initialize Shared Preferences in the app
File Location
- data
|__ sharedpreferences
      |___ vost_shared_preferences.dart
- domain
|__ managers
     |___ shared_preferences_manager.dart

Requirements

Create class that manages the https://pub.dev/packages/shared_preferences plugin - VostSharedPreferences. This class should read and write into the shared Preferences.

All the keys should const and Stringand should be declared as private at the bottom of the file

Create class that abstracts managing the shared preferences : SharedPreferencesManager -> this class will know the default value for each preference, example: if we are trying to get a list of ids, instead of null, we should return an empty array. This class has a get and set method for each value. If needed, it can also have a set method that sets multiple values.

NOTE:
Since that at the start we don't have any values to store, please create a new String value to store with the key test_shared.

Hey guys, is this issue assigned to someone? If not I can help :)

Go ahead @freitzzz !
I'll assign the issue to you
I'm just going to edit the description to be more clear, other than that you're good to go!

Got it!
Will start working on the issue asap

@freitzzz any news? Did you manage to have time to complete the PR?

Due to inactivity, I'm going to remove the assignee of this issue

Due to inactivity, I'm going to remove the assignee of this issue

Hi @Vanethos !
Unfortunately I've been very inactive on Github due to work and school consuming most of my work and spare time :( I'm sorry that I wasn't able to help and answer you in time!
I will also make sure that I can work on a PR next time I ask for an assignee on an issue.
Cheers,
freitzzz

@freitzzz There's no problem in that!
The joy of open-source is being able to contribute to projects when we have time!
And sometimes life just happens or we don't have the time or energy to do it and that's totally okay :D
When we have less time, others will have more time, and vice-versa, so I just removed you from this issue not for "punishment", but because others (in this case myself) had time to finish this off now.
There are plenty of issues still open, and more to come, so please, don't see this as a way to scold you! We want more contributions and yours would be valuable to this project :D

Hello, @Vanethos  I'm glad to help with this issue <3. BTW I love the way you structured the app.

@Vanethos  can you explain what is the roles for VostSharedPreferences and SharedPreferencesManager.
Should  VostSharedPreferences be just a wrapper to SharedPreferences plugin and  SharedPreferencesManager methods like setUser() ?

@TarekkMA
As you can see this issue has been assigned to me and I have already created a PR for it
But you have other issues that you can do!

Oh okay thank you I will select another issue


Crash on ES.Next Class Method (Property) Decorator

Atom Crashes each time on parsing a property decorator (ES.Next/Babel)

Repro Steps

Open a file with a property decorator and at least one letter for a function signature

or

Write a class with a property decorator
Start writing the funtion signature ... crash

Expected: Work as usual
Actual: Atom crashes
Versions

Atom:       1.16.0
Atom-Shell:
OS:         linux 4.8.0-52-generic
Misc

apm  1.16.1
npm  3.10.5
node 6.9.5 x64
python 2.7.12
git 2.7.4

This report was created in and posted from the Atom editor using the package bug-report v0.7.1.

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way 😀

So what's the issue now?
I think this issue is very easy to understand and doesn't necessarily need more clarification.
But anyway, I think I filled out the whole form as generated by the bug-report plugin.
The only thing I didn't do was make a screenie of my atom crashing ...
So what can I do to meet you half way ... I don't understand

There are details missing from your issue body. The most important of which is whether you have actually followed the required prerequisite checklist;

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

There's obviously a very good reason we use an issue template.
Either edit your original issue body using the issue template (or provide all required information in an equivalent format), or open a new issue where you use the issue template.

bug-report was created before there were issue templates and doesn't include all the information that we need.  Now that issue templates exist, it is better that you file issues from the GitHub website.

ahh, thx ...

thx, you were right:

it was an issue with linter-jscs
linter-jscs they say is discontinued in favor of eslint
the issue was already reported
cheers


Add basic language server

😮 this is sweet!
Before you spend too much time on this, make sure to take a look at the updated global options docs here, which will be pushed with v2.3 very soon: https://github.com/caddyserver/website/blob/master/src/docs/markdown/caddyfile/options.md

😮 this is sweet!
Before you spend too much time on this, make sure to take a look at the updated global options docs here, which will be pushed with v2.3 very soon: https://github.com/caddyserver/website/blob/master/src/docs/markdown/caddyfile/options.md
Edit: lol you clicked merge before I got the chance to submit my comment 😅

Haha, all good.  I'll take look into that 👍

Ooo wow! I can't wait to try this.
I hope you're able to automatically render/update the docs for this, somehow? We don't really have a good structured definition of the Caddyfile for programmable purposes...

Ooo wow! I can't wait to try this.
I hope you're able to automatically render/update the docs for this, somehow? We don't really have a good structured definition of the Caddyfile for programmable purposes...

My goal was to get a basic language server integrated, if you haven't seen already the code is a mess.  I should probably write some code to generate the documentation from the docs so it can be easily updated.  I'm still trying to figure out the best way to handle certain things such as suggestions for directives as some can only appear under a certain scope, and how to handle extensions that register global options or new directives.


Clean up “Non-preempting PriorityClasses” page section

This is a cleanup issue
This issue is about clean-up work for https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#non-preempting-priority-class

The table of contents does not list “Non-preempting PriorityClasses”.
The section for Non-preempting PriorityClasses (alpha) should use a feature state shortcode.

Proposed Solution:

Change the heading level for:

### Non-preempting PriorityClasses (alpha) {#non-preempting-priority-class}

so that this section appears in the table of contents.
Remove the text

1.15 adds the `PreemptionPolicy` field as an alpha feature.
It is disabled by default in 1.15,
and requires the `NonPreemptingPriority`[feature gate](/docs/reference/command-line-tools-reference/feature-gates/
) to be enabled.

and add a feature state shortcode:{{< feature-state for_k8s_version="1.15" state="alpha" >}}

Page to Update:
https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/

Additional Information:
/kind cleanup
/priority backlog
/good-first-issue

If you are new to contributing to the website, want to help with this issue and have questions, reply here and someone from SIG Docs will offer you advice.
(It's also OK to ask questions if you're already participating; it'd be great to leave this issue for a new contributor though).

/assign

PS. It's important that readers get to learn about the feature gates named PreemptionPolicy and NonPreemptingPriority.


Version 2 roadmap

This is an all encompassing PR to cover #10 and #11 as well as address issues #7, #8, #12, and #13
It is designed to be merged for a Breaking Change version bump (2.0.0).
It introduces validateDidInsert, validateTracked, capturing all errors, and handling event bubbling (attach to non-field elements).

[x] Write docs for validateDidInsert
[x] Write docs for validateTracked
[x] Write docs for validated event detail (multiple errors handling)
[x] Add doc statement about bubbling for non-field elements
[x] Write docs for verify-form-validity
[x] Write tests for verify-form-validity
[ ] Build out a more user friendly demo/documentation site in dummy app and deploy to gh-pages
[ ] Clean Git history

I just tried this branch in one of our documentation projects and it works great! I think I'm going to clean this up and merge soon.

Spoke too soon. using validateDidInsert caused an error

Uncaught (in promise) TypeError: target.setCustomValidity is not a function

Because I set this up to work with event bubbling it enabled the modifier to be placed on non-field elements. This meant that when the user triggered a validation (via input/change/blur) it would bubble and trigger the handler. Since the original element was the input element the event.target is a valid input element and thus has a setCustomValidity().
When I performed this with the validateDidInsert flag the modifier has no idea of the element it is attached to thus dispatching the validate event on a non-input element. When the handler triggers the event.target is not an input and thus setCustomValidity() is not available.
I need to figure out either placing an assert to prevent this (or offer a better error message) OR maybe instead attempt to discover the input element via a DOM walk?

Fixed missingsetCustomValidity error with validateDidInsert/validateTracked use. Easy enough to walk the DOM to find valid input fields. And if none found no-op.