Add operands to filter/order screen for each column

Is your feature request related to a problem? Please describe.
Not a problem, but a easier filter on multiple columns
Describe the solution you'd like
Add opernd to each column in filter/order screen. So it is very similar to what we have when right click on column and select filter by cell/custom/clipboard. Tried to discribe it on screenshot. Same logic exists in phpmyadmin and it is very handy.

Screenshot from phpmyadmin.

You could use Context menu-Filter or F11 right in the resultset.
Filters will be provided

Is it solved your problem?

Filter with context menu is handy when you need only filter one column and we have filter/order window that uses for filter by many columns so its common to have same logic for filter like in context. Without it its very unclear for what case you will use filter\order window.

thanks for clarification and suggestion :)


Umbraco 8.15 - Articulate

Hi with umbraco 8.15 and articulate, I have a problem in post.chtml it gives me this error: Method not found: 'System.String Markdig.Markdown.ToHtml (System.String, Markdig.MarkdownPipeline)'. with @ Model.Body.
Can you help me? Thank you

Not sure, what theme are you using? is it a custom theme? I cannot replicate this issue on my site which is running 8.15.2


Prevent module redefinition in same tx

In the transcript below, after loading the following module once:
(module y 'ks  (defcap FOO () (enforce false ""))   (defun f () (with-capability (FOO) 5))  )

I have to load this modified version of it twice before it actually takes hold:
(module y 'ks  (defcap FOO () (enforce true ""))   (defun f () (with-capability (FOO) 5))  )

Transcript:
pact> (env-data { "keyset": { "keys": ["admin"], "pred": "=" } })
"Setting transaction data"
pact> (env-keys ["admin"])
"Setting transaction keys"
pact> (define-keyset 'ks (read-keyset 'keyset))
"Keyset defined"
pact> (module y 'ks  (defcap FOO () (enforce false ""))   (defun f () (with-capability (FOO) 5))  )
"Loaded module y, hash 8feeb41510079e1d8832ed25d5ded4a38f9234fef87f68125c6b367a99ed1086c142773a3ea6bd7857cfb04b1920583975d3cc54ccc02e493f6e49317bef17c8"
pact> (f)
<interactive>:0:0:
 at <interactive>:0:0:
 at <interactive>:0:0: (enforce LBool {_lBool = False} LString {_lString = ""})
 at <interactive>:0:0: (FOO)
 at <interactive>:0:0: (with-capability <app Ref (TDef {_tDef = Def {_dDefName = DefName "FOO", _dModule = ModuleName {_mnName = "y", _mnNamespace = Nothing}, _dDefType = Defcap, _dFunType = FunType {_ftArgs = [], _ftReturn = TyVar {_tyVar = TypeVar {_tvName = TypeVarName {_typeVarName = "a"}, _tvConstraint = []}}}, _dDefBody = Scope (TList [TApp (App {_appFun = TVar (F (TVar (Direct (TNative {_tNativeName = NativeDefName "enforce", _tNativeFun = NativeDFun (NativeDefName "enforce") _, _tFunTypes = FunType {_ftArgs = [Arg {_aName = "test", _aType = TyPrim TyBool, _aInfo = },Arg {_aName = "msg", _aType = TyPrim TyString, _aInfo = }], _ftReturn = TyPrim TyBool} :| [], _tNativeExamples = [ExecErrExample "(enforce (!= (+ 2 2) 4) \"Chaos reigns\")"], _tNativeDocs = "Fail transaction with MSG if pure expression TEST is false. Otherwise, returns true.", _tNativeTopLevelOnly = False, _tInfo = })) )) enforce , _appArgs = [TLiteral (LBool {_lBool = False}) false ,TLiteral (LString {_lString = ""}) ""], _appInfo = (enforce false "")}) (enforce false "")] TyAny (defcap FOO () (enforce false ...), _dMeta = Meta {_mDocs = Nothing, _mModel = []}, _dInfo = (defcap FOO () (enforce false ...}, _tInfo = (defcap FOO () (enforce false ...})> <list(1)>)
 at <interactive>:0:0: (f)
pact>
pact> (module y 'ks  (defcap FOO () (enforce true ""))   (defun f () (with-capability (FOO) 5))  )
"Loaded module y, hash 3a62c8dc47d1c4d3ed8f2f45f1af53280582dc077c05808f52aef67372a9258dec250f7eb4f5b3e1c64e91403483d861ca7b010013af9d2509781dfb71cf20f8"
pact>
pact> (f)
<interactive>:0:0:
 at <interactive>:0:0:
 at <interactive>:0:0: (enforce LBool {_lBool = False} LString {_lString = ""})
 at <interactive>:0:0: (FOO)
 at <interactive>:0:0: (with-capability <app Ref (TDef {_tDef = Def {_dDefName = DefName "FOO", _dModule = ModuleName {_mnName = "y", _mnNamespace = Nothing}, _dDefType = Defcap, _dFunType = FunType {_ftArgs = [], _ftReturn = TyVar {_tyVar = TypeVar {_tvName = TypeVarName {_typeVarName = "a"}, _tvConstraint = []}}}, _dDefBody = Scope (TList [TApp (App {_appFun = TVar (F (TVar (Direct (TNative {_tNativeName = NativeDefName "enforce", _tNativeFun = NativeDFun (NativeDefName "enforce") _, _tFunTypes = FunType {_ftArgs = [Arg {_aName = "test", _aType = TyPrim TyBool, _aInfo = },Arg {_aName = "msg", _aType = TyPrim TyString, _aInfo = }], _ftReturn = TyPrim TyBool} :| [], _tNativeExamples = [ExecErrExample "(enforce (!= (+ 2 2) 4) \"Chaos reigns\")"], _tNativeDocs = "Fail transaction with MSG if pure expression TEST is false. Otherwise, returns true.", _tNativeTopLevelOnly = False, _tInfo = })) )) enforce , _appArgs = [TLiteral (LBool {_lBool = False}) false ,TLiteral (LString {_lString = ""}) ""], _appInfo = (enforce false "")}) (enforce false "")] TyAny (defcap FOO () (enforce false ...), _dMeta = Meta {_mDocs = Nothing, _mModel = []}, _dInfo = (defcap FOO () (enforce false ...}, _tInfo = (defcap FOO () (enforce false ...})> <list(1)>)
 at <interactive>:0:0: (f)
pact>
pact> (module y 'ks  (defcap FOO () (enforce true ""))   (defun f () (with-capability (FOO) 5))  )
"Loaded module y, hash 3a62c8dc47d1c4d3ed8f2f45f1af53280582dc077c05808f52aef67372a9258dec250f7eb4f5b3e1c64e91403483d861ca7b010013af9d2509781dfb71cf20f8"
pact>
pact> (f)
5

This is due to the fact that module redefinition doesn't work reliably outside of begin-tx-commit-tx pairs, which in the repl clear out the local namespace. In this case, there is nothing about defcap per se, you can reproduce the issue with (module y 'ks (defun foo () (enforce false "")) (defun f () (foo) 5)).
On the second load, the old definition of foo is dereferenced in f. By the third definition, the second definition of f is dereferenced.
Done properly with tx bracketing there is no issue.
pact> (begin-tx)
""
""
pact> (env-data { "keyset": { "keys": ["admin"], "pred": "=" } })
"Setting transaction data"
pact> (env-keys ["admin"])
"Setting transaction keys"
pact> (define-keyset 'ks (read-keyset 'keyset))
"Keyset defined"
pact> (module y 'ks  (defcap FOO () (enforce false ""))   (defun f () (with-capability (FOO) 5))  )
"Loaded module y, hash b26d25d75252bebda5362c9f2a8c9e665cb4bf831fc1f775c5305bffb569989330f4a4dc307d92319d639588f3b1c1ff3be288fa9311489fcb4cc6b4dc254063"
pact> (expect-failure "" (f))
"Expect failure: success: "
pact> (commit-tx)
""
""
pact> (begin-tx)
""
""
pact> (module y 'ks  (defcap FOO () (enforce true ""))   (defun f () (with-capability (FOO) 5))  )
"Loaded module y, hash b07da2e400951e1b4b776c76b4ccd9b91d568c3ee4fa61254882d9ebd50684fa3f1b88beb41357b25e6d639834378a7e3b1b35cc8a851fe6d24bf57f836760b6"
pact> (commit-tx)
""
""
pact> (y.f)
5

We can probably agree though that defining the same module twice in a transaction is A Bad Thing and prevent it.

To fix, enforce that the module name is not in _rsNewModules in _evalRefs here https://github.com/kadena-io/pact/blob/f8fbe7ba1c831f47a4801a6b67ae06a2d718cc57/src/Pact/Eval.hs#L238

@slpopejoy I agree that within begin-tx/commit-tx we probably want to disallow redefinition of a module.
But if I understand correctly, this would also throw an error if someone tries to redefine/overwrite a module in the REPL generally, right? It seems that this will likely confuse developers who are used to REPLs being forgiving about overwriting bindings, in the name of enabling rapid experiments/iterations. I know when I use the Pact REPL I sometimes redefine bindings repeatedly until I get the behavior I want.
To reduce surprise, it seems like we probably want to allow redefinitions of modules in the REPL, and if a binding like FOO appears, we first look in the module being redefined before using existing bindings in the environment.
Thoughts?

Thinking this is fine as-is, per @bts 's last comment. Closing, further discussion can reopen.


/generate_204 should generate an HTTP 204

For Captive Portal Assistant.

We'll want to add this to nginx.conf
location /generate_204 {
    keepalive_timeout 0;
    return 204;
 }


[REQUEST]Could you supply a option to exclude the feature for Canvas2D ?

I want to exclude Canvas2D for building a small bin file , Because my game only supports WebGL.
Thanks.

We plan to make this easy in v5.

@englercj  I found there are many good features in v5 , when & where  could I get the  early access version of v5 ?

@finscn in our dreams ;)

I haven't even started yet :) waiting for a couple refactoring changes from @GoodBoyDigital to hit v4, then I'll be off to the races for v5!

v5 will have this one covered :)


Fix bug #3318

Closes #3318
Summary
The TrackingId should be uppercase to work with Google Analytics.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: coretoco sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@coretoco can you update this PR to target the release/9.4.x branch instead of development.  We apologize for any confusion with the branching at this time.  We are working to make this more for DNN v10 and beyond.

@david-poindexter thank you for your feedback.
I created a new PR (#3322) into release/9.4.x and will close this one now.


TEC Service Doesn't Open the USB Port

Hi there,
I have configured the TEC controller with the TEC service before and now I would like to send commands through python. But it seems like the USB port is not open to do that?
Log is attached.
Thank you,
C:\Users\mk\AppData\Local\Programs\Python\Python37\python.exe "C:/Users/mk/Documents/RD_Assignments/1108/TEC 1090/pyMeCom for TEC Controller by spomjaksilp (3)/example.py"
Traceback (most recent call last):
File "C:/Users/mk/Documents/RD_Assignments/1108/TEC 1090/pyMeCom for TEC Controller by spomjaksilp (3)/example.py", line 106, in
mc = MeerstetterTEC()
File "C:/Users/mk/Documents/RD_Assignments/1108/TEC 1090/pyMeCom for TEC Controller by spomjaksilp (3)/example.py", line 45, in init
self._connect()
File "C:/Users/mk/Documents/RD_Assignments/1108/TEC 1090/pyMeCom for TEC Controller by spomjaksilp (3)/example.py", line 49, in _connect
self._session = MeCom(serialport=self.port)
File "C:\Users\mk\Documents\RD_Assignments\1108\TEC 1090\pyMeCom for TEC Controller by spomjaksilp (3)\mecom\mecom.py", line 420, in init
self.ser = Serial(port=serialport, timeout=timeout, write_timeout=timeout, baudrate=baudrate)
File "C:\Users\mk\AppData\Local\Programs\Python\Python37\lib\site-packages\pyserial-3.4-py3.7.egg\serial\serialwin32.py", line 31, in init
File "C:\Users\mk\AppData\Local\Programs\Python\Python37\lib\site-packages\pyserial-3.4-py3.7.egg\serial\serialutil.py", line 240, in init
File "C:\Users\mk\AppData\Local\Programs\Python\Python37\lib\site-packages\pyserial-3.4-py3.7.egg\serial\serialwin32.py", line 62, in open
serial.serialutil.SerialException: could not open port '/dev/ttyUSB0': FileNotFoundError(2, 'The system cannot find the path specified.', None, 3)

Hi mkardan,
from the log it looks like you are on a Windows machine. Please take a look at the class MeerstetterTEC in the example and you see that it has an optional argument port that defaults to "dev/ttyUSB0" which is a Linux address to a serial port. You will need to construct the Tec in the main function with your windows  port address.
Best regards,
Tim

Brilliant,  thanks a lot Tim. :)


Introduce @InternalApi

If a package is annotated with @InternalApi, this package and
all the subpackages it contains are not exposed in the Gradle API
jar.
Similarly, if a class within a non-annotated package is itself
annotated with @InternalApi, then it's not visible in the
Gradle API jar.
This approach lets us introduce new internal APIs which are
truly invisible to users, without relying on Java modules.
For now, because we only care about the Gradle API jar, it
means that the internal APIs are not visible in buildSrc,
but they are effectively usable in build scripts.
See #13501

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

This PR now makes the internal APIs invisible to both build scripts and the Gradle API. For Kotlin scripts there wasn't anything special to do since they already compile against the gradleApi().

How dare you, stalebot ?

nope

@bot-gradle test this

Sorry some internal error occurs, please contact the administrator @blindpirate

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

Sorry some internal error occurs, please contact the administrator @blindpirate

6.8 is really a cursed release

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

Sorry some internal error occurs, please contact the administrator @blindpirate

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

So the Gradleception build fails because the DetermineBaselinesTest lives in build-logic and uses the ProjectBuilder test fixture. This test fixture doesn't have access to the private classes anymore.
I'm wondering if it completely rules out this approach or if we should do something different :thinking:
@jjohannes FYI

Everything behaves as if the test was using the gradle api jar at runtime, instead of using the Gradle runtime :thinking:

I could confirm that this is the behavior (the generated API jar is on the test classpath, not the jars from Gradle itself).

nope


add task failed hook method for WorkflowStatusListener

We extended WorkflowStatusListener in our production environment and added onWorkflowFailed method for task fails. This feature was added because of it is not enough for terminate and complete status trigger and sometimes we need hook mechanism when one of the tasks fails when the workflow is not terminated. Pls evaluate this feature.

Hey @andyyumiao, while the purpose of this PR is to implement task-level notifications (IIUC), the implementation is incomplete and when bundled in together with the WorkflowStatusListener conflates the responsibilities of workflow-level notifications and violates the Interface Segregation principle.
Task level notifications should be a different interface and should provide controls to tweak notification levels based on attempts, retries, timeouts etc


[stable/postgresql] display secretName template generated by helper

Signed-off-by: Hugo Cortes<EMAIL_ADDRESS>What this PR does / why we need it:
Uses the secret name generated by the _helpers.tpl when outputting kubectl command to get secret.
Which issue this PR fixes
Postgres secret can be set by one of following variables:

global.postgresql.existingSecret
existingSecret
or simply the chart name

Previous if/else check omitted the global.postgresql.existingSecret value.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @prydonius

/ok-to-test
/lgtm


Godot_mono binary on macOS isn't possible to link in homebrew because of dependence on relative file paths

Tested versions
4.2-mono
System information
macOS 14.2
Issue description
I noticed an asymmetry between the godot and godot-mono casks on homebrew, so I added the link to godot-mono's binary to allow the user to invoke it from the command line in https://github.com/Homebrew/homebrew-cask/pull/163355. This hits a snag when you actually try to run the binary from the command-line, it fails with: •NET assemblies not found. Unable to find the NET assemblies directory. Make sure the opt/homebrew/bin/GodotSharp/Api/Debug' directory exists and contains the NET assemblies.. This is because the binary is looking for GodotSharp using a relative path, expecting to be executed from within the app bundle. I raised the issue here wondering how I could make the link execute with the correct working directory, and I was told that it isn't acceptable for the calling location to be assumed and the fix needed to happen upstream. I assume one could put the .NET assemblies in some shared system directory, but that would run against the much-lauded portability/lack of an installer with Godot. I am hoping there is some other option to allow us to run godot-mono from the command line in a homebrew cask like we are currently able to with godot.
Steps to reproduce
brew install godot-mono
godot-mono project.godot
Minimal reproduction project (MRP)
N/A

so I added the link to godot-mono's binary to allow the user to invoke it from the command line in

It's not a bug, there's absolutely no reason for the bundled app to look for resources anywhere except [[NSBundle mainBundle] resourcePath] (it can be relocated, and multiple versions can co-exist, so nothing outside the bundle should be directly referenced). Also, Godot is not intended to be used as a standalone executable, and you should not symlink part of the bundle. Instead, use a wrapper script (see what Blender or VS Codium casks do).
https://github.com/Homebrew/homebrew-cask/blob/e867f38d8e8a51c139fab025196a7ff84970e639/Casks/b/blender.rb#L22-L34

Thanks for pointing me in the right direction!


Optimise getReportOrDraftReport (Jason trace)

Problem
In the latest Jason trace, getReportOrDraftReport took 76ms. In the DEV environment, although timings vary, we achieved an improvement for around 25%
PR -> https://github.com/Expensify/App/pull/47404

This can be closed now as there was no other reviewer


update screencast, dependencies and fix tests

@aayusharora please check and merge

Current coverage is 46.45% (diff: 100%)

No coverage report found for development at b460e74.

Powered by Codecov. Last update b460e74...b7d9b0a

merging myself because we need to get the tests fixed asap


update icons

Reviewer: @MariagraziaAlastra @jagtalon

Description:

The badge and search icons are missing a red outline

Steps to test this PR:

Open about:extensions, or about:addons.
Badge and search icon should have an outline

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

LGTM, thanks


add foldername kwarg to servedocs

As discussed in #99. For documentation: is the record in the docstrings enough?
For tests I shamelessly copied the testsets and modified them, hope it's fine.

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 69.23%.

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   88.53%   88.53%
=======================================
  Files           4        4
  Lines         218      218
=======================================
  Hits          193      193
  Misses         25       25

Impacted Files
Coverage Δ

src/utils.jl
78.37% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d2aac...057511d. Read the comment docs.

This looks great, many thanks!
Could you please lightly update the docs? (man/functionalities/) the additional keyword sections
Then I'll merge and do a minor release with it, thanks!

Thanks Tamás!


Fix encoding problems in attributegroupreference and entityCounts

related issue: #547
The build is failing because of the new ACL changes.

I fixed the build in another branch and build is passing. I am merging this PR.


Istio Grafa not able to access

So i am running istio on aws ec2.
I am trying to depoy the grafana dashboard via this
kubectl -n istio-system port-forward $(kubectl -n istio-system get pod -l app=grafana -o jsonpath='{.items[0].metadata.name}') 3000:3000
However, when i try to access masterip:3000, nothing happens.
it slistening on port 3000 when i did a lsof
lsof -i:3000
COMMAND   PID USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
kubectl 12267  opc    6u  IPv4  45964      0t0  TCP localhost:hbci (LISTEN)
kubectl 12267  opc    7u  IPv6  45965      0t0  TCP localhost:hbci (LISTEN)
Whats happening. on local host this work however

port-forward only binds to <IP_ADDRESS> IOW, it will not bind to your master IP.  port-forward will not do what you want. In 1.0.0, there are config options called telemetry-ingress however that feature was DOA in 1.0.0 sadly.  1.0.2 has resolved this problem with commit: https://github.com/istio/istio/commit/40143b05d92e5192df5a4629da7ece36111aed17.  I'd encourage you to try 1.0.2
Use the helm commands documented with --set telemetry-gateway.grafanaEnabled and access port 15031 of your load balancer external IP.  Note there is no authentication!
Can you point out the documentation which mentions to use port-forward so it can be corrected?
Cheers
-steve

@leeadh and @sdake this is probably better discussed on a mailing-list.
Can we please move this to: istio-users@ googlegroups.com ?

@leeadh can you report this question on the mailing list please.
Thanks!
-steve

https://istio.io/docs/tasks/telemetry/using-istio-dashboard/
@sdake.  An using istio 1.1.0


Allow Refs to be hashable using their data

With the addition of the __eq__ method (#1048), Refs are no longer hashable. This PR should revert to the previous behavior.

Nice! Thanks!

Thanks for fixing this error I introduced, @happyraul !


add odex and mconala datasets

Added ODEX and MCoNaLa datasets in tasks. Followed the original code repository of ODEX and MCoNaLa to create the processing and evaluation functions.

The current scores for this implementation for codegen-2b-mono are:
{
  "odex-en": {
    "pass@1": 0.3679726651480638,
    "pass@2": 0.40785644553949135,
    "pass@5": 0.44750070323076746,
    "pass@10": 0.4676729704105087
  },
  "config": {
    "model": "Salesforce/codegen-2B-mono",
    "temperature": 0.2,
    "n_samples": 50
  }
}

This is higher than number reported in Odex paper due to the original implementation not stripping the prompts (see issue https://github.com/zorazrw/odex/issues/5) However when stripping the prompt in that implementation the pass@1 in greedy mode is
Overall Pass@K Scores:
[pass@1] 0.4100 (439)

This implementation gives a pass@1 of
{
  "odex-en": {
    "pass@1": 0.3712984054669704
  },
  "config": {
    "model": "Salesforce/codegen-2B-mono",
    "temperature": 1e-06,
    "n_samples": 1
  }
}

So there is still a gap to be investigated


Commit Linting during pipeline execution

Summary
Feat: Adds linting to commits, grouping them on release, and ensuring commit messages fit the conventional commits standard
Fix: Adds version number to the Pull Request alert GH Workflow step, as specific versioning is required

Would add commit linting as a step under the lint job in the circuit.yml ~ Circuit Build & Test CI pipeline. Also, please use the latest version of the action.

I don't think that's required, it isn't relevant to circuit not the build pipeline. This would still block the pr from merging and we should try to steer away from mono-ci

Would add commit linting as a step under the lint job in the circuit.yml ~ Circuit Build & Test CI pipeline. Also, please use the latest version of the action.

I don't think that's required, it isn't relevant to circuit nor the build pipeline. This would still block the pr from merging and we should try to steer away from mono-ci
It would also take longer since this job can be async whilst the others are ongoing.

yea, would increase the std pipeline duration a little bit but would want it to actually fail if commits haven't been massaged..dirty commits shouldn't be merged.

Hi, not sure how this happened...
[phpengine](https://github.com/phpengine) dismissed [AwesomeIbex](https://github.com/AwesomeIbex)’s [stale review](https://github.com/t3rn/t3rn/pull/393#pullrequestreview-1037019919) via [b203439](https://github.com/t3rn/t3rn/commit/b203439084085a837fc193fb0fb92a5ccc7f2d38) 4 minutes ago


Create a generation dataset and corresponding forward

There are multiple components modified here since generation case is quite different。
Modification includes

A new CustomLMDataset (because we need both input_ids, original length and raw answers)
A new collate_fn for organizing the dataset
A new forward method for model.generate
A new criteria function for training

@ZidongLiu Hi Zidong, can you help us review the codes? Thank you!


Update README.me with new text and new logo

Also please fix PR title by providing a context and run the formatter.


Do not recommend catching Stack Overflow excption

Please reconsider the guidance on this page. Trying to recover from SO is problematic from security perspective as it can leave the system in an undefined state. It is similarly questionable as catching OOM or NRE; it is generally hard to know if it is safe to continue executing the program.
At the very least make it clear that the call to _alloca or _malloca should be the only thing in the __try block. There should be no // code ... for the reasons mentioned above.
Also, since the warning text is confusing because it makes it look like _malloca does not raise SO, it may be a good idea to go into more details to clear things up.

Make it clear that _malloca is not immune to SO either, it simply has a hardcoded threshold of memory size that it would not try to allocate on the stack.
Emphasize that _freea is required to avoid memory leaks.
Overall, explain what exactly silences this warning - catching SO, switching to _malloca, or both?

Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 363ab89d-ac4b-f979-1532-5937c7f792a5
Version Independent ID: 63a697ff-eda6-10bf-fc9e-3b57e5533908
Content: C6255
Content Source: docs/code-quality/c6255.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

We are in the process of moving away from GitHub issues for C++ documentation (we still accept pull requests). For details, please see Announcing a new way to give feedback on Microsoft Learn This issue will be closed after it is copied to an internal tracking system.


feat request: colorize the message

@xy-planning-network has a nice feature on the forked repo: https://github.com/xy-planning-network/tint/commit/662ca545427ccb5267ee2dab1e49271d98da3c9c
looking forward to have this in tint

You can add custom coloring using the ReplaceAttr option or create/use a fork with this feature.
The output format is opinionated and I want the API to stay small and close to the slog.TextHandler. There are many requests for small format changes. So far the ReplaceAttr option seems like a good middle ground.

ReplaceAttr doesn't tell the log level, so hard to colorize per level


Bug in value builder

Value Builder is not working with bool value with the below code
code:
void main() => runApp(MaterialApp(home: Home()));

class Home extends StatelessWidget {
  const Home({ Key? key }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Theme using GetX'),),
      body: Column(
        children: [
          ListTile(
            title: const Text('Dark mode'),
            leading: const Icon(Icons.dark_mode),
            trailing: ValueBuilder<bool>(
              initialValue: Get.isDarkMode,
              builder: (darkMode, toggleDarkMode) {
                return Switch(
                  value: darkMode,
                  onChanged: (_){
                    Get.changeThemeMode(!darkMode ? ThemeMode.dark : ThemeMode.light);
                    toggleDarkMode(!darkMode);
                  },
                );
              },
            )
          )
        ],
      ),
    );
  }
}

error :
════════ Exception caught by widgets library ═══════════════════════════════════
The following TypeErrorImpl was thrown building ValueBuilder(dirty, state: _ValueBuilderState#b6583):
Expected a value of type '(bool?, (bool?) => void) => Widget', but got one of type '(bool, (bool) => void) => Switch'
Value Builder is working after setting value to bool? with the below code
Working code:
void main() => runApp(MaterialApp(home: Home()));

class Home extends StatelessWidget {
  const Home({ Key? key }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Theme using GetX'),),
      body: Column(
        children: [
          ListTile(
            title: const Text('Dark mode'),
            leading: const Icon(Icons.dark_mode),
            trailing: ValueBuilder<bool?>(
              initialValue: Get.isDarkMode,
              builder: (darkMode, toggleDarkMode) {
                return Switch(
                  value: darkMode as bool,
                  onChanged: (_){
                    Get.changeThemeMode(!darkMode ? ThemeMode.dark : ThemeMode.light);
                    toggleDarkMode(!darkMode);
                  },
                );
              },
            )
          )
        ],
      ),
    );
  }
}
```

This is happening due to Null Safety.
builder takes (T?, (T?) => void ) => Widget, so non null values will throw this.
The working code you provided is how it should be. Not sure this is a bug as much as a documentation issue.
NOTE: value: darkMode as bool can be changed to value: darkMode!


Error: undefined method `jasperserver' for #<Rails:: ...

Here is my controller:
class ReportsController < ApplicationController
  require 'jasperserver-rails'

  def index
    @council_report = CouncilReport.find(params[:council_report_id])
  end

  def run_report(report_name, report_id)
    JasperserverRails::Jasperserver.new.run_report report_name + '.pdf' do
      format 'pdf'
      report report_name
      params({ :council_report_id => report_id.to_s })
    end
  end

  def proposed_works_summary
    @council_report = CouncilReport.find(params[:council_report_id])
    run_report('cams/proposed_works_summary', @council_report)
  end
end

Everything else is as per the usage instructions. What am I missing?

I believe you're missing the initializer in config/initializers.

I updated the README with the instructions for setting up the initializer and config file.

@forbov Did you solve this issue?


Default iframe set via env var

Checked for duplicates
Yes - I've already checked
Alternatives considered
No - I haven't considered
Related problems
No response
Describe the feature request
I want a way to set the default iframe url for the aerie UI when started - without having to define a new view. Currently this is hard coded as 'https://eyes.nasa.gov/apps/mars2020/#/home'.

action to discuss if this is the preferred mechanism for customizing


Add two_qubit_cnot_decompose to qiskit.synthesis docstring

I think this two_qubit_cnot_decompose is missing an .. autofunction:: in the docstring?  If it's meant to be there, let's take a note to add it after rc1 - no need to hold up the PR over a documentation thing.
Originally posted by @jakelishman in https://github.com/Qiskit/qiskit/pull/11687#discussion_r1475028459

I wasn't sure what to do with this function, since it has no docstring, and also due to the comment here:
https://github.com/Qiskit/qiskit/blob/a234ff2dc717884fa9b1c3dce3e3d8c4c3eccbfb/qiskit/synthesis/two_qubit/two_qubit_decompose.py#L1531


Merge staging-next into master

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: freetype, libxml2, poezio, python, shared-mime-info
Partial log (click to expand)
copying path '/nix/store/9bq20m0axq1hv3ni93m20p91k80rl0i1-gnupg-2.2.10' from 'https://cache.nixos.org'...
copying path '/nix/store/9j41fd2q769i7knrp3g32cnq5n380yh0-python3.6-pycrypto-3.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/cvyw1zrm7scd8qk96dni145fglzm5gr1-python3.6-python-potr-1.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/7wxz7rsbl5c8x3bcm5kzar57pwnh4r1i-python3.6-slixmpp-1.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/pm5blvis5r9dvmsm0xkmn50aqmmvk0pm-poezio-0.12' from 'https://cache.nixos.org'...
/nix/store/s17fqpr4iwfrr11n2j0n0s07vjybwha1-freetype-2.9
/nix/store/sfvr5ib3yqyxj2vzr832in3dsihqsriy-libxml2-2.9.8-bin
/nix/store/pm5blvis5r9dvmsm0xkmn50aqmmvk0pm-poezio-0.12
/nix/store/74b1xd5srd6ja54xwznvbrd5hcfl6k1n-python-2.7.15
/nix/store/686gkgsa2mghx3hzv90s4dj5wzmr5n94-shared-mime-info-1.10

Success on x86_64-darwin (full log)
Attempted: freetype, libxml2, python, shared-mime-info
The following builds were skipped because they don't evaluate on x86_64-darwin: poezio
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/vnbwgv7fwfb4irvf1yapk0jz2ga27brk-freetype-2.9/lib
patching script interpreter paths in /nix/store/vnbwgv7fwfb4irvf1yapk0jz2ga27brk-freetype-2.9
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/211pbdy3v8yqkh79nykvjblz4njyxl0p-freetype-2.9-dev/lib  /nix/store/211pbdy3v8yqkh79nykvjblz4njyxl0p-freetype-2.9-dev/bin
patching script interpreter paths in /nix/store/211pbdy3v8yqkh79nykvjblz4njyxl0p-freetype-2.9-dev
/nix/store/211pbdy3v8yqkh79nykvjblz4njyxl0p-freetype-2.9-dev/bin/.freetype-config-wrapped: interpreter directive changed from " /bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/vnbwgv7fwfb4irvf1yapk0jz2ga27brk-freetype-2.9
/nix/store/fy1lmal54cgkr714fv1iy3m5wprjks2h-libxml2-2.9.8-bin
/nix/store/c6mnc84yva1wa85nzjfha6mxfsk6qbg7-python-2.7.15
/nix/store/yr0r4v8cj6m2886ngvar282r2npmpndk-shared-mime-info-1.10

Success on x86_64-linux (full log)
Attempted: freetype, libxml2, poezio, python, shared-mime-info
Partial log (click to expand)
copying path '/nix/store/zg3b4ivqik89wdypl22aixab0z9lklfi-pinentry-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/sq5mr3wlqmma2wprga5v9dvx5xg3893r-python3.6-mpd2-0.5.5' from 'https://cache.nixos.org'...
copying path '/nix/store/1y3axwa86vmag13va2vm1ldzmxr9zxm8-gnupg-2.2.10' from 'https://cache.nixos.org'...
copying path '/nix/store/j0yahpa8f3vq0329dfi9v62m2lg045zb-python3.6-slixmpp-1.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ich6lab969fpkwv387f7fpz50g51kik7-poezio-0.12' from 'https://cache.nixos.org'...
/nix/store/g9p94w6fx4hckhalmsk3rk9anapckfwp-freetype-2.9
/nix/store/h73hfs1kkr9r8zr8rgjzivdc2ff0azdq-libxml2-2.9.8-bin
/nix/store/ich6lab969fpkwv387f7fpz50g51kik7-poezio-0.12
/nix/store/2brlr94ahy3a9mvcjy0qbqpv8zrb7b7s-python-2.7.15
/nix/store/i0pb3n5wv6di4pgvw661dk8rg390vbi0-shared-mime-info-1.10


relation "django_celery_results_taskresult" does not exist

This is caused by our forked version of django-celery-results.
Will look into it now.

The problem happens when running Task.update_state.
You can follow the discussion here: https://github.com/celery/django-celery-results/issues/7#issuecomment-305145392


VP9d - use C++ primitives (memcpy => std::copy)

@dmitryermilov : this change is entirely with operator=, we are not blocked to merge this one.


pkgs/vpp: Make it compile.

Still needs some work.

shrug builds for me, not sure what CI's problem is


Update How_to_count_tokens_with_tiktoken.ipynb to add support for the gpt-3.5-*-0613 models

Add support for gpt-3.5-*-0613 models in the num_tokens_from_messages() function

thanks! I'll make a small update on top your addition.


just a few questions and a suggestion

How can I run gitrob on a particular Github repository only
How to run gitrob against other git platforms (e.g. GitLab)
Can I remotely feed a cloned repository to gitrob ??
Answer to 3 might solve the other two if there is one.
Also, this is a suggestion, to add the support for remotely adding repository which is preset in the system storage

I too need the ability to target a specific repository owned by my organization (not an individual user)

@jarvis-parker @danquinn2121 None of these features are currently implemented but they are on the roadmap with no given priority or timeframe yet. If you would like to open feature requests for each of these in this fork they can be looked at in further detail and scoped appropriately.
Thanks!

@jarvis-parker @danquinn2121 these have been moved to the fork. mattyjones/gitrob#8 and mattyjones/gitrob#9


docs: update position documentation, types (add static, explain)

Docs ✍
While reading the position style prop documentation in Layout Props, I noticed the "Type" specified (enum('absolute', 'relative')) did not match that in the React Native implementation ("absolute" | "relative" | "static" | undefined).

In particular:

The static position prop was missing.
As a result, the documentation was out of date and incorrect.

To fix this, I've:

Fixed the enum type specified.
Updated the prop's explanation to reflect the current implementation, basing this on more or less entirely on the Yoga Layout Position documentation and its subdocuments.

Before 🐛

static position missing.
Documentation incomplete and, in a couple instances, inaccurate.

After 🦋

static position added.
Documentation updated to reflect current Yoga Layout and React Native implementations.

Please take and edit this contribution as you see fit. Hope it's of some use 🙏

Oh - just noticed this has already been updated by someone else: https://github.com/facebook/react-native-website/pull/4235
Lovely! Closing 🫡


Fixed README blinky gpio_write input

Hi! Found a probable issue and probable solution:
Previously, when a learner followed the blinky README instructions, "make flash" generated an error. The issue was that variable pin in main.c wasn't previously defined. (Maybe that was just me and this is invalid!) By making the change proposed, the main.c from README instructions aligns with Step-1-... main.c. Now my main.c builds and flashes without error. The board blinks appropriately too.
Hopefully this is net helpful!
John

@mundahl thanks!


[SPARK-8056][SQL][WIP] Design an easier way to construct schema for both Scala and Python

I've added functionality to create new StructType similar to how we add parameters to a new SparkContext.
I've updated most of the StructType class to make it so the underlying data store is based off a map of fields instead of the array used to construct it. This both enables the above functionality and clarifies some semantics of what's going on internally in terms of how the data is used and also guards against an issue previously present where one could have duplicates in the schema that would cause problems.

Merged build triggered.

Merged build started.

Test build #34335 has started for   PR 6678 at commit 22fbb6d.

Test build #34335 has finished for   PR 6678 at commit 22fbb6d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class FieldIdx(field: StructField, idx: Int)
class StructType(fieldsArr: Array[StructField]) extends DataType with Seq[StructField]

Merged build finished. Test FAILed.

@ilganeli  can we simplify this and get rid of the map? Basically just add the "add" function. The map also increases serialization size (even though you could make it transient).

I was imaging the struct type is immutable, i.e. "add" will return a new struct type that has an extra column.

@rxin I'm not super gung-ho about having the map. I figured it would be cleaner than just expanding an ArrayBuffer. If you don't like this approach I can implement the alternative.
Thank you,
Ilya Ganelin
-----Original Message-----
From: Reynold Xin [notifications<EMAIL_ADDRESS>Sent: Friday, June 05, 2015 10:42 PM Eastern Standard Time
To: apache/spark
Cc: Ganelin, Ilya
Subject: Re: [spark] [SPARK-8056][SQL][WIP] Design an easier way to construct schema for both Scala and Python (#6678)
@ilganelihttps://github.com/ilganeli can we simplify this and get rid of the map? Basically just add the "add" function. The map also increases serialization size (even though you could make it transient).
—
Reply to this email directly or view it on GitHubhttps://github.com/apache/spark/pull/6678#issuecomment-109506678.

The information contained in this e-mail is confidential and/or proprietary to Capital One and/or its affiliates and may only be used solely in performance of work or services for Capital One. The information transmitted herewith is intended only for use by the individual or entity to which it is addressed. If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.

If it is immutable, there isn't anything to expand right?

Opened a new PR here for simplicity:
https://github.com/apache/spark/pull/6686


Small notation error on the ROC curve slides

Slides: slides-evaluation-roccurves.pdf [Slide 5/16]
If I'm not mistaken, one too many parentheses are closed in the left expression.

Yes, indeed, thank you @christian-hobelsberger !


Update CSV package

Currently the CSV package is restricted to versions below 0.7.10, which makes this package incompatible with other packages which use CSV.jl.
I realise that there was a change in syntax for higher versions of CSV.jl, nonetheless I think it's worth it.
I will open a pull request and see if I can do this myself.

Hi, have you solved this issue? Can you open a pull request?
Many thanks!


Out of bounds exception

Hi Ivan,
I have been trying to intregrate your tool into my application and have reached an out of bounds exception. I was following the instructions to use it and run an error when truing to get the properties from my file with Properties p = Properties.fromFile(path);.
An example of error trace is:
"LogLevel.ERROR"     "RangeError (index): Invalid value: Not in inclusive range 0..112: -1"     "#0      List.[] (dart:core-patch/growable_array.dart:264:36)
I/flutter (11792): #1      Line._isProperty (package:properties/src/properties_parser.dart:237:46)
I/flutter (11792): #2      Line._init (package:properties/src/properties_parser.dart:137:17)
I/flutter (11792): #3      new Line (package:properties/src/properties_parser.dart:119:5)
I/flutter (11792): #4      PropertiesParser._getLines (package:properties/src/properties_parser.dart:47:20)
I/flutter (11792): #5      PropertiesParser.parse (package:properties/src/properties_parser.dart:10:14)
I/flutter (11792): #6      Properties._initFromFile (package:properties/properties.dart:107:23)
I/flutter (11792): #7      new Properties.fromFile (package:properties/properties.dart:68:5)
I/flutter (11792): #8      FileManager.loadPendingSessions.<anonymous closure> (package:able_care/services/file_manager.dart:998:39)
I/flutter (11792): <asynchronous suspension>
I/flutter (11792): "

This seems to come from the fragment:
   for (var i = 0; i < line.length; i++) {
      if (line[i] == Properties.EQUAL && line[i - 1] != Properties.BACKSLASH) {
        return true;
      }
    }

I am guessing if the first int is Properties.EQUAL with i=0, then it tries to look for position 0-1 = -1 Out of bounds.
I am not sure how I reached the case in which the first item is a = after registering a key with p.add(Constant.KeyNames.LocalPropertySID, response.toString(), true) (the constant is a string, so the key should not have been empty either.
Is there something I am missing or implementing incorrectly? Anyhow, controlling that exception could be healthy for your code as well.
 To be clear, I barely know the code, I just had to use it once and have taken it over from the original author to make an updated to null-safety.
Anyway, is it possible for you to share the properties file so we can see the input it fails on?


update readme

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.869%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
536

Relevant Lines:
610

💛  - Coveralls


S3 plugin does not work with file upload

When a file is uploaded, it is created on S3 bucket but the file is 0 bytes long and has some problem to access to the file via the URL given in Wordpress.

Configure correctly the IAM User on AWS S3 fix this issue.
Source : https://github.com/humanmade/S3-Uploads/issues/158#issuecomment-371585472


Adding Solution to codechef problem Find Remainder(.py)

Related Issue
Solved issue number: #297
Describe the changes you've made
Added Solution to codechef problem "Find Remainder"
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Language used for coding
Python
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have documented the code.
[x] New and existing unit tests pass locally with my changes.

your code should be such that it passes test cases of coding platform. Your code is giving error by running it on codechef.


[Question] Does this library support TLS? If so how can I configure and use it?

[Question] Does this library support TLS? If so how can I configure and use it?

I'm also interested in this question

+1.

+1

@3rd-Eden @mapleeit  @kevin-greene-ck We'd like to contribute TLS into this repository. Once the PR is up, can you please review it and incorporate it into a new release of the client?

+1


Add git hook for php-cs-fixer, phpunit and phpstan

https://packagist.org/packages/brainmaestro/composer-git-hooks

I can try to work on this

Thanks @wkiril


Http Client Connection Pool Error

Hi,
I have a series of Tasks that connect to multiple targets that have an hourly cronjob running them.
The multiple tasks are using the same JerseyClient instance from JerseyClientConfiguration.
After a while, I start getting javax.ws.rs.ProcessingException: java.lang.IllegalStateException: Connection pool shut down
The only way to recover is restarting the application.
This only started to occur in Dropwizard 0.8.2.
Thanks for any help!

After further investigation, it seems that InstrumentedHttpClientConnectionManager shuts down the pool for an unknown reason:
DEBUG [2015-07-11 14:12:44,652] org.apache.http.impl.conn.HttpClientConnectionOperator: Connecting to /
DEBUG [2015-07-11 14:12:44,652] org.apache.http.impl.execchain.MainClientExec: Connection discarded
DEBUG [2015-07-11 14:12:44,652] org.apache.http.impl.conn.DefaultManagedHttpClientConnection: http-outgoing-6409: Close connection
DEBUG [2015-07-11 14:12:44,652] com.codahale.metrics.httpclient.InstrumentedHttpClientConnectionManager: Connection released: [id: 6409][route: {s}->****:443][total kept alive: 0; route allocated: 7 of 1024; total allocated: 21 of 1024]
DEBUG [2015-07-11 14:12:44,653] com.codahale.metrics.httpclient.InstrumentedHttpClientConnectionManager: Connection manager is shutting down
After this point, any HttpClient call, returns an exception java.lang.IllegalStateException: Connection pool shut down
PoolingHttpClientConnectionManager shuts down on close() and finalize() method.
When does Dropwizard closes the CloseableHttpClient?
Thanks

This also affected us - we had to rollback to 0.8.1.

I tried to reproduce the issue locally and couldn't get the behavior seen. Does anyone have a gist or repo demonstrating the bug?

This probably not very helpful, but I figured I would list the places I believe close could be called:

Jetty shuts down
InstrumentedHttpClientConnectionManager gets garbage collected and finalize is triggered
DropwizardApacheConnector#close
One thread calls close on the Client

Maybe this should be true?
https://jersey.java.net/apidocs/2.19/jersey/org/glassfish/jersey/apache/connector/ApacheClientProperties.html#CONNECTION_MANAGER_SHARED

I believe you are correct (especially because the default is false):

Jersey issue on Apache HTTP client connection manager sharing
Jersey commit that adds the CONNECTION_MANAGER_SHARED

hotness

I don't think that's relevant.
The problem described in the Jersey issue is applied only for cases, when user provides own connection manager that's shared between clients. We don't provide such ability,
because we create a new connection manager every time user creates a new instance through JerseyClientBuilder. Moreover, the current fix leaks InstrumentedHttpClientConnectionManager, which will be closed only during a major GC, a highly unpredictable event. It's really easy to end up with a couple of hundred open TCP connections to a remote server.
I think, we should revert connection manager sharing or at least disable it by default.

Okay, I've reverted. Do you have any idea what's causing the issue?

I would go with reviewing the changes in Jersey between 2.17 and 2.19, if the issue is reproduced only in 0.8.2. But I have a gut feeling that the issue is connected to the finalizer in some way.

@arteam We faced the same issue with dropwizard 0.8.2.
I noticed, that finalizer was added into ClientRuntime of Jersey 2.18. https://github.com/jersey/jersey/blob/4eece8eeb3947becdf91188a63412b5011eae2b5/core-client/src/main/java/org/glassfish/jersey/client/ClientRuntime.java#L297 which close() the connector.
Then, underlying apache client 4.4.1 http://grepcode.com/file/repo1.maven.org/maven2/org.apache.httpcomponents/httpclient/4.4.1/org/apache/http/impl/client/HttpClientBuilder.java#1184 close() the connection manager, cause it's not shared by default.
So, the patch provided by @carlo-rtr seems valid to me. What do you think, guys?


Audio streaming training with masking

By utilizing a mask, we can simulate audio streaming.

@farzadab Hi,
I created a test file for ultravox_model, moved the function, and changed var names.
I look forward to further improvements.

@farzadab, I utilized 'just test', and 'just format', and corrected mentioned issues.

@farzadab solved.


Renamed Azure::Nullable<T>::GetValue() to Value().

This rename makes Nullable<T> consistent with other Core types like Operation<T> and the C++ Optional<T>
https://en.cppreference.com/w/cpp/utility/optional/value
https://github.com/Azure/azure-sdk-for-cpp/blob/a7fdea42e65435c354e64c862f8490e410aef0e2/sdk/core/azure-core/inc/azure/core/operation.hpp#L82

@RickWinter, @antkmsft any feedback or review on https://github.com/Azure/azure-sdk-for-cpp/pull/2034 before I merge it?

I prefer Get...() and Create...() but I guess our SDK is no longer uniform about that, and we don't have a guideline for that, and I'd prefer if we had one; But as of this change, I am fine with it, given that there's no such naming guideline.

Value is idiomatic to STL in C++.  This change was about standardizing on Value.  If there are placing that aren't standardized we need to fix them.


Fix Chinese Language Compatibility of Weblate translation

Make the language code of the Weblate translation compatible with 3D Slicer.
For more specific info you could refer to #34

Thanks for reporting the issue. Indeed Weblate and Qt uses different locale names, which caused incorrectly named translation files. Instead of hardcoding specific language codes as implemented this pull request, we get the language code from the file - see https://github.com/Slicer/SlicerLanguagePacks/commit/aa360be21016a8c1d6aa0c847648589f04cf6a7b


arch: x86: set output format/arch per arch

Instead of doing this per platform, set the output format and arch on
architecture level.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b3d165f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #9187   +/-   ##
=========================================
  Coverage          ?   52.72%
=========================================
  Files             ?      201
  Lines             ?    25277
  Branches          ?     5279
=========================================
  Hits              ?    13328
  Misses            ?     9823
  Partials          ?     2126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d165f...5809f84. Read the comment docs.


Command "Terminal: Clear" and Ctrl+Left make cursur jump to bottom

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.74.0-insider
OS Version: Windows_NT x64 10.0.19044

Steps to Reproduce:

Click menu item "Terminal > New Terminal".
Run echo foo.
Hold Enter to fill the terminal view.
Run command Terminal: Clear from the command palette.
Press up-arrow key to fill the current line with the command echo foo again. Don't run it.
Press Ctrl+left-arrow key. The cursor jumps to the last line in the terminal view, which is empty, even though we were in the first line.
(Hitting Enter runs the command and fills the whole terminal view again.)

I can reproduce this, but to me it looks like this is bc we're still processing the enters that were pressed before the typing occurred

/duplicate https://github.com/microsoft/vscode/issues/75141


Fix command line Schematron to resolve URI with catalog

This pull request derives from #324. So needs to be handled after that.

XSpec CLI fails to resolve Schematron URI with catalog.
The root cause of the problem is that URI is resolved as string manipulation.
This pull request fixes it by throwing URI to catalog.

4d39175964e21ecb3e026a882648691feb5e465a reproduces the problem. (Travis, AppVeyor)
2b5ebaca5e506f78d78e53566f4252bc788cdb72 fixes the problem.

Although this pull request contains a lot of commits for historical reasons, all that needs to be reviewed in the end is a pair of commits mentioned in the initial comment:

4d39175964e21ecb3e026a882648691feb5e465a reproduces the problem. (Travis, AppVeyor)
2b5ebaca5e506f78d78e53566f4252bc788cdb72 fixes the problem.

@cirulls
Merged this bug fix.


Fix test-only Http2Frame: host -> :authority.

Signed-off-by: Dianna Hu<EMAIL_ADDRESS>
Commit Message: Fix test-only Http2Frame to send the ":authority" pseudoheader instead of "host" for requests.
Additional Description: This change enables tests using Http2Frame to comply with the "SHOULD" suggestion of the HTTP/2 specification: https://httpwg.org/specs/rfc7540.html#HttpRequest.
Risk Level: Low
Testing: //test/integration:http2_flood_integration_test //test/integration:h2_capture_fuzz_test //test/integration:h2_capture_persistent_fuzz_test //test/integration:h2_capture_direct_response_fuzz_test //test/integration:h2_capture_direct_response_persistent_fuzz_test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign-from @envoyproxy/maintainers

/assign-from @envoyproxy/envoy-maintainers


Create a Destination for an External API (Slack)

The step 4 is not working, error message returned:
"404: Not Found"

Hi,
You can ignore this error. When creating destinations for APIs, we only use the API stub (not the full URL) so that you can use 1 destination for multiple methods. Otherwise, we would need a destination for all methods we wanted to use. As long as a stub has the same authentication method for all methods, this is the best practice.
Thank you!
Meredith


Sort tokenlist

Need to be able to sort tokenlist for FE (swaps dialog) so well known tokens are at the top and not random unknowns. Currently tokens are alphabetically ordered.
Ideas:

order by tvl
order by volume
manual ordering by "priority"

Tvl might be easiest

Ordering by market cap, this data is readily available


Proposal: Normalize AST of control flow statements such as if/else for improved analysis

This is related to issues such as https://github.com/etsy/phan/issues/224
and would help to get rid of the redundant statements (if (!is_string($a)) {return} assert(is_string($a)); ) in codebases using phan (such as phan itself)
This may interfere with dead code detection.
Currently, phan is unable to handle infer the type of $foo (string) in the remaining statements for this form:
{
  if (!is_string($foo)) {
    return; // Or continue, or break, or throw, or multiple branches, all resulting in unreachability
    /* General case: going past the end of the conditional block is unreachable */
  }
  /*  REMAINING_STATEMENTS; */
  function_accepting_string($foo);  // This may emit an error
}

It is also unable to analyze things such as (deliberate) variable assignments in if statements, or conjunctions
if ($cond && ($foo = bar()) && $foo instanceof string) {
  // Phan emits error for $foo being an undeclared variable}

The following normalizations are proposed ($var is a normal variable, A and B and C are expressions, X and Y and Zare statement lists.)
Line numbers of AST nodes should not change, new AST nodes should be created without modifying the input AST (using line numbers of nearby nodes)
The would be applied repeatedly on an AST node until no longer possible (Then recursing into new child nodes)
// Applied whether or not there is an else.
if ($var = A) {X} -> $var = A; if ($var){B}
// Do this, unless there is a else statement that can be executed
if (A && B) {X} -> if (A) { if (B) { X }}
// The below rule also applies when B_ALWAYS_RETURNS performs a break/continue in a for/while loop.
if (!A} {Y_ALWAYS_RETURNS} C_REMAINING -> if (A) {X_REMAINING} Y_ALWAYS_RETURNS
// If one of the branches never returns, both can go into the other branch in the normalized form
// (Other forms of this exist)
if (!A} {Y_ALWAYS_RETURNS} else {Z} X_REMAINING -> if (A) {Z; X_REMAINING} else {Y_ALWAYS_RETURNS }
if (!A) {X} else {Y} -> if(A) {Y} else { X }

As a further optimization, this would only need to be done if this contained expressions that were meaningful for the phan analyzer (`$var instanceof ClassName, is_string(), or variable assignments), as a child ast node somewhere.
Less useful rules from formal logic:
if (!(A || B)) {X} -> if (!A && !B) {X}
if (!!A)) {X} -> if (A) {X}

After applying these rules (if (!A} {Y_ALWAYS_RETURNS} C_REMAINING -> if (A) {X_REMAINING} Y_ALWAYS_RETURNS), the original example becomes (something phan is currently able to analyze):
{
  if (is_string($foo)) {
      /*  REMAINING_STATEMENTS; */
      function_accepting_string($foo);  // This will no longer emit an error
  }  else {
     return; // Or continue, or break, or throw, or multiple branches, all resulting in unreachability
     /* General case: going past the end of the conditional block is unreachable */
  }
}

I implemented a proof of concept at https://github.com/TysonAndre/phan/pull/5 with most of those rewriting rules - The existing unit tests pass, and phan is able to analyze the phan codebase.
I still plan to test this more.
The proof of concept contains a fix for https://github.com/etsy/phan/issues/407 and https://github.com/etsy/phan/issues/224
(https://github.com/TysonAndre/php-ast-simplification is a standalone project to run this step, and view the old/new AST for single php files or snippets)

This is a really interesting idea.
One big win would come from our current special case for conditional instanceof checks turning into casts:
if ($v instanceof DateTime) {
    // $v is now of type DateTime
}

The check is very dumb and doesn't handle any additional logic like if (true || $v instanceof DateTime) { ... }. The proposed patch would resolve that problem.

@TysonAndre Merging your patch in would be great. Let me know if there's anything I can do to help.


Integrate HHVM support

HTTP/2 is fast, HHVM instead of FastCGI is even faster. It would be nice to have a config/template to use HHVM.
Here are example configs for Apache/Nginx: https://github.com/facebook/hhvm/wiki/FastCGI

:+1:

So if I understand the docs you linked to, it's essentially the same as proxying to php-fpm? What would need to be done for then Caddy to work with HHVM if it does not already?
fastcgi / <IP_ADDRESS>:9000 php

@mholt i think he is requesting a manner to embed hhvm directly in the caddy process, like mod_php. else i have no idea what he meant

Maybe hhvm can be embedded into caddy via gobindata to make deployment easier and expose it via a cgo binding?

As I am restricted on time, I have yet to dig through caddy's source code for a proper integration suggestions.
As of now, there are parameters such as gzip that can be placed in the caddyfile to enable support: https://caddyserver.com/docs/caddyfile
It would be interesting if HHVM could be activated on a site with param hhvm, much like param gzip in the caddy file. FastCGI is recommended for compatibility and would be default. hhvm param would invoke HHVM instead of FastCGI for PHP handling (and HHVM works with Hack language, which brings more devs to the project).
As for the link I posted (https://github.com/facebook/hhvm/wiki/FastCGI), as you are using FastCGI now, it should be simple to setup HHVM in proxy mode (localhost:9000).
An auto config script is located here for HHVM (https://github.com/hhvm/packaging/blob/master/hhvm/deb/skeleton/usr/share/hhvm/install_fastcgi.sh) which can give you further idea as to integration.
I wish I could be more help as to the specifics of the caddy project.

I find HHVM's speed compelling. Thanks for the resources @zorrobyte - they'll surely be helpful!
As for me personally, I do not have time to devote to this right now either, but HHVM seems like a technology that Caddy would do well to support in the long run, assuming PHP keeps being popular. Anyone is welcome to tackle this - just comment here.

Hi,
I have some questions regarding adding HHVM.  It looks like it is largely written in C++, so how would we include it with Caddy and still have Caddy be cross platform for all the currently supported operating systems?  Are you suggesting to to gather binaries of HHVM and include it with each version of Caddy?  The other option is to have the user compile it them self.  How were you imagining shipping it with Caddy?
Not saying this is a bad idea just trying to figure out how it would allow Caddy to be cross platform.... Or do we end up leaving out support for any OS that can't compile HHVM?

We would need to use a pure Go library to build HHVM into Caddy for exactly that reason; I was under the impression there was some other way to bind to an external HHVM process - but it does appear that FastCGI can do that already.

My two cents,
HHVM is a “nice to have” as in it works very well for most things but fails at certain other things, see http://hhvm.com/frameworks/ http://hhvm.com/frameworks/ . You are right, it isn’t cross platform and adds complexity however, I did mention it for Caddy as it can go far as to help popularize your platform as many others do not currently offer HHVM/Hack integration. I suppose it could come down to a caddy including HHVM as a module, as in a setup script that would be ran to compile and integrate HHVM into caddy. This way HHVM stays an optional, doesn’t clutter core code but is easily added to caddy with minimal setup, keeping it simple per the caddy philosophy.
Anywho, that’s just my high level suggestion. I’m an Advanced Beginner at best :)

On May 7, 2015, at 9:44 AM, Joshua Loper<EMAIL_ADDRESS>wrote:
Hi,
I have some questions regarding adding HHVM. It looks like it is largely written in C++, so how would we include it with Caddy and still have Caddy be cross platform for all the currently supported operating systems? Are you suggesting to to gather binaries of HHVM and include it with each version of Caddy? The other option is to have the user compile it them self. How were you imagining shipping it with Caddy?
Not saying this is a bad idea just trying to figure out how it would allow Caddy to be cross platform.... Or do we end up leaving out support for any OS that can't compile HHVM?
—
Reply to this email directly or view it on GitHub https://github.com/mholt/caddy/issues/12#issuecomment-99871113.

I am a power user of HHVM and I think that fastcgi support should be enough. The protocol is well tested and works. HHVM wasn't built with embedding in mind. Furthermore HHVM also has a builtin web server called Proxygen.
and to @zorrobyte HHVM may fail for the frameworks but I have been using HHVM in production for more than a year and never had a problem with it. It may not be cross-platform at the moment but during the last few months, they have announced an official Homebrew tap and a heavily-under-development windows build. Here's a graph I saw today, I think you should have a look at it too :) https://www.facebook.com/groups/hhvm.general/permalink/539355092884555/

Closing this issue since it doesn't seem to be going anywhere, bug discussion is still welcome on it for any interested.

There is actually no discussion. HHVM is accessible via FastCGI.


Plans to support react 18

Hello, do you have plans to support react 18?
its working crazy with react 18 - example here https://codesandbox.io/s/context-selector-forked-st5bps

It supports React 18.
The behavioral change is expected and it's not an issue. It's what I call extra-render-with-no-commits behavior.
FYI: https://twitter.com/dai_shi/status/1534170089981100032

thanks for your help :)


Add ids for dynamic fields

Purpose
This PR makes sure all dynamic fields in the html doc are provided to properly present the offer DTO. This allows to easily load dynamic content into the html template.
Changes
The ids are named in a manner to provide consistent naming conventions (separation with a hyphen). Finally, the item table contains now thead and tbody to allow dynamic adding of table rows for items.

 Add HTML template fields for all dynamic properties

 Add HTML template fields for all dynamic properties


Duplicated snapshots and os error 2 when running both integration and unit tests

What happened?
When running insta, I get duplicated snapshot reviews, as well as a crash at the end of the snapshot reviewing. In the original (non-minimal) case, I wasn't able to review some of my tests.
I should have reviewed two snapshots, but only was able to review one. The error was the dreaded "No such file or directory (os error 2)".
Reproduction steps

Create a new directory (not using cargo new --lib)
Create a Cargo.toml
Put this in your Cargo.toml:

[package]
name = "testing2"
version = "0.1.0"

[[test]]
name = "integration"
path = "tests/tests.rs"

[dev-dependencies]
insta = { workspace = true }

[workspace]
members = ["testing"]

[workspace.dependencies]
insta = "1.31"

Run cargo new testing --lib in the project root
Put this in testing/src/lib.rs

#[test]
fn it_works() {
    insta::assert_snapshot!("stuff...");
}

Create the tests/ directory in the project root
Create tests/tests.rs
Put this in tests/tests.rs

#[test]
fn works() {
    insta::assert_snapshot!("hr");
}

Run cargo insta test --review --all

Insta Version
1.31.0
rustc Version
1.71.0
What did you expect?
I expected to review two tests, and have no crash.

I'm also struggling with this issue... I need to run things without --workspace, one-at-a-time, just to get insta to work!

Same here, which makes cargo insta barely usable in a larger workspace.

I've added some better error messages on missing files, currently only on master.
Could folks try that and see what that reports?
(I'm not familiar with insta not working on larger workspaces; we use it very successfully in PRQL. Is the distinction that nested crates have problems?)

[patch.crates-io]
insta = { git = "https://github.com/mitsuhiko/insta.git", branch = "master" }

@max-sixty no difference, still only getting this:

error: No such file or directory (os error 2)

cargo insta test --release --accept --workspace

     Running tests/snapshots.rs (target/release/deps/snapshots-eee0592393c0f811)

running 3 tests
test <SNIP> ... ok
stored new snapshot <SNIP>.snap.new
stored new snapshot <SNIP>.snap.new
test <SNIP> ... ok
test <SNIP> ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.28s

     Running unittests src/lib.rs (target/release/deps/snapshots-08c69356ac69b7db)

running 15 tests
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok
test <SNIP> ... ok

test result: ok. 15 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

...

error: No such file or directory (os error 2)

The workspace consists of a root bin package and 9 member lib crates, two of which contain the snapshot tests.
Running cargo insta test --release --accept on each of the crates individually works just fine.
Curiously running the cargo insta command with --workspace even failed when only one crate had snapshot tests.

still only getting this:

error: No such file or directory (os error 2)

Would you mind trying cargo install --git https://github.com/mitsuhiko/insta --bin=cargo-insta to ensure it's also running the latest cargo-insta?
(There may be an error source which doesn't offer more info. But I at least more info to some sources, including ones that look like this)

The workspace consists of a root bin package and 9 member lib crates, two of which contain the snapshot tests.

Thanks — I guess this is because of the root / nested package. I'm guessing if turn the root package off then it works OK (to the extent that's possible to test)?

still only getting this:

error: No such file or directory (os error 2)

Would you mind trying cargo install --git https://github.com/mitsuhiko/insta --bin=cargo-insta to ensure it's also running the latest cargo-insta?
(There may be an error source which doesn't offer more info. But I at least more info to some sources, including ones that look like this)

Now it does indeed provide a more useful error message:

error: File error for "/tests/snapshots/snapshots__.snap.new": No such file or directory (os error 2)

I deleted the contents of the tests/snapshots directory of one of the crates to trigger the error and looking at the contents of the directory the file above is the only one with .snap, while all other still are .snap.new, in case that's helpful.

The workspace consists of a root bin package and 9 member lib crates, two of which contain the snapshot tests.

Thanks — I guess this is because of the root / nested package. I'm guessing if turn the root package off then it works OK (to the extent that's possible to test)?

Commenting out [package] & Co in the root Cargo.toml did indeed make the error vanish!

OK nice, that's some progress.
I had a look through the code — I can't see exactly what's going on. I think two main possibilities:

Two tests — one in the root package and one in a nested package — are named the same, and the snapshot has been removed by the time we get to the second
Some variant of insta attempting to collect the tests twice

Could we try renaming the test that references "/tests/snapshots/snapshots__.snap.new" to something really unique and seeing whether the error still triggers?
Also if anyone has a minimally reproducible example — probably requires a link to a repo — that would be v useful...

Also if anyone has a minimally reproducible example — probably requires a link to a repo — that would be v useful...

This is all you need: Workspace with root package and single snapshot test in member crate. 💣💥

Create root cargo project:
cargo new "insta-bug-repro"
cd "insta-bug-repro"

Change contents of root Cargo.toml file to this:
# Cargo.toml

[workspace]
members = [
    "crates/member-crate",
]

[workspace.dependencies]
insta = "1.39.0"

[package]
name = "insta-bug-repro"
version = "0.1.0"
edition = "2021"

[dependencies]
insta = { workspace = true }

[patch.crates-io]
insta = { git = "https://github.com/mitsuhiko/insta.git", branch = "master" }

Create member crate cargo project:
mkdir "crates"
cd "crates"
cargo new "member-crate"

Change contents of member crate Cargo.toml file to this:
# crates/member-crate/Cargo.toml

[package]
name = "member-crate"
version = "0.0.0"
edition = "2021"

[dependencies]
insta = { workspace = true }

Add snapshot test to root package (doesn't matter if you add it to main.rs or to tests/test.rs)
// src/main.rs

fn main() {
    println!("Hello, world!");
}

#[cfg(test)]
mod tests {
    #[test]
    fn another_test() {
        insta::assert_debug_snapshot!(vec![1, 2, 3]);
    }
}

Run tests via cargo insta
cargo insta test --workspace --accept

   Compiling member-crate v0.0.0 (<SNIP>/insta-bug-repro/crates/member-crate)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.40s
     Running unittests src/main.rs (<SNIP>/insta-bug-repro/target/debug/deps/insta_bug_repro-74dd16e027693651)

running 1 test
stored new snapshot <SNIP>/insta-bug-repro/src/snapshots/insta_bug_repro__tests__test2.snap.new
test tests::test2 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.13s

     Running unittests src/lib.rs (<SNIP>/insta-bug-repro/target/debug/deps/member_crate-2eb078fdc829f709)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests member_crate

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

insta review finished
accepted:
  src/main.rs (test2.snap)

Everything fine so far. 👍🏻

Add snapshot test to member crate package (doesn't matter if you add it to lib.rs or to tests/test.rs)
// crates/member-crate/src/lib.rs

#[cfg(test)]
mod tests {
    #[test]
    fn test() {
        insta::assert_debug_snapshot!(vec![1, 2, 3]);
    }
}

Run tests via cargo insta
cargo insta test --workspace --accept

    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.03s
     Running unittests src/main.rs (<SNIP>/insta-bug-repro/target/debug/deps/insta_bug_repro-74dd16e027693651)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (<SNIP>/insta-bug-repro/target/debug/deps/member_crate-2eb078fdc829f709)

running 1 test
stored new snapshot <SNIP>/insta-bug-repro/crates/member-crate/src/snapshots/member_crate__tests__test.snap.new
test tests::test ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.13s

     Running tests/insta.rs (<SNIP>/insta-bug-repro/target/debug/deps/insta-e229e15f5cea934d)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests member_crate

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

error: File error for "<SNIP>/insta-bug-repro/crates/member-crate/src/snapshots/member_crate__tests__test.snap.new": No such file or directory (os error 2)

👎🏻

Disable root package:
[workspace]
members = [
    "crates/member-crate",
]

[workspace.dependencies]
insta = "1.39.0"

# [package]
# name = "insta-bug-repro"
# version = "0.1.0"
# edition = "2021"

# [dependencies]
# insta = { workspace = true }

[patch.crates-io]
insta = { git = "https://github.com/mitsuhiko/insta.git", branch = "master" }

Run tests via cargo insta

cargo insta test --workspace --accept

```plain
Compiling member-crate v0.0.0 (<SNIP>/insta-bug-repro/crates/member-crate)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.65s
    Running unittests src/lib.rs (<SNIP>/insta-bug-repro/target/debug/deps/member_crate-2eb078fdc829f709)

running 1 test
stored new snapshot <SNIP>/insta-bug-repro/crates/member-crate/src/snapshots/member_crate__tests__test.snap.new
test tests::test ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s

Doc-tests member_crate

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

insta review finished
accepted:
crates/member-crate/src/lib.rs (test.snap)
```

Everything fine again. 👍🏻

As evident from the stdout/stderr output above the issue doesn't seem to be related to name collisions among workspace crates, since even adding a single test to a single member crate triggers the error. The error however only gets triggered if the workspace also has a root package (that doesn't need to actively be using insta though).

@regexident thanks for the full example!
I obv fully believe it happens. Weirdly I can't repro locally — I'm guessing it's something about the order in which the crates run. I haven't tried your exact example — would you be able to push it as a git repo? Otherwise I can copy & paste the files.

Here is a repository: insta-bug-repro.zip
I've added a commit (with explanatory messages) for each of the steps described above and added ✅/❌ for the expected outcome of running cargo insta test --workspace --accept on the given commit's checkout.
Make sure to delete the snapshot directory in between runs.

I'm running the following in case it helps:
macOS Sonoma 14.6 Beta (23G5075b)

cargo 1.79.0 (ffa9cf99a 2024-06-03)
rustc 1.79.0 (129f3b996 2024-06-10)

cargo-insta 1.39.0

Thank you! I can repro with cargo insta test --workspace --accept;  git clean -fd on 7fd61fb nicely. I'll have a look in the next day or two.
(+ ref https://github.com/mitsuhiko/insta/issues/388, I think likely related)

Great @regexident , if you get a moment, would you mind testing whether #531 works? Otherwise we can presume it does; it solves your (excellent!) MCVE
cargo install --git=https://github.com/max-sixty/insta/ --branch=396

@max-sixty Just gave it a few test runs and got no errors. Awesome!
Thanks for looking into the issue! 🙏

Fixed by #532


Add option to disable minify in bundler

Yes, there was a conflict with the previous patch I made, because the same line was changed, I've rebased on the current main branch now.


Manual traffic lights should not be available on middle nodes

Middle node on straight road should not be selectable for setup Pedestrian Traffic Lights
Click on TM:PE Icon -> Manual Traffic Lights -> Select a middle node at a straight road.
Symbols shown, but no Traffic lights and as far as i see there should be no Symbols as without using the Node Controller this Pedestrian Traffic Light is not working. As soon as you click somewhere else the 'setup' disapears.

As this is not creating anything the symbols are only irritating
Info 0.0013097: TM:PE enabled. Version 11.4.0, Build <IP_ADDRESS>71 DEBUG for game version 1.13.0-f8

This kind of issue exists with most tools; we need some consistent way to know which tools are applicable for any given node/segment.
Maybe something like:
Dictionary<nodeId, NodeFlags> NodeInfo;
Dictionary<segmentId, SegmentFlags> SegmentInfo;

We could have flags such as Valid (created + not deleted|collapsed) and Visible (in camera view) in there too.

It's worth noting that IIRC manual traffic lights feature may not be as strict as TTL when it comes to which nodes are allowed (you cannot save it and everything disappears when you close/change tool so it's not a big issue) - I would remove that feature completely or make it debug only.

The only reason manual TL exists is because the TTL UI/UX is so bad.
IMO:

We should be able to allow TL on any node (changing node type if required, eg. whatever Node Controller mod does)

Same sort of thing with ped crossings IMO

All TLs should be editable TTL (assuming we can kick TTL UI/UX in to something fun)
Toggle TL should create basic (vanilla-ish) TTL script
Quick-setup shortcut should create better TTL script, add turning lanes, etc.


Invariant Endo instance, bump contravariant upper version bounds

This adds an Invariant Endo instance, which would be useful for me.
Also, I needed to bump the upper version bounds for contravariant, since the latest version (<IP_ADDRESS>) is much larger.

Thanks for emailing me about this; I missed this original notification in my inbox.


[Question] Best way to upscale video using TRTIS?

Hi! Sorry if this kind of question isn't belonging here or it was asked before. I assume here are a lot of experts with knowledge of NVIDIA ecosystem.
My question is:
Is there any convenient and efficient way to pipe video frames to a TRTIS instance and after encode new video using output of an frame upscale model? Essentialy, what I'm looking for is a solution that uses combination of existing tools for upscale video using my frame-based model and not required any glue code for this.
Thanks!

@vBLFTePebWNi6c you might want to check https://developer.nvidia.com/deepstream-sdk Currently it does not use TRTIS but supports inference using TRT runtime and can run on edge device such as Jetson or server. Is there any particular reason you want to use TRTIS?

@prasshantg thanks for your suggestion! I'd prefer to use TRTIS because of it's ability to efficient managing of multiple GPU usage, plus high-level API and easy deployment process. I look recently at DeepStream SDK. As I understood, it requires writing a plugin for on C++ any model, which will be far more cumbersome than using TRTIS.

@vBLFTePebWNi6c from your problem description it seems like you'd still need to do some integration yourself. For that, I'd recommend looking into GStreamer (DeepStream is, as I can see, a collection of plugins for it). With it, you will be able to use a lot of existing plugins for loading the video, decoding, encoding, outputting it to a screen, or transporting it via a network. The only thing you would need to add it seems is the upscaling step.

@aleksa2808, the problem is that upscale operation is computation-heavy, thats why I want to use TRTIS -- for upscale multiple frames in parallel on many GPUs. It works as intended, but it'd be great if there would be a solution which will substitute my inefficent python code of deconding frames, sending them to TRTIS and encode new video.
Nevertheless, I get the point -- GStreamer + DeepStream is the best solution for my problem.

@vBLFTePebWNi6c if you want to fully utilize your available GPUs, you can use the TRTIS client to asynchronously send decoded frames to the server on one thread, and then in a different thread process / encode the received frames. You can find an example of making asynchronous requests in the python client here.
I hope this resolves your problem, but if not, perhaps a better place to ask these kind of questions would be on Stack Overflow.


[WIP] Fix: mistyping github in micro run prepends github.com/micro/services…

[DO NOT MERGE THIS}
… to source
Previous behaviour (note it's "gihub" and not "giThub"):
$ micro run gihub.com/micro/examples/blog/posts@tagsavefix
service at 'https://github.com/micro/services/tree/tagsavefix/gihub.com/micro/examples/blog/posts' not found

Current behav:
$ micro run gihub.com/micro/examples/blog/posts@tagsavefix
Get https://gihub.com/micro/examples/tree/tagsavefix/blog/posts: dial tcp <IP_ADDRESS>:443: connect: connection refused

I'm going to leave this here and stop work on it for the time being as it's becoming a whack-a-mole

Closing, reopen when ready


get_test

### Please add more and better examples @jonataslaw

Hi @samsheldin.
See an example in the get_test package repository: https://github.com/jonataslaw/get_test
I am closing this issue, as it refers to another repository.


Core: input validation highlight isn't working

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[x] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request

I'm not sure of how we want to do this with core/angular. I'd prefer if we didn't have Angular specific styles in core, so either we add the styles to our angular package or we add our own Ionic classes for validation based on the Angular controls (my preference).
Here are the current styles:

// Input highlight mixin for focus, valid, and invalid states
@mixin ios-input-highlight($highlight-color) {
  border-bottom-color: $highlight-color;
}

// Show the focus highlight when the input has focus
@if ($input-ios-show-focus-highlight) {
  // In order to get a 2px border we need to add an inset
  // box-shadow 1px (this is to avoid the div resizing)

  .item-ios.item-input.item-input-has-focus .item-inner {
    @include ios-input-highlight($input-ios-highlight-color);
  }

  // The last item in a list has a border on the item, not the
  // inner item, so add it to the item itself
  .list-ios .item-input.item-input-has-focus:last-child {
    @include ios-input-highlight($input-ios-highlight-color);

    .item-inner {
      box-shadow: none;
    }
  }
}

// Show the valid highlight when it has the .ng-valid class and a value
@if ($input-ios-show-valid-highlight) {
  .item-ios.item-input.ng-valid.item-input-has-value:not(.item-input-has-focus) .item-inner {
    @include ios-input-highlight($input-ios-highlight-color-valid);
  }

  .list-ios .item-input.ng-valid.item-input-has-value:not(.item-input-has-focus):last-child {
    @include ios-input-highlight($input-ios-highlight-color-valid);

    .item-inner {
      box-shadow: none;
    }
  }
}

// Show the invalid highlight when it has the invalid class and has been touched
@if ($input-ios-show-invalid-highlight) {
  .item-ios.item-input.ng-invalid.ng-touched:not(.item-input-has-focus) .item-inner {
    @include ios-input-highlight($input-ios-highlight-color-invalid);
  }

  .list-ios .item-input.ng-invalid.ng-touched:not(.item-input-has-focus):last-child {
    @include ios-input-highlight($input-ios-highlight-color-invalid);

    .item-inner {
      box-shadow: none;
    }
  }
}

Also, we might want to have the angular classes passed down to the native input.

And here's how we did it in v3:

function setControlCss(element: Ion, control: NgControl) {
  if (!control) {
    return;
  }
  element.setElementClass('ng-untouched', control.untouched);
  element.setElementClass('ng-touched', control.touched);
  element.setElementClass('ng-pristine', control.pristine);
  element.setElementClass('ng-dirty', control.dirty);
  element.setElementClass('ng-valid', control.valid);
  element.setElementClass('ng-invalid', !control.valid);
}

Modified the control value accessors to set the following classes conditionally based on the associated ng-* classes:

ion-invalid
ion-valid
ion-touched
ion-untouched
ion-dirty
ion-pristine

https://github.com/ionic-team/ionic/compare/core-item-border-refactor?expand=1

Any news on this issue? We are developing an app that makes heavy use of angular reactive forms. We wonder if ionic form components will support by default input validation highlighting for angulr forms or we will have to implement our own styling for "ng-*" classes.
We are working with beta.7 and have verified that validation is working correctly and "ng-" and "ion-" classes are being applied to the ion-input element. But the red outline doesn't show up in invalid inputs.

@brandyscarney This issue needs to be reopened.
The border color doesn't change when the form is invalid.

Create a reactive form with a validator like maxLength:

    this.profileForm = this.formBuilder.group({
      name: ['', [Validators.required, Validators.maxLength(3)]],
    });

Create a form and add the reactive text field:

  <form [formGroup]="profileForm" novalidate padding>
    <ion-item-group>

      <ion-item>
        <ion-label>Name:</ion-label>
        <ion-input formControlName="name"></ion-input>
      </ion-item>

      <ion-item>
        <ion-button [disabled]="profileForm.invalid">SAVE FORM</ion-button>
      </ion-item>

    </ion-item-group>

{{profileForm.value | json}}

{{profileForm.status}}

  </form>

When the forms get invalid the line color below the field didn't change.

@MrSparklle Could you create a new issue for this? I would like to keep this issue specific to adding it to the @ionic/core package (the bare CSS needed to add highlighting) and then have a separate issue for any issues with the Angular integration (the class being added to the wrong place). Thank you! 🙂

No problem Brandy. Issue opened: https://github.com/ionic-team/ionic/issues/16052


10 add test data

Coverage remained the same at 100.0% when pulling 1013ab22a1f46ff6b156e5caa93e108e22f2e6b3 on 10-add-test-data into 0d7560fbbf7362d831f811018f42a341e2587e1d on master.


harfbuzz: add flag to correctly install CMake files

Description of changes
Similar to how we already set -DKDE_INSTALL_CMAKEPACKAGEDIR in CMake
builds, Harfbuzz now uses -Dcmakepackagedir to correctly handle both
Nixpkgs split outputs and relocatable installations.
See https://github.com/harfbuzz/harfbuzz/pull/4370.
Note: this doesn't do anything yet, the upstream PR isn't even merged yet. Just putting this here already for the release when the flag actually does something so it doesn't get forgotten.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Upstream PR's been merged, I assume this will be needed with the next version (after 8.2.1).

Included in #243918.


[OSX] prevent osx from inserting View and Help menu options.

What does the pull request do?
Stops OSX from inserting menu items that are not applicable to avalonia apps.
What is the current behavior?
if user has a native menu item headered "View" or "Help"
OSX adds items like "Show Tabbed View" and "Enter FullScreen Mode" and "Search".
What is the updated/expected behavior with this PR?


Line Number Padding

As a program user
I want the side of the field displaying my line number to not change in size when it goes from 9 to 10 lines, 99 to 100 lines, etc.
So that it is less awkward when I cross those thresholds.
Request Description
Implement the text area where the line numbers appear being 3 or 4 characters wide by default. Also, right-justify the text within it so that the least-significant digital always lines up with the divide between the line numbers and the text editor region. Perhaps force a monospace font?

Closed by #39


Use sentence case for Finder format name

Policy Area and Policy Programme should be sentence case. This commit fixes that.

Lovely; thank you. :cake:


(feat): Automatic id creation

I'm submitting a...
[x] Feature request

Current behavior
As of now users have to manage ids on their own.
Expected behavior
Opt in or configurable automatic id creation. (or opt-out and configurable but this would introduce a breaking change)
What is the motivation / use case for changing the behavior?
This would make the framework even more easy to use if you're not using custom IDs.
Todo

[ ] API design ideas
[ ] Reopen #35 as it would make sense with automatic id creation.

Closing this issue. I have added the guid() method to simplify the id creation. You can now do the following:
import { guid } from '@datorama/akita';

export function createPerson(name: string): Person {
  return {
    id: guid(),
    name,
    guests: 0,
    attending: false
  };
}


only copy stream data to write when popping a STREAM frame

Fixes #1675.
stream.Write can be called with arbitrarily large slices of data. We should avoid copying all that data up front since this can take a long time. Instead, we can copy the data that is dequeued when a STREAM frame is popped.

Codecov Report

Merging #1676 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
+ Coverage   86.99%   86.99%   +<.01%
==========================================
  Files          97       97
  Lines        6281     6282       +1
==========================================
+ Hits         5464     5465       +1
  Misses        581      581
  Partials      236      236

Impacted Files
Coverage Δ

send_stream.go
89.56% <100%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9baf9...466825e. Read the comment docs.


Subgroup loading

Changing the loading behavior as demanded in #85.
Please note that currently the paragraph is collapsed by default.

Don't forget to answer to every of my review remark, at minimum with a "fixed".
I think you haven't addressed "isCollapsed could probably be collapsed for consistency with collapsible, visible and other components.
"


SDN-5086: Add API and feature gates for OVN-K BGP support

Add API & feature gate to control the deployment of components that
provide additional routing capabilities. MetalLB operator and OVN-K
route advertisements feature will rely on this API.
Add API & feature gate to enable OVN-K route advertisements.
ref: https://github.com/openshift/enhancements/pull/1636/files

/hold
While I would like relevant feedback, this may still not be set on its final form.
The option proposed with two flags is clean but it may appear evident that the extra flag is just there to hook into the MetalLB operator workflow, or from the other perspective, to allow MetalLB operator to hook into the CNO workflow. The guist is that both ovn-kubernetes BGP and MetalLB operator would need the same stuff deployed and we don't want to have it duplicated in the cluster.
Other options:

Single flag and MetalLB operator users will have to tolerate an ovn-kubernetes rollout that they didn't have before. Users may consider the temporary control plane downtime a breaking change.
Single flag and ovn-kubernetes will have the functionality enabled always (listening for CRD events) even if not planned to be used. Seems like waste of resources and not the best alignment with our 36 month lifecycle plans either.
Single flag and a some other sort of CNO hidden API (unpublished config map) for MetalLB operator to leverage. Not great not terrible.
Single flag and MetalLB operator deploys its own FRR-k8s deployment if the flag is not set, or uses the CNO FRR-k8s deployment if flag is set. Complex.

@JoelSpeed PTAL

/hold cancel

/retest

This last update goes for AdditionalRoutingCapabilities for the top most attribute & feature gate name.
Also splits RouteAdvertisements attribute to a separate feature gate, since there is a chance they both graduate at different times.
@JoelSpeed PTAL

My continuing niggle with this API is that we are telling users to enable a capability, that is in fact, a project name, and not a technical feature.
What is it exactly that FRR is providing to the end user, and is it possible we could name the capability after the end user visible functionality, rather than this project?

I guess this is the way to see it in the current proposal:
We are providing additional routing capabilities through different providers; what those specific capabilities are and how they are configured depend on the provider type (a provider does not necessarily represent a unique specific capability, one provider can provide many capabilities; and specific capabilities are not exclusive to one provider): at this time we are not offering any configuration to enable/disable specific capabilities through this API, the user (or other components) will need to deal directly with the provider's API; and just selecting a provider in this API will not make any functional change in the cluster other than deploying whatever is necessary for the provider.
The only provider available right now will be FRR-k8s which aims to provide all FRR capabilities.
I guess we could have taken a completely different route, which is add an API to enable specific features, completely abstracting the user for the fact that we are using FRR-k8s, FRR or whatever. That has its pros but also cons, specifically:

Makes user life easier but takes choice out from him
Forces us to replicate/abstract, and keep up with, the FRR-K8s API in our own API, which is something we are not ready to do

@JoelSpeed I dont really see a valid argument that we should not allow values for a specific technology or project. Let's take newtorkType in the API for example:
https://github.com/openshift/api/blob/84047ef4a2ce54dc7f879b1382690079081128f1/config/v1/types_network.go#L58
A user could provide values as OpenShiftSDN or OVNKubernetes. These are both 2 different projects/technologies.
You can think of FRR as its own networking stack that has a bunch of features like @jcaamano mentioned. Just like if you use OVNKubernetes you get a lot of features that OpenShiftSDN doesn't have. OVNKubernetes is limited in its overall feature set, and for advanced networking use cases we need the features in FRR. The two technologies will complement each other.

@JoelSpeed PTAL

/override ci/prow/verify-crd-schema

/retest-required