Changes to cards

Signed-off-by: AnshumanDhiman<EMAIL_ADDRESS>Description
This PR fixes #291
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

Merge conflicts...


When changing an access list entry, automatically reload NGINX for changes to take effect.

Is your feature request related to a problem? Please describe.
Changing an access list does not seem to reload nginx/openresty, so you have to either manually do it, or make a change in the proxy host through the NPM GUI to kickstart the reload.
Describe the solution you'd like
When an access list is changed, automatically reload NGINX so that the ACL change becomes effective.
Describe alternatives you've considered
N/A
Additional context
N/A

I think this is still needed. Please keep open.


Missing dependency on documentation

You should tell users that libsixel1 is a dependency.

What is the difference between libsixel and libsixel1 ?

You're right. I think I have some apt src issues. Therefore I see two packages as libsixel1 and libsixel. When libsixel is installed, the tool won't work. Not sure what's the difference between them. Thanks anyways. I'm closing it since it's not a generic thing. It's me with a messy apt.


Add ListOptions to GetCommit and CompareCommits to support pagination

Thanks, @Saaarah.
Please make sure to run unit tests before submitting PRs.
You will need to modify the unit tests since the API has changed with this PR.
Please check out surrounding tests to see how pagination is also tested. Thanks.

Hi Glenn, thanks for reviewing my merge request and I've added the new parameters in the two API's unit tests. Thanks again!

Hi @Saaarah - it looks like there are some calls to these APIs in the examples, if you could please take a look and fix them.
Here is the error:
Run go vet ./...
# github.com/google/go-github/v37/example/commitpr
vet: example/commitpr/main.go:128:97: too few arguments in call to client.Repositories.GetCommit
Error: Process completed with exit code 2.

Hi @Saaarah - it looks like there are some calls to these APIs in the examples, if you could please take a look and fix them.
Here is the error:
Run go vet ./...
# github.com/google/go-github/v37/example/commitpr
vet: example/commitpr/main.go:128:97: too few arguments in call to client.Repositories.GetCommit
Error: Process completed with exit code 2.

Hi Glenn, I've fixed the example. Sorry for not updating all affected code, it'll be nice to have a small section in readme.md to ask contributors to run all necessary tests prior to creating pull request, which will be really helpful for first timer contributors.

it'll be nice to have a small section in readme.md to ask contributors to run all necessary tests prior to creating pull request, which will be really helpful for first timer contributors.

This is already covered in our CONTRIBUTING.md doc:
  5. Please run:
     * `go generate github.com/google/go-github/...`
     * `go test github.com/google/go-github/...`
     * `go vet github.com/google/go-github/...`

It now looks like gofmt needs to be run on the example code:
Run diff -u <(echo -n) <(gofmt -d -s .)
--- /dev/fd/63	2021-07-12 15:58:15.735418376 +0000
+++ /dev/fd/62	2021-07-12 15:58:15.735418376 +0000
@@ -0,0 +1,12 @@
+diff -u example/commitpr/main.go.orig example/commitpr/main.go
+--- example/commitpr/main.go.orig	2021-07-12 15:58:16.035434090 +0000
++++ example/commitpr/main.go	2021-07-12 15:58:16.035434090 +0000
+@@ -127,7 +127,7 @@
+ 	// Get the parent commit to attach the commit to.
+ 	opt := &github.ListOptions{
+ 		PerPage: 10,
+-		Page: 1,
++		Page:    1,
+ 	}
+ 	parent, _, err := client.Repositories.GetCommit(ctx, *sourceOwner, *sourceRepo, *ref.Object.SHA, opt)
+ 	if err != nil {
Error: Process completed with exit code 1.

it'll be nice to have a small section in readme.md to ask contributors to run all necessary tests prior to creating pull request, which will be really helpful for first timer contributors.

This is already covered in our CONTRIBUTING.md doc:
  5. Please run:
     * `go generate github.com/google/go-github/...`
     * `go test github.com/google/go-github/...`
     * `go vet github.com/google/go-github/...`

Ah thanks for pointing out! I've formatted the file and run all the commands listed above. Thanks Glenn!


Reducing limitations

When comparing with Fiji result, test 10-129-C_2 accumulates around 10 pixels of shift over the montage. But it looks very close to it, even at the bottom.
The last tile in a row doesn't get a correct registration, possibly due to some blur along the overlapping edge.

Please add a readme to the S200 and 10-129-C (HiPercomp) data sets stating that there were publicly released by U.S. Air Force Public Affairs office under PA number:
88ABW-2103-0127

@imikejackson are MNML 3 and 5 also released? If yes, is it the same PA number?

Will add PA numbers in another PR.

Release numbers added in #93


Add flag to inspect command to set private key file name

Right now inspect (without key argument) will always use --priv_key.bin as filename, and can't be changed.,

As it turns out, the flag is there (-k works) but it needs to be set on the base command (i.e. mycelium) and not after the inspect command so mycelium -k <key_file> inspect. Need to see if clap could generate some doc for that


SpecBindGeneratorPlugin.SpecFlow requires SpecFlow 1.9, but SpecBind uses 2.0

I noticed that SpecBind got updated to use SpecFlow v2.0, but a new SpecBindGeneratorPlugin.SpecFlow plugin was never pushed out that also uses SpecFlow 2.0 (it still uses 1.9). So if you try updating NuGet references for SpecBind, SpecBindGeneratorPlugin.SpecFlow, and SpecFlow, you get the following error:

Yeah, somehow that got updated before I wanted to push out. I'm building 1.7.0 right now and that should have all the updates.

Cool, thanks!

OK 1.7.0 is released, that should work now.


Make a graph from an adjacency matrix with negative elements

Information

retworkx version:0.9.0
Python version:3.9.6
Operating system:macOS Big Sur 11.4

What is the current behavior?
When I tried to make a graph from an adjacency matrix with negative matrix elements, I noticed that edges corresponding to the negative elements are neglected.
When the adjacency matrix is as follows,
adjacency_matrix = np.array([
    [1.0, -1.0, 2.0],
    [0.0, 1.0, 1.0],
    [0.0, 0.0, 1.0]
])

then the list of weighted edges,
graph = retworkx.PyGraph.from_adjacency_matrix(adjacency_matrix)
list(graph.weighted_edge_list())

outputs,
[(0, 0, 1.0), (0, 2, 2.0), (1, 1, 1.0), (1, 2, 1.0), (2, 2, 1.0)]

It means that there is no edge between node 0 and 1.
On the other hand, if the adjacency matrix is
adjacency_matrix = np.array([
    [1.0, 1.0, 2.0],
    [0.0, 1.0, 1.0],
    [0.0, 0.0, 1.0]
])

graph = retworkx.PyGraph.from_adjacency_matrix(adjacency_matrix)
list(graph.weighted_edge_list())

then the list of weighted edges is like this:
[(0, 0, 1.0), (0, 1, 1.0), (0, 2, 2.0), (1, 1, 1.0), (1, 2, 1.0), (2, 2, 1.0)]

What is the expected behavior?
Is the above behavior is a bug or intended?
If it is a bug, I expect that negative elements of a given adjacency matrix are not neglected.
For example, for the adjacency matrix
adjacency_matrix = np.array([
    [1.0, -1.0, 2.0],
    [0.0, 1.0, 1.0],
    [0.0, 0.0, 1.0]
])

I want the following list of weighted edges:
[(0, 0, 1.0), (0, 1, -1.0), (0, 2, 2.0), (1, 1, 1.0), (1, 2, 1.0), (2, 2, 1.0)]

Furthermore, it would be more convenient if we can create a graph from an adjacency matrix with complex matrix elements as follows.
adjacency_matrix = np.array([
    [1.0, 1.0+1.0j, 2.0+2.0j],
    [0.0, 2.0, 3.0+3.0j],
    [0.0, 0.0, 3.0]
])
graph = retworkx.PyGraph.from_adjacency_matrix(adjacency_matrix)
list(graph.weighted_edge_list())

[(0, 0, 1.0), (0, 1, 1.0+1.0j), (0, 2, 2.0+2.0), (1, 1, 2.0), (1, 2, 3.0+3.0j), (2, 2, 3.0)]

Steps to reproduce the problem
adjacency_matrix = np.array([
    [1.0, -1.0, 2.0],
    [0.0, 1.0, 1.0],
    [0.0, 0.0, 1.0]
])
graph = retworkx.PyGraph.from_adjacency_matrix(adjacency_matrix)
list(graph.weighted_edge_list())

I expect this is an oversight and can be fixed by changing this line: https://github.com/Qiskit/retworkx/blob/main/src/graph.rs#L1405 to be != 0. That should still work as expected but handle negative weights. It might also be worth adding a kwarg at the same time to adjust the null value so it can be inf or nan instead of zero.
As for the complex element array that's a bit trickier, the method is statically typed as it uses numpy's c api to read the array and we are prevented from using generics by pyo3 when building the interface to python (it needs to know the type to build the interface function). The best we could probably do is add a second method like from_complex_adjacency_matrix or something. Would that work for your use case?


Feature: directory collector

As I cannot add anything into original PR #108, I'm openning this PR as a follow up. #

merged: https://github.com/sensiolabs-de/deptrac/pull/147


Control Center crashed on Windows.

logs.txt

fixed wrong delations of fingerprints which caused this crash

Didn't face this error on Win10 for a long time.

Fixed in Master.

While we don't face this problem


remove secrets

closes #1863

According to the 1es wiki: "the best way to fix this is to change the fake secret to include the literal string "Placeholder" (case-insensitive)."
https://www.1eswiki.com/wiki/If_Your_Push_Was_Blocked_By_Credential_Scanning#It.27s_a_placeholder_or_example_credential

According to the 1es wiki: "the best way to fix this is to change the fake secret to include the literal string "Placeholder" (case-insensitive)."
https://www.1eswiki.com/wiki/If_Your_Push_Was_Blocked_By_Credential_Scanning#It.27s_a_placeholder_or_example_credential

Can you try pulling this pr branch in to a PR for your repo and run the gate on it to see if the 1ES guidance works here? There's also a chance it runs the scan on git history which would require more work.


Add a method allowing canonical strings to be returned from DataInput

Use a shared buffer for decoding short strings

I don't know what this string interning is here, but I am strongly opposed to it

This PR does not use String.intern which was the previous concern.  So what's wrong here?

It does essentially the same thing. Leaking memory on purpose into static finals.

The map isn't static.
Even if there was a static map, if it was expressly used for known static strings, then it wouldn't be a leak but just re-use of constants.

it absolutely is.  You won't sneak this one past me.
-1 to this interning stuff. I remember what things were like when we made this mistake before and had to fix it.

both are an issue.
The threadlocal will leak badly, especially for cases that "churn" lots of threads (e.g. jetty defaults, e.g. java webapps). It will cause more harm than good.
the private map just leaks for the caller by unnecessarily saving strings. it's a lot of overhead to datainput to add this map. keep in mind datainput isn't closeable and has other implementations such as ByteArrayDataInput.
Sorry, I don't see advantages to this stuff.

The ThreadLocal aspect was a needless addition here; it could be reverted.

the private map just leaks for the caller by unnecessarily saving strings. it's a lot of overhead to datainput to add this map. keep in mind datainput isn't closeable and has other implementations such as ByteArrayDataInput.

Let's imagine a small improvement to the patch to lazily create the map on first use.  Some usages of ByteArrayDataInput and perhaps others would never use it (e.g. SynonymGraphFilter).  Are there cases you see that would lead to undesirable use of these canonical strings?  That it's not closable doesn't seem to be an issue to me since DataInput should not be outliving the things it was used to read; quite the reverse, no?

I am currently reviewing the impact of these changes on performance, GC, and memory usage to lucene & elasticsearch. If this does show an improvement, I'll set this PR to ready to review. If not, I'll close it.

For reference, this is aimed at #11711 and #11712

This is ready to review. I've removed the threadlocal byte buffer.
With testing in elasticsearch, this reduced the duplicated strings in these fields by 90%. For the linked tickets this would reduce the memory usage from these strings from 6GB to 600MB. There is no significant performance difference I can see from running this in lucenebench.
In the cases where the new method is not called, this would just add an empty HashMap instance to each DataInput instance, with the same lifetime as the container.
When getCanonicalString is called, this added a single hashmap lookup to the call compared to getString. It also requires memory for the backing HashMap, with the same lifecycle as the container, scaling with the number of distinct strings returned by that method.
So this causes slightly more memory when deserializing, at the benefit of using drastically less memory once it is all deserialized and the data input & hashmap have been GCd.

Another option is to have the FieldInfosFormat classes handle string pooling themselves, leaving DataInput unchanged.

There is somewhat a matter of taste at stake, so I can appreciate Robert's point of view that DataInput is nice the way it is without adding this to it for an edge (abuse?) case.  I've seen Lucene based indexes used in a variety of ways so I'm sympathetic for finding a path forward.  If this optimization can be isolated to a small place in FieldInfosFormat and also fix the problem (?), will that address your concern Robert?  Maybe we need to see what it'd look like first.

I think if you get yourself in this situation via oversharding/dynamic fields/etc, then you can add -XX:+UseStringDeduplication to your commandline, problem solved.

-XX:+UseStringDeduplication to your commandline, problem solved.

This is actually a very elegant workaround... I wonder what the benchmarks would show on those affected systems.

Unfortunately that doesn't seem to have much of an effect - same number after a GC, with the option turned on or off

Unfortunately that doesn't seem to have much of an impact, from what I can see here.
@rmuir Would you be against having a string cache specifically in the relevant methods in FieldInfosFormat?

yes because it would translate as a leak for many other use-cases/applications.

To be clear, are you referring to the extra memory used by the deduplication hashmap for the duration of the deserialisation, that will then be eligible for GC after the method returns?

I've changed it to use a separate object for the string map, scoped to the deserialisation method.
I couldn't come up with a nice way to handle readMapOfStrings to cache the key strings so far, it's much harder to do that once the map is actually created.

It looks like there are strong objections to sharing string instances here, and there is a JVM command-line flag that may achieve similar gains for many indices X segments X fields sort of use case?


Retrying logic can prevent an overloaded service from recovering

It seems like the current behavior of the retry logic (introduced in #84) is to almost immediately retry the RPC upon receiving a deadline exceeded error:
https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/rpc/ApiResultRetryAlgorithm.java#L44
A very common reason for a service to return a deadline exceeded error is when it's overloaded. Sending more RPCs will bog it down further and prevent it from recovering. I think it would be better to remove the special handling and use the standard exponential back off to allow the service to recover.

@pongad @garrettjonesgoogle WDYT?

How immediate is this concern? gRPC has an approved proposal for server-configured retry-timeout. At least in the long term, I think our strategy should be to let gRPC deal with it.

Is this P2 or P1?

(Assigning P2 for triage, but feel free to bump it if @pongad and others concur.)


render_views does not work in rspec-rails 2.7 / Rails 3.1 as advertised

rspec-rails 2.7.0
Following the directions here: https://www.relishapp.com/rspec/rspec-rails/docs/controller-specs/render-views
Test code:
describe MapsController do
  render_views

  describe "Map search" do
    it "should return results" do
      get :search, :address => "123 Main St, 92109", :distance => 5, :format => :js
      response.should render_template('search')   # works OK
      response.body.should == 'whatever'   # response.body always ""
    end

Bottom line, even with render_views, response.body is always ""

The scenarios on https://www.relishapp.com/rspec/rspec-rails/docs/controller-specs/render-views all pass against Rails 3.1, so I'm unable to reproduce this in a stock Rails app. Maybe there's some gem or setting you have that's creating a conflict. Would you post your Gemfile?

I'm having the same issue as well, and have created a repository to demonstrate it: https://github.com/LockeCole117/render_views


Redshift plugin

Description

Add new plugin to connect to AWS Redshift cluster and run query.
Add unit test cases.

Fixes appsmithorg/appsmith #1267
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Tested the driver by connecting it to an instance of Redshift cluster running on cloud. All build TC passed using AWS redshift cred.
Created mock test cases since testcontainer support is not availabe. All mock TCs passed.
Tested with UI:
a. Test datasource with valid credentials

b. Test datasource with invalid credentials

c. Select query

d. Get structure

e. Delete query

f. Insert query

g. Create query

f. New logo

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@sumitsum : For important logs that we do want to see, could we use System.out.println instead of log.error?


cupy.cutensor.reduction returns wrong value for max(-a) operation

cupy.cutensor.reduction returns wrong value for max(-a) operation.
reproduction code:
import cupy
from cupy import cutensor
from cupy.cuda import cutensor as cuda_cutensor

n = 4
a = cupy.arange(n * n, dtype='f').reshape(n, n)
c = cupy.zeros((n), dtype='f')

desc_a = cutensor.create_tensor_descriptor(a, cuda_cutensor.OP_NEG)
desc_c = cutensor.create_tensor_descriptor(c)

c = cutensor.reduction(
    1.0, a, desc_a, ('x', 'y'),
    1.0, c, desc_c, ('x',),
    reduce_op=cuda_cutensor.OP_MAX)

print(c)  # Expected: [ -0.  -4.  -8. -12.]

output:
[1.1754944e-38 1.1754944e-38 1.1754944e-38 1.1754944e-38]

Sorry for being late to respond, but this problem has been fixed in cuTENSOR 1.2.  Could you check with cuTENSOR 1.2?
Output (cuTENSOR 1.1):
[1.1754944e-38 1.1754944e-38 1.1754944e-38 1.1754944e-38]

Output (cuTENSOR 1.2):
[  0.  -4.  -8. -12.]

I confirmed the problem has been fixed. Thanks!


Change Ports

coap.nordicsemi.academy:5688 (unencrypted) -> 5683
coap.nordicsemi.academy:5689 (dTLS with pre-shared key: connect:anything) -> 5684

Hi @coderbyheart request you to please review https://github.com/NordicPlayground/nordic-developer-academy-coap/pull/4

@coderbyheart Thank you so very much for your guidance and patience , i am happy to share that i ended up learning couple of things from this contribution. Thanks again !


Class with complex properties

I am new to FluentLiquid so I'm not sure if what I am doing should work or not. I'm trying to use a class with nested class properties. The example below is contrived to make my question easier to understand.
Here are the C# classes.
public class AccountStatusModel
{
        public string FirstName { get; set; }
        public string LastName { get; set; }
        public IEnumerable<string> InvoiceNumbers { get; set; }
        public ContactInformation ContactInfo { get; set; }
        public IEnumerable<Payment> InvoicePayments { get; set; }
}

public class ContactInformation
{
    public string Email { get; set; }
    public string PhoneNumber { get; set; }
}

public class Payment
{
    public DateTime PaymentDate { get; set; }
    public decimal PaymentAmount { get; set; }
}

And here is the email template. The simple properties for FirstName and LastName display correctly. So do the IEnumerable<string> values. However, the ContactInfo properties are blank and so are the InvoicePayments object properties. For the  IEnumerable<Payment>, the loop does show a list item for each of the Payment items (simple bullet in this case) but the list item does not have the data for the Payment property values. That is, if the IEnumerable<Payment> has four items, I get four bullets but no text next to the bullets.

    First Name: {{FirstName}}

    Last Name:  {{LastName}}

Contact Information

    Email: {{ContactInfo.Email}}

    Phone: {{ContactInfo.PhoneNumber}}

Here are your invoices and the payments that have been made towards them

Invoices

        {% for invoice in InvoiceNumbers %}

{{invoice}}

        {% endfor %}

Payments

        {% for p in InvoicePayments %}

{{p.PaymentDate}} - {{p.PaymentAmount}}

        {% endfor %}

My primary question is whether this package can handle the nested objects or not. If it can do that, what am I doing wrong with the template?

Did you "Include" the related properties in your query?
_context.AccountStatus
.Include(x => x.ContactInformation)
.Include(x => x.Payment)
.FirstOrDefault();

https://docs.microsoft.com/en-us/ef/core/querying/related-data/


Nodes try to self connect when given predefined config

Hi there and thanks for sharing this project. I'm keen to introduce Raft into one of my projects in which there is a predefined cluster. During boot I'm getting the follower error on 2 of the three nodes:
panic: raft.membership: attempted to send msg to local member; should never happen

Here is the relevant code
func raftInit() {
	raftgrpc.Register(
		raftgrpc.WithDialOptions(grpc.WithInsecure()),
	)
	fsm = newstateMachine()
	node = raft.NewNode(fsm, transport.GRPC)
	raftServer = grpc.NewServer()
	raftgrpc.RegisterHandler(raftServer, node.Handler())

	m1 := raft.RawMember{ID: 1, Address: "host1:8081"}
	m2 := raft.RawMember{ID: 2, Address: "host2:8081"}
	m3 := raft.RawMember{ID: 3, Address: "host3:8081"}

	go func() {
		lis, err := net.Listen("tcp", ":8081")
		if err != nil {
			log.Fatal(err)
		}

		err = raftServer.Serve(lis)
		if err != nil {
			log.Fatal(err)
		}
	}()

  go func() {
	err := node.Start(raft.WithInitCluster(), raft.WithMembers(m1, m2, m3) )
                 if err != nil {
			log.Fatal(err)
		}
	}()
}

Not sure if this is misconfigured on my side or if there's an issue here. Would greatly appreciate you assistance.

@alexanderturner Unable to reproduce the issue from the given code, do you use the same WithMembers configuration with all hosts?
Docs:
WithMembers add the given members to the raft node.

WithMembers safe to be used with initiate cluster kind options, ("WithForceNewCluster", "WithRestore", "WithInitCluster") Otherwise, it may conflicts with other options like WithJoin.

As long as only one url member, WithMembers will only set the current node, then it will be safe to be composed with other options even "WithJoin".

WithMembers and WithInitCluster must be applied to all cluster nodes when they are composed, Otherwise, the quorum will be lost and the cluster become unavailable.

Node A:
n.Start(WithInitCluster(), WithMembers(<node A>, <node B>))

Node B:
n.Start(WithInitCluster(), WithMembers(<node B>, <node A>))
Note: the first member will be assigned to the current node.


Discussion

Hi, I'm interested in this project.
Could we connect? Hope to hear from you asap.
Best Regards!

I'd reach out to the upstream project.
https://github.com/onedr0p/cluster-template


[WIP] Fix using variable error for nested foreach parallel

PR Summary
This fixes a bug in ForEach-Object -Parallel where a using variable in a nested ForEach-Object -Parallel throws an error even when the variable is defined in the correct scope (Issue #11817).
PR Context
This error was occurring because, when ForEach-Object -Parallel was assembling the user variable map, it was searching all nested scriptblocks within the ForEach scriptblock, with the result of finding nested using variables where the variable had not yet been defined.  Since the nested scriptblock using variable had not been defined in the current scope, a mapping error was thrown.
Fix is to change the using variable map function to not search nested scriptblocks in the ForEach -Parallel case.  This way foreach -parallel using variable mapping is always performed only for the current scope.
Many thanks to @mklement0  for pointing out the fix.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[x] Issue filed: 5436

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@PaulHigin would this fix also affect the use of nested iterations of Start-ThreadJob and similar $using: variable usage there?

@vexx32  No, ThreadJob will also need to change.  Please create an issue for it.

Just double checked it, and looks like Start-ThreadJob doesn't exhibit the same issue, interestingly enough. 🎉

Will this be added to RC3?

@PrzemyslawKlys I don't think so, as the RC3 is already locked down and we have a very high bar for GA. But this fix will be included in a servicing release later.

What is the status of this PR?

AFAIK there is no reason not to take this PR.  @daxian-dbw can we include this in the next preview release?

AFAIK there is no reason not to take this PR.  @daxian-dbw can we include this in the next preview release?

@PaulHigin Please rebase to pass CIs.

@PaulHigin Please rebase to pass CIs.

Closing this PR since it is so old, and created a new one (#14548)

Closing this PR since it is so old, and created a new one (#14548)


[docs] Update Jbang instructions

Removed "Required Java 8" from the Jbang instructions as this not really necessary given the fact Jbang can install Java when needed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks! 😄


Bug: KeyError 'countries'

What are you trying to achieve?
Call shippingZoneUpdate mutation with default: true input.
Steps to reproduce the problem

Call a mutation for some existing shipping zone and pass default: true in the input:

mutation {
  shippingZoneUpdate(id: "U2hpcHBpbmdab25lOjY3", input:{ default: true }) {
    errors {
      code
      field
      message
    }
    shippingZone {
      id
    }
  }
}

What did you expect to happen?
Error should be handled.
Logs
https://saleor.sentry.io/share/issue/24f38163cb244629a06367a230416631/
Environment
Saleor version: 3.11.17

Reported in: https://saleorcommerce.slack.com/archives/C038XPD8HLK/p1679413591787469

Shall I work on this bug? @maarcingebala  . If yes , Please assign this to me


Should null String field values be allowed in multipart POST requests?

Not sure if this is a bug, a behavior that should be flexibilized, or one that should be enforced (or just kept that way).
TL;DR: Setting up a multipart POST request won't allow field(String name, String value) calls to receive a null String value as it used to in older versions (I'm updating client code dependencies and don't want to break the existing server-side code).
It throws NullPointerException instead since, although the BodyPart class constructor looks like it accepts null values (no this.value = Objects.requireNonNull(value); is enforced, for example), it actually throws an exception when invoking this.partType = value.getClass(); right below in the constructor.
I'm no HTTP connoisseur but I don't think a non-null String field value should be a requirement for multipart requests (or, in the case it is, it seems like it is being only incidentally enforced). In my opinion a null String value could simply be translated to an empty string when the actual request is made.
It seems that it is only needed in order to return the value object's Class<?> instance in getPartType(), which in the case of a null value in my opinion could be the actual T class parameter from BodyPart<T> (I haven't thought out how that would translate to actual code, though). Also, I haven't cloned the repo to look for further consequences of implementing such flexibilization.
To Reproduce
import kong.unirest.Unirest;

public class Teste4
{
    public static void main(String [] args)
    {
        Unirest.post("http://www.example.com")
                .field("first", "something") // Alternatively, replace this line with .multiPartContent()
                .field("second", (String)null)
                .asJson();
    }
}

Resulting stack trace:
Exception in thread "main" java.lang.NullPointerException
	at kong.unirest.BodyPart.<init>(BodyPart.java:40)
	at kong.unirest.ParamPart.<init>(ParamPart.java:37)
	at kong.unirest.ParamPart.<init>(ParamPart.java:33)
	at kong.unirest.HttpRequestMultiPart.field(HttpRequestMultiPart.java:48)
	at Teste4.main(Teste4.java:9)

Expected behavior
In my thinking, the request object should be constructed normally instead of throwing a NullPointerException.
Environmental Data

Java Version: jdk-<IP_ADDRESS>-hotspot (AdoptOpenJDK, but the behavior is not tied to a specific Java version or release)
Version: unirest-java-3.11.10-standalone.jar (or more recent)

Oh. A type erasure issue.
Not easy to retrieve the runtime type of T. I guess this is why getPartType() was needed in the first place.
Okay then, I think the issue can be closed.


[1.7.10] NEI not displaying the upper left hot bar in the Inventory window.

So, recently I've been playing newer mod packs and I've been wanting to get back to an older version of Minecraft with some cool mods that are no longer around (like Thaumcraft). So I dusted off the The Ferret Business pack, it's kind of a mess but Caigan assures me it'll be updated soon. So I dusted off FTB Infinity, created a world with Cheats enabled, and threw it into Expert mode but no matter what I do, global overwrite or not global overwrite (W highlighted and not highlighted) on the hot bar, game mode, and cheat / recipe mode button the hot bar on the top left doesn't show up when I open my Inventory screen. It's the same with Ferret Business (existing world has Cheats enabled) and, for giggles, I installed FTB Crackpack for 1.7.10 (and made a Cheats enabled world) and all of the 1.7.10 packs I've poked at has this issue. I seem to remember there being a hot bar in the top left where I can toggle Creative / Adventure, Survival, etc, turn on and off the rain, etc. O.o

Update, just for those who are curious, in the NEI config file "Cheatmode=2" is set and "Lockmode=-1" is too so... It aught to be showing. O.o

no way! i think i finally found the problem by you...

my cheatmode was also set to 2 and my lockmode was also set to -1

Yeah, I'm having that same problem right now. I don't know how to fix it


Update Get-PnPDeletedUnifiedGroup.md

Docs Build status updates of commit 82276bb:
:clock10: Pending: waiting for processors (21 builds ahead of you)
:warning: Docs Build is busy, currently there are 21 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 82276bb:
:clock10: Full build: the average full build time is 17 min(s) 54 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 82276bb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPDeletedUnifiedGroup.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@rarajase   PnP cmdlet documentation changes should be done here:
https://github.com/pnp/PnP-PowerShell/pulls in the dev branch.
Essentially, the documentation for PnP cmdlets is directly reflected from cmdlet's source code, later, a process is run to create the documentation. (so your changes would be later replaced)
Sorry but this PR needs to be closed because of that.


Use against RS256

Can this library be used against RS256 encoded tokens and how?

Set RS256 as the algorithm and the public key as the secret.
$app = new Slim\App;

$app->add(new Tuupola\Middleware\JwtAuthentication([
    "secret" => $publickey
    "algorithm" => ["RS256"]
]));

You can find example of how to generate the token in firebase/php-jwt README. This middleware uses firebase/php-jwt for decoding the token.


Fix dog-fetcher panic and Redis provider deadlock

Feature or Problem
This PR fixes a panic in the dog-fetcher component and a deadlock in the kv-redis provider
Related Issues

Release Information
next dog-fetcher
keyvalue-redis-provider 0.28.2
Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Yep @vados-cosmonic, updating the dog fetcher to<EMAIL_ADDRESS>was the fix


DBAAS-738: Importing AWS RDS Provider Account failed

Changed the specsynced condition for UI
Check if the AWS service account can be used to read the db instances from AWS before using the credentials to run the RDS controller
Make the inventory ready when it is still importing the db instances

@xieshenzh can you clarify what you meant here and why it should be done this way: "Make the inventory ready when it is still importing the db instances"?

@xieshenzh can you clarify what you meant here and why it should be done this way: "Make the inventory ready when it is still importing the db instances"?

Because the db instances that are being imported are not ready for binding. They will appear as not available in the inventory status. In this case, make the inventory to be ready while it is still loading the db instances, so that the UI can stop waiting.

How would this impact the users? It seems confusing if the inventory is ready but the instance is still being imported.

I don't think there would be any impact. The UI is not expecting any intermediate state from the Inventory, the specsynced condition should either be ready or not set. DB instances being loaded is a kind of intermediate state.
I think the users would be happy to see the Inventory is ready even if some instances are not ready.

specsynced can also be false if the provider operator runs into error during inventory discovery.

specsynced can also be false if the provider operator runs into error during inventory discovery and the UX would then display the error. I just wanted to make sure this won't impact the UX. @yzhao583 could you confirm?

It will set the condition to false if there is error, but it will set the condition to true when importing database is in progress and error is not happening..

@yzhao583 @xieshenzh did we work out if there's more change required for this or if we're in agreement on what's being performed? I can't tell by the last comments if the current approach to set SpecSynced==true prior to being finished is a good or bad thing.

@xieshenzh @jeremyary If inventory is ready, but instance not ready, maybe we can set SpecSynced to True, but there is no db instance in the response? In this case, UI shows a empty state, not error state.


Display scripts in evo rpc output in a more generic way

Basically, display the actual data and do it in a way we already do for raw txes etc. e.g.
      "scriptPayout": {
        "asm": "0288325491ab8b60b7a3d4719f48a0d106d4c3f5b06924002f06167eca0f2e9065 OP_CHECKSIG",
        "hex": "210288325491ab8b60b7a3d4719f48a0d106d4c3f5b06924002f06167eca0f2e9065ac",
        "reqSigs": 1,
        "type": "pubkey",
        "addresses": [
          "yU5Wq6uxUKJmcZc8ABgXhBZCEmp4sZMRpL"
        ]
      }

This should also help with displaying data later when we decide to allow non-p2pkh scripts in protx-es.

On another thought, we'd still have to modify rpc commands themselves first anyway for non-p2pkh scripts to even be allowed to be submitted, so this can be postponed till later versions. Closing.


define business process for adding new centres/centre-id

use case:

WCMP2 validation of topic hierarchy will need to check the centre_id before it's approved by WMO

ideas:

add status column to topic hierarchy CSVs
branch and PR workflows

TT-WISMD 2023-02-15:

discuss with @efucile @golfvert on formality of approval process/options/governance (pull request?  National PR approval?  Something else?)

center_id

Anna, while the decision is still fresh, we go for centre-id, can you change your text? Just to avoid confusion on what is what !

TT-WISMD 2023-04-12:

once we get into FT workflow, we need to consider a fulsome list so that centres are not blocked from producing data
can we add a status column to the centre-id (active, planned, etc.)
need historical centre-id's for centres who stop providing data (for delayed mode/climate applications)
FT workflow: delay in approval
monitoring can help here to trigger centre-id publication for corrective action

gets added at next FT

security implications?

centre-id needs to be approved by PR
being approved / registered is a pre-cursor to data publication
need trigger/notification to TT-WISMD to add centre-ids

@kurt-hectic FYI, we will be adding centre-ids to the TH

Decision
This is part of the WIS2 node registration and the centre-id will be kept in the WIS2 registry.

20231013_Adding_NC_WIS2.pdf
20231013_Adding_WIS2_Node.pdf
This will need some tweaking, but the overall process is agreed as described here.

We still need to address how/when the centre-id is added to the topic-hierarchy.
Centre-ids...

are requested by the center
approved by WMO
managed in the WIS2 Registry

I think these are the options available for implementation in the WTH
a. centre-id is added to the WTH in GitHub immediately and a new minor version of the WTH is released soon after
b. centre-id in TH is approved through fast-track approval ~2x/year
c. WIS2 Registry updates the WTH as needed/on a schedule, new minor version of WTH is released on a schedule

I'd go for a. and I don't think the concept of minor version of the WTH exists and we don't need it either.
So "a. centre-id is added to the WTH in GitHub immediately" and done.

So "a. centre-id is added to the WTH in GitHub immediately" and done.

This change then needs to propagate schemas.wmo.int as well as possibly elsewhere, for those doing WTH validation.  Which means even with a, we will need to apply minor version update somehow and communicate.

Related: https://github.com/wmo-im/wis2-guide/issues/51

"for those doing WTH validation". Not necessarily. The GB when subscribing to a new centre-id will be the mere fact of that subscription check that the centre-id is known and correct. So checking the TH by the GB, up to that level at least doesn't require any publication.
And, I am not sure that we will need strict TH validation elsewhere.

TT-WISMD 2023-12-01:

WTH stable branches are as per FT approval
if there is an update to WTH that involves an addition of a centre-id, a new version of WTH tables/bundle are published immediately with the new centre-id to stable branch

PR in #78


Add Contributors Section in readme

I want to add a contributors section in the readme to showcase all the valuable contributors of this repository.
@prathimacode-hub Do assign me this issue under DCP'21.
Thank You.

Contributors section is already added. Also while creating issue or PR follow the templates given. @payaldutta


Add background image for when there are no tabs open

Fixes #1508
Specific changes

Add background image in the dialog explorer
Fix dialog-bg color in dark theme

Testing

@DesignPolice & @mewa1024 can you take a look at this and give a sign-off when you get a chance?
I noticed the image is completely invisible in High Contrast mode, and this is because we didn't have any comps for High Contrast. Any thoughts on what we want to do in that situation?

Since this is mostly decorative. For anyone with vision issues I would want it to go away.  So high contrast... just either set the opacity to 0% or 100% so that it is not visible. We may need to verify what it would do with a screen reader, I would hate for it to read:
code
code
giant logo
code
code
thanks Marc


Would like support reading to Uint8Array in Parser.toObject

In adding support for flatbuffers in @foxglove/schemas, I was testing the creation of an mcap file containing a foxglove.Grid which includes a Uint8 data array, and found that the renderer was spending a long time normalizing the Grid messages data field from Array to Uint8Array type.
Would this be hard to add? It would greatly increase the performance for larger data arrays.
Looks like you have a TODO here for it?
https://github.com/jkuszmaul/flatbuffers_reflection/blob/main/src/reflection.ts#L412
happy to attempt a PR on this too if you don't have time.

It should be reasonably straightforward to add, although I'd need to refresh myself on how exactly studio's parsers manage these things to ensure I actually implemented the correct feature. I'll plan to add it myself sometime soon (should probably also accept some of the version bump PR's for the dependencies....).

Ah, you may want to generate the patch then. I'm at a conference this week and so am not going to be reliable in getting it done this week.

All good, I think I have a fix, but it looks like I don't have permission to push a branch to make a PR?
I can try patching in the meantime though

looks like I don't have permission to push a branch to make a PR?

The normal way of doing this would be to make a fork of the repo

Hopefully solved, thanks @snosenzo


add autonomy stop limits

I think @syed8rahman agreed that we should have a separate frontend for these new order types for now until we can reassess our current UX.


iOS - cover set to relative path to the /www folder doesn't work

I have cover set to this path: assets/img/music-placeholder.png, which is under /www folder. However on iOS this doesn't set the cover image. Any idea?

Hello,
I am facing the same problem (Android), did you found any solution?

I have no problem with Android. Check your file and path and make sure everything is correct.

The version of this plugin i was using was outdated sorry :P

I'm having this same issue on iOS. @shawnlan- did you figure it out?

I use remote image as a workaround. Not ideal, but at least works.

Ok- works! But yeah, not ideal. Thanks!
On Jul 26, 2017, 7:15 PM -0400, shawnlan<EMAIL_ADDRESS>wrote:

I use remote image as a workaround. Not ideal, but at least works.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

same here, would be nice to have local file support like android

The same issue

It is not necessary, many times it is because the name of the app contains spaces or something like that
(the App)
I did it like this:
iOS
(cordova.file.applicationDirectory + "www / assets / imgs / cover-random.jpg"). replace ("% 20", ""); (if you app contain spaces)
or
(cordova.file.dataDirectory + cover.name) + ".jpg"
Android
assets / imgs / cover-random.jpg
or
this.file.dataDirectory + cover.name ".jpg";


Add parsing for permissions and statuses

Proposed solution
The jwt_middleware() also needs to parse permissions and statuses from ELIXIR token for GA4GH claims. Details about GA4GH AAI can be found here and a seemingly good implementation of this exists in the Beacon API Server.
DoD (Definition of Done)

Preferably a new module that checks the token in use for GA4GH claims, retrieves the GA4GH passports and processes them into sets of permissions that can be included with the request["token"] value.
Testing

A mock of OAuth2 server could be in place for integration testing

Issue is directed towards this part:
https://github.com/CSCfi/metadata-submitter/blob/e611e8f3a3026387c298603fce86d9b3b7a6c54b/metadata_backend/api/middlewares.py#L92-L101

This issue is not valid any more and closing in favour of #135


Promote extension log API to stable

What's the protocol for this? Discussion here and merge it if I get 👍s?
Earlier discussion at 98c58df
Fixes #43275

Check Travis though.

@roblourens I'm fine with the new API but Joh has the final say as he is the API police ;-)

@roblourens There is still my question:

As an extension author when should I use an output channel and when should I use the logger?

Are we deprecating the output channel API ?

I see these as different things, output channel for transient info that users would want to monitor, and logging for bug reports and info for developers.
I'm actually not sure why we show all the log files in the output pane - do we expect users to want to look at these? Even as a developer I don't see generally useful info there unless I'm looking at a specific component or issue.
But if my view is wrong then maybe there's room to merge them instead.

Yes, we use spdlog internally for implementing output channels.
We already use Output channel to show extension logs, example: Typescript log. May be there are more extensions doing the same. So, I see the point that it might confuse the authors when to use Output channel and when to use log api. To me, log api looks more as a utility than an API to the extensions.
Also, we can enhance Output to stream the log files from extensions into output channel.

TypeScript has a verbose logging mode which writes tons of info to a file, but doesn't use the output channel. Spamming the output channel in that case would just slow things down.
I assume that the output channel API transfers all data to the renderer process whether or not the output channel is visible. So that's a big difference between the two.

I do not think there will be any slow down or data transfer. If we provide an api to create a file based output channel and if extension has a log file and wanted to show in output channel, then it can create an output channel using the new API passing the log file URI.
Streaming of data happens in the renderer which will be similar to our internal log channels inside product. I did several improvements to output channels in last milestone and one of those is that no streaming happens when a file based channel is not visible.

I see these as different things, output channel for transient info that users would want to monitor, and logging for bug reports and info for developers.

I, personally, as a user, never ever want to see output channels, unless we're talking about the output of executing my program or the output from testing my program. I find it hard to imagine there are people that want to monitor output channels. Take, for example, the following output channels: git, tslint or TypeScript. I could care less what they are writing in the output channel. Also, all the messages in there are crafted by the developers of those components and I have no clue what they mean. The only time I would care is if I would file an issue and the developer asks me to paste him that information.
My point is that nobody wants to monitor output channels as part of their regular flow, similar to how nobody wants to monitor log files as part of their regular flow. So, IMHO, output channels are log files. They simply miss some tracing level, some special methods to avoid writing ifs all over the place, and perhaps could benefit from more optimization. I am not sure if the output is written to disk directly from the extension host process or it travels to the renderer process; we could write it to disk from the extension host process for all output channels, as they would all benefit from this optimization.
If I understand you correctly, we have the requirement that extensions maybe want to log from a separate process than the extension host. In such a case, I believe they would use a logging library available in their runtime's programming language. e.g. OmniSharp would use a logger written in C#, TypeScript could also use spdlog, etc. I understand how it is useful in such a case for them to write their log files close to the other VS Code log files, and us giving them a folder path and log level API makes good sense. It's just that these should be synchronous, not asynchronous, and should be pure. Getting a property should, IMHO, have no side effects, such as creating a folder on disk...

What's the protocol for this?

@roblourens Glad you are asking..

start are the api guidelines, then
propose something that doesn't conflict with the guidelines, then
discuss.

In this PR we are still on phase 2 (propose something that doesn't conflict with the guidelines) and maybe on something like phase 0 - do we want/need this API.
I agree with @alexandrudima that there is too much overlap with output channels (be minimal) and if we untangle the proposal into two pieces we might end up with a better solution. One part of this proposal is being part of the vs code logging infrastructure and using (improved) output channels seems like a promising idea/exploration. The other part is exposing log config data, like level and file location. If those aren't extension-specific we should look into adding something to vscode.env, if they are extension specific something on the ExtensionContext is required.

Outcome of discussing this

have logDirectory a property of the extension context (in the spirit of storagePath)
move log level information and corresponding event to vscode.env as there is only a global log level in vscode
move the logging-related methods to the output channel api.

We are aiming to deliver the first two items during this milestone and consider the last as stretch.

This PR is now n/a


Disallow conversions from IUOs to extistentials.

Commit 170dc8acd784ab1b24ed279239f5d9f226872bca removed a penalty that
we used to have for conversions to Any. In some unusual circumstances
not having that penalty can result in new amiguities where we should
have nothing ambiguous about an expression according to our type rules.
This change attempts to ensure that we make that less likely or
impossible by not allowing direct conversions from IUOs to Any (instead
forcing these to first be force-unchecked, leading to more expensive
solutions). We never should have allowed these conversions anyway,
independent of removing the penalty for conversions to Any.
This change is intentionally very narrow to avoid further potential
source breakage.
Fixes rdar://problem/29907555.
(cherry picked from commit 5c6c7ff651bb1f49510db6057dcf8b422f7749f4)

@swift-ci Please test

Assigning to @ematejska since I don't think we have permission to merge to swift-3.1-branch.


Windows versions supported?

Hi, the provided binary for Windows/AMD64 crashes on Windows 7 with the following stack
M:\>Terrapin_Scanner_Windows_amd64.exe
Exception 0xc0000005 0x8 0x0 0x0
PC=0x0

runtime.asmstdcall()
        /usr/lib/go/src/runtime/sys_windows_amd64.s:65 +0x75 fp=0x22fca0 sp=0x22 fc80 pc=0x466215
rax     0x0
rbx     0x632ee0
rcx     0x685ac0
rdi     0x7fffffde000
rsi     0x22fea0
rbp     0x22fde0
rsp     0x22fc78
r8      0x0
r9      0x22fee0
r10     0x657818
r11     0x21
r12     0x22fec0
r13     0x1
r14     0x632880
r15     0x0
rip     0x0
rflags  0x10293
cs      0x33
fs      0x53
gs      0x2b

Which Windows versions are supported? Or it requires some additional components to be installed?

Hi there,
Our pre-built binaries are cross-compiled to support Windows (amd64). However, Go has removed support for Windows 7 in 1.21, the version we use to build those binaries. To get the scanner up and running on Windows 7, you will need to build the scanner yourself using a Go version between 1.18 and 1.20 (see README for instructions). Alternatively, you may build a custom Docker image by adjusting the Golang version in the Dockerfile.


alright

Coverage increased (+0.4%) to 72.041% when pulling 799de4ffdff6e1b0d6fa1fc23cc16ec5a664f575 on mybranch into 3071dd900bf7c5437f038c4137750bc1405086a3 on master.

Coverage increased (+0.4%) to 72.041% when pulling 799de4ffdff6e1b0d6fa1fc23cc16ec5a664f575 on mybranch into 3071dd900bf7c5437f038c4137750bc1405086a3 on master.

Coverage increased (+0.3%) to 72.024% when pulling 390c6d9f11f5bc750e91472ab29dd4382e298c52 on mybranch into 3071dd900bf7c5437f038c4137750bc1405086a3 on master.

Coverage increased (+2.08%) to 73.753% when pulling 390c6d9f11f5bc750e91472ab29dd4382e298c52 on mybranch into 3071dd900bf7c5437f038c4137750bc1405086a3 on master.

Coverage increased (+4.009%) to 75.685% when pulling 4f896135370662428f1e713e96029125d9cb4167 on mybranch into 3071dd900bf7c5437f038c4137750bc1405086a3 on master.

Coverage increased (+4.2%) to 75.86% when pulling e5c8ad6ed721ccdcc8122b0ce29094cb6b918a63 on mybranch into 3071dd900bf7c5437f038c4137750bc1405086a3 on master.

Coverage increased (+5.3%) to 76.986% when pulling 9034ba56d452298a3aefe951044589eec3c85a38 on mybranch into 3071dd900bf7c5437f038c4137750bc1405086a3 on master.


Update handling for Panel.collapsedTitle and add support for Panel.collapsedIcon

Resolves #3477
See Toolbox PR https://github.com/xh/toolbox/pull/671
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Regarding the modal button - it seems the question we need to ask is "should we show a header with only a modal button?".
Right now (both develop and this PR) the answer is no - you need at least one other item in your header for it to show at all. However, given that we are willing to show a header with only header items (and you can think of the modal button as built in header item), this is likely an oversight on our part.
I think we should aim for needing at least one of Title / Icon / Header Items / Modal Button required to display. What do you think?

I agree if header items are enough, the modal button should be enough to show a header. But if you pop out a collapsed panel with only a modal button, you end up with this (bottom panel is modal), which definitely looks strange. However, in my opinions, it's not much stranger than the current ability to pop out a collapsed panel. I'm not sure how complicated this would be, but what do you think about toggling a panel's collapsed status when clicking the modal button so it's in an expanded state and shows its content?

Closing in favor of #3480 which includes additional fixes and refactoring


Battery percentage and charging status in OpenVRConfig

This patch adds battery percentage and charging status for openvr devices to OpenVRConfig.
See issue https://github.com/GodotVR/godot_openvr/issues/118

I approve of this!

Thanks!


Problem with jplsinfo

jplsinfo.cpp:26:12: error: no match for 'operator<<' (operand types are 'std::stringstream' {aka 'std::__cxx11::basic_stringstream<char>'} and 'const charls::spiff_profile_id')
   26 |         ss << val;
      |         ~~~^~~~~~
In file included from c:\msys1200\include\c++\12.0.1\istream:39,
                 from c:\msys1200\include\c++\12.0.1\fstream:38,
                 from jplsinfo.cpp:6:
c:\msys1200\include\c++\12.0.1\ostream:108:7: note: candidate: 'std::basic_ostream<_CharT, _Traits>::__ostream_type& std::basic_ostream<_CharT, _Traits>::operator<<(__ostream_type& (*)(__ostream_type&)) [with _CharT = char; _Traits = std::char_traits<char>; __ostream_type = std::basic_ostream<char>]'
  108 |       operator<<(__ostream_type& (*__pf)(__ostream_type&))
      |       ^~~~~~~~
c:\msys1200\include\c++\12.0.1\ostream:108:36: note:   no known conversion for argument 1 from 'const charls::spiff_profile_id' to 'std::basic_ostream<char>::__ostream_type& (*)(std::basic_ostream<char>::__ostream_type&)' {aka 'std::basic_ostream<char>& (*)(std::basic_ostream<char>&)'}
  108 |       operator<<(__ostream_type& (*__pf)(__ostream_type&))
      |                  ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

I do not see reference to charls version. Closing as incomplete. Feel free to reopen if you are using charls 2.2.x (or up).

Fixed in ea442f4


Call Founder's Calculation Option and Display it's Return

#102
*make sure it follows original Descent functionality.

Very quick task
Copied Lineages Tab and changed its function names and function calls to match Founders
Noticed the backend data is not what Ziker showed us. This will need to be changed in the future, but will require no alterations in the frontend
{t:10}


Test PR - adding a file for testing purpose

This is a test PR.
This is not intended to be merged

trigger build DUNE/dunesw#41

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard


A UI element that is centred in the canvas will continually enter/exit the element

If you put a UI button in the centre of a UI canvas and point the UI Pointer at it, the button will flicker as it is constantly being put into the on/off state.

https://github.com/thestonefox/SteamVR_Unity_Toolkit/pull/528


Add non full line selection to CodeMirror

I would just like to preface this issue with a little context on my thoughts about this addition to CodeMirror. I've always been a fan of how CodeMirror V1 performed "non-full-line selection". Here's a screenshot of CodeMirror V1's selection:

@marijnh I also know that you weren't exactly keen on the idea when CodeMirror V2 was brought out. At the time you said:

The current model doesn't easily allow supporting both approaches, so there's no option to switch between them.

But having a look at the code now, it looks like the foundation that's there may support both approaches without too much effort. I've actually started to add the non-full-line-selection as an option in this fork (you can see the exact changes here in this commit).
Here's a quick screenshot of the current fork, with fullLineSelection disabled in the top editor:

Please note, that unfortunately I haven't been able to fully wrap my head around bidirectional text, so my current fork only supports the left-to-right direction. However, I have got it working perfectly with lineWrapping and also with code folds.

I was also looking at giving the selection a curved border so it would look more aesthetic (like Sublime Text, vscode, etc.), here's an example (from vscode).

I originally thought that adding curved borders would be too difficult in the DOM, but vscode tackles the problem by adding extra elements where the border-radius needs to go the other way - a smart trick, and it works well! Here's what I mean.

All in all, I'm creating this issue at the moment, for two reasons:

I think I may need your help with supporting bidirectional text
I don't want to put in heaps of effort if this isn't something you want to have in CodeMirror

All things considered, @marijnh I would like to know your opinions, thoughts, suggestions, etc. on potentially integrating this into CodeMirror.

Have you tried using CSS to hide the built-in selection (.CodeMirror-selected { display: none }) and using the markselection addon to style your selection?

Hah! I hadn't thought of that. That definitely looks like it works well, but is it possible to highlight past the end of the line with the markselection addon?
e.g., when highlighting just the text, if one highlights past the line an extra distance is highlighted to indicate that the selection is past the end of the line. (Like line 4 in the 2nd screenshot in my original post). Because, if that's not possible, then the user won't be able to distinguish between highlighting just to the end of the line, or highlighting to the start of the next line.

but is it possible to highlight past the end of the line with the markselection addon?

Not easily. You could add more code to add style non-breaking-space widgets to every line whose end is selected.

Hmm, I'm not sure that's exactly possible. I've tried to give that a shot both with cm.addWidget and cm.markText. It looks like both those APIs clip the widget to the end of the line - so I can't seem to place the widget after the actual line.
It may be possible with markText but since the marker wraps with the text is the user has lineWrapping: true and the line exceeds the max length then the widget will wrap too.
Unless, of course, I misunderstood how one would go about adding such widgets.

I can't seem to place the widget after the actual line.

You don't need to -- if you place it at the end of the line, it can take up space and thus extend the line.

Ah, sorry about that -- I must have had something wrong in my tests.
I got it all working now 👍
Sorry for the trouble, and thanks again 😄


Use the selector atom-text-editor[mini] to select mini-editors.

In index.less: Use the selector atom-text-editor[mini] to select mini-editors.

Just go through the less css files and search for .editor class and change it to .atom-text-ditor. THen look in all the other files for a instance of it and change it as well this will fix the issue until someone changes it in the repo.

This is a duplicate of #38 which has been fixed in v0.3.2.


Optimized config loading and refactored Jmeter element custom exception logging

Hey @QAInsights ,
This is a nice tool you have created there!
I just thought few parts of it could be refactored and some further optimized.
So I made those changes in this PR...

I've refactored the following:

The way config is being loaded. Instead of loading it multiple times, its better to load once and use it everywhere in the tool.
Converted if/elif/else conditional checks to Dictionary based switch case for exception element logging to reduce number of condition checks.

I've added the following:

config.py which will load the configuration at the start of application and holds the configuration for later use.
exceptions.py which is refactored if/else blocks from engine.py

I've removed:

f.close() while loading jmx file in app.py, since file is opened with a context manager.

Cheer!
Prasad

Glad to see that I'm not the only one that saw great potential in the tool and started contributing 😄 ! Nice work @leelaprasadv !

Thanks @leelaprasadv and @delirius325 for the support :).

Thanks @leelaprasadv for the PR. It is merged now.
@all-contributors please add @leelaprasadv  for code.


Webplayer/ Demo shows black screen

When visiting https://nex-mpi.github.io/viewer/viewer.html?scene=https://pureexe.github.io/food/1008 I cannot see any image being rendered. I'm using Firefox v88 on arch linux. In chrome the application just crashes for me.

Please try to open this link instead. Is it work for you?
https://nex-mpi.github.io/viewer/viewer.html?scene=https://pureexe.github.io/food/640
What is your machine spec?
I suspect that memory. (RAM / VRAM) is too small for storing the MPI.

@pureexe  thanks - this link works. I'm running this off a X1 Carbon Notebook but with the second link I'll get also higher FPS (~40). Will try in an hr on a GPU machine, thanks for the quick response.


Add text edit to history stack

If I need to change the state of the text that is bound to the <prism-editor /> component (i.e., by doing something other than typing into the text field), is there any way to ensure that the history stack stays correct?

I guess yes, have you tried it?

Yes, I've tried it. For example, this doesn't work:
  <button @click="addLine">Add line</button>
    <prism-editor
      class="my-editor"
      v-model="code"
      :highlight="highlighter"
      line-numbers
    />

  data() {
    return {
      code: '',
    };
  },
  methods: {
    highlighter(code) {
      return highlight(code, languages.js);
    },
    addLine() {
      this.code = `${this.code}\nconst foo = "bar";`;
    }
  },

Clicking the "addLine" button will update the text--but then typing ⌘+Z will cause the textarea state to go back to one edit prior to the state before clicking the "addLine" method.


⚠ ESPN has degraded performance

In a5ea91e, ESPN (https://espn.com) experienced degraded performance:

HTTP code: 200
Response time: 1054 ms

Resolved: ESPN performance has improved in da0a877.


Release 5.3.0

What was changed in onc_certification_g10_matrix.xlsx
Github cannot diff binary file.
~ Yunwei
From: Stephen MacVicar @.>
Date: Monday, April 8, 2024 at 9:08 AM
To: onc-healthit/onc-certification-g10-test-kit @.>
Cc: Subscribed @.***>
Subject: [EXT] [onc-healthit/onc-certification-g10-test-kit] Release 5.3.0 (PR #507)
You can view, comment on, or merge this pull request online at: https: //github. com/onc-healthit/onc-certification-g10-test-kit/pull/507 Commit Summary 23d0e6a bump version 2499e8b bump smart test kit 2f399ee use new validator 35cdd7c bump core

You can view, comment on, or merge this pull request online at:
https://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507
Commit Summary

23d0e6ahttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/commits/23d0e6a34bb92e1bf83a8f48eb870a0a9e476ac9 bump version
2499e8bhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/commits/2499e8b29571c7c481e861f39b6ac7b10adedccb bump smart test kit
2f399eehttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/commits/2f399eeaf9af370bfd6eb3adab8115602b71eccf use new validator
35cdd7chttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/commits/35cdd7cbfa8c806bd89cce6631b423e53e0e502c bump core
dc6fca4https://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/commits/dc6fca43f79470954afaea6f4fc18c050cf93a4e bump us core
838a7fbhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/commits/838a7fb77bc51f240723831d59b7fb2814c9afc2 regenerate matrix

File Changes
(8 fileshttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files)

M .envhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055d (2)
M Gemfile.lockhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731f (36)
M config/nginx.background.confhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-768be0c531c45a77f309cb9e49a94e3a00dbd7f3722e2fb54cec4e1091fea5dd (30)
M docker-compose.background.ymlhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-19abf8eb1d0ad3c2035c6a535b37328dff896c8481f6a9d74b68a30cf9bc9a74 (22)
M docker-compose.ymlhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3 (8)
M lib/onc_certification_g10_test_kit/version.rbhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-7c5bd0d85aad0fc54276813a35c97f79a95d8d5866c4aba374c2f4e568c93bd6 (2)
M onc_certification_g10_matrix.xlsxhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-debaf44e3264ddd4a06e7f412c0d5b12a0c869d4081b9406ad61efcc8d59d2f2 (0)
M onc_certification_g10_test_kit.gemspechttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507/files#diff-aed467f6c1d98e4c411ee9a56cbf426417c47304d52d83614e6fca4d617d4523 (4)

Patch Links:

https://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507.patch
https://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507.diff

—
Reply to this email directly, view it on GitHubhttps://github.com/onc-healthit/onc-certification-g10-test-kit/pull/507, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACC26V7CVMRG5CH7ZEMQWALY4KQGDAVCNFSM6AAAAABF4ZG2JKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTCMZSGQZTSNY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

What was changed in onc_certification_g10_matrix.xlsx Github cannot diff binary file.

Probably just the version number. It's a generated file.


Consolidate the three Browser dirty bits

This PR removes needs_chrome_raster, needs_tab_raster and needs_draw, and replaces them with a single dirty bit needs_raster_and_draw. Aims accomplished:

Simplifies the code substantially (and found one bug in lab12.py as a result -- raster timing was wrong)
Provides room for an exercise on this topic

I found that needs_raster_and_draw is necessary and can't be removed. The reason is that the browser thread event loop is unfortunately continuously polling and can't be made event-driven (because SDL doesn't seem to support it). So without this loop, the browser thread would have erratic behavior when trying to run animations, because it'd waste a lot of time doing useless rasters and delay responding to the main thread.

Going to merge this one too, and the removal of TabWrapper after (PR 346). Then you can do a full review on Monday..


channel images/metadata not reflected after submitting an update

Since we re-resolve the channel page, the pending data is overwritten by the resolve and we lose the recently edited data. If the page is refreshed later, the image/metadata should be updated.
The metadata is also lost if you try to edit the channel before it's confirmed also.

If a real fix for this is complicated, a hack-fix like that shows a warning/notice to wait n minutes for channel edits if a user has edited a channel within that time window would be acceptable.


TagHelpers : Should support nested <input> elements

as of tag helper label, when there is not content, the displayname is shown while if there's content the content is used.
This is good because we can use

and
I want to be kept logged in on every visit

but there is a 'case' when we may want both, having content and providing the displayname from metadata/modelstate like this

    <input asp-for="RememberMe" />

This will display a checkbox with empty text inside.
I can do

    <input asp-for="RememberMe" />
    @Html.NameFor(m => m.RememberMe)

This works but I need to use old HtmlHelpers to read from modelstate/metadata.
Another problem is that label should only have one input inside and checkbox taghelper adds two for the model binder to work. This has no visual problem but is not valid html.
the intended result html is:

    <input id="RememberMe" name="RememberMe" type="checkbox" value="true">
    RememberMe

<input name="RememberMe" type="hidden" value="false">

Is this kind of support added to the label taghelper somehow?
Is there a plan to support this scenario ? (I know in MVC5 this was not possible with HtmlHelpers, but since you added tag helpers, I was hoping we have some way to sort this out)
Note that bootstrap uses this structure so checkbox is aligned well on the form http://getbootstrap.com/css/#forms-example

+1
Just a note:

Another problem is that label should only have one input inside and checkbox taghelper adds two for the model binder to work. This has no visual problem but is not valid html.

I think this is incorrect. Any input with hidden type is not interactive element at all, so the markup:

 <input type="checkbox" name="RememberMe" value="true" checked>
 <input type="hidden" name="RememberMe" value="false">
 Remember Me?

will perfectly pass W3C validator.
more:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#Phrasing_content
specifically:

, if the type attribute is not in the hidden state

A simple solution would probably be to just keep the existing content and add the label value to the end or the beginning—but there’s already the problem that you would need some way of configuring where it’s supposed to be inserted. At the beginning is equally valid as at the end; but it would be even okay to have it nested in other elements.
I don’t know if tag helpers could provide this technically, but it would be cool if they were able to expose some tag “context” variable which you could refer to from within the tag. That way, you could access the label value in this case, or even other more complex values in other tags:

    <input<EMAIL_ADDRESS>/>
    @label.Text

There, the asp-context attribute allows you to define a new variable which exists within the tag’s “scope”.

Any progress on this?
I think it is a matter of detecting if the parent of the checkbox is a Label and if so render the Label text after the input field.

            <input asp-for="AllowContactAboutOffers" />

outputs

      <input type="checkbox"
                 name="AllowContactAboutOffers"
                 id="AllowContactAboutOffers"> Content from Display Name

+1  Has there been any progress on this?

Am I correct in saying that the documentation is incorrect for Bool .NET Types mapping to input type of checkbox here? https://docs.microsoft.com/en-us/aspnet/core/mvc/views/working-with-forms. I guess I am wondering at what point in these open issues would one change the docs to remove the expectation or note that it does not work? Sorry all.....just challenged with read and do only to research and find issues. Thanks for your input.


[Production] "Academic honesty accepted" looks like a button

Describe the bug
When we accept the academic honesty policy and hover over the text, it feels like a button. The cursor should be auto.
To Reproduce
Steps to reproduce the behavior:

Go to the settings page
Make sure you have accepted academic honesty policy
Hover over "you have accepted academic honesty" button

Desktop (please complete the following information):

OS: Windows 10 Pro 32 Bit Pro
Browser: Chrome
Version: 77.0.3865.90

We can make this button disabled, no? I tried it and it seems good.

Please feel free to make a PR..
Here are the lines that you probably need to touch:
https://github.com/freeCodeCamp/freeCodeCamp/blob/aa62fdbfe98f872785f792108c6d55582da7e12d/client/src/components/settings/Honesty.js#L20-L30

[ ] The panel can be a button and disabled.
[ ] We would need some tests for these as well.

Thanks.

Please follow our guidelines for contributing

Sure, I'll do it as soon as I can, after work.

@raisedadead I went ahead and created a PR for this, along with unit test. Hope it's fine.


Add stories for appearance/layout/positions

REDMINE-17717

Coverage remained the same at 99.208% when pulling a1e98a648d2291a1e2887a50fbb0ff6e015ce78d on tf:appearance-stories into f68c6387337f3c07f74bdf1ca8543122d0bb1a1b on codevise:master.


Remove whitespace with (

Hi if I have a something like: [foo] and I press cs[( then I get [ foo ]. I would like open parenthesis to avoid adding the leading/trailing whitespace (i.e basically swap the default behaviour of ( for ))? Is that possible?  I had something working prior to todays changes with:
require('nvim-surround').setup({
    delimiters = {
        pairs = {
            ['('] = { '(', ')' },
        },
}})

but that is not working anymore.. Thanks in advance!

See the breaking changes issue (#77), many changes have been made to configuration that break things. You're going to want to put the table under the add key.

Hi! I indeed saw that but if I add:
require('nvim-surround').setup({
    surrounds = {
        ['('] = {
            add = { '(', ')' },
        },
    },
})

and then for instance try ds( on (foo) it won't work  since I probably also need to add a delete entry to the surrounds table.. My question therefore is: is there an easy way to simple map/swap ( to have the same of ) for add, delete and change?

You can set the ( surround to false, then alias ( to ) in the aliases table. See the default configuration for examples

Hi! I indeed saw that but if I add:
require('nvim-surround').setup({
    surrounds = {
        ['('] = {
            add = { '(', ')' },
        },
    },
})

and then for instance try ds( on (foo) it won't work since I probably also need to add a delete entry to the surrounds table.. My question therefore is: is there an easy way to simple map/swap ( to have the same of ) for add, delete and change?

Also with respect to why your original setup didn't work: you are correct that you would need to provide find/delete keys; they were defaulting to the invalid_key_behavior behavior, and was trying to delete {, '(', '(' } pairs.

Thanks!

just want to leave a comment for OP: I had the exact same issue. And of course, thank you kylechui for providing the exact solution we need!


Build: Add action to verify PR labels

What this PR does / why we need it:
We use Auto to assist with publishing npm packages, updating changelogs and doing github releases. For this to work PRs need specific labels / sets of labels adding however understanding which to add when and remembering to do this has proven problematic. This PR introduces a gh action that will check labelling of PRs and comment on the PR to help educate contributors.The action will not post multiple comments, instead it will always update the first message it posts. It will block PR merging under certain circumstances (noted by the ❌ in the message). Below are screenshots of the various messaging.
No semver or release labels

Semver label no release label

Semver and release labels

Conflicting / multiple semver labels

No changelog label

No changelog and release label

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Whether we want to warn in Semver and release labels about issues when merging a subsequent PR with release? i.e. from the contributing docs:

NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

If we should clarify that release and no-changelog are mutually exclusive in the following:

Optionally_ add the release label if you would like this PR to trigger npm package publishing.

I've updated the PR to try to solve the above two issues by

added the note about merging subsequent PRs
updated the optional release label message to state adding it only if using patch, minor or major labels...

Optionally if using a patch, minor or major label also add the release label if you would like this PR to trigger npm package publishing.


Add example of a simple Streamlit app using autogen 0.4.X

What feature would you like to be added?
There is a simple example (see app) for integrating Autogen 0.2.X into a Streamlit app.
There is not such a reference (to my knowledge) for this integration using Autogen 0.4.X. Given Streamlit's popularity, this would be helpful to many developers.
The concrete ask here is, under an examples folder, have an app.py demonstrating how Streamlit could be integrated.
Why is this needed?
See previous message.

This could be a great addition. We do have one for ChainLit: https://github.com/microsoft/autogen/tree/main/python/packages/autogen-core/samples/distributed-group-chat though the focus is more on distributed agents rather than the presentation layer.
Is this something you can help with? I feel it can be a good addition for the AgentChat package, under https://github.com/microsoft/autogen/tree/main/python/packages/autogen-agentchat a samples directory.


Update specs2-core to 4.20.5

About this PR
📦 Updates org.specs2:specs2-core from 3.+ to 4.20.5
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.specs2", artifactId = "specs2-core" }
}]

labels: test-library-update, version-scheme:semver-spec, commit-count:1

Superseded by #60.


Limit xMac JDK22+ testing to MacOS v11+

...because JDK22 and up are not built to be usable on MacOS versions under 11.

Fixes #949

Being tested here: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk22/job/jdk22-mac-x64-temurin/18/console

run tests


Move SampleSolrApp into different Repository

In order to clean up the repo, I suggest moving the SampleSolrApp and its dependencies to it's own repository (ex. SolrNet/SampleSolrApp).
The Sample Solr App can reference Solr by using nuget, just like any other user would do.
I'm more than happy to help/do the migration, once the extra project is set up.

Excellent idea. The current master in SolrNet also has a 4.x version of Solr which can be moved here as well.
Thank you very much, here is the repository:
https://github.com/SolrNet/SolrNetSampleApps
Please put the current SampleSolrApp in a folder of its own so that other samples can be added when required
Also on Monday I will work on Nuget

I actually started working on getting solr upgraded to 6.6  , have it working in theory.
solr itself should be in both repo's, since the integration tests use solr as well.

@xavier-morera  I'll move the SampleSolrApp version from solrnet/net-update-plus-autofac-ninject

Great work! Here is what I think are the next steps:

Get current version in Nuget (just got keys today, will try it out tonight)
Release the branch that upgrades to 4.6, including Nuget (but not yet Solr 6.6) Having this is as a standalone release helps those that are currently using SolrNet with older versions as it has minimal changes
Go for SolrCloud (branch already waiting for review)
Then Solr 6.6 (is it possible to do this in a separate branch, just to get other people to test?)

Thanks a lot! Great contributions

Regarding Solr 6.6, I didn't actually mean solrnet support for it (if necessary), but rather, upgrading the solr version inside the project to 6.6  . Anyway this will lay the basis for code support for 6.6, so yet when we get to number 4 I'll do so.
I'm in rather advanced stages of async support (see https://github.com/gjunge/SolrNet/tree/async-support ) . I'm only all the time facing issues with our unit tests and build system.
MbUnit is not really .net 4.6 friendly, and I feel we are reaching its EOL boundaries.
So I also started kind of a bomb shell project, converting all unit tests to xunit, and getting them to run in AppVeyor.  I am aware of #175 , but it seems that 2.5 year later, and 10 year after creating some those unit tests, xunit is in good shape to take over.

Understood on 1. Then I suggest Solr should be moved to the SolrNetSampleApps to minimize size of main repository.
Great on 2. Understood on XUnit. I am totally in favor of XUnit. The creator of this project, Mauricio, favored MbUnit and had strong reasons to do so, but development ceased on MbUnit so worth moving to XUnit at this point.
So on 3. then it is better to have both in parallel and move little by little from MbUnit to XUnit to do a controlled and progressive migration

Well, actually the solr instance is in use by the integration tests (which currently ,  with MbUnit,  partially fail), see also #289  . Maybe in the future we can create some (Powershell) scripts that downloads and sets solr up when the integration tests are run for the first time, for now I think that is a bridge too far.
and 3. See #289, it is actually pretty far along.

Different question all together: Are you still using the FAKE/Build scripts? I believe that most of what it does can be moved over to different areas.

NuGet packaging, add a standard nuspec file to the various projects, and let let AppVeyor do the publishing. This seems a much more standard way to do it. This way a user can even decide to publish the nugets of his branch to a private nuget server easiliy.
Running test: from the IDE and in AppVeyor
Building: from the IDE and in AppVeyor
Running integration tests: can build a script for that
Running the sample app, will be separated anyway.
ILMerge: needed for what?
What is your opinion on the matter?

Answers inline

NuGet packaging, add a standard nuspec file to the various projects, and let let AppVeyor do the publishing. This seems a much more standard way to do it. This way a user can even decide to publish the nugets of his branch to a private nuget server easiliy.

Agreed

Running test: from the IDE and in AppVeyor

I agree, however Mauricio had a different opinion on running from the IDE. However let's move forward and if the original creator wants a different direction we can start a talk on the matter

Building: from the IDE and in AppVeyor

Agreed

Running integration tests: can build a script for that

Sounds good, especially not having Solr as part of the repository

Running the sample app, will be separated anyway.

Agreed, I can move it tonight or tomorrow and commit.

ILMerge: needed for what?

I do not know, need to review

Cannot find SampleApp in both repositories. Do You update app during development?

@xavier-morera A PR is still waiting to be accepted: https://github.com/SolrNet/SolrNetSampleApps/pull/1

Also, I've found other commit  and tried to run SampleSolrApp from given .bat file -- getting errors, web page tells that app.config is wrong.

@gjunge thanks, done.

You should update the docs that reference the old location, I was tearing my hair out for a minute.

Done @camelofcode
Sorry for that. Thank you


Add more EnvTest coverage

Add more test scaffoling
Cover more config samples
Add tests for inspector controller

/test unit

/test unit

could not run steps: step unit failed: failed to create or restart test pod: unable to create pod: Pod "unit" is invalid: spec.containers[0].resources.requests: Invalid value: "2168235294": must be less than or equal to memory limit of 2Gi

/test unit
https://github.com/openshift/release/pull/41053 should resolve previous resource limit issue.


Filtered search for efforts does not display the organization owner or the effort status

When exporting a filtered search on efforts to an Excel spreadsheet, the effort owner organization and the effort status are not included in the spreadsheet.

Refined to: add status, responsibleOrg, customFieldEnum1 and customFieldRef1 to the Excel export for tasks/effort search results.


iOS9 - UICollectionViewFlowLayout has cached frame mismatch for index path

Hi,
After a recent upgrade to iOS9, I started seeing this warning on the console:
UICollectionViewFlowLayout has cached frame mismatch for index path <NSIndexPath: 0xc000000000000016> {length = 2, path = 0 - 0} - cached value: {{9.75, 0}, {55, 65}}; expected value: {{0, 0}, {55, 65}}
This is likely occurring because the flow layout subclass KTCenterFlowLayout is modifying attributes returned by UICollectionViewFlowLayout without copying them
Changing :
NSMutableArray *superAttributes = [NSMutableArray arrayWithArray:[super layoutAttributesForElementsInRect:rect]];
to
NSMutableArray *superAttributes = [NSMutableArray arrayWithArray:[super layoutAttributesForElementsInRect:rect].copy];
Fixed the issue.
Hope that helps.

Thank you kindly!


[android_alarm_manager] Added comments and refactored android_alarm_manager plugin for clarity.

Description
I started reading through android_alarm_manager to determine how it would work with the new Android plugin API but I had a difficult time tracing the execution paths and interpreting the intent of the code. So I decided to go through and document everything I could to make better sense of it. I'd like to commit those comments and minor refactorings so that hopefully it's a little more clear for everyone.
Added comments and refactored android_alarm_manager plugin for clarity.

Added many comments, both on public members and within private source code.
Moved all static behavior above instance behavior in AlarmService to clearly demonstrate how much behavior has been defined statically (which I think we very much want to move to instance behavior).
Renamed some methods to shift them from ambiguous naming to explicit.
Created request data structures to parse and hold information about desired one-shot and periodic tasks.

Recommendations for further refactoring:

I think we should move all the plugin behavior out of AlarmService and into its own object because AlarmService lives and dies based on the OS, regardless of whether that timing is convenient for our plugin behavior.
On a similar note, we should adjust the API to work with multiple Flutter execution contexts instead of just one. This will be a requirement for add-to-app scenarios, regardless of what the new Android embedding API looks like.
I would recommend codifying the method channel messages in its own object instead of combining it with the associated logic. This will also make it much easier in the future to replace hand-coded message handling with a generated version.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[ ] All existing and new tests are passing.
[x ] I updated/added relevant documentation (doc comments with ///).
[x ] The analyzer (flutter analyze) does not report any problems on my PR.
[ x] I read and followed the [Flutter Style Guide].
[x ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[ ] I updated CHANGELOG.md to add a description of the change.
[x ] I signed the [CLA].
[x ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ x] No, this is not a breaking change.

@mklim @jason-simmons @bkonyi - Do any of you have any concerns or comments about this PR, outside of the minor formatting complaints coming from PR validation?


🧪 Form - Add Test

CC: @ncn-ssw @Ben0189 @jeffsee55 @scottgallant @wicksipedia
Hi Team,
There aren't any tests for local storage, which requires integration tests on a core part of tinacms.
Tasks,

[x] Implement Playwright and add it to CI
[x] Implement one UI test, make sure it works in CI
[x] Add basic tests for local storage

Progress update 🚀

Done - Set up a specific TinaCMS example project for Playwright
Done - Completed the initial setup and configuration for Playwright.
Done - Executed the first end-to-end (E2E) test to create a blog post.

Moving on we can start write some E2E test for local storage retain edit🙌.

As per conversation with @JackDevAU and @wicksipedia in daily meeting, the test for the local storage retain edit feature can be marked as skipped in the CI pipeline for now since the local storage feature is not yet implemented😊,

Progress update 🚀
Done - Added UI test for local storage edit retain on input and rich text editor
Done - Added playwright test workflow in CI GitHub action
In progress - Improve test to use playwright best practices
In progress - Improve CI workflow for playwright test
re-estimated to 4

Progress update 🚀
Done - Playwright setup finished with one working test (create blog post and two draft test for local storage retain edit)
Done - CI workflow setup for playwright test to run (e2e test workflow)
BLOCKED - pr cannot be build due to broken pipeline
https://github.com/orgs/tinacms/projects/38/views/1?pane=issue&itemId=68475801

✅ Done - PR merged https://github.com/tinacms/tinacms/pull/4592


Attribute AutocompleteBase to limit SELECT field from database

Hello,
I am would like disqus to modify AutocompleteBase to provide this kind hook:
class InstitutionAutocomplete(autocomplete_light.AutocompleteModelBase):
    search_fields = ['name']
    list_fields = ('id', 'name')
    def choices_for_request(self, *args, **kwargs):
        qs = super(InstitutionAutocomplete, self).choices_for_request(*args, **kwargs)
        return qs.only(**self.list_fields) if self.list_fields else qs

I am think in mosts cases autocomplete don't require a lot of data, so this is a good idea to provide attribute to limit fields fetched by database. Django by default fetch all fields, long text fields too.
Greetings,

That's sane for the DB.


Similar to "read" in Calc, implement "get" which reads a URL

For full "curl" functionality we would need header support, and etc. but it could start with just accessing the URL with a "GET" call and retrieving the result.

Currently researching the best HTTP library to use.


auth requests to registry do not use User-Agent override from plugins."io.containerd.grpc.v1.cri".registry.headers

Description
After configuring plugins."io.containerd.grpc.v1.cri".registry.headers with the custom User-Agent string I can see an updated header on registry calls, but not on auth calls like https://auth.docker.io/token?scope=repository%3Agoogle%2Fpause%3Apull&service=registry.docker.io
Steps to reproduce the issue

Configure headers

[plugins."io.containerd.grpc.v1.cri".registry.headers]
  User-Agent = ["my-user-agent-override"]

I can see User-agent was overriden successfully in calls to https://registry-1.docker.io/v2/google/pause/manifests/124sf
I see standard header (not overriden) in calls to https://auth.docker.io/token?scope=repository%3Agoogle%2Fpause%3Apull&service=registry.docker.io

I didn't test with the hosts file (new configuration model), but I'd think it will be the same.
Describe the results you received and expected
on manifest and image download header is set.
What version of containerd are you using?
containerd github.com/containerd/containerd 1.7.0-0ubuntu0~22.04.1~gke1
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

this is still a problem. Not sure how to reopen it in this repo
/reopen


Improve Polish translation for emptyMessage key

A coworker on our i18n team reports that the current Polish translation for the emptyMessage key is confusing and/or inaccurate.
The current message for the key emptyMessage in English reads: "No available options"
The current Polish string is "Brak danych", which translated literally means "no data".
The slight loss of meaning makes this confusing for our Polish colleagues, as this shows up in various components that don't have options loaded yet.
This PR corrects the translation to: Nie ma dostępnych opcji, which translates more directly to "no options available".

@jbookersas nice!  Did you check any others.  Some of these I generated with Google Translate so they may not be 100% correct. :)

I did not. I'm relying on my colleague in Poland to report these. I can ask them to have a look, though.

thank you i think some of them probably are not accurate :)


Chrome becomes active window after drag and drop

This is currently reproducible on the demo page: https://angular-file-upload.appspot.com/.
OS: Windows 7
Browser Versions: Chrome 53 & 52, Firefox 48, IE11

Position a Windows Explorer window on top of a Chrome window.
Drag and drop a file from Windows Explorer to the demo page draggable area in Chrome
Chrome becomes the active window

Follow the steps above again using Firefox and IE and note that Windows Explorer remains the active window after dragging and dropping the file.
Can you prevent Chrome from stealing focus from Windows Explorer?

Submit the bug on google Chrome. I am not sure which behaviour would be better. Having the browser to gain focus makes sense to me. Anyway it is very browser implementation dependent I don't think it should be hacked to accommodate for inside this plugin. You might be able to achieve something for chrome by listening to the drop event and stopping propagation something similar.