Model loads after each completed partition

Given the embedding udf below, the model re-loads and is reinitializing after each write and completed partition / parquet file:
import daft
import torch
import numpy as np
from typing import Optional

BATCH_SIZE = 1
NUM_GPUS = 1
return_dtype=daft.DataType.list(daft.DataType.float64())

@daft.udf(return_dtype=return_dtype, num_gpus=NUM_GPUS, batch_size=BATCH_SIZE)
class STEmbeddingUDF:
    def __init__(
        self,
        model_name: str,
        device: str = "cuda",
        convert_to_tensor: bool = False,
        torch_dtype: torch.dtype = torch.float16,
        set_seq_len: bool = True,
        max_seq_length: Optional[int] = 2048,
    ):
        from sentence_transformers import SentenceTransformer

        self.model = SentenceTransformer(
            model_name,
            device=device,
            model_kwargs={"torch_dtype": torch_dtype}
        )

        if set_seq_len:
            self.model.max_seq_length = max_seq_length

        self.convert_to_tensor = convert_to_tensor
        self.device = device

    def __call__(self, text_col: daft.DataFrame) -> daft.DataFrame:
        embeddings = self.model.encode(
            text_col.to_pylist(),
            batch_size=BATCH_SIZE,
            convert_to_tensor=self.convert_to_tensor,
            device=self.device,
        )
        if self.convert_to_tensor is not True:
            embeddings = embeddings[0].astype(np.float64)
        return [embeddings]

...

df = daft.read_parquet(f"hf://datasets/name")

processor = STEmbeddingUDF
data = col("text")
df = df.with_column("embeddings, processor(data))

df.to_parquet("embeddings")

Model reloads after completing and writing one partition/file:
Loading checkpoint shards: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████| 7/7 [00:49<00:00,  7.09s/it]
We detected that you are passing `past_key_values` as a tuple and this is deprecated and will be removed in v4.43. Please use an appropriate `Cache` class (https://huggingface.co/docs/transformers/v4.41.3/en/internal/generation_utils#transformers.Cache)
Loading checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 7/7 [00:47<00:00,  6.82s/it]
Loading checkpoint shards:  29%|████████████████████████████████▎                                                                                | 2/7 [00:13<00:32,  6.41s/it]

Any input would be greatly appreciated.

Indeed. This is something @kevinzwang is working on stabilizing our solution for.
You can actually try it out with the environment variable: DAFT_ENABLE_ACTOR_POOL_PROJECTIONS =1
The fix is currently available for the local executor. We have some local branches available for the Ray Runner as well and are in the process of testing/stabilizing both. Let us know if you try it!

I see you're using a GPU as well in your UDF. We will probably want to correctly assign the CUDA_VISBLE_DEVICES appropriately for each instance of your UDF which isn't yet being done on the PyRunner.

Indeed. This is something @kevinzwang is working on stabilizing our solution for.
You can actually try it out with the environment variable: DAFT_ENABLE_ACTOR_POOL_PROJECTIONS =1
The fix is currently available for the local executor. We have some local branches available for the Ray Runner as well and are in the process of testing/stabilizing both. Let us know if you try it!

Hi @jaychia ,
I will test out setting the environment variable for cuda visible devices and actor pool.
Thank you!

Made a PR for an initial attempt at doing CUDA_VISIBLE_DEVICES: https://github.com/Eventual-Inc/Daft/pull/2882
You'll likely need that if running multi-GPU on a single node + PyRunner!

Hi @jaychia,
Setting DAFT_ENABLE_ACTOR_POOL_PROJECTIONS=1 helped to resolve the issue of the model loading multiple times per completed partition.
But now when I run the above udf with :
STEmbeddingUDF.with_init_args(
    model_name="sentence-transformers/all-MiniLM-L6-v2",
    convert_to_tensor=False
).with_concurrency(1).override_options(num_gpus=1)

I receive the error:
    name: partial_udf.func_cls() for name, partial_udf in partial_stateful_udfs.items()
TypeError: STEmbeddingUDF.__init__() missing 1 required positional argument: 'model_name'

    raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

Thank you.

Oops yes, I think you've stumbled upon one of the TODOs in this beta feature:

Let me work on something here

Oops yes, I think you've stumbled upon one of the TODOs in this beta feature:
Let me work on something here

Thank you!

Hi @jaychia,
I am now able to run with EmbeddingUDF.with_init_args(model_name).with_concurrency(1).override_options(num_gpus=1) using the main branch.
But now hit an error for RuntimeError: No CUDA GPUs are available when using daft.context.set_runner_ray().
I have exported export CUDA_VISIBLE_DEVICES=0 before running the script.
Thank you.

Hi @jaychia,
I am now able to run with EmbeddingUDF.with_init_args(model_name).with_concurrency(1).override_options(num_gpus=1) using the main branch.
But now hit an error for RuntimeError: No CUDA GPUs are available when using daft.context.set_runner_ray().
I have exported export CUDA_VISIBLE_DEVICES=0 before running the script.
I know you mentioned previously that there was another branch for Ray Actor pool but I was unsure if these were directly related.
Thank you.

Ahh derp! I think we just forgot to forward the GPU requests to the Actor pool that we're creating. Should be a very simple fix. cc @kevinzwang

Hi @conceptofmind, just merged in a PR to fix the ray actor resource allocation issue you encountered. It will be included in our next release!

Hi @conceptofmind, just merged in a PR to fix the ray actor resource allocation issue you encountered. It will be included in our next release!

Hi @kevinzwang,
I will test it out on the main branch now.
Thank you!

Looks like it is all working now on the main branch.
See 1.0/1.0 in the Ray Actor pool:
1.0/1.0 GPU

I will look into testing on multiple GPUs soon.

Great to hear! By the way, feel free to close this issue once you confirm that this problem is resolved.

Yes will close out after testing multi gpu single node and multi GPU multi node.

Closing this issue, but feel free to reopen if the fix did not work


Metal fix broken in 2.1

Polaris22MetalFixup.kext from 2.1/2.0 or complied myself nether works. Change OpenCore.efi to the one in 2.0 version, problem solved.

Reuploaded https://github.com/osy86/HaC-Mini/releases/tag/v2.1 with the old OC. I updated it without testing, sorry.


[Question] Handling chained promises / parsing fetch response

Hello. I'm really digging redux-saga, but have run into an issue with my response parsing. I just moved over to using fetch's text() and json() functions, which return promises, and now my try/catch blocks aren't working the way they used to. Here's an example.
The parser:
export function parseResponse(response : Object, emptyResponseExpected : ?boolean) : Promise {
	if (response && response.status) {
		if (response.status < 200 || response.status > 399) {
			console.log('[REJECT]', response);
			return response.text().then((text) => Promise.reject(parseJSONResponse(text)));
		}
		console.log('[RESOLVE]', response);
		return response.text().then((text) => Promise.resolve(parseJSONResponse(text)));
	}
	if (!response && !emptyResponseExpected) { return Promise.reject(response.status); }
	if (response && emptyResponseExpected) { return Promise.reject(response.status); }
	return response.text().then((text) => Promise.resolve(parseJSONResponse(text)));
}

The saga:
function* refreshToken() {
	const authToken = yield select(token);
	const config = { method: 'put', headers: { ...POST_HEADERS, Authorization: `Bearer ${authToken}` } };
	try {
		const response = yield call(callAPI, genRoute('/token'), config);
		yield put({ type: TOKEN_REFRESH_SUCCESS, response });
	} catch (error) {
		yield put({ type: TOKEN_REFRESH_FAILURE, error });
	}
}

CallAPI, for reference:
function* callAPI(route : string, config : Object, emptyResponseExpected : boolean = false) {
	return fetch(route, config).then(response => {
		return parseResponse(response, emptyResponseExpected);
	});
}

The console does output [REJECT], but I still put the TOKEN_REFRESH_SUCCESS type, with an undefined response. Maybe I'm overcomplicating things, but any help would be appreciated. I hope I come to better understand sagas by posting this.

If it helps at all, it works as expected when I use my parseResponseLegacy function, which is as follows:
const parseResponseLegacy = (response, emptyResponseExpected) => {
	if (response && response.status) {
		if (response.status < 200 || response.status > 399) {
			if (response._bodyText && response._bodyText.length
				&& response._bodyText.indexOf('<!DOCTYPE') === -1) {
				return Promise.reject(response._bodyText);
			}
			return Promise.reject(response.status);
		}
		if (response._bodyText && response._bodyText.length) {
			return Promise.resolve(JSON.parse(response._bodyText));
		}
		return Promise.resolve(response.status);
	}
	if (!response && !emptyResponseExpected) { return Promise.reject(response); }
	if (response && emptyResponseExpected) { return Promise.reject(response); }
	return Promise.resolve(response);
};

redux-saga just attaches a promise.then(onResolve, onReject) when handling promise responses. If it puts a TOKEN_REFRESH_SUCCESS it's likely because it gets a promise resolved with undefined.
You may to try attach a handler to `parseResponse(...)
function* callAPI(route : string, config : Object, emptyResponseExpected : boolean = false) {
    return fetch(route, config).then(response => {
        return parseResponse(response, emptyResponseExpected)
                    .then(logResolve, logReject)
    });
}

to check what outcome you get (resolve or reject)


Add lmdbxx package

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2962
https://travis-ci.org/ingenue/hunter/builds/313617104?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2966
https://travis-ci.org/ingenue/hunter/builds/313722622?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.188


Conditionally drop console messages from production build

Add a environment variable, DROP_CONSOLE, to specify if console
function calls should be dropped in the production build.
Supersedes https://github.com/facebook/create-react-app/pull/9221/

@eddiemonge @ianschmitz what are your thoughts on this?
I believe it addresses the concerns expressed in my earlier PR, and I think it would be a great improvement to CRA.
Thanks in advance!

This seems reasonable to me.
Another way I know of doing this on a per project basis is to create a logging utility function that wraps console call somewhat like this:
export const log = (...args) {
  if (process.env.NODE_ENV !== 'production') {
    console.log(...args);
  }
}

If the env is production then the code is removed at build time.

@iansu @amyrlam @mrmckeb @ianschmitz @petetnt Can you please take a look at this PR?
I believe that this approach to removing console statements from production builds is easy, safe, maintainable, and very much desirable for end users.
If there are further changes I can make to this PR to make it more acceptable and/or appealing, please let me know. I'm eager to get (or a functionally equivalent) change accepted.
Thanks again!

This PR would be welcomed by the community here
https://stackoverflow.com/questions/47839311/removing-log-statements-in-create-react-app-without-ejecting/53770988#53770988

Anything I can help with to progress this PR? My two cents... the code change is identical code style to the other environment checks such as shouldUseSourceMap.
I took a look at the two failing checks, but there is no detail on why they failed.

Just another note of support for this PR ... using the popular snippet if (dev) { console.log = () => {} } in a library module will unintentionally remove console.log messages in development mode for modules that use that library.

@ianschmitz @eddiemonge @mrmckeb @petetnt (and anyone else) can you please look at this PR? I believe it meets all requirements for a contribution and addresses an issue requested by CRA users. If there's anything I can do to move this along, please tell me - it's been a long time and I'd really like to see some progress (or at least feedback) on this PR.
Thank you in advance!

@ianschmitz Thanks for adding the tag new feature, just wondering does that indicate there an ETA for accepting/rejecting the PR? Next major release or something?

Any ETA on this? Would be nice to have this implemented guys

Bump

Can someone please review this

Another gentle nudge. Can someone from facebook (@ianschmitz ?) take a bit of time to approve / give feedback on this? It would be highly appreciated. Eject is not the way.

Just a quick update on this, I still get upvotes on my response to this issue on StackOverflow and the issue has over 10K views. Seems like this is still a relevant topic for some people, personally I've given up on this ever being actioned, but would be nice to have some closure here one way or the other so we can all move on. https://stackoverflow.com/questions/47839311/removing-log-statements-in-create-react-app-without-ejecting/53770988#53770988

@jackblackevo @matrush @rvdende @danielrentz @sdarnadeem @pawelskowronek @nvh95 @JSLGeeganage and anyone else - can you please review this (simple) MR and let us know what needs to be done to merge it, or why it cannot be mergeable?


Update README

Update readme in such a way that someone could follow the instructions to clone the repo and have a running local version of OpenMissouri using the steps in the README. README should include the TBD (MIT we think) license and also some information about the funding provided by RJI and subsequent copyright on parts of the code.

Jamie Stephens cleaned up the readme, but we still could use help in fleshing it out.


feat!: allow for hardcoded upgrade schedules

This PR implements the protocol work behind ADR018. After several iterations I have come across a design which I think best meets our requirements. I will need to update the ADR afterwards.
This still relies on a hardcoded upgrade schedule but rather than simply upgrading at that height through EndBlocker, a proposer will modify the proposed block of the height before with a message indicating a version change. Nodes will vote on that version change in ProcessProposal. If 2/3+ support that app version then the proposal will pass and the block be committed. In the following height the upgraded nodes will perform the state migration if any and propose a block corresponding to that new app version. Nodes that don't support that app version will panic in DeliverTx.

Codecov Report

Merging #2583 (53ccf5e) into main (a3d2453) will decrease coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   20.64%   20.63%   -0.02%
==========================================
  Files         132      132
  Lines       15334    15340       +6
==========================================
- Hits         3166     3165       -1
- Misses      11865    11872       +7
  Partials      303      303

Files
Coverage Δ

test/tokenfilter/setup.go
100.00% <100.00%> (ø)

app/app.go
4.47% <0.00%> (-0.06%)
:arrow_down:

... and 2 files with indirect coverage changes

Certainly not suggesting we change this in this PR, with a more complex signalling mechanism we might want to consider only proceeding with the upgrade if more than some fraction greater than 2/3 signal their readiness.

With a more complex signalling mechanism, we might want to consider only proceeding with the upgrade if more than some fraction greater than 2/3 signal their readiness.

Yeah I also thought about this but theoretically since it only takes 2/3 to approve the block then only 2/3 are necessary to signal the upgrade. What we could do is inject some delay but I don't think it's necessary.
Another idea is to have a more intelligent downgrade mechanism. If we're not reaching consensus across multiple rounds then a validator should be free to propose a lower version that might get the quorum required. While I've thought a little about downgrades, they haven't yet been properly addressed and should do in the future


generate .crt too

the generate_ssl.sh script was only generating the .key files, not the .crt too.  Modified it to create both. There are probably other ways of doing this too.

Hi,
Thank you for the PR, though there are other tasks that has to be done before merging it. As you changed the extensions of files you forgot to propagate this though code and .gitignore.
Probably that's the reason behind failing tests too.


Can`t slide ion-item-option after reorder ion-item

Bug Report
Ionic version:

[x] 4.x
Current behavior:

If an <ion-item-sliding> is dragged down in <ion-list>, it is possible to slide <ion-item-options>. But if the item is dragged up in the list, sliding is no longer possible.

Expected behavior:

Sliding should still be possible if the item is dragged up in the list
Steps to reproduce:
See gif above
Related code:

<ion-list>
  <ion-reorder-group (ionItemReorder)="reorderConfigurationsList($event)" disabled="false">
    <ion-item-sliding *ngFor="let configuration of _configurationsList">
      <ion-item lines="full" color="white">
        <ion-label>
          <h2>{{configuration.name}}</h2>
          <ion-note>Created: {{ configuration.created | date: 'MM/dd/yy HH:mm' }}</ion-note>
        </ion-label>
        <ion-reorder slot="end"></ion-reorder>
      </ion-item>
      <ion-item-options side="start">
        <ion-item-option>Favorite</ion-item-option>
        <ion-item-option color="danger">Share</ion-item-option>
      </ion-item-options>
      <ion-item-options side="end">
        <ion-item-option>Unread</ion-item-option>
      </ion-item-options>
    </ion-item-sliding>
  </ion-reorder-group>
</ion-list>

reorderConfigurationsList(ev) {
    const itemToMove = this._configurationsList.splice(ev.detail.from, 1 ) [0];
    this._configurationsList.splice(ev.detail.to, 0, itemToMove );
    ev.detail.complete();
  }

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.12.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.1.2
   @angular-devkit/build-angular : 0.13.6
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.3.6
   @ionic/angular-toolkit        : 1.4.1

Cordova:

   cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms     : none
   Cordova Plugins       : no whitelisted plugins (0 plugins total)

System:

   ios-sim : 8.0.0
   NodeJS  : v10.15.3 (/usr/local/bin/node)
   npm     : 6.9.0
   OS      : macOS Mojave
   Xcode   : Xcode 10.2 Build version 10E125

Hi there,
Thanks for the issue. Can you provide a repository with the code required to reproduce this issue? I am unable to reproduce it with the code snippet you provided.
Thanks!

Hi there,
Thanks for the issue. Can you provide a repository with the code required to reproduce this issue? I am unable to reproduce it with the code snippet you provided.
Thanks!

Of course. https://github.com/alperbalkaya/ionicReorderBug

Thanks for the follow up.
I have been investigating this issue and have a couple observations:

When sliding the item up, componentDidUnload is being called on the ion-item-sliding that was moved. This is causing any gesture listeners on the element to be destroyed (including the listener that lets you reveal the sliding options).
After componentDidUnload is called, there are still 3 items in the DOM (there were 3 to begin with). One would assume that the re-ordered item was destroyed and then re-created, but componentDidLoad was never fired. So I'm not sure if that means a) the component was firing componentDidUnload when it should not have been or b) the component was being re-created but not firing componentDidLoad when it should have been. (it also could be another case I'm not even thinking of 🙂)

I'm going to continue to dig into this, but just wanted to keep you in the loop.
Thanks!

Hi everyone,
There are some changes to Stencil actively being worked on that we think may resolve this issue. I am going to do some testing with it later this week and will post here when I have an update.
Thanks!

@liamdebeasi Any update here?

Hi @alperbalkaya,
The Stencil updates need a little bit more time to be worked. When I have another update I will post it here.
Thanks!

Yes fix would be awesome. Current workaround is changing the list reference -JSON.parse(JSON.stringify(list)) - which forces a rerender

I've posted some kind of solution that worked for me, don't know if is what you are looking for, but with the same issue I managed it to work as described in this recent comment, on 23 april 2019:
https://github.com/ionic-team/ionic/issues/16120

Issue also appears when using reorder group inside another reorder group.

c

Just for information, I have a similar issue. In my case I have an ion-range slider in the ion-item being reordered, When I reorder and change the underlying array (ie: ev.detail.complete(this.myArray);), the slider freezes.  nb: this behavior does not manifest itself when just calling ev.detail.complete().

I have the same issue

Yes fix would be awesome. Current workaround is changing the list reference -JSON.parse(JSON.stringify(list)) - which forces a rerender

I can confirm that this is a valid workaround. However, the whole list "blinks" for a short moment because for some reason, redrawing in Ionic is not as smooth as with Angular.

Thanks for the issue! I was able to test out the latest Ionic with the update to Stencil One and confirmed it is still an issue in 4.6.2 and latest.

I have the same issue.

Yes fix would be awesome. Current workaround is changing the list reference -JSON.parse(JSON.stringify(list)) - which forces a rerender

I can confirm that this is a valid workaround. However, the whole list "blinks" for a short moment because for some reason, redrawing in Ionic is not as smooth as with Angular.
Thanks.

At present, in 4.12.0, there is still this problem, there is no final solution?
@liamdebeasi

@Wilsonoonn This issue was fixed and will be available in the next stable release of Ionic. For any new bug, I recommend creating a new issue.


Consider adding telegram Notification ?

Hi,
Woud you consider adding a telegram notification when a buy or sell occurs ?
I'll quickly try and edit your code with these easy steps:
import telegram_send
...
if a buy signal
        if action == 'BUY':
            telegram_send.send(messages=["BUY SIGNAL Market xxxxxxxx"])

...
# if a sell signal
elif action == 'SELL':
telegram_send.send(messages=["SEL SIGNAL Market xxxxx"])
Of course it requires setting your own bot before :
https://medium.com/@robertbracco1/how-to-write-a-telegram-bot-to-send-messages-with-python-bcdf45d0a580
Let me know whatyou think,
thanks

Sounds like a great feature. I'll add it as an option. Thanks

If you add your Telegram token and client_id to the config.json you will receive updates.
{
    "coinbasepro" : {
        "api_url" : "https://api.pro.coinbase.com",
        "api_key" : "",
        "api_secret" : "",
        "api_passphrase" : "",
        "config" : {
            "base_currency" : "BTC",
            "quote_currency" : "GBP",
            "live" : 1,
            "sellatloss" : 0
        }
    },
    "telegram" : {
        "token" : "",
        "client_id" : ""
    }
}


vmware workstation and device/credential guard are not compatible

When running VMWare, I got the message "vmware workstation and device/credential guard are not compatible"
Is this script related and if so, what to edit?

Never tested on VMWare. Only within Hyper-V. Need to Google.

https://kb.vmware.com/s/article/2146361


Scan packages in parallel

Instead of scanning one package at a time, scan GOMAXPROCS at a time.

Before:

After:


Add dev-toolkit Alternative

Adds the dev-toolkit npm package to the list of Alternatives.
I think it's awesome to finally see an official solution to what people have been asking for! So thanks a lot for that! :)
Sidenote:
Since I've needed something like create-react-app, I built something quite similar to this project and although its sibling/cousin starter-project dev-toolkit-starter still has a few babel-dependencies, I'm trying to find a way to remove them. The dev-toolkit-starter is similar to what you get after using create-react-app my-app. Any ideas how I can remove those dependencies? You guys seem to have gotten rid of them quite easily.
Quick list of features:

ES2015 / ES6
root-relative imports
Vanilla HMR
Browsersync
ESLint
React
jsx-control-statements
sass / scss
css-modules
Autoprefixer
classnames
express
react-router

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Hi! I think we won’t merge something that asks to be cloned—we are specifically compiling a list of tools that can be used by themselves so that users get benefits of version updates, don’t have to clone a project, etc.

Any ideas how I can remove those dependencies? You guys seem to have gotten rid of them quite easily.

If you have specific questions feel free to ask but Create React App is open source 😉 .
Take a look if you’re wondering how it works.

Fair enough. I thought it might be more straightforward to clone a starter-repo that already has the dependency instead of using a command.
@gaearon Is it ok if I resubmit after making some changes?

Sure! It's not super obvious that this is not a boilerplate with a lot of dependencies. If it's not please could you make it a bit clearer in README?

of course! thanks for the feedback :smile:
I'm changing it so that it uses a command dev-toolkit init to intitialize a starting point and add more information to the readme. Will make another PR after that's done.


Unable to get react-quill 0.3.0 working with react 0.12.1

I'm running React.js 0.12.1 and upgrading to 0.13 or 0.14 is not possible at this time.
I tried installing react-quill via "npm install react-quill". Version 0.3.0 was installed and, looking at react-quill\package.json, the devDependency for react is "^0.12.0".
When I use react-quill as follows in my React component, I get the warning, "Warning: Something is calling a React component directly. Use a factory or JSX instead" from react-with-addons.js, followed by the error _"Uncaught TypeError: Cannot read property '_reactAutoBindMap' of null" from ReactClass.sj.
var ReactQuill = require('react-quill');
var MyComponent = React.createClass({
    render: function() {
        return <ReactQuill value="hi" />;
    }
);

As you can see, I am using JSX.
I saw some discussion on removing React 0.12 support at some point. Does react-quill 0.3.0 still support React 0.12?

Yes, React 0.12 will still be supported up until next version, when support for React 0.14 will be merged in, and support for React 0.13 and less will be dropped.
ReactQuill already uses React.createFactory throughout to support React 0.12, though, so I believe there's something else at play here. I'll try and see if I can reproduce.


Setting user agent on loginview

Is seems that there isn't any possibility to change the user agent of login web view. Today my application got rejected due to the webview having a "Find it for free on Google Play" header on Instagram login page, due to Android user-agent of the wkwebview.

Definitely something we could implement.
Feel free to push a PR, if it's urgent, cause I'm not sure when I can get down to it 😊
Still, please keep in mind that WKWebView based authentication, like LoginWebView is, requiring full access to a third party user account through cookies is usually not allowed in the App Store, and might be caused for rejection, Android banner or not.

I've added support for this in #156.
It'll be merged to master as soon as @TheM4hd1 reviews it 😊💪


docs(api/useFetchers): typo fix

Hey there! 👋
Micro adjustment to the useFetchers docs.
Appreciate all the stellar work on Remix!! 🙌

Thank you!


TextField not Auto-Scrolling on Append

I'm currently using the Python Flet library and have noticed that when I append new text to multiple textfields, the TextField does not auto-scroll to show the newly added content. This makes it difficult to see the most recent updates without manually scrolling through the entire textfield.
Steps to Reproduce:
Create a TextField object
Add some initial text
Append new text to the TextField object
Notice that the textfield does not auto-scroll to show the new content
Expected Behavior:
When new text is appended to a TextField object, the view should automatically scroll to show the newest content at the bottom of the textfield.
Actual Behavior:
The TextField does not auto-scroll to show the newly added content, making it difficult to see the most recent updates without manually scrolling through the entire textfield.
Possible Solution:
One possible solution could be to implement a function that checks the length of the text in the TextField before and after appending new text, and if the length has increased, automatically scroll to the bottom of the TextField to display the new content.
Thanks for your help in addressing this issue!

Please attach some code and captures to your issue. I don't seem to understand what you mean.

like this：
after I appended a lot of lines in TextField object，in order to see the new lines, I only scroll to the bottom in the TextField by myself
,it`s very diffcult to use

The TextField has an auto scroll for manual/typed text input. No idea on how to cause this for your use case.


[FEATURE REQ] Add a CheckNameAvailability feature for Failover Group

Library or service name.
Microsoft.Azure.Management.Sql.Fluent
Is your feature request related to a problem? Please describe.
The Azure SDK and Azure REST api does not have a feature that checks the name of a failovergroup if it is already taken, and it should have since failovergroup names are globally unique.

Since this was filed, the Microsoft.Azure.Management.Sql.Fluent library has been deprecated and is currently only receiving critical security fixes.   Closing this out.


Dummy e2e Test

Basic and dummy E2E test which only creates CR, verify it was created and then deletes it. The FAR CR is not running any FA, and only echo an empty string -> echo " "
This way we can catch installation/running errors, such as #26, because deployment would fail until we add functionality of E2E test in #20.

/lgtm
/hold
left 2 nits, feel free to fix/unhold

/unhold


Add user guide

As a new user, I can view the user guide easily so that I can learn more about the product as and when I need.

@pangrwa could you help me delete this issue


switch the hardware and software trigger

Hello Everyone,
does someone know, that if is it possible to switch the Hardware and software setting?
For example, that I set the AcquisitionMode to 'SingleFrame' and the Matrix Vision Camera can already take photo, once I call the image_acquirer.start_acquisition(). And I set the following features for NodeMap
remote_device.node_map.TriggerSelector.value = 'FrameSelector'
remote_device.node_map.TriggerMode.value = 'on'
remote_device.node_map.TriggerSource.value = 'Line4'
remote_device.node_map.TriggerActivation.value = RisingEdge
If I call the start_acquisition() again after setting the features, the camera should wait for a hardware trigger, and give me a image back.
What if I want to switch reset the hardware feature setting and back to the normal Software trigger. The camera give me a image right after I call start_acquisition() ? Is that possible in genicam or in harvesters?
I have tried to set the remote_device.node_map.TriggerSelector.value = '' and set it to None. Both of them are not allowed.
Thank you

Hi, first, you'd need to set up the following features:
remote_device.node_map.TriggerSelector.value = 'FrameSelector'  # you can change this depending your use case.
remote_device.node_map.TriggerActivation.value = 'RisingEdge'
remote_device.node_map.TriggerMode.value = 'On'

Then, you would back and forth between the hardware trigger and the software trigger with:
remote_device.node_map.TriggerSource.value = 'Line4'

And:
remote_device.node_map.TriggerSource.value = 'Software'

While the device is working with the software trigger, you will trigger the device with the following line:
remote_device.node_map.TriggerSoftware.execute()

To get further in-depth knowledge I would recommend you to check out SFNC that is a collection of feature names and those definitions. You can download the latest version at here.
Good luck, Kazunari

The camera give me a image right after I call start_acquisition() ?
If you set AcquisitionStart to TriggerSelector then you can get an image by calling fetch_buffer(). Please try to read through this tutorial to get the outline.

Hello @kazunarikudo,
I have tried the another way, I have set the remote_device.node_map.TriggerMode.value = 'On' to 'Off' to switch the mode to Software. I have tried with the mvPropView, a software from  Matrix Vision.
Thank you.
And thank you for making harversters Lib for us.
I hope, the support for arm64 is coming soon in this year.


The section on "return values" should explain expression bodied members

Type of issue
Missing information
Description
The text for return values discuss the return keyword, but the samples are mostly expression bodied members. Their should be an example with a statement body and a return statement. And, the text should explain that expression bodied members return the value returned by the expression.
Page URL
https://learn.microsoft.com/en-us/dotnet/csharp/methods
Content source URL
https://github.com/dotnet/docs/blob/main/docs/csharp/methods.md
Document Version Independent Id
6386f636-99b3-93c3-ca9e-0134f3e3be10
Article author
@BillWagner
Metadata

ID: 158425f1-86b1-101a-9172-14c944867784
Service: dotnet-csharp
Sub-service: fundamentals

Hi @BillWagner, I'd like to pick this up

Hi @bigboybamo
I've assigned it to you

Hi @BillWagner I have opened a PR #41636


Lowercase JSON/YAML keys of Test.Status and Error

I've also filed #18, #19 to call out some related problems with marshalling.


During init:  Got response in unexpected format when fetching metadata. Please try again.

Describe the bug
After logging in and scrolling through the boards, I choose my board and get:
" Got response in unexpected format when fetching metadata. Please try again."
The same happens when I choose "None" for default board.
Please provide following details

JiraCLI Version:

(Version="1.5.1", GitCommit="0e0f82d52ef5a775d2cc662fbe38d9732b9b5c59", CommitDate="2024-01-20T10:48:06+00:00", GoVersion="go1.21.5", Compiler="gc", Platform="darwin/arm64")
2. Are you using Jira cloud or on-premise jira server?
This isn't available since I can't get past the init stage.  We're on Cloud
3. What operating system are you using? Also mention version.
MacOS Sonoma Version 14.5 (23F79)    4. What terminal are you using? Also mention version.
MacOS Terminal Version 2.14 (453)    ```
To Reproduce
Steps to reproduce the behavior:

run jira init --debug --server https://nope.atlassian.net --installation cloud --login<EMAIL_ADDRESS>Select default project: EE
fail

Expected behavior
Take me to the board/issues.
Screenshots

Additional context

A little more information. This is what the API returns whether I choose a default board or None:
#curl --request GET   --url 'https://nope.atlassian.net/rest/api/2/issue/createmeta?projectKeys=EE&expand=projects.issuetypes.fields'   --user "`me@nope.com:$JIRA_API_TOKEN"   --header 'Accept: application/json'
{"expand":"projects","projects":[]}

Try passing the --project <project> --board <board> flags as well.
$ JIRA_API_TOKEN=$(echo -e "$JIRA_API_TOKEN") jira init \
    --installation cloud \
    --server <url> \
    --login <email> \
    --project <project> \
    --board <board> \
    --debug

I'm able to auth via an automated script successfully without and prompts for input using this method. In my case, I also had to echo the API key with escaping (-e) to get the Jira API token to be read properly because it runs in kubernetes.


sf plugin migration guide is missing

Summary
Migration guide link in README.md of https://github.com/salesforcecli/command points to wiki page that does not exist.
Steps To Reproduce:

Open https://github.com/salesforcecli/command in browser
Scroll down README.md and find paragraph "A migration guide is provided in the sf wiki..." and click the link to open the guide

Expected result
The migration guide URL (https://github.com/salesforcecli/cli/wiki/Migrate-Plugins-Built-For-Sfdx) would exist, with the page showing instructions on how to migrate my old sfdx plugin to an sf plugin.
Actual result
The URL https://github.com/salesforcecli/cli/wiki/Migrate-Plugins-Built-For-Sfdx  redirects to https://github.com/salesforcecli/cli/wiki/ and there does not seem to be a migration guide link in the table of contents.

Thanks for letting us know about this -- I see now that we mistakenly deleted some pages from the WIKI without realizing it!  We're working furiously to get 'em back.  Stay tuned!

@alan-morey , the page is back.  Thanks again for letting us know!


Background Remover

Description of the new feature / enhancement
Background Remover for image files from right click context menu
Scenario when this would be used?
from right click context menu
Supporting information
iOS's Files App have this kind of feature

Hi @coolgujju4u
Can you elaborate on this?

/needinfo
is it you just want a solid color?

Thanks for replying Please check below article as per macOS for idea which I was trying to explain. How to remove the background from an image on an iPhone or Maczapier.comThank youParesh BhatiaOn 21-Aug-2023, at 7:36 PM, Clint Rutkas @.***> wrote:
/needinfo
is it you just want a solid color?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Oh!  So like get a person or dog out of an image and put that on the clipboard?
/needinfo

Neat idea but not something powertoys would build.


Not working on android

My code working on iOS but not working on android
ActionSheet.options({
options: [
{ text: Strings.report_fake, onPress: () => this.doComplainPost(GlobalVariables.FAKE) },
{
text: Strings.report_duplicate,
onPress: () => this.doComplainPost(GlobalVariables.DUPLICATE),
},
{
text: Strings.report_inappropriate,
onPress: () => this.doComplainPost(GlobalVariables.INAPPROPRIATE),
},
],
cancel: { onPress: () => console.log('cancel') },
})
Error message is
[Unhandled promise rejection: TypeError: null is not an object (evaluating '_ActionSheetAndroidModule.ActionSheetAndroidModule.options')]

node_modules/react-native-cross-actionsheet/src/ActionSheet.js:16:43 in __awaiter$argument_3
node_modules/regenerator-runtime/runtime.js:45:44 in tryCatch
node_modules/regenerator-runtime/runtime.js:274:30 in invoke

http://<IP_ADDRESS>:19001/App.bundle?platform=android&dev=true&minify=false&hot=false:200976:75 in

node_modules/promise/setimmediate/core.js:45:7 in tryCallTwo
node_modules/promise/setimmediate/core.js:200:23 in doResolve
node_modules/promise/setimmediate/core.js:66:12 in Promise

@MehrozeYaqoob @aelesia Did you ever find a solution to this? I'm also running into the same issue.

Nope. I eventually had to look for an alternative library

@MehrozeYaqoob What alt library did you use? I can't seem to find one that I can drop in as easily.

I used react-native-actionsheet. :)

Awesome! Thanks!


Automatic micro-testing

As we are heading toward delivering a production-ready database, the micro testing frameworks can be used to ensure that we have covered as many cases as possible.  In the meantime, we will conduct manual testing (or "stress testing") and observe the key metrics when processing several selected queries in order to ensure that the system does not behave unexpectedly, such as OOM, under a relatively high level of load. Yet, the manual testing steps are not the topic of this issue.
Source micro-testing framework
Source reading/parsing
The parsing part will be more deterministic than the rest. We need to generate random data in a specific format (with a probability of generating false data, the expected behavior is to drop it) and verify the correctness of the parsed output.

[ ] MockSource x Protobuf
[ ] MockSource x JSON https://github.com/risingwavelabs/risingwave/pull/5512
[ ] MockSource x Debezium JSON
[ ] MockSource x Avro

Failover
In this test, we need to ensure that RisingWave can achieve at-least-once delivery. There must be no data loss or wrong data ordering. The program will include a Meta and a simplified CN, which only runs a wrapped SourceExecutor that consumes the upstream and checks the data ordering. When the CN receives a periodic barrier, it flushes its state to ensure that no data older than the checkpointed offset has been consumed. Also, there shouldn’t be a hole (gap) between the consumed data and the new incoming data. The checking can be implemented as debug_assert, which can be turned off on production (or enabled if necessary).
The simplified CN will be killed periodically, like for 30s at a time. We can run the testing daily, each for 1h.

[x] #5221
NOTE: Kafka/Redpanda is the highest priority
[ ] Kinesis x JSON
[ ] Pulsar x JSON (Partition number: 16, Parallelism: 4)

SQL testing

[ ] Now that we have sqlogictest and sqlsmith, the stability of our SQL support has been quite satisfying.
The issues are tracked in https://github.com/risingwavelabs/risingwave/issues/3896

Hummock testing
Compaction / Vacuum
We will conduct four types of test to improve compaction/vacuum coverage:

[x]  Functionality test. Target coverage ≥ 85%.

Compaction/vacuum task generation (i.e. compaction strategy) https://github.com/risingwavelabs/risingwave/pull/5208
Compaction/vacuum task scheduling and assignment https://github.com/risingwavelabs/risingwave/pull/5240
Compaction worker logic (build SST, compaction filter, bloom filter generation, …)

[x]  Deterministic replay Hummock MANIFEST. We will have a framework implemented to reply Hummock MANIFEST to verify foreground reads produce the same result before and after compaction. https://github.com/risingwavelabs/risingwave/issues/5464
[ ]  (Write-only) Stress test. We will verify the whole compaction process can sustain under reasonable stress without crashing by putting excessive write load into RisingWave.

Read-path
The testing can be covered by batch-query testing.
Batch-query testing
The motivation is to verify the query correctness and the stability of the query path while querying a large dataset.
The approach is to first generate the dataset via tpch and ch-benchmark and load the data into both Postgres and RisingWave. The Postgres is used as a source of truth. We will then perform different queries and compare the query results of both databases.
Streaming testing
Deterministic testing
By the end of 9/30, we will heavily rely on MadSim for testing the streaming execution since it’s currently the most effective way to achieve high coverage. The development plan:

[x]  Enable mocking Etcd RPC https://github.com/risingwavelabs/risingwave/pull/5084
[x]  Enable mocking S3 https://github.com/risingwavelabs/risingwave/issues/5161
[x] Enable mocking Kafka https://github.com/risingwavelabs/risingwave/issues/5181
[x]  Recovery testing: The basic idea is to set up a madsim cluster that will randomly kill one of the instances, and while consuming the source, the service must remain available after recovery. After it finishes processing, there will be a checker to verify if the computation results are correct. #7623

Sink testing
TBD

Hi @neverchanje Any updates or future plan on this? It has been silent for a few months and I am considering to close it...

Okay. The S3 simulator is under final review and integration. https://github.com/madsim-rs/madsim/pull/107. Will close this issue when it is done.

I'm closing this issue as the main work on simulation testing is done.


some SPDX json generated from Syft doesn't include DocumentName

Some SPDX json generated from Syft doesn't include DocumentName. This is not in accordance to the SPDX spec (https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#64-document-name-field)...
Unfortunately, I am not able to share these SBOMs, but they were generated by Syft.

I ran into a similar issue today where my spdx-json file had a name of ./ which resulted in a segfault:
$ bin/guacone collect files ./spdx.json
{"level":"info","ts":1687301853.469325,"caller":"cli/init.go:53","msg":"Using config file: /Users/jonzeolla/src/jonzeolla/guac/guac.yaml"}
{"level":"info","ts":1687301853.6743119,"caller":"parser/parser.go:126","msg":"parsing document tree with root type: SPDX"}
{"level":"error","ts":1687301853.750566,"caller":"collector/collector.go:89","msg":"emit error: unable to ingest doc tree: unable to parse purl pkg:guac/spdx/./: name is required","stacktrace":"github.com/guacsec/guac/pkg/handler/collector.Collect\n\t/Users/jonzeolla/src/jonzeolla/guac/pkg/handler/collector/collector.go:89\ngithub.com/guacsec/guac/cmd/guacone/cmd.glob..func5\n\t/Users/jonzeolla/src/jonzeolla/guac/cmd/guacone/cmd/files.go:181\ngithub.com/spf13/cobra.(*Command).execute\n\t/Users/jonzeolla/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:944\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/Users/jonzeolla/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068\ngithub.com/spf13/cobra.(*Command).Execute\n\t/Users/jonzeolla/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992\ngithub.com/guacsec/guac/cmd/guacone/cmd.Execute\n\t/Users/jonzeolla/src/jonzeolla/guac/cmd/guacone/cmd/root.go:51\nmain.main\n\t/Users/jonzeolla/src/jonzeolla/guac/cmd/guacone/main.go:23\nruntime.main\n\t/opt/homebrew/opt/go/libexec/src/runtime/proc.go:250"}

I worked around it by manually updating the name:
$ diff spdx.json spdx-modified.json
5c5
<  "name": "./",
---
>  "name": "example",

This seems to be on the syft backlog per https://github.com/anchore/syft/issues/1238

Resolved with #744


Invoke robocopy

Decided to rewrite it to use start-process. I was not at all happy with letting robocopy throw out error codes and trying to clean them up with exit 0. Pester doesn't like that either. This way there is far better control available. Right now it just spits out the errors in the log, but it could be even further refined in the future if that were necessary/wanted.
Let me know what you think.
Thanks! Have a good one!

Looks good to me, no complaints over 2 weeks, merge time!  Thanks for putting the time into this!


[ALGO] Prim's Minimum Spanning Tree

Prim's Minimum Spanning Tree
Prim's algorithm is a greedy algorithm which finds a minimum spanning tree for a (weighted) undirected graph. See the wikipedia entry for more details.
Syntax
The algorithm should have the following syntax:
/**
 * Computes the minimum spanning tree (MST) of a graph using Prim's algorithm.
 *
 * @tparam V The vertex type of the graph.
 * @tparam E The edge type of the graph.
 * @param graph The input graph.
 * @param start_vertex The starting vertex for the MST construction.
 * @return An optional containing a vector of edges forming the MST if it exists,
 *         or an empty optional if the MST doesn't exist (e.g., graph is not connected).
 */
template <typename V, typename E>
[[nodiscard]] std::optional<std::vector<typename graph<V, E, graph_type::UNDIRECTED>::edge_t>>
prim_minimum_spanning_tree(const graph<V, E, graph_type::UNDIRECTED>& graph, vertex_id_t start_vertex);

This should live in the graaf::algorithm namespace under include/graaflib/algorithm/minimum_spanning_tree.h.
Definition of Done
This issue is done when:

[ ] The algorithm is implemented
[ ] The new function has a javadoc-style comment explaining the interface
[ ] Appropriate tests are added under test/graaflib/algorithm/minimum_spanning_tree_test.cpp
[ ] A test coverage of at least 95% is reached
[ ] A documentation entry is added under docs/docs/algorithms under the appropriate category

Just adding a short description and the algorithm syntax here is fine
See the wiki on how to build the documentation locally

[ ] The algorithm is added to the list of algorithms in README.md

Hey can i work on this issue?

Hey can i work on this issue?

Hi, this has been in progress for quite some 😬
All logic should already be there, so I will aim to finish up the tests this week and open the PR.
I hope the other issue regarding negative weight cycles looks interesting to you as well. If you have any proposals for new algorithms to implement, feel free to open an issue or discuss it on our discord. I will create new algorithm tickets coming week as well.


Update breakpoints.md

[ ] I have followed (at least) the PR section of the contributing guide.

@Hossein5727 This looks like a mistake, I'm closing.


Minor typo in CONTRIBUTING.md

A spelling mistake - Milesstone > Milestone

[approve ci]

[approve ci autest]

Thanks!


#fatemeh-set up- server

Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
Write a summary of your change. Explain why you have made it.
Related to
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
add env file, and install psql. the project is ready to run
Fixes #1
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have carefully reviewed my own code
[ ] I have commented my code
[ ] I have updated any documentation

I think you intended to make this to your team repo
(Also it looks like you're trying to add an additional React app in the frontend/ directory, which doesn't make sense - there's already one in client/.)


Proxy Issues?

When I attempt to pull up certain commands in Wat, such as vantage auth or vantage firewall reject, I get this:
Unexpected Error:  { [Error: connect ECONNREFUSED]
  code: 'ECONNREFUSED',
  errno: 'ECONNREFUSED',
  syscall: 'connect' }

My internet is going via an HTTP proxy set in the OSX system settings, and I'm guessing that this may be the issue.  Any thoughts?  (If it's just a lack of implementation, and you point me to the code in question, I may be able to try some stuff out.)

Right on. I have to do some research on using system proxy settings. Should probably be pretty simple. It's on the 1.0 list.

I allowed for setting a custom proxy in Wat. There's two supported commands now:
proxy add
proxy remove

Great!  Thanks :)


Add support for CH32V20x

Includes CH32V203, 208.

All CH32V20xxx board definitions were auto-generated and added, waiting for hardware to confirm working state.


install

Hi，I find the web page of the wigwam is a mistake. please you could provide a correct web page.

I think below is the link:
https://github.com/vadimkantorov/wigwam


Incorrect validation message at admin end

Title
When you edit admin's profile and try to change the password. And when you leave New Password and Confirm New Password blank. And insert your current password, The flash warning shows that your changes are saved.
Preconditions
1. framework branch: Master

Steps to reproduce
1. Edit Admin Profile.
2. Go to change password panel.
3. Now leave the new password and confirm password as blank and only put your current password.
4. Save it

Expected result

It must show a warning that the rest two columns can't be left blank

Actual result

If admin does not enter any value in password and confirm password field, it will not be considered as admin is trying to change password,  if you are leaving blank these field that means you are only updating either Name or Email.

Then there should be an asterisk on current password column it should be a required field.


How do you use result of ivy-report ?

How do you use result of ivy-report ? It's unclear from documentation.
I tried
sbt show ivy-report
and
show ivy-report
in bash.

This is just a helper key. You would usually use dependency-tree. Is that what you are looking for?

Ah I see. Nah, I was curious if this command gives me URLs from which each particular dependency was downloaded from.
Some of my team members (on Debian and Mac) machines had odd problems when few of the dependencies were failing on download because Ivy was (for some reason) was adding name of the machine to URL. It basically looked like this
M[info] Resolving xpp3#xpp3;working@tardis ...
[warn] 	module not found: xpp3#xpp3;working@tardis
[warn] ==== local: tried
[warn] <EMAIL_ADDRESS>[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/xpp3/xpp3/working<EMAIL_ADDRESS>[warn] ==== spray releases: tried
[warn]   http://repo.spray.io/xpp3/xpp3/working<EMAIL_ADDRESS>[warn] ==== spray nightlies: tried
[warn]   http://nightlies.spray.io/xpp3/xpp3/working<EMAIL_ADDRESS>[warn] ==== jasperreports: tried
[warn]   http://jasperreports.sourceforge.net/maven2/xpp3/xpp3/working<EMAIL_ADDRESS>[info] Resolving org.jibx#jibx-bind;1.2.5 ...

Closing for now... If there is still something to do here, please reopen.


Add Password Recovery

The build failed at ./app/api/auth/[...nextauth]/route.ts:23:13 but the code in that file is exactly the same as in main. Was the Github build check changed?

@blickly, can you take a look at why the build is failing now? The error logs show a type error but not sure how it was introduced.
[00:03:40.437] Running build in Washington, D.C., USA (East) – iad1
[00:03:40.529] Cloning github.com/aimpowered/LibOrate (Branch: 56-password-recovery, Commit: 9c70be9)
[00:03:40.853] Cloning completed: 323ms
[00:03:50.185] Restored build cache from previous deployment (3SswhHqiBzpyXWc7UuYvigyhXZf7)
[00:03:50.263] Running "vercel build"
[00:03:51.430] Vercel CLI 37.12.0
[00:03:52.016] Installing dependencies...
[00:03:56.715] npm warn deprecated<EMAIL_ADDRESS>Use @eslint/config-array instead
[00:03:56.838] npm warn deprecated<EMAIL_ADDRESS>Use @eslint/object-schema instead
[00:03:58.484] npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
[00:04:02.284] npm warn deprecated<EMAIL_ADDRESS>This version is no longer supported. Please see https://eslint.org/version-support for other options.
[00:04:15.185]
[00:04:15.185] added 368 packages, removed 125 packages, and changed 354 packages in 23s
[00:04:15.185]
[00:04:15.185] 203 packages are looking for funding
[00:04:15.186]   run `npm fund` for details
[00:04:15.218] Detected Next.js version: 14.2.16
[00:04:15.233] Running "npm run build"
[00:04:15.415]
[00:04:15.415] ><EMAIL_ADDRESS>build
[00:04:15.415] > next build
[00:04:15.415]
[00:04:16.280]   ▲ Next.js 14.2.16
[00:04:16.281]   - Experiments (use with caution):
[00:04:16.281]     · missingSuspenseWithCSRBailout
[00:04:16.281]
[00:04:16.365]    Creating an optimized production build ...
[00:04:39.145]  ✓ Compiled successfully
[00:04:39.145]    Linting and checking validity of types ...
[00:04:47.493] Failed to compile.
[00:04:47.493]
[00:04:47.493] ./app/api/auth/[...nextauth]/route.ts:23:13
[00:04:47.493] Type error: Type '(credentials: Record<never, string> | undefined, req: Pick<RequestInternal, "method" | "body" | "headers" | "query">) => Promise<{ email: string; role: "user" | "admin"; id: unknown; }>' is not assignable to type '(credentials: Record<never, string> | undefined, req: Pick<RequestInternal, "method" | "body" | "headers" | "query">) => Awaitable<User | null>'.
[00:04:47.493]   Type 'Promise<{ email: string; role: "user" | "admin"; id: unknown; }>' is not assignable to type 'Awaitable<User | null>'.
[00:04:47.493]     Type 'Promise<{ email: string; role: "user" | "admin"; id: unknown; }>' is not assignable to type 'PromiseLike<User | null>'.
[00:04:47.493]       Types of property 'then' are incompatible.
[00:04:47.493]         Type '<TResult1 = { email: string; role: "user" | "admin"; id: unknown; }, TResult2 = never>(onfulfilled?: ((value: { email: string; role: "user" | "admin"; id: unknown; }) => TResult1 | PromiseLike<TResult1>) | null | undefined, onrejected?: ((reason: any) => TResult2 | PromiseLike<...>) | ... 1 more ... | undefined) => ...' is not assignable to type '<TResult1 = User | null, TResult2 = never>(onfulfilled?: ((value: User | null) => TResult1 | PromiseLike<TResult1>) | null | undefined, onrejected?: ((reason: any) => TResult2 | PromiseLike<...>) | null | undefined) => PromiseLike<...>'.
[00:04:47.493]           Types of parameters 'onfulfilled' and 'onfulfilled' are incompatible.
[00:04:47.494]             Types of parameters 'value' and 'value' are incompatible.
[00:04:47.494]               Type '{ email: string; role: "user" | "admin"; id: unknown; }' is not assignable to type 'User'.
[00:04:47.494]                 Types of property 'id' are incompatible.
[00:04:47.494]                   Type 'unknown' is not assignable to type 'string'.
[00:04:47.494]
[00:04:47.494]   21 |       type: "credentials",
[00:04:47.494]   22 |       credentials: {},
[00:04:47.494] > 23 |       async authorize(credentials, req) {
[00:04:47.494]      |             ^
[00:04:47.494]   24 |         const { email, password } = credentials as {
[00:04:47.494]   25 |           email: string;
[00:04:47.494]   26 |           password: string;
[00:04:47.554] Error: Command "npm run build" exited with 1
[00:04:48.267]


[Bug] Split mode doesn't work with Clip tool

Clip tool doesn't split brushes, and it's making a invisible brush.
RealtimeCSG 1.308

Confirmed, thanks for reporting. I'll get a fix out asap

This issue is fixed in version 1.309 which is available on the update site
( http://prenominal.nl/updates/index.php )
I will close this ticket when it's available on the asset store

I forgot report about how to make invisible brush.

Ah, ok :-/ Thanks for reporting this

This issue is fixed in version 1.312 which is available on the update site!
( http://prenominal.nl/updates/index.php )
I will close this ticket when it's available on the asset store

Fix is in the version that's on the asset store now, so closing ticket


Ion-Slides Coverflow Warping

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x ] 3.x
I'm submitting a ...  (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Using coverflow and infinite looping, the slides begin warping as it a nears the end of the set (see gif).
https://imgur.com/lYCQdej
Expected behavior:
Slides do not warp.
Related code:
<ion-slides #slider class="coming-soon-posters" >

  <ion-slide>

  </ion-slide>

  <ion-slide>

  </ion-slide>

  <ion-slide>

  </ion-slide>

  <ion-slide>

  </ion-slide>

  <ion-slide>

  </ion-slide>

  <ion-slide>

  </ion-slide>

  <ion-slide>

  </ion-slide>

  <ion-slide>

  </ion-slide>

</ion-slides>

.coming-soon-posters {
  .slide-zoom {
    height: 100%;
  }
}

.coming-soon-poster {
  position: absolute;
  top: 20px;
  left: 20px;
  right: 20px;
  bottom: 20px;

  background-size: cover;
}

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.4.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.4.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.4.0
    @ionic/cli-plugin-ionic-angular : 1.3.1
    Cordova Platforms               : android 5.2.2 ios 4.1.1
    Ionic Framework                 : ionic-angular 3.4.2

System:

    Node       : v8.1.0
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 5.0.3

Hello, thanks for opening an issue with us! Would you be able to provide a plunker that demonstrates this issue? Thanks for using Ionic!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

@jgw96 I created a GIT repo with an ionic starter template and I added the described problem. After around 6 items in the array this warping effect starts to show up.
https://github.com/hoermiller/ionic-v3-coverflow-test
If you need further information or want me to test something just let me know.
My local environment
cli packages: (/usr/local/lib/node_modules)

@ionic/cli-utils  : 1.10.2

ionic (Ionic CLI) : 3.10.3

local packages:

@ionic/app-scripts : 2.1.4

Ionic Framework    : ionic-angular 3.6.1

System:

Node : v6.9.5

npm  : 5.3.0

OS   : macOS Sierra

Thank you for the sample code. Given that this area is getting a fair amount of rework in version 4, I am going to mark this as something to have another look at after version 4 is released.


conflict with houston:admin package

For some reason, after installing the houston:admin package, the following statement returns false:
Meteor.users instanceof Mongo.Collection
As a result, meteor-tabular doesn't recognize Meteor.users as a collection and I get a server-side error to that effect when trying to define a table. This should probably be fixed in Houston but thought I would mention it here in case (1) a workaround can be provided in meteor-tabular or (2) someone else runs into the same problem as it took me a couple hours to debug today.

I see this issue come up a lot in various places. I don't know why they haven't fixed it yet. I'd rather not do workarounds for issues caused by other packages, but thanks for posting.

Agreed, it's not your problem.


Refactor simulation initialisation

Boilerplate initialization code has been moved to the AMRSimulation class. Two functions are exposed to the user, first, which allows the user to perform a computation before initialization (for example to read in a table), and a second is called while the initialization code iterates over the simulation domain. These functions have empty implementations by default, so the user will need to implement them when relevant.

/azp run

@AstroKriel can you take a look at the build errors?

@AstroKriel can you take a look at the build errors?

Yep, fixed the errors. The errors were because I forgot to add the quokka namespace call to all references of the grid-struct. I have checked everything compiles fine now.

/azp run

@AstroKriel can you take a look at the build errors?

Yep, fixed the errors. The errors were because I forgot to add the quokka namespace call to all references of the grid-struct. I have checked everything compiles fine now.

The GPU build is still failing. Can you take a look at that?

@AstroKriel can you take a look at the build errors?

Yep, fixed the errors. The errors were because I forgot to add the quokka namespace call to all references of the grid-struct. I have checked everything compiles fine now.

The GPU build is still failing. Can you take a look at that?

It looks like the build error occurred because the reference to the state array was stored in grid_vec[...].array, and that vector lives on the CPU. There isn't an operator implemented to access vector elements stored on the CPU from the GPU, and that is why the error was being thrown. I fixed this by extracting the reference to the state variable and passing that reference directly to computeWaveSolution(...) instead of accessing the reference via the grid_vec[...] vector in the function call.

It looks like the build error occurred because the reference to the state array was stored in grid_vec[...].array, and that vector lives on the CPU. There isn't an operator implemented to access vector elements stored on the CPU from the GPU, and that is why the error was being thrown. I fixed this by extracting the reference to the state variable and passing that reference directly to computeWaveSolution(...) instead of accessing the reference via the grid_vec[...] vector in the function call.

Yeah, the fact that std::vector is not usable from the GPU requires a lot of workarounds in general. This looks like a reasonable way to do it. I'll re-run the GPU tests and merge if it passes.

/azp run

@AstroKriel something is still not right. GPU build still fails.

Ah yep, it looks like the state reference (ie grid_vec[...].array) needs to be extracted outside all the ParFor loops, because when compiled on GPU, the same problem as before occurs. I'll fix this and see if the problem persists / if there are other problems.

/azp run

@AstroKriel there are GPU build failures in the HydroBlast3D problem.

/azp run


The mysql url configuration joiner should use & instead of ;

Why are the changes needed?

The mysql url configuration joiner should use & instead of ;
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Please take a look if you find a moment, thanks @pan3793

Codecov Report

Merging #4322 (8d289e7) into master (4de0a69) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4322      +/-   ##
============================================
- Coverage     53.62%   53.58%   -0.05%
  Complexity       13       13
============================================
  Files           562      562
  Lines         30731    30731
  Branches       4159     4159
============================================
- Hits          16481    16468      -13
- Misses        12691    12702      +11
- Partials       1559     1561       +2

Impacted Files
Coverage Δ

.../kyuubi/server/mysql/constant/MySQLErrorCode.scala
13.84% <0.00%> (-6.16%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLCommandHandler.scala
77.77% <0.00%> (-4.05%)
:arrow_down:

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (-3.23%)
:arrow_down:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
75.27% <0.00%> (-2.20%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLGenericPackets.scala
76.59% <0.00%> (-2.13%)
:arrow_down:

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
59.09% <0.00%> (-1.52%)
:arrow_down:

.../engine/spark/session/SparkSQLSessionManager.scala
78.48% <0.00%> (-1.27%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
78.39% <0.00%> (-0.62%)
:arrow_down:

...kyuubi/engine/KubernetesApplicationOperation.scala
22.53% <0.00%> (ø)

...rc/main/scala/org/apache/spark/ui/EnginePage.scala
79.26% <0.00%> (+0.28%)
:arrow_up:

... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master/1.7/1.6


cannot enter PWNDFU Mode

I have tried 200+ times to put my device into DFU mode to enter PWNDFU Mode through your application but none of my attempts succeeded.Most of time after it failed,my device would not reboot automatically.
iPhone6,2|MacOS Catalina 10.15.1

I wouldn't recommend 10.15.1 , it breaks a lot of things. "Device has no langid" is a ipwndfu issue, google around for how to fix that

Thanks for your help! It seems to be a problem with libusb and I successfully set the nonce on my 5s after solving that. I found a strange problem that when I was using the CheckNonceGUI or the current version of checkm8 nonce setter it said that either unsupported device or no device found (My device is iPad7,5) but in the previous version of checkm8 nonce setter I entered my device model manually and everything went well,it just worked.

Ah, I somehow removed support for some devices by mistake! Will fix that now sorry

Just updated the app to fix this issue, check the releases tab for the .app! Thank you for bringing it to my attention! Please let me know if the update fixes it or not

It worked! Thanks!


NVHPC HPC2020 arch

Filing this early, feel free to play around and suggest changes when you find the time.
This time, README is updated accordingly and should contain all relevant information on how to build and run.

Dropped the compute-node build requirement for AC (and with it the information about allocating a node from the build section as this is detailed in the run section further down) and use upper-case 'AC' everywhere.


NODE service - create_table task/function without insert_data task/function

@apmariglis
Please update the https://github.com/madgik/MIP-Engine/blob/master/documentation/design_docs/changesForNodes.pdf with the specific interface that you want to be implemented.

Moved to jira.


Support workspace-level crate version denylist / local yanking

Problem
Occasionally, crates release a semver-violating version that causes breakage when consumed.
Cargo currently has two main features to address this issue:

Crate authors can mark the offending crate as "yanked"
Crate consumers can use a lock file with a pinned working version

The first approach is the best one, but it requires active intervention of the crate authors which may sometime take a few days. The second approach works great if the dependency was already used through a good version, however it's not easy to use when we want start using this dependency. This dependency can be deep in the chain so applying requirements locally in the workspace may not work. There are also solutions involving forking the crate or pointing to some other source (such as the Git repo), but these feel more complex than needed since the working version already exists in the registry, cargo resolution should be able to resolve it.
The scenario is the following:

foo has a private dependency on clumsy ^1.0.0
bar has a private dependency on clumsy ^2.0.0
myproject depends on foo only
clumsy releases 2.0.1 which contains a semver violation
myproject wants to add a dependency on bar, but by doing so cargo pulls the broken clumsy 2.0.1 instead of the working clumsy 2.0.0

myproject now needs to wait for an upstream fix or manually edit the lock file to add foo and clumsy 2.0.0, which is pretty tedious.
Proposed Solution
The solution for me would be to help resolution / updating the lock file in presence of semver violations without expecting coordination from third-party libraries, In the problem description, the fix could also be applied in bar, but in all cases myproject has to wait for a fix upstream instead of fixing it itself locally and moving on. I expect the solution to be applied locally at the workspace level and not be used when publishing the top crate to the registry.

The restricted solution for this issue of semver violations would be to have a way to mark at the workspace level that a crate version should be treated as yanked. When cargo performs resolution, a crate version is treated as yanked if it is marked as such either on the registry or in the workspace manifest (for example in the patch section). Resolution proceeds with regular yanking semantics. With this solution, myproject would flag<EMAIL_ADDRESS>as yanked and cargo resolution would select<EMAIL_ADDRESS>

A more general solution would be to allow patching dependency requirements. myproject could patch bar to depend on clumsy =2.0.0 instead of clumsy ^2.0.0.

Another general solution would be support for version substitution when patching the registry. Right now patch.crates-io.clumsy can swap it to a path or git dependency, but it could also support swapping for a different version from the registry.

Notes
Despite being currently affected by the scenario above, I prefer to avoid sharing exact details of the crates involved as general improvements to occasional semver violations feel more important than blaming specific instances which should be fixed eventually anyway. It's not the first time that I encounter a semver violation, nor the last and it would be nice to have an escape hatch. EDIT: The violation that prompted me to fill this issue was fixed through yanking after 3 days.
Also related:

https://github.com/rust-lang/cargo/issues/7193
https://github.com/rust-lang/cargo/issues/5286

You currently also have other options:

Downgrade the package without manually editing the lock file. You can run `cargo update -p<EMAIL_ADDRESS>--precise 2.0.0 to downgrade
Pin the version in your Cargo.toml with something like bar = "=2.0.0". This has the drawback of missing potential upgrades after the broken version, but then again, if the crate broke semver you might want to check the future 2.0.2 manually first and not allow automatic updates. You would have to add the dependency directly in one of your projects though to pin the version.

Are those solutions good enough for you?

Thanks for the report. I love the amount of details you filled in!
I wonder if we could consolidate similar feature requests into one location, so people don't need to jump between issues to get the full picture. Personally I favor #5286 and close this. Does that sound good to you?

@weihanglo
I don't think that these issues cover the same use cases. As far as I understand, #5286 is about version requirements (a local property of a crate) while this issue is about resolution (a global property of the dependency tree).
@mladedav
These are good ideas using the current Cargo features (I did not try them though), but I still think that local yanking would be a useful feature.

4th comment in #5286:

Scenario: Package A depends on B which depends on C. C pushes a broken version. B has not yet pushed a blacklist for the broken C. A should be able to blacklist it without a dependency on C.

I appreciate it's not the issue itself, but this seems to exactly describe what you're proposing here?

I see, yes this comment matches the goal of the issue here; but then @epage replies that the global denylist is not the goal of #5286 so I find it a bit confusing. When searching for existing issues I saw this one, and their comment is actually why I opened a dedicated issue for this feature. Anyway, if you think that it's clear enough if this issue is closed/it's better for triage then it's fine for me. :+1:

While I focused on the implementation in my discussion for #5286, I think the most important thing is to focus on the underlying requirements and to allow discussion of multiple solutions for the underlying requirements in one place to avoid fracturing the discussion.
However, I think the solutions discussed in each are tightly related to the underlying problem in each which are distinct.
In #5296 the concern is with the published result of a package (in this issue's terms, from the perspective of the publisher of bar).  The only thing that affects dependents on a published package are version requirements.
This issue is about the generation of my-projects Cargo.lock without the cooperation of bar or clumsy.
The user and who they are trying to help in each story is different.


Version change from 4.0.0 to 5.0.0

Changes

[X] Changed package version to 5.0.0 (this is due to multiple breaking chnages in package API).

Pending release references

Migrate some features from Scribble (#29)
A comprehensive list of known AST node types (#30)
Support for Solidity 0.8.4 (#33)
Parser and AST for arbitrary expression types (#34)

Regards.

Codecov Report

Merging #36 (bdcba96) into master (09d9365) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   91.99%   91.99%
=======================================
  Files         239      239
  Lines        4710     4710
  Branches      717      717
=======================================
  Hits         4333     4333
  Misses        232      232
  Partials      145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d9365...bdcba96. Read the comment docs.


[RUN] Refresh windows service status

Description of the new feature / enhancement
I use PowerToys run a lot :) And first - i want to thank you all.
My issue/enhancement is about windows service control in powertoys run- i want every time open run dialog, service status to be refreshed.
Scenario when this would be used?

Open powertoys Run and type: (just for example, or with other service) !apache and do stop service action... (Powertoys run will close now)
Now open powertoys run and see last typed !apache (its here because option "Clear the previous query search on launch" is disabled) and see... that even if service Apache is stopped- still stop action is visible instead of play/start.

This can be done in reverse- enable windows service, after open powertoys again - wrong action buttons.

Supporting information
Well.. am with Windows 11 64
PowerToys ver 0.55.0
If you need more information- i am here.
Thanks a lot for great job!

Related to #15454

/dup #15454


HYDE - quick question and feature request

So in the UI HYDE Level 0, 1, and 2 are explained:

Whether to use HYDE approach for LLM getting answer to embed (0=disabled, 1=non-doc LLM answer, 2=doc-based LLM answer)

I'm not sure if i understand correctly but it seems like in the first HYDE answere it uses only the inherent LLM knowledge, in HYDE answere 2 it uses some additional information for my documents.

Is this correct, and if so, what do HYDE levels 3-5 do?

Additional questions/requests:

Why is the model so overly "creative", poetic and using all kinds of emojis in the first couple HYDE answers? This seems a bit over the top as its just making up some literally "magical stuff"
It would be nice to have the option to only receive the final answere and not see the model generating the weird HYDE responses in between
Unrelated question: What is the unit of the Chunk size for document chunking in the expert settings? Is it characters, tokens, ...?

Hi thanks for questions.
I allow you to change the HYDE prompt now.

3-5 just keep iterating using all prior outputs + original query for embedding search.
It's overly creative in emoji stuff because of your chosen model mostly.
For now, set stream=False to only get final answer.
chunk is characters.  So chunk_size=512 is 512 characters.

Added ability to only see final result either as CLI option or change in UI/API.

Hi, how would i configure it so that only the HYDE response displays and not the final response from UserData? The HYDE response gets overwritten by the the final response. Thanks

Good idea.  I added another option, on by default, where I accordion the intermediate steps instead of just losing them.
--hyde_show_intermediate_in_accordion=True by default now.


Resident tasks: Disallow "acceptedResourceRoles" != ["*"]

Mesos treats resources which already have a role assignment != "" as "reserved". Therefore, they cannot be reserved again. To change that, the reserve op would need to specify the resources to relabel as well as the goal reservation state. Since we cannot change that short term, we should disallow resident apps which target roles != "".
/cc @aquamatthias @meichstedt

disallowing defining acceptedResourceRoles alone is not enough imo. The Marathon doc says If you do not specify this, Marathon considers all resource offers with roles that have been configured by the --default_accepted_resource_roles command line flag. If no --default_accepted_resource_roles was given on startup, Marathon considers all resource offers.
So in general, we should only consider unreserved resources for reservations.


Add some works from Google

Added some works from Google Deepmind:

SpatialVLM: Endowing Vision-Language Models with Spatial Reasoning Capabilities
Open-vocabulary Queryable Scene Representations for Real World Planning

Hi Boyuan, thanks for your PR! I’ve merged this PR, but I’m not entirely sure if SpatialVLM is suitable to be listed under the "embodied agent" category. Additionally, in the next two weeks, I will be updating a new version of our survey paper, “When LLMs Step into the 3D World: A Survey and Meta-Analysis of 3D Tasks via Multi-modal Large Language Models,” and I am considering including “Open-vocabulary Queryable Scene Representations for Real World Planning.” I might check with you at that time. If it's convenient, feel free to add me on WeChat: mxz1997112.


how to use continuous kv cache with prefix prompt caching in gpt attention plugin in context phase?

In this scenario, I want to use system prompt cache with continuous kv cache in the context phase.
I have 14 precomputed key-value pairs stored in the continuous kv cache with shape [batchsize, 2, num_kv_heads, max_seq_len, head_size]. When I first compute attention values using gpt-attention-plugin, I pass the kv cache as the parametaer past_key_value and set context_lengths, sequence_length and host_past_key_value_lengths as 14.
Since it's in the context phase, I find that kv cache with precomputed values are not used in the computing attention progress. The attention results show that gpt-attention-plugin doesn't count the precomputed values. And the present kv values computed by get-attention are stored in the kvcache[0:14], instead of being stored in the [14:28].
So I wonder how to use continuous kv cache with prefix prompt caching in gpt attention plugin in context phase?

@schetlur-nv @nv-guomingz

@byshiue could u please take a look this question?


Oni homebrew install fails

the command  brew cask install oni fails with:
Error: Command failed to execute!
==> Failed command:
/usr/bin/xattr -w com.apple.metadata:kMDItemAlternateNames ("oni") /Applications/Oni.app/Contents/Resources/app/oni.sh
==> Standard Output of failed command:
==> Standard Error of failed command:
Traceback (most recent call last):
File "/usr/bin/xattr-2.7", line 7, in
from pkg_resources import load_entry_point
ImportError: No module named pkg_resources
==> Exit status of failed command:
#<Process::Status: pid 31689 exit 1>

Sorry for the late reply!
Its possible this has been fixed since Oni was updated to the latest version on homebrew-cask.


makefile

chore: add gitignore directove for platform specific build
fix: force the creation of the build/_maven_output to prevent image building from failing

Release Note
NONE

creating the build/_maven_ouptut directory should be part of maven-overlay (https://github.com/apache/camel-k/blob/main/script/Makefile#L381) which is actually called as part of make images. So I really wonder why this did not work for you

sorry I overlooked the detail that it is _maven_output instead of _maven_overlay

sorry I overlooked the detail that it is _maven_output instead of _maven_overlay

no worries

@christophd do you think this can be merged ?


Tag all releases

As a developer, I'd like to checkout the release of nimbus-core that my project is using in order to debug framework issues.
Issue Details
1.3.1.M5, and 1.3.1.M6 are missing from the release list and have not been tagged.
Type of Issue  (check one with "X")
[X] Bug Report => Please search GitHub for a similar issue or PR before submitting
[ ] Feature Request => Please ensure feature is not already in progress
[ ] Support Request => Please do not submit support requests here, instead see: https://discourse.oss.antheminc.com/

Environment Details

Nimbus Version:
1.3.1.M5, 1.3.1.M6

Tags are available in git now.

Thanks!


Euler transform with optional upper/lower limits to each parameter

Intro
This adds a new transform dubbed the AdvancedLimitedEulerTransform, which implements per axis upper and/or lower limiting. It achieves this functionality by clamping the transform gradient based on the current value of each parameter, using the Softplus function.
In the parameter file, set the transformation as:
(Transform "AdvancedLimitedEulerTransform")

Additional parameter to set are:
// SharpnessOfLimits defines the cutoff sharpness; higher values represent a sharper cutoff
(SharpnessOfLimits "200.0000000000")
// UpperLimits and LowerLimits are defined to absolute values of each of three Euler angles and translations, ie (a, b, c, tx, ty, tz)
(UpperLimits 0.5000000000 0.5000000000 0.5000000000 10.0000000000 10.0000000000 10.0000000000)
(LowerLimits -0.5000000000 -0.5000000000 -0.5000000000 -10.0000000000 -10.0000000000 -10.0000000000)

Note: axis limiting is implemented for 3D images and for use with gradient based optimizers! Using 2D input images will throw an error, while using another optimizer will not effectively apply the limits.
Example application
For instance if 3D CT was translated +15 mm along the X axis, and then registered onto its original version, and with the registration limited to +/- 10 mm along the X axis like this (see TransformParameters.tx15.txt):
transformix.exe -in CT_fix.nii.gz -tp TransformParameters.tx15.txt -out .
// convert result.nrrd to CT_fix_tx15.nii using your favourite converter
elastix.exe -f CT_fix.nii.gz -m CT_fix_tx15.nii -p ElastixParameters_tx15.txt -out output

The corresponding output can be found in folder output, ie. from TransformParameters.0.txt see the following line:
(TransformParameters -0.000304 -0.008137 -0.017665 -10.700775 -0.109858 0.028943)

where indeed the translation along the X axis was limited at -10 mm. The limits are also propagated into the transform parameter file:
...
(SharpnessOfLimits "200.0000000000")
(UpperLimits 0.5000000000 0.5000000000 0.5000000000 10.0000000000 10.0000000000 10.0000000000)
(LowerLimits -0.5000000000 -0.5000000000 -0.5000000000 -10.0000000000 -10.0000000000 -10.0000000000)
Additionally, if a limit was reached, this is indicated in the transform parameters file by value close to 1 as follows:

(LowerLimitsReached 0.0000000000 0.0000000000 0.0000000000 0.9990956587 0.0000000000 0.0000000000)
(UpperLimitsReached 0.0000000000 0.0000000000 0.0000000000 0.0000000000 0.0000000000 0.0000000000)

Specific axis could also be effectively disabled by settings the upper and lower limits to same (zero) value:

(LowerLimits 0.0000000000 0.0000000000 0.0000000000 0.0000000000 0.0000000000 0.0000000000)
(UpperLimits 0.0000000000 0.0000000000 0.0000000000 0.0000000000 0.0000000000 0.0000000000)
[ElastixParameters_tx15.txt](https://github.com/SuperElastix/elastix/files/7007427/ElastixParameters_tx15.txt)
[TransformParameters.tx15.txt](https://github.com/SuperElastix/elastix/files/7007429/TransformParameters.tx15.txt)

Hi,
it seem the Elastix framework was refactored recently and this is causing the build to fail. The problem seems to be in the waythe output transform parameter file is to be written.
We identified the following issue:
In header Core/ComponentBaseClasses/elxTransformBase.hxx
 /** Allows a derived transform class to write its data to file, by overriding this member function. */
  virtual void
  WriteDerivedTransformDataToFile(void) const
  {}

Parameters to write are passed in the implementation of function WriteToFile(xl::xoutsimple & transformationParameterInfo, const ParametersType & param) and at the end of function the following happens:
  transformationParameterInfo << Conversion::ParameterMapToString(parameterMap);

  WriteDerivedTransformDataToFile();

There is an incentive to override the WriteDerivedTransformDataToFile(), however, it does not accept any parameters, while the parameterMap seems to be written to output stream prior to calling this function.
In our current implementation we want to compute an output vector, i.e. LimitsReached, based on the current transform paramters, i.e. EulerTransformParameters and the parametersUpperLimits, LowerLimits and SharpnessOfLimits.
In previous Elastix version (4.9) there used to be a mechanism to override the WriteToFile() function and thus generate the transform parameter file, with all the parameters available in the function.
My question is how is it possible, in the refactored elastix framework, to compute output values and write them into the transform parameters file? Was this option considered? If yes, is there a use case such that to take a look?
Many thanks,
Ziga

@zigaS-fe-uni-lj Thank you for your pull request! Indeed, with a recent refactoring, the support to override elastix::TransformBase::WriteToFile was removed. We observed that in most cases, it is sufficient for elastix::TransformBase::WriteToFile to just write the content of its transform parameter map. If your (derived) transform class has some extra transform parameters to be added to the map, you may now override elastix::TransformBase::CreateDerivedTransformParametersMap(void), instead, to returning a map of the extra transform parameters! I think it should be as follows:
template <class TElastix>
auto
AdvancedLimitedEulerTransformElastix<TElastix>::CreateDerivedTransformParametersMap(void) const -> ParameterMapType
{
  ParameterMapType parameterMap{
    { "CenterOfRotationPoint", Conversion::ToVectorOfStrings(m_LimitedEulerTransform->GetCenter()) },
    { "SharpnessOfLimits", { Conversion::ToString(m_LimitedEulerTransform->GetSharpnessOfLimits()) } },
    { "UpperLimits", Conversion::ToVectorOfStrings(m_LimitedEulerTransform->GetUpperLimits()) },
    { "LowerLimits", Conversion::ToVectorOfStrings(m_LimitedEulerTransform->GetLowerLimits()) }
  };

  if (SpaceDimension == 3)
  {
    parameterMap["ComputeZYX"] = { Conversion::ToString(m_LimitedEulerTransform->GetComputeZYX()) };
  }
  return parameterMap;
}

When this member function is added to AdvancedLimitedEulerTransformElastix, I think both overrides, WriteToFile and CreateTransformParametersMap, may just be removed from AdvancedLimitedEulerTransformElastix. I think, in your case, it would not be necessary to override WriteDerivedTransformDataToFile(void). However, you would need to try it out!
Maybe it's also helpful to take a look at the current revision (develop branch, git HEAD) of elxEulerTransform.h and elxEulerTransform.hxx at https://github.com/SuperElastix/elastix/tree/develop/Components/Transforms/EulerTransform
Hope this helps! Kind regards, Niels

When a user does not specify those new parameters (SharpnessOfLimits, UpperLimits, LowerLimits) would AdvancedLimitedEulerTransform behave exactly like the existing EulerTransform? I would like it like that!

@zigaso Just for my understanding, does your proposal only support 3D, no 2D? Because I see that you wrote "itkAdvancedLimitedEuler3DTransform.h", but no corresponding 2D transform!
Just want to be sure that that's your intention!  😃

你好：   邮件内容已收到，我会尽快处理，谢谢   祝好！


feat: config to allow custom json encoder

@zachschubert pretty small change, shouldn't have conflicts w/ your changes. I think ErgoEncoder could be the default encoder and Payload can wrap your changes for FlaskHttpInvoker's payload

Codecov Report

Merging #9 (b19fed8) into master (2eb2a29) will decrease coverage by 0.90%.
The diff coverage is 97.82%.

@@             Coverage Diff             @@
##            master       #9      +/-   ##
===========================================
- Coverage   100.00%   99.09%   -0.91%
===========================================
  Files            3        4       +1
  Lines           68      111      +43
===========================================
+ Hits            68      110      +42
- Misses           0        1       +1

Impacted Files
Coverage Δ

src/util.py
98.41% <96.77%> (-1.59%)
:arrow_down:

test/integration/target.py
100.00% <100.00%> (ø)

test/unit/test_util.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb2a29...b19fed8. Read the comment docs.


Updated R packages with 3.4.4

@j-martens

@heatherbshapiro : Thanks for your contribution! The author, @rastala, has been notified to review your proposed change.

@heatherbshapiro : Thanks for your contribution! The author, @rastala, has been notified to review your proposed change.

#sign-off

@j-martens: I'm sorry - only the author of this article, @rastala, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


problem with runit ....

Runit not behaving the right way ... stoping and running container ...
maybe I need to move to another init ... maybe systemd but ... ubuntu still not support it ,,, and controversy around it ,,, maybe create other problems ..
plus docker and systemd no idea if that will work ... at the moment what I found on line appear that need to run privilege to use systemd ...
trying ubuntu:15.04 to check if work ...

I still using runit .... I will wait for update and full integration of systemd to ubuntu to try to replace runit ..

Moving to systemd ... but will be slow move ... after done with baseimage need to move with all the other   docker container ...
reason to move to systemd:
-- All the linux already come with systemd including ubuntu after 15.04
-- To reduce complexity and size of the container (base image already include systemd when FROM command is execute to install another init (runit) will make it bigger that necessary and force working on this container to learn two different init system .. the one running at server  and the one running  at the container.
-- Future version of docker will have support/integration of systemd integrate on it .
-- Future open source software that I will deploy in ours containers will come already predefined for working with systemd and will be easier to find info about any problem or help reference on line .. but runit will be not .
Possible problem with the move:
-- systemd on ubuntu maybe still going to change (new init system on ubuntu)
-- My poor knowledge relate to systemd
-- The way this baseimage was used to be adapted to be run with runit  to allow multiple process inside a docker container maybe need to change drastically when we try to do the same for systemD. In other word this baseimage will maybe bad reference to move to systemD and maybe better start from scratch .

I will use  quantumobject/docker-systemd   for replacement for this image when it ready ... but at the moment I will continue to used this one .. SystemD need to be better integrate to ubuntu and docker .. still a lot of bug that need to be fix to be of any use ...