Invalid free wild pointer lead to DOS in load_png in loader.c

load_png has a pointer rows, which should be set to NULL, otherwise cleanup code would use(calling free) it.
binary: img2sixel
file: loader.c
function: load_png
poc:
poc.zip
result:
#0  __GI_raise (sig=sig@entry=0x6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff6fcf801 in __GI_abort () at abort.c:79
#2  0x00007ffff7018897 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7ffff7145b9a "%s\n") at ../sysdeps/posix/libc_fatal.c:181
#3  0x00007ffff701f90a in malloc_printerr (str=str@entry=0x7ffff7143d88 "free(): invalid pointer") at malloc.c:5350
#4  0x00007ffff7026e1c in _int_free (have_lock=0x0, p=0x65a5b8, av=0x7ffff737ac40 <main_arena>) at malloc.c:4157
#5  __GI___libc_free (mem=0x65a5c8) at malloc.c:3124
#6  0x0000000000426701 in load_png (result=<optimized out>, buffer=<optimized out>, size=<optimized out>, psx=<optimized out>, psy=0x65a5dc, ppalette=<optimized out>, pncolors=0x65a5e0, reqcolors=0x100, pixelformat=0x65a5e4,
    bgcolor=0x0, transparent=0x65a5f8, allocator=0x652260) at loader.c:633
#7  0x0000000000410e2b in load_with_builtin (pchunk=<optimized out>, fstatic=0x0, fuse_palette=0x1, reqcolors=<optimized out>, bgcolor=<optimized out>, loop_control=0x0, fn_load=<optimized out>, context=<optimized out>) at loader.c:889
#8  sixel_helper_load_image_file (filename=<optimized out>, fstatic=0x0, fuse_palette=0x1, reqcolors=0x100, bgcolor=<optimized out>, loop_control=0x0, fn_load=<optimized out>, finsecure=<optimized out>, cancel_flag=<optimized out>,
    context=<optimized out>, allocator=<optimized out>) at loader.c:1418
#9  0x0000000000403d93 in sixel_encoder_encode (encoder=0x652290, filename=0x7fffffffe634 "/tmp/crashes/id:000001,sig:11,src:000624,op:havoc,rep:4") at encoder.c:1743
#10 0x000000000040272d in main (argc=<optimized out>, argc@entry=0x2, argv=<optimized out>, argv@entry=0x7fffffffe388) at img2sixel.c:457
#11 0x00007ffff6fb0b97 in __libc_start_main (main=0x402010 <main>, argc=0x2, argv=0x7fffffffe388, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe378) at ../csu/libc-start.c:310
#12 0x0000000000401f4a in _start ()

CVE-2020-11721 was assigned for this issue.

@carnil Hello I find a problem and request a CVE id ,but no reply to me?
https://github.com/saitoha/libsixel/issues/136

I'm not sure of the validity of this bug, @carnil, @sleicasper.
The maintainer of this project has been absent for over a year and now I'm de facto maintainer. (See #154.)
I've patched the other CVE, see libsixel#8.
This one doesn't seem valid to me though. I need more information. I don't get the crash. I get a libpng error. Could libpng have updated in the meanwhile? Is this a libpng issue masquerading as a libsixel issue?
I get:
Starting program: /home/fred/Workspace/libsixel/converters/.libs/img2sixel -8 id:000001,sig:11,src:000624,op:havoc,rep:4
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
libpng error
UU[00][00]: invalid chunk type
[Inferior 1 (process 1827699) exited with code 0377]
quit)

If you can still repro the bug, is this a sufficient fix?
diff --git a/src/loader.c b/src/loader.c
index abc27f8..ea93daa 100644
--- a/src/loader.c
+++ b/src/loader.c
@@ -630,7 +630,9 @@ load_png(unsigned char      /* out */ **result,

 cleanup:
     png_destroy_read_struct(&png_ptr, &info_ptr,(png_infopp)0);
-    sixel_allocator_free(allocator, rows);
+    if (rows != NULL) {
+        sixel_allocator_free(allocator, rows);
+    }

     return status;
 }

If not, please give more info. If it's fixed, no big deal, I'll request CVE mark the bug invalid…

@ctrlcctrlv
which version of libsixel are you reproducing?
This bug is reproducible at the time of reporting, which is v1.8.6.

Please give a full command line.

Also, what is your libpng version? Mine is 1.6.37 on Arch Linux. My working theory right now is that this is not our bug, it's a libpng bug that they fixed recently which had the side effect of causing this bug. However, please feel free to explain to me how to reproduce so I can solve it if I'm wrong and close this out.

Wait. Is what you're saying that if HAVE_SETJMP && HAVE_LONGJMP isn't true that can trigger the goto cleanup, which then can free a wild pointer (rows)?
I didn't think that condition wasn't true on any modern system, but I can fix it. Is this what you mean @sleicasper ?

@ctrlcctrlv yes, that is what I mean. 'rows' can be a wild pointer. After executing 'goto cleanup', it can be freed.

Except that's not the executed codepath for your PoC? I don't mind patching it, but I don't understand how you got that from your PoC.

See? I get a libpng error.
:!make && LD_LIBRARY_PATH=./converters/.libs/:src/:src/.libs gdb ./converters/.libs/img2sixel -ex 'run
 id:000001,sig:11,src:000624,op:havoc,rep:4'

GNU gdb (GDB) 10.2
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./converters/.libs/img2sixel...
Starting program: /home/fred/Workspace/libsixel/converters/.libs/img2sixel id:000001,sig:11,src:000624,op:havoc,rep:4
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
libpng error
UU[00][00]: invalid chunk type
[Inferior 1 (process 1852108) exited with code 0377]
(gdb) break png_error
Breakpoint 1 at 0x7ffff7e4d220
(gdb) r
Starting program: /home/fred/Workspace/libsixel/converters/.libs/img2sixel id:000001,sig:11,src:000624,op:havoc,rep:4
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".

Breakpoint 1, 0x00007ffff7e4d220 in png_error () from /usr/lib/libpng16.so.16
(gdb) bt
#0  0x00007ffff7e4d220 in png_error () from /usr/lib/libpng16.so.16
#1  0x00007ffff7e4d315 in png_chunk_error () from /usr/lib/libpng16.so.16
#2  0x00007ffff7e5ff23 in ?? () from /usr/lib/libpng16.so.16
#3  0x00007ffff7e6009b in ?? () from /usr/lib/libpng16.so.16
#4  0x00007ffff7e52339 in png_read_info () from /usr/lib/libpng16.so.16
#5  0x00007ffff7f8b62f in load_png (result=0x5555555645b8,
    buffer=0x55555555c3c0 "\211PNG\r\n\032\n", size=8, psx=0x5555555645c8, psy=0x5555555645cc,
    ppalette=0x5555555645c0, pncolors=0x5555555645d0, reqcolors=256, pixelformat=0x5555555645d4,
    bgcolor=0x0, transparent=0x5555555645e8, allocator=0x55555555c2a0) at loader.c:365
#6  0x00007ffff7f98213 in load_with_builtin (pchunk=0x55555555c390, fstatic=fstatic@entry=0,
    fuse_palette=fuse_palette@entry=1, reqcolors=reqcolors@entry=256, bgcolor=bgcolor@entry=0x0,
    loop_control=loop_control@entry=0, fn_load=0x7ffff7f9bda0 <load_image_callback>,
    context=0x55555555c2d0) at loader.c:889
#7  0x00007ffff7f99324 in sixel_helper_load_image_file (
    filename=filename@entry=0x7fffffffe652 "id:000001,sig:11,src:000624,op:havoc,rep:4", fstatic=0,
    fuse_palette=fuse_palette@entry=1, reqcolors=256, bgcolor=0x0, loop_control=0,
    fn_load=0x7ffff7f9bda0 <load_image_callback>, finsecure=0,
    cancel_flag=0x55555555b0f0 <signaled>, context=0x55555555c2d0, allocator=0x55555555c2a0)
    at loader.c:1418
#8  0x00007ffff7f9d722 in sixel_encoder_encode (encoder=0x55555555c2d0,
    filename=0x7fffffffe652 "id:000001,sig:11,src:000624,op:havoc,rep:4") at encoder.c:1748
#9  0x0000555555555944 in main (argc=2, argv=0x7fffffffe298) at img2sixel.c:459
(gdb) frame 5
#5  0x00007ffff7f8b62f in load_png (result=0x5555555645b8,
    buffer=0x55555555c3c0 "\211PNG\r\n\032\n", size=8, psx=0x5555555645c8, psy=0x5555555645cc,
    ppalette=0x5555555645c0, pncolors=0x5555555645d0, reqcolors=256, pixelformat=0x5555555645d4,
    bgcolor=0x0, transparent=0x5555555645e8, allocator=0x55555555c2a0) at loader.c:365
365	   png_read_info(png_ptr, info_ptr);
(gdb)

Anyway @sleicasper, I've merged https://github.com/libsixel/libsixel/commit/e71aacc97b5f756948b13c1228877d29395c7b55 which I consider as closing this. It closes libsixel#9 in the fork. I've released version 1.9.0.

It seems to be a libpng error that triggers the longjmp, then libsixel frees the wild pointer.
However, it looks like libpng have fixed it somehow. I couldn't reproduce this issue using default version of libpng on ubuntu 20.04 anymore.
The patch looks good to me, it should prevent libsixel freeing wild pointer no matter libpng has error.


Adding include, filter, sort... on Related Resource

Hi there,
I'm almost done updating my full application to this library, which btw is simply amazing, only to face a last minute issue. Let me explain. Consider a Post with many Comments.
Using related resources I can have the following endpoint:
/api/posts/{post_id}/comments
Now I would like to implement pagination on this and I know it is on the path to 1.0, that's awesome news. But I also need to be able to include other resources or apply some filters.
But the following doesn't work:
/api/posts/{post_id}/comments?include=author&filter[title]=hello
I would have expected that it would be parsed by the Comment Adapter and Validator.
I don't see anything in the spec preventing filtering or inclusion on related resources, unless I missed it.
Sure I could achieve the same result by adding a filter on the comments endpoint:
 /api/comments?include=author&filter[title]=hello&filter[posts-id]={post_id}
But that's not how my API is documented and isn't the best way of doing it.
Is it something which is on the radar? Maybe on the road to 1.0?

Hi! Really glad you like the package!
Yes, you should totally be able to do this. The reason it isn't working at the moment is because the relationship stuff hasn't been fully implemented - which is why the relationship stuff is the biggest thing on the 1.0 path.
I agree that a request to posts/1/comments needs to be passed to the Comments adapter/validators rather than the posts one. I need to work out a way of neatly doing that and then put in the code to do it.
Will definitely be in for 1.0. I've being doing some work on all the non-relationship stuff that's on the 1.0 list, with the idea being that I'll move on to the relationship stuff next.

I see you're hard at work ;) That's awesome news.
Thanks.

Oops, closed the issue, didn't know if you wanted to keep it open for reference.
Feel free to reopen ;)

no problem!

before I open a new ticket I was wondering if this also applies to sorting on related attributes on the main resource.
For example: GET /contracts?include=user&sort=user.firstname
Or is this already supported and I just can't seem to figure it out?

@theTechGuyy sorting is supported.
Set the allowed sort params on your validator class, e.g.:
https://github.com/cloudcreativity/laravel-json-api/blob/master/tests/JsonApi/Posts/Validators.php#L30-L35
And then you'll need to implement how to apply that sorting in your adapter. The Eloquent sorting will automatically apply sort parameters itself, but wouldn't work with user.firstname because the sorting happens when querying the database. It does it here:
https://github.com/cloudcreativity/laravel-json-api/blob/master/src/Store/EloquentAdapter.php#L320-L331
So you'd have to overload the methods if you have some other sorting logic?

Ahh thanks so much - and sorry for hijacking the issue..

@theTechGuyy I'm not seeing sortBy called on my adapter at all. Using 0.11 which looks like it has #96 merged on Laravel 5.5

@moneal I'll take a look at this now

@moneal I've added a test to the master branch that definitely checks that the sortBy method is being called. Can you describe more about the scenario you have where it is not being called?

@lindyhopchris This is what I'm testing with right now.
public function testUserNotesSortDescending()
{
    // $this->markTestSkipped('Sort not currently working');
    $user = factory(User::class)->create();
    /** @var Collection $notes */
    $notes = factory(Note::class, 3)->make()->each(function ($note, $index) use ($user) {
        /** @var Note $note */
        $note->created_at = Carbon::now()->addSeconds($index);
        $note->updated_at = $note->created_at;
        $note->notable()->associate($user);
        $note->save();
    });
    $response = $this->actingAs($user)->doRead($user->id, [
        'include' => 'notes',
        'sort' => '-notes.created_at'
    ]);
    $response->assertSearchOneResponse($user->id);
    $response->assertJson([
        'data' => [
            'relationships' => [
                'notes' => [
                    'data' => [
                        [
                            'type' => 'notes',
                            'id' => $notes[2]->getKey()
                        ],
                        [
                            'type' => 'notes',
                            'id' => $notes[1]->getKey()
                        ],
                        [
                            'type' => 'notes',
                            'id' => $notes[0]->getKey()
                        ]
                    ]
                ]
            ]
        ]
    ]);
}

I don't think the sort parameter needs to be -notes.created_at, it should just be -created_at

When using -created_at it is not changing the order of the related notes.

Ah, is this a relationship of the users resource? I.e. you're doing a request at users/1/notes? If so, you'll have to manually implement applying the sort order in the controller method as I haven't implemented full support for searching relationships yet - it's on the to-do list for 1.0.

Sorting of related resources is now supported on the 1.0 branch.

Sorry but I'm not sure I understood correctly, is it now possible to sort on an included resource or is it still necessary to implement our own sorting logic?
Ex: /safaris?include=console.owner&sort=-console.owner.updated_at

This refers to sorting on related paths: i.e. GET /api/posts/1/comments?sort=-created-at will sort the comments in the response.
Sorting included resources is not supported. The spec says:

An endpoint MAY support requests to sort the primary data with a sort query parameter.

Note that it refers to sort the primary data: included resources are not the primary data.

Ahh thanks so much - and sorry for hijacking the issue..
Edit:
just for anybody googling towards this and wondering on how to achieve the sorting by related columns in a somewhat generic way with overloading the EloquentAdapter.sortBy function. Should
work with master as soon as #96 is fixed:
   /**
     * @param Builder $query
     * @param SortParameterInterface $param
     */
    protected function sortBy(Builder $query, SortParameterInterface $param)
    {
        $column = $this->getQualifiedSortColumn($query, $param->getField());
        $order = $param->isAscending() ? 'asc' : 'desc';
        if (!starts_with($column, $query->getModel()->getTable())) {
            // related sorting
            $relation = substr($column, 0, strpos($column, '.'));
            $attribute = substr($column, strlen($relation) + 1);
            $relation = $query->getModel()->$relation();
            $relatedTable = $relation->getRelated()->getTable();
            // Include related table
            $query->leftJoin(
                $relatedTable,
                $query->getModel()->getTable().'.'.$relation->getForeignKey(),
                '=',
                $relatedTable.'.'.$relation->getOwnerKey()
            );
            // correct column name to match model table
            $column = $relatedTable.'.'.$attribute;
        }
        $query->orderBy($column, $order);
    }

getForeignKey() exists on a model, not relation. Relation uses getForeignKeyName()


Convert parquet metadata back to builders

Which issue does this PR close?

Closes #.
Rationale for this change

An argument could definitely be made for simply removing these builders, but this was a less disruptive option
What changes are included in this PR?

Are there any user-facing changes?

I thought I needed it for #4155 but actually I decided against it. Seems like a harmless API addition though


TemplateAllNumberAway disappear in config.

The config TemplateAllNumberAway was present before, and its purpose was to prevent redundant translations, such as attack N point, from being translated multiple times. This feature was very useful, but I couldn't locate it in the latest version of the config. Has it been deleted, and if so, what was the reason? Alternatively, has it been merged with another feature? I hope to see it reinstated soon.
For evidence supporting the existence of TemplateAllNumberAway, refer to this issue.

I don't think you are very careful...
option is in place and working
I use this option and it works if you do not have such an option in the config, add it yourself

also here try my custom translation seraer (uses google api) he also has a caching system similar to this option (speeds up translations, fewer requests to google itself)
https://github.com/bbepis/XUnity.AutoTranslator/issues/396

I see the translations again and I have identified the actual problem. Only words that don't have rich text work with TemplateAllNumberAway.
Here are some results:
交换{{A}}个肝脏。=交換{{A}}個肝臟。
（随机获取1块神话符文石）\n需要: 10<size\=130%><sprite tint\=1 name\=item></size><link\="tooltip:d5a12fa97d4f54e4caea6fb40ef27c0c;technical:">[人肝]</link> 库存量：36\n=（隨機獲取1塊神話符文石）\n需要: 10<size\=130%><sprite tint\=1 name\=item></size><link\="tooltip:d5a12fa97d4f54e4caea6fb40ef27c0c;technical:">[人肝]</link> 庫存量：36\n

Line 1 converts the number to {{A}}, while line 2 remains unchanged. Consequently, I will modify the issue's title to accurately reflect the problem.

Я снова вижу переводы, и я определил фактическую проблему. Только слова без форматированного текста работают с TemplateAllNumberAway. Вот некоторые результаты:
交换{{A}}个肝脏。=交換{{A}}個肝臟。
（随机获取1块神话符文石）\n需要: 10<size\=130%><sprite tint\=1 name\=item></size><link\="tooltip:d5a12fa97d4f54e4caea6fb40ef27c0c;technical:">[人肝]</link> 库存量：36\n=（隨機獲取1塊神話符文石）\n需要: 10<size\=130%><sprite tint\=1 name\=item></size><link\="tooltip:d5a12fa97d4f54e4caea6fb40ef27c0c;technical:">[人肝]</link> 庫存量：36\n

Строка 1 преобразует число в {{A}}, а строка 2 остается неизменной. Следовательно, я изменю название проблемы, чтобы точно отразить проблему.

well, so I’m talking about the same in my problem that the option doesn’t work everywhere, that’s why I made a solution for myself through nodejs local server
with its cache system

I see the translations again and I have identified the actual problem. Only words that don't have rich text work with TemplateAllNumberAway. Here are some results:
交换{{A}}个肝脏。=交換{{A}}個肝臟。
（随机获取1块神话符文石）\n需要: 10<size\=130%><sprite tint\=1 name\=item></size><link\="tooltip:d5a12fa97d4f54e4caea6fb40ef27c0c;technical:">[人肝]</link> 库存量：36\n=（隨機獲取1塊神話符文石）\n需要: 10<size\=130%><sprite tint\=1 name\=item></size><link\="tooltip:d5a12fa97d4f54e4caea6fb40ef27c0c;technical:">[人肝]</link> 庫存量：36\n

Line 1 converts the number to {{A}}, while line 2 remains unchanged. Consequently, I will modify the issue's title to accurately reflect the problem.

well, so I’m talking about the same in my problem that the option doesn’t work everywhere, that’s why I made a solution for myself through nodejs local server
with its cache system


adds ensureInitialized(); to readme and example

Adds the changes to documentation and example to prevent the white screen of nothingness.
#8
https://stackoverflow.com/questions/57689492/flutter-unhandled-exception-servicesbinding-defaultbinarymessenger-was-accesse

Thanks!


[TS] Sentiment should be renamed to style

TS fix of #2968

@dclaux would you be able to help out with this one today at all? Thanks a ton!


Inline types are not exposed to users

Hi!
I'm a maintainer over at typeshed, where we have stubs for dj-database-url. It looks like you recently added inline types and a py.typed file, which is great! This means that we can hopefully soon remove our stubs from typeshed.
Unfortunately, your py.typed file isn't properly exposing your inline types to users of the package. If I install dj-database-url==1.3.0 and run mypy on a file containing just this:
import dj_database_url

Then this is the output from mypy:
repro.py:1: error: Library stubs not installed for "dj_database_url"  [import]
repro.py:1: note: Hint: "python3 -m pip install types-dj-database-url"
repro.py:1: note: (or run "mypy --install-types" to install all missing stub packages)
repro.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 1 source file)

The reason for this is that dj-database-url is currently a single-file project. Unfortunately, PEP 561 doesn't provide a way for single-file projects to add a py.typed file to their project. In order for the py.typed file to be recognised by type checkers, you'd need to convert this project into a package (with the py.typed file inside the package). If you did that (and specified package_data in setup.py to ensure that the file was included in uploads to PyPI), then type checkers would see the py.typed file, and know to look for inline types in dj-database-url.
Would you consider making dj-database-url into a package? If dj-database-url remains a single-file project, then unfortunately the py.typed file you already have in this repo serves little purpose, and may as well be deleted :/
Cc. @palfrey, who authored #198, and @XF-FW, who originally contributed the stubs to typeshed :)

Sounds good to me. https://github.com/jazzband/dj-database-url/pull/215 implements this, and explicitly tests the mypy test case works. @mattseymour?

Fixed as of release 2.0.0

Thanks @palfrey and @mattseymour! Can confirm that the py.typed file is now included in the PyPI release, which led to our typeshed automation successfully being triggered: https://github.com/python/typeshed/pull/10094


Use fewer processes and file descriptors

Currently, Lace will perform the following steps in order: (1) create all file descriptors and pipes, (2) all processes are spawned, and (3)  wait for all processes to complete. For larger scripts, this may exhaust the available number of file descriptors or running processes as imposed by the system or ulimit.

We could run a certain number of commands in parallel, gobble their inputs, and feed it to subsequent commands as the earlier ones finish. This is not so simple because some commands like "yes" do not terminate until their output stream closes.

We may however be able to exploit known behaviors of Lace-specific programs and variable declarations (e.g., the "proper" fix to Issue #3).
We may add optional specifications for I/O behavior.

Using techniques of stream-based languages that are geared towards performance, a Lace-specific command could simply be a function call for each input line within the Lace interpreter. This would substantially reduce number of processes and pipes, and it should boost performance.

This could be extended to include user code that is compiled in or dynamically loaded. The user would need to specify I/O behavior.

Since scripts are pretty small, I haven't actually run into this issue yet. It is a design goal though, so consider it an "epic" rather than an "issue".

The biggest waste of file descriptors is the string variables. Currently, every variable usage actually gets its value from the output of elastic. I think elastic and other builtins will run as threads in the future, and communication between them will not have the overhead of a file descriptor.
That would make the number of file descriptors roughly equal to what you'd expect from an equivalent shell script. A bit less due to builtins, or a bit more because scripts can use temporary files.
Speaking of tmpfiles, I think they are part 2 of the solution here. We can have a single-input builtin named tmpfile that changes its input pipe's $(OF ...) source to actually be a file. The consumer(s) of that data would necessarily need to wait until all data is written, which we can only guarantee when the producer exits, thus allowing us to wait for the producer to exit before spawning the consumers or subsequent programs.
Let's devote this issue to the "part 2" solution of making a tmpfile builtin.

To resolve this issue, I'll have Lace execute its builtins in pthreads.
Just need to figure out a clean way to pass in the pre-opened files. Perhaps the builtins can get -internal flag prefixes to accept non-string args.

https://github.com/grencez/lace/commit/a48b094611e4cbcf4630976e37c140d2a0dd46ae makes zec run in a thread usually. It doesn't cut down on the file descriptors though.

After https://github.com/grencez/lace/issues/30 is closed, we should be able to:

[ ] Avoid the self-spawn that is currently done to redirect stdio.
[ ] Run execfd builtin in a thread.

To close this issue out, I'd also like to:

[ ]  Avoid file descriptors between builtins.


Issue #2791: fix bug The title bar of the website always displays loading...

Close this PR. I created another PR https://github.com/gu-corp/react-native-webview/pull/125  to fix this


Presentation: fix private categories showing in categories/models trees

Bug fix, test utils and tests.
Closes iTwin/itwinjs-core/issues/3782
and iTwin/itwinjs-core/issues/4256

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use pnpm or update package.json

dominikg is started to implement svelte-ecosystem-ci and it includes this ESLint plugin also.
For this CI to be successful, either of the following must be implemented

Use pnpm
Add "packageManager":"yarn@version" to package.json

I personally want to use pnpm because now both Svelte and SvelteKit is using pnpm.
Then we can think that we can always use pnpm for Svelte repositories.
And I think pnpm is much faster...

I think it's a good idea to use organization's familiar package manager! Let's change ours to use pnpm too.

close this because https://github.com/sveltejs/eslint-plugin-svelte/pull/477 is merged.


Add Korean language in handbook page

I proposal add korean language in handbook/vision.rst.

It will be the first point to introduce the symbol to Korean.
It will be helpful for Korean community.
I have prticipated in the Korean translation work of desktop-wallet.

We would LOVE to have the Vision document translated to more languages!
Please feel free to submit a Pull Request. Don't worry about formatting or linking from other pages if you don't want to. We can take care of it in the review.
I can assign this issue to you if you want to!


[DEVHAS-264] Don't immediately display Application not ready error

What does this PR do?:
This PR updates the logic in the Component controller for handling scenarios where the Application isn't reconciled before the Component is.
Previously, if a Component's associated Application resource was not finished reconciling, or had an error state associated with it, we would return an error message in the Component. However, in scenarios where the the Component and Application are created together, it's not ideal to immediately display that error message.
With this PR, when the Component controller encounters that error, we instead add a counter annotation to the Component. If the error occurs 5 consecutive times, we then return the original error in the Component status. Otherwise, if the error goes away, we don't display it.
Which issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/browse/DEVHAS-264
PR acceptance criteria:

[ ] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

/retest


Check at runtime if data to be sorted is an array

Based on the type system, the data should be an array or undefined. However at runtime also other (truthy) objects are passed resulting in type error.

Problem reported in https://github.com/kubev2v/forklift-console-plugin/issues/248 can be recreated with following code snippet:
diff --git a/packages/legacy/src/queries/helpers.ts b/packages/legacy/src/queries/helpers.ts
index 8ae3338..2fd2470 100644
--- a/packages/legacy/src/queries/helpers.ts
+++ b/packages/legacy/src/queries/helpers.ts
@@ -124,7 +124,7 @@ interface IHasName {

 export const sortByName = <T extends IHasName>(data?: T[]): T[] => {
   const getName = (obj: T) => obj.name || obj.metadata?.name || '';
-  return (data || []).sort((a, b) => (getName(a) < getName(b) ? -1 : 1));
+  return (('foo' as unknown as T[]) || []).sort((a, b) => (getName(a) < getName(b) ? -1 : 1));
 };

 export const sortIndexedDataByName = <TItem extends { name: string }, TIndexed>(data: TIndexed) =>

Before

After


Automated cherry pick of #3630: Bump antrea.io/ofnet from v0.5.5 to v0.5.7
#3510: Fix the issue of local probe bypassing flows on Windows

Cherry pick of #3630 #3510 on release-1.5.
#3630: Bump antrea.io/ofnet from v0.5.5 to v0.5.7
#3510: Fix the issue of local probe bypassing flows on Windows
For details on the cherry pick process, see the cherry pick requests page.

/test-all
/test-windows-all

Codecov Report

Merging #3761 (e7581b0) into release-1.5 (9d35d65) will decrease coverage by 19.39%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.5    #3761       +/-   ##
================================================
- Coverage        60.82%   41.42%   -19.40%
================================================
  Files              333      200      -133
  Lines            28536    24164     -4372
================================================
- Hits             17356    10011     -7345
- Misses            9282    13120     +3838
+ Partials          1898     1033      -865

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.42% <0.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Close the PR.


Launch screen does not work on iOS9.0

The launch screen does not show up before starting the application.
Error generating launch image for org.nativescript.testApp: Error Domain=UILaunchStoryboardErrorDomain Code=1 "No such interface found."

Output: https://gist.github.com/vchimev/02f7d19d905a9812b86d

Could this be related to the LaunchScreen storyboard discussed in #281? Could you please try removing the LaunchScreen in platforms/ios and rebuilding?

Maybe its an xcode 7 issue since when i ran it on my real iphone 4s with ios 8.1 still have black screen, i will try your suggestion fealebenpae


Upgrade to ruby 2.3.3

Now that Ruby 2.4.0 stable is out, we should probably swap to ruby 2.3 to avoid falling too far behind.
https://www.ruby-lang.org/en/news/2015/12/25/ruby-2-3-0-released/ describes the misc benefits

Coverage increased (+0.0003%) to 99.352% when pulling 18c5846e9e9483ea612ffbbacdeb197f3b681174 on CloCkWeRX:upgrade_ruby23 into 1684c1058bd409a8618ed5458e90add8eb223149 on openfarmcc:master.

Hmm, this looks like 2.3.3 isn't available on rbenv. I'm going to investigate why that's the case.

Looks good :)


Exploration for GPU spot instances on Azure how-to guide

Context
Explore the implementation needed for https://warthogs.atlassian.net/browse/KF-5664.
What needs to get done
Explore how the implementation needed can be achieved in order to be able then to write a how-to guide
Definition of Done
Exploration has been done and findings are documented in the issue.

Thanks @DnPlas for the work I am adding some ideas.
I went through the guide. Agree with you that we can move this to done. There are some key things I want to mention.

I think gpu spot instances for azure will be limited to certain regions. I am also having some hard time finding information about GPU spot instances setup on internet.
The aks setup guide https://ubuntu.com/tutorials/install-kubeflow-on-azure-kubernetes-service-aks#1-overview  not sure if is still valid. If it will not work I recommend checking the ci with aks setup we use for uats.
The example from kubeflow examples is really old I dont think it will work out of the box. We should consider this during planning.

@misohu We also have this AKS kubeflow setup guide https://charmed-kubeflow.io/docs/deploy-charmed-kubeflow-to-aks

Thanks @misohu for your input!

I think gpu spot instances for azure will be limited to certain regions. I am also having some hard time finding information about GPU spot instances setup on internet.

Yeah, it was also the case for me, but from what I saw we just have to make sure to use the N series https://azure.microsoft.com/en-us/pricing/details/virtual-machines/linux/ and configure them accordingly when we create the pool of VMs.
As for the regions, I guess that depends more on the user than on us, so not sure if we need to do anything about it. wdyt?

The aks setup guide https://ubuntu.com/tutorials/install-kubeflow-on-azure-kubernetes-service-aks#1-overview not sure if is still valid. If it will not work I recommend checking the ci with aks setup we use for uats.

We need to update those guides you are mentioning + the one @orfeas-k linked, they both seem outdated.

The example from kubeflow examples is really old I dont think it will work out of the box. We should consider this during planning.

Agreed.

After reading https://charmed-kubeflow.io/docs/aks-spot , I do not think there is much more exploration we have to do. This document covers all the settings already, from the AKS configuration to the workload configuration. Perhaps the work we’ll have to do is:

Probably add more examples of how to configure workloads to be scheduled in the spot instances (right now we only have pipelines). I have in mind the following:

Training with GPU

Pipelines (already covered)

Perhaps a pipeline with specific steps going to the GPU spot instance and others staying in different node(s)

Revisit the format and the contents just to make sure it is what we want and users can find it useful

Thanks @DnPlas looking good ... if we will write about the GPU training we just might have an explanation mentioning the n series instances plus a little note that not all regions might have them. Approving the issue thanks :)

Closing this issue as we have all the required information now.


bug: default configuration value of jsx-boolean-value

The documentation for this rule says

The default value of this option is "never"

But ESLint using "react/jsx-boolean-value": 2 doesn't flag an error with
<Foo bar={true} />

I think the problem comes from
  var configuration = context.options[0] || {};

instead of
  var configuration = context.options[0] || 'never';

in the rule file

Good catch! I'll fix this.


Avoid potential null dereference looking up flags.

Trivial potential null pointer dereference.
-Mark

Good catch, thanks.


v-repeat Pagination

hi, I have an issue with pagination I have the following code

Vue.filter('paginate', function(value){

    var length = value.length;
    if(length > 10)
    {
        App.userList.pages = Math.ceil(length / 10);
    }
    else{
        App.userList.pages = 1;
    }

    App.userList.createPages();

    return value.filter(function(item, index){
        var indices = App.userList.currentPage * 10;
        if(index < indices && index > indices - 10)
        {
            return item;
        }
    });
});

and then in my view

v-repeat="list | filterBy searchText in username | paginate"

it works fine but the problem is it only works when the page is loaded. I want my items v-repeat to update when App.userList.pages value updates.

@masoodahm can you please post your solution Im trying to load Laravel 5 pagination with ajax but then i get pagination from<PHONE_NUMBER>011121314 to 38 instead 12345..38 so it actually works but pagination is huuge hehe


Update french translation

Hey,
I was a little bit busy last months, and finally took some time to update that.
If I remember correctly, you were saying last time that we will change the translation system since Roll20 support it now. I'm up the next two weeks if you want to do that (you'll just have to explain what I need to do).

You can read about the new system here: https://wiki.roll20.net/Character_Sheet_i18n
I plan to do it soon - a German guy offered some alterations and an Italian guy just messaged me as well so I should definitely set that up soon.
Everything looks good on this except "+ Mod. Dex.". The dex mod is always added. This is dex mod/100 to break a tie so I would word this differently.
Thanks!

Yep, totally right for break ties, it's fixed.


Links to pictures in chapter 13 seem to be broken

Pictures in chapter 13 do not show.

Fixed in last commit


chore: ignore .vscode directory

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jason Bedard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


First try of integration of github pages

The stub makes reference to another project

Ok, maybe we need to decide which ghitub page for documentation implements like

https://jekyllthemes.io/theme/documentation

https://jekyllthemes.io/theme/just-the-docs


CmpStatus is not displayed fully when run inside a keymap

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Announcement

[X] I have checked Breaking change announcement.

Minimal reproducible full config
-- | Fetches Lazy if not present.
local function bootstrap_lazy()
	local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
	if not vim.loop.fs_stat(lazypath) then
		vim.fn.system({
			"git",
			"clone",
			"--filter=blob:none",
			"https://github.com/folke/lazy.nvim.git",
			"--branch=stable",
			lazypath,
		})
	end
	vim.opt.rtp:prepend(lazypath)
end
bootstrap_lazy()

require("lazy").setup({
	{
		"hrsh7th/nvim-cmp",
		dependencies = { "hrsh7th/cmp-buffer" },
		config = function()
			local cmp = require("cmp")
			cmp.setup({ sources = cmp.config.sources({ { name = "buffer" } }) })
		end,
	},
})

vim.keymap.set("n", "<space>c", function()
	vim.api.nvim_cmd({ cmd = "CmpStatus" }, {})
end)

Description
CmpStatus is not displayed fully when run inside a keymap. The user needs to press enter to get the status fed to them.
Steps to reproduce

Open a file with Neovim, e.g., nvim .config/nvim/init.lua.
Press <space>c

Expected behavior
Selecting CmpStatus in Legendary runs the command and displays the full status:

Actual behavior
You need to press enter 3-4 times to get the full output of CmpStatus, line by line.
Additional context
No response

This is not a bug in cmp, but in nvim_echo.
The following can be reproduced regardless of cmp.
vim.keymap.set('n', '<Space>c', function()
  for _ = 1, 10 do
    vim.api.nvim_echo({ { 'hi\n', 'Normal' } }, false, {})
  end
end)

Huh, thanks @uga-rosa.
I found https://github.com/neovim/neovim/issues/22478, which, when completed, should address this issue in nvim-cmp.


Alternative support for VS2015 C runtime

This uses "weak" linkage to select code path depending on MS C runtime version. It doesn't need additional objects on the comand line, but legacy_stdio_definitions.lib for VS2015.

Nice

Continued here: https://github.com/D-Programming-Language/druntime/pull/1361


matrix-alertmanager: init at 0.5.0

Motivation for this change
I deployed this software in multiple organizations and it would be useful to have the packaging upstreamed.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Updated to 0.5.0


[do not merge] Debug multicluster ingress test failures

Having trouble reproducing flakes locally which seem consistent in CI, getting some debug info

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test integ-pilot-multicluster-tests_istio

/test integ-pilot-multicluster-tests_istio

/test integ-pilot-multicluster-tests_istio

/test integ-pilot-multicluster-tests_istio

/test integ-pilot-multicluster-tests_istio

integ-pilot-multicluster-tests has not failed on TestIngress across across 6 runs despite failing ~half the time in job history from what I can tell...

/test all

@Monkeyanator: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dafc2003a0d0f728d9f769aa029840e16c44c1b4
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Request: Pass DOM element to onSelectSlot

I want to render buttons on the calendar when a slot has been clicked in month view. Would you be able to pass the DOM element when calling onSelectSlot?
Or is there a better way of going about rendering buttons on the select date tile?

I created my own fork with this feature.


Null never shows up as an inner type in CandidType

We are missing a lot of Null in our property tests, we should ensure that it appears everywhere it needs to appear.

I think this will be resolved with https://github.com/demergent-labs/azle/issues/1524


Add a Fluentbit image build using Mariner containers

Which issue this PR addresses:
Fixes https://dev.azure.com/msazure/AzureRedHatOpenShift/_workitems/edit/13782744
What this PR does / why we need it:
This builds fluentbit from source in a Mariner build container and then places it in a Mariner runtime container.
The build is minimised to include as little functionality as possible, removing all available features except ones required by ARO for use in conjunction with MDSD.
Build portion at https://msazure.visualstudio.com/AzureRedHatOpenShift/_git/ARO.Pipelines/pullrequest/7089561
Test plan for issue:
Needs to be manually tested in a cluster.
Is there any documentation that needs to be updated for this PR?
N/A

I tested the images (as well as with Mariner-based MDSD for comparison) on a test cluster:

The overall CPU usage of the fluentbit container was reduced by 30% (so ~0.5% of a core across the cluster), but more interestingly, the memory usage was reduced by 60% (60MB across the base cluster!)
The logging rate of the test cluster was consistent at 8200 logs/hr.


Remove map link and add in logo/image of campaign on home page

When displaying the list of campaigns, display the image. The "map" link can be removed from the view. Lifted from #691.

@tonysurma can this issue be closed?  looks like fix has been merged for this issue.


Can't test donation flow on staging because of recaptcha

I wanted to test the latest deployment on now: https://opencollective-frontend-vjtbkdcktf.now.sh/veganbrussels/donate

This is not staging :-) I added now.sh in the Recaptcha config.


Detail of running on AirSim

I am trying to run AirSim 1.8.1 on Windows, but the drone often collides with buildings. Could you provide more details on running AirSim so that the cause can be found?

I also observed this with AirSim initially. I tried mitigating by checking for collisions in the transition model and assign large penalty when collision happens in the reward model. It got much better. I was able to consistently get trials without collisions. But since the planner has randomness, it didn't eliminate the occurrance.
Btw all the notes I have about AirSim are here: https://github.com/h2r/sloop/wiki/Running-SLOOP-object-search-on-AirSIm-UE4

Great! The drone can sometimes succeed in finding  the vehicle.
While there still exists some questions:
1.
The target car might be showing up in the images captured by the drone's camera, but it has not yet been located. This may due to the fact that the red car was manually placed in the Neighborhood environment. Is it possible for the car to be generated automatically based on specific coordinates?
2. What`s the effect of parameter "target_poses" in config?
3. The drone's action is sometimes labeled as "find," yet the car is not visible in the rendered image within the drone's field of view. Could this issue be caused by the misplacement of the target car?

Great! After following the notes in wiki, the drone can sometimes succeed in finding the vehicle!
While there still exists some questions:
1.
The target car might be showing up in the images captured by the drone's camera, but it has not yet been located. This may due to the fact that the red car was manually placed in the Neighborhood environment. Is it possible for the car to be generated automatically based on specific coordinates?
2. What`s the effect of parameter "target_poses" in config?
3. The drone's action is sometimes labeled as "find," yet the car is not visible in the rendered image within the drone's field of view. Could this issue be caused by the misplacement of the target car?

Answering to the best of my memory since it's been a while:

I'd say of course and it's an Unreal Engine question;  For my demos, I just created new scenes with fixed car placements.
That is the groundtruth location of the target object in the 20x20 grid. From the wiki, you will notice that I mapped the neighborhood environment in UE4 to a 20x20 grid. In this demo, in case you didn't notice, there's actually no real object detector being run; the observations were simulated based on the groundtruth location (with some noise) of the target on this grid.
It might be related to my point above. If you encounter this case, feel free to attach a screenshot and I could help you diagnose.


DNS Rebinding is to Slow

Instead of abusing the TTL on DNS entries. Why not have two IPs for one A record?
The way that browser works is if the first A recorded fails to connect the application will fall back to the next IP. This in theory would allow you to instantly do DNS rebinding without having to worry about and silly browse caching.

Not sure if I fully understand your technique, but we need the first request and DNS lookup to succeed as we load our (attacker) JavaScript/HTML code during this step. After the DNS has been rebound to the victim's IP address (e.g. <IP_ADDRESS>), the attacker JavaScript can then make arbitrary requests and read its responses from the localhost.

I made a awesome Diagram to show you what I'm talking about.

This takes advantage of A records round robin.

I think this won't work @robertmd , because the browser will prefer non-routable routes over the routable ones, so the initial HTML/JS from the attacker won't be loaded first.

@robertmd do you have a working PoC of this?

This PoC should work. I've tested the PoC a number of times with good results.
https://gist.github.com/robertmd/9f82efbd63926169e02c98673dcc9297

Cannot reproduce this on current versions of Chrome, Safari & Firefox on macOS 10.13 High Sierra. The browser always connects to the local IP first.
Can you share your versions / setup?

@simonerni I can't reproduce on Firefox but Chromium seems to go for the public IP first. Just trying to load pages atm, not trigger a rebinding attack.
I feel a bit dumb because I played with this in the past but my default browser is Firefox so I concluded it wouldn't work.
I'm playing around implementing this in my framework this afternoon. I'll update here if I get a full rebinding attack working.

I just tested it in the latest Firefox, Chrome, Edge on windows 10. They all appeared to be working. What order did you put the IPs in?

I could not reproduce this either, using Chrome, Safari and Firefox on macOS 10.13 High Sierra. This technique is supposed to work only if you specify public IP addresses records and is described in https://media.blackhat.com/bh-us-10/whitepapers/Heffner/BlackHat-USA-2010-Heffner-How-to-Hack-Millions-of-Routers-wp.pdf.

@robertmd On Windows 10, do the browsers hit the external IP address first?

yes, It does. I just tried it on Ubuntu and I am seeing the behavior you are describing, I'm trying it on windows 7 now.

On MacOS:

Firefox consistently loads the private IP first when two records are present.
Chromium seems to load the public IP first (@gdncc can you reproduce with Chromium?)

These were only testing loading an external resource when two A records were present. I didn't try DNS rebinding end-to-end.
I'm working on adding this to a branch of my framework for a full test, should be done in a couple of hours if you want to try it out: https://github.com/mwrlabs/dref/tree/iptables-fast-rebind

I was able to read the contents of the iframe from another domain. I made a short video showing it on windows. The top terminal is a remote server and the bottom one is a local server.

Added DNSRebindFromQueryMultiA DNS rebinding strategy, increasing the speed of DNS rebinding on several platforms.


Hang at 200 or 400 items

When using --comments and --media_metadata and attempting to scrape a non-limited (no use of --maximum) amount of posts from a user I tend to see the program stop at 200 or 400 and stay there. Can I get more debugging information somehow to see what's going on?

I am pleased to report it did eventually move on. It seems to get stalled at those and later 200 item increments. Perhaps rate limiting of some kind is going on.

I have similar behaviour using the following:
instagram-scraper denimwear --tag --maximum 1000 --comments --include-location -t none
Stops first around 83 and freezes for 10 min, then continues and stopps at 93 and freezes for 20 min... Is there an intended limit somewhere?


Db configuration

Allow for pvc to be retained or deleted when defining the deployment. Also allow for PVC size to be defined. I had to define the if statement in the way I did in case a user provided no input for the field. Open to suggestions on doing it cleaner though.
closes #112

Going to hold this until the 2.0 change merges


Fancy Zones 0.79 randomly changes zone size to drop behind task bar

Microsoft PowerToys version
0.79.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce

I created a three-zone template for an LG 32-inch monitor running 3840x2160 resolution driven by a MSI Radeon XTX 7900 24GB card. Using AMD Ryzen 7 5700X CPU on a MSI WiFi pro board.
Template has worked fine since inception two weeks ago -- which it was when I created it because this same problem happened on a lower version of Fancy Zones.
This morning upon starting the computer for the day, everything was fine. I walked away from the PC for breakfast, returned and the Fancy Zones are dropping behind the Task Bar. Fancy Zone editor does not appear to have a way to specify the size in pixels.
I have seen this issue dating all the way back to Fancy Zones 0.60.0 in 2022, but no solutions are proposed.
✔ Expected Behavior
I was expecting that the zones I saved in Fancy Zone would remain the same as they were when they were saved.
❌ Actual Behavior
Fancy zone resized zones to full monitor height, ignoring the Task Bar
Other Software
No response

I can confirm this happens to me now as well, on my primary monitor. My other monitors, using the same layout, are fine.
Also, if I turn taskbars off on my other monitors (Uncheck "Show my taskbar on all displays" in Personalization -> Taskbars") The zones do not update to fill the new space-- which they used to do. On my primary monitor, the windows are too large, and on my other monitors, the windows are too small.

#19066 provides a fix if you have two monitors in use. Moving the monitors around fixes the taskbar detection issue. Also mentioned this in #31972

I've had this happen a few times now whenever a monitor has been turned off and on, when the computer wakes back up from sleep, or even when the graphics driver reboots (like during an install). The most consistent way I've found to "fix" it is to hit Win+Ctrl+Shift+B to reset the graphics driver.
Also of note, often when this happens, not just powertoys displays over the taskbar. Often ALL windows overlay ontop of the task bar.

I've had this happen a few times now whenever a monitor has been turned off and on, when the computer wakes back up from sleep, or even when the graphics driver reboots (like during an install). The most consistent way I've found to "fix" it is to hit Win+Ctrl+Shift+B to reset the graphics driver.
Also of note, often when this happens, not just powertoys displays over the taskbar. Often ALL windows overlay ontop of the task bar.

That fix seems to work indeed. Thanks for sharing.
Hopefully they simply fix it permanently somehow.

Thank you!!
@.***
Eric Jay Toll
Journalist • Photographer • Writer
Phoenix, Arizona, U.S.A.
<EMAIL_ADDRESS>602-617-3797 mobile
Website: EricJayToll.comhttps://ericjaytoll.com/
Portfolio: EricJayToll.Contently.comhttps://ericjaytoll.contently.com/
Follow “On The Toll Road” on social media
@.@.https://www.instagram.com/ericjaytoll/[Icon  Description automatically @.***https://www.youtube.com/channel/UCKWa4JuWcaj6jpP8tCEZktA
From: KazuyaYuza @.>
Sent: Friday, June 28, 2024 1:09 PM
To: microsoft/PowerToys @.>
Cc: Eric Jay Toll @.>; Author @.>
Subject: Re: [microsoft/PowerToys] Fancy Zones 0.79 randomly changes zone size to drop behind task bar (Issue #32274)
I've had this happen a few times now whenever a monitor has been turned off and on, when the computer wakes back up from sleep, or even when the graphics driver reboots (like during an install). The most consistent way I've found to "fix" it is to hit Win+Ctrl+Shift+B to reset the graphics driver.
Also of note, often when this happens, not just powertoys displays over the taskbar. Often ALL windows overlay ontop of the task bar.
That fix seems to work indeed. Thanks for sharing.
Hopefully they simply fix it permanently somehow.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/32274#issuecomment-2197559320, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHTTDB7JJXE6AXJ6LNM2XNTZJW7E7AVCNFSM6AAAAABFZKJNICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGU2TSMZSGA.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

/dup https://github.com/microsoft/PowerToys/issues/17697


Various L4 and WB fixes, take 4

Fixes #555, #563, #565, #567, #570, #572, and #575.
See https://github.com/stm32-rs/stm32-rs/pull/577; "unrecoverable" git errors.
Not currently working:

Last 3 (by address) added L412 RTC regs are not adding
WB HSEM and IPCC renamed regs are not changing

Also removed the L4x2 USB_FS rename to USB: the RM calls it USB_FS.

Broke git again


Better static path analysis.

@amdrozdov I'll merge it in to complete the E2E test. Please post-review.


Vertical letterboxing when displayed on TVs

Hello,
I designed my app following all the rules from documentation and also I took examples from here, but Google Console keeps rejecting my app and I don't have enough details. Maybe you have any idea how can I know what is the problem or how to solve it?

Not designed in landscape orientation
Your app or game has vertical letterboxing when displayed on TVs. Please design your TV app or game to be displayed in landscape mode. Please refer to our TV Layouts documentation for more details.

All the pages are force to be landscape and I used AndroidX Leanback library
This is my app url
I really need help or any suggestion, please. I have had this problem for more than 5 months.
Thanks in advance.

Unfortunately the review team is separate from the team that manages these samples, but if you're using the leanback library for all screens and the orientation for every activity is set to landscape in your manifest, then the most likely problem is video that isn't in 16:9 format (e.g., a 3:2 video will have vertical letterboxing). I don't know the details of the review process but maybe a content format warning or a zoom to fit would help?

That's a good idea. I didn't think about this particular case. And I'll try it.
And Yeh, For sure I know the review team is separate. But as resources for Android TV development is so limited on the internet I thought that maybe someone here can figure out what is the problem.
@IanGClifton  Thank you so much :)


docs: add info about DefaultValue prop in Tabs

Motivation
The docs do not clearly mention the defaultValue prop available for Tabs, but I thought that we should for SEO reasons and to raise awareness about it.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Make sure the docs build.

thanks 👍


fix(#1737): textarea to show 0 characters remaining

Before (the change)
Textarea doesnt show '0 characters remaining'
After (the change)
Textarea does show '0 characters remaining'

Make sure that you've checked the boxes below before you submit the PR

[x] I have read and followed the setup steps
[x] I have created necessary unit tests
[ ] I have tested the functionality in both React and Angular.

Steps needed to test

issue is verified on react and angular

issue is verified

:tada: This PR is included in version 1.17.0-alpha.78 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.17.0-alpha.33 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.23.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Id4 submission

rejected:B1
It looks like you are trying to submit B1, however it seems like the following submission criteria are problematic:

Logs are missing
We’ve thus marked B1 as rejected, however if this is a mistake, please upload the log summary and we can re-review.

rejected:ID4
reason:We cannot fully verify this submission. It looks like you are trying to submit ID4, however, it seems like we cannot find the transaction between your account and Concordium Test Account.

rejected:ID4
reason:We cannot fully verify this submission. It looks like you are trying to submit ID4, however, it seems like we cannot find the transaction between your account and Concordium Test Account.

rejected:ID4
reason:We cannot fully verify this submission. It looks like you are trying to submit ID4, however, it seems like we cannot find the transaction between your account and Concordium Test Account.

transaction details

rejected:ID4
reason:We cannot fully verify this submission. It looks like you are trying to submit ID4, however, it seems like we cannot find the transaction between your account and Concordium Test Account.

transaction details

confirmed:ID4
AccountAddress:3RxMpLnSCq9cK8CZaMb6Cz3iWVv9UDWwcZVpYd6cXU1dLvWeCM
DeviceDetails:verified

confirmed:ID4
AccountAddress:3RxMpLnSCq9cK8CZaMb6Cz3iWVv9UDWwcZVpYd6cXU1dLvWeCM
DeviceDetails:verified


feat(/functions): adds POST /functions, DELETE /functions and PATCH /functions

Implements missing methods (POST & DELETE)
What kind of change does this PR introduce?
What is the current behavior?
Currently list and get methods are implemented on /functions route -  #115
What is the new behavior?
Adds POST /functions (implemented by create method) and DELETE /functions (implemented by remove)

[x] GET /functions
[x] GET /functions/:id
[x] POST /functions
[x] DELETE /functions/:id
[x] PATCH /functions/:id
Function properties that can be changed

[x] Name
[x] Schema

Thank you for all the feedback @w3b6x9 🙌  making the requested changes now - I love it here!


Chromosome-wise window stacking

adding the chromosome-wise window stacking

I think it's ok, now.


Route Specific IP Address Access Restriction

Specifications
TargetFramework: net6.0
Ocelot Version: 17.0.0
Description
Is there any feature to restrict a route so that only specific IP addresses will be able to access it?

Hello @ShaonDey you could implement a delegating handler and throw an exception if the IP address doesn't match.
You can Inject the HttpContext in the constructor - IHttpContextAccessor - and then get the source address by using httpContext.Connection.RemoteIpAddress?.ToString(), it's not bullet proof though.


EMScription build error on Stable 1.1

Log dump: http://dumptext.com/e7KqPSTN
uname -a
Linux arch-laptop 4.3.3-2-ARCH #1 SMP PREEMPT Wed Dec 23 20:09:18 CET 2015 x86_64 GNU/Linux
pacman -Q scons
scons 2.4.1-1
pacman -Q emscripten
emscripten 1.35.22-1
whereis emscripten
emscripten: /usr/lib/emscripten /usr/lib/emscripten/emscripten.py
pacman -Q llvm-libs
llvm-libs 3.7.1-1
Code used to produce error:
export EMSCRIPTEN_ROOT=/usr/lib/emscripten
scons -j 4 platform=javascript tools=no target=release

Thanks for the report. The HTML5 templates were kind of broken in 1.1, could you try the current git master branch to see if it works better for you?

Problem is that I'm writing a PKGBUILD for the AUR for the stable branch (and I'll be doing one for the -git branch afterward). See https://github.com/godofgrunts/arch-PKGBUILDs/blob/master/godot-export

stable branch does not really work with HTML5, but we'll release a new
stable in some weeks
On Fri, Jan 29, 2016 at 4:29 PM, godofgrunts<EMAIL_ADDRESS>wrote:

Problem is that I'm writing a PKGBUILD for the AUR for the stable branch
(and I'll be doing one for the -git branch afterward). See
https://github.com/godofgrunts/arch-PKGBUILDs/blob/master/godot-export
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3510#issuecomment-176926900.

Okay, you can close as wontfix if you'd like, I'll comment out the build until the next stable.

Thanks for working on AUR packages, that's great! As far as your stable package is concerned, you could probably go with the 2.0-beta tag directly, it's IMO as stable as 1.1 and with many fixed bugs.
/me should finish his Mageia package and push it live :)

I'm only referring to it as "stable" because there isn't a 2.0 stable yet. :+1:

Yeah I know that :) But as a fellow packager I'd still advise you to package the beta as godotengine-stable, it will save you some headache. 1.1 was not so packaging friendly IMO (especially since it did not support system wide templates).


META-56 Usecase Newspaper (per page; with PDF)

Should the PREMIS.xml of the TIFF and ALTO XML representations also contain a 'is source of' relationship with regards to the PDF? In a sense the individual file objects are not the 'real' source of the PDF; it's the combination of all of them that's the source. As of now the package PREMIS.xml contains a creation event that stipulates that the TIFF and ALTO XML representation objects are the source of the PDF representation outcome, and the PDF object contains 'has source' relationships with all of the other objects. Is this enough?

Should the PREMIS.xml of the TIFF and ALTO XML representations also contain a 'is source of' relationship with regards to the PDF? In a sense the individual file objects are not the 'real' source of the PDF; it's the combination of all of them that's the source. As of now the package PREMIS.xml contains a creation event that stipulates that the TIFF and ALTO XML representation objects are the source of the PDF representation outcome, and the PDF object contains 'has source' relationships with all of the other objects. Is this enough?

I think this is enough!


prometheus: Adjust probe timers

We want to react quickly to readiness changes, so other replicas get used.
We want to give 5 minutes grace on startup for crash recovery to complete, before we start killing the pod
Fixes #319

Test this please

Not sure why the e2etest is failing: Error: unknown command "cluster" for "kops" - I don't imagine that's my change causing it

@mikebryant Probably not. Sorry about that. I will re trigger the tests.
Test this please.

Broken in a different way.
=== RUN   TestAlertmanagerCreateDeleteCluster
2017/05/05 14:58:20 e2e setup successful
2017/05/05 14:58:20 Creating Alertmanager (prometheus-operator-e2e-tests-92ibccrp2qt5s/test)
2017/05/05 14:59:21 Deleting Alertmanager (prometheus-operator-e2e-tests-92ibccrp2qt5s/test)
2017/05/05 14:59:26 Creating Alertmanager (prometheus-operator-e2e-tests-92ibccrp2qt5s/test)
--- FAIL: TestAlertmanagerCreateDeleteCluster (65.99s)
	alertmanager_test.go:40: failed to create an Alertmanager cluster (test) with<PHONE_NUMBER>64 instances: timed out waiting for the condition

Again, I'm guessing this is just a test flake?

Interesting, not a flake I've seen before. But we'll re-run. Test this please @coreosbot!

lgtm thanks a lot @mikebryant !


An option to render single patch on a full page

config.fullPage. should then listen for window resizing etc. Probably the main patch should be closed when navigating to sub-patch only in the case when config.fullPage is true.

From #319:

...conf.singlePatch should be a renderer option, so it will auto-close patches opened before.

These options should corellate with each other: fullPage should control page resizing and singlePatch should control if previous patch should be closed when another was opened.


Update the link of one of the relevant articles

Hello! I never got the chance to mention it before, but thank you for linking one of my articles in your repository :)
1. Are you opening this pull request for bug-fixs, optimizations or new feature?
No
2. Please describe how these code changes achieve your intention.
I'm working on migrating my domain from twinnation.org to twin.sh, thus I'm preemptively updating the link to prevent it from becoming dead at some point
3. Please link to the relevant issues (if any).
N/A
4. Which documentation changes (if any) need to be made/updated because of this PR?
N/A
5. Checklist

[X] I have squashed all insignificant commits.
[X] I have commented my code for explaining package types, values, functions, and non-obvious lines.
[X] I have written unit tests and verified that all tests passes (if needed).
[X] I have documented feature info on the README (only when this PR is adding a new feature).
[X] (optional) I am willing to help maintain this change if there are issues with it later.

Thanks~


Not verbose enough error message

Background:
The error handling from addResultsForCases can be improved. It took me a fair amount of time to find out that my code was trying to update a tag which was not present into my TestRail suite:
13:41:20  tests-runner | Cannot update run due to Error: Request failed with status code 403
13:41:20  tests-runner | Cannot add result for case due to Error: Request failed with status code 400
13:41:20  tests-runner | The run 6190 is updated with undefined

Actual error found with extra debugging:
{
    "error": "Field :results contains one or more invalid results (case C347702 unknown or not part of the test run)"
}

Planning on proposing a contribution for a better error handling around this function shortly!
	async addResultsForCases(runId, data) {
		return this.axios.post('add_results_for_cases/' + runId, data).then((res) => {
			output.log(`The response is ${JSON.stringify(res.data)}`);
			return res.data;
		}).catch(error => {
			output.error(`Cannot add result for case due to ${error.response.data.error}`);
		});
	}


Latch revision

Updating the design with...

more compactness
VIK connector
optional latch pin functionality

Ordered but not tested.


Elliptical arc isn't being transformed correctly when using a negative scale

I am seeing some buggy behavior when I import the below SVG.
Original SVG:
<svg xmlns="http://www.w3.org/2000/svg" width="160" height="160" viewBox="0 0 160 160">
  <path fill="#000"
      transform="translate(160) scale(-1, 1)"
      d="M 0 160 V 80 A 80 80 0 0 1 80 0 h 80 V 80 A 80 80 0 0 1 80 160 Z"/>
</svg>

Optimized SVG:
<svg xmlns="http://www.w3.org/2000/svg" width="160" height="160" viewBox="0 0 160 160">
  <path fill="#000"
      d="M 160 160 V 80 A 80 80 0 0 1 80 0 V 80 A 80 80 0 0 1 80 160 h 80 z"/>
</svg>

Not totally sure, but I think the issue might be here:
https://github.com/svg/svgo/blob/master/plugins/_path.js#L265
From what I can tell, the elliptical arc commands are not having their sweep flags toggled correctly.

I guess it's been fixed by #752.


Test against Latest WP Version instead of Trunk

Ticket: #2562
Issue
There appears to be an unrelated failure occurring due to trunk changes in WP on #2562. This begs the question — why test against trunk at all?
Solution
Swap trunk for latest
Impact
We'll be a bit behind should a breaking change come in WP's functions (whereas before we could have caught it before formal release). However,
Usage Changes
None
Considerations
Should we maybe keep one trunk test in the matrix and allow failures?

Coverage remained the same at 89.774% when pulling 9ef1de215663927cd5d2e1ec39d4722ed470d169 on trunk_latest into 5344a44e98d5c801631a70ebcf48d02510ea299e on 2.x.

Testing trunk, as well as latest PHP version is important to spot bugs before they are released (see https://github.com/timber/timber/issues/2548) which prevents from running into issues when it comes out.
I don't have stats on this but I feel that latest version adoption is quite fast nowadays.

I hear that @nlemoine — maybe I was being a bit too cavalier. I agree, we should preserve some amount of trunk tests.
Perhaps the better "middle way" is now here with the latest commit: test against latest for most of the tests and keep one set of trunk tests. This way we can better identify what is a live issue in the code against WP vs. what could be a coming issue (or an accidental regression that the WP core team will likely resolve). What do you think?

I would keep two trunk:

PHP 8.1/trunk: to ensure Timber is still working on edge configuration
PHP 7.4/trunk: to ensure Timber is still working on edge WP

Both with allow failure on, so we can keep an eye on bugs to come but still let us merge things that are not ready yet to pass (or waiting that WP fixes some issues).

I've updated the test configuration.
I also think we should support PHP 8.1 as it's already out since a few months. It would be a shame to have a PHP 8.0.x only constraint. I already fixed the issues I've found for that version and It's only a matter of time before we have to support this.

So how do we manage the failed runs against WP trunk? Is there a state that they pass with the errors? Or do we manually check if it’s only those tests that fail and then overrule merging?

In the current test run, there’s also a PCOV error with PHP 7.4 against WP latest.

I don't think this related to GA trunk tests failing? It says "Review required"

I don't think this is related to GA trunk tests failing?  Merging isn’t blocked now, but I think we still need to manually check whether any failing checks are against WP trunk before merging.

I think we still need to manually check whether any failing checks are against WP trunk before merging.

Not sure I understand your comment. If some failures happen on trunk, you will see them but they will not prevent the "Merge" button. A failure on non trunk test will disable the "Merge" button.

This works! So just to clarify/confirm, the review is what creates the permission for the merge — not a setting in the config or matrix


ImportError: cannot import name AlphaRegularizer

Hi !
Thanks for your kind to evaluate NMT-KERAS.
I did try several versions of keras to deal with the trouble of "ImportError: cannot import name AlphaRegularizer"
Could you help me?
----> 6 from model_zoo import TranslationModel
7 import utils
8 from keras_wrapper.cnn_model import loadModel
D:\python-2.7.14\src\voice\nmt-py27-win-keras\nmt-keras\model_zoo.py in ()
5 from keras.models import model_from_json, Model
6 from keras.optimizers import Adam, RMSprop, Nadam, Adadelta, SGD, Adagrad, Adamax
----> 7 from keras.regularizers import l2, AlphaRegularizer
8 from keras_wrapper.cnn_model import Model_Wrapper
9 from keras_wrapper.extra.regularize import Regularize
ImportError: cannot import name AlphaRegularizer

Hi @Jeen-Hur ,
please, make sure you're using our Keras fork

HI @Ivapeab!
How can I install your version of Keras fork using conda?
Thank you in advance!

I am trying to install Anadonda Python 3.7 for Windows and then tensorflow-gpu and then nmt-keras.  Per above, your version of keras needs to be installed first.  But then conda will try to uninstall it or install another keras on top of it.  Would it be possible for you to try doing an install from scratch of Anaconda and nmt-keras on a Windows PC and tell us how you navigate around conda's dependency checking?

try
installing from the correct repository
pip install git+https://github.com/MarcBS/keras.git

i faced the same issue when i tried
pip install keras


handle endpoint level parameters with openapi4j parser

see openapi-processor/openapi-processor-spring#122

grmp, used wrong issue number (#122) in commit instad of #58.


fix: Limit parallel builds on operator

Usually the builds get strictly queued because of potential image layering in terms of reusing the integration kits. There are situations though where parallel builds on the operator are possible.

Avoid many running integration builds
Monitor all builds started by the operator instance and limit max number of running builds according to given setting
By default use max running builds limit = 3 for build strategy routine
By default use max running builds limit = 10 for build strategy pod
Add max running builds setting to IntegrationPlatform

Release Note
fix: Limit parallel builds on operator

@claudio4j @squakez could you please rerun the failed workflows? I assume that the errors are flaky tests and are not related to the changes made in this PR

@squakez YAY, checks are green. I will rebase and resolve the conflicts

@squakez I finally managed to add an E2E test, could you please trigger the workflow once more? thx

@squakez no idea what is happening with the jobs here. all green on my fork christophd#92

let's give another spin


Parameters for most things

command line parameters for: debug, cameras (in/out), size, background, threads, avoids edit/recompile cycles for faster experimentation.

Excellent, thanks, merged!


[SPARK-41965][PYTHON][DOCS][WIP] Add DataFrameWriterV2 to PySpark API references

What changes were proposed in this pull request?
Add DataFrameWriterV2 to PySpark API references
Why are the changes needed?
DataFrameWriterV2 was not added in the API references
Does this PR introduce any user-facing change?
doc-only
How was this patch tested?
CI

merged into master


Fixes instance & instance template errors

introduces in this PR:
https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/pull/42
Issue:
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/issues/434

#46 merged


Browser Push Notifications on Android

I tested the demo page, https://cipchk.github.io/ngx-notify/ on my android phone, and Browser Push notifications do not work. I am running Chrome 67.0.3396.87 on Android 8.0.0, One Plus 3T.

Pls refer to browser compatibility


data-chromatic="ignore" not working correctly

I have added data-chromatic="ignore" to the div that displays the date, yet I'm getting a Chromatic failure when the length of the date changes.  As the date changes, so will the width of that div and it should pass regardless because of the "ignore" tag.  For the "ignore" to be useful, it needs to ignore both value and width changes.  Here you can see that it seems to only know about the first 192.67px.

Please reach out on Intercom if you haven't already. The issue is unrelated to this repository.

What's intercom?  Can you provide a link, plz?

Intercom is our chat bubble on the webapp. Also visible on e.g. the docs pages. Alternatively you can email<EMAIL_ADDRESS>


"Where is my weapon?" Thread did not finish "where is my weapon" mod errors

Describe the bug
After the game crashes , i reload the file and i get this error , i have over 200 mods installed so i can't snipe easily which mod is giving problems , the game works fine when i create a new world so it's kinda tricky.
To Reproduce
Steps to reproduce the behavior:

Open world map
Stay on world map for a while until the game crashes
Reload save file
Profit

Error Log
[
Player.log
](url)
Mod List
Too many mods

WhereIsMyWeapon.Patch_Pawn_HealthTracker_HealthTick.Postfix

Please test with the new version, and re open this issue if needed

tested with 2.2.17, unable to reproduce the issue. Mod works fine now


Move logging fields under params

https://github.com/probot/probot/blob/master/src/wrap-logger.ts#L53-L59
says that any key should be fine but I tried to match the other log lines and see if it makes filebeat happy

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ability to open a binary WebSocket connection

Currently, it seems to be impossible to create an HttpConnection with a binary WebSocket transport. It defaults to text.
The solution in my fork is to make SetTransferMode() public so that I can call it before StartAsync().

You need to set the transferModeFeature to TransferMode.Binary. See: https://github.com/aspnet/SignalR/blob/dev/src/Microsoft.AspNetCore.SignalR.Client.Core/HubConnection.cs#L88-L100

@KPixel why are you changing the mode manually?

I am not using SignalR, just the Sockets layer.
Regarding setting the transferModeFeature, that's exactly what SetTransferMode() does, so I don't want to duplicate it.

Ah cool!

SetTransferMode is not part of the interface. We could possibly expose it as an extension method on IConnection.

That's fine with me.
And HubConnection can re-use it as well.


RHISOS 470 | IOPS Values from Rules are actuals

Changes are based on the assumption that IOPS values are actuals from rules

Thanks @saltgen for the quick fix and @PreetiW for testing it sooner! Merged!

Working like a charm, thanks @saltgen


Manually invoke completions with Ctrl+Space, most appropriate completion not selected

Using latest from master
I have no choice but to use the arrow keys in order to complete assertEquals

Another example, if I press Ctrl+Space here:

And then type ad while the completions drop down is there I get:


Add smarty fuel

@lam-vy-mulodo
Plz review this pull request. thanks

@Hung-Phan-Mulodo Hung
Please merge into master branch. Thanks!


Uncaught exception when calling connection.console.info()

I received the following error when trying to use the info() method of the RemoteConsole object  while in my completion provider. The other console methods were not affected and operated normally.
Notification handler 'window/logMessage' failed with message: EPERM: operation not permitted, write
Essentially the relevant code I was using boiled down to:
connection.onCompletion((position: TextDocumentPosition): CompletionItem[] => {
  connection.console.info('...');
});

vscode-languageserver: 1.3.1
os: windows 10

This is an issue in the extension host. Moving to vscode

This issue was moved to Microsoft/vscode#3128


Using split tab on vim

I would like to see if there is an option to create a split tab on vim such that I can see 2 vim windows side by side, without opening a new ‘msys’ window entirely.
Right now if I open msys I get one vim window. If i try right clicking it and select ‘split tab’, it opens a powershell window which i do not know how to use to navigate to vim.

open 1 file first, then type :vsp the next file you want to open

You can try this out bro I think it works
split screen — :vsplit {filename.java} for vertical split, :split {filename.java} for horizontal split

change between tabs in vim — ctrl + w + w (i.e. press w twice)

it works bro thanks


[2201.4.x] Include service types category in API docs generation

Purpose
Currently service type objects are shown as object types. This will add a flag isService in object types to check whether the object type is a service type.
isService flag for service classes is also added to specify service classes under the same category (Classes).
Fixes #39210
Approach
When setting the module from syntax tree, service objects will also be filtered as an object type. Then the doc generation will look for Service keyword in the qualifiers to identify whether it is a service object or not. If it is, it will be added to Service Types category instead of Object Types.
Samples
An example for a service object is shown below.
public type BugDiscussionService service object {
    # The remote method that will be called when a bug discussion is opened.
    # + event - the event notification payload
    remote function onDiscussionOpened(BugDiscussionOpenedOrCommentedEvent event);
    # The remote method that will be called when a bug discussion is commented on.
    # + event - the event notification payload
    remote function onDiscussionCommented(BugDiscussionOpenedOrCommentedEvent event);
    # The remote method that will be called when a bug discussion is labeled.
    # + event - the event notification payload
    remote function onDiscussionLabeled(BugDiscussionLabeledEvent event);
    # The remote method that will be called when a bug discussion is closed.
    # + event - the event notification payload
    remote function onDiscussionClosed(BugDiscussionEvent event);
};

When we generate API docs for this, it will generate api-docs.json file as follows.

isService flag is also added to classes.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Are there any test cases for this ?

Currently there are no test cases for this? Shall include a test for this?


CosmWasm 2.0

It looks that CosmWasm 2.0 has been released:

https://github.com/CosmWasm/cosmwasm/releases

but wasmd hasn't been updated yet:

https://github.com/CosmWasm/wasmd/releases

Let's wait for it to be updated, but I'm opening this issue to keep track of their progress, since we probably want to avoid doing a lot of work right now just to later realize that there are tons of breaking changes (which, btw, I don't know how "breaking" 2.0 is).

It seems that wasmd of version 0.51 is already in the project. May close the issue.

thanks, you're right


#1: add support for horses in database initialization

✏ Note: The title of the pull request, which references a user story in GitHub matters: once the pull request is merged, the corresponding user story (GitHub issue #1) will be automatically closed.
✏ Note: A GitHub pull request can be used to merge Branches (as is the case here) or to import changes from a Forked repository. For a brief explanation of the pull request workflow see Understanding the GitHub flow.

/paulo - can you please review this pull request?

/paulo - can you check now?

/paulo - can you check now?


Address Chromium "situation"

Chromium as packaged is intentionally unusable in Mint 20. I'm working on another PR that removes it from the current playbook, so we don't give the wrong impression of it working. The alternatives are somewhat documented here: https://forums.linuxmint.com/viewtopic.php?f=42&t=321953 or we can close this with an intentional WONTFIX on record.

For additional history & context: Chromium support was added in #177 to support Lab05 for CS 101. The Chrome/Chromium dev tools are used as part of the lab. For the features used, Firefox absolutely should be sufficient. Based on old emails from that time, it sounded like Chrome was never a hard requirement, so Firefox might be a good option to pursue.
Of the alternatives, the "portable" option is probably the least bad. Snaps in Mint are asking for trouble, so is adding upstream buster sources; the beta or developer aren't ideal for distributing to potentially CS101 students who need to complete an assignment ASAP don't want to deal with beta bugs; ungoogled chromium requires adding another apt repo as well.

Mint has announced that they will be packaging Chromium directly: https://blog.linuxmint.com/?p=3969


New account page layout

Attempt at issue #2426
Not sure if coding style matches what is wanted, mainly the parts using bootstrap row and col
Everything seems fine on this end

Messed up branching. Changes are in our master branch instead of this one.


Embed image return 550 "This messsage is classified as spam"

Hi!
In Symfony, I try to send a email with embedded an image, but Swiftmailer returns:

[2015-07-07 20:23:39] request.CRITICAL: Uncaught PHP Exception Swift_TransportException: "Expected response code 250 but got code "550", with message "550 This messsage is classified as spam (4.6). "" at /home/www/example.com/symfony/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php line 383 {"exception":"[object] (Swift_TransportException(code: 550): Expected response code 250 but got code \"550\", with message \"550 This messsage is classified as spam (4.6).\r\n\" at /home/www/example.com/symfony/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php:383)"} []

Recognizes the message as spam.
My code is:

$message = \Swift_Message::newInstance(null);
$message->setSubject('Thanks!');
<EMAIL_ADDRESS>=> 'Biller'));
$message->setTo($username);
$message->setBody(
	$this->renderView(
		'BillerBundle:Email:registration_client.html.twig',
		array(
			'header' => $message->embed(\Swift_Image::fromPath('/home/www/example.com/symfony/web/bundles/biller/images/banner-mailing-header.jpg')),
			'firstName' => 'Name',
			'username' => $username,
			'password' => 'Password'
		)
	),
	'text/html'
);
$numSent = $this->get('mailer')->send($message);

When I comment  the "header", Swiftmailer send email.
I have also tried:

$imgPath = '/home/www/example.com/symfony/web/bundles/biller/images/banner-mailing-header.jpg';
$imgType = pathinfo($imgPath, PATHINFO_EXTENSION);
$imgData = file_get_contents($imgPath);
$imgBase64 = 'data:image/' . $imgType . ';base64,' . base64_encode($imgData);
...
'header' => $message->embed(\Swift_Image::newInstance($imgBase64, $imgPath, 'image/jpeg')),

But, returning the same error.
Do you know how to enable Swiftmailer send emails with embedded images?
Thanks!

Check with your hosting provider. They are rejecting your email
Le 7 juil. 2015 11:31 PM, "sgb004"<EMAIL_ADDRESS>a écrit :

Hi!
In Symfony, I try to send a email with embedded an image, but Swiftmailer
returns:
[2015-07-07 20:23:39] request.CRITICAL: Uncaught PHP Exception
Swift_TransportException: "Expected response code 250 but got code "550",
with message "550 This messsage is classified as spam (4.6). "" at
/home/www/
example.com/symfony/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php
line 383 {"exception":"object"} []
Recognizes the message as spam.
My code is:
$message = \Swift_Message::newInstance(null);
$message->setSubject('Thanks!');
<EMAIL_ADDRESS>=> 'Biller'));
$message->setTo($username);
$message->setBody(
$this->renderView(
'BillerBundle:Email:registration_client.html.twig',
array(
'header' => $message->embed(\Swift_Image::fromPath('/home/www/example.com/symfony/web/bundles/biller/images/banner-mailing-header.jpg')),
'firstName' => 'Name',
'username' => $username,
'password' => 'Password'
)
),
'text/html'
);
$numSent = $this->get('mailer')->send($message);
When I comment the "header", Swiftmailer send email.
I have also tried:
$imgPath = '/home/www/example.com/symfony/web/bundles/biller/images/banner-mailing-header.jpg';
$imgType = pathinfo($imgPath, PATHINFO_EXTENSION);
$imgData = file_get_contents($imgPath);
$imgBase64 = 'data:image/' . $imgType . ';base64,' . base64_encode($imgData);
...
'header' => $message->embed(\Swift_Image::newInstance($imgBase64, $imgPath, 'image/jpeg')),
But, returning the same error.
Do you know how to enable Swiftmailer send emails with embedded images?
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/swiftmailer/swiftmailer/issues/635.


[WIP] Update repo to work with Terraform 0.13

Tests passed! Could I have one more review please? 😇

Thanks for the review! Merging now.


0.4.0 stack usage increase?

Recently I upgraded some code to use nanopb .0.4.0, but I'm having some problems with significantly higher stack usage with the new version.  We're building this for an embedded ARM-based microcontroller (STM32F4).  We're compiling with GCC, optimization level -O2.
Our compile options for nanopb are:
-DPB_FIELD_16BIT
-DPB_WITHOUT_64BIT
-DPB_NO_ERRMSG

One example is a schema with the following definition:
message ItemList
{
    repeated uint32 ids  = 1;
    uint32 version       = 2;
}

We specify a maximum length in the options file:
ItemList.ids max_count  : 16

For that reason, decoding the ItemList pb is very simple:
bool LoadModel(uint8_t* buffer, size_t size, ItemList* model)
{
    pb_istream_t iStream =
        pb_istream_from_buffer(buffer, size);
    return pb_decode(&iStream, ItemList_fields, model);
}

Here's the 5-byte buffer that is being decoded:
0A 01 00 10 01

In my experiments, nanopb 0.4.0 used about 60% more stack than the old version we were using, going from 236 to 376 bytes of stack to decode the buffer above.    The old version was a pull of master from late 2018, I believe--git describe says nanopb-0.4.0-dev-32-g580d7c8.
I also ran a similar test with a much more complicated schema (see below) and got similar results: an increase from 884 bytes to 1445 bytes to decode the message.
Is this change intentional/expected?  Are there any options I can set to reduce stack usage?
Schema for the more complicated message:
message Property
{
    enum Mode
    {
        A = 1;
        B = 2;
        C = 3;
    }

    oneof field
    {
        Mode   DeviceA_Mode     = 1;
        uint32 DeviceA_Size     = 2;
        uint32 DeviceA_Length   = 3;

        Mode   DeviceB_Mode     = 4;
        uint32 DeviceB_Size     = 5;
        uint32 DeviceB_Length   = 6;
    }
}

message SettingsGroup
{
    message Settings
    {
        message Command
        {
            uint32 label                 = 1;
            repeated Property properties = 2;
        }

        uint32      id      = 1;
        string      name    = 2;
        uint32      flags   = 3;
        bool        en      = 5;
        Command     begin   = 6;
        Command     end     = 7;
    }

    Settings settings   = 1;
    uint32 version      = 2;
}

Options:
* anonymous_oneof: true
* long_names     : false
SettingsGroup.Settings.name               max_length : 32
SettingsGroup.Settings.Command.properties max_count  : 6

I have a similar question about stack usage. I am using GCC 9.2.1, with -Os, with nanopb 0.4.4.
When decoding a (fairly large) protobuf struct into a statically allocated buffer (target size ~925 bytes),
it seems stack usage is very large (for the tiny Cortex-M0 running this application).
This is the GDB backtrace:
(gdb) bt
#0  0x10059896 in load_descriptor_values (iter=iter@entry=0x20000700 <snt_task_stack+148>) at ../../../libs/nanopb/pb_common.c:14
#1  0x100599e8 in pb_field_iter_begin (iter=iter@entry=0x20000700 <snt_task_stack+148>, desc=0x10067c44 <firmware_version_t_msg>, message=0x20001168 <profile+312>) at ../../../libs/nanopb/pb_common.c:163
#2  0x10058eb4 in pb_decode_inner (stream=stream@entry=0x20000778 <snt_task_stack+268>, fields=<optimized out>, dest_struct=<optimized out>, flags=0) at ../../../libs/nanopb/pb_decode.c:986
#3  0x10058a6c in pb_dec_submessage (field=0x20000810 <snt_task_stack+420>, stream=0x20000888 <snt_task_stack+540>) at ../../../libs/nanopb/pb_decode.c:1594
#4  decode_basic_field (stream=stream@entry=0x20000888 <snt_task_stack+540>, wire_type=wire_type@entry=PB_WT_STRING, field=field@entry=0x20000810 <snt_task_stack+420>) at ../../../libs/nanopb/pb_decode.c:451
#5  0x10058bb2 in decode_static_field (field=<optimized out>, wire_type=<optimized out>, stream=0x20000888 <snt_task_stack+540>) at ../../../libs/nanopb/pb_decode.c:538
#6  decode_field (stream=0x20000888 <snt_task_stack+540>, wire_type=<optimized out>, field=0x20000810 <snt_task_stack+420>) at ../../../libs/nanopb/pb_decode.c:792
#7  0x10059072 in pb_decode_inner (stream=stream@entry=0x20000888 <snt_task_stack+540>, fields=<optimized out>, dest_struct=<optimized out>, flags=0) at ../../../libs/nanopb/pb_decode.c:1089
#8  0x10058a6c in pb_dec_submessage (field=0x20000920 <snt_task_stack+692>, stream=0x20000998 <snt_task_stack+812>) at ../../../libs/nanopb/pb_decode.c:1594
#9  decode_basic_field (stream=stream@entry=0x20000998 <snt_task_stack+812>, wire_type=wire_type@entry=PB_WT_STRING, field=field@entry=0x20000920 <snt_task_stack+692>) at ../../../libs/nanopb/pb_decode.c:451
#10 0x10058bb2 in decode_static_field (field=<optimized out>, wire_type=<optimized out>, stream=0x20000998 <snt_task_stack+812>) at ../../../libs/nanopb/pb_decode.c:538
#11 decode_field (stream=0x20000998 <snt_task_stack+812>, wire_type=<optimized out>, field=0x20000920 <snt_task_stack+692>) at ../../../libs/nanopb/pb_decode.c:792
#12 0x10059072 in pb_decode_inner (stream=stream@entry=0x20000998 <snt_task_stack+812>, fields=<optimized out>, dest_struct=<optimized out>, flags=1) at ../../../libs/nanopb/pb_decode.c:1089
#13 0x10058a6c in pb_dec_submessage (field=0x20000a30 <snt_task_stack+964>, stream=0x20000ab0 <snt_task_stack+1092>) at ../../../libs/nanopb/pb_decode.c:1594
#14 decode_basic_field (stream=stream@entry=0x20000ab0 <snt_task_stack+1092>, wire_type=wire_type@entry=PB_WT_STRING, field=field@entry=0x20000a30 <snt_task_stack+964>) at ../../../libs/nanopb/pb_decode.c:451
#15 0x10058bb2 in decode_static_field (field=<optimized out>, wire_type=<optimized out>, stream=0x20000ab0 <snt_task_stack+1092>) at ../../../libs/nanopb/pb_decode.c:538
#16 decode_field (stream=0x20000ab0 <snt_task_stack+1092>, wire_type=<optimized out>, field=0x20000a30 <snt_task_stack+964>) at ../../../libs/nanopb/pb_decode.c:792
#17 0x10059072 in pb_decode_inner (stream=stream@entry=0x20000ab0 <snt_task_stack+1092>, fields=<optimized out>, dest_struct=dest_struct@entry=0x20001030 <profile>, flags=flags@entry=0) at ../../../libs/nanopb/pb_decode.c:1089
#18 0x100590e8 in pb_decode (stream=stream@entry=0x20000ab0 <snt_task_stack+1092>, fields=<optimized out>, dest_struct=dest_struct@entry=0x20001030 <profile>) at ../../../libs/nanopb/pb_decode.c:1165
#19 0x1005d5b0 in pb_profile_decode (dst_profile=0x20001030 <profile>, src_pb=src_pb@entry=0x2000182c <smalloc_pool> "\b\356\237\360\326\v\022\006\066\065\061\063\067e\032\004\b\001\020\t\"P\n\020\b\254\002\020(\030\310\001 \002(\024\060\003H\001\022\022\b<\020",
    len=len@entry=578) at ../../../libs/libsnt/src/protobuf/profile_protobuf.c:79
<...>

pb_decode_inner seems to be recursively called, and using quite some stack.
In this case I calculated total nanopb stack usage to be ~1040 bytes.
Is this to be expected? Is there a way to work around this issue?
Would it help using FT_CALLBACK, or doesn't that change anything about stack usage?
Thanks,
Maxime

@maximevince Yeah, it is to be expected that stack usage grows in relation to the number of submessage levels.
Callbacks don't directly make a difference. In long term it would be better to make nanopb store only the required information (buffer pointer etc.) on each recursion level, instead of the full stack frame needed by recursive C functions, but that is a quite large change.
I'm not aware of any particularly effective workaround, other than changing the .proto structure to have less submessage levels.

@PetteriAimonen thanks for your swift reply. Now that we know the limitations, we can work with/around them.
Thanks for your excellent project, by the way.


large weight changes should be ignored at beginning of shot

I notice that if there is a very large weight change in the first few seconds it is recorded and ruins the graph.

A solution would be to ignore large weight changes like this as they are glitches in the weight system tare setting to zero at a guess delivering incorrect numbers.
Alternatives would be for the Decent Scale to hide these from the interface.
example: https://visualizer.coffee/shots/7c08927f-dc58-4f03-82af-abf2fc948429

Visualizer just displays what's uploaded in the .shot file.
I think you should report this behavior to John or someone over at Basecamp since the scale should not be reporting these values, or if it does, the app should discard them.
On the Visualizer side what you can do is show/hide chart lines by clicking on their name under the chart.