Research: v5 transaction format

Just opening this issue to have a URL to share until I and/or another contributor get around to implementing a demo of cross-input signature aggregation in detached signatures, presumably as part of a v5 transaction format proposal. Also implicit/optional sequence numbers (but not locktime to avoid disincentivizing re-org resistance), probably some solution for fractional satoshis, maybe implied OP_RETURNs, and compactUint everything else. (And consider enabling or requiring v5 TXs to support UTXO Hash Sets.)
A key goal is to reduce the size/cost of CashFusion transactions, e.g. the largest one so far was ~40KB, with 261 inputs and 114 outputs1. Replacing each signature in this TX with a reference to a detached signature (e.g. OP_1) would save 261 * 64 = 16,704 bytes (minus the aggregated, detached signature itself), bringing the transaction size down to ~24KB (41% savings). The savings are also greater for transactions with more inputs than outputs, so the overall effect will also encourage (privacy-preserving) UTXO set consolidation.
Also worth noting that we could save an additional 261 * 33 = 8,613 bytes (down to ~15KB, for 62% total savings) if all inputs switched to P2PK rather than P2PKH. Between the funding output (the change output of the last TX) and fusion input, each user saves 24 bytes of public key hash and P2PKH overhead.
There are some privacy considerations on the P2PK usage: you don't want to leak which output is the "change" if you're paying to P2PKH, but if the funding transaction was already using PayJoin, there was no meaningful cost to negotiating P2PK addresses rather than P2PKH. We can also expect 1) network wide P2PK usage to increase due to the cost savings and 2) if some popular wallets support both P2PK and P2PKH (esp. mixed use) the difference stops being useful as a privacy-breaking heuristic (wallets could even juggle funds between them to throw off naive trackers).

Chaingraph Queries
Paste into https://try.chaingraph.cash/:
 {
  transaction(
    where: {
      hash: {
        _eq: "\\xf55237e16408134f6ff21c75c857f0db38dc106a7bf2572af3717475cbefdf02"
      }
    }
  ) {
    hash
    input_count
    output_count
    size_bytes
    encoded_hex
}

Result:
{
  "data": {
    "transaction": [
      {
        "hash": "\\xf55237e16408134f6ff21c75c857f0db38dc106a7bf2572af3717475cbefdf02",
        "input_count": "261",
        "output_count": "114",
        "size_bytes": "40703",
        "encoded_hex": "[... snip ... ]"
      }
    ]
  }
}

Note: until we improve performance of this sort of query, you need a trusted instance to find/filter CashFusion transactions:
query CashFusionTxs {
  search_output_prefix(
    args: { locking_bytecode_prefix_hex: "6a0446555a00" }
    limit: 100
  ) {
    transaction_hash
    transaction {
      input_count
      output_count
      size_bytes
      block_inclusions {
        block {
          hash
          height
        }
      }
    }
  }
}

Latest spitball for v5 TXs (given Limits/BigInt work):

Both fractional satoshis and fractional cashtokens could be represented by two CompactUints - first is whole units, second is a numerator with the CompactUint length indicating the denominator, e.g. 0x40 is 64/256 (0.25), 0x80 is 0.5, 0xc0 is 0.75, up to 0xfc (252/256, 0.984375), then up to 0xfdffff (65535/65536, ~= 0.999985), 0xfeffffffff<PHONE_NUMBER>/4294967296 ~= 0.99999999977), and 9*ff<PHONE_NUMBER>3709551615n/18446744073709551616n, that's 0.999... to 19 decimal places).

This optimally-minimizes byte length for representing evenly-divided precisions (i.e. splitting values between outputs), and allows another satoshis_or_tokens *<PHONE_NUMBER>3709551616n of precision with minimal complexity in balancing TX inputs/outputs using only 64-bit math.
Note that this format makes representing some base-10 fractions a little messier (0.1 is the classic example): good approximations for .10 are 0x1a (26/256=0.1015625), 0xfd9a19 (6554/65536 = 0.1000061035), 0xfe99999919 (429496730/4294967296 ~= 0.10000000009313226), or even ff9a99999999999919<PHONE_NUMBER>3709551620000000000000000000n /<PHONE_NUMBER>3709551616n =<PHONE_NUMBER>000000000n, that's .1000... to 19 decimal places) but it's easy to select/format for human consumption, e.g. in JS: (26/256).toFixed(2) = '0.10'. Even for these non-base-2 amounts, the overall cost of representing a satoshi amount is typically better than today's highly inefficient format. E.g. 1.1 satoshis is 0x011a (1.1015625 sats) or even 0x01FE99999919 (1.1 to 10 decimal places) as compared to today's whole-unit single satoshi encoding of: 0x0100000000000000. (And remember, at these precisions, humans are not typing base-10 numbers: human-typed numbers are being converted, often through an exchange rate and a UTXO selection algorithm, to the best choice by wallet software, optimizing for fees by minimizing transaction byte-length.)

New OP_UTXOTOKENAMOUNTPRECISE, OP_OUTPUTTOKENAMOUNTPRECISE, OP_UTXOVALUEPRECISE, and OP_OUTPUTVALUEPRECISE opcodes could return values as BigInts of maximum precision (existing operations should continue returning whole units; critical for contracts wanting to operate within more strictly enforced boundaries, e.g. some market making algorithms).
New fungible CashToken mints can either continue to exclude the extra precision, or with another TOKEN_PREFIX bitfield set, include the "fractional" CompactUint on all token amounts. (Existing token systems can create trustless migration covenants, but we can't add precision to existing cashtokens without breaking the possible expectation of indivisibility; also, a lot of fungible token systems probably don't want or need the extra divisibility, and saving 1-byte per output would continue to be a feature of "indivisible" cashtokens.)
Detached signatures after locktime (no need to bundle with a protocol-level signature aggregation algorithm, they're useful already, and a future upgrade can lock down a non-interactive aggregation system) or 0x00 if none.
0 amounts imply OP_RETURN
Compress everything else (except locktime) with CompactUints.

Adding to spitball (revisiting byte saving ideas from here):

Allow non-push opcodes in unlocking bytecode: this would create a malleability concern in v1 and v2 transactions, but since v5 transactions can optionally eliminate malleability with detached signatures, it's actually reasonable to offer users both features at the same time.

This would allow e.g. giant P2PKH address sweep transactions to specify <0> <key.public_key> in the zeroth input (where the 0 references the first detached signature), and all later inputs would have a 6-byte unlocking bytecode: <0> <0> OP_INPUTBYTECODE <2> OP_SPLIT OP_NIP (0x00ca527f77). Saving 94 bytes per input after the first input: 65-byte schnorr signature, plus 33-byte compressed public key, plus 2 bytes of push opcodes, minus the 6-byte pattern.
Savings for more complex contracts also rack up too – similar P2SH20 and P2SH32 UTXOs can be spent by pushing most or all of the redeem bytecode only once, with later inputs referencing it. (And note that the availability of this feature would allow contract authors to design with it in mind, optimizing final TX sizes.)
OP_EVAL would generally save some bytes of parsing operations (e.g. 4 bytes above), esp. for inputs that truly need only to copy the exact contents of another input (copying up to 16 inputs is 3 bytes, up to 127 is 4 bytes).
We could consider some sort of "detached data" annex that allows for arbitrary data to be referenced (rather than just signatures), but that adds some meaningful additional complexity around control of the annex contents (locking bytecode can't really use it safely, since it needs to commit to things in advance – any use of such an annex would be very similar to just using the stack) and in practice, referencing into such an annex is going to cost the same as referencing into various other inputs. So really, wallets can just deposit whatever data they need to reference into inputs according to some optimization strategy (imagine wanting to deduplicate references to several public keys across a variety of inputs: the wallet can just stick each public key into a different input and inspect/parse it from there later across all other inputs). It's hard (and certainly messier at the protocol level) to save more bytes with such an annex vs. simply adding OP_EVAL.
And I'll also note that these savings are useful beyond just being "compression with extra steps" – even if e.g. the P2P protocol gzipped everything, we don't operate on compressed objects at the user layer: all hashes are digests of uncompressed transactions and block headers, blockchain indexers and analysis APIs need to index uncompressed results for actual use, VMs operate on uncompressed bytecode (and naive decompression could be a DoS vector), etc. In practice, savings at this layer are a lot more useful than just reducing the bytes that go over the wire.


Replace scikit-learn's nearest neighbors with scipy's

Scikit-learn is a large dependency compared to its single use in goftests, in the get_nearest_neighbor_distances function. Perhaps it could be replaced with SciPy's KDTree (or cKDTree), since SciPy is already required.

cc @mattbarr

Sounds reasonable to me. I didn't know about SciPy's KDTree.

This was fixed by pull request #9.


FAILED test in GPy.testing.pickle_tests.py (test_modelcreation)

When running GPy.tests() the following error occurs:
On line 143 of  test_modelrecreation:
np.testing.assert_allclose(pcopy.param_array, par.param_array, atol=1e-6)
This line fails.  My computer computes:
pcopy.param_array = [  3.09445348e-01   1.63745336e+00   1.23195228e-15]
par,param_array =  [  6.45484765e-01   2.14052788e+00   1.23195228e-15]
Note, I am running Mac OSX 10.9.5, GPy version GPy-0.6.0

Can you recreate this error using 0.8?
It should be fixed now.
Thanks for spotting it.

Thanks.  All tests pass now.


[wip] hotfix/config-resource - Properly correct the ConfigResource object

Apply PR changes from #25

This is ready for review/merge

@webimpress Thanks for taking an interest in this.  This repository, zf-configuration, is working IMHO now.  The most significant change besides correcting patchKey is patch() now uses a flag for ArrayUtils to preserve keys.  This is echoed in the last test.
I hope you'll review this at your convenience.

@TomHAnderson I'm afraid this patch can't be applied as it is BC Break. See #29 and as I discussed with @weierophinney we can change it only in 2.0.0 release.
I know you provided changes to apigility-admin, but we have to think about other consumers of that library. They could also rely on that (broken) function and we can't change it in v1 :(
/cc @weierophinney

I agree with you, @webimpress.  The library was so broken and was used even with that broken functionality that a 2.0 release to me, too, sounds like the only viable solution.  I do not think we should let this fester.  I want to see a new version released asap which we can use to correct zf-apigility-admin and zf-apigility-doctrine.

@TomHAnderson So what's wrong with #25? I think it should be applied for 2.0.
I'm a bit confused with your changes, because this PR contains bug fix and other improvements, so it's hard to review real changes in the functionality.

As you can see I started this work by merging back in #25 so it sounds like you're asking me from #25 what was each change in this PR made for.  Is that what you're asking?
The first commit after #25 major change was https://github.com/zfcampus/zf-configuration/pull/30/commits/9266764eb83217bd5d6b283f126b168d29f01785#diff-e813dca6ad9b65fb412e84d53d3d39a1R166 which exploded the key if it was an array.  My only lead going into this was a comment like you can't patch an array with array keys and that was because that person didn't realize the first array was a delimited list of the location in the tree so the code linked above was added.
In order for me to develop I needed to better understand what was taking place and that's why my first step in a refactor is breaking the parts up; you call this improvements.
Are you asking for a minimalist patch/PR?

Closing due to inactivity. My previous comment notes what needs to be done to get this accepted, should anyone want to pick this up.


Server always loads with default config

Is it right behavior ?
Looks like env config is never passed to newServer function
serv, err := newServer(NewDefaultConfig())

Oops, good catch


Missed items

pretty sure i did the pet correctly
added new items

Oh I didn't see it. I'll just wait for the conflict


Support for paragraphs

I need to introduce a paragraph break in the summary. <para> is meant to be used for it. It's now included in the generated .json as is. It needs to be converted to <br>.

This feature was added some time back by #1289

This feature was added some time back by #1289


Remix loaders are being called BEFORE action when using fetcher.submit()

What version of Remix are you using?
1.10
Steps to Reproduce
Trigger an action using fetcher.submit() on a nested route and observe your network activity and see that there are some "revalidation" (loader) network requests are firing BEFORE the action request.
Expected Behavior
I would expect that the revalidation happens only AFTER the fetcher is called and the action is resolved.
Actual Behavior
Loaders are being called BEFORE Action which is causing my UI to be inconsistent for a brief moment.

Turns out the issue was on my side :)


Using the Ubuntu binaries instead

The arch community seems to have figured out a way to just use the Ubuntu binaries "directly", instead of downloading the swift source code from git repositories.
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=swift-development-bin
Could something like that be adapted to a script for fedora?

It depends on the versions of glibc, fedora tends to be bleeding edge. Plus
there is a difference in arch/debian about how 64 bit libs are handled,
which results in a need to build specificaly for the fedora distros.
On Mar 6, 2016 4:16 AM, "Raul Ferreira"<EMAIL_ADDRESS>wrote:

The arch community seems to have figured out a way to just use the
binaries directly instead of downloading the swift source code from git
repositories.
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=swift-development-bin
Could something like that be adapted to script for fedora?
—
Reply to this email directly or view it on GitHub
https://github.com/thawkins/fedora-swift/issues/4.

I guess i'll close the issue then, it would be nice to have something that could run a bit quicker than the current script but i guess there's no alternative for now.


Update software_support.md, added link to Adobe Photoshop plugin

Description
Readme extended with a link to Adobe Photoshop plugin
Pull Request Checklist

[X] CLA Signed: Have you signed the Contributor License Agreement (individual or corporate, as appropriate)? Only contributions from signed contributors can be accepted.
[ ] Authors: Have you considered adding your name to the AUTHORS file?
 You can use ./ci.sh lint for automatic code formatting.

Please review the full contributing guidelines for more details.

Thanks, @eduardsmirnov!


get address from privateKey

How to generate an address given a private Key with this lib?
is it documented?

You have to derive the public key from the given private key and use the "account_by_key" api: https://developers.steem.io/apidefinitions/account-by-key-api

Keep in mind there can be more than 1 account with the same keyset

like a collision?

Keys aren't unique on Steem. You can use the same key for multiple accounts.


Add normal distribution charts

to the stake and earnings overview, add a second type of graph next to piechart, maybe use VictoryHistogram
to see how many X orchs earn above Y% of fees
and how many X orchs have more than Y% of stake

n/a


Make LBRY's DMCA takedown system far better than youtube's

Make LBRY's DMCA takedown system far better than YouTube's
some things that should be implemented into your DMCA system to make it far better than YouTube's crappy robotic version.

Require a photo captcha and a scan of the person's ID who files a DMCA takedown notice and same thing with counterclaims to prevent fraud from DMCA extortionists.

REQUIRE Plenty of Paperwork / Sources to prove if a DMCA takedown filer does indeed owns copyrights to something.

Use humans to filter out incomplete DMCA claims and counterclaims. ANYTHING properly written like in the counterclaim in the image below should be ALLOWED to PASS THROUGH ONTO THE CLAIMANT without restriction.

Add some special area to allow someone to post evidence of report DMCA fraud from a DMCA scammer extortionist. Mainly used to contact and report to LBRY if a DMCA extortionist scammer files a false DMCA claim against you (example scammer files to bogus DMCA claims to give a user two strikes on youtube and forces user to Pay something like $384 via bitcoin through spoofed email or they will file another notice and give your youtube channel the 3rd strike)

DO NOT IMPLEMENT ANY KIND OF AUTOMATED SYSTEM TO HANDLE both DMCA NOTICES AND COUNTER NOTICES EVER. You real human employees.  You are required by DMCA LAW in the DMCA to allow counter-notices to pass off to the claimant if they're written properly like this one in the image is.

STAY AWAY FROM AND DO NOT implement a 3 copyright strikes and your out and your terminated system like YouTube, Instead for infringers LBRY should take a MUCH LIGHTER handed approach instead of permabanning them from the LBRY website for 3 or more copyright strikes, instead of deleting videos that receive a DMCA claim and issuing a copyright strike, force those videos or anything that receives a DMCA claim to be forced to encrypted and private so that only the original uploader can view / download it on lbry until the copyright takedown notice is either resolved by a counter-notice or the user deletes the video / thing that received a DMCA claim. This kind of design will prevent trolls from abusing the system to take down someone's channel while allowing a media company to force a video that is obviously infringing to remove that video from "being seen on the platform"
DO NOT IMPLEMENT ANY FORM OF SYSTEM OF CONTENT ID like youtube! It's ripe with MISFINDS, ERRORS, AND ABUSE.

Thanks for the feedback and write-up. We currently process dmca claims manually, there's no automated system. We also can't delete content, we can only block it.
Please see LBRY.com/faq/dmca for more details. Closing this for now as there's no immediate action we'll be taking.
Can we show you some appreciation for the feedback?

Thanks for the feedback and write-up. We currently process dmca claims manually, there's no automated system. We also can't delete content, we can only block it.
Please see LBRY.com/faq/dmca for more details. Closing this for now as there's no immediate action we'll be taking.
Can we show you some appreciation for the feedback?

Stay away from the 3 strikes copyright system with LBRY. Hiding videos from everyone except the original uploader that receives a DMCA takedown notice is a better idea until the original uploader files a counterclaim or contact's LBRY with documentation that shows why the claim is bogus such as if it came from someone who does not actually own the copyright or a DMCA takedown extortion scammer.


Expose the LiveConnectSession directly

If you want to just get the current instance of the session's authentication token, there is no builtin way but to hold a reference in app, we could just make this variable public to ease the burden on app developers https://github.com/MSOpenTech/msa-auth-for-android/blob/dev/src/main/java/com/microsoft/services/msa/LiveAuthClient.java#L513

Thanks Peter, we won't be addressing these items ourselves at this time but would be happy to review and accept a PR.


Scout Alarm switches off when triggered

Describe the bug
When the alarm is armed (in Away or Night mode), and a door/window is opened, triggering an Access Sensor, the security system switches to OFF in HomeKit
To Reproduce
Steps to reproduce the behavior:

Arm the Scout Alarm (to Away or Night)
Trigger an Access Sensor by opening a door or window
Immediately the Security System in HomeKit switches to OFF
ScoutAlarm continues with a countdown (which I configured) and after that the siren activated. There's no notification in HomeKit about the triggered alarm.

Expected behavior
I'm not sure what the expected behaviour would be as I never had a security system in HomeKit, but I assume the alarm stays armed and a notification is sent out stating the alarm is triggered.
Note that while HomeKit claims the alarm is switched to OFF, it's still armed as the sirene goes off (after the countdown).
Screenshots
If applicable, add screenshots to help explain your problem.
Logs
If applicable, include any relevant portions of Homebridge logs.
Additional context
Add any other context about the problem here.

Thanks for the bug report!
Last time I tested this on my own system, the behavior in the Home app was that the armed mode (Stay/Away/Night) stayed the same, but it showed the status system as “Triggered”.
Unfortunately, this will likely be difficult to root cause without significantly more information about your Scout system, particularly while it’s alarming. I’ll take some time this week to push out a new release with more verbose logging.
For now, I do have a few follow-up questions:

What version of iOS or macOS are you viewing the Home app on?

What version of iOS or tvOS is your HomeKit hub running (if any)?

Thanks for the support.
I’m on the latest public versions of iOS and tvOS (13.3).
I just tried if maybe the issue is related to the countdown/alarm delay option that confuses HomeKit but that’s not the case. The issue still exists without the delay.
I do assume the logic of triggering the alarm remains in the Scout app? There does not seem to be any logic in the Home app to configure when to trigger.

This is how the Home app displays a Security System when it's in the triggered state:

Of note, if you're looking at the detailed view of an accessory (the second screenshot above), the Home app doesn't seem to update the state for any change unless you close and open it.

I've pushed a new version (0.2.2) of the plug-in to NPM that adds more logging. Would you be willing to update the plug-in, test again, and post the Homebridge logs here?
If you're not comfortable posting the logs publicly here, feel free to message me on the homebridge community slack.

Hi, version 0.2.2 crashes for me.
[12/30/2019, 9:17:03 PM] Loaded plugin: homebridge-scout
Dec 30 21:17:03 raspberrypi homebridge[3374]: internal/fs/utils.js:220
Dec 30 21:17:03 raspberrypi homebridge[3374]:     throw err;
Dec 30 21:17:03 raspberrypi homebridge[3374]:     ^
Dec 30 21:17:03 raspberrypi homebridge[3374]: Error: ENOENT: no such file or directory, open './package.json'
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Object.openSync (fs.js:440:3)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Object.readFileSync (fs.js:342:35)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Plugin.module.exports [as initializer] (/usr/local/lib/node_modules/homebridge-scout/index.js:9:39)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Server. (/usr/local/lib/node_modules/homebridge/lib/server.js:171:14)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Array.forEach ()
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Server._loadPlugins (/usr/local/lib/node_modules/homebridge/lib/server.js:145:22)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at new Server (/usr/local/lib/node_modules/homebridge/lib/server.js:57:24)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:32:16)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Object. (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Module._compile (internal/modules/cjs/loader.js:959:30)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
Dec 30 21:17:03 raspberrypi homebridge[3374]:     at Module.load (internal/modules/cjs/loader.js:815:32)
Dec 30 21:17:03 raspberrypi systemd[1]: homebridge.service: Main process exited, code=exited, status=1/FAILURE
I managed to fix this issue by running npm init to create a package.json file. Then I moved on to run homebridge as a service with systemctl. But this gives the following (similar?) error.
Dec 30 21:19:23 raspberrypi homebridge[3697]: [12/30/2019, 9:19:23 PM] Loaded plugin: homebridge-scout
Dec 30 21:19:23 raspberrypi homebridge[3697]: internal/fs/utils.js:220
Dec 30 21:19:23 raspberrypi homebridge[3697]:     throw err;
Dec 30 21:19:23 raspberrypi homebridge[3697]:     ^
Dec 30 21:19:23 raspberrypi systemd[1]: homebridge.service: Main process exited, code=exited, status=1/FAILURE
Any suggestions?

I did however manage to test version 0.2.2 for the triggering issue. Turns out that if I wait a while, the alarm does go off, and the correct state is eventually reflected in HomeKit. However, in between the triggering of the alarm and the alarm actually sounding, HomeKit reports the alarm as OFF.
step 1) Arming Away Mode in HomeKit:
[12/30/2019, 9:37:17 PM] [ScoutAlarm] Mode [54ca4d86671a81ce96000033] arming event fired.
step 2) Away mode actually armed. Notice this takes almost a minute. No idea why:
[12/30/2019, 9:38:03 PM] [ScoutAlarm] Mode [54ca4d86671a81ce96000033] armed event fired.
step 3) Trigger the alarmHere, I triggered the door panel. In HomeKit the alarm immediately switches to OFF. In Scout the alarm stays armed.
[12/30/2019, 9:38:50 PM] [ScoutAlarm] Device [0a70080064100452584da000a0000100] triggered event fired.
[12/30/2019, 9:38:50 PM] [ScoutAlarm] Mode [54ca4d86671a81ce96000033] triggered event fired.
[12/30/2019, 9:39:06 PM] [ScoutAlarm] Device [0a70080064100452584da000a0000100] triggered event fired.
step 4) Alarm sounds After 45s the sirene does go off, and in HomeKit the status changes to "triggered". I'm not sure why it takes 45s as I disabled the alarm delay in Scout. HomeKit does not send out a notification about this.
[12/30/2019, 9:39:35 PM] [ScoutAlarm] Mode [54ca4d86671a81ce96000033] alarmed event fired.
step 5) Dismiss alarmI dismiss the alarm in Scout
[12/30/2019, 9:39:48 PM] [ScoutAlarm] Mode [54ca4d86671a81ce96000033] dismissed event fired.

Ok, first of all, I pushed a new version (0.2.3) that should fix the crash in 0.2.2… 🤦♂
For step 2, the delay between arming and armed is so you can set your system to away and leave your house (open a door) before the alarm mode is set and would trigger an alarm. This is entirely controlled by Scout and is working as expected.
Thanks to your testing (and the new logging), I can see what the actual problem is though. The mode state transitions as follows:
disarmed ➡ arming ➡ armed ➡ triggered ➡ alarmed ➡ dismissed
The problem is that I'm not currently accounting for the triggered state. Unfortunately, there's not a direct mapping of these mode states to HomeKit security system states. A HomeKit security system can only be one of the following:

STAY_ARM
AWAY_ARM
NIGHT_ARM
DISARMED
TRIGGERED

When the mode state is alarmed, the HomeKit state should obviously be TRIGGERED, but I feel like it's less clear if the mode state is triggered that the HomeKit state should shift to TRIGGERED or stay in its current armed state since Scout is only counting down a grace period.
I'm leaning towards the latter (maintaining state until the actual alarm), and it probably warrants a user-configurable option, but it needs a sane default.
Thoughts?

thanks for the quick reply. I think the "triggered" state should map to the current armed state. The alarm is not sounding yet, so HomeKit should remain "unaware".
I'm not even sure if it warrants a user-configurable option as the grace period typically allows the user to dismiss the alarm before sounding. So if you would allow the user to map it to triggered, HomeKit would assume the alarm is sounding, which is not the case.

version 0.2.3 does indeed fix the crash. Great.
One thing though: the "security system tile" is now grouped together with one of my contact sensors. Assuming this is not something that changed in the plugin code, I assume HomeKit does not like accessories to magically come and go as a result of homebridge changes so it probably got things mixed up. And I'll get it fixed when I re-add homebridge to HomeKit.

I've pushed a fix and included it in a new release (0.2.4).
Thanks again for your help!

I have updated to version 0.2.4 but the issue is not yet fixed for me. Alarm switches to OFF when triggering.

Hmm… I was able to repro the bug in 0.2.3, but confirmed it was fixed with 0.2.4.
Can you upload a new set of your Homebridge logs and a screenshot of your Scout mode configuration?

Actually, can you update to 0.2.5 and run homebridge --debug to capture logs? It will include a bunch of additional data about your Scout configuration.

I just tried this scenario again and it works perfectly now. I'm 100% sure I was on 0.2.4 and restarted homebridge before. Anyway, you can close this report. Sorry for the confusion and thanks for the great work!


minor typo

Hi @Sarabeth-Jaffe-Microsoft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Sarabeth Jaffe). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Make some changes to improve code coverage

~Opening this PR for discussion on tomorrow's call...~
~There's a couple error checks in our code that will quite literally never execute:~
~- The error check after data.NewDevfileData() in  pkg/devfile/devfile.go#L53~
~- We're hardcoding a valid devfile version~
~- The error check after devfile.ConvertApplicationToDevfile in controllers/application_controller.go#L143~
~- Because of the aforementioned error check~
~I'm somewhat hesitant to make this change, as I don't like ignoring any errors in Go, and since these functions could change in the future, but I thought I'd throw this PR up out of curiosity and for discussion.~
We also weren't mocking any GitOps repository creation failures in our tests, so I tried to modify our mock client to allow error responses to be mocked

I wasn't sure how to mock it dynamically, so I took an approach where we return an error response if the API request contains "test-error-response"
Again, not crazy about my implementation here, but figured I'd put it in this PR for discussion

Also added some miscellaneous test cases to cover more edge cases

update.go

Some edge cases around invalid components

componentdetectionquery

Git repo with invalid devfile

component

Git repo with context folder, no devfile in context folder

/retest


Removes flicker

Remove flicker on overlapping nodes
SceneKit defaults the z-order of all nodes to 0, which causes flicker for overlapping nodes.  This change assigns a random z-order value to each node, with the ability to override that random value if you want to control which node is in front / behind the other.
Breaking Changes
N/A
Meta

Tied to Version Release(s):

Checklist

[x] Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
[x] Documentation has been added to all open, and public scoped methods and properties.
[ ] Changelog has been updated
[ ] Tests have have been added to all new features. (not a requirement, but helpful)
[ ] Image/GIFs have been added for all UI related changed.

Screenshots

@Pilot-Marc - can you please update the changelog?

I'm recreating your PR to clean it up.  I'm doing the following to clean things:
1. ` git checkout -b feature/removeFlicker`
2. `git fetch upstream` - make sure I'm up to date with develop in this repo
3. `git fetch pilot-marc` - make sure I've got everything from your fork
4. `git reset --hard upstream/develop` - start at whatever the current develop branch is
5. `git cherry-pick 17dc9e9` - First commit relevant to this PR "Remove flicker by assigning non-conflicting z-order values to each node"
6. `git cherry-pick 5a5abd3` - Next relevant commit: "Convert TAB -> Space"
7. `git cherry-pick d9cfe75` - Next relevant commit: "Convert TAB -> Space"
8. `git cherry-pick febbd0a` - The Comment commit: "Update ChangeLog for PR 203" 👈 This is the one that was missing
9. `git push origin feature/removeFlicker` 👈  pushed up to my fork: [@intere/ARKit-CoreLocation](https://github.com/intere/ARKit-CoreLocation/tree/feature/removeFlicker)

This getting released soon?  Looking fwd to it.

Yeah, we can probably cut a minor release.  There are more PRs that I haven't gotten around to yet.

I've added an issue to do this: https://github.com/ProjectDent/ARKit-CoreLocation/issues/218


Is it possible to convert animation to video?

is it possible to convert animation to video?

Hi @iamappmaker,
You can do it using a screen recorder.
The library doesn't have this feature and we have not planned to implement it, even in a far future.
Closing the issue.


OpenCR USER1 LED - Cannot used /cmd_vel

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[X] Burger
[ ] Waffle
[ ] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[X] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Intel Joule 570x
[ ] Raspberry Pi 3B+
[X] Raspberry Pi 4
[ ] etc (Please specify your SBC here)

Which OS you installed on SBC?

[ ] Raspbian distributed by ROBOTIS
[ ] Ubuntu MATE (16.04/18.04/20.04)
[ ] Ubuntu preinstalled server (18.04/20.04)
[X] Raspberry Pi 4B (2GB or 4GB) ROS Noetic image

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[X] Ubuntu 20.04 LTS (Focal Fossa) - Used for bringup through Open SSH
[X] Windows 11 - Through MATLAB
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [x.x.x]
Firmware version: [1.2.6]

Specify the commands or instructions to reproduce the issue.

"roslaunch turtlebot3_bringup turtlebot3_core.launch"
"roslaunch turtlebot3_bringup turtlebot3_lidar.launch"
Then on MATLAB any use of the /cmd_vel topic causes this issue.

Copy and Paste the error messages on terminal.
N/A

Please describe the issue in detail.

Upon carrying out the turtlebot3 core bringup the USER1 LED on the OpenCR board begins (and continues) to rapidly flash orange. When trying to use the topic "/cmd_vel" nothing happens. However, when checking rostopic list - all topics are available.
Additionally, I am not receiving any errors in MATLAB (This code was working perfectly yesterday) or when viewing on the Linux machine and I am able to successfully use the topic "/battery_state". This would therefore suggest this is not a MATLAB or Windows issue
Any help appreciated.
Thanks,
Cam.
*EDIT - Additionally to the flashing USER1 LED the Arduino LED on the OpenCR has also begun flashing could this have anything to do with this issue?

Issue resolved itself.
The issue signposted above actually fixed itself. The orange USER1 LED still blinks after the "core.launch" bringup however all topics and commands can utilised be carried out without any issues.
Thanks
Cam.


Intersections of object types are treated differently than object spread to form a new type

I don't know if this is an intended behaviour or a bug. I might be confused between intersection and object spread to form a new type because their behaviour are pretty similar
Flow version: 0.112
Expected behavior
IMO, object type intersection and "type spread" should be treated the same way.
Actual behavior
https://flow.org/try/#0PTAEAEDMBsHsHcBQAXAngBwKagIKgLygDeoAlgCYBcoAdgK4C2ARpgE6gC+A3ChtgEIFcoAGTFaAQwaZqAZ2StSNAOaceiCbNQ0AxqEh1dyUrBqhlmZPwAUASmoAFVrAalZmADz8AfMUShQVks6VjMSCmoARgAaSWlqAHJkTHkEtUQORA0tXX1DHWNTUGT5O0dnV3cvUXEJC2p6ZjZOXyJ-UB1TeVAmIQl4CVJkc0sbWx4A9qDkELD2gIA6JaZo+dA6mVBI9szMoA
In the above snippet, const b = await getB(); b is apparently of type A and not B, hence the "missing name" error
The fix is to change
type B = A & { name: string };

to
type B = { ...A, name: string };

https://flow.org/try/#0PTAEAEDMBsHsHcBQAXAngBwKagIKgLygDeoAlgCYBcoAdgK4C2ARpgE6gC+A3ChtgEIFioAHRicAGloBDBpmoBnZK1I0A5px6JpC1DQDGoSHQPJSsGqDWZk-ABQBKagAVWsBqQWYAPPwB8xIigoKw2dKyWJBTUAIxSNLLyoADkyJhKyZqIHIjaugZGJvpmFqBpSo4ubh5evqAAZMLS1tT0zGycAURBoPoWSqBMQtLw0qTIVjb2DjzBPaHI4ZE9wWIiTBIroM1JMT05OUA
This problem also happens without async
https://flow.org/try/#0PTAEAEDMBsHsHcBQAXAngBwKagIKgLygDeoAlgCYBcoAdgK4C2ARpgE6gC+A3ChtgEIFcoAGTFaAQwaZqAZ2StSNAOaceiSHRoBjZKVg1QyzMn4AKAJTVBRRKFCsTdVoZIVqARgA0k6dQDkyJjy-mqIHIgaWrr6hkHyltai4hLG1PTMbJzEdqDaBvKgTELGppY89rmOyM6uufYAdE1MXvWgqTKgHrkREUA

Any update on this? We use intersection types extensively, and now if we try to upgrade to 0.111.0 or greater we get around 1800 flow errors, and changing every single type we have to use spread instead of intersection is not a viable solution.
This definitely seems like a bug, as our intersection types and the operations we're trying to do on them are totally valid from a typing standpoint.

This is kind of preventing us to update flow, since we use intersection exclusively, but any time we use object spread as a value, it gives an error.

This seems to be working now, I'm closing it :)


core: expose stream options

Description: this PR introduces envoy_stream_options which is a subset of AsyncClient::StreamOptions, that can be used in the bridge layer.
Risk Level: med - new functionality
Testing: unit tests missing, will update after initial discussion
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

@buildbreaker @rebello95 @goaway this PR exposes stream data buffering in order to allow for retries. I only did the work here to expose the option and wire it all the way to the underlying envoy stream.
We have an open question on how we want the platform code to deal with turning on buffering, and its relation with retries. Therefore, the way I have implemented here leaves us open for several possibilities.

re-opening now that I am back. @goaway do you mind taking a look and if it looks good on first pass I can rebase and we can review?

closing this in favor of: https://github.com/lyft/envoy-mobile/pull/511


functions.config().algolia.app_id;  TypeError: Cannot read property 'app_id' of undefined

Thanks for stopping by to let us know something could be better!
Please run down the following list and make sure you've tried the usual "quick
fixes":

Check the Emulator's docs
Check the Emulator's self-help: functions --help or functions-emulator --help
Search the issues already opened: https://github.com/GoogleCloudPlatform/cloud-functions-emulator/issues
Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js

If you are still having issues, please be sure to include as much information as
possible:
Environment details

OS:
Node.js version:
npm version:
@google-cloud/functions-emulator version:

Steps to reproduce

???
???

Following these steps will guarantee the quickest resolution possible.
Thanks!

Hi, please follow the template if you're having any issue with the emulator.

@ittechsathish Make sure to follow the steps here, especially running this within your functions directory:
firebase functions:config:get > .runtimeconfig.json

I had the same problem even after running the command that a file within a subdirectory would get an empty functions.config object. But apparently that was due to having a second node_modules folder within said subdirectory. After deleting the second node_modules folder everything worked fine.


Bad Callback function

I initialized a system with two turtlebots and their navigation nodes with the corresponding prefixes as instructed. I started pretending there is only one robot to explore to keep things simpler. Cqlite is working up to the filter node. I'm receiving Frontier points from cqlite_filter but the following error emerges along with. Centroids are not visible either. Rviz says, "Points should not be empty for specified marker type."
[ERROR] [1717524200.888219]: bad callback: <function callBack at 0xffffb06ee3a0>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
TypeError: callBack() missing 1 required positional argument: 'args'

I attach the Rviz and node graph herewith.

The node graph.

Filter points contain pointArray, not the marks, and hence cannot be visualized in rviz. The filter points are directly used by cqlite_planner. If you want to visualize filter points, you can easily remap them to markers inside cqlite_filter.py.

@ehsanlatif  The callback issue seems to be independent of the RVIZ visualization error. Can you look into this callback issue and provide a solution?
@MayooranT  can you provide more information on the callback issue? Which node is triggering this error and if you have changed any configuration/settings other than what we described in the README steps.

@ehsanlatif The callback issue seems to be independent of the RVIZ visualization error. Can you look into this callback issue and provide a solution? @MayooranT can you provide more information on the callback issue? Which node is triggering this error and if you have changed any configuration/settings other than what we described in the README steps.

Frontier filter must be the one which is triggering while publishing those three topics. This must be triggered when line 22 or 32 in cqlite_filter.py. I get this twice every time a frontier point detected by local or global frontier detector.


Scripts Refactor

Thought I'd clean things up a bit, add some functionality and all that jazz.

Moved spawn-alacritty-cwd into a new top level share/ directory to help people find it.
Modified create-flamegraph.sh so it can be run from anywhere, and so that it hides the cloned FlameGraph repo a bit.
Added a useful colors.sh script.
Updated the README.

I didn't touch the python script because I couldn't seem to get it to work.

@chrisduerr would merging the two scripts with a flag to show 24bit color, and the same defaults work better?

Thanks for getting around to this, it fell off my radar.


Running tests fails on MacOs

Describe the bug
Running tests locally on MacOs fails with:
du: invalid option -- b
This is due to the line:
const res = execSync(`du -bs ${dbLocation}`, {encoding: "utf8"});

That can be found in this test here
Reason this fails is that, apparently the -b is not in the du spec and not supported on MacOs. This means this will also fail on windows by the way.
Expected behavior
The tests should run fine on MacOs (also windows) and should not be dependent on OS.

Closing issues for specific incidents on old versions of Lodestar, please re-open if it happens with latest stable


Bookmarks not working again

In deconvolution mode, the directory bookmarks are not working (ie they are not staying in the list).

Moved to new version


Total cases is not matching with sum of active, recovered, death cases.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This is due to some migrated cases (HP) and a non-covid related death in Karnataka. Please see the info icon near the state names.


get last 24hrs of my feed

I'm using --login and :feed and trying to use --post-filter="date_utc >= datetime(2024, 10, 12, 3, 5, 0)" to limit posts to the last 24hrs, but I keep getting posts that are earlier than that.
I'm I using --post-filter incorrectly?
Since :feed isn't chronological, is it even possible to filter this way?

In the mobile app, if you tap the logo, a menu appears with a "following" option that presents a chronological feed, is that available in instaloader?


Updated style.css for the license agreement

1. Why is this change necessary?
Under Linux you can choose between a bright and a dark style.
When the dark style is activated, the text of the license agreement is hard to read.
2. What does this change do, exactly?
Colors the background of the license agreement white
Before the change

After the change

3. Describe each step to reproduce the issue or behaviour.
Install Linux (Linux Mint) and activate the dark theme. Then visit the install process.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21687
Please use this issue to track the state of your pull request.

Hey @YannickFricke,
we have changed the license agreement in a another ticket to a iframe and considered your change with commit https://github.com/shopware/shopware/commit/03ac44274948497f53acb5b27c457ef0d8046b8a#diff-5ed18aabf58a6f2152bc9228c926c40aR136
But thank you for your contribution! :blue_heart:


Make EMR on EKS module CI/CD ready

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

Describe the solution you would like
Do not do this, it is not suitable for a CD pipeline (where you typically only want explicit changes ;done in a PR or so)
https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/emr-on-eks/main.tf#L122
Describe alternatives you have considered
find another solution to trigger this explicitly maybe?

thanks for reporting - this module is slated to be removed in v5 and there are alternate routes for creating EMR virtual clusters on EKS instead. Here is the latest implementation https://github.com/bryantbiggs/terraform-aws-emr/tree/master/modules/virtual-cluster and an example that demonstrates how to use it https://github.com/bryantbiggs/terraform-aws-emr/tree/master/examples/virtual-cluster

That makes sense! Thanks for the quick feedback!


In My Vs Code The Extensions Are Not Installed

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hi @ItsMeOmkar
Thanks for reaching us, could you kindly provide more information about this issue, such as a screenshot or error message, so that we can properly investigate?
Thanks,
VS Marketplace Team

Hi @ItsMeOmkar
Since we have not heard any response on this required information, closing the issue.
Please recreate or comment if the issue still persists.
Thanks,
VS Marketplace Team


Midnight Commander (mc) output is screwed when using the 'ms-terminal' as $TERM

Environment
Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 1.1.1671.0

Any other software? WSL Ununtu 20.04 LTS

Steps to reproduce

Use the latest Ubuntu LTS as the WSL environment.

Set the TERM=ms-terminal.
terminfo.src

Run mc.

Expected behavior

Actual behavior

Q: Doctor, it hurts when I do this
A: Don't do that

Do not use the ms-terminal terminfo.

We do not maintain that terminfo file, we do not own it, and we have not suggested its use.


NameSpaceRuleChecker: Questions and possible bug with DELETE

Dear developers
I'm aware that this checker is currently off by default, but nevertheless I played around with it and have a few questions about it. It's basically three questions in one issue, but they are related to each other so I'm including them in one issue.
To test, I'm using the following REST API:
POST /rest/admin/products/{username}
=> This creates a product provided by user {username}. This can only be done by a user with a valid JSON Web Token (JWT) and only if the username in the token corresponds to {username}. It returns, among other data, the productID of the newly created product.
GET  /rest/admin/products/{username}/{productID}
=> Allows to get a product. Can only be done with valid JWT that contains the corresponding username. So just like the POST request above, this is part of the "administrative area" of the API (anything below /rest/admin) to maintain products.
DELETE  /rest/admin/products/{username}/{productID}
=> Allows to delete a product. Can only be done with valid JWT that contains the corresponding username. Also part of the "administrative area".
GET  /rest/products/{productID}
=> Allows any user (no authentication required) to get a product. So in contrast to the requests above, this is not part of the "administrative area" of the API used for maintaining product, but allows anonymous users to view product details.
There's a little python program that returns valid JWTs of two users, luke and snoopy. This is used in parameter --token_refresh_command.
#!/usr/bin/env python
import sys
sys.stdout.write("{'luke':{}, 'snoopy':{}}\n")
sys.stdout.write("Authorization: Bearer eyJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJNYXJrZXRwbGFjZSIsInN1YiI6Imx1a2UiLCJleHAiOjE5MDczNTM5NzJ9.jdoYfz_diOQa...\n")
sys.stdout.write("Authorization: Bearer eyJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJNYXJrZXRwbGFjZSIsInN1YiI6InNub29weSIsImV4cCI6MTkwNzM1NDAxMX0.XiOtGu...\n")

I've added two vulnerabilities:

With a valid JWT, one can GET the products of another user, e.g., snoopy can successfully execute GET  /rest/admin/products/luke/25 to get a product that belongs to luke.
With a valid JWT, one can DELETE the products of another user, e.g., snoopy can successfully execute DELETE  /rest/admin/products/luke/25 to delete a product that belongs to luke.

The results of fuzz-lean are as follows:

GET /rest/admin/products/luke/25 as user snoopy is correctly recognised as a vulnerability.
GET /rest/products/25 is wrongly flagged as a vulnerability. Intuitively, I wouldn't have expected this as the POST request created the product below /rest/admin/products/luke. But apparently, a vulnerability is flagged if the corresponding productID is used in any other request, no matter what the full pat is. Is this intentional?
DELETE /rest/admin/products/luke/25 as user snoopy is not recognised as a vulnerability. Apparently, when testing this, restler first does a POST and a corresponding DELETE (so the product is removed), and then it does another DELETE (I assume with the second user). This results in a 4xx error, as the product is longer there. This seems to be a wrong verification approach and a possible bug. The correct approach would be to do POST with the JWT of user1 and then DELETE with the JWT of user2.

And a final question: Is there a way to link the username in a token (that is returned by the python script above in my case) with the username that is used in the path of the POST request? Right now, I have hardcoded this in Grammar.py which works (so it always uses username luke), but this is not really an elegant solution.
So to summarise: three questions/issues:

Is allowed access to GET /rest/products/25 intentional?
Is the missed vulnerability with DELETE /rest/admin/products/luke/25 due to a bug?
Is there a good way to link the username in a JWT to parameters used in requests?

For reference, I've attached Grammar.py, the network log and the two reported vulnerabilities.
Thanks a lot!
Marc
grammar.py.zip
network.testing.140572845729536.1.txt
NameSpaceRuleChecker_20x_1.txt
NameSpaceRuleChecker_20x_2.txt

@rennhard Hi Marc, thanks for your detailed feedback and questions. Here are some answers.

Is allowed access to GET /rest/products/25 intentional?

Yes, by design, the NameSpaceRule checker intentionally flags this access by user-2 of a dynamically-created resource created by user-1. This is to err on the safe side: the checker reports all such (potentially dangerous) valid accesses, at the risk of reporting false alarms in some contexts.

Is the missed vulnerability with DELETE /rest/admin/products/luke/25 due to a bug?

If you set "mode": exhaustive in this checker settings (in the settings file - see https://github.com/microsoft/restler-fuzzer/blob/main/docs/user-guide/Checkers.md for how to do this and the exact syntax), you should then see the sequence "POST by user-1;DELETE by user-2" that you expected. (If not, please let us know.)

Is there a good way to link the username in a JWT to parameters used in requests?

No, as what you call "username" in your example is implicit/nameless with RESTler and this checker - the first JWT can dynamically create some resources, while the second JWT tries to access those and reports an alarm whenever it is successful. (The 'names' associated with JWT1 and JWT2, if any, are irrelevant.)
Please let us know if this does not address adequately your questions. Thanks!

Hi Patrice
Thanks a lot for the feedback. Setting "mode":"exhaustive" does not help to detect the DELETE issue. I'm using the following setting file:
{
    "checkers": {
        "invaliddynamicobject": {
            "no_defaults":true
        },
        "namespacerule" : {
            "mode":"exhaustive"
        }
    }
}

Note that when adding a bug to the REST API so that when calling DELETE the resource is not deleted, then the issue (sequence POST user1, DELETE user2) is correctly detected (as DELETE now returns 200 and not a 4xx status code because the resource is still existing), even without exhaustive mode. The output of the checker is attached. So the problem may indeed be that the NameSpaceRuleChecker uses a wrong approach when checking the sequence POST - DELETE in the sense that it tries to re-DELETE a resource that is no longer there?
Thanks,
Marc
NameSpaceRuleChecker_20x_1.txt

Can you please attach the full network.testing.xxx logs?

I'm adding two network logs:

network.testing.140006863460096.1.txt: This is based on the REST API that does not actually delete the resource when DELETE is called (but it still returns status code 204). Here, the NameSpaceRule Checker finds the vulnerability with the sequence POST-DELETE. And there's also a vulnerability reported by the UseAfterFree checker because the resource is not deleted.

network.testing.139987614951168.1.txt: Here, the REST API correctly deletes the resource when DELETE is called. The NameSpaceRule Checker does not find the vulnerability (although it should).

network.testing.140006863460096.1.txt
network.testing.139987614951168.1.txt

Thanks for these network logs. But can you please confirm that these logs were obtained with
"namespacerule" : {
            "mode":"exhaustive"
        }

? (They do not look like it...) Thanks again!

I'm pretty sure I'm using exhaustive mode. I'm using the following file user-settings.json on the command line with --settings user-settings.json:
{
    "checkers": {
        "invaliddynamicobject": {
            "no_defaults":true
        },
        "namespacerule" : {
            "mode":"exhaustive"
        }
    }
}

The reason why I also added the rule for invaliddynamicobject was to make sure the settings file is working (as I get such a vulnerability without the settings file and it went away when using the settings file), as the output files of fuzz-lean don't contain any information about what checker settings were actually used.
I also just checked with fuzz mode (instead of fuzz-lean), but this has no effect on vulnerabilities that are reported (or not) with the DELETE request.

Thanks Marc.  I've created a new issue to stop the checker from replaying the final request in the sequence prior to sending the attack request. This should hopefully relieve the issue surrounding false negatives when attacking with DELETE requests. I'll look more into what's going on with exhaustive mode as well.

Thanks again Marc.
To be clear, there are 2 distinct action items:

the Namespacerule checker should test the 'POST;DELETE' sequence even in non-exhaustive mode - new issue #112 has been filed to address this.
the network logs above do not show all the consumer requests being tried in exhaustive mode (as we had expected) - this should be investigated as well (either the exhaustive mode was not turned on properly, or there is a glitch somewhere).

Thanks a lot for taking care of this.
I'm closing this issue.

Just to conclude:

the first point above was fixed with issue #112
the second point above: after further investigation, my understanding of the exhaustive mode was wrong (my mistake) and there was no glitch here.

Thanks again for your feedback.


Remove START and node() from cypher query build

Neo4j v3.x does not support either START or node() therefore breaking relationship traversals, (e.g. node1.test_rel.all()) raising the exception "Internal error - should have used fall back to execute query, but something went horribly wrong" within Neo4j itself.
This fix should be like for like functionality, replace the START part of the query with the format "MATCH () WHERE id()= WITH ".

Here's an example where it fails. By the way, I'm not using 'replace', I've just replaced the part of match.py which built up a START using node ID.
The patch I've proposed is only 'like for like' solution, where the part of the cypher query you build up the 'START alias=node(id)' which is no longer valid now looks like this:
'MATCH (alias) WHERE id(alias)=node_id WITH alias'
This means the statement in AST should behave identically to before.
rel_all_example.zip

If you'd like I could look at the code that build the 'start' element of _ast and turn it from a string into a list of dicts, i.e. [{'alias':'id'}]

Hey just checked this locally it appears neo4j 3.2 has removed a bunch of deprecated stuff. I am investigating.

Let me know if you would like me to look at any parts of that.
Sent from my iPhone
On 9 Jun 2017, at 19:43, Robin Edwards <notifications<EMAIL_ADDRESS>wrote:
Hey just checked this locally it appears neo4j 3.2 has removed a bunch of deprecated stuff. I am investigating.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/robinedwards/neomodel/pull/255#issuecomment-307468676, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFZIEE2Ewk0HZvi-ugAlzb3uf7LayWgPks5sCZI2gaJpZM4Nsvmf.

Right used your with work around thanks for that. Its not ideal but it will do for now. Cheers!


Set up more trigger excludes

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

Pull Request Test Coverage Report for Build 107081

0 of 0   changed or added relevant lines in 0 files are covered.
1298 unchanged lines in 167 files lost coverage.
Overall coverage decreased (-1.5%) to 77.991%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapterOptions.cs
1
86.67%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs
1
96.36%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs
1
96.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs
1
96.35%

/libraries/Microsoft.Bot.Builder/BotStateSet.cs
1
85.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/DebugSupport.cs
1
75.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/SourceRange.cs
1
46.15%

/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/DeclarativeType.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptCultureModels.cs
1
97.53%

Totals

Change from base Build 107074:
-1.5%

Covered Lines:
21120

Relevant Lines:
27080

💛  - Coveralls


SVG not showing on Xamarin Forms 3.6.x [Android]

Description
TheLittleThingsPlayground-master.zip
SVG images are not shown.
Steps to Reproduce
Create a Xamarin Forms 3.6.x project with FFImageLoading + FFImageLoading.Svg
Expected Behavior
All the svg images are displayed
Actual Behavior
No one image is rendered , only blank or background color of the image are displayed.
Basic Information

Version with issue:  2.4.9.x
Last known good version: <IP_ADDRESS>9 with issues on Xamarin 3.4.0 and Android 9.0
Platform: Xamarin Forms Android 9.0 + PCL .Net Standard 2.0

Screenshots

Reproduction Link / Code
In the example project go to "Card" section .

Works fine for me.
Please make sure you:

removed all bin/obj folders from your projects
have the same packages version in all projects

Forgot about one thing:
You should use SvgCachedImage instead CachedImage


Spike: Investigate component templating for speed and consistency

Overview
Investigate automated scaffolding methods that could be used to give new components a consistent starting point. This measure has the potential to speed up the development of new components and increase standardization between components.
Background
This issue was surface from a discussion with @cjam and @chrisolsen as part of a larger discussion about service team needs and contribution to the design system.
Acceptance criteria

[ ] Meet with Ashnav Kumar for demo and knowledge transfer
[ ] Investigate methods for automating the templating of components
[ ] Web component template

[ ] Angular template
[ ] React template

Just an FYI, I don't think Ashnav's expertise aligns with this templating issue, I changed the acceptance criteria to me for this one.


🐛 Booking status is not correct

Cc: @jimmidier @william-liebenberg @adamcogan

To myself
Describe the Bug

Brady is booked today (Aug 24) but his booking status shows he is free.
Tasks

[ ] Investigate
[ ] Fix

Screenshots

Figure: Status is wrong
Definition of Done

[ ] All tasks are updated and closed
[ ] No high priority defects/bugs are on that user story
[ ] Code reviewed by one other team member (e.g. Checked by Bill)
[ ] All acceptance criteria have been met
[ ] Deployed to Dev
[ ] (If implemented) Pass automated UI testing
[ ] (If not implemented above) Do a manual test on all supported commands (at least one for each LUIS intent) against Dev
[ ] Complex code is documented (removing technical debt)
[ ] Deployed to Production
[ ] Add description about the changes for the PBI
[ ] Tick off the definition of done tasks in the PBI
[ ] (Optional) A Done Video, particularly for PBI with multiple stages

Thanks!

Judging from CRM report Brady was not booked on Aug 24th

As per conversation with @jimmidier, the root cause is that the Appointments field returned by the PeopleAPI is empty. It also causes Bookings is always empty in the profile card.
Created a PBI in PeopleAPI to fix this: Appointments field is empty

Figure: Bookings are empty

Done - Fixed in Appointments field is empty when fetching employees


Initial version refactoring

A collection of random issues coming to mind during code inspection.

[x] Add abstract methods to Lattice base class
[x] Add abstract methods to Neighborhood base class
[x] Split Border into 2 abstract casses
[x] Remove unused Property.declare_once() argument
[x] Check the correctness of OrthogonalNeighborhood.neighbor_state
[x] Move Lattice.is_off_board_code to Border
[x] Merge core.base.topology.mixins and core.base.mixins

We've done a good job in refactoring, fixing most of pylint issues and making object model more consistent. Only 2 pylint categories were disabled in the process: 1) no-member, since it can not detect CellularAutomaton members generated by the metaclass, 2) too-few-public-methods, because experiment classes are holding "data" only, that's allowing them to be easily inherited.


Add possibility to ignore SMTP TLS certificate validation

When interacting with STARTTLS SMTP would it be possible to either

accept self-signed certificates
ignore cert being issued for different domain
allow server name override for IP connections?

What I'd like to do is to send an email from localhost or <IP_ADDRESS>, and with currently broken configuration on my server such connection presents cert that's valid for external domain.tld

You need to customize Email class.
We use GitHub issues to track BUGS and to track approved DEVELOPMENT work packages. We use our forum to provide SUPPORT and to discuss FEATURE REQUESTS.


To range on Infinity for BigInt

Related: https://github.com/Jack-Works/proposal-Number.range/issues/7#issuecomment-467282703
We can range 1 to Infinity now, but we can't range from 1n to Infinity. Because Infinity is not a BigInt.
But there is no representation of Infinity for BigInt. Should we add a speical case for that?

BigInt will not be able to represent Infinity.
Should we add a special case for range?

I would vote for yes.
Though Infinity is not a BigInt, bigint < Infinity works and always return true.

I also vote for yes. We intentionally made it fine to compare BigInts and Numbers.

Yes, this should definitely work.

please checkout #23

I couldn't an issue that mentioned this. I was getting worried that we'll never be able to have an "endless" BigInt iterator just because types don't match. BigInts are better suited for infinite sequences than Numbers

@Rudxain #23 allows BigInt.range(Infinity), to my reading.

#23 allows BigInt.range(Infinity)

I know, I just wanted to post my thoughts about this (even though the issue is old, and has been closed by that PR).
I sometimes like to visit old posts on forums, GH issues, and social media, specially if I want to say something that hasn't been said by someone else


Corrected a few little things and extended the functionality

Hello
Thanks so much for the additions! Did you test the getFileData() method? It doesn't seem to work for me, with correctly tagged mp3 files.

No Problem. :)
I found that out, too.
It does work seldomly, just not everytime.
I did not figure out why it doesn't work.
I will look into that on the weekend, but it my be better to remove it by
now, or to mark it as not working properly.
2015-08-14 12:03 GMT+02:00 Loïc Stankovic<EMAIL_ADDRESS>
Hello
Thanks so much for the additions! Did you test the getFileData() method?
It doesn't seem to work for me, with correctly tagged mp3 files.
—
Reply to this email directly or view it on GitHub
https://github.com/loics2/node-mplayer/pull/3#issuecomment-131057006.


Frontend: Refactor List and TileViews for Organisation and Campaigns.

Refactor List and TileViews for Organisation and Campaigns.
Dummy Components in /designsystem

Tableview, Listview, Tileview for Organisations /  Campaigns

if possible expand the view when user clicks more items per page vs scrollbox

Apply to

Organisations
Campaigns
Tangram
Governance

@iZeroIO maybe different tickets required

https://github.com/gamedaoco/gamedao-beta/pull/57
@DarkNebula0

I guess this deprecates the need for a condensed table view.
Tile and List should be enough (List could get condensed version if needed)

@soundyogi there is also #9. is that ticket deprecated and we can close it as campaigns page is mentioned here?

ok closed


Please update document for "IoT Hub Trigger"

Please update document for "IoT Hub Trigger", Basically we want to debug the messages in visual studio as it arrives.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 369aefa6-74da-3001-f835-15abdfffd5d6
Version Independent ID: 2cc2a2db-d059-3252-7a1a-4261b7d3c37c
Content: Develop Azure Functions using Visual Studio
Content Source: articles/azure-functions/functions-develop-vs.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Thank you for taking the time to share your product and documentation feedback with us. Your input is valued because it helps us create the right documentation for our customers. Due to the volume of issues in our queue, we are closing open issues older than 90 days. We hope to continue hearing from you. Thank you.


Feat/dynamic import

was #455

And finally a successful import https://github.com/NixOS/nixos-search/actions/runs/2216914043

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/tweag-nix-dev-update-29/18903/1


Implement List component

Is this blocked from a particular issue in https://github.com/material-components/material-components-web ?

Hello, it's under active development in the mwc-select branch

Thanks @e111077 for landing this one  in https://github.com/material-components/material-components-web-components/pull/763

@e111077 can this be closed?


Agent capability tooltip shows as agent disconnect in overview tab

Should relabel this to be "agent capability unhealthy", or something along those lines.

@alexandreLamarre what's the expectation for the tooltips?
Currently there's 3 TimelineTypes:

Timeline_Unknown
Timeline_Alerting
Timeline_Silenced

What would you like each to show?


Add progress bar for "installing component" step

Some components, such as rust-docs and rust-src take a bit longer to install, even on SSD-equipped machines. These take even longer on Windows (#1540).
One thing that would help in these situations would be if the user could see the progress of the component install to:

Get a sense for how long the component will take to finish installing
Know that rustup isn't just hung up

Perhaps Cargo's new progress bar released in stable 1.30 could be reused in some way?
...
info: installing component 'rust-docs'
Installing [============>                                           ] 330/1400

At least one user reported thinking that rustup was stuck when it got to installing rust-docs: https://github.com/rust-lang/rustup.rs/issues/1458#issuecomment-405044857


Fix a tyop in the storage documentation

Found while reading the docs

README -> Documentation/storage.md?

@ericchiang better? ^^

Typo in your commit message. Also we generally prefix the commit message with the directory. So it would be
Documentation: fix a typo in the storage documentation

That okay?

@ericchiang yes, the commit message is misspelled on purpose. It was sarcasm. I'll fix it since you don't appreciate the humour. Just a moment please.

Hopefully that looks better. I'll try to do a better job the next time I contribute to CoreOS Inc. projects.

Ah sorry. Those kinds of jokes are hard over the internet. Thanks for the fix!


Remove version: Stackers.Stack version 3.18.2

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://binaries.getstack.app/builds/prod/win/x64/Stack Setup 3.18.2-x64.exe
Response status code does not indicate success: 530 ().
(Automated message - build 896)


Drop rfc7895 from config

RFC7895 is deprecated.
Move configs to /etc/clixon/ same as elsewhere.
Use subdirectory to hold restconf and autocli configurations separately.
Leverage autoconf to do path expansions in top-level Clixon configuration file.
Allow distro packaging to pass user/group in as configure parameters.

Can I please get a review or merge of this?


Fix serial monitor typing

Q
A

Bug fix?
yes

New feature?
no

Doc update?
no

BC breaks?
yes

Deprecations?
no

Fixed tickets
#...

I think the initial author used # as separator to avoid problems with \r and \n which may be used depended on terminal settings if enter is used.
Maybe somebody can verify or add additional cleanup of the input.

No progress -> closed for now


Created File selectionSort.py

Hey, @jatinkumar027  I have created a selection sort file in python and solved issue #28 . This implements one of the beautiful sorting technique "Selection Sort". I have attached the output of program in my system.
Kindly merge and close the issue...

Great work @ashishpetwal


Improvement of the UI and better user interaction.

Hey @tushargupta1504  can you assign this to me. under GSSoC24 Extd.
Actually the site looks good but still needs some improvement, if you assign this to me I would love get it done.

I really like your app and want to work on your project ,please assign this issue to me under gssoc-ext 2024


BUG: scipy.special.poch is not valid for complex domain

Describe your issue.
Pochhammer symbol is defined by gamma functions which is valid for complex domain. When I use scipy.special.poch function for complex values, I get an TypeError.
Reproducing Code Example
import scipy.special as sc

print(sc.gamma(4j+2)/sc.gamma(4j))
# (-16.000000000000107+4.000000000000045j)

print(sc.poch(4j,2))

Error message
TypeError: ufunc 'poch' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

SciPy/NumPy/Python version information
1.7.1 1.19.0 sys.version_info(major=3, minor=8, micro=10, releaselevel='final', serial=0)

(Removed defect and replaced with "enhancement"-it's not a bug that it doesn't support complex numbers; it's just that nobody has added it yet.)


v1.2.0 Release Testing - Rancher with fresh Harvester installation

Outline

Three node Harvester with Rancher 2.7.5
Prerequisites

VLAN 1 network on mgmt and 1 network on other NICs
2 Virtual machines with data and md5sum computed- 1 running, 1 stopped
2 VM backup, snapshots - 1 backup when VM is running and 1 backup when VM is stooped
Create a new storage class apart from default one. Use the new storage class for some basic operations.

Test steps

Import Harvester in Rancher 2.7.5
Create rke2 custom cluster, Harvester node driver cluster, cluster using terraform
Deploy cloud provider and csi driver all the clusters.
Necessary checks for cloud provider and csi driver working on cluster.
Scale down and scale up of clusters

Harvester Configuration
Setup

Setup a 3 nodes cluster

Network

VLAN 1 network on mgmt and 1 network on other NICs

Create VLAN 1 network on mgmt NIC
Create VLAN 1 network on other NIC

Storage

Create a new storage class apart from default one. Use the new storage class for some basic operations.

Add disk to a node
Create a new storrage class which selects the new disk
Create a new volume base on the new storage class

Virtual Machine

2 Virtual machines with data and md5sum computed- 1 running, 1 stopped
2 VM backup, snapshots - 1 backup when VM is running and 1 backup when VM is stooped

Create 2 VMs with new volume attached, stop one VM.

1 VM attaches volume pre-created
1 VM attaches volume on-demand

Make some data and its checksum computed, stop one VM.

On own volume
On attached volume

Backup and snapshot on the running VM

Taking backup
Validate checksum
Restore backup
Validate checksum
Taking snapshot
Validate checksum
Restore snapshot
Validate checksum

Backup and snapshot on the stopped VM

Taking backup
Validate checksum
Restore backup
Validate checksum
Taking snapshot
Validate checksum
Restore snapshot
Validate checksum

Rancher Integration
Based on

Test steps

Import Harvester in Rancher 2.7.5
Create rke2 custom cluster, Harvester node driver cluster, cluster using terraform
Deploy cloud provider and csi driver all the clusters.
Necessary checks for cloud provider and csi driver working on cluster.
Scale down and scale up of clustersbasic operations.

Importation

Import Harvester to Rancher 2.7.5

RKE2 Cluster
Ref. https://harvester.github.io/tests/manual/harvester-rancher/22-create-rke2-kubernetes-cluster/

Harvester Node Driver Cluster 'cluster-hvst'

Harvester Node Driver Cluster by Terraform 'cluster-hvst-tf'

Custom Cluster 'cluster-custom'

Cloud Provider
Ref. https://confluence.suse.com/pages/viewpage.action?pageId=976454156

Deploy cloud provider to cluster-hvst
Deploy cloud provider to cluster-hvst-tf
Deploy cloud provider to cluster-custom

Harvester Node Driver (Terraform)

 XXX $~~$ :heavy_check_mark:

Go to "Cluster Management" -> "Cloud Credentials" -> "Create" -> "Harvester"
Go to "Cluster Management" -> "Clusters" -> "Create"
Cluster should be created (Takes ~20m)

Rancher
Harvester

 Test CCM driver $~~$ :question:

 Test CSI driver $~~$ :question:

 Scale up & down $~~$ :question:
1. Scale up, check
1. Scale down, check

Custom Cluster 'rke2-custom'
Ref. https://github.com/harvester/harvester/issues/4077
Ref. https://github.com/harvester/harvester/issues/4083

Create two or one vm in Harvester (Ubuntu)
In rancher, Create cluster -> select custom
Fill the UI form on Rancher with required details. Select Harvester as cloud provider.
It will give a command to create cluster with desired role (etcd/control plane/worker)
Run those command on the VM(s) created
The VM(s) should get registered in Rancher

Expectation:
You should be able to see/manage the custom cluster on Rancher which is using Harvester VMs
https://ranchermanager.docs.rancher.com/v2.5/pages-for-subheaders/use-existing-nodes (edited)

Note that Custom cluster with RKE2 Embedded provier can deploy successfully

rancher-system-agent.log
rancher-system-agent.log
Provisioning Log

1st round based on harvester v1.2.0-rc5 & Rancher v2.7.5 done.
Close it first, will update further version in wiki.


Add ReverseProposals query to cw-govmod-single.

Resolves #213
This adds the ReverseProposals query to cw-govmod-single. It does not add the Tally query as in the new design that query is strictly a subset of the Proposal query with a little extra work to compute the current turnout percent on the contract side.
Where possible we want to limit the amount of contract side compute happening and limit complexity in the contracts so I'm in favor of just not adding it.

Unrelated but this also loosens the quorum requirements to allow for a zero percent quorum.


fix font face overwriting font size

This fix works on my system. Maybe there was an upstream patch?

Have you checked that this change still works even when using Emacs 27 with Radian's early init-file symlinked into ~/.emacs.d?

This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and the thread may be reopened :)


HighChartsPlotOptionsImpl#step needs to remove parentheses in #getHightChartValue

HighChartsPlotOptionsImpl line 260 is
    builder.append(", step: '" + steps.name() + "'");

but should be
    builder.append(", step: " + steps.name().toLowerCase());

Currently it always shows (Line-) charts with steps, even though it default to FALSE in the implementation,

Oddly it states different in the HightChars documentation though: http://api.highcharts.com/highcharts#plotOptions.line.step

Thank you for the hint! I will fix this as soon as possible!

HighCharts documentation seems to be wrong:
http://jsfiddle.net/rgugbfc2/1/
So 'left' 'right' and 'center' should be a String - false should be Boolean.
Proposed change: HighChartsPlotOptionsImpl:260
if (steps.equals(Steps.FALSE)) {
    builder.append(", step: " + Boolean.FALSE);
} else {
    builder.append(", step: '" + steps.name().toLowerCase() + "'");
}

Thank you for the hint, just implemented this.


Fix test issues after build update

@eric-kimbrel,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Feature: adding examples directory

I hereby added an examples directory where projects which show off the puppetboard in various manners can be added.

@visibilityspots If I am reading this PR right, this is adding a vagrant playground to see Puppetboard in action - correct?

@stack72 yes indeed, I added an examples directory which consists a first submodule pointing to a vagrant playground which is provided by puppet.

@visibilityspots can you add some README stuff to explain how to use this?

I would rather just a link in the readme than a submodule.

I don't think the whole submodule thing is a great idea either. If it was a dependency that we needed to vendor, sure, but for some examples, no. Little section in the README plus a link to the repository would be enough.


Add API for reorder in current playlist

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
854

Relevant Lines:
854

💛  - Coveralls


Switch to httpx for HTTP2 support

We should use HTTP/2 to connect to the Hue bridge:

Evenstream has keepalive builtin so we can remove the workaround
No more request throttling needed

aiohttp however does not yet support http2 so we should move to httpx

No more need for workaround to detect if the connection is still alive if we switch to HTTP2


Create fab definition for dashboard and include in spk default HLD

As a: developer
I want: dashboard helm chart to be included in the default HLD created by spk
So that: the dashboard is already present on the cluster
Describe the solution you'd like:
Post completion of https://github.com/microsoft/bedrock/issues/967, it would be ideal for users of bedrock to not have to manually setup the dashboard in their cluster. However, some thinking is needed around how env vars would be passed in to the helm install command (for the vars needed by dashboard) during manifest generation or fab generate, since these env vars have secrets that are not written in the chart's values.yaml.

[ ] Investigate and provide a solution for including dashboard in default HLD

Acceptance Criteria:
Dashboard is easy to setup on the cluster
Describe alternatives you've considered:
Manually install via helm chart
Additional context:
Does this require updates to documentation?: Yes

@samiyaakhtar I think there should be an option to enable/disable this. Maybe by default it is not included but if a user adds the flag --dashboard to the spk hld init command  then this feature will be enabled.

So spk hld init --dashboard will add a reference to Spektate when the user sets up the HLD.
This method is idempotent so if the Spektate dashboard exists in the HLD no change will happen.

Thoughts? cc @mtarng


Proper uninstall

Hey! :)
I've wanted to use this app for showing tray icons, but it doesn't work unfortunately, so I tried to uninstall it.
Please make a proper uninstall method, because just deleting the program files leaves in place start menu shortcuts and, the most inconvinient, the context menu shortcut, for which I've needed to use ECMenu for deleting it.

how to uninstall it?


Add a metric and an alarm for the cluster in protected mode error

Description of changes

Implement a new metric named ClusterInProtectedMode to oversee the cluster's status, specifically if it's operating in protected mode. The metric also includes a blue line labeled "Cluster Is In Protected Mode" when the sample count equals 1.
Introduce a new alarm called ProtectedModeAlarm that alerts users when the cluster operates in protected mode. Add a new constant, PROTECTED_MODE_THRESHOLD = 1, to the constant.py file, serving as the alarm's threshold value.

Tests

Add a unit test in test_cw_dashboard_builder.py
Conduct manual tests for both the alarm and the metric within clusters, by intentionally inducing the protected mode error.

Checklist

[x] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[x] Check all commits' messages are clear, describing what and why vs how.
[x] Make sure to have added unit tests or integration tests to cover the new/modified code.
[x] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Could you update the PR description of an example output dashboard and alarm?

Could you update the PR description of an example output dashboard and alarm?

Added two screenshots to reflect the metric and the alarm of the protected mode error.


v0.3.7

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/85637
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.7 -m "<description of version>" dcb87861e2c02c278635ee848669797e32414ff7
git push origin v0.3.7


Fix Gist getId() and deleteFile(), add getGistId()

Fixes #682
Also add deleteFile() to GHGist
@martinvanzijl @Aulig
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.

[x] Push your changes to a branch other than master. Create your PR from that branch.
[x] Add JavaDocs and other comments
[x] Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
[x] Run mvn clean compile locally. This may reformat your code, commit those changes.
[ ] Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

@bitwiseman Would you like us to review the changes?

@martinvanzijl  Yes, if you have time that would be great.

@bitwiseman I've reviewed the changes, please check my comments. Looks mostly reasonable, but it may introduce confusion to have two possible types for body in GitHubRequest (InputStream and plain Object).

@martinvanzijl
Thanks!  Due to your comments I went back reconsidered the whole PR.  Turns out the change was a lot simpler than I first thought.


Develop ivan

From Cora's notes:

[x ] - update instructions to not mention ARTIFACTORY (I took the vars out of the script)
[ x] - before running actions, create cat-service-release repo first via UI (took this out of the intro).
[ x] - the release repo must be public - can include images for creating new public repo -
[ x] - Switch to bump through UI (effort to avoid resetting passwords in tutorial)
[ ] - Show a screenshot that tests passed.

Screenshot for passed test unavailable at this point, until tests added*

relevant changes are in commit da77873 performed merge afterwards so noting if interested.
Also added a picture to first page on forking.*


Add Alpine build from source instructions.

These instructions assume that PR #2103 will be merged prior to this PR being merged.

Thanks!

Just a reminder that the instructions are incorrect until #2103 is merged with to the change from libexecinfo to libunwind. Prior to that PR being merged the instructions should have libexecinfo-dev instead of libunwind-dev on https://github.com/ponylang/ponyc/pull/2104/files#diff-04c6e90faac2675aa89e2176d2eec7d8R339 in order to work correctly.

Whoops, sorry I missed that note. Should I unmerge?

Up to you. You can alternatively fix the instructions to reference libexecinfo-dev for now and then make sure they get updated to libunwind-dev as part of #2103. Either way works but the instructions are incorrect for the code on master as it exists right now.


feature/BE-15

Sole intention of this PR to integrate AWS S3 with our backend. Here how you can review it:

That would be nice to read the related issue #246 in the first place. I used this guide to configure the S3, so reading it would give you a concrete idea about what you're going to review. That's ok if you don't read it but it's very short anyways.
Firstly, reach me out and ask for the credentials. Put those credentials into the .env file. (I'll directly send the whole file to you, just let me know)
Install the requirements.
Run the application and open the admin panel.
Create a user or open the profile of an already existing user.
Attempt to change the profile picture of him. Now, it should be stored in the cmpe451-development S3 bucket.
Try to open the image. If the access is denied, then that indicates that we successfully stored the image in the bucket. We can't open it because it requires credentials (clicking on the URL doesn't provide the credentials). Providing credentials and opening the images is something that must be done in the frontend. We'll be in touch with them to make this procedure as smooth as possible.

Other changes present in this PR related to a previous PR #245 in which I integrated Swagger to our application. I strongly recommend you to have a look at that first and approve it if possible. We should merge Swagger integration to master as soon as possible for others to document their APIs this week.

It's been 11 days since I opened the PR folk. Still waiting for review @BElifb @mumcusena @serdarakol. Frontend is also welcomed to review it since they are currently working with AWS, @kostanya @sinemKocoglu.

I reviewed it and everything seems fine, I was able to run the application with AWS credentials. We are GTG, you can merge the PR.


AD B2C authority not working

Describe the bug
I am using AD B2C tenant. And I am using the authority in the form of https:///tfp/// as mentioned in the configuration.dart for Azure B2C.
But it is going to the wrong authorize endpoint starting with https://login.microsoftonline.com and I am getting bad request error.
Environment (please complete the following information):

Flutter: [yes]
Browser: [e.g. chrome]
Dart msal_js Version: [e.g. 1.3.0 ]
JavaScript msal.js Version: [e.g. 1.3.4]

Looks like markdown messed up the docs for authority, you're using it in the form of https://{instance}/tfp/{tenant}/{policyName}/ correct?
The authority format for B2C also changed somewhat recently to https://{your-tenant-name}.b2clogin.com/tfp/{your-tenant-id}/{policy-name}/ (doesn't use login.microsoftonline.com for the first part). You may also not need the tfp part, the B2C docs are inconsistent with it so I don't really understand why it's needed sometimes and others not.
msal.js also has some issues with the new B2C authorities. If you're not setting validateAuthority to false, make sure to add the domain you use to knownAuthorities ({your-tenant-name}.b2clogin.com).

Closing this for now.
If you're still having configuration troubles, you may want to consider opening an issue up in the msal.js repo https://github.com/AzureAD/microsoft-authentication-library-for-js. This package just passes configuration directly to it.

@Francessco121 Thanks for your help. I managed to get it working with setting validateAuthority to false.


[606] Configure DFE Sign-in redirect URL for AKS environments

Trello card URL
https://trello.com/c/QvrkR3vd
Changes in this PR:
Add a new variable to override DFE_SIGN_IN_REDIRECT_URL only on AKS
How to review
Deployed manually to qa2: https://qa2.teaching-vacancies.service.gov.uk/

 Create custom domains for AKS environments


"other-identifier" element doesn't appear in published XML file

[ ] Show "other-identifier" element in XML

When you publish the activity containing "other-identifier", it doesn't appear in XML file. It should appear in the XML.

Deployed.


Prompt user for deployment option with the cloud module

After a predictor is fitted, giving user a prompt for using the cloud module as a deployment option.

I recently had a short conversation with @Innixma offline. We both agreed that improved documentation with concise instructions would greatly benefit users who experiment, train, and debug models locally, and then wish to deploy them to the cloud in a reliable manner. We have a few potential options to consider:

[Preferred] Implement a new parameter across all predictors that enables users to directly run their training in the cloud once they are satisfied with the local results. For instance, this parameter could be named cloud_option="aws_sagemaker".
Include comprehensive log entries at the conclusion of the training process, providing users with instructions on how to reproduce the same results using the corresponding parameters in the CloudPredictor.

Also, it would be better to update our installation guide on the docker DLC usage guide on EC2

It would be good to introduce the concepts and relations of sagemaker, autogluon-cloud, and DLC. We may need to recommend some training+deployment pipelines such as using autogluon-cloud's fit and deploy APIs.  Let users know their training and deployment envs should be the same.


generate-sas needed Contributor role

This is autogenerated. Please review and update as needed.
Describe the bug
I created an app registration via AD.  I assigned the role: Storage Blob Data Contributor at the container and account level.    I received the permissions error.
az login --service-principal --username <redacted> --password <redacted> --tenant <redacted>

EXPIRE=$(date -u -d "1 day" '+%Y-%m-%dT%H:%M:%SZ')
START=$(date -u -d "-1 day" '+%Y-%m-%dT%H:%M:%SZ')

ACCOUNT="stsecureupload"
CONTAINER="intake"
SAS=$(az storage container generate-sas --account-name "$ACCOUNT" --name "$CONTAINER" --start "$START" --expiry "$EXPIRE" --https-only --permissions acdlrw --auth-mode login --as-user)

SAS=$(sed -e 's/^"//' -e 's/"$//' <<<"$SAS")
echo $SAS

I then assigned the Contributor Role the the App Registration and then it finally created a SAS.
Command Name
az storage container generate-sas
Errors:
You do not have the required permissions needed to perform this operation.
Depending on your operation, you may need to be assigned one of the following roles:
    "Storage Blob Data Contributor"
    "Storage Blob Data Reader"
    "Storage Queue Data Contributor"
    "Storage Queue Data Reader"

If you want to use the old authentication method and allow querying for the right account key, please use the "--auth-mode" parameter and "key" value.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az storage container generate-sas --account-name {} --name {} --start {} --expiry {} --https-only --permissions {} --auth-mode {} --as-user

Expected Behavior
Environment Summary
Linux-4.4.0-18362-Microsoft-x86_64-with-debian-buster-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.78 *

Extensions:
azure-devops 0.16.0

Additional Context

The App Registration as service principal is a kind of Azure AD security principal. To request the user delegation key, a security principal must be assigned the Microsoft.Storage/storageAccounts/blobServices/generateUserDelegationKey action. The following built-in RBAC roles include the Microsoft.Storage/storageAccounts/blobServices/generateUserDelegationKey action, either explicitly or as part of a wildcard definition:

Contributor
Storage Account Contributor
Storage Blob Data Contributor
Storage Blob Data Owner
Storage Blob Data Reader
Storage Blob Delegator

If the security principal is assigned any of the built-in roles listed above, or a custom role that includes the Microsoft.Storage/storageAccounts/blobServices/generateUserDelegationKey action, at the level of the storage account, the resource group, or the subscription, the security principal will be able to request the user delegation key.
Therefore, no matter App Registration is given the role of Contributor or Storage Blob Data Contributor, as long as Microsoft.Storage/storageAccounts/blobServices/generateUserDelegationKey action permission is given, so the user delegation sas can be generated.

Therefore, no matter App Registration is given the role of Contributor or Storage Blob Data Contributor, as long as Microsoft.Storage/storageAccounts/blobServices/generateUserDelegationKey action permission is given, the user delegation sas can be generated.
@ghstahl May I ask did you give App Registration the role of Storage Blob Data Contributor when this problem arises? You can use the command az role assignment list --role 'Storage Blob Data Contributor' to have a check~

Because there is no reply to this question for a long time, I will close it temporarily. If you have any questions, please feel free to let us know.