Update code that references openapparel.org

Add .opensupplyhub.org to the ALLOWED_HOSTS list in settings.py
Change DEFAULT_FROM_EMAIL in settings.py
Add opensupplyhub to CORS_ALLOWED_ORIGIN_REGEXES in settings.py
Update reports that exclude OAR emails with AND NOT u.email LIKE '%openapparel.org%' to also exclude opensupplyhub.org email addresses.

Hey team! Please add your planning poker estimate with Zenhub @nanotubing @TaiWilkin


Enhance ds:check for dsq, ds-macro and commented ds

Hi Luan,
This PR enhances the php artisan ds:check and does not introduce any breaking change.
Main changes

The dsq() is now included in the functions to be checked;
Commented  calls //ds() will produce now produce a  "ds() found error";
Macro DS calls User::query()->where('id', 20)->ds()->get(); also produces a  "ds() found error";
Changed the ci_check.directories to base_path('app');
Removed the spaces on ci_check.text_to_search for better user experience;
Test is now checking for functions; whenever  a new shortcut is created, it must be included there.

Problem
Currently, ds:check is not detecting the commented calls and macro calls.
Even though commented ds() calls would  not produce any problem, having them in the final product can be seen as a "less professional" code quality.

Result

Please let me know if changes are required.
Greetings and thanks,
Dan

Hi Luan,
This PR enhances the php artisan ds:check and does not introduce any breaking change.
Main changes
* The `dsq()` is now included in the functions to be checked;

* Commented  calls `//ds()` will produce now produce a  "ds() found error";

* Macro DS calls `User::query()->where('id', 20)->ds()->get();` also produces a  "ds() found error";

* Changed the `ci_check`.`directories` to `base_path('app')`;

* Removed the spaces on `ci_check`.`text_to_search` for better user experience;

* Test is now checking for functions; whenever  a new shortcut is created, it must be included there.

Problem
Currently, ds:check is not detecting the commented calls and macro calls.
Even though commented ds() calls would not produce any problem, having them in the final product can be seen as a "less professional" code quality.

## Result

Please let me know if changes are required.
Greetings and thanks,
Dan


profile menu: Show profile-edit option when a user clicks on self-profile.

This removes some options when a user clicks on their own profile. And add
a link to edit their own profile settings.
Front end test adjusted because it was testing an option that does not
appear if a user clicks on their own profile.
Fixes #5075
@ryanle42 FYI

It looks like:

@timabbott rebased version of #7725

Merged, after cleaning up the commit message's explanation a bit, and changing "Edit profile" to "Edit your profile" for clarity.
Thanks @YJDave and @ryanle42!


Prevent header navigation and title overlapping

What

Prevents the header title and logo from overlapping. Partially mends #1029 (this pull request doesn't fix the overlap of the 'Menu' button).
Why

The overlap looked broken and made it difficult to read the links.
Visual Changes

Before:

After:

View Changes
https://govuk-publishing-compo-pr-1057.herokuapp.com/component-guide/layout_header/with_navigation/preview

@andysellick The link has been marked as 'active', e.g: to signify it's the current page you're on.


Consider dropping support for launch config deduction

As part of an effort to whittle down the kernel adapters as much as possible, we could require users to specify a launch configuration themselves , rather than allow logic to infer in the kernel adapter class.
This may become necessary if we end up supporting adapterless execution by kernel source parsing (#10).

In practice, I find myself using that in some adapters.


[backport] Add parallel build feature

Backport of #4240

[automatic post] Jenkins, test this please.

In v8 I would like to provide this feature as a hidden option for safety. Defaulting to 1 and do not touch self.parallel when the environment variable is not set.

Jenkins CI test (for commit 03ee6a53b2321431da00e54c38ed06f374a4935a, target branch v8) succeeded!

Currently, instability is discovered in some environments. See #4344 for details.


show valid default asset on send page

After carrying out a transaction, the asset field will then update based on the filtered assets.
Do we want the Asset field to update after a user commits a transaction?
For example, if you send some LUNA to a wallet, after the transaction is successful, the asset field will update based on the filteredAssets variable to something like axlUSDC.
Fixed. We should be able to pass those values directly to the reset call but it's not working for some reason...

https://react-hook-form.com/docs/useform/reset

After carrying out a transaction, the asset field will then update based on the filtered assets.
Do we want the Asset field to update after a user commits a transaction?
For example, if you send some LUNA to a wallet, after the transaction is successful, the asset field will update based on the filteredAssets variable to something like axlUSDC.

Is this resolved now on your end?


Oncluster build initial e2e set of tests

Changes
This PR contains an intial set of tests for On Cluster builds according to #856

:gift: E2E on cluster build tests

/kind enhancement
The following is covered by this PR

[x] Deploy on cluster a default function from a public git repository, from a default branch
[x] Deploy on cluster a default function from a public git repository, from a feature branch
[x] Deploy on cluster a default function from a public git repository, from a commit hash
[x] Deploy on cluster a default function from a public git repository, from a tag revision
[x] Deploy on cluster a default function located in a specific directory from a public git repository, from main branch
[x] Updated changes to a function get deployed
[x] Deploy on cluster a default function for each language: node, python, quarkus, springboot, typescript
[ ] Deploy on cluster a fuction from a public GitHub repository
[ ] Deploy on cluster a fuction from a public GitLab repository
[ ] Deploy on cluster a default function from a Private git repository using basic http auth
[ ] Deploy on cluster a default function from a Private git repository using ssh auth
[x] Triggers on cluster build from cli when func.yaml indicates local
[x] Triggers on cluster build from cli when func.yaml indicates local from a specific branch
[x] Triggers on cluster build from cli when func.yaml indicates local from a when a functions is on a specific directory
[x] Triggers local build from cli when func.yaml indicates build from git
[x] Ensure all resources created by on cluster build are deleted when the functions is deleted

/hold for other to approve

/unhold


[SPARK-17186][SQL] remove catalog table type INDEX

What changes were proposed in this pull request?
Actually Spark SQL doesn't support index, the catalog table type INDEX is from Hive. However, most operations in Spark SQL can't handle index table, e.g. create table, alter table, etc.
Logically index table should be invisible to end users, and Hive also generates special table name for index table to avoid users accessing it directly. Hive has special SQL syntax to create/show/drop index tables.
At Spark SQL side, although we can describe index table directly, but the result is unreadable, we should use the dedicated SQL syntax to do it(e.g. SHOW INDEX ON tbl). Spark SQL can also read index table directly, but the result is always empty.(Can hive read index table directly?)
This PR remove the table type INDEX, to make it clear that Spark SQL doesn't support index currently.
How was this patch tested?
existing tests.

cc @yhuai @gatorsmile

Test build #64205 has started for PR 14752 at commit d2bc794.

Test build #64205 has finished for PR 14752 at commit d2bc794.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64205/
Test FAILed.

The changes look reasonable. We just need to completely remove them from the code base.

Test build #64245 has started for PR 14752 at commit 688802b.

Test build #64245 has finished for PR 14752 at commit 688802b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64245/
Test FAILed.

Test build #64253 has started for PR 14752 at commit d1e83d2.

Test build #64253 has finished for PR 14752 at commit d1e83d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64253/
Test PASSed.

Thanks - merging in master/2.0.


Support Slack-style webhooks

Supporting Slack-style webhooks would allow Notifico to be used in a more generic interface that can support many services that provide webhooks, such as server monitoring services.
Another potential avenue would be Discord-style webhooks, but since Discord has a Slack webhook compatibility layer, I think Slack should have more priority.

There will definitely be limits to what we can reasonably do with this as a v1. Slack webhooks can be very complex, and even interactive.


Add make target for updating the main deps to master

Make it easier to update kpt to use the latest versions of the upstream kyaml, cmd/config and cli-utils libraries.

/lgtm


Caching using Angular-Cache and Restangular

Hi, this is my first time using Github so please if I posted this in the wrong place just tell me to repost it somewhere else :)
Basically I am trying to implement a basic caching system based on routes using angular-cache and restangular.
Here is the stackoverflow link with all the code example: http://stackoverflow.com/questions/25626981/cancelling-get-request-to-server-using-restangular
The problem I am having is that of trying to cancel the request when the same request object has been found in the cache.
Thanks

@abonnici Were you able to figure this out?


RtlULongLongToLongLong  return value documentation is incorrect.

The documentation for RtlULongLongToLongLong states there is no return value, when it returns NTSTATUS in the signature?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5482baf4-6375-1e28-2031-5cc83d4b767f
Version Independent ID: 33416e02-4afd-7bad-9743-62bfa0f9db6f
Content: RtlULongLongToLongLong function (ntintsafe.h) - Windows drivers
Content Source: wdk-ddi-src/content/ntintsafe/nf-ntintsafe-rtlulonglongtolonglong.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Thanks for the report @bgianfo
I noticed that the same is true for every function page in the ntintsafe.h header, https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/ntintsafe.
I just pushed an update for all of them that says returns success or check the header for error values (since they are all inline).  It looks like 2/3 of them return STATUS_INTEGER_OVERFLOW (including the one you reference) but not all.
Update should be on the live site within an hour or so.


Issue replicating results

Hello, I've been looking to run predictions through your fine-tuned USPTO-50K model, and I'm getting 0% accuracy. Even though the generated molecules are similar, not a single one is exactly correct. Here are the test SMILES I gave the model as input. Here's an example of the output I'm getting:
python -m molbart.predict \
        --reactants_path {input_file} \
        --products_path {output_file} \
        --model_path {model_file} \
        --batch_size 64 \
        --n_beams 10

source       |  COC(=O)c1ccc2c(c1)n(CCC(C)C)c(=O)n2CCC(C)C
prediction   |  CC(C)CCBr.COC(=O)c1ccc2[nH]c(=O)n(CCC(C)C)c2c1
target       |  CC(C)CCn1c(=O)n(CCC(C)C)c2cc(C(=O)O)ccc21

The sha1sum of the checkpoint i downloaded is c859c68b198ac1b8cfab48196bdde6b35641bf81. However, I had to adjust the model to fit the Chemformer 2.0 code. I ran the following code to convert the model before using it.
chemUSPTO50 = torch.load('Chemformer USPTO-50k.ckpt')
chemUSPTO50['hyper_parameters']['vocabulary_size'] = chemUSPTO50['hyper_parameters'].pop('vocab_size')
torch.save(chemUSPTO50, 'Chemformer2 USPTO-50k.ckpt')

If you know why this is happening, or if you are using a different model for the results below please let me know. Thank you.

Sorry, I realized was running forward reaction prediction but the model was fine tuned on retro-synthesis. I'm getting high T1 accuracy now that i've fed the products into the model.


pull request for e2e test at 01/20/2017 09:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Proposal:partial generics

I want to omit it when the compiler can type infer
Example
Observable.of(1,2,'str')
  .filter<number|string,number>((x):x is number=>typeof x==='number');

Partial generics
Observable.of(1,2,'str')
  .filter<*,number>((x):x is number=>typeof x==='number');

More Better
Observable.of(1,2,'str')
  .filter<*,*>((x):x is number=>typeof x==='number');

I'm surprised you need to specify the types at all in these situations. I thought that API (if you are using RxJS) was fairly overloaded to infer unions. Any way you can get a lot of this with default generic parameters. if the Declaration is such that the consumer must regularly Supply explicit type arguments at the call site then the API needs to be heavily reworked.

Array#filter will also be better
Example
[1,2,'str']
  .filter<number>((x):x is number=>typeof x==='number');

Partial generics
[1,2,'str']
  .filter<*>((x):x is number=>typeof x==='number');

rxjs
https://github.com/ReactiveX/rxjs/blob/master/src/operator/filter.ts#L6
export function filter<T, S extends T>(this: Observable<T>,
                                       predicate: (value: T, index: number) => value is S,
                                       thisArg?: any): Observable<S>;

Duplicate #10571 ?

OK.Thanks!


Delete duration SplashScreen

Requirement
the splashscreen must disapear when data is load
To do
Delete the duration in the splashscreen

duplicate #1026


CakePHP 4

Using the correct branch for CakePHP 4, I was unable to get the table to display the data for a long time.
I eventually fixed it by changing
<?php
echo $this->DataTables->table('datatable', $options, ['class' => 'table table-striped table-responsive']) ?>

to
<?php
echo $this->DataTables->table('datatable', $options, ['class' => 'table table-striped table-responsive']);
echo $this->Html->scriptBlock($this->DataTables->draw("#datatable", $options)); ?>

I have to use the the 2nd line when I thought it would be added due to the DataTables->table() function
Everything works as expected with this change
Could this info be added to the README or some other documentation page?

That really doesn't make much sense. If you look at the code:
https://github.com/ypnos-web/cakephp-datatables/blob/master/src/View/Helper/DataTablesHelper.php#L76-L78
You can see that your second call is a replication of what the table() method does already

I agree. It doesn't make sense to me either as I also went into the table() method before opting for this.
I then went through with debug() inside table() and table() only ever returns

Changes to my $options array did not make data show up in the table.
Searching for how to make the data show up in the table led me to this section:
e) Now draw the datatable:
echo $this->Html->scriptBlock($this->DataTables->draw("#$id", $options));

in https://github.com/ypnos-web/cakephp-datatables/issues/79#issuecomment-641909787 and decided to try it, which made the tables show up.
Such was the case in 3 different locations on the same site we are using this.
Doing that second line made the table show up with data. Without it, it only returns the table tags.


Updated the marker display to allow namespaces to be enabled/disabled from the config

The marker display does not currently load the enabled/disabled state of namespaces from its config. Those values are simply not used. These changes load the enabled/disabled state of namespaces from the config into a map which gets used to disable namespaces when they are added.
This is essentially the same fix as commit 0baa9f351cb73f880141ecfabd61aaa224de7458 but applied to the marker display instead of the tf display.

lgtm
I was able to reproduce this with the basic_shapes demo in the visualization_marker_tutorials package.


Adding command to open the generated file in chrome window

Move PR #27 to here, since it's not actually a PR.

Hi @hajsf, let's discuss the idea here. Sorry for any inconvenience in advance.
The idea is really good and this is a lot of tools is doing. However, my personal doesn't want to have it in Plotters, because it's out of its domain. Plotters is basically a plot rendering library. Yes there are a lot of cool features out there, but Plotters should keep simple and functioning well.
For the feature you described I think a good approach is like this:
use plotters::prelude::*;
fn main() {
    let file = "out.png";
    {
         let bg = BitmapBackend::new("out", (1024,768));
         // Some drawing here
    }
    std::process::Command::new("chrome").args(.....).spawn();
}

In addition to that, I doesn't feel comfortable with the assumption that everyone has chrome installed. Plus it seems some body else would use a image viewer to open it.
And please share you idea, and maybe I was wrong. And I am very happy to talk.
Thanks,
Hao

Hi Hasan @hajsf,
Thanks for the suggestion, but I think it's out of the domain of Plotters. So closing this issue. Feel free to reopen it if you think this is really desired for Plotters. Any comment is welcome :)
Thanks again!


Game Status

Hi!
I'm using Discord.Net 2.0.0-beta-00858 and the code SetGameAsync isn't working (works on beta 00854 but there animated emotes are not supported). Am I doing something wrong? Or I need to use IActivity instead?
Also, can be added "Watching" and "Listening to" game statuses please?
Listening to - game type 2
Watching - game type 3

Yes, you'd have to use Activity instead, based on the changes made.

And, can I get an example? On how to set?

I haven't updated... I just know that that in particular was changed. Didn't take a look at it myself

Would be interested to know how to use it too.


Definite answer on subtitle rendering

I have been reading the doc extensively and I am struggling to consistently render subtitles, and I'd appreciate some direction

The default setup (using Flutter widget if I understand correctly) seems to work with some subtitles but with very little formats. Among others Ass is not supported, even thought it is probably one if not the most used format
On the back of that realization, I foudn the libass: true configuration to use libass. When I enabled this, I was able to make subtitles work perfectly on windows
On Android, I gather I needed to add libassAndroidFont but even with that option, I was still not able to show embedded ASS subtitles.

Which brings me to trying to figure out what is the most "recommended" setup for subtitles?

Is it possible to get the default flutter to at least have basic support for ASS subtitle, or is this not possible?
can libass still work on Android? And also I am curious to understand why is Android the only platform who needs an external font? (just out of curiosity)

Which way should I lean for the widest range of support?
Thanks for your help

After further investigation sounds like libass is a great option, only i found it impossible to make it run on Android
This is what I have set:
class _FullscreenVideoPlayerState extends State<FullscreenVideoPlayer> {
  late final player = Player(
      configuration: PlayerConfiguration(
    libass: true,
    libassAndroidFont: 'assets/fonts/Montserrat-VariableFont_wght.ttf',
  ));

any help appreciated thanks

1.PlayerConfiguration(libass: true);
2.await _nativePlayer.setProperty("sub-fonts-dir", fontsDir);
3.await _nativePlayer.setProperty("sub-font", "Droid Sans Fallback");

It works for me

Can you give me an example? Also having problems with ass/ssa subtitles

Player _player = Player(configuration: const PlayerConfiguration(libass: true, logLevel: MPVLogLevel.debug);

_player.stream.log.listen((event) {
   print(event);
}),

// copy the font to device
if (Platform.isAndroid) {
   NativePlayer _nativePlayer = _player.platform as NativePlayer;
   final ByteData data = await rootBundle.load("assets/fonts/subfont.ttf");
   final Uint8List buffer = data.buffer.asUint8List();
   final Directory directory = await getApplicationSupportDirectory();
   final String fontsDir = "${directory.path}/fonts";
   final File file = File("$fontsDir/subfont.ttf");
   await file.create(recursive: true);
   await file.writeAsBytes(buffer);
   await _nativePlayer.setProperty("sub-fonts-dir", fontsDir);
   await _nativePlayer.setProperty("sub-font", "Droid Sans Fallback");
}

_player.open(Media("xxxxxxx"));

the "Droid Sans Fallback" font from https://github.com/RPi-Distro/fonts-android/blob/master/DroidSansFallback.ttf
if not work, you need check the logs

Player _player = Player(configuration: const PlayerConfiguration(libass: true, logLevel: MPVLogLevel.debug);

_player.stream.log.listen((event) {
   print(event);
}),

// copy the font to device
if (Platform.isAndroid) {
   NativePlayer _nativePlayer = _player.platform as NativePlayer;
   final ByteData data = await rootBundle.load("assets/fonts/subfont.ttf");
   final Uint8List buffer = data.buffer.asUint8List();
   final Directory directory = await getApplicationSupportDirectory();
   final String fontsDir = "${directory.path}/fonts";
   final File file = File("$fontsDir/subfont.ttf");
   await file.create(recursive: true);
   await file.writeAsBytes(buffer);
   await _nativePlayer.setProperty("sub-fonts-dir", fontsDir);
   await _nativePlayer.setProperty("sub-font", "Droid Sans Fallback");
}

_player.open(Media("xxxxxxx"));

the "Droid Sans Fallback" font from https://github.com/RPi-Distro/fonts-android/blob/master/DroidSansFallback.ttf if not work, you need check the logs

Damn this is a life saver been trying to look for this answer for 2 weeks. Thanks!

Thanks a lot @SmartVive, I have updated our API:

#963


Updated Readme.md for companies using Argo:

Added Peak.ai in the companies list that officially using Argo. We at Peak are developing a new product feature that is machine learning code workflow as a service based on Argo workflows/DAG.
Checklist:

[ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
[ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". Why? for the release notes.
[ ] Optional. I've added My organization is added to the README.
[ ] I've signed the CLA and required builds are green.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


What is documentation?

Good afternoon! My name is Anton.
I have been using your library for a year. I really like using this library. I have been studying the source code of your library for a long time. What I just didn't see there! But that's not what I wanted to tell you at all.
And so, do you know why, I studied your source code? The fact is that there is no documentation in the repository. It is completely absent. And so, a counter question is asked: How to use your library without knowing its functionality?
Turning to the developers of this miracle, I ask you to add documentation. Preferably, to everything that can be used in practice. Also, it does not hurt to add examples of use in everyday tasks. If the developer does not add documentation, then I will remove the star from his repository.  Time has passed.
Sincerely, qxtony.

Hi, qxtony! I appreciate your concern. Unfortunately, the project is stiil a work in progress. Documentation is coming soon. Please be patient. 😊

Thanks for the answer!


Goals

I like that you added your goals. Maybe you can add in your reflection how it went and what went good and wrong etc.

Good point! Done


Ensure ForkedBlockchain.prototype.getAccount works

This issue pulls out #3 from https://github.com/trufflesuite/ganache-core/issues/483#issuecomment-680185528:
Yes, I meant ForkedBlockchain.prototype.getAccount. There might be a separate bug in this fn, I haven't checked if there are tests for this scenario yet:

contract account A exists at block 9 on the original chain. it has a non-zero balance
we fork at block 10
we selfdestruct() the contract on our fork at block 11, thus transferring its value to another address.
getAccount(account A, block 12) may return the account from the original chain. A call to eth_getBalance may return the non-zero account value.

This was released in https://github.com/trufflesuite/ganache-core/releases/tag/v2.12.2-beta.0


Add tagging to s3 versioned objects

Adding the ability to specify the version id of an S3 key when tagging an object.
Issue: https://github.com/spulec/moto/issues/2486

Coverage decreased (-0.008%) to 93.487% when pulling f788fd5c8cd0251fa0ffca57925045999020cbf6 on Htermotto:harrison__add_tagging_to_s3_versioned_objects into 16a0e93259bec370f65eb1232e842ad4999fc23d on spulec:master.

Coverage decreased (-0.008%) to 93.487% when pulling f788fd5c8cd0251fa0ffca57925045999020cbf6 on Htermotto:harrison__add_tagging_to_s3_versioned_objects into 16a0e93259bec370f65eb1232e842ad4999fc23d on spulec:master.

Very nice!


Add OpenAPI spec with generated client

Purpose
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the changelog
[ ] Added tests
[ ] Updated the spec
[ ] Checked native-image compatibility

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

ballerina/openapi.json should be added into docs/spec folder.

@KamalikaSene we need to incorporate licensing header into the generated code. If you run following command from the repository root, it would generated client code with licensing header.
bal openapi -i docs/spec/openapi.yml --mode client --license docs/license.txt -o ballerina

@KamalikaSene it seems like when generating the client the authentication related configs are not properly set [1] due to a bug in OpenAPI tool. Can you create an issue for the is ballerina-library repo [2] @lnash94 FYI
[1] - https://github.com/ballerina-platform/module-ballerinax-discord/blob/bb9dae023216816ce3f1c7b09e03cd548f7fa1e8/ballerina/client.bal#L42
[2] - https://github.com/ballerina-platform/ballerina-library

Lets remove ballerina/openapi.json from the PR.

https://github.com/ballerina-platform/module-ballerinax-slack/pull/151#issuecomment-2188037326

we also need to add a sanitations.md file including all the sanitations we did on the original spec and, the exact command we used to generate the client using the openAPI tool. (A example PR with the expected file structures can be found in https://github.com/ballerina-platform/module-ballerinax-asana/pull/2/files)


Not usable with nanovg

Both projects are directly including stb. Not good. Maybe STB should be treated as every other lib and not as header only.
16:03:10:503	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_from_memory already defined in nanovg.lib(nanovg.c.obj)
16:03:10:503	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_from_callbacks already defined in nanovg.lib(nanovg.c.obj)
16:03:10:503	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load already defined in nanovg.lib(nanovg.c.obj)
16:03:10:503	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_from_file already defined in nanovg.lib(nanovg.c.obj)
16:03:10:503	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_gif_from_memory already defined in nanovg.lib(nanovg.c.obj)
16:03:10:503	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_16_from_memory already defined in nanovg.lib(nanovg.c.obj)
16:03:10:503	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_16_from_callbacks already defined in nanovg.lib(nanovg.c.obj)
16:03:10:568	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_16 already defined in nanovg.lib(nanovg.c.obj)
16:03:10:568	2>soil2.lib(SOIL2.c.obj) : error LNK2005: stbi_load_from_file_16 already defined in nanovg.lib(nanovg.c.obj)

Comment the #define STB_IMAGE_IMPLEMENTATION on nanosvg or SOIL2. SOIL2 patches stb_image to enhance its capabilities, I cannot do much about this issue, also it's trivial to disable the compilation on one of the sides.

well, both projects could at least customize the used "namespace". Just prepend soil2__ to every stb function.

Btw is your updated STB lib backwards compatible? Could I simply back it out of Soil2 and run NanoVG against it?

Yes, you should have no problem, it's the same API.

thx


fix: Update readme

Signed-off-by: Ce Gao<EMAIL_ADDRESS>

@gaocegege You probably want to update the repo description as well.


x/y coordinates LED reading/writing seems inverted

Describe the bug

On Calliope x/y coordinates when reading LEDs seems mixed up

To Reproduce
Steps to reproduce the behavior:

set LED (0,1) to brightness 5
read LED (0,1) -> brightness 0
read LED (1,0) -> brightness 5

Expected behavior

x/y coordinates of LED reading should be the same as in LED writing

Device information

OS: Ubuntu 23.10
Browser Firefox 120.0

Solved (duplicate of issue 1609)


Feature Request : Labels

Hi guyes, it's me again ^^.
Not related directly to the Dynatrace One Agent Operator (from my point of view) and more related to one Agent Operator.
It is possible to send more kubernetes data and more exactly "labels"? Right know, we only rely on namespace but we preferred to use "labels". I know we can grab labels using the Kubernetes API but due to security limitation, we can't provide external access to our cluster.
For example this is what we have:

Hey @merlindorin ,
This is already possible as of now.
Check out our documentation here:
https://www.dynatrace.com/support/help/technology-support/cloud-platforms/kubernetes/other-deployments-and-configurations/leverage-tags-defined-in-kubernetes-deployments/
Hope this helps!
Regards,
Marco

hey @DTMad , thx for the answer.
From what the doc say... we have nothing to do for grabbing these tags. But we still don't have any label in tags :/.
Are you sure that one-agent will grab these labels and not Dynatrace itself using the Kubernetes API?
For memo, this is our tags (kubernetes section) :

Hi! You need to grant the view role to the Service Accounts used by your Pods (see https://www.dynatrace.com/support/help/shortlink/kubernetes-tagging#grant-viewer-role-to-service-accounts) to use this feature.
Nonetheless, we're also working on improving the experience with Kubernetes and Dynatrace, including your security concerns and these labels.
Best regards,
Luis


RDKDEV-987 - Upstream PlayerInfo Resolution 2160P60 Changes

Reason for change: After setting resolution 2160P60, while fetching for PlayerInfo.resolution its returning 2160P60 instead of 2160P. As this is generic change, need to upstream the AMLS905X4-763_2160p-PlayerInfo_Resolution.patch file.
Risks: Low
Test Procedure:
TDK PlayerInfo test cases: SetAndGet_All_Supported_Resolutions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sprint branch is changed to "sprint/24Q2". So, i am closing this PR to create New one.


Check for nil viewcontroller when removing observer

STPopup may lose its reference to view controller, especially after memory warning, causing bad access crash.
Checking for existence of view controller before removing observer prevents the crash

@artonragsdale _viewControllers in STPopupController holds strong reference of UIViewController, and it's not cleaned up when memory warning is received. Even it's set to nil, calling a function to nil will not crash. Do you have any crash log on this issue?

@kevin0571 I actually fixed this a while ago and just got around to submitting a pull request but it did solve a crash bug my app was experiencing. I'll have to look back through old crash reports to see if I can find it.


feat: add helper functions to initialize React Router integration

Why

Instead of passing a version field, just call a function with the version you want. Removes a nesting level, and a coupling between fields in the object (from the user's perspective)
What
Added helper functions for v4, v5, v6 and v6 data routers

Links

Checklist

[ ] Tests added
[x] Changelog updated
[x] Documentation updated

it was in the react package's readme. fixed! 👍

For reference: pr to update cloud doc [private repo]


Add Zb* extensions via auto-generation

implements #16 with auto generated tomls

these toml files were auto-generated with the help of the riscv-opcodes library
they haven't been tested yet, since I didn't generate any tests for them at this point, but feel free to use and try them out until then


cmd/go: slightly confusing import cycle error when a package imports itself

What version of Go are you using (go version)?
go version devel +f3f507b2d8 Fri Dec 22 21:13:38 2017 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What did you do?
Create the package p in my GOPATH, with a single file, then run go install:
package p

import "p"

What did you expect to see?
Some sort of error, like "a package cannot import itself".
What did you see instead?
$ go install
can't load package: import cycle not allowed
package p
        imports p
import cycle not allowed
package p
        imports p

This is a minimal example - I found this while merging package B into A, when B was importing A. This resulted in a couple of files in package A still importing package A.
I understand that the error is technically correct, but it's a bit confusing and it threw me off for a couple of seconds. The error message suggested above would have pointed me in the right direction faster.
It's also worth noting how the "import cycle not allowed" message is printed twice for some reason.

This error is reported by go build/install, not the compiler. Reassigning.

Do we care about GOPATH mode that much at this point? Module mode behaves better:
#!/bin/bash

docker run -i golang:1.13 <<-SCRIPT

        mkdir foo
        cd foo
        go mod init test.tld/foo
        go env GOMOD

        cat >foo.go <<-EOF
                package foo

                import "test.tld/foo"
        EOF

        go build

SCRIPT

$ ./repro.sh
go: creating new go.mod: module test.tld/foo
/go/foo/go.mod
can't load package: import cycle not allowed
package test.tld/foo
        imports test.tld/foo

The double error is gone, but I still think the message could be more helpful to humans. For example, pointing at how a package can never import itself. But if we decide that that's unnecessary, I think the issue can be closed.

The current error is:
$ go build
package go.seankhliao.com/testrepo0930
	imports go.seankhliao.com/testrepo0930 from main.go: import cycle not allowed

I feel like it's fine?

I think it's fine. I might still want a clear message like "a package cannot import itself", but perhaps that's obvious enough.


Add unit tests for .NET Core, fix issue with embedded resources

Add unit tests for the .NET Core build
Add project files for .NET Core
Fix issue with embedded resources - builds created with dotnetbuild could not read the public.xml embedded resource
Target netstandard1.3 instead of netstandard1.5 (remaining on netstandard1.3 because that's the first version which includes Encoding.ASCII)

@bartsaintgermain Can you review & approve? Thx!

@bartsaintgermain Ping!


[ENHANCEMENT] dropRight bad example 👎

Description
The slice function can take the negative negative value of the second agrimement
What does your PR belong to?

[ ] Website
[x] Snippets
[ ] General / Things regarding the repository (like CI Integration)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (non-breaking improvement of a snippet)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have checked that the changes are working properly
[x] I have checked that there isn't any PR doing the same
[ ] I have read the CONTRIBUTING document.

@Chalarangelo
What are the exceptions?
You are sure ?

I ma not sure because I am on mobile so I cannot test this right now, however it seemed like it would not handle the edge cases it used to, but your screenshot proves it does. Can someone else review and merge this PR if it works?

This should pass all test cases, but it needs the documentation updated. slice by design of the negative index implementation is dropRight( see MDN )

I agree with @skatcat31, after updating the description we should be ready to merge this!

@Chalarangelo My english skill very bad. You can update the documentation yourself ?

@retyui No problem at all! 👍


Failed to launch Cerbos: Error: Command failed

Hi there!
I am getting error with this action, the cerbos setup action runs fine, it finds the policies fine, but this error comes up in the compile cerbos action:
Error: Failed to launch Cerbos: Error: Command failed: /opt/hostedtoolcache/cerbosctl/0.29.0/x64/cerbos compile /home/runner/work/cerbos/cerbos/resource_policies --tests /home/runner/work/cerbos/cerbos/tests
Here is the full log:
Run cerbos/cerbos-setup-action@v1
  with:
    github_token: ***
    version: latest
Version from input: latest
Operating System: Linux
Architecture: x86_64
Looking for asset cerbos_0.29.0_Linux_x86_64.tar.gz in Cerbos releases.
Downloading release from https://github.com/cerbos/cerbos/releases/download/v0.29.0/cerbos_0.29.0_Linux_x86_64.tar.gz.
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/95c1cdfe-931e-45c6-bfe5-488a1fb6ecb2 -f /home/runner/work/_temp/82318d0b-a537-4b55-ad36-f8b4f57dd873
Successfully extracted binaries to /home/runner/work/_temp/95c1cdfe-931e-45c6-bfe5-488a1fb6ecb2
Adding cerbos binaries to the cache
Cached the binary cerbos in /opt/hostedtoolcache/cerbos/0.29.0/x64
Cached the binary cerbosctl in /opt/hostedtoolcache/cerbosctl/0.29.0/x64
Adding cerbos binaries to path
Added the binary to path (/opt/hostedtoolcache/cerbos/0.29.0/x64)
Added the binary to path (/opt/hostedtoolcache/cerbosctl/0.29.0/x64)

Run cerbos/cerbos-compile-action@v1
  with:
    policyDir: resource_policies
    testDir: tests
Getting path to the cerbos binary
Succesfully got path to the cerbos binary: /opt/hostedtoolcache/cerbosctl/0.29.0/x64/cerbos
Running cerbos compile process.
Configured policy directory: /home/runner/work/cerbos/cerbos/resource_policies
Configured test directory: /home/runner/work/cerbos/cerbos/tests
Added --tests flag to the command as tests are enabled
Command to run: /opt/hostedtoolcache/cerbosctl/0.29.0/x64/cerbos compile /home/runner/work/cerbos/cerbos/resource_policies --tests /home/runner/work/cerbos/cerbos/tests
cerbos compile results
  cerbos: error: compile.Cmd.Run(): tests failed
  Error: Failed to launch Cerbos: Error: Command failed: /opt/hostedtoolcache/cerbosctl/0.29.0/x64/cerbos compile /home/runner/work/cerbos/cerbos/resource_policies --tests /home/runner/work/cerbos/cerbos/tests
  cerbos: error: compile.Cmd.Run(): tests failed

It looks like the action is trying to find tests in the tests directory at the root of your repository but I assume they are actually in the resource_policies directory? Could you please post the directory layout of your repo?
Either way, the error message is not great. We'll look into fixing that. Thanks for reporting.

Thanks for the reply, @charithe , they are in the tests directory as normally structured.
Pic of directory structure:

Could it be something else then?

with:
  policyDir: resource_policies
  testDir: tests

Setting the policyDir to resource_policies makes Cerbos only search for the policies in that directory. If you import derived roles into your resource policies from the derived_rolesdirectory, Cerbos will not be able to find those -- which is what seems to have happened here. Unfortunately, due to a bug in the compile action, the output from Cerbos was suppressed. We are working on a fix for that.
Cerbos automatically discovers tests within the policy directory so you just need to set policyDir to the root of the repository to fix the compilation error.

Nice one thanks for the reply @oguzhand95 , should I set policyDir to ./ then?

Yes, you can set it like this;
with:
  policyDir: .

Have it working now, thanks!


RazorLight.Compilation.TemplateCompilationException: Failed to compile generated Razor template

I'm creating a .NET 5 worker service app that watches few other apps and sends email when required.
I'm using FluentEmail to send those emails and everything works fine, until I deploy the app.
When I deploy the app and it attempts to send an email, it throws this exception:
RazorLight.Compilation.TemplateCompilationException: Failed to compile generated Razor template:
- (3:35) The type 'Attribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (3:10) The type 'Type' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (35:37) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (38:66) 'GeneratedTemplate.ExecuteAsync()': return type must be 'Task' to match overridden member 'TemplatePageBase.ExecuteAsync()'
- (38:66) The type 'Task' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (40:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (41:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (42:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (43:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (53:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (69:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (84:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (44:19) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (92:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (47:20) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (100:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (50:20) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (108:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (53:19) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (116:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
- (124:12) The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
See CompilationErrors for detailed information
   at RazorLight.Compilation.RoslynCompilationService.CompileAndEmit(IGeneratedRazorTemplate razorTemplate)
   at RazorLight.Compilation.RazorTemplateCompiler.CompileAndEmit(RazorLightProjectItem projectItem)
   at RazorLight.Compilation.RazorTemplateCompiler.OnCacheMissAsync(String templateKey)
--- End of stack trace from previous location ---
   at RazorLight.EngineHandler.CompileTemplateAsync(String key)
   at RazorLight.EngineHandler.CompileRenderAsync[T](String key, T model, ExpandoObject viewBag)
   at CallSite.Target(Closure , CallSite , Object )
   at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
   at FluentEmail.Razor.RazorRenderer.ParseAsync[T](String template, T model, Boolean isHtml)
   at FluentEmail.Razor.RazorRenderer.FluentEmail.Core.Interfaces.ITemplateRenderer.Parse[T](String template, T model, Boolean isHtml)
   at FluentEmail.Core.Email.UsingTemplateFromFile[T](String filename, T model, Boolean isHtml)
   at WatchDog.Services.NotificationService.SendEmailAsync[TModel](String subject, String fileName, TModel model) in C:\Users\SomeOne\source\repos\WatchDog\WatchDog\Services\NotificationService.cs:line 41

My setup looks like this:

Views Folder
References

Views Folder

I added the Views folder and please note that this is a .NET 5 Worker Service project (if that matters instead of it being some Web project).

Program.cs file:

Inside the ConfigureServices, I've added the RazorRenderer as:
//Set email service using FluentEmail
<EMAIL_ADDRESS> .AddRazorRenderer(@$"{Directory.GetCurrentDirectory()}/Views/")
 .AddSmtpSender("smtp.somesmtp.com", 25)
 .AddSmtpSender(new System.Net.Mail.SmtpClient() { });

NotificationService.cs file:

private async Task SendEmailAsync<TModel>(string subject, TModel model)
{
    try
    {
        using (var scope = _serviceProvider.CreateScope())
        {
            var email = await scope.ServiceProvider.GetRequiredService<IFluentEmail>()
                    .To(string.Join(";", _emailRecipients))
                    .Subject(subject)
                    .UsingTemplateFromFile("./Views/Emails/SomeReport.cshtml", model)
                    .SendAsync();
        }
    }
    catch (Exception ex)
    {
        _logger.LogError(ex, "Failed to send email. Check exception for more information.");
    }
}

SomeReport.cshtml file:

SomeReport.cshtml is inside Views\Emails\SomeReport.cshtml which looks like this:
@using System;
@using RazorLight;
@using System.Collections.Generic;
@using WatchDog.Models;

@model IEnumerable<SomeReport>
@{
    Layout = "./Shared/_Layout.cshtml";
}

@* Work with the Model here... *@

_Layout.cshtml file:

_Layout.cshtml is inside Views\Shared\_Layout.cshtml which looks like this:
@using RazorLight;
@* Some common layout styles here *@
@RenderBody()

WatchDog.csproj file:

I've also added PreserveCompilationContext and PreserveCompilationReferences:
<PropertyGroup>
  <TargetFramework>net5.0</TargetFramework>
  <PreserveCompilationContext>true</PreserveCompilationContext>
  <PreserveCompilationReferences>true</PreserveCompilationReferences>
</PropertyGroup>

I've looked at everywhere and still haven't found a solution to this.
Please help.
Thanks!

I am a little confused why you would copy-paste so much config stuff vs. just create a GitHub repository with the full repro.
I have not used .NET 5 worker services before.  In fact, reading this issue was the first time I learned about it, so thank you for sharing.
Based on reading the docs, I would probably want to see your file csproj, as https://docs.microsoft.com/en-us/dotnet/core/extensions/workers#the-project-file basically says you need to use the worker service SDK.
That said, the issue could be as simple as .NET 5 trimming.  I am not sure how to disable trimming - I think you have to use <IsTrimmable>false</IsTrimmable>

Hi @jzabroski, thank you for the reply.
I unfortunately wasn't able to create a repo of this code as this is from my work and I can't publish code outside of work.
And you're right, it was something related to publish.
And this answer fixed the issue for me:
https://stackoverflow.com/a/68622890/8644294
Thank you!

PublishTrimmed false and IsTrimmable are very similar so not so not surprised that works but am surprised people would pass in p:PublishTrimmed=true from command line. It seems extremely bad practice to customize your pack differently and outside your csproj as developers will debug the app in a different context than actually deployed


Feature/styling

Using the automated styles and fixes by cargo fmt and cargo clippy

Reviewing this might take some time.


remove redundant header

Hi Irina, do we know if either of those IDs are used anywhere to jump directly to that section, e.g. with #sv on the end of the URL?

@ens-ap5 Looked with grep and did not find anything.

OK - thanks for checking!


Add query history telemetry

Initial set of events :

Timing for important actions like reading/writing storage file
Errors
Settings changed

Actions executed are already captured by core telemetry so don't need to do anything more there.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

38 of 52 (73.08%)  changed or added relevant lines in 2 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 42.351%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/query-history/src/queryHistoryProvider.ts
14
28
50.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/query-history/src/queryHistoryProvider.ts
8
68.57%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
29378

Relevant Lines:
64550

💛  - Coveralls


feat: new declareStore factory

I prepared a new syntax for declare store. What do you think?
before
type State = {
  id: string;
};
const USER_STATE = {
  id: string
};
const USER_STATE_UPDATES = declareStateUpdates<State>()({
  setId: (id: number) => (state) => ({
    ...state,
    id: id,
  }),
});

 type UserStore = StoreWithUpdates<
  State,
  typeof USER_STATE_UPDATES
>;

const createUserStore = declareStoreWithUpdates(
  USER_STATE,
  USER_STATE_UPDATES,
  { name: 'UserStore' },
);

const userStore = createUserStore();
// OR
const userStore = createUserStore({id: 1});

userStore.updates.setId('2')

after
type State = {
  id: string;
};
const initialState: State = {
  id: '',
};
const createUserStore = declareStore({
  initialState,
  updates: {
    setId: (id: string) => (state) => ({
        ...state,
        id: id,
    }),
  },
});

type UserStore = ReturnType<typeof createUserStore>;

const userStore = createUserStore();
// OR
const userStore = createUserStore({ id: '1' });

userStore.updates.setId('2')

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
374

Relevant Lines:
374

💛  - Coveralls

@chartyom First of all, thank you for the contribution!
Please consider the following points, because the proposed changes don't align with the library:

Please remove Deep* types for inferring a type for a state. Usage of a readonly, immutable state is not reposibility of the library. State type should be passed as it's done by existed createStore<State>().
Please reuse existed store an state types as much as possible. For example there is no need for the separate type StoreResult.
Related to the previous point, there is no need for reset() method of the store. Because an application logic is responsible for resetting a store, not the library.
The same is for getInitialState() - only application logic can decide for sure what should be considered as "initial state". Thus an initial state should not be an attribute of a store instance.
The proposed declareStore() shoud take only a value as an initial state, please don't provide a factory.

In total, I'd like to propose you to remake existed declareStoreWithUpdates() as declareStore() with only changes:

Providing parameters as an object:declareState(params: {
  initialState: State,
  updates: Updates,
  options?: StoreOptions<State>,
});

Reuse your magic for inferring state mutations (StateUpdates)
Attach a prodided updates to a resulting factory for a store, as you proposed. However, this property should be included to the common type for the factory, which will be returned by declaredStore() and declareStoreWithUpdates().

Thank you for the PR. I consider to use declareStore() as the main method for store declaration and mark declareStoreWithUpdates() as deprecated.


Cloud Credential secret cannot be found

#Bug Report
Issue
I'm here to report 2 potential bugs. Template doesn't seem to handle cloudCredentialSecretName correctly in few instances.
Context
I forked this repo to test rancher template against our rancher/vsphere environment. Here is the repo link: https://github.com/esnet/rancher-cloud-template/tree/main/charts/vsphere-test
I'm currently using v.0.6.1 for provisioning clusters. I've noticed few oddities around the cloudCredentialSecretName.
If I hard bake the secret name (not the actual secret itself) in the values.yaml file, the template will use that literally as opposed to interpolating the secret (i.e. xx-somestring). The UI (I'm using v.2.10.0) will complain that the secret does not exist. If I add the secret name in the dropdown menu under questions.yaml, then it will find the secret but complain about "cattle-global-data:cc-zzzzz" not found. I figure I'm missing something or misunderstanding concepts related to Secrets and namespacing.... could someone point me in the right direction for this?
For whatever it's worth, the helm install goes through.
SUCCESS: helm install --generate-name=true --labels=catalog.cattle.io/cluster-repo-name=rgs --namespace=fleet-default --timeout=10m0s --values=/home/shell/helm/values-vsphere-test-0.6.1.yaml --version=0.6.1 --wait=true /home/shell/helm/vsphere-test-0.6.1.tgz

For whatever it's worth, I have an active ticket with RGS:  #7589.
It's probably a skill issue but it seems like using rancher template requires a lot more effort and investment to get it to work over say Terraform. Happy to be educated and contribute to this repo if opportunity arises. Thanks everyone.


Bug of  'sequences index out of range'

The datasets is MedVidQA, model is deberta-v3-base,
When I bash run.sh ,it turn out that: the index of sequence is out of range ,then I print the value of the 'sequences',it turn out to be "[]"(nothing in it!).So what is the bug of it ?

https://github.com/WENGSYX/VPTSL/blob/main/main.py#L332

Hi! Can you check if the 'visual' list in VPTSL/main.py at main · WENGSYX/VPTSL (github.com) is empty? If it's empty, it indicates that the I3D video features were not successfully read. In that case, you should check if you've accurately entered the path to the I3D video features.

thank you ,I checked the path of the features data, and recorrect it . Now it works！


Issue 19/append suffix version model name

Fix issue with suffix name #19

@ivmarcos  Hi, could you merge this PR?

@ivmarcos  Hi, could you merge this PR?


Adding logic to pick API server urls

This pull request is meant to solve this issue
Currently, I have the servers sorted by two criteria:
If maturity is different, prefer production and then prefer staging
If maturity is the same, prefer https
I did a bit of testing with one of the example queries from the BioThings_Explorer_TRAPI repo and it seemed to work.

I would wait for discussion to finish on the original issue....
I haven't tested this yet, but I imagine this may not have the logic that I described in my recent posts...

This may require some reworking to make it TRAPI-specific. If you follow the build() method in SyncOperationationsBuilderWithReasoner, you should see the part where TRAPI operations are pulled in and parsed. I believe you want to add behavior this to parsePredicateEndpoint() rather than the general parser.
Additionally, as this package is used elsewhere, you should change the default behavior to assume a production environment -- we can explicitly provide the dev value to the dev server.

Hm, I see that the parsePredicateEndpoint is reading from predicates.json which only seems to have one server per operation, so any logic would have to be included wherever the predicates.json file is created

Ah, you're right! In this case, you're going to want to modify the update_local_smartapi cron job.

Closing this PR then, a new PR has been made for that cron job.


Common Initializers Does Not Work with Bias

It is expected that bias vector can be initialized not only with zeros but the following code fails.
import jax, jax.numpy as jnp
import flax.linen as nn

layer = nn.Conv(features=32,
                kernel_size=(3, 3),
                use_bias=True,
                bias_init=nn.initializers.lecun_normal())

jax.jit(layer.init)(jax.random.PRNGKey(42), jnp.empty((5, 28, 28, 1)))

# File jax/core.py:1969, in NamedShape.__getitem__(self, idx)
#    1967 try:
#    1968   idx = operator.index(idx)
# -> 1969   return self.__positional[idx]
#    1970 except TypeError:
#    1971   pass
#
# IndexError: tuple index out of range

It seems that the issues #1386 is related and maybe #2002 is related as well.

Assigning this to @zaxtax who is looking into improving our initializer documentaiton.

Thanks. It is not only about documentation. Is is about universality and interfacing of common initialize routines as well.

Yes you are right!

@daskol I agree! Part of making good documentation is writing code that's easy to explain :)

The problem is that all initializes that are implemented on top of variance_scaling (like lecun_normal) require the shape to have at least 2 dimensions, so you can't pass these to bias_init. This should be documented, also maybe we should improve the error message.

Agreed. Documentation should be updated.
From my perspective, variance_scaling initializer can be extrapolated on bias term. Bias term can be considered as a edge case of variance_scaling-based initializer.


Can't accept a 2d array

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 (latest version)
TensorFlow installed from (source or binary): PIP
TensorFlow version (use command below): 1.14
Python version: 3.7.4

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
When feeding the fully connected layer my last 2d rnn matrix even though the documentation says that it should be able to accept a 2d matrix
It should take a 2d matrix
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf

inputs = tf.placeholder(tf.int32, shape=(None, 750), name="inputs")
questions = tf.placeholder(tf.int32, shape=(None, 750), name="inputs")

gru_cell = tf.nn,rnn_cell.GRUCell(64) # Units= 64
output, (state_c, state_h) = gru_cell(inputs, questions)
# Both output & both states dimension is 2
logits = tf.contrib.layers.fully_connected(output, num_outputs=100, activation_fn=None) # vocab_size = 100
# We don't have to run the session since Tensorflow will check the tensors for the right shape

@mariusjohan, Please provide the complete standalone code to replicate the reported issue here. Thanks!

@gadagashwini Is that enough?

@mariusjohan, Please find the gist here and let us know the expected output. Thanks!

Sorry for taking so long, I've been really busy in school so I could not find any time. But here I am!
For some reason i could not run the gist, but i copy-pasted the code into my terminal and for some reason it worked there even with at 2d tensor.
Sorry for wasting your time :) But it doesnt work in own project for some reason. But i think i can solve it myself.


potential bug and a question

Thanks for the code. found it helpful in understanding the complexities of stock price prediction.
line #208 in base.env.market.py
  if date_index < self.bound_index:
      # Get y, y is not at date index, but plus 1. (Training Set)
      instruments_y = scaled_frame.iloc[date_index + 1]['close']
  else:
       # Get y, y is at date index. (Test Set)
       instruments_y = scaled_frame.iloc[date_index + 1]['close']

both the if and else conditions have the same code. should the else statement be
  instruments_y = scaled_frame.iloc[date_index]['close']
secondly, i had a question. how do i convert the scaled values back to the normal values after the predict function is called ? I would like to see the predicted price as a non scaled value ?
thanks and appreciate your effort.

ok. figured it out. it is not a bug. closing the issue


[$250] Android- Composer- Only haptic feedback but no paste menu when long tapping on the composer

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Break down in numbered stepsPrecondition:

User has copied any content on the device.

Launch New Expensify app.
Go to DM.
Long tap on the composer (do not make the keyboard appear).
Note that there is haptic feedback but no menu to paste when long tapping on the composer while keyboard is hidden.
Tap on the composer.
Dismiss keyboard by using device back navigation (device back button or swipe gesture to dismiss).
Long tap on the composer.
Note that now there is menu to paste.

Expected Result:
In Step 4, when the chat is opened for the first time, long tapping on the composer should bring up the menu to paste.
Actual Result:
In Step 4, when the chat is opened for the first time, there is no menu to paste when long tapping on the composer, and there is only haptic feedback.
In Step 8, the menu to paste only shows up after bringing up the keyboard and dismissing it.
Workaround:
Unknown
Platforms:

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/56cdf77d-cf91-4f16-906a-1a9b4c30a34e

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021846255346776510837
Upwork Job ID:<PHONE_NUMBER>776510837
Last Price Increase: 2024-11-05

The issue already happens in Production:
https://github.com/user-attachments/assets/39d99202-e87f-485b-b451-90093823a74c
Removing the DeployBlocker

Waiting for proposals.

Still no proposals.

Still no proposals.

I'm going to set the priority to weekly since it's LOW priority on the project board and nobody has submitted any proposals yet.

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)

Thank you @mvtglobally, I'm closing this as we cannot reproduce it anymore. Thank you for your help.

QA team can reproduce the issue in the latest build (9.0.79-0)
https://github.com/user-attachments/assets/fdd75d5e-285c-4617-b087-c6309295e914


Add plugins config and only show "Add" if "proposalParams" is set to …

@samuveth Can you resolve conflict then we can merge it

@bonustrack I need your approval so I can merge.


Unable to upload product images after product creation

I have created a product and want to add images to it, via /products//edit. The image gets uploaded, I get a "Remove" button for the image, but when I click on "Update product", the image is gone.

Oh, it was actually a fault in our setup, ImageMagick was missing and the config wanted to put the files into an S3 bucket. Sorry for being overly cautious ^^


Remove manager ofonly when exists

Remove manager only when instance exists

Thx for this PR.
:+1:


removed import * from the code

hey I changed the * in your code, import stuff was happening in a very convoluted way.
I didn't have access to your repo so that's why this pr

You've been invited as a collaborator on the repo.


Any way to get older expansions?

Specifically, I'm interested in coding for vanilla (1.12.1).
Not sure how hard that would be to add.
I see that the wiki entries contain "Game Flavors" and "Added in" fields. And there's vanilla wiki, too.

Unofficial game versions like 1.12.1 won't be supported, sorry
classic_era (1.14.3) would be be nice to support though


Efficient handling of special (co)limits in data migration

Ensure that important special cases, such as singleton diagrams and discrete diagrams, don't go through the general code pathways when computing limits and (co)limits of diagrams for data migration.

The most important cases, namely singleton and discrete diagrams, are handled by the above PR. (Co)span diagrams, leading to pullbacks/pushouts, should also be handled by the Specialize(Co)limit algorithms, but I'll leave that minor optimization for later.


HTML5 video caption control icon when clicked in tiny slider distorts/shifts/changes the slide.

Issue description:  In the demo link mentioned below tiny slider contains html5 video in each of its 4 slides. In chrome html5 video shows an additional icon(three vertical dots) with options (captions/download/picture-in-picture). On click of this icon instead of displaying the options the slides change or in other words the slider gets distorted.
When used in our project, previous and next arrows fail to function properly after clicking on this icon.
Demo link/slider setting:  https://codepen.io/kkaran-kumar/pen/ZEWMymX
Tiny-slider version:   2.9.2
Browser name && version:  Chrome Version 85.0.4183.102 (Official Build) (64-bit)
OS name && version:  Windows 10

Hello,
I have a similar issue. I have a slideshow with 3 slides and a slide contains an html5 video with custom controls. For each slide, on mobile wherever i click the slides change. How to avoid this ?
Thanks.
Tiny-slider version: 2.9.3
Android Chrome - Iphone chrome / safari

Hello,
I have a similar issue. I have a slideshow with 3 slides and a slide contains an html5 video with custom controls. For each slide, on mobile wherever i click the slides change. How to avoid this ?
Thanks.
Tiny-slider version: 2.9.3
Android Chrome - Iphone chrome / safari


The susceptance of the transformer conversion has to be negative

The reactance we calculate in the so called "no load experiment" is inductive as it relates to the coil of the transformer. Therefore the susceptance (its inverse) is negative by definition.

Since I had to remind myself 😂

Which is also what the ValidationUtils expect.


Can't decode values with colon in them

Encode works great. I like how the functions are called. These are exactly what I needed, so thank you.
I just wanted to bring your attention to one thing: a value with a colon, like <IP_ADDRESS>:11234 gets truncated to <IP_ADDRESS> on decode().
Here's the string I'm using to test with:
var configBencoded="d10:privateKey64:f81f88d85e52101237d5d009f9dd8f469322683b2fbe63511042a3abe718d82c19:authorizedPasswordsld8:password26:6lfwuz05nkw2u5unnxk4t637268:authTypei1e5:trusti5000eed8:password27:noa9fna09fnadf0afnavz08732n8:authTypei1e9:publicKey54:1femhkxsj5w35g2pufmc800dz7hkvfxtsc7y9lp37krnrrvdmmn3.k5:trusti5000eee5:admind4:bind15:<IP_ADDRESS>:11234e10:interfacesd12:UDPInterfaced4:bind13:<IP_ADDRESS>:311989:connectTod13:<IP_ADDRESS>:50570d8:password26:k3r20m3tq5c7xz5yfwv5tgdmm08:authTypei1e9:publicKey54:57tghkxsj5w35g2pufmc800dz7hkvfxtsc7y9lp37krnrrvdwrs0.k5:trusti10000ee13:<IP_ADDRESS>:71732d8:password22:someguy-nfnadfenfaidfn8:authTypei1e9:publicKey53:92ngtkxsj5w35g2pufmc800dz7hkvfxtsc7y9lp37krnrrv4pp9.k5:trusti8000eeeee6:routerd9:interfaced4:type12:TUNInterface9:tunDevice4:tun0ee27:resetAfterInactivitySecondsi30e8:securityl7:nofilesd7:setuser6:nobodyee7:versioni1ee";
var configObj=configBencoded.decode();
alert(configObj.interfaces.UDPInterface.bind); // Should show <IP_ADDRESS>:311989, but instead is <IP_ADDRESS>

I'm using this .js to decode instead:
http://jrex.mozdev.org/source/browse/ddpour/content/bencode.js

Cool, thanks for the heads up! I'll see what I can do!

Should be fixed, however, I noticed in your example, "<IP_ADDRESS>:311989" is 14 chars, not 13, so it would cut off the last digit.
Thanks for using my solution, please please let me know how it goes and if there are any more issues, I'd like to improve this.

Should be fixed, however, I noticed in your example, "<IP_ADDRESS>:311989" is 14 chars, not 13, so it would cut off the last digit.
Thanks for using my solution, please please let me know how it goes and if there are any more issues, I'd like to improve this.

Yeah, the value should be 31198 because 311989 is too big for a TCP port number. The following 9 is bencoding for the next value. Anyway, Just wanted to write to say I've confirmed your fix worked (damn, you're smart- I puzzled on how to fix it and gave up.) By the way, I'm using your library exclusively now for a CJDNS config editor.

Cool, I think I encode() might not be very efficient, with large size objects, so let me know if you run into a range error, stack size too deep.


Add ajv-spec benchmarks

This PR includes an additional ajv-spec benchmark. It is offered to provide a structural comparison between the schemas that are generated via TSON.application<[...], 'ajv'> (which are not working for several existing tests).
This benchmark uses the same schematics as the TypeBox benchmark but instead measures the Ajv compiler. The ajv-spec benchmark also uses the same spoiler data that was implemented for the TypeBox benchmark to ensure parity. All tests are currently passing (however these have only been implemented for the is benchmark)
This PR also updates the TypeBoxObjectUnionImplicit to use Type.Optional() over Type.Union([Type.Undefined(), ...]) to permit missing properties as per spoiler data.
Results below.

Linking draft implementation of TS > JSON Schema representation mapping on repl.it using the ObjectUnionImplicit test for reference.
Could be good to compare the TSON.application<...> output vs the output generated on this link, and just check what's different. You should be able to fork the repl and modify the type and interfaces for different generated schema outputs.
Wondering if specifically TSON.application<T, 'json-schema-draft-6'> could be possible (where the output is a limited subset of the draft-6 specification) (noting the differences between the swagger specification like nullable). Would be good to get good Ajv alignment in any case.
Hope this helps!

@samchon All good :)

Anyway, is it really okay that defining optional only instead of using undefined type?
As you know, TypeScript can assigned undefined value on the question marked property type like below.
With additionalProperties: false option, failure case could be happened.
interface ISomething {
    name: string;
    etc?: string;
}

const name: string = "unknown";
const etc: string = "another";
const something: ISomething = {
    name,
    etc: name === "unknown" ? undefined : etc,
};

is it really okay that defining optional only instead of using undefined type?

Yes, it's fine. TypeScript will treat prop?: string as prop: string | undefined. But the key difference is that Optional allows the property key to be missing.  As noted per https://github.com/samchon/typescript-json/pull/255#issuecomment-1287551099, see expanded description below
// -------------------------------------------------------------------
// { prop: undefined | null | number } means:
// - prop key MUST exist
// - prop value must be undefined | null | number

prop: Type.Union([Type.Undefined(), Type.Null(), Type.Number()])

{ prop: undefined } // ok
{ prop: null }      // ok
{ prop: 1 }         // ok
{ }                 // fail !!

// -------------------------------------------------------------------
// { prop?: null | number } means:
// - prop key can be OPTIONAL
// - prop value must be null | number (or undefined)

prop: Type.Optional(Type.Union([Type.Null(), Type.Number()]))

{ prop: undefined } // ok - see below for details.
{ prop: null }      // ok
{ prop: 1 }         // ok
{ }                 // ok

Note: The reason { prop: undefined } is ok in the second example is due to how JavaScript would test for undefined on that value. Consider.
const value = {}
if(value.prop === undefined) console.log('ok')

So to support missing properties, the correct way to express this is via Type.Optional(T) (which removes the key from the schemas required array). Also keep in mind that JSON Schema does not have a specification for undefined (only null). So if you're testing Ajv specifically, you will want to remove all Type.Undefined() and use Type.Optional() only.
Hope that helps.

Just on this...

With additionalProperties: false option, failure case could be happened.

The { additionalProperties: false } will be fine too as the schema still encodes for "known" properties. The additionalProperties check is usually dependent on the keys returned from Object.keys(schema.properties).
So for example.
// ------------------------------------------------------
// TypeBox
// ------------------------------------------------------

const T = Type.Object({
   prop: Type.Optional(Type.Union([Type.String(), Type.Null()])
   // ^  string | null | undefined
})

// ------------------------------------------------------
// JSON Schema
// ------------------------------------------------------

const T = {
  type: 'object',
  properties: {
    prop: { // <------ additionalProperties: false checks Object.keys(T.properties)
      anyOf: [
        { type: 'string' },
        { type: 'null' }
      ]
    }
  }
}

// ------------------------------------------------------
// additionalProperties: false test
// ------------------------------------------------------

const allowed = Object.keys(T.properties)

Object.keys({ prop: null }).every(key => allowed.includes(key)) // ok
Object.keys({ }).every(key => allowed.includes(key))            // ok
Object.keys({ foo: 1 }).every(key => allowed.includes(key))     // fail

Constrained schemas (such as the ones implemented in TSON) will likely need to control minimum required and excess properties checks through a combination of required and additionalProperties: false. These two properties essentially let you encode the rules for the current union specialization algorithm, but provides the flexibility to allow additional properties if necessary.
Again, hope this helps!

How about this case that defining undefined prop on non-declared property?
To anticipate below case, TSON.equals() function is even checking whether the excess property value is undefined or not.
I've implemented such logic because following JS rule, undefined valued property and real undefined property is equivalent.
When undefined value comes
{
    x: 1,
    y: 1,
    z: 1,
    excess: undefined,
}

TypeBox
return function check(value) {
  return (
    (typeof value === 'object' && value !== null && !Array.isArray(value)) &&
    (Object.keys(value).length === 3) &&
    (typeof value.x === 'number') &&
    (typeof value.y === 'number') &&
    (typeof value.z === 'number')
 )
}

TSON
(input, path, exceptionable) =>
    "number" === typeof input.x &&
    "number" === typeof input.y &&
    "number" === typeof input.z &&
    Object.entries(input).every(([key, value]) => {
        if (undefined === value) return true;
        if (["x", "y", "z"].some((prop) => key === prop))
            return true;
        return false;
    }),

JSON Schema requires you to be explicit about allowing (or disallowing) additionalProperties. The default is to allow them.
const T = Type.Object({
  x: Type.Number(),
  y: Type.Number(),
  z: Type.Number()
})

{ x: 1, y, 2, z: 3 }                    // ok
{ x: 1, y, 2, z: 3, excess: undefined } // ok

const T = Type.Object({
  x: Type.Number(),
  y: Type.Number(),
  z: Type.Number()
}. { additionalProperties: false })

{ x: 1, y, 2, z: 3 }                    // ok
{ x: 1, y, 2, z: 3, excess: undefined } // fail

I mean that the additionalProperties: false should not consider undefined value as superfluous property.
You suggested that additionalProperties: false can be a good solution for validating implicit union type like ObjectUnionImplicit type, but such undefined superfluous property can break integrity of TypeBox. When collaborating many other web developers, I've seen lots of people overusing the undefined when creating union typed object and it's the reason why not blocking the undefined value.

https://github.com/samchon/typescript-json/issues/197

I mean that the additionalProperties: false should not consider undefined value as superfluous property.

Sure, but it's not superfluous because a property with an undefined value still yields a key (which would be an unexpected key/value if additionalProperties:false was enabled)
Object.keys({ x: 1, y: undefined }) // ['x', 'y'] - 'y' is unexpected

I've seen lots of people overusing the undefined when creating union typed object and it's the reason why not blocking the undefined value.

Undefined in JavaScript is a little ambiguous, as it could mean "the key does not exist" or "the key exists but it's value is undefined". I expect this is another reason why JSON schema doesn't have a specification for undefined values.
const A = {}
const B = { prop: undefined }

if(A.prop === undefined) console.log('ok')
if(B.prop === undefined) console.log('also ok')

// ^ as a user, you wouldn't know by running this test that `A` had a missing `prop` key. The user would
// need to explicitly call `Object.keys(A | B)` to determine if the property actually existed. This is a problem
// if there is dependent logic based on the property keys. The JSON Schema specification provides
// assurances here, but it does so by way of NOT having a specification for undefined.

Overall, I do think it's important to have a distinction between {} and { prop: undefined } for validation purposes. So, I tend to agree with the JSON Schema specification here (there's been very few cases where JSON Schema hasn't been able to express the semantics of TS types, even if the schema can be quite verbose)

Within framework of JSON schema, your policy seems right. How to handle undefined property, it would be just a difference between our libraries. Thanks for detailed description.


setup prepush to run compile

Changelog

Add compile command in pre-push git hook
Add --write in prettier command in pre-commit

Closes #56

Coverage remained the same at 100.0% when pulling aef2e1147f92fb0e53751341452595bd30be94e4 on compile-prepush into a5f367ae09bfb5766d84117e29266b45c8ed6fa4 on master.


⚠ API - Lens has degraded performance

In 459e18f, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 582 ms

Resolved: API - Lens performance has improved in 436bad3 after 8 minutes.


TPT 0-300

I finished looking over these changes today. These changes catch a few things that pidgin's fork didn't get to yet.

Added a few more new labels: pickypoint, hisher, kidkids, adultetc. All the text that uses them is edited to use them in the translation too.
Changed lots of whitespace to match the 144-pixel textbox this hack uses.
Ported a bunch of references that got skipped somehow, including the Onett and Twoson newspapers.
Fixed some typos, some of which existed in the EB text.
Changed some dialogue that uses party leader in M12 to match EB text and display Ness's name every time. This could be edited back if that's a better idea though. (Looking now, I only see two examples, L4013 and L2443.)
Added a version of @MalBound's hint newspaper "controller" and "TV" replacement text 'cause it was in these labels. (I said "game system" explicitly because the Japanese text doesn't even mention controllers, it just outright said whoever was playing the game.)

Besides the last two bullet points possibly needing edits, this is ready to merge.

I was looking over these labels and realized that the Stonehenge text I changed was broken in the original game. I'll work on a fix (and maybe squash all these commits so everything's a little less messy).

I think the conflict is due to how the changes got applied in pidgin's fork. I'll see if I can resolve it.

The conflicts are pretty complicated and I don't think I can fix it anytime soon :\ Do you think you could take a look at it?

Looks like all the line endings got changed around somewhere...I'll change my file to Unix style endings and see if it's easier to resolve.

It took some StackOverflow searching, but I think I got it to not completely break. I'll spend some time fixing the conflicts today and tomorrow.

Okay, ready for merge now.


Add support for months changes events

Coverage decreased (-0.4%) to 54.331% when pulling cfa6ab4f4e2e99fd2301c03871490c2956c09894 on aliazizi:master into 9dc8db5d92c27b2be0b9ef32f5b3578383e4a9ea on mberneti:master.


Move build / rebuild to Github Actions

Due to future deprecation of Jenkins, build and rebuild actions should be moved to Github Actions.

https://github.com/zooniverse/front-end-monorepo/pull/2531 has a deploy workflow that should be easy to adapt here.

Deploy via GH Actions is working now. Do we want to turn off Jenkins (and the associated Lita command?)

@eatyourgreens (cc @camallen) -- Great!  Wonderful to have this deploy off of Jenkins.  For the Lita command, however: this is what Sam needs to use to rebuild the index (when project teams update subject sets + workflows) and I don't believe she has the repo access to trigger the GH Action.
Is it possible to edit the Lita command to trigger the GH Action?  That is a high priority to get enabled, so non-devs have access to trigger that action.  I opened a new issue on the Lita repo: https://github.com/zooniverse/lita/issues/138

I think there would be a substantial security risk there: allowing Lita to run private GH API calls.


As a keptn core contributor, I get notified if either the setup or the main use cases don't work

Implement automated verification of the keptn installation and the main use cases, so core contributors are notified if a recent broke either one of those two.
Acceptance criteria

Given I'm a keptn developer
When I push a change that breaks the setup of keptn
Then I want to be notified that my change broke the keptn setup in a timely manner
Given I'm a kept developer
When I push a change that breaks one of the main use cases
Then I want to be notified that my change broke one of the main use cases in a timely manner

Fixed with #206 and #337


How can I use the getQueryStringFromState function?

Hello,
I want to use the https://community.algolia.com/algoliasearch-helper-js/reference.html#algoliasearchHelper.module:url.getQueryStringFromState function but I keep getting the message that this function doesn't exist.
I'm using it in the render function of a widget and when I console.log the args passed in the render function I can't find the url module in the helper data.
What am I doing wrong?
I'm trying to build a extension that handles the <link rel="next" and rel="prev" in the  but to do that I need to get the query string - so I can get the right url for the next pages with their filters. Im using instantsearch.js 1.10.3
Tried to add this to discourse.algolia.com but I keep getting 403 error.

Hi @Maaark thanks for reporting this issue.
The url module of the JS Helper is not available on the Helper instance. Since the helper as a module is not accessible either, I doubt you'll be able to get the function you want. We could expose this package with instantsearch, maybe. Any thoughts on that @vvo ?
Can you tell us more about what you're trying to build?

Can you tell us more about what you're trying to build?

Yep we need this also to understand more deeply the use case.

We could expose this package with instantsearch, maybe. Any thoughts on that @vvo ?

Yes this could be exposed on the instantsearch module or just on the helper instance (search.helper...)

@vvo You helped me to build a custom pagination module that works with a 'show more' button.  So when you click this button you will get the second page appended to the first page.
After this click there is a query string appended to the current url, but I need to get the query string for the current url so I can use it for my function to build the link rel="prev/next" elements (https://support.google.com/webmasters/answer/1663744?hl=en)

@Maaark Can you create a small jsFiddle describing where you are so far and what is the missing piece? An example load more demo with then a small comment saying "Here I would want to display/get .."
Thanks

Closing this issue for now.


Clone/Copy NetPacketReader

I see that all clients use the same NetPacketReader, how can I make each client have its own NetPacketReader?
Or you can copy NetPacketReader to use at the desired time.
Thanks

@vanhaodev they don't use same reader. There is new (or from cache) reader for each message. If you turn off AutoRecycle - they won't be recycled until you call .Recycle on them


SassFilter --debug-info flag references temp file, not originating sass file

There appears to be an issue with various sass to css file mapping tools such as Fire Compass in Firefox. It is referencing a temp file instead of the originating sass file. Below you can see the section of code I'm referencing.
https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Filter/Sass/SassFilter.php#L163
...
$pb->add($input = tempnam(sys_get_temp_dir(), 'assetic_sass'));
file_put_contents($input, $asset->getContent());

And this is a snippet of the debug info that is output in the css.
...
@media -sass-debug-info {
filename {
    font-family: file:///tmp/assetic_sassIvzIp9;
}

This appears to be because the sass file is copied to a temp file, then compiled off that.
Is this by design?

Same problem in CompassFilter. The temp filename is split off his last letter.


[bin/fontbakery-fix-dsig] Use really empty DSIG as a dummy. Closes #1437

This pull request addresses the problems described at issue #1437
I also added a --force and --delete switch to the command.
Just created a DSIG with this that looks like:
  <DSIG>
    <!-- note that the Digital Signature will be invalid after recompilation! -->
    <tableHeader flag="0x0" numSigs="0" version="1"/>
  </DSIG>

I was just cleaning up my git stash and found this lying around. Before we merge, in the issue @HinTak writes:

However, you probably want to check that this works for the undocumented use of it in directwrite ...

So, what are these applications that need a (dummy) DSIG to be present and who can test this?

MS word, I believe. I think Windows explorer also uses it to show an OT
logo instead of a TT logo.
On Jul 25, 2017 10:26 AM, "Lasse Fister"<EMAIL_ADDRESS>wrote:
I was just cleaning up my git stash and found this lying around. Before we
merge, in the issue @HinTak https://github.com/hintak writes:
However, you probably want to check that this works for the undocumented
use of it in directwrite ...
So, what are these applications that need a (dummy) DSIG to be present and
who can test this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/googlefonts/fontbakery/pull/1458#issuecomment-317754799,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP9y7RGTU6k8lMZObiJ2S9UODLqOzKRks5sRfskgaJpZM4OioQ0
.

Thanks, Lasse and Dave!
This is the kind of info that we should be gathering so that the rationale behind each test is more objective rather than keeping statements like "some programs need this for some reason".
I can see that this tool works as intended, that's not a problem.
But does it actually address the hypothetical issue that brought us to implement it?
All I gather from the comments above is that there is some problem with unspecified versions of MS Word and Windows Explorer that results in some unclear misbehaviour. Who could clarify and test that for us ?

If you are motivated to provide the clear rationale for the DSIG test, you
can license a copy of Windows and MS Word and test it.
I don't care to ;)

But does it actually address the hypothetical issue that brought us to implement it?
All I gather from the comments above is that there is some problem with unspecified versions of MS Word and Windows Explorer that results in some unclear misbehaviour. Who could clarify and test that for us ?

That's the question. I can try with a recent MS-Word and Win-7

For why it is needed at all, you'll have to ask Microsoft folks (and good luck getting any answers...). OTOH, your old dummy dsig was malformed, as it claims to have one signature block but is truncated at the beginning of the said signature block. The change is to have a well-formed dsig table with zero/no signature block. It is smaller and well-formed, at least.

Thanks Hin-Tak!

yeah. It makes sense! Thanks, Hin-Tak :-)
I'm not that much enthusiastic to figure this out as far as to license a copy of Windows and Office! LOL
But I feel bad to lack the precise info.

On the other hand, at some point in the past someone certainly complained about some program misbehaving and that lead us to write this test/fixer. We must take notes in those kinds of situations, so that we at least know the precise requirements and rationale behind our tools development :-)


Update side-menu.js

@jogibear9988 I'm not able to start the demo locally anymore. I guess this is caused by the bump of the lit-element version.
If you want to you can exclude that for now from this PR and I'll update the version of all dependencies this weekend


Extract value only if the map key exists in PropertyOrFieldSupport

Check List:

Fixes #2111
Unit tests : YES
Javadoc with a code example (on API only) : NA

@joel-costigliola raising it as a draft just to sync on the strategy. If we like the approach, I'll use the opportunity for some additional BDD refactoring in the test classes.


Add support for pause/resume

this function will not break the previous APIs.
Pause/Resume function is useful for:

Download/Upload progress
Timer & Countdown
Audio & Video progress bar
...

Well, it seems that the travis-ci test failed because of issues that are not related to this pr.

Thanks for the contribution. This looks like a good addition, could you add a test case for this also?
Tests should work locally. Unfortunately the CI tests are broken at the moment as we test against real browsers. That requires quite regular maintenance.

@kimmobrunfeldt Test case added, and it passed on my PC:
---- Linting code..

><EMAIL_ADDRESS>lint /Users/jiejiss/Work/Code/js/progressbar.js
> ./tools/lint.sh

><EMAIL_ADDRESS>jscs /Users/jiejiss/Work/Code/js/progressbar.js
> jscs ./src ./test

><EMAIL_ADDRESS>eslint /Users/jiejiss/Work/Code/js/progressbar.js
> eslint --ext .js ./src ./test

---- Running tests..

Running "shell:testem" (shell) task

  .............................................................
  ........

  69 tests complete (15691 ms)

Done, without errors.

Thank you!

Delay option is now available in the latest version.


feat(utils): deprecate proxyWithComputed

Ref: https://github.com/pmndrs/valtio/pull/647#discussion_r1096397705

Merging this.
@stephenh Please feel free to help improving the docs: wording, examples, etc.

@dai-shi cool! I'll working on rebasing my docs PR on top of this. Thanks!


Add explanation of vaccination statistic terms to the app

Current Implementation
The CWA includes the following statistics, among others, on vaccination:

"People Who Have Received at Least One Vaccine Dose" ("Mindestens eimal geimpfte Personen")
"People Who Have Basic Immunization" ("Grundimmunisiert")
"People Who Have Received a Booster Vaccination" ("Personen mit Auffrischimpfung")

The used terms are nowhere defined in the app. For example, the user can't tell if "People Who Have Basic Immunization" includes all people who have received two shots or three.
Suggested Enhancement
Add the definitions of these terms to the apps statistics information screen. The terms are defined by STIKO, the definition is for example available in this document: https://www.rki.de/DE/Content/Infekt/EpidBull/Archiv/2022/Ausgaben/40_22.pdf?__blob=publicationFile.
Expected Benefits
The user finds explanation on relevant statistics directly in the app.
Additional information

I'm opening this issue based on feedback I received via Twitter, however, I also support this request. Here's the link to Twitter: https://twitter.com/longvaccvoyager/status/1583480974985158658?s=20
This is a follow-up to https://github.com/corona-warn-app/cwa-documentation/issues/922

Internal Tracking ID: EXPOSUREAPP-14221

Good morning @Ein-Tim, thanks for the suggestion. Internal Tracking ID: EXPOSUREAPP-14221

Assuming that the immunization data displayed in the CWA statistics tiles has the same source as https://github.com/robert-koch-institut/COVID-19-Impfungen_in_Deutschland then the exact definitions are on https://github.com/robert-koch-institut/COVID-19-Impfungen_in_Deutschland#erklärung-zum-merkmal-impfstatus.

As the CWA project went into ramp-down mode, I don't expect to see any bigger features implemented. I'm therefore closing this issue.


[experimental-unionfs] 0.5.0_8544ac2 can't install FreeBSD

hello-0.5.0_8544ac2e98c21d3c398f33f7829e62cc60cfacc7-FreeBSD-12.2-amd64.iso
In the installer, a click on the Continue button is followed by closure of the application.
Home-built VirtualBox 6.1.8 host, 2 GB memory given to the guest.

Thanks for reporting. First we need to get the unionfs based version to boot (apparently it did that for you!) before we change the installer to support installing the unionfs based version.

Without having looked into this yet, I suspect that the current issue is that it tries to copy from the location where the ZFS got mounted, and probably this mount point has changed in the experimental-unionfs branch.
Regarding where we install to, this is an excellent question. I would be in favor of "installing" by just copying the whole compressed filesystem somewhere, and leave it as an immutable single file, but the feasibility of this approach largely depends on how well the unionfs approach turns out to work, so nothing is decided yet.

got same problem.
work with less them 4 GB Ram in Virtualbox
hello-0.5.0_8544ac2e98c21d3c398f33f7829e62cc60cfacc7-FreeBSD-12.2-amd64.iso work for boot with virtualbox for me but not install "GUI/CLI" both crash virtualbox.
freebsd install failed to mount filesystem then try to install. CLI bsdinstall failed then mount /mnt .

This version cannot be installed because the installer has not been updated to support the experimental-unionfs branch. Firt priority is to get the experimental-unionfs branch to boot at all into the desktop on Intel GPU machines. Only if we can make this work, then it makes sense to work on the installer.

so no "VM" iso version only? for testing of apps on VM's

I don't understand your comment @KDGNOR

I don't understand your comment @KDGNOR

I edit my old comment.

The unionfs based version was a test and is no longer developed at the moment.
I never got it to work 100% properly


Incorrect mutex example

The mutex example compiles but run incorrectly in my computer. I did some fixup and it works.
impl<T> Drop for MutexGuard<'_, T> {
    fn drop(&mut self) {
        self.0.locked.store(false, Ordering::Release);
        self.0.lock_ops.notify(1);
    }
}

You're right :) I have added the Drop impl for MutexGuard to the example. Thanks!