Memory leak when open 10+ rtsp video

Describe the bug
I have 100+ rtsp source.
I will show 9 rtsp videos on WPF UI once.
When after 5 seconds will show next  9 rtsp videos on WPF UI.
Repeat the above steps.
When after 30min, Memory leak.
I see memory in Windows TaskManager ,It's going up.
I use memory tools see : the unmanaged memory is going up.
Whenn stop the all rtsp videos, The unmanaged memory is not release.
Screenshots

Desktop (please complete the following information):
Windows 10 OS
This is my stop every video code:
_rawFramesSource.Stop();
_realtimeVideoSource.SetRawFramesSource(null);
_rawFramesSource = null;
i think i cant release all memory use this code.
can you help me?

@BogdanovKirill   can you help me.

And some more info:
When start them WPF Demo.
The init unmanaged memory is  66MB
#1 Open one rtsp video:
unmanaged memory is  138MB
#2 Close video:
unmanaged memory is 77MB
#3 After 5 min, Open one rtsp video:
unmanaged memory is 187MB
#4 Close video:
unmanaged memory is 91MB
Open once the unmanaged memory going up,
And then will going up to more an more.
Memory leak.

Hello,
If I understand correctly your problem is connected only with code responsible for display only?
Can you see this problem if only frame receiving + frame decoding are enabled (without display)?

And please don't forget to call Dispose for RealtimeVideoSource before _rawFramesSource = null;

Any news?

I'm sorry for not giving you timely feedback on the problem.
Thanks for your replay.  I'm currently working on other bugs in the system.
I'm not sure yet this problem is lead by FFMPEG decode.
I will try only frame receiving + frame decoding are enabled (without display) to research this problem.
If get any more info ,i will tell you.
Very thanks for you.

Any news or we could close that ?

Please reopen if you will find exact problem

Hi @BogdanovKirill
I am also wondering about this memory leak issue.  I am using the decoding github project "rtspcapture - working" which gives me the SnapshotMaker example. I changed it to a Winforms project so I could stream to a picture box, and then take a snapshot, and put it in another picture box.
I commented out the ToImage() function so I took out all displaying of Images in my picture boxes. The memory seems more stable.
My memory spikes up when taking shapshots, even though I am clearing my Picture Boxes.
As I take more snapshots, the memory climbs higher.
It never come down, even when calling the GC explicitly.
I am not sure how to clean up ?  Can you help?
(This code comes from my crude test program)
    private void OnFrameReceived(object sender, RawFrame rawFrame)
    {
        if (!(rawFrame is RawVideoFrame rawVideoFrame))
            return;

        FFmpegVideoDecoder decoder = GetDecoderForFrame(rawVideoFrame);
        if (!decoder.TryDecode(rawVideoFrame, out DecodedVideoFrameParameters decodedFrameParameters))
            return;

        int bufferSize;

        bufferSize = decodedFrameParameters.Height *
                     ImageUtils.GetStride(decodedFrameParameters.Width, RawFramesDecoding.PixelFormat.Abgr32);

        if (_decodedFrameBuffer.Length != bufferSize)
            _decodedFrameBuffer = new byte[bufferSize];

        var bufferSegment = new ArraySegment<byte>(_decodedFrameBuffer);

        var postVideoDecodingParameters = new PostVideoDecodingParameters(RectangleF.Empty,
            new Size(decodedFrameParameters.Width, decodedFrameParameters.Height),
            ScalingPolicy.Stretch, RawFramesDecoding.PixelFormat.Bgr24, ScalingQuality.Bicubic);

        IDecodedVideoFrame decodedFrame = decoder.GetDecodedFrame(bufferSegment, postVideoDecodingParameters);

        //ArraySegment<byte> frameSegment = decodedFrame.DecodedBytes;
        //string snapshotName = decodedFrame.Timestamp.ToString("O").Replace(":", "_") + ".jpg";

        //ToImage(decodedFrameParameters.Width, decodedFrameParameters.Height, snapshotName, System.Drawing.Imaging.PixelFormat.Format24bppRgb, frameSegment.Array);

    }

    private void ToImage(int Width, int Height, string imgName, System.Drawing.Imaging.PixelFormat pixelFormat, byte[] rgbValues)
    {
        Bitmap bitMap = new Bitmap(Width, Height, pixelFormat);

        Rectangle BoundsRect = new Rectangle(0, 0, Width, Height);

        BitmapData bitmapData = bitMap.LockBits(BoundsRect, ImageLockMode.WriteOnly, bitMap.PixelFormat);

        IntPtr _dataPointer = bitmapData.Scan0;

        int _byteData = bitmapData.Stride * bitMap.Height;

        System.Runtime.InteropServices.Marshal.Copy(rgbValues, 0, _dataPointer, _byteData);

        bitMap.UnlockBits(bitmapData);

        if (pictureBox1.Image != null)
        {
            pictureBox1.Image.Dispose();
            pictureBox1.Image = null;
        }

        pictureBox1.Image = bitMap;
        pictureBox1.Refresh();

        if (MustTakeSnapshot)
        {
            Thread t = new Thread(new ParameterizedThreadStart(TakeSnapshot));
            t.Start(bitMap);
        }
    }

    private void TakeSnapshot(object bitMap)
    {

        Bitmap b = (Bitmap)bitMap;

        ImageCodecInfo jgpEncoder = GetEncoder(ImageFormat.Jpeg);

        System.Drawing.Imaging.Encoder encoder = System.Drawing.Imaging.Encoder.Quality;

        EncoderParameters encoderParams = new EncoderParameters(1);

        EncoderParameter myEncoderParameter = new EncoderParameter(encoder, 50L);

        encoderParams.Param[0] = myEncoderParameter;

        string filename = @"c:\capture\frame" + DateTime.Now.Millisecond.ToString();
        b.Save(filename, jgpEncoder, encoderParams);

        if (pictureBox2.Image != null)
        {
            pictureBox2.Image.Dispose();
            pictureBox2.Image = null;
        }

        pictureBox2.Image = Image.FromFile(filename);

        b.Dispose();
        b = null;
        bitMap = null;

        MustTakeSnapshot = false;
    }


Updated README and added button background color property

Updated README for #22
Fixed #4 and #40

Merged. Looks great.
I have renamed from CustomizableButtons to CustomizableButton.
I have made the backgroundColor optional, so that UITableViewCell uses its default colors, if no background color is provided.
Thank you @Pizzo15.

@neoneye Yeah I was unsure about that backgroundColor default value.
I'll check to see if I find other open issues to work on.

Much appreciated. Thanks.


ci(cd): remove "dry-run" from semantic releases to perform release

Update the release.yml github action to perform the release (instead of just being a dry-run)

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Title: Release server sends application/json MIME type for package downloads

Steps to reproduce:

Visit https://code.headmelted.com/#linux-header-manual
Click link for "code-oss_1.8.0-2016112710_amd64.deb" download

Expected results:
I'm prompted to install deb with the "Software Install" app
Actual results:
Server sends package with application/json MIME type, so I'm prompted to open
with gedit, instead.
Additional details:
Clicking on the other links (e.g., RPMs) gives the same results.
Also, minor nitpick: the arch lists for the debs and RPMs are listed in a
different order.

I'll get a look at the package ordering and change it so that the both formats are the same.
Insofar as the MIME headers go, the hosting is done by bintray, and you may have picked up on something they aren't yet aware of here.

I've switched recently from Bintray to packagecloud for hosting the packages.  As a result the link now points directly to packagecloud's repository for the built packages, so is no longer held on the code.headmelted.com page.


{{ stated_legaldefense }}

set to blank?
Need to resolve

should always be included - no matter whether they have filed an answer or not - judge may or may not read answer so it is a good idea to always include a short description.
No conditional around state_legaldefense


Crash on pressing settings button

Ios 15.7.3 (Palera1n)

Send a crash log

Cr4shed app doesn't show me a crash log. How can I give it to you?

{"app_name":"Antoine","timestamp":"2023-03-02 12:05:25.00 +0100","app_version":"1.1","slice_uuid":"9c8d59e5-3c99-335c-ac67-ac962ef3f079","build_version":"1","platform":2,"bundleID":"com.serena.Antoine","share_with_app_devs":0,"is_first_party":1,"bug_type":"309","os_version":"iPhone OS 15.7.3 (19H307)","incident_id":"4AA4884D-6A8F-4D89-9BDC-2FF3950B4F71","name":"Antoine"}
{
"uptime" : 160000,
"procLaunch" : "2023-03-02 12:05:12.3024 +0100",
"procRole" : "Foreground",
"version" : 2,
"userID" : 501,
"deployVersion" : 210,
"modelCode" : "iPhone9,4",
"procStartAbsTime" :<PHONE_NUMBER>060,
"coalitionID" : 1845,
"osVersion" : {
"isEmbedded" : true,
"train" : "iPhone OS 15.7.3",
"releaseType" : "User",
"build" : "19H307"
},
"captureTime" : "2023-03-02 12:05:25.4888 +0100",
"incident" : "4AA4884D-6A8F-4D89-9BDC-2FF3950B4F71",
"bug_type" : "309",
"pid" : 46671,
"procExitAbsTime" :<PHONE_NUMBER>491,
"cpuType" : "ARM-64",
"procName" : "Antoine",
"procPath" : "/Applications/Antoine.app/Antoine",
"bundleInfo" : {"CFBundleShortVersionString":"1.1","CFBundleVersion":"1","CFBundleIdentifier":"com.serena.Antoine"},
"storeInfo" : {"deviceIdentifierForVendor":"D471B2BD-51ED-4FD5-97E9-DC88A7F740BE"},
"parentProc" : "launchd",
"parentPid" : 1,
"coalitionName" : "com.serena.Antoine",
"crashReporterKey" : "6d359202792efcc9ce6c0eba77708269693ebb50",
"basebandVersion" : "6.03.01",
"vmRegionInfo" : "0 is not in any region.  Bytes before following region:<PHONE_NUMBER>\n      REGION TYPE                 START - END      [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL\n      UNUSED SPACE AT START\n--->  \n      __TEXT                   104584000-10461c000 [  608K] r-x/r-x SM=COW  ...e.app/Antoine",
"isCorpse" : 1,
"exception" : {"codes":"0x0000000000000001, 0x0000000000000000","rawCodes":[1,0],"type":"EXC_BAD_ACCESS","signal":"SIGSEGV","subtype":"KERN_INVALID_ADDRESS at 0x0000000000000000"},
"termination" : {"flags":0,"code":11,"namespace":"SIGNAL","indicator":"Segmentation fault: 11","byProc":"exc handler","byPid":46671},
"vmregioninfo" : "0 is not in any region.  Bytes before following region:<PHONE_NUMBER>\n      REGION TYPE                 START - END      [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL\n      UNUSED SPACE AT START\n--->  \n      __TEXT                   104584000-10461c000 [  608K] r-x/r-x SM=COW  ...e.app/Antoine",
"faultingThread" : 0,
"threads" : [{"triggered":true,"id":1298158,"threadState":{"x":[{"value":0},{"value":2929},{"value":0},{"value":4373628634},{"value":42},{"value":4294967344},{"value":0},{"value":1},{"value":0},{"value":5456509739251728561},{"value":72057598332895232},{"value":144115188344293088},{"value":705465472371658756},{"value":0},{"value":2199023325184},{"value":4294967296},{"value":7990704160,"symbolLocation":0,"symbol":"_platform_memmove"},{"value":0},{"value":0},{"value":4373418992},{"value":10756209280},{"value":4373419476},{"value":0},{"value":1},{"value":0},{"value":8515189384,"symbolLocation":0,"symbol":"__kCFNull"},{"value":0},{"value":0},{"value":0}],"flavor":"ARM_THREAD_STATE64","lr":{"value":6619335448},"cpsr":{"value":1610612736},"fp":{"value":6099004432},"sp":{"value":6099003680},"esr":{"value":2181038086,"description":"(Instruction Abort) Translation fault"},"pc":{"value":0},"far":{"value":0}},"queue":"com.apple.main-thread","frames":[{"imageOffset":0,"imageIndex":0},{"imageOffset":1875628,"symbol":"CI::GLContext::GLContext(CI::GLContext::ShareContextInfo, CGColorSpace*, CGColorSpace*, CI::PixelFormat, bool, unsigned long, bool, bool)","symbolLocation":496,"imageIndex":1},{"imageOffset":1875704,"symbol":"CI::GLContext::GLContext(CI::GLContext::ShareContextInfo, CGColorSpace*, CGColorSpace*, CI::PixelFormat, bool, unsigned long, bool, bool)","symbolLocation":24,"imageIndex":1},{"imageOffset":329488,"symbol":"+[CIContext(Internal) internalContextWithEAGLContext:options:]","symbolLocation":628,"imageIndex":1},{"imageOffset":33604,"symbol":"-[CIContext initWithOptions:]","symbolLocation":596,"imageIndex":1},{"imageOffset":32996,"symbol":"+[CIContext contextWithOptions:]","symbolLocation":44,"imageIndex":1},{"imageOffset":528168,"symbol":"__38+[CUIShapeEffectStack sharedCIContext]_block_invoke","symbolLocation":56,"imageIndex":2},{"imageOffset":409748,"symbol":"_dispatch_client_callout","symbolLocation":16,"imageIndex":3},{"imageOffset":23244,"symbol":"_dispatch_once_callout","symbolLocation":28,"imageIndex":3},{"imageOffset":528108,"symbol":"+[CUIShapeEffectStack sharedCIContext]","symbolLocation":60,"imageIndex":2},{"imageOffset":579524,"symbol":"-[CUICatalog imageByStylingImage:stylePresetName:styleConfiguration:foregroundColor:scale:]","symbolLocation":76,"imageIndex":2},{"imageOffset":11718748,"symbol":"-[UIImage _imageWithStylePresets:tintColor:traitCollection:]","symbolLocation":636,"imageIndex":4},{"imageOffset":18480252,"symbol":"-[UIImageView _renditionForSource:size:symbolConfiguration:withCGImageProvider:lazy:]","symbolLocation":1092,"imageIndex":4},{"imageOffset":18476152,"symbol":"-[_UIImageContentLayoutWeakEffect _renditionForSource:size:symbolConfiguration:withCGImageProvider:lazy:]","symbolLocation":140,"imageIndex":4},{"imageOffset":1590876,"symbol":"-[_UIImageContentContextualEffect _renditionWithCGImageProvider:size:lazy:]","symbolLocation":44,"imageIndex":4},{"imageOffset":5293644,"symbol":"-[_UIImageContent renditionWithSize:scale:applyingEffect:]","symbolLocation":820,"imageIndex":4},{"imageOffset":6381752,"symbol":"-[_UIImageContent renditionApplyingEffect:]","symbolLocation":112,"imageIndex":4},{"imageOffset":5832800,"symbol":"-[_UIImageCGImageContent renditionApplyingEffect:]","symbolLocation":48,"imageIndex":4},{"imageOffset":1562116,"symbol":"-[_UIImageContentLayout _materializeContentsIfNeeded]","symbolLocation":72,"imageIndex":4},{"imageOffset":3166144,"symbol":"-[_UIImageContentLayout contents]","symbolLocation":20,"imageIndex":4},{"imageOffset":2034724,"symbol":"-[UIImageView _setImageViewContents:]","symbolLocation":1040,"imageIndex":4},{"imageOffset":2252676,"symbol":"-[UIImageView _updateState]","symbolLocation":612,"imageIndex":4},{"imageOffset":1454788,"symbol":"+[UIView(Animation) performWithoutAnimation:]","symbolLocation":96,"imageIndex":4},{"imageOffset":1740924,"symbol":"-[UIImageView _updateImageViewForOldImage:newImage:]","symbolLocation":660,"imageIndex":4},{"imageOffset":1458176,"symbol":"-[UIImageView setImage:]","symbolLocation":468,"imageIndex":4},{"imageOffset":2033304,"symbol":"-[UIImageView initWithImage:]","symbolLocation":272,"imageIndex":4},{"imageOffset":5930836,"symbol":"-[UISwitchModernVisualElement _invalidateOnOffImages]","symbolLocation":164,"imageIndex":4},{"imageOffset":5837708,"symbol":"-[UISwitch refreshVisualElementForTraitCollection:populatingAPIProperties:]","symbolLocation":604,"imageIndex":4},{"imageOffset":3611144,"symbol":"UISwitchCommonInit","symbolLocation":308,"imageIndex":4},{"imageOffset":3268472,"symbol":"-[UISwitch initWithFrame:]","symbolLocation":52,"imageIndex":4},{"imageOffset":264908,"symbol":"PreferencesViewController.tableView(:cellForRowAt:)","symbolLocation":1996,"imageIndex":5},{"imageOffset":267468,"symbol":"@objc PreferencesViewController.tableView(:cellForRowAt:)","symbolLocation":156,"imageIndex":5},{"imageOffset":2555868,"symbol":"-[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:]","symbolLocation":1624,"imageIndex":4},{"imageOffset":4565068,"symbol":"-[UITableView _updateVisibleCellsForRanges:createIfNecessary:]","symbolLocation":700,"imageIndex":4},{"imageOffset":2703096,"symbol":"-[UITableView _updateVisibleCellsNow:]","symbolLocation":1464,"imageIndex":4},{"imageOffset":1492088,"symbol":"-[UITableView layoutSubviews]","symbolLocation":436,"imageIndex":4},{"imageOffset":1556932,"symbol":"-[UIView(CALayerDelegate) layoutSublayersOfLayer:]","symbolLocation":2556,"imageIndex":4},{"imageOffset":251168,"symbol":"CA::Layer::layout_if_needed(CA::Transaction*)","symbolLocation":528,"imageIndex":6},{"imageOffset":1956004,"symbol":"-[UIView(Hierarchy) layoutBelowIfNeeded]","symbolLocation":556,"imageIndex":4},{"imageOffset":3496832,"symbol":"-[UISheetPresentationController _sheetLayoutInfoLayout:]","symbolLocation":48,"imageIndex":4},{"imageOffset":3094680,"symbol":"-[_UISheetLayoutInfo _layout]","symbolLocation":332,"imageIndex":4},{"imageOffset":2826032,"symbol":"__54-[UISheetPresentationController _transitionWillBegin:]_block_invoke_2","symbolLocation":52,"imageIndex":4},{"imageOffset":1454788,"symbol":"+[UIView(Animation) performWithoutAnimation:]","symbolLocation":96,"imageIndex":4},{"imageOffset":16983084,"symbol":"__54-[UISheetPresentationController _transitionWillBegin:]_block_invoke.523","symbolLocation":140,"imageIndex":4},{"imageOffset":2458236,"symbol":"-[_UIViewControllerTransitionCoordinator _applyBlocks:releaseBlocks:]","symbolLocation":268,"imageIndex":4},{"imageOffset":5198356,"symbol":"-[_UIViewControllerTransitionContext __runAlongsideAnimations]","symbolLocation":264,"imageIndex":4},{"imageOffset":2483276,"symbol":"__63+[UIView(Animation) _setAlongsideAnimations:toRunByEndOfBlock:]_block_invoke","symbolLocation":28,"imageIndex":4},{"imageOffset":5554480,"symbol":"-[UIViewAnimationState _runAlongsideAnimations]","symbolLocation":32,"imageIndex":4},{"imageOffset":5821056,"symbol":"-[UIViewAnimationState pop]","symbolLocation":52,"imageIndex":4},{"imageOffset":2473388,"symbol":"+[UIViewAnimationState popAnimationState]","symbolLocation":64,"imageIndex":4},{"imageOffset":1528220,"symbol":"+[UIView _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:]","symbolLocation":728,"imageIndex":4},{"imageOffset":18510892,"symbol":"__50-[UITransitionView _startTransition:withDuration:]_block_invoke.170","symbolLocation":156,"imageIndex":4},{"imageOffset":2491924,"symbol":"+[UIView(UIViewAnimationWithBlocks) conditionallyAnimate:withAnimation:layout:completion:]","symbolLocation":88,"imageIndex":4},{"imageOffset":3294596,"symbol":"-[UITransitionView _startTransition:withDuration:]","symbolLocation":692,"imageIndex":4},{"imageOffset":2488164,"symbol":"-[UITransitionView transition:fromView:toView:removeFromView:]","symbolLocation":2552,"imageIndex":4},{"imageOffset":2880560,"symbol":"-[UIViewControllerBuiltinTransitionViewAnimator animateTransition:]","symbolLocation":1496,"imageIndex":4},{"imageOffset":4759504,"symbol":"___UIViewControllerTransitioningRunCustomTransition_block_invoke_2","symbolLocation":72,"imageIndex":4},{"imageOffset":2917632,"symbol":"+[UIKeyboardSceneDelegate _pinInputViewsForKeyboardSceneDelegate:onBehalfOfResponder:duringBlock:]","symbolLocation":104,"imageIndex":4},{"imageOffset":3387588,"symbol":"___UIViewControllerTransitioningRunCustomTransition_block_invoke.641","symbolLocation":176,"imageIndex":4},{"imageOffset":3939204,"symbol":"+[UIView(Animation) _setAlongsideAnimations:toRunByEndOfBlock:]","symbolLocation":172,"imageIndex":4},{"imageOffset":2511480,"symbol":"_UIViewControllerTransitioningRunCustomTransition","symbolLocation":572,"imageIndex":4},{"imageOffset":8979404,"symbol":"__56-[UIPresentationController runTransitionForCurrentState]_block_invoke.401","symbolLocation":2152,"imageIndex":4},{"imageOffset":3195444,"symbol":"-[_UIAfterCACommitBlock run]","symbolLocation":64,"imageIndex":4},{"imageOffset":2258788,"symbol":"-[_UIAfterCACommitQueue flush]","symbolLocation":200,"imageIndex":4},{"imageOffset":1400484,"symbol":"runAfterCACommitDeferredBlocks","symbolLocation":640,"imageIndex":4},{"imageOffset":1402224,"symbol":"cleanUpAfterCAFlushAndRunDeferredBlocks","symbolLocation":128,"imageIndex":4},{"imageOffset":1402684,"symbol":"afterCACommitHandler","symbolLocation":56,"imageIndex":4},{"imageOffset":255884,"symbol":"CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION","symbolLocation":32,"imageIndex":7},{"imageOffset":63924,"symbol":"__CFRunLoopDoObservers","symbolLocation":616,"imageIndex":7},{"imageOffset":44860,"symbol":"__CFRunLoopRun","symbolLocation":1012,"imageIndex":7},{"imageOffset":123284,"symbol":"CFRunLoopRunSpecific","symbolLocation":572,"imageIndex":7},{"imageOffset":6536,"symbol":"GSEventRunModal","symbolLocation":160,"imageIndex":8},{"imageOffset":5134984,"symbol":"-[UIApplication run]","symbolLocation":1080,"imageIndex":4},{"imageOffset":2617288,"symbol":"UIApplicationMain","symbolLocation":336,"imageIndex":4},{"imageOffset":163556,"symbol":"UIApplicationMain(::::)","symbolLocation":100,"imageIndex":9},{"imageOffset":30020,"symbol":"main","symbolLocation":108,"imageIndex":5},{"imageOffset":99536,"symbol":"start","symbolLocation":444,"imageIndex":10}]},{"id":1298162,"frames":[{"imageOffset":6452,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":11}]},{"id":1298163,"frames":[{"imageOffset":6452,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":11}]},{"id":1298164,"name":"com.apple.uikit.eventfetch-thread","frames":[{"imageOffset":2732,"symbol":"mach_msg_trap","symbolLocation":8,"imageIndex":12},{"imageOffset":4220,"symbol":"mach_msg","symbolLocation":72,"imageIndex":12},{"imageOffset":27848,"symbol":"__CFRunLoopServiceMachPort","symbolLocation":368,"imageIndex":7},{"imageOffset":45008,"symbol":"__CFRunLoopRun","symbolLocation":1160,"imageIndex":7},{"imageOffset":123284,"symbol":"CFRunLoopRunSpecific","symbolLocation":572,"imageIndex":7},{"imageOffset":97964,"symbol":"-[NSRunLoop(NSRunLoop) runMode:beforeDate:]","symbolLocation":232,"imageIndex":13},{"imageOffset":356304,"symbol":"-[NSRunLoop(NSRunLoop) runUntilDate:]","symbolLocation":88,"imageIndex":13},{"imageOffset":4607732,"symbol":"-[UIEventFetcher threadMain]","symbolLocation":512,"imageIndex":4},{"imageOffset":412636,"symbol":"NSThread__start","symbolLocation":792,"imageIndex":13},{"imageOffset":13128,"symbol":"_pthread_start","symbolLocation":116,"imageIndex":11},{"imageOffset":6472,"symbol":"thread_start","symbolLocation":8,"imageIndex":11}]},{"id":1298165,"queue":"com.apple.libtrace.state.block-list","frames":[{"imageOffset":5768,"symbol":"__ulock_wait","symbolLocation":8,"imageIndex":12},{"imageOffset":19808,"symbol":"_dlock_wait","symbolLocation":52,"imageIndex":3},{"imageOffset":19276,"symbol":"_dispatch_thread_event_wait_slow$VARIANT$mp","symbolLocation":52,"imageIndex":3},{"imageOffset":72700,"symbol":"DISPATCH_WAIT_FOR_QUEUE","symbolLocation":320,"imageIndex":3},{"imageOffset":71712,"symbol":"_dispatch_sync_f_slow","symbolLocation":136,"imageIndex":3},{"imageOffset":40256,"symbol":"___os_state_request_for_self_block_invoke","symbolLocation":348,"imageIndex":14},{"imageOffset":405652,"symbol":"_dispatch_call_block_and_release","symbolLocation":24,"imageIndex":3},{"imageOffset":409748,"symbol":"_dispatch_client_callout","symbolLocation":16,"imageIndex":3},{"imageOffset":42812,"symbol":"_dispatch_lane_serial_drain$VARIANT$mp","symbolLocation":644,"imageIndex":3},{"imageOffset":45604,"symbol":"_dispatch_lane_invoke$VARIANT$mp","symbolLocation":456,"imageIndex":3},{"imageOffset":85704,"symbol":"_dispatch_workloop_worker_thread","symbolLocation":632,"imageIndex":3},{"imageOffset":7696,"symbol":"_pthread_wqthread","symbolLocation":284,"imageIndex":11},{"imageOffset":6460,"symbol":"start_wqthread","symbolLocation":8,"imageIndex":11}]}],
"usedImages" : [
{
"size" : 0,
"source" : "A",
"base" : 0,
"uuid" : "00000000-0000-0000-0000-000000000000"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 3346432,
"uuid" : "9795cbd6-ea23-3c07-9b84-1fc501e7048f",
"path" : "/System/Library/Frameworks/CoreImage.framework/CoreImage",
"name" : "CoreImage"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 901120,
"uuid" : "d2e4c3cd-5596-34c2-b1f0-59f86b3f9303",
"path" : "/System/Library/PrivateFrameworks/CoreUI.framework/CoreUI",
"name" : "CoreUI"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 536576,
"uuid" : "34ef3925-0303-30bf-9946-ad99311620dd",
"path" : "/usr/lib/system/libdispatch.dylib",
"name" : "libdispatch.dylib"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 24756224,
"uuid" : "697c7d5c-9761-36e9-8e0f-200035bf3f39",
"path" : "/System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore",
"name" : "UIKitCore"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 622592,
"uuid" : "9c8d59e5-3c99-335c-ac67-ac962ef3f079",
"path" : "/Applications/Antoine.app/Antoine",
"name" : "Antoine"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 3047424,
"uuid" : "fd63e054-0c31-3665-874b-aa57ec5b0acb",
"path" : "/System/Library/Frameworks/QuartzCore.framework/QuartzCore",
"name" : "QuartzCore"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 4448256,
"uuid" : "55c76f8e-bcc9-3a4c-9f62-16eac0ba8ab8",
"path" : "/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation",
"name" : "CoreFoundation"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 36864,
"uuid" : "8f5bd2c4-f5d5-358e-82bd-1b2259a5c050",
"path" : "/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices",
"name" : "GraphicsServices"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 393216,
"uuid" : "a0a642d9-1f20-37dd-90ee-289b047d7bc8",
"path" : "/usr/lib/swift/libswiftUIKit.dylib",
"name" : "libswiftUIKit.dylib"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 344064,
"uuid" : "58ab16ce-d7e0-32d3-946d-4f68fb1a4a17",
"path" : "/usr/lib/dyld",
"name" : "dyld"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 69632,
"uuid" : "ad10e933-2904-3dbc-9575-707033bf6949",
"path" : "/usr/lib/system/libsystem_pthread.dylib",
"name" : "libsystem_pthread.dylib"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 212992,
"uuid" : "af565ccf-2e9d-37b0-ae60-c41279a0025a",
"path" : "/usr/lib/system/libsystem_kernel.dylib",
"name" : "libsystem_kernel.dylib"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 3035136,
"uuid" : "3f1763e1-10b6-3144-b223-e031482cbf46",
"path" : "/System/Library/Frameworks/Foundation.framework/Foundation",
"name" : "Foundation"
},
{
"source" : "P",
"arch" : "arm64",
"base" :<PHONE_NUMBER>,
"size" : 102400,
"uuid" : "3a281dbb-bd38-3f3d-acee-78bdefdcebf1",
"path" : "/usr/lib/system/libsystem_trace.dylib",
"name" : "libsystem_trace.dylib"
}
],
"sharedCache" : {
"base" :<PHONE_NUMBER>,
"size" :<PHONE_NUMBER>,
"uuid" : "cd244fbb-9697-3d73-a8cf-df97f36e2079"
},
"vmSummary" : "ReadOnly portion of Libraries: Total=722.1M resident=0K(0%) swapped_out_or_unallocated=722.1M(100%)\nWritable regions: Total=547.9M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=547.9M(100%)\n\n                                VIRTUAL   REGION \nREGION TYPE                        SIZE    COUNT (non-coalesced) \n===========                     =======  ======= \nActivity Tracing                   256K        1 \nCG raster data                    3248K        9 \nColorSync                           80K        5 \nCoreAnimation                     4224K       56 \nCoreUI image data                  720K        1 \nFoundation                          16K        1 \nKernel Alloc Once                   32K        1 \nMALLOC                           540.5M       32 \nMALLOC guard page                  128K        8 \nSTACK GUARD                         80K        5 \nStack                             3184K        5 \nVM_ALLOCATE                        144K        8 \n__CTF                               756        1 \n__DATA                            19.0M      576 \n__DATA_CONST                      49.9M      594 \n__DATA_DIRTY                      2243K      484 \n__FONT_DATA                          4K        1 \n__GLSLBUILTINS                    1904K        1 \n__LINKEDIT                       187.7M        9 \n__OBJC_RO                         92.1M        1 \n__OBJC_RW                         3520K        1 \n__TEXT                           534.4M      606 \n__UNICODE                          592K        1 \ndyld private memory               1024K        1 \nmapped file                      159.9M       10 \nshared memory                       48K        3 \n===========                     =======  ======= \nTOTAL                              1.6G     2421 \n",
"legacyInfo" : {
"threadTriggered" : {
"queue" : "com.apple.main-thread"
}
},
"trialInfo" : {
"rollouts" : [
{
"rolloutId" : "60356660bbe37970735c5624",
"factorPackIds" : {
  },
  "deploymentId" : 240000027
},
{
  "rolloutId" : "6112e14f37f5d11121dcd519",
  "factorPackIds" : {
    "SIRI_TEXT_TO_SPEECH" : "634710168e8be655c1316aaa"
  },
  "deploymentId" : 240000231
}

],
"experiments" : [
]
}
}


Possibility for @FragmentInject?

The androidx.fragment library recently added support for supplying a custom FragmentFactory to handle creation (and re-creation) of Fragments. This opens a potential possibility for using Dagger to handle the creation and injection of your Fragments -- potentially supplying the arguments as @Assisted similarly to how @InflationInject is working.
Is this something you would consider adding to the library or do you think it would be better as a separate library?

Is it needed? Fragments don't require any assisted parameters in their
constructor like views. Normal injection and multibinding should suffice.
On Fri, Mar 1, 2019, 9:38 AM Alex Townsend<EMAIL_ADDRESS>wrote:

The androidx.fragment library recently added support for supplying a
custom FragmentFactory
https://developer.android.com/reference/androidx/fragment/app/FragmentFactory
to handle creation (and re-creation) of Fragments. This opens a potential
possibility for using Dagger to handle the creation and injection of your
Fragments -- potentially supplying the arguments as @Assisted similarly
to how @InflationInject is working.
Is this something you would consider adding to the library or do you think
it would be better as a separate library?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/AssistedInject/issues/82, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEerSyiFI2ePGCGIQd6g0qK80RQ_qks5vSTtLgaJpZM4bZJND
.

My use-case was for attempting to convert/refactor a project to use a Dagger-backed FragmentFactory for constructor injection of Fragments instead of Dagger's AndroidInject field-level injection, where previously some values/state was passed through the args Bundle (note: the project was not yet using Dagger, ).
Using a pattern like the @InflationInject with the args Bundle would allow passing in an arbitrary number of "assisted" elements through the Bundle supplied to the FragmentFactory when you first create the Fragment -- values could be pulled out in the init block and used however necessary in Fragment setup. I might just have missed something but I was struggling to do this in a generic/re-usable way for all Fragments using just @AssistedInject.
Might be more of a niche use case though, as you said there is no required assisted parameter in this use-case. Might be better to pull out into a separate library then?

I don't think it requires assisted injection.
I think you want this to work like how AndroidInjection.inject(this) works
where it creates a subcomponent where the concrete type is available in a
generated subcomponent. And then if you need to access the arguments you
can either inject the subtype and call getArguments() or add a module to
the subcomponent which @Provides the Bundle by calling getArguments().
And I think we need to do this for activity, service, etc. And as a result
I think it should live in Dagger, not this library.
On Fri, Mar 1, 2019 at 10:22 AM Alex Townsend<EMAIL_ADDRESS>wrote:

My use-case was for attempting to convert/refactor a project to use a
Dagger-backed FragmentFactory for constructor injection of Fragments
instead of Dagger's AndroidInject field-level injection, where previously
some values/state was passed through the args Bundle (note: the project was
not yet using Dagger, ).
Using a pattern like the @InflationInject with the args Bundle would
allow passing in an arbitrary number of "assisted" elements through the
Bundle supplied to the FragmentFactory when you first create the Fragment
-- values could be pulled out in the init block and used however necessary
in Fragment setup. I might just have missed something but I was struggling
to do this in a generic/re-usable way for all Fragments using just
@AssistedInject.
Might be more of a niche use case though, as you said there is no
required assisted parameter in this use-case. Might be better to pull
out into a separate library then?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/square/AssistedInject/issues/82#issuecomment-468700819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEageHrfH_EBm-WsJNWO35jtlcWcgks5vSUWvgaJpZM4bZJND
.

Seems like that would work.
In the meantime, (fragment) constructor injecting an @AssistedInject factory instead of the type (i.e. Presenter.Factory instead of Presenter) and delaying calling factory.create(...) until the args Bundle has been set and I can pull whatever I need should work until Dagger better supports FragmentFactory
Looks like there is already an issue for FragmentFactory on the Dagger github as well, so I'll just close this out.
Thanks for the comments!


feat: Test building package on master

This PR adds a GitHub Action to test if the package is buildable on each commit to master.
This ensures the package can be build and exploses a reproducible "production" build on each commit to use for quick tests. Additionaly, this action als prints out the contents of the package - which is helpful in package debugging sessions. A sample run can be found in my fork (here).

This is really neat. New to github actions so I hadn't thought of doing something like this.

@j-huff I am doing a lot of the DevOps / SecOps stuff on the main InvenTree org stuff so I might have other recommendations in the future


Support for cloudsqlpostgres driver/dialect type:feature

Use of google's cloud sql proxy requires a special driver named cloudsqlpostgres. This requires the postgres dialect, but the postgres dialect instance itself is not public and cannot be accessed in a call to RegisterDialect.
If the individual dialects or the dialectsMap were public, it would allow client code of this package to register custom drivers such as cloudsqlpostgres: https://github.com/GoogleCloudPlatform/cloudsql-proxy#to-use-inside-a-go-program. Alternatively, consider adding support directly for cloudsqlpostgres by simply registering the existing postgres dialect with an additional key.

Or just add in dialect_postgres.go:
	RegisterDialect("postgres", &postgres{})
+	RegisterDialect("cloudsqlpostgres", &postgres{})

I guess your patch and this one would be best. I'am making a PR.
Your patch allow to access already defined dialect, but it does add support for cloudsqlpostgres.

Right, my thinking was just to make the dialect map public and client code could use pre-registered dialects, as ours does now. But I won't complain about native support for cloudsqlpostgres as well. :-)

I'm really interested in this, but I have tried this patch and it doesn't seem to be working for me. I get the following problem:
panic: sql: Register called twice for driver postgres goroutine 1 [running]: database/sql.Register(0xb5e0e5, 0x8, 0xe26e80, 0xe82800) /usr/local/go/src/database/sql/sql.go:50
Any idea what I'm doing wrong here, having huge problems trying to get this to work with Postgres cloudsql


Does the mod have backwards compatibility with older minecraft versions?

If not will there be?

It might work on some versions, but a while back mojang changed a thing about commands, forcing fabric to rework its command api. This only supports the new one.
As for a backport, I don't think I will do it unless there's significant demand, but it should be quite simple: just change the versions and switch to the old command event


[go] trivial ergonomics improvement

The interface writer.FeatureGenerator can somtimes be satisfied with a simple function. This is analogous to the standard library http.Handler. By defining a type alias like so it would be slightly easier to use in the trivial case.
type FeatureGeneratorFunc func() *Feature

func (f FeatureGeneratorFunc) Generate() *Feature {
	return f()
}

usage
features := *writer.Feature[]{...}
fgen := writer.FeatureGeneratorFunc(func() *Feature {
    return features
}

For example this would slightly simplify your test cases.

That is a good idea. Feel free to send a PR. :)

I don't know what I was thinking. This can't work because of the need for internal state tracking the iteration progress.

FWIIW, for simple cases it would work. Yes, the reason for the current pattern is because in the common case you are going to keep state but it is not impossible to have a stateless generator. State can also be kept in other ways like around the closure itself or, God forbid, globals. :)


chore(bootcamp): Prepare for Heureka Bootcamp

Estimated Agenda
Pre-BootCamp preparations

[x]  Friday 2nd August - Heureka Introduction with Victor and possibly the Accenture devs
[ ] - Environment Setup
[ ] - Ticket assignments
[x] -  Book meeting room 12th - 18th in the office
[ ] Establish UI workload - US, use cases, general overview - defined backlog for UI
[ ] Define affected User Stories.

Potential Workload

#5
#6
#11
#7
#9
#51
#96
#34

Workstreams
The workload is distributed across 3 work streams:

UI
GH Enablement
Scanners

Participants

Michael
David
Victor
Lola
Hoda
Dimitris
Arno
Tilman ?

Meeting room C06.15 has been booked. Exploring other possibilities that allow easy access to areas with monitors.

@MR2011 and @drochow  WTYT about this Tentative Boot-Camp Agenda
Day 1: Kick-off and Project Overview
•	09:00 - 10:00: Welcome and Introduction
•	10:00 - 11:00: Overview of the Product and Goals for the Week
•	11:00 - 12:00: Ice Breaker Activity
•	12:00 - 13:00: Lunch Break
•	13:00 - 17:00: Task Planning and Assignments
Day 2: Diving into Development
•	09:00 - 10:00: Recap of Day 1 and Goals for Day 2
•	10:00 - 12:00: Frontend and Backend Development Sessions: Working on Epics
•	12:00 - 13:00: Lunch Break
•	13:00 - 16:00: Continued Development Sessions: Working on MVP Epics
•	16:00 - 17:00: EOD review
Day 3: Mid-Week Check-In and Continued Development
•	09:00 - 10:00: Recap of Day 2 and Goals for Day 3
•	10:00 - 12:00: Frontend and Backend Development Sessions: Working on Epics
•	12:00 - 13:00: Lunch Break
•	13:00 - 14:00: Mid-Week Check-In: Progress Reports and Adjustments
•	14:00 - 16:00: Continued Development Sessions
•	16:00 - 17:00: EOD review
Day 4: Final Development and Initial Testing
•	09:00 - 10:00: Recap of Day 3 and Goals for Day 4
•	10:00 - 12:00: Frontend and Backend Development Sessions: Finalizing Epics
•	12:00 - 13:00: Lunch Break
•	13:00 - 16:00: Initial Testing and Bug Fixing.
•	16:00 - 17:00: EOD review
Day 5: Review and Wrap-Up
•	09:00 - 10:00: Recap of Day 4 and Goals for Day 5
•	10:00 - 12:00: Final Testing and Bug Fixing
•	12:00 - 13:00: Lunch Break
•	13:00 - 15:00: Review of finished Epics and Feedback Session
•	15:00 - 16:00: Wrap-Up and Next Steps for continued Product Development
•	16:00 - 17:00: Closing Celebration

Day 1: Kick-off and Project Overview
•	10:00 - 11:00: Welcome and Introduction
•	11:00 - 12:00: Work-Stream Settings
•	12:00 - 13:00: Lunch
•	13:00 - 14:30: Frontend and Backend Development Sessions: Working on Epics
•	14:30 - 15:30: Ice Breaker Activity
•	15:30 - 17:00: Frontend and Backend Development Sessions: Working on Epics
Day 2: Diving into Development
•	09:00 - 09:30: Work-Stream Settings
•	09:30 - 10:45: Frontend and Backend Development Sessions: Working on Epics
•	10:45 - 11:00: Break
•	11:00 - 12:00: Frontend and Backend Development Sessions: Working on Epics
•	12:00 - 13:00: Lunch
•	13:00 - 14:00: Technical Design Discussion
•	14:00 - 15:00: Ice Breaker
•	15:00 - 16:00: Frontend and Backend Development Sessions: Working on Epics
•	16:00 - 17:00: Recap
Day 3: Continued Development
•	09:00 - 09:30: Work-Stream Settings
•	09:30 - 10:45: Frontend and Backend Development Sessions: Working on Epics
•	10:45 - 11:00: Break
•	11:00 - 12:00: Frontend and Backend Development Sessions: Working on Epics
•	12:00 - 13:00: Lunch
•	13:00 - 15:00: Technical Design Discussion
•	15:00 - 16:00: Ice Breaker
•	16:00 - 17:00: Frontend and Backend Development Sessions: Working on Epics
Day 4: Final Development and Initial Testing
•	09:00 - 09:30: Work-Stream Settings
•	09:30 - 10:45: Frontend and Backend Development Sessions: Working on Epics
•	10:45 - 11:00: Break
•	11:00 - 12:00: Frontend and Backend Development Sessions: Working on Epics
•	12:00 - 13:00: Lunch
•	13:00 - 14:00: Technical Design Discussion
•	14:00 - 15:00: Ice Breaker
•	15:00 - 17:00: Frontend and Backend Development Sessions: Working on Epics
Day 5: Review and Wrap-Up
•	09:00 - 10:45: Technical Design Discussion
•	10:45 - 11:00: Break
•	11:00 - 12:00: Frontend and Backend Development Sessions: Working on Epics
•	12:00 - 13:00: Lunch
•	13:00 - 14:00: Week Recap
•	14:00 - 15:00: Week 2 Setup - Virtual Boot-camp

Catering request has been submitted.

Pictorial Agenda

MVP:
Views -
IssueMatch List
Service List
Service detail
Component list

Mural Board

Day 1:
Expectations

A working POC
UI with real findings
Search for affected components by CVE
POC workflow - a few data from each source - basic end-to-end workflow in a UI.
Consider useful info to show on the UI for each entity - we need to clarify what useful data is for each component and also for each persona - TDD (Personas doc)
persona data - understand what kind of data to deliver
set straight what GH can and cannot do
Enable heuraka as a plugin in GH
Persona useful info -
DOOP - being hybrid plugin - clarify future of DOOP
Properly represent Heureka to all stakeholders
Foundation loose ends tied together - understand how ot all works - build a workflow.
Establish a foundation for building plugins/services
Narwahl personas - managers, LOBs,
Persona use case expected data/info - LO-FI mock ups may help
Establish user-stories and acceptance criterias to be fulfilled - identify base ACs'
Core Features definition - map to new personas - list of features
HAve something to deliver for now.

Core
Plugin
Real data.


Locally created conversation does not show up in AtlasConversationsRecyclerView

Hi,
I'm using AtlasConversationsRecyclerView to show the list of conversations in my Android app.
Before showing the conversation list, I'm fetching a custom list of layer user ids from our backend and, for each id, I'm creating a new conversation using newConversationWithUserIds.
LayerSDK prints some debug saying that the conversation is being successfully created:

(...)com.layer.sdk.internal.lsdkk.k.e(Log.java:465) : Creating new Conversation, Id: layer:///conversations/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx

However, when displaying the conversation list, it does not show the locally created conversations.
This code is already in production since a few months ago and only recently users start to complain about not seeing some conversations that should be listed.
When the conversations are created from the Web Client or backend, then it is normally showing up on the mobile conversation list.
We tried to change the conversation creation for different moments but none of these approaches are working:

Just after connected and if authenticated (onConnectionConnected)
Just after layer authentication (onAuthenticated);
Just after sync (onAfterSync)

We've been using Atlas-Android version 0.4.10 and we verified the same porblem when using the latest version (0.4.12).

For technical assistance please reach out to us via support.layer.com.


[SPARK-18966][SQL] NOT IN subquery with correlated expressions may return incorrect result

What changes were proposed in this pull request?
This PR fixes the following problem:
Seq((1, 2)).toDF("a1", "a2").createOrReplaceTempView("a")
Seq[(java.lang.Integer, java.lang.Integer)]((1, null)).toDF("b1", "b2").createOrReplaceTempView("b")

// The expected result is 1 row of (1,2) as shown in the next statement.
sql("select * from a where a1 not in (select b1 from b where b2 = a2)").show
+---+---+
| a1| a2|
+---+---+
+---+---+

sql("select * from a where a1 not in (select b1 from b where b2 = 2)").show
+---+---+
| a1| a2|
+---+---+
|  1|  2|
+---+---+

There are a number of scenarios to consider:

When the correlated predicate yields a match (i.e., B.B2 = A.A2)
1.1. When the NOT IN expression yields a match (i.e., A.A1 = B.B1)
1.2. When the NOT IN expression yields no match (i.e., A.A1 = B.B1 returns false)
1.3. When A.A1 is null
1.4. When B.B1 is null
1.4.1. When A.A1 is not null
1.4.2. When A.A1 is null

When the correlated predicate yields no match (i.e.,B.B2 = A.A2 is false or unknown)
2.1. When B.B2 is null and A.A2 is null
2.2. When B.B2 is null and A.A2 is not null
2.3. When the value of A.A2 does not match any of B.B2

 A.A1   A.A2      B.B1   B.B2
-----  -----     -----  -----
    1      1         1      1    (1.1)
    2      1                     (1.2)
 null      1                     (1.3)

    1      3      null      3    (1.4.1)
 null      3                     (1.4.2)

    1   null         1   null    (2.1)
 null      2                     (2.2 & 2.3)

We can divide the evaluation of the above correlated NOT IN subquery into 2 groups:-
Group 1: The rows in A when there is a match from the correlated predicate (A.A1 = B.B1)
In this case, the result of the subquery is not empty and the semantics of the NOT IN depends solely on the evaluation of the equality comparison of the columns of NOT IN, i.e., A1 = B1, which says

If A.A1 is null, the row is filtered (1.3 and 1.4.2)
If A.A1 = B.B1, the row is filtered (1.1)
If B.B1 is null, any rows of A in the same group (A.A2 = B.B2) is filtered (1.4.1 & 1.4.2)
Otherwise, the row is qualified.

Hence, in this group, the result is the row from (1.2).
Group 2: The rows in A when there is no match from the correlated predicate (A.A2 = B.B2)
In this case, all the rows in A, including the rows where A.A1, are qualified because the subquery returns an empty set and by the semantics of the NOT IN, all rows from the parent side qualifies as the result set, that is, the rows from (2.1, 2.2 and 2.3).
In conclusion, the correct result set of the above query is
 A.A1   A.A2
-----  -----
    2      1    (1.2)
    1   null    (2.1)
 null      2    (2.2 & 2.3)

How was this patch tested?
unit tests, regression tests, and new test cases focusing on the problem being fixed.

Test build #74545 has started for PR 17294 at commit 507b2fa.

LGTM - pending jenkins.

Test build #74545 has finished for PR 17294 at commit 507b2fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74545/
Test PASSed.

Merged build finished. Test PASSed.

Merging to master. Thanks!

@nsyca should we backport this to 2.1/2.0?

@hvanhovell It would not be trivial to backport to 2.1/2.0. The correlated predicates in the NOT IN subquery have been pulled up in Analyzer phase and combined with the the columns in the LHS and RHS of NOT IN. We will need a different technique from this fix such as marking the correlated predicates differently from the columns in NOT IN.
NOT IN is not commonly used with null values. I think the effort may not be worth it.
Thank you for your quick turnaround time in the review and merging the PR.

@nsyca that makes sense. Lets not backport for now.


Op2dTensorSquash doesn't fit into tensor operation paradigm and can't pass the tests.

@muralinr @zjing14 probably you may shed some light on it.
@junliume probably you know who else worked on this code and may answer the questions.
Should we move Op2dTensorSquash outside of 3d tensors operations and add separated tests and all the infrastructure for it? Combining different functionality under one API interface seems error prone for me.
Here is a detail description:
For 3d tensor operations there is a special Squash case where tensor B is not equal to A and C and is not properly squashed.
It supposed to be either equal to A and C A:2x3x4 and B:2x3x4 or some of the dimensions are squashed like B:1x3x4 or B:1x1x4 or B:2x3x1 but for that particular squashed case there is an exception https://github.com/ROCmSoftwarePlatform/MIOpen/blob/a0c73f544d3db86511f8a521a34198cba5939ac7/src/ocl/tensorocl.cpp#L1286 which explicitly breaks the rule and allows following combinations: A:1x1x3 and B:1x100x3.
The problem is Op2dTensorSquash does not pass tensor_ops tests but it is used in RNN tests and RNN relies on its behavior (when I force to use any non-squashed version which pass tensot_ops tests, it fails RNN tests):

Failed log
```
./bin/test_tensor_ops --float --a 1 1 3 --b 1 3 3 --offsets 0 0 0 --alpha-beta 1 1 1 --packed 1 --sa 1 1 1 --sb 1 1 1 --sc 1 1 1
...
MIOpen(HIP): Info2 [GetKernels] 0 kernels for key: Op2dTensorSquash "1-1-1-1x256x1"                                                              [2296/9067]MIOpen(HIP): Info2 [AddKernel] Key: Op2dTensorSquash "1-1-1-1x256x1"                                                                                MIOpen(HIP): Info [PrintVersionImpl] COMgr v.2.5.0, USE_HIP_PCH: 1                                                                                MIOpen(HIP): Info2 [SetIsaName] amdgcn-amd-amdhsa--gfx1030                                                                                MIOpen(HIP): Info2 [Log] Kernel MIOpenTensorKernels.cl Compile Time, ms: 223.932                                                                            MIOpen(HIP): Info2 [run] kernel_name = Op2dTensorSquash, global_work_dim = { 256, 1, 1 }, local_work_dim = { 256, 1, 1 }                                    GPU_C[0]: 57.000000                                                                                GPU_C[1]: 217.000000
GPU_C[2]: 286.000000
GPU_A[0]: 3.000000
GPU_A[1]: 7.000000
GPU_A[2]: 11.000000
GPU_B[0]: 3.000000
GPU_B[1]: 7.000000
GPU_B[2]: 11.000000
GPU_B[3]: 6.000000
GPU_B[4]: 10.000000
GPU_B[5]: 14.000000
GPU_B[6]: 9.000000
GPU_B[7]: 13.000000
GPU_B[8]: 0.000000
MIOpen(HIP): Info2 [default_deallocator] hipFree 36 at 0x7fc19fc02000 Ok
MIOpen(HIP): Info2 [default_deallocator] hipFree 12 at 0x7fc19fc01000 Ok
MIOpen(HIP): Info2 [default_deallocator] hipFree 12 at 0x7fc19fc00000 Ok
c[0](3.000000) = a[0](3.000000) * b[0](3.000000)
c[1](7.000000) = a[1](7.000000) * b[1](7.000000)
c[2](11.000000) = a[2](11.000000) * b[2](11.000000)
CPU_C[0]: 12.000000
CPU_C[1]: 56.000000
CPU_C[2]: 132.000000
./bin/test_tensor_ops --float --a 1 1 3 --b 1 3 3 --sa 1 1 1 --sb 1 1 1 --sc 1 1 1 --offsets 0 0 0 --alpha-beta 1 1 1 --packed 1
FAILED: 0.458838
Iteration: 0
TensorOp:
A tensor: 1, 1, 3
B tensor: 1, 3, 3
C tensor: 1, 1, 3
Offsets: 0,0,0
Max diff: 161
Mismatch at 0: 12 != 57
```

Currently to run such tests the check at https://github.com/ROCmSoftwarePlatform/MIOpen/blob/a0c73f544d3db86511f8a521a34198cba5939ac7/test/tensor_ops.cpp#L317 should be disabled, since it verifies normal tensor operations requirements and squashed version is out of this scope.

@CAHEK7 Sure, if you want to add another test exclusively for 2D tensors, please feel free to add it.  However, we are not doing an active development for OpenCL kernels.

I would like to remove the squashed version from the tensor operation at all. I'm not talking about the tests only. Move it to squashed tensor ops or something like this. (and keep ocl version as it is).
The rest of the tensor operations will be optimized and rewritten on hip. As about the optimizations - check pr #2262

@muralinr
The main concern is Op2dTensorSquash resides in 3d operations and moreover it does not behave like all the other operations and there are no direct tests for it. Somebody may wrongly call OpTensor3d expecting elementwise operations and got squashed version instead. There is no explicit difference between Op2dTensorSquash, Op2dTensorLite and Op3dTensorGeneric.
But the last two behaves identically, Lite version is just an optimized special case which can be verified by Generic version, while Op2dTensorSquash produces completely different results.

@CAHEK7 Op2dTensorSquash kernel is used by RNNs (LSTM) currently.  I will run some of these RNN configs and provide you more info.

@CAHEK7 The following RNN config will be using Op2dTensorSquash kernel.
./bin/MIOpenDriver rnnfp16 -n 224 -W 224 -H 1000 -l 8 -b 1 -m lstm -p 0 -r 0 -k 32 -F 4 -t 1 -w 1

@CAHEK7 please remind me if there is a fix WIP?

@CAHEK7 Can you please run below tests which calls tensor operations?
./bin/MIOpenDriver rnnfp16 -n 224 -W 224 -H 1000 -l 8 -b 1 -m lstm -p 0 -r 0 -k 32 -F 2 -t 1 -w 1
./bin/MIOpenDriver rnnfp16 -n 224 -W 224 -H 1000 -l 8 -b 1 -m lstm -p 0 -r 0 -k 32 -F 4 -t 1 -w 1
./bin/MIOpenDriver rnnfp16 -n 224 -W 224 -H 1000 -l 8 -b 1 -m lstm -p 0 -r 0 -k 32 -c 0 -F 1 -t 1 -w 1

@CAHEK7 please remind me if there is a fix WIP?

For this particular issue I don't know what should be fixed. The problem is that it passes RNN tests, but fails direct tensor_ops test and vice versa - if the kernel passes direct test it fails rnn. So 2d squashed operation is not the typical operation and can only be distinguished by specific 3d tensor configuration which also violates tensor ops paradigm.
My proposal is to move that squashed operation out of the tensors operations and add all of the required tests and infrastructure.

Squash came from here: https://github.com/ROCmSoftwarePlatform/MIOpen/commit/df1cb2ac2a107ad9e7ffe88009fa7c19cb7588d0

Since OpTensor is a part of external API, this squashed version must be removed from it as it violates the rules of tensor operations.
As for temporary solution, I suggest to introduce a flag which will be false by default and for all the external API calls and tests, but for direct call from RNN code it will be set to true to enable non-conformant behavior.
Later squashed version will be completely removed from OpTensor to some separated entity.


SR-IOV: MSI/MSI-X interrupt new TC

New TC "SR-IOV Interrupts change": verifies if the interrupts count from /proc/interrupts is increasing after traffic goes through the VF.
Expected initial results:
a. The number of PCIe MSI devices processing interrupts should be greater than NUM_VF*9
Steps:

On the controller-vm save/construct these values from /proc/interrupts:
a. A sum of all interrupts per PCIe MSI device (exclude MSI devices with 0 interrupts)
b. A list of all vCPUs that are processing interrupts. Save the number of interrupts for each vCPU.
Start iPerf3 for 10 minutes with 128 threads
Repeat step 2 after iPerf3 finished

Expected results:
After comparing the values from step 2 and step 4, each value from step 4 should increase after the iPerf3 run.
Test results
[LISAv2 Test Results Summary]
Test Run On           : 03/14/2019 22:36:49
ARM Image Under Test  : Canonical : UbuntuServer : 18.04-LTS : latest
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:22
ID TestCaseName                                                                TestResult TestDuration(in minutes)
1 SRIOV-INTERRUPTS-CHANGE                                                           PASS                14.33

[LISAv2 Test Results Summary]
Test Run On           : 03/14/2019 22:38:32
ARM Image Under Test  : RedHat : RHEL : 7.5 : latest
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:25
ID TestCaseName                                                                TestResult TestDuration(in minutes)
1 SRIOV-INTERRUPTS-CHANGE                                                           PASS                16.75

Can test log includes before/after interrupt count snapshot as raw data?

@juhlee-microsoft They include the interrupts/vcpu before & after the test run. Here is an example:
[lisa@LISAv2~]$ cat TestExecution.log
Thu Mar 14 23:16:13 2019 : Testscript running on redhat_7
Thu Mar 14 23:16:13 2019 : Successfully initialized testscript!
Thu Mar 14 23:16:31 2019 : yum_install ruby: Success
Thu Mar 14 23:16:31 2019 : Expected VF count: 1. Actual VF count: 1
Thu Mar 14 23:16:31 2019 : The number of MSI PCIe devices processing interrupts is: 17
Thu Mar 14 23:16:31 2019 : vCPU 0 is processing 1157 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 1 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 2 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 3 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 4 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 5 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 6 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 7 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 8 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 9 is processing 0 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 10 is processing 3907 interrupts
Thu Mar 14 23:16:31 2019 : vCPU 11 is processing 0 interrupts
------ [adsuho]: skipping logs ------
Thu Mar 14 23:16:33 2019 : ------------ Running iPerf3 for 10 minutes ------------
Thu Mar 14 23:26:35 2019 : The number of MSI PCIe devices processing interrupts is: 17
Thu Mar 14 23:26:35 2019 : vCPU 0 is processing 1157 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 1 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 2 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 3 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 4 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 5 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 6 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 7 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 8 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 9 is processing 0 interrupts
Thu Mar 14 23:26:35 2019 : vCPU 10 is processing 1822779 interrupts
------ [adsuho]: skipping logs ------

I've further consolidated the test script & also did a test run on Hyper-V:
[LISAv2 Test Results Summary]
Test Run On           : 03/15/2019 08:20:59
VHD Under Test        : ****\Ubuntu\ubuntu_18.04.1\ubuntu_18.04.1_gen1_gen2.vhdx
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:24
ID TestCaseName                                                                TestResult TestDuration(in minutes)
1 SRIOV-INTERRUPTS-CHANGE                                                           PASS                18.84

Improved the logging:
Fri Mar 15 09:02:44 2019 : vCPU 5 interrupts increased from 166 to 925643
Fri Mar 15 09:02:44 2019 : vCPU 7 interrupts increased from 159 to 937679
Fri Mar 15 09:02:44 2019 : vCPU 9 interrupts increased from 997 to 1674760
Fri Mar 15 09:02:44 2019 : vCPU 14 interrupts increased from 351 to 871065
Fri Mar 15 09:02:44 2019 : vCPU 16 interrupts increased from 592 to 1189431
Fri Mar 15 09:02:44 2019 : vCPU 18 interrupts increased from 219 to 2793269
Fri Mar 15 09:02:44 2019 : vCPU 21 interrupts increased from 299 to 3123559
Fri Mar 15 09:02:44 2019 : vCPU 34 interrupts increased from 148 to 2053292
Fri Mar 15 09:02:44 2019 : vCPU 38 interrupts increased from 326 to 4770674
Fri Mar 15 09:02:44 2019 : vCPU 44 interrupts increased from 1210 to 1287228
Fri Mar 15 09:02:44 2019 : vCPU 46 interrupts increased from 3644 to 10913
Fri Mar 15 09:02:44 2019 : vCPU 48 interrupts increased from 460 to 3089460
Fri Mar 15 09:02:44 2019 : vCPU 52 interrupts increased from 472 to 2576655
Fri Mar 15 09:02:44 2019 : vCPU 54 interrupts increased from 435 to 1614233
Fri Mar 15 09:02:44 2019 : vCPU 56 interrupts increased from 656 to 3614524
Fri Mar 15 09:02:44 2019 : vCPU 58 interrupts increased from 127 to 3105506
Fri Mar 15 09:02:44 2019 : vCPU 62 interrupts increased from 210 to 1584688
Removing PR-UNDER-TEST & DO-NOT-MERGE labels


Update CHANGELOG.rst

coverage: 75.274%. remained the same when pulling 30ebf4366a3995b5ed85efcfe837ac6ac75c52f8 on jmcrawford45-patch-6 into 8b280b9a61dcc580a3127ef40217f393aae9d8d7 on main.


Get all the VIPs of a service entry through MCP over xDS

Related issue is here: https://github.com/istio/istio/issues/36694
Signed-off-by: zhaohuabing<EMAIL_ADDRESS>Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@zhaohuabing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
bb700a723c3b4f71f665bfba1f5b9558403189f7
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zhaohuabing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
bb700a723c3b4f71f665bfba1f5b9558403189f7
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zhaohuabing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
bb700a723c3b4f71f665bfba1f5b9558403189f7
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
bb700a723c3b4f71f665bfba1f5b9558403189f7
link
true
/test unit-tests_istio

lint_istio
1d52f3d8d40ad474746fe090cb4a7b03349072c0
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
1d52f3d8d40ad474746fe090cb4a7b03349072c0
link
true
/test lint_istio

gencheck_istio
1d52f3d8d40ad474746fe090cb4a7b03349072c0
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I guess we could, but it would be confusing, because its role is not a proxy.
Huabing Zhao - Chat @ Spike	[1dmtlo]
On January 13, 2022 at 13:50 GMT, Rama Chavali @.***> wrote:
But this use case is another node type, which is a
"controller" running on the control plane.
Why cant we distinguish with proxy metadata?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@costinm @hzxuzhonghu Could you please share your thoughts about this? Should we just use Proxy Metadata or introduce a "controller" node type?

If we choose to use MetaData, we have a few options: Labels, Annotations, Raw. Neither Labels nor Annotations fit the semantic of the use case. May I just define a key "isController" in the Raw map?

May I just define a key "isController" in the Raw map?

My preference would be this. as introducing a new node type and not all code paths honouring that type (we mostly check if it is router or sidecar in majority of the code) seems incorrect to me. But I will wait for others feedback

May I just define a key "isController" in the Raw map?

My preference would be this. as introducing a new node type and not all code paths honouring that type (we mostly check if it is router or sidecar in majority of the code) seems incorrect to me. But I will wait for others feedback

@costinm @hzxuzhonghu  How do you think about it?

Option 2: there is a generator field in NodeMetadata, we can make use of it.

Option 2: there is a generator field in NodeMetadata, we can make use of it.

I need to pull the MCP resources, so the generator field has already been set as "API".

API seems enough

API seems enough

The Aeraki use case is that Aeraki needs to pull MCP resources(Service Entry, VIrtual Service, etc.) from the Istio, just the same as the "api" generator currently does, but from a "controller" point of view, so it needs all the VIPs in a Service Entry, not just the address of the same cluster of the "proxy".

@zhaohuabing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
140b277a83f259bccfbb099d03ee43da0f6df3b2
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thank you. LGTM. Will leave it for others to review

I think we should look more at the feature we want - not at the particular role.
You seem to want a custom filtering of the resources that are returned. It's not specific to controllers.
We can start with a Result_filter=none metadata. Later we can refine it, or even add it the the resource name.

This approach is more generic and can be applied to more use cases, I'll change the code.

MCP client does not want to filter out some resources, instead, it wants to know all resources.  There is a lack of use cases to implement more logic in pilot to support generic filtering.

Put a hold until come to an agreement

Should we put all the addresses in the result by default? Will the behavior cause incompatible change?

@hzxuzhonghu @ramaraochavali @costinm Hi guys, is anything I can do to move this forward?

Should we put all the addresses in the result by default? Will the behavior cause incompatible change?

I like the idea, but depends on how consumers are using this.. If they're just building things that match these VIPs, they'll have a few irrelevant ones, but there could easily be cases where traffic starts getting sent to VIPs that are invalid for a given cluster.
Do consumers properly set CLUSTER_ID meta? They should... and maybe if that's unspecified "" (not the default `"Kubernetes"' value) we don't filter VIPs based on CLUSTER_ID?

Do consumers properly set CLUSTER_ID meta? They should... and maybe if that's unspecified "" (not the default `"Kubernetes"' value) we don't filter VIPs based on CLUSTER_ID?

I think this approach is the best so far. It works for my use case and also has the least impacts on existing users.
@hzxuzhonghu @ramaraochavali @costinm if you also agree with this, I can change this PR this way.

Another idea is cluster_id=* – less likely to break other clients. Only issue is making that wildcard have consistent behavior in all the places that we use cluster_id..

@zhaohuabing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

integ-cni_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

integ-cni_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-cni_istio

integ-telemetry-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

integ-cni_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-cni_istio

integ-telemetry-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

integ-cni_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-cni_istio

integ-telemetry-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-multicluster_istio

integ-pilot-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

integ-cni_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-cni_istio

integ-telemetry-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-multicluster_istio

integ-pilot-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-multicluster_istio

integ-telemetry-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

integ-cni_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-cni_istio

integ-telemetry-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-multicluster_istio

integ-pilot-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-multicluster_istio

integ-telemetry-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-mc_istio

integ-ipv6_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test unit-tests_istio

analyze-tests_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test analyze-tests_istio

release-test_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test release-test_istio

gencheck_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test gencheck_istio

integ-distroless_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-distroless_istio

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-helm_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-helm_istio

integ-security_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security_istio

integ-telemetry_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry_istio

integ-pilot_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-istiodremote_istio

lint_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test lint_istio

integ-pilot-istiodremote-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote-mc_istio

integ-cni_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-cni_istio

integ-telemetry-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-security-multicluster_istio

integ-pilot-multicluster_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-multicluster_istio

integ-telemetry-mc_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-telemetry-mc_istio

integ-ipv6_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaohuabing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
94108850f2a416ccd49637cebedf48b26bed0528
link
true
/test integ-operator-controller_istio

integ-security-multicluster_istio
79659a204a92ccf4972e29d8fad34f02000cf868
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest