Removal of fluent interface

I am willing to remove fluent interface from display package.
@WanWizard any objections?

Any objections?

The only thing I have ever chained with views is multiple calls of set() to make the code clearer and to make turning output filtering off clearer too. I'm with @sagikazarmark in that fluent interfaces should be avoided for the most part.
If people request it we can easily add it back in at a later date.

I agree it should not be there "for the sake of it", but don't remove it where is absolutely makes sense.
For views, it absolutely makes sense to be able to chain the diffent set() methods. This may have side effects though, for example simply returning the result of a chained call and expect to get a View object back may no longer work depending on the last method in the chain.

Yeah, the builder-like methods can be fluent.

for example simply returning the result of a chained call and expect to get a View object back may no longer work depending on the last method in the chain.

@WanWizard that's the responsibility of the developer


Libraries depending on libraries and template inlining not working?

First off, thank you for the generator.  It has been pretty tough figuring out exactly what the Angular community is aiming for with project configuration of libraries vs. applications.
I created two libraries (call them A and B) using this generator and an application using the angular-cli.  Library A depends on B, and the library A has templateUrl specified in a number of components.  When the app is built (npm run build), the templates are not included.  Also, the library that depends on the other can't run through npm run build.
I'm not sure exactly which errors are caused by what problems, so I'm just going to walk through this here to see if I can get my libraries working (they've been fine up until now, but I've been using tsc and not been worrying about AoT).
Taking a step back to just Library A, if I run npm run prepublish, nothing gets inlined.
For example, one of the components in A that has a templateUrl specified, the corresponding js still says templateUrl: 'the.component.template.name.html' -- it was never in-lined.
Not knowing if this is tied to running npm run build, I tried it, but I get the following error:
Error: ENOENT: no such file or directory, open '/projects/ui-development/library-a/dist/node_modules/library-b/src/shared/base.service.metadata.json'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.writeFileSync (fs.js:1333:33)
    at MetadataWriterHost.writeMetadata (/projects/ui-development/library-a/node_modules/@angular/tsc-wrapped/src/compiler_host.js:115:22)
    at MetadataWriterHost._this.writeFile (/projects/ui-development/library-a/node_modules/@angular/tsc-wrapped/src/compiler_host.js:92:23)
    at Object.writeFile (/projects/ui-development/library-a/node_modules/typescript/lib/typescript.js:64240:132)
    at Object.writeFile (/projects/ui-development/library-a/node_modules/typescript/lib/typescript.js:9020:14)
    at printSourceFileOrBundle (/projects/ui-development/library-a/node_modules/typescript/lib/typescript.js:61204:16)
    at emitSourceFileOrBundle (/projects/ui-development/library-a/node_modules/typescript/lib/typescript.js:61155:21)
    at Object.forEachEmittedFile (/projects/ui-development/library-a/node_modules/typescript/lib/typescript.js:8986:17)
Compilation failed

It seems to be trying to open library B's base service metadata file in library-a/dist/node_modules/library-b/src/... (vs. library-a/node_modules/library-b/dist/src/...).
As for my project setup,  this project's README suggests using npm link.  The libraries cannot be linked because there seem to be many closed (and unresolved) issues related to the angular-cli generating applications that ultimately emit obscure errors about makeDecorator not being statically analyzable, etc. (here's one).   Therefore my only solution so far has been to make my package.json dependency for the libraries point to a file path relative to the application or library:
Application's package.json
"dependencies": {
    "library-a": "../library-a"

Library A's package.json
"dependencies": {
    "library-b": "../library-b"
}

In each case, I then use npm install ... to install/refresh changes up-stream to the application.
I apologize for the rather wide net of errors, but I've been at this all day trying to unpack all these little obscure error messages.  At this point I'm not sure what errors are related and which are not since all of my code runs through tsc just fine.

Actually a quick update.  I must have just missed the 9.0 release 2 days ago when I started trying to use this, so I did not get any of the things related to inlining templates.  Now the issue is when I try to build library A, which depends on B, I end up with RangeError: Maximum call stack size exceeded, so I'm now off trying to figure out how to correct that issue, which seems to not reference anything about my own code.

@btgoodwin — The automatic template inlining is indeed only supported as of v9.0.0.
If you get a makeDecorator error, make sure to npm link the dist directory, not the root directory of your library.
It's hard to figure out what is causing the RangeError without seeing the actual code. It would be great if you could keep us posted if you find out what is causing it.
Thanks in advance!

@jvandemo Thanks for catching that (about the dist directory).  I misread the instructions.
I've restarted now with actually creating a bare library B and library A such that B depends on A.  I also de-conflicted the module names, components, etc. (so SampleModuleB, SampleComponentB, etc.).  For module B's SampleComponentB, I changed it from template to templateUrl and placed the contents into an html file under ./html/sample.component.html:
@Component({
  selector: 'sample-component-b',
  templateUrl: `html/sample.component.html`
})
export class SampleComponentB {

  constructor() {
  }

}

I then linked A's dist into B as suggested.
When I run npm run build on library B, the output dist/index.js still shows templateUrl: ... as in the original source.  If I move that HTML file into the same directory as the component, I get the same result.  I've looked in each of the output files, and I don't see where the HTML ever was inlined.
The issue with call size exceeded is clearly something wrong with my real libraries, as these basic sample ones don't have the same issue.
Just in case this was an Angular-CLI issue, I linked B and A into my app and imported each of their modules.  The template for SampleComponentB still does not get inlined anywhere.

@btgoodwin — Okay, if I understand correctly, you have 2 libraries:

Library A
Library B

From the Library A directory you should:

$ npm run build to generate dist directory for library A, which should inline styles and templates of library A in the bundle in its dist directory
$ npm link dist to link the dist directory of library A

Then from the Library B directory, you should:

$ npm link library-a (or whatever you named library A in its src/package.json
$ npm run build to generate dist directory for library B, which should inline styles and templates of library B in the bundle in its dist directory

Also, for automatic inlining of templates and styles, you must have version 9.0.0 of this generator.
Can you let us know how that goes? Thanks! 👍

Correct on all points.  Actually, I just figured out the problem.
On library-b, where I swapped the template for templateUrl, I accidentally left the backticks:
// Was:
template: `sample.component.html`

// Should have been this based on the inlineTemplate:79 in inline-resources.js
template: 'sample.component.html'

I discovered this when I tried to make library-a reproduce the same issue.  So in-lining does work as expected since I suppose people won't be putting their URLs in backticks. 😉
Consequently though, should one be concerned with rollup's messages:
'library-a' is imported by build/index.js, but could not be resolved -- treating it as an external dependency

@btgoodwin that rollup message is nothing to be concerned about. If lib-b depends on lib-a then lib-a is an external dependency indeed. If you want to get rid of this message though, find the 'rollup' task in your gulpfile and add lib-a to the 'external' property of rollup.

That's what I figured however in a previous version of our libraries, it was an indication that libraries were being "skipped" for the bundle.
Thanks everyone.  I'm still trying to figure out why my "real" library-b is throwing that stack error, but I'm convinced that's not an issue with your tooling.
Many thanks for putting this together! 👍

Awesome, thank you @caroso1222 and @btgoodwin for the help and updates.
Much appreciated!

@jvandemo @caroso1222 for the sake of closing the loop on my last two problems in case someone's google voyage drops them here:
RangeError... when produced by gulp ngc: This was because of a ModuleWithProviders pattern that worked fine back in 2.x with Optional() arguments configuring a service.  My setup was like the old RouterModule, using OpaqueToken.  Now you have to use InjectionToken which requires specifying a type.  Mine is a double string list (originally, specified as Array<Array<string>>).  That was my problem.  Switching to string[][] fixed it. :man_shrugging:
I then started getting TypeError: Cannot read property 'module' of undefined without any reference to my code.  That problem was related to the 2.x method of configuring submodule routes in the RouterModule.  In the past, to get that working where you navigate to components provided by child modules and routes, one had to export the child routes all the way out to the parent where forRoot would be used to configure the routes.  Now, it seems they have forChild and loadChildren working such that the parent sets its path to the child:
{ path: 'some-path', loadChildren: './some-child/module#SomeChildModule' }

Cheers :)

@btgoodwin — Awesome, thank you so much for the update. I am sure this will help many others in similar situations.
Much appreciated! 👍


Old field values persist in GUI after changing  GPU selection

Hello
I used 0.4.4 .rpm package, and when I open the GUI to the Information tab, then change the currently selected GPU from the top,  field values from the previous GPU persist and are shown for the newly selected GPU.
In the images bellow my RTX 3090 ASIC Name shows up as "Polaris 10" , which is obviously the value from my Radeon RX 580 card. Same for other fields like VRAM Type, VRAM bandwidth, CPU accessible VRAM.

Fixed in https://github.com/ilya-zlobintsev/LACT/commit/2b77a31c76c5c95816d1d56020154f85ef17d76e, please try the the package from the test release


Would it be possible to somehow support English "long s" character (the "ſ" character) which many old books use?

Many older books in English use the “long s” (which is/was a separate letter and there is an UTF-8 character “ſ” for it, which looks almost like an “f”, but without the line on it or just with a small line on the left side, but not on the right side)… I mean this: https://en.wikipedia.org/wiki/Long_s
So it’s not just some style that some “old-looking” fonts use for an “s”… it was actually a letter different from “s” that old books used besides “s”, like in a word “Uſefulneſs” (Usefulness).
Many old books that were published before 20th century have it and high resolution scans of books like those can be found online since they are in Public Domain… so, many people may wish to do OCR on them, even if they are also available in PDF form with searchable text because PDFs of those old books often have many errors that OCR software has made because it confused “ſ” with an “f” or some other letter.
Here are a couple of example out of many:
https://archive.org/details/artistsvademecum00laur
https://archive.org/details/gri_33125008226413
(you can get high resolution scans of the book in JPEG2000 format if you click on “SINGLE PAGE PROCESSED JP2 ZIP”)
There are lots and lots of old books on Archive.org and many have OCR mistakes when downloaded as a PDF.
Could it be added to English, but only used if the resolution was hight enough to clearly distinguish “ſ” from an “f”, to clearly detect that there aren't any traces of a line on the right side?
That could help someone a lot to digitalize old books more accurately, without having to do lots and lots of manual corrections.

Try script/Fraktur or frk – both contain the long S (ſ) and some ligatures which are also needed. In addition, using a different word list is useful for old texts (otherwise Tesseract finds words like "Google" even in historic texts.

Maybe you are interested in a German project which has a focus on OCR for historic texts, see https://github.com/OCR-D.

I forgot that there is also enm, the trained data for old English which also has the long S. Here is the complete list of all languages and scripts with that character:
enm/enm.lstm-unicharset:ſ 3 0,255,0,255,0,0,0,0,0,0 Latin 20 0 90 s	# ſ [17f ]a
Fraktur/Fraktur.lstm-unicharset:ſ 3 0,255,0,255,0,0,0,0,0,0 Latin 20 0 90 s	# ſ [17f ]a
frk/frk.lstm-unicharset:ſ 3 0,255,0,255,0,0,0,0,0,0 Latin 13 0 82 s	# ſ [17f ]a
frm/frm.lstm-unicharset:ſ 3 0,255,0,255,0,0,0,0,0,0 Latin 18 0 106 s	# ſ [17f ]a
ita_old/ita_old.lstm-unicharset:ſ 3 0,255,0,255,0,0,0,0,0,0 Latin 12 0 92 s	# ſ [17f ]a
spa_old/spa_old.lstm-unicharset:ſ 3 0,255,0,255,0,0,0,0,0,0 Latin 9 0 109 s	# ſ [17f ]a

@MaxPower85, can this issue be closed?

Hello I wonder how the ground truth for enm.traineddata was created, which font was used to produced the long s in historical text? And what datasets/text (that containing ſ and ſ?) were used to automatically generated the ground truth  ? Thanks.

also Æ for ae etc.

That's all available information: https://github.com/tesseract-ocr/langdata_lstm/tree/main/enm.
It contains some training text and a list of fonts.

Thank you! Is there way to know what is all the original ground truth used in the enm model training, and how the ground truth was created? This is related to https://github.com/tesseract-ocr/tessdata/issues/156
Thanks!

We simply don't know the answer as the training was done at Google and there are only some hints in several issues.

I see no issue at all.
The training files at https://github.com/tesseract-ocr/langdata_lstm/tree/main/enm look good and have long s.
Just a try with a page https://github.com/wollmers/ocr-deu-bio-testfiles/blob/master/naturgeschichte00gt/naturgeschichte00gt_0014.png in German Fraktur (typical 18th century):
ocr-deu-bio-testfiles/naturgeschichte00gt$ tesseract naturgeschichte00gt_0014.png naturgeschichte00gt_0014.l_enm -l enm --psm 6 --tessdata-dir  /usr/local/share/tessdata txt pdf hocr
Tesseract Open Source OCR Engine v5.0.0-alpha-773-gd33ed with Leptonica
Warning: Invalid resolution 0 dpi. Using 70 instead.

$ cat naturgeschichte00gt_0014.l_enm.txt | grep ſ
ben , miiſſen es bfters mehr dem Zufall als ihree
GeſcHicflichkeit verdanfen. Aber ſon genannte
Naturalien genauer zu beſhreiben und zu bes
ſtimmen , als bisher geſchehen, dazu iſt mehr
Gelegenheit vorhanden, und auch dieſe Bemys
bung iſt niiglich und verdienſilich.  Die ſeltenſten unter den hier bes
ſchriebmnen Vegeln befinden ſi in der hieſigen
* F$in{il. Phaſanerie, wo ich ſie nach Gefallen
beobachten und die Beobachtungen des Phaſa#- _
fi< von dieſen und den Ubrigen wohl erhaltene
meiner Aufſicht ſtehenden Naturalienkabinete
der Durchlauchtigſten Prinzeſſin Marie
/ Friederike zu Heſſen. Die Scthriftſteller
\ \ 4abl iſt} hier alle qu nennen; whrde gu weiclauſtig
\ ſein 3

Not the best quality as it isn't trained on German alphabet (äöüÄÖÜß), texts and typical typefaces, but it supports longs s.

Thank you. I don't have issue with the long S.. just wanted to know how the historical English ground truth for training was created, and what datasets were used. Thanks.


Command make init failing

Hello!
After cloning this repository, I try to execute the command
$ make init

I expect to see something like this:
docker-compose run --rm --user "1000:1000" app php ./artisan migrate --force --seed
Creating network "laravel-roadrunner-in-docker_default" with the default driver
Creating volume "laravel-roadrunner-in-docker_pg-data" with default driver
Creating volume "laravel-roadrunner-in-docker_redis-data" with default driver
Creating volume "laravel-roadrunner-in-docker_tmp-data" with default driver
Pulling postgres (postgres:13.2-alpine)...
13.2-alpine: Pulling from library/postgres

But I see something else:
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.app.depends_on contains an invalid type, it should be an array
services.cron.depends_on contains an invalid type, it should be an array
services.queue.depends_on contains an invalid type, it should be an array
services.web.depends_on contains an invalid type, it should be an array
Makefile:23: recipe for target 'init' failed

A part of docker-compose.yml
    depends_on:
      postgres:
        condition: service_healthy
      redis:
        condition: service_healthy

Hi! What is your docker-compose version?

Sorry to bother you, updated from 1.25 to 1.29
Everything is good.
Thanx.


docs: update project links in README

The repo was transferred from raccoongang organization to openedx one.
The README instructions should be updated to reflect the current state of the repo.

Hi @cmltaWt0! When you get a moment, could you add a brief description of the update to the top of the PR? Thanks!

Closing due the proposed changes are already in develop branch.


Create ambassador tls secret in organization namespace

Description
As a developer I want to create the ambassador tls secret in the organization namespace instead of default namespace for Quorum and Besu
Acceptance Criteria

Network deploys successfully without error
Ambassador tls secrets are create in org namespace
The services connect over tls

I'll take this issue


Integrate with Github pull requests

Is there a plan to make this tool integrate with Github's pull requests?
I work at FB right now and I notice that your tool is inspired by FB's workflow and I had the same idea of making a tool to replicate the same workflow with git and Github. Your tool seems to match pretty well what I'm looking for aside from being able to do code reviews of the commit before merging them in the main branch.

Hi @qwertzguy, I didn't have any specific plans to integrate with GitHub. Can you clarify more about the workflow you'd like to see? Do you mean as a maintainer, to try out pull requests locally, or as a contributor, to create and update pull requests?
You should be able to check out a remote pull request as per the docs here: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally. Then you can just commit/rebase/amend commits as normal.

And if I may ask, how did you hear about this project?

Hi @arxanas, I mean as a contributor. My idea of the workflow, would be one similar to FB:

Checkout master
Write code and make a commit
Create a PR for that one commit
Be able to checkout master again and work on another change and commit it
Create a 2nd PR for that one other commit
Be able to checkout the 1st commit to make fixes following the comments in the PR and update the PR

Let me know if that makes sense.
I found the project by typing 'git branchless' in Google. I typed that in to try to find tools to have a similar workflow as in FB but with git. So it's pretty by chance that I thought of searching using the same term as the name of your project :)

I found the project by typing 'git branchless' in Google. I typed that in to try to find tools to have a similar workflow as in FB but with git. So it's pretty by chance that I thought of searching using the same term as the name of your project :)

Perfect 😄
You should be able to use git-branchless in conjunction with Github. I recommend that you get the gh CLI client (https://cli.github.com/) for Github, so that you can do things like create a pull request from the command-line.
Fundamentally, you need to have a branch somewhere in order to interface with Github, since it serves as the canonical reference to the tip of the stack you want to send upstream. You have three choices, varying in how much you want to use branches:

Use branches as normal with a Github workflow. In this workflow, you'll check out directly to the branch and make commits there. When you're ready to update the pull request, you'll git push (or git push -f, if you rebased/amended/rewrote any commits). You would gain the nice visualization for git sl, but not much else.
Update your local branch only when you're ready to update the pull request. You would need to create the branch, but you wouldn't need to check it out. Understand you make your additional commits on top of the branch, you can squash them all together and run git restack, which will update the branch automatically, or you can manually move the branch with git branch -f. Then run git push/git push -f as normal. This is how I prefer to work with Github.
Only create a branch in your remote repository. Then, you can update it to an arbitrary commit using an invocation like git push origin HEAD:my-branch (I think). If you hate branches, then this is the way to go.

The Phabricator diff number D123 is surfaced in the smartlog. I would be open to adding a similar mechanism to surface which Github issues/pull requests are addressed in the commit message.

Yea I was thinking of option 3 and having a tool that automatically does
the work of generating a remote branch name and keeping the mapping between
commit and remote branch name in order to update PRs. And like you
suggested, I was also thinking of having the pr number show up in the
smartlog (ideally with status and number of comments) and even have a
command to open it in the browser.
On Thu, Apr 1, 2021, 16:37 Waleed Khan @.***> wrote:

I found the project by typing 'git branchless' in Google. I typed that in
to try to find tools to have a similar workflow as in FB but with git. So
it's pretty by chance that I thought of searching using the same term as
the name of your project :)
Perfect 😄
You should be able to use git-branchless in conjunction with Github. I
recommend that you get the gh CLI client (https://cli.github.com/) for
Github, so that you can do things like create a pull request from the
command-line.
Fundamentally, you need to have a branch somewhere in order to
interface with Github, since it serves as the canonical reference to the
tip of the stack you want to send upstream. You have three choices, varying
in how much you want to use branches:

Use branches as normal with a Github workflow. In this workflow,
you'll check out directly to the branch and make commits there. When you're
ready to update the pull request, you'll git push (or git push -f, if
you rebased/amended/rewrote any commits). You would gain the nice
visualization for git sl, but not much else.
Update your local branch only when you're ready to update the pull
request. You would need to create the branch, but you wouldn't need to
check it out. Understand you make your additional commits on top of the
branch, you can squash them all together and run git restack, which
will update the branch automatically, or you can manually move the branch
with git branch -f. Then run git push/git push -f as normal. This is
how I prefer to work with Github.
Only create a branch in your remote repository. Then, you can
update it to an arbitrary commit using an invocation like git push
origin HEAD:my-branch (I think). If you hate branches, then this is
the way to go.

The Phabricator diff number D123 is surfaced in the smartlog. I would be
open to adding a similar mechanism to surface which Github issues/pull
requests are addressed in the commit message.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arxanas/git-branchless/issues/4#issuecomment-812233094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQPCYBC52KWIJCAXCDUHK3TGT7R3ANCNFSM42GIXMFQ
.

Integrating with Github sounds strategically useful for the project. But I think there are a lot of design decisions that would need to be resolved first.

What should the interface for git-branchless be for managing pull requests?

It should be decided how this relates to gh pr.
Should it be a default aliased command, or should users write something like git branchless pr in order to invoke it? I don't want to add confusion with gh pr.
Do you have to run the command once to create the PR (essentially the same as gh pr, except that we may create a branch name)? And then again to update the PR? Or should we create different commands?

Generating a branch: I think it would be best to generating a local branch as well. After all, local branches already have a mechanism to keep up to date with remote branches. If we don't reuse the branch name, then there are a number of additional problems we have to solve:

Keeping the PR associated with a commit in sync with rewritten versions of the commit.  We would have to add an implicit or explicit way to move around or copy the PR reference for the commit.
When you add a commit to a line of development, it's unclear if the entire stack should be associated with the PR, or the commit which was previously associated with it. More generally, it's not clear if people have a one-commit-per-PR workflow or a many-commits-per-PR workflow. Branches solve this by not moving the branch unless it's checked out when you make the commit.
When you add multiple descendant commits to a line of development, it's even more unclear which of the descendant commits should be associated with the PR. Branches also solve this, since it's explicit which commit is associated with the PR.

Showing the PR number: showing the PR number might be possible without hitting the network, if the PR number is encoded in the commit somehow.

You could put it in the commit message, in the same way as Phabricator diff numbers are put in the commit message, but I imagine there will be some projects with strict commit message requirements that won't like that.
It might be best to use the branch name to encode the PR. Actually, then, you wouldn't need a separate field for the PR at all.

Showing the status/number of comments:

It would take a while to render the smartlog if we have to hit the network. I recall that Facebook solves this by having a separate hg ssl command, which will take longer to render. We could also just have the user configure whether or not they want their smartlog to hit the network.

Alternatively, it would be nice if we could somehow update the already-displayed output using some fancy terminal-drawing, but I don't see a way to make it work if more output was produced than can fit in the terminal window.
Or, we could show the networkless smartlog first, and then wait on the network request. The user can either cancel with ctrl-C, or we can re-print the smartlog output with the live Github information once it's available.

If we hit the network, we may want to make sure that the user has a Github authentication token, so that we're less likely to cause them to hit a rate limit.
From the UI perspective, it's a lot of information, and I'm not sure where we would want to put it in the smartlog. I experimented a while ago with having more than one status line per commit, but it was pretty hard for me to read. We might want to try it again — it might be that only showing additional metadata for commits which are linked to a Github PR is not too unwieldy.

Command to open in browser: this might be better solved by the user's terminal emulator. For example, iTerm 2 has "smart selections", which are what I use to automatically open Phabricator reviews in the browser (like this: https://hlung.medium.com/using-smart-selection-in-iterm2-to-make-asana-task-id-or-any-text-clickable-dddbbbe2bbe8). If we reuse the branch name to encode the PR number, then perhaps we wouldn't need to surface additional information at all.

I've been thinking quite a bit about it, but I'm a bit torn on which solution to use. Ideally I would want something close to the workflows at FB, but at the same time it does not match the github workflow well: for example github doesn't support amending a commit in a PR well, it will replace the commit but not let reviewers view previous versions of the commit.
Here are some thoughts on your points:

Since we'll likely be automating some of the PR creation process, I think it should be something like git branchless pr with a different syntax than gh pr.
I think generating a local branch could be ok, but for most IDEs, it then doesn't show if you are behind on the main branch (or whichever is the branch you made the new branch from).

If we don't do a local branch and instead move the local main branch pointer when user switches from one branchless commit to another, then IDEs will be able to use origin/main as the upstream and make it easier to see if there's commits that have been pushed on the remote and easier to rebase. We can then track the commit using the main branch and save the commit hash when the user changes to another branchless commit. As far as where to keep the info about the remote branch and PR, I think it can be in .git/config which already has info for each local branch, and I think we can put our own config in there which would not be a local branch config, but more of a per commit config.
I think per commit PR would be best to match the FB workflow and gerrit workflow, which I like. However it does make it a bit harder, as then we would need to make one remote branch per commit and then have PRs that have the previous commit's branch as the base branch, which might be a bit weird, and once the previous commit's PR gets merged, we would need to update the PRs of the descendant commits.
I think one branch per commit does help to address being able to update a commit: in github each commit in a branch is a bit like a version of a commit in phabricator, so we could auto rename the commits like v1, v2, etc. Problem though is it will make the git log pretty confusing. So not sure if that's good. Kinda bummer that github doesn't handle amending commits well.

I think we could store the PR info in .git/config
Another option could be that we cache the PR info results and have some daemon that can refresh in the background. Could be useful for fetching remote from time to time as well. Ad there could be a flag / command to force refresh synchronously.
Ah true, easiest would be to display the entire URL, that way there's no config needed in most terminal.

Definitely! I appreciate the discussion and I'm open to work on it. I just need to think a bit more about it and whether it fits well into your project. Out of curiosity: how were you planning to handle code reviews with your tool? Or is the idea to not have code reviews and push into the main branch directly?

I just need to think a bit more about it and whether it fits well into your project.

Github integration has a definite place in the project, given that most people using it will probably be using Github. At the very least, we should be able to reflect the work in progress on Github (e.g. linking commits to PRs somehow). We'll have to add write operations as necessary in order to support that workflow (e.g. creating/updating PRs).

Out of curiosity: how were you planning to handle code reviews with your tool? Or is the idea to not have code reviews and push into the main branch directly?

There's no specific code review workflow prescribed by the tool at present:

For repos which I own, I just rebase my work onto the local main branch once it's done, and then push to the remote main branch. Sometimes I create a local/remote branch pair to get a CI run on Github (example: https://github.com/arxanas/git-branchless/actions/runs/662701629 for the git-v2.31 branch, it fails the tests 😭).
For Github PR workflows, I make a branch for the PR/commit and push it to my fork as usual. Once merged/rebased into the remote main branch, I can fetch the remote main branch and rebase my work on top of it.
For the Phabricator workflow, I create a branch of development, and use arc diff (actually a company-specific tool arc multi-diff, which handles stacks) to create or update the code reviews on Phabricator. Later, they're reviewed by someone else, and I click the button in the Phabricator interface to submit the commit to the main branch. Finally, I fetch the remote main branch and rebase my work on top of it.

Currently, none of these workflows show review status. I use the Github/Phabricator website tooling to manage my in-progress reviews.

Since we'll likely be automating some of the PR creation process, I think it should be something like git branchless pr with a different syntax than gh pr.

Sounds good to me. We might want to take a step back and think more holistically about the workflow. For example, Phabricator uses a single command to both create and update code reviews (arc diff). Maybe we should have a single command like git submit, which submits a stack of work to the code review backend (Github/Phabricator/etc.)? It can also handle the case of updating all dependent PRs, as you mention later.
If we do so, we should decide whether we want to support the one-commit-per-code-review workflow, or the many-commits-per-code-review-workflow, or both.

I think generating a local branch could be ok, but for most IDEs, it then doesn't show if you are behind on the main branch (or whichever is the branch you made the new branch from).

That's disappointing, but won't that be an issue for people who don't use git-branchless as well? How do they handle their code review management when they don't know how far behind their branches are?
If we want, we can update git sl to show the number of commits ahead/behind our local lines of development are. (NB: an old version of git-branchless used to do this, but the ahead/behind calculation was pretty slow in large repositories. We'd have to pay attention to performance. There's a mergebase-caching mechanism specifically to address this point.)

If we don't do a local branch and instead move the local main branch pointer when user switches from one branchless commit to another

I really don't want to move the local main branch on behalf of the user. It should always represent the remote main branch. There's also the issue that if git-branchless crashes or gets into a bad state after a given command, then the user may not know how to remediate.

then IDEs will be able to use origin/main as the upstream and make it easier to see if there's commits that have been pushed on the remote and easier to rebase

An alternative is that we can have local branches which correspond to PRs always correspond to the remote main branch, which will enable this. Then, instead of git push to update the PR, we can use a theoretical git submit command to push it to the correct remote branch, rather than the remote main branch. (Although, I suppose this could be risky, because users who manually git push will push to the wrong branch... we could hook into the local pre-push hook to detect this case.)

As far as where to keep the info about the remote branch and PR, I think it can be in .git/config which already has info for each local branch, and I think we can put our own config in there which would not be a local branch config, but more of a per commit config.

I'm not sure if the approach you're proposing handles the evolution of commit: when you amend/rebase a commit, it's replaced with an entirely new commit object. I wrote https://github.com/arxanas/git-branchless/wiki/Architecture#commit-evolution to detail this further. What should the behavior be in the following cases?

 However, the commit-to-PR mapping only has an entry for the previous version of the commit. Should we prompt the user to add a new entry for the new commit object, or automatically do it?
A commit is combined with another commit (via a git rebase -i fixup), but they currently have separate PRs. Do we need to combine the PRs somehow?

Branches are a concept which the user is already familiar with, and which already has semantics in the git-branchless system, so I would like to reuse them as much as possible for this use-case as well.

once the previous commit's PR gets merged, we would need to update the PRs of the descendant commits.

This feature alone itself might be a killer feature for some Github users!

Another option could be that we cache the PR info results and have some daemon that can refresh in the background. Could be useful for fetching remote from time to time as well. Ad there could be a flag / command to force refresh synchronously.

So far, I've tried to avoid having long-running processes, as they significantly complicate the architecture. I would prefer to only add a synchronous update flag to git sl. Then the user can opt to always run with that flag (or alias git sl to do so), or they can do it only when they want an update on status. Thus, we won't sacrifice performance without an explicit opt-in from the user.

There's a lot of prior work in this thread: https://news.ycombinator.com/item?id=26913959

Got a busy these past weeks. The HN thread is interesting, especially ghstack. I wonder if using git branchless and ghstack together works.

It was made by a current Facebook engineer, so I'm hopeful that it fits our workflows!

Hi, I found this because I have a similar project with the same name: https://github.com/krobelus/git-branchless
I wonder if there is a better name for mine, since it has a smaller scope. Maybe git stacked-branches? :thinking:

Checkout master
Write code and make a commit
Create a PR for that one commit
Be able to checkout master again and work on another change and commit it
Create a 2nd PR for that one other commit
Be able to checkout the 1st commit to make fixes following the comments in the PR and update the PR

that is well supported by my tool. In step 4., you don't need to checkout master again, because  you don't switch branches in the first place. My git branchless adds branches to the Git object database without needing to ever check them out.
There's also an integration example on how to cherry-pick others' GitHub PRs to your local branch.

@krobelus whoops, I searched for "git branchless" before I named the project, and I thought I didn't find anything.
It looks like your workflow is a lot simpler for the common case where your commits don't conflict with each other! I suppose my workflow is better only if you want to do a lot of backtracking and make tree-structured histories. I'm not sure what a better name would be. git-treeful, git-forest, git-backtrack?
Maybe for yours, you could emphasize the single branch nature. git-monobranch, git-uberbranch? Or you could emphasize dividing the commits up after the fact. git assign, git divide, git partition, git-group, git-group-by? A name from the latter group would also suggest partitioning by other factors, such as splitting up the commits by which files were touched.

Right, my workflow doesn't offer a solution for the case when there are conflicts. Thanks for your suggestions, I'm leaning towards git bs now, since it's pretty similar to git ps (though I still need to try that).
(bit of a brain dump ahead, soz)
Yours is interesting - so the user can switch between commits they are not sure about, and the commits can have conflicts and shared history. Getting to any local commit is already possible via the reflog, but the interface can definitely be improved.
What I sometimes dislike about the reflog is that, when I'm searching around and check out some of entries, then reflog entry numbers are shifted. There is no git reflog pause to inspect the state of history without writing changing its state.. I imagine it might be nice to have something like Emacs' undo-tree, or a git bisect for the reflog...
The tree search terminology reminds me of CDCL, so.. is this conflict-driven commit learning? :laughing:
I like the concept of hiding commits, I wonder what's the best way to attach such metadata to commits.
I'm using commit messages; some other projects are creating new Git objects for metadata; at one point
I've thought about attaching Git notes (notes also survive rebase/amend). One important point
for me is that I want to integrate naturally with standard Git tools and workflows.


Add support for testnet addresses starting with x

Testnet addresses can start with x as well as y.
Should probably change this to an array, and adapt the code accordingly

I wonder how we'll handle this; do we simply choose the x/y prefix at random during key generation? Adding support for the extra character is fine, just not sure how we practically apply it.
Small bounty added!

I haven't dived into the code, but I think key generation works fine


Bad data causes RPC client disassociation in Mesos / Spark 2.0.2

[WARN] [dispatcher-event-loop-12]  TaskSetManager: Lost task 157.0 in stage 3.0 (TID 479, <IP_ADDRESS>): ExecutorLostFailure (executor 26 exited caused by one of the running tasks) Reason: Remote RPC client disassociated. Likely due to containers exceeding thresholds, or network issues. Check driver logs for WARN messages.
[ERROR] Lost executor 21 on *IP Address*: Remote RPC client disassociated. Likely due to containers exceeding thresholds, or network issues. Check driver logs for WARN messages.
Executor log entries only say what is being dropped until they are suppressed. Nothing useful in the driver logs.
My data set is on S3, about 50 part files in csv.gz format about 30G in total, with about .03% of the records not complying to the structure, and attempting to write into parquet.
I Tried:

Increasing / Decreasing memory in the driver and executors (made each executor as big as the data set, still didn't work.)
Decreasing the number of executors to watch all the logs.
Setting memoryOverhead to 2G
Pretty much all settings I could find.
Removing my schema and making inferSchema = false.

Works fine in my 2.0.0 Zeppelin instance too, same data.  Works fine for good csv.gz data.

Thanks for reporting this. Would you please file a bug report in Apache Spark JIRA?
Since Spark 2.0 CSV data source is distributed with Apache Spark.


Unable to list Roles via console with Oracle19c

Describe the issue:
Role list will be empty with Oracle19c, in Console > Manage > Roles
How to reproduce:

Configure Oracle as Primary user store
Login to console with superuser credentials
View roles (Manage)

Expected behavior:
Added roles should be display properly
Environment information

Product Version: 5.11 Beta 3
OS: Windows
Database:  Oracle 19c
Userstore: JDBC

@NilukaSripalim were you able to get the group list?
Also, are you using Oracle for the identity_db as well?


merge all VE repos back into the master

To centralize development and maintenance, including issue tracking, milestones, and the wiki for project management, we're bringing these projects back into the master project and re-arranging things a bit:
https://github.com/RSGInc/VisionEvalRPAT
https://github.com/RSGInc/VisionEvalSyntheticFirms
https://github.com/gregorbj/SimHouseholds
And then delete these repos and update the VE wiki as well

And delete old repos

@gregorbj - please delete the gregorbj/SimHouseholds repo since it is now here

Merged the VERSPM repo (was RSPM_VisionEval) and deleted the RSPM_VisionEval repo. Deleted the SimHouseholds repo. All repos now merged and old repos removed.


rewrite entity system using ashley

https://github.com/libgdx/ashley/wiki
https://www.youtube.com/watch?v=E4tZ7e032tI&ab_channel=Quillraven

We consider this done since all the old stuff was replaced with ecs


RadioPickerSettingsTile: label clickable and option for radio button on the left

I think it would be very convenient if the label of the radio button would be clickable to choose the radio button.
The second is more a preference, maybe an option would be possible to place the radio button on the left side?

Good idea. Could you please send a PR? Otherwise, I'll find some free time to implement it later.

Also currently not on my top priority, but will try to do it in the future!


Ignore broadcasted txs until fully synced

When syncing up at certain times you can observe a burst of failed to add broadcast tx errors being logged which I suppose means that the node is already accepting gossiped transactions and validating them. If possible, we could change this such that subscription to gossiped transactions is initiated once the node is fully synced. This can potentially speed up the sync process

Thanks for your advice.
That make sense.
We'll include this feature ASAP.

Associated PR #196

After a long period of testing, the same problem has not been found for the time being.


Spread operator does not copy Special attributes

This code comment indicates this is known, but I think they probably should be copied over if possible :-D
  /**
   * Implements the XHP spread operator in expressions like:
   *   <foo attr1="bar" {...$xhp} />
   *
   * This will only copy defined attributes on $xhp to when they are also
   * defined on $this. "Special" data-/aria- attributes will still need to be
   * implicitly transferred, since the typechecker never knows about them.
   *
   * Defaults from $xhp are copied as well, if they are present.
   */
  protected final function spreadElementImpl(

And indeed testing indicates they are not copied:
hphpd> $foo =
;
$foo =
;
hphpd> $bar =
;
$bar =
;
hphpd> =$bar
=$bar
xhp_div Object
(
    [tagName":protected] => "div"
    [attributes":"xhp_x__composable_element":private] => HH\Map Object
        (
            [class] => "baz"
        )

    [children":"xhp_x__composable_element":private] => HH\Vector Object
        (
        )

    [context":"xhp_x__composable_element":private] => HH\Map Object
        (
        )

    [source] => ":1"
)

@ngavalas : do you know why we're doing this? The typechecker also never knows about them when they're explicitly copied.

Confirmed we can do this; originally done in case the typechecker wasn't aware of these, but it is.
https://github.com/facebook/hhvm/blob/d47b5f1d3bfae307bd2acfaaff1b6ceb7a473538/hphp/hack/src/naming/naming_special_names.ml#L171
related to #230


[bug?]: CLI model import results in an error!

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
12
What happened?
Imported custom weights via the CLI import results in an error and defaults back to Stable Diffusion 1.5 Weight (model).
Screenshots
--web was specified, starting web server...
Initialization file D:\Stable Diffusion\Invoke Application\invokeai\invokeai.init found. Loading...
Started Invoke AI Web Server!
Default host address now <IP_ADDRESS> (localhost). Use --host <IP_ADDRESS> to bind any address.
Point your browser at http://<IP_ADDRESS>:9090/
System config requested
Model change requested: Stable_D
Current VRAM usage: 2.17G
Offloading stable-diffusion-1.5 to CPU
Scanning Model: Stable_D
Model Scanned. OK!!
Loading Stable_D from D:\Stable Diffusion\Invoke Application\invokeai\models\ldm\stable-diffusion-v1\v2-1_768-nonema-pruned.ckpt
** model Stable_D could not be loaded: LatentDiffusion.init() missing 1 required positional argument: 'personalization_config'
Traceback (most recent call last):
File "D:\Stable Diffusion\Invoke Application\invokeai.venv\lib\site-packages\ldm\invoke\model_cache.py", line 80, in get_model
requested_model, width, height, hash = self._load_model(model_name)
File "D:\Stable Diffusion\Invoke Application\invokeai.venv\lib\site-packages\ldm\invoke\model_cache.py", line 233, in _load_model
model = instantiate_from_config(omega_config.model)
File "D:\Stable Diffusion\Invoke Application\invokeai.venv\lib\site-packages\ldm\util.py", line 90, in instantiate_from_config
return get_obj_from_str(config['target'])(
TypeError: LatentDiffusion.init() missing 1 required positional argument: 'personalization_config'
** restoring stable-diffusion-1.5
Retrieving model stable-diffusion-1.5 from system RAM cache
Retrieving model stable-diffusion-1.5 from system RAM cache
Current embedding manager terms: *
Setting Sampler to k_lms
Additional context
No response
Contact Details
<EMAIL_ADDRESS>

Can you provide the source where you get the weights file? Did you load other models? Maybe this model file contains errors

https://huggingface.co/stabilityai/stable-diffusion-2-1/blob/main/v2-1_768-nonema-pruned.ckpt

Stable Diffusion 2 is not supported yet.


Update manifest migrate command to go from istio/istio helm values.yaml to new IstioOperatorSpec

The main task for 1.5 will be to migrate helm users to new operator API (WIP in https://github.com/istio/api/pull/1177). Most of the work will probably be on the destination schema side, as istio/istio values.yaml should be very close or the same as istio/installer. But this also needs to be verified.

change merged: https://github.com/istio/istio/pull/20542


visible confusion

Called a level gay insultingly after people were talking about some glitches it had
Originally posted by @Agent-11 in https://github.com/sm64js/sm64js/issues/565#issuecomment-950043441
visible confusion moment...

Just closing it so it doesn't clog up the open section.


ImageData::PreScale gives unnecessary errors if pixScale fails

Current Behavior:
If for whatever reason, pixScale fails in the ImageData::PreScale function in src/ccstruct/imagedata.cpp, it gives an error message after checking if (pix == nullptr).  But if that is the case, then the next lines, calling pixGetWidth(pix) and pixGetHeight(pix) also give error messages.
Suggested Fix:
Perhaps immediately return nullptr if pixScale fails?  I'm not sure what would be best here.  There are still further error messages which will appear here in this case, in any event.

Can you give example/test case how to trigger this problem?

Well, I sort of can and I sort of can't.  I have been delving into the code quite deeply, and have written a major patch to the 4.1.1 version to handle low-resolution images (though I'm still not convinced whether it's worth the effort).  There's a case I'd overlooked in my code, so at this point, the pixScale occasionally failed (or actually what I'd replaced the pixScale with).  And this therefore set pix to nullptr, so I got error messages from the next two lines of code.  Now, in the real tesseract code, it is highly unlikely for pixScale to fail, so it is highly unlikely that this bug will show.  But there is already a test for pix == nullptr a couple of lines later anyway; my thought was that it doesn't seem worth generating the extra lines of error messages (about pixGetWidth/Height) in this case.  It is really minor, though!

ok

https://github.com/tesseract-ocr/tesseract/issues/590#issuecomment-423772964 mentions the same problem.

pixScale fails if the scale factor reduces the image size and the resulting image would be less than one pixel high or wide.


Future#await return self after complete

Fix #1607

Current coverage is 96.16% (diff: 100%)

Merging #1614 into master will not change coverage

@@             master      #1614   diff @@
==========================================
  Files            89         89
  Lines         10862      10862
  Methods           0          0
  Messages          0          0
  Branches       1826       1826
==========================================
  Hits          10445      10445
  Misses          274        274
  Partials        143        143

Powered by Codecov. Last update 3d5daff...1af9d1b

@danieldietrich JavaDoc fixed
@paplorinc I don't have any real-world application for this method yet. But I inline call to await() in FutureTest

Great, thanks :)


Write a C++ program to convert days to weeks

Description
Write a C++ program to convert days to weeks
1 week = 7 days
Input  : 35
Output : 5

How to contribute

Save the solution in program/ConvertDaysToWeeks.cpp file
Add ConvertDaysToWeeks.cpp file in convert-days-to-weeks folder

!assign


New release tag format (e.g. "1.17.0-dev.0.0") not detected by flutter tool

NOTE: This was fixed with both #53775 and #53715, if cherry-picking the fix include both.
I suspect this is because we use a regex on git tags in the flutter tool to detect tagged releases, which the new tag does not match.
~/git/flutter$ flutter doctor -v
[✓] Flutter (Channel master, v1.16.4-pre.46, on Mac OS X 10.15.3 19D76, locale en-US)
    • Flutter version 1.16.4-pre.46 at /Users/fujino/git/flutter
    • Framework revision 730a440fd5 (12 minutes ago), 2020-03-31 16:26:01 -0400
    • Engine revision 6b09714a2c
    • Dart version 2.8.0 (build 2.8.0-dev.18.0 11d6bc6055)

~/git/flutter$ git tag | grep 'dev'
1.17.0-dev.0.0

UPDATE: The problem code is:
    return parse(_runGit('git describe --match v*.*.* --first-parent --long --tags', processUtils, workingDirectory));

@tvolkert did you use the roll_dev.dart script (or its internal wrapper) to publish this?

Hmm, I'm guessing this was a manual tag

Yep, manual tag. (for now - gonna update scripts after I've documented all the changes to the publishing)

/cc @jonahwilliams
I don't know if this is one, but I wanted to note that we need to be careful of places where the tool needs to be able to handle both the old and the new version string formats.

Could we tag the releases with both naming schemes for now, until the update percolates everywhere? Alternatively, we need to wait up for the tool fix for now

I'm gonna wait for the tool fix and mark 1.17.0-dev.0.0 as bad, since it's only on dev for now.

FYI, I'm going to publish another dev release that still contains this bug despite it being TODAY, to at least ensure that our dev build is signed on MacOS.

FYI, I'm going to publish another dev release that still contains this bug despite it being TODAY, to at least ensure that our dev build is signed on MacOS.

SGTM

Thanks, Chris!

also need #54217 for CP


Allow modeling "done.invoke" events for model.assign(...)

This PR allows you to specify 'done.invoke' as a restricted event type for modeling inline model.assign(...) actions in onDone blocks:
const model = createModel(
  {
    name: ''
  },
  {
    events: {
      SOME_EVENT: () => ({})
    }
  }
);

createMachine<typeof model>({
  context: model.initialContext,
  invoke: {
    src: () => new Promise((res) => res(42)),
    onDone: {
      // No type errors!
      actions: model.assign(
        {
          name: (_, e) => e.data
        },
        'done.invoke'
      )
    }
  }
});

Shouldn't you also be able to type things explicitly?
Doing something like this doesn't seem to work when you have events defined in your model:
            actions: myModel.assign(
              (ctx, event: DoneInvokeEvent<MyResult>) => ({
                count: event.data.n,
                msg: event.data.s
              })
            )

https://codesandbox.io/s/explicit-invoke-done-event-typing-kf0dt?file=/src/index.ts

Shouldn't you also be able to type things explicitly?
Doing something like this doesn't seem to work when you have events defined in your model:
            actions: myModel.assign(
              (ctx, event: DoneInvokeEvent<MyResult>) => ({
                count: event.data.n,
                msg: event.data.s
              })
            )

https://codesandbox.io/s/explicit-invoke-done-event-typing-kf0dt?file=/src/index.ts

The current problem is that DoneInvoke events don't have a type, so you can't narrow it this way.

Hmm.. would it make sense to be able to declare your invoke events in your model with your other events?

Hmm.. would it make sense to be able to declare your invoke events in your model with your other events?
Or something like:
events: {
  ...
},
invoke: {
  'myInvoke.done': {foo: '', bar: ''},
  'myInvoke.error': {msg: ''}
}

Just brainstorming..
And also by default the model's eventtype could include generic event types for the different invoke events.. then you'd be able to do what I was trying to do?

Yeah, that can probably be covered in another PR. It's something I also want to support.

@Andarist This is ready for re-review

@Andarist When you get the chance, can this be re-reviewed? It's not perfect, but it's a stop-gap solution to a problem many are facing with onDone transitions.

We phased out createModel API so no new additions to it are planned.


Icon request: ZEBEDEE

URL of the site or app
https://zebedee.io/
Logo resources for the icon
https://zebedee.io/press
Anything else?
No response

The press kit page has multiple versions of the logo, i.e., a "ZBD" and "ZEBEDEE" version. I figure the ZBD version is probably better for this application but I created icons for both just in case.
Hope this helps.
ZEBEDEE Version
This is the logo used predominantly on the https://zebedee.io/ site, but the text might be too small? See alternate version below.

ZEBEDEE.zip
ZBD Version (Alternate)
ZBD logo that's probably more legible at a small size.

ZBD.zip
Background Color
I used the purple color taken from the ZBD media kit, as purple seems to be the dominant color on the https://zebedee.io/ site. Specifically, #916FF7.

ZBD-Media-Kit.zip

Thanks! I'll use ZBD one. If somebody will add this to the repo, their common logo is ZBD

Added ZBD logo icon to the repo, with smaller logo
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/ZEBEDEE.svg


[mqtt_statestream] Exception thrown with each state change.

Home Assistant release (hass --version):
0.55.2
Python release (python3 --version):
3.6.1
Component/platform:
mqtt_statestream
Description of problem:
After adding mqtt_statestream to configuration.yaml, exceptions (~10), all the same, are thrown at startup. Then same exception thrown when a state changes.
Expected:
No exceptions.
Problem-relevant configuration.yaml entries and steps to reproduce:
mqtt_statestream:
  base_topic: homeassistant
  publish_attributes: true
  publish_timestamps: true

Add above to configuration.yaml.
Start hass. Exceptions will be logged.
Change the state of something to see the exception generated again.

Traceback (if applicable):
2017-10-17 14:11:35 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.6/asyncio/tasks.py", line 181, in _step
    result = coro.throw(exc)
  File "/usr/lib/python3.6/site-packages/homeassistant/core.py", line 1025, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/mqtt/__init__.py", line 411, in async_publish_service
    msg_topic, payload, qos, retain)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/mqtt/__init__.py", line 488, in async_publish
    self._mqttc.publish, topic, payload, qos, retain)
  File "/usr/lib/python3.6/asyncio/futures.py", line 331, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.6/asyncio/tasks.py", line 244, in _wakeup
    future.result()
  File "/usr/lib/python3.6/asyncio/futures.py", line 244, in result
    raise self._exception
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/paho/mqtt/client.py", line 1071, in publish
    raise TypeError('payload must be a string, bytearray, int, float or None.')
TypeError: payload must be a string, bytearray, int, float or None.

Additional info:
Apart from this the component seems to perform as expected, i.e. there are state messages published to the appropriate topics.

Duplicate of #9815.


GetObjectsByFolderName

GetObjectsByFolderName method of the ADF class currently accepts a folder name and compares with the target using equality.
A nice improvement would be to provide a folder patter and compare using "like" operator. This would help with subfolders.
Thanks

Interesting idea. This will not impact any existing usage, so simple improvement.


adds asset download page :: adds menu link

@kakax114 - have a look at the layout, I'll update the logos now as per our discussion...

@kakax114 also adding beekart's assets


some issues with code including python versions

doc needs to convert into string to proceed further for re
doc = str(doc).lower() # convert into string to handle error if input is else

while converting into binary from md5 encoding required to mention
h = bin(int(md5(token.encode('utf-8')).hexdigest(), 16)) # to handle encoding error

Python version update to call dictionary items in 3.0
 for _, token in token_dict.items():  # instead of iteritems() in python version 2.0 replaced with items() in python 3.0

if __name__ == '__main__':
    # Just for demonstration
    doc = data # {doc_id, doc}
    binary_hash = simhash(doc)
    print(binary_hash)

Hello @shoaib-intro. I am happy to review and merge a PR if you want to port the library to python 3.


Critical error about VAT amount is off in case of cart with multiple taxes

When I place an order and the cart contains products with several tax percentage, so for instance a product with 21% and a product with 9%, and there are shippingcosts calculated, a critical error occurs when placing an order:
[2020-06-17 19:13:16] request.CRITICAL: Uncaught PHP Exception RuntimeException: "Could not create a Mollie Payment Url, error: Could not create Mollie order, error: Error executing API call (422: Unprocessable Entity): Order line 3 is invalid.  Expected VAT amount to be €0.33 (€3.95 × (9.00% / 109.00%)), got €0.44. Field: lines.3.vatAmount. Documentation: https://docs.mollie.com/guides/handling-errors" at molliepayments/src/Handler/PaymentHandler.php line 200 {"exception":"[object] (RuntimeException(code: 0): Could not create a Mollie Payment Url, error: Could not create Mollie order, error: Error executing API call (422: Unprocessable Entity): Order line 3 is invalid.  Expected VAT amount to be €0.33 (€3.95 × (9.00% / 109.00%)), got €0.44. Field: lines.3.vatAmount. Documentation: https://docs.mollie.com/guides/handling-errors at molliepayments/src/Handler/PaymentHandler.php:200)"} []
I am using shopware version 6.2.2 and plugin version 1.0.14

Hello Alexander,
I quickly tested this on the same versions and I didn't get this error.
I will present this to our team to look if we can find the issue.

Hello Alexander,
Our team would like to know exactly what the context is.

What were the prices, quantities and VAT rates of the products in the shopping cart?
Is the customer in a customer group with net or gross prices?

Hey,
I ran into this error today myself. Fresh Shopware 6.2.2 with Mollie 1.0.15, no other plugins.
The root of the problem is, that the Mollie API only allows one value for tax per order line: https://docs.mollie.com/reference/v2/orders-api/create-order#order-lines-details
Shopware on the other hand permits an array of taxes per order line. Usually this does not apply, so the error does not occur. But there is one specific case where this happens. When there are different items with different tax rates the VAT for the shipping costs is splitted between all taxes.
Let's say there is one item which costs €10 and has 7% VAT and the other is another item in the cart which costs €20 and has 19% VAT and the shipping costs are €6 (including VAT). In this case the tax for the shipping costs is €2.00 * 0.07 + €4.00 * 0.19.
1. How to reproduce the error
I assume you have a clean Shopware with demo data and configured Mollie 1.0.15.
1st step
In the administration under Settings > Shop > Shipping: Make the standard shipping available to all customers and add shipping costs to it.

2nd step
In the adminstration under Catalogues > Products: Chose two products. In the field "tax rate" add "Standard rate" to one and "Reduced rate" to the other. Also make sure both products have "free shipping" disabled (enabled by default).

3rd step
In the storefront: Add both products to your cart and select standard shipping method. Make sure the shipping costs are greater than €0 and you have two different tax rates in the cart summary.

4th step
In the storefront: Send the order and you will recieve this error.

2. Causes
As I said above Shopware allows a list of taxes for an order line item while Mollie API only allows one value.
The source of the problem is the method getLineItemTax in the file src/Service/OrderService.php:
321    public function getLineItemTax(CalculatedTaxCollection $taxCollection)
322    {
323        $tax = null;
324
325        if ($taxCollection->count() > 0) {
326            /** @var CalculatedTax $tax */
327            $tax = $taxCollection->first();
328        }
329
330        return $tax;
331    }

As you can see the Mollie plugin just picks the first tax of the collection that Shopware sends. If there is only one tax everything is fine, but if there are multiple taxes obviously there is going to be a problem. Mollie picks the first one and applying only the first tax rate to the entire order line (shipping costs in this case) will not result in the same tax price as if the tax is divided in different tax rates as described in the beginning (example: €6 * 0.19 is not equal to €2.00 * 0.07 + €4.00 * 0.19).
3. Solution
We have overridden this method by the following code and for now everything is working (one day of testing)
321    public function getLineItemTax(CalculatedTaxCollection $taxCollection)
322    {
323        if ($taxCollection->count() === 0) {
324            return null;
325        } elseif ($taxCollection->count() === 1) {
326            return $taxCollection->first();
327        } else {
328            $tax = [
329                'tax'     => 0,
330                'taxRate' => 0,
331                'price'   => 0
332            ];
333
334            $taxCollection->map(function ($t) use (&$tax) {
335                $tax['tax'] += $t->getTax();
336                $tax['price'] += $t->getPrice();
337            });
338
339            if ($tax['price'] > 0) {
340                $tax['taxRate'] = $tax['tax'] / ($tax['price'] - $tax['tax']);
341            }
342
343            return new CalculatedTax(
344                $tax['tax'],
345                round($tax['taxRate'], 4) * 100,
346                $tax['price']
347            );
348        }
351    }

I hope this helps out.

@julian-kiener Did you see the response of @dl-mbegerau ? He describes the way to reproduce it. Can you fix this problem?

@alexbaat Yes I did see it. We are waiting for response from Mollie if this solution of @dl-mbegerau is the right one.

Hey, I hope you get a response soon.
Btw: We applied a little change to the code I mentioned in the original post.
this
339            if ($tax['price'] > 0) {
340                $tax['taxRate'] = $tax['tax'] / ($tax['price'] - $tax['tax']);
341            }

has been changed to
339            if ($tax['price'] != $tax['tax']) {
340                $tax['taxRate'] = $tax['tax'] / ($tax['price'] - $tax['tax']);
341            }
This condition is only there to avoid division by zero.
The original version didn't fix the problem for promotions (discounts). These had the same issue like shipping costs when applied to multiple products with different vat percentages only that the values are negative.

It seems unlogical that a product line item would have multiple taxes. Agree? So we could just focus on the issue with multiple shipping taxes. And I think a better solution would be to add to shipping lines to Mollie. It seems less error prone than calculating a fake tax. Also, I wouldn't know what a fake tax would mean for administration.

I don't think its unlogical. Right, in most cases a product has only the value-added tax. But there are lots of taxes out there and some products have multiple taxes like tobacco for example. If those have to be displayed or not in an online shop depends on the country I guess. But the payment gateway should be flexibel and cover each possible case, I believe.
You are right, the solution I propose is not ideal. But I think, it's the only way as long as the Mollie API only allows one tax per order line. I mean fake tax is probably not the right term, because the tax is not fake, only the tax rate does not correspond to a real tax because it's the average of multiple taxes.
It's not only shipping costs. Promotions cause the same exception. Probably there are more cases in the real world. The thing is, the current state causes an exception and does not permit the sale in any case where multiple taxes affect a single product. Also it leaves the customer and the shop owner with an error they can't really deal with.
 Otherwise you would have to create a special solution for shipping costs and promotions. And maybe in a couple of weeks someone reports another case and so on.
I'm really not an accounting expert, but the few shop or ERP systems I have used, all allow to add multiple taxes per product/order line.

@dl-mbegerau I've talked things over with Mollie and Klarna. They were both okay with the solution. So in the recently released version 1.0.17, I've implemented your method.


Installing database error

Hi, while installing database (Mage2 Related Product), I'm getting error:
SQLSTATE[42000]: Syntax error or access violation: 1072 Key column 'related_products_id' doesn't exist in table (SQL: alter table related_products add constraint related_products_related_products_id_foreign foreign key (related_products_id) references products (id) on delete cascade)

it should be just related_product_id. Anyway i fix it up soon


Broken animation and physics on certain NPCs

I have encountered a physics problem with FPS unlock embedded intp Flawless Widescreen. The birds in Stromveil Castle cannot throw the explosive barrels when you unlock your FPS. There’s just a “poof” animation and the explosive barrels thus stay intact.
Then I disabled the FPS unlock and the explosions worked again. So it might be breaking some stuff in your gameplay without even realizing.

This has already been addressed
#30


Refactor skip in Sobol, add warnings and improve doc

Address #953

Fix typo for Sobol' and extend documentation
Raise if ones tries to skip n != 2**m points
Warn about improper sampling (not a power of 2)
Default to randomize (better convergence properties)

Hello @tupui! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file skopt/sampler/sobol.py:

Line 170:80: E501 line too long (80 > 79 characters)
Line 252:80: E501 line too long (81 > 79 characters)

FYI, on top of the enhancements, I fixed some CI inconsistencies (mismatching python versions) and some tests in test_plots.py (wrong tolerance setting).

@holgern Thanks for handling this so quickly, really appreciate it 😃


Feature Request: Add Workspaces metrics

Created PR here: https://github.com/ivx/yet-another-cloudwatch-exporter/pull/381

Was merged and released. Thanks <3


Quaternion constructor should construct identity quaternion

As the title states. Right now it constructs an invalid quaternion, which would result in an assert if you were to use a default-constructed quaternion in the transform for a collision shape.
// Constructor of the class
Quaternion::Quaternion() : x(0.0), y(0.0), z(0.0), w(1.0) {

}

Btw, thank you for a splendid library! Very clean API, a breeze to work with 💯

Yes this is a good idea. I will make this change for the next release (version 0.7.0) of the library.

Is this issue solved simply by changing the constructor initialiser? I ran tests after making the changes - all succeeded. All testbeds work just fine.
If there are usages which could be broken, I am willing to look into it, but could really use some directions.
Otherwise, I will PR?

This issue is already solved in the "develop" branch. I will merge this branch into "master" soon in order to release the next version (0.7.0) of the library. I will close this issue only when it has been part of the "master" branch.

This is now available in the version v0.7.0 of ReactPhysics3D that has just been released.
Thanks a lot for reporting this.


Change orbconfig in-cluster with orbctl

Currently orbconfig in-cluster gets reconciled by orbiter, that should only changed by orbctl and the reload, by restart or config-reload

covered in #185


Why isn't this a private repository?

Organizations can't have private repositories unless they pay.

however, a student can make a private repository. Ex. robotics. They do not have to pay for a private org


On creating new customer, old data not being read by it.

Streamed data for a topic, and existing consumers are able to read. Then created new consumer but it is not able to read existing data(1min old), if new data is produced then it is able to read.

If your consumers are in the same group, and you store offsets, then that would be somewhat expected, no? Check your consumer group configuration and partitioning.

The consumers are in different group.  Basically I'm creating a consumer and assigning a group Id to it.
Consider a topic 'abc'. Data has been produced and existing consumer(ex: grp Id - Test1) was able to consume. And now adding a new consumer with different group Id(say Test2) is not able to read from existing topic 'abc'.

What did you set fromBeginning to? See https://kafka.js.org/docs/consuming#a-name-from-beginning-a-frombeginning for details.

I haven't set fromBeginning which means it is taking default false. So, since it's a new consumer(with a new group id), it should automatically read from offset 0. Isn't?

Actually, no :)
'fromBeginning' is looked at when there is no known saved offset (i.e. the situation you have with a new consumer group), and in that case 'true' means "use the earliest offset known to kafka", while 'false' means "use the newest offset known to kafka". With the default setting 'false' therefore you end up with your behavior, where you see all messages that came into the topic after your new consumer was created.
Try setting fromBeginning to 'true'.


[oap-shuffle]Fix multiple descriptions and  formats

The log info in PmofShuffleManager.scala
logInfo("Initialize RdmaShuffleManager")
should be
logInfo("Initialize PmofShuffleManager")

simplify boolean expression in BaseShuffleReader
By assert(pmofConf.enablePmem)

Delete inappropriate comments in PmemShuffleBlockResolver
// create ShuffleHandler here, so multiple executors can share
Does this really describe the intent of the current code?
So I deleted the comment.

Thanks


ROCm base image update

Motivation
Update base image of ROCm for deepseek-v3 better support
Modifications
As it is.
Checklist

[+] Format your code according to the Contributor Guide.
[+] Add unit tests as outlined in the Contributor Guide.
[+] Update documentation as needed, including docstrings or example tutorials.

@kkHuang-amd ,
Let's update parallel_state.py after this merged.
Thanks!


verify.py hangs on graph_subst.pb

verify.py hangs when running on TASO/graph_subst.pb. The problematic rules seem to be 99, 100, 130, 131.
I also noticed TASO/graph_subst.pb contains 132 rules in total, while the generated pb file has 819 rules. Could you help me understand the difference? Thanks!

I met the same problem.


Update ALM name in GitHub

RHUAP-409
Due to a name change of the Almighty project, GitHub paths and file structure needs to be changed accordingly. Dev will change the repo, but we will need to:

Update issues in almighty-ux to not use the name
Update links in GitHub issues that point to Jira, if they have the title
Update GitHub usage documentation
Update files/folders in almighty-devdoc/ux and verify links continue to work after Jira/InVision changes

GitHub: https://github.com/almighty/almighty-core/issues/345

repo moved to Fabric8


[fix] remove redundant line

Description
Remove the redundant code found in 11364
This change is quite straight forward since the results only relevant with build_window_nodes_from_documents
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code

gonna make the linter happy 😀


Create initial wiki structure for project plan.

Commit [2e13556] (https://github.com/olunet/SuperCap/wiki/_Project-plan/2e135565e6706ffec8aa1866d0754506659c6e19)

Work includes: description of roles, communication means, work process, scope.
Estimated: 2 man-hours


Invoking networks() results in STATUS_ACCESS_VIOLATION

fn main() {
   let sys_stat = systemstat::System::new();
   do_something(&sys_stat);
}

fn do_something(sys_stat: &systemstat::System) {
    let net = sys_stat.networks(); // crash (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)
}

platform: windows 11
version: 0.1.10

In the current version, networks do work for me on Windows 11.

Just tested again, it doesnt for me 🤷
https://github.com/Snazzie/systemstat-access-violation-bug

I'm getting the same issue. (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

I guess this only happens when there are enough network adapters to trigger it. I think I see the bug from a quick look at the code, can someone test db66afe0fd804?

@unrelentingtech yes, that fixed it 🎊 . I have 14 adapters on my machine (loads of virtual ones)


how can I access downloaded videos using a button in app ?

Currently, videos are exported to camera roll.

@kewlbear how can I access it in swift UI. I am new to swift UI. Can you provide me a code snippet

One way is to modify https://github.com/kewlbear/YoutubeDL-iOS/blob/632934f370e3dee5b9e8e58d1c824b647845a7c3/Sources/YoutubeDL/Downloader.swift#L185. If you don't want to modify the package, you may be able to monitor progress object and use hardcoded URL.


French translation of Intermediate Front End Development Projects

[ ] Build a Random Quote Machine
[ ] Show the Local Weather
[ ] Build a Wikipedia Viewer
[ ] Use the Twitch.tv JSON API

Working on it

Issue moved to FreeCodeCamp/TranslationExpansion #69 via ZenHub


simple css update

Here is my contribution. It's not much because I'm still a beginner but I tried my best.

Looks good 👍  thanks for your contribution


Add trace()

Description
We advertise trace() in the User Guide as a debug tool wrapping Kint::trace() but it isn't actually there. This PR adds it to Common.php.
Checklist:

[X] Securely signed commits
[X] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[x] User guide updated
[X] Conforms to style guide

Userguide actually shows, Kint::trace(); as how to use it, but I'm fine adding this feature in. Just need to update the docs.

Ah I see - the subheaders misled me since the other two are global functions. Well it’s fine either way but if this seems good I’ll update that doc.

yeah, I think it's worth doing.

@lonnieezell All set!


Front-end Page implementations

Front end setup, CSS library, will suggest libraries with small file size or minimalist design like miligram  or other for faster load times and minimum js requirements.
Equally configure front-end React unit testing
Html implementation of Layout
Html implementation of login, signup, forgot password pages/widget

Hello what are the updates here?


handle some more cases of subclassing needing super() calls

When we generate our own constructor() for a class (which we do
when we need to declare any properties on it), we must also put
in a call to super().  But this is easy to get wrong so do our
best to avoid calling super() when possible.
Helps with issue #38 but doesn't close it.

I'm not really happy with how subtle this is (and especially the test case is pretty crazy feeling) but I think it is sufficient to get missive working through sickle so I am sort of ok with it.

LGTM. I think it's ok.
The problem is that we'll need type checking to really solve the super call part, which complicates things quite a bit. It'd be great if there was some Closure syntax that'd allow us to just invoke the super ctor with the correct args, but I don't think that exists.


Update the Ref DQM loading program to only send report to slack channel once a week (saturday)

but will send a report to slack channel if there is any error during data loading.

@azurebrd Thanks


chore: Add telemetry for resolved error message

Description

Adds errorID, tat and appsmith error code to plugin execution errors

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

Manual

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

/ok-to-test sha=007f477

As this only include telemetry changes and i have verified it in the event fired console log. I will add test plan approved label myself.


[QUESTION] How to Update to 3.0 with baremetal now?

Question
As the title says, I try to update my old 2.x version to 3.0 and this is not working as I did before anymore.
The page just keeps blank.
This here were the steps that worked for me in the past:
systemctl stop dashy
cd /opt/dashy
git merge
git pull origin master
npm install --ignore-engines
npm run build
systemctl start dashy

My dashy service file looks like this:
[Unit]
Description=dashy

[Service]
Type=simple
WorkingDirectory=/opt/dashy
ExecStart=/usr/bin/npm start
[Install]
WantedBy=multi-user.target

The service always tells me that there is still version 3.0 available as update and dashy keeps running as version 2.1.2.
Apr 21 08:17:44 dashy npm[554]:
Apr 21 08:17:44 dashy npm[554]: ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
Apr 21 08:17:44 dashy npm[554]: ┃ Welcome to Dashy! 🚀                                                       ┃
Apr 21 08:17:44 dashy npm[554]: ┃ Your new dashboard is now up and running at http://<IP_ADDRESS>:4000         ┃
Apr 21 08:17:44 dashy npm[554]: ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
Apr 21 08:17:44 dashy npm[554]:
Apr 21 08:17:44 dashy npm[554]: Using Dashy V-2.1.2. Update Check Complete
Apr 21 08:17:44 dashy npm[554]: ━━━━━━━━━━━━━━━━━━━━━━━━━━━
Apr 21 08:17:44 dashy npm[554]: ⚠ Update Available: 3.0.0
Apr 21 08:17:44 dashy npm[554]: ━━━━━━━━━━━━━━━━━━━━━━━━━━━

I want to mention that here are some warning during the update process:
root@dashy:/opt/dashy# systemctl stop dashy
root@dashy:/opt/dashy# git pull origin master
remote: Enumerating objects: 2035, done.
remote: Counting objects: 100% (1952/1952), done.
remote: Compressing objects: 100% (1643/1643), done.
remote: Total 2035 (delta 350), reused 1890 (delta 307), pack-reused 83
Receiving objects: 100% (2035/2035), 88.66 MiB | 5.67 MiB/s, done.
Resolving deltas: 100% (370/370), completed with 67 local objects.
From https://github.com/Lissy93/dashy
 * branch              master     -> FETCH_HEAD
   129c6d71..382f8f3e  master     -> origin/master
Updating 129c6d71..382f8f3e
error: Your local changes to the following files would be overwritten by merge:
        public/conf.yml
        yarn.lock
Please commit your changes or stash them before you merge.
Aborting
root@dashy:/opt/dashy# npm install --ignore-engines
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '>=16.0.0 <21.6.2' },
npm WARN EBADENGINE   current: { node: 'v21.7.1', npm: '10.5.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '8 || 10 || 12 || 14 || 16 || 17' },
npm WARN EBADENGINE   current: { node: 'v21.7.1', npm: '10.5.0' }
npm WARN EBADENGINE }

up to date, audited 1599 packages in 8s

155 packages are looking for funding
  run `npm fund` for details

79 vulnerabilities (1 low, 50 moderate, 23 high, 5 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

Category
Setup and Deployment
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this question hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

error: Your local changes to the following files would be overwritten by merge:
public/conf.yml
yarn.lock
Please commit your changes or stash them before you merge.
Aborting
This suggests that changes to the file conf.yml and yarn lock are not made because they are different on your system than on the git repo.
Please make a copy of conf.yml (and possibly other assets like images that you saved inside dashy) and remove the whole dashy folder and clone the repo again.
That is probably the easiest.
Otherwise save a copy of conf.yml and assets and run 'git reset --hard'

error: Your local changes to the following files would be overwritten by merge:
        public/conf.yml
        yarn.lock
Please commit your changes or stash them before you merge.
Aborting

This suggests that changes to the file conf.yml and yarn.lock are not made because they are different on your system than on the git repo.
But yarn.lock needs to be changes as there were changes in dependencies and upgrading them.
Please make a copy of conf.yml (and possibly other assets like images that you saved inside dashy) and remove the whole dashy folder and clone the repo again. That is probably the easiest. Otherwise save a copy of conf.yml and assets and run 'git reset --hard'

oh sry maybe I had to be more clear, I meant the warnings, not the errors :) Last ones are absolutly clear.
this part here:
root@dashy:/opt/dashy# npm install --ignore-engines
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '>=16.0.0 <21.6.2' },
npm WARN EBADENGINE   current: { node: 'v21.7.1', npm: '10.5.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '8 || 10 || 12 || 14 || 16 || 17' },
npm WARN EBADENGINE   current: { node: 'v21.7.1', npm: '10.5.0' }
npm WARN EBADENGINE }

oh... with the git reset --hard did the trick, thank you!

Great to see it's working for you!
As you can see, you are using a little bit to new version of node, I think in the docs it's even written that dashy needs the latest LTS version which is currently 20.x.x, but as you can see it even works with newer version, just with that note.
I think --ignore-engines was introduced to fix some dependency issue when upgrading some of them to more up-to date versions, but not entirely sure on that.


Help with Login please

Fatal error: Uncaught exception 'Exception' with message 'getAttestation Exception: HTTP Status Code != 200'
It's not working for me. What am I doing wrong?

Is the Casper service down? I'm getting this:
{
    "code": 503,
    "message": "DroidGuard Service Unavailable"
}

@modsfabio @wikizhao remove your auth files from the authData folder, and try to login. It should be everything ok, its working for me.
Regards

@mgp25 how often or in which period of time should I update de auth.dat?

Oh @mgp25 I think it's a bug of casper service. There is a '#' in my password. The post fields should be url encoded. : )

@LanchaBasualdo you dont' need to update the auth, you can keep it always

Ok. Thanks. Thing is I remember from last version that I had yo update de auth every 50min more or less.

On 7/9/2015, at 12:40, mgp25<EMAIL_ADDRESS>wrote:
@LanchaBasualdo you dont' need to update the auth, you can keep it always
—
Reply to this email directly or view it on GitHub.

@mgp25 I'm sorry but if I keep the auth.data fiel for more than 50 minutes a trying to get object from... message shows up, therefore not logging in

Still not working for me. I deleted the Auth dat files


Separate UPLC optimization from compilation

What we need is something like optimize :: forall a s . (forall s' . Term s' a) -> Term s a. This will allow us to use optimization with things like Plutarch.Pretty, for instance.

You can just wrap it in a term but it’s probably the plutarch pretty API that’s incorrect.

The Plutarch.Pretty API is the entire motivation for this.


Updated Config File

Updated the config file to have separate sections, and to include left and right IP addresses.

also we need to update the config imports in LEDSignHandler.js


fix(Accordion): log error if incorrect activeIndex type

As discussed in PR #3193, this fix ensures that an Accordion will log an error if the incorrect type is given for activeIndex.
The expected types are:

number if exclusive
array if not exclusive

It will not log in production.
At first I considered doing the logging in the same lifecycle method that is used in Dropdown, however it uses the now deprecated componentWillReceiveProps. That's why I chose to log it in componentDidUpdate
In #3193 we also discussed further documentation, but I noticed that there is already an example of how to use an Accordion when exclusive is false.
I chose to not fix the crash that might occur when clicking a panel if the incorrect type for activeIndex is given, as the warning will be printed beforehand. If you feel this should be fixed, let me know.
You may go ahead and close #3192 , as this logging fixes the issue I had with it.

Codecov Report

Merging #3199 into master will decrease coverage by 0.07%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #3199      +/-   ##
==========================================
- Coverage   99.92%   99.85%   -0.08%
==========================================
  Files         169      169
  Lines        2790     2798       +8
==========================================
+ Hits         2788     2794       +6
- Misses          2        4       +2

Impacted Files
Coverage Δ

src/modules/Accordion/AccordionAccordion.js
92.3% <75%> (-7.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b34d9b...3131498. Read the comment docs.

No worries, thanks for being a wonderful maintainer!


[Feature Request] Dark Mode

I do believe a dark mode will be a nice feature for EOL.date :)
btw i know we barely using (almost zero) bootstrap but with upcomming 5.3 series finally they are bringing
dark mode support. So i suggest to start using it whenever  they release it

Our theme supports it, but not automatically or easily.
There's a ready implementation at https://www.aronsommer.com/just-the-docs-dmt/#, https://github.com/just-the-docs/just-the-docs/issues/234, https://github.com/just-the-docs/just-the-docs/pull/302
We could probably read the browser preference in JS and set it automatically: https://usefulangle.com/post/318/javascript-check-dark-mode-activated.
We're now at zero bootstrap (I removed the last bits when we switched from jekyll-openapi to Stoplight Elements.

Hi @usta can you assign me this issue and guide me on how to run this project locally in order to solve this? I am new to open source contributions so I might need some assistance.

See https://github.com/endoflife-date/endoflife.date/blob/master/HACKING.md#development for setting up the site locally.
The approach from this comment seems reasonable.
You can use https://github.com/scikit-hep/scikit-hep.github.io/pull/114 as a reference.

If you need help filing a pull request, see https://jarv.is/notes/how-to-pull-request-fork-github/

@gabrielcannes are there any improvements about this issue ? Are you still working on this ?

Hi, no. I'm not working on this anymore. Sorry about that.
Em sáb., 23 de jul. de 2022 15:42, Ömer Fadıl USTA @.***>
escreveu:

@gabrielcannes https://github.com/gabrielcannes are there any
improvements about this issue ? Are you still working on this ?
—
Reply to this email directly, view it on GitHub
https://github.com/endoflife-date/endoflife.date/issues/1187#issuecomment-1193170747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKDCLA7XAZN7SC26VJ5QVFDVVQ4KDANCNFSM5WAKYUYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

To anyone wanting to pick this up for Hacktoberfest, please file a PR for this upstream - on the theme itself.

hello,
should i do theis with JS (and then getting the browser preference) or withe the JTD option?
@captn3m0

I'd like an approach that doesn't prevent us from upgrading to the upcoming JTD option (https://github.com/just-the-docs/just-the-docs/pull/1086/files).
It might be better to help on the upstream issue, so we can just have a regular theme upgrade to achieve this.