Packaging Error

I have been trying to package a level with this new plugin but I keep getting errors. Ill post the Output log here maybe someone can help.
LogUObjectHash: Compacting FUObjectHashTables data took   0.42ms
LogTurnkeySupport: Project requires temp target (ITwinForUnreal plugin is enabled)
LogLauncherProfile: Unable to use promoted target - ../../../../../../Users/TimvanNuland/Documents/Unreal Projects/Itwin_Plugin/Binaries/Win64/UnrealGame.target does not exist.
LogMonitoredProcess: Running Serialized UAT: [ cmd.exe /c ""C:/Program Files/Epic Games/UE_5.3/Engine/Build/BatchFiles/RunUAT.bat"  -ScriptsForProject="C:/Users/TimvanNuland/Documents/Unreal Projects/Itwin_Plugin/Itwin_Plugin.uproject" Turnkey -command=VerifySdk -platform=Win64 -UpdateIfNeeded -EditorIO -EditorIOPort=55970  -project="C:/Users/TimvanNuland/Documents/Unreal Projects/Itwin_Plugin/Itwin_Plugin.uproject" BuildCookRun -nop4 -utf8output -nocompileeditor -skipbuildeditor -cook  -project="C:/Users/TimvanNuland/Documents/Unreal Projects/Itwin_Plugin/Itwin_Plugin.uproject"  -unrealexe="C
:\Program Files\Epic Games\UE_5.3\Engine\Binaries\Win64\UnrealEditor-Cmd.exe" -platform=Win64 -installed -stage -archive -package -build -pak -iostore -compressed -prereqs -archivedirectory="C:/Users/TimvanNuland/Documents/Itwin Test" -clientconfig=Development" -nocompile -nocompileuat ]
UATHelper: Packaging (Windows): Running AutomationTool...
UATHelper: Packaging (Windows): Using bundled DotNet SDK version: 6.0.302
UATHelper: Packaging (Windows): Starting AutomationTool...
UATHelper: Packaging (Windows): Parsing command line: -ScriptsForProject="C:/Users/TimvanNuland/Documents/Unreal Projects/Itwin_Plugin/Itwin_Plugin.uproject" Turnkey -command=VerifySdk -platform=Win64 -UpdateIfNeeded -EditorIO -EditorIOPort=55970 -project="C:/Users/TimvanNuland/Documents/Unreal Projects/Itwin_Plugin/Itwin_Plugin.uproject" BuildCookRun -nop4 -utf8output -nocompileeditor -skipbuildeditor -cook -project="C:/Users/TimvanNuland/Documents/Unreal Projects/Itwin_Plugin/Itwin_Plugin.uproject" -unrealexe="C:\Program Files\Epic Games\UE_5.3\Engine\Binaries\Win64\UnrealEditor-Cmd.exe" -pl
atform=Win64 -installed -stage -archive -package -build -pak -iostore -compressed -prereqs -archivedirectory="C:/Users/TimvanNuland/Documents/Itwin Test" -clientconfig=Development -nocompile -nocompileuat
UATHelper: Packaging (Windows): Initializing script modules...
UATHelper: Packaging (Windows): Total script module initialization time: 0.13 s.
UATHelper: Packaging (Windows): Executing commands...
UATHelper: Packaging (Windows): Installed Sdk validity:
UATHelper: Packaging (Windows): Win64: (Status=Valid, MinAllowed_Sdk=10.0.00000.0, MaxAllowed_Sdk=10.9.99999.0, Current_Sdk=10.0.22621.0, Allowed_AutoSdk=10.0.18362.0, Current_AutoSdk=, Flags="InstalledSdk_ValidVersionExists")
UATHelper: Packaging (Windows): Scanning for envvar changes...
UATHelper: Packaging (Windows): ... done!
UATHelper: Packaging (Windows): Cleaning Temp Paths...
UATHelper: Packaging (Windows): BUILD SUCCESSFUL
UATHelper: Packaging (Windows): Setting up ProjectParams for C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Itwin_Plugin.uproject
UATHelper: Packaging (Windows): ********** BUILD COMMAND STARTED **********
UATHelper: Packaging (Windows): Running: C:\Program Files\Epic Games\UE_5.3\Engine\Binaries\ThirdParty\DotNet\6.0.302\windows\dotnet.exe "C:\Program Files\Epic Games\UE_5.3\Engine\Binaries\DotNET\UnrealBuildTool\UnrealBuildTool.dll" Itwin_Plugin Win64 Development -Project="C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Itwin_Plugin.uproject" -Manifest="C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Intermediate\Build\Manifest.xml"  -remoteini="C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin"  -skipdeploy  -log="C:\Users\TimvanNuland\AppData\Roaming\Unre
al Engine\AutomationTool\Logs\C+Program+Files+Epic+Games+UE_5.3\UBT-Itwin_Plugin-Win64-Development.txt"
UATHelper: Packaging (Windows): Log file: C:\Users\TimvanNuland\AppData\Roaming\Unreal Engine\AutomationTool\Logs\C+Program+Files+Epic+Games+UE_5.3\UBT-Itwin_Plugin-Win64-Development.txt
UATHelper: Packaging (Windows): Creating makefile for Itwin_Plugin (manifest 'C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Intermediate\Build\Manifest.xml' not found)
UATHelper: Packaging (Windows): Writing manifest to C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Intermediate\Build\Manifest.xml
UATHelper: Packaging (Windows): Building Itwin_Plugin...
UATHelper: Packaging (Windows): Using Visual Studio 2022 14.36.32542 toolchain (C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532) and Windows 10.0.22621.0 SDK (C:\Program Files (x86)\Windows Kits\10).
UATHelper: Packaging (Windows): [Upgrade]
UATHelper: Packaging (Windows): [Upgrade] Using backward-compatible build settings. The latest version of UE sets the following values by default, which may require code changes:
UATHelper: Packaging (Windows): [Upgrade]     CppStandard = CppStandardVersion.Default        => Updates C++ Standard to C++20 (Previously: CppStandardVersion.Cpp17).
UATHelper: Packaging (Windows): [Upgrade]     WindowsPlatform.bStrictConformanceMode = true   => Updates MSVC strict conformance mode to true (Previously: false).
UATHelper: Packaging (Windows): [Upgrade] Suppress this message by setting 'DefaultBuildSettings = BuildSettingsVersion.V4;' in Itwin_Plugin.Target.cs, and explicitly overriding settings that differ from the new defaults.
UATHelper: Packaging (Windows): [Upgrade]
UATHelper: Packaging (Windows): Determining max actions to execute in parallel (24 physical cores, 32 logical cores)
UATHelper: Packaging (Windows):   Executing up to 24 processes, one per physical core
UATHelper: Packaging (Windows): ------ Building 2 action(s) started ------
UATHelper: Packaging (Windows): [1/2] Link [x64] Itwin_Plugin.exe
UATHelper: Packaging (Windows):    Creating library C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Binaries\Win64\Itwin_Plugin.lib and object C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Binaries\Win64\Itwin_Plugin.exp
UATHelper: Packaging (Windows): spdlog.lib(async.obj) : error LNK2019: unresolved external symbol _Cnd_timedwait_for referenced in function "public: bool __cdecl std::condition_variable::wait_for<__int64,struct std::ratio<1,1000>,class <lambda_f596761ae2bdb7f673f1a3ad47018eba> >(class std::unique_lock &,class std::chrono::duration<__int64,struct std::ratio<1,1000> > const &,class <lambda_f596761ae2bdb7f673f1a3ad47018eba>)" (??$wait_for@_JU?$ratio@$00$0DOI@@std@@V<lambda_f596761ae2bdb7f673f1a3ad47018eba>@@@condition_variable@std@@QEAA_NAEAV?$unique_lock@Vmutex@std@@@1@AEBV?$du
ration@_JU?$ratio@$00$0DOI@@std@@@chrono@1@V<lambda_f596761ae2bdb7f673f1a3ad47018eba>@@@Z)
UATHelper: Packaging (Windows): cpr.lib(threadpool.cpp.obj) : error LNK2001: unresolved external symbol _Cnd_timedwait_for
UATHelper: Packaging (Windows): assert.lib(stringification.cpp.obj) : error LNK2019: unresolved external symbol __std_bitset_to_string_1 referenced in function "class std::basic_ostream<char,struct std::char_traits > & __cdecl std::operator<<<char,struct std::char_traits,32>(class std::basic_ostream<char,struct std::char_traits > &,class std::bitset<32> const &)" (??$?6DU?$char_traits@D@std@@$0CA@@std@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@0@AEAV10@AEBV?$bitset@$0CA@@0@@Z)
UATHelper: Packaging (Windows): assert.lib(assert.cpp.obj) : error LNK2019: unresolved external symbol __std_min_8u referenced in function "auto __cdecl std::_Min_vectorized(unsigned __int64 const * const,unsigned __int64 const * const)" (??$_Min_vectorized@$$CB_K@std@@YA?A_PQEB_K0@Z)
UATHelper: Packaging (Windows): C:\Users\TimvanNuland\Documents\Unreal Projects\Itwin_Plugin\Binaries\Win64\Itwin_Plugin.exe : fatal error LNK1120: 3 unresolved externals
UATHelper: Packaging (Windows): Total time in Parallel executor: 4.96 seconds
UATHelper: Packaging (Windows): Total execution time: 6.11 seconds
UATHelper: Packaging (Windows): Took 6,20s to run dotnet.exe, ExitCode=6
UATHelper: Packaging (Windows): UnrealBuildTool failed. See log for more details. (C:\Users\TimvanNuland\AppData\Roaming\Unreal Engine\AutomationTool\Logs\C+Program+Files+Epic+Games+UE_5.3\UBT-Itwin_Plugin-Win64-Development.txt)
UATHelper: Packaging (Windows): AutomationTool executed for 0h 0m 7s
UATHelper: Packaging (Windows): AutomationTool exiting with ExitCode=6 (6)
UATHelper: Packaging (Windows): BUILD FAILED

Hi Tim,
These issues should be fixed with the latest version of the Visual Studio 2022 compiler.
You are currently compiling with VS 2022 17.6, so please do the following:

update VS 2022 to latest version (17.12)
force UnrealBuildTool to use the latest version you installed: open the file "%appdata%\Unreal Engine\UnrealBuildTool\BuildConfiguration.xml" in a text editor and add this block inside the root  tags:

<WindowsPlatform>
<Compiler>VisualStudio2022</Compiler>
<CompilerVersion>Latest</CompilerVersion>
</WindowsPlatform>

Thank you for the information


Add session expiry logic

By default, sessions are 30 day 'rolling sessions' and the timestamp for when they expire is extended when they are accessed to keep them alive.
When sessions expire (ie after 30 days of inactivity), session object returns empty (as if there is no session) and users must sign in in again.
Cleaning up old sessions from the database is not currently handled by the default adapter, but I do intend to add some logic to do this (added @TODO).
The session expiry date can be changed by passing a custom updateSession() callback handler function in the options to the default adapter.

Using a custom updateSession() method with the default adapter, it is possible to specify other behaviour:
e.g.

Disable rolling sessions (e.g. force a new login every X days).
Create a session expiry date far into the future on initial sign in, so that they effectively never expire.
Set a decently long max expiry time (e.g. 90+ days) but only actually update the session expiry time if the current expiry time is < 30 days; so that sessions stay valid for 30 days (and at most 90 days of inactivity) so that idle sessions are valid for at least 30 days (and maybe longer) but you don't need to write to your session database as often (useful if slow/expensive).

Note: Adapter options are passed as second option to the default adapter (the first option being the DB connection details). This is probably confusing and might be a design mistake.
const adapter = Adapter.Default({ /* database object * /}, {
  updateSession: async (session, isNewSession) => {
    // 1st arg is the current session (or null) so it's easy to check current
    // expiry date, get user specific info, etc.
    // 2nd arg is true if this is a brand new session.
    //
    // Function should return an ISO date (e.g. toISOString) or false/null to
    // prevent an update from being applied; but should always return a session
    // if isNewSession is set or the sign in will fail.
  }
})

Relying on on Adapter options is a little obtuse / confusing and so I'm considering it an 'advanced option' right now. In future, we might change how session expiry dates and behaviour is set to make it easier.
Note: There are some other updates in this PR, that's just from the linter and some improvements to formatting of contributing guide.

I've pushed this change out as<EMAIL_ADDRESS>It includes the new Facebook profile from @LoriKarikari too, will test it on the example site later!

BTW, as there are no Acceptance Tests for this yet, this is an example of what you see in a session (and in the cookie) with the new version:

I went with a default of 30 days for expiry for now.
Wanted to get this feature in and a similar (shorter) expiry to verification emails as they are blocking features, and can come back and make it easier to configure later.
Definitely want to revisit this, to make it easier to customise in future. :-) It is still configurable in this release, just awkward to configure and I want to make it easier.


Detailed step by step guide to understand the csv report produced by locust

Problem statement

The documentation of locusts on apis and how to use it is very detailed and I am very thankful for all the contributors who contributed in making the documentation.
Understanding the csv report when locust is run in headless mode is very difficult, because understanding the percentile section and why does the total average response time drop for a GET request when the load increases is puzzling.
There are a lot of articles on how to use locust, but almost no detailed guide on interpreting the csv reports directly. Also I am running this in a restricted environment so I cannot push stats to graphite or any other database. I have no option but to interpret results directly from csv.

Feature request (documentation) :

I kindly request the official contributors to create a detailed documentation in the wiki section or would be great if someone could redirect me to an article where interpreting reports is collated.

doesnt seem to be any interest in this i'm afraid...


Issue with Favourites list on 1.36+

After updating SongCore to load v4 songs, favourites has been slightly buggy. This needs to be checked out asap.

is this the "fav list gets the regular songs list for some reason" bug

former


Sync eng/common directory with azure-sdk-tools for PR 1585

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1585  See eng/common workflow

/azp run java - template

/check-enforcer override


Create end-to-end tutorial for developers

The current keptn documentation is missing a very critical item. An end-to-end tutorial for developers that explains how to use keptn.
Let's say that I am a developer and I already have a cluster with keptn installed. I also have an application with a simple dockerfile. What should I do next in order to use keptn?

In the doc we have a section on Use Cases. This is a step-by-step tutorial on e.g: onbaording a service, running a delivery, self-healing ... -> https://keptn.sh/docs/0.3.0/usecases/
Is this what you are looking for?

@grabnerandi This starts from an existing project. What if I have a brand new project? Let's say only a dockerfile and source code. Is that enough? What are the possible values for shipyard.yaml? Do I also need another file apart from shipyard.yaml? What if I am using plain K8s manifests and not Helm? Will that work?
Basically what are the requirements for a project to be keptn ready? i.e. a hello-world from start to finish.

Understood. Our team is currently working on additonal blog posts on how to onbaord your custom services. We will make sure to highlight what the starting point of a keptn project is.
#1: keptn needs you to specify a shipyard file (your project) and then onboard your services -> as described here: https://keptn.sh/docs/0.3.0/usecases/onboard-carts-service/
#2:  keptn DOESNT build -> keptn requires an artifact already available in e.g: a docker registry. So - you would use some CI tool to build an artifact and push it to a registry. Once you have an artifact you would  tell keptn that there is a new artifact, e.g: through the keptn cli as explained here: https://keptn.sh/docs/0.3.0/usecases/onboard-carts-service/#send-a-new-artifact-and-watch-keptn-doing-the-deployment

@kostis-codefresh on a different note: Would codefresh be interested in collaborating around standardized application lifecycle events as we started to define in https://github.com/keptn/keptn-specification/blob/master/cloudevents.md

https://github.com/keptn/keptn.github.io/pull/235 addresses this. Closing.


JSON output?

JSON is kind of a lingua franca for data storage and serialization - I think it would greatly increase the interoperability with software written in other languages and make it easier to parse in languages with no good support for parsing EDN. Could it be possible to implement this?

It wouldn't be at all difficult to add. I'm really short on time lately, but if I have a spare hour I'll see about it. Clojure has decent JSON support, IIRC. You can do a bunch of things with EDN that JSON doesn't support, but I don't think bltool actually uses those features.

Added in release 0.2.2.


Transform origin for poppers

📝 Description
Transform origins will want to come from the arrow especially the case where the popper is slightly scaling into view.
In the case that a popper is positioned at the start or end, we can use the dimensions of the trigger to calculate where this will be
⛳ Current behavior (updates)
Transform origins for start and end placement variants are just at the start and end of the floating box
🚀 New behavior
Transform origins are now calculated so they are placed in the centre of the trigger
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information

Hi @xylophonehero,
Could show a demo of what a before and after looks like?

Before
https://user-images.githubusercontent.com/68996622/169564619-b01be5f7-0874-4a18-9d77-2b14985dc838.mov
After
https://user-images.githubusercontent.com/68996622/169564708-d3f2eac0-1c1a-41e4-8ac9-b4448be64e1d.mov

I did just notice that if the tooltip is small that the trigger then it doesn't work as well. If we get access to the arrow placement that would probably work better.
This was done in a private repo so can't share the code but I can put together a codepe next week

Thanks for the video @xylophonehero. Closing in favor of #100.
I managed to figure out how to use data from the arrow placement to compute the transform origin.

Nice looks good!


System.InvalidCastExeption

I recently started developing a VSIX extension for VS and possibly I am not doing it correctly but I keep getting an "InvalidCastExeption" when running "DTE dte = (DTE)ServiceProvider.GetServiceAsync(typeof(DTE));" because "...GetService..." is seemingly unavailable.
PS. I can understand that perhaps the documentation is intended for senior devs but I can't help but feel that you are doing yourselves a disservice by not lowering the barriers to entry, or perhaps I'm just retarded???

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb4ce0ea-fd74-c3f1-5154-00db7cacab01
Version Independent ID: 110c664a-cf94-0b5b-4052-3c96c5816452
Content: Walkthrough: Accessing the DTE Object from an Editor Extension - Visual Studio
Content Source: docs/extensibility/walkthrough-accessing-the-dte-object-from-an-editor-extension.md
Product: visual-studio-windows
GitHub Login: @gregvanl
Microsoft Alias: gregvanl

Reverted to VS2015, problem solved. My bad


Add support for JavaDoc tags @apiNote, @implSpec and @implNote

Description of the problem / feature request:
The rule InvalidTag reports false positives for JavaDoc tag @implNote.
Error message:
 [InvalidTag] Tag name `implNote` is unknown. If this is a commonly-used custom tag, please click 'not useful' and file a bug.

Feature requests: what underlying problem are you trying to solve with this feature?
Please support these tags: https://blog.codefx.org/java/new-javadoc-tags/
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
    /**
     * Detects variations of {@code rootProject.setName($string)}, as well as the Groovy setter shorthand
     * {@code rootProject.name = $string}.
     *
     * @implNote This expression does not guarantee matching left/right quotes or parentheses. For example, it will
     * match {@code 'Name"}, even though that is not valid Groovy or Kotlin syntax. Similarly, in allowing for Groovy's
     * parentheses-optional syntax for {@code setName $string}, this pattern makes both open and close parentheses
     * optional, rather than requiring neither or both, so it will parse an open parenthesis without a matching close,
     * and vice versa.
     */
     public class Tags {}

What version of Error Prone are you using?
2.4.0
Have you found anything relevant by searching the web?
No

I think this does work at HEAD, where the check is called InvalidBlockTag. That should be in 2.4.0.

In my build with 2.4.0 I still get the error message with InvalidTag: https://ci.jenkins.io/job/Plugins/job/analysis-model/job/master/1085/consoleFull
So should I simply deactivate the rule InvalidTag as it has been deprecated?

In my build with 2.4.0 I still get the error message with InvalidTag: https://ci.jenkins.io/job/Plugins/job/analysis-model/job/master/1085/consoleFull
So should I simply deactivate the rule InvalidTag as it has been deprecated?

Are you sure you're using 2.4.0? I think that check was deleted before that release: https://github.com/google/error-prone/commit/57915048ab23de6918857cb201fff372567812ec

Are you sure you're using 2.4.0? I think that check was deleted before that release: https://github.com/google/error-prone/commit/57915048ab23de6918857cb201fff372567812ec

Hmm, interesting. Seems that then my maven configuration is broken indeed. I must admit that from the readme I did not find out how to configure it correctly with maven and Java 8. Seems that an old version of error prone is picked up.

Hmm, interesting. Seems that then my maven configuration is broken indeed. I must admit that from the readme I did not find out how to configure it correctly with maven and Java 8. Seems that an old version of error prone is picked up.

@uhafner for a Maven configuration with Error Prone that is both JDK 8 and JDK 11 compatible you could have a look at this pom.xml The jdk8 profile shows what's necessary for Java 8. (Ignore the verification.skip reference.)

@uhafner for a Maven configuration with Error Prone that is both JDK 8 and JDK 11 compatible you could have a look at this pom.xml The jdk8 profile shows what's necessary for Java 8. (Ignore the verification.skip reference.)

Thanks @Stephan202, I actually found the bug in my configurations. I still used plexus-compiler-javac-errorprone which includes an old error prone version. Now everything is working correctly!

Thanks @Stephan202, I actually found the bug in my configurations. I still used plexus-compiler-javac-errorprone which includes an old error prone version. Now everything is working correctly!


X.L.PerWorkspace does not send messages to right sublayout until activated

Here I'll try to make a bit more formal and informative version of #76
Config that reproduces the bug
import XMonad
import XMonad.Util.EZConfig

main = xmonad def { workspaces = ["1", "2"]
                  , layoutHook = onWorkspace "1" tiled tiled
                  } `additionalKeysP`
                  [ ("M-b", broadcastMessage Expand)
                  ]
  where tiled = Tall 1 (1/2) (1/4)

Steps to reproduce

Start xmonad
Open two windows
Shift them to second workspace
Press "M-b"
Go to second workspace

Actual results
Two windows are half-splitted
Expected results
Left window should occupy 3/4 of width of the screen
My attemt to explain the bug
Definitions

A sublayout is one the arguments of PerWorkspace which are instances of LayoutClass
An active sublayout is the sublayout which is chosen by the Bool argument of PerWorkspace
A layout is activated when runLayout is called first time for it

Explaination
When PerWorkspace on workspace "2" is not activated, its first sublayout is always active(but after activation the second one will be active). So, when we send message to non-activated PerWorkspace, it retranslates it only to first sublayout but we want it to retranslate that message to second sublayout
Possible fixes

Get rid of this module and move its functionality into core(I know you're a bit conservative about changing stuff in core; and this fix still can have some problems(e.g. with dynamic workspaces))
Create third state(for no layout chosen; default state) and accumulate messages for sending them to active sub-layout after activated
Assume that's right behaviour and explicitely state in the docs that sending messages to non-activated layouts is undefined behaviour
Activate each layout after it have been created.
Any other suggestions?

Now I prefer another way(that is close to 4 but is more general): to send some "update" messages to layouts on early startup(just after layouts have been created) and after each WindowSet update(logHook?).
Does anyone has any thought on this?

logHook, yes.
We already fire the logHook very early; before the startupHook in fact, at least 4 times judging by my testing.

That's nice, so the only thing we have to do(if it's the right solution) is to send the "update" messages at the same time when we fire logHook and update all layouts when it fires. But it could be expensive, so I'm wary.


message_feed: Improve UI for revealing long messages.

Summary
This PR encompasses the following changes:

Replace the [More...] link with a button that says "Show more".
Replace the [Show Less...] link with a button that says "Show less".
In the condensed view, add fading to the bottom of the message to visually communicate that the message is truncated.

Fixes: #19157
Details
This PR takes message: Improve the UI for long messages. #19308  as the base, and tries to improve upon it. It fixes the merge conflicts and also tries to implement the feedbacks on it. The changes are:

The buttons are now rounded to match other buttons used in the UI, and hover animation is added. It made sense to keep the button borders the same bluish tint as we used the same color in the previous [More] links.

In condensed view, the fading now starts much lower, allowing for a clearer view of the condensed region.

The transitions are removed, for the two reasons,

Adding animations could possibly degrade the experience while having to browse through a ton of messages, the little time taken by the animations do add up in the long run, and given that we also support keyboard navigation, we would rather want it to be as snappy as possible.

It was problematic to animate the max-height property. The previous PR #19308 used a very high value of max-height (1000vh) to enable animations but that lead to a delay in the collapsing part of the animation, since the animation would only start to be visible once the max-height reaches from 1000vh to the actual length of the expanded message content region. The fix for this would be to to calculate the line height of each message and then dynamically add the max-height and transition properties.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Thanks for working on this @iiishitaaaa, but the original issue/PR were stale; our current plans for this part of the app are in https://github.com/zulip/zulip/issues/22801.


IllegalArgumentException: Cannot construct a Paragraph with an empty list of segments

Just have seen #592 but still having this problem.
Using 0.8.2.
Exception in thread "JavaFX Application Thread" java.lang.IllegalArgumentException: Cannot construct a Paragraph with an empty list of segments 	at org.fxmisc.richtext.model.Paragraph.<init>(Paragraph.java:43) 	at org.fxmisc.richtext.model.Paragraph.restyle(Paragraph.java:216) 	at org.fxmisc.richtext.model.GenericEditableStyledDocumentBase.lambda$setStyleSpans$7(GenericEditableStyledDocumentBase.java:164) 	at org.fxmisc.richtext.model.ReadOnlyStyledDocument.lambda$null$7(ReadOnlyStyledDocument.java:272) 	at org.reactfx.util.Tuple2.map(Tuple2.java:31) 	at org.fxmisc.richtext.model.ReadOnlyStyledDocument.lambda$replace$8(ReadOnlyStyledDocument.java:271) 	at org.reactfx.util.Tuple2.map(Tuple2.java:31) 	at org.fxmisc.richtext.model.ReadOnlyStyledDocument.replace(ReadOnlyStyledDocument.java:270) 	at org.fxmisc.richtext.model.ReadOnlyStyledDocument.replace(ReadOnlyStyledDocument.java:260) 	at org.fxmisc.richtext.model.GenericEditableStyledDocumentBase.setStyleSpans(GenericEditableStyledDocumentBase.java:158) 	at org.fxmisc.richtext.model.SimpleEditableStyledDocument.setStyleSpans(SimpleEditableStyledDocument.java:7) 	at org.fxmisc.richtext.GenericStyledArea.setStyleSpans(GenericStyledArea.java:1281)
It happens with large texts only, but no idea about the exact source.
EDIT:
Just found out it happens only if group #[^\n]*, which matches everything after a '#', is present and followed by an empty line.

I've tried to reproduce the error according to your edit but without success ?
Could you please provide a test case that fails, so that I can have a look.
Also are you sure you are using 0.8.2 because the line numbers in the stacktrace don't match the source code for that tag (or the master branch) ?

Also are you sure you are using 0.8.2 because the line numbers in the stacktrace don't match the source code for that tag (or the master branch) ?

I was using 0.8.2 (846kb), tried downloading again and got a 792kb jar. Don't know how that happened but now it works.


QC: what happens if no pagination have been detected?

what happens, if a document has no pagination? In this case, because the OCR has not discovered it?

https://treatment.plazi.org/GgServer/summary/A84EFFEEFF96FFE6FFC8FFB2176C451C

The QC error is about the metadata, and you can simply type in the pagination in the respective "Edit > Exit Document Metadata" dialog ... it's only that the metadata gizmo fills that filed automatically if page numbers are present.


Instruction for WildFly AS should be updated

Hello, I got into some problem latest asciidoctorj on WildFly. see:
UPDATE: sorry, wrong URL was pasted.
http://stackoverflow.com/questions/27904558/asciidoctorj-doesnt-work-on-wildfly-8-2-0-final

Hi,
I've created a new github project named asciidoctor-wildfly-docker in order to validate the required configuration in order to run Asciidoctor into WildFly.
This project gives you the possibility to execute tests into a Docker container in order to validate that Asciidoctor can convert AsciiDoc content to HTML and PDF output.
I'd love to have your feedback :
https://github.com/mgreau/asciidoctor-wildfly-docker

Hi that's great and simplifies a lot starting with the application, only one thing, could you add the Dockerfile you used to create the image? In this way everyone can modify it or see what is doing internally the image.

The Dockerfile is here src/test/resources/wildfly/v8.2/Dockerfile . For now, this is the only way to build create this image since it is not on Docker Hub.
One of the main goal is to execute those tests with severals versions of WildFly and others Applications Server like TomEE :)

We've got access to the Asciidoctor organization on DockerHub now! I'll setup the admins later today and notify you when it's ready for push.


Spam prevention: filter repetitive messages

Filter messages that are repetitive, such as when a user says the same thing twice without a different message in between.

Snippet of text to work with: https://github.com/carlbennett/BNRBot/issues/10#issuecomment-143406678

Resolved in e2ae40c8954fe5eceb9ae8a19dc6c085815a7a04.


Live specialist_document content item does not pass example validation

Attempting to update the aaib_report.json example with the currently live version for a prototype:

https://github.com/alphagov/govuk-content-schemas/blob/master/formats/specialist_document/frontend/examples/aaib-reports.json
https://www.gov.uk/api/content/aaib-reports/aaib-investigation-to-rotorsport-uk-calidus-g-pcpc

After updating and running bundle exec rake, the following error occurs:
vagrant@development:/var/govuk/govuk-content-schemas$ bundle exec rake
formats/specialist_document/frontend/examples/aaib-reports.json: had 1 error(s):
  The property '#/details/metadata' of type Hash did not match one or more of the required schemas. The schema specific errors were:

- anyOf #0:
    - The property '#/details/metadata' contains additional properties ["document_type"] outside of the schema when none are allowed
- anyOf #1:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #2:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #3:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #4:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #5:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #6:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #7:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #8:
    - The property '#/details/metadata/location' of type String did not match the following type: array
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #9:
    - The property '#/details/metadata/location' of type String did not match the following type: array
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #10:
    - The property '#/details/metadata/report_type' value "correspondence-investigation" did not match one of the following values: investigation-report, safety-bulletin, completed-preliminary-examination, overseas-report, discontinued-investigation
    - The property '#/details/metadata' contains additional properties ["aircraft_category", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #11:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #12:
    - The property '#/details/metadata/report_type' value "correspondence-investigation" did not match one of the following values: investigation-report, bulletin, interim-report, discontinuation-report, safety-digest
    - The property '#/details/metadata' contains additional properties ["aircraft_category", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #13:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #14:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
- anyOf #15:
    - The property '#/details/metadata' contains additional properties ["date_of_occurrence", "aircraft_category", "report_type", "location", "aircraft_type", "registration", "document_type"] outside of the schema when none are allowed
The following examples don't validate against their schemas:
formats/specialist_document/frontend/examples/aaib-reports.json

Looks like document_type was disallowed in the schema in https://github.com/alphagov/govuk-content-schemas/commit/8212a1e3551017fd3c3dbb0bf52b399f38869f56.
Most likely scenario is that after making that change, not all documents were republished to publishing-api. You could try republishing on integration to confirm.

@tijmenb Coming back to this today, I wonder how we can stop this happening in the future. Maybe something that periodically tests random content items are valid? Probably a better way.
It's hard to be confident that published content is in a valid state.

Yep, I think that would be a good idea. Another option is to validate the output of the content-store.
@kevindew thoughts?

Yeah - to be absolutely confident the validating of content-store output sounds like a good idea. Quite destructive though, but that would give frontend applications a greater assurance.
I guess though if we go down the route we want assurances before a 500 error.
Naturally best thing would be immutable schemas, I guess complexity/cost of implementation rules that out
So other ideas could be:

Forbidding at merging point updating a schema that is backwards incompatible with previous version (could always be forced with an admin merge for exceptional circumstances). To encourage new schemas for backwards incompatible changes.
Storing a date when a schema is generated and a date in the Publishing API for when last validated  to make it easier for Publishing API to be able to batch validate

Seeing a new issue when attempting to update examples to match live:
The property '#/links' contains additional properties ["finder"] outside of the schema when none are allowed in schema file:///var/govuk-sites/govuk-content-schemas/dist/formats/specialist_document/frontend/schema.json#
cc @thomasleese @kevindew

@fofr started having a look into this yesterday - is a little painful but will prioritise it.

pretty sure this is done

@mcgoooo Can you link to the fix if done?

Fix is here: https://github.com/alphagov/govuk-content-schemas/pull/585


Pub upgrade did not trigger analysis

Username: kasperl
I just ran 'pub upgrade' on a project which updated one of my dependencies. Then I started the project in Dartium, but unfortunately a constructor had changed so Dartium stopped with a NSM error. However, I didn't get any static warning in the editor before I chose 'Reanalyze sources'.
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.2.0.dev_05_15 (2014-02-24)
OS: Mac OS X - x86_64 (10.9.2)
JVM: 1.6.0_65
projects: 1
open dart files: 1
auto-run pub: true
localhost resolves to: <IP_ADDRESS>
mem max/total/free: 1996 / 266 / 162 MB
thread count: 31
index: 235202 relationships in 50083 keys in 260 sources
SDK installed: true
Dartium installed: true

Cannot reproduce; assumed stale.


add some ipython integration

http://ipython.org/ipython-doc/dev/config/integrating.html
we should at a minimum support a few of the repr*_() methods (latex, html)
we can probably get creative here. displaying distributions as histograms? once we have an idiagram object, that can be displayed as a venn-like diagram.
other ideas?

added in e6d8630a19949ff118d26bc90a9eeee990f8b275
would be very interested in a pr that made it nicer.


No applicable installer found

Describe the bug
Can't install anything, been trying to install DDU off the script and keep getting errors
To Reproduce
Steps to reproduce the behavior:
Run the script, click install packages, select anything, click install, see the error
Expected behavior
Expected it to install a program like before but it did not
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Have had this problem for over a month now, reinstalling winget does nothing as i've done that already several times with no success.

Yep can confirm, getting the same results.

I have the same issue.
Maybe its a problem with winget and the scope attribute. In winutil every package installs with scope "machine" (= install for all users). If the selected package is not approbriate for scope machine, then winget exits with this error "APPINSTALLER_CLI_ERROR_NO_APPLICABLE_INSTALLER". E.q. installing "HWInfo" works.

I have the same issue. Maybe its a problem with winget and the scope attribute. In winutil every package installs with scope "machine" (= install for all users). If the selected package is not approbriate for scope machine, then winget exits with this error "APPINSTALLER_CLI_ERROR_NO_APPLICABLE_INSTALLER". E.q. installing "HWInfo" works.

I can confirm that it's a scope issue: https://github.com/microsoft/winget-cli/issues/3936. I had to make changes and remove the scope when testing my changes in #1738.


Stackstorm UI being really slow and does not show certain options

Hi Team,
Our production stackstorm UI is not working fine from past couple of days (being a month now exactly) and it does not populate any data . Snippet below:

Even when it shows the data , it does not show some options as highlighted in the screenshot.

Can some one help on this?

Did you take a look for any errors in the web browser developer console?

Hi @armab
Thanks for replying.
I could see below errors:

But when i specifically click on actions and open any action and then look into execution , only then it shows the history. What could be the reason that it does not load on its own?

Hi
Could anyone help with this? It is the same and we are still struggling.

What's your setup? the UI just calls the API to retrieve the results. Do you have the same issues if querying executions using postman?

what does the command "st2 trace list" output
did you have a look at the log folder /var/log/st2

I am unaware of what to check in logs. Could anyone help here? With my new setup also , i am unable to access the UI and gives me gateway 504 error.

I don't know either what to look for, error 504 means stackstorm is never sending information to nginx. I can try to guess what you should look for, based on when this issue happens or what you were trying to do.
I'm pretty sure you are using the default install.

3 components of stackstorm interact with nginx, st2web uses st2auth to login then the rest is st2api.
The fact that you seem to be authenticated, indicates to me you should not look in st2auth, and probably look st2api.
essentially currently all you know is that st2api is not answering back to nginx and you want to find out why.
Look for an error at the end of the st2api log as soon as the error happens. Look at the time the log entry is created, try to find a message that seems to tell you why st2api is not responding.

I am getting nothing in the logs as well for the errors. It just logs the query when i login to the UI.

can you confirm you have looked at /var/log/st2/at2api.log


Secure a file's download route, so that unauthenticated access is denied

I would like to secure a file's "download" route (on the server) so an unauthenticated user cannot access it. I have tried using Meteor.userId() inside interceptDownload and it's not available, as it's not a Meteor method:
Error: Meteor.userId can only be invoked in method calls or publications.

Any suggestions?
Versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS>"aws-sdk": "^2.413.0"

Gah! Super simple, there is a protected config key for the collection constructor:
const Files = new FilesCollection({
  protected: true
})

Just re-opening this, as I have a question. Is it possible to get the userId of the current request inside interceptDownload? I would like to do further checking on a user's permissions...

Once again, found it. downloadCallback is the method I was looking for, as this exposes the userId...
Files.downloadCallback = function (fileObj) {
  console.log(this.userId)
  return true // false to deny access
}

@jpsear I believe you can pass a function to protected instead of a boolean.


clean custom delete btn example

Thanks 👍  I think there're still have the same minor issue in this repo ;p


How do I use .WithParsedAsync and multiple Verbs

Hello,
On the Verbs help page, (https://github.com/commandlineparser/commandline/wiki/Verbs), the following example is given:
static int Main(string[] args) {
    Parser.Default.ParseArguments<AddOptions, CommitOptions, CloneOptions>(args)
    .WithParsed<AddOptions>(options => ...)
    .WithParsed<CommitOptions>(options => ...)
    .WithParsed<CloneOptions>(options => ...)
    .WithNotParsed(errors => ...)
}

I would like to do this, using the .WithParsedAsync. Something like :
static int Main(string[] args) {
    Parser.Default.ParseArguments<AddOptions, CommitOptions, CloneOptions>(args)
    .WithParsedAsync<AddOptions>(options => ...)
    .WithParsedAsync<CommitOptions>(options => ...)
    .WithParsedAsync<CloneOptions>(options => ...)
    .WithNotParsed(errors => ...)
}

How do I do this (or something similar) with the <IP_ADDRESS> ?
Thank you for your reply.

How do I do this (or something similar) with the <IP_ADDRESS> ?

You don't. If this feature is important to you, you update to a CommandLineParser version that actually offers this functionality.

How do I do this (or something similar) with the <IP_ADDRESS> ?

You do it exactly as you did, however, WithNotParsed should also be replaced with WithNotParsedAsync. Everything else related to this should then just be bog-standard async programming...

I have encountered the same issue. @drogars, thanks for the input. However, I wouldn't say I liked the nesting aspect of the awaits. After some thinking, I've come up with the following extension methods that people can reuse if they want to.
In my case, I have
public static class CommandLineExtensions
{
    public static Task<ParserResult<object>> WithJobAsync<TJob>(
        this ParserResult<object> parserResult,
        Func<TJob, Task> parsedFunc) where TJob : IJob =>
        parserResult.WithParsedAsync(parsedFunc);

    public static async Task<ParserResult<object>> WithJobAsync<TJob>(
        this Task<ParserResult<object>> parserResultTask,
        Func<TJob, Task> parsedFunc) where TJob : IJob
    {
        var parserResult = await parserResultTask;

        return await parserResult.WithParsedAsync(parsedFunc);
    }

    public static async Task WithNotParsedAsync(
        this Task<ParserResult<object>> parserResultTask,
        Action<IEnumerable<Error>> notParsedAction)
    {
        var parserResult = await parserResultTask;

        parserResult.WithNotParsed(notParsedAction);
    }
}

Having these extensions, I can now do the following.
var result = Parser.Default.ParseArguments<
                SendPerformanceNotificationsJob,
                CalculateSegmentationJob>(jobArguments.Args);

            await result
                  .WithJobAsync<SendPerformanceNotificationsJob>(sendPerformanceNotificationsJob => ExecuteJobAsync(sendPerformanceNotificationsJob, stoppingToken))
                  .WithJobAsync<CalculateSegmentationJob>(sendPerformanceNotificationsJob => ExecuteJobAsync(sendPerformanceNotificationsJob, stoppingToken))
                  .WithNotParsedAsync(_ =>
                  {
                      var helpText = HelpText.AutoBuild(result,
                                                        h => HelpText.DefaultParsingErrorsHandler(result, h),
                                                        e => e);
                      Console.WriteLine(helpText);
                      throw new JobExecutionFailureException(helpText, Result.Error());
                  });

In my case, as you can see I am dealing with background jobs and hence the naming. But that's not the important part, you can rename the extension methods as you'd like and have nice fluent-style chaining without nested await-s


⚠ Bofrost.lu has degraded performance

In bf033fc, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1964 ms

Resolved: Bofrost.lu performance has improved in bfd0c26 after 27 minutes.


Training stuck at 1 epoch

I've been training 4 hours but its still on 0%...
This is the configuration:

The audio quality is a bit low but the dataset is around 20-30min long cutten into 9s files. My RAM is 4GB..
How to fix this?

Before reading please note I am not an expert, so do not take anything I tell you to do as fact. First of all, you need more ram, I have 16GB, and it works fairly well. What is your GPU? you need a good gpu to use this. I have an RTX 4070 laptop gpu, which has 8GB Vram and it takes about a minute per half hour. This gpu is 14.7 Teraflops (How many trillions of floating point operations per second.) Also, try increasing batch size per gpu. Default is 4, but for me putting it between 9 and 11 gets the highest speed.

I have 4GB of ram 💀


Add the third-party/kvmtool-rim-measurer submodule

This PR adds the kvmtool-rim-measurer tool for calculating Realm Initial Measurement.

Good to see this change, which is a big step forward to support attestation!
I took a quick look at the changes you've made to "3rd-kvmtool-rim-measurer" in islet-asset.
It seems like "kvmtool" now can work in two different modes-- (1) the original mode, which populates a realm and runs it, (2) the RIM calculation mode that you made.
I get why you designed this way because this design allows us to reuse many parts of "kvmtool" codes, which is a good thing, I like this point.
(If I was mistaken at any point, please correct me)
Apart from that, could you add some documents that briefly describe the design of the RIM measurer, why it's designed this way, and how to use it considering the part to verify RIM in FVP? (added as a markdown file in islet/doc/)
That document doesn't have to be added to this PR, when to upload it is up to you.

A brief description is here https://github.com/Samsung/islet-asset/blob/3rd-kvmtool-rim-measurer/BUILD-RIM-MEASURER
I can elaborate more how it is designed, but basically it re-uses the existing kvmtool source code and adds a layer that takes care of measurements.

A brief description is here https://github.com/Samsung/islet-asset/blob/3rd-kvmtool-rim-measurer/BUILD-RIM-MEASURER

Checked. I think this is good enough at this point. I'll copy this explanation onto our github page as well, which could be a more proper place I think.


[dotnet][java][js][py][rb][rust] Update dependency rules_proto to v6.0.2

This PR contains the following updates:

Package
Type
Update
Change

rules_proto
bazel_dep
patch
6.0.0 -> 6.0.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update (6.0.2). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Home Page Test Scripts added for all locales

Added Home Page Test Scripts for all locales
CC: @sigadamvenkata

You just resolve other feedbacks, then can checkin, I will take a look later

@Dli3 do you have any feedback on this?

@PavanKumarN8 @sigadamvenkata This PR broke the eslint workflow. Please check the checks before merging.
Also, @PavanKumarN8 looks like you need to sign the Adobe CLA.


Lists have an extra divider between them that wasn't there in previous versions.

Hi! Love the library. I've noticed that in a recent build lists have a divider between them. The sample app on the Play Store doesn't have a divider, but the sample APK here on Github does. It's probably just a very easy to fix issue.

please make this a feauter so any one can disable/enable dividers between list items

That's not part of the Material guidelines so you'll need a custom adapter.


Responsive table

Hi,
Having a look through the Bootstrap migration checklist, it appears that tables are now made response by just adding .table-responsive class on the table:
https://v4-alpha.getbootstrap.com/migration/
Shall I let you know any other issues I find?

Definitely yes please! Thanks...


Re-render a Field based on another Field change

Hi,
I've decided to open this issue here as the behavior does look like a bug
Background is: I need some text inputs to be visible depending on a given value of my state. This value is bound to a checkbox Field and I used its onChange listener to update the reducer.
This is my checkbox:
<Field
   name = "fwd"
   type = "checkbox"
   component = {this.renderField}
   onChange = {event => this.props.toggleFwd(event.target.checked)}
/>

And this is one of the text fields I'd like to show/hide based on the 'fwd' value:
<Field
  name="fwdInfo.name"
  type="text"
  component={this.renderField}
  className="fwdField"
/>

In the beginning of the 'renderField' helper method I have:
    let className = `form-group ${field.className}`;
    if (className.includes("fwdField")) {
      if (this.props.patient.fwd) {
        className.replace("hidden").trim();
      } else {
        className += " hidden";
      }

What's happening:

If the page loads with the 'fwd' == false (i.e. the text fields are hidden), even if I tick the checkbox, the fields won't appear - the render method is not called!
If the page loads with 'fwd' == true, when I uncheck the checkbox, the fields won't disappear - the render method is no called. However, if I focus on the text input, the render message is called and they disappear as expected. After that, if I check the checkbox again, all the fields correctly reappear, as expected.

Maybe I should not expect a Field component that is not bound to a given value to re-render when it changes - however, this behavior of rendering after I focus the text input made me wonder if there is a bug here.
actionCreator and reducer apparently are working fine:
export function toggleFwd(fwd) {
  return {type: TOGGLE_FWD, fwd};
}

case TOGGLE_FWD:
      return {...state, fwd: action.fwd};

hi, did you solved? i have same problem. i have two forms on page, use the tabs to switch them, the tabs component has a 'isActived'  inner state, when click the hidden tab, the component will re-render and the 'isActived' be reset to init value, so can't show the tab panel.

Hi @filipercastro, can you take a look whether the following example helps you?
https://codesandbox.io/s/G6klJ830J
cc @shengnian

Hi @gustavohenke, that did work! I was not aware of the formValues decorator (it seems to be new in 6.8, I was using 6.7 so far).
Sorry, should have looked a bit more into the API before raising this as a bug.
Thanks very much for your help!

Indeed, formValues is a handy decorator!
But you can do it with its selector counterpart as well, formValueSelector, or with the selector getFormValues - they are just a little bit more difficult to setup via connect(), etc.

@gustavohenke
thanks, my scene is:
loginForm.jsx
class LoginForm extends PureComponent {

  render () {
    const { pristine } = this.props
    return (

        <form>
          <Field
            name='email'
            label='email'
            component='input'
            validate={[required, maxLen15, minLen4]}
          />
          <Field
            name='password'
            type='password'
            label='Password'
            component='input'
            validate={[required, maxLen15, minLen4]}
          />

            <button
              type='button'
              className='btn btn-submit btn-block'
              onClick={() => this.props.login()}
              disabled={pristine}>Login
            </button>

        </form>

    )
  }
}

export default reduxForm({
  form: 'LoginForm',
})(connect(
  state => ({
    ...
  }),
  {
    login
  }
)(withRouter(LoginForm)))

OtherForm.jsx
class OtherForm extends PureComponent {

  render () {
    const { pristine } = this.props
    return (

        <form>
          <Field
            name='email'
            label='Email'
            component='input'
            validate={[required, maxLen15, minLen4]}
          />
          ...

            <button
              type='button'
              className='btn btn-submit btn-block'
              onClick={() => this.props.go()}
              disabled={pristine}>Submit
            </button>

        </form>

    )
  }
}

export default reduxForm({
  form: 'OtherForm',
})(connect(
  state => ({
  ....
  }),
  {
    submit
  }
)(withRouter(OtheForm)))

the tabs component install with yarn :
yarn add https://github.com/freeranger/react-bootstrap-tabs

and the react-bootstrap-tabs has a inner state 'selected'
layout.jsx
class Account extends React.Component {
  render () {
        return (<Tabs
              headerClass='tab-header-bold'
              activeHeaderClass='tab-header-brand'
              onSelect={(index, title) => {
                console.log(index, title)
              }}
              className='app-main-tabs'>
              <Tab label='Login' >
                <LoginForm />
              </Tab>
              <Tab label='Other'>
                <OtherForm />
              </Tab>
              </Tabs>
        )

When I click the 'Other' tab, Redux Devtools's log twice render, and the react-bootstrap-tabs
inner state selected will be reset. if i remove the <LoginForm /> and <OtherForm /> worked fine
click the 'Other' tab the Redux Devtools's log d@@redux-form/REGISTER_FIELD... UPDATE_SYNC_ERRORS DESTROY
am i using is wrong?

I could not understand your issue very well, @shengnian.
But you should check whether the tabs aren't destroying the contents - it's not because you wrote your code like that the Tab is actually mounting LoginForm/OtherForm.
Anyway, you can keep your state without destroying: check the wizard example.

ok, i tried the wizard example,  that's a little different, two form have different redux-form name and same input form name.  i'll trying to try other solutions.
Thank you for your help.

Okay, closing since initial request was fulfilled.


Fix Issue 17250 - ProcessPipes (std.process) should provide a test for a null pid

The pid() property of the ProcessPipes struct asserts that the pid is not null. This makes it impossible to check for a null pid (see bug description for a more detailed description). The solutions are : either remove the assert and expect the user to check for a null pid or add a new function isNullPid. In my opinion, the first solution is the better one as checking for a null pid can be simply done and doesn't need a one liner function. Either way, if for some reason, the latter solution is preferred, I will update my commit.

Thanks, replied to issue (https://issues.dlang.org/show_bug.cgi?id=17250).

I think this is an improvement and is okay. Personally, I think an API that indicates that the state of PipeProcess would be preferable. CyberShadow's suggestion of an implicit bool conversion sounds good. However, even if a new API was added, it's odd that the pid() method asserts just because it gets called. From this perspective alone this is an improvement, and there are arguments that this
is as good as a new api method.
If going with this approach, I suggest adding a line to the ProcessPipe.pid() method documentation to indicate that the return value is null if a process has not been successfully spawned. A unit test also makes sense.

if a process has not been successfully spawned

To be pedantic:
If a process has been attempted to be spawned and has not been successfully spawned then the result is an exception. The return value of pid will only be null only when the type is uninitialized.
If ProcessPipes had been written a few years later, a @disabled default constructor might have been suitable, as I think that was the intention of the authorcs.

If a process has been attempted to be spawned and has not been successfully spawned then the result is an exception. The return value of pid will only be null only when the type is uninitialized.

Ah, okay, my mistake. Thanks for the clarification. The scenario I had in mind was this:
ProcessPipes pipes;
scope(exit) wait(pipes.pid);
... code ...
pipes = pipeProcess("my_application", Redirect.stdout | Redirect.stderr);
... code ...

The exception is thrown and the scope guard runs. However, the assignment to the pipes variable never happens. The state of the _pid member in the struct pipeProcess was attempting to create is not available to interrogate, only the state of the uninitialized ProcessPipe.

Yep, I saw in the bug report.

If going with this approach, I suggest adding a line to the ProcessPipe.pid() method documentation to indicate that the return value is null if a process has not been successfully spawned.

With that clarified, I think this is good as is.

Agreed, thanks for spending the time hashing it out.


Added getFullResult and getRawResult methods

In #39 we want to add support for retrieving percentages. In order to handle that and future-proof image-diff for further cases, we are adding methods which call back with the raw CLI info from ImageMagick and extracted total/percentage info.
In this PR:

Added getFullResult and getRawResult methods
Added tests
Updated/added documentation
Added missing context cleanup in tests (e.g. after(function cleanup () {)
Fixes #39

Notes:
For release, this should be as simple as:
./release.sh 1.6.0

/cc @mlmorg

Sorry for the delay! Merged.

No worries, thanks @mlmorg! =)


[fix] #2599: Remove nursery lints

Description of the Change
Nursery lints are explicitly disabled. The lints which were enabled as part of clippy::nursery are instead enabled individually.
Issue
Closes #2599
Benefits
Smoother toolchain upgrade process
Possible Drawbacks
New lints have to be explicitly enabled. Migitation:

On each upgrade uncomment clippy::nursery and see the effects of new lints.

better, because nursery lints, since they are incomplete/not agreed upon/incorrect, can make the code look worse and encourage bad practices among engineers to just to satisfy the linter


Are there plans to open source the pretraining code?

Thank you very much for your work. I want to apply them to my own assembly code preprocessing scheme, so re-pretraining is required. Do you have plans to open source your pretrained code? Thanks a lot.

Thanks for your interest, @xunge! I will try to open source the pre-training code next month.

Dear author, is the pre-training code ready to be updated?

Dear author, now I really need your pre-training code to learn. If you can, can you open your preprocessed code? Thank you very much and look forward to your reply.

Dear author, now I really need your pre-training code to reference and apply to my solution. If so, can you open source your pre-training code? Thank you very much and look forward to your reply.

Thank you for reaching out and expressing your interest in getting an update on the progress of our code release. We will release a new cross-architecture model and its pre-training code in the near future.

Any chance to get an update on this?
I realize cleaning up code to open source it is a lot of work and you might have different priorities right now. But anything you can release with little effort on your side would be great.
For example, it would already be very useful to just see a snippet of raw code for how you implemented the modified token and position embeddings,

To answer my own question: it turns out that the implementation of the token and position embeddings is (cleverly?) done in a single line here: https://github.com/vul337/jTrans/blob/002952947ffbe3af1e53101f9007bb9142914c8f/finetune.py#L189C38-L189C38
class BinBertModel(BertModel):
    def __init__(self, config, add_pooling_layer=True):
        super().__init__(config)
        self.config = config
        self.embeddings.position_embeddings=self.embeddings.word_embeddings

What this does is to completely ignore BERT's precomputed position_embeddings (a 512x768 matrix of sequence length x embedding length). Instead it points any calls to it to the first 512 positions in BERT's word_embeddings (a 2902x768 matrix of vocab length x embedding length).
Because of this, any calls or updates to the position embedding end up with the calls to the first 512 word embedding tokens in the vocabulary. Which, very importantly, are exactly all the jump tokens.
In effect the makes the parameters shared: the position embeddings are learned by updates to the jump token word embeddings during training.
See also the answer to https://github.com/vul337/jTrans/issues/11

Thank you for reaching out and expressing your interest in getting an update on the progress of our code release. We will release a new cross-architecture model and its pre-training code in the near future.

Sorry to interrupt, is it available now.

I like your work! Is the pretraining code available now?

Sorry for this delay. We've released our new pre-train code at https://github.com/Hustcw/CEBin/tree/main/pretrain .
We also recommend trying our new approach CLAP with model and code. We've integrated our models into the online service at https://mlm.01.ai.


PHP 8 and Sylius 1.10

Do you plan to support PHP 8 and Sylius 1.10? I'm not sure if your v1.1.0 covers them, I guess not?

Hello, normally it's not a big deal, are you able to propose a pull request ?
I should be very easy to support it :

add a php 8 and sylius 1.10 to the GitHub action matrix
maybe some few change into the composer.json
maybe some little changes inside some classes

Hello @michaelKaefer, I publish a new release, I hope you'll enjoy it 😉
https://github.com/FLUX-SE/SyliusEUVatPlugin/releases/tag/v1.1.1


[ImgBot] optimizes images

Hi! I'm ImgBot. Nice to meet you.
I noticed there were a bunch of images living in your project that weren't totally optimized so I thought I'd make you a PR ;) I use a lossless compression algorithm from ImageMagick so all the images are the same quality and dimensions as before only they take up less space now.
Image processing is tough work, I know, but I never get tired and I never rest - not until all the images on GitHub are totally optimized.
*Total -- 989.43kb -> 562.65kb (43.13%)
/assets/mocha-banner-192.png -- 15.30kb -> 6.35kb (58.49%)
/docs/images/emacs.png -- 591.08kb -> 280.32kb (52.58%)
/docs/images/reporter-dot.png -- 13.15kb -> 7.28kb (44.63%)
/docs/images/jetbrains-plugin.png -- 87.05kb -> 50.34kb (42.17%)
/docs/images/wallaby.png -- 47.87kb -> 33.00kb (31.06%)
/assets/mocha-logo-128.png -- 7.27kb -> 5.19kb (28.62%)
/assets/mocha-logo-192.png -- 10.13kb -> 7.25kb (28.45%)
/docs/images/mocha_side_bar.png -- 214.39kb -> 170.27kb (20.58%)
/assets/mocha-logo-64.png -- 3.20kb -> 2.65kb (17.01%)

Coverage increased (+0.05%) to 90.014% when pulling 9cd974c8c2f370c2e0e9ed04c75cea85269568b4 on ImgBotApp:imgbot into 33db6b119c471fc275d61795ba6767eea8979ebb on mochajs:master.

👍 happy to help
If you want more prs from ImgBot here, or any of your other projects, feel free to install the GitHub app.
https://github.com/apps/ImgBot

@dabutvin Please don't send unsolicited PRs from bots.
I'm going to revert this, as we've lost color information on the logos.

@boneskull sorry for the trouble.
I logged an issue over at Magick.NET

Also, we already have image optimization as part of the build pipeline. It's completely on purpose to keep the original images unoptimized so we don't lose any information. This lets us remove build time optimizations if they cause undesired data loss

@Munter with their implementation you revert a commit. Personally I favor having the optimizations in the build step ONLY because we have a build step. this way we have everything in one place.

we already have image optimization as part of the build pipeline. It's completely on purpose to keep the original images unoptimized so we don't lose any information

This is an extremely common scenario.  I don't see how the bot could be effective, sending PRs to random projects.


Working only for Python 3.x codes

If the repository to inspect uses a Python version bellow 3.x, such as zhiqiangdon/CU-Net (Python 2.7), the "ast module" is not able to work properly if we have a Python 3.X environment (which is what is necessary to run code_inspector) .
code_inspector manages the error, but obviously is not able to parser some files, such as the ones that uses "old printing style" (e.g. print 'save prefix: ', checkpoint.save_prefix (Line 76) --> zhiqiangdon/CU-Net/cu-net.py).
The issue is that  "ast module" can only handle Python code for the version of Python it is shipped with.
So, I have tested if creating a Python 2.7 environment, would solve this issue. However, code_inspector comes with 2 libraries (cdmcfparser and docstring_parser), which dont have support anymore for Python 2.7.  So, code_inspector does not run in a Python 2.7 environment.
Something to have in mind!

I am in favor of placing a warning stating that we work for 3.x + and that's it :)

Agreed!

Closing the issue then!


⚠ Bofrost.at has degraded performance

In 7f1a94d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1497 ms

Resolved: Bofrost.at performance has improved in 8354559.


Add hardware licenses

It would be nice if there was open source hardware licenses section
Some information:
https://en.wikipedia.org/wiki/Open_Hardware_License
https://en.wikipedia.org/wiki/Open-source_hardware#Licenses

It would be nice if there was open source hardware licenses section Some information: https://en.wikipedia.org/wiki/Open_Hardware_License https://en.wikipedia.org/wiki/Open-source_hardware#Licenses

sure! I will check it out and if it's ok, I will add it to this guide


Motivation around setting beta to 1/9

Hi everyone,
I was wondering what was the motivation around setting the beta parameter for the smooth L1 loss for faster RCNN to 1/9.
The line in question is here: https://github.com/pytorch/vision/blame/8a0b491e51197edd9ca9f9ad7f6d9147ac8a209d/torchvision/models/detection/roi_heads.py#L44
Is this based on some work / intution I could be able to track (but wasn't) or was it a "good guess"?

Hi @davideboschetto , looking at https://github.com/pytorch/vision/pull/2113 and the other conversations linked in this PR, it seems that 1/9 was chosen mostly for its empirical performance


Merge changes from upstream webhook-example.

This PR makes a lot of changes and I don't understand what it's supposed to do.


Replace nonequilibrium integrators with NonequilibriumLangevinIntegrator

Now that we have NonequilibriumLangevinIntegrator in openmmtools, we should remove the redundant integrators from perses/annihilation/ncmc_switching.py.

@pgrinaway : If we extend the integrator_type argument, should we keep the current terminology ([GHMC, VV, VVVR, BAOAB]) or standardize on the new integrator splitting language ([O { V R H R V } O, V R H R V, O V R H R V O, R V O H O V R])?

I'd also like to add an ignore_shadow_work option, since we will presumably want to do so when g-BAOAB is in use.
I'm hoping we can reuse these parts of perses for at least some pilot experiments for the shadow work paper, but I think this refactoring would also be immediate use to you too. Did you want to tackle this or should I, @pgrinaway?

If we extend the integrator_type argument to NCMCEngine, should we keep the current terminology ([GHMC, VV, VVVR, BAOAB]) or standardize on the new integrator splitting language ([O { V R H R V } O, V R H R V, O V R H R V O, R V O H O V R])?

Maybe for now we can use the current terminology, otherwise we'd have to add in extra checks (like make sure that people actually include a Hamiltonian update.

I'd also like to add an ignore_shadow_work option, since we will presumably want to do so when g-BAOAB is in use.

You mean disable its computation? That's probably a good thing to do to get efficiency. The integrator doesn't otherwise include shadow work in the protocol work variable, though.

I'm hoping we can reuse these parts of perses for at least some pilot experiments for the shadow work paper, but I think this refactoring would also be immediate use to you too. Did you want to tackle this or should I, @pgrinaway?

To be clear, by "this refactoring" you mean having perses use the integrators in openmmtools? I can tackle that.

You mean disable its computation? That's probably a good thing to do to get efficiency. The integrator doesn't otherwise include shadow work in the protocol work variable, though.

Currently, NCMCEngine uses the total work (protocol + shadow). We want to be able to easily select whether NCMCEngine includes or omits shadow work.

To be clear, by "this refactoring" you mean having perses use the integrators in openmmtools? I can tackle that.

Yes!

To clarify, this issue refers to refactoring the NCMCEngine, not the relative nonequilibrium stuff that we are doing now.


Update attestation_report 'flags' bitmask

I was fetching a report with the lib and was faced with this error message: mbz bits at offset 0x48 not zero: 0x00000004.
Looking at page 44 of the ABI spec here this seems like a valid value. After updating the bitmask with this patch the report was generated.
I am happy to remove the gofumpt formatting if you prefer that. It looked like you also use it, which is why I left it in.
Cheers.

I just realized that this probably has changed since you built the library since there is now the possibility to have the attestation report signed with a VLEK, instead of a VCEK.
There are probably more places to change to add proper VLEK support. But so far it seemed fine.

Thanks for bringing this to my attention, I wasn't aware of the VLEK before this PR. It's not particularly valuable for the cloud computing case, since if the host knows the private key, then it's within the trust boundary. The SEV-SNP threat model is meant to push the cloud service provider entirely out of the trust boundary. We'll still make sure this generic library stays up to date with the spec if you decide not to pursue a full support PR, just maybe not immediately. Thanks!

I think for VLEK to be added to go-sev-guest, we need to have a better sense of the whole story so we can have e2e tests with hardware. I know this library doesn't show how to install certificates into /dev/sev, so assuming a loaded VLEK could be okay, but I don't know what the difference will be for VLEK certificate shapes, since our kds library validates expected data about certificates.
I think for now we can extend the ABI representation, but not yet validate VLEK-based attestation reports.

The VLEK certificate is part of the extended report. go-sev-guest can retrieve that correctly. From what I understand in the docs, I can treat that like a VCEK and don't have to do anything special.

I haven't found the time to fully implement VLEK support with unit tests and fake support, but I'll merge this to unblock. I've opened Issue#53 to track everything that I hope to get to, but alas I can't prioritize that work just yet.


Transaction address changes automatically to other

I was sending wbnb to my another wallet but when I copied and pasted address and approve transaction  it changes to it's contract address which I never  copied, kindly revert this transaction or help me to get back my asset it's 0.04 wbnb attaching transaction hash: 0xdbcae8083a769a600a9eff2137d1874c050ff0b6484c23870ecce5d43a55f5ad
My wallet address: 0x9A174001fDf92BD166F9BeF2C195bF5446a73f93

As mentioned in the issue template, this repository is not for reporting individual losses, only for large scale smart contract exploits. If you need support, please join the Revoke.cash Discord (see website footer for a link).


Update books.md

Add Italian book section.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


integration-docs: Update for new format (Groove, Gosquared, Gogs, Gitea).

As the changes were mostly to the docs format and not content, these are grouped together in a PR that updates 4 doc pages.
As part of https://github.com/zulip/zulip/issues/29592, update the following integration documentation pages:
Screenshots and screen captures:

Groove

GoSquared

Gogs

Gitea

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Feedback:

Merging steps to reduce the number of steps
Replacing macro {!git-webhook-url-with-branches.md!} with {!git-branches-additional-feature.md!}
Adding the 'configuration options' section for the {!git-branches-additional-feature.md!}

Updated docs

@zulipbot add "mentor review" @sbansal1999, please review this too, thanks!

Updated GoSquard doc

@Niloth-p does this look good to you now?

@Niloth-p does this look good to you now?

I would say that the wording aspect has not yet been addressed in this PR, probably because it was not initially opened with that in mind.
Hi @PieterCK, during our discussion, when I raised the question about including phrasing updates, you mentioned your opinion that the formatting changes and the writing changes would be separate PRs/commits, so we decided to review just for the formatting and reordering changes. From the updates on #30726 before its merge, it's clear that the text rewrites would need to be incorporated as well. Could you please look into that?
You can refer to any of the recently merged integration docs PRs and use this list I made as well. Feel free to add any more patterns that you notice, so that we can all refer to it throughout this batch of updates.

Update: Added commit description for integrations with notable changes in their documentation. Replaced the word "constructed" to be "generated" instead. Re-worded and combined some steps to make the overall instructions more concise.
@Niloth-p Appreciate the thorough review Niloth! The list is super helpful. Thank you :+1:

@PieterCK - Thanks for working on this! I went ahead and did a maintainer review on these since it'd gone through the buddy review process. I pushed a few updates...
Updates:

I simplified the Groove documentation so that it better follows our patterns.
I split out the Go Squared instructions so that it matched the 1 step for navigation and 1 step for configuring format.
I removed the if blocks around the event filtering macro.

Updated screenshots:

Groove

GoSquared

Gog

Gitea

Looking good! I noted on CZO that the Gitea screenshot could be better.

Merged, thanks @PieterCK and @laurynmm!


Core: add notification for client unable to join full room

Description
Lets the host know if another user tries to join a full room
Summary:

Related Issue:
https://linear.app/whereby/issue/COB-972/add-an-sdk-host-notification-when-someone-tries-to-join-a-full-room

Testing

yarn build
yarn dev:sample-app
go to the sample app page and join a P2P room as a host
join the same room with 3 more clients in other browsers
try to join from a fifth browser
see the notification in the sample app

Screenshots/GIFs (if applicable)

Checklist

[x] My code follows the project's coding standards.
[x] Prefixed the PR title and commit messages with the service or package name
[x] I have written unit tests (if applicable).
[x] I have updated the documentation (if applicable).
[x] By submitting this pull request, I confirm that my contribution is made
under the terms of the MIT license.

Additional Information

I followed the test steps but I haven't seen the notification. I ran rm -rf node_modules, then yarn yarn build yarn dev:sample-app.  I see the client_unable_to_join signal evt in devtools when the fifth knocker's req is accepted. There's no (related) console error or warning.
What did I do wrong? 😕


fix: Added message flash when chart with missing dataset is accessed.

SUMMARY
Chart with deleted dataset is still available on charts list. While trying to access its explore view page redirects to charts list page. As discussed in issue #12464, I added flash notification message in right bottom corner.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
[Link to previous behaviour video] (https://user-images.githubusercontent.com/25153919/104351996-6655dd00-5506-11eb-929d-a7c1593098e0.mov)
After:

TEST PLAN

Go to charts list and remember choose chart by dataset
Go to list of datasets
Delete chosen dataset
Come back to charts list and try access charts previously chosen (it will have empty dataset name)
It should redirect to charts list and show notification of missing chart and dataset:
The datasource associated with this chart no longer exists

ADDITIONAL INFORMATION

[x] Has associated issue: #12464
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

just one quick change - "datasource" to "dataset" in the message 🙏

just one quick change - "datasource" to "dataset" in the message 🙏

just one quick change - "datasource" to "dataset" in the message 🙏

It's done 👍

just one quick change - "datasource" to "dataset" in the message 🙏

It's done 👍

@kkucharc I think changing the underlying exception message makes more sense. We're trying to go with "dataset" moving forward. Also please wrap messages in babel translation _() function for i18n

@kkucharc I think changing the underlying exception message makes more sense. We're trying to go with "dataset" moving forward. Also please wrap messages in babel translation _() function for i18n

What is the current behavior? User gets redirected to Explore and then sees an error message because the underlying datasource doesn't exist right?
While not having user go to the chart Explore to find this information out is generally great, there might be some legit cases when user (especially owner) still want to access such chart - for example when they are trying to see the configuration they set up to build a new chart, or if they want to specify new dataset.

What is the current behavior? User gets redirected to Explore and then sees an error message because the underlying datasource doesn't exist right?
While not having user go to the chart Explore to find this information out is generally great, there might be some legit cases when user (especially owner) still want to access such chart - for example when they are trying to see the configuration they set up to build a new chart, or if they want to specify new dataset.

@zuzana-vej Now we have situation like on video -
https://user-images.githubusercontent.com/25153919/104351996-6655dd00-5506-11eb-929d-a7c1593098e0.mov

@zuzana-vej Now we have situation like on video -
https://user-images.githubusercontent.com/25153919/104351996-6655dd00-5506-11eb-929d-a7c1593098e0.mov

Codecov Report

Merging #12468 (6913ac6) into master (d8f4443) will decrease coverage by 15.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #12468       +/-   ##
===========================================
- Coverage   66.81%   50.99%   -15.83%
===========================================
  Files        1015      473      -542
  Lines       49548    16872    -32676
  Branches     5080     4341      -739
===========================================
- Hits        33106     8604    -24502
+ Misses      16312     8268     -8044
+ Partials      130        0      -130

Flag
Coverage Δ

cypress
50.99% <ø> (+0.01%)
:arrow_up:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

superset-frontend/src/components/IconTooltip.tsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...end/src/SqlLab/components/ExploreResultsButton.jsx
8.00% <0.00%> (-84.00%)
:arrow_down:

...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx
14.70% <0.00%> (-82.97%)
:arrow_down:

... and 866 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f4443...27737d1. Read the comment docs.

Codecov Report

Merging #12468 (6913ac6) into master (d8f4443) will decrease coverage by 15.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #12468       +/-   ##
===========================================
- Coverage   66.81%   50.99%   -15.83%
===========================================
  Files        1015      473      -542
  Lines       49548    16872    -32676
  Branches     5080     4341      -739
===========================================
- Hits        33106     8604    -24502
+ Misses      16312     8268     -8044
+ Partials      130        0      -130

Flag
Coverage Δ

cypress
50.99% <ø> (+0.01%)
:arrow_up:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

superset-frontend/src/components/IconTooltip.tsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...end/src/SqlLab/components/ExploreResultsButton.jsx
8.00% <0.00%> (-84.00%)
:arrow_down:

...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx
14.70% <0.00%> (-82.97%)
:arrow_down:

... and 866 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f4443...27737d1. Read the comment docs.

@junlincc Could you describe steps to reproduce - > I tried to delete datasets and charts remain.

@junlincc Could you describe steps to reproduce - > I tried to delete datasets and charts remain.

Same here:
Before:

After:

Maybe it's something in sorting or Dataset filter?

Same here:
Before:

After:

Maybe it's something in sorting or Dataset filter?


Increase sensubility smart-gateway ring buffer

Increase the ring buffer size of the sensubility Smart Gateway as
messages often exceed the default of 16384 bytes, resulting in no API
healt check data from controllers arriving.
Closes: rhbz#2241033

Seems a bit weird to go from (2^14) to (2^16 - 1), but okay. :)

Yea the jump is quite big, but the error message I was getting was that the message was 40000, larger than 16384, so I picked the next exponential that I could remember off the top of my head :)


Migrate command-line utilities

With this PR, mix-models can serve as the CLI entry point for all code in message_ix_models and in message_data.

Add .util.cli from message_data.tools.cli.
Add .util.logging from message_data.logging.

Codecov Report

Merging #8 (72e1757) into main (c3db1df) will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   99.08%   99.84%   +0.76%
==========================================
  Files          12       17       +5
  Lines         435      650     +215
==========================================
+ Hits          431      649     +218
+ Misses          4        1       -3

Impacted Files
Coverage Δ

message_ix_models/util/importlib.py
100.00% <ø> (ø)

message_ix_models/__init__.py
100.00% <100.00%> (ø)

message_ix_models/cli.py
100.00% <100.00%> (ø)

message_ix_models/model/bare.py
100.00% <100.00%> (ø)

message_ix_models/model/structure.py
100.00% <100.00%> (ø)

message_ix_models/testing.py
100.00% <100.00%> (ø)

message_ix_models/tests/model/test_structure.py
100.00% <100.00%> (ø)

message_ix_models/tests/test_cli.py
100.00% <100.00%> (ø)

message_ix_models/tests/util/test_click.py
100.00% <100.00%> (ø)

message_ix_models/tests/util/test_context.py
100.00% <100.00%> (ø)

... and 11 more


PH integrity validation improvements + gateway fix

Dont merge before the release
see https://github.com/stratisproject/StratisBitcoinFullNode/pull/3720

This PR is totally bloated for no reason, injecting the connection for the settings is really not needed.
Also there is no need to check gateway just do nothing if its a regular header.

Agreed with @dangershony .
Removed bloating.


Feature Request: OR logic for rule steps

Thanks for the great work so far on this, I'm having a blast trying it out. One thing I'd love to see is a way to express that one of a group of steps is required, rather than just a list of optional steps.
For instance, I have this working rule:
(def rules [{:id :statement
             :optional-steps []
             :rule [:actor
                    #{:get-value
                      #{"NN"} #{"NNP"} ;; singular, singular proper
                      #{"NNS"} #{"NNPS"}} ;; plural, plural proper
                    :verb
                    #{:get-value #{"VBD"}}
                    :object
                    #{:get-value
                      #{"NN"} #{"NNP"}
                      #{"NNS"} #{"NNPS"}}
                    #{#{"."}}
                    ]}])

"bob experienced enlightenment." => {:errors nil, :result {:rule :statement, :data {:actor ["bob"], :verb ["experienced"], :object ["enlightenment"]}}}

"people experienced enlightenment." => {:errors nil, :result {:rule :statement, :data {:actor ["people"], :verb ["experienced"], :object ["enlightenment"]}}}

note that some of the POS tags are different than the postagga defaults, I'm plugging in the Stanford NLP lib for tagging
This rule finds simple statements of actor - verb - object, where the actor and object can both be singular or plural. But it isn't possible to disambiguate between singular and plural in the result map, meaning that if I want to look specifically for singular or plural actors or objects, I need to either make both optional (which could result in a false hit with no actor/object), or branch and write more rules to cover all cases (singular actor - verb - singular object, plural actor - verb - singular object etc...) which would get pretty huge.
It would be great if I could specify something like an OR condition, either in the optional steps vector or the body of the rule, for example:

(def desired-rules
  [{:id :statement
    :optional-steps [;; grouping of two or more steps to indicate
                     ;; that one of them is required
                     [:actor-singular
                      :actor-plural]
                     ]
    :rule [:actor-singular
           #{:multi :get-value
             #{"NN"} #{"NNP"}} ;; singular, singular proper
           :actor-plural
           #{:multi :get-value
             #{"NNS"} #{"NNPS"}} ;; plural, plural proper
           :verb
           #{:get-value #{"VBD"}}
           :object
           #{:get-value
             #{"NN"} #{"NNP"}
             #{"NNS"} #{"NNPS"}}
           #{#{"."}}
           ]}])

"bob experienced enlightenment." => {:errors nil, :result {:rule :statement, :data {:actor-singular ["bob"], :verb ["experienced"], :object ["enlightenment"]}}}

"people experienced enlightenment." => {:errors nil, :result {:rule :statement, :data {:actor-plural ["people"], :verb ["experienced"], :object ["enlightenment"]}}}

Would something like this make sense to add? Is there some other property of the rule syntax that can achieve this already? Happy to contribute to make it happen.

Hey Thanks for using postagga ! I am really happy that you could plug in another tagger, means that the design is modular enough for you to use the parser :)
Well what you're suggesting makes perfect sense. I am aware that the mere list of steps to follow isn't expressive enough, as it only describes one linear branch of parsing: this then this then....
I totally agree that we should be able to add "forking" as you suggest, so we can have a proper "automaton" that parses our "grammars". But I would not put this in "optional steps", actually I am going to ditch the "optional steps" vector altogether, and put a "grammar" kindof matrix telling possible ways to go from one step: That'll do or in particular and branching in more general way:
for instance :step1 -> step2 step3
step3 -> ...
I am gonna defintely work on this.
But can you fork the project and add an example of how did you plug the stanford tagger please ? Mind sharing the model / pos-tagger ?
Cheers
Rafik

Or I can simply specify vector of steps like so:
          [:actor-singular
           #{:multi :get-value
             #{"NN"} #{"NNP"}} ;; singular, singular proper
           :actor-plural
           #{:multi :get-value
             #{"NNS"} #{"NNPS"}}] ;; plural, plural proper

To say this Or this. I'll probably begin this way as it would take less time to implement.
Of course, I'll keep the optional vector in this method.
Thanks you for sharing your thoughts. Really appreciate it!

I can help anywone willing to work on this for #Hacktoberfest !!

Hey @milt ! I added the :!OR! operator to account for your request ! can you plz consider testing?


Get rid of the middleware

Just out of curiosity, why does there need to be a middleware? Can't there just be one JavaScript file you include which will check the HTML on ready for a <meta> or <input> tag with token?
I personally don't like having too many intercepting middlewares altering the output etc, would much prefer a tiny bit of vanilla js included in each page checking a few tags.

The point of this package is to make it a drop-in solution where the developer doesn't need to do any additional config or setup. This is not meant to be a solution for everyone, and I completely understand if it doesn't fit your use case. :)


Changed LogStashFormatter to take type from progname, which has the h…

…ighest precedence.
1 'type' from logger.progname has the highest precedence
2 If that is empty, it takes the value from the hash's ['type']
3 If none of the above is set, type can be set through FileBeat config

👍

:+1:


LRU hash map causes heap corruption under heavy load

It appears as if there is a bug somewhere in the new multi-generational LRU hash that causes heap/pool corruption. I am investigating it still.

Concurrent updates can result in key entries not being removed from the cold list. This results in freed items remaining in the cold list and corrupting heap.


Getting error with react-d3-tree.

Thank you for taking the time to report an issue with react-d3-tree!
Feel free to delete any questions that do not apply.
Are you reporting a bug, or opening a feature request?
is it a bug?

also checked that dequal is available in the node_modules
What is the actual behavior/output?
unable to render a simple tree due to the error "lite_1.dequal is not a function"
What is the behavior/output you expect?
render a simple tree. could it be that it is an issue with existing dependencies?
What version of react-d3-tree are you using?
tried with version 2.0.0 and latest 3.1.1

Hi,
Closing since I wasn't able to reproduce this.
Seems to be a local dependency issue but please comment again here if you can consistently reproduce this on a tool like codesandbox or similar 👍


UNDERTOW-1791: Migrate from getPeerCertificateChain to getPeerCertificates

Java 15 runtimes default jsse SSLSession implementation throws an
UnsupportedOperationException when getPeerCertificateChain is called.
https://www.oracle.com/java/technologies/javase/15-relnote-issues.html#JDK-8241039
In this PR I have replaced uses of getPeerCertificateChain with getPeerCertificates, however I have not provided an implementation of sslsessioninfo.getPeerCertificateChain which delegates to getPeerCertificates and converts to the javax variant. It's unclear if that would be desirable.
It appears unlikely that there are cases in which getPeerCertificates produces different results, but it's possible a SSLSession implementation is incorrect in a way that causes this change to introduce failures. We could flag this behavior behind a property.

I've cherry-picked the commit from #987 to run tests using jdk15 in addition to 8 and 11.

this PR introduced a regression in the SSL tests and will require some investigation before being merged

I've fixed the failure -- sorry about that. Hopefully it's not too late for 2.2.3.Final.

thanks, there is still time for 2.2.3.Final @carterkozak !