How to make a only Sunday(30-10-2016) as a Trading Day

Dear Zipline Maintainers,
Before I tell you about my issue, let me describe my environment:
I am a beginner on Zipline and need help on non US stock data ingestion.
MacOs
Zipline 1.3.0
Custom CSV Bundle
Non US Equities
Custom Trading Calendar
Conda Environment installation
Now that you know a little about me, let me tell you about the issue I am
having:
I am a beginner on Zipline and need help on non US stock data ingestion.
Description
I need to make a single Sunday(30-10-2016) as a Trading day. I have registered this trading Calendar as in calendar_utils.py and have no problem with it. I have even got the adhoc_holidays() working.
This is the Trading calendar for Indian Stock market. India has few regualr holidays which fall on the same day every year and many holidays are irregular. Based on the same list of irregular holidays since Oct 2016 i have made my custom trading calendar. Yes, i am now dealing with data after October 2016 to current date only.
I want to point to special_opens where the issue is. I have a data in my csv for 30-10-2016 as it was a special trading day on Sunday.
Below is my NSEExchange trading calendar.
from datetime import time

from pandas._libs.tslib import Timestamp
from pandas.tseries.holiday import Holiday
from pytz import timezone
from trading_calendars.trading_calendar import TradingCalendar, HolidayCalendar
from itertools import chain

Chritmas = Holiday(
        "Christmas",
        month=12,
        day=25
)

Ambedkar_Jayanthi = Holiday(
    "Ambedkar_Jayanthi",
    month=4,
    day=14
)

Gandhi_Jayanthi = Holiday(
    "Gandhi_Jayanthi",
    month=10,
    day=2
)

India_Independence = Holiday(
    "India_Independence",
    month=8,
    day=15
)

May_Day = Holiday(
    "May_Day",
    month=5,
    day=1
)

India_Republic = Holiday(
    "India_Republic",
    month=1,
    day=26
)

OtherHolidays = [
    Timestamp('2016-03-07', tz='Asia/Kolkata'),
    Timestamp('2016-03-24', tz='Asia/Kolkata'),
    Timestamp('2016-03-25', tz='Asia/Kolkata'),
    Timestamp('2016-04-15', tz='Asia/Kolkata'),
    Timestamp('2016-04-19', tz='Asia/Kolkata'),
    Timestamp('2016-07-06', tz='Asia/Kolkata'),
    Timestamp('2016-09-05', tz='Asia/Kolkata'),
    Timestamp('2016-09-13', tz='Asia/Kolkata'),
    Timestamp('2016-10-11', tz='Asia/Kolkata'),
    Timestamp('2016-10-12', tz='Asia/Kolkata'),
    Timestamp('2016-10-31', tz='Asia/Kolkata'),
    Timestamp('2016-11-14', tz='Asia/Kolkata'),
    Timestamp('2017-02-24', tz='Asia/Kolkata'),
    Timestamp('2017-03-13', tz='Asia/Kolkata'),
    Timestamp('2017-04-04', tz='Asia/Kolkata'),
    Timestamp('2017-06-26', tz='Asia/Kolkata'),
    Timestamp('2017-08-25', tz='Asia/Kolkata'),
    Timestamp('2017-10-20', tz='Asia/Kolkata'),
    Timestamp('2018-02-13', tz='Asia/Kolkata'),
    Timestamp('2018-03-02', tz='Asia/Kolkata'),
    Timestamp('2018-03-29', tz='Asia/Kolkata'),
    Timestamp('2018-03-30', tz='Asia/Kolkata'),
    Timestamp('2018-08-22', tz='Asia/Kolkata'),
    Timestamp('2018-09-13', tz='Asia/Kolkata'),
    Timestamp('2018-09-20', tz='Asia/Kolkata'),
    Timestamp('2018-10-18', tz='Asia/Kolkata'),
    Timestamp('2018-11-07', tz='Asia/Kolkata'),
    Timestamp('2018-11-08', tz='Asia/Kolkata'),
    Timestamp('2018-11-23', tz='Asia/Kolkata')
]

SpecialOpen = [
    Timestamp('2016-10-30', tz='Asia/Kolkata')
]

class NSEExchangeCalendar(TradingCalendar):
    """
    Exchange calendar for NSE

    Open Time: 9:15 AM, Asia/Kolkata
    Close Time: 3:30 PM, Asia/Kolkata

    """

    regular_early_close = time(15, 30)

    @property
    def name(self):
        return "NSE"

    @property
    def tz(self):
        return timezone('Asia/Kolkata')

    @property
    def open_time(self):
        return time(9, 15)

    @property
    def close_time(self):
        return time(15,30)

    @property
    def regular_holidays(self):
        return HolidayCalendar([
            Chritmas,
            Ambedkar_Jayanthi,
            Gandhi_Jayanthi,
            India_Independence,
            May_Day,
            India_Republic
        ])

    @property
    def adhoc_holidays(self):
        return list(chain(
            OtherHolidays
        ))

    @property
    def special_opens(self):
        return list(chain(
            SpecialOpen
        ))

#This is the valid exception which i get. #helpwanted.
(/Users/praj3/anaconda3/envs/ZipPallavi) bash-3.2$ zipline ingest -b csvdir
<string>:22: UserWarning: Overwriting bundle with name 'csvdir'
Loading custom pricing data:   [############------------------------]   33% | DWARIKESH: sid 0
Merging daily equity files:  [------------------------------------]  0
Traceback (most recent call last):
  File "/Users/praj3/anaconda3/envs/ZipPallavi/bin/zipline", line 11, in <module>
    load_entry_point('zipline==1.3.0', 'console_scripts', 'zipline')()
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/zipline/__main__.py", line 348, in ingest
    show_progress,
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/zipline/data/bundles/core.py", line 451, in ingest
    pth.data_path([name, timestr], environ=environ),
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/zipline/data/bundles/csvdir.py", line 94, in ingest
    self.csvdir)
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/zipline/data/bundles/csvdir.py", line 156, in csvdir_bundle
    show_progress=show_progress)
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/zipline/data/us_equity_pricing.py", line 257, in write
    return self._write_internal(it, assets)
  File "/Users/praj3/anaconda3/envs/ZipPallavi/lib/python3.5/site-packages/zipline/data/us_equity_pricing.py", line 378, in _write_internal
    ).difference(asset_sessions).tolist(),
AssertionError: Got 497 rows for daily bars table with first day=2016-10-20, last day=2018-10-19, expected 496 rows.
Missing sessions: []
Extra sessions: [Timestamp('2016-10-30 00:00:00+0000', tz='UTC')]

Edit:
I even tried adding
@property
    def special_opens_adhoc(self):
        return [(time(9, 15), ['2016-10-30'])]

But this too throws the same exception that, This is not a Trading day.
I am missing something in my special_opens, not sure how to get this working. #help
Sincerely,
Punith
#helpwanted  #pleasehelp

how can i use zipline for indian stock market

Hi Punithmailme,
Could you please advise on how you added calendar for NSE  ?
It would be much helpful as i am trying to backtest for nse data.
Thanks


Question about payouts

Hi, great guys!
I see extreme often situation like that.

All recipient wallets are only and latest version 1.0.2
I have to wait 5-10min, cancel TXes then restart again and again.
it's in-depend of fee
Can you advice something?
Thank you.
p.s. You may join me to internal chat. I can do a lot of good for your team. From good quality bug reports/tests to... I am developing good pool for your coin. thank you. I am easy find on the cryptonet:)

Solved.


Supported file version incorrect

In the "Supported CMake and CMakePresets.json versions" section, the first sentence says "Visual Studio supports version 2 or later for the CMakePresets.json and CMakeUserPresets.json files." However, when I try to use any version later than 3, VS 2022 gives an error that it only supports file versions 2 to 3.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18671a37-b8d9-b8cd-51fc-c1cd267e6af5
Version Independent ID: 6f0932ad-998a-9449-dfff-259452ba20d5
Content: Configure and build with CMake Presets
Content Source: docs/build/cmake-presets-vs.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

@adara9
Thanks for the report. While I can update the document with this limitation, you'd probably rather have the product support the later versions of the CMakePresets files. To request this capability, I recommend using the Suggest a Feature command in the VS IDE (accessible via the Help > Send Feedback > Suggest a Feature menu). That will create a new issue in Developer Community where it will get the attention of the relevant product team members. When and if that feature is adopted, we'll update the docs again accordingly.

Thanks! The webpage that took me to said to search for similar issues
first, and I see that the team has already added support for file version 4
in the current preview release. Looking forward to seeing that in a full
release.
On Tue, Sep 13, 2022, 20:26 Colin Robertson @.***>
wrote:

@adara9 https://github.com/adara9
Thanks for the report. While I can update the document with this
limitation, you'd probably rather have the product support the later
versions of the CMakePresets files. To request this capability, I recommend
using the Suggest a Feature command in the VS IDE (accessible via the
Help > Send Feedback > Suggest a Feature menu). That will create a
new issue in Developer Community https://aka.ms/vsfeedback/browsecpp
where it will get the attention of the relevant product team members. When
and if that feature is adopted, we'll update the docs again accordingly.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/cpp-docs/issues/4161#issuecomment-1246084255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQZPEGNQWDC36LBCFSSWSDV6ELUHANCNFSM6AAAAAAQK2BOFU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Update posted.


How can I update the Node version with mupx?

The mupx-specific README suggests updating mupx itself, which I have done. It doesn't mention the use of "nodeVersion" in the mup.json, so is that still appropriate? I am trying to run DEBUG=* mupx setup and there is no verbose output (simply Installing Docker, success, Setting up environment, success).
I'm trying to update so that I can try to deploy with bcrypt imported in Meteor 1.3 or wrapped using meteor add npm-bcrypt. I keep getting error: this app is not compatible with architecture 'os.linux.x86_64', but again, I can't see any verbose output.

Updating meteor should now more recently give you <IP_ADDRESS> which solves various fiber problems (npm module building etc.), and is highly recommended. Although there might be a <IP_ADDRESS> now too?
I believe nodejs is preset in the docker containers and not as much an issue with mupx setup.
The new version of mupx is now porting over at kadirahq/meteor-up were the devs there will be more help with newer release issues.

Thanks @MasterJames, I'm running my app fine with bcrypt locally. It's only the deployment process that is affected, so I don't think it is related to my Meteor version (I've reproduced the issue in <IP_ADDRESS>). I'm unclear on how to even confirm which version of Node my Docker container is running.

Google is good for that sort of thing.
http://stackoverflow.com/questions/12014750/how-can-i-know-the-version-of-node-being-used-by-my-meteor-app

I was under the impression that the app could be running with a different node version in the docker container, and I couldn't figure out how to confirm that.
Anyway, I seem to have been mistaken on my previous comment about attempting to upgrade Meteor. I made a ton of changes to my environment and then tried again to upgrade to Meteor 1.3.2 and it seems to have resolved the problem of architecture compatibility. Separately I discovered that the bcrypt node module installed on my local machine (OS X) cannot run on my Ubuntu server, so I've resorted to using the wrapped Meteor package. Thanks for the insights.


Explain how test suites can access test fixtures

Issue type
Missing information
Problem description
Neither of these existing documentation pages shows how to use test suites in conjunction with test fixtures:
https://docs.gradle.org/current/userguide/jvm_test_suite_plugin.html
https://docs.gradle.org/current/userguide/java_testing.html#sec:java_test_fixtures
The best information I've found so far is this discussion:
https://discuss.gradle.org/t/how-do-jvm-test-suite-and-java-test-fixtures-relate-to-each-other-and-how-can-they-be-used-cross-project/46491
But even after reading that, we're left to piece together non-trivial code, and I'm still spending hours struggling with it.
If the one of the aforementioned pages could provide a build script code snippet and a good explanation of how it works, that would be so helpful!
Context (optional)
In a project that already makes use of text fixtures, it's been surprisingly difficult and time consuming to create working test suites.
Page with the problem
https://docs.gradle.org/current/userguide/jvm_test_suite_plugin.html

This is a valid documentation issue.


folder name fix

This updates folder names to be consistent with their file paths. It only changes the letter casing (which causes the file lookup to fail for some webservers).
closes #48

And one thing to note-- the imac and iMac folders were combined in this PR, which moves the .PSD into the folder. I figured this combination was okay, since this is consistent with other devices' folders. The same goes for the .PSDs in surface and ipad.
In total, this PR changes

rename macbook to Macbook
rename iphone to iPhone
merge imac into iMac
merge surface into Surface
merge ipad into iPad

Hi @bencmbrook,
will this affect the css image paths? Have you tested this?

Hey @ben182, the CSS image paths remain as they were. The data-device attributes always used proper capitalization, so the paths always resolved to the correct capitalized case. In other words, there are no API changes and it should not break any existing projects.
I've tested this, and it's running properly now on my production server (which was failing before due to the mismatched letter casing).
And thanks for this awesome repo!

Okay thanks for the help!


Abstract classes can't be instantiated after update to 4.1.1+1

This code was working fine but after update I got error.
I try several solutions, but nothing works...
Any idea how to change that?
enum AnimationTrigger {
  onPageLoad,
  onActionTrigger,
}

class AnimationInfo {
  AnimationInfo({
    required this.trigger,
    required this.effects,
    this.loop = false,
    this.reverse = false,
    this.applyInitialState = true,
  });
  final AnimationTrigger trigger;
  final List<Effect<dynamic>> effects;
  final bool applyInitialState;
  final bool loop;
  final bool reverse;
  late Adapter adapter;
  late AnimationController controller;
}

void createAnimation(AnimationInfo animation, TickerProvider vsync) {
  final newController = AnimationController(vsync: vsync);
  animation.controller = newController;
  animation.adapter = Adapter()..init(newController); //<-- Abstract classes can't be instantiated.
}
\\......

I just removed the Adapter and it works now... Sorry for the confusion ;)
enum AnimationTrigger {
onPageLoad,
onActionTrigger,
}
class AnimationInfo {
AnimationInfo({
required this.trigger,
required this.effects,
this.loop = false,
this.reverse = false,
this.applyInitialState = true,
});
final AnimationTrigger trigger;
final List<Effect> effects;
final bool applyInitialState;
final bool loop;
final bool reverse;
late AnimationController controller;
}
void createAnimation(AnimationInfo animation, TickerProvider vsync) {
final newController = AnimationController(vsync: vsync);
animation.controller = newController;
}


add acf_accordion example

Thanks for the pull request! I’m curious, could you please share a screenshot of how this looks in the administrator dashboard?

Well this specific piece of code would just render a horizontal bar with the label "Address" and an arrow that changes direction when you press it.

With a field added it would look like this:

Thanks!


Exception: Invalid json in get_vehicle_information

Running latest HA.
core-2021.12.9
Getting this in the log when starting the addon. Tried to reinstall but getting same error.
Logginformation (FEL)
This error originated from a custom integration.
Logger: homeassistant.config_entries
Source: custom_components/audiconnect/audi_services.py:257
Integration: Audi Connect
First occurred: 13:39:16 (1 occurrences)
Last logged: 13:39:16
Error setting up entry<EMAIL_ADDRESS>for audiconnect
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 313, in async_setup
result = await component.async_setup_entry(hass, self)  # type: ignore
File "/config/custom_components/audiconnect/init.py", line 106, in async_setup_entry
return await data.update(utcnow())
File "/config/custom_components/audiconnect/audi_account.py", line 162, in update
if not await self.connection.update(None):
File "/config/custom_components/audiconnect/audi_connect_account.py", line 113, in update
vehicles_response = await self._audi_service.get_vehicle_information()
File "/config/custom_components/audiconnect/audi_services.py", line 257, in get_vehicle_information
raise Exception("Invalid json in get_vehicle_information")
Exception: Invalid json in get_vehicle_information
It´s working again. Don´t know what changed. But this is solved.

closing based on comment.


Persistence Module Prototype - Base Postgres Infra & Utilities for Development

Base Postgres infrastructure to build out the V1 prototype.
Overview
Run a local Postgres instance alongside the V1 prototype LocalNet as well as some utils to debug & use it.
Changes
Config Changes
Add postgres_url and schema to persistence configs.
Makefile Changes
You can run make to see a helper of all the available make commands.
List of new / updated make commands:

make compose_and_watch - updated to run DB
make db_cli - get CLI to the containzired postgres DB
make db_bench_init and and make db_bench - WIP to benchmark DB
make db_admin - helper to open GUI
make db_drop - helper to drop all schemas matching node% -> useful before restarting containers

Testing
$ make protogen_clean
$ make protogen_local
$ go mod vendor && go mod tidy
$ make mockgen
$ make docker_wipe
$ make compose_and_watch

@andrewnguyen22 Please review the description in this PR before reviewing.

Adding @okdas as a reviewer.


Possible memory leak

Hi - I ran into a problem that looks like a memory leak. I define my model using a custom Fourier convolution layer that uses pytorch-finufft. In the optimization loop, after approximately epoch ~50 I get a standard CUDA OOM error:
OutOfMemoryError: CUDA out of memory. Tried to allocate 1.48 GiB. GPU 0 has a total capacty of 23.61 GiB of which 527.88 MiB is free. Including non-PyTorch memory, this process has 22.54 GiB memory in use. Of the allocated memory 15.10 GiB is allocated by PyTorch, and 3.19 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

The error disappears when I exclude the Fourier convolution layer (and with it any calls to pytorch-finufft). This one is a bit tricky to give a minimal example for and I am not sure if it has anything to do with pytorch-finufft.
FWIW, this is the conv function in question:
from pytorch_finufft.functional import finufft_type1 as nufft1, finufft_type2 as nufft2

def _scale_grid(x):

    xmin, _ = x.min(dim=-1, keepdim=True)
    xmax, _ = x.max(dim=-1, keepdim=True)

    x0 = (xmin + xmax) / 2
    L = xmax - xmin

    xs = 2 * torch.pi * (x - x0) / L
    volume = torch.prod(L, dim=-2)

    return xs, volume

def to_complex(t: Tensor) -> Tensor:

    if t.is_complex():
        return t
    elif t.dtype == torch.float32:
        return t.to(torch.complex64)
    elif t.dtype == torch.float64:
        return t.to(torch.complex128)
    else:
        raise TypeError(f"Cannot convert tensor of type {t.dtype} to complex.")

@partial(torch.vmap, in_dims=(0, 0, None))
def cconv(f: Tensor, x: Tensor, kernel: Tensor, *, eps: float = 1e-6) -> Tensor:

    # f.shape = (..., n_channels, npts)
    # x.shape = (..., ndim, npts)
    # kernel.shape = (..., in_channels, out_channels, *grid_shape)

    xs, volume = _scale_grid(x)

    f_hat = nufft1(xs, to_complex(f), kernel.shape[2:], isign=1, eps=eps)
    c_hat = torch.einsum("i...,io...->o...", f_hat, to_complex(kernel) / volume)
    c = nufft2(xs, c_hat, isign=-1, eps=eps)

    return torch.real(c)

Can you try some of the methods described on this page to visualize memory usage? I don't think it is necessary to run until the OOM error, just until we can see a trend in the graph to try to track down

The plot thickens.
I did both approaches simultaneously (track memory + printouts) but this time around the entire python kernel crashes. My jupyter notebook just throws:
The Kernel crashed while executing code in the the current cell or a previous cell. Please review the code in the cell(s) to identify a possible cause of the failure. Click [here](https://aka.ms/vscodeJupyterKernelCrash) for more info. View Jupyter log for further details.

I did also do a shorter run (~20 epochs) and saved the memory history pickle file. It is not showing any systematic memory increase over time. Happy to share it if you want to take a look.
I'm very confused now.

@Matematija - do you still have this code/happen to remember if you were using cuda 11.8?

Sorry - I didn't see this when this was posted. I can confirm was using CUDA 11.8.

Ok, we believe a known memory leak in CuFFT was likely the underlying cause then


Handle paths with spaces on windows for ctags

ctags now runs correctly in the background and handles paths with spaces.
Sorry for the messy commit history.  I'm still pretty new to git and didn't think to do all this in a branch other than master.

Thanks.  I'm pretty new to vim script as well.

Thanks! It's going to take me some time to test this so hang in there :)

So, are you going to test this?  It's been two months.  :)

I've been quite busy.
What's this "WIP" commit?

WIP = work in progress.  I know it's a messy commit history.  I'm still very new to git.

Can't help you there, I also often mess up with Git (which is why I use Mercurial and mirror stuff on Github via hg-git). But yeah the commit history is too messy to merge right now, sorry. I don't know what the best way to clean it is, short of re-doing it :(

Oh, I just figured you'd do a merge --squash.  But, I can redo it.  It should have been in a separate branch anyway.

Closing it since it's been a while.


Modify Calc's "todate" function so that "m/d/y" will parse any number of digits in any field

So that `todate(10/4/2022', 'm/d/y') will work right. In other words, the m|d|y are just indicators of which fields are which, but NOT the number of digits involved (since the separators will work that out).

This relates to #426, which is done, EXCEPT it makes mention of other "toXXX" functions which we don't have implemented yet.


Auto open as a page and set to full width

problem
I must always open as a page + set to full width, i lost some times to do that, and would prefere a trick in the enhancer to automatically do that.
solution
The feature can be implemented as in the other enhancement, and maybe can be separate between the two, for people who want just one or the two.

the bypassing having to click "open as page" i've made a module for, it will be released with the next update soon.
however, setting a page to full width involves changing actual page data, which the enhancer can't do at the moment.

though actually toggling the full width option is still out of scope, a page will be able to visually appear full width via setting --theme_dark--page_normal-width/--theme_light--page_normal-width to 100% in the next release. this is default behaviour if you have the "neutral" theme enabled.


Views

ref:

https://github.com/scientist-softserv/hykuup_knapsack/issues/85

Closing per Kirk's PR
Views were examined and no changes were needed


[BUG] SPI Slave driver issue

Description / Steps to reproduce the issue
Hello All.
I am Facing some issues during slave driver development.
Here I can report and talk about change done in drivers/spi/spi_slave_driver.c. PR is: https://github.com/apache/nuttx/pull/10727
This PR do bind during file open and unbind during file close. The issues is that the bind is necessary to configure configure slave controller, so, in current master, all spi transaction when file is closed will be lost.

Before this PR all spi message is saved in lower half buffer, when we do read in top half, we get data from lower half, now lower half only get spi data while top half is waiting for.

@Donny9 and @gustavonihei  let's talk about this PR, please?
@acassis Can you help me to check about expected behavior, Do we need save information after driver initialization or only during open execution?
On which OS does this issue occur?
[Linux]
What is the version of your OS?
Ubuntu 24.0
NuttX Version
master
Issue Architecture
[all]
Issue Area
[Drivers]
Verification

[X] I have verified before submitting the report.

@FelipeMdeO I think you are right, the modification seems suspicious! This is issue when someone adds a driver and don't add a testing application!
@xiaoxiang781216 could you please help and ask your team to review?

@xiaoxiang781216 is there some example using SPI Master <---> SPI Slave communication (maybe using RPMSG) ? It should be something useful to validate the driver and could help Felipe to reach his goal

@xiaoxiang781216 is there some example using SPI Master <---> SPI Slave communication (maybe using RPMSG) ? It should be something useful to validate the driver and could help Felipe to reach his goal

Yes, we made rpmsg over spi master/slave recently, but it make the significant change to rptun driver framework., so it need more time to prepare the patch.
For spi slave change, @Donny9 will take a look.

@FelipeMdeO  hello～
The purpose of this PR modification is to disable interrupts and the SPI slave controller when the application has not opened the SPI slave device, in order to conserve power consumption.
Before the device is opened by the user application, any data sent by the host is of no concern to the user application.
Even without this PR, if the host continuously sends data, the rxbuffer may overflow, resulting in data loss.
So, if the application does care about the data, it should open the device and use the poll interface to  monitor the underlying data, thus preventing data loss.
Therefore, I recommend opening the device node to prevent data loss.
 This will ensure that when the host sends data, it is received by the SPI slave lower half driver, and when you read it, the data is copied from the lower half to the top half.

@Donny9 , Thank you very much for your explanation.
I understand the implementation now and I agree, it makes sense, initialize function configure spi peripheral, open enable and close disable it.
Donny, I cannot do it work yet, can help me to understand other point, please?
In the PR: https://github.com/apache/nuttx/pull/10782
We have the change below:

but:
priv->rx_length = MIN(buflen, sizeof(priv->rx_buffer));
I think that:
while (priv->rx_length == 0) always will be false. What did I miss?

@Donny9 , Thank you very much for your explanation.
I understand the implementation now and I agree, it makes sense, initialize function configure spi peripheral, open enable and close disable it.
Donny, I cannot do it work yet, can help me to understand other point, please? In the PR: #10782 We have the change below:
but: priv->rx_length = MIN(buflen, sizeof(priv->rx_buffer));
I think that: while (priv->rx_length == 0) always will be false. What did I miss?

@FelipeMdeO  Hello:
The spi_slave_read function is used by an application to read data from the top half. It first checks if there is any data available (by verifying if priv->rx_length is not equal to 0):
If there is data available, it directly copies the data from priv->rx_buffer to the user's buffer using memcpy.
However, if there is no data available, it needs to invoke SPIS_CTRLR_QPOLL to fetch data from the lower half.
The SPIS_CTRLR_QPOLL function will call SPIS_DEV_RECEIVE to push data from the lower half into the priv->rx_buffer of the top half and updates priv->rx_length accordingly. Once this is done, the while loop  in spi_slave_read will exit , and memcpy data, finish read~

@Donny9 all drivers on NuttX needs some example application to prove it is working and to help to test. At this moment we don't know if the BUG is on ESP32-C6 or in the SPI Slave driver.
Could you please submit a simple/minimal apps/testing/spislave/ example just to receive data from other board (using spitool) and transmit back to the board?

@Donny9 all drivers on NuttX needs some example application to prove it is working and to help to test. At this moment we don't know if the BUG is on ESP32-C6 or in the SPI Slave driver.
Could you please submit a simple/minimal apps/testing/spislave/ example just to receive data from other board (using spitool) and transmit back to the board?

@acassis we will provide a new rpmsg transport on top of spi master and slave, after that you can test the basic communication through rpmsg ping command from nsh.

@Donny9 all drivers on NuttX needs some example application to prove it is working and to help to test. At this moment we don't know if the BUG is on ESP32-C6 or in the SPI Slave driver.
Could you please submit a simple/minimal apps/testing/spislave/ example just to receive data from other board (using spitool) and transmit back to the board?

okay,  i will submit later.

Hi @Donny9,
Sorry to insist, but I still haven't figured out how the read function works.
Look:

Let's consider that I'm trying to get 30 bytes, so priv->rx_length = 30;
while (priv->rx_length == 0) will be false, so we jump for:

now, read_bytes = 30;
But priv->rx_buffer isn't updated, because it is necessary call SPIS_CTRLR_QPOLL(priv->ctrlr);  what does not happen.
You explaned:
"However, if there is no data available, it needs to invoke SPIS_CTRLR_QPOLL to fetch data from the lower half."
I understand priv->rx_length always will different of zero, maybe the mistake is because we are doing sizeof instead just get value:
priv->rx_length = MIN(buflen, **sizeof**(priv->rx_buffer));
What do you think?

@Donny9 I think @FelipeMdeO is right, there is a logic error here:
  priv->rx_length = MIN(buflen, sizeof(priv->rx_buffer));
  ret = nxmutex_lock(&priv->lock);
  if (ret < 0)
    {
      spierr("Failed to get exclusive access: %d\n", ret);
      return ret;
    }

  while (priv->rx_length == 0)

The MIN(buflen, sizeof(priv->rx_buffer)); never will return 0, unless the user ask to read 0 bytes, what makes no sense either.
Please review the code or submit a minimum example showing that it will work.

@Donny9 I think @FelipeMdeO is right, there is a logic error here:
  priv->rx_length = MIN(buflen, sizeof(priv->rx_buffer));
  ret = nxmutex_lock(&priv->lock);
  if (ret < 0)
    {
      spierr("Failed to get exclusive access: %d\n", ret);
      return ret;
    }

  while (priv->rx_length == 0)

The MIN(buflen, sizeof(priv->rx_buffer)); never will return 0, unless the user ask to read 0 bytes, what makes no sense either.
Please review the code or submit a minimum example showing that it will work.

@acassis @FelipeMdeO You are right,  sorry, We have reverted this PR（https://github.com/apache/nuttx/pull/8769) internally, but it hasn't been committed yet. It's true that it would cause the read function to stop working. Revert PR: https://github.com/apache/nuttx/pull/13337, @FelipeMdeO you can try with this PR.


Investigate "ba_prop_club_emis_rig_01" and "cs6_08_props_combo0120_90_lod" collision

@DurtyFree sorry for the ping, but I believe this is an issue with your data

hi, can you describe further?

I believe "cs6_08_props_combo0120_90_lod" is made-up because it collides with "ba_prop_club_emis_rig_01" which seems to be the real key, but your data has it wrong: https://forge.plebmasters.de/objects/cs6_08_props_combo0120_90_lod

Ah i see, I just digged into it and it seems to be a collision in codewalker. The model name is picked up from a related ytyp update\x64\dlcpacks\mpbattle\dlc1.rpf\x64\levels\gta5\props\prop_battle_lights_02.rpf\ba_prop_battle_lights_02.ytyp which lists the name cs6_08_props_combo0120_90_lod as associated asset name, which doesnt exist as a model but is a collision to the real one (ba_prop_club_emis_rig_01), so thats where this name came from.
Not sure if I will dig into this further, seems to be a rare case of a collision

Ah, so you also got the name from elsewhere? I'm just kinda concerned that someone has been making up hash names and now my database might be poisoned, but oh well. Thanks for looking into it, and I hope you can at least correct this in your data.

I fixed this collision manually, sadly I cannot know whether something is a collision or not :/ I will try something out but feel free to let me know if you find any more issues / collisions.
You can also drop me a message at discord: DurtyFree#3216
https://forge.plebmasters.de/objects/ba_prop_club_emis_rig_01

I have found more invalid hash collisions and fixed it:
            { "cs6_08_props_combo0120_90_lod", "ba_prop_club_emis_rig_01" },
            { "0", "p_mp_door_07" },
            { "s_m_m_pilot_85_lod", "v_39_ventilation" },
            { "hw1_02_247_10_lod", "kt1_16_dirt0302" },
            { "id1_26b_26_lod", "vb_rd_cablemesh9665_thvy001" },
            { "a_f_y_soucent_17_lod", "ch2_05d_upper_res4_dtl" },
            { "sc1_props_combo0804_77_lod", "cs1_13_houses" },
            { "ch2_02_retwall00_lod_lod", "cs1_11_decals17" },
            { "ch1_05_props_combo53_92_lod", "cs3_07_glue_05" },
            { "ch1_10_props_combo34_62_lod", "cs3_07_props_wire_025" },
            { "cs1_07_props_combo23_97_lod", "ar_prop_gate_cp_90d_01b_l2" },
            { "dlc_gtao_heist_planning_board_heist_board_print", "bkr_prop_prtmachine_dryer" },
            { "ch2_03_land06_lodb", "ex_office_01c_floorlamp_recept" }
     ```


New CommonsChunk vendor algorithm/functionality

Do you want to request a feature or report a bug?
Feature.

What is the current behavior?
Currently CommonsChunk is great for applications that explicitly define chunks, but for applications that don't, there's an issue... we have to explicitly declare all of our vendors, which change, and every time a dependency is removed/added, we have to update that list of vendors.
There's also the added issue that when we define that list of vendors we'd like to include in our vendor.js, we're typically going to request that the entire dependency and functionality of that dependency is included so that we don't get errors or lose functionality. That means that for certain dependencies, we end up including the entire dependency, even if we're only using one function from it.
I'd like to propose that CommonsChunk plugin scans the list of dependencies for each file, and it counts import statements for each dependency. If the count for a particular dependency is greater than the minDependency (or we could call it minImport) value, it's safe to assume that because of how common that dependency is within the application (and how often it's being imported) that it's an essential part of the application's vendors and isn't going away any time soon.
So we automatically take that dependency and bundle it into the vendor.js file.
This means that we get vendor.js, and its beautiful caching properties, without the pain of continuously having to modify our config file.
If this is a feature request, what is motivation or use case for changing the behavior?
It's a total pain to constantly be updating vendors.

As a side note, we could generate a hash based on the contents of the file, which would allow our clients to know when the vendor file has changed (useful for cache busting).

Technically that's how the algorithm works today. Check out the source of CommonsChunkPlugin and you'll see that it checks against all entry chunks (or a specified subset), and then tracks the number of times a module.is requested from each chunk. If it turns out that the module spans at minimum (unless minChunks is specified) across chunks. If so, it separates that code into a new bundle. Ideally youd provide a name for that bundle with the filename property.
In regards to your second concern: take a look at this section I wrote on passing minChunks property a function.
https://webpack.js.org/plugins/commons-chunk-plugin/#passing-the-minchunks-property-a-function

@TheLarkInn So could that be accomplished with something like this?
new webpack.optimize.CommonsChunkPlugin({
    names: Object.keys(package.dependencies),
    filename: '[chunkhash].vendor.js'
})

new CommonsChunkPlugin({
  name: "my-single-lib-chunk",
  filename: "my-single-lib-chunk.js",
  minChunks: function(module, countOfHowManyTimesThisModuleIsUsedAcrossAllChunks) {
    // If module has a path, and inside of the path exists the name "somelib",
    // and it is used in 3 separate chunks/entries, then break it out into
    // a separate chunk with chunk keyname "my-single-lib-chunk", and filename "my-single-lib-chunk.js"
    return module.resource && (/somelib/).test(module.resource) && count === 3;
  }
});

This is the example seen above from the docs page. Maybe you aren't understanding (or maybe I am not understanding).
It would be fair to say that any module you request from your import/require statements will come from node_modules right?
So you could implement exactly what you are talking about by modifying the above example to instead of being a regex to some lib, to be instead /node_modules/. This will automatically collect all requests which come from node_modules and move them to a separate chunk.

@TheLarkInn I see what you mean now, that works great. UglifyJS gives a ton of warnings though when it's setup that way.

And there's more.
This doesn't typically happen - how can we suppress this?

@TheLarkInn that works great, thanks.

This still requires you to list all modules from node_modules in the entry object though, don't you? As in
  entry:   {
    app: './app.js',
    lib: [
      "axios",
      "es6-promise",
      "fast.js",
      "google-map-react",
      "jed",
      "jquery",
      "mobx",
      "mobx-react",
      "mobx-react-devtools",
      "moment",
      "moment-timezone",
      "pikaday",
      "po2json",
      "react",
      "react-dom",
      "router5"
    ]
  },
  output:  {
    path:          './build/app.js',
    publicPath:    '/events/build/js',
    filename:      "[name].js",
    chunkFilename: ".js"
  },

etc.?

Ah, nevermind. I have just re-read "Implicit Common Vendor Chunk" section.


to_datetime function to convert strings to dates

Describe your feature request
Convert a string column into a Datetime column, with the ability to supply a format argument and other options.
export const to_datetime = (
        format: str,
        time_unit: TimeUnit | None = None,
        time_zone: str | None = None,
        strict: bool = True,
        exact: bool = True,
        cache: bool = True,
        utc: bool | None = None,
): Expr => {
        ...
}

Python/Rust API: https://pola-rs.github.io/polars/py-polars/html/reference/expressions/api/polars.Expr.str.to_datetime.html#polars-expr-str-to-datetime
Python Implementation: https://github.com/pola-rs/polars/blob/1313e59009edd1d6e6f85ef9be32c4706cc4d0b8/py-polars/polars/expr/string.py#L80-L159
I saw this function but I don't think this is an entrypoint/exposed in the public API:
https://github.com/pola-rs/nodejs-polars/blob/e6c1edb2d16da906ab2f41e8341dbe71f7e2708d/src/lazy/dsl.rs#L580

so we are slightly behind on mirroring the python apis. This method used to be called strptime.
https://pola-rs.github.io/nodejs-polars/interfaces/StringNamespace.html#strptime

py-polars has both strptime and to_datetime, nodeje-polars has only strptime.
Are you missing any parameters from strptime?


merge from main into live

Docs Build status updates of commit 7ac1116:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 7ac1116852e1627ecc20af2947c77f9c9031cc6b in branch main of repository https://github.com/MicrosoftDocs/bingmaps-docs into branch live (commit 4f110bd565fa4353a3452f318a0842a435ecf67f). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 628a022:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/retired/traffic-coverage-old.md
:warning:Warning
View
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

BingMaps/articles/TOC.yml
:white_check_mark:Succeeded
View

BingMaps/coverage/transit-coverage/north-america.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/routes/route-data.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/toc.yml
:white_check_mark:Succeeded
View

BingMaps/retired/bing-maps-on-azure-marketplace.md
:white_check_mark:Succeeded
View

BingMaps/retired/truck-routing-coverage-old.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/mapstylepickertrafficswitchtoggledeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmapstylepickertrafficswitchtoggledlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/index.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/mapuserinterfaceoptions-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-concepts/index.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-services-api/index.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/TOC.yml
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/map-control-api/index.md
:white_check_mark:Succeeded
View

BingMaps/retired/traffic-coverage-old.md

Line 25, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'media/BingMaps_Traffic_Flow_2018.PNG'.
Line 33, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'media/BingMaps_Traffic_Incident_2018.PNG'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Reduce test execution time in syslog

# master
% bundle exec ruby test/plugin/test_in_syslog.rb
Loaded suite test/plugin/test_in_syslog
Started
.......

Finished in 10.643330534 seconds.
--------------------------------------------------------------------------------
7 tests, 34 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------
0.66 tests/s, 3.19 assertions/s

# This branch
% bundle exec ruby test/plugin/test_in_syslog.rb
Loaded suite test/plugin/test_in_syslog
Started
.......

Finished in 7.054952274 seconds.
--------------------------------------------------------------------------------
7 tests, 34 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------
0.99 tests/s, 4.82 assertions/s

I added #1117.

I've rebased and added mising assertions.

LGTM. Thanks!


Implement annotated tag support.

Closes #4.

Released in v1.1.0.

Truly amazing.

Not knowing how it worked internally was killing me.

It's a slippery slope to becoming a git core contributor. What's next? BBQs at Linus' house?

I do like good BBQ, I might be a goner....

This still does not work for me. I created an annotated tag
git tag -a 1.0.1 -m 'Hotfix'
Checking out this tag (git checkout 1.0.1), this still gives me null for info.tag
var getRepoInfo = require('git-repo-info');

var info = getRepoInfo();

info.sha //=> Works as expected
info.tag //=> Gives null

Did I misunderstand how this is supposed to work?


Zend_Navigation_Page_Mvc::isActive() doesn't seem to be functioning properly

A preliminary look at the source shows that $this->_active is not null so the condition if (null === $this->_active) { ... } is never met so the logic to actually figure out if the page is active or not is never run. I commented out the condition and it seems to fix the problem. My active pages were now showing in the navigation.
I output the value of $this->_active before the condition and it was boolean false. I'm couldn't seem to find where this could be set to false since Zend_Navigation_Page_Mvc initializes $this->_active as null, overwriting Zend_Navigation_Page.
I realize this a hack way to do it, but don't have a lot of extra time to dig deeper.
ZF 1.12.16
Thanks for any help!

A preliminary look at the source shows that $this->_active is not null so the condition if (null === $this->_active) { ... } is never met so the logic to actually figure out if the page is active or not is never run.

This not true. Please take a look into the unit test for this class.
Please provide an unit test to illustrate your problem.

Ok, thanks. I will do ASAP.

(I fixed the link.)
Is this still a problem?

Closing due inactivity.


Sub-task ranges on profiles

The application code would be able to open and close "ranges" inside a task, and associate a name with each range. Nesting of ranges would be supported.
task foo() {
  // do stuff
  push "part 1"
  // do stuff
  push "sub-part 1a"
  // do stuff
  pop
  // do stuff
  pop
  // do stuff
}

In the profile, these ranges would be overlaid directly on top of the parent task's box (like a wait interval is visualized today):

Note that a wait can occur while we have pushed a user range, so on the profile we would go to a "waiting" state, then back into the last used color.
This feature would be useful for debugging mapper performance (we would mark on the profile which part of a mapper call task is executing user code, and which is doing runtime work), and for apps to visualize how much time certain parts of a task are taking.
On the profiler side, this could be done as a generalization of the existing TaskWaiter infrastructure; instead of having a fixed sequence of points (created, ready, start, stop), we could generalize this to any number of intervals (of which the default happen to be running/blocked/ready).
Note that we can't actually paint over rectangles in the new UI. So at some point in the pipeline we need to slice things into non-overlapping segments.

You want this ability just inside the mapper or also in the application? The mapper is probably straight-forward since there's no deferred execution in the mapper, but if you want it in the application that will be a bit more work.

Does deferred execution matters? If we have the following code:
task foo() {
  // do stuff
  push green
  // do stuff
  launch task B
  pop
  // do stuff
}

The launch task B is a deferred execution, and it will be visualized somewhere else but not inside task foo.

It depends entirely on what "do stuff" is. If "do stuff" is perform computation in this task then no. If "do stuff" is launch some sub-tasks, then it matters quite a lot.

My usecase is for the mapper, but @rohany expressed interest in having user-controlled ranges in application tasks (I'll let him explain his usecase more), so I made the ask a bit more general.
I was assuming that the range-enter / range-exit annotations would not consider deferred execution. I.e. all that the runtime would need to do is dump a marker at the point when control reaches a "push" or "pop" point, regardless of any asynchronous work that had been launched prior to that point. If the code did this:
enter task
push "range 1"
launch sub-task
pop
wait on sub-task

then the range on the profile would only include the launching time, not the waiting. This is sufficient for profiling mapper calls, but maybe @rohany had different requirements?

I agree with @manopapad , the range will only include the launching time, and the wait will be shown as WaitInterval of the task.

My usecase is for the mapper, but @rohany expressed interest in having user-controlled ranges in application tasks (I'll let him explain his usecase more), so I made the ask a bit more general.

I think having it in the application would be quite beneficial to many users. The use case I'm imagining was when thinking about adding some more sophisticated fusing / partitioning logic to legate. In the case where we batch many tasks up together and try to fuse or bulk partitioning things, it would be nice to demarcate the ranges that we actually spend thinking about this, to understand the overheads involved. I suspect other applications that do non-trivial reasoning in top-level tasks would also be interested in this. What I don't think we should do is try to support something like this at small granularities to help profile hot loops or something in compute task bodies, as that's something better left for other benchmarking tools.

I suspect everyone is going to want what @rohany is asking for, but that will take more time to implement, but I'd rather do that than something just hacks in the range timing for launching tasks. If we're just going to support this in the mapper to start though then that is an obvious thing to do since there is no deferred execution there.

demarcate the ranges that we actually spend thinking about this

It didn't sound to me like Rohan is asking for anything different than I did. He also just wants to show on the profile a range of time spent doing computation in the task, which includes just time in the task, and doesn't recursively include any time spent in launched sub-tasks.

Another useful case for application-level support we found is to analyze top-level tasks. With the current profiler, the users only see a single big top-level task running as follows:

But, with this functionality, users can see more fine-grained tasks within a single big top-level task. This will allow us to investigate issues with top-level tasks, e.g., #1448.

An alternative visualization would be to "stack" the different ranges:

We could possibly do this "on demand", when the user hovers/clicks on a box (otherwise we only show the top parent box).


Huge numbers give NaN0000 over and over when using .toString()

For example, if you do something like this:
var a = bigInt(2).pow(1000000).minus(1);
document.write(a.toString());
The printed result is:
http://pastebin.com/PBks4FPu
If you go towards the bottom there's actual numbers, but it starts off with that mess. What's going on here?

Thanks for the bug report. This was caused by a bug in the Karatsuba multiplication function. It should be fixed now.


Visual Studio 2022. Sometime 'add using' code fix do not work for blazor web assembly

This issue has been moved from a ticket on Developer Community.

Hi,
Visual Studio 2022(17.0.0, current).
Sometime 'add using' code fix do not work for blazor web assembly
thank you

Original Comments
Feedback Bot on 11/9/2021, 05:07 PM:
This issue is currently being investigated. Our team will get back to you if either more information is needed, a workaround is available, or the issue is resolved.
Fire Zhang [MSFT] on 11/23/2021, 11:30 PM:
Thank you for taking the time to log this issue!
Regrettably, I can’t repro the issue on the latest version of VS2022 Enterprise(17.0.1) with following repro steps:

Create project Blazor WebAssembly App
Wait for loading finished and build the solution (Result: build successfully)
Open “FetchData.razor” and comment out “@inject HttpClient Http”
Result: “Add using” works fine on error line
Can you firm these steps and tell me at which step you failed?

Roma on 12/1/2021, 00:57 PM:
Hi,
Steps:

create new blazor wasm project
delete _Imports.razor
open FetchData.razor
move cursor to ‘forecasts = await Http.[cursor possition]GetFromJsonAsync<WeatherForecast[]>(“sample-data/weather.json”);’ line
try to use ‘add using’ refactroing

thank you
Feedback Bot on 12/1/2021, 00:03 AM:
We will close this report in 14 days because we don’t have enough information to investigate further. To keep the problem open, please provide the requested details.

Original Solutions
(no solutions)

See repro steps, I can reproduce following those steps, this is definitely odd!

I investigated and it looks like the C#'s resolve code action endpoint is hanging indefinitely until the request gets cancelled. Moving to dotnet/roslyn.


Backup error - unexpected EOF

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.
1. $ influx backup   /backup/influxdb/backup_$(date '+%Y-%m-%d_%H-%M')   -t {token}
2.  receive an error after a while (Error: failed to backup bucket data: failed to download snapshot of shard 103: http: unexpected EOF reading trailer)

Expected behavior:
finish backup without errors

Actual behavior:
receiving an error before backup finishes

Environment info:

System info: Run uname -srm and copy the output here

- Linux 5.13.0-28-generic x86_64
- Ubuntu 20.04.2 LTS

InfluxDB version: Run influxd version and copy the output here

- InfluxDB 2.0.8 (git: e91d41810f) build_date: 2021-08-13T18:22:30Z
- Influx CLI 2.3.0 (git: 88ba346) build_date: 2022-04-06T19:30:53Z

Config:
Copy any non-default config values here or attach the full config as a gist or file.
http-write-timeout = "5s"
query-concurrency = 10000
http-bind-address = ":8086"
http-read-timeout = 0

Logs:
Error: failed to backup bucket data: failed to download snapshot of shard 103: http: unexpected EOF reading trailer

Performance:
Generate profiles with the following commands for bugs related to performance, locking, out of memory (OOM), etc.
# Commands should be run when the bug is actively happening.
# Note: This command will run for ~30 seconds.
curl -o profiles.tar.gz "http://localhost:8
086/debug/pprof/all?cpu=30s"
- curl: (52) Empty reply from server

iostat -xd 1 30 > iostat.txt
# Attach the `profiles.tar.gz` and `iostat.txt` output files.

iostat.txt

I have a similar error message.
Backup command:
influx backup /tmp/backup/influxdb -t 'token'
Output:
2022/06/05 10:25:06 INFO: Downloading metadata snapshot
Error: failed to backup metadata: failed to save local copy of KV backup to "20220605T102506Z.bolt": unexpected EOF

Same issue when running influx backup --host "$INFLUXDB_HOST:$INFLUXDB_BACKUP_PORT" --org "$INFLUXDB_ORG" --token "$INFLUXDB_TOKEN" "$BACKUP_PATH":
Influx CLI 2.3.0 (git: 88ba346) build_date: 2022-04-06T19:30:53Z
InfluxDB v2.2.0 (git: a2f8538837) build_date: 2022-04-06T17:36:40Z
Error: failed to backup bucket data: failed to download snapshot of shard 219: http: unexpected EOF reading trailer

Thanks for the reports. This looks like an error coming from the CLI where it is encountering some failure when downloading the shard from influxdb itself.
Is this something that is frequently reproducible or transient? If reproducible, can you provide logs from influxdb?

It is reproducible on every backup run, log file attached:
influx.log

I could solve the problem for me. In the Logs InfluxDB always claimed that it doesn't have the permission to open the influxd.bold file. However, this file is owned by the user 1000 and shouldn't make any problems.
The problem was that the InfluxDB volume was a cifs network mount. The cifs mount had the correct uid and gid (1000), but the network share host had a different owner of the share (that I can't change). I now solved it with just exposing the engine directory to the network share and keeping the influxd.bold file local on the docker host.

Have you set the value of http-write-timeout in the influxdb configuration file, during the backup process, once this time is exceeded, an error will be reported

size of data dir: 260GB
observation: shards having 0 byte files when the error occurs
during the runtime of influx backup, the influxdb is under heavy load of writes from IoT device fleet (~17K pieces)

when my db is so large, I would like to backup cold shards, and skip active shards


Create feature flag library

We have a number of trial features or new strategies to handle this/that, across all of Istio. While some have CLI flags and associated CRDs, some do not.. Esp pilot, that has a host of env variables that not only pollute the core code, but make it harder to follow, when things go wrong. Some of these variables are also long forgotten.
It would be good to have a single place (e.g., pkg/features/pilot.go) where we define variables that hold all these feature flags/settings obtained from env vars. The rest of the code could simply use the if(feature_set), do x else do y . This should make it easy for us to track what things are in experimentation mode (e.g., throttle debounce, etc..) and once things are stable, we can remove the feature flag and make it the only implementation (i.e. remove the else case).
We could also have a loop that periodically scans these env vars and updates the feature flags so that people can turn it on or off dynamically.

cc @hzxuzhonghu / co or others, if you are looking for a TODO, this is a big one :).

Let me have a try.
/assign


wis2box-ctl.py start issue: Named volume is used in service  mosquitto/pygeoapi but no declaration was found in the volumes section.

I have followed the Quickstart procedure but I bump into this:
[rocky@vps-1b403fa7 wis2box]$  python3 wis2box-ctl.py start
ERROR: Named volume "${PWD}/data:/data/wis2box/data:rw" is used in service "mosquitto" but no declaration was found in the volumes section.

Funny enough, if I repeat the command, I sometimes get another (related) error:
[rocky@vps-1b403fa7 wis2box]$  python3 wis2box-ctl.py start
ERROR: Named volume "${PWD}/data:/data/wis2box/data:ro" is used in service "pygeoapi" but no declaration was found in the volumes section.

Context:
rocky@vps-1b403fa7 wis2box]$ cat tests/test.env
# Required
# Host machine data directory path
WIS2BOX_HOST_DATADIR=${PWD}/tests/data

# Optional
# Environment variable overrides
WIS2BOX_LOGGING_LOGLEVEL=DEBUG
WIS2BOX_DATA_RETENTION_DAYS=30

rocky@vps-1b403fa7 wis2box]$ cat /etc/centos-release
Rocky Linux release 8.5 (Green Obsidian)

[rocky@vps-1b403fa7 wis2box]$ /usr/bin/docker-compose  --version
docker-compose version 1.25.0, build 0a186604

Hi @davidpodeur. dev.env uses interpolation to get the absolute path of the working directory with ${PWD} (dotenvy docs). It seems like your machine is passing the un-interpolated value for WIS2BOX_HOST_DATADIR to docker-compose. Because it is passing a string (i.e. WIS2BOX_HOST_DATADIR=${PWD}/test/data) instead of the path to data (i.e. WIS2BOX_HOST_DATADIR=/home/runner/work/wis2box/wis2box/tests/data) docker-compose is trying to mount the volume named ${PWD}/test/data (which doesn't exist) instead of mounting the directory from the host machine into the container.
I know this is an issue for windows machines that use cd instead of their Linux/Unix counterpart, PWD...
Some ideas:

Add PWD to dev.env:

# Required
# Host machine data directory path
PWD=/my/working/directory
WIS2BOX_HOST_DATADIR=${PWD}/tests/data

Try ${pwd} or ${cd}. This is second because I am not sure about the system environment variables on an OS basis. I don't want to send you on a wild goose chase for something that could be easily hardcoded.

Hope this helps! Let me know how it goes :)


Add apollographql/apollo-kotlin project

The apollo-kotlin repo has 4 issues with :wave: Good First Issue label. Depends on #394.

I will pick up this issue and create a PR.

:wave: Good First Issue is a non standard label and does not make sense to add this project. So I will check to see if the apollo-kotlin can add either good first issue or good-first-issue.


fix bug about sec-websocket-protocol

fix bug when sec-websocket-protocol and sec-websocket-extensions appear in header

I want to you merge this PR.
My python-3.6 websocket client application has same problem, cannot connect to websocket server implemented nodejs.
I think this problem is critical.
My application patched this PR, can connect websocket server.
Please merge and as soon as possible release bugfix version this problem and some important fixes.

@Lawouach can you please fix this one? Or review it?

Thank you

No pb. I will release a new version today.

Thank you.


dev(narugo): fix bug for tensorboard loggger

PLEASE run your code before pushing here!!!
That's all.

Already fixed


Announcements optimizations

This PR brings several enhancements for announcements, like

Allow to specify a device port to be used for the device and announcement (allows running multiple devices on the same host)
Allow to specify an announcement network Interface to prevent iterating all interfaces (including some not relevant ones, prevents https://github.com/mfucci/node-matter/issues/184)
Announce a device for 15 mins (in 1minute intervals), 15mins as by specs
Announce all Fabrics when restarting a device from persistent fabrics (enhances #63)

Notes: The handling with overlapping of announcements and an opened additional commissioning window is not perfect, but that topic will be restructured soon anyway for high level API when bringing all together. It works as needed for now

@Apollon77 I take it that node-matter if fully abandoned now and this PR sorts out some of the issues you and I were working on in the previous library?

@vves basicslly yes. I took over the announcement interface from your PR but left out the "still in discussion" IPv6 topic because i still do not understand why you have issues.
That's why I left the PR in node-matter open and we continue discuss there. Or you open a new PR in matter.js (Code places are same-ish)

@turon I adjusted Readme to better state what the announceinterface is for and I answered your other comments. Announcement will also be adjusted with high level API

Additionally - the importance of the announceinterface is that on multi-nic systems, each network interface will announce a different *.local mdns name.  In my case, I have two physical and one virtual nic and I have three different devices announced on mdns unless a single interface is selected.


[java] Parse METHOD generic type

For example:
public static <T> void bind(T);
Should have:
signature: <T> bind(T)
short_description: <T> void bind(T)
And:
public static <T extends Bar> void bind(T);
Should have:
signature: <T extends Bar> bind(T)
short_description: <T extends Bar> void bind(T)
Right now, short_description is parsed correctly, but only because object_type = '.+?\s+' matches <T> void, which is actually a bug. object_type should match void instead.
Right now, signature is not parsed correctly. It is parsed as bind(T) when it needs to have the typed parameter as well to distinguish from the two cases above which are both legal in the same class.

🎊 My diff is ready for review at http://codereview.cc/D1505


cilium-cni: allow for compilation with cgo disabled

This PR refactors some existing code to remove the transitive dependency pkg/bpf from any dependencies used by plugins/cilium-cni. It updates the version of github.com/vishvanada/netlink , a dependency of plugins/cilium-cni, to a newer version which does not require cgo to be enabled. With that dependency update, an update to golang.org/x/sys/unix was also required. Finally, sets CGO_ENABLED=0 for compiling cilium-cni (see
https://golang.org/cmd/cgo/#hdr-Using_cgo_with_the_go_command for more information about this).
Fixes: #5055
Signed-off by: Ian Vernon<EMAIL_ADDRESS>allow for cilium-cni to run on non-glibc platforms

How to test:

Run $ cd plugins/cilium-cni && make clean && make cilium-cni . The output will be the following, indicating that cilium-cni compiles without the need for cgo.

$ cd plugins/cilium-cni && make clean && make cilium-cni
go clean
rm -f cilium-cni
# Compile without cgo to allow use of cilium-cni on non-glibc platforms - see GH-5055
CGO_ENABLED=0 go build -ldflags '-X "github.com/cilium/cilium/pkg/version.Version=1.2.90 2b3650dac 2018-08-16T07:33:15-07:00 go version go1.10.3 linux/amd64"' -o cilium-cni ./cilium-cni.go
$ echo $?
0
$

This change is

test-me-please


./scripts/releng/update-release-info.sh cannot download the related images

this script directly replace the whole content of content/en/releases/release.md, cause two problems:

lose header part, like title and type info
will not download the related image, now is release-cycle.jpg and release-lifecycle.jpg

shall we improve this script or leave it by human handling?

/triage accepted
/language en

/sig relase

Hi @howieyuen as #34049 has been merged can we close this issue? Please let me know if anything pending on correcting scripts files.
Thanks!

/close


[Feature Request] Separate downloading and parsing

There seem to be a number of open issues (e.g. #55 #42 #29 #22) related to the downloading of a feed. One of them (#55) is quite important.
I think the library is excellent, but it does too much.
Parsing:
It would be nice if we could use it for parsing only, by supplying our own XML strings.
Downloading:
For those who want to use it for downloading as well, the existing methods could be used (so I'm not referring to a breaking change). However, the HttpClient should be initialised in a static constructor, so that only those users who want it will actually cause it to be created. Those who don't use it - and only use the parser - would not cause the client to be created.

I forked this repo and removed all the HttpClient stuff from it. The library only does parsing now. Also I ported to .NET 8.
https://github.com/Roald87/FeedReader


StackEdit goes into offline mode when trying to save to Dropbox

After writing a draft of a document in StackEdit 4.3.12 on my Chromebook, I tried to synchronize it with Dropbox by selecting # > Synchronize > Save on Dropbox. I typed the path to the folder on Dropbox where I wanted to save the document but when I clicked OK, a messaging saying You are offline displays.
My Chromebook is still connected to the internet (I can access other sites in other tabs). This only happens with Dropbox. I can save and sync with Google Drive.

Same issue here. Thought I move to Dropbox after the sync issues that StackEdit has in the last time with Google Drive. But this seems to be even worse (read: not work at all).
Any update on this?

same issue here, "You are offline" , but I can go to internet

Same here.
"open from Dropbox" returns a 404 error.

I'm also getting the same error with both Dropbox and Google Drive sync

Please open a new ticket if not fixed in the v5.


[Issue]: CaptainAgent follow up tasks

Describe the issue

More comprehensive tests
Add tests in github CI/CD workflow
Tool/Agent lib structure

Steps to reproduce
No response
Screenshots and logs
No response
Additional Information
No response

For Tool/Agent lib structure - if this refers to including in package, see PR #76


App translations

UI and API's for custom app translations
Probably best if we refactor it as well since it's quite ugly and ndb handles this usecase much better.
Estimated time: 12h

Issue migrated to our-city-app/plugin-mobicage-control-center#20


Add force feature

I want to add a feature for "forceful" decoding by deleting chars from the end and beginning until a result is found. Sometimes I have dirty protos which are just 1 char away from being validly decodable - e.g. leading VarInt from a size-delimited stream, or a trailing EOF.
This will likely be a --force flag:

Copy data somewhere
Retry validation until no error, while deleting trailing chars in a loop
If no results, re-copy, retry validation while deleting leading chars in a loop

This is the new default behavior.


Setup Google Tag Manager in static pages

@alonsogarciapablo setup Google Tag Manager in the previous non-static dashboard pages, but as of June 25th with the new static pages deploy it was lost. So this PR brings them back to life.
Related to https://github.com/CartoDB/cartodb/issues/14029

Here're the instructions to setup GTM:

This is the template that renders the <noscript> tag:
https://github.com/CartoDB/cartodb/blob/master/app/views/shared/_google_tag_manager_no_script.html.erb
Thanks @jesusbotella!

No, the <noscript> tag is not being included because it would be useless in the static pages. All the scripts and stylesheets are being inserted to DOM via JS, so if JS is disabled the page wouldn't load at all. That's why I didn't include that one.

Ok. There are GTM credentials in staging, so we can deploy it there to verify everything is 👌.

I think we should ask for a Backend review as well to be sure that changes in Ruby are OK ;)

:+1: Ruby code seems pretty straightforward... Should we quickly verify in staging?

Yes, let's try in staging first to make sure nothing fails ;)

Working like a charm!

🚀  Thanks @jesusbotella!


Switch to the container-based infrastructure on Travis

This uses the PHP builtin webserver to expose web fixtures rather than installing Apache. This relies on the fact that PHP 5.6 is installed on Travis even on jobs running with a different version, and so can be used for fixtures on all jobs (and we don't care about the PHP version used to run fixtures as we were not using the Travis one before anyway).
If this works fine, I will apply it on other driver repositories needing a webserver to expose fixtures (i.e. all except BrowserKitDriver)

Works (for the remaining failure, see #206)

OK.

This can be re-tested now and should work fine. Clever idea to always use the 5.6 webserver.


swc_cli installation fails on windows

Describe the bug
hello, while installing swc_cli on windows I get this error
   Compiling swc_ecma_ext_transforms v0.114.2
   Compiling swc_ecma_lints v0.93.1
error[E0599]: no method named `atom` found for reference `&swc_ecma_ast::ModuleExportName` in the current scope
   --> C:\Users\lukas\.cargo\registry\src\index.crates.io-6f17d22bba15001f\swc_ecma_ext_transforms-0.114.2\src\jest.rs:110:68
    |
110 | ...                   if HOIST_METHODS.contains(exported.atom()) {
    |                                                          ^^^^ method not found in `&ModuleExportName`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `swc_ecma_ext_transforms` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `swc_cli v0.91.270`, intermediate artifacts can be found at `C:\Users\lukas\AppData\Local\Temp\cargo-installvPUYRz`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Versions
rustc --version
rustc 1.78.0 (9b00956e5 2024-04-29)

rustup --version
rustup 1.27.1 (54dd3d00f 2024-04-24)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.78.0 (9b00956e5 2024-04-29)`

OS: Windows 11
Input code
No response
Config
No response
Playground link (or link to the minimal reproduction)
https://play.swc.rs/?version=1.5.24&code=H4sIAAAAAAAAA1WNMQ7CMAxFd5%2FCY3OFdqlgYmPgAk7qSiATR7ErFVW9eyMEQvzxf73%2Fxkt%2BcHKKwl0AXotWxyRkhjc2P%2BuzaObsyKtzngxPZPxrNwBsGa9VS7fhxDMt4j3OJMa4h%2Fdalij3hN7%2BeoyqwpQHgB2%2Bvg%2FWqORaX92fOQxwAFAhVQmlAAAA&config=H4sIAAAAAAAAA2WPSw7CMAxE9z1F5TULYIEEd%2BAQUepWQc1HtisRVb17kzYNIHbxvHjGMzdtCy%2FW8Gjn9ExDUMRIdU4KRyfqnRSQGJA1mSBwOqhwRr0aGavWofakxBMnJDThBpadgygaULIf8vV8uRcvGL1n%2FPUCa5zp4%2Fc12ttAyPwXapUbxrq%2FJzYlFazvpg2WlrnJfsENPp%2BOsGoMhp%2FH5tZjWQEa0ouIMQEAAA%3D%3D
SWC Info output
No response
Expected behavior
swc_cli will install
Actual behavior
Errors
Version
newest
Additional context
No response

Duplicate of https://github.com/swc-project/swc/issues/9018


Disregard order in 'Symmetric Difference', again

Not sure what happened to #1671, but looks like it was lost in migration.
Fix #2224

#2912 had a better solution. Closing this as obsolete.


Centering not working when having horizontal and vertical taskbar simultaneously

I have a multi-monitor setup.
On one monitor i have a vertical taskbar, on the other one it is horizontal.
Unfortunately, the icons are only being centered on one of them, in this case the vertical one:

Keep up the good work!

It looks like you're using an older version... Which is not capable of doing that.


[Tests-Only] Remove unneeded TestAlsoOnExternalUserBackend local_storage skipOnLDAP tags

See core PR https://github.com/owncloud/core/pull/37616 - all these tags no longer need to be specified.
skipOnOcis is the important one.
PR #346 demonstrated that this will work.

https://cloud.drone.io/owncloud/ocis/775/3/7
API acceptance tests
391 scenarios (391 passed)
good


Update RDS engine version

Need
To update from 10.14 - > 10.17 based on this conversation
https://czi-sci.slack.com/archives/C023Q1APASK/p1655830775328629

From Eduardo's post:
* For PostgreSQL Minor Versions 10.13, 10.14 and 10.16, the recommended minimum minor version is 10.17

and AWS console recommends:
Your DB cluster is running aurora-postgresql version 10.14. Upgrade to version 10.20.

so we might as well upgrade to 10.20 or whatever the most recent 10.x version is when we address this upgrade.

Also, deadline for upgrading RDS is July 15, 2022!

Moved to cool down since we need to get this upgrade done during Q2 cool down


@conda-forge-admin, please add bot automerge

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/gz-cmake-feedstock#6.


app crashed on mouse dragging of tab

Environment
Windows build number: Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable):  1.4.3243.0

Any other software?

Steps to reproduce
drag tab to middle of terminal I tried dragging ubuntu tab
Expected behavior
open new window
Actual behavior
crashes entire app almost consistently out of 5 times tried got 3 crashes and often get them

Hi! Can you try the steps in https://github.com/microsoft/terminal/issues/8287#issuecomment-733893742 ? This will collect useful information about the crash.

Hi! Can you try the steps in https://github.com/microsoft/terminal/issues/8287#issuecomment-733893742 ? This will collect useful information about the crash.

Also, @ErroKokkarda are you running elevated? Or, do you have UAC disabled?

Also, @ErroKokkarda are you running elevated? Or, do you have UAC disabled?

It happened to me couple times on Windows Terminal Preview Version: 1.5.3242.0, but stopped immediately after reinstalling, so maybe try that.

It happened to me couple times on Windows Terminal Preview Version: 1.5.3242.0, but stopped immediately after reinstalling, so maybe try that.

This happens to me a fair amount, but I'm having a hard time repro'ing.  I typically have 8-10 tabs open, mostly running openssh inside a powershell terminal.  It seems much more common after the windows have been open for several hours which usually means at least one sleep or hibernate, but I don't know yet whether that is required.  If I try to reorder the tabs by dragging one with the mouse, then when I release the mouse button, the Terminal window completely disappears.
I'll keep trying to figure out how to reproduce this reliably.

Whenever it crashes, I drag the tab down into the client area, and I see the red-circle-with-slash glyph being dragged by the mouse. Then mouse cursor changes to the windows wait cursor, and then after about a second or two, (I'm still holding the left mouse button down) it crashes (the whole Terminal window disappears)  I don't think it crashes if I don't drag the tab into the window client area (below the title bar), but not totally sure. But even when I do drag the tab down over the client area, it only crashes a few percent of the time.
I always see the windows wait cursor first when it's about to crash. If I don't see the wait cursor it doesn't crash.


Pin GDAL version to avoid incompatibilities on Windows systems

We are running into this problem here: https://github.com/conda-forge/gdal-feedstock/issues/541

#358 has removed the version pin for PDAL, which should also render the GDAL pin unnecessary.


Update README.md

Adding comment for windows users following #121.

Can I ask you for a review? @Nicholas-Schaub @tying84


⚠ Bofrost.lu has degraded performance

In adaf3e6, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1722 ms

Resolved: Bofrost.lu performance has improved in 57c243d after 13 minutes.


Splitter should avoid splitting inner expressions

     Identifier ident = Identifier.idPool(name);
-    FuncDeclaration* pFd = cast(FuncDeclaration*)dmd_aaGet(&arrayfuncs, cast(void*)ident);
+    FuncDeclaration* pFd = cast(FuncDeclaration*) dmd_aaGet(&arrayfuncs, cast(
+        void*) ident);
     FuncDeclaration fd = *pFd;

The entire cast expression should be on the next line.

Another case, the call expression should stay intact.
-        auto dd = new DtorDeclaration(declLoc, Loc(), stc, Identifier.idPool("__fieldDtor"));
+        auto dd = new DtorDeclaration(declLoc, Loc(), stc, Identifier.idPool(
+            "__fieldDtor"));

Another awful one:
-            memcpy(&saved_idents, &rvl.saved_idents, (const(char)*).sizeof * VC_SAVED_IDENT_CNT);
-            memcpy(&saved_types, &rvl.saved_types, (Type).sizeof * VC_SAVED_TYPE_CNT);
+            memcpy(&saved_idents, &rvl.saved_idents, (const(
+                char)*).sizeof * VC_SAVED_IDENT_CNT);
+            memcpy(&saved_types, &rvl.saved_types, (
+                Type).sizeof * VC_SAVED_TYPE_CNT);

New low:
-        auto ed = new EnumDeclaration(loc, ident, memtype ? memtype.syntaxCopy() : null);
+        auto ed = new EnumDeclaration(loc, ident, memtype ? memtype.syntaxCopy(
+            ) : null);

Not as low as the number of pull requests from you.

Should I not be reporting these?

I'm curious what message you are trying to communicate by using the phrases "awful" and "new low".

That the code ends up formatted really badly.

The cost calculation for expression wrapping now adds extra penalties to tokens inside of "(", "[", and "{" tokens. I also tweaked several other parameters to the cost function, so line wrapping should be better in general now.

Awesome, I'll check it out.

It does appear to be better in general now.  Some cases could still be better, eg
-        doCond(e.thisexp) || doCond(e.newargs) || doCond(e.arguments) || applyTo(e);
+        doCond(e.thisexp) || doCond(e.newargs) || doCond(e.arguments) || applyTo(
+            e);

I investigated this further and found two issues:

The paren depth info used to more heavily weight inner expressions wasn't calculated properly
Some code that was supposed to act as a backup and force a newline if the hard column limit was hit was actually running if the soft column limit was hit.


Revert/rethink time-locked token calculation

Relates to #893

Done https://github.com/Granola-Team/mina-indexer/pull/905/commits/edbd01b8802351188a38a2e70b12dfc7d4723941


Handle errors in ApiRepoUpdateSlice

Closes https://github.com/artipie/artipie/issues/320

@genryxy thanks, added

@g4s8 please, take a look/merge


Allow for desired count of 0

AWS allows you to scale a service down to 0, this is useful, for example, when you want to use a service as a canary.
Fixes #24.

Thansk @iterion, I'll merge this in :)


[TEST: Suggested formatting improvements]: for README.md for better readability

This PR suggests formatting improvements for the file.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/what-are-tabs.md
90
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


submit on bootstrap modal

Hi! First of all sorry for my bad english.
I try to put validator on form in bootstrap modal. When I focus on input (which is requiered) and than focus on other element - everything fine! But if I Click to the submit button -  form is submitted and page is refreshed.
here is code:

                <form data-toggle="validator" role="form">

            Name
            <input type="text" class="form-control" id="inputName" placeholder="Cina Saffary" required>

            Twitter

              @
              <input type="text" pattern="^[_A-z0-9]{1,}$" maxlength="15" class="form-control" id="inputTwitter" placeholder="1000hz" required>

Hey look, this one has feedback icons!

            Email
            <input type="email" class="form-control" id="inputEmail" placeholder="Email" data-error="Bruh, that email address is invalid" required>

            Password

              <input type="password" data-minlength="6" class="form-control" id="inputPassword" placeholder="Password" required>

Minimum of 6 characters

              <input type="password" class="form-control" id="inputPasswordConfirm" data-match="#inputPassword" data-match-error="Whoops, these don't match" placeholder="Confirm" required>

                <input type="radio" name="underwear" required>
                Boxers

                <input type="radio" name="underwear" required>
                Briefs

                <input type="checkbox" id="terms" data-error="Before you wreck yourself" required>
                Check yourself

            <button type="submit" class="btn btn-primary">Submit</button>

        </form>

so how can I validate form on modal and after validate, if success, submit the form?

modal.txt

				<form data-toggle="validator" role="form">

            Name
            <input type="text" class="form-control" id="inputName" placeholder="Cina Saffary" required>

            Twitter

              @
              <input type="text" pattern="^[_A-z0-9]{1,}$" maxlength="15" class="form-control" id="inputTwitter" placeholder="1000hz" required>

Hey look, this one has feedback icons!

            Email
            <input type="email" class="form-control" id="inputEmail" placeholder="Email" data-error="Bruh, that email address is invalid" required>

            Password

              <input type="password" data-minlength="6" class="form-control" id="inputPassword" placeholder="Password" required>

Minimum of 6 characters

              <input type="password" class="form-control" id="inputPasswordConfirm" data-match="#inputPassword" data-match-error="Whoops, these don't match" placeholder="Confirm" required>

                <input type="radio" name="underwear" required>
                Boxers

                <input type="radio" name="underwear" required>
                Briefs

                <input type="checkbox" id="terms" data-error="Before you wreck yourself" required>
                Check yourself

            <button type="submit" class="btn btn-primary">Submit</button>

        </form>

problem solved! Dear devolopers - something was wrong after 2015 year:
I found the same problem in this issue https://github.com/1000hz/bootstrap-validator/issues/332
in this ticket you recommended to see this unsolved problem https://github.com/1000hz/bootstrap-validator/issues/26
so, i find that there is no same problem before first post by AJRames commented on 2015 Jan 27.
And i thought: possible something was wrong before this date?!
OK. I downloaded previous version of plugin v0.9.0 And everything will OK !
Dear 1000hz - i found your plugin very COOL! Please find the mistakes in your newest version and correct it!

Thanks!!!.. I have been trying to figure out why my submit buttons which were disabled before no longer were disabled.  Reverting to .9 fixed the problem.
To recreate, you don't need a modal.  Any nested div will cause the problem.

For the record had the same issue and reverting to 0.9 fixed it for me as well

If not working this solution: $('.modal').on('shown.bs.modal', function (e) { $(this).find('form[data-toggle=validator]').validator() });
Try first detroy validator $('.modal').on('shown.bs.modal', function (e) { $(this).find('form[data-toggle=validator]').validator('destroy'); $(this).find('form[data-toggle=validator]').validator() });
It's work for me.

@quadrogod thanks a lot.

@quadrogod  thanks a lot for saving me, I have worked on it for the whole morning

@t4n017's answer works properly. However, you'll notice the validator doesn't prevent submits if the modal is closed and re-opened. Here's what I have to do to get properly functional performance from it:
$('#some-modal').on('shown.bs.modal', function (e) {
  $(this).find('form').validator()

  $('#some-modal-form').on('submit', function (e) {
    if (e.isDefaultPrevented()) {
    } else {
      e.preventDefault() // if you're using AJAX
      // do the submission thing
    }
  })
  $('#some-modal').on('hidden.bs.modal', function (e) {
    $(this).find('form').off('submit').validator('destroy')
  })
})

I am not using the data-toggle='validator' attribute to initialize the modal validators, only JS. I would strongly recommend operating this way, since data-toggle finds common use elsewhere in Bootstrap.
This function can be genericized pretty easily if you change from ID's to classes, then just tack the class on the modal.

Validator works, but is not preventing to be submitted! :persevere:

Seems to be working ok.
http://jsbin.com/rumobowixu/1/edit?html,output
It doesn't submit if there are errors, and then if you fill out the form correctly you can see the POST being sent in the Network tab of the developer tools.

Not working in my local... I've v2.2.4 installed.
Its still sending ajax request.
I simplified in here:
http://jsbin.com/facokewuma/1/edit?html,js,output

@nelson6e65 The validator needs to be initialized before the submit handlers are bound. Additionally, you need to check if !e.isDefaultPrevented() before you make your ajax call.
  // ...

  $formulario.validator().submit(function (event) {
    LoginDialog.toggleButtons(false);
    // Si tienen data-ajax, se le agrega un listener al darle al botón 'Eliminar'
    if ($formulario.data('ajax') && !event.isDefaultPrevented()) {

  // ...

@1000hz Thanks. In jsbin seems to be working, but in my local is still sending ajax request regardless the value of event.isDefaultPrevented(). :disappointed: Maybe some kind of weird logic in my javascrip. I'll check this later (I'm sleepy now).

"Not working in my local... I've v2.2.4 installed."

"[...]my local is still sending ajax request regardless the value of [...]"
@nelson6e65

Sorry, . My bad: I was using an old version (0.10.2) here. :sweat_smile:
Updating to 0.11.5 solved that problem.
Thank you, @1000hz. I solved other issues by following your advises. :smiley:

Thank you so much! I was tearing my hair out trying to find what was bugging this. @tanoabeleyra's solution worked for me.

Just started to try validator and I think I have a similar issue but slightly different.  I already capture the submit button click with:
$(":submit").on("click", function (e) {
//Submit the form data and display the result
e.preventDefault();
//Submit the form with ajax here
I'm only using the html5 validators right now but none of them are reported when I click the Submit button. I tried adding a check for isDefaultPrevented but that didn't make any difference.
I have validation in my server script which catches the errors but want them to happen before I submit the form.
Is my Submit handler getting in the way?

I'm having the same issue with validator allowing a modal form to submit even with errors.
I'm using bootstrap validator v0.11.9 with Rails 5.
I have a bootstrap modal that has a form with "remote: true" (AJAX).
I'm initialized validator with javascript and am not using the data-toggle attributes.
If I open the form and immediately click "submit" I can see the validation errors, but the form continues to submit.
I tried the recommended solution above - but can not figure out to to prevent the form from submitting.
This is the code I'm using (rails 5 - new.js.erb) - everything works except the form submits with errors.
var modal = $("#userFormModal");
modal.find(".modal-content").html("<%= j (render partial: 'form', locals: {user: @user}) %>");
modal.modal();
modal.on("shown.bs.modal", function(){
enableFormBehaviors();
$("#new_user").validator("destroy").validator();
});
This is an example of the html mark up:
<%= form_for(@user, remote: true) do |f| %>

×

New User Record

    <% if @user.errors.any? %>
      <%= render partial: "shared/form_errors", locals: {errors: @user.errors.full_messages } %>
    <% end %>

      First Name *

      <%= f.text_field :first_name, id: "first_name_input", class: "form-control",
                       data: {error: "First Name required"}, required: true %>

....... removed for example

    <%= f.submit @ftot.new_record? ? "Create Project" : "Edit Project", class: "btn save_btn focus_btn" %>
    Close

<% end %>
Any help would be appreciated. I've spend days trying to figure this out.


On multi-line strings it duplicate texts

text where cursor is positioned but not selected is duplicated on conversion.

Thanks for the bug report. This has now been fixed.


PINMUX_REGEN redefinition warning in generated pinmux_regs.h

Filing issue for this warning msg thrown:
In file included from opentitan/sw/device/../../sw/device/lib/pinmux.h:10,
from examples/hello_world/hello_world.c:7:
sw/device/../../build/sw/device/examples/hello_world/lib/pinmux_regs.h:15: warning: "PINMUX_REGEN" redefined
#define PINMUX_REGEN 0
sw/device/../../build/sw/device/examples/hello_world/lib/pinmux_regs.h:14: note: this is the location of the previous definition
#define PINMUX_REGEN(id) (PINMUX##id##_BASE_ADDR + 0x0)

. I thought I changed pinmux regen register field name as 'wen'. Hum... don't know why it is not visible to you.
Could you please check if you have latest sw/device/rules.mk file?

Aah apologies, I made a mistake. Closing this.


Background disk clean up cause battery usage in background

Hi,
Our app does not perform any background task; however, when we go to settings -> battery usage, we notice that our app is showing background usage. When we search through our code, we see that SDWebImage clearing disk during app background as a background task.
Is there a way to disable the background disk clean up? If so, what's the best alternative place to call disk cleanup?
Please advise! Thank you!

There seems to be no straight way to disable this feature. How long is the background usage are we talking about here? It shouldn't be very noticeable unless you have a large amount of cached files.

We are seeing something like for 8 minutes screen time of the app, it was running 2 minutes in background.

@paktree check if your cache is large in size like @skyline75489 suggested.
Also do a test with fewer images e.g with the demo project and let us know if you still see significant background usage time.
closing this. please reopen when you have more info


Add a default value for password_test_user and password_test_pass for configuration page

fix: #26
Hello,
I tried to use this plugin with recent version of Piwigo and PHP 8, as explained by #26 php now raise errors which are displayed in the module configuration page.
There may be more efficient ways to fix the error but providing a default value for password_test_user and password_test_pass works well.

Any news on when this will be pushed?
Thanks


Xamarin.Auth, latest Prism, and Unity problem

Hey Dan,
Have you tried this library with a UWP app and latest Prism.  I'm getting conflicts due to Unity:
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\VisualStudio\v15.0\AppxPackage\Microsoft.AppXPackage.Targets(1700,5): error APPX1101: Payload contains two or more files with the same destination path 'Unity.Abstractions.dll'. Source files:
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\VisualStudio\v15.0\AppxPackage\Microsoft.AppXPackage.Targets(1700,5): error APPX1101: C:\Users\admin\.nuget\packages\unity\5.7.3\lib\netstandard2.0\Unity.Abstractions.dll
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\VisualStudio\v15.0\AppxPackage\Microsoft.AppXPackage.Targets(1700,5): error APPX1101: C:\Users\admin\.nuget\packages\unity.abstractions\3.3.0\lib\netstandard2.0\Unity.Abstractions.dll

Any ideas?
cliff

Yeah I'm guessing you're using the Unity package from this repo... at the time I last published it I was in sync with what Prism used for Unity which was the Unity NuGet. That has since changed to Unity.Container which is why you're getting two identical references. I'll make a note of this and try to get an updated package out later this week.

btw feel free to send a PR on this as well :)

one quick noob question, how do i use the Directory.build.props to create a local package without editing the project files?

thanks, i had already sorted it.  should've removed the comment.


ZEPPELIN-2083: default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml

What is this PR for?
Default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml
What type of PR is it?
[Bug Fix]
What is the Jira issue?

ZEPPELIN-2083

How should this be tested?
Remove default spark interpreter, and and another with a different name say "spark2". This newly created interpreter should show up on top.
Screenshots (if appropriate)
Before:

After:

Questions:

Does the licenses files need update? N/A
Is there breaking changes for older versions? N/A
Does this needs documentation? N/A

Tested, LGTM

@Leemoonsoo  can you help review this.

LGTM

LGTM


Admin editing another users recipe changes recipe author

Confirmed: Author field is always written as currently logged in user.

Fixed with commit: https://github.com/seanyoung247/Plum/commit/769cca4aee720263c1868fa3bc02b0d66a1b8226


Fix: Fixed an issue with admin operations not working

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #13229, #10422

ShellFileOperations2.cs is the same file added for #13359 with a small change.
Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Copy, delete, rename, etc files from a protected folder

It doesn't show progress, but I still think it is very nice!
Here are a few things I noticed.

It would be better to show progress as indeterminate.
Occasionally the following exception occurs:

2023-10-20 08:56:19.6985|Error|System.ArgumentException: Source object type is not a projected type and does not inherit from a projected type. (Parameter 'value')
   at WinRT.CastExtensions.GetRefForObject(Object value)
   at WinRT.CastExtensions.As[TInterface](Object value)
   at Files.App.Dialogs.ElevateConfirmDialog.ElevateConfirmDialog_obj3_Bindings.SetDataRoot(Object newDataRoot)
   at Files.App.Dialogs.ElevateConfirmDialog.ElevateConfirmDialog_obj3_Bindings.DataContextChangedHandler(FrameworkElement sender, DataContextChangedEventArgs args)
   at ABI.Windows.Foundation.TypedEventHandler`2.Do_Abi_Invoke[TSenderAbi,TResultAbi](Void* thisPtr, TSenderAbi sender, TResultAbi args)

One sec "Yes" it's not showing

Done! :)

I made a copy of several folders on my disk, and when I try to delete them, some of them get deleted, while others ask for administrator permission. When I click 'Yes,' they don't get deleted, and the status center displays an error. Is this normal behavior?