Adapter is loosing connection

After every iobroker restart the connection to the Broadlink devices is lost.
The iobroker instance is restarting every night at 3 o clock.
After an adapter restart the Broadlink is found again.
The used version is 2.1.5

a similar situation. the connection to the device is constantly lost. Only restarting the adapter helps. Is it possible to add any kind of connection check??
log when there is no connection:
stateChange error invalid id type: RM:0x279d_78:0f:77:00:d0:f5.L.CODE_b200ae01360b150b0b15160b0b15160a0c150b150c15160a0b150c150b150b16160a0c150b15150b160b160a160a0c150b15160b150b160a0c150b150b160b150b160b150b15160b160a0c14160b160a160b150b160b150da052350b150b0c15150b0b15160b0b150c140c15160a0b160b150b150c15160a0b160b15160b150b160a160b0b150b15160b160a160a0c150b160b150b150b160b150b15160b150b0b15160b160a160b150b160a160da150360a160b0b15160b0b15160b0b150b160b15160a0c150b150b150c15150b0b160b15160a160b150b160a0c150c15150b160a160a0c150b160b150b150c150b150c15150b160a0c15150b160a160b160a160b150da151350b150b0b15160b0b15160b0b150b150c15160a0b160b150c140c15160b0b150b15160b150b160a160b0b150b16150b160a160b0b150b150c150b150c150b150b16150b160a0c15150b160a160b150b160a160da150360b150b0b15170a0b15160b0b150b150c15160b0b150b150c150b15160b0b140c15160b150b160a160b0b150b16150b160a160b0b150b160b150b150c150b150b16150b160a0c15160a160b150b160a160b150005dc00000000000000000000=RM:0x279d_78:0f:77:00:d0:f5 {val: true,ack: false,ts:<PHONE_NUMBER>905,q: 0,from: 'system.adapter.admin.0',user: 'system.user.admin',lc:<PHONE_NUMBER>940}
log after restart:

broadlink2.0 | 2021-08-20 11:29:58.538 | info | found macs: 78:0f:77:00:d0:f5
-- | -- | -- | --
broadlink2.0 | 2021-08-20 11:29:58.537 | info | broadlink2.0 started and found 1 devices named RM:0x279d_78:0f:77:00:d0:f5
broadlink2.0 | 2021-08-20 11:29:58.537 | info | Poll every 120 secods.
broadlink2.0 | 2021-08-20 11:29:54.176 | info | discover [ '<IP_ADDRESS>' ] from <IP_ADDRESS>:32920
broadlink2.0 | 2021-08-20 11:29:54.175 | info | interface to be used: { netmaskBits: 24, address: '<IP_ADDRESS>/24', addrs: [ 192, 168, 1, 100 ], cidr: '<IP_ADDRESS>/24', bcaddr: '<IP_ADDRESS>' }:
broadlink2.0 | 2021-08-20 11:29:54.175 | info | interface to be used: { netmaskBits: 16, address: '<IP_ADDRESS>/16', addrs: [ 172, 23, 0, 2 ], cidr: '<IP_ADDRESS>/16', bcaddr: '<IP_ADDRESS>' }:
broadlink2.0 | 2021-08-20 11:29:49.492 | info | Device RM:0x279d_78:0f:77:00:d0:f5 detected: address=<IP_ADDRESS>, mac=78:0f:77:00:d0:f5, typ=RMP, id=0x279d devtype=RM3 Pro Plus
broadlink2.0 | 2021-08-20 11:29:48.956 | info | discover [ '<IP_ADDRESS>', '<IP_ADDRESS>', '<IP_ADDRESS>', '<IP_ADDRESS>' ] from <IP_ADDRESS>:56567
broadlink2.0 | 2021-08-20 11:29:48.956 | info | interface to be used: { netmaskBits: 24, address: '<IP_ADDRESS>/24', addrs: [ 192, 168, 1, 100 ], cidr: '<IP_ADDRESS>/24', bcaddr: '<IP_ADDRESS>' }:
broadlink2.0 | 2021-08-20 11:29:48.955 | info | interface to be used: { netmaskBits: 16, address: '<IP_ADDRESS>/16', addrs: [ 172, 23, 0, 2 ], cidr: '<IP_ADDRESS>/16', bcaddr: '<IP_ADDRESS>' }:
broadlink2.0 | 2021-08-20 11:29:48.944 | info | Discover Broadlink devices for 10sec on broadlink2.0
broadlink2.0 | 2021-08-20 11:29:48.943 | info | macObjects: [ '78:0f:77:00:d0:f5' ]
broadlink2.0 | 2021-08-20 11:29:48.943 | info | interface to be used: { netmaskBits: 24, address: '<IP_ADDRESS>/24', addrs: [ 192, 168, 1, 100 ], cidr: '<IP_ADDRESS>/24', bcaddr: '<IP_ADDRESS>' }:
broadlink2.0 | 2021-08-20 11:29:48.942 | info | interface to be used: { netmaskBits: 16, address: '<IP_ADDRESS>/16', addrs: [ 172, 23, 0, 2 ], cidr: '<IP_ADDRESS>/16', bcaddr: '<IP_ADDRESS>' }:
broadlink2.0 | 2021-08-20 11:29:48.941 | info | broadlink2 has 1 old devices!
broadlink2.0 | 2021-08-20 11:29:48.940 | info | Devices to rename:
broadlink2.0 | 2021-08-20 11:29:48.940 | info | Devices to add:
broadlink2.0 | 2021-08-20 11:29:48.940 | info | Scanning additional IP's: <IP_ADDRESS>
broadlink2.0 | 2021-08-20 11:29:48.938 | info | broadlink2 initialization started...
broadlink2.0 | 2021-08-20 11:29:48.845 | info | starting. Version 2.1.5 in /opt/iobroker/node_modules/iobroker.broadlink2, node: v12.22.1, js-controller: 3.3.15
broadlink2.0 | 2021-08-20 11:29:43.725 | info | Terminated (ADAPTER_REQUESTED_TERMINATION): Without reason
broadlink2.0 | 2021-08-20 11:29:43.724 | info | terminating
broadlink2.0 | 2021-08-20 11:29:43.723 | info | Adapter disconnected and stopped with dostop(null) and callback(true)
broadlink2.0 | 2021-08-20 11:29:43.645 | info | Close all connections...
broadlink2.0 | 2021-08-20 11:29:43.620 | info | Got terminate signal TERMINATE_YOURSELF


feat(deps): update to backstage 1.29

Description
Please explain the changes you made here.
Which issue(s) does this PR fix

Fixes https://issues.redhat.com/browse/RHIDP-2791

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

/test e2e-tests

all tests passed except prow, so triggered them again after latest update.

/test e2e-tests

/retest

Received approval from QE to merge with e2e tests failing.


Decide where links to pages should live.

We need to decide how much cross-site linking we should be doing between .io and .tech

@alyssaoc I don't think this applies to me.

Issue moved to lbryio/growth #86 via ZenHub


rename to styles.css, maybe even styles.scss

Nobody says index.css, it is styles.css, just like it is main.py and index.js.


[FIXED JENKINS-28405] Add support for all missing git code browsers

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Add only the code browser that you need. Otherwise it may take a long time to get this reviewed. It's not a goal for the Job DSL Plugin to support each and every feature, it will never support every feature of every plugin.

As requested, i removed unwanted code browser and kept only needed : gitlab & gitblit.


Fix types

We don't need to copy types from RNCamera when we can import them from the library

ref https://github.com/react-native-community/react-native-camera/blob/master/types/index.d.ts#L142

great job @abumalick, it makes pretty much sense! thank you for contributing


Website links not working

The links FAQ, Features, Website Examples, Videos, and Training from the "learn menu" (check image) are actually not working, returns 404.

what site are you on, cause those links don't even exist in http://foundation.zurb.com/

Yeah the issue is on forum side: http://foundation.zurb.com/forum/signin
but not so much the main site: http://foundation.zurb.com/

The forum's top bar has been updated to match the main Foundation site.


Distance to Assets - Geocode Assets and Bases tool doesn't have Esri World Geocoder as an input parameter

Expected Behavior
When using tasks in the ArcGIS Pro version of Distance to Assets, the first task runs through the 1. Geocode Assets and Bases tool. I'd expect the input geocoding service in the tool to default to the Esri World Geocoder.
Current Behavior
The current default geocoder is https://geocode.arcgis.com/arcgis/rest/services/World\GeocodeServer. I'm not sure if it is the same as the Esri World Geocoder, but this seems like a remnant of how you needed to enter the specific url to connect to the geocoder in ArcMap.

Possible Solution
The quick workaround is to document to the user that they need to replace the default geocoder with the Esri World Geocoder, but a more elegant enhancement would be to remove the parameter that includes the file path in the pro version of the template.
Steps to Reproduce (for bugs)

Open Distance to Assets In ArcGIS Pro
Run the Task Item entitled Create Distance to Assets
The first task is 1. Geocode Assets and Bases, which is where you'll encounter the filepath as the geocoder.

Your Environment
Pro 2.0

@dbarnes1 why do you think this incorrect? This is the online geocoder and functions as required

@adgiles it looks like there are two options when you click on the drop down in that parameter. Those options are Esri World Geocoder and MGRS Geocoder. I guess my question is whether the Esri World Geocoder in the drop down is the same as this path: https://geocode.arcgis.com/arcgis/rest/services/World\GeocodeServer. If it is, why do we need to have that path set in the tool?
This is related to the fact that I'm unable to actually run the tool in Pro: https://github.com/ArcGIS/solutions-desktop-templates/issues/400

@dbarnes1 they are the same but you will only get the drop down if the locators are set as ready to use services within your portal

@adgiles thanks for clarifying! Just wanted to make sure everything makes sense as I go through the documentation for the template. I'll go ahead and close this


[TC-MC-6.4]Mediaplayback cluster-Values are mismatching with Expected outcome when TH send command to DUT.

Problem
Values are mismatching with Expected outcome when TH send command to DUT. For example TH sends a FastForward command to the DUT, DUT  responds as success after if TH tries to read PlaybackSpeed attribute and CurrentState attribute from the DUT
It should response as

But currently DUT responding with same value for  all the commands(Rewind, Play, Pause, FastForward) after if TH tries to read PlaybackSpeed attribute and CurrentState attribute
Test-Plan Reference:-
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/media.adoc#tc-mc-6-4-variable-speed-media-playback-verification
Spec Reference:-
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/media/MediaPlayback.adoc#attributes
PFA log below:-
[TC-MC-6.4].txt

this should now be addressed, thanks


when use a for loop in ios 9.3， 'for' will run twice

Version
2.5.13
Reproduction link
https://github.com/greedying/vue-for-bug-demo
Steps to reproduce
let vm = new Vue(params)
vm.$data.list is a array;
when you do this, it is right:
for(var i = 0; i < vm.$data.list.length; i++) {}

but this below  is wrong. it run twice, and I don't know why
for(var i in vm.$data.list) {}

this is  only in ios 9.3
first, find an iphone with ios 9.3
second, open the bugs github demo
third, see the image or run the code in iphoe，or view the demo url in README
What is expected?
for-loop run only once
What is actually happening?
for-loop run twice

nice sample

Hi, thanks for filling this issue.
for...in loops accesses properties on the prototype, so you'll need a hasOwnProperty check. This is not related to Vue and is a common JavaScript pitfall with for...in.

hi~ in fact, only vue's property or computed property will run twice for-loop.
yes, it is about hasOwnProperty, so may Vue changed its own property, I doubt.
anty way, vue doest not have a similar  performance with common js 。
I add  the demo of common js in my github， you can see it if you want。

may I reopen it ?


Update README.md

From
How creative, innovative and polish the app is?
to
How creative, innovative and polished is the app?

Thank you! It seems that the file has been updated already. Nonetheless, thank you so much for you help ❤


Do you really need numpy as build dependency?

At a glance, I don't see any C-extension, and you are publishing only universal wheel on PyPI. So maybe can remove numpy as build dependency.
https://github.com/spacetelescope/slitlessutils/blob/8ecfe054cfcfe0b94941d231605872de8e3ab781/pyproject.toml#L71

Yep, that's not needed.  Thanks!


Change Request: maxRetries parameter naming convention for TS

I need to write guidelines codifying the options that control retry policy. Today we have multiple conventions in use (maxTries, retryCount). I want to standardize on maxRetries which seems to be used in many places already, by other languages in our SDK, and libraries in ecosystem.
/cc @ramya0820

Is this about throttlingRetryPolicy and exponentialRetryPolicy? I'm wondering if we could abstract these into a common API that would be agnostic of headers and status codes? Would that be relevant / desired?

@bterlson There is also a new ask to allow users to configure the timeout for each attempt. Do you want to use this issue to write the guideline for that or create a new one?


fix amc12a_2011_p18

fix the informal statement from https://artofproblemsolving.com/wiki/index.php/2011_AMC_12A_Problems/Problem_18.

thank you @Huyongyi-cpu !


ARROW-9839: [Rust] [DataFusion] Implement ExecutionPlan.as_any

This allows ExecutionPlan to be downcast to a specific operator.

fyi @alamb @jorgecarleitao


recipe data model

Recipe has the following attributes:

Identifier
Name
List of tags
List of Ingredients
List of steps or instructions
Publication date


fix dot and add type values in zfmt

This commit fixes a bug in canonical zfmt to print "."  instead of
nothing for a root record field path.  It also adds support for
printing type values.
This addresses some but not all of the problems in #2224.
We can add a number of tests for this stuff when we tackle
the rest of #2224.

Maybe add test coverage now if it's easy?

I'd like to wait simply because this is still an early first stab meant to provoke conversation and this is all a moving target.  As we finalize canonical form we can write tests that cover the final design.


Check the generated webhook secret

Sometimes, the webhook secret contains a / character. This make the router to be confused, and the webhooks never arrive.
We should check the webhook secret value before validation

This is a tricky one. let's add it in documentation till we get some fix out.

Discussion on Mattermost Community


Negation operator

!(expression)
Can parser also automatically convert "x != y" into "!(x == y)" ?

done


calico namespaceselector question

I setup calico with kubesphere on aws eks.
Used calicoctl to create  networkpolicy:
apiVersion: projectcalico.org/v3
kind: NetworkPolicy
metadata:
  name: deny-user-namespace
  namespace: 2048-game
spec:
  ingress:
  - action: Allow
    protocol: TCP
    source:
      namespaceSelector: 'systemCreated=="true"'

namespace:
Name:         default
Labels:       kubesphere.io/namespace=default
              kubesphere.io/workspace=system-workspace
              systemCreated=true
Annotations:  <none>
Status:       Active

No resource quota.

No LimitRange resource.

and then, i created a nginx deployment in 2048-game namespace.
Then curl busybox in default namespace.
When I execute curl from busybox container in defualt namespace, the traffic is blocked.
Can anyone help? I am expecting the curl traffic to be able to reach nginx, since i have allowed tcp traffic from systemCreated=true namespaces

@iammuho hm, yeah it does seem like that NetworkPolicy should allow incoming TCP connection from pods in the default namespace to all pods in the 2048-game namespace.
One thing to double check is that you've left the selector field blank. I believe this should default to "all()", but worth double checking (e.g., what does calicoctl get networkpolicy -n 2048-game -o yaml show?)
Are there any other policies in your cluster?
Another question to make sure - does traffic to that pod work without any policy in place? Have you confirmed that its the addition of this policy that is causing the problem?

Solved by limit all traffic from labeled namespaces


readlink() proposal

there is no 'readlink()' facility in luafilesystem. just having attributes() and symlinkattributes() is cumbersome to use.
I'd like to propose following ideas, and if accepted i can implement them and send a patch:

just implement lfs.readlink(name[, recursive]) which returns the file pointed too or 'nil' when not a symlink. If recursive is true or a number then resolve the link recursively (for n times or until reaching a final file, checking that there is no loop)
extend the lfs.attributes() function returning a .link field when the given filename was a link. This can be a array of recursive link expansions  or just the final name to which it resolves. in case of a loop, stat() already fails.

readlink() functionality was implemented as part of #78 (for non-Windows platforms). With an up-to-date LuaFileSystem you can access the symlink target via the new target attribute of symlinkattributes(), e.g.
lua -llfs -e 'print(lfs.symlinkattributes("/proc/self/exe", "target"))'

Regards, NiteHawk

Side note: The documentation is still not mentioning the "target" attribute, as the relevant change to doc/us/manual.html has not been forwarded to the gh-pages branch yet.

gh-pages is supposed to document latest release, not master

Ah, I see - good point.


Launching a game when nothing is selected.

The firmware will try to launch a game even if nothing is selected in the list. This throws up the restart game window and if you press yes it will freeze the UI.

To throw into the mix here, it also implodes when a game is deleted when nothing is selected, or deleted twice somehow.
Had some pretty wonky blits for a moment when this caught me out.

Yeah, not checking that the game list is non-empty then reading out-of bounds:
https://github.com/pimoroni/32blit-beta/blob/1e7ed87f8413a6ef434f1931a8a5c71abc1a3a14/firmware/firmware.cpp#L510-L513
https://github.com/pimoroni/32blit-beta/blob/1e7ed87f8413a6ef434f1931a8a5c71abc1a3a14/firmware/firmware.cpp#L536-L538
Err... oops (also, not the most consistent file)

@Gadgetoid I think we might be able to close this issue?


Upstream merger2

Looks like nothing big. I hope it works.

It's not really, the bigger update is nerves_network.


Update jsDelivr link

jsDelivr switched to a fully automated system, that can serve files from npm and GitHub. This means all future releases will be available automatically, but will use a new link structure.
I updated the links now so you don't forget to do it when you release a new version.
You can find links for all files at https://www.jsdelivr.com/package/npm/ng-image-appear.
Feel free to ping me if you have any questions regarding this change.

Thanks for the update @LukasDrgon.


Ensure file URIs without a host build with slashes

If you parse a file uri without a host like file:///etc/hosts, it will rebuild as file:/etc/hosts.  This PR fixes Uri\build to add the missing // for file URIs that don't have a host.
The docs for parse_url say:

This function is intended specifically for the purpose of parsing URLs and not URIs. However, to comply with PHP's backwards compatibility requirements it makes an exception for the file:// scheme where triple slashes (file:///...) are allowed. For any other scheme this is invalid.

I figure if parse_url supports file:// URIs it makes sense for Uri\build to support them too.
I tried to find a source for the proper behavior.  RFC 3986 just says:

For example, the "file" URI scheme is defined so that no authority, an empty host, and "localhost" all mean the end-user's machine

Interesting! I wonder if file: is exceptional, or if there's others like it. I want to do a bit of research about that before applying this patch, but everything looks good!

Thanks for the quick response 😄
I'm currently depending on the 1.x release.  Should I open a separate PR targeting the 1.0 branch?

I can do a backport. Takes only a few minutes.

Awesome 👌 thanks Evert!


The ability to configure the upstream version of envoy in istio/proxy

Describe the feature request
The ability to configure the upstream version of envoy in the istio/proxy WORKSPACE dynamically (e.g.  configurable from a CI/CD system).  Ideally, attributes such as url (i.e.repo) and sha could be specified via environment variables or another, related bazel-specific means. Additionally, if the http archive source is private, then auth configuration (e.g. .netrc) should be configurable as well.
As a reference implementation, I took a stab at this https://github.com/istio/proxy/pull/2496 but my effort was subsequently reverted due to limitations in the approach; one major limitation being the absence of a means to authenticate.
Describe alternatives you've considered

Continue to hard-code the value and handle auth ad hoc.
Configure and build from a local source path.
Use --override_repository (xref: https://github.com/istio/proxy/pull/2496#issuecomment-548842080) but not sure how this will work regarding auth with private repos/archives.

@lizan - Do you have any bandwidth to help with this. Is there any way to take what you do locally for private repos and make it configurable from an external environment (e.g. CI)?

@clarketm --override_repository allows you to point envoy (or any other repository in bazel terms) to a specific local directory, without patching WORKSPACE. Regarding auth with private repos/archives, it should be done prior to invoke bazel, for example: git clone https://github.com/private/envoy /tmp/envoy && bazel build --override_repository=envoy=/tmp/envoy //src/envoy will work, and you are able to configure git to do authenticate (by default git https uses .netrc, you can also use ssh too).

@clarketm --override_repository allows you to point envoy (or an...

Okay I see.  So the idea is to clone the private repository/source locally on the filesystem upfront, then use --override_repository to point to direct bazel to the local path where the source was downloaded. I can give that a try and send out a PR shortly, Thanks!


test: Fetch DNS proxy port from cilium status

Rather than depending on the underlying iptables implementation, pull
the DNS proxy port from cilium status. This will help when the
underlying implementation changes in future.

test-focus "TFTP with DNS Proxy port collision"

Coverage remained the same at 36.986% when pulling 570506c9e853afa01d8bf1828aa29fd58b757656 on joestringer:submit/proxy-port-api into ba9031bb45a0da79ee3a843a8c9b50807d0e40be on cilium:master.

test-focus "K8s.*TFTP with DNS Proxy port collision"

test-focus K8s.*TFTP with DNS Proxy port collision

Only the "TFTP with DNS Proxy port collision" test depends on this function, so if it passes, we're good. If not, it needs iteration.

test-focus K8s.*TFTP with DNS Proxy port collision


Feature/selective cleaning

This PR circumvents the issue when having a locked down (subnet access) storage accounts. The process of cleaning of stemcell fails. For more details check #612
[X ] Please check this box and fill the data as below once you have run the unit tests.
Code coverage should keeps at 100%.
Changelog

A new propriety use_default_account_for_cleaning was added to always use default account for cleaning. By default the flag is disabled and same code path and functionality is maintained. When enabled stemcells are only deleted from default storage account only.

Thank you 👍

@ahelal We’ve tested the change in one of our landscapes, where stemcell deletion was failing due to lack of access to a storage account. The CPI was able to delete stemcells.

@dsboulder would it be possible to get a BOSH CPI release that contains this fix?

hi @dsboulder,
h4xnoodle closed the related issue https://github.com/cloudfoundry/bosh-azure-cpi-release/issues/612 as this PR was merged. However, to be able to use it in production we need a release to contain this fix. Can you please provide this as part of a new release?
The latest release was build 4 month ago as far as I can see.
Thanks, Claudia


Refac: Straightforward output shape permutation

This PR is about where and when we call MaybePermuteHWC2CHW(). It's not about tensor allocation (this will come, later).

At a high-level, this PR changes all conditional call patterns like:
if (cond) {
  output.frames = MaybePermuteHWC2CHW(output.frames)
}

to a plain, unconditional
output.frames = MaybePermuteHWC2CHW(output.frames)

This makes it a lot simpler to reason about our output  shape  permutation. In main, cond is typically input-dependent (but really, caller-dependent), and it leads to a state that's hard to reason about.
Another benefit of this PR is that now all low-level decoding routines (like convertAVFrameToDecodedOutputOnCPU()) have a simpler interface: they only ever take and return HWC tensors.

At a lower level, the following changes were made:

MaybePermuteHWC2CHW() is now a method so we can pass a streamIndex. It makes its interface slightly simpler.
It's now up to every high-level decoding function to call MaybePermuteHWC2CHW().
Some methods like getFrameAtIndex() and getNextDecodedOutputNoDemux() were used both as a high-level decoding entry-point and as a low-level subroutine of other entry-points. I split those into getFrameAtIndex()/getFrameAtIndexInternal()  and getNextFrame()/getNextDecodedOutputNoDemux() to clearly distinguish between the public entry point and the underlying private helper. Note that this isn't just a "nice-to-have" or a nit-pick, it's a necessary change for the goal of this PR.
getNextFrame() is the new public entry point, getNextDecodedOutputNoDemux() is now private.

A follow-up of this PR will be to unify the tensor allocation. I think it'd make sense for tensors to always be pre-allocated by the high-level decoding entry points. It will allow us to unify the allocation logic in a single place.

Looks good to me. @ahmadsharif1 should also review.


Allow LaTeX comments in math blocks

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[x] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
When using comments in a math block, which are specific to LaTeX the math view breaks.
To Reproduce
Steps to reproduce the behavior:

Create math block with $$ $$
Write math
Comment one line with %

Expected behavior
Math view should still be woring even with comments like the default markdown preview.
Desktop (please complete the following information)

OS: Win10
Version: 0.80

Hi, unfortunately this is not something we'll be able to fix at this time because VSCode does not allow ESM packages, and latest versions of katex are ESM only. We are already at the latest supported version, so we have to wait until VSCode adds support for ESM.
I did find that the comments are partially supported though:

You can see that the "foo" at the end is not displayed thanks to the comment.


[fix] ndm exporter and lvm node driver service endpoint discovery

Signed-off-by: Abhishek Agarwal<EMAIL_ADDRESS>Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/openebs])

Did not find device-localpv operator here.


Theme breaks with Sphinx 7.2.0

Trying to build fails with Sphinx 7.2.0 with the following error:
Theme error:
An error happened in rendering the page index.
Reason: TypeError("argument of type '_CascadingStyleSheet' is not iterable")

We are having the same issue with the Read the Docs Sphinx Theme. See https://github.com/readthedocs/sphinx_rtd_theme/issues/1502 cc @picnixz

I'm eager to know when this issue will be resolved. Can you share any insights on the timeline?


[BACKLOG-40476] Change PDI File Browser to use PVFS URI on Backend

only use "pvfs://..." URI in VFSFileProvider
remove or deprecated the use of the variables 'connection' and 'domain'

gains:

simplifies code for VFSFileProvider.java by using the abstraction layer of PVFS
VFSFileProvider does not have to contain every VFS Providers URl logic for Provider URI <--> PVFS URI

I  removed (ie set null, set "", or eliminated ) or deprecated all the uses of connection and domain variables and code. I was running out of time for to fully remove them. I created https://hv-eng.atlassian.net/browse/BACKLOG-40656 to track this. As the code is harmless.  Currently the sonarqube code smells/bugs are related to me adding @depracted or unreachable code, which is expected.
PR dependencies:

The new root logic in VFSFileProvider#getRoot depends correct bucket flags. A coupe of providers need to be updated see PR: https://github.com/pentaho/pdi-plugins-ee/pull/1066

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 27m 31s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
engine,plugins/file-open-save-new/api,plugins/file-open-save-new/core,ui

:ok_hand: All tests passed!
Tests run: 2748, Failures: 0, Skipped: 5    Test Results

:information_source:  This is an automatic message

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 24m 39s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
engine,plugins/file-open-save-new/api,plugins/file-open-save-new/core,ui

:ok_hand: All tests passed!
Tests run: 2748, Failures: 0, Skipped: 5    Test Results

:information_source:  This is an automatic message

Addressing Sonar qube issues

main goal is to convert PDI browser to using PVFS, not all code is unit testable or easily unit testable. I tried where I could, weighing cost of testing new logic and fixing legacy code structure
most if not all the remaining  sonar qube issues are related to "@depreacted" which is tracked by https://hv-eng.atlassian.net/browse/BACKLOG-40656

https://github.com/pentaho/pentaho-kettle/pull/9310#issuecomment-2100649873

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:warning: Build finished in 24m 59s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
engine,plugins/file-open-save-new/api,plugins/file-open-save-new/core,ui

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 3 test(s) failed:
org.pentaho.di.trans.steps.datagrid.DataGrid_EmptyStringVsNull_Test.emptyAndNullsAreDifferent (click to expand)
[2][0] expected:<> but was:<null>

org.pentaho.di.trans.steps.fieldsplitter.FieldSplitter_EmptyStringVsNull_Test.emptyAndNullsAreDifferent (click to expand)
[2][0] expected:<> but was:<null>

org.pentaho.di.ui.core.dialog.EditRowsDialog_EmptyStringVsNull_Test.emptyAndNullsAreDifferent (click to expand)
[0][2] expected:<> but was:<null>

Tests run: 2748, Failures: 3, Skipped: 5    Test Results

:information_source:  This is an automatic message

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:warning: Build finished in 29m 42s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
core,engine,plugins/file-open-save-new/api,plugins/file-open-save-new/core,ui

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 8 test(s) failed:
org.pentaho.di.trans.steps.datagrid.DataGrid_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
[1][0] expected:<null> but was:<>

org.pentaho.di.trans.steps.fieldsplitter.FieldSplitterTest.testSplitFields (click to expand)
Unexpected output value at index 1 expected:<null> but was:<>

org.pentaho.di.trans.steps.fieldsplitter.FieldSplitter_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
[1][1] expected:<null> but was:<>

org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.fieldsWithLineBreaksWithEmptyLinesTest (click to expand)
[0][0] expected:<null> but was:<>

org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.readInputWithNonEmptyNullif (click to expand)
expected null, but was:<>

org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.readInputWithMissedValues (click to expand)
[0][1] expected:<[1]> but was:<[]>

org.pentaho.di.trans.steps.textfileinput.TextFileInputTest.readInputWithMissedValues (click to expand)
[0][1] expected:<[1]> but was:<[]>

org.pentaho.di.ui.core.dialog.EditRowsDialog_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
[0][1] expected:<null> but was:<>

Tests run: 4028, Failures: 8, Skipped: 6    Test Results

:information_source:  This is an automatic message

⚠ Build finished in 29m 42s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
core,engine,plugins/file-open-save-new/api,plugins/file-open-save-new/core,ui

⛔ Failed Tests
⛈ 8 test(s) failed:
org.pentaho.di.trans.steps.datagrid.DataGrid_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
org.pentaho.di.trans.steps.fieldsplitter.FieldSplitterTest.testSplitFields (click to expand)
org.pentaho.di.trans.steps.fieldsplitter.FieldSplitter_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.fieldsWithLineBreaksWithEmptyLinesTest (click to expand)
org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.readInputWithNonEmptyNullif (click to expand)
org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.readInputWithMissedValues (click to expand)
org.pentaho.di.trans.steps.textfileinput.TextFileInputTest.readInputWithMissedValues (click to expand)
org.pentaho.di.ui.core.dialog.EditRowsDialog_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
Tests run: 4028, Failures: 8, Skipped: 6    Test Results
ℹ This is an automatic message

I don't think I had anything to do with this. These tests are from pentaho-kette/engine and I only added javadoc comments to one class in  pentaho-kette/engine, no source code change.
When I run the tests locally from master with commit: https://github.com/pentaho/pentaho-kettle/commit/1dc52168c914289d1c6d18270e9d811420ecef39
I get 7 failures, see image below

As stated in description, the sonarqube findings are related to me removing/deprecating code which can be addressed in - https://hv-eng.atlassian.net/browse/BACKLOG-40656

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:warning: Build finished in 23m 44s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
core,engine,plugins/file-open-save-new/api,plugins/file-open-save-new/core,ui

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 8 test(s) failed:
org.pentaho.di.trans.steps.datagrid.DataGrid_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
[1][0] expected:<null> but was:<>

org.pentaho.di.trans.steps.fieldsplitter.FieldSplitterTest.testSplitFields (click to expand)
Unexpected output value at index 1 expected:<null> but was:<>

org.pentaho.di.trans.steps.fieldsplitter.FieldSplitter_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
[1][1] expected:<null> but was:<>

org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.fieldsWithLineBreaksWithEmptyLinesTest (click to expand)
[0][0] expected:<null> but was:<>

org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.readInputWithNonEmptyNullif (click to expand)
expected null, but was:<>

org.pentaho.di.trans.steps.fileinput.text.TextFileInputTest.readInputWithMissedValues (click to expand)
[0][1] expected:<[1]> but was:<[]>

org.pentaho.di.trans.steps.textfileinput.TextFileInputTest.readInputWithMissedValues (click to expand)
[0][1] expected:<[1]> but was:<[]>

org.pentaho.di.ui.core.dialog.EditRowsDialog_EmptyStringVsNull_Test.emptyAndNullsAreNotDifferent (click to expand)
[0][1] expected:<null> but was:<>

Tests run: 4028, Failures: 8, Skipped: 6    Test Results

:information_source:  This is an automatic message


Updates to prioritize MSIX

MSIX is our primary app packaging format and we want to reflect that in our relevant documentation. Updating descriptions and examples to primarily be MSIX, without removing the AppX mentions.

Docs Build status updates of commit d738042:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/appx/Appx.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1f64d00:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/appx/Add-AppxPackage.md
:white_check_mark:Succeeded

docset/windows/appx/Appx.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 75aea39:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/appx/Add-AppxPackage.md
:white_check_mark:Succeeded

docset/windows/appx/Appx.md
:white_check_mark:Succeeded

docset/windows/appx/Get-AppxLastError.md
:white_check_mark:Succeeded

docset/windows/appx/Get-AppxLog.md
:white_check_mark:Succeeded

docset/windows/appx/Get-AppxPackage.md
:white_check_mark:Succeeded

docset/windows/appx/Get-AppxPackageManifest.md
:white_check_mark:Succeeded

docset/windows/appx/Remove-AppxPackage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.

Hello @sharlaakers
Are you a Microsoft Employee right? please have a look at this, so you link your GitHub account to your Microsoft Account, thank you.
Approving this changes now...


Smoothness and derivatives for (cubic) curves

This is another prototype as part of the Curve project. Once again, I have ignored NURBS for the time being.
Objective
Provide a general framework for expressing smoothness for curves (up to C2) and integrate it with bevy_math's existing cubic spline constructions.
Solution
Continuous/differentiable curves
There are a few layers here. At the most basic level, we have a trait-enshrined way of expressing tangent spaces at the level of types:
pub trait HasTangent {
    type Tangent;
}

The point of this is that it is used to define types WithDerivative<T> and WithTwoDerivatives<T> that pair a point with derivatives at that point (elements of the tangent space). For example:
/// A point with a tangent.
pub struct WithDerivative<T>
where
    T: HasTangent,
{
    /// The underlying point.
    pub point: T,
    /// The derivative at `point`.
    pub derivative: T::Tangent,
}

Now, the central idea connecting this to curves is that a differentiable curve is a curve that returns WithDerivative<T> when sampled, so that the point component provides the position and derivative provides the velocity. We have introduced some new traits that work this way: they are just marker traits on top of Curve<...>:
pub trait ContinuousCurve<T>: Curve<T> {}

pub trait DifferentiableCurve<T>: Curve<WithDerivative<T>>
where
    T: HasTangent,
{
}

//...

Of course, with these traits, it's worth keeping in mind that they will not be preserved by the abstract Curve interface methods. For example, applying Curve::map to a differentiable curve, the result need not generally be differentiable. The same is true for many operations, including simple ones like compose (which joins two curves end-to-end).
On the other hand, the result of calling such functions may actually be continuous, differentiable, and so on. To bridge this gap in expressivity, we have also introduced a wrapper struct Blessed and a method bless that produces it so that the user can explicitly elevate to the level of these marker traits when necessary:
/// Bless this curve, allowing it to be treated as continuous, differentiable, and so on.
fn bless(self) -> Blessed<Self> {
    Blessed(self)
}

Cubic segments and curves
The interoperation of cubic curves with this new technology comes in a few parts. Firstly, CubicCurve has an additional marker type parameter S: Smoothness which indicates the global guarantees of smoothness that issue from the curve's construction. This parameter has four levels: Nothing, C0, C1, and C2. CubicCurve<P, S> is itself a Curve<P>, sampling from its position. If its Smoothness parameter is at least C0, then it is a ContinuousCurve. CubicSegment<P> is similar, but it is always a ContinuousCurve (it has no Smoothness parameter).
To access higher derivative information through the Curve interface, there are a pair of new methods on both CubicSegment and CubicCurve:
/// Returns a [curve] whose samples include both the position and velocity from this curve. If
/// this curve is at least C1, then the output is a [`DifferentiableCurve`].
///
/// [curve]: Curve
#[inline]
pub fn with_velocity(&self) -> SegmentDerivative<&Self> {
    SegmentDerivative(&self)
}

/// Returns a [curve] whose samples include the position, velocity, and acceleration from this
/// curve. If this curve is at least C2, then the output is a [`TwiceDifferentiableCurve`].
///
/// [curve]: Curve
#[inline]
pub fn with_velocity_accel(&self) -> SegmentTwoDerivatives<&Self> {
    SegmentTwoDerivatives(&self)
}

CubicCurve is similar. The wrapper types SegmentDerivative and SegmentTwoDerivatives (truly inspired nomenclature) implement DifferentiableCurve and TwiceDifferentiableCurve respectively. Similarly, the wrapper types for CubicCurve — CurveDerivative and CurveTwoDerivatives — implement DifferentiableCurve and TwiceDifferentiableCurve if the underlying Smoothness parameter is at least C1 or C2 respectively.
Putting it together
For starters, we can use the Curve interface pretty seamlessly in conjunction with cubic splines:
// This is a `Curve<P>` where `P` is determined by the control data:
let my_curve = CubicBSpline::new(control_data).to_curve();
// so we can do all the usual curve operations on it:
let new_curve = my_curve.reparametrize(|t| f32::cbrt(t));

For something more complex, let's imagine we have some geometric operation which wants a differentiable curve as input and produces some output:
pub fn do_geometry(curve: impl DifferentiableCurve<Vec3>) -> Output { //... }

For a cubic curve, we could do something like this:
let my_curve = CubicHermite::new(points, tangents).to_curve().with_velocity();
let output = do_geometry(my_curve);

On the other hand, if I specified my inputs with CubicBezier but I made sure it's differentiable using the folds of my brain (or am willing to accept the consequences of doing something weird), I can use the bless interface to work with it:
let my_curve = CubicBezier::new(control_data).to_curve().with_velocity();
let output = do_geometry(my_curve.bless());

Migration Guide
Some existing uses of the CubicCurve type will need to be annotated with a Smoothness parameter in order for the program to compile. This is because CubicCurve now tracks its global continuity and differentiability guarantees. For similar reasons, existing uses of CubicCurve::push_segment or Extend::extend will require first calling CubicCurve::without_smoothness in order to destroy the smoothness guarantees from the curve's construction, since arbitrary concatenations of curve segments cannot be known by the compiler to maintain these guarantees.

Closing in favor of #16503 for now, which makes much less sweeping changes.


feat(html/parser): raw for doctype

Description:
Added raw for doctype (better linting and codegen)
BREAKING CHANGE:
Yes
Related issue (if exists):
No

@kdy1 rebased and update tests


Ammo kinematic transforms break when combined with THREE's .attach()

Trying to combine THREE's recent .attach() https://github.com/mrdoob/three.js/pull/16528
with Ammo's kinematic bodies. The ammo bodies don't seem to transform as expected
https://glitch.com/edit/#!/ammo-grab
https://ammo-grab.glitch.me/
@InfiniteLee suggested

huh yea it looks like the collider's transform gets totally messed up
whatever attach is doing must not be playing nice with how ammo-body grabs the world transform for kinematic bodies
i would do some debugging in ammo-body syncToPhysics

This is attempting to use .attach() as a way to keep a physics object firmly locked onto a hand as it moves (even just visually, it is alright if the physics body lags a tiny bit behind)
Hoping this could become a definitive approach to this very commonly desired feature (also haven't thought about if it would be viable in NAF)
https://github.com/donmccurdy/aframe-physics-system/issues/81
https://github.com/aframevr/aframe/issues/2425

following up...

Kevin Lee
i had an idea just now about what the issue probably is.
https://github.com/donmccurdy/aframe-physics-system/blob/6cb498263f0ac6401b5784bce24a5b827e3e7ffc/src/components/body/ammo-body.js#L380
there's this check for the parent of the entity to see whether or not it should try to calculate the world transform or not
if attach is doing something where its not actually parenting the grabbed object under the hand, it will still try to use the local transform
which would explain why the collider appears in the ground (at origin)
that check is probably not super necessary (it was just a perf saving attempt on my part)
but you can hack around the issue by nesting the objects under an empty entity
not ideal though

which indeed works !
https://grab-again.glitch.me/
https://glitch.com/edit/#!/grab-again

if you opened that issue already, feel free to mention that. I'll have to think about whether or not that check is important or not...


stick oc to version 4.15

What type of PR is this?
(bug/feature/cleanup/documentation/unit-test)
What this PR does / Why we need it?
Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
Pre-checks (if applicable)

[ ] Ran unit tests locally
[ ] Validated the changes in a cluster
[ ] Included documentation changes with PR

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.35%. Comparing base (4ce37a3) to head (0ab574e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   45.35%   45.35%
=======================================
  Files          65       65
  Lines        5373     5373
=======================================
  Hits         2437     2437
  Misses       2609     2609
  Partials      327      327

/lgtm


'install awscli' fails when aws is already installed

I tried your role under AlmaLinux9 installed in WSL2 in Windows. First I only called the role as is, and it correctly installed aws cli 2.9.20. Then I upgraded the playbook by specifying the latest version of awscli under vars:
---
- name: Install aws cli
  hosts: all
  become: true
  vars:
    awscli_version: latest

  roles:
    - bodsch.awscli

The playbook failed with:
fatal: [localhost]: FAILED! => {"changed": false, "cmd": ["/var/tmp/aws/install"], "delta": "0:00:00.297718", "end": "2023-02-17 16:17:45.819835", "msg": "non-zero return code", "rc": 1, "start": "2023-02-17 16:17:45.522117", "stderr": "Found preexisting AWS CLI installation: /usr/local/aws-cli/v2/current. Please rerun install script with --update flag.", "stderr_lines": ["Found preexisting AWS CLI installation: /usr/local/aws-cli/v2/current. Please rerun install script with --update flag."], "stdout": "", "stdout_lines": []}

Your role doesn't seem to handle upgrades. In /tasks/install.yaml, line 38, the AWS install script has to be called with the --update flag.
I have to say your role is a lot cleaner than my usual approach, which consists of uri, unarchive and lots of shell commands to compare the latest and current versions. Thanks for your work. I'm still learning ansible, and this is a good example of how I could make my own roles, with tests.
Regards.

My role does allow updates very well.
This involves completely removing the currently installed (old) version and unpacking the new version. An --update in the installation call is therefore unnecessary.
There is even a separate molecule test for that.
However, I am not sure if the environment used (WSL and Windows) could be a problem here.

Please try 1.3.0

@sylchamber-qc Have you tested the new version?
Do you still have a problem?
Otherwise I would close the issue.

Ah sorry, I didn't see the notification. I will try today.

@sylchamber-qc ping

For me it is not comprehensible and there is a separate test workflow for this purpose.
I am closing the issue.


[WIP] Energy minimization compute deployment / execution

Description
This PR addresses #12.
We will want to merge this as soon as we have reached basic functionality (protocol executes on a test molecule). A follow-up PR will focus on error handling and performance.
Todos

[x] finish basic user touchpoints in openff-benchmark fractal.
[x] finish basic user touchpoints in openff-benchmark optimize.
[ ] add tests for optimization compute components

Status

[ ] Ready to go

We now have both submission and export entry-points in place. Need to write up initial QM-then-MM protocol next.
This is ready for an initial review @j-wags when you get the chance. There may be many details I failed to capture.

Thanks for the review @jthorton!
@dfhahn, if you like you can give this branch a play using the approach in the demo notebook to generate the inputs needed for downstream analysis. Note that in this notebook we first generate the QM optimizations, then export the final geometries with initial and final energies as key-values in the SDF files. Then, we use those QM SDFs as our inputs for the MM optimizations.
I believe the resulting outputs should be everything you need for downstream analysis. Please let us know if this presents problems, or if you think we could be structuring the compute approach differently to make analysis easier.

Merging, as now need to do some synthesis work with the CLI to string together multiple workflow components.


"Alt Absorption Sound" Crashes Game On Taking Damage

Full Log: https://mclo.gs/zXl8tKz

if i guessed wrong please reopen

Might have to as I never even configured Fabrication from within the game, rather, I modified the config file and then started my game.
I should have attached this too:

i used "resolve" to try avoid gh auto closing the issue.
the commit probably fixes the issue (i say probably because i haven't gotten the crash possibly world specific/mod conflict no clue)


[Question] Question about the arguments in the training script

Question
Hi,
Thanks for sharing your work. I have a few questions about some of the arguments used in the training script.

DataArguments.sep_image_conv_front: What does this parameter mean? I'd like to know details of why this option exists.
TrainingArguments.force_fsdp: What does this parameter do? I couldn't find where it is being used.

Thank you very much in advance!

Hi, these are parameters used in earlier code versions, and now we move to DeepSpeed and thus removed the need of these. Thanks.


Logged In status API

Hi and thanks for your scraper,
As user I need to check if I am logged in now. There is isLoggedIn but it requires $session, to get it I need a key, but getCacheKey is private. So as a minimal solution I suggest to make  getCacheKey public.
Here is PR.

Resolved.


fix migrations in develop

the migrations aren't working now in develop

Resolved - we should probably learn & teach how to handle these situations correctly so this won't happen in the future


Add paragraph about code analysis tools

Fixes the code analysis tools part of #263

Add tooling to masters curriculum at static and dynamic.

@jpthiele I added the swebok and vi-hps https://vi-hps.org/
what do you think?

I think it's a good addition, thanks!


fix(downloader): be consistent in downloading files

This PR puts some order in the downloader such as functions are re-used across several places.
This fixes an issue with having uri's inside the model YAML file, it would resolve to MD5 rather then using the filename

While we are changing the format of the yaml 's model path, should we take the opportunity to rip out MD5 as well? While I'm still not particularly worried about hash collisions in this case, it would quiet down security and other automated scanners. A more modern hash can't be that much worse to compute for this usecase.

While we are changing the format of the yaml 's model path, should we take the opportunity to rip out MD5 as well? While I'm still not particularly worried about hash collisions in this case, it would quiet down security and other automated scanners. A more modern hash can't be that much worse to compute for this usecase.

right we should get rid of it, but I don't want to  make it part of this pr. The real problem is addressing here is that if currently you specify a YAML config file, e.g.:
name: LocalAI-Llama3.1-8b-Function-Call-v0.3
context_size: 8192
parameters:
  model: huggingface://mudler/LocalAI-Llama3.1-8b-Function-Call-v0.3-GGUF/LocalAI-Llama3.1-8b-Function-Call-v0.3-q4_k_m.bin
stopwords:
- <|im_end|>
- <dummy32000>
- <|eot_id|>
- <|end_of_text|>

Now it will download the file locally with the correct name, but later it will try to resolve it as md5 and fails in loading. I know it seems it does much this PR, but it just re-uses more shared code introducing the type URI.

While we are changing the format of the yaml 's model path, should we take the opportunity to rip out MD5 as well? While I'm still not particularly worried about hash collisions in this case, it would quiet down security and other automated scanners. A more modern hash can't be that much worse to compute for this usecase.

right we should get rid of it, but I don't want to make it part of this pr. The real problem is addressing here is that if currently you specify a YAML config file, e.g.:
name: LocalAI-Llama3.1-8b-Function-Call-v0.3
context_size: 8192
parameters:
  model: huggingface://mudler/LocalAI-Llama3.1-8b-Function-Call-v0.3-GGUF/LocalAI-Llama3.1-8b-Function-Call-v0.3-q4_k_m.bin
stopwords:
- <|im_end|>
- <dummy32000>
- <|eot_id|>
- <|end_of_text|>

Now it will download the file locally with the correct name, but later it will try to resolve it as md5 and fails in loading. I know it seems it does much this PR, but it just re-uses more shared code introducing the type URI.

I'm sold on keeping it limited to that for now. type URI string was a good introduction :)

trying to do some bugfixing so we can cut another patch release as 2.19 did got quite few regressions. then we can start merging bad things that could break :smiley_cat:
I'd like to have also https://github.com/mudler/LocalAI/pull/2890 in, let's see if can get fixed during this week end

Another fix [probably out of scope, just tagging it here for notes] is to modify File.URI to be of the new type - would avoid some conversion at this stage.
https://github.com/mudler/LocalAI/blob/d792cf115b2e11cacffaa19707a0e3f42e5e85f8/core/config/backend_config.go#L77

Another fix [probably out of scope, just tagging it here for notes] is to modify File.URI to be of the new type - would avoid some conversion at this stage.
https://github.com/mudler/LocalAI/blob/d792cf115b2e11cacffaa19707a0e3f42e5e85f8/core/config/backend_config.go#L77

ekk tried already, https://github.com/mudler/LocalAI/pull/3108/files#diff-b763c168954daf0de0c66797d84a70a83c56a945ed1ed24d8eb33f2303a62ed4R76 but sadly doesn't save from silly conversions down the line :shrug:

@dave-gray101 added also a fix for huggingface scanning ( reported in https://github.com/mudler/LocalAI/issues/3114 )


Ability to configure the resource name prefix

Currently SST adds a naming convention of ${stage-name}-${app-name}  to each resource. Is it possible to configure this or can support be added for this in the future?

Hey @ryands17, got it. Lemme add it to the roadmap.
Btw, do you want to configure just the stack name, or each resource (ie. function name, queue name, etc)?


Minimize Ansible facts needed

The role requires only a couple of Ansible facts, and it has already some logic to handle their lack; sadly, since all the tests have gather_facts=true, this is not tested (as all the Ansible facts are available upfront). Also, the current way for the role to ensure to have its own facts is to collect the "min" subset, which contains way more than what the role needs.
Improve this situation a bit, both in what the role needs and how the tests work:

introduce a separate __rhc_required_fact_subsets internal variable, which represents the list of fact subsets matching the existing __rhc_required_facts internal variable; they look similar now, they don't necessarily need to, however
use __rhc_required_fact_subsets for the "setup" task of the role, rather than "min"
set gather_facts=false in all the tests to ensure no facts are collected upfront, to check that what is needed will be collected on demand before use
since "tests_environments" explicitly uses a couple of Ansible facts, manually collect them
collect also a couple of facts when using external test data: this is because it is possible to conditionalize some of the test data variables based on the distribution version

This should make the role slightly faster to run (at least the first time in a play) in case none of the needed Ansible facts for it is already collected.

@richm thanks for the notes, I have the fixes locally. Before I keep testing/updating this: do you see anything problematic in the approach/changes?

No, I think this is fine.

[citest]


SelectMenu ability to clear search string

Description
Basically I want to avoid this situation:
https://github.com/nuxt/ui/assets/967369/1bbd7b71-54c3-4d06-bac2-103dfd95f874
Additional context
It would be nice to clear search for when the menu is destroyed and during my flow of creation.

Thanks for creating this, I was hoping for this exact option, however it doesn't seem possible out the box.

To add to this, what would be ideal is if the value of search is expose to the USelectMenu component, and then it could be manipulated (cleared or changed) from the USelectMenu component.
My use-case is I'm hoping to be able to utilise the USelectMenu to create an "input tag" component. The items for the USelectMenu would be any pre-existing tags. When the user searches for a tag, and it doesn't exist, they could create the new tag by pressing 'Enter'. What I'd like to be able to do is to "sluggify" the output of the new tag, and once they pressed 'Enter' then clear the value of search for that the full list of tags (including the newly created tag) is then shown to the user.


Remove section on geographic profiling

It's not possible to do justice to geographic profiling justice in the time available and this is a case where a little knowledge could well be dangerous, so remove this content.

This supersedes #17 so that can be closed at the same time.

This actually supersedes #16 so that is what should be closed, not #17


node12.16.0  Operation error

I'm using nodejs 12.16.0 and cesium 1.66
In node 12.16.0, I found that cesium couldn't run：
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: D:\github\CesiumJS\server.js
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1173:13)
    at Module.load (internal/modules/cjs/loader.js:1001:32)
    at Function.Module._load (internal/modules/cjs/loader.js:900:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)
    at internal/main/run_main_module.js:18:47 {
  code: 'ERR_REQUIRE_ESM'
}

When I switch to node 10.17.0, cesium 1.66 can run

Does cesium plan to support the new version of nodejs？

@ShareQiu1994 thanks for opening an issue.
Cesium already supports Node 12 and I am unable to reproduce this problem with 12.6.0. Can you please provide the exact steps to recreate it?
It appears Node 12.6.0 has 6 significant regressions that they quickly patched in 12.6.1: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#2020-02-18-version-12161-erbium-lts-mylesborins Perhaps you are hitting one of these?

@mramato Thank you for your answer.
repro steps:
1.git clone https://github.com/CesiumGS/cesium.git
2.npm install
3.node server.js
My environment：
Nodejs 12.16.1
Cesium 1.66
Windows 10
When I upgraded the node to 12.16.1, I found that the problem still existed.
I don't know if it's a problem with my system environment. I'll try changing the machine.Thank

@ShareQiu1994 My apologize but I can now reproduce this.  I accidentally ran with 12.6 instead of 12.16.  This is a breaking change during the 12.x line from the NodeJS team.  Looks like they changed behavior as of 12.10.
I'm looking into it.

There are 2 issues here:

Make Cesium's dev server and release package operations all run under Node 12.  This should be easy.

Make Cesium itself build using Node 12.  This is harder.  It looks like the breaking changes from Node 13 were backported to 12.  There is an initial PR in #8541 but there are showstoppers in our dependencies.

CesiumJS itself works under Node 12, Node 12 based applications can import and use it without issue. It's only the developer tools we use to build Cesium that actually have issues.

Updated my above comment but I'm closing this issue in favor of tracking it as part of #8452

@mramato Thank you for your efforts, I will continue to pay attention to its changes

This is fixed in master and will be released as part of 1.68 on April 1st.


Allow alternate nicknames for bots

I believe there was some discussion on IRC, but I don't remember the conclusion. It would let people use things like e.g., bench for benchable, bisect for bisectable. You could always implement it by hand with irc-all(), but that seems like overkill. Maybe it would be as simple as turning this:
if $e.text.subst-mutate: /^ $nick <[,:]> \s* /, '' {
into this:
if $e.text.subst-mutate: /^ @nicks <[,:]> \s* /, '' {

Added in version 3.006001 as :alias argument. It can take a list of Str or Regex and functions as an alias to the currently used nick:
    .run with IRC::Client.new:
        :nick<Foo>
        :alias('bar', /meow [able]?/);

    ##
   # Foo, do stuff
   # bar, do stuff
   # meow, do stuff
   # meowable, do stuff

Amazing! Thank you


Twitter integration

Hi, @edsu. This one taken a little effort haha.
It's a draft by now as I'm testing this in real life in order to be sure it's actually working and not only passing the tests I built for this.
Additions
At functionality level I've just added the ability to tweet the changes in the same thread and only if the article has at least one diff detected. If the article has no diff, no tweet is generated.
Tests
In order to properly test this, I've taken the Twitter functions into a separate file, so I could mock its functionality when creating the test suite.
I've tested every possible scenario I could think of. Anyway, I'm running this locally within a classic cron on my local machine, in order to ensure that not only the test passes but also works in real life.
When I confirm it's really okay, I'll set the PR ready to be reviewed by you.
About Travis integration
I think you should connect Travis to the diffengine repo and configure it to not let you merge if it doesn't pass so we avoid things like happened in the past PRs. What do you think?
It's very easy to do, really.
I've done myself for my fork so I'm sure that I don't broke it before I go with the PR to this repo. It's passing right now.

Hope it helps

Thanks for all this work @nahuelhds! I'm glad to see diffengine is breaking out from the monolithic init.py file, and it is going to great to have this thread functionality you have devised merged in. I really appreciate all the efforts you are making to test the twitter integration.
If there is a setting I should change in the .travis.yml let me know. At the moment the tests only run when there has been a change to the master branch? Should I relax that and allow it on branches as well? I believe that GitHub warned me about merging a branch that failed tests earlier, but I tend to merge on the command line.

Not really a travis setting at yml level but defining the Travis integration to run the CI cycle on the PRs, so you can see they don't break anything before merging them to master. That's the way I've configure it on my fork, for instance.

I can confirm that it's working fine and creating threads

@edsu you can review this now.
Next steps:

Optional text for the different types of changes: title, url, summary. E.g.: a tweet saying "Changes in the title and the url" and so.
Configurable logging directly to the console (useful when running from the cli and debugging (not depending on the log file only)
Configurable database engine (sqlite, postgres)

But I rather merge this first because is a huge change in the code.

I will take a look. Isn't Travis already running your PRs?
https://travis-ci.org/github/DocNow/diffengine/pull_requests
Please let me know what knob to turn on GitHub or Travis if you need something changed.

This PR is incredibly thorough and clean @nahuelhds. Thank you for spending the time to clean up, and throughly test the work you did on that initial proof-of-concept branch! This is going to sound overly dramatic, but people like you are the reason why open source ever worked in the first place.

Thank you very much Ed, for this and the tweet today. I have no words. I'm really excited by collaborating with this project. It saved me a lot of work and thinking. So I'm glad I can collaborate with these ideas.

About Travis, I don't see anything related when I open a PR at diffengine repo. Weird, I should see it if it's already integrated, right?


Not user friendly exception while giving a none existing path

Executing:
python -m deephyper.search.hps.ambs --problem ../deephyper/deephyper/benchmark/hps/toyCond/problem.py --run ../deephyper/deephyper/benchmark/hps/toyCond/problem.py --evaluator subprocess

Stacktrace example
Uncaught exception <class 'TypeError'>: the 'package' argument is required to perform a relative import for '../deephyper/deephyper/benchmark/hps/toyCond/problem'Traceback (most recent call last):
  File "/Users/romainegele/opt/anaconda3/envs/dh/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/Users/romainegele/opt/anaconda3/envs/dh/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/romainegele/Documents/Argonne/deephyper/deephyper/search/hps/ambs.py", line 115, in <module>
    search = AMBS(**vars(args))
  File "/Users/romainegele/Documents/Argonne/deephyper/deephyper/search/hps/ambs.py", line 48, in __init__
    super().__init__(problem, run, evaluator, **kwargs)
  File "/Users/romainegele/Documents/Argonne/deephyper/deephyper/search/search.py", line 43, in __init__
    self.problem = util.generic_loader(problem, 'Problem')
  File "/Users/romainegele/Documents/Argonne/deephyper/deephyper/search/util.py", line 159, in generic_loader
    return load_attr_from(target)
  File "/Users/romainegele/Documents/Argonne/deephyper/deephyper/search/util.py", line 123, in load_attr_from
    module = import_module(str_module)
  File "/Users/romainegele/opt/anaconda3/envs/dh/lib/python3.7/importlib/__init__.py", line 122, in import_module
    raise TypeError(msg.format(name))
TypeError: the 'package' argument is required to perform a relative import for '../deephyper/deephyper/benchmark/hps/toyCond/problem'

resolved in #a33809b


Upgrade Android Billing Library

Version of flutter_inapp_purchase
flutter_inapp_purchase 5.4.2
Platforms you faced the error (IOS or Android or both?)
Android platform, Target SDK android 14
Expected behavior
The app is uploaded to play store successfully.
Actual behavior
The app refuse to be uploaded to playstore.
It shows the following error:-
This app targets Android 14 or above, and your current Play Billing Library version doesn't support Android 14. To target the latest Android version, please update your PBL version to either 5.2.1, or 6.0.1 and above.
Tested environment (Emulator? Real Device?)
Real Device
Steps to reproduce the behavior
Install the latest package and upload the app to play store

Hi Team,
Any update on this?
Thanks

There is information on the web that an update is required if the app targets Android 14 or later.
https://developer.android.com/google/play/billing/migrate-gpblv6?hl=en

Hi people any update on this?

any updates on this?


[test] Modified intro file.

description here

Was testing out how to push changes to SB with Faus!


Missing namespace when using AGP 8

When trying to build my app with AGP version 8.x and targetSdkVersion 34 i get this error:
A problem occurred configuring project ':sumup'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file: /Users/valley/.pub-cache/hosted/pub.dev/sumup-0.9.0/android/build.gradle. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

What's missing is a namespace entry in android/build.gradle like this:
android {
    namespace "io.purplesoft.sumup"
    ...
}

Could you please add this missing part?
Thanks a lot.

Fixed in version 0.10.0

Thanks a lot!


Fix license metadata in package.json

See https://github.com/JulietaUla/Montserrat/blob/master/OFL.txt and quoting the README :

The goal is to rescue what is in Montserrat and set it free, under a free, libre and open source license, the SIL Open Font License.

Currently, we have the license field for every package set to MIT (which is what Fontsource is licensed under), so this was intentional. We actually do have an issue open for this though, to switch the license field to that of the font, not Fontsource. This should be implemented in Fontsource version 5.

Yup. We can't keep manual edits like this as all packages are automatically generated and rebuilt occasionally. These changes will get wiped unless programmatically implemented.
Closing in favour of #156. Thanks!


Bug title of Organization in card wraps strangely

Expected Behavior

Probably should wrap on word.

Current Behavior
Wraps on character.

Possible Solution
Update the css of the .v-card__title to be
    align-items: left;
    font-size: 1.25rem;
    font-weight: 500;
    letter-spacing: .0125em;
    line-height: 2rem;
    text-align: left;

Steps to Reproduce

Go to https://amplify-app-production.herokuapp.com/
Look at cards with long titles

Context (Environment)

Detailed Description

Possible Implementation

Labels
Please add the following labels dependent on the bug type

Security Bug: Creates an issue that can cause harm
Vulnerability Bug: Creates an issue to update a supply chain dependency error
Functional Bug: something that is causing a crash of the app

I think this has already been done.


Malordered Data Received even if the config is sent before

I'm trying to use the Google Speech-To-Text API (through the @google-cloud/speech npm package) to transcribe some audio from a browser mic (need to be cross-browser so I can't use the Chrome API).
I'm creating a streamingRecognize with the needed parameters and then I push some data to this stream but the API response is the following one: "Malordered Data Received. Send exactly one config, followed by audio data".
Here's the code:
const gcpClient = new gcpSpeech.SpeechClient();

const encoding = 'LINEAR16';
const sampleRateHertz = 16000;
const languageCode = 'en-US';

const request = {
  config: {
    encoding: encoding,
    sampleRateHertz: sampleRateHertz,
    languageCode: languageCode,
  },
  interimResults: true
};

const recognizeStream = gcpClient.streamingRecognize(request);

recognizeStream
.on('data', (data) => {
    console.log("onDataThing", data);
    process.stdout.write(
              data.results[0] && data.results[0].alternatives[0]
                ? `Transcription: ${data.results[0].alternatives[0].transcript}\n`
                : `\n\nReached transcription time limit, press Ctrl+C\n`
            )
})
.on('error', (error) => {
    console.log("error", error);
});

io.on('connection', (socket) => {
    socket.on('audiodata', (data) => {
        console.log("audiodata", data);
        recognizeStream.write(data);
    });
});

As you can see, I'm getting the audio from the browser and send it via a socket (using socket.io) to the backend to have a streaming recognition.
The config is sent when creating the stream with streamingRecognize and then the audio is sent by chunk of data so I don't understand why is it considered as Malordered.
If you have any idea or solution, that would be awesome!

@danajeremy did you solved this problem?

For me the issue was happening because in the browser I've been requesting data from MediaRecorder and then listening for dataavailable etc. Apparently because it's OGG encoded the speech API doesn't understand chunks (even though I passed encoding).
After I switched to requesting data without MediaRecorder, it started working (with encoding = 'LINEAR16'):
function convertFloat32ToInt16(buffer) {
    let l = buffer.length;
    let buf = new Int16Array(l / 3);

    while (l--) {
      if (l % 3 === 0) {
        buf[l / 3] = buffer[l] * 0xFFFF;
      }
    }
    return buf.buffer
  }

  const socket = io("http://localhost:3000");

  function microphoneProcess(e) {
    var left = e.inputBuffer.getChannelData(0);
    var left16 = convertFloat32ToInt16(left);
    socket.emit('audioMessage', left16);
  }

  const handleSuccess = function(stream) {
    const context = new AudioContext();
    const source = context.createMediaStreamSource(stream);
    const processor = context.createScriptProcessor(2048, 1, 1);

    source.connect(processor);
    processor.connect(context.destination);

    processor.onaudioprocess = function(e) {
      microphoneProcess(e);
    };
  };
  navigator.mediaDevices.getUserMedia({audio: {sampleRate: 16000}}).then(handleSuccess);


MB-10498: Increase open file limit in AWS

Description
When running the load test, AWS reported errors about the number of open files. This increases the limit
Reviewer Notes
This has been deployed to loadtest env and confirmed to fix the problem.

Messages

:book:
:link: MB-10498

  Generated by :no_entry_sign: dangerJS against 96592f2def6eaa7d288066b7e413085a801456c8


Erroneous import highlights in ST3

Modules imported from packages listed in "build-depends" section of the cabal file are highlighted as "Could not find module", even if they are installed globally and stack build works. Also, all modules in my project have the similar highlight.
How do I circumvent this problem?
Config: Ubuntu16.04, stack-1.6.3, latest hie, latest ST3

I have the same problem.

@jflanglois There are two possible solutions, both are based on the same effect: ST3 normally inherits PATH from where it was launched (and, therefore, so does hie). Packages outside base are visible from stack path, but not from PATH, hence the can't find module.
First solution - launch ST3 via stack: stack exec -- sublime .
Second solution - lauch hie from ST3 via stack: in the LSP config the command should be "command": ["/path/to/stack", "exec", "--", "hie-wrapper", "--lsp", "-d"]

@ShrykeWindgrace Ah I just realized that I misread the issue. In my case only internal imports from the package are not working for hie.

Can a ST3 user make a PR against the README about this?

@alanz I can do that, but not earlier than tomorrow morning

@ShrykeWindgrace both proposed solutions seem wrong to me, as stack exec needs to use the correct resolver for the project

@nponeccop and why would it not use the correct one? If I launch ST3 in my project folder via stack exec -- sublime ., stack knows about the resolver, doesn't it?

@nponeccop even if hie-wrapper manages to detect the project root, resolver, and ghc version, how does it spawn the corresponding hie? Does it supply the correct path (via stack exec / stack path / its cabal counterpart)? If it does not, then the problem of finding locally installed executables like hspec-discover (or simply packages only visible to stack path) remains.
I agree that both my solutions are closer to workarounds than to longterm approaches, but these are the only solutions I found so far.

I agree. The workaround is worth documenting, and the issue with hie is worth fixing.


ENH: create

As summarised in the readme

Tutorial 3 - A full cataloging pipeline - to be completed
This tutorial takes you through the steps of:

dataset structuring with DataLad
metadata addition and extraction with DataLad MetaLad
translating metadata into the catalog schema
catalog generation and testing with DataLad Catalog
publishing your catalog online

Also, to be informed by the notes of @jkosciessa here: https://github.com/jkosciessa/datalad_cat_test/blob/main/readme.md

If this is to be created, it would essentially be a duplication of https://handbook.datalad.org/en/latest/beyond_basics/101-182-catalog.html


[Bug]: github-actions workflow to build and publish docker image failing

Describe the bug
The github-actions workflow to build and publish docker image is failing with below error:
Error: buildx failed with: error: failed to solve: process "/dev/.buildkit_qemu_emulator /bin/sh -c /usr/local/bin/install-plugins.sh < plugins.txt" did not complete successfully: exit code: 255

To reproduce
Trigger the workflow without explicitly setting up QEMU emulator.
Expected behavior
No response
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

If this is for jenkins main node then no need to care about using buildx.
We can lock the jenkins mainnode to use x64.
It is not like we would ever run our Jenkins on arm64.

This was regarding building the docker image on GHA. Nothing related to jenkins. Looks like the fix is in. Closing the issue.
Thanks!


Add nameable and decoration files

In this phase of the project, I have implemented the following;

Created a class called nameable and implemented a correct_name method to raise a NotImplementedError
Make the person class inherit from the nameable class
Created a class called Decorator to inherit the nameable class
Created a  CapitalizeDecorator to inherit the decorator class
Created a TrimmerDecorator to inherit from the decorator class

Thanks for the correction. I'm implementing right away
Sent from Yahoo Mail on Android
On Tue, Apr 18, 2023 at 10:03 PM, Bright @.***> wrote:
@brytebee requested changes on this pull request.
Hi, @Divinity-dev 👋 ,
Highlights 💡

Good commit message. ✔
Good PR Summary. ✔
Great UI design. ✔
App functions as it should. ✔

Good job so far coming so far with the progress you've made! 💪 💪
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Please, remember to tag me in your question so I can receive the notification.
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In trimmer_decorator.rb:

@@ -0,0 +1,7 @@
+require './decorator'

+class TrimmerDecorator < Decorator

def correct_name

Required: This method should return only the first 9 characters if a name is longer than that. It does work as required. Consider the code snippet below.
def correct_name
@nameable.correct_name[0..9]
end

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thank you
Sent from Yahoo Mail on Android
On Tue, Apr 18, 2023 at 10:14 PM, Bright @.***> wrote:
@brytebee approved this pull request.
Hi, @Divinity-dev 👋 ,
Highlights 💡

Good commit message. ✔
Good PR Summary. ✔
Great UI design. ✔
App functions as it should. ✔

STATUS: APPROVED 🕺 🥳
Congratulations 🍾 🥳 !! Your project is ready for presentation! There is nothing else to say other than... it's time to merge it
Good luck! 🎉
Optional Suggestions:

N/A

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Prerequisites in readme.md - build tools 149

Hi, I had problems building the SimplePlay3DSpatialSoundUWP audio sample due to "MSB4057: The target 'MarkupCompilePass1' does not exist in the project" against the DirectXTK project.
Finally solved this by installing the 10.0.14393 Windows 10 SDK for Visual Studio Built Tools 2017 15.2 (26530.15). This is not part of the default build tools install.
Please add build tools and versions to the prereqs, and if there's a way to adjust the build tools installer to include the latest version of all required components, that would be great.

As of April 8, 2017, all the projects in this repo were set to use VS 2017 and the Windows 10 Creators Update SDK (15063). That was when the spatial audio samples were added as well. There should be no reason you have to have the older Windows 10 Anniversary Update SDK (14393) installed to build them.

That pointed me to the issue. Both DirectXTK .vcxproj files reference 14393 as the minimum version:
10.0.14393.0

From: Chuck Walbourn<EMAIL_ADDRESS>Sent: Tuesday, July 11, 2017 3:01 PM
To: Microsoft/Xbox-ATG-Samples
Cc: Engel, Nic B.; Author
Subject: Re: [Microsoft/Xbox-ATG-Samples] Prerequisites in readme.md - build tools 149 (#3)
As of April 8, 2017, all the projects in this repo were set to use VS 2017 and the Windows 10 Creators Update SDK (15063). That was when the spatial audio samples were added as well. There should be no reason you have to have the older Windows 10 Anniversary Update SDK (14393) installed to build them.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Microsoft_Xbox-2DATG-2DSamples_issues_3-23issuecomment-2D314585051&d=DwMFaQ&c=lI8Zb6TzM3d1tX4iEu7bpg&r=mrdb0sJ2hUH3eEEWeeCP8cqFBqetUTKLLh6bJ9SkIXk&m=3CSOrdaFS6bOjB6Z2ny91AoUafvLxgDDWdRF7LdSnHs&s=f0qW8M-2FQEuV_78yb3MYOb5b2EDm7dOhHOac23cAHE&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AE-2Db-5FjJOTkScIdfm5Qjf8rDjMrdPWBWGks5sM-5FDQgaJpZM4OUtGr&d=DwMFaQ&c=lI8Zb6TzM3d1tX4iEu7bpg&r=mrdb0sJ2hUH3eEEWeeCP8cqFBqetUTKLLh6bJ9SkIXk&m=3CSOrdaFS6bOjB6Z2ny91AoUafvLxgDDWdRF7LdSnHs&s=rLBOdCcYL69mXM91PdBz-qnRmjTyEwQITAXro1q--vA&e=.

The minimum version doesn't impact which SDK is used to build. All it should control is the value that ends up in the AppX manifest in the <OSMinVersion> element.
I have noticed VS 2017 has a quirk of only showing as possible options for the min version which Windows 10 SDK is installed, which I've noted is silly because the SDK isn't used at all for build--it's rather large for something that just provides a version number to a droplist. Still, I suppose there's something else in their validation that could be incorrectly tied to it as well. I'll see if my VM repro shows this issue...

Thanks! On clean hardware, I observed that  building the vanilla solution failed but changing the minversion to 15063 caused it to succeed. I retract my original statement about the build tools...they were not required.

From: Chuck Walbourn<EMAIL_ADDRESS>Sent: Jul 12, 2017 1:20 AM
To: Microsoft/Xbox-ATG-Samples
Cc: Engel, Nic B.; Author
Subject: Re: [Microsoft/Xbox-ATG-Samples] Prerequisites in readme.md - build tools 149 (#3)
The minimum version doesn't impact which SDK is used to build. All it should control is the value that ends up in the AppX manifest in the  element.
I have noticed VS 2017 has a quirk of only showing as possible options for the min version which Windows 10 SDK is installed, which I've noted is silly because the SDK isn't used at all for build--it's rather large for something that just provides a version number to a droplist. Still, I suppose there's something else in their validation that could be incorrectly tied to it as well. I'll see if my VM repro shows this issue...

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Microsoft_Xbox-2DATG-2DSamples_issues_3-23issuecomment-2D314691309&d=DwMFaQ&c=lI8Zb6TzM3d1tX4iEu7bpg&r=mrdb0sJ2hUH3eEEWeeCP8cqFBqetUTKLLh6bJ9SkIXk&m=L8bZoS3VaRiGLN_mUOzP6zE0EFvUr-gvJJrM9hDTkJ8&s=c-VrXIlZWowWYRX6VdvnQfJHyE6nvao1EySBvUggy0Q&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AE-2Db-5FtCHRag4X1DVmDbVVCKsxNk6TKlDks5sNIG7gaJpZM4OUtGr&d=DwMFaQ&c=lI8Zb6TzM3d1tX4iEu7bpg&r=mrdb0sJ2hUH3eEEWeeCP8cqFBqetUTKLLh6bJ9SkIXk&m=L8bZoS3VaRiGLN_mUOzP6zE0EFvUr-gvJJrM9hDTkJ8&s=-P6hN93hInyODOreP7rhU9YmwlNL5L6Ck2ndNxednds&e=.

I have left the min version in most of the samples as 14393 as that's a reasonable minimum. The spatial audio samples need 15063, which is why it appears only DirectXTK is set 'wrong'. I'll verify this behavior and write up at least two bugs for the Visual Studio team:

The minimum version should not be tied in any way to what SDK is installed since it's just metadata

The minimum version listed in a static library should probably be ignored

Makes sense. Thanks for the support!
Best,
-Nic B-
Sent from Ninehttp://www.9folders.com/ - Please pardon any typos

From: Chuck Walbourn<EMAIL_ADDRESS>Sent: Jul 12, 2017 1:34 AM
To: Microsoft/Xbox-ATG-Samples
Cc: Engel, Nic B.; Author
Subject: Re: [Microsoft/Xbox-ATG-Samples] Prerequisites in readme.md - build tools 149 (#3)
I have left the min version in most of the samples as 14393 as that's a reasonable minimum. The spatial audio samples need 15063, which is why it appears only DirectXTK is set 'wrong'. I'll verify this behavior and write up at least two bugs for the Visual Studio team:

The minimum version should not be tied in any way to what SDK is installed since it's just metadata

The minimum version listed in a static library should probably be ignored

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Microsoft_Xbox-2DATG-2DSamples_issues_3-23issuecomment-2D314694581&d=DwMFaQ&c=lI8Zb6TzM3d1tX4iEu7bpg&r=mrdb0sJ2hUH3eEEWeeCP8cqFBqetUTKLLh6bJ9SkIXk&m=1raq7DPWVJEEu4LU30xhmqGCNFvjM9MVsKFGEp2WrU8&s=0rnq10oSyzoonbEEUIgYa2d3jf5sBK5uuw94PbRVrcw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AE-2Db-5FqoV9CGdHr9BdHzhE5bqAvfE1z2fks5sNITzgaJpZM4OUtGr&d=DwMFaQ&c=lI8Zb6TzM3d1tX4iEu7bpg&r=mrdb0sJ2hUH3eEEWeeCP8cqFBqetUTKLLh6bJ9SkIXk&m=1raq7DPWVJEEu4LU30xhmqGCNFvjM9MVsKFGEp2WrU8&s=XuL43kMJ8aB-cSvvGYILZAXihzjdZWIza6gf1O1aI8g&e=.

I'm having this same issue. What's the solution? I have windows 10 15063 and Visual Studio Professional 2017. When I try to compile DirectXTK I get "the target "MarkupCompilePass1" does not exist in the project". I couldn't quite follow from the above whether there is a way for me to get past this... :)

I'm still working through the exact repro, but it sounds like you need to install the Universal Windows Platform apps workload (which includes the Windows 10 SDK 15063), the C++ tools for UWP apps optional component, and the Windows 10 SDK 14393 optional component to get it to build currently.

Super – based on the original thread I already tried installing extra build tools with no luck, but I’ll try what you suggest – Thanks!
-Amy
From: Chuck Walbourn<EMAIL_ADDRESS>Sent: Thursday, July 13, 2017 11:33 AM
To: Microsoft/Xbox-ATG-Samples<EMAIL_ADDRESS>Cc: Amy Karlson (Populus Group LLC<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/Xbox-ATG-Samples] Prerequisites in readme.md - build tools 149 (#3)
I'm still working through the exact repro, but it sounds like you need to install the Universal Windows Platform apps workload (which includes the Windows 10 SDK 15063), the C++ tools for UWP apps optional component, and the Windows 10 SDK 14393 optional component to get it to build currently.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FXbox-ATG-Samples%2Fissues%2F3%23issuecomment-315164192&data=02|01|v-amkarl%40microsoft.com|494ac2d14ca6454c898a08d4ca1d9975|72f988bf86f141af91ab2d7cd011db47|1|0|636355675857311584&sdata=cl6rLu2i67nZARzav8vM7HiMJfKMPO%2BQx9NbSbkF9LA%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZjvM71xqJtUKpczlofKXkUg3qdCV3UMks5sNmLdgaJpZM4OUtGr&data=02|01|v-amkarl%40microsoft.com|494ac2d14ca6454c898a08d4ca1d9975|72f988bf86f141af91ab2d7cd011db47|1|0|636355675857311584&sdata=Xi5XtAAyAIORAPfjz97oYkD2%2FmguvingbC0uG%2B0GOZw%3D&reserved=0.

I actually didn't need the 14393 SDK. I just needed to manually change the min version to 15063 in DirectXTK project properties.

Yes that is another workaround, but a number of samples are using 14393 as the minimum by design because the APIs in them are not strictly 15063 or later only.

Confirmed. Not great behavior, but at least I know what's happening :) Updated the readme.md.
Thanks!


refactor(apps): move rofi config to nix

#79  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zakuciael and the rest of your teammates on  Graphite


Only determine revision range when needed

Determining the changelog revision can fail, and it is not needed only if the user added the template.
This pull request modifies the behavior of getChangelog() so it only tries to determine the revisions if the changelogCommand contains the template.

Thanks @szdavid92, I've released this in v2.5.2.


Added lint config and presubmit script

This is consistent with (i.e. copied from) transparency-dev/merkle.

Codecov Report

Merging #5 (19eb922) into main (31840b7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           52        52
=========================================
  Hits            52        52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31840b7...19eb922. Read the comment docs.


Contract compilation debugging infrastructure

My overall take is that we should approach this from a different angle. I think we should look into making it possible to dump the serialized UniversalArtifact from a) RocksDB of nearcore, via state-viewer perhaps; or b) generate one from .wasm on the fly with near-vm-runner-standalone or similar.
This would then allow a whole swath of tools to be constructed that can deserialize the UniversalArtifact and dump all sorts of interesting information from it (a-la dumpelf(1)). We could also investigate a tool to convert these artifacts to elf so that the tooling that exists for ELFs can be reused directly (shouldn't be too hard to achieve via e.g. the object crate)

We can dump serialized artefact, and it makes lot of sense to make changes you suggest, but it's pretty hard to disassemble it to do in depth code quality analysis.

And to implement conversion tools we need API to access function length from artefacts + provide ability to store symbolic information.

Yeah, it does seem that we obviously want both:

high level tool which takes artifact and dumps it into some format interoperable with other tools, or just directly inspects it
low level API which tells where the functions are

Though, I'd probably avoid committing the code referring to specific files on Nikolay's hard-drive :-)

I think one of the important parts of my message became implicit. One of the adjustments I am suggesting is that we want to deal with UniversalArtifacts only. That is, the concrete implementation of the Artifact trait and not the trait object. I don't anticipate us implementing anything similar for the staticlib or dylib engines either way – and the function length information is readily available as part of the UniversalArtifact as a field.
So in practice doing something along the lines of UniversalArtifact::deserialize(engine, bytes).finished_function_lengths() would be a reasonably nice approach to obtain the information about functions in the disassembled code without modifying the Artifact trait.

Made it draft for now, as https://github.com/near/wasmer/pull/98 is better.

Since we landed the alternative implementation I'm going to close this for the time being.


Add Github Issue Template

Does what it says on the tin! If I missed anything, please let me know.  I tried to follow the issue submission guidelines as closely as possible.
For #969

I've updated the template per your suggestions!  I also remove the *Description* lines.  They didn't provide anything meaningful, so I added spaces instead.

Good changes. Let's merge this, then!


[Android] - When recording video on Android, set the recording time to 5 minutes or more, and return to the problem

Make sure you follow all of the setup directions before posting an issue: https://github.com/jamesmontemagno/MediaPlugin#important-permission-information
If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Version Number of Plugin: <IP_ADDRESS>
Device Tested On:HUAWEI P10, XIAOMI MI8, XIAOMI MI9
Simulator Tested On:
Version of VS: Visual Studio Community 2017 - 15.9.9
Version of Xamarin: <IP_ADDRESS>047
Versions of other things you are using:
Steps to reproduce the Behavior
Android: Click the button on the Android platform to call the TakeVideoAsync method.
Expected Behavior
Android: You should return directly to the program after recording the video.
Actual Behavior
Android: After the video is recorded, the Media Test interface appears. After more than 20 seconds, it will return to the program. The recording time is 5 minutes. If the recording time setting is short, this problem will not occur. Once the recording time reaches 4 minutes. Or after 5 minutes, this problem will occur when the recording is finished and returned.
And I also use this example program provided by you to have this problem.
Code
` private async Task<string> RecordVideoPlugin() {

        if (IsCrossMediaInit == true)
        {
            await DisplayAlert("Prompt", "The media is in use, please wait a little while.", "OK");
            return null;
        }
        try {

            IsCrossMediaInit = await CrossMedia.Current.Initialize();

        } catch (Exception e) {

            Log.WriteLine(e.Message + " ==== " + e.StackTrace);
        }

        if (!CrossMedia.Current.IsCameraAvailable || !CrossMedia.Current.IsTakeVideoSupported) {
            await DisplayAlert("No Camera", "No camera available.", "OK");
            return null;
        }

        var videoName = DateTime.Now.ToString("yyyy-MM-dd-HH:mm:ss");

        var file = await CrossMedia.Current.TakeVideoAsync(new StoreVideoOptions() {
            Quality = VideoQuality.Medium,
            CompressionQuality = 92,
            DesiredLength = TimeSpan.FromMinutes(5),
            DefaultCamera = CameraDevice.Front,
            Name = videoName + ".mp4"
        });

        if (file == null)
            return null;

        Log.WriteLine(file.Path);
        return file.Path;
}`

Screenshots

@jamesmontemagno Hi
Can you look at this? This problem will also appear in your sample program.

I looked at the source code, which is the problem caused by the method in the red box.