Rip Sun/Moon Data

Is there any plan to integrate Sun and Moon data in to the database anytime soon? / Is there an appropriate way for people to contribute to such an effort?

I haven't contributed to this project before, but I'm willing to help out. I'll start things off with some info and questions.
It looks like this pk3DS tool has seen some active development lately for Gen 7. https://github.com/kwsch/pk3DS
Was this tool used in the past? Is it worth collaborating or talking to the developer?
What is considered a legitimate source for data? I haven't had much luck in getting homebrew running on my 3DS for dumping an image of Sun/Moon and decrypting it. There seem to be a handful of ROMs available for download around the internet, but I doubt this is legally legitimate and I question the safety (from viruses, etc.) of doing so.
What is the status of the 'scripts' directory in this repository? I read the description of them being one-shot scripts, but would they still be useful as examples or starting points?
I'm glad to help out in any way that I can!

I would love if more people could help, but this is low-level finnicky/tedious work and I have no idea how to convey all the necessary context.  :)  Maybe hop in IRC if you really want to give it a shot — irc://irc.veekun.com/veekun
The only legitimate source is the game itself, yes.
Part of our problem is that several people did all the datamining for previous games with a ton of messy ad-hoc scripts, most of which are now lost, many of which (such as the stuff in scripts) don't make much sense in isolation.  Having everything blended together in one database doesn't help much, either; even once you have the data, cramming it into SQL alongside fifteen other games' data can be a pain.
I'm currently writing a repeatable set of extractors — that work is on the yaml branch, in pokedex.extract.*.  The idea is to eventually rerip everything to independent YAML files, but for now I'm just trying to get Sun and Moon into YAML and then separately convert that to SQL.
I don't think pk3DS does anything we don't know about already, but I'll give it a look.

@eevee While there isn't a more reliable way to get the data directly ripped from the games, there may be no other choice than add the data manually...
The problem with YAML is that won't perform well on large datasets, because you cannot read it line by line to get the full "item/row" of information.
To leverage the process of going through all CSV files, I've created a backend/admin project that imports the CSV files into SQLite and exports them back to CSV once you've finished editing with the admin UI.
Initially I meant to use it as a tool to migrate from your data structure to a brand new and more efficient one (where you could do things like sort pokemon by stat more easily), but I ditched the idea since it was consuming me a lot of time (it needs to be well rethought).
Here it is, in case you may find it interesting: https://github.com/metaunicorn/pokedata-backend. All instructions come in the readme. In case you need more help, just tweet me: @metaunicorn.
One handycap/feature is that the exporter will add IDs to all tables and will quote all the strings/sentences that have spaces.

Good news!  As of the most recent commit, we now have Sun/Moon items, abilities, moves, and Pokémon.  Minus some exceptions, which I'm working on.

There are some obvious omissions (encounters...), but that's always the case, and this ticket wasn't specific...  so since Sun and Moon are now actually on the goddamn website, I'm calling this done.


[backport] Add random for uniform [0, 1) generation

Backport of #4906

Jenkins CI test (for commit 694db5315270ee5bfbc9db7e69508d75d701bf32, target branch v9) succeeded!


Add Simple & Easy rebuildPatch scripts

bash PatchServer.sh (PatchName)
bash PatchAPI.sh (PatchName)


perf(semantic): reduce lookups

Small performance optimization (I hope) to resolving references in Semantic. Look up current bindings once rather than on every turn of the loop.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4214  👈
#4213
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

No difference on benchmarks, so closing.

Actually, I changed my mind. Even if it makes little/no difference in this case, it's probably a better code style.

Just for the record, this PR did not produce a 6% speed-up. It produced no speed up. CodSpeed has done the comparison to 2 commits back, rather than 1. So result shown above includes the perf boost of #4213 which preceded this.


Abort a dialog

Sometimes, I ask the user a question, but then something happens and that question becomes obsolete before it got answered. I don't think dialoguer can handle this yet(?), since the interact method is blocking.

Yup.

Well, consider this a feature request then.

I would consider it as out of scope for this project. I would recommend you to play with much more lower level libraries.


[FEATURE]

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
How to use GPT-4o-Mini, tried adding the model in backend but it does not appear on UI
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Solved the issue by adding Model in llm.py
        "OPENAI": [
            ("GPT-4o", "gpt-4o"),
            ("GPT-4o-Mini", "gpt-4o-mini"),
            ("GPT-4 Turbo", "gpt-4-turbo"),
            ("GPT-3.5 Turbo", "gpt-3.5-turbo-0125"),
        ],


ErrorResponseException constructor is not public

We are currently building a Kotlin service which uses this sinch java package.
We are trying to try catch the exception ErrorResponseException, however, since the constructor access is not given, and by default it is private, our Kotlin service could not access this exception with error:
Cannot access '<init>': it is package-private in 'ErrorResponseException'
Can we update the constructor for this exception to be public?

Our tests shows that Kotlin can catch this exception without any issue (as it is compiled to byte code same as java).
Could you provide the failing code that you have?


Spot Numbers not Incrementing

From David Martin: For my field testing, I set up my starting number for SPOTs to my last GSWA number (1074) in the hope that it would continue incrementing. However, StraboSpot just added the numeral “1” to each successive site (see attachment), until I deleted the starting number from the naming conventions (then it incremented OK, starting from 1)

I cannot recreate this issue.
Maybe this could happen if there is a non-numeric character in the field for the starting number in which case the app would not be able to "add" 1 and would append 1 to the end. But the field doesn't let a user enter a non-numeric character.
We need to figure out how to recreate this.

I'm still not sure how this happens but it happened to me as well. Somehow the integer was turned into a string. This commit turns it back to an integer. Hopefully that fixes it.
Commit ec0e5eb5414a4922feb497f4ed776130a91bc6e1


glClearTex(Sub)?Image operations in GL do not consider half-float fill data formats.

Description
The glClearTexImage and glClearTexSubImage commands within RenderDoc do not handle GL_HALF_FLOAT as a data type format for the constant fill pixel value given by pointer to the commands. The handling code within RenderDoc thus only copies the least-significant byte of the fill value (treating it as a byte, rather than two bytes).

Steps to reproduce
u16 clear_data = 0xAABB;
glClearTexImage(texture, 0, GL_RED, GL_HALF_FLOAT, &clear_data);

Here we just write the constant pattern 0xAABB as a half-float, i.e: -0.0526 into texture. RenderDoc will only write and see 0xBB for the underlying half-float texture.
The functions here:
https://github.com/baldurk/renderdoc/blob/v1.x/renderdoc/driver/gl/wrappers/gl_draw_funcs.cpp#L4590
https://github.com/baldurk/renderdoc/blob/v1.x/renderdoc/driver/gl/wrappers/gl_draw_funcs.cpp#L4590
Do not not handle type of GL_HALF_FLOAT, as a result s stays 1 and memcpy only copies the least-significant byte of the fill value.
It should be noted that GL_UNSIGNED_SHORT works, however glClearTexImage and glClearTexSubImage are defined to convert the data given by fill to the underlying texture format when the types aren't the same. This means there's no way to specify a half-float value as an unsigned short and clear the texture with it since that value will be converted to half-float instead.

Environment

RenderDoc version: Multiple
Operating System: Windows 10, Windows 11, and ArchLinux
Graphics API: OpenGL 4.5 and OpenGL 4.6 (Core Profile)

That commit should add in the necessary handling, treating it similarly as a 2-byte value.


Polymorphic JSON merge patch models may cause properties to be included in update when deserializing

While regenerating an SDK to use stream-style serialization I found that polymorphic properties aren't being handled correctly during deserialization if they support JSON merge patch.
The current design of JSON stream-style deserialization uses the model setter if the property is defined by a super type. JSON merge patch uses the setter to determine if a property should be included in serialization when the model is used in a patch operation. These together result in the parent properties always being included in serialization, and possibly in an incorrect way if the value is null and something else sets it in-between deserialization and using the model in a patch operation.
Code sample
public class Parent {
  private String property;

  public Parent setProperty(String property) {
    this.property = property;
    // Track property for patch serialization
    return this;
  }
}

public class Child extends Parent {
  public Child setProperty(String property) {
    super.setProperty(property);
    // Track property for patch serialization
    return this;
  }

  public static Child fromJson(JsonReader jsonReader) throws IOException {
    // logic
    if ("property".equals(fieldName) {
      childInstance.setProperty(jsonReader.getString());
    }
    // logic
  }
}

Solutions
At this time there are two solutions I can think of:

The models within the polymorphic hierarchy have internal setters that don't track the property's inclusion into patch serialization.
The parent model defines the property as package-private and all children models change deserialization to set the property directly.

My preference is for option #2 as option #1 would require each child model within the hierarchy to add an internal setter as well. Additionally, option #2 can be used universally, even when the model isn't used in JSON merge patch operations and would allow for the removal of calls like:
public String getProperty() {
  return super.getProperty();
}

public Type setProperty(String property) {
  super.setProperty(property);
  return this;
}

and allow for direct access to the field:
public String getProperty() {
  return property;
}

public Type setProperty(String property) {
  this.property = property;
  return this;
}

Thanks @alzimmermsft for raising this. Do you mean using deserialized model to do patch operation could lead to problem? Is it similar as this one: https://github.com/Azure/autorest.java/pull/2576#issuecomment-1966144039
For this issue, we previously discussed with @srnagar, and we decided to ignore it first as we assume we do not use deserialized model to do patch. But this can be discussed furthur.

We'd expect user do this with a new class (and only set the property that to be modified -- the right way to do a json-merge-patch on a resource)
client.patch(name, new Child().setProperty(newValue);

instead of
Child child = client.getByName(name);
child.setProperty(newValue);
client.patch(name, child);

However, user may confuse about it (with none json-merge-patch).
And it is possible that user uses a model that nested in the resource. e,g,
Child child = client.getByName(name);
Property prop = child.getProperty();
client.patch(name2, new Child().setProperty(prop));

Then the updatedProperties in Property class could carry-over to the new Child class.

Thanks @alzimmermsft for raising this. Do you mean using deserialized model to do patch operation could lead to problem? Is it similar as this one: #2576 (comment) For this issue, we previously discussed with @srnagar, and we decided to ignore it first as we assume users do not use deserialized model to do patch. But this can be discussed furthur.

Yeah, this is that comment, I also talked with @srnagar yesterday about it as I didn't realize this was discussed before.

We'd expect user do this with a new class (and only set the property that to be modified -- the right way to do a json-merge-patch on a resource)
client.patch(name, new Child().setProperty(newValue);

instead of
Child child = client.getByName(name);
child.setProperty(newValue);
client.patch(name, child);

However, user may confuse about it (for instance, when the lib is used with other libs that only support PUT to update or simple PATCH).
And it is possible that user use a de-serialized model that nested in the resource. e,g,
Child child = client.getByName(name);
Property prop = child.getProperty();
client.patch(name2, new Child().setProperty(prop));

Then the updatedProperties in Property class could carry-over to the new Child class.

I think we should fully support both newed up instances for patching and roundtripping scenarios as if only newing up is supported this may result in a lot of confusion. For example, though the service doesn't support it the idea is generalizable, Storage has metadata on Blobs and you may have data like last-change which is a date and if it's older than a certain threshold you had a will-delete-on value, such as rotating logs stored in Storage.

We'd expect user do this with a new class (and only set the property that to be modified -- the right way to do a json-merge-patch on a resource)
client.patch(name, new Child().setProperty(newValue);

instead of
Child child = client.getByName(name);
child.setProperty(newValue);
client.patch(name, child);

However, user may confuse about it (for instance, when the lib is used with other libs that only support PUT to update or simple PATCH).
And it is possible that user use a de-serialized model that nested in the resource. e,g,
Child child = client.getByName(name);
Property prop = child.getProperty();
client.patch(name2, new Child().setProperty(prop));

Then the updatedProperties in Property class could carry-over to the new Child class.

I think we should fully support both newed up instances for patching and roundtripping scenarios as if only newing up is supported this may result in a lot of confusion. For example, though the service doesn't support it the idea is generalizable, Storage has metadata on Blobs and you may have data like last-change which is a date and if it's older than a certain threshold you had a will-delete-on value, such as rotating logs stored in Storage. Overall, the idea is there are likely scenarios where the service value will need inspection before the patching can be done and forcing a path where a new model needs to be newed up is a bit confusing:

One point is that there maybe intrinsic ambiguity on "what is intended by user".
e.g. in below, user likely only want to modify "property", as they get and update on same resource. On this, user would want to send a json-merge-patch with only one property.
Child child = client.getByName(name);
child.setProperty(newValue);
client.createOrUpdate(name, child);

But here
Child child = client.getByName(name);
child.setProperty(newValue);  // with or without this line
client.createOrUpdate(newName, child);  // via json-merge-patch

user likely want to keep every property in "name" resource and copy it to a new resource. And here user would want to send a json-merge-patch with all properties existed in "name" resource.


Crawl static site to find new pages

Mode
Page screenshots
Feature description
I'm trying out lost pixel, coming from Percy snapshots.  I'm trying to find a way to automatically snapshot all pages, including newly-added pages, without having to update a configuration array in lostpixel.config.ts.  Is that possible?  If not, how do people usually manage the workflow?  Do they always just try to remember to add new pages to the config?
Or, is there a way to automatically find and snapshot all pages?  If not, is this a feature you'd consider adding?  Otherwise, I'm not sure how useful this tool will be to me.

Hey Ian! You can construct pages dynamically and process in lost pixel or you can even point lost pixel to a json array of pages that lives separately in the application.
are you able to construct the list of pages yourself? If the answer is yes you can integrate pretty easily with lost pixel.
I also like the Sitemap approach that would make it semiautomatic, check this out please:
https://www.lost-pixel.com/blog/simplifying-next-js-visual-regression-testing

Ah perfect, I'll give the sitemap approach a whirl.  Appreciate it!

Would love to help with any questions! Feel free to ping anytime and good luck playing with Sitemaps and lost pixel 🙌🏼

Cool that you figured it out 🙌🏼 I think it's a misconfig on our side not to allow pages as undefined when you provide them via external json. Also good catch on the side of the versioning and our templates, will update that!


chore(FieldTheory/Galois): Move infinite Galois

Split the original file FieldTheory.Galois.Infinite into GaloisClosure and Profinite, for spliting the basic constructions, profinite (stated categorically), and the fundamental theorem completely.
Moves:

Mathlib.FieldTheory.Galois.Infinite -> Mathlib.FieldTheory.Galois.GaloisClosure
Mathlib.FieldTheory.Galois.Infinite -> Mathlib.FieldTheory.Galois.Profinite

bors merge


Updates for Documenter.jl syntax changes

See https://github.com/MichaelHatherly/Documenter.jl/pull/51 for details.
(Sorry about the trailing whitespace stripping, I can revert that bit in needed.)

Coverage remained the same at 92.727% when pulling cb314820c6c81d94030eb1779f3cfeda76536ec6 on MichaelHatherly:mh/doc-syntax-updates into d4f7e6f677c12adad50e268b24f8ce26ff5ed89c on tshort:master.

 Thanks for the PR!


Repository invalid

After trying to add the repository I get an invalid repository error. I added it based on the README:

I did not try it inside https://hacs.xyz/

Hi @akosbalogh ,
fglair_for_homeassistant is NOT an add-on.
Please read accordingly the README: https://github.com/bigmoby/fglair_for_homeassistant#hacs


tried to solve extra line issue in lakeFS/docs/deploy/k8s.md

I tried to resolve the docs/deploy/k8s.md file and solve issue #2622

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Display ticket severity

Questions

Do we need to be concerned about the scenario where ticket.data is null? This change accounts for that but it may be redundant.
Given that this change is small and we're about to redo layout, is this change acceptable without tests at this time? Or is the presence of branching logic sufficient to justify a test?

Summary

We previously tried to display severity but were accessing it at the wrong place. This fixes the issue by accessing the severity in the ticket.data object and handles situations where the ticket doesn't have a severity property.
I spoke with Alberto about color coding... that is not in scope for this item

What it looks like

Yes, null data can happen when the ticketing connector fails or when there's no ticket with the ID we're looking for.
We should be fine to merge this without tests because there are no tests for IncidentSummary yet. Writing those tests would be useful, but doesn't need to be part of this pull.

Codecov Report

Merging #129 into master will increase coverage by 0.86%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   60.09%   60.96%   +0.86%
==========================================
  Files          94       94
  Lines        1411     1414       +3
==========================================
+ Hits          848      862      +14
+ Misses        563      552      -11

Impacted Files
Coverage Δ

src/components/Incident/IncidentSummary.js
0% <0%> (ø)
:arrow_up:

src/components/TopNav/Preferences.js
66.66% <0%> (ø)
:arrow_up:

src/components/TopNav/NavMenu.js
86.66% <0%> (ø)
:arrow_up:

src/components/elements/MenuLink.js
80% <0%> (ø)
:arrow_up:

src/actions/actionHelpers.js
80% <0%> (+5.71%)
:arrow_up:

src/components/Search/CreateIncident.js
88.88% <0%> (+22.22%)
:arrow_up:

src/components/Timeline/EventFilter.js
42.1% <0%> (+42.1%)
:arrow_up:

src/components/elements/IconButtonStyled.js
66.66% <0%> (+66.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3230158...2a2935a. Read the comment docs.

Coverage increased (+0.5%) to 56.933% when pulling 2a2935a5e1d4f7f49634f3163cc3379dc6c11488 on danieljurek:features/display-severity into 32301581b9c897dcbba92559919168ab7268765a on Azure:master.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/71519

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/81287

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/88228

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/89638

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92117

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/95347

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/107850

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116444


Feature request - drill down to the minute instead of five minute intervals

Is it possible to drill down to the minute instead of being limited to five minute increments? In other words, have a minutes grid that shows all (0-59).  I dont see any way to do it with options.

I figured this out. The feature is there. I just needed to add minuteStep:1 to my Javascript tag for that ID.(dpt).
 <%= javascript_tag do %>

              $(function(){
              $('#dpt').fdatepicker({
              format: 'mm-dd-yyyy hh:ii',
              disableDblClickSelection: true,
              pickTime: true,
              minuteStep: 1
              });
              });
  <% end %>

I'm not sure if the options are documented anywhere else, but you can see the available options in foundation-datepicker.js in lines (approximately) 17 through 187.


Fix SubsetStack copy ctor and dtor memory error

Playing around with xval's knn unit test I got segfaults on Subset deallocation, there seems to be two issues:

DenseFeatures  calls m_subset_stack->remove_all_subsets() two times, in free_features() and in free_feature_matrix() that is called from the former;

SubsetStack's copy ctor doesn't ref m_active_subset, but I'm a bit confused about this since every subset is refd by (CSubset*)other.m_active_subsets_stack->get_element(i);, so on the contrary I'd expect some memleak...

To reproduce it: https://gist.github.com/micmn/59a41d97d5415b4206eaabf616d26f20
@karlnapf

found it :) there was also a double SG_UNREF(m_active_subset)

is there a reason for not having SG_UNREF(x) = x->unref(); x = null;?

yes, probably :)


Downgrade "Flushing ..." log messages to SEV_DEBUG

Yeah I'll open a PR in a moment. Hopefully it won't be too contentious

here's the upstream PR https://github.com/falcosecurity/libs/pull/2072


TypeError: connection.createChannel(...).then is not a function

Getting this for callback api of amqplib

Can you see if you can find a test that should break?

You are using the channel model everywhere in your test units, at the same time I can see an example for callback model on your module's page. Just try use exactly callback api of amqplib while creating connection to see the error message above.
See line 72 in your /lib/request.js
A connection that created with callback api does not contain function 'then', but no any way to create a new channel which is applicable for callback api of amqplib in this script.
Could you split your code into two separate script implementing callback and promises api as it is done in amqplib?

You can use the following code to test the issue:
var amqplib    = require('amqplib/callback_api');
var amqprpc    = require('amqplib-rpc');
var sync       = require('synchronize');
sync(amqplib, 'connect');
sync(amqprpc, 'request');
var request = amqprpc.request;
var message = {a:5, b:4};
var config = {
hostname: '<IP_ADDRESS>',
port: 5672,
username: 'utest',
password: 'upass'
};
var conn, reply;
sync.fiber( function() {
try {
    conn = amqplib.connect(config);
    reply = request(conn, 'multiply-queue', message, { timeout: 30000 });
    console.log('rpc reply:', reply);
    conn.close();
} catch (error) {
console.log('rpc call error:', error);
if (conn) {
    conn.close();
};
};

});

One last question, what version of amqplib are you using?
On Mon, Mar 20, 2017 at 5:13 AM lukinsv<EMAIL_ADDRESS>wrote:

You can use the following code to test the issue:
var amqplib = require('amqplib/callback_api');
var amqprpc = require('amqplib-rpc');
var sync = require('synchronize');
sync(amqplib, 'connect');
sync(amqprpc, 'request');
var request = amqprpc.request;
var message = {a:5, b:4};
var config = {
hostname: '<IP_ADDRESS>',
port: 5672,
username: 'utest',
password: 'upass'
};
var conn, reply;
sync.fiber( function() {
try {
conn = amqplib.connect(config);
reply = request(conn, 'multiply-queue', message, { timeout: 30000 });
console.log('rpc reply:', reply);
conn.close();
} catch (error) {
console.log('rpc call error:', error);
if (conn) {
conn.close();
};
};
});
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tjmehta/amqplib-rpc/issues/16#issuecomment-287742406,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnFF9HBPzRCIe-Sv2Q6cYEmr_iV02GWks5rnm1hgaJpZM4Mh8Mn
.

The latest one - 2.0.4

oh, amqplib - 0.5.1

You may want to try a later version of amqplib in the meanwhile if it's
possible. I have a feeling that may be causing the issue.
On Mon, Mar 20, 2017 at 10:09 AM lukinsv<EMAIL_ADDRESS>wrote:

oh, amqplib - 0.5.1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tjmehta/amqplib-rpc/issues/16#issuecomment-287829108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnFFz47m-euKeAIC8b4iNV5m24y_j-1ks5rnrLbgaJpZM4Mh8Mn
.

This is the latest version in it's repo https://github.com/squaremo/amqp.node

The issue is you are creating a new channel with 'channel' connection version, which uses promises
line72: var promise = connection.createChannel().then(function (channel) {
The 'callback' version of 'connection' has no 'then' function. So, you have to completely rework the 'response' module to support the callback version of amqplib.connection object.

Gotcha, I have a min to check this out right now. Taking a look.

@lukinsv I fixed this in #17, let me know that branch works for you.
Thanks!


wrong icon for play/pause action

The icon for the play part of this action is actually used for "next track" anywhere else. Play is only a triangular...

Fixed in #6


Create ember-try auth0 scenarios

Just my thoughts:
is it feasible to switch from bower to npm packages and use greenkeeper to create pull request, and have build on travis for each version bump?

Yeah I've been thinking about that. I just read this https://simplabs.com/blog/2017/02/13/npm-libs-in-ember-cli.html


OCAS with EMS E3 license alone is not supporting OCAS URL - proxy replacement.

OCAS with EMS E3 license alone is not supporting OCAS URL - proxy replacement, Either EMS E3 bundled with MCAS or EMS E5 requires for this feature.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76a66643-56f5-dc00-5af6-3ee1d9b6f090
Version Independent ID: c319c4a4-974e-7e3a-d58a-76fd57a9efe9
Content: Differences between Cloud App Security and Office 365 Cloud App Security
Content Source: CloudAppSecurityDocs/editions-cloud-app-security-o365.md
Service: cloud-app-security
Product: ****
Technology: ****
GitHub Login: @shsagir
Microsoft Alias: shsagir

@Balamurugan-dot  Correct, this information is available in the Microsoft Cloud App Security licensing datasheet mentioned at the top of the topic. Thanks for your inquiry.


Why mobileNet.predict() hit a performance cliff after certain amount of runs?

TensorFlow.js version: 0.6.0
TensorFlow.js Core version: 0.6.0
Browser version: Chrome 65.0.3325.181 (Official Build) (64-bit)
Describe the problem or feature request
mobileNet.predict() hit a performance cliff after certain amount of runs.
On my MacBook Pro, the average of 100 runs is ~11ms, while the average of 200 runs drops to ~46ms. Similar issue happened on my Android device. I wonder what caused the performance drop? Anyway to avoid it? Thanks.
Code to reproduce the bug / link to feature request:
Change tfjs-converter/demo/index.js cat.onload() code to call mobileNet.predict() multiple times in a loop:
console.time('Subsequent predictions');
for (let i = 0; i < 200; i++) {
result = mobileNet.predict(pixels);
}
console.timeEnd('Subsequent prediction');

Try await tf.nextFrame() between each tick (you may have to wrap your code in a function marked as async).
async function run() {
  console.time('Subsequent predictions');
  for (let i = 0; i < 200; i++) {
    result = mobileNet.predict(pixels);
    await tf.nextFrame();
  }
  console.timeEnd('Subsequent prediction');
}
run();

This issue was moved to tensorflow/tfjs#145


Manual Assessment:  Errors while drag and drop the points.

Describe the bug
In some submissions, the assessment works as expected but in others the points are not being updated when I drag and drop the points.
To Reproduce

Go to exercise dashboard of a modeling exercise
Drag and drop the grades
Verify you get the same errors in the console and the points are not being updated. (see the screenshot)

Expected behavior
The assessment should work as usual.
Screenshots

Which version of Artemis are you seeing the problem on?
6.1.5
What browsers are you seeing the problem on?
Chrome
Additional context
No response
Relevant log output
No response

https://user-images.githubusercontent.com/88991954/236146815-bc947d7b-d888-4597-a39a-c102af1a2d02.mov

I don't have this problem anymore, works like a charm :)
@Santia-go if it's also working for you, you might consider closing this issue.


[Feature]:  Support loglevel in rsbuild

What problem does this feature solve?
We can custom loglevel in rsbuild and configure different level in different instance.
What does the proposed API look like?
maybe dev.loglevel, output.loglevel.

Try this:
import { logger } from '@rsbuild/core';

logger.level = 'xxx';

https://rsbuild.dev/api/javascript-api/core#logger
https://github.com/rspack-contrib/rslog?tab=readme-ov-file#log-level

The above method will affect all instances. We may need to provide a way to configure logLevel for different instances.

I want that instance is independent, for example, I have created two rsbuild instance, if use
import { logger } from '@rsbuild/core';

logger.level = 'xxx';

The another will be influenced also.

The above method will affect all instances. We may need to provide a way to configure logLevel for different instances.

Yes, you are right.

This may be difficult to achieve because the code in Rsbuild does not get the logger from the Rsbuild instance, but directly imports the logger module.


Update generated code to Swift 2

Primarily using guard instead of the current if with early return.

See https://github.com/tomlokhorst/swift-json-gen/pull/7 for further discussion.


Eval line in tutorial does not work if the shell is bash

This line:

microvium --eval "console.log('Hello, World!')"

Causes problems because the ! is inside double quotes and so is subject to shell script parsing.  The ! token instructs the shell to evaluate the last command matching the pattern ') and so you will get a surprising shell error when you run this.  Flipping the quotes works fine:
$ microvium --eval 'console.log("Hello, World!")'
Hello, World!
Output generated: script.mvm-bc
72 bytes
$ microvium --eval "console.log('Hello, World!')"
bash: !': event not found

Thank you!


Weighted Optimization

There are two reasons we perform weighted optimization

we receive weights from the selector (manual prioritization)

a downsampling strategy outputs weights (e.g. loss/gradnorm)

However I think right now some things in the weight handling are a bit weird:
a) If we receive weights from the selector and then do downsampling, we loose the weights
b) We do the following logic:
        weighted_optimization = (
            retrieve_weights_from_dataloader or self._downsampling_mode == DownsamplingMode.BATCH_THEN_SAMPLE
        )

and I don't know why we do this. First, do we never use weighted optimization in StB? Second, why do we always use weights in BtS? I think whether we should perform weighted optimization is a property of the downsampling startegy (if we don't receive weights from the selector). If we don't receive weights from the selector and e.g. use RHO-LOSS, we should not use weighted optimization. While we set the weights to 1 currently, we use the noreduction loss function, which I think can have performance implications for training with downsampling. I think we should do the following:

if we receive weights from selector and use no downsampling, use weights from selector
if we don't receive weights from selector and use no downsampling OR a downsampling strategy that does not output weights (we probably need to add a flag), use no weighted optimization
if we don't receive weights from selector and use downsampling that outputs weights (e.g. loss/gradnorm), use donwmsapling weights in both StB and BtS
if we receive weights from selector and use downsamplers that outputs weights, not sure. either we use one of the weights or we multiply them.

right now the weight handling is using the expensive no reduction thing even if it's not necessary, I think

@XianzheMa maybe, at your convienence, you could check this out, since it may have downsampling performance implications :) thank you! but not highest priority of course


dsn_patch1 (comments)

IMPORTANT:
We should do the branch naming scheme as "dsn_patch" followed by a number (like dsn_patch1) for only changes to dsn_class, dsn_levels and main. We should follow this naming scheme even if only 1 file out of the 3 is changed to keep it consistent. Also keep in mind that the version numbers are still in the commit names for each file respectively.
I'll work on adding the previous update names in updates.txt, then indicate a switch in naming schemes.
=====
Otherwise, this update is just adding comments to each line/block of code. Hopefully, you are able to study and interpret what each part does and how it contributes to the whole game. Feel free to let me know if you have any questions 👍 .

we haven't updated that updates.txt in so long, guess I'll try and do that for today

we haven't updated that updates.txt in so long, guess I'll try and do that for today

well, that was a f*cking lie


Black background on iframes (graphics, search) in dark mode

On Chrome 94 all elements embedded in iframes (e.g. dependency graphs, search results) do sometimes have a black background:

How to reproduce

Make sure the system does not have dark-mode enabled
Go to a page in the example docs containing a dependency graph (e.g. here)
Enable dark mode by clicking the ☀-Button
the background of the graphs should be fine:

refresh the page
now the iframe-background is not transparent any more and it will stay black on all iframes. 😲

I can  reproduce this on  Chrome 94 on macOS and on Chrome for Android. Other supported browser don't seem to be affected. I don't know when this started to be a problem and I don't know what the reason might be.
Given the fact that it is not consistent (it only starts to be a problem after a page refresh or if the page is loaded in dark mode) even let's me consider that this might be a bug in Chrome?
If you want to help, pls let me know if you can reproduce the issue or if you have an idea what is going on... 🤔

I can reproduce this. Chrome 94.0.4606.81 on Windows using the link in your comment. Disabling the color-scheme: dark property seems to fix it? E.g.:
iframe {
    color-scheme: normal;
}

Although I'm just testing in the page inspector and a page refresh may show the issue again.
I found this article which has some insights about iframes and transparency bugginess in Chrome. It may explain what's going on.

I can confirm that this fixes the problem! Thank you so much, I'd never would have found this!
This will be included in the upcoming 1.6.1 patch release: https://github.com/jothepro/doxygen-awesome-css/commit/c52f8129d0c8f21d5f4d9d099a3e158f98483dbe


ERROR - Navigation error: the JSON object must be str, bytes or bytearray, not NoneType

Describe the bug
When attempting to log the LLM output using the Llama3 model locally, I encounter the following error: ERROR - Navigation error: the JSON object must be str, bytes or bytearray, not NoneType. The logged output appears as shown in the screenshot.

Expected behavior
I expected the output to be correctly logged, similar to the results obtained when testing with the Gemini model, without encountering the JSON object error.

Llama 3 might not perform well enough and the extraction pipeline might fail. It also might happen because ollama quantizes things and the output is a bit random.
Could you try with Groq?

i tried with Groq and after some prompt adjustments it worked ! thank u ! i was using llama 3 8B and when i tested with Groq i used Llama 3 70B , could it be one of the reasons ?

Yes, Llama 3 70b is much better than 8b version. We did some testing and could observe that:

You can find more on our blog article on our Web Agent evaluation.


Fix Style/AccessorMethodName

Details

Rubocop says don't use things like set before write methods. A writer method's behavior should be implied/known.

Motivation and Context
Working to help solve issue 1021!
How Has This Been Tested?
bundle exec rake :+1:
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Rubocop style fixes

@brasmusson As I've been going through and updating my current PRs, I've been moving the changelog entries to the Improved section. That work for you? :)


Cursor drifts when mouse is captured if window width or height are odd

#602 related. Observable on maximizing or toggling fullscreen

Fixed in #651
Values offset when window size changes while capturing (eg. fullscreen), should probably reset __mouse_capture_frame on resize (as per __input_transform_coordinate)

Fix is rounding old x/y since OS cursor position is always an integer.
Found a couple more issues debugging this with @tabularelf

Still drifts if GUI larger than window (eg. default room size larger than resolution)
The lock obviously needs to be dropped if the window exits the display area
__input_release_multimonitor_cursor uses incorrect values and is not performant (needs rework)


node_dependencies unable to resolve a function called _is_owner

Not sure why, but moving fn _is_owner to _beforetheimpl` block fixes this. @Braqzen ran into this so it's a higher priority bug.
contract;

use std::{address::Address, assert::assert, chain::{auth::{AuthError, Sender, msg_sender}, log_b256}, context::call_frames::contract_id, contract_id::ContractId, hash::{HashMethod, hash_pair, hash_u64, hash_value}, panic::panic, result::*, storage::{get, store}};

abi MultiSignatureWallet {
    fn constructor(owner1: Address, owner2: Address) -> bool;
    fn submitTransaction(tx_hash: b256) -> bool;
    fn approveTransaction(tx_hash: b256) -> bool;
    fn revokeTransaction(tx_hash: b256) -> bool;
    fn executeTransaction(tx_hash: b256) -> bool;
    fn is_owner(owner: Address) -> bool;
    fn has_approved(tx_hash: b256, owner: Address) -> bool;
    fn get_transaction_hash(to: ContractId, value: u64, data: b256, nonce: u64) -> b256;
    fn get_transaction_data(tx_hash: b256) -> (u64, bool);
}

/// Assertion used to ensure that the value stored for the owner is true i.e. they are an owner in the contract
fn _is_owner(state: bool) {
    assert(state);
}

storage {
    /// The state is used as a gatekeeper for unlocking functionality post initialization
    state: u64,
    /// The sentinel is used as a dummy value to store under a newly submitted tx hash
    /// so that we can
    ///     - use the tx in other functions
    ///     - prevent a resubmission of the same tx
    tx_sentinel: u64,
}

/// TODO: proper documentation instead of temporary filler comments

impl MultiSignatureWallet for Contract {
    /// Initializes the contract by setting the owners, state and a sentinel value for the tx
    fn constructor(owner1: Address, owner2: Address) -> bool {
        assert(storage.state == 0);

        // TODO: when vectors are implemented change owners to be a Vec<Address>
        store(owner1.value, true);
        store(owner2.value, true);

        storage.state = 1;
        storage.tx_sentinel = 1;
        true
    }

    /// Takes a transaction hash and stores in it storage
    fn submitTransaction(tx_hash: b256) -> bool {
        _is_initialized(storage.state);

        let sender: Result<Sender, AuthError> = msg_sender();
        if let Sender::Address(address) = sender.unwrap() {
            let status: bool = get(address.value);
            _is_owner(status);

            // When a Tx has not been submitted its default value should be 0.
            // Make sure we are not overwritting a previous Tx
            let tx_data: u64 = get(tx_hash);
            assert(tx_data == 0);

            // Mark the first submission as a non-zero value
            store(tx_hash, storage.tx_sentinel);
            log_b256(tx_hash);
        } else {
            panic(0);
        };

        true
    }

    /// Takes a transaction hash and changes the approval to true for the owner while incrementing the approval count
    fn approveTransaction(tx_hash: b256) -> bool {
        // TODO: signature authentication? ec_recover == signer(s)?
        _is_initialized(storage.state);

        let sender: Result<Sender, AuthError> = msg_sender();
        if let Sender::Address(address) = sender.unwrap() {
            _is_owner(get(address.value));

            let tx_data: u64 = get(tx_hash);
            _tx_exists(tx_data);

            let approval_hash = _owner_approval_hash(tx_hash, address);
            let approved: bool = get(approval_hash);

            assert(!approved);

            // TODO: Increment Tx approval if not executed then store it again

            store(approval_hash, true);
            log_b256(address.value);
        } else {
            panic(0);
        };

        true
    }

    /// Takes a transaction hash and changes the approval to false for the owner while decrementing the approval count
    fn revokeTransaction(tx_hash: b256) -> bool {
        // TODO: signature authentication? ec_recover == signer(s)?
        _is_initialized(storage.state);

        let sender: Result<Sender, AuthError> = msg_sender();
        if let Sender::Address(address) = sender.unwrap() {
            _is_owner(get(address.value));

            let tx_data: u64 = get(tx_hash);
            _tx_exists(tx_data);

            let approval_hash = _owner_approval_hash(tx_hash, address);
            let approved: bool = get(approval_hash);

            assert(approved);

            // TODO: Decrement Tx approval if not executed then store it again

            store(approval_hash, false);
            log_b256(address.value);
        } else {
            panic(0);
        };

        true
    }

    /// Takes a transaction hash and executes it if the approval hash reached past the threshold
    fn executeTransaction(tx_hash: b256) -> bool {
        _is_initialized(storage.state);

        let sender: Result<Sender, AuthError> = msg_sender();
        if let Sender::Address(address) = sender.unwrap() {
            let tx_data: u64 = get(tx_hash);
            _tx_exists(tx_data);

            // Check approval threshold and if not executed then execute, mark as executed

            log_b256(tx_hash);

            // TODO: execute
        } else {
            panic(0);
        };

        true
    }

    /// Returns a boolean value indicating if the given address is an owner in the contract
    fn is_owner(address: Address) -> bool {
        _is_initialized(storage.state);
        get(address.value)
    }

    /// Returns a boolean value indicating if the given address hash approved the specified transaction
    fn has_approved(tx_hash: b256, owner: Address) -> bool {
        _is_initialized(storage.state);
        let tx_data: u64 = get(tx_hash);
        _tx_exists(tx_data);
        get(_owner_approval_hash(tx_hash, owner))
    }

    ///
    fn get_transaction_hash(to: ContractId, value: u64, data: b256, nonce: u64) -> b256 {
        // TODO: data > b256?
        // TODO: this is probably not following the EIP-191 signing standard. What do?
        let to_hash = hash_value(to.value, HashMethod::Keccak256);
        let data_hash = hash_value(data, HashMethod::Keccak256);
        let value_hash = hash_u64(value, HashMethod::Keccak256);
        let nonce_hash = hash_u64(nonce, HashMethod::Keccak256);

        let id = contract_id();
        hash_pair(id.value, hash_pair(to_hash, hash_pair(value_hash, hash_pair(data_hash, nonce_hash, HashMethod::Keccak256), HashMethod::Keccak256), HashMethod::Keccak256), HashMethod::Keccak256)
    }

    /// Takes a transaction hash and returns the number of approvals and execution state
    fn get_transaction_data(tx_hash: b256) -> (u64, bool) {
        _is_initialized(storage.state);

        let tx_data: u64 = get(tx_hash);
        _tx_exists(tx_data);

        // TODO: extract the approval and execution values

        // return (current approval count, execution state)
        (1, true) // make the compiler happy for now
    }
}

/// Assertion used to ensure that the contract has called the constructor and initialized the values
fn _is_initialized(state: u64) {
    assert(state == 1);
}

/// Returns the hash where the boolean value indicating the approval of the owner is stored
fn _owner_approval_hash(tx_hash: b256, owner: Address) -> b256 {
    hash_pair(owner.value, tx_hash, HashMethod::Sha256)
}

/// Assertion used to ensure that a transaction hash has been submitted to the contract
fn _tx_exists(tx_data: u64) {
    assert(tx_data != 0);
}

I've minimised the repro, seems to be related to if lets.
contract;

enum E {
    X: (),
}

fn a() { }

fn b() {
    if let E::X = E::X {
        a();    // succeeds
        c();    // fails
    };
}

fn c() { }


Disable autocomplete for attributify props when not using that mode in VSCode

The autocomplete for classes in vscode works great, but it also shows same suggestions when tying component props even though I'm not using the attributify mode.

Since there is no setting for it, I'm guessing that is either by design or not implemented?
Suggested solution
It would make sense to either disable/enable it manually or based on the configuration as the attributify mode has to be explicitly enabled there to work.

You can try to explicitly set a presetUno in uno.config.ts, since presetAttributify is set by default

@chizukicn Even all presets are deleted, the contents of the rules are still autocomplete. The VSCode extension does not detect if the attribute context

Please provide a minimal reproduction. Thanks.

Why reproduction is required

@antfu Here is a reproduction GitHub repo

I'm not using attributify and it messes up autocompletion in vscode. Need an option to disable attributify in vscode plugin

I wrote a test to pinpoint the cause of this issue. I thought it might be an issue with searchUsageBoundary matching too large a range in jsx files @antfu
https://stackblitz.com/edit/vitest-dev-vitest-sbpput?file=test%2Fsuite.test.ts

any update for this issue?

My solution:

Create uno.config.ts on your root folder
Config Presets to presetMini()

import { defineConfig } from 'unocss'
import presetMini from 'unocss/preset-mini'
export default defineConfig({
  presets: [presetMini()],
})

Reload Uno CSS plugin

any update pleaze for this ??
@antfu

waiting...


Updating libraries for Ruby SDK

Coverage remained the same at 100.0% when pulling e2a21a5b9d550efb5552bf2c4bf38c4f49780ab4 on ali/update_libraries into 529349900eef5c98eaf18a1d2df956eba7258db1 on master.


PackedScene API outside the editor overrides all child node properties

Godot version
3.5
System information
Linux Mint
Issue description
Packing a scene via the PackedScene API in a running game produces an incorrect serialization of the scene which differs from saving a scene in the editor.
The incorrect serialisation does not properly compute what is overriden by instances and incorrectly writes every property into the .tscn. This makes it so changes to the scenes that are instanced in this incorrectly saved scene will not apply to this incorrect scene.
If you view this incorrect scene in the editor and then save it in the editor, the editor will repair this incorrect serialization.
Properties in a Child Scene which are not changed in a Parent Scene should not be present in Parent.tscn, or else it makes it so Parent is overriding Child. The editor serializes correctly but the PackedScene api at runtime does not.
Note: This work is being done to create a level editor where players can make levels in game, using nodes that we provide. We need this code to work to allow us to update those nodes without having to reserialize every player created level.
Steps to reproduce
Create a Scene, and set a property (like sprite.texture) call it Child in the editor and save it to the project
Write a script which creates a node called Parent, instances a Child and saves Parent via the PackedScene API
View Parent.tscn, note that all properties (eg: sprite.texture) are being saved into the .tscn. This is incorrect as some of these properties are defined in Child and are not overriden in Parent.
Change some of these properties in Child.
Load the parent via script, (as to be sure not to have the Editor reserialize Parent.tscn). Note that the instances of Child.tscn have not been updated to reflect the changed property.
Make a copy of Parent.tscn, open it in the editor and hit save in the editor and you will see how it should be serialized. Specifically properties that are in Child.tscn but not overriden in the Parent scene are not present in Parent.tscn file and now properly reflect future changes made to Child.tscn
Minimal reproduction project
PackedSceneTest.zip
Normal, correct scene created in the editor:
[gd_scene load_steps=3 format=2]

[ext_resource path="res://BasicScript.gd" type="Script" id=1]
[ext_resource path="res://NestedScene.tscn" type="PackedScene" id=3]

[node name="Node2D" type="Node2D"]

[node name="Node" type="Node" parent="."]
script = ExtResource( 1 )

[node name="NestedScene" parent="." instance=ExtResource( 3 )]

That same scene loaded and saved at runtime, with incorrectly computed overriden properties:
[gd_scene load_steps=4 format=2]

[ext_resource path="res://NestedScene.tscn" type="PackedScene" id=1]
[ext_resource path="res://icon.png" type="Texture" id=2]
[ext_resource path="res://BasicScript.gd" type="Script" id=3]

[node name="Node2D" type="Node2D"]

[node name="Node" type="Node" parent="."]
script = ExtResource( 3 )
some_property = 1

[node name="NestedScene" type="Sprite" parent="." instance=ExtResource( 1 )]
self_modulate = Color( 1, 0, 0, 1 )
texture = ExtResource( 2 )

The code to load and save the scene at runtime to produce the incorrect serialization:
var instanced_node = scene.instance()
get_tree().root.add_child(instanced_node)
var packed_scene := PackedScene.new()
packed_scene.pack(instanced_node)
ResourceSaver.save("res://scene_saved_at_runtime.tscn, packed_scene)

property_utils.cpp line 98:
		// Should be called in the editor only and not at runtime,
		// otherwise it can cause problems because of missing instance state support.

Looks like relevant information. This comment was written by Pedro Estebanez. Looks like all this code was written by Pedro.

cc @RandomShaper

I'll take a look. However, that comment plus the condition date back to older than my changes. I just brought those lines to a partial rework of that function which involved moving it to a new file.

At runtime, this code returns an empty Vector, while the editor does not:
// packed_scene.cpp
// in SceneState::_parse_node()
Vector<SceneState::PackState> states_stack = PropertyUtils::get_node_states_stack(p_node, p_owner, &instanced_by_owner);

I have discovered that this is due to
// PropertyUtils::get_node_states_stack()
//...
} else if (n->get_filename() != String()) {
// this is not empty in editor, is in exported game
const Ref<SceneState> &state = n->get_scene_inherited_state();

Now scene inherited state is empty due to the way packed scenes are instanced.
Node *PackedScene::instance(GenEditState p_edit_state) const {
#ifndef TOOLS_ENABLED
	ERR_FAIL_COND_V_MSG(p_edit_state != GEN_EDIT_STATE_DISABLED, NULL, "Edit state is only for editors, does not work without tools compiled.");
#endif

	Node *s = state->instance((SceneState::GenEditState)p_edit_state);
	if (!s) {
		return nullptr;
	}

	if (p_edit_state != GEN_EDIT_STATE_DISABLED) {
		s->set_scene_instance_state(state);
	}

I can fix this in our applicated by instantiating scenes with GEN_EDIT_STATE_INSTANCE as the argument:
var instanced_node = scene.instance(PackedScene.GEN_EDIT_STATE_INSTANCE)

However godot is attemping to restrict this behaviour to tools builds. I am going to be disabling that force in godot source code and attempting to instance and save nodes in exported games using GEN_EDIT_STATE_INSTANCE.
Overall this is no longer a bug report, but rather a request for better documentation on PackedScene.instance()'s parameters.
And a feature request that there is an ability for the PackedScene API to produce correctly serialized scenes in exported games.

GDScript default values are not recorded into exported builds. Why not? Is there a performance cost to this? Is there a subset of these values that can be enabled on exported builds such that the PackedScene api can produce correctly serialized scene files?
gdscript.h:
#ifdef TOOLS_ENABLED

	Map<StringName, int> member_lines;

	Map<StringName, Variant> member_default_values;

	List<PropertyInfo> members_cache;
	Map<StringName, Variant> member_default_values_cache;
	Ref<GDScript> base_cache;
	Set<ObjectID> inheriters_cache;
	bool source_changed_cache;
	bool placeholder_fallback_enabled;
	void _update_exports_values(Map<StringName, Variant> &values, List<PropertyInfo> &propnames);

#endif

GDScript default values are not recorded into exported builds. Why not? Is there a performance cost to this?

Serializing default values increases file sizes, especially with complex objects.

The engine needs to know the default values of every property of the builtin classes. That information is stored in ClassDB and is filled on every startup of the editor. I have not checked, but I guess those values GDScript only keeps in tool builds come from there. That means that, in order to allow running projects to benefit from the expected serialization either the engine should do that heavy collection at the startup of a project (not feasible), or the engine could have a snapshot of that information in an easy to load format, suitable for non-tools builds as well as tool builds running projects.

Serializing default values increases file sizes,

I misspoke here in my earlier comment, I dont think the engine should serialize default values. I think an exported game should be able to compute what is a default or inherited value. Currently, only the editor can do that, and I dont think it needs to be that way.

the engine should do that heavy collection at the startup of a project (not feasible)

Just to clarify, we're referring to an exported, non tools, game starting up right? Why is it not feasible? Seems like it would be feasible. Perhaps we just need to take some stuff out of TOOLS_ENABLED? Is there some massive cost to computing what is and what is not a default value?

Why is it not feasible?
It takes a long time, in the order of seconds, and likely a non negligible amount of memory.

Quoting myself:

That information is stored in ClassDB and is filled on every startup of the editor.

Maybe there could be some function you can call to trigger that process in non-tools builds.

I have also created an in-game level editor that is saving rooms as Godot scenes.
Room created from template.(PackedScene.GEN_EDIT_STATE_MAIN)
Spawned objects instantiated with
instantiate(PackedScene.GEN_EDIT_STATE_INSTANCE), and on room node call room_node.set_editable_instance(new_inst, true).
That enables editing object sub node exported variables and save into PackedScene.
But level editor is dysfunctional in exported build.
Such functionality shouldn't be locked behind in-editor builds.


fix arguments of assert.Equal in NACK tests

Description
Nothing particular, but the expected value is the 2nd argument, and the actual value the 3rd (i was copying and pasting code for my report patch and i realized that i was using the wrong syntax)
Reference issue

:fire: iterative improvements are my favorite :)
I also added you to the Pion organization, after one review you can merge your own PRs (same rules for everyone in the org) will start sending my PRs for this repo your way!
I am really excited to have 'easy congestion control' users can do Server <-> Server RTP transport and get nice stats


Compilation Error: Type mismatch

Hi. Your project got my attention after the battery of my laptop almost blowed up after being 24/7 plugged to the power outlet. Nice work!
However, I am experiencing issues while compiling your code. I get the following error:
ERROR] Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.7.10:compile (compile) on project smartCharger: Compilation failure                     [ERROR] D:\git projects\smartCharger\src\main\kotlin\Charger.kt:[61,47] Type mismatch: inferred type is TimeUnit but DurationUnit was expected
I have the following environment for the build:

Windows 10
Java SE Development Kit 19.0.1
apache-maven-3.8.6

The compilation prerequisites section in the Readme is empty, so I don't know if I'm using the correct versions.
I don't know if you are still maintaining this project, but if you decide to give me a hand, it would be great. :)
Thanks in advance and best regards,
JC

Hey, thanks for using my project :) This compiler error is the result of a kotlin upgrade which went under my radar. I fixed it now together with other small things that broke. If you do find more interest in my project, feel free to contribute - especially with the "profiles"-feature, which is still pretty much broken :/ - but don't feel obligated of course ;)
Thanks again and do submit more issues if you are facing any.
Cheers,
Vatbub

Oh and you need to run git pull origin master to get the latest changes. Then, run mvn package and it should work :)


Join and subquery support

There are two standard data-modeling approaches in analytical databases.
Star Schema
This is the de-facto standard to model data in data-warehouses to efficiently run OLAP (analytical / BI) style queries. We have a single fact table (containing measures / numeric data, e.g sales) surrounded by one or more dimension tables (e.g product). There is no relationship between dimension tables themselves. The only join path is between fact and dimension tables. In other words, you get a [1 : many] join since a single record in dimension table can be associated with multiple records in fact table.
One of the key things to note about modeling data this way is that dimension tables are denormalized (which again reiterates the fact that there is no relationship between two dimension tables).
Snowflake Schema
It is similar to star schema in the sense that there is a fact table and dimension tables. The key difference is that at least some of the dimension tables are normalized (thus leading to more dimension tables). This way you also establish relationship between multiple dimension tables as well.
The potential problem with this schema is normalization and thus resorting to join often even for simple queries. Not only that, writing a join query is way more complex in snowflake as compared to star. This is the main reason why star schema is generally the preferred choice in OLAP world. Managing the schema (I mean the collection of tables) is also complicated in this case.
There are few other ways to model as well but the above two are standard ones. The modeling step is going to be critical since it will dictate (to some extent) what kind of joins we support, complexity of such queries and the complexity at the user end to write such queries.
Standard Distributed Join Techniques
Now regardless of what we do above, there are couple of ways to implement join in distributed query engines like Pinot/Presto/Kusto/Spark etc and broadcast join is one of them.
Broadcast join is a common way to execute standard star schema join where we join a large fact table with smaller dimension table(s). The smaller table is then broadcasted to each server for the server to execute a local in-memory join (potentially a hash join by using the dimension table as the build side of the join and fact table as the probe side). The reducer/aggregator layer can do the final processing. In the spark community, this is commonly referred to as map-side join.
Co-located join for partitioned tables
Another way is to do a co-located join for partitioned tables. Let's say we are joining tables T1 and T2 on the join key column K. If both tables are partitioned on the join key column with the same uniform partition function, then each node essentially has all the data locally to execute it's side of the join without any data movement (as involved in broadcast join).
There are more known ways (shuffle) to do distributed join with varying degree of data movement, complexity etc. However, I feel the modeling approach that we will adopt along with any restrictions should be the first thing to get clarity on and this will also be determined by (to some extent) what our users currently expect from Pinot in terms of join. I feel we should start looking at join in Pinot with limited support for star schema join (where we try to restrict the number of dimension tables) as a reasonable starting point. We can also look at dimension-to-dimension join but we need to be more careful when modeling the data for such scenario.
I will start creating a proposal cum design document and share with the community. Meanwhile, we can use the issue to have some discussion on requirements etc.

Design document for a star schema join involving a fact table and small size dim tables: https://docs.google.com/document/d/1InWmxbRqwcqIakzvoEWHLxtX4XR9H5L01256EbAUHV8/edit?usp=sharing
This design require the dim table to be available on each host hence the restriction on size. Future work for this will involve lifting this restriction by implementing a broadcast join operator, which will enable larger and partitioned dim tables and help solve more generic join use cases.

At LinkedIn, we are exploring a combined design for subqueries and distributed joins since design / architecture wise there might be overlap and it is good to think of both design wise.
cc @amrishlal @jackjlli
Once we have had some preliminary thought / initial design, we will share with community in the next couple of weeks/months to iterate upon and collaborate further.

Great to see this. I am excited about this feature - but I don't see a strict need for subqueries to be designed in conjunction with joins. IMO subqueries are simpler and have independent use cases (nested aggregates).
I have been working on a sub query only proposal that I plan to share today.  Please share your inputs and feedback on it, and let's ensure its aligned with your overall plan of join support

@atris, Subqueries can broadly be divided into two categories

inner query (and there could be multiple of these) referring to same table as outer query
inner query (and there could be multiple of these) referring to different tables not necessarily same as outer query.

Since the overall query might touch more than 1 table and might require us to consider data movement / exchange operators (as in the case of join), we think it is better to think about both during design. This is the reason why we want to approach them together in the design phase to prevent situation where we go ahead and design, implement one of the two features and later on find ourselves retro-fitting the other one.

If the outer query is being executed on a broker node, on top of the result of the underlying topmost Combine operator, would this still be a problem?

I don't completely follow that. Can you give an example ? Also, are you approaching this from making subqueries work for a particular scenario ?

Any update on this topic ?

@kishoreg is anyone working on this?

We are thinking about it- we will fix the query-spi layer first so that the implementation is less invasive.


Change "Test page" page title

on https://uksa-alpha.cxp.io/application-overview/frequency
to something more relevent.

Fixed


Remove: purocean.YankNote version 2.9.2

## .\Tools\YamlCreate.ps1 -SkipPRCheck -Mode 5 -PackageIdentifier purocean.YankNote -PackageVersion 2.9.2

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


Ionic2 app reloads automatically every 10 seconds

Hello,
i am facing serious issue on ionic2 app which is running on iphone5.page is gettting reload every 10 seconds without any action.its reloading continuesly.please help me out with solution.

Try:

test in a browser with all addons disabled
test in a different editor

In the issue template is this text which you shouldn't have deleted:
**Ionic info:** (run `ionic info` from a terminal/cmd prompt and paste output below):

global packages:
@ionic/cli-utils : 1.4.0
Cordova CLI      : 7.0.1
Ionic CLI        : 3.4.0

local packages:
@ionic/app-scripts              : 1.3.7
@ionic/cli-plugin-cordova       : 1.2.1
@ionic/cli-plugin-ionic-angular : 1.2.0
Cordova Platforms               : android 6.2.3
Ionic Framework                 : ionic-angular 3.3.0

System:
Node       : v7.4.0
OS         : Windows 10
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed
npm        : 4.6.1

But this problems not occuring in browser.its happening in iphone 5 phone device

How did you run the app on you iphone?

This seems like a better fit for the support forums.

Hello! Thanks for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!


apm test displays wrong file names

How to reproduce this bug:

Open a package or create a new one.
Run apm test. If you created a new package with package-generator, the specs will fail and display an error like Expected 'life' to be 'easy'. (spec/testing-package-view-spec.coffee:5:20).
Rename spec/testing-package-view-spec.coffee (I renamed it to testing-package-view2-spec.coffee).
Run apm test again.

The specs fail (as expected), but instead of showing the new file path, it shows the old one.
I assume this is a caching issue, because clearing ~/.atom/compile-cache fixes the bug for me.
$ apm test
...

TestingPackageView
  it has one valid test
    Expected 'life' to be 'easy'. (spec/testing-package-view-spec.coffee:5:20)

Finished in 0.306 seconds
3 tests, 9 assertions, 1 failure, 0 skipped

Tests failed
$ mv spec/testing-package-view-spec.coffee spec/testing-package-view2-spec.coffee
$ apm test
...

TestingPackageView
  it has one valid test
    Expected 'life' to be 'easy'. (spec/testing-package-view-spec.coffee:5:20) <--Wrong path

Finished in 0.185 seconds
3 tests, 9 assertions, 1 failure, 0 skipped

Tests failed
$ rm ~/.atom/compile-cache -R
$ apm test
...

TestingPackageView
  it has one valid test
    Expected 'life' to be 'easy'. (spec/testing-package-view2-spec.coffee:5:20)

Finished in 0.316 seconds
3 tests, 9 assertions, 1 failure, 0 skipped

Tests failed
$ atom -v
1.4.1-2cf2ccb
$ apm -v
apm  1.5.0
npm  2.13.3
node 0.10.40
python 3.5.1
git 2.6.4

Would you mind reopening this on the https://github.com/atom/apm repository? That's where we track issues with the apm tool.

Is this really an issue with apm ?
AFAIK apm test is just an alias for atom --dev --test spec (source).
Using atom --dev --test spec instead of apm test shows the same issue, I only prefer apm test because it's shorter.

Ah good point. Thanks for clarifying :grinning:


Add support for Weak/Strong links aka Cascading deletes

This PR exposes cores concept of Weak/Strong  links in the Object Store schema using the Relationship::Strong parameter when creating link properties. This can be used to implement cascading deletes.
// New constructor
Property(std::string name, PropertyType type, std::string object_type, Relationship relationship)

Semantics:

Default (and current Linktype) is Weak.
Changing the link type is a breaking change
Modifying the link type does not clean up the Realm automatically, i.e. changing from weak -> Strong will not automatically remove all objects not connected. This cleanup only happens if a links is actually updated.
It is possible to create child objects with no parents, these will not be deleted automatically. This only happens if the parent is created, the link is created, and then removed again.
Cascading behaviour is immediate inside a transaction. Rolling back the transaction will undo all deletes.
Some corner cases exist for cyclic object graphs, they are documented in core

Java PR using this is here: https://github.com/realm/realm-java/pull/5678

All comments addressed

Currently, Sync will crash with Unsupported operation if you try to change the link type, so merging this PR is probably not a good idea until that has been fixed. Apparently, that will require a protocol upgrade.

Destructive changes always caused "bad changeset received", how is this any different?

The problem is not that you cannot make existing links strong, but rather that sync does not support strong links at all.

...oooh. Ouch. Thanks for the info.
Although in that case, what is the current link type?

Cascading deletes are now (somewhat) supported via embedded objects and it's unlikely sync will ever support strong links, so closing this.


Back-merging: Add branching policy (berkeley)

Back-merges https://github.com/MinaProtocol/mina/pull/14684 into berkeley.
The conflict was that berkeley (same as develop: https://github.com/MinaProtocol/mina/pull/14914) contained an older version of the branching policy that was on notion. That older policy was fully incorporated into the new one.

!ci-build-me

!ci-build-me

!ci-build-me

!approved-for-mainnet


modified goog.net.WebSocket.EventType.CLOSED

modified goog.net.WebSocket.EventType.CLOSED to include information from the underlying ClosedEvent
https://github.com/google/closure-library/issues/1078

@googlebot I signed it!

From: google-cla[bot]<EMAIL_ADDRESS>Sent: Tuesday, March 2, 2021 11:00 AM
To: google/closure-library<EMAIL_ADDRESS>Cc: Kutilek, Drew H<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [google/closure-library] modified goog.net.WebSocket.EventType.CLOSED (#1119)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla.developers.google.com%2F&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392583723|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=0VW1zspMb%2Fz02PENWT7nazYUa9VN7AQt6qg4oaUF%2Bd4%3D&reserved=0 to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA datahttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla.developers.google.com%2Fclas&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392593681|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=aLG2PKHDHnCBBhrBCIGd%2FCzIBJpBuwBrxK7yjR8gTI4%3D&reserved=0 and verify that your email is set on your git commitshttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392593681|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=hkLONl%2BXa5B%2B8QrcVCcf0BKuwmWDd%2FbQO8UJMgHq%2Fz4%3D&reserved=0.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoothttp://go/cla#troubleshoot (Public versionhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopensource.google%2Fdocs%2Fcla%2F%23troubleshoot&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392603641|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=UD0GxPsHdIVhx0xPptAaFQGfoH6VzFh8N7F17%2BZhxSY%3D&reserved=0).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA datahttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla.developers.google.com%2Fclas&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392603641|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=fIP0APGvVva3%2BnLzHzz3%2FBOzBXy%2BGEq%2Ba1iw0wseJIA%3D&reserved=0 and verify that your email is set on your git commitshttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392613587|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2B3OxzlgtPFKeTNBDEA6GB3BS%2BsFyBYd71eYZ3n8w18Q%3D&reserved=0.
The email used to register you as an authorized contributor must also be attached to your GitHub accounthttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392613587|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=W0t%2B%2BUKy7sai29u52BYVF6j%2BGTDmtLqRm%2Bt2ro13was%3D&reserved=0.

ℹ Googlers: Go herehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgoto.google.com%2Fprinfo%2Fhttps%253A%252F%252Fgithub.com%252Fgoogle%252Fclosure-library%252Fpull%252F1119&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392623552|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=9TfzwQEOIkfnth3%2FsiXg%2FnQH1hASO5D%2FtTHICgyvZA8%3D&reserved=0 for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fclosure-library%2Fpull%2F1119%23issuecomment-789137898&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392623552|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=IzImcVyP5u2M4a1MBopiUMbPEvJCP5oUYP6lHBuWZXc%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDUULAITP2OX3YZRST2YWLTBUYVDANCNFSM4YPRYCMQ&data=04|01|drew.h.kutilek%40disney.com|b58d2ece1c1a4371604508d8ddad75db|56b731a8a2ac4c32bf6b616810e913c6|1|0|637503084392633499|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=D%2BGNW8ffYR4jPUQXz99eoGKFS4N1RryqL0FaUZAqP5w%3D&reserved=0.

@googlebot I signed it!

https://cla.developers.google.com/clas does not have the agreement listed for my G Suite account<EMAIL_ADDRESS>which should be a member of the google group<EMAIL_ADDRESS>Perhaps it will take some time for the signed agreement to be processed. I will check that page periodically and re-run the CLA check once it is there.

Hi Drew, how long has it been since the corporate CLA went through? According to the internal guidance regarding CLAs, it might take a few days after the corporate CLA is set up for our database to be updated. So it's possible if it was just set up recently that the database hasn't been updated yet.
I do see an entry for Disney Streaming Services, but I can't tell how long ago the CLA was added -- do you happen to be under this subsidiary?

It was just submitted and DocuSign'd this morning. So I will give it a few days and try again.
I do not fall under Disney Streaming Services, I submitted a new one for Movies Anywhere LLC.

Ok, I will also check back over the next few days!

@googlebot I signed it!


Feature request: map.panInside

As reported in https://stackoverflow.com/questions/48450191/have-leaflet-panto-not-center , there is currently no API way of panning the map so that a given point just falls within the map viewport.
There is map.panTo() which resets the center of the map to the given LatLng, and there is map.panInsideBounds(), which needs a LatLngBounds. But there is no panInside() which could take just a LatLng.

Closing since #6054 was merged!


Add a Pull Request template

Is your feature request related to a problem? Please describe.
I would like to have a Pull Request template to make it easier to contribute to this project.

Also, if possible I would like to work on this.

It would be great @Benardi! :rocket:


Use an IndexSet for type and kind scheme variables :grimacing:

This fixes quite a nasty bug I encountered into where an infinite substitution was being generated when forall type variables were processed in a certain order...
Swapping out HashSet for IndexSet (to preserve insertion order) is of course not really a fix at all, as we shouldn't depend on insertion order. But fixing that will require a significant review of the type checking logic, which I don't want to be blocked on right now.

Closing in favor of #118


bower  ECONFLICT Unable to find suitable version for angular

Hi,
I'm unable to get this working on Windows.  I have node v4.2.1, npm v2.14.7 and bower v1.7.0 installed.
npm install is working ok, but bower install gives the following output:
▶ bower install
bower angular#~1.3.15           cached https://github.com/angular/bower-angular.git#1.3.20
bower angular#~1.3.15         validate 1.3.20 against https://github.com/angular/bower-angular.git#~1.3.15
bower angular-highlightjs#~0.4.1           cached https://github.com/pc035860/angular-highlightjs.git#0.4.3
bower angular-highlightjs#~0.4.1         validate 0.4.3 against https://github.com/pc035860/angular-highlightjs.git#~0.4.1
bower angular-resource#~1.3.15             cached https://github.com/angular/bower-angular-resource.git#1.3.20
bower angular-resource#~1.3.15           validate 1.3.20 against https://github.com/angular/bower-angular-resource.git#~1.3.15
bower angular-bootstrap#~0.12.1            cached https://github.com/angular-ui/bootstrap-bower.git#0.12.1
bower angular-bootstrap#~0.12.1          validate 0.12.1 against https://github.com/angular-ui/bootstrap-bower.git#~0.12.1
bower angular-route#~1.3.15                cached https://github.com/angular/bower-angular-route.git#1.3.20
bower angular-route#~1.3.15              validate 1.3.20 against https://github.com/angular/bower-angular-route.git#~1.3.15
bower angular-spring-data-rest#0.4.1       cached https://github.com/guylabs/angular-spring-data-rest.git#0.4.1
bower angular-spring-data-rest#0.4.1     validate 0.4.1 against https://github.com/guylabs/angular-spring-data-rest.git#0.4.1
bower angular#>=1 <1.3.0                   cached https://github.com/angular/bower-angular.git#1.2.29
bower angular#>=1 <1.3.0                 validate 1.2.29 against https://github.com/angular/bower-angular.git#>=1 <1.3.0
bower angular#>1.0.8                       cached https://github.com/angular/bower-angular.git#1.4.8
bower angular#>1.0.8                     validate 1.4.8 against https://github.com/angular/bower-angular.git#>1.0.8
bower                                   ECONFLICT Unable to find suitable version for angular

I'm fairly new to node et al, and I guess using Windows isn't helping (no choice there), but the spring-data-rest plugin is just the droid I am looking for so I am hoping you can help me resolve this...
I've been messing around with other projects using these tools and wonder if I have inadvertently installed conflicting versions of something?
Please can you offer some clues as to what may be the problem?
Cheers,
Mike.

Hi Mike,
sorry for my late response. I just updated the sample with the newest libraries etc. and for me the bower install works properly. For me there is a prompt asking which version of Angular should be used and there select the one which is defined in the bower.json (1.4.8) of the project.
I hope that helps.
Happy christmas and regards,
Guy

Hi Mike,
I will close the issue due to inactivity. You can reopen it if you still have an issue.
Thanks and regards,
Guy


Adds patternfly and font awesome icons

I am adding icons, please review this with care since I've wrote documentation and I suck at writing in english.
#11

@cshinn @srambach Please review again, I am sorry I missed the md files

:shipit:

LGTM! what do you think @srambach?

+1


[FLINK-13986][runtime] Clean up legacy code for FLIP-49.

What is the purpose of the change
This PR is a clean up of FLIP-49 commits. It contains the changes of the following issue, while the commits are cleaned up, reorganized and squashed.

FLINK-13983 #9801
FLINK-13986 #10141

Brief change log

b6c67e181dce913a99802471eb8baeb11cdb1920..eaab6c2b6069514c6a1479222dd329e231fab448: Hot-fixes and clean-ups.
3a17c1902964858919461aadbab92ee741345983..3579db36cff214967fbf78cb6e4dfe6873cf5860: Commits for FLINK-13983, launching TMs with new memory calculation logics. Fix test cases that failed due to the switch of memory calculation logics.
ae4484cc6d206942fab436b36a55bdae7af8cf2f..35bc04059fb8225e2cadf7f9fcd870e9bd2cd2ee: Commits for FLINK-13986, cleaning up legacy codes.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Travis passed: https://travis-ci.org/xintongsong/flink/builds/611746842

Also, in old scripts we output a warning if user sets deprecated memory config with a hint what to use instead, we do not do this now for all deprecated options which we fallback to in TaskExecutorResourceUtils including FLINK_TM_HEAP which we should deprecate in release notes

@azagrebin
Thanks. Comments are addressed.

Thanks for the review, @azagrebin.
There's one minor text fix after you approved this PR, which is cleaning ENV in TaskExecutorResourceUtilsTest#testConfigTotalProcessMemoryLegacyEnv.
Travis passed with this fix: https://travis-ci.org/xintongsong/flink/builds/619851085

Actually, I did not notice that we do not snapshot the env vars before the test and restore them afterwards, like we do e.g. in PluginConfigTest:
        private static Map<String, String> oldEnvVariables;

        @Before
	public static void setup() {
		oldEnvVariables = System.getenv();
	}

	@After
	public void teardown() {
		if (oldEnvVariables != null) {
			CommonTestUtils.setEnv(oldEnvVariables, true);
		}
	}

This is a cleaner approach.
Could you add this?

@azagrebin, updated.

merged into master by 5dca72169992567837bda21889c187fd56bfb391..5576851e0317b2e1e9e78e7aae02285203eed940


Massive debug log files generated

DBeaver 7.0.0 generated 10GB of debug log files in a few days of activity.
I'm guessing a debug flag got left turned on somewhere?

System information:

Win10 x64 Insider 2004
DBeaver 7.0.0

Probably some error with huge stacktrace was spammed.
Could you post a sample of debug log content?
You can disable debug log in preferences:

Ok. I had to wipe it as my disk was full, I've installed a large file editor and next time it happens I'll grab a chunk, then I'll remove the flag.
Thanks.

ticket will be closed.
if issue reproduce once again - feel free to reopen the ticket


Make sure GH actions is run also for PR's from forked repos

https://github.community/t/github-workflow-not-running-from-pull-request-from-forked-repository/16379/40
https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#pull_request_target

After moving to Eclipse, I do not think we will be needing this anymore.

I decided to unassign me, as I am not going to work on this :upside_down_face:


added thread options in run_tracker.yaml but looks like the command created does not care

title explains ....

Solved, the problem was that script was expecting an int but in the yaml things were passed as strings

:+1:


CoreML Format

Hello, I want to use your model on iOS device for image Inpainting feature but have to convert to .mlmodel format using coremltools python package. is it possible to convert yours?
Thanks.

any update?

Hi, sorry for the late response. I am not familiar with the IOS application.


Bug: Use of boolean instead of bool

PHP Version
8.2
CodeIgniter4 Version
4.2.10
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
macOS, Linux
Which server did you use?
apache
Database
No response
What happened?
VSCODE Intellisense detected improper type "boolean". Should be "bool".
app/Config/Cache.php line 137
Steps to Reproduce
See app/Config/Cache.php line 137
Expected Output
Get error reported by VSCode's Intellisense
Anything else?
No response

I dont see any error

I'm using vscode and does not see any error. In any case, can you send PR for the change?

I'm using the PHP DEVSENSE extension also. There's no "boolean" in php. It must be "bool".
On Wednesday, January 4, 2023 at 06:09:07 AM EST, John Paul E. Balandan, CPA<EMAIL_ADDRESS>wrote:

I'm using vscode and does not see any error. In any case, can you send PR for the change?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

phpDocumentor permits boolean.
https://docs.phpdoc.org/3.0/guide/references/phpdoc/types.html#definition-of-a-type
But PSR-5 does not permit boolean.
https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md#keyword
We accept PR for the change!

Ah i see, PSR-5 accept bool not `boolean.
I send PR #7051.

But now PSR-5 is a draft, not accepted yet.


correct types documentation

currently the documentation refers the types to https://developers.google.com/places/supported_types which is incorrect since react-geosuggest isn't using the API service directly.
the types should actually refer to the ones in the https://developers.google.com/maps/documentation/javascript/reference#AutocompletionRequest.
tested in my usages

Thanks! Didn’t spot that there was a wrong URL in there.  👍

@ro-ka no problem dude. happy to help.


feat: add logging macro

[x] resolves #187
[x] follows contribution guide
[x] code change includes tests

Guide to be added in README.md of the logging package
Prequiste for using log! macro for a package:

import this as a dependency in Scarb.toml

[dependencies]
`raito_macros = { path = "../macros" }`

add the features in Scarb.toml

[features]
default = [log_level_none]
log_level_none = []
log_level_trace = []
log_level_debug = []

add the logging.cairo(must be this name) file to the package root, like the package/consensus

# packages/consensus/src/logging.cairo
#[cfg(feature: 'log_level_trace')]
pub const LOG_LEVEL_TRACE: bool = true;

#[cfg(feature: 'log_level_trace')]
pub const LOG_LEVEL_DEBUG: bool = true;

#[cfg(feature: 'log_level_debug')]
pub const LOG_LEVEL_TRACE: bool = false;

#[cfg(feature: 'log_level_debug')]
pub const LOG_LEVEL_DEBUG: bool = true;

#[cfg(feature: 'log_level_none')]
pub const LOG_LEVEL_TRACE: bool = false;

#[cfg(feature: 'log_level_none')]
pub const LOG_LEVEL_DEBUG: bool = false;

in lib.cairo

pub mod logging;

How is it going @TropicalDog17? It seems like this one is close to be finished.

Please check: https://github.com/keep-starknet-strange/raito/pull/224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.

Please check: #224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.

Please check: #224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.

Which means we might need to wait until they implement it.

Please check: #224. I had to try it myself. Indeed there is a problem with conditional compilation in a multipackage project. Waiting for scarb developers response.

Which means we might need to wait until they implement it.

yeah I see, and very weird that the language server still recognize that feature.

yeah I see, and very weird that the language server still recognize that feature.

true

I am closing it for now. We will need to revisit this issue once feature support in Scarb is more mature. The work with my small fixes is parked in branch: feat/logging-macro

@TropicalDog17 please contact me on tg: @aundumla


Pull:create, warn when remote branch doesn't exist and ask to push

I will finish to tomorrow ;) its going to be awesome :+1:

:+1:


Not perfect yet, but surely better.

@dbishop i think we can close this - i merged #21 - and that seems to have all the ports and modules match up and it works with different disks or server_per_port settings...
if you could double check master is working for you that'd be great - happy to hold onto this for reference as long as it's useful!


Node.js  Loaders Team Meeting 2023-03-28

Time
UTC Tue 28-Mar-2023 18:00 (06:00 PM):

Timezone
Date/Time

US / Pacific
Tue 28-Mar-2023 11:00 (11:00 AM)

US / Mountain
Tue 28-Mar-2023 12:00 (12:00 PM)

US / Central
Tue 28-Mar-2023 13:00 (01:00 PM)

US / Eastern
Tue 28-Mar-2023 14:00 (02:00 PM)

EU / Western
Tue 28-Mar-2023 19:00 (07:00 PM)

EU / Central
Tue 28-Mar-2023 20:00 (08:00 PM)

EU / Eastern
Tue 28-Mar-2023 21:00 (09:00 PM)

Moscow
Tue 28-Mar-2023 21:00 (09:00 PM)

Chennai
Tue 28-Mar-2023 23:30 (11:30 PM)

Hangzhou
Wed 29-Mar-2023 02:00 (02:00 AM)

Tokyo
Wed 29-Mar-2023 03:00 (03:00 AM)

Sydney
Wed 29-Mar-2023 05:00 (05:00 AM)

Or in your local time:

https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Loaders Team+Meeting+2023-03-28&iso=20230328T1800
or https://www.wolframalpha.com/input/?i=06PM+UTC%2C+Mar+28%2C+2023+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1H3pe3uAJOwNKbw9FMvlbPXlwcXComzKsVGnia-0ENxs/edit

Agenda
Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/node

console.log failure while working with worker threads. #30491

Invited

Loaders team: @nodejs/loaders

Observers/Guests
Notes
The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

link for participants: https://zoom.us/j/97506450082

For those who just want to watch: https://www.youtube.com/c/nodejs+foundation/live

Is there a reason to meet today? I’m not sure why https://github.com/nodejs/node/issues/30491 is on the agenda.

I’m not sure why nodejs/node#30491 is on the agenda.

Because console.log flakiness inside worker threads is an issue for loaders (and has been a pain for our own tests). If we have time, we could discuss what solutions we could come up with.

I can meet. Do we need to make a decision (that should be recorded) or just pair/brainstorm (which could just be a huddle)?

I’m not sure what decision could need to be made? If you find a solution for the console.log issues then I think just make a PR, and if there are any tradeoffs involved they can be analyzed in the context of landing that PR.

Sounds like we don't need an official meeting then?
Michaël has a clever idea which he pushed earlier today that hopefully will do the trick (theoretically, I can't see why it wouldn't work). So 🤞

I’m not sure what decision could need to be made? If you find a solution for the console.log issues then I think just make a PR, and if there are any tradeoffs involved they can be analyzed in the context of landing that PR.

That's what I made in https://github.com/nodejs/node/pull/47036, but given the lack of interactions on that PR, it was hoping discussing it in the loaders meeting would be more productive. I'm fine skipping, it sounds like Michaël may have find another solution, so it's not as urgent to find a solution.