Does contrastive loss in mnist_siamese_graph.py follow the original paper?

It seems that the contrastive loss in the moist_siamese_graph.py is defined as
K.mean(y_true * K.square(y_pred) +
                  (1 - y_true) * K.square(K.maximum(margin - y_pred, 0)))

However, the loss defined in the original paper is
K.mean((1 - y_true) * K.square(y_pred) +
                  y_true * K.square(K.maximum(margin - y_pred, 0)))

where y_true is 0 if two images are from the same class, and 1 otherwise.

I had the same thought when I originally looked at the paper and this implementation, and I still do. I think you are correct about the second formula.
Also, I think there is another really big assumption in compute_accuracy: they fix a threshold at 0.5, but it actually may not be the best value to choose. It somewhat works because the formation of pairs here makes it so you have a balanced number of examples and counter-examples with the same cost in the loss function.
If you really want the best FAR and FRR the example should at least tell the user to test a few values of threshold and plot a ROC.
One last thing: I don't remember what setting of verbose is activated in this example, but beginners should really be careful of the accuracy and val_accuracy metrics during the fitting phase, because they are computed on simple rounding operations (so basically with a threshold of 0.5), so they may actually not reflect the real accuracy at all. However, the loss remains a good metric to look at if your dataset is not too unbalanced.

@StripedBanana No matter how much the threshold is, the compute_accuracy is wrong. I saw there is a fix which gives a correct method of computing the accuracy, but they reverted this fix and I don't know why.
For the threshold, I use the corrected contrastive loss function provided by @LinHungShi and draw the scatter plot for the prediction value:

Then I have no idea how to set a simple threshold to divide them...Or maybe I should follow the original paper and do some clustering?

From your scatter plot it looks like your training phase has done very little to get better results than random guessing. Are you using the mnist dataset and the pairing function from the example? This data should give you much more distinct distributions after a few epochs. Can you post your training phase metrics and parameters? Just copy paste the console output from Keras if you use verbose.
I strongly don't recommend using compute_accuracy if you want to go further than just toying around with this example. It is very unintuitive and you should get way more information with your scatter plot.

@StripedBanana
The previous plot is a result after 20 epoch.  I tried 100 epoch then it looks worse...

Sorry I am new for Keras. I set verbose=1 in the fit function. Then this is the console output of the last 3 epoch. Is this you need?
Epoch 97/100
   512/10840
 73728/108400 [===================>..........] - ETA:
108400/108400 [==============================] - 5s - loss: 0.2224 - val_loss: 0.2749
Epoch 98/100
  8704/108400 [=>............................] - ETA: 5s - loss: 0.2200
 56320/108400 [==============>...............] - ETA: 2s - loss: 0.2219
108400/108400 [==============================] - 6s - loss: 0.2223 - val_loss: 0.2755
Epoch 99/100
 18944/10840
 27648/108400 [======>.......................] - ETA: 3s - loss: 0.2197
106496/108400 [===============
108400/108400 [==============================] - 5s - loss: 0.2217 - val_loss: 0.2742
Epoch 100/100
 35328/108400 [========>.....................] - ETA: 3s - loss: 0.2202
108400/108400 [==============================] - 5s - loss: 0.2220 - val_loss: 0.2742

Yes this is what I need, but only a few epochs does not help much, although I can already say loss/val_loss>0.2 is very high (I think a loss of 0.25 is basically random guessing given the contrastive loss function we have). So I'm pretty sure we can say your training phase is ineffective.
Can you also tell us what data you use? How do you load it? What is your network? Maybe you only change the contrastive loss expression in the example?

@StripedBanana I use the default MNIST dataset by from keras.datasets import mnist. I didn't change anything from the original code except the contrastive loss function.
Now I feel weird about the eucl_dist_output_shape function as well. The value returned is <class 'tuple'>: (None, 1). I doubt whether it really works, and I feel that's why this network can only do a random guessing. Do you have any clue about it?

@typewind eucl_dist_output_shape returning (None, 1) is ok, it's just required by TensorFlow since there is no shape inference in a model. Basically we are saying that we expect an unknown number of scalar values as the output of the euclidean distance.
Please post your code so we can try to run it and reproduce.

@StripedBanana My code is here. I only modified contrastive_loss(line 37) and compute_accuracy(line 76)

@StripedBanana , you seem to know about contastive loss and siamese networks. I am stuck on an issue I don't quite understand, would you be kind enough and help me a little? My training runs fine (I train keras siamese as given in the example but on custom dataset) and the model is working decently. I have noticed that model.predict never returns 0. Does it return the euclidean distance between feature vectors of the query image pair during inference? It seems to be capped at a minimum of 0.00031622776. This exact number comes up quite frequently when I print(pred[0][0]) where pred = model.predict([image1, image2]). Any help is highly appreciated.

Ok, nevermind, I got it


deploy failed on okd 3.11

The vault container failed to run with following error logs:
chown: /vault/file: Operation not permitted
chown: /vault/file: Operation not permitted

I have found that the log infomation is located ./vendor/github.com/hashicorp/vault/vault/init.go.
I also try to execute the chown command and it return following information to me.
/ # chown vault:vault /vault/file
chown: /vault/file: Operation not permitted

The persist volume is provided by NFS server within the cluster. The ownner for the NFS export path is nobody:nobody.
I also try to change the default scc to allow pod run as any, but it is not work.
I also try to rebuild the vault container and remove the command that will chown the file /vault/file, then the pod will up, but I can not visit the web. It seems like it is not the right way to resolve this issue.
Could you give me some suggestion to fix this issue?

hi @vanloswang , I am not maintaining this repo anymore. While the approach explained in this repo is probably still valid, I now recommend the approach explained here:
https://blog.openshift.com/vault-integration-using-kubernetes-authentication-method/
https://blog.openshift.com/integrating-vault-with-legacy-applications/
In partuclar the last blog post points to this repo: https://github.com/openlab-red/hashicorp-vault-for-openshift , which has more up to date and tested instructions to setup Vault.
Back to you error it looks like for some reason you don't have the right permissions on the mounted volume. Try to fix it using the supplemental group option on your pod and adding the group id that you have defined on that NFS mount.

OK，Thank you very much.


add predict command

This PR

updates the CLI (rewrite that now include a predict command)
includes some other changes to allow loading statistical measures from json with pydantic validation

This is very cool :) I have already tested with affable-shark and the test input data provided by the model.
I have one general question, maybe I am missing something. Since we can have multiple input tensors and output tensors, that means we can have multiple .npy files. Why we don't store the tensors in one .npy file as an object, or maybe use the .npz, so we can can make our lifes easier dealing with one input and one output file?

I used .npy as a file format default here, but in general we support many file formats. Users might want use .h5, .tif .png... which the imageio library takes care of for us.
As there is no .npz equivalent across file formats I would like to keep this simple approach.
We might want to use .h5 as a default and we should add .zarr and possibly make that the default instead.
Using numpy is the most hacker friendly, but not the most user friendly.

Oh I see, maybe we could add this to the help section, so users can know what are the possible format right? For example, I didn't know that also from the format of the output file, the format of the file is inferred as well e.g. if --outputs=*.png, a png image will be created.
Althoug file extensions and file formats can be out of sync, but yeah let's not be too pedantic :)


Spellchecking feature not working

"Spell checking failed: Error invoking "spell""
GNU Nano uses GNU spell, which uses ispell

In classic confinement the feature work in Ubuntu 18.10, but its compatibility is not verifiable.


Fixes for recent Imath deprecations

FLT_MAX was erroring for being undefined, because of some removals of
includes deep in Imath that we inadvertently depended on instead of
including <limits.h> here in OpenEXR. But that should be replaced by
std::numeric_limits<float>::max() anyway, in modern C++ style.
Also, fix some warnings due to Imath::Math<> having been marked as
deprecated and now std:: for certain math functions is preferred.
Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

Failing Windows CI. Grrrr...


Make subject / organization configurable for the membership services CAs

Description
The subject info for CA certificates generated by membership services is currently hardcoded.  Need externalize this properties and make them configureable.
Describe How to Reproduce
Use membership services as implemented today.  The values for organization and country are hardcoded to IBM and US respectively

I am happy to take this on if no one else has it


[FIXED] Not able to run locust due to "No module named pkg_resources" issue on Manjaro (Arch based Linux)

Describe the bug
I've install locust inside a venv via pip install locust.  Running locust -f myfile.py failed with "No module named pkg_resources" error. Trying to update setuptools as recommended on Stackoverflow I managed to break my system's pip/setuptools. At that point setuptools version was 56.0.0 - I guess this version is not compatible with locust's dependencies(?)
Below are the steps how I managed to fix pip/setuptools issue which allowed to run locust successfully after installation.

deactivated and removed used venv
fixed pip via python3 -m ensurepip --default-pip and python -m ensurepip --upgrade (that seems to have updated setuptools as well - version 57.4.0). But you can also try python3 -m pip install --upgrade pip setuptools wheel)
created a new venv python -m venv ~/.venvs/locust
activated locust venv ~/.venvs/locust/bin/activate
installed locust pip install -U locust --no-cache-dir
run locust with success

Environment

OS: Manjaro 21.1.6 Pahvo (Arch Linux)
Kernel: x86_64 Linux 5.13.19-2-MANJARO
Python version: 3.9
Locust version: 2.5.0
Locust command line that you ran: locust -f myfile.py

Is this really locust related?
my first hit on google sounds like it may be a more general problem.
https://stackoverflow.com/questions/7446187/no-module-named-pkg-resources


Add blmayer.dev

Hi!
Please add this site to your list, it has 6KB.
https://blmayer.dev
Thanks.

I am afraid, this website will not be added to 10 KB Club because it does not meet the requirement specified in the fifth point of the Club Rules.


Where is the refresh() method?

I'm submitting a ...  (check one with "x")
[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
According to the docs there is a method called refresh() that refreshes the rows in the grid.
However, my DatatableComponent doesn't have any such method. A quick search on the repo yields zero results too.
Expected behavior
Currently cells are not being updated on external events. User has to click on the table to trigger rerendering of the row. Being able to refresh the table's view would be ideal.

Refresh will be delete! Certainly. We wait until @austin fix something

Opps... Forgot to remove from docs. See #255 for info on this.


New Discord Whitelist remove if role isn't present command but I have no clue what I am doing

Kinda new to GitHub, so I don't quite get how to implement my own code solutions into the code without officially submitting it. This piece of code would be for automatically removing the Whitelist of someone when they lose a specific role. My use of this is for a Twitch sub only minecraft server that would remove the whitelist once they are no longer a Twitch Subscriber (Role in Discord), but I have not a single clue of how to make the .jar file myself, and all of my attempts have not worked. I adapted the onGuildMemberRemove function to create this. As far as I can tell the function should work, all that would need to be implemented is a way in the config file to enable or disable it, and to add a role to check for. This code uses the GuildMemberRoleRemove event to work. Below is the code:
@Override
public void onGuildMemberRoleRemove(@Nonnull GuildMemberRoleRemoveEvent event)
{
	for(Role rl : event.getMember().getRoles())
	{
		if(rl.getName() == "Twitch Subscriber")
		{
			return;
		}
	}
    	String discordUserToRemove = event.getMember().getId();
    	DiscordWhitelister.getPlugin().getLogger().info(discordUserToRemove + " lost their sub. Removing their whitelisted entries...");
    	List<?> ls =  UserList.getRegisteredUsers(discordUserToRemove);

    	if(ls != null)
    	{
        		for (Object minecraftNameToRemove : ls)
        		{
            		DiscordWhitelister.getPlugin().getLogger().info(minecraftNameToRemove.toString() + " lost their sub. Removing their whitelisted entries.");
            		if (WhitelistedPlayers.usingEasyWhitelist)
            		{
                			ExecuteServerCommand("easywl remove " + minecraftNameToRemove.toString());
            		} else
			{
                			ExecuteServerCommand("whitelist remove " + minecraftNameToRemove.toString());
            		}
        		}
        		try
        		{
            		UserList.resetRegisteredUsers(discordUserToRemove);
        		}
        		catch (IOException e)
        		{
            		e.printStackTrace();
            		return;
        		}
        		DiscordWhitelister.getPlugin().getLogger().info(discordUserToRemove + " lost their sub. Successfully removed their whitelisted entries from the user list.");
    	}
    	else
    	{
        		DiscordWhitelister.getPlugin().getLogger().warning(discordUserToRemove + " lost their sub. Could not remove any whitelisted entries as they did not whitelist through this plugin.");
    	}
}

Added in 973d5f53e764975133c641ca6ad8580a3ab84ad9. Thanks for the suggestion.


ci: remove ninja for all but windows, for us it is slower than make -j2

[x] My pull request is made against the dev branch.
[x] I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] I tested my commits, by adding a test case to the unit tests if needed
[x] I have ensured that I did not break any existing API calls.
[x] My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

I'm done tweaking this now, ready for review.
2x speed improvement in Linux and mac builds, 25% speed increases in windows. moved voice connection unit tests to extended as they are no longer reliable on GitHub runners.


Build fails

On my Rust installation cargo install smith fails to compile:
   Compiling delegate v0.4.3
error[E0432]: unresolved import `syn::export`
  --> /Users/xxxxxxxxx/.cargo/registry/src/github.com-1ecc6299db9ec823/delegate-0.4.3/src/lib.rs:94:10
   |
94 | use syn::export::TokenStream2;
   |          ^^^^^^ could not find `export` in `syn`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `delegate`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: failed to compile `smith v2.0.0`, intermediate artifacts can be found at `/var/folders/f5/p_5syrl918q6m214rwk78dk00000gn/T/cargo-install7ZT3bT`

Caused by:
  build failed

I'm running MacOS BigSur 11.1:
$ cargo --version
cargo 1.49.0 (d00d64df9 2020-12-05)
$ rustc --version
rustc 1.49.0 (e1884a8e3 2020-12-29)

Thank you, Luca-

Today I upgraded to Rustc v 1.50.0, but it still doesn't compile
...
...
   Compiling clipboard v0.5.0
   Compiling delegate v0.4.3
error[E0432]: unresolved import `syn::export`
  --> /Users/lucaivaldi/.cargo/registry/src/github.com-1ecc6299db9ec823/delegate-0.4.3/src/lib.rs:94:10
   |
94 | use syn::export::TokenStream2;
   |          ^^^^^^ could not find `export` in `syn`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `delegate`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: failed to compile `smith v2.0.0`, intermediate artifacts can be found at `/var/folders/f5/p_5syrl918q6m214rwk78dk00000gn/T/cargo-installvhNbdr`

Caused by:
  build failed

$ cargo --version
cargo 1.50.0 (f04e7fab7 2021-02-04)
$ rustc --version
rustc 1.50.0 (cb75ad5db 2021-02-10)

The version on crates.io was outdated, I don't use the delegate crate anymore. Just pushed v2.0.1 and it fixes it.

The version on crates.io was outdated, I don't use the delegate crate anymore. Just pushed v2.0.1 and it fixes it.

Thank you!
I'll try again as soon as I'll be back home.


Add Bitcoin Core 0.14.1

Added new version of Bitcoin Core 0.14.1

Thanks! Not sure why CI failed, but I'm restarting it.

3f4eb95a832c205d1fe3b3f4537df667f17f3a6be61416d11597feb666bde4ca bitcoin-0.11.2-linux64.tar.gz
bitcoin-0.11.2-linux64.tar.gz: FAILED
sha256sum: WARNING: 1 computed checksum did NOT match

Thanks!


The link to download ASDK seems wrong

The link to download ASDK which mentioned in the article doesn't work. In that page, we can't find anywhere to download ASDK or provide our details.

Go to the Get Started page where you can download the ASDK, provide your details, and then click Submit.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 289cb46f-b173-0ec0-ace1-6e038f82c553
Version Independent ID: 8f72a4e5-fba9-6631-1924-3b649446bf18
Content: Download and extract the ASDK - Azure Stack Development Kit (ASDK)
Content Source: azure-stack/asdk/asdk-download.md
Service: azure-stack
Sub-service: azure-stack-hub-asdk
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@xizhuang We apologize for the inconvenience, we are investigating this problem. In the meantime, you can download the ASDK from here: https://azure.microsoft.com/contact/azure-stack-dev-kit/thank-you/

#please-close

Resolved


this.setState is not a function

Happens for me on clicking links -- blocks app from transitioning state semi-permanently (until I click around a lot more). Rel #291

index.js:38300 Uncaught TypeError: this.setState is not a function
    at Object.handleTouchTap [as onTouchTap] (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:38300:18)
    at EnhancedButton._this.handleTouchTap (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:11603:21)
    at Object.ReactErrorUtils.invokeGuardedCallback (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:36388:16)
    at executeDispatch (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:21832:21)
    at Object.executeDispatchesInOrder (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:21855:5)
    at executeDispatchesAndRelease (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:16699:22)
    at executeDispatchesAndReleaseTopLevel (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:16710:10)
    at Array.forEach (native)
    at forEachAccumulated (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:51264:9)
    at Object.processEventQueue (file:///Users/ia/dev/etc/emerald-wallet/app/index.js:16910:7)

can't reproduce

Attached: GIF of "clicking errors" -- I wish I could be more descriptive...
I'll try:
Generally: clicking on some things "freeze" the app
Walkthrough GIF:

I click on "ADD ETC" and get no expected popup; notice the error log then.
I click "SEND" and am directed to SEND view (as expected)
I click "Dashboard" am directed to wallet view with maladjusted CSS formatting
I click on "Wallets and Tokens" and get same this.setState error, and am not redirected to appropriate view.

This is the fix:
class WalletsTokensButton extends React.Component {

    constructor(props) {
.....
        this.handleTouchTap = this.handleTouchTap.bind(this);
        this.handleRequestClose = this.handleRequestClose.bind(this);
    }
......

31df66f has helped -- I am now able to navigate 👍
It seems there are for me still a couple visual elements broken:

[ ] black circle over the network selection arrow in the nav
[ ] "+ WALLETS AND TOKENS" button remains visually to appear selected after being un-selected (click button, then click away, below is result)


Create tags

Having docker automated builds, creating tags in github should create the respective tag in docker hub.
Could it be possible to start creating tags from now?
We can even still add the old tags now, just checking the code in that version and building the image there. With a few lines of bash this could be easily done (I guess).

I'll put it on the todo list, but it might be a while before I'm able to implement it fully. I hope it's not a high priority for you as it might well cross over into 2017.

Not a priority at all. Being a priority I'd help creating some bash script for the old tags, or maybe with some free time...

+1

@elisiariocouto if it's a must-have for you (or anybody else), please don't add +1 to the comments and use reactions on the original issue post. Of course, you're welcome to submit a PR, currently this has no planned due date.

Alright, I can help you with this. How are the Docker Hub builds being triggered?

Webhook, on commit of firehol/netdata (trigger via API) repository or on push to titpetric/netdata (standard). Nothing special about it. I already set it up once to use branches as tags (but never created appropriate branches for it):

So, technically, what needs to be done, ideally - is a script which I would put in the master branch, and occasionally run to update either tags or branches, which would then in turn use this information to pull the correct tag from firehol/netdata and build it as a docker container. The obvious issue might be, that the Dockerfile respectively changed over time and it might not be able to build whichever versions, meaning some modifications might have to be made per-branch.
Of course, we can also stick everything into a folder structure under the master branch, and I can create a few links on docker hub manually. It would mean however, that each new netdata version tag would need to be added manually to docker hub. I guess I am also fine with that.

Wouldn't this be much easier if the Docker Hub Automated builds were triggered by firehol/netdata repository itself? This way the only build setting that needs to be added is the Tag option.

This way, everytime a new tag is pushed on firehol/netdata repository, a new Docker image is tagged with the same tag name. What do you think?

Alas the netdata image is build from this repository. I don't think hub supports linking two different repositories like that. The only way I see is that the tag information would be transfered to this repository somehow (occasional commit to update tags).

If there's no way to do it directly with the hub we should consider using travis.

But it won't be autoexecuted on firehol's updates... so I'mnot really sure how to do this :confused:

firehol/netdata has a custom webhook that triggers the titpetric/netdata hub build. I'm sure the @ktsaou will add a new one if needed.

Again, I think it is better if the build.sh and all the docker build related scripts are moved to firehol/netdata and a new Docker Hub account and Docker Automated Build is created by @ktsaou. This way, in just a few clicks, tags work and a proper Docker Hub repo is created. But that's just my opinion.

Guys, I am open to help in any way you like.
@titpetric if you want me to add another hook or link the main repo to docker, let me know.

I created the structure and tags for 1.4 and 1.5 versions of netdata. I extended the README.md with information how to add new sections. Ofcourse, when doing all of this I realized that perhaps there's no need for automated builds for these tags, because they are not being actively developed. Most likely it would be enough to pass a TAG ENV to the Dockerfile, and have a local script to build and push older releases of netdata only once. I might change this at some later point.
Any change of firehol/netdata will most likely never trigger a change in the docker hub build, unless the tag was re-created upstream. I don't think that is being done. Most likely, a tag of 1.5.1 should be created for this purpose, and the tag 1.5.0 should not be touched.
@ktsaou if you're using semver to version netdata, I'd suggest tagging them with [major].[minor] along with the [major].[minor].[patch] which you already use. The [major].[minor] tag should be updated to point at the latest [major].[minor].[patch] version. Either that, or have versioned branches for development (ie, like you have for 1.3.0, but don't have for 1.4.0 and 1.5.0?). I asume that master/tags are the current practice of tagging releases, so I completely ignored this branch.

Note: leaving this issue open for a while to gather come feedback/comments. Thank you all.

I asume that master/tags are the current practice of tagging releases, so I completely ignored this branch.

you are right.

if you're using semver to version netdata, I'd suggest tagging them with [major].[minor] along with the [major].[minor].[patch] which you already use. The [major].[minor] tag should be updated to point at the latest [major].[minor].[patch] version

ok, I will do.

Closing issue, so far everything works as expected.

Niiice! 😄


Add support for verifying helm charts using provenance file

Ref: #541

Converting PR to draft, as this is being put on hold until we reach GA (ref: https://github.com/fluxcd/flux2/issues/2592)


Make span in mux, gin internal

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
The span in mux, gin should be internal span instead of http span. These frameworks uses net/http or grpc as the underlying communication framework.
Describe alternatives you've considered
No response
Additional context
No response

Related to #174. We need to suppress those spans.


api/v2: sort silences similarly to v1 api

Sort the queried silences to match behaviour in the v1 api.
Fixes #1781

@simonpasquier I did some more refactoring and added a test, please take a look, thanks!

LGTM


HBase native support

Even a JVM extension is hard to do due to dependency alignment issues and due to the fact that there is no way to configure the component not to connect to the cluster at startup. Here my today's attempt that basically works, but is not good enough to be merged: https://github.com/ppalaga/camel-quarkus/commit/f2401f3feb8563b80b3b72a739b206fdd7017b61

The dependency hell was not that bad after all, at least the extension part - so I solved it with the usual means. The test module was a bit worse due to the mess in the transitive dependencies of hbase-testing-util (used to start the test cluster). For that one, was able to keep dependencyManagement config in the test module.

The native mode is partly finished in #1906, I gave up when I found out that HBase has a shaded Netty.

The shaded Netty is version 3.x and in addition to that there is Netty 4.x in the client class path. Therefore the unshading trick we applied in #2008 won't work here.
I tied with trial and error strategy a bit, but did not come too far without understanding the hbase client internals. Here is my last state: https://github.com/ppalaga/camel-quarkus/tree/i1648.2

HBase was removed in Camel 4.x.


feat: HEAD request response should not have body

This PR bring s the capability to check whether a HEAD request
with status code 200 returns a body or not.
Introducing this rule makes conflict with the rule of status code 200 should contain response body.

@Andras-Csanyi what do you mean "Introducing this rule makes conflict with the rule of status code 200 should contain response body." ?
Is there something we need to address there? We don't want the user to get conflicting messages

Is there something we need to address there? We don't want the user to get conflicting messages

I missed this. Yes, we should update the existing:
content-entry-provided:
  description: Request bodies and non-204 responses should define a content object
  given:
  - $.paths[*][*].responses[?(@property != '204' && @property != '202' && @property != '101')]
  - $.paths[*][*].requestBody
  severity: warn
  formats: ["oas3"]
  resolved: true
  then:
    field: content
    function: truthy

Specifically the path to the responses field:
  - $.paths[*][?(@property != 'HEAD' && @property != 'head' && @property != 'Head')].responses[?(@property != '204' && @property != '202' && @property != '101')]

Unfortunately, the properties are case sensitive, and I don't know of a way to get covert all @property chars to upper/lower for comparison, but the new path should look similar to above.
Revoking approval until we make the above update.

@barrett-schonefeld Would it be simpler to define a function to check all of those conditions?

Would it be simpler to define a function to check all of those conditions?

Although the update to the path is complicated, I think it is preferable to defining a custom function that handles the validation from the path level.
It would complicate things a bit because we would need a custom function that takes a path object, only walks down non-HEAD operations, walks to responses, only walks down non-204, non-202, non-201 responses, and checks if content is truthy.

Okay, good to know! Thanks for the explanation

@dpopp07 and @barrett-schonefeld thanks for the feedback! I apologise not being clear enough how the rules are conflicting.
Let me take a try with the custom function.

 How about validating that the http verbs are must be lowercase? Spectral has inbuilt function for this (casing), so it is easy to validate it.
Once we ensured that the verbs are lowercase (flat), we can simplify (or keep it simple) the condition @barrett-schonefeld sketched previously.
https://meta.stoplight.io/docs/spectral/ZG9jOjExNg-core-functions#casing

Before we go down the custom function rabbit hole let me propose something. How about validating that the http verbs are must be lowercase?
https://meta.stoplight.io/docs/spectral/ZG9jOjExNg-core-functions#casing

Good idea, and I just realized that we already assume lowercase for other rules, so I think we can proceed with this rule by following the same pattern. For example:
content-entry-contains-schema:
  description: Content entries must specify a schema
  given:
  - $.paths[*].[post,put,patch].requestBody.content[*]
  - $.paths[*].[get,post,put,patch,delete].[parameters,responses][*].content[*]
  severity: warn
  resolved: true
  then:
    field: schema
    function: truthy

Hence, for the content-entry-provided rule, I think we can use:
- $.paths[*].[get,post,put,patch,delete].responses[?(@property != '204' && @property != '202' && @property != '101')]

And we can move forward with this PR.

For summarising what should happen:

make changes in the content-entry-contains-schema, so that it doesn't care with case sensitivity when it goes deep other than HEAD verbs
introduce a new rule which validates that http verbs should be lowercase
finish/fix response-head-response-with-content (this name is suggested by @barrett-schonefeld )

1 and 2 possibly can be a separate PR if this one seems to too big already.
What do you think @barrett-schonefeld ?

Closing, not a priority to add this rule, though valid, at the moment


README content wrong for java-docs-samples/taskqueue/deferred/

java-docs-samples/taskqueue/deferred/ README refers to Guestbook....
Is is guestbook or taskqueue?

Notice: this issue has been closed because it has been inactive for 460 days. You may reopen this issue if it has been closed in error.


Add missing using

The example was incomplete; System.Threading.Thread was being referenced without the namespace being properly imported.

Hi 👋 @perlun
Thank you so much for posting this issue. We really appreciate it. Could you please add a C# project to the unloading directory:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net5.0</TargetFramework>
    <StartupObject>test.Program</StartupObject>

</PropertyGroup>

We have a build validation that requires a project to compile from.

@IEvangelist No probs, sounds good so we can avoid compilation issues in these examples going forward. I added a .csproj file, let's hope it passes CI runs this time.

This was bit of a can of worms actually, but I think I have most problems resolved now. After adding the .csproj file, some other compilation errors were discovered. Opening the project in JetBrains Rider didn't work so well, since I didn't have the .NET 5 preview installed. After installing it, things worked much smoother and I could fix most of these, but...
...the TestAssemblyLoadContext name is being overloaded in two of these examples, which aint going to work. One of them would need to be renamed. Which one should I rename? Are there any references to the class names there (in the actual docs) that has to be fixed as well?
(Btw, https://dotnetcli.blob.core.windows.net is really slow where I am (400 KiB/s on a 100 Mbit connection), would be good to put up this behind a proper CDN like I presume the official downloads are. :sunglasses:)

Good to know, I'd be good with you adding a namespace for each of these.

@IEvangelist

Good to know, I'd be good with you adding a namespace for each of these.

You've got it, compiles fine locally now. :+1:


[Snyk] Upgrade react-router-dom from 6.4.1 to 6.4.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade react-router-dom from 6.4.1 to 6.4.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released a month ago, on 2022-10-05.

Release notes

Package name: react-router-dom

6.4.2 - 2022-10-05

6.4.2-pre.1 - 2022-10-04

6.4.2-pre.0 - 2022-09-30

6.4.1 - 2022-09-21

    from react-router-dom GitHub release notes

Commit messages

Package name: react-router-dom

92425b8 chore: Update version for release
171c34a chore: exit prerelease
1317087 chore: Update version for release (pre) (#9395)
9e9a90b fix: make hasErrorelement optional on types (#9394)
718743e Merge branch 'release-6.4.2-pre.0' into dev
5905109 chore: Update version for release (pre) (#9380)
8359631 Enter prerelease mode for 6.4.2
b19a80b fix: detect and error on invalid pathnames (#9375)
540f94b fix: Strengthen route typings  (#9366)
434003d fix: respect basename in useFormAction (#9352)
779d4af fix: update matchPath to avoid false positives on dash-separated segments (#9300)
9e386f5 fix: reset actionData state on redirection from an action (#9334)
0a00110 feat: better handle throws in queryRoute (#9353)
d8e6d7f docs: add better docs and console errors for data router features (#9311)
41c0491 chore(CI): skip GitHub release creation
98161c9 chore: remove old changesets package + fix patch version
9d983b6 chore: sync contributors

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Updated separately.


Fix CI by upgrading to operator-sdk version

golangci-lint breaks because go list fails due to `thrift` package
issue; see: https://github.com/golang/go/issues/34016 and later due to
another issue https://github.com/golangci/golangci-lint/issues/658 for
which a release of golangci-lint is yet to be made.
This patch fixes these by moving to operator-sdk version 0.10 and by
installing (go get) latest golangci-lint

Signed-off-by: Sunil Thaha<EMAIL_ADDRESS>

/test e2e

/lgtm
@sthaha should this be done upstream too ? 👼

Thanks, that is a good point! .. shall submit one upstream.

/lgtm


Select2 won't update if the option array is changed

The component is called as follows:
<values selected="{{values}}" options="{{fieldValues[field]}}"/>

the [field] part of fieldValues[field] is dynamically updated by another component, resulting the options parameter to change.
Component content:

<select decorator='select2' value='{{selected}}' multiple="{{multiple}}" style="width:300px">
    {{#options}}
        <option value='{{.}}'>{{.}}</option>
    {{/options}}
</select>
<button on-click='reset-data'>Reset (two-way binding)</button>

Selected option: {{selected}}

The select2 html is not updated, although the last line {{selected}} is updated properly. Also, if I don't use the decorator, it works fine with regular select boxes.
After some more digging I created the following solution which can be placed in the decorator:
if (node._ractive.binding) {
        observer = ractive.observe('options', function () {
                if($(node).data('select2') !== undefined){
                    console.log('destroy');
                    $(node).select2('destroy');
                    window.setTimeout(function () {
                        $(node).select2();
                    },0);
            }
        });
    }

It will destroy and rebuild the decorator if the options are changed.

This is better:
if (node._ractive.binding) {
    observer = ractive.observe('options', function () {
            if($(node).data('select2') !== undefined){
                window.setTimeout(function () {
                    $(node).select2();
                    $(node).select2('destroy');
                },0);
        }
    });
}

And even better:
if (node._ractive.binding) {
  observer = ractive.observe('options', function () {
        if($(node).data('select2') !== undefined){
            window.setTimeout(function () {
                $(node).select2();
                $(node).select2('destroy');
                $(node).select2('val','');
            },0);
    }
});

}

That's a really dirty workaround. You're destroying and recreating the entire select2 element every time any of the options changes. That causes FoUS and performance issues.
It would be much better to update the select2 options directly, but that seems to be a work in progress: https://github.com/select2/select2/issues/2830
Sorry, but I can't put it in the decorator like this. When select2 allows modifying options through the API then I will be happy to add support for that though.


Flav/add user to app log

Description

The investigation into missing permissions for enforcing the correct group permissions to read from a data source revealed an issue with the public API for posting a message. This PR modifies those two endpoints to use keyAuth instead of workspaceAuth. This change is safe because an early check ensures that the workspaceId in the URL (wId) matches the one associated with the key.
Risk

Deploy Plan

PMRR.


BREAKING: grape color is no more

Version 1.5.0 renamed the grape color to purple. This is a breaking change. Please bring back grape as a duplicate of purple or release version 2 to denote the breaking change.

Also, new npm releases don't show up on the releases page.

you're right, it was breaking, and a major version should have been changed. i also need to setup git release publishing. let me think on this some more though. thanks for creating the issue.


Update draft references to draft-irtf-cfrg-opaque-08

A bunch of places (docs, README) still reference "draft-irtf-cfrg-opaque-05", which should be updated to the latest on https://datatracker.ietf.org/doc/draft-irtf-cfrg-opaque/, which is version 08.

Just wanna note that it's version 8 since march 7th.

Closed by #271


Exported game crashes due to missing resources while in-editor it runs fine

Tested versions

Reproducible in v4.2.1.stable.official.b09f793f5 (December 2023)
Not reproducible in v4.0.3.stable.official.5222a99f5 (May 2023)
Was a problem for 12+ months already some time before May 2023, most likely before 4.0 stable release.

System information
Arch Linux, KDE 5, Radeon RX6800XT, X11
Issue description
Testing my game from the editor works fine. But after exporting a game build from a template, the build throws errors about missing stuff and boots the game to a gray screen, with almost nothing working.
Swapping the engine runtime for the Godot editor doesn't make a change.
The only way to make a playable release of the game is to package all the game files together with the Godot runtime and distributing that - which is what I was doing for (I think) at least a year when a similar problem was present in Godot game exports.
It seems like the problem is strictly with the generated .pck or .zip file (I tested both).
This is the last game build I made that didn't have this problem:

You can download it here: https://libla.st/downloads/Liblast_dev.zip (it might be replaced in the future with a newer version so check the modification dates inside of the ZIP file).
I unfortunately can't test the exact same project in an older version of Godot, but the older versions of the game can be accessed from Liblast's git repository on Codeberg:
http://code.libla.st
So presumably if you clone and checkout the main branch at a commit from circa May 2023 it should build fine in Godot 4.0.3 stable. I didn't test this yet - anybody is welcome to try! Just remember to clone the repository - not download ZIP - Git LFS-stored files are essential for the game to work and will not be included in a source code archive download, making it a red herring. I wish I could disable that option...
I think this must be a regression at least in some degree, At first I thought maybe it's a bug in the feature to export only selected resources, but after switching to exporting everything the game build still fails in the same way.
Here's complete console output as I run the game, open it's internal console (the only feature of the game that works) and stop the game from there:
❯ ./Liblast.x86_64
Godot Engine v4.2.1.stable.official.b09f793f5 - https://godotengine.org
Vulkan API 1.3.255 - Forward+ - Using Vulkan Device #0: AMD - AMD Radeon RX 6800 XT (RADV NAVI21)

ERROR: No loader found for resource:  (expected type: CompressedTexture2D)
   at: _load (core/io/resource_loader.cpp:282)
ERROR: Failed loading resource: res://Assets/Characters/CharacterHeavy_ID_Mask_Processed.png. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:274)
ERROR: Can't load dependency: res://Assets/Characters/CharacterHeavy_ID_Mask_Processed.png.
   at: parse_variant (core/io/resource_format_binary.cpp:459)
ERROR: Failed loading resource: res://.godot/exported/133200997/export-f77c830eaf23cebf5c54d514cb2310e1-CharacterBodyShader.res. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:274)
ERROR: No loader found for resource:  (expected type: CompressedTexture2D)
   at: _load (core/io/resource_loader.cpp:282)
ERROR: Failed loading resource: res://Assets/Characters/CharacterHeavy_ID_Mask_Processed.png. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:274)
ERROR: Can't load dependency: res://Assets/Shaders/Characters/CharacterBodyShader.tres.
   at: parse_variant (core/io/resource_format_binary.cpp:459)
ERROR: Failed loading resource: res://.godot/exported/133200997/export-fccab72fc104c99a9db8ddc636649342-CharacterBody.res. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:274)
ERROR: Can't load dependency: res://Assets/Materials/Characters/CharacterBody.tres.
   at: parse_variant (core/io/resource_format_binary.cpp:459)
ERROR: Error when trying to parse Variant.
   at: parse_variant (core/io/resource_format_binary.cpp:503)
ERROR: Error when trying to parse Variant.
   at: parse_variant (core/io/resource_format_binary.cpp:490)
ERROR: Failed loading resource: res://.godot/exported/133200997/export-acf2a845315cc13706608f268e070e12-Character.scn. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:274)
Log file name: 2023-12-18_231655.log
 · 2023-12-18 23:16:55          658 | Liblast log start
WARNING: UPnP didn't find a Gateway
     at: push_warning (core/variant/variant_utility.cpp:1111)
ERROR: Failed to instantiate scene state of "res://Assets/Characters/Character.tscn", node count is 0. Make sure the PackedScene resource is valid.
   at: instantiate (scene/resources/packed_scene.cpp:141)
ERROR: Failed to load scene dependency: "res://Assets/Characters/Character.tscn". Make sure the required scene is valid.
   at: instantiate (scene/resources/packed_scene.cpp:222)
ERROR: Failed to load scene dependency: "res://Assets/Menu/CharacterProfilePreview.tscn". Make sure the required scene is valid.
   at: instantiate (scene/resources/packed_scene.cpp:222)
ERROR: Failed to load scene dependency: "res://Assets/Menu/UserProfileMenu.tscn". Make sure the required scene is valid.
   at: instantiate (scene/resources/packed_scene.cpp:222)
ERROR: Failed to load scene dependency: "res://Assets/Menu/MainMenu.tscn". Make sure the required scene is valid.
   at: instantiate (scene/resources/packed_scene.cpp:222)
ERROR: Parameter "p_child" is null.
   at: add_child (scene/main/node.cpp:1409)
 · 2023-12-18 23:17:25        31246 | console command: quit
 · 2023-12-18 23:17:25        31253 | Liblast log finish
 · 2023-12-18 23:17:25        31253 | stopping server
Cleaning up game state
 · 2023-12-18 23:17:25        31253 | cleaning up game state
WARNING: Trying to free a non-existing GameState
     at: push_warning (core/variant/variant_utility.cpp:1111)
ERROR: 1 RID allocations of type 'P11GodotBody3D' were leaked at exit.
ERROR: 13 RID allocations of type 'P12GodotShape3D' were leaked at exit.
ERROR: Pages in use exist at exit in PagedAllocator: N33RendererSceneRenderImplementation22RenderForwardClustered32GeometryInstanceForwardClusteredE
   at: ~PagedAllocator (./core/templates/paged_allocator.h:170)
ERROR: 17 shaders of type SceneForwardClusteredShaderRD were never freed
   at: ~ShaderRD (servers/rendering/renderer_rd/shader_rd.cpp:841)
ERROR: 2 RID allocations of type 'N10RendererRD5SkyRD3SkyE' were leaked at exit.
ERROR: 2 RID allocations of type 'N26RendererEnvironmentStorage11EnvironmentE' were leaked at exit.
ERROR: 2 shaders of type CanvasShaderRD were never freed
   at: ~ShaderRD (servers/rendering/renderer_rd/shader_rd.cpp:841)
ERROR: 4 shaders of type ParticlesShaderRD were never freed
   at: ~ShaderRD (servers/rendering/renderer_rd/shader_rd.cpp:841)
ERROR: 15 RID allocations of type 'N10RendererRD12LightStorage11ShadowAtlasE' were leaked at exit.
ERROR: 1 RID allocations of type 'N10RendererRD12LightStorage23ReflectionProbeInstanceE' were leaked at exit.
ERROR: 2 RID allocations of type 'N10RendererRD12LightStorage15ReflectionAtlasE' were leaked at exit.
ERROR: 1 RID allocations of type 'N10RendererRD12LightStorage15ReflectionProbeE' were leaked at exit.
ERROR: 1 RID allocations of type 'N10RendererRD12LightStorage13LightInstanceE' were leaked at exit.
ERROR: 1 RID allocations of type 'N10RendererRD12LightStorage5LightE' were leaked at exit.
ERROR: 24 RID allocations of type 'N10RendererRD11MeshStorage4MeshE' were leaked at exit.
ERROR: 39 RID allocations of type 'N10RendererRD15MaterialStorage8MaterialE' were leaked at exit.
ERROR: 23 RID allocations of type 'N10RendererRD15MaterialStorage6ShaderE' were leaked at exit.
ERROR: 13 RID allocations of type 'N10RendererRD14TextureStorage12RenderTargetE' were leaked at exit.
ERROR: 123 RID allocations of type 'N10RendererRD14TextureStorage7TextureE' were leaked at exit.
ERROR: 180 RID allocations of type 'N18RendererCanvasCull4ItemE' were leaked at exit.
ERROR: 13 RID allocations of type 'N18RendererCanvasCull6CanvasE' were leaked at exit.
ERROR: 13 RID allocations of type 'N16RendererViewport8ViewportE' were leaked at exit.
ERROR: 3 RID allocations of type 'N17RendererSceneCull8InstanceE' were leaked at exit.
fish: Job 1, './Liblast.x86_64' terminated by signal SIGSEGV (Address boundary error)

Steps to reproduce

Access the game project via git.

You can follow the paragraph in our README: https://codeberg.org/liblast/liblast#_how_to_edit_the_game , or (if you're on Linux) just execute this:
cd ~/
git clone https://codeberg.org/Liblast/Liblast.git`
cd Liblast
git lfs install
git lfs pull

Now load the game project located in Liblast/Game/project.godot using Godot 4.2.1.
Play the game from the editor (hit F5 after the project loads)
Do you see and hear things outside of a gray void?
Now export the game (ensure you have the export templates first, like you always do).
Run the exported game build.
Do you see and hear things outside of a gray void?

Minimal reproduction project (MRP)
:man_shrugging:

By quick peeking at your export settings (https://codeberg.org/Liblast/Liblast/src/commit/cb617c17223d672ef972735f35765fa644942833/Game/export_presets.cfg#L25), it seems you have BPTC texture compression format disabled, which seems to be a requirement when you have S3TC enabled (https://github.com/godotengine/godot/issues/81234, https://github.com/godotengine/godot-proposals/issues/7230 and https://github.com/godotengine/godot/pull/84913/)

By quick peeking at your export settings (https://codeberg.org/Liblast/Liblast/src/commit/cb617c17223d672ef972735f35765fa644942833/Game/export_presets.cfg#L25), it seems you have BPTC texture compression format disabled, which seems to be a requirement when you have S3TC enabled (#81234, godotengine/godot-proposals#7230 and #84913)

Thanks! I am not sure if I ever touched that, but this project has a long history with Godot 4, so it's entirely possible that defaults changed and things got shifted around. I'll try to set that to defaults and see if that has any effect,.

Oh dear, this is the case. Enabling BPTC fixed this.
I think Godot needs make it much harder for the user to completely screw themselves up here.
If it's a known requirement, maybe disable the control for BPTC in the "enabled" state when S3TC is on or something... show a warning sign nearby like in the node tree explorer...


Email input

Description
This PR includes the following proposed change(s):

Added email input to CSO Account creation page

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
yarn lint
yarn test -u
yarn test

Does the change impact or break the Docker build?

[ ] Yes
[x] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[ ] No

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes

Alex asked me to complete this ticket yesterday, but I had errors committing/merging this branch.    That PR was merged yesterday so this PR can be closed.
Great work on this.


Full screen modal

Please add Full screen modal :blush:

can you add some more details. Maybe some references to material design examples. If you want to request a feature giving as much detail as possible helps the process.

appending effect more like this
full screen modal example
more specific example (Last one)

Like this?
<style>
.modal.open{
	width: 100%;
	max-height: 100%;
	height: 100%;
	top: 0 !important;
}
</style>

@chi-bd  .model-content also need to be tweaked, to move modal-action on bottom
.modal-content {
  height: calc(100% - 56px);
}

And still, the close animation works bad. See http://codepen.io/kmmbvnr/pen/pbVZdJ

@wupadach 's second example is epic.

Moved to feature request board.

Hi boys, my implementation, i and the my team uses this solution:
 .modal.full {
      width: 100vw;
      max-height: 100vh;
      height: 100vh
  }

the .full class is add in all project.

Isn't 100vh a bit too high?


Task 3 Turn-in

**Please turn in your task 3 here, by providing **

a link to your repo.
team name and team members.
the option you worked for the task 3.
notes that one needs to know, in order to replicate your experiment.

For example,

Submission: https://github.com/csce585-mlsystems/project-athena
Team: ATHENA
Members: Pooyan Jamshidi, Ying Meng, Jianhai Su
Option: Generate Adversarial Examples in White-Box

Please organize your submission in a folder named Task3 and organize files in the following structure:
Task3
  |-- video
  |-- slides (if there are any)
  |-- any other materials

Submission: https://github.com/Dojones98/project-athena
Team: Clutch
Members: Ravi Patel, Praful Chunchu, Daniel Jones, Austin Staton

Notes: The task 3 folder has two markdown files in it, one title "video" and the other titled "slides." These files contain the links to the video and slides respectively.

Submission: https://github.com/Kronemeyer/project-athena/tree/master/Task3
Team: Minerva
Members: Oliver Mills, Deja Scott, Benjamin Ritz, Benjamin Kronemeyer
Similar to above submission, ours are links inside of markdown files.

Submission: https://github.com/andrewwunderlich/project-athena/tree/master/Task 3
Team: doubleE
Members: Andrew Wunderlich, Miles Leonard-Albert, Jay Desai
We elected to submit the files directly in the repo rather than post links.  The video ran longer than 5 minutes, but we kept it to just under 10 minutes and felt that we couldn't cut it down any further without skipping important information.

Submission: https://github.com/Arleycht/project-athena/tree/master/Task3
Team: LANS
Members: Landin Thorsted, Alex Tsai, Nick Bautista, Yiqian Sun

Submission: https://github.com/cjshearer/project-athena/blob/master/Task3/
Team: Ares
Members: Cody Shearer, Zhymir Thompson, Mahmudul Hassan, Vincent Davidson
I just put the links for the slides and the video in the same markdown file.

Submission: https://github.com/Kronemeyer/project-athena/tree/master/Task3
Team: Epsilon
Members: Andrew Smith, Stephen Baoine, Naga Venkata Sai Jagjit (JJ) Satti
I put the links for the slides and video in markdown files in their respective folders.

Submission: https://github.com/Jacob-L-Vincent/project-athena.git
Team: JIR
Members: Jacob Vincent, Isaac Keohane, Raul Ferraz
Links to videos and google slides are in .txt files in task 3 folder. There is also a .pdf of the slides in the task 3 folder as well.

Submission: https://github.com/Team-Horus/Task3
Team: Horus
Members: Withana Jayarathna, Kaveh Shariati, Olajide Bamidele, Joshua Ojih

the assignment is due.


Support of Twig 2.*

It would be great to have ability for upgrade Twig at least to the 2.0.* version in projects with phpDocumentor.
Expected Behavior
Expects that composer json supports 1.3 and  2.* version of Twig.
Actual Behavior
Currently used Twig version is ~1.3 and it  is little outdated.
If it is not possible for some reasons, please tell when such changes could be made.
Thanks.

I second it. Nothing worse than having to use outdated dependencies or having to juggle versions for legacy support reasons. Wouldn't've been that bad if I wasn't using Twig in my project, but I am.
And having a choice between PHPDoc and Twig, unfortunately, up-to-date Twig wins.

I have just tried to do the upgrade but because we re-set the Extensions in each pass of the writer an upgrade is not easily doable. This trick is not allowed in Twig 2.
The situation that you describe is why we recommend using the phar file or the docker based setup to generate your documentation. phpDocumentor contains too many dependencies that may conflict with your particular setup for use to accommodate everyone.
Even by upgrading Twig to version 2.0 we may be causing issues for people using Twig 1.3 in their projects.
I had hoped that with a quick upgrade that we would help you out there, but because it takes effort we could use to fix bugs without a direct ROI I am afraid we are unable to do this at this time.

So we just cannot use phpdocumentor with composer ? Very nice, good job !!!
And if all our project use composer, we have to install this old and unused pear/pecl to use phpdoc ? Supid choice....
I'll never use again phpdoc so...

Use the PHARs, Luke...
The PHARs will be with you, always...
Don't underestimate the PHARs...


Request to analyze only certain packages from the command line

Hi,
Would it be possible to add a command-line argument for the analyzer, to let us say, effectively, "please analyze packages, but ONLY these packages"
Right now, we can use --package-warnings, but that pulls in too many errors/warnings from packages we know are violating the analyzer.
Ideally, something like: --package-warnings=foo,bar would be very helpful!

That sounds possible, but could you move this issue over to the analyzer_cli repository? (Someday I need to figure out how to do that myself.)

search for "github issue mover" and you'll land on https://github-issue-mover.appspot.com/
Meanwhile, I'll do it for this one.
Thanks for the review.

This issue was moved to dart-lang/analyzer_cli#58


Upgrade maven-gpg-plugin 3.2.0 -> 3.2.1

This PR contains the following updates:

Package
Type
Update
Change

maven-gpg-plugin
build
patch
3.2.0 -> 3.2.1

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade maven-gpg-plugin 3.2.0 -> 3.2.1

See:
- https://github.com/apache/maven-gpg-plugin/releases/tag/maven-gpg-plugin-3.2.1
- https://github.com/apache/maven-gpg-plugin/compare/maven-gpg-plugin-3.2.0...maven-gpg-plugin-3.2.1


Fix for Issue 203

Fix for issue: https://github.com/lucidrains/x-transformers/issues/203

Thank you Anthony!


Merge release-2.0.x to main.

CI for this should fail due to the current test breakage in main (will be fixed soon).


[docs] Add info about passing objects to contains and notContains assertions

\cc @DevExpress/testcafe-docs
fixes #1740

@testcafe-build-bot \retest


Update [Getting Started with sklearn notebook] with proper logic

The notebook https://learn.microsoft.com/en-us/azure/databricks/_static/notebooks/getting-started/get-started-sklearn-7.3.html has the training function like below:

search_space = {
  'max_depth': hp.quniform('max_depth', 2, 10, 1),
  'n_estimators': hp.quniform('n_estimators', 200, 1000, 100),
  'max_features': hp.quniform('max_features', 3, 8, 1),
}

def train_model(params):

  # Create and train model.
  rf = RandomForestRegressor(n_estimators = n_estimators, max_depth = max_depth, max_features = max_features)
  rf.fit(X_train, y_train)

  predictions = rf.predict(X_test)

  # Evaluate the model
  mse = mean_squared_error(y_test, predictions)

  return {"loss": mse, "status": STATUS_OK}

This does not sound accurate as this function is supposed to be called by HyperOpt hence RandomForestRegressor should be initialised using the dynamic parameters not just point to values of variables defined before which are static.
IMO, the function should look like this:

search_space = {
  'max_depth': scope.int(hp.quniform('max_depth', 2, 10, 1)),
  'n_estimators': scope.int(hp.quniform('n_estimators', 200, 1000, 100)),
  'max_features': scope.int(hp.quniform('max_features', 3, 8, 1)),
}

def train_model(params):

  # Create and train model.
  rf = RandomForestRegressor(random_state=0, **params)
  rf.fit(X_train, y_train)

  predictions = rf.predict(X_test)

  # Evaluate the model
  mse = mean_squared_error(y_test, predictions)

  return {"loss": mse, "status": STATUS_OK}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4cac26cd-ab9e-dec0-45b7-4add1f9c6fc9
Version Independent ID: 4cac26cd-ab9e-dec0-45b7-4add1f9c6fc9
Content: Get started with scikit-learn in Azure Databricks - Azure Databricks
Content Source: databricks/machine-learning/train-model/sklearn-tutorial.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@ylashin
Thanks for your feedback! We will investigate and update as appropriate.

@mssaperla
could you please review this and update as appropriate.

@ylashin
Thanks for your feedback! We have assigned the issue to author and will provide further updates.

Thanks for your dedication to our documentation. Unfortunately, we have been unable to review your issue and apologize for the delayed response. The requested updates have not yet been made. The timeline for resolution varies based on resourcing. We've created an internal work item (DOC-7741) to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

#please-close


error in JavaScript for nanoPlot (Lab, Python)

See http://localhost:8888/notebooks/doc/python/PlotJSAPI.ipynb notebook
code for nanoPlot doesn't work and displays the message: "Big is not defined - please check console"

@EfimovVladimir  look here: https://github.com/twosigma/beakerx/blob/master/doc/javascript/usingExternalLibs.ipynb

@piorek thanks, it helps

hm, it works only on jupyter notebook, not on JupyterLab

@EfimovVladimir looks like you added only first of the two needed.
It is not needed in classical notebok because Big.js is already in global scope.
%%javascript
require.config({
    paths: {
        'big': '//cdnjs.cloudflare.com/ajax/libs/big.js/5.2.2/big'
    }
});

%%javascript
require(['big'], function(Big) {
    window.Big = Big;
});


Model unable to learn when to stop

Hi! I am training on my own data on a pre-trained model. sampling rate of dataset is 22050, batch size is 24, even after 3000 iterations, every time output result is of fixed length. I guess it is not learning when to stop. And the results are just noises.

Does the validation loss dropping? I suppose you can keep training until 10k and see if there's any alignment in between the two mel cepstrum outputs. If it doesn't converge probably your data isn't "clean" enough.
My previous dataset was not properly aligned which causes the model unable to find a good stopping boundary after training for 30k iteration.

No, the validation drop doesn't reduce either.

@akshitmittal1  Any screenshots about the tensorboard loss graph?

@theblackcat102 I put the model on training again, this time model perfectly learns when to stop. The thing I changed was reduce the learning rate. The results are good in terms of pronunciation but there are background noises and slight blurryness in the voice. I think that's because of my data. Still, can you suggest me anything which I can do to reduce the background noises


creating custom media types

I want to enhance/change the current HTML media to add more components to it than just the image, and use my own css and feed data per each slide
Is this possible? if so, can you explain the process I would go about doing this?
Thanks

Have a look at the "js/media" folder. You can copy one of those and alter it. After that, including it to the webpage should be all you need to do.


Dark mode in combination with group tabs is not readable

When using dark mode and group tabs the text inside the tabs is not visible
for an example see here

Thanks for reporting this.
Is this using the sphinx-tabs library?

@dantownsend yes it is

Looks like sphinx-tabs explicitly sets the background colour to white.
I'd add this to your CSS file, and it'll fix it:
.sphinx-tabs-panel {
    background: none;
}

We could add this override to the Piccolo theme, but it feels a bit fragile overriding the styles of other libraries.
It looks like they do support a dark theme by adding  data-theme="dark" to the body tag. That's probably the best solution, though it does tie us to a third party library.
https://github.com/executablebooks/sphinx-tabs/blob/9431223384729010ba29c27c2d2976ce76b7e1ad/sphinx_tabs/static/tabs.css#L76

@dantownsend thanks that worked


SignedData Verifier

Add services for apps to create and verify signed data objects, i.e. trust lists, value sets and business rules. This extends the format previously used for the trust list, i.e. a CBOR encoded content blob and a detached COSE signature blob.

Why not typealias ContentAndSignature = Pair<ByteArray,Bbytearray>? and two delegated extension properties (on that specific type alias)? Saves custom equals and hashCode…

Because then one wouldn't know if first is the content, or first is the signature, right?

was thinking about something like this:
typealias SignedData = Pair<ByteArray,ByteArray>
val SignedData.content: ByteArray get() = this.first
val SignedData.signature: ByteArray get() = this.second


Transparent PNG

Hello, is there some way how to show white background under the transparent PNG img element with let say 20px padding?
I've tried ::before class on img, but it's not working. Then I've tried set background color on hb-image-div, but this div is 100% width.
Thanks
Your demo with PNG:

@vojtasvoboda
Hello. I think you should try this,
.hb-image-div img {
    background: white;
}

It should work. Thanks.

Great it works well, thanks :-)


1G management speed setting

provide speed setting for 1G management port. Force it to run @ 100M or force to run @1000M

3 Settings

auto/auto
100m/full/autoneg off
10m/full/autoneg off

done

setting via
/opt/fmadio/etc/network.lua
["eth0"].Speed = "100m"
["eth0"].Speed = "10m"
there is no GUI option


add 'unknown' status for some data that might be unavailable

For games like iRacing which don't expose a full dataset, set things like tyre condition to 'unknown' rather than defaulting to 'new' and maybe add a "we don't have access to that information" response. Currently asking about tyre condition and damage in iRacing will always respond as if the tyre / component is fine. Even when it isn't

for the specific cases mentioned in the original complaint ("tyres are fine" when the app has no idea) I've fixed the code so, for iRacing, it gives a 'no data' response. Closing this for now, might need to reopen


Tooltip does not show on invalid title, improve documentation?

Nightly build: Date: Tue Feb  7 13:29:42 2012
The documentation regarding to Title.text states:

Custom functions that return no valid content will still cause the tooltip to be created! Replace these with an each() loop if this is not the desired behaviour.
If no valid content is provided, the title will not be created.

My tootlip however is not created when my custom function returns Null.
Example: there is no title attribute. The tooltip will not be created
title: function(api) {return $(this).attr('title');}

The tooltip however is created when it returns False. So my custom function should look like:
title: function(api) {return $(this).attr('title') || false;}

I favour improving the code but improving documentation would help others as well

This is now fixed in the latest commits to abide by the documentation's rules. Cheers javinto!


feat: REST API for Hub

Motivation
Our Hubs currently operate using a gRPC API. While gRPC is efficient, it presents several challenges:

It's difficult and non-intuitive to use.
Constructing protobufs for query arguments can be cumbersome.
The API isn't universally accessible, especially from browsers.

This proposal suggests implementing a REST API for the hubs. The advantages of a REST API include:

They can be easily accessed from various platforms, including browsers and using tools like curl.
No additional dependencies (like protobufs) are needed to interact with them.
They are simpler to understand, deploy, and debug.

Implementation Details:

The REST API will coexist with the current gRPC API and will be served on a new port (2181).
The REST API will internally call the gRPC API, ensuring consistent data returns. The REST API will not introduce any additional business logic. gRPC responses will be automatically converted to JSON using protobufjs, which is already part of our stack.
Errors will also be presented as plain JSON objects. Callers are expected to parse the JSON to extract error details. Additionally, HTTP response codes will be set to reflect the nature of the error.

Differences from the gRPC API

These APIs will be NOT be available in the REST API

Admin API
Sync Methods

The "Bulk" methods in gRPC are integrated into standard endpoints in the REST API (for instance, bulk requests for casts can be made from the /casts endpoint).
We won’t implement the subscribe method to get Hub events.

Pros & Cons:
Pros:

REST is more intuitive and easier to understand, invoke, deploy, debug, and consume.
Protobufs returned will be automatically converted to JSON, simplifying the REST server implementation. By calling the gRPC API internally, both APIs will inherently remain consistent.

Cons:

JSON responses can be verbose, leading to increased network overhead.
There will be a need to maintain and synchronize documentation between the REST and gRPC APIs.
No push mechanism, so users will be expected to poll for Hub events (i.e, no direct replacement for the gRPC’s subscribe method)

API Specification:

Except for the /message endpoint (which uses POST), all API calls are made with the GET method.
The API returns plain JSON objects. When multiple objects are to be returned, they are encapsulated within arrays.
Endpoints returning multiple objects support pagination:

pageSize and an optional nextPageToken can be provided.
Responses include a nextPageToken for fetching subsequent pages. If this token is undefined, no more pages are available.
Objects returned are usually sorted. To reverse the sort order, use reverse=1.

Various endpoints accept filters such as link_type or target_fid as URL parameters. Multiple filters can be applied concurrently, and they are processed sequentially.
Endpoints are prefixed with the API version number, v1. For instance, the endpoint to submit a message is /api/v1/message.


URL in description and README broken

The URL in the repository description and the one in the README are pointing to githubschool's copy of the game instead of yours.
Please fix both so they point to your copy of the game at https://githubschool.github.io/github-games-idmarjr

Fix: https://github.com/githubschool/github-games-idmarjr/commit/935ec02bb41e684011b5113185d3152b772b9a11


Specify rust crate name when installing from git

A repo can contain multiple crates and binaries. They install by cargo install --git [url] [crate]. It looks like you cannot do this in mise.

duplicate of https://github.com/jdx/mise/issues/2963


tests/vm_test.go: Use libvmi and refactor

What this PR does / why we need it:
Use libvmi in tests/vm_test.go and do the following refactorings:

Inline newVirtualMachine and NewRandomVirtualMachineWithRunStrategy
Rename import of virtctl to allow variables named 'vm'
Remove duplication of createVirtualMachine()
Deduplicate VM creation and JSON serialization
Refactor startVM and stopVM
Use Eventually where possible
Use appropriate matchers in virtctl tests
Consistently name variables across file
Use const and type inferring where possible
Fix typos and whitespace
Replace deprecated call to ioutil.TempFile

Release note:

None

/cc

/retest

/retest

/retest-required

@dankenigsberg @rmohr I addressed your comments, WDYT?

/retest

/retest

/retest

@akrejcir @rmohr @xpivarc I replaced MatchUnstructuredBool and MatchUnstructuredSlice with Field(matcher types.GomegaMatcher, fields ...string). WDYT?

/retest

/retest

@xpivarc Updated and rebased the PR and tried to split the changes into more commits. It is still massive, but hopefully the splitted commits make it easier to review?

/cc @lyarwood

/retest

@EdDev Do you want to have a look first?

Ping @xpivarc @EdDev
/retest

Ping @xpivarc @EdDev /retest

I will try to go over this proposal this week, sorry for the delay in the response.
/cc

/retest

/retest

/test pull-kubevirt-e2e-arm64

/approve


Examine HCI Test Messages Part 2

User Story

As a sender to ReportStream, I want to ensure all my messages are transmitted to the appropriate sender losslessly.
Description/Use Case

We have received a set of sample messages from the sender. This folder includes:

moreSampleResults_20231115.txt - the original file sent from the sender. This contains multiple HL7v2 messages pasted in a single file. The messages come in pairs, labelled "Original" and "Transformed". Original means the messages was sent by ProPhase to HCI, and Transformed means the message HCI received was updated to follow the HL7v2 NIST ELR spec and is what ReportStream will receive. The HL7v2 messages have been broken out of this file into their own separate files, labeled "prophase" and "hci" respectively.
msg_<n>_<hci/prophase>.hl7 - a standalone HL7 message. RS should only have to process the messages from hci, the prophase ones are there for reference only.

We should run all the HCI messages through the pipeline and compare that the output message from RS is not missing any important data that exists in the input message. We should also document any differences between the input and output and fix them if it makes sense. All differences should be documented in a spreadsheet or file in the folder containing the sample messages
Risks/Impacts/Considerations

Dev Notes

Acceptance Criteria

[ ] Messages processed. Differences documented and/or fixed.

Hey team! Please add your planning poker estimate with Zenhub @arnejduranovic @jalbinson @JessicaWNava @jimmyfagan @thetaurean

Please add your planning poker estimate with Zenhub @JFU-NAVA-PBC

The msg_1_hci.hl7 message gets the following error when I submit it as is: Required field missing: A datatype for OBX-5 must be specified in OBX-2.

Differences documented here: https://docs.google.com/document/d/1i4dMY3NCZ5FSR9M4XUVjYOk5_OdqT1LhnnX6TP4VvC0/edit?usp=sharing


Remove Array JSX "children" argument

Also some other things:

no more key warnings for normal usage
React.Basic no longer depends on React.Basic.DOM
displayName
rename react to reactComponent
add new react which behaves more like React.Basic.DOM components
(simpler api for PureScript-only components by pre-applying
createElement)
React 16 support

Closes #14

Definitely changed more than I originally set out to, but a lot of the changes seemed complement each other.

I don't know that I have any major complaints with these changes, but I think my personal preference is the current api of element {props} [children]. That just may be my opinion though.


Add new browser image node14.17 with Chrome 99 and FF 98

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Maximus1285 did you build this according to the guide in CONTRIBUTING.md? I don't see a buildspec.yml and the circle.yml is referencing the included/9.5.2 image. Those files are auto-generated when you run the script, and if they are wrong the image won't build properly to Docker or ECR.
Re-running yarn add:browsers -- 14.17.0 --chrome=99.0.4844.51 --firefox=98.0 should generate the correct files.

Hi @admah , thanks for reviewing. I have made the required changes. Hopefully, I got it right this time around.

@admah can you please take a look at this?


Bancor V3 (Schema Version 1.3.0, Subgraph Version 1.0.0, Methodology Version 1.0.0)

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/bancor-v3-ethereum&tab=protocol

Date Reviewed
8/10/2022

Schema Version
1.3.0

Subgraph Version
1.0.0

Methodology Version
1.0.0

Protocol |   |   |   |
-- | -- | -- | -- | --
Section | Value | Status | Check Type | Comments
financialsDailySnapshots | totalValueLockedUSD | not ok | Public data | The latest TVL subgraph data has around 87%  discrepancy with Defi Llama data and Dune. Is this including the value of BNT?
financialsDailySnapshots | dailyProtocolSideRevenueUSD | not ok | Public data | Total revenue looks accurate, double check if the protocol cut is accurate as well. Seemed low but could be what the protocol is making.
financialsDailySnapshots | cumulativeProtocolSideRevenueUSD | not ok | Public data | See analysis under 'dailyProtocolSideRevenueUSD'
Pool Overview |   |   |   |
-- | -- | -- | -- | --
TVL |   | not ok | Public data |  the subgraph TVL data have massive discrepancies ranging from 54.15% to 96.39% with official website data. could be contributing to the TVL issue.
Pool |   |   |   |
-- | -- | -- | -- | --
pool data not showing |   | not ok |   | All pools cannot be accessed individually in the Pool section. Error: Type LiquidityPoolHourlySnapshot has no field hourlySupplySideRevenueUSD Type LiquidityPoolHourlySnapshot has no field hourlyProtocolSideRevenueUSD Type LiquidityPoolHourlySnapshot has no field hourlyTotalRevenueUSD
Document: https://docs.google.com/spreadsheets/d/1BdnnDRE9cBH-YOXy2c3yQxv3sQDMU9wL/edit#gid=173913592

The QA document has been updated this is the current version: https://docs.google.com/spreadsheets/d/1BdnnDRE9cBH-YOXy2c3yQxv3sQDMU9wL/edit#gid=173913592

Issues were resolved.


fix: update urls in meta CSP to allow netlify and cloudcannon js to run in-page

Proposed changes

Updates the netlify URL in the CSP to match what is in use
Adds the cloudcannon URL to the CSP to allow in-page editing

This PR is not needed. I resolved the issue by adding a postbuild script, which runs after the HTML pages are generated in the CloudCannon builder, that adds the CloudCannon CDN url to the CSP meta tag.


refactor api pagers to deduplicate spaghetti

the page-querying design in the api layer has grown organically from the roots of its implementation prior to centralizing calls in the api layer.  As a result, there's a lot of duplicate, or near- duplicate, code handling.  The duplication will, as we grow the layer, eventually lead to maintenance issues and "I forgot that spot" gotchas.
This PR is a first step towards wrangling that code into a clean and centralized pattern.

Page controller structs are consistent for each type (one for deltas, one for non-deltas).
All page controllers call into either enumerateItems or deltaEnumerateItems as their centralized runner.
All variations on data control (only ids, collision keys, etc) are handled as a post-process to the enumeration calls, instead of duplicating the runner process itself in every iteration.

Future PRs can further reduce issues by:

conforming container enumeration to the same pattern.
moving pager loop processing out of higher layers and into the api layer.

Does this PR need a docs update or release note?

[x] :no_entry: No

Type of change

[x] :broom: Tech Debt/Cleanup

Issue(s)

#3988

Test Plan

[x] :zap: Unit test
[x] :green_heart: E2E

messed up the git commit, closing and remaking


Add Java snippets on CXF component page, normalize formating markup, …

…re-indent examples
@ffang @llowinge could you please review?

0d0f9456e7b9facff69e840b99e49eca9671f0a2 that I just force-pushed does not show up for some reason.


Simplify writing Environment as a Java properties file

When using Environment API integrating with other libraries, they might require an external properties file to initialize. Currently, one cannot iterate over keys/values of an Environment instance and then write it to an external properties file. Either Environment should provide its keys as an API or a separate API should be introduced to allow I/O for an Environment.

This issue will be also solved by PR https://github.com/sdl/environment-api/pull/3
Because it adds a Map<String, String> representation to the Environment API.

I still think that we might need proper EnvironmentWriter as a proper interface.


Bump client_matrix.py for grpc-java 1.31.1

@nicolasnoble

@dapengzhang0, note that this is for the old release. After this goes in I'll send a PR for the current release.


Ensemble or joint calling for rare variants in a large cohort of families?

Dear bcbio developers and users!
Could you please share your experience when studying cohorts
(rare germline variants)?
Is it better to run ensemble calling sample by sample, or joint calling?
Joint calling is caller specific, so you cannot run ensemble+joint,
just 4 different joint runs, right?
Generally it is accepted that joint genotyping (multisample) is better,
but it cannot be validated in my case.
Ensemble calling does a great job in terms of sensitivity, gatk best practices
say that some singletones may be lost with joint genotyping.
Would you expect any difference in sensitivity/specificity, or it is just a way to organize data,
one large gemini result database is better than 1000 small databases?
What do you think?
Thanks!
Sergey

Sergey;
Thanks for starting this discussion. You're right that multisample calling and ensemble are not very compatible right now. My general suggestion would be to run either HaplotypeCaller or FreeBayes on the multisample batches and use those calls. Ensemble is more useful right now for trickier calling like somatic detection of low frequency variants and does less for population based calling where the callers are doing a good job. As you said, it also makes interpretation much easier as you have a single squared off VCF to assess call rates across variants for the full population. Hope this helps.

Thanks Brad;
Finally I'm running per-family (up to 3-4 samples) ensemble, because

joint genotyping allows to rescue low coverage variants when evidence exists in the other sample,
at the same time it is less confident for singletons (rare mutations), when there is no evidence in other samples. We are interested in singletons in the project.
it is easy to validate ensemble calls even for families (platinum exomes have families), but it is not so easy to validate joint genotyping: we don't have 100 platinum exomes, the only way is to mix platinum exomes and sequenced samples;
it is hard to convince people, that mixing reads from different families makes sense. It is better to get high quality variants and then study allele frequencies in the population.

Sergey


Object doesn't support property or method 'remove'

I have added <script
src="http://cdnjs.cloudflare.com/ajax/libs/dom4/2.0.0/dom4.js"

 but still facing this error on IE 11. is there any solution available for that??

the remove is there, but if you use it with some element that doesn't extend Element it won't work.
I am not sure they move remove and others to the Node.prototype though, so if that's the case, I might update the library, but basically it looks to me you are trying to remove non-elements.

I have resolved this issue. apply polyfills for IE 11.
reference: https://medium.com/agilix/internet-explorer-11-and-angular-2-50beda010aae
and did code changes:
var blob = new Blob([csvArray]);
if (window.navigator.msSaveOrOpenBlob) // IE hack; see http://msdn.microsoft.com/en-us/library/ie/hh779016.aspx
window.navigator.msSaveBlob(blob, "ExportCSV.csv");
else {
var a = window.document.createElement("a");
a.href = window.URL.createObjectURL(blob);
a.download = "ExportCSV.csv";
document.body.appendChild(a);
a.click(); // IE: "Access is denied"; see: https://connect.microsoft.com/IE/feedback/details/797361/ie-10-treats-blob-url-as-cross-origin-and-denies-access
document.body.removeChild(a);
after adding this..now i can export data in IE11

but this has nothing to do with remove, right? anyway, happy you solved.

I think we can use removeChild(() method instead of remove()..


sys-kernel/coreos-modules: Enable dm-verity signature support

Enable dm-verity signature support
This allows checking against the primary kernel keyring, but not the secondary. It is a prerequisite for the ioctl to inject the signature to be supported in the first place.
How to use
Test with sysext with signature: https://github.com/flatcar/sysext-bakery/pull/24.
Testing done
Not yet. Will see if ioctl still reports error after an image for this PR is built.

[ ] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Moved to backlog. Feel free to update.


Fix directory paths.

Fix for this issue: https://github.com/opentracing/opentracing-cpp/commit/3fb91d3238ff469d44b21504f7e8f4da0e333e8f#r27784606

@yandreiy -- look good?

@rnburn That's great, thanks for quick update!


What would be the url for the WinAppDriver Pipeline Task

Hi, I’d like to try the WinAppDriver Pipeline Task but what would be the url I use to get to the server instead of <IP_ADDRESS>:4723?
Recently, I just got the interactive build agent working with Appium and am pretty excited about it. So with this new Pipeline task does this mean I won’t need to run the build agent interactively and logged on anymore?
Thanks,
Rodney

WinAppriver task by default uses <IP_ADDRESS>: 4723. No you still need to be logged out to execute the UI tests.


Restore command --input option

Describe the issue here.
influx restore command
The option  --input /path/to/backup/dir/ doesn't work for me (The prompt ask me to set a path)
It works using with the same syntax as for backup command (input path just after the command)
Like this: influx restore /path/to/backup/dir/ ...
Relevant URLs

Provide relevant URLs
https://docs.influxdata.com/influxdb/v2.0/reference/cli/influx/restore/#flags

What products and version are you using?
InfluxDB 2.0 OSS

Additionally, the command line help also states that the "--input" flag is mandatory. The usage section of the command line help states that the input path shall be put at the end of the line without "--input" flag. This inconsistency should also be fixed.


unix/winPB: Allow use of local Vendor_Files folder

Fixes: #1850
In cases where dotgpg can't be used, or we need to automate running the playbooks, (such as AWX, see the referenced issue), currently, there's no way to run the adoptopenjdk tagged roles (or any roles requiring vendor file material). To fix this, I've adapted the Get_Vendor_Files role to allow  the use of the local vendor files, or retrieving them from the secrets repo in the case that the machine doesn't have local vendor files.
This assumes that the local vendor files:

Follow the same structure as the vendor_files in the secrets repo (i.e. https://github.com/AdoptOpenJDK/secrets/blob/master/vendor_files/Nagios_User_SSHKey.gpg --> /Vendor_Files/Nagios_User_SSHKey)
aren't gpg encrypted.

Checklist

[x] commit message has one of the standard prefixes (Sort of)
[ ] FAQ.md updated if appropriate : N/A
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC :  Not beneficial as the adoptopenjdk is skipped in VPC.
[ ] inventory changes, ensure bastillion is updated accordingly: N/A

Ref: Latest Commit.
I'm unsure about how we want to proceed with the AIX playbook - I'm happy to change it so it's in line with Windows/Unix, if that's whats wanted. The latest commit just updates where the SSH-keys are expected to be, so they're in line with where the Windows/Unix playbooks expect them to be.

Ref: Latest Commit.
I'm unsure about how we want to proceed with the AIX playbook - I'm happy to change it so it's in line with Windows/Unix, if that's whats wanted. The latest commit just updates where the SSH-keys are expected to be, so they're in line with where the Windows/Unix playbooks expect them to be.

I'm unsure about how we want to proceed with the AIX playboo

I think we need to do that, otherwise things just get messy, but happy for it to be done in a separate PR to this ...

I'm unsure about how we want to proceed with the AIX playboo

I think we need to do that, otherwise things just get messy, but happy for it to be done in a separate PR to this ...

This isn't working for me at the moment - it's not correctly picking setting the authorized_keys file. The original version (SHA f4403a07798cd285de12ac8a19c5861ca78e415e) works ok

This isn't working for me at the moment - it's not correctly picking setting the authorized_keys file. The original version (SHA f4403a07798cd285de12ac8a19c5861ca78e415e) works ok

This doesn't work as-is because the user roles have e.g.
     key: "{{ Jenkins_User_SSHKey }}"

instead of
      key: "{{ lookup('file', '{{ Jenkins_User_SSHKey }}') }}"

This doesn't work as-is because the user roles have e.g.
     key: "{{ Jenkins_User_SSHKey }}"

instead of
      key: "{{ lookup('file', '{{ Jenkins_User_SSHKey }}') }}"

Just tried with a modified version of Get_Vendor_Files that included the jenkins_user and nagios_plugins tags on each task, and move my files around from the old locations (I'm not sure I like the new names ad structure though) and it works, so we should identify the list of tags we need to catch these situations and add them to complete this.

Just tried with a modified version of Get_Vendor_Files that included the jenkins_user and nagios_plugins tags on each task, and move my files around from the old locations (I'm not sure I like the new names ad structure though) and it works, so we should identify the list of tags we need to catch these situations and add them to complete this.

With the latest commit, I think the tags I've added cover all the roles that need the Vendor_Files - jenkins_user, nagios_plugins, superuser in Unix's case & jenkins in Window's case

With the latest commit, I think the tags I've added cover all the roles that need the Vendor_Files - jenkins_user, nagios_plugins, superuser in Unix's case & jenkins in Window's case

This is now lookgin promising and appears to work in myt scenario - I presume you've tested that it still successfully picks things up from the secrets repo if required ;-)
Hmmm just had another thought after looking at it - if I was to run it with --skip-tags nagios_plugins would that stop it locating the jenkins_user key?

Sadly, it does :|
Maybe it'd be better to just keep the adoptopenjdk tag on it, and put in the README.md something along the lines of "If you want to run the playbook with any of the following tags: jenkins, nagios_plugins, superuser, then the vendor_files tag must be included"
It's not the best solution, but I would assume that the people who have access to the Vendor Files would read the README?
Alternatively, I could put the tasks that set all the variables from the local Vendor Files, into the Common/main.yml role, but I'd say that feels like a worst solution ...

On something semi-related:
a) I like hands-free incl - report errors/warnings as you find them - but continue as long as possible
b) while developing a change to jenkins_user for AIX - and not having access to the secret I came up with the following logic

register: jenkins_user_rsa (or jenkins_user_pki, or whatever you like - different from the tag in any case).
ignore_errors: yes
Add new debug task to report key could not be copied when: jenkins_user_rsa.failed == true

What I did not add was a task to test if a key is already installed (after the failed). With an extra condition such as this the message could be changed to something as: key was not not updated, if required; or when nothing is there "jenkins_user" is not functional - key is missing (and perhaps have the playbook stop, although my preference is to continue and see what else may be missing/needed).
The names of the variables don't interest me. However, imho, having a playbook that plays to the end - reporting everything it finds is more efficient that re-running a playbook and have it stop at the first missing bit it runs into. With a list of missing items - I can do the searching, updating, and then re-running the playbook with the expectation all should pass this time.

I think those points in the last comment are separate from this PR and should not hold up merging of it - @Willsparker I'm happy for this to go in now if you are (It's actively causing a problem not having it in) and other enhancements to cover the scenaios I described can be done
Ref our other discussion @aixtools I do think it's worth having a vendor_files tag in the AIX ones too in order to avoid your "seven different skip tags" :-)
@Willsparker Do you know if the playbooks run ok if neither secrets or /Vendor_Files is accessible and --skip-tags vendor_files is used?

If the vendor_files tags are skipped, the roles that use the vars from them will need to be skipped too. Doing --skip-tags adoptopenjdk,jenkins will do that :-)
Yeah, I'm happy for this to go in

@aixtools While I agree that it's frustrating to have to re-run the playbook whenever it fails (and having to re-run it many times to fix all the issues), I don't think it's a good idea to force them to succeed if they don't work. I think this is just asking for issues to go unnoticed when using the playbooks to setup actual machines, from people not looking through the Ansible logs - I know I don't tend to look through the logs if the Ansible reports the playbook as succeeding.

If the vendor_files tags are skipped, the roles that use the vars from them will need to be skipped too. Doing --skip-tags adoptopenjdk,jenkins will do that :-)

Hmmmm I've just had a situation where I've tried to do a "basic" machine setup, so I thought I'd just run the adoptopenjdk role. Needless to say, this tries to create the jenkins user but then skips the reading of the key, so it falls over. Will need to think about a solution for that.

Really? Ansible should run that role, If you specify --tag adoptopenjdk ... :thinking:


Running Main.py files in Shift+Alt+F5 does not work but does work for F5.

I would like to replicate the behaviour of Spyder IDE: press F5 and runfile('Main.py, wdir= 'MainFolder') runs all the code and charts inside the interactive window.  In Visual studio 2017 my Main.py file runs with F5 fine  and it finds my classes and modules within the project/solution (of course the charts and stuff pop up and pauses the debugger which is why I also want the interactive window working). However if I run the same Main.py using Shift+Alt+F5 it runs the file but immediately stops at the first 'import Mylib as mylib'  and ModuleNotFoundError: No module named 'Mylib' .   It would seem that the Debugger (F5) and the interactive (Shift+Alt+F5) have different default working directories in Visual Studio.   I have tried adding in Project -> Properties -> Working Directory and also tried adding my  Folder to the search Paths and this did not fix it, but intuitively F5 and Shift+Alt+F5 should run EXACTLY the same code with the same configurations.

Hi Moritz, Two things are likely the problem.

You have installed two conflicting IDEs. Maybe you have Anaconda and also have the Original Python IDE installed. That error occurs when there're conflicting folders.

Check to make sure your VS has also not installed its own Class of modules separate from what you have installed through pip. This can also be the case.

The case is most likely the 1st point.
Cheers.

Hi , I specifically deleted all python/Anaconda before installing VS2017 with Anaconda bundled as part of the install.   I have a work-around to first right click the project and click Open Interactive. Then Shift+Alt+F5 goes to that 'projectname' interactive window.  It seems that in VS with different Python Environments it may route to the Anaconda Interactve window or to the 'projectname' interactive window.  While intuitively the interactive working directory should be same (Shift+Alt+F5 should have consistent behaviour) , how does one set the working directory of the Interactive window in VS, before runtime?

This is the same as #2449 - we're going to look into it. The problem is exactly what you describe: they should run with the same configuration, but right now they do not.

Can u please solve this issue of mine...
In 3.4.0 shell , when I click

shift+alt+fn+5 invalid error is seen.
fn+5 invalid error is seen.

For the first time nothing change is seen. After closing the shell window and running the program after opening Invalid syntax error is seen.