Does speaker-diar have vad system dependency?

Hi,wespeaker team.  My name is Nathan.
first of all, thank you for your great work.
These day I am using wespeaker to implement my own diar-system.
but i faced some error that I don't understand.
First, I trained model 'ECAPA_TDNN-ASTP-emb512-fbank80-num_frms200-aug0.6-spTrue-saFalse-ArcMargin-SGD-epoch150' and used other Language. I checked this model is work properly.
Second, I moved to 'examples/voxconverse/v2' and  follow stage 3(vad)-6(Applying spectral clustering).
I would like use my own VAD system. So I used mine and replace original data to new 'data/test/system_sad' as below.
silero-vad-3.1)
2spk-00000834-00004734 2spk 0.834 4.734
2spk-00005088-00011358 2spk 5.088 11.358
2spk-00012192-00017502 2spk 12.192 17.502
2spk-00018240-00020382 2spk 18.240 20.382
2spk-00020736-00022302 2spk 20.736 22.302
2spk-00023040-00024798 2spk 23.040 24.798
mine)
2spk-00000940-00004780 2spk 0.940 4.780
2spk-00005080-00011480 2spk 5.080 11.480
2spk-00012160-00017580 2spk 12.160 17.580
2spk-00018220-00020480 2spk 18.220 20.480
2spk-00020740-00022320 2spk 20.740 22.320
2spk-00023040-00024940 2spk 23.040 24.940
So, when I used my own vad time, system shows error.
Only chaged thing is 'data/test/system_sad' and follow stage 4-6
bash ./run_test.sh --stage 4 --stop_stage 6
But system shows quiet different result
test_system_sad_labels
case1)using silero
2spk-00000834-00004734-00000000-00000150 1
2spk-00000834-00004734-00000075-00000225 1
2spk-00000834-00004734-00000150-00000300 1
2spk-00000834-00004734-00000225-00000375 1
2spk-00000834-00004734-00000300-00000390 1
2spk-00005088-00011358-00000000-00000150 1
2spk-00005088-00011358-00000075-00000225 1
2spk-00005088-00011358-00000150-00000300 1
2spk-00005088-00011358-00000225-00000375 1
2spk-00005088-00011358-00000300-00000450 1
2spk-00005088-00011358-00000375-00000525 1
2spk-00005088-00011358-00000450-00000600 1
2spk-00005088-00011358-00000525-00000627 1
2spk-00012192-00017502-00000000-00000150 1
2spk-00012192-00017502-00000075-00000225 1
2spk-00012192-00017502-00000150-00000300 1
2spk-00012192-00017502-00000225-00000375 1
2spk-00012192-00017502-00000300-00000450 1
2spk-00012192-00017502-00000375-00000525 1
2spk-00012192-00017502-00000450-00000531 1
2spk-00018240-00020382-00000000-00000150 0
2spk-00018240-00020382-00000075-00000214 0
2spk-00020736-00022302-00000000-00000150 0
2spk-00020736-00022302-00000075-00000156 0
2spk-00023040-00024798-00000000-00000150 0
2spk-00023040-00024798-00000075-00000175 0
case2)using mine
2spk-00000940-00004780-00000000-00000150 1
2spk-00000940-00004780-00000075-00000225 1
2spk-00000940-00004780-00000150-00000300 2
2spk-00000940-00004780-00000225-00000375 2
2spk-00000940-00004780-00000300-00000384 2
2spk-00005080-00011480-00000000-00000150 1
2spk-00005080-00011480-00000075-00000225 1
2spk-00005080-00011480-00000150-00000300 1
2spk-00005080-00011480-00000225-00000375 2
2spk-00005080-00011480-00000300-00000450 1
2spk-00005080-00011480-00000375-00000525 1
2spk-00005080-00011480-00000450-00000600 1
2spk-00005080-00011480-00000525-00000640 2
2spk-00012160-00017580-00000000-00000150 1
2spk-00012160-00017580-00000075-00000225 1
2spk-00012160-00017580-00000150-00000300 2
2spk-00012160-00017580-00000225-00000375 2
2spk-00012160-00017580-00000300-00000450 1
2spk-00012160-00017580-00000375-00000525 2
2spk-00012160-00017580-00000450-00000542 2
2spk-00018220-00020480-00000000-00000150 0
2spk-00018220-00020480-00000075-00000225 0
2spk-00018220-00020480-00000150-00000226 0
2spk-00020740-00022320-00000000-00000150 0
2spk-00020740-00022320-00000075-00000158 0
2spk-00023040-00024940-00000000-00000150 0
2spk-00023040-00024940-00000075-00000190 0
Result using silero is right answer. But mine shows bad result.
Actually, I implemented vad,embedding,spectral_cluser in c++ env.
It also shows error too.
Does your system have any dependencies?
please give me a advise.
Thank you.

Thank you for your question.

Re-train your own ECAPA-TDNN model is fine and could perform better in the language of your data if you have enough training data in your domain.
Use your own VAD system is also fine. (Your VAD works well as the results shows.)

Maybe you can try:

Print np.diff(eig_values[:max_num_spks + 1]) in this https://github.com/wenet-e2e/wespeaker/blob/788e3eb71292af87d4a1708e8812387a82415221/wespeaker/diar/spectral_clusterer.py#L61 The max index decides the number of spks. In your case, I guess the second value and the third value should be very close.  And unfortunately, the 3rd value is slightly bigger using your own VAD, while the 2nd one is bigger using silero-VAD.
Try to tune the n parameter in https://github.com/wenet-e2e/wespeaker/blob/788e3eb71292af87d4a1708e8812387a82415221/wespeaker/diar/spectral_clusterer.py#L42 or https://github.com/wenet-e2e/wespeaker/blob/788e3eb71292af87d4a1708e8812387a82415221/wespeaker/diar/spectral_clusterer.py#L44  Use a smaller n could probably get less spk number.

Thank you for your response.
I still don't understand enven though vad results are almost same, spectral clustering behaves differently.
I followd your instruction 'n=n-1 or n=n-2'
Both of those worsk. But It works only a test wav when i use my own VAD.
I wondering parameter 'n' is generated based on number of subsegments.
How to control of 'n'?

n = int((1.0 - p) * m) , m is the number of subsegments. If m is less than 1000, we keep n=m-10; else n = m*(1-p).  p is usually tuned in a dev set.
From our experience, p in [0.01, 0.05] could be fine. Some papers have discussed about the p value. link

All of my test set are less than 1000 subsegments, so only takes 'n = max(m - 10, 2) '
But mainly difference on vad is unit about second.
I realized that my implemented vad system outputs in units of 10ms, while your outputs in units of 1ms.
Could you please check your system working well by using units of 10ms?

The uint of vad (1ms or 10ms) could not have such a big difference.

Yeap that's true....
So i tried to get results using your pretrained Model.
After testing, I realized my model trained by myself has little problem even though EER result is not bad.
I will figure it out what's matter.
Thank you so much to help me.


Updates resources and goals api to follow api.apiId new name convention

@briangormanly ready when you are on this one - don't want to push it through without your review.


Update README.md

Passing plugins through the use of a file is not available for the LTS version of Jenkins.

it will be in the next LTS


Jamendo Playlists

Checklist

[x] I've verified and I assure that I'm running youtube-dl 2018.12.17
[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Description of your issue, suggested solution and other information
Jamendo support was merged a couple years ago (#10132) but it doesn't work -- or at least, doesn't currently work -- on albums, the same way bandcamp and youtube playlists do. I assume the parser needs tweaking now I guess? It just says there's 0 tracks found.
Site Examples
https://www.jamendo.com/album/68337/timeless-piano-dreams
$ youtube-dl  -v https://www.jamendo.com/album/68337/timeless-piano-dreams
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.jamendo.com/album/68337/timeless-piano-dreams']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.12.09
[debug] Python version 3.7.1 (CPython) - Darwin-18.2.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.1, ffprobe 4.1
[debug] Proxy map: {}
[JamendoAlbum] timeless-piano-dreams: Downloading webpage
[download] Downloading playlist: Vladimir Sterzer - Timeless Piano Dreams
[JamendoAlbum] playlist Vladimir Sterzer - Timeless Piano Dreams: Collected 0 video ids (downloading 0 of them)
[download] Finished downloading playlist: Vladimir Sterzer - Timeless Piano Dreams

I experience the same issue, maybe there's a problem with the regex filtering the track ids out: r'<a[^>]+href=(["\'])(?P<path>(?:(?!\1).)+)\1[^>]+class=["\'][^>]*js-trackrow-albumpage-link'

When somebody works on this issue, he could also integrate support for downloading all tracks of an artist and all tracks of a playlist. Example urls:

https://www.jamendo.com/artist/440692/jekk
https://www.jamendo.com/playlist/500458937/best-of-november-2018


Fold comments command does not work in VSCode with Volar, but works with Vetur

I mean this command:

After I replaced Vetur with Volar it stopped working.

Hi @ilyub, I can't reproduce this problem, it's working for me, please provide minimal reproduction code if you can.

Hi @johnsoncodehk, thx for the response.
Here is a sample vue file that does not fold comments on Ctrl+K + Ctrl+/:

<template>

</template>

Here is a sample ts file that folds comments on Ctrl+K + Ctrl+/:
/**

Description.
/
export function withComment(): void {
/

Function body
*/
}

This is what Ctrl+K + Ctrl+/ should do:

Please, let me know if any aditional info is needed.


Feature Suggestions & Ideas

Hey,
Please comment below for some suggestions and ideas for new features! I will go ahead and post some myself below as well.
Thanks for contributing to the project by sharing your ideas!

Hey, here are some ideas:

Post:Rating Ratio
Change status message.
Stats.
Allow changing the request interval time.
Automated PM (besides Spigot)
Change avatar
Update account details (location, job, etc).
A “styler” to change colors or let others pick their own theme would be nice.
Pie chart showing which sites you have the most posts / ratings on
Changing avatar.
For all of these things make it so you can pick which sites to do it on and which to not do it on. Like, some sites I have Saphiria and some I have my personal name. So I would not want to bulk change all of the settings.
Change signature.
When someone buys his/her premium resource (like done here https://www.spigotmc.org/resources/spigot-pm-auto-send.3618/)
Refresh every 30 seconds (or allow user to change the time, but make it so on Spigot it is always 1min).

test

test

test

test

test


Use actual liquidation price for open CFDs

I propose to do something like this to deal with https://github.com/itchysats/itchysats/issues/2809. Eventually we may just want to store this information directly, particularly for closed and failed CFDs.

We can deduce the liquidation prices for open CFDs by looking at the stored CETs, as soon as we have them (after we apply {ContractSetup, Rollover}Completed events.
This is only possible for open CFDs, because they are the only ones that have access to this information (unlike offers, closed CFDs and failed CFDs). Having correct liquidation prices also matters a lot more for open CFDs, as the user can actually use this information to make decisions.

bors r+

bors r+

@luckysori it seems that it's not our typical rollover test failure, but an assertion of liquidation price:
https://github.com/itchysats/itchysats/blob/master/daemon-tests/tests/main/collaborative_settlement.rs#L171

bors r+


Status Labels Inconsistent in Expenses and Transactions List

Something small I've noticed is that the status labels (PAID, APPROVED etc) we use in expenses and transactions list are inconsistent.

We need to make them consistent. I'm proposing the smaller labels (that we use in transactions) but I am open for suggestions.
cc: @opencollective/design

That's probably a design update that was applied on one but not the other. Rather than picking the one we prefer, we should look at Figma and use the styles from the latest design.

Ah yes, the newer designs has the more boldface font labels; https://www.figma.com/file/KinuveYf4WUlRIXzMTnmIsmO/[OC-Design]-Lab?node-id=14041%3A210564 which we have on the expenses side. Thus I am changing all to those.


Package new sensors

Hello Carla team.
First of all, I want to say thank you for offer this very useful simulator.
Now, I am trying to adding a new sensor by following the tutorial in the below link:
How to add a new sensor
https://carla.readthedocs.io/en/latest/how_to_build_on_linux/
After doing make rebuild, I run Unreal editor with make launch.
The sensor is working well through Python API.
class SafeDistanceSensor(object):
    def __init__(self, parent_actor):
        self.sensor = None
        self._parent = parent_actor
        world = self._parent.get_world()
        bp = world.get_blueprint_library().find('sensor.other.safe_distance')
        self.sensor = world.spawn_actor(bp, carla.Transform(), attach_to=self._parent)
        self.sensor.listen(lambda event: SafeDistanceSensor.callback(world, event))
    @staticmethod
    def callback(world, event):
        for actor_id in event:
            vehicle = world.get_actor(actor_id)
            print('Vehicle too close: %s' % vehicle.type_id)

Then I want to run CARLA without Unreal editor.
So I packaged CARLA with make package
Then I run the exactly same python code to call the new sensor.
But I get the error below:
IndexError: blueprint 'sensor.other.safe_distance' not found
It seems that the changes of new sensor is not packaged.
I use carla 9.6 on ubuntu 18.04
How can I package the new sensor correctly?
Thanks for your help!

Hi, I am stuck on something very similar to you. Do you remember, how you were able ti figure it out?
Best regards,


proposal: Go 2: predeclared 'isT any bool'

Go Programming Experience
Experienced
Other Languages Experience
many
Related Idea

[ ] Has this idea, or one like it, been proposed before?
[ ] Does this affect error handling?
[X] Is this about generics?
[X] Is this change backward compatible? Breaking the Go 1 compatibility guarantee is a large cost and requires a large benefit

Has this idea, or one like it, been proposed before?
Not to my knowledge.
Does this affect error handling?
No.
Is this about generics?
Indirectly.
Proposal
I propose that we add an intrinsic is function, equivalent to this Go declaration:
// Is[T] reports whether the type assertion x.(T) would succeed.
func is[T any](x any) bool {
     _, ok := x.(T)
    return ok
}

This operator makes it possible to test the type of an interface without breaking out of expression mode, which is especially helpful when writing code that makes heavy use of sum types, such as syntax trees, types, XML documents, and so on.
if len(calleeDecl.Body.List) == 1 &&
                is[*ast.ReturnStmt](calleeDecl.Body.List[0]) &&
                len(calleeDecl.Body.List[0].(*ast.ReturnStmt).Results) > 0 { // not a bare return

Of course, one can write this function in Go or import it from a package, but like min and max it is ubiquitous and fundamental, and warrants a short name.
Language Spec Changes
The universe scope defines an is function, whose declaration is equivalent to the Go code shown above.
Informal Change
The is operator performs a test of an interface's  dynamic type.
Is this change backward compatible?
Yes.
Orthogonality: How does this change interact or overlap with existing features?
Very orthogonal.
Would this change make Go easier or harder to learn, and why?
No net change. Harder, because one more thing to learn; easier, because less frustrating breaking out of expression mode.
Cost Description
No response
Changes to Go ToolChain
local changes to cmd/compile, go/types, a few others
Performance Costs
none
Prototype
See above.

A more general builtin, and one that could not be written in the language today, would take anything with a 1- or 2-value form and return the second value. For lack of a better name I'll call it snd for second. With that you could write snd(v.(T)) or snd(m[k]). I have felt the need for this far more for maps, personally. That would also suggest a both builtin that forces the 2-value return. I have wanted both of those before, though mostly snd.

A more general builtin, and one that could not be written in the language today, would take anything with a 1- or 2-value form and return the second value. For lack of a better name I'll call it snd for second. With that you could write snd(v.(T)) or snd(m[k]). I have felt the need for this far more for maps, personally. That would also suggest a both builtin that forces the 2-value return. I have wanted both of those before, though mostly snd.

That is more general, but less clear:

snd(m[k]) would ask whether k is present in a map. You can write this today as m[k] (if all elements are true), or m[k] != nil or m[k] != 0 if the map contains only nonzero values, which is the common case. In the rare case that you want to distinguish absence from zero, it would be clearer to declare contains(m, k) as a function or use the explicit ,ok form.
snd(<-ch) would tell you whether you received a value from the channel, but would throw that value away. I can't think of a time I've needed that operation, but that fact is that concurrency operations appear far less common than ordinary computation, and essentially never in the middle of an expression context.

So it doesn't seem to me to be the right axis for generalization.

I have written plenty of code that wants to know if a value is in a map that must distinguish between zero and absent. Far more often than it was okay to rely on zero and absent being the same. I've wanted is maybe 3 or 4 times. I've wanted return both(m[k]) much more often and that's pretty rare.
Agreed that snd(<-ch) is fairly useless.

Evidence: grep for if _, ok := .[.](.); ok on your favorite repo.

However, this grep alone does not indicate whether these occurrences would noticeably benefit from being usable in an expression. The difference between using if is[T](x) { and if _, ok := x.(T); ok { by itself is so minor that it doesn't even save a line.

The difference between using if isT { and if _, ok := x.(T); ok { by itself is so minor that it doesn't even save a line.

is[T] composes a bit nicer if one needs to do multiple matches, e.g. x is a T and x.F is a U and x.G is a V if x, ok := x.(T); ok && is[U](x.F) && is[V](x.G) {}. This starts to save lines.
But the main question is whether the new builtin improves the readability of the code more than the cost of adding a new builtin into the language.
is[T] would help the readability for x/tools but YMMV.

A thing I frequently see, especially with people first coming to Go from dynamically typed languages, is overuse of []any and map[string]any especially when working with JSON. I worry that having this is builtin would encourage trudging through that approach rather than defining types.
And personally, I don't find that there are many cases calling for is. Running a grep for just _, ok on all code I have cloned for work finds zero uses for type assertions, only map lookups plus some channel receives in tests, out of about 168k lines of Go.

As suggested in an earlier comment, I did a (very unscientific) survey of the codebase I spend my dayjob maintaining, for examples that might benefit from this proposal.
This codebase seems to have a pretty even split between _, ok being used with type assertions vs. being used for testing for the presence of map keys, along with a small number of functions specific to this codebase that follow the (result, bool) convention.
During this survey I found three main situations.

Most common: Detecting what type an interface isn't, rather than what it is:
    if _, ok := b.(*Example); !ok {
        return fmt.Errorf(...)
    }

I think this is most common because this sort of negative type assertion doesn't generate any new information about what dynamic type the interface does have; the first result is always useless.
It seems that most (possibly all) of these examples would slightly benefit in conciseness from this proposal:
    if !is[*Example](b) {
        return fmt.Errorf(...)
    }

...although I have mixed feelings about whether this is more or less readable to someone who isn't already familiar with this is function, since the is identifier seems to get lost in a swamp of punctuation.

A lot less common: Detecting what type an interface (most often an error) has, without any care about the value.
    if _, ok := err.(SpecialError); ok {
        // Different handling for this special error type
    }

For errors in particular it seems relatively common for the dynamic type to be the most important information, with the data inside that value being less important. This isn't true in all cases of course -- sometimes we're treating a particular error type as special specifically so that we can rely on some fields or methods unique to that error type -- but making the decision based on type alone seems somewhat common in our codebase.
These examples could also be trivially replaced by a call to is:
    if is[SpecialError](err) {
        // Different handling for this special error type
    }

Dishonorable mention: a series of tests that could have and should have been a type switch.
    if _, ok := k.(Example1); ok {
        return Example1Result
    }
    if _, ok := k.(Example2); ok {
        return Example2Result
    }
    return OtherResult

Thankfully I found few enough examples of this that I can count them on one hand. Of course I would rewrite these to be type switches instead of adopting the is builtin for them.
    switch k.(type) {
    case Example1:
        return Example1Result
    case Example2:
        return Example2Result
    default:
        return OtherResult
    }

This survey contradicted my initial (incorrect) hunch that there wouldn't be many examples of testing the type without then using the value. I expect we'd have plenty of opportunities to use is if it were accepted as a builtin.
However, I feel ambivalent because of the highly subjective concern I mentioned above: that the identifier is gets visually lost in a lot of punctuation that seems to make this harder to read and understand than I had initially hoped. The longer forms we're using today are less concise, but the meaning "feels" clearer to me.
I expect this concern would reduce if I were exposed to more examples of this in real code, but I'd worry about folks who are new to Go -- who might not have yet learned to read identifer[Something] as Go's generics syntax, due to it being different to most other languages -- being unsure how to mentally parse is[*Thingy](something) as "Is *Thingy the dynamic type of something?"
Perhaps choosing a longer name would allow being more specific about what exactly this function means and thus better prime someone to guess what the following characters mean. I don't want to bikeshed about it though; I'm curious to see if others share this concern or if it's just me.
Given all of the above, I'm cautiously in favor.

I'd like to note that this may conflict with the package https://github.com/matryer/is
is is an extremely common identifier so making it built-in now will make it hard to use. Some different name may be needed.

I'd like to note that this may conflict with the package https://github.com/matryer/is is is an extremely common identifier so making it built-in now will make it hard to use. Some different name may be needed.

That shouldn't be a problem any more than adding min() and max() were. Existing code will continue to work with no difference and anyone who wants to use it can just change the name of the import.

I wrote an analyzer to detect functions equivalent to is[T] or some instantiation of it, and ran it across a sample (min imports = 10) of the corpus of the Go module mirror. Out of 21479 modules, 590 (3%) define at least one function equivalent to is for some T. The query found a total of 1664 such functions. I have included a random sample of 100 of them below.
This measure is undercounts situations in which is[T] would be useful. I have not attempted to tally cases in which two statements:
    cond := false
    if _, ok := x.(X); ok {
        if _, ok := y.(Y); ok {
            cond = true
        }
    }
    f(cond)

could be replaced by one expression:
    f(is[X](x) && is[Y](y))

<EMAIL_ADDRESS>is[int64]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v14/parquet/schema.MapLogicalType]
<EMAIL_ADDRESS>is[github.com/Easypay/go-agent/internal/utilization.validationError]
<EMAIL_ADDRESS>is[*github.com/llir/llvm/ir/types.PointerType]
<EMAIL_ADDRESS>is[github.com/renproject/pack.typeU16]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v15/parquet/schema.Float16LogicalType]
<EMAIL_ADDRESS>is[*github.com/juju/juju/core/charm.unsupportedBaseError]
<EMAIL_ADDRESS>is[go.aporeto.io/manipulate.ErrCannotExecuteQuery]
<EMAIL_ADDRESS>is[*github.com/PuerkitoBio/ghost/handlers.statusResponseWriter]
<EMAIL_ADDRESS>is[github.com/hyperledger/fabric-sdk-go/pkg/fab.peersConfig]
<EMAIL_ADDRESS>is[*github.com/ulule/loukoum/builder.Delete]
<EMAIL_ADDRESS>is[github.com/hyperledger/fabric-sdk-go/pkg/fab.tlsCACertPool]
<EMAIL_ADDRESS>is[github.com/Azure/golua/lua.Float]
<EMAIL_ADDRESS>is[interface{IsHTTP2NoCachedConnError()}]
<EMAIL_ADDRESS>is[*github.com/tsuru/tsuru/api/observability.tsuruJaegerSampler]
<EMAIL_ADDRESS>is[github.com/endophage/gotuf/client.ErrNotFound]
<EMAIL_ADDRESS>is[github.com/offchainlabs/arbitrum/packages/arb-util/machine.HaltBlocked]
<EMAIL_ADDRESS>is[github.com/mit-dci/lit/btcutil/blockchain.errNotInMainChain]
<EMAIL_ADDRESS>is[gitlab.com/aquachain/aquachain/core/types.HomesteadSigner]
<EMAIL_ADDRESS>is[github.com/df-mc/dragonfly/server/item/enchantment.FireProtection]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v7/parquet/schema.JSONLogicalType]
<EMAIL_ADDRESS>is[github.com/dolthub/go-mysql-server/sql/types.DecimalType_]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v13/arrow/compute/internal/exec.integerMatcher]
<EMAIL_ADDRESS>is[code.gitea.io/gitea/models.ErrSHADoesNotMatch]
<EMAIL_ADDRESS>is[github.com/renproject/pack.typeU128]
<EMAIL_ADDRESS>is[github.com/viacoin/viad/blockchain/indexers.errDeserialize]
<EMAIL_ADDRESS>is[github.com/cavaliergopher/grab/v3.StatusCodeError]
<EMAIL_ADDRESS>is[github.com/keybase/client/go/kbfs/kbfsmd.ServerErrorThrottle]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v9/parquet/schema.UnknownLogicalType]
<EMAIL_ADDRESS>is[string]
<EMAIL_ADDRESS>is[github.com/roasbeef/btcd/blockchain.errDeserialize]
<EMAIL_ADDRESS>is[*code.gitea.io/gitea/modules/markup/markdown.TaskCheckBoxListItem]
<EMAIL_ADDRESS>is[github.com/spotmaxtech/k8s-apimachinery-v0260/pkg/util/mergepatch.ErrConflict]
<EMAIL_ADDRESS>is[code.gitea.io/gitea/models/git.ErrBranchAlreadyExists]
<EMAIL_ADDRESS>is[github.com/u2takey/go-utils/mergepatch.ErrConflict]
<EMAIL_ADDRESS>is[github.com/goruby/goruby/ast.literal]
<EMAIL_ADDRESS>is[*go.uber.org/cadence/.gen/go/shared.WorkflowExecutionAlreadyStartedError]
<EMAIL_ADDRESS>is[*gopkg.in/httprequest.v1.RemoteError]
<EMAIL_ADDRESS>is[github.com/vattle/sqlboiler/boil.boilErr]
<EMAIL_ADDRESS>is[*github.com/lib/pq.Error]
<EMAIL_ADDRESS>is[*github.com/lyraproj/pcore/types.SemVerRange]
<EMAIL_ADDRESS>is[*github.com/linkeddata/gojsonld.Literal]
<EMAIL_ADDRESS>is[*github.com/go-openapi/spec.Schema]
<EMAIL_ADDRESS>is[github.com/gitbundle/modules/queue.ErrInvalidConfiguration]
<EMAIL_ADDRESS>is[github.com/powerpuffpenguin/goja.valueUndefined]
<EMAIL_ADDRESS>is[*k8s.io/kube-openapi/pkg/validation/spec.Schema]
<EMAIL_ADDRESS>is[*github.com/iotaledger/iota.go/v3.AliasAddress]
<EMAIL_ADDRESS>is[github.com/lmittmann/w3.CallErrors]
<EMAIL_ADDRESS>is[github.com/Beeketing/go-agent/internal/utilization.validationError]
<EMAIL_ADDRESS>is[github.com/alloyzeus/go-azfl/errors.ArgumentError]
<EMAIL_ADDRESS>is[github.com/brimdata/zed/compiler/optimizer/demand.all]
<EMAIL_ADDRESS>is[github.com/spotmaxtech/k8s-apimachinery-v02217/pkg/util/mergepatch.ErrPreconditionFailed]
<EMAIL_ADDRESS>is[*github.com/mdlayher/ndp.RouterAdvertisement]
<EMAIL_ADDRESS>is[github.com/decred/dcrd/blockchain.errNotInMainChain]
<EMAIL_ADDRESS>is[github.com/talkincode/toughradius/v8/common/iploc.indexItem]
<EMAIL_ADDRESS>is[code.gitea.io/gitea/models/asymkey.ErrDeployKeyAlreadyExist]
<EMAIL_ADDRESS>is[*github.com/git-lfs/git-lfs/git.missingErr]
<EMAIL_ADDRESS>is[*github.com/juju/charm/v9.noCharmArchiveFile]
<EMAIL_ADDRESS>is[float32]
<EMAIL_ADDRESS>is[*gopkg.in/macaroon-bakery.v2/bakery.DischargeRequiredError]
<EMAIL_ADDRESS>is[github.com/bunsenapp/go-selenium.SessionIDError]
<EMAIL_ADDRESS>is[*gitlab.com/fulljourney/mysqlparser.ColName]
<EMAIL_ADDRESS>is[github.com/kubewharf/katalyst-core/pkg/agent/qrm-plugins/memory/dynamicpolicy/memoryadvisor.MemoryControlKnobHandler]
<EMAIL_ADDRESS>is[code.gitea.io/gitea/models/issues.ErrPullRequestHeadRepoMissing]
<EMAIL_ADDRESS>is[*github.com/open-cluster-management/multicloud-operators-foundation/pkg/controller/inventory/errors.AssetSecretNotFoundError]
<EMAIL_ADDRESS>is[code.gitea.io/gitea/models/db.ErrNameReserved]
<EMAIL_ADDRESS>is[string]
<EMAIL_ADDRESS>is[*github.com/nektos/act/pkg/runner.stepDocker]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v12/parquet/schema.DateLogicalType]
<EMAIL_ADDRESS>is[github.com/google/uuid.invalidLengthError]
<EMAIL_ADDRESS>is[github.com/df-mc/dragonfly/server/item.Bow]
<EMAIL_ADDRESS>is[github.com/networkservicemesh/api/pkg/api/networkservice.NetworkServiceClient]
<EMAIL_ADDRESS>is[github.com/casbin/govaluate.ExpressionFunction]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v15/parquet/schema.StringLogicalType]
<EMAIL_ADDRESS>is[github.com/hyperledger/fabric-sdk-go/pkg/fab.channelPeers]
<EMAIL_ADDRESS>is[*go/ast.CallExpr]
<EMAIL_ADDRESS>is[github.com/apache/arrow/go/v13/arrow/compute.EmptyDatum]
<EMAIL_ADDRESS>is[**github.com/cloudogu/cesapp-lib/core.Dogu]
<EMAIL_ADDRESS>is[github.com/palcoin-project/palcd/blockchain.errDeserialize]
<EMAIL_ADDRESS>is[error]
<EMAIL_ADDRESS>is[github.com/hyperledger/fabric-sdk-go/pkg/core/cryptosuite.securityProvider]
<EMAIL_ADDRESS>is[*github.com/lestrrat-go/jwx/v2/jwk.keyValidationError]
<EMAIL_ADDRESS>is[github.com/df-mc/dragonfly/server/block.WheatSeeds]
<EMAIL_ADDRESS>is[*github.com/blend/go-sdk/envoyutil.XFCCExtractionError]
<EMAIL_ADDRESS>is[*os/exec.ExitError]
<EMAIL_ADDRESS>is[go.aporeto.io/manipulate.ErrTLS]
<EMAIL_ADDRESS>is[*github.com/xelaj/errs.MultipleErrors]
<EMAIL_ADDRESS>is[github.com/hyperledger/fabric-sdk-go/pkg/msp.tlsCACertPool]
<EMAIL_ADDRESS>is[github.com/cozy/goexif2/exif.TagNotPresentError]
<EMAIL_ADDRESS>is[zombiezen.com/go/capnproto2/pogs.noWhichError]
<EMAIL_ADDRESS>is[*github.com/nats-io/nats-operator/pkg/util/retryutil.RetryError]
<EMAIL_ADDRESS>is[syscall.Errno]
<EMAIL_ADDRESS>is[go.aporeto.io/manipulate.ErrNotImplemented]
<EMAIL_ADDRESS>is[github.com/verrazzano/verrazzano-modules/module-operator/pkg/controller/errors.RetryableError]
<EMAIL_ADDRESS>is[github.com/ava-labs/coreth/core/types.HomesteadSigner]
<EMAIL_ADDRESS>is[github.com/fnproject/fn/api/models.FuncError]
<EMAIL_ADDRESS>is[*github.com/rh-messaging/shipshape/pkg/framework.RetryError]
<EMAIL_ADDRESS>is[github.com/alloyzeus/go-azfl/azerrs.CallError]
<EMAIL_ADDRESS>is[github.com/kubewharf/katalyst-core/pkg/util/general.HealthzCheckFunc]
<EMAIL_ADDRESS>is[github.com/wavesplatform/gowaves/pkg/errs.UnknownAsset]

it looks like over half of those deal with errors, which could be errors.As(err, &T{})

@adonovan, if this was a function in the standard library instead of a builtin, would you view that as acceptable, and any brief thoughts on how you would spell it if so? (Sorry if you already mentioned this).

it looks like over half of those deal with errors, which could be errors.As(err, &T{})

A quick side note is I think @Merovius has observed that if errors.As had been designed after generics were available, it might have been errors.As[T error](err error) (T, bool) instead, which is arguably more ergonomic.

Now, none builtin functions use the custom generic syntax. So maybe it is not a bad idea to support this function in std instead in my opinion.
BTW, @rsc's reply on the generic form of Is and As: https://github.com/golang/go/issues/29934#issuecomment-490091428

Update: Thanks for all the comments. I fixed a couple bugs in the analyzer (https://go.dev/cl/570315) and re-ran it, and updated the list, now partitioned into error and non-error-related cases (roughly 50% each).
I agree that a generic errors.As would have been nice, but perhaps that ship has sailed.

if this was a function in the standard library .. how you would spell it if so?

No package springs to mind; it's essentially an operator in the language. The closest analogue is min and max, but they obviously belong in the "math" package; there's no obvious counterpart here.

I am curious how those numbers compare to _, ok := m[k]. Are there docs somewhere about how to run these kinds of analyses and how to get a snapshot of the module proxy or is this something that requires special access?

Would this change make Go easier or harder to learn, and why?
No net change. Harder, because one more thing to learn; easier, because less frustrating breaking out of expression mode.

This feels like a kind of disingenuous answer. "Less frustrating breaking out of expression mode" is not a learnability benefit, it's a convenience. I think this is a pretty clear net negative (albeit not a huge one) when it comes to learnability.
Personally, I feel rather strongly that this proposal represents an inflationary attitude towards predeclared functions. For most of Go's life, we had a very limited number of predeclared identifiers and that was always advertised as a big benefit. And we only used predeclared functions for things that we could not implement in the language.
That changed with min/max, which where only made predeclared to avid the import. Now their existence is taken as evidence that we might as well add more.
Not to go all old-man-yelling-at-cloud, but I don't like it. I disliked adding min/max, I dislike is and I will probably dislike the next proposed predeclared function that creates a minor convenience.

For me it is more the problem that there are already several different kinds of is, for equality, error handling or unit testing, declared in different packages, so adding one more seem not particularly helpful, at least not with that name.
The min and max are somewhat different as they were likely used only for minimum and maximum.
For this proposal something like typeIs seems better to me.

If min and max are not builtin, then

their performance would be not good enough, because a slice is needed to be created at run time.
people are not willing to use them because a package needs to be imported but provided functionality is so tiny.

Adding to the ordinary proposal minutes, but I don't think this holds its weight. The vast majority of the time you care about the underlying type of something, you care because you want to use it. The x, ok := v.(T) form gives you the value to use. I can see how having is would be useful in complex conditionals, inside which you would re-type-assert to get the value. That may come up often in the kinds of AST code you write, but for me it almost never comes up. It's necessarily a feature of localized value.
To me at least, this doesn't seem worthwhile enough. The language already provides two forms - type assertions and type switches - so the bar for adding a third equivalent form seems quite high to me, and I don't think we have evidence here of meeting that bar.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

func is (t any, aType ... any) (any,bool) {
//  if t.(type) in aType , return first aType  and true
// elae return nil ,false
}

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group


Improve tags-on-commits-list and first-published-tag-for-merged-pr style (Second attempt)

First attempt: #5327
I made a mistake last time: the style is referenced from branch names, but tags are not actually branch names. This makes the blue background of branch names (in contrast to the usual gray of <code> blocks) less distinctive. The color also makes it appear more prominent than necessary, especially for tags-on-commits-list.
So this time I went to take a look at how release pages show the tag, which also shows meta info just like the feature does.
Screenshot

Test URL
Before
After

tags-on-commits-list

Multiple tags-on-commits-list

first-published-tag-for-merged-pr

Alternative design
Wrapping the version in <code>, which keeps it easily recognizable while being less prominent.

I'd rather have a background under the tag name, it's usually short so it doesn't naturally stand out otherwise. I'm okay with either blue or gray.

I'd rather have a background under the tag name, it's usually short so it doesn't naturally stand out otherwise.

That's also one of the reason I had in the first attempt. However I think first-published-tag-for-merged-pr doesn't benefit that much from the background:

(As said above,) it makes branch names next to it less distinctive
With clean-conversation-headers there's really not much stuff there, so it can be easily spotted anyway

It kinda makes sense but really I think this piece of information is important enough to deserve visibility. For example in PRs it lets me know whether a PR has been released and in the commit list it acts as an instant "release notes" between versions.
Making it less visible I think lessens the impact of this feature, so its 👎 for me

Making it less visible I think lessens the impact of this feature, so its 👎 for me

Alternative design then 😅

the style is referenced from branch names, but tags are not actually branch names. This makes the blue background of branch names (in contrast to the usual gray of <code> blocks) less distinctive.

In short: the blue background is misleading. GitHub only uses that for branches, so should we.

I don’t think the color itself has any meaning for the user since this style only seems to appear in PRs headers, so claiming that it misleads the user is like saying all red cars look like Ferraris.
If you want to make a change to how first-published-tag-for-merged-pr looks I'd go in the opposite direction and make it even more noticeable somehow.
My arguments don't apply to tags-on-commits-list though so that part can be merged.

I don’t think the color itself has any meaning for the user since this style only seems to appear in PRs headers

That's not true, it is literally also in the timeline:

And where linkify-branch-references apply:

These are just a few examples, I'm pretty sure there's more.

so claiming that it misleads the user is like saying all red cars look like Ferraris.

That style is from .commit-ref and it's called "commit ref" for a reason.

I think it's fine to make small deviations from GitHub conventions when it makes sense. I agree with fregante that the highlight is part of the feature, it's small and when you're actively looking for it the color makes a difference — especially on cramped hi-def screens.

Let's try


codegen output 82cbf8ea99d04165934487aec28218dc

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 44 (31.82%)  changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.2%) to 27.478%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/managers/files.generated.ts
0
1
0.0%

src/managers/folders.generated.ts
1
2
50.0%

src/managers/metadataTemplates.generated.ts
0
4
0.0%

src/managers/sessionTermination.generated.ts
0
5
0.0%

src/schemas.generated.ts
9
28
32.14%

Files with Coverage Reduction
New Missed Lines
%

src/schemas.generated.ts
1
21.91%

Totals

Change from base Build<PHONE_NUMBER>:
1.2%

Covered Lines:
4399

Relevant Lines:
11252

💛  - Coveralls


Thermaltake Pure Plus 14 software wont detect controller

My Pure Plus 14s aren't detected by the software. What should i do?

Are they detected by the official software?

What is the official software? I've been trying with the TT RGB Plus one till now.
Also, my controller is the one with the 3 buttons on it.... don't know if that gives you extra information or not

Yes, TT RGB Plus is the official software from thermaltake.
If your controller does not have usb connection then no software will be able to control it.

I bought the wrong product.... bought the regular Pure instead of the Pure Plus.... Sorry for wasting your time :/


Add package path to sys when downloading package as github archive

This fixes the coval.py metric so that imports within the downloaded module work correctly. We can use a similar trick to add the BLEURT metric (@ankparikh)
@thomwolf not sure how you feel about adding to the PYTHONPATH from the script. This is the only way I could make it work with my understanding of importlib but there might be a more elegant method.
This PR fixes https://github.com/huggingface/nlp/issues/305

Sorry for the long diff, everything after the imports comes from black for code quality :/

I think it's fine and I can't think of another way to make the import work anyways.
Maybe we can have the sys.path behavior inside prepare_module instead ? Currently it seems to come out of nowhere in the code ^^'
We could check if external imports have a __init__.py and if it is the case then we can add to directory to the PYTHONPATH


Limit on number of images?

My slider is limiting me to 10 images per slider. Why is this? I was previously able to put an unlimited amount of images into the slider

I'm getting the same issue. Could it be related to a max-width setting on the slider container or something?


Investigate novel pub/sub system test failure (only one message returned)

From: https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/77052107
======================================================================
ERROR: test_message_pull_mode_e2e (pubsub.TestPubsub)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/GoogleCloudPlatform/gcloud-python/system_tests/pubsub.py", line 129, in test_message_pull_mode_e2e
    message1, message2 = sorted(messages, key=_by_timestamp)
ValueError: need more than 1 value to unpack
----------------------------------------------------------------------

FWIW It seems pretty straightforward. Maybe we should revive #535? Our system tests are very flaky now.

Merging into #1085


[flutter_tools] add a mechanism to turn off immediate tool exit

Description
Instead of always exiting the tool, provide a mechanism to turn off this behavior for non-critical functionality like configuration and analytics settings.
Fixes https://github.com/flutter/flutter/issues/66786
Fixes https://github.com/flutter/flutter/issues/4674

Ahh TIL that we did not wrap readAsStringSync in error_handling_io. @zanderso was this an intentional choice, or just another method that needs to be added?
I can think of a few cases where we could handle the exception if reading fails ... but that could probably be fixed with this method too

Ahh TIL that we did not wrap readAsStringSync in error_handling_io. @zanderso was this an intentional choice, or just another method that needs to be added?

It wasn't intentionally omIt hadn't come up yet.

I can think of a few cases where we could handle the exception if reading fails ... but that could probably be fixed with this method too

sg.


lista kontrolna

Create a repository checklist

[ ] the task provides required feedback and has been submitted (needs grading)
[ ] the ability to clone the repository to the teacher's computer
[ ] there is README.md formatted as expected
[ ] README.md contains required information
[ ] build succeeded
[ ] all UTs are green

Create a repository checklist for teacher

[ ] the task provides required feedback and has been submitted (needs grading)
[ ] the ability to clone the repository to the teacher's computer
[ ] there is README.md formatted as expected
[ ] README.md contains required information
[ ] build succeeded
[ ] all UTs are green


Websocket Errs

Hi! Great boilerplate, thank you. I seem to be getting websocket errors consistently and I'm not sure how to address it:
On the server:
Error handling upgrade request TypeError: Cannot read properties of undefined (reading 'bind')
    at DevServer.handleRequestImpl (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/base-server.js:478:50)
    at async /Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/dev/next-dev-server.js:339:20
    at async Span.traceAsyncFn (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/trace/trace.js:154:20)
    at async DevServer.handleRequest (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/dev/next-dev-server.js:336:24)
    at async handleRoute (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/lib/router-utils/resolve-routes.js:305:33)
    at async resolveRoutes (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/lib/router-utils/resolve-routes.js:525:28)
    at async upgradeHandler (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/lib/router-server.js:454:50)
    at async Server.<anonymous> (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/lib/start-server.js:170:13)
 GET /ws/069/odjxga5b/eventsource 404 in 62ms
 GET /ws/info?t=1725293484684 404 in 118ms
Error handling upgrade request TypeError: Cannot read properties of undefined (reading 'bind')
    at DevServer.handleRequestImpl (/Users/bram/Dropbox/PARA/Projects/ycb-companion/node_modules/next/dist/server/base-server.js:478:50)
 GET /ws/262/oti0xwhd/eventsource 404 in 89ms

On the browser (using npm run dev):
contentScript.bundle.js:10529

      GET http://localhost:3000/ws/info?t=1725293622208 404 (Not Found)

EDIT: typo in title, I meant Websocket*

anything i should look at in particular?

anything i should look at in particular?

Unfortunately, the project doesn't use directly any websocket, it's probably some dependencies not working well.

Any udpates?

I found a few issues: https://github.com/vercel/next.js/issues/55802 and https://github.com/vercel/next.js/discussions/68216 but I haven't found a fix yet that worked

Thank you. Currently for now, I'm not able to reproduce it and it seems the issue is coming from Next.js.


get_parents function for getting parents by node keys

Hi again! I'm attempting to implementing breadcrumbs on the site I'm working on, and found it necessary to implement some kind of way of getting all parents of a node. Since I'm a little bit inexperienced I'm not sure if there are better ways of solving this issue, but this is my attempt at providing at least the basics. Sorry for not providing any tests, I might try to add some later.

I was a little bit scared of writing tests, but seems pretty easy so I'm writing them now. A little bit unsure of the correct order of returning parents. For breadcrumbs it's nice if the order is root first, but perhaps not conceptually correct really.

Also added a basic test.

Hi! Thanks so much :) I will merge your commits.
But please check the usage of categories to generate the breadcrumbs. It is how it is done on the glayu times theme page.eex

  <%= for category <- @page.categories do %>

<a href="<%= category.path %>" class="category"><%= category.name %>

   <% end %>

Hi! Yes this works for posts I think, but I was attempting to create breadcrumbs for category pages. I now realize that I would have been able to just fetch the first post and get the breadcrumbs from there, also on category pages, so thank you for clearing that up for me. :) But nice of you to merge it anyway.


Fall back to the CPU for non-zero scale on Ceil or Floor functions.

This fixes https://github.com/NVIDIA/spark-rapids/issues/4913.
Apache Spark has added scale parameter for Ceil/Floor functions in Spark-3.3 https://github.com/NVIDIA/spark-rapids/issues/4910. When ceil/floor functions are called with scale parameter, the physical plan changes compared to earlier. It adds RoundCeil/RoundFloor and the result type is decimal type.
In this PR, we have added support to RoundCeil and RoundFloor if the scale is 0. i.e we call GpuCeil if ceil is called with scale 0. For scale values other than 0, we fallback to CPU.

build

@gerashegalov @jlowe what do you guys think about adding utility classes, like RapidsFloorCeilUtils in this PR and RapidsErrorUtils previously, as we move forward as opposed to just adding methods in the SparkShims trait?
My vote is for having individual modular classes like the ones I mentioned above in favor of just adding methods to SparkShimsImpl.

build

build

build

CI failed due to databricks test failure. Fix is in https://github.com/NVIDIA/spark-rapids/pull/4998. Will upmerge once that PR is merged.

build


Add support for redirect with cookie authentication

In relation to feedreader/pluto#39, the request cookie gets saved for each redirect. This should support cookie based authentication.
The test passes on my computer, but I am not good at ruby code so I don't know if this really fixes the issue.

Sorry for the confusion - the fetcher gem is used by pluto and is "standalone", that is, it is not related to webclient.  The webclient is a newer gem NOT used in any way by fetcher (and, thus, pluto).  That might change long-term but not for now (there's only so much I can do).
Thus, you're welcome to look into the fetcher gem, see https://github.com/rubycoco/webclient/blob/master/fetcher/lib/fetcher/worker.rb for the core functionality.

Digging more into RFC 6265, it looks like the implementation in the first 2 commits was not compliant, as point 4 just says to pass back the cookie name and its value and to separate the list with ;.
It looks like it has to do with how I extracted the cookies using response[Set-Cookies]. The third commit should fix this issue.
If I understand correctly how the cookie process works and how it's implemented in [Net::HTTP](https://docs.ruby-lang.org/en/2.0.0/Net/HTTP.html#class-Net::HTTP-label-Response+Data, the server will return a comma-separated string of cookies in the Set-Cookie header. The client has to process the cookie string and pass it back to the server as a colon-separated string of cookies that just includes their name and value. In processing the string, the client should use the cookie attributes that the server set to just include the relevant cookies (more on this later).
As of the third commit in this pull request, the code processes the list of cookies and appends all of them to the next request.
Here is the trace of the fetch request (disregard the local version bump):
$ fetch 'https://link.springer.com/search.rss?search-within=Journal&facet-journal-id=10827'
fetcher/0.4.6 on Ruby 2.6.3 (2019-04-16) [universal.x86_64-darwin20]
[debug] uri.host=<link.springer.com>, uri.path=</search.rss>
[debug] fetch - copy src: https://link.springer.com/search.rss?search-within=Journal&facet-journal-id=10827 to dest<EMAIL_ADDRESS>[debug] using direct net http access; no proxy configured
[debug] GET /search.rss?search-within=Journal&facet-journal-id=10827 uri=https://link.springer.com/search.rss?search-within=Journal&facet-journal-id=10827, redirect_limit=5
[debug] 302 Found location=https://idp.springer.com/authorize?redirect_uri=https://link.springer.com/search.rss?search-within=Journal&facet-journal-id=10827&client_id=springerlink&response_type=cookie
[debug] Set cookie:
[debug] GET /authorize?redirect_uri=https://link.springer.com/search.rss?search-within=Journal&facet-journal-id=10827&client_id=springerlink&response_type=cookie uri=https://idp.springer.com/authorize?redirect_uri=https://link.springer.com/search.rss?search-within=Journal&facet-journal-id=10827&client_id=springerlink&response_type=cookie, redirect_limit=4
[debug] 302 Found location=https://idp.springer.com/transit?redirect_uri=https%3A%2F%2Flink.springer.com%2Fsearch.rss%3Fsearch-within%3DJournal&code=70db8b5c-9e2f-4470-b958-98a3f0f92710
[debug] Set cookie: idp_session=sVERSION_14bc31d57-065e-41b4-8f80-f0c9cfbebd4a; idp_session_http=hVERSION_16711a21a-9423-4f3a-9a58-34279722dc4d; idp_marker=204f0cc0-5014-45ce-a8fd-6c2a4bbd268a
[debug] GET /transit?redirect_uri=https%3A%2F%2Flink.springer.com%2Fsearch.rss%3Fsearch-within%3DJournal&code=70db8b5c-9e2f-4470-b958-98a3f0f92710 uri=https://idp.springer.com/transit?redirect_uri=https%3A%2F%2Flink.springer.com%2Fsearch.rss%3Fsearch-within%3DJournal&code=70db8b5c-9e2f-4470-b958-98a3f0f92710, redirect_limit=3
[debug] 302 Found location=https://link.springer.com/search.rss?search-within=Journal
[debug] Set cookie: idp_session=sVERSION_14bc31d57-065e-41b4-8f80-f0c9cfbebd4a; idp_session_http=hVERSION_16711a21a-9423-4f3a-9a58-34279722dc4d; idp_marker=204f0cc0-5014-45ce-a8fd-6c2a4bbd268a
[debug] GET /search.rss?search-within=Journal uri=https://link.springer.com/search.rss?search-within=Journal, redirect_limit=2
[debug] 200 OK
[debug]   content_type: text/xml, content_length:
Done.

You can see that now the client correctly sets the list of 3 cookies in-between redirects.
The only outstanding issue with this current implementation is that the client doesn't do any processing of the cookie list that it receives from the server. Instead, it just passes back all cookies to the next one. This should be fine as cookies are used in-between redirect requests and the cookie jar only lives for a short time. Let me know if you can think of any issues with the current implementation.

No worries. Thanks for taking the time. I try my best to wrap it all up early next week. Cheers. Prost.


Doubled/Duplicate bridged messages in matrix

Hi, I'm using the bridge with a discord user account, latest git master and latest stable synapse. Ever since this morning, the matrix versions of my discord private rooms are receiving 2 duplicate messages for every discord message. Before today, the bridge was working as expected. I don't think I changed anything when the problem started. I tried upgrading both the bridge and synapse once I noticed the problem, but it's still occurring.
I did notice that in a newly created matrix room (corresponding to a newly opened DM in discord), I didn't see duplicate messages, but I'm still getting duplicate messages in bridged matrix rooms/DMs that existed before today.
I'm using essentially the default configuration, just adjusted to my homeserver. Let me know if I can provide any other information for debugging.

Well, in typical software fashion, I tried restarting from a fresh database, and the duplicate messages have stopped.  I still have my old database around in case it's useful for debugging, but otherwise, problem solved.

Well, in typical software fashion, I tried restarting from a fresh database, and the duplicate messages have stopped.  I still have my old database around in case it's useful for debugging, but otherwise, problem solved.

Er, I spoke too soon. After a few hours of non-repeated messages, the problem is back. Not sure if there's other state I can clear besides the internal database.

Er, I spoke too soon. After a few hours of non-repeated messages, the problem is back. Not sure if there's other state I can clear besides the internal database.

Well, I figured it out. An old VPS i had mx-puppet-discord running on previous had rebooted, and I forgot that the service was started by default, so two bridges were running at the same time. Spooky zombie services.

Well, I figured it out. An old VPS i had mx-puppet-discord running on previous had rebooted, and I forgot that the service was started by default, so two bridges were running at the same time. Spooky zombie services.


Update zio, zio-test, zio-test-sbt to 1.0.0-RC21-2

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 1.0.0-RC20 to 1.0.0-RC21-2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

labels: library-update, semver-pre-release

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #93   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           41        41
=========================================
  Hits            41        41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d8773...88eab35. Read the comment docs.


Support pipeline factory functions as CLI reference

In our RAG use case, we want to start using a pipeline factory function, but this is currently not supported by the CLI.
This PR fixes that.
I also included a change (the first commit) which removes the finally blocks. We were using this as follows:
try:
    ref = ...
except SpecificError:
    ref = ...
finally:
    run(ref)

But apparently the finally block is also entered if any non-SpecificError exception is raised in the try block. This lead to all non-handled errors to become an UnboundLocal error. This is now no longer the case, and the original error is not caught.

But apparently the finally block is also entered if any non-SpecificError exception is raised in the try block. This lead to all non-handled errors to become an UnboundLocal error. This is now no longer the case, and the original error is not caught.

TIL

I'm going to review this tomorrow after a nights sleep 😉


Support of arrays in json configuration

I have a part of serilog config in json
   "WriteTo": [       {         "Name": "LiterateConsole"       },       {         "Name": "File",         "Args": {           "path": "C:\\Temp\\Logs\\log.txt",           "rollingInterval": "Day"         }       }     ],
Using the transform like this
  { "Serilog/WriteTo[1]/Args/path",  "test"  }
I got new node
   "WriteTo[1]": {       "Args": {         "path": "test"       }     }
Is it possible to work with arrays in json config?

I've been trying to work out the new Array support that was added to 2.0, and had some luck. Figured I'd share it.
First, I cloned the repository to my local machine to fiddle with things.
I tried using the Powershell stuff in the Samples\Powershell folder. However, the MagicChunks.dll file that is in there doesn't seem to support the Array stuff, so must be old.
Next, I went into the build directory and ran the build.ps1 script. Then I copied the MagicChunks.dll file from the working\dotnet directory, into the Samples\powershell folder, overwriting the file there.
Then I added your JSON to the config.json file in there.
Using the powershell guide, I was able to get your transform listed above to work perfectly.
PS C:\Development\magic_chunks\samples\powershell> Import-Module ".\MagicChunks.psm1"
PS C:\Development\magic_chunks\samples\powershell> Format-MagicChunks -path ".\config.json" -transformations @{
>> "WriteTo[1]/Args/path" = "test";
>> }

There are some examples of how to use the new array syntax in the src/MagicChunks.Tests/Documents/JsonDocumentTests.cs file. You can use index lookup, as you requested, as well as by property value.
Hope that helps. Now I have to get it working in my TFS build. ;)

Thank you @smansker , this worked for me with the following transformation after refreshing the MagicChunks.dll in Samples\Powershell folder (Release 2.0):
{ "array[0]/path" = "test"; }
Although I couldn't make it work when my json config file is an array so I wanted to use the following transformation:
{ "[0]/path" = "test"; }
on a json file with the following structure:
[ { "path": "to be replaced"}, ... ]
Here is the result:
"Unable to cast object of type 'Newtonsoft.Json.Linq.JArray' to type 'Newtonsoft.Json.Linq.JObject'."


Module is not waiting for cluster to sync

We use a ci/cd system to test our deployment and in some (timing-)edge-cases the module is unable bootstrap / setup the galera-cluster, because it tries to do queries while cluster is still "not synced".
This commit is [WIP], because I personally dont like the "file creation" just to do checks, but I currently dont have the time or ideas how to solve this a bit smarter.

@devfaz I've converted your PR to a draft. Let me know when it's done, so I start reviewing it.

@devfaz Any news on this?

Timeout. Please report back if you're still interested to get this merged.


TypeError: sequence item 1: expected str instance, NoneType found

$ git clone https://github.com/fabioparra/TypeScript.git; cd TypeScript
$ git checkout bc691ef78ec
$ ipython3
from git2json.parser import parse_commits
from git2json import run_git_log
list(parse_commits(run_git_log('.git')))

TypeError                                 Traceback (most recent call last)
<ipython-input-4-a4fe5c202781> in <module>()
----> 1 list(parse_commits(run_git_log('.git')))

~/.virtualenvs/bayesian/lib/python3.6/site-packages/git2json/parser.py in parse_commits(data)
     47         full_commit = rc.groups()[0]
     48         parts = RE_COMMIT.match(full_commit).groupdict()
---> 49         parsed_commit = parse_commit(parts)
     50         yield parsed_commit
     51

~/.virtualenvs/bayesian/lib/python3.6/site-packages/git2json/parser.py in parse_commit(parts)
     71         parse_message_line(msgline)
     72         for msgline in
---> 73         parts['message'].splitlines()
     74     )
     75     commit['changes'] = [

TypeError: sequence item 1: expected str instance, NoneType found

I believe this has been fixed with https://github.com/tarmstrong/git2json/pull/17 but since I wasn't able to reproduce this problem locally, it would be helpful to have your confirmation that it is fixed.


Init is not defined

Hello! I was following the tutorial provided on the main site, which uses version 0.9.17, and at some point, when I'm going to install the dependencies by executing pyb install_dependencies I get the following error:
BUILD FAILED - name 'init' is not defined
Since I installed pybuilder with pip and I got the latest version (0.11.12) I might be doing something wrong. Here is a copy of my build.py file at the moment of the issue.
from pybuilder.core import use_plugin
use_plugin("python.core")
use_plugin("python.unittest")
use_plugin("python.install_dependencies")
default_task = "publish"
@init
def initialize(project):
   project.build_depends_on('mockito')

Resolved


Not in names.

Does this work?
Just Descriptions - https://help.github.com/articles/github-flavored-markdown/)

And Comments - https://help.github.com/articles/github-flavored-markdown/)


Re-add diff functionality.

This feature was left out when making the change to Go and it'd be great if we could add it back.
Basically, after running the scraper, we run git diff on the two latest data entries. Should only happen when the script is executed with a `--diff flag, i.e.
$ ./scraper --diff

Added in https://github.com/kshvmdn/intern-supply-scraper/commit/74133e14730318c150ccd5af15a0a663f2d1b28d.


Tag and product lists

Show how nested tag and product lists are managed by admins in either OneDrive or GitHub, and how authors can pick and insert them in their articles.

i think a bookmark in the authors browser could be the way to go initially...

for now the tags.md in /tools/tagger controls the taxonomy and i built a quick node script that extracts the taxonomy from an AEM project into the respective .md with nested lists
https://github.com/davidnuescheler/cqtags2md

I just tested id, and it leaves a trailing comma:
Products: AEM Forms on JEE, AEM Forms on OSGi,
Topics:

Fwiw, I think the client side code remdering the tag links should be able to handle trailing commas.

Fwiw, I think the client side code rendering the tag links should be able to handle trailing commas.

yes. this is why I reported it here. :-)

Done


Crash Report: Argument rangeInElement (88,360) endOffset must not exceed descriptor text range (1444, 1576) length (132).

Description
Stacktrace
Please paste the full stacktrace from the IDEA error popup

Thanks for reporting! This issue has already been reported in #493 and has been solved in commit a4caa3cf552a4c36472dd610eaf15fc98df53859. A new release which includes the fix will be available when one of the owners has the time to upload it to Jetbrains.


Parameterized Queries with Dapper: Syntax Error

just tried to use parametrized queries with dapper. unfortuantely i get the error below. is there a way to use this with dapper directly?
var connectionString = "Data Source=:memory:";
using (var cn = new DuckDBConnection(connectionString))
{
    cn.Open();

    Console.WriteLine("DuckDB version: {0}", cn.ServerVersion);

    cn.Execute("CREATE TABLE test (id INTEGER, name VARCHAR)");

    var query = cn.Query<Row>("SELECT * FROM test");
    Console.WriteLine("Initial count: {0}", query.Count());

    cn.Execute("INSERT INTO test (id,name) VALUES (123,'test')");
    cn.Execute("INSERT INTO test (id,name) VALUES (567,'blub')");
    cn.Execute("INSERT INTO test (id,name) VALUES (567,NULL)");

    var test_parameter = cn.Query("SELECT * FROM $test", new { test = "test" });
}

also tried something like this:
var test_parameter = cn.Query("SELECT * FROM $test", new DuckDBParameter("test", "test"));

the error:
DuckDB.NET.Data.DuckDBException: 'Parser Error: syntax error at or near "$"'`

I think you can't parameterize the table name.

The following works fine: var test_parameter = cn.Query("SELECT * FROM test where id = $id", new { id = 123 });

I think you can't parameterize the table name.

thanks! looks like SQL in general can't use parametrized names for tables. I guess i need to keep string formatting in C# then..


Cleanup examples and docs

Remove old examples and add new examples in godoc format.
These get compiler check on test run, so should be less
fragile and will show up better in the go docs.
Resolves: #20

@cpkurotori I know... its far from complete, but I wanted to get some of the non-working stuff removed and cleaned up.
Thanks for the review.


chore(master): release 2.7.16

:robot: I have created a release beep boop
2.7.16 (2024-10-07)
Dependencies

deps: update actions/checkout action to v4.2.1 (cf25903)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.7.16
:sunflower:


Abhishek.kumar1/ravtdbq 48 support json datatype

L1 review is done

Changes looks good.
L2 completed.


The modified configmap in "istio" does not take effect in  time

Bug description
Hi, I enconter a problem when I use kubectl edit cm istio -n istio-system to modify an entry, for example the zipkin address. I found this modification took effect in the configuration file in istiod, while no changes in sidecar of productpage pod. By the way, I check the file in path /etc/istio/proxy/envoy-rev0.json. After I delete the productpage pod, the address changed.
My istio version is 1.5.0
Expected behavior
Steps to reproduce the bug

Use kubectl edit cm istio -n istio-system to modify entry
check /etc/istio/proxy/envoy-rev0.json in any sidecar.

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
How was Istio installed?
istioctl manifest apply --set profile=demo
Environment where bug was observed (cloud vendor, OS, etc)
CentOS 7.3

This is working as expected. Its a bootstrap configuration, we cannot change it at runtime

Closing as this is working as expected


Creating a credit memo generates error

When we try to create a credit memo on the "Channable - Returns" page, the following error is generated:
"Unable to locate the order Item-ID if imported return."

Scenario:

Go to the returns page channable/returns/index/
Select an item
Via the actions choose Create Credit Memo
An error is shown

The error is generated in \Magmodules\Channable\Service\Returns\CreateCreditmemo::execute   (link) because \Magmodules\Channable\Service\Returns\CreateCreditmemo::findOrderItemId  can't find a itemId because the $item['gtin']  is not the SKU but the afas_eancode  . There is no sku in the $item array so this will always result in an error.
There is a getSkuFromGtin method in the GetByOrder class but this is a private method as are the methods needed for this method.

Hi @AndrewRMillar,
Thank you for providing a detailed breakdown of the issue.
We’ve implemented a fix, which will be included in the next release.
I’ll keep the issue open for now, so we can update you once the official release is available.


Need help: I need to use a door magnetic sensor to provide feedback on the door switch in the 3D layout

The code is as follows. I have used Sweet Home 3D software to draw the house type diagram and exported it in OBJ format. The room door is closed by default, and the 3D house type diagram can be displayed correctly on the front end of HA. I have added the entity of the door magnetic sensor to display the opening and closing of the door, but an error is reported. I don't know where the problem is, please request help!
`type: custom:floor3d-card
path: /local/floor3d-card
name: Home
objfile: 985.obj
mtlfile: 985.mtl
entities:

entity: binary_sensor.sxpad_is_charging
entity: binary_sensor.lumi_lumi_sensor_magnet_aq2_opening
type3d: door
door:
doortype: swing
side: right
direction: inner
degrees: '60'
hinge: null
object_id: sweethome3d_opening_on_hinge_1_door_382
action: more-info
zoom_areas:
zoom: ''
lock_camera: 'no'
selectionMode: 'no'
editModeNotifications: 'yes'
header: 'yes'
click: 'no'
overlay: 'no'
hideLevelsMenu: 'no'
shadow: 'no'
extralightmode: 'no'
show_axes: 'no'
sky: 'no'
globalLightPower: '0.8'
backgroundColor: transparent
`

TypeError: Cannot read properties of undefined (reading 'objects')
at floor3d-card.js:2356:6622
at Array.forEach ()
at bf._add3dObjects (floor3d-card.js:2356:4982)
at bf._onLoaded3DModel (floor3d-card.js:2288:35635)
at Object.onLoad (floor3d-card.js:2231:531770)
at XMLHttpRequest. (floor3d-card.js:2231:435962)
floor3d-card.js:2356 Error: Object issue for Entity: <binary_sensor.lumi_lumi_sensor_magnet_aq2_opening> TypeError: Cannot read properties of undefined (reading 'objects')
at floor3d-card.js:2356:11044
at Array.forEach ()
at bf._add3dObjects (floor3d-card.js:2356:4982)
at bf._onLoaded3DModel (floor3d-card.js:2288:35635)
at Object.onLoad (floor3d-card.js:2231:531770)
at XMLHttpRequest. (floor3d-card.js:2231:435962)

Hello @bugensui2022, you need to provide a hinge or a panel object. The object-id represent the group of elements of the door that are moving when you open and close the door. The hinge represent the object-id of the door hinge which is also the axis on which the door is swinging. The panel object is used when you do not have the hinge to repesent the main element of the door. There are some examples in the card guide even if I recognize it is not always trivial to use

您好，您需要提供铰链或面板对象。对象 ID 表示打开和关闭门时正在移动的门元素组。铰链表示门铰链的对象 ID，它也是门摆动的轴。当您没有铰链来回收门的主要元素时，将使用面板对象。卡片指南中有一些示例，即使我认识到使用并不总是微不足道的

Thank you for your help

Hello @bugensui2022, you need to provide a hinge or a panel object. The object-id represent the group of elements of the door that are moving when you open and close the door. The hinge represent the object-id of the door hinge which is also the axis on which the door is swinging. The panel object is used when you do not have the hinge to repesent the main element of the door. There are some examples in the card guide even if I recognize it is not always trivial to use

Thank you for your help

If you were able to fix, can I please ask you to close the issue ?

If you were able to fix, can I please ask you to close the issue ?
OK


need an exact length shape builder: Len

same impl as Min, Max, etc

[x] implemented
[ ] documented


re-implement transitionLineBreakState with generics

goos: darwin
goarch: arm64
pkg: github.com/shogo82148/uniseg
                      │   .old.txt   │              .new.txt               │
                      │    sec/op    │    sec/op     vs base               │
LineFunctionBytes-10    0.6215n ± 1%   0.6212n ± 0%       ~ (p=0.305 n=10)
LineFunctionString-10   0.6210n ± 0%   0.6211n ± 0%       ~ (p=0.671 n=10)
geomean                 0.6213n        0.6212n       -0.02%

                      │   .old.txt   │              .new.txt               │
                      │     B/op     │    B/op     vs base                 │
LineFunctionBytes-10    0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
LineFunctionString-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                            ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                      │   .old.txt   │              .new.txt               │
                      │  allocs/op   │ allocs/op   vs base                 │
LineFunctionBytes-10    0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
LineFunctionString-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                            ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 18 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 95.864%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
788

Relevant Lines:
822

💛  - Coveralls


Sanitize user subreddit input

Link to regex101 with the regex I used: https://regex101.com/r/SOJjWZ/4
Sanitizes subreddit inputs from a variety of formats.

thanks for the pr :D


getting this error when i try to run and i use clien as intentionally

Exception in thread Thread-133:
Traceback (most recent call last):
  File "C:\Users\Nc\AppData\Local\Programs\Python\Python37\lib\threading.py", line 926, in _bootstrap_inner
    self.run()
  File "C:\Users\Nc\AppData\Local\Programs\Python\Python37\lib\threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "gh.py", line 40, in send
    skylink =clien.upload_file('cctv.jpg')
  File "C:\Users\Nc\AppData\Local\Programs\Python\Python37\lib\site-packages\siaskynet\_upload.py", line 87, in upload_file
    sia_url = utils.uri_skynet_prefix() + response.json()["skylink"]
  File "C:\Users\Nc\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\models.py", line 900, in json
    return complexjson.loads(self.text, **kwargs)
  File "C:\Users\Nc\AppData\Local\Programs\Python\Python37\lib\json\__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "C:\Users\Nc\AppData\Local\Programs\Python\Python37\lib\json\decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Users\Nc\AppData\Local\Programs\Python\Python37\lib\json\decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Can you please provide a snippet of your code, too?

def send():
    cv2.imwrite(filename='cctv.jpg', img=frame)
    limb = "https://siasky.net"+skylink.strip("sia:")
    message = client.messages.create(
                          body=f"person detected confidence is {conf}",
                          media_url=limb,
                          from_='whatsapp:+14155238886',
                          to='whatsapp:+918360073016'
                      )
t1 = threading.Thread(target=send)
if label ==['person']:
    t1.start()

def send():
    time.sleep(5)
    cv2.imwrite(filename='cctv.jpg', img=frame)
    skylink = clien.upload_file('cctv.jpg')
    limb = "https://siasky.net"+skylink.strip("sia:")
    message = client.messages.create(
                          body=f"person detected confidence is {conf}",
                          media_url=limb,
                          from_='whatsapp:+14155238886',
                          to='whatsapp:+918360073016'
                      )
t1 = threading.Thread(target=send)
if label ==['person']:
    t1.start()

We've been having some issues with our servers that could be causing this. Can you please try again or try uploading to e.g. https://siasky.xyz?
Also: the error message should be improved on our end -- but we're not really actively working on this SDK right now. I'll leave the issue open though.


tools/update-version.sh is not working

It seems that it does not support
version.workspace = true

style.

closed by #809


Join duration w/ backoff

This is a quick hotfix to apply a backoff delay for the join process.
It'll backoff exponentially up to the max join delay (2 mins) in between each retry and try to join up to the max join duration (20 mins). Ringpop will flag the developer with an error when the join delay reaches its max. If join duration is exceeded, Ringpop'll still do nothing and just idle naively waiting for something to be done. A continuous joiner and refusing gossip communication are left for future PRs.
@uber/ringpop

nits aside, lgtm

:+1: lgtm


⚠ Turnos 24x7 has degraded performance

In 2e5e88f, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 981 ms

Resolved: Turnos 24x7 performance has improved in 2f402ff.


Favorites List or Recent Search (Search 'n Pick)

Is your feature request related to a problem? Please describe.
Using Search 'n Pick to find the same names of "things" during different playthroughs or moments of play.
Describe the solution you'd like
Would it be possible to get a Favorites system? Like mark this as a Favorite and then have a Favorites List that you can see all your Favorite Items, Traits, Feats.
Describe alternatives you've considered
Also as another point of this a Recent Search History could work if easier to implement then a Favorites system!

👍 Really would love this.
also, if possible, I would love to be able to define "sets", and to be able to add sets to character with one click
for example, I always add trickster nature 1/2/3 + trickster knowledge arcana 1/2/3 + trickster use magic device 1/2 to all my companions/pets
Would really love to be pack them in a "trickster feat" set and be able to add them all with one click
two-weapon-fight
monk styles
are other notable example of "nice to have" sets...


feat(protocol): Enable protocol to handle multiple proof types

Related to: https://github.com/taikoxyz/taiko-mono/issues/13731

[x] Code changes required to verify multiple proofs
[x] Code changes required to overwrite unverified fork choice
[x] Test changes of multiple proofs (ZKP & SGX) + overwrite unverified FK
[x] Adjust other tests to changes

I think this PR still has a high level design issue: the proofToggleMask can only specify an AND logics, but not something like: *if a valid SGX proof is given, then ZKP is not necessary; *.

Need to remvoe ""oracle_prover" and "system_prover" everywhere.

I think this PR still has a high level design issue: the proofToggleMask can only specify an AND logics, but not something like: *if a valid SGX proof is given, then ZKP is not necessary; *.

Could you give a scenario where we would use conditional logic like that? I saw this only really as an all proofs that are enabled are required thing.
I could see some benefit of the different proofs coming in at different times (like SGX proof first, which would set the cooldown period still pretty high, then a zkp proof that lowers it) but in practice I think probably doesn't really make a difference (we'll always want the zkp anyway, which is the slowest, and all of them being required all the time is best for security), and complicates things quite a bit like the fee payments.
We could still implement something like this in a verifier contract, the main protocol would would just require a single proof related to that verifier contract, but internally the verifier contract can do whatever it wants so could contain multiple sub-proofs with some special logic. This would actually be a pretty nice way to implement the testnet scenario where we want to skip some ZKP proofs, then there's no need to build this into the core protocol.
So maybe let's simplify the core protocol as much as possible and only let it support a single "proof" (as in some data and a verifier contract to call), then let the verifier contract handle the rest.

Probably makes more sense to do the opposite which I think is what we already do, make a release for alpha-n, and keep working on main.

@adaki2004  given that our core protocol and tokenomics have changed a lot, shall we close this PR then re-implement the idea later?


add a completion handler for -dismiss()

add a completion handler for -dismiss()

Current coverage is 0.00%

Merging #7 into develop will not affect coverage as of 7ceea0e

@@            develop    #7   diff @@
=====================================
  Files             4     4
  Stmts           116   116
  Branches          0     0
  Methods           0     0
=====================================
  Hit               0     0
  Partial           0     0
  Missed          116   116

Review entire Coverage Diff as of 7ceea0e

Powered by Codecov. Updated on successful CI builds.

Thanks @Limon-O-O ! :smile:
A couple of things here:
Personally, I've never used this parameter and that's one reason why it was intentionally omitted. To me, doing almost anything in the completion block here is a code smell — usually the view lifecycle methods are more appropriate (and better) for any cleanup or teardown for a view controller.
Aside from that, now the behavior here is a bit weird given this is possibly using popViewControllerAnimated, where there is no completion parameter.
Let me know if there's a good use-case that I'm missing! :blush:

I have a tableView, like this

And I want to call a protocol method source?.didSelectRowAtIndex(indexPath.row) in completion()
func tableView(tableView: UITableView, didSelectRowAtIndexPath indexPath: NSIndexPath) {
        tableView.deselectRowAtIndexPath(indexPath, animated: true)

        dismiss() {
            self.source?.didSelectRowAtIndex(indexPath.row)
        }
    }

Take your advice,
override func viewDidDisappear(animated: Bool) {
   super.viewDidDisappear(animated)

    if let didSelectRow = didSelectedRow {
        source?.didSelectRowAtIndex(didSelectRow)
    }
 }

@Limon-O-O :+1:
It looks like you are keeping a var to track this state, didSelectRow — but you don't need to:

don't call deselectRowAtIndexPath inside didSelectRowAtIndexPath
use indexPathForSelectedRow inside viewDidDisappear

override func viewDidDisappear(animated: Bool) {
   super.viewDidDisappear(animated)

    if let indexPath = tableView.indexPathForSelectedRow {
        tableView.deselectRowAtIndexPath(indexPath, animated: true)
        source?.didSelectRowAtIndex(indexPath)
    }
 }

Wow, help me a lot, thanks :)


Dialogue.Stop() sometimes has null VM

Wondering if It'd be alright to add a null check for the vm in Dialogue.Stop() (Dialogue.cs line 245)
Just seeing it error log a null there sometimes.

Makes sense to add a check like that. The only time I think that could happen is if the dialogue is unloaded before Stop is called; are you seeing it happen at other times?

On 2 Mar 2016, at 7:21 AM, Alexander Holowka<EMAIL_ADDRESS>wrote:
Wondering if It'd be alright to add a null check for the vm in Dialogue.Stop() (Dialogue.cs line 245)
Just seeing it error log a null there sometimes.
—
Reply to this email directly or view it on GitHub.

Not sure why it's happening yet, might investigate further...

Actually, reading the code, the VM is never set to null. The only time it can be null is after you create the Dialogue, but before you call Run.
Anyway, adding a check, because it’s sensible to do so!

On 2 Mar 2016, at 7:26 AM, Alexander Holowka<EMAIL_ADDRESS>wrote:
Not sure why it's happening yet, might investigate further...
—
Reply to this email directly or view it on GitHub https://github.com/thesecretlab/YarnSpinner/issues/29#issuecomment-190886731.

Package attached!
YarnSpinner-<IP_ADDRESS>-2-g02a69ab-development-source-minimal.unitypackage.zip


[Bug][azure devops] got error when restart

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
time="2023-05-15 14:04:10" level=error msg="failed to load plugins
caused by: get error when invoking remote function run-migrations
Wraps: (2) remote error response:
| Traceback (most recent call last):
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1900, in _execute_context
|     self.dialect.do_execute(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
|     cursor.execute(statement, parameters)
| psycopg2.errors.SyntaxError: syntax error at or near "PRIMARY"
| LINE 1: ALTER TABLE _tool_azuredevops_jobs DROP PRIMARY KEY
|                                                 ^
|
|
| The above exception was the direct cause of the following exception:
|
| Traceback (most recent call last):
|   File "/app/python/plugins/azuredevops/azuredevops/main.py", line 132, in
|     AzureDevOpsPlugin.start()
|   File "/app/python/pydevlake/pydevlake/plugin.py", line 265, in start
|     fire.Fire(PluginCommands(plugin))
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/fire/core.py", line 141, in Fire
|     component_trace = _Fire(component, args, parsed_flag_args, context, name)
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/fire/core.py", line 466, in _Fire
|     component, remaining_args = _CallAndUpdateTrace(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
|     component = fn(*varargs, **kwargs)
|   File "/app/python/pydevlake/pydevlake/ipc.py", line 54, in wrapper
|     ret = func(self, *args)
|   File "/app/python/pydevlake/pydevlake/ipc.py", line 105, in run_migrations
|     self._plugin.run_migrations(create_db_engine(db_url), force)
|   File "/app/python/pydevlake/pydevlake/plugin.py", line 120, in run_migrations
|     model.migrate(session)
|   File "/app/python/plugins/azuredevops/azuredevops/models.py", line 129, in migrate
|     session.execute(f'ALTER TABLE {self.tablename} DROP PRIMARY KEY')
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlmodel/orm/session.py", line 101, in execute
|     return super().execute(  # type: ignore
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/orm/session.py", line 1712, in execute
|     result = conn._execute_20(statement, params or {}, execution_options)
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1705, in _execute_20
|     return meth(self, args_10style, kwargs_10style, execution_options)
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/sql/elements.py", line 333, in _execute_on_connection
|     return connection._execute_clauseelement(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1572, in _execute_clauseelement
|     ret = self._execute_context(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1943, in _execute_context
|     self.handle_dbapi_exception(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2124, in handle_dbapi_exception
|     util.raise(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/util/compat.py", line 208, in raise
|     raise exception
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1900, in _execute_context
|     self.dialect.do_execute(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
|     cursor.execute(statement, parameters)
| sqlalchemy.exc.ProgrammingError: (psycopg2.errors.SyntaxError) syntax error at or near "PRIMARY"
| LINE 1: ALTER TABLE _tool_azuredevops_jobs DROP PRIMARY KEY
|                                                 ^
|
| [SQL: ALTER TABLE _tool_azuredevops_jobs DROP PRIMARY KEY]
| (Background on this error at: https://sqlalche.me/e/14/f405)
Wraps: (3) exit status 1
Wraps: (4) exit status 1
Error types: (1) *hintdetail.withDetail (2) *hintdetail.withDetail (3) *hintdetail.withDetail (4) *exec.ExitError"
panic: get error when invoking remote function run-migrations
Wraps: (2) remote error response:
| Traceback (most recent call last):
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1900, in _execute_context
|     self.dialect.do_execute(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
|     cursor.execute(statement, parameters)
| psycopg2.errors.SyntaxError: syntax error at or near "PRIMARY"
| LINE 1: ALTER TABLE _tool_azuredevops_jobs DROP PRIMARY KEY
|                                                 ^
|
|
| The above exception was the direct cause of the following exception:
|
| Traceback (most recent call last):
|   File "/app/python/plugins/azuredevops/azuredevops/main.py", line 132, in
|     AzureDevOpsPlugin.start()
|   File "/app/python/pydevlake/pydevlake/plugin.py", line 265, in start
|     fire.Fire(PluginCommands(plugin))
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/fire/core.py", line 141, in Fire
|     component_trace = _Fire(component, args, parsed_flag_args, context, name)
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/fire/core.py", line 466, in _Fire
|     component, remaining_args = _CallAndUpdateTrace(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
|     component = fn(*varargs, **kwargs)
|   File "/app/python/pydevlake/pydevlake/ipc.py", line 54, in wrapper
|     ret = func(self, *args)
|   File "/app/python/pydevlake/pydevlake/ipc.py", line 105, in run_migrations
|     self._plugin.run_migrations(create_db_engine(db_url), force)
|   File "/app/python/pydevlake/pydevlake/plugin.py", line 120, in run_migrations
|     model.migrate(session)
|   File "/app/python/plugins/azuredevops/azuredevops/models.py", line 129, in migrate
|     session.execute(f'ALTER TABLE {self.tablename} DROP PRIMARY KEY')
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlmodel/orm/session.py", line 101, in execute
|     return super().execute(  # type: ignore
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/orm/session.py", line 1712, in execute
|     result = conn._execute_20(statement, params or {}, execution_options)
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1705, in _execute_20
|     return meth(self, args_10style, kwargs_10style, execution_options)
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/sql/elements.py", line 333, in _execute_on_connection
|     return connection._execute_clauseelement(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1572, in _execute_clauseelement
|     ret = self._execute_context(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1943, in _execute_context
|     self.handle_dbapi_exception(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2124, in handle_dbapi_exception
|     util.raise(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/util/compat.py", line 208, in raise
|     raise exception
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1900, in _execute_context
|     self.dialect.do_execute(
|   File "/root/.cache/pypoetry/virtualenvs/azuredevops-ANnMAkq9-py3.9/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
|     cursor.execute(statement, parameters)
| sqlalchemy.exc.ProgrammingError: (psycopg2.errors.SyntaxError) syntax error at or near "PRIMARY"
| LINE 1: ALTER TABLE _tool_azuredevops_jobs DROP PRIMARY KEY
|                                                 ^
|
| [SQL: ALTER TABLE _tool_azuredevops_jobs DROP PRIMARY KEY]
| (Background on this error at: https://sqlalche.me/e/14/f405)
Wraps: (3) exit status 1
Wraps: (4) exit status 1
Error types: (1) *hintdetail.withDetail (2) *hintdetail.withDetail (3) *hintdetail.withDetail (4) *exec.ExitError
goroutine 1 [running]:
github.com/apache/incubator-devlake/server/services.Init()
/app/server/services/init.go:97 +0x229
github.com/apache/incubator-devlake/server/api.CreateApiService()
/app/server/api/api.go:63 +0x3d
main.main()
/app/server/main.go:44 +0x8a
What do you expect to happen
I don't know what happend. I think maybe there a bug in python migration.
How to reproduce

deploy devlake by docker-compose.yml
stop and re-deploy.

Anything else
No response
Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@likyh I suppose you have enabled postgresql in docker-compose.yml and .env, right?

@likyh I suppose you have enabled postgresql in docker-compose.yml and .env, right?

Yes, I use it in Postgres


Using IDestinationConfiguration instead of AppConfig parameters

Hi Guilherme,
First of all, I'd like to express my utmost thanks for creating SharpSapRfc on here. It helps to reduce my work a lot and surely it simplifies to a great extent in dealing with the the SAP .Net connector coding complexities.
Please pardon my novice knowledge in the area but is it possible to use your package with our own SAP connection parameters created on the fly (instead of getting them from Appconfig file) by implementing the IDestinationConfiguration interface?
Many thanks in advance and keep up the brilliant work!
Kind regards,
Faizul

Forgot to mention that I'd like to know whetherit's possible that SoapSapRfcConnection could be used without having to read parameters from static config file as well. Cheers.

Hi f4i2u1,
You can achieve that by implementing your own IDestinationConfiguration class, this way you can set your parameters dynamically.
Take a look at this example.
public class Program
{
    public class CustomDestinationConfig : IDestinationConfiguration
    {
        public object ConfigurationManager { get; private set; }

        public bool ChangeEventsSupported()
        {
            return false;
        }

        public event RfcDestinationManager.ConfigurationChangeHandler ConfigurationChanged;

        public RfcConfigParameters GetParameters(string destinationName)
        {
            if (destinationName == "MY_CUSTOM_CONN")
            {
                RfcConfigParameters parms = new RfcConfigParameters();
                parms.Add(RfcConfigParameters.Name, "MY_CUSTOM_CONN");
                parms.Add(RfcConfigParameters.AppServerHost, "yourserver.com");
                parms.Add(RfcConfigParameters.SystemNumber, "00");
                parms.Add(RfcConfigParameters.SystemID, "ECC");
                parms.Add(RfcConfigParameters.User, "user");
                parms.Add(RfcConfigParameters.Password, "p$ss");
                parms.Add(RfcConfigParameters.Client, "100");
                return parms;
            }
            else
                throw new ArgumentOutOfRangeException(destinationName);
        }
    }

    public static void Main(string[] args)
    {
        RfcDestinationManager.RegisterDestinationConfiguration(new CustomDestinationConfig());

        using (SapRfcConnection conn = new PlainSapRfcConnection("MY_CUSTOM_CONN"))
        {
            var result = conn.ExecuteFunction("Z_SSRT_SUM",
                new RfcParameter("i_num1", 2),
                new RfcParameter("i_num2", 4)
            );

            var total = result.GetOutput<int>("e_result");
        }
    }
}

Regarding dynamic configuration with SoapSapRfcConnection, unfortunately it is not possible. That was something I didn't think about.
I will put this on my schedule and release a minor update (2.0.9) with this feature, it should be easy to implement.

Many thanks and looking forward for the minor update!

Ok, it's done, you can take a look at this test case [1] for an example.
I'm planning to push v2.0.9 to NuGet before Friday.
[1] ConnectionTestCase.cs

Excellent! Many thanks for the help and quick turnaround, really appreciate
it!
Kind regards,
Faizul
On Wed, Jan 13, 2016 at 12:27 AM, Guilherme Oenning <
<EMAIL_ADDRESS>wrote:

Ok, it's done, you can take a look at this test case [1] for an example.
I'm planning to push v2.0.9 to NuGet before Friday.
[1] ConnectionTestCase.cs
https://github.com/goenning/SharpSapRfc/blob/bb241cf1e2117d1a94af8c6f8bb825b654ba1bfa/tests/TestCases/ConnectionTestCase.cs
—
Reply to this email directly or view it on GitHub
https://github.com/goenning/SharpSapRfc/issues/33#issuecomment-171061720
.


Upgrade imgui to 0.10

Checklist

[ ] I have read the Contributor Guide
[ ] I have read and agree to the Code of Conduct
[ ] I have added a description of my changes and why I'd like them included in the section below

Description of Changes
Describe your changes here
Related Issues
List related issues here

Could you add a change log thingy?

Will try make some time doing the release. Does it have hurry?