require a store for buffering

turns out the logs endpoint is:

different than the artifacts endpoint
doesn't support Range 😠

in light of that, add store as a required variable for the caller to create, seeing that it must properly be closed as well. this exposes the caller to httpreaderat which I don't love, but its simple to implement and seems worth it for easy conditional buffering
this also changes the return signature to a *zip.Reader, since it appears logs are also returned as zip files

Does httpreaderat just do buffering internally in this case? What do we get from it if we aren't using it to abstract Range?

it conditionally buffers to memory (1Mb by default) and file (1Mb<x<1Gb)

cc @jonjohnsonjr so this atrocity is on your radar. hoping to not need this soon


Pointerfication followup: Type safety and cleanup

Objective
The Ptr types gives free access to the underlying NonNull<u8>, which adds more publicly visible pointer wrangling than there needs to be. There are also a few edge cases where Ptr types could be more readily utilized for properly validating the soundness of ECS operations.
Solution

Replace *Ptr(Mut)::inner with cast which requires a concrete type to give the pointer. This function could also have a debug_assert with an alignment check to ensure that the pointer is aligned properly, but is currently not included.
Use OwningPtr::read in ECS macros over casting the inner pointer around.

Adding the Controversial tag due to the technical trickery involved, to make sure we get Cart to review this before merging.

All the use sites you changed seem to immediately .as_ptr() and also all seem to be using T = u8 because of it being blobvec internals. I think we ought to change inner(&self) -> NonNull<u8> to as_ptr(self) -> *mut u8 instead. I like the changes to use .read though :)

Main reason I chose cast was to effectively treat Ptr types like void*: you need to give it an underlying type to have any meaningful operation on it. The fact that BlobVec uses u8 internally is just an artifact of the interface it uses. The uses in Deref(Mut) and read likewise enforce this usage too. This is in the crate's public interface, and IMO we should try to smooth out the rough edges on anything we mark pub before someone starts relying on it.
Ideally, moving the pointer casts and conversions into Ptr types behind a carefully curated public interface also allows us to provide wider runtime safety checks in debug mode (as the comment in the OP above suggests) to ensure the lower level safety invariants don't get broken.

If you know the underlying type you should be calling deref/deref_mut/read and working with borrows instead. The only reason these types exist instead of using borrows is because we do not know the underlying type. There should never be a reason to do .cast::<RealType>.

@BoxyUwU made the changes requested, ended up adding OwningPtr::drop_as and making as_ptr into pub(crate). This should at least disable using raw *mut u8 in userspace/non-ECS code and force use of the typed APIs.
With that said, is there a reason why OwningPtr does not have deref(_mut)?

IMO we should revert to_ptr -> as_ptr, as to_* methods signify more active operations, e.g. to_string wheras as_* operations signify zero-cost casting like operations. Beyond this, we should also not mark these methods pub(crate) to make them useful for public abstractions, such as #4447.

bors r+

bors r-


Richturn/edits

Added text & image asking users to file Console/UI/UX issues in Console repo.

e05a895


Failure during 'az bicep upgrade'

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az bicep upgrade
Errors:
The command failed with an unexpected error. Here is the traceback:
[Errno 13] Permission denied: '/Users/bbuchmeier/.azure/bin/bicep'
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 657, in execute
    raise ex
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 720, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 691, in _run_job
    result = cmd_copy(params)
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/command_modules/resource/custom.py", line 3287, in upgrade_bicep_cli
    ensure_bicep_installation(release_tag=latest_release_tag)
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/command_modules/resource/_bicep.py", line 93, in ensure_bicep_installation
    installed_version = _get_bicep_installed_version(installation_path)
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/command_modules/resource/_bicep.py", line 171, in _get_bicep_installed_version
    installed_version_output = _run_command(bicep_executable_path, ["--version"])
  File "/usr/local/Cellar/azure-cli/2.23.0/libexec/lib/python3.8/site-packages/azure/cli/command_modules/resource/_bicep.py", line 205, in _run_command
    process = subprocess.run([rf"{bicep_installation_path}"] + args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
  File<EMAIL_ADDRESS>line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File<EMAIL_ADDRESS>line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File<EMAIL_ADDRESS>line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: '/Users/bbuchmeier/.azure/bin/bicep'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az bicep upgrade

Expected Behavior
Environment Summary
macOS-10.15.7-x86_64-i386-64bit
Python 3.8.10
Installer: HOMEBREW

azure-cli 2.23.0

Additional Context

route to service team

bump. For more context, I have done  clean install of python, Azure CLI, as well as bicep, and this is still an issue.

Closing this issue. I had to manually delete the /.azure folder on my mac and then do a fresh install of azure-cli as well as bicep. Solved the issue. Not sure why uninstalling bicep and the cli did not remove the files in conflict in the first place.


BG test data update

This pull request should not have been merged because of the failed checkes. A ticket was already created for this:
https://github.com/eu-digital-green-certificates/dgc-testdata/issues/298

@vanlooverenkoen  These fails are intentional, unfortunately we have issued aproximately 1 000 000 DGCs using Json.Net as a serializer and there are null objects in the JSON. We are asking everybody to relax the schema validation a little bit, to accept these DGCs. But to have some test data, we had to provide the broken ones as well as the good ones


Ratings support

in addition to comments, users can leave ratings on posts with playlists (same as comment, but with a rating of 1-5 stars)
we need to:

make sure the ratings func from previous branch works
render ratings properly, and also allow users to like a rating as they would a comment
we can probably add the liking of comments in this branch too since it should be very similar
maybe also refining the tags feature? allowing them to dismiss an unneeded tag field if they don't want to add one, etc.

unlike comments, only one review should be submitted per user @RamsesPeralta7

fixed


Info message is sent to stderr instead of stdout

I found that, when profiling a script which is writing some output to stdout, cprofilev info message was written at the beginning of the output file:
# Output file is ok in this case:
fooScript.py myInput > myOutput

# If I want to profile the script execution:
cprofilev fooScript.py myInput > myOutput

# But now the first line of myOuput is:
#[cProfileV]: cProfile output available at http://<IP_ADDRESS>:4000

In order to be able to use cprofilev while keeping the output unchanged, the info message is now written to sys.stderr instead of being sent to stdout with print.

ah, appreciate the PR. Do you think you could add comments explaining the change (so people don't mistakenly revert this in the future). If not, I'll be happy to add them myself after merging this.
Thanks so much!

I added some comments in the code to explain the change.
Thank you for this nice profiling tool!

Awesome. Thanks!


can't install cuda

I want to install cuda via vcpk but I can't , I get these errors :
CMake Error at ports/cuda/portfile.cmake:26 (message):
Could not find CUDA.  Before continuing, please download and install CUDA
(V9.0.0 or higher) from:
  https://developer.nvidia.com/cuda-downloads

Also ensure vcpkg has been rebuilt with the latest version (v0.0.104 or
later)
Call Stack (most recent call first):
scripts/ports.cmake:72 (include)
Error: Building package cuda:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: cuda:x86-windows
Vcpkg version: 0.0.106-unknownhash
Additionally, attach any relevant sections from the log files above.

@developernew123
http://developer.download.nvidia.com/compute/cuda/9.1/secure/Prod/local_installers/cuda_9.1.85_win10.exe

Hi @developernew123, thanks for posting this issue. please try to install CUDA toolkit 10 in your machine first. Then install CUDA via vcpkg. I have tested on my local and it can be installed successfully.

Please reopen this issue if the problem persist for you after install CUDA toolkit 10.


Unable to start protractor with IE

I'm running e2e test using grunt-protractor-runner on Windows 7 VM
My node version is 0.10.25
My protractor version is 2.5.1
When I run I get this
Using the selenium server at http://<IP_ADDRESS>:4444/wd/hub
[launcher] Running 1 instances of WebDriver
ERROR - Unable to start a WebDriver session.

/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/error.js:113
  var template = new Error(this.message);
                 ^
UnknownError: Unable to find executable for product Opera Desktop
    at new bot.Error (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/error.js:113:18)
    at Object.bot.response.checkResponse (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/response.js:106:9)
    at /home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:152:24
    at /home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1582:15
    at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654:20)
    at notify (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)
    at notifyAll (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:442:7)
    at resolve (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:420:7)
    at fulfill (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:535:5)
    at /home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1582:15
==== async task ====
WebDriver.createSession()
    at Function.webdriver.WebDriver.acquireSession_ (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:149:22)
    at Function.webdriver.WebDriver.createSession (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:123:30)
    at Builder.build (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/builder.js:294:22)
    at DriverProvider.getNewDriver (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/lib/driverProviders/driverProvider.js:38:7)
    at Runner.createBrowser (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/lib/runner.js:180:37)
    at /home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/lib/runner.js:257:21
    at _fulfilled (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/q/q.js:797:54)
    at self.promiseDispatch.done (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/q/q.js:826:30)
    at Promise.promise.promiseDispatch (/home/luca/my-project/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/q/q.js:759:13)
[launcher] Process exited with error code 1
>>
Fatal error: protractor exited with code: 1

Hi There!
There's definitely something wrong here configuration wise, but I'm hesitant to say the issue is with protractor. My gut says it's a configuration issue, either with your project's protractor.conf or grunt-protractor.
With that in mind, your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

If the result of that discovery is an internal issue with protractor, please feel free to add an issue with an isolated reproducible case.
Thanks!


add input element for password length

Solve #9

Thanks for your contribution..
Try to fix it for mobile view


chore: disable local-mode-tests on windows

Something about the local mode tests makes it occasionally break in windows on CI. Specifically, the inspector fails to connect to the miniflare process, and ends up spamming "waiting for connection" in the logs. I'm disabling these tests since they're for sanity only right now, and we have a fuller suite of tests for windows in the main package anyway.
Fixes https://github.com/cloudflare/wrangler2/issues/776

Landing this, makes this a better than the situation we already have, we can revisit later.


Let team organizer specify role for each player selection

We have a player_selections.role field that's intended to let the organizer specify a role that player is fulfilling in the composition by playing that hero. It's an optional field. We should let the user set it and then, on the composition show page #80, we should make it visible in a subtle way, perhaps on hover as a tooltip.
We need an interface with a text field that the user can set to the role for each player+hero on each point. We need a way for the user to access this text field because there's not room on the page for it to be visible all the time, for every selection.
Like maybe I want Rob to play Mercy not as a primary healer, but as DPS because he's gonna Battle Mercy. Or maybe we need Soldier: 76 as our Healer: 76.

Neat idea! Is this for after version 1? You're doing the work, so up to you whenever you want to do it! :)


Fixes issue #163: Improve documentation for html under Formats

Fixes issue #163 by explicitly listing the supported categories and their mapped display names as well as explicitly listing the configurable option(s) in the documentation.

@aputinski Please review.


Pylint alerts corrections as part of an intervention experiment

Is your feature request related to a problem? Please describe.
Pylint alerts are correlated with tendency to bugs and harder maintenance.
Describe the solution you'd like
Fix some of the pylint alerts.
Describe alternatives you've considered

You can leave the code as is
You will probably fix some of the alerts during your ongoing development

Additional context
I'd like to conduct a software engineering experiment regarding the benefit of Pylint  alerts removal.
The experiment is described here.
In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control.
After the interventions are done, one can wait and examine the results.
I'm asking for your approval for conducting an intervention in your repository.
See examples of interventions in stanford-oval/storm, gabfl/vault, and coreruleset/coreruleset.
You can see the planed interventions
May I do the interventions?

The linked file is for a different package.  I think this is what is relevant for us: https://github.com/evidencebp/pylint-intervention/blob/main/interventions/candidates/pvlib_pvlib-python_interventions_October_06_2024.csv
Looking through the list of flags, I am inclined to decline the offer.  Many of the "issues" are intentional, and compatible with the linter configuration we use.  Others would be only debatable improvements, with the effort required to edit and review likely not worth the improvement IMHO.

The goal of the experiment is to evaluate the benefit of fixing alerts of various types. Benefit will be measured by both developer opinion and in metric improvement.

@evidencebp I am curious, what metrics do you use?  How can the benefit of fixing pylint issues be quantified?

Thank you for the feedback, @kandersolar !
Some of the alerts are known to have limited or even no effect (e.g., line-too-long).
They function as a control, to see that the influence is not a side-effect (e.g., drawing attention to the file, leading to a different significant fix).
These alerts are easy to fix and review.
Usually there are two types of relevant metrics.
The first one is code metrics that are based on the source code itself.
Examples are lines-of-code and McCabe.
These are usually direct and local.
Another type of metric are process metrics, based on the development process.
This is a view independent of the source code (making comparing more reliable) and can represent benefits.

I concur with @kandersolar - most of the pylint items are "line too long" which is intentional for readability, or in the set "too many lines/branches/statements)". Squelching the "too many" set feels like refactoring modules and functions, which would be a lot of work for (my perception) little return.

@kandersolar , @cwhanse , I respect your decision and enjoy the discussion.
I agree regarding the line-too-long.
Note that "too many lines/branches/statements)" is a very different case.
Code length (in many variations) is very influential.
It leads to code that is harder to understand, test, and modify.
Refactoring to split a long method into smaller ones is common enough to be implemented in IDEs.
Note that the goal of the experiment is to reach a point that we will have a dataset of many clean interventions that will allow us to learn how beneficial each alert type is.
From this point of view, even verifying the line-too-long is not beneficial will advance the knowledge.

Seems like we're not interested in any pursuing this for pvlib-python, but thanks @evidencebp for the offer.


DateTimeSelect can't set Hour, Minute and Second Attributes on construct

When creating a DateTimeSelect elements provided, the class construct the parent and then sets element for Hour, Minutes and Seconds, dissmissing the attributes passed to constructor.
$element = new Element\DateTimeSelect('datetime', array(
    'label' => 'Date Time',
    'day_attributes'    => array('class' => 'day-class'),
    'month_attributes'  => array('class' => 'month-class'),
    'year_attributes'   => array('class' => 'year-class'),
    'hour_attributes'   => array('class' => 'hour-class'),
    'minute_attributes' => array('class' => 'minute-class')
));

In this statement only day, month and year attributes are passed as this are procesed on the parent constructor (Element\DateSelect) after this elements are created.
The problem is that hour, minute and hour attributes are passed but the Select Elements for this "Elements" does not exists yet.
Zend\Form\Element\DateTimeSelect.php
    /**
     * Constructor. Add the hour, minute and second select elements
     *
     * @param  null|int|string  $name    Optional name for the element
     * @param  array            $options Optional options for the element
     */
    public function __construct($name = null, $options = array())
    {
        parent::__construct($name, $options);

        $this->hourElement   = new Select('hour');
        $this->minuteElement = new Select('minute');
        $this->secondElement = new Select('second');
    }

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Add typings for TS users working with GrAMPS

Possibly, if you decide you don't want to maintain that yourselves until (possibly) moving to Typescript, we could just put them on DefinitelyTyped. Also, as one of the parameters is a GrAMPS datasource, this also applies to other GrAMPS libraries.


⚠ ClamAV has degraded performance

In 8625e0d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 480 ms

Resolved: ClamAV performance has improved in 0d9e25a.


blocker.py

Thank you for contributing @ShashiNova, make sure to check your contributions on GitHub Pages.


[REQ] Allow certain groups/subscriptions to be excluded from the main/all feed

The problem I am facing
There is currently no way to prevent certain subscriptions or groups from being displayed in the main feed. For example, I am subscribed to an account that posts a LOT and it takes up most of my main feed. This could also help users that are subscribed to NSFW accounts and would not want inappropriate content being the first thing shown when opening the app
A possible solution
It would be very helpful to have an "Exclude from main feed" checkbox when making or editing a subscription group that doesn't show the specified accounts in the main feed but the tweets are still available if the user clicks on the group in the subscriptions tab
Thanks

An alternate fix could be to set your default feed to something other than all.

An alternate fix could be to set your default feed to something other than all.

How do I set that? I've tried that before and I can't find the option for it anywhere

Was offering that as an alternative change, not as a fix that already existed, sorry.

Ah, makes sense. No worries!

Sorry, I don't think this will be supported - the All feed is explicitly that: a feed containing all of your subscriptions. The supported way to achieve what you'd like to do is to create a group containing the subscriptions you'd like to see. Adding this will be essentially duplicating functionality, whereas I think maybe promoting groups to the same level as the All feed (i.e. @moocow1452's suggestion) is probably a better way forward.
I wasn't too keen on having the All feed on the home screen, for reasons like this, but it was a highly requested feature 😕


Update the tests so that the Stark validator pass the same tests as the current P256 and secp256k1 validators

This was an error


Expose host-resolver as a stand-alone daemon

BTW if we can just fix libslirp to use the sane resolver, that will be helpful for non-Lima QEMU users and we can avoid CGO.
https://gitlab.freedesktop.org/slirp/libslirp/-/blob/v4.6.1/src/slirp.c#L244
Originally posted by @AkihiroSuda in https://github.com/lima-vm/lima/issues/281#issuecomment-932806046

I think that embedding our DNS server inside libslirp won't work because libslirp is written in C, so we can't use the Go DNS library.
But I think we could expose our server as a standalone daemon that would server e.g. on <IP_ADDRESS>:53 and then we could put that address as the only address into /etc/resolv.conf on the host (the same way systemd-resolved works).
That way libslirp would automatically inherit it (I hope, on macOS it doesn't read /etc/resolv.conf, but calls libresolv, so needs more research). But also all other tools, like dig, host, or nslookup would suddenly start using the native macOS resolver.
For Lima I would still run the code inside the hostagent, so that we don't need an extra daemon, and more importantly, so that we don't need to mess with /etc/resolv.conf. But it would be nice if we could make this available system-wide with just a launch daemon for other use cases.


Synchronize the SheduleProvider#getInstance method to make it thread safe.

As par the discussion on #174, changed the getInstance method as synchronized.
(Sorry I closed the #174 accidentally and couldn't find a way to amend the PR. I'm sending another PR)

Thanks  Takeshi, great to have you on board :)

Haha, thanks for merging!


[web] TextField is blurry in web, if wrapping Container is smaller than text bounds

Steps to Reproduce

Run flutter create bug.
Update the files as follows:

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Column(
        children: [
          Center(
            child: Column(
              children: <Widget>[
                Container(
                  width: 330,
                  color: Colors.black12,
                  child: TextField(
                    controller: TextEditingController(text: 'You have pushed the button this many times:'),
                  ),
                ),
                Container(
                  width: 320,
                  color: Colors.black12,
                  child: TextField(
                    controller: TextEditingController(text: 'You have pushed the button this many times:'),
                  ),
                ),
              ],
            ),
          ),
        ],
      ),
    );
  }
}

Run this code on the Chrome platform. Try to change the width of the window to see blur increasing and decreasing.

Expected results:
I expected to see crisp text, like in the first row.
Actual results:
I see a blurry text in TextField, like in the second row.

What I see in Windows build (all is ok):

G:\AndroidStudioProjects\_Trainings\_plugins_test\bug_with_blur>flutter run -d chrome --verbose
[   +9 ms] executing: [G:\_Dev\src\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +51 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 5663e02645a6e69fedfe8553cbe7940cbb592be9
[        ] executing: [G:\_Dev\src\flutter/] git tag --contains HEAD
[ +175 ms] Exit code 0 from: git tag --contains HEAD
[   +2 ms] executing: [G:\_Dev\src\flutter/] git describe --match *.*.*-*.*.pre --first-parent --long --tags
[ +148 ms] Exit code 0 from: git describe --match *.*.*-*.*.pre --first-parent --long --tags
[        ] 1.19.0-1.0.pre-173-g5663e0264
[   +8 ms] executing: [G:\_Dev\src\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +28 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/master
[        ] executing: [G:\_Dev\src\flutter/] git ls-remote --get-url origin
[  +25 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +68 ms] executing: [G:\_Dev\src\flutter/] git rev-parse --abbrev-ref HEAD
[  +28 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] master
[  +40 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +7 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +14 ms] executing: G:\_Dev\ANDROID_SDK_HOME\SDK\platform-tools\adb.exe devices -l
[  +32 ms] List of devices attached
[   +5 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +164 ms] Generating G:\AndroidStudioProjects\_Trainings\_plugins_test\bug_with_blur\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[ +115 ms] Launching lib\main.dart on Chrome in debug mode...
[  +63 ms] Updating assets
[  +65 ms] Syncing files to device Chrome...
[  +28 ms] Generating G:\AndroidStudioProjects\_Trainings\_plugins_test\bug_with_blur\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +49 ms] <- reset
[   +6 ms] G:\_Dev\src\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev --old_gen_heap_size=2000 G:\_Dev\src\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root G:\_Dev\src\flutter\bin\cache\flutter_web_sdk/
--incremental --target=dartdevc --debugger-module-names -Ddart.developer.causal_async_stacks=true --output-dill C:\Users\Igor\AppData\Local\Temp\flutter_tools.9e0a54d5\flutter_tool.47fb3c7c\app.dill --libraries-spec
file:///G:/_Dev/src/flutter/bin/cache/flutter_web_sdk/libraries.json --packages .packages -Ddart.vm.profile=false -Ddart.vm.product=false
--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-root
C:\Users\Igor\AppData\Local\Temp\flutter_tools.9e0a54d5\flutter_tools.83c69b0e --filesystem-scheme org-dartlang-app --initialize-from-dill build\cache.dill.track.dill --platform file:///G:/_Dev/src/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill
[   +7 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[+9301 ms] Syncing files to device Chrome... (completed in 9 384ms, longer than expected)
[   +1 ms] Synced 22.2MB.
[        ] <- accept
[ +135 ms] [CHROME]:
[   +1 ms] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:6302/devtools/browser/d01b0785-0fb1-476b-a07e-e3657ad58865
[+4653 ms] Debug service listening on ws://<IP_ADDRESS>:6340/F_F1sPcrDTw=

[ +479 ms] Debug service listening on ws://<IP_ADDRESS>:6340/F_F1sPcrDTw=
[   +2 ms] Warning: Flutter's support for web development is not stable yet and hasn't
[        ] been thoroughly tested in production environments.
[        ] For more information see https://flutter.dev/web
[        ]   To hot restart changes while running, press "r" or "R".
[   +1 ms] For a more detailed help message, press "h". To quit, press "q".

G:\AndroidStudioProjects\_Trainings\_plugins_test\bug_with_blur>flutter analyze
Analyzing bug_with_blur...
No issues found! (ran in 2.5s)

flutter doctor -v
[√] Flutter (Channel master, 1.19.0-2.0.pre.173, on Microsoft Windows [Version 10.0.17763.1217], locale ru-RU)
    • Flutter version 1.19.0-2.0.pre.173 at G:\_Dev\src\flutter
    • Framework revision 5663e02645 (12 hours ago), 2020-05-27 18:32:01 -0400
    • Engine revision 2663be8370
    • Dart version 2.9.0 (build 2.9.0-11.0.dev e007545c42)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at G:\_Dev\ANDROID_SDK_HOME\SDK
    • Platform android-29, build-tools 29.0.3
    • ANDROID_SDK_ROOT = G:\_Dev\ANDROID_SDK_HOME\SDK
    • Java binary at: D:\_ProgramFiles\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    X Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio CommunityВ 2019 16.4.2)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio CommunityВ 2019 version 16.4.29613.14

[√] Android Studio (version 3.6)
    • Android Studio at D:\_ProgramFiles\Android Studio
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] VS Code (version 1.43.2)
    • VS Code at C:\Users\Igor\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.9.1

[√] Connected device (3 available)
    • Windows    • Windows    • windows-x64    • Microsoft Windows [Version 10.0.17763.1217]
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 81.0.4044.138

! Doctor found issues in 1 category.

Issue reproduces on Windows
Windows

Macos

flutter doctor -v
[✓] Flutter (Channel master, 1.19.0-2.0.pre.173, on Mac OS X 10.15.5 19F96, locale en-GB)
    • Flutter version 1.19.0-2.0.pre.173 at /Users/tahatesser/Code/flutter_master
    • Framework revision 5663e02645 (15 hours ago), 2020-05-27 18:32:01 -0400
    • Engine revision 2663be8370
    • Dart version 2.9.0 (build 2.9.0-11.0.dev e007545c42)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10 (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.5
    • macOS         • macOS                     • darwin-x64     • Mac OS X 10.15.5 19F96
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome 83.0.4103.61

• No issues found!

Removed platform-windows. This happens on windows in the browser, but not on the native windows build.

The same problem happens on 1.19.0-4.1.pre (Chrome on Linux). @yjbanov can we increase the priority as this is a huge blocker for publishing to production? Looks like the website is totally blurry.

I agree, it probably should have greater priority. This is a bug in basic web rendering. A small mistake with numbers could lead to a bad looking app.

I don't think this is caused by a mistake in container width. In my case it works exactly the opposite. One of the widget is wrapped with Expanded, and all the widgets in this Row are blurry. Things improve when the screen width is smaller that the total width of the children in this Row - everything is sharp as it should be.

I would have closed this in favor of https://github.com/flutter/flutter/issues/62291 since Column is involved here but after removing all of the layout widgets in the sample, the issue persists.
width: 320

width: 330

It's hard to think that these are completely unrelated issues, maybe this can help pinpoint the cause.
Tested on the latest master 1.22.0-10.0.pre.121.

flutter doctor -v
[√] Flutter (Channel master, 1.22.0-10.0.pre.121, on Microsoft Windows [Version 10.0.19041.450], locale en-US)
    • Flutter version 1.22.0-10.0.pre.121 at C:\Development\flutter_master
    • Framework revision 6c1a29e54c (6 hours ago), 2020-09-09 20:05:05 -0400
    • Engine revision 564367b297
    • Dart version 2.10.0 (build 2.10.0-107.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.6.30320.27
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (6 available)
    • SM G950F (mobile)           • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
    • sdk gphone x86 arm (mobile) • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows            • windows-x64    • Microsoft Windows [Version 10.0.19041.450]
    • Web Server (web)            • web-server         • web-javascript • Flutter Tools
    • Chrome (web)                • chrome             • web-javascript • Google Chrome 85.0.4183.102
    • Edge (web)                  • edge               • web-javascript • Microsoft Edge 85.0.564.44

• No issues found!

Minimal reproducible code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Container(
        width: 330,
        color: Colors.black12,
        child: TextField(
          controller: TextEditingController(text: 'You have pushed the button this many times:'),
        ),
      ),
    );
  }
}

I am also experiencing random blurry text in more complex layouts when using Container, Row, Column and Table widgets on Chrome on Linux since at least Flutter 1.19.
Text also gets blurry when hovering over a RaisedButton or an InkWell like in the code sample below

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Default label',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: Center(
      child: Container(
        width: 600,
        child: Text.rich(
          TextSpan(children: [
            TextSpan(
              text: 'First part of the loooooooooooooooooooooooooooong text',
              style: TextStyle(fontSize: 20),
            ),
            WidgetSpan(
                child: InkWell(
              child: Icon(Icons.free_breakfast),
              onTap: () {},
            )),
            TextSpan(
              text: 'Second part of the loooooooooooooooooooooooooooong text ',
              style: TextStyle(fontSize: 20),
            )
          ]),
          textAlign: TextAlign.left,
        ),
      ),
    ));
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.22.0-10.0.pre.107, on Linux, locale en_US.UTF-8)
    • Flutter version 1.22.0-10.0.pre.107 at /home/azbuky/Devel/Sdks/flutter
    • Framework revision 54ade88365 (28 hours ago), 2020-09-08 22:08:57 -0700
    • Engine revision d1d848e842
    • Dart version 2.10.0 (build 2.10.0-98.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /home/azbuky/Devel/Sdks/Android/Sdk/
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /home/azbuky/Devel/Sdks/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 3.6)
    • Android Studio at /home/azbuky/Devel/Sdks/android-studio
    • Flutter plugin version 48.0.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.48.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.14.1

[✓] Connected device (4 available)
    • Nexus 5X (mobile) • 026128a95bb02d50 • android-arm64  • Android 8.1.0 (API 27)
    • Linux (desktop)   • linux            • linux-x64      • Linux
    • Web Server (web)  • web-server       • web-javascript • Flutter Tools
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 85.0.4183.102

• No issues found!

</details

I'm also seeing this in specific situations. Hovering over a FlatButton seems to produce the worst and most consistent examples. Not seeing it in Firefox, only in Chrome. Also strangely only on an external 4k display, my laptop display is perfectly crisp (also 4k panel but scaled to display at ~2k).

I want to +1 this issue. I just closed #66600 in favor of this thread.

Can we make it P3/P4? More people are reporting the same issue, let's get that prioritized as it's really a blocker.

I have been digging in my app's generated html code in Chrome and it seems Flutter usually renders text using the <p> element but sometimes it renders the text into a <canvas> element, especially for more complex layouts.
The blurred text is always the one rendered in a canvas. I have manually added image-rendering: pixelated to the css of one of the canvases and it seems to fix the blurriness.
Is Chrome doing some kind of canvas smoothing by default that makes the text blurry?

I'm also experiencing the same issue in web.I think this issue need more priority and need to be resolved as soon as possible.

I am also experiencing issues with this, can confirm it is not just a too-small wrapping container - this occurs regardless of that.
Here is an example widget that has this issue:
Container(
  height: 40,
  child: Directionality(
    textDirection: TextDirection.rtl,
    child: ElevatedButton.icon(
      onPressed: () async {
        await shareLink(medium: ShareMedium.Email, message: message, link: link);
      },
      label: Text('Email'),
      icon: Icon(Icons.email_outlined, size: 15),
      style: Theme.of(context).elevatedButtonTheme.style
    )
  )
)

Please help!

I have this problem too.
I use Windows with scaling more than 100%
If I hover over a button, no matter what kind of, the button changes his color and the text get's unsharp!

I noticed this issue is more visible as the widgets are near the center of the screen and when layout widgets are involved, suchs as: Rows, Columns, Center.
Tried image-rendering: pixelated; but the text gets distorted.
In --web-renderer html it works most of the time but not everywhere.
I also noticed that it's more related to the size of the window.

I think the problem is related to DecoratedBox widget and Container also uses DecoratedBox inside itself.

I have created a custom painter who draws the box shadows without any problems. I don't have enough time to work around this issue. But this error is probably not about drawing shadows.

class ShadowPainter extends CustomPainter {
  const ShadowPainter({
    required this.shadows,
    this.borderRadius,
    this.textDirection = TextDirection.ltr,
  });

  final List<BoxShadow> shadows;
  final TextDirection? textDirection;
  final BorderRadiusGeometry? borderRadius;

  @override
  void paint(Canvas canvas, Size size) {
    final rect = Offset.zero & size;

    _drawShadows(canvas, rect, textDirection);
  }

  void _drawShadows(Canvas canvas, Rect rect, TextDirection? textDirection) {
    for (final BoxShadow boxShadow in shadows) {
      final Paint paint = boxShadow.toPaint();
      final Rect bounds = rect.shift(boxShadow.offset).inflate(boxShadow.spreadRadius);
      _drawBox(canvas, bounds, paint, textDirection);
    }
  }

  void _drawBox(Canvas canvas, Rect rect, Paint paint, TextDirection? textDirection) {
    if (borderRadius == null) {
      canvas.drawRect(rect, paint);
    } else {
      canvas.drawRRect(borderRadius!.resolve(textDirection).toRRect(rect), paint);
    }
  }

  @override
  bool shouldRepaint(_ShadowPainter oldDelegate) {
    return oldDelegate.shadows != shadows &&
        oldDelegate.textDirection != textDirection &&
        oldDelegate.borderRadius != borderRadius;
  }
}

Hi everyone facing the issue, I re-visited this and checked it but couldn't see the issue on the latest Flutter stable 3.19.5 (using Windows machine and testing on both HTML and Canvaskit renderers)

Demo

Web:

Cavaskit
HTML

Windows app:

flutter doctor -v (stable & master)
[√] Flutter (Channel stable, 3.19.5, on Microsoft Windows [Version 10.0.19045.4170], locale en-US)
    • Flutter version 3.19.5 on channel stable at C:\WIP\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (6 days ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio Hedgehog\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.4.4)
    • Visual Studio at D:\DOWNLOADWORK\VS2022
    • Visual Studio Community 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android StudioGiraffe
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio Hedgehog
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.87.2)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.84.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4170]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 123.0.6312.86
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 121.0.2277.83

[√] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.22.0-3.0.pre.27, on Microsoft Windows [Version 10.0.19045.4170], locale en-US)
    • Flutter version 3.22.0-3.0.pre.27 on channel master at C:\WIP\flutter_master
    ! Warning: `flutter` on your path resolves to C:\WIP\flutter\bin\flutter, which is not inside your current Flutter SDK checkout at C:\WIP\flutter_master.
      Consider adding C:\WIP\flutter_master\bin to the front of your path.
    ! Warning: `dart` on your path resolves to C:\WIP\flutter\bin\dart, which is not inside your current Flutter SDK checkout at C:\WIP\flutter_master.
      Consider adding C:\WIP\flutter_master\bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision bf7deff765 (31 minutes ago), 2024-04-03 00:42:28 -0400
    • Engine revision 0da1b2eb37
    • Dart version 3.5.0 (build 3.5.0-11.0.dev)
    • DevTools version 2.34.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio Hedgehog\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.4.4)
    • Visual Studio at D:\DOWNLOADWORK\VS2022
    • Visual Studio Community 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android StudioGiraffe
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio Hedgehog
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.87.2)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.84.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4170]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 123.0.6312.86
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 121.0.2277.83

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I will close the issue as fixed. If anyone still experiences this on the latest Flutter version, please write in comments and I will re-open this. Thanks!


Create model by picking fields from another model

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
It would be great to have the ability to define one model from another model by picking fields, but not having to duplicate the field definitions, similar to pick in typescript
This is especially useful when creating Patch request models, where you might want only a subset of the entity's fields to get passed.
There is a current workaround, but that involves poking into fields, which are internal to pydantic and hence not a great idea, it would be great to have this as inbuilt support:
from pydantic import BaseModel, create_model

class User(BaseModel):
    id: int
    name: str
    email: str
    age: int

def create_pydantic_subset(original_model: BaseModel, fields: list):
    subset_fields = {field_name: (field.type_, ...) for field_name, field in original_model.__fields__.items() if field_name in fields}
    return create_model(f'{original_model.__name__}Subset', **subset_fields)

UserPatch = create_pydantic_subset(User, ['name', 'email'])

I found a stack overflow question also requesting similar functionality
Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[X] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[X] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

While in principle we could do some mypy plugin wizardry to support this, I'll just note that it's unlikely that IDEs/other type checkers will support this any time soon (specifically, I think it's not likely to get support unless something is added to make it possible for @dataclass). And without a broader expression of interest I think improved tooling-integration support for this would fall fairly low on the priority list.
As a result, while you can get this behavior by using tricks like what @yezz123 has suggested, I would generally advise against this if you care about static type-checking.
(I'll note that __root__ models are planned to be removed in v2, so it will probably require some changes to keep @yezz123's suggestion working, though I think there should still be a way to do something equivalent with create_model).


Ruby 2.2.0, Rails 4.2.0

bundle update
fix config.serve_static_assets
fix spec_helper

Coverage decreased (-0.0%) to 81.62% when pulling e09a41149f0772729e4451fa6f05a6c149d4b19e on tany:ruby-2.2.0 into 5118d40c7969ec59a4606a00540e16526d2db6b0 on shirasagi:master.

replace be_true to be_truthy.
https://github.com/sunny4381/shirasagi/commit/16eb763a3ac7df5dd4cb692d1d9417dd999fd591


impl Debug for FontError.

This is especially useful when parsing fonts and using .unwrap() to
panic on error – which is not uncommon for tests / tooling purposes.

Thanks! Of course this should be implemented.


Use Mini-asset

I've split out the core functionality of this plugin into a standalone library - mini asset. My goal in doing this is two fold:

Insulate asset compress from changes in CakePHP.
Make asset compress like features available to non-CakePHP applications. I currently use a fork of AssetCompress at work, and I selfishly want to maintain less code.

TODO

[x] Fix path resolution for Sprockets filter by using the cake friendly scanner.
[x] Fix path resolution for ImportInline filter
[x] Restore tests for AssetScanner and theme/plugin path resolution.

merge broke my previously working local dev on windows now i get requests like this with errors:
http://localhost:81/css/G%3A/resources/pages/project%20cake3/webroot/cache_css/not_logged_in.css?theme=ThemeDefault
Error: CssController could not be found.

while i see the ToDo's list and css is in theme the js is not:
http://localhost:81/js/G%3A/resources/pages/project%20cake3/webroot/cache_js/base.js
Error: JsController could not be found.

Looks like the full path is being included on windows.

i got to point where paths are ok but now even with debug = true its still trying to compress the file instead of normal appending files and outputing them (like it worked before merge) - the fix ive found is delete the filters[] in .ini
to fix routes change $path = str_replace(WWW_ROOT, '', $path) to:
$root = str_replace('\\', '/', WWW_ROOT);
        $path = str_replace('\\', '/', $path);
        $path = str_replace($root, '', $path);

in AssetCompressorFilter.php getName and in AssetCompressHelper.php url

Ok. Thanks for the help on the windows issue. I will look into the missing debug toggle too.

@Graziel Both those issues should be fixed now. If you could open new issues for any other problems you have it would be appreciated :smile:


Is there a method additional to subscribeToContentCardsUpdates

Is there a additional method to subscribeToContentCardsUpdates from docs? https://www.braze.com/docs/developer_guide/platform_integration_guides/web/content_cards/integration/#control-group

I've create a simple example how we can implement subscription:
https://github.com/OncoHealth/braze_plugin_web/pull/6


Module has no name errors

Please help

Try pip uninstall texthero, then pip install git+https://github.com/jbesomi/texthero.git

Hi @henrifroese , done this, it seems that any of the nlp functions are not working.  have installed spacy separately.
Even simple things like this are not working, produce same errors.

All other things work great (eg tfidf, scatter plots etc as per your documentation)

Hi @cameronstewart, for some reason, your version of texthero in the jupyter notebook is < 1.0.8. Note that most of texthero.nlp functions have been introduced on Texthero 1.0.8 onwards.
If you are using conda, make sure you have installed Texthero in your current environment.
I'm closing this issue, feel free to open it again in case of need.
Best,


Broken in Chef 12.11, recommend knife data bag --local-mode now this project is dead

The following made Chef 12.10.54 (unreleased) stop working with knife-solo_data_bag.
https://github.com/chef/chef/compare/v12.10.53...v12.10.54
Since Chef local-mode has supported local editing of data bags since I think 11.8, I don't think this gem is needed anymore.
Local mode can be induced alternatively via adding to knife.rb:
local_mode true

The issue with that is that local_mode reads from your knife.rb and uses the chef-repo.  'knife solo data bag' is still helpful If you keep data bags in test/integration for kitchen and want the ability to modify encrypted data bags.

Can you confirm you are still having issues with the latest version of this gem (>=2.0)?
Please use local_mode true in your config when testing, thanks.


July 30 meeting decisions

This PR adds docs for the two decisions the Web Foundation team discussed on July 30:

We name our route-level components ResourceList and ResourceDetails, instead of ResourceIndex and ResourceShow as we currently do in Web.
We split test files by feature when component test files get too long.

@TheMallen @tzvipm @asmockler @cartogram I made some updates, particularly around naming convention: I liked Andy's suggestion of Component-feature. Thoughts?

❤ This looks very good and intuitive imo especially when it comes to splitting test files.

Alright, thanks for all the feedback folks!


Is there any equivalent param as POLLER_INTERVAL_MILLISECONDS?

Describe the solution you'd like
In KES, we have the following params to reduce AWS Secrets Manager cost.
      - name: env.POLLER_INTERVAL_MILLISECONDS # This parameter defines the frequency of API calls to AWS Secrets Manager. Modify this if necessary.
        value: "120000" # By default this was 10000 but it was too expensive
      - name: env.WATCH_TIMEOUT # This parameter defines timeout value to restart control loop not to hang up in Node.js environment ref. https://github.com/external-secrets/kubernetes-external-secrets/issues/362
        value: "150000"

What is available parameter that works similarly for this operator?
What is the added value?
Explain the value that it adds. e.g. "Secret refreshing will make internal secrets up to date with external secrets".
Give us examples of the outcome
Provide templates if you are proposing changes in the CRD. Provide example workflows or code snippets if they make sense to present.
Observations (Constraints, Context, etc):
Give here all extra information that could be interesting. Such as Golang version and Kubernetes version if you are reporting a bug/problem. You can also foresee technical constrains like "this could only be implementing using this specific technology or approach, because of this and that".

Let me leave this open since I am not familiar with KES and maybe this is about something else :sweat_smile:

Yes you're right. That was a global interval used for all ExternalSecrets. This was now moved to the ExternalSecret spec as refreshInterval and can be configured on a per-es basis.
I'm closing this again. Feel free to reopen if you have any further questions or comments.


pull request for e2e test at 11/12/2016 07:56:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: viewmodel disappearing

yeah so just spawn the viewmodel again lol
legality of this is questionable (?)

Fixes #210 (symptomatic fix, still not clear why it happens)

It's limited to P2 SP now, I guess. I don't know of any case it happens in mods or in coop anyway.


Add popover margin

Tooltip has margin ($tooltip-margin variable), which allows us to add spacing between element and tooltip.
But popover doesn't have this option despite both components use popper.js. Looks a bit inconsistent.
Is there a valid reason for this?

In both cases (Tooltip and Popover) you have the offset parameter which allow you to add some spaces see :
https://getbootstrap.com/docs/4.0/components/tooltips/#options
https://getbootstrap.com/docs/4.0/components/popovers/#options

In this case why do we need margin option for tooltips?

it's a customisation for folks who prefer to do it in CSS

Would be nice to add $popover-margin variable for those folks then :) Looks inconsistent - both components have offset option, but only one of them allows you to change it in CSS

No plans to change this right now.


Support brokerName in request protocol

FEATURE REQUEST

Support brokerName in request protocol.
brokerName is a higher-level abstraction than brokerAddress and should be taken in request.
Related components should know request-target by brokerName such as logic queue extension, envoy-like cloud-native gateway, or even more separate computing and storage to decouple computing from current broker logic.
Detail request code: PULL_MESSAGE, UPDATE_CONSUMER_OFFSET, QUERY_CONSUMER_OFFSET, SEARCH_OFFSET_BY_TIMESTAMP, GET_MIN_OFFSET, GET_MAX_OFFSET.

BrokerAddress can be used as a router, I do not get why do you need brokerName.

@drpmma In favor of this recommendation, the entire Remoting layer is currently IP oriented. Using broker names instead of IP can better hide the underlying state of the broker, especially the abstraction of logical resources brought by logical queues and other features.

+1 for the change. IP-centered strategy suffers a lot in the era of cloud and container orchestration. We need logical representation to adapt to this trend.

Not only brokerName, the queueId also need abstraction, unbind with specific physical node

Now that bname is supported in RpcRequestHeader, related RPC can use this field to implement.


"Unexpected token :" when saving keymap.json

Prerequisites

[x] Can you reproduce the problem in safe mode?

Yes

[x] Are you running the latest version of Atom?

Yes

[ ] Did you check the debugging guide?

No

[ ] Did you check the FAQs on Discuss?

No

[x] Are you reporting to the correct repository?

Yes, I hope so

[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Yes
Description
Getting error message when trying to save keymap:
Failed to load /Users/tyurins/.atom/keymap.json
Unexpected token :
Steps to Reproduce

Open Settings -> Keybindings
Copy a keybinding (first one in my case)
Open keymap.json (from settings page or from Atom menu)
Paste and Save

Expected behavior: [What you expected to happen]
No error
Actual behavior: [What actually happened]
Error
Versions
$ atom --version
Atom    : 1.11.1
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

This is because copying a keybinding from Settings -> Keybindings copies CSON, rather than JSON, which you tried pasting into keymap.json – if you rename that to keymap.cson it should work.
But, settings-view should probably be smart enough to detect which format keymap.cson is in and copy the right format for keybindings. We should also probably make this error more descriptive.


[IIIF-248] works in concert with PR#6 on docker-manifest-store

on commits to the master branch, new docker-manifest-store builds are triggered for the latest tag
on tags to this repo, new docker-manifest-store builds are triggered with a tag that matches the tag on this repo

closing because the existence of this PR seems to be blocking Travis-CI from running the deploy stage, I'll re-open after that testing is complete


MINOR: [Docs] Update alignment to center in specification for ADBC

Rationale for this change
Update alignment to center in specification for ADBC

What changes are included in this PR?
Update alignment to some content.

Are these changes tested?
Yes. I have verified the changes by building the documentation.

Are there any user-facing changes?
Yes. the updated documentation will be visible to users.

Before:

After:

@lidavidm Hello. I found a misalignment (maybe?). Could you please check it when you have some free time?


columns selected here miss the column HADM_ID ?

https://github.com/bvanaken/clinical-outcome-prediction/blob/b376f4bcd72d6d8da40078b416fb8e926ca22ba9/tasks/adm_dis_match_mimic/adm_dis_match_mimic.py#L108

And how to pretrain the wiki before the diag task?

Hi,
since these notes are only used for the pre-training task, we don't necessarily need the HADM_ID column here. Or did you find that there is an issue with the column missing?
For pre-training on WIKI data, you can first create the data via adm_dis_match_wiki.py and then use the resulting data set for outcome pre-training via outcome_pretraining.py.
Hope this is helpful!
Best regards
Betty


How to use usernameless and passwordless at the same time

As described in the Yubico developer Guide we can use User Handle to allow usernameless and passwordless authentication.
How to do it with this library and initiate attestation and assertion phases without a username because all documentation describes an associated user passed in parameter.
Thanks for your help.

I think I have my answer :)
If we don't give a username during assertion phase the client will ask the user which one he wants to use but to validate it correctly after, we have to store User Handle and use it like describe in the documentation.
This validation should be added inside assertion verification phase because for now only the string type is checked for this attribute.
And to store User Handle we have to ask the user to use the key ones before logout like a validation process because User Handle is not returned during attestation verification phase

https://developers.yubico.com/WebAuthn/WebAuthn_Developer_Guide/Resident_Keys.html

If we want to authenticate a user with his username we have to set residentKey to required as describe in the specification
Else, we have to ask him his username, retrieve authenticators associated to it, asking for user verification and then validating User Handle to be sure all is good

passwordless.dev is @aseigler's project and my goto for playing around with Passwordless and Usernameless. I took a look at attestation options and distilled the differences down to this:
Passwordless
{
  "user": {
    "name": "namehere",
    "id": "bmFtZWhlcmU",
    "displayName": null
  },
  "authenticatorSelection": {
    "requireResidentKey": false,
    "userVerification": "preferred"
  }
}

Usernameless
{
  "user": {
    "name": " (Usernameless user created at 2/1/2021 5:53:46 PM)",
    "id": "IChVc2VybmFtZWxlc3MgdXNlciBjcmVhdGVkIGF0IDIvMS8yMDIxIDU6NTM6NDYgUE0p",
    "displayName": null
  },
  "authenticatorSelection": {
    "requireResidentKey": true,
    "userVerification": "preferred"
  }
}

(I've omitted common stuff like RP info, challenge, etc...)
So yes, as you called out from the Yubico guide one difference is requireResidentKey: true (or the new residentKey: "required" in L2 of the WebAuthn spec).
I started a "Cookbooks" section for the SimpleWebAuthn docs to document this exact thing: a collection of options devs can specify to support either of these flows. I'll experiment with this in the next few days and restart that effort to document these collections of settings.

@MasterKale thanks for your answer.
For both, we have to store User Handle like this we can validate the user when is authenticated with username or not by finding the user in the database with the User Handle value.
That's why I'm asking you to add this field inside AuthenticatorDevice and validate it during verification phase.

Okay, after a few hours diving back into the spec I understand better now that for the sake of privacy userHandle (as user.id in attestation options) should always be a random 64-byte Buffer and never the user's actual internal DB ID.
This means that generateAttestationOptions() should be updated to generate that random userHandle every time and return it in attestation options. It'd then be the responsibility of the RP to take that userHandle, persist it until verification, then store it in the credentials table along with an fkey to the user's actual internal DB ID.
There's now additional load, outside of library functionality, to communicate all of this to people implementing this library who wish to take advantage of passwordless or usernameless flows...

That's why I'm asking you to add this field inside AuthenticatorDevice and validate it during verification phase.

I understand your request better now, too, and this makes perfect sense. I'm going to model upcoming changes around this diagram on this specific page in Yubico's dev guide:

Thanks @MasterKale and yes if we match the specific credentials data from Yubico I guess we are on the good way

UserHandle will allow us to find user in the database and the corresponding authenticator like this we can be sure that it was registered for this RP that's why we have to find AuthenticatorDevice inside the DB with UserHandle and validate all the fields save during attestation generation with the data received during attestation verification.

This issue is going to end up becoming a documentation issue, since PR #97 is adding additional return values from attestation that will be helpful in supporting passwordless and usernameless flows. Once that PR gets merged in work can begin on adding entries to the SimpleWebAuthn docs site containing "best practices" for setting up the RP to support these non-2FA WebAuthn flows.

I'm going to close this issue out for https://github.com/MasterKale/SimpleWebAuthn-homepage/issues/2.


[WFCORE-74] : Use 'filesystem-path' arbitrary descriptor for attributes/params that represent a path.

Adding support for arbitrary descriptors metadata.
Adding FILESYSTEM_PATH and WEB_URL arbitrary descriptors.
Adding support in CLI for FILESYSTEM_PATH during completion.
Adding CLI operation parameter validation before sending operation.
Jira: https://issues.jboss.org/browse/WFCORE-74

Core - Full Integration Build 1498 is now running using a merge of 29252100e0e6c4d4c497eee7fdf61207f339056e

Linux Build 2365 is now running using a merge of 29252100e0e6c4d4c497eee7fdf61207f339056e

Windows Build 1878 is now running using a merge of 29252100e0e6c4d4c497eee7fdf61207f339056e

Windows Build 1878 outcome was SUCCESS using a merge of 29252100e0e6c4d4c497eee7fdf61207f339056e
Summary: Tests passed: 3427, ignored: 64 Build time: 0:35:28

Linux Build 2365 outcome was SUCCESS using a merge of 29252100e0e6c4d4c497eee7fdf61207f339056e
Summary: Tests passed: 3427, ignored: 64 Build time: 0:36:55

Core - Full Integration Build 1498 outcome was SUCCESS using a merge of 29252100e0e6c4d4c497eee7fdf61207f339056e
Summary: Tests passed: 3082, ignored: 368 Build time: 0:50:10

Core - Full Integration Build 1503 is now running using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106

Windows Build 1883 is now running using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106

Linux Build 2370 is now running using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106

Windows Build 1883 outcome was SUCCESS using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106
Summary: Tests passed: 3427, ignored: 64 Build time: 0:35:05

Linux Build 2370 outcome was SUCCESS using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106
Summary: Tests passed: 3427, ignored: 64 Build time: 0:36:21

Core - Full Integration Build 1503 outcome was SUCCESS using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106
Summary: Tests passed: 3082, ignored: 368 Build time: 0:47:55

Please remove the validation from this PR. It is not required.

WildFly pull requests Build 5 is now running using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106

WildFly pull requests Build 1822 outcome was FAILURE using a merge of 74c559c2bd7d46f1483e13d6ff5ef0beeaef8106
Summary: Snapshot dependencies failed: 3 (new) Build time: 00:00:02

Linux Build 2397 is now running using a merge of 8b8d5f5aa2ca70afde9d2b7d447b55f7841e9463

Linux Build 2397 outcome was SUCCESS using a merge of 8b8d5f5aa2ca70afde9d2b7d447b55f7841e9463
Summary: Tests passed: 3403, ignored: 64 Build time: 00:37:32

WildFly pull requests Build 1826 outcome was SUCCESS using a merge of 8b8d5f5aa2ca70afde9d2b7d447b55f7841e9463
Summary: Running Build time: 00:00:02

My apologies; I thought I'd posted this last week but it seems I didn't.
Please remove the validation stuff. It's not really part of WFCORE-74, it's too late in the cycle to deal with this kind of behavior change, and the general type checking is something I very much oppose.

Linux Build 2406 is now running using a merge of c09c937060c6d02aa452320b289b6dfad5feae2f

Linux Build 2406 outcome was SUCCESS using a merge of c09c937060c6d02aa452320b289b6dfad5feae2f
Summary: Tests passed: 3401, ignored: 64 Build time: 00:37:41

WildFly pull requests Build 1834 outcome was SUCCESS using a merge of c09c937060c6d02aa452320b289b6dfad5feae2f
Summary: Running Build time: 00:00:02

Linux Build 2413 is now running using a merge of 2dc022f8cd20b501a952453b062942f49d3e03e9

Linux Build 2413 outcome was SUCCESS using a merge of 2dc022f8cd20b501a952453b062942f49d3e03e9
Summary: Tests passed: 3402, ignored: 64 Build time: 00:37:03

WildFly pull requests Build 1840 outcome was SUCCESS using a merge of 2dc022f8cd20b501a952453b062942f49d3e03e9
Summary: Running Build time: 00:00:02

Linux Build 2422 is now running using a merge of fe1a113b4911d7ea928b866fb057fba569ff1edd

Linux Build 2422 outcome was SUCCESS using a merge of fe1a113b4911d7ea928b866fb057fba569ff1edd
Summary: Tests passed: 3402, ignored: 64 Build time: 00:35:53

WildFly pull requests Build 1849 outcome was FAILURE using a merge of fe1a113b4911d7ea928b866fb057fba569ff1edd
Summary: Snapshot dependency failed: ... WildFly Core Full - Integration (new) Build time: 00:00:21

Linux Build 2444 is now running using a merge of df5c2ce180c45595de746dd4f9e8505a666ae814

Linux Build 2444 outcome was SUCCESS using a merge of df5c2ce180c45595de746dd4f9e8505a666ae814
Summary: Tests passed: 3403, ignored: 64 Build time: 00:35:53

WildFly pull requests Build 1869 outcome was SUCCESS using a merge of df5c2ce180c45595de746dd4f9e8505a666ae814
Summary: Running Build time: 00:00:07

Core - Full Integration - Windows Build 16 is now running using a merge of e594336c25290fca12eff08be562b5c1e7b26e17

Linux Build 2468 is now running using a merge of e594336c25290fca12eff08be562b5c1e7b26e17

Linux Build 2468 outcome was SUCCESS using a merge of e594336c25290fca12eff08be562b5c1e7b26e17
Summary: Tests passed: 3402, ignored: 64 Build time: 00:37:37

Core - Full Integration - Windows Build 16 outcome was FAILURE using a merge of e594336c25290fca12eff08be562b5c1e7b26e17
Summary: Tests failed: 1 (1 new), passed: 3054, ignored: 358 Build time: 00:52:21
Failed tests
org.jboss.as.test.integration.management.api.ModelPersistenceTestCase.testSimpleOperation: java.lang.AssertionError: null
	at org.jboss.as.test.integration.management.api.ModelPersistenceTestCase.testSimpleOperation(ModelPersistenceTestCase.java:119)
------- Stdout: -------
18:00:18,378 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) org.jboss.as.controller.persistence.ConfigurationPersistenceException: WFLYCTL0081: Failed to back up C:\BuildAgent\work\db872761b443af46\full\testsuite\integration\basic\target\jbossas\standalone\configuration\standalone.xml: org.jboss.as.controller.persistence.ConfigurationPersistenceException: WFLYCTL0081: Failed to back up C:\BuildAgent\work\db872761b443af46\full\testsuite\integration\basic\target\jbossas\standalone\configuration\standalone.xml
	at org.jboss.as.controller.persistence.ConfigurationFile.fileWritten(ConfigurationFile.java:552)
	at org.jboss.as.controller.persistence.ConfigurationFilePersistenceResource.doCommit(ConfigurationFilePersistenceResource.java:65)
	at org.jboss.as.controller.persistence.AbstractFilePersistenceResource.commit(AbstractFilePersistenceResource.java:58)
	at org.jboss.as.controller.ModelControllerImpl$4.commit(ModelControllerImpl.java:783)
	at org.jboss.as.controller.AbstractOperationContext.executeDoneStage(AbstractOperationContext.java:707)
	at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:658)
	at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:362)
	at org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1294)
	at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:395)
	at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:225)
	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:207)
	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.access$300(ModelControllerClientOperationHandler.java:129)
	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:151)
	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:147)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:422)
	at org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:92)
	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:147)
	at org.jboss.as.protocol.mgmt.AbstractMessageHandler$2$1.doExecute(AbstractMessageHandler.java:298)
	at org.jboss.as.protocol.mgmt.AbstractMessageHandler$AsyncTaskRunner.run(AbstractMessageHandler.java:518)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
	at org.jboss.threads.JBossThread.run(JBossThread.java:320)
Caused by: java.nio.file.FileSystemException: C:\BuildAgent\work\db872761b443af46\full\testsuite\integration\basic\target\jbossas\standalone\configuration\standalone_xml_history\standalone.last.xml: The process cannot access the file because it is being used by another process.

	at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
	at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
	at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
	at sun.nio.fs.WindowsFileCopy.copy(WindowsFileCopy.java:165)
	at sun.nio.fs.WindowsFileSystemProvider.copy(WindowsFileSystemProvider.java:278)
	at java.nio.file.Files.copy(Files.java:1274)
	at org.jboss.as.controller.persistence.FilePersistenceUtils.copyFile(FilePersistenceUtils.java:73)
	at org.jboss.as.controller.persistence.ConfigurationFile.fileWritten(ConfigurationFile.java:550)
	... 23 more

WildFly pull requests Build 1890 outcome was FAILURE using a merge of e594336c25290fca12eff08be562b5c1e7b26e17
Summary: Snapshot dependency failed: ... WildFly Core Full - Integration - Windows (new) Build time: 00:00:07

The CLI part looks good. Thanks!

retest this please

Linux Build 2479 is now running using a merge of e594336c25290fca12eff08be562b5c1e7b26e17

Windows Build 1991 is now running using a merge of e594336c25290fca12eff08be562b5c1e7b26e17

Core - Full Integration - Windows Build 28 is now running using a merge of e594336c25290fca12eff08be562b5c1e7b26e17

Windows Build 1991 outcome was SUCCESS using a merge of e594336c25290fca12eff08be562b5c1e7b26e17
Summary: Tests passed: 3403, ignored: 64 Build time: 00:38:40

Linux Build 2479 outcome was SUCCESS using a merge of e594336c25290fca12eff08be562b5c1e7b26e17
Summary: Tests passed: 3403, ignored: 64 Build time: 00:40:11

Core - Full Integration - Windows Build 28 outcome was SUCCESS using a merge of e594336c25290fca12eff08be562b5c1e7b26e17
Summary: Tests passed: 3055, ignored: 358 Build time: 00:55:00

WildFly pull requests Build 1898 outcome was SUCCESS using a merge of e594336c25290fca12eff08be562b5c1e7b26e17
Summary: Running Build time: 00:00:02


Update images to ubuntu 17

http://releases.ubuntu.com/zesty/ :)

I knew this was coming 😄 We only support OSes that are part of the support matrix in the template, because these are ones that we test on. Once Ubuntu 17 is supported, we can look at adding it but I'd be keen to close this issue now and reopen it when that happens.

Closing this as this won't supported in the template unless/until it's supported in the support matrix. Feel free to reopen if/when this happens 👍


chore: bump all charm libs

bump all charm libs to most recent versions

Closed PR by mistake

I think this was previously failing because the kfp-api obs tests require juju agent-version==2.9.34.  I have pinned that now to resolve the issue


stdenv: add option to change make command

Motivation for this change
Otherwise, when a package requires e.g. bmake, all the helpful stuff
stdenv implements around make has to be copied (as required by the
package).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@OfBorg eval

Hmm, so we'd have to modify buildPhase to not add that flag if a custom make is in use, and then we'd probably also want to do something about it checking for GNUmakefile instead of BSDmakefile.
I think this is probably not a good idea after all.  It would be better to write a setup-hook for bmake that replaces the default buildPhase with a bmake-specific one.


Move delegation certificate declaration in a separate table

Issue Number

#913
Overview

[x] I have moved tracking of delegation "certificate" into a separate SQLite table
[x] I have adjusted readWalletMetadata to now pull the delegation status from the right table
[x] I have added a putDelegationCertificate function to insert a new row in the database when new certificates are discovered
[x] I have extended the state-machine tests accordingly, with proper tagging

Comments

Cardano.Wallet.DB.Sqlite
  Sqlite State machine tests
    Sequential
      +++ OK, passed 400 tests:
      65.8% UnsuccessfulReadTxHistory
      57.8% SuccessfulReadCheckpoint
      57.2% CreateThenList
      55.0% TxUnsortedInputs
      54.8% TxUnsortedOutputs
      49.0% CreateWalletTwice
      32.5% ReadTxHistoryAfterDelete
      28.5% PutCheckpointTwice
      27.8% UnsuccessfulReadCheckpoint
      24.8% ReadMetaAfterPutCert
      22.5% CreateThreeWallets
      18.5% RemovePendingTxTwice
      17.5% RolledBackOnce
      14.2% SuccessfulReadPrivateKey
      13.2% SuccessfulReadTxHistory
      12.0% RemoveWalletTwice
    Parallel
      # PENDING: No reason given
  Sqlite State machine (RndState)
    Sequential state machine tests
      +++ OK, passed 400 tests:
      65.8% UnsuccessfulReadTxHistory
      57.8% SuccessfulReadCheckpoint
      57.2% CreateThenList
      55.0% TxUnsortedInputs
      54.8% TxUnsortedOutputs
      49.0% CreateWalletTwice
      32.5% ReadTxHistoryAfterDelete
      28.5% PutCheckpointTwice
      27.8% UnsuccessfulReadCheckpoint
      24.8% ReadMetaAfterPutCert
      22.5% CreateThreeWallets
      18.5% RemovePendingTxTwice
      17.5% RolledBackOnce
      14.2% SuccessfulReadPrivateKey
      13.2% SuccessfulReadTxHistory
      12.0% RemoveWalletTwice

bors r+


Update dependencies

Updates:

serde
elastic_types
elastic_responses

This introduces a few breaking changes that I think need to simmer for a bit before merging.

Need to update a few more dependencies (for elastic_derive)

I think given elastic_respones::HttpResponse is a mostly useless type and will probably be removed, we'll introduce our own HttpResponse wrapper that wraps reqwest::Response and only use elastic_responses::HttpResponse for parsing an IsOk.

Just a few docs out of date now and this should be good to go.


can i consider the delegate methods as optional?

The delegate methods are optional?

it depends on how you use and integrate the player. you don't have to use delegation, if you don't want to but various state changes won't propagate.

I changed the code a bit to make them optional like below. Can do a pull request if you want?
@objc public protocol PlayerDelegate: class {
    optional func playerReady(player: VideoPlayerViewController) -> ()
    optional func playerPlaybackStateDidChange(player: VideoPlayerViewController) -> ()
    optional func playerBufferingStateDidChange(player: VideoPlayerViewController) -> ()

    optional func playerPlaybackWillStartFromBeginning(player: VideoPlayerViewController) -> ()
    optional func playerPlaybackDidEnd(player: VideoPlayerViewController) -> ()
}

If you change the code to above, you will see about 14 errors in the class where the delegate methods, when called, need to have a '?' to define them as optional.


Multiple trigger not working for checkboxes

Sample json working on survey builder broken in latest build
{
pages: [
{
name: "page1",
questions: [
{
type: "checkbox",
choices: [
"one",
{
value: "two",
text: "second value"
},
{
value: "three",
text: "third value"
}
],
name: "question1"
},
{
type: "text",
name: "question2",
visible: false
},
{
type: "text",
name: "question3",
visible: false
},
{
type: "text",
name: "question4",
visible: false
}
]
}
],
triggers: [
{
type: "visible",
operator: "contains",
value: "one",
name: "question1",
questions: [
"question2"
]
},
{
type: "visible",
operator: "contains",
value: "two",
name: "question1",
questions: [
"question3"
]
}
]
}

Screenshot from survey builder site release version v0.9.9

Screenshot from latest build

Yes, indeed. The survey checkbox value was stored in the survey data as a link on itself. As result they are modifying at the same time and the new check doesn't work.
I have written the unit test and fix it.
Thank you very much!
Andrew-