use tree-sitter-verilog

Hi,
I have developed SystemVerilog 2017 parser: https://github.com/tree-sitter/tree-sitter-verilog
Based on GitHub's Tree-Sitter parser generator infrastructure: http://tree-sitter.github.io/tree-sitter
I also have SystemVerilog language plugin here: https://github.com/drom/language-verilog
I would love to merge these features into your plugin.

What would the effective change be for these features you're talking about?

I did not quite get your question. Are you asking:

How tree-sitter based syntax highlighter different from the regexp based plugin you have now?
What code need to be added to the plugin to enable tree-sitter?

Tree-sitter is the full parser, so it sees the correct structure of the source file instead of RegExp guess about the structure.

I can prepare PR if you are interested.

Sounds great; please do!

Failed to load a language-systemverilog package grammar

Cannot find module './build/Release/tree_sitter_verilog_binding' in /Users/peter/.atom/packages/language-systemverilog/grammars/tree-sitter-systemverilog.cson

I'm not sure what to make of that. I made your changes, updated the dependencies, and now I'm seeing that error

Failed to load a language-systemverilog package grammar

Cannot find module './build/Release/tree_sitter_verilog_binding' in /Users/my_username/.atom/packages/language-systemverilog/grammars/tree-sitter-systemverilog.cson

I'm not sure what to make of that. I made your changes, updated the dependencies, and now I'm seeing that error

Have you run apm rebuild ?

Yep, that's post-rebuild. Pre-rebuild I was getting a dependency problem from tree-sitter-verilog

Yep, I have not tested it under Windows :(

Me either; I'm on MacOS

do you have g++ installed somewhere?

Yep

could you try installing tree-sitter-verilog by itself?
Like npm i tree-sitter-verilog

The module '/[...]/language-systemverilog/node_modules/tree-sitter-verilog/build/Release/tree_sitter_verilog_binding.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 72. This version of Node.js requires
NODE_MODULE_VERSION 64. Please try re-compiling or re-installing
the module (for instance, using npm rebuild or npm install). in /Users/my_username/.atom/packages/language-systemverilog/grammars/tree-sitter-systemverilog.cson

node --version ?

v12.6.0

atom --version ?

Atom    : 1.39.1
Electron: 3.1.10
Chrome  : 66.0.3359.181
Node    : 10.2.0

you need node v10.
nvm i 10

😂😂

I thought "Ah nice everything's working now" but then the window didn't respond and eventually showed that ^

apm rebuild

Same problem I'm afraid

nvm i 10 gave me v10.16.0. I then tried nvm i 10.2.0 to match Atom's npm version exactly and got the following:

npm i tree-sitter-verilog

<EMAIL_ADDRESS>install /[...]/language-systemverilog/node_modules/tree-sitter-verilog
node bin/install.js

build
In file included from ../src/binding.cc:2:
/Users/peter/.node-gyp/10.2.0/include/node/node.h:53:10: fatal error: 'core.h' file not found
#include "core.h"  // NOLINT(build/include_order)
^~~~~~~~
1 error generated.
make: *** [Release/obj.target/tree_sitter_verilog_binding/src/binding.o] Error 1
gyp
ERR! build error
gyp
ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/[...]/.nvm/versions/node/v10.2.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp
ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR!
stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
gyp ERR!
System Darwin 18.7.0
gyp ERR! command "/[...]/.nvm/versions/node/v10.2.0/bin/node" "/[...]/.nvm/versions/node/v10.2.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "build"
gyp ERR! cwd /[...]/language-systemverilog/node_modules/tree-sitter-verilog
gyp ERR!
node -v v10.2.0
gyp ERR! node-gyp -v v3.6.2
gyp
ERR! not ok
done

<EMAIL_ADDRESS>updated 1 package in 15.903s

You need newer Node 10. nvm i 10

nvm i 10.16.0 ?

Yep that's what I did the first time; that's when Atom crashed

How did you installed my branch of the plugin?
apm -d link ?

do you run atom -d ?

apm link. Didn't use the -d flag though

Try dev mode: apm -d link then atom -d

-d isn't accepted as a valid flag on MacOS's apm. atom -d does work, however

apm link -d

apm link -d then atom -d: it's crashing even sooner now; before it would open the GUI and it looked like I could just start typing. Now it opens a blank window and hangs for a while before showing that "crashed" dialog

apm rebuild ?

Same problem I'm afraid

ll ~/.atom/dev/packages/

lrwxr-xr-x 1 my_username staff 48 Jul 27 13:08 language-systemverilog -> /Users/my_username/scratch/language-systemverilog/

cd ~/.atom/dev/packages/language-systemverilog/
rm -rf node_modules/ package-locks.json
apm rebuild
atom -d

Failed to load a language-systemverilog package grammar

Cannot find module 'tree-sitter-verilog' in /Users/peter/.atom/dev/packages/language-systemverilog/grammars/tree-sitter-systemverilog.cson

Failed to load a language-systemverilog package grammar
Cannot find module 'tree-sitter-verilog' in /Users/my_username/.atom/dev/packages/language-systemverilog/grammars/tree-sitter-systemverilog.cson

cd ~/.atom/dev/packages/language-systemverilog/
git clone
rm -rf node_modules/ package-lock.json
nvm i 10
npm i
apm rebuild
atom -d

It runs through everything without problems but then when the GUI opens it hangs with a blank screen for a while before showing the "crashed" dialog

https://flight-manual.atom.io/hacking-atom/sections/debugging/

I like the idea of having an exact grammar parser rather than some regex matching but for now I'm going to leave it alone in favor of some higher-priority items on my TODO list.

Sure. Will try later.

@pistoletpierre I have installed it on MacOS ; Atom v1.40.1 without a problem. Could you give it a try again?

Same problem I'm afraid. apm link -d && apm install && atom -d: I get the output pasted below. If I try the nvm+npm stuff it crashes the editor and shows a dialog like the screencap I put in this response: https://github.com/pistoletpierre/language-systemverilog/issues/4#issuecomment-515698005.
Atom: 1.40.1 x64
Electron: 3.1.10
OS: Mac OS X 10.14.6
Thrown From: language-systemverilog package 0.12.2
Stack Trace
Failed to load a language-systemverilog package grammar
At Cannot find module './build/Release/tree_sitter_verilog_binding' in ~/.atom/dev/packages/language-systemverilog/grammars/tree-sitter-systemverilog.cson

Error: Cannot find module './build/Release/tree_sitter_verilog_binding'
    at Module._resolveFilename (internal/modules/cjs/loader.js:602:15)
    at Module._resolveFilename (/Applications/Atom.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._resolveFilename (/app.asar/src/module-cache.js:336:28)
    at Function.Module._load (internal/modules/cjs/loader.js:528:25)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (/app.asar/src/native-compile-cache.js:68:27)
    at Object.<anonymous> (~/Dropbox/Code/language_systemverilog_treesitter/language-systemverilog/node_modules/tree-sitter-verilog/index.js:2:20)
    at Object.<anonymous> (~/Dropbox/Code/language_systemverilog_treesitter/language-systemverilog/node_modules/tree-sitter-verilog/index.js:15:3)
    at Module._compile (/app.asar/src/native-compile-cache.js:121:30)
    at /app.asar/src/compile-cache.js:255:23)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
    at Function.Module._load (internal/modules/cjs/loader.js:551:3)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (/app.asar/src/native-compile-cache.js:68:27)
    at /app.asar/src/tree-sitter-grammar.js:61:27)
    at GrammarRegistry.createGrammar (/app.asar/src/grammar-registry.js:604:14)
    at CSON.readFile (/app.asar/src/grammar-registry.js:583:29)
    at /app.asar/node_modules/season/lib/cson.js:219:59
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:440:3)
  at /packages/language-systemverilog/grammars/tree-sitter-systemverilog.cson:1:1


Labels management

The goal of this task is to manage (synchronize) labels of tasks in different Github repositories with one command - using a python script. At the moment developers need to do it "by hand" in each repository, which creates differences between labels and takes a lot of time. The script should solve that issue.
Task preparation:

[x] read about github - what it is and how it is used.
[x] understand what github label is: create 2 or 3 different repositories (on your account), add few test issues and label them
[ ] read about python programming language - how is it different from C++? Answer this question in your own words in the comments of this task
[x] create a txt file called numbers.txt containing random numbers (one number per line). Try to push the file to this repository (read about pushing and pulling to github first).
[ ] write a short python script reading numbers from numbers.txt and multiplying each number by the previous number. (the first one should be multiplied by 0, since there is no previous number)
[ ] save the script under test.py file and push it to this repository

python is simpler and easier to learn, since it doesn't have as much syntax rules as c++ - it results in fewer lines of code. although it compiles code slower because it uses an interpreter, while c++ is already precompiled.


Workspace Segmentation: segmentation fault

-go on segmentation workspace (without selecting a tool box).
-add two different data.
-remove the first one you add.
-chose a toolbox (paint segmentation for example)
-add another data.
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7e1b5e3 in itk::VTKImageExportBase::UpdateInformationCallbackFunction (userData=0x2e204b0)
at /home/pedron/medinria-superproject/ITK/Modules/Bridge/VTK/src/itkVTKImageExportBase.cxx:192
192	  ( userData )->UpdateInformationCallback();
(gdb) where
#0  0x00007ffff7e1b5e3 in itk::VTKImageExportBase::UpdateInformationCallbackFunction (userData=0x2e204b0)
at /home/pedron/medinria-superproject/ITK/Modules/Bridge/VTK/src/itkVTKImageExportBase.cxx:192
#1  0x00007fffe03e5742 in vtkImageImport::InvokeUpdateInformationCallbacks (
this=this@entry=0x2e22230)
at /home/pedron/medinria-superproject/VTK/Imaging/vtkImageImport.cxx:336
#2  0x00007fffe03e7e14 in vtkImageImportExecutive::ProcessRequest (
this=0x2d0cdf0, request=0x2f64e90, inInfoVec=0x0, outInfoVec=0x2f643b0)
at /home/pedron/medinria-superproject/VTK/Imaging/vtkImageImportExecutive.cxx:38
#3  0x00007fffe29ad279 in vtkImageData::UpdateInformation (this=0x2f64860)
at /home/pedron/medinria-superproject/VTK/Filtering/vtkImageData.cxx:1192
#4  0x00007fffe3c29f3d in vtkImageView2D::GetMTime (this=0x19f4050)
at /home/pedron/medinria-superproject/medInria/src/medVtkInria/vtkImageView/vtkImageView2D.cxx:370
#5  0x00007fffe3c2e739 in vtkImageView::Render (this=0x19f4050)
at /home/pedron/medinria-superproject/medInria/src/medVtkInria/vtkImageView/vtkImageView.cxx:311
#6  0x00007fffdb5cb789 in medVtkViewItkDataImageInteractor::qt_static_metacall
(_o=0x3036da0, _c=3763572886, _id=0, _a=0x0)
at /home/pedron/medinria-superproject/build/medInria/build/src-plugins/itkDataImage/moc_medVtkViewItkDataImageInteractor.cpp:70

I do not have this crash @paulineMig. Did you use meshes or specific datasets?

No I don't think they have anaything special and it is doing it for many different dataset
Did you choose the toolbox before adding the second dataset the second time?

Nope, i did as you said in this issue. I tested with a dataset+mesh, and with 2 datasets

I do it with a ct scan i add a mask (lungs mask for example) close the ct scan choose the toolbox and open a new mask (heart mask). And it crash every time (i have 6 differents data set and their mask and all crash)

Indeed it doesn't crash every time for one patient if a use the mask of the body instead of the mask of the lungs it doesn't crash it is really weird

I have got this issue also when inside Vizualization Workspace
-open  2 datas in the same view
-remove the first one
-add another one
-> MUSIC crash
It crash on Medhi's computer too

Crashes on my macOS Sierra too. lldb shows:
frame #0: 0x000000010a0e5ab8 libITKVTK-4.9.1.dylib`itk::VTKImageExportBase::UpdateInformationCallbackFunction(userData=0x0000000104702e20) + 8 at itkVTKImageExportBase.cxx:191 [opt]

188 	//----------------------------------------------------------------------------
189 	void VTKImageExportBase::UpdateInformationCallbackFunction(void *userData)
190 	{
-> 191 	  static_cast< VTKImageExportBase * >
192 	  ( userData )->UpdateInformationCallback();
193 	}
194
I have attached two images (masks) that you can use to reproduce the bug.
masksTest.zip
I follow the same steps as Pauline.

It indeed crashes with your datasets :o

In fact its happens also in visualization workspace and not only in segmentation workspace

So, i looked at your datasets and this problem. Few notes:

This happens only with your datasets.
The debug tool shows a link with vtkSetVector3Macro(DataSpacing,double) in vtkImageImport.
Your datasets seems to have a good spacing (0.738281 0.738281 1.5)
I've tested to change a lot in medAbstractWorkspace, medAbstractLayeredView, etc. The crash remains.
... I put your datasets in Reformat->Reslice->Save:  no more crashes for a moment using these saved data in Visualization, and then an other crash but not linked to DataSpacing.

I'm wondering, does this crash happen now that you use medUtilities::setDerivedMetaData(output, input, newSeriesDescription); in your filters?

An other information, the last crash i have seem to be linked to the time of the datasets. In the header of your files, AcquisitionDate is there twice, and Size / SeriesNumber / SOPInstanceUID / FilePaths / ContainsBasicInfo are missing. I suggest that you test with medUtilities::setDerivedMetaData again :)

With new data created for sure with medUtilities::setDerivedMetaData it still crash

Zut XD.
Ok, i'll search again, but right now, i do not really see what could go wrong with these datasets, and not the others

I have created new datasets just now it crash. I have attached the new data.
test_music.zip

There is no data information in your vtk files @paulineMig
Here are 2 vtk with no crashes:
vtkOK.tar.gz

The same data as before but with data information (still chrashing).
The bug never happened to me with meshes (or i do not remember it )
test_music_1.zip

I added a PR about this crash, if you can tell me :) https://github.com/Inria-Asclepios/medInria-public/pull/270

I open again this issue since the PR creates other bugs.

This bug remains with @paulineMig data from 5 jul 2017, the crash is:
0	vtkImageImport::GetDataSpacing	vtkImageImport.h	99	0x7fffe7b219be
1	vtkImageImport::GetDataSpacing	vtkImageImport.h	99	0x7fffe7b219be
2	vtkImageImport::InvokeExecuteInformationCallbacks	vtkImageImport.cxx	351	0x7fffe7b1f157
3	vtkImageImport::RequestInformation	vtkImageImport.cxx	221	0x7fffe7b211be
4	vtkExecutive::CallAlgorithm	vtkExecutive.cxx	747	0x7fffe6ec4c20
5	vtkStreamingDemandDrivenPipeline::ExecuteInformation	vtkStreamingDemandDrivenPipeline.cxx	375	0x7fffe7015b59
6	vtkDemandDrivenPipeline::ProcessRequest	vtkDemandDrivenPipeline.cxx	242	0x7fffe6eba832
7	vtkStreamingDemandDrivenPipeline::ProcessRequest	vtkStreamingDemandDrivenPipeline.cxx	300	0x7fffe7012325
8	vtkExecutive::ForwardUpstream	vtkExecutive.cxx	644	0x7fffe6ec3615
9	vtkDemandDrivenPipeline::ProcessRequest	vtkDemandDrivenPipeline.cxx	223	0x7fffe6eba7ed
10	vtkStreamingDemandDrivenPipeline::ProcessRequest	vtkStreamingDemandDrivenPipeline.cxx	300	0x7fffe7012325
11	vtkImageData::UpdateInformation	vtkImageData.cxx	1192	0x7fffe6f0e9f9
12	vtkImageActor::GetDisplayBounds	vtkImageActor.cxx	255	0x7fffe8083656
13	vtkImageActor::GetBounds	vtkImageActor.cxx	326	0x7fffe8083918
14	vtkFrustumCoverageCuller::Cull	vtkFrustumCoverageCuller.cxx	94	0x7fffe806f114
15	vtkRenderer::AllocateTime	vtkRenderer.cxx	557	0x7fffe81311e9
16	vtkRenderer::Render	vtkRenderer.cxx	332	0x7fffe81314a4
17	vtkRendererCollection::Render	vtkRendererCollection.cxx	51	0x7fffe812d3e5
18	vtkRenderWindow::DoStereoRender	vtkRenderWindow.cxx	723	0x7fffe8136fdd
19	vtkRenderWindow::DoFDRender	vtkRenderWindow.cxx	692	0x7fffe8136c99
...	<plus>

No more crash since 3.1.1 on https://github.com/medInria/medInria-public, closing this old issue


MAINT: Introduced a couple of fixes for the np.core.fromnumeric functions

Follow-up on https://github.com/numpy/numpy-stubs/pull/71#issuecomment-619435429.
https://github.com/numpy/numpy-stubs/pull/67 Fixes & Updates

Integers and booleans can often be used interchangeably (in fact, bool is an int subclass in builtin python). Created_ArrayLikeIntOrBool to reflect this compatibility.
Rename _ScalarGeneric to _ScalarGenericDT; add a new _ScalarGeneric TypeVar which is only bound to np.generic.
np.choose() can only accept array-like objects consisting of integers (or booleans); reflect this in its annotation.
np.argpartition() will return an np.integer if a scalar is passed; not an np.ndarray.

Further Notes

It seems np.partition() might actually bugged in NumPy 1.17.3.
it's default value for axis is set to -1 instead of None. Consequently, it will raise an AxisError if a scalar is passed unless one explicitly passes axis=None to the function.

>>> import numpy as np

>>> np.partition(0, 0, axis=None)
array([0])

>>> np.partition(0, 0)
Traceback (most recent call last):
  ...
AxisError: axis -1 is out of bounds for array of dimension 0

Thanks @BvB93!


Yolov5 Transpose stops graph loading

We created an edgetpu graph through the Openvino process and the graph  seemed to be converted successfully. We checked it in Netron and it seemed normal. But when we try to load the graph using the edgetpu library we get the error:
RuntimeError: Internal: :213 batches * single_output_size != output->bytes (2028 != 105456)Node number 10 (EdgeTpuDelegateForCustomOp) failed to prepare.
We suspect the issue has  to do with the Transpose operation not being supported for edgetpu but since it should be run on the CPU we're not sure what's stopping it from loading.
Any advice? Thanks in advance.
Netron image:

@BernardinD
I tired to change few options in Tflite_convert and tested model on edgetpu_compiler. But I haven't seen any success.
But I have found an interesting thing when referring to yolov5 model from here  . The same model works fine on edgetpu. when I looked deeper, the only difference between your model and his is (ResizeNearestNeighbor align_corners =false, half_pixel_centers = true) operation. your model has same op with different config.
Probably onnx -> tf has messed it up. Can you refer to following repos and see if onnx -> keras will fix the problem ?
https://github.com/zldrobit/yolov5
https://github.com/ultralytics/yolov5

The issue had to do with the unexpected 5 dimensional Transpose at the end of the graph. For some reason the edgetpu library was still compiling it even though it wasn't mapped to the TPU. Reshaping the data down to 4D fixed the issue.


[cluster-test] Limit gzip run time to 45sec

If file is very large gzip can take insane amount of time, at this point we might as well just delete log and continue
Also fix test to not emit error when file does not exist.

@bors-libra r+

:pushpin: Commit 94b580b has been approved by ankushagarwal

:hourglass: Testing commit 94b580bf68bda3672bdfe513cf5e8245da9e59af with merge 968ecaee049dd9f6d13b0fb45ec62379b42e1426...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing 968ecaee049dd9f6d13b0fb45ec62379b42e1426 to master...


  Both amazing tools.  However, FusionAuth has a field for User and a separate field for Username.  User is a GUID, Username is something the user can set.  If they don't set a Username, it's null, and thus is not sent when headers are generated.  This poses a problem because the way REVERSE_PROXY_AUTHENTICATION_USER works in GItea, if the header that is specified is empty, it pops up the Sign In screen, even though there may be an email present in another header.  I really don't want my users to get a GUID for their username by default... only for the slackers who don't bother setting their Username in FusionAuth.
So.... drum roll please.  It would be really cool if you could specify fallbacks as comma-separate values, as so:
REVERSE_PROXY_AUTHENTICATION_USER = X-Auth-Request-Preferred-Username,X-Auth-Request-User

In my case, the Username header is sometimes present and is definitely preferable.  User is always present, but gross.
Fwiw, I attempted to use the Email header as User, and I got errors because there's an @ sign in it, and that's not legal.  Honestly, I would also be pretty happy if it would take email in as a username, or even took the first part up to the @ sign.  That'd be even better.  All my users are in the same domain, and there's disambiguation code in Gitea already for colliding usernames, so....
By the way, thanks so much for Gitea.  I use it, love it, and tell everyone about it.
JH
Screenshots
No response

Which version is your Gitea instance? I think REVERSE_PROXY_AUTHENTICATION_EMAIL has been supported.

I'm on latest.  Yes, I can pass the email in, but as I mentioned, if I try to use X-Auth-Email as the username, it fails due to the @ in it.


how to support the digest authentication

dear all .
the okhttp how to support digest authentication?

There is a 3rd party library available: https://github.com/rburgst/okhttp-digest
However, +1 for official support in OkHTTP

Duplicate of https://github.com/square/okhttp/issues/205


[$500] Distance Split - Distance is not interactable on split distance confirmation page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.18-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Go to workspace chat > + > Request money.
Go to Distance.
Enter addresses and proceed to confirmation page.
Click Distance.
Note that Distance is interactable on distance confirmation page.
Repeat Step 1 - 6 with Split bill in the context menu (to create split distance request).

Expected Result:
Distance is interactable on split distance confirmation page.
Actual Result:
Distance is not interactable on split distance confirmation page. It is grayed out.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/3072418a-af07-47b9-b3f6-2410d53d48e5

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0101cbee32541ad090
Upwork Job ID:<PHONE_NUMBER>812893696
Last Price Increase: 2023-12-28

Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance is not interactable on split distance confirmation page
What is the root cause of that problem?
It is because we are disabling it when it is not request iou type in confirmation page
What changes do you think we should make in order to solve the problem?

We should remove that condition
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance is not interactable on split distance confirmation page. It is grayed out.
What is the root cause of that problem?
In split bill, isTypeRequest will be false and isTypeSplit will be true
https://github.com/Expensify/App/blob/573f6b7005d67e5f8ec83e2efa64fb8d3b9902d2/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L679-L680
It makes the distance field disable and isn't interactable
What changes do you think we should make in order to solve the problem?
https://github.com/Expensify/App/blob/573f6b7005d67e5f8ec83e2efa64fb8d3b9902d2/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L679
https://github.com/Expensify/App/blob/573f6b7005d67e5f8ec83e2efa64fb8d3b9902d2/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L671
We should update condition to
shouldShowRightIcon={!isReadOnly && (isTypeRequest || isTypeSplit)}

disabled={didConfirm || (!isTypeRequest && !isTypeSplit)}

What alternative solutions did you explore? (Optional)
NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we try to create a distance request from the composer add action menu, the distance menu on the confirmation page is disabled.
What is the root cause of that problem?
The distance menu on the confirmation page is disabled because we only enable it if it's a request type.
https://github.com/Expensify/App/blob/573f6b7005d67e5f8ec83e2efa64fb8d3b9902d2/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L679
Currently, we only allow a distance request for request type only, not a split bill.
https://github.com/Expensify/App/blob/88d837c2e88c8c4c22a4c80f93b622d634e67290/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js#L272
So, it makes sense that the button is disabled. The bug here is that the Distance tab shouldn't show when we do a split bill.
What changes do you think we should make in order to solve the problem?

Hide the Distance tab when it's a split bill or show it only for request type.
https://github.com/Expensify/App/blob/88d837c2e88c8c4c22a4c80f93b622d634e67290/src/pages/iou/request/IOURequestStartPage.js#L100
const shouldDisplayDistanceRequest = iouType !== 'split' && (isExpenseChat || isExpenseReport || isFromGlobalCreate);
or
const shouldDisplayDistanceRequest = iouType === 'request' && (isExpenseChat || isExpenseReport || isFromGlobalCreate);

Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance is not interactable on split distance confirmation page. It is grayed out.
What is the root cause of that problem?
the menu distance is grey out because the condition only checking disabled={didConfirm || !isTypeRequest}
https://github.com/Expensify/App/blob/88d837c2e88c8c4c22a4c80f93b622d634e67290/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L679
What changes do you think we should make in order to solve the problem?

we need to add the condition if the isTypeSplit too. it's mean if distance coming from split bill
disabled={didConfirm || (!isTypeRequest && !isTypeSplit)}
What alternative solutions did you explore? (Optional)

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01aa92cd4c91423d94

Hi @izarutskaya - can you please check your video? I don't think you've uploaded it properly, thanks!

Let Dylan know here: https://expensify.slack.com/archives/C05DWUDHVK7/p1703805792841859

@jliexpensify What is the ideal behaviour here?
Should we allow user to split distance request at all?
In FAB, we have not allowed to do the same. In my opinion, we should go with @bernhardoj's proposal, and disable the split distance request.

@shubham1206agra I've checked the #wave5 slack channel and it looks like Distance requests can be split cc @neil-marcellini @dylanexpensify if you have any further input?

@FitseTLT Please follow contributing guideline, You need to post a new comment to the issue when you edit your proposal.
https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#propose-a-solution-for-the-job

@shubham1206agra I've checked the #wave5 slack channel and it looks like Distance requests can be split cc @neil-marcellini @dylanexpensify if you have any further input?

I was just saying this as there is currently no support for distance split request in API (I think as it strips all distance info while creating the split request, and only amount is kept).
cc @tgolen as you are working on request refactoring PR.

@shubham1206agra  I think that distance split request API will be implemented in this issue  https://github.com/Expensify/App/issues/33698

Thanks @DylanDylann , can you let us know when that other issue is sorted?

@shubham1206agra I've checked the #wave5 slack channel and it looks like Distance requests can be split cc

@shubham1206agra @jliexpensify If that, I think we should enable distance split requests in the scope of this issue. In FE we need to add requestType to the payload of API and require API changes to return correct data

@shubham1206agra I think that distance split request API will be implemented in this issue #33698

Nope this is not true. @jliexpensify Can you please post about this in internal channel so we can know whether to disable distance split or not?
if not, then can we have complete API calls for split request and start split request to correct for distance request?

Asked here, will keep you updated! https://expensify.slack.com/archives/C05DWUDHVK7/p1704250033812399?thread_ts=1703805792.841859&cid=C05DWUDHVK7

@DylanDylann @neil-marcellini - did you have any thoughts on this question? I didn't get an answer in my thread, cheers!
I think this is blocking the proposal review atm.

@jliexpensify It seems you tagged @dylanexpensify 😄

Ha whoops sorry!

@shubham1206agra - @dylanexpensify has confirmed that we should be able to split Distance requests.

then can we have complete API calls for split request and start split request to correct for distance request?

Could you clarify what you're asking in this second part? (I'm not an Engineer)

Can I get StartSplitBill, and SplitBill API param related to split distance bill? I suspect that it is missing in BE too. Maybe take this internal to get some eyes on this by internal team.
cc @dylanexpensify @neil-marcellini

@jliexpensify Bump on the above question

@shubham1206agra sorry for the delay, was OOO.

then can we have complete API calls for split request and start split request to correct for distance request?

By "we", do you mean a Contributor or C+?

Can I get StartSplitBill, and SplitBill API param related to split distance bill?

Just to confirm, this is an access issue?

I suspect that it is missing in BE too.

Sorry, what is BE?
Apologies if these are dumb questions, I'm not an Engineer and want to make sure I'm communicating your requests correctly.

then can we have complete API calls for split request and start split request to correct for distance request?

By "we", do you mean a Contributor or C+?

In general, as we may want to know the API parameter.

Can I get StartSplitBill, and SplitBill API param related to split distance bill?

Just to confirm, this is an access issue? i.e. these are internal things you need access to? If so, should this be Internal instead?

We can make internal to get the parameters

I suspect that it is missing in BE too.

Sorry, what is BE?

I mean backend.
Adding 🎀👀🎀 for an engineer to help here.

The answers have been shared internally, just awaiting a response .ghanks for your patience @shubham1206agra!

I believe @neil-marcellini is back from ooo today and he has more context on this than anyone else so in sake of saving time I will just leave this over to him as he is already assigned

Had a chat with Neil, we're going to close this one! We'd like to wait until P2P distance requests (including split) are implemented, thanks.

@jliexpensify Can you close https://github.com/Expensify/App/issues/33673 https://github.com/Expensify/App/issues/33698 too as they have the same problem?

Posted and tagged you in both issues


--verbose always reports "0 files processed 0 files fixed"

--verbose always seems to report "0 files processed" and "0 files fixed" for 4.0.0, and incorrectly reports "0 files processed" for 3.1.7 when using --lint.
3.1.7
> echo '*{color:red}' > original.css
> cp -f original.css style.css
> csscomb --verbose --lint style.css # note the "0 files processed"

0 files processed
0 files fixed
spent: 17.514ms
> csscomb --verbose --fix style.css # this works correctly
✓ style.css

1 file processed
1 file fixed
spent: 23.687ms

4.0.0-alpha
> echo '*{color:red}' > original.css
> cp original.css style.css
> csscomb --verbose --lint style.css # incorrect
 0 files processed 0 files fixed
Time spent: 20.803ms
> csscomb --verbose --fix style.css # also incorrect
 0 files processed 0 files fixed
Time spent: 29.496ms
> diff style.css original.css # note the file was fixed despite what csscomb says
1,3c1
< * {
<   color: red;
< }
---
> *{color:red}

Pointing this out because I thought there was something wrong with my *.css globbing and spent time trying to fix that before figuring out that "0 processed files" was just being reported incorrectly by both versions of csscomb.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36490849-verbose-always-reports-0-files-processed-0-files-fixed?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github).

Should be fixed in dev


WIP: issue #945 postgresql stored procedures support

Very interesting updates, great work.  Some confusions around some parts.  Left comments, and happy to discuss.

This PR is still in progress, far from finish yet. I created the PR just want to check how it works withe the pipeline. :)

This PR is still in progress, far from finish yet. I created the PR just want to check how it works withe the pipeline. :)

Apologies Albert, I saw it in my inbox and jumped on it.  I didn't want to wait too long.  (I just noticed after your comment the WIP) :)


Add Nicolas Lehmann, github: nilehmann, role: Chile setter, auth: cruz

Nicolás will be setter for la-tcap.

invited to la-tcap


updating from 11.1.0 -> 11.1.1 results to "Could not connect to Central search. Analysis failed."

I'm using the gradle plugin.
With 11.1.0 the plugin performs without errors but with 11.1.1 I get this error:
Could not connect to Central search. Analysis failed.
java.io.IOException: Finally failed connecting to Central search. Giving up after 7 tries.
	at org.owasp.dependencycheck.analyzer.CentralAnalyzer.fetchMavenArtifacts(CentralAnalyzer.java:362)
	at org.owasp.dependencycheck.analyzer.CentralAnalyzer.analyzeDependency(CentralAnalyzer.java:228)
	at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
	at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
	at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.net.UnknownHostException: search.maven.org: Temporary failure in name resolution
	at java.base/java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
	at java.base/java.net.InetAddress$PlatformNameService.lookupAllHostAddr(InetAddress.java:934)
	at java.base/java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1543)
	at java.base/java.net.InetAddress$NameServiceAddresses.get(InetAddress.java:852)
	at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1533)

	at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1306)
	at org.apache.hc.client5.http.SystemDefaultDnsResolver.resolve(SystemDefaultDnsResolver.java:48)
	at org.apache.hc.client5.http.impl.io.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:169)
	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:490)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:164)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:174)
	at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:144)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:192)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:150)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.HttpRequestRetryExec.execute(HttpRequestRetryExec.java:113)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:110)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:174)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:245)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:188)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:162)
	at org.owasp.dependencycheck.utils.Downloader.fetchAndHandle(Downloader.java:601)
	at org.owasp.dependencycheck.data.central.CentralSearch.searchSha1(CentralSearch.java:179)
	at org.owasp.dependencycheck.analyzer.CentralAnalyzer.fetchMavenArtifacts(CentralAnalyzer.java:3[39]
	... 8 more

I can revert back to 11.1.0 and the errors disappear.
I can also add the centralEnabled to false but the summary in the final report is empty. Though the scan information seems to be correct.
I'm behind a proxy BUT before there hasn't been a need to define proxy-information (nvd data comes from internal address etc.). I guess this is the problem now?
What has possibly changed between the 11.1.0 -> 11.1.1 versions that cause this?

Hi
i don't know if it might be related, but for the 11.1.0 i have the following error:

Central search is currently down: https://status.maven.org/
Previously, the gradle plugin did not rely on Central by default. FP/FN were identified because of differences between Maven and Gradle so we decided to re-enable the central search capability by default in the gradle plugin. If using the latest you can disable the central analyzer.

Thanks, I tried with the centralEnabled=false and it seem to populate the summary correctly after all.
I couldn't find a mention of this change in the changelog and the documentation isn't up to date.

@dkrowl - the gradle plugin is not maintained in this repo. You can see the change documented in the release notes here: https://github.com/dependency-check/dependency-check-gradle/releases/tag/v11.1.1

@Zuplyx good idea, that approach could likely be used for a few other external connections. Possibly even looking at status codes instead of just the number of failed attempts. We accept PRs if you've got time.

hi @jeremylong we are encountering the issue too. what is the impact if we centralEnabled=false?

You could end up with false negatives (i.e. unreported issues). See https://github.com/dependency-check/dependency-check-gradle/issues/421

duplicate of #7232


CGO nested structure has too much alignment padding

What version of Go are you using (go version)?

$ go version
go version go1.11.2 windows/amd64
AND
go version go1.11.2 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GOARCH=amd64
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
AND
set GOARCH="amd64"
set GOHOSTARCH="amd64"
set GOHOSTOS="darwin"
set GOOS="darwin"

What did you do?
The attached file is a minimal reproducible test case for a complicated set of nested includes in our codebase.  A "packed" structure that ends 'unaligned' is nested into an "unpacked" structure with a subsequent element requiring 8 byte alignment.
What did you expect to see?
I expected that only four bytes of padding would be inserted and be visible via fmt.Printf("%+v") resulting in a data structure that matched our external C code.
What did you see instead?
An extra "invisible" 8 bytes of padding are inserted breaking interoperability
main.txt

Program output
`Unaligned struct requiring padding
sizes: inner = 0x10 outer = 0x20
offsets: elem2 0x8  elem3 0x18
outer dump    {inner:{elem1: elem2:4294967295} _:[0 0 0 0] elem3:18446744073709551615}
outer hex dump:
00000000  00 00 00 00 00 00 00 00  ff ff ff ff 00 00 00 00  |................|
00000010  00 00 00 00 00 00 00 00  ff ff ff ff ff ff ff ff  |................|
Aligned struct requiring padding
sizes: inner = 0x10 outer = 0x18
offsets: elem2 0x8  elem3 0x10
outer dump    {inner:{elem1: elem2:4294967295} elem3:18446744073709551615}
outer hex dump:
00000000  00 00 00 00 00 00 00 00  ff ff ff ff 00 00 00 00  |................|
00000010  ff ff ff ff ff ff ff ff                           |........|
`

There is no way to represent a packed struct in Go, so the bug is that cgo is generating an incorrect struct rather than an error.
Slightly smaller test case.  The two lines should have the same numbers.  On amd64 this program currently prints
Go 24 16
C 16 16

package main

import (
	"fmt"
	"unsafe"
)

/*
#include <stdio.h>
#include <stdlib.h>
#include <stdint.h>

#pragma pack(push, _header, 1)

// Should have size of 8 + 4 = 0xc
typedef struct {
	void * elem1;
	uint32_t elem2;
} InnerNotAligned;

// Should have size of 8 + 8 = 0x10
typedef struct {
	void * elem1;
	uint64_t elem2;
} InnerAligned;

#pragma pack(pop, _header)

// Should have size of 0xc + 4 (pad) + 8 = 0x18
typedef struct {
	InnerNotAligned inner;
	// requires ONLY 4 pad bytes to align the next element
	uint64_t elem3;
} OuterNotAligned;

// Should have size of 0x10 + 8 = 0x18
typedef struct {
	InnerAligned inner;
	// requires no padding
	uint64_t elem3;
} OuterAligned;

void printSizes() {
	printf("C %zu %zu\n", offsetof(OuterNotAligned, elem3), offsetof(OuterAligned, elem3));
}
*/
import "C"

func main() {
	var notAligned C.OuterNotAligned
	var aligned C.OuterAligned
	fmt.Printf("Go %d %d\n", unsafe.Offsetof(notAligned.elem3), unsafe.Offsetof(aligned.elem3))
	C.printSizes()
}

I can't follow the gopherbot included link, but this is the issue referred to: https://go-review.googlesource.com/c/go/+/150602

Can this be considered for backport to 1.11 ?

@gopherbot Please open an issue to  backport to 1.11.


OCM-6822 | fix: add validations for external auth

https://issues.redhat.com/browse/OCM-6822

lgtm


Add RestructureMuxes transform for better code generation

This transforms nested mux expressions that have a common input. For example:
r <= mux(a, mux(b, s, r), r)

becomes
r <= mux(and(a, b), s, r)

This is especially important for register updates where the default is always the register itself. This reduces the line count of the RocketCore.fir in regress by 4.5%

Glancing at the Verilog, I need to check that this doesn't hurt synthesis results

That’s what I was about to say. I think this is a nice improvement if it doesn’t hurt QoR. (I’m optimistic it won’t.)

It looks like this does not hurt synthesis results. Users should keep an eye though when bumping.

This can cause stack overflows in certain Vec dynamic access situations, we should hold off on merging until this is fixed (and synthesis results are checked again regarding this)


any plans to update this to latest Qwik?

useStyles for example, it now requires a ?inline in the import

https://github.com/qwikverse/vscode-qwik-snippets/pull/4


Text only renders with font file that was loaded first

I have multiple .ttf fonts in different file paths, and in my application, if I try to create two text images with different font files, only the first one is properly rendered with the font.
For instance, running the code:
vips.Image.text("TEST1", {font = "Stone Serif 10", fontfile = "stone-serif.ttf", dpi = 300}):write_to_file("test1.png")
vips.Image.text("TEST2", {font = "MatrixBoldSmallCaps 10", fontfile = "matrix.ttf", dpi = 300}):write_to_file("test2.png")

produces:

If I swap the lines, I get a different result:

What could be the reason behind this?
vips version: 8.12.1

Hi @piface314,
There have been a few fixes to font handling since 8.12 (three years ago). I would update your libvips.
I tried with current stable:
#!/usr/bin/luajit

vips = require "vips"

local image = vips.Image.text("TEST1", {
    font = "MissFajardose 10",
    fontfile = "/home/john/pics/MissFajardose-Regular.ttf",
    dpi = 600
})
image:write_to_file("test1.png")

image = vips.Image.text("TEST2", {
    font = "PT Serif, Bold 10",
    fontfile = "/home/john/pics/PT_Serif-Web-Bold.ttf",
    dpi = 600
})
image:write_to_file("test2.png")

To make:

I get the same result if I swap the two text render operations.

Oh, I see. I was using this version because it seems to be the newest version available on apt. In this case, should I build from source?

Yes, or update your OS, of course. There are various libvips PPAs as well.


Unable to use macros successfully

Hi again, and sorry for making this my personal forum but I don't know a better place to go than this.
I have tried copying the perl macro from the website:
> object hash perl
  my ($rs, $args) = @_;
  my $method = shift @{$args};
  my $string = join " ", @{$args};

  # Here, $method is a hashing method (MD5 or SHA1), and $string
  # is the text to hash.

  if ($method eq "MD5") {
    require Digest::MD5;
    return Digest::MD5::md5_hex($string);
  }
  elsif ($method eq "SHA1") {
    require Digest::SHA1;
    return Digest::SHA1::sha1_hex($string);
  }
< object

// You call an object using the <call> tag.
+ what is the md5 hash of *
- The hash of "<star>" is: <call>hash MD5 <star></call>

+ what is the sha1 hash of *
- The hash of "<star>" is: <call>hash SHA1 <star></call>

but it doesn't work. I have also tried javascript macros which have worked on the online compiler but they don't work here. I even used these imports:
import com.rivescript.;
import com.rivescript.lang.;
import com.rivescript.macro.*;
Am I missing something?

@ArjunVermaGitHub No worries :-) What do you mean with it doesn't work?
Do you get an exception?
And did you configure the lang specific object handler like:
rs = new RiveScript();
rs.setHandler("javascript", new JavaScriptHandler());

We have various integration tests using macros. See e.g. https://github.com/aichaos/rivescript-java/blob/master/rivescript-core/src/integration-test/java/com/rivescript/JavaScriptObjectIT.java

Thank you so much. When I said it doesn't work, I meant it didnt give me the output I required. For example, in your reverse hello world program, instead of elloh dlrow, I got err:object not found. The program ran fine, just the output is unexpected.
No, I did not configure it like you said to, but something weird is happening now that I did. When I try to use the setHandler function outside my onCreate() function for my app, the program cant find the function in the packages, but it does get recognized when I use the function inside it. Still, the application throws an error when I launch the activity.
Caused by: java.lang.ClassNotFoundException: Didn't find class "javax.script.ScriptEngineManager" on path: DexPathList[[zip file "/data/app/com.example.myapplication-2/base.apk", zip file "/data/app/com.example.myapplication-2/split_lib_dependencies_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_0_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_1_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_2_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_3_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_4_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_5_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_6_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_7_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_8_apk.apk", zip file "/data/app/com.example.myapplication-2/split_lib_slice_9_apk.apk"],nativeLibraryDirectories=[/data/app/com.example.myapplication-2/lib/arm, /system/lib, /vendor/lib]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)

is what seems relevant to me, please tell me if I should paste more of the stackTrace

Based on the exception (Didn't find class "javax.script.ScriptEngineManager") I think you are missing the javax.script dependency. Probably it's not part of the Dalvik JVM but I'm not sure as I have no experience with Dalvik...
Maybe this helps: https://stackoverflow.com/questions/25371949/is-it-possible-to-use-javascript-code-in-android

It can't be fixed with an import statement. I cant seem to install a dependency either. Would it be faster to switch over to perl or some other type of macro? Or is it possible to use java functions in some way to get the same work done?

@ArjunVermaGitHub yes you could also use Java subroutines as , see https://github.com/aichaos/rivescript-java/blob/master/rivescript-core/src/integration-test/java/com/rivescript/JavaObjectIT.java for an example in an integration test.
But I wonder why you say it can't be fixed? It's not only about adding an import statement. You need to addition libraries (jars) to your project that contain the script engine implementation.

OK I installed the jar file, and now the import happens properly, but I got a new kind of exception:
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Enumeration java.lang.ClassLoader.getResources(java.lang.String)' on a null object reference
This is originating from the same line:
bot.setHandler("javascript", new JavaScriptHandler());
Why is it a null object reference when I have already used the constructor?

I have no idea. Probably you have to look at the full stack trace to see from where it originates...

Well, I managed to do pretty well using Java macros. I've had a lot of fun with this and sincerely thank you for the help. I do feel there may have been something weird happening with the javascript for android business, but even if thats true, the workaround is really good.
I have been developing a bot for the past few days and can envision the enormous applications this platform has to offer.

Thx for the feedback @ArjunVermaGitHub.
I'm closing this issue for now. If you anything else feel free to raise another issue or re-open this one.


Remove english localization (USEID-426)

We should set German as the dev localization then as well, right? This can only be done by editing the .xcodeproj-file itself.

What would be the benefit? Since we will bring English back very soon and would require "non-supported" editing of the project file, I would leave it.

Our development localization de facto is German, as this is the first language we use when creating localizations. There is no real benefit besides stating this fact, so feel free to ignore it.


[DDW-957] Fix random Buildkite failures and improve CI

This PR:

Adds retry capability to Buildkite agent calls to ensure artifacts upload is not affected by intermittent network issues
Merges test and linter GH Actions pipelines into a single pipeline
Removes Hydra linter and TSC checks (which are anyway covered by GitHub actions)
Adds a postinstall hook that runs yarn lockfile:fix - only in local environment
Introduces cache for node_modules in GitHub actions which should reduce the GH actions execution time by ~1.5 min

Screenshots
Lockfile fixed automatically:

Lockfile fix skipped in CI:

Build fails when lockfile:fix is not run:

Build fails when manage:translations is not run:

TODO

[ ] Daniel to remove ci/hydra-build:tests.runTsc GitHub check

@DominikGuzei @szymonmaslowski @renanvalentin please re-review :)


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

:tada: This PR is included in version 6.26.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Reland "Expose build mode in environment of asset transformer processes"

Relands https://github.com/flutter/flutter/pull/144752, which had to be reverted because the branch was stale. The original branch branched off master before https://github.com/flutter/flutter/pull/144734 landed. That PR introduced a new AssetTransformer call site.
This PR branch is identical to the original but with a new commit that addresses the new call site, update new call sites.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Not a big deal but for the future, please bear in mind this part of the Tree Hygiene doc:

Also avoid using "Reland" in the commit message. When you later revert the revert, just land the PR afresh with the original commit message, possibly updated with the information since collected, and include a link to the original PR and to the revert PR so that people can follow the breadcrumbs later.


Introduce a new overrideInputs on {default,shell}Nix

Porting https://github.com/edolstra/flake-compat/pull/49 with some edits to avoid re-indentation and to fix a null reference bug.
This allows the user of this non-flake to have similar functionality to follows.
Example (default.nix):
nix-repl> (import ./.).default
«derivation /nix/store/axgvq22kyb8ymchzq1mjayms4jdl6ni6-ledc-0.1.0.drv»

nix-repl> ((import ./.).overrideInputs { nixpkgs = <nixpkgs>; }).default
«derivation /nix/store/r8zw693hpg91yx6f57hyx1gk4zdiq2lm-ledc-0.1.0.drv»

I tested this and it seems to work fine

This breaks on the dwarffs flake (https://github.com/edolstra/dwarffs/tree/9861d09c7a22f86d44e41d5ac049e7b4a8d1998d) with an "expected a string but found a list" error, presumably due to the structure of the nixpkgs follow.

For some reason this PR skipped my attention.. what is the status of it?

@zimbatm If I understand correctly, @DavHau's suggestion will fix the issue mentioned @alois31, which is that doing something like inputs.nixpkgs.follows = "nix/nixpkgs"; doesn't work with this. I haven't reviewed that change yet to include it. Feel free to do so on my behalf if you'd like to merge this.


Don't use pwd in fabrica.sh docker commands

Valid security issue, using pwd in current dir will pass it's content to docker.

[ ] It might be our project's source code or users home.
[ ] this is ambiguous, since different dirs are mounted to /network/target, depending on the command

perhaps it would be enough to rename /network/target to /fabrica-target or /fabrica-workspace


JKBMS Bluetooth - added battery details

added: capacity
added: MOS temperature
added: charging switch status
added: discharging switch status
added: balancing switch status
added: show if balancing is active and which cells are balancing
added: cell imbalance alert

One suggestion: From the jkbms you can read ["settings"]["balance_trigger_voltage"] maybe use this value (and a multiple of this value) rather than fixed values like 0.05 and 0.1 ?

That‘s a good idea. I‘m currently still gaining experience at which point the cell voltage difference is critical. What would you say when the cell difference should be warning and critical?

That‘s a good idea. I‘m currently still gaining experience at which point the cell voltage difference is critical. What would you say when the cell difference should be warning and critical?

Same here. No idea.
Critical-value however could be the one the bms has set as its trigger ["settings"]["balance_trigger_voltage"] . And warning? maybe half that value?

Regarding the cell voltage difference I found now that 5% of the maximum cell voltage or 200 mV are considered as critical.
So I would use 200 mA or 5% of OVP as critical and 120 mA or 3% of OVP as warning. Over Voltage Protection is fetched from the BMS.


This pshould cover how to protect against accidental deletion of the Storage Account or Resource Group.

I would suggest that this page also cover how to protect against accidental deletion of the Storage Account or Resource Group. Soft Delete is fine but not much protection again these other risks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 597c9b5f-f41f-400c-f4da-8bc8159d366a
Version Independent ID: 5b993db0-eb4c-11ce-83a2-3c577be2eebc
Content: Prevent accidental deletion - Azure file shares
Content Source: articles/storage/files/storage-files-prevent-file-share-deletion.md
Service: storage
Sub-service: files
GitHub Login: @khdownie
Microsoft Alias: kendownie

This page is meant specifically for Azure File Shares. The various data protection including stopping deletion for storage accounts can be found on this page:
https://docs.microsoft.com/en-us/azure/storage/blobs/data-protection-overview
Perhaps adding this link under the next steps section would be helpful. Assigning this feedback to the doc author for consideration.

Thanks for your responce.  Sure but the page you reference appears to be specific for Blobs and thus not Azure file shares.  I agree that some of the precautions apply, but they should be included on a Azure file shares page not just on the Blob page.

@terryclancy @DerekHerman-MSFT I have added the additional links to Next Steps, so this issue can now be closed. Thanks!
https://docs.microsoft.com/en-us/azure/storage/files/storage-files-prevent-file-share-deletion


Upgrading the Provider for compatibility with alpha1

Hiya Sammy!
I don't know how much more will change before a stable release of the OAuth2 client (and so I don't know if you're trying to follow it closely or basically wait until the dust has settled), but here are some changes that seem to make everything happy with alpha1 :). I'm making tutorial for something, and I'm hoping to use the OAuth2 client to make my (and everyone's) life easier - even if it's alpha. I really like the idea.
Thanks!

At this point, the API for oauth2-client shouldn't change. It's in alpha to give providers a chance to review and upgrade, as well as find issues that need to be resolved before a final 1.0.0 release.

Thanks Ben - really happy to hear that!

Actually, I'll revise what I said about the API not changing…
Take a look at https://github.com/thephpleague/oauth2-client/issues/362. I'll be doing a 1.0.0-alpha2 release this Saturday. Following that will be a beta1 release (probably after another week). As of the beta1 release, I am putting a freeze on the API.

@ramsey good plan - really happy to see that things are moving more than anything else - when releases get neglected and stall, that's very difficult (this is clearly not that situation). Thanks!

Thank you sir! :)

Yes! :fireworks:


[ML] : Lasso regression with distributed Frank-Wolfe under SSP with parameter server.

Implementation of the Distributed Frank-Wolfe optimization algorithm to solve a Lasso regresssion problem under SSP with a parameter server.
This pull request is based on #967 for the SSP implementation. It uses Apache Ignite as backend for the parameter server.
Distributed Frank-Wolfe is discussed here : http://arxiv.org/abs/1404.2644

Thanks for your contribution @thomaspeel.
Please bear with us. We still need to figure out how to get #967 in, so it might take a while until we can continue with your PR.

I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit.


Improve API documentation with information about limit and offset

The API documentation indicates that to list all embursments you have to execute the following get command
Listing reimbursements
GET /api/chamber_of_deputies/reimbursement/
Lists all reimbursements.
althoug, when we execute this command line the API retrives only the seven first rows. It is necessary to also indicate parameters limit and offset in order to fetch through the database, as I did in my code, as indicated bellow (R code).
library(jsonlite)

reembolso<- fromJSON("https://jarbas.serenata.ai/api/chamber_of_deputies/reimbursement/?limit=20&offset=20")

#LIsts 20 congressperson names from the 21st position
reembolso$results$congressperson_name

It is necessary to also indicate parameters limit and offset in order to fetch through the database

TLDR My take on that is that: no, it's not necessary.
The next page URL (including limit and offset)  is given in the next (or previous, when it's available) fields of every response. So users doesn't have to do the math, just use the URL given by the API itself.

This adopted largely in REST APIs and is important: it allows maintainers of the project to (try to) keep control of the offset and limit thinking about PostgreSQL performance and backend limitations (e.g. maybe override user's limit to avoid a query too big that might disrupt the service). So, as in the REST principle, following the API response to go to the next page: it's good to the users (the link is already there, as precise as it needs to be), it's good to the maintainers (this helps us keeping Jarbas alive).

Great. Next and previous really help a lot.
Maybe this explanation you've written could be added to the documenation.


Hide our own error stack on IPC messaged errors

From: https://github.com/sindresorhus/ava/issues/245#issuecomment-158339191

Our error stack is pretty useless when an error comes from the forked process.

Agreed.
I think the best solution is to stop rejecting the promise in that case. Rejection has the side affect of bailing out of Promise.all early, so other test files may not finish. We should resolve with an failure result, that will simply be summarized in the output. We should save rejection for unexpected/unrecoverable problems.

We should resolve with an failure result, that will simply be summarized in the output. We should save rejection for unexpected/unrecoverable problems.

:+1:

Pretty sure this has been addressed in various ways. Closing.


Allow configuration via hash as well as attributes

The ability to create multiple configurations on the same system is severely limited by the fact that it currently always points to the same node['openvpn']['config'] attribute. This allows a hash or some other node attribute to be given instead.
Please fix the tests. I want to be more confident about the changes I am making.

Thanks for merging all these. I can't remember whether I found any logic in config being an Array but evidently I thought Hash made more sense regardless. It can't have been to make the entries ordered because the template calls sort anyway and as you say, it's a hash in the attributes file. I'm surprised it wasn't already broken the way it was.

I think it wasn't broken because it just wasn't used.

Oh, good point. :grinning: It's been too long since I did this.


GPSd socket connection to host

Hard-coding host IP in kafka-gps-log.py is not a good solution as docker's localhost IP can change.
The optimal choice is to use docker.host.internal to have docker resolve to localhost. However, as mentioned in here, Linux won't have this function until docker version 20.04.
Maybe current workarounds is to use network_mode: host in docker-compose.yml and hard-code localhost in kafka-gps-log.py.

Fixed in 9a0ff755be4e33eb936034833b06e88ac216d710.


fix(ONYX-1026): start selling sticky button hoisted up (attempt 2)

This PR resolves ONYX-1026
Description

Turned out the fix in this PR was breaking the flow (that's why). We paired with Ole and decided to proceed with the solution which seems to work fine. We added a timeout to let the keyboard have more time to close and made the function asynchronous
Also, we found out that the issue is present on iOS as well, it's just not so obvious
PR Checklist

[x] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

wait for the keyboard to close before navigating back on the Sell flow -daria

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (wait for the keyboard to close before navigating back on the Sell flow -daria)

  Generated by :no_entry_sign: dangerJS against 17345a1e7778b55897feaa198859b607e2d1e6a0

Will go ahead and merge this now to have the 'x' button fixed before today's QA session.


DlError message: dlopen failed: library

DlError message: dlopen failed: library "./libfrida-gadget.so" not found
libfrida-gadget.so is frida-gadget

Use a full path like /data/local/tmp/libfrida-gadget.so

if theres nothing more from you i'll close this since a valid path would fix this issue...

does this work for any device than emulator?

yes not tested yet but in theory it should work for real devices too

does this work for any device for real phone than emulator?


Bootstrap servers should be list of escaped strings

Bootstrap servers are currently one string that is not escaped. Example:
stream = MemgraphKafkaStream(
    name="chatter_stream",
    topics=["chatters"],
    transform="twitch.chatters",
    bootstrap_servers="'kafka:9092'",
)

It should look like this:
stream = MemgraphKafkaStream(
    name="chatter_stream",
    topics=["chatters"],
    transform="twitch.chatters",
    bootstrap_servers=["kafka:9092","hehe:17"],
)

Related to https://github.com/memgraph/gqlalchemy/issues/93


Fully Automatable 2.0 Setup

Summary:
When provisioning a rancher stack, I would like to fully automate the first-time setup procedure for the UI/admin.
Currently, thanks to #12947 I can get past the admin password prompt by resetting the password first.
However, it still asks me for the server URL.
I want to be able to do ALL of the steps that currently require a UI through automation: https://rancher.com/docs/rancher/v2.0/en/quick-start-guide/
Requiring any explicit UI interaction is very un-friendly to devops-oriented workflows.
Thanks!
Details:
Rancher versions:
rancher/server: docker image rancher/server:v2.0.0-beta4-rc3
rancher/agent: n/a
Infrastructure Stack versions:
healthcheck: n/a
ipsec: n/a
network-services: n/a
scheduler: n/a
kubernetes (if applicable): n/a
Docker version: (docker version,docker info preferred)
Client:
 Version:	18.04.0-ce
 API version:	1.37
 Go version:	go1.9.2
 Git commit:	3d479c0
 Built:	Tue Apr 10 18:14:11 2018
 OS/Arch:	linux/amd64
 Experimental:	false
 Orchestrator:	swarm

Server:
 Engine:
  Version:	18.04.0-ce
  API version:	1.37 (minimum version 1.12)
  Go version:	go1.9.4
  Git commit:	3d479c0
  Built:	Tue Apr 10 18:23:35 2018
  OS/Arch:	linux/amd64
  Experimental:	false

Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 1
Server Version: 18.04.0-ce
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 10
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 773c489c9c1b21a6d78b5c538cd395416ec50f88
runc version: 4fc53a81fb7c994640722ac585fa9ca548971871
init version: 949e6fa
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.93-boot2docker
Operating System: Boot2Docker 18.04.0-ce (TCL 8.2.1); HEAD : b8a34c0 - Wed Apr 11 17:00:55 UTC 2018
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 995.6MiB
Name: rancher-master
ID: UHCV:NCYY:TNUG:YCXT:DT4G:3SHH:WDMF:U2LE:MAAM:4ZE7:AYCK:5NAK
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Operating system and kernel: (cat /etc/os-release, uname -r preferred)
NAME=Boot2Docker
VERSION=18.04.0-ce
ID=boot2docker
ID_LIKE=tcl
VERSION_ID=18.04.0-ce
PRETTY_NAME="Boot2Docker 18.04.0-ce (TCL 8.2.1); HEAD : b8a34c0 - Wed Apr 11 17:00:55 UTC 2018"
ANSI_COLOR="1;34"
HOME_URL="http://boot2docker.io"
SUPPORT_URL="https://github.com/boot2docker/boot2docker"
BUG_REPORT_URL="https://github.com/boot2docker/boot2docker/issues"

4.9.93-boot2docker

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
VirtualBox / docker-machine
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Just starting up a single admin node
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
2.0, so Kubernetes?
Steps to Reproduce:
Create new docker-machine
Start a rancher server
docker run -d --restart=unless-stopped -p 80:80 -p 443:443 rancher/server:v2.0.0-beta4-rc3

Hi @superseb
I really appreciate you providing that gist.
I still believe this should be logged as a feature request or similar, for at least documenting these APIs
I don't believe having to MITM capture web traces, to figure out the api, is an acceptable solution for a product designed around CI/CD/automation.
Thanks again.

The product is in beta, docs will follow shortly. These will probably not address your request for docs on API yet, but in the mean time you can use this method.


add: week ending oct 6 2017

ping @satra

lgtm - please do send updates over the last couple of weeks.


Extensibility point in AuthorizeEndpoint

As part of researching tenant based authentication I found I can vary the tenant without affecting the user's authentication within IdSrv4.  This seems reasonable, yet there doesn't appear to be an extensibility point within the AuthorizeEndpoint's ProcessAuthorizeRequestAsync that would allow additional validation or customizing the interaction to change the prompt mode.  It looks like in IdSrv I might be have been able to do this in PreAuthenticateAsync.
I'm testing this within the Mvc test project by including the "alice" tenant in the acr
            options.Events = new OpenIdConnectEvents
            {
                OnRedirectToAuthenticationEndpoint = ctx =>
                {
                    ctx.ProtocolMessage.AcrValues = "tenant:alice";
                    return Task.FromResult(0);
                }
            };

I then kill the Mvc authentication cookie and use the "bob" tenant.  I'd like to detect the tenant change via a claim set on the initial sign-in and force them to authenticate again.
            options.Events = new OpenIdConnectEvents
            {
                OnRedirectToAuthenticationEndpoint = ctx =>
                {
                    ctx.ProtocolMessage.AcrValues = "tenant:bob";
                    return Task.FromResult(0);
                }
            };

So in short, you're saying that if the acr_value=tenant:foo request param is passed, that it's not being honored if the user is already logged in with a idp other than "foo"?

Yes, though I'm not sure this should be handled differently in the default case.  My concern is more that there doesn't seem to be a way to reject the current IdentityServer identity during authorize.

Well, IIRC, in IdSvr3 if the tenant in the acr_values didn't match the user's idp, then we triggered a login. So if IdSvr4 doesn't do that, then it sounds like a regression bug.

Tenant and Idp are different unrelated things.
Sent from my iPhone

On 22.01.2016, at 18:16, Brock Allen<EMAIL_ADDRESS>wrote:
Well, IIRC, in IdSvr3 if the tenant in the acr_values didn't match the user's idp, then we triggered a login. So if IdSvr4 doesn't do that, then it sounds like a regression bug.
—
Reply to this email directly or view it on GitHub.

Oh yea, of course. Forget what I said then :/

Then I'm back to my original question.  Is there any way in IdSrv4 to force re-authentication based on authorize parameters or does this need to wait until some of the UserService bits are flushed out?

Yep -- so you can take a look at this (it might be an approach that works for you): https://github.com/IdentityServer/IdentityServer3/issues/2388#issuecomment-172640121


docker: invalid reference format: repository name must be lowercase.

I am getting this error on running
docker run -it --rm -v ${PWD}/config:/config -v ${PWD}/reports:/reports -p 9001:9001 --name fuzzingserver crossbario/autobahn-testsuite
from this directory of crossbar-docker/autobahn-testsuite.
I realized the problem is not on crossbar-docker. It is because ${PWD} and my folder path has a space and Cap letter. May be I think you should change the sample command into
docker run -it --rm -v "${PWD}"/config:/config -v "${PWD}"/reports:/reports -p 9001:9001 --name fuzzingserver crossbario/autobahn-testsuite so that it work for such cases as well.

well, don't put space in paths;) 101?


Update Python.gitignore

Added VSCode IDE folder
Reasons for making this change:

TODO
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

This will be helpful thanks for making this change!


Patch hashes and update the code

This patches bitcoin_hashes to use the version in the repository and fixes the code after removal of Deref.

Hmm, do we really need AS_DEPENDENCY test? What does it achieve?

I don't know what was the initial motivation for adding the dependency test but git blame tells me it was added by @elichai in commit 89f73ea686cf28ff44e066a5c341bf318811e8e5. Do you remember Elichai?

PR looks good to me.

Yes, IIRC we had a bug in the one of the macros, that it assumed some things were available(don't remember if it was a dependency it assumed or something else) but they weren't when the macro was used from outside of the crate.
So we added a test testing the macro as a dependency

Oh, wow, I thought this is not needed because integration tests were supposed to act exactly as if they used the library as a dependency but if they have some dependencies available that are used by macros I can totally see how the issue wouldn't be caught.
That being said, I don't think the test can check anything unless it actually calls the macro. Do you know which one it was?

We should be able to have an integration test that only uses hashes and calls all of the exported macros. And another one for bitcoin as well.

@tcharding yeah, I think that's what we should do. My suggestion is to remove/disable the current test for now to get this in and then we can do the change in parallel with other.

The latest push has those tests disabled.


Correct unnatural Japanese translation.

I'm sorry for my bad english.
Short description of what this resolves:

Older translation “アップデート・アップロードの設定” means “Settings of Update/Upload”
Older translation “GitHub の設定をアップデート・アップロードしています” means “Uploading/Updating settings of/for Github”, not “in Github”

Changes proposed in this pull request:

N/A

Fixes: N/A
How Has This Been Tested?

I probably did well. But I think there aren't any tests that aim for kinds of this change.

Screenshots (if appropriate):

Checklist:

[x] I have read the contribution guidelines.
[ ] My change requires a change to the documentation and GitHub Wiki.
[ ] I have updated the documentation and Wiki accordingly.

Can you fix the conflict so i can merge into upcoming release branch

I didn't understand the developing style of this project; I realized that this problem was already fixed by #1077.
So sorry to have troubled you.


Code coverage is including .svg file

I have essentially the default app generated by create-react-app, but with some packages added to enable React testing for Jest (and test file moved into __test__).
If I run jest --coverage everything works properly, however, if I add the following line to my App.js file, I get an error from running the same command:
import logo from '../../public/images/logo.svg';
The error is:
> jest --coverage

 FAIL  src/App/__test__/App.test.js
  ● Test suite failed to run

    /Users/kenc/dev/test/public/images/logo.svg: Unexpected token (1:0)
      > 1 | <svg id="Layer_3" data-name="Layer 3" xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 51.47 28.89"><defs><style>.cls-1{fill:#f7941d;}</style></defs>
<title>Artboard 1</title><path class="cls-1" d="LONG PATH REMOVED TO KEEP THIS SHORT"/>
<rect class="cls-1" x="24.15" y="10.57" width="4.41" height="3.12"/></svg>

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|
Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        1.134s
Ran all test suites.

I assume this is because jest is incorrectly trying to check code coverage for the .svg file.
I tried adding some config to my package.json to prevent it from looking at .svg files:
  "jest": {
    "coveragePathIgnorePatterns":["/node_modules/", ".*.svg"]
  }

That seemed to let it get further, as it now shows this error:
> jest --coverage

 FAIL  src/App/__test__/App.test.js
  ● Test suite failed to run

    /Users/kenc/dev/test/public/images/logo.svg:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){<svg id="Layer_3" data-name="Layer 3" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 51.47 28.89">
                                                                                ^
    SyntaxError: Unexpected token <

      at transformAndBuildScript (node_modules/jest-runtime/build/transform.js:320:12)
      at Object.<anonymous> (src/App/index.js:4:42)
      at Object.<anonymous> (src/App/__test__/App.test.js:3:40)

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|
Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.992s
Ran all test suites.

How can I prevent Jest from including .svg files in the coverage check?

This is unrelated to coverage. You are trying to import an svg file which you cannot do in node.js. Check out the tutorial here: http://facebook.github.io/jest/docs/tutorial-webpack.html#content

Ever find a solution?

Did you try the link in the post above yours?

Unfortunately that link is dead.

Oh, that's not good. Correct link is http://facebook.github.io/jest/docs/en/webpack.html
/cc @ericnakagawa is the "tutorial" part of the url gone on purpose? Is it possible to set up custom redirects?

Thanks. I gave an update at #2663 because it is still not working for me.

This is unrelated to coverage. You are trying to import an svg file which you cannot do in node.js. > Check out the tutorial here: http://facebook.github.io/jest/docs/tutorial-webpack.html#content

Did you try the link in the post above yours?

@cpojer @SimenB 404


Time format validation enhancement

What version of Ajv you are you using?
6.10.0
What problem do you want to solve?
No validation for incorrect time format in field definition {"type": "string", "format": "time"}. For example: 25:00:00 (example code)
What do you think is the correct solution to problem?
Change code in file lib/compile/formats.js:
AS IS:
var TIME = /^(\d\d):(\d\d):(\d\d)(\.\d+)?(z|[+-]\d\d:\d\d)?$/i;
TOBE:
var TIME = /^(2[0-3]|[01]?[0-9]):([0-5]?[0-9]):([0-5]?[0-9])(\.\d+)?(z|[+-]\d\d:\d\d)?$/i;
Will you be able to implement it?
No sure if I can manage all necessary auto tests, but I can try

It does more thorough validation with the option format: “full”


This plugin did not work on windows 11.

I tried to add some code like the following in my main.dart.
  if (!kIsWeb && (Platform.isWindows || Platform.isLinux || Platform.isMacOS)) {
    var size = Size(config.windowWidth, config.windowHeight);
    // disable window resizing
    await DesktopWindow.setWindowSize(size);
    await DesktopWindow.setMinWindowSize(size);
    await DesktopWindow.setMaxWindowSize(size);
  }

However, I got no response on windows 11, I have tested it ok on windows 10. If I comment these pieces of code or change it to use window_size of github.com/google/flutter-desktop-embedding, it works too.
https://user-images.githubusercontent.com/2276718/137615433-75a18ab6-92df-44f8-a3f1-a6a20afbb511.mp4

I had the same problem. I fixed it removing the "await" key

I had the same problem. I fixed it removing the "await" key

Thanks man! it helped me too, but it's still strange

Did you call this method in the main() ?

No idea why this works but removing await works for me too.


Only use long_name if it is a string

Fixes the hvplot part of https://github.com/holoviz/holoviews/issues/5615
This change makes it so that it only uses the long name if it is a string.

LGTM, thanks!


Mocha versions 2.3.0 and 3.0.0

Hi,
I am doing some research on Mocha 2.3.0 and 3.0.0 versions and am interested in end of availability/support dates for these versions.
What kind of support I can have if I use theses versions beyond their end of their availability/ support?
Any information on this subject is appreciated.
Best regards,
Ardeshir.

2.3.0 was released, and 3.0.0 is in the works, though the scope is still being discussed. Hard to say what will go into 3.0.0, and we don't yet have a timeline AFAIK. In terms of support, you should try to stick to the most recent version as we try our best to avoid breaking changes. But if a regression is found, we'll hopefully resolve it rather quickly. :) And of course, there's the option to stick to older versions.
As long as you're on 2.x.x, you should expect good support, as the core implementation hasn't drastically changed across minor/patch releases.


CMAKE_BUILD_TYPE not used on windows

It appears that the CMAKE_BUILD_TYPE  standard cmake flag is ignored.
What is the appropriate way to produce a release build of SQLiteCpp on windows?

Windows is a multi-config build system, so you can do the following (assuming you're currently cd'd to the repo).
mkdir build
cd build
cmake ..
cmake --build . --config Release

This'll be the same for all projects you might build with Cmake.

Yes, thanks for answering.
It's done like that in CI https://github.com/SRombauts/SQLiteCpp/blob/master/appveyor.yml and https://github.com/SRombauts/SQLiteCpp/blob/master/.github/workflows/build.yml


LAN IP addresses

Homebridge on RPI4, Ubuntu 20.04.1, nodejs 14
4 sonoff items, randomly one gets LAN address upon restart of homebridge service but the other three show as not LAN compatible. Latest update reports a change in LAN address to my router address. All sonoff items are in a separate VLAN. When trying to connect to the sonoff items using the router address, it fails as expected and changes connections to WS.
May I suggest offering a configuration mode to hardcode the IP address of the switches/lights/etc?

May I suggest offering a configuration mode to hardcode the IP address of the switches/lights/etc?

This is something I could definitely implement. Give me some time and it's something I can do. I will be in contact.
When working with separate VLANs it makes it very hard to code and the easiest solution would be to implement hardcoded IPs via the config.

Hi @AQPSal
Please try updating to v2.25.1 and then adding this to the json config file in the appropriate place:
"ipOverride": {
   "100012ab34": "<IP_ADDRESS>"
}

or for multiple devices
"ipOverride": {
   "100012ab34": "<IP_ADDRESS>",
   "100012ab35": "<IP_ADDRESS>",
   "100012ab36": "<IP_ADDRESS>"
}

where the value on the left is the ewelink device id and the right value is (obviously!) the ip.
I'm assuming you're comfortable with editting the json directly... but let me know if you need more explanation.
Then restart Homebridge and ideally:

the devices will be configured with the IP you have set in the config
any "incorrect" future IP updates will be ignored by the plugin.

Let me know!

Seems to be working well. I have only tested it for a couple of minutes. I'll report back in a few days. Thank you!

After a few hours of testing, it works perfectly. Thank you again. Fantastic job1

Ah glad it's worked for you. Maybe this feature will help others too :)


I pulled a new image yesterday, and certainly met a fatal error, I wish someone could fix it.

I reckon these Images are indeed bug existing.

@Crazybun0422 - Looks like something is trying to create a directory in /layers/heroku_nodejs-npm-install at runtime. I'm not surprised that you would see EACCES for that. Do you have any insights into what might be doing that? Are you calling npm at runtime in some way?

@Crazybun0422 - Looks like something is trying to create a directory in /layers/heroku_nodejs-npm-install at runtime. I'm not surprised that you would see EACCES for that. Do you have any insights into what might be doing that? Are you calling npm at runtime in some way?

I did npm install when initializing the app, however, this error is reported as I did execute 'node ./web/index.js'. that's difficult to understand why, and this error just appeared when I pull this image last time. so I just guess all these images actually released buged.

I suddenly found this 'heroku/builder-classic:2.2' is worked

heroku/builder-classic:22 Only this version is work. I tested times of them
@joshwlewis

@Crazybun0422 heroku/builder-classic:22 is deprecated, and part of the reason is that it uses an older Buildpack API (0.4, 0.10 is current). I don't think you'll be able to fix those deprecation warnings.
I highly suggest heroku/builder:22 instead. I'd like to understand more about the issue with heroku/bulder:22 - can you try starting the app with DEBUG=*?

@Crazybun0422 Have you had a chance to try the above? Also, could you provide more information on when this stopped working? The build log from the last successful build would be very helpful.


fix spacing between name and updated time

Description
Fix spacing between name and updated time in image-set details header
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report

Merging #292 (700ab5c) into master (f2f5631) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   31.23%   31.26%   +0.02%
==========================================
  Files         102      102
  Lines        2110     2108       -2
  Branches      620      618       -2
==========================================
  Hits          659      659
+ Misses       1330     1328       -2
  Partials      121      121

Impacted Files
Coverage Δ

src/Routes/ImageManagerDetail/DetailsHeader.js
0.00% <0.00%> (ø)

src/Routes/ImageManagerDetail/ImageDetail.js
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f5631...700ab5c. Read the comment docs.


Set a file output format

I like the exported PDF to be qboard date time.pdf or something that won't give me file(n).pdf.

Addendum: Same thing, but with the json file.

closed by ea83fb81c9f4a74603b621dd95b861b682f2b2e2


Modification for VMAT Legs

We would like to see a new option where the legs could also be set to VMAT when needed. This is a change as part of bringing this tool clinical and we will be returning the change back upstream. I'd be happy to discuss any impacts here!
Line reference for sanity
https://github.com/esimiele/VMAT-TBI/blob/1f20b17b8d12595836d9dd9cf77297c619d70b7b/ESAPI/Projects/VMATTBIautoPlan/placeBeams.cs#L61

Will make this change in the near future (next week or so if you don't beat me to it haha!), but will need your help testing it as we don't do TMI/TMLI at Stanford or Rutgers using VMAT.

The script optimizes all of the VMAT fields in one plan with the patient in the HFS position. Code will need to be added to the plan preparation section to copy the original plan, remove all fields superior to the matchline, take all the fields inferior to the matchline and reverse the field orientations and control points.

Thank you, that's the next step I wanted to discuss. We currently have a matlab script doing that control point manipulation. I was debating writing an eclipse script or adding to yours to reorient the leg plans.

Cool! No worries, The logic should be pretty simple. It's the ESAPI syntax that will be a pain in the butt to figure out. Could you send the snippet of your matlab code that reverses the control points (via DM)? Will be a nice double check of my logic

I talked with the author, and he's okay with me posting it here. We've gone with 175 and 185 for collimator angles which gives us 355, and 5 for the clinical plan.
I realized I had never shared my solution, though yours looks more readable then mine. Our clinical practice currently is to use the same energy for the legs as for the body, I'm not sure what the generally accepted practice will be going forward.
Info = dicominfo(file);     %Dicom info
RPmodified = Info;          %New plan file
FN = fieldnames(Info.BeamSequence);     %Number of beams
BeamNumber = length(FN);

for i=1:BeamNumber          %Loop through beams

    CPcount = Info.BeamSequence.(FN{i}).NumberOfControlPoints;      %Number of control points
    CPList = fieldnames(Info.BeamSequence.(FN{i}).ControlPointSequence);    %Control points
    ControlPoints = Info.BeamSequence.(FN{i}).ControlPointSequence;

    for j=1:CPcount     %Loop through control points

        if j==1         %First control point set col angle
           Col = ControlPoints.(CPList{j}).BeamLimitingDeviceAngle;  %Angle
           if Col > 180
               Col = Col-180;
           else
              Col = Col+180;   %Flip 180 degrees
           end
           RPmodified.BeamSequence.(FN{i}).ControlPointSequence.(CPList{j}).BeamLimitingDeviceAngle = Col;
        end

        Dir = ControlPoints.(CPList{j}).GantryRotationDirection;     %Gantry rotation direction
        if strcmp(Dir,'CW')     %If CW set to CC
            RPmodified.BeamSequence.(FN{i}).ControlPointSequence.(CPList{j}).GantryRotationDirection = 'CC';
        elseif strcmp(Dir,'CC')     %If CC set to CW
            RPmodified.BeamSequence.(FN{i}).ControlPointSequence.(CPList{j}).GantryRotationDirection = 'CW';
        elseif strcmp(Dir,'NONE')   %Last control point has direction set as 'NONE'
            'Done'
            i   %Do nothing
        else
            error('Undefined Gantry')
        end

        swapAngle = ControlPoints.(CPList{CPcount-j+1}).GantryAngle;  %Swap angle with opposite 1-178 2-177 3-176 etc...
        RPmodified.BeamSequence.(FN{i}).ControlPointSequence.(CPList{j}).GantryAngle = swapAngle;

    end
end

This feature and the reversal of the control points will be implemented in a future release of:
https://github.com/esimiele/VMAT-TBI-CSI
as we expand into VMAT TMI/TMLI


Dynamic pooling (Or variable-size pooling?)

Is there a way of performing dynamic pooling in Keras? (1D CNN)
Like Goldberg elaborates: Splitting the resulting output from the convolution (conv layer) into r groups, thus apply pooling separately on each group, where the groups can be of different sizes.
Or is there a way of performing variable-size pooling?
Example:
Given a text of sentences, text = [sentence1, sentence2, sentence3], where sentence1 is of length 20, sentence2 of length 15, and sentence3 of length 18 (counted in words).
Is there a way of grouping the convolution associated with the words from sentence1, sentence2, and sentence3? Thus apply pooling at each group.
...
conv = Conv1D(filters=100 kernel_size=2, strides=1, padding="valid", activation="relu")(training)
pool_0 = MaxPooling1D(pool_size=20, stride=20)(conv[0])
pool_1 = MaxPooling1D(pool_size=15, stride=15)(conv[1])
pool_2 = MaxPooling1D(pool_size=18, stride=18)(conv[2])
traning = concatenate([pool_0, pool_1, pool_2)
...
Or performing variable-size pooling, a structure like:
...
conv = Conv1D(filters=100 kernel_size=2, strides=1, padding="valid", activation="relu")(training)
pool = MaxPooling1D(pool_size=[20, 15, 18], stride=[20, 15, 18])(conv)
traning = concatenate([pool[0], pool[1], pool[2])
...
Thanks.

I need this as well to implement XML-CNN.