Io uring fix stop facade

Using the stopping facade writes currently the wrong pointer into the IORING_OP_ASYNC_CANCEL operation. This PR fixes this by passing the pointer to __task which is used for the original submission.
Its still a draft because I stlil want to think about a cleaner solution

/ok to test

/ok to test

It doesn't seem to be a timing issue.

/ok to test

/ok to test

I could finally reproduce the issue. It is because the container image is based on Ubuntu-2204 but the GPU host runner is probably on an older system with a Kernel 5.4 (I assume ubuntu-2004).
I could reproduce the error in a Ubuntu-2004 VM where I compiled and ran the tests in an Ubuntu-2204 container.
We have implemented two strategies for cancelation based on the kernel version. But since this is a header-only solution the detection of the kernel version works via defines in /usr/include/linux/version.h which reports a newer kernel version than what is actually being used.
The question is how to solve this now. I know of following solutions

Generate a cmake configure file with the actual detected kernel version of the host system and use this detection
Make the cancelation strategy a run-time decision instead of a build-time decision by detecting the factual kernel-version in run-time
Improve the CI by matching Host kernel and kernel headers within the image.

any thoughts?
@trxcllnt @ericniebler

Improve the CI by matching Host kernel and kernel headers within the image.

This would be my preferred solution. I don't think we're under any obligation to support Franken-distros. @trxcllnt, any clue what could have led to this situation?

Improve the CI by matching Host kernel and kernel headers within the image.

This would be my preferred solution. I don't think we're under any obligation to support Franken-distros. @trxcllnt, any clue what could have led to this situation?

I want to side note that up until recently the default github action runner were based on ubuntu-20.04 too.
If upgrading the runners host system is too complicated because of other dependencies the test should also be OK with a container image based on 20.04. Or at least faking the Linux header files

Paul makes the valid point that if code is compiled on one kernel version and run on another, it should still work. That argues for runtime detection.

Paul makes the valid point that if code is compiled on one kernel version and run on another, it should still work. That argues for runtime detection.

We have compatibilty for newer kernel versions. i.e. if we compile an application with kernel version 5.4 it will also run correctly on kernel 5.15. If I build my application against kernel version 5.15 and use features of this newer kernel I don't really expect my application to work correctly on an older kernel.
I will add the runtime check nonetheless. But it will pessimize the size of the timed schedule operations, because the solution that uses timerfd has more state.
io_uring itself provides a query for supported op codes but this is officially available since kernel version 5.6. Since we Ubuntu-20.04 ships with kernel version 5.4 the only way to test for cancelation support is to make dummy cancel request and check the errro code for -EINVAL. I will do so in the constructor of io_uring_context.

How about this: We require a kernel version of 5.5 (which introduces IORING_OP_ASYNC_CANCEL) or higher for io_uring support and if we detect an older version within CMake we shouldn't build the io_uring tests? I could completely remove the timerfd workaround.

/ok to test

/ok to test

There was something weird going on for nvc++ for the run-time detection. I've revert those changes and disabled the tests for GPU CI. We just need to remember re-enable the tests whenever the host machine of the GPU gets a newer kernel version.

/ok to test

/ok to test

Thank you!


Connect to herelink udp stream

I can connect to herelink usb and activate teethering, my raspberry can ping herelink at <IP_ADDRESS> trough usb0 ethernet. Herelink is emitting an udp stream at port 14552.
If i start on my raspberry:
mavproxy.py --master=udpout:<IP_ADDRESS>:14552 --out=udpbcast:<IP_ADDRESS>:14550
Everything works and stream is rebroadcasted on the wifi network that the raspberry creates.
Now i would like to use mavlink-router to do the same, i pretty much tried everything but nothing seems to work:
mavlink-routerd  <IP_ADDRESS>:14552
Error binding socket (Cannot assign requested address)
Could not open <IP_ADDRESS>:14552
mavlink-routerd -e <IP_ADDRESS>:14552
Open UDP [4] <IP_ADDRESS>:14552
Error binding socket (Cannot assign requested address)
Could not open <IP_ADDRESS>:14552
I just can't connect to source of stream no matter what i try.

With mavlink-router, there are two types of UDP endpoint: One listening for incoming data at a specified port ("Eavesdropping") and one for sending data to a specific IP and port ("Normal"). Using the command line syntax, the -e arguments are always in normal mode ("output"), while the last endpoint is created in eavesdropping mode ("input"). (The documentation of this is not clear enough.)
Your commands are trying to open an UDP port on <IP_ADDRESS>, which isn't the IP of your host. So this has to fail, because you can only listen on the IP of any of your network devices or all devices together (using <IP_ADDRESS>).
You're writing, that the herelink is "emitting an udp stream at port 14552", which couldn't be 100% true. The herelink can either send data to an IP and port configured at that device (from port 14552) or you can connect to it at port 14552, which seems to be the case reading you mavproxy command.
The second case isn't possible with mavlink-router, because mavlink-router would have to send a packet to the herelink first to establish a connection. I don't know mavproxy in detail, but it seems, that it'll emit heartbeats on it's own to initialize an "udpout" connection. Mavlink-router does not do this!
The only thing, you could try with mavlink-router would be this command (listening for UDP data on 14552 and sending to <IP_ADDRESS>:14550):
mavlink-routerd -e <IP_ADDRESS>:14550 <IP_ADDRESS>:14552

Hopefully the instructions above clarify. For herelink, since it's IP-based, another possibility is to skip mavlink-router altogether and just use iptables rules to route them. This is what I did for the Parrot SkyController 2. See https://github.com/ArduPilot/dema-rc/blob/master/distro/sc2/usr/bin/dema-rc-cm#L23-L33


The most useful Markdown table plugin

Nothing else. Just want to thank you.

Glad you like it.

Honestly, this is an awesome plugin.  I picked this plugin randomly and even without much experience with NeoVim (I use LunarVim), it works flawlessly.

@tahir-hassan Thank you, I appreciate it.


set carousel to slide

It seems there may be issues with our settings if someone switches the animation to fade. This gets applied to both the carousel and the flexslider itself. However, fade does not work for the thumbnail nav.

closed via #171 and #172


introduce transform parser

aim to support primitive passthrough tranform input data stream

cast from timestamp to unix_time
add column based on compute value of multiple row
filter or downsample based on row value

instead of creating own yaml configuration, use subset of ansi SQL to and on demand transform lambda function
https://druid.apache.org/docs//0.15.1-incubating/ingestion/transform-spec.html

The goal of this pr is to evaluate sql / js approach side by side. If JS approach wins, this dep will be removed.


chore(protos): update protos to v0.119.0 and regenerate code

This PR was created automatically by the CI pipeline to update the .proto files to the latest release from client_protos, v0.119.0, and regenerate the go protobuf code.

FYI this is the PR for the latest release.


WIP Enabling Avgpool1d, pooling converters refactoring.

Description
Enabling Avgpool1d, pooling converters refactoring.
Marked as WIP as it Includes/depends on  previous Conv1D PR.
Also, I merged in MatMul PR to try passing my test case. No dependency on this one.
Need to add unit test, too.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines of this project (You can use the linters)
[x ] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[ ] I have added tests to verify my fix or my feature
[x ] New and existing unit tests pass locally with my changes

Superseded by https://github.com/NVIDIA/TRTorch/pull/435


Update getJigsawJDK.sh to the new Jigsaw downlaod page

This should fix issue #65

@lasombra if you want to resolve #66 you ccan already do it
you will have to save this script file with a different name, which will make two script files available in the system:
getJDK.sh
getJigsawJDK.sh

Are you able to get my drift?
Do you want to create a new PR with those changes?

Yeah. Let me work on it.

Works fine on my ubuntu box as well - would be great to have some others test it out. But safe to merge now.


https://docs.raku.org/language/intro has a bad link

links to https://docs.raku.org/language/ which is now a 404. removing the / works

The bad link is gone.


install rollouts 1.0.6

Codecov Report

Merging #82 (29cba93) into main (88cb972) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   25.13%   25.13%
=======================================
  Files           1        1
  Lines         187      187
=======================================
  Hits           47       47
  Misses        134      134
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cb972...29cba93. Read the comment docs.


chore: changes to access APPSMITH_FEATURE_CONFIGS in worker

We need to access env variables in eval worker to filter PLATFORM_FUNCTIONS in EE.
Related PR: https://github.com/appsmithorg/appsmith-ee/pull/1015

/ok-to-test sha=722585a

/ok-to-test

/ok-to-test sha=ad7fcf0

/ok-to-test sha=a41894a


include rxjs fail in angular4

Hi there.
I used RXJS and ng2-file-upload in my project. I want to build production version in AOT.
Rollup failed when i include 2 modules like this:

plugins: [
nodeResolve({ jsnext: true, module: true, modulesOnly: false }),
commonjs({
include: ['node_modules/rxjs/', 'node_modules/ng2-file-upload/'],
namedExports: {
'node_modules/ng2-file-upload/index.js': ['FileUploader'],
'node_modules/rxjs/Subject.js': ['Subject']
},
}),
uglify()
]

error info:
Error: 'Subject' is not exported by<EMAIL_ADDRESS>and i change rollup-config like this:
 include: ['node_modules/**', 'node_modules/ng2-file-upload/**']
RXJS just fine but FileUploader can not include.
[!] Error: 'FileUploader' is not exported by<EMAIL_ADDRESS>How can i include then both?

I currently have the same issue with this error, while thryin yo create umd file with rollup.js in Angular 4
[!] Error: 'Subject' is not exported by ../../node_modules/rxjs/Subject.js
Ive tried this but i still get an error.
   commonjs({
        include: 'node_modules/**',
        include: 'node_modules/rxjs/Subject.js',
        namedExports: {
            'node_modules/rxjs/Subject': [ 'Subject' ]
        }
    }

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid. We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets transferred to the new repo. :beer:


Create cloudbuild.yaml

"Control deployment promotion via trigger variable" -commit and code copied from
https://github.com/googleinterns/step7-2020/blob/master/cloudbuild.yaml

awesome, i will follow this same step to add this file to our capstone repo


Mapping color X, Y  coordinates in to  depth x, y coordinates

Hello,
I am performing object detection on the color Image, what then gives me x, y coordinates in the color Image space. I now would like to map the color x, y coordinates in to the depth x, y coordinate space.
Is there a way to do that with the SDK or to retrieve the transformation Matrix?, The Depth date and Image have the same size (1280x720), and i am using the D435i and Python3.
Thanks
EDIT:
This question is similar to this one:
https://github.com/IntelRealSense/librealsense/issues/5943#issue-572912072

If you need to map color pixels to depth pixels, I wonder if the instruction rs2_project_color_pixel_to_depth_pixel may meet your needs.
https://github.com/IntelRealSense/librealsense/issues/2948

@XMaster96 Did you get chance to try what MartG-RealSense suggested? Any update? Thanks!

@XMaster96 Any update from your side? Thanks!

Sorry for not answering.
The priorities in my project have changed, and so I haven't tried it yet. I looked in to the link from @MartyG-RealSense, and it seems to solve my problem
I am also closing this issue for now, because I do not know when I will come back to it.
Thanks a lot for the the help


POC Support date_bin on timestamps with timezone

This PR is a POC to support date_bin on timestamps with timezone. There are two things covered in this PR:

adds a UDF function to_local_time():

only accept 1 input in type Timestamp(..., *)
return in type Timestamp(..., None)
for example:

> select to_local_time('2024-04-01T00:00:20Z'::timestamp AT TIME ZONE 'Europe/Brussels');
+---------------------------------------------+
| to_local_time(Utf8("2024-04-01T00:00:20Z")) |
+---------------------------------------------+
| 2024-04-01T00:00:20                         |
+---------------------------------------------+
1 row(s) fetched.
Elapsed 0.010 seconds.

> select to_local_time('2024-04-01T00:00:20'::timestamp AT TIME ZONE 'Europe/Brussels');
+--------------------------------------------+
| to_local_time(Utf8("2024-04-01T00:00:20")) |
+--------------------------------------------+
| 2024-04-01T00:00:20                        |
+--------------------------------------------+
1 row(s) fetched.
Elapsed 0.008 seconds.

Combine to_local_time() with date_bin() will look like:
> select date_bin(interval '1 day', to_local_time('2024-04-01T00:00:20Z'::timestamp AT TIME ZONE 'Europe/Brussels'));
+----------------------------------------------------------------------------------------------------+
| date_bin(IntervalMonthDayNano("18446744073709551616"),to_local_time(Utf8("2024-04-01T00:00:20Z"))) |
+----------------------------------------------------------------------------------------------------+
| 2024-04-01T00:00:00                                                                                |
+----------------------------------------------------------------------------------------------------+

> select date_bin(interval '1 day', to_local_time('2024-04-01T00:00:20Z'::timestamp AT TIME ZONE 'Europe/Brussels')) AT TIME ZONE 'Europe/Brussels';
+----------------------------------------------------------------------------------------------------+
| date_bin(IntervalMonthDayNano("18446744073709551616"),to_local_time(Utf8("2024-04-01T00:00:20Z"))) |
+----------------------------------------------------------------------------------------------------+
| 2024-04-01T00:00:00+02:00                                                                          |
+----------------------------------------------------------------------------------------------------+

Support date_bin on timestamps with timezone -- the original date_bin works correctly. the confusion happens at the display of the timestamp when there is a timezone. Even though the underlying time, the UTC time is correct, but when there is a timezone, the display automatically adjust the time, which result the display time to be wrong. Adjusting the underlaying time can make the final display time to our expected result.

With the implementation in https://github.com/appletreeisyellow/datafusion/pull/9/commits/54f1bdc5e83044d61b4eb278e22559d01140ebb3, there is a change in behavior https://github.com/appletreeisyellow/datafusion/pull/9#discussion_r1662931294, which is not right.
Then I looked into Postgres to see how it works. This is what I found:

psql date_bin() displays the result either with timezone in UTC or without timezone. They don't display it in a different timezone, or maybe I'm missing something

postgres =# SELECT
  date_bin('1 d', '2021-10-31T01:00:00', '1970-01-01T00:00:00'),
  date_bin('1 d', '2021-10-31T01:00:00'::timestamp, '1970-01-01T00:00:00'),
  date_bin('1 d', '2021-10-31T01:00:00' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00'),
  date_bin('1 d', '2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00'),
  date_bin('1 d', '2021-10-31T01:00:00', '1970-01-01T00:00:00') AT TIME ZONE 'Europe/Brussels',
  date_bin('1 d', '2021-10-31T01:00:00', '1970-01-01T00:00:00') AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels'
;
        date_bin        |      date_bin       |      date_bin       |        date_bin        |      timezone       |        timezone
------------------------+---------------------+---------------------+------------------------+---------------------+------------------------
 2021-10-31 00:00:00+00 | 2021-10-31 00:00:00 | 2021-10-31 00:00:00 | 2021-10-30 00:00:00+00 | 2021-10-31 02:00:00 | 2021-10-30 22:00:00+00
(1 row)

This is very different from what DataFusion is currently doing, with cargo build from the current main branch:
> SELECT
  date_bin(interval '1 day', '2021-10-31T01:00:00', '1970-01-01T00:00:00') AS date_bin_1,
  date_bin(interval '1 day', '2021-10-31T01:00:00'::timestamp, '1970-01-01T00:00:00') AS date_bin_2,
  date_bin(interval '1 day', '2021-10-31T01:00:00' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00') AS date_bin_3,
  date_bin(interval '1 day', '2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00') AS date_bin_4,
  date_bin(interval '1 day', '2021-10-31T01:00:00', '1970-01-01T00:00:00') AT TIME ZONE 'Europe/Brussels' AS date_bin_5,
  date_bin(interval '1 day', '2021-10-31T01:00:00', '1970-01-01T00:00:00') AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels' AS date_bin_6
;
+---------------------+---------------------+---------------------------+---------------------------+---------------------------+---------------------------+
| date_bin_1          | date_bin_2          | date_bin_3                | date_bin_4                | date_bin_5                | date_bin_6                |
+---------------------+---------------------+---------------------------+---------------------------+---------------------------+---------------------------+
| 2021-10-31T00:00:00 | 2021-10-31T00:00:00 | 2021-10-30T02:00:00+02:00 | 2021-10-31T02:00:00+02:00 | 2021-10-31T00:00:00+02:00 | 2021-10-31T02:00:00+02:00 |
+---------------------+---------------------+---------------------------+---------------------------+---------------------------+---------------------------+
1 row(s) fetched.
Elapsed 0.031 seconds.

Different number of timestamp casting will result in a different date type in terms of timezone:

Odd number of timestamp casting --> timestamp without time zone
Even number of timestamp casting --> timestamp with time zone
This postgres behavior is mentioned in https://github.com/apache/datafusion/issues/10368#issuecomment-2111684373,  https://github.com/apache/datafusion/issues/10602#issuecomment-2122811703, and https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-ZONECONVERT

postgres =# SELECT
  pg_typeof('2024-03-31T00:30:00') AS type_unknown,
  pg_typeof('2024-03-31T00:30:00' AT TIME ZONE 'Europe/Brussels') AS type_wo_tz, -- 1 casting
  pg_typeof('2024-03-31T00:30:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels') AS type_w_tz, -- 2 casting
  pg_typeof('2024-03-31T00:30:00'::timestamp AT TIME ZONE 'UTC') AS type_w_tz, -- 2 casting
  pg_typeof('2024-03-31T00:30:00'::timestamp AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels') AS type_wo_tz -- 3 casting
;
 type_unknown |         type_wo_tz          |        type_w_tz         |        type_w_tz         |         type_wo_tz
--------------+-----------------------------+--------------------------+--------------------------+-----------------------------
 unknown      | timestamp without time zone | timestamp with time zone | timestamp with time zone | timestamp without time zone
(1 row)

My purpose is:

For short term fix, use UDF function to_local_time() combined with the current implementation of date_bin() to achieve the desired result
For long term fix, we might need to be clear on the timestamp representation in arrow-rs first before we can moving forward: https://github.com/apache/arrow-rs/issues/5827

My proposal is:

For short term fix, use UDF function to_local_time() combined with the current implementation of date_bin() to achieve the desired result

This makes sense to me

For long term fix, we might need to be clear on the timestamp representation in arrow-rs first before we can moving forward: Propose change timestamp casting with timezone to without timezones (also parsing of timestamps without timezones) apache/arrow-rs#5827

If we made the change proposed in https://github.com/apache/arrow-rs/issues/5827, would that "solve" all these issues?
If so, how would someone implement timezone aware date binning?
Would it be to do like what postgres does and cast back to timestamp without timezone?

If so, how would someone implement timezone aware date binning?
Would it be to do like what postgres does and cast back to timestamp without timezone?

This is how postgres behaves:

If the input timestamp has timezone, date_bin result will be in the timezone of the system, instead of the input timezone! postgres date_bin aware the system timezone, but not the input timezone!

Currently, DataFusion date_bin returns the same timezone as the input timezone
Do we want to match the behavior to postgres?

If the input timestamp doesn't have timezone, date_bin result will not have timezone

For example, in postgres:
postgres =# select
  pg_typeof('2021-10-31T01:00:00'::timestamp) as input_datatype,
  date_bin('1 d', '2021-10-31T01:00:00'::timestamp, '1970-01-01T00:00:00'),
  pg_typeof(date_bin('1 d', '2021-10-31T01:00:00'::timestamp, '1970-01-01T00:00:00')) as result_datetype;
       input_datatype        |      date_bin       |       result_datetype
-----------------------------+---------------------+-----------------------------
 timestamp without time zone | 2021-10-31 00:00:00 | timestamp without time zone
(1 row)

postgres=# show timezone;
    TimeZone
-----------------
 America/Chicago
(1 row)

postgres=# select
  pg_typeof('2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels') as input_datatype,
  date_bin('1 d', '2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00'),
  pg_typeof(date_bin('1 d', '2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00')) as result_datetype;
      input_datatype      |        date_bin        |     result_datetype
--------------------------+------------------------+--------------------------
 timestamp with time zone | 2021-10-30 01:00:00-05 | timestamp with time zone
                                            -- -05 is the system timezone,  it is 01:00 instead of 00:00 because the origin time is '1970-01-01T00:00:00'

# if cast the origin to 'Europe/Brussels' timezone, the result will be at 00:00
postgres=# select date_bin('1 d', '2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels');
        date_bin
------------------------
 2021-10-31 00:00:00-05
(1 row)

postgres=# set time zone 'UTC';
SET

postgres=# show timezone;
 TimeZone
----------
 UTC
(1 row)

postgres=# select
  pg_typeof('2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels') as input_datatype,
  date_bin('1 d', '2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00'),
  pg_typeof(date_bin('1 d', '2021-10-31T01:00:00' AT TIME ZONE 'UTC' AT TIME ZONE 'Europe/Brussels', '1970-01-01T00:00:00')) as result_datetype;
      input_datatype      |        date_bin        |     result_datetype
--------------------------+------------------------+--------------------------
 timestamp with time zone | 2021-10-30 00:00:00+00 | timestamp with time zone
                                            -- -01 is the system timezone, instead of the input timezone
(1 row)

My proposal is:

For short term fix, use UDF function to_local_time() combined with the current implementation of date_bin() to achieve the desired result
For long term fix, we might need to be clear on the timestamp representation in arrow-rs first before we can moving forward: Propose change timestamp casting with timezone to without timezones (also parsing of timestamps without timezones) apache/arrow-rs#5827

Here is the short term fix PR: https://github.com/apache/datafusion/pull/11347
For long term fix, there are still discussions going on in https://github.com/apache/arrow-rs/issues/5827 which is the first step of the long term fix.
At this point, I conclude the POC is done, so closing this draft PR.


Is it possible to labeling images with keypoint and panoptic type?

My actions before raising this issue

[ V] Read/searched the docs
[ V] Searched past issues

I try to label some object with keypoints and panoptic types, but I can't find any solution on CVAT.
currently I have to integrate some automatic labeling tool into CVAT and I integrated bounding box and semantic segmentation method, but I not yet find a way to import keypoint and panoptic result came from automatic labeling tool to CVAT for editing by human  and exporting final data.

Keypoints and panoptic COCO formats are not fully supported yet.
Keypoints are not supported, but they can be imported as just points with COCO format import and then they can be exported with Datumaro to COCO format, but they won't contain categories and visibility properties.
RLE instance segmentation from COCO instances/stuff and VOC png segmentation masks are supported, but not COCO panoptic.

I believe COCO keypoints and panoptic are supported now: https://openvinotoolkit.github.io/datumaro/docs/formats/coco/
I will close the issue.


[mysql-connector-cpp] upgrade to 8.0.32

I did these things:

Upgrade to 8.0.32
Use all dependencies from vcpkg
Include jdbc support (Windows dynamic linkage is not supported, because it will require libmysql:windows-xx-static and link them into a big dll. I didn't find a way to achieve that in vcpkg.)

Checklist:

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Have you tested its usage after installation? I followed the usage prompt after installation:
find_package(unofficial-mysql-connector-cpp CONFIG REQUIRED)
target_link_libraries(main PRIVATE unofficial::mysql-connector-cpp::connector)

the header files in installed/x64-windows/include in my test project cannot be referenced in the project.

Have you tested its usage after installation? I followed the usage prompt after installation:
find_package(unofficial-mysql-connector-cpp CONFIG REQUIRED)
target_link_libraries(main PRIVATE unofficial::mysql-connector-cpp::connector)

the header files in installed/x64-windows/include in my test project cannot be referenced in the project.

It works for me. Could you upload your test case?

CMakeLists.txt
add_executable (testmysqlcon "testmysqlcon.cpp" "testmysqlcon.h")
find_package(unofficial-mysql-connector-cpp CONFIG REQUIRED)
target_link_libraries(testmysqlcon PRIVATE unofficial::mysql-connector-cpp::connector)
if (CMAKE_VERSION VERSION_GREATER 3.12)
  set_property(TARGET testmysqlcon PROPERTY CXX_STANDARD 20)
endif()

code:
#include "testmysqlcon.h"
#include <mysqlx/common.h>
using namespace std;

int main()
{
	cout << "Hello CMake." << endl;
	return 0;
}

error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open include file: 'mysqlx/common.h': No such file or directory	testmysqlcon	F:\testwork\testmysqlcon\testmysqlcon\testmysqlcon.cpp	5

@kotori2 Is my usage wrong? Can you tell me how you use it?

CMakeLists.txt
add_executable (testmysqlcon "testmysqlcon.cpp" "testmysqlcon.h")
find_package(unofficial-mysql-connector-cpp CONFIG REQUIRED)
target_link_libraries(testmysqlcon PRIVATE unofficial::mysql-connector-cpp::connector)
if (CMAKE_VERSION VERSION_GREATER 3.12)
  set_property(TARGET testmysqlcon PROPERTY CXX_STANDARD 20)
endif()

code:
#include "testmysqlcon.h"
#include <mysqlx/common.h>
using namespace std;

int main()
{
	cout << "Hello CMake." << endl;
	return 0;
}

error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open include file: 'mysqlx/common.h': No such file or directory	testmysqlcon	F:\testwork\testmysqlcon\testmysqlcon\testmysqlcon.cpp	5

It seems that my test case works because I included other vcpkg packages to my build, so mysql headers get included as well.
I tried the previous version with commit hash 2a6dfa3a7e2e926aacef5402b3c26f7f433052b7, it turns out it does not work as well. Gonna test if it is a regression issue.

I tracked back to the very first version 79211d3e4a8c79bc81858f1622b81d6ca6fed72e and header will not include on their on, and I have no idea how to fix it.
Should I add include_directories to mysql-connector-cpp-config.cmake.in?

You need to extend this patch to provide a public install interface:
https://github.com/microsoft/vcpkg/blob/2b1757dd1d5ed7d9d5bb65fd8316631b157e7afc/ports/mysql-connector-cpp/export-targets.patch#L9-L10
It is missing from many vcpkg patches. Example from another PR (may need adjustments):
https://github.com/microsoft/vcpkg/blob/ff80c0832cbcc2245db1bb3ce838b722d58e90d2/ports/minizip/CMakeLists.txt#L27
As an extra note, IMO the port deserves more work. For example it should really use a standard find_package(ZLIB REQUIRED) instead of custom zlib lookup code.

For example it should really use a standard find_package(ZLIB REQUIRED) instead of custom zlib lookup code.

Oh okay. I was trying to touch as fewer code as possible. Gonna try these later when I have time.

Oh okay. I was trying to touch as fewer code as possible. Gonna try these later when I have time.

Your intentions are good :+1:
But it is more maintainable to solve the cross-platform issues once in a single spot, e.g. within port zlib, than in all consuming ports. And maybe you may find a minimal change by injecting the find_package(ZLIB) early enough in the call stack. (I don't know if it is feasible here.)

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Oh, they really circumvent canonical find_package(...) calls even for zlib and openssl?
If not restoring find_package, this port will be hard to maintain and use: duplicating what we already maintain in wrappers and still not delivering imported targets which CMake can identify with canonical targets such as ZLIB::ZLIB or OpenSSL::SSL.

Oh, they really circumvent canonical find_package(...) calls even for zlib and openssl? If not restoring find_package, this port will be hard to maintain and use: duplicating what we already maintain in wrappers and still not delivering imported targets which CMake can identify with canonical targets such as ZLIB::ZLIB or OpenSSL::SSL.

@dg0yt I do tried on my end with such patch:
diff --git a/cdk/cmake/DepFindCompression.cmake b/cdk/cmake/DepFindCompression.cmake
index f9fe519f..ed256026 100644
--- a/cdk/cmake/DepFindCompression.cmake
+++ b/cdk/cmake/DepFindCompression.cmake
@@ -44,6 +44,10 @@ if(TARGET ext::z)
 endif()

 message(STATUS "Setting up compression libraries.")
+find_package(ZLIB REQUIRED)
+find_package(lz4 CONFIG REQUIRED)
+find_package(zstd REQUIRED)
+return()

 #######
 # ZLIB

But I got an weird error:
-- Setting up compression libraries.
CMake Error at C:/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
Call Stack (most recent call first):
  C:/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  C:/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindZLIB.cmake:166 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cdk/cmake/DepFindCompression.cmake:47 (find_package)
  cdk/cmake/dependency.cmake:45 (include)
  cdk/protocol/mysqlx/CMakeLists.txt:30 (find_dependency)

I am pretty sure ZLIB is required in vcpkg.json. Could you please help me out?
Also the CI seems failing randomly on Windows
========================== Starting Command Output ===========================
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "C:\a\_temp\a25dcb94-6018-49c8-a186-ac64e33887bb.cmd""
Succeeded in formatting the manifest files.
vcpkg has crashed. Please create an issue at *** containing a brief summary of what you were trying to do and the following information.

Version=2023-06-08-19a3cb921a585fce63c0651f56a991a5a08bdc60
EXCEPTION=bad allocation
CMD=
.\vcpkg.exe|
format-manifest|
--all|
##[error]Cmd.exe exited with code '1'.
Finishing: Format Manifests

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static

Usage test pass with following triplets:
x86-windows
x64-windows
x64-windows-static

I'm sorry but I think changing all package search calls from add_ext to find_package is out of my capability because the code are not only searching for library/headers, but also binaries such as protobuf. I did tried but it doesn't work.
We might need a separate PR to enhance this issue since this PR is already delayed for 2 months.
Again thanks for the help from @dg0yt :D


Add ccache support

Combined with nodemcu/nodemcu-firmware#2066, this can greatly speed up builds.

Thanks a lot. I'll wait until the dust over at nodemcu/nodemcu-firmware#2066 has settled.


Support for JDA v5's Message update

Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for
missing information.

[x] I have checked the pull request page for upcoming
or merged features/bug fixes.
[x] I have read JDA's contributing guidelines.

Pull Request Information
Check and fill in the blanks for all that apply:

[ ] My PR fixes a bug, error, or other issue with the library's codebase.
[x] My PR is for the command and menu module of the JDA-Chewtils library.
[ ] My PR creates a new module for the JDA-Chewtils library: ______.

Description
Updates Chewtils to support the latest Message changes made in JDA v5.
Methods using Message instances as vars (i.e. reply(Message)) have been updated to use MessageCreateData instances instead.
respond(File, String, AttachmentOption...) was changed to respond(File, String, String, boolean) due to AttachmentOption being removed.
The new method now uses the second String for the description (Set to null or empty for no description) and the boolean to mark as spoiler.
I'll leave this PR as a draft until the next Alpha is dropped by JDA that implements it completely, so that we have a proper version to support and not just a commit.
(I mainly made this change to use it in my bot :P)

I started on this but gave up, thanks for takin over 😄

Guess the new version requires to propagate first...

Yeah it can take an hour or so, welcome to central

Nevermind, that's not the issue 😄


Update azure-synapse-link-pipelines.md

Added Email Alerting for "Else" Condition in ADF Pipeline
Enhanced the existing ADF pipeline to provide immediate notification if the "else" condition is met, though the pipeline technically succeeds. Implemented using Azure Logic Apps, this addition ensures prompt alerts via email for better monitoring and maintaining data integrity. Integrated images and JSON configurations for comprehensive guidance.

@microsoft-github-policy-service agree


Unable to use FILE_URI as background

I realise that this plugin is no loner supported/maintained by the developer, but there is clearly an existing user base that may be able to help with issues.
I'm trying to use a FILE_URI as inputType and I'm passing the image.src as inputData, like this:
        var image = document.getElementById('my-image');
        navigator.sketch.getSketch(onSuccess, onFail, {
            destinationType: navigator.sketch.DestinationType.DATA_URL,
            encodingType: navigator.sketch.EncodingType.JPEG,
            inputType: navigator.sketch.InputType.FILE_URI,
            inputData: image.src
        });

The path to the image with id my-image is valid and the image is displayed. However, when calling getSketch I get an error: Failed to generate sketch. File not found: /android_asset/www/img/image.jpg
If it makes any difference, this is using Cordova Android platform version 7.1
Any suggestions? Thanks

@beard7, thank you for reporting this issue.
This repo is part of our legacy code base and is no longer supported/maintained by us. You are welcome to create/publish a fork to npm or do what you want with the code.
Apologies for any inconvenience.


Add a language version for British English

Is your feature request related to a problem? Please describe.
The current English version of the UI covers American English only. There is no version for British English.
Describe the solution you'd like

Add a version for British English on Lokalise
Rename current English version for the UI to -> English (US)
Add a language version for the UI for British English -> English (UK)

This affects Lokalise and the UI but not the preference/filter setting for contributions.

@sushidave I double-checked on lokalise and found out that we indeed have localized versions of some languages:

But I would like to keep-it-simple-stupid and just have one unspecific language version for now.
Are you OK with that? If not, feel free to reopen this issue here. :+1:


Sync with common.ValidateRetryPolicy

What was changed:
Synced validation code from https://github.com/temporalio/temporal/blob/v1.8.1/common/util.go#L445
Why?
A workflow using this code fails during unit test
		ctx = workflow.WithActivityOptions(ctx, workflow.ActivityOptions{
			ScheduleToStartTimeout: time.Minute,             // Timeout between activity being scheduled to starting execution
			StartToCloseTimeout:    TransmitActivityTimeout, // Timeout of the execution
			RetryPolicy: &temporal.RetryPolicy{
				MaximumAttempts: 1,
			},
		})

Checklist

Closes issue:

How was this tested:

Any docs updates needed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jlcheng Thanks for the contribution! Adding a unit test that covers the case you mentioned failed would be really useful to have as well.

@jlcheng could you add a unit test as Spencer suggested then we could approve/land this change.


100% CPU load

@dsyme it's my, relatively new (post RTW) code:
 member x.IsDisposableType =
        if isUnresolved() then false else
        let ty = generalizedTyconRef entity
        Infos.ExistsHeadTypeInEntireHierarchy cenv.g cenv.amap range0 ty cenv.g.tcref_System_IDisposable

Please, help.

@vasily-kirichenko Which PR was that?

@cartermp https://github.com/Microsoft/visualfsharp/pull/2488

Thanks!  Is this on VisualFSharp.sln?  If so, which file?
Interesting that this is happening.  For some reason the loop within a loop is just slamming the dictionary in CanImportILType.  Maybe there's a way to filter down what to look for prior to that?

@cartermp many files were opened at that time :( One thing I can think about is trying to call IsDisposableType for IDisposable itself.

Either a quadratic (or worse) algorithm or a concurrency problem accessing that dictionary?

I don't see this bug anymore.


Update Composer dependencies (2020-09-15-00-07)

Visual regression test passed!
View the visual regression test report


Fix JSON string soft wrap highlighting

Currently JSON syntax highlighting breaks for strings when soft wrap is turned on. This is issue https://github.com/atom-material/atom-material-syntax/issues/42. A commenter remarked that One Dark doesn't have this problem, so I toyed around with the One Dark theme's json.less file until I got it to match the Material Syntax colors.
I don't have much experience with CSS/less, so test it out before a merge, but it seems to work fine.
Current:

With this PR:

ท


Speedup GLMs

Description
GLMs can be optimized, especially for small number of parameters. Right now there are multiple instances of unnecessary copying of data and repeating same calculations. Also most loops can be replaced with Eigen expressions that produce vectorized (faster) binary code. There was a previous take on this problem (pull request 1038).
Further speedups using GPUs are likely possible.
Example
GLMs are faster.
Expected Output
GLMs are faster.
Current Version:
v2.19.0

Thanks for submitting.  We're trying to coax our issues into being more like technical specs.  For this issue, there needs to be a description of how the GLMs are to be sped up.  I think this issue has already been discussed, so maybe there could be a pointer to that discussion.

I have updated the issue with more details.

Thanks much for adding the details.

I have just completed GPU implementations! Speedups are quite significant:

That's really great.  Is it ready for review?  One of the GPU devs is going to have to take a look.
I take it that K = 2000 and K = 2 are the number of predictors?
I'm surprised there's any speedup for K = 2 --- is it because things other than the matrix-vector multiply are also being sped up?
Any idea why the bernoulli-logit is so much faster on GPU?  I'd have expected normal_id to speed up the most as it's the one where the matrix-vector multiply should take up most of the cycles.
Thanks for reporting CPU/GPU types.  This stuff's so hard to evaluate with all the hardware options being so important.

This is waiting for GPU caching and CPU GLM optimizations PRs to be merged. Meanwhile I will probably reorganize the code a bit resulting in another PR that will have to be merged before this one.
K is the number of attributes of each data point.
Yes, there is a separate kernel for each model that does all the computationally heavy operations.
With a large number of attributes speedups of all four models are comparable. With only a few attributes there are operations, other than matrix-vector multiply that need significant time. While the product is bound by memory transfers, other operations are compute-bound and can be sped up more by using a GPU. In normal-id model there are few other operations so the speedup is lower.

This is waiting for GPU caching

I'll look at that this weekend. Trying to get the async and paper stuff finished up as well

Closing as this was resolved with #1185, GPU GLMs are part of a new issue #1319


Pypy support

This lib could be useful to manipulate large amounts of data ; and Pypy can help speeding thing up for those use-cases, but Pypy is marked compatible only with python 3.5, and cannot be installed with the python_requires=3.6 specified in the setup.py file.
I don't think anything in the code requires 3.6 other than the async generators. Would you consider a PR lowering the python_requires to 3.5 and add a dependency on async_generator to support 3.5 ?

Thanks for the issue!
There seems to be some demand for Pypy, but I would like to understand a bit more why is that. Currently I am not super enthusiastic about supporting older Python versions or Pypy, but perhaps some discussion here can change mind.
As far as aioinflux is concerned, the most CPU-intensive part of the code is the serialization part (i.e., transforming a dictionary/dataframe to a line protocol string). I have been aware of that and have stated it in the README:

Beware that serialization is not highly optimized (cythonization PRs are welcome!) and may become a bottleneck depending on your application.

As a side note, please understand that the current pure Python line protocol serialization implementation is somewhat optimized, and according to my simple benchmarks, it is 7-8x faster than the official Python client (which is a pity and one of the many reasons I decided to write my own InfluxDB client library from scratch).
Serialization can likely be improved a bit (hopefully 2-3x) using Cython, or perhaps even more by writing a C extension from scratch (such as ciso8601).
So I would like some clarification on:

Where does the the need to to use Pypy come from? Is it related to aioinflux? Is it because you depend on Pypy for some other part of your application (which needs aioinflux as a dependency)?
If it comes from aioinflux, is it because of a serialization issue or some other part of the code?
Would faster serialization using Cython/C extensions also be a solution to your current issue? Why or why not?
How much faster do you expect the serialization code (or aioinflux as a whole) to run with Pypy?

My concerns are:

Pypy support for Python 3 seems to be quite beta, and they have always lagged behind the reference CPython implementation. Supporting Pypy will likely mean we have to be stuck on an old Python version for years to come. I don't think it to be unlikely Pypy will still be on Python 3.5 when Python 3.9 comes out in 3-4 years time.
Keeping decent unit tests/coverage for Pypy may be a big burden and being stuck in an old Python version may restrict the addition of new functionality.
If I implement a Cython/C Extension improvement (which I plan to someday) we may have to keep separate serialization implementations: 1) a pure Python serialization implementation (for Pypy use) and 2) a Cython/C extension implementation for use in CPython use. Needless to say this might not be the nicest thing to maintain.

By the way, @miracle2k has made his own fork of aionflux, which supports curio/asks and Python 3.5 (and I assume Pypy as well). It would also be nice to hear some opinions from other contributors: @steersbob, @carlos-jenkins.

Note: I have little to no practical experience with PyPy.
That said: This seems to be the primary influx + asyncio library. It may be desirable to focus on doing the core feature well, instead of supporting everything up to and including a mail client.
I may be available to write a C serializer, but that'd depend on how much effort it would be, and what the expected performance gain would be.

Thanks for you detailed response! Here are some answers to your points
I am definitely not enthusiastic about supporting old versions of Python either, and I was not suggesting supporting anything other than pypy-3.
The Python3 flavor of the pypy releases are not beta anymore though - we have been using them in quite a few production projects for some time now - and they plan on moving the compatibility version to 3.6 in 2018 [1]
From what I saw in other projects, supporting Pypy is often nothing more than toggling "on" pypy in the CI matrix, even with C-extensions.
(Concerning the C-parser/serialiser, I don't have much experience with C extensions, but I think using CFFI works very well with both CPython and Pypy)
And lastly, regarding use-case: I understand that for the aioinflux part of the code, once the C parser/serialiser has been implemented, running on Pypy will not improve the performances at all. But we are using aioinflux to connect to a large InfluxDB, with some data processing that we would like to be able to do efficiently in our Python code. Using Pypy for this processing would definitely speed thing up.
I understand that supporting old versions is definitely not an objective here, but I think processing data on the Python side is a common use-case, and supporting Pypy probably won't impact the code much here.
Finally: I think we have three options here:

I open a pull request that adds async_generator as a dependency, lowers the python_requires to 3.5 and enables the CI on pypy (hopefully that will be enough to support pypy3)
You put this "on-hold" until pypy releases a version compatible with python 3.6 some time this year, and then everything should work out of the box
Or you can of course close this issue and decide pypy is out of scope

[1] https://morepypy.blogspot.fr/2017/12/pypy27-and-pypy35-v510-dual-release.html

@arthurdarcet: I just released v0.3.0 so now perhaps is a good time for you to fork and make the necessary adaptations.
Besides async generators, aioinflux also makes heavy use of f-strings (which are 3.6+ only). They are quite useful for serialization and considerably faster than regular str.format formatting (I have no idea why, though). I have used them to speed up dataframe serialization and am now thinking of applying them back to regular mapping/dictionary parsing.
I think it'd be nice supporting Pypy, but as stated above I am a bit hesitant due to maintainability issues. From the three options you gave, I am a bit more inclined to option two, but feel free to make a fork and open a pull request (option one). We can take a look at it and try to merge it to the master branch. If you don't need Pandas support, dropping dataframe support for the Pypy version would also be an option.

f-strings are available in pypy3 since 5.8, so this won't be an issue. I'm exactly sure how we can specify in the setup file that the project requires python 3.6 or pypy3 5.8... I'll look into that.
I probably won't have time to work on this in the next few days, but I'll open a PR when a get a chance


Pass the Github token to the initialiser of RepoAudit::Report

Do the ENV.fetch in the calling bin script, rather than inside the private fetch_repo method.

As part of PR https://github.com/ministryofjustice/repo-audit/pull/29 we don't have fetch_repo method anymore and the ENV.fetch has moved to RepositoryHelper.


When entity is reparented, whole child hierarchy is notified

When a hierarchy of entities was parented to an entity, only the root node of the hierarchy was notified about this, using 'insert' or 'remove' event.
This PR changes this to notify all children of reparented hierarchy.
This allows model and render components that are part of the reparented hierarchy to correctly add or remove their MeshInstances from layers.
Fixes https://github.com/playcanvas/engine/issues/3421

Do we want this to go out with 1.46.2 or 1.47.0?

1.46.2

Yeah, but it also touches some pretty fundamental code. I'm a bit concerned it could have either performance impact or introduce some kind of behavioral change.

I agree with @willeastcott actually. This is a pretty serious change and I'd also vote for merge with next major engine release.

Regarding the performance impact, there should not be large. We build hierarchies from top to bottom .. so when an entity is added to parent, it does not have further children. So this code would mostly trigger only when a hierarchy (a character) is added to the scene .. in which case this event would trigger one time per entity and no more. And it's only handled by model and render component. I'll do some perf testing tomorrow, but I expect this should be the case.

I added timing to engine example hierarchy which builds hierarchy with 5460 entities + materials, and I cannot measure any performance difference at all - in both cases the times are in the range of 700-750ms.

That's good - my worry levels have subsided substantially.

Wouldn't we want to distinguish the root node/entity being reparented vs a descendent somehow? I can imagine an application wanting to be able to discern the two.


Reset password process

Polish up the reset password process. Resetting a password should NOT log the user in automatically, but instead redirect them to the login screen.

Addressed, here: https://github.com/stevebrush/giftdibs-api/pull/45/files#diff-bf027ff3d600e5bfe8caddb7b95ff310L207


Hiding Options inside Grid menu

Using ui-Grid v3.0.0 as of 2015-05-14
The Grid Menu I have shows the below 3 options when the menu button is pressed.
Export all Data as CSV
Export visible Data as CSV
Columns:
Is there a way to Hide what it displays so it only shows, Export all Data as CSV?
The code I currently have is
$scope.gridOptions= {
enableGridMenu; true
exporterMenuPdf: false,
exporterCsvFilename: 'export.csv',
columnDefs: $scope.columns,
};
I tried to add in exporterAllAsCsv: false but that did not take out that option.

There is an option to hide the hide/show columns.  There is not an option to remove the export visible, to achieve that you'd need to set the option that hides all exporter menu items, then manually add export all as csv as a custom menu item.

Ok thanks i will give that a try, i know i can hide individual columns but i want to hide the header that says Colums:

Setting gridMenuShowHideColumns to false worked. Though its still showing "Export Visible Data As CSV" instead of just "Export All Data As CSV".
Is there a way to hide "Export Visible Data As CSV" grid menu. Tried setting exporterMenuVisibleData to false in gridOptions but didn't work.
Thanks

@AnirudhaGohokar I believe the only option at this time is to disable the existing options and add your own:
gridOptions:{
exporterMenuCsv: false,
gridMenuCustomItems: [{
title: 'Export All Data As CSV',
order: 100,
action: function ($event){
scope.gridApi.exporter.csvExport(uiGridExporterConstants.ALL, uiGridExporterConstants.ALL);
}
}]
}

@laenas how to do the same for export to pdf option ?

Hi all, I have "Clear all filters" in the grid menu and the requirement is that when user did not add any filters in the column headers then "Clear all filters" button from grid menu should be disabled. How can I achieve this? Thank you.


Instructions on downloading images no longer works

➜  images git:(master) ✗ wget -P images/ https://copy.sh/\{linux.iso,linux4.iso,buildroot-bzimage.bin,openbsd-floppy.img,kolibri.img,windows101.img,os8.img,freedos722.img\}
--2021-05-04 17:37:27--  https://copy.sh/%7Blinux.iso,linux4.iso,buildroot-bzimage.bin,openbsd-floppy.img,kolibri.img,windows101.img,os8.img,freedos722.img%7D
Resolving copy.sh (copy.sh)... <IP_ADDRESS>, 2001:19f0:6c01:3e6:5400:3ff:fe01:c520
Connecting to copy.sh (copy.sh)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2021-05-04 17:37:28 ERROR 404: Not Found.

What's the deal with 403 Forbidden when we try to grab your images? I used to be able to grab them so I can mirror this site for testing, but now they are 403 or 404. Please let us grab all images that you use (They are easily obtained but you did all the hard work, which I greatly appreciate...so please let us benefit from the fruits of your labor).
Ok appears i missed the ` ... this worked but still of course no windows images. Can't paste it here because it converts it to code just add one before and at end of the wget command (the whole thing)

The command from the readme should work (don't put a backslash in front of the { or } characters):
wget -P images/ https://k.copy.sh/{linux.iso,linux4.iso,buildroot-bzimage.bin,openbsd-floppy.img,kolibri.img,windows101.img,os8.img,freedos722.img}

Alternatively, if you shell doesn't expand the braces correctly, you download them one by one:
wget -P images/ https://k.copy.sh/linux.iso
wget -P images/ https://k.copy.sh/linux4.iso
…

The reason I don't provide links for the larger image files, including the Windows images, is that I'm paying for the bandwidth, and it's fairly easy to create them from scratch. If you'd like to mirror them publicly or need them for testing, send me an email and I'll share them with you.


Create Spatial Index using Neural Network [Feature Request]

Consider a Skip-gram model from NLP.
Apply the same concept to pairs of points in ECEF, instead of Cosine distance use Euclidean distance.
 In this case the L2 norm between any two vectors should be approximately equal to the geodesic distance.
Use the projection as base to hash geometries and so on (similar to encoding a sentence by merging the embedding of each word).
The idea here, if possible, would be to project the surface of a manifold into a high dimensional Cartesian plane.
https://carlostgameiro.medium.com/disrupt-spatial-analysis-642eeb360493

Thanks for contributing this idea. I think exploring it outside of this repository would make the most sense at this point as I don't see it as something we would merge in H3.


allow users to use node port for istio ingress without producing another service for lb

and specify lb ip for istio gateway.
use consistent config with istio ingress gateway.

@linsun: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a580c569710d9629be0c7ef92116558eccf05115
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

But please fix the duplicated IP.

@costinm for duplicate ip, i was hoping each chart (istio-ingress and ingress gateway) will pull its own LB ip.  I'll test it.

re duplicate ip, @costin, i don't think that is an issue.  For example, i set  the following in values.yaml
ingress:
  enabled: true
  serviceAccountName: default
  autoscaleMin: 1
  autoscaleMax: 1
  resources: {}
# limits:
#  cpu: 100m
#  memory: 128Mi
# requests:
#  cpu: 100m
#  memory: 128Mi
  service:
    loadBalancerIP: "<IP_ADDRESS>"
    type: LoadBalancer #change to NodePort, ClusterIP or LoadBalancer if need be
    ports:
    - port: 80
      name: http
      nodePort: 32000
    - port: 443
      name: https
    selector:
      istio: ingress
#
# ingressgateway configuration
#
ingressgateway:
  enabled: true
  serviceAccountName: istio-ingressgateway-service-account
  autoscaleMin: 1
  autoscaleMax: 1
  resources: {}
# limits:
#  cpu: 100m
#  memory: 128Mi
# requests:
#  cpu: 100m
#  memory: 128Mi
  service:
    name: istio-ingressgateway #DNS addressible
    labels:
      istio: ingressgateway
    #namespace: istio-system
    loadBalancerIP: "<IP_ADDRESS>"

and below is the output after helm template:
# Source: istio/charts/ingress/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: istio-ingress
  namespace: istio-system
  labels:
    chart: ingress-0.8.0
    release: RELEASE-NAME
    heritage: Tiller
    istio: ingress
spec:
  loadBalancerIP: "<IP_ADDRESS>"
  type: NodePort
  selector:
    istio: ingress
  ports:
    -
      name: http
      nodePort: 32000
      port: 80
    -
      name: https
      port: 443
---

---
# Source: istio/charts/ingressgateway/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: istio-ingressgateway
  namespace: istio-system
  labels:
    chart: ingressgateway-0.8.0
    release: RELEASE-NAME
    heritage: Tiller
    istio: ingressgateway
spec:
  loadBalancerIP: "<IP_ADDRESS>"
  type: LoadBalancer
  selector:
    istio: ingressgateway

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a580c569710d9629be0c7ef92116558eccf05115
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
a580c569710d9629be0c7ef92116558eccf05115
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
f5b3bc3419cbbe66a263d9e365143925026863a5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
a580c569710d9629be0c7ef92116558eccf05115
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
f5b3bc3419cbbe66a263d9e365143925026863a5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
f5b3bc3419cbbe66a263d9e365143925026863a5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
f5b3bc3419cbbe66a263d9e365143925026863a5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
f5b3bc3419cbbe66a263d9e365143925026863a5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
f5b3bc3419cbbe66a263d9e365143925026863a5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f5b3bc3419cbbe66a263d9e365143925026863a5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
451ee8c98eb58dc33d46319620fa2cc717046d73
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Make Subscriptions Failsafe?

Subscribing incorrectly can crash the app.

More info about this would be good so people can try to fix it.

Subscribing to a non-existent portion of the state tree causes otherwise healthy apps to crash. I'm not yet very familiar with the code, but I suspect this could be remedied by surrounding the subscriptions on the client side with a try/catch.


Rules execution mode

Hi,
This is more a question than an issue, but I can't find my answer in the docs.
I am wondering wether rules are executed in a sequential mode or if there is a certain number of rules that can be executed simultaneously ?
For exemple if
a rule1 is triggered every 10s
and
a rule2 is executed every minute and actually last 20 seconds to complete.
Will my rule1 still be executed 6 times a minute ?
Thank you for your answers.

Right now, all the rules run sequentially. run_every only applies at the global level.
I've got an open pull request, https://github.com/Yelp/elastalert/pull/1298, which is still slightly a work in progress, that makes it so that each rule can be run on separate intervals. I plan on releasing this soon.


fix: metric with services LB.

What does this PR do?
Excludes non server LB from metrics.
Motivation
Fixes #5755
More

[x] Added/updated tests
[ ] Added/updated documentation

Any chance this will be merged in soon?

https://docs.traefik.io/contributing/maintainers/#pr-review-process


CPython does not support some emojis as variable name while RustPython does

Feature
on CPython 3.10:
$ python
Python 3.10.1 (main, Dec 18 2021, 23:53:45) [GCC 11.1.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 🦀 = 0
  File "<stdin>", line 1
    🦀 = 0
    ^
SyntaxError: invalid character '🦀' (U+1F980)

on RustPython 0.1.2:
$ ./rustpython
Welcome to the magnificent Rust Python 0.1.2 interpreter 😱 🖖
>>>>> 🦀 = 0
>>>>> 🦀
0

According to python doc, valid identifiers are defined as:
identifier   ::=  xid_start xid_continue*
id_start     ::=  <all characters in general categories Lu, Ll, Lt, Lm, Lo, Nl, the underscore, and characters with the Other_ID_Start property>
id_continue  ::=  <all characters in id_start, plus characters in the categories Mn, Mc, Nd, Pc and others with the Other_ID_Continue property>
xid_start    ::=  <all characters in id_start whose NFKC normalization is in "id_start xid_continue*">
xid_continue ::=  <all characters in id_continue whose NFKC normalization is in "id_continue*">

The Unicode category codes mentioned above stand for:
Lu - uppercase letters
Ll - lowercase letters
Lt - titlecase letters
Lm - modifier letters
Lo - other letters
Nl - letter numbers
Mn - nonspacing marks
Mc - spacing combining marks
Nd - decimal numbers
Pc - connector punctuations
Other_ID_Start - explicit list of characters in PropList.txt to support backwards compatibility
Other_ID_Continue - likewise

While Ferris-chan 🦀 (U+1F980) is not included above, it should probably not be considered a valid variable name?
Python Documentation
Lexical Analysis: Identifiers

Is this a bug in RustPython… or a deficiency in CPython? 🤔

This is really strange, we do use xid_start/continue for this, and unic_ucd_ident::is_xid_start('\u{1f980}') does return false, I'm not sure why this would be happening.

Ah, looks like it was actually on purpose: ca11e7dea7
Honestly not sure about this, while IMO there's nothing wrong with supporting single-emoji identifiers even if cpython doesn't, this does bring in a unic crate that isn't strictly necessary, which can bloat things.

This was more of a gimmick in the old days, a sort of easter egg, but if it reduces bloat it can be removed. I'm not emotionally attached to the thing 😄 .


Whether <IP_ADDRESS> should be in the SFB online & Teams IP range

Hi team, could you please help to verify if <IP_ADDRESS> is within the range of SFB online and Teams?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077406d8-bff1-496e-3ea2-b38558fd9355
Version Independent ID: 57db3dec-2250-2dee-fd1a-ec6656911798
Content: Office 365 URLs and IP address ranges
Content Source: Enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@Kurosawa-Dia This IP address could be for a Default category URL, in which case we do not list all of the corresponding IP addresses. Please see https://techcommunity.microsoft.com/t5/office-365-networking/why-are-some-office-365-network-endpoints-provided-as-urls-only/m-p/310490#M97 for more information. Thanks for your question.


Test library via TravisCI

I've seen that there is a PR (#12) by @gianarb on integrating a CircleCI config.
I'd like to propose integrating TravisCI since they are able to run docker inside the VM the test runs in.
Also, most open-source projects currently use Travis.
What CI would you rather like to support?

Just one is fine, I picked circleci because I think it is what the other projects like the java implementation uses. But I don't have a blocking one :) The best we can get in place is good

I think we can keep trying to make circleci to work @mraerino I don't think we need travis for now


Sync doesn't work on production server

Hello, I've got the following problem:
I use Faye configuration. Sync works properly in development and production modes on my local machine, but it doesn't work on production server. Though Faye on production server is up and running.
I run Faye with bundle exec thin -p 9292 -e production -R sync.ru start

I, too, am having trouble getting Sync to work on staging (and production) server.
My stack is:

Rails app accessible at https://staging.domain.com
Nginx reverse proxy enforcing SSL
init.d script running Sync on boot via bundle exec rackup sync.ru -E production

Frankly, I am confused by the -E production requirement even in development and am not sure what configuration (if any) is loaded from config/sync.yml and what it should look like for production environment using my stack.

same here: local OK, remote Not working.
Same stack as @Epigene but without enforcing SSL
Here is my Procfile
web:      bundle exec unicorn -c ./config/unicorn.rb
worker:   bundle exec sidekiq -c 5 -e production
sync:     bundle exec rackup sync.ru -E production -p 9292
redis:    redis-server --maxclients 3984

And I'm also confused by the different environments and why to run what?!
What I discovered so far:

Websocket connection seems to be OKish
Sync events are pushed to the browser
Website doesn't change
no error in js-console

I found my mistake in config/sync.yml.
Change this
production:
   server: "/faye"

to this
production:
   server: "http://localhost:9292/faye"

I'm opening #194 in order to improve the quality of our documentation.

Have struggled a bit to get it work on staging/production.
You need to start the server with below command
RAILS_ENV=production bundle exec rackup sync.ru -E production


Inform a user that a click was made on a wrong element

When testcafe clicks an element which is overlapped by the second element, it waits for the first element to appear. If the first element do not appear during selector timeout period, then it clicks the second element.
It would be nice to inform users that a click is made on a wrong element.
<!DOCTYPE html>

    <meta charset="UTF-8">
    <title></title>

fixture `fixture`
    .page `../pages/index.html`;

test(`test`, async t => {
    await t
        .click('#child1');
});

https://github.com/DevExpress/testcafe/issues/2861
Sometimes we cannot click on element inside a shadow root. See #2861 tests

Can this be re-opened? I believe it still happens (we're seeing it occur on some of our tests while running against BrowserStack's iPhone 8.

This is also an issue for us when we have a dynamic notification box display on top of elements we need to click. Instead of failing the test, TestCafe continues to find the element and try to interact with it again and again creating an infinite loop.


Environmentvariables

Changes related to the efforts to save the Demo Test Account integration information in a env variables encrypted in the AppVeyor CI

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test fail.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test pass.

AppVeyor build and test fail.

AppVeyor build and test pass.


Update responses to behave like a hash

Following on from the gds-api-adapters upgrade to 47.2, OpenStruct responses
are now longer supported and must now be hashes.

Thank you!


Renderer parameters for color reconstruction

Hi, Thanks for open-sourcing this awesome project. For the image reconstruction part, may I ask what parameters you use in the renderer? (gamma_val, aggr_func_rgb etc.). Also, would you please shed some light on why we need to aggregate all faces when computing color? Cause it seems only the face with the smallest z matters to color.

Hi,
I just uploaded shape recon code. Please check in the code!
When compute gradient from color to texture, I would agree that only the front triangle matters. However, when computing gradient to vertices, the color from other triangles also matters so that the vertices would know where they should "move" to match the ground truth images.

Thanks!

Hi @sunshineatnoon, were you able to reproduce the color reconstruction experiment?


Upscaling for Kavita returns 200 but doesn't load the image.

[0 llvmpipe (LLVM 15.0.6, 128 bits)]  queueC=0[1]  queueG=0[1]  queueT=0[1]
[0 llvmpipe (LLVM 15.0.6, 128 bits)]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 llvmpipe (LLVM 15.0.6, 128 bits)]  fp16-p/s/a=1/1/0  int8-p/s/a=1/1/1
[0 llvmpipe (LLVM 15.0.6, 128 bits)]  subgroup=4  basic=1  vote=1  ballot=1  shuffle=1
[2024-03-28T22:03:10Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
[2024-03-28T22:03:10Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
[2024-03-28T22:03:10Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
[2024-03-28T22:03:10Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
LLVM ERROR: Cannot select: 0x7f51842316c0: i16,ch = X86ISD::FILD<(load (s16) from %stack.8)> 0x7f51841e9180, FrameIndex:i64<8>
  0x7f51841e9048: i64 = FrameIndex<8>
In function: cs_co_variant
[2024-03-28T22:03:10Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
[0 llvmpipe (LLVM 15.0.6, 128 bits)]  queueC=0[1]  queueG=0[1]  queueT=0[1]
[0 llvmpipe (LLVM 15.0.6, 128 bits)]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 llvmpipe (LLVM 15.0.6, 128 bits)]  fp16-p/s/a=1/1/0  int8-p/s/a=1/1/1
[0 llvmpipe (LLVM 15.0.6, 128 bits)]  subgroup=4  basic=1  vote=1  ballot=1  shuffle=1
[2024-03-28T22:03:14Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
[2024-03-28T22:03:14Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
LLVM ERROR: Cannot select: 0x7f6084230b80: i16,ch = X86ISD::FILD<(load (s16) from %stack.8)> 0x7f6084221950, FrameIndex:i64<8>
  0x7f6084221818: i64 = FrameIndex<8>
In function: cs_co_variant

Shows the response as okay but I suspect something with the image API has changed and it's causing images not to load at all.

Not sure when this broke, but in Kavita, images need the apiKey to be passed to load the image.

For me it's work without the api api key but this error it's not normal :
LLVM ERROR: Cannot select: 0x7f6084230b80: i16,ch = X86ISD::FILD<(load (s16) from %stack.8)> 0x7f6084221950, FrameIndex:i64<8>
0x7f6084221818: i64 = FrameIndex<8>
At the end you have this message :
[2024-08-23T20:15:07Z INFO  kurp::handlers::upscale] GET /api/reader/image: upstream response: 200 OK
[2024-08-23T20:15:10Z INFO  kurp::handlers::upscale] GET /api/reader/image finished upscaling


Added DetailCardGrid Component for the Second Theme

Signed-off-by: Abhijay Jain<EMAIL_ADDRESS>Description
Added DetailCardGrid Component for the Second Theme
Resolves #271
Screenshots (In case of UI changes):

Desktop  View

Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests have passed and it does not give any unexpected error for the same.

cc: @charithccmc @dinithminura


pythonPackages.mypy: 0.812 -> 0.910

Project description
pythonPackages.mypy: 0.812 -> 0.910
There's a dependency that is depending on this newest version.
I failed to upgrade mypy on my own.
Metadata

Nix package: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/mypy/default.nix
homepage URL: http://www.mypy-lang.org
source URL: https://github.com/python/mypy
license: mit

@superherointj Why was this closed? There doesn't seem to be a patch yet, right?


feat(pixels): add my new pixel (12, 12)

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

The errors presented by CI are due to running npm test, and moving around some other users entries, as they were unordered.


Added partial match search function

Uses nonrel-search, which is normally an AND search, to perform separate queries for each keyword and combine the results. The function supports returning these OR results first sorted by the most matching keywords (as close to AND as possible) and secondarily sorted by an arbitrary field.

Hi gregbayer, thank you for your patch for nonrel-search.
The official repo for nonrel-search is now at https://github.com/django-nonrel/nonrel-search. Could you please fire up another pull request at the official repo so that all django-nonrel developers could see your pull request?

Sure thing. Will do.

Thank you. So I'll close this pull request here.


Things to work on at the QPL2023 hackathon

Small things:

[x] Change colours for selection?
[x] Support panning (this is actually easier than you think). [Agustín]
[x] Magic wand UI improvements (#40). [Tuomas]
[x] More and sexier animations (see also #46).
[x] Make positioning of spiders after drag bialgebra action better (see #41).
[x] When in selection mode, let shift-clicking add things to selection (see #23). [Tiffany]
[x] In Proof mode, do colour change by double clicking? [Julien]
[x] Better phase inputs when double-clicking in edit mode (support expressions like 'pi/2' or even 'alpha'). [Razin]
[x] Make ZXLive more mypy compliant. [Boldi]
[x] When new vertices are added by a rewrite, make sure these vertices are selected. [Agustín]

Medium things:

[x] Make magic wand smarter by detecting which edges exactly you want to unfuse. [Tuomas]
[x] Magic wand: drag across edge to add identity.
[x] #50
[x] Allow printing of matrix representing the diagram and checking changes. [Richie]
[x] Add toolbar in Proof mode for bringing to several normal forms.
[ ] Sound effects?
[x] Implement H-boxes (easier than you think, just use PyZX things).
[x] #135
[x] Make ZXLive Python 3.9 compatible. [Richie]

Big things:

[x] Start derivation panel tracking all your proof steps. [Aleks/Mark]
[x] #63
[ ] #101

Closing this as it is mostly implemented and has served its purpose.


Implement picosat_set_interrupt

Allow users to set custom interrupt functions as well as providing default time and signal-based (e.g., Ctrl+C) ones.
picosat.h doesn't say it, but the interrupt function should return non-zero when it's time for picosat_sat to give up and zero if it can keep going. The external_state should be a pointer to some Go object that the Go interrupt function can read for information about what it's supposed to do. May need some C type casting to allow this.

Is there any way to use the Context type. Perhaps we pass a Context object to a new method SolveWithTimeout or just to Solve (but would require a major version bump since Solve's signature would change; the context package says Context objects should always be passed to every function that uses one rather than stored in a struct).

A user could not use picosat_set_interrupt more than once concurrently. We'll have to be careful to serialize access to it. Otherwise a timer going off (for example) for one Solve call would end all Solve calls. This may automatically be taken care of by way of Solve's use of a write lock.


Orbit not visible on load when Interchange used for images

I've just updated to Foundation 5.1.
My site has an Orbit slider which uses Interchange to deliver two different sets of images (smaller ones for mobile).
A snippet of my HTML:

When the page first loads, Orbit isn't visible. If I readjust the browser window, it appears and begins functioning as expected.
Is anyone else experiencing this? It was working perfectly prior to updating.

Hi,
I had the same issue recently, so after many tests this worked for me :

Added all sliders format in assets/partials ex: slide.html, large-slider.html etc..
Added the interchange plugin and a new data-orbit-interchange attribute
Watch for 'replaced-zf-interchange' event on [data-orbit-interchange]
Get an image from the slide freshly loaded and wait for image loading
Then init the plugins agains

a quick exemple :
html :

javascript :
$('[data-orbit-interchange]').on('replaced.zf.interchange', function () {

        var element = $(this).find('.orbit').first();

        var img = $(element).find('.orbit-image').first();

        img.on('load', function() {

            element.foundation();

        });

 });

this is not the best solution i guess , but it worked for me,
Hope this can help


Monitor instance refresh status as part of deployment process

Add the ability to monitor instance refresh progress as part of a deployment.
When switched on Capistrano won't complete until the autoscaling group instance refresh has completed.
Running cap $env rolling:instance_refresh_status directly will monitor the status of the most recent instance refresh.

Not really, I wanted to test the latest changes but I haven't found time yet. I'll plan it for next week :)
But the code changes look good. Only thing is terminating the instance, I was thinking of moving the rescue to Instance#terminate. Then it is also rescued from the code that runs in the at_exit hook. But then I'm not sure how we would log the error...

Thanks for the update :+1:

I've made a few small changes and will make a new release in the next days.


[SdkUnitTests]java.util.Base 64 since java 1.8

Hi,
I cannot compile project with JDK 1.7 becasue the project is instacing a java JRE class called Base64 which is new in JRE 1.8
Is it mandatory to compile and work with this library under JRE 1.8?

Its not mandatory, its just to show how to encode the document contents to Base64 before sending it to DocuSign API. Here is some example that might work for you:
import java.io.DataInputStream;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.File;
import java.util.ArrayList;
import java.util.List;
….
try {
// read file from a local directory
FileInputStream fis = new FileInputStream(file);
DataInputStream dis = new DataInputStream(new FileInputStream(file));
try {
fileBytes = new byte[(int) file.length()];
dis.readFully(fileBytes);
} finally {
dis.close();
fis.close();
}
} catch (IOException ioExcp) {
// handle error
System.out.println("Exception: " + ioExcp);
return;
}
…
String base64Doc = Base64.encodeToString(fileBytes, true);
doc.setDocumentBase64(base64Doc);
doc.setName(file.getName());

Thank you for your quickly reponse. I'm removing the class and testing your source.


LibCore: Port MappedFile to Windows

Marked this as draft because it looks like we better off using mman vcpkg package after all, as suggested by @zacuke. Core::System::mmap cannot be used in AK/BumpAllocator.h because AK should not depend on LibCore. There is a slight caveat that mmap from mman does not support MAP_PRIVATE, but this is not a problem in our case.

If we can't create MAP_PRIVATE | MAP_ANONYMOUS mappings, then an mman wrapper package doesn't seem particularly useful. Unless I'm missing something, we would want to use VirtualAlloc for BumpAllocator. In the ladybird codebase, BumpAllocator is only used by LibRegex. The only other place we use MAP_ANONYMOUS is in the LibGC heap allocator.
It's definitely true that nobody in Ladybird is using a read-write Core::MappedFile, so a read-only mapping for those use cases is just fine.

MAP_ANONYMOUS is not a problem either because:
    // Anonymous mapping returned by this function is effectively always private because
    // the only way to share it is via the handle, which is immediately closed after MapViewOfFile.
    // Hence:
    // * shared anonymous is not supported
    // * private anonymous does not need to use copy-on-write


Remove PrivateNoUnderscore and PublicHasUnderscore from ValidVariableName

Also fixes message error.
Fixes #502

Looks good to me :+1:


Hello there!

Hi, I'm the creator of Staticman. I just came across your project and I loved the idea. Are you still using and maintaining it? Would be great to have a chat and understand if we could incorporate this into the main project, to make it easy for people to deploy Staticman as a Netlify function.
Thanks!

Hi @eduardoboucas
Yes, I am actively using it on my blog and since I have very little traffic, I haven't encountered many bugs with it. It is staticman at the core after all 😄
I am definitely open to chatting more about it. Do you want to continue discussing on github or how else can I reach you?


make sure a dump contains IF NOT EXISTS in every create table statement before sourcing it

or find another way to prevent 'table already exists' errors

Adding DROP TABLE is of course not the same as adding IF NOT EXISTS, but it fixes the same error when importing the database.


sdcard: solve backup bug when sd is re-inserted

This issue was existent for a long time. While using the BitBox02, when the sdcard is plugged into the device and the user unplugs and replugs it, backup operations (e.g., list backups, restore from backup) failed and throwed error from the firmware side.
Sdcard backup operations first check if the sdcard is inserted before calling sdcard interface funtions. This commit fixes the re-insertion problem by reinitializing the sdcard whenever it is checked if it is inserted.
The problem earlier most probably stems from sdcard being in an unexpected state when it is re-inserted. The forced initialization step fixes the broken states.

Also, I don't understand why CI fails (I haven't touched anything related to the error).
And can you please check if the commit successfully addresses problem by trying out these steps:
- Have microSD inserted
- Plug in BitBox02
- Click on choose "recover from microSD"
- Go back to main menu (just hit "Enter")
- Take out MicroSD
- Plug MicroSD back in
- Click on "recover from microSD"

Also, I don't understand why CI fails

It's because our clang-tidy check runs only on the files that are in the diff, which in this case is sdcard.c. Please try to figure out the error/fix. Could just be casting to (void*) on first glance.

I took an even closer look at this today. We are a bit sloppy with the return value of f_mount. So we missed that it returns an error message after reinserting the sd card. Since @asi345 pointed out that re-initializing the driver fixes the issue, I found another way to also solve the issue:
diff --git a/src/sd.c b/src/sd.c
index 9ad53f47..836962df 100644
--- a/src/sd.c
+++ b/src/sd.c
@@ -18,6 +18,7 @@
 #include <string.h>

 #ifndef TESTING
+#include "sd_mmc/sd_mmc_start.h"
 #include "driver_init.h"
 #include "sd_mmc.h"
 #endif
@@ -107,7 +108,12 @@ static bool _mount(void)
     sd_mmc_resume_clock();
 #endif
     memset(&fs, 0, sizeof(FATFS));
-    if (f_mount(&fs, "SD", 1) == FR_INVALID_DRIVE) {
+    int res = f_mount(&fs, "", 1);
+    if (res == FR_DISK_ERR) {
+        sd_mmc_start();
+        res = f_mount(&fs, "", 1);
+    }
+    if (res == FR_INVALID_DRIVE) {
 #ifndef TESTING
         sd_mmc_pause_clock();
 #endif
@@ -121,7 +127,8 @@ static bool _mount(void)
  */
 static void _unmount(void)
 {
-    f_mount(NULL, "SD", 1);
+    f_unmount("");
+
 #ifndef TESTING
     sd_mmc_pause_clock();
 #endif

Our unmount function is also incorrectly implemented. There is a helper macro that gets it right. I suggest we change to that.
I see now that I also removed SD from the argument to mount/umount. Empty string should mount the "default" volume. We anyway set FF_STR_VOLUME_ID to 0, so we don't have support for string volume names. I guess the correct "logical drive number" in our case is "0".

okay, I'm implementing this version that you suggested, and removing the extra rust-c function calls that I have added.

okay, I'm updating the code according to these reviews, but I am not sure whether I can reopen this pr.
at the worst case I'll open a new pr.

okay, I'm updating the code according to these reviews, but I am not sure whether I can reopen this pr. at the worst case I'll open a new pr.

Just make a new branch and a new PR with the fixes!

Please check : https://github.com/BitBoxSwiss/bitbox02-firmware/pull/1320 for these fixes


cursor() and getregion() don't handle v:maxcol well

Problem:  cursor() and getregion() don't handle v:maxcol well.
Solution: Add special handling for v:maxcol like setpos() does.

thanks!