Led Off support for ZigStar LAN Coordinator

Could you please support disabling leds for ZigStar LAN Coordinator?
If i disable it in Z2M it won't start up telling me adapter does not support led control

Should that maybe also be reported to https://github.com/xyzroe/ZigStarGW-FW and https://github.com/xyzroe/ZigStarGW-FW ?

You just need to change Zigbee firmware to a version that supports control LEDs from z2m.
For example the last one from Koenkk

Ok, thanks a lot.


weave expose prior to scope launch

Seems to work. Whether or not it's a good idea... maybe we want to put it on a switch? scope launch --no-expose?

@tomwilkie Give me a +1 and I'll update the DNS stuff in this PR as well.

Yes please!

@tomwilkie PTAL?


Change StatelessSession to Session

"... do operations cascade to associated instances. Collections are ignored by a stateless session..."
https://docs.jboss.org/hibernate/orm/3.5/api/org/hibernate/StatelessSession.html

http://docs.spring.io/spring/docs/current/spring-framework-reference/html/transaction.html


Dnd Indicator Mode? Can do it?

example: https://master--5fc05e08a4a65d0021ae0bf2.chromatic.com/?path=/story/examples-pages-layout--horizontal

Of course, it is recommended that you handle it in the hover event of the drop element

Can you give a demo when you have time? Also can add it to vue3-dnd docs

I added a simple example
https://hcg1023.github.io/vue3-dnd/example/sortable/indicator.html


[WIP]Wikidata edit fix

Title (required)
Fixes #1601

Only one line fix, it will be easier if you do. So I don't create another PR. Then wikidata uploads are linked.

Currently if you upload from map, wikidata uploads are successful.
But if you upload from list, it doesn't. Because a line was missing:
In PlaceRenderer.java class, add this line just below line 130 "editor.putString(WIKIDATA_ENTITY_ID_PREF, place.getWikiDataEntityId());" then is will look like:
   private void storeSharedPrefs() {       SharedPreferences.Editor editor = directPrefs.edit();       Timber.d("directPrefs stored");       editor.putString("Title", place.getName());       editor.putString("Desc", place.getLongDescription());       editor.putString("Category", place.getCategory());       editor.putString(WIKIDATA_ENTITY_ID_PREF, place.getWikiDataEntityId());       editor.apply();   }

@neslihanturan Thanks for the tip. :)
I have added the line that you mentioned. @misaochan Can you help in testing this PR.

Codecov Report

Merging #1800 into 2.8-release will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##           2.8-release   #1800      +/-   ##
==============================================
- Coverage         3.66%   3.65%   -0.01%
==============================================
  Files              188     188
  Lines             9478    9483       +5
  Branches           839     839
==============================================
  Hits               347     347
- Misses            9107    9112       +5
  Partials            24      24

Impacted Files
Coverage Δ

...fr/free/nrw/commons/nearby/NearbyListFragment.java
0% <0%> (ø)
:arrow_up:

...a/fr/free/nrw/commons/upload/UploadController.java
0% <0%> (ø)
:arrow_up:

.../fr/free/nrw/commons/nearby/NearbyMapFragment.java
0% <0%> (ø)
:arrow_up:

...java/fr/free/nrw/commons/nearby/PlaceRenderer.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143ad00...4abb4cc. Read the comment docs.

Tested with one image, it works :-)

I cna confirm that uploads from Nearby (both map and list) are both working.

I have successfully added https://www.wikidata.org/wiki/Q19871703 via Nearby Map, and https://www.wikidata.org/wiki/Q2137835 via Nearby List. :)
Great job @maskaravivek and @neslihanturan !


The CIS <IP_ADDRESS> check is not working

Describe the Issue
The auditd rule for "<IP_ADDRESS> | Ensure actions as another user are always logged | Config" is applied but the check shows it as failed.
Expected Behavior
Show as passed.
Actual Behavior
Shows as failed.
Control(s) Affected
CIS <IP_ADDRESS>
Environment (please complete the following information):

branch being used: devel
Ansible Version: 2.16.7
Host Python Version: 3.12.3
Ansible Server Python Version: 3.10.12

Additional Notes
The key of the auditd rule was changed from "actions" to "user_emulation" in https://github.com/ansible-lockdown/UBUNTU22-CIS/blob/devel/templates/audit/99_auditd.rules.j2 and with commit https://github.com/ansible-lockdown/UBUNTU22-CIS-Audit/commit/f14547455befe3a6b6db3f2df91aec456a4b9816 the key was adapted in the expected output.
The key was not updated in the grep commands to get the corresponding rules grep actions /etc/audit/rules.d/*.rules and auditctl -l | grep actions.
Possible Solution
Update the key used in the grep command and probably also an adjustment of the expected output is needed

hi @wh-zfy
Thank you for this a great catch, i've raised the PR for this issue already, to be merged.
thanks
uk-bolly

Hi, I did try the PR and it now finds the rules but the output still does not match with what gets set by Ansible Lockdown UBUNTU22-CIS.
I did also look at UBUNTU22-CIS devel and main as also UBUNTU22-CIS-Audit devel and benchmark-v1.0.0 and didn't notice any differences in the relevant files, so this should affect all versions.
The Ansible role sets:
-a always,exit -F arch=b64 -C euid!=uid -F auid!=unset -S execve -k user_emulation
-a always,exit -F arch=b32 -C euid!=uid -F auid!=unset -S execve -k user_emulation

When I run grep user_emulation /etc/audit/rules.d/*.rules on a system that had the Ansible role applied the output is:
/etc/audit/rules.d/99_auditd.rules:-a always,exit -F arch=b64 -C euid!=uid -F auid!=unset -S execve -k user_emulation
/etc/audit/rules.d/99_auditd.rules:-a always,exit -F arch=b32 -C euid!=uid -F auid!=unset -S execve -k user_emulation

The output is then matched against:
    stdout:
    - '/-a always,exit -F arch=b64 -C euid!=uid -F euid=0 -F auid>=1000 -F auid!=(unset|4294967295|-1) -S execve -k user_emulation/'
    - '/-a always,exit -F arch=b32 -C euid!=uid -F euid=0 -F auid>=1000 -F auid!=(unset|4294967295|-1) -S execve -k user_emulation/'

The grep output is exactly what is given in the CIS benchmark as output, but it isn't matched by the check. As I understand, it should also literally match this text.
The check for the loaded rules would then also need an update.

hi @wh-zfy
Thats my fault mean to raise as draft to complete today, as i spotted a couple of other things to address too.
The approvers are in contact with each other, so this was held back. The readme has also been updated to explain how the branches work.
It will be merged to devel hopefully today and the benchmark branch also updated
thanks again
uk-bolly

hi @wh-zfy
These fixed have now been merged into both the benchmark branch and the devel branch.
I will close this issue. Please feel free to open if this is not working as expected.
many thanks
uk-bolly


Add method to bypass domain filters for subreddit

Some subreddits who have opted into our content, like r/futurology, need us to be able to accept all content. Right now, everything needs to go through the content filters.
Review and work on a method for bypassing the domain filters on a sub-by-sub basis.

Fixed by #53


chore(main): release ctrl-q 4.3.0

:robot: I have created a release beep boop
4.3.0 (2024-11-26)
Features

qseow: Add --new-app-delete option to qseow field-scramble command (996df4f)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

ctrl-q-v4.3.0
:sunflower:


update the test cases to not remove all roleassignments

This PR updates the test cases to not remove all the Roleassignments and fixes few other issues in the test code

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

@azuresdkci add to whitelist

@darshanhs90 this PR will not be accepted in it's current state.
Please use the TestFramework to inject your access tokens.

@shahabhijeet any more changes needs to be done as part of this PR?

@cormacpayne this PR is waiting to be reviewed,are there any changes required before it needs a review?


Allow installing ripsecrets via homebrew

I'm not sure exactly what's entailed by this, but I don't think it would be too difficult

Here is the cookbook:
https://docs.brew.sh/Formula-Cookbook

This will probably qualify for Homebrew core inclusion by the end of May. I'll take it on by then, you could assign this to me.

@colindean thanks Colin! I saw that authors aren't supposed to submit their own project so I'd appreciate it :-)

ripsecrets is now in Homebrew: https://github.com/Homebrew/homebrew-core/blob/master/Formula/ripsecrets.rb

https://formulae.brew.sh/formula/ripsecrets

Thanks @colindean, I really appreciate it!


areweguiyet https cert errors

I'm not sure who best to report this to, so filing as an issue here. Feel free to route and close.
If I open https://areweguiyet.com/ I get a cert error, saying it's a *.github.com cert (and also including *.github.io). This is probably a very simple misconfiguration.
The http still works, but I always try to prefer https.

Thanks for opening the ticked! I'll have a look.

@pythoneer hey I looked into this last night and it looks like our DNS A record for the website is set to <IP_ADDRESS>, and for https to work GitHub requires people to use one of
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

https://help.github.com/en/articles/troubleshooting-custom-domains#https-errors
(and then we can even enforce https on Github pages apparently! 😉 )

@shivshank  I'll change that as soon as i am at home. Have the ip's changed? I am just wondering – in my memory this has worked in the past.

should be fixed now.


Azure Device Twin and RBAC docs

Signed-off-by: Eystein Måløy Stenberg<EMAIL_ADDRESS>Note that the RBAC docs does not seem to be quite correct, at least not yet (https://tracker.mender.io/browse/MEN-5386).

Remember this needs a cherry to 3.2.x

May need to change "Manage" to "Deploy" in the last sentence, depending on https://tracker.mender.io/browse/MEN-5386.

May need to change "Manage" to "Deploy" in the last sentence, depending on https://tracker.mender.io/browse/MEN-5386.

5386 is in now

Our CI system has something against me personally I think... Now...?

3.2.x cherry pick: 08cab03476449af237608be4e1da060bd0e56a0f
hosted does not seem to have been rebased for 3.2 yet, skipped.


⚠ ClamAV has degraded performance

In a362b49, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 563 ms

Resolved: ClamAV performance has improved in 5a04e71.


Open access for numba ACM proceedings?

Currently http://numba.pydata.org/numba-doc/latest/user/faq.html?highlight=acm#how-do-i-reference-cite-acknowledge-numba-in-other-work links to http://dl.acm.org/citation.cfm?id=2833162&dl=ACM&coll=DL
That's behind a paywall - many researchers will not be able to access it, or not want to make an account there and pay for it. So this is non-ideal.
Could you please check if there is a way for you to post a copy of the PDF publicly, e.g. on http://numba.pydata.org or on a preprint server?
If it's forbidden by ACM, you could consider writing something new in the future in an open-access journal?

I've moved the Git repo for the paper to a public location here:
https://github.com/numba/Numba-SC15-Paper
Our draft PDF (effectively a preprint) is in the repo, which should have the same contents as the final ACM publication.
We'll update the docs to point people at that location in addition to the ACM link.  Thanks for bringing this up!

https://github.com/numba/numba/pull/3990 <-- will be fixed by this.


Segmentation model

Mege segmentation model with main

Squashed pull request to merge segmentation-model with main.
TODO's are placed at the locations within the files that need action.


Error:KEY_TF_BAD_EXIT_CODE when updating the project

Please find logs attached.
idea.zip

Hi @julia-vaseva,
Your workspace can't be identified by the plugin. I'm trying to figure out why. Did you create the workspace with the Jetbrains TFS plugin or the our TFVC? Is is a server workspace?
Also we should be giving a better error message as to what's happening so I'll add that to our backlog.
Thanks,
-Leah

Hi @leantk,
This is a log file send by our user. Unfortunately, I haven't got any steps to reproduce the issue. It is definitely your TFVC plugin, and, as far as I understand, the user tries to use a workspace created via Visual Studio: "I am trying to open a solution which is already bound using Visual Studio."
Sorry for such a poor description, hope that it'll help to localize the problem anyway.

Currently workspaces created in Visual Studio cannot be identified with the command line tool that is used by the plugin. That is why the user is seeing that error. The user would have to clone the repository using our plugin or the command line tool in order to use the other plugin features.
Like I said, I will make a fix to show a proper error message but as for making Visual Studio workspaces compatible with our plugin, that's a very large change that we aren't able to get to at the moment. There is a backlog item for it though.

@leantk Thanks for clarifying and for showing a workaround! I believe that an error message is always a good idea. Shouldn't we mention in docs, that VS workspaces won't work with this plugin out-of-the-box?

Yes I should have that in the docs for sure. Thanks for pointing that out. I'll add the error message and updates to the doc and then let you know when that's complete.

I've updated the error messaging in commit https://github.com/Microsoft/vso-intellij/commit/0c66406c641b9b912da268f3587d0fdf5c5b5dd9 to be more informative and I've also updated the website with the information on how to recognize Visual Studio workspaces. I'll close this as fixed but please reopen if you see more issues.


Pretrained backbones for resnet_ws_mrrp and resnet_ws_v2

Hi @shenyunhang!
The OneDrive link published in README: https://1drv.ms/f/s!Am1oWgo9554dgRQ8RE1SRGvK7HW2 has only pretrained resnet_ws models
Are resnet_ws_mrrp / resnet_ws_v2 models available somewhere? The resnet_ws_mrrp backbone seems the best-performing in the paper.
Btw, is resnet_ws or resnet_ws_v2 better performing? (and what is the meaning of difference in pooling?)
Thanks!

Both resnet_ws_mrrp and resnet_ws_v2 use the same weights as resnet_ws.
The differences are some model structures.


Test over 4k bytes of output (to reproduce #537 #538

This is a test case for #537 / #538 for all targets, so we do not end up in any regression.

turns out the xen unikernels aren't tested by the debian 10 system (ok 12 output xen # skip xl not available), I'm wondering what the CI setup is, is this done on a physical machine with xen?

turns out the xen unikernels aren't tested by the debian 10 system (ok 12 output xen # skip xl not available), I'm wondering what the CI setup is, is this done on a physical machine with xen?

We probably missed an image of Debian with Xen indeed but I'm not a user of Xen at all 😕. I will make an issue to keep track about that. If someone has the time to explain how to install/use Xen on Debian 11, it will be super useful for me to create a new image (or update the current one).

I will merge the test as is and I made an issue for the CI. Thanks!


don't leak goroutines when pings complete

@Kubuxu wanna CR for me?

LGTM, this change will solve the currently reported issue but rest will prevent hangs in general. Nice.

This LGTM as an adhoc fix, but longer term we should aim for making this independent of time, e.g. by allowing one ping per peer, and aborting earlier pings when a new ping comes in.


Launchbuddy Login Problems

A long time ago, Launchbuddy worked, and it worked well.
I then had to reformat my PC and put some of my old AppData back, including my Launchbuddy data.
I found that after that, and deleting all data, it never worked again.
Basically, it allows me to make my login files but then doesn't save them properly I guess? If I click one, it loads the last one I logged in on, no matter what.
So I have accounts for 1-10. I just set them all up with the newest GW2Launchbuddy.
After finishing 10, I tried 1, and it launches 10. Try 2? it launches 10.
I can recreate login on 1 and have it be number 1 again, but then only 1 launches once again.
What do I do?
Windows 10 21H1 Pro
Ryzen 7 3700x (if processor type matters for the code, I don't think it does...?)
Launchbuddy Version: Gw2 Launchbuddy V3.0.1 Hotfix

Uh, something you did in the last two versions fixed it! I have all my accounts set up and they're all working with individual .dat files that aren't corrupt (they were different sizes than the new ones were)


Giving Apex Violation Error When Run SF SCANNER DFA Run Even Apply with Security Keywords In Queries

When I Scan My VS Code Local Code with Salesforce Code Analyzer using the Below Command
sf scanner run dfa --format=csv --outfile=CodeAnalyzerDFA.csv --target="./" --projectdir="./" --category="Security"
I Got   Salesforce Graph Engine couldn't resolve the parameter passed to [READ] operation with field(s) [Unknown]. Could you confirm that this operation has the necessary FLS checks? Error On Queries Method,
But In Checkmarks Reports it is not showing any error.
I am Scanning this Report For a salesforce Security Check for App Exchange.
My Queries Method:
@AuraEnabled(cacheable=true)
public static List getOrderItemRelatedToOrder(List newOrders) {
Set orderIdSet = new Set();
Set orItemFields = Constants.ORDITM_FIELD_LIST;
for(Order orderRecord : newOrders) {
if (orderRecord.Id != null) {
orderIdSet.add(orderRecord.Id);
}
}
String query =
'SELECT ' +
String.join(new List(orItemFields), ', ') +
' FROM OrderItem WHERE OrderId IN :orderIdSet  WITH SECURITY_ENFORCED';
return Database.query(String.escapeSingleQuotes(query));
}

Hi @niteshlande - thanks for reporting. Graph Engine has a known issue where it can't parse String objects constructed with + operator. We'll keep this open and report back when we prioritize and fix this issue.


Helper function for dynamic access to constants & vprint -> vsprint

Since static classes cannot be invoked but can share namespace with functions, calling a dynamic string name instead of using constant('L::'.$string) and rather than a named method like L::get($string) can in fact be done with the help of a new function that accesses the class' properties.
How to use: L($string), or L($string,$args) for vsprintf formatting.

That dynamic access function is so weird, it's genius. Thank you!

This kind of compliment sure puts a smile on my face :)


Use greek letters in the shell prompt

I very much like the lambda in eshell, instead of a dollar-sign:
~/Work/svn/puppet λ

It would be nice to have something like this in bash too.  Perhaps alpha or beta for normal and continuing prompts, and omega for root?
[mjl@milo:~]
[16:49]α sudo \
β bash
Password:
[root@milo:~]
[16:49]Ω

List of greek letters to select from: https://www.w3schools.com/charsets/ref_utf_greek.asp
Perhaps beta/alpha should be swapped?  still to decide.  very low priority, so this will probably be done quickly ;-)

for z-shell (if I ever use it, which is unlikely):  ʓ
https://unicode-table.com/en/0293/

I think use β small letter beta for the primary prompt  (because it evokes "bash", and also it still looks similar to traditional $)
For the secondary prompt, I think technically the greater-than should be replaced with one of these:

≻ Succeeds
⊱ Succeeds under relation
⪼ Double Succeeds

For all of them, only use the greek letters if the terminal's character encoding is UTF-8.
All of these work on a Linux UTF-8 terminal.  I think the Succeeds / Succeeds under relation work better because they are heavier glyphs

[mjl@hoppy:~]
[16:49]β sudo \
⊱ bash
Password:
[root@hoppy:~]
[16:49]Ω


Fix compatibility with ember-data-model-fragments

This adds a workaround for compatibility with ember-data-model-fragments, as discussed in #182.
@patocallaghan you mentioned that the workaround did not work for you before, could you try this branch when you have the time? (you'll need to use "ember-data-factory-guy": "whatthewhat/ember-data-factory-guy#model-fragments-compatibility" in your package.json)
I only tested it on 1 app, but it seems to be working ok with ember-data-model-fragments 1.13.1 and ember-data 1.13.16
Closes #182

@whatthewhat thanks for this. Going to try out the latest release. There was possibly something wrong with my factory's setup. On that note, what's the best way to include a model-fragment in a model factory? Can you only hard code the payload into the parent factory or can you create factories for your model fragments?

@patocallaghan I was wondering that myself .. me curious ... would be neat-o if you could make factories for the fragments.  If you add that explanation on the README would be nice, so others could get some hints.

I'm testing this with fragments v2.1.2 and ember-data 2.4.3 (with ember-data also specified in bower.json)  The current issue I have is that "this" is undefined on the last line below.
import FragmentTransform from './fragment';
import map from '../../util/map';

/**
  @module ember-data-model-fragments
*/

/**
  Transform for `MF.fragmentArray` fragment attribute which delegates work to
  the fragment type's serializer

  @class FragmentArrayTransform
  @namespace MF
  @extends DS.Transform
*/
var FragmentArrayTransform = FragmentTransform.extend({
  deserialize: function deserializeFragmentArray(data) {
    if (data == null) {
      return null;
    }

    return map(data, function(datum) {
      return this.deserializeSingle(datum);
    }, this);
  },

  serialize: function serializeFragmentArray(snapshots) {
    if (!snapshots) {
      return null;
    }

    var store = this.store;

Any ideas on this? Maybe the versions I'm using are not compatible.

can you try v2.4.4 factory guy ?  might not help .. but it was a special patch for fragments .. so it's worth a shot

Yep, that's the factory guy version I'm using.

I am not sure .. maybe wait till the other's like @whatthewhat have a say. Otherwise if you can let me clone the repo I can noodle around?

I'll have to wait since the repo is private. Thanks Daniel!

ok .. np

@danielspaniel @whatthewhat I created an example repo If you get a chance to take a look that would be great!

@mattmcginnis just tried you example and can confirm the error.
The reason it works for me is because we don't have any fragment data in factories at the moment (in your example if the factory does not have default values for the fragment the test passes).

I had a quick dig into this, haven't really got anywhere with it but this is what I found

When transformValueFunction(fixture[attribute]) is called it has no context associated with it so when serialize for the ModelFragment is called, this is undefined and it blows up on this.store. You can get passed this error by doing the following on line 42 of converter/fixture-converter.js:

let fragmentType = serializer.transformFor(type);
return fragmentType.serialize.bind(fragmentType);

But then this leads to another problem, it fails with another error later on in the serialize function. Line 57 in the fixture-converter.js just passes a json payload but the ModelFragment's .serialize function is expecting the param to be of type DS.Snapshot. Internally serialize accesses several properties on that class, namely modelName and eachAttribute.

I am about to fall over because this was the last thing on a long day of work but
.. I did a bigger dig into this and I think I found a bug in the fix that was done by whatthewhat.
I am too tired to say whether this is a real bug or my imagination, but your test now passes and all the fun data is there.
But ...  I have to check out more scenarios, and also maybe add tests for model fragments and make sure I don't cause other MF errors.
I might take all this same info in your sample repo and put that in fg and write tests against it  ( for all the different types of fragments ) .. should I be doing that? or is that MF writers job?   not sure?

@patocallaghan .. I did not read your post carefully enough, but you found the bug too.
serializer is looking to serialize a snapshot ..
and in this world of building fixture data I am not actually doing and ember-data serialize
anyway .. I can't think straight right now, but here was my fix:
let fragmentType = serializer.transformFor(type);
return fragmentType.deserialize.bind(fragmentType);

Let me know if that makes sense

Thanks guys! I was nearly at the same solution myself when I saw the comment.  I created a pull request based on the snippet above.  I also updated my sample repo with that fork and added some tests that modify attrs and save.  Everything works as advertised.

Nice work @danielspaniel and @mattmcginnis!  ... Yeah I think it would be great to have some sort of testing against Model Fragments considering it's now supported. I don't mind helping out adding some tests for that if you want? I also think it warrants an update to the README (again I can add something there)

Yep, my bad.. great work on investigating the issue :+1:

@patocallaghan .. I would be really happy if you added some good tests to make this a more rock solid commit, because I don't trust that things will work in every situation yet util those exist.
I am even thinking now that the deserialize is not even needed, and that just a no op function would have been fine. In other words I am questioning the value of transformValueFn itself .. does not seem to actually serve any purpose, but i will check later today to be sure. z

Any updates @patocallaghan ??
This is actually alittle bit tricky because model fragment is different serialize than an ember data attribute .. so  , there has to be a check if this attribute is a model fragment ( not sure how to do that yet )
anyway .. if you have anything going on testing wise let me know.

Hey @danielspaniel ..I have some tests but nothing extensive yet. I'll make time to get a PR into you in the next few days

ok .. great .. I have come up with this
import EmberDataAttributeTransform from "ember-data/transform";

and then
    if ('function' === typeof serializer.transformFor && !(serializer.transformFor instanceof EmberDataAttributeTransform)) {
      return this.noTransformFn;
    }

as my sort of hackey solution .. and have added a few tests of my own already .. if you want to ScreenHero today or tomorrow let me know .. and we can share test info

Hey, yep that sounds like a plan. How about Friday night GMT which I guess makes it in the afternoon for you?

@patocallaghan sounds good .. I'll be available .. let's say 1 pm -> 4 pm EST .. let me know when you ready and I can get you SH info

Just wanted to say thanks for everyone's work on this fix! I realize MF's weird use of serializers made it a little bit of a pain o_O

No problem @slindberg .. it was really neat to be able to make this work because making factories for the  fragment data is really nice.  If you have any suggestions, bring them on. Always welcome to hear about a nice idea or two.


feature: core.typed annotations

Would this be welcomed if I started contributing them?

If this will make Cheshire depend on core.typed, then I'd vote against it. If this can be made entirely optional, why not.

I agree with Michael, if optional, yeah, if it added the dependency then probably not.

Would it be okay if it's a dev-time only dependency? core.typed is just a compile-time checker; it shouldn't show up e.g. production uberjars.

@lvh I think a dev-time only dep is okay with me


Content-Type header not set

Hi,
Just found this library today and I'm having an issue connected this to a JSONAPI server (fortune JS using mongo adapter).
The problem is when I make a request from devour I get this error back from the server:
NotAcceptableError: The serializer for "application/vnd.api+json" does not exist.
Apparently this is caused by the request not having a content type header. I can indeed see that chrome is not sending that header when making the request (doing a find with a single ID).
I looked inside the devour lib and can see you do set them, but then noticed this is an issue with axios the dep you are using for formatting and sending requests.
Apparently axios only applies this header if there is any content set beforehand. So I think the library needs tweaking to set the content type header after setting the data (in theory?).

This sounds like an issue on the serverside. The content-type application/vnd.api+json is part of the JSONAPI spec. https://jsonapi.org/format/#content-negotiation-clients


[Custom]: Enhance the UI of the Signup and Login page

💡 Custom Issue
📝 Description
I want to enhance the ui of the Signup and Login pages, make them more visually appealing and align them with the overall theme of the app
🔍 Steps to Reproduce (if applicable)

Change the colors and texts
Change the images
Modify the hover effect on the buttons
Align the elements in a better way

🎯 Expected Outcome

📸 Screenshots or Additional Information

💡 Custom Issue
📝 Description
I want to enhance the ui of the Signup and Login pages, make them more visually appealing and align them with the overall theme of the app
🔍 Steps to Reproduce (if applicable)

Change the colors and texts
Change the images
Modify the hover effect on the buttons
Align the elements in a better way

🎯 Expected Outcome
📸 Screenshots or Additional Information

Sure @prasoonk1204 .


Steady state stokes example [steady-stokes-example]

This PR adds a steady state stokes example. This also includes the necessary changes and enhancements to corresponding methods enabling the "FormLinearSystem" interface on rectangular blocks of a block matrix.

[ ] Website update
[x] Make visualization optional

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

https://github.com/mfem/mfem/pull/987
@jandrej
@tzanio
@akgillette + @jamiebramwell
11/23/19
⌛due 12/14/19
⌛due 12/21/19

I think this PR should probably be split into two PRs. One with the changes and additions such as FormColSystemMatrix and EliminateCols. The other with just the stokes example cpp file. Additionally, the column system changes should be merged the matrix-free versions from pa-vector-divergence branch.

This depends on #1164.

This depends on #1164

Should we mark this as WIP then and transfer the review to #1164 (is that one ready?)

Yes, let's mark this as WIP and #1164 is ready for review.


Correction for raw affiliation SPO, INRA, Montpellier SupAgro, University Montpellier, Montpellier, France

Correction needed for raw affiliation SPO, INRA, Montpellier SupAgro, University Montpellier, Montpellier, France
raw_affiliation_name: SPO, INRA, Montpellier SupAgro, University Montpellier, Montpellier, France
new_rors: 03rnk6m14;04w07sc25
previous_rors: 03rnk6m14
works_examples: W2936958071
contact: c0e845bea3a49b8c80478b1bf62363b5:63e0866ba92c40635ab704433cc8a1d5721e @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


tee in create-new-user-bulk.sh

I think you should use the tee -a command. Because your tee script without a flag overwrites the create-new-user-bulk.sql file with the last executed line. i use it in Debian 10.

Thanks for the report, I'll take a look and add some logic for this


hwrdocs

I made a new branch, hwrdocs, to work on pyemu documentation.  I'm working with the Sphinx setup you established.

Coverage remained the same at 81.288% when pulling cc73dcc86a073b571b3c84cf70d04d2ad5acf960 on hwreeves-USGS:hwrdocs into 3542fb9a05c72dcd563486204b79a301d2cfd104 on jtwhite79:develop.

Thanks @hwreeves-USGS ! Let's go with develop for now and once the docs are good-to-go, we can merge into master at make a new release. ok?


Create a new branch based on master

Create a new branch based on master

Branch has been already created.


Optgroup list

This PR needs #822 and introduces a select2 style optgroup list view.
It didn't handle creation  as AFAIK there is no standard way to indicate that item should be created under which group.
There's still a problem with the previous selected choice that didn't appear selected in the admin, but that was already a problem with the original Select2ListView. I will try to fix that in another PR if a find the time.

Hi ! Tests are passing on travis now, could you rebase this on the current master please ?
Do you think you add a minimal example in test_project ?
Thanks !

Codecov Report

Merging #823 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
- Coverage   97.02%   96.91%   -0.11%
==========================================
  Files         124      124
  Lines        2118     2175      +57
==========================================
+ Hits         2055     2108      +53
- Misses         63       67       +4

Impacted Files
Coverage Δ

src/dal/autocomplete.py
96.42% <ø> (ø)
:arrow_up:

src/dal_select2/views.py
100% <100%> (ø)
:arrow_up:

test_project/select2_list/test_views.py
100% <100%> (ø)
:arrow_up:

src/dal/test/stories.py
94.68% <0%> (-2.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c4fad...241e93b. Read the comment docs.

Rebased, tested and minimally documented. :)
I've squashed the previous branch for removing the other PR dep.

Absolutely delicious patch <3


Text format (e.g. IridasCube) parsing optimizations

Primarily driven by a wish to increase performance of parsing .cube files. But the functions that are added or changed are used across parsing of all/most of text based formats.
With these changes, parsing "Khronos PBR Neutral" Iridas .cube file (5.4MB) on Ryzen 5950X / VS2022 Release build: 167ms -> 126ms. Parsing the same file in CLF format: 150ms -> 137ms.
What the PR does is:

Add locale independent IsSpace(char). Somewhat similar to 3aab90d31, whitespace trimming perhaps should not be locale dependent.
Add IsEmptyOrWhiteSpace() and use that inside ParseUtils::nextline, instead of doing Trim(line).empty().
Add StringUtils::StartsWith(char) and use that in various parsers that were constructing whole std::string object just to check for a single character.
When building for C++17 or later, NumberUtils can use standard <charconv> from_chars functions (except on Apple platforms, where those are not implemented for floating point types as of Xcode 15). This has advantage of not having to deal with errno or locales. Saves some thread local storage accesses and function calls (e.g. on Windows errno is actually a function call).

Turns out that NumberUtils::from_chars was only indirectly covered by tests, and as XML parser utils tests point out,
it should be able to handle hex floats and so on. So all that is implemented there, and explicitly covered by
tests/utils/NumberUtils_tests.cpp.
There's a CMake setup change that adds /Zc:__cplusplus flag for MSVC; for backwards compat reasons it does not report proper C++ version detection defines otherwise.

Apologies for the delay in CI @aras-p, we have to manually approve the workflows due to our current GitHub settings. Trying to see if we can update that or merge your other PR which should also work.

@remia thanks! I admit I did not expect that this PR would need so many failed iterations. <charconv> is a tough beast, it seems :)

Doing some test on an Intel MBP, Xcode 16, it seems to still not support from_chars()

Yeah, Apple's Clang/STL keeps on being "special". Some other software (e.g. Blender) works around this whole issue by embedding https://github.com/fastfloat/fast_float and using that instead of <charconv>

Now that two reviews have been done, is there something expected from my side to move forward with this PR?

@aras-p , apologies for the delay in getting this merged. Our CI system is currently having some problems which is causing checks to fail, but I don't think we will need you to do anything more on this one.
It's great to have your participation on OCIO -- we'll try to get your next PR merged more quickly!   ;)


feat: simple uri escaping and unescaping

import Init.System.Uri

open System.Uri

/- Uri character escaping includes UTF-8 encoding for the 😵💫 char! -/
#eval toFileUri "/temp/test.xml?😵💫=2022"
/- "file:///temp/test.xml%3f%f0%9f%98%b5%e2%80%8d%f0%9f%92%ab%3d2022" -/

/- round trip test -/
#eval unescapeUri (toFileUri "/temp/test.xml?😵💫=2022")
/- "file:///temp/test.xml?😵💫=2022" -/

/- and to System.FilePath -/
/- FilePath.mk "file:///temp/test.xml?😵💫=2022" -/
#eval fileUriToPath (toFileUri "/temp/test.xml?😵💫=2022")

/- escaped percent -/
#eval unescapeUri "/temp/test%%.xml"
/- "/temp/test%.xml" -/

/- invalid escape followed by valid escapes -/
#eval unescapeUri "file://test%xx/%3Fa%3D123"
/- "file://test%xx/?a=123" -/

/- tilde is NOT escaped -/
#eval toFileUri "~/git/lean4"
/- "file:///~/git/lean4" -/

This fixes the RubiksCube demo on Windows:

This should probably be in Std, not Init. We also try to avoid orphan modules (I believe), so you should create Std.System as well and recursively import them up to Std.

This should probably be in Std, not Init. We also try to avoid orphan modules (I believe), so you should create Std.System as well and recursively import them up to Std.

Why is System.FilePath different and more special than System.Uri - these seem closely related to me... eventually I'd like to see a full Uri class there that does Uri component parsing, resolve_uri, make_relative and all that...
I have no idea what the second part of your sentence means, can explain more about what an orphan module is and share an example of "recursively import them up to Std." ?

Why is System.FilePath different and more special than System.Uri

The Lean runtime deals with FilePaths but not with Uris, so that's one profound difference. But would be good to hear from others here.
An orphan module (which I think I made up) is a module not imported by the package root. So Std should be importing Std.System should import Std.System.Uri.

An orphan module (which I think I made up) is a module not imported by the package root. So Std should be importing Std.System should import Std.System.Uri.

Ok, I get it now, I moved the code to Std.System.Uri.

Unhandled test case, I think: "%%"

I have this test case:
/- escaped percent -/
#eval unescapeUri "/temp/test%%.xml"  -- "/temp/test%.xml"

@Kha - I'm done messing with this one now, I think.

@lovettchris This PR is almost ready to be merged. Thanks! Could you please squash and resolve conflicts? GitHub is saying it cannot be rebased due to conflicts.

squash

Done, weird my local git didn't think there were conflicts.  I assume we do a squash merge when PR is completed?


TypeError: L.markerClusterGroup is not a function

Hi,
I just tried implementing the markerCluster functionality into my application based on Angular17 (with standalone Components). I copied the example from this repo 1:1 (as own module as in the example)  and getting the following error:
TypeError: L.markerClusterGroup is not a function

The Error is thrown within the directive in the ngOnInit (line 18). See the following screenshot.

Extract from package.json:
"leaflet": "^1.9.4",   "leaflet.markercluster": "^1.5.3",    "@asymmetrik/ngx-leaflet": "^17.0.0",    "@asymmetrik/ngx-leaflet-markercluster": "^17.0.0",

Now, it works without any issue. That's my code:
const markerArray = L.markerClusterGroup();
for (const loc of this.locations) {
  passArray.addLayer(marker([ loc.lat, loc.lon ], {
    icon: this.icon
  }));
}
this.markerGroup = markerArray;

in my template:

    @if (markerGroup) {

    }

I've come across this issue too. I solved this problem by next steps:

Add leaflet and leaflet.markercluster scripts in a “scripts” array (angular.json), in the current order:

"scripts": [
  "node_modules/leaflet/dist/leaflet.js",
  "node_modules/leaflet.markercluster/dist/leaflet.markercluster.js"
    ];

These scripts will add “L” object as a field of the global “window” object. Now you can get Leaflet extended by “markercluster” plugin as: window.L anywhere;

Define a private field (“leaflet” in my case) in component/directive/services classes, where you use Leaflet:

import 'leaflet.markercluster'; // you need import this locally anyway for "markercluster" methods ts-declaration

@Component({})
export class AppComponent() {
  private leaflet = window.L; // here is our leaflet with the clusters

  initMap() {
    const map = this.leaflet.map('map').setView([0, 0], 10);
    const markers = this.leaflet.markerClusterGroup(); // now this method is defined!
    map.addLayer(markers);
  }
}

Works for me on Angular 18.2.0.

Having the same issue here. I think this problem would go away if the import to Leaflet inside LeafletMarkerClusterDirective would be
import L from 'leaflet`

I'm currently migrating a project from Angular 15 to 18 and I started encountering the "not a constructor" error wherever a constructor from a leaflet plugin was being initialised, e.g. new L.StripePattern({...}). This is due to how the newer version of Angular bundles Leaflet - at runtime L resolves to {default: <the actual Leaflet object>, <...core Leaflet functions>}.
Changing the import to the above notation worked for me, so I reckon this directive needs to follow the same approach.


[Bug] dateTime format with polish locale displays week number instead of "w"

When I format dateTime variable to display month name using  #{dateTime:MMMM} with polish locale, instead of displaying "września" (September) it displays "37rześnia". It looks like "w" is replaced with #{dateTime:w}.
The same happens to other month with "w" in the name : kwietnia (April) and czerwca (June).
Expected behavior
#{dateTime:w} #{dateTime:MMMM}  --> 37 września
#{dateTime:+7M:w} #{dateTime:+7M:MMMM} --> 15 kwietnia
#{dateTime:+9M:w} #{dateTime:+9M:MMMM} --> 24 czerwca
Actual behavior
37 37rześnia
15 k15ietnia
24 czer24ca
Beeftext version (e.g. Beeftext v7.0 Portable Edition).
Beeftext v14.0
Operating system version (e.g Windows 10)
Windows 11 Pro 21H2 22000.856
polish language

I found that in evaluateDateTimeVariable function after formatting the date function replaces "ww" and "w" into week number.
result.replace("ww", QString("%1").arg(weekNumber, 2, 10, QChar('0')));
return result.replace("w", QString::number(weekNumber));
I think it should first check if formatStr == "w" || "ww"

Hi.
Thank you for reporting. You're obviously right. I'll fix that and post a build soon.

Hi. The issue should be fixed. Here are test builds:

Beeftext-14.0-Installer.zip
Beeftext-14.0-PortableEdition.zip

Thank you.
Works great.


How to play nicely with synced folders? (Google Drive for example)

I have Google Drive (on mirror mode) syncing the log files for my project, however it gets stuck on trying to sync the .__XXX.lock  file forever, which balloons the CPU and RAM usage to close to 100% forever on my Windows 10 PC. Is there anything I can do to prevent this?

This package uses Win32API file locking to ensure safe concurrent access to write the log file. Maybe Google Drive doesn't like locked files very much. Which process is ballooning - the Python one or a Google Drive one? You should be able to see in Task Manager's details pane.
As a workaround, is it possible to set Drive to ignore *.lock files? You shouldn't need to sync or back those up really.
Currently there is no way to control where the lock file is placed - it's always in the same dir as the actual log file. However it might help to add an option to place the locks somewhere else, outside of the synced folder.


Element duplication

Element duplication
This incidence occurs during application of the integrated copy function in RDMO. During the duplication process, the new element inherits without consultation all relations of the original element.
This behaviour might be intended, if existing option sets should be extended. But it is confusing, if an option from set B is copied to be used in another option set B' similarily. After the duplication process is complete, option set B carries both option A and A'.
This incidence is not restricted to options and option sets and can be reproduced for instance with attributes too. With regard to the multi-site-setup this incidence may create some confusion unintentionally.

References / Verweise

Hey @chsinn , thanks for reporting, I already found the problem. Whenever you copy an element, the new element gets injected into the old elements "parent". I will fix it asap.


Semantic API signature of an anonymous record type symbol is invalid

Description:
Consider the following anonymous record.
    record {
      string recField = "";
    } testRec = someFunction();

For the create function code action, we need to determine the type the LHS. However, the signature returned by the typeSymbol.signature() is  string recField; anydata...; } while the expected value is {| string recField; anydata...; |}.
Steps to reproduce:
See the above description

@IMS94 Is this issue still valid in the current master or slalpha2?

The above produces the following in the current master:
function someFunction() returns record {| string recField; anydata...; |} {

    return {};
}

The original issue seems resolved right? However, have some concerns regarding the mapping constructor expr generated for the return statement. It's not a valid value for the return type. Shouldn't it have been a valid one, ideally?

@pubudu91 With ##28989, original issue should be fixed. Regarding the mapping constructor, agreed that it is not correct. Need to support setting default values for fields within that in future. We did not put more effort into fixing that now due to other priorities. Can you create an issue so that we can fix this eventually?

Ack. Will do. Shall we close this then?

@pubudu91 Yes. Will close this.


Add problem matcher for appstream-util validate's output

See https://github.com/vixalien/sticky/issues/59#issuecomment-1554644759
I'm still trying to figure out how to also annotate the filename, hence made this a draft.

I think appstreamcli works better than appstream_util and easily catches these errors.

Indeed. I believe this is fixed by #110


python312Packages.tika-client: 0.6.0 -> 0.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.tika-client is: Modern Python REST client for Apache Tika server
meta.homepage for python312Packages.tika-client is: https://github.com/stumpylog/tika-client
meta.changelog for python312Packages.tika-client is: https://github.com/stumpylog/tika-client/blob/0.7.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.0 with grep in /nix/store/v81lqkjyk7cqzyqwqrmvw30mb9xbmk41-python3.12-tika-client-0.7.0
found 0.7.0 in filename of file in /nix/store/v81lqkjyk7cqzyqwqrmvw30mb9xbmk41-python3.12-tika-client-0.7.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

paperless-ngx
python311Packages.tika-client
python312Packages.tika-client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v81lqkjyk7cqzyqwqrmvw30mb9xbmk41-python3.12-tika-client-0.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.tika-client https://github.com/r-ryantm/nixpkgs/archive/efaf696f2dc06623d8605d43dc71550b2877faba.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/efaf696f2dc06623d8605d43dc71550b2877faba#python312Packages.tika-client

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v81lqkjyk7cqzyqwqrmvw30mb9xbmk41-python3.12-tika-client-0.7.0
ls -la /nix/store/v81lqkjyk7cqzyqwqrmvw30mb9xbmk41-python3.12-tika-client-0.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

paperless-ngx
python311Packages.tika-client
python311Packages.tika-client.dist
python312Packages.tika-client
python312Packages.tika-client.dist

Maintainer pings
cc @e1mo for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 347669 run on x86_64-linux 1

5 packages built:

paperless-ngx
python311Packages.tika-client
python311Packages.tika-client.dist
python312Packages.tika-client
python312Packages.tika-client.dist


[Summer of code] Use confirm offset in ReputMessageService

Make sure set the target branch to develop
What is the purpose of the change
tracking issue: https://github.com/apache/rocketmq/issues/4330
Brief changelog
Use confirm offset in ReputMessageService
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

 虽然在 allAckSyncStateSet = true 下, 不会发送成功, 但是这些消息仍然会被 reput by reputMessageService.
后续切换 master 的时候, 就会出现消息丢失的现象.
解决办法就是让 reputMessageService 利用 autoSwitchHaSerivce 中的 ConfirmOffset 作为 reput 边界, 这样当消息发送失败时 (allAckSyncStateSet = true), confirmOffset 不会增大, reputMessageService 就不会 reput 这些失败的消息.

Codecov Report

Merging #4449 (ba7d4f5) into 5.0.0-beta-dledger-controller (81dc938) will decrease coverage by 0.08%.
The diff coverage is 75.00%.

:exclamation: Current head ba7d4f5 differs from pull request most recent head 5882be7. Consider uploading reports for the commit 5882be7 to get more accurate results

@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4449      +/-   ##
===================================================================
- Coverage                            43.17%   43.09%   -0.09%
+ Complexity                            6343     6335       -8
===================================================================
  Files                                  841      841
  Lines                                59824    59833       +9
  Branches                              8152     8154       +2
===================================================================
- Hits                                 25830    25785      -45
- Misses                               30643    30689      +46
- Partials                              3351     3359       +8

Impacted Files
Coverage Δ

...ketmq/store/ha/autoswitch/AutoSwitchHAService.java
57.05% <63.63%> (-0.19%)
:arrow_down:

...org/apache/rocketmq/store/DefaultMessageStore.java
54.03% <100.00%> (+0.14%)
:arrow_up:

...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java
75.56% <100.00%> (+0.09%)
:arrow_up:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-8.96%)
:arrow_down:

...etmq/namesrv/routeinfo/BatchUnRegisterService.java
94.73% <0.00%> (-5.27%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-4.35%)
:arrow_down:

...mq/broker/topic/TopicQueueMappingCleanService.java
12.43% <0.00%> (-3.63%)
:arrow_down:

...a/org/apache/rocketmq/broker/BrokerController.java
44.04% <0.00%> (-3.31%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
59.13% <0.00%> (-2.16%)
:arrow_down:

...he/rocketmq/broker/processor/PopReviveService.java
24.90% <0.00%> (-1.81%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81dc938...5882be7. Read the comment docs.

Coverage increased (+0.02%) to 47.298% when pulling 5882be707423f246c5d418b8c81a00a79c630b17 on hzh0425:feature/use-confirmOffset into 6645d0a42b743fc003ed54658cd24e99c375ac8b on apache:5.0.0-beta-dledger-controller.

Coverage increased (+0.02%) to 47.298% when pulling 5882be707423f246c5d418b8c81a00a79c630b17 on hzh0425:feature/use-confirmOffset into 6645d0a42b743fc003ed54658cd24e99c375ac8b on apache:5.0.0-beta-dledger-controller.


neovim: support new extraPython*Packages options, fix configure

https://github.com/NixOS/nixpkgs/pull/43388 changed the expected type of extraPython{,3}Packages parameters from list to a function, as well as stopped support of configure to be passed as null.
See the diff in https://github.com/NixOS/nixpkgs/pull/43388

#375

Squashed and rebased to master in 63efd267673eb5febf4da728923f21f5353d8462. Thanks for fixing!

This is preventing home-manager switch in NixOS 18.03. Was the change in nixpkgs merged into stable?

I don't think so, however I don't think there are any compatibility guarantees with nixpkgs stable on master branch of this project. Try release-18.03 branch?

@gmarmstrong Yeah, as @rvolosatovs said the master branch basically tracks Nixpkgs unstable. The release-18.03 branch should be compatible with Nixpkgs 18.03. Note that until this change was merged they were actually one and the same.


Vite plugin can not work on bun runtime

UnoCSS version
0.61.9
Describe the bug
bunx vite works correctly, but bunx --bun vite gives the error:
error when starting dev server:
ReferenceError: Cannot access 'default' before initialization.
    at <anonymous> (E:\projects\app\node_modules\jiti\dist\jiti.cjs:1:180987)
    at jitiInteropDefault (E:\projects\app\node_modules\jiti\dist\jiti.cjs:1:181414)
    at <anonymous> (E:\projects\app\node_modules\jiti\dist\jiti.cjs:1:185158)
    at processTicksAndRejections (:12:39)

Reproduction
add UnoCSS() into vite plugins and run bunx --bun vite
System Info
bun version: 1.1.22
vite version: 5.4.0
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is a Bun issue and should be posted here instead: https://github.com/oven-sh/bun/issues

It can be followed here btw https://github.com/oven-sh/bun/issues/13338

  "overrides": {
    "unconfig": "0.3.10"
  }

add this into your package.json and UnoCSS will work in Bun again. importx somehow introduced a Bun compat issue that I am not sure of yet


document workflow schema version

Changes introduced with this PR

document workflow schema version
document workflow schema and engine version compatibility
fix broken multiple outputs link

By contributing to this repository, I agree to the contribution guidelines.

Changes merged in pr 70


Update angular version to ^2.4.9 and add @types/vis (fixes AOT)

This fix unblocks compiling an angular cli app and resolves #26 (for me anyways).
When I ran git commit I got a whole pile of lint errors regarding different ts files, but the only file I modified was package.json so I'm not sure why. I bypassed them, but I'm guessing the tests will fail on travis too.
Please merge this or give me a timeline as to when you can make this change. This is blocking me using this plugin in my app entirely.

I've hopefully fixed this with the next version (currently you can test with ng2-vis@0.0.6-pre.1). I also updated to angular 2.4.10. Please follow the conversation in #26
Thanks again for your PR!


[WFCORE-890] Split http-upgrade for the HTTP Managenent interface into it's own element.

:exclamation: Commits from this branch are used in numerous other topic branches so please do not cherry-pick or rebase. :exclamation:
This change is a minor update to the HTTP management interface configuration in preparation for subsequent Elytron changes that will be coming in the future.  Also unfortunately I implemented some changes in the wrong order - following on from this PR I also have another PR to refactor the management interfaces so they can share as much common code as possible as at the moment there is a lot of duplication.
The reason for this change is that Elytron provides authentication policies for SASL based authentication and for HTTP based authentication - once HTTP Upgrade occurs we switch to Remoting to handle the authentication which means we are switching to SASL so this new child element is to logically group the configuration specific to HTTP Upgrade.

Looks good but needs a rebase. Ping me on hipchat once it's rebased and I'll try and get it merged immediately.

I just pushed 3 PRs to master-ignore and plan to merge them once the testsuite finishes (say 4:30 EDT) so any rebase should probably wait for that.

Those 3 PRs are merged.


Add warm_pool

what

Add warm_pool

why

A warm pool gives you the ability to decrease latency for your applications that have exceptionally long boot times, for example, because instances need to write massive amounts of data to disk. With warm pools, you no longer have to over-provision your Auto Scaling groups to manage latency in order to improve application performance.

references

https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-warm-pools.html

/test all


Fixed Return Home Button Error

Fixed Return Home Button Error
 BEFORE :

https://github.com/user-attachments/assets/8317ee0e-cf69-4924-98cf-8477d774ff92
 After :

https://github.com/user-attachments/assets/595f0c34-1b70-44f9-b594-7f686dff3bdc
🛠 Fixes Issue
Fixes: #<issue_number>
👨💻 Description
What does this PR do?

Briefly describe the feature or bug fix you've implemented.
Highlight any major changes or added functionality.
Mention how it enhances the project.

📄 Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (adds or updates related documentation)

📷 Screenshots/GIFs (if any)
Include screenshots or GIFs to demonstrate your changes
✅ Checklist

[ ] I am a participant of GSSoC-ext.
[ ] I have followed the contribution guidelines of this project.
[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have added documentation to explain my changes.

Mandatory Tasks

[ ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🤝 GSSoC Participation

[ ] This PR is submitted under the GSSoC program.
[ ] I have taken prior approval for this feature/fix.

@YadavAkhileshh Please Review My Changes and Merge it by Assigning Labels to it !!!

@YadavAkhileshh Please Merge it Before 7 p.m, Because After that it is Going to END.


Exclude Implicit references from Microsoft.Build.CentralPackageVersions?

Would it be possible to add an option to Microsoft.Build.CentralPackageVersions to exclude the implicit package references from requiring a PackageVersion entry?
I'd prefer to let those be managed automatically as they currently are, but still have the control that Microsoft.Build.CentralPackageVersions provides for all the other packages.

Yes I think an new property added to this condition would do:
https://github.com/Microsoft/MSBuildSdks/blob/master/src/CentralPackageVersions/Sdk/Sdk.targets#L92
Feel free to test it out and send a PR

It looks like it will be a bit more complicated than just adding a condition there, since the implicit references end up getting removed completely by the stuff going on in https://github.com/Microsoft/MSBuildSdks/blob/master/src/CentralPackageVersions/Sdk/Sdk.targets#L28-L54
I see what needs to be done though, so I'll try and get a PR ready soon.

I did end up spending some time on on this, and got it mostly working, but there were some really weird edge cases that I never go time to work through.
Does #31 still replace the implicit packages? If so, perhaps it will be easier to change that once 2.0 is ready.

@bording yeah I decided with v2.0 to just ignore implicit package references.  I'll release it today and you can give it a shot.

Closed via #31


Browser opens with all parts even though DNA selected

Which browser is this?  I can't seem to reproduce in the RegistryInputDialog or RootCDSelectionDialog.

It is the one when you open a document.

On Mar 20, 2017, at 4:21 AM, Michael Zhang<EMAIL_ADDRESS>wrote:
Which browser is this? I can't seem to reproduce in the RegistryInputDialog or RootCDSelectionDialog.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOLDesigner/issues/146#issuecomment-287676513, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD90BDOKnaRe5MkLJngLVx-Q86S8fPks5rnf6vgaJpZM4MRj4I.

I believe I have fixed this in SBOLDesigner now.  I've also updated the jar in iBioSim.  However, I was never able to reproduce this in the first place, so it's probably good to check to make sure.
Closing for now.

Appears to be fixed.

On Mar 26, 2017, at 9:11 PM, Michael Zhang<EMAIL_ADDRESS>wrote:
I believe I have fixed this in SBOLDesigner now. I've also updated the jar in iBioSim. However, I was never able to reproduce this in the first place, so it's probably good to check to make sure.
Closing for now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOLDesigner/issues/146#issuecomment-289343894, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD9ycc1LdSKoG5IniKkTrcV-o9_dWzks5rpyjygaJpZM4MRj4I.


Changed Beginner1 class names

Coverage remained the same at 65.104% when pulling c6fe106207af8df87e4dc4ba7cb26565de38f420 on lramirez:exampledata into d28d0152623c7ae191f7ab3cabb607e14331b5e3 on tdd-pingis:master.


DxcInput component does not support number type

The DxcInput component does not support type="number".
It is strange that for masked input is necessary to use this property:  isMasked={true}.
I think it would be better if "isMasked={true}" was changed to type="password".
The DxcInput field should have the same property "type" as the standard HTML Input component and the Material-UI  TextField component.
Can you please add the "type" property with the following standard options:
<input type="button">
<input type="checkbox">
<input type="color">
<input type="date">
<input type="datetime-local">
<input type="email">
<input type="file">
<input type="hidden">
<input type="image">
<input type="month">
<input type="number">
<input type="password">
<input type="radio">
<input type="range">
<input type="reset">
<input type="search">
<input type="submit">
<input type="tel">
<input type="text">
<input type="time">
<input type="url">
<input type="week">

I'm closing this one because is a duplicate of #104.
We have in our roadmap standardising data type formats in our design system, in order to guarantee consistency across different applications.
We won't necessarily replicate html or material API, since we are implementing custom components .
For example, we already have a radio component, so there is no need of having an input type "radio".


including setup.md as only file in learners config field causes Actions workflow to fail

Although it does not cause any problem when I build locally, listing setup.md under learners: in config.yaml causes the Build and Deploy workflow to fail on GitHub with the following cryptic error message:
'' does not exist in current working directory ('/home/runner/work/upgraded-engine/upgraded-engine').

I have created a minimal example at https://github.com/tobyhodges/upgraded-engine
Here is the output of sessionInfo() on my local system, where sandpaper::serve() runs without issue:

R version 4.3.1 (2023-06-16)
Platform: aarch64-apple-darwin20 (64-bit)
Running under: macOS Ventura 13.5.2

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib/libRlapack.dylib;  LAPACK version 3.11.0

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

time zone: Europe/Berlin
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

loaded via a namespace (and not attached):
 [1] utf8_1.2.3        generics_0.1.3    renv_1.0.2        xml2_1.3.5        tinkr_0.2.0       digest_0.6.33
 [7] magrittr_2.0.3    evaluate_0.21     fastmap_1.1.1     jsonlite_1.8.7    rprojroot_2.0.3   processx_3.8.2
[13] whisker_0.4.1     promises_1.2.1    ps_1.7.5          purrr_1.0.2       fansi_1.0.4       cli_3.6.1
[19] rlang_1.1.1       commonmark_1.9.0  xslt_1.4.4        withr_2.5.0       cachem_1.0.8      yaml_2.3.7
[25] tools_4.3.1       sandpaper_0.13.2  memoise_2.0.1     dplyr_1.1.3       httpuv_1.6.11     credentials_1.3.2
[31] assertthat_0.2.1  mime_0.12         vctrs_0.6.3       R6_2.5.1          lifecycle_1.0.3   fs_1.6.3
[37] varnish_0.3.0     pkgconfig_2.0.3   desc_1.4.2        callr_3.7.3       later_1.3.1       pkgdown_2.0.7
[43] pillar_1.9.0      glue_1.6.2        Rcpp_1.0.11       servr_0.27        gert_1.9.3        xfun_0.40
[49] tibble_3.2.1      tidyselect_1.2.0  rstudioapi_0.15.0 sys_3.4.2         knitr_1.44        htmltools_0.5.6
[55] rmarkdown_2.24    pegboard_0.6.1    compiler_4.3.1    downlit_0.4.3     askpass_1.2.0     openssl_2.1.0

Is there a reason why you would list setup.md locally? It gets stripped from the menus because it's a section in the index and not a separate page.

I can imagine circumstances in which a person would do this accidentally e.g. if they add a bunch of files to learners/ and then decide they want to control the order those pages appear in the dropdown menu. They might forget that setup.md doesn't need to be included, and add it to the config.yaml based on the list of filenames in the directory. I think that's a realistic scenario.
But mostly I wanted to report this because of the inconsistency in behaviour between my local setup and the Actions workflow, which combined with the non-obvious error message and the fact that the issue seemed to spring up spontaneously earlier this week, made it very difficult to debug.

Ah, gotcha. That's a very good point. Thank you for finding the root cause of this and creating a MWE.
In particular, this bug was just added in the update to the 404 page that addressed https://github.com/carpentries/sandpaper/issues/498.
The nitty gritty of what's happening is that, when the 404 page is built from a deployment function (one that starts with ci_), then it will convert all of the relative links in the navigation to absolute URLs.
The problem arises when there is nothing to be had in one of the navigation menus for the learners, which can occur in two situations:

the only file in the learners/ folder is setup.md
the only file listed in the learners: item of config.yaml is setup.md

If you have the following config, it will work as expected.
learners:
- reference.md
- setup.md

That being said, this is definitely a bug that should be rectified.

Because this is causing existing builds to fail, I will add a quick fix, but it does beg the question: what happens when someone does not want anything to appear in the "more" section? At the moment, there's no good way to do that.

The problem arises when there is nothing to be had in one of the navigation menus for the learners, which can occur in two situations:

the only file in the learners/ folder is setup.md
the only file listed in the learners: item of config.yaml is setup.md

Indeed that makes it much less likely to come up. Thanks for clarifying.

Because this is causing existing builds to fail, I will add a quick fix, but it does beg the question: what happens when someone does not want anything to appear in the "more" section? At the moment, there's no good way to do that.

My immediate thought is that the More dropdown should not be displayed if there's nothing to populate it. If that is challenging to implement, I would suggest some subtly-styled placeholder text that says something like "nothing here".

This was fixed in https://github.com/carpentries/sandpaper/pull/520


A few comments about stack variables and byte ordering...

Hi, and sorry to bother you once again, but after playing around some more with my project, I have a couple comments:

I noticed that rv is an automatic (stack) variable.  For the readxx() calls it is not explicitely initialized to zero and my understanding of the C++ standard is that it does not guarantee that stack variables are initialized to zero.  That won't be a problem for reading a single byte, but for reading multiple bytes, the additional bytes are added into rv, so it seems to me like that could be a problem.

When reading multiple bytes, it appears that the byte order is determined by the LSB/MSB first setting.  That's not unreasonable, and in my situation, I wired the 74HCx165 intuitively such that A is bit 0, and H is bit 7 which seemed natural, but actually H is shifted out first, so it really makes H the LSB which is a bit counter-intuitive.  However, my byte order is Chip0 low, Chip1 high which arguably seems natural in the general case because Chip0 data always appears first.  However, I think the byte ordering treats a cascade of registers conceptually as a single large shift register with the LSB/MSB first setting applied to the entire "large" register which is why I think it was done that way.  So in my case, I was able to simply work around the problem by calling read() multiple times and placing the bytes in least significant byte order even though the bit order is MSB for the reason stated above.    It might be nice for the bit order and byte order to be specified independently, but I'm sure that complicates the library code so I'm not even suggesting that.  I just thought my situation was interesting and it made me realize that bit 0 really corresponds to the "H" pin, not the "A" pin.  Perhaps a bit of a caveat.  Moral: Always read the datasheet, as things are not always as they seem!

Thanks!

Thanks for this feedback, appreciated

Agree, better to make initializations explicit.
Have to verify the details, lib might need additional documentation about byte order.

Bitwise the library calls should behave like the reference shiftIn(). I will verify / compare the code once again.

At lowest level the rv variable is initialized
At the "higher" level functions it is not needed
uint16_t FastShiftIn::read16()
{
  uint16_t rv;
  if (_bitOrder == LSBFIRST)
  {
    rv = readLSBFIRST();  <<<  rv is overwritten so initialization not needed.
    rv += uint16_t(readLSBFIRST()) << 8;
    return rv;
  }
  rv = readMSBFIRST();
  rv <<= 8;
  rv += readMSBFIRST();
  return rv;
}

possibly better to rewrite them to
uint16_t FastShiftIn::read16()
{
  if (_bitOrder == LSBFIRST)
  {
    uint16_t rv = readLSBFIRST();
    rv += uint16_t(readLSBFIRST()) << 8;
    return rv;
  }
  uint16_t rv = readMSBFIRST();
  rv <<= 8;
  rv += readMSBFIRST();
  return rv;
}

Yes, the initial assignment initializes the entire value, so not an issue.  It was late here, when I wrote that.  I think your bit ordering is working fine.  If anything, it might be worth documenting that the LSB for the 74HCx595 is actually "G", not "A".  FWIW, that is what tripped me up on the byte ordering. (I saw a similar post in the Arduino forum where someone encountered that problem, but nothing to do with your library, just a general concern for the 74HCx165).

Thanks for the followup.

Reopened the issue as I want to add a section in the readme.md file.
(Open issues work as reminder)


importer: Adds importer permission

Needed for https://github.com/CERNDocumentServer/cds-ils/pull/236

IMO it should be on cds-ils not on invenio-app-ils, ping @ntarocco

This doesn't correspond to ILS, closed by https://github.com/CERNDocumentServer/cds-ils/pull/240


add sanitizer support

Description
What is the purpose of the change?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Brief of your solution
Please describe your solution to solve the issue or feature request.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Codecov Report

Merging #28 (d976e5c) into main (8e3cdb6) will not change coverage.
 Consider uploading reports for the commit becb3e7 to get more accurate results

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   44.39%   44.39%
=======================================
  Files           8        8
  Lines         428      428
=======================================
  Hits          190      190
  Misses        204      204
  Partials       34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3cdb6...becb3e7. Read the comment docs.


Automerging workflow

For pull request workflows, we need to add an automerge step if all tests pass.
Frontend web app example:
  automerge:
    runs-on: ubuntu-latest
    needs: test
    if: |
      github.actor == 'dependabot[bot]' &&
      startsWith(github.event.pull_request.title, 'build(deps-dev):')
    steps:
      - name: wait for code cov project to pass
        uses<EMAIL_ADDRESS>        id: wait-for-codecov-project
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          checkName: codecov/project
          ref: ${{ github.event.pull_request.head.sha || github.sha }}
      - name: wait for codecov patch to pass
        uses<EMAIL_ADDRESS>        id: wait-for-codecov-patch
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          checkName: codecov/patch
          ref: ${{ github.event.pull_request.head.sha || github.sha }}
      - name: merge
        if: steps.wait-for-codecov-project.outputs.conclusion == 'success' && steps.wait-for-codecov-patch.outputs.conclusion == 'success'
        uses: actions/github-script@v3
        with:
          script: |
            github.pulls.merge({
              owner: context.payload.repository.owner.login,
              repo: context.payload.repository.name,
              pull_number: context.payload.pull_request.number,
              merge_method: "rebase"
            })

Frontend libraries will have the same approach (automerging dev dependencies).
Backend applications can do automerging for any Dependabot update, as long as all tests and status checks pass.

Frontend libraries have been updated to use automerging.

Backend apps have been updated to use automerging.


Lab 4 Level 5

I am trying to figure out a dynamic implementation of the add method of the Roster class for Level 5 without using isPresent() [As part of the restrictions]

Intended output:

My output:

Any help is appreciated, thank you.

You're literally overwriting stuff.

Yup, I used orElse() too!

It worked. Thanks!


feat: use v-safe-href to sanitize url

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
just follow the Vue best practices, use sanitize-url to avoid the URL Injection.
Also, to avoid change all the href link in the project i add a v-safe-href directive, so the fix will be much easier imo.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #6692
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 94e800e
Refactored the footer component and moved it to components/TheFooter.vue. Replaced <a> elements with nuxt-link or v-safe-href in various files to improve navigation and security. Fixed the code style of twitterText in components/collection/unlockable/UnlockableLoader.vue.

🤖 Generated by Copilot at 94e800e

Sing, O Muse, of the skillful refactoring
That the wise and nimble coder wrought
On the many <a> elements, transforming
Them to nuxt-link for speed and thought.

TheFooter - ✔
unlockable twitter
wallet asset menu ✔
walletassetnfts ✔
walletassetportfolio ✔
shoppingcart modal ✔
drops:
dropcard ✔
Gallery:
galleryitemdescription ❌ (metadata)
unlockabletag - ✔
identity:
itentityItem
module:
identitylink
identitypopoverheader
identitySocial
landing:
Featured Articles ✔
media/type:
UnknowMedia - must search
RMRK/profile:
ProfileDetail ✔
Shared:
blockexplorerlink ✔
LinkResolver
Format:
ExternalLink ✔
Teleport
Teleport.vue ✔
Transfer:
TransferOld
components:
CardArticle.story - not sure if used
CardArticle - not sure if used
NeoNFTCard ✔
blog links ✔
QR Code

Gallery:
galleryitemdescription ❌ (metadata)

this one has been fixed @prury

pay 50 usd

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.93 USD/DOT ~ 10.142 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0x905640b560738b6ed4dce515562f9dbcc341893f6c84b86e41765db6556c45ad
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


add digest module

This is adapted from Nova code base: https://github.com/microsoft/Nova/src/digest.rs

Update sha3 library version and corresponding codes in commitment key setup.
Fix test errors

Will add related methods for PublicParameter and PlonkInstance in future PR.

If there were a more pronounced Repr type inside F, it would be much more elegant (without all those bit reads), but unfortunately it can't be created for an arbitrary field.
Now I will create a separate PR with my version, feel free to compare variants

ecial trait and structure
Can work with any hash function, with the desired output size, rather than giving only one option
Works automatically with any serializable type, does not require a separate trait marker
Handles errors, rather than panicking over them

Your approach looks simpler.  However, there is one potential issue of your approach. In your implementation, it works with any function that implements digest trait. For the security reason, we have to choose a collision resistant hash function. In Nova's implementation, it used sha3. If to choose your approach, please modify it to restrict to a collision resistant hash, like the sha3 in the test example. @cyphersnake


⚠ Samsung has degraded performance

In 7bbb187, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2517 ms

Resolved: Samsung performance has improved in 2b1868c.


Predicate for "damage_source_property" in loot_tables don't have "type" property

I think I found a "bug" in the predicate minecraft:damage_source_properties for loot_tables. They aren't type property. For example in the file turtle.json the bowl recipe have predicate > is_lightning, instead of predicate > type > is_lightning. The Minecraft version work in the game, but the second (with type) suggested by DPH+ don't work in Minecraft, and the loot is looted regardless of the predicate. I think pictures will be better than words !
Minecraft Ver (work fine) :

DPH+ Ver (predicate ignored) :

Please uninstall the "Datapack Helper Plus (JSON)" extension; it's the bad one. The language server (Data-pack Helper Plus) can provide support for JSONs correctly.


CNN 模型所需的计算力（flops）和参数（parameters）数量计算（给出计算推导、例子）

RT.

1.我看公式不是很复杂，公式尽量不要用图片，要用markdown的latex写

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: zhangjin12138:x: unknownunknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

1.我看公式不是很复杂，公式尽量不要用图片，要用markdown的latex写

其实还是有点麻烦 也不难  就是要搜很多符号  谢谢啦


epan-sys-0.1.0 as a crate does not contain a git repo

epan-sys-0.1.0 involves building wireshark from source. Although the git repo of this project does contain a submodule called wireshark, the downloaded crate at local path ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/epan-sys-0.1.0 does not.
After running the following command in the aforementioned local path,
git submodule update --init --recursive wireshark

the output goes:
fatal: not a git repository (or any of the parent directories): .git

It seems like std::process::Command::output() did not catch this error, hidden behind the cmake error:
  CMake Error: The source directory "/Users/[REDACTED]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/epan-sys-0.1.0/wireshark" does not exist.
  Specify --help for usage, or press the help button on the CMake GUI.

https://github.com/ghpr-asia/wsdf/issues/12 is the associated issue but the author closed without addressing the first case. This issue focuses on that case.

https://github.com/ghpr-asia/wsdf/issues/16

@Banyc Hi, I was taking a look at the build of epan-sys and trying to reproduce it in #18, I did not encounter this missing git repo situation. Would something like https://github.com/amitrahman1026/wsdf/pull/1 help you successfully build?

@amitrahman1026 oh its been ages but ive turned to just writing the lua plugin instead.

@amitrahman1026 oh its been ages but ive turned to just writing the lua plugin instead.

Alright no worries :) I'll see what I find out while trying to make this build process a little better


add rust sdk benchmark into workflow

Add rust benchmark into workflow

Codecov Report

Merging #266 (a242d20) into main (2c33bd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   54.79%   54.79%
=======================================
  Files          41       41
  Lines        3796     3796
=======================================
  Hits         2080     2080
  Misses       1716     1716

Flag
Coverage Δ

rust
54.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cordova/CDVURLProtocol.h missing in cordova-ios 6.0.0

https://github.com/apache/cordova-ios/pull/783
Read the above URL. breaking (CDVURLProtocol): delete by the cordova-ios team.

Until this is not fixed, I forked this repo and created a version that is enabled on Android only, so that it does not break iOS platform.
cordova plugin add cordova-plugin-crypt-file-android
I hope this helps until the CDVURLProtocol dependency gets replaced with an alternative.

I found a solution and works for me, but I don't know if it's the best solution. I can't wait for an official fix and meanwhile I need my code working. I will change my code when an official fix will be released.
In the file CDVCryptURLProtocol.h, change the code:
//
//  CDVCryptURLProtocol.h
//  CordovaLib
//
//  Created by tkyaji on 2015/07/15.
//
//
//#import <Cordova/CDVURLProtocol.h>

@interface CDVCryptURLProtocol : NSURLProtocol
@end

In the file CDVCryptURLProtocol.m
Define:
NSString* const kCDVAssetsLibraryPrefixes = @"assets-library://";
Then, change the function canInitWithRequest to
+ (BOOL)canInitWithRequest:(NSURLRequest*)theRequest
{
    if ([self checkCryptFile:theRequest.URL]) {
        return YES;
    }

    NSURL* theUrl = [theRequest URL];

    if ([[theUrl absoluteString] hasPrefix:kCDVAssetsLibraryPrefixes]) {
        return YES;
    }

    return NO;
    //return [super canInitWithRequest:theRequest];
}

Add this lines and define function canonicalRequestForRequest
+ (NSURLRequest*)canonicalRequestForRequest:(NSURLRequest*)request
{
    return request;
}

Finally, change function startLoading to
- (void)startLoading
{
    NSURL* url = self.request.URL;

    if ([[self class] checkCryptFile:url]) {
        NSString *mimeType = [self getMimeType:url];

        NSError* error;
        NSString* content = [[NSString alloc] initWithContentsOfFile:url.path encoding:NSUTF8StringEncoding error:&error];
        if (!error) {
            NSData* data = [self decryptAES256WithKey:kCryptKey iv:kCryptIv data:content];
            [self sendResponseWithResponseCode:200 data:data mimeType:mimeType];
        }
    }

    //[super startLoading];
}

Hope it helps!

Any new about when this will fix and available for IOS

Pull request #100 will fix support for cordova-ios 6+ I unfortunately had to change the app-scheme, this may OR may not be an issue with some plugins you have or have written. This is due to the fact that the new method of implementing WKURLSchemeTask's only work on custom schemes.


examples/shader: Add CRT effect

http://slack.net/~ant/libs/ntsc.html

I'll have a go at this.

I think SNES, thanks!

What's going on this?

Any updates?

Hi yes sorry,
I'll try get this out this afternoon, been very busy with work.
On Tue, 8 Dec 2020, 1:44 am Hajime Hoshi<EMAIL_ADDRESS>wrote:

Any updates?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hajimehoshi/ebiten/issues/1359#issuecomment-739961870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSK643N75QYHAPRPUYMGYTSTTS43ANCNFSM4RUZTUJA
.

OK please take your time :-)
As this is not an urgent task, I'll remove the milestone. Of course I'll reapply the milestone when you finish this work.

Was this a duplicate of https://github.com/hajimehoshi/ebiten/issues/2008 ?

Oh right


Add fortis colosseum glory value to varplayer enum

VarPlayer 4130 tracks the personal glory value of the player and is updated upon finishing a colosseum run.

We don't add vars to this file unless they're being used in a core plugin. If you need it for a hub plugin use client.getVarbitValue()

We don't add vars to this file unless they're being used in a core plugin. If you need it for a hub plugin use client.getVarbitValue()

@Felanbird understood, thanks for the reply. I was following the guidance here: https://github.com/runelite/runelite/wiki/VarPlayers,-VarBits,-and-VarClients#using-a-var-in-a-plugin. Should this be updated to specify it is for core plugins only?

We went ahead and removed that section since it's only really supposed to apply to core plugins. You'll be able to use the beforementioned API for your hub plugin without having any API definition created for it.


git reset --hard  ${GST_PLUGIN_VAAPI_REPO_DISPLAY_LOCK_PATCH_HASH} failed

build with dockerfile, can't pass the step:
ARG GST_PLUGIN_VAAPI_REPO_DISPLAY_LOCK_PATCH_HASH=b219f6095f3014041896714dd88e7d90ee3d72dd
git clone https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi.git -b 1.14 --depth 10
git reset --hard ${GST_PLUGIN_VAAPI_REPO_DISPLAY_LOCK_PATCH_HASH}
failed: fatal b219f6095f3014041896714dd88e7d90ee3d72dd

You need more than 10 commits on branch 1.14, try to change shallow clone depth to --depth 50.

@mshabunin thank you for help with this one! @aiopeniot we needed a particular commit with our fix of gstreamer-vaapi in R1 release. Now it's included into common gstreamer-vaapi 1.16 distribution and we got rid of these lines in our Dockerfile. You're welcome to check out our latest R1.2 release


Percentage over 100 shows as empty.

When I pass in a percentage greater than 100, it fills in the bgColor, I thought it would just stay 'full'.
I have values that are bigger than 100, My work around is percent > 100 ? 100 : precent

Good catch! I think we should add a fix for that in the getOffset method:
const getOffset = (val = 0) => Math.round((100 - Math.min(val, 100)) / 100 * diameter);

By using Math.min in there we will prevent values bigger than 100


feat(hardware-ledger): miscellaneous improvements to establishing ledger connection

Context
There is an ongoing lace onboarding flows revamp work. Changes in this PR are part of the improvements to the HW connection implementation
Proposed Solution
Important Changes Introduced

switched the ledger's transport lib to the one based on the navigator.usb Web API. Trezor supports only WebUSB API, so this way we will be able to show both device types in a single native picker.
enabled LedgerKeyAgent to accept USBDevice object and establish the connection using it.
added a listener for a disconnection event which removes a particular connection object from the list of remembered active connections.
method searching and picking matching active connection now tests the matched connection before returning it. In case of any problem the broken connection is removed from the remembered connections list.

@szymonmaslowski Tests in the wallet package are failing.
https://github.com/input-output-hk/cardano-js-sdk/tree/master/packages/wallet/test/hardware/ledger
cmd: yarn test:hw:ledger

@szymonmaslowski Tests in the wallet package are failing. https://github.com/input-output-hk/cardano-js-sdk/tree/master/packages/wallet/test/hardware/ledger cmd: yarn test:hw:ledger

Thanks for pointing me there. I will handle it.

https://github.com/input-output-hk/cardano-js-sdk/pull/1161/commits/a63795ac4987527738ed780433c0d9cab7214e17 ✅


Doesn't pass JDBC version in user agent

Describe the bug
JDBC version is expected to be set in client name. actual result: metabase/1.3.3/unknown (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7; HttpURLConnection; rv:unknown)

Would it be a good idea to follow guidelines for the Agent header? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent
It means that client will add its version on its own and result would look like
metabase/1.3.3  (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7;) ClickHouseJDBC/0.6.1 (HttpURLConnection; Apache HC 5.2.0)

Just in case here is a Java Client issue https://github.com/ClickHouse/clickhouse-java/issues/1698

I will leave this open as a reminder to upgrade the JDBC driver when the fix is out.


Private GridOptions

Hello.
Here https://github.com/ceolter/ag-grid-ng2/blob/master/src/agGridNg2.ts#L19
There is code private gridOptions: GridOptions;
Is it ok, that gridOptions is private?
I couldn't reach api field and was forced to use any type for AgGridNg2 object.
<ag-grid-ng2 #agGrid style="width: 100%;" [style.height]="styleOptions.height + 'px'" class="ag-fresh"
            [gridOptions] = "gridOptions"
            [columnDefs]="columnDefs"
            [rowData]="rowData"
            enableSorting
            enableColResize
            (gridReady) = RegisterApi(agGrid)
        ></ag-grid-ng2>

RegisterApi(agGrid: any) {
        agGrid.gridOptions.api.setViewportDatasource(this.viewportDatasource);
    }

you should not need to touch the gridOptions. the api and columnApi are public on the component.

I've changed prevoiusly mentioned method RegisterApi to
RegisterApi(agGrid : AgGridNg2) {
        console.log(agGrid.api);
        agGrid.api.setViewportDatasource(this.viewportDatasource);
}

console.log(agGrid.api) gave me undefined.
agGrid.api.setViewportDatasource(this.viewportDatasource) threw an exception:
TypeError: Cannot read property 'setViewportDatasource' of undefined
    at AppComponent.RegisterApi (app.component.ts:78)
    at DebugAppView._View_AppComponent0._handle_gridReady_32_0 (AppComponent.template.js:743)
    at eval (core.umd.js:12274)
    at SafeSubscriber.schedulerFn [as _next] (core.umd.js:6712)
    at SafeSubscriber.__tryOrUnsub (Subscriber.ts:240)
    at SafeSubscriber.next (Subscriber.ts:192)
    at Subscriber._next (Subscriber.ts:133)
    at Subscriber.next (Subscriber.ts:93)
    at EventEmitter.Subject._finalNext (Subject.ts:154)
    at EventEmitter.Subject._next (Subject.ts:144)
BrowserDomAdapter.logError @ platform-browser.umd.js:1900

What am I doing wrong?

you get passed an event, not AgGridNg2, so:
RegisterApi(event: any) {
        console.log(event.api);
        agGrid.api.setViewportDatasource(this.viewportDatasource);
}

if missing, just console.log(event) and see what is in it. it should have api and columnApi

Thank you! That helped!


Fix docker setup

Remove obsolete version from docker-compose.yaml sample
Remove ports setting from docker-compose.yaml sample, because this conflicts with network_mode: host and newer docker-compose versions throw an error if both exists in the docker-compose.yaml file

@Neverminda Thanks. I've also ported your change to the german version.


Scrapy-crawlera breaks SplashRequest

If you are using Splash and crawlera middleware the splash requests will not work. I have not tracked the requests but I assume that its trying to access my local host through the proxy.

Hi @eusid
Thank you for notice! We already aware about it and put this issue into our roadmap. However I'm couldn't provide any ETA for the fix arrival.

No problem. I'd be interested in doing the pull request with a little guidance from more experienced scrapy devs.

Sure @eusid Feel free to PR. We would be happy to guide you there!

@eusid if you are interested in following this problem, could you share a code example so we can see where is the problem? Splash works with Crawlera, but of course it needs some extra configuration, as you can see here: https://github.com/scrapy-plugins/scrapy-splash/issues/97

Closing this since no updates, feel free to reopen if a example ever comes around.