Feature/autogenerate doc using jsongenerator

This PR contains the changes needed for automatic generation of document using JsonGenerator tool. This involves adding a
cmake file which contains function DocGenerator().This function implements the logic for doc generation and installation for
wpeframework-plugins. This also adds option for including the cpp interface header file path that will substitute the {cppinterfacedir} tag in JsonGenerator tool command for document generation.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/685/rdkcentral/Thunder

Commit: 4a7549eab66b59fbd593c951401f7d3729b6e548

Report detail: gist

@nkkrishnan2512 please first submit it to the master. We will than cherry-pick it to R2 on request of Comcast.
@sebaszm can you review this.

@pwielders, as you know, we can currently only use/test against the R2 branch. So @nkkrishnan2512 may try this on master, but if there's too many differences that requires significant changes, then we won't be able to test it. We've been doing PRs for R2 before, so why different for this?

Created new PR (https://github.com/rdkcentral/Thunder/pull/693 )for master branch with the autogeneration documentation changes,hence closing this one.


Switch to Admin Bot for post-release tasks

This should allow the 'merge main to beta' post-release process to work.

This PR was included in release version 1.2.0-beta.1 :tada:

This PR was included in release version 1.2.0 :tada:


New ICollection extension method - Swap

Hello
This is my first pull request, this is a new extension method to replace an item in a collection when the item we want to change exists in a collection. Otherwise it won't make any changes.
EDIT: I have noticed that all ICollection methods are  void or bool, so I rewrote the method to be void. I have it on my fork.

Hello @falwickster ,
Thank you for your contribution.
This project is currently still on hold on our side for a few weeks (we have to many requests) but we will certainly look at it when we will be able.
Beside this, I'm this not sure if I like the second implementation or not.
We probably expect when swapping an item, the same position will remain as your first implementation.
Best Regards,
Jonathan

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Bulk Operations •  Dapper Plus •  LinqToSql Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Hello @JonathanMagnan,
Thanks for feedback. I replaced this ICollection method to IList Method, because as far as I know ICollection doesn't store indexes, so swaping items with keeping its position is problematic.
Best Regards

Thank a lot ;)
Best Regards,
Jonathan

Hello @falwickster ,
Sorry for the long waiting, we had to complete the support to .NET Standard first.
Your method has been added
Thank you for your contribution ;)
Best Regards,
Jonathan


Remove optimizations with unoptimized prop

Description
When the unoptimized flag is passed in, this removes the f_auto/q_auto optimizations from the Cloudinary URL.
It will also construct a full Cloudinary URL as the src, otherwise the public ID is attempted to be used, which results in ab broken URL. This usually wouldn't be allowed but it seems the unoptimized flag bypasses the image allowed list.
This doesn't fix this issue occuring when the unoptimized flag is passed in globally inside next.config.js
Issue Ticket Number
Fixes #245

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Fix or improve the documentation
[ ] This change requires a documentation update

Checklist

[ ] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[ ] I have created an issue ticket for this PR
[ ] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] I have performed a self-review of my own code
[ ] I have run tests locally to ensure they all pass
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes needed to the documentation

This is a workaround for the issue https://github.com/vercel/next.js/issues/50764. Should this be noted in a code comment?

@pschaub good call, added a line


Merge --help and --help-experimental, remove defunct options.

Motivation
Various options for the K utilities are split into --help and --help-experimental.
However, this split feels arbitrary.
Several  "experimental" options such as --gen-bison-parser are used very commonly.
A much less commonly used, but related option --bison-lists is "non-experimental.
There are also several options that I suspect are defunct such as --documentation, --add-top-cell and --shutdown-wait-time.
Proposed changes

Merge --help and --help-experimental
Remove (or hide) defunct options
Separate remaining options into sections

This is one possible implementation for kompile.
  Core Options:

    --backend
      Choose a backend. <backend> is one of [llvm|haskell|kore|java|ocaml].
      Each creates the kompiled K definition.
      Default: llvm
    --directory, -d
      Path to the directory in which the output resides. An output can be
      either a kompiled K definition or a document which depends on the type
      of backend. The default is the directory containing the main definition
      file.
    --md-selector
      Preprocessor: for .md files, select only the md code blocks that match
      the selector expression. Ex:'k&(!a|b)'.
      Default: k
    --main-module
      Specify main module in which a program starts to execute. This
      information is used by 'krun'. The default is the name of the given K
      definition file without the extension (.k).
    --syntax-module
      Specify main module for syntax. This information is used by 'krun'.
      (Default: <main-module>-SYNTAX).
    --help, -h
      Print this help message

  Warnings & Debugging:

    --check-races
      Checks for races among regular rules.
      Default: false
    --coverage
      Generate coverage data when executing semantics.
      Default: false
    --debug
      Print debugging output messages and error stack traces
      Default: false
    --debug-warnings
      Print debugging output messages and error/warning stack traces
      Default: false
    --profile-rule-parsing
      Generate time in seconds to parse each rule in the semantics. Found in
      -kompiled directory under timing.log.
      Default: false

    -W
      Enable specific warning categories. Values: [non-exhaustive-match|undeleted-temp-dir|missing-hook-ocaml|missing-hook-java|missing-syntax-module|invalid-exit-code|deprecated-backend|invalid-config-var|future-error|unused-var|proof-lint|useless-rule|unresolved-function-symbol|malformed-markdown|invalidated-cache|unused-symbol]
      Default: []
    -Wno
      Disable specific warning categories.
      Default: []
    --warnings, -w
      Warning level. Values: [all|normal|none]
      Default: NORMAL
      Possible Values: [ALL, NORMAL, NONE]
    --warnings-to-errors, -w2e
      Convert warnings to errors.
      Default: false
    -E
      Perform outer parsing and then stop and pretty print the definition to
      standard output. Useful for converting a K definition into a completely
      self-contained file when reporting a bug.
      Default: false

    --verbose, -v
      Print verbose output messages
      Default: false
    --version
      Print version information
      Default: false

  SMT Options (Java & Haskell backends):

    --ignore-missing-smtlib-warning
      Suppress warning when SMTLib translation fails.
      Default: false
    --smt
      SMT solver to use for checking constraints. <solver> is one of
      [z3|none].
      Default: Z3
      Possible Values: [NONE, Z3]
    --smt-prelude, --smt_prelude
      Path to the SMT prelude file.
    --z3-cnstr-timeout
      The default soft timeout (in milli seconds) of Z3 for checking
      constraint satisfiability.
      Default: 50
    --z3-impl-timeout
      The default soft timeout (in milli seconds) of Z3 for checking
      implication.
      Default: 5000
    --z3-jni
      Invokes Z3 as JNI library. Default is external process. JNI is slightly
      faster, but can potentially lead to JVM crash.
      Default: false
    --z3-tactic
      The solver tactic to use to check satisfiability in Z3.

  Parser Configuration:

    --bison-lists
      Make List and NeList left associative. This is useful for creating Bison
      parsers that use bounded stack space.
      Default: false
    --bison-file
      C file containing functions to link into bison parser.
    --bison-stack-max-depth
      Maximum size of bison parsing stack (default: 10000).
      Default: 10000
    --gen-bison-parser
      Emit bison parser for the PGM configuration variable within the syntax
      module of your definition into the kompiled definition.
      Default: false
    --gen-glr-bison-parser
      Emit GLR bison parser for the PGM configuration variable within the
      syntax module of your definition into the kompiled definition.
      Default: false

  LLVM backend options:

    -I
      Add a directory to the search path for requires statements.
      Default: []
    -O1
      Optimize in ways that improve performance and code size, but interfere
      with debugging and increase compilation time slightly.
      Default: false
    -O2
      Optimize further in ways that improve performance and code size, but
      interfere with debugging more and increase compilation time somewhat.
      Default: false
    -O3
      Optimize aggressively in ways that significantly improve performance,
      but interfere with debugging significantly and also increase compilation
      time and code size substantially.
      Default: false
    -Og
      Optimize as much as possible without interfering with debugging
      experience.
      Default: false
    -ccopt
      Add a command line option to the compiler invocation for the llvm
      backend.
      Default: []
    --no-llvm-kompile
      Do not invoke llvm-kompile. Useful if you want to do it yourself when
      building with the LLVM backend.
      Default: false
    --iterated
      Generate iterated pattern matching optimization; time-consuming but
      significantly reduces matching time.
      Default: false
    --iterated-threshold
      Threshold heuristic to use when choosing which axioms to optimize. A
      value of 0 turns the optimization off; a value of 1 turns the
      optimization on for every axiom. Values in between (expressed as a
      fraction of two integers, e.g. 1/2), control the aggressiveness of the
      optimization. Higher values increase compilation times extremely, but
      also increase the effectiveness of the optimization. Consider decreasing
      this threshold if compilation is too slow.
      Default: 1/2

  Java backend options:

    --transition
      <string> is a whitespace-separated list of tags designating rules to
      become transitions.
      Default: [transition]
    --add-top-cell
      Add a top cell to configuration and all rules.
      Default: false
    --legacy-kast
      Compile with settings based on the old KAST structure
      Default: false
    --maps-as-int-array
      Abstracts map values as an array of ints.
      Default: false
    --step
      Name of the compilation phase after which the compilation process should
      stop.

  OCaml backend options (not supported):

    --heuristic
      A string of single characters representing a sequence of heuristics to
      use during pattern matching compilation. Valid choices are f, d, b, a,
      l, r, n, p, q, _, N, L, R.
      Default: qbaL
    --hook-namespaces
      <string> is a whitespace-separated list of namespaces to include in the
      hooks defined in the definition
      Default: []
    --no-link-prelude
      Do not link interpreter binaries against constants.cmx, prelude.cmx,
      plugin.cmx, lexer.cmx, parser.cmx, hooks.cmx and run.cmx. Do not use
      this if you don't know what you're doing.
      Default: false
    --non-strict
      Do not add runtime sort checks for every variable's inferred sort. Only
      has an effect with `--backend ocaml`.
      Default: false
    --ocaml-dump-exit-code
      Exit code which should trigger a dump of the configuration when using
      --ocaml-compile.
    --ocaml-serialize-config
      <string> is a whitespace-separated list of configuration variables to
      precompute the value of
      Default: []
    --packages
      <string> is a whitespace-separated list of ocamlfind packages to be
      included in the compilation of the definition
      Default: []
    --reverse-rules
      Reverse the order of rules as much as possible in order to find most
      nondeterminism without searching.
      Default: false
    --gen-ml-only
      Do not compile definition; only generate .ml files.
      Default: false

  Other Tweaks:

    --no-exc-wrap
      Do not wrap exception messages to 80 chars. Keep long lines.
      Default: false
    --no-expand-macros
      Do not expand macros on initial configurations at runtime. Will likely
      cause incorrect behavior if any macros are used in this term.
      Default: false
    --no-prelude
      Do not implicitly require prelude.md.
      Default: false
    --opaque-klabels
      Declare all the klabels declared by the following secondary definition.
    --shutdown-wait-time
      If option is set, a shutdown hook will be registered that, once invoked,
      interrupts the main thread and waits its termination. The wait time is
      the argument of this option, in format like 10ms/10s/10m/10h. Useful if
      K is interrupted by Ctrl+C, because it allows the backend to detect
      interruption and print diagnostics information. Currently interruption
      detection is implemented in Java Backend. If K is invoked from KServer
      (e.g. Nailgun), the option is ignored.
    --timeout
      If option is set, timeout for this process, in format like
      10ms/10s/10m/10h. Using this option is preferred compared to bash
      timeout command, which has known limitations when invoked from scripts.
    --cache-file
      Location of parse cache file. Default is $KOMPILED_DIR/cache.bin.
    --emit-json
      Emit JSON serialized version of parsed and kompiled definitions.
      Default: false
    --floats-as-po
      Abstracts floating-point values as a partial order relation.
      Default: false
    --heat-cool-by-strategies
      Control heating and cooling using strategies.
      Default: false
    --k-cells
      Cells which contain komputations.
      Default: [k]
```

Documentation
-------------

None

Potential Alternatives/Work-arounds
-----------------------------------

Status quo

Testing Approach
----------------

None

We should remove the distinction, and audit the existing options for removal.


Remote Content Library - Uses the "Site System Installation Account" if specified.

Hello, one thing that is not called out here that should be mentioned is that if you use a Site System Installation Account that is not the machine account, it will use the site installation account instead of your site server machine account to attempt to login to your remote content library and access the files. This is very problematic when you are using a DMZ account as the site system installation account as you either have to give perms to the content library to the DMZ account, have to give the site server machine account access into the DMZ or have to create a local account in the DMZ and remote content library with the necessary perms.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92260657-2102-c15f-a844-5fa3aff64aae
Version Independent ID: a4597d2d-9441-61f2-718d-c0a54a46d3fd
Content: The content library - Configuration Manager
Content Source: sccm/core/plan-design/hierarchy/the-content-library.md
Product: configuration-manager
Technology: configmgr-other
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @SCCMWalker for the feedback. What version of ConfigMgr are you seeing this behavior? It might be a product bug, I'm checking with engineering to confirm.

1806, I am talking with someone on the Premiere Support team and they indicate this is a known behavior. Also I posted elsewhere and Kerwin confirmed this is the expected behavior.

Hi, @SCCMWalker, This is a known behavior, but the issue isn't very common. For that reason,  we recently documented the behavior in a KB article rather than the documentation. #please-close


Add hardware version to worker VM

Description

When a worker VM is created in the process of creating a volume snapshot on Vmware, the hardware version of the worker VM will be set to the highest supported hardware version of the hypervisor. If you have hypervisors of different versions in a cluster and set the "Default vm compatibility" to a lower version, the worker VM should use same version as the original VM instance,
This PR sets the worker VM hardware version to the same version as the original VM instance.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

This has been tested by doing the following:

create an instance
take a snapshot
check the hardware version of the worker vm created in Vsphere.

@blueorangutan package

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1968

@blueorangutan package

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian.

@Spaceman1984 unsupported parameters provided. Supported mgmt server os are: centos6, centos7, centos8, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74

@blueorangutan test centos7 vmware-65-u2

@blueorangutan test centos7 vmware-65u2

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan package

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✔centos8 ✔debian. JID-1994

@blueorangutan package

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✖debian. JID-1996

@blueorangutan test centos7 vmware-65-u2

@Spaceman1984 unsupported parameters provided. Supported mgmt server os are: centos6, centos7, centos8, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74

@blueorangutan test centos7 vmware-65u2

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan test centos7 vmware-65u2

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Trillian test result (tid-2741)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 72722 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4321-t2741-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 80 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
636.51
test_vpc_redundant.py

test_04_rvpc_network_garbage_collector_nics
Error
3921.42
test_vpc_redundant.py

test_04_rvpc_network_garbage_collector_nics
Error
3921.47
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
0.03
test_vpc_redundant.py

ContextSuite context=TestVPCRedundancy>:teardown
Error
0.05
test_vpc_redundant.py

@Spaceman1984 I changed the title to what I think better descibes what is intended. please have a look.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2107

@Spaceman1984 pl check, build failing due to possibly code or unit test failure

The internal branch work is LGTM - if this PR is a duplicate of the same code - then let's assume LGTM.

The branch builds fine locally, must be some kind of merge issue. Looking into it.

@blueorangutan package

I was advised that Alex will test cc @rhtyd

@blueorangutan package

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2108

@blueorangutan test centos7 vmware-65u2

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Trillian test result (tid-2877)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39603 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4321-t2877-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
397.81
test_vpc_redundant.py

LGTM


Eikon battle in ultrawide

When you controll Pheanix in the castle assault toward the end of the demo and you have to manually aim at Ifirt, the aim reticle is off probably because of the ultrawide fix, you actually need to aim around 5CM left of ifrit to have the reticule confirm that you are on target (it changes from a cross to a circle)
playing at 3440x1440.

This is a known issue. I've yet to get to that point of the game so I haven't had a chance to try and fix it yet. Once I get there and have more information, I'll come back and update this issue.

Thank you so much for all your dedication and work to get that fix up so fast !
Random question, do you recognize the engine the game is running on ? Is it a SE engine from another game heavily modified or a new one entirely ?

If it's not possible to fix the offset at ultra wide resolutions, it would be great if there was a way to have it revert to 16:9 for those battles -- either automatically or via a hotkey.
At 32:9, the offset becomes way too large to try and work around, and unfortunately the pause menu doesn't have the option for switching resolutions during the fight.

If it's not possible to fix the offset at ultra wide resolutions, it would be great if there was a way to have it revert to 16:9 for those battles -- either automatically or via a hotkey.
At 32:9, the offset becomes way too large to try and work around, and unfortunately the pause menu doesn't have the option for switching resolutions during the fight.

From what a friend tell me about the PS5 version. All other fight are more like QTE and less shooting, that's only when controlling the phoenix in the beginning. So hopefully it won't be needed . . .

Fixed in v0.7.3


Required flag is reset for array items.

For some reason the schema for array item is enforced in such way that array items become required.
I created a copy of the originating schema and reset required flag for it. Test update was necessary.

lgtm


Add flake8 extension to restrict import alias

Add flake8 extension to restrict if import alias is allowed and what import alias to use. Fix import alias across the project.

Codecov Report

Merging #139 into master will increase coverage by <.01%.
The diff coverage is 98.7%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   94.14%   94.14%   +<.01%
==========================================
  Files          40       40
  Lines        2409     2410       +1
  Branches      462      462
==========================================
+ Hits         2268     2269       +1
  Misses         84       84
  Partials       57       57

Impacted Files
Coverage Δ

orquesta/specs/mock/models.py
83.33% <100%> (ø)
:arrow_up:

orquesta/expressions/yql.py
90% <100%> (ø)
:arrow_up:

orquesta/specs/native/v1/models.py
97.92% <100%> (ø)
:arrow_up:

orquesta/composers/mistral.py
88.67% <100%> (ø)
:arrow_up:

orquesta/composers/native.py
85.71% <100%> (ø)
:arrow_up:

orquesta/specs/mock/__init__.py
100% <100%> (ø)
:arrow_up:

orquesta/utils/parameters.py
100% <100%> (ø)
:arrow_up:

orquesta/specs/mistral/v2/tasks.py
95.2% <100%> (ø)
:arrow_up:

orquesta/specs/mistral/v2/policies.py
100% <100%> (ø)
:arrow_up:

orquesta/utils/jsonify.py
100% <100%> (ø)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aac022...a8f5868. Read the comment docs.


Possible error in KvValue type definition

Currently, in the file src/types.ts, KvValue is defined as
export type KvValue =
  | ...
  | Set<unknown>
  | Map<unknown, unknown>
  | ...

shouldn't it be defined as the following instead ?
export type KvValue =
  | ...
  | Set<KvValue>
  | Map<KvValue, KvValue>
  | ...

Or maybe something more restrictive for the key of a Map ?

You are definitely right, thanks for pointing that out! After some quick testing, I think KvValue is restrictive enough for the map keys. I have updated the module (v0.6.1) with your suggested fix.


Address error caused by use of stability attribute

These are no longer allowed outside the standard library as of rust beta
3 and cause, "error: stability attributes may not be used outside of the
standard library", if used.

Thank you for the pull request! I fixed this error before I saw your PR (it was hiding under a pile of bug reports on other projects), but I really appreciate the time you took to figure it out and send it.

Oh, and by the way, the uchardet library now relies exclusively on stable APIs and it's compatible with Rust 1.0.0-beta.4. So with any luck, it won't need any further compatibility updates, and you can just use the version from crates.io.

Great, thanks Eric


Providing option for a consent modal

Forking off from the discussion here Would this work as a library the next version of Drupal uses?.
We are planning to introduce a consent modal (detailed discussion here to address privacy concerns.
The consent system will integrate with the tool called Klaro.
We can have something like when the chatbox opens, the user will be prompted to give consent to data being stored/used. If the user declines, then the chatbox will close, and if they approve, then they can continue with using the chatbot.
There is already a part of feature that is there in Deepchat which can be used for the consent modal. But that is only triggered in a particular case.
So is it possible to have something like this?

Hi @vivekpan27.
The functionality that you are describing should be implemented by the platform and not Deep Chat itself as this is very much a form of meta  state that is strongly tied and controlled by the project that is implementing it.
Having read the discussion that you have referenced, the comment here seems to also be in agreement.

Hey @OvidijusParsiunas,
I get what you are saying and agree that too that this consent modal feature should be implemented by the platform.

Having read the discussion that you have referenced, the comment here seems to also be in agreement.

What the commenter is saying here is that Drupal CMS will already be having Klaro enabled so we don't need the consent modal for it.
And the issue summary is concerned with Drupal CMS only. So for that issue, we do not need the modal.
But vanilla Drupal sites might not have Klaro installed, so if someone installs the Deepchat module there, the consent modal would be required in the chat window.
So if we have the option of having something like this  triggerred as and when required, then we can populate it's HTML ourselves. Then we would be able to add the consent form there.

The existing internal modal functionality doesn't provide the ability to add custom HTML.
Additionally, the particular use-case you have outlined is highly specific to your scenario and I don't foresee any other projects requiring such custom modal behaviour as it is something that should always be controlled by the parent app.
I want to help you, but since this particular functionality is not something that other projects would need, I simply can't add it to the official Deep Chat API as our goal is to keep it as lean and standardised as possible.
Having said this, you could potentially go in another route and use the introPanel which will allow you to add custom HTML and do what you need to do. Ofcourse, you will need to disable the submit button, which you can do via the disableSubmitButton method. Hopefully this helps you!


Help command is hard to find

As the other commands are onetime init, onetime time, I'd expect to be able to do onetime help. Having to do onetime --help feels a bit odd compared to the rest of the commands.

disagree. -h and --help are well estabilished conventions for clis


fix for 01-HelloWorld example

fixed print statement and added setCursor to avoid cut-off text

Wow!


Document Comparison toolkit is not working

System Info
First, Thank you so much for your work on Langchain, it's very good.
I am trying to compare two documents following  the guide from langchain https://python.langchain.com/docs/integrations/toolkits/document_comparison_toolkit
I have done exactly the same code:
I have one class to use for the args_schema on the tools creation:
class DocumentInput(BaseModel):
    question: str = Field()

I have created the tools :
tools.append(
                   Tool(
                       args_schema=DocumentInput,
                       name=file_name,
                       description=f"useful when you want to answer questions about {file_name}",
                       func=RetrievalQA.from_chain_type(llm=llm, retriever=retriever)
                   )
               )

agent = initialize_agent(
       agent=AgentType.OPENAI_FUNCTIONS,
       tools=tools,
       llm=llm,
       verbose=True,
   )

And here I am getting the error:
"1 validation error for Tool\nargs_schema\n  subclass of BaseModel expected (type=type_error.subclass; expected_class=BaseModel)",
I have changed the args_schema class to :
from abc import ABC
from langchain.tools import BaseTool
from pydantic import Field

class DocumentInput(BaseTool, ABC):
    question: str = Field()

And now the error, I am getting is:
("Value not declarable with JSON Schema, field: name='_callbacks_List[langchain.callbacks.base.BaseCallbackHandler]' type=BaseCallbackHandler required=True",)
I only want to compare the content between two documents, Do you have some example to compare two files which is working? Maybe I am calling wrong the creation of the tools.
Who can help?
@yajunDai
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[X] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
I have follow exactly the guide for ->https://python.langchain.com/docs/integrations/toolkits/document_comparison_toolkit to compare two documents, and I am getting the error :
"1 validation error for Tool\nargs_schema\n  subclass of BaseModel expected (type=type_error.subclass; expected_class=BaseModel)",
The args_schema class is :
class DocumentInput(BaseModel):
    question: str = Field()

I trying to create the tools :
tools.append(
                   Tool(
                       args_schema=DocumentInput,
                       name=file_name,
                       description=f"useful when you want to answer questions about {file_name}",
                       func=RetrievalQA.from_chain_type(llm=llm, retriever=retriever)
                   )
               )

and here I am getting the error:
"1 validation error for Tool\nargs_schema\n  subclass of BaseModel expected (type=type_error.subclass; expected_class=BaseModel)",
After that I am doing this, but I can't get to initialize_agent
 agent = initialize_agent(
        agent=AgentType.OPENAI_FUNCTIONS,
        tools=tools,
        llm=llm,
        verbose=True,
    )

It's exactly the guide for the Document comparsion on Langchain
Expected behavior
Expected behaviour, that I can compare the content for two documents without error

Thank you so much for your answer,
The version of LangChain I am using -> 0.0.275
The version of Python -> 3.8
Any other relevant packages or libraries you're using
And the version fo the rest of the packages are:
Package            Version

aiohttp            3.8.5
aiosignal          1.3.1
annotated-types    0.5.0
anyio              3.7.1
async-timeout      4.0.3
attrs              23.1.0
basf-auth          2.9.0
cachetools         4.2.4
certifi            2023.7.22
cffi               1.15.1
charset-normalizer 3.2.0
click              8.1.7
colorama           0.4.6
cryptography       41.0.3
dataclasses-json   0.5.14
exceptiongroup     1.1.3
faiss-cpu          1.7.4
fastapi            0.103.0
frozenlist         1.4.0
greenlet           2.0.2
gunicorn           21.2.0
h11                0.14.0
httpcore           0.17.3
httptools          0.6.0
httpx              0.24.1
idna               3.4
itsdangerous       2.1.2
langchain          0.0.275
langsmith          0.0.27
loguru             0.7.0
marshmallow        3.20.1
multidict          6.0.4
mypy-extensions    1.0.0
nose2              0.13.0
numexpr            2.8.5
numpy              1.24.4
openai             0.27.9
websockets         11.0.3
wheel              0.38.4
win32-setctime     1.1.0
yarl               1.9.2
I am using AzureOpenAI
model=gpt-35-turbo-16k
version=2023-07-01-preview
I can upload the code in Github,if it can help
thanks

same issue for me:
pydantic.v1.error_wrappers.ValidationError: 1 validation error for Tool
args_schema
subclass of BaseModel expected (type=type_error.subclass; expected_class=BaseModel)

same issue with me
python 3.10
pydantic 2.3.0
pydantic-core 2.6.3
langchain 0.0.281

Hello,
I am still having the same problem, Can anyone get some news about this problem? Have you got to compare two documents?
Thanks

I also had the problem until today. For me the problem was the new pydantic==2.4.2. I downgraded to pydantic==1.10.12 and it works for me with langchain==0.0.304.

Hello,
I am still having the same problem, Can anyone get some news about this problem? Have you got to compare two documents?
Thanks

I was also facing the same issue that got resolved by downgrading pydantic to pydantic==1.10.0  and using langchain==0.0.287 version. It got sorted

Still having the same issue with the latest langchain

!pip install pydantic==1.10.13
I meet the same problem, and I solve it  by run the above code.
By the way, my previous pydantic version is 2.3.0 which is not ok.

Facing same issue, would like to stick to pydantic version 2.4.2

Encountering the same issue here.  The examples in the documentation don't work.  If you start from a clean virtualenv, install langchain, and then run code from the documentation, it fails:
https://python.langchain.com/docs/modules/agents/tools/custom_tools
class SearchInput(BaseModel):
    query: str = Field(description="should be a search query")

@tool("search", return_direct=True, args_schema=SearchInput)
def search_api(query: str) -> str:
    """Searches the API for the query."""
    return "Results"

throws the error:
pydantic.v1.error_wrappers.ValidationError: 1 validation error for StructuredTool
args_schema
  subclass of BaseModel expected (type=type_error.subclass; expected_class=BaseModel)

Reverting Pydantic back to a 1.x version as mentioned above fixes it:
pip install pydantic==1.10.13

Pydantic is the main issue: Pydantic has released v2 version on June 30, 2023 and langchain integration is not compatible

Same issue: '1 validation error for Tool\nargs_schema\n  subclass of BaseModel expected (type=type_error.subclass; expected_class=BaseModel)'
python: 3.10.5
langchain: 0.0.340
pydantic: 1.10.13
####### schema_code #######
from langchain.tools import BaseTool
from langchain.tools.base import ToolException
from pydantic import BaseModel, Field
from typing import Type, Optional
from requests import post
import logging

class AddLeadHubSpotSchema(BaseModel):
    lead_name: Optional[str] = Field(description="should be a string with full name of the lead")
    lead_email: Optional[str] = Field(description="should be a string with email of the lead")
    lead_mobile_phone: Optional[str] = Field(description="should be a string should be a string with mobile phone of the lead")
    hubspot_api_url: Optional[str] = Field(description="should be a string")
    hubspot_api_access_key: Optional[str] = Field(description="should be a string")
    hubspot_api_secret_key: Optional[str] = Field(description="should be a string")

####### instantiation_code #######
try:

    from langchain.agents import Tool

    args_schema = AddLeadHubSpotSchema(
        hubspot_api_url='https://url-passada-via-args-schema.com',
        hubspot_api_access_key='access-key-passado-via-args-schema',
        hubspot_api_secret_key='secret-key-passada-via-args-schema',
    )

    add_lead_hubspot_tool = AddLeadHubSpotTool()

    tool = Tool(
                name=add_lead_hubspot_tool.name,
                func=add_lead_hubspot_tool.run,
                description=add_lead_hubspot_tool.description,
                return_direct=add_lead_hubspot_tool.return_direct,
                handle_tool_error=True,
                args_schema=args_schema,
            )

    return tool

Hi everyone! Need some help in Langchain Documnet Comparsion (https://python.langchain.com/docs/integrations/toolkits/document_comparison_toolkit). The agent is responsding to general question, like how to make a pizza. How to restrict the agent to respond out of my vector store. Tried to add the prompt template for rag from langchain hub. Not working. Is there any other way to restrict. Thanks in advance.
tools = []
files = [
# https://abc.xyz/investor/static/pdf/2023Q1_alphabet_earnings_release.pdf
{
"name": "alphabet-earnings",
"path": "/Users/harrisonchase/Downloads/2023Q1_alphabet_earnings_release.pdf",
},
# https://digitalassets.tesla.com/tesla-contents/image/upload/IR/TSLA-Q1-2023-Update
{
"name": "tesla-earnings",
"path": "/Users/harrisonchase/Downloads/TSLA-Q1-2023-Update.pdf",
},
]
for file in files:
loader = PyPDFLoader(file["path"])
pages = loader.load_and_split()
text_splitter = CharacterTextSplitter(chunk_size=1000, chunk_overlap=0)
docs = text_splitter.split_documents(pages)
embeddings = OpenAIEmbeddings()
retriever = FAISS.from_documents(docs, embeddings).as_retriever()
# Wrap retrievers in a Tool
tools.append(
    Tool(
        args_schema=DocumentInput,
        name=file["name"],
        description=f"useful when you want to answer questions about {file['name']}",
        func=RetrievalQA.from_chain_type(llm=llm, retriever=retriever),
    )
)

llm = ChatOpenAI(
temperature=0,
model="gpt-3.5-turbo-0613",
)
agent = initialize_agent(
agent=AgentType.OPENAI_FUNCTIONS,
tools=tools,
llm=llm,
verbose=True,
)
agent({"input": "did alphabet or tesla have more revenue?"})

Pydantic new version has compatibility issues with langchain. simplest way is to change the pydantic import as below
'''
from pydantic.v1 import BaseModel
'''
reference:


Fix #537: Make sure class properties are initialized in the right order

Testcase from #537 adopted.
Previously the constructor code of the parent class was appended,
because the parents constructor method was simply reused.
This explicitly prepends only the statements.

Thank you
Awesome work :cat:


Spam-Ham Classification

💥 Proposal
I would like to apply machine learning and NLP techniques to classify an email as Spam or Ham.
Dataset: From Kaggle
Technology Stack: Python (Jupyter Notebook)
Goal: Provide bases to start with NLP via classifying mail into spam and Ham

@Juhibhojani Please provide the dataset link

Dataset Link: https://www.kaggle.com/datasets/uciml/sms-spam-collection-dataset
(Source: Kaggle)

@Juhibhojani  - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!  Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.

Hey, I have performed a classification using the SVM algorithm and Tf-Idf vectorizer, so should I add this project to the deep learning or machine learning directory?
And  to confirming, the name should be SVM_Spam-Ham.ipynb


Agent Authentication User

Hello
We just received the comms that agent authentication is ready for test on the Live platform.  Can HMRC provide some credentials for us to test this with?
Thanks
Pauline

Hi Pauline,
Thanks for your query, will check our team on what comms went out and will get back to you with the answer.
Regards,
Chandra

Hi Pauline,
Our team have been advised that the Agent authentication communication which was sent out is about the 'Married Allowance API' that is now in production and can be accessed by individuals or agents.
MTDfsB Self Assessment API's https://www.tax.service.gov.uk/api-documentation/docs/api#self-assessment-api are NOT yet enabled for Agents.
Regards
Rakesh

I'm going to close this issue due to inactivity. Please open another if you would like to discuss this further.
Thanks,
Jacob


Adding terminator support

python script to add new profile / change terminator default profile;
integration of said script in apply-colors.sh.

Hi, thank you for the pull request.
A couple of things.
First the file should be call apply-terminator.sh
Second I'm not sure if it is going to work, please look this reference
https://github.com/Gogh-Co/Gogh/blob/master/apply-colors.sh#L485
Thanks


update cni config version

See: https://github.com/containerd/containerd/pull/4308/files#diff-bc3ee81027bc2e27f4df56465b4290e1R37
https://github.com/containerd/containerd/pull/4308
Signed-off-by: Mike Brown<EMAIL_ADDRESS>

@aojea FYI

nice, ecosystem moving up :+1:


Use of astropy.model.tabular2D

asdf unconditionally uses astropy.model.tabular2D, which is only introduced in the not yet released version 1.3 of astropy. With the current version 1.2.1 of astropy, the tests will consequently fail:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "asdf/__init__.py", line 37, in <module>
    from .asdf import AsdfFile
  File "asdf/asdf.py", line 15, in <module>
    from . import block
  File "asdf/block.py", line 26, in <module>
    from . import stream
  File "asdf/stream.py", line 6, in <module>
    from .tags.core import ndarray
  File "asdf/tags/__init__.py", line 11, in <module>
    from . import transform
  File "asdf/tags/transform/__init__.py", line 10, in <module>
    from .tabular import *
  File "asdf/tags/transform/tabular.py", line 15, in <module>
    class TabularType(TransformType):
  File "asdf/tags/transform/tabular.py", line 18, in TabularType
    types = [astropy.modeling.models.Tabular2D,
AttributeError: 'module' object has no attribute 'Tabular2D'

Please wrap the according code with some version check of astropy, or depend on a minimal version of astropy (once the 1.3 is released). Note however that relying on the newest features will make backporting to older OS versions more difficult (since astropy needs to be backported first).

Duh! I'll make 1.2.1 fixing this. Thanks for the note!

@olebole  I've uploaded 1.2.1 to pypi. It runs with older versions of astropy.

Thanks, it is now uploaded to Debian as well.


Hide Gmail download icon no longer works

Looks like this happened when Google updated Gmail in Sep/Oct. They added support for classes and id's but removed attribute selector support. As a result this code no longer works.
* img[tabindex="0"] + div{
	/* Hide download icon in Gmail */
	display: none !important;
}

Instead, using img + div > div works. But obviously that can be dangerous since it's so general so adding a warning would be a good idea (or maybe not even include it at all?). Alternatively you can link the image with <a> or add a class to target it better.

Hi @jkupczak,
Unfortunately that snippet is outdated.
You can try methods listed in this blog post.
Thanks,
Alen :)


Warning Fixed :  tsdoc-param-tag-missing-hyphan

In src/common/Page.ts
After running "npm run generate-docs",  we get warning "@param block should be followed by a parameter name and then a hyphan" in line 1052, 1055, 1058.
I corrected the syntax of the @param TSDoc comment.

@googlebot I signed it!
On Mon, Apr 5, 2021 at 6:25 PM google-cla[bot] @.***>
wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fpuppeteer%2Fpuppeteer%2Fpull%2F7056
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/puppeteer/puppeteer/pull/7056#issuecomment-813378333,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN7AYMX6WNDOQZGKCD6MPOLTHGXKXANCNFSM42MYOTIQ
.

@tasneemkoushar thank you for your efforts here but it looks like another PR that's merged has fixed it. If you'd like to contribute any more fixes that'd be great - let me know if I can help :)

Okay no issue, Sure I will try to fix other warnings.
On Tue, Apr 6, 2021 at 8:02 PM Jack Franklin @.***>
wrote:

@tasneemkoushar https://github.com/tasneemkoushar thank you for your
efforts here but it looks like another PR that's merged has fixed it. If
you'd like to contribute any more fixes that'd be great - let me know if I
can help :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/puppeteer/puppeteer/pull/7056#issuecomment-814169657,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN7AYMR2JCS4WGCB6P6GSULTHMLQRANCNFSM42MYOTIQ
.

I pushed PR regarding some issue, the PR passed is not able to pass
run-checks for Linux, can you please help me to figure out what to do to
solve this?
I really want to contribute to puppeteer and be a part of it.
On Tue, Apr 6, 2021 at 2:40 PM Tasneem Koushar @.***>
wrote:

Okay no issue, Sure I will try to fix other warnings.
On Tue, Apr 6, 2021 at 8:02 PM Jack Franklin @.***>
wrote:

@tasneemkoushar https://github.com/tasneemkoushar thank you for your
efforts here but it looks like another PR that's merged has fixed it. If
you'd like to contribute any more fixes that'd be great - let me know if I
can help :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/puppeteer/puppeteer/pull/7056#issuecomment-814169657,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN7AYMR2JCS4WGCB6P6GSULTHMLQRANCNFSM42MYOTIQ
.

My PR is https://github.com/puppeteer/puppeteer/pull/7067
On Wed, Apr 7, 2021 at 4:19 PM Tasneem Koushar @.***>
wrote:

I pushed PR regarding some issue, the PR passed is not able to pass
run-checks for Linux, can you please help me to figure out what to do to
solve this?
I really want to contribute to puppeteer and be a part of it.
On Tue, Apr 6, 2021 at 2:40 PM Tasneem Koushar <
@.***> wrote:

Okay no issue, Sure I will try to fix other warnings.
On Tue, Apr 6, 2021 at 8:02 PM Jack Franklin @.***>
wrote:

@tasneemkoushar https://github.com/tasneemkoushar thank you for your
efforts here but it looks like another PR that's merged has fixed it. If
you'd like to contribute any more fixes that'd be great - let me know if I
can help :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/puppeteer/puppeteer/pull/7056#issuecomment-814169657,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN7AYMR2JCS4WGCB6P6GSULTHMLQRANCNFSM42MYOTIQ
.


Particle marginal Metropolis-Hastings (PMMH)

Hi all !
Have you already thought of implementing PMMH ?
I'm interested in implementing it !
The syntax could be the following (with the same notations as in the article):
sampler1 = PMMH(nb_samples, SMC(1, :x) , :θ)
sampler2 = PMMH(nb_samples, SMC(1, :x) , (:θ, proposal))

with proposal being a distribution type (with rand and pdf functions available).
Here, sampler1 would be by default defining q(θ'|θ) as the prior and sampler1 defining q = proposal .

Have you already thought of implementing PMMH ?
I'm interested in implementing it !

Sounds great - we thought about it but didn't have the time to implement it. We'll do our best to help.

The syntax could be the following (with the same notations as in the article):
sampler1 = PMMH(nb_samples, SMC(1, :x) , :θ)
sampler2 = PMMH(nb_samples, SMC(1, :x) , (:θ, proposal))

This looks very reasonable!

Hi @yebai !
I'm working on PMMH, and I'm wondering why cannot we use SMC inside a Gibbs sampler (but only PG and Hamiltonian) ? Is it because you didn't adapt SMC (with  vi[getretain(vi, 0, spl)] = NULL and such) or is there a theoretical issue ?

I'm working on PMMH, and I'm wondering why cannot we use SMC inside a Gibbs sampler (but only PG and Hamiltonian) ? Is it because you didn't adapt SMC (with vi[getretain(vi, 0, spl)] = NULL and such) or is there a theoretical issue ?

It's because of theoretical reasons. SMC is not a valid MCMC kernel, combining SMC with HMC would lead to a biased MCMC sampler.

@yebai Is this the same reason why PG use Cond-SMC as a MCMC kernel?

@yebai Is this the same reason why PG use Cond-SMC as a MCMC kernel?

yes that's right.

Thanks for the reminding @yebai.
Otherwise, could you explain please why if spl.alg.gid != 0 link!(vi, spl) end  and  if spl.alg.gid != 0 invlink!(vi, spl) end is necessary in HMC ?

@emilemathieu The transformation is performed only when HMC is used in Gibbs (indicated by the condition spl.alg.gid != 0). When HMC is used together with other samplers, it is necessary to make sure HMC works in the transformed space (say R). For example, when HMC is used together with PG, PG only works in the original space (say X) but HMC needs to work in the transformed space (R), thus the transformation X -> R and R -> X is needed.
For standalone HMC, we can just run HMC in transformed space R all the time (there is one transformation done before the iterations if it is this case).

Thanks @xukai92 !
Would you have some references about theoretically why is this space transformation is needed ?
Do you whether I should do this in PMMH ?

Moreover I have issues running tests, I get: LoadError: UndefVarError: check_numerical not defined.
Shouldn't we add in src/Turing.jl
export check_numerical

?

PR for review: https://github.com/yebai/Turing.jl/pull/339

I've pushed on https://github.com/yebai/Turing.jl/pull/339 the version allowing for parameters' proposal.

I have pushed a version of PMMH that handles user-defined proposals in PR https://github.com/yebai/Turing.jl/pull/339.

PR https://github.com/yebai/Turing.jl/pull/339 has been merged.

Hi all !
In the current implementation of PMMH, a small modification would allow to use it as a PIMH algorithm.
For reminder, PMMH targets p(theta, x_{1:T} | y_{1:T}) whereas PIMH targets p(x_{1:T} | y_{1:T}) (global parameters theta are considered as deterministic and fixed).
It would be contracted as:
pmmh = PMMH(100, SMC(20, :v1), :v2)
pimh = PMMH(100, SMC(20))

The only change in the code is:
if !isempty(spl.alg.space) vi = model(vi=vi, sampler=spl) end

which means that if there is no global parameters, the theta* ~ p(.|theta) proposal is not ran.
Do you think a new PIMH type should created for transparency: ?
pimh = PIMH(100, SMC(20))

or is it ok to use PMMH for both cases ?
Best,
Emile

Eventually, several modifications were needed, I pushed a PR https://github.com/yebai/Turing.jl/pull/354.
Feedbacks are welcomed.
Best,
Emile

@emilemathieu Yes for transparency, it would be better to have a typealias PIMH referencing PMMH.

@yebai
such as typealias PIMH PMMH ?
Or something like
abstract PMH
immutable PIMH <: PMH ...
immutable PMMH <: PMH ...

and then construct PIMH as a special case of PMMH ?

PR https://github.com/yebai/Turing.jl/pull/369

Closed by #369


make the dqn policy a property so that it can be switched more easily

Addresses an issue brought up in #18


Multi-output New payload

Thanks! I think this might be related to #22 ?

Point 2 of #22 , I think

I came from from #24.  Supposedly this fixes that, however I can't figure out how to make this fix work.  It doesn't look like there's been a release since the Multi-output New payload was merged into the master.  I even tried downloading the code directly and overwriting the node-module files, but that didn't work either.  What's needed to implement this "fix"?

I even tried downloading the code directly and overwriting the node-module files, but that didn't work either. What's needed to implement this "fix"?

I have to admit I cannot remember what this issue was about, but there's a much better way to roll with node modules pulled from github: you can use the git URL directly in your package.json, or switch an installed module over to the latest github version with NPM like so:
npm uninstall some_module; npm install https://github.com/some_user/some_module.git

Keep in mind though that being on the bleeding edge can be more trouble than it's worth...


Add progress bar when downloading file

Issue Type: Feature Request
My workspace is remote and I use 'Remote - SSH' extension.
In vscode 'Explorer', when I right click on a file and download, it downloads to my local laptop, but there is no progress indication on how much the file has downloaded. It will be nice if there is a progress bar for the ongoing download.
Version: 1.64.2 (user setup)
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:02:28.252Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000
VS Code version: Code 1.64.2 (f80445acd5a3dadef24aa209168452a3d97cc326, 2022-02-09T22:02:28.252Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No
Remote OS version: Linux x64 5.4.0-96-generic

Duplicate of #111580


Update to support Webhook responses

From telegram bot api official page:
Recent changes
August 29, 2015
You can now make new requests when responding to webhook updates.
Would be cool to have a helper method to ease this task.

Responding to webhooks really doesn't seem like a great idea, it doesn't let you ever get the status of that response. Having to make an extra request really shouldn't affect anything that significantly.


Pattern for matching and removing file number prefixes can be improved

Related to #6

In fact, I think it can be removed...relying on filenaming for increasing amounts of logic was getting funky. OK to close?


Three finger gesture support

Really like the app, just would like one addition. Using the normal function keys, it works perfectly. But when I use a three finger swipe (up to increase volume, down to decrease, left for previous, and right for next), the old UI comes in. Since I almost always use the three finger swipe, I don't really get to experience the app. Can you please add a switch so that three finger swipes enable the flyout?

This is a duplicate or a part of #4
See https://github.com/ShankarBUS/ModernFlyouts/issues/4#issuecomment-665840978
Unfortunately, Windows completely makes it impossible to hook the trackpad swipes and gestures. I can't answer whether it's possible or not.
@ADeltaX FYI (sorry for disturbing you 😅)

Closing it as a duplicate of #4


Theme for shape

Hi,
Json theme for shape is not working. Can you please update the code or provide me a fix for it?

I have just tested it and it seems like all features under line, fill and rotation work fine. Can you explain which specific aspect of shape formatting is not functional for you?


Initial surface for module API (enough for an ILAG module)

This layer is intended to represent the actual module API surface for element-web (technically react-sdk). We extract this to a dedicated package for a few reasons:

It makes determining module compatibility trivial: compare the module-api dependency of the element-web layer and the module with semver to see if it'll work.
This package is mostly just types and very little code, making for a small dependency. A module would not need to pull in the entirety of the react-sdk or similar just to make itself compatible.
With a dedicated package, modules are less likely to reach into implementation-specific code to "go around" the module API surface. For example: modules will have a harder time getting access to a MatrixClientPeg (not impossible, but harder).

With this PR, the project gets shifted over to the element-web team for ongoing maintenance. It is treated as a direct dependency of the react-sdk itself and thus maintained by the same team.
Note: There are other layers which are listed as drafts. These drafts are not up for review because they depend on layers like this one to exist and be published. They will be put up for review incrementally.
Upon merge of this PR, I'll publish the package to npm.

Part of a series / reference material:

React layer: https://github.com/matrix-org/matrix-react-sdk/pull/8246
Web layer: https://github.com/vector-im/element-web/pull/21703
Demo module: https://github.com/vector-im/element-web-ilag-module/pull/1
Internal proposal (cannot be public)

With this PR, the project gets shifted over to the element-web team for ongoing maintenance. It is treated as a direct dependency of the react-sdk itself and thus maintained by the same team.

There are other prerequisites for this
Such as copying the T- labels, wiring up a bunch of the same CI (Enforce Labels, Sonar, Static Analyses, etc)

With this PR, the project gets shifted over to the element-web team for ongoing maintenance. It is treated as a direct dependency of the react-sdk itself and thus maintained by the same team.

There are other prerequisites for this
Such as copying the T- labels, wiring up a bunch of the same CI (Enforce Labels, Sonar, Static Analyses, etc)

this is all counted as "ongoing maintenance" btw :P (we don't have any of this infrastructure on the widget-api, for instance)
also, considering it's a bit in flux at the moment I'd rather switch once we have everything set up fully on the other layers. There's also no real reason to overload this PR at the moment (I think).


Explicitly call resetStateToDefault before loading motions

This resets states to default values before loading a motion, making sure colors/states don't carry over between motions
Fixes issue #279
Brief summary of changes
Added the call to reset states to default before calling Model.formStateStorage
Testing I've completed
tested motions in issue reported and colors don't carry over.
Looking for feedback on whether there are other side effects to the call.
CHANGELOG.md (choose one)

no need to update bugfix

Can you review or suggest a different solution/workaround @aseth1 ? Thanks.


SCRecoder/SCRecoder.h file not found (Swift)

Try to import it in swift project but keeps giving me this error,
I have added "SCRecorder.xcodeproj" to my library folder and in bridging header I added importing line but i keep getting that error in bridging header.

Same issue here.

I managed to solve it with the following steps:
On the SCRecorder project:

Set Build Settings > Packaging > Public Headers Folder Path to include/$(TARGET_NAME)
Add SCRecordSession to Build Phases > Headers > Public
Move Project headers to Public headers

I did that, didn't work for me. Not sure what am I doing wrong.

Sorry to hear ... why don't you use cocoapods?

Haven't installed cocoapods yet and wanted to try manually first

working.

@codinglearning
how did you solve it?

imported all .h and .m files not the whole project

All you need to import in your bridging header is:
#import <SCRecorder/SCRecorder.h>
On Mon, Jun 1, 2015 at 5:57 PM, Olivier Lesnicki<EMAIL_ADDRESS>wrote:

@codinglearning
how did you solve it?
Reply to this email directly or view it on GitHub:
https://github.com/rFlex/SCRecorder/issues/166#issuecomment-107605356

@mjgaylord both @codinglearning and I managed to solve it by the end.
But more steps were required than just doing #import <SCRecorder/SCRecorder.h>

Same problem here

Well I solved this problem using cocoapods.

This solution worked for me. I installed it manually.


Investigate datetime lag

User reports:
Hello, I've noticed that the system date/time setting is lagging behind. For example, now my VPS was showing a time of 10:08 UTC before I used ntpdate ntp.ubuntu.com to get it right again, and now it is showing 11:34 (as it should). I have now set this in my crontab to run daily, but it's a weird issue I've never before come across. Maybe something you might want to investigate

@saffronjam Haven't heard any news about this, should we call it stale and close the issue for now?

Hello, I posted this issue. Seems like the ntp service crashes:
`× ntp.service - Network Time Service
Loaded: loaded (/lib/systemd/system/ntp.service; enabled; vendor preset: enabled)
Active: failed (Result: exit-code) since Wed 2024-01-10 03:10:07 UTC; 3 weeks 2 days ago
Docs: man:ntpd(8)
Main PID: 697 (code=exited, status=255/EXCEPTION)
CPU: 50.309s
Jan 05 15:03:01 xkr-kth ntpd[697]: <IP_ADDRESS> local addr <IP_ADDRESS> ->
Jan 10 03:09:13 xkr-kth ntpd[697]: Soliciting pool server 2a01:3f7:5:2::1
Jan 10 03:09:31 xkr-kth ntpd[697]: Soliciting pool server <IP_ADDRESS>
Jan 10 03:09:32 xkr-kth ntpd[697]: Soliciting pool server <IP_ADDRESS>
Jan 10 03:09:33 xkr-kth ntpd[697]: Soliciting pool server <IP_ADDRESS>
Jan 10 03:10:06 xkr-kth ntpd[697]: Soliciting pool server <IP_ADDRESS>
Jan 10 03:10:06 xkr-kth ntpd[697]: Soliciting pool server <IP_ADDRESS>
Jan 10 03:10:07 xkr-kth systemd[1]: ntp.service: Main process exited, code=exited, status=255/EXCEPTION
Jan 10 03:10:07 xkr-kth systemd[1]: ntp.service: Failed with result 'exit-code'.
Jan 10 03:10:07 xkr-kth systemd[1]: ntp.service: Consumed 50.309s CPU time.`
I don't know if this helps :)

Got one more report from a user (orb vm) that got 5 minutes time dilation over a month.
Let's try and fix this in the cloud-init template, and provide a fix script for current VM users

VM v1 is deprecated, we can close this issue now


DROOLS-4242: NPE in Kogito Quickstart: broken codegen

Verified that this work by adding the following to my local copy of https://github.com/quarkusio/quarkus-quickstarts/tree/development/using-kogito
     <dependency>
      <groupId>org.kie.kogito</groupId>
      <artifactId>kogito-codegen</artifactId>
      <version>8.0.0-SNAPSHOT</version>
    </dependency>

new release? @mswiderski @mariofusco

This is shared by maven and quarkus extension
Il Lun 24 Giu 2019, 18:10 Maciej Swiderski<EMAIL_ADDRESS>ha
scritto:

@mswiderski commented on this pull request.
Why do we need the kogito-codegen here? Shouldn’t it be brought by
quarkus-kogito?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kiegroup/kogito-runtimes/pull/71?email_source=notifications&email_token=AAC4654JX2LYMDLGCQKUL4TP4DWVHA5CNFSM4H27W57KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4OE23A#pullrequestreview-253513068,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC4655UZVAGWVS5LV4EH6LP4DWVHANCNFSM4H27W57A
.

That’s fine by why it needs to be declared explicitly? It’s already included in kogito quarkus extension, isn’t it?

Wiadomość napisana przez Edoardo Vacchi<EMAIL_ADDRESS>w dniu 24.06.2019, o godz. 18:39:
This is shared by maven and quarkus extension
Il Lun 24 Giu 2019, 18:10 Maciej Swiderski<EMAIL_ADDRESS>ha
scritto:

@mswiderski commented on this pull request.
Why do we need the kogito-codegen here? Shouldn’t it be brought by
quarkus-kogito?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kiegroup/kogito-runtimes/pull/71?email_source=notifications&email_token=AAC4654JX2LYMDLGCQKUL4TP4DWVHA5CNFSM4H27W57KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4OE23A#pullrequestreview-253513068,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC4655UZVAGWVS5LV4EH6LP4DWVHANCNFSM4H27W57A
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

sure, I just added it to override the version number

Another thing is I am not sure we should always return new instance for both RuleUnits and then KieRuntimeBuilder- wouldn’t it make more sense to have just single instance for it?

@mswiderski good catches. It should be better now


Refactoring the assignment order of the RunCommand function in validatorPod

In the validatorPod struct's RunCommand method, there has been a minor, yet significant change in the order of operations to ensure that the result field of the validatorPod struct correctly captures the full command result.
In the previous version of the method, the command result struct r was assigned to v.result before r.Stdout was populated with the command output. This meant that v.result always contained an empty string for its Stdout field, regardless of the command's actual output.
This has now been corrected by moving the assignment of r to v.result below the line where r.Stdout is populated. This ensures that the Stdout field of v.result correctly contains the command's output, and not an empty string.
This change is important because it provides accurate command output information when referencing v.result, allowing for better debugging and error handling in the usage of validatorPod instances. While it might seem like a small change, it can significantly improve the transparency and traceability of command execution within the application.

Description

Issue
Fixes #<issue_number>
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Change #1
Change #2
...

Testing

[ ] make develop_test; if any code changes were made
[ ] Docker Compose LocalNet; if any major functionality was changed or introduced
[ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

LGTM ✅ Confirmed on my local that this populates the Stdout field properly.

@dylanlott For external contributors that are not core contributors (yet), we need to merge it ourselves after checks have passed.

Seeme like a harmless change, so we can merge it in.


pull request for e2e test at 11/22/2016 21:56:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Updating Microsoft.Insights swagger spec to include api-version for Management groups

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask<EMAIL_ADDRESS>(or NullMDR in github) for additional help.

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@changlong-liu Could you please help to confirm why do we have so much breaking change in python SDK?

@changlong-liu Please help to review this PR.
Please review the comments on the PR for the readme.md file. What is the best way to add a new api-version to the swagger spec?
From: Phoenix He<EMAIL_ADDRESS>Sent: Wednesday, June 24, 2020 8:04 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Aditi Mukhtyar<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Updating Microsoft.Insights swagger spec to include api-version for Management groups (#9938)
@changlong-liuhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchanglong-liu&data=02|01|Aditi.Mukhtyar%40microsoft.com|28b28b5e1bc2415fdba908d818b47aae|72f988bf86f141af91ab2d7cd011db47|1|0|637286510726054882&sdata=qWWw0RGuV1y94g6Za%2FLkqUC3INBx6ljxHMlU7yLEd7c%3D&reserved=0 Could you please help to confirm why do we have so much breaking change in python SDK?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23issuecomment-649186157&data=02|01|Aditi.Mukhtyar%40microsoft.com|28b28b5e1bc2415fdba908d818b47aae|72f988bf86f141af91ab2d7cd011db47|1|0|637286510726064876&sdata=HD60JZVY%2FxpNwM5LSWg4k%2B7G56V1hBmw4z9GFnxx9Kw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIKX6MRRQYNVM4VOSUTRYK5D3ANCNFSM4OF5VH5Q&data=02|01|Aditi.Mukhtyar%40microsoft.com|28b28b5e1bc2415fdba908d818b47aae|72f988bf86f141af91ab2d7cd011db47|1|0|637286510726064876&sdata=0TnZKS6T8OSUy9TO8c3NtRoMmgqfpiDyXeUxluredaE%3D&reserved=0.

/azp run automation - sdk (SDK Python)

/azp run automation - sdk

Hi @NullMDR , @admukhty ,
The Python breaking change is not related to this PR. I think it's fine for Python to merge this PR.
Hi @NullMDR ,
This is related to the Track2 release last week, and I just created this PR for Python: https://github.com/Azure/azure-sdk-for-python/pull/12211
The Python code report will turn to fine after that PR is merge.

<EMAIL_ADDRESS>please help merge this pull request.
It seems like I am not authorized to merge it.
<EMAIL_ADDRESS>Thanks,
Aditi
From: MyronFanQiu<EMAIL_ADDRESS>Sent: Saturday, June 27, 2020 8:33 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Aditi Mukhtyar<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Updating Microsoft.Insights swagger spec to include api-version for Management groups (#9938)
@MyronFanQiu approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23pullrequestreview-438740384&data=02|01|Aditi.Mukhtyar%40microsoft.com|3db77d42427745b8ad0808d81b13eb7f|72f988bf86f141af91ab2d7cd011db47|1|0|637289119665590246&sdata=jd%2FNnYFvCzaDp%2B5zO4Bs%2FBu6SahiHaAiGLvbM7ERbOQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIK5MCAPESLEOCKVCFTRY22VXANCNFSM4OF5VH5Q&data=02|01|Aditi.Mukhtyar%40microsoft.com|3db77d42427745b8ad0808d81b13eb7f|72f988bf86f141af91ab2d7cd011db47|1|0|637289119665600240&sdata=vn7Vt8Dg6%2FvAlgdloCShupZuC7bmirYXhOal0KuZnNs%3D&reserved=0.

<EMAIL_ADDRESS>please help merge this pull request. It seems like I am not authorized to merge it<EMAIL_ADDRESS>Thanks, Aditi From: MyronFanQiu<EMAIL_ADDRESS>Sent: Saturday, June 27, 2020 8:33 PM To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Aditi Mukhtyar<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Updating Microsoft.Insights swagger spec to include api-version for Management groups (#9938) @MyronFanQiu approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23pullrequestreview-438740384&data=02|01|Aditi.Mukhtyar%40microsoft.com|3db77d42427745b8ad0808d81b13eb7f|72f988bf86f141af91ab2d7cd011db47|1|0|637289119665590246&sdata=jd%2FNnYFvCzaDp%2B5zO4Bs%2FBu6SahiHaAiGLvbM7ERbOQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIK5MCAPESLEOCKVCFTRY22VXANCNFSM4OF5VH5Q&data=02|01|Aditi.Mukhtyar%40microsoft.com|3db77d42427745b8ad0808d81b13eb7f|72f988bf86f141af91ab2d7cd011db47|1|0|637289119665600240&sdata=vn7Vt8Dg6%2FvAlgdloCShupZuC7bmirYXhOal0KuZnNs%3D&reserved=0.

we still need ARM team's review and approval.

<EMAIL_ADDRESS>can you help add someone from the ARM team to review this?
I see it is has been waiting for over a week.
From: MyronFanQiu<EMAIL_ADDRESS>Sent: Saturday, June 27, 2020 10:24 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Aditi Mukhtyar<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Updating Microsoft.Insights swagger spec to include api-version for Management groups (#9938)
<EMAIL_ADDRESS>please help merge this pull request. It seems like I am not authorized to merge it<EMAIL_ADDRESS>Thanks, Aditi From: MyronFanQiu notifications<EMAIL_ADDRESS>Sent: Saturday, June 27, 2020 8:33 PM To: Azure/azure-rest-api-specs azure-rest-api-specs<EMAIL_ADDRESS>Cc: Aditi Mukhtyar Aditi.Mukhtyar<EMAIL_ADDRESS>Mention mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Updating Microsoft.Insights swagger spec to include api-version for Management groups (#9938https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210017099&sdata=AGDi%2B2T0mvhl%2F4Jbzy2GIdpdSNkFYjp9W9QGv5t3860%3D&reserved=0) @MyronFanQiuhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMyronFanQiu&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210027069&sdata=5X5YBqFKZGte%2BXStCvsf59YLVGlezwhi0e6PHt2NxJA%3D&reserved=0 approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23pullrequestreview-438740384&data=02%7C01%7CAditi.Mukhtyar%40microsoft.com%7C3db77d42427745b8ad0808d81b13eb7f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637289119665590246&sdata=jd%2FNnYFvCzaDp%2B5zO4Bs%2FBu6SahiHaAiGLvbM7ERbOQ%3D&reserved=0https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23pullrequestreview-438740384&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210027069&sdata=UfDRq%2FTY48PZMhytIS0uWA206KCCc2u8ZCxa%2Bgjb70A%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIK5MCAPESLEOCKVCFTRY22VXANCNFSM4OF5VH5Q&data=02%7C01%7CAditi.Mukhtyar%40microsoft.com%7C3db77d42427745b8ad0808d81b13eb7f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637289119665600240&sdata=vn7Vt8Dg6%2FvAlgdloCShupZuC7bmirYXhOal0KuZnNs%3D&reserved=0https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIK5MCAPESLEOCKVCFTRY22VXANCNFSM4OF5VH5Q&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210037013&sdata=kNqmf9rWvcSsAMkmSpM8qialzL01c%2BhbbA7TWmF4L0M%3D&reserved=0.
we still need ARM team's review and approval.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23issuecomment-650699141&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210037013&sdata=mQr7ctAEgm%2FvqcImcPUALC9LsPgHaALG%2BWZdhufMphw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIJTE2F6Q2SHJ4OWJSDRY3HVNANCNFSM4OF5VH5Q&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210046971&sdata=dY67WHL7OvyjtcmUN2bz1Ju5vJ2QOrHXjBR1WyCLW6s%3D&reserved=0.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

<EMAIL_ADDRESS>the ARM team has reviewed and approved the PR.
Please help merge it.
Thanks,
Aditi
From: MyronFanQiu<EMAIL_ADDRESS>Sent: Saturday, June 27, 2020 10:24 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Aditi Mukhtyar<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Updating Microsoft.Insights swagger spec to include api-version for Management groups (#9938)
<EMAIL_ADDRESS>please help merge this pull request. It seems like I am not authorized to merge it<EMAIL_ADDRESS>Thanks, Aditi From: MyronFanQiu notifications<EMAIL_ADDRESS>Sent: Saturday, June 27, 2020 8:33 PM To: Azure/azure-rest-api-specs azure-rest-api-specs<EMAIL_ADDRESS>Cc: Aditi Mukhtyar Aditi.Mukhtyar<EMAIL_ADDRESS>Mention mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Updating Microsoft.Insights swagger spec to include api-version for Management groups (#9938https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210017099&sdata=AGDi%2B2T0mvhl%2F4Jbzy2GIdpdSNkFYjp9W9QGv5t3860%3D&reserved=0) @MyronFanQiuhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMyronFanQiu&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210027069&sdata=5X5YBqFKZGte%2BXStCvsf59YLVGlezwhi0e6PHt2NxJA%3D&reserved=0 approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23pullrequestreview-438740384&data=02%7C01%7CAditi.Mukhtyar%40microsoft.com%7C3db77d42427745b8ad0808d81b13eb7f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637289119665590246&sdata=jd%2FNnYFvCzaDp%2B5zO4Bs%2FBu6SahiHaAiGLvbM7ERbOQ%3D&reserved=0https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23pullrequestreview-438740384&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210027069&sdata=UfDRq%2FTY48PZMhytIS0uWA206KCCc2u8ZCxa%2Bgjb70A%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIK5MCAPESLEOCKVCFTRY22VXANCNFSM4OF5VH5Q&data=02%7C01%7CAditi.Mukhtyar%40microsoft.com%7C3db77d42427745b8ad0808d81b13eb7f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637289119665600240&sdata=vn7Vt8Dg6%2FvAlgdloCShupZuC7bmirYXhOal0KuZnNs%3D&reserved=0https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIK5MCAPESLEOCKVCFTRY22VXANCNFSM4OF5VH5Q&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210037013&sdata=kNqmf9rWvcSsAMkmSpM8qialzL01c%2BhbbA7TWmF4L0M%3D&reserved=0.
we still need ARM team's review and approval.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9938%23issuecomment-650699141&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210037013&sdata=mQr7ctAEgm%2FvqcImcPUALC9LsPgHaALG%2BWZdhufMphw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBXUIJTE2F6Q2SHJ4OWJSDRY3HVNANCNFSM4OF5VH5Q&data=02|01|Aditi.Mukhtyar%40microsoft.com|033d49115d734c0051f808d81b2367a1|72f988bf86f141af91ab2d7cd011db47|1|0|637289186210046971&sdata=dY67WHL7OvyjtcmUN2bz1Ju5vJ2QOrHXjBR1WyCLW6s%3D&reserved=0.


💔 Split out Github Component to Separate Repo

We would like to move our Github configuration into a separate repo to make it easier for self-serve requests.
As platform engineers, we've encountered reluctance on the part of our users to raise PRs and otherwise self-serve requests for team membership because the github component of a rather large monorepo. Although the process is isolated, there is fear that improperly made request will have ripple effects on other infra. Therefore, we would like to split out GH component into its own repo, potentially expanding it later to include other self-serve functionality.
Proposal:
Split off GH team management component into its own repository.
Definition of Done:

[x] Repository created
[x] Dependencies to other part of the code identified and remediated
[ ] Workflows created
[ ] Provisioning roles updated
[ ] Code tested and reviewed by other team members
[ ] Documentation for self-servicing requests updated

Confirm that the repo in question is data_platform
Confirm the name of the new repository
identify the GH team management components to be moved

confirmed
source data-platform
new data-platform-github-access - internal
this is the component to move https://github.com/ministryofjustice/data-platform/tree/main/terraform/github
start with teams using import to create.

New repo created in this PR.
Repo located here.

Tasks left to do:

Create workflows
Add devcontainer
Add documentation for self-servicing requests updated

draft pr to add  workflow for repository pr

We had  been working in two branches one for the workflow and one for the terraform we had issues with the later and the workflow failed as it was still an empty repo so we started a new branch git_hub_workflow.
in the new branch we  found out the terraform plan which had previously had no actions had multiple creates and destroys so we copied the github dir from data-platform again and the plans were then identical 2 to change ? -- remember we will have to do this again to keep the new repo in sync with data-platform until the switch over
The workflow had issues with the AWS credentials  in the draft pr so had to manually amend the role GlobalGitHubActionAccess   to include the new repo "repo:ministryofjustice/data-platform-github-access:*". this enabled the workflow to create the terraform plan
Lots of issues with the super linter that we will have to address


Send + Sync implentation of HtmlRewriter

A few days ago, I came across this crate when I was researching methods of applying regular expression onto an HTML stream. I was really excited to see that this hard problem was actually solvable using this crate.
I sadly realized that the HtmlRewriter is nether Send nor Sync, so it is almost impossible to us it in combination with futures.
So I decided to try to do a basic rewrite of the crate into a Send and Sync implementation. It currently compiles and all the tests pass.
Although I refrained from using any RwLock's or Mutex's, there are some minor/major performance and throughput regressions, I attached an output file of a run I did using the script/bench.sh benchmark.
benchmark.txt
This and the bounds required for the HtmlRewriter  to be Send and Sync make it probably moronic to merge it directly into the lol-html crate.
But it would be possible to put it behind a feature flag with almost no downsides for developers and users.
This is the reason for the Pull request, do you guys think a Send and Sync version of the HtmlRewriter behind a feature flag would be mergeable?
I ask because I would have to put in some effort and time to not just duplicate some code a bunch of time (Send and non Send versions).
Thank you very much in advance, I am looking forward to hearing back from you.

@inikulin?

Thank you for the contribution.
The rewriter is designed for single-threaded uses. To be used in multithreaded environment and satisfy Send + Sync it just needs external synchronisation  (i.e. be wrapped in Mutex or RwLock).

Could you please reopen this PR?
It is impossible to Sendany type that it not send, wrapping it in a Arc<Mutex> doesn't make it Send.
Please check the respective docs for Mutex as well as Arc.
Send and Sync is only ever implemented for a type if all the contained types in it also implement Send and Sync. This makes sense, so to ensure that things that are not Send can't be sent across threads. For example: A Thread Local only ever makes sense to use if it is used from the same thread, wrapping it in a Arc<Mutex> should not make it sendable.

Indeed, my bad.
However, unfortunately, due to performance considerations we won't accept this PR. Even though compiler marks HtmlRewriter as !Send because of Rcs, those Rcs are never leaked outside of the rewriter, so it's safe to assume that HtmlRewriter is Send as long as its handlers are Send and its behind Mutex. So, as a workaround you can do:
struct SendRewriter(Mutex<HtmlRewriter>);

unsafe impl Send for SendRewriter {}

add wrapper methods that statically ensure that rewriter handlers are Send.

Maybe using https://crates.io/crates/sendable (which implements send for Rc) does not affect performance such as using Arc. Interested in the send implementation as well.


[Dawn] Code snippets seem to be unreadable (see issue from 2022)

Continuing from https://github.com/TryGhost/Themes/issues/197
There seems to still be an issue as of Dawn latest release with the code snippets
I assume that the order in which the .css files are loaded is incorrect, as this is what I see in my code inspection for pre blocks on the Blogpost preview page:

It's apparent that there seem to be two variables: --primary-text-color and --color-primary-text. Whilst the latter would read well in dark mode it's not the one that gets applied. Any advise? For now I'm overriding the color property of pre HTML elements.
Installation details
Version: 5.78.0
Environment: production
Database: mysql8
Theme: dawn v1.0.0 (as per UI, but uploaded one from https://github.com/TryGhost/Dawn/archive/main.zip, but I must say that some versioning wouldn't hurt)
Workaround
Adding this snippet to page footer mitigates the issue:
<style>
  /* Fixing ghost Dawn theme issue */
  pre {
    color: var(--color-primary-text)
  }
</style>

Hi @MNeverOff 👋 In case you were unaware, you can use Prism to provide richer code blocks. See: https://ghost.org/tutorials/code-snippets-in-ghost/
I did a bit of digging on this issue as I'd experienced the same thing - I eventually tracked it down to a one of the vars -color-lighter-gray not being overridden on detection of a browser requesting a dark theme.  Which is why this looked okay when selecting a dark or light theme manually, but letting the browser call for the dark theme had the wrong background colour.
Check out #323 - hopefully one of the Ghost team sees this 😄

Hey @georgepstaylor, well done on submitting a PR there, I came to sam e realisation but wasn't as confident in my overarching knowledge of Ghost just yet to submit the fix myself, appreciate you taking that step!
Also, will definitely check out Prism, looks much better than the thing I've built with a :pre copypasting of content from codeblocks

@MNeverOff thank you for including the workaround. I find it annoying that on dark it's still a white box, but this makes it readable!
Hopefully the pull request gets reviewed soon and the workaround is no longer needed.


Trouble of merging werights

Hi! Thank you for your great work.
I have a problem when I want to do merging weights.

I have a fake small data to do lora fine tuning. Getting 6 files, adapter_config.json  adapter_model.safetensors  config.json  non_lora_state_dict.bin  README.md  trainer_state.json in the ./output/testing folder.
When I do the merging with --model-path output/testing
--model-base Phi-3-vision-128k-instruct
--save-model-path output/merged_output
--safe-serialization
Get the error message OSError: output/testing does not appear to have a file named preprocessor_config.json. Checkout 'https://huggingface.co/output/testing/tree/main' for available files.

Should I have the file preprocessor_config.json under ./output/testing after the lora fine tuning?

Sorry, I for the issue. This is becuase the lora folders has to have 'lora' in the folder name.
You could change your folder name tha include 'lora'.
https://github.com/2U1/Phi3-Vision-ft/blob/e90cf1c4c74e895b7f80b46c8a05ae9fa27bc5d5/src/utils.py#L40

Thank you for the reply!
I would like to ask a basic question. I run the code in another machine.
Having this issue
pyo3_runtime.PanicException: The global thread pool has not been initialized.: ThreadPoolBuildError { kind: IOError(Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }) }
thread '' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:168:10:
The global thread pool has not been initialized.: ThreadPoolBuildError { kind: IOError(Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }) }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
pyo3_runtime.PanicException: The global thread pool has not been initialized.: ThreadPoolBuildError { kind: IOError(Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }) }
Do you have any idea? Seems it is an env problem?

@WYY220062 It seems like an somekind of env error. I haven't seen this error before.
It looks like its related to Rust.

I have one more question, seems I should not keep "lora" in the merged result folder. Do I understand correctly?

@WYY220062 Yes you're right. Merged path shouldn't have word "lora" in it.


How do we get io.grpc.CallCredential working in the commonMain module ?

I want to apply metadata to the requests like JWT token etc.., can you help me where to look for regarding this ?

The generated service stubs come with an optional function parameter called metadata.
The way I use it:
KMMetadata().apply {
    if (token != null) {
        set(AUTHENTICATION_TOKEN_KEY, token)
    }
}

Of course, it would be nice to be able to supply this metadata in KMStub with a function withMetadata(metadata).