v2: DeviceCollector does not connect variables that existed before being entered.

In general, it seems a good idea for the DeviceCollector to be able to do something like this:
with DeviceCollector():
    motor1 = Motor('OLD-PV')

#processing happens here...

with DeviceCollector():
    motor1 = Motor('NEW-PV') #actually, motor1 needs to be reassigned

But at the moment, the DeviceCollector simply checks on the existing objects before it's been entered, and compares them to the objects on exit by name. This means any replaced objects, such as in the example above, won't be connected. In the above, trying to get and put to motor1 will get an object that has not had connect run, as the enter/exit definitions of DeviceCollector will not have recognized motor1 as a new device which needs connecting.
There is a fairly straightforward way of getting around this, that @coretl has mentioned to me. At the moment, the device collector checks for objects by name on exit:
    def __enter__(self):
        # Stash the names that were defined before we were called
        self._names_on_enter = set(self._caller_locals())
        return self
...
    def __exit__(self, type_, value, traceback):
        self._objects_on_exit = self._caller_locals()
        return call_in_bluesky_event_loop(self._on_exit())
...
    async def _on_exit(self):
        # Name and kick off connect for devices
        tasks: Dict[asyncio.Task, str] = {}
        for name, obj in self._objects_on_exit.items():
            if name not in self._names_on_enter and isinstance(obj, Device):
                ...
                if self._connect:
                    task = asyncio.create_task(obj.connect(self._prefix, self._sim))
                    tasks[task] = name
        ...

Instead, we can check for the id of the objects, and compare that as opposed to the name. This will allow re-defining motors and other ophyd v2 devices in device collectors, and will mean they get connected/named as expected. This would look like so:
    def __enter__(self):
        # Stash the names that were defined before we were called
        self._ids_on_enter = {k: id(v) for k, v in self._caller_locals().items())
        return self
...
    async def _on_exit(self):
        # Name and kick off connect for devices
        tasks: Dict[asyncio.Task, str] = {}
        for name, obj in self._objects_on_exit.items():
            is_new = name not in self._ids_on_enter or id(obj) != self._ids_on_enter[name]
            if is_new and isinstance(obj, Device):
                ...
                if self._connect:
                    task = asyncio.create_task(obj.connect(self._prefix, self._sim))
                    tasks[task] = name
        ...

What do people think of this? Is this what users would expect DeviceCollector to do?

@tacaswell @danielballan @prjemian @mrakitin any thoughts on this?

I like the notion of an instrument  registry that is being developed by @canismarko for our spectroscopy beam lines.

As @prjemian mentioned, we developed an InstrumentRegistry class for Haven inspired by Pint's ureg.
https://haven-spc.readthedocs.io/en/latest/topic_guides/instrument_registry.html
A default registry object is created at import time and can be used either directly on Device objects:
motor1 = Motor(...)
registry.register(motor1)

or as a class decorator, where the device is registered regardless of the context it's created in:
@registry.register
class MyMotor(Motor):
    ...

motor1 = MyMotor(...)

I use the decorator form more since most of my devices are subclasses of ophyd.Device.
You could in theory use multiple registries, but I haven't had a need for that yet.
It currently checks for duplicates by name similar to this DeviceCollector, but that could change easily.

There are 2 problems that DeviceCollector aims to solve:

For each dev = Device(), make sure dev.name is set to "dev" if not already explicitly set
Calling await asyncio.gather(d.connect() for d in all_devices)

The first of these exists in both ophyd.v1 and v2, the second is only in v2 as it can do a concurrent connection of many devices at once.
I think the registry could be made to solve the first (if you declare MyMotor(name="motor") instead of motor=MyMotor() then you could globals().update({d.name: d for d in registry.findall())). It could also handle the second case, although it would have to be careful to not call connect on devices with parents, as the parent is responsible for connecting its children at present.
How do you solve 1 at present?

I would not trust stashing the id as they are only unique for objects that all exist at the same time.  If an object is garbage collected it's ID is available for (immediante) re-use (there is a bluesy issue where we verified this the hard way with some of the logic in plan mutator....).  Just keep a reference to any devices that exist on entry (so you are sure you keep them alive) and then you can do an is test to verify it is the same object or not.   I think if we are going to have DeviceCollector then we need to support this.
I'm very very skeptical of a global devices registry at the ophyd library level.  I think "you must keep track of your devices" is way simpler to explain (and enables facility and beamline specific registries if people want them) rather than "we keep a global registry that is almost certainly not what you wanted but is close so please spend an inordinate amount of effort engineering around un-needed global state".  I acknowledge my presentation of the alternatives is biased.

(if you declare MyMotor(name="motor") instead of motor=MyMotor() then you could globals().update({d.name: d for d in registry.findall())).

I think this is getting too far away from Python syntax

I would not trust stashing the id as they are only unique for objects that all exist at the same time. If an object is garbage collected it's ID is available for (immediante) re-use (there is a bluesy issue where we verified this the hard way with some of the logic in plan mutator....). Just keep a reference to any devices that exist on entry (so you are sure you keep them alive) and then you can do an is test to verify it is the same object or not. I think if we are going to have DeviceCollector then we need to support this.

Excellent, let's do that:
    def __enter__(self):
        # Stash the names that were defined before we were called
        self._objects_on_enter = self._caller_locals()
        return self
...
    async def _on_exit(self):
        # Name and kick off connect for devices
        tasks: Dict[asyncio.Task, str] = {}
        for name, obj in self._objects_on_exit.items():
            is_new = name not in self._objects_on_enter or obj is not self._objects_on_enter[name]
            if is_new and isinstance(obj, Device):
                ...
                if self._connect:
                    task = asyncio.create_task(obj.connect(self._prefix, self._sim))
                    tasks[task] = name
        ...

@RAYemelyanova please can you make the changes with associated tests?

I'm very very skeptical of a global devices registry at the ophyd library level. I think "you must keep track of your devices" is way simpler to explain (and enables facility and beamline specific registries if people want them) rather than "we keep a global registry that is almost certainly not what you wanted but is close so please spend an inordinate amount of effort engineering around un-needed global state". I acknowledge my presentation of the alternatives is biased.

Agreed, let's make DeviceCollector useful but completely optional, so sites can build their own registries that do the functionality of naming and connection their own way.


[RFE] Upgrade alert manager to 0.26.x

Components:

[x] Bump the alertmanager image in the chart

Resolves CVEs
Allows users to consume the newer official configs like teams receivers into raw alertmanager configs stored in configmaps / secrets

[ ] Bump the Alertmanager CRDs that contain the newer alertmanager config changes introduced in 0.26

Users can consume the the new configuration options via the CRDs

[ ] Add UI for configuring the new options exposed in the alertmanager configs

Allows users to consume the new configuration options via the UI

[ ] Documentation updates

[ ] Deprecate the prom2teams alerting driver once the majority of the above items in this issue have been completed

[ ] Remove the prom2teams alerting driver from the charts repo and from the alertmanager webhook UI

Backporting considerations
2.8.X
SURE-7727

Retest passed : Upgrade alert manager to 0.26.x
Test scenarios:

verified “Upgrade alert manager to 0.26.x” on local cluster.
verified “Upgrade alert manager to 0.26.x” downstream cluster.
verified  “Upgrade alert manager to 0.26.x” using rancher upgrade from rancher 2.8.5 to 2.9.0-alpha7.
verified Update logging-operator by upgrading, downgrading and uninstalling logging chart
.

Rancher version: 2.9.0-alpha7
RKE2 : v1.29.4+rke2r1

monitoring  : rancher-monitoring:104.0.0+up45.31.1

mirrored-prometheus-alertmanager:v0.26.0


How to generate a scene while exporting it as a USDC file

Hello, how to generate a scene and export it as a USDC file instead of exporting it through tools after generating the scene?
I want to create a scene and export it as USDC simultaneously in one command line

You can add export.gin to your --pipeline_configs and this will cause every scene to run export as its last step.


Unavailable Packages removed from Catalog without any notification

We keep our Munki repo in git and clone the repo to our local machines when we need to make changes. Because of their size we don't keep the /pkgs/ directory in git, instead when we're working with Munki admin we'll mount a network share to the /pkgs/ directory.
Which works great, but if we lose connectivity to the network share (thus munki admin sees /pkgs/ as empty), when saving it'll remove the references to those packages from the catalog (effectively blanking out the catalog) with no real warning.
It'd be nice to have some sort of dialog saying that it can't access the packages when saving in munki admin.

Thanks for reporting. We're using a similar workflow here (but constantly without the pkgs directory). When the pkgs directory is unavailable you should check the "disable sanity checks" option in preferences which causes MunkiAdmin to run makecatalogs with the --force argument. In fact, in your case, I'd suggest keeping that option on all the time. You will get complete catalogs every time whether the actual packages are available or not.

Awesome, thanks that makes sense. Didn't know that was an option, works great.
Thanks for the response!


Woodpecker server crashes on startup

Component
server
Describe the bug
After upgrading from 0.15.7 to 0.15.9, woodpecker server can no longer start.
Full stacktrace is here .
Note that I am using MySQL for the database. I tried dropping the database and recreating. It recreated the database tables on startup, but immediately crashed afterwards.
I tried rolling back to 0.15.7 and now that won't start either.
System Info
woodpecker-server 0.15.9 on Fedora 37, installed via the RPM from the Github releases page.

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

@qwerty287 I'm getting the same error message with 0.15.7, 0.15.8 and 0.15.9 . I was able to get it working again by compiling the source tarball from the 0.15.9 release locally.
This isn't the first time I've had problems with the binary releases that I could fix by compiling locally. FWiW, I've always used the MySQL database backend. If there is some additional testing around binary release + MySQL I could help with, let me know.

Probably an issue with the rpm build


BeeGFS 7.2.7 version fixes

Describe the bug
BeeGFS client installation should be successful
To Reproduce
Execute storage.yml
Expected behavior
Execution should be successful

Closing with pr @1955


Getting started is missing installation of nx

Core Library
MSAL.js v2 (@azure/msal-browser)
Wrapper Library
Not Applicable
Public or Confidential Client?
Public
Documentation Location
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/contributing.md#build-library
Description
As described in https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/5517, there seems to be a requirement to install nx.
It could be added to package.json, it worked for me to add nx as a dev-dependency, but I was a bit unsure about the massive diffs in package-lock.
I guess it also could be added to the readme in https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/contributing.md#build-library to install it.

It does happen on a clean clone on both windows and linux when

On both windows and linux it works again when I run
npm install nx
npm run build

I guess it is lerna that needs to include nx as a dependency,  so I can close the issue, but it will affect users who do not install nx "by hand" until this is fixed in lerna.

It is being fixed upstream https://github.com/lerna/lerna/pull/3486 @bmahall


Add multiline continuation support.

There is existing multiline support but it requires an ugly "<<<"
continuation sentinel. In this change we instead detect unexpected EOF
errors at the end of our input indicating we should continue parsing.

This builds on #14


feat: docs update for latest version

Wait with merge until my branch has been merged first

Double checked for conflicts and missing .md suffix, it get's a green light from me. Wait with merge however until @j-zimnowoda has released new version of Otomi


[BUG] interpretation of expiration time 0 in cookies.txt

Basic information

Program version: v0.0.8
Python version: 3.8.2 and 3.9.2
Operating system: macOS and Windows 10 x64 LTSC

Describe the bug
Okay so I'm not familiar with cookies.txt, so I'm not sure whether Youtube-DL or chat-downloader is to blame... but I think it would be a good idea to replicate Youtube-DL's behavior for the sake of convenience.
When a cookie in cookies.txt has expiry time 0, the cookie is not included (i think) in http-requests. This means that most cookies set by Youtube-DL will not make it, as Youtube-DL interprets 0 as infinite and produces cookies.txt accordingly.
This is problematic as YouTube now requires the CONSENT cookie (at least in the EU), and chat-downloader does not generate this. Some currently accepted values are YES+NO.no+V11+BX and YES+cb.20210328-17-p0.en+FX+754.
Command/Code used
$ python3 -m youtube_dl --cookies cookies.txt youtube.com/watch?v=XyL6bhHsNhQ
[...]

$ cat cookies.txt
.youtube.com	TRUE	/	FALSE	0	CONSENT	YES+[...]
.youtube.com	TRUE	/	TRUE<PHONE_NUMBER>	GPS	1
.youtube.com	TRUE	/	TRUE<PHONE_NUMBER>	VISITOR_INFO1_LIVE	[...]
.youtube.com	TRUE	/	TRUE	0	YSC	[...]

$ python3 -m chat_downloader -c cookies.txt -o ars.json youtube.com/watch?v=XyL6bhHsNhQ
[INFO] Site: youtube.com
Traceback (most recent call last):
  File "/Users/ed/Library/Python/3.9/lib/python/site-packages/chat_downloader/cli.py", line 170, in main
    run(**args.__dict__)
  File "/Users/ed/Library/Python/3.9/lib/python/site-packages/chat_downloader/chat_downloader.py", line 273, in run
    chat = downloader.get_chat(**chat_params)
  File "/Users/ed/Library/Python/3.9/lib/python/site-packages/chat_downloader/chat_downloader.py", line 207, in get_chat
    chat = self.get_chat(**original_params)
  File "/Users/ed/Library/Python/3.9/lib/python/site-packages/chat_downloader/chat_downloader.py", line 166, in get_chat
    info = self.sessions[site.__name__].get_chat(**params)
  File "/Users/ed/Library/Python/3.9/lib/python/site-packages/chat_downloader/sites/youtube.py", line 1393, in get_chat
    return self.get_chat_by_video_id(match.group('id'), kwargs)
  File "/Users/ed/Library/Python/3.9/lib/python/site-packages/chat_downloader/sites/youtube.py", line 1367, in get_chat_by_video_id
    initial_info = self._get_initial_video_info(video_id)
  File "/Users/ed/Library/Python/3.9/lib/python/site-packages/chat_downloader/sites/youtube.py", line 906, in _get_initial_video_info
    raise ParsingError(
chat_downloader.errors.ParsingError: Unable to parse initial video data. <!doctype html><html lang="en" dir="ltr"><head><base href="https://consent.youtube.com/"><meta name="referrer" content="origin"><link rel="canonical" href="https://consent.youtube.com/m"><meta name="viewport" content="initial-scale=1,minimum-scale=1,maximum-scale=5,width=device-width"><link rel="shortcut icon" href="//www.google.com/favicon.ico"><script data-id="_gd" nonce="[...]

Expected behavior
When the CONSENT cookie in cookies.txt is modified to have an expiry time in the future, the chat download succeeds
Additional context/information
I didn't check whether the cookies are actually included or not, or whether the 0 causes incorrect formatting or something, so that part is just an assumption. But youtube is not happy :)
EDIT: nothing interesting in -v either, aside from the redirect URL to https://consent.youtube.com:443 -- it includes some session-tracking URL parameters (they don't seem too related to the final cookie value)

Support for generating consent cookies has been added in the latest version (v0.1.1). So, this should fix this issue too. Would you be able to confirm? You shouldn't need to pass a cookies file in anymore either. 😃

yup, that takes care of the actual problem, so don't have to worry about this anymore :>
welcome back btw!

yup, that takes care of the actual problem, so don't have to worry about this anymore :>
welcome back btw!

Awesome! 😄 Super happy to be back. 😃


Crashes when escape key pressed

On Ubuntu 15.10, The application crashes when I press the escape key.
Crash detials from terminal:
[12347:0212/113447:ERROR:channel.cc(305)] RawChannel read error (connection broken)
Failed to tell parent about crash.

system details
$ uname -srmov
Linux 4.2.0-27-generic #32-Ubuntu SMP Fri Jan 22 04:49:08 UTC 2016 x86_64 GNU/Linux

Its not a crash, its just a normal quit for the app (I know the error is strange).
I added a toolbar icon in my fork, so now it just go in background.

Well, a non-zero exit is technically a crash. Ubuntu will interpret this as a crash as long as it has an anomalous exit status.
I'm using Antergos linux now, and this issue isn't present.

I have the same thing on linux mint, but I changed the behavior of the ESC button so I dont have your behavior (App quiting). I'm not sure, but I'm pretty confident its a NWJS problem...

Please see https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/458


#175494070 Return Trip

[start:175494070]
[finish:175494070]
What does this PR do?

user should be able to return trip

Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Questions:

@Liliane003  Work on your pr description and how can this be tested


How to handle connection errors?

Does not seem to be able to handle pool connection 'error' events.  For example, if the database were to be stopped/restarted or lose connection, no callbacks will be activated - causing app the hang.

//  1. Start database

//  2. Connect to database

//  3. First query
Model.where().query().fetchAll()
  .then(function (collection) {
    // successful query
    // works as normal
  });

//  4. Stop/disconnect database

//  5. Second query (nothing happens)
Model.where().query().fetchAll()
  .then(function (collection) {
    // suppose to be connection error
  })
  .catch(function (err) {
    // Expected error
    // never reached
  });

Is there a way for Bookshelf to know that the connection was lost?

Your first post was in the right place. This question pertain to Knex. I don't know the answer, but I think I've seen this discussed before on their issues page. How Bookshelf approaches this issue will be based on the Knex API.


Floating base

Description
rnea_grad:

Code overhaul implementing a different rnea_grad implementation found here: https://github.com/ROAM-Lab-ND/spatial_v2_extended/blob/main/v3/derivatives/ID_derivatives.m
Instead of bpass and fpass for dq and dqd as implemented previously, opted for fpass and bpass for simplicity.
Fpass calculates f, IC, BC, S, Sd, Sdd, Sj (spatial force on links, spatial inertia matrices, bias force matrix, motion subspace matrices and relevant ordered derivatives).
Bpass calculates dc_dq and dc_dqd, derivatives of torque given dq and dqd.
See link above for more implementation details.

crm, crf, icrf, factor_functions:

Added helper functions for rnea_grad.
cross_operator (crm in spatial v2) computes for any vector v the operator v x (v cross)
dual_cross_operator (crf in spatial v2) computes spatial/planar cross product operator force. Essentially calls -self.crm(v).T
icrf implemented in main branch and used in rnea_grad. Helper function defined in spatial_v2 extended library and called by idsva (main branch) and rnea_grad
factor_functions is a helper function defined in spatial_v2 extended library for use in rnea_grad() and idsva().

apply_external_forces:

Added implementation based on spatial v2 linked above.
Function subtracts external forces from parameter input f_in.
Needs further testing before implementation is complete.

Tests
Ran in terminal from forked repo here at base of working directory:
https://github.com/kawotwi/GRiD/tree/floating-base
***NOTE: You may need to edit import statements to reflect directory structure.
iiwa14.urdf testing

python printReferenceValues.py iiwa.urdf -f
python printReferenceValues.py iiwa.urdf

hyq.urdf testing

python printReferenceValues.py hyq.urdf -f
python printReferenceValues.py hyq.urdf

Benchmark testing against Matlab values using the following sequence: (These instructions are in the previous pull request here: https://github.com/A2R-Lab/RBDReference/pull/5)

Run python compare_rnea_fb_spatial.py INSERT_URDF.urdf -f which will print the exact q, qd, qdd necessary for any spatial floating base algorithms to account for floating base joint inserted at the next step. Essentially what this file is doing is creating a format compatible with Matlab. Matlab for floating base joints expects the quaternion (xyzw for spatial_v2) and xyz location of the floating base joint, then a separate list for the joint angles sized appropriately for the respective urdf.
Generate floating base URDF for Matlab testing in terminal at base of working directory of GRiD using python generate_spatial_model.py INSERT_URDF.urdf -f to generate INSERT_URDF.m file. This effectively adds a floating base joint at the base of the URDF for Matlab.
Place the newly generated urdf.m file in working directory of spatial_v2_extended
Run the addPath function in Matlab commented at the top of the matlab_dynamics_test_script.m to make sure directories are sourced correctly.
Within the test script, paste the exact outputs from q, qd, qdd from the first step with brackets as inputs to the dynamics functions.
Run matlab_dynamics_test_script.m to familiarize yourself and see input structure. It will output floating base tau from RNEA, H (output of CRBA joint space inertia matrix), and Hinv (analytical inverse of joint space inertia matrix)
To test rnea_grad do the following: [dtau_dq, dtau_dqd] = ID_derivatives( fb_model, q_fb, qd_fb, qdd_fb )

@plancherb1 Edits for rnea_grad and external forces. (Some testing still needed to be done for external forces but should be minor.)


Connection security certificates

In the Connection Security section it mentions the following:
By default, the certificate used for RDP encryption is self-generated by the OS during the deployment. If desired, customers may deploy centrally managed certificates issued by the enterprise certification authority. For more information about configuring certificates, see Windows Server documentation.
Which OS generates the cert, the client or session host?  At the end, it says you can use a CA to create your own certs but the link goes to Remote Desktop Listener certs for Windows 2012.  I am trying to determine if I need to use internal CA for certificates and how to configure WVD to use the CA instead of the self-generated certs. Would be nice to have more clarification if this is even a recommendation for WVD.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f5e20117-5458-fd52-7594-5854f349573d
Version Independent ID: 271a354c-7451-647f-6233-0011cc4ce181
Content: Understanding Windows Virtual Desktop network connectivity - Azure
Content Source: articles/virtual-desktop/network-connectivity.md
Service: virtual-desktop
GitHub Login: @gundarev
Microsoft Alias: denisgun

Hi, we are investigating your issue and will update you shortly.

@wilbug1git1 The OS of the session host is what generates the certificates, and you can add / change the listener certificates for RDP connections.
Adding your own certs is an additional layer of security if desired. Only users who have the custom cert installed can connect to the RDS deployment.

@wilbug1git1 We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Make ${{ PREFIX }} and other "build-time" vars available in script section?

I am wondering if it would be useful to add some variables only in the script section.
Because it would make it less annoying to deal with Windows vs. Unix env vars.
E.g. this:
    - if: unix
      then:
        - cargo install --locked --root $PREFIX --path . --no-track
      else:
        - cargo install --locked --root %PREFIX% --path .  --no-track

Could be written as:
script: cargo install --locked --root ${{ PREFIX }} --path . --no-track

However, some variables introduce a "dependency" on the parsing (for example, PREFIX usually needs the package name to be available, because the directory looks something like /bld/<package-name>-<timestamp>/placeholder).

Actually, it might also be nice to have ${{ PYTHON }} availalbe (which depends on ${{ PREFIX }}.
Maybe we should render this part with another Jinja context ...

The reason why it's nice is that it works cross-platform regardless of the shell. Switching to deno_task_shell would also work, but not sure if that's a better solution.

Apologies, the issue I tagged above may be a new issue. This was the closest similar issue I could find.

No this is fine and is the correct issue indeed! :)

We also have a PR for it: https://github.com/prefix-dev/rattler-build/pull/894

Initial version of this is merged!


No !important for visibility classes please.

Hello,
I see this has been reference in #6024, #6050 and #6051 and I have to raise this issue again.
@rafibomb You said, "Visibility classes need important because they are too easy to override."
I have never on my sites I have built with hiding content...that is until now. I was using .hide to hide content and then using javascript to reveal content when a person performed an action. I upgraded to a new version and all of the sudden all of my JS was broken. NOTHING was revealing. I now have to go through all of my sites when I upgrade them and remove hide and replace with style:display:none; so my javascript will function again. (I hope I have everything changed and don't get a call tomorrow from a client telling me something is broken because I missed it!)
I would really like to see this reverted back to it without a !important because this is causing way more problems than not having the !important.
Also, if a person is having trouble with something not hiding (because of the lack of !important) it is very easy for them to override other styles to hide it.
I believe @wolfgang-demeter had a pull request to revert this back. I must agree with @nblum "an important in a framework stylesheet is realy ugly... can't understand this"
Is there a specific use case for why this was done other than they are too easy to override?

I can give you a basic example.
.button.expand {
  display: block; }

.hide {
  display: none; }

You could argue that this makes a good case against our style of writing CSS classes, but I don't know if that's likely to change, in this version of Foundation or the next. To be sure, the framework as it currently is has a little too much !important going on. Ideally the usage is none, except on these visibility classes. A well-written CSS component will avoid those specificity issues from the beginning and not resort to hacks.
The bigger issue is that we shouldn't have slipped an !important into an existing class that was widely used, when the framework is over a year old. What if we just revert that one change and keep the rest of the classes as they are? Changing any of the existing visibility classes to not use !important would be a breaking change in the same way changing !hide was.

Thank you for the example. I think you hit the target when you said:
"The bigger issue is that we shouldn't have slipped an !important into an existing class that was widely used, when the framework is over a year old."
The hide class is the one I use the most frequently removing the !important would benefit me and even adding another class, such as hide-important or something of that nature for when we run into an issue with hiding an item. Of course there is probably a better way to phrase the class but that is the idea.
Also, and I believe this is has been mentioned for F6, is less CSS Specificity would help this issue as well.

Yep, we're looking at potentially using less tag selectors and more classes, which means less nesting and less specificity.

Thank You @gakimball!

Version 5.4.7 also introduced visibility: hidden;! To make .hide work again as expected - like in previous versions - this has to go to. I mentioned that in my - then declined - Pull Request (https://github.com/wolfgang-demeter/foundation/commit/dee0ca2463b7073284a55373eb646c4d8efcb9c4 and https://github.com/zurb/foundation/pull/6051).
But thankfully this abominiation has an end! ;)

Done and done. 8bed21e7aa843b1e2be32f120d178c92892484f8


Add the Item Share plugin

This plugin gives players the ability to share items from their Equipment, Inventory, Bank, and GIM Storage to other players within their invite-only group
https://github.com/vyxyl/runelite-item-share

I almost forgot to add the 3rd party server warning message
The server code is here:
https://github.com/vyxyl/runelite-item-share-aws
Is there a way to give Runelite developers the ability to control + verify the server?
ex. Adding them as a user to AWS

There isn't a way for us to verify what is running on the server without administrating it ourselves, which we will not do.
You are doing a lot of accesses to client data off the client thread(I think, your code is incredibly difficult to read) , which is generally invalid. You should develop with -ea added to your vm arguments to check for this behavior

@abextm Thank you for your review!
I was able to verify that -ea was added to the vm options during development + data accesses were under the client thread
Just to be extra sure, I wrapped client calls with ItemShareState.clientThread.invokeLater
I also removed the unused assets + moved the readme screenshots out of the resources folder
Let me know if you would like any other changes!

you need to remove your navbutton on 'shutDown`.
also I don't require it, but generally things like
logger.error("Failed to save player: " + e.getMessage());
e.printStackTrace();

should be
log.warn("Failed to save player", e);

since printStackTrace goes to the void, also you should prefer using format placeholders {} to concats in logs

@abextm Thank you again for your review, let me know if there needs to be any other changes

This repo has been deleted. The question mark link leads to 404 on the plugin hub.


WIP: Port @babel/preset-modules to SWC

This is a port of @babel/preset-modules to SWC. As with the original, this produces smaller output when targeting browsers supporting esmodules that just works around browser bugs as opposed to compiling to ES5. This was later integrated into @babel/preset-env, and I think that would be a good idea for SWC's preset-env as well.
This is just an initial PR to get feedback on the approach and whether this would even be accepted into SWC. Also left some questions below.

[x] transform-async-arrows-in-class
[x] transform-edge-default-parameters
[ ] transform-edge-function-name
[ ] transform-jsx-spread - do we want to take the same approach with a separate implementation or combine this into the existing JSX transformer? I also noticed a currently unused use_spread option in the existing one.
[ ] transform-safari-block-shadowing - not needed, SWC always renames shadowed variable declarations, even with let
[ ] transform-safari-for-shadowing - same as above
[ ] transform-tagged-template-caching

cc. @developit

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think it's a good change. Thank you for sending the PR and I will accept it.
I'll take a look at the changes.

I think this is ready for review! Added a bugfixes option to the env config, which applies the bugfix passes and overrides the versions for other passes. Data copied from Babel. Tested manually via the CLI as well and it appears to work.
Also, while @babel/preset-modules has a JSX spread transformer, @babel/preset-react instead has a useSpread option. This makes sense because JSX transformation is not included in preset-env, so I've replicated that here as well. It does mean that it isn't turned on automatically based on env versions though. Not sure if we want to do that somehow. Also, not quite sure why it's in preset-modules to begin with since object spread isn't even supported until Edge 79 I think... @developit do you remember?


iTerm2 image support

Fixes https://github.com/buildkite/terminal/issues/8

Ooooer! Code looks good :+1:


Add SCAR to Landscape

Pre-submission checklist:
Please check each of these after submitting your pull request:

[X] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[X] Is your project closed source or, if it is open source, does your project have at least 250 GitHub stars?
[X] Have you picked the single best (existing) category for your project?
[X] Does it follow the other guidelines from the new entries section?
[X] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[X] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[X] Does your project/product name match the text on the logo?
[X] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] 2 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape failed.
Built with commit 11e275f8f542c5d08ed7aff7cc97c3bece9cb273
https://app.netlify.com/sites/landscape/deploys/5b3e2755fdd72a1fe6469416

Mmmm, the build failed due to:
error: Cannot fetch: https://github.com/apache/incubator-dubbo Error: read ECONNRESET
should I close the PR and open a new one? is the CNCF-Bot going to retry in several minutes?
thanks

I smacked it to get it to work. Please consider creating a Twitter account for the project.

LGTM


error

I encountered this problem.
Traceback (most recent call last):
File "demo.py", line 84, in
vert = sess.run(model.output3, feed_dict=feed_dict)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 895, in run
run_metadata_ptr)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1124, in _run
feed_dict_tensor, options, run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1321, in _do_run
options, run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1340, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: <excephtion str() failed>
Did someone encounter this problem? thanks!

The problem may be related to pre-trained model loading. Please check you have pretrained ckeckpoint file in correct directory and you have correct version of requirement libraries.

Hi,
Do you know how to download the dataset and unzip it from the link below?
https://drive.google.com/open?id=131dH36qXCabym1JjSmEpSQZg4dmZVQid


Action using dockerfile without going through dockerhub

Openwhisk can create an action through a docker image in the dockerhub. But the process of uploading and pulling images on the dockerhub seemed cumbersome.
Is there a way to create an action with the Dockerfile itself without going through dockerhub? It seems to be possible by building a docker locally on user's openwhisk server.
User will be able to administrate by build own Dockerfile with tag like wsk create action example exec --dockerfile ./Dockerfile --tag user/example

Related to https://github.com/apache/incubator-openwhisk/issues/1362#issuecomment-337943114.

Hi, this sounds great, but haven't received much attention or so it seems based on this thread :) Are there any plans about supporting Dockerfile-based action builds? Thx.

This would be a good feature, I agree. Are you interested in working on this?


Migrate Visualization operators to the new engine

Although the current Amber engine codebase isn't very polished, it is possible to migrate visualization operators to the new engine.
Frontend code need less changes. The only change needed might be on the data format, because current engine does not support dynamic schema.
To minimize code changes to backend engine, what we can do now is treat visualization operators as normal aggregation operators. In the workflow layout, they need to be followed by a 'view result' operator, which is the only sink operator now. This way no new sink will be introduced. But the response format do need changes. (Chart type need to be injected)
Since visualization operators are essentially aggregations, and because Amber is distributed, visualization operators also need to be written as distributed aggregations.

done


Handle Biblical sort order for repos with a sort order in the manifest

New TSVs don't have a sort order in the  filename anymore. Files listed in the stepper or side menu should be listed in Canonical order as specified in the manifest. If there isn't an order specified then it should be alphabetical.

ready for testing
https://develop--tc-create-app.netlify.app/
translationCore Create - v1.2.0-rc.4 build 33-43fd9f5

v1.2.0-rc.4 build 33-43fd9f5
I'm seeing alpha sort order for twl's even though the manifest does supply the sort order. What am I missing?

Not seeing the change as per the description in the issue in translationCore Create - v1.2.0-rc.4 build 33-43fd9f5.
The manifest does have the sort order but the TWL resource shows books in alphabetical order.

ready to RE-test
https://develop--tc-create-app.netlify.app/

Looks good in translationCore Create - v1.2.0-rc.5 build 34-ab649d5. Seeing the biblical sort order as per the manifest.

In v1.2.0-rc.5 build 34-ab649d5 I am now seeing the correct sort order for tWL.


Design a logo

Use the FPGA idea (connecting circuits on the top-right, library name in the center)

May add a small Qt-based utility to draw it programatically.

Done!


Small tweaks to Docker

Adds cleanup after apt get, removes a potential double Node install, and enforces stopping at the first error when building Automata. This should hopefully allow for better debugging, if not fix why Docker cannot generate indices.

Great work, @NolanTrem!


Cross compile to .NET Core 3.0

We should start cross compiling to .NET Core 3.0.
Certain C# 8 features (ranges, async streams) are only available there. We also want to be compatible when 3.0 RTMs.
I think we can handle this with one global tool package, but this needs to be checked.

Is this a reason why System.Text.Json is inaccessible for me even through I have the preview SDK for .NET Core 3 installed?
I also noticed that when I switch from netcoreapp2.0 to netcoreapp3.0 in omnisharp.json, everything in VS Code basically starts erroring out - but this is probably an OmniSharp issue completely outside of dotnet-script, correct?

@TomasHubelbauer We have just started looking into .Net Core 3.0 so this is not something that is supported yet. There is a twofold story to supporting .Net Core 3.0. First of all, dotnet-script needs to ship as a netcoreapp3.0 app so that it knows how to execute these scripts. Then there is the OmniSharp side that needs to be updated to handle metadata references from a .Net Core 3 app.  OmniSharp uses the Dotnet.Script.DependencyModel library for that. This library ships with the C# extension and is not tied to the installation of dotnet-script you have on your machine.
So we are working with getting the dependency model to work with .Net Core 3. Once we have that ready, we can update both dotnet-script itself and the OmniSharp bits.

this is done


Support specifying map boundary and warn for giant maps

This means that users will be able to specify just the area they want to map, and thus orphaned tiles outside of that area won't result in a huge map.

It'd also be nice to detect orphaned tiles somehow, but I have no idea where I'd begin on that one.

For giant map, it can be useful to make the image chunk-by-chunk.


To regression problem?

Hi, thanks for opening the code.
Can I use this model to solve regression problem?

Thanks for your interest!
The native code supports classification only.
I think with some modifications it should be able to handle regression, basically changing the BCE classification loss into a regression loss, and substituting label embedding from one-hot classes into something continuous.


add embedded database h2 and update embedded zookeeper

for better fast experience, add embedded database h2 and update embedded zookeeper

Codecov Report

Merging #2082 into dev will decrease coverage by 0.04%.
The diff coverage is 99.04%.

@@             Coverage Diff              @@
##                dev    #2082      +/-   ##
============================================
- Coverage     33.17%   33.13%   -0.05%
  Complexity     1552     1552
============================================
  Files           313      313
  Lines         15528    15529       +1
  Branches       1886     1886
============================================
- Hits           5151     5145       -6
- Misses         9849     9855       +6
- Partials        528      529       +1

Impacted Files
Coverage Δ
Complexity Δ

...scheduler/api/controller/DataSourceController.java
2.19% <0%> (ø)
2 <0> (ø)
:arrow_down:

.../org/apache/dolphinscheduler/api/enums/Status.java
100% <100%> (ø)
5 <3> (+1)
:arrow_up:

...scheduler/alert/template/AlertTemplateFactory.java
42.85% <0%> (-14.29%)
2% <0%> (ø)

...he/dolphinscheduler/common/thread/ThreadUtils.java
71.18% <0%> (-10.17%)
12% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25bedfe...de0ea19. Read the comment docs.


BLE Hub for discovery on iOS

The scenario is that multiple iOS devices are in the room and are running in the background. They can see if someone is a peripheral but can't be peripherals themselves. So what we want to do is to enable both iOS apps in the foreground as well as Android apps (hopefully in the background too but we'll see) to act as Hubs who can relay discovery information for the iOS centrals running in the background.
In other words if user A pulls out their phone and can now act as a peripheral we want them to be able to be connected to by the other iOS devices running in the background, receive their discovery announcements and then relay those discovery announcements to the other iOS devices running in the background. When this happens we also need to be able to relay any requests that result from discovery.
In other words if device C receives via device A a discovery announcement from device B and C wants to respond then C needs to send its response via A.
In an ideal world we will be able to build all this logic at the node.js layer and just use a standard BLE API to talk to the BLE stacks on both Android and iOS.

If our investigations of running central and peripheral work out as they look to be then we wouldn't need the BLE Hub at all!


Where to put Static Meshes?

The readme example shows an Art folder that also has Animations and Sounds, so I guessed there at first. But then, the readme also mentions an Environment folder later on ("Want to view only static mesh in Environment/Rocks/?").
So, is it Content/Art/Subfolder or Content/Environment/Subfolder?
Also, I suggest that it gets clarified in the readme for newbies like me.

Static mesh are a type of files. The location depends on the purpose of it. For Meshes used for a map, environment, I think Content/Env/{NameOfTheMap}(optional)/Rocks should do it. Depends on hierarchy too. Do you want all your static mesh in one big folders organised by type of meshes. Or do you want a folder with the map name, and all used meshes in this map.
Depends on the way you handle levels.
Same question can be asked for textures and materials. I personally think the way of
/MapName/Meshes
/MapName/Textures
/MapName/Material
Work best, as a team of level designer doesn't usually play with material or textures so much. All they want is quick access to meshes


Collaborate with dependency-track to use it as NVD proxy endpoint

Is your feature request related to a problem? Please describe.
We (like probably many others) used dependency-track  (prior dependency-check v9+) as proxy for NVD (legacy/non API V2) and other feeds.
This greatly lowers the load on public feed endpoints and makes CI pipelines using dependency-check more robust.
Dependency-track V4.10.0+ provides NIST NVD API v2 support (with API key etc).
Describe the solution you'd like
We would like to use its NVD endpoint for dependency-check (like we used to).
 dependency-check.sh Core  --updateonly  --nvdDatafeed=https://{{ endpoint }}/mirror/nvd
Describe alternatives you've considered
I understand that one can create a proxy with the vulnz cli and I have (as a test) been able to make the cached content from vulnz work via the http endpoint.
However, the dependency-check project collaborating with the dependency-track project would help the community significantly.
Here is what I did to research this a bit more ...
The cached (by dependency-track V4.10.0)  NVD files look like
nvdcve-1.1-{{ year }}.json
nvdcve-1.1-{{ year }}.json.gz
nvdcve-1.1-{{ year }}.json.gz.ts
nvdcve-1.1-{{ year }}.meta
(...)
nvdcve-1.1-modified.json
nvdcve-1.1-modified.json.gz
nvdcve-1.1-modified.json.gz.ts
nvdcve-1.1-modified.meta

I noted that the cache.properties is missing (that I understand you potentially would like to remove as a requirement).
I tested if I can create the cache.property file out of the meta data available.
 $ export p=../nist-orig; export c="${p}/cache.properties"; echo "prefix=nvdcve-1.1-" > "${c}"; for i in $(seq 2002 2023); do echo "lastModifiedDate.${i}=$(grep lastModifiedDate ${p}/nvdcve-1.1-${i}.meta|sed 's#lastModifiedDate:##g'|sed 's#:#\\:#g')" >> "${c}"; done; echo "lastModifiedDate.modified=$(grep lastModifiedDate ${p}/nvdcve-1.1-modified.meta|sed 's#lastModifiedDate:##g'|sed 's#:#\\:#g')" >> "${c}"
creating this file.
prefix=nvdcve-1.1-
lastModifiedDate.2002=2023-11-07T03\:04\:03-05\:00
lastModifiedDate.2003=2023-11-07T03\:03\:59-05\:00
lastModifiedDate.2004=2023-11-07T03\:03\:57-05\:00
lastModifiedDate.2005=2023-11-08T03\:02\:12-05\:00
lastModifiedDate.2006=2023-11-29T03\:01\:23-05\:00
lastModifiedDate.2007=2023-12-08T03\:03\:39-05\:00
lastModifiedDate.2008=2023-12-08T03\:03\:33-05\:00
lastModifiedDate.2009=2023-12-08T03\:03\:26-05\:00
lastModifiedDate.2010=2023-12-08T03\:03\:20-05\:00
lastModifiedDate.2011=2023-12-08T03\:03\:13-05\:00
lastModifiedDate.2012=2023-12-08T03\:03\:06-05\:00
lastModifiedDate.2013=2023-12-09T03\:02\:56-05\:00
lastModifiedDate.2014=2023-12-09T03\:02\:47-05\:00
lastModifiedDate.2015=2023-12-09T03\:02\:40-05\:00
lastModifiedDate.2016=2023-12-09T03\:02\:31-05\:00
lastModifiedDate.2017=2023-12-09T03\:02\:19-05\:00
lastModifiedDate.2018=2023-12-09T03\:01\:55-05\:00
lastModifiedDate.2019=2023-12-09T03\:01\:36-05\:00
lastModifiedDate.2020=2023-12-11T03\:01\:28-05\:00
lastModifiedDate.2021=2023-12-11T03\:01\:03-05\:00
lastModifiedDate.2022=2023-12-11T03\:00\:38-05\:00
lastModifiedDate.2023=2023-12-11T03\:00\:14-05\:00
lastModifiedDate.modified=2023-12-11T06\:00\:01-05\:00

but that failed with
$ dependency-check.sh Core  --updateonly  --nvdDatafeed=https://{{ endpoint }}/mirror/nvd
[INFO] Checking for updates
[INFO] NVD API Cache requires several updates; this could take a couple of minutes.
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2012.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2012.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2023.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2023.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2011.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2011.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2022.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2022.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2010.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2010.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2021.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2021.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2020.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2020.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2009.json.gz
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2009.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] Download Started for NVD Cache - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2008.json.gz
[ERROR] The execution of the download was interrupted
org.owasp.dependencycheck.data.update.exception.UpdateException: The execution of the download was interrupted
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDownload(NvdApiDataSource.java:261)
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDatafeed(NvdApiDataSource.java:156)
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.update(NvdApiDataSource.java:108)
	at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:906)
	at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:878)
	at org.owasp.dependencycheck.App.runUpdateOnly(App.java:427)
	at org.owasp.dependencycheck.App.run(App.java:172)
	at org.owasp.dependencycheck.App.main(App.java:89)
Caused by: java.util.concurrent.ExecutionException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
	at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDownload(NvdApiDataSource.java:251)
	... 7 common frames omitted
Caused by: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
	at com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61)
	at com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1153)
	at com.fasterxml.jackson.databind.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:2224)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownProperty(BeanDeserializerBase.java:1719)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownVanilla(BeanDeserializerBase.java:1697)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:316)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:177)
	at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:342)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4899)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3846)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3814)
	at org.owasp.dependencycheck.data.update.nvd.api.DownloadTask.call(DownloadTask.java:95)
	at org.owasp.dependencycheck.data.update.nvd.api.DownloadTask.call(DownloadTask.java:42)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
[INFO] Skipping RetireJS update since last update was within 24 hours.
[INFO] Skipping Hosted Suppressions file update since last update was within 2 hours.
[INFO] Updating CISA Known Exploited Vulnerability list: https://www.cisa.gov/sites/default/files/feeds/known_exploited_vulnerabilities.json
[INFO] Begin database defrag
[ERROR] Error downloading NVD CVE - https://{{ endpoint }}/mirror/nvd/nvdcve-1.1-2008.json.gz Reason: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
[INFO] End database defrag (257 ms)
[ERROR] The execution of the download was interrupted
org.owasp.dependencycheck.data.update.exception.UpdateException: The execution of the download was interrupted
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDownload(NvdApiDataSource.java:261)
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDatafeed(NvdApiDataSource.java:156)
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.update(NvdApiDataSource.java:108)
	at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:906)
	at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:878)
	at org.owasp.dependencycheck.App.runUpdateOnly(App.java:427)
	at org.owasp.dependencycheck.App.run(App.java:172)
	at org.owasp.dependencycheck.App.main(App.java:89)
Caused by: java.util.concurrent.ExecutionException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
	at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
	at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDownload(NvdApiDataSource.java:251)
	... 7 common frames omitted
Caused by: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "CVE_data_type" (class io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20), not marked as ignorable (7 known properties: "startIndex", "totalResults", "resultsPerPage", "format", "version", "vulnerabilities", "timestamp"])
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 2, column: 22] (through reference chain: io.github.jeremylong.openvulnerability.client.nvd.CveApiJson20["CVE_data_type"])
	at com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61)
	at com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1153)
	at com.fasterxml.jackson.databind.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:2224)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownProperty(BeanDeserializerBase.java:1719)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownVanilla(BeanDeserializerBase.java:1697)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:316)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:177)
	at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:342)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4899)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3846)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3814)
	at org.owasp.dependencycheck.data.update.nvd.api.DownloadTask.call(DownloadTask.java:95)
	at org.owasp.dependencycheck.data.update.nvd.api.DownloadTask.call(DownloadTask.java:42)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

The other way to create the mirror is with the vulnz CLI - and with 5.1.0 it now produces the meta files as well. I plan on updating ODC to use the meta files.

The URLs provided make it look like the provided cache is using the 1.1 schema as opposed to the 2.0 schema?

@jeremylong I think you're right. The dependencytrack documentation (https://docs.dependencytrack.org/datasources/nvd/) is somewhat vague or confusing after the migration to NVD API, but to my understanding

dependencytrack will continue to mirror the NVD data feeds (no updates after 15.12.2023 I guess)
and encourage to switch to NVD REST API mirroring

But nowhere is it stated or documented, that dependencytrack will allow other tools - e.g. dependency-check - to utilize the NVD API mirror or proxy.
I guess, I and others are hoping to utilize the dependencytrack NVD API data through some mirror or proxy functionality as opposed to fetching it from NVD API (or through some caching mechanism) for dependency-check.
At least, this is what we used to do, for dependency-check prior to 9.0.0 and dependencytrack prior to 4.10.0, where we pointed the dependency-check update url to dependencytrack's mirror like
cve {
   urlModified = 'https://dependencytrack/mirror/nvd/nvdcve-1.1-modified.json.gz'
}

The only thing I know of that can create a cache of the NVD API 2.0 data is the vulnz cli. If dependency-track has a way to mirror the data in the same schema as available from the NVD API (currently 2.0) then we can likely figure something out.

The only thing I know of that can create a cache of the NVD API 2.0 data is the vulnz cli. If dependency-track has a way to mirror the data in the same schema as available from the NVD API (currently 2.0) then we can likely figure something out.

I believe dependency-track (v4.10.0) already uses a client library from open-vulnerability-clients to implement the mirroring. Class org/dependencytrack/tasks/NistApiMirrorTask.java (https://github.com/DependencyTrack/dependency-track/blob/master/src/main/java/org/dependencytrack/tasks/NistApiMirrorTask.java) has dependencies on io.github.jeremylong.openvulnerability.client.*
I don't know how the NVD API 2.0 data is persisted in dependency-track v4.10.0.
It would be really useful to take advantage of the dependency-track NVD mirroring feature in dependency-check. Both projects are related to OWASP. Thank you for your work!

The feeds provided by DT are still the original 1.1 feed files as served by the NVD. DT does not convert the data from the NVD REST API to the feed format.
The problem is that DT itself does not need large chunks of the data returned by the NVD. It only persists in its database what it really needs. It's thus not possible to generate the original feed files based on that data alone.
The way the NVD REST API is to be consumed also makes it hard to generate feed files: CVEs are provided based on their last modification date, not their publish date. The latter is how the feed files were organized. If you want to replicate that, you have to keep all CVEs in memory, then at the very end group them by publish date, and finally write that to partitioned nvdcve-1.1-<YEAR>.json files.
From what I understand, that is pretty much how vulnz is doing it. That approach is fine for a short-lived CLI application, but not for DT, which is a long-running application that has many more responsibilities to fulfill concurrently. This type of cache management is very memory and I/O heavy, even more so when the cache is supposed to be updated regularly.
I think it might be the easiest to point both DT and DC to the same, vulnz-generated cache.

I am experimenting with dumping the raw data into a Lucene index and have it indexed by CVE ID and last modification timestamp. Theoretically, using this, DT should be able to emulate the REST API responses of the NVD, serving CVEs which have been modified since a given timestamp.

I think the above is a workable solution. @jeremylong as long as users are able to customize the NVD REST API URL in DependencyCheck, DT can act as a cache for it (https://github.com/nscuro/dependency-track/commit/4e63ee94e9d2c132fda4354e4265e07b30dd9761). I already tested with two DT instances, and one is able to pull CVE data from the other's mirror just fine this way.
Are there any other query parameters than lastModStart and lastModEnd that DependencyCheck might use? The Lucene-based approach gives us more flexibility than static files, but also requires us knowing the fields that clients may filter by.

thanks for the quick turn-around, @jeremylong !
We have started to integrate dependency-check 9.0.5 yesterday, and will be able to test the resolution of this enhancement as soon @nscuro  integrates his work in an upcoming release dependency-track ...


Turn off two-factor authentication on Electron_Cash_wallet

I have tried to turn of my two-factor authentication on Electron_Cash_wallet by sweeping private keys and by restore wallet. When I put in the list of private keys, I cannot sweep, the button (sweep) stays gray. When I restore my wallet as a standard wallet, my wallet has 0 balance.
Can Anyone help me? Best, Ronald

Most 2FA discussion should happen here: #41


Recording problem in eu-south-1 and af-south-1

Describe the bug
Even though we turn on the region and wait for a couple of days, we still can't use media pipelines to record chime meetings in these two regions (eu-south-1 and af-south-1).
To Reproduce
Even though we successfully turn on the recording, we don't receive any content in the S3 bucket in the same way as we got the content in the different regions. However, the recording pretends to be successful. We also receive events through the event bridge about the recording. So everything seems to be successful. But there is no content in the S3 bucket.

In the Chime SDK Available regions guide, eu-south-1 and af-south-1 are marked with *.

Regions marked with an asterisk (*) must be enabled in your AWS account. For more information, refer to Enabling a Region in the AWS General Reference.

Have you enabled these two regions in the AWS console? If not, you can follow the steps:
https://docs.aws.amazon.com/general/latest/gr/rande-manage.html#rande-manage-enable

Yes, we enabled it and even waited for a few days. And still, it doesn't work

Hello @vknaisl, Can you provide a sample requestId or invoke the API and provide the request body for us to further debug?

Hi @vknaisl, our log shows IllegalLocationConstraintException, could you please double check if the S3 bucket provided in CreateMediaCapturePipeline request belongs to the same AWS Region as the Amazon Chime SDK meeting? https://docs.aws.amazon.com/chime-sdk/latest/dg/create-s3-bucket.html

Hi,
No, the meeting is in the region eu-south-1. However, the S3 bucket is in us-east-1 region. We didn't know that. Nevertheless, for the rest of the regions except eu-south-1 and af-south-1, it works. Can you please explain me why it works?
Thanks!
Vojtech

Hi @vknaisl , Customer will see failures when

meeting is in manual-enabled region while S3 bucket is in a different region
S3 bucket is in manual-enabled region while meeting is in a different region

Because S3 has limitation on the manual-enabled region, either of above scenario will cause a failed S3 operation failure, so in the developer doc, we ask customer to make the bucket and meeting in the same region to avoid failure.

Hi,
Thanks for the explanation. We created a bucket for each region and it helped :)
Vojtech


How to add a node at runtime or in dynamic data compared all the nodes and added where needed.

What is the actual behavior/output?
I need to add a kr3 child node into the obj_1 parent node.

What is the behavior/output you expect?
[Replace with your answer if relevant]
We need to add these nodes at runtime or when refreshing a page.

This is now possible
see also
https://github.com/bkrem/react-d3-tree/issues/403


Add :exception_handler to RESERVED_KEYS

Rails will wrap this in a SafeBuffer if this isn't done.

@aaronjensen Do you have some more information about what you mean by:

Rails will wrap this in a SafeBuffer if this isn't done.

i.e. a way to reproduce the problem that you were seeing that this PR fixes?

I'm definitely sorry about the poor pull request message. Unfortunately, this was 2 years and 2 projects ago, so I couldn't tell you what problem I was fixing.
It seems like no one else has run into it since then either, so this can probably be closed out.

No worries at all! At least this'll still be around if someone else finds it.


Flash Player

Is there any way to play flash video?

There was some work on it here: https://github.com/scrapinghub/splash/pull/454

Many thanks!


Unable to deploy a single war from multi-war project

When multiple war files are produced by a single gradle project, you cannot choose just one to bundle with liberty. Using the following configuration to select just one of the war task:
liberty {
  server {
    deploy {
      apps = [libertyWar]
    }
}

Results in the following message:
At least one application is not defined in the server configuration but the build file indicates it should be installed in the apps folder. Application configuration is being added to the target server configuration dropins folder by the plug-in.

And an installed_apps_XXXXXXXXXX.xml config file generated under configDropins/defaults which interferes with the intended configuration.

What is getting added to the installed_apps_xxx.xml file? All the war files or just the libertyWar one specified in the apps attribute? Is the libertyWar application configured in your server.xml?

In generated install_apps_configuration_xxx.xml file contains
<?xml version="1.0" encoding="UTF-8"?>
<server>
    <webApplication id="foo-app" location="foo-app.war" name="foo-app"/>
    <webApplication id="foo-app" location="foo-app.war" name="foo-app"/>
</server>

The source server.xml contains
<?xml version="1.0" encoding="UTF-8"?>
<server description="foo-server">
    <application name="foo" context-root="/" location="foo.war" type="war"/>
</server>

The libertyWar war task produces foo.war

Can you provide the rest of the build.gradle file? Or a sample test project for us to reproduce?

@cmuchinsky Is this issue still a problem for you? If so, can you provide a sample test project so we can recreate the issue?

I believe this is still a bug, but have since refactored my build to work around it by not having more than one war file produced from a single gradle build.


Cannot update to latest version 2.1.4

I cannot update either with the Update button or by selecting Version 2.14
Why is version 2.12 not listed?
Shouldn't version 2.13 also be listed, even though it is installed?
See screenshot:

I think the 2.1.2 release is essentially non-existent due to an issue with not updating library.properties correctly. So 2.1.3 is 2.1.2.
In the screenshot above, 2.1.3 is not in the drop down list since it is the currently installed version.

What happens when you try installing 2.1.4?

Thank you.
As shown in my earlier screenshot, after using Manage Libaries > Update on RTClib, it does not get implemented. Restarting IDE 1.8.19 shows the version apparently unchanged.

@terrypin999 omitted some important information from this report:
https://forum.arduino.cc/t/cannot-update-rtclib/1246598

I've just tried IDE 2.3.2 which is much more informative, telling me:
Failed to install library: 'RTClib:2.1.4'.
Error: 3 INVALID_ARGUMENT: The library RTClib has multiple installations:
and listing several, all beginning with 'RTClib'.

@terrypin999 you also left out the part of the error message that gives instructions for how to solve the problem.
As explained by the error message from Arduino IDE 2.x, this problem occurs when there are multiple multiple installations of a given library. Libraries are identified by the name field in the library.properties metadata field. This means that it is possible to have multiple installations of a given library because, even though they must have different installation folder names to coexist in the file system, each library can have the same name field value in the metadata. Unless there is a malfunction, the Arduino IDE Library Manager will never produce multiple installations of a given library, but it can easily occur when the user installs libraries manually.
I'll provide instructions you can follow to reproduce the fault:

Use the Arduino IDE Library Manager to install version 2.1.3 of the "RTClib" library.
Click the following link to download a ZIP file of the library:
https://github.com/adafruit/RTClib/archive/refs/tags/2.1.3.zip
Unzip the downloaded file in the libraries subfolder of your sketchbook folder.
ⓘ You can also do this using the "Add .ZIP Library..." feature of Arduino IDE 1.x, but the feature in Arduino IDE 2.x is smart enough to not generate a redundant installation so you must do a fully manual installation to reproduce the fault if you are using 2.x.
Use the Arduino IDE Library Manager to update the "RTClib" library.

The update fails. If you are using Arduino IDE 2.x, you will see this error message like this in the "Output" panel:
Failed to install library: 'RTClib:2.1.4'.
Error: 3 INVALID_ARGUMENT: The library RTClib has multiple installations:
- C:\Users\per\Documents\Arduino\libraries\RTClib
- C:\Users\per\Documents\Arduino\libraries\RTClib-master
Automatic library install can't be performed in this case, please manually remove all duplicates and retry.

If you are using Arduino IDE 1.x, the more vague message is shown:
Library RTClib is already installed in: C:\Users\per\Documents\Arduino\libraries\RTClib

So @terrypin999's problem doesn't have anything to do with the codebase hosted in this library and the issue should be closed as off topic.
The failure of Arduino IDE 1.x to clearly communicate the problem to the user was certainly a defect (https://github.com/arduino/arduino-cli/issues/1871), but that defect has already been resolved to the extent possible in the years of development that have occurred since the time of the obsolete IDE version used by @terrypin999 so there is also no longer any problem in Arduino IDE.

FWIW, based on the name, this one was probably installed manually, via downloading repo zip:
- C:\Users\per\Documents\Arduino\libraries\RTClib-master


Long project names truncated

Hi Andrew,
thanks for OctoGerrit! I gave it a try for https://review.typo3.org and it looked like that:

What people mostly disturbed was:

project names cropped in list of reviews (we have pretty long ones)
centered fixed-size table

Maybe a combined fox for both - enlarging the table and giving the project name more space - would make people happier.

Thanks for the kind words. Please feel free to edit the css on your end for your needs. If you'd like 100% width table, you can find an example of how to accomplish that with the side-by-side diff css. You could also shorten the issue name/title column and expand the project name column.
We personally like the 990x max width as it's much cleaner and hides information we don't find to be essential. So while we won't be making the requested change to the css here in this repo, it's certainly possible to do so on your own copy.


502

page sendbox 页面能打开, 但是Google、YouTube等网站就会502
502 Bad Gateway
openresty
error.log
2019/06/28 13:53:43 [error] 2387#0: unexpected response for www.google.com
2019/06/28 13:53:43 [error] 2387#0: unexpected response for www.google.com
2019/06/28 13:53:50 [error] 2387#0: *1 connect() failed (110: Connection timed out) while connecting to upstream, client: <IP_ADDRESS>, server: , request: "GET /http HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/", host: "<IP_ADDRESS>.xip.io:8443"

<IP_ADDRESS> 的 DNS 连不上吗？


help: Clarify what muting means for the muted user.

We don't want to claim something so strong as the earlier
version, because the mutee can still guess that they
have been muted if the muter suddenly starts completely
ignoring messages, especially PMs.
https://chat.zulip.org/#narrow/stream/101-design/topic/Hiding.20user-muted.20messages/near/1180007

The empty space at the end if the tip seems a bit odd. Should we add something else or flesh it out a bit more?

I don't think it's a problem; we can consider adjusting the tip styling to not have a fixed width if we think it's weird.

How about moving this text from a tip to a simple bold text sentence? (Since its just information and not really a suggestion to the user to do something.)

Merged with s/user/Zulip/, since "user experience" is sorta developer speak.


Update CODEOWNERS

Makes @dotnet-maestro-bot the owner of bot-managed files.

As in aspnet/AspNetCore#9463, I'd rather we hold off on this until we can get notified automatically.

Also, realized this means we would not be notified when someone other than the bot updates any of the files the bot would now own. That's a problem because we likely will miss changes that we should have blocked or corrected before merge e.g. Version.Details.xml changes that add dependencies but don't include needed CoherentParentDependency attributes.

Added @dougbu as well as the bot so you keep getting notifications on all bot PRs.


Bot connect

Hello, I want connect bots with facebook (I have 500 cookies).
But I see "Prevent crash" and bot stop connect and continue after seconds...
I give cookies if help me to connect 100% of bots
How I solve packet error to connect all with facebook and no stop...

Does anyone else use that cookie ????

Ur probs using HTTP proxies. The one thay says prevent crash that means they offline or not working proxies are. Skype cough Mastkilxp

mastkilxp add me on skype fayizbe


fix comment

CircleCI build fails because doc check compares the existing output files from gen_onnx_mlir.py with the output that it now produces. Should a PR that changes gen_onnx_mlir.py always include the new .inc files?

Yes, always include the newly generated .inc files.

@caoimhinuibrian , you need check in your OpBuildTable.inc and ONNXOps.td.inc. That's why the check-doc failed. Before running gen_onnx_mlir.py, you need install onnx package by either "pip install onnx==1.6.0" or "pip install -e your-onnx-mlir/third_party/onnx". The prerequisite for the later one is protoc.


Message updates

Each commit either

adds a new message with the official name (Add <message>)
renames a message's name to the official name (<oldName> -> <officialName>)
updates a message's hash (Update <message>)
corrects switched hashes (Switch <message1> and <message2>)
removes an old message of a duplicate (<newMessage> replaced <oldMessage> OR (if both messages were added in the same commit) <newMessage> is a duplicate of <oldMessage>)

THANK YOU! 💯 ❤


Stats aren't working properly

Describe the bug
At the top of the page if you hover your cursor over the stats the person has (eg: Intelligence, Health, Defence) the box which is supposed to appear describing that persons stats sometimes appears pointing to different stats then the one your cursor is on.
Profile/Location
https://sky.shiiyu.moe/stats/Artinator11/Papaya
Expected behaviour
What I expected to happen was the box to appear and the stats to appear in the right place.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: 10

Seems like this is only happening with intel

I believe this was fixed in #161

I believe this was fixed in #161


Bash: $ signs are not escaped

Stand-alone Autocannon works ($'s are correctly escaped)
autocannon "http://localhost:8080/Catalog/Orders?\$top=15&\$expand=book" -c 100 -d 10
Running 10s test @ http://localhost:8080/Catalog/Orders?$top=15&$expand=book
Expected Behavior
Autocannon inside node clinic should work, too:
clinic flame --autocannon [ "http://localhost:8080/Catalog/Orders?\$top=15&\$expand=book" -c 100 -d 10 ] -- node srv/server.js
Server listens on port 8080 - Service URL: http://localhost:8080/ Running 10s test @ http://localhost:8080/Catalog/Orders?$top=15&$expand=book
Current Behavior
However, it actually behaves like this:
clinic flame --autocannon [ "http://localhost:8080/Catalog/Orders?\$top=15&\$expand=book" -c 100 -d 10 ] -- node srv/server.js
Server listens on port 8080 - Service URL: http://localhost:8080/ Running 10s test @ http://localhost:8080/Catalog/Orders?=15&=book
So the $'s are not escaped
Steps to Reproduce (for bugs)
Just execute the given commands.
Sample upload

Environment

Clinic version: v2.2.1
Ubuntu Linux 16.04
GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu)

Node version: v8.11.4

With clinic --autocannon, clinic starts the autocannon subprocess, and environment variables are also resolved at that time. We inline environment variables to support this case:
clinic flame --autocannon [ 'http://localhost:$PORT/path/to/endpoint' -d 1 ] -- node server.js

Here, $PORT will be replaced by the port that node server.js is listening on.
We could:

only inline $PORT, and not any other environment variables, which may be surprising, or;
test and document that escaping '\$top' and "\\\$top" works, which is annoying

Thanks for your answer.
I would prefer the second option since it's, as you say, less surprising and also covers more cases.
Thanks a lot!

@goto-bus-stop - Anything to action for this one?

@DylanC Looks like this was addressed. Thanks for checking in!


Remove webpack-dev-server

Fixes https://github.com/zeit/next.js/issues/236, https://github.com/zeit/next.js/issues/102
By using webpack-hot-middleware, we can use HMR from our server instead of running a dedicated server (webpack-dev-server).

Trying to run a locally built version with node dist/bin/next
getting error
ERROR in multi bundles/pages/_error.js
Module not found: Error: Cannot resolve module 'next/dist/client/webpack-hot-middleware-client' in /Users/jonas/Development/github/next.js
 @ multi bundles/pages/_error.js

Also, when adding a new page (test.js) in /dist/pages
import React from 'react'

export default () =>
hi

I get the following error:
ERROR in multi bundles/pages/test.js
Module not found: Error: Cannot resolve module 'next/dist/client/webpack-hot-middleware-client' in /Users/jonas/Development/github/next.js/dist
 @ multi bundles/pages/test.js
> Ready on http://localhost:3000
/Users/jonas/Development/github/next.js/dist/server/build/plugins/watch-pages-plugin.js:53
          return _this.prevFileDependencies.indexOf(f) < 0;
                                           ^

TypeError: Cannot read property 'indexOf' of null
    at /Users/jonas/Development/github/next.js/dist/server/build/plugins/watch-pages-plugin.js:53:44
    at Array.filter (native)
    at Compiler.<anonymous> (/Users/jonas/Development/github/next.js/dist/server/build/plugins/watch-pages-plugin.js:52:73)
    at Compiler.applyPluginsAsync (/Users/jonas/Development/github/next.js/node_modules/tapable/lib/Tapable.js:71:13)
    at Watching._go (/Users/jonas/Development/github/next.js/node_modules/webpack/lib/Compiler.js:44:16)
    at Watching.invalidate (/Users/jonas/Development/github/next.js/node_modules/webpack/lib/Compiler.js:108:8)
    at Watching.<anonymous> (/Users/jonas/Development/github/next.js/node_modules/webpack/lib/Compiler.js:93:8)
    at /Users/jonas/Development/github/next.js/dist/server/build/plugins/watch-remove-event-plugin.js:45:22
    at NodeWatchFileSystem.<anonymous> (/Users/jonas/Development/github/next.js/node_modules/webpack/lib/node/NodeWatchFileSystem.js:43:3)
    at EventEmitter.g (events.js:286:16)

@nkzawa

@jonaswindey hmm, I can't reproduce. I did clean install (rm -rf node_modules && npm i). How did you install next locally ?

mkdir tmp
git clone https://github.com/zeit/next.js.git tmp && cd tmp
npm i
node dist/bin/next

ERROR in multi bundles/pages/_error.js
Module not found: Error: Cannot resolve module 'next/dist/client/webpack-hot-middleware-client' in /Users/jonas/Development/sandbox/tmp
 @ multi bundles/pages/_error.js
> Ready on http://localhost:3000

@jonaswindey it looks you executed dist/bin/next on the root directory of next.js ?
You have to do it on the directory of your app, or pass a directory to the command argument like ./dist/bin/next ../../my-next-app.

@nkzawa if I do this on the latest commit from yesterday that command still works, and not anymore.
this was the command I use to run next locally and this allowed me to test pages when creating them under /dist/pages
how do you run 'next' locally when you want to test your own examples?

@jonaswindey these are not supported even if it works before by accident. I recommend to use npm link which allows to install local modules.


Add extension to ground loot - Stackables ( Runes, Seeds, Noted, etc )

Add a separate gp value filter for stackables/noted/runes.

Duplicate of #1123


Semantic MediaWiki using jcarousel for gallery display

Thanks to your jcarousel plug-in we are finally be able to use Mediawiki's galleries in carousel mode. The implementation [1] is done in connection with Semantic MediaWiki and Semantic Result Formats.
Everything works fine but we have a small design glitch that we would like to address. We would like to set some margins within the class of .jcarousel-list-horizontal but somehow we fail to be able to change these attributes. (It is has to be .jcarousel-list-horizontal due to  the way how MediaWiki generates a gallery)
Is their some way the set .jcarousel-list-horizontal attributes because definitions in CSS file won't work and settings via jquery().css would help either.
Out testing environment includes jcarousel 0.2.8 MediaWiki 1.18.0 PHP 5.3.8  MySQL 5.5.16 Semantic MediaWiki (Version <IP_ADDRESS>) Semantic Result Formats (Version 1.7)
[1] https://github.com/mwjames/smw-srfgallerycarousel
Thanks

jCarousel sets margins and paddings to 0 for the list. This is needed for correct calculations and animations of the list. If you could setup a page and explain what exactly you want to archieve, i'm sure a can give some hints how to solve this (probably some margin on the clip or some other wrapper element).
Btw: i saw that you're using wrap:circular. This option is very buggy in 0.2 and i highly recommend to not using it.

Thanks for your reply.
According to your suggestion we use wrap:both as default instead and as soon the deployment is available on [1], I'll try to set-up an example.
[1] http://www.semantic-mediawiki.org/wiki/Help:Gallery_format


[REQUEST] Support compute particles in Shader

I found some repos about particles in shader, but they are based on ThreeJS.
https://github.com/pwambach/threejs-particle-shader
https://github.com/squarefeet/ShaderParticleEngine
https://github.com/schteppe/gpu-physics.js
(Some of them could support that  custom how to compute the particles with code-snippet).
I hope pixi-particles could support this feature.
( The ParticleContainer is not enough. the core-computation of particles is still in JS )
Thanks

Is there any feedback on this one? Would be such an awesome addition.

It's not something that I have the expertise to implement myself.


[HUDI-2795] Add mechanism to safely update,delete and recover table properties

Fail safe mechanism, that lets queries succeed off a backup file
Readers who are not upgraded to this version of code will just fail until recovery is done.
Added unit tests that exercises all these scenarios.
Adding CLI for recovery, updation to table command.
[Pending] Add some hash based verfication to ensure any rare partial writes for HDFS
[Pending] Move the existing upgrade/downgrade infra to use this

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

local testing. Added deletes and also tested this here.
https://gist.github.com/vinothchandar/45f4209cc01daaba99324de390a97406

CI is happy. https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=3491&view=results


Bugfix #107

Hi,
this is a bugfix for #107
Thanks
Sven

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   69.15%   69.15%
=======================================
  Files          18       18
  Lines         483      483
=======================================
  Hits          334      334
  Misses        149      149

Impacted Files
Coverage Δ

src/auditlog/diff.py
86.76% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45760c6...38f04a7. Read the comment docs.

Can you write a test case for passing a naive datetime and asserting the outcome?

Yes, I will write a test later today and submit it too

Sorry for the wrong commit I rebased and it should be fine now

yeah that is totally fine, thanks for rebasing, you didn't have to, I squash the commits going in so it wouldn't matter too much, but better to do it this way all the same for clarity with git's history.

Hi,
did this fix get merged at all?
Best
Sven


How to add options dynamically in bootstrap 4 version

Hi,
Thank you for sharing bootstrap-select with the community.
I'm using the 1.13.9 version with bootstrap 4.
How to add dynamically data inside dropdown menu.
like this type
http://www.marcorpsa.com/ee/t1161.jq1.html
bootstrap-select 1.13.6  and above not working.

Similar to #990. Please subscribe and 👍 #990 for updates.


Can I have nested Stories?

Problem Description
Seems not possible
Steps to Reproduce
<Story showCredit={false}
stories={[{
name: 'Initialization',
component: () => (<Story.../>)
}
]}
/>

Thanks for response. Can you please give pointer to how to go about it? It seems nesting creates problem in resize....


app-drawer-layout stylings ignore app-header custom element

Bug Description
Css styling and other rules do not reach custom app-header element.
For example, the menu paper icon button is expected to be invisible and drawer is visible until screen is small enough where drawer hides, menu button is visible and functions to open drawer.
Bug: Stylings on the content from app-drawer-layout does not reach paper-icon-button within a custom element #contentContainer:not(.narrow) > ::content > ::content > ::content[drawer-toggle] { display:none;} <br/ >
Menu appears from the beginning with drawer, clicking on menu button to toggle the drawer no longer works which is expected to work with the drawer-toggle property.
Noticed that header is also no longer fixed and scrolls with the remainder of the app-header-layout has-scrolling-region property.
Steps to Reproduce

Open my-app.html found in demo/ create own
Within  <app-header-layout>, create custom element for ex <my-header>
HTML Skeleton for <my-header>:
<app-header>
<app-toolbar>
<paper-icon-button icon="menu" drawer-toggle></paper-icon-button>
<div title>My Title</div>
</app-toolbar>
</app-header>

Expected Results

Actual Results

Browsers Affected

[x] Chrome

This issue was moved to PolymerElements/app-layout#321


Rewind and infinite not working as expected

I'm having an issue where if I set the option { infinite: true }, advancing backward through the carousel, the slider behaves as expected, but advancing forward, I get what I would expect for the rewind behavior (it goes backwards to the first slide), and in the console I get the error:
Uncaught TypeError: Cannot read property 'offsetLeft' of undefined.
If I set { rewind: true }, there's no difference from when neither rewind or infinite is set to true.
Maybe there is something in my setup that is causing this, but my usage thus far mirrors very closely what's given in the docs.
My CSS is taken from the docs here, and the only option I'm setting on init is infinite: true or rewind: true (one or the other).
My markup:

      <svg xmlns="http://www.w3.org/2000/svg" width="50" height="50" viewBox="0 0 501.5 501.5"><g><path fill="#2E435A" d="M302.67 90.877l55.77 55.508L254.575 250.75 358.44 355.116l-55.77 55.506L143.56 250.75z"/></g></svg>

      <svg xmlns="http://www.w3.org/2000/svg" width="50" height="50" viewBox="0 0 501.5 501.5"><g><path fill="#2E435A" d="M199.33 410.622l-55.77-55.508L247.425 250.75 143.56 146.384l55.77-55.507L358.44 250.75z"/></g></svg>

Is it a bug?

Hey @andosteinmetz,
Infinite can be set to false or number of visible slides. So I believe you would want { infinite: 1 } instead of { infinite: true }

Although shifting this into a feature request. I was thinking about this, and trying to think of possible scenarios where you want infinite and slidesToScroll to be different values. I couldn't think of any, but maybe it was built this way for a specific use case that I am not thinking of.
If there is not a use case maybe infinite should be a boolean value and then the number of visible slides is based on slidesToScroll?

Thanks! That fixes my immediate issue.
To me, it seems natural for them to be three separate values: infinite (boolean), slidesToScroll, and slidesVisible, though I haven't looked too carefully into the code to see how the 'infinite' value is being used...

@andosteinmetz This slider has a few different features and in an attempt to make them work together the code needs to know how many slides are visible for the infinite feature.


Upgrade tests to use RHEL 7.4

Should we not be testing both RHEL 7.3 and RHEL 7.4?

@swade1987 we actually talked about this today during standup. It's a non-trivial amount of work to test both (as well as adding a significant amount of build/test time for a relatively little gain). What version do most clients seem to use? We'd like to test against what's most popular for obvious reasons.

@emmetthitz clients use a mixture of RHEL 7.3 and 7.4.
We can't force clients to upgrade to 7.4 just because we can only test one distribution version, this seems like a limitation which needs to be resolved in our CI/CD toolchain. We should really be testing an N and N-1 versions of our supported OS's

It indeed is a limitation that we have been aware of for quite some time. Running the entire test suite against multiple distros is not trivial right now, both from a $ perspective and tooling perspective.

In this case, we need to be extremely explicit about the version of OS we support moving forward.
We need to state RHEL 7.4 and that 7.3 is out of scope, and the same with Ubuntu.