linux unable to detect pci connection for coral device

Description
I am having issues with my Coral M2 dual edge TPU the host won't detect it.
I have followed the setup instructions, but lspci -nn | grep 089a returns nothing.
Click to expand!
Issue Type
Build/Install
Operating System
Linux
Coral Device
Mini PCIe
Other Devices
No response
Programming Language
No response
Relevant Log Output
nvidia@ubuntu:~$ uname -r
5.10.104-tegra
nvidia@ubuntu:~$ lspci -nn | grep 089a
nvidia@ubuntu:~$

nvidia@ubuntu:~$ sudo apt-get install gasket-dkms
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer required:
apt-clone archdetect-deb bogl-bterm busybox-static cryptsetup-bin dpkg-repack gdal-data gir1.2-timezonemap-1.0 gir1.2-xkl-1.0 grub-common libaec0 libarmadillo9 libarpack2 libavcodec-dev libavformat-dev
libavresample-dev libavresample4 libavutil-dev libcfitsio8 libcharls2 libdap25 libdapclient6v5 libdc1394-22-dev libdebian-installer4 libepsilon1 libexif-dev libfreexl1 libfyba0 libgdal26 libgdcm-dev
libgdcm3.0 libgeos-3.8.0 libgeos-c1v5 libgeotiff5 libgl2ps1.4 libgphoto2-dev libhdf4-0-alt libhdf5-103 libhdf5-openmpi-103 libilmbase-dev libjbig-dev libjpeg-dev libjpeg-turbo8-dev libjpeg8-dev libkmlbase1
libkmldom1 libkmlengine1 liblept5 liblzma-dev libminizip1 libnetcdf-c++4 libnetcdf15 libodbc1 libogdi4.1 libopencv-calib3d4.2 libopencv-contrib4.2 libopencv-dnn4.2 libopencv-features2d4.2 libopencv-flann4.2
libopencv-highgui4.2 libopencv-imgcodecs4.2 libopencv-imgproc4.2 libopencv-ml4.2 libopencv-objdetect4.2 libopencv-photo4.2 libopencv-shape4.2 libopencv-stitching4.2 libopencv-superres4.2 libopencv-video4.2
libopencv-videoio4.2 libopencv-videostab4.2 libopencv-viz4.2 libopencv4.2-java libopencv4.2-jni libopenexr-dev libpng-dev libpq5 libproj15 libqhull7 libraw1394-dev libsocket++1 libspatialite7 libsuperlu5
libswresample-dev libswscale-dev libsz2 libtesseract4 libtiff-dev libtiffxx5 libtimezonemap-data libtimezonemap1 liburiparser1 libvtk6.3 libxerces-c3.2 odbcinst odbcinst1debian2 os-prober proj-data
python3-icu python3-pam rdate tasksel tasksel-data
Use 'sudo apt autoremove' to remove them.
The following NEW packages will be installed
gasket-dkms
0 to upgrade, 1 to newly install, 0 to remove and 284 not to upgrade.
Need to get 0 B/48.0 kB of archives.
After this operation, 256 kB of additional disk space will be used.
debconf: Delaying package configuration, since apt-utils is not installed.
Selecting previously unselected package gasket-dkms.
(Reading database ... 191886 files and directories currently installed.)
Preparing to unpack .../gasket-dkms_1.0-18_all.deb ...
Unpacking gasket-dkms (1.0-18) ...
Setting up gasket-dkms (1.0-18) ...
Loading new gasket-1.0 DKMS files...
It is likely that 5.10.104-tegra belongs to a chroot's host
Building for 5.10.104-tegra and 5.4.0-146-generic
Building initial module for 5.10.104-tegra
Done.
gasket.ko:
Running module version sanity check.

Original module

No original module exists within this kernel

Installation

Installing to /lib/modules/5.10.104-tegra/updates/dkms/

apex.ko:
Running module version sanity check.

Original module

No original module exists within this kernel

Installation

Installing to /lib/modules/5.10.104-tegra/updates/dkms/

depmod.....
Backing up initrd.img-5.10.104-tegra to /boot/initrd.img-5.10.104-tegra.old-dkms
Making new initrd.img-5.10.104-tegra
(If next boot fails, revert to initrd.img-5.10.104-tegra.old-dkms image)
update-initramfs........
DKMS: install completed.
Building initial module for 5.4.0-146-generic
Done.
gasket.ko:
Running module version sanity check.

Original module

No original module exists within this kernel

Installation

Installing to /lib/modules/5.4.0-146-generic/updates/dkms/

apex.ko:
Running module version sanity check.

Original module

No original module exists within this kernel

Installation

Installing to /lib/modules/5.4.0-146-generic/updates/dkms/

depmod...
Warning: Unable to find an initial ram disk that I know how to handle.
Will not try to make an initrd.

attaching Some more logs incase it helps
$ dpkg -l | grep gasket
ii  gasket-dkms                                1.0-18                               all          DKMS source for the gasket driver
$ sudo modinfo apex
filename:       /lib/modules/5.10.104-tegra/updates/dkms/apex.ko
author:         John Joseph<EMAIL_ADDRESS>license:        GPL v2
version:        1.2
description:    Google Apex driver
srcversion:     700E8BBBE9CC23C6EC17712
alias:          pci:v00001AC1d0000089Asvsdbcsci*
depends:        gasket
name:           apex
vermagic:       5.10.104-tegra SMP preempt mod_unload modversions aarch64
parm:           allow_power_save:int
parm:           allow_sw_clock_gating:int
parm:           allow_hw_clock_gating:int
parm:           bypass_top_level:int
parm:           trip_point0_temp:int
parm:           trip_point1_temp:int
parm:           trip_point2_temp:int
parm:           hw_temp_warn1:int
parm:           hw_temp_warn2:int
parm:           hw_temp_warn1_en:bool
parm:           hw_temp_warn2_en:bool
parm:           temp_poll_interval:int

Thanks! can you please share the output of below command as well..
  sudo groups  $USER

You haven't installed PCI driver for edgetpu device and because of that it is not working and lspci doesn't list it
From end of first log is seen that driver is not installed because of some issue with initrd.
You should install and use edgetpu as root or it can't install and run.
login as root and repeat installation steps. Also make sure you have installed linux header files for your kernel image version and gcc before to run driver installation


ols and odinfmt doesnt' seem to run on some files

I have a project that has 3 odin files in the same project/directory and ols/odinfmt work on 2 of the 3 files but not the last one.
The only difference I can tell is that the one that doesn't work is longer than the other 2.
Here are the wc output:
  334 erasure/binary_finite_field.odin
  249 erasure/erasure.odin
  370 erasure/finite_field_matrix.odin
  953 total

The project is at here. The file that doesn't work is finite_field_matrix.odin. Note that it did work when I started the file so maybe it's because of file size?
BTW, the way I check whether it works is by adding extra spaces inside a struct and when I write, it should auto shift/reformat the struct.

It's normally lack of trailling commas. Right now core:odin/parser expects there to commas, where the cpp parser does not care.
If you still have issues reopen it, and I'll look at the file causing issues.


Create User Persona

Persona 1: John Nick
Background: John is a 32-year-old policy maker working for the local government. They have a background in public administration and are responsible for developing policies that address demographic changes and social needs.
Goals:
•To access up-to-date population data to inform policy decisions.
•To understand demographic trends for better resource allocation.
Needs:
•Easy access to comprehensive population data.
•Ability to filter and analyze data based on specific criteria (age, location, etc.).
Persona 2: Andreea Khan
Background: Andreea is a 28-year-old researcher at a non-profit organization focused on urban development. They have a degree in urban planning and are involved in projects that aim to improve living conditions in densely populated areas.
Goals:
•To gather detailed population statistics for research purposes.
•To compare population data across different regions and time periods.
Needs:
•Access to a wide range of population data.
•Tools for visualizing and exporting data for further analysis.

Persona 1:

Persona 2:


Fix: Respect Content-Type of multipart requests

Problem
rack-test sets a requests Content-Type to multipart/form-data as soon as a file is part of the requests content. While this is convenient in most cases, it can also erroneously overwrite different (though valid) Content-Types such as multipart/related.
An example of how to reproduce the issue is given in the added test case:

send a request containing a file and explicitly set the Content-Type to multipart/related
inspect the resulting requests Content-Type, which will be multipart/form-data instead

Proposal
Instead of explicitly setting the Content-Type to multipart/form-data when a multipart request is detected, check first whether or not a valid Content-Type is already given by the caller. Use the given Content-Type if it exists or fall back to multipart/form-data.

@perlun @junaruga any update on merging and releasing a patch version for this?

Thanks for the feedback! I have simplified the statement as proposed.

@tomknig unfortunately now the class length no longer matches rubocop rules. please always make sure to run it before pushing it (in a pre-push hook for example).
Can you fix the violation and make travis happy again?

Yeah, sorry.
I have updated the known (and temporarily accepted) rubocop violations rather than trying to squeeze the code into the class since it were your style suggestions that I accepted. I hope that's a solution you are fine with?

@scepticulous Do you see any issues with merging this? I think @tomknig 's points are valid.

@perlun I am fine with merging

@junaruga if you are also happy with the PR we should ask this PR, too. Will  you?

It looks good! I am okay to merge it.
Seeing RFC multipart
https://tools.ietf.org/html/rfc1341
https://tools.ietf.org/html/rfc2387
Possible "multipart/*" are like this.

multipart/form-data
multipart/related
multipart/mixed
multipart/alternative
multipart/digest
multipart/parallel

@tomknig thanks for the PR! merged!


Allow passing in font style overrides?

For text whose styles, particular font-size, can shift around, it can be necessary to put the ... on the text assuming it's the largest size it'd ever be. This can be necessary for design in consistency and accessibility.
Example: if text starts at font-size: 20px but can go up to 22px, and it's desired to not change what text is displayed on the screen, react-truncate should be told to assume 22px.

Closing out my old issues in repos that haven't had updates in a few years. Cheers!


How do I add Transitioner to CustomTabs wrapped with createNavigationContainer?

Im currently implementing a custom tab via: https://github.com/react-community/react-navigation/blob/master/examples/NavigationPlayground/js/CustomTabs.js
Everything works as expected but I would like to add a Transitioner to the screens.  How do I access the router, state ect when the CustomTabRouter, CustomTabBar, CustomTabView and
const NotificationTabs = createNavigationContainer(createNavigator(CustomTabRouter)(CustomTabView))

...are all created outside of the scope of the class and thus the navigation prop?
I am currently adding this component to another screen that is part of a TabNavigator
render() {
  return (
    <NotificationTabs/>
  )
}

...so, this.props.navigation is actually the current tab.

I think I see what I am missing:
const stuff = NotificationTabs.getNavigator()

This conversation is more or less a duplicate of:
https://github.com/react-community/react-navigation/issues/474
I have moved my code example and feedback there, so please feel free to delete/close this issue.


docs: fix duplicate entry in tool.unasyncd example

This PR removes a duplicate entry in the [tool.unasyncd] example. I copy-pasted the example and VS code complained.
Is there another setting, that was meant instead?

Is there another setting, that was meant instead?

Seems to be a copy-paste error :)


Documentation: Adding Javadoc for BudgetView file

Description
This pull request adds comprehensive Javadoc comments to various classes in the project, including MainLayout, Application, LoginView, RegistrationView, and others. These comments provide clear and concise explanations of the classes' purposes, methods, and interactions with other components, which will improve the maintainability and understandability of the codebase.
This PR also includes some minor code clean-up to ensure consistency in formatting and to fix any typos in the existing comments.
Closes # (36)
Type of Change
(delete this part: put an X on the box eg. [X])

[ ] Bug fix
[ ] New/Update feature
[x] New/Update Documentation

Approved and looks good really clear


Fix odd tab border around quick pick when there are no active elements

The current behavior is just the native behavior (compared with Search viewlet). The shortcut to navigate from the input field to the first list entry is the down arrow. I'm not sure about the implications for accessibility when changing tab behavior (that's where Tab navigation is more important).

Makes sense. For now we can leave it as is.


How to get started with TagUI?

source - LinkedIn

My team-mate Ruth is now working on a video course, probably sometime in June she can publish. In the meantime, following are useful resources to get started.
Overview slide deck - https://drive.google.com/file/d/1pltAMzr0MZsttgg1w2ORH3ontR6Q51W9/view
Recent 1h webinar -  https://www.youtube.com/watch?v=hKc4eNBhMws
Usage guide -  https://tagui.readthedocs.io/en/latest/
Simple examples -  https://github.com/kelaberetiv/TagUI/tree/master/flows/samples
Advance examples - https://github.com/aimakerspace/TagUI-Bricks
Weekly Zoom 1-to-1 (Thursday 4-5pm SGT, UTC+8) -  https://github.com/kelaberetiv/TagUI/issues/914
Telegram group chat -  https://t.me/rpa_chat
The weekly Zoom meeting and Telegram group chat are especially useful resources if you have any questions to ask. Folks from the community will also share back their experiences. Also, you can also raise an issue on GitHub where so far this year we have been replying within 24h - https://github.com/kelaberetiv/TagUI/issues

MacBook-Air-de-Aliro:~ aliro$ ln -sf /Users/aliro/tagui/src/tagui /usr/local/bin/tagui
ln: /usr/local/bin/tagui: Permission denied
I can't install tagui in Mac  do you help me ?

Hi @manuautomatic can you try with below, maybe need permission to create this shortcut -
sudo ln -sf /Users/aliro/tagui/src/tagui /usr/local/bin/tagui

Gracias por responder. Puse la sintaxis
sudo ln -sf /Users/aliro/tagui/src/tagui /usr/local/bin/tagui
Aparecio --> Password:
Puse la contrasena y me sale que no encontro el archivo es extraño porque cuando ejecuto tagui de forma manual sigue la direccion lineas arriba. He logrado instalar y ejecutar la extension de python pero agrega mas texto y quiero poder hacer con el tagui. Estoy intentando automatizar algunos procesos
Mira cuando hago click manualmente Last login: Thu Jul 22 01:57:58 on ttys000
/Users/aliro/Desktop/tagui/src/tagui ; exit;
MacBook-Air-de-Aliro:~ aliro$ /Users/aliro/Desktop/tagui/src/tagui ; exit;
tagui v5.11: use following options and this syntax to run - ./tagui flow_filename option(s)
.................

Thanks for answering. I put the syntax
sudo ln -sf / Users / aliro / tagui / src / tagui / usr / local / bin / tagui
Appeared -> Password:
I put the password and I get that I did not find the file is strange because when I manually execute tagui it follows the direction lines above. I have managed to install and run the python extension but it adds more text and I want to be able to do with the tag. I am trying to automate some processes
Watch when I manually click Last login: Thu Jul 22 01:57:58 on ttys000
/ Users / aliro / Desktop / tagui / src / tagui; exit;
MacBook-Air-de-Aliro: ~ aliro $ / Users / aliro / Desktop / tagui / src / tagui; exit;
tagui v5.11: use following options and this syntax to run - ./tagui flow_filename option (s)
.................

I have seen that there is a time when you can have a zoom meeting you have a link

Thanks for answering. I put the syntax
sudo ln -sf /Users/aliro/Desktop/tagui/src/ tagui /usr/local/bin/tagui
Appeared -> Password:
I put the password and I get that I did not find the file is strange because when I manually execute tagui it follows the direction lines above. I have managed to install and run the python extension but it adds more text and I want to be able to do with the tag. I am trying to automate some processes
Watch when I manually click Last login: Thu Jul 22 01:57:58 on ttys000
/ Users / aliro / Desktop / tagui / src / tagui; exit;
MacBook-Air-de-Aliro: ~ aliro $ / Users / aliro / Desktop / tagui / src / tagui; exit;
tagui v5.11: use following options and this syntax to run - ./tagui flow_filename option (s)
I have seen that there is a time when you can have a zoom meeting you have a link

then password put   --- > ln: /usr/local/bin/tagui: No such file or directory

Hi @manuautomatic sorry I just saw your message! The Zoom meeting is every Thursday 4-5pm (UTC+8) -
https://github.com/kelaberetiv/TagUI/issues/914

Can you double check your line below? I think you accidentally added an extra space between /src/ and tagui
sudo ln -sf /Users/aliro/Desktop/tagui/src/ tagui /usr/local/bin/tagui

Try again with -
sudo ln -sf /Users/aliro/Desktop/tagui/src/tagui /usr/local/bin/tagui

For TagUI in human language version, the download instructions are here. And it should be > v6.46 after you download.
https://tagui.readthedocs.io/en/latest/setup.html

Closing this issue because most of the items in the list are already integrated into the GitHub landing page


ApplyProvisioningTemplate fails for Task list in lcid 1044

The ApplyProvisioningTemplate method fails in a very specific case: When the template contains a task list AND the language is nb-no (lcid 1044).
It is the creation of the Calendar view that causes the error:
...
Microsoft.SharePoint.Client.ServerException: Kolonnen Description finnes ikke. Den kan ha blitt slettet av en annen bruker.
at Microsoft.SharePoint.Client.ClientRequest.ProcessResponseStream(Stream responseStream)
at Microsoft.SharePoint.Client.ClientRequest.ProcessResponse()
at Microsoft.SharePoint.Client.ClientRequest.ExecuteQueryToServer(ChunkStringBuilder sb)
at Microsoft.SharePoint.Client.ClientRequest.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientRuntimeContext.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientContext.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryImplementation(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay)
at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryRetry(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectListInstance.CreateView(Web web, View view, ViewCollection existingViews, List createdList, PnPMonitoredScope monitoredScope)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectListInstance.ProvisionObjects(Web web, ProvisioningTemplate template, TokenParser parser, ProvisioningTemplateApplyingInformation applyingInformation)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo)
at Microsoft.SharePoint.Client.WebExtensions.ApplyProvisioningTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation applyingInformation)
...
The error message says that the column Description does not exist.
If I remove this from the xml file for the template, it works:

A out-of-the-box Task List does not have a field with Internal Name Description.
Try Body.

Hi,
Could you report that directly in the PnP Core Component repository at  https://github.com/OfficeDev/PnP-sites-core/issues. We do understand that it takes some time, but you could cross link this one. Just ensuring that things are not missed if they are located in wrong repository. thx.


Use K Gateway with GatewayAllowFromList instead of GatewayAllowAll

https://github.com/knative-sandbox/net-ingressv2/pull/74 will points to the Gateway by GatewayAllowAll. We should use
It should use GatewayAllowFromList.
Note, the K Gateway needs some requirement:

Gateway for Istio to be deployed in the same namespace with Istio's istio-ingressgateway and knative-local-gateway svc.
Gateway for Contour does not matter about the namespace as Contour can specify the namespace.
Gateway for Istio needs to configure spec.addresses for knative-local-gateway.istio-system.svc.cluster.local.

The Istio's Gateway requirement is extremely painful.
I tried to open https://github.com/istio/istio/issues/33654

This could be relieved by https://gateway-api.sigs.k8s.io/geps/gep-709/


[Task]: Rotate private-public keypair used to generate and validate the signature from CS

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Make sure to keep the deprecated public key in Appsmith instance to avoid interruption.

Merge sequence:

Appsmith PR which can support both the keys older and updated one
CS PR to merge the keys with updated keypair
Merge the Appsmith PR which removes the deprecated public key

marking this high priority as it has been 6 months since the keys were changed. For security aspect we should rotate the keys.

Doc on how to rotate the keys: https://www.notion.so/appsmith/Procedure-to-rotate-keys-bb87c366f0f744839d3613398a12f385

Is this issue closed ? or needs more work?


When AutomaticKeepAliveClientMixin used SnackBar lagging.

When I use AutomaticKeepAliveClientMixin with wantKeepAlive = true and call showSnackBar() from the state object the snackbar is shown but in laggy way, it continues to pop up several times whether you try to dismiss it or just wait. SnackBar is displayed as intended if AutomaticKeepAliveClientMixin not used.

Expected results:
Snackbar is shown only once and won't pop up be himself if user dismiss it.
Actual results:
Snackbar is shown several times, and if user tries to dismiss it, it pops up again.
Flutter doctor:
[✓] Flutter (Channel stable, v1.17.1, on Mac OS X 10.15.4 19E287, locale uk-UA)
    • Flutter version 1.17.1 at /Users/vlytvyne/flutter
    • Framework revision f7a6a7906b (5 weeks ago), 2020-05-12 18:39:00 -0700
    • Engine revision 6bc433c6b6
    • Dart version 2.8.2

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/vlytvyne/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.2

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[!] IntelliJ IDEA Community Edition (version 2019.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

! Doctor found issues in 1 category.

Hi @vlytvyne
could you provide a complete minimal reproducible code sample?

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Add Makefile target postflight-cli

The postflight-cli target runs the installation postflight check using the installer's CLI.

What version was --postlfight added? I know it's not new.
I can't remember why we've been using a custom postflight script, unless it was some sort of version compatibility to support older versions of DC/OS that didn't have postflight.
It could also have been to validate that the GUI is accessible tho. I think the CLI postflight just checks 3DT state.
Perhaps we need to modify make postflight to run --postflight and then another script that just pools the GUI?

@karlkfi I pushed an update that resolves your comment.
--postflight has been around as long as the CLI installer, and at least as long as the web installer. Pre-1.7, at least. The CLI and web installer postflight both verify the same thing: component health via the 3DT health API. One of those components is the master's adminrouter, which we effectively use as a proxy for determining whether the GUI is available. Either postflight approach (CLI or web) should work for the purposes of dcos-docker, but it's nice to have both as options in the Makefile since this is for local development.
IMO if the built-in postflight isn't sufficient for determining whether the cluster is up and available, that's a bug in DC/OS. Now that checks are becoming a thing and postflight is going to using them, we can add a GUI check there.

So... ultimately I do want to use --postflight instead of my own script. But as it stands, the existing --postflight behavior is  pretty terrible. It regularly prints stack traces, doesn't indicate any sort of progress, and has some odd behavior.
I supposed having a postflight-cli is a tolerable placeholder for now, but it would really only be useful for people testing that cli command.
AFAIK, the only things that --postflight does that make postflight doesn't is:

check multiple masters
check all agents

These two behaviors can be trivially added to make postflight just by adding some loops. Checking multiple masters we can add right away. Checking agents tho is debatable whether it's actually desirable. The UI & API is usable as soon as the masters are up. So from a user perspective, that's all they need. But from a CI perspective, you'd want to make sure all the agents are up before you start running integration tests or to verify that code changes still allow the agents to come up.
So there are really two classes of use cases for postflight, which means we probably want either two commands or an optional argument on one command...

So I guess what I'm saying is:

I don't want people to get attached to this command because i may remove it in the future.
I think it having two kinds of postflights might confuse people who don't knwo the difference and make UX worse...
If I add this we need some docs or at least a make help comment about why we have two.
If you still think you need this after my comments, let me know.

What do you think?
What exactly is your use case?

My use case was that I wanted to test the CLI postflight locally since I was hacking on it, and there was no existing Makefile target which allowed me to do that. It's a limited use case, which is why I didn't try to change the existing postflight target.
I doubt that running postflight on agents would make it take much longer, agents tend to come up quickly once a cluster's Mesos and DNS are working.
Would adding some comments and help output explaining that this is duplicated functionality useful only for local DC/OS development do the trick?


disable submit button with onError

After going through the issue:
https://github.com/NewOldMax/react-form-validator-core/issues/41
And trying to implement the solution in codepen, here: https://codesandbox.io/s/pedantic-davinci-sxudm
After switching the handleError to handle the promise from isFormValid instead of the old boolean, I'm having troubles toggling disabled in state to disable/enable the submit button.
If a form is invalid, this is fine as handleError sets disabled in state to true. However, when the form is valid I'd assume handleError doesn't get called, so other than creating our own isValid function which returns true or false and constantly calling it perhaps using validationListener (maybe?), is there a solid way to determine a valid form so that the button is enabled?
I'm also going to have additional login in handleSubmit, but figuring out a solution to the above problem would be useful to start! Any info is appreciated.

Hi,
since isFormValid is a promise, you should use it as promise:
handleError = () => {
    this.form.isFormValid().then(isValid => {
      this.setState({ disabled: !isValid });
    });
};

Cheers, was able to add custom validators, listener, and that handleError to get it to work nicely. Thanks!


--api-servers is not needed …

… if kubeconfig is provided and indicates api-server, this is deprecated and breaks in v1.8
This answers #778

Sure, but I would do that in a different PR -- this is to correct a blocking v1.8 issue

retest

Not sure what the problem is but this PR doesn't seem to work in CI.  The failure symptom is that all nodes are not joining the cluster.  This occurring before the fabric is setup so we are expecting all nodes to show up in a kubectl get nodes but they should be 'NotReady'.

added a patch to the kubelet units so they work.  rebased to resolve the conflict.

I believe this was also done in the 1.8 PR. Please confirm and rebase or close.

The only difference is this PR passes --require-kubeconfig=true whereas HEAD passes --require-kubeconfig.

Will close.  This was required for 1.8 but we seem to have done that already.


Updated documentation. Removed build artifacts. Added .gitignore

Updated documentation containing a detailed article on the app and other technical concepts to be considered for resiliency.

Slightly modified the rest of the readme files (for setup and for API) and moved them in the doc folder, together with the images used in the main README.

Removed the build artifacts committed with the APP and added a .gitignore file to prevent future commits with this.

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree company="Microsoft"

looks great! It can be merged.


Remove EFS access point user and directory enforcements

Discussed with @mreferre - he preferred to keep the access point user and directory enforcement for future tests.


Fix SwiftLint issues & add more API from Violation

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

See the complete overview on Codacy


[P2P] Move IP range filtering to PeerConnectorDiscovery and Update ConnectionManager disconnect

The issue was that we disconnect the peer in ConnectionManager too late. We disconnect it AFTER its been added to the connectedPeers collection. So it connects, we call OnPeerAdded and we call ShouldDisconnect and it disconnects the JUST added peer.
Also, we dont check for localhost addresses so even those get disconnected.
Fixes #2892

I am fine with this change @noescape00

Removing AsyncQueue reintroduces a race condition

Removing AsyncQueue reintroduces a race condition

@dangershony and I decided to go with a lock 👍

@noescape00 can you explain the race condition still after using the lock?

Ah the problem is exactly this
if (peer == connectedPeer)
    continue;

In case we are already connected this will never work? why do skip this check?

Ah the problem is exactly this
if (peer == connectedPeer)
    continue;

In case we are already connected this will never work? why do skip this check?

It is not skipped??

It is skipped and if we are the same peer we return false (don't disconnect)


[Draft] First attempt at a DSS extension

Implementation of the DSS model. Checked for MNist classification / MNist generation.

Hi @ag1988 ,
We were going to add DSS addendum to our writeup of S4. Let us know if you have any tips or tricks that you want us to include.
Also just to check. In the paper I didn't see an easy way to recover the RNN form of the model. Is that true? Are there other parameterizations that allow it?

Hi @srush,
Thank you for including DSS in your wonderful tutorial! The implementation looks great.

The init for Lambda can be double-checked here.
In the current code, by default I use separate Deltas for the real and imaginary parts of Lambda. I.e. instead of directly using (Lambda.realDelta + 1j * Lambda.imagDelta) , I use  (Lambda.realDelta_1 + 1j * Lambda.imagDelta_2). This doesn't help a lot but I just wanted to mention this just in case.

Otherwise your code looks wonderful! Thanks again for including DSS :)
About recovering RNN reps, do you mean the following: given inputs u = (u1,..,uL), kernel K = (k1,..,kL) , output y= (y1.,,,yL) how to recover the states? The set of states is not unique as the state space (A,B,C) ~ (VAV, VB, CV) in terms of outputs. But the recurrence x_{k} = bar{A}.x_{k-1} + \bar{B}.u_k and x_{k} = Vbar{A}V.x_{k-1} + V\bar{B}.u_k will have different states (transformed by V*).

Thanks for responding!
For (1) I was thinking of not training Lambda at all, do you think that would make it much worse? We didn't train A in our S4 code and it seemed basically fine.
For (2) the RNN mode, I wasn't sure how to recover A, B, C at all from Lambda and W. For generation tasks, it is really nice to be able to have these matrices.
My thought was if we don't train Lambda, we maybe have V from the eigenvectors, and could learn B and C instead of W?

Hey @ag1988 - so interesting results! To better test the implementation, we ran the DSS implementation we wrote up (in this PR) and our S4 implementation (with fixed A matrix) on the sequential CIFAR classification task (given an image as a sequence of pixels, predict class).

With our S4, we get 87.05% accuracy after 100 epochs.
With Diagonal State Spaces (DSS) we get 88.9% accuracy after 100 epochs.

The original S4 paper reports SOTA at ~91% accuracy (but that's with training A, adding an LR schedule, etc.). So all in all, a strong result for the simple DSS model! Nice!

@srush let me get back to you on the states question tomorrow. Sorry for the delay :pray: .
@siddk Woo hoo! That's really cool Sidd! :tada:

Hi @srush ,
Here's a derivation of how to compute the states for the state space parameterized by DSS. I know its a bit strange that original state space here is depending on Delta but this is just to show you that its indeed possible to construct a valid set of states. Let me know if there's an error.

Thanks, @ag1988, this is super clear. Going to add it to our implementation.
It's really convenient that it factors this way. N separate RNNs. I think Jax can actually optimize for that.

Sounds great Sasha! Someone asked me this question before but it wasn't
super clear to me why recovering the states would be helpful as they're not
even unique. But after you asked, looks like it'll be helpful to include it
in the DSS write-up for the interested reader. So thanks for asking this
question.
On Wed, Apr 6, 2022, 9:02 PM Sasha Rush @.***> wrote:

Thanks, @ag1988 https://github.com/ag1988, this is super clear. Going
to add it to our implementation.
It's really convenient that it factors this way. N separate RNNs. I think
Jax can actually optimize for that.
—
Reply to this email directly, view it on GitHub
https://github.com/srush/annotated-s4/pull/49#issuecomment-1090972823,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AID3IGHX6VTIULHMJI65QXDVDYXY7ANCNFSM5ST3BW7Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


"constructor" and "destructor" are being written into JSON when using toJSON

I've been using this include for my WIP Stuntjumps gamemode and I have to thank you for making it - it makes the code a ton cleaner (even though it's not REAL classes)
I did find one issue with it though:
When trying to convert a class to JSON using MTA's toJSON function, it still maintains the constructor and destructor.
The resulting JSON would then have
[ { "constructor": false, "destructor": false, ...other_data_here... } ]"
Looking through the code it seems to be caused by implicitly setting both constructor and destructor to false instead of nil
https://github.com/misterquestions/lua-class/blob/master/include.lua#L150
https://github.com/misterquestions/lua-class/blob/master/include.lua#L160
I've changed the code locally to set it to nil instead and it appears to work fine

Hmmm the problem is that when value is explicitly nil the __index will allow using constructor/destructors as they will be found by looking super's, not sure if we should allow that at all.

Oh I didn't take that into consideration - so far I've not been using supers anywhere hence why I probably didn't run into any issues

Do you have some test code I could run and test against to see if I can get something working with this?
I've played around a bit and managed to get something working, but knowing what code would cause issues specifically (e.g. having it be nil instead of false) would be good to test against 😁
Another option I thought about is implicitly implementing a self:super call or something that will pass custom arguments to the super class.
However, this would break the dual-class extension (e.g. your class 'Deathmatch' (Gamemode, TeamGamemode) example code)

I once tought about doing some implementation of allowing a 'super' global func which is meant to call super class method which is named the same than the invoking function, even tho possible the overhead that it might cause would be really high


install: both docker and using pip fail on AWS

I know 'docker login repo.splunk.com' works anywhere I need it to, except AWS.
Is there something different needed to pull the latest, in this case eventgenx from? I am getting this on login:
Error response from daemon: Get https://repo.splunk.com/v1/users/: dial tcp: lookup repo.splunk.com on <IP_ADDRESS>:53: no such host
Works fine from non-AWS systems.
I moved on to trying as a PyPI module and after splunk_eventgen installs, at exection I get the following:
root@ip-172-31-5-166:/tmp/eventgen-develop# splunk_eventgen
Traceback (most recent call last):
File "/usr/local/bin/splunk_eventgen", line 5, in
from pkg_resources import load_entry_point
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 2927, in
@_call_aside
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 2913, in _call_aside
f(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 2940, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 635, in _build_master
ws.require(requires)
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 943, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 829, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'cryptography>=1.3.4' distribution was not found and is required by requests
Reason for posting - since I can do all of this no problem on non-AWS servers, is there some networking I am missing or Ubuntu version I should have for eventgen with Splunk.

ping me on slack, this is an external repo which customers / public has access to, happy to answer this there :D


Image normalization on my own dataset.

Hello,
I have a doubt about image normalization.
I have my own dataset in COCO format for instance segmentation.
I tried DCN. https://github.com/open-mmlab/mmdetection/blob/master/configs/dcn/cascade_mask_rcnn_r101_fpn_dconv_c3-c5_1x_coco.py
So the config comes with its own img_norm_cfg.
But my dataset has following values:
img_norm_cfg = dict(
    mean=[128, 128, 128], std=[11.578, 11.578, 11.578], to_rgb=True)

So when I am fine-tuning on my own dataset do I need to use the default img_norm_config or the values calculated from my own dataset?
Will it have an impact on the results.?

@VikasRajashekar If it is fintune mode, you do not need to modify this field.

@hhaAndroid in case I don't want to use the provided pre-train checkpoint using load_from.
In that case, can I use img_norm_cfg of my own dataset?

@VikasRajashekar You just need to ensure that the norm value is consistent with the pre-training.


Closing instance with nodetool

Elassandra version: <IP_ADDRESS>
Plugins installed: []
JVM version: openjdk version "1.8.0_151"
OS version: Debian 4.9.82-1+deb9u3 (2018-03-02) x86_64 GNU/Linux
Description of the problem including expected versus actual behavior:
Closing elassandra instance with
bin/nodetool stopdaemon
is not closing cassandra instances. Access ports to cassandra and elasticsearch are unbind.
Steps to reproduce:

bin/cassandra -e
bin/nodetool stopdaemon  (no output)
bin/cassandra -e (seems to work)
bin/nodetool status
get:
Failed to connect to '<IP_ADDRESS>:7199' - NotSerializableException: 'javax.management.remote.rmi.RMIJRMPServerImpl'.

Provide elasticsearch cluster state:
Provide user CQL schema:
Provide logs (if relevant):

Describe the feature:

Hi Charles,
If you stop your cassandra instance like step 2, it may take a while to properly stop your node, and when stopped, step 4 works as expected (it fails to connect to your stopped node).
Finally, you should find these messages in your cassandra logs:
2018-05-25 11:39:19,263 INFO  [RMI TCP Connection(4)-<IP_ADDRESS>] CassandraDaemon.java:549 stop Cassandra shutting down...
2018-05-25 11:39:19,268 INFO  [RMI TCP Connection(4)-<IP_ADDRESS>] Server.java:176 close Stop listening for CQL clients
Thanks.
Vincent.


Don't show all of the search hits in the Variants side panel when launched w/i clin.iobio

Also, sort the entries so that the lowest ranked hits appear first.


fixed jobs type delete job error

Perfect thanks @changjunhao 👍

@changjunhao version v1.1.1 is now published with this fix 👍


run tests from makefile

closes #243
check command

soter_test
themis_test
themispp_test

This is required test suit.
check_all command

phpthemis_test
pythemis_test
rubythemis_test
node

These tests require external dependencies, so they might fail due to outdated local configuration.

maybe we should refactor this makefile and make that make test will run tests (not compile them)? What about to rename test target to prepare_test (or something like this) and new check target to test? after that make test will do what expected - test current code
and I would use this updated Makefile in our circle.yml

Nice idea! But then we should update Makefiles for other products to be consistent :)
I'll do it

@Lagovas
compile tests:

prepare_tests_basic
prepare_tests_all

run tests:

test_basic
test

by default, make test will prepare all tests and run them

@Lagovas

circle.yml updated
wiki updated

to finish this refactoring we should use new make test in our circle.yml instead of current commands:
...
- build/tests/soter_test
- build/tests/themis_test
- build/tests/themispp_test
- build/tests/pythemis_test.sh
- build/tests/phpthemis_test.sh
- build/tests/node.sh
...
what you think?

I think that we shouldn't use make test in circle.yml, because it's more useful to see what tests are failing.
However, I did more research & refactoring on that, and got rid of running ruby tests with sudo.

@Lagovas I think that we shouldn't use make test in circle.yml, because it's more useful to see what tests are failing.

yeah, it's good when used public interface of Makefile (like you did now), not when used the implementation in recipes (as it was before).


WebkitBlobRessource error 1 when reloading blob on IOS

The problem occur when using file download on IOS and using reload on the window displaying the blob.
I get an error like (approximatively translated from french) :
Safari cannot open this page.
Error: The operation cannot complete  (WebkitBlobRessource error 1).
Just reporting for documentation as I dont think there is a solution to this problem. The ressource have very likely been released from memory, maybe Webkit / Safari could display a more user friendly message ( I did a quick search on webkit but base but found no related issue).

PR #8081 might help here, since it should disable blob usage in Chrome on iOS.
What version of PDF.js are you using?
(For future reference, please provide as much of the information in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md as possible when opening an issue.)

Yes, sorry for skipping details.
I use 1.6.210. I will get the check version of IOS but I think it's version 10.
Thanks for reference to #8081, I will read it.

Given everything mentioned in https://github.com/mozilla/pdf.js/issues/8152#issue-213375356, this really seems like a browser-specific bug rather than a PDF.js one; should this be closed since there doesn't appear to be anything we can do here?

Yes, I will close, thanks.


Keyboard interrupt not working

Description
Expected behavior is that pressing Ctrl+C once stops the program. This used to work well until a recent JAX update.
CPU
Additional system info
Linux
NVIDIA GPU info
No response

Do you have a code example that reproduces this issue? Do you know if you see this more specifically during JIT compilation, execution, or anything else?

Hi! This always happened during jitting which isn't great but okay. But now it also happens during execution. I do have a codebase where this is reproducible but I don't have a small self-contained example. Would instructions to run the code base be helpful (it's just a pip install and a python3 command)?

@froystig @danijar It was once discussed and analyzed in https://github.com/google/jax/issues/14882#issuecomment-1548995301, but without further progress.

The problem here is that python is trapping the keyboard interrupt signals, but c++ is blocked compiling. If we periodically checked PyErr_CheckSignals() during XLA compilation, + any other place we wait for futures and cancelled based on it, that could resolve this problem.


can't use D435 after update Firmware

librealsense
2.33.1 RELEASE

OS
Windows

Name
Intel RealSense D435

Serial Number
819612071062

Firmware Version
<IP_ADDRESS>

Advanced Mode
YES

Camera Locked
YES

Usb Type Descriptor
2.1

Product Line
D400

Asic Serial Number
818413023426

Firmware Update Id
818413023426

after update the Firmware ,I can't open the D435 via Intel Realsense Viewer and  can't update the Firmware again.

always show this:

If you are able to access the RealSense Viewer program, does the camera appear at all in it when inserted into the USB port please?

If you are able to access the RealSense Viewer program, does the camera appear at all in it when inserted into the USB port please?

I could have used it normally,but when I updated the firmware,it failed to connect.
And  I can't update the firmware again

If you are able to access the RealSense Viewer program, does the camera appear at all in it when inserted into the USB port please?
Edit Thanks for adding the Viewer images!

thanks for your help!

It is a good sign that the camera is displayed in the Viewer.   Could you go to the 'More' icon at the top of the Viewer's options side-panel please and select ''Install Recommended Firmware' from its menu.  This should cause the Viewer to try to update the firmware.  You do not need to provide a firmware file for this option, as the recommended file is included within the Viewer package.

thanks very much for your suggest !
but it's not working.
when select  ''Install Recommended Firmware',firstly it will show this for a few seconds

and then will show this:

Thanks for your patience and the additional images you posted.
Could you check please whether the camera works with the Depth Quality Tool program (which is similar to the Viewer) to eliminate whether it is a problem with the Viewer program specifically please?

Thanks for your patience too.
Depth Quality Tool program can't work, It's always in the launch page like this:(already at least 5min before I close it)

and the rs_examples is also not work(I use VS2019)
but they were normal before
should I use  Firmware Update Tool?

The firmware update tool (rs-fw-update may be worth a try, though the firmware looks healthy.  The tool has the ability to recover cameras if the camera can be detected.  My recollection though is that it needs a USB 3 connection and that only the RealSense Viewer firmware update method works with USB 2.
https://dev.intelrealsense.com/docs/firmware-update-tool
If the firmware is okay and there is some other cause of the problem (such as a corrupted calibration table inside the camera, which has been known to disrupt firmware update) then you could try a "Gold Reset" of the camera to its factory defaults, which fixes the calibration table too.
This is done by installing a program called the Dynamic Calibrator and using a program within it called CustomFW to perform the reset.  The details of doing so are in the link below.
The Dynamic Calibrator software can be downloaded here:
https://downloadcenter.intel.com/download/28517/Intel-RealSense-D400-Series-Calibration-Tools-and-API
Download the upper of the two links at the side of the page, CalibrationTool-<IP_ADDRESS>-Setup.zip
When it is installed, use the CustomRW program to activate a gold reset:
Intel.Realsense.CustomRW.exe -g

The firmware update tool (rs-fw-update may be worth a try, though the firmware looks healthy. The tool has the ability to recover cameras if the camera can be detected. My recollection though is that it needs a USB 3 connection and that only the RealSense Viewer firmware update method works with USB 2.
https://dev.intelrealsense.com/docs/firmware-update-tool
If the firmware is okay and there is some other cause of the problem (such as a corrupted calibration table inside the camera, which has been known to disrupt firmware update) then you could try a "Gold Reset" of the camera to its factory defaults, which fixes the calibration table too.
This is done by installing a program called the Dynamic Calibrator and using a program within it called CustomFW to perform the reset. The details of doing so are in the link below.
The Dynamic Calibrator software can be downloaded here:
https://downloadcenter.intel.com/download/28517/Intel-RealSense-D400-Series-Calibration-Tools-and-API
Download the upper of the two links at the side of the page, CalibrationTool-<IP_ADDRESS>-Setup.zip
When it is installed, use the CustomRW program to activate a gold reset:
Intel.Realsense.CustomRW.exe -g

Amazing,"RealSense Viewer program" is working properly again!!!!
But I did nothing！
I just went to the kitchen and ate an apple ,and then restart the "RealSense Viewer program"
Thanks for your patience very much!!!!
thanks!!!!

You are very welcome.  I'm glad that your problem was resolved!
I will close the case now, as your camera is working again.   Good luck!


Race condition fix for interceptor setup

Supersedes #2111
This targets development, and fixes a naming issue.
cc @anton-plebanovich
Further details can be found in the superseded pull request.

Fails

:no_entry_sign:

danger-swift` failed.

Log
Cloning and building inline dependencies: import DangerSwiftProse // package: https://github.com/f-meloni/danger-swift-prose.git, import DangerXCodeSummary // package: https://github.com/f-meloni/danger-swift-xcodesummary.git, this might take some time.
Updating packages...
ERROR: failedToUpdatePackages("/Users/distiller/.danger-swift/Packages/")

  Generated by :no_entry_sign: dangerJS against cdfb62b0e7d3737dbb8a673d96e8f50e0c397d51

I wonder if and how we can write a test that covers this.


[BUG] Deselecting is not working

Describe the bug

When you attempt to uncheck a previously selected picture in picker, it is not working.
How to reproduce

import 'package:flutter/material.dart';
import 'package:photo_manager/photo_manager.dart';
import 'package:wechat_assets_picker/wechat_assets_picker.dart';

class PhotoView extends StatefulWidget {
  const PhotoView({super.key});

  @override
  State<PhotoView> createState() => _PhotoViewState();
}

class _PhotoViewState extends State<PhotoView> {
  List<AssetEntity> selectAsset = [];

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.white,
      appBar: AppBar(
        title: Text('wechat_asset_picker'),
      ),
      body: Column(
        crossAxisAlignment: CrossAxisAlignment.center,
        children: [
          TextButton(
              onPressed: () async {
                final PermissionState ps =
                    await PhotoManager.requestPermissionExtend();

                if (ps.isAuth) {
                  // Granted
                  // You can to get assets here.
                  final List<AssetEntity>? result =
                      await AssetPicker.pickAssets(context,
                          pickerConfig: AssetPickerConfig(
                              selectedAssets: selectAsset,
                              requestType: RequestType.image));
                  if (result != null) {
                    selectAsset = result;
                    setState(() {});
                  }
                }
              },
              child: Text('picker')),
          Expanded(
            child: GridView.builder(
              itemCount: 9,
              gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
                crossAxisCount: 3,
                mainAxisSpacing: 8,
                crossAxisSpacing: 8,
              ),
              itemBuilder: (BuildContext context, int index) {
                return (index >= 0 && index < selectAsset.length)
                    ? AssetEntityImage(
                        selectAsset[index],
                        fit: BoxFit.cover,
                        isOriginal: false,
                      )
                    : Container(
                        decoration: BoxDecoration(
                          border: Border.all(color: Colors.black, width: 1),
                        ),
                      );
              },
            ),
          )
        ],
      ),
    );
  }
}

Steps to reproduce the behavior:

Present wechat_asset_picker using AssetPicker.pickAsset() method for changing photos that is preselected
Press preview for deselecting previously selected photo.
Even if you select a previously selected photo in preview bottom, the same photo will continue. (can not change)
Main picture in preview is not changed so I can not deselected.

Expected behavior

Does the preview mean the photos that I preselected? When I touch picture at the bottom of preview screen, main picture have to be changed what i select and I should be deselect the picture.

Screenshots (If contains)

Version information

Device: iPhone X, iPhone mini 13
OS: iPhone X-iOS 16.7.2 / iPhone mini 13 - iOS 17.2
Package Version: 8.7.1
Flutter Version: v3.13.8

Additional context

This problem occurs more often, especially when an old photo is provided as a parameter value for preselect.

I didn't reproduce this on my iPhone 12 (iOS 17.1).

The select button will only disappear if the selectedAssets used in the config is null.

https://github.com/fluttercandies/flutter_wechat_assets_picker/blob/bf5daf25163301ab6ff276e2a51f701ac550066f/lib/src/delegates/asset_picker_viewer_builder_delegate.dart#L747-L757
https://github.com/fluttercandies/flutter_wechat_assets_picker/blob/bf5daf25163301ab6ff276e2a51f701ac550066f/lib/src/widget/asset_picker_viewer.dart#L50-L57

Based on the above code, there should be nothing wrong with the package. Closing as invalid usages.

in my case, This happens when you select a photo taken two to three weeks ago in the picker. I think there is no problem when choosing the photos that are currently loaded on the screen, but an error occurs when the older photo is selected as the pre-elect photo. would you check this again?

I think there is no problem when choosing the photos that are currently loaded on the screen, but an error occurs when the older photo is selected as the pre-elect photo.

It only matters to the condition I've attached above. I've also checked by selecting assets out of the first 10 pages and starting the selecting again. No issues were found tho.


Standardize parsing optional keywords, improve comments

I was somewhat confused about this pattern in https://github.com/sqlparser-rs/sqlparser-rs/pull/767 so I added some comments to improve the code.
I also removed support for parsing ONLY from ALTER INDEX added by @devgony  in https://github.com/sqlparser-rs/sqlparser-rs/pull/767#discussion_r1058338538

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0009%) to 86.387%

Totals

Change from base Build<PHONE_NUMBER>:
-0.0009%

Covered Lines:
13003

Relevant Lines:
15052

💛  - Coveralls


[Release] 3.7.0

Chores

#169
#171
#173
#184
#187
#185

Bugs

#168
#179

Could I get one more approval here, please? 🎸


ut fix: construct update in Monitor

Description
org.opensearch.commons.alerting.model.Monitor add a new parameter in its constructor(https://github.com/opensearch-project/common-utils/commit/d7fd7b6b1963f82843fb1bda0bde71fd3618bd76), which cause test file compile failing. Fix it by adding default value.
Related Issues
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[x] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

There seems to be flakey test: https://github.com/opensearch-project/skills/actions/runs/11064528711/job/30742459624?pr=415


n_fft issue

Changing n_fft does not change the frequency bins when using
mne.time_frequency.psd_welch

is n_fft > n_samples for your signal?

yes

Read the docstring of n_fft more carefully, it says that if n_fft > n_samples , then n_samples will be used, i.e. n_fft = min(n_fft, n_samples). Make sense?

Yes I see that sorry about that. I had previously had n_fft  > n_samples and I got the zero-padded result. Not qute sure what function I used. Does mne support zero-padding or should I have to zero-pad the data before turning it into an Epoch?

I know that tfr_* does that but what if I needed padding without the need to do time-frequency analysis? In this case where I fix the time bounds computation time is faster.

IIRC psd_welch does not support padding and I also remember myself expecting at the beginning that n_fft > n_samples does zero padding.
The scipy.signal.welch function that psd_welch is using supports zero-padding however: nperseg argument controls segment length and nfft is used for zero-padding, when needed.

I suppose we could change it so that if n_fft > n_samples it zero-pads, seems more consistent. Not sure how to do it in a nice way from a non-API-breaking standpoint, though. We might need to introduce a kwarg :(

In some cases one may still want a welch window that is shorter than n_samples and zero-padding too, so another kwarg seems necessary (pad_to, pad, zero_pad ?).

I agree

@mmagnuski did you change this behavior in #3823? If so can you update whats_new.rst to say so, and we can close this?

No, I have a local branch for this. I will try to push it tomorrow.

Great thanks for fixing these issues


[PE-D][Tester E] UG Table of Contents hyperlinks do not work

Clicking on the links in the table of contents at the top of the main UG  (or other hyperlinks in the UG) does not work -- browser does not jump to the relevant header. However, the links in the table of contents on the right of the page work.

Some info that may help in troubleshooting:

URL from working ToC:
https://ay2324s1-cs2103t-t14-2.github.io/tp/UserGuide.html#finding-a-patient-by-name-find
URL from not working ToC:
https://ay2324s1-cs2103t-t14-2.github.io/tp/UserGuide.html#finding-a-patient-by-name--find

Tested on Firefox on MacOS.
I'm not sure what exactly caused this problem (my guess is something to do with how MarkBind vs GitHub Flavored Markdown generates anchor slugs for headers, as my team's UG links [using Jekyll] works fine). Hopefully the info given above helps.

Labels: type.DocumentationBug severity.Medium
original: xenosf/ped#13

Completed in #248


Only set supported feature gates of kubelet

How to categorize this PR?

/kind bug
/platform equinix-metal
What this PR does / why we need it:
Only sets the csi feature gates in the kubelet if they are supported.
Release note:

Fixes removed feature gates in the Kubelet service for newer versions

Can you please check the failing verify step?


Setting the content type to "application/x-www-form-urlencoded" or "multipart/form-data"

Is there a way to set the content type to "application/x-www-form-urlencoded" or "multipart/form-data"?
It seems to be supported in OpenAPI.NET's object model (eg:  https://github.com/Microsoft/OpenAPI.NET/blob/d79395555eaf5ff8815d6477d681e43015c427d1/test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiPathItemTests.cs)
P.S. Thank you guys for this repo and your hard work!

Yes, you should be able to use attribute type = "application/x-www-form-urlencoded" e.g below
Sample object

Thanks @Shwetap05. This sample comment works when I generate a v3 OAS document using the OpenApiSpecVersion.OpenApi3_0 setting. However, when generating a v2 OAS document, the properties of the SampleObject1 do not showing up in the spec file.

@andrewliang Are you converting to V2 document using Microsoft.OpenApi.Readers? If so it could be a bug in OpenApi.Net so can you please open an issue for it on https://github.com/Microsoft/OpenAPI.NET?

hm.. I'm not using Microsoft.OpenApi.Readers directly in my code but is it possible that Microsoft.OpenApi.CSharpAnnotations.DocumentGeneration.OpenApiGenerator is using it?
I'm using the generator to read the dll and xml files as instructed in the README.md file. I'm also calling the OpenApiDocument.Serialize() method and passing in OpenApiSpecVersion.OpenApi2_0

@andrewliang Microsoft.OpenApi.CSharpAnnotations.DocumentGeneration.OpenApiGenerator does not own any serialization code, OpenApiDocument.Serialize()  is owned by https://github.com/Microsoft/OpenAPI.NET so can you please open an issue with details on that repo?

No problem. I'll open an issue against https://github.com/Microsoft/OpenAPI.NET.
Thanks again.


Feature/python model v1

This change currently includes table materialization and incremental materialization.
Also super happy to hear any feedback and what you think we missed.
TODOs:

[x] functional test for python incremental model
[ ] separate out copy grants to make it work for both python and SQL model

@jtcohen6  this is ready minus the part copy grants won't work for python model, it need some refactor that probably should be ticketed work. Created #214 to track it


Expand/collapse mask sometimes creates extra mask values

using collapse_mask() on the attached nifti file (which contains 16 mask images) adds more unique mask values than should exist (26, where there should be 16). Subsequently calling expand_mask()  therefore expands out to a Brain_Data instance with shape[0] == 26 instead of 16.
Using the following file as fName:
compiled_masks.nii.gz
Example code:
dat = Brain_Data(fName)
collapsed = collapse_mask(dat)
len(np.unique(collapse.data) # this is wrong, too many
expanded = expand_mask(collapsed)
expanded.shape()[0] # this is wrong, too many

The following doesn't seem to help either:
#Assure masks are binary
newMasks = dat.empty()
for ma in dat:
    newMasks = newMasks.append(ma.threshold(0,binarize=True))
collapsed = collapse_mask(newMasks)
expanded = expand_masks(collapsed)
expanded.shape()[0] #still wrong

This is probably a consequence of overlapping masks.  We could add an option to automatically remove overlapping areas, but not sure if this is a good idea.  Maybe we should just note this in the documentation.


covid interpretability

@wyli I was interested to see the interpretability using images that were less zoomed in compared to the lesion example. Not sure what to make of the images yet.
@ericspod Would it be possible to put the covid images somewhere public (e.g., Kaggle/Zenodo)?

just wanted to double check this PR, it's not ready because the x-ray dataset not released publicly?

just wanted to double check this PR, it's not ready because the x-ray dataset not released publicly?

Hi, that's correct. @ericspod any update on this? Would you like me to see to it?

Hi, that's correct. @ericspod any update on this? Would you like me to see to it?

I have the dataset up now on a Kaggle page: https://www.kaggle.com/ericspod/project-monai-2020-bootcamp-challenge-dataset If this is ok with everyone I will update the bootcamp repo with reference to it and the other materials for the day 3 challenge.

I have the dataset up now on a Kaggle page: https://www.kaggle.com/ericspod/project-monai-2020-bootcamp-challenge-dataset If this is ok with everyone I will update the bootcamp repo with reference to it and the other materials for the day 3 challenge.

This PR is now ready for review @wyli @ericspod @Nic-Ma . Thanks!

This PR is now ready for review @wyli @ericspod @Nic-Ma . Thanks!


XGBoost 2.0.0 breaks tests

XGB 2.0.0 was released last week (Sept 12, 2023).  This causes 19 tests to fail.
Many errors are related to NDCG ("NDCG is now the default objective function.")

Before, I believe they were defaulting to objective="rank:pairwise" but that doesn't seem to fix this.
Also, we'll need an upstream fix from onnxmltools for the 1 onnx XBG error.
Pinning this for now.

onnxmltools was updated but let's wait for their release, then do ours

With the onnxmltools patch, we now get some new errors:
==== 19 failed, 516 passed, 105 skipped, 115 warnings in 294.32s (0:04:54) ====
Some of them are
FAILED ....Check failed: label_is_valid: Relevance degress
must be lesser than or equal to 31 when the exponential NDCG gain function is used.
Set `ndcg_exp_gain` to false to use custom DCG gain.

but many are just outright wrong: Mismatched elements: 100 / 100 (100%) ...

The problem is related to convert_sklearn_xgb_regressor's https://github.com/microsoft/hummingbird/blob/1ae115227b6a8686def78164ec8cb3cad7a0f531/hummingbird/ml/operator_converters/xgb.py#L133

With xgb==1.7.6, for get_dump() we have '0:[f0<0.84472543] yes=1,no=2,missing=1\n\t1:leaf=-0.0600000024\n\t2:leaf=0.100000009\n',
whereas with xgb==2.0.0 we have '0:leaf=2.36637643e-09\n' from get_dump()
Then at:
https://github.com/microsoft/hummingbird/blob/1ae115227b6a8686def78164ec8cb3cad7a0f531/hummingbird/ml/operator_converters/xgb.py#L81
the values for TreeParameters(lefts, rights, features, thresholds, values) are incorrect

Since it seems they likely changed something internally (now it appears there is a one-node tree rather than a three-node tree), this will take a bit more time.  Let's not block the release on this for now.

TODO: look at https://github.com/onnx/onnxmltools/pull/597/ more closely

Going forward we can look at #764 as a starting point


feat(app): use pv to persist sessions

WIP
/deploy #persist

You can access the deployment of this PR at https://renku-ci-nb-1518.dev.renku.ch


Removed incorrect return type annotation

1. Why is this change necessary?
This removes an incorrect return type annotation.
2. What does this change do, exactly?
It removes the "@return array" annotation, because the method does not return anything - it does not make use of the "return" keyword.
3. Describe each step to reproduce the issue or behaviour.
Search for the "return" keyword in the code of the loadStoresAction() method - you will not find it so there is no return value.
4. Please link to the relevant issues (if any).
None
5. Which documentation changes (if any) need to be made because of this PR?
None
6. Checklist

[x] * I have written tests and verified that they fail without my change
[x] * I have squashed any insignificant commits
[x] * This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

* = Not relevant

We decided to close this PR because of time constraints and limited overall benefit to the product. If this change is still important to you, please create a new issue on https://issues.shopware.com so people can up-vote this feature.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.

Well  that's fine but don't expect me to spend time again for another pull request, if clicking on a merge button for an obviously correct pr isn't worth your time.

Hey @chriskonnertz,
I'm sorry we upset you by not merging. It takes more time for us than just pressing the merge button, we would have to import the branch to our internal git and then stick to our normal workflow, including QA and testing.
A tiny change can (and in the past did) break things that no one thought of, be it in the Shopware core or for plugin developers.
We are thankful for people like you putting time and effort into Shopware. So if in the future you need a change to the core that is beneficial for others as well we would be glad if you submitted it as a PR.

@ndzoesch
Hello,
thank you for this explanation.
However,

A tiny change can (and in the past did) break things

this does not seem to be a valid argument in this case, since I did not change any
executable code.

So if in the future you need a change to the core that is beneficial for others as well we would be glad if you submitted it as a PR.

Unfortunately this is no longer possible.


Design order and account batch effect

I am running DE analysis on some single cell datasets created merging multiple samples from different studies. All the datasets are saved as Seurat objects and the meta.data have this structure:
 orig.ident nCount_RNA nFeature_RNA percent_mt
PMM_Bcell_1_TCACAAGCACGGACAA-1        PMM       1943          813   4.220278
PMM_Bcell_4_AAGGAGCCAGGTCTCG-1        PMM       1285          733   2.101167
PMM_Bcell_4_GTGGGTCAGAACAATC-1        PMM       1111          601   2.430243
PMM_BM_3_GGACAAGGTCTAGCGC-1           PMM       3502         1592   4.625928
PMM_BM_8_CACAGGCGTGTATGGG-1           PMM       3393         1757   5.097230
PMM_BM_8_TGGCGCACAACTGCGC-1           PMM       2856         1419   4.201681
                                      label             cell_type   replicate
PMM_Bcell_1_TCACAAGCACGGACAA-1  NK resident CD56dimCD16+ NK cells PMM_Bcell_1
PMM_Bcell_4_AAGGAGCCAGGTCTCG-1 NK exhausted CD56dimCD16+ NK cells PMM_Bcell_4
PMM_Bcell_4_GTGGGTCAGAACAATC-1 NK exhausted CD56dimCD16+ NK cells PMM_Bcell_4
PMM_BM_3_GGACAAGGTCTAGCGC-1     NK resident CD56dimCD16+ NK cells    PMM_BM_3
PMM_BM_8_CACAGGCGTGTATGGG-1     NK resident CD56dimCD16+ NK cells    PMM_BM_8
PMM_BM_8_TGGCGCACAACTGCGC-1    NK exhausted CD56dimCD16+ NK cells    PMM_BM_8

The columns label contains the two groups that I want to compare, cell_type as the name suggest the cell types and replicate the different samples which the cells come from.
My questions are:

I can I select the order of the comparison (NK exhausted vs NK resident | NK resident vs NK exhasuted)? If the answer is no, how can I understand which group is taken as control?
To take account of the batch effect, there are different methods, for example with DESeq2 is possible to add it in the model design (~batch + condition), is it possible to add this variable to Libra's function run_de? If no, does it make sense to take the pseudobulk matrix and use it as bulk expression matrix to input into edgeR/DESeq2/limma? In this way I could create a personalized design matrix or run the batch correction separately before run the DE analysis

Thank you for the support
Jacopo

Yes you can simply set the factor levels and Libra will use that to set the reference.
No, we will add this in an updated version. However, you can just to Libra:::to_pseudobulk and use this in your own custom analysis with edgeR/DESeq2/limma.

Thank you for the answer, all clear

Hi，I wanna to ask how to specify  the comparison  in Libra?

See https://github.com/neurorestore/Libra/issues/6

Thanks

Hello，beforeI am running DE analysis，I set data$label <- factor(data$label, levels = c("after","before"))，does it mean that the comparison is before vs after ?

The second factor level is used as reference.

Thanks so much


Make the free version of the map enabled by default so that open source contributors/users don't have to have API key for paid version

From slack - possible solution:
Free map is always on -> switch to paid

for staging and production env

feature flag is set to switch to a paid map via URL, e.g, ?flags=map_type_paid

this flag loads API key from the .env.prod file and loads paid map.

since the API key is placed in .env files and .env files are placed into .gitignore (see note)
for a local dev that tries to load the map locally

it works by default as the free map
when trying to set the feature flag to paid via ?flags=map_type_paid

map will not load unless they have the our key OR
they create an account and get their own API key and place into .env.dev

currently the .env.* are in .gitignore so this will break the docker map

closed with the last PR 1155


[WIP] More external mock tests

More tests with mocked external services.
See #959 .

Note: most of the commits appearing in the list have been already merged to master.

/azp run

Transaction tests have been 'mockified', for all coins.
The command make newman-mocked host=localhost:8420 should be added as a new CI build.
Transaction tests:

non-mocked: runs in 57 seconds, 14/58 cases fail.
mocked: runs under 4 seconds, 0 failures.
It even runs with no network connectivity :)


Should the regex be shortened?

Since var WHITESPACE = /\s/;, should var NUMBERS = /[0-9]/; be var NUMBERS = /\d/; and var LETTERS = /[a-zA-Z]/; be var LETTERS = /[a-z]/i;? Thanks!

\d is not equivalent to [0-9]: http://stackoverflow.com/a/16621778/973988
D:

Interesting and thanks for the pointer. I'm not sure, if that is true in javascript
// english 1-0 followed by bengali 1-0
'1234567890১২৩৪৫৬৭৮৯০'.match(/\d*/) // ["1234567890"]

Also interesting :)

If someone wants to pr the /[a-zA-Z]/ => /[a-z]/i that's fine, not a big deal either way


libsecret: 0.21.3 -> 0.21.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for libsecret is: A library for storing and retrieving passwords and other secrets
meta.homepage for libsecret is: https://wiki.gnome.org/Projects/Libsecret
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.21.4 in filename of file in /nix/store/rvgk9hiy6g94wahdyklsrp62f5sg31zg-libsecret-0.21.4

Rebuild report (if merged into master) (click to expand)

755 total rebuild path(s)

755 package rebuild(s)

First fifty rebuilds by attrpath
CHOWTapeModel
ChowKick
abaddon
abracadabra
adapta-gtk-theme
aegisub
ahoviewer
akkoma
alfaview
alfis
almanah
amule
amule-daemon
amule-gui
amule-web
ansel
anytype
apache-directory-studio
apostrophe
appgate-sdp
archi
arduino-ide
armcord
asc
asn1editor
astroid
audacity
aws-workspaces
ayatana-indicator-datetime
ayatana-indicator-session
badwolf
balsa
bambu-studio
beeper
bespokesynth
bespokesynth-with-vst2
beyond-identity
birdfont
bitwarden
bitwarden-directory-connector
bitwarden-directory-connector-cli
blackbox
boatswain
bochs
boinc
bookworm
bossa
bossa-arduino
bubblemail
budgie.budgie-control-center

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rvgk9hiy6g94wahdyklsrp62f5sg31zg-libsecret-0.21.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libsecret https://github.com/r-ryantm/nixpkgs/archive/0997b57e759c5bb58538d978dda0726c1aac1eda.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0997b57e759c5bb58538d978dda0726c1aac1eda#libsecret

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rvgk9hiy6g94wahdyklsrp62f5sg31zg-libsecret-0.21.4
ls -la /nix/store/rvgk9hiy6g94wahdyklsrp62f5sg31zg-libsecret-0.21.4/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @bobby285271 @hedning @jtojnar @dasj19 @amaxine @lovek323 @7c6f434c for testing.

@ofborg eval


feat: allow serialization/deserialization of custom data types (alternative API)

Alternative to #13125. Instead of separating the logic between hooks.server.js and hooks.client.js, this puts both things in hooks.js. Initially I thought the separate made more sense, but I'm not so sure. In essentially all cases, you'll need a reference to the custom type — for an instanceof check during serialization, and for instantiation during deserialization — so there doesn't really seem to be a benefit to keeping them in separate files.
Putting them in one place is easier to understand, and means you can't end up with mismatches. It does mean that the serialization logic ends up in the client, but we're talking about a few bytes for a value instanceof Foo && [value.blah] function.
I'm not too sure about the naming of things. Right now it looks like this:
// hooks.js
import { MyCustomThing } from '$lib/stuff';

export const transport = {
  MyCustomThing: {
    reduce: (value) => value instanceof MyCustomThing && [value.blah],
    revive: ([blah]) => new MyCustomThing(blah)
  }
};

Are transport, reduce and revive sufficiently clear? serialize and deserialize are alternatives but they're quite long words. toJSON and fromJSON don't quite capture it (since we're not actually producing JSON, or even necessarily JSON-serializable values). Not sure if there's something better.
TODO:

[ ] add a type for the export (ultimately, this should be added automatically just like other hooks)
[ ] documentation

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Are transport, reduce and revive sufficiently clear?

Thinking further: I like encode and decode. Short, symmetric, and clear but sufficiently abstract (e.g. doesn't imply stringification)

preview: https://svelte-dev-git-preview-kit-13149-svelte.vercel.app/
this is an automated message

I would prefer a version where you can tree-shake the server code:
export const transportEncode = {
  MyCustomThing: (value) => value instanceof MyCustomThing && [value.blah]
};

export const transportDecode = {
  MyCustomThing: ([blah]) => new MyCustomThing(blah)
};

We're talking about a few bytes, unless you have a realistic example to the contrary? I don't think the trade-off is a good one

Amazing stuff!


L2CAP cases

Can you apply the following ? Once the bumble PR is merged we can update bumble accordingly :ok_hand:
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -10,7 +10,7 @@ classifiers = [
 ]
 dependencies = [
     "bt-test-interfaces>=0.0.4",
-    "bumble>=0.0.176",
+    "bumble@git+https://github.com/zxzxwu/bumble#egg=l2cap_pandora",
     "protobuf==4.24.2",
     "grpcio==1.57",
     "mobly==1.12.2",


Revert "Added slaves file back since it was breaking bigtop rpm"

Reverts amplab/tachyon#610

Why revert?
On Jan 19, 2015 3:51 PM, "Haoyuan Li"<EMAIL_ADDRESS>wrote:

Reverts amplab/tachyon#610 https://github.com/amplab/tachyon/pull/610
You can view, comment on, or merge this pull request online at:
https://github.com/amplab/tachyon/pull/613
Commit Summary

Revert "Added slaves file back since it was breaking bigtop rpm"

File Changes

M .gitignore
https://github.com/amplab/tachyon/pull/613/files#diff-0 (3)
D conf/slaves
https://github.com/amplab/tachyon/pull/613/files#diff-1 (2)

Patch Links:

https://github.com/amplab/tachyon/pull/613.patch
https://github.com/amplab/tachyon/pull/613.diff

—
Reply to this email directly or view it on GitHub
https://github.com/amplab/tachyon/pull/613.

Because of the https://tachyon.atlassian.net/browse/TACHYON-213
@hsaputra  Am I mis-understanding something?

Henry asked you to revert but if you do you can not build the rpm against
master.  I currently rely on it so I get broken.
When a release finally happens we can revert this since we can update
bigtop then
On Jan 19, 2015 5:40 PM, "Haoyuan Li"<EMAIL_ADDRESS>wrote:

Because of the https://tachyon.atlassian.net/browse/TACHYON-213
@hsaputra https://github.com/hsaputra Am I mis-understanding something?
—
Reply to this email directly or view it on GitHub
https://github.com/amplab/tachyon/pull/613#issuecomment-70591234.

Make sense. Let me change it back.

Thanks
On Jan 19, 2015 5:59 PM, "Haoyuan Li"<EMAIL_ADDRESS>wrote:

Make sense. Let me change it back.
—
Reply to this email directly or view it on GitHub
https://github.com/amplab/tachyon/pull/613#issuecomment-70592821.

Ugh, this is not perfect but I guess we need it to allow external clients
to generate RPM :(
On Monday, January 19, 2015, dcapwell<EMAIL_ADDRESS>wrote:

Thanks
On Jan 19, 2015 5:59 PM, "Haoyuan Li"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Make sense. Let me change it back.
—
Reply to this email directly or view it on GitHub
https://github.com/amplab/tachyon/pull/613#issuecomment-70592821.

—
Reply to this email directly or view it on GitHub
https://github.com/amplab/tachyon/pull/613#issuecomment-70592851.

No, Haoyuan you were right. David works in different project that requires
the slaves file to be there to build rpm.
I don't like having temporary file in master but since we don't release
often I guess we need to do this.
Sorry for the confusion HY :(
On Monday, January 19, 2015, Haoyuan Li<EMAIL_ADDRESS>wrote:

Because of the https://tachyon.atlassian.net/browse/TACHYON-213
@hsaputra https://github.com/hsaputra Am I mis-understanding something?
—
Reply to this email directly or view it on GitHub
https://github.com/amplab/tachyon/pull/613#issuecomment-70591234.


Cassandra backend revamp

Implement RAII-based wrapper on top of Cassandra driver
Re-implements important reading/writing routines using the wrapper
Split into smaller logical components (Wrapper layer, Schema, SettingsProvider, ExecutionStrategy, RetryPolicy, Backend interface implementation, etc.)
Add testability and unit tests for components that can be mocked
Add db tests for the wrapper

Probably not complete/finished yet but let's start reviewing @cindyyan317.

Codecov Report

Merging #537 (cc21d62) into develop (5604b37) will decrease coverage by 1.73%.
The diff coverage is n/a.

❗ Current head cc21d62 differs from pull request most recent head f0ad4c4. Consider uploading reports for the commit f0ad4c4 to get more accurate results

@@             Coverage Diff             @@
##           develop     #537      +/-   ##
===========================================
- Coverage    16.84%   15.11%   -1.73%
===========================================
  Files           99      120      +21
  Lines         9203    10148     +945
  Branches      5688     6164     +476
===========================================
- Hits          1550     1534      -16
- Misses        6293     7274     +981
+ Partials      1360     1340      -20

see 52 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

While this is annoying, it's true that not the entire backend implementation is covered. When we delete old backend code this number will improve a lot tho. We will probably be adding more tests for the backend later on as well as possibly exclude it from clio (move it to a separate project perhaps).


Debian packages are not created with root privileges

Description
The debian packages aren't built with root:root privileges. So by installing them with dpkg (or equivalent) the files are extracted and the UID and GID are set to 1001:123, which can be literally anything on the system.
To Reproduce

download any .deb installer package
install (e.g. dpkg -i syncplay_1.6.9.deb)
check file permissions with ls -l /usr/lib/syncplay or ls -l /usr/lib/syncplay-server

Expected behavior
Root ownership of the extracted files
Version and platform:

OS: Pop!_OS 21.10
Syncplay version and build type: 1.6.9

Additional context
The files seem to be created with runner:docker privileges.
Solution recommendation
The .deb packages could be built with fakeroot, where it is possible to easily set UID and GID to 0:0, which is always the systems root, and build the .deb package.
I've extracted and rebuilt the package with correct permissions and installed it successfully on my system. It's working without issues.

Just adding another way to check privileges of installer package:
dpkg-deb --contents syncplay_1.7.0_Beta1.deb


docs(argocd): update argocd configuration documentation

Updates the Argocd plugin's installation guide to include the new backend system.
Argocd backend plugin still uses old backend system, so we are using a legacyPlugin wrapper to make the backend plugin work at the moment.
cc: @rohitkrai03

/lgtm

/approve


Please consider removing the FormControl's hardcoded 'fullWidth' property

We would like to suggest that you consider -- in the event that you haven't already -- the assumption that all mui-downshift components will want to span the entire width of their parent container.
With reference to the attached images, please note that we position our input controls in pairs within a single MUI <Grid item> container.

So the "City" control and the mui-downshift "State/Province" select control are in the same container. To achieve the proper side-by-side placement we must remove the 'fullWidth' property hardcoded into the FormControl at
Line 43 of Input.js file (<FormControl disabled={disabled} required={required} error={error} fullWidth>)
Here's what the form looks like before we remove that property:

The mui-downshift control thinks it should span the entire <Grid item> container, which has the effect of pushing it to the next line.
Thanks for reading and if we've missed or misused some aspect of your fine work, please let us know.

@SladeRun14 thanks for the feedback.  I've thought about this before, and it would be a breaking change (would result in a 2.0.0 release).  I like to keep things as little opinionated as possible, and I think removing the fullWidth would fall within that.
I would still like to ability to opt-in for those use cases (I typically turn it on for all my inputs).  Problem is what to call it.  We already have getInputProps that gets applied to the MuiInput component.  Possibly getFormControlProps.
https://github.com/techniq/mui-downshift/blob/master/src/Input.js#L43
I'm not sure when I'll be able to get to this, but if you could send a PR that I could review, I might be able to get that done quicker (shouldn't be a huge overall change, but would need 1 o 2 storybook stories added, etc).

@techniq thanks for considering our comment.  It looks like mui-downshift is not suitable for our use case.  Simply removing the fullWidth property wasn't enough to achieve the positioning we desire.  We also had to hardcode an MUI className in the outermost div:  <div className="MuiFormControl-root-251" {...getRootProps && getRootProps()}> which is a bit of a smell.  And even then the mui-downshift component doesn't position itself correctly on initial display.  The page has to be refreshed for the component to pop into place.
Should we discover an acceptable mui-downshift mod as we re-evaluate our options, we'll consider sending a PR. In the meantime, thanks again for your contributions to the material-ui space.


ButtonBar last page bar item is not displayed but still interactable

As per title.
The demo itself works fine, but even copying the demo over to a new project and this issue occurs.

@4D4B make sure your last child view controller conforms to XLPagerTabStripViewControllerDelegate and implements -(NSString *)titleForPagerTabStripViewController:(XLPagerTabStripViewController *)pagerTabStripViewController. Otherwise there will be no text in the last button.
Regards


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Changes Unknown when pulling 0f7c80d07496d528e335f6a9254d64c48132b024 on analysis-zOLa14 into ** on master**.

Changes Unknown when pulling 0f7c80d07496d528e335f6a9254d64c48132b024 on analysis-zOLa14 into ** on master**.


Update MiBoxer_FUT039Z.md to include ZHA

I can confirm these work in ZHA, I have two and they are doing fine. I've only had RGB strips connected so I cannot comment on white performance but RGB works as expected so no reason to doubt the white.

thanks


DOC: Refactor the README file.

Refactor the README file:

Make the README file be a reSTructured text format file to conform to
the ITKModuleTemplate.
Remove the copyright notice countradicting the ISC Apache license
accepted and explicitly mentioned in the module's source files.
Add License note in the README file.

LGTM!

@DVigneault thanks ! Credit still goes to your work 👍 .


Make function not access outer-state

Minor refactor to use functionality upstream

@regadas made the suggested changes 👍
Please have a look


Add functionality to avoid duplicate posting

After uploading a post, make sure to mark the file as uploaded before so that it doesn't get uploaded twice.
Could also delete the file after uploading it.

Kind of useless because you can just delete the file after uploading it


⚠ GitHub has degraded performance

In c9bca27, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 186 ms

Resolved: GitHub performance has improved in 95c4b98 after 2 hours, 2 minutes.


Error in fetching the Apple service connection details

When trying to connect to App Store Connect for a new project I'm getting this error:

Trying to add the account again also results in an error that the account already exists.
What could be wrong?

An additional error when trying to set up a new app specific password (although the previous one that was set was still valid):

I was able to completely remove the account and re-add it. Seems that it went through.
Perhaps there could be a better explanation of what is wrong, and hints on what to try in the interface. The errors were quite unhelpful.

@andreialecu  Were you able to resolve the issue? If you see it again, please reach out to us via support.

I was able to resolve it by re-adding the account.
Would be a good idea to improve this flow though. Feel free to close.

Another solution: Click on your Avatar -> Account Settings -> Developer Accounts
There was a message noting "invalid". Just click on it and "re-connect" your account.

The mis-leading error is still present as of today but thinking-twins solution works well (when clicking on Reconnect, the apple password is not requested, it's just an Apple re-authentication).


Fix bug that did not allow local Filesystem based repo

The code assumed HttpUrlConnection and fails in classCastException.
Also added some toSting.
There should be some more JUnit tests here :-)

To be honest, it's for the first time when I see that someone uses pf4j-update with a local repository.
Is it not enough to add or update the plugins (zip files) in pluginsDir folder (the default value is plugins)?
Do you have a real use case for a such feature?
If we need to support a such scenario my feeling is that FileDownloader is not the perfect place for modification and we should perform a check somewhere in front of this class.

I'm using it in some tests, and then it is convenient to simulate a repo in the file system.
The project I'm trying to integrate with is Apache Solr. And I can imagine users who use the product behind firewalls without access to the internet, where first downloading one or more online plugin repos to a shared file system and then pointing Solr to those might make sense.
Some users also have multiple Solr clusters, and having a central shared file system repo that each cluster could check for updates against sounds useful.
Of course such users could also serve the same files from a local Nginx or similar, but that is one more thing to manage...

I took a look in actual code.
I see that I have two repositories json in the root of project:

repositories,json
repositories-folder.json

So my feeling is that the actual code works with the folder repositories.
If it doesn't work to accommodate your request in the actual code  with minimal impact I see these steps:

create a new getPluginFile(String url) in UpdateManager
use the above method in installPlugin and updatePlugin (instead of FileDownloader)

The implementation of getPluginFile(String url) looks something like (the pseudocode)
if (url is a file) {
   return the file
} else {
   download the file via FileDownloader
   return the file
}

Makes sense I guess, that if the URL is indeed a local file, then no need to first copy it, if you are anyway going to unzip and then remove the original zip?

I don't understand your last comment.
First, it's not clear for me if the actual code works for your scenario with local repo (I think that if you declare the url of repo like in repository-folder.json, it should be OK).

Makes sense I guess, that if the URL is indeed a local file, then no need to first copy it, if you are anyway going to unzip and then remove the original zip?

It's the responsibility of the PluginManager to install the plugin in application (the DefaultPluginLoader unzip plugins archives from pluginsDir), the UpdateManager only fetch plugins files to pluginsDir.  We don't remove the zip archive (from PluginManager or UpdateManager).

No problems when using HTTP repo.
The test coverage is a bit lacking. Perhaps I get to write some unit tests later.


[5.7] Updates to chained aliases / Use direct-ref aliases and pre-chain aliases

-Keep track of aliases that should be referenced directly
-Keep track of pre-chain aliases separately from the final module aliases
-Use above lists when applying final aliases
-Update logic to determine when to apply aliases
-Added additional tests
Resolves rdar://95724629

@swift-ci smoke test

@swift-ci smoke test

self-hosted issues should get fixed by https://github.com/apple/swift-driver/pull/1127

BTW, I think looking into getting the self-hosted jobs to work for cross-repo tests seems actually important. Today we don't have a way to preflight coordinated manifest changes like this, since self-hosted jobs don't work and smoke tests are using local dependencies.

@swift-ci smoke test


Feature/ms graph api support

Adds support for sending mails via Microsoft Graph API
For testing purposes: you will need an Azure app and a tenant to send emails from. Microsoft offers a handy free developer program that you can use for 30 days: https://developer.microsoft.com/en-us/microsoft-365/dev-program
API Flow: create a draft, send draft, retrieve sent email.

Create draft: this way we get the email's ID. This ID can be used to perform the further operations on it. By using the header Prefer IdType="ImmutableId" we will receive an ID that does not change as the email gets moved from mailbox to mailbox (i.e. when it moves from "Drafts" to "Sent Items").
Send draft: send the email. Does not return anything, so if we need the MessageID we have to fetch the sent email.
Retrieve sent email. We fetch the email using the ImmutableID. From this we get the MessageID that we store in the DB. Sent emails are not guaranteed to appear in the "Sent Items" mailbox immediately, so we have a very rudimentary failsafe: request the item, if the response is 404, wait (by default 10 seconds), then try again. If it still hasn't appeared, propagate error.

Someone who knows the drone secrets used for the redpencil repo should add them to the .drone.yml file before merging this.


chore: add capi logo and move existing image

What this PR does / why we need it:
Adds CAPI logo to repo so that it can be used elsewhere. And also moves existing "cupid" image to the same location.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:

[ ] squashed commits into logical changes
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

Merging with only 1 approval


x64 backend: refactor for uniform handling of instruction-operand-size flags

Currently, the new x64 backend encodes operand-size information into x64::Insts in various ways, depending on the arm of the enum. We should refactor so that we use an OperandSize universally; this would cut down a bit on boilerplate and would add some clarity.
Related to that, we also have some fairly subtle logic surrounding REX-prefix emission. We should modify RexFlags so that it takes an OperandSize in its constructor, to make REX-prefix errors less likely.

Hi Chris,
From looking at inst/mod.rs refactoring Inst to use OperandSize seems straightforward enough on the surface (famous last words).
Do you mind if I take a stab at it?

Hi Chris,
From looking at inst/mod.rs refactoring Inst to use OperandSize seems straightforward enough on the surface (famous last words).
Do you mind if I take a stab at it?

@kaseyc -- please do! This is a pretty well-scoped issue I think -- you should be able to change the Inst enum first and then just follow the type errors all the way. Thanks!

@kaseyc -- please do! This is a pretty well-scoped issue I think -- you should be able to change the Inst enum first and then just follow the type errors all the way. Thanks!