Add a setting to flash the pane when BEL is emitted

Summary of the Pull Request
Adds a new bellStyle called window. When window is set and a BEL is emitted, we flash the pane that emitted it.
Additionally, changes bellStyle in the SUI to a list of checkboxes instead of radio buttons, to match bellStyle being a flag-enum. Deprecates 'BellStyle::Visual' in the schema, but still allows it to be set in the json (it maps to Window | Taskbar)

References
#6700

PR Checklist

[ ] Closes #xxx
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[x] I work here

Validation Steps Performed
GIF in Teams

hit me with a gif

hit me with a gif

done!

Maybe InvertScreenColors/_InvertTimerTick need to take the write lock?

That seems to have fixed it, tested by repeatedly sending a bunch of BELs and couldn't get the screen to not revert back properly

Hmm. So bellStyle now has these options:

"audible": sound
"visual": "window" + "taskbar"
"window": flash the terminal
"taskbar": update the taskbar icon
The user can choose any combination above, or set all/none entirely:
"none": bell is ignored
"all": all of the above

I'm having two thoughts here:
Design
Should we "deprecate" visual? By that I mean...

remove visual from schema
in the code, treat "visual" as a quick way to set window and taskbar (keep legacy users happy)
default is [ "window", "taskbar" ]?

Maybe we need to introduce another bellStyle for tab?
I'm worried this proposal may give people too many bells and whistles? But the purpose of this proposal is to keep "visual" separate from "all" more clearly. Thoughts?
Settings UI
(this is more of a follow-up task, but it's still relevant right now)
I think we may want checkboxes instead of radio buttons now. This'll let users enable/disable the bell styles they want.
It's too much work for this PR because I feel like we'll want to use this as we introduce more flag-style settings. But just something to keep in mind. I'm ok with what we have now.

Marking this PR as ready for review now.
Disclaimer: I am not very happy with moving away from an auto-generated enum list to a manually created one for bellstyle, but XAML doesn't seem to have a clean way to allow binding checkboxes to individual flags of an enum. The best I could find was this C# example, but after spending most of a day trying to implement that and speaking to someone on the XAML team about it, it seems that its not very applicable to our C++/WinRT scenario.

This looks/feels really good. It also seems to crash if the flashing tab is not the active tab (!).

I seriously love how nice this feels.

It also seems to crash if the flashing tab is not the active tab (!).

Oops, thanks for catching that, fixed!

abstraction concern. if you'd rather keep it this way, let me know!

I think I like the idea of letting the app handle the flash. Though I think it'll be much smoother to do that after the pane refactor goes in - that way we can attach the xaml light to the pane instead of the control's grid. Thoughts?

@carlos-zamora can you dismiss or re-review?


feat: add dialogOpened activitytype

Description
Added dialogOpened as an activityType, and added validation for dialogOpened
Related Issue(s)
#1078
Verification

[x] Your code builds clean without any errors or warnings
[x] Manual testing done (required)
[x] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@coderabbitai full review

Actionable comments posted: 2
Outside diff range and nitpick comments (1)

tests/k6/common/dialog.js (1)> 143-149: Nitpick: Consider setting activities to undefined instead of using delete.

The static analysis tool suggests avoiding the delete operator for performance reasons. As an alternative, you can set the activities property to undefined instead of deleting it:
 export function setActivities(dialog, activities) {
     if (activities == null) {
-        delete dialog.activities;
+        dialog.activities = undefined;
         return;
     }
     dialog.activities = activities;
 }

However, this is a low-priority suggestion and the performance impact is likely negligible in most scenarios. The current implementation is correct and can be left as is.
Let me know if you'd like me to submit a PR with this change.
Tools
Biome> [error] 145-145: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)

Review details

Please go ahead with the PR.


Use const fn for constructors

Thank you for helping out with embedded-graphics development! Please:

[x] Check that you've added passing tests and documentation
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
[x] Run rustfmt on the project
[x] Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
This makes the following functions const:

Point::component_mul
Point::component_div
Size::saturating_add
Size::saturating_sub
Size::component_mul
Size::component_div
BinaryColor::invert
BinaryColor::is_on
BinaryColor::is_off
Rectangle::with_center
Rectangle::is_zero_sized
RawDataSlice::new
MonoTextStyle::new
Arc::with_center
Arc::from_circle
Arc::to_circle
Circle::with_center
Ellipse::with_center
Sector::with_center
Sector::from_circle
Sector::to_circle
Styled::new

One of biggest obstacles to making functions const was that the arithmetic operators can't be used in a const context except on integers. Rectangle::with_center in particular couldn't be const because of that limitation, and is used by several other constructors, so I added const versions of the necessary sub and div functions to Point and Size as a workaround so that I could make it const. I also had to bump the MSRV up to 1.57 since it stabilized panicking in const functions because Point's implementation of Sub<Size> panics. Do you think it's worth it?
Related
https://github.com/embedded-graphics/embedded-graphics/issues/205
https://github.com/embedded-graphics/embedded-graphics/pull/638

Looks like we're good for 1.57 instead of 1.56.1. Hopefully not too much work to update this PR!

👍🏻 I rebased it on top of the latest version of your PR branch.

Oops, looks like Github autoclosed this PR and won't let me reopen because the original branch was deleted. Can you try rebasing on master now that #638 is merged? If not, feel free to open a new PR with the changes.

Oops, looks like Github autoclosed this PR and won't let me reopen because the original branch was deleted. Can you try rebasing on master now that #638 is merged? If not, feel free to open a new PR with the changes.

Rebasing didn't give me the option to re-open it, so I made a new PR: https://github.com/embedded-graphics/embedded-graphics/pull/640.

Rebasing didn't give me the option to re-open it, so I made a new PR: https://github.com/embedded-graphics/embedded-graphics/pull/640.


SdlRouterService not exiting properly on some phones during BT toggle

On some phones (i.e. Moto E) when the bluetooth adapter is power cycled the router service doesn't close properly. The notification stays in the tray and clients aren't notified of the transport disconnect. This causes issues when the bluetooth adapter is cycled backed on and the router service attempts to make a connection between both the module and the clients.

Fixed with PR #322


Set up Mailchimp

[x] Set up Mailchimp

The client has confirmed they are comfortable with Mailchimp redirecting users away from the website when submitting the contact form. They have decided to continue using Mailchimp for this functionality.
Ensure that the integration is seamless and that the redirection provides a smooth user experience.
Additionally, verify that all form submissions are properly tracked and delivered to the client's Mailchimp account.

[ ] Checked by QA

MailChimp documentation here


feat(design): add details component

Description
An abstraction component which renders expanded list view is need to maintain consistancy among the various component.
Here are certain nice to haves:

A footer with some fields for meta data like task start time, end time etc.
A a URL field that renders a copy to clip button.
A tab group for separation of information. We can have vital info in the first on and rest on the other so on and so forth.
A fixed sized text box to show sys logs which can be very long (we can put this in a seperate tab group).

Possible solution(s)
Like in Form component, we can use .fields to create such component where each field will specify what kind of render will this be like, url, or large text, tag, footer on and so forth. Package-author can fill in the .fields with the data from API and that could be then used to render the values for their respective fields.

@git-anurag-hub The above mentioned are just some of the things I feel might make the full view a little cleaner, this is just an opinion, what do you think. Please update the description if you think we should go any other way.


Domain level security group should not be used for individual user-profile

Reference code
https://github.com/aws-samples/amazon-sagemaker-studio-secure-data-science-workshop/blob/b5505cc857f00fab178f476706dc5610e8714de6/cloudformation/ds_env_studio_user_profile_v1.yaml#L348
Current setup
The above code here uses the same, domain level security group for each user-profile in the domain. This security group is created here. This security group later adds an ingress to itself here.
Problem with current setup
In this setup, all app instances in the domain will be able to talk to each other because of this over permissive security group. Anyone who blindly uses this code will end up with their users being able to access each other's apps. This sample code is causing customer confusion. Some customers may remain blind to the issue unless they are checking VPC flow logs or goes through a pentesting process.
Recommended fix

Remove domain level security group ingress to itself. Keep that security group for common access patterns like apps being able to access VPCE/Privatelink, certain customer subnet, and IGW (if so desired)
Use Jinja2 or similar to create per user security-group in the CFN template where each security group allows ingress to itself but one user level security group is not allowed ingress into another

The issue has been resolved. Separate SageMaker domain level security group from user profile level security group. Removed SageMaker domain level security group ingress to itself. It is used for VPC Endpoint.

Separated SageMaker domain level security group from user profile level security group. Removed SageMaker domain level security group ingress to itself. It is only used for VPC Endpoint traffic in SM Exec Policy.


Hide cpu name not persists on rainmeter restart

this option not working on computer or rainmeter restart

That it doesn't. Working on a fix.


Deploy to Railway

Let's see whether GCP or Railway has better value for money.

Current numbers:

GCP+Firebase
Railway

curl frontend (cold)
✅ 0.450s
1.548s

curl frontend (warm)
✅ ~0.17s
~0.52s

curl /v2/version (cold)
53.214s
14.862s ✅

curl /v2/version (warm)
✅ ~0.42s
~0.54s

curl /v2/analyze
~0.83s
~0.42s ✅

curl /v2/compileDDC (no cache)
~5.88s
~5.12s ✅

curl /v2/compileDDC (with cache)
N/A
~2.44s ✅


[995] Course bugfix, enum and course improvements

Context

Rails enums generate methods by default. If the enum values are more ruby-esque in the first place, the helpers read much nicer
It's best to keep strings as a presentation concern
Code that uses ActiveRecord (and hence the database) is likely to be more performant that reading all the objects in memory and performing ruby operations on them

Changes proposed in this pull request

rubify the enums
re-implement certain Course methods using scopes

Guidance to review
Came out of a review from #118.
Update: while cleaning up this PR, @defong and I found a bug in the implementation of #118. This is fixed here.

@misaka we've re-instated the specs and found a bug in the process! 💯 Please have another look at this new and improved PR.


Add fabs, floor and ceil to math module

Hello,
I added fabs, floor and ceil functions to the math module.

Thanks for your contribution!


Concur brick not building

I'm getting the following build error:
   Configuring concur-brick-<IP_ADDRESS>...
    Preprocessing library concur-brick-<IP_ADDRESS>...
    [1 of 4] Compiling Concur.Brick.UI  ( src/Concur/Brick/UI.hs, .stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/build/Concur/Brick/UI.o )
    [2 of 4] Compiling Concur.Brick.Run ( src/Concur/Brick/Run.hs, .stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/build/Concur/Brick/Run.o )

    /Users/vilem/github/concur/concur-brick/src/Concur/Brick/Run.hs:40:35-39: error:
        Variable not in scope:
          runIO
            :: SuspendF [Image] (Free (Suspend [Image]) b) -> Maybe (IO ())

Is it still WIP?

Hey sorry, yes the brick backend is still WIP. Infact only the virtual-dom and react backends are usable. I'll add a note to the README.

Ah great, thanks. I did try out the virtual-dom backend as well, but that didn't build.

Try building with stack build --stack-yaml stack-ghcjs.yaml so that it will build with GHCJS. The vdom library it uses is bitrotten and will take some work before it can be compiled with GHC for native executables.


[code] remove unnecessary extern

I fully agree with @LuDuda. Use of extern to indicate if an API is callback or not is indeed very useful.

Agree with @LuDuda. The real purpose of extern in this case is for the developer.

Thank you for the explanation! I was considering to add -fvisibility=hidden and only export symbols in include/*, thoughts?


Invoke __newdinex for nil and NaN on tables, matching Lua 5.2

In Lua 5.1 and currently in Luau, __newindex only invokes for nil and NaN on anything but tables (so in Luau only userdatas).
Lua 5.2 changed this so that __newindex invokes for nil and NaN on tables.
For example with this script setmetatable({ }, { __newindex = print })[nil] = "Nil!"
Lua 5.1
Lua 5.1.5  Copyright (C) 1994-2012 Lua.org, PUC-Rio
> setmetatable({ }, { __newindex = print })[nil] = "Nil!"
stdin:1: table index is nil
stack traceback:
        stdin:1: in main chunk
        [C]: ?

Lua 5.2
Lua 5.2.4  Copyright (C) 1994-2015 Lua.org, PUC-Rio
> setmetatable({ }, { __newindex = print })[nil] = "Nil!"
table: [memory address]   nil     Nil!

Lua 5.3
Lua 5.3.6  Copyright (C) 1994-2020 Lua.org, PUC-Rio
> setmetatable({ }, { __newindex = print })[nil] = "Nil!"
table: [memory address]   nil     Nil!

Luau currently
> setmetatable({ }, { __newindex = print })[nil] = "Nil!"
stdin:1: table index is nil
stack backtrace:
stdin:1

This is useful if you want to implement a new custom table system where nil and NaN can be hashed without using newproxy. For example:
local nilkey = {}
local nankey = {}

local mt = {
    __index = function(self, k, v)
        if k == nil then
            return rawget(self, nilkey)
        elseif not rawequal(k, k) then
            return rawget(self, nankey)
        end
        return nil
    end,
    __newindex = function(self, k, v)
        if k == nil then
            rawset(self, nilkey, v)
        elseif not rawequal(k, k) then
            rawset(self, nankey , v)
        else
            rawset(self, k, v)
        end
    end,
}

local v = setmetatable({ }, mt)
v[1] = "1"
v[nil] = "Nil!" -- This errors in Lua 5.1 and Luau currently but works in Lua 5.2 and above
print(v[nil]) --> Nil!
v[0/0] = "NaN!"
print(v[0/0]) --> NaN!

The drawback is that this could potentially break compatibility with Lua 5.1 and bring performance implications; and this changes the semantics of x[y] = z for tables.
This is not documented in the Lua 5.2 compatibility section of Luau so I'm unsure what @zeux's position on this is.

This isn't mentioned in compatibility section mostly because that is based on official release notes, and many small behavior changes don't seem to be documented :) We weren't aware of this change in semantics.
Realistically, the current behavior is mostly a byproduct of the implementation details. This is somewhat linked to #380 and we're planning to look into changing the mechanics of table insertion a little bit to allow for changes like this more easily. I'm guessing that the implementation details in Lua 5.2 changed enough to permit this although I'm not sure if this was intentional or accidental.
(update, it's likely this change https://github.com/lua/lua/commit/89b59eee7386379e87200a86215fc6de91e49036 which is related to the problem that motivated us looking into this in the first place)
That said, we usually evaluate changes like this from the grounds of consistency and usefulness.
On the consistency angle, allowing nil keys gives me pause. It's incompatible with iteration behavior, so any custom container that supports nil keys won't be able to traverse over them.
On the usefulness angle, allowing NaN keys is a little sketchy. You can definitely imagine container implementations that use something other than normal equality such that NaN keys all compare equal to each other, but it seems a little questionable. That said, this is more defensible than nil because it would make more sense in general to allow all values of a given type such as number to serve as keys.
Either way, I think in this case we'd need to first lock down some changes around internals of table insertion, and then see to what extent we can relax the rules and whether it makes sense to do so separately.


az vm extension image show name/version mismatch

The az vm extension image show command returns the version in place of the name ( "name": "<IP_ADDRESS>"), tried this with azure-cli (2.0.28):
$  az vm extension image show --location westcentralus --publisher Microsoft.OSTCExtensions --name CustomScriptForLinux --version <IP_ADDRESS> --output json
{
  "additionalProperties": {},
  "computeRole": "IaaS",
  "handlerSchema": null,
  "id": "/Subscriptions/03dd9652-d9f8-4816-ab45-2dbe05bd3479/Providers/Microsoft.Compute/Locations/westcentralus/Publishers/Microsoft.OSTCExtensions/ArtifactTypes/VMExtension/Types/CustomScriptForLinux/Versions/<IP_ADDRESS>",
  "location": "westcentralus",
  "name": "<IP_ADDRESS>",
  "operatingSystem": "Linux",
  "supportsMultipleExtensions": false,
  "tags": null,
  "type": null,
  "vmScaleSetEnabled": false
}

This comes from service side. Let me contact with CRP folks

The underneath REST call is GET /subscriptions/.../Providers/Microsoft.Compute/Locations/westcentralus/Publishers/Microsoft.OSTCExtensions/ArtifactTypes/VMExtension/Types/CustomScriptForLinux/Versions/<IP_ADDRESS>?api-version=2017-12-01, so it is the version entity gets retrieved. Still the name fields looks odd
//cc: @danielsollondon

Is the ask to improve the API behavior in that it shouldn't return a field name that confuses users?

That is right, but we can live with this

Cleaning up old issues from 2016 - 2018. Please reopen this issue if it is still a concern.


Should the reserved keywords expand for JDK8 or later?

JDK8 or later version has more keywords like 'try-with-resources', 'goto', 'volatile'.
private static final String[][] RESERVED_KEYWORDS = {
    {},
    {},
    {"do", "if", "in", },
    {"for", "let", "new", "try", "var"},
    {"case", "else", "enum", "eval", "null", "this", "true", "void", "with"},
    {"catch", "class", "const", "false", "super", "throw", "while", "yield"},
    {"delete", "export", "import", "return", "switch", "static", "typeof"},
    {"default", "extends", "public", "private"},
    {"continue", "function"},
    {"arguments"},
    {"implements", "instanceof"}
  };

Reference:  [JDK 8 keywords] (https://docs.oracle.com/javase/tutorial/java/nutsandbolts/_keywords.html)

try-with-resources just uses try followed by a parenthetical, no?  goto and volatile were keywords from Oak days, no?
Besides, these are javascript reserved keywords.  I think you're right that the list needs some additions: async for example.


[question] Using a Proxy

How could one create bots using remote proxies?

This question needs some clarification. What exactly are you trying to do?

I bet something like  https://github.com/PrismarineJS/node-minecraft-protocol/issues/185 , an http/socks proxy, not Minecraft one

Socks is trivial to add but I don't really feel like adding it to mainline. If that's a usecase you need to support all you need to do is create a new socket for Spock to connect with for example using https://github.com/Anorov/PySocks .
Spock is explicitly friendly about swapping out core plugins for this reason. If you need a Minecraft proxy, they're a dime a dozen, just pick one. You can build one with Spock in under an hour if you're familiar with the Minecraft protocol.
But ya, I don't really like adding dependencies without a very good reason.

Ah, I see. Thank you - problem is solved. Apologies for not replying - I haven't logged into Github for days.


Use buffer as key to store messages

It was added in a PR, reverted accidently, now adding again

Travis seems to be acting weird, specs pass locally for me
~/.a/p/linter ❯❯❯ apm test                                                                                steelbrain/message-registry-enhancements
Window load time: 630ms
................................................................................................
Finished in 4.429 seconds
96 tests, 240 assertions, 0 failures, 0 skipped

The build has been failing since https://github.com/atom-community/linter/pull/1012 was merged in, all subsequent builds have failed.
Something is different between your local copy and Travis since it has one additional assertion compared to your output.

I wonder how it is possible since my local copy and travis share the same specs folder. I'm using the latest apm by the way


fix: [CDS-99032]: Removed the accountIdentifier

Describe your changes
Comment Triggers

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck
gitleaks: trigger gitleaks

Please test following this scenario

teraform apply ( create new one )
terraform apply ( reruning terraform apply after creating )
remove project from namespace and rerun it should get create
terraform apply update ( some of the fields of project itseld )
terrfaofmr apply rerun ufter update
try to update some of the fields agent_id, org_id, account_id ( it should be recreated)
rerun terraform apply after update ( nothing should change )
remove project from terrafrom resource file and run terraform apply
rerun terraform apply


http_plugin and a unix socket

I noticed the other day that there was an option in the http plugin to use an unix socket however when I tried to set that config option I got an error message stating it was unrecognized.
std::exception::what: unrecognised option 'unix-socket-path'
Looking at the code it seems that if the default is not set then the option is not added.
https://github.com/EOSIO/eos/blob/2232802dee4be1a3f6ca436edad64af3c45d7029/plugins/http_plugin/http_plugin.cpp#L351
I guess the question is whether this is supposed to work and if not will it be supported in the future?

The http_plugin's unix socket support is in use by keosd as a more secure option for communicating with it.  There are no plans to enable that support in nodeos.


Line numbers are often not present in error reporting for a model

While developing TorXakis models you make a mistake every now and then. For some obvious syntax errors you get a line number reported, very useful! But for most errors you are left in the dark about where to start searching for the mistake. Now that our models are getting bigger this is really becoming an issue! Please provide a location for all errors in the model.

The error message given in these situations then mentions that something is wrong with the operator /\ or ++, but as these operators occur very often in the model, you have no clue where to look

Hi, I just submitted a pull request with a new compiler which produces more information. Could you give it a try and submit issues when an error is not useful enough? Then we can improve the error messages in a case by case basis. Thanks!

Thanks for the update.
Kind regards,
Johan Foederer
Océ-Technologies • Software Test Automation specialist
E johan.foederer<EMAIL_ADDRESS>• T +31 (0)77 359 2529 • W www.oce.comhttp://www.oce.com/
This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by telephone or with a 'reply' message and delete the message and its attachment(s), if any, from your system(s). Thank you for your co-operation.
From: Damian Nadales<EMAIL_ADDRESS>Sent: maandag 25 juni 2018 10:07
To: TorXakis/TorXakis<EMAIL_ADDRESS>Cc: Foederer, Johan<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [TorXakis/TorXakis] Line numbers are often not present in error reporting for a model (#496)
Hi, I just submitted a pull request with a new compilerhttps://github.com/TorXakis/TorXakis/pull/741 which produces more information. Could you give it a try and submit issues when an error is not useful enough? Then we can improve the error messages in a case by case basis. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/TorXakis/TorXakis/issues/496#issuecomment-399867646, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ae-LzPFY9Fmk4HscfMQcJQP_PM_yd2DIks5uAJoJgaJpZM4QdKLj.

permanently removed sensitive info.


Reset min date on the slider demos to lowest possible (0?)

Looks like this is an almost instant change in the demo params, right?
For low end of "When am I?" and low end of time-slider, let's allow this to be "0" or "1" whichever works.

[ ] Demos change range to [0, 2020]

[ ] MBGL demo
[ ] Leaflet demo

[ ] fix breakages due to years not being 4 digits; tests so far have always had 4 digits, never gone to <1000

[ ] MBGL control
[ ] Leaflet wrapper

MBGL demo:
Date range changed to [ 0, currentyear ] and will change with each calendar year.
Default view is http://localhost:9000/demo/ which thanks to UrlHashWriter will update to something close to  http://localhost:9000/demo/#14.600/40.80623/-73.91894/1920,0-2019
Internal rename of the range parameter, and updated docs.
Reworked date filter logic, to pad out years to 4 digits, e.g. the year 718 would be represented by the bookends "0718-01-01" and "0718-12-31"

Leaflet demo:
https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/
Date range is now [ 0, currentyear ] same as MBGL demo.
Changed to datespan parameter to range.
Confirmed that other behaviors such as the casting to 4 digit years, is handled by the underlying MBGL control which has been upgraded.


Match movies in the Netflix data set to movies on Wikidata

Netflix Data Set (2007)
The only relevant information in the data set is the movie title and year. We would need to search Wikidata using their REST API. We would then want to store the QID (the wikidata ID) of the item along with any relevant "features" (genre, awards, director etc), and map it to the netflix movie id in the dataset. For example.
Netflix Movie Id: 4521
Wikidata ID: Q781324
Title: The Matrix
Year: 1999

Here is a SPARQL query for finding movies from a certain year with a certain title:
SELECT * WHERE {
  SERVICE wikibase:mwapi {
    bd:serviceParam wikibase:api "EntitySearch" ;
                    wikibase:endpoint "www.wikidata.org" ;
                    mwapi:search "One Last Dance" ;
                    wikibase:limit 1 ;
                    mwapi:language "en" .
    ?item wikibase:apiOutputItem mwapi:item .
  }
  {
    ?item wdt:P31/wdt:P279* wd:Q11424 ;
          wdt:P577 ?releaseDate ;
          rdfs:label ?itemLabel .
    FILTER("2003-01-01"^^xsd:dateTime <= ?releaseDate && ?releaseDate < "2004-01-01"^^xsd:dateTime) .
    FILTER (lang(?itemLabel) = "en") .
    SERVICE wikibase:label { bd:serviceParam wikibase:language "en" . }
  }
}
LIMIT 1

This query is for "One Last Dance" and the year 2003, those parameters should be modified.
It can be used to look up movie titles/years in Wikidata, based on the movie name and year. However, we would likely want to expand this with clauses for the other information we want like "genre" (which we can see is P136 on this page: https://www.wikidata.org/wiki/Q1755591). So we would add:
...
    ?item wdt:P31 wd:Q11424 ;
          wdt:P577 ?releaseDate ;
          wdt:P136 ?genre .
...

However, the genre could be missing, so we should enclose it in an OPTIONAL block:
...
    ?item wdt:P31 wd:Q11424 ;
          wdt:P577 ?releaseDate .
   OPTIONAL { ?item wdt:P136 ?genre . }
...

This query can be used with the Wikidata Query Service REST API, as demonstrated in this Python lesson from the class: https://github.com/noisebridge/PythonClass/blob/main/lessons/10-web-scraping/web-scraping.ipynb

Wikidata Query Service

Code from notebook:
import requests

query = '''
SELECT DISTINCT ?item ?itemLabel ?rtid WHERE {
  ?item wdt:P136 wd:Q471839.
  ?item wdt:P577 ?pubdate.
  ?item wdt:P1258 ?rtid.
  FILTER((?pubdate >= "1990-01-01T00:00:00Z"^^xsd:dateTime) && ((?pubdate < "2000-01-01T00:00:00Z"^^xsd:dateTime)))
  SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}
'''

resp = requests.post('https://query.wikidata.org/sparql',
              headers={'User-Agent': 'Noisebridge MovieBot 0.0.1/Audiodude<EMAIL_ADDRESS>              data={
                'query': query,
                'format': 'json',
              }
)
resp.raise_for_status()

data = resp.json()
ids =[d['rtid']['value'] for d in data['results']['bindings']]

Semi functional pr: https://github.com/noisebridge/UntitledPythonProject/pull/8

I will work on the SPARQL query to make it more accurate.

Okay this query gets Lilo & Stitch the movie.
SELECT * WHERE {
  SERVICE wikibase:mwapi {
      bd:serviceParam wikibase:endpoint "www.wikidata.org";
                      wikibase:api "EntitySearch";
                      mwapi:search "Lilo and Stitch";
                      mwapi:language "en".
      ?item wikibase:apiOutputItem mwapi:item.
  }
  ?item wdt:P31/wdt:P279* wd:Q11424 ;
          wdt:P577 ?releaseDate .
  SERVICE wikibase:label {
    ?item rdfs:label ?temLabel .
    bd:serviceParam wikibase:language "en".
  }
  FILTER("2002-01-01"^^xsd:dateTime <= ?releaseDate && ?releaseDate < "2003-01-01"^^xsd:dateTime) .
} LIMIT 10

The key is removing/extending the limits from both the API request and the query itself. It is possible you will now get multiple hits for the same query, and I'm not entirely sure what we should do in that case. Any ideas?
Also note that the strategy of "search 2 years before and 2 years after" wouldn't work here, because if you do that, you're going to get the spin off movies that came out in 2003.

Also, if you add in the genre, without LIMIT 1, you get all the genres:
https://w.wiki/Az$A

Get either US release date if it exists, or unspecified if not
{
# Get US release date
?item p:P577 ?releaseDateStatement .
?releaseDateStatement ps:P577 ?releaseDate .
?releaseDateStatement pq:P291 wd:Q30 .
}
UNION
{
# Get unspecified release date
?item p:P577 ?releaseDateStatement .
?releaseDateStatement ps:P577 ?releaseDate .
FILTER NOT EXISTS { ?releaseDateStatement pq:P291 ?country }
}


dep/gps/pkgtree: test failure

deadwood(~) % go test github.com/golang/dep/gps/pkgtree
--- FAIL: TestListPackages (0.00s)
    --- FAIL: TestListPackages/malformed_go_file (0.00s)
        pkgtree_test.go:1320: Did not get expected PackageOrErrs:
                        (GOT): pkgtree.PackageTree{ImportRoot:"bad", Packages:map[string]pkgtree.PackageOrErr{"bad":pkgtree.PackageOrErr{P:pkgtree.Package{Name:"", ImportPath:"", CommentPath:"", Imports:[]string(nil), TestImports:[]string(nil)}, Err:scanner.ErrorList{(*scanner.Error)(0xc420183640)}}}}
                        (WNT): pkgtree.PackageTree{ImportRoot:"bad", Packages:map[string]pkgtree.PackageOrErr{"bad":pkgtree.PackageOrErr{P:pkgtree.Package{Name:"", ImportPath:"", CommentPath:"", Imports:[]string(nil), TestImports:[]string(nil)}, Err:scanner.ErrorList{(*scanner.Error)(0xc420182140)}}}}
FAIL
FAIL    github.com/golang/dep/gps/pkgtree       0.007s

% go version
go version devel +507f4d5 Fri May 5 01:00:11 2017 +0000 linux/amd64

yeah ty - i just noticed this, and am super-confused about how it snuck by our CI

good point
I know we had to work on other tests in this package to get gps into dep.. hrmmm 🤔
Is this intermittent or constant? Just curious 😁

Ah just kidding - Sam already found it 😁

it's still super, super weird that it made it past CI, as this was a consistent error owing to...ugh...a super brittle test that got cranky when the license header changed file offsets. it should've been complaining immediately.
makes me not trust travis. 😢

makes me not trust travis.

The test passes because the test sets an environment variable to skip the
test
https://travis-ci.org/golang/dep
On Fri, May 5, 2017 at 2:28 PM, sam boyer<EMAIL_ADDRESS>wrote:

it's still super, super weird that it made it past CI, as this was a
consistent error owing to...ugh...a super brittle test that got cranky when
the license header changed file offsets. it should've been complaining
immediately.
makes me not trust travis. 😢
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/issues/520#issuecomment-299371102, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA_0E4tgeKl8ys1gaykjDGVHrWFTnks5r2qWCgaJpZM4NRaeJ
.

...lol, it was right in front of me and i didn't read it. maybe it's time to go to sleep 😄


[Docs] Broken Links in MeshMap Documentation

Current State
In the MeshMap documentation's introduction, there are two links provided for "Designer" and "Visualizer." Unfortunately, these links do not redirect to any valid destinations. The documentation page where this issue is observed can be found here: https://docs.meshery.io/extensions/meshmap
Desired State
To resolve this issue, we need to update the links in the documentation to direct users to the respective "Designer" and "Visualizer" sections of the Layer website.
I would like to work on this issue if it is considered valid and within the scope of improvements needed for MeshMap documentation.

Contributor Guides and Handbook

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

hey @ATREAY  can i work on it

hey @saurabh100ni, can I work on this issue if it is valid?

Go On @ATREAY 😎🚀

Hey @saurabh100ni, I've made the neccessary updates. Could you kindly review them when you have a moment?


Multi-caret selection: provide additional info

Suggestion:
In the "Muti-caret selection", could we add the commands related to the keyboards shortcuts as well? In this case:
Edit.LineUpExtendColumn (add caret up)
Edit.LineDownExtendColumn (add caret down)

I had them unmapped for years and I guess they sync'd via my Microsoft account when I logged into VS 2022, so I had no idea what these shortcuts were referencing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b328a871-7747-31d6-737c-4e3f6d10d9d1
Version Independent ID: 2b455842-a4ef-25bd-c386-f36e0d14ce3d
Content: Find and replace text, and multi-caret selection - Visual Studio (Windows)
Content Source: docs/ide/finding-and-replacing-text.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@dubeg Thanks for your feedback; we'll look in to adding this info as soon as we can (and we'll report back after we do).

@dubeg Thanks for taking the time to provide us with your feedback; we appreciate it. We've added a "Commands" sub-section to the "Multi-caret selection" section of the Find and replace text page, which includes the information you requested. We'll close this issue now, with our thanks to you for helping to improve the documentation!


fix: create index for pod annotation path for allowkubernetessync annotation instead of deployment

Fixes: #579

Can we add some kind of test for this? e2e or otherwise?

Can we add some kind of test for this? e2e or otherwise?
Another question I have is that wrote response {"webhook": "/mutate-v1-pod", "code": 200, "reason": "OpenFeature is disabled", "UID": "8f021e26-6d9b-47f2-90f2-588236ec388d", "allowed": true} (meaning the openfeature/enabled annotation isn't found) is also reported in the issue. Is that related or is that a totally different issue (I think it's different)? Note my comment here.

Hey, to be honest I don't know. On one side, if the OF is disabled, the mutating webhook should never kick in and therefore we should not have any problems with backfilling the permissions. Here we have both, maybe Adam can give us more context here? One theory might be that during the rollout, there was a certain time, where the namespace was created, but not annotated for OF yet. There we might see this warning (OF disabled). After it's annotated, we saw the errors from mutating webhook. Just thinking out loud... WDYT?


[cluster-agent] Fix CWS Instrumentation metrics

What does this PR do?

This PR fixes the metrics generated for CWS Instrumentation. Instead of using a counter that will grow forever, a distribution will better fit our monitoring use case.
Motivation

This fixes our visibility on the kubectl cp instrumentation feature added in this PR.

/merge


Adds dicttoxml to lazy requirements instead of main requirements

Handling https://github.com/scrapinghub/exporters/issues/306

Hm, the import in compression.py should be changed to be dynamic too, replacing the hardcoded with something like this at the end of the file:
try:
    from bz2file import BZ2File
except ImportError:
    pass
else:
    FILE_COMPRESSION['bz2'] = lambda path: BZ2File(path, 'a')

Right. Will do it.

Btw, tip: if you put "close #ISSUE_ID" in the PR title, it will close the issue automatically when merged :)

@bbotella kinda miss nitpicking your PRs! :laughing:

Neat, will merge when build finishes!
Thanks @bbotella ! :heart:


Add LICENCE to Releases

The next releases should have the LICENSE in it. Maybe also the README.

Just read it: "Leun4m" instead of "leun4m"...


Lightning + DDP + apex.amp fails to initialize

🐛 Bug
Runtime error when using DDP with apex.amp.
To Reproduce
Replace with
    trainer = pl.Trainer(
        max_epochs=1,
        gpus=1,
        num_nodes=1,
        accelerator='ddp',
        amp_backend='apex',
        amp_level='O3',
        precision=16,
        progress_bar_refresh_rate=20
    )

And export Boring Model as .py to your machine with apex installed.
The initialization of apex.amp lies at  https://github.com/PyTorchLightning/pytorch-lightning/blob/e272bea4dcf679d15ab836310c82193641e79778/pytorch_lightning/plugins/precision/apex_amp.py#L41, called at https://github.com/PyTorchLightning/pytorch-lightning/blob/e272bea4dcf679d15ab836310c82193641e79778/pytorch_lightning/trainer/trainer.py#L440 . However, the initialization of apex.amp requires the model to be at GPU side, where the transition https://github.com/PyTorchLightning/pytorch-lightning/blob/e272bea4dcf679d15ab836310c82193641e79778/pytorch_lightning/plugins/training_type/ddp.py#L272
called at https://github.com/PyTorchLightning/pytorch-lightning/blob/e272bea4dcf679d15ab836310c82193641e79778/pytorch_lightning/trainer/trainer.py#L481 happens after init. Thus, the if-statement https://github.com/PyTorchLightning/pytorch-lightning/blob/e272bea4dcf679d15ab836310c82193641e79778/pytorch_lightning/plugins/precision/apex_amp.py#L50 ignores to performing apex configuration.

Or... apex backend is not supported any more?

Dear @caic99,
Apex should still be supported, but slowly being depreciated in several libraries such as Horovod.
I will look into this one.
Best,
T.C


fix: correct mismatch of time until live auction

The type of this PR is: BugFix

This PR resolves PURCHASE-2621
Description

This PR addresses a bug that resulted in the start time of a live auction being display in two different ways in the Auctions view and the Individual Auctions view.

Both views now show the time until auction in hours, when less than 24, and the individual auction page also includes the minutes until auction to be more precise.
Phone 8

Pixel 2

In addition to providing more information to the user, this addresses an issue cause by how we handle time calculation on the client vs the server. More detail in this slack thread.
For future consideration
We should consider unifying how we handle time calculations between the client and server, as it is likely we will continue to run into bugs following the current approach.
PR Checklist (tick all before merging)

[ x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ x] I have tested my changes on iOS and Android.
[ x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ x] I have documented any follow-up work that this PR will require, or it does not require any.
[ x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ x] I have added a CHANGELOG.yml entry or my changes do not require one.

Looks good here but I'd like to confirm with design (cc @ArvindLall ) that we are okay with showing this more fine-grained timing, as adding minutes might cause confusion when the screen doesn't update automatically.

Thanks @erikdstock! Ran it by him in the Jira ticket and he was on board. But @ArvindLall of course feel free to let me know if any additional thoughts have come up.


Expand on Explicit Valence Error - Partial Sanitization recipe

Reference Issue

What does this implement/fix? Explain your changes.
Adds molecular structures for the unsanitized and partially-sanitized iterations. Explains that setting the hybridization is key to making a reasonable molecule in this case.
Any other comments?

I fixed the test failures. It was doctests. I'd run the code locally in a Jupyter Notebook, which outputs the last expression in a cell. So I needed to copy the code into a regular .py file and print the outputs.


fix: capabilities sintaxis based on libcap version

Workaround for libcap sintax changes: https://github.com/ansible/ansible/issues/72662

After review, merge and release, we'll need to release a new version of backups_role, changing this line, and then update backups_role version on odoo-provisioning.


Allow route paths to be customized

By default when using pow_routes() the paths for all routes are generated such as:
/session/new
/registration/new

I'd like to be able to have my route paths defined as:
/sign_up
/sign_in

Is there currently a way to do this?

I think you can find an example for custom routes here: https://github.com/danschultzer/pow/blob/master/guides/custom_controllers.md

They can be overridden, the same way you would override routes normally in Phoenix:
defmodule MyAppWeb.Router do
  use MyAppWeb, :router
  use Pow.Phoenix.Router

  # ...

  scope "/", Pow.Phoenix, as: "pow" do
    get "/sign_up", RegistrationController, :new
    post "/sign_up", RegistrationController, :create
    get "/sign_in", SessionController, :new
    post "/sign_in", SessionController, :create
  end

  scope "/" do
    pow_routes()
  end

  # ...
end

thanks @danschultzer that is exactly what I was looking for.


Fix: PA unit test failure due to temporary object issue

This issue is caused here: https://github.com/triton-inference-server/client/pull/737/files#diff-e9c0b753b6e0449de174969db3d6aaf0db112a24b1a08d6703cdb12d8c006ff4R1124
The std::to_string(concurrency_range_start) creates a temporary std::string object. The call to .data() returns a const char* pointer to the internal buffer of this temporary object.
Since the std::string object is temporary, its destructor might be called immediately after the expression completes causing the pointer returned by .data() to be invalid.
This PR fixes this issue by storing the the the temporary string object of concurrency_range_start in a string variable and use it later to push into the args.

Some duplicates introduced in resolving merge conflicts. Fixing them.


Update build scripts to have additional tasks for OLM bundle generation

Describe the solution you'd like
Release workflows should include optionally executing necessary steps to generate an OLM bundle as a release asset.
The code-generator is capable of generating assets already: https://github.com/aws-controllers-k8s/code-generator/pull/22
The remaining automation probably looks like this:

Execute new generators ack-generate olm ...
Execute operatorSDK bundling workflows
Execute publishing of the bundle to a registry

Per previous discussion the first (1.) item makes sense to include in the release scripts (https://github.com/aws-controllers-k8s/community/blob/main/scripts/build-controller-release.sh). The challenge there would seem to be that the input service configuration for the olm generator is required, so if the developer hasn't prepared that ahead of time, such as in cases where someone is not interested in consuming the bundle assets for any reason, then the script would fail.
The second (2.) and third (3.) items feel like separate scripts, docs, or both. The second item requires operatorSDK be installed on the build machine. The third is relatively varied on how it gets done.
Let me know what you think!
Describe alternatives you've considered
These build steps were initially covered in the previously mentioned PR's original design which generated a partial Makefile (borrowed from OperatorSDK/Kubebuilder) that contained just the necessary bits for these steps. However, updating existing automation tooling definitely makes more sense.

Hi @jaypipes was this implemented? Apologies for the delays on my end (side tracked at the moment)

Hi @jaypipes was this implemented? Apologies for the delays on my end (side tracked at the moment)

Hi @komish! Sorry, I thought this was implemented with your patches to code-generator... I was mistaken. :) Re-opening!

@jaypipes No problem, thanks for re-opening! Still have this on my radar, just need to circle back to it. Should be able to do so in the next few weeks!


ClamAV: Stuck downloading signatures (first time)

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x ] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[x] The title contains the plugin to which this issue belongs

os-clamav (installed) | 1.8 | 47.7KiB | 3 | OPNsense
First time install, enabled as per docs. Clicked Download Signatures, waiting +2 hours with no sign of completion.

No log
Versions OPNsense 24.1.5_2-amd64
FreeBSD 13.2-RELEASE-p11
OpenSSL 3.0.13
Up to date
CPU type Intel(R) Celeron(R) N5100 @ 1.10GHz (4 cores, 4 threads)

I'd just like to add I have a similar problem. Its late here at the moment so I dont have much else to add other than im also running OPNsense 24.1.4
I also see no change to traffic, no downloads are happening. I havnt had the time yet to check for any logs that might give insight. I'll be looking for solutions to over the next few days so will reply If i find anything.

I do want to add, it appears that the signatures update but don't show up in the 'Signatures' tab. I can see the database update from the logs section. If someone with more familiarity with this could take a look that would be helpful.

I get the same situation too, no signatures in the tab. No error banner any more saying none found and the service is running it would seem. Also have the logs reporting database ok and up to date.

I get the same problem. just running a clean install of OPNsense 24.7.5 together with clamAV 1.8.
Banner for downloading signatures is shown but when clicking it, nothing happens.
When having a look at the system-logs I can see a recurring error in the "configd.py".

Script action stderr returned "b'/bin/sh: /usr/local/etc/rc.d/clamav-clamd: not found
returned exit status 127
Also on the dashborad the service can not be started.

Had the same issue and could fix it in CLI.

Download initial signatures

freshclam

Enable and start clamAV-daemon

/usr/local/etc/rc.d/clamav_clamd enabled
/usr/local/etc/rc.d/clamav_clamd start

Enable and start freshclam-daemon

/usr/local/etc/rc.d/clamav_freshclam enabled
/usr/local/etc/rc.d/clamav_freshclam start
Hope this helps.

Thank you @rosti1226!!

@rosti1226 Thanks, this is still broke. Fresh install, enabled ClamAV and Freshclam, but it just hangs.
Very bad UI experience with not showing what is going on.
Used the CLI via SSH to connect Shell. 8) Shell from the UI and followed @rosti1226.
Not sure why this issue isn't fixed, addressed and then auto closed out, as it's trivial and something in the plugins is broken.

Thanks @mimugmail and @fichtner!! 👍 💯


Log in

I would also like to voice my dislike of the mandatory  entry of your e-mail every log in. My organization already requires multi factor device log in so my log in process has become a long drawn out annoyance at this point. The process honestly does not even pander to safety, as the credentials are the same for my house account and O365. I feel like most organizations do that.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d23565fb-ccc9-42fc-6bde-f999d92fc762
Version Independent ID: 60c86bac-f951-8181-793b-34018f4a76ea
Content: Microsoft sign-in experience updates
Content Source: articles/multi-factor-authentication/end-user/sign-in-experience-updates.md
Service: multi-factor-authentication
GitHub Login: @eross-msft
Microsoft Alias: lizross

@biaalexzimm Please post this as a feedback @ https://feedback.azure.com/forums/169401-azure-active-directory. This will allow the community to upvote and for the product team to investigate and include into their plans.
We also have the "Give Product Feedback" button in our documents now to take you directly to the appropriate feedback page.

A similar feedback on new login experience has been provided at site, you can provide your comments or Upvote the same using this link.


Cannot set configuration variables to nil

When setting any configuration variable to nil as instructed from the helper doc: https://github.com/Olical/conjure/blob/2e7f449d06753f2996e186954e96afc60edd5862/doc/conjure.txt#L510
Then the configuration variable still gets overwritten with the default variable.
POC setup:
  use {
    'Olical/conjure',
    config = function()
      vim.g['conjure#completion#omnifunc'] = nil
      vim.g['conjure#client#clojure#nrepl#mapping#refresh_changed'] = nil
      vim.g['conjure#client#clojure#nrepl#mapping#refresh_all'] = nil
      vim.g['conjure#client#clojure#nrepl#mapping#refresh_clear'] = nil
    end
  }

Executing :lua print(vim.g['conjure#completion#omnifunc']) (or any other configuration set to nil per se above) results in ConjureOmnifunc (the relevant default value).
This is caused by the nil check here:
https://github.com/Olical/conjure/blob/2e7f449d06753f2996e186954e96afc60edd5862/fnl/conjure/config.fnl#L45
I believe having the option to unset some configuration values is crucial, because this would allow to remove any conflicting keybindings and in this example, leaving the omnifunc to the relevant lsp handler.

I suppose the only way to support nil configuration values is by supporting vim.NIL because lua treats nil the same as missing key according to this: https://neovim.io/doc/user/lua.html#vim.NIL

So the way I've got around this so far is to set things you don't want (omnifunc, mappings) to v:false instead of nil etc, I admit the docs in :h conjure said nil for omnifunc which is incorrect, I've just fixed that.
The mappings however do say you should use v:false although it is burided in :h conjure which isn't super clear. Supporting v:nil across the board will be a little tricky but possible. Your PR is maybe a solution although it involves a single pass at startup to transform vim.NIL (a truthy value!) into nil (a falsy value!).
That single pass at startup and reliance on it to transform the value will maybe cause weird issues for people down the line where they thing v:null works but then if they set it too late suddenly Conjure will enable things they thought were disabled because vim.NULL is true in Lua.
So I'd like to avoid that transform is possible by discouraging people from using v:null at all and instead using v:false which IS falsy in Lua by default because it's converted to the lua false value. It is also possible to store a false inside a table where a nil isn't.
So, my answer is: I think we should stick to recommending and using v:false to signify "turn this off" for now for mappings and omnicompletion etc. I've updated the help text on omnicomplete to recommend v:false too.

Thank you, setting my options to v:false seems to work fine for now.
I still believe that false is not a semantically correct representation for unset config variables and is somewhat confusing, although explicitly specifying it in the documentation kinda helps a bit.
You can close this for now (along with its respective PR) if you have no further plans for allowing that kind of transformations.
PS. Thank you for this amazing plugin!

I do agree it's not semantically correct but for my purposes it's "good enough". I mostly like it because v:false becomes lua false which is... falsey... so it works great in conditionals where I check for config.
I will consider moving support to v:null at some point, but it'll be work across the board to make sure all code handles that case. Because v:null becomes a truethy value in lua which will break a LOT of if statements. I'll need to make sure I catch every one or risk introducing quite a few bugs.
For now though, I'll close this but keep the change in mind, I agree it's right, just time and there's bigger things to fix at the moment 😄 thank you for the investigation, work and suggestion!


[BUG] Issuer is Now Required at Runtime But Not During Type Checking

To Reproduce
I adjusted the "get Urls" test from the samlTests.spec.ts file to omit the issuer (mimicking our app's previous setup), and got a runtime error of "issuer is required" when it was run
diff --git a/test/samlTests.spec.ts b/test/samlTests.spec.ts
index 815691b..0fed2df 100644
--- a/test/samlTests.spec.ts
+++ b/test/samlTests.spec.ts
@@ -17,7 +17,7 @@ describe("SAML.js", function () {
         entryPoint: "https://exampleidp.com/path?key=value",
         logoutUrl: "https://exampleidp.com/path?key=value",
         cert: FAKE_CERT,
-        issuer: "onesaml_login",
+        // issuer: "onesaml_login",
       });
       req = {
         protocol: "https",

1) SAML.js
       get Urls
         "before each" hook for "calls callback with original query string":
     TypeError: issuer is required
      at assertRequired (src/utility.ts:2:667)
      at SAML.initialize (src/saml.ts:2:4711)
      at new SAML (src/saml.ts:2:4242)
      at Context.<anonymous> (test/samlTests.spec.ts:16:14)
      at processImmediate (internal/timers.js:464:21)

Expected behavior
The TSC should've have failed beforehand when checking types instead
Environment

Node.js version: v14.19.0
node-saml version: Tip of master branch - commit SHA: abfb20d668b148f63e4acf8892f87853e3a9c168

This is addressing gaps in #61


Is there a default timeout for sheets.spreadsheets.values.append ?

Is there some default timeout for calling Google Spreadsheets API v4 using Nodejs? Particualrly, method sheets.spreadsheets.values.append.
It seems like occasionaly it just hangs forever (very rare, but still).

@bloodcarter Hope this link helps
https://developers.google.com/apps-script/guides/services/quotas

why would it hang forever it you reach the quota?

+1

@bloodcarter Hope this link helps
https://developers.google.com/apps-script/guides/services/quotas

This is completely irrelevant to the OP's question. There is no timeout argument to pass so when the google API hangs it will hang forever.


refactor(svg-icons): align svg-icons naming with font icons naming

BREAKING CHANGE: some svg-icons were renamed

```info.svg -> info-circle.svg```
    ```msg-error.svg -> error.svg```
```msg-info.svg -> info.svg```
```msg-neutral.svg -> neutral.svg```
```msg-success.svg -> success.svg```
```msg-warning.svg -> warning.svg```

The downside from this is that the msg- icons were kind of a family, and it's easy to know that those are the ones to use for messages

@gabrielhl Yep that's true but they can also be used outside the message component. Another reason for this change is to align font icons and dc-icon classes with the provided svg files. Check the 2.0.0 alpha section in the changelog.

@dami-gg any update on that one?

worked like charm You can merge it from my point of view


The isnan method doesn't work on Numpy arrays with non-numeric

My DataFrame has a column with list type, but the value is None,  when I use:
tools: list = None
df=pd.Series(
            [
                tools
            ],
            index=[
                "tools"
            ],
        )
PandasCodec.encode_request(df, use_bytes=False)

Always found this errors if mlserver >= 1.4.0:
TypeError: ufunc 'isnan' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

I found the code:
https://github.com/SeldonIO/MLServer/blob/release/1.4.0/mlserver/codecs/numpy.py#L108
How can I make it work correctly on versions above 1.4.0?

Hi @baifachuan -- Thanks for bringing this up. I can see the kind of error you are getting and I can also replicate it locally. I am having difficulties understanding your use case though, would you please describe what you are trying to do?

Hi @baifachuan -- Thanks for bringing this up. I can see the kind of error you are getting and I can also replicate it locally. I am having difficulties understanding your use case though, would you please describe what you are trying to do?

Hi @ramonpzg thanks for your replay, I deployed a locally privatized large language model (LLM) through Seldon.
These parameters need to be passed to Seldon when chat with LLM.
df=pd.Series(
            [
                tools
            ],
            index=[
                "tools"
            ],
        )

df is the  chat parameters,  because tools is LLM TOOL list, So they definitely won't be of a numerical type.

Is there any update regarding that bug? I am experiencing the same issue. This problem occurs as soon as there is an attempt to pass any non-numeric values. For instance, I have a dfthat contains text values, some of which can be None. A fix would be to check for float values in mlserver/codecs/numpy.py row 109: if isinstance(val, float) and np.isnan(val)


Revert "Add emit extension block symbols option to dump-symbol-graph and SymbolGraphOptions"

Reverts apple/swift-package-manager#5892
Breaks the windows build due to missing dependencies.

@swift-ci please test

@swift-ci please smoke test

Sorry, missed that the Windows build wasn't triggered on the original PR, I only looked at the overall "green" status.

FYI @theMomax


jdt-language-server

Update to latest release.
Call preInstall and postInstall hooks from installPhase to make customizing the derivation easier.

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@britter There is already PR #279285 which was just merged so I think this should be closed unless you want to update it to just add the install hooks

@matt-snider it doesn't touch the update script? This branch just needs rebasing due to the conflict.

@matt-snider I think it makes sense to add the hooks. But I will create a new PR for that. Thanks!


MM-66 added endpoint for adjust poll_rate

Created POST /api/polling_rate that takes polling_rate and adjust the applications current polling rate

looked good to me


Add toggleable attributes to window queries

zoom-fullscreen, zoom-parent, border, sticky, split should all be in yabai -m query --windows.
Related: #83

Fixed on master.

The value for the split key is not a quoted string causing jq to have a parse error
{ 	"id":2268, 	"pid":6156, 	"app":"Hyper", 	"title":"Hyper", 	"frame":{ 		"x":24.0000, 		"y":24.0000, 		"w":1632.0000, 		"h":1002.0000 	}, 	"level":"0", 	"role":"AXWindow", 	"subrole":"AXStandardWindow", 	"movable":1, 	"resizable":1, 	"split":horizontal, 	"floating":0, 	"sticky":0, 	"border":1, 	"zoom-parent":1, 	"zoom-fullscreen":1, 	"native-fullscreen":0 }
yabai -m query --windows --window | jq .   parse error: Invalid numeric literal at line 17, column 20

Well that was a brilliant mistake - fixed and did a new release.


Offer set affiliate status

fix mistyping in unblockAffiliate method
add Offer::setAffiliateApproval method

guys, any response here?:)

👍
@antlypls wdyt?

👍 let's merge and bump minor version?

@miry @antlypls @psychocandy thanks 🎉


padding the pedestrian image using black pixels and changing the resolution to 224 × 224

where was the code?

in AttrDataset.py


Move logging namespace to Logger static class, faster ShouldLog() check, LoggingPolicyOptions with allow-lists

This takes the API review feedback, and I reviewed the design with Jeffrey, took his feedback.
Closes #1639.
Closes #1722.

Created Logger class, moved the public contents of Azure::Core::Logging there.
Logger now uses std::shared_timed_mutex, which is more effective than the plain std::mutex in our case. Atomic is not possible with std::function, and we do want to use std::function, Jeffrey agrees.
Created LoggingPolicyOptions, which has 3 whitelists for request and response headers, and for query parameters, in response to API review feedback. Use them in the code to not output anything that is not there.
Added CaseInsensitiveSet, which is used in LoggingPolicyOptions.
RetryPolicy stores retry codes in std::set instead of std::vector.

Tweak logging

Please update the PR title to be more descriptive with the details of the change and intent of the PR

I'm looking for naming consistency. If we have a log policy with log options and a log class for setting listeners/level. Or, a logging policy, with logging options, and a logging class. Or, a logger policy with logger options and a logger class.
Consistent naming helps the user understand that there's a relationship between all these things.
This is why I also don't like having both a log class and a logger class.
• Jeffrey Richter (see Architecting Distributed Cloud Appshttp://aka.ms/RichterCloudApps & Designing HTTP APIshttps://www.youtube.com/watch?v=9Ng00IlBCtw&list=PL9XzOCngAkqs4m0XdULJu_78nM3Ok3Q65&index=1)

From: Ahson Khan<EMAIL_ADDRESS>Sent: Wednesday, March 3, 2021 11:11:19 AM
To: Azure/azure-sdk-for-cpp<EMAIL_ADDRESS>Cc: Jeffrey Richter<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-cpp] Move logging namespace to Logger static class, faster ShouldLog() check, LoggingPolicyOptions with allow-lists (#1752)
@ahsonkhan commented on this pull request.

In sdk/core/azure-core/inc/azure/core/http/policy.hpphttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-cpp%2Fpull%2F1752%23discussion_r586781301&data=04|01||fa2e7323198a48fce29408d8de88e3dd|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637504026799863927|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=CV07hTXB6Ln3jrA1wegaOaHdKbsUXKS6ycQSK7tKq0c%3D&reserved=0:

/**
* @brief Logs every HTTP request.
*

@details Logs every HTTP request, response, or retry attempt.

@remark See #logging.hpp

@details Logs every HTTP request and response.

@remark See Azure::Core::Logger.
*/
class LoggingPolicy : public HttpPolicy {

Why do we prefer the name LogPolicy over LoggingPolicy?
.Net: LoggingPolicyhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-net%2Fblob%2F49d9b2c3be3d48fc6d8f7044ae74c20c2cfc34c0%2Fsdk%2Fcore%2FAzure.Core%2Fsrc%2FPipeline%2FInternal%2FLoggingPolicy.cs%23L16&data=04|01||fa2e7323198a48fce29408d8de88e3dd|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637504026799863927|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=g%2FvRl%2FFyeaIioKq38flR9518ndJDLMoxNsnQ2hB4AH0%3D&reserved=0
Java: HttpLoggingPolicyhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-java%2Fblob%2Fd7bcc73f3866dbfb007a6ae8512b1fb01ac58ada%2Fsdk%2Fcore%2Fazure-core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fazure%2Fcore%2Fhttp%2Fpolicy%2FHttpLoggingPolicy.java%23L39&data=04|01||fa2e7323198a48fce29408d8de88e3dd|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637504026799873889|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2FmQr2lIvpon4fKCqriyLPj76BDqgTjuAZ2IXj8W281Q%3D&reserved=0
Python: HttpLoggingPolicyhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Fblob%2F4f1c4a7bff4cf9a50f5d882e1f8adf8663adcadb%2Fsdk%2Fcore%2Fazure-core%2Fazure%2Fcore%2Fpipeline%2Fpolicies%2F_universal.py%23L347&data=04|01||fa2e7323198a48fce29408d8de88e3dd|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637504026799873889|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=MxckieUTgmuuWkZDZhgpKi6UuIF3YC4MwOgZs9ztKKw%3D&reserved=0
JS: LogPolicyhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-js%2Fblob%2F50c5a5447454c2ae1d2b4fa5b02470671f41dd77%2Fsdk%2Fcore%2Fcore-http%2Fsrc%2Fpolicies%2FlogPolicy.ts%23L45&data=04|01||fa2e7323198a48fce29408d8de88e3dd|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637504026799883839|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=zQ%2FwGLyAclmuOIx2JWOiChsE9A9U%2FLLm7Ng1mEOpIg4%3D&reserved=0
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-cpp%2Fpull%2F1752%23discussion_r586781301&data=04|01||fa2e7323198a48fce29408d8de88e3dd|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637504026799883839|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=NG9Yb0cwXifWPeUEzriydVcApMr9aDAazif0MvC1W1Y%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARLJPYB3NYV42MEUF7O3TTTB2QXPANCNFSM4YJFQYWQ&data=04|01||fa2e7323198a48fce29408d8de88e3dd|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637504026799883839|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ZQpmZz5ZOXyptVE2lI2gIv7yzR1xRETOi0tr2p%2FxSpQ%3D&reserved=0.

Per agreement with the team, merging together all the API review changes otherwise extractable to several PRs, to win us time on namespace/file moving changes. If there's any unaddressed feedback left, will be fixed in subsequent PRs. I addressed all the feedback that I took to my best knowledge, if something is not reflected in the code changes, I'll reply with the comment mentioning the fix was not taken intentionally.


errors_cause for JSON API error encoding

Closes #13123.
Ping @nobuti when this is closed, as he's blocked by this.

@nobuti, this has just been merged into master. cc @elenatorro


math/big: implement recursive division algorithm

math/big currently only has an implementation of "schoolbook" long division which is O(n^2).  An implementation of Burnikel and Ziegler's Fast Recursive Division (1998) would improve division's asymptotic complexity to the multiplication time.  The multiplication asymptotic complexity is currently ~n^1.6 for the karatsuba implementation, but could be improved with other algorithms in the future and recursive division would automatically benefit.
Note, The Handbook of Elliptic and Hyperelliptic Cryptography Algorithm 10.35 on page 188 has a more explicit version of the div2NxN algorithm.  This algorithm is directly recursive and avoids the mutual recursion of the original paper's calls between div2NxN and div3Nx2N.  Algorithm 10.35 along with the Burnikel and Ziegler's handling of unbalanced division in blocks of 2NxN "digits" seems like the best candidate for implementation.
In addition to speeding up division in general, this will improve String output #20906 which relies on repeated large divisions.

CC @griesemer

Note: Burnikel and Ziegler's Fast Recursive Division is also an ingredient of the Karatsuba Square Root algorithm [1], which is the method gmp and mpfr use for computing square roots. It should be faster than the Newton approach currently used in Float.Sqrt.
[1] Paul Zimmermann. Karatsuba Square Root. [Research Report] RR-3805, INRIA. 1999, pp.8.


how does this work?

how does this work?

Hey Ray! Right now this doesn't work! Eventually the goal of this project is to become a CLI tool to allow users to easily create and manage a Johnny Decimal filesystem from their terminal. The Johnny Decimal system is outlined here: https://johnnydecimal.com/
It's a simple yet powerful way to organize both digital and physical file systems. Ideally this CLI tool will be a lightweight wrapper that allows people to create, remove, rename, etc all the necessary files or directories needed for a JD system.  The repo currently has the general scaffold of commands that I hope to implement. Any PR's are more than welcome!

I think his point was "could you write a readme, so that we know the ideas you had behind this and can more easily submit a PR?" :)


Lk86/spot vm integration develop

This is the same as #12076, to allow integration tests to pass, this time against develop.

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me


Fix #1996- add study-wide average for data entry lag

Overview

Added some text under the Outstanding Data Entry KRI to specify the study-level average for data entry lag (in days) as well as a study-level average of the data entry lag for those that were flagged as >= 10 days of lag. This is related to a request from Jenn. Will run it by her to confirm this is what she wanted prior to merging in.
Test Notes/Sample Code

Connected Issues

Closes #1996

I think i need to add the site-level average(s) to the tooltip so we can compare more directly.


Uncaught Exception: Attempting to call a function in a renderer window that has been closed or released. Function provid

An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.0.1
Time: Wed Mar 23 2016 11:30:32 GMT 0700 (SE Asia Standard Time)
Error:
Attempting to call a function in a renderer window that has been closed or released. Function provid
Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: Object.<anonymous> (C:\Users\kientrungnguyen\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\inject\GPMInject\interface\mouseButtonNavigation.js:8:8.
    at BrowserWindow.callIntoRenderer (C:\Users\kientrungnguyen\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\lib\rpc-server.js:201:19)
    at emitTwo (events.js:92:20)
    at BrowserWindow.emit (events.js:172:7)
    at EventEmitter.<anonymous> (C:\Users\kientrungnguyen\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\main\features\core\controlBar.js:12:45)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)
    at EventEmitter.<anonymous> (C:\Users\kientrungnguyen\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\api\lib\web-contents.js:134:25)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)

This issue was created automatically inside the uncaughtException handler

Closing this automatically reported issue as a duplicate of #470


Delete item with relationships: configure defaults

This includes support for the configuration part of https://github.com/DSpace/Rest7Contract/pull/78
This replaces https://github.com/DSpace/DSpace/pull/2588

@benbosman do you think the default [/dspace]/config/entities/relationships.xml should be added in this PR since some of the changes are related with that?

Thanks @paulo-graca for your feedback, we'll update the branch based on these useful improvements.

The name has been updated from copyLeft to copyToLeft (and similar for right)
The dspace-api/src/test/data/dspaceFolder/config/entities/relationship-types.xml has been updated with some sample defaults, but the default [/dspace]/config/entities/relationships.xml will be part of a separate PR as discussed in the last meeting
We also noticed a small issue in RelationshipServiceImpl.java concerning the place to maintain which has been solved and a test has been created to verify this fix

@paulo-graca if you have some time left, this could use a quick re-review
Your feedback was processed and Tim has approved it already

Thanks for the 2 approvals, merging this PR


Add raw-loader to fix "unexpected character" error

As per the Phaser 3 boilerplate, we need to include raw-loader to fix those pesky "Unexpected Character" errors.

I appreciate the PR! I think though that this issue was resolved by removing the yarn.lock file from the project. Take a look at the discussion here: https://github.com/snowbillr/phaser3-webpack-es6-dev-starter/pull/1.


"Invalid state ref" error if uiSref has whitespaces around (ng1)

These don't work:
My fancy link
Another fancy link

This works:
My fancy link

This is an ng1 version issue, don't know if is also an ng2 issue too.
Possible solution:
Add \s* at beginning/end of main regexp in parseStateRef function, in file /src/ng1/directives/stateDirectives.ts, like so:
parsed = ref.replace(/\n/g, " ").match(/^\s*([^(]+?)\s*(\((.*)\))?\s*$/);

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Why would you have those spaces around it?

Because this is not legible ...
My fancy link

... but this is

    My fancy link

I know, there are other workaround, this is a simple example, but, why would a bug not be fixed?

This error is also thrown in IE9 when there are line breaks or too many spaces between parameters passed to a state in an ui-sref. The only solution I've found is to put the ui-sref and its contents all on the same line. It's extremely inconvenient to read though.

Please PR the solution :)


scripts/dts: Fix issue in label generation of registers

If we have something like:
   #address-cells = <1>;
   #size-cells = <0>;

   intc: ioapic@fec00000  {
       compatible = "intel,ioapic";
       reg = <0xfec00000 0x100000>;
   };

We should generate:
DT_INTEL_IOAPIC_FEC00000_BASE_ADDRESS_0
DT_INTEL_IOAPIC_FEC00000_BASE_ADDRESS_1
Instead we generated:
DT_INTEL_IOAPIC_FEC00000_BASE_ADDRESS
DT_INTEL_IOAPIC_FEC00000_BASE_ADDRESS_1
This was due to logic deciding if '_0' should be used not taking into
account #address-cells & #size-cells correctly.
Fixes: #16296
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Depends on PR #16299 to get merged first or builds will break.


Issue with regex in "nested" in-line short-cut

NOTE: I'm unable to provide a complete standalone project that will exhibit this issue due to confidentiality concerns. I will attempt to be as thorough as I can be with code snippets.
Problem
The regex expression contained in a "nested" in-line short-cut fails to match on a "date" when used in conjunction with a scenario outline containing more then 1 example.
Code Snippet
Scenario Outline: testing regex 'nested' with outline +
* def meta = { created: '#regex [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{2,}Z', modified: '#regex [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{2,}Z' }
Given path <a_private_path_I_cant_give_you> + ''
When method GET
Then status 200
* match each response == { id: '#regex [a-z0-9]+', name: '#string', type: '', meta: #(meta), integration_id: '#uuid' }
Examples:
| Type |
| accessProfile |
| account |
Notes

Having only 1 entry in the Outline/Examples table, the regex(s) match
Adding a 2nd entry in the Outline/Examples table, the 1st regex match fails trying to match on the created: key with an error like:
path: $[18].meta.created, actual: '2015-08-20T21:08:25Z', expected: '#regex [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{2,}Z', reason: regex match failed
If the created: key is modified to be created: #ignore, instead of being a #regex, the 2nd regex on modified: works as expected, regardless of the number of entries in the Outline/Examples table. Ex:
* def meta = { created: '#ignore', modified: '#regex [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{2,}Z' }
Ignoring the 2nd regex on modified:, but keeping the #regex on the created: key, the match still fails (when there are > 1 entries in the Outline/Examples table). Ex:
* def meta = { created: '#regex [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{2,}Z', modified: '#ignore' }

Example Response Data
For path: <a_private_path_I_cant_give_you> + '<Type>', where '<Type>' comes from Outline/Examples table:
response = [{ "id": "2c9180835aec6751015afb8695fe05dc", "name": "Bhushan Burujwale All", "type": "accessProfile", "meta": { "created": "2017-03-23T14:16:25.854Z", "modified": "2018-06-21T05:38:37.978Z" }, "integration_id": "269090ee-3ccf-48c6-bb0b-8c2cc6fcc7fa" } ]
For each <Type>, the response data is similar where the value of the "type" key will reflect <Type>

I'm closing this issue as "user error". Upon further digging I found that my response data was returning varying 'date' formats that sometime includes the milliseconds and other times does not (older data). I needed to further refine my #regex pattern being used for matching the created: key.
Thanks PT for all your assistance.


Ulrawide hero fix

Summary of changes
Fixes the issue with the hero image being cutoff on the top and bottom on ultra wide displays.
It does this by allowing the hero image to increase in height up to a certain limit (75% of the viewport).
The image still gets slightly cutoff on 2K ultra wide displays (3440 x 1440p) but significantly less than before. Even without the height limit the image doesn't fit within the viewport and users would have to scroll down to see the rest.
Here's a before and after example:
Before:

After

Frontend

Updated the graphql query for the hero image in useSpotlightData.js
Updated the global styles to add a height limit and fix an issue with the hero caption on some breakpoints.

[x] My changes are accessible (at minimum WCAG 2.0 Level AA)
[x] My changes are responsive and appear as expected on mobile and desktop views.
Backend
N/A
Test Plan

View the home page
Test the page at various breakpoints: mobile, desktop, laptop, ultra wide, etc.
Ensure the hero image isn't cutoff (or at least extremely cutoff) at all breakpoints.

I think we should have a team discussion about semi-colon usage before removing them.  In this case, can you convince me why we should remove them?

I always just use prettier to style my code. I believe we have it set to semi: false, not sure who set it to that but that's why they got removed.
Honestly I'd prefer we use them but I was just following the prettier config.
Maybe we should have a discuss to update the prettier config so it fits more inline with what everyone wants.

I believe we have it set to semi: false, not sure who set it to that but that's why they got removed.

If you're referring to https://github.com/ccswbs/doorknob/blob/main/.prettierrc I don't recall any discussion of its settings. It could be simply using defaults that no one ever bothered to examine or change.

Yeah looking at gus it seems to just be the default for the Gatsby starter template. https://github.com/ccswbs/gus/blob/9de75354658f88893c87de7345a6645153f5a434/.prettierrc


Update ru.coffee. personal_sub block

New lines, yay! :D
Also, someone please take attention about @differentmatt comment at line https://github.com/codecombat/codecombat/blob/af89452b930574042557dc163c266d68b3bd8dec/app/locale/en.coffee#L435 and how it was propaginated to ru.coffee

Ah, great work! I will reformat that comment to be more standard.


Fix getApplicationDefault to also return projectId.

@murgatroid99 PTAL

Coverage remained the same at 92.673% when pulling 0be5248ab02830df3c7c5a57c6523aa2e5963330 on jmdobry:fix-callback into 4a0b7fc0e409b2af5cc6d70aad0404a1e5205898 on google:master.

ping? @murgatroid99 @bjwatson

I'm not familiar enough with NodeJS to review this. @jmuk do you have a couple minutes to take a look?

Coverage remained the same at 92.673% when pulling 735d6e98657ec81432b5f0bfdb395fadb83b71d7 on jmdobry:fix-callback into 4a0b7fc0e409b2af5cc6d70aad0404a1e5205898 on google:master.

No I can't. I'm not a member either.
@jmdobry can you make both @jmuk and I members of this repo? @jmuk should probably also be an owner.

I can't, as I am not an admin, though @justinbeckwith and I have wanted to be for a while.

@murgatroid99 @ofrobots, are you admins?

Looks like I can merge. Should I try to release also? :)


Planck distribution is a geometric distribution

stats.planck is just a geometric distribution stats.geom with p = 1 - exp(-lambda). I am not aware that Planck distribution is a known name for it.
Currently, planck is incorrectly defined for negative lambda as well (see #9358).
Should planck be deprecated?

In the scipy docs, geom.pmf(k) = (1 - p) ^ (k - 1) * p and planck.pmf(k) = (1 - exp(-lambda)) * exp(-lambda * k) = (1 - (1  - exp(-lambda)) ^ ( k - 1) * (exp(-lambda)) * (1 - exp(-lambda)), so it's just not simple as p = 1 - exp(-lambda), so I think we shouldn't deprecated stats.planck. Thanks!

OK, but geom.pmf(k, 1-exp(-a)) == planck.pmf(k-1, a), so difference is a shift by one (which can be achieved with the parameter loc). Did i overlook sth?

Your second parameter is (1 - exp(-a)), but planck is more than geom with exp(-a), so it can not solve by shift by one.

Numerical "proof":
import numpy as np
from scipy.stats import planck, geom

a = 0.5
k = np.arange(20)
sum(abs(geom.pmf(k, 1-np.exp(-a)) - planck.pmf(k-1, a))) # 1.30e-18


Use native epoll transport if available

With this patch TChannel will use native epoll transport if it's available.

Fixed by 7c38efe.

already merged.


Error setting up clone project

Hello, I don't see any other requirements, yet I'm still being bogged down by errors on npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@sveltejs/adapter-static
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@sveltejs/kit
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@sveltejs/adapter-static
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

 But this time I ran npm update before install and it worked (despite it saying some vulnerabilities)


RAD-1176 Add docs for Prebid Native MVP

This PR adds 3 Prebid Native pages to the site:

ad ops setup instructions using DFP
developer setup instructions with explanations
developer example code (taken from Lane's native test page on his devbox)

All 3 are cross-linked among themselves and have links to DFP docs, other pages on the site, etc., as needed.

@mjacobsonny and @matthewlane, mind taking a look at this?  Comment above gives an overview of the PR.
To view, pull down this branch (RAD-1176) and view in your local Jekyll by running bundle exec jekyll serve - you may need to edit the port in _config.yml to something like 8080 on Mac.


remove unused 'rx' field from subcriber

the rx field is unused. I guess it was added to prevent the Sender::send method returning an error, but the result type is ignored anyway, so i don't think there's any reason to care if it does.

this is a non-breaking change