Add a number next to the editor node configuration warning icon

A small red number is present next to the node configuration icon warning when there is more than 1 warning.
The number is hard to read due to its small size, but its different color helps make nodes with multiple configuration warnings stand out from other nodes with only 1 warning.
It's very unlikely to have more than 5 warnings in a single node, so I only added icons for up to 5 node configuration warnings.
Preview
From 0 to 5 node configuration warnings:

Maybe the last one (after 5, 6+) should have an infinity sign to imply there can be more?

Maybe the last one (after 5, 6+) should have an infinity sign to imply there can be more?

Infinity sign might be difficult to do at a small size, but I guess I could replace the 5 with a "+" symbol.

I'm not sure how useful it is to actually get numbers 2 to 5 like this. Two states for "1 warning" and "multiple warnings" would be sufficient IMO.
The "multiple warnings" icon could be with a "+" symbol as suggested, or maybe with two warning symbols in front of each other. PoC for the latter (probably doesn't work so well on a 16x16 grid in the end):

Oh, I like that. I find it hard to read the number on the submitted icons, so unless there is a good reason to have counted variants, I'd go with that one.
If we want the exact number, better find a way to draw a badge on the Tree's cell.

Knowing the exact number of warnings is useful for my nodes with custom configurations warnings.

Knowing the exact number of warnings is useful for my nodes with custom configurations warnings.

You explained that in your case it was because you couldn't disable the default warnings, and added yours on top. So in that situation you would see a "double" icon when your warnings trigger alongside the built-in ones. The exact number of up to 5 is very arbitrary. And we can't render text on top of the icon. So I'd go with a more universal solution.

The exact number is still useful. For example one of my custom nodes requires a specific type of parent, its children to all be of a certain type, and another certain type of node to be a descendant exactly once. Even without the default config, seeing 1-3 helps here.
Ik it's not commonly helpful here, but everywhere else, warnings show how many there are. Consistency would be nice and IMO it'd be better to just resolve this now in a way that'd never get brought up again in the future.

Maybe we could use an unary numeral system instead of base 10 digits, I think that would be easier/faster to read.
So something along these lines:
(just a quick draft, the 4 dotted versions could be replaced by 3 combined with a plus symbol)

Or bigger: (and overlapped, although it looks like the lower circles are squished :/)

1/2 with a gradient:

How about an adding a number before the icon like this:

Maybe we could use an unary numeral system instead of base 10 digits, I think that would be easier/faster to read.

I like it, doesn't imply a specific number too much, especially the fading one, so can be used with any number above the supported minimum.

Having it like script warnings would be the best for consistency, but it takes more space.

I don't have much to add.  This can be improved to show the types of items in the tree like blender.

Remade to use @Geometror's dot icons. I went for the unique color so it looks easier to distinguish, even with only 2 warnings.

Rebased and tested again, it works as expected:

So I was wondering why build was failing with MSVC with a "file too large" error… it turns out the SVGs you sent here contain a lot of variations outside the viewport:

I guess we'll have a Godot cutting room floor one day… :eyes:

Thanks!


[FEATURE] AI Service: Add an option to register a custom OutputParser

Add an option to register a custom OutputParser when building AI Service.

Hello, are you thinking about something like that :
OutputParser outputParser = new MyOutputParser(); // my custom implementation
Assistant assistant = AiServices.builder(Assistant.class)
                .chatLanguageModel(model)
                .tools(tool)
                .outputParser(outputParser)
                .build();

Yes, we should think about how it should behave, when a custom OutputParser is provided (or even multiple?).
AI Service can also have multiple methods with different return types, so we should consider this as well.

Related: https://github.com/langchain4j/langchain4j/discussions/786

I'm thinking about making something like that :
interface Chat {

    @Moderate
    String chat(String text); // will use default parse() method

    @Output(MyCustomOutputParser.class) // will use a custom output parser
    Answer getAnswer(String question);
}


added strip option

This is from pngquant --help:
pngquant, 2.10.1 (July 2017), by Kornel Lesinski, Greg Roelofs.
Color profiles are supported via Little CMS. Using libpng 1.6.29.
usage:  pngquant [options] [ncolors] -- pngfile [pngfile ...]
pngquant [options] [ncolors] - >stdout <stdin
options:
--force           overwrite existing output files (synonym: -f)
--skip-if-larger  only save converted files if they're smaller than original
--output file     destination file path to use instead of --ext (synonym: -o)
--ext new.png     set custom suffix/extension for output filenames
--quality min-max don't save below min, use fewer colors below max (0-100)
--speed N         speed/quality trade-off. 1=slow, 3=default, 11=fast & rough
--nofs            disable Floyd-Steinberg dithering
--posterize N     output lower-precision color (e.g. for ARGB4444 output)
--strip           remove optional metadata (default on Mac)
--verbose         print status messages (synonym: -v)
I created pull request to update windows version of pngquant in pngquant-bin and it wuld be greate to add this option in imagemin-pngquant.

Yes! Just wasted 1h trying to understand why some PNGs were not getting compressed, it was because of huge metadata.
Actually 'strip' should be turned on by default (though there has to be a reason why the underlying pngquant lib has a different default on Mac than for anything else).


Some mods do not specify their dependencies

Example: Terralith, Forge 1.18.2, has a dependency (cristellib?) that is not specified in the metadata that is retrieved.

One solution would be to update the mods.json object to specify these and have a whole system for handling this.
A simpler solution would just be to add the mod to any layer requiring it.


Remove redundant detail in example

Removed redundant parts of Step 1 of the "Status quo" example. These details are explained in Step 3 and 4.

Thanks!


Array of objects is compared incorrectly by EqualToJsonPattern

Steps to reproduce:
Try to compare these two JSONs using EqualToJsonPattern, setting both ignoreArrayOrder and ignoreExtraElements to true.
Expected:
{
    "a": [
        {
            "b": 3
        }
    ]
}

Actual
{
    "a": [
        {
            "b": 0,
            "c": 1
        },
        {
            "b": 3,
            "c": 1
        }
    ]
}

Result: isExactMatch() returns false.
Expected result: isExactMatch() returns true.
This can be reproduced by adding the following method to the file EqualToJsonTest.java
    @Test
    public void similarObjetcsInAnArray() {
        assumeJava8OrHigher();

        String expected = "{\n" +
                "    \"a\": [\n" +
                "        {\n" +
                "            \"b\": 3\n" +
                "        }\n" +
                "    ]\n" +
                "}";

        String actual = "{\n" +
                "    \"a\": [\n" +
                "        {\n" +
                "            \"b\": 0,\n" +
                "            \"c\": 1\n" +
                "        },\n" +
                "        {\n" +
                "            \"b\": 3,\n" +
                "            \"c\": 1\n" +
                "        }\n" +
                "    ]\n" +
                "}";

        MatchResult match = new EqualToJsonPattern(expected, true, true).match(actual);
        assertThat(match.isExactMatch(), is(true));
    }

This is the diff object that is produced by zjsonpatch. As you can see there is a replace op in it, which is causing the issue. The same difference must be described as 2 add operations. I'm not sure whether this must be fixed in zjsonpatch or wiremock.
[
    {
        "op": "replace",
        "path": "/a/0/b",
        "value": 0
    },
    {
        "op": "add",
        "path": "/a/0/c",
        "value": 1
    },
    {
        "op": "add",
        "path": "/a/1",
        "value": {
            "b": 3,
            "c": 1
        }
    }
]

Are you using the jre8 JAR?

@tomakehurst Yes.

Are you sure? zjsonpatch isn't used in the jre8 JSON equality matcher.

When I run your test case in the JRE8 suite it passes. I only see it fail in JRE7, which is expected as it's still (and will forever be) dependent on zjsonpatch.

@tomakehurst I checked once again and you are right! The issue doesn't occur on the java8 version. Thanks for your quick response! I guess this issue can be closed now, unless you wish to fix it for java 7.

The Java7 version is going EOL soon, and it wouldn't be a simple fix as the library used for JSON equality in the jre8 version is Java 8+.


use spin_lock_wo_note replace spin_lock in csection

Summary
use spin_lock_wo_note replace spin_lock in csection
reason:
spin_lock_wo_note/spin_unlock_wo_note  should be called in matching pairs.
leave_critical_section use cpu_irqlock_clear which alse use spin_unlock_wo_note

in https://github.com/apache/nuttx/pull/13933
I overlooked some changes, resulting in a mismatch in spinlock calls
Impact
critical section
Testing
ci ostest

so, this is bug, right? please add some comments to describe the issue, rather than brushing it off lightly.
https://github.com/apache/nuttx/commit/17ca45e8a39b9c7e939568974592480fb2968dc1#diff-2286c811e8067df7f9b18d955e7a560c29ba15f8c8894faee39b86b22c9f5e3fR83

so, this is bug, right? please add some comments to describe the issue, rather than brushing it off lightly. 17ca45e#diff-2286c811e8067df7f9b18d955e7a560c29ba15f8c8894faee39b86b22c9f5e3fR83

ok


[SMALLFIX] Removed explicit type arguments in EvictorTestUtils

Removed some explicit type arguments in the EvictorTestUtils class.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9953/
Test PASSed.

Merged build finished. Test PASSed.

LGTM


[GOBBLIN-1581] Iterate over Sql ResultSet in Only the Forward Direction

after sql-connector was bumped, exception results from ResultSet.first() being called because it iterates in backward direction of set

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1581

Description

[X] Here are some details about my PR, including screenshots (if applicable):
after sql-connector was bumped, exception results from ResultSet.first() being called because it iterates in backward direction of set

can also be addressed by changing the prepare statement of every sql cmd that is executed
PreparedStatement pstmt = this.conn.prepareStatement(sql) ->
PreparedStatement pstmt = this.conn.prepareStatement(sql, ResultSet.TYPE_SCROLL_SENSITIVE, ResultSet.CONCUR_UPDATABLE)
Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Tested manually with snapshot and ingestion job

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@phet @arjun4084346 can you review?


Move alpha to predict and make corrections in tests, examples, and docs

Description

Move alpha parameter to predict argument and set default value to None
predict() now returns y_pred if alpha is None et a Tuple[y_pred, y_pis] otherwise
Adjust all tests, examples, and documentation accordingly
Add some tests to test default value of alpha parameter

Type of change
Please check options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
New tests
Checklist:

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : flake8 . --exclude=doc
[x] Typing passes successfully : mypy mapie examples --strict
[x] Unit tests pass successfully : pytest -vs --doctest-modules mapie
[x] Coverage is 100% : pytest -vs --doctest-modules --cov-branch --cov=mapie --pyargs mapie
[x] Documentation builds successfully : cd doc; make clean; make html

Hello @vtaquet! Thanks for opening this PR.

In the file mapie/estimators.py:

Line 290:13: W503 line break before binary operator
Line 291:13: W503 line break before binary operator

Do see the Hitchhiker's guide to code style


Error after updating server to Java 16

[02:14:31 ERROR]: Error occurred while enabling AntiVPN v6.4.13 (Is it up to date?)
java.lang.NullPointerException: Cannot invoke "me.egg82.antivpn.AntiVPN.onEnable()" because "this.concrete" is null
at me.egg82.antivpn.BukkitBootstrap.onEnable(BukkitBootstrap.java:93) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:501) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:415) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:581) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:283) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1057) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:290) ~[patched_1.16.5.jar:git-Airplane-"f5fb024"]
at java.lang.Thread.run(Thread.java:831) [?:?]
[02:14:31 INFO]: [AntiVPN] Disabling AntiVPN v6.4.13

Requesting PR for fixing this - can still use the same library and go the LuckPerms route of having the API and an injector in the plugin jar.

Note, this is a slightly old version of the plugin - can you please reproduce with this https://jenkins.egg82.me/job/egg82/job/Anti-VPN/job/master/54/
and re-send the error log?

For posterity, here's one copy of the error on 7.0.0, from discord

the same for me with the latest dev build...

[13:45:07] [Server thread/INFO]: [Anti-VPN] Loading Anti-VPN v7.0.0
[13:45:09] [ForkJoinPool-2-worker-7/INFO]: Downloading IP Address
[13:45:09] [ForkJoinPool-2-worker-5/INFO]: Downloading Caffeine
[13:45:09] [ForkJoinPool-2-worker-1/INFO]: Downloading H2
[13:45:09] [ForkJoinPool-2-worker-3/INFO]: Downloading Zstd
[13:45:13] [ForkJoinPool-2-worker-7/INFO]: Downloading RabbitMQ
[13:45:14] [ForkJoinPool-2-worker-1/INFO]: Downloading FastUtil
[13:45:15] [ForkJoinPool-2-worker-5/INFO]: Downloading Ebean Core
[13:45:16] [ForkJoinPool-2-worker-3/INFO]: Downloading Javassist
[13:45:17] [ForkJoinPool-2-worker-7/INFO]: Downloading PostgreSQL
[13:45:20] [ForkJoinPool-2-worker-3/INFO]: Downloading Jedis
[13:45:27] [Server thread/ERROR]: [me.egg82.antivpn.BukkitBootstrap] java.lang.NoClassDefFoundError: me/egg82/antivpn/external/it/unimi/dsi/fastutil/ints/IntList
java.lang.NoClassDefFoundError: me/egg82/antivpn/external/it/unimi/dsi/fastutil/ints/IntList
        at me.egg82.antivpn.BukkitBootstrap.onLoad(BukkitBootstrap.java:95) ~[?:?]
        at org.bukkit.craftbukkit.v1_16_R3.CraftServer.loadPlugins(CraftServer.java:397) ~[patched_1.16.5.jar:git-Paper-691]
        at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:252) ~[patched_1.16.5.jar:git-Paper-691]
        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1066) ~[patched_1.16.5.jar:git-Paper-691]
        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:290) ~[patched_1.16.5.jar:git-Paper-691]
        at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.ClassNotFoundException: me.egg82.antivpn.external.it.unimi.dsi.fastutil.ints.IntList
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:153) ~[patched_1.16.5.jar:git-Paper-691]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:114) ~[patched_1.16.5.jar:git-Paper-691]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:519) ~[?:?]
        ... 6 more
[13:45:27] [Server thread/ERROR]: [org.bukkit.craftbukkit.v1_16_R3.CraftServer] me/egg82/antivpn/external/redis/clients/jedis/exceptions/JedisException initializing Anti-VPN v7.0.0 (Is it up to date?)
java.lang.NoClassDefFoundError: me/egg82/antivpn/external/redis/clients/jedis/exceptions/JedisException
        at me.egg82.antivpn.BukkitBootstrap.getAllowErrorStats(BukkitBootstrap.java:549) ~[?:?]
        at me.egg82.antivpn.BukkitBootstrap.onLoad(BukkitBootstrap.java:99) ~[?:?]
        at org.bukkit.craftbukkit.v1_16_R3.CraftServer.loadPlugins(CraftServer.java:397) ~[patched_1.16.5.jar:git-Paper-691]
        at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:252) ~[patched_1.16.5.jar:git-Paper-691]
        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1066) ~[patched_1.16.5.jar:git-Paper-691]
        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:290) ~[patched_1.16.5.jar:git-Paper-691]
        at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.ClassNotFoundException: me.egg82.antivpn.external.redis.clients.jedis.exceptions.JedisException
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:153) ~[patched_1.16.5.jar:git-Paper-691]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:114) ~[patched_1.16.5.jar:git-Paper-691]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:519) ~[?:?]
        ... 7 more

Paper and Spigot are dropping Java 16.
Would really love a fix for this. @egg82
We are stuck without AntiVPN until it's updated.

Yep same here!

It will work if you add
--illegal-access=permit
to your startup flags
However this is just a temporary fix I think

@strahil211 I added  --illegal-access=permit to my run.bat startup flag and it still isn't working, I'm thinking of downgrading to java 11 or 8 until this is fixed or until 1.17 releases

@egg82 @Laarryy any news on when we will get a 1.16 version?
Mojang is dropping 1.17 in 2 days.
As well when will the plugin finally compile once more for bungee...
https://gist.githubusercontent.com/andrewkm/29ffdb77effd01aec4a533965616ea35/raw/d5cc10fcbcca2dfa392e99f20caa23f68bd305fb/gistfile1.txt

I'll be working on making this J16 and MC1.17 compatible as soon as I am able - it should be soon, but life, as usual, is hectic. Don't worry though, it's not nearly abandoned. As for the compiling on bungee... another item on the list!

@Laarryy thanks, we badly need this lately, and currently have no way to proceed.

Any updates on this?  It can't be That hard to fix it 😭

We’ll be forking AntiVPN and fixing it on our end. Feel free to get in touch for more info.

@Laarryy  have you more information or a Dev-Build?

@andrewkm Where can I get in touch with you for the fork?

Still waiting for this, is it the end of this plugin? There's gotta be a way to fix it

Plugins been dead for a while dude.
Just get your own devs to update it like we have.

Hi @andrewkm - if you have working improvements and refuse to PR them, why? Additionally, why continue to pester me about putting aside my actual life to do something you don't need done? I don't appreciate the consistent negativity, please stop and appreciate my perspective, where I currently have the choice of working in real life towards things that will affect my future permanently, or spending a very long time updating and mostly simply writing from scratch a plugin that mostly works already. I need to prioritize right now, but as I have said a number of times, I have not condemned this project and still plan on working on it once I can reasonably do so.

 Either kill the project or work on it. Your explanations mean nothing.

We love you Larry!

Hi @andrewkm - if you have working improvements and refuse to PR them, why? Additionally, why continue to pester me about putting aside my actual life to do something you don't need done? I don't appreciate the consistent negativity, please stop and appreciate my perspective, where I currently have the choice of working in real life towards things that will affect my future permanently, or spending a very long time updating and mostly simply writing from scratch a plugin that mostly works already. I need to prioritize right now, but as I have said a number of times, I have not condemned this project and still plan on working on it once I can reasonably do so.

Larry, I want to add that we support you. I'm sure the majority of the community support whatever you choose to do and prioritise. If I could help, I would!
To put it simply andrew (and for someone who has likely profited in multiple ways off this project) his attitude towards you and this project is downright appalling.

Hey @Laarryy ! Any update on adding java 16 support?
We are about to move our infrastructure over to java 16 and would love to keep using this plugin.


merge from arlac77/npm-package-template

.travis.yml

chore(travis): (jobs.include)
chore(travis): remove 12.10.0 (jobs.include.node_js)
chore(travis): remove -npm (cache)
chore(travis): (script)

Coverage remained the same at 98.4% when pulling 486f5e6a0ae2b406d4c82278f2031e6767626d46 on npm-template-sync/1 into c692df61bcf00579839cb22b64cc44a75ff845fa on master.

:tada: This PR is included in version 2.1.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use alternate approach for restart.sh

[ ] Give more controls to the user in the game window itself.

can i work on this issue?

@agarwalshivani23 yes

I've started some work on this issue as well. If anyone else is working on it, I'll be happy to discuss and collaborate.

Yeah sure
On Fri, 6 Dec, 2019, 9:44 PM Satvinder31415<EMAIL_ADDRESS>wrote:

I've started some work on this issue as well. If anyone else is working on
it, I'll be happy to discuss and collaborate.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/code-monk08/connect4/issues/5?email_source=notifications&email_token=AKPUIRXDB4LOMTDLK7S7VU3QXJ27ZA5CNFSM4IYYHEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGESRLI#issuecomment-562636973,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKPUIRSERPLME6N3TTTKXVDQXJ27ZANCNFSM4IYYHEHA
.

@code-monk08  @agarwalshivani23
Hi, I've made some changes to implement the start menu and restart option. They're present in one of my repositories : connect4-2. Running main_menu.py will start the application(with a black screen currently).Pressing enter will launch the game.After the game is over,pressing y will restart while n will quit the game.Feel free to modify the code and add graphics(currently there are none). Also, bear in mind that this version is 2 commits behind the original one. I don't feel confident implementing graphics and mouse interactivity so I think that'll be the end of my contribution to this issue.

@Satvinder31415 do one thing push your branch, I will ask @agarwalshivani23 to continue work from there.

@Satvinder31415 but why are feeling under confident?

No it's just that I'm not really good at front end design. I was thinking
of taking the test cases issue and working on it.
On Tue, Dec 10, 2019 at 8:18 PM Mayank Singh<EMAIL_ADDRESS>wrote:

@Satvinder31415 https://github.com/Satvinder31415 but why are feeling
under confident?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/code-monk08/connect4/issues/5?email_source=notifications&email_token=AMU74CURPO4YKC5ULVUKCMLQX6T2HA5CNFSM4IYYHEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGPPSAA#issuecomment-564066560,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMU74CQMN3LTVTNSRZFAQDDQX6T2HANCNFSM4IYYHEHA
.

ahh ! no issues we can improve whatever you design.. after all it's all about being creative, I will suggest you to try your hand again at this issue, bare minimum graphics will also do :)

I'm currently doing unit testing. I'll come back to this.

@Satvinder31415 I have recently merged @agarwalshivani23 's pull request and I am closing this issue, if you still want to add start menu to the game then I am looking forward to your PR, you can check the updated code and look if it helps you.


AffectItemStackEvent/AffectSlotEvent calling all slots in inventory

Hey,
whilst developing a block tracking plugin i noticed something a little weird it seems that every time you change anything in your inventory all inventory slots call the AffectItemStackEvent event im fairly sure this isnt intended behaviour as it makes very little sense to me. below i have the first 4 pages out of 10 where it calls the AffectItemStackEvent without the stack actuly being touched
http://i.imgur.com/2neifGq.png
http://i.imgur.com/lHJcIJG.png
http://i.imgur.com/GhKn3TF.png
http://i.imgur.com/3teJ0DZ.png
thanks
johnfg10

I'm not sure what to do with this plugin output.
Anyways if this problem still happens reopen an Issue on SpongeCommon
with more information.
e.g. include a copy-pasteable Listener for us to reproduce it with.


Select specific devices to disconnect

Great simple solution, thanks for providing it!
Maybe down the line this could include a list of known devices and you can select which ones will disconnect on sleep?

Hi @Mat-thieu,
Glad you've found Bluesnooze useful.
I like your idea but unfortunately I don't think it's possible to implement on modern versions of macOS. I had a look into a couple of the answers from this Ask Different question:
https://apple.stackexchange.com/questions/159548/prevent-auto-pairing-for-certain-devices-bluetooth
But none of the solutions seem to work any longer (I'm not an expert in Cocoa / Bluetooth APIs so there might be a solution, but I don't know what it might it be).
Thanks,
Oli


chore: drop nginxinc.nginx role

nginxinc.nginx dropped support for Ubuntu 16.04 and Debian 9.
However, installing dokku should install nginx automatically, i.e. the
role was unnecessary in the first place.

Following @josegonzalez's suggestion here to simply drop the nginxinc.nginx role dependency since nginx should be installed as a dokku dependency anyhow.
The build errors when installing the dokku package; there seems to be an issue with the the nginx service not starting up properly in this case (log)
"Starting nginx (via systemctl): nginx.serviceJob for nginx.service failed because the control process exited with error code.",
"See \"systemctl status nginx.service\" and \"journalctl -xe\" for details.",
" failed!",
"Reloading nginx configuration (via systemctl): nginx.servicenginx.service is not active, cannot reload.",
" failed!",
"2021/11/07 21:14:00 exit status 1",
"dpkg: error processing package dokku (--configure):",
" installed dokku package post-installation script subprocess returned error exit status 1",

If someone has any pointers as to why that might be, let me know.
Otherwise I'll need to find some time at some point to run it on a live machine

Is it because tests are run in docker and there is no systemd in docker?

Is it because tests are run in docker and there is no systemd in docker?

Thanks for the suggestion - geerlingguy's docker images that we are using have systemd (see e.g. here); also apt-installing dokku works just fine when the nginxinc.nginx role is run before (as we currently do).
I wonder what nginxinc.nginx does that makes this problem go away...

The issue still persists today.
Active support for ubuntu 16.04 ended April 2021, so I personally don't care about supporting it in this role.
Given this, let's not try to fix something that isn't broken.
Should someone else be interested in removing the dependency on the nginxinc.nginx role in the future, feel free to continue.


dashboard: unclear header

the header 'Data shown below are for the organization' is unclear

clearer (display is by organization). wording could become '{organization name} data'

will change when we link submission to user.


allow setting of animation speed

Level remote7 demo is so fast, I cannot absorb what is going on.
It will be good to have a control to set the animation speed.

If you execute this line in console:
debug_Constants_GRAPHICS.defaultAnimationTime = 1600

you can change the default animation speed! its a little hidden but should unblock you :)


[WIP] refactor: Converting TableElement.jsx to functional component

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Still working on PR summary and testing.

Codecov Report

Merging #12949 (4067237) into master (c781ab8) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12949      +/-   ##
==========================================
- Coverage   66.92%   66.87%   -0.06%
==========================================
  Files        1024      489     -535
  Lines       50185    28661   -21524
  Branches     5213        0    -5213
==========================================
- Hits        33588    19166   -14422
+ Misses      16457     9495    -6962
+ Partials      140        0     -140

Flag
Coverage Δ

cypress
?

javascript
?

python
66.87% <ø> (+2.78%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/views/database/views.py
62.69% <0.00%> (-24.88%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/db_engine_specs/elasticsearch.py
86.95% <0.00%> (-7.49%)
:arrow_down:

superset/db_engine_specs/clickhouse.py
87.09% <0.00%> (-7.35%)
:arrow_down:

superset/sql_validators/base.py
93.33% <0.00%> (-6.67%)
:arrow_down:

superset/db_engine_specs/presto.py
82.25% <0.00%> (-6.28%)
:arrow_down:

superset/db_engine_specs/sqlite.py
90.62% <0.00%> (-6.25%)
:arrow_down:

superset/db_engine_specs/base.py
79.85% <0.00%> (-6.12%)
:arrow_down:

... and 566 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c781ab8...4067237. Read the comment docs.

Do you want to set this as a "draft", too?

Corbin has taken this over at this PR.


De-dupe API docs

The API docs are now in https://github.com/expressjs/express-api-docs as well as here.  In the Express TC meeting, it was decided to consolidate them as described in https://github.com/expressjs/express/issues/2902#issuecomment-189068604.  For convenience, I reproduce the basic proposal here:

Create a GitHub Pages site from the API docs at https://github.com/expressjs/express-api-docs, which would be at http://expressjs.github.io/express-api-docs (or whatever).  This site would contain the API doc content but also have the navigation to the rest of the documentation, linking out to http://expressjs.com for the other non-API docs.  This wouldn't be hard.
Remove the source of the API docs from https://github.com/strongloop/expressjs.com and change the navigation header so that the links to the API docs point to http://expressjs.github.io/express-api-docs.  That is, when someone clicks on the API > 4.x menu link, http://expressjs.github.io/express-api-docs would actually load.

The end result would be something that appears exactly like the current http://expressjs.com/ but where the API docs are sourced and published from https://github.com/expressjs/express-api-docs.  The site would look essentially the same at http://expressjs.github.io/express-api-docs), although it would have a different home page, I presume.
NOTE: Instead of using the default GH pages domain, we'll use expressjs.info domain that @jasnell grabbed on behalf of the foundation recently.
Link to https://github.com/expressjs/express-api-docs/issues/2.

Once @mikeal provides the information I need to transfer the domain
ownership I will initiate. Until then, I can create the CNAME record to
point to the appropriate github.io location.
On Mar 1, 2016 4:36 PM, "Rand McKinney"<EMAIL_ADDRESS>wrote:

The API docs are now in https://github.com/expressjs/express-api-docs as
well as here. In the Express TC meeting, it was decided to consolidate them
as described in expressjs/express#2902 (comment)
https://github.com/expressjs/express/issues/2902#issuecomment-189068604.
For convenience, I reproduce the basic proposal here:

Create a GitHub Pages site from the API docs at
https://github.com/expressjs/express-api-docs, which would be at
http://expressjs.github.io/express-api-docs (or whatever). This site
would contain the API doc content but also have the navigation to the rest
of the documentation, linking out to http://expressjs.com for the
other non-API docs. This wouldn't be hard.
Remove the source of the API docs from
https://github.com/strongloop/expressjs.com and change the navigation
header so that the links to the API docs point to
http://expressjs.github.io/express-api-docs. That is, when someone
clicks on the API > 4.x menu link,
http://expressjs.github.io/express-api-docs would actually load.

The end result would be something that appears exactly like the current
http://expressjs.com/ but where the API docs are sourced and published
from https://github.com/expressjs/express-api-docs. The site would look
essentially the same at http://expressjs.github.io/express-api-docs),
although it would have a different home page, I presume.
NOTE: Instead of using the default GH pages domain, we'll use
expressjs.info domain that @jasnell https://github.com/jasnell grabbed
on behalf of the foundation recently.
—
Reply to this email directly or view it on GitHub
https://github.com/strongloop/expressjs.com/issues/593.

Just quickly, but I believe the intention was http://expressjs.info/ using an A-name DNS entry supported by GitHub pages. More information: https://help.github.com/articles/using-a-custom-domain-with-github-pages/

Ah, right, A record, not CNAME. Sorry got CNAME stuck in my head. :)
On Mar 1, 2016 4:38 PM, "Blake Embrey"<EMAIL_ADDRESS>wrote:

Just quickly, but I believe the intention was http://expressjs.info/
using an A-name DNS entry supported by GitHub pages. More information:
https://help.github.com/articles/using-a-custom-domain-with-github-pages/
—
Reply to this email directly or view it on GitHub
https://github.com/strongloop/expressjs.com/issues/593#issuecomment-190991168
.

With the announcement of the plan to move this repo to expressjs org, this problem goes away, so I'm closing.


[GOBBLIN-312] Pass extra kafka configuration to the KafkaConsumer in …

…KafkaSimpleStreamingSource
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-312

Description

[X] Here are some details about my PR, including screenshots (if applicable):

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Adds the gobblin.streaming.kafka.consumerConfig configuration prefix for passing extra kafka config to the KafkaConsumer.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@abti, please review.


Update images of Stream Analytics queries in documentation

Addressed in Commit https://github.com/MSOpenTech/connectthedots/commit/5dfd115fa47cae8215f48833d4378129c97ec031


Moar bitfield fixes.

See the individual commits for details.
Last one fixes the overflow issues observed in https://bugzilla.mozilla.org/show_bug.cgi?id=1365254#c22, cc @upsuper.

 Warning

These commits modify unsafe code. Please review it carefully!

r? @fitzgen


SVG icon won't scale as expected

See here
https://codepen.io/marcomtr/pen/JjZjrNK

Looks like all material symbols are missing the viewBox property. Working example with viewBox property set: https://jsfiddle.net/yq5befz7/
Will ask on official repo if it can be added at the source (fonts CDN), otherwise will add it in this package.

Added viewBox to SVGs in the latest release 0.4.0


Handle the end-of-module-handling more gracefully

When a module ends, it immediately goes back into the main listen loop, and this is confusing to the user.  When the conversation class is done handing a module, it needs to re-introduce itself so that the user knows they can do something else now.

FIxed by 4af1c0cf2bead02b15b780dbfb9bb99b8b43a5b7


Fix docs bugs(#1018)

Fix docs bugs to make them readable

Fix the wrong link in readme

Description

Fixes pyrsia/pyrsia#
This PR does... by accomplishing... and it can be reviewed by... you can also test the changes by running...
Screenshots (optional)
PR Checklist

[ ] I've read the contributing guidelines.
[ ] I've read "What is a Good PR?"
[ ] I've included a good title and brief description along with how to review them.
[ ] I've linked any associated an issue.

Code Contributions

[ ] I've built the code cargo build --all-targets successfully.
[ ] I've run the unit tests cargo test --workspace and everything passes.
[ ] I've made sure my rust toolchain is current rustup update.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.cyj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Implement InternalTrace logging in extensibility assembly

This new assembly needs ot have logging but if we do it in the obvious way, based on what we have done before, it will create yet another log file. By preference, we should pass the internal trace settings, including the writer, into the new assembly when we create ExtensionManager. To do that, InternalTrace class needs to create a singleton instance rather than being a static class.
See UPDATE below

It turned out to be simpler to just move the logging code into the extensibility assembly, which is referenced by both the engine and the agents.

:tada: This issue has been resolved in version 2.0.0-alpha7 :tada:
The release is available on:

GitHub Release
NuGet Package


EDA

There is class imbalance in the dataset. You can explain how to deal with this and how could that affect the results? You could do that in the EDA file or in the proposal.

Hi Hossam, thank you for your feedback, to address the data imbalance, we decided to use f1-score as our metric to analysis the data. We hope that this is ok. Again, we do appreciate your feedback to help us improve further.
Best,
Group 33


Backup Times

Hello!
I've been using mscs for quite some time now and I'm wondering if anyone else has reported backup times changing somewhat randomly?
I know as my world grows that my backup size grows but every world I've ever played using mscs the backup changes from about 30-40 seconds to a full 7 minutes with nothing in the world changing (loading new chunks/dimension etc). Is there something I'm missing in the way mscs backup functions that can help me decrease the time?
Thanks!

We use rdiff-backup to run backups.  I just checked my worlds, and all of them complete a backup in less than a minute, even my oldest world. 7 minutes seems off unless the world is huge.  Since rdiff-backup performs incremental backups, maybe you could try deleting the backup folder for the world and run a fresh backup (fresh backups take longer than the next). As long as you are running with the default configuration, backups are found in /opt/mscs/backups/<world>/.

Thank you. This helped. The default is 30 days. I changed it to 10 and then deleted my backups folder and now it’s back to just a few seconds. Hopefully changing my default to 10 will help all of my worlds going forward.


Add a decent readme.md

For now, focus on:

Recording a video to showcase how to use the app
Writing a good enough readme.md to guide people on what the project has and in what helps.

I'll try to host the demo video here:
https://github.com/user-attachments/assets/d0832790-a7b7-4c3d-824f-647a935c641f


vcpkg bootstrap error

I have the vcpkg error on  VC 20197
Version: 1.41.1 (user setup)
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:58:56.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362
PS C:\vcpkg-master> .\bootstrap-vcpkg.bat
Could not find Visual Studio. VS2015 or VS2017 (with C++) needs to be installed.
In C:\vcpkg-master\scripts\bootstrap.ps1:143 car:9

    throw "Could not find Visual Studio. VS2015 or VS2017 (with C ...

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Could not find ...o be installed.:String) [], RuntimeException
FullyQualifiedErrorId : Could not find Visual Studio. VS2015 or VS2017 (with C++) needs to be installed.

Tryed to reboot, no solution
I have this extensions installed
Name: C/C++
Id: ms-vscode.cpptools
Description: C/C++ IntelliSense, debugging, and code browsing.
Version: 0.26.2
Publisher: Microsoft
Name: C/C++ Snippets
Id: hars.cppsnippets
Description: Code snippets for C/C++
Version: 0.0.14
Publisher: Harsh
Name: PlatformIO IDE
Id: platformio.platformio-ide
Description: Development environment for Embedded, IoT, Arduino, ARM mbed, Espressif (ESP8266/ESP32), AVR, RISC-V, STM32, PIC32, nRF51/nRF52, MSP430, MCS-51 (8051), FPGA, FreeRTOS, ESP-IDF, CMSIS, SPL
Version: 1.10.0
Publisher: PlatformIO

Thanks for posting this issue. This issue has been fixed. So I am closing this issue for now.


Fix missing filters on plugin iterator.

Coverage decreased (-2.7%) to 46.195% when pulling 1eb30458360c87df5e4175ce150ae7f9727c6e64 on jdgarrett:avro-ingest-iterator-fix into 3c11af41f49641ffe68fc7033ce59b10d4b13ab9 on locationtech:master.


C#: Unable to set custom scene tree class

Tested versions

master [b97110c]
4.3-beta2
4.2.2-stable

System information
Godot v4.3.beta.mono (b97110cd3) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; <IP_ADDRESS>23) - AMD Ryzen 9 3900X 12-Core Processor (24 Threads)
Issue description
Using a custom scene tree defined in C# does not seem to work and displays an error on scene start that the defined scene tree could not be found. Doing so in GDScript works without any issues. I have attempted the following steps:

Simply defining a subclass that extends SceneTree and referencing the C# class name in the project settings.
Explicitly adding the GodotClassName attribute to said subclass and referencing the value provided in the attribute in the project settings
Registering the custom scene tree as a custom type using an editor plugin

I went through open and closed issues and couldn't find anything that resembled this so I don't know if this a user error, known problem, expected behavior or a bug.
Steps to reproduce
The attachted project contains 2 custom scene trees: MySceneTree defined in GDScript and NonWorkingSceneTree defined in C#. The project is set to the C# variant by default so running the test scene should immediately display an error that the scene tree was not found. Switching the scene tree to MySceneTree in the project settings should work and print initialize to the console on start.
Minimal reproduction project (MRP)
scenetreetest.zip

Update: This was indeed a user error. Adding the GlobalClass attribute to the custom C# Scene tree makes it work as expected.


[SPARK-19727][SQL] Fix for round function that modifies original column

What changes were proposed in this pull request?
Fix for SQL round function that modifies original column when underlying data frame is created from a local product.
import org.apache.spark.sql.functions._

case class NumericRow(value: BigDecimal)

val df = spark.createDataFrame(Seq(NumericRow(BigDecimal("1.23456789"))))

df.show()
+--------------------+
|               value|
+--------------------+
|1.234567890000000000|
+--------------------+

df.withColumn("value_rounded", round('value)).show()

// before
+--------------------+-------------+
|               value|value_rounded|
+--------------------+-------------+
|1.000000000000000000|            1|
+--------------------+-------------+

// after
+--------------------+-------------+
|               value|value_rounded|
+--------------------+-------------+
|1.234567890000000000|            1|
+--------------------+-------------+

How was this patch tested?
New unit test added to existing suite org.apache.spark.sql.MathFunctionsSuite

Can one of the admins verify this patch?

I dont' know the code well enough to really evaluate this, but, I see that .clone() is called in a similar context in decimalExpressions. There are also similar usages of changePrecision in UnsafeArrayWriter and UnsafeRowWriter; I wonder if they are affected too?
CC maybe @cloud-fan or @yjshen  ?

I think we should fix changePrecison to return a new instance instead of updating itself.

Good idea @cloud-fan. I will look for usages of changePrecision then.

I have just started refactoring of changePrecission in order to make it immutable.
My idea was to change the signature from:
def changePrecision(precision: Int, scale: Int, mode: Int): Boolean
into
def changePrecision(precision: Int, scale: Int, mode: Int): Option[Decimal]
Here are my first thoughts:

org.apache.spark.sql.types.Decimal is mutable by definition, so making one method immutable makes its contract very inconsistent

I am afraid of performance degradation in micro-benchmarks since in some use cases, an instance needs to be created twice

changePrecission is called 10 times in Scala, 10 times in code gen functions and 3 times in Java unsafe writers (UnsafeArrayWriter, UnsafeRowWriter)

I would be grateful if you could confirm if it's the right way to go.

how about we add a new method toPrecision that returns Option[Decimal]? Most of the time we should call toPrecision, but for some performance critical path we should call changePrecission

It seems it makes more sense now, please have a look.

LGTM, pending tests

@cloud-fan could you please give the green light to tests?

ok to test

sorry forgot the trigger the test...

Test build #74135 has started for PR 17075 at commit fc0f2d1.

Test build #74135 has finished for PR 17075 at commit fc0f2d1.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74135/
Test FAILed.

retest this please

Test build #74152 has started for PR 17075 at commit fc0f2d1.

Test build #74152 has finished for PR 17075 at commit fc0f2d1.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74152/
Test FAILed.

retest this please

Test build #74181 has started for PR 17075 at commit fc0f2d1.

Test build #74181 has finished for PR 17075 at commit fc0f2d1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74181/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #74186 has started for PR 17075 at commit fc0f2d1.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74186/
Test FAILed.

retest this please

Test build #74195 has started for PR 17075 at commit fc0f2d1.

Test build #74195 has finished for PR 17075 at commit fc0f2d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74195/
Test PASSed.

Merged build finished. Test PASSed.

thanks, merging to master!


Update README added .keep files

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #57 into release will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           release    #57   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files            2      2
  Lines          714    714
======================================
  Hits           714    714

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97d39c...31c50f4. Read the comment docs.


Unit variety

Hi! First of all, I'd like to say I've just started using you app and I really like it.
I wanted to suggest adding some other Units of Measurement to the app, mostly on the metric system.
Using Km for excercise tracking, cm for height measuring, kg for weight measuring, etc.
It should be simple enough to add code that does the conversions on the backend and it would save some hassle for people who don't use the imperial system (having to do conversions on another app or site is kind of annoying and it goes against the quick and easy usage of your app).
Thanks a bunch!

That is a very good idea. You can clearly see my American bias working in :)
However, because it’s a mostly American audience, I think what I’ll do is have it be set when you first login for the first time and then you can change it in settings page. Does that sound reasonable you?
And fun fact, a lot of the internals are ready and are metric!
But just so I’m not missing anything, can you list the units that you would like to see?

That sounds good.
As far as I can see on the app, most of the excercise tracking is based on weight and distance, so here you can set the option for kg instead of lbs and km instead of miles.
The same measure of kg instead of lbs and cm instead of feet and inches can go into the config tab to set the user's personal data (weight and height).
The units for food (i.e kcal, grams) are fine because I think it's kind of universal? I use the American system where I'm from (South America) so that's no issue for me, and the customizable foods/recipes already uses grams for servings so it's cool.
I guess mostly that: for distance add km, for weight kg, for height cm (this might need a little bit of UI tweaking because you have to input tabs for feet/inch..sorry).
Thanks in advance!

Ok great - I’ll let you know when I finish - and you can give feedback on thread

Done! Let me know what you think :)

Seems to be working fine! Great job!


How to use the upcoming federation support?

Hi,
After some digging I see that federation support is on the roadmap for HC11.0 via this branch: https://github.com/ChilliCream/hotchocolate/tree/feat-apollo-federation-support
However, I need it now..... I've pulled that branch down, built it and added the resulting packages into my project.  If I'm using schema first, can I just define a schema with the external / key etc directives and HC will know what to do with them?  Is there support for resolving references yet?

It is not fully implemented and will not work.

@dillanmann is leading the effort here and might have some more to say on it. Furthermore, it is not clear if this feature will make the cut for 11.0, it might be moved to a later version. However, we always need helping hands on our efforts, so if you want to help to implement this you can join our slack channel and I can set you up with @dillanmann who did the initial parts of it.


Logs

Problem Statement
I'm trying to properly manage openvpn-server and openvpn-auth-oauth2 logs and trying to connect both of them.
Openvpn-server has client IP adress data and openvpn-auth-oauth2 has cid, but there's no way to connect those log lines with openvpn-auth-oauth2 log lines - openvpn-server doesn't have a log line with both cid and IP and openvpn-auth-oauth2 doesn't have any log entry with IP.
Would it be possible, to add client IP address (in example: x.y.z.203) and maybe also port (in example: 51552) to openvpn-auth-oauth2 log lines? at least in one of them, preferrably 1st openvpn-auth-oauth2 log line: "msg="new client connection" cid=617 kid=1 common_name=....". Would be awesome if all the log entries would have IP, but I can also deal with 1 - then I can tie openvpn-server entries which start with IP, with openvpn-auth-oauth2 entries.
Here's an (redacted) current log example:

Apr  3 14:26:25 openvpn ovpn-server[27936]: x.y.z.203:51552 TLS: move_session: dest=TM_ACTIVE src=TM_INITIAL reinit_src=1
Apr  3 14:26:25 openvpn ovpn-server[27936]: x.y.z.203:51552 TLS: tls_multi_process: initial untrusted session promoted to semi-trusted
Apr  3 14:26:25 openvpn openvpn-auth-oauth2[95295]: time=2024-04-03T14:26:25.431Z level=INFO msg="new client connection" cid=617 kid=1 common_name=clientname reason=CONNECT
Apr  3 14:26:25 openvpn openvpn-auth-oauth2[95295]: time=2024-04-03T14:26:25.431Z level=INFO msg="start pending auth" cid=617 kid=1 common_name=clientname reason=CONNECT
Apr  3 14:26:25 openvpn ovpn-server[27936]: MANAGEMENT: CMD 'client-pending-auth 617 1 "WEB_AUTH::https://vpn.domain.com:9000/oauth2/start?state=Rs_sz...Angy-sM5_Y" 180'
Apr  3 14:26:25 openvpn ovpn-server[27936]: SENT CONTROL [clientname]: 'AUTH_PENDING,timeout 180' (status=1)
Apr  3 14:26:25 openvpn ovpn-server[27936]: SENT CONTROL [clientname]: 'INFO_PRE,WEB_AUTH::https://vpn.domain.com:9000/oauth2/start?state=Rs_sz...Angy-sM5_Y' (status=1)
Apr  3 14:26:25 openvpn ovpn-server[27936]: x.y.z.203:51552 Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 2048 bits RSA, signature: RSA-SHA256, peer temporary key: 253 bits X25519
Apr  3 14:26:25 openvpn ovpn-server[27936]: x.y.z.203:51552 [clientname] Peer Connection Initiated with [AF_INET]x.y.z.203:51552
Apr  3 14:26:25 openvpn ovpn-server[27936]: x.y.z.203:51552 PUSH: Received control message: 'PUSH_REQUEST'
Apr  3 14:26:25 openvpn openvpn-auth-oauth2[95295]: time=2024-04-03T14:26:25.794Z level=INFO msg="initialize authorization via oauth2" cid=617 kid=1 common_name=clientname
Apr  3 14:26:26 openvpn ovpn-server[27936]: x.y.z.203:51552 PUSH: Received control message: 'PUSH_REQUEST'
Apr  3 14:26:27 openvpn openvpn-auth-oauth2[95295]: time=2024-04-03T14:26:27.043Z level=INFO msg="successful authorization via oauth2" cid=617 kid=1 common_name=clientname idtoken.subject=sV52..mQ idtoken.email=""<EMAIL_ADDRESS>user.subject=sV52..mQ<EMAIL_ADDRESS>Apr  3 14:26:27 openvpn openvpn-auth-oauth2[95295]: time=2024-04-03T14:26:27.043Z level=INFO msg="accept OpenVPN client cid 617, kid 1" cid=617 kid=1 common_name=clientname idtoken.subject=sV52..mQ idtoken.email=""<EMAIL_ADDRESS>user.subject=sV52..mQ<EMAIL_ADDRESS>Apr  3 14:26:27 openvpn ovpn-server[27936]: MANAGEMENT: CMD 'client-auth 617 1'
Apr  3 14:26:27 openvpn ovpn-server[27936]: clientname/x.y.z.203:51552 MULTI_sva: pool returned IPv4=<IP_ADDRESS>, IPv6=(Not enabled)

Environment

openvpn-auth-oauth2 Version:
OpenVPN Server Version:
Server OS:
OpenVPN Client (flavor, OS):

Sorry, I might have been blind and noticed just now that this is exactly what I'm asking for.
But it says default true.. is this a new param with new version?

--log.vpn-client-ip
log IP of VPN client. Useful to have an identifier between OpenVPN and openvpn-auth-oauth2. (env: CONFIG_LOG_VPN__CLIENT__IP) (default true)

Sadly, you did not share the version you are using. It's available since v1.19.0


Add working steps in Hyperperfect calculator

Proposal
(A clear and concise description of what the proposal is.)

pls assign me

Go ahead
Deadline 16 June,2021

If no one is working on this issue can i work on it @sairish2001  @arpit456jain

Go ahead
Deadline 30 June,2021

As there is no temperature converter . Can I create an issue for it if no
issue exits like it.
On Fri, Jun 25, 2021, 10:23 Rajinderpal Singh @.***>
wrote:

Assigned #4780
https://github.com/makesmatheasy/makesmatheasy/issues/4780 to
@jugeshraghav https://github.com/jugeshraghav.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/makesmatheasy/makesmatheasy/issues/4780#event-4938014154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARVI6WKXNDVVHZMLOBWWRJ3TUQDTDANCNFSM45ZTGYXA
.

Hi, @sairish2001 @arpit4567jain  I want to know something related to the issue. Steps here means after entering some value we must define how the number is a hyperperfect number .

Hi, @sairish2001 @arpit4567jain  I want to know something related to the issue. Steps here means after entering some value we must define how the number is a hyperperfect number .

Means how the value is computed, just explain it, in proper way. You can check other Calculators which having steps, Like refer Calculators/solveFraction.html or function solveFraction (...,...)  in logicJavaScript.js file, to get an rough idea, what we mean from Steps

As there is no temperature converter . Can I create an issue for it if no
issue exits like it.
On Fri, Jun 25, 2021, 10:23 Rajinderpal Singh @.***>
wrote:

Assigned #4780
https://github.com/makesmatheasy/makesmatheasy/issues/4780 to
@jugeshraghav https://github.com/jugeshraghav.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/makesmatheasy/makesmatheasy/issues/4780#event-4938014154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARVI6WKXNDVVHZMLOBWWRJ3TUQDTDANCNFSM45ZTGYXA
.

In basic Converters Section this Calculator is there


Remove an unnecessary apostrophe in this text

This is possessive "its" which doesn't need an apostrophe; "it's" is a contraction of "it is" which doesn't make sense here.

Merged, well spotted!


No horizontal scrolling with scroll wheel, trackpad or arrow keys.

First of all, great plugin! Looks like a great start.
The only thing keeping me from using this would be the lack of working horizontal scroll listeners and arrow key listeners.
Disclaimer: I haven't used in code, this is just from trying out the demo.

I would second this, for ref: tested on Chrome, Safari, Firefox all latest versions,  on a Mac Book Pro using macOS Sierra.

Hey @calebroseland. @simondavies
Thank you for giving me an issue~
But Unfortunately the browser can't detect "horizontal wheel" natively (CMIIW). So, if you want to scroll horizontally, you can hold shift and start scrolling (vertically). It will move your content horizontally. Try it :grin: :+1:

+1 deal breaker for me that I can scroll horizontally


Loop inside orchestration causing external events being ignored?

Need to check if the same issue happens here as well. https://github.com/dapr/java-sdk/issues/967

This behavior is expected
Cause: https://github.com/microsoft/durabletask-java/blob/ad8c959b580a635da818b6f4c56731adce0a8ef3/client/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java#L420C28-L420C48, each iteration there are two tasks created and we put them in our task queue, but eventually only one task will be consumed in one iteration, so in next iteration, the other event will consume the old task left in the queue causing the behavior that this event is ignored (anyway we already lose the reference to the old task). Because we are using the loop inside the workflow, the task queue is a singleton so old unconsumed tasks will pipe in that singleton queue causing this behavior.


Adds note about repo flag

Signed-off-by: Dharmit Shah<EMAIL_ADDRESS>
Description of the change:
$subject
Motivation for the change:
To ensure that the reader doesn't get lost into trying to fix the errors reported by the IDE. GoLand reported 35 errors to me. I decided to see at the very first occurrence, which was in the import block. Luckily, for me, fixing that fixed all the subsequent errors.
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

@dharmit you might have to rebase against master (if you haven't done that already) for the molecule tests to pass.

Thanks, @rashmigottipati.  I thought it was required only when doing git commit.
There are two commits in this PR, and both are signed off using git commit -s. Wonder why DCO is still unhappy.
Anyway, I'll amend the commit and force-push to see if that helps.


Ehlers-Danlos syndrome

This term is currently classified as a collagenopathy and yet not all forms of EDS are caused by collagen gene mutations. Probably all EDS forms affect collagen in some way, but multitudes of other diseases also affect collagen in some way and thus this is not a consistent way to classify this disease.

A similar comment applies to the various osteogenesis imperfecta forms.


Ease maintenance

Closes #235.
I'm pushing now to get some guidance on requirements moving forward.

Travis CI does not seem activated for this project. Is this something you could look at? It would make sense, since .travis.yml is already there, and all.

@ferigis should merge, but I already approved 😏

@ferigis: ping

hi, I can't merge it if travis is complaining

Let me see what's stopping it.

That's odd. It seems to not find katana 1.0.0

I'm bumping rebar3 (in script ci) to "latest available", since this seems to be the origin of the failing CI checks.

I see this failing, now, only for OTP 20.3. I don't know if that's good or bad. :(
@ferigis, do you want me to look into this?

…aaaand merged!


Duplicate weight initialization

[Question1]
In model.py, line 107 - 117:
The following layer's weight was initalized by xavier init but at line 111 they are also initialized by weight_norm. Why do we initialize their weights twice?

ns_fc3
nsa_fc4
nsc_fc4

[Question2]
In the same file, line 119:
Why do we need to add this line: self.train(). According to pytorch official document, it says:

This has any effect only on modules such as Dropout or BatchNorm.

Does this mean we can remove this line?
Thank you, this repo is awesome and with nice coding structure.

For Q1, I was following weight initialization approaches from ikostrikov/pytorch-a3c/model.py. It actually does twice weight initializations. I haven't done comparing performance between different initialization approaches. I've refactored to cleaner solution https://github.com/wing3s/pysc2-rl-mini/commit/c5551fbe26e82c50cc8ef16a7cd87f3875fa91fa without stacking initializations.
For Q2, from source code, self.train() only has impact on Dropout and BatchNorm like you mentioned. Theoretically, we can remove it. I haven't done testing removing these lines to prove it.
Thanks for digging into the code. I'll circle back to these questions once I'm in final testing phase.

Thank you for your response :)


Fix docs build

Codecov Report

Merging #4 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   79.46%   79.41%   -0.06%
==========================================
  Files          49       49
  Lines        3546     3546
==========================================
- Hits         2818     2816       -2
- Misses        572      574       +2
  Partials      156      156

Impacted Files
Coverage Δ

config/dynamic.go
83.25% <0%> (-0.96%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f1917...2b51d99. Read the comment docs.


[Feature request] rclone lsjson with encryption mapping

A -M flag for the lsjon command would include the encryption mapping on crypt remotes. It would give the same info as --crypt-show-mapping, but directly in the JSON object, not on STDERR.

That is a nice idea!

Hi,
I would like to work with this issue.

@kubatasiemski - Great - thanks!

Please find this in the beta
https://beta.rclone.org/v1.39-218-gacae10cd/ (uploaded in 15-30 mins)
Please re-open if you have a problem with it.
Thanks @kubatasiemski for implementing it :-)


Add put_header function

I just added the function put_header to plugin.
Email.put_header(%Email{}, "HEADER_KEY", "HEADER_VALUE")

Before I accept this merge, can you can a couple test cases in test/email_test.exs to test this function?

Sure, i rename the function and test case is added.


Add option to disable adjustment factor in EWMA

Hi wesm, was this issue fixed?

yes — see the referenced commit


question about texture management

Hi! I was wondering, why not make one texture file per block?
This would allow us to put a direct link to the block texture instead of the texture coordinates in a single file.

unless we put it all in an atlas at runtime which isnt too easy to do as it seems (+ given the codebase this has), when drawing blocks we'd need to switch the texture every time a different block face is drawn, which is kinda slow compared to if we were using the texture coords with only one texture. this also has the downside of slowing down start times by having to load each texture individually and having to allocate gpu memory and a texture object for each of them, which there is a limit on how many texture objects you can have at once.
hope this helps

Considering even Minecraft itself used a single file for all block faces up to 1.12 (I belive), the current approach should be more than fine


Support DNS over HTTP (DoH) and DNS over TLS (DoT)

Is your feature request related to a problem? Please describe.
Currently I dont see any method to deploy a DNS listener with DoH or DoT funtionality.
Describe the solution you'd like
Ability to create DoH Proxy Profile
Ability to create DoH Server Profile
Ability to create DoH proxy Listeners
Ability to create DoH Server Listeners
Ability to attach Client SSL profile to tcp DNS listener to enable DoT functionality.
Describe alternatives you've considered
There are no alternatives
This functionaity is in BigIP as of version 16.1 - https://support.f5.com/csp/article/K05451012
Here are some additional details - https://clouddocs.f5.com/training/community/dns/html/class5/class5.html

Any info about this if this will be implemented?


Shared load balancer not getting created v1.13.0-rc1

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I wanted to try out the new shared lb mode for ingress from here #21386
Installed cilium 1.13 rc using the cli with ingressController.loadbalancerMode=shared
cilium install --version "v1.13.0-rc1" \
            --helm-set ingressController.enabled=true \
            --helm-set ingressController.loadbalancerMode=shared \
            --helm-set bgp.enabled=true \
            --helm-set bgp.announce.loadbalancerIP=true

Then added an ingress obect
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: news-ingress
  namespace: news
spec:
  ingressClassName: cilium
  rules:
    - host: news.kube2.domain.local
      http:
        paths:
          - backend:
              service:
                name: url-service
                port:
                  number: 5000
            path: /api/url
            pathType: Prefix

  tls:
    - hosts:
        - news.kube2.domain.local
      secretName: ingress-cert

But no LoadBalancer service gets created.
When I omit ingressController.loadbalancerMode=shared the LoadBalancer looks like this
NAMESPACE     NAME                                  TYPE           CLUSTER-IP      EXTERNAL-IP     PORT(S)                      AGE
news          service/cilium-ingress-news-ingress   LoadBalancer   <IP_ADDRESS>     <IP_ADDRESS>   80:31680/TCP,443:32395/TCP   11m

Am I doing anything wrong here?
Cilium Version
v1.13.0-rc1
Kernel Version
Linux kube02 5.10.0-18-amd64 #1 SMP Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux
Kubernetes Version
v1.24.6+k3s1
Sysdump
cilium-sysdump-20221015-201208.zip
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

:wave:
The above installation command looks good to me, however, it's hard to know for sure what is insuded cilium-ci:latest image.
Can you help to update the image of cilium-opeator and cilium agent to v1.13.0-rc1 and retry ?
          image: quay.io/cilium/cilium-ci:latest

Yes of course.
I ran cilium upgrade --version "v1.13.0-rc1", now cilium version displays v1.13.0-rc1 as running
After that I deleted and re-added the ingress -> no change on service side
New logs attached: cilium-sysdump-20221017-001314.zip
BTW is this intended that the cli installer uses latest instead of the specified version?

BTW is this intended that the cli installer uses latest instead of the specified version?

@Woidla27 no, that was a bug and is now fixed in the latest cilium-cli.

Not sure if it's still issue for you, kindly let me know how it's going.

Yes this is still an issue for me.
Meanwhile I tried out cilium v1.13.0-rc3 ok kubernetes v1.25.4+k3s1 and still no LoadBalancer in shared mode.
cilium install --version "1.13.0-rc3" \
	--helm-set kubeProxyReplacement=strict \
	--helm-set k8sServiceHost=<IP_ADDRESS> \
	--helm-set k8sServicePort=6443 \
	--helm-set ingressController.enabled=true \
	--helm-set ingressController.loadbalancerMode=shared \
	--helm-set bgp.enabled=true \
	--helm-set bgp.announce.loadbalancerIP=true

Linux kube02 5.10.0-19-amd64 #1 SMP Debian 5.10.149-2 (2022-10-21) x86_64 GNU/Linux
Here is a new log bundle: cilium-sysdump-20221214-210905.zip
I am happy to provide more logs as required
@aanm cilium-cli installs the correct version now. Thank you.

can you also share you bgp-config map as well ?
I have tested with latest master image, it seems working well.
$ cilium status
    /¯¯\
 /¯¯\__/¯¯\    Cilium:         OK
 \__/¯¯\__/    Operator:       OK
 /¯¯\__/¯¯\    Hubble:         disabled
 \__/¯¯\__/    ClusterMesh:    disabled
    \__/

Deployment        cilium-operator    Desired: 1, Ready: 1/1, Available: 1/1
DaemonSet         cilium             Desired: 1, Ready: 1/1, Available: 1/1
Containers:       cilium             Running: 1
                  cilium-operator    Running: 1
Cluster Pods:     2/4 managed by Cilium
Image versions    cilium             cilium:tilt-79a3eb9e6cdccb6c: 1
                  cilium-operator    operator-generic-ci:tilt-07cfa4c9560e9f54: 1

$ ksysg services cilium-ingress
NAME             TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                      AGE
cilium-ingress   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>     80:32708/TCP,443:30417/TCP   24m

Here is my bgp config map
apiVersion: v1
kind: ConfigMap
metadata:
  name: bgp-config
  namespace: kube-system
data:
  config.yaml: |
    peers:
    - peer-address: <IP_ADDRESS>
      peer-asn: 65535
      my-asn: 64512
    address-pools:
    - name: default
      protocol: bgp
      addresses:
      - <IP_ADDRESS>/28

Today I had some time to experiment.
Tried a lot of things.

Fresh installation using K3S v1.26.0+k3s2 + Cilium v1.13.0-rc3, still on Debian 11
Migrated MetallLB BGP to Cilium BGP Control Plane + LB IPAM
Different combinations with shared and dedicated LoadBalancer (both as default value in cilium-config configmap and annotation)

But in the end it remains: a LoadBalancer for shared ingress is missing.
IP assignment via BGP seems to work in dedicated mode.
Any Ideas how to further debug this issue?
Here is a log with activated debug mode while dedicated ingress should be applied.
logs-cilium-z2mcs-cilium-agent-20230123-002546.zip
Here the shared config and result
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: news-ingress
  namespace: news
  annotations:
    io.cilium.ingress/loadbalancer-mode: shared
spec:
  ingressClassName: cilium
  rules:
    - host: news.kube2.domain.local
      http:
        paths:
          - backend:
              service:
                name: url-service
                port:
                  number: 5000
            path: /api/url
            pathType: Prefix

# kubectl get service -A
NAMESPACE     NAME                          TYPE           CLUSTER-IP      EXTERNAL-IP     PORT(S)                      AGE
default       kubernetes                    ClusterIP      <IP_ADDRESS>       <none>          443/TCP                      5h47m
kube-system   hubble-peer                   ClusterIP      <IP_ADDRESS>    <none>          443/TCP                      3h32m
kube-system   hubble-relay                  ClusterIP      <IP_ADDRESS>    <none>          80/TCP                       3h32m
kube-system   hubble-ui                     ClusterIP      <IP_ADDRESS>   <none>          80/TCP                       3h32m
kube-system   kube-dns                      ClusterIP      <IP_ADDRESS>      <none>          53/UDP,53/TCP,9153/TCP       5h47m
kube-system   metrics-server                ClusterIP      <IP_ADDRESS>   <none>          443/TCP                      5h47m
news          cilium-ingress-news-ingress   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>   80:31003/TCP,443:32150/TCP   95s
news          url-service                   ClusterIP      <IP_ADDRESS>   <none>          5000/TCP                     3h31m

Here in dedicated mode:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: news-ingress
  namespace: news
  annotations:
    io.cilium.ingress/loadbalancer-mode: dedicated
spec:
  ingressClassName: cilium
  rules:
    - host: news.kube2.domain.local
      http:
        paths:
          - backend:
              service:
                name: url-service
                port:
                  number: 5000
            path: /api/url
            pathType: Prefix

# kubectl get service -A
NAMESPACE     NAME             TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)                  AGE
default       kubernetes       ClusterIP   <IP_ADDRESS>       <none>        443/TCP                  5h48m
kube-system   hubble-peer      ClusterIP   <IP_ADDRESS>    <none>        443/TCP                  3h32m
kube-system   hubble-relay     ClusterIP   <IP_ADDRESS>    <none>        80/TCP                   3h32m
kube-system   hubble-ui        ClusterIP   <IP_ADDRESS>   <none>        80/TCP                   3h32m
kube-system   kube-dns         ClusterIP   <IP_ADDRESS>      <none>        53/UDP,53/TCP,9153/TCP   5h47m
kube-system   metrics-server   ClusterIP   <IP_ADDRESS>   <none>        443/TCP                  5h47m
news          url-service      ClusterIP   <IP_ADDRESS>   <none>        5000/TCP                 3h32m

It's weird that shared LB service is not created in your case, do you use the helm chart version aligned with cilium version?
Here is the related manifest for shared LB service.
https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/templates/cilium-ingress-service.yaml

Today I tried out helm instead of cilium-cli for installation. Also switched to rc5
Now it's working as expected
NAME             TYPE           CLUSTER-IP      EXTERNAL-IP     PORT(S)                      AGE
cilium-ingress   LoadBalancer   <IP_ADDRESS>    <IP_ADDRESS>   80:31154/TCP,443:31113/TCP   20m
hubble-peer      ClusterIP      <IP_ADDRESS>   <none>          443/TCP                      20m
hubble-relay     ClusterIP      <IP_ADDRESS>    <none>          80/TCP                       20m
hubble-ui        ClusterIP      <IP_ADDRESS>   <none>          80/TCP                       20m
kube-dns         ClusterIP      <IP_ADDRESS>      <none>          53/UDP,53/TCP,9153/TCP       5d23h
metrics-server   ClusterIP      <IP_ADDRESS>   <none>          443/TCP                      5d23h


Crash on Mac OSX 10.8.5

Hey,
the Download version of OSCRouter crash on my Mac System direct at the startup.
My System:
Mac Pro 2 x 2,4GHz Quad-Core Xeon
6 GB Ram
Mac OSX 10.8.5
any Ideas ?
Greetings Peer

Hey Peer,
Oops, the crash was happening in a call to suppress AppNap, which did not exist in OSX 10.8.5 or earlier.  I just published a new release with the fix...
~Chris

You are awesome !
The fix work Perfect !
Thx
Peer

Am 18.02.2016 um 18:10 schrieb Chris Mizerak<EMAIL_ADDRESS>Hey Peer,
Oops, the crash was happening in a call to suppress AppNap, which did not exist in OSX 10.8.5 or earlier. I just published a new release with the fix...
~Chris
—
Reply to this email directly or view it on GitHub.

:thumbsup:


[New Product] Spring Boot

Implement Sprint Boot eol based on Spring Boot support page :

It replaces https://github.com/endoflife-date/endoflife.date/pull/1807

Made some minor changes and dropped 3.0 release cycle for now. We only list stable releases, v3 is still at RC stage.

Made some minor changes and dropped 3.0 release cycle for now. We only list stable releases, v3 is still at RC stage.

Yes, thanks a lot, I did not know how to really good handle this. Thanks a lot for your kind and useful feedbacks for the newibe I am on this project. 🙏

😸 🚀


:wrench: Basic support for MAS builds

Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[ ] Commit message has a short title & issue references
[ ] Commits are squashed
[ ] The build will pass (run npm test).

More info can be found by clicking the "guidelines for contributing" link above.

Current coverage is 83.75% (diff: 100%)

Merging #203 into master will decrease coverage by 0.22%

@@             master       #203   diff @@
==========================================
  Files            44         44
  Lines           949        948     -1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            797        794     -3
- Misses          152        154     +2
  Partials          0          0

Powered by Codecov. Last update 7d23435...2ebd6e6


Wrong title being pasted when fetching multiple titles at once

I've tried to fetch one url title before another fetch was done, which resulted in both titles being the same and hence one title being wrong.

Hm, this used to work, I'm in a bit of crunch time at the moment but I'll check into this as soon as I can!

Came here to file the same issue -- noticed it in particular with the "enrich existing url" feature.

@zolrath I have an example fix for this here. If I get around to cleaning it up, I'll submit a pull request.


Deliver Early Adopter onboarding workshop for Traveler Screening (Health) team

Describe the issue
We've designed two half-day workshops to introduce our team to the Early Adopter teams, and provide background on what we've set up in the way of Landing Zone, KeyCloak, Infrastructure-as-Code, Corporate PIA and STRA .. etc. Also review the Early Adopter Submission, Service Blueprint, Shared Responsibilities Model, and discuss how we propose to work together - all aimed at getting our Early Adopter Program off to a good start.
Which Sprint Priority is this issue related to?
The 'Milestone' should clearly list Sprint Priorities - which one is this issue related to?
Additional context
Add any other context, attachments or screenshots
Definition of done

workshops conducted and feedback gathered on what the Early Adopters liked, and any suggestions they might have for improvements
capture notes on how it all went

@ActionAnalytics could we include the miso/security teams as part of these workshops also?


Enable use of git 1.7

The --set-tracking call during git new-fb is new in git 1.8. That means that machines that still have git 1.7 break during this call.

git 1.7 is EOL


Add a way to see links not read yet

Hello,
I follow a lot of blogs but I have to go through each directory to see if there are any new article.
It would be nice to have a way to have all links in the same directory maybe or small icons on directories where updates are available.
Let me know if I'm not clear enough.
Thanks

Hi, thanks for the suggestion. Does turning on the "Show on folders when all their items are read/unread" setting provide the functionality you need?

Hello,
Yeah it should be good I guess :)

Cool, thanks! :) I'll close the issue for now, let me know if you need anything else!

Perfect thanks :) I'm waiting for the other one I'm currently watching :)


FIX: Qt toolbar

This PR fixes Qt toolbar callbacks (e.g. in Brain):
Using pyvistaqt 3d backend.

Traceback (most recent call last):
  File "/home/guillaume/source/mne-python/mne/viz/backends/_qt.py", line 428, in callback
    weakself.app_window,
AttributeError: '_Renderer' object has no attribute 'app_window'

It also adds a test to avoid regression and does simple refactoring of 'actions' (Qt name for callables which can have an icon and shortcut).

thx @GuillaumeFavelier
can you see why CIs complain?

I can reproduce locally, I'll fix it

thx @GuillaumeFavelier
can you add a what's new entry ? 🙏

Thanks @GuillaumeFavelier !


Wrong version in simdutf_version.h

The latest tag is v1.0.0 but the version in simdutf_version.h is 0.1.0.
A comment in simdutf_version.h says that the version should not be changed by hand but it seems the release.py script is also missing.

Thanks for the report. Fixed.

It seems this one https://github.com/simdutf/simdutf/blob/d1bef814dc4331bb8d06a40ee84f966c43650661/include/simdutf/simdutf_version.h#L7 is still incorrect.


operations like getpoint or stats are stalled when using them from irb

Hi
To report that when I call getpoint or stats in the irb console, the console stalls and need to interrupt with ctrl-z
I load an image with Active Storage:
p = Picture.first
im = Vips::Image.new_from_file ActiveStorage::Blob.service.send(:path_for, p.image.key), access: :sequential
then I just call im.getpoint(0,0) and the console gets blocked.
Also if I call im.stats I obtain the same behavior
My dev stack is:

Libvips 8.11
Rails <IP_ADDRESS>
Ruby-vips 2.1.2
working on zsh
using Apple Silicon

Hi @stoicdavid, I'm sorry you're having trouble.
It sounds like a weird one -- it's fine for me. Unless there's some way I can reproduce this I'm not sure I can help.
john@banana ~ $ irb
irb(main):001:0> require 'vips'
=> true
irb(main):002:0> x = Vips::Image.new_from_file "/home/john/pics/k2.jpg", access: :sequential
=> #<Image 1450x2048 uchar, 3 bands, srgb>
irb(main):003:0> x.getpoint(0, 0)
=> [11.0, 1.0, 0.0]
irb(main):004:0>

john@banana ~ $ gem info ruby-vips

*** LOCAL GEMS ***

ruby-vips (2.1.2, 2.1.1, 2.1.0)
    Author: John Cupitt
    Homepage: http://github.com/libvips/ruby-vips
    License: MIT
    Installed at (2.1.2): /home/john/packages/gems
                 (2.1.1): /home/john/packages/gems
                 (2.1.0): /home/john/packages/gems

    A fast image processing library with low memory needs
john@banana ~ $ irb --version
irb 1.2.6 (2020-09-14)
john@banana ~ $ ruby --version
ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux-gnu]
john@banana ~ $ vips --version
vips-8.11.1-Wed Jun 23 11:25:51 UTC 2021

There is a known issue in 8.11.0 with modules. You could try disabling libvips modules.
VIPSHOME=/usr/local/

Though I don't know if that'll fix the issue you're seeing.

Thanks will try now and let you know

Thanks @jcupitt, my issue appears in the rails console, I tested directly using an irb session using your same example and worked!
Then I thought it has something to do with the rails console and noticed that Spring preloader is the one causing the issue, I disabled the gem in my gemfile and then re-tried getpoint and stats in the rails console and worked.
I tried the installation disabling modules but I observed the same behavior in the rails console, so the module issue is unrelated.
I am checking now what is going on with Spring, I've recently upgrade into rails <IP_ADDRESS> will try with previous versions of rails and see if that works, also just noticed that rails released a newer version 6.1.4 so perhaps that might fix things. Will let you know...

Ah then I expect it's a fork problem.
You can't mix fork and threads in the same process, or at least only with great care. After a fork(), the parent stays in the same state (all running threads still there, all locks and signals still working), but the child starts with just one thread and all the thread structures (locks etc.) in whatever state they were at the time of the fork. So if a mutex is locked when the fork happens, the child will block and never unblock when it hits it.
Rails servers starts up everything, then when a request comes in, forks a child process to handle it. If ruby-vips is initialised at server startup, then the child process will not work. You need to switch off the pre-fork system, or only init ruby-vips when you start to handle a request.
This is true for any gem which uses threads of course, not just ruby-vips.

Yes, spring will do this kind of fork-per-request trickery, you'll need to check the configuration there.

Thanks, will do some additional research later today and if I find something additional will post here for reference and close the issue. Many thanks

I think this is fixed in 8.11.3. Sorry for the regression.

Thanks! tested it and it works!
For the sake of curiosity what was causing the issue? was it something related with the Spring preloader?

That's great! Thanks for testing, @stoicdavid.
The problem was that 8.11 has a new threading system, it was being started up on vips_init(), and that was being called on process start. Some time later, spring would fork the process to become a request handler, and all thread state breaks on fork.
The fix was just to delay threadpool creation until first use.


400 text : Bad Request on user provisioning to salesforce

Moved from https://wso2.org/jira/browse/IDENTITY-7237

Add an IdP with salesforce provisioning enabled. [2]
Enable outbound provisioning in resident service provider and select above created IdP as the provisioning connector.
Add user using UI - Do not select the role. just click finish

User is added to local user store without any issue. But it's not provisioned to salesforce.
Error:
recieved response status code :400 text : Bad Request

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Coffee Bush Genertation on Server

Hi,
I'm struggling to get coffee bushes to generate on a server.
Locally on the same seed I can find them pretty easily. I don't see anything in the logs to suggest Caffeinated hasn't loaded correctly. I'm using the same version of Farmer's Delight both locally and on the server.
Dropping into Creative Mode on the server I can find the associated items with the plugin so I believe it's loaded.
Is there anything else I can do to check my end that it's working correctly, to help troubleshoot what the issue might be?
Any help would be greatly appreciated.
Many Thanks

Hi, thanks for reaching out - what version of Caffeinated are you using and what Minecraft version are you on? Also, are there any mods you've installed that may tweak world generation? Issues related to this should be fixed on the latest version for 1.21.x unless I missed something.

Found the issue :)
I had just listed my client and server version. Went to then list the mods on the server. And highlight any world-gen mods. Noticed I had 2 versions of Geophilic installed. Complete missed this before.
Removed the older of the two versions, and restarted the server. Generated some new forest chunks and Coffee bean shrubs have generated.
Sorry to have wasted your time.

Oh no worries! Glad you were able to figure it out!


Enable custom training job in SageMaker plugin

TL;DR
Please replace this text with a description of what this PR accomplishes.
Type

[ ] Bug Fix
[x] Feature
[x] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

Codecov Report

Merging #113 into master will increase coverage by 0.69%.
The diff coverage is 64.55%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   58.70%   59.40%   +0.69%
==========================================
  Files          99       99
  Lines        5936     5956      +20
==========================================
+ Hits         3485     3538      +53
+ Misses       2103     2067      -36
- Partials      348      351       +3

Impacted Files
Coverage Δ

go/tasks/plugins/k8s/sagemaker/sagemaker.go
59.18% <56.86%> (+10.15%)
:arrow_up:

go/tasks/plugins/k8s/sagemaker/utils.go
61.90% <78.57%> (-0.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4e8b5...4de7787. Read the comment docs.

@bnsblue can we update the description?

@bnsblue This is awesome work! Thank you. Couple comments from my side

Would you mind elaborating some of your comments?
Also could you please take another look? @kumare3

Will do

@kumare3 please take another look


Heavy requests with logging causes Timezone issue

Whenever I give the webserver a heavy load, it fails after a while with a Timezone exception:
(SystemError("unable to read directory /home/gearsad/.julia/packages/TimeZones/JvOCz/deps/compiled", 24, nothing),
Base.StackTraces.StackFrame[readdir(::String) at file.jl:620,
timezone_names() at discovery.jl:15,
localzone() at local.jl:28,
Type at formatters.jl:35 [inlined],
#config!#71(::String, ::Dict{AbstractString,Int64}, ::Bool, ::Bool, ::Bool, ::Bool, ::Function, ::Logger, ::String) at config.jl:39, #config!#69 at config.jl:36 [inlined], config! at config.jl:25 [inlined], #config#72(::Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::String) at deprecated.jl:55, config(::String) at deprecated.jl:54, log(::String, ::Symbol) at Loggers.jl:41,
setup_http_handler(::Request, ::Response) at AppServer.jl:54, #2 at AppServer.jl:24 [inlined], handle at Handlers.jl:35 [inlined], #7 at Servers.jl:163 [inlined],
handle_request(::##7#11{Server{http,HandlerFunction{##2#7}}},
::Stream{Request,Transaction{TCPSocket}}) at Servers.jl:510,
handle_stream(::##7#11{Server{http,HandlerFunction{##2#7}}},
::Stream{Request,Transaction{TCPSocket}}) at Servers.jl:486,
(::##55#56{Bool,##7#11{Server{http,HandlerFunction{##2#7}}},Transaction{TCPSocket},Stream{Request,Transaction{TCPSocket}}})() at task.jl:259])

It looks like this is happening because this is called each log(): https://github.com/essenciary/Genie.jl/blob/master/src/Loggers.jl#L41
I've changed out my calls from log("message", :info) to @info "message to work around this, but wanted to document the issue in case anyone else sees it.

As a best practice, do you suggest we use log() calls or @info / @debug?
I don't think Genie should be reinitialize Memento each log(), could this possibly be done on initialization?

@GearsAD Thanks - I need to look at a different logging package, I think. Memento is the 3rd one I tried and it doesn't work well with Genie.
Can you please detail what "heavy load" means so I can try to replicate the issue? I think it's time to look at revamping logging.
The reasoning behind log() is to have a higher level logger which allows more granular logging by default. Like say logging to REPL and logging to file, with different verbosity levels (we don't want to end up with GB size file logs in a few hours) and environment-aware (in prod log only errors).

Thank you!


Missing Matches Data with The Game Server of China

The Chinese Server data is missing today.
For example, I just played a blitz match

But the API not listed the match. The lasted data is 1 day ago.
Some others sent feedbacks to me for their missing data.
Sent from my OnePlus ONEPLUS A5000 using FastHub

Hey Team - This is a duplicate of #232


Update mod_doh documents and config file.

Codecov Report

Merging #501 into develop will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #501      +/-   ##
===========================================
- Coverage    53.28%   53.26%   -0.03%
===========================================
  Files          250      250
  Lines        23319    23319
===========================================
- Hits         12426    12421       -5
- Misses        9450     9451       +1
- Partials      1443     1447       +4

Impacted Files
Coverage Δ

bfe_modules/mod_doh/conf_mod_doh.go
50.00% <0.00%> (ø)

bfe_spdy/frame_write.go
49.49% <0.00%> (-2.03%)
:arrow_down:

bfe_http2/server.go
71.50% <0.00%> (-0.33%)
:arrow_down:

bfe_websocket/server_conn.go
76.51% <0.00%> (+2.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04893fe...20f0acd. Read the comment docs.


Add className for markdown results

Purpose
Address #1632
Approach

Separate markdown results from others in lib/display.js and add className to the markdown component
Tweak styles for it

Step 1. appears very clumsy, but still it works like this:

Alternative approach
If @nteract/output starts to support adding custom className for each Media component, the code would be more cleaner.
Misc
I also beautified indentations in hydrogen_style.less

I understand that an if statement does work here, and I know I have been busy lately so I apologise. But the if statement adds unnecessary complexity. What you should do is create a new file for a new component that returns a div wrapped around the media.markdown class, and also make sure that the default props for the new component are the same as the default props of media.markdown

Check out the source code for the Markdown component. The code is very simple, so it would be easy to copy into a custom component here like @wadethestealth said. As long as the mediaType default prop stays the same you won't need an if statement and the custom component can replace the current markdown component in supportedMediaTypes

@wadethestealth @BenRussert
Thanks for your reviews !
I just modified the files according to your suggestions, and would appreciate you took a look.

I also removed react-hot-loader dependency in the last commit: 71f85b2.
I confirmed Hydrogen works after a clean installation.

Approved