Add thread level to csv output.

Hello,
I am an infrastructure engineer on the performance team at MongoDB and we are using Linkbench as part of our performance testing. After a Linkbench task is run, we need to parse the results and the thread levels used. It would be cleaner to have the thread levels in the csv file along with the results. I think this would be helpful to many users of Linkbench, and at the very least won't hurt them as it is backwards compatible.
Thanks,
Julian

Thank you for your pull request. I am not sure that this repo has a maintainer, thus it was moved into github.com/facebookarchive and it might be read-only. My linkbench fork is still active at https://github.com/mdcallag/linkbench

Mark,
Thanks for responding! Should I make the PR to your fork instead then?
Best,
Julian
On Mon, Jun 18, 2018 at 1:47 PM, Mark Callaghan<EMAIL_ADDRESS>wrote:

Thank you for your pull request. I am not sure that this repo has a
maintainer, thus it was moved into github.com/facebookarchive and it
might be read-only. My linkbench fork is still active at
https://github.com/mdcallag/linkbench
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebookarchive/linkbench/pull/35#issuecomment-398138417,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APy5ACYKjbg-2QKza_pvFLPROWaoe3DPks5t9-eWgaJpZM4Um7IJ
.

yes
On Mon, Jun 18, 2018 at 3:42 PM, julianedwards<EMAIL_ADDRESS>wrote:

Mark,
Thanks for responding! Should I make the PR to your fork instead then?
Best,
Julian
On Mon, Jun 18, 2018 at 1:47 PM, Mark Callaghan<EMAIL_ADDRESS>wrote:

Thank you for your pull request. I am not sure that this repo has a
maintainer, thus it was moved into github.com/facebookarchive and it
might be read-only. My linkbench fork is still active at
https://github.com/mdcallag/linkbench
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/facebookarchive/linkbench/
pull/35#issuecomment-398138417>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APy5ACYKjbg-2QKza_
pvFLPROWaoe3DPks5t9-eWgaJpZM4Um7IJ>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebookarchive/linkbench/pull/35#issuecomment-398218263,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABkKTceeRu9tv0AGRQ_IFb-31zxLEUD4ks5t-CzfgaJpZM4Um7IJ
.

--
Mark Callaghan
<EMAIL_ADDRESS>


wasp mode of STAR

You should incorporate STAR's WASP mode into the pipeline.

This will involve adapting jing's code into Snakefile-WASP. You may specifically want to look at the star_plus_WASP rule.

new idea: keep Snakefile-WASP but also create an alternative Snakefile, Snakefile-WASP-STAR using Jing's Snakefile

Turns out we haven't yet figured out how to correctly run the WASP mode of STAR. For some reason, none of the output vW tags are 1, indicating that none of the reads passed WASP filtering.
In any case, I'm going to close this issue until we figure it out. If we ever do, we should just be able to switch out Snakefile-WASP for a different Snakefile. Perhaps "Snakefile-STAR"?


Minor tweak to initial description

Added verbiage indicating the service is an HTTP-based service since customer questions arise from time to time about whether App Service handles TCP/IP based traffic (which it doesn't).

@stefsch : Thanks for your contribution! The author(s) have been notified to review your proposed change.

verified edits


Radio and multi checkbox types do not receive formControl or errorExistsAndShouldBeVisible

First: I'm not sure if this is specific to this template library or if it's something that should be addressed in the main Formly repo. If you'd like me to migrate this issue to the main repo, please let me know.
Here's a JS Bin showing the issue: http://jsbin.com/naqaqaguma/2/edit
As you can see, my "input" type field received a formControl object and the errorExistsAndShouldBeVisible key in validation. The other two, however, did not.
Through the excessive use of debugger statements, I believe I've located the problem in the watchFormControl function in formly-field.js. Specifically, the function exits early due to lines 196-199 because Formly can't locate the ng-model attribute in the element. This prevents Formly from adding the watchFieldExistence and addShowMessageWatcher watchers, which set formControl and errorExistsAndShouldBeVisible, respectively.
By examining the element at this point in the execution, it appears that the actual inputs have not yet populated via ng-repeat, so there is no ng-model for Formly to find.
I'm at a bit of a loss with regards to a solution because it seems like it's a timing issue with directive compilation. Perhaps the directive could be compiled prior to Formly starting its watches?

What if you were able to set noFormControl: false explicitly and that would cause formly to add the watcher anyway. I think this would work. Would that be acceptable?

Doesn't appear to make a difference - I tried setting it on the field as well as creating a custom type with the option set: http://jsbin.com/tonelumepu/2/edit

Sorry, what I meant was, what if I made it work that way (doesn't currently). Do you think that would be a reasonable API to use?

Sure, that sounds perfectly reasonable.

Alrighty, I think I've got it working in angular-formly 6.3.3 and the templates 4.0.8. Let me know if you have trouble!

Looks to be working well for me, thanks!

So, I've figured out a better way to accomplish this. You no longer will need to specify noFormControl: false :-) Look forward to<EMAIL_ADDRESS>:-)


chore: fix some typos

Please provide a description of this PR:
fix some typos
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @deterclosed. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test


--format from file

Is your feature request related to a problem? Please describe.
For a long format string it would be a convenient to load it from file, not only provided as a parameter.
Describe the solution you'd like
Add a new parameter: --format-file <format-file>
Describe alternatives you've considered
No alternatives were considered for this feature.
Additional context
Templates can be quite complicated, especially when using range, if etc. I am trying to get information from a json to csv. The dasel cannot reference parent's node properties, so I needed to use range from template.
Even the simplest template is unreadable, when using --format :
dasel select -f x.json -m '.[*]' --format '{{$id:=._id}}{{range $i:=.controlledBy}}{{printf "%s,%s\n" $id $i.zoneId}}{{end}}'

I've just seen this - I agree that this could be very useful. I'd be happy to support this in the future.

Closing this as --format isn't supported in v2.
When I implement a relatable feature there I will include this functionality.


Add tests

There were similar tests in HHVM-2015-02-19, however the API has changed. Something similar should be done.

They're present again in HHVM.


Error permalinks

Content links that back each error code from the errors spec: https://github.com/prisma/specs/tree/master/errors
The error message will contain a clickable link to each error.
To discuss: Initially, this can be pris.ly links backed by the spec itself.

Update: Waiting for implementation.

Internal Note: Dropping because docs writing has priority.

Errors and error codes now have permanent links at https://www.prisma.io/docs/reference/api-reference/error-reference - but they really just show the same text as the actual error message right now, no additional information.


Missing information on exporting vulnerability assessment results

Please add instructions on how to export vulnerability assessment results to this documentation. You can find the information on this TechCommunity post from yesterday, but it would be helpful to include that information (or at least a link to the TechCommunity post) here in the official documentation page: https://techcommunity.microsoft.com/t5/azure-security-center/exporting-vulnerability-assessment-results-in-azure-security/ba-p/1212091

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 747a2c52-c59c-dedc-9c72-6b6352ea2cab
Version Independent ID: 07e64d3e-26da-be39-de53-6e259c90545f
Content: Built-in vulnerability scanner in Azure Security Center
Content Source: articles/security-center/built-in-vulnerability-assessment.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@skeeler Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

The article has now been updated to include info about the ARG export. Thanks for the feedback!
#please-close


Integration Test - Release - 2019/05/08 12:39:46

Auto create for integration test. DocfxAuthorMetadataFlow

@bharney-msft : Thanks for your contribution! The author, @bharney, has been notified to review your proposed change.


Update playbook to support latest ansible

Updated your scripts to be compatible with ansible galaxy playbooks distribution
Left only necessary tasks for installation and configuration
Please let me know if you are interested in such update. For now - we are using our version deployed to galaxy. Happy to revert your license/copyright, allow you to publish playbook in ansible and drop our version.

Hey, any updates on this?

Good day @volodymyr-mykhailyk,
Thanks for your contribution and effort to improve this playbook.
We have reviewed your changes and aggregating part of functionality into these two pull requests: #2 #4
What have been incorporated:

Add Windows support.
Restructure playbooks in order to publish to Ansible Galaxy.
Merge playbooks except install and activate into one for simplicity.
Instead of using many var files to determine the install path, decide path in the tasks.
By default won't perform activation if already in activated state. Unless "force_reactivation" attribute is set to true.
Additional changes:
Support upgrade if downloaded installer is newer than installed version.
Separate install and activate into different tasks.

What we don't aggregate:

Template usage
Currently for Windows platform, our playbooks take advantage of Ansible Windows support so that we don't have to execute ps1 directly.

We are looking for collaboration with you in the future. We will close this PR now.
Thanks.


New version for Xcode 7.3

As Xcode 7.3 is released and _stdlib_getDemangledTypeName unresolved error is merged to master could you please create new version?

pod updated


Making the project stack friendly and minor cleanup.

First of all, thanks for all the great work on the library 👏
I noticed it is being referenced on the NSQ page, but due to its rapidly progressing dependency libraries, it is severely out of sync with their latest versions. Since it's significantly easier to build the project when it's compatible with Stack, I updated it to fit in the Stack formula.

Thanks :)


[Build] Upgrade Apache parent pom version to 23

Motivation

The current version of Apache Parent POM in use is version 18. It is from May 2016

Modifications

use most recent version 23 from January 2020

/pulsarbot run-failure-checks

This change may impact the list of jars that we bundle into the binary tarballs and in general the execution of the build.

Wouldn't the build fail in the src/check-binary-license script if this would happen?

It may also impact the release procedure.

How? Any details of what the impact could be? It's probably something that should be addressed sooner or later. Version 18 is from May 2016. That's ancient. :)

My point is only about the fact that we are upgrading a few Maven plugins, so the results may be different.
This in general happens if we do not set explicitly a version for all of the plugins that we are using.
Most notably the shade and assembly plugin sometimes introduce changes, but we are already setting our own favourite version.
If CI validation passes then we are on our way.
I just wanted to say my 'heads up', as PR that does not change code sometimes are not taken much into consideration but they may have an effect anyway (usually a positive effect)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

This PR depends on #10007

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@merlimat @aahmed-se @sijie @codelipenghui @jerrypeng @zymap @rdhabalia  Please review this change. This PR is finally ready for review.


Make region mandatory in the KEB schema

Description
Make region input parameter mandatory in the KEB schema.
Reason
Users provision SKRs without selecting a region, then some default region is in use. Then after a while, they are surprised.
AC

[x] 1) Adjust KEB schema to make input parameter region mandatory.
[x] 2) Keep KEB defaulting if input parameter is not provided. This is backward compatibility for users that use for example BTP CLI.
[ ] 3) test on DEV with BTP cockpit and BTP CLI

Links

current defaults: https://help.sap.com/docs/btp/sap-business-technology-platform/available-plans-in-kyma-environment?q=Kyma

PR: https://github.com/kyma-project/kyma-environment-broker/pull/42

OpenStack plan was missing the default region eu-de-2 in the schema and it has been added.

We decided to remove KEB defaulting the region. The region will always be required.

[ ] Update docs how to provision with the region required


build replicate-forked prereleases

the failed checks don't make sense here - the release/publish-image failure doesn't matter because I've since changed the workflow to not build on branches (only tags); I have no idea why lint is failing because I didn't touch that.


[HOTFIX] fix flaky test in PySpark SQL

It may loss precision in microseconds when using float for it.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #1040 has started for   PR 7344 at commit 249ec61.

Test build #1040 has finished for   PR 7344 at commit 249ec61.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

It was merged already.

Added.


[Q] salesforce static resource - unable to load the javascript library exceljs > 1.15.0 as static resource

I have trying import the javascript library "exceljs" as static resource in my lightning web component using "loadScript" method, the exceljs version 1.15.0 is working fine. But when I add any version higher than 1.15 the load method is unable to import the library, can the error value in the catch block of the loadScript promise is coming as "undefined". Please help me understand what are the possible reason for this behaviour and provide a way to use the latest version of the exceljs as the static resource.
Source:
Version 1.15.0
Version 4.1.1

latest version works -  4.3.0

Is this resolved?

Hi,
We found the same issue when trying to load the library as a static resource in Lightning Web Components, and also, in Aura components, library was not loading. This seems to be related to this line of the regenerator-runtime source code. We have tested generating the ExcelJS bundle (with npm run build) and then "hacking" it by modifying that line:
window.regeneratorRuntime = runtime;

In our case, we have both strict mode and CSP. According to the comments right below that line, a possible solution may be running that code without the strict mode. This would involve changing the ExcelJS bundler somehow.


Add container 'run' command

The new run command can be used as convienence wrapper to the workflow
of:

Creating a pod
Creating a container within this pod
Starting the container within the pod

I've wanted this long time ago! Thanks!

/lgtm
/approve

cool, thanks for adding this feature.


How can I control the panel width (using MVVM)?

Hi,
consider the following layout:
                <uniDock:StackDockGroup TheOrientation="Horizontal">

                    <uniDock:StackDockGroup DockId="Left" IsStableGroup="True" TheOrientation="Horizontal" />
                    <uniDock:TabbedDockGroup DockId="Tabs" IsStableGroup="True" />
                    <uniDock:StackDockGroup DockId="Right" IsStableGroup="True" TheOrientation="Horizontal" />

                </uniDock:StackDockGroup>

Right now, adding a panel to the Left group will split the view in 50/50. In a typical explorer style or Visual Studio style app, the left and right panels are somewhat smaller (let's say 20% initially). Can I somehow control the size (width) of a panel after I added it to a StackDockGroup?
Bonus question: at the moment, a window resize is causing to resize all panels proportionally. Is there a way to keep a group at the same width? In the above example, the Left and Right group should stay the same size (width) but the tabs adapt to the new window size?
Thanks,
Stefan

I'll have to look, do not remember off my head. I'll answer you on Sunday.

Yes, it is possible to do it. The parent StackDockGroup can define e.g. InitialSizeCoefficients="250 * 250", e.g.
		<np:StackDockGroup x:Name="TheStackGroup"
						   TheOrientation="Horizontal"
						   IsStableGroup="True"
						   Margin="20"
						   **InitialSizeCoefficients="250 * 250"**>

Note there should be no commas between the coefficients (only spaces) and they should be in GridLength format - in the same way in which e.g. Avalonia Grid defineds its columns or rows.
If I remember correctly, adding extra sub items to the panel will continue according to the same rule - 50/50 of the last pane, but the first 3 panes should always be 250, then whatever is left, and then 250 again.

I've added a new sample to NP.Ava.UniDock repository - Prototypes/NP.DockItemsWidthSample that demos it.

Stefan, please close the issue if you question is answered. Thanks

Hi Nick,
I tried but somehow I can't get it to work in my app.
My code from above now looks like this:
<uniDock:StackDockGroup TheOrientation="Horizontal" IsStableGroup="True" InitialSizeCoefficients="250 * 250">
    <uniDock:StackDockGroup DockId="Left" IsStableGroup="True" TheOrientation="Horizontal" />
    <uniDock:TabbedDockGroup DockId="Tabs" IsStableGroup="True" />
    <uniDock:StackDockGroup DockId="Right" IsStableGroup="True" TheOrientation="Horizontal" />
</uniDock:StackDockGroup>

Note that my panels and tabs are put into the dock groups using MVVM. Initially, I only put one panel to the Left dock group and it still is 50/50.
Also, I tried the sample app but I think there's once again something messed up with the sub modules. I can't really fetch/pull the repo anymore and git spits out the following error:
fatal: No url found for submodule path 'SubModules/NP.IoCy/SubModules/NP.Utilities' in .gitmodules
fatal: Failed to recurse into submodule path 'SubModules/NP.IoCy'

Hi Nick,
I've uploaded a repro project here (based on the ViewModelSample):
https://github.com/StefanKoell/Misc/tree/main/src/NP.ViewModelSample
In the MainWindow.axaml I've created the StackDockGroup as mentioned above.
In the code behind I'm adding a left panel and a couple of tabs.
Note that I don't add a right panel. I defined the right panel but didn't add anything. In my "real world app", the right panel is used if the user chooses to add a specific panel to the right at a later point in time.
Regards,
Stefan

Thanks Stefan, I'll take a look over the weekend.


Implement modular communication protocol that can be used by this and ROS

Feature description
We should have one canonical source for the command spec with expected inputs and config keywords
The ideal solution
Store a large yaml file with the command spec, where each command is a dictionary with several important fields, and command objects are stored in a large list. We could also use this spec for validation of incomming and outgoing commands (e.i. do they exist, do they have the right number of arguments, etc.). This would also let us define defaults on a per-command basis.
Alternatives?
There are probably many ways to implement this, but unclear what way is the best.
Will this require substantial changes to the codebase?
Not really. We just need to read in this yaml file in the "config" script.

This workflow has been implemented and confirmed working in ROS, but now needs to be tested in straight python.


🚧 Undefined value

Codecov Report

Merging #661 (0a92ace) into main (e7108e8) will decrease coverage by 0.04%.
The diff coverage is 73.07%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   93.90%   93.86%   -0.04%
==========================================
  Files          99       99
  Lines       13756    13782      +26
  Branches       25       25
==========================================
+ Hits        12917    12936      +19
- Misses        833      840       +7
  Partials        6        6

Impacted Files
Coverage Δ

pydantic_core/__init__.py
81.81% <ø> (ø)

src/validators/model.rs
98.77% <ø> (ø)

src/argument_markers.rs
81.03% <72.00%> (-6.85%)
:arrow_down:

src/lib.rs
100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7108e8...0a92ace. Read the comment docs.


Feat:Create a contributors page

Describe the feature
Proposed solution:
Implement a contributors page which will be routed on the navbar, this page shall have the avatar of all the contributors in the form of cards along with links which shall redirect the user to their github accounts.
The avatar and the link will be beautifully aligned in different cards.The contributors will be placed in descending order of the pr's made to the project.
Add ScreenShots
nil
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

I would like to work on this issue under gssoc'23

We could create a link in the footer under contact us that would redirect to the contributors page, what do you think


make -j126 failed about<EMAIL_ADDRESS>on centos8_x86_64

Describe the bug (描述bug)
[root@localhost build]#cmake .. -DBUILD_UNIT_TESTS =ON
CMake Error: Parse error in command line argument: -DBUILD_UNIT_TESTS
Should be: VAR:type=value

CMake Error: Problem processing arguments. Aborting.

[root@localhost build]#cmake .. -DBUILD_UNIT_TESTS=ON
-- The C compiler identification is GNU 8.5.0
-- The CXX compiler identification is GNU 8.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at cmake/FindGFLAGS.cmake:37 (message):
  Could not find gflags library.
Call Stack (most recent call first):
  CMakeLists.txt:75 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/CMakeFiles/CMakeOutput.log".
[root@localhost build]#. ../../spack-build-env.txt
[root@localhost build]#cmake .. -DBUILD_UNIT_TESTS=ON
CMake Deprecation Warning at CMakeLists.txt:18 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- The C compiler identification is GNU 8.5.0
-- The CXX compiler identification is GNU 8.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found gflags: /home/spack/opt/spack/linux-centos8-skylake_avx512/gcc-8.4.1/gflags-2.2.2-4fkmr4ydgvpvxutqlg2dx5qvrm3wejt4/lib/libgflags.so
-- Found Protobuf: /home/spack/opt/spack/linux-centos8-skylake_avx512/gcc-8.4.1/protobuf-3.12.2-erunnl2vwbtdkv6btnglgrl3bprm3cwj/lib64/libprotobuf.so;-lpthread (found version "3.12.2")
-- Found Threads: TRUE
-- Found OpenSSL: /home/spack/opt/spack/linux-centos8-skylake_avx512/gcc-8.4.1/openssl-1.1.1j-sd3cphltvpn7w26oiva2h5jfj4lkegld/lib/libcrypto.so (found version "1.1.1j")
-- Found Gperftools: /home/spack/opt/spack/linux-centos8-skylake_avx512/gcc-8.4.1/gperftools-2.9.1-bzx6zug2mozykrqxgjgkpqn75ybcuzcm/lib/libtcmalloc_and_profiler.so
CMake Deprecation Warning at CMakeLists.txt:16 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Configuring done
-- Generating done
-- Build files have been written to: /home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-download
Scanning dependencies of target googletest
[ 11%] Creating directories for 'googletest'
[ 22%] Performing download step (git clone) for 'googletest'
Cloning into 'googletest-src'...
Note: switching to 'release-1.8.0'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at ec44c6c1 Merge pull request #821 from mazong1123/master
[ 33%] Performing update step for 'googletest'
[ 44%] No patch step for 'googletest'
[ 55%] No configure step for 'googletest'
[ 66%] No build step for 'googletest'
[ 77%] No install step for 'googletest'
[ 88%] No test step for 'googletest'
[100%] Completed 'googletest'
[100%] Built target googletest
CMake Deprecation Warning at build/googletest-src/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at build/googletest-src/googlemock/CMakeLists.txt:41 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at build/googletest-src/googletest/CMakeLists.txt:48 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.8")
-- Configuring done
-- Generating done
-- Build files have been written to: /home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build
[root@localhost build]#make -j126
……
[ 16%] Building CXX object test/CMakeFiles/BUTIL_DEBUG_LIB.dir/__/src/butil/files/scoped_temp_dir.cc.o
[ 16%] Building CXX object src/CMakeFiles/BUTIL_LIB.dir/butil/memory/ref_counted_memory.cc.o
In file included from /home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest.cc:142,
                 from /home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-all.cc:42:
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:429:11: error: 'string' does not name a type; did you mean 'String'?
   virtual string CurrentStackTrace(int max_depth, int skip_count) = 0;
           ^~~~~~
           String
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:449:11: error: 'string' does not name a type; did you mean 'String'?
   virtual string CurrentStackTrace(int max_depth, int skip_count);
           ^~~~~~
           String
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:635:31: error: 'testing::Test::SetUpTestCaseFunc' has not been declared
                         Test::SetUpTestCaseFunc set_up_tc,
                               ^~~~~~~~~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:636:31: error: 'testing::Test::TearDownTestCaseFunc' has not been declared
                         Test::TearDownTestCaseFunc tear_down_tc);
                               ^~~~~~~~~~~~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:645:26: error: 'testing::Test::SetUpTestCaseFunc' has not been declared
   void AddTestInfo(Test::SetUpTestCaseFunc set_up_tc,
                          ^~~~~~~~~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:646:26: error: 'testing::Test::TearDownTestCaseFunc' has not been declared
                    Test::TearDownTestCaseFunc tear_down_tc,
                          ^~~~~~~~~~~~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:911:13: error: 'scoped_ptr' in namespace 'testing::internal' does not name a template type
   internal::scoped_ptr<InternalRunDeathTestFlag> internal_run_death_test_flag_;
             ^~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:912:13: error: 'scoped_ptr' in namespace 'testing::internal' does not name a template type
   internal::scoped_ptr<internal::DeathTestFactory> death_test_factory_;
             ^~~~~~~~~~
[ 16%] Building CXX object src/CMakeFiles/BUTIL_LIB.dir/butil/memory/singleton.cc.o
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h: In member function 'void testing::internal::UnitTestImpl::ClearNonAdHocTestResult()':
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:703:36: error: 'ClearTestCaseResult' is not a member of 'testing::TestCase' {aka 'testing::TestSuite'}
     ForEach(test_cases_, TestCase::ClearTestCaseResult);
                                    ^~~~~~~~~~~~~~~~~~~
[ 16%] Building CXX object test/CMakeFiles/BUTIL_DEBUG_LIB.dir/__/src/butil/file_util.cc.o
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h: In member function 'void testing::internal::UnitTestImpl::InitDeathTestSubprocessControlInfo()':
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:751:5: error: 'internal_run_death_test_flag_' was not declared in this scope
     internal_run_death_test_flag_.reset(ParseInternalRunDeathTestFlag());
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:751:5: note: suggested alternative: 'internal_run_death_test_flag'
     internal_run_death_test_flag_.reset(ParseInternalRunDeathTestFlag());
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     internal_run_death_test_flag
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h: In member function 'const testing::internal::InternalRunDeathTestFlag* testing::internal::UnitTestImpl::internal_run_death_test_flag() const':
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:758:12: error: 'internal_run_death_test_flag_' was not declared in this scope
     return internal_run_death_test_flag_.get();
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:758:12: note: suggested alternative: 'internal_run_death_test_flag'
     return internal_run_death_test_flag_.get();
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            internal_run_death_test_flag
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h: In member function 'testing::internal::DeathTestFactory* testing::internal::UnitTestImpl::death_test_factory()':
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:763:12: error: 'death_test_factory_' was not declared in this scope
     return death_test_factory_.get();
            ^~~~~~~~~~~~~~~~~~~
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:763:12: note: suggested alternative: 'death_test_factory'
     return death_test_factory_.get();
            ^~~~~~~~~~~~~~~~~~~
            death_test_factory
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h: At global scope:
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:1043:29: error: 'string' does not name a type; did you mean 'String'?
     virtual void Send(const string& message) = 0;
                             ^~~~~~
                             String
[ 16%] Building CXX object src/CMakeFiles/BUTIL_LIB.dir/butil/memory/weak_ptr.cc.o
[ 16%] Building CXX object test/CMakeFiles/BUTIL_DEBUG_LIB.dir/__/src/butil/file_util_posix.cc.o
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:1049:23: error: 'string' does not name a type; did you mean 'String'?
     void SendLn(const string& message) {
                       ^~~~~~
                       String
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:1057:24: error: 'string' does not name a type; did you mean 'String'?
     SocketWriter(const string& host, const string& port)
                        ^~~~~~
                        String
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:1057:44: error: 'string' does not name a type; did you mean 'String'?
     SocketWriter(const string& host, const string& port)
                                            ^~~~~~
                                            String
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:1068:29: error: 'string' does not name a type; did you mean 'String'?
     virtual void Send(const string& message) {
                             ^~~~~~
                             String
/home/spack-stage/root/spack-stage-brpc-0.9.7-2iuiakdynpinmqur7edrvhldyrko7a27/spack-src/build/googletest-src/googletest/src/gtest-internal-inl.h:1094:11: error: 'string' does not name a type; did you mean 'String'?
     const string host_name_;
           ^~~~~~
……

Can you tell me why googletest was going from mazong1123/master
Download instead of downloading from google/googletest? Now because of the old version of google test causes a lot of syntax problems, can you fix it?

googletest from mazong1123/master is not introduced by brpc source code, you can check you cmake files to see where it is introduced.

Can you tell me why googletest was going from mazong1123/master
Download instead of downloading from google/googletest?

It's not downloading from mazong1123/master,  just a git commit message, which is:

Merge pull request #821 from mazong1123/master

See https://github.com/google/googletest/tree/release-1.8.0

@wasphin When I use the incubator-brpc@master version, the following error message is displayed on x86_64 that use "make -j126":

Is there any good way to change it by using the latest google test instead of "mazong 1123/master", which is too old.

Is there any good way to change it by using the latest google test instead of "mazong 1123/master", which is too old.

You can change the "GIT_TAG release-1.8.0"  in https://github.com/apache/incubator-brpc/blob/master/cmake/CMakeLists.download_gtest.in to use a new version of googletest

@wwbmmm [root@localhost spack-src]#vim cmake/CMakeLists.download_gtest.in

The test was successful:

Do you have any plans to develop aarch64 test? An error is reported when I compile the test on aarch64:
[root@localhost spack-src]# vim test/CMakeLists.txt

Do you have any plans to develop aarch64 test? An error is reported when I compile the test on aarch64:

brpc has not fully support aarch64 yet. @serverglen will work on this.


Download Error

Hello there. I completely follow your instructions in README. But I run into a problem. I want to know if your method is to crawl video from youtube one by one according to the video ID.If so, what can i do when my IP is blocked due to crawling too many videos?

Please make sure that you have the latest version of youtube-dl, also check out their page for FAQ
https://github.com/ytdl-org/youtube-dl

Sorry to disturb you again. Let me talk about the problem I encountered in detail.
Here is my error:

And my youtube-dl has upgraded to the latest version already,

What should I do next?
I use the proxy to download the dataset in WIN, by the way.

Please make sure that you have the latest version of youtube-dl, also check out their page for FAQ
https://github.com/ytdl-org/youtube-dl
Sorry to disturb you again. Let me talk about the problem I encountered in detail.
Here is my error:

And my youtube-dl has upgraded to the latest version already,

What should I do next?
I use the proxy to download the dataset in WIN, by the way.

I cannot help on youtube-dl unfortunately.
Alternatively you can submit a request to us with user agreement. Thanks!

I cannot help on youtube-dl unfortunately.
Alternatively you can submit a request to us with user agreement. Thanks!
Do you mean the dataset download protocol? I did not find the relevant file in your website or profile，so I email you a protocol used in other match. If don't meet the requirements, please let me know, Thanks for your help!

Dear Hang Zhao，
I am the studet in github named hao zhang. I'd like to request the HACS segments for research only and the user agreement is placed in the attachment. If the file don't meet your requirements, please let me know. Thanks for your help!
Hao Zhang
2019.9.9
------------------ 原始邮件 ------------------
发件人: "Hang<EMAIL_ADDRESS>发送时间: 2019年9月6日(星期五) 下午3:49
收件人<EMAIL_ADDRESS>抄送: "雨落烂漫"32668646<EMAIL_ADDRESS>主题: Re: [hangzhaomit/HACS-dataset] Download Error (#7)
I cannot help on youtube-dl unfortunately.
Alternatively you can submit a request to us with user agreement. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dreamedrainbow Can you follow the instruction in this repo to submit a list of missing files? We have an automatic pipeline to share videos with you.


[BEAM-1393] [BEAM-1394] [BEAM-1445] Update Flink Runner to Flink 1.2.0 & Use Flink InternalTimerService for TimerInternals

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @aljoscha
I did not modify the snapshot in UnboundedSourceWrapper. That is a independent revision. We can do it in another PR.

Coverage decreased (-0.007%) to 69.61% when pulling 72a212b3ce325151d414807ab8a4b4d7f93ae15a on JingsongLi:BEAM-1393-Flink-1.2.0 into 591118e66b172793884f26bd48c55aaf3fc7737d on apache:master.

Hi @JingsongLi Could you please rebase on top of master and provide one (or several if there are independent features) commits? With several merge commits in between it's hard for me to reconcile it with the current master when merging.
I also think we need to figure out the checkpointing of the side-input state before we can merge. Having in a regression in the checkpointing would not be good. Unfortunately I didn't manage to come up with a good solution for that yet. I'll keep you posted.

Hi @aljoscha  I'm so sorry, I want to rebase some commits, but bring so many commits to this PR. Is there a way to get rid of them?
 (Except merge):
https://github.com/apache/beam/pull/1960/commits/c691466db48cbe94baf93fa59bd1e4db604a7801
https://github.com/apache/beam/pull/1960/commits/830d7f755136a60f9ecb54710495fe940d9b12b1
https://github.com/apache/beam/pull/1960/commits/0f00c752c9d2ccace8f47f0f5ab4e4ff7d95f7eb
As you say, we need to figure out the checkpointing of the side-input state before we can merge. I did BEAM-1445 in this PR. I used Map to store state because OperatorStateBackend don't support namespace.

Don't worry. 😃
I responded on Jira, regarding the checkpointing of side input and pushed back events.

Coverage increased (+0.2%) to 69.77% when pulling de65dca96476b3caea3ab626125ee0d9fa751d56 on JingsongLi:BEAM-1393-Flink-1.2.0 into 591118e66b172793884f26bd48c55aaf3fc7737d on apache:master.

This is indeed a bit more complicated. I will do some tests in our internal Flink cluster.

I understood it.. add -Prelease to mvn install will run findbugs plugin.

I also rebased/cherry-picked your changes on top of master and squashed into a single commit. The result of this is here: https://github.com/aljoscha/beam/tree/finish-pr-1969-flink12. If you could continue working on that one it will be easier to merge things into master in the end. 😃

Because TwoInputStreamOperatorTestHarness does not support KeyedStateBackend, the testing of KeyedSideInput and snapshot/restore is a bit difficult.

Ha wow, you are quick. 😃
Testing the keyed operator with side input does in fact work when using KeyedTwoInputStreamOperatorTestHarness. I would quickly fix that and then merge your changes so that we can also get your changes for the user facing timer API in.
I would propose to add more extensive tests and resolve some other rough edges in follow-up work. What do you think?

OK, very good!
Yes, The DoFnOperator become more and more complicated. We should add more tests.

The good thing is that WindowDoFnOperator will have essentially no functionality after these changes so we only have to test the DoFnOperator. 😃

@davorbonaci What's the command to ask Jenkins to re-run? I can't figure out what the problem is in the "Maven clean install" hook.

retest this please

Looks like a javadoc problem, but no details.

I think I figured it out, see my fix here: https://github.com/apache/beam/pull/2012
I'll wait for Jenkins to give the green light and then I'll merge. 👍

I finally managed to resolve all the issues, was chasing master there for a bit. 😄
Thanks for your very good work, @JingsongLi 👍


[Bug] mysql long transaction will restart infinitely, no longer consume binlog

Search before asking

[X] I searched in the issues and found nothing similar.

Flink version
1.13.2
Flink CDC version
2.3
Database and its version
mysql 5.7
Minimal reproduce step
mysql, insert a large amount of data in a transaction, commit for a long time
What did you expect to see?
Can consume binlog normally
What did you see instead?
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

2023-05-10T08:19:49.639925+08:00 89795485 [Note] Start binlog_dump to master_thread_id(89795485) slave_server(5421), pos(./mysql-bin.240254, 4) with GTID
2023-05-10T08:19:49.639944+08:00 89795485 [Note] Start asynchronous binlog_dump to slave (server_id: 5421), pos(./mysql-bin.240254, 4) binlog end pos(mysql-bin.240258, 337795371)
2023-05-10T08:19:49.952178+08:00 89795485 [Note] Stop asynchronous binlog_dump to slave (server_id: 5421)
2023-05-10T08:19:49.952214+08:00 89795485 [Note] Aborted connection 89795485 to db: 'unconnected' user: 'smlkcanal' host: '<IP_ADDRESS>' (Failed on my_net_write())

我猜是这个块的代码造成的，当接收一个特别大的事务，eventLastSeen超过1分钟没有被更新，然后就会断开连接，重连，重连上继续接收那个特别大的事务，然后再超时重连。就这样无限循环下去。

Considering collaboration with developers around the world, please re-create your issue in English on Apache Jira under project Flink with component tag Flink CDC. Thank you!
为了方便各个国家的贡献者交流，请在 Apache Jira  的 Flink 项目下重新用英文创建问题，同时在问题上将 Component 标注为 Flink CDC。谢谢！


DBCluster masterUserPasswordSecretRef required, even when AWS can't take it (when replicating)

What happened?
When creating a DBCluster.rds.aws.crossplane.io/v1alpha1 object, the value replicationSourceIdentifier can be set to an ARN like arn:aws:rds:us-west-2:123456789:db:funtimesdb to have the new Aurora cluster replicate replicate from that specified instance. When you do, AWS will not accept a masterUsername, a master password, or databaseName because all of that information will come from the master the new cluster will replicate from.
The issue is that on the DBCluster object, masterUserPasswordSecretRef is always required, even in the case of a valid entry in replicationSourceIdentifier causing AWS to reject the request because it contains a password.
My current workaround is to specify a real secret in masterUserPasswordSecretRef, but in it to specify a key that does not exist:
masterUserPasswordSecretRef:
      namespace: crossplane
      name: newclustertst-aurora
      key: thisisnotreal

When I do so, the arbitrary requirement for masterUserPasswordSecretRef is satisfied, but because it can't find the value in that secret crossplane either doesn't specify the secret in the request or it is null, therefore AWS accepts the request.
The other, related issue is that of password generation on a new cluster.  Unlike DBInstance.rds.aws.crossplane.io/v1alpha1 with it's nullable MasterUserPasswordSecretRef and the boolean autogeneratePassword and RDSInstance.database.aws.crossplane.io/v1beta1 with it's nullable MasterUserPasswordSecretRef, on DBCluster you MUST specify the password in an existing secret when creating the cluster.  It would be great if DBCluster had the same nullable MasterUserPasswordSecretRef and boolean autogeneratePassword combo as DBInstance so that it fixes the main issue of this bug report AND allows for auto password generation making DBCluster behavior consistent with DBInstance (and moreor less consistent with RDSInstance.
We are upgrading Crossplane and the provider to the newest version to help with another issue (https://github.com/crossplane/provider-aws/issues/895) but I don't think it will help here as this is documented even in the newer versions.
How can we reproduce it?
Apply this secret and DBCluster to get the AWS rejection message (same error as when you unnecessarily supply masterUsername or databaseName):
NOTE: replicationSourceIdentifier must point to a working and compatible database instance.
apiVersion: v1
kind: Secret
metadata:
  name: newclustertst-aurora
  namespace: crossplane
stringData:
  password: testPassword!123
---
apiVersion: rds.aws.crossplane.io/v1alpha1
kind: DBCluster
metadata:
  name: newclustertst-aurora
spec:
  forProvider:
    region: us-west-2
    engine: aurora-postgresql
    engineVersion: "13.4"
    replicationSourceIdentifier: arn:aws:rds:us-west-2:123456789:db:funtimesdb
    #masterUsername: dbadmin
    #databaseName: newclustertst
    masterUserPasswordSecretRef:
      namespace: crossplane
      name: newclustertst-aurora
      key: password
      #key: thisisnotreal
    backupRetentionPeriod: 14
    enableIAMDatabaseAuthentication: true
    preferredBackupWindow: "7:00-8:00"
    storageEncrypted: true
    dbSubnetGroupName: "sandbox_us-west-2"
  providerConfigRef:
    name: aws-provider

To get the error from Crossplane, comment out "masterUserPasswordSecretRef" or specify a secret that doesn't exist and it will either tell you masterUserPasswordSecretRef is required or that the one specified doesn't exist.
To get it to work, comment key: password and uncomment #key: thisisnotreal.
What environment did it happen in?
Crossplane version: 1.0.0
Provider version: 0.20.0 (but according to the documentation, this is still the case with 0.25.0
Kubernetes distro: AWS EKS
Kubernetes version: 1.20.11
kubectl version:
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:33:37Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"20+", GitVersion:"v1.20.11-eks-f17b81", GitCommit:"f17b810c9e5a82200d28b6210b458497ddfcf31b", GitTreeState:"clean", BuildDate:"2021-10-15T21:46:21Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}

okay got it think we can change this here https://github.com/crossplane/provider-aws/blob/master/apis/rds/v1alpha1/custom_types.go#L60 adding optional/,omitempty and check the controller here https://github.com/crossplane/provider-aws/blob/master/pkg/controller/rds/dbcluster/setup.go#L91

#1413 fixed this issue


[BUG] copying checboxes links them

place a checkbutton
ctrl+c copy paste it
if you click the copied one the original one also gets set and vica versa,

but there is no indication in Style pane that they are linked.
Your environment
OS: Windows
formation-studio-0.7.0
Python version: Python 3.7.0

Thanks for bringing this up @mrx23dot. I will work to fix this along with its related issue #44

This should be fixed now.


Environment not recognised for mypy, but is for jedi

Hi, I have added this plugin to the main server (python-lsp-server) which I have installed via pipx:
pipx install python-lsp-server
pipx inject python-lsp-server pylsp-mypy

I have created a virtual environment and am directing the server to use it via plugins.jedi.environment and I have also tried running the server in the virtual environment (although it is not installed there).
Both methods work for jedi services (code completion, documentation, etc) but when using the mypy checks, libraries with type stubs installed are always flagged as errors of type missing imports. This does not occur when running mypy from the environment.
Not sure if this is a known issue or there's some configuration I'm missing, seems strange to me that the jedi part of the server picks up the environment, but the mypy part does not.
Any help would be very much appreciated!

Have you set the command path in your sublime project:
        "LSP": {
            "pylsp": {
                "enabled": true,
                "command": [
                    ".../.venv/bin/pylsp",
                ],

?

I'm using Doom Emacs as my editor, not Sublime Text. Additionally, I'm using a globally installed version of pylsp, rather than one installed in a local virtualenv. For what it's worth, the equivalent emacs config variable is lsp-pylsp-server-command and it is set to pylsp in my configuration (which is the default value).

IIRC, questions like this were sort of asked/answered a year or two ago in the abandoned forerunner project. Too bad GitHub doesn't integrate searches and references somehow. (Or... they probably do and I'm just old/dumb.)
Anyway, OP, if you still use this plugin, please try this patch.
Install globally (just a guess, haven't used pipx in forever):
$ pipx inject python-lsp-server git+https://github.com/jpneverwas/pylsp-mypy@overrides

Add some init (if doom doesn't already have something for this):
(defvar-local my/lsp/custom-settings nil)
(put 'my/lsp/custom-settings 'safe-local-variable #'vectorp)

(defun my/on-hack-locals ()
  (when my/lsp/custom-settings
    (lsp-register-custom-settings my/lsp-custom-settings)))

(defun my/on-prog-mode ()
  (add-hook 'hack-local-variables-hook #'my/on-hack-locals nil t))

(add-hook 'prog-mode-hook #'my/on-prog-mode)

;; BTW, I find this -v flag quite useful for debugging lsp-mode
(set-variable 'lsp-pylsp-server-command '("pylsp" "-v"))

And then the usual ~/proj/.dir-locals.el:
((python-mode
  . ((my/lsp/custom-settings
      ("pylsp.plugins.pylsp_mypy.enabled" t t)
      ("pylsp.plugins.pylsp_mypy.live_mode" nil t)
      ("pylsp.plugins.pylsp_mypy.dmypy" t t)
      ("pylsp.plugins.pylsp_mypy.overrides"
       ["--python-executable" "/home/user/proj/.venv/bin/python" t]))
     ;; in case you switched to eglot
     (eglot-workspace-configuration
      . ((:pylsp . (:plugins
                    (:pylsp_mypy
                     (:enabled t
                      :live_mode nil
                      :dmypy t
                      ;; last I checked (like 1+ yrs ago w. pyls),
                      ;; a bug in eglot made config-file necessary
                      :overrides ["--config-file"
                                  "/home/user/proj/mypy.ini"
                                  "--python-executable"
                                  "/home/user/proj/.venv/bin/python"
                                  t]))))))
     (lsp-pylsp-plugins-jedi-environment . "/home/user/proj/.venv"))))

I probably botched a few things, but you get the idea. Let me know what
happens. (Emacs FTW!)

This is likely fixed by now. Please test.

Closing because no reply is assumed to mean it is fixed


Proctored MCQ Quiz 5 - Evan Sanchez

Score: /2
Graded by: Brian Zhang

GH Indi Page, Review Ticket, Crossover graded, Study Plan

Quiz5 MCQ results >50%, (1 or 0) and test corrections

Score 2/2 Grader: Brian Zhang
AP Test 4 (20/25) - Corrections


Restrict prerelease version to prerelease ranges

Currently prerelease versions like 1.2.5-beta are matched successfully against non-prerelease ranges like >= 1.2.0.  This may cause undesired behavior and/or unexpected instability.
This change is to restrict prerelease matches to more closely follow npm-semver:
https://github.com/npm/node-semver#prerelease-tags

Sry for the delay, looks good but i have to check this first.
It's a comprehensible action taken by node-semver but it may also lead to confusion if this exception case is not known to the users

Since semver itself doesn't specify range semantics and node-semver is probably the most widely known implementation of semver that implements ranges, I think it makes sense to follow it. That is the behaviour I would expect, at least.

Looks like there's a 2 year old issue to make it official - mojombo/semver#205

It took some time since i had to verify this is fully compliant.
I added some simple tests which fail, see branch feat_noderange

http://semver.org/#spec-item-9

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.

Emphasis mine

I'm currently working on a rework of the range system which allows us to support this kind of special semantic and most of node-semvers operators. Expect it in the next 2-4 weeks


chore: [WIP] 🍰 Fix Admin Interface Hot Module Replacement

🍰 Pullrequest

Fix admin interface hot module replacement.
Error message see the related issue #1961 .
Issues

fixes #1961

Additional Informations
We use webpack 4 I saw …

webpack 4 docs: https://v4.webpack.js.org/configuration/dev-server/#devserverpublic
webpack 5 docs: https://webpack.js.org/configuration/dev-server/#websocketurl

Todo

[X] None

Hey @Mogge ,
I am not able to fix this problem.
And I don't have the error message in my terminal that I could see if it vanishs or not.

This is not a problem - hot reload works as expected on admin


Adding support For Pre-volta GPU

Related to #1271 . I am currently working on adding support for Pre-volta GPUs in Triton.

Want to ask some questions in FMA to Dot we are using LLVM::FMulAddOp which requires the same type for all operands and results and while doing passes we convert our result tensor to tensor<64x64xf32, #triton_gpu.blocked<{sizePerThread = [4, 4], threadsPerWarp = [2, 16], warpsPerCTA = [4, 1], order = [1, 0]}>> which is of type f32 even when we give result tensor to be of float16 type is there any specific reason for this ? So basically this PR will give support only for float32 types currently. If we try to pass float16 type it will give error.

So basically this PR will give support only for float32 types currently for dot operation. If we try to pass float16 type it will give error.

What errors did you see?

What errors did you see?

error: 'llvm.intr.fmuladd' op requires the same type for all operands and results
Pass execution failedLLVM ERROR: Failed to translate TritonGPU to LLVM IR.
[1]    139783 abort (core dumped)  python3 test_files1.py

@Jokeren got this error when passing these tensors.
 a = torch.randn((64, 16), device="cuda", dtype=torch.float16)
 b = torch.randn((16, 64), device="cuda", dtype=torch.float16)
 c = torch.empty((64, 64), device="cuda", dtype=torch.float16)

I tried to dump all the tensor types the result tensor I got of different type is.
tensor<64x64xf32, #triton_gpu.blocked<{sizePerThread = [4, 4], threadsPerWarp = [2, 16], warpsPerCTA = [4, 1], order = [1, 0]}>>

When tried with float32 it worked successfully.

I got this kind of error:
error: 'llvm.intr.fmuladd' op requires the same type for all operands and results
Pass execution failedLLVM ERROR: Failed to translate TritonGPU to LLVM IR.
Aborted

I get this error running it on a Tesla K80 (Kepler architecture, compute capability 3.7).
error: 'llvm.intr.fmuladd' op requires the same type for all operands and results
Pass execution failedLLVM ERROR: Failed to translate TritonGPU to LLVM IR.

@Ph0rk0z @Kraegge I am working on this bug also will update this PR when done.

Ok. i was eager to try triton and see what kind of speeds I get on my pascal card. I saw that GPTQ closed their bugs and assumed the best  :)

Hey @geekypathak21 do you think it's possible to support 4 or 8 bit data representation for the Pascal cards and greater?

Hey @clxyder I think it's possible to support 16 but not sure about 8 and 4.

Hey @clxyder I think it's possible to support 16 but not sure about 8 and 4.

But it is working in 4bit on cuda kernels currently. 8bit through bits and bytes is a bit sketchy and doesn't work with every model.


Binary vector format for flat and hnsw vectors

This provides a binary vector format for vectors. The key ideas are:

Centroid centered vectors
Asymmetric quantization
Individually optimized scalar quantization

This allows Lucene to have a single scalar quantization format that allows for high quality vector retrieval, even down to a single bit.
For all similarity types, on disk it looks like.

quantized vector
lower quantile
upper quantile
additional correction
sum quantized components

(vector_dimension/8) bytes
float
float
float
short

During segment merge & HNSW building, another temporary file is written containing the query quantized vectors over the configured centroids. One downside is that this temporary file will actually be larger than the regular vector index. This is because we use asymmetric quantization to keep good information around. But once the merge is complete, this file is deleted. I think eventually, this can be removed.
Here are the results for Recall@10|50

Dataset
old PR
this one
Improvement

Cohere 768
0.933
0.938
0.5%

Cohere 1024
0.932
0.945
1.3%

E5-Small-v2
0.972
0.975
0.3%

GIST-1M
0.740
0.989
24.9%

Even with the optimization step, indexing time with HNSW is only marginally increased.

Dataset
OLD PR
This One
Difference

Cohere 768
368.62s
372.95s
+1%

Cohere 1024
307.09s
314.08s
+2%

E5-Small-v2
227.37s
229.83s
< +1%

The consistent improvement in recall and flexibility for various bits makes this format and quantization technique much preferred.
Eventually, we should consider moving scalar quantization to utilize this new optimized quantizer. Though, the on disk format and scoring will change, so, I didn't do that in this PR.
supersedes: https://github.com/apache/lucene/pull/13651
Co-Authors: @tveasey @john-wagster @mayya-sharipova @ChrisHegarty

Hi @benwtrent , I am the first author of the RaBitQ paper and its extended version. As your team have known, our RaBitQ method brings breakthrough performance on binary quantization and scalar quantization.
We notice that in this pull request, you mention a method which individually optimizes the lower bound and upper bound of scalar quantization. This idea is highly similar to our idea of individually looking for the optimal rescaling factor of scalar quantization as described in our extended RaBitQ paper, which we shared with your team in Oct 2024. An intuitive explanation can be found in our recent blog. The mathematical equivalence between these two ideas is listed in Remark 2.
In addition, the contribution of our RaBitQ has not been properly acknowledged at several other places. For example, in a previous post from Elastic - Better Binary Quantization (BBQ) in Lucene and Elasticsearch, the major features of BBQ are introduced, yet it is not made clear that all these features originate from our RaBitQ paper. In a press release, Elastic claims that "Elasticsearch’s new BBQ algorithm redefines vector quantization", however, BBQ is not a grandly new method, but a variant of RaBitQ with some minor adaption.
We note that when a breakthrough is made, it is always easy to derive its variants or to restate the method in different languages. One should not claim a variant to be a new method with a new name and ignore the contribution of the original method. We hope that you would understand our concern and acknowledge the contributions of our RaBitQ and its extension properly in your pull requests and/or blogs.

Remark 1. The BBQ feature fails on the GIST dataset because it removes the randomization operation of the RaBitQ method. With the randomization operation, RaBitQ is theoretically guaranteed to perform stably on all datasets.
Remark 2. Let $B$ be the number of bits for scalar quantization. The scalar quantization can be represented in two equivalent ways.
1. Scalar quantization can be determined by the lower bound $v_l$ and the upper bound $v_r$. The algorithm first computes $\Delta =(v_r-v_l) / (2^{B}-1)$ and then maps each real value $x$ to the nearest integer of $(x-v_l) / \Delta$.
2. Based on the process above, scalar quantization can be equivalently determined by a rescaling factor $\Delta$ and a shifting factor $v_l$.

@benwtrent Thanks for your reply.
First, in the blog - Better Binary Quantization at Elastic and Lucene - the BBQ method is a variant of our RaBitQ with no major differences. The claimed major features of BBQ all originate from our RaBitQ paper (as we have explained in our last reply). There is only one attribution to our method, where it is mentioned (in one sentence) that BBQ is based on some inspirations from RaBitQ. We think this attribution is not sufficient - it should be made clear that the mentioned features of BBQ all originate from RaBitQ.
Second, for the new method described in this pull request, there is no attribution to our extended RaBitQ method at all - we note that we shared with your team the extended RaBitQ paper more than 2 months ago. To our understanding, the method is highly similar to our extended RaBitQ at its core (which also supports quantizing a vector to 1-bit, 2-bit, ... per dimension). They share the major idea of optimizing the scalar quantization method by trying different parameters. In your new blog, it is mentioned that “Although the RaBitQ approach is conceptually rather different to scalar quantization, we were inspired to re-evaluate whether similar performance could be unlocked for scalar quantization.” This is not true since our extended RaBitQ corresponds to an optimized scalar quantization method.
Given that our extended RaBitQ method is a prior art of the method introduced in the blog and our method was known to your team more than 2 months ago, you should not have ignored it. Discussions on the differences between two methods if any should be clearly explained and experiments of comparing the two methods should be provided as well.

@gaoj0017 it sounds to me as if your concern is about lack of attribution in the blog post you mentioned, and doesn't really relate to this pull request (code change) - is that accurate?


Memory Leak Happens if constructor fails

https://github.com/zenomt/rtmfp-cpp/blob/d0ee847c880aa37a7a4a900ec4cea55a646cf621/src/RTMFP.cpp#L34

is this a theoretical concern, or one that's causing an actual problem? that is, are you actually experiencing an RTMFP's constructor failing (from, like, out of memory or something), and you're catching the exception and trying to recover without just stopping the process (when you're already super close to out-of-memory)?
i will fix these malloc leaks, but in this same constructor a new reference/retain is made on a shared_ptr that won't be released because the RTMFP destructor won't be called. there's probably lots of other places in the code where dynamic allocation or additional refcounts happen in constructors, that would be leaked if the constructor ultimately failed.
knowing how much of a real problem these kinds of potential leaks are in the real world will help me to prioritize an audit to find them and decide what to do about them.

https://github.com/zenomt/rtmfp-cpp/commit/4f07df76a6e6273c9c111a7173da3f090959dd80 addresses the specific leak you called out. however, without any indication that this kind of leak is causing a real-world problem for anyone, or in fact that anyone actually attempts to catch any exceptions rather than letting the program terminate on exception, i'm not inclined at this time to track down and address others like it.

Hi Michael,
Thanks for addressing the memory leak in commit 4f07df7.
While I haven’t encountered issues with the RTMFP constructor failing, my concern is more preventive. In environments where multiple programs run together, even small memory leaks—whether from our process or others—can accumulate, potentially leading to failures. Over time, repeated loading and unloading of the library could also contribute to memory leaks.
I am in learning phase and trying to seek some changes for myself with your guidance can enrich me in future.
Best,
Kartik

keep in mind that the kind of situation that could cause this constructor (or any of the other constructors in the library) to fail is that the process is already out of memory. if that's the case, it's probably not possible to continue running anyway (especially in C++ where dynamic allocation happens all over the place). plus, unless you're explicitly catching exceptions, the program will terminate when any constructor fails. being almost or entirely out of allocatable memory in the process is probably going to be unrecoverable, and the best course of action will be to terminate.


remove prerelease dependencies

This is the result of deleting lerna-package-lock.json and then running npm i

need to run npm run bump-version -- --release or whatever the command is to update the package.json files as well


Only show the project explorer when an F# project is open

When I open a folder containing projects in other languages, the F# project explorer panel is still there. Is there any way to scan the current folder for F# source files and only show the project explorer if F# files exist?
Thanks

Unfortunately that's not something we can control. VSCode adds to UI all tree explorers that are defined in plugins manifests and then just lazily initialize content.
I guess you can try to create issue in VSCode repo

A work around is to disable the ionide plugin for that workspace.


axiomatization of the contributor and contributor roles branch

There are multiple reasons why we need to define the contributors of an academic event or event series via the roles they bear within these planned processes. One would be the fact that an organization or person can contribute in multiple ways, e.g. a person could be a steering committee chair and at the same time a member of some other committee, or an organization could be acting as both a sponsor and organizer of an event. Another reason why we need roles for the definition of contributors is that they are realizable entities. Since we are dealing with planned processes this is important, as sometimes things don't work out as planned. If an event organizer has, for example, invited someone to deliver a keynote speech and promoted the event accordingly but at the time of the event this person is somehow unable to participate, we would say that this person is a contributor of the event with a keynote speaker role that was not being realized. Or we could think of an accreditation process that provides some kind of certificate for the attendees of an event and only when this certificate is present can we say that the attendee role of the participants was realized. Now when it comes to actually annotating event data, we do not want to assert each time that Person X has Role Y which gets realized in Event Z. We simply want to say Person X organized Event Z - or the inverse that Event Z was organized by Person X - knowing that Role Y and likely its realization is implied. We thus need subproperties of "has participants" as shortcuts and an axiomatization that reflects this.

learn from https://github.com/data2health/contributor-role-ontology/issues/14

related to https://github.com/tibonto/aeon/issues/97

related to https://github.com/data2health/contributor-role-ontology/issues/132

There are still some outstanding improvements, such as subsuming 'event organizer role' under CRO:'project management role' (CRO:0000065), but this has to wait until https://github.com/data2health/contributor-role-ontology/pull/133 is merged. Yet in order to get forward I've closed this issue and will make new ones for these changes.

This issue needed to be reopened, as the idea to subsume AEON specific roles under CRO:'contributor role' and that under OMRSE:'role in human social processes' was a bad idea. First using the automated workflows of the ODK causes this subsumption to break whenever a new release is built, as this will also rebuild the CRO module and thus delete the injected subclass of axioms. Sencond, it is not clear if this axiom injection is event allowed (see also: https://github.com/data2health/contributor-role-ontology/issues/135). Third, there needs to be clarity about how to model such very general social roles the OBO way. As of now COB only reuses SEPIO's 'agent role', but with a new editor note that implies this bearer of this role to be causing the process in which it is involved, whereas the original SEPIO:'agent role' does not go so far. Also it is unclear whether the modeling descisions of roles in OMRSE, which do not link/reuse/or mention CRO at all, can be seen as canonical in OBO. All of this needs to be resolved somehow. So until there is a grand plan on how to best model such social roles in OBO, we will just define them in AEON.


Back button on Edit cart rule page doesn't work.

Bug report
Title
Back button on Edit cart rule page doesn't work.
Issue Description
Back button on Edit cart rule page doesn't work.
Preconditions
2. Commit id.-161e16d4b92adfa54d49211d44b3e34af7f56157

Steps to reproduce
1. step1- Create a cart rule.
2. step2- Edit the rule and click on back button.

Expected result
It should redirect to cart page.
Actual result
No response on click.

Commit Id: 655d2abf1174ec750d6526038ec650d1484db9be

Fixed


docs: add asset prefix section to deploy guide

Summary
Add asset prefix section to deploy guide.
Related Links
Same as https://rspress.dev/guide/basic/deploy#static-resource-prefix-configuration
Checklist

[ ] Tests updated (or not required).
[x] Documentation updated (or not required).

👍🏻👍🏻👍🏻 extremely good hand-by-hand tutorial

😄


Set box version fixed

Since version 1.0.2, puppet has been updated to the next major version (4.x.x), whereas this repo depends on puppet 3.x.x.

Thank you @Sch3lp !

No problem! ;)


message_move: Disable stream select dropdown for unprivileged users.

This PR disables stream-select dropdown in move_topic_modal for users who are not permitted to move messages.
Fixes: #28345

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Thanks for your work @Vector73 , probably I think we should also render the required warning message raise JsonableError(_("You don't have permission to move this message")) alongwith blocking the dropdown selection whenever an unprivileged user tries to move the message.
The obvious reason is so that the user understands why the drop-down selection has been blocked.
Might be a better addition . Would like to have @alya views on this.

Ah, good point! A tooltip on the stream dropdown explaining why the dropdown is disabled will be very helpful here. Let's do:

You do not have permission to move messages to another stream in this organization.

Added the tooltip to stream dropdown when it is disabled.

Thanks!
@sahil839 are you up for doing a first-round review on this one? I haven't tested.

Updated the commit message.

I have updated the commit description. I think it follows the commit message guidelines now.

The line-wrapping still needs to be fixed. The guidelines recommend having not more than 68-70 characters per line so that it is easy to read the commit message by doing "git log" in a terminal. Please see "Formatting guidelines" section in the docs for more info.

Fixed line wrapping.

Testing the PR, I wonder if it would look better to also fade the color of the bar on the left side of the stream dropdown, matching with the stream symbol? It didn't jump out at me in light theme, but it looked a bit odd to me in dark theme.

Please ask in #design if you have a different intuition, or if this is technically difficult for some reason.

Yeah that sounds good. I have done that in the recent changes.
Dark Theme:

Light Theme:

Ah, sorry I missed the latest comment on this one. Marking for integration review; I haven't re-tested the latest version.

Posted a few comments, otherwise lgtm.

Merged, thanks for getting this finished @Vector73!


RIPPLE-76: Adding security warning for "Remote" proxy

hey, @brentlintner !
I have created a security note for "remote" proxy - http://snag.gy/ez5TG.jpg

@ibuziuk awesome! Looks solid. +1 from me, and will merge this, unless anyone has any other comments.

Ah, since it seems solid, I just merged it, as: 185e7a9162d5f0f954a5f267734d5c2a886feed8
Thanks again!


Add missing test_ids

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Add missing test_ids
Special notes for your reviewer:
Release note:

None

/retest

Thank you for the contribution @duyanyan. Can you add a description and possibly link to a bug/rfe as well?

/retest

usrbinkat

Do you mean the description for memory dump feature? here is the link https://github.com/kubevirt/community/blob/main/design-proposals/vm-memory-dump.md

/retest


Move methods depending on OpenSSL to the corresponding package

String extensions asPrivateKey and asPublicKey are implemented in the package JSONWebToken-Pharo-Core
They depend on classes LcEvpPublicKey and LcRSA, which are only available if the OpenSSL baseline is loaded
When only using the Core baseline for JSONWebToken, these methods are not required, and are currently generating a loading error because those classes are not available.
Both extension methods should be moved to the JSONWebToken-OpenSSL package.

We need to be careful to not break the GS64 components


selectedBorderColor not working

selectedBorderColor, unselectedBorderColor are not working. would you check it?

I have the same problem.
I want to know why.

I have released 2.1.2 version of the package which resolves this problem.
The version is now available at pub.dev
Thank you for noticing it ❤


Allow timestamp list/vector in StreamOutlet.push_chunk

Motivation
Supporting timestamps: list would be nice in the case that we want to push a chunk of samples with irregular timestamps. This is done, e.g., in the neural data simulator project to publish spike timestamps over LSL. The current neural data simulator implementation uses multiple push_sample calls, which is slower than a single push_chunk call.
Implementation
Because calling libraries depend on pylsl's speed, it was important that the default .push_chunk(timestamp: float) function call did not slow down with this new feature. Thus, the current default code-path assumes timestamp: float and falls back (through catching an exception) for the case that timestamp: Union[list, tuple, np.ndarray].
See testing section below for an informal performance test.
Testing
On a separate branch (not planned for committing), we checked that .push_chunk(timestamps: list) matches the received .pull_chunk(timestamps) values.
Performance
pylsl/examples/PerformanceTest.py performs similarly before and after the change, based on python3 -m cProfile -o pylsl.cprof pylsl/examples/PerformanceTest.py
Before:

After:

Both before and after, push_chunk consumes about ~0.7% of compute-time.
Note: I'm not sure why some of the other parts of the call-graphs are different. It might have to do with exactly when I Ctrl-C out of the Python script, as sometimes it took the first format and sometimes it took the second.
This was not a very rigorous test, but this matches intuition about the implementation because try: clauses are very fast unless an exception is raised.

I'm planning to merge mid next week unless there are any objections.


[📚] Missing Windows information in "Add Firebase to your Flutter app"

Description
Add Firebase to your Flutter app does not have information about Windows, but Windows seems to be supported by firebase_auth in pub.dev.
Steps

Go to the firebase_auth pub.dev website, see that Windows is an available platform. Navigate to the documentation website that is specified in its README.
Go to Get Started with Firebase Authentication on Flutter, see that the first steps refers you to Add Firebase to your Flutter app.
Add Firebase to your Flutter app does not show a Windows platform and does not provide instructions for Windows.

Screenshots

Alt: A screenshot of the package:firebase_auth from pub.dev, showing that Windows is a supported platform.

Alt: A screenshot of Add Firebase to your Flutter app showing that there is no Windows option.

Hey @alestiago - Windows support is for development environment only at the moment. See the README. Once it becomes stable, presumably the documentation will also update to reflect setup required.

Awesome, thanks @russellwheatley for the quick reply! 💙
Would be nice to get the development information in Add Firebase to your Flutter app too! Note that users landing on pub.dev firebase_auth or firebase_core might not land on the documentation you shared since there is no direct link to it.
For MacOS, iOS and Android there are some versions constraints the project needs to comply with before adding Firebase to a Flutter application (as stated in the documentation), are there any version constraints for Windows (even when used for development and not production)? If there are version constraints, where are those documented?

Awesome, thanks @russellwheatley for the quick reply! 💙
Would be nice to get the development information in Add Firebase to your Flutter app too!
For MacOS, iOS and Android there are some versions constraints the project needs to comply with before adding Firebase to a Flutter application (as stated in the documentation), are there any version constraints for Windows (even when used in a development environment)? If there are version constraints, where are those documented?


Added setTransform convenience method

@GoodBoyDigital For the PIXI.flash work

Nice one @bigtimebuddy :+1:
This will come in handy for many peeps!


Typescript definitions?

Has anyone worked on creating a typescript definition file for redux-ui-router? I'm new to writing them, but was gonna try creating one, but if there's something already out there I'd like to use that.

There isn't one, and I don't have plans to make one at the moment, however if you want to make one, I am accepting PRs

Ok, I'm still learning how to write them for external libraries, but I'll take a shot at it and submit a PR. Thanks!

I just submitted a PR for the definition file. Thanks for the opportunity to contribute, and if you see any glaring issues please let me know and I'll work to clean them up.


nicer node-coords formatting

https://docs.python.org/3/library/string.html#format-specification-mini-language


Make crash statistics accessible via REST API

This Feature Request is About

[ ] Integration
[x] Analytics
[ ] Ads
[ ] Messaging/Push
[ ] IAP
[x] Flurry Website/Dashboard
[ ] Other

Platform

[x] iOS
[ ] tvOS
[ ] WatchOS

Is your feature request related to a problem? Please describe.
In our company we have dashboards that show vital app statistics like the number of crashes or the issue-free devices. On the Flurry website we can see all that data and there is a REST API for all the analytics stuff, but there is no API to access the crash statistics.
Describe the solution you'd like
We would like to have a REST endpoint for querying the number of crashes, errors, the crash-free devices and the issue-free devices.
Describe alternatives you've considered
Scraping the website, very ugly and annoying.

Hello @fabiankr. Thank you for using Flurry Analytics and for this feature request. I will investigate this further and see what options we can provide.

@fabiankr We have added documentation to our developer portal for getting crash analytics data. Please refer to https://developer.yahoo.com/flurry/docs/api/code/analyticsapi/ for building the API query. The exact dimensions for crash report and crash summary can be found at https://developer.yahoo.com/flurry/docs/api/code/analyticsapi/crashreport/ and https://developer.yahoo.com/flurry/docs/api/code/analyticsapi/crashsummary
Feel free to reach out if there are any other questions regarding/during integration.

@rajkaur01 Thanks a lot. I think that covers everything we need. :)


[SPARK-40416][SQL] Move subquery expression CheckAnalysis error messages to use the new error framework

What changes were proposed in this pull request?
Move subquery expression CheckAnalysis error messages to use the new error framework.
This will help improve the usability of Apache Spark as a product, and link against documentation.
Why are the changes needed?
Error messages related to SQL query analysis in Apache Spark need some work to make them more descriptive and actionable.
Does this PR introduce any user-facing change?
Yes, error messages change.
How was this patch tested?
Unit test and query test coverage shows the updates in error messages received.

Hi @MaxGekk @srielau  can you please help review this? 🙏 it helps make error messages better with respect to subquery expression analysis. @allisonwang-db FYI

Can one of the admins verify this patch?

Hi @dtenedor, I have just merged the bug fix https://github.com/apache/spark/pull/37861. The query context should be set correctly in the AnlysisException.  I believe the test cases in this PR need to be updated so please try updating the code base to the latest master.

Hi @dtenedor, I have just merged the bug fix https://github.com/apache/spark/pull/37861. The query context should be set correctly in the AnlysisException. I believe the test cases in this PR need to be updated so please try updating the code base to the latest master.

@gengliangwang thanks, this is done. We can see the new query contexts in this PR at the latest commit, they appear more accurate now.

Hi @MaxGekk I responded to your comments, please take another look at this when you have time. 🙏 @gengliangwang @allisonwang-db @srielau FYI

Friendly ping @MaxGekk @allisonwang-db @gengliangwang can we please review this again?

LGTM except one comment

Thanks, merging to master


Use Decimal for certain OpenAPI params to avoid losing precision

Currently, the schema parameters multipleOf, maximum, exclusiveMaximum, minimum, and exclusiveMinimum are forcibly cast to float.
This causes a couple problems with OpenAPI:

From the docs on multipleOf:

multipleOf may be used with floating-point numbers, but in practice this can be unreliable due to the limited precision or floating point math.

It loses precision with large numbers. For example, if we wanted to have a field that accepts a 64-bit integer (in the range -9223372036854775808 to<PHONE_NUMBER>854775807), casting that to float converts it to +/-9.223372036854776e+18, resulting in +/-9223372036854776000 when cast back to int. This causes a significant difference between what the developer intends to be a valid value, and what actually gets validated against (and displayed in error messages).

Declaring those fields as Decimal avoids losing precision through unwanted float conversions.

I'm seeing that this would only work to override the generated OpenAPI, but it wouldn't alter the internal implementation in Pydantic and the actual validation, right?
In that case, I feel it would be dangerous to make it look like some validation is done, but it's actually no exactly that. :thinking:


Podspecs have changed paths and docs are not updated

Bug report
Summary
V.3.0.0  has a different path of inidividual podspecs then the one specified in docs
Environment info
react-native info output:
System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 2.16 GB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 13.14.0 - ~/.n/bin/node
    Yarn: 1.22.10 - /Users/Dan/.npm-packages/bin/yarn
    npm: 6.14.4 - ~/.n/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.0. - /Users/dan/.gem/ruby/2.7.1/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.2, DriverKit 20.0, macOS 11.0, tvOS 14.2, watchOS 7.1
    Android SDK:
      API Levels: 28, 29
      Build Tools: 28.0.2, 28.0.3, 29.0.3
      Android NDK: 20.1.5948944
  IDEs:
    Android Studio: Not Found
    Xcode: 12.2/12B45b - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_265 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: 0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 3.0.0-beta.2
Steps to reproduce
Just npm install then run pod install
Cocoapods won't find the path if we set the Podfile as per docs:
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-AppTrackingTransparency', :path => "#{permissions_path}/AppTrackingTransparency.podspec"

I had to change it to
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-AppTrackingTransparency', :path => "#{permissions_path}/AppTrackingTransparency/Permission-AppTrackingTransparency.podspec"

I can prepare a PR if it helps :)

@rborn master branch targets stable version, the v3.0.0 branch doc is already updated: https://github.com/zoontek/react-native-permissions/tree/3.0.0#ios :)

🤦♂ Thanks 😅


Ability to hide "private" plans from UI

Use Case
I want to hide some plans when listing plans for bolt plan show.
Describe the Solution You Would Like
Tasks can be hidden from bolt task show with a private key in the task metadata. A similar setting should be configurable for plans. Perhaps as a Yard tag in puppet strings documentation similar to documenting plan parameters:
# @summary
#   This plan will be hidden from UI
#
# @private true
#
# @param targets
#   The target to run on.
#
# @example Run private plan
#   run_plan(private, $targets)
#
plan private(TargetSpec $targets) { }

Additional Context
This would be useful for hiding packaged module content in PE.

With the addition of bolt-project.yaml we have a workaround for some of the use cases around this. If a project author wants to limit which plans appear in the UI they can add a bolt-project.yaml file and whitelist public plans for the project under the plans key.