Added timezone to column description

Pull Request
Are you a current Fivetran customer?
Ephemeral Tattoos.
What change(s) does this PR introduce?
Add timezone notation to timestamp column. Should replicate for all timestamp columns for clarity.
Did you update the CHANGELOG?

[ ] Yes

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[x] No  (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[ ] Yes

Is this PR in response to a previously created Bug or Feature Request

[ ] Yes, Issue/Feature #43
[ ] No

How did you test the PR changes?

[ ] CircleCi
[ ] Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[ ] BigQuery
[ ] Redshift
[ ] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

Provide an emoji that best describes your current mood

:dancer:
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Hey @mvtemple thanks again for opening this up. I went ahead and cleared away the rest of the changes needed; once our tests pass we'll go ahead and merge to main!

Thank you Renee!!!
On Tue, Jun 21, 2022 at 10:42 AM Renee Li @.***> wrote:

This has been merged with #45
https://github.com/fivetran/dbt_stripe_source/pull/45
—
Reply to this email directly, view it on GitHub
https://github.com/fivetran/dbt_stripe_source/pull/42#issuecomment-1161841143,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT36FYD4JMLQ7TNO2NC6KEDVQHIDPANCNFSM5YURFDLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Unable to add accounts to Authenticator; locked in Edit mode w/ 'Legal Info' dimmed

Original issue 219 created by tom.king.mobilemind on 2012-10-25T23:19:16.000Z:
What steps will reproduce the problem?

Add multiple accounts to authenticator (ie via QR code). 6 in my case
Click Edit. Change one.
Unable to leave Edit mode. Unable to add accounts
"Legal Info" dimmed so workaround from issue # 116/# 1179 fails

What is the expected output? What do you see instead?
Ability to use Authenticator to add more accounts or exit Edit mode.
What version of the product are you using? On what operating system?
Google Authenticator <IP_ADDRESS>5, iOS 6.0, iPhone 4S
Please provide any additional information below.
This needs to be addressed or a clear workaround for transferring all keys. Revoking 6 keys and generating 6 new keys on 6 different systems because of an 'Edit' button bug seems bad.

Unable to reproduce this 4 year old bug.


Skip ActiveJob retrying for ProcessInstallmentJob

Fixes https://github.com/solidusio-contrib/solidus_subscriptions/issues/175
This disables the ActiveJob default retry mechanism because installment
processing failures are already taken care of by solidus_subscriptions.
Before this, there was a potential for double retrying, which could
causes background jobs and canceled orders to accumulate leading
to side effects and a bad customer experience.
Now, a process_job_error_handler configuration Proc is called when a
ProcessInstallmentJob #perfom method fails.
The rescued error can be managed/logged as preferred or re-raised
if the default retry behavior is required in the ProcessInstallmentJob.

Thanks for the guidance @aldesantis and @igorbp!


cannot import name 'coo_array' from 'scipy.sparse'

Dear author, when I run to python saga_gui.cpy, I get an error called ImportError: cannot import name 'coo_ array' from 'scipy. sparse'
Can you tell me where I didn't do it right? Thank you very much

Hi. What is your version of Scipy? I guess this is caused by the version mismatch. You can try to update it.

This is a compatibility issue because it seems that the coo_array feature requires scipy >= 1.8.0 (as stated here). However, this version of SciPy also requires Python >= 3.8, which is not compatible with the overall environment settings.
To resolve this, I personally downgrade to hdbscan = 0.8.19 using the following command:
conda install -c conda-forge hdbscan=0.8.19
And for your reference I have scipy=1.7.3 and scikit-learn =0.20.4 and this combination works for me.


Dealing with if scalar

The whole discussion around to_array is quite tricky, see https://github.com/data-apis/dataframe-api/pull/294 and https://github.com/data-apis/dataframe-api/pull/307 . One big difficulty is that for some libraries it can stay lazy (e.g. Dask has a lazy array), whereas for others it can't (polars LazyFrame doesn't have a to_numpy attribute)
Maybe we can temporarily park it, and try to address the more important (arguably) issue of what to do about
df: DataFrame
features = []
for column_name in df.column_names:
    if df.col(column_name).std() > 0:
        features.append(column_name)
return features

Because as far as I can tell, this call is problematic for all libraries other than purely eager ones. Even Dask, which was mentioned in #294 as an example of a library which can stay lazy in to_array, raises in the call above (see here).
Dask raises here, it doesn't do any implicit computation.
So...what do we do here? Maybe let's try resolving this one, and then return to to_array?
I'll hold off making suggestions this time, let's let the discussion roll

This seems related to #305 and what ought to happen if __bool__ is called on a Scalar. Any solution should probably incorporate the lessons learned from the analogous discussion for the array-api. In #305 I try to argue for piggy-backing on the array-API which would move this problem out of the scope of the dataframe API 🪄 .

I think we've resolved this now - __bool__ forces computation or raises (implementation-dependent), and it may be necessary to call persist first (also implementation-dependent)


Graphing dependencies in local projects?

Is there a way to point this at a package on my local filesystem?

Edit: Nevermind... 'looking into code, it's pretty clear there's not enough here to warrant fleshing this out to support that sort of thing.
BTW, rather than scraping the npmjs.org site to get the dependeny graph you can hit their registry JSON API directly.  E.g. for react you'd fetch https://registry.npmjs.org/react


Launch SendByScan as overlay

This PR opens the send_by_scan view as an overlay using z-index. It allows the existing view to be rendered in the background so that inputs' values don't get lost. E.g. in the case of the send_by_address view, when a user types the message or the amount before opening the QR-code scanner to scan the address, those values remain and do not have to be written in the cookies anymore. The scannerState is delivered via props now.
I tried to test this change as much as possible. But as I don't know all the chases SendByScan can handle, I might have missed some.
I tested to scan:

Scanning an Address
Scanning a PK
Scanning a Request QR code

and they all worked.

shoot this is conflicting now sorry.
I camped on it and then I merged a different PR.
I'm such a noob.
We are using cookies to hold the form values on refresh, but if this is still the way to go would you mind patching up the conflicts and I'll merge it?

We are using cookies to hold the form values on refresh, but if this is still the way to go would you mind patching up the conflicts and I'll merge it?

Just checked out the conflicts. Will need a bit more time to resolve them. Should be able to do it by the end of this week :)

When fixing this, I didn't realize this was a problem for many other components too. I've hence decided to make this a bounty for all components and created an issue: #200. Closing for now.


pythonPackages.iterfzf: init at <IP_ADDRESS>.0

Motivation for this change
I'm slowly working on packaging the Remt tool for Remarkable Tablets.  This package is required, and not packaged in NixOS.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Build on macos 10.14 fails:
...
  Using pythonImportsCheckPhase
  Sourcing python-namespaces-hook
  Sourcing setuptools-check-hook
  Using setuptoolsCheckPhase
  unpacking sources
  unpacking source archive /nix/store/mjlkkiqkh4nq54gq2ls61gbmp7f45zfv-source
  source root is source
  setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/tox.ini
  patching sources
  /nix/store/ddm1y988d42mxmz62fzg8xz3ladxz8vq-stdenv-darwin/setup: eval: line 91: unexpected EOF while looking for matching `"'

Go figure.  Something easy enough to fix at least.
First couple of weeks of this semester have been interesting.

I tried this change out in nix-shell and it seems to be working:

I tried this change out in nix-shell and it seems to be working:

Looks like there is a merge conflict. Could you rebase?

Looks like there is a merge conflict. Could you rebase?

Is there anything else I need to do?

Is there anything else I need to do?


fix: FluentNavLink with OnClick event callback will have different behaviour

Discussed in https://github.com/microsoft/fluentui-blazor/discussions/1446

Originally posted by aliastopan February  5, 2024
This behavior is also consistent with the official demo site.
Is there a way to set FluentNavLink indicator manually? Or the only solution is to write custom css for active NavLink?
🐛 Bug Report
The standard html structure of FluentNavLink is div.fluent-nav-item a.fluent-nav-link.active div.positioning-region with that "active" class it gives nav-item active indicator. But when <FluentNavLink> has OnClick event callback, the html structure become div.fluent-nav-item div.positioning-region the anchor element is gone. This also resulting the nav item to be ignore by tab key navigation
💻 Repro or Code Sample
🤔 Expected Behavior
Adding OnClick event callback should alter the behaviour of FluentNavLink
😯 Current Behavior
Adding OnClick event callback to FluentNavLink remove the anchor element and active class indicator
💁 Possible Solution
🔦 Context
🌍 Your Environment

OS & Device: Windows 10 (19045.3930)
Browser Google Chrome Version 120.0.6099.217 (Official Build) (64-bit)
Nuget: "Microsoft.FluentUI.AspNetCore.Components" Version="4.4.0"

Additionally, nav item also become less responsive.
The blue bg-color is from .fluent-nav-item .positioning-region and the grey highlight is the .fluent-nav-link itself.
When the mouse click outside the grey area (clicking only the blue .positioning-region) the navigation would not navigate. The mouse click must precisely click the .fluent-nav-link for FluentNavLink to work.
The "Setting" nav menu doesn't have OnClick event callback, so it doesn't get affected. It behave as expected.


New expense form: move from category to tags

User story
In the new expense form, we have deprecated the expense category field in favor of having tags. In the initial private release (https://github.com/opencollective/opencollective-frontend/pull/3477) these the tags input will be disabled. To support it we need to make a proper transition from the category.
Best solution for this problem
API

[ ] Migration

[ ] Add a tags column on Expense as an array of strings
[ ] Fill tags with existing categories (ex: category="FOOD" :arrow_right: tags=['FOOD'])
[ ] Delete the category column

[ ] Model

[ ] Add the column with a validator similar to https://github.com/opencollective/opencollective-api/blob/5ff5e291d2dc833a90859b1f3790bef6fa84242d/server/models/Conversation.js#L63 (should be extracted in a lib like validateTags).

[ ] GraphQL

[ ] Deprecate category resolver, return the first tag instead of the category
[ ] In input, if a category is provided and no tags are, set the category as a tag

[ ] Adapt the other DB queries that may be impacted by this

Frontend

[ ] Enable the tags input in the createExpense form and make sure it works with API

Duplicate of https://github.com/opencollective/opencollective/issues/2823


Added proper unavailability support

Hello! Here are the changes in this PR. Hope you like it!
-Added proper unavailability logic.
-Changed the timout to 9 seconds because otherwise HA would spam the console about it.
-Should fix #73
The unavailability stuff isn't perfect. For example, both entities don't become unavailable at the same time, and the current_page number will update to the next available page once internally even if the device is unavailable. But if it works, it works..

Hey sorry I'm on the road at the moment but I've just merged anyway

Hello! Here are the changes in this PR. Hope you like it!
-Added proper unavailability logic. -Changed the timout to 9 seconds because otherwise HA would spam the console about it. -Should fix #73
The unavailability stuff isn't perfect. For example, both entities don't become unavailable at the same time, and the current_page number will update to the next available page once internally even if the device is unavailable. But if it works, it works..

Thank you very much, will try it right now


Textures not exported by python script

Describe the bug
I use the following script to export to GLTF:
import bpy
import sys
from pathlib import Path

argv = sys.argv
argv = argv[argv.index("--") + 1 :]  # get all args after "--"

filename = Path(argv[0])

bpy.ops.wm.open_mainfile(filepath=str(filename))
bpy.ops.export_scene.gltf(
    filepath=str(filename.with_suffix(".gltf")),
    export_format="GLTF_EMBEDDED",
    export_yup=True,
)

With the default blender cube with any texture applied, I get the following, and the export file doesn't contain the texture:
Blender 2.93.5 (hash a791bdabd0b2 built 2021-10-13 00:53:14)
Read prefs: /home//.config/blender/2.93/config/userpref.blend
Read blend: models/untitled.blend
'/usr/bin/2.93/python/lib/python3.9/site-packages/libextern_draco.so' does not exist, draco mesh compression not available
10:31:49 | INFO: Starting glTF 2.0 export
10:31:49 | INFO: Extracting primitive: Cube
10:31:49 | INFO: Primitives created: 1
10:31:49 | WARNING: Image '<bpy_struct, Image("ds5.png") at 0x7f7e23485408>' has no color channels and cannot be exported.
10:31:49 | INFO: Finished glTF 2.0 export in 0.004320383071899414 s

It works fine if I export using the GUI. Am I missing something?
To Reproduce
Steps to reproduce the behavior:

Create new blender file, add a cube, add a texture to the cube.
Run blender --background --python export.py -- <model>.blend
Open the gltf file and list the textures

Expected behavior
The gui and python script should both generate the same result.
Version

OS: archlinux
Blender Version: 2.93.5

Sorry for the late response. Here it is with another texture: https://tmp.chocolytech.info/blender-bug.zip

Sorry, but I can't reproduce with your file neither:

Not sure what I did last time, but I can reproduce now.
Seems to be an Blender API issue, that doesn't retrieve texture (and even some node) correctly when used in background.
I will open some issue in Blender tracker.

@julienduroure did you end up opening this issue on the blender issue tracker? Could you share a link to that?

Here is the ticket:
https://developer.blender.org/T95550

Has anyone found a solution for this, I am trying to export gltf but running this in docker and it does not export textures?

Hello,
I am no more able to reproduce with recent version of Blender.
Closing this ticket.
(Note: On your test case, your blend file saved image path in absolute paths, so I had to remap it before testing)
Feel free to open a new ticket if you are still facing issues


(PUP-5979) regsubst: hash as replacement parameter

Allow a hash as replacement parameter to the function regsubst again as
it was possible with puppet 3.x.

We prefer commit messages to be written in imperative form on their first line e.g.
"(PUP-5979) Make regsubst function accept a hash to define replacement".

I originally asked if it was valid with empty string as key, but I think it is. I have used that to make a match that matches the empty strings between characters and replaced those with a delimiter - I therefore deleted those questions.
This is all ready to be merged but I would like the commit message to be changed if it is not too much of a hassle for you. Let me know in that case and I can fix that up.

I have changed the commit message as requested. Let me know if I can do anything further.

Thank you for the contribution.


DS 677 notifications tag manager

Jira
https://pegadigitalit.atlassian.net/browse/DS-677
Summary
Notification Tag Manager modal and Notification Settings mockups were created.
Details
A mockup of four separate Modal Tag Manager steps and Notification Settings page content were created in a User section.
How to test
Go over the User section in a pattern lab. Check if the Notification Tag Manager and Notification Settings page content is similar to the design and if the standards of a11y and UX are acceptable
Visual changes
The design of the four steps (white circles on the top right corner) was replaced with our bolt-progress-bar component. The bolt-chip style was changed a little bit.

@mikemai2awesome
I deleted all custom CSS for the Notification Settings page and used bolt components like: listing-teaser, grid, stack, and used some of the utility classes to recreate that design.
For the modals followed the same approach. The only custom code I left is for header (as we discussed on the slack that this could be the only element with the custom code). I'm wondering if this should be left (custom CSS) or I should remove the custom CSS and rewrite the header using the inline bolt-list component. Now the header markup is cleaner but we have a couple of lines of custom CSS. And using the inline bolt-list component will cause a little bit more of the markup but no CSS.
What would be better ? Let me know what do you think @danielamorse and I'll fix if neccessary

@MarcinMr I would say remove the remaining custom CSS and finish building the header with existing components (and maybe inline style or CSS vars for the background gradient?).
The main reason I say this is because you've already converted so much of this to use existing components and utility classes. Normally if we have an "element" class like c-base-tag-manager__header, we'd also have a "block" class wrapping it like c-base-tag-manager. In a component like this we'd also have __body and __footer classes as well, but since you did such a good job of converting to existing components :) I'd say just go all the way.
Otherwise, looks great visually and in code. Take care of this last step and we can merge it.


WIP: Create JRF domain using create-rcu-schema sample

external Jenkins passed at: http://build.weblogick8s.org:8080/job/weblogic-kubernetes-operator-quicktest/623/console passed
internal Jenkins assed passed at: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/2726/console

@anpanigr @vanajamukkara I'm going to delete all the commented out code and sync to the latest develop branch(again) after passing review.


New CAM billing section

@rchakra1, @amwatson1s, @bjswoboda, @cristb   please review.

@gsanchezu please address comments.

Ok @jim-phillips, thanks for your review. I've pushed a commit with them addressed

@gsanchezu is this ready to be merged? If so, please confirm and mention @asanokhin  and he'll get it into the next deployment. We have one going out tomorrow 7/17 and another on 7/19.

@lyzalou  let's wait to see if @rchakra1, @amwatson1s or @bjswoboda have something to add/comment. Thanks!

@gsanchezu Everything looks good. Can you please make a small change.
For the item, where you had
" Issue a Support Ticket requesting separate invoices by your defined Cost Centers"
can you please change to
" Open a Support Ticket request separate invoices by Cost Centers and CenturyLink Billing team will assign a separate Billing Account Number for each Cost Center and makes sure that a separate invoice is generated by CostCenter. "
Other than that, everything looks good. Thank you.

Hey @lyzalou, @asanokhin, this is now ready to merge. Thanks!


add generative-ai-java on springboot

https://github.com/xlorne/springboot-starter-gemini

Hey @xlorne it's not clear what's the issue you're reporting. Could you elaborate?

Well, I found that Generative-AI does not have an SDK for Java, so I open sourced an open source SDK based on Java Springboot.


Release next 6.0.0-beta by February 28th

Internally still working on the upgrade but things look good so far. Nothing new will probably change since the upgrade looks pretty good, but I prefer to have a round of dogfooding prior to a full release.

[ ] Contact cli team and notify of upcoming changes for release 6
[ ] Release the next increment as 6.0.0-beta2 or 3... whichever number we are on
[ ] Thinking about another 5 release. I think I can hack together the replacement webdriver-manager to work with 5.

Well, that did not happen; however, I am almost done moving targets internally. Maybe by the end of the week....

Done! Thanks Craig.
... you're welcome. 😄

Oh instead of a beta release we just made the 6.0.0 release.


Add the draft media types (sticky note)

Any new contribution will start with a sticky note, even before choosing format:

The text-size in the sticky will adjust to fit the available space using fluid type. The format can be selected in this screen or later in the details screen (or stay like this as a sticky note):

start with simple post it (maybe + color)

No, notes can be submitted (e.g. https://manage.chronomaps.net/database/37/table/143/269/row/26).
The form was buggy, it declared fields to be required while they were not visible due to conditions, so the submit button did not allow submitting the form.


Liquidity bug

There should be no fees or donkey burning

there should be donkeys burned. the player would need to provide transport to receive resource. lords may weigh nothing but the second resource would weigh something


Note editor should show preview of the markdown

The editor should allow users to preview the markdown. Similar to how github/stackoverflow has a preview tab which renders the markdown.
Check if there is any lightweight library for react that can be used to build this functionality.

Added react-markdown-editor-lite to provide markdown editing and preview features


Remove Unwanted space in markdown for mobile view

As seen in the above extra space was added between certain words. Remove this gap, and make the rendered HTML consistent with the input Markdown.

This is due to text-align justify, and not a problem with markdown.


v14.4.27 JS: improve "game" prototype

[Current coverage][cc-pull] is 99.18%

Merging [#346][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #346   diff @@
==========================================
  Files            24         24
  Lines           366        366
  Methods          77         77
  Messages          0         77    +77
  Branches          0          0
==========================================
  Hits            363        363
  Misses            3          3
  Partials          0          0

Powered by Codecov. Last updated by [948322b...50ebfbe][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/948322b9c0c6d85caf10d8e79227ebd9f7cacf68...50ebfbe15ca46d81ee91b1f721149c401e8d0c7b
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/346?src=pr


[RFE] Better Windows/WSL2 dev experience

Current situation
The dev experience for WSL(2)/Windows could be improved. Some notes I made so I don't forget:

[ ] There's no specific quickstart instructions (maybe we need some apt-get/download golang instructions build-essential nodejs)
[ ] The apt-get provided golang in the Ubuntu LTS is too old (Deb/Ubuntu provide 13 I think we need 15 for one dependency).
[ ] It doesn't work with minikube as per the minikube-recommended Hyper-V install instructions (It installs /Users/windowsusername/[.kube|.minikube] and headlamp looks for /home/unixusername/.kube, additionally inside the config files it uses "C:\Users\windowsusername\.minikube..." windows paths for certificates and such which would be /mnt/c/Users/windowsusername/.kube inside WSL2).
[x] CPU use is intense for just waiting there doing nothing with make run-frontend, and npm install takes a long time.

Impact
It will be easier for Windows/WSL(2) using developers to contribute.
Ideal future situation
Headlamp should run based on the quickstart instructions, and the development experience should be ok with a suggested development configuration.

After we merged #371 , I think the experience in WSL2 is flexible enough that even if users want to use Headlamp with a Windows-path kubeconfig, they can. Should we close this, @illume ?

I made the items into a checked list so it's easier to see some things that could be done to improve the situation. I think we should keep this open.


[FEEDBACK] My tests, synitra connector and survival recipes.

Hello ! Since there is no comment section on modrinth, i'll put my feedback here.
First, i'd say thank you for your amazing work, as your mod come just in time for the modpack i'm creating (sth based on a complete apocalypse...). I was desperately looking for big robots and you gave me them :D
So, the modpack being on forge, i proceeded to test your mod with the latest version of the synitra connector. Well, it just work out of the box (although it may need the connector extras) so it's a good point.
Also, as you didn't came with any recipes for the items i'm currently planning to add them myself with kubejs (and i think other pack developers will do the same).
Also, i would have two requests/questions :

do you think i can make your mobs spawn naturally with a mod like "in control" (or sth like "custom mob spawn" for fabric) ?
Would it be possible to make the health bars toggleable ?

Thank you again !

Super thank you @Shkeiru for your feedback!
[Your modpack]
Yes..., this is exactly what I wanted to see after releasing my mod!
Thank you from bottom of my heart XD
I'm really looking forward to see your modpack and i will do my best on forge porting!
[In control]
I haven't tested yet. But I think it will probably work, since mob's implementation is so simple.
And if not, I will fix it :)
[Health bars]
Yes possible and I will do it for next release! XD
It was needed to make config feature for other flags, so I will do it at the same time.


fix pathing in HDR-1

e.g. https://github.com/paralax/lfi-labs/blob/master/HDR-1/index.php#L9

see http://php.net/manual/en/function.getcwd.php#38162 and maybe use dirname(FILE)


Generate ScalaDoc to get an API reference

This will reduce the need to surface every square inch of the API in the README too.

Have generated some scaladoc here using Travis & Github Pages
Laminar: https://pishen.github.io/Laminar/com/raquo/laminar/index.html
Airstream: https://pishen.github.io/Airstream/com/raquo/airstream/index.html
scala-dom-builder: https://pishen.github.io/scala-dom-builder/com/raquo/dombuilder/index.html
scala-dom-types: https://pishen.github.io/scala-dom-types/com/raquo/domtypes/index.html

Cannot link from one scaladoc to another by clicking class name, maybe it requires apiURL to be set before publish?
Some UI of the scaladoc are broken (example)

Well, new version is out, I'm gonna close this. I don't think I'll have time to do this anytime soon.


consider renaming master to main

@funkey, what do you think?
It's easy to do, but you would want to be ready to run a command to update your local forks right afterwards

done!


Slider Height not flexible

I have

Image

Description

Following setup for the responsive Swiper, the height no longer works.
If I set height to 100%, then I get whitespace caused by the slides stacking.
Height:auto , same result. It seems that a pixel value is always set, locking the height.
Am I missing an option or css that allows the height to flex?

Fixed my problem using the following in "onSlideChangeStart"
onSlideChangeStart: (swiper)->
        $(swiper.slides).each ->
          $(this).css height: if $(this).index() != swiper.activeIndex then 0 else 'auto'

Setting the "hidden" slides height = 0 and active slide height = auto on change start should fix the problem.

@nolimits4web
Its really nice slider. I am using this slider.
I have one problem while using this slider with onSlideChangeStart.

I have 2 slides in slider.
When I shift from one slide to another. Actual the event should fire but its not getting fire.
While I trying to slider 2 to 3 (3rd slide not present) or trying to slide to before 1st the action raised.

Please suggest something.
Waiting for response.
Thanks

Fixed my problem.
Problem was occurred due to written the function in document.ready()
when I picked that function out problem gets resolved.
// Working Code
var mySwiper = new Swiper('.swiper-container',{
   onSlideChangeStart: function(swiper){
       setSwiperHeight();
   }
})

// Not Working Code
$(document).ready(function(){
  var mySwiper = new Swiper('.swiper-container',{
     onSlideChangeStart: function(swiper){
         setSwiperHeight();
     }
  })
})


feat/workflow

Description
This pull request provides the following changes on the workflow:

Build and tests now runs on linux, macOS and windows
CI now checks the conventional commits rule
CI now runs clippy-rs on source code

Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[X] Other (for changes that might not fit in any category)

Checklist

[X] I have assigned this PR to myself
[X] I have added at least 1 reviewer
[X] I have tested this code
[X] I have added sufficient documentation in the code
[X] I have added the right flag to this PR

CI -> Continuous Integration
Merge yamls in a single one since they are all related
Do not trigger CI is the code or dependencies hasn't change

Done in fd74766

Add dependencies on job, IMO you should not build the app if pass do not test and you should not test the app if the lint failed. That would do lint -> test -> build. WDYT?

How can i make that ?

How can i make that ?

Use needs keywords, let keep it for another PR

Sign your commit and we merge it


Apache HTTP Client 5

Hello!
Do you have any plans to support Apache Http Client 5? I realize it's a bid deal as it rewrites huge chunks.
Thanks for the great library BTW I use it all the time,
Ryan

Hi @ryber
Thank you for you kind words about my project. I'm very happy that it is helpful for you.
Yes, I have a plan to support Http Client 5. I even thought about making my project an official test library for HttpClient 5. I already had small conversation with HttpClient developers but so far nothing was decided.

Hi,
Any updates on this?
Also, thank you for a great project!

Today I've tried to migrate library to the Http Client 5 and it seems that most of the work is just about changing the packages. If there will no unexpected problems I should be able to finish the migration by the end of this week.

I have prepared a version of the library compatible with HttpClient 5.
You can find it on branch master_v5.
It would be very helpful if you could have a look at it and try it on your projects.
In the next few days, it should be also available from Maven.

I can confirm that my tests passed using the master_v5-branch-snapshot.
Thank you very much.

You can find it also in Maven Central Repository.
https://mvnrepository.com/artifact/com.github.paweladamski/HttpClient5Mock/1.0.0-RC1
If I won't find any bugs in 1.0.0-RC1 I will release version 1.0.0 in about two weeks. I don't expect any changes in the API during that time.

I've decided to use the same artifactId.

For mocking HttpClient 4.x use HttpClientMock 1.X.
For mocking HttpClient 5.x use HttpClientMock 2.X.


Fix the lack of Highlight_Word

According to the  Walkthrough: Highlight text,We have to write this.
[Export(typeof(EditorFormatDefinition))] [Name("MarkerFormatDefinition/HighlightWordFormatDefinition")]
[UserVisible(true)]
internal class HighlightWordFormatDefinition : MarkerFormatDefinitio
{
    public HighlightWordFormatDefinition()
    {
        this.ForegroundColor = Colors.Red;
        this.DisplayName = "Highlight Word";
        this.ZOrder = 5;
    }
}

but this example hasn't this.
So I added this code to the example.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Asugakoisi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Remove enabling kubelet service by terraform

On minions kubelet service is managed by Salt, it makes
no sense to enable and start it especially before salt-minion service.

It will be fixed in https://github.com/kubic-project/terraform/pull/12


new lexer request: SystemC, SystemC-AMS, and SPICE

(Original issue 1009 created by eda_globetrotter on 2014-06-22T11:42:37.009034+00:00)
Can you please kindly provide syntax highlighting for hardware description languages (HDLs) such as SystemC, SystemC-AMS, Verilog-A, Verilog-AMS, and SPICE?
Thank you very much, and have a nice day!

I'm closing all requests for lexers/formatters without a patch/PR.


Fixed integer conversion warnings in src/core/security

Added some typecasts to avoid GCC warning about integer conversions when we eventually turn that warning on

Thanks for taking care of this. One small thing but otherwise LGTM. Will merge when travis is green.

The Travis failure is #2178, and seems to be unrelated to this change. All of the Jenkins failures are pre-existing failures, and are also unrelated to this change.


Added Georgian locale (ka_GE)

Added translations for the Georgian language.
Although not very well known, Georgian is a unique language spoken only by the citizens of Republic of Georgia (for thousands of years).
I love your library, and since I had to create a Georgian locale for my use anyway, I thought I might as well create a PR.
Not a lot of libraries have Georgian translations, so your library will stand out even more now!

Pull Request Test Coverage Report for Build 379

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.9%) to 29.258%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/lang/ka.js
0
1
0.0%

Totals

Change from base Build 372:
-1.9%

Covered Lines:
84

Relevant Lines:
282

💛  - Coveralls

Thank you very much.
Please help to fill the testease of the locale.

@hustcc There seems to be no language tests in v4.0.0 branch.

There has one test case of en.

send pr to master, code is merged into master.

Running npm install didn't install jest-date-mock since it was not included in package.json, so I added it. I hope that's okay.

Seem you pr to timeago.js on branch v4.0.0, you should change to master.

Will open a new pull request, sorry for the inconvenience.


Time-based renewal of the API access-key

The API Token expiration date/time is part of the accessKey. The access key consists of three parts using a : as delimiter: {expiration_timestamp_milliseconds}:{user_id}:{access_key_data}.
Example:<PHONE_NUMBER>000:{user_id}:{access_key_data} expired on Wednesday, January 1, 2020 12:00:00 AM GMT.
Now that we know this, maybe we can add a function to check if the key is still valid before initiating an API request instead of renewing it every three downloads.

The accessKey URL query component can be omitted if an Authorization header of type Bearer Token is present. PR #20 implements related changes to the code.


New repo: multicluster-mesh-addon

We would like to create an additional repo multicluster-mesh-addon to manage multicluster service mesh on OCM as an addon.
Related issue: https://github.com/open-cluster-management-io/OCM/issues/34
/assign @mikeshng @qiujian16

+1
Would you be able to do a quick presentation in our community meeting next week?

Sure, I added the topic in the meeting agenda.

@morvencao who will be the maintainer of this repo?

@qiujian16 Any requirements for the maintainer? I can maintain this repo.

the only requirement is the maintainer should be the member of ocm org. And It would be better to have at least 2 maintainers.

done https://github.com/open-cluster-management-io/multicluster-mesh
/close


Proper error handling in as_rust! and new macro for IntoRustByName

"Return" Results from as_rust! instead of using unwrap() and unreachable!.

Implement IntoRustByName<_> for Row using a new macro row_into_rust_by_name!.
row_into_rust_by_name! uses as_rust! and the implementations change a bit, although I think the new behavior is more accurate.
But it still leaves a problem. get_by_name() returns Option<Result<_>>. None if the column can't be found and Some(Err(_)) if the conversion fails. It also returns a custom error if the value is empty (except for blobs) and it doesn't handle null values explicitly. It would be nice if an Option could be returned, that is None in case of a null value.
Maybe we could change the return type to Result<Option<_>> and return an error if the column can't be found. I'm not sure what the use case for the current implementation is, is it a common use case to look for a column that might not be there?

Coverage remained the same at 94.946% when pulling a01ce8cb3b24ca3c49c090c5ec08d3fdb817dff6 on dfaust:master into 3c8800a1c47d06f3dac68fc2a42f0982cf6cb953 on AlexPikalov:master.

Coverage remained the same at 94.946% when pulling a01ce8cb3b24ca3c49c090c5ec08d3fdb817dff6 on dfaust:master into 3c8800a1c47d06f3dac68fc2a42f0982cf6cb953 on AlexPikalov:master.

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   95.56%   95.56%
=======================================
  Files          18       18
  Lines        1870     1870
=======================================
  Hits         1787     1787
  Misses         83       83

Impacted Files
Coverage Δ

src/types/data_serialization_types.rs
28.57% <ø> (ø)
:white_check_mark:

src/types/mod.rs
97.48% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8800a...a01ce8c. Read the comment docs.

We could  build validation before we speak (execute query) to Cassandra to check whether the column name given by the user actually exists. We would get the meta data about the Columns after the prepare phase. We might need to cache that meta data
The after the preparation phase and validate

Maybe we could change the return type to Result<Option<_>> and return an error if the column can't be found.

I prefer to have Option on get by name, similarly to https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.get which has pretty same meaning in terms of HashMap.

It also returns a custom error if the value is empty (except for blobs) and it doesn't handle null values explicitly. It would be nice if an Option could be returned, that is None in case of a null value.

If I'm not missing something we still won't have any explicit differentiation between null- and non-set values as Rust doesn't have NULL. For me it's okay to consider an attempt to convert a empty array of bytes into integer as an error. Maybe we could provide a special error type for such cases. Any way I think it would be better to create a separate issue where we could discuss it in details.

Maybe we could change the return type to Result<Option<_>> and return an error if the column can't be found. I'm not sure what the use case for the current implementation is, is it a common use case to look for a column that might not be there?

is it a common use case to look for a column that might not be there?
it is not common but during the development phase we would definitely use column name  which are not in the db like using names instead of name sort of ...

Result<Option<_>> columns should be considered as optional because of CQL nature. While table contains some column, particular query may not contain a request to get data for this column SELECT one_of_hundred_columns FROM ks.table. Because of that I think that a result of get in this case should be Option.
From other hand result of parsing bytes into struct naturally is Result ie. https://doc.rust-lang.org/uuid/uuid/struct.Uuid.html#method.from_bytes.

@AlexPikalov

I prefer to have Option on get by name, similarly to ... which has pretty same meaning in terms of HashMap

The thing with HashMap is, that it only has one fail state. A key either exists or it doesn't. If you don't get a value back, it is clear that the key doesn't exist. Plus it is totally "legitimate" to ask for a key that might or might not exist, so it might not even be an error if it doesn't.

If I'm not missing something we still won't have any explicit differentiation between null- and non-set values as Rust doesn't have NULL

Rust has Option, which maps completely to the null concept of Cassandra.

For me it's okay to consider an attempt to convert an empty array of bytes into integer as an error

I disagree, having an empty value just like having a null value is totally legitimate. And C* makes a clear distinction between those two.

While table contains some column, particular query may not contain a request to get data for this column

Yes, but that would be a faulty query. And as such would deserve an error message like "column xyz not found".
@harrydevnull

during the development phase we would definitely use column names which are not in the db

So that would be an error then. (see above)

@dfaust yes that would be error; and in case of value present or empty it would be option... exactly my reasoning for result<option<_>>

@dfaust

Yes, but that would be a faulty query. And as such would deserve an error message like "column xyz not found".

It is not. Let's assume that you have table with columns col_a, col_b, col_c. Query SELECT col_a FROM table; is absolutely fine as well as selecting only b, c or any combination of these columns. So each field is in fact optional.

Rust has Option, which maps completely to the null concept of Cassandra.

Absolutely agree here. We might do following Option<Option<Result<_>>>
Option< // getting column
    Option< // empty/non-set or not
         Result<R, E> // result of our attempt to convert a set of bytes into selected type
    >
>

but it seems to be overhead

Another option is to concatenate these two option and return None if columns was not found or it contains null/not-set value

And inner Result is mostly about attempting to convert a "wrong" array of bytes into particular type.

@dfaust @AlexPikalov
Option< // getting column
Option< // empty/non-set or not
Result<R, E> // result of our attempt to convert a set of bytes into selected type
>

seems to really overboard !!
Result<Option<_>> seems to cover all cases  (just my opinion)

if column name is not present in DB -->Error
if column name is present but trying to covert into a wrong type error ---> Error (trying to convert varchar to i32 )
if column name is present and  value is empty --> None
4.if column name is present and  value is there --> Some(value)

@AlexPikalov

Yes, but that would be a faulty query. And as such would deserve an error message like "column xyz not found".

It is not fault.

Ok that was phrased poorly on my part. It's not the query that's faulty, but it's the programmers fault to try to get a column that wasn't fetched.
@harrydevnull
I agree, just one clarification:

if column name is not present in DB --> Error
if column name is present but trying to covert into a wrong type error ---> Error
if column name is present and value is null --> None
if column name is present and value is there --> Some(value)

so it would be Result<T,ColumnNotFoundORParseError> ColumnNotFoundOrParseErroris something i made up; just to show the intent

Makes sense as well.
@dfaust @harrydevnull
So we have two options basically:

Result<Option<_>>

column is not present -> Err(io::NotFound)
column name is present but trying to covert into a wrong type error -> Err("conversion error")
column name is present, but value is null or not set -> None
column name is present and proper value is there -> Ok(Some(val))

Option<Result<_>>

column is not present -> None
column name is present but trying to covert into a wrong type error -> Some(Err("conversion error"))
column name is present, but value is null/not-set -> None
column name is present and proper value is there -> Some(Ok(val))

cc @tupshin it would be interesting to know your opinion as well.

Basically, these two options look almost equivalent for me, event so the second one is the one I like more mainly because it behaves similarly to HashMap::get* and slice::get* it returns None if optional value not found.
Meanwhile I'll create a question on reddit to get more feedback

https://redd.it/5xcj2e this is the discussion

Third option 😄 . Found it in the Book

When faced with both an Option and a Result, the solution is usually to convert the Option to a Result.

So what we also could do is to return just a Result. Try to convert no column, null/not-set value - Err, otherwise Ok

Another way of looking at it is to separate getting the value and the value itself. There can be an error while getting the value (column not fetched or wrong type) but the value itself is either set (Some - which can be empty) or not set (None).

Seems, that Result<Option<_>> is more popular and more appropriate

I've created a separate issue for that. #111


Unable to exit the app (Android)

I am not able to exit the app by pressing the back button (this issue is present in the sample code provided) and I am not able to go back to my chat page after video call in my app

Hi there
you can use the following hint to override a back button handler and implement a back screen navigation https://stackoverflow.com/questions/45346951/override-back-press-react-native-router-flux


ENH: Port TestPluginBase to framework

Thanks @thermokarst 👍 , everything should be addressed!

Thanks @jakereps!
Now it would be great to update any plugins using the old harness:

q2-types
q2-phylogeny
q2-alignment
q2-demux
q2-feature-classifier

Would you mind opening up issues in those projects to indicate the need to switch over? Feel free to whip up some PRs too. Thanks!!

Thanks @jakereps for taking care of all this! 🎉 🎉 🎉 🎉 🎉 🎉 🎉


VM Service: spawned isolate has a pauseEvent type of None despite --pause-isolates-on-start

When an isolate is spawned via Isolate.spawn(), the VM service reports its pause status as "None" even if --pause-isolates-on-start was passed. Here's an inspector view of the Isolate JSON in which the pause event is "None".
This seems to have started some time between 1.15 and 9f43293.
The easiest way to reproduce this is probably to run pub run test  test/client_test.dart -n 'onIsolateStart emits an event when an isolate starts' in vm_service_client.
See also dart-lang/vm_service_client#5

Thinking about this further, this is actually the right behavior; we probably just need to wait until the isolate is runnable for it to be paused.

@nex3 Yes, None is reported before the isolate could be paused (while sources are being loaded, etc).


Reading image sizes lazily

Just read that scale_ratio can be passed when decoding, which sounds awesome! Is it also somehow possible (maybe even with an external package) to read the size (h, w) of an image without loading first.
My use case is a high-throughput scenario, loading images for a deep learning pipeline. Often many of these images are saved in a much larger, but variable, resolution and are scaled and cropped to the same size (e.g. (256, 256)) before being batched and run through the model. It would be super useful to know the image size before decoding the image, so that I can select the smallest possible scale_ratio such that we still have (h>256 ,w>256). Still need to benchmark how this compares in load speed to just loading each image, downscaling and saving it once. Even if it only offers some load speed improvements, avoiding the extra resizing preprocessing step could also help reduce quality degradation, though.

Absolutely, we need an interface to look at the file properties (image size, colorspace, EXIF data, etc). I just need more free time to investigate this as I know little about the EXIF standard. I'm not sure yet whether this should be provided in this package, or in another package, e.g., the not-yet-existed EXIFViewer.jl.
But for this package, we can definitely have something like an exclusive keyword preferred_size = (256, 256) to aspect_ratio to make jpeg_decode generate the smallest output whose size are larger than (256, 256).

the not-yet-existed EXIFViewer.jl.

Maybe just another julia wrapper to https://github.com/libexif/libexif

Right, a preferred_size keyword would definitely do for my use case 👍


🍱 Update Speedtest-Tracker PNG

I updated the  Speedtest-Tracker.png to the new icon from alexjustesen/speedtest-tracker.

I think there is a confusion between two projects.

https://github.com/henrywhitaker3/Speedtest-Tracker
https://github.com/alexjustesen/speedtest-tracker/tree/21125195ccdc6549093bbec855a5fccfbfc64d7e

I opened a issue to ask the maintainer for his plans with this icon and for his opinion on the change.

The rabbit is the icon I'm using in the app and in the docs and making no plans on changing it.
This was the response from @alexjustesen.

@ArthurHuyghe Thanks for the work! I'll add in the old icon as suggested.


Import issues

Hi,
I am having trouble getting pgmult to work (Python 3.5 on Mac OS X Yosemite).  Specifically:
   from pgmult.utils import pi_to_psi, psi_to_pi, ln_pi_to_psi

gives me an error about pypolyagamma:
  from pypolyagamma import PyRNG, PyPolyaGamma, pdgrawvpar, get_omp_num_threads

The error is "no such name PyRNG".  So I changed this to
   from pypolyagamma.pypolyagamma import PyRNG, PyPolyaGamma, pdgrawvpar, get_omp_num_threads

in the corresponding  init.py.  That fixed this error, but now I am having problems with
import pgmult.gp
 ---> 29 import pgmult.gp
      30 reload(pgmult.gp)
      31

      /Users/<USERNAME>/pgmult/pgmult/gp.py in <module>()
      13
      14 PROFILING = False
 ---> 15 from pgmult.utils.profiling import line_profiled
      16 from .internals.utils import \
      17     kappa_vec, N_vec, psi_to_pi, pi_to_psi, ln_psi_to_pi, ln_pi_to_psi, \

      ImportError: No module named 'pgmult.utils.profiling'; 'pgmult.utils' is not a package

Your help would be greatly appreciated!

Thanks for pointing this out! Sorry, we left the code in a bit of a messy state after our last project. I just cleaned up a few imports, so the imports in pgmult.gp should be ok now.
As for the pypolyagamma imports, I believe those were fixed in https://github.com/slinderman/pypolyagamma/commit/809b2c22a1882e288f2d664ad7b756b029a5fbf7. Can you make sure you have the latest pypolyagamma?
If all is working, the pgmult test, test/geweke_test_gp.py should run successfully.
Thanks again,
Scott

Thanks Scott.  I am afraid the new version still has import issues though:
<ipython-input-4-d3ba56e2c5cd> in <module>()
     18
     19 from pgmult.utils import pi_to_psi, psi_to_pi, ln_pi_to_psi
---> 20 import pgmult.gp
     21 reload(pgmult.gp)
     22

/Users/<USERNAME>/pgmult/pgmult/gp.py in <module>()
     18 import pypolyagamma as ppg
     19
---> 20 from hips.inference.elliptical_slice import elliptical_slice
     21
     22 #TODO: Factor out reusable parts of the GP models

   ImportError: No module named 'hips'

I tried cloning hips-libs/hips but was unable to.

Also, for python 3 I believe you want these two lines:
   from urllib import urlretrieve
   import cPickle as pickle

to be
  from urllib.request import urlretrieve
  import six.moves.cPickle as pickle

I got it to work in python 3.


Panic when stopping etcd process

etcd v3.2.9
When stopping etcd, we always get the following panic error. Is there a way of gracefully stopping etcd ?
panic: Drain() is not implemented

goroutine 101105 [running]:
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/transport.(*serverHandlerTransport).Drain(0xc4217b18c0)
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/transport/handler_server.go:374 +0x64
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.(*Server).GracefulStop(0xc420464620)
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/server.go:1006 +0x2e6
github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed.(*Etcd).Close.func2(0xc424b04300, 0xc4202f5cc0)
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed/etcd.go:201 +0x54
created by github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed.(*Etcd).Close
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed/etcd.go:202 +0x20a

Suggestion from gRPC team https://github.com/grpc/grpc-go/issues/1384#issuecomment-317124531

Easy to repro: start a single node etcd cluster with TLS. Spawn a watcher. Stop etcd.


URL in Prisma Client's error message has a typo

Bug description
When Prisma Client encounters a Rust Panic, it crashes like so:

Here's the URL is supposed to be clickable, but isn't, because there's an h missing in the beginning (in https://)
How to reproduce
Use this (incorrect) schema:
model User {
  id    Int
  name  String
  email String

  @@unique([name, name])
}

Use this script:
await prisma.user.findOne({
      where: {
        name_name: {
          name: "Something",
        },
      },
    })

Expected behavior
The URL should be valid, which will make it clickable.
Environment & setup

OS: macOS
Database: Postgres
Prisma version: @prisma/cli          : 2.0.0-alpha.1299
Current platform     : darwin
Query Engine         : query-engine d88852ac341cdf3c7379a08fa1ebc5c444a4aa67
Migration Engine     : migration-engine-cli d88852ac341cdf3c7379a08fa1ebc5c444a4aa67
Introspection Engine : introspection-core d88852ac341cdf3c7379a08fa1ebc5c444a4aa67
Format Binary        : prisma-fmt d88852ac341cdf3c7379a08fa1ebc5c444a4aa67
Node.js version: v12.16.3

Hey @madebysid , could you have another look at this after @pantharshit00 could not reproduce this? With a newer Prisma version this should definitely not happen any more. If you can not reproduce this, we would like to close the issue (or you can do that for us).

Can't see this anymore!


Uplink explosive price trim

About the PR

Cheapens down the uplink grenades by a bit to make them more frequently used and to give engineering more work.

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: BurninDreamer

tweak: Uplink explosives (and EMPs) are now cheaper.

I think explosives shouldn't be any cheaper, gibbing tool and massive hole for 4 TC? No thanks.
EMPs could be cheaper, yes, I don't see them used (only if you get it from surplus).

I think explosives shouldn't be any cheaper, gibbing tool and massive hole for 4 TC? No thanks.
EMPs could be cheaper, yes, I don't see them used (only if you get it from surplus).

With spacing nerf, defibs and how easy it has always been to fix breaches I think it's a good change to make explosives cheaper to have the station actually explode more, as that gives medical bay, security and engineering, as well as random bystanders things to do.
Minibombs and grenades don't cause "massive holes" either, a minibomb fully destroys 1 tile (used grey tiles for testing) and uncovers lattice from 1-4 tiles near the destroyed tile, the "tile" damage is done within a 3x3 square with the minibomb at it's center, the "object" damage is about a 5x5 square with the minibomb at the center, objects include walls, tables, etc.

But consider this: a minibomb has a 10 second timer before it explodes, it's dead obvious where beeping is coming from, it cannot be linked to remote signalers or buttons, and the sound is clear enough I can hear it on without headphones on 20% volume on shitty laptop audio, all of this meaning that people will stay far away from the bomb so you're not getting that instant gib off on anything but a blue moon.
oh yea didnt do as much testing on grenades, they deal like 150 damage point blank to unarmored human, they're okay i guess.

It's arguably good in AOE, but people just hear "beep, beep, beep" and run away instantly, while you sit here and reveal your position because you didn't use remote trigger C4.
I personally would reduce EMPs to like 1 TC because it's a cool item and want to see it used much more than it is now, but they have been 4 at merge and thats probably for a reason.
oh yea ill make a discussion thread about this pr on discord, need opinion from some actual players rather than gh dwellers
https://discord.com/channels/310555209753690112/1118235222119563386

Okay from the (derailed 800 message) Discord thread the opinion on the price changes are mostly positive and the discussion basically concluded.

re-open when you come back to this


Protect EC private key

Enable use of secure heap for EC private keys.
Fixes #13892
The fix to this issue was committed to the master branch not addressed on 1.1.1-stable.
This PR is an attempt to remedy the current state.
The test code below was added to secmemtest.c. Please this change and test is acceptable I can update the test file.
Test Code.
"
struct lcl_bignum_st {
BN_ULONG d;                / Pointer to an array of 'BN_BITS2' bit
* chunks. /
int top;                    / Index of last used d +1. /
/ The next are internal book keeping for bn_expand. /
int dmax;                   / Size of the d array. /
int neg;                    / one if the number is negative */
int flags;
};
static int test_sec_mem_ecc(void)
{
#ifdef OPENSSL_SECURE_MEMORY
int res = 0, mem = 0, fips = 0;
EC_KEY *key = NULL;
EC_GROUP *ec_grp = NULL;
int ec_res = 0;
if (!TEST_true(CRYPTO_secure_malloc_init(4096, 32)))
    goto err;

key = EC_KEY_new();
if(!TEST_ptr(key))
    goto err;

ec_grp = EC_GROUP_new_by_curve_name(NID_X9_62_prime256v1);
if (!TEST_ptr(ec_grp))
    goto err;

ec_res = EC_KEY_set_group(key, ec_grp);
if (!TEST_size_t_ne(ec_res, 0))
    goto err;

ec_res = EC_KEY_generate_key(key);
if (!TEST_size_t_ne(ec_res, 0))
    goto err;

if (!TEST_size_t_ne(CRYPTO_secure_used(), 0))
    goto err;

const BIGNUM *priv_key = EC_KEY_get0_private_key(key);
if (!TEST_ptr(priv_key))
    goto err;

struct lcl_bignum_st* ptr_priv = (struct lcl_bignum_st*)priv_key;
if (!TEST_size_t_ne(CRYPTO_secure_allocated(ptr_priv->d), 0))
    goto err;

res = 1;

err:
if (ec_grp) EC_GROUP_free(ec_grp);
if (key) EC_KEY_free(key);
mem = CRYPTO_secure_used();
if (!TEST_size_t_ne(mem, 0))
printf("Secure memory leaked %d\n", mem);
CRYPTO_secure_malloc_done();
return res;

#else
return 1;
#endif
}
"

Checklist

[x] tests are added or updated

OTC needs to decide if this qualifies as a bug fix or not.

OTC: This does not qualify as a bug fix and cannot be merged to 1.1.1.

Thank you for the contribution but unfortunately as this was not evaluated as a bug fix, it cannot be merged.


typo: reuslt -> result

found a typo, thanks for the repo

Hi @0xlws ,
Thank you for your contrition to improve this project. This PR has been merged.


Switching from alpine to bullseye and to fabric8

To simplify docker multi-arch image handling, I would recommend to switch the openjdk:8-jdk-slim-bullseye base image.
This one combines different architectures within one docker tag, which enables much easier docker-compose handling.
On different archs, we can always use the same unmodified docker-compose file - in contrast to the alpine image, where we had to switch the docker tag, which leads to incompatible docker-compose files on different archs.
Additionally I switched to io.fabric8:docker-maven-plugin, which supports builds on mac m1; the deprecated spotify plugin doesn't...

Many thanks for providing this PR


`--version' does not say it all

$ singularity --version
2.1

Expecting 2.1.2 here, as that was the version I have installed.

Yep, you are right. Fixed in [2.x 50b322c].


render should show malformed YAML for troubleshooting purposes

Command

[ ] archive
[ ] check-image-updates
[ ] delete
[ ] deploy
[ ] diff
[ ] helm-pull
[ ] helm-update
[ ] list-images
[ ] list-targets
[ ] poke-images
[ ] prune
[X] render
[ ] seal
[ ] validate
[ ] version

Who are you?
DevOps Engineer
What do you want to do?
When getting errors such as
✗ building kustomize objects for /path/to/kluctl/deployment failed. accumulating resources: accumulating resources from 'helmrelease.yaml': MalformedYAMLError: yaml: line 99: did not find expected ',' or ']' in File: helmrelease.yaml

it can often be difficult to ascertain what is going on.
If kluctl printed said line and the ones surrounding it, it would be easier to see what exactly the issue is.
Why do you need that?
It allows for easier and faster troubleshooting, especially when working with complicated and/or macro-heavy templates.

Added in v2.15.0

Reopening as this was not added in v2.15.0 :)

Is this not covered by

kluctl render now accepts the --print-all flag which simply prints all rendered manifests to stdout.

If wanted/needed I could look into this this week and see if I can come up with a solution, shouldn't be too hard.

@netthier It will most likely error out and then not show where the error was. This is because the error happens while kustomize is rendering. The --print-all flag prints the result of the kustomize rendering...which does not exist then.
@nullfact0r I'm happy for contributions :) You can ping me here or on the Kubernetes Slack if you need help or have questions in regard to the code base. I would assume that the first thing you'd need to figure out is how to get details about where the error happened inside the kustomize call. And then find a way how to propagate it up so that you can show the error properly.


vasp_test add conventional to primitive cell transformation

Need to speed up the calculation by using the primitive cell

This has been fixed in 4d9b14b567f2987df9a2931418e804d22635f49c


Fix defintion of fireDate

The original PushNotificationIOS from react-native package was taking a Date object for fireDate. Using such an object with this new package however throws an exception "NSmutableDictionary cannot be converted to date".

@laurent22 Released 1.0.6 with your changes.


Lightweight Statistics

What:
We would like to support light weight statistics that will have little to no impact on the performance.
Why:

Speedb performance can be tracked easily by customers
Currently, Rocksdb statistics reduce performance by 20%
Easy troubleshooting
This should be the base line for monitoring graphs

Who:

Testing
-Customers
-POCs

Requirements:

Collecting statistics should not affect performance
Collect statistics once every X operations (x should be a default value that can be changed)
2.1 The user shall be able to change the default and collect in different frequency
The statistics should be printed to a dedicated stats file: Speedb-stats (file name TBD)
3.1  It should keep a history of 4 days and then rotate (TBD, depends on file size)
3.2  The file size/total duration should be configurable
The counters should be accumulated
The following metrics should be collected: (WIP)

Write latency
Read latency
Table sizes
Get
Multi get
User Write (db.write.micros)
Read
Compaction related metrics*
IOs
BW
Writes to the disks (write.raw.block)
Seek

closed due to research on #255


Adding documentation for UI Image constructors.

Checklist

[ ] New Extension
[ ] New Test
[x] Changed more than one extension, but all changes are related
[x] Trivial change (doesn't require changelog)

          3 Messages

:book:
Executed 202 tests, with 0 failures (0 unexpected) in 5.301 (5.611) seconds

:book:
Executed 187 tests, with 0 failures (0 unexpected) in 4.570 (4.829) seconds

:book:
Executed 124 tests, with 0 failures (0 unexpected) in 4.388 (4.479) seconds

  Generated by :no_entry_sign: Danger


Broken docker images in release

Environment

Installation method: Docker
Darkroom version: >= v0.0.5
Operating system: Ubuntu x86_64
Go version ('go version' output): go version go1.12.9 linux/amd64

Steps to reproduce
docker pull gojektech/darkroom:v0.0.9
docker run -p 3000:3000 --env-file <path-to-darkroom.env> gojektech/darkroom:v0.0.9

Observed result
standard_init_linux.go:211: exec user process caused "no such file or directory"

Expected result
The server should run without errors.
Comments
This has most probably resulted from CGO_ENABLED build pipeline.

The problem exists because the build result cannot be executed from the docker image and resulting in not found. This happened because of the binary still need to use some library from the OS which the Busybox does not provide.
Disabling the CGO_Enabled probably will fail the build, as the WebP library that being used use the C library. Another approach to fix this issue is by releasing the binary with static library.

Yes, I also think the issue is with linking the library. I'll have to look deeper into the issue once I get time for this. Feel free to dig deeper and fix this, I'll keep your comment in mind while looking too. ✌


Custom Login Logo URL locaiton?

After setting the custom logo (that works thanks!) it still links to wordpress.org, can this be set with the same function? if not how can we do it?

Looks like this code should work:
function custom_login_url() {
return get_bloginfo( 'url' );
}
add_filter( 'login_headerurl', 'custom_login_url' );

return get_bloginfo('url'); can change to return: 'http://example.com'.

Partially works, it truncates the .com from the end of the URL I set.

I just tested it out and it works. It's basing it off the URL you have set in your database.

This does work! Not sure what I did wrong at first, Alas there is still an Alt tag hover over tag on the image, can that also be set?

This does work! Not sure what I did wrong at first, Alas there is still an Alt tag hover over tag on the image, can that also be set?


Handle overload in scheduler

What changes are proposed in this pull request?
doraloadjob failed if worker got overloaded
Why are the changes needed?
worker got overloaded when batch size too large.
Does this PR introduce any user facing changes?
No.

@ssyssy FYI

lgtm

The behavior LGTM when test locally, thanks for the fix

alluxio-bot, merge this please


Can't always rely on MW's API parser to provide an integer.

MW's API should always provider an integer to the $from variable, but if they ever encounter a bug in that functionality it would immediately create a SQL injection vector in the code.  For sanity $from is wrapped in intval().

Looks good :+1:


Add an applies to flag to Energy Tariff

This pr:

[x] changes the default value for the half-hourly flag on Meter. It should default to false, the current value is wrong. Most meters on Energy Sparks are non half-hourly meters. 75% of them are NHH meters
[x] Adds a new enum option to Energy Tariff (:applies_to). This will be used to indicate whether the tariff applies to just half-hourly meters (:half_hourly), just non half-hourly meters (:non_half_hourly) or both types of meter (:both).
[x] The applies_to option is only relevant for electricity meters so we also set the default to (:both) but adds a validation so that if the value is changed for a gas (or anything other than electricity) meter, then there’s an error.

hi @urbanwide this one's ready for review but just waiting on confirmation if i need an additional migration/after party task to re-set all meters to false (see details in ticket).  might do that in a follow up pr tho.


Prepare v0.12.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.049%

Totals

Change from base Build<PHONE_NUMBER>:
82.0%

Covered Lines:
3323

Relevant Lines:
4050

💛  - Coveralls


Example in docs throws error

using GLMakie, GraphMakie, LightGraphs

GLMakie.activate!()

g = wheel_graph(10)
f, ax, p = graphplot(g)
hidedecorations!(ax)
hidespines!(ax)
ax.aspect = DataAspect()

Throws:
ERROR: LoadError: MethodError: no method matching ne(::SimpleGraph{Int64})
Closest candidates are:
  ne(::Graphs.SimpleGraphs.AbstractSimpleGraph) at ~/.julia/packages/Graphs/Mih78/src/SimpleGraphs/SimpleGraphs.jl:118
  ne(::Graphs.AbstractGraph) at ~/.julia/packages/Graphs/Mih78/src/interface.jl:158
Stacktrace:
  [1-10] ⋮ internal
       @ GraphMakie, Makie, Unknown
    [11] include(fname::String)
       @ Base.MainInclude ./client.jl:451
Use `err` to retrieve the full stack trace.
in expression starting at [path]:7

Package status:
pkg> st
      Status `~/node-size/Project.toml`
  [e9467ef8] GLMakie v0.4.7
  [1ecd5474] GraphMakie v0.3.0
  [093fc24a] LightGraphs v1.3.5

Julia version: 1.7.0 (2021-11-30)

Oh Sorry. This is noise. I didn't notice that the examples were updated recently. I was still importing LightGraphs.jl instead of Graphs.jl


Rocko32

I force pushed rocko64-acpi (sorry).
This branch is then on top of rocko64-acpi, but switches to 32b and turns off acpi.
Nevertheless we can not assume bios has no-acpi so we turn acpi=off when booting from eemc. When booting from usb/sd card you still need to do that manual I use setenv acpi 'acpi=off quiet' prior to run usbboot. Both branches provide a new u-boot, so if you reflash that with this one you will have no-acpi version.
I also added a temporary patch to enable i2c-6. This will only work on the no-acpi kernel. The bus detects, but I haven't tested connecting a device. Maybe you can, mraa should work normal.
Running make image now (so partial rebuild, so far no problems except the CPU fan running at 3000rpm, is a bit hot here)

Good question. Since I'm using UART as a console only and not much relied on Bluetooth functionality, I can't stand for 32-bit only case. Though, for DIY people UART iisue might be crucial and thus better to stick with reliable solution.

Thanks. And what do you think from the general kernel support prospective - I e.g. read somewhere that 32 bit x86 gets much less love these days as x86-64 is prevalent (e.g. those Meltdown/Spectre patches were planned for later)? I haven't yet spent any significant time verifying that, so I'm curious about your opinion here.

The patches have either gone into upstream (so won't apply) or experimental and accidentally committed. The cfg's are nw unneeded as Andy's kernel has them.

Got it, thanks.

So I'm getting a kernel build failure, which looks like some architecture mismatch:
<...>
|   WRAP    arch/x86/include/generated/asm/mm-arch-hooks.h
|   CC       /edison_dev/yocto/vanilla32/out/linux64/build/tmp/work/edison-poky-linux/linux-yocto/4.16.0-r0/linux-edison-standard-build/tools/objtool/orc_gen.o
|   CC      scripts/mod/empty.o
| cc1: error: code model 'kernel' not supported in the 32 bit mode
| cc1: sorry, unimplemented: 64-bit mode not compiled in
| /edison_dev/yocto/vanilla32/out/linux64/build/tmp/work-shared/edison/kernel-source/scripts/Makefile.build:324: recipe for target 'scripts/mod/empty.o' failed
| make[4]: *** [scripts/mod/empty.o] Error 1
| /edison_dev/yocto/vanilla32/out/linux64/build/tmp/work-shared/edison/kernel-source/scripts/Makefile.build:583: recipe for target 'scripts/mod' failed
| make[3]: *** [scripts/mod] Error 2
| /edison_dev/yocto/vanilla32/out/linux64/build/tmp/work-shared/edison/kernel-source/Makefile:566: recipe for target 'scripts' failed
| make[2]: *** [scripts] Error 2
<...>

That's on Ubuntu 16.04 x86-64, which built official (32-bit) + our latest 64-bit images just fine. Investigating...

Hmm. I have that when I build with bitbake -k edion-image after switching from 64b to 32b. If you are using that, you could try bitbake linux-yocto -c cleansstate and then bitbake -k edion-image again.
I've been building the kernel a lot lately and got sick of doing that and just do make image. It's a bit slower as it deletes more (u-boot), but at least it stops complaining.

I can reproduce. First I did make clean followed by make image which gave the error. Then tried make cleansstate then make image. Which worked.
But if you are right it worked because it was the 2nd attempt.

Right, that's similar to what I observe

Build now completed. Next building sdk.

So looks like the first time linux-yocto build runs, it creates the kernel config with CONFIG_X86_64=y, for whatever reason. However using clean/cleansstate and manually removing .config and then runnning do_configure task does create a proper config. I've checked all our settings in kernel-related recipes and everything looks ok in general. I'm now trying cleanall (i.e. it will redownload the source) to see if it changes anything, but this is quite strange (but at least understood now).

Very strange. Maybe we can find from the logs in which order the recipes ran, and from there which created the wrong config?

Yeah, I'll take a look - but I'd be quite surprised if task order would change, that's pretty fixed. I could think of some variables being set with delays - but then again I don't yet understand how to reproduce at will, the clean/cleansstate should've done that.
I run bitbake manually, but those makefile targets are essentially the same, just with checks if it's already setup and so on - additional "helpers" I don't really need.
That git fetch of the kernel is really slow, still at 43% at the moment, so looks like this will continue tomorrow.

Oh, sorry - you meant recipes not tasks - generally other recipes cannot influence that. That's surely something happening within the linux-yocto recipe and looks like there's some difference between "the first time" (and the definition of that is what I'm trying to understand right now) and the "other ones".

No, I did mean the task order of linux-yocto recipe, just phrased it wrong.

Okay, so cleanall and redownloading didn't help, as I suspected. So let me try one last thing before I ditch that for now and start looking into regulatory DB stuff, which should be more fun. make clean you said reproduces that - and it simply yanks the out dir as a whole, let me try that.
BTW, what exactly was the problem with HSU you faced on 64bit? Looking through all the public announcements about Merrifield, it's advertised as 64bit core/SoC, so it doesn't look like it would be a hack to run it like that. So maybe we could just fix the stuff to work on 64 instead of resorting back to 32, which reportedly gets less love from kernel community and produces  bitbake glitches :D

I was on 64b, then checked out 32b, followed by make clean. But that only cleans out, not sstate-cache. So I thought that to be the reason why it tries to build 64b kernel again. make cleansstate seems to fix that. Though in the past I just deleted the contents of bbcache/sstate-cache/ (but kept downloads, so not having to go through that again).
Just checked my log.task_order for linux-yocto, but unfortunately it starts with do_cleansstate. Interesting stuff would be before that.

I've checked the task order - it's fine. First kernel_configme, then configure, as expected. And the result is the same - proper config. So looks like it's something strictly related to the very first time it builds after setup. The only other thing I've noticed is that the NATIVELSBSTRING value changes after it downloads that uninative thing. Maybe that's related, not sure. I'll probably look into regulatorydb stuff now and the get back to this.

Alright. I think we need to get hostapd working first. As I understand the regdb was only needed for a 5G AP. I tried it last weeked, the postbuild script wants to manipulate the hostapd conf file on first run, but the location has changed. Without modifying anything I see the AP on my phone with an open connection, but connecting didn't work. With AP working we could try to reinstate the factory config script / web server... never got to that point.

All right - I've got the 32bit image ready, just need to get the dust off my Edison, flash it and look into hostapd.
As a note to self to document findings: while building the above I've poked around that kernel build issue a bit more and looks like the reason is that for whatever reason when being run for the very first time after setup, the do_kernel_configme() doesn't produce a proper .config, like if the merge_config.sh didn't work properly, while the logs (including the one from that script) seemingly look ok. Need to look further from there.

Hmm. Something wrong with my config fragments? Had that before, but how would that change 32b into 64b.
You might appreciate this:
root@edison:~# modprobe -i i2c-dev
root@edison:~# i2cdetect -r 1
WARNING! This program can confuse your I2C bus, cause data loss and worse!
I will probe file /dev/i2c-1 using read byte commands.
I will probe address range 0x03-0x77.
Continue?  This program can confuse your I2C bus, cause data loss and worse!
I will probe file /dev/i2c-6 using read byte commands.
I will probe address range 0x03-0x77.
Continue?  I put my review comments in the commits. Sorry for rebasing.

Okay, I was going to work on hostapd tomorrow, so won't rebuild right away, but will test afterwards.

So the hostapd stuff aside - let me try building the updated version and let's merge it (if it's ok) - I believe we better chunk the changes instead of keeping this long PR open and updating it continuously.

All right, so I've pushed one commit into the PR with fixes for my comments (all but one - that attribution thing is worth to be checked). Please just squash it when merging.
Now the PR is build- and boot-tested, looks ok. Let's get this merged and start stabilizing it, I see some things to check around wifi and all those official build remnants (I've created a couple of GH issues to track that).

Yes, see above. I wrote this. Andy didn't like it much I think and didn't want to take it. He doesn't like that I copy the circular buffer into a new linear buffer. To make it into the kernel I would probably need to revise this and submit 2 descriptors to the dmaengine. As I wasn't sure those would be handled consecutively by the dma handle (without interchargap) and the current patch works I didn't try this yet.

BTW I split up your commit into i2c: and u-boot: and squashed them with the both erratic commits. I am making rocko32 now to check that I didn't introduce new errors.
Can you please check if I attributed your work correctly? I'm not sure what is the correct way or how to do that and would like to learn that.
If it is ok as is, I'll pull rocko32 into master.

The branch looks (and builds) good to me.
As for the attribution - with such small ones (and within the PR context where it merely fixed the typos right away instead of me commenting and you fixing), I'm not sure it's even worth it :) But typically it's done in a form of just a reference "based on original patch by XYZ", "idea inspired by XYZ" or somesuch. or preserving the commit author in git.
The Signed-off-by line typically means only that the signing off person confirms the patch was developed in accordance with the given project's policies and that the licence and copyright are appropriate. And duplicating it (with the same name) usually is not advised. Such a layered one is typically seen when there's an original author of the patch (signoff 1), which is picked to the repo by the maintainer, which confirms the patch validity and acceptance (signoff 2).
All in all in this specific case I'd say you could've just used my fixes without any specific attribution. And if there were full patches/commits to merge, then you could either (1) commit by yourself and attribute in the commit message or (2) just take the commit and merge/cherry-pick it, preserving the author (and you would be the committer, git separates these two).

No worries, that's not necessary - but thanks!


1.1 known limitations: call out deletes in large txn limitation

Fixes #2535

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e55ecef88a95e8732e09bf38491aafb5dfd70da7/


Crash when TenantResolver returns a null Tenant

Using nuget 0.0.2pre it's not possible to return null in a resolver's ResolveAsync method - e.g. where no Tenant can be located. Returning null causes a NullReferenceException in TenantResolutionMiddleware.cs.
Easily reproduced in the MVC Sample project

You can return a null TenantContext like this
return Task.FromResult<TenantContext<AppTenant>>(null);
This will work and you can handle the null tenant in your app logic as needed.

@andyward does that solve the issue? I've added a new page to the wiki that covers this and updated the MVC sample.

Thanks. I overlooked the generic Task.FromResult
The approach in the wiki works well too.


[Bug]:

Component/Nuget
GPS or Geofencing (Shiny.Locations)
What operating system(s) are effected?

[ ] iOS (13+ supported)
[ ] Mac Catalyst
[X] Android (8+ supported)

Version(s) of Operation Systems
3.0
Hosting Model

[X] MAUI
[ ] Native/Classic Xamarin
[ ] Manual

Steps To Reproduce
run the app and click "Start" Button and minimize or run the app on the background
Expected Behavior
The app  send  geolocation running under background.
Actual Behavior
The app does not send geolocation.
Exception or Log output
No response
Code Sample
public interface ILocationService
{
Task StartListener();
Task StopListener();
}
public class LocationService : ILocationService
{
private readonly IGpsManager gpsManager;
 public LocationService(IGpsManager gpsManager)
 {
     this.gpsManager = gpsManager;

 }

 public Task StartListener()
 {
     if (gpsManager.CurrentListener is not null)
         return Task.CompletedTask;

     return gpsManager.StartListener(new GpsRequest
     {
         BackgroundMode = GpsBackgroundMode.Realtime,
         Accuracy = GpsAccuracy.High,

     });
 }

 public Task StopListener()
 {
      return gpsManager.StopListener();
 }

}
public partial class MainPage : ContentPage
{
int count = 0;
//  IServiceTest Services;
ILocationService svc;
public MainPage(ILocationService _svc)
{
InitializeComponent();
svc = _svc;
}
//method to start manually foreground service
private void OnServiceStartClicked(object sender, EventArgs e)
{
svc.StartListener();
}
 //method to stop manually foreground service
 private void OnServiceStopClicked(object sender, EventArgs e)
 {
     svc.StopListener();
 }

}
Code of Conduct

[X] I have supplied a reproducible sample that is NOT FROM THE SHINY SAMPLES!
[X] I am a Sponsor OR I am using the LATEST stable/beta version from nuget (v3.0 stable - ALPHAS are not taking issues - Sponsors can still send v2 issues)
[X] I am Sponsor OR My GitHub account is 30+ days old
[X] I understand that if I am checking these boxes and I am not actually following what they are saying, I will be removed from this repository!

This is not an acceptable reproducible sample.


[Feature request] Support modded game data files

In my personal single player "mod" (only convenience features) I'm using the vanilla body parts that can be found in misc.txt as red portal shortcuts to some bosses. before the D2R support release (great work btw) they were parsed without any problems, but after they produce errors like this: Failed to parse Horn at row 7, column 10: Unknown mod 429
save game: horn.zip

Hmmm, when I open this file in game I can't see the horn in the inventory at all, even though the save file says that's where it is. That's going to be tough to test blind. Let me see if I can pinpoint the issue just from the raw data.

Ah, I found the "issue". Before D2R support, I was skipping magical properties for normal items because I thought the list was just not there. It happened to work because of the JM headers, which allowed me to jump to the next item. In your case, you actually had magic properties on these body parts which are normal items, so me skipping them was a "happy mistake", I would say.
But with D2R, I had to refactor to not rely on the JM headers anymore as they have been removed, which forces me to parse every property on the item. Your items seem to have a property that does not exist in the game files (I'm assuming you added lines in ItemStatCost, for things like red portal to bosses), so now they fail to parse.
Not sure there is much I can do about this, supporting hacked items created for the base game is something I've tried to do, but supporting modded data files is much harder without a fork.

Your items seem to have a property that does not exist in the game files (I'm assuming you added lines in ItemStatCost, for things like red portal to bosses), so now they fail to parse.

Actually I didn't 😇 I just reproduced it with a clean vanilla installation and modded exactly two things:

chars start with the cube
added one recipe that transforms any item into a horn

after cubing one of the starting scrolls on a fresh char into a horn an uploading the save to your tool, I get the same error as before.
I've attached the save (the char has the horn in it's inventory, not the stash) and the "mod" itself (just extract to your d2 directory and start with -direct -txt)
save: char.zip
mod: mod.zip
If you decide to ignore this issue I have no problem with it, I just wanted to let you know that this is something that happens with the official game files if one could obtain the body parts. They must be special in some kind of way.

Do you get "Could not find base zcv for unknown item" and "Could not find base zkf for unknown item" when using the mods  stackable runes and gems. I'm using this and I think it is causing these errors, although I'm not quite sure.


Bug: Hidden Git columns are still being calculated

Description
The data for the Git columns is calculated even when the columns are hidden. This leads to unnecessary resource consumption and should be an easy way to improve performance in Git repos.
Steps To Reproduce

Hide all the Git columns in the Details layout
Observe that the memory isn't freed up

Requirements

only load Git data for visible columns
free up data if a column is hidden

Files Version
v2.5.21
Windows Version
Windows 11
Log File
NA

I'll see if I can fix it.


Typescript Typings

This project is great, and I am looking forward to using this API in an upcoming project of my own. However, it would be really cool if there were Typescript typings available. Perhaps I can start on a bit of them myself sometime

The lack of typings in this package is one of a few factors that led me to create a new library to replace it. It's published under node-groupme on npm and is written entirely in Typescript from the ground up.
I you appreciate typings and are willing to contribute, please visit my repository where there are Issues explaining what still needs to be done.


Live debugger parsing, expression evaluation, sender and FFI

Parsing goes through an intermediate step, which serde can simply deserialize to, handling which isn't possible by serde is then translated to working structures.
The Evaluator (feel free to clean up lifetime handling if possible. Spent far too much time fighting the borrow checker. Maybe my code is already perfect and I don't know it.) handles all evaluation of the expression language, iteration, error handling etc. and defers to some callbacks for actual evaluation of the values.
Missing: some sending stuff.

Codecov Report
Attention: Patch coverage is 63.39114% with 950 lines in your changes missing coverage. Please review.

Please upload report for BASE (bob/remote-config@95c7998). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             bob/remote-config     #497   +/-   ##
====================================================
  Coverage                     ?   70.16%
====================================================
  Files                        ?      225
  Lines                        ?    31890
  Branches                     ?        0
====================================================
  Hits                         ?    22375
  Misses                       ?     9515
  Partials                     ?        0

Components
Coverage Δ

crashtracker
17.46% <0.00%> (?)

datadog-alloc
98.76% <0.00%> (?)

data-pipeline
51.30% <0.00%> (?)

data-pipeline-ffi
0.00% <0.00%> (?)

ddcommon
84.72% <0.00%> (?)

ddcommon-ffi
69.60% <0.00%> (?)

ddtelemetry
56.37% <0.00%> (?)

ipc
84.77% <0.00%> (?)

profiling
79.13% <0.00%> (?)

profiling-ffi
59.53% <0.00%> (?)

serverless
0.00% <0.00%> (?)

sidecar
43.28% <0.00%> (?)

sidecar-ffi
0.00% <0.00%> (?)

spawn-worker
54.98% <0.00%> (?)

trace-mini-agent
69.36% <0.00%> (?)

trace-normalization
97.79% <0.00%> (?)

trace-obfuscation
95.75% <0.00%> (?)

trace-protobuf
50.00% <0.00%> (?)

trace-utils
91.05% <0.00%> (?)


@value Generates a Twitter link on command page(s)

I'm unsure if this is intended but it seems unnecessary because @value does nothing in twitch chat so most twitter commands would have the direct twitter link anyway. 🍆

Are you sure this isn't an extension you have installed? I don't have the same issue:

I don't think I have any extensions that run in incognito 🤔

I can replicate this. The link appears on the detail page (https://nymn.pajbot.com/commands/991-yonn2) but not on the commands page https://nymn.pajbot.com/commands if you select it from the list.

Ok can confirm this shows up for me: https://i.nuuls.com/eySeP.png
Seems really inconsistent, wasn't showing up for me the other day...

👍 confirmed fixed


Support HTML Dialog Element

The HTMLDialogElement has been added to scala-js-dom, it could also be added here.

Would a PR help?

Yes but not right now. I'm in the middle of rewriting SDT in a completely
different format with source code generators. Once that is done "in a few
days", I'll be open to PRs onto the new branch.

Message ID: @.***>

@Lasering Could you please add type Dialog = HTMLDialogElement to object html in scalajs-dom, it seems that all other HTML element types have an alias there.

Sorry I'm just swamped with SDT / Laminar stuff myself.

@Lasering Could you please add type Dialog = HTMLDialogElement to object html in scalajs-dom, it seems that all other HTML element types have an alias there.

In progress

The PR has been merged.


ViLT failed because result shape differ from aten.add and ttnn.add

Brief describe
add shape mismatch for this input variation
"Tensor<[5]> self = ?", "Tensor other = 0.0"

Run pytest tests/pattern/test_add_shape_mismatch.py can reproduce
FAILED tests/pattern/test_add_shape_mismatch.py::test_add_vilt - assert torch.Size([5]) == torch.Size([1, 5])

Debug log
In ViLT, there have the following code
# /home/ubuntu/venv_pt/lib/python3.8/site-packages/transformers/models/vilt/modeling_vilt.py(122)<listcomp>()
    def visual_embed(self, pixel_values, pixel_mask, max_image_length=200):
        _, _, ph, pw = self.patch_embeddings.projection.weight.shape

        x = self.patch_embeddings(pixel_values)
        x_mask = pixel_mask[:, None, :, :].float()
        x_mask = nn.functional.interpolate(x_mask, size=(x.shape[2], x.shape[3])).long()
        x_h = x_mask[:, 0].sum(dim=1)[:, 0]
        x_w = x_mask[:, 0].sum(dim=2)[:, 0]

        batch_size, num_channels, height, width = x.shape
        patch_dim = self.config.image_size // self.config.patch_size
        spatial_pos = self.position_embeddings[:, 1:, :].transpose(1, 2).view(1, num_channels, patch_dim, patch_dim)
        pos_embed = torch.cat(
            [
                nn.functional.pad(
                    nn.functional.interpolate(
                        spatial_pos,
                        size=(h, w),
                        mode="bilinear",
                        align_corners=True,
                    ),
                    (0, width - w, 0, height - h),
                )
                for h, w in zip(x_h, x_w)
            ],
            dim=0,
        )

The original value of x_h and x_w are
x_h: TorchTensor([12])
x_w: TorchTensor([16])

But after convert to ttnn, the wrong value become
x_h: TorchTensor([[1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]])
x_w: TorchTensor([[12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12]])

And it will cause nn.functional.interpolate failed
>           return torch._C._nn.upsample_bilinear2d(input, output_size, align_corners, scale_factors)
E           TypeError: upsample_bilinear2d() received an invalid combination of arguments - got (Tensor, tuple, bool, NoneType), but expected one of:
E            * (Tensor input, tuple of ints output_size, bool align_corners, tuple of floats scale_factors)
E                 didn't match because some of the arguments have invalid types: (Tensor, !tuple of (TorchTensor, TorchTensor)!, bool, !NoneType!)
E            * (Tensor input, tuple of ints output_size, bool align_corners, float scales_h, float scales_w, *, Tensor out)

../venv_pt/lib/python3.8/site-packages/torch/nn/functional.py:4038: TypeError

After debugging, I think the root cause is the add operator's shape is different (correct shape should be [12], but got [1, 12])
Currently ViLT is work because the guard function guard it
If this issue can solve, then can also remove the blocklist on guard function

The problem may appeared on ttnn.from_torch & ttnn.to_torch, here is the compiled graph of test_add_shape_mismatch
# arg0_1.shape: torch.Size([5])
def forward(self, arg0_1):
    # ttnn_from_torch.shape: ttnn.Shape([1[32], 5[32]])
    ttnn_from_torch = ttnn.from_torch(arg0_1, layout = ttnn.TILE_LAYOUT, device = device, dtype = ttnn.bfloat16);  arg0_1 = None
    # ttnn_add.shape: ttnn.Shape([1[32], 5[32]])
    ttnn_add = ttnn.add(ttnn_from_torch, 0.0);  ttnn_from_torch = None
    # ttnn_to_torch.shape: torch.Size([1, 5])
    ttnn_to_torch = ttnn.to_torch(ttnn_add);  ttnn_add = None
    # _to_copy_default.shape: torch.Size([1, 5])
    _to_copy_default = torch.ops.aten._to_copy.default(ttnn_to_torch, dtype = torch.float32);  ttnn_to_torch = None
    return (_to_copy_default,)

ttnn_from_torch.shape become ttnn.Shape([1[32], 5[32]]) and ttnn_to_torch.shape is torch.Size([1, 5]), it cannot convert back successfully

ghostnetv2_100 has same issue

Retinanet has same issue, its err msg is
IndexError: shape mismatch: indexing tensors could not be broadcast together with shapes [1, 1, 800], [1, 1066]

And one of its root cause can reproduced by this pattern
# result_before.shape: torch.Size([800, 1]) (0~479)
# result_after.shape: torch.Size([1, 1, 800]) (0~480)
arange = torch.ops.aten.arange.default(800, dtype=torch.float32, device=torch.device(type="cpu"), pin_memory=False)
add = torch.ops.aten.add.Tensor(arange, 0.5)
mul = torch.ops.aten.mul.Tensor(add, 0.6)
sub_1 = torch.ops.aten.sub.Tensor(mul, 0.5)
clamp = torch.ops.aten.clamp.default(sub_1, 0.0)
_to_copy = torch.ops.aten._to_copy.default(clamp, dtype=torch.int64)
unsqueeze_6 = torch.ops.aten.unsqueeze.default(_to_copy, 1)
return unsqueeze_6

You can reproduce it by pytest tests/pattern/test_retinanet_pattern.py

Got it. So this is basically related to the issue of full e2e support for Tensor with rank <2

Got it. So this is basically related to the issue of full e2e support for Tensor with rank <2

Yes, it affect widely

I think the root cause is here
    if (layout == ttnn::TILE_LAYOUT and intended_shape.rank() < 2) {
        output_shape.push_back(1);
        tensor = ttnn::reshape(
            tensor,
            ttnn::Shape(
                SmallVector<uint32_t>{1, intended_shape[0]},
                SmallVector<uint32_t>{1, tensor_arg.get_shape().with_tile_padding()[0]}));
    }

It breaks the shape consistency

Please stop spending time investigating this further.
This is a known issue. TT engineers are working on resolving this. It will be resolved in full around the first week of January. Some parts will be fixed earlier.
We are fully aware of this issue.