HTML5 Video not playing in IE10

If you load the http://mediaelementjs.com in IE10 and play the video at the top of the page, you will notice that the video never plays. The loading gif just keeps spinning.

Same issue here. The video is not working under Windows 7 with IE10 and IE11. Says error loading this resource.

I've not been able to replicate this. I'm using IE11 on Windows 7 in VM
Ware Fusion on a Mac.
It looks like the MP3 is loading correctly. Can you play MP4 directly? Does
the local version work? Are there any other factors you can think of that
would be different in your install?
JD
On Mon, Oct 12, 2015 at 7:03 AM, Igor Buyanov<EMAIL_ADDRESS>wrote:

Same issue here. The video is not working under Windows 7 with IE10 and
IE11. Says error loading this resource.
[image: screen shot 2015-10-12 at 15 03 30]
https://cloud.githubusercontent.com/assets/3011068/10427440/6cbf235c-70f2-11e5-9fcb-0a3adbf3bb2e.png
—
Reply to this email directly or view it on GitHub
https://github.com/johndyer/mediaelement/issues/957#issuecomment-147376551
.

--
John Dyer - http://j.hn/

It does work in VirtualBoxVM with Windows 7 and IE10, but does not work under real Windows 7 environment. Do you have a browserstack account? The bug can be replicated there and our client has the same issue in a native Windows 7 machine.
The mp3 underneath the video works fine.
I already tried re-encoding the videos with different settings - no luck.

Yes, I'm seeing that now.
The 'error' event is firing in IE, but I'm not sure why. I'm seeing the
same error on http://www.w3.org/2010/05/video/mediaevents.html and
http://videojs.com/
I'll keep checking.
On Mon, Oct 12, 2015 at 8:00 AM, Igor Buyanov<EMAIL_ADDRESS>wrote:

It does work in VirtualBoxVM with Windows 7 and IE10, but does not work
under real Windows 7 environment. Do you have a browserstack account? The
bug can be replicated there and our client has the same issue in a native
Windows 7 machine.
The mp3 underneath the video works fine.
I already tried re-encoding the videos with different settings - no luck.
—
Reply to this email directly or view it on GitHub
https://github.com/johndyer/mediaelement/issues/957#issuecomment-147390880
.

--
John Dyer - http://j.hn/

So it appears browserstack.com's W7 have some codec problems. Any chance
you can fully update and reboot that machine and try it again?
JD
On Mon, Oct 12, 2015 at 12:25 PM, John Dyer<EMAIL_ADDRESS>wrote:

Yes, I'm seeing that now.
The 'error' event is firing in IE, but I'm not sure why. I'm seeing the
same error on http://www.w3.org/2010/05/video/mediaevents.html and
http://videojs.com/
I'll keep checking.
On Mon, Oct 12, 2015 at 8:00 AM, Igor Buyanov<EMAIL_ADDRESS>wrote:

It does work in VirtualBoxVM with Windows 7 and IE10, but does not work
under real Windows 7 environment. Do you have a browserstack account? The
bug can be replicated there and our client has the same issue in a native
Windows 7 machine.
The mp3 underneath the video works fine.
I already tried re-encoding the videos with different settings - no luck.
—
Reply to this email directly or view it on GitHub
https://github.com/johndyer/mediaelement/issues/957#issuecomment-147390880
.

--
John Dyer - http://j.hn/

--
John Dyer - http://j.hn/

I'll ask the client, who has the Windows 7 machine to check for updates. I do not have a Windows 7 machine with this reproducible bug, except browserstack's live virtual machine.
Hope it's an IE bug, 'cause I already tried all possible solutions.
Thank you for taking a look at this bug. I'll keep you posted.

Any resolution with this?  I'm having the same issue.  W7, IE11, the video will not play:  "Error loading this resource".  It is strange because some videos will play, while others do not, regardless of how many times I re-render them.  For the life of me, I can't figure out what is different between the ones that do play and the ones that don't.

Mopi16, try to re-encode with handbrake for example. It did fix some issues for me.

Thanks, artifex404.  You are correct.  Since I've posted, I have come to believe that it is the way I have encoded the file (I am using an instance of FFMPEG).  The strange thing is that some of the videos in the output stream work, while others do not.  And they do not work only for Windows 7, IE11.  At least I now have a place to start in working on my encoding scheme.  Thanks so much!


plugins redirect to jcenter, which is not available

This might be the wrong place to report this - please redirect me in that case.
Expected Behavior
Gradle resolves plugins to mavenCentral (?) - builds that worked so far should still work after the jcenter sunset.
Current Behavior
Build fails in CI

problem occurred configuring root project 'xxx'.
Could not resolve all files for configuration ':classpath'.
Could not resolve org.apache.logging.log4j:log4j-core:2.17.1.
Required by:
project :
Could not resolve org.apache.logging.log4j:log4j-core:2.17.1.
Could not get resource 'https://plugins.gradle.org/m2/org/apache/logging/log4j/log4j-core/2.17.1/log4j-core-2.17.1.pom'.
Could not GET 'https://jcenter.bintray.com/org/apache/logging/log4j/log4j-core/2.17.1/log4j-core-2.17.1.pom'.
Received fatal alert: handshake_failure
Could not resolve org.jdom:jdom2:2.0.6.
Required by:
project : > com.github.johnrengelman.shadow:com.github.johnrengelman.shadow.gradle.plugin:7.1.2 > gradle.plugin.com.github.johnrengelman:shadow:7.1.2
Could not resolve org.jdom:jdom2:2.0.6.
Could not get resource 'https://plugins.gradle.org/m2/org/jdom/jdom2/2.0.6/jdom2-2.0.6.pom'.
Could not GET 'https://jcenter.bintray.com/org/jdom/jdom2/2.0.6/jdom2-2.0.6.pom'.
Received fatal alert: handshake_failure

...
Context
Was working fine - last build about 3 months ago.
Steps to Reproduce
build.gradle
plugins {
    id 'com.github.johnrengelman.shadow' version '7.1.2'
    id 'application'
    id 'jacoco'
}
...

repositories {
    mavenCentral()
}

sourceCompatibility = 1.8
targetCompatibility = 1.8
...

.gitlab-ci.yml
image: eclipse-temurin:8-jdk-alpine@sha256:6b9d78db2289428157455dc5f5f56255aaaf1ea8e1b0fcb1298a75007103bd0e
...
build:
  stage: build
  script:
    - sh ./gradlew --build-cache assemble
...

Your Environment
Gradle 7.6 via gradlew
GitLab CI SaaS
Java 8
Will try to assemble a sharable MRE in case there isn't an obvious thing glaring at you.

I don't see why it resolves to jcenter in CI. It works fine locally or within a container with above image ...
I cleared the runner caches but to no avail.

References

https://blog.gradle.org/jcenter-shutdown#check
https://status.gradle.com/

@jbartok thanks for the reply.
Was or is? My build is still failing.

Adding explicit pluginManagement to settings.gradle seems to resolve the issue for most projects.
Some projects, that use private maven repos (GitLab SaaS), I receive a new error, though.

Could not determine the dependencies of task ':shadowJar'.
Could not resolve all dependencies for configuration ':runtimeClasspath'.
Could not resolve a.b.c:d:3.4.0.
Required by:
project :
Could not resolve a.b.c:d:3.4.0.
Could not get resource 'https://gitlab.com/api/v4/groups/xxx/-/packages/maven/a/b/c/d/3.4.0/d-3.4.0.pom'.
Could not GET 'https://gitlab.com/api/v4/groups/xxx/-/packages/maven/a/b/c/d/3.4.0/d-3.4.0.pom'.
The server may not support the client's requested TLS protocol versions: (TLSv1.2, TLSv1.3). You may need to configure the client to allow other protocols to be used. See: https://docs.gradle.org/8.0.2/userguide/build_environment.html#gradle_system_properties
Received fatal alert: handshake_failure

It used to work in the past. All that changed since is time and I upgraded to Gradle 8.


BG-18745 Implement initial Drone CI for this KRSv2 project.

JIRA Ticket
https://bitgoinc.atlassian.net/browse/BG-18745
Change Description
The following changes have been added:

Add initial Drone CI pipeline with .drone.jsonnet (with Danny G's help converting from .drone.yml to .drone.jsonnet. Didn't need it.)

In "checks" pipeline, add "lint test" which shows quite a few errors which need to be fixed.

Add pipeline with "unit tests" for node 6. There are failing tests to be fixed.
https://drone.bitgo-dev.com/BitGo/key-recovery-service-v2/20/2/5

Add pipeline with both "unit tests" and "audit test" for node 10.
This pipeline is failing for obviously reasons. To resolve the failures and vulnerabilities, both package.json and package-lock.json must be upgraded with later versions of dependencies, and below is the PR for that.
https://github.com/BitGo/key-recovery-service-v2/pull/70

Tests

Drone CI pipeline: https://drone.bitgo-dev.com/BitGo/key-recovery-service-v2/

Given the latest requirements of obsoleting support for node 6, adding support for node 10, and extracting lint test into a different PR, I'm closing this PR and consolidating into PR https://github.com/BitGo/key-recovery-service-v2/pull/70. Thank you all for your valuable feedbacks.


initial commit for jenkins howto

please post jenkins howto

@csaroka i don't have as much experience with Jenkins as you but I am looking to understand why the localized template is needed vs stable chart in the master Helm tree. My concern is about this being evergreen and not outdated in a short period.
Overall, nice work and very well documented.

@kacole2 You certainly could use the stable chart; I didn't make any changes to the base yaml or templates. However, if the stable chart's values.yml changes, the README may require updating. The localized copy is simply a point of reference for a working configuration.


Create checking conditions depending on the input data

It should be interesting a previous input data checking in order to see if the registration step will be performed correctly.
Remove the restrictive adding of the T1 image.
Stop method if only DTI data is inserted.

Removed the need for T1 image.
Defined an order in which a structural modality will be accepted as the reference. At least one structural image modality is needed.


Need support for another filename format of NPM log files

My Nginx Proxy Manager saves log files as proxy_host-2.log with an underscore between proxy and host. Currently that's not supported.

It's working!

@fuuman do you have archive logs ending in .gz ? If so, what is the filename for those.


Using secrets with _export

I'm using digdag with embulk to upload data to Treasure Data, and I'd like to set a few credential-related variables in the root of the workflow to share across all of the embulk tasks. Currently I can reference the secrets directly in each task and set the environment variables in the command, likesh>: var=${secret:my_var} embulk run file.yml, but when I'm syncing dozens of tables to TD, I'd like to just set the environment variables from within digdag and reference them within the embulk file. Using normal parameters this is possible, but not secrets.
This is what I want to accomplish:
_export:
  TD_API_KEY: ${secret:td_api_key}

+data_upload:
  +task_1:
    sh>: embulk run my_file.yml
  +task_2:
    sh> embulk run my_other_file.yml

However, TD_API_KEY is assigned the literal value ${secret:td_api_key} and is not expanded. Is this intentional? Or is there a better way to do it?

Hello, @nickhall
The ${} syntax evaluate task at execution time. And you can't use it in _export: section.
Support team in Arm treasure data may propose a better solution for you.
Could you ask it in TD?

@nickhall - This is Ivan w/ Treasure Data Support.  A possible solution could be using the liquid syntax to include environment variables in your yml files.  You can read more about it here: https://support.treasuredata.com/hc/en-us/articles/360001502447-Using-Variables-with-Bulk-Import
Please feel free to reach out to us directly at<EMAIL_ADDRESS>with any questions.

@hadrianhu Thank you for the suggestion. That is what I'm trying to do, but the problem is that I have no way of setting the environment variables from within digdag, which is the main part of what I'm trying to do. The root of the problem is that there is no convenient way to load environment variables without a restart of the system, so I'm trying to use secrets as per the recommendation of TD support, but I can't set secrets to environment variables to use across tasks. I'm at a loss here with what to do.

Are you aware of  ‘_env’. This is exactly designed for your use case and should allow you to set secrets. We use this pattern with liquid variables in Embulk to send data to treasure data and works great.

Hello,
I tried this in in my workflow. But I am getting an error. Details below.
Config:
`+run_etl:
_env:
datahub_password: ${secret:datahub_password}
gmcc_password: ${secret:gmcc_password}
+truncate_tables:
  py>: tasks.dealer.run_etl
  from_id: 0
  to_id: 0
  flow: 'emb_truncate_tables'`

Error:
rror: io.digdag.core.repository.ModelValidationException: Validating workflow failed
+gm_etl+run_etl contains invalid keys: '_env': "{"_env":{"datahub_password":"${secret:datahub_password}","gmcc_password":"${secret:gmcc_password}"}}" (config)

Hello, I tried similar way to pass secrets to the subtasks, but it fails.
echo "hello"

Hello @hiroyuki-sato
I tried the same approach to pass secret, i am getting errors.
+run_etl:
  _env:
    datahub_password: ${secret:datahub_password}
    gmcc_password: ${secret:gmcc_password}

  +truncate_tables:
    py>: tasks.dealer.run_etl
    from_id: 0
    to_id: 0
    flow: 'emb_truncate_tables'

Error:
error: io.digdag.core.repository.ModelValidationException: Validating workflow failed
+gm_etl+run_etl contains invalid keys: '_env': "{"_env":{"datahub_password":"${secret:datahub_password}","gmcc_password":"${secret:gmcc_password}"}}" (config)

Hello, @doctor. Have you ever tried the following?
  +truncate_tables:
    py>: tasks.dealer.run_etl
    from_id: 0
    to_id: 0
    flow: 'emb_truncate_tables'
    _env:
      datahub_password: ${secret:datahub_password}
      gmcc_password: ${secret:gmcc_password}

As I comment before,

The ${} syntax evaluate task at execution time. And you can't use it in _export: section.

I suggest you create a new Issue, not comment on the closed issue.

Hello @hiroyuki-sato
Thanks for replying. I did not explain it clearly the issue I am facing. In addition to truncate_tables task, I have 5 more embulk tasks that requires the passwords from secret. Do I need to set the _env: per task to use the secrets or can I set it once in the parent task and reference it in the subtasks?
I also tried creating store params for the passwords, the problem with this approach is that store params are made visible in the UI. In my case passwords are displayed as plain text.
...and yes I will create a new issue going forward. Thanks again.

Close the old issue. Please reopen or file new one if you need.


Failed messages to deadLetter?

AWS SQS daemon sends failed messages to deadLetter queue.
How will sqsd manage the failed jobs/messages? will that be sent to deadLetter like AWS sqsd?
if yes then how should we setup deadletter queue?

It  works only with SQS settings, without any  changes in sqsd daemon.


Table with encapsulated customer filter component and sort

Reproduction link
https://stackblitz.com/edit/angular-3huaun
Steps to reproduce
run the stackblitz
What is expected?
customer filter icon is after sort icon
What is actually happening?
customer filter icon is not in the order

Environment
Info

ng-zorro-antd
7.2.0

Browser
Version 73.0.3683.103 (Official Build) (64-bit)

https://stackblitz.com/edit/angular-3huaun-erxaqg?file=src/app/customer-filter.component.ts
you have to add some style in app-custom-filter
    :host{
      position: static !important;
    }

with version ng-zorro-antd 7.3.2, problem happens again.
Reproduction link
stackblitz


Special characters

Is there any way to support special characters? I tried with template
$stream = stream_socket_client('tcp://<IP_ADDRESS>:9100', $errorNumber, $errorString);
$printer = new Printer(new Template(3, $stream));
$printer->addCommand(new Command\ObjectCommand('address', 'ěščřžýáíééĚŠČŘŽÝÁÍÍÉ'));
$printer->printLabel();

The printed label is with wrong encoded characters.

@RamyTalal Any idea if this is somehow possible please?

According to the Brother docs it should be possible, but I haven't implemented this yet.
See https://download.brother.com/welcome/docp000706/cv_ql720_eng_escp_100.pdf page 21.

Thanks. I actually got it working by setting the Character set to Windows-1250 using the Printer settings tool. After that the special characters are printed correctly. Encoding to Windows-1250 might be needed first before sending to printer:
$text = iconv("UTF-8//IGNORE", "WINDOWS-1250//IGNORE", $text)

Hope this helps someone.
Thanks for an awesome library! Hopefully you'll find some time to add the missing commands.. :)


Share users page between apps

Users/roles should be able to be configured within Arkime/Cont3xt/Parliament/WISE.

[x] shared page that knows which app is using it
[x] admins only
[x] add to Arkime
[x] add to Cont3xt
[x] roles shouldn't require passwords

implemented in #1818


Boolean values not being displayed as boolean

As per title, query results for boolean values are displayed as [object Object] rather than true/false or 1/0: is this a common issue?

Could you share the screenshot of your query and output?

The query is essentially a simple
SELECT     id, value FROM      table
where value is a boolean. The results I get are the following:

with the second column representing the boolean, somehow. For the records I am running it on both macOS Sierra 10.12.6 and Ubuntu 18.04, seeing the same results.

+1 Same issue on windows 10, visual studio code 1.27.2, MySQL server 5.7.21


Robust handling of inconsistent TabularInput keys

Currently, CsvOutput emits a warning if the keys of a TabularInput change after the first call to logger.log(TabularInput). A new key not seen before will be ignored and an old key not presented will be left blank. In other words, CsvOutput conservatively handles dynamic fieldnames.
This behaviour of CsvOutput makes it tricky to log performance of Multi- and Meta- ML algorithms, where there are usually per-task fields but not every task is presented in every iteration, resulting in missing of logs for some tasks.
The desired behaviour to handle inconsistent keys should be

When a new key is encountered

Expand header with the new key.
Expand old rows with empty cells for the new key.

If the value of any key is missing, leave the cell blank.

Introduction
Dowel is a tool that the Garage Team uses for logging results from our various Reinforcement learning experiments.
Dowel can be used to log different types of data such as floats or strings. The logs can be logged to stdout (the console), CSV files, and Tensorboard.
You can check out an example of how Dowel is used here. In fact, almost all parts of the Dowel API are used in this example.
The problem
After statistics such as loss have been logged, and a call to logger.dump_all() is made for the first time, new tabular data can’t be written to a CSV output. This is because currently data cannot be inconsistently logged to CSV, meaning that on every single call to dump_all, the same logger keys must appear. Data that is inconsistently logged will not appear in the CSV output. This is a design flaw that we have been able to work around but affects our workflows. You can read about a user’s issue with this and the desired functionality over here.
Your goal is to solve the problem as well as introduce tests into our testing framework in order to verify your solution.
Some General Instructions

Fork Dowel and install all necessary dependencies (you may want to do this from within a conda environment, or virtual environment. We use python 3.6)
Take a look at this toy example which when run exposes the bug and the accompanying issue mentioned above.
When you have finished writing your solution and tests, upload a PR onto your fork, not onto the upstream repository.
When you are done email us back with the link to your pull request.

If you have any questions, open an issue in your fork, and tag @avnishn and @zequnyu. Our preferred mode of communication on any questions that you have is through github issues and pull requests, as this is how the Garage team communicates generally. For this reason, we won’t respond to any direct emails with regards to help with your project. We will however respond to any other questions that you have via email (interview scheduling, etc)
Best of luck, and let us know if there are any issues as early on as possible


update package.json file

we are getting high risk security issue with phantom-prebuild version as 2.1.12.. so updating that to 2.1.16

I think it would be better to use https://github.com/john-doherty/selenium-cucumber-js/pull/108 instead...


Gradle with intellij problem evaluating root project: Seems to be RoboVM

So I've tested this on a couple different project setups and have noticed that it happens everytime that no matter what platform I try to compile for I receive this error,
Error:(82, 0) Gradle: A problem occurred evaluating root project 'beta_runner'.
> com/github/jtakakura/gradle/plugins/robovm/RoboVMPlugin : Unsupported major.minor version 51.0

It appears to be an issue with RoboVMPlugin, I have no idea if this is widespread or an isolated case though.

Could you please help me? I am also facing the same issue when building an application for iOS & Desktop App.
Thanks in advance.

Please use the forum if you need help.

I get this with the latest version of Android SDK as well right now.

Error:(1, 1) A problem occurred evaluating root project 'app'.

Plugin with id 'com.android.application' not found.


MN availability card

User story
As a nutritionist I want to understand how MN availability will change in the near future, so I can make informed recommendations. I also want to export the data and charts for use in my reports.
Summary
Provide MN availability data in chart and table form
Component

Location

Details

[ ] A line chart shows how the MN availability will change
[ ] Line chart has a description
[ ] You can download line chart as *.png file
[ ] You can download line chart as *.svg
[ ] Table shows the data for three different scenarios (TO CONFIRM - table columns: year, SSP1, % change from index, SSP2, % change from index, SSP3, % change from index) [Is index = 2010 data?]
[ ] You can download the data in the table in a *.csv format
[ ] Clicking on the question mark near the scenarios provides the description of the scenarios

Resources

API data

The data for the table can be accessed via
https://api.micronutrient.support/projection-total
Filtering by country can be acheived via filtering, e.g. for Malawi:
https://api.micronutrient.support/projection-total?filter={"where":{"country":"MWI"}}
Limiting to a given micronutrient can be acheived via e.g. for Calcium:
https://api.micronutrient.support/projection-total?filter={"where":{"country":"MWI"},"fields":{"scenario":true,"year":true,"Ca":true,"CaDiff":true}}
There may in the future be a utility endpoint to ease filtering by Country/Mn e.g. /projection-total/<COUNTRY>/<MN> but the above should suffice for now

Text description for chart [TO DO]

[ TO DO]

Text description for table

The data shows total_allcomdty for selected nutrient (Need to clarify this). Index (2010 = 1.0) .

Text for scenario description

SSP1 - Sustainable development is realized, with relatively high levels of investment in research and development, which leads to rapid technological change (with a sustainable focus), decreasing inequality, lower energy intensity, and high land productivity. This development pathway leads to a future where society is able to relatively easily mitigate or adapt to climate change. There are a high rate of economic growth, declining population growth, and increasing levels of education globally.
SSP2 - This is a middle-of-the-road scenario that follows historical trends. Economic development continues but is not uniform. Environmental degradation continues but at a slowing pace. There is general improvement, but it is much slower than that seen in SSP 1. Climate change presents moderate challenges to both adaptation and mitigation.
SSP3 - This is a fairly negative future pathway characterized by increasing nationalism with greater levels of conflict and challenges to global and regional cooperation. Barriers to trade increase, and countries tend to look inward at the expense of global cooperation. There are lower levels of technological change. Economic development is slow, and population growth is higher. Climate change presents significant challenges for both adaptation and mitigation.

Acceptance criteria

[ ] Nutritionists can easily see how MN availability is expected to change in the future and they can download the data and charts for their own reports.

Sprint Ready Checklist

[ ] Acceptance criteria defined

[ ] Team understands acceptance criteria

[ ] Team has defined solution / steps to satisfy acceptance criteria

[ ] Acceptance criteria is verifiable / testable

[ ] External / 3rd Party dependencies identified

The data for the table is now available via the API.  Details added to the issue

The data for the table is now available via the API.  Details added to the issue


Add collate argument to BatchView

This adds a collate kwarg to BatchView with the following options:

nothing (default): same as previously (obsview(data, is))
false: [getobs(data, i) for i in is]
true: batch([getobs(data, i) for i in is])

The reason collation was added to BatchView itself and not made a wrapper is that this will allow adding support for in-place, collated getobs! later on.
I've made sure BatchView remains type-stable by dispatching on the collate option, with some caveats:

I'm not sure how to get the return type of batch which is needed as a type argument for BatchView (current solution evaluates batch(getobs(...)) which should be avoided
There is a type instability when taking a BatchView((x1, x2), collate=true) i.e. a collated batch view of a tuple. This comes from a type instability in batch([(rand(10), "hello")]). This one explains the failing tests.

Additional comments:

there were implementations for both getobs and getindex; I assume only getindex is needed?
getobs(A::BatchView) is currently defined as getobs(A.data) which doesn't do any batching. I would have thought that it should simply return all the batches

To-do:

[ ] fix type instability in batch
[ ] find better way to infer output type of batch
[x] add inferrability tests for new combinations of arguments
[ ] add tests for collating
[ ] update docstring

I hope the way I tried to tackle type stability is useful, if not, please let me know!

You can use Core.Compiler.return_type though note that if it doesn't infer a concrete type, you might get a super type.

You can use Core.Compiler.return_type though note that if it doesn't infer a concrete type, you might get a super type. I think the current approach is fine though.

I'll see if that works fine, I'd like to avoid running getobs, as as a user I wouldn't expect that to happen, especially if the data container has an expensive loading operation that is lazily applied with mapobs.

Seems to work fine 👍 Will return an abstract type if the batch type is not inferrable which also silences the tests.
Example of non-inferrable is the above BatchView(([1, 2, 3, 4], ["a", "b", "c", "d"), collate=true) which cannot be inferred because batch(([1, 2, 3, 4], ["a", "b", "c", "d"])) is not type-stable which we should tacke in a separate PR.

Codecov Report

Merging #88 (cdc48d8) into main (c1dc3c2) will decrease coverage by 0.54%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   89.97%   89.42%   -0.55%
==========================================
  Files          14       14
  Lines         479      473       -6
==========================================
- Hits          431      423       -8
- Misses         48       50       +2

Impacted Files
Coverage Δ

src/batchview.jl
71.42% <75.00%> (-5.50%)
:arrow_down:

src/obstransform.jl
83.33% <0.00%> (-0.76%)
:arrow_down:

src/utils.jl
93.87% <0.00%> (-0.25%)
:arrow_down:

src/resample.jl
100.00% <0.00%> (ø)

src/Datasets/generators.jl
100.00% <0.00%> (ø)

src/parallel.jl
96.55% <0.00%> (+1.63%)
:arrow_up:

src/observation.jl
88.63% <0.00%> (+1.67%)
:arrow_up:

src/folds.jl
95.83% <0.00%> (+3.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1dc3c2...cdc48d8. Read the comment docs.

getobs(A::BatchView) is currently defined as getobs(A.data) which doesn't do any batching. I would have thought that it should simply return all the batches

agree

I changed the method to return batches 👍


Compilation error---Server returned HTTP response code: 403

Hi,
While compiling, i'm getting below error
./gradlew clean build
Downloading http://services.gradle.org/distributions/gradle-1.4-bin.zip
Exception in thread "main" java.io.IOException: Server returned HTTP response code: 403 for URL: http://services.gradle.org/distributions/gradle-1.4-bin.zip
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1900)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
at org.gradle.wrapper.Download.downloadInternal(Download.java:63)
at org.gradle.wrapper.Download.download(Download.java:49)
at org.gradle.wrapper.Install.createDist(Install.java:51)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:129)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:48)
gradle.properties
cat gradle.properties
version = 0.4
rundeckPluginVersion = 1.1
mavenCentralUrl = http://repo1.maven.org/maven2
My Java version
java -version
java version "1.8.0_221"
Java(TM) SE Runtime Environment (build 1.8.0_221-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.221-b11, mixed mode)

I made few changes to gradle-wrapper.properties to new gradle link. Now i'm getting below
`./gradlew clean build
Downloading https://downloads.gradle-dn.com/distributions/gradle-1.4-bin.zip
.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Unzipping /Users/krishna/.gradle/wrapper/dists/gradle-1.4-bin/ka7flpc4t9igms41h3dpdhmt0/gradle-1.4-bin.zip to /Users/krishna/.gradle/wrapper/dists/gradle-1.4-bin/ka7flpc4t9igms41h3dpdhmt0
Set executable permissions for: /Users/krishna/.gradle/wrapper/dists/gradle-1.4-bin/ka7flpc4t9igms41h3dpdhmt0/gradle-1.4/bin/gradle
Error listing versions of org.rundeck#rundeck-core;1.5+ using class org.gradle.api.internal.artifacts.repositories.resolver.MavenVersionLister$1. Will attempt an alternate way to list versions. This behaviour has been deprecated and is scheduled to be removed in Gradle 2.0
FAILURE: Build failed with an exception.

Where:
Build file '/Users/krishna/code/corp/rundeck/salt-step/build.gradle' line: 79

What went wrong:
A problem occurred evaluating root project 'rundeck-salt-plugin'.

Could not resolve all dependencies for configuration ':runtime'.
Could not resolve org.rundeck:rundeck-core:1.5+.
Required by:
:rundeck-salt-plugin:0.4
Failed to list versions for org.rundeck#rundeck-core;1.5+.
Could not list versions using M2 pattern 'http://repo1.maven.org/maven2/[organisation]/[module]/[revision]/[artifact]-revision.[ext]'.
Could not GET 'http://repo1.maven.org/maven2/org/rundeck/rundeck-core/'. Received status code 501 from server: HTTPS Required
Could not resolve com.google.code.gson:gson:2.2.2.
Required by:
:rundeck-salt-plugin:0.4
Could not GET 'http://repo1.maven.org/maven2/com/google/code/gson/gson/2.2.2/gson-2.2.2.pom'. Received status code 501 from server: HTTPS Required
Could not resolve com.google.guava:guava:14.0.
Required by:
:rundeck-salt-plugin:0.4
Could not GET 'http://repo1.maven.org/maven2/com/google/guava/guava/14.0/guava-14.0.pom'. Received status code 501 from server: HTTPS Required
Could not resolve commons-validator:commons-validator:1.4.0.
Required by:
:rundeck-salt-plugin:0.4
Could not GET 'http://repo1.maven.org/maven2/commons-validator/commons-validator/1.4.0/commons-validator-1.4.0.pom'. Received status code 501 from server: HTTPS Required
Could not resolve org.springframework:spring-context:3.2.2.RELEASE.
Required by:
:rundeck-salt-plugin:0.4
Could not GET 'http://repo1.maven.org/maven2/org/springframework/spring-context/3.2.2.RELEASE/spring-context-3.2.2.RELEASE.pom'. Received status code 501 from server: HTTPS Required
Could not resolve org.apache.httpcomponents:httpclient:4.2.4.
Required by:
:rundeck-salt-plugin:0.4
Could not GET 'http://repo1.maven.org/maven2/org/apache/httpcomponents/httpclient/4.2.4/httpclient-4.2.4.pom'. Received status code 501 from server: HTTPS Required
Could not resolve org.apache.commons:commons-io:1.3.2.
Required by:
:rundeck-salt-plugin:0.4
Could not GET 'http://repo1.maven.org/maven2/org/apache/commons/commons-io/1.3.2/commons-io-1.3.2.pom'. Received status code 501 from server: HTTPS Required
Could not resolve com.google.code.findbugs:jsr305:2.0.1.
Required by:
:rundeck-salt-plugin:0.4
Could not GET 'http://repo1.maven.org/maven2/com/google/code/findbugs/jsr305/2.0.1/jsr305-2.0.1.pom'. Received status code 501 from server: HTTPS Required

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 18.18 secs`

I don't know if this is already solved but I got to compile it by changing the maven URL from http to https in gradle.properties.
Also, for gradle-wrapper to work I had to change to https the url in gradle/wrapper/gradle-wrapper.properties

Had to perform the same modifications as listed above, flipping to HTTPS to get to this point
./gradlew clean build --debug 09:46:51.757 [DEBUG] [org.gradle.logging.internal.DefaultLoggingConfigurer] Finished configuring with level: DEBUG, configurers: [org.gradle.logging.internal.OutputEventRenderer@71d15f18, org.gradle.logging.internal.logback.LogbackLoggingConfigurer@17695df3, org.gradle.logging.internal.JavaUtilLoggingConfigurer@6c9f5c0d] WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.jruby.ext.posix.util.FieldAccess (file:/home/user/.gradle/wrapper/dists/gradle-1.4-bin/3qf9ve1tumvav5egd5m6ofv9as/gradle-1.4/lib/jna-posix-1.0.3.jar) to field java.io.FileDescriptor.handle WARNING: Please consider reporting this to the maintainers of org.jruby.ext.posix.util.FieldAccess WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release 09:46:51.903 [ERROR] [org.gradle.BuildExceptionReporter]  09:46:51.905 [ERROR] [org.gradle.BuildExceptionReporter] FAILURE: Build aborted because of an internal error. 09:46:51.906 [ERROR] [org.gradle.BuildExceptionReporter]  09:46:51.907 [ERROR] [org.gradle.BuildExceptionReporter] * What went wrong: 09:46:51.909 [ERROR] [org.gradle.BuildExceptionReporter] Build aborted because of an unexpected internal error. Please file an issue at: http://forums.gradle.org.
Can't seem to figure out how to resolve this.
java -version
openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.18.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.18.04, mixed mode, sharing)
javac 11.0.11


Fix small typo in installation-overview.md

This change is

Coverage remained the same at 87.515% when pulling 7377cc4dcd1f69e345b72cc7dd1c4705008bdea9 on faheempatel:patch-1 into 1081266e4907533bc8628c0f8ca25352ccc8ad05 on shakacode:master.

@faheempatel thanks!


Steps to Reproduce

Toggle a widget
Click the menu

Current Result

Expected result

Should be able to see the menu

Browser and version
Chrome

Duplicated https://github.com/CartoDB/cartodb/issues/11790.


Update Mono version to <IP_ADDRESS>

Update mono to version <IP_ADDRESS> from version 5.12
Description
On travis, the used version of mono was 5.12. Updating it is necessary to use newer versions of the .net framework and the C# language
Related Issue
#4216
Motivation and Context
Updating it is necessary to use newer versions of the .net framework and the C# language
Requires Documentation Change
No changes needed
How Has This Been Tested?
Local machine running the same version
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

HI @Leonardo-Ferreira we require 3 months live testing to ensure the stability of the mono in production environments. So far every version of Mono since 5.12 has exploded with memory leaks within 2 weeks. We'll continue testing and upgrade when its safe.


[Feat] Activation offloading for distributed lora recipe

Context
What is the purpose of this PR? Is it to

[x] add a new feature
[ ] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?

Change docstring to reflect arg change activation_checkpoint -> enable_activation_checkpoint
Add arg enable_activation_offloading and logic to do activation offloading

Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

[ ] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[ ] update docstrings for any new or updated methods or classes
[ ] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness
[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

[x] I did not change any public API
[x] I have added an example to docs or docstrings

While we were working on this PR, we observed a weird behaviour in the trace.
Steps to reproduce
1. Clone repo at this branch
git clone --branch feat-activation-offloading-streams-dist git@github.com:Jackmin801/torchtune
cd torchtune

2. Dev Install with torch nightly
pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu121
pip install -e ".[dev]"

3. Login to huggingface and download model
huggingface-cli login --token <HF_TOKEN>

tune download meta-llama/Meta-Llama-3.1-8B-Instruct --output-dir /tmp/Meta-Llama-3.1-8B-Instruct

4.  Would you be able to run it with activation on and off for ~25-50 steps and compare loss, memory, tps?
If you use weights and biases, its probably the easiest way to take a screenshot (you can login with your gmail, get the token, pip install wandb, wandb login, insert your token)
then you can run your config like this:
tune run --nproc_per_node 2 lora_finetune_distributed --config llama3_1/8B_lora max_steps_per_epoch=50  epochs=1 metric_logger=torchtune.training.metric_logging.WandBLogger log_peak_memory_stats=True ...other params...
Please use dataset.packed=True, compile=True, enable_activation_checkpoint=True, enable_activation_offload=true/false
if loss and TPS is about the same, but memory is much lower, this should be easy to approve.

Loss seems to be roughly the same (difference probably caused by flash attn scheduling). The memory usage is reduced by ~20% with a tps reduction of ~2%. I guess this is ok to merge?

will get to this tomorrow. Thanks for posting the results!


Guide Creation Flow V2

Here is a mockup flow for how we can improve Guide Creation in a few ways:

It integrates the timeline building feature. This was discussed in #510 though in this version I tweaked what the member enters and in what order to make it easier on them and a little more logical. Feedback?
It simplifies the first screen to be just about choosing the Crop - nothing more (everything else was moved to the final touches page) This change is because we've had some feedback that uploading a crop photo on the first page seems weird and out of place. I agree. Notice I also reframed this photo as 'Choose a featured image for the guide' which would allow the member to choose from photos they've already uploaded to the Guide.
Actions can be of type ordered or unorderd. This concept was lost in communication when Actions were builtout as they are today. The modal is replaced by showing the options in the same area as the questions. I think this is less interruptive to the member's flow/experience. What do you think?
The 'Stage Overview' and 'Stage Actions' sections are now combined into one UI element (the left sidebar nav) I think this cleans up the page, helps focus attention, prevents the need to scroll after advancing to the next stage, and makes the data entry process for each section uniform.

What do you think? Is this improved? What other ideas do you have?
I think once we nail down a V2 design that we're all happy with, this should be the next step for us because the guides are our main 'product', so we should be making the creation of them as good (fun and easy) as it can be.

Edit: I then undid that because it didn't actually make sense to do.

All of these changes make sense to me. I don't know about timeline though, there's some easy things that can be moved around. Maybe this needs to be broken down more, I'll have a think.

Cool, let me know what you think about. I'm happy to make more mockups and throw around other ideas :)

@roryaronson I really liked what Kevin got at in his email, copies here:

Some thoughts I had about software development and guide creation (summarized since my notes are back home). I see about 4 obstacles to guide creation. 1) time. 2 hours to make a guide to me seems impossible for gaining crowd sourcing momentum. 2) lack of confidence. People have no confidence in themselves as authorities for plant growing and even those I would deem beyond capable are intimidated. 3) significance. Who will see the guide these people made after all their hard work? Right now it's a dead guide. 4) Fun. Making guides is not fun. People say the process should be like turbo tax, but the huge obvious difference there is that taxes are mandatory. Therefore we must be even funner and easier than turbo tax (ideally).

Solutions I see are mostly software based. 1) I think we should try to get people some tangible product from their work after only 15 minutes of work. Just get them hooked even, and praise the heck out of every single thing they do. 2) to tackle the lack of confidence thing one idea I had is to tell a story. Expose newcomers with some rookie guide creators success story. Sally wouldn't call herself a great gardener, but one day she made a guide that ended up helping thousands of people. All the praise she got from these people made her feel good. Etc. 3) from pop up cards telling the creator how great their contribution is, to social verification by seeing how many people planted your guide in their garden, to forums and guide upvoting. 4) badges for everything, less time consuming, not needing to finish a guide, maybe even allowing guide collaboration, to Having other reasons for people to be on the site other than guides(creation or consumption).

I think what might be something good to explore is a modular way of building guides. We start with the basics (name, crop, pictures, basic timeline). The "back of the seed packet" stuff. Then we show the incomplete parts of the guide as some form of "fill this bit in" tags. "Make your timeline more complete". "What stages do you think require special attention?".
That way, users get the immediate feedback. Their guide is up in 15 minutes, and they're not drawn into this long process. It's also useful information right off the bat (if we get the timeline to work properly). Then we let them dive into fleshing out the details.
Thoughts?

I like that - kinda going back to the WYSIWYG idea from long ago. Definitely something worth exploring in a mockup. We would need to be careful of showing too much of an incomplete Guide because that gets intimidating. From what I remember, that's why we moved away from the total WYSIWYG creation model.
Something else we could think about is encouraging Guides with only a few stages. Like, 'Its totally okay to make a Guide just about harvesting apples. Not an expert in propagation? No problem!'
We also had talked about a 'Preview' button in the Create Guide Nav that the member could use to preview the completed Guide with for anytime/instant feedback. That's how creating a Kickstarter campaign works (which is a similar process).
@xbertolerox, regarding your 'lack of confidence' point, how do you think Instructables or a recipes website has gotten past this (if at all)? I like the idea of telling member stories as a solution, and also creating a video or something showing how easy and fun it is to make a Guide

I made a thing! Its a new iteration of the V2 flow I made above. This one squashes Timeline creation into 3 screens instead of 4, and moves some of the explanatory text into helpful hints from Bumble our :bee: mascot. Just ideas worth exploring I think :)
Something else I thought of while making this is how photo uploading works on Instructables. Basically they have a bottom bar where you can upload a bunch of photos. They all get uploaded and hang out in this bottom bar. Then the Instructable creator can drag and drop them into the appropriate step(s) in their Instructable. It seems to speed things up, especially when one doesn't know if they want to use a photo or not, or which step they want to use it in. It avoids double uploading too when using a photo in multiple places, and avoids having to open up a file picking modal repeatedly.

I think as far as modular completion goes, LinkedIn does a decent job. I filled in my basic info, but every time I would log on it would have a highlighted segment brought to the top of the page asking me to complete it in order to look more professional/competitive. Every time I logged on it would ask me something, and over the course of a week I ended up with a pretty fleshed out profile. It also gives you a profile rating on the side. I've got a "superstar" profile so now I feel baller.
Rory I think one way recipe sites and instructables overcomes the confidence issue is by letting shitty content on the site. This is just a hunch, but if people see something they could easily improve on then they're less intimidated. They know where the standard is and that they can raise it. Especially if you add a competive edge such as featuring good instructables, giving gold stars, and holding contests. I wonder if it would be helpful to put the notion that we must serve our member nice guides on hold for a bit. Then we can try to get the ball rolling with any guides that get made, and challenge others to begin organically raising the standard of quality.

Honestly I feel the same. Our content is very structured at the moment, and
this is awesome, but maybe it's intimidating? I think it would actually
work really well modularly. I'm imagining the power rangers robots. I'm
happy to do some exploration sketches, though they'll probably be a lot
more low-fi.
@xbertolerox, would you want to come up with some concepts as well? I think
you and Kat might have the best idea in mind. I'll ask her on slack (unless
she has a github account?)
On Jun 11, 2015 15:48, "xbertolerox"<EMAIL_ADDRESS>wrote:

I think as far as modular completion goes, LinkedIn does a decent job. I
filled in my basic info, but every time I would log on it would have a
highlighted segment brought to the top of the page asking me to complete it
in order to look more professional/competitive. Every time I logged on it
would ask me something, and over the course of a week I ended up with a
pretty fleshed out profile. It also gives you a profile rating on the side.
I've got a "superstar" profile so now I feel baller.
Rory I think one way recipe sites and instructables overcomes the
confidence issue is by letting shitty content on the site. This is just a
hunch, but if people see something they could easily improve on then
they're less intimidated. They know where the standard is and that they can
raise it. Especially if you add a competive edge such as featuring good
instructables, giving gold stars, and holding contests. I wonder if it
would be helpful to put the notion that we must serve our member nice
guides on hold for a bit. Then we can try to get the ball rolling with any
guides that get made, and challenge others to begin organically raising the
standard of quality.
—
Reply to this email directly or view it on GitHub
https://github.com/openfarmcc/OpenFarm/issues/638#issuecomment-111141538
.

Sure I will take a crack at it in the next few days. What would be most helpful to you? Are you imagining a reworking of the guide creation flow that we currently have, just to see where things could go? Put more ideas on the table kind of thing?

@xbertolerox I was just thinking the roughest idea of what you think would be a good flow. We can iterate on that.

I think at this point we should be exploring as many ideas as possible, so this is all great.
The LinkedIn example is a good one. I wonder how that can apply to Guides though. On LinkedIn you have just one thing - your profile, which is about you, so you can feel comfortable updating it anytime. On OpenFarm you would potentially have multiple Guides, but maybe not be checking them regularly once you make them, and maybe not want to add to them, or maybe not have the content ready when the site prompts for it. I think about the Instructables I've made - I never check them or update them unless I get a comment I want to respond to.
On another train of thought, it seems like there are two use cases for Guide Creation:

Member makes a complete or partial (but complete to them) Guide in one sitting, potentially updating it with new content every once in a while, but maybe not.
Member is going to make a Guide incrementally as they grow the plant and learn about it - They make a partial Guide initially and then add Life Stages and new content regularly over a few months (a modular approach)

My hunch is that both use cases will happen often.

Hi Rory and hello all!
My name is Farman and I'm excited about working with y'all. Two things this comment will be mentioning:

usability testing

life stages decision process

So I looked over all these comments and the creation flows but I was wondering if you have performed any usability tests on farmers/growers/plant hobbyists? I think that would also help make optimal decisions on the interactivity, accessibility, and functionality. What you have to offer so far is enough to perform a test for usability. It would also get a better sense of testing this out on users who aren't familiar with the design process but more just actually using the site.

When I first used the site, I noticed a lot of bugs like making a garden was not responsive, but I can see that things have dramatically improved especially with the process of creating a guide now. I like that a lot! I might also add that I love this is a User Generated Farm Guide because that can really get more farmers involved to collaborate online and work across more than just their local farmer market. But, I digress.

I don't know if this has been mentioned but is the life stages offering too many options? I noticed there are nine and, from an amateur farmer's perspective, it looks like some of those can be under the same thing. For example, Preparation + Sow + Germination + Seedling = Seeding, Juvenile + Adult + Flowering = Growing, Fruit + Dormant = Production. This may have some inaccuracies, but it was just an example to explain the more simpler the design, the better the interaction.

Hey @farmanp thanks for jumping into the conversation! We have done some usability studies with a handful of people - and we got a lot great feedback from them. We have a summarizing document here if you want to browse through.
Though I agree with you that the more simple design is almost always the better one, a lot of the feedback we've received has been 'there aren't enough options'. At least part of what makes some online resources not that useful is that they are too generic. And it seems that people who are interested in contributing to OpenFarm want to be more specific because they find that to be the most valuable content. A major thing that people want too is 'location based' advice. So most people aren't looking for a catch-all generic guide, they're looking for something tailored to them in some way.
This all being said, it would be great to A/B test two different guide creation flows - one with all the life stages as we have it now, and one with just a few more broad groupings as you've described. Though we barely have enough development resources (at the moment) to build one! But, I think it would be well worth making mockups of alternate flows.
Also, if you're interested in doing more usability studies - that would be great! Kevin Bertolero and/or Kat Ying might be able to assist you in doing an interview cause they've done a few already.

tl;dr - Let's use the "press and hold" function to give users more options when creating guides!
Awesome and if you need some help with creation flows and creating mockups, I can help!
When it comes to designing the step by step process, I see a great opportunity to implement the "press and hold" action for making advanced customizations to a garden guide, similar to this:
http://codepen.io/masterx2/pen/kFyCt
The mechanics could be altered but the takeaway is that simple options look like the core decisions you have to make, but if you really wanted to add more, you could press on one of the steps and hold it down to open more options. For example, let's assume that the options now are Seeding, Growing, and Production. If you wanted to make significant actions to the individual process of each stage, you could click down on the stage (click "seeding") and when you hold down, more options would show up. It's similar to the what Maya offers and you can see it being much more supportive to everyone's needs in the end so that it doesn't scare away some people from using it. I imagine it would have some difficulty to implement, but I thought it would be very unique to the user experience.
I'll speak with Kevin and Kat.

My main concern with that technique is that I don't know how discoverable long presses are on websites. Do you have any research on that available?
Just a cursory search of UX StackExchange brings up this:
http://ux.stackexchange.com/questions/24852/context-sensitive-click-long-click-yea-or-nay
http://ux.stackexchange.com/questions/1257/indicate-long-click-option-to-user-on-android
http://ux.stackexchange.com/questions/14284/tap-double-tap-long-press
http://ux.stackexchange.com/questions/24460/press-and-hold-or-long-press-gestures-unintuitive
It looks like most people recommend staying away from long press, even on mobile, where I thought it might be permissible.
NNGroup also recommends against hidden navigation options:
http://www.nngroup.com/articles/top-10-ia-mistakes/
I think a drop-down with "more options" might be a better option. Or an indicator that collapses or opens up hidden stages?

I don't think long-presses are good on the web because they are not common (Or maybe they are and I have just never discovered them!! ;p). And definitely not anything with a 'middle click' - that codepen example doesn't work on either of my laptops :(
I think we're onto something here though - at every step of Guide Creation, we want to find a balance of which options to show by default and which ones to 'hide' but still have available for those who want them. Furthermore, finding the best way to 'hide' the extra options be it menus, dropdowns, just making them smaller, etc.
Here's a new idea: What if we had both generic and specific options for life stages. So we had both a 'Growing' stage, and also the Seedling, Juvenile, Adult, Flowering, etc stages. Depending on how the member thinks or how they want to setup their guide, they could choose the generic route, or the more specific route. Mockup:

I think Farman is definitely on to something
Reducing the life Stages could be a good way to reduce guide creation time
and lower the intimidation barrier. I've never used long clicks on a
computer, but I like your mockup Rory (love the mascot/comment comb!).
I like the idea of nesting more complex actions or stages. The simple
guides can be made with more ease, yet the site can still feel technically
suited for growers.
-Kevin
On Friday, June 26, 2015, Rory Aronson<EMAIL_ADDRESS>wrote:

I don't think long-presses are good on the web because they are not common
(Or maybe they are and I have just never discovered them!! ;p). And
definitely not anything with a 'middle click' - that codepen example
doesn't work on either of my laptops :(
I think we're onto something here though - at every step of Guide
Creation, we want to find a balance of which options to show by default and
which ones to 'hide' but still have available for those who want them.
Furthermore, finding the best way to 'hide' the extra options be it menus,
dropdowns, just making them smaller, etc.
Here's a new idea: What if we had both generic and specific options for
life stages. So we had both a 'Growing' stage, and also the Seedling,
Juvenile, Adult, Flowering, etc stages. Depending on how the member thinks
or how they want to setup their guide, they could choose the generic route,
or the more specific route. Mockup:
[image: more options life stages]
https://cloud.githubusercontent.com/assets/5524043/8386314/2bd69782-1c04-11e5-8c8f-d9ff94cf8e4f.png
—
Reply to this email directly or view it on GitHub
https://github.com/openfarmcc/OpenFarm/issues/638#issuecomment-115863803
.

--
Kevin Bertolero
Forestry & Natural Resource Management, Cal Poly
(209) 312-1075

@roryaronson just for clarification, what's the green circle mean in your mockup, and what does it mean when something is selected in the more options and on the "generic options". Does it make sense to show both? Should they maybe be made more distinct? What "more options" fall within Preparation? Do they break down that easily?

@simonv3 the green circle means that that stage has been selected to be used.
I think we could go in two directions here.

Generic options and Advanced options are separate. You can either choose from the generic three OR the advanced dozen. But you can't pick from both at one time.

All advanced options are 'children' of the generic options as though the generic options were categories or 'meta-stages'. So each advanced stage would have to fit into one of the generic stages. One can either pick JUST generic options, OR by picking advanced options the 'parent' generic option is also automatically selected. This might involve displaying somewhat of an extra layer on the timeline because this would imply the generic life stage would be occurring concurrently with the advanced option. For example, on the current Timeline mockups, the 'Plant's Lifetime' is already somewhat of a 'meta-stage' that encompasses all advanced life stages. Imagine adding in generic options to the hierarchy: 1) Plant's Lifetime, 2) Generic Life Stages, 3) Advanced Life Stages, where everything is nested and occurring concurrently.

Am I making sense here? ;p
I think I am in favor of option 2. Are there other options?

Here is a mockup for what option 2 could look like:

I like where this is going.
What happens when a user doesn't have "Production" selected in the first step? Do we still show the production options when "More options" gets selected. Or are they just not high-lighted? If they have production selected - are all of them highlighted?

That's pretty cool Simon! Definitely includes everything. I'd still worry about how users get taught when they're dropping on an empty timeline. What if it defaulted to something adjustable/expandable? I forget if the sections can overlap…

That's cool! We just automatically create a timeline? It's even less thinking and I think we can come up with some good visual to indicate that things can be dragged around.
How would you remove a section? I'm not sure the '+' is the best indicator there, but I'm not sure whether I can think of anything better - it certainly affords pressing.
I think the issue is though that things could technically overlap. But in that case, why don't we just gantt chart it?

Reducing that cognitive load ;)
Dragging hint/visuals can definitely be improved, as well as that splitting/reducing process. I'll think on that interface a bit more (I was stuck on trying to make the pressing clear and accessible too).
Gantt chat style would work although I think it's not as clear for a beginner and doubles the draggable points and complexity. Maybe if it's a rarity it could be turned on:
Have overlapping sections? Enable advanced mode.

I like where this is going! I feel the concern too of dropping someone into an empty timeline. "Uh, what do I do here?" I also feel a concern about giving someone a timeline they don't want. Maybe my Guide is just about harvesting (adult, flowering, fruiting, dormancy) and as a guide author I now feel pressured to make a 'complete guide' and/or I don't realize I can remove timeline sections.
Another thing we have talked about being a major distinction on the timeline is the life stage vs the window. Eg: the seedling life stage might only last one week, but you can do it anytime within a 4 month window. The best idea I came up with for this is having the member create a timeline as though they are growing the crop as early in the season as possible, and then having them take that whole timeline and shifting it to represent the latest start possible.
Something else that could be cool is using the Timeline as the navigation between life stages when filling out the stage details.

Here's some more thoughts along the lines of getting straight on a timeline. When the user chooses the stages they could be shown something like @warpling's splitting, or a more gantt style thing (like the existing concepts.

@roryaronson I just realized that how I'm seeing these stages represented on the timeline is "when you do them" as opposed to "how long they take", which I feel like is fairly standard for growing instructions. Is it worth showing a couple of people who grow plants the timeline, and asking them how they interpret the timeline?

 You all really care about this! And the new mockups look amazing. I'm glad it was cleared up about the function I offered because it doesn't make sense to use something that will just get buggy and be choppy design.
Are there plans to improve the "cognitive load" that @warpling  was mentioning? I like where he's getting at. I've seen a lot of applications provide a quick tour and tutorial for how to use their sites. It's normally short and sweet but I think sometimes it helps to get hints involved, but not intensive hints like the infamous Microsoft paperclip.

@farmanp All talk about this is very welcome. Have a look at issue #540 for some past conversations, but Rory also mentions the tour thing above (that's what the bee is for). In slack we've also discussed how the bandcamp tutorial works and some other things (which is subtle, and I like).
If you want to talk in real time, you should join Slack! Here's a sign up page: http://openfarm-slack.herokuapp.com/ (we'll be integrating that into the actual website soon).

thanks @simonv3. I'll be sure to make my comments more constructive on here from now on.

@farmanp I didn't mean to imply that they weren't constructive! It's good to keep these things in mind, and all contributions are welcome :). Once we have some properly built things, I think we would all love whatever help we can get testing them with users and getting user feedback.

Anyone have any more thoughts on this? I'm doing a major restructure at the moment of the API, and it doesn't make much sense to me to rebuild this part if we're going to change it again so soon.

@simonv3, interesting thought on the "when you do them" as opposed to "how long they take". I think I see it as 'both are important' for these reasons: As a grower, its important for me to know both when can I sow the seeds and how long should I be caring for the plants as seedlings.
If a timeline is only showing "how long they take" information and there isn't the flexibility of a 'window' then as a Guide reader I might feel boxed into "Oh my gosh I missed when this Guide started by a month! Now I don't know if these plants will survive if I start them now, it might be too late, I guess I won't grow them". When in reality, the Crop maybe could be sowed anytime during a 4 month period, and the Timeline was only showing an early start. It would also be helpful from a planning perspective to know how I might want to spread out when I sow my seeds in order to get a full season of tomatoes vs just one big crop of them.
If a timeline is only showing "when you do them" information then I might misunderstand a 4 month long seedling bar as my plants will be seedlings for 4 months. Doing it gantt style would solve this, but may look messy and overwhelming, and not really convey to me when my next stage is going to start. The 'when you do them' windows could also be really long. Imagine a guide for growing in a greenhouse. Is every stage just the entire year because you can grow stuff year round? That's a useless timeline.
Maybe we don't need to show windows for every stage though. What if we simply showed the reader the Growing Season window and the Guide duration (and sub-stages) as though they are going to start using the Guide today. If its not the right timing (the Guide Duration falls outside of the Growing Season), then we show a warning message to the tune of "Warning: You're 3 weeks early to start using this Guide". Within timeline creation, we have the member create a non-gantt (non-overlapping) style timeline that represents their whole guide duration. And then we have them specify an earliest and latest start time for their Guide.
On another note, I really like the concept of combining life stage selection with timeline creation. I'll make another mockup right now. Keep the convo going! :bee:

So I thought a lot about all this. It seems that the most important 'window' to show is the 'Starting Window' - the period of time when someone should start following a Guide. I think this is best input by first creating a complete Timeline for an early start, and then shifting it to represent a late start. Visually this makes the most sense to me (rather than trying to drag the starting window itself and imagining what all the other stages would then look like). The other stuff like 'Growing Season' can be easily inferred from the available information IMO and it isn't correct to show on Guides that may only have to do with a few life stages.
Re: splitting life stages. I don't know if that's a good idea. Essentially all life stages are the same thing (periods of time that are labeled). So while we can have a 'Preparation' Stage, I don't think it needs to have sub-stages. I guess I'm saying we should just let the member choose whatever stages they want and they all should act the same - just be labeled according to whatever makes the most sense to the Guide creator. We can start the member off with a couple 'generic' stages.
Enough blabbing from me, here's my mockup ;p


feat: initial setup

This PR creates our initial package.  I think anyway.   I've created a secret NPM_TOKEN - my hope is that when I merge this PR the initial version of easyauth-deeplink will be published.
Not used @joshuakgoldberg's template before - but I'm optimistic!

Ahh love to see this! Please let me know if there's anything that feels off (or just plain doesn't work). I was hoping to get this cleaned up by end of year, but typescript-eslint working has been taking over.

Thanks @JoshuaKGoldberg!  It's really very good!  About to hit merge and see if publishing works.

Things that I had to figure out for myself: needed to set up an NPM_TOKEN variable
Had to manually delete the dist folder

Huh - post publishing the stuff in dist has come back @JoshuaKGoldberg  - feels wrong?

Yeah it's that same bug 😢


Hide quick actions OSD when viewed

Is your feature request related to a problem? Please describe.
Always tapping the image after opened to hide the OSD is taxing and repetitive.
Describe the solution you'd like
When the viewer is opened, let the OSD be hidden on media viewer access.
Describe alternatives you've considered
Provide a toggle in the settings to set this behaviour.

I believe what you want is covered by Settings > Viewer > Overlay > Show on opening.


Make all generated classes implement == and hashCode using Equatable

This PR proposes making all generated classes have the == and hashCode methods implemented so we can easily make comparisons against different instances of them.
I am using the equatable package to facilitate the code generation required to make this work.

Hey @leoiacovini, thanks for your PR!
As you've added equatable, could you migrate classes that are implementing it by hand as well? On lib/generator/data.dart.

@comigor Done, can you check again, please :)

Released as https://pub.dev/packages/artemis/versions/0.7.0


Change --@sharedscreen to --@shared and make it work for screen and processor.

I can do this, but first I need to know if it's a good idea and will be approved.

Well, we originally wanted to completely separate starfall instances from their entities, so there wouldn't be a concept of "screen" or "processor" on that level.
We'd then have --@server and --@client, which would determine where the code is run. (Can also supply both)
The question that remains, however, is: What if the user doesn't specify anything? Do we have some default behaviour? will it error?
Renaming sharedscreen to shared is not really a good idea at the moment, since we'd only end up renaming it again, causing us to break old code twice instead of once.

I think it should always be shared with the option of using --@server or --@client to specify that the code is server-side only or client-side only. I think the only difference between the processor, screen, and hud (to be made) should be the way the render hook gets called.

Actually what if we make it so the user can declare what the following code runs on. --@server, --@client, and --@shared with shared as default.
print("Shared print")

--@server
entities.self():setColor(Color(0,0,0,255))

--@client
hook.add("render","blah",function() end)

--@shared
print("another shared print")

--@client
print("client print")

Then we can split the script into which parts run on the server and which parts run on the client.

--@server and --@client would be preprocessor statements. Putting it inline would not work. We have a method for switching, surprisingly built into GLua, called SERVER and CLIENT.
if SERVER then
    print( "Serverside stuff" )
end

-- You can use else instead of 'end', and another 'if CLIENT' section.

if CLIENT then
    print( "Some CLIENT stuff" )
end

The point that @Xandaros is trying to make, is with explicit preprocessor statements what is the expected behaviour for a script which is either not explicitly stated, or has both. I have discussed this with him briefly. As I mentioned to Xan when I brought these issues to his attention, we have been wanting this freedom to execute Lua on either 'platform' for a while now. As Xan mentions, we've been looking at separating the physical representation from the instance which the code runs, this would then allow us to interpret the code on whichever 'platform' we want without affecting our interface to the users.

I'm aware they are preprocessor statements. They could be used to split the server and client code apart so that the server code doesn't get sent to the client. If you guys don't care if that gets sent to the client then yeah SERVER and CLIENT work fine, but the starfall processor doesn't allow shared code for whatever reason.

The expected behavior for a script that doesn't have them explicitly stated should be shared.

Why?

Because shared is more common I would think.

I just made the processor always shared, and the screen and hud entity can be linked to the processor using the component tool.


Implement a countdown for each player. If no card is submitted until then, send a random one to the backend. Same for the choosing of winner (both gamemodes)

7f3aa502db9bddffe4c329a717f82d5f09a5a6a1


Subcommand run does not search PATH for command argument

Binaries cargo install'd are placed in ~/.cargo/bin (which is in my shell's PATH), but rustup run <toolchain> foo does not search PATH, instead assuming the named executable to be within the named toolchain's bin directory and requiring the full path to successfully run the command. This is a change from the behavior of multirust, which did search PATH for the named command.

Can you clarify what you mean by 'requiring the full path to successfully run the command'? rustup should know the path to the toolchain directory and always be able to find the command in the toolchain directory.
I don't know why run would search ~/.cargo/bin. The command is for running binaries out of the toolchain directory.

Thanks for the report @murarth !

I'm not suggesting that rustup run should search ~/.cargo/bin specifically. Rather, I think that it should search the list of directories in the environment variable PATH when the named executable is not found within the toolchain. Its primary purpose may be running toolchain binaries, but it's also the most straightforward way to run a binary that is built with a non-default toolchain and affected by #350.
For example, if one uses cargo install to build and install rusti, one must run rustup run nightly ~/.cargo/bin/rusti in order to run the binary. Running rustup run nightly rusti gives a No such file or directory error, as rustup is not searching PATH.
It seems sensible to me that, unless it would conflict with some other concept in rustup, the run subcommand ought to be thought of as providing the proper execution environment for any executable, not just those that make up the toolchain.

This is basically the same as #210, although that has nothing to do with the PATH, but is about running a command from the local directory.


Student submissions enhancement

Display in student submissions page the required files, max file size, and whether students can only submit required files above the submissions table.
Motivation and Context

This pull request enhances the student submission experience (uploading files). This fixes issue 5171.
Your Changes

Description:
Added a new partial to incorporate changes.
Type of change (select all that apply):

[X] Other (please specify): Feature enhancement

Testing

I tested this pull request by first going to an assignment with no required files, then creating an assignment with 2 required files and a requirement that only required files could be submitted and checking that the required files were displayed. Then I turned off the assignment requirement that only required files could be submitted in the same assignment I made and checked that the info that I displayed reflected that change (non-required files were alright).
Questions and Comments (if applicable)

Should I change the way I display this info?

Checklist

[X] I have performed a self-review of my own code.
[x] I have fixed any Hound bot comments.
[X] I have verified that the TravisCI tests have passed.
[X] I have reviewed the test coverage changes reported on Coveralls.
[X] I have updated the Changelog.md file.

Required documentation changes (if applicable)

WOW!! Thanks for the quick fix :)

@bobthefairycat I should say, we don't plan to release this patch during the current semester, so it won't affect your teaching right now. (But will be in place in future semesters!)


fix: Cardview in Favorite Events

Fixes #1397
Changes: Improved UI
Screenshots for the change:
New Looks

Not good


fix fix insert stmt throw MultiCastDataSink cannot be cast to DataStreamSink (#38526)

cherry pick from #38526

run buildall


Chip size

Need to measure SoC physical size to determine chip type:

Chip model
Length
Width
Thickness

Hi3518A
13mm
13mm
1.37mm

Hi3518C
20mm
20mm
1mm

Hi3518E
11mm
11mm
???

Datasheets:

Hi3518A & Hi3518C (Size data is on bottom of PDF page 20)
Hi3518E (Size data is bottom-right of PDF page 1)

Chip measurements:

Dimension
Value
Uncertainty

Length
10mm
+-2mm

Width
10mm
+- 2mm

Thickness
0.71mm
+- 0.5mm

Chip is most likely the Hi3518E.

Further confirmed as the Hi3518E by the file firmware/_firmware_image.bin.extracted/7E8B84:
(clip of the hexdump)
^@^N^@hi3518e_chnl.ko3ESC<FB><FF>^B^@^O^@hi3518e_h264e.kocESC<F4><FF>^B^@^M^@hi3518e_isp.ko<8B>ESC<FE><FF>^B^<EMAIL_ADDRESS>


Make Application Icon use SVG

Compared to other Icons the Mattermost icon looks pretty pixely in the Gnome 3 application switcher. It also does so in the dock. This is propably due to a poor scaling algorithm of the PNG used as the application icon.
So this is a feature request to use SVG for the application icon at least on capable operating systems.

@yuya-oc are we able to use an SVG icon for the app icon? Or should we use a higher-quality PNG instead?
I agree it does look pixelated compared to others

For now I'm not sure how SVG is applied on Gnome.
@mcnesium For reference, would you tell the distribution and the way to install you are using?

Of course, sorry. This is on Manjaro Gnome 17.0 with GNOME Shell 3.22.3 and Mattermost 3.6.0 installed from AUR

This bothered me as well, the default icon looks very pixelated when using dash-to-dock for Gnome or Budgie. It also opens a separate icon if you have mattermost pinned as favorite instead of using the same one. The reason for this seems to be that the desktop entry mattermost-desktop.desktop doesn't match the WMCLASS of the application ("mattermost", "Mattermost").
Incorrect icons using default mattermost-desktop.desktop
Correct icons using renamed mattermost.desktop
Renaming the desktop entry solved the problem for me. Would it perhaps be possible to either rename the .desktop filename it installs or change the WMCLASS? I have only tried this on Gnome with dash-to-dock and Budgie, but I assume this would solve the issue for other launchers as well.

@yuya-oc thoughts on renaming the desktop entry? Would there be potential consequences of the change?

Only noting this as an issue with Ubuntu 18.04, as well. I never noticed it as an issue while using Ubuntu+Unity, but the pixelation stands-out quite a bit more in GNOME Shell.
I've confirmed this on the newly-released mattermost-desktop version 4.1.0.

I'll be submitting a patch which adds an SVG icon. Here's the before:

And here's the after:

Expect this patch in the next day or so.

Pull request submitted here

I think there has been some sort of regression because I have an ugly icon.
Ubuntu 19.04 with Mattermost 4.2.1


Fix documentation about Refreshing a Token

Coverage remained the same at 99.82% when pulling f91de4a09f081ae0fd9dc81e791be8325fe3e008 on ZenCocoon:readme-fix into bbbeeacd5d9acce11cad965cc9680727b82f25a4 on thephpleague:master.

In the context of this example, I think there is no $token object on which a refreshToken property exists. $refreshToken is a variable itself, since it could have come from a data source (like a database) where you stored the refresh token. Maybe just add some copy above the example to note that the $refreshToken comes from some data store where we stored the token after earlier requests?

Good point, how do you feel about this explanation instead then?

Looks great. Thanks!


insert new tools and customize it.

I'm submitting a

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Enhancement
[ ] Feature request
[ ] Documentation issue or request

Description
A bug: Description of the issue you encountered
A feature: Description of the feature. Cause and its Motivation
Version Information
ngx-editor: x.x.x
angular: x.x.x

Browser

[ ] Chrome - x.x.x
[ ]  Mozilla Firefox - x.x.x
[ ] Opera - x.x.x
[ ] Microsoft Edge - x.x.x

NOTE: Replace x.x.x with your version information

I want to add a button that will show a modal or direct to other component

duplicate of #174


Show the staff username on ban page

Dm me on discord if there is a problem: bear#0377

Closing this as you also have it in your translation branch :D


Lists of single-property objects get mangled

see: https://github.com/jashkenas/coffee-script/issues/1756

I think this can be reduced to:
x = [ { one: 1 }, { two: 2 } ];

Which should now compile to:
x = [
  one: 1
,
  two: 2
 ]

Which compiles back to JS correctly.

I think a compilation to x = [ { one: 1 }, { two: 2 } ] or
x = [
  { one: 1 }
  { two: 2 }
]

is nicer. We should only use implicit braces when it's the natural and unambiguous choice. It's perfectly fine to use explicit braces on anything non-trivial.


BUG: Darkmode for template dropdown does not work

Version (please complete the following information):

OS: Windows
Browser Microsoft Edge and Chrome
Web Clipper version: 0.10.1
Obsidian version: 1.7.7

Describe the bug
When I drop down the list of templates on a browser in Dark Mode, the list is white but the text (I think is for Dark mode which makes it hard to see)
Expected behavior
What did you expect to happen? It should be dark
URLs where the bug occurs
Any specific web pages where the bug can be replicated.
Everywhere
To reproduce
Click on the addin in edge
Click on the double arrows for a list of templates

Your template file
If you are using a custom template (i.e. not the Default template).  Paste the JSON code below.
(paste here)

Do other dropdowns display correctly in dark mode? E.g. in settings?

Yes, they do

Fixed in 0.10.3


C-API : How to run classification

I'm using the C-API from C++. First of all, thank you for the great documentation with all the code examples, this is insanely helpful.
My problem is a classification problem. But in C-API tutorial, the example given is for a regression :
// variable to store labels for the dataset created from above matrix
float labels[ROWS];

for (int i = 0; i < ROWS; i++) {
  labels[i] = i;
}

// Loading the labels
safe_xgboost(XGDMatrixSetFloatInfo(dmatrix, "label", labels, ROWS));

And later, when predicting :
for (unsigned int i = 0; i < output_length; i++){
  printf("prediction[%i] = %f \n", i, output_result[i]);
}

The output is a float.

I'm trying to change the code to deal with a classification problem. I could successfully create the labels as uint :
  // variable to store labels for the dataset created from above matrix
  uint32_t labels[ROWS];

  for (uint32_t i = 0; i < ROWS; i++) {
    labels[i] = i;
  }
  // Loading the labels
  XGDMatrixSetUIntInfo(dtrain, "label", labels, ROWS);

But when running the predictions, I still get a float prediction. I'm not sure how to change the prediction code to get "classes" instead (uint). Any pointer to share ?

The document for C is mostly geared toward others who want to work on higher-level language interfaces, so the machine-learning aspect of the document is relatively lacking. The best place to start at the moment is the Python interface and work your way back to C, where the former is completely defined on top of the latter without any helper C code.
That said, you need to:

Provide the objective and the number of classes num_class to XGBoost during training.
Define labels as classes:

[1, 0, 3, 2, 1, 2]

This is a set of labels with 6 samples, with a total of 4 classes in the dataset.

For class output instead of probability output, use the multi:softmax objective instead of the multi:softprob objective. Otherwise, you can calculate the estimated class labels yourself based on the estimated probability.

Feel free to reopen if there are further questions.


Query ergonomics macro

Added macro implementation to not expose zio-schema into users api.

Codecov Report

Merging #1087 (9e46ce8) into main (61e57a0) will increase coverage by 0.43%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   56.92%   57.36%   +0.43%
==========================================
  Files          73       76       +3
  Lines        2259     2723     +464
  Branches       66       76      +10
==========================================
+ Hits         1286     1562     +276
- Misses        973     1161     +188

Impacted Files
Coverage Δ

...tp/src/main/scala/zhttp/http/QueryParameters.scala
0.00% <0.00%> (ø)

zio-http/src/main/scala/zhttp/http/Request.scala
38.09% <0.00%> (-1.91%)
:arrow_down:

...io-http/src/main/scala/zhttp/service/Handler.scala
64.70% <0.00%> (-4.53%)
:arrow_down:

.../main/scala/zhttp/http/headers/HeaderGetters.scala
28.37% <0.00%> (-3.59%)
:arrow_down:

...erver/content/handlers/ServerResponseHandler.scala
94.28% <0.00%> (-1.17%)
:arrow_down:

...io-http/src/main/scala/zhttp/http/PathModule.scala
77.35% <0.00%> (-0.77%)
:arrow_down:

...main/scala/zhttp/http/headers/HeaderModifier.scala
14.52% <0.00%> (-0.77%)
:arrow_down:

zio-http/src/main/scala/zhttp/http/Status.scala
100.00% <0.00%> (ø)

zio-http/src/main/scala/zhttp/html/Template.scala
100.00% <0.00%> (ø)

...c/main/scala/zhttp/service/server/ServerTime.scala
33.33% <0.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e57a0...9e46ce8. Read the comment docs.

new API in Progress https://github.com/dream11/zio-http/pull/1209


Feature/add resource filter

Describe your PR
Related to #
Fixes #
Pages/Interfaces that will change
Screenshots / video of changes
Drop some screenshots of the before and after of your work here. Better yet, take a screen recording using a tool like Loom
Steps to test

Additional notes

@ryancharris Added a comment on #24 with a function that should help with filtering. Tested locally so it should work just fine for you 👍
I would suggest using useMemo() with it since we'll likely end up having a lot of data to filter through and we don't want that to refilter that data on every re-render.

@ryancharris looking solid, thank you!


Incorrect rendering of Katex in Markdown

Issue Type: Bug
Summary:
Before the updated built-in notebooks came out, I was using markdown cells within jupyter to render latex equations without any issue. With the new built-in notebooks, I am having rendering errors which I assume are due to the new KaTeX typesetter. I am sure there are more symbols and environments that will give me issues, but I have listed the few that I found so far in the example provided.
Steps to Reproduce:

Open an .ipynb file with the new built-in notebooks.
In a markdown cell, enter a KaTeX equation to be rendered using $$ (wrapping it in \begin{equation}\end{equation} environment makes no difference).

$$
p(x|\hat{a},\hat{b})=
\begin{cases}
\langle a,b \rangle,& \textrm{if } a=a^*\\
\langle x,b \rangle,& \textrm{if } a\ne a^*
\end{cases}
$$

Expected Results:
We want to correctly render the \hat symbol, the \cases environment, as well as the \ne or \neq symbol.
Actual Results:
The symbols/environments mentioned render incorrectly:

VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:30:16.440Z)
OS version: Linux x64 5.8.0-63-generic snap
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 4700)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
31.29GB (0.85GB free)

Process Argv
--no-sandbox Documents/code/expert_rank/ --crash-reporter-id c276f5fd-6ee5-47a7-ae52-111291da1fc8

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (8)

Extension
Author (truncated)
Version

prettier-vscode
esb
8.1.0

latex-workshop
Jam
8.19.2

markdown-toc
jof
1.4.0

python
ms-
2021.7.1060902895

vscode-pylance
ms-
2021.7.7

jupyter
ms-
2021.8.1054968649

pdf
tom
1.1.0

vscodeintellicode
Vis
1.2.14

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30321513
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
pythonvssor306:30344512
bridge0708:30335490

Duplicate of #128490


5mC detection and mismatch due to the nanopore errors

Hi @jts
Do you consider mismatches with the reference during the detection of 5mC in CpG sites?
As you know, the error rate of the nanopore is high and there may be many cytosines that actually might not be C when compare them to reference. I was wondering that nanopolish examines cytosines through its HMM that are called C from nanopore and also are C in the ref? or not?
Thanks,
Vahid.

Hi @vahidAK,
The calling algorithm does not use mismatches in its evaluation of whether a particular base is methylated or not. The basecalled sequence is used to determine which part of the reference the underlying signal data belongs to, but otherwise is not considered in the calling algorithm.
Jared


Reduce dependencies to wrapper packages

Is your feature request related to a problem? Please describe.
Currently, this package depends  on some third party packages that in turn depend on heavy libraries. E.G pytesseract
relies on pillow even though dd uses opencv-python directly. However, both libraries are only used for loading an image as numpy array. Pillow on the other hand is not directly accessed.
Pytesseract in turn is barely are lightweight wrapper for tesseract and the only functionality is to provide a  function for reading an image, call tesseract and return results as dict.
Describe the solution you'd like
Reducing dependencies to wrapper libraries by integrating the functionality main functionality to dd. The following
packages can be make redundant.

pdf2image
pytesseract

With a little more work this also concerns

pycocotools

Describe alternatives you've considered
Integrating the necessary wrapper functionality directly into this package.
Additional context
Add any other context or screenshots about the feature request here.

Pytesseract dependency removed with 2a25c0e .

pdf2image dependency removed with 6c3f4ec .


Cluster creation failed

... calling kube-up
Project: kubernetes-gcp
Zone: us-central1-b
+++ Staging server tars to Google Storage: gs://kubernetes-staging-230631a5ee/devel
Starting master and configuring firewalls
WARNING: You have selected a disk size of under [200GB]. This may result in poor I/O performance. For more information, see: https://developers.google.com/compute/docs/disks#pdperformance.
Created [https://www.googleapis.com/compute/v1/projects/kubernetes-gcp/zones/us-central1-b/disks/kubernetes-master-pd].
NAME                 ZONE          SIZE_GB TYPE        STATUS
kubernetes-master-pd us-central1-b 100     pd-standard READY
Created [https://www.googleapis.com/compute/v1/projects/kubernetes-gcp/global/firewalls/kubernetes-master-https].
NAME                    NETWORK SRC_RANGES RULES   SRC_TAGS TARGET_TAGS
kubernetes-master-https default <IP_ADDRESS>/0  tcp:443          kubernetes-master
Created [https://www.googleapis.com/compute/v1/projects/kubernetes-gcp/regions/us-central1/addresses/kubernetes-master-ip].
cluster/../cluster/gce/util.sh: line 529: cd: easy-rsa-master/easyrsa3: No such file or directory
=== Failed to generate certificates: Aborting ===
satnam-macbookpro2:kubernetes satnam$  kubectl version
Client Version: version.Info{Major:"0", Minor:"17+", GitVersion:"v0.17.1-629-gd9d12fd3f7036c-dirty", GitCommit:"d9d12fd3f7036c92606fc3ba9046b365212fcd70", GitTreeState:"dirty"}
Couldn't read version from server: Get http://localhost:8080/version: dial tcp <IP_ADDRESS>:8080: connection refused
$ kubectl config view
apiVersion: v1
clusters: []
contexts: []
current-context: ""
kind: Config
preferences: {}
users: []

Huh. Is this reproducible?

No, probably not. So I will close the issue then.


Zero forecast for middle level time series using optimal reconciliation

I am using optimal_combination function with OLS method on the forecast to reconcile it. For some datasets I am getting zero forecasts for all middle levels time series. Why is it so? What can I do to fix it? Can anyone please help.
Using this code https://scikit-hts.readthedocs.io/en/latest/usage.html#reconcile-pre-computed-forecasts

@carlomazzaferro can you help on this.

@carlomazzaferro can you help on this.

I unfortunately do not have time anymore to dedicate to this project, contributions are welcome


Ref docs issue

@v-yilinhu commented on Thu Dec 09 2021
Error:

Version spec 3.6.8 for architecture x64 did not match any version in Agent.ToolsDirectory.

For more details check here:

https://apidrop.visualstudio.com/Content CI/_build/results?buildId=268067&view=results

@danieljurek for notification.

@xiangyan99 commented on Fri Dec 10 2021
@danieljurek could you take a look?

Assigning to @sima-zhu to close. Looks like she fixed the issue.

Link is broken. I do not have context about this. I'd prefer to close for now. Please feel free to reopen if the issue still exists. I'd happy to help address the issue.


Maybe a bug: When users start leaving, the user list doesn't update, so the colors no longer alternate like intended

I noticed this bug when using the previous mod called AlternatingSessionUserList, and I am just assuming that the same issue is here. Correct me if I'm wrong. Basically if users leave you can get for example two or more bars in a row of the same color.

this has been fixed, yes... please don't report issues without verifying it still exists 😅


Nuke stopped working

I just realized that in my older version show didnt work since I updated in January 2019. I updated to the newest version. Now in today's version nuke doesn't work. Here is what I get:
Microsoft Windows [Version 10.0.17763.678]
(c) 2018 Microsoft Corporation. All rights reserved.
C:\Users\Michael>cd C:\Routine\kijijipy
C:\Routine\kijijipy>python kijiji_repost_headless -u<EMAIL_ADDRESS>-p XXXXXX nuke
Traceback (most recent call last):
File "C:\Users\Michael\AppData\Local\conda\conda\envs\p36\lib\runpy.py", line 193, in run_module_as_main
"main", mod_spec)
File "C:\Users\Michael\AppData\Local\conda\conda\envs\p36\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "kijiji_repost_headless_main.py", line 204, in
main()
File "kijiji_repost_headless_main.py", line 51, in main
args.function(args)
File "kijiji_repost_headless_main_.py", line 196, in nuke
[api.delete_ad(ad['id']) for ad in all_ads]
File "kijiji_repost_headless_main_.py", line 196, in
[api.delete_ad(ad['id']) for ad in all_ads]
File "kijiji_repost_headless\kijiji_api.py", line 128, in delete_ad
'ca.kijiji.xsrf.token': get_xsrf_token(my_ads_page.text),
File "kijiji_repost_headless\kijiji_api.py", line 73, in get_xsrf_token
return yaml.load(m.group(1), Loader=yaml.FullLoader)['token']
AttributeError: module 'yaml' has no attribute 'FullLoader'
C:\Routine\kijijipy>

You need to update your pyyaml Python package to version 5.1 or newer.
See here for details.


addressing #294

addressing #294

[ ] update README.md
[ ] update doc/installation.rst
[ ] correct typo (giddy) in doc/installation.rst
[ ] update version (v1.3.1) in spaghetti/__init__.py
[ ] run changelog tool
[ ] GitHub release
[ ] conda-forge release
[ ] manually update changelog
[ ] PR to update pysal/pysal/subtags
[ ] PR to update pysal/pysal/tags.json
[ ] PR to update pysal/pysal/tarballs.json

pysal/pysal#1123