Bugfix: Temporary relief from double-rendering

Apparently StrictMode activates double-rendering in a dev environment to help with checking for issues. The real problem is our component. I'll implement a proper fix in a followup PR.

great find!


raise code coverage

code coverage is at 57% due to the _run sub not being tested.

of note, the integration tests themselves shouldn't raise test coverage as gathered by Devel::Cover, they're still important to test running the script side of password in it's entirety.

merging and closing for now.
still need more coverage, but have taken on other tasks in the meantime which are more important.


Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I've got an Ollama ReAct agent, Redis Ingestion Pipeline and a destructive DatabaseReader. The agent kept getting empty responses from the QueryEngineTool (sisyphus the syslog-indexing daemon).
From what I understand, the correct format should be:
Action: sisyphus
Action Input: {"input": "describe the data or whatever"}

But that wasn't working. So I told the LLM I think there's a problem with the parser, and to just try things till it works.
User: let's try using the tool again.
> Running step 2458cb50-805c-44b6-a797-fbe826979101. Step input: let's try using the tool again.
Thought: The current language of the user is: English. I need to use a tool to help me answer the question.
Action: sisyphus
Action Input: {'input': AttributedDict([('title', 'Input'), ('type', 'string')])}
Observation: Error: 2 validation errors for QueryStartEvent
query.str
  Input should be a valid string [type=string_type, input_value=AttributedDict([('title',...'), ('type', 'string')]), input_type=AttributedDict]
    For further information visit https://errors.pydantic.dev/2.9/v/string_type
query.QueryBundle.query_str
  Field required [type=missing, input_value=AttributedDict([('title',...'), ('type', 'string')]), input_type=AttributedDict]
    For further information visit https://errors.pydantic.dev/2.9/v/missing
> Running step 4770a398-4e57-49e2-8a52-5165bc2e4908. Step input: None
Thought: The user is getting an error message indicating that the input type and required fields are missing from the query.
Action: sisyphus
Action Input: {'input': AttributedDict([('title', 'Input'), ('type', 'string')])}
Observation: Error: 2 validation errors for QueryStartEvent
query.str
  Input should be a valid string [type=string_type, input_value=AttributedDict([('title',...'), ('type', 'string')]), input_type=AttributedDict]
    For further information visit https://errors.pydantic.dev/2.9/v/string_type
query.QueryBundle.query_str
  Field required [type=missing, input_value=AttributedDict([('title',...'), ('type', 'string')]), input_type=AttributedDict]
    For further information visit https://errors.pydantic.dev/2.9/v/missing
> Running step 88c6115b-7fd6-4a4f-9c63-d64f33410025. Step input: None
Thought: The error message still indicates that the input is missing and should be a string, but it seems like the tool needs more specific information about what to query for.
Action: sisyphus
Action Input: {'input': 'syslog query', 'query': 'select * from syslog where ...'}
Observation: The provided system event seems to be related to a scanning operation that has completed successfully. The mention of "Syslog (redis_vector_store) in background" suggests that the event is likely from a logging or monitoring tool.
The provided system event seems to be related to a scanning operation that has completed successfully. The mention of "Syslog (redis_vector_store) in background" suggests that the event is likely from a logging or monitoring tool.

 But... why? Please help me understand this so I can explain it to the robot.

I have no idea what's going on there. Some code to reproduce might be helpful.
 I think llama3.1 will probably be the best (but at that point, llama3.1 supports function calling, i would use a FunctionCallingAgent)

I'm using a llama3.2. I'll look into the Function Calling Agent. Thanks

Seems to me llama3.2 is hallucinating pretty bad on the react loop -- not totally unexpected

FunctionCallingAgent example posted on #16781. I know it can be done with lower level efforts, so I might need to get into the parsing code. Or perhaps I need to go lower level than the FunctionCallingAgent?

There is definitely lower-level
https://docs.llamaindex.ai/en/latest/examples/llm/openai/#manual-tool-calling (this applies to Ollama as well)


There should be no trailing slash in DELETE object

Otherwise, the object name isn't OK.
For instance, you can have an object named test and another named test/. They are distinct.
A little test case :

Add an object named "bleh" to an s3 bucket, and run the following script :

extern crate rusoto;

use rusoto::s3::{S3Client, DeleteObjectRequest, DefaultCredentialsProvider};

#[test]
fn it_works() {
    let s3 = S3Client::new(DefaultCredentialsProvider::new().unwrap(), rusoto::Region::UsWest2);
    s3.delete_object(&DeleteObjectRequest {
        bucket: "rusototester".to_string(),
        key: "bleh",
        ..Default::default()
    })
}

If you list the objects, you'll notice bleh is still there. That's because the request tried to delete the (non-existing) file "bleh/"

Great catch.


use the now exported expvarHandler https://github.com/golang/go/issue…

This is simply some code cleanup and simplification.  Prior to Go 1.8 the expvarHandler was not exposed.  So you had to copy the code into your project.  You no longer have to do that.
This makes the example hotrod code simpler and easier to follow. Downside it requires Go 1.8 or above, which should be OK now that we are at 1.9.2 right?
See: https://github.com/golang/go/issues/15030

love it! please sign your commit, e.g. git commit -s --amend; git push --force

Please make sure all commits are signed (or squash them into one)

Coverage remained the same at 100.0% when pulling b552d15f0b0a6d7d2862e2787642c29cc8a2cda4 on dstroot:master into 3eddf478f098dbff9cec02451dec7c5a83bcebe0 on jaegertracing:master.

Coverage remained the same at 100.0% when pulling e8db1069957dbd406c676f908ea506dfe947d2be on dstroot:master into 3eddf478f098dbff9cec02451dec7c5a83bcebe0 on jaegertracing:master.

Coverage remained the same at 100.0% when pulling 0c4265df3bfa8deb277b39dbdc5c3fa1659e18cf on dstroot:master into 3eddf478f098dbff9cec02451dec7c5a83bcebe0 on jaegertracing:master.

Coverage remained the same at 100.0% when pulling 0c4265df3bfa8deb277b39dbdc5c3fa1659e18cf on dstroot:master into 3eddf478f098dbff9cec02451dec7c5a83bcebe0 on jaegertracing:master.

No - it was all my fault.  I was not 100% familiar with DCO, and I made an assumption the Hotrod example packages were only used in the Hotrod example. That was totally on me.  I LOVE the example by the way.  I am trying to use open tracing and Jaeger now in my projects.  Cheers!


The update() method seems to have a problem

I have data like this

When I use the db.update(key='test', updates={'text': ''}) method to update it and specify text as '', I want it to save an empty string, but it will actually save null.

The same situation occurs when updating the object.

Is this the correct behavior? How do I save an empty string?

this might be a ui bug. could you check using the sdk if the value is actually an empty string?


Enable cookie support after the SDK has been initialized

We have a home page / with a cookie banner. We are not allowed to write cookies until the user consents. We initialize the SDK with isCookieUseDisabled=true. Once the user consents, we would like to immediately write the cookies so when they continue to the next page /sign-in, same session ID is used there.
We can call appInsights.properties.context.sessionManager.update() but there seems to be no way to set CoreUtils._canUseCookies to true once the SDK has been initialized.

Seems like a bug. Will get this in to next release (2.3.1)

The fix did not make it into 2.3.1 as far as I can see. In the meantime, did anyone find a workaround for this, yet? Tried for two hours but failed miserably :)

I managed to create a very hacky workaround. When using the following code, we seem to be able to activate cookies even after the SDK has been initialized.  It only works by recreating a completely new app insights instance. like this:
activateCookies() {
    CoreUtils._canUseCookies = true;
    this.appInsights = new ApplicationInsights({
      config: {
        instrumentationKey: environment.appInsights.instrumentationKey,
        isCookieUseDisabled: false,
        enableAutoRouteTracking: true
      }
    });
    this.appInsights.loadAppInsights();
    this.appInsights.trackPageView();
}

Note: This workaround will break in the near future as we are planning on hiding all of the properties that start with "_" as they are considered to be private and should not be set directly.
To fix this properly we will need to add a setter method to be able to set/reset this value.

Hopefully you will not hide it without fixing the bug itself. But thanks for the heads up :) Maybe a reloadConfig method or so might help, in case other settings are also affected by that "set-once, change-never"-behavior.

Noted.
Also while looking at some other indirectly related code, I just tripped over another issue with the workaround, because the _canUseCookies is actual an internal global (on the CoreUtils). if someone else creates a new instance of AppInsights and also sets the isCookieUseDisabled to true this will reset the _canUseCookies back to false (via calling CoreUtils.disableCookies()).
This means that all of the cookie functions become no-op...
So this also means that by your instance setting this any other instances included on your app/page are also affected, even if they are only using the Utils.setCookie(), Utils.getCookie(), Utils.deleteCookie() and Utils.canUseCookies().
So in your case if you only have 1 AppInsights instance and you are not including any other components that create their own app insights instance then this workaround will currently work (until we fix the issue). But if not then there will be a race (initialization order) condition which could cause cookies to be unexpectedly disabled for any other instances.
Notes for possible fix.
I'm thinking the real fix here is probably the following or a combination

remove the CoreUtils._canUseCookies and associated CoreUtils.disableCookies() static methods, keeping the Utils are cookies available settings detection.
perhaps also have "global" Utils settings for backward compatibility for now (we already have disableCookies() methods).
change the logic for the "isCookieUseDisabled" config to be AppInsights instance specific only
likewise in the ChannelController change the logic for "isCookieUseDisabled" config to be AppInsights instance specific only.
add setter (or enable/disable) function(s) to enable setting / disabling the instance to cookie setting.

I think it is a good idea to remove global statics in general, except for maybe global defaults that can be changed on instance-basis. So +1 for removing those.
I also think an enable/disableCookie Function makes it explicit that you can actually do that on an existing instance. I would probably prefer that. But it would just somehow make sense to avoid confusion with the existing isCookieUseDisabled flag on the config object. Because having both the config property and the enable/disable methods could confuse users.
Maybe rename that config property as well to "enableCookies" and make it default to true? Just thinking out loud here...

I just came across this as I have exactly the same problem with "cookie consent" scenario in a react application. Is the recommendation to load AI with isCookieUseDisabled = false first, then reload it with isCookieUseDisabled = true after getting user consent? I tried just changing the config upon consent directly but that doesn't seem to work.

@hiraldesai as of today, there is no way to re-enable cookies after you have initialized AI with cookies disabled. You have to use the workaround I described above by completely re-initializing AI after getting consent.

We worked with our privacy team and decided that we don't need this feature any more. Feel free to close if there are no other customers asking for it.

Hello @MSNev ,
Due to the new Microsoft WCP Cookie Compliance banner, we are required to give the user the option to change their cookie preferences even after they had already consented to them. For example, the user might first consent to Telemetry cookies, but change their mind afterwards whilst using the website.
In order to support that, we need to:

Clean up the cookies created by the application insights library when the user chooses to no longer consent to telemetry cookies.
Re-initialize the application insights client object with cookies disabled.

My questions are:

Is there a native way in the API to do that cleanup?
Will simply reassigning the this.appInsights to a new instance of ApplicationInsights be enough?

Hello @MSNev ,
Any updates on this? There is a compliance deadline date across the company.

Sorry, was off yesterday, quick answers

Is there an API to cleanup -- No
Will simply reassigning this.appInsights to a new instance -- depends, but probably not. If the initial instance hooks XHR etc, these will remain in effect.
Currently, you can disable Cookies via the Utils.disableCookies() or CoreUtils.disableCookies() functions, however, we don't have a "clean" way to re-enable them that is what we are going to look at as part of this issue

Thank you for your replies!
Is it ok to resort to manually delete the cookies? Would that break the calls to app insights?

If you call disableCookies() first and then delete them that should not cause any issues

Note: as per comment in #1463 investigate adding a new "cleanup cookies" function to remove any pre-existing cookies (even if cookie usage is disabled) to better support GDPR.

Note: as per comment in #1463 investigate adding a new "cleanup cookies" function to remove any pre-existing cookies (even if cookie usage is disabled) to better support GDPR.

if anyone else is looking for this method, it's located under the core property at appInsights.core.getCookieMgr().setEnabled(value: boolean) in version 2.6.0

Oh, nice catch...
I'll look to expose this on both the web analytics object and the snippet proxy (the actual sources of the global appInights object) as part of simple initialization (Id been working on the underlying support), this will be in the next release.
I'll update the documentation (hopefully today) to hightlight this.

OK added new issue #1512 to address this gap as this issue will get closed once the release is fully deployed to all CDN endpoints

v2.6.0 is now fully deployed to all CDN endpoints


It is not possible to enable flux language support

Please, provide possibility to enable flux language support.
Here is a pull request: https://github.com/ninthnails/terraform-aws-influxdb-oss/pull/4

Flux language support has been enabled as per the PR #4 was merged. Thanks again for the contribution.


Fixes Travis CI: Isolate JMH PerfTest in separate profile

Moves the JMH benchmark stuff into a separate Maven profile (perf-benchmark) that is activated by passing -DperfBenchmark=true.  Excludes JMH deps & test from regular build so Travis install/test cycle works w/o requiring a clean.

Thanks


[WIP] Migrate to Flutter 1.23

Fix #90

Codecov Report

Merging #91 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   58.31%   58.32%
=======================================
  Files          76       76
  Lines        5942     5943    +1
=======================================
+ Hits         3465     3466    +1
  Misses       2477     2477

Impacted Files
Coverage Δ

lib/widgets/form_card.dart
85.82% <100.00%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23b75c...41c053e. Read the comment docs.

The remaining errors likely need to be fixed by package maintainers for packages:

timetable https://github.com/JonasWanke/timetable/issues/55
network_image_mock https://github.com/stelynx/network_image_mock/issues/2

I'll leave this PR as a draft for now.


Handle unscheduled failed replica

Set the replica RebuildRetryCount to FailedReplicaMaxRetryCount when the replica is considered as a rebuilding replica and marked as failed.
It would be deleted soon in func `cleanupCorruptedOrStaleReplicas'
longhorn/longhorn#4791
related: longhorn/longhorn#4724

@mantissahz Please backport to 1.3 and 1.2. Thanks.


Where is ollama storing models?

I was under the impression that ollama stores the models locally however, when I run ollama on a different address with
OLLAMA_HOST=<IP_ADDRESS> ollama serve, ollama list says I do not have any models installed and I need to pull again.
This issue occurs every time I change the IP/port
I have also performed the steps given in the docs
mkdir -p /etc/systemd/system/ollama.service.d
echo '[Service]' >>/etc/systemd/system/ollama.service.d/environment.conf
echo 'Environment="OLLAMA_HOST=<IP_ADDRESS>:11434"' >>/etc/systemd/system/ollama.service.d/environment.conf

running ollama serve in itself still listens only on localhost:11434, where I have models and manually changing it with OLLAMA_HOST=<IP_ADDRESS> ollama serve, makes the models disappear

Hi,
maybe this helps: https://github.com/jmorganca/ollama/issues/1687
I figured out that the model location depends on how you start ollama. With "ollama serve" or as System Service.

Hi @sushiselite, Ollama should be storing the models where it is being served from, although the directory can change.
Are you connecting to different Ollama host server, or restarting a container when the host changes by chance? I'm wondering if it could be the models stored in a container being lost when it restarts.

Hey @BruceMacD!
Ollama seems to have different models for when run with a simple ollama serve on localhost and when run with OLLAMA_HOST=<IP_ADDRESS> ollama serve

When you run ollama serve on the command line, you are running as your user. Then your models will be in ~/.ollama. When you described your issue at the top, you mentioned that you created /etc/systemd/system/ollama.service.d/environment.conf, which updates the service which is going to save the models to /usr/share/ollama/.ollama. The reason it saves there is that the service runs ollama as the user ollama. But then you ran ollama serve. To use the new service configuration, it would be better to restart the service: sudo systemctl restart ollama. Does that make sense?

@technovangelist I appreciate the detailed reply. Maybe this might be worth amending in the respective FAQ section?

Setting the env variable is not working for me, it keeps storing the models on /usr/share...
[Unit]
Description=Ollama Service
After=network-online.target

[Service]
ExecStart=/usr/local/bin/ollama serve
User=ollama
Group=ollama
Restart=always
RestartSec=3
Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin OLLAMA_MODELS=/opt/ai/models"

[Install]
WantedBy=default.target

Worked putting env variables in service.d/

I did it manuelly with "export OLLAMA_MODELS=/usr/share/ollama/.ollama/models" before I start "ollama serve"
and it worked.
WIth other Environment Variables I do it like this and it worked also:
[Service]
Environment="OLLAMA_HOST=<IP_ADDRESS>:11434"
Environment="OLLAMA_ORIGINS=*"

@marianoarga  I looked at your ollama.service file.
In the service section, there is one:
Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin OLLAMA_MODELS=/opt/ai/models"

[Service]
ExecStart=/usr/local/bin/ollama serve
User=ollama
Group=ollama
Restart=always
RestartSec=3
Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

This should be:
Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
Environment="OLLAMA_MODELS=/opt/ai/models"
Note the two environment entries. I had a similar issue with HSA Override. The ollama.service file takes multiple environment entries. If one tries to pack them all into one, however,  systemd ignores the surplus. So, in the quoted file, systemd ignores everything after the path entries. I received no error indicating this in my instance.

@sushiselite on linux this can be set using: https://github.com/ollama/ollama/blob/main/docs/faq.md#setting-environment-variables-on-linux
Let me know if this helps!

@marianoarga I looked at your ollama.service file.
In the service section, there is one: Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin OLLAMA_MODELS=/opt/ai/models"

[Service]
ExecStart=/usr/local/bin/ollama serve
User=ollama
Group=ollama
Restart=always
RestartSec=3
Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

This should be: Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" Environment="OLLAMA_MODELS=/opt/ai/models"
Note the two environment entries. I had a similar issue with HSA Override. The ollama.service file takes multiple environment entries. If one tries to pack them all into one, however, systemd ignores the surplus. So, in the quoted file, systemd ignores everything after the path entries. I received no error indicating this in my instance.

but when I change the config flie /etc/systemd/system/ollama.service like this:
Environment="OLLAMA_MODELS=/data/models"

And try to restart ollama, I got Error could not connect to ollama app. When I try ollama serve, it failed pending at source=routes.go:1042 msg="no GPU detected".
To prove it, I comment the OLLAMA_MODELS line. It works again.
Anyone know how to slove it?

@marianoarga I looked at your ollama.service file.
In the service section, there is one: Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin OLLAMA_MODELS=/opt/ai/models"

[Service]
ExecStart=/usr/local/bin/ollama serve
User=ollama
Group=ollama
Restart=always
RestartSec=3
Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

This should be: Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" Environment="OLLAMA_MODELS=/opt/ai/models"
Note the two environment entries. I had a similar issue with HSA Override. The ollama.service file takes multiple environment entries. If one tries to pack them all into one, however, systemd ignores the surplus. So, in the quoted file, systemd ignores everything after the path entries. I received no error indicating this in my instance.

but when I change the config flie /etc/systemd/system/ollama.service like this:
Environment="OLLAMA_MODELS=/data/models"

And try to restart ollama, I got Error could not connect to ollama app. When I try ollama serve, it failed pending at source=routes.go:1042 msg="no GPU detected".
To prove it, I comment the OLLAMA_MODELS line. It works again.
Anyone know how to slove it?

After sever try, I got the reason is dir permission. Slove like this sudo chown ollama:ollama /data/models.

For anyone arriving from Google, check /usr/share/ollama/.ollama/models or /var/lib/ollama/.ollama/models as was the case for me on Arch. The model files are stored in the blobs subdirectory with unhelpful names but you can sort by largest, and inspect a file's contents to find its name like so:
hexdump -C -n 256 /var/lib/ollama/.ollama/models/blobs/sha256-8eeb52dfb3bb9aefdf9d1ef24b3bdbcfbe82238798c4b918278320b6fcef18fe

You can serve them with llama-server as they're gguf files, useful in case you need some features ollama is missing (e.g. batching, grammar, completion)
./build/bin/llama-server -m /var/lib/ollama/.ollama/models/blobs/sha256-8eeb52dfb3bb9aefdf9d1ef24b3bdbcfbe82238798c4b918278320b6fcef18fe -c 2048

@abb128 thanks.
On Ubuntu 24.04, it's in /usr/share/ollama/.ollama/models. I installed ollama using https://ollama.com/download and it's started as a service.
A sudo access (to become ollama or root) is needed to read it manually.
$ ls -ld /usr/share/ollama/
drwxr-x--- 4 ollama ollama 4096 Dec 23 09:53 /usr/share/ollama/


Remove reflection usage for SKObject creation

Description of Change
Describe your changes here.
Bugs Fixed

Related to issue #

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
List all API changes here (or just put None), example:
Added:

string Class.Property { get; set; }
void Class.Method();

Changed:

object Cell.OldPropertyName => object Cell.NewPropertyName

Behavioral Changes
Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[x] Rebased on top of master at time of PR
[ ] Changes adhere to coding standard
[ ] Updated documentation

Just a unit test failure due... because we no longer have to have a test for a field:
     D:\a\1\s\tests\Tests\GarbageCleanupFixture.cs(23,34): error CS0117: 'HandleDictionary' does not contain a definition for 'constructors' [D:\a\1\s\tests\SkiaSharp.Desktop.Tests\SkiaSharp.Desktop.Tests.csproj]

Woops. Will fix that shortly.

Pity there is no generic constraint for complex constructors new(IntPtr, bool) 😢

Yep but we could just introduce parameterless ctor and move the current logic to a internal virtual method I guess.

Hmmmm. We could do that.
Already the code is set up to support setting the handle later in the construction. So technically, we can do:
var obj = new SKSomething();
obj.SetHandle(handle: handle, owns: true);

The issue is with already-default constructors, like new SKPaint(). That already constructs a new native object. From user code.
Not sure how to deal with that...

Might a special paint help here? ReferencedSKPaint : SKPaint that is used by code that wants to expose a already existing instance?

Okay. A parameterless ctor will not work because it has to be public. So the delegate approach is the best we can get for now without duplicating code.

Haven't fixed GarbageCleanupFixture yet

No prob. I was just updating from master with some more unit tests for other things.

What project were you using to make these changes? Was it the source project? I managed to fix the unit tests in VS2019 (I think) so it might also be cool to just open the .NET Core tests and then use them as you work on things. And you can use it to test chunks of code. Not sure what is happening with the full framework test not running in VS, but it work on the command line so no biggie.

I am working with the Netcore Tests project. That isn't including all tests.

Do we get a public ci build again that let's us see the failing tests?

We were working on that, but we also keeping our usage of DevOps down so we can let the COVID-19 responders get priority.
I say we smack this virus a big one and scare nature into a state where it doesn't want to pop another for a very long time 😆 (my expert medical opinion)

What did fail this time?

DevOps. Sometimes it just fails to download the Windows SDK or some random thing. Restarting it. Sometimes the asset copy between stages also just forgets to copy a file.

I have been thinking about this PR... The delegates inline make is easier to maintain, but still a bit... well... not awesome.
I did like the way you did the static methods of GetObject in each type in https://github.com/mono/SkiaSharp/pull/1193. Maybe we could make the new, local GetObject just call the SKObject version:
internal static GRContext GetObject (IntPtr ptr, bool owns = true, bool unrefExisting = true) =>
    SKObject.GetObject<GRContext>(handle, (h, o) => new GRContext(h, o), owns, unrefExisting);

This will also reduce the amount of IL generated for the thousands of delegates. I suppose that is less duplication and we just have to worry about the method signature, which is easy.
I know you have been working on this for several days and it is a pain to keep going back. So, thanks for sticking with it. Did you managed to run any perfs? It will be interesting to see how much the improvements are.

I am fine with redoing this. Your suggestion reduces the code noise so I am fine with it.
I wonder if we should get rid of the delegate as well if we introduce a helper method on each type.
Creating object before this change took 3% after this change it was 1%. Destruction of objects still takes about 4% of all processing.
In general SkiaSharp had less impact on the overall processing time.
I can run some benchmarks if you want.

Interesting that destruction takes more time... Do you have any idea where this overhead is? I will run some more profiling and see... Has there been any variance with types of objects/operations?

I am calling SKFontManager.MatchCharacter quite often. That produces SKFontStyle on every call. It is really bad to cache these one time used instances.

That produces SKFontStyle on every call.

I saw that and now I cache that now: https://github.com/mono/SkiaSharp/blob/master/binding/Binding/SKFontStyle.cs#L55
But, did you try the overloads that take a parameter?
https://github.com/mono/SkiaSharp/blob/fc9f030a08eb158fb934774cdf54f8df939088c7/binding/Binding/SKFontManager.cs#L170

Y I will cache them on my own in the future still I don't see why SKFontStyle isn't a struct.

I will fix the unit tests tomorrow. When we agree on this solution I will fix coding style issues.

OK, I'll review. Thanks for all the effort. It is much appreciated.

Okay. Next try 👍

I did some benchmarks and things are looking like they are about 1.3x faster!
BenchmarkDotNet=v0.12.0, OS=Windows 10.0.18363
Intel Core i9-9980HK CPU 2.40GHz, 1 CPU, 16 logical and 8 physical cores
  [Host]     : .NET Framework 4.8 (4.8.4150.0), X64 RyuJIT
  Job-VTGAFA : .NET Framework 4.8 (4.8.4150.0), X64 RyuJIT
  Job-MNUBEA : .NET Core 3.1.2 (CoreCLR 4.700.20.6602, CoreFX 4.700.20.6702), X64 RyuJIT
  Job-XIDDXQ : Mono 6.8.0 (Visual Studio), X64

BEFORE
|  Method |       Runtime |     Mean |     Error |    StdDev |
|-------- |-------------- |---------:|----------:|----------:|
| TheTest |    .NET 4.7.2 | 1.369 us | 0.0211 us | 0.0197 us |
| TheTest | .NET Core 3.1 | 1.178 us | 0.0233 us | 0.0229 us |
| TheTest |          Mono | 2.811 us | 0.0536 us | 0.0550 us |

AFTER
|  Method |       Runtime |     Mean |     Error |    StdDev |
|-------- |-------------- |---------:|----------:|----------:|
| TheTest |    .NET 4.7.2 | 1.051 us | 0.0172 us | 0.0143 us |
| TheTest | .NET Core 3.1 | 0.940 us | 0.0181 us | 0.0169 us |
| TheTest |          Mono | 1.912 us | 0.0186 us | 0.0156 us |

CODE
[SimpleJob(RuntimeMoniker.Mono)]
[SimpleJob(RuntimeMoniker.Net472)]
[SimpleJob(RuntimeMoniker.NetCoreApp31)]
public class Benchmark {
    [Benchmark]
    public object TheTest() {
        // the actual test
        var data = SKData.Create(1);

        data.Dispose();
        return data;
    }
}

public class Program {
    public static void Main(string[] args) {
        var summary = BenchmarkRunner.Run<Benchmark>();
    }
}

Hmm that isn't much but at least this will free us from reflection.

Not much, but it might add up on larger drawings. This is a 1.3x speed up on almost every static construction and many members.
And this is just .NET desktop. Who knows what actually happens on iOS or other AOT systems.

Thanks for this PR, took a few runs but we got it all done and we now have a slightly faster SkiaSharp.

I am fine with redoing things to get the best results. Will start experimenting with the V2 bits soon so we get that stable soon.


(PUP-5903) Add local type alias to 4.x function api (review only a.t.m)

This adds the ability to add type aliases that are local to a function. See commit for example.
At this point, this is up for a preliminary review only and there are yet no tests of the new behavior.

The TypeParser is modified so it can operate on a Scope or a Loader (there is no scope available that would find the loader in question, so this was required).
The RunbyFunctionInstantiator proviedes a Binding where loader is bound when doing the eval of the loaded function .rb file
A user that wants to use type alias must use create_loaded_function instead of create_function, and must supply the loader from the Binding (i.e. just give it as an argument, see commit message).
A new builder was added to handle the local_types clause in the  function definition. It creates a new nested loader that the Function class remembers.
The Function class new operator is overloaded to set the loader from local_types instead of the user given one in case a more specialized loader should be used.

This design was favoured as it only includes one piece of magic - supplying "loader" that is available when loading via divine powers. Another approach was explored where this was not required, but that required the implementation of nested things to use block.binding.local_variable_get(:loader) to get the local variable out of the provided Binding. That is much worse "logic from a distance" and prevents rational behavior when testing (i.e. just calling the create function with a loader when testing).
Not 100% happy with the name create_loaded_function - open to suggestions, or on a different approach in carrying over the loader from the RubyFunctionInstantiator into the Function implementation.
Ideally, a loader should always be given when creating a function, but the existing API for create_function cannot be changed. Ideally it should always be present when evaluating the block. (Any suggestions?)
Is it fine that if there is a local_types clause there will always be a nested loader for local types even if user did not add any local types.

The one thing that I react to instantly is that a user that wants to benefit from this must use a different create function and provide a loader. Why is that? Isn't it possible to create such a loader on the fly in case there's a need for it? I don't mind having another function that enables some other user-defined loader to be used but I think that's a corner case that very few will explore.

Perhaps one solution could be to defer all evaluation of parameter types until the function is instantiated.

I agree, the need to pass the "loader" on like that is not satisfactory. The problem is that the binding makes it available to the given block, but when I need to pick it up (before evaluating anything since it may be the call to 'local_types' I had trouble finding it anywhere. I did a number of trials of using block.binding.get_local_variable. Maybe the problem is that just did not find the right spot - i.e. in "create_function" but before it evaluates that block.

meh, failures on Ruby 1.9.3 and 2.0.0. Have to look into if what I want is possible there.

Found a way around the problem that should work on Ruby 1.9.3 and later

I think this looks good now. Wish I had it when I wrote the dispatchers for the lookup function. I made some nitpick comment. A rebase is needed.

Some follow up in other tickets will be needed in the type mismatch describer to make the messages understandable - the user cannot see the local types anywhere (at least not easily).

The local_types support must also have a way to use the defined types in the logic - i.e. find the loader. (it is already but not in a nice way as you have to use `self.class.loader.load(:type, ''typename') to find one.

Part of this was cherry picked as it solves other problems targeted for stable. Some tests were added there. @thallgren and I agree this + a couple of additional tests makes this complete.

The problem is that the binding makes it available to the given block, but when I need to pick it up (before evaluating anything since it may be the call to 'local_types' I had trouble finding it anywhere. I did a number of trials of using block.binding.get_local_variable. Maybe the problem is that just did not find the right spot - i.e. in "create_function" but before it evaluates that block.??

This PR is superseded by  PR-4768

@nedi00 , sounds like you're using the create_function in a scenario that we haven't anticipated (i.e. not using the auto loader). The unit tests in the new PR may be of help but it's nothing that I'd recommend for a production system as all the things related to accessing the loader in a dispatch is api-private.

@nedi00 hit me up on IRC helindbe if you tried using this before it was merged and you had issues. If this was intended as advice, I think we figured out how it works - the solution looks good now.


feat: port Algebra.Order.ZeroLeOne

[x] depends on #608

theorem zero_le_two [Preorder α] [One α] [AddZeroClass α] [ZeroLeOneClass α] [CovariantClass α α (· + ·) (· ≤ ·)] :
    (0 : α) ≤ 2 :=
  add_nonneg zero_le_one zero_le_one

yields
failed to synthesize instance
  OfNat α 2

I could replace the RHS by 1 + 1, but that doesn't seem useful.

Just replace the typeclass arguments with an AddMonoidWithOne? (Whatever it takes to summon the OfNat instance.)

Could you please fix the long lines?

Note duplicated work in #664.
Moreover, @YaelDillies has proposed a mathlib3 refactor https://github.com/leanprover-community/mathlib/pull/17646 which would simply merge this file into other files. I propose we just close both of these PRs for now.
Zulip discussion at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/naming.20conventions


Forget now has --prune which might be more efficent.

I was comparing one of my servers and it uses restic forget --prune instead of restic prune. It appears a bit more efficient as it only runs prune if there is something to prune.

I've updated the comment and the forget.


Add codecgen support

Don't merge yet. It's having some generation problems against your new types.go files

Updated, give it a spin.


Make a list of missing components/functions/functionality

Summary
Right now when a test breaks, it's pretty difficult for a developer to tell whether something went wrong in the unit test, or something went wrong in brs. Particularly, not every component is implemented, and some components (i.e. MarkupGrid) are just "skeletons" that don't actually behave like they do in BrightScript.
We should keep a list of all of the components and global functions that are not yet implemented so that it's easily discoverable for developers.
(Also, it'd be really cool if we were able to somehow leverage that in the code, so we could print messages to the user like "Error: Tried to use FooComponent, but it is not implemented")

d'oh, that wasn't the full list — that's what I get for manually linking.

d'oh, that wasn't the full list — that's what I get for manually linking.


Initial Filament v3 changes

Initial batch of changes for Filament v3.  Mostly in the package service provider, and a few tweaks in the action code.  Basic usage of the bulk action and header action on basic model in a resource are working.

The getStateFromRecord() change in WithMapping is to handle Filament V3's new nested relationship handling, where you can have any arbitrary dotted chain of relationships in a TextColumn, which can include "many" relations, like ...
TextColumn::make('post.comments.author')
   ->label('All Comment Authors')
   ->listWithLineBreaks(),

If there are multiple values, getStateFromRecord() returns an array, which is then formatted in the column's view, according to whatever formatting methods are applied to the column, like listWithLineBreaks() or bulleted().  If no specific nested formatting methods are applied, Filament renders as comma separated.  Obviously we can't use the view logic, although in theory we could look to see if a formatting method is applied to the column and do newline or comma separation accordingly ... but for now I just imploded with a newline.


Feature Request: Support for docker secrets

How?
Like mysql environment variable MYSQL_PASSWORD_FILE, an equivalent RESTIC_PASSWORD_FILE.
Example Usage
version: "3.3"

services:
  backup:
    image: mazzolino/restic
    hostname: docker
    restart: unless-stopped
    environment:
      # ...
      RESTIC_PASSWORD_FILE: /run/secrets/restic_password
      # ...
    secrets:
      - restic_password
secrets:
  restic_password:
    file: ./RESTIC_PWD

Never mind.. I should've searched restic issues first 🤦🏽♂
https://github.com/restic/restic/issues/278

And... there's this exact environment variable already exist...!


Release 45

This is a PR for Release 45.
Status:

[x] In development
[ ] In testing at NRK
[ ] Finalize and merge

Release 45 overall status: https://github.com/nrkno/Sofie-TV-automation/issues/47

Codecov Report

Merging #745 (e1148d1) into master (2a70de4) will decrease coverage by 1.66%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   69.86%   68.19%   -1.67%
==========================================
  Files         302      277      -25
  Lines       34428    33753     -675
  Branches     4662     4504     -158
==========================================
- Hits        24052    23019    -1033
- Misses       9925    10283     +358
  Partials      451      451

Impacted Files
Coverage Δ

meteor/lib/Rundown.ts
40.59% <ø> (+1.20%)
:arrow_up:

meteor/lib/Settings.ts
100.00% <ø> (ø)

meteor/lib/api/ExternalMessageQueue.ts
100.00% <ø> (ø)

meteor/lib/api/mediaManager.ts
100.00% <ø> (ø)

meteor/lib/api/peripheralDevice.ts
93.61% <ø> (-3.85%)
:arrow_down:

meteor/lib/api/pubsub.ts
93.33% <ø> (+0.11%)
:arrow_up:

meteor/lib/api/rundownLayouts.ts
54.40% <ø> (-2.75%)
:arrow_down:

meteor/lib/api/rundownNotifications.ts
100.00% <ø> (ø)

meteor/lib/api/shapshot.ts
100.00% <ø> (ø)

meteor/lib/api/system.ts
100.00% <ø> (ø)

... and 220 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Releasing of Release 45 will be skipped in favor of Release 46


[GLUTEN-CORE] Refactor cpp dependency on gtest and gbenchmark in more general way

Before this PR, gtest was installed at /usr/local/lib64 in our dev machine, and cpp/core/tests could not find gtest location to link by default.
After this PR, cmake will unify dependency management with FetchContent.

@kerwin-zk

CI failed due to oap-velox build error, seems already fixed.
/usr/bin/ld: ../../releases/libvelox.so: undefined reference to `facebook::velox::parquet::duckdb_reader::ParquetReader::ParquetReader(std::shared_ptr<facebook::velox::dwio::common::InputStream>, facebook::velox::dwio::common::ReaderOptions const&)'

Hi @zhejiangxiaomai could you help take a look?

CI failed due to oap-velox build error, seems already fixed.
/usr/bin/ld: ../../releases/libvelox.so: undefined reference to `facebook::velox::parquet::duckdb_reader::ParquetReader::ParquetReader(std::shared_ptr<facebook::velox::dwio::common::InputStream>, facebook::velox::dwio::common::ReaderOptions const&)'

Thanks, I am fixing CI problem.

I will merge it when CI pass.


Issue on python3.4

On python3.4 with the latest version of pygerduty, acknowledging an incident gives the following error. It works fine with python2.7
Traceback (most recent call last):
  File "oncall.py", line 35, in <module>
    incident.acknowledge(requester_id=me.id)
  File "/home/derek/pagerduty/lib/python3.4/site-packages/pygerduty/__init__.py", line 396, in acknowledge
    self._do_action('acknowledge', requester_id=requester_id)
  File "/home/derek/pagerduty/lib/python3.4/site-packages/pygerduty/__init__.py", line 390, in _do_action
    self.pagerduty.request("PUT", path, data=json.dumps(data))
  File "/home/derek/pagerduty/lib/python3.4/site-packages/pygerduty/__init__.py", line 654, in request
    return self.execute_request(request)
  File "/home/derek/pagerduty/lib/python3.4/site-packages/pygerduty/__init__.py", line 589, in execute_request
    response = (urllib.request.urlopen(request, timeout=self.timeout).
  File "/usr/lib64/python3.4/urllib/request.py", line 161, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib64/python3.4/urllib/request.py", line 461, in open
    req = meth(req)
  File "/usr/lib64/python3.4/urllib/request.py", line 1112, in do_request_
    raise TypeError(msg)
TypeError: POST data should be bytes or an iterable of bytes. It cannot be of type str.

Thanks for the report. This should be fixed in pygerduty-0.29.1.


votca_compare: add +/-'nan' comparision

I still do not get why we have nan values in the tests. Otherwise it looks fine

It is in third (error) column and for very short runs that we are doing during the regression tests, the error is sometimes nan as the error is sqrt((sum2-sum*sum/c)/(c*(c-1))) and for c=1, you get 0/0 and hence nan.

I have another idea how to get rid of the nan so let's hold off on this for a bit.

Not needed anymore.


preferences: changed the type of delegated property owner to nullable

Closes #38

@rwqwr, can you also add this change to core-ktx changelog?

Yes, sure.


Support for SSL and basic authentication

Hi, could this project support SSL and HTTP Basic authentication?. I think it may be interesting when you have, for intance, a consul server behind a reverse proxy with this security options enabled.
Regards

If you're connecting to Consul remotely and not via a local agent, you're doing something very odd and not supported.


TextInput Label doesn't shrink when filling from inputRef

When I'm using react-hook-form to set some values in a TextInput I receive from the server, it populates correctly, but doesn't shrink the label.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Currently the text is overlapping the placeholder text.
Expected Behavior 🤔
The placeholder should shrink and display above the filled text.
Steps to Reproduce 🕹
https://codesandbox.io/s/react-hook-form-mui-textfield-3czpw
Context 🔦
This started happening in v4.2.1 and up. It works in v4.2.0.

Are you sure about the reproduction? I don't see any issue.

@oliviertassinari Yes, I might have forgotten to save the code the codesandbox. Please check it again. The placeholder is overlapping the text.

Could the problem come from https://github.com/mui-org/material-ui/pull/16526?

I was expriencing this issue as well, using values instead inputRef though. I fixed by simply checking if there was any values or not, like this:
value={ props.myProp ? props.myProp : '' }

I don't understand why that library needs to mutate the value in the DOM instead of using defaultValue on the <input />. Could you verify that it cannot work with defaultValue being specified on the element?
Using defaultValue should automatically cause the filled state and we don't need extra effect handling.

@eps1lon I checked his code and tested what you said and it worked!
I changed my code as well. But still, using default value on number inputs doesn't fix the issue. Email, Text, and Tel work perfectly, but not number inputs.

@erfan226 I have marked your comments as off topics as you are not using the inputRef prop. Your case is different. You are very likely switching between the uncontrolled and controlled mode. Check the warnings in the console.

hi @eps1lon, Yes you can set defaultValue on the input and it should work. However, this library is leveraging some of the goodies from the uncontrolled component, which means when we declare defaultValues in the custom hook.
eg: useForm({ defaultValues: { test: '123' } })
This library itself have to mutate the input value. hope this makes sense, I would love to make this lib compatible with material-ui, as myself is a big fang of MUI. let me know if things I can improve to make integration easier, or even how things should be done in usage so I can document on the website.

However, this library is leveraging some of the goodies from the uncontrolled component, which means when we declare defaultValues in the custom hook.

defaultValue as a prop is for uncontrolled components. Why is this not sufficient and requires mutating the instance?

defaultValue as a prop is for uncontrolled components. Why is this not sufficient and requires mutating the instance?

It's more of a DX thing, like I mentioned above when dev wants to declare all default values in one go. The library allows them to write things like
const { register } = useForm({
  defaultValues: {
    firstName: "bill",
    lastName: "luo",
    email<EMAIL_ADDRESS>    pets: [ 'dog', 'cat' ]
  }
})

But why do you need to go outside of react to change the value? We already have all the tools in place to solve these issues. We specifically want to avoid mutating the instance from outside because this can cause all sorts of unforeseen issues. Especially when you're building a brand new library using hooks there's really no need to go back to handling state via DOM.
If your concern is DX you could just as well use const props  = useForm(); <input {...props} /> where props = { value, ref }. This seems like you just want it to look faster because render counts don't change.

The more I look at this the more I feel like using defaultValue as a prop is even better for DX. Your example has an indirection between the input name and its default value. One has to look at the component, check the name, look at the hook, scan for the key with the name and then sees the default value.
By having name and defaultValue at the component I have those next to each other and eliminate potential bugs when mispelling/renaming names or keys.

First of all, thanks for the feedback :)

We specifically want to avoid mutating the instance from outside because this can cause all sorts of unforeseen issues.

In this instance, I couldn't see an issue when setting up the default value. It leverages the native DOM API and it's not "outside" (it using component ref).

This seems like you just want it to look faster because render counts don't change.

I disagree with the above statement, it's not the intention for this library to "look" faster. The intention is great DX and better performance (it can be). I don't want to go for syntax like <input {...props} /> which I don't want to go into such discussion.
I guess the solution right now is to trigger an extra re-render when user changing defualtValue, I am happy to document it down in the website, so users do aware. thanks for looking into this issue tho.

By having name and defaultValue at the component I have those next to each other and eliminate potential bugs when mispelling/renaming names or keys.

Totally agree, one of the reasons we had typescript support to declare a type, so avoid misspell the name.

I don't want to go for syntax like <input {...props} /> which I don't want to go into such discussion.

Well I'm happy to hear your reasoning but if you don't want to discuss this we can close the issue. I'll wait a bit in case someone else has other arguments.

The intention is great DX and better performance (it can be).

Could you share some benchmarks so that we can evaluate if it would make sense to support this API?

Totally agree, one of the reasons we had typescript support to declare a type, so avoid misspell the name.

This sounds interesting. How do you make sure I can't write const { register } = useForm({ defaultValues: { bar: 'baz'  } }); <input name="foo" ref={register} />;?

Well I'm happy to hear your reasoning but if you don't want to discuss this we can close the issue. I'll wait a bit in case someone else has other arguments.

It's a design decision which I made when I start building react hook form. I prefer things to be more declarative so devs can see each prop. Not a big fan of {...props} you need to overwrite or get overwritten by what's in the ...props.

The intention is great DX and better performance (it can be).

sure, do you mean overall performance enhancement of this library or just setting up defaultValue? When I made my statement above, I meant overall. If you are interested in terms of overall performance enhancement, I have a couple of screenshot on the website: https://react-hook-form.com

This sounds interesting. How do you make sure I can't write const { register } = useForm({ defaultValues: { bar: 'baz' } }); ;?

export interface Props<Data extends DataType> {
  mode?: Mode;
  defaultValues?: Partial<Data>;
  nativeValidation?: boolean;
  validationFields?: (keyof Data)[];
  validationSchema?: any;
  submitFocusError?: boolean;
}

This is what we have at the moment, this library is still very young and we are still consistently improving on the type and everything else. I don't think we can prevent everything but at least we try :)
By the way, my intention was not to ask MUI to make a change for react-hook-form, rather than find a solution in between.

Would defaultValue handle a case where I would need to load a value from a server and set the default value at that time?

@minhaferzz no :(

I'm closing, following https://github.com/mui-org/material-ui/pull/17025#issuecomment-523541442. @bluebill1049 let us know if you see more people facing this issue, we could revaluate in the future.

Thanks @oliviertassinari and @eps1lon anyhow for looking into this.

I'm having a similar issue as this, but it's unclear if it's the same or different. I'm using setValue() on a few Material UI input fields on page load, but the labels are not shrinking properly in Safari only. In Chrome, the MuiInputLabel-shrink and MuiInputLabel-filled classes are being properly applied. Let me know if I should open a separate issue, or if it's a Material UI problem and I should open an issue there.

@sdornan If you have a minimal live reproduction that show that the issue originates from Material-UI, e.g. using codesandbox, feel free to open a new issue. In the case of react-hook-form, we have already explored some of the issues with the approach the library took. More details in https://github.com/mui-org/material-ui/issues/18269#issuecomment-562892026.

@sdornan please consider using Controller with MUI components.
https://react-hook-form.com/api#Controller

Here's a reproduction: https://codesandbox.io/s/hopeful-mountain-cgx6p
Will open a new issue if necessary.

@sdornan did you got this resolved?

@gradinarot https://react-hook-form.com/api#Controller

I manged to solve it by passing InputLabelProps and biding the "shrink" prop to the field's value.

@bluebill1049 Using Controller does not work on Safari either.

@rfoel I don't think so. Provide a code sandbox and screenshots/video.

@gradinarot I did the same thing as you.

I manged to solve it by passing InputLabelProps and biding the "shrink" prop to the field's value.

I know this is old, but how did you do it? passing state value and useEffect? ... I'm working in the same direction

I manged to solve it by passing InputLabelProps and biding the "shrink" prop to the field's value.

I know this is old, but how did you do it? passing state value and useEffect? ... I'm working in the same direction

Read the documentation.
https://react-hook-form.com/api/usecontroller/controller
CSB: https://codesandbox.io/s/react-hook-form-v7-controller-5h1q5

I manged to solve it by passing InputLabelProps and biding the "shrink" prop to the field's value.

I know this is old, but how did you do it? passing state value and useEffect? ... I'm working in the same direction

Put something like this on your text field.
InputLabelProps={{ shrink: controllerProps.value ? true : false }}

I manged to solve it by passing InputLabelProps and biding the "shrink" prop to the field's value.

I know this is old, but how did you do it? passing state value and useEffect? ... I'm working in the same direction

I manged to solve it by passing InputLabelProps and biding the "shrink" prop to the field's value.

I know this is old, but how did you do it? passing state value and useEffect? ... I'm working in the same direction

Put something like this on your TextField.
InputLabelProps={{
shrink: controllerProps.value ? true : false
}}

I manged to solve it by passing InputLabelProps and biding the "shrink" prop to the field's value.

I know this is old, but how did you do it? passing state value and useEffect? ... I'm working in the same direction

Put something like this on your TextField.
InputLabelProps={{
shrink: controllerProps.value ? true : false
}}

@gradinarot https://react-hook-form.com/api#Controller

@gradinarot, I know this is an old thread, but is there a way to solve this issue without the controller?
TextField stutters with the controlled input, so it would be great if there was a way, even if hacky, to make the components' labels shrink back.

@gradinarot https://react-hook-form.com/api#Controller
@bluebill1049, I know this is an old thread, but is there a way to solve this issue without the controller?
TextField stutters with the controlled input, so it would be great if there was a way, even if hacky, to make the components' labels shrink back.

I had the same problem, here’s how I fixed the bug :partying_face:
import {Controller} from "react-hook-form";
import {TextField} from "@mui/material";
import Cleave from "cleave.js/react";
import React from 'react'
import 'cleave.js/dist/addons/cleave-phone.fr'

const CleaveTextField = React.forwardRef((props, ref) => (
    <Cleave htmlRef={ref} {...props} />
));

/**
 * @param name
 * @param control
 * @param label
 * @param required
 * @returns {JSX.Element}
 * @constructor
 */
const PhoneField = ({ name, control, label, required }) => {

    return (
        <Controller
            name={name}
            control={control}
            render={({ field, formState,}) => {
                const errorMessage = formState.errors[name]?.message || '';
                return <TextField
                    {...field}
                    label={label}
                    error={!!errorMessage}
                    helperText={errorMessage as string}
                    fullWidth
                    placeholder='00 00 00 00 00'
                    required={required}
                    InputProps={{
                        inputComponent: CleaveTextField
                    }}
                    inputProps={{
                        options: {
                            phone: true,
                            phoneRegionCode: 'FR',
                        }
                    }} />
            }} />
    );
};

export default PhoneField;

The Label shrinks if you wrap the input component with Controller and pass the value into it.
<Controller     control={control}     rules={{         required: true,     }}     render={({ field: { value } }) => (         <TextField             onChange={(x) => setValue("name", x.currentTarget.value)}             value={value}             id="name"             label="Name"             variant="standard"             fullWidth         />     )}     name="name" />

The Label Shrinks if you wrap the input component with Controller and pass the value into it.
<Controller control={control} name="name"
   rules={{
     required: true,
   }}
   render={({ field: { value } }) => (
     <TextField
         onChange={(x) => setValue("name", x.currentTarget.value)}
         value={value}
         id="name"
         label="Name"
         variant="standard"
         fullWidth
     />
   )}
/>


[VL] Results are mismatch with the vanilla Spark when cast(sum(decmial(20,4)), float)

Backend
VL (Velox)
Bug description
The type of column ind_order_amount  in SrcTable is decimal(20,4), and the type of column week_ind_order_amount
in TableTarget is float.
The following SQL snippet shows that the calculation of columweek_ind_order_amount for Gluten is inconsistent with the Vanilla version, as detailed in the screenshot.
gluten branch https://github.com/apache/incubator-gluten/tree/branch-1.1
INSERT OVERWRITE TABLE `TableTarget` PARTITION (dt='2024-02-29')
SELECT
a.deal_id,
SUM(a.quantity) AS week_quantity,
SUM(a.ind_quantity) AS week_ind_quantity,
SUM(a.ind_order_amount) AS week_ind_order_amount,
SUM(a.user_cnt) AS week_user_cnt,
FROM
(
  SELECT deal_id,
  quantity,
  ind_quantity,
  ind_order_amount,
  user_cnt,
  FROM SrcTable
  WHERE partition_date BETWEEN '2024-01-31' AND '2024-02-29'
    AND deal_id IS NOT NULL
) a
GROUP BY deal_id;

Spark version
None
Spark configurations
No response
System information
No response
Relevant logs
No response

cc @zhouyuan  @rui-mo  Could you please help me take a look at this issue?

SrcTable test data
deal_id | ind_order_amount
------------+--------------------------
  952732041 |                2599.0000
  952732041 |                2599.0000
  952732041 |                   0.0000
  952732041 |               10396.0000
  952732041 |                5198.0000
  952732041 |                2599.0000
  952732041 |                   0.0000
  952732041 |                   0.0000
  952732041 |                2599.0000
  952732041 |                2599.0000

Expect 28589.0
Actual 28588.998

@kecookier Do you find this issue is caused by cast(decimal as float)? If so, could you provide a decimal value before cast so I can reproduce the result difference? Thanks.

@kecookier Do you find this issue is caused by cast(decimal as float)? If so, could you provide a decimal value before cast so I can reproduce the result difference? Thanks.

SELECT cast(sum(cast(col as decimal(20, 4))) as float) FROM VALUES (2599.0000), (2599.0000), (2599.0000), (2599.0000), (2599.0000), (10396.0000), (5198.0000) AS tab(col);

You can use the following SQL statement to reproduce the issue.

I've identified the error code, and I will submit a velox PR as soon as possible.

I've identified the error code, and I will submit a velox PR as soon as possible.

cc @rui-mo


Structs

To be able to store data in programs, as well as interface with foreign objects, we need some mechanism for structs.
Struct items
To facilitate this, we need to introduce an item for declaring structs. Here's my proposed syntax for that:
struct MyStruct

struct_item := 'struct' identifier

Fields are not declared ahead of time, because the rest of the language doesn't do that either.
The above item declares a variable MyStruct whose value is a completely new struct type.
Calling methods
Method call syntax is inherited from existing languages like C++ or JavaScript.
left.method_name(arguments)

Unlike Lua, we do not use a separate symbol to disambiguate calls with self from those without self.
A syntax sugar should be available for method calls without arguments:
left.property

This will allow for clean getters. Syntax for setters is outside the scope of this issue.
Attaching method to structs
Users should be able to attach methods to structs. To keep it familiar, a syntax similar to Rust should be used.
impl MyStruct
  # ...
end

impl_block := 'impl' expression function_item* 'end'

The subject of impl is an arbitrary expression, to allow for implementing structs from other modules.
A struct can only be implemented once. Attempting to implement it any more times results in a runtime error. A mixin mechanism may be added in the future to relax this restriction a bit.
Any functions declared in the block become the struct's associated functions. Right now functions should be the only thing permitted in an impl block; this may later get relaxed to arbitrary expressions to facilitate metaprogramming.
Constructor
There are a few designs I've had in mind when it comes to constructors. One idea is to use a Rust-like approach:
impl MyStruct
  func new()
    MyStruct { name = "Gabe" }
  end
end

Enforcing that the struct is only constructed inside the impl block however is hard with how dynamic impl blocks are in Mica.
We could also do something akin to Ruby/Wren:
impl MyStruct
  func new() constructor
    @name = "Gabe"
  end
end

function_parameters := '(' (identifier (',' identifier)* ','?)? ')'
function_annotations := ('constructor' | 'static')+
function_item := 'func' identifier function_parameters function_annotations block 'end'

field := '@' identifier
expression := field

I was thinking about using . instead of @ for referring to fields but it clashes with inline . for method calls. Ruby uses @ any nobody seems to complain about it.
Defined fields can only be accessed inside the struct's associated functions:
impl MyStruct
  func new() constructor
    @name = "Gabe"
  end

  # To declare a getter:
  func name() @name end
end

This allows us to compile structs to very efficient bytecode, by assigning a static index to each field referred to in the struct, just like Wren does.
Now, to construct the struct we simply call the constructor on the type itself:
mystruct = MyStruct.new()
print(mystruct.name())  # Gabe

Traits
Traits (or interfaces) are a way of specifying a contract a struct must abide to. Thanks to the flexibility of impl blocks, these can largely be implemented in the standard library without any additional syntax features:
func memoize(f)
  results = Map.new()
  func (arg)
    if !results.contains_key(arg) do
      results.insert(arg, f(arg))
    end
    results.get(arg)
  end
end

func Say(T)
  struct SayImpl
  SayImpl
end
Say = memoize(Say)

# Implementations of constructors omitted.

struct Dog

impl Say(Dog)
  func say()
    print("woof")
  end
end

struct Cat

impl Say(Cat)
  func say()
    print("meow")
  end
end

doggo = Dog.new()
kitty = Cat.new()

Say(type(doggo)).say()  # woof
Say(type(kitty)).say()  # meof

The only language addition this needs is a type function, to find out what type a given value is.
A proper implementation of this in the standard library should also include a seal function, to prevent any additional traits from being implemented on a struct. But maybe we should seal structs automatically once the original local variable goes out of scope?
The above example also makes use of a different way of calling methods. value.method() is syntax sugar for type(value).method(value), though I'm not sure how to efficiently implement this in the VM yet.

Multiple constructors
Structs should allow for multiple constructors.
struct Vector

impl Vector
  func new(x, y) constructor
    @x = x
    @y = y
  end

  func zero() end
    @x = 0
    @y = 0
  end
end

Each constructor must initialize all fields. Referring to a field that was never assigned to in the first constructor is an error.


[Feature]: better error display

What problem does this feature solve?
When I accidentally copied a line of incorrect code into mdx, the compilation error led to a white screen in Rspress. It took me a moment to realize that it might be due to an error in compilation. I hope for better error prompts, such as using the overlay from Rsbuild or developing an exclusive overlay for Rspress.

What does the proposed API look like?
No need to add new API.

This error is exposed at runtime, not in compilation, so the Rsbuild error overlay takes no effect.

If we do some static check, it will take a long time in build process maybe.

Got it, what I'm expecting might be Error Boundaries from the default theme. The boundary could include MDX content which is prone to throw error.


💅 customize cookies

In Accordance with GDPR, user has now control over tracking cookies.

ref #9350
ref #9152
remove/replace old vue-gtag implementation

Screenshots

Accept

Decline

What's missing

[ ] small UI changes
[ ] clarity setting
[ ] double check text
[ ] locales/translation

wheres my data-testid 😢

Hey @roiLeo thanks for PR
I don't see the text "Being on our site, you agree with our cookie policy", can you adjust please?
Is it default on?

wheres my data-testid 😢 (i accept it on tests because it sometimes gets in the way of some elements I'm trying to click on page)

✅ fixed using page selector instead of data-id

can't disable/enable cookie control, is it supposed to be like that?

this is excepted see title "Necessary cookies", some cookies are needed for proper operation like theme color, if the cookie banner has already been accepted

mobile
✅ fixed

I don't see the text "Being on our site, you agree with our cookie policy", can you adjust please?

Is it default on?

yes, default ON, even on page load

wheres my data-testid 😢 (i accept it on tests because it sometimes gets in the way of some elements I'm trying to click on page)

✅ fixed using page selector instead of data-id

can't disable/enable cookie control, is it supposed to be like that?

this is excepted see title "Necessary cookies", some cookies are needed for proper operation like theme color, if the cookie banner has already been accepted

mobile
✅ fixed

thank you

👀

Thanks @roiLeo for finishing this one.


LIME-125: Added logging helper to session lambda and conditional response so we can decouple the back and frontend of passport when we switch to common lambdas

Proposed changes
What changed
Added logging helper to session lambda and conditional response
Why did it change
So we can decouple the back and frontend of passport when we switch to common lambdas
Issue tracking

LIME-125

Closing as the logging approach has changed since this PR was created


 I don't need HTTPS. All I want is the download resume support. HTTPS and auth should NOT be forced on us. I just need a simple server with resume support.

Feel free to make them optional. Or just pull in the pieces you need.


[Refactor] Fix the clang-tidy check

Why I'm doing:
What I'm doing:
[ 62%] Building CXX object src/runtime/CMakeFiles/Runtime.dir/runtime_state.cpp.o
/root/starrocks/be/src/storage/lake/pk_tablet_writer.h:59:47: error: private field '_column_to_expr_value' is not used [clang-diagnostic-unused-private-field]
    const std::map<std::string, std::string>* _column_to_expr_value = nullptr;
                                              ^
8444 warnings and 1 error generated.
Error while processing /root/starrocks/be/src/storage/lake/pk_tablet_writer.cpp.
Suppressed 8447 warnings (8440 in non-user code, 3 NOLINT, 4 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).

What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@Mergifyio rebase main

@mergify backport branch-3.3

has the same issue on branch-3.3, backport to branch-3.3


About using PTv3 to inference our LiDAR point clouds

Hi, I encountered one problem when I tried to use the pre-trained model on Nuscenes of PTv3 to infer our own LiDAR point clouds. The category 'bicycles' is hard to categorize. 'bicycles' is often categorized as 'static manmade‘. Could you please provide some suggestions on the config when using this model?

Would fine-tuning the model (or joint training with PPT) with your personal dataset be better?

Would fine-tuning the model (or joint training with PPT) with your personal dataset be better?

Thanks for your reply. However, we don't have the labels for LiDAR point clouds. We want to generate the labels using pre-trained models. The labels are not required to be perfect, but in nearly every frames, PTv3 seems to ignore the category 'bicycle'. However, it performs well on category 'vehicle' or scenario objects.
Could you provide some suggestions or comment on this situation?

@BotaoSun @Gofinge  I am also interested in running the pre-trained model on Nuscenes of PTv3 to infer my own LiDAR point to do semantic segmentation. Would you mind sharing the process of doing this? Here's what I have in mind:

Convert my dataset such that it has following format
--train
--test
--scence0
--coord.npy
--strength.npy
--scence1
--coord.npy
--strength.npy
--valid
Leaving train and valid folder empty for now
Modify the pointcept.datasets.default.py VALID_ASSETS by leaving only coord, strength, segment and rename the file to custom_default.py
Download the Nuscene PTv3 Exp record (where do I put this folder?)
Run the test script like this: sh scripts/test.sh -p python -d custom_default -n nuscenes-semseg-pt-v3m1-0-base -w model_best

Then I should be able to get the segment.npy file? Please let me know if I am missing anything in this process.

@BotaoSun @Gofinge I am also interested in running the pre-trained model on Nuscenes of PTv3 to infer my own LiDAR point to do semantic segmentation. Would you mind sharing the process of doing this? Here's what I have in mind:

Convert my dataset such that it has following format
-train
-test
--scence0
---coord.npy
---strength.npy
--scence1
---coord.npy
---trength.npy
-valid
Leaving train and valid folder empty for now
Modify the pointcept.datasets.default.py VALID_ASSETS by leaving only coord, strength, segment and rename the file to custom_default.py
Download the Nuscene PTv3 Exp record (where do I put this folder?)
Run the test script like this: sh scripts/test.sh -p python -d custom_default -n nuscenes-semseg-pt-v3m1-0-base -w model_best

Then I should be able to get the segment.npy file? Please let me know if I am missing anything in this process.

Hi, I think transforming your data to the same format as Nuscenes is a good idea.
If you are confused with the folder path, maybe you could directly run test.py  and add the path like this

python tools/test.py --config-file ${CONFIG_PATH} --num-gpus ${NUM_GPU} --options save_path=${SAVE_PATH} weight=${CHECKPOINT_PATH}

Thanks for the responds! Now I am trying to use the pre-trained nuscene model and test it on semantic kitti but I am getting very low accuracy. Is this normal or am I doing something wrong? So the first picture is the actual label and the second is the predicted label. For example, if I select the car in the middle of the picture I am getting 252: "moving-car" which is correct but in the predicted label I am getting 44: "parking", both corresponds for the SemanticKITTI labeling. I understand the labeling objects for nuscenes and semantic kitti might be different but both has car labeled. So I would assume it's inferencing the car correctly. What I did was modifying the config file's test data for the exp record of the NuScenesDataset to SemanticKITTIDataset test=dict(         type='SemanticKITTIDataset',         split='val',

Thanks for the responds! Now I am trying to use the pre-trained nuscene model and test it on semantic kitti but I am getting very low accuracy. Is this normal or am I doing something wrong? So the first picture is the actual label and the second is the predicted label. For example, if I select the car in the middle of the picture I am getting 252: "moving-car" which is correct but in the predicted label I am getting 44: "parking", both corresponds for the SemanticKITTI labeling. I understand the labeling objects for nuscenes and semantic kitti might be different but both has car labeled. So I would assume it's inferencing the car correctly. What I did was modifying the config file's test data for the exp record of the NuScenesDataset to SemanticKITTIDataset test=dict( type='SemanticKITTIDataset', split='val', oh and a side note, I did not enable flash attention will that be a problem?

Sorry for the late response. Not too much. Just don't forget to reduce the patch size to a reasonable level.

Hi, I encountered one problem when I tried to use the pre-trained model on Nuscenes of PTv3 to infer our own LiDAR point clouds. The category 'bicycles' is hard to categorize. 'bicycles' is often categorized as 'static manmade‘. Could you please provide some suggestions on the config when using this model?

Could you let us know where you obtained the pre-trained model?

Hi, I encountered one problem when I tried to use the pre-trained model on Nuscenes of PTv3 to infer our own LiDAR point clouds. The category 'bicycles' is hard to categorize. 'bicycles' is often categorized as 'static manmade‘. Could you please provide some suggestions on the config when using this model?

Could you let us know where you obtained the pre-trained model?

https://huggingface.co/Pointcept/PointTransformerV3

oth corresponds for the SemanticKITTI labeling. I understand the labeling objects for nuscenes and semantic kitti might differ, but both have car labeled. So I would assume it's inferencing the car correctly. What I did was modifying the config file's test data for the exp record of the NuScenesDataset to SemanticKITTIDataset test=dict( type='SemanticKITTIDataset', split='val', oh and a side note, I did not enable flash attention

I'm trying to do inference with the pretrained models as well and I followed the exact instructions; However, I'm getting this error:
FileNotFoundError: SemSegTester: NuScenesDataset: [Errno 2] No such file or directory: 'data/nuscenes/info/nuscenes_infos_10sweeps_val.pkl'

Could you help me out? Please share the code with me or explain how you did it.

Hi, here (https://huggingface.co/datasets/Pointcept/nuscenes-compressed)


KINETIC:READY event gets called twice!

controller('MainCarousel', function ($scope) {
    $scope.$on('KINETIC:READY', function kineticReady(event, stage) {
        // do something with the stage
        // like stage.add(new Kinetic.Layer());
        // ...
        alert(1);
    });
})

The alert actually gets called twice!

I was not able to reproduce it.


Update HardwareCompatList.md

Docs Build status updates of commit fb7a864:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/learn-about-hardware/HardwareCompatList.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Ignore “ignore”

Is there a way to ignore whatever criteria is being used to ignore URLs and have those in the sitemap too?

Some URLs are ignored if their source code has a line similar to this one:
<meta name="robots" content="noindex , nofollow" />

(which IMHO sitemap-generator-cli should ignore when run with the option --no-respect-robots-txt).
Comment out line 102 in /usr/local/lib/node_modules/sitemap-generator-cli/index.js in order to include those URLs in the sitemap too like so:
      // /(<meta(?=[^>]+noindex).*?>)/.test(page) || // check if robots noindex is present

The workaround no longer works - something else is at line 102 now and "noindex" does not occur anywhere in the file.

There are legitimate use cases when one wants to obtain a list of HTML documents that constitute a website as seen by humans. Please add a way to absolutely override any and all logic that causes a page to be [ IGN ]ored.

The goal of this library is to create a sitemap for Google. --no-respect-robots-txt does what it says, ignore everything in robots.txt but not more.
If you need to crawl all of your pages you can just build something simple on your own with simplecrawler (which is used here under the hood as well).


[Suggestion] Open Materia Creation In-Game Interface Upon Clicking 'Spiritbond Complete' Alert

When clicking the 'Spiritbond Complete' alert, open the same in-game interface as when executing the General action 'Materia Extraction'.

Addendum: allow toggling the click-through mode of the alert such that this only applies if enabled.

Yes please, this would be great.

https://github.com/goatcorp/DalamudPlugins/pull/2350


Fixed ArrayIndexOutOfBounds for short stack traces

I had custom Error objects which shortens the stack trace and I would receive ArrayIndexOutOfBoundsExceptions.
This fix will ensure that this won't happen.
Hope you think this is ok!

Thanks! I had a major refactoring a few days ago, unfortunately cannot merge this code. I added this a fix for that but in a different way. Instead of while loop I put a simple calculation.
if (methodCount + stackOffset > trace.length) {
    methodCount = trace.length - stackOffset - 1;
}

This is actually not fixed by your method, still gets this in my code:
    java.lang.ArrayIndexOutOfBoundsException: length=8; index=8
            at com.orhanobut.logger.LoggerPrinter.logHeaderContent(LoggerPrinter.java:261)
            at com.orhanobut.logger.LoggerPrinter.log(LoggerPrinter.java:215)
            at com.orhanobut.logger.LoggerPrinter.e(LoggerPrinter.java:123)
            at com.orhanobut.logger.Logger.e(Logger.java:54)
            at com.izettle.android.fragments.startup.FragmentLogin.onError(FragmentLogin.java:314)

Removed a line from that log above.
Even if I change the method count to 0 it will still crash.


Fix the merging issue of signed out user with signed in user

Fixes this issue

Sorry any news on this? :)
does it gonna be merged :)

Thanks for reminding, it fell under my desk.
I am on it right now.

@BatDroid it's published 🎉

https://www.npmjs.com/package/matomo-tracker-react-native


Use main branch instead of master

Best practices say we should be using "main" branch instead of "master".

main is here: https://github.com/stacks-network/sbtc-docs/tree/main


Is it possible to format the text?

I would like to be able to apply styles as specified in the Telegram style guide (https://core.telegram.org/bots/api#html-style) but I can't get.
I saw something mentioned about it in #8 but I'm not sure if any progress was made on it.
When i log something like:
Serilog.Log.Write(LogEventLevel.Warning, $"bold");

I receive in my chat:
bold
Is it possible to apply formatting in any way with this library?
Thank you.

I can provide a switch that allows to format the messages as you like (something like a bool allowHtmlFormatting = true. In general, the special HTML chars are HTML encoded (as you already figured out) to avoid formatting issues in Telegram.

That would be great, as far as I see HTML is not currently supported, but is it possible to use now other format techniques like Markdown?

I had some serious trouble with Markdown and MarkdownV2 formatting (To make it look good in Telegram). Please don't ask me what exactly was the problem because I don't really remember. I only know that it was really complicated to construct and escape the characters.
So, if you ask me, the boolean flag (Like a 'I know what I'm doing' flag) is the best option for that and doesn't affect the other users if the default is set to false.

With the next version, you can now use the option useCustomHtmlFormatting and set it to true. I have added a test where this is shown (Check out https://github.com/serilog-contrib/Serilog.Sinks.Telegram.Alternative/blob/761e2185a7381c1c2ad29de99e06acb8d91110e5/src/Serilog.Sinks.Telegram.Tests/TestSink.cs#L455).

Great, thank you very much for the fast support and maintenance of the library :)


Remove Tuftool install prerequisite for Bottlerocket downloads

Tuftool is now in builder-base so we don't need to install it prior to Bottlerocket downloads in CI.
/hole
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.10

/hold

/approve
/unhold


Zip files is not released after the job finish

Hello!
When i use the AWS Code Build plugin, in the job finish the xxxx.source.zip file is not deleted, i need restart the Jenkins process to file be released, i can see in "lsof" command:

java      11801    jenkins  572w      REG              202,1    118609     446884 /var/lib/jenkins/jobs/Test/9c179a84-d1ca-4ca5-a9ae-e608b42883c5-source.zip (deleted)

Someone could help me please?
Thank you

Thanks for bringing this to our attention, we'll fix the issue as soon as possible.

Hi @leobaran-aws Ok, thank you! i'm waiting, if you need somethnig else please contact me.
Thank you!

Hello @leobaran-aws,
Do you have some news abou this?
Regards

I was not able to reproduce this on my Jenkins instance, but I think I found where the issue may be happening. I've pushed a fix to the branch zip-file-test. Can you pull the code, manually build with mvn install, upload the new target/aws-codebuild.hpi, and see if it fixes the issue?

Hello @leobaran-aws
Perfect, all works now, thank you! Will you merge to master? If yes when you do this can i update plugin in "Jenkins Plugin Manager"?
Regards

Great, I'll merge it in. Yes you should be able to update to version 0.19 when we release it.

Cool, do you have some estimate date to release?

Today, within the next eight hours.

Perfect. Thank you.
On Feb 23, 2018 12:56 PM, "Leo Baran"<EMAIL_ADDRESS>wrote:

Today, within the next eight hours.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-codebuild-jenkins-plugin/issues/55#issuecomment-368049965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKWM5ZPUe4ZiY-8q8fFq6ANMKkppXMt6ks5tXt-vgaJpZM4SCltn
.

Fixed in<PHONE_NUMBER>9a304c85a807b0375965601d02e1a8. We'll release this change in version 0.19, which should be available within the next couple of hours.

Thank you so much @leobaran-aws !


feat: add hover styles to homepage and minor styles fixes

Description

fix: add correct table header spacing and font size
fix: center edit page icon on mobile devices
feat(homepage): add styles on hover
fix(intro): correct margin bottom for mobile view

Testing required outside of automated testing?

[ ] Not Applicable

Screenshots (if appropriate):
Table headers
Before

After

Center edit page icon on mobile devices
Before

After

Add styles on hover to homepage steps

Correct margin bottom for mobile view
Before

After

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature request - add ability to upload images to a SimpleMDE field

It would be nice if there was an ability to upload images to a simplemde editor rather than manually pasting url of an image. Similarly to how it works in tinymce plugin.
Is this possible @tabuna ?
Thanks

Yes, that's a good idea. This download is possible.
I would be happy if you add it yourself.

Hi @angay9 . Now the field has the property to load images/files, etc. in its graphical interface.

I know it's been a long time, but maybe you like it. Will be available from next release


🐛 [BUG] - File not uploading

Description
Each and every time I am uploading a file it is showing me the below image. what that x sign mean and there were no error message as well.
Reproduction URL
no
Reproduction steps
1. Go to the website
2. Click on upload files
4. See error

Screenshots

Logs
No response
Browsers
Chrome
OS
Linux

Just checked my console output in the browser and found this.

It is saying that Magic Admin SDK Error: [ERROR_MALFORMED_TOKEN] The DID token is malformed or failed to parse. seams like Decentralized ID tokens is malformed.

Try clearing the cookies as well as local storage and try again


[Proposal] Consolidated segment metadata management

Motivation
Druid currently stores segment metadata in two places, i.e., metadata store and deep storage. In metadata store, segment metadata is stored in segments table. In deep storage, it's stored in descriptor.json file.
Druid core retrieves segment metadata only from the metadata store, and only insert-segment-to-db tool uses descriptor.json file to find segment files in deep storage.
However, storing metadata in two different places has several drawbacks.

An additional effort is required to make sure that the same segment metadata is stored in metadata store and deep storage (https://github.com/apache/incubator-druid/issues/4170).
Deep storage migration is complex because it needs to update metadata in both metadata store and deep storage.

insert-segment-to-db tool seems to be introduced for recovery when the metadata store is broken (https://github.com/apache/incubator-druid/pull/1861), but another approach should be employed to handle that kind of error, e.g., replicating metadata store.
Public Interfaces
DataSegmentFinder will be removed.
Proposed Changes
The segment metadata is stored only in the metadata store.
Compatibility, Deprecation, and Migration Plan
This is not a backward compatible change. descriptor.json file is no longer stored in deep storage. insert-segment-to-db tool will be removed.
Deep storage migration would become simpler since segment metadata needs to be updated in only metadata store.
Test Plan
N/A
Rejected Alternatives
N/A

I have seen people in past using insert-segment-to-db tool to recover metadata storage db segments.
Having said that, I think its ok to remove it and the descriptor file as well from deep storage, but at the same time we need to update docs to have more emphasis on recommending the increased importance of metadata storage in the docs and add recommendations for setting up recovery and backup policies for the metadata storage.

@jihoonson This was a cool change. I have a question regarding the existing descriptor.json files after the upgrade. Do they need to be manually removed? We use HDFS as a deep store so it would be nice to reduce the file count from Druid after upgrade validation. Thanks!

They don't need to be manually removed, but you can if you want to.

@capistrant as @gianm said, you don't have to. KillTask will remove them automatically. Also please note that KillTask will fail in 0.14.0 or earlier if descriptor.json file is missing. It means, once you remove those files, it might be hard for you to roll back to an earlier version.


Add wcosmo dependency and cosmology module

with units, we are getting this error, which essentially means the astropy.units which is a subclass of numpy.ndarray and jax.numpy.array are incompatible under jit/grad/vmap transforms.
Traceback (most recent call last):
  File "/media/gradf/academia/pdet/playground.py", line 35, in <module>
    print(vt())
          ^^^^
  File "/media/gradf/academia/pdet/playground.py", line 22, in vt
    vt_val = VT.predict(
             ^^^^^^^^^^^
  File "/media/gradf/academia/pdet/src/pdet/O3.py", line 176, in predict
    parameter_dict = self.check_input(key, shape, parameter_dict)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/media/gradf/academia/pdet/src/pdet/_emulator.py", line 423, in check_input
    key, missing_distance = self._check_distance(key, shape, parameter_dict)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/media/gradf/academia/pdet/src/pdet/_emulator.py", line 221, in _check_distance
    luminosity_distance = Planck15.luminosity_distance(redshift) * units.Gpc
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
  File "/home/gradf/miniforge3/envs/pdetenv/lib/python3.12/site-packages/quax/_core.py", line 324, in __call__
    out = fn(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^
TypeError: unsupported operand type(s) for *: '_QuaxTracer' and 'PrefixUnit'
--------------------
For simplicity, JAX has removed its internal frames from the traceback of the following exception. Set JAX_TRACEBACK_FILTERING=off to include these.

@oshaughn Any suggestions to work around this issue?

Nothing concrete.  You can apparently extend JAX to work with astropy.units, for example https://jax.exoplanet.codes/en/latest/autoapi/jaxoplanet/units/decorator/ .  You can also have something that explicitly switches from astropy units to pint units, as pint units can be compatible with Jax https://pypi.org/project/jpu/


unsupported apstra version causes crash

Found by Adam Jarvis (hilarious formatting by Microsoft Teams):
ajarvis@ajarvis-mbp ZF % terraform plan Planning failed. Terraform encountered an error while generating this plan. ╷ │ Error: Plugin did not respond │ │ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ConfigureProvider call. The plugin logs may contain more details. ╵ Stack trace from the terraform-provider-apstra_v0.15.0 plugin: panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x18 pc=0x1032629c0] goroutine 12 [running]: github.com/Juniper/apstra-go-sdk/apstra.(*Client).logStr(...) github.com/Juniper/apstra-go-sdk@v0.0.0-20230522110948-d674c2561777/apstra/logging.go:20 github.com/Juniper/apstra-go-sdk/apstra.ClientCfg.NewClient({{0x14000490450, 0x12}, {0x14000034948, 0x5}, {0x1400003494e, 0x5}, 0x0, {0x1036a7e00, 0x0}, 0x140005b1a10, ...}) github.com/Juniper/apstra-go-sdk@v0.0.0-20230522110948-d674c2561777/apstra/client.go:205 +0x680 terraform-provider-apstra/apstra.(*Provider).Configure(0x14000322b70, {0x1036ad038, 0x140005b03c0}, {{0x1400040e338, 0x5}, {{{0x1036b1760, 0x140005b1500}, {0x10358b0a0, 0x140005b0f90}}, {0x1036b3d50, ...}}}, ...) terraform-provider-apstra/apstra/provider.go:185 +0x274 github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ConfigureProvider(0x140000c5760, {0x1036ad038, 0x140005b03c0}, 0x14000596c40, 0x14000596bc0) github.com/hashicorp/terraform-plugin-framework@v1.2.0/internal/fwserver/server_configureprovider.go:15 +0xc8 github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ConfigureProvider(0x140000c5760, {0x1036ad038?, 0x140005b0270?}, 0x5?) github.com/hashicorp/terraform-plugin-framework@v1.2.0/internal/proto6server/server_configureprovider.go:36 +0x2b0 github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ConfigureProvider(0x140001aaa00, {0x1036ad038?, 0x140005a9a40?}, 0x14000596a00) github.com/hashicorp/terraform-plugin-go@v0.14.3/tfprotov6/tf6server/server.go:527 +0x250 github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ConfigureProvider_Handler({0x103672580?, 0x140001aaa00}, {0x1036ad038, 0x140005a9a40}, 0x1400041a3f0, 0x0) github.com/hashicorp/terraform-plugin-go@v0.14.3/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:331 +0x170 google.golang.org/grpc.(*Server).processUnaryRPC(0x140001a61e0, {0x1036b1a38, 0x140003824e0}, 0x14000289680, 0x14000322cc0, 0x103be0c78, 0x0) google.golang.org/grpc@v1.53.0/server.go:1336 +0xbac google.golang.org/grpc.(*Server).handleStream(0x140001a61e0, {0x1036b1a38, 0x140003824e0}, 0x14000289680, 0x0) google.golang.org/grpc@v1.53.0/server.go:1704 +0x82c google.golang.org/grpc.(*Server).serveStreams.func1.2() google.golang.org/grpc@v1.53.0/server.go:965 +0x84 created by google.golang.org/grpc.(*Server).serveStreams.func1 google.golang.org/grpc@v1.53.0/server.go:963 +0x28c Error: The terraform-provider-apstra_v0.15.0 plugin crashed! This is always indicative of a bug within the plugin. It would be immensely helpful if you could report the crash with the plugin's maintainers so that it can be fixed. The output above should help diagnose the issue.

The issue boils down to: When logging is unconfigured (nil logger and log threshold 0), a priority 0 log message (which is created in this case) leads to a nil pointer dereference in the SDK logging code.
While the provider probably shouldn't produce that condition, it's better fixed in the SDK.


c++compilation error\warning classification, just like qtcreator

This doesn't look like VS Code. Is this a issue for another editor/IDE?
Please add more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


New user questions

Hey!
I have a 3090 and I tried the new live feature, it works but ive seen it can generate a picture every half a second on other machines, I am using the automatic server and I can see it using LCM 6 steps, also in settings i set the gpu to high.
Is there a way to speed it up? Maybe doing a local install of comfyui with optimization?
How fast are your live previews with 3090/3080?

Hello. I'm not sure I understand your question. There is no live feature in this plugin if I understand correctly. Maybe you're posting in the wrong repo?

Hello. I'm not sure I understand your question. There is no live feature in this plugin if I understand correctly. Maybe you're posting in the wrong repo?

You are correct, il close the issue sorry for the confusion


lib/path: return empty string when home is undefined

I got into this issue when running node as a launchd daemon. In this case HOME environment variable isn't defined, so we are getting paths like /undefined/Library/Application Support/... as result.
This PR add guards to all home path variables, returning an empty string in case of undefined env vars.

@jprichardson Thoughts on this?
On one hand, I see @derekstavis' point, but on the other hand, //Library/Application Support/... isn't much better and '' is less intuitive to check for programmatically IMHO.

Why would $HOME not be define? Unless I suppose it's a system launchd daemon? @derekstavis   is that what is happening?

Yeah, @jprichardson, I got this issue when running as a launchd daemon.

@RyanZim I felt lame when adding this short circuits, but I still argue about '' being less intuitive interface -- it's false-y (in  if ('')) and is a return object that works well with path.* series of functions :smile:

@jprichardson Final decision?

@RyanZim what do you think about removing the methods homedir(), tempdir(), datadir() and encouraging the use of https://github.com/jprichardson/ospath instead?  ospath is a library I made over a year ago to replace path-extra, but now I'm thinking that path-extra should be focused on methods used to manipulate paths and that's it. Thoughts?

:+1: :+1: :+1:
Go for it!

If you are planning on breaking the API, be sure to add deprecation messages and also bump a minor version, instead of patch version :)

bump a minor version

Bump the MAJOR!!!
Regarding depreciation, we should allow for replicating datadir(appname) in ospath first IMHO.

@derekstavis v4.0.0 is shipped: https://github.com/jprichardson/node-path-extra/blob/master/CHANGELOG.md#400--2016-09-14.
Feel free to open an issue at ospath to continue discussion. (Unless you've already decided @jprichardson)