incorrect error message when chrome fails to create a screenshot

In some cases chrome is not able to create a screenshot. This happens sometimes when a user is running a test and starts causes the managed browser to lose focus.
Currently, visualreview-protractor reports such errors as 'something went wrong while sending a screenshot'. This is misleading as something went wrong while creating a screenshot. This message should be corrected.

command: protractor conf.js
created run with ID 5
Using the selenium server at http://localhost:4444/wd/hub
[launcher] Running 1 instances of WebDriver
F

Failures:

  1) Protractor Demo App should have a title
   Message:
     Error: VisualReview-protractor: Something went wrong while sending a screenshot to the VisualReview server. UnknownError: unknown error: cannot take screenshot
from unknown error: Failed to capture tab: unknown error
JavaScript stack:
Error: Failed to capture tab: unknown error
    at checkForExtensionError (chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/background.js:14:17)
    at Object.callback (chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/background.js:37:5)
    at safeCallbackApply (extensions::sendRequest:21:15)
    at handleResponse (extensions::sendRequest:72:7)
  (Session info: chrome=43.0.2357.81)
  (Driver info: chromedriver=2.14.313457 (3d645c400edf2e2c500566c9aa096063e707c9cf),platform=Mac OS X 10.10.2 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 60 milliseconds
Build info: version: '2.45.0', revision: '5017cb8', time: '2015-02-26 23:59:50'
System info: host: 'rBook', ip: '<IP_ADDRESS>', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.10.2', java.version: '1.7.0_75'
Session ID: d78eeeb03b5568ab591fc23573efec89
Driver info: org.openqa.selenium.chrome.ChromeDriver
Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=chrome, chrome={userDataDir=/var/folders/gj/9v9p7xqd30d77b9t743vgblc0000gp/T/.org.chromium.Chromium.kA2c84}, rotatable=false, locationContextEnabled=true, mobileEmulationEnabled=false, version=43.0.2357.81, takesHeapSnapshot=true, cssSelectorsEnabled=true, databaseEnabled=false, handlesAlerts=true, browserConnectionEnabled=false, webStorageEnabled=true, nativeEvents=true, applicationCacheEnabled=false, takesScreenshot=true}]
   Stacktrace:
     Error: VisualReview-protractor: Something went wrong while sending a screenshot to the VisualReview server. UnknownError: unknown error: cannot take screenshot
from unknown error: Failed to capture tab: unknown error
JavaScript stack:
Error: Failed to capture tab: unknown error
    at checkForExtensionError (chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/background.js:14:17)
    at Object.callback (chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/background.js:37:5)
    at safeCallbackApply (extensions::sendRequest:21:15)
    at handleResponse (extensions::sendRequest:72:7)
  (Session info: chrome=43.0.2357.81)
  (Driver info: chromedriver=2.14.313457 (3d645c400edf2e2c500566c9aa096063e707c9cf),platform=Mac OS X 10.10.2 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 60 milliseconds
Build info: version: '2.45.0', revision: '5017cb8', time: '2015-02-26 23:59:50'
System info: host: 'rBook', ip: '<IP_ADDRESS>', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.10.2', java.version: '1.7.0_75'
Session ID: d78eeeb03b5568ab591fc23573efec89
Driver info: org.openqa.selenium.chrome.ChromeDriver
Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=chrome, chrome={userDataDir=/var/folders/gj/9v9p7xqd30d77b9t743vgblc0000gp/T/.org.chromium.Chromium.kA2c84}, rotatable=false, locationContextEnabled=true, mobileEmulationEnabled=false, version=43.0.2357.81, takesHeapSnapshot=true, cssSelectorsEnabled=true, databaseEnabled=false, handlesAlerts=true, browserConnectionEnabled=false, webStorageEnabled=true, nativeEvents=true, applicationCacheEnabled=false, takesScreenshot=true}]
    at <project_root>/node_modules/visualreview-protractor/visualreview-protractor.js:195:17
    at _rejected (<project_root>/node_modules/visualreview-protractor/node_modules/q/q.js:844:24)
    at <project_root>/node_modules/visualreview-protractor/node_modules/q/q.js:870:30
    at Promise.when (<project_root>/node_modules/visualreview-protractor/node_modules/q/q.js:1122:31)
    at Promise.promise.promiseDispatch (<project_root>/node_modules/visualreview-protractor/node_modules/q/q.js:788:41)
    at <project_root>/node_modules/visualreview-protractor/node_modules/q/q.js:604:44
    at runSingle (<project_root>/node_modules/visualreview-protractor/node_modules/q/q.js:137:13)
    at flush (<project_root>/node_modules/visualreview-protractor/node_modules/q/q.js:125:13)
    at process._tickCallback (node.js:355:11)
From: Task: <anonymous>
    at VisualReview.takeScreenshot (<project_root>/node_modules/visualreview-protractor/visualreview-protractor.js:166:41)
    at [object Object].<anonymous> (<project_root>/spec.js:9:8)
From: Task: Asynchronous test function: it()
Error
    at [object Object].<anonymous> (<project_root>/spec.js:5:3)
    at Object.<anonymous> (<project_root>/spec.js:4:1)

Finished in 1.536 seconds
1 test, 1 assertion, 1 failure

[launcher] 0 instance(s) of WebDriver still running
[launcher] chrome #1 failed 1 test(s)
[launcher] overall: 1 failed spec(s)
test finished. Your results can be viewed at: http://localhost:7000/#/1/1/5/rp
[launcher] Process exited with error code 1


docs: move optional step into collapsible details

The optional step for verifying the pre-built binary takes up a large chunk of the README. Since it's a less frequently used procedure, proposal to hide the contents into a collapsible details section.

@coderabbitai review


Update README.md

Thanks for the input.
I am missing a head paragraph telling the main goal of the process.
Something like "The main purpose of this section is to integrate your project into a fully continuous delivery pipeline. What is a continuous delivery Pipeline?
...

Git triggers your Jenkins build system, which starts building ...
bla bla bla

==> A nice process UML diagram on draw.io would be welcome here.
Make them understand what they are supposed to do. The big picture.
".
Please update the README accordingly and double check English typos.

Thanks for the PR. Merged


How to update to 2.0

This is a 2 part question and it is a total novice question, so please, some grace.
In Companion 2.4.2 this AHM module is only showing up as 1.0.2. I have been unable figure out how to update to 1.0.3. if my understanding is correct the 2.0 module is for Companion 3.0.
That being said, I updated Companion to 3.0 and there is no module for AHM available.
Part one : Is there a way to update/import modules that I am just missing with Companion?
Part two : Does the update (1.0.3 or 2.0) have presets recall? Because if not, That is what I am trying to do so it will be useless in for my current needs, so is there anyone that can program this feature?
Thank you!

Seth

Part one : Is there a way to update/import modules that I am just missing with Companion?

There is no current way to update modules on a per module basis, you should update the Companion app is as a whole to access v2.0 of the module

Part two : Does the update (1.0.3 or 2.0) have presets recall? Because if not, That is what I am trying to do so it will be useless in for my current needs, so is there anyone that can program this feature?

Both 1.0.3 and 2.0 have preset recall. The action title is currently "Recall a scene"


Custom network should be highlighted when you click on it

Problem
When you click on Custom for custom network that tab should be highlighted.

Solution
See above
Alternatives
No response

It won't become active before establishing a connection with it that's why it is not highlighted and should not be


NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Couchbase integration

This PR includes two commits for NIFI-5054 and NIFI-5257.
NIFI-5054 can be merged separately, but NIFI-5054 depends on the dependency version bump in NIFI-5054.
These enhancements are all Couchbase Server related, and should be easy to review together.

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Hi @ijokarumawak I tried building this today (on Windows). I'm not much of a Java developer, so this could easily be a noob mistake. It looks like there was an error here:
> [ERROR] Errors:
> [ERROR]   TestMinimalLockingWriteAheadLog.testRecoverFileThatHasTrailingNULBytesAndTruncation:503 ╗ OverlappingFileLock
> [INFO]
> [ERROR] Tests run: 30, Failures: 0, Errors: 1, Skipped: 3
>

Which leads to a build failure at the end:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:38 min
> [INFO] Finished at: 2018-06-04T11:44:56-07:00
> [INFO] Final Memory: 134M/920M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project nifi-write-ahead-log: There are test failures.
> [ERROR]
> [ERROR] Please refer to C:\zproj\nifi-ijokarumawak\nifi-commons\nifi-write-ahead-log\target\surefire-reports for the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the command
> [ERROR]   mvn <goals> -rf :nifi-write-ahead-log

I've put the entire output into a pastebin here: https://pastebin.com/Am3k3xn4
Is there something I'm missing or doing wrong?

Hi @mgroves, first of all, thanks for jumping on the review process! Some unit tests fail due to environmental difference or race conditions. Does the error happen consistently? If so, the test might have issues on Windows. We have disabled several unit tests on Windows, and we may need to do the same with that particular one. However, the test has been there for about a year. I suspect the failure can occur occasionally. Anyway, since the test is not related to this PR, you can ignore it to proceed.
If the test failure persist, please add -DskipTests maven option, or @Ignore annotation to that test method.

Thank @ijokarumawak, I used -DskipTests and it built successfully for me on Windows. I tried out the PutCouchbaseKey operator with a CouchbaseClusterService using a username and password, and it works great.
I'm curious how it would work if someone wants to use a newer version of NiFi with Couchbase 4 or older. I'm not familiar enough with the NiFi architecture or project--will they have to use an old version of NiFi or is there someway they can keep using the older module?

Thanks @mgroves for confirming that you can use username/password authentication, that helps a lot to finish review cycle!
As for the compatibility against older version of Couchbase Server, I tested this updated NiFi component against Couchbase Server 4.5 EE. I confirmed followings:

A bucket without password can be accessed
A bucket with password can be accessed with a bucket password using the existing user-defined-property configuration.
What if a bucket with a password is accessed with a user name and password? If the user name is the bucket name and password is a bucket password, then it succeeds.

Couchbase Java SDK provides backward compatibility well, so NiFi can rely on that. The updated NiFi can access Couchbase 4.x and 5.x.

Great @ijokarumawak, thanks for that clarification. What are the next steps to getting this PR accepted? Do we need to just wait for further review, or is there anything else you need from me? When this PR is accepted, by the way, I'd love to have you write a guest blog post to talk about it and promote Nifi some more :)

@mgroves In order to get this PR merged, we need a +1 from another NiFi committer. We need to wait for further review. Hope it will happen soon.
If you have time, it would be helpful to know how you feel about other enhancements, especially CouchbaseRecordLookupService. It may require you to get familiar with many NiFi topics such as distributed cache, Record data model and Schema registry.
I don't remember if I already shared, but actually I wrote a blog post (in Japanese, but we're living in a machine translation era) about improvements included in this PR. It can be used for the guest blog post if the content looks ok.
http://ijokarumawak.github.io/nifi/couchbase/2018/06/04/nifi-couchbase-update/

Thanks for the PR @ijokarumawak and thanks for assisting with the review @mgroves! I'll be happy to have a look and help get this merged.

@mcgilman Thanks for reviewing. I've changed how Relationships are created.

Thanks @ijokarumawak! This has been merged to master.


add -json function to return JSON

add -json function to return JSON to STDOUT
STDOUT can send the status to various platform.

My forked version was not the current version


Spellbinding fabric

Check out the branch.
Basic idea is, you can use it to craft scrolls but it also is a way of moving chests around.
You should take a look and make some suggestions
Also we need textures really bad

Is everyone okay?

I would like both reviews and textures.

Tomorrow I will finalize this request and merge it. You can review it if you want.

I am gonna merge this now.


styleguide: Code consistency improvements

This pull request contains some code consistency improvements for configuration and template files used by the styleguide.
For the moment, these files contains a mix between HTML, Markdown and Jade.
I try to improve the readability of these files by replacing all HTML by the appropriate Markdown for the styleguide content or Jade for the styleguide examples.

Merci beaucoup pour ton retour et cette remise au propre des fichiers, c'est bien plus clair ainsi. 👍

Thanks for clarifying the examples.

- Small : s/em/small
- table Pays s/l/p
- Jade/Pug needs more indenting with input where a required asterisk appears Champ texte (placeholder) (really not intuitive here, meh)
- "Une grille multi-lignes" : empty div, will add "lorem" text
- new div in

. Not sure yet if it's OK or not.
- à la fin de Grid, les 2 "(pas vraiment) blocs" .grid-perso { @include grid(4, 0); } et .grid-perso { @include grid(4, 1rem); } sont ignorés (à re-inliner je suppose)


feat: add Zola

Adds support for Zola

After reviewing it seems Zola only uses a config.toml for its configuration options. I am unsure if that's a sufficient distinction between them both, however.

Thanks @henrifrancois, I opened https://github.com/netlify/framework-info/issues/329 as a follow up


Fix WebPack dev server.

Live reloading was not working.

Added npm modules for webpack hot module replacement.
Modified webpack.config.js based on settings found in typescript-react-redux-starter.
Changed readme.md to say that npm run dev runs on port 3000 instead of 8080.

Great contribution, thanks.  If you can fix up the dependency thing, I'll :shipit:

Abdella started working on this as well - we've cooked up a plan.  See #36.


Header component - Service name alignment

The service name should sit on the same baseline as GOV.UK

The navigation links are ok to be vertically centred and should remain unchanged.

line-height: 1.25 (as per your work) will get us closer (if not dead on)

font :)

Thanks, of course.
Will close issue until we know how we're rolling out the new version of the font. :)


Add default values

As per title, we need to ensure that the default are available for the library:
if the user does not specify a componentsMap ensure there is one available that uses the react-diagram default nodes and links.
if the user specify a type that does not exists in the components map, report the error in console but as a fallback use the default type for visualization.

from @zsinnema :
Create default widgets as a sort of a base widget to which we can provide the data and type of data we want to show as children and it generates the UI widget for us.

{ 'dataToShow': Types.TypeOfInput }

TypeOfInput can be something like TextInput and we provide default looks for TextInput + default functionality (like editing)

@afonsobspinto I would look at the material ui library
also I think @vidhya-metacell can help you with this archtitecture
ad 1) yes and a new component type can "inherit" from an existing
ad 2) yes, think of "theming"


Stray Code in Cash Register Boilerplate

Describe the Issue
Stray code is populated in the boilerplate for the Cash Register project
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-cash-register-project/build-a-cash-register
Your code
let price = 1.87;
let cid = [
  ["PENNY", 1.01],
  ["NICKEL", 2.05],
  ["DIME", 3.1],
  ["QUARTER", 4.25],
  ["ONE", 90],
  ["FIVE", 55],
  ["TEN", 20],
  ["TWENTY", 60],
  ["ONE HUNDRED", 100]
];

Expected behavior
User should have blank project to start
Screenshots
No response
System
All
Additional context
No response

I believe this was actually intentional as to show campers the correct data structure for the cid array.
@scissorsneedfoodtoo thoughts?

Hmm, its in there without an explanatory comment and has confused at least one user.

It looks like the boilerplate code is possibly referenced here

If you'd like to test your application with different values for price and cid, make sure to declare them with the let keyword so they can be reassigned by our tests.

but being more explicit would be better.
we could rework this section here

There are a few variables you'll need to use in your code:

price: the price of the item as a floating point number.
cash: the amount of cash provided by the customer for the item, which is provided via an input element on the page.
cid: cash-in-drawer, a 2D array listing available currency in the cash drawer.

proposed new version
In the `script.js` file, you have been provided with the `price` and `cid` variables. The `price` variable is the price of the item, and the `cid` variable is the cash-in-drawer, which is a 2D array listing the available currency in the cash drawer.

The other variable you will need add is the `cash` variable, which is the amount of cash provided by the customer for the item, which is provided via an `input` element on the page.

@jdwilkin4 I think the proposed version looks good.


[feat] Update Tauri version

Describe the problem
Hi,
We have Tauri Application that I have automated tests to check it.
We have different branch that we want to check (Prod, Master, RC, private branches, feature  branches).
We want to work with the auto-update feature.
In tauri.conf.json we set the updater endpoint from where to look for update but I need to install the application from different location.
Can we control this endpoint dynamaclly ?
It come up that we need to create about 8 different MSI that have different updater endpoint
Also another problem while running automation is that I try to make silent install using msiexec but due to security issues it works also when run as Administrator so I cant do it from my code.
Do you have solution for that ?
Thanks
Idan
Describe the solution you'd like
I would like to get solution on how it should work
Alternatives considered
No response
Additional context
No response

I will consider this as duplicate of https://github.com/tauri-apps/tauri/issues/7422 and thus will be closed by https://github.com/tauri-apps/tauri/pull/7432 which has a new API to configure the endpoints at runtime instead of only through the configuration.

@amrbashir If I understand correctly the solution you suggest is relevant only for a dynamic update server and not using a static JSON file?

for both, you will be able to specify the endpoints (where to look for an update, be it a server url or just a json file). So you can manually check for an update against the alpha Prod branch for example, then in another test, check for an update against the RC branch, and so on

Can you write please a code example of the PR you mentioned? thanks!
in addition, I see the code was not merged yet to master.
when does it plan to be merged?
thanks!

Can you write please a code example of the PR you mentioned?

tauri::Builder::default()
  .setup(|app| {
  	tauri::async_runtime::spawn(async {
  	  let updater = app.updater();
	  let update = update.endpoints(&["your prod/staging/feature update url"]).check().await.unwrap();
  	});
    Ok(())
  })
  .run(tauri::generate_context!())
  .expect("error while running tauri application");

in addition, I see the code was not merged yet to master. when does it plan to be merged?

Hard to say but hopefully it will be available as part of 1.5 release.

I want to check the match environment: "your prod/staging/feature update url"
by parameter that I get from outside,
for example - I want to run the tauri application in dev& build mode and pass each time another parameter that indicates which endpoint I need.
how can I do it?
examples will be appreciated :)

tauri::Builder::default()
  .setup(|app| {
  	tauri::async_runtime::spawn(async {
  	  let updater = app.updater();
	  let update = update.endpoints(&[std::env::var("UPDATE_URL")]).check().await.unwrap();
  	});
    Ok(())
  })
  .run(tauri::generate_context!())
  .expect("error while running tauri application");

and so you'd run your app like this:
UPDATE_URL="https://your.update/url" cargo tauri run

or you could build a small UI where you can input the URL and then do the check in a tauri command.

thanks!
if I want to change the updtae_url when I run the application EXE,
for example running in bash : tauriApp.exe https://your.update/url
how can I get this param in main.rs file?

use https://doc.rust-lang.org/stable/std/env/fn.args.html


New Scraper: Kings County Board of Supervisors

Create a new scraper for Kings County Board of Supervisors
Jurisdiction: Kings County
Website: https://www.countyofkings.com/departments/board-of-supervisors/calendar-agendas-and-summaries

@jpt-c
hey, OK so i found this calendar on their website. my question is what's the easiest way to scrape this thing? is this a wordpress calendar thing?
https://www.countyofkings.com/community/calendar-of-events

Tribe calendars have an endpoint like wp-json/tribe/events/v1/events which I'm not seeing on this page.
Here's an example of one of those: https://github.com/City-Bureau/city-scrapers-atl/blob/main/city_scrapers/spiders/atl_regional_commission.py
I haven't done exhaustive check, but this may just be a normal scrape needed.


Improve CI

parallelize testing in circleci, cuts CI times in half
use coveralls for coverage reporting: https://coveralls.io/github/BuoyantIO/linkerd
test-config.sh touchups:

make POSIX compliant with /bin/sh (fixes failures in parallelized CI)
more robust waiting for linkerd startup, should reduce timeout-related failures.

:star: 👖 cool!

⭐  yay! ⭐


Issue grabbing chapter list from Webnovel.com

Novel-Grabber can't get the chapter list from Webnovel, neither manually nor automatically. The manual grab just gets navigation links from the website, while the automatic checking doesn't finish.
Webnovel.com chapters scroll continuously, there is no "next chapter" button.

Make sure you're using the "full" novel URL. The one with the name in it:
https://www.webnovel.com/book/12820870105509205/Supreme-Magus
While webnovel works with just the novel number, it doesn't work in Novel-Grabber at the moment. Also keep in mind that Novel-Grabber can only grab non-vip chapters and will not count vip ones in the chapter list.

to bad it dose not inc vip content

A few aggregator sites are supported through.


Can’t send email notification with full statistics including rejected and undecided entries (not only accepted/failed ones)

Expected behaviour:
notification with accepted|rejected|undecided|failed entries is sent
Actual behaviour:
notification with only accepted and failed entries is sent
Steps to reproduce:

Step 1: add to tasks "digest" plugin with "accepted|rejected|undecided|failed" options
Step 2: add "emailreport" task with "notify" and "from_digest" plugins and "restore_state: yes" option
Step 3: execute tasks from step 1

Config example:
schedules:
  - tasks: 'task1'
    interval:
      hours: 2
  - tasks: 'task2'
    interval:
      hours: 4
  - tasks: 'emailreport'
    schedule:
      hour: 21
...
templates:
  ...
  video:
    digest:
        list: email_list
        state:
          - accepted
          - rejected
          - undecided
          - failed
...
tasks:
  task1:
    template:
      - video
...
  task2:
    template:
      - video
...
  emailreport:
    no_entries_ok: yes
    from_digest:
      list: email_list
      restore_state: yes
    seen: local

    notify:
      task:
        title: "[FLEXGET] Daily report"
        template: custom_html.template
        via:
          - email:
              from: '{? email.email_from ?}'
              to:
                - '{? email.email_to1 ?}'
                - '{? email.email_to2 ?}'
              smtp_host: smtp.gmail.com
              smtp_port: 587
              smtp_username: '{? email.smtp_username ?}'
              smtp_password: '{? email.smtp_password ?}'
              smtp_tls: yes
              html: yes

Log:
2017-01-26 21:00 VERBOSE  details       emailreport     Produced 586 entries.
2017-01-26 21:00 VERBOSE  manipulate    emailreport     Modified 0 entries.
2017-01-26 21:00 VERBOSE  details       emailreport     Summary - Accepted: 0 (Rejected: 1070 Undecided: 586 Failed: 0)
2017-01-26 21:00 WARNING  task          emailreport     Task doesn't have any output plugins, you should add (at least) one!
2017-01-26 21:00 VERBOSE  notify_entry  emailreport     No accepted or failed entries, not sending a notification.

Additional information:

Flexget Version: 2.9.8
Python Version: 2.7.12
Installation method: pip
OS and version: Ubuntu 16.04

P.S.
As @liiight proposed maybe "always_send" should be added to the "notify" plugin
Related issue and FR in forum:
https://discuss.flexget.com/t/cant-send-email-notification-with-full-statistics-including-rejected-and-undecided-entries-not-only-accepted-failed-ones/3129
https://discuss.flexget.com/t/add-always-send-option-to-notify-plugin/3130?source_topic_id=3129

The concern I have is making sure the template lines up with when the plugin sends. If we add an always_send option to task notifications, but the configured template doesn't report on rejected or failed entries, it will start sending out mostly blank emails. I'm not sure the best solution.

I think this is solvable via some jinja if condition, shouldn't be a problem imo

Yes, in my custom_html.template I have something like this:
{% if task.accepted %}
...
{% endif %}
{% if task.rejected %}
...
{% endif %}
...
etc.

That's not going to stop it from sending you a blank email.

We could go back to the way email plugin did it, and make the template have the logic (and produce a totally blank result to signify nothing should be sent.) I wasn't wild about that, but I guess it sorta makes sense, as the template has to match whatever logic you have for sending notifications anyway.

Nah, that's not so nice

For me the empty email is not a problem at all. The problem is that I can't send report with anything except accepted and failed reports. The problem is that new notification approach is less configurable and flexible than previous one, imho. If someone like me would like to receive extended report then just put a note in Wiki about possible empty email sending.
Or additionally to the "always_send" option add kind of "except_empty" option with default "true" value :)

That's awful tbh. It needs to be done right.

Sorry guys, maybe I'm not completely understand the problem.
In current implementation notify plugin sends emails about only accepted and failed entries. If none of them exists - it does not send email.
I'm not asking to break this logic, I'm just kindly asking to add 2 more states.
If none of them (including rejected and undecided) entries exists - do not send email (or any other type of notification)

I think adding a config option like
notify:
  when:
    - accepted
    - failed
    - rejected

would be better. It at least makes it clearer.

I think adding a config option like
notify:
when:
- accepted
- failed
- rejected
would be better. It at least makes it clearer and the template is free to pull any entries.

Would that be passed in to the template as well somehow? Or the templates should show all of those and you'll see all of them when the right event fires?

Or the templates should show all of those and you'll see all of them when the right event fires?

Hmm, on second thought, that's not so good. We don't want to see rejected entries in every email if it isn't selected. I guess we need some way to pass that selection in to the template.

I think we're over thinking this. Sending a notification per task run is a non common scenario. I'd say we add a statistics templates and mention in the wiki that this can result in empty notifications.

I think we're over thinking this. Sending a notification per task run is a non common scenario. I'd say we add a statistics templates and mention in the wiki that this can result in empty notifications.

You mean it would change the trigger events based on selecting one specific template? Or you mean along with adding an option on when to trigger, but certain triggers are only compatible with certain templates..

Maybe we switch the task template to iterate over the all_entries list, and also pass in some sort of filter function, or list of desired states?

@gazpachoking My idea was just to make it send notifications if there were any entries with the desired state and then pass all entries to the template.

@cvium What do you mean by "all entries"?

I just mean "make all entries available in the template", which I think they already are?

Indeed they are available, the task just gets passed into the context. I guess I just think it would be surprising that there is an option to send notifications on different triggers, e.g. rejected entries, but that the included templates would send notifications about accepted and failed entries only in that case still. I don't really want to add complicated logic in though, maybe you guys are right. If we add it, I think we should discourage use of this new option in the docs, and clearly list the caveats to do with template matching your desired (uncommon) needs.

so we're cool with just adding a flag and a warning in the wiki?

Hello dear developers. Any news when this fix will be released? :)

@gazpachoking i wanna merge #1662. objections?


[sw/rom] Updates to sec_mmio hardening

Introduce launder32 and HARDENED_CHECK to sec_mmio.
Remove shutdown callback function.
Remove expensive modulus operation.
Remove direct use of volatile.
Add checks to sec_mmio_init function to ensure counters are properly
initialized.

Signed-off-by: Miguel Osorio<EMAIL_ADDRESS>

Generated assembly https://gist.github.com/moidx/7e63545c15dc25e15efd826562fc5330

Updated assembly after implementing new changes: https://gist.github.com/moidx/7e63545c15dc25e15efd826562fc5330


MH-13242 Set disable_search_threshold for chosen globally

Just realised that Opencast 6.x and newer come with a new default here which we don't want at our site.
This pull request simplifies the code by settings disable_search_threshold globally which also makes it easier for Adopters to customize this value if desired.

So I'm assuming the reasons for declining #21 don't apply anymore? Not that I'm complaining about making things more consistent.

They still do apply - we just react differently at our side since the situation has changed: At the time #21 was in review, PR #21 would have changed the search_threshold to 0. Meanwhile, the official Opencast codebase already sets this to zero.
The motivation for this PR is that we will not follow the community considering this change and we will add a custom patch to our codebase that reverts this. That is easier to do if we only need to adapt one line of code. Hence you see this PR from our side, this time.

So I'm assuming the reasons for declining #21 don't apply anymore? Not that I'm complaining about making things more consistent.

They still do apply - we just react differently at our side since the situation has changed: At the time #21 was in review, PR #21 would have changed the search_threshold to 0. Meanwhile, the official Opencast codebase already sets this to zero.

Where does that happen? It looks like at least in edit-event the threshold is still 8.

@KatrinIhler It comes from here: https://github.com/opencast/opencast/pull/389/files. I've adapted edit-event since it is quite the same situation as the detail modals and wizards. Didn't adapt the filters, though.


Macos firefox initial click on select element does not fire click event

Current
Macos firefox initial click on select element does not fire click event
Expectation
Macos firefox initial click on select element does not fire click event
Discussion
On Macos, on firefox, the click event fires on a click of a select element value, but not on the unopened select element.
On Macos, on safari, both click events do not fire.
The environment components, especially those with select elements, have a mechanism for determining if a user is in interaction with a component, or has ended interaction with a component. Without the firing of the initial click event, there is misdetection of user interactino state, and ESC key might not work correctly.
Arguably, it is not often that one uses one might not use mouse and keyboard for navigation, but for the sake of power users who use both for navigation, this bug should be fixed asap.
UPDATE: Upon second thought, because of the inconsistency of select element behavior across browsers, it might be better to replace it with a custom dropdown element with a search capability. The custom dropdown element click events will work perfectly.

postponing.


Azure Search Readme and Samples Issues

Section Link1, Link2, Link3

Suggestion:
Add the follow code:
import * as dotenv from "dotenv";
dotenv.config();

@jongio for notification.

closed with https://github.com/Azure/azure-sdk-for-js/pull/12342


[#26] Implement a generator for Java model

Moved branch to jkenny repo and created pull request from there.


Is it possible to start Activity from a Service?

In your code backgroundactivity is started from notification service. Is this working as expected in android 10 devices?

Life saved, Thanks @fedeamura


High cpu usage

Don't know if this is an issue, but since the last couple of changes/releases i notice that the cpu utilization is increased by approximately 10% per boiler. I am running homeassistant on Raspberry pi4 and i monitor 2 Genus One boilers.
So i did some tests to see what's happening.
Up until version 2.0.0 the total cpu utilization was around 6-7%. When version 2.0.2 was installed the total cpu utilization increased to 27%. Disabling the ariston yaml file makes the cpu utilization drop to 6-7%. Disabling one of the 2 boilers that are configured in ariston yaml file make the cpu run at 17%. If i remove some sensors, selectors, etc i can make the cpu run at 10%.
Is this normal or expected considering the latest modifications?

Since Ariston changed requests I had to rewrite most of functionality. Higher CPU can be a result of different factors:

in older versions reading of data was limited while setting data, but I doubt that is the case
new version has a bit more calculations for data mapping, less preset dictionaries and more dynamic calculations, some actions that are run in different threads were changed from 1s delay to immediate.
Reducing CPU use requires profiling to identify problematic places. I did not bother as I run it on NAS as container with 4 x86 CPU cores available. But maybe it is good to optimize it a bit.

Hi,
looking with py-spy with and without the integration seems that the deepcopy in sensor_valuse() is cousing the cpu usage.

Hope this helps a little bit :)
BR


fix: validate json value correct in mapper

Description
Mapper input is not validating the JSON value correct, it's treating the empty array([]) value as invalid. As soon as I type empty array as value to any key, input field becomes invalid and the save button grays out.
How has this been tested?
Manually
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build/CI related changes
[ ] Documentation related changes
[ ] Other... Please describe:

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

This also fixes #1066


RFC: CSRs for Prims

Some comportable IPs (OTP, Flash) have primitives with CSRs nodes. These CSRs are macro-specific and typically (but not only) DFT / test related. Currently these CSRs are defined in a separate Hjson located in a closed repo, maintained by the Silicon Creator.

This creates problems with our design and DV tooling, since these tools do not understand the concept of "nested CSR" nodes. For example, the DV environment generates RAL models for both reg_top 1 and reg_top 2 in the picture above, and these RAL models alias onto each other, which causes problems with both automated and directed tests.
Furthermore, the crossbar configuration (offset / size) for these CSRs is not inferred correctly by the design and DV tooling.
There are several potential approaches to this problem and discussions on how to solve this are currently ongoing.
However, it is clear that a change (either on the DV, tooling or design side) is going to be necessary.
This issue serves as a place holder until we have converged on a solution.
See also these slides for an overview of the solutions considered so far.

Hi Michael - just to double-check, is this ready for review from the Technical Committee from your perspective?

Hey Alex - yes this is ready. We have put together a CFR document here:
https://docs.google.com/document/d/1pnDU3-V2BwEbw2nxFmSClJTIODKlCGhPS4TFC8n7D04/edit#heading=h.l7qwxjui9ien
Do you want me to send this to a specific mailing list also?

Nope, tagging it with the RFC label is fine. I've put it on the agenda for the next meeting. We did used to have separate RFC: Proposal and RFC: TC review labels (with the latter indicating it's ready for review), but it seems that label was removed at some point.

Alright, thanks!

@msfschaffner should we close this now? I know you've already implemented a scheme for this and it is already in production.

Yeah I am going to close it in a bit. I still need to document some of this.

This can go in the M2.5 backlog.


Fix Dirreadall in fid.go

9p protocol requires read messages to have offsets that are at
the start of a directory entry.  ioutil.ReadAll reads chunks from
the underlying fid at boundaries that do not have this property
and so cannot be used to read a directory. Implement Dirreadall
in terms of Dirread instead.

Fixed a few days ago, sorry for not seeing this.


Installation in windows

I am having some trouble doing the installation in windows 7 with pip and with setup.py. I see that the module was developed originally for Linux, but could it be possible to install it on windows? The error is the following:
running bdist_egg
running egg_info
creating pybdaq.egg-info
writing pybdaq.egg-info\PKG-INFO
writing top-level names to pybdaq.egg-info\top_level.txt
writing dependency_links to pybdaq.egg-info\dependency_links.txt
writing manifest file 'pybdaq.egg-info\SOURCES.txt'
reading manifest file 'pybdaq.egg-info\SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'pybdaq.egg-info\SOURCES.txt'
installing library code to build\bdist.win32\egg
running install_lib
running build_py
creating build
creating build\lib.win32-2.7
creating build\lib.win32-2.7\bdaq
copying bdaq_init_.py -> build\lib.win32-2.7\bdaq
creating build\lib.win32-2.7\bdaq\examples
copying bdaq\examples\ai_instant.py -> build\lib.win32-2.7\bdaq\examples
copying bdaq\examples\do_static.py -> build\lib.win32-2.7\bdaq\examples
copying bdaq\examples_init_.py -> build\lib.win32-2.7\bdaq\examples
creating build\lib.win32-2.7\bdaq\tools
copying bdaq\tools\extract_enums.py -> build\lib.win32-2.7\bdaq\tools
copying bdaq\tools_init_.py -> build\lib.win32-2.7\bdaq\tools
copying bdaq\wrapper.cpp -> build\lib.win32-2.7\bdaq
copying bdaq\wrapper_enums.cpp -> build\lib.win32-2.7\bdaq
running build_ext
building 'bdaq.wrapper' extension
error: ;"C:\Python27";"C:\Python27\pyinstaller";c:\Program Files (x86)\Microsoft S
Server\100\Tools\Binn;c:\Program Files\Microsoft SQL Server\100\Tools\Binn;c:\Program Files\Microsoft SQL Server\10
DTS\Binn" unexpected
Thanks a lot! And great work! :)

@gccinac ; it might be possible, but we have honestly not tried and don't plan to support this use case (we've internally moved away from needing that particular DAQ).
That said; have you tried installing with the drivers from the Advantech website?  I believe the Windows link is here:
http://downloadt.advantech.com/download/downloadsr.aspx?File_Id=1-Y2H70F

@jjmilburn ; yes, I have tried installing the drivers, but it didn't work. If I make it work on windows I'll let you know.
Anyway, thanks a lot for the library!


Roll engine 3c3b26b55c16..7e79b1f03db0 (4 commits)

https://github.com/flutter/engine/compare/3c3b26b55c16...7e79b1f03db0
git log 3c3b26b55c1682cbf58a712d102c66dca53f93e4..7e79b1f03db04a70509a207d5a0ce2de498f9aba --no-merges --oneline
7e79b1f03 Roll src/third_party/dart 896f1c4bb9..a2709992a2 (25 commits)
9c4c043ae Roll src/third_party/skia 604d5a3fca01..558637996569 (1 commits) (flutter/engine#8452)
754453df3 Roll src/third_party/skia 1f58a8e457ba..604d5a3fca01 (1 commits) (flutter/engine#8451)
d6d45da07 Roll src/third_party/skia b0ababfe5ad2..1f58a8e457ba (3 commits) (flutter/engine#8450)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


fix(package): update @jupyterlab/services to version 0.44.0

Closes #768

Sometimes doing stuff with greenkeeper and the GitHub UI is good, sometimes it is not.
¯\_(ツ)_/¯


Add header where score obtained can be mentioned

I don't think it would be possible to implement this feature without Back-End. And, we don't want to do that.


Request: Access to the sortable instance

I would like to be able to call methods on the sortable instance from inside my component, which I believe means we would need to passed in the instance as a prop.
Use case: being able to set options after the fact, based on certain conditions. For example: disabling sorting based on a toggle requires a call to sortable.set('disabled', true)  which necessitates access to the sortable instance.

Added to v0.7.0. Thanks for your efforts.


Change return type of -supportedInterfaceOrientations

This method's previous result type was provoking a warning. This patch fixes it

Our SDK and pod no longer ships this class.


Simplify implementation of extractAnnotationBaseName

Changed to extract full qualified annotation name. Lastest PR is here:
https://github.com/typetools/annotation-tools/pull/136


ZALLY-77 Fix bin path in zally command

🔋
Only shell script update.
Closes #77
More details: http://stackoverflow.com/questions/59895/getting-the-current-present-working-directory-of-a-bash-script-from-within-the-s

:+1:


breaking(Form): remove onSubmit serializer

Breaking Changes!
Form onSubmit no longer includes a second parameter with the serialized form values.  The serializer was accomplished by reading from the DOM, which is an anti-pattern in React.  The onSubmit prop itself remains in-tact and functions identically to a vanilla React form's onSubmit prop.
Fixes #1362.  See the related issues #1348 and #833 for more context.
Before
class OrderView extends React.Component {
  handleSubmit = (e, formData) => {
    e.preventDefault()
    console.log('Quantity:', formData.quantity)
  }

  render() {
    return (
      <Form onSubmit={this.handleSubmit}>
        <Form.Input name='quantity' defaultValue={this.state.quantity} />
      </Form>
    )
  }
}

After
You should hoist your data up the tree by either setting state, or using a state management solution such as Redux.
setState Example
class OrderView extends React.Component {
  state = {}

  handleChange = (e) => this.setState({ quantity: e.target.value })

  handleSubmit = (e) => {
    e.preventDefault()
    console.log('Quantity:', this.state.quantity)
  }

  render() {
    return (
      <Form onSubmit={this.handleSubmit}>
        <Form.Input name='quantity' value={this.state.quantity} onChange={this.handleChange} />
      </Form>
    )
  }
}

Codecov Report

Merging #1367 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   99.75%   99.74%   -0.01%
==========================================
  Files         140      140
  Lines        2400     2345      -55
==========================================
- Hits         2394     2339      -55
  Misses          6        6

Impacted Files
Coverage Δ

src/collections/Form/Form.js
100% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a46e8...f11ac5a. Read the comment docs.

Released in<EMAIL_ADDRESS>

then where would placeholder be...?

handleToggle for Checkbox groups state tracking
handleToggle = (e, { name, value, checked }) => {
		this.setState({ [name]: {
			...this.state[name],
			[value]: checked
		}
		});
	};


Added isset to sample feature array. Problem: while using ModelManger…

When using ModelManager, NaiveBayes fails on restoration and use of the classifier. One of the issues I spotted was on line 139, the $sample[$feature] did not contain an isset() check. So I added one. This helped in debugging the next step. I recommend we keep it.

I'm not convinced, if sample doesn't have all features that has been used in training then you should use Imputer class to generate missing features or use other strategy to ensure that all samples have equals numbers of features.

Yeah, it's not crucial, I realized this later when I was able to step over this undefined index issue. The real problem was resolved when I utilized the pipeline properly. Ideally we should handle the error better, I lost half a day :)

So, maybe better to throw some kind of exception here, for example InconsistentDatasetExcetpion

Hey @makotze, We are moving this topic further?

Thanks anyway for point this problem, fixed in: https://github.com/php-ai/php-ml/pull/327


Node.js DLL outdated in Windows Client?

My update tracker (Secunia PSI) warns me that the node.dll that comes with Keybase is outdated - can this be updated?

Tracked internally with DESKTOP-3846


BlendSpace2D Sync does not work with Discrete Blend.

Tested versions
Reproducible in 4.3 stable.
System information
Godot v4.3.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 SUPER (NVIDIA; <IP_ADDRESS>22) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)
Issue description
The sync option should play the animation starting from the last frame of the previous animation. This works correctly when using the continuous blend mode, but not when using discrete. This is readily apparent when using pixel art sprites that face the cardinal directions.
Using the BlendSpace2D in discrete mode to transition between run animations based on velocity, where continuous mode is inappropriate but maintaining timing between footsteps played on the animation, or attack frames when turning during an attack, is important. There seem to be other users affected by this as well.

Steps to reproduce
The minimal example project has a player that can move using WASD. They use their velocity and last facing direction to determine if they are in the idle or walking animation, and in which direction by using a BlendSpace2D. All of the walk animations have the same number of frames, and the walk animation on the first frame plays a footstep sound effect. The BlendSpace2D is in Sync and Discrete modes.
Notice when changing direction while still moving the sound effect is played rapidly, indicating it is playing the first frame of the animation immediately always, despite the fact that Sync is on. Now switch to Continuous mode and perform the same task, noting that the sound animation is not played immediately on changing directions but at the expected regular interval, indicating that Sync is working correctly.
I suspect the issue occurs for BlendSpace1D as well from limited testing.
Minimal reproduction project (MRP)
blendspace2dbug.zip

The issue of Sync is broken and plays from the beginning does indeed exist, and that is fixed in https://github.com/godotengine/godot/pull/100373.
However, as a problem specific to your MRP, the transition to idle occurs during the change of direction, so the issue remains because the Transition is set to Reset.

I'm also concerned about CallbackProcess mismatch due to _physics_process() vs Idle.

After applying https://github.com/godotengine/godot/pull/100373, you should consider rethinking the Transition condition or disabling the Reset option.


Change the default build-platforms to only build locallly

Now that we can support a matrix of size one out of the box, changing the default configuraiton for multi-platform builds to only run in-cluster.

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

Merging this PR without a resolution to konflux-ci/konflux-ci#567 as the multi-platform pipeline cannot be used by default in deployments as it requires the additional configuration of the multi-platform controller.


Master

Summary
Explain the goal of this change and what problem it is solving. Format this cleanly so that it may be used for a commit message, as your changes will be squash-merged.
Test Plan
How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create a networking test suite

Create a ginkgo networking test suite and add the following tests to it:
TestNetwork
TestImportantURLs

Part of the ginkgo-ization of the e2e tests
https://github.com/GoogleCloudPlatform/kubernetes/issues/3837


Add missing tokio feature for task::LocalSet

Seems like wiremock v0.4 forgot to enabled this feature, which is required for using tokio::task::LocalSet. This causes breakage in every downstream create that doesn't have this feature enabled (we don't, it seems). Enabling this feature downstream makes this crate compile, but if needed, wiremock should enable this feature itself.
Not sure how this went undetected here, since I don't see it anywhere in the dependencies.

Quite weird that we haven't caught this in our tests - it might be the case that another dev dependency enables the feature?
Anyway, thanks for reporting the issue and opening a PR!


Revert "[tf] Refactoring top-level security tests (#39453)"

This reverts commit b42fc6e5c16587ed0f6b4e76a972ec2b5b72a186.
Please provide a description of this PR:

@nmittler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
af864bc9e18169008db46eed0cfe5be7d52c0556
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio


Add scholarship information

Signed-off-by: Richard Hartmann<EMAIL_ADDRESS>

@roidelapluie was this a "good to merge once that's fixed"?

Nope, it looks like it does not render fine:
https://deploy-preview-196--promcon.netlify.app/2021-losangeles/scholarship/
In-Person: Sunday, August 8, 2021 (11:59PM Pacific Time) Virtual: Sunday, September 26, 2021 (11:59PM Pacific Time)
are on the same line. Same as in the next  paragraph.

(my apologies for the 2 steps review, first time I only looked at markdown.)

No worries; I should have caught it myself...


Transformers should come from a specific providers

Transformers should be linked to a provider so we can list available transformers for a provider.

soon we will need to set transformers parameters too....


Where is the Scanner.jar file?

I have no idea how to run this scanner and the information provided is no help either.
Ive downloaded the zip unpacked it and tried to find ths scanner.jar file but it´s nowhere to be found.
Would be nice if there was a step by step instruction how to use this software.

Looks like you have uninstalled the wrong documents, you have installed the code files. Refer to this link -https://github.com/MCRcortex/nekodetector/releases Then click on the assets option. Then click on the .jar file and save it in your computer.

As for the tutorial, after downloading the .jar file, open command prompt as administrator and then type - 'java -jar scanner.jar 4 C:' without the apostrophe.

Thanks for the help i was really confused

You're welcome, did it detect anything?

Thanks for the help i was really confused

it´s currently scanning

Scan complete. No infected jars found. nice

Scan complete. No infected jars found. nice

If you have any other drives you want to scan just copy the same command but replace the C:\ with the drive name in command prompt.

Ok good to know :)


v0.4.15 doesn't work with Ember v2.10.0

Hi! I'm trying new version but fail to run the app.
here is the issue

I made a repo for example
https://github.com/chilicoder/ember-sparkles-example2
looks like something with ember-let dependency.. but installing it doesn't help

I could make it work after downgrading
to Ember v 2.9.0
and adding dependency
"ember-let": "^0.4.0",

I created a discussion on ember forum
http://discuss.emberjs.com/t/migrating-ember-sparkles-from-2-9-1-to-2-10-d3-chart-library/12091/2

@chilicoder from your first error message it seems you’re missing ember-let have you tried ember install ember-let?

this has been fixed in the latest release, 0.4.16


F2Pool is switching to a new address (likely bc1qf274x7penhcd8hsv3jcmwa5xxzjl2a6pa9pxwm)

Not sure if they really switch to a P2TR address as they would be unable to spend from it for the next six months.
The address bc1qf274x7penhcd8hsv3jcmwa5xxzjl2a6pa9pxwm has been receiving coinbase rewards from an 'unknown' miner paid a full block reward to the old F2Pool address (likely as a proof that the own the new address).
https://web.archive.org/web/20210530050325/https://twitter.com/f2pool_official/status/1398866105553199104

This address paid 220+ BTC to the 1KFHE7... f2pool address here.


FIX? Ignore? multi disk ZIP error

Unless we have better solution for multi part zip, it would be better ignoring and pretending it is single zip file. Found that some malwares use this trick to interrupt automated analysis like below sample. https://www.virustotal.com/gui/file/2b9eb34b2d86e9119ada81f2c641086225c420d3439a3ca22e2a903ce8c2c937

@ryu-s-r  could you please share this apk or a similar one as a poc?

@erev0s Do you have preferred way to share this malicious apk file?

@ryu-s-r  feel free to use a service like https://bazaar.abuse.ch/ or you can upload it somewhere as a zip with a password and share it here.

Here's the malware sample zipped with 'infected' password.
https://quickshare.samsungcloud.com/vx6vSvYOFX4x


[SMALLFIX] Update usages of libexec CLASSPATH

alluxio-config.sh no longer sets CLASSPATH. Instead, it sets ALLUXIO_SERVER_CLASSPATH and ALLUXIO_CLIENT_CLASSPATH.

targeting branch-1.5

Merged build finished. Test PASSed.

https://github.com/Alluxio/alluxio/pull/5478


compile failed due to  E0507

rust code is simple like example
use notifica::*;

 fn main() {
     notifica::notify("Hello", "World");
 }

compile failed. error:

Compiling notifica v1.0.0
error[E0507]: cannot move out of borrowed content
--> C:\Users\s-pc.cargo\registry\src\mirrors.ustc.edu.cn-61ef6e0cd06fb9b8\notifica-1.0.0\src\lib.rs:71:9
|
71 |         self.0.uninit();
|         ^^^^^^ cannot move out of borrowed content
error: aborting due to previous error
For more information about this error, try rustc --explain E0507.
error: Could not compile notifica.
To learn more, run the command again with --verbose.

Changing teardown to take ownership instead of a mutable reference should fix this.


[C++][Parquet] Implement LZ4_RAW compression

Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=apitrou) / @pitrou
Related issues:

[Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec (is related to)
[C++] Use LZ4 frame format (supercedes)

PRs and other links:

GitHub Pull Request #9782
GitHub Pull Request #18

Note: This issue was originally created as PARQUET-1998. Please see the migration documentation for further details.

Antoine Pitrou / @pitrou:
Issue resolved by pull request 9782
https://github.com/apache/arrow/pull/9782


bits-service-release does not show any releases

Hi,
On http://bosh.io/releases/github.com/cloudfoundry-incubator/bits-service-release?all=1 it says

No versions available

although there is a valid bosh release on https://github.com/cloudfoundry-incubator/bits-service-release/releases/tag/1.4.0
Can you please help,
Thanks,
Peter and @suhlig

@petergtz havent yet re-ran pipeline script that creates new pipelines for added projects. (need a pipeline for that hehe)

should be up now: https://bosh.io/releases/github.com/cloudfoundry-incubator/bits-service-release?all=1


tags sheet improvements

use sheetsync to do some sheet actions
any tag on any event should be listed on tags sheet

Mostly abandoned in favor of Streamlog's native tag management

closed in favor of streamlog


Use IPs instead of localhost for nodetool commands

note this might break IPv6 IP tests

Note:
https://github.com/scylladb/scylla-ccm/commit/5b65941a2759e507a4ee88a65de0a985882ec69d
did in 2014 exact the opposite to get IPv6 test working
this change is needed for https://github.com/scylladb/scylla-tools-java/pull/100 to pass dtest

@tarzanek can you take this ccm branch for a walk in the BYO with -a next-gating ?, also I don't know if this issue from 2014 is still relevant, i'll try looking for the relevant tests in dtest

http://jenkins.scylladb.com/view/master/job/scylla-master/job/manual-and-scheduled-tests/job/byo_build_tests_dtest/547/
runs now

http://jenkins.scylladb.com/view/master/job/scylla-master/job/manual-and-scheduled-tests/job/byo_build_tests_dtest/547/

@fruch the jenkins job failed on something completely different - can you help me figuring out if it is relevant or how to move further?

hmm rerun or Tomeks fix fixed it:
http://jenkins.scylladb.com/job/scylla-master/job/manual-and-scheduled-tests/job/byo_build_tests_dtest/549/
@fruch is that OK with you?

@tarzanek looks good.
I would only want one quick eye from @bhalevy or @slivne if they know if we have any ipv6 tests in dtest that might break cause of this.

re: IPv6 - I think just enclosing the IP in tests into " "(or sanitizing them) would make them work, so I am puzzled the cassandra folks didn't rather fix enclosure than having a hack that depends on localhost name resolution


[SPARK-19872][PYTHON] Only reseralize with BatchedSerializer when repartitioning for skewed partition handling

What changes were proposed in this pull request?
This PR proposes to avoid serialization for non-batched ones. It seems UTF8Deserializer can't be replaced with BatchedSerializer.
with the file, text.txt below:
a
b

d
e
f
g
h
i
j
k
l

Before

>>> sc.textFile('text.txt').repartition(1).collect()

UTF8Deserializer(True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../spark/python/pyspark/rdd.py", line 811, in collect
    return list(_load_from_socket(port, self._jrdd_deserializer))
  File ".../spark/python/pyspark/serializers.py", line 549, in load_stream
    yield self.loads(stream)
  File ".../spark/python/pyspark/serializers.py", line 544, in loads
    return s.decode("utf-8") if self.use_unicode else s
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x80 in position 0: invalid start byte

After

>>> sc.textFile('text.txt').repartition(1).collect()

[u'a', u'b', u'', u'd', u'e', u'f', u'g', u'h', u'i', u'j', u'k', u'l', u'']

How was this patch tested?
Unit test in python/pyspark/tests.py.

cc @davies, could you see if it makes sense?

Test build #74462 has started for PR 17282 at commit 30688db.

Test build #74462 has finished for PR 17282 at commit 30688db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74462/
Test PASSed.

Merged build finished. Test PASSed.

This fixing is not in correct direction. The root cause is coalesce uses wrong jrdd_deserializer when constructing new RDD.
The correct fixing looks like:
diff --git a/python/pyspark/rdd.py b/python/pyspark/rdd.py
index a5e6e2b..291c1ca 100644
--- a/python/pyspark/rdd.py
+++ b/python/pyspark/rdd.py
@@ -2072,10 +2072,12 @@ class RDD(object):
batchSize = min(10, self.ctx._batchSize or 1024)
ser = BatchedSerializer(PickleSerializer(), batchSize)
selfCopy = self._reserialize(ser)

       jrdd_deserializer = selfCopy._jrdd_deserializer
       jrdd = selfCopy._jrdd.coalesce(numPartitions, shuffle)
   else:

       jrdd_deserializer = self._jrdd_deserializer
       jrdd = self._jrdd.coalesce(numPartitions, shuffle)

   return RDD(jrdd, self.ctx, self._jrdd_deserializer)

   return RDD(jrdd, self.ctx, jrdd_deserializer)

@viirya you are right. I overlooked. Thanks for correcting this.

Test build #74592 has started for PR 17282 at commit 925cd2e.

Test build #74592 has finished for PR 17282 at commit 925cd2e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74592/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

@viirya, thank you for taking a look.

lgtm, merging into master, and 2.1, 2.0 branch.

Thank you both @davies and @viirya

My code is :+1: sc.binatyFiles('hdfs://localhost:9000/user/majdouline/Training').repartition(90).collect()
and i got this error :+1:  UTF8Deserializer(True)
Traceback (most recent call last):
File "", line 1, in
File ".../spark/python/pyspark/rdd.py", line 811, in collect
return list(_load_from_socket(port, self._jrdd_deserializer))
File ".../spark/python/pyspark/serializers.py", line 549, in load_stream
yield self.loads(stream)
File ".../spark/python/pyspark/serializers.py", line 544, in loads
return s.decode("utf-8") if self.use_unicode else s
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/encodings/utf_8.py", line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x80 in position 0: invalid start byte
I had change rdd.py and serializers (version 2.1.0 to 2.0.2), but i got the same error
Can you help me please to fixe that .


Apply adversarial training after few epochs.

I want to train the model without adversarial attack at the first two epochs.
After that, I would like to train the model with adversarial learning.
In summary,
1 epoch: Training w/o adversarial
2 epoch: Training w/o adversarial
3 epoch: Training with adversarial
4 epoch: Training with adversarial
....
Is it possible to adjust the start epoch of the adversarial training?
I couldn't find any related parameter in nsl.configs.make_adv_reg_config

Closing this issue due to inactivity in 30 days. Please feel free to reopen if you have more questions.


ADD border around color for contrast

Is your feature request related to a problem? Please describe.
I dont notice grayish colors on my grayish gutter.
Describe the solution you'd like
white border in dark theme
black border in light theme
Describe alternatives you've considered
N/A
Additional context
1px is enough

No


Remove disabling buildSrc validation tasks from Kotlin DSL model building in "classpath mode"

The "classpath mode", or "lenient mode" is now only used when loading adhoc scripts model after user interaction in the IDE.
buildSrc now doesn't run validation tasks by default anymore.
This code was realizing all tasks forcibly because of it's use of matching {}

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

ReadyForNightly build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


B-17927 - INTEGRATION - Prime Simulator Enhancements For New Move Order Document Download API

B-17927
E-04799
For INTEGRATION
Summary
This PR is for enhancements to the Prime Simulator UI to consume new Prime move order document download API.
GET: /moves/:locator/documents?type:type where :type can be [ALL, ORDERS, AMENDMENTS]
API is designed to handle the following use cases:

merge all documents(order and amendments) into one PDF (type=ALL)
merge only order documents into one PDF  (type=ORDERS)
merge only amendment documents into one PDF (type=AMENDMENTS)

A new download button "Download Move Orders" and dropdown for doc type have been added within the Move section in the details page.

Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Goto http://officelocal:3000/sign-in and click "Local Sign In" and sign in as Prime Simulator office user. Create one if needed (click "Create a New Prime Simulator office User").
Click on any of the table rows in the "Moves available to Prime" page. This will take you to the details view.
Click on "Download Move Orders" button. A modal Save As modal box will display if API invocation is successful.

Adjacent to the download is document type dropdown. By default ALL is select.

Note: 422 error(unprocessable entity) is returned if attempting to download AMENDMENTS when none exist for move. An error will display. Error message will display for all documented errors.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 8f2ad46f286de3e8fb61a514be69ccc71aae9a72

Test coverage on server failed.
Last run: Thu 25 Jan 2024 02:17:45 AM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.


Silvestre/add awk runner

Curious if we really need this though
Using sh could be enough

We could do a survey on Telegram (or ask div and ayoub what they think) before adding it.


Update .env

Quotes are used as password, so login was set to 'changeme' and not changeme.

That is because you are using a version of Compose we don't support, as mentioned in the warning inside the Host Setup section of the README.
Summary:

Versions of Compose below 1.26 have a known bug that make them interpret quotes literally.
We need to be conservative with our usage of quotes because versions above 1.26 do require quotes when values contain special characters — such as $&!*... — which might be interpreted. (So do other popular Unix tools that read .env files, such as direnv).
Those characters are common in passwords, including the ones generated by Elasticsearch's password tool, which usage we recommend in the README.

As you can see, we either support a version of Compose that is over two years old, or we quote passwords to prevent our users from running into issues such as in #667.
If I have to decide between the two, I choose to support newer versions anytime.

Oh, Sorry. We did miss this. Thanks for the reply


chore: fix errors related to missing types and TS rules

Description
Fix a few minor errors related to missing imports and types
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves #(issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide reproduction instructions and list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ x] New and existing unit tests pass locally with my changes

I don't think the TS errors in ta2-playground are valid, as in, I can remove all of them and I can still build/test/run without encountering any errors. Is it possible that you are running a different set of configurations?

I don't think the TS errors in ta2-playground are valid, as in, I can remove all of them and I can still build/test/run without encountering any errors. Is it possible that you are running a different set of configurations?

The errors only surface at the publish step on github as Martin highlighted to me.
one way to see the errors locally, is to open the local client folder and run “yarn run vue-tsc --noEmit”


Azure.Identity Revising Troubleshooting.md

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Update aka.ms links in .NET code accordingly.

@schaabs Should we include links to the error codes for authorization endpoint errors for some credentials as part of troubleshooting guide?
Examples of error codes for ClientClaimCredential could be - https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-protocols-oidc#error-codes-for-authorization-endpoint-errors
or for AuthCodeCredential could be - https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow#error-codes-for-authorization-endpoint-errors
I have opened an issue in JS to track this - https://github.com/Azure/azure-sdk-for-js/issues/20177

@schaabs I've created https://github.com/Azure/azure-sdk-for-net/issues/26947 as a reminder to update this TSG for the BrokeredAuthN package once it ships.

/azp run net - identity- ci


Graph representation of the terragrunt dependencies similar to terraform graph

It would be great to have a visual representation similar to terraform graph but with the terragrunt dependencies, something like:
terragrunt plan-all --terragrunt-graph | dot -Tsvg > graph.svg

This could be applied to the *-all commands
Related https://github.com/gruntwork-io/terragrunt/issues/1093

Released as https://github.com/gruntwork-io/terragrunt/releases/tag/v0.23.7. Binaries will show up shortly


Error: Access not granted or expired. (line 454, file "Service", project "OAuth2")

Hi,
I have exhausted all the resources (past issues, related SO posts, Google search results) so you are my last hope.
Most likely this is some basic setting error or some mistake in the process of creating a project and credentials put I just can't figure out where it is.
I'm trying to connect to Search Console and everything goes fine until it is time to get the token.
I have changed this based on one of the issues solved:
.setParam('approval_prompt', 'auto');
This is my manifest file:
"oauthScopes": [
"https://www.googleapis.com/auth/webmasters",
"https://www.googleapis.com/auth/script.external_request",
"https://www.googleapis.com/auth/userinfo.email"
],
callback URL is set, API is enabled.
Can you help me to debug further?
Thanks!

If you just need an additional Google scope, then you don't need to use this library at all. Simply add the scope to your manifest (which you already have) and then use ScriptApp.getOAuthToken() to retrieve the token the script is using, and then pass that in a UrlFetchApp.fetch() request to the API.


Optimizer: "Cannot optimize the number of edges"

Hi,
I'm trying to use the Optimizer class in the Python binding, for a version of NGT which I built from sources (v1.14.1) but I encounter a bug which seems to be an off-by-one error.
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
/tmp/ipykernel_28461/550346330.py in <module>
      1 optimizer = ngtpy.Optimizer(log_disabled = True)
----> 2 optimizer.optimize_number_of_edges_for_anng(os.path.join(export_path, "ngt-opt"))

RuntimeError: /usr/local/include/NGT/GraphOptimizer.h:505: Optimizer::optimizeNumberOfEdgesForANNG: Cannot optimize the number of edges. 0:0.937933 # of objects=5676310

The dataset I use has 5676309 data points, and the GraphOptimizer seems to want to work on point 5676310.
Minimal code to reproduce:
ngtpy.create(os.path.join(export_path, "opt"), 128, distance_type='L2', object_type='Float16')
index = ngtpy.Index(path=os.path.join(export_path, "opt"), read_only=False, zero_based_numbering=True, log_disabled=False)

for vec in xb:
    index.insert(vec)
index.save()
index.close()

optimizer = ngtpy.Optimizer(log_disabled = True)
optimizer.optimize_number_of_edges_for_anng(os.path.join(export_path, "opt"))

Am I doing something wrong here ?
Thank you !

Since the message shows the number of inserted objects + 1 by mistake, I don't think that it is an off-by-one error. When you specify 'Float' to the object type, do you get the same error?

Good call, in 'Float' there's no error and the optimization process seems to work fine.
So there's a problem with fp16 and the Optimizer ?
Concerning the fp16, according to your experience, is there a tangible benefit in terms of performances to work in fp16 instead of fp32 ?
I didn't encounter yet a database where fp16 was faster than fp32.
Thank you very much for your help and your time!

Hi, that's great, thank you for working on a fix! I will test again when it's released.
I built the NGT libraries from sources (on a CPU with AVX2) and built the python bindings from the python/ directory, by following the wiki, I believe I should get the benefits of AVX2 extensions even when building an index from Python code.

I have just made a new release v1.14.2 with bug fixes of the optimizer relating to FP16.

I closed this issue for now. Feel free to reopen this whenever you find any issue.


Automatic Upvote By The Petition Creator

Related Issue

Automatic Upvote: https://github.com/jonogon/jonogon-mono/issues/12

Description

An automatic upvote will be created by the creator of a petition.
If there is an error while creating the upvote the petition won't be created.

Thanks!


Insomnia-specific patches.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


FEAT: show selected country iso code feature implemented

This allows showing the selected country iso code, by default it is false.

Can you be a bit more specific in the description ?
Is it showing the isoCode instead of the input ? Is this actually needed ?

Hi @cedvdb , yup there is a boolean flag showIsoCodeInInput, false by default. If it is true then the currently picked or selected country's iso code will be shown in the left side of the flag.

Can you double check that things are still aligned in the example by playing with:

border: outline vs underline
hint on or off
persistent country on off
etc.

I will double check it too but it's going to be merged faster if there is no issue. This was a nightmare to get right, at least vertically

Hi @cedvdb, Actually I am talking about one boolean flag to show the selected country's iso code. It is false by default.
It won't be showing instead of input It will be shown in the left side of the flag. Please find the attachment with this comment. Currently, in the attachment I have selected the Australia an the iso code of Australia is AU that is shown just in the left side of the flag. But in my case I don't want to show the flag so the flag is missing in the attachment!

Is this screenshot from a design software or from the input itself ? Because I don't think it's currently possible to have two separate borders from this library like in the screenshot. Ence why I'm wondering if the api shouldn't be lower level to allow designs like that.

Yup! the separate border is not currently possible from the package itself, It is designed by myself for my use case. But in the pr, i have just added the the feature which shows the selected country iso code, like "AU" in the above attachment.
Great, thanks for taking care of that! Let me know if you need any help or if there are any updates.


Install additional plugins

Option to install additional plugins
Default parameters install no additional plugins
Added option to uiDefinition
Updated README

Rebased against master.
Replaces #59.

Thanks for opening this new PR @ajhewett; reviewing now

@russcam integrated review comments and squashed to a single commit.
Thanks for the git help.

Thanks again for submitting this @ajhewett 👍 Would you mind pinging me an email with the best email address to contact you on (you can find mind in the git log)?


Add ability to set the merge commit message when doing automerge

For example, a comment could be:
@dpebot merge when travis passes
Update bigquery samples

* Add support for loading tables from local files.
* Add tests.

Then dpebot would automatically use whatever is in the code fences as the commit message.

and squash!

It already squashes. :)

great, I also like something like
Pull-Request: #12 at the bottom (in the title is ok too but less nice)


Running out of connections

I use Elasticache Redis as my redis server, 1 master, 1 slave (fairly large machine, this is an autoscaling micro webservice).  I used to use an older version and it worked good (from a connections point of view), but I had to upgrade from 2.1.2 due to distributed lock fixes. I am currently using 2.2.4, but after about 12-24 hours I see the " RedisConnectionException:Can't aquire connection from pool! " exceptions.
I expected it had to do with Elasticache closing idle connections, so I turned that back off for now, but it didn't effect this behavior, it seems to be related with my update from 2.1.2 to 2.2.4.
Does redisson not refresh its connection pool as connections close, do they timeout, or is this something else entirely?
I am using SingleServer or MasterSlave Configuration, with defaults, the current behavior is seen with SingleServer. (I haven't added configurations for slaves yet)
The only functionality I currently use in Redisson is the Distributed lock mechanism, to control 2 sets of locks.
Flow of using lock: get lock, set expire to 15s, (try) process,(finally) unlock (or set lock to expire in 500ms)
Redis has plenty of connections available. only 1300 or so used out of about 7k

Redisson has async connection pool since 2.1.4 version, so connection acquisition approach has changed entirely.
When Can't aquire connection from pool! occurs it has an additional info like entires field state. Could you please print it too.

Extra Details as requested: (address hidden)
org.redisson.client.RedisConnectionException:Can't aquire connection from pool! [[freeSubscribeConnectionsAmount=0, freeSubscribeConnectionsCounter=0, freeConnectionsAmount=0, freeConnectionsCounter=0, freezed=false, freezeReason=null, client=[addr=fubar.com/<IP_ADDRESS>:6379], nodeType=MASTER, failedAttempts=0]]\nat org.redisson.misc.ConnectionPool.get(ConnectionPool.java:124)at org.redisson.connection.MasterSlaveEntry.connectionWriteOp(MasterSlaveEntry.java:184)at org.redisson.connection.MasterSlaveConnectionManager.connectionWriteOp(MasterSlaveConnectionManager.java:565)at org.redisson.command.CommandAsyncService.async(CommandAsyncService.java:341)at org.redisson.command.CommandAsyncService$5.run(CommandAsyncService.java:386)at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:581)at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:655)at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:367)at java.lang.Thread.run(Thread.java:745)

Does redisson not refresh its connection pool as connections close, do they timeout, or is this something else entirely?

It has ConnectionWatchdog it handles situation when connection is down and tries to reconnect.

do you see in logs messages produced by this line at ConnectionWatchdog:100?
log.warn("Can't connect " + connection + " to " + connection.getRedisClient().getAddr(), e);

No, no messages containing "Can't connect" in the logs with severity of Warning. We use logback appenders (Dropwizard framework) if that matters any.

Could you try to lunch it with debug level mode for org.redisson package ?

I'll try it and hope it works. Dropwizard tends to override most configurations due to their glueing tools together.

Please note debug lines like at CommandAsyncService:541:
            log.debug("connection released for command {} and params {} from slot {} using node {}",
                    details.getCommand(), Arrays.toString(details.getParams()), details.getSource(), connection.getRedisClient().getAddr());

It will be deployed in a few days and I'll respond to this ticket with more details as I find them. Thanks for your help!

try 2.2.7 version which has just gone to maven central and increase connection pool size amount.

@INRIX-Cory-Bradshaw Have you tried?

I couldn't update to latest due to dependency conflicts with the web service framework we are using. Thanks for your help though

Just wanted to add that I am also getting the "Can't aquire connection from pool!" error when running a load test with both Redisson 2.2.7 and 2.2.8 (error message is different but is about the exhausted pool).
I downgraded Redisson to 2.1.2 and the same load test succeeds without the error.
As an idea of the load I am running:

v2.1.2 opens 38 of the 100 max connection in version 2.1.2 and happily continues.
v2.2.8 uses the entire 100 connections and falls over exhausted pool error.
I have also tried increased the max connections to 1000 in v2.2.8. Redisson quickly uses all 1k connections and throws the exhausted error message again.

Thanks for adding more information. Is there any way we can get the connection handling of 2.1.2 (perhaps a configuration setting?)  with the fixes in 2.2.4 and on? My biggest concern at the moment is that I will be unable to use any future fixes due to being locked in on a lower version of Jackson that is incompatible with the newest releases.
Was the upgrade in Jackson necessary, or just to keep with the latest?

Have you tried latest Redisson with your Jackson version? I think it should work.

Have you tried latest Redisson with your Jackson version? I think it should work.

I tried, but it failed, let me try again to make sure i have the exclusions in the right places.

Yeah, try again please. And check you classpath for Jackson libs version mix, 2.4.x with 2.5.x, for example.

The application deployment is using shade, so it can't have multiple versions for the same library.

OK, got the exclusions setup correctly. (I was missing an exclusions for the yaml artifact) How can we address the connection problem @codenative mentioned?

@codenative which command execution mode do you use, asynchronous?

Synchronous

could you share your testcase?

I can reproduce the issue in 2.2.2 but it is working fine in 2.2.1 so it may be caused by changes in version 2.2.2.

I don't see in git history any changes of command execution logic between 2.2.1 and 2.2.2 versions

I have some ideas how connection pool could be improved. Some thinking is needed

@mrniko Okay. Thanks for your work btw, great client!

@mrniko, I second @codenative comment,  thanks for the wonderful support.

Thanks for you using and patience, guys!

I created this task for connection pool enhancements https://github.com/mrniko/redisson/issues/414. Please track it

@codenative hi! Could you please try to run your tests with version from cpv2 branch?

@mrniko I just tested with the same load as last time and it's working nicely without running out of connections. Great work!

@codenative there is a commands queue with size 3 elements for each channel. I'm just investigating which is better with queue or without it.

@mrniko I just tried to reproduce it with v2.2.8 and v2.2.9 and it's not having the same connection issue so I'm a bit stumped. We were able to reproduce the issue in multiple environments previously so I am not sure as to why it isn't doing it anymore. It could be an intermittent issue so I will keep an eye on it.

@codenative
The issue was introduced in 2.3.0 version and fixed in https://github.com/redisson/redisson/issues/2587


[infer] Goals and implementations discussion

This is a discussion issue about infer implementations in the context of Frictionless Data
infer is an operator that takes a set of values (or rows = arrays of values) and infers type information. Usually focus is basic types e.g. integer, number, string etc but it could be widened to semantics types.
def infer([value1, value2]):
    return  type   # or could be a set of probabilities for types

# can have a set of rows instead - where a row is a set of values
# this may be more complex than simply doing infer on each column if we believe there is a connection between columns
def infer([row1, row2]):
    # array of types corresponding to columns
    return  [types]

Example:
infer(['10', '12', '15', '2017']) => integer

infer(['1999', '2000', '2001', '2002']) => year

Tasks

[ ] Define needs
[ ] Research existing work including implementations with FD and outside

[ ] infer in tableschema-py, tableschema-js, tableschema-go etc

[ ] Test data
[ ] Outline Algorithms

Notes

casting and inferring have much in common
set of types would come from TableSchema or elsewhere
Need to think about Inclusions e.g. number is a refinement of integer
Handling Nulls: e.g. '-'
https://twitter.com/forestgregg/status/927938008497745926 - thread by

Semantic type inference
Originally this hackmd by @pwalsh : https://hackmd.io/KwIwHAzAjAbDAMBaATAY1ogLMzJEE4ATGfLMTbAQwFNV8ZQg?both
Context

https://twitter.com/forestgregg/status/927938008497745926
https://twitter.com/forestgregg/status/927940306347098112
https://twitter.com/forestgregg/status/929006770613379072
https://twitter.com/_pwalsh/status/929619554174754816

Frictionless Data
The Table Schema Frictionless Data libraries do some basic type inference. The Table Schema spec has "types" and "formats". The Python library infers types only, and the JavaScript library infers types and most formats too.

https://github.com/frictionlessdata/tableschema-js
https://github.com/frictionlessdata/tableschema-py

The algorithms are super simple.
Some of what is on offer here is part of what is referred to in the Twitter conversation. eg - inferring email addresses as a format of the string type (in Table Schema).
Use cases
Defining Dedupe Models
For dedupe users, making the data model for comparing records is their hardest task. For this task the user

needs to know what fields will be useful to compare
decide how to compare each of those fields

From our experience, a handful of types of information are very likely to be good candidates for
a dedupe data model -- names, postal addresses, email addresses. If we could infer the semantics of the field we could make good recommendations to the user for how to compare their data (both whicch fields to use and how to compare).
Related work
Schema matching
Last year DataMade wrote a whitepaper on the related problem of schema matching for columnar data. While the problems of semantic typing and schema matching are not the same, many of the techniques that could be used for schema matching can be used, to good effect, for semantic typing.

@roll @lauragift21 @lwinfree i feel this is the kind of thing that merits a page somewhere - in some sense it could go on specs as some kind of protocol (but don't think that is a great match) or it could on main site - maybe in the guide or even in its own page under "jobs". Any thoughts?

For me infer is more an internal thing (implementation details).
I would rather get back to the discussion of adding Data Quality Spec to the specs in some more general form than it is now

@roll it's partly implementation but i think it is actually something people need to do quite a bit and it would be nice to get the key analysis points recorded somewhere - maybe this should just move to the forum for now ...