fixed and verified OD calculation

To be consistent with how OD is calculated using the "interpolation" method, we have to rescale the cropped image to be range 0-1, float64, not inverted.
After doing this, I can verify by eye that the plots from the two approaches (interpolation and fit) are similar.  This verification was done only on April flu plates.  Please see data here for the debug outputs of that run:

The main point is that I'd prefer to use iinfo than a hardcoded number. If
you can work that in with using /= that's your call but not sure how that
will work with different types. I think the speed difference is minor in
the grand scheme of things.
On Thu, Apr 9, 2020 at 10:13 AM Bryant<EMAIL_ADDRESS>wrote:

@bryantChhun commented on this pull request.
In array_analyzer/workflows/registration_workflow.py
https://github.com/czbiohub/serology-COVID19/pull/38#discussion_r406353077
:

@@ -144,13 +144,13 @@ def point_registration(input_folder, output_folder, debug=False):
)

     # Estimate and remove background

   im_crop = im_crop.astype('float64')

   im_crop /= 255.0

Ok we'll have to change it to
im_crop = im_crop/np.iinfo(im_crop.dtype).max
The problem I had with /= 255.0 is that numpy will complain if the two
data types are different. But I always thought the /= is faster?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/czbiohub/serology-COVID19/pull/38#discussion_r406353077,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABT3MZPAA2UMZWNWPDEDAC3RLX627ANCNFSM4MEI6O2A
.

Looks good, I just have some minor suggestions.

Sorry.  Missed a few more of those "255" hardcoded locations.  They are updated now.  Should be good to go.


added mime parser debugger

new source file to run the mime parser against a single test file. This is done by a launch.json configuration. Also created a folder in testdata called events, in it I stored an event object that will allow our s3 code to run without deploying to lambda.

This pull request would pull all changes from your tap-ts-starter project (converted to an xml parser) into my main tap-ts-starter repo. I think you meant to just push certain changes that the two would have in common.


Generics: Cannot limit template param to specific types

Generics currently allow you to restrict the type of a template param to any type that extends some type, but as far as I know, there's no way to restrict the type of the template param to specific types.
For example, I'm trying to create a generic type where the template param is one of any specific type in a discriminated union, but the compiler doesn't treat the type as a discriminated union within generic code. Here's is a super simplified example:
interface Cat {
    type: "cat"
    meow(): void;
}

interface Fish {
    type: "fish"
    swim(): void;
}

// discriminated union
type Animal = Cat | Fish;

// template param should really be limited to exactly Animal (Cat or Fish)
interface AnimalWrapper<T extends Animal> {
    animal: T;
}

function foo<T extends Animal>(animalWrapper: AnimalWrapper<T>) {
    if (animalWrapper.animal.type === "cat") {
        // ERROR: Property 'meow' does not exist on type 'T'
        animalWrapper.animal.meow()
    } else {
        // ERROR: Property 'swim' does not exist on type 'T'
        animalWrapper.animal.swim()
    }
}

Is it reasonable to expect that my code example should work, and that this is a bug? Or is there some technicality about T extending Animal rather than being Animal that prevents the compiler from making the typical assumptions that would allow my code example to work?
On the surface, it's hard for me to imagine how anything could possibly extend animal, and have any value for type other than "cat" or "fish". Shouldn't the compiler be able to determine in my "if cat" statement that animalWrapper.animal is indeed something that extends Cat, and therefore must have the "meow" method?
Would it be reasonable to expand the syntax of Generics to be able to limit the template param to specific types? Here's what I imagine:
// "is" would indicate that "T" must be exactly one of the types in the "Animal" union
interface AnimalWrapper<T is Animal> {
    animal: T;
}

function foo<T is Animal>(animalWrapper: AnimalWrapper<T>) {
    // Now that "T" is limited specifically to Cat or Fish, the following code should be valid
    if (animalWrapper.animal.type === "cat") {
        // Compiler should now know BOTH:
        // 1) animalWrapper.animal is of type 'Cat'
        // 2) animalWrapper is of type AnimalWrapper<Cat>
        animalWrapper.animal.meow()
    } else {
        animalWrapper.animal.swim()
    }
}

Here is a workaround in the Playground: https://goo.gl/u3tUDW

@Proculopsis Your "foo" function is only working because it is not using the template type:
// The Template type 'T' is never used
function foo<T extends Animal>(animal: Animal) {
    if (isCat(animal)) {
        animal.meow()
    } else {
        animal.swim()
    }
}

If you change the method signature to animal: T, then you get a compiler error at animal.swim().

Here is another attempt in the Playground: https://goo.gl/grTLZ1
Sorry, I tried to simplify your example - the above implements AnimalWrapper and includes isFish() because the transpiler doesn't know that isCat()/else is exhaustive.

Yeah, I'm basically doing the same thing - using custom type guards to force the compiler to know what type it is wherever necessary.
One problem with this workaround is that you lose the ability to test against "never" to guarantee that all possible cases have been covered by the code:
/**
 * Use for compile-time validation that you have handles all possiblilities for
 * a value.
 * Throw the return value for error reporting in case an invalid
 * value from an external data source makes its way through at runtime.
 * @param value - The value that should never have a possible value/type at the
 *        point where this function is called.
 * @param name - A name for the value, used only for constructing the error
 *        message for the returned error.
 * @return an Error that you may choose to throw for runtime error reporting.
 */
function assertNever(value: never, name?: string): Error {
    return new Error(
        `${name || "value"} was expected to be "never",` +
        ` but it is "${value}" of type "${typeof value}"`
    );
}

function foo<T extends Animal>(animalWrapper: AnimalWrapper<T>) {
    console.log(animalWrapper);
    if (isCat(animalWrapper.animal)) {
        animalWrapper.animal.meow();
    } else if (isFish(animalWrapper.animal)) {
        animalWrapper.animal.swim();
    } else {
        // ERROR: Argument of type 'T' is not assignable to parameter of type 'never'.
        //              Type 'Animal' is not assignable to type 'never'.
        //              Type 'Cat' is not assignable to type 'never'.
        //
        // I expect it to compile because all possibilities are handled above.
        throw assertNever(animalWrapper.animal, "animalWrapper.animal");
    }
}

Would it be reasonable to expand the syntax of Generics to be able to limit the template param to specific types?

This is effectively what generics already are? There's another proposal floating around for upper-bounded generics which may be what you want, but it's hard to tell.
It's hard to speak to this issue specifically because the type parameter isn't really doing anything in the example. In most cases where you actually use the type parameter in a way that accomplishes something (correlating two parameters, two properties in the same parameter, or a parameter to a return type) it can be rewritten in a way that works the way you expect while still doing the right thing.
The salient thing to mention is that we can't safely say that the type of AnimalWrapper<T extends Animal>.animal is actually Cat! You could have an AnimalWrapper<FancyCat>, at which point it would be unsound to allow you to assign a non-Fancy cat to the .animal property.

@RyanCavanaugh Actual use cases I have are more complex and make use of the type parameter more extensively, but this example is simplified to point out specifically the issue I experienced with expecting the discriminated union type Animal to "work" as a type parameter, such that type narrowing would happen when testing the discriminator.
Your example of a FancyCat would have to be assignable to eiither Dog or Cat (probably Cat), so I would still expect the compiler to understand that if animalWrapper.animal.type === "cat", then animalWrapper.animal must have the properties defined in the Cat interface.

I see what you mean now about assigning a wrong type to animalWrapper.animal.
I think this is part of why I was suggesting some way to limit the generic type param to EXACTLY the Animal type union, rather than anything that is assignable to Animal. But I understand that everything in the type system is about assignability of "shapes" of types, rather that exact types themselves, so that's probably never going to happen.
So maybe ignore my suggested solution and just look at my problem: why can't the compiler figure out that that the meow() method exists on animalWrapper.animal the type after testing that animalWrapper.animal.type === "cat"? Can this problem be solved somehow within the design of the type system?

@UselessPickles a bit of a late reply, but recently I came across a very similar problem, and someone suggested doing this, whenever the TS compiler can't distinguish between union-types -- worked like a charm for me:
(animalWrapper.animal as Cat).meow()
(animalWrapper.animal as Fish).swim()


[Bug] Unable to disable tint completely

For some reason some shader packs interact with the tint strangely resulting in a very dim background while loading, could there be a toggle to disable tint completely? (Setting strength to 0.0 does not work, maybe it's not the tint at all?)

For some reason some shader packs interact with the tint strangely resulting in a very dim background while loading, Could there be a toggle to disable tint completely? (Setting strength to 0.0 does not work, maybe it's not the tint at all?)

Uhh, I have no issue with disabling the tint altogether in dev env by setting it to 0.0 strength so what version are you using exactly? Is it the 1.19.2 version?

https://modrinth.com/shader/makeup-ultra-fast-shaders for the shaders
https://modrinth.com/mod/iris using iris
and Seamless Loading Screen 2.0.2 1.19.2

I'll do some testing later but it could just be an issue for my modpack, I can say when the shader is disabled and tint is set to 0.0 theres no dark background at all, but when the shader is enabled the background remains dark no matter the tint level.

Shader on and tint 0.0

Shader off and tint 0.0

I guess it is also worth mentioning that it stays dark with shaders disabled until you enter and save the game then enter again, so it could be how the screenshot is captured? I have no clue.. I wouldn't blame you if you closed this issue though as shader's are kind of outside the scope of fixing probably.

Hmm seems similar to another issue with the Shader https://github.com/javiergcim/MakeUpUltraFast/issues/62 but I tested with Complementary Reimagined without issue so maybe the specific Shader Pack.
It seems to happen on Screenshot Capture actually leading to a completely blacked-out image... meaning such has nothing to do with tint but something to do with the Screenshot capture being nothing.

I frankly don't have a clue what is going on and don't think this is something that will be easily fixed to say the least

Turning on the Simpler Exposure Option just fixes the issue...?

Turning on the Simpler Exposure Option just fixes the issue... for some reason.

For some reason it doesn't fix the issue for me, how strange.. May be a weird cause..

... Odd, I will need to take some time and maybe talk with IMS about what might be causing this within Iris

... Odd, I will need to take some time and maybe talk with IMS about what might be causing this within Iris

Disregard my last comment I thought this was another issue, that actually fixes it, super sorry about that I've been a little sleep deprived..

Turning on the Simpler Exposure Option just fixes the issue... for some reason.

I think this is an issue with the exposure part of the shaders and not an issue with this mod, so you can close this if you want, or poke them about how it works

Ill keep such open but doubtful a fix will be needed on our end at the moment


iRODS collections creation fails with CAT_INVALID_USER

A user has reported a case where iRODS collection creation fails with the iRODS invalid user error:
Error running flow: SetAccessTask failed: CAT_INVALID_USER (omics_project_xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx)

We should be creating the user group if it doesn't exist, but apparently that hasn't happened in this case for whatever reason. I can confirm that the user group indeed does not exist on the production iRODS server.
I can also reproduce this on a new project on the production server. The weird part is that locally this works just fine. Some deployment config problem maybe?
EDIT: Upon closer inspection, it seems the project_create flow is not run at all on the server when a new project is created. This is bad. Looking into why.

Turns out this was a case of "braindead developer". The Django settings for PROJECTROLES_ENABLE_MODIFY_API and PROJECTROLES_MODIFY_API_APPS were not correctly set in the production config, causing the API to never call the creation actions. Now fixed.


ArcCell to accept ?Sized.

It seems to me that since it uses Arc underneath, Sized is not required and was added implicitly.

It is required, because an Arc containing an unsized value takes up two words (the data pointer and the slice length or trait vtable pointer) and therefore doesn't fit in an AtomicUsize.

Oh. Ok then. Thank you. :)


Add virtualenv instructions as alternate to Vagrant and clean up a co…

…uple little things in the Vagrant instructions

Thanks for this @ndintenfass !


Eject Web3Torrent for CRA

Eject Web3Torrent from CRA to allow us to customize our config as we see fit.

I'm not so opinionated about this that we should not merge it, I don't mind. I'm just a little traumatized from subtle code compilation bugs.

The main criticism I have is that this introduces an enormous amount of extra boilerplate and configuration to the codebase, most of which I suspect is copied from somewhere else. I doubt we need every single one of these files checked in, and there probably exists some sane defaults in most places where new code has been introduced that we could use.
There exists this thing called react-app-rewired that seems to be the intended technology for this scenario of wanting to edit webpack configs without ejecting. It is probably frustrating that I just found out this exists right now.
Overall I would just be strongly in favour of trying to remove as much extra boilerplate as possible.

This is all the code hidden in CreateReactApp that gets generated by yarn eject. I originally looked at react-app-rewired but decided  that doing a project eject would be nicer as we could finally own the various configs and we would avoid some hacks like writing out to a .env.local to set contract addresses.
I agree that all the boilerplate is a bit awful (and a reason I don't love using CRA, there's a lot of complexity in there). I think we should work to reduce that but I'd prefer to do that outside the scope of this PR.


write error when handle gRPC request using http2 manager

What this PR does:
write error when handle gRPC request using http2 manager

Codecov Report

Merging #372 (5babcbd) into develop-0.5.0 (44f09ad) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           develop-0.5.0     #372   +/-   ##
==============================================
  Coverage          39.66%   39.66%
==============================================
  Files                 52       52
  Lines               3061     3061
==============================================
  Hits                1214     1214
  Misses              1717     1717
  Partials             130      130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f09ad...5babcbd. Read the comment docs.


sunIsUp() for given date

According to the readme

You can get determine if the sun is up at a specific moment by passing in instance of Carbon\Carbon to sunIsUp

But in the code, this function only checks if the current date Carbon::now() is between the sunrise and sunset of the passed date
It should check if the passed date is between that days sunrise/sunset, shouldn't it?

Thanks for reporting this. It is fixed in the latest release.


Block production can fail when eth1 deposits are not current

ERROR | BeaconRestApi | Failed to process request to URL ..../eth/v2/validator/blocks/....
tech.pegasys.teku.validator.coordinator.MissingDepositsException: Unable to create block because ETH1 deposits are not available. Missing deposits 410438 to 410582

In this case, we've failed with 500 with full stack trace.
What'd be nice is if GetNewBlock fails (v2 only is fine), and the exception is a MissingDepositsException, we should pass back the error message, still as a 500 error, and we won't need to fall through to the default exception handler and print the stack trace.
This will give the user a lot more context about what may be going wrong.

Can I take this?

@sragss Yep, happy for you to take a look at this.  Give us a yell either here or in Discord (https://discord.gg/7hPv2T6 in the #teku channel) if you have any questions. And it's always helpful to put work up as a draft as early as possible to get feedback on the general direction even if you know there's more stuff to work on.

Assigned to me so no one else takes it - apparently can't assign it to you directly.

Thanks! Is the idea here to catch this at the request handler level as follows?
  @Override
  public void handleRequest(RestApiRequest request) throws JsonProcessingException {
    final UInt64 slot =
        request.getPathParameter(SLOT_PARAMETER.withDescription(SLOT_PATH_DESCRIPTION));
    final BLSSignature randao = request.getQueryParameter(RANDAO_PARAMETER);
    final Optional<Bytes32> graffiti = request.getOptionalQueryParameter(GRAFFITI_PARAMETER);
    final SafeFuture<Optional<BeaconBlock>> result =
        provider.getUnsignedBeaconBlockAtSlot(slot, randao, graffiti, false);
    request.respondAsync(
        result
            .thenApply(
                maybeBlock ->
                    maybeBlock
                        .map(AsyncApiResponse::respondOk)
                        .orElseThrow(ChainDataUnavailableException::new))
            .exceptionally(
                err -> {
                  if (err.getCause() instanceof MissingDepositsException) {
                    return AsyncApiResponse.respondWithError(
                        SC_INTERNAL_SERVER_ERROR, err.getCause().getMessage());
                  } else {
                    // Fall through to default exception handler
                    throw (RuntimeException) err;
                  }
                }));
  }

Or should this be done at the DefaultExceptionHandler level? Are there some similar examples that someone can point to?
I notice that other error types such as ServiceUnavailableException and ChainDataUnavailableException do not long stack traces but don't see where that is implemented.

Let me know if we should also check that it is a GetNewBlock call.


[Feature_Request] Class based Sampler for Class Incremental/Continual Learning research

For class incremental learning regime, splitting datasets on the basis of classes is a requirement and currently there isn't any class based sampler which returns a subset of the dataset with specific classes in it be it randomized samples or not for those specific classes. I would like to add a new sampler which randomizes the samples from specific classes and returns the subset. Kindly provide some insight on this.

Oops! I was supposed to open this issue in the torch repository. Closing this. I apologize!


Error inserting JSON column

HI!
First of all, thanks for this library it has been really useful for me!
I'm opening an issue because I'm getting in trouble when I try to insert a POJO which contains a JSON field/cloumn.
If I try to insert a field which contains the JSON string : "{"customer_name": "John"}" i get the following error :
de.bytefish.pgbulkinsert.exceptions.BinaryWriteFailedException: java.io.IOException: Ending write to copy failed.
at de.bytefish.pgbulkinsert.pgsql.PgBinaryWriter.close(PgBinaryWriter.java:163)
at de.bytefish.pgbulkinsert.PgBulkInsert.saveAll(PgBulkInsert.java:80)
at com.gindumac.mis.normalization.core.sink.PostgresSink.bulkStore(PostgresSink.java:41)
... 1 more
Caused by: java.io.IOException: Ending write to copy failed.
at org.postgresql.copy.PGCopyOutputStream.close(PGCopyOutputStream.java:107)
at java.io.FilterOutputStream.close(FilterOutputStream.java:159)
at java.io.FilterOutputStream.close(FilterOutputStream.java:159)
at de.bytefish.pgbulkinsert.pgsql.PgBinaryWriter.close(PgBinaryWriter.java:161)
... 3 more
Caused by: org.postgresql.util.PSQLException: ERROR: invalid input syntax for type json
Detail: Token "" is invalid.
Where: JSON data, line 1: ...
COPY test, line 1, column json
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2440)
at org.postgresql.core.v3.QueryExecutorImpl.processCopyResults(QueryExecutorImpl.java:1116)
at org.postgresql.core.v3.QueryExecutorImpl.endCopy(QueryExecutorImpl.java:965)
at org.postgresql.core.v3.CopyInImpl.endCopy(CopyInImpl.java:45)
at org.postgresql.copy.PGCopyOutputStream.endCopy(PGCopyOutputStream.java:168)
at org.postgresql.copy.PGCopyOutputStream.close(PGCopyOutputStream.java:105)
... 6 more
However, if I change the previous String by a null the insert finishes successfully (And I can se a null value in my table)
I'm using PostgreSQL 9.6.6 on AWS RDS.
Do you have any clue of what the error cause might be?
Thanks!

Thanks for the bug report! Actually I think it is related to this: https://dba.stackexchange.com/a/156383. Basically you need to Escape the JSON before writing it. I will see what's the simplest way in Java. I label it as not a Bug, because it is a requirement imposed by Postgres, but I leave it open and we find a workaround! 😎

Thanks for trying it! 🤜🤛 I will write a unit test first and then try to fix it. Don't know for sure, if I manage to today. Please hold on! 😌

@B87 Did you also create the column as a JSONB Column? Because the Mapping maps to a JSONB column: https://github.com/bytefish/PgBulkInsert/blob/master/PgBulkInsert/src/main/java/de/bytefish/pgbulkinsert/mapping/AbstractMapping.java#L178.

Yep that's my problem.... I was creating the column as a json, jsonb is fine so I'm happy with it.
Thanks for your time and help!


Alternative way to do opentok on iOS

Feature Request
Description
The cordova opentok project is really quite rough around the edges and does not integrate with the opentok-layout-js library.
Proposal
I am wondering if it is possible or better to simply shim the webrtc API from cordova-plugin-iosrtc
And then use the web opentok library with a wrapper library for any compatibility issues?
Links / references
https://github.com/BasqueVoIPMafia/cordova-plugin-iosrtc

@Anthonyzou One of the TokBoxers in the past tried this approach, but had difficulty getting it working effectively with the JS SDK: https://github.com/aoberoi/cordova-plugin-opentokjs
This plugin uses the OpenTok iOS and Android SDK while the opentok-layout-js package was made for the JavaScript SDK.
One of our open source contributors, @wolfenrain, is working on a layout manager something for the Cordova plugin.

Closed by accident, but would love to hear your thoughts! @Anthonyzou

Ah I see.
I am also having difficulties.
But they don't seem like major changes that need to be done. It just seems like there is a little incompatibility with the data from MediaDevices.getUserMedia, from cordova-plugin-iosrtc


Boss talk

Description
This update includes several changes aimed at improving the testing suite for the NPC components of the project. The key changes are as follows:

Added Basic NPCConfigsTest: Introduced a new test class to validate the configuration of NPCs.
Removed MapFactoryTest: Deleted a test that lacked a class (MapFactory doesnt exist anymore), ensuring clarity and relevance in the test suite.
Fixed WeaponFactoryTest: Addressed issues in the previously commented-out WeaponFactoryTest to ensure its functionality (Minor changes).
Added Test Case for NPCDeathHandler: Developed a basic test case for the NPCDeathHandler to verify its behavior and correctness.

These changes are motivated by the need to enhance code reliability and ensure comprehensive testing coverage for NPC functionalities.
Fixes / Closes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
The following tests were executed to verify the changes:

Basic NPCConfigsTest: Verified the NPC configurations.
NPCDeathHandler Test: Checked the NPC death handling functionality.

Please follow these steps to reproduce the tests:

Run the entire test suite using the command: ./gradlew test.
Ensure that all tests, including the newly added ones, pass without issues.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Adjusted Accordingly


question about MELODY

Hi, @RetroCirce. Thank you for your great work.
I have a question about "MELODY: the lead (vocal) melody transcription" described in 3.2 in the paper. How do you extract the lead (vocal) melody of the music. And how do you do vocal melody transcription when there are vocals in the music.
Thank you.

Hi, as mentioned in our paper. Pop909’s vocal melody is extracted by human. We hire musicians and composers to give the expert label for the melody.


Remove Entity from components

About the PR
Gets rid of Entity<SolutionComponent> from all components. Storing Entity in components breaks serialization, and it was redundant because they all store the solution name anyway which is all that's needed to get the solution.
Breaking changes
Entity<SolutionComponent> has been removed from all components. If your code used ResolveSolution(uid, comp.SolutionName, ref comp.Solution) you need to change it to TryGetSolution(uid, comp.SolutionName, out var solutionEnt)

imo Entity should be fixed to serialize properly (just write the uid and when reading resolve the component)

imo Entity should be fixed to serialize properly (just write the uid and when reading resolve the component)

Perhaps, but all these components store the solution name anyway, so it's redundant to store a nullable solution entity as well.

imo Entity should be fixed to serialize properly (just write the uid and when reading resolve the component)

This isn't happening.


Order update emails not being sent in version 2.9.0

Order update emails including refund notifications do not appear to be sent to the customer, only to the admin copy email address.  I have "Customers receive order status update email (deprecated)." set to "No" as instructed by Adyen helpdesk.

Hi @hughconway,
What do you want to achieve ?
Regards,
Rik
Adyen

I would like customers to recieve updates when I manually change the status of an order but not when it is an automatic system change such as moving from 'payment review' to 'processing'.

Hi @hughconway,
I think if you create a manual comment history you can define if it will send out an mail to the customer. I don't think this has anything todo with our payments module.
Regards,
Rik
Adyen


Fix checking empty string.

If string is "0,1,2,3" result is "01,2,3"
empty($row[$fieldname]) return true if $row[$fieldname] is "0"

@kekek2 thanks


fix the CardMatcher for Defensive Debris

It seems the change to CardMatcher that i reverted in this commit https://github.com/throneteki-playtesting/throneteki/commit/a718344009b3833d80413952e81f6b8b7e6fe301 broke multiple tests, which is weird.
we will have to have another look at that change and Defensive Debris, which introduced this change

Fixed in 2ed044265139638e309eec578c9c389667cc2e4d


"in treatment" contains "intensive care" ?

Just to be sure on this
Doer the "in treatment" numbers contain the "intensive care"?
There might be a clarification comment regarding this somewhere on the page

It should include it, that is how terviseamet writes it in press release at least.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Tõnis Ormisson<EMAIL_ADDRESS>Sent: Friday, April 17, 2020 12:52:16 PM
To: okestonia/koroonakaart<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [okestonia/koroonakaart] "in treatment" contains "intensive care" ? (#111)
Just to be sure on this
Doer the "in treatment" numbers contain the "intensive care"?
There might be a clarification comment regarding this somewhere on the page
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/okestonia/koroonakaart/issues/111, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE7MKRZEKD7MLIPY3QYENZLRNARFBANCNFSM4MKTOVZQ.


Wrong behaviour of checkboxes in Settings UI when the name of the setting starts with the name of another setting

Does this issue occur when all extensions are disabled?: No (as it is related to extension settings)

VS Code Version: Version: 1.83.1 (user setup)
OS Version: Microsoft Windows [Version 10.0.19045.3636]

Steps to Reproduce:

Install one extension with boolean settings whose name (e.g.: "foo.bar.baz") start with another setting name (e.g.: "foo.bar")
Open Settings UI
Scroll the checkbox for the "foo.bar.baz" setting in and out of the view.
The checkbox is shown as checked or unchecked randomly, instead of showing the value of the property (expected behaviour)

Also:

Click the checkbox for the "foo.bar.baz" setting.
Other checkboxes get checked/unchecked at the same time.

A video of the issue in a real life extension: https://github.com/theNestruo/z80-asm-meter-vscode/issues/150#issuecomment-1784626152
A minimal extension that can be used to reproduce the issue: https://github.com/theNestruo/settingsui-checkbox-issues-vscode

Settings where the name of one starts with the name of another aren't supported at this time.
Duplicate of #176373


WIP: Adds -Credential parameter and Truncate Warning

Closes #13 and #14

[ ] Update documentation for -Credential.
[ ] Test a643c271d547d9dbfa5cf9260e161fd5c71bf467 in multi-domain environment.

@PoshAJ -Credential can only be used with -Server ? Is that correct ?

@PoshAJ -Credential can only be used with -Server ? Is that correct ?

Yes, as it's currently designed. We could support it separately, but it's probably fine to require -Server.

@PoshAJ -Credential can only be used with -Server ? Is that correct ?

Yes, as it's currently designed. We could support it separately, but it's probably fine to require -Server.

Ahhh because of the overloads, didn't check them 😅 Perhaps we should add a parameter set for -Credential only when -Server is used

@PoshAJ -Credential can only be used with -Server ? Is that correct ?

Yes, as it's currently designed. We could support it separately, but it's probably fine to require -Server.

Ahhh because of the overloads, didn't check them 😅 Perhaps we should add a parameter set for -Credential only when -Server is used

Yeah, we can go a couple ways with this one?

Parameter Sets
Dynamic Parameter
Support -Credential without -Server


[PE-D][Tester D] Command Summary of UG needs command formats

The addnote, editnote, deletenote, add-p, edit-p, and delete-p commands all have example usages provided, but no command format. To be specific, a command format would explain what the integers mean e.g., instead of deletenote 1 1 it would be deletenote COMPANY_INDEX NOTE_INDEX.

Labels: type.DocumentationBug severity.Low
original: chengjunyuan/ped#8

fixed in #73


Migrate to the latest version of canvas

Migrate to the latest canvas version

[x] Upgrade @elyra/canvas (from 6.1.23 to 8.0.32)
[x] Resolve breaking changes
[x] Clean-up the UI
[x] Verify ui tests
[x] Update documentation screenshots
Confirm canvas upgrade fixes issues:

[ ] #750 (part 2) // resolved in canvas 9.0.1
[x] icon svg support
[x] #386

Merge (upcoming) Pipeline editor PRs:

[x] #741
#744 // will be merged after this PR
[x] #750 (part 1)
#752 // may be merged after this PR

Changes

per @elyra/canvas release 7.0.5

Updated dependency react-intl (^3.0.0)
Added dependency react-redux (^7.0.0)

per @elyra/canvas release 8.0.1

Updated CSS class names and styling
Placed <CommonCanvas> inside a <IntlProvider>
Removed toolbarMenuActionHandler. Handling of these actions moved to the editActionHandler
Removed contextMenuActionHandler. Handling of these actions moved to the editActionHandler.
Renamed addComment action to createAutoComment
Renamed delete action to deleteSelectedObjects

per @elyra/canvas release 8.0.2

Added config createSupernode // user can disable creation of supernodes via configuration parameter

per @elyra/canvas release 8.0.4

Added config enableInsertNodeDroppedOnLink // user can drag nodes from the palette and drop them onto existing links in the flow which causes the node to be inserted between the two nodes joined by the link

Update screenshots in documentation

Fixes #645
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

all the major work is dont here and it is basically ready for reviews.
what left is to merge with #744 and #752 once those are ready.
the second part of #750 cannot be confirmed as it was addressed in canvas yesterday and won't be available until next canvas release.

Just tried this out locally and it looks great! So sleek! For those who don't have time to check out the PR locally this is what the new canvas looks like:

As for #744, I think actually it might be a good idea to merge this PR first, because I think there's a handler in the newer version of canvas that would simplify that PR (beforeEditActionHandler).
We'll also need to change the pipeline documentation images to use the new interface.

Just tried this out locally and it looks great! So sleek! For those who don't have time to check out the PR locally this is what the new canvas looks like:
As for #744, I think actually it might be a good idea to merge this PR first, because I think there's a handler in the newer version of canvas that would simplify that PR (beforeEditActionHandler).
We'll also need to update the pipeline documentation images to use the new interface.

thanks for the reminder. i'll update to documentation images. this can be merged first if it is going to simplify #744

this PR is good to go for @elyra/canvas v8.0.32.
however, v9 has just been published. i will upgrade to v9 instead and resolve any issues that may arise.

@vabarbosa Also, feel free to merge this before #752 merges as well and I can rebase. It seems like there's more to discuss on that PR than there is here.

I'll be reviewing this early this afternoon, will post code and UX reviews as I finish each

Code and UX LGTM but I found some UI issues on Safari (surprise surprise Safari again >.<). I've attached screen shots of the oddities below:
As you can see some of the borders and mouse over are missing or misaligned. No idea why it is like this on Safari and not Chrome.

thanks, Safari discrepancies should be resolved.


Route Logs

Hello, how can i get a log when users login or access pages or activity via web routes

https://spatie.be/docs/laravel-activitylog/v4/basic-usage/logging-activity

Hello, am asking about how can you records the route logs ?
Example user login or user visit a pages

With that method how and wherever you want. In a middleware, controller, event listener ...
There's no special "log every route/http call" logic. So you have to build it your own with the activity logger.


fix: fixing bug with cfg loading for fine-tuning

Description
When saving a SAE checkpoint, we save the full LM runner config instead of just the SAE config. This config is superset of the SAE config, but since there are extra keys in the LM runner config this was causing loading to break when trying to fine-tune. This PR fixes the issue by filtering out any keys from the loaded config dict which aren't present in the SAE config when loading from dict.
Fixes #227
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

[x] I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

Thanks! Amazing work!


Include category names in the repo

Searching the code, I can't find any reference to the current list of categories shown in the sidebar:
Administrators
Editors
Marketing & Sales
Designers
Managers
Testers
Consultants
Programmers
Researchers
Translators
Support

There's a list in db/jobberbase.sql:
INSERT INTO `categories` (`id`, `name`, `var_name`, `category_order`) VALUES
(1, 'Programmers', 'programmers', 7),
(2, 'Designers', 'designers', 3),
(3, 'Administrators', 'administrators', 0),
(7, 'Marketers', 'marketers', 2),
(5, 'Testers', 'testers', 5),
(6, 'Editors', 'editors', 1),
(8, 'Managers', 'managers', 4),
(9, 'Consultants', 'consultants', 6);

But they don't match the actual labels used on the site. "Marketers" is actually labeled "Marketing & Sales", and there are three more categories on the site that are not present in the .sql file: "Researchers", "Translators" and "Support".
Should the jobberbase.sql file be synced with the actual database used on the site? Or is there another way to resolve this issue?
ps - I'm opening this because I want to propose renaming the "Editors" category to "Writers & Editors", but found no way to contribute that change.

By the way, it's also unclear how "Administrators" differs from "Managers". Perhaps "Administrative assistants" would be clearer? Or simply "Assistants"?

Yeah, true, the database is not currently synced. The jobberbase.sql is an initial import, and the customization happens "later". Before we figure out how to best keep it in sync it would be nice to at least do backups of the running database in the first place... ;) I now changed "Editors" to "Writers & Editors" as you proposed via the admin web panel.
I agree that it is difficult to cleanly specify categories. For me, "Managers" are responsible to manage certain aspects of the project, and "Administrators" are doing backend stuff like financial aspects, paperwork etc. -- maybe more of a more specific type of "Manager" then. "Administrators" is also confusing many since they hear "(System) Administrators", sysops.
I would not mind changing the categories, as you can see we only did very small changes from the initial set proposed by Jobberbase, but "Assistants" sounds even more generic and "low hierarchy", and for me it would not clarify anything. It will always be difficult to accommodate all the different organizational structures and preferences of FOSS projects: Many community projects would argue that there is no "management" but "Managers" are actually "Assistants dealing with the boring stuff", or "Coordinators".
From what I can see it is most common to separate the roles dealing with the financial and legal aspects, which I would summarize as "Administrative", from everything else.

I agree with your points. "Administratives" would work well IMO, in place of "Administrators". That would make the "Manager" category non-confusing as far as I'm concerned, so it could be left as it is. Organizations who prefer emphasizing the servant role of managers can always categorize them under the Administratives category :)


[fixme] we should fix this to make it less racy in testing

https://github.com/bacalhau-project/bacalhau/blob/db7f6410d8b8f325bc2f2dd188366caef99b3c88/pkg/node/node.go#L279

no longer using node info publisher after nats


Check how to support sync functions with cached and multi_cached

using iscoroutinefunction would be a way but need to write 2 wrappers. In the sync wrapper case it could be that we are caching a sync function but we are still running in the context of asyncio. Having in the sync wrapper the asynchronous cache.get running with the loop.run_until_complete will make it crash...
Closing this for now since I can't find a way to work around that


CREO2URDF – MVP-2

We will focus on one single iCub/ergoCub mechanism. For example, we could address the case of the head + neck.

Closing since the mvp2 has been achieved in https://github.com/icub-tech-iit/creo2urdf/issues/28


Python 3.x support

regex4dummies needs to be compatible with Python 3.x, not just 2.7. This will allow a much wider audience to use and take advantage of regex4dummies.

This is very complicated and will require dependencies be updated to support Python 3.x. For this reason, I am removing the milestone until further notice.


Add pyarrow.json import

pyarrow.json needs explicit import otherwise:
Traceback (most recent call last):
  File "/workspace/relbench/examples/gnn_link.py", line 65, in <module>
    dataset.get_db(),
  File "/usr/local/lib/python3.10/dist-packages/relbench/data/dataset.py", line 69, in get_db
    db = self.make_db()
  File "/usr/local/lib/python3.10/dist-packages/relbench/datasets/amazon.py", line 50, in make_db
    ptable = pa.json.read_json(
  File "/usr/local/lib/python3.10/dist-packages/pyarrow/__init__.py", line 317, in __getattr__
    raise AttributeError(
AttributeError: module 'pyarrow' has no attribute 'json'

Yep, thanks, had been meaning to do this!

Already took care of this while refactoring.


Hangup timeout handling

Reset the RtpDatagramProtocol addr attribute to None on disconnect. This will make sure the RTP port gets properly set for subsequent calls after hanging up.

Thanks! Closing this in favor of: https://github.com/home-assistant-libs/voip-utils/commit/5472d4c62ecf852cc3d96e2cc02be31151c75eb4


ToggleButton - add HTMLButton props such as name and value

🙋 Feature Request
It would be helpful to be able to be able to use props available on button such as name, and value. The type prop is already supported.
That way the button values are included when the form is submitted.
Alternatively, allow the spreading of arbitrary props into the component. That would enable wrapping the React-Aria-Components with new props supported in the underlying HTML element and or passed as RenderProps.
🤔 Expected Behavior
Add the following:
<ToggleButton name="foo" value="bar" >List</ToggleButton>

<button name="foo" value="bar">List</button>

😯 Current Behavior
Button props are excluded from being rendered.
💁 Possible Solution
export interface ToggleButtonProps extends Omit<AriaToggleButtonProps, "children" | "elementType">,
    SlotProps,
    RenderProps<ToggleButtonRenderProps> {
  /**
   * The name of the button, submitted as a pair with the button's value as part of the form data, when that button is used to submit the form.
   */
  name?: string;
  /**
   * Defines the value associated with the button's name when it's submitted with the form data. This value is passed to the server in params when the form is submitted using this button.
   */
  value?: string;
}
...

🔦 Context
Being able to use Toggle buttons as regular button and inputs able to capture state is helpful.
💻 Examples
One example is a set of toggles to convert a UI from grid view to a list view, etc. Similar to how Finder in macOS enables the switching. Submitting the form to a server or in an SPA using the form data values to determine the user selection.
🧢 Your Company/Team
Considering using react-aria-components for products. React-Aria is a very impressive project and this would reduce a lot of boiler plate and reimplementing many of the patterns already in the examples.

In a similar vein to https://github.com/adobe/react-spectrum/issues/4377, I'll close this in favor of that issue.

@LFDanLu Thanks for the quick response. Sounds good. Same problem, and perhaps one that all ButtonBaseProps can define or allow for extension of custom attributes.


Author names are completely misleading

GitLens Version: 10.2.1 (VS marketplace version)

VSCode Version: 1.36.0
OS Version: Windows_NT x64 10.0.17763

Result expected:

gitLens-text-hint in grey
Gitlens should display the correct Author Name and created time next to the code. Example:
"You, 2 months ago"
gitLens-dialogue-box
Gitlens should display the correct Author Name and created time in the dialogue box once you hover your mouse over the gitLens-text-hint in grey.

Actual result:

Gitlens is showing the name of another repository member instead of 'You', even if you are the original inventor of this line of code. Please refer to the picture below:

Steps to Reproduce: (let's say there is a file, say gitLens.vue, created by John Smith)
Step 1. Press ctrl-C to copy the entire file.
Step 2. Delete 98% of the contents in the file (gitLens.vue) and create a new commit, say commit id = 'aa3efe'
Step 3. Paste in the original content to gitLens.vue, save it and commit the change. Let's say the commit id = 'ff553e3'
Now every single line of code in gitLens.vue (commit id =ff553e3) will show 'You' as the author instead of 'John Smith'.
Your repository members can steal your authorship by similar code manipulation.
This bug renders the value of GitLens to ZERO, as GitLens is supposed to be a software to reflect the original copyright of the intellectual property of the true inventor of a line of code/algorithm.

I'm not sure what you are really looking for here -- but this is how Git works. You can always keep going back in history to see who the original author was.


Open Payment Journal from bank account

Hello
We need some extra functions on page 2000001 "EB Payment Journal" in order to properly open it from other pages.
We use the following function which is called from the bank account list and card.
There is a template for each bank account, a template can have multiple batches but he last one should be used.
`
#region PSIBOpenPaymentJournal
procedure PSIBOpenPaymentJournal();
var
PayJnlLineTemplate: Record "Payment Journal Template";
PaymentJournalLine: Record "Payment Journal Line";
PayJnlBatch: Record "Paym. Journal Batch";
EBPaymentJournal: Page "EB Payment Journal";
begin
PayJnlLineTemplate.SetRange("Bank Account", Rec."No.");
PayJnlLineTemplate.FindFirst();
PayJnlBatch.SetRange("Journal Template Name", PayJnlLineTemplate.Name);
PayJnlBatch.FindLast();
    PaymentJournalLine.SetRange("Journal Template Name", PayJnlLineTemplate.Name);
    PaymentJournalLine."Journal Batch Name" := PayJnlBatch.Name;
    EBPaymentJournal.SetTableView(PaymentJournalLine);
    EBPaymentJournal.SetRecord(PaymentJournalLine);
    EBPaymentJournal.Run();
end;
#endregion PSIBOpenPaymentJournal

`
This type of algorithm usually works for opening other journals but for some reason it doesn't work for the EB Payment Journal.

Opens:

The values used for the template name and bank account are the last values you entered before closing the page (I cannot find any code that explains this behaviour). All of the other global variables used to control this page are correct, except for these 2.
On the page these are defined as the CurrentJnlBatchName and BankAccountCodeFilter variables.
It seems like these variables are impossible to control via extensions. The OnOpenPage trigger uses the CurrentJnlBatchName, when I try to debug, the value of this variable is as expected but when the page opens, a different value is shown.
We require a function to open the journal but also control these 2 variables (and the logic behind the onvalidate trigger)
Thank you in advance.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Don't return unapproved entries in search results

Reason:

MAL seems to get a lot of entries that are unapproved and are actively being added/removed.
creates a lot of inconsistency and anime/manga sweepers can't keep up with this.
creates bad quality responses for query related endpoints (Search, Schedules, Seasons, etc)

Thus;

All search results will now exclude unapproved entries by default
User can pass unapproved in query to include said entries

Resolved with https://github.com/jikan-me/jikan-rest/pull/346


Us 1128025

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Exchange-Deployments-2013/configure-document-collaboration-with-onedrive-for-business-and-exchange-2016-on-premises-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/configure-exchange-2013-public-folders-for-a-hybrid-deployment-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/configure-exchange-online-public-folders-for-a-hybrid-deployment-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/configure-legacy-on-premises-public-folders-for-a-hybrid-deployment-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/exchange-server-hybrid-deployments-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/how-and-when-to-decommission-your-on-premises-exchange-servers-in-a-hybrid-deployment-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/hybrid-deployment-prerequisites-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/irm-in-exchange-hybrid-deployments-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/simplify-the-outlook-web-app-url-for-office-365-hybrid-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/transport-routing-in-exchange-2013-exchange-2007-hybrid-deployments-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/transport-routing-in-exchange-2013-exchange-2010-hybrid-deployments-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/transport-routing-in-exchange-hybrid-deployments-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Deployments-2013/troubleshoot-a-hybrid-deployment-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/about-exchange-documentation-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/accepted-domains-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/access-control-list-acl-inheritance-is-blocked-inhblockpublicfoldertree-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/access-to-active-directory-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/accessibility-for-people-with-disabilities-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/accessing-public-folders-with-outlook-2016-for-mac-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/account-setup-in-outlook-for-ios-and-android-using-basic-authentication-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/activate-a-lagged-mailbox-database-copy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/activate-a-mailbox-database-copy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-directory-does-not-exist-or-cannot-be-contacted-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-directory-domain-is-mixed-mode-localdomainmodemixed-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-directory-domain-is-mixed-mode-preparedomainmodemixed-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-directory-domain-is-mixed-mode-rootdomainmodemixed-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-directory-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-directory-functional-level-isn-t-windows-server-2003-or-later-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-directory-permissions-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/active-manager-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/ad-lds-directory-exists-in-default-location-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-a-mailbox-database-copy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-a-role-entry-to-a-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-a-role-entry-to-an-unscoped-top-level-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-a-role-to-a-user-or-usg-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-a-sip-address-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-an-address-list-to-or-remove-an-address-list-from-an-offline-address-book-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-an-auto-attendant-extension-number-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-an-e-164-number-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-an-extension-number-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-ins-for-outlook-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-mailbox-and-client-access-servers-to-a-sip-uri-dial-plan-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-or-remove-email-addresses-for-a-mailbox-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-or-remove-users-from-a-mobile-mailbox-policy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-retention-tags-to-or-remove-retention-tags-from-a-retention-policy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-the-federation-mailbox-to-the-ad-rms-super-users-group-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/address-book-policies-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/address-book-policy-procedures-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/address-list-procedures-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/address-lists-exchange-2013-help.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Clair connection issues in Ubuntu16

I have has issue with clair, the logs are below:
2018/02/20 17:04:21 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 <nil>}
I have looked around and tried several recommended fixes  without any success !!
My configuration is as follows:
Containers: 3  Running: 2  Paused: 0  Stopped: 1 Images: 3 Server Version: 17.12.0-ce Storage Driver: overlay2  Backing Filesystem: extfs  Supports d_type: true  Native Overlay Diff: false Logging Driver: json-file Cgroup Driver: cgroupfs Plugins:  Volume: local  Network: bridge host macvlan null overlay  Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog Swarm: inactive Runtimes: runc Default Runtime: runc Init Binary: docker-init containerd version: 89623f28b87a6004d4b785663257362d1658a729 runc version: b2567b37d7b75eb4cf325b77297b140ea686ce8f init version: 949e6fa Security Options:  apparmor  seccomp   Profile: default Kernel Version: 4.4.0-31-generic Operating System: Ubuntu 16.04.1 LTS OSType: linux Architecture: x86_64 CPUs: 8 Total Memory: 3.858GiB Name: slingshot ID: CA7X:MACI:7LHI:CZ62:IDNO:FD4X:AJ7D:MDQJ:ZJYP:MHF4:WYTA:A3OU Docker Root Dir: /var/lib/docker Debug Mode (client): false Debug Mode (server): true  File Descriptors: 56  Goroutines: 69  System Time: 2018-02-20T18:08:12.902672024+01:00  EventsListeners: 0 Registry: https://index.docker.io/v1/ Labels: Experimental: false Insecure Registries:  <IP_ADDRESS>/8 Live Restore Enabled: false

What version of Clair are you using? This looks like it's from master and not a stable release. If you'd like to use Clair with any existing clients, you'll probably want to use a stable release.
The failure looks like Clair is failing to bind to port 6060. Can you describe the steps you used to arrive at this error?


interactivity added to cards

The cards now move through the different stages using the next and back buttons

LGTM!


Embedded link directs to wrong page on DQS tutorial page, for SQL 2014

**Submitted to site feedback by @Xceptions **
A wrong link was inserted in a page for learning how to automate DQS cleansing with SSIS.
In this page [1], the link inserted at the bottom is supposed to take us to the next item on the list of learning which is this [2], but it instead, leads to here [3].
Please correct it

Helpfully, here are the hidden link Https URLs:

[1] = https://docs.microsoft.com/en-us/sql/tutorials/task-6-adding-excel-source-to-the-data-flow?view=sql-server-2014

[2] = https://docs.microsoft.com/en-us/sql/tutorials/task-7-adding-dqs-cleansing-transform-to-the-data-flow?view=sql-server-2014

[3] = https://docs.microsoft.com/en-us/sql/integration-services/data-flow/data-flow?view=sql-server-2014

. .

@msebolt Hi Matthew, For this Issue 2590, would you please fix the errant link, by creating a private repo PR.

@ryanmajidi Hello Ryan, This Issue #2590 is now fixed by our private repo PR #11245.
Thank you for bringing this documentation shortcoming to our attention. We hope to hear from you again.
I am now Closing this Issue, as fixed.


Fine-tuned models for AE and ASC

Hi,
As you mentioned in this issue: #17
I have used the transformer-version code base to fine-tune the models. Here is the result that I got after running bash script/run_ft.sh, e.g. for AE_laptop_14 and ASC_laptop_14:
ae_laptop_14
BERT                            f1 = 0.7863
BERT_Review              f1 = 0.8381
BERT-DK                      f1 = 0.8302
BERT-XD_Review        f1 = 0.8374
BERT-PT                      f1 = 0.8358
asc_laptop_14
BERT                               acc = 73.9028 	     mf1 = 70.7175 	     pos_f1 = 0.8672 	   neg_f1 = 0.6798 	   neu_f1 = 0.4436
BERT_Review                 acc = 78.2445 	     mf1 = 75.1642 	     pos_f1 = 0.8824 	   neg_f1 = 0.7473 	   neu_f1 = 0.5526
BERT-DK                        acc = 75.3918 	     mf1 = 71.6495 	     pos_f1 = 0.8688 	   neg_f1 = 0.7167 	   neu_f1 = 0.4880
BERT-XD_Review          acc = 78.7304 	     mf1 = 75.4337 	     pos_f1 = 0.8860 	   neg_f1 = 0.7453 	   neu_f1 = 0.5824
BERT-PT                        acc = 77.2100 	     mf1 = 74.2477 	     pos_f1 = 0.8798 	   neg_f1 = 0.7283 	   neu_f1 = 0.5484
Now, I have two questions:
I need to use fine-tuned models for two end-tasks (AE & ASC) for two new datasets (Amazon reviews >> Cellphone and Laptop )

It seems that the script doesn't save any model for the end tasks. Am I right?
If it's true, How can I use models for my own datasets to predict the aspect and polarity?

Best,
Vahid

I think I could find the bug. In the config.py, you assigned remove_model = True
class TrainConfig(Config):
    def __init__(self,
        max_seq_length=128,
        train_batch_size=32,
        learning_rate=3e-5,
        run=10,
        eval_batch_size=32,
        remove_model=True,
        num_train_epochs=8,
        fp16=True,
        do_lower_case=True,
        adam_epsilon=1e-8,
        fp16_opt_level="O1",
        max_grad_norm=1.0,
        weight_decay=0.0,
        warmup_steps=0,
        no_cuda=False,
        n_gpu=1,
        device=0,
        **kwargs
    ):


update to Kubernetes 1.19.1

Updating to Kubernetes 1.19.0 (rc) disabled some of our tests. We need https://github.com/kubernetes/kubernetes/pull/94283

Fixed in PR #723, albeit with a fork of Kubernetes because we needed additional fixes.


Add linter workflow

Description

Added the prettier linter to ensure proper and uniform linting of the codebase.
For the linter to run successfully please open the settings of the repo go to Actions -> General -> workflow permissions and enable read and write permissions.

Fixes #370
Screenshots

Checklist

[x] Tests have been added or updated to cover the changes
[ ] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[x] All tests are passing

@SurajPratap10 Can you please merge this PR if no changes are necessary?

@SurajPratap10

@SurajPratap10 This can be merged?

@SurajPratap10 Please merge this.

@SurajPratap10


About batch_size

HI! I train with ./scripts/train_voc_aug.sh -l 1323 -g 2 -b 101 ，and I use 4*V100(16G),batchsize=4,lr=0.0025.  In your code,it's 2*V100(32G),batchsize=8,lr=0.0025.But miou in result is just75.29%.When I set lr=0.00125 ,the miou=76.33%,lower than you 78.20%.
I set batchsize in scripts/train_voc_aug.sh line 49：
nohup python3 VocCode/main.py --labeled_examples="${labelled}" --gpus=${gpus} --backbone=${backbone} --warm_up=5 --batch_size=4 --semi_p_th=.6 --semi_n_th=.0 --learning-rate=1.25e-3 \
--epochs=${max_epochs} --unsup_weight=${unsup_weight} > voc_aug_"${labelled}"_"${backbone}".out &

In addition, I have done experiments on Cityscapes(372), and only with batchsize set to 2 does not get error:out of GUP memory.(gpu=4*v100(16G),lr=0.0045).In your code it's gpu=2*v100(32G),lr=0.0045,batchsize=8
Can you give me some advice?

Hi @Yan1026 ,
I recommend you follow the setting in this link (https://wandb.ai/pyedog1976/PS-MT(VOC12)/runs/177s76t6) for voc12 aug set and this link (https://wandb.ai/pyedog1976/PS-MT(City)/runs/bxf92y1q) for cityscapes.
In case you are using V100 (16G), I suggest you to downgrade backbone to be resnet50 and compare the results in paper.

Thanks for reply,I will try again.
I just set batchsize in scripts/train_voc_aug.sh line 49：
nohup python3 VocCode/main.py --labeled_examples="${labelled}" --gpus=${gpus} --backbone=${backbone} --warm_up=5 --batch_size=4 --semi_p_th=.6 --semi_n_th=.0 --learning-rate=1.25e-3 \ --epochs=${max_epochs} --unsup_weight=${unsup_weight} > voc_aug_"${labelled}"_"${backbone}".out &
Is this right?

Hi @Yan1026 ,
Sorry, I can't guarantee the performance if your setting differs from the hype-parameter in this link (https://wandb.ai/pyedog1976/PS-MT(VOC12)/runs/177s76t6/overview?workspace=user-pyedog1976).
The smaller batch size or learning rate will lead to a significant difference, and please follows our setting for the aug experiment.

Thanks for reply,I will try again. I just set batchsize in scripts/train_voc_aug.sh line 49： nohup python3 VocCode/main.py --labeled_examples="${labelled}" --gpus=${gpus} --backbone=${backbone} --warm_up=5 --batch_size=4 --semi_p_th=.6 --semi_n_th=.0 --learning-rate=1.25e-3 \ --epochs=${max_epochs} --unsup_weight=${unsup_weight} > voc_aug_"${labelled}"_"${backbone}".out &
Is this right?

Hi Yuyuan, thanks for your great work. I also have one question about your batchsize. You mentioned that On Pascal VOC 2012, we crop images to 512 × 512 pixels for DeeplabV3+, train for 80 epochs with base learning rate set to 0.01, using batch size 32, for both labelled and unlabelled images, following CPS. So you are using batchsize=64, am I right? However, it seems tp me that CPS only use batchsize=16 (I am not sure about that). Could you give me some advice on that? Thank you so much.


Updated time doesn't reset to 0 from Cloud

Description:
User has active pro subscription. Installed new build 2.6.3 and signed in to the app.
It seems Web and iOS were able to reset updated time to 0 on this example sensor, but on Android same sensor never resets counter to 0.
Muzibur added a fix for this just recently, maybe same fix is needed on Android?
https://drive.google.com/file/d/1-UPsW9w35oIZmo7J6fNpT8LOUcQbKOyo/view?usp=sharing
Web:

iOS:

Android:
https://drive.google.com/file/d/1-T6eLFzdrOD-FQmHNF8qu0CH6Hx_a_Q1/view?usp=sharing

Should work as always. Please re-check @markoaamunkajo

Discussed in DM, sent couple of new videos about updated times.

@andreevdenis this is caused by system time being set manually and mine was 5 minutes ahead.
Tried also 1 hour behind and I can get the counter to update with negative values.
Also happens on iOS.
Is this something worth fixing? I guess most will use automatic time on their devices.

We are comparing timestamp from the cloud with local time so this explains everything. Not worth fixing in my opinion and I'm not sure how we can fix this.

Ok moving to done


[Clarification & Feedback] Quick Start 2 - 5. Grouping Data - "Add New Column"

TL;DR
Specify that it is through the Grouped By column that you're adding a new column and a request to clarify/explain the difference.
New User Feedback
So I had a moment of confusion in following along in Quick Start 2 which comes down to where I was clicking "add new column" from. See Quick Start (Page 5 - Grouping Data)

Add a new column and rename it Monthly Profit using the following formula:

So, earlier in the Quick Start (Page 4 - Calculated Columns) you learn about creating columns at the table level.  However in Step 5 the phrasing "Add a new column and rename it" makes me think that you're asking
to make a column just like I did in step 4.
However, doing that and then moving it to "Group By" (which is called out in the step previous as an option to Group) doesn't make the same as adding a column next to Group By.  Or at least it doesn't if you drag and drop like:

And I'm unable to drag/drop [Profit] into the Group By month grouping anyways.
The Ask

Update the Quick Start to make it clearer that you need to use the "Add a column" from the Group By menu
Help users understand if they made a mistake, like "Does your data look like this?" Here's an explanation of what went wrong:

I will add some instructional text to help explain this but the point you are missing is that we are not only adding a new column in this flow, we are also adding the column as part of a grouped columns calculation. This results in the calculation to be aggregated at the grouped columns level. This is a subtle, but important difference than just adding a table column that has some calculations.


microk8s join ... --worker works, microk8s join ...  does not

Summary

I installed microk8s on multipass qemu vms on separate physical machines.

Joining a multipass vm as worker from a physical machine to another is successful and the node appears in the cluster.
Joining a multipass vm as control plane from a physical machine to another ends successful, but the node does not appear in the cluster and the microk8s on that multipass vm is now not reachable, some error about <IP_ADDRESS>:16443.

Hi @itmitica, could you please provide more details in the setup (machines, VMs, networks, IPs, opened ports)? I suspect this has something to do with the datastore not being reachable from/to all nodes but I cannot be sure. Thanks


carriage-return key sends message while typing SMELL

it is diffedent from the std keyboard. Tne enter key should just be new line
like in the orriginal google keyboard[ Before posting bugs, please check
https://code.google.com/p/hackerskeyboard/wiki/FrequentlyAskedQuestions and
the existing bugs for known issues - my responses may be delayed since I
have very little time to work on this project. ]

What steps will reproduce the problem?
1.
2.
3.

What is the expected behavior? What do you see instead?

What version of Hacker's Keyboard are you using, for example "1.37"? (See
"Debug" section at the bottom of the app's Settings menu.)

On what phone or tablet?

If applicable, does this affect the 4-row or 5-row layout, or both? Which
language(s)?

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 23 Mar 2014 at 12:56

#392, I think.


Fix code snippets for python-based-visualizations docs

This change is

/assign @joeliedtke

This change is staged at:
https://deploy-preview-1509--competent-brattain-de2d6d.netlify.com/docs/pipelines/sdk/python-based-visualizations/

Currently, the code snippets within the Known Limitations section looks like

The code snippets are not properly rendered and should instead be
.

Thanks for fixing the code sample formatting, @ajchili!
/lgtm
/approve


Add startup api check job PSP

What this PR does / why we need it:
Adds the PSP and related RBAC resources for the Startup API Check job, new job in 1.5.0 but missing these resources.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4361
Special notes for your reviewer:
Release note:

Pod Security Policy for startup api check job

/ok-to-test

/retest

@ndegory thank you for the changes; lets wait for @wallrj to review / answer on these comments:

https://github.com/jetstack/cert-manager/pull/4364#discussion_r692789136
https://github.com/jetstack/cert-manager/pull/4364#discussion_r688984138

/assign @wallrj

@wallrj @inteon , is there anything else you would like to see in this PR, or are we good with leaving any changes in how hook annotations are managed for another PR?

/cherry-pick release-1.5

/kind bug


Use the same command for getnameverison in both firmware and apps

To ensure that other client apps can get what app is running, and present an adequate error to the user,the getnameversion command needs to be the same regardless of device-app or firmware.
In firmware we have defined it as:
FW_CMD_NAME_VERSION (0x01)
FW_RSP_NAME_VERSION (0x02)
The protocol of the signer and all apps using it should be change to the above.

For my tkey-device-x25519 I used the 0x01 and 0x02 as fw uses, but alas...

You are right.
For 1.0 release we chose not to make breaking changes to the protocol to ease migration, i.e., you can use either version of the signer with either version of tkey-ssh-agent if you just load the app with tkey-runapp for example.
But in the long run it might be better to move to something else, like proto buffer or something.


Usage of /var/db/xbps from two (or more) different systems is not supported

Reusing the hosts /var/db/xbps does break systems, since the pkgdb of the host system will just be appended with the packages in the VOIDNSRUN_DIR (and vice versa).
Take a look at the output of e.g. xbps-pkgdb -a, you should see a ton of packages reported as broken if this is executed inside voidnsrun.
Using xbps-install inside voidnsrun, as suggested in your README, will not do what you want, since the pkgdb that was created with the initialization of /glibc will not be inside the namespace, so the host one will be used and "corrupted".

For reference, this caused https://github.com/void-linux/void-packages/issues/32184

Hi. Thanks for reporting this but it's not actually true. When you use xbps-install with voidnsrun, it bind-mounts /var and /etc from the container. The host pkgdb is therefore never used so it can't be corrupted.
The reason why xbps-pkgdb -a reports ton of broken packages is that xbps-pkgdb was not added to the list of xbps commands here, which is, indeed, not good.
Fixed with 7d79c86285de5da04d22827c149c6a46886159ee.

Thanks for the fix :)


Mintmaker: explicitly disable Dependency Dashboard

Seems like we have to manually disable that because some preset might be taking effect:
https://github.com/renovatebot/renovate/discussions/11330
Let's force this, so that we can disable the dashboard.

@qixiang @staticf0x PTAL

/retest


Test broken: predspec

The predspec test fails to build. Please respond to this issue if you have any interest in keeping this test. I am trying to determine who has an interest in maintaining each test, and if no one is interested, I will delete the test.
Build error:
testmapper.cc:36:15: error: no matching function for call to ‘Legion::Mapping::DefaultMapper::DefaultMapper(LegionRuntime::HighLevel::Machine&, LegionRuntime::HighLevel::HighLevelRuntime*&, LegionRuntime::HighLevel::Processor&)’
   , runtime(rt)
               ^
testmapper.cc:36:15: note: candidates are:
In file included from testmapper.h:2:0,
                 from testmapper.cc:1:
/home/eslaught/legion/runtime/mappers/default_mapper.h:113:7: note: Legion::Mapping::DefaultMapper::DefaultMapper(const Legion::Mapping::DefaultMapper&)
       DefaultMapper(const DefaultMapper &rhs);
       ^
/home/eslaught/legion/runtime/mappers/default_mapper.h:113:7: note:   candidate expects 1 argument, 3 provided
/home/eslaught/legion/runtime/mappers/default_mapper.h:111:7: note: Legion::Mapping::DefaultMapper::DefaultMapper(Legion::Mapping::MapperRuntime*, Legion::Machine, Legion::Processor, const char*)
       DefaultMapper(MapperRuntime *rt, Machine machine, Processor local,
       ^
/home/eslaught/legion/runtime/mappers/default_mapper.h:111:7: note:   no known conversion for argument 1 from ‘LegionRuntime::HighLevel::Machine {aka Realm::Machine}’ to ‘Legion::Mapping::MapperRuntime*’
testmapper.cc: In member function ‘virtual void TestMapper::select_task_options(LegionRuntime::HighLevel::Task*)’:
testmapper.cc:109:9: error: ‘LegionRuntime::HighLevel::Task’ has no member named ‘inline_task’
   task->inline_task = false;
         ^
testmapper.cc:110:9: error: ‘LegionRuntime::HighLevel::Task’ has no member named ‘spawn_task’
   task->spawn_task = false;
         ^
testmapper.cc:111:9: error: ‘LegionRuntime::HighLevel::Task’ has no member named ‘map_locally’
   task->map_locally = true;
         ^
testmapper.cc:112:9: error: ‘LegionRuntime::HighLevel::Task’ has no member named ‘profile_task’
   task->profile_task = false;
         ^
testmapper.cc:113:9: error: ‘LegionRuntime::HighLevel::Task’ has no member named ‘task_priority’
   task->task_priority = 0;
         ^
testmapper.cc:115:9: error: ‘LegionRuntime::HighLevel::Task’ has no member named ‘additional_procs’
   task->additional_procs.insert(procs[node].begin(), procs[node].end());
         ^
testmapper.cc: In member function ‘virtual void TestMapper::notify_mapping_result(const Mappable*)’:
testmapper.cc:140:32: error: ‘const Mappable’ has no member named ‘as_mappable_task’
   const Task *task = mappable->as_mappable_task();
                                ^
testmapper.cc:147:49: error: ‘const struct Legion::RegionRequirement’ has no member named ‘selected_memory’
         << ") mapped on " << task->regions[idx].selected_memory
                                                 ^

@streichler Have you decided whether it would be beneficial to keep this test?

This test has been removed as of d0fb5b8d04cc6876612db969b67f7b4e66fef711. If you are interested in resurrecting this test, please reply to this issue.


Add backend tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f836da1). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage        ?   65.44%
=======================================
  Files           ?        9
  Lines           ?      356
  Branches        ?        0
=======================================
  Hits            ?      233
  Misses          ?      123
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Open up pub modscope for everybody

Everybody should have enough rights to add modules to the pub modscope, without being able to see or modify other pub modules that have other owners.
All authors will have to get the pub modscope specific user role attached. The module listing should be changed to also check module user roles.

Not gonna happen anymore. People shouldn't use the pub modscope.


Typo on Command Line

Hi, thanks for sharing your code! In README, I think boostrap.run under the Use a Specific GPU section shall be bootstrap.run.

Sorry for the typo. Thanks for pointing it out!


ultra_face_opencvdnn_inference with version-RFB-640.onnx weights does not work

Hello! I'm trying to run ultra_face_opencvdnn_inference with version-RFB-640.onnx as a weights file, but getting this mesage:
[ERROR:0] global /tmp/pip-req-build-ms668fyv/opencv/modules/dnn/src/onnx/onnx_importer.cpp (1876) handleNode DNN/ONNX: ERROR during processing node with 1 inputs and 1 outputs: [Exp]:(472)
Traceback (most recent call last):
  File "ultra_face_opencvdnn_inference.py", line 193, in <module>
    inference()
  File "ultra_face_opencvdnn_inference.py", line 148, in inference
    net = dnn.readNetFromONNX(args.onnx_path)  # onnx version
cv2.error: OpenCV(4.5.1) /tmp/pip-req-build-ms668fyv/opencv/modules/dnn/src/onnx/onnx_importer.cpp:1887: error: (-2:Unspecified error) in function 'handleNode'
Node [Exp]:(472) parse error: OpenCV(4.5.1) /tmp/pip-req-build-ms668fyv/opencv/modules/dnn/src/dnn.cpp:614: error: (-2:Unspecified error) Can't create layer "472" of type "Exp" in function 'getLayerInstance'

Does anyone know how to overcome this issue? Or has anybody successfully ran opencvdnn inference with RFB-640 model?

I have the exactly same error outputs. Both version-RFB-640.onnx and version-RFB-320.onnx do not work. I am using opencv 4.4.0 by the way.


Image Picker - more file types desired

Using Image Picker, I am able to view any file type on my device, or in linked cloud storage (In my example, Google Drive), but I am not able to actually select any non-image file type for upload.
It would be great if it could select any file type (Even if only images would be displayed)
Thanks!

There are several community packages in pub.dartlang.dart that provide additional features (select multiple images, ...). Worth checking for additional file types as well.

@Caponigri We current don't have a plan to add features to picking files other than image/videos with the image_picker plugin. Did you end up finding a good plugin to pick files?


Simulator network configuration and stress test

Support for configuring the network using the simulator's SimConfig struct. (See https://github.com/MystenLabs/mysten-sim/pull/3 for background).
Adds a new test which runs the stress tester inside the simulator. This test can currently expose various bugs/errors when run with a higher latency network. The default target that is checked in uses low latency and thus will pass in CI.
@sadhansood is there an easy way to get a failure signal from the BenchDriver, e.g. a callback every time a transaction fails? Right now I don't have a good way to make this test fail if errors are encountered.

@mystenmark the BenchmarkStats object that is returned by the BenchDriver has num_errors and num_success metric in it. We could pass in the run_duration as some finite value (5 mins, 1 hour, etc) and check the resulting stats for %error_rate and fail the test if it's too high.

@mystenmark the BenchmarkStats object that is returned by the BenchDriver has num_errors and num_success metric in it. We could pass in the run_duration as some finite value (5 mins, 1 hour, etc) and check the resulting stats for %error_rate and fail the test if it's too high.

I took a look at that, but apparently the errors that I'm seeing aren't resulting in client facing errors, so they don't show up in the BenchmarkStats - I'll need to find some other way to instrument those.
I added a simple assert for 0 errors for now.
We can add longer tests, but I'll need to set up a nightly job for longer tests - I don't want to add very long running tests to CI.


Adsk Contrib - Improve Python information

Signed-off-by: Patrick Hodoul<EMAIL_ADDRESS>Following investigations reported on OCIO Slack and ASWF Slack, some Python 'generally available' variables were discovered missing. So, the changes here add these variables:
>> import PyOpenColorIO as ocio

ocio.__version__ provides the current version
ocio.__license__ provides the license
ocio.__copyright__ provides the copyright
ocio.__doc__ provides a one-line explanation of the library purpose
ocio.__status__ provides the status of the version i.e. production when that's an official release otherwise dev (or any version post fix we will agree on)

Thanks @hodoulp, this is great!
Here is for reference what we have in Colour (+ the automatic doc, etc...):
__author__ = 'Colour Developers'
__copyright__ = 'Copyright (C) 2013-2020 - Colour Developers'
__license__ = 'New BSD License - https://opensource.org/licenses/BSD-3-Clause'
__maintainer__ = 'Colour Developers'
__email__ =<EMAIL_ADDRESS>__status__ = 'Production'
__application_name__ = 'Colour'
__major_version__ = '0'
__minor_version__ = '3'
__change_version__ = '15'
__version__ = '.'.join((__major_version__, __minor_version__, __change_version__))

From there, I would add __author__ because it is mentioned, briefly in PEP8: https://www.python.org/dev/peps/pep-0008/#module-level-dunder-names
__application_name__ is made by us for our packages and could be __title__ which occurs a bit. Same for __major_version__, __minor_version_ and __change_version__ although you can find the, rarely, in the wild.
We use them for example when describing the Colour running environment: colour.utilities.describe_environment()
===============================================================================
*                                                                             *
*   Interpreter :                                                             *
*       python : 3.6.9 (default, Nov  7 2019, 10:44:02)                       *
*                [GCC 8.3.0]                                                  *
*                                                                             *
*   colour-science.org :                                                      *
*       colour : v0.3.15-86-g2d5b1ed0                                         *
*                                                                             *
*   Runtime :                                                                 *
*       imageio : 2.4.1                                                       *
*       matplotlib : 3.2.1                                                    *
*       networkx : 2.4                                                        *
*       numpy : 1.18.3                                                        *
*       pandas : 1.0.3                                                        *
*       scipy : 1.4.1                                                         *
*       six : 1.12.0                                                          *
*                                                                             *
===============================================================================

@KelSolaar, yes author and email are interesting information for Python developers.

As usual this is a notice that we will merge this week if there are no discussions on the pull request.


Forward declaration inconsistency warning fix

Removes compilation warning:
warning: struct 'CTransaction' was previously declared as a class'

Good catch! Thanks

Thanks for the merge, now I have more coming.


Fix LCE ViewState example in Getting Started section

Does this look right, @sockeqwe ?

No problem. I haven't used Mosby yet but wanted to try it so I've been reading through all the documentation and just wanted to make sure what I was reading was accurate.
I'm not sure I follow when you say you didn't want to add getData() because it is LceViewState related. This is in the "LCE ViewState example" section, so it should be expected to find LceViewState things here, wouldn't it?
I agree that the "Getting Started" section can/should be simplified compared to the more in-depth individual sections, but I found it odd that it mentions implementing createViewState() but not getData() - they are both required when extending MvpLceViewStateFragment, aren't they? Once I had read the ViewState section and some of the sample code, it felt strange that it was missing from this example. Not a huge deal, just wanted to bring it up for your consideration from the perspective of a new user.
Note that the other part of this commit is updating the createViewState() signature in the example to return LceViewState<M, V> rather than ViewState. Is this accurate?
Thanks!

I agree.
Yep, LceViewState<M, V> is correct.


feat(*): added warsaw (europe-central2) location

fixes https://github.com/firebase/extensions/pull/663

Codecov Report

Merging #677 (ebe1e98) into next (612cbbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #677   +/-   ##
=======================================
  Coverage   50.65%   50.65%
=======================================
  Files          30       30
  Lines        1313     1313
  Branches      193      193
=======================================
  Hits          665      665
  Misses        647      647
  Partials        1        1

Testing


Use JCTools queues

Mutiny currently contains code for queues coming from older and modified JCTools versions and RxJava 2 derivatives.

We should instead depend on current JCTools
io.smallrye.mutiny.helpers.queues.Queues is the facade for providing different kinds of queues
We might decide to shade JCTools in Mutiny instead of a direct dependency
Mutiny uses system properties for some queue sizes (e.g. mutiny.buffer-size.xs), we should instead use Infrastructure-provided configuration

/cc @cescoffier (we had an offline discussion on that topic) @franz1981 (JCTools)

Work continues in #1413
Thanks @franz1981

I closed the issue, not the draft PR 🤣

Done in #1434


kops_cluster_updater: add instance group filtering to rolling updates

Adds the instance_groups attribute to rolling_update_options that, if set, only runs the rolling update on the specified IGs.
Equivalent to running kops rolling-update cluster --instance-groups=<ig1>,<ig2>,... --yes
Closes #1113

@eddycharly any chance I could get a review for this? This functionality is the last missing piece needed to allow migration of our 11 kops cells fully into terraform

@eddycharly any chance I could get a review? This functionality is the last missing piece in migrating management of our 11 kops clusters into Terraform. Otherwise we will have to run kops rolling-update cluster --instance-group ... in a null_resource which is something I very much would rather avoid.

Ahh, i see you have moved on from ownership of this provider. I will close this merge request.

Ahh, I see you have moved on from supporting the kops provider. I will close this MR and open it with the new provider


Add Support for containerd

AKS is now using containerd instead of docker. This is leading to failure of the actions when used with AKS.
See this issue for more details

This request is being tracked here https://github.com/Azure/cli/issues/77
Closing this issue.


[SPARK-44024][SQL] Change to use map when unzip only used to extract a single element

What changes were proposed in this pull request?
A minor code simplification, use map instead of unzip when unzip only used to extract a single element.
Why are the changes needed?
Code simplification
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions

Looks OK, is it ready?

Yes, this one ready to go

Merged to master


clipboard.js can't work in ios9

Minimal example

Fork this link

Expected behaviour
I thought that clipboard.js can copy the text  in moblie clipborad.
Actual behaviour
clipborad.js throw an error on this page under ios9.
Devices affected
I tested on all major devices like huawei honor v10、samsung s6、iphone x with ios11、iphone 6, only iphone 6 with ios9 does not work.

There is no sample in this issue that demonstrates the issue. Please try the demo page at: https://clipboardjs.com
This issue should be closed...

The same problem for me. Have you solved it ?

iOS9? Take a look at the readme. This project supports Safari 10+ due to limitations in previous versions...

I have the same problem，IOS9+, Have you solved it ?

emmm..as @Ruffio says, the project supports Sarfari 10+. It has limitations in previous versions.
so,  i pop up a popup window to remind users to manually copy by themselves.


Add instructions for running the unit tests in README

I encountered unit tests failures while trying to run the unit tests.
Without instructions, my first attempt was to navigate to the uptane/tests directory and run ./runtests.py.  This resulted in unit test failures.  I wasn't sure if these were expected failures, or not.
The README does not currently provide instructions on running tests.
We should add instructions for running the tests so that potential collaborators do not run into the same issue.

Coverage remained the same at 61.054% when pulling 4cd549c3751b913848689824b88e4529e1b91758 on vladimir-v-diaz-patch-1 into 0de7eebeddde1f6f4f6bcce1bb50508cce960c7b on develop.

Yes, that is expected in that they were run from the wrong directory. Tests are run from the root uptane/ directory. This is somewhat apparent from the text of runtests.py. Also, if you just run tox from the root uptane/ directory, all this is run correctly.
I'm not opposed to sticking instructions on how to run the tests in the README somewhere, (which would probably just tell people to run tox), and I'm not opposed to adding a small note about how to run individual tests (which would tell you to run them from the root directory, e.g. python tests/test_secondary.py). At the moment, though, the tests are a development tool, and the README is a set of instructions for running the demo to acquaint yourself with Uptane.

Coverage remained the same at 61.054% when pulling 8c56f97901caaad51efec0a6a99ee1b7f3ba02ed on vladimir-v-diaz-patch-1 into 0de7eebeddde1f6f4f6bcce1bb50508cce960c7b on develop.

I added a commit to mention that individual unit tests can also be executed from the root directory, and that runtests.py runs all of the unit tests...

I made some edits to move the testing notes out of the way and explain why testing may be useful. Let me know if the result strikes you as worse. Otherwise, LGTM with the edits.

Coverage remained the same at 61.054% when pulling c048d17ba46a781ddfd6ce7e99d1c56aca35c06b on vladimir-v-diaz-patch-1 into 0de7eebeddde1f6f4f6bcce1bb50508cce960c7b on develop.

The edits look good to me.  You can go ahead and merge.
Note that people who are implementing Uptane might be interested in these unit tests, to help them with verifying behavior.

Good point. Added that note. Merging.


Not Compatible with MW 1.34.1 - Error 500 (fresh install, no extensions)

Setup

Browsers and versions: All
MediaWiki version: 1.34.1
Database version: MySQL | 5.7.28-log
PHP version: 7.3.15 (cgi-fcgi)
Pivot version: 2.1.0
Extension version (if connected to the issue): None installed or enabled, default without even default extensions enabled. Only thing enabled is uploads.

Issue
Not compatible with MW 1.34.1, kicks error 500 in preview, when activated. Had to use the following command in SSH to clear it out of user preferences to be able to access my site again: php userOptions.php skin --old "pivot" --new "vector"
Have to switch to a different skin despite how much we love this one, support for 1.33 is ending June 2020. Going to mess up all the pages we have grids in and this makes us very, very sad. Might port the grid and styles out of this theme into another. :<
Thank you for this wonderful skin, we hope to return to it in the future.

I’ll be adding a fix for that in 24 hrs. Known issue because of change in MW.

Fixed with release v2.2.0, pull master (2.2.0) or develop (2.2.0-dev)

Just wanted to say again a big thank you for this.


Be deploy

Description
--Update content in index.html and create dotenv file
Fixes # (issue)
--Fixed backend security
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

Will remove node_modules after merging due to odd error with our .gitignore not catching node_modules folder.


feat: add cms and timestamp

add packages from notation-core-go v1.0.0-rc.1:

cms
timestamp

refactor:

moved hashutil, oid, pki to cms package
rename asn1 to be ber package and moved to cms package
moved all OID <-> hash related function to oid package
moved hasing algorithm -> OID function to oid package
added cert.ExtKeyUsage[0] == x509.ExtKeyUsageTimeStamping validation in SignedToken.Verify

Generally, the main logic keeps the same as v1.0.0-rc.1
Signed-off-by: Junjie Gao<EMAIL_ADDRESS>

@JeyJeyGao Can you split this PR into two smaller PRs (e.g. cms and timestamp)? Otherwise, it is too hard to review.

@JeyJeyGao Can you split this PR into two smaller PRs (e.g. cms and timestamp)? Otherwise, it is too hard to review.

@shizhMSFT Removed timestamp package

I guess I have a general question before starting to review this PR: Besides relocating and renaming files/packages, is there anything new in this PR compared to v1.0.0-rc.1? If yes, can you list them in the summary? @JeyJeyGao

@Two-Hearts I have updated the PR description. These are all the changes.