Refactoring parse_message()

Description
The goal of this ticket is to refactor the generic presto parse_message() func into model level input validations and separate parse_input_message() and parse_output_message() functions instead of just one parse_message() for both input and output.
Reference: CV2-5001
How has this been tested?
Has it been tested locally? Are there automated tests?
Are there any external dependencies?
Are there changes required in sysops terraform for this feature or fix?
Have you considered secure coding practices when writing this code?
Please list any security concerns that may be relevant.

Also, I think it is super helpful to have an early draft PR like this to be able to discuss!!

oh wait, I'm realizing I missed a crucial word

i don't think we should have code that checks responses have specific fields in their bodies (callback_url, id, etc)

responses
I agree we don't need to validate these fields in responses (if these are missing, they are about to fail anyway) but I think we need to validate these on inputs

oh wait, I'm realizing I missed a crucial word

i don't think we should have code that checks responses have specific fields in their bodies (callback_url, id, etc)

responses
I agree we don't need to validate these fields in responses (if these are missing, they are about to fail anyway) but I think we need to validate these on inputs

yes, exactly. the quoted checks on inputs are already being enforced by pydantic in schemas.pyas I mention in my other comments too.

Ok you've done a great job here but I have two things:

I hate how much we're calling parse_input_message. Is there any way we can find a way to refactor so we don't call it a billion different places?
I know you're stubbing out the validations per fingerprinter, but I think we could probably just do basic type checking of the sort we already do for unit tests for each fingerprinter and that would probably be sufficient as a first pass? We can talk more about that in the ML call next week if that's screwy or confusing.

thanks Devin! I agree with the suggested solutions on both issues you raised. let's definitely discuss before making a decision on ml call or one on one, but my current hope is to keep the scope of this refactor limited, and have separate tickets for both reducing parse_input_message() usage and implementing model specific validations.

Ok you've done a great job here but I have two things:

I hate how much we're calling parse_input_message. Is there any way we can find a way to refactor so we don't call it a billion different places?
I know you're stubbing out the validations per fingerprinter, but I think we could probably just do basic type checking of the sort we already do for unit tests for each fingerprinter and that would probably be sufficient as a first pass? We can talk more about that in the ML call next week if that's screwy or confusing.

Per our convo today, I have created two tickets per your suggestion @DGaffney to address these issues in future work. Those tickets are CV2-5093 and CV2-5102.


Advanced Type: Quiz

adv subtypes: quiz
lint 030

Not sure I understand the webex file stuff, I guess it's possible to have several of them pre-saved? Don't hesitate to share this kind of resources in the future, I'm interested.

Not sure I understand the webex file stuff, I guess it's possible to have several of them pre-saved? Don't hesitate to share this kind of resources in the future, I'm interested.

Good idea. I have a Webex file, I'll create a Google Meet version and push them to the repository


Domain aliases

I can't see how this can be done at config level, but it would be handy declaring domain aliases, typically CNAME NS entries for the www case and stuff like that.
Thanks

you can create CNAME records with https://up.docs.apex.sh/#configuration.dns_zones_records, however I don't think API Gateway will route them properly, I'll double check, but we might need CF in front

I tried adding a CNAME and got a Cloudfront error. My quick workaround for this is just using staging as my www.* environment. It's bad because you get another cert and actually have two of everything running, but it worked for my need.

@rscott SEO-wise I'd definitely redirect from one or the other (if that's relevant) since it can be treated as duplicate content


Projection with multiple aggregates only running last one

If you have a projection with multiple aggregates (I've only tried with combinations of Sum and Count) only the last one seems to get run, and each property gets the results from that last query.
dnx: 1.0.0-rc1-16048
EF: 7.0.0-rc1-16147
Repro:
public partial class MyContext : DbContext
{
    public MyContext()
    {

    }

    public DbSet<Forum> Forums { get; set; }
    public DbSet<Topic> Topics { get; set; }

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
    {
        optionsBuilder.UseSqlServer(
            @"Server=(localdb)\mssqllocaldb;Database=EF7.AspNet5;Trusted_Connection=True;");
    }

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
    }
}

public class Forum
{
    public Forum()
    {
        Topics = new HashSet<Topic>();
    }

    public int Id { get; set; }
    public string Title { get; set; }

    public ICollection<Topic> Topics { get; set; }
}

public class Topic
{
    public int Id { get; set; }
    public string Title { get; set; }
    public int ForumId { get; set; }
    public int Counter { get; set; }

    [ForeignKey(nameof(ForumId))]
    [InverseProperty("Topics")]
    public Forum Forum { get; set; }
}

Query:
var forums = _context.Forums.Include(f => f.Topics).Select(f => new
        {
            f.Id,
            Counter = f.Topics.Sum(t => t.Counter),
            TopicCount = f.Topics.Count(),
        }).ToList();

Sample data:
var forum = new Forum();
forum.Title = "SAMPLE";

var topic = new Topic();
topic.Title = "SAMPLE";
topic.Forum = forum;
topic.Counter = 10;

forum.Topics.Add(topic);

var topic2 = new Topic();
topic2.Title = "SAMPLE2";
topic2.Forum = forum;
topic2.Counter = 9;

forum.Topics.Add(topic2);

context.Forums.Add(forum);

context.SaveChanges();

Running the above query with this sample data results in:
Id: 1
Counter: 2
TopicCount: 2

When we should get a Counter of 19. This is the resulting SQL query:
SELECT (
     SELECT COUNT(*)
     FROM [Topic] AS [t]
     WHERE [f].[Id] = [t].[ForumId]
), [f].[Id]
FROM [Forum] AS [f]

I also updated a sample MVC repo with an example of this issue: https://github.com/davezych/EF7_3029/tree/SumCount

I also have the same issue. A fix would be appreciated.

I can provide some samples if you want.

@GunterGlad please do provide samples (you can paste them in the comments).

Here is my expression:
var list3 = context.Customers.Select(x => new
{
Name = x.Name,
PaymentTotal = x.Payments.Sum(p => p.PaymentAmount),
PaymentTotalPlus = x.Payments.Sum(p => p.PaymentAmount + 5)
}).ToList();
public class AppDBContext: DbContext, {
public DbSet Customers { get; set; }
public DbSet Payments { get; set; }
}
Here are my classes:
public class Customer
{
public string Name { get; set; }
public virtual ICollection Payments { get; set; }
}
public class Payment
{
#region Customer
public int CustomerID { get; set; }
public virtual Customer Customer { get; set; }
#endregion Customer
public decimal PaymentAmount { get; set; }
}

Fixed in e697bd49359b50e4a385f199c0e4aabff769aca2

I am having the same issue. Example:
var test = await _context.Transports
                .Include(t => t.Boxes)
                .Where(t => t.Id == 123)
                .Select(s => new
                {
                    Weight = (from b in b.Boxes
                              join p in _context.Packages on c.Id equals p.BoxId
                              select p).Sum(p => p.Weight),
                    Volume = (from c in s.Boxes
                              join p in _context.Packages on c.Id equals p.BoxId
                              select p).Sum(p => p.Volume)
                })
                .ToListAsync();

would return a list of objects where Weight would be always the same value as Volume because the Weight aggregate is never executed in database. Same thing as described above.
I can see it was fixed in November 2015, however I am testing it with "EntityFramework.MicrosoftSqlServer": "7.0.0-rc1-final" and it still has this problem.
Isn't this fix part of the final RC1? If not, how should I apply the fix? Thank you

@realavaloro the fix is not part of the RC1, we took a snapshot on the 18th. Also there is no easy way to update the packages to the nightly ones - you would have to move the entire project to the nightly packages and might have some stability problems at the moment. The best course of action is apply the workaround for now (produce two queries, each having just one aggregate).
We don't have the dates for RC2 just yet, but you can follow https://github.com/aspnet/Home/wiki/Roadmap
Dates will appear there, when they are known. It should happen soon.

@maumar  Thank you. The workaround will be enough for now then.


[Mod Info] Network detective (for debuggin mods) [Steam ID<PHONE_NUMBER>] by kian.zarrin

Mod:
Network detective (for debuggin mods) [Steam ID<PHONE_NUMBER>] by kian.zarrin
Stability:

Stable: it simply functions fine.

Statuses:

Modders mod: this is intended for modders, regular users don't need it.
Source code: available at https://github.com/kianzarrin/NetworkDetective

This was already in the catalog.


Vscode app idea.

I have an idea to make that the vscode app contains:
.
Just to clarify the www.vscode.dev is an official vscode online replacement.

I had the same idea so I opened a PR for the code.
Hopefully it gets merged 🙏


test: set members for pitr test

Description
Update members to 3 for PITR tests as the source postgres instance has 3 members and we cannot create PITR instance less than the source instance members
Types of changes in this PR
Changes that affect the core Terraform module or submodules

[ ] Bug fix
[ ] New feature
[ ] Dependency update

Changes that don't affect the core Terraform module or submodules

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other

Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.
Your notes help the merger write the commit message for the PR that is published in the release notes for the module.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
Merge by using "Squash and merge".

FYI, tested by scaling up members for the PITR instance to 3 from source PITR instances 2 members and it worked as expected.

:tada: This PR is included in version 3.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


v2.12: log viewer only showing first log line

Summary
Should see all lines of logs, but only see first line.
Diagnostics
Network shows all lines:

UI states correct number of lines, but only first appears:

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@dcherman I think you worked on this recently?

Huh, interesting; I'm not sure how my original PR actually worked.  Essentially what's happening is the lines array contains all of the expected content, however the way that we pass the observable to the logs viewer doesn't make sense - we're emitting the lines array as a value, however that will never get re-emitted as more lines get pushed (and that wouldn't make a ton of sense).
It should be relatively straightforward to fix by using a multicast observable - PR incoming.


Sbom-tool can scan project with poetry.lock, but wrote 0 package.

When I used sbom-tool to scan the project with poetry.lock, it wrote 0 package elements in the SBOM regardless of source code or docker images. But it seemed that it scanned normally. For detail, please see the screenshot below:

The command is as follows:
For source code:
salus Generate -b ./test -bc ./test -pn Test -pv 0.0.1 -ps test -nsb https://test.com/ -V Verbose -m .
For docker image:
salus Generate -b ./test -bc ./test -di test:latest -pn Test -pv 0.0.1 -ps test -nsb https://test.com/ -V Verbose -m .
ENV: Ubuntu-20.04

We have new detectors being executed and we are not writing packages in the SBOM. Let's add the new component mappings into the sbom-tool

Poetry components are either Pip or Git.  I am investigating, but at the moment it doesn't appear that any of the detected components are returned for the SBOM Tool from the detectors.

Component detectors implementing this interface are in an experimental state.
The detector processing service guarantees that:
They should NOT return their components as part of the scan result or be allowed to run too long (e.g. 4 min or less).
They SHOULD submit telemetry about how they ran.
If opted in, they should behave like a normal detector.

https://github.com/microsoft/component-detection/blob/main/src/Microsoft.ComponentDetection.Contracts/IComponentDetector.cs#L53-L59


Search - Edit - Delete , Previous-Next buttons moved to the bottom

up to 5.6 these buttons message actions (all in the same bar ) were located at the bottom,
for larger phones, it is better to have them down there because it is easier to navigate through e-mails and delete.
perhaps this could be an option in settings. or maybe part of a custom theme?

Duplicate of #4725


JS Working, Telnet No

Sorry for my bad english.
I have written example code from website.
<?php

use Ratchet\Server\IoServer;
use Ratchet\Http\HttpServer;
use Ratchet\WebSocket\WsServer;
use Replayer\Chat;

require dirname(__DIR__) . '/vendor/autoload.php';
$server = IoServer::factory(
                new HttpServer(
                new WsServer(
                new Chat()
                )
                ), 8080
);

$server->run();

This works fine from browser. If i want connect from telnet to my localhost - i have no response.
If i use "basic" code like this:
<?php
use Ratchet\Server\IoServer;
use Replayer\Chat;

    require dirname(__DIR__) . '/vendor/autoload.php';

    $server = IoServer::factory(
        new Chat(),
        8080
    );

    $server->run();

Telnet works fine.
Thx for help

Please post your telnet command and the output from telnet when you attempt to connect.


How to use template data

I'm having issues to pull template data into Viewmodel. So I'm using Iron Router and I'm doing something like this:
@route 'example',
   data: ->
      Collection.findOne @params.id

So in a template controller you can reach this data, for example via Template.currentData() or @ in helpers. However, trying to call Template.currentData() from within Viewmodel results in errors, and @ obviously refers to Viewmodel.
So I've tried to get this data via a Session variable, like this:
data: ->
  Session.set 'templateData',  Collection.findOne @params.id

which I pull in either in a Viewmodel function or set it on a variable:
name: Session.get('templateData').name

which sometimes works, but sometimes results in undefined (probably some timing issues here).
So what's the right way to get template data with Viewmodel?

See: http://viewmodel.meteor.com/#definingBk
You basically define the view model with a function that takes the data context. You can use as many view model definitions as you like (functions or objects). They get appended to the the view model.
Template.home.viewmodel(
  // Add all properties in the data context
  function (data) { return data; },
  // Add more properties (some using the data context)
  function (data) {
    return {
      isEven: data.number % 2 === 0,
      address: '123 Main St.',
      zip: 12345
    }
  },
  // Now use a plain object
  {
    name: ''
  }
);

@ManuelDeLeon This still doesn't always work. Doing the same thing as @satyavh I am defining a route with iron:router that returns a Collection.findOne({}) as the data context. Then I define my viewmodel as follows.
Template.edit.viewmodel('edit', function(data) {
  return {
    id: data._id
  }
});

This results in Uncaught TypeError: Cannot read property '_id' of null when I browse to the url manually. Works fine if I hit the url from a link, so again I suspect strange timing issues.

@tomeglenn Please make a repro. It looks like IR is rendering the template before there's something in the collection.

@ManuelDeLeon Thanks for the quick response. When I get the chance I'll try and put together a sample.


fix: update to the latest version of the SDK

This PR adjusts version of the SDK to the latests.
When adjusting I found out numerous cases where we have incompatible enums defined in the ui-components.
I have marked those areas with TODO to get some explanation from core team

I know what is happening. It looks like we got more enums from SDK and the ones we had defined in UI outdated/do not match the ones on SDK.
I will remove enums from UI and use SDK ones from now

We have number of enums now returned by the SDKs that weren't returned before
as result we getting a lot of incompatibilities between what is in the @rhoas/app-services-ui-shared and actual types returned by SDKs
There are couple ways to solve it:

Manually adjust types that we have in the  rhoas/app-services-ui-shared - In some cases we will be fixing obvious bugs related to lack of typescript validation when dev was done

Add kafka-sdk to app-services-ui-shared and use underlying enums in events/modaltypes etc.

Move kafka type of the logic from app-services-ui-shared back to the Kafka-UI (they seem specific)

We have number of enums now returned by the SDKs that weren't returned before as result we getting a lot of incompatibilities between what is in the @rhoas/app-services-ui-shared and actual types returned by SDKs
There are couple ways to solve it:

Manually adjust types that we have in the  rhoas/app-services-ui-shared - In some cases we will be fixing obvious bugs related to lack of typescript validation when dev was done

This is not ideal but we ca fix issues for now temporary

Add kafka-sdk to app-services-ui-shared and use underlying enums in events/modaltypes etc.

This option is straight forward and permanent solution if there is not any concern.

Move kafka type of the logic from app-services-ui-shared back to the Kafka-UI (they seem specific)

We can move kafka type of logic back to kafka-ui but it will be bit major changes . There are some common logic related to modals logic used in multiple modules kas-ui, kafka-ui, srs-ui etc.
Similarly we copied some types (acls types) in ui-components repo due to concern of using kafka-sdk.
Let's discuss more about it offline.

Similarly we copied some types (acls types) in ui-components repo due to concern of using kafka-sdk.

This was not the correct thing to do. The rule of not depending on the SDKs on the shared repos is there exactly to avoid this kind of issues. The right thing to do would have been to figure out which data the UI needed to do its job and make that the exported type.
After having done that, in the apps (kafka-ui, kas-ui, etc) we would have written the code required to translate the data coming from the SDKs to the data required by the UI.
In other words, we need to build layers and the code to connect them.  I have asked for an ADR I'd to document this but I don't have one yet. A short description of the layers from the top to the bottom would be:

ui-components - this deals with the visuals. The data is thought in terms of text the user will see. User actions that manipulate the data (delete, save) trigger callbacks that will be handled in a lower layer
(kafka|kas|srs|...)-ui - this layer contains the code that interacts with the SDKs to gather the data required by the UI. It also deals with the routes owned by the app. It's bootstrapped with props coming from the lower layer for actions that are common across all apps (like showing a notification or opening a drawer) plus the data required to work with the SDKs (URLs, tokens, etc).
At least one federated module is exposed by this layer, the app itself. More can be exposed if a feature is expected to be used across services (eg. the Kafka creation dialog).
app-services-ui - the lower layer. It implements features common across the services (eg. a drawer), it deals with the authentication, it deals with the configs and it mounts all the apps on their allotted route, passing them the data required for them to work. It can use the SDKs to figure what kind of features the user has access to.

About the problem at hand, we already discussed offline and defined this order of actions:

enable TS on kafka-ui and kas-ui
remove these clashing types from the shared repo, which means decoupling the modals from the SDK
update kafka-ui and kas-ui to use the new shared repo
upgrade the SDKs on kafka-ui and kas-ui

Each point is a single PR that will have to be validated against the test suite on stage

Superseded by #700


Update S3 Website Endpoints

Update S3 Website Endpoints based on information obtained from:
https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_website_region_endpoints

Thanks, @bduverger!


Fix object leaks caused by unfulfilled yields

Now the stack saved in a GDScriptFunctionState is cleared as soon as the yield() operation is known not to be resumed because either the script, the instance or both are deleted.
This clears problems like leaked objects by eliminating cases of circular references between GDScriptFunctionStates preventing them and the objects they refer to in their saved stacks from being released. As an example, this makes using SceneTreeTimer safer.
Furthermore, with this change it's now possible to print early warnings about yield()s to released script/instances, as now we know they won't be successfully resumed as the condition for that happens. However, this PR doesn't add such messages, to keep the observed behavior the same for the time being.
Also, now a backup of the function name in GDScriptFunctionState is used, since the script may not be valid by the time the function name is needed for the resume-after-yield error messages.
NOTE: This is the version of #38482 for 3.2.
Fixes #37188.

This code is generously donated by IMVU.

Thanks!


Do not deactivate the current audio session on instantiating

When instantiating AudioPlayer() , the currently activated  AVAudioSession is deactivated. So, when starting the app, it stops the playback from other apps. This is not how apps like Apple Music or Podcasts behave.
Please have AudioPlayer() not close the current Audio-Sessions during initialization, so that one can instead activate it before calling the play() command.

Apart for the Example project, the library itself does not contain any code in regards to AVAudioSession configuration etc.
AVAudioSession configuration is entirely up to whoever chooses to use this library. You can read about  AVAudioSession here https://developer.apple.com/documentation/avfaudio/avaudiosession

Right, this is what I do the same as in the example project, setting AVAudioSession.sharedInstance().setActive to true when start playing audio and to false when stop playing. This is why I was suspecting that maybe during the Audio Core initialization the current audio session would be set inactive for some reason.
But the real problem is a different one:
I have stripped everything related to audio from my code now, I only do a var player = AudioPlayer() at program start, which alone leads to stopping any current playing audio from other apps then.
Do I have to configure something before I instantiate AudioPlayer() or could there be potentially something happening during the librarie's audio core init process that shuts down the audio which is currently played by other apps?

I encountered the same issue as @haecksenwerk , it's unclear to me which part of the initialization code inside AudioPlayer() caused background audio to stop. @haecksenwerk did you get a chance to look into that? if not I'll do some further debugging.

This is the line (153) in AudioPlayer.swift:
        frameFilterProcessor = FrameFilterProcessor(mixerNode: audioEngine.mainMixerNode)

We should replace it with:
        frameFilterProcessor = FrameFilterProcessor(mixerNode: AVAudioMixerNode())

@iDevelopper Replacing that would mean the filtering will not apply on the playing audio though...

@junyaninflection I haven't looked into the issue any further

@dimitris-c @iDevelopper @haecksenwerk could you review if this PR make sense ? @iDevelopper does pinpoint the root cause and all I'm doing in this PR is deferring the access of mainMixerNode.


GEODE-6451 CI Failure: Hang cleaning up after ClusterConfigLocatorRes…

…tartDUnitTest.serverRestartsAfterLocatorReconnects
Removed code that scrubbed the current membership view of IDs matching a
new join request.  This code is no longer needed now that we generate a
new UUID for a member when it tries to auto-reconnect.  The new ID of
such a member would never match an old ID.
In practice this code was causing test failures in situations where the
auto-reconnect time was set to a small value.  A member would end up
sending multiple join requests to the same coordinator.  The first would
be used to allow the new member into the cluster but the second, due to
this code, would cause that member to be immediately removed from the
cluster.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Pushing changes for GEODE-5676 to be tested here.  Log messages starting with "BRUCE:" will be removed before merging to develop.


Update https.md

Previous version of tutorial is outdated because certbot-auto is deprecated.
I forgot to say you don't need to restart The Lounge after certificate renewal. :/
Tested on Ubuntu 20.04 VPS. Hence apt is my package manager.

Closing this, as it seems stalled and is too distro specific to be merged as is.


chore(configs): Temporarily disable security audit in CI

Purpose
The security audit currently produces an error (https://github.com/IBM/audit-ci/issues/103), causing CI to wrongly fail.
Approach and changes

Temporarily disable security audit in CI

Definition of done

[x] Development completed
[x] Reviewers assigned
[x] Unit and integration tests
[x] Meets minimum browser support
[x] Meets accessibility requirements

:tada: This PR is included in version 1.1.0-canary.1 :tada:
The release is available on:

npm package (@canary dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support nesting with cause

I'm building an application which really needs nested errors. The fs can throw, but in my application just seeing what failed isn't enough to understand what action was being attempted when a failure occurred. Instead I must catch the source error, attach some additional context, and rethrow.
I'd like to be able to attach the original error as a cause. Spec-level support for this is already underway. A shim has been published as well, but while it can get a cause property set up correctly, it doesn't contain any logic about rendering causes. This library has an opportunity to be the first to present such information in a useful way and kickstart the community's ability to use this feature.
I'm going to make a fork and see what I can do.

The only slight problem is that my personal temptation is to hard fork it as I don't know coffeescript and I don't want to.

Supporting cause sounds like a good idea!
As to coffeescript, I'll be happy to merge back TS or ESNext :)


Problem editing resources when using emacs

Get this error after I started using kubecolor. My editor is emacs running as daemon.
$ k edit deployments.apps unleash
emacsclient: could not get terminal name
emacsclient: error executing alternate editor ""
error: there was a problem with the editor "emacsclient -t"

@Kyrremann
Hi, can you update kubecolor to the latest (go get -u github.com/dty1er/kubecolor/cmd/kubecolor) then try again? I think I fixed the problem

Can confirm that it works on my machine! Thanks for the help!


Updated Io_SharedAdc

Summary

Updated shared ADC
Changelist

Testing Done

Resolved Issues

Checklist
Please change [ ] to [x] when you are ready.

[ ] I have read and followed the code conventions detailed in README.md (This will save time for both you and the reviewer!).
[ ] If this pull request is longer then 500 lines, I have provided explicit justification in the summary above explaining why I cannot break this up into multiple pull requests (Small PR's are faster and less painful for everyone involved!).

@pasitlaothamatas Can you update the summary of the PR explaining the changes you made and why. Im assuming the main motivation is for when we need to use more than one ADC peripheral and in that case we need to call HAL_ADC_Start_DMA() on each ADC peripheral as well as have a buffer array for each ADC

When using two ADCs you could also configure it in Multi-mode:

It appears if you're using two ADCs simultaneously then you must use the multimode-specific DMA functions. Imo we should just limit this PR to be using one ADC, otherwise this will never end. Just remove MAX_NUM_OF_ADC and hard code it as 1, and leave a note in the jdocs saying that this is assuming one ADC without multi-mode.

Imma close this

After offline discussion, this PR is being replaced by #614


feat: add unit and class for specific gravity trend

Payload parsed by the rapt_ble integration now includes trend of the specific gravity change (documented in https://github.com/sairon/rapt-ble/commit/7bef92fc3c1439a1d2c9180411aa695883c954a3). This PR adds new unit and device class for these metrics.

@bdraco Before I added rapt_ble integration to the Core, tilt_ble was the only integration using SPECIFIC_GRAVITY too. But I agree that this one will likely stay unique for RAPT devices.
So what you're suggesting is to use SensorDeviceClass and Units as base classes for a library-specific enums, which will be used in my code and tests, correct?

@bdraco Before I added rapt_ble integration to the Core, tilt_ble was the only integration using SPECIFIC_GRAVITY too. But I agree that this one will likely stay unique for RAPT devices.
~So what you're suggesting is to use SensorDeviceClass and Units as base classes for a library-specific enums, which will be used in my code and tests, correct?~
D'oh, just realized that subclassing enums is forbidden (PEP 435), so I will actually need to define own enums for the purpose of the integration. So should I go that way?

Yes, you'll have to copy the enum since enums can't be subclasses (kinda annoying... )

OK, could be done like this: https://github.com/sairon/rapt-ble/blob/bc626eb736cef0d16acc6803a8ea09d472a51dfa/src/rapt_ble/custom_state_data.py
Obviously mypy hasn't issues with the fact that update_sensor is getting device_class that is actually not its own SensorDeviceClass as specified in the type hints, but linter in PyCharm doesn't like if it's named differently, so I used the original names for custom enums. I can't really say I like this approach but if you prefer it rather then spamming sensor_state_data library with exotic units and classes, I can live with that.

OK, could be done like this<EMAIL_ADDRESS>Obviously mypy hasn't issues with the fact that update_sensor is getting device_class that is actually not its own SensorDeviceClass as specified in the type hints, but linter in PyCharm doesn't like if it's named differently, so I used the original names for custom enums. I can't really say I like this approach but if you prefer it rather then spamming sensor_state_data library with exotic units and classes, I can live with that.

I don't really love it either but I also don't want to keep adding to this library unless we have at least 2-3 integrations that need it to keep it from growing into something unmanageable.

Understood. I will add a link to this PR to the code so it's clear I wasn't crazy when I implemented it like that :) We can close it here, I will do some more tests of the new sensor and create a Core PR later. Thanks!


[Dropdown] - Set new dropdown value in 'onChange' event does not work.

Hi, I'm new to use Semantic-UI for few days. I have a mutil-dropdown list with an event that when choose element has data-value "all", it will remove all current selected elements and set only "all".
    $('#my-locations-picker')
        .dropdown({
            onChange: function (val, text, element) {
                var listCount = val.split(',');
                if (listCount.indexOf('all') == -1) {
                    //another case
                } else {
                    // this code does not work and create stack overflow error
                    $('#my-locations-picker').dropdown('set exactly', 'all');
                }
            }
        })
    ;

My code "set value" works on console browser, but when I put it on "onChange()" event, it creates a loop to stack overflow error. Anyone can help me out of this bug ? Thank you.

Please fork the link in the readme to create a jsfiddle demonstrating your bug.

Sorry for late reply. Here is the fiddle link

Hi, that snippet doesnt have any of the libraries included so the result is not appearing.
Please fork the jsfiddle from the readme to have a default test case. You should remove meteor dependencies as a test case should represent the minimum code required to reproduce hthe bug.

Closing until there's a test case.


Rename the repo to jupyterlab-desktop?

Problem
"App" is sometimes also used for web apps, and we have sometimes used the term "lab-based apps" to refer to web applications built with JupyterLab components.
To make it more explicit, maybe we should rename the repo to jupyterlab-desktop? Or jupyterlab-desktop-app?
Proposed Solution
If we decide to do the rename then it's probably just:

the name of the repo
the title in the README

Additional context

I like jupyterlab-desktop, worth bringing up in today's meeting

I also like jupyterlab-desktop - more descriptive of what it is (app is generic)

FWIW I also like jupyterlab-desktop, but mostly I just wanted to chime in here and say that I think this re-energized repository is amazing

Sounds good to me as well! we might also want to name the product as JupyterLab Desktop.


No module named 'scripts.tapswap'

C:\Users\root\Desktop\All-In-One-main>python app.py
Traceback (most recent call last):
File "C:\Users\root\Desktop\All-In-One-main\app.py", line 5, in
from scripts.tapswap import TapSwap
ModuleNotFoundError: No module named 'scripts.tapswap'
I get this error when I start the bot

I think you don't have the scripts folder.

https://github.com/Poryaei/All-In-One/tree/main/scripts

I turned off the values of tapswap and hamster kombat bot in the config file, could that be why?

No

There are no missing files in the scripts

What is your Python version? Let me try to run it on that version.

You deleted the scripts files!

Just change config.json for turn off

It's my fault, I'm sorry for wasting your time.

Don't say it like that! Feel free to ask if you have any questions, and if there's no problem, let's close the issue.


[executor] stop using storage-server and storage-client (trait StorageRead) in tests

Motivation
Those are to be deprecated.
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
existing tests converted.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r=wqfish

:pushpin: Commit 9112fc9 has been approved by wqfish

:hourglass: Testing commit 9112fc9903593b114f9cc71eb2a64c2fda7988c2 with merge 05c3cef9609599ce2dd751e69f55acdfcf1dfa83...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wqfish
Pushing 05c3cef9609599ce2dd751e69f55acdfcf1dfa83 to master...


Add stable and beta to travis config

Supersedes #430

Merging since the tests runs in parallel. https://github.com/PistonDevelopers/image/pull/430#issuecomment-123662754


Topic 6: REST & Spring

Nice work Matias, please always remember to add javadocs and format the code before sending


LLEXT/Xtensa/detached: disable FLIX commands and link once

this is just two commits on top of #80626 - it will be rebased once it's merged.

I love this 🚀 (TBH, never understood the reason for disabling only a specific a class of relocations in the first place). I think it's another step in the right direction for Xtensa!
With this PR relocate_local does not do what its name suggests anymore. I would suggest to go one step further and add a different parameter, skip_relocation, and skip the link process if either is not the default value, This would give a few advantages:
* we could deprecate the now confusingly named `relocate_local` in a future release (once SOF updates);

* once that is deprecated, all load_params would default to 0, so you could directly initialize a proper config with only your needed fields (`struct llext_load_param cfg = { .nonzero = 1 }`).

@teburd what do you think about this?

I think load_param as a way of trying to direct llext_load is the wrong approach to solving SoF's problem. I re-iterate my stance here, I believe exposing more verbs (functions) is the better route, and will lead to simpler code everywhere. I keep thinking about this, and I keep thinking we've taken a mis-step somewhere to lead to having SoF adding these flags, and having to do work itself rather than providing the tools to make it happen.
llext_load should be the Easy Button, not the it does everything function.
We should support custom allocation and placement strategies, but not with the same function that gets overloaded with flags that lead to confusing branching in the load path.
My recommendation here would be to add some small state tracking to the extension. Noting where the sections are to be placed, where the source material is, and if they have been copied or not. Having instead a set of functions that basically do what SoF does today but in a more general and broadly useful way.
E.g. perhaps some functions like the following...
/**
 * @brief Link the extension with itself and others
 *
 * Assumes the address of each ELF section is given by dest_addrs and uses this memory
 * location as if the ELF section were already located there while linking. The address
 * of the sections may be the same as the destination address.
 *
 * Assumes that the sections are available in the extension already and are writable.
 *
 * @retval -EINVAL if any destination addresses are invalid
 */
int llext_link(struct llext *ext, void *dest_addrs[LLEXT_MEM_COUNT]);

(copy the map, link the elf with the destination addresses in mind, could be the same as the source address!)
and llext_copy, would presume that the destination addresses are already allocated and would take a slotmap of what to copy
/**
 * @brief Copies (without allocating) any sections marked to be copied in the slot map|
 *
 * Copies any sections marked in the copy_sect slot map to their destination addresses
 * if the source and destination addresses are not equal.
 *
 * Assumes no overlap
 *
 * @retval -EINVAL if any source overlaps with any destination
 */
int llext_copy(struct llext *ext, bool copy_sect[LLEXT_MEM_COUNT]);

Adding and allocating the struct llext in its initial state can be done in a separate function.
/**
 * @brief Initialize, parse, and add an extension
 *
 * Initializes an allocation llext struct with a pointer to an elf data source.
 */
int llext_mem_init(struct llext *ext, const void * const elf);

Now the sof code...
https://github.com/thesofproject/sof/blob/main/src/library_manager/llext_manager.c#L107
Can look more like its using llext rather than trying to work around everything.
llext_manager_load(...) {
   llext_copy(...)
}

llext_manager_link(...) {
   llext_link(...)
}

llext_manager_allocate_module(...) {
   struct llext *ext = /* sof allocated extension struct */
   llext_mem_init(...);
}

All memory allocation is now directly expected to occur in SoF code as it already does. And SoF code is completely in control over the flow as it already is.
The llext_load() function can remain being an Easy Button option for things like the shell, demos, and a good starting point for anyone not interested in custom placement and allocation. We can also completely drop the buf loader idea, maybe in fact dropping the loader as a whole and instead expecting people to provide a pointer to the ELF data. The FS loader feels misguided at this point given the way people are actually using this stuff.

My question was very much related to this PR and how to move LLEXT forward incrementally: deprecate or live with legacy choices?
Your proposal is instead a rather sizable effort and a major API change. You should make an RFC from that post so we can discuss it in more detail (I am not opposed, though I remain kinda skeptical about the benefits), I didn't see an answer in there, but I guess the approval is my clue! :sweat_smile:

The FS loader feels misguided at this point given the way people are actually using this stuff.

Not sure I understand this part. Do we have real-world examples of LLEXT use (or specifically of the FS loader) that abuse something in the API?

My question was very much related to this PR and how to move LLEXT forward incrementally: deprecate or live with legacy choices?
Your proposal is instead a rather sizable effort and a major API change. You should make an RFC from that post so we can discuss it in more detail (I am not opposed, though I remain kinda skeptical about the benefits), I didn't see an answer in there, but I guess the approval is my clue! 😅

Agreed, I've been mentally building the picture up of how this might look. I'll try and gather my thoughts by the end of the year on all this.

The FS loader feels misguided at this point given the way people are actually using this stuff.

Not sure I understand this part. Do we have real-world examples of LLEXT use (or specifically of the FS loader) that abuse something in the API?

It's more this discrepancy with the file like API the loader provides vs how LLEXT is actually being used. I didn't mean to speak of the fs loader itself but the API the loader provides being file-like rather than memory-like.

E.g. perhaps some functions like the following...

@teburd shall we move this to a "feature?" Yes, if we could do as you describe above in SOF, which would supposedly mean preserving what currently is the loader context for the entire life-time of the extension, that would stream-line it a good deal.


Error generating Video

I have this error when try to generate video
I had an error before with Cuda but execute this line of code
pip install torch==2.3.0 torchvision torchaudio xformers --index-url https://download.pytorch.org/whl/cu121
Unload to CPU: AutoencoderKL
Load to GPU: CLIPTextModel
Unload to CPU: CLIPTextModel
Load to GPU: ModifiedUNet
Unload to CPU: ModifiedUNet
Load to GPU: AutoencoderKL
Unload to CPU: AutoencoderKL
Load to GPU: CLIPTextModel
Unload to CPU: CLIPTextModel
Load to GPU: ImprovedCLIPVisionModelWithProjection
Load to GPU: Resampler
Traceback (most recent call last):
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\gradio\queueing.py", line 528, in process_events
    response = await route_utils.call_process_api(
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\gradio\route_utils.py", line 270, in call_process_api
    output = await app.get_blocks().process_api(
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\gradio\blocks.py", line 1908, in process_api
    result = await self.call_function(
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\gradio\blocks.py", line 1485, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "C:\Users\scool\AppData\Roaming\Python\Python310\site-packages\anyio\to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
  File "C:\Users\scool\AppData\Roaming\Python\Python310\site-packages\anyio\_backends\_asyncio.py", line 2144, in run_sync_in_worker_thread
    return await future
  File "C:\Users\scool\AppData\Roaming\Python\Python310\site-packages\anyio\_backends\_asyncio.py", line 851, in run
    result = context.run(func, *args)
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\gradio\utils.py", line 808, in wrapper
    response = f(*args, **kwargs)
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\torch\utils\_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "I:\Paints-UNDO\gradio_app.py", line 222, in process_video
    frames, im1, im2 = process_video_inner(
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\torch\utils\_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "I:\Paints-UNDO\gradio_app.py", line 183, in process_video_inner
    positive_image_cond = video_pipe.encode_clip_vision(input_frames)
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\torch\utils\_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "I:\Paints-UNDO\diffusers_vdm\pipeline.py", line 93, in encode_clip_vision
    frames = einops.rearrange(frames, 'b c t h w -> (b t) c h w')
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\einops\einops.py", line 591, in rearrange
    return reduce(tensor, pattern, reduction="rearrange", **axes_lengths)
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\einops\einops.py", line 518, in reduce
    backend = get_backend(tensor)
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\einops\_backends.py", line 55, in get_backend
    if backend.is_appropriate_type(tensor):
  File "C:\Users\scool\.conda\envs\paints_undo\lib\site-packages\einops\_backends.py", line 408, in is_appropriate_type
    return isinstance(tensor, (self.tf.Tensor, self.tf.Variable))
AttributeError: module 'tensorflow' has no attribute 'Tensor'

If you update the version of torch, the versions of other libraries must also be updated to match the new version of torch.
This can be a complicated problem for people who have no experience in deep learning, so I recommend that you re-install an environment, first install torch using the command pip install torch==2.3.0 torchvision torchaudio xformers --index-url https://download.pytorch.org/whl/cu121,
Then install other libraries and they will automatically match your torch version

I would recommend to use VENVs if possible and maintain the dependencies of each application separate, that way you will avoid causing issues due to incompatible versions of the libraries

I try again and the same error come out, and when install i have this message
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. albumentations 1.3.1 requires scipy>=1.1.0, which is not installed. basicsr 1.4.2 requires opencv-python, which is not installed. basicsr 1.4.2 requires scipy, which is not installed. basicsr 1.4.2 requires tqdm, which is not installed. facexlib 0.3.0 requires opencv-python, which is not installed. facexlib 0.3.0 requires scipy, which is not installed. facexlib 0.3.0 requires tqdm, which is not installed. filterpy 1.4.5 requires scipy, which is not installed. gfpgan 1.3.8 requires opencv-python, which is not installed. gfpgan 1.3.8 requires scipy, which is not installed. gfpgan 1.3.8 requires tqdm, which is not installed. insightface 0.7.3 requires onnx, which is not installed. insightface 0.7.3 requires scipy, which is not installed. insightface 0.7.3 requires tqdm, which is not installed. jax 0.4.24 requires scipy>=1.9, which is not installed. keras-nightly 3.0.4.dev2024021403 requires rich, which is not installed. opennsfw2 0.10.2 requires opencv-python>=<IP_ADDRESS>, which is not installed. opennsfw2 0.10.2 requires tensorflow>=2.0.0, which is not installed. opennsfw2 0.10.2 requires tqdm>=4.62, which is not installed. scikit-image 0.22.0 requires scipy>=1.8, which is not installed. scikit-learn 1.4.0 requires scipy>=1.6.0, which is not installed. tb-nightly 2.16.0a20240212 requires protobuf!=4.24.0,>=3.19.6, which is not installed. tf-nightly-intel 2.17.0.dev20240213 requires protobuf!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.20.3, which is not installed.


[SPARK-2666] when task failed with FetchFailed it need to cancel running tasks of failedStage

in DAGScheduler's handleTaskCompletion,when task failed with FetchFailed reason, it need to cancel running tasks of failedStage before add failedStage to failedStages queue.

@lianhuiwang This PR has gone stale. Do you mind updating it so that tests pass and it merges cleanly, or are you waiting for feedback from a committer?

ok, i will update based on new code base.


Adding protected enum field to our table crashes VS Code AL Extension

1. Describe the bug
We created a table and want to add a field with Type enum. The enum in question is a run of the mill extensible enum without any protection level. When that field gets added everything works but as soon as the protection level of said field is changed to protected we get the following error:
Internal error: System.AggregateException: One or more errors occurred. (Unable to cast object of type 'Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceModuleSymbol' to type 'Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.TypeSymbol'.)
---> System.InvalidCastException: Unable to cast object of type 'Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceModuleSymbol' to type 'Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.TypeSymbol'.
at Microsoft.Dynamics.Nav.CodeAnalysis.AccessCheck.IsFieldAccessible(FieldSymbol field, Symbol within, TypeSymbol throughTypeOpt, LookupOptions options, Compilation compilation) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Semantics\AccessCheck.cs:line 247
at Microsoft.Dynamics.Nav.CodeAnalysis.BuckStopsHereBinder.IsAccessibleHelper(Symbol symbol, TypeSymbol accessThroughType, LookupOptions options, Boolean& failedThroughTypeCheck, HashSet1& useSiteDiagnostics) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\BuckStopsHereBinder.cs:line 79    at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.CheckViability(Symbol symbol, LookupOptions options, TypeSymbol accessThroughType, Boolean diagnose, HashSet1& useSiteDiagnostics, BoundExpression receiver) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder.cs:line 1050
at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.LookupMembersWithoutInheritance(LookupResult result, TypeSymbol type, String name, LookupOptions options, Binder originalBinder, TypeSymbol accessThroughType, Boolean diagnose, HashSet1& useSiteDiagnostics, BoundExpression receiver) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder_Lookup.cs:line 395    at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.LookupMembersInClass(LookupResult result, TypeSymbol type, String name, BoundExpression receiver, LookupOptions options, Binder originalBinder, Boolean diagnose, HashSet1& useSiteDiagnostics, ApplicationObjectExtensionTypeSymbol excludedExtension) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder_Lookup.cs:line 281
at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.TryGetFieldByNameOrId(TableTypeSymbol relatedTable, Int32 fieldId, String unquotedRelatedFieldName, FieldSymbol& fieldSymbol) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder_Properties.cs:line 1809
at Microsoft.Dynamics.Nav.CodeAnalysis.TableExpressionContext.TryGetSymbolByNameOrId(Boolean bindOnSource, Int32 symbolId, String unquotedSymbolName, ISymbolWithType& symbol) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\TableExpressionContext.cs:line 73
at Microsoft.Dynamics.Nav.CodeAnalysis.BoundPropertyExpressionFactory1.CreateLhsForCondition(IdentifierNameSyntax leftHandSide, DiagnosticBag diagnostics) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\BoundPropertyExpressionFactory.cs:line 144    at Microsoft.Dynamics.Nav.CodeAnalysis.BoundPropertyExpressionFactory1.CreateBoundPropertyValueExpressionFromRhs(SyntaxNode rhs, DiagnosticBag diagnostics, String lhsIdentifierName) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\BoundPropertyExpressionFactory.cs:line 239
at Microsoft.Dynamics.Nav.CodeAnalysis.BoundPropertyExpressionFactory1.CreateRhs(SyntaxNode rightHandSide, String leftHandSideName, DiagnosticBag diagnostics) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\BoundPropertyExpressionFactory.cs:line 89    at Microsoft.Dynamics.Nav.CodeAnalysis.BoundPropertyExpressionFactory1.CreateExpression(IdentifierNameSyntax leftHandside, SyntaxNode rightHandside, DiagnosticBag diagnostics) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\BoundPropertyExpressionFactory.cs:line 73
at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.BindPropertyExpressions(SyntaxNode ownerSyntax, PropertyTypeInfo info, SeparatedSyntaxList1 propertyExpressions, ExpressionContext expressionContext, CompilationOptions options, DiagnosticBag diagnostics, Boolean& hasErrors) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder_Properties.cs:line 2701    at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.BindTableFilterStatement(TableFilterPropertyValueSyntax propertyValue, PropertyTypeInfo info, DiagnosticBag diagnostics) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder_Properties.cs:line 2123    at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.GetBoundPropertyValue(PropertySyntax syntax, DiagnosticBag diagnostics, PropertyValueSyntax propertyValue, PropertyTypeInfo info) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder_Properties.cs:line 182    at Microsoft.Dynamics.Nav.CodeAnalysis.Binder.BindProperty(PropertySyntax syntax, DiagnosticBag diagnostics) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Binder\Binder_Properties.cs:line 111    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourcePropertySymbol.LazyGetProperty() in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourcePropertySymbol.cs:line 180    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourcePropertySymbol.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourcePropertySymbol.cs:line 125    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceControlSymbol.ForceCompleteProperties(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourceControlSymbol.cs:line 226    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceControlSymbol.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourceControlSymbol.cs:line 172    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceControlSymbol.ForceCompleteMembers(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourceControlSymbol.cs:line 246    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceControlSymbol.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourceControlSymbol.cs:line 182    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.ObjectMembers1.ForceMembersCompleteAndCheckUniqueness(SourceLocation locationOpt, DiagnosticBag diagnostics, CancellationToken cancellationToken, Predicate1 excludeFromNameUniqueness) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Members\ObjectMembers.cs:line 175    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.ObjectMembers1.ForceCompleteMembers(SourceLocation locationOpt, CancellationToken cancellationToken, Predicate1 excludeFromNameUniqueness) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Members\ObjectMembers.cs:line 1183    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.ObjectMembers1.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken, Predicate1 excludeFromNameUniqueness) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Members\ObjectMembers.cs:line 1103    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourcePageTypeSymbol.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourcePageTypeSymbol.cs:line 52    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceNamespaceSymbol.<>c__DisplayClass47_1.<ForceComplete>b__0(Int32 i) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourceNamespaceSymbol.cs:line 806    at System.Threading.Tasks.Parallel.<>c__DisplayClass19_01.b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
--- End of stack trace from previous location ---
at System.Threading.Tasks.Parallel.<>c__DisplayClass19_01.<ForWorker>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)    at System.Threading.Tasks.TaskReplicator.Replica.Execute()    --- End of inner exception stack trace ---    at System.Threading.Tasks.TaskReplicator.Run[TState](ReplicatableUserAction1 action, ParallelOptions options, Boolean stopOnFirstFailure)
at System.Threading.Tasks.Parallel.ForWorker[TLocal](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action1 body, Action2 bodyWithState, Func4 bodyWithLocal, Func1 localInit, Action1 localFinally) --- End of stack trace from previous location ---    at System.Threading.Tasks.Parallel.ThrowSingleCancellationExceptionOrOtherException(ICollection exceptions, CancellationToken cancelToken, Exception otherException)    at System.Threading.Tasks.Parallel.ForWorker[TLocal](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action1 body, Action2 bodyWithState, Func4 bodyWithLocal, Func1 localInit, Action1 localFinally)
at System.Threading.Tasks.Parallel.For(Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action1 body)    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceNamespaceSymbol.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourceNamespaceSymbol.cs:line 806    at Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceModuleSymbol.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken) in D:\a\_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Symbols\Source\SourceModuleSymbol.cs:line 100    at Microsoft.Dynamics.Nav.CodeAnalysis.Compilation.GetSourceDeclarationDiagnostics(SyntaxTree syntaxTree, Nullable1 filterSpanWithinTree, Func`4 locationFilterOpt, CancellationToken cancellationToken) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Compilation\Compilation.cs:line 1260
at Microsoft.Dynamics.Nav.CodeAnalysis.Compilation.GetDiagnostics(CompilationStage stage, Boolean includeEarlierStages, CancellationToken cancellationToken) in D:\a_work\1\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Compilation\Compilation.cs:line 784
2. To Reproduce
We sadly can't reproduce this error in a small sample extension. For further details see the screenshot under 4. Since this is happening in our product code we can't just openly publish the source code to GitHub. We also raised a ticket TrackingID#2308160010009365 and were told to open an issue here, since a demo app isn't mandatory here. I am available for a Teams call to showcase this error in action.
3. Expected behavior
No error should be thrown and we should be able to build the extension.
4. Actual behavior
Without protection level:

As soon as the field gets set to protected:

Here the Enum in question:

5. Versions:

AL Language: v12.0.847725 (tried both release and pre-release)
Visual Studio Code: 1.81
Business Central: 22.4
List of Visual Studio Code extensions that you have installed: None except the AL extension.

This will be released with the next 23 VSIX and with the next pre-release, whichever comes first


http2 check should not use process.version

Super agent as check where it automatically use http2 by just checking node version. This is not a good idea as like us people might have custom version of node that compile out certain features of node. A check like typeof process.versions.nghttp2 !== undefined could be better way of telling if node support http2 or not.
Thanks

PR welcome


Makefile seems to incorrectly disable ALPN when using system openssl

Hit this when investigating https://github.com/grpc/grpc-java/issues/2720
It seems this makefile check is backwards? (checked against branch v1.1.2, still look there on master). It's causing ALPN support to be compiled out, even though the makefile correctly detects for support.
diff --git a/Makefile b/Makefile
index d9d7f40..31c5437 100644
--- a/Makefile
+++ b/Makefile
@@ -725,10 +725,10 @@ LDFLAGS := $(LDFLAGS_OPENSSL_PKG_CONFIG) $(LDFLAGS)
 else # HAS_PKG_CONFIG=false
 LIBS_SECURE = $(OPENSSL_LIBS)
 endif # HAS_PKG_CONFIG
-ifeq ($(HAS_SYSTEM_OPENSSL_NPN),true)
+ifneq ($(HAS_SYSTEM_OPENSSL_ALPN),true)
 CPPFLAGS += -DTSI_OPENSSL_ALPN_SUPPORT=0
 LIBS_SECURE = $(OPENSSL_LIBS)
-endif # HAS_SYSTEM_OPENSSL_NPN
+endif # HAS_SYSTEM_OPENSSL_ALPN
 PC_LIBS_SECURE = $(addprefix -l, $(LIBS_SECURE))
 endif # EMBED_OPENSSL
 endif # NO_SECURE

Closing as stale. Please reopen if still relevant.


Draft for Rule 10

Here is an initial draft for Rule 10.
There might be material in it that belong to other rules. Let me know if you think it's the case.
@naupaka and @emhart let me know if I captured all the concepts you were hoping this rule would cover.
Note that I didn't commit the manuscript here as the compilation fails on my system (probably issue with version of pandoc) and I haven't had a chance to investigate.
Cheers!

This captures the main idea well--I think it is probably (?) should be noted that tidy data in Hadley's sense is most applicable to delimited text data (tsv/csv), and that the structure of observations might be very different with hdf5 or netCDF, for example, although both of the latter could also be considered machine readable as long as their data structures are set up properly in some standard fashion. And I just thought of this, but do we talk anywhere about storing data in the short or long term in a relational database (and the pros/cons)?

Perhaps focus on 'normalized' rather than 'tidy' data. Is tidy a special case of normalized? Does the definition always hold that tidy = less repitition? Is tidy a recent @hadley term, or a general, robust concept like normalization?

I think @fmichonneau means it in the sense of Hadley's paper (which he cites)
I suppose in this case 'tidy' is a particular subset of 'normalized'.

This might be overly pedantic, but I'm not sure CSV qualifies as a format that has clear specifications. There is RFC 4180, but in practice there are many formats that get called CSV but aren't compatible. This isn't an argument to remove CSV/TSV from the list of suggested file formats, but should we call attention to the lack of a common standard and/or suggest that people create CSVs that adhere to RFC 4180?

Tidy data is (pretty much exactly) Codd's 3rd normal form, but framed in a way that most people can actually understand.

@karawoo This paper could be a good opportunity to promote RFC 4180 (one of my personal favourites). In Rule 4 probably.

Thanks all for your comments!

I am not familiar enough with hdf5 and netCDF to know if it makes sense to use the tidy concept for data stored in this kind of format.
I don't think we talk about the pros/cons of data formats for the different stage of the analytical process. Maybe it could be covered by Rule 2 (#32)? I am going to create a new issue to make sure it doesn't get forgotten
I'll add a mention about normalized data in the next revision of the text.
@karawoo it might be pedantic, but I agree. CSV files can take many shapes and forms. Let's talk about RFC4180 in the Rule 4 (#34). My point here was to use data formats that can be imported in a variety of computing environment without having to write a parser for it.

:+1:

Tidy data is (pretty much exactly) Codd's 3rd normal form, but framed in a way that most people can actually understand.

Thanks @hadley for the clarification. I think it will be useful to provide this context.

@fmichonneau Nice work on this, I think it's coming  together well.  Just a couple of thoughts on some of the other formats.  NetCDF and HDF5 formats don't necessarily take on the form of "tidy" data you refer to.  My reading is that tidy data is a way of having well arranged data for a single flat file.  However NetCDF is conventionally a gridded format where each cell can be thought of as a z value in a 2-D x-y grid.  HDF5 files can take this form too, however they also can be used to store files in a nested format analogous to a directory structure (but not necessarily).  Here's an ecological example far clarification.  Let's say I'm measuring DBH at different sites in different regions.  I might store that data in HDF5 like this:
Region1/
|- SiteA/
|- Tree1, 4.5
|- Tree2, 3.9
|- Tree3, 2.6
If I want to analyze this data in a nice Tidy flat file it would be something like
Region1    SiteA   Tree1   4.5
Region1    SiteA   Tree2   3.9
Region1    SiteA   Tree3   2.6
I think there's a couple of other things to consider in this section:
1). Are all open formats by definition machine readable?   E.g. Are all ascii formats machine readable (because they are ascii), or only ones that adhere to a standard?
2). What about databases?  Is MySQL an a machine readable format?  Or would we only want to recommend databases that can be exported  (I'm thinking about how CouchDB just stores data in JSON). Is HDFS a machine readable format? It's an open source standard.
3). A slightly clearer definition of what "machine readable" means exactly.  Is it using an open format with a standard?  Has embedded metadata?  I wish I had more insight, I'm still trying to wrap my head around it.

Perhaps a key point is "for smaller datasets, use flat files because they are easy and accessible". I propose a definition and methods for handling bigger data issues in rule 9 (#39)
Are databases or NetCDF useful for small datasets? I am not sure, except where the small dataset is a subset of a larger one that is already stored in NetCDF or a database.
To clarify a few points made by @emhart, though:

as of v4, netCDF is a front-end to HDF5, ie. in many ways they are the same, and can use many of the same tools (e.g. NCO) for computing 'on disk' and across similar variables in the data heirarchy (e.g. from different members of a stochastic simulation or model ensemble).
In principle, i am not sure if there is a difference between what these can do and a RDBMS, except that HDF5/NetCDF4 can be optimized for raster / spatial data
both of these have arbitrary levels of hierarchy, and both work well with gridded data
the number of dimensions can be high (climate data provided in this format generally have latitude, longitude, height and time dimensions for each of many variables in a raster)

In this example,
Region1/
|- SiteA/
|- Tree1, 4.5
|- Tree2, 3.9
|- Tree3, 2.6

This is the same representation (right?) as can be done in HDF5 or CSV as shown above or in a three-table relational database (tables regions, sites, trees with each region having >= 0 sites, and each site having  >= 0 trees).
An alternative representation might be spatially explicit: a recursive PostGIS table in which the geometry column can represent regions and sites as vector polygons and trees as points, supporting queries to locate all trees within some site. Not sure how much of this is useful.
Again, I suggest that for data that fits in memory, such models are less essential than having tidy, i.e. easily useable, data.

I know that "ASCII" is useful shorthand, but it is also jargon, and strictly it refers to a archaic 7-bit code table for unaccented Roman characters. Not all science is done in English. Better to recommend Unicode in general, and UTF-8 in particular.  UTF-8 is of course backwardly compatible with ASCII, or rather, ASCII-encoded data is also UTF-8 data.


Create deterministic animateFauxDOM

Hi,
Love the lib btw, with the one exception that I don't really like the race between D3 and FauxDOM that occurs when you call animateFauxDOM.  When an transition lasts 1000 ms and you have to call the function with an arbitrary duration and hope if finishes just feels horrible to me.
With this in mind I thought up a scheme that we could write a second, deterministic, animateFauxDOM that uses D3 transition.on("start") and transition.on("end") hooks to update a boolean state variable this.state.animating or something.  Then call an asynchronous function that loops until the variable is false this ensuring the DOM is updated through the duration of the animation, no shorted, no longer.
My Javascript is still pretty amaturish, and I would like to add this myself as a PR, but want to check with you first to see if you think this scheme will even work?

This would be good, I didn't have a hand in the animation code and I didn't implement it in the first place since I wasn't sure how to do it. Anything that involves a state being coordinated could get pretty easily broken if a hook isn't called due to an exception or if someone starts two animations at once.
I haven't used the current animation style, but if there's a simpler, deterministic solution, I'm all ears :smile: maybe try messing with it on a fork and see what you get? No harm done if not, if you get something you think is on the right track I can take a look and discuss it further, no pressure though!
I'm mainly just doing small maintenance tasks for this project at the moment, so I'm not thinking in terms of large changes.

So I'm not going to do anything about this right now, but I'm going to leave it open because it's a good idea and should probably happen at some point. It's just outside of my (personal) scope right now. If anyone wants to overhaul how animations are supported, be my guest :smiley:

If anyone wants to overhaul how animations are supported

I think the best way would be to use Proxy to notify when Elements or style is edited.

Going to close this for now I'm afraid, just not something I have the time or motivation for just right now. If anyone would like to work on this feature I'll be more than happy to talk about it though!


Inconsistent ICD9 and ICD10 codes for avian and novel H1N1 flu

This is the same issue reported here, https://github.com/ohdsi-studies/Covid19CharacterizationCharybdis/issues/53
Just want to rephase: the concept set definition included ICD9 codes with avian and novel H1N1 flu but not those ICD10 codes.

@pbr6cornell to adjudicate. We’ve already had multiple sites contribute results. We generally do not change the package once it’s been disseminated even if there are later identified design issues. We would have to acknowledge these in the discussion sections of subsequent manuscripts.


Add the last steps in the install instruction to enable the plugin

I would like to ask last steps to be added in the readme:
First save your custom Workspace, it will change after we are done.
Go to Settings > Configure Krita. (It will open the Config menu.)
On the Left panel select "Python Plugin Manager"
Add a check to "ComfyUI Plugin" in the checkbox list on the left panel.
Click OK to close "Config menu".
After restarting Krita your Workspace should be populated by new dockers, you can show/hide them in the Settings > Dockers checklist.
Rearrange your Workspace and save it, example "ComfyUI".

Added. Thanks for the contribution!


GitHub Actions stuck with the 6.2.4.RELEASE update

Bug Report
Current Behavior
With the new version (6.2.4.RELEASE) the GitHub Actions is running infinitely for tests.
You can check the behavior on this project
Locally, there is no problem.
Expected behavior/code
The GitHub Actions should be able to run tests like with the 6.2.3.RELEASE
Environment

Lettuce version(s): 6.2.4.RELEASE
Redis version: 7.0.8

Additional context
The project is a Kotlin project using the Coroutine extension of your library.
For tests, test-containers dependency is used to turn on Redis

Seems a netty compatibility issue:
AbstractCacheServiceTest > SetWithExpiration > should set value with expiration() FAILED
    java.lang.IllegalStateException at CoroutineDebugging.kt:46
        Caused by: java.lang.IllegalStateException at BoundedAsyncPool.java:270
            Caused by: io.lettuce.core.RedisConnectionException at RedisConnectionException.java:78
                Caused by: java.util.concurrent.CompletionException at CompletableFuture.java:332
                    Caused by: java.lang.UnsatisfiedLinkError at ErrorsStaticallyReferencedJniMethods.java:-2


"SmartGc memory low or critical region number, restore heap water mark"

Hi, sometimes(NOT ALWAYS) I get a message: "SmartGc memory low or critical region number, restore heap water mark", and my code doesn't run to the end, it returns earlier than the return statement in my code.
pub async fn handle_audio_samples(rust_request: RustRequest) -> RustResponse {
    use crate::messages::audio_samples::{ReadRequest, ReadResponse};

    match rust_request.operation {
        RustOperation::Create => RustResponse::default(),
        RustOperation::Read => {
            /* some code here */
            /* return something  here */
        }
    }
}

The value of successful is false, just like RustResponse::default().
Can I have any way to check why this happens?
Thank you.

Hi @newproplus , may I ask you which version of Rinf you are using?

@temeddix
rinf version is 4.20.0
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.3, on Debian GNU/Linux 12 (bookworm) 6.1.0-15-amd64, locale zh_CN.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.85.0)
[✓] Connected device (3 available)

Sometimes it returns early without any error or message.

Is there a method to monitor the entire lifecycle? This can detect which step may have the problem. Because my project is quite complex, it is not easy to provide source code to reproduce the problem.

Hi @newproplus , sorry for being late, I was busy with various things after christmas.
Do you mind telling me how many requests you are making? Do you use requestToRust function frequently?` if so, are there many 'failed responses' from Rust?

Hello, @newproplus , Rinf version 5 released recently has a new architecture under the hood. Could you try it out and tell me if the problem persists?

@temeddix OK, I'll try it later. Thank you for your great job.

For your information, you need to run rinf template once again if you're coming from Rinf4 :)

Rinf version 6 has a new communication system re-written from scratch, so this problem from version 4 shouldn't be present anymore. The wrapper became even thinner and resources are more efficiently used.
If anyone experiences such problems again with Rinf version 6, please let us know :)


Bad build requirement

I've create a fresh rtd docker image with this Dockerfile:
FROM python:2
ARG proxy
ENV http_proxy=$proxy  \
    https_proxy=$proxy \
    no_proxy="localhost,<IP_ADDRESS>"

RUN git clone --depth=1 https://github.com/rtfd/readthedocs.org.git

WORKDIR readthedocs.org

RUN pip install -r requirements.txt

# Waiting for PR #4206 to be merged
RUN export DEBIAN_FRONTEND=noninteractive; \
  apt-get update && \
  apt-get -y install vim sed
RUN sed -i 's@--use-wheel@--only-binary=:all:@g' readthedocs/doc_builder/python_environments.py

RUN python manage.py migrate

# Create a superuser account for Django
RUN echo "from django.contrib.auth.models import User; User.objects.create_superuser('admin', 'admin@localhost', 'admin')" | python manage.py shell

RUN python manage.py loaddata test_data

CMD [ "python", "./manage.py", "runserver", "<IP_ADDRESS>:8000" ]

All is working well but when i try do build the admin-demo i've got:
[rtd-command-info] start-time: 2018-06-18T14:30:53.320295, end-time: 2018-06-18T14:30:55.243362, duration: 1, exit-code: 0
python2.7 -mvirtualenv --no-site-packages --no-download /readthedocs.org/user_builds/admin-demo/envs/stable
New python executable in /readthedocs.org/user_builds/admin-demo/envs/stable/bin/python2.7
Also creating executable in /readthedocs.org/user_builds/admin-demo/envs/stable/bin/python
Installing setuptools, pip, wheel...done.

[rtd-command-info] start-time: 2018-06-18T14:30:55.288269, end-time: 2018-06-18T14:30:57.922045, duration: 2, exit-code: 1
python /readthedocs.org/user_builds/admin-demo/envs/stable/bin/pip install --only-binary=:all: --upgrade --cache-dir /readthedocs.org/user_builds/admin-demo/.cache/pip Pygments==2.2.0 setuptools<40 docutils==0.13.1 mock==1.0.1 pillow==2.6.1 alabaster>=0.7,<0.8,!=0.7.5 commonmark==0.5.4 recommonmark==0.4.0 sphinx==1.7.4 sphinx-rtd-theme<0.5 readthedocs-sphinx-ext<0.6
Collecting Pygments==2.2.0
  Downloading https://files.pythonhosted.org/packages/02/ee/b6e02dc6529e82b75bb06823ff7d005b141037cb1416b10c6f00fc419dca/Pygments-2.2.0-py2.py3-none-any.whl (841kB)
Collecting setuptools<40
  Downloading https://files.pythonhosted.org/packages/7f/e1/820d941153923aac1d49d7fc37e17b6e73bfbd2904959fffbad77900cf92/setuptools-39.2.0-py2.py3-none-any.whl (567kB)
Collecting docutils==0.13.1
  Downloading https://files.pythonhosted.org/packages/5f/6d/e864b3c61b81eec57386ac62082fccfe694c7c3046d8723258a37da6d5fc/docutils-0.13.1-py2-none-any.whl (537kB)
Collecting mock==1.0.1
  Could not find a version that satisfies the requirement mock==1.0.1 (from versions: 1.1.0, 1.1.2, 1.1.3, 1.1.4, 1.2.0, 1.3.0, 2.0.0)
No matching distribution found for mock==1.0.1

Why the requirement (for mock) is not valid ?

This is because of a regression. See #4261. Closing this in favor of https://github.com/rtfd/readthedocs.org/issues/4262


Fixed couple of not stable Cypress tests

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Tests

Improved test stability for single object annotation by ensuring the absence of certain elements before visibility checks.
Introduced a delay for animation in the organization menu test to enhance reliability.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.37%. Comparing base (f1341d5) to head (f33b9cf).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7937      +/-   ##
===========================================
- Coverage    83.38%   83.37%   -0.01%
===========================================
  Files          380      381       +1
  Lines        40034    40053      +19
  Branches      3769     3769
===========================================
+ Hits         33382    33396      +14
- Misses        6652     6657       +5

Components
Coverage Δ

cvat-ui
79.31% <100.00%> (-0.02%)
:arrow_down:

cvat-server
87.12% <ø> (+<0.01%)
:arrow_up:


Provide network and CPU throttling

Currently synthetics tests results are not representative of the majority of users that visit a specific web application. To better represent a real world situation we should run the tests with CPU and network throttling enabled. We can run the tests multiple times with different CPU/network throttling profiles.
@paulb-elastic @drewpost, IMHO it's preferable to make a decision on throttling while still in the experimental phase since the generated report results will be affect by this.

I completely agree that this is so important.
From a CPU perspective, we need to ensure in the first instance that there is a consistent allocation of CPU resources available for the test to run. We have had some discussions internally about this, and it’s listed as a requirement for GA (https://github.com/elastic/synthetics/issues/93), being able to provide a consistent CPU boundary for both on prem and within cloud.
The most important thing in the first instance is to ensure consistency of the resources available, which dovetails from protecting against noisy neighbours.
Future enhancements could potentially be implemented to simulate slower devices (like a device profile configuration against a monitor that simulates a slower device).
Network throttling is equally important and monitors should rarely be running at line speed (certainly not when we’re gathering performance data) as it can generate such variability and misleading results.
Monitor configurations should be used to define what network speed the test runs with, controlling upload speed, download speed and latency as a minimum set of variables.
In all these cases, there is a need to ensure that the platform has sufficient CPU and network bandwidth to deliver the total concurrent monitors being run from that shared infrastructure, to ensure that it does not create a bottleneck that impacts the performance metrics of the tests.

100% agree on the importance of this from a product perspective.
Device simulation is my biggest use case. Both with synthetic monitors and also ad-hoc generated runs based on identified anomalous RUM cohorts.
We should also consider the UX of this @katrin-freihofner - From a user's perspective is it better to have mixed speeds within a single monitor or would we have one speed per monitor consistently? Also, how do we communicate when speed settings have changed when viewing historical data

100% agree on the importance of this from a product perspective.
Device simulation is my biggest use case. Both with synthetic monitors and also ad-hoc generated runs based on identified anomalous RUM cohorts.
We should also consider the UX of this @katrin-freihofner - From a user's perspective is it better to have mixed speeds within a single monitor or would we have one speed per monitor consistently? Also, how do we communicate when speed settings have changed when viewing historical data

I’d like to split this out to track and prioritise the features individually.
(I am excluding the platform consistency (CPU) from this as that’s a platform requirement for GA)
From the Synthetic Agent perspective, there are several things we need to throttle/emulate:

UA String (to emulate a different device type, often combined with a change of the viewport)
Viewport (to emulate a different device type, often combined with a change of the UA String)
Network (to emulate more realistic, throttled connections such as DSL, 3G, 4G etc.)
CPU (to emulate older devices)

Three separate issues have been raised to cover these as follows:

Emulate device type (this covers both the UA String and Viewport as they are so closely related for setting the device type) https://github.com/elastic/synthetics/issues/209
Network throttling https://github.com/elastic/synthetics/issues/210
CPU Throttling https://github.com/elastic/synthetics/issues/211


On-premise not working

It works great on DEV environment when I use 1.4.1 version of SP framework, but for on-premise I must use 1.1.0 and it does not work with that version... It would not start DEV environment neither build. In console, there is an error like: 404 manifests.js not found... Do you have any solution for this?

Yeah - this project is written for SP Online. I am in the process of simplifying this project template alongwith a video course. That should make it trivial to use it anywhere without huge baked in dependencies into what SPFx project you are using.


Buckets seem to be broken

The bucket recipe seems to be broken. It will not build with either the vanilla recipe or the BTW recipe

works just fine, make sure you don't have other mods removing the recipe.


License information update

PR Description:
This PR is to update the license information of this project along with its dependencies
License file information in README file is updated accordingly
Project license is updated with Apache Version 2.0 considering the project use cases and deployment scenarios.

Can one of the admins verify this patch?

@swaminathanvasanth @abhi4578 Dependency licenses file updated with all the licenses related to servers and client packages, pls review


SyntaxError: The requested module 'solid-js/web' does not provide an export named 'SVGElements'

Describe the bug
I was build a lib with @mdx-js/mdx. When i run pnpm test it cause following error
node:79444) ExperimentalWarning: VM Modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
 FAIL  tests/component.spec.tsx
  ● Test suite failed to run

    SyntaxError: The requested module 'solid-js/web' does not provide an export named 'SVGElements'

Your Example Website or App
https://github.com/Jackie1210/smdx
Steps to Reproduce the Bug or Issue

pnpm install
pnpm test

Expected behavior
tests passed
Screenshots or Videos
No response
Platform

OS: [macOS]

Additional context
No response

If I had to guess without looking this is a server vs client issue. Where the pulled in code is the server code but it's building client output.  We do export SVGElements from our client build as far as I can see. And it looks from the package JSON the libraries are mostly up to date. So that would be my guess.

My tests is in server enviroment. This error occured because i needed jsx-runtime from solid-js/h as params of function evaluate I built this source code of solid-js, add it did not export SVGElements in solid-js/web pkg, which only export from dom-expression/client in client mode.
I found #855  which has the same issue since 1.3.7, it there any chance this issue can be fixed?

solid-js/h is client only. It doesn't work on a server. Or at least on a server you don't want to use server build as our h function generates DOM elements. So you could run it on a server with JSDOM or similar but then it would be the client build you want.

I have been trying to figure out what expectation is here. solid-js/h and server build are not compatible. h actually produces DOM nodes. I am not even certain I can get a string-rendered compatible version of h working, along with a hydration-capable version as well. It's a ton of work and it might not pan out.
Basically fixing this error will just lead you to the next one.
If you want to use Solid JSX on the server use our transform babel-preset-solid.

@ryansolid Thanks for your time. I will try client mode instead.


demo site lacking css

Hi, I noticed your demo site is looking slightly out of sorts:

I think some of the css is not being loaded properly.

Thanks for the heads up!
Actually, the problem was that Netlify moved all the sites without custom domain from .com to .app last month.
I had not updated the baseURL in the config file. That's now done!
Thanks


Replace KV View - Node & Bucket with a more comprehensive KV overview

Lots of changes in terms of panels, but I think you and the KV team own this dashboard. :-) Looks good.


Add possibility to rename the target

Add possibility to rename target path.
E.g. /usr/bin/emacs-nox to /usr/bin/emacs
target:
  - /usr/bin/emacs-nox -> /usr/bin/emacs

Decided on script hooks instead:
before: |
    echo "before anything" > /tmp/before.txt

after: |
    echo "after calculation, before applying the state" > /tmp/after.txt

Addressed per https://github.com/isbm/mezzotint/pull/25


API Documentation - @deprecated

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=402

No real issue here, just recommendations (some obsolete)


Add kwargs for boto s3 writing

This allows the use of extra arguments to the boto uploading functions, such as headers, metadata, reduced_redundancy, encrypt_key, and policy.
Allowing server side encryption is the biggest advantage here, as buckets which enforce SSE will not be writable unless the following is used.
    s3 = luigi.s3.S3Client()
    s3.put(localfile, remotefile, encrypt_key=True)

lgtm
i could see a problem if you want to use kwargs for other things (not put) in the future, but for now that's not a big deal

also would have been good to add tests so try to do that next time :)

Sorry - long day at the office! See #1403 for some basic tests :smiley:


feat: Support for map col with int val

For map type column, the default value for both key and value column was assumed as empty string.
This doesn't allow for map type column with int value type.
This change sets default value as 0 for int type value column for map object

Closing this for now, as the parent pr was merged with map type.


Improve LMDB

This PR includes:

Restructuring of LMDB backend, usage of native dup keys for LMDB indexes.
Automatic resizing of database.

If the autoResize option is enabled, the database will automatically resize itself if needed by minResize (default is 1GB).

Codecov Report

Merging #22 into staging will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging      #22   +/-   ##
========================================
  Coverage    75.79%   75.79%
========================================
  Files           30       30
  Lines         2384     2384
========================================
  Hits          1807     1807
  Misses         577      577

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6612e...ebccf72. Read the comment docs.


on mac a confirm dialog does not close when button is clicked

What's the version of macOS and this crate you're using?


Getting raw pointer to platform GL context

I am writing some type-safe Rust bindings to RenderDoc, a fairly popular graphics API debugger, and I am trying to get it to play nice with glutin-based applications.
When RenderDoc gets injected into the running application, the target application calls the SetActiveWindow function to tell RenderDoc which window to display the debug overlay and which graphics device to capture command lists from. To paraphrase the documentation:
void SetActiveWindow(RENDERDOC_DevicePointer device, RENDERDOC_WindowHandle wndHandle)

Note:
RENDERDOC_DevicePointer is a typedef to void *. The contents of it are API specific:

For D3D11 it must be the ID3D11Device device object.
For OpenGL it must be the HGLRC or GLXContext context object.
For Vulkan it must be the dispatch table pointer within the VkInstance. This is a pointer-sized value at the location pointed to by the VkInstance. NOTE - this is not the actual VkInstance pointer itself.

RENDERDOC_WindowHandle is a typedef to void *. It is the platform specific HWND, xcb_window_t, or Xlib Window.

glutin::GlWindow can give me the raw window handle via the (albeit deprecated) platform_window() method, but I can't seem to acquire a raw pointer to the underlying GL context. Is there any way to do this with glutin at present? If not, how realistically could a feature like this be added? I am willing to make a pull request if needed.

The os module contains all the platform-specific getters.
Making it possible to retrieve a pointer to the GL context should be done through a trait defined in this module.

@tomaka Thanks for the guidance! However, I was thinking it might be more appropriate to add an unsafe platform_context() method to the GlContext trait instead. This would remain consistent with the existing platform_window() method in winit. Would you have anything against this approach?

platform_context is too vague. If glutin creates an EGL context and you think it's a GLX context, then bad things may happen.
The platform_window method in winit is deprecated as well, so we shouldn't take inspiration from it.

I see what you mean. But what if the resulting application doesn't care, e.g. RenderDoc? Should I instead use #[cfg] attributes to select the correct backend from the os module at compile time?

All applications must care about what of context they have.
You quoted this in the OP:

For OpenGL it must be the HGLRC or GLXContext context object.

Which I guess means that RenderDoc expects a GLX context.

RenderDoc expects either a WGL context or a GLX context, depending on the platform. It is possible that other OpenGL context types may be accepted in future versions of the application. But that is beside the point that I'm trying to make.
Suppose I were to create a trait in the top-level os module, as was suggested in your initial reply, which looks roughly something like this:
pub trait ContextExt {
    type Handle;
    unsafe fn as_ptr_mut() -> *mut Handle;
}

Which types should implement this trait? I presume you meant for the various Context types defined in platform. If that's the case, then how would I handle contexts represented as enums, e.g. platform::windows::Context and platform::linux::Context? What would you recommend I specify for the associated type? Or have I misunderstood something fundamental here?

First of all, I was thinking of having a different trait in each submodule in os, but I guess having the same trait for all platforms is a nice solution as well.
As for handling contexts that are enums, you can just add methods to the enums. After all, the point of the ContextExt trait is just correctly handling visibility.

Methods which return what type? Like I mentioned before, the idea of ContextExt is to return a type-safe mutable pointer to the underlying context handle, whatever that may be. What could I possibly set the Handle associated type if the backend being selected is unknown at compile time? Returning an enum containing pointers to the contexts might work, but is there be a prettier way?

Just create another enum with the Glx and Egl variants, whose sole purpose is to be returned by the method in ContextExt.


e2e: validate resource cleanup

What this PR does / why we need it:
Adds a check that resources are actually cleaned up when HostedClusters are deleted.
Checklist

[x] Subject and description added to both, commit and PR.

/test e2e-aws


Creates the Error Code Framework and updates type codes.

Reason for Change:
The goal of these changes is to enable the CNI client modules to receive consistent and meaningful feedback from CNS when an operation fails.  This will improve the telemetry and retry logic of the CNI client modules and enhance the reliability and performance of the container networking services.
Issue Fixed:
N/A
Requirements:

[ ] uses [conventional commit messages]
[X] includes documentation
[X] adds unit tests
[ ] relevant PR labels added

Notes:
This is part of an effort to create an extensible error code framework for CNS.

@microsoft-github-policy-service agree [company="Microsoft"]

Just as an FYI, we do have Azure API guidelines which we could consider adopting/learning from going forward. Specific guidance on errors.


Add frame_rate attribute to HLS.Variant struct

Hi Cade!
Looks like you had added most of the support for frame rates, just curious if there was anything specific holding it up.
Thanks!

Thanks for the PR! No reason, probably just got missed. I'll push out a new release