Dali Output does not match name or order

Hi i'd like to report a bug regarding the order of the outputs don't seem to match when there are multiple outputs:
# Just a simple peek image shape and resize and normalize code
#  Did not do anything special
pipeline.set_outputs(resized_images, shapes) # FP 32 and INT64

Here's an example of my config file for outputs:
output: [
    {
        name: "processed_image"
        dims: [256, 256, 3]
        data_type: TYPE_FP32
    },
    {
        name: "image_shape"
        dims: [3]
        data_type: TYPE_INT64
    }
]
# Image shape becomes processed_image and vice versa

When i call with Triton for some weird reason the output of these 2 are  flipped whether its in ensemble or even just calling via the client. Unless the problem is own my side? I've tried a lot of things but just can't seem to get it correct.

You don't say how you are communicating with Triton. I assume the tritonclient python library but the answer would be the same if you were using the C++ library or directly using the HTTP/REST or GRPC protocol. In all these cases there is no enforced order of the tensor outputs (or inputs), even between different requests of the same model. You must access the outputs using the name of the tensor.

You don't say how you are communicating with Triton. I assume the tritonclient python library but the answer would be the same if you were using the C++ library or directly using the HTTP/REST or GRPC protocol. In all these cases there is no enforced order of the tensor outputs (or inputs), even between different requests of the same model. You must access the outputs using the name of the tensor.

Hi sorry for not making it clear yes i am calling via the python library client.
When i'm calling it via the Triton client, i've always done it as such but i recently added 1 extra output, when i called it i get the opposite position of one another. Or am i just doing it wrong?
triton_client = grpcclient.InferenceServerClient(url="localhost:8001")
for image in images:
    with open(image, 'rb') as f:
        image = np.frombuffer(f.read(), dtype=np.uint8)
    sent_count += 1
    image = np.expand_dims(image, axis=0)
    inputs = [grpcclient.InferInput(input_name, image.shape, input_dtype)]
    outputs = [grpcclient.InferRequestedOutput('processed_image'),grpcclient.InferRequestedOutput('image_shape')]
    inputs[0].set_data_from_numpy(image)

    result = triton_client.infer(
        'seg_preproc', inputs,
        request_id=str(sent_count),
        model_version='1', outputs=outputs
    )

    result.as_numpy('image_shape') # (1, 256, 256, 3), FP32
    result.as_numpy('processed_image') # (1, 3), INT64

I launched the verbose mode of triton i get the following in this order:
requested outputs:
image_shape
processed_image

Hi sorry for not making it clear yes i am calling via the python library client.
When i'm calling it via the Triton client, i've always done it as such but i recently added 1 extra output, when i called it i get the opposite position of one another. Or am i just doing it wrong?
triton_client = grpcclient.InferenceServerClient(url="localhost:8001")
for image in images:
    with open(image, 'rb') as f:
        image = np.frombuffer(f.read(), dtype=np.uint8)
    sent_count += 1
    image = np.expand_dims(image, axis=0)
    inputs = [grpcclient.InferInput(input_name, image.shape, input_dtype)]
    outputs = [grpcclient.InferRequestedOutput('processed_image'),grpcclient.InferRequestedOutput('image_shape')]
    inputs[0].set_data_from_numpy(image)

    result = triton_client.infer(
        'seg_preproc', inputs,
        request_id=str(sent_count),
        model_version='1', outputs=outputs
    )

    result.as_numpy('image_shape') # (1, 256, 256, 3), FP32
    result.as_numpy('processed_image') # (1, 3), INT64

I launched the verbose mode of triton i get the following in this order:
requested outputs:
image_shape
processed_image

@edwin-19 ,
Unfortunately, I couldn't quickly reproduce your issue - for me the order of outputs is correct. Could you share your DALI pipeline? The problem may lay there.
Also, what version of dali_backend do you use? Few days ago we had major bug fix, which might also impact your case. Should you like to try out master version, please build dali_backend with the docker:
git clone --recursive git@github.com:triton-inference-server/dali_backend.git
cd dali_backend
docker build -t tritonserver:dali-master .

Then you treat tritonserver:dali-master as your regular Triton server image

@edwin-19 ,
Unfortunately, I couldn't quickly reproduce your issue - for me the order of outputs is correct. Could you share your DALI pipeline? The problem may lay there.
Also, what version of dali_backend do you use? Few days ago we had major bug fix, which might also impact your case. Should you like to try out master version, please build dali_backend with the docker:
git clone --recursive git@github.com:triton-inference-server/dali_backend.git
cd dali_backend
docker build -t tritonserver:dali-master .

Then you treat tritonserver:dali-master as your regular Triton server image

@szalpal
The version of DALI i'm using is:
nvidia-dali-cuda100           0.29.0

I have been using dali for about 2 weeks, there was a bug fix i see, hmmm.
Anyway my pipeline is shown below, but i dont think should cause it to mistake outputs?
pipeline = Pipeline(batch_size=32, num_threads=4, device_id=0)
with pipeline:
    source = fn.external_source(device='cpu', name='image_input')
    shapes = fn.peek_image_shape(source)

    images = fn.image_decoder(source, device="mixed", output_type=types.BGR)
    resized_images = fn.resize(images, resize_x=256, resize_y=256)
    resized_images = resized_images / 255.

    pipeline.set_outputs(resized_images, shapes)

@szalpal
The version of DALI i'm using is:
nvidia-dali-cuda100           0.29.0

I have been using dali for about 2 weeks, there was a bug fix i see, hmmm.
Anyway my pipeline is shown below, but i dont think should cause it to mistake outputs?
pipeline = Pipeline(batch_size=32, num_threads=4, device_id=0)
with pipeline:
    source = fn.external_source(device='cpu', name='image_input')
    shapes = fn.peek_image_shape(source)

    images = fn.image_decoder(source, device="mixed", output_type=types.BGR)
    resized_images = fn.resize(images, resize_x=256, resize_y=256)
    resized_images = resized_images / 255.

    pipeline.set_outputs(resized_images, shapes)

@edwin-19
Unfortunately, again I couldn't reproduce your problem, even using your pipeline. Here are the files I used, hope you'll find them useful:
    pipeline = dali.pipeline.Pipeline(batch_size=32, num_threads=4, device_id=0)
    with pipeline:
        source = fn.external_source(device='cpu', name='image_input')
        shapes = fn.peek_image_shape(source)

        images = fn.image_decoder(source, device="mixed", output_type=types.BGR)
        resized_images = fn.resize(images, resize_x=256, resize_y=256)
        resized_images = resized_images / 255.

        pipeline.set_outputs(resized_images, shapes)
    pipeline.serialize(filename=filename)

name: "dali"
backend: "dali"
max_batch_size: 256
input [
  {
    name: "image_input"
    data_type: TYPE_UINT8
    dims: [ -1 ]
  }
]

output [
  {
    name: "DALI_OUTPUT_0"
    data_type: TYPE_FP32
    dims: [ 256, 256, 3 ]
  },
  {
    name: "DALI_OUTPUT_1"
    data_type: TYPE_FP32
    dims: [ -1 ]
  }
]

And the client with the output:
    outputs.append(tritonclient.grpc.InferRequestedOutput("DALI_OUTPUT_0"))
    outputs.append(tritonclient.grpc.InferRequestedOutput("DALI_OUTPUT_1"))

    inputs[0].set_data_from_numpy(batch)

    # Test with outputs
    results = triton_client.infer(model_name=model_name,
                                      inputs=inputs,
                                      outputs=outputs)

    print("0:",results.as_numpy("DALI_OUTPUT_0").shape)   # 0: (1, 256, 256, 3)
    print("1:",results.as_numpy("DALI_OUTPUT_1").shape)   # 1: (1, 3)

Should you like more help with your issue, please provide more details or more specific reproduction

@edwin-19
Unfortunately, again I couldn't reproduce your problem, even using your pipeline. Here are the files I used, hope you'll find them useful:
    pipeline = dali.pipeline.Pipeline(batch_size=32, num_threads=4, device_id=0)
    with pipeline:
        source = fn.external_source(device='cpu', name='image_input')
        shapes = fn.peek_image_shape(source)

        images = fn.image_decoder(source, device="mixed", output_type=types.BGR)
        resized_images = fn.resize(images, resize_x=256, resize_y=256)
        resized_images = resized_images / 255.

        pipeline.set_outputs(resized_images, shapes)
    pipeline.serialize(filename=filename)

name: "dali"
backend: "dali"
max_batch_size: 256
input [
  {
    name: "image_input"
    data_type: TYPE_UINT8
    dims: [ -1 ]
  }
]

output [
  {
    name: "DALI_OUTPUT_0"
    data_type: TYPE_FP32
    dims: [ 256, 256, 3 ]
  },
  {
    name: "DALI_OUTPUT_1"
    data_type: TYPE_FP32
    dims: [ -1 ]
  }
]

And the client with the output:
    outputs.append(tritonclient.grpc.InferRequestedOutput("DALI_OUTPUT_0"))
    outputs.append(tritonclient.grpc.InferRequestedOutput("DALI_OUTPUT_1"))

    inputs[0].set_data_from_numpy(batch)

    # Test with outputs
    results = triton_client.infer(model_name=model_name,
                                      inputs=inputs,
                                      outputs=outputs)

    print("0:",results.as_numpy("DALI_OUTPUT_0").shape)   # 0: (1, 256, 256, 3)
    print("1:",results.as_numpy("DALI_OUTPUT_1").shape)   # 1: (1, 3)

Should you like more help with your issue, please provide more details or more specific reproduction

Hi @szalpal, thanks for the feedback so kind of solve it. With your suggestion above
You see this is my original output tensor names for my Triton dali backend
output: [
    {
        name: "processed_image"
        dims: [256, 256, 3]
        data_type: TYPE_FP32
    },
    {
        name: "image_shape"
        dims: [3]
        data_type: TYPE_INT64
    }
]

When i change the tensor names to what you suggested above the order matches:
output [
  {
    name: "DALI_OUTPUT_0"
    data_type: TYPE_FP32
    dims: [ 256, 256, 3 ]
  },
  {
    name: "DALI_OUTPUT_1"
    data_type: TYPE_FP32
    dims: [ -1 ]
  }
]

So i was wondering is this a design of dali backend, because i did not specify any special name when creating the operators so i thought i could assign any name as long as i follow the order of my pipeline output.

Hi @szalpal, thanks for the feedback so kind of solve it. With your suggestion above
You see this is my original output tensor names for my Triton dali backend
output: [
    {
        name: "processed_image"
        dims: [256, 256, 3]
        data_type: TYPE_FP32
    },
    {
        name: "image_shape"
        dims: [3]
        data_type: TYPE_INT64
    }
]

When i change the tensor names to what you suggested above the order matches:
output [
  {
    name: "DALI_OUTPUT_0"
    data_type: TYPE_FP32
    dims: [ 256, 256, 3 ]
  },
  {
    name: "DALI_OUTPUT_1"
    data_type: TYPE_FP32
    dims: [ -1 ]
  }
]

So i was wondering is this a design of dali backend, because i did not specify any special name when creating the operators so i thought i could assign any name as long as i follow the order of my pipeline output.

This is interesting! Thank you for providing info. Certainly, there shouldn't be any problem with custom names for inputs. If this confirms, I guess it's a bug. I'll look into the issue.

Sure let me know if u need any extra info

Indeed, there is a bug in mapping outputs from DALI to the outputs from dali_backend.
As a workaround please assign outputs in config.pbtxt in an alphanumeric order. I'll post the fix as soon as possible.
PR with fix prerequisite:
https://github.com/NVIDIA/DALI/pull/2665

Waiting for DALI v1.0


Moving Razor Pages Areas Folder

Describe the bug
I can't find a way to move the default Areas folder to a subfolder.
This is my project structure:
Project.Web
+-- ClientApp (VUE SPA)
+-- Server (includes all asp.net components)
I moved my pages already to the Server folder but I can't manage to get the Areas folder within the Server folder working.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core 2.2

Expected behavior
Having a RazorPagesOptions like options.AreasRootDirectory

@netleader there isn't an feature to do this as yet. We had some trouble reconciling configurable Areas with Razor Class Libraries like IdentityUI. https://github.com/aspnet/Mvc/issues/7608 goes in to a bit more detail about this. You could explore using route model conventions to configure the pages in your application to account for your modified folder structure.

Thanks for your reply, those route model conventions are not "convinient" I hope you guys will provide a better solution in the future.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


DIYRuZ_RT alternative firmware

Device description
Sonoff Basic ZBR3 with DS18b20 and Z-Stack 3.0 firmware
https://habr.com/ru/company/iobroker/blog/495926/
Zigbee2mqtt page
https://www.zigbee2mqtt.io/devices/DIYRuZ_RT.html
MQTT message with device information
PUT here the device data you receive when publish message with topic
zigbee2mqtt/bridge/config/devices, as example
'{"message":[{"dateCode":"20200327","friendly_name":"Coordinator","ieeeAddr":"0x00124b00060e4bfb","lastSeen":1599416678016,"networkAddress":0,"softwareBuildID":"zStack30x","type":"Coordinator"},{"dateCode":"20200405","description":"[DiY CC2530 Zigbee 3.0 firmware](https://habr.com/ru/company/iobroker/blog/495926/)","friendly_name":"0x00124b001e728b58","hardwareVersion":1,"ieeeAddr":"0x00124b001e728b58","lastSeen":1599416671477,"manufacturerID":0,"manufacturerName":"DIYRuZ","model":"DIYRuZ_RT","modelID":"DIYRuZ_RT","networkAddress":60164,"powerSource":"Mains (single phase)","softwareBuildID":"20200405","type":"Router","vendor":"DIYRuZ"}],"type":"devices"}'

MQTT messages from device
Put here examples of MQTT messages with different states you've received from device, as example
topic 'zigbee2mqtt/0x00124b001e728b58', payload '{"linkquality":28,"state":"ON","temperature":27.25}'
topic 'zigbee2mqtt/0x00124b001e728b58', payload '{"linkquality":26,"state":"OFF","temperature":27.25}'

MQTT state change commands
If device supports state change put MQTT topics + payload examples to change device state here
topic 'zigbee2mqtt/0x00124b001e728b58/set'  payload: 'ON'
topic 'zigbee2mqtt/0x00124b001e728b58/set' payload: 'OFF'

Pull request added to support. https://github.com/stas-demydiuk/domoticz-zigbee2mqtt-plugin/pull/408

PR has been merged, thanks!


What might this core idea of app result into?

So  the main purpose of this project is sharing the data from one  type of app to another like, todo can be shared to diary writing app so that same data may not be inserted in multiple place.
What I am feeling like this might end up into is a content provider which will provide todos, projects, tasks, motivation. For example google fit provides data about fitness, this app might do that with productivity things. So that not only our app but other apps can also benefit from it, which will eventually result into a happier user.
This might have another advantage, for instance an user wants to download todo and finds that he can also create routine out of it without writing any more letters.

But at the mean time, one of our other major focus is reducing the context switch a user has to do between different app, i.e. one step solution for productivity. Though being a content provider is an awesome idea our major focus should revolve around  being that app  where user does not have to switch the app to be productive.

The solution might be at first just focusing on being the one stop solution for productivity then in future , making data accessible to other apps so that they can give some extra value to users from the data they have inserted to our app.


Support libraries version update?

In dependencies.gradle, the version referenced for all support libraries is 23.1.0, a relatively older release. Since then, there have been lots of updates and fixes. Current version is 23.2.1. Are there plans to update these? The changes that apply most to my usage are related to RecyclerView's measurement changes to support wrap_content. If I compile a newer version of an android support library in my own gradle project, will RxBinding respect that version or use the one defined in dependencies.gradle?

You can declare the newer version in your build.gradle and those versions will be used for building your app. Confirm by running ./gradlew dependencies.
The only reason to bump in this project is if there's new APIs that need binding against. We won't be making releases to track every support library update though.

a relatively older release

This is literally the previous release. It's not that old.

Thanks for the super quick reply!


Cluster Explorer Apps/Marketplace is completely broken in Firefox

I use Firefox as my main browser. The old UI works splendidly, but ever since Cluster Explorer and especially the App Marketplace has been forced down upon me, I've had to start using Chrome. Can you please make Cluster Explorer work in Firefox?

Everything we do is free, open source, and nobody is "forcing" anything on you.
The cluster manager UI still exists, and works the same as it always has.  It will continue to through at least including 2.6.
Explorer works fine in Firefox.  We test it.  And Safari.  I use them all periodically.  Various other employees including our chief architect use Firefox exclusively.
It's somewhat slower with a lot of data because js proxies are used to maintain all the state from the server and the implementation of them in Firefox is about 100x slower than Chrome, but is still perfectly usable normal uses.
If you have specific, actionable, reproducible problems, report them.

You're absolutely right. I'm sorry. This issue was created in frustration. That was wrong of me. I'll try to do better next time. Thanks for your work!


bug(slides): [hidden] breaks things

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If you bind to [hidden], when the ion-slides becomes visible the sliding is broken. Pages do not lock correctly.

   <ion-slides pager #slides>
      <ion-slide style="background-color: green">

Slide 1

      </ion-slide>
      <ion-slide style="background-color: blue">

Slide 2

      </ion-slide>
      <ion-slide style="background-color: red">

Slide 3

      </ion-slide>
   </ion-slides>

Note that if you use *ngIf it works, but then @ViewChild becomes complicated.
Expected behavior:
Slider should work correctly.
Other information:
See attached repo:
sliderTest.zip
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.5.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.10
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.2.1 Build version 8C1002

Seems like a duplicate of https://github.com/driftyco/ionic/issues/10176?
You need to call update after changing the visibility to readjust the slides.
It has been added to the docs as it was previously set to private.


docs: correct upload create docs (add required fields)

It's not possible to use Upload Create endpoint without those fields, they are required:
"file",
"file_format",
"locale_id"

@vermaxik first, sorry for the delay, I was on vacation for a week.
The problem with this PR is that it's causing breaking change for all clients. Declaring an existing parameter required changes method signatures. ruby example:
-    def upload_create(project_id, file, file_format, locale_id, opts = {})
-      data, _status_code, _headers = upload_create_with_http_info(project_id, file, file_format, locale_id, opts)
+    def upload_create(project_id, opts = {})
+      data, _status_code, _headers = upload_create_with_http_info(project_id, opts)
       data
     end

We'll have to discuss what to do in this case. IMO this should be merged, as it correctly describes the API, but it would need a major version bump for all the clients. Perhaps we should dedicate some time and investigate other potential places where this is needed, so that we have only one painful band-aid pull, rather than multiple ones in the future.
@theSoenke what do you think?

@jablan agree that we should spend some effort to check whether there are more such places to tackle all in one go. Although that might be some quite tedious work. Maybe we should then create a task for it?

@vermaxik @jablan what is the way forward here? Since tests are currently failing, I marked it as "draft" again.

@docstun we opened a ticket for it https://phrase.atlassian.net/browse/TSI-2145 unfortunately, we can't make it during these quality weeks.

Hi @theSoenke
thank you for checking it, good to know.
FYI there is possibility to add discriminator/polymorphism for dynamic request/response, TMS has it a lot.
Closing this PR in favor of https://github.com/phrase/openapi/pull/571

FYI there is possibility to add discriminator/polymorphism for dynamic request/response, TMS has it a lot.

@vermaxik do they also generate a set of clients from OpenAPI description? I'm a bit concerned how different clients handle such cases.

@jablan  looks like it should be supported https://openapi-generator.tech/docs/generators/openapi/#schema-support-feature
afaik TMS doesn't have any official clients (and they still on openapi v2), but at our team we need to implement custom support for this feature and would love to avoid it as much as we can.


Exception '*** setObjectForKey: key cannot be nil' was thrown while invoking uploadFile on target FirestackStorage

Getting this error when trying to upload a small video (~839KB). I wonder if I've made some silly mistake in the code somewhere.
Here's the react-native-camera snippet.
startRecording() {
    if (this._camera) {
      this._camera.capture({
        mode: constants.CaptureMode.video,
      })
        .then((data) => {
          const firestack = new Firestack();
          const filename = 'somevideo.mov';
          firestack.storage.setStorageUrl('ftw-group-messaging-app.appspot.com');
          firestack.storage.uploadFile(`videos/${filename}`, data.path, {
            contentType: 'video/mov',
          })
          .then((res) => {
          console.log('result from upload file: ', res);
          })
          .catch((err) => {
            console.log('error happened with uploadFile', err);
          });
        })
        .catch(err => console.error(err));
      this.setState({
        isRecording: true,
      });
      setInterval(this.stopRecording, 3500);
    }
  }

The error goes away after reloading once. But nothing happens. No file gets uploaded.

Hi I have the same error. have you solved it? @coffeeandjunk

Same issue here... The only difference in my case is contentType = "image/jpeg";

@auser Please help me with this issue. Spent so much time on time and feel desperate now... What I noticed recently is this:

When I run react-native run-ios, go to profile, and then immediately change profile picture everything ends with this crash (like on the picture above);
If after start I press Cmd+R to refresh app in the simulator and do the same the picture gets updated successfully.
I have no a faintest idea of the reason.

Thank you in advance!

I was unable to solve it. I didn't face this issue with images though. And no, I didn't use react-native-image-picker. I moved out of firestack (temporarily) as I couldn't find a way to solve it. I'll review this error sometime in next month. If it still persists, I'll see if I can solve it somehow.

I was able to solve my problem by importing the json from Firebase to the project by dragging it via xcode not finder
Do the other firebase service work like database?

Ah just seeing this. Yes, you have to do it via Xcode, otherwise the compiler doesn't know it needs to be linked.
Thanks for the comment @iamkyleee. For the same reason, all services in Xcode work like this.

@auser don't know why you decided to close this. @iamkyleee I've done it of course. If I hadn't done it, this wouldn't trigger crash just sometimes. Above I described that most often it only appears before I reload the app. =(


add tool to audit release branch against code.getmdl.io

Why not write it in JS? That way it would work for Windows users too.
https://github.com/arturadib/shelljs

@sindresorhus That is definitely the plan. This is more of a interim solution. My mid-term goal is to have all task integrated into the (rewritten, cleaned-up, sane) gulpfile.

Closing this, as it no longer works with our release process.


Add support for IPv6 address allocation

@sargun  should be the primary reviewer here

got a 👍  from Sargun as well!


linux-yocto: Build rtl8822bu module

Changelog-entry: linux-yocto: Build rtl8822bu module
Signed-off-by: Alexandru Costache<EMAIL_ADDRESS>

closing as not needed


Dba compression

Type of Change

[x] Bug fix (non-breaking change, fixes #1714 )
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Pester test is included

Purpose
Created a new function called Set-DbaCompression
Updated the function called Test-DbaCompression

Lookin good! @gbargsley or @ClaudioESSilva can you have a look?


Add myself to list of contacts on README

Hey guys, I want in on the fun. Added my twitter handle and information to the contact list.

Thanks! 👍

Apology for interruption. May anyone explain what just happen since last 1 hour? Am I seeing conhost source code? 😵

@biswa96 you should reach out on twitter (look at the readme to find out how) instead of, you know, in the comments on somebody else's pull request :)


os.PathLike not compatible with pandas._typing.FilePathOrBuffer

This issue occurs when using df.to_csv(some_path_like) where some_path_like is typed as os.PathLike.
minimal example:
import os
import pandas as pd

def write(path: os.PathLike):
    df = pd.DataFrame()
    df.to_csv(path)

When using this, I get the mypy error: error: Argument 1 to "to_csv" of "NDFrame" has incompatible type "_PathLike[Any]"; expected "Union[str, Path, IO[str], None]"
You use Optional[FilePathOrBuffer[AnyStr]]=..., so I don't actually know if this is an issue of pandas._typing or if it could be fixed here or if it supposed to work like that.

I checked with the pandas and it seems this part was changed - and our stubs had this outdated - https://github.com/pandas-dev/pandas/commit/c4c1dc3563ec95da1e700f96c9848be874699818
Following current typing from pandas, I changed our code: https://github.com/VirtusLab/pandas-stubs/pull/41/files
This however will lead to changing your signature to:

def write(path: os.PathLike[Any]):
    df = pd.DataFrame()
    df.to_csv(path)

, because os.PathLike seems to be a generic type. Would it be okay for your case?


"Show/Hide the Terminal window" buggy between displays

Windows Terminal version
1.14.1452.0
Windows build number
10.0.22621.0

Bug the first
Steps to reproduce

Setting a key combination for the Action "Show/Hide the Terminal window", for example "ctrl+win+h". BTW, is this called "Global Summon"?
Acts in the same display works fine
Maximize Terminal window in a bigger display, then "Hide" it with keystroke.
move mouse cursor to a smaller display, "Show" it with keystroke.

Expected Behavior
after step 4, the window shows maximized.
Actual Behavior
Focus changed, but Terminal shows ghostly
more detail:

when display failed: (Rectangle is correct)

Bug the second
Steps to reproduce

Setup a key combination to "Show/Hide the Terminal window".
Maximize Terminal window in a smaller display.
Move cursor to a bigger display, press keystroke to "summon" Terminal to this display

Expected Behavior
Terminal window moves to the bigger display, and maximized
Actual Behavior
Terminal window moved to the bigger display, and "maximized" according to the window button, but actually not maximized.
Notice the buttons on the upper right corner

This looks related to #10182, but with the added variable of the terminal being maximized. Thanks for the report!


Workspace trust icon position incorrect when compact window density

When opening Workspace Trust when window.density.editorTabHeight is compact the icon is not positioned correctly.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.83.1
OS Version: Windows 10 Enterprise 22H2 19045.3570

Steps to Reproduce:

Enable VSCode settings  "window.density.editorTabHeight": "compact".
Open Workspace Trust, the icon in title is not positioned correctly.

This is a consequence of  #152904. I will submit a PR.

fyi @benibenj


How to run this package on production (ubuntu + apache2) ?

Hi,
I'm using this package in  my dev server and it works well, I run it with the command php artisan websockets:serve.
I would like to know how can I run it in my production server.

Well I tried to write an article https://ghostscypher.medium.com/running-laravel-websockets-in-production-def368a84d56 here hopefully it helps you out. Had the exact same problem as you before.


UIORG-25 sso config

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mkuklis can you merge the PR?

@szkata this looks good! One thing I noticed is the fetch in downloadMetadata. It would be great to refactor it to use stripes-connect at some point. This should be now possible with the work done here: https://github.com/folio-org/stripes-connect/pull/13


MRG: In Report, limit max. image height to 600 pixels

For some plots I ended up with images of >1000 pixels of height, which wouldn't fit on my screen. To avoid having to scroll (and to reduce report size!), I'm now limiting max. height to 600 pixels.

This only applies to add_stc functions, not add_figure, right? If a user creates their own figure and passes it to add_figure, the size should be respected.

If a user creates their own figure and passes it to add_figure, the size should be respected.

It should be! If not, it's a bug. But I'll double-check!

Okay great -- bonus points if there is some test that asserts that a too-large user image actually shows up in the HTML at the correct size. But this might be a pain, in which case just manual visual confirmation is enough

Whoops, so the size is only preserved for add_image(), but not for add_figure(). I'll fix that and add a test.

It might be easiest to start a new PR for this one and start a fresh one now that #10342 has been merged.
@hoechenberger I'm going to push the milestone for this one as I don't see it as a blocker, but if you manage to get it in by the end of the week, great! But I assume the installers will probably occupy most of your time...

@hoechenberger I'll close based on the comment/plan in https://github.com/mne-tools/mne-python/pull/10248#issuecomment-1040674093 but feel free to reopen at some point if you'd rather continue work here


[Feature Request] Publishing the onnx-modifier distribution to PyPI

The onnx-modifier is an excellent tool; however, its installation and usage process could be more user-friendly. Providing a command-line interface that can be installed directly from PyPI would greatly reduce the barriers to entry for users.

@ice-tong Thanks for the suggestion! Making onnx-modifier installable from PyPI really helps. However, I am not familiar with how to achieve it. Any help from the community is welcomed.


Compiling gridencoder on windows with cuda 12.5

this was a chore, but I got it working. compiled, at least.
first, setup some environment variables.
specifically, you need CUDA_ARCH to exist. you'll need to look up exactly what the value should be for your video card. my Nvidia 3050 is 'sm_86'
Some others that you might need are TCNN_CUDA_ARCHITECTURES which depends on your card again, mine is '86'
and also CUDA_HOME which should be the path to your cuda install
Start with downloading the repo, then navigate to torch-ngp\gridencoder and run python setup.py install
This will almost certainly fail. you'll probably get a bunch of errors about atomicAdd.
we needed to do this to generate a build.ninja file. it would be somewhere like \torch-ngp\gridencoder\build\temp.win-amd64-cpython-312\Release
edit the file.
you need to double check all the paths you see in here. mine failed to have correct paths for cuda and visual studio. there is also a reference to std=c++. make sure that you change this to a version you have installed. I used c++17
save the file
now open gridencoder.cu
near the top, around like 20 you'll see a definition for atomicadd
now, depending on the errors you get you'll need to be creative here, but basically we need to write a function to convert what is getting put into atomic add into what cuda 12.5 is expecting.
My errors looked like this:
function "atomicAdd(int *, int)" does not match because argument #1 does not match parameter
static __inline __declspec(__device__) int atomicAdd(int *address, int val)
so my functions ended up looking like this
 __device__ inline at::Half atomicAdd(at::Half *address, at::Half val) {
  return atomicAdd(address, val);
}
template <typename T>
 __device__ inline T atomicAdd(T *address, T val) {
  return atomicAdd(address, val);
}
now open a cmd window next to the build.ninja file and run ninja -f build.ninja
and then it compiled. yay

you may also need to edit setup.py to have the correct c++ versions and visual studio paths


opt.train_sample_n is 16?

Hi @ruotianluo. May i ask why you are using train_sample_n = 16 for gen_result and n=1 for greedy in the code below? In transformer_sc.yml, you dont define train_sample_n so it should follow the value in opts which is 16. Shouldn't this be >1 only when using new self-critical when we want to generate multiple samples?
          self.model.eval()
            with torch.no_grad():
                greedy_res, _ = self.model(fc_feats, att_feats, att_masks,
                    mode='sample',
                    opt={'sample_method': opt.sc_sample_method,
                         'beam_size': opt.sc_beam_size})
            self.model.train()
            gen_result, sample_logprobs = self.model(fc_feats, att_feats, att_masks,
                    opt={'sample_method':opt.train_sample_method,
                        'beam_size':opt.train_beam_size,
                        'sample_n': opt.train_sample_n},
                    mode='sample')

Train sample n is defined in transformer.yml

In that case, why is sampling 5x more than greedy? You repeated the tensor 5 times for sampling but one time for greedy. And then when you computed the cider score, in which
greedy_res.shape[0] ==batch_size  and gen_result_size = batch_size * seq_per_img
and then:
    for i in range(gen_result_size):
        res[i] = [array_to_str(gen_result[i])]
    for i in range(batch_size):
        res[gen_result_size + i] = [array_to_str(greedy_res[i])]
    gts = OrderedDict()
    for i in range(len(data_gts)):
        gts[i] = [array_to_str(data_gts[i][j]) for j in range(len(data_gts[i]))]

    res_ = [{'image_id':i, 'caption': res[i]} for i in range(len(res))]
    gts_ = {i: gts[i // seq_per_img] for i in range(gen_result_size)}
    gts_.update({i+gen_result_size: gts[i] for i in range(batch_size)})

So here the sampling is more than greedy. This wasn't in your previous version. May I know what is the purpose of changing it from the previous version and why is the greedy baseline not equal to the sample when subtracted from each other?

The purpose of changing it is to reduce unnecessary computation. Since the model is set to eval mode, sample 5 greedy decoding is the same as sampling 1 greedy decoding.

@ruotianluo do you mean that in sampling, we can have different outputs for the same image, but for greedy its only one output since we are taking the max. So we only perform greedy one time and duplicate later? Is that what you mean?

yes.

alright. Thanks a lot. I have one more question.
I realized that in gathering the logprobs:
           it, sampleLogprobs = self.sample_next_word(logprobs, sample_method, temperature)

            # stop when all finished
            if t == 0:
                unfinished = it > 0
            else:
                unfinished = unfinished * (it > 0)
            it = it * unfinished.type_as(it)
            seq[:,t] = it
            seqLogprobs[:,t] = logprobs

You are saving the logprobs and not the sampled ones sampleLogprobs. And then in  RewardCriterion you gather them according to it:
input = input.gather(2, seq.unsqueeze(2)).squeeze(2)
May i also if that contributes to performance? Or is it just another way?

No. It's because some other loss may need the full probability.


Always use latest verible

Similar to the verible-formatter-action, fetch the most recent version of verible and perform the linting.
Should the same arguments be used as before or should it be done the same way as the formatting action?

-f fail fast without html error document
-S shows an error message on fail
-L follows a redirect

Hi @mglb, should be done now.

Please create new PR with your new branch.


404 not handle properly, when there is no image available for valid url

In this particular scenario, the library keep throwing image decoding errors and also trying to make irrelevant network request with displayImage while scrolling in the listView.
Image can't be decoded [https://demo.buddycloud.org:443/api/topics@topics.buddycloud.org/media/avatar?maxheight=200_120x120]

I believe, the library should provide either http statusCode or introduce new FailedReason to handle this situation. Also showImageForEmptyUri(null)  not handle this issue properly.

I would also like to be able to handle the HTTP status code inside: public void onLoadingFailed(String imageUri, View view, FailReason failReason).


[docs][base-ui] Add tokens to plain CSS theme stylesheet

[x] I have followed (at least) the PR section of the contributing guide.

Part of: #40108
This PR is to add the theme tokens to the stylesheet and tweak the component's styling accordingly.
Preview: https://deploy-preview-40113--material-ui.netlify.app/experiments/base/components-gallery/

Do we plan to add these configs to the settings panel long term?

I think we could aim to adding some settings, like border-radius, a toggle for flat/elevated (where we remove box-shadows from buttons and inputs), and typography (I'm still figuring out the best way to add this to the stylesheet)

The customization popup, is broken, the color switcher does not work anymore. I haven't look further, but wanted to raise that up. I can check it tomorrow if you need help Victor

Hey @mnajdova actually it's pretty broken everywhere 😅 —don't worry, though, it looks like this because @danilo-leal is adding some tweaks to the tokens, and I reckon he's still doing it haha. Anyway, I really appreciate the help, but I think after his tweaks we can merge this and work towards the next step: defining how we'll make it available for users.

The Select component has to be updated because of https://github.com/mui/material-ui/pull/39675, as right now, it doesn't have a visual indication for keyboard navigation. We need to add a visible border with :focus-visible.

Merging this one as I feel like it's in great shape! If we spot more improvement opportunities, we can always open iterative follow-up PRs 😬 In fact, an obvious one would be adding a dark mode toggle, but, as this might be available within the documentation, I'm assuming the toggle will be there. Anyhow, great work, y'all!


memory leak - issue latest build

I added wkhtmltopdf to the php-fpm image today. Did a rebuild and thought all was fine.
However soon as a browser visited any site the ram on the system went through the roof until the point where I ram out and the system crashed.
I have followed all the steps.

Rebuild my images multiple times
docker-compose down
docker container prune
docker image prune -a
docker volume prune

and brought up all the containers again.  The container that is having the issue each and every time is the laradock-php-fpm container.
I am right now attempting to use this image instead https://hub.docker.com/layers/laradock/php-fpm/2.7-7.4/images/sha256-59b3b2b936e16fb2b6ec7d818a84bcc3bd23b068be0e710dcdf05e5fc20d095d?context=explore will report if it works. Something with https://hub.docker.com/layers/laradock/php-fpm/latest-7.4/images/sha256-c1943c4a18d0903f70c444a33e4dcf806c9269d6566c667e6ccff74ab427673e?context=explore seems to be driving the ram usage through the roof. Nothing else with my setup has changed previous to what I mentioned. Colleague has had the identical issue.
hmm get same issue with https://hub.docker.com/layers/laradock/php-fpm/2.7-7.4/images/sha256-59b3b2b936e16fb2b6ec7d818a84bcc3bd23b068be0e710dcdf05e5fc20d095d?context=explore

Having the same issue I think. Since Friday my freshly build php-fpm containers in my laradock setup eat up my memory when I make a reaquest to the instance. Sometimes happen inside the workspace too ...

Tried to fix this all night. I'm on Ubuntu 20.04 (but also tried 20.10) and can't make it work.
The problem is appearing since Friday for me. That's when I set up my computer with a fresh copy of ubuntu. First I thought something wen't wrong during the installation but I just set it up again and it's not working anymore.
I'm using  Docker version 19.03.14, build 5eb3275d40 and docker-compose version 1.17.1, build 6d101fb.
The repo I'm trying to set up is https://github.com/tjventurini/laravel-blueprint so you might get the issue when you run then setup.
Not sure what else I can provide you by now. It's not writing any logs or so.
Any help is appreciated, this one is driving me crazy! 🆘

I found my issue after 12 hours of hell. It was xdebug. disabled and rebuild and that solved my issue

Thx, that solved my issue too. Although I now have to find out how I can make use of xdebug again.

Any updates @tjventurini ?

Any updates @tjventurini ?

I hade the same issue, It seems xdebug in version 3 needs a different config, It's my xdebug.ini file which I'm using and it's working properly:
; Old Xdebug Docker configuration
; https://serversforhackers.com/c/getting-xdebug-working
;xdebug.remote_enable=1
;xdebug.remote_handler=dbgp
;xdebug.remote_port=9000
;xdebug.remote_autostart=1
;xdebug.remote_connect_back=0
;xdebug.remote_idekey=phpstorm
;xdebug.remote_host=host.docker.internal

; New Xdebug Docker configuration
; https://xdebug.org/docs/upgrade_guide
; https://xdebug.org/docs/all_settings#mode
xdebug.mode=debug,trace
; https://xdebug.org/docs/step_debug
; https://xdebug.org/docs/all_settings#discover_client_host
xdebug.discover_client_host=true
; https://xdebug.org/docs/all_settings#client_discovery_header
xdebug.client_discovery_header=HTTP_XDCB
; https://xdebug.org/docs/all_settings#client_host
; in linux it doesn't work on docker 19 version, because of domain name
xdebug.client_host=host.docker.internal
; https://xdebug.org/docs/all_settings#client_port
xdebug.client_port=9003
; https://xdebug.org/docs/all_settings#start_with_request
xdebug.start_with_request=default

; https://xdebug.org/docs/all_settings#var_display_max_data
;xdebug.var_display_max_data=512
; https://xdebug.org/docs/all_settings#var_display_max_depth
;xdebug.var_display_max_depth=3
; https://xdebug.org/docs/all_settings#var_display_max_children
;xdebug.var_display_max_children=128
; https://xdebug.org/docs/all_settings#cli_color
;xdebug.cli_color=1
; https://xdebug.org/docs/all_settings#show_local_vars
;xdebug.show_local_vars=0
; https://xdebug.org/docs/all_settings#dump_globals
;xdebug.dump_globals=true
; https://xdebug.org/docs/all_settings#dump_once
;xdebug.dump_once=true
; https://xdebug.org/docs/all_settings#dump_undefined
;xdebug.dump_undefined=false;
; https://xdebug.org/docs/all_settings#dump.*
;xdebug.dump.SERVER=REMOTE_ADDR,REQUEST_METHOD
;xdebug.dump.GET=*
;xdebug.dump.POST=*
; https://xdebug.org/docs/all_settings#file_link_format
;xdebug.file_link_format =
; https://xdebug.org/docs/all_settings#filename_format
;xdebug.filename_format = ...%s%n
; https://xdebug.org/docs/all_settings#max_stack_frames
;xdebug.max_stack_frames=-1
; https://xdebug.org/docs/all_settings#show_local_vars
;xdebug.show_local_vars=0
; https://xdebug.org/docs/all_settings#show_error_trace
;xdebug.show_error_trace=0
; https://xdebug.org/docs/all_settings#show_exception_trace
;xdebug.show_exception_trace=0

I hade the same issue, It seems xdebug in version 3 needs a different config, It's my xdebug.ini file which I'm using and it's working properly:
; Old Xdebug Docker configuration
; https://serversforhackers.com/c/getting-xdebug-working
;xdebug.remote_enable=1
;xdebug.remote_handler=dbgp
;xdebug.remote_port=9000
;xdebug.remote_autostart=1
;xdebug.remote_connect_back=0
;xdebug.remote_idekey=phpstorm
;xdebug.remote_host=host.docker.internal

; New Xdebug Docker configuration
; https://xdebug.org/docs/upgrade_guide
; https://xdebug.org/docs/all_settings#mode
xdebug.mode=debug,trace
; https://xdebug.org/docs/step_debug
; https://xdebug.org/docs/all_settings#discover_client_host
xdebug.discover_client_host=true
; https://xdebug.org/docs/all_settings#client_discovery_header
xdebug.client_discovery_header=HTTP_XDCB
; https://xdebug.org/docs/all_settings#client_host
; in linux it doesn't work on docker 19 version, because of domain name
xdebug.client_host=host.docker.internal
; https://xdebug.org/docs/all_settings#client_port
xdebug.client_port=9003
; https://xdebug.org/docs/all_settings#start_with_request
xdebug.start_with_request=default

; https://xdebug.org/docs/all_settings#var_display_max_data
;xdebug.var_display_max_data=512
; https://xdebug.org/docs/all_settings#var_display_max_depth
;xdebug.var_display_max_depth=3
; https://xdebug.org/docs/all_settings#var_display_max_children
;xdebug.var_display_max_children=128
; https://xdebug.org/docs/all_settings#cli_color
;xdebug.cli_color=1
; https://xdebug.org/docs/all_settings#show_local_vars
;xdebug.show_local_vars=0
; https://xdebug.org/docs/all_settings#dump_globals
;xdebug.dump_globals=true
; https://xdebug.org/docs/all_settings#dump_once
;xdebug.dump_once=true
; https://xdebug.org/docs/all_settings#dump_undefined
;xdebug.dump_undefined=false;
; https://xdebug.org/docs/all_settings#dump.*
;xdebug.dump.SERVER=REMOTE_ADDR,REQUEST_METHOD
;xdebug.dump.GET=*
;xdebug.dump.POST=*
; https://xdebug.org/docs/all_settings#file_link_format
;xdebug.file_link_format =
; https://xdebug.org/docs/all_settings#filename_format
;xdebug.filename_format = ...%s%n
; https://xdebug.org/docs/all_settings#max_stack_frames
;xdebug.max_stack_frames=-1
; https://xdebug.org/docs/all_settings#show_local_vars
;xdebug.show_local_vars=0
; https://xdebug.org/docs/all_settings#show_error_trace
;xdebug.show_error_trace=0
; https://xdebug.org/docs/all_settings#show_exception_trace
;xdebug.show_exception_trace=0

For me it was to remove the develop mode
xdebug.mode=debug

For me it was to remove the develop mode
xdebug.mode=debug

This worked for me as well


Incorrect parsing of parametric function Result

According to https://golang.org/ref/spec#Function_types, a function can declare its return types as a list of parameters. The following function, therefore, is valid:
func f() (a, b io.Reader, c error) {
	return
}

Gocode, however, incorrectly determines that the second return type from f is error, not io.Reader, as demonstrated by the following:
package main

func f() (a, b io.Reader, c error) { return }

func main() {
	a, b, c := f()
	b.
}

With the above saved as issue.go:
$ gocode -in ./issue.go autocomplete 94
Found 1 candidates:
  func Error() string

Thank you for gocode!

Thanks for reporting it.


Tree traversal in smalltalk

Ok, I fixed a typo and shortened it.

@nic-hartley would you mind reviewing the changes?

@Neverik Make sure to fix the merge conflicts, and this can probably be merged then


De-incubate file system watching

Fixes #14195
Fixes #14128
Remove the incubation message when file system watching is enabled, and drop "unsafe" from file system watching-related property names.

@bot-gradle test QFL please

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test this please.

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this please.

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this please.

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@wolfs PTAL post merge!


Fix touches from erroring when running in embedded mode

Fixes #390 by making sure that the end event target started within the node we care about - the embedded target.

It's not like this anymore.


How to use the "IN" clause using the select statement

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[ ] I commit to help with one of those options 👆

Example Code
# Something similar to this from sqlalchemy

session.execute(
    select(
        [MyUserTable.c.id, MyUserTable.c.name],
        MyUserTable.c.id.in_((123, 456))
    )
).fetchall()

Description
Trying to use the "IN" clause in the sqlmodel, where I could filter out based on a list of values
Operating System
Linux
Operating System Details
No response
SQLModel Version
0.0.6
Python Version
3.10.4
Additional Context
No response

Hi, try this way:
        db_setting = session.exec(select(Settings).where(Settings.id.in_([1,2,3]))).all()

Thanks, @mgurg, this works. Weirdly enough, pylance won't recognize .in_() as a member function of the attribute, so I was thinking this wouldn't work. Any idea why?

try https://sqlmodel.tiangolo.com/tutorial/where/#type-annotations-and-errors
from sqlmodel import col
col(Settings.id).in_([1,2,3])

I read the whole documentation and don't know how I could have missed this. Thank you, @hrehfeld!


[Feature] Metadata should be visible and editable in the admin dashboard.

Currently metadata is only visible in the raw metadata field in admin dashboard.
All metadata should be displayed in the dashboard anywhere they used.
And also possibly be editable in case of a customer change request.
Two of current, very much needed use cases:

For parcel locker shipments a customer needs to provide a Parcel Locker Id (selected from some custom storefront Locker Map).
As this data would be sent in metadata, non technical shop operator would not see it in the dashboard. He also can't edit it.
Currently there's no business identifier field (CVR in Denmark) in the billing details address. This data would be also sent in metadata making it invisible for shop operator (relevant issue: https://github.com/medusajs/medusa/issues/1466)

I understand we could 'hack' the admin theme, but this is not desirable since such edits would lock us out of admin theme updates.
And the admin theme is awesome on its own, would not want to mess with it ;)
There are already such ui elements in the admin. Here from creating fullfilment:

Would be great to attach this anywhere they're needed and also displaying them.
Creating, editing and displaying.

Agree, also need this.

@madsviktor @chemicalkosek We've expedited this request and will release it within the coming days on all domains in the admin 💯

Agreed! This would come in handy for many uses cases.

need this


What stops someone else from writing a managed app that accesses your key vault?

Is the Appliance Resource Provider tied to a specific managed app definition?  if so, how?
It seems like anyone could just write a managed app that points at your key vault and get right in.
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2fd769b4-4c68-88be-bf6c-30ad3c355b82
Version Independent ID: e5b2d116-ac1c-84ef-eeec-e9107019b982
Content: Use Key Vault when deploying managed app - Azure Managed Applications
Content Source: articles/azure-resource-manager/managed-applications/key-vault-access.md
Service: managed-applications
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@xaxxon Thanks for the comment. We are looking into this and will get back to you shortly.

@xaxxon Apologies for delayed response, assigning this to our document author @tfitzmac to further help answer your query and see if any document enhancement is needed.

#reassign:davidsmatlak

@xaxxon Thanks for your feedback about the documentation. Unfortunately, your issue wasn't reviewed in a timely manner. Your issue remains open and will be reviewed, and the timeline for resolution may vary based on resourcing. There was a recent change to the content's author and I'm working through the open GitHub issues and updating documentation. I'll post a comment when I'm working on your issue.

The Applicance Resource Provider is a service principal in your Azure Active Directory tenant. In the article, you assign a role to the service principal to access to the key vault. In the Add service as contributor section I added some content about the service principal and in the Next steps included links to more information about key vault security and how it works with Azure Active Directory and Azure role-based access control.
I submitted pull request for this issue and after the pull request is merged, this issue will automatically close. After the merge, the updated document will be online within 24 hours.


Additional environmental variables not added when building from Git branch

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v12.22.7
Amplify CLI Version
6.3.1
What operating system are you using?
Ubuntu
Amplify Categories
api
Amplify Commands
push
Describe the bug
Create a serverless container based API.  Give it permissions to storage.  amplify push to a dev environment.  Git push to feature branch, then merge to a branch that Amplify is tracking to trigger a build.  This part works fine.
Then, give it permissions to another API (in my case, a graphql API) via amplify api update.  amplify push to dev environment.  Everything works.  Git push to feature branch, then merge to the branch that Amplify is tracking to trigger a build.  The new environmental variables are not added to the Task Definition.
The new environmental variables are in the cloud formation yaml in ./amplify/backend/api/[apiname]/[apiname]-cloudformation-template.json for my "dev" environment.  However, if I amplify pull --appId [appid] --envName [github branch env] the variables are not in the cloudformation template.  If I then locally update the serverless container API to include the additional permissions and amplify push Amplify tells me that there are no changes and nothing is pushed.
Expected behavior
I expect Amplify to respect the cloudformation template in my branch when building from a branch for serverless containers.
Reproduction steps
Create a serverless container based API.  Give it permissions to storage.  amplify push to a dev environment.  Git push to feature branch, then merge to a branch that Amplify is tracking to trigger a build.  This part works fine.
Then, give it permissions to another API (in my case, a graphql API) via amplify api update.  amplify push to dev environment.  Everything works.  Git push to feature branch, then merge to the branch that Amplify is tracking to trigger a build.  The new environmental variables are not added to the Task Definition.
GraphQL schema(s)
Not applicable
Log output
No relevant logs
Additional information
This is a screenshot of the env variables in my dev project:

This is a screenshot in the Amplify project connected to the github branch:

For some reason the amplify/backend/backend-config hadn't been merged into the branches that Amplify was connected to.  Once that file got merged (with the environmentMap containing the updated variables) this was addressed.


AllJoyn related project updates to make compatible with Update 2, new checksum algorithm

Project updates to make compatible with Update 2, new checksum algorithm

Hi @zhuridartem, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

:+1:


Upgrade PHPUnit

The PHPUnit 7.x version is the latest for this repository.
If upgrading the PHPunit version to the 8.x, i should drop php-7.1 and let this package require php-7.2 at least.

I am sorry this issue wasn't clear. When I opened it, PHPUnit was an old version, I think we are good with what we have now and I don't feel like removing 7.1 from support. Thanks anyways!


Change key file format to raw bytes when encrypted

Use File.WriteAllBytes/ReadAllBytes when reading/writing encrypted data blobs instead of a base64 encoded string

I guess we want to wait on this before release of next preview since it's changing the format ...

looks good


[backport] Ensure predict leaf output 1-dim vector where there's only 1 tree. (#6889)

Codecov Report

Merging #6937 (a54604c) into release_1.4.0 (96f8843) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release_1.4.0    #6937   +/-   ##
==============================================
  Coverage          81.80%   81.80%
==============================================
  Files                 13       13
  Lines               3852     3852
==============================================
  Hits                3151     3151
  Misses               701      701

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f8843...a54604c. Read the comment docs.


inconsistent isPressed state when focus is moved to another element

🐛 Bug Report
We have a Select component that uses react-aria's hooks. When the select popover opens we move the focus to another dom element inside the popover. When we move the focus to another element like this, button's isPressed stays true.
🤔 Expected Behavior
isPressed should be false when we change the focus from button to another element
😯 Current Behavior
button's isPressed state stays true when focus is moved to another dom element. And since isPressed true button will ignore press/click event triggers.

🔦 Context
we have a components library that uses react-aria
💻 Code Sample
https://codesandbox.io/s/naughty-blackwell-nnsxu?file=/src/App.tsx

@deebov I tried your codesandbox and it seems to toggle the input element appearance on/off just fine. The console.logs seem to indicate that isPressed is being set to false on mouse up as well.

@deebov I tried your codesandbox and it seems to toggle the input element appearance on/off just fine. The console.logs seem to indicate that isPressed is being set to false on mouse up as well.

oh sorry, I forgot to be more specific.

Refresh the page
Set the focus to button with Tab
Press Space
Click the button with mouse and it should ignore the click

Looks like we have something that's supposed to be dealing with that https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/interactions/src/usePress.ts#L226
but isn't, I'd start debugging here

Thanks for the repro steps @deebov, will need to investigate why that line that @snowystinger linked doesn't seem to be handling this situation properly

Experiencing the same issue. A similar re-production scenario sandbox: https://codesandbox.io/s/react-spectrum-template-forked-vy3n1m?file=/src/App.js
Did some digging and here is the result:
When the input is focused immediately after keydown, keyup happens on the input. To handle this case, onKeyUp handler is set on document (probably what @snowystinger linked too as well). And there is even a test case for that: https://github.com/adobe/react-spectrum/blob/a162e5b235fcdc79087ea6d64c726664dc9d4179/packages/%40react-aria/interactions/test/usePress.test.js#L2071
BUT, in that test case, keyup is triggered on body. It's different when it's triggered on an input, because isValidKeyboardEvent here would return false in that case:
https://github.com/adobe/react-spectrum/blob/9498c7d858b08e03b4c36fac491b9e4434453da0/packages/%40react-aria/interactions/src/usePress.ts#L292
And state.isPressed would not reset to false.
I adjusted the test case in this branch to cover this case too: https://github.com/adobe/react-spectrum/commit/e5740c3971986932226325b046f9fbb765c812ea
Removing isValidKeyboardEvent check in onKeyUp would pass the updated test without breaking any other test case, but I don't have a good overview of usePress and am not sure if everything in that if block should run in this case.

I can still open a small PR from https://github.com/adobe/react-spectrum/commit/e5740c3971986932226325b046f9fbb765c812ea to adjust the existing test case to cover this scenario. Let me know if it makes sense.

We'd love it if you contributed a test. The better and more accurate our tests the less likely we are to regress and that's fantastic

Going to close this since apparently it's fixed.


Support multiple RPCHook

MQ have to suport multiple RPCHook,more flexibility, for example Limiting,auth,Message Tracer

+1 to provide a RPC hook chain.

@fuyou001 Have you ever considered the mechanism for loading user's implementation from the classpath? This will prevent users from modifying the source code to recompile.

@duhengforever no.


Added allocations to distributors

Added allocations to distributors

Run "hack/globalscheduler/globalscheduler-up.sh"
Run "cluster/kubectl.sh apply -f globalscheduler/test/yaml/sample_2_schedulers.yaml"
Run "cluster/kubectl.sh apply -f globalscheduler/test/yaml/sample_4_clusters.yaml"
Run "cluster/kubectl.sh apply -f globalscheduler/test/yaml/sample_2_distributors.yaml"
Run "cluster/kubectl.sh apply -f globalscheduler/test/yaml/sample_2_allocations.yaml"
Run "cluster/kubectl.sh get allocations" and found the 2 allocations status phases have changed to "Assigned"

this ready for merge right?

this ready for merge right?

Yes.


Specify the Redirect URI in controller

Hi All,
Is there a way to specify the redirectURI property in the controller?

Officially there is no way to do it, but others have injected SatellizerConfig service into a controller and updated configuration objects that way.


chore: upgrade actions to use node20

Not sure why warnings doesn't show up here
https://github.com/reMarkable/helmfile-nix/actions/runs/8970048640/job/24632687211

Not sure why warnings doesn't show up here https://github.com/reMarkable/helmfile-nix/actions/runs/8970048640/job/24632687211

They did, on the summary page


Update README.md

Feel free to add the Actionable docker for postgres too. So we can push this in a single commit

hey i really dont know about the docker command for postgres can you help me getting this?

docker run --name some-postgres -e POSTGRES_PASSWORD=mysecretpassword -d postgres
is this command good ?

Actionable docker Postgres setup
docker run --name <your-db-name> -p 5432:5432 -e POSTGRES_PASSWORD=<your-db-password> -d postgres

Change<your-db-name> and <your-db-password> with a Database Name and Database Password

Sample DATABASE_URL

postgresql://postgres:<your-db-pass>@localhost:5432/postgres?schema=public

I have made a new pull request with the required chances plz check it
On Sat, 13 Apr, 2024, 8:41 pm Sujith Thirumalaisamy, <
@.***> wrote:

Actionable docker Postgres setup
docker run --name  -p 5432:5432 -e POSTGRES_PASSWORD= -d postgres
Change and  with a Database Name and Database
Password
Sample DATABASE_URL
@.***:5432/postgres?schema=public
—
Reply to this email directly, view it on GitHub
https://github.com/code100x/daily-code/pull/217#issuecomment-2053673160,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXGSF5FERE6TF54WHQ3BJC3Y5FDINAVCNFSM6AAAAABGFPWRLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTGY3TGMJWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Character replacement empties textfield for specific chars

Hello,
I've written a character replacer that replaces unwanted characters in a textfield with others. I'd created a directive and put it on the textfield.
.directive('charreplacer', ['$parse', function($parse) {
    return {
      restrict: 'A',
      require: 'ngModel',
      link: function($scope, element, attr, ctrl) {
        ctrl.$parsers.push(function(value){
            value = value.replace(/[äÄáâàåæöÖóøüÜçÇéêèùûîíñßšµ¹²³€£¤¦,¨´¸¼½¾\s]/g, function(m) {
              return {
              'ä': 'ae',
              'Ä': 'Ae',
              'á': 'a',
              'â': 'a',
              'à': 'a',
              'å': 'a',
              'æ': 'ae',
              'ö': 'oe',
              'Ö': 'Oe',
              'ó': 'o',
              'ø': 'o',
              'ü': 'ue',
              'Ü': 'Ue',
              'ç': 'c',
              'Ç': 'C',
              'é': 'e',
              'ê': 'e',
              'è': 'e',
              'ù': 'u',
              'û': 'u',
              'î': 'i',
              'í': 'i',
              'ñ': 'n',
              'ß': 'ss',
              'š': 's',
              ' ': '-',
              'a': 'q',
              'µ': 'm',
              '¹': '1',
              '²': '2',
              '³': '3',
              '€': 'E',
              '£': 'L',
              '¤': '',
              '¦': '',
              ',': '',
              '¨': '',
              '´': '',
              '¸': '',
              '¼': '',
              '½': '',
              '¾': ''
            }[m];
        });
            ctrl.$setViewValue(value);
            ctrl.$render();
            return value;
        });
      }
    };
  }])

If I test it in Chrome everything is fine. In my Firefox 38.3.0 characters like éèêáàâóîí causing that the textbox will be empty.
I've seen that the with these characters the replacement happens twice. One time normal, the second time, a empty String comes in.
The characters have to been written in the textfield. To copy and paste it into the textfield doesn't cause this bug.

When you are using $setViewValue inside a parser, it runs the whole parser / model update pipeline again before returning the new value. Please don't do this, as it can lead to unexpected behavior.
This should work:
            ctrl.$viewValue = value;
            ctrl.$render();

And another thing: we only test against the latest version of "evergreen" browsers. So you should really update your Firefox to at least 38.7.0, which is the current  Extended Support Release. There was a bug in previous versions of Firefox that you seem to be hitting.

I've updated my firefox to 43.0.2, but the error still occurs

I should have added that I couldn't reproduce the error. Can you please
create a demo with exact steps to reproduce? And have you tried my changes
to your directive?
Am 23.12.2015 15:30 schrieb "eueumasl"<EMAIL_ADDRESS>
I've updated my firefox to 43.0.2, but the error still occurs
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/issues/13620#issuecomment-166908134
.

I was able to reproduce the error in an isolated project:
https://jsfiddle.net/gc0xae7z/

@Narretz could you reproduce it with your Firefox?

@Narretz Could you please have a look on this bug?

@eueumasl Sorry, I didn't see your update. Will look at it today.

So I'm using FF 44, and I cannot reproduce this issue. How do you enter these characters? On my German keyboard, I have to press ` first, then e, and the input is as expected output as e. I have also copy and pasted è and it's also converted to e.

I'm using FF 43 and a German keyboard too. Copy and paste works fine and the é is converted to e. But pressing ´ and then e causes the textfield to be emptied.
I'm currently updating to FF 44 and will test it again.

In FF 44 it sill occurs. Could it be that the operating system makes a difference? I'm using Ubuntu 14.04

Am 01.02.2016 um 15:12 schrieb eueumasl:

In FF 44 it sill occurs. Could it be that the operating system makes a
difference? I'm using Ubuntu 14.04
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/issues/13620#issuecomment-177988330.

Possibly, yes. I'm on Windows 7.

Closing as there is no indication this is an Angular issue. Possibly a browser/OS combination bug.


bootstrap of cluster (IE addition of new node, not change to old one) should be parallel "unconditionally"

Extension of https://github.com/Altinity/clickhouse-operator/pull/1124
But for specific case, when we add new nodes (or start cluster from 0), not change old one.
For that particular case, sequential start for first shard can be unneeded, plus "Max percentage of the cluster's shards that may be reconciled concurrently (up to X% shards in parallel)" can be ignored.

It works this way since 0.22.0. Here is 4 shard cluster
I0214 06:06:40.821117       1 worker.go:1548] createStatefulSet():Create StatefulSet eu/chi-test-4-test-4-1-0 - started
I0214 06:06:41.021358       1 worker.go:1548] createStatefulSet():Create StatefulSet eu/chi-test-4-test-4-3-0 - started
I0214 06:06:41.221569       1 worker.go:1548] createStatefulSet():Create StatefulSet eu/chi-test-4-test-4-2-0 - started
I0214 06:06:41.425166       1 worker.go:1548] createStatefulSet():Create StatefulSet eu/chi-test-4-test-4-0-0 - started


Moved outline-view docs and test folders to component dev-site folder

Summary

Since Terra-Outline-View is not published yet moving the doc examples and test pages from terra-core-docs to component dev-site folder to avoid build issues that might happen when terra-core-docs is referred in projects like cerner-clinical-theme.

Closes #
Deployment Link

https://terra-core-move-outline-eyz5dt.herokuapp.com/components/terra-outline-table-view/outline-table-view/about
https://terra-core-move-outline-eyz5dt.herokuapp.com/tests/terra-outline-table-view/outline-table-view/outline-table-view

Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Need to change the browser.url parameter since test file location has been changed. I think build is failing due to that.

c47b74b

updated : https://github.com/cerner/terra-core/pull/3663/commits/c47b74bd7088a5dbc4ef12e76cd944919346bf1f


Cleanup release index

Actually seems like the unassigned nodes did not get updated as they should have been and therefore we had old revisions being "active" and constantly rechecked.
Instead of merging this PR we should probably fix the regular updates of the unassigned nodes. There is now a separate proposal that we can vote in, that updates unassigned nodes. It will be used by default in the DRE tool once https://github.com/dfinity/dre/pull/411 is merged.


Api for release component contacts and global component contacts.

Missing API Doc for both of new end-points

@erichuanggit Let's not write documentation until we know this is actually the direction we want to go in.


OpenRoad version / git describe not found

After switching to the git describe version, all I see get is:
-- OpenROAD version: 1
-- OpenROAD git describe: -128-NOTFOUND

What happens if you run 'git describe'?

git describe
fatal: No names found, cannot describe anything.

This happens when I call it from the Openroad-flow / tools / OpenROAD (a submodule)
but when I run it on a non-submodule, I get v2.0-854-ga462d24d3

@maliberty running cmake on the non-submodule gives me:
-- OpenROAD version: 1
-- OpenROAD git describe: v2.0-856-g13d06cda0

It seems strange as well that the git describe is saying v2.0 and OR version is 1.

I think I narrowed it down a little. Since we have a copy of the repo, the tags were not copied over. Doing that fixed the  issue with  -128-NOTFOUND, but a better fallback or warning might be good.

Fixed with 6e80ae096c9ae61e86057b7e9116bc9b44dde37a


Checking for CreatedOn column in HistoryContext is always performed using 'dbo' schema

My codefirst BD is deployed using a custom schema, so all my tables are [myschema].[tablename]. I'm logging an error on EF initialization where this query is performed:
SELECT TOP (1)
[c].[CreatedOn] AS [CreatedOn]
FROM [dbo].[__MigrationHistory] AS [c]

All others 'migrations' query are performed using correct schema name, for example:
SELECT
[GroupBy1].[A1] AS [C1]
FROM ( SELECT
    COUNT(1) AS [A1]
    FROM [myschema].[__MigrationHistory] AS [Extent1]
    WHERE [Extent1].[ContextKey] = @p__linq__0
)  AS [GroupBy1]

So it seems that something is missing in this query.

This is by design, EF runs a bunch of different queries against the database to work out what state it is in - in this case, it's part of working out whether the database has an old version of the migrations history table. It catches the exceptions and swallows them, so you shouldn't see any failures at the app level.


Enable a debug interface during development?

During development, it would be helpful to include an interface within the window that displays current map settings in realtime (i.e. center, zoom, etc.). This would make it much simpler to create/edit map animations, layers, points, etc. on the fly.
Looking into the PR backlog for eegeo.js there's a branch referencing Three.js. The debug functionality I'm asking about is included with Three.js (example can be found at the top right corner of the page here: https://threejs.org/examples/#misc_sound).
Is this currently available in eegeo.js? If not, anyway to quickly enable something similar? I can't find any DOCs listing API's exposed at runtime.

Have added this to roadmap, agree with suggestion. Will add an optional debugging widget that displays this information.

heh, nice little workaround. Works fine for the short term.


[PE-D][Tester A] User Guide example picture is not visible

The user guide for auto complete section is not very clear.
Suggested Changes:
Zoom in more to the command and the auto complete result.
Proof:

Labels: severity.VeryLow type.DocumentationBug
original: HanB1n/ped#11

Duplicate of #220.


SSL options to connect to pgsql

I think that it can be useful to have the possibility to specify the ssl options while configuring the connection to the pgsql database.
Now it is possible to enable ssl connections but it does not seem possible to enable CA verification and full verification of the server certificate (see libpq ssl support).
The epgsql library seems to support this kind of configuration through the ssl_opts in the connect_options of the connect method (see connect example).
I think that this enhancement would require some modifications of the configuration file processing and in the code of the method conn_opts in emq_auth_pgsql_cli.erl.
Best regards.

Hi,
I have been testing this functionality and I can't get it working. I don't see how to configure the pgsql connection to verify the SSL connection. The options verify and fail_if_no_peer_cert can't be configured.
It seems to me that there are only three options available in the configuration file:
auth.pgsql.ssl_opts.keyfile =
auth.pgsql.ssl_opts.certfile =
auth.pgsql.ssl_opts.cacertfile =

However there is no way to configure verify, so the certificate of the server is not checked against the cacertfile. If I try these configuration options:
auth.pgsql.ssl_opts.verify = verify_peer
auth.pgsql.ssl_opts.fail_if_no_peer_cert = true

The broker refuses to start with the followin messages in the log:
11:20:40.547 [error] You've tried to set auth.pgsql.ssl_opts.verify, but there is no setting with that name.
11:20:40.547 [error]   Did you mean one of these?
11:20:40.571 [error]     auth.pgsql.ssl_opts.certfile
11:20:40.571 [error]     auth.pgsql.ssl_opts.keyfile
11:20:40.571 [error]     auth.pgsql.ssl_opts.cacertfile
11:20:40.571 [error] You've tried to set auth.pgsql.ssl_opts.fail_if_no_peer_cert, but there is no setting with that name.
11:20:40.571 [error]   Did you mean one of these?
11:20:40.608 [error]     auth.ldap.ssl.fail_if_no_peer_cert
11:20:40.608 [error]     mqtt.listener.https.fail_if_no_peer_cert
11:20:40.608 [error]     mqtt.listener.ssl.fail_if_no_peer_cert
11:20:40.612 [error] Error generating configuration in phase transform_datatypes
11:20:40.612 [error] Conf file attempted to set unknown variable: auth.pgsql.ssl_opts.fail_if_no_peer_cert
11:20:40.612 [error] Conf file attempted to set unknown variable: auth.pgsql.ssl_opts.verify

Reviewing the commits involved in this issue it seems to me that one of the commits 8bf8c53 included the possibility to configure verify and fail_if_no_peer_cert but the other two commits not. The final commit that was merged into master seems not to include this 0ec2bdb.
I'm using version 2.1.0 latest
Best regards,

@vpelaez The issue has been fixed in version 2.2.


Shorten api key lengths

refs #10156
This addresses the length of Content API Keys only, so I'm not 100% sure if we should leave the issue open for when Admin API access is done too

Yes please leave the issue open :)


Using quick fix action to rename an identifier does not rename every instance

The "change to" fix action does not use "rename" action,  it only changed the identifier it was called on.
System information
Output of clangd --version:
clangd --version
Ubuntu clangd version 14.0.0-1ubuntu1
Features: linux+grpc
Platform: x86_64-pc-linux-gnu

Also clangd 15.0.6 that is downloaded with clangd extension in VSCode
Editor/LSP plugin:
VSCode/ llvm-vs-code-extensions.vscode-clangd
Operating system:
Ubuntu 22.04.2 LTS

Could you provide a code example please, and indicate where in the code you are performing the code action?

Here's some example code that has this issue:
ExampleClass.hpp
#pragma once

class test {

    public:

    test();

    float ThisIsAVariable;

    float ThisIsAFunction(float);

};

ExampleClass.cpp
#include "ExampleClass.hpp"

test::test() : ThisIsAVariable(1) {};

float test::ThisIsAFunction(float b){
    return ThisIsAVariable * 2 - b;
}

main.cpp
#include "ExampleClass.hpp"
#include <iostream>

int main() {

  std::cout << "test " << test().ThisIsAFunction(22) << std::endl;

}

.clang-tidy
Checks: "bugprone-*,
  modernize-*,
  -modernize-use-trailing-return-type,
  -modernize-use-using,
  readability-*,
  clang-analyzer-*,
  clang-diagnostic-*,
  cppcoreguidelines-*,
  -cppcoreguidelines-owning-memory,
  performance-*,
  -fuchsia-*,
  -*-use-auto,
  -cert-err58-cpp,
  -google-readability-todo,
  "
HeaderFilterRegex: ".*"
CheckOptions:
  - {key: readability-implicit-bool-conversion.AllowPointerConditions, value: 1}
  - { key: readability-identifier-naming.NamespaceCase,                value: CamelCase }
  - { key: readability-identifier-naming.TypedefCase,                  value: CamelCase }
  - { key: readability-identifier-naming.TypedefSuffix,                value: _t }
  - { key: readability-identifier-naming.TypeAliasCase,                value: CamelCase }
  - { key: readability-identifier-naming.TypeAliasSuffix,              value: _t }
  - { key: readability-identifier-naming.ClassCase,                    value: CamelCase}
  - { key: readability-identifier-naming.TemplateCase,                 value: CamelCase}
  - { key: readability-identifier-naming.TemplatePrefix,               value: T}
  - { key: readability-identifier-naming.StructCase,                   value: CamelCase }
  - { key: readability-identifier-naming.AbstractClassCase,            value: CamelCase}
  - { key: readability-identifier-naming.AbstractClassPrefix,          value: I}
  - { key: readability-identifier-naming.PrivateMemberCase,            value: CamelCase }
  - { key: readability-identifier-naming.PrivateMemberPrefix,          value: m_ }
  - { key: readability-identifier-naming.ProtectedMemberCase,          value: CamelCase }
  - { key: readability-identifier-naming.ProtectedMemberPrefix,        value: m_ }
  - { key: readability-identifier-naming.PublicMemberCase,             value: camelBack}
  - { key: readability-identifier-naming.ParameterCase,                value: camelBack }
  - { key: readability-identifier-naming.LocalVariable,                value: camelBack}
  - { key: readability-identifier-naming.ConstantCase,                 value: CamelCase}
  - { key: readability-identifier-naming.ConstantPrefix,               value: c_}
  - { key: readability-identifier-naming.EnumCase,                     value: CamelCase}
  - { key: readability-identifier-naming.EnumConstantCase,             value: CamelCase }
  - { key: readability-identifier-naming.ProtectedMethodCase,          value: camelBack }
  - { key: readability-identifier-naming.PublicMethodCase,             value: camelBack}
  - { key: readability-identifier-naming.PrivateMethodCase,            value: camelBack}
  - { key: readability-identifier-naming.PrivateMethodPrefix,          value: _}
  - { key: readability-identifier-naming.MacroDefinitionCase,          value: UPPER_CASE }

The issue happens when you try to do the auto fix (or just fix) float ThisIsAVariable or float ThisIsAFunction(float); in ExampleClass.hpp

Thanks, I see now: when invoking the quick fix for clang-tidy's "invalid case style", which is to rename the variable, only occurrences in the current file are renamed, not occurrences in other files.
This is kind of an interesting problem. Currently, clangd just passes through the quick fix produced by the clang-tidy checker. The clang-tidy checker operates on a translation unit level, so it doesn't have the capability to produce a quick fix that makes edits to other translation units.
On the other hand, clangd does have the capability to rename a variable across translation units, using its index of the project. In theory, clangd could "upgrade" the clang-tidy quick fix from a "local rename" to a "global rename". But to do this, clangd would need to understand that the quick-fix is "rename symbol X", rather than "make these edits to this file" which is the current information clang-tidy provides.

I wonder if perhaps a solution could build upon the proposal in this RFC to "enhance clang-tidy with project-level knowledge". Then perhaps clang-tidy could produce the multi-TU quick fix itself.

For neovim users, here's a (slightly modified) snippet from my config that takes a clang-tidy rename code action and forwards it to clangd (Probably something similar could be built for vscode):
require'lspconfig'.clanngd.setup {
   on_attach = function(client, bufnr)
        vim.api.nvim_create_user_command('ClangdApplyRename', function() apply_next_rename(client) end, {})
   end
}

 function apply_next_rename(clangd)
    local params = vim.lsp.util.make_range_params()
    params.context = {
        diagnostics = vim.lsp.diagnostic.get_line_diagnostics()
    }
    local result = clangd.request_sync('textDocument/codeAction', params, 1000)

    if result.err then
        vim.notify(vim.inspect(result.err), "error")
        return
    end

    local current_column = vim.fn.col('.') - 1 -- LSP is 0-indexed

    local find_name = function(result)
        for _, action in pairs(result) do
            if (action.diagnostics and action.diagnostics[1] and action.diagnostics[1].code == 'readability-identifier-naming') then
                local range = action.diagnostics[1].range
                if (range.start.character <= current_column and current_column < range['end'].character) then
                    -- Simply use the first new text, they should all be the same
                    for file, change in pairs(action.edit.changes) do
                        return change[1].newText
                    end
                end
            end
        end
    end
    local newName = find_name(result.result)

    if not newName then
        vim.notify("No rename code action at this line!", "error")
        return
    end

    params = vim.lsp.util.make_position_params()
    params.newName = newName

    result = clangd.request_sync('textDocument/rename', params, 1000)
    if result.err then
        vim.notify(vim.inspect(result.err), "error")
        return
    end

    vim.lsp.util.apply_workspace_edit(result.result, clangd.offset_encoding)
end

@tom-anders very interesting :)

In theory, clangd could "upgrade" the clang-tidy quick fix from a "local rename" to a "global rename". But to do this, clangd would need to understand that the quick-fix is "rename symbol X", rather than "make these edits to this file" which is the current information clang-tidy provides.

So your script solves this problem by hardcoding the information, "for the readability-identifier-naming diagnostic, the quick-fix is conceptually a rename, with the newText field of the first change storing the new name".
I guess if we are fine with hard-coding such things in clangd, there's no reason the server couldn't do this, and replace the quick-fix with a Command that performs a workspace-wide rename when invoked.

@tom-anders very interesting :)

In theory, clangd could "upgrade" the clang-tidy quick fix from a "local rename" to a "global rename". But to do this, clangd would need to understand that the quick-fix is "rename symbol X", rather than "make these edits to this file" which is the current information clang-tidy provides.

So your script solves this problem by hardcoding the information, "for the readability-identifier-naming diagnostic, the quick-fix is conceptually a rename, with the newText field of the first change storing the new name".
I guess if we are fine with hard-coding such things in clangd, there's no reason the server couldn't do this, and replace the quick-fix with a Command that performs a workspace-wide rename when invoked.

Yeah IMO hardcoding this should be fine, the "API" of the quick-fix should never change in the future, and if clang-tidy at some point gains the ability to do a "global rename", it would not even break our hardcoded logic.
I can try implementing this in clangd and see what the feedback is - if it's not accpected, at least then we'll have an editor-agnostic patch that people can use.

I can try implementing this in clangd and see what the feedback is - if it's not accpected, at least then we'll have an editor-agnostic patch that people can use.

Sure! I'm happy to help by reviewing.

@HighCommander4 Here's a draft: https://github.com/llvm/llvm-project/pull/78454/files
Feel free to add some comments when you have time - We should probably add a lit-test, I'll do that once we agree on implementation details

This was fixed for clangd 19 in https://github.com/llvm/llvm-project/pull/78454.


SYMP-67 | End on Vulnerable Populations question

Ticket: https://freshworks.atlassian.net/jira/software/c/projects/SYMP/boards/288?modal=detail&selectedIssue=SYMP-67

Nice one!


Update Open from ABS modal copy

Describe the bug
The copy on the modal shown when you open from ABS needs to be updated.

Please amend this copy to the following.
Title: Choose a bot project for your Azure Bot
Subtext: Use your Azure Bot resource with a new or existing bot project. You can publish your bot project directly to Azure, using the publishing profile created for you. Learn more.
Option 1: Create a new bot project
Option 2: Use an existing bot project
The learn more link should link to https://docs.microsoft.com/en-us/composer/quickstart-create-bot-with-azure (we probably need an aka.ms link for this if we don't already have one for use in Composer).
FYI @JonathanFingold as our docs will need to be updated following this change in R14 and the screenshots over there already look out of date anyway https://docs.microsoft.com/en-us/composer/quickstart-create-bot-with-azure.

Can the title say "Choose a bot project for your Azure Bot" (remove the "Create /")? There are a few places in the UI where we tell the user to choose something and among the choices is the ability to create a new thing.
@mareekuh for copy review

Oh I like that! Good idea!
From: mewa1024 @.>
Date: Wednesday, June 23, 2021 at 8:06 PM
To: microsoft/BotFramework-Composer @.>
Cc: Marieke Iwema @.>, Mention @.>
Subject: Re: [microsoft/BotFramework-Composer] Update Open from ABS modal copy (#8166)
Can the title say "Choose a bot project for your Azure Bot" (remove the "Create /")? There are a few places in the UI where we tell the user to choose something and among the choices is the ability to create a new thing.
@mareekuhhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmareekuh&data=04|01|mariekei%40microsoft.com|49ea0a8f4e464e19d88008d936bd0da2|72f988bf86f141af91ab2d7cd011db47|1|0|637601007889431940|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=C6itrHMojj8Qi0VCfI5ssf7bKeFi4%2B93FlF2K8uZWz4%3D&reserved=0 for copy review
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FBotFramework-Composer%2Fissues%2F8166%23issuecomment-867298896&data=04|01|mariekei%40microsoft.com|49ea0a8f4e464e19d88008d936bd0da2|72f988bf86f141af91ab2d7cd011db47|1|0|637601007889441939|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=c%2BUGW5mYeCcC2zWa7IPzD%2Fc%2FjxlE6230mKpZuLO%2BgqE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALSBVCRZ52N7VTEPXCKZ4F3TUKOLBANCNFSM47EBHZRQ&data=04|01|mariekei%40microsoft.com|49ea0a8f4e464e19d88008d936bd0da2|72f988bf86f141af91ab2d7cd011db47|1|0|637601007889451929|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=l7BPbFjI4N7QvakHF6PmzahlEgUkO4u36y1q6X2S0c4%3D&reserved=0.

For the subtext, possible to shorten a little? maybe like:

Use your Azure Bot resource with a new or existing bot project. Later, you can publish your project directly to your Azure Bot resource by using the publishing profile we have created for you. Learn more

Thanks @mewa1024 - good suggestions.
I have amended the title as per your comment and I have updated the sub copy, with a slight tweak from your suggestion, to
Use your Azure Bot resource with a new or existing bot project. You can publish your bot directly to Azure, using the publishing profile created for you. Learn more.
@srinaath please note the tweak in copy - I have updated the copy at the top of the issue for ease. Thanks.

I've linked https://aka.ms/composer-abs-quickstart to that URL in the docs.


Remove deprecated array_ops

@ilblackdragon Feel free to close this if you've done so internally. I expect there will be a lot of clean-up recently.


configs/coco/dcfs_FSIS_r101_novel_shot_seedx.yaml.

Hello, I couldn't find "configs/coco/dcfs_FSIS_r101_novel_1shot_seedx.yaml." Could you please provide it to me? Thank you.

hi，
We thank you for your attention to our work.
This issue has been fixed by updating config files for training FSIS and gFSIS in the "run_coco_fsis.sh". In fact, the same config file is used to train FSOD and FSIS (gFSOD and gFSIS) in our implements.
If there is anything, please do not hesitate to let me know.

 While running the experiments, I also noticed some configuration issues in the run_coco_fsod.sh script: 1. The --eval-only option on line 48 is redundant. 2. You need to add the following line of configuration separately for fsod and gfsod: MODEL.ROI_BOX_HEAD.BBOX_CLS_LOSS_TYPE ${classloss}.
In addition, regarding the experimental section in the paper, I have a question about the distinction between "Ours" and "Ours*." You mentioned that "Ours*" is the average of 10 runs, so what does "Ours" represent? Is it the value for the first run?

We train and test simultaneously during the training process, so the test file is not redundant in https://github.com/gaobb/DCFS/blob/07cad8d0e8ed4239cebb0d1428963264de80241b/run_coco_fsod.sh#L48

The loss function is valid using the current command line mode. For example, https://github.com/gaobb/DCFS/blob/07cad8d0e8ed4239cebb0d1428963264de80241b/run_coco_fsod.sh#L46

In our paper, we have a detailed description of Ours and Ours*. Following the previous work [33], all experimental
results are averaged over 10 seeds. For a fair comparison with DeFRCN [28], we also report the
average results over 10 times repeated runs on seed0."

Thank you for your response. My previous questions contained errors. The incorrect configuration file is run_voc_fsod.sh.


Sass 105: Updating the content for the start page

For reference, prototype above

For the service header I think you'll want to rebase as the header should be correct.
@robert-webb-hmrc your other two comments are valid but we thought that the breadcrumbs one would be completed as part of the breadcrumbs ticket.
& similarly the subheading update be done as part of another ticket to change them all to the same thing. @joeyymoore could you check we have a ticket for the date subheading

Looking at the subheadings it would only be two places in income FE actually (personal FE has different headings), maybe even one message key so it might be easier to update as part of this? @joeyymoore @robert-webb-hmrc thoughts?

So the subheading as per SASS-300 should be "submit" rather than "Submit". This is the case in this frontend as well as the PITSF

So the subheading as per SASS-300 should be "submit" rather than "Submit". This is the case in this frontend as well as the PITSF

good point you're right


Investigate switching from minimatch to picomatch

We use minimatch in our implementation of sh.find() to match glob patterns.  Let's see if we can switch to picomatch, which is smaller, and has zero dependencies.
minimatch is ~7K in our bundle:
node_modules/minimatch/minimatch.js       7.32 KB     11ms

It would be good to see if that goes down with picomatch.
NOTE: picomatch uses the builtin path module, so fixing #597 would help here too.

Comparison of minimatch and picomatch sizes and deps.
First minimatch
dist/minimatch.js                                                                               14.56 KB    611ms
├── minimatch.js                                                                                7.31 KB     17ms
├── ../../../usr/local/lib/node_modules/parcel-bundler/node_modules/process/browser.js           2.27 KB    231ms
├── ../../../usr/local/lib/node_modules/parcel-bundler/node_modules/path-browserify/index.js     2.09 KB      2ms
├── node_modules/brace-expansion/index.js                                                        2.06 KB    176ms
├── node_modules/balanced-match/index.js                                                           601 B    116ms
└── node_modules/concat-map/index.js                                                               259 B     65ms

And picomatch:
dist/index.js                                19.84 KB    17.55s
├── lib/parse.js                              9.62 KB     681ms
├── lib/picomatch.js                          3.18 KB     758ms
├── node_modules/process/browser.js           2.63 KB     200ms
├── lib/scan.js                               2.13 KB     453ms
├── node_modules/path-browserify/index.js      2.1 KB     166ms
└── index.js                                    116 B    16.08s

Filed a bug in picomatch to discuss, and it looks like we can't do much to make it smaller than it is (4.7K minified and gzipped vs. 4.1K for minimatch), https://github.com/micromatch/picomatch/issues/6
I'm still tempted to consider it, since it has no dependencies.


[New Port Request] Mini-XML

Library name: Mini-XML
Library description: Mini-XML is a tiny XML library that you can use to read and write XML and XML-like data files in your application without requiring large non-standard libraries.
Source repository URL: https://github.com/michaelrsweet/mxml
Project homepage (if different from the source repository): https://www.msweet.org/mxml/
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now, consider making a pull request instead.

I have made a pull request here, but I don't really know what I'm doing here.

can anyone reopen this pls?

This is from 2021!

I am working on adding MSVC support to zynaddsubfx, which uses mxml as a dependency. So i need this port

@Rossmaxx I also need this port for setting up a Zyn CI. Your mentioned PR still has open checkpoints and an open review comment. Maybe you could finish those and continue asking maintainers for help?