cloud_firestore: DocumentSnapshot.data['email'] returns null

Steps to Reproduce
import 'package:flutter/material.dart';
import 'package:stepify/constants/colors.dart';
import 'package:flutter_redux/flutter_redux.dart';
import 'package:stepify/models/app_state.dart';
import 'package:redux/redux.dart';
import 'package:cloud_firestore/cloud_firestore.dart';

class DrawerContainer extends StatelessWidget {
  DrawerContainer({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return new StoreConnector<AppState, _ViewModel>(
      converter: _ViewModel.fromStore,
      builder: (BuildContext context, _ViewModel vm) {
        return new Drawer(
          child: Column(
            children: <Widget>[
              UserAccountsDrawerHeader(
                decoration: BoxDecoration(color: MeSuiteColors.blue),
                accountName: new Text(vm.currentUser.data['displayName']),
                accountEmail: new Text(vm.currentUser.data['email'] ?? "unknown"),
                currentAccountPicture: Icon(
                  Icons.account_circle,
                  size: 50.0,
                  color: Colors.white,
                ),
              )
            ]
          )
        );
      },
    );
  }
}

class _ViewModel {

  final DocumentSnapshot currentUser;

  _ViewModel({@required this.currentUser});

  static _ViewModel fromStore(Store<AppState> store) {
    return new _ViewModel(
      currentUser: store.state.currentUser,
    );
  }
}

vm.currentUser.data['email'] returns a null value!
Seems like the user email value isn't retrieved from Firebase. Firebase provides this according to - https://firebase.google.com/docs/reference/js/firebase.UserInfo#email

Firebase provides this

but is it guaranteed to have a value != null?

@zoechi no, but I’m using google auth along with it, so the field should be populated from prior experience - side note, the vanilla JS library pulls the email so it seems like a plugin-specific issue

Oops, I messed up the auth flow at a point and didn't create a full copy of the currentUser returned by Firebase into Cloud Firestore

@rishab2113
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/439. Any further collaboration will be done there.


Team Task: User Features Ideation

The draft idea for the main and backup user features.
To be completed on 6/1/2023

Send requests form (to request to add / increase)
Login Account (for each of the different center)

TBC with Team 2 for any clashes by Mon 09/01/23
5 Main Features (tentative):

Send requests form (to request to add/increase manpower, donor, etc)
Login Account (for each of the different center)
Automated report generation/submission system for quarterly report (data analysis)
Filter system for display of data(sort from a-z / z-a etc)
Overall dashboard to display data like running cost, donations, etc. for each the centres they manage

Scheduler for board/group meetings? (Event calender kind of thing)
Search bar (to quickly navigate to a report)

Show/hide sender manager name (for request)
Gantt chart

Overall dashboard to display data like running cost, donations, etc. for each the centres they manage.
Graph representation of data (data analysis of current project)


Give back the same values by the output channels

This should fix the problem found by @RyanDavies19 at https://github.com/FloatingArrayDesign/MoorDyn/pull/202
The API still works the new way though.
As I suppose it can be appreciated, the former way is quite inconsistent, at least with respect the fairlead and the anchor. Maybe it would be good to take the axial damping out to it own API method (MoorDyn_GetLineNodeTenD() and moordyn::Line::getNodeTenD())

Oki, tomorrow I will try to do that
On Thu, 9 May 2024, 17:39 RyanDavies19, @.***> wrote:

@.**** commented on this pull request.
In source/Line.cpp
https://github.com/FloatingArrayDesign/MoorDyn/pull/210#discussion_r1595623946
:

@@ -531,12 +531,15 @@ Line::GetLineOutput(OutChanProps outChan)
return rd[outChan.NodeID][1];
else if (outChan.QType == VelZ)
return rd[outChan.NodeID][2];

else if (outChan.QType == Ten)

return getNodeTen(outChan.NodeID).norm();

else if (outChan.QType == Ten) {

if ((outChan.NodeID == 0) || (outChan.NodeID == N))

	return getNodeForce(outChan.NodeID).norm();

return (0.5 * (T[outChan.NodeID] + T[outChan.NodeID - 1])).norm();

I think here for internal nodes we should return the wall tension using
Line::getNodeTen(outChan.NodeID).norm(). This would keep output channels
consistent with what is done in MDF, where the subroutine GetLineTen is
returned for the "Ten" output channel:
https://github.com/OpenFAST/openfast/blob/6a7a543790f3cad4a65b87242a619ac5b34b4c0f/modules/moordyn/src/MoorDyn_IO.f90#L1885
—
Reply to this email directly, view it on GitHub
https://github.com/FloatingArrayDesign/MoorDyn/pull/210#pullrequestreview-2048250048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMXKKGD2K2DE6BUCLJ7WXDZBOKDVAVCNFSM6AAAAABHOEXIGGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBYGI2TAMBUHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@sanguinariojoe Thanks for making those fixes, all looks good compared to MDF now so I will merge.

Figure from the same test case mentioned in #202


"Boot entry already exists, not adding another" despite not having the secure boot entry in efibootmgr

After turning off secure boot and doing a fresh grub reinstallation, I tried to run your updated script and ran into this issue:

I encountered this error too. It appears that the secureboot entry is deleted when it's not recreated. The previous version of the code actually duplicated the entries, so I don't really know why this is happening.
In the meantime, I'll revert that new feature addition. I guess it's better to have duplicate entries than a missing entry?


how to remove % character after install oh-my-zsh

I'm an Hyper user, after install zsh / oh-my.zsh i see a strange character in hyper, could you please help me to remove it?

This is a Hyper bug, see https://github.com/zeit/hyper/issues/3586.


steam: use 64-bit libva

Motivation for this change
backport of #78310
closes #73512
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

20.03 is around the corner, closing


Allow usage of the module not only through python -m, but also directly

I'd like to replicate how pre-commit works in this sense - not sure how it's done, but they managed to have it so once you install the program, you can run it directly through the pre-commit command - no need to do python -m pre-commit.

ah yep, found it - https://youtu.be/GaWs-LenLYE?t=386


update installation

Update installation:

Pin to pandas<1.1.0 (See #152)
Add aiohttp

Looks good to me.


Make sure parent classes are sorted in a stable way.

I know I'm the last person you'd expect to request more verbosity in commit messages, but it would be good to know what problem is being solved here.  I mean the solution is obvious but what problem were you seeing that required this fix?

I know I'm the last person you'd expect to request more verbosity in commit messages, but it would be good to know what problem is being solved here. I mean the solution is obvious but what problem were you seeing that required this fix?

I'll update


Update UG

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #175   +/-   ##
=========================================
  Coverage     63.70%   63.70%
  Complexity      616      616
=========================================
  Files           110      110
  Lines          2229     2229
  Branches        261      261
=========================================
  Hits           1420     1420
  Misses          707      707
  Partials        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df0348...13d3119. Read the comment docs.


Menu icons are barely visible in light mode (macOS)

vs

Thanks for reporting this, I'll look into updating the icon set to work with both modes.


[bug] Token validation error

Describe the bug
I have the following workflow:
jobs:
  demo:
    runs-on: ubuntu-latest
    steps:
    - name: Print something
      run: echo "hello"
  slsa-setup:
    permissions:
      id-token: write # For token creation.
    outputs:
      slsa-token: ${{ steps.generate.outputs.slsa-token }}
    runs-on: ubuntu-latest
    steps:
      - name: Generate the token
        id: generate
        uses: slsa-framework/slsa-github-generator/actions/delegator/setup-token@main
        with:
          slsa-workflow-recipient: "delegator_generic_slsa3.yml"
          slsa-rekor-log-public: ${{ inputs.rekor-log-public }}
          slsa-runner-label: "ubuntu-latest"
          slsa-build-action-path: "./builder"
          slsa-workflow-inputs: ${{ toJson(inputs) }}
      - name: run echo after slsa-setup
        run: echo "echo after slsa-setup"
  slsa-run:
    needs: [slsa-setup]
    permissions:
      id-token: write # For signing.
      contents: write # For asset uploads.
      actions: read   # For the entrypoint.
      packages: write
    uses: slsa-framework/slsa-github-generator/.github/workflows/delegator_generic_slsa3.yml@main
    with:
      slsa-token: ${{ needs.slsa-setup.outputs.slsa-token }}

When I run it, I get the following error in the verify-token step of the generaic delegator:
mismatch github.job: got 'slsa-setup', expected 'verify-token'.
Which looks like it fails here: https://github.com/slsa-framework/slsa-github-generator/blob/4ed6a517a4eda072ff1fc2395f806a82741400a6/.github/actions/verify-token/src/validate.ts#L35
cc @ianlewis since you recently refactored the verify-token validation.

Yes, the environment vars for the github job would differ here between the setup where it was created and the job that verifies it - I'll put out a fix, I thikn this check shouldn't be there

Thank you, @asraa. I can confirm that verify-token now passes with the above workflow.


Reading env settings from file using environ leads to crash to some applications like sphinx, django extensions

What happened?
First of all, I am not sure whether this ticket should be a bug report or an enhancement. Either case, whenever you want to generate docs using sphinx, sphinx should be able run the application. Therefore, for any django project the docs/conf.py should contains the following additional code:
# If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the
# documentation root, use os.path.abspath to make it absolute, like shown here.
sys.path.insert(0, os.path.abspath('../'))
import django
os.environ.setdefault("DJANGO_SETTINGS_MODULE", path_to_settings)
django.setup()

Using Cookiecutter template, the variable path_to_settings should be "config.settings.local". However, by running make html this will generate error because function env() won't be able to work and will raise the following error:
django.core.exceptions.ImproperlyConfigured: Set the DATABASE_URL environment variable
To fix, you can replace every instance of env(..) to the correct value for example:
CELERY_BROKER_URL = env('CELERY_BROKER_URL') should be replaced with CELERY_BROKER_URL = "redis://redis:6379/0"
Therefore, I have created a new settings script just for documentation and it only contains the minimal settings to make django application run. I called the settings settings_docs.py and within \docs\conf.py, the
django settings module will be os.environ.setdefault("DJANGO_SETTINGS_MODULE", config.settings.settings_docs)
Steps to reproduce

generate .rst files from your apps.
within \doc\ directory run make html

This problem also happens when you try to run some django extensions commands such as graph-models
It will generate the following problem:
django.core.exceptions.ImproperlyConfigured: Set the DATABASE_URL environment variable. It seems these applications can't use environ to read from settings from file.

If using Docker, try docker-compose run command rather than docker-compose exec.

Ya I am running it in docker.. Thanks your solution was quite helpful and it solved the problem of not reading settings from text.

@webyneter can you expand a bit on why the environment variables are exported properly when using run instead of exec? I would like to use exec and have DATABASE_URL set properly

@uzi0espil I have the same problem. Would you mind explaining how you solved it? I also use cookiecutter and docker.

@Micromegass Simply just execute the following:
docker-compose -f local.yml run django python manage.py YOU_RCOMMAND.
Or to build documentation.
docker-compose -f local.yml run django make -C ./docs html
So to preserve the environment values, just use docker-compose's run command.

thanks for the quick reply. Trying this I get /entrypoint: exec: line 43: make: not found From which directory are you executing this? And is your documentation folder outside the django project or, like I have it, inside of it?

@Micromegass I am running the command from the project's root folder. The docs folder sets in project's root. For example:
- Project
-- Project => where django code and its applications reside.
--- media
--- ....
-- docs
--- make => this what you need to set a parameter for -C
--- Makefile
--- ....
-- configs
-- ...
-- productions.yml
-- local.yml

thanks again. I have the exact same setup. No matter how I write this command it always says it can't find make. Are you sure the make html command is splitted before and after the -C flag?

One thing I have different from the cookiecutter framework is that I am using python:3.6.6-stretch and not the alpine image for django. what I would suggest is to ssh inside the docker and from the root directory try to run make. check also this problem in alpine

Ok I will try that. thanks very much for your help!

Mate, I it worked. ssh'd into docker and turns out make wasn't installed. I added apk add make to my dockerfile, ran the command again and it worked. Thanks a bunch!!

@Micromegass Glad I was able to help! Cheers.


implemented insert plan proposal

made handling of indexWriterProjection more generic and moved it to insertFromSubQueryConsumer,
so inner consumers don’t have to handle it.

ack


Add ADLS Gen2 data source type

Adding new data source type "adlsgen2" for API versions 2020-06-30 and 2020-06-30-Preview
API with the new data source type is expected to be deployed by Feb 2021 and swagger can be published as soon as the API gets updated.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Based on the offline communcation with Mark Heffernan, this change is approved by the API review board.


Training example does not run

The README.md says to run python main.py --dataset celebA --is_train True --is_crop True. But when I do this it crashes with the error:
Traceback (most recent call last):
  File "main.py", line 58, in <module>
    tf.app.run()
  File "/usr/local/anaconda2/envs/subpixel/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 30, in run
    sys.exit(main(sys.argv[:1] + flags_passthrough))
  File "main.py", line 39, in main
    dataset_name=FLAGS.dataset, is_crop=FLAGS.is_crop, checkpoint_dir=FLAGS.checkpoint_dir)
  File "/develop/nets/subpixel/model.py", line 58, in __init__
    self.build_model()
  File "/develop/nets/subpixel/model.py", line 64, in build_model
    self.up_inputs = tf.image.resize_images(self.inputs, self.image_shape[0], self.image_shape[1], tf.image.ResizeMethod.NEAREST_NEIGHBOR)
  File "/usr/local/anaconda2/envs/subpixel/lib/python2.7/site-packages/tensorflow/python/ops/image_ops.py", line 787, in resize_images
    raise ValueError('\'size\' must be a 1-D Tensor of 2 elements: '
ValueError: 'size' must be a 1-D Tensor of 2 elements: new_height, new_width

Running the same example from the carpedm20/DCGAN-tensorflow repo works fine for me.

Hi Tom! it runs for me... which version of tensorflow are you using? perhaps I should say that I used 0.10.0rc0 installed from source. my bad...
Could you please check the api of tf.image.resize_iamges in your version?

here check out the change
https://gist.github.com/EderSantana/9b0d5fb309d775b995d5236c32238349

Awesoem, thanks @EderSantana - that one line fix in build_model fixed it. I committed this in pull request #7 if you want to pull this into the master branch.

Also - I'd like to try to reproduce your example. Can you also tell me how this example input/output pair was processed?


PAC with claim

updated and renamed TOTPUtils parser to PACUtils #108
implemented #111
detailEndpoint /api/auth/token/app/operation/detail
claimEndpoint /api/auth/token/app/operation/detail/claim

2 things:

we should add the PACUtils to the documentation (to the section https://github.com/wultra/mtoken-sdk-android/blob/develop/docs/Using-Operations-Service.md#totp-proximitycheck)
create a new pull request to releases/1.7.x branch with just PACUtils changes so we can support it with the old 1.4.0 server.


⚠ Avatar API Endpoint has degraded performance

In 5b01130, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 4718 ms

Resolved: Avatar API Endpoint performance has improved in 0ba9366 after 23 minutes.


SMIRNOFF: handling of small periodic systems

Is there a specification for long range interactions for if the system size is smaller than the cutoffs? Is only the minimum image calculated or are all periodic copies included?   I'm not entirely sure there needs to be a convention, but it probably should be specified if there is or not.

For periodic systems where we want to specify a periodic sum should be used, we should presumably be specifying that we should use "the Ewald sum" for Coulomb interactions (and/or Lennard-Jones interactions), rather than PME. The choice of PME cutoff, lattice parameters, alpha, etc. would all be left up to the implementation to optimize performance as long as the level of error introduced is acceptable---which is something we should explicitly define. This would enable true Ewald to be used on arbitrary space groups in the simulation engine in a manner that is compliant with the force field specification (e.g. for simulating small molecule crystals).
Only when non-periodic or pure cutoff methods are used (rather than periodic sums) would we need to specify the exact form of the cutoff/switch/shift to be used, since there is no "ideal" periodic lattice sum result to compare to.

I assume

if the system size is smaller than the cutoffs

refers loosely to the size of the molecules, not the periodic boxes. For small (i.e. single-molecule or dimer) systems, the infrastructure and fitting pipelines have been using NoCutoff for years. No periodicity, no periodic sums, no lattices, and not even any cutoffs for vdW terms (https://github.com/openforcefield/standards/issues/51). Other engines don't implement this identically to or as simply as OpenMM, leading to difficulties in porting the behavior.

Is there a specification for long range interactions for if the system size is smaller than the cutoffs?

If system size is defined by box vectors, I think this is simply undefined and either our infrastructure or the downstream engine should error out. (I suspect this is what happens now, I have not checked.)
If system size is defined by some characteristic length or volume of molecules and this would end up < 9 Angstrom, the convention is to just not set the box vectors, which the toolkit and interchange will interpret to mean the system is not periodic. After #53 this means (with mainline OpenFF force fields) the options will be nonperiodic_method="no-cutoff"
for vdW:

"no-cutoff": The vdW interaction is not truncated.

and nonperiodic_potential="Coulomb" for Electrostatics:

denotes that the standard Coulomb potential should be used with no cutoff or reaction-field attenuation

Is only the minimum image calculated or are all periodic copies included?

This comes down to what each engine supports - as I understand it, the intent it that no periodic images are used (for either energy) once you define the system as non-periodic. OpenMM handles this well, GROMACS does not handle it well, Amber does (I think), LAMMPS surely can, other engines I'm not totally sure.
This issue is fairly old. While some details are not completely resolved (particularly existing pain points like PME options) I think the spec now does a sufficient job of guiding users through non-periodic systems so I'm inclined to say the original question is resolved.


jensaarai:eval-multi-line keymap error "range.serialize is not a function"

"cmd-enter": "jensaarai:eval-multi-line" keymap from throws the above error.
From : .atom/packages/jensaarai/lib/text-recording.js:117

OK, I think I tracked this down. I'm not sure why line and block are different, seems like they're both passing back an Atom Range object. Although it seems like Atom v1.51 has a getCurrentParagraphBufferRange() function that returns a proper Range that can be serialized; whereas I was previously doing this manually. I'll push the change into 0.2.7.


Refactoring of code & ability to revoke token :star2:

Coverage remained the same at 100.0% when pulling caa1088b1a0a884529bb6f31979e391ba2066657 on add_revoke_token_endpoint into 4b0b01781ed0037de3967c499f7cc9d032a3367e on master.


Disable automatic loading of remote content in Mail

Added a command that disables automatic loading of remote content by Mail.app when an e-mail is opened by the user. This improves security by not automatically loading possibly malicious content delivered through emails to an individual.

Awesome! Thank you.


image/jpeg: Regression from 1.4.2: invalid JPEG format: bad RST marker

Decoding the attached image will return "bad RST marker" using go version devel +bd45bce Wed Jul 8 01:20:02 2015 +0000 darwin/amd64
Decoding with 1.4.2 works just fine. And I haven't seen any other jpeg decoder fall over on this one.

Nigel?

Yes, I am working on a fix.


Duplicate hash

We are hashing ID's of objects and save them in the database. Now we got 2 same hashes encoded by Hashids::encode(1290) and Hashids::encode(1302) now those same numbers encode in the following hash: 3GWpmbk4xdzJn4z
Now the package delivers a decode function: Hashids::decode('3GWpmbk4xdzJn4')  and it gives back an array with 1 item that has 1302. This matches the 2nd number encoded but not the first? It should either decode in both numbers, or the hash should be different for the numbers.
Any clue how this is possible or is this the behavier is need to have? We are using version v1.1.0 since the project is still running in laravel 5.1 and needs to be upgraded soon.
Edit* For version 3.3.0 the problem has been solved.

We've cleaned up and fixed a couple of bugs in Hashids version 2.0.


Consider releasing Mezzano into the public domain using the Unlicense?

MIT license is one of the best licenses, but have you considered just releasing Mezzano into the public domain using the Unlicense?
I've been releasing all my projects under the Unlicense for years to ensure maximum usefulness of my contributions, and encourage everyone to do the same. There is no point in corrupting open source codebases with copyright, the biggest scam in history!

I'll stick with MIT. I want to avoid dealing with software licenses as much as possible, including switching them around.


Benchmark performance of manually windowed ReadGroup (with agg) against ReadFilter

We should create a benchmark to understand if we can get any performance gain from issuing several calls to ReadGroup (with an aggregate) to create grouped and windowed aggregates.
Specifically, we want to know if doing several time-based seeks would be pathologically slow.
Consider the following query:
period = 1h
from(bucket: "telegraf")
  |> range(start: -12h)
  |> filter(fn: (r) => r._measurement == "diskio" and r._field == "read_bytes")
  |> group(columns: ["name"]) // device name
  |> aggregateWindow(fn: count, every: period)

To simulate storage effects you can benchmark

Calling into storage with ReadGroup using count as the aggregate 12 times, once for each hour in the range
Calling ReadFilter across the entire 12h time range
If ReadFilter is faster, then there is no benefit to issuing multiple calls to ReadGroup as a way of implementing window semantics.

Vary the benchmark across different time ranges, and different periods.  Vary also the number of series being grouped and the number of groups in the result.  Basically, do whatever you can to make the ReadGroup approach "win" against ReadFilter.
DOD:

A unit test that does the benchmark
Use the results to determine if this optimization would be a good idea

Here's the output of a benchmark.
I noticed when writing the benchmark that ReadGroup a was pretty slow and it was spending a lot of time evaluating seriesHasPoints when sorting series keys. I describe this in this comment: https://github.com/influxdata/influxdb/issues/18039#issuecomment-628873643
I included performance with a tweak of making seriesHasPoints hardcoded to return true, to see if fixing #18039 would have any effect on whether this optimization is worthwhile.
With calls to ReadGroup issued concurrently:

BenchmarkReadFilterVsReadGroup/group_by_t0_filter-8                 	      10	 101637476 ns/op	12058580 B/op	  235222 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_4_windows-8         	      10	 100128614 ns/op	24435672 B/op	  307904 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_12_windows-8        	       4	 272839689 ns/op	73308070 B/op	  923712 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_24_windows-8        	       2	 500042760 ns/op	146132084 B/op	 1832398 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_60_windows-8        	       1<PHONE_NUMBER> ns/op	365105928 B/op	 4573553 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_120_windows-8       	       1<PHONE_NUMBER> ns/op	730223704 B/op	 9147189 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_240_windows-8       	       1<PHONE_NUMBER> ns/op<PHONE_NUMBER> B/op	18279337 allocs/op

With calls to ReadGroup issued concurrently:
(seriesHasPoints hardcoded to return true)

BenchmarkReadFilterVsReadGroup/group_by_t0_filter-8                 	      10	 105251775 ns/op	12058560 B/op	  235222 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_4_windows-8         	     100	  10250693 ns/op	15315001 B/op	  102900 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_12_windows-8        	      37	  33069201 ns/op	45945315 B/op	  308699 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_24_windows-8        	      18	  62648799 ns/op	91888501 B/op	  617380 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_60_windows-8        	       7	 151473745 ns/op	229722979 B/op	 1543449 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_120_windows-8       	       4	 298454434 ns/op	459443052 B/op	 3086904 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_240_windows-8       	       2	 579911443 ns/op	918888172 B/op	 6173820 allocs/op

With calls to ReadGroup issue serially:
(seriesHasPoints hardcoded to return true)

BenchmarkReadFilterVsReadGroup/group_by_t0_filter-8                  	      10	 102283384 ns/op	12058719 B/op	  235224 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_4_windows-8         	       4	 323934844 ns/op	24435706 B/op	  307906 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_12_windows-8        	       2	 939805816 ns/op	73308168 B/op	  923726 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_24_windows-8        	       1<PHONE_NUMBER> ns/op	146135472 B/op	 1832435 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_60_windows-8        	       1<PHONE_NUMBER> ns/op	365099256 B/op	 4573590 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_120_windows-8       	       1<PHONE_NUMBER> ns/op	730193144 B/op	 9147127 allocs/op
BenchmarkReadFilterVsReadGroup/group_by_t0_group_240_windows-8       	       1<PHONE_NUMBER>6 ns/op<PHONE_NUMBER> B/op	18279248 allocs/op

The PR for the benchmark is here. Not sure if this should get merged:
https://github.com/influxdata/influxdb/pull/18100


Document docker integration test requirement

A few of the integration tests manually start docker containers and fail if docker is not running. CONTRIBUTING should reflect that requirement. Also, running command line commands directly from java code doesn't seem like the idiomatic way to run docker containers in a gradle test environment. Explore if there is a better way.

I talked to Daniela - we're going to remove the otel dep and related tests for now.


External script work with hydration

The external scripts only load once in the first page, the rest pages require to reload the external script because hydration.

This isn't a reproduction.

It also sounds like it's working as expected. Of course your external scripts don't reload when you navigate client-side. Why would you want them to?

First i would like to thank for the response from the two most High Contributors!
The reason which i report that is because some ui libraries need to load external js, Flowbite ui is one of them, this project has two option to integrate to Sveltekit:

From dedicated component(in progress)
Second from external js script imported to body
I prefer the second option for more customizability, in this case they suggest:

_"If you are using Flowbite.js, you need to add rel="external" to the link tag for pages using Flowbite interactivities.
Path
By default, the SvelteKit runtime intercepts clicks on  elements and bypasses the normal browser navigation for relative (same-origin) URLs that match one of your page routes. — SvelteKit doc Adding a rel=external attribute to a link will trigger a browser navigation when the link is clicked."_

So you would like to run the script that is run once again after navigation because..? Flowbite does not notice that new elements are added and doesn't run again? How would it work for flowbite components who only render after some if-condition becomes true? Wouldn't they suffer from the same problem? If sounds like flowbite should notice that it should rerun whatever logic it has again

Adding a rel=external attribute to a link will trigger a browser navigation when the link is clicked

Oof, that is horrible advice. Please don't do that! Flowbite really needs to offer an API for doing whatever initialization work currently requires the script to be re-executed (not just for SvelteKit, but for any integration that isn't already covered by a dedicated component library), though it sounds like flowbite-svelte is a better option.
I'm going to close this as it's very much a Flowbite issue rather than a SvelteKit issue — the framework is working as intended.


Support push rules for projects

I'm not sure if features of the enterprise edition are in scope of this project, but it would be nice if push rules (get, add, edit, delete)  would be supported (like web hooks / project hooks)

Hi @BernhardBerbuir! The go-gitlab package definitely supports ee features as well.
I don't have much (if any) time to work this one myself, but if anyone is up to add support for the push rule APIs I have no problem with merging that PR 👍


Packages for Linux distros

@AlexanderP,
Hi, can you please upload Leptonica 1.83 and Tesseract 5.3.0 to https://mentors.debian.net ?
I hope @bgermann can help as a Debian sponsor.
See: https://github.com/DanBloomberg/leptonica/issues/656#issuecomment-1361851778

I have updated the package and have changed debian/watch along the way.
For the future, please make sure to that uscan works and can actually download the tarballs (tesseract and test).
Also, please do not include .git in your uploads.

So Tessract 5.3.0 is on it way to sid and hopeufully later it will move to bookworm. @AlexanderP and @#bgermann, thank you!
@AlexanderP,
What about Leptonica 1.83? Can you also upload it to Debian?

That is @jbreiden's responsibility.

https://tracker.debian.org/pkg/tesseract

news
[2023-01-09] Accepted tesseract 5.3.0-1 (source) into unstable (Alexander Pozdnyakov) (signed by<EMAIL_ADDRESS>

https://tracker.debian.org/pkg/tesseract

Migration status for tesseract (5.1.0-2 to 5.3.0-1): BLOCKED: Rejected/violates migration policy/introduces a regression
Issues preventing migration:
∙ ∙ autopkgtest for cataclysm-dda/0.F-3-9: amd64: Pass, arm64: Regression ♻ (reference ♻), armel: Pass, armhf: Pass, i386: Pass, ppc64el: Test in progress, s390x: Test in progress

CC: @reinerh

@amitdo Sorry, the cataclysm-dda autopkgtest is a bit flaky. I've just requested a retry.
(And I'll improve the test in the next upload)

@reinerh,
The migration of Tesseract 5.3.0 to Debian testing is blocked due to regression in tests (s390x) of your package.

Hm, the s390x regression seems to be independent of my package (and only happens on s390x).
I retriggered the test, but it looks like it's more an infrastructure problem. I'll check with the debci developers.
But your package should migrate now.

Some Debian warnings can be fixed by running make with more output (make V=1 ).

news
[2023-01-19][ tesseract 5.3.0-2 MIGRATED to testing


Link in Readme to markdown

I get a 404 clicking the link to the markdown files in the readme. It doesn't look like it is pointing to this url https://github.com/AzureTechCommunity/talks/blob/main/talks/app_service_web.md

Thanks for the bug report. I just resolved this in 6b9e347


guide: params, metrics and plots metafiles

We briefly cover those 3 types of files on the Project Structure -> Pipeline Files -> Stages section.
I understand that they can be considered stage-related and thus belong on that page.
However, it feels like the current info in each command reference (dvc params, dvc metrics, dvc plots) could be moved to the user guide, potentially extending it.

Related to (or part of) https://github.com/iterative/dvc.org/issues/144#issuecomment-841960760

Should these be tasks in https://github.com/iterative/dvc.org/issues/2911 since params, metrics and plots are mainly experiment tracking mechanisms?

Hmmm, in fact this looks like a dupe of https://github.com/iterative/dvc.org/issues/2572 !


https://github.com/microsoft/DeepSpeed/pull/3457

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

flows summarize

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


[$250] BUG - Create room - Workspace is not selected by default if one workspace only available in the account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app and login
Click global fab button and select "New Room"
Observe the workspace field

Expected Result:
When creating a new room, if you have only one workspace, it should be selected by default
Actual Result:
Select a workspace is shown as default and Showing an error telling the user to select a value from the list when there's only one value
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.2.12-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/194421943-580fa9c0-9d20-48b0-a939-472a92ddf488.mp4
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665065274983609
View all open jobs on GitHub

LGTM 👍 🟢

@rushatgabhane Your proposal will change value in the dropdown or the picker but the changed value is not passed to the parent component.
@aimane-chnaif Soluion 2 from above proposal looks good to me. His proposal is to apply the change to a general component Picker. @aimane-chnaif Please do test all the components using Picker to make sure it doesn't cause any regression and output is as expected while creating PR.
cc: @tgolen
🎀👀🎀 C+ reviewed

Yeah, I like the proposal for applying it to all pickers 👍 🟢

I think @isabelastisser needs to create an upwork job and assign it to you next. But, I think you're OK to start on a PR and we'll get they payments and job figured out in the meantime.

Cool, I'll do the GH assignment for you.

Hey @tgolen , I'm still getting familiar with this process, so do I still need to create an Upwork job and assign it to @aimane-chnaif ? It looks like this has been done here, but I wanted to confirm. Thanks!

I honestly don't really know. Can you check SO to see what the current process is supposed to be? It's constantly evolving.

@isabelastisser - I was confused too. On Friday, I asked here and confirmed that I did need to create a job for the GH that I was tagged as external. I think that's the next step here.

Hi @aimane-chnaif, can you please let me know if you were already assigned this job in Upwork? If not, I will create one today. Thanks!

Internal job posting: https://www.upwork.com/ab/applicants/1585237928058978304/job-details
External job posting: https://www.upwork.com/jobs/~01a510b944f147220c

don't you guys have something to close these issues? its already solved, why is this still open?

Ack, very sorry about that! I have merged it now. So sorry!
On Tue, Nov 1, 2022 at 12:49 PM aimane-chnaif @.***>
wrote:

@tgolen https://github.com/tgolen PR has not been merged yet. I think
you just forgot to click Merge button after Approve
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/11650#issuecomment-1298962588,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJMABYHSRMMM3MQW4Y7Y2TWGFQ4XANCNFSM6AAAAAAQ7AXJ2I
.
You are receiving this because you were mentioned.Message ID:
@.***>

Waiting payment. PR was deployed to production 9 days ago.

cc: @isabelastisser

The Contributor and Contributor+ have been paid, the contract has been completed, and the Upwork post has been closed.


shared: add CMake based build rules for ICU

This adds a CMake based build for ICU.  This is motivated by Windows
where we can avoid having to install a large number of tools in order to
build ICU by rewriting the build system in CMake.
This is a stopgap solution to the fact that ICU does not a CMake based
build.  The project has been trying to switch to a CMake based for
nearly 4 years now [1].
This allows building ICU on Windows without having to setup and
configure cygwin to get access to autotools and without having to do
stage and coordinate the data build and the MSVC build.  This also
allows the use of ninja to build which speeds up the build of ICU, as
well as enables easy cross-compilation.  Additionally, this allows for a
more homogeneous build of Swift as nearly every other project builds
with CMake.  There are a number of other parallel attempts to add an
out-of-tree CMake based system (e.g. [2]).  This is a fairly common
problem but this solution is far more simple as it only provides enough
support to deal with the immediate needs of the Swift project.  It only
supports building the bits of ICU that are needed for the Swift project
and tries to hardcode as much of the configuration as possible to reduce
the size of the ICU build while retaining all functionality required for
the Swift use cases.
[1] https://unicode-org.atlassian.net/browse/ICU-7747
[2] https://github.com/LibCMaker/ICU_CMake_Files

CC: @shahmishal

Is there a reason we don't want to add this part of swift repository?

The swift repository is already overly complicated and a collection of disjoint things.  We shouldn't encourage that.  This is part of the build infrastructure, and I think that it makes sense to have it be part of the packaging/build scripts.

cc: @gottesmm

@shahmishal I talked with compnerd about this. Part of the issue here is that currently ICU has been trying for ~4 years to get a CMake build. Given that we are technically taking on more maintenance when we update ICU if we take this, I think that is important that we make the pragmatic considerations here obvious to future maintainers. With that in mind:

I think it is important to directly link to the ICU project ticket in the commit message where this work is being tracked. https://unicode-org.atlassian.net/browse/ICU-7747. As one can see, the ticket still has multiple things to work on there.
I think it is important to bring up the specific benefits that this provides in the commit message. Something along the lines of will improve our build by making cross compilation easier and will allow us to use ninja to build ICU improving incremental build times.
From what compnerd has told me, other projects are already doing something like this. I would like to see some links to that in the commit message as well that shows we are doing something that is standard.

So big picture, I think this is a reasonable trade-off on balance but we need to add a bunch of documentation into the commit message and probably the file as well that says /why/ we are doing this so that it is clear in the future why we did this (in case the pragmatics change [e.x.: ICU gets a real cmake build]).

@gottesmm updated the commit message with additional context

@gottesmm, @shahmishal I have now this and https://github.com/apple/swift/pull/58546 ... can we please get this resolved and merged?


Sound connected to images/categories/text

We often get the question to add sound to images or other parts of Xerte on mousover or click.
For example in Categories:

Add audio to the image/text that plays as soon as you drag it.
Add adio to the categorie that plays as soon as an item is dropped.

Other example Memory game:

Play sound when the card is turned.

But there are a lot of other places when this is realy useful for the dyslectic for example.

I think things like this would be really nice but they can involve lots of optional properties to cover everything that people might want to do. for example...

sound on mouse over
sound on click
sound on drag
sound on drop

And then do they want sounds to be the same on all labels (at page level) or different for every label (at nested page level)
There are lots of optional properties starting to be added for things similar to this (I've added quite a few feedback ones) and I kind of feel like there should be a better way of doing it... but I'm not sure what. maybe lots of optional properties is the only way


Mismatch between hex and decimal values in the comments section of generated .S file

In the attached clmul-01.S file,
inst_1:
// rs1 == rs2 == rd, rs1==x29, rs2==x29, rd==x29, rs2_val ==<PHONE_NUMBER>854775807, rs1_val ==<PHONE_NUMBER>3709550591
// opcode: clmul ; op1:x29; op2:x29; dest:x29; op1val:0xfffffffffffffbff;  op2val:0xfffffffffffffbff
TEST_PKRR_OP(clmul, x29, x29, x29, 0x0000000000000000, 0xfffffffffffffbff, 0xfffffffffffffbff, x29, x1, 8, x2)
rs2_val and its hex equivalent in op2val are not same
Similarly in
inst_3:
// rs1 == rs2 != rd, rs1==x27, rs2==x27, rd==x30, rs2_val ==<PHONE_NUMBER>4495857663,
// opcode: clmul ; op1:x27; op2:x27; dest:x30; op1val:0xfffffffffffffbff;  op2val:0xfffffffffffffbff
TEST_PKRR_OP(clmul, x30, x27, x27, 0x0000000000000000, 0xfffffffffffffbff, 0xfffffffffffffbff, x27, x1, 24, x2)
rs2_val and its hex equivalent in op2val are not same
###########
riscv_ctg --version
RISC-V Compliance Test Generator, version 0.6.3
python3 --version
Python 3.6.9
clmul.cgf.txt
clmul-01.S.txt

To be clear: there are 2 comments, and it's the first comment that is clearly wrong, since rs1==rs2, yet rs1val!=rs2val
This doesn't affect tests.  I don't know the source of first comment (e.g. is it coming from the coverpoint file?) so hard to know if has any practical affect.
As a nit (actually, 2 nits: ):

I would prefer that  all operands be listed in hex, because it is impossible to determine by eye whether a large decimal number  is equivalent to anything, while it's usually quite easy to resolve hex numbers.
It would be nice if the comments were consistent about ordering (rs1 usually comes before rs2, but is reversed in that first comment).

Would be nice if the sign is also represented in hex rather explicit sign as below for the hex values.
inst_5:// rs1==x24, rd==f11, rs1_val == -1227077728 and rm_val == 0
// opcode: fcvt.s.l ; op1:x24; dest:f11; op1val:-0x4923b860; valaddr_reg:x16; val_offset:40; rmval:0x0; correctval:0; testreg:x18
TEST_FPIO_OP(fcvt.s.l, f11, x24, 0x0, 0, x16, 40, x17, x15, 0, x18)
inst_6:// rs1==x7, rd==f7, rs1_val ==<PHONE_NUMBER> and rm_val == 4
// opcode: fcvt.s.l ; op1:x7; dest:f7; op1val:0x4923b860; valaddr_reg:x16; val_offset:48; rmval:0x4; correctval:0; testreg:x18
TEST_FPIO_OP(fcvt.s.l, f7, x7, 0x4, 0, x16, 48, x17, x15, 16, x18)

My preference is that hex values be raw hex with the exception of branch/jump and load/store offset values.
Anything that's absolute should be raw hex without a minus sign if the SMB is a 1.

The first line in the comments is the set of coverpoints which caused a particular test case to be generated. These are lines directly from the cgf. The second line is the key to identifying the values in the macro arguments, sort of a hint to understand which is which. Now the values don't match because of the rs1==rs2 in both of these cases. This is because the operands and the values are generated independent of each other and then combined together to write out the test cases. But when 2 or more registers are the same, there is a possibility that a value combination coverpoint might not be satisfied(due to value overwrites in case of using the same regsiter). In such a scenario, the value of the operands is equated out. This is the reason you see the mismatch in the values in both the comments. But this does not mean that the coverpoint for rs2_val is not hit. CTG replicate the value combination once again towards the end of the test. The comment is right with respect to the values provided to the macro instance and accurate. The first comment should always be taken with a grain of salt. I'm not sure whether sanitising the first comment is a low hanging fruit which can be easily implemented.

In riscv_ctg/generator.py
###########
def instr(self, op=None, val=None):
cond_str = ''
if op:
cond_str += op[-1]+', '
if val:
cond_str += val[-1]
########
if val:
cond_str += val[-1]
above two lines adds the decimal values of rs2_val in the comments. This is redundant information.
Hex values of the same are already added to the comments in .S file.
Commenting out the above two lines will avoid redundant information and also this issue.

That will remove the values for cases where rs1_val and rs2_val are indeed different.  Fixing this infact depends on multiple conditions such as whether rs1 is loaded first or rs2 is inside the macro and whether both the vals are equal. IMO its fine the way it is, since it indicates correctly the values passed to the macro. The observed values are different due to the program flow and that is how it should be. Very few instances of the macros generated will encounter this problem(i.e rs1 and rs2 are never the same register unless a coverpoint explicitly specifies it). This is more of a nice to have but needs additional information about the macros to figure out the correct value to be appended to the comments.


Training on a custom dataset

Hi Zhang,
Thanks for open sourcing this code. I am trying to run your model on my dataset, I have pre-processed the data in it's required format.
Now I am not familiar with lua and torch, so can you tell me is there anything I need to change in the config file to run it over a different dataset than dbpedia one? (I could only decipher the no of classes parameter from config file). Sorry if the question sounds elementary, I just want to make sure I am folllowing the right steps for my experiements.
Thanks in advance.

All that you should change is the number of output classes in the config file. In the below line, change the outputSize parameter to the number of output classes.
config.model[23] = {module = "nn.Linear", inputSize = 1024, outputSize = #NoOfOutputClasses}

Thanks for your reply. I tried that and it's working. Also I have one more small question.
I am getting accuracy of around 18% after 20000 epochs. Task is 8 class classification and training data has around 65k samples and testing data has 16k samples.
Can you think of something from top of your head which I might have done wrong?

Your question is too generic. It totally depends on your data. First thing that I can think of is

Check whether data is balanced
You can try some pre processing to remove unwanted info from the data

Please close the ticket if your query is resolved.

Thanks for your response. I realized that maximum length it is taking is around 2500 which will consume more memory per batch.
I trimmed it to avg. sentence length instead of max. sentence length which is ~140 so now the code is running in reasonable time.

Classes are imbalanced. Half of the classes have most of the documents, but baseline methods (logistic regression on top of wordvectors) is performing far better than this (~62%).
That was the reason I was worried about.

If your dataset is imbalanced as you said, assigning all samples to the largest class can give you around 50% accuracy. 62% is not surprising at all.
However, the Crepe code enforces balanced sampling from classes at training, because of line 65 in data.lua. It does not enforce such balanced sampling during testing. The mismatch between training and testing distributions will result in funny results.

It's a multi-class (8 class) classification problem, so how will assigning all samples to largest class will give 50% acc.?

Maybe I was wrong in my statement. I overestimated the class imbalance. Here is the distribution of classes :
7: 23849, 0: 15159, 1: 6445, 4: 5759, 5: 3969, 3: 3659, 2: 2845, 6: 492
I am sure 62% is not by significant considering this distribution.

You statistics also show a very small data size (in terms of number of samples). It would be very hard for convolutional networks to learn good representation in that case.
I will close the issue now because the topic start to deviate away from your original question. Feel free to open a new issue for different questions.

Sure, thanks for your reply. I was just curious since other models (simpler models) were performing better than this one.

Bad performance is expected if your dataset is less than several hundred thousand samples. If you are interested, refer to our article for a set of complete benchmarks.

Sure, thanks for your quick response. Will refer to your article. Thanks again.


Create UI for editing scheduled messages

In the initial scheduled messages implementation, the UI does not make it clear how to save changes you have made to a scheduled message (which must be done by pressing the "Schedule" button). To make it clear what's going on, when a user opens a previously scheduled message, we should have the following UI:
Compose buttons

The main action button should be labeled as "Save changes"

If you edit the message and close the compose box without clicking "Save changes", the edited version of the message should be saved in Drafts, but the scheduled message will not be affected.
^ menu
This menu should have 3 options:

Reschedule message, which opens the scheduling modal (see #25261) to let the user pick a different time.
Unschedule message, which removes the scheduled message and puts the compose box in to a regular sending state.
View scheduled messages

Compose banner
There should be a green compose banner explaining the situation. We can try:

This message is scheduled for <time>. Until then, you can modify it by editing the content and clicking Save changes.

CZO thread

Hm, would it look OK if we put the second sentence on a new line?

Closing in favour of #25340


Don't break when included more than once on host page

Fixes #190
I added two tests, both referencing ../src/iframeResizer.js (unlike the rest of the tests where its ../js/iframeResizer.js) because otherwise one of the (existing) tests failed.
I also had some trouble minifying - so I skipped that too.

Thanks for this, looks good. Just wondering if we should through a warning message if the script is loaded twice.

@davidjbradshaw, good idea - as long as it can be suppressed via configuration too. My use case is just that: I have no idea how many times the host script can be included on a page - and it must just work.

Released v2.8.7. Thanks.


Verify support with Cumulus 3.x

The Cumulus support has been tested against 2.5.6 - 2.5.x.
Need to verify support with  Cumulus 3.x release

@jeremyschulman this has been resolved, right?

confirmed.  thank you.


Fix webserver serving folder named like index file

If there was a directory named like an index file (e.g. "index.html"), other index files registered later (e.g. "index.htm") were ignored and the directory was served instead (or an index file in the directory). This was fixed by now checking if the index file is not a directory.

Coverage remained the same at 74.25% when pulling b283bf35b1f74ec859d60cba24e40cece1d3891d on philippwiesemann:fix-webserver-index-dirs into e37bd6d1bda88760db5697355ed22270dabfb8c4 on NanoHttpd:master.

Merged. Thank you.


WebSiteManagementClient.Certificates.List() crashes on deserialization

Hey
When trying to get the list of certificates available to a webapp, im getting the following exception:
Microsoft.Rest.SerializationException
  HResult=0x80131500
  Message=Unable to deserialize the response.
  Source=Microsoft.Azure.Management.Websites
  StackTrace:
   at Microsoft.Azure.Management.WebSites.CertificatesOperations.<ListWithHttpMessagesAsync>d__5.MoveNext()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Management.WebSites.CertificatesOperationsExtensions.<ListAsync>d__1.MoveNext()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at UpdateAllWebAppPfxs.Program.<Main>d__0.MoveNext()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at UpdateAllWebAppPfxs.Program.<Main>(String[] args)

Inner Exception 1:
JsonSerializationException: Cannot deserialize the current JSON array (e.g. [1,2,3]) into type 'Microsoft.Azure.Management.WebSites.Models.Page`1[Microsoft.Azure.Management.WebSites.Models.Certificate]' because the type requires a JSON object (e.g. {"name":"value"}) to deserialize correctly.
To fix this error either change the JSON to a JSON object (e.g. {"name":"value"}) or change the deserialized type to an array or a type that implements a collection interface (e.g. ICollection, IList) like List<T> that can be deserialized from a JSON array. JsonArrayAttribute can also be added to the type to force it to deserialize from a JSON array.
Path '', line 1, position 1.

Looking at fiddler i can see the response from https://management.azure.com/subscriptions/<subscriptionId>/providers/Microsoft.Web/certificates?api-version=2018-02-01  is of the form [{"id": ...}] and not { "value": [ .. ] } as is expected in the Page model.
I dont know if its the API or the SDK model that is in the wrong here ?

@Fraaankes please let us know if this is still an issue.


Build error on Windows, gradle failing

Since today, our build is breaking with the below error. We did not change any dependency, nevertheless after some tinkering we found moving the sqlite3_flutter_libs package back to 0.5.10 (from  0.5.11)  prevents the issue.
I hope this is the right place to report this, any assistance is appreciated.
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sqlite3_flutter_libs:extractReleaseAnnotations'.
> Error while evaluating property 'hasAndroidAnnotations' of task ':sqlite3_flutter_libs:extractReleaseAnnotations'
   > Could not resolve all artifacts for configuration ':sqlite3_flutter_libs:releaseCompileClasspath'.
      > Failed to transform sqlite3-native-library-3.39.4.jar (eu.simonbinder:sqlite3-native-library:3.39.4) to match attributes {artifactType=android-classes-jar, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-api}.
         > Could not find sqlite3-native-library-3.39.4.jar (eu.simonbinder:sqlite3-native-library:3.39.4).
           Searched in the following locations:
               https://repo.maven.apache.org/maven2/eu/simonbinder/sqlite3-native-library/3.39.4/sqlite3-native-library-3.39.4.jar

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Little update, build was fixed as described above BUT now we get runtime errors for type casting from the compiled APK. I'm uncertain if its related, getting the impression I can't trust the build server anymore ;)
type '_Smi' is not a subtyoe of 'string' in type cast

Ran into same issue:

Just checked  this site:
https://repo.maven.apache.org/maven2/eu/simonbinder/sqlite3-native-library/3.39.4/
it seems that the mentioned file in the error sqlite3-native-library-3.39.4.jar doesn't exist there.

...but thats a little bit strange, since I cannot see similar file in the other versions either... ...not that I know how this library is assembled.

@RoarGronmo we did exactly the same like you and asked us the same question 😅 I hope somebody else has an idea.. would love to get my Jenkins back to live

we found moving the sqlite3_flutter_libs package back to 0.5.10 (from 0.5.11) prevents the issue.

Yup, something went wrong publishing the new native artifact to maven central. I have retracted 0.5.11 from pub.dev in the meantime.

type '_Smi' is not a subtyoe of 'string' in type cast

I don't think this is related.

Saw that now, removed and reintroduced sqlite3_flutter_libs and it "downgraded" to 0.5.10 from 0.5.11.
Works fine now.
@Dev-Owl I think you need just to do flutter pub upgrade to fix, am I right @simolus3 ?.

Should work with sqlite3_flutter_libs version 0.5.11+1, which I've just released. If you're running into more issues, please let me know.
Apologies again for the inconvenience!

@simolus3  No worries, will check our infrastructure tomorrow morning. Thanks a lot for the quick reply and the work in general 👍

Confirmed, all is good now  👍
The other error seems to come from a change in code generation and is not related to Drift.


PBSafariActivity not in PBWebViewController Pod

Via pod install PBSafariActivity isn't included. Would be great for an update. (will drag and drop manually). Or create an additional pod for it.
Thank you, great work!

The idea here is that each individual had different needs so I didn't include the PBSafariActivity, that's just an example. It's easy to just drag and drop it like you did or create your own activity.
There are also other pods that provide this: I just found ARSafariActivity for example


Add Ethereum support to GoodDollar Wallet

@patpedrosa yes, it was continued in the next one task: https://github.com/GoodDollar/GoodDAPP/issues/4083#issuecomment-1903993660

closed based on last comment


3.x Debian/Ubuntu repos

This will add the ability to setup the correct apt repo based on the specified version. This also enables the user to use custom apt repos with all relevant parameters (location, release, repos, key).

#226


What is this package?

Looks like it's a loader for coffee-script-redux. It's some fork of CoffeeScript by the looks of it.


[Bug] Replace soci create/push with nerdctl push in our documentation

Description
nerdctl v1.6.0  adds support for creating and pushing SOCI indexes. We should replace mentions of soci create/push with nerdctl push in our documentation. Note: The nerdctl CLI just shells out to the soci CLI, so we should mention that the soci CLI still needs to be installed.
Steps to reproduce the bug
No response
Describe the results you expected
Replacing references of soci create/push with nerdctl push.
Host information

OS:
Snapshotter Version:
Containerd Version:

Any additional context or information about the bug
No response

Should we add as one option instead of replacing, as nerdctl is not a must-have to use soci. (Containerd is a must-have though).

We need some way to manage container images in containerd. Right now, our alternative is ctr. While nerdctl is technically optional, the alternative (ctr) is pretty inappropriate for production use-cases.
If we eventually have a containerd-less option (or docker containerd support is default), then we can probably have options, but I think making nerdctl + SOCI CLI the only recommendation in our docs is reasonable.


Results with randomly initialization SWAG are bad

Thanks for releasing the code.
I find that Fig. 2 (i) from the paper, shows that both pre-trained and random networks, models with SWAG could produce good results. Thus, I just try to change line 260 into resnet = models.resnet50(pretrained=True). However, it seems the result are bad.
Results with p-ResNet (arch=resnet):

Results with p-ResNet∗ (arch=resnet_swag):

Results with r-ResNet∗ (arch=resnet_swag):

Can you please clarify this? Thanks in advance if I missed something.

Hi, I think your results are consistent with figure 2. This figure is showing p-resnet* better than p-resnet. r-resnet* better than r-resnet.
For your results, it is clear the second one is better than the first in the sense that more style patterns are transferred, seeing for example, upper left regions, the nose.
And I think you could run a r-resnet without swag. I believe it would be worse than your last image.


chore(repository): cleanup obsolete projects & files

Closes #138 . See checklist there for details

2,000 deleted? Negative productivity there. SMH. :-D

whoa, didn't notice that!


Feature Request.

I am using this plugin for quite a while and I am working on a few improvements, one of which is a feature where when the user uses the  command on the compilation buffer it jumps to the file in the already opened buffer instead of jumping the compilation buffer.
In my case when I am editing a file and I run the compile command and jump to error I end up with 2 buffers with same contents which feels weird. Before using your plugin I was using compile.nvim and this plugin does a wincmd p to go out of the compilation buffer and open the error there.
I was wondering how should I go about adding this feature to compile-mode.nvim. Specifically my question is, which way would be better? to have a config that user can configure to open the error outside of compilation buffer. something like this?
require('compile-mode').setup({
    errors_in_compilation = false,
})

or to have a seperate keybind or seperate command? Waiting for your thoughts on this.
BTW I have implemented the config way of doing this.

This feels like a natural thing for people to want. I wouldn't be against having it as the default, and adding a configuration option to disable this behavior. Feel free to open a pull request, and I'll give your code a look :smile_cat:

Take a look at what I've done in #9 and see if it's what you're looking for.

Hey, this is good we can merge and close the issue


[BEAM-5456] Upgrades Google API Client libraries to 1.27.0.

New version of the client library fixes known issues such as:

Lack of http write timeout
Slow writer timeout

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

run java postcommit

Run Java PostCommit

Run Java PostCommit

@chamikaramj

LGTM. Please let me know if this is ready to be merged.

Run Java PreCommit

Run Java PreCommit

Run Java PostCommit

Run Java PostCommit


SingleSpaceAfterConstructFixer - better handling of closing parenthesis and brace

closes #5448

Coverage remained the same at 91.928% when pulling 6d12e9395e3d593b81e30d3429cc1e2e92389c49 on keradus:fix_5448 into 898719e487933984861143857dfefe93976a9c72 on FriendsOfPHP:2.17.

Coverage remained the same at 91.928% when pulling 6d12e9395e3d593b81e30d3429cc1e2e92389c49 on keradus:fix_5448 into 898719e487933984861143857dfefe93976a9c72 on FriendsOfPHP:2.17.


Added campaign-nosurge to sim normal fight campaigns.

Do you think these changes are really necessary? Campaigns like that Anniversary are not regular events and even it will happen once again, it's easy to implement by using 'campaign' + 'fight' flags together ('fight' must be after 'campaign' to override the game mode only).
Hint: stage 7 does not need to be simmed with campaign optimization mode, on the last stage we need just win! For normal (regular) campaigns use 'surge' + 'win' flags, for Anniversary: 'fight' + 'win' ('fight' is default game mode, so it can be omitted).
I. e. currently TUO has no a full list of game types for campaign (at least for last stage), but we have a lot of self-made tools for campaign simming per guild/family...

Thanks for the fast reply.
I didn't know that with campaign + fight, the game mode gets overridden.


C# Extension Performance issue

Issue Type: Bug
Extension Name: csharp
Extension Version: 1.21.13
OS Version: Windows_NT x64 6.3.9600
VSCode version: 1.42.1

new update asked to choose new Formatter, (previously it was "ms-vscode.csharp"):
"[csharp]": {
"editor.defaultFormatter": "ms-dotnettools.csharp",
},
{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 202,
		"activateCallTime": 12,
		"activateResolvedTime": 52,
		"activationReason": {
			"startup": true,
			"extensionId": {
				"value": "ms-dotnettools.csharp",
				"_lower": "ms-dotnettools.csharp"
			},
			"activationEvent": "workspaceContains:*.csproj,*.sln,*.csx,*.cake,**/*.csproj,**/*.sln,**/*.csx,**/*.cake"
		}
	},
	"runtimeErrors": []
}

ms-dotnettools.csharp-unresponsive.cpuprofile.txt

Thanks for the report. This is a result of the changed publisher name, so this is a duplicate of https://github.com/OmniSharp/omnisharp-vscode/issues/3620


Error trying to load with VLLM

I'm trying to run/load prometheus on Amazon Sagemaker Stuidio notebooks but keep running into errors.
If I load it using VLLM
model = VLLM(model="prometheus-eval/prometheus-7b-v2.0")
ValueError: The model's max seq len (32768) is larger than the maximum number of tokens that can be stored in KV cache (18672). Try increasing gpu_memory_utilizationor decreasingmax_model_len when initializing the engine.
From what I found out, the reason is due to Mistral having 32k context length which is longer than the KV cache can handle. Do you suggest which value of gpu_memory_utilization or max_model_len to try out?
If loading with OpenAI endpoint:
model = LiteLLM('openai/prometheus-eval/prometheus-7b-v2.0') # VLLM endpoint
litellm.exceptions.BadRequestError: litellm.BadRequestError: BadRequestError: OpenAIException - Error code: 400 - {'error': {'message': 'invalid model ID', 'type': 'invalid_request_error', 'param': None, 'code': None}}
...and HF endpoint:
model = LiteLLM('huggingface/prometheus-eval/prometheus-7b-v2.0') # Huggingface TGI
litellm.exceptions.APIError: litellm.APIError: HuggingfaceException - response is not in expected format - [{'error': 'Rate limit reached. Please log in or use a HF access token'}]
Thanks.

I figured it out myself by setting VLLM params to:
model = VLLM(model="prometheus-eval/prometheus-7b-v2.0",                  max_model_len=23000,                  gpu_memory_utilization=0.9)


following docs/elan.md "Scenario 1" instructions gives you an old mathlib

As indicated in the title, if you follow the instructions at https://github.com/leanprover/mathlib/blob/master/docs/elan.md under "Scenario 1: Start a new package", replacing nightly-2018-04-06 by 3.4.1 according to master mathlib's current leanpkg.toml file, the result is that you get a checkout of the lean-3.4.1 branch of mathlib, which has not been updated since June 20. I described the situation in more detail on Zulip. This is potentially confusing to new users and even to me. I can easily diagnose what happened and how to fix it, but for the sake of new users we should make it impossible to end up in this situation in the first place.
I infer from elan.md (and also dimly recall) that there was a time when mathlib master built against a nightly version of Lean. As that is no longer the case, can we simply delete the lean-3.4.1 branch of mathlib? Then leanpkg should automatically choose the master branch, which is the desired behavior, right?

I pushed for that branch to exist for the simple reason that I wanted to see for myself (and for my summer students) the possible advantages of having a stable version of everything. In theory this sounds like a way of injecting some sort of sanity into the situation, but in practice I did not find too many advantages, so would not be fighting to keep the 3.4.1 branch.

I think the problems described in this issue have been solved by the 3.4.2 branch etc... @rwbarton Shall we close this?

I agree this is fixed.


Bump to Squirrel 0.9.1

This fixes squirrel/squirrel.windows#257, which almost certainly didn't hit Atom Shell-based apps, but let's be extra paranoid. Verified with a full build + install of atom/atom@000237

Awesome, thanks

Published as 0.25


Type declarations

Updated types for tool-bar
PS: added a 14px option so later I make a PR for that one: https://github.com/suda/tool-bar/issues/288

Nice! It's probably best to merge this in after all the other PRs get in :+1:

@aminya probably needs to be rebased on top of master now :)

This is ready

@suda I ran the CI again. This is ready.

It's conflicting after merging in the refactor :(

It's conflicting after merging in the refactor :(

I fixed the conflict.


v0.3.1

Softbuffer is broken on recent builds of Redox without the fix here, so it's helpful to have a new release that fixes it. We seem to have accumulated a few non-breaking fixes, so it seems like a good enough time to do a release anyway.
Disabling fetch on Windows could be considered breaking, but it doesn't change the API, was broken anyway, and is likely unused. So I don't think that's an issue.

I have no idea what's going on with the link errors for the Windows CI; I guess some testing there is warranted before a release, though I'm not currently booted into Windows...

I'll look into the Windows errors

Any updates on this?

It looks like https://github.com/rust-windowing/softbuffer/issues/142 isn't really related to softbuffer, so that probably doesn't block a release...
May be better to release before merging https://github.com/rust-windowing/softbuffer/pull/149, since winit will still be using 0.30 (pending https://github.com/Smithay/client-toolkit/pull/403, etc.)

I agree. @notgull what do you think, can we do a release if the windows issue is not a regression?

https://github.com/rust-windowing/softbuffer/pull/150 could be good to get in the release, if @daxpedda thinks that PR is good. (The Web backend is probably the one I'm least familiar with.)

#150 could be good to get in the release, if @daxpedda thinks that PR is good. (The Web backend is probably the one I'm least familiar with.)

Indeed, would be nice to wait for that, I'm reviewing it as we speak.

I agree. @notgull what do you think, can we do a release if the windows issue is not a regression?

I'm fine with it.

@ids1024 are you able to tag/publish a release?

I already released on crates.io. I hadn't thought to tag a release on Github, but I've done that now.


Games button

Necessary to fix the "game" button, since it does not work. If you go to the URL "/ games /", then you will also not be able to go into the games.

Acces to games is presented by URL:
platform/games.
Also in #136 pull-request added button to top panel responsible for games navigation


DeleteDatasetRows not Listed as Operation

DeleteDatasetRows not Listed as Operation.  What else is missing?
Doc URL: https://docs.microsoft.com/en-us/power-bi/service-admin-auditing#operations-available-in-the-audit-and-activity-logs
I'm trying to use PowerShell to pull in audit logs, I want all operations for the most part but the DeleteDatasetRows, which is not Listed as Operation, is generating 5K rows per hour in our log and is too noisy for analysis.
It doesn't seem as though there is a way to exclude an operation, only include [x,y,z] operations.  So I need a full list of operations to be able to include them all except this one operation.
The fact that this documentation is missing an operation ,for a feature/operation that is very mature, leaves me suspect of other missing operations.

Hi @TravisKale,
Please let us know which document you are using. That way I can assign this Issue to the document author,
Thanks
The DOCS team

Updated original issue with doc URL.   https://docs.microsoft.com/en-us/power-bi/service-admin-auditing#operations-available-in-the-audit-and-activity-logs

Thanks @TravisKale.  This issue has been assigned to the doc author for review.

Hi @TravisKale - Thanks for your patience while I researched. We acknowledge that DeleteDatasetRows  can be a nuisance. And, unfortunately, the filter action only supports "equal" & "and", making it impractical to exclude events. Today, the better approach is to download all events and then exclude or delete in the local archive. I've shared your feedback with the product group.

@kfollis This issue is not about the filtering capability, its that the documentation I point to does not have the DeleteDatasetRows operation defined.  The only reason I mention the filtering is because of the lack of sophistication in the tooling, I need to know all the possible operations to filter out what I don't want, i.e. I have to call out every operation I do want.

Thanks for clarifying @TravisKale. I've reopened your issue and am looking into the enhancement you've requested. For the task you're describing, the better approach is to download all events and then exclude or delete in the local archive. But if I understand what you're asking for correctly, you can't tell what you do want because you're not sure that the operations list includes all the operations you might want.

@kfollis Yes, that is my main concern, not all operations are listed in the documentation, well at least one for sure, and I need a comprehensive list to make sure I'm not excluding anything by not including it in my include list.

Hi @TravisKale,
I'm cleaning up our Git Issues queue, and I noticed that this Git issue is a bit old, so I'm going to close it.  I hope that you were able to get your questions answered. If not, please let us know.  Another option is to submit your questions to the Power BI community (community.powerbi.com).
All the best,
the DOCS team

@mihart No, the documentation is still incomplete.  Very frustrating to see this issue linger for over a year only to be swept under the rug.

@mihart the issue @TravisKale pointed is still not resolved. I was also trying to understand what the "DeleteDatasetRows" event means but couldn't find it in the documentation

@georgedarakji and @TravisKale - I am reopening this issue due to the gaps that you're still seeing. The article was recently updated and numerous events were added, but I do note that the documentation is incomplete - I will refer the issue to the product team owner for further discovery.

Hi @TravisKale,
Can you please post a snippet of the log containing this event (DeleteDatasetRows)?
Thanks,
Kesem

@KesemSharabi below is a screenshot. I am pulling the audit log using the API and this is what I am getting in the screenshot.

@TravisKale please jump in if you can and provide a snippet too

Thanks @TravisKale, I'm pulling the engineering team to look into this and will update you shortly.

Hi @KesemSharabi. I can see that the DeleteDatasetRows activity was added to the documentation but it is still not clear what this activity represents. It will be great if you can explain it in the Notes field. Does it represent rows getting deleted as a result of a dataset refresh or what exactly is it? Thank you

@KesemSharabi @kfollis any update regarding my last post please?

Hi @TravisKale,
DeleteDatasetRows Indicates that the Push Datasets - Datasets DeleteRows API was called.
I added this information to Operations available in the audit and activity logs.
Thank you for your patience and for getting involved.
Kesem


Icons not visible on my QHD monitor (2560 x 1440)

Describe the bug
As implied from the title, the icons throughtout jellyfin media player on my QHD monitor appear to be broken. Although the theme appears to be fine when jellyfin web is viewed on the browser

On a Smartphone or Tablet?

Device:  Windows 11 QHD monitor

Are you using any extra code in your "Custom CSS" field?
If yes, please include it here.
@import url('https://cdn.jsdelivr.net/gh/MakD/zombie-release@latest/zombie-min-git.css');
@import url('https://cdn.jsdelivr.net/gh/stpnwf/ZestyTheme@latest/colorschemes/green.css');

/*if the logo is present on the details page and loaded hide the title so it doesnt duplicate and look weird*/
#itemDetailPage .itemName.infoText.parentNameLast > bdi:nth-child(1) {display: none;}
.hide+.detailPageWrapperContainer .itemName > bdi:nth-child(1) {display: block !important;}
/*the same but for the single episodes link back title*/
#itemDetailPage .parentName > bdi:nth-child(1) {display: none;}
.hide+.parentName > bdi:nth-child(1) {display: block !important;}

/* remove My Media title */
.section0 .sectionTitle {display: none;}

Screenshots (from jellyfin media player)

Awesome, and glad to hear that it works well on QHD screens. Feel free to create an issue if something looks broken there.


Transaction Failed

I have used this plugin but i when i have transaction to bank limit issue how can i solve this issue ?

not sure about this issue but look like issue with bank or upi id

just google things if something need to be in plugin let me know

i have use my live upi and other upi check but same issue facing in bank limit exidded transaction not success.


Add support for Response constructors

I noticed that none of the Response constructors seemed to exist. It seems like this is because the constructor in Response.webidl accepts multiple types, and one of those types is ReadableStream which isn't defined yet. That causes an Unrecognized type: ReadableStream warning and all constructors for Response are omitted even though the other argument types could be supported.
I'm curious what you think is the best way to handle this.  This PR changes the function that converts UnionType to IdlType::Union to include any supported types instead of returning None when there is at least one unsupported type, but I'm not sure if that's a good idea.

This seems like a good idea to me, thanks for the PR! I might want to be sure that we still have a warning for unknown types, but otherwise ignoring them for now seems fine.
@fitzgen or @afdw, do y'all have thoughts on this?

Thanks @alexcrichton. The Unrecognized type: ReadableStream warning is still printed by this code. Is that what you're referring to?
Also, on a side note, is there a better way to get the bytes out of a ArrayBuffer from rust? In my test case here I'm just using a DataView and reading each byte one by one, but that seems inefficient and I was hoping there was something like with strings where the bytes can be copied to the WASM memory and read directly in Rust.

Yes, we still want the warning for unknown types. This let's us audit our code generation, which is important for mechanically generated crates like web-sys.

It seems to me that we should do the unknown type filtering after expanding overloads. That way the overloads that only use known types should be generated regardless. I don't think this is quite what is happening in this PR (correct me if I'm misunderstanding!) If I'm reading this right, it seems like this PR might introduce bugs where an overload was generated that shouldn't exist by effectively treating unknown types as optional.

Yes, I think there are more problems with this approach:

It can generate empty unions (that would not be generated normally).
If we will eventually add support for these unknown types, this addition can be a breaking change. For example, if previously there was a union with only 1 element, so a name without _with_, after adding support for more elements names has to include _with_.

About this particular issue: looks like ReadableStream actually is not defined in WebIDL: https://github.com/heycam/webidl/issues/445. It is currently defined in a custom syntax in its specification: https://streams.spec.whatwg.org/#rs-class-definition.

I think @fitzgen's suggestion of performing filtering after we generate APIs might solve his and @afdw's concerns, @jRiest would you be up for exploring that? We maybe able to just whitelist the ReadableStream type as an interface for now and let it naturally get filtered later as it's not actually defined.

@jRiest hey wanted to circle back to this and was wondering if you'll have a chance to address some of the feedback above? If not no worries, I can try to take it from here too!

Ok I've finally gotten a chance to get around to this, yay! I've moved this over to https://github.com/rustwasm/wasm-bindgen/pull/1014


Add sample for using Direct Line tokens

Fixes #2343

Changelog Entry

Fixes #2343. Add sample for Direct Line tokens, by @navzam, in PR #3779

Description

(following up on the discussion with @corinagum in #2343)
Added a sample that shows how to integrate Web Chat using a token instead of a secret, which can help developers protect their secret and mitigate user impersonation.
I took my original direct-line-token-sample and tried to make it fit the format of other Web Chat samples, particularly the ones in 07.advanced-web-chat-apps.
Open Questions
Since I'm new to contributing to this repo, I have some open questions:

[x] Which samples folder does this best fit into? For now it's in 01.getting-started/k.direct-line-token.
[x] Is there a GitHub Action that needs to be created for this sample? Or should I remove the badge at the top?

Related to CI, which corinagum/compulim would handle

[ ] What are the steps to get a hosted demo of this sample?
[ ] Should I include the Docker-related files that other samples in 07.advanced-web-chat-apps have? If so, any guidance on how I can verify those files?
[x] I have a C# version of the API as well, but didn't include it here because I didn't see precedent for that. Would that be helpful for me to include?

C# version added

[ ] Does the C# version need a proxy from the API to the bot localhost endpoint, similar to what other JS samples have? Or is that only needed for the hosted demo?

Specific Changes

Added bot and API code in bot/ and web/ respectively (in both csharp and javascript), and a README.md. Currently lives in 01.getting-started/k.direct-line-token but can be moved easily.

[x] I have added tests and executed them locally

Not applicable to samples

[x] I have updated CHANGELOG.md
[x] I have updated documentation

README.md included

Review Checklist

This section is for contributors to review your work.

[ ] Accessibility reviewed (tab order, content readability, alt text, color contrast)
[ ] Browser and platform compatibilities reviewed
[ ] CSS styles reviewed (minimal rules, no z-index)
[ ] Documents reviewed (docs, samples, live demo)
[ ] Internationalization reviewed (strings, unit formatting)
[ ] package.json and package-lock.json reviewed
[ ] Security reviewed (no data URIs, check for nonce leak)
[ ] Tests reviewed (coverage, legitimacy)

This is fantastic! Thanks for getting this up.

[ ] Which samples folder does this best fit into? For now it's in 01.getting-started/k.direct-line-token.
[ ] Is there a GitHub Action that needs to be created for this sample? Or should I remove the badge at the top?
[ ] What are the steps to get a hosted demo of this sample?
[ ] Should I include the Docker-related files that other samples in 07.advanced-web-chat-apps have? If so, any guidance on how I can verify those files?

I feel like the getting started folder is most appropriate. Usually that's reserved for the quick deploy samples, but in this case it's something most developers will need to implement.
Could you clarify what you mean by badge? Took a look at the README.md and didn't see what you meant.
Getting this hosted: I'll have to defer to @compulim on this one. Although I see the benefit of hosting it, I think it is most beneficial that the code is available, and hosting would add complexity we don't have the manhours for right now. Let's see what compulim says.
Looks like the Docker files on the 07. samples are related to CI, which I think we can ignore if we don't deploy. TBH, I'm not confident that all of those samples are even running publicly right now ^^;;

Correct :)
@compulim could you verify the above?

Thanks! I snuck a 5th question into the PR description regarding a C# API - any thoughts on that?

Could you clarify what you mean by badge?

I'm referring to the build status badge that some of the samples show, I'm guessing related to the CI you mentioned. For example:

For the badge - yeah, that's it, how did I miss it? It's for the CI - from what I know atm, compulim or I would do the CI so you don't have to worry about that for now :)
Since I know there are plenty of C# bot devs out there - for a C# section, is your /web/ directory similarly done with CHTML etc?
There isn't technically a precedence... but I know there are plenty of C# devs that would take advantage of this sample. I'm thinking doing something like the following:
samples/a.getting-started/k.direct-line-token/csharp
samples/a.getting-started/k.direct-line-token/javascript
Inspiration taken from https://github.com/microsoft/BotBuilder-Samples/tree/main/samples
Thoughts?

I had the API in both JS and C#, but both of them used a static index.html for the frontend. I only had the bot in JS since it's more of an accessory in the sample, but in hindsight, that's not ideal b/c a C# dev would want a C# bot to run the full sample.
So yeah, I think the structure you suggested makes sense, with the README (and maybe the static files in /web/public/) at the root since they're common to both.

Sounds good, thanks for the update. I'll try to get the C# version in here shortly

C# version is in there now. I added another open question around whether the C# version needs the API-to-bot proxy that other JS samples have.

@navzam I updated your branch with master, just FYI :)

Awesome, thanks @corinagum for helping review and merge this!


Mention the branch to use when deploying zkevm-contracts

I am going through the tutorial mentioned in the following link -
https://docs.polygon.technology/zkEVM/get-started/deploy-zkevm/create-wallets/
In this article it is asked to take clone of the main branch of the zkevm-contracts repository, but the directory structure in the main branch is different from that mentioned in the doc. Also the deployment parameters file is also different from that used in the main branch
So can you confirm which branch should i use for deploying the contracts ?

Hi there @amitOodles,  I'm so sorry you're experiencing these problems. Actually, this deployment guide is very out of date and we are in the process of updating it but it is taking time.
What you could do is use the CDK rollup guide, which is essentially the same guide: https://docs.polygon.technology/cdk/get-started/deploy-rollup/intro/
However, please note we are still working on updating the start services section in that guide.
Let us know if you have any issues with this guide and keep an eye out for updates.
Thank you for reaching out.


Refactor routes

Refactored the code so that it is easier to use routes without typos. You just have to tap into the route by using {classname.id}.

@DesignrKnight  I would like to close this or as I've figured out another way of doing this more efficiently.
I created a separate file which through which all the routes can be managed and we can just tap into the routes at different places by Routes.{nameOfTheRoute}. I think that is a better way of handling this as you suggested.

Fixed by #116


Vite 4.0

Will this be updated to support the latest version of Vite (4.x)?

Hello. Yes, I am planning the update and will work on it shortly.
The current version of Peat most probably is already compatible with Vite 4, as I have not found any mention of breaking changes to the manifest file Vite produces, which is what Peat hooks into. You might give it a try.

From what I can tell, only the default server port for development server has changed from 3000 to 5173 since Vite v3. You should be good to go and use this tool for your integration @compilekaiten.

Hey. I figured this would work fine, since not a lot has changed. But, I saw the ReadMe said 2.*, so I figured I'd ask.
I'll go ahead and test this out, and see if it fits my project.
Thanks!

I have just updated the readme to mention support for v3 and v4. Let me know if you encounter any problems.
FYI: This tool is production ready, I'm using it on multiple projects, I just have not found time to include automated testing, that is the only reason it sits on 0.* versions.
Have a nice end of the year.

I have just updated the readme to mention support for v3 and v4. Let me know if you encounter any problems.
FYI: This tool is production ready, I'm using it on multiple projects, I just have not found time to include automated testing, that is the only reason it sits on 0.* versions.
Have a nice end of the year.

Sorry to reopen this, but any chance you have a link to a project that utilizes this? Would be nice to see visually how this operates. I'm not sure I'm setting this up correctly 😅

let me give you a helping hand.
first, you need to understand that all this tool does, is provide you with script tags to your jS modules and link tags for CSS files, which it reads from manifest.json generated by Vite in production/build or localhost dev server.
So you first need to configure Vite to

generate manifest file upon build
output JS entry file instead of HTML entry file (which it generates by default), usually main.js

Since you will be serving the JS/CSS assets from PHP, you do not want the static HTML.
For that you only need to <?php echo $locator->entry('src/main.js'); ?> in your PHP template.
To get the locator, you configure the bridge service
$bridgeService = new ViteBridge(
    manifestFile:  __DIR__.'/public/my-js-widget/manifest.json', // this must poin to the manifest file
    cacheFile: __DIR__. '/temp/vite.php',  // this may be any writable file location
    assetPath: 'my-js-widget',
    devServerUrl: 'http://localhost:5173',
);

and
$locator = $bridgeService->makePassiveEntryLocator(false); // pass true here for development

As you can see, if you pass true above, the script and link tags willl point to your localhost where you should have the dev server running.
Let me know if you have problems with the PHP configration or you are unable to make Vite output the correct files for you.

and nope, i dont have any open source project using this ... maybe I should create a a sandbox.

So I think I've got it setup correctly. This is my project layout: https://prnt.sc/osOBORtxzqlj

public_html is my web root and where I'm using the bridgeService and locator.
the js folder houses my Vite/Vue3 TS project.

What I'm a bit confused on, is if I include the HTML tags in my index.php file like in the screenshot above, or just echo the locator?
I think a Sandbox example would be nice, especially for people like me that aren't as experienced.
Thanks

I understand now.
You want to remove the echo part on line 15 (keep the assignment), and replace the lines 26-27 with just <?php echo $html; ?> to output the content there.
In development mode (what you have there now) it should print exactly the same content on those 2 lines. That is how you know it works correctly.
Once you pass false to $bridge->makePassiveEntryLocator(false), the printed tags will point to assets compiled by Rollup. That will be your next step.

P.S.
You are not echoing the locator, but the assets returned by the Locator::entry method (see ViteEntryAsset class).

Thanks for your help! This is a great project.

Maybe the documentation sux 🤷♂
BTW I created a simpler approach with ViteHelper ... Wonder if that would have helped you start it up faster.
The helper would basically reduce your code to this for bundles:
<?php echo Dakujem\Peat\ViteHelper::extractAssets('src/main.ts','./vue/manifest.json','/vue'); ?>

and this for development server:
<?php echo Dakujem\Peat\ViteHelper::populateDevelopmentAssets('src/main.ts','http://localhost:5173'); ?>

But it does not use the PHP cache file and as such is a bit slower.

Maybe the documentation sux 🤷♂
BTW I created a simpler approach with ViteHelper ... Wonder if that would have helped you start it up faster.
The helper would basically reduce your code to this for bundles:

<?php echo Dakujem\Peat\ViteHelper::extractAssets('src/main.ts','./vue/manifest.json','/vue'); ?>

and this for development server:

<?php echo Dakujem\Peat\ViteHelper::populateDevelopmentAssets('src/main.ts','http://localhost:5173'); ?>

But it does not use the PHP cache file and as such is a bit slower.

I think this is a nice way to get up and running very quickly, especially if someone wants to just test it.
Utilizing the cache is a must though!

Yes, that cache improves the performance a lot in production, especially with opcache and jit.
I included that ViteHelper in documentation for "configuration troubleshooting", that should get people on the right track faster.
See it here: https://github.com/dakujem/peat/tree/feat/friction-reducer#troubleshooting-configuration


Tweaks to replay script generation

This PR fixes tweaks 3 things surrounding replay script generation:

Fix issue where grouped parameters would become unquoted (i.e. -param "a b c" would become -param a b c in script, now it stays the same).
Add code to set environment variables in script
Add Windows support: .bat instead of .sh, no #!/bin/bash header, set env variables appropriately for each platform

I haven't yet tested the Windows support, but I did add a replay test based on Surelog (so that it catches all platforms), and I can kick off a wheel build to try it out.

Nice fixes.


adds a note about serial steering cars working wOP

Add a small note under Community Maintained cars saying OP will work with serial steering cars with additional hardware and minor code modifications

We'll add a page to the wiki for cars that are well-supported in forks and just link to that in the README. @VirtuallyChris will get the wiki page up sometime tomorrow, and you can add this info there.