Add randomUint/randomInt cheatcodes

Component
Forge
Describe the feature you would like
While property-based testing (fuzz) should fit for most case of general testing, there are some other cases where a test function would require generating random values dynamically.
As an example, here is a function that ensures rewards of a staking contract are properly applied no matter the number of time the APR has changed after an investment, as well as no matter the intervals between each pair of APRs changes.
function test_rewardsOf_1(
    uint256 initialInvestment,
    uint256 numberOfAPRChanges
) public {
    // Initially invest random amount of tokens
    deal(investedToken, address(1234), initialInvestment);
    vm.prank(address(1234));
    testedContract.stake(initialInvestment);

    // Bound numberOfAPRChanges to [0,200]
    numberOfAPRChanges = bound(numberOfAPRChanges, 0, 200);

    // Create random number of APR change after investment
    for (uint256 i = 0; i < numberOfCheckpoints; i++) {
        testedContract.setAPR(randomNumber(0, type(uint16).max));

        // Move forward a random amount of time until next APR
        skip(randomNumber(0, type(uint40).max));
    }

    // ... Verify that rewards are properly calculated
}

In this example using randomNumber() would be better than using static values as it would potentially reveal more complex errors scenarios.
However, I think those random values wouldn't offer the same trust than random values received through functions parameters (as they are simple random values and don't use any shrinking/resolve mechanism).
Maybe a solution could be to implement shrinking/resolve on those too, but its seems complex.
So I'm a bit mixed on this idea, but I'd be happy to read your thoughts on it :)
Additional context
No response

Note that I've already tried this library but it slows my tests run by ~200x.
I also tried to implement my own helper contract relying on ffi to retrieve $RANDOM environment variable, but it also slows so much my tests runs and may produce inaccurate results on numbers that don't fit in 64 bits.

imho @mds1 this sounds like a good idea to build this in. wdyt?

In this example using randomNumber() would be better than using static values as it would potentially reveal more complex errors scenarios.

You can also achieve this with a new fuzz parameter that you hash in each iteration of the loop:
function test_rewardsOf_1(
    uint256 initialInvestment,
    uint256 numberOfAPRChanges,
    uint256 entropy // <-- new param
) public {
    // --- snip ---
    for (uint256 i = 0; i < numberOfCheckpoints; i++) {
        testedContract.setAPR(randomNumber(0, type(uint16).max));

        // Move forward a random amount of time until next APR
        uint256 randomNumber = uint256(keccak256(entropy, i));
        skip(bound(randomNumber, 0, type(uint40).max));
    }

    // ... Verify that rewards are properly calculated
}

Or if you don't want to introduce a fuzz param because you want determinism, you can deterministically generate a pseudo-random value:
function test_rewardsOf_1(
    uint256 initialInvestment,
    uint256 numberOfAPRChanges
) public {
    // --- snip ---
    for (uint256 i = 0; i < numberOfCheckpoints; i++) {
        testedContract.setAPR(randomNumber(0, type(uint16).max));

        // Move forward a random amount of time until next APR
        uint256 randomNumber = uint256(keccak256("entropy", i));
        skip(bound(randomNumber, 0, type(uint40).max));
    }

    // ... Verify that rewards are properly calculated
}

Note that I've already tried this library but it slows my tests run by ~200x.
I also tried to implement my own helper contract relying on ffi to retrieve $RANDOM environment variable, but it also slows so much my tests runs and may produce inaccurate results on numbers that don't fit in 64 bits.

Yea ffi is very slow and I wouldn't recommend using it for this purpose. A much better/more performant approach to use $RANDOM would be to just use vm.envUint("RANDOM")

imho @mds1 this sounds like a good idea to build this in. wdyt?

This feature has been requested a few times, but I'm not sure of the use case. There's also some decisions to make before it's implemented, namely around how it should behave, e.g. should it be uniformly random, or deterministic, or act like a fuzz value (e.g. leverage strategies and the dictionary).

If purely random, we need to introduce a seed for this cheat (it could just be an input), or we could leverage the existing seed param. This is required for when you need reproducibility. But if you're doing that, what benefit does the cheat add over a fuzz param or $RANDOM?
If deterministic, you can do this already by hashing some block/context properties (like timestamp, etc), or by hashing an arbitrary string. You can continually generate deterministic but pseudo-random values this way with a loop index, or by storing the last result in storage then hashing that to get the next result, like this (the example is for generating addresses, but same idea)

I actually think we can easily add this
randmon()
random(from, to)
I believe thread_rng is perfectly fine here
adding this isn't much work or complex and having a simple cheatcode for this could be useful

@Tudmotu what is your use case for this that you can't do with a fuzz parameter or vm.envUint("RANDOM") + forge-std's bound method to get your randomness within a range? I hear this feature requested a lot but honestly haven't heard a compelling use case for a dedicated randomness feature
My main hesitation about adding it is (1) I'm not clear on the use case, and (2) it's another thing that needs a seed config option, so consequently needs some way to be reproduced when a fuzz run fails, so reproducing test failures gets a bit more complex

Up till now I've been using ffi + python for random.
Testing envUint('RANDOM') now, I get an error trying to access RANDOM:
Failed to get environment variable `RANDOM` as type `uint256`: environment variable not found

I'm running Linux. So possibly RANDOM is not injected into the Foundry process?
Not sure my personal use case is applicable to many people:
In my scripts (not tests) I write temporary files and I need their names to be random so that I don't accidentally overwrite them.

Are you running a fuzz test? If so you can just add an extra fuzz parameter, or use msg.data as your entropy. Can also use vm.unixTime which might help

Personally I need it in a script, not a test. But again, I have a very specific use-case. The idea of using unixTime might actually be good enough for me. Thanks, didn't think about that!
So unless someone else has a more common use case, I agree it might not be necessary :slightly_smiling_face:

Up till now I've been using ffi + python for random. Testing envUint('RANDOM') now, I get an error trying to access RANDOM:
Failed to get environment variable `RANDOM` as type `uint256`: environment variable not found

I'm running Linux. So possibly RANDOM is not injected into the Foundry process?
Not sure my personal use case is applicable to many people: In my scripts (not tests) I write temporary files and I need their names to be random so that I don't accidentally overwrite them.

this is because $RANDOM is not an env variable in Linux but rather a script injected by shells like bash. This is why it isn't visible with the env command.
I would need this random feature too. I would like to simulate some market transactions.

Some questions that need to be answered before a vm.random() cheat is introduced, namely around how to guarantee users can always reproduce failed tests when the cheat is used:

Should it be reliant on the calldata, like the solady method, that way the approach to reproducing failed cases doesn't change? If not, what does the UX look like there to ensure you can always reproduce failures? (Consider that users will want to run both with and without specifying a seed for the rng).
Should it leverage the same strategies as fuzzer inputs for generating values, or should it use some other distribution?

I'll share my extended personal opinion:
I view Forge as something beyond a testing framework. Don't know about any of you, but I use Forge scripts extensively & practically have replaced all my JS scripts with Solidity scripts by now, including stuff like automatically updating our Notion docs whenever we deploy. Forge is to Solidity what Node was to Javascript — and I believe we will start seeing more and more libraries built specifically for Forge (e.g. Surl). Therefore I think it is reasonable to include a cheatcode even if it is not suitable for writing tests, as long as it caters to script & library authors.
I also think test authors should know what they are doing to some degree. Jest does not prevent me from using Math.random(), for example. And there are many other ways in which tests can become flaky.
That said, while I don't hold the same view, I do understand your position regarding reproducibility.

Hi everyone, sorry if this is not the appropriate place to ask, but wondering now that this is merged into master when will it be available as a release, or how I might install master on my local?
Im currently using 6822860 2024-07-29T00:23:34.055980000Z
Cheers


Factory for model with attribute named 'y' breaks console reload!

Description
If you have a rails model with an attribute named 'y' and you have a factory that sets this attribute, then using the reload! command in the rails console generates the following error:
NoMethodError (undefined method `end_line=' for nil:NilClass)

Reproduction Steps

create a new rails 6.0.x project
add factory_bot_rails to gemfile & bundle install
create a rails active record model which includes an attribute named 'y' (eg rails g model Foo name:string x:float y:float and then run rails db:migrate  )
start the rails console and enter the reload! command in the console

Expected behavior
the Rails console should reload the application
Actual behavior
the following error message is displayed:
NoMethodError (undefined method `end_line=' for nil:NilClass)
If you comment out the line in the factory definition that sets 'y', then you will not encounter an error message when using the console reload! command
System configuration
factory_bot_rails version:  5.2.0
factory_bot version:  5.2.0
rails version:  6.0.3
ruby version: 2.5.5 (also tested with 2.6.3 with same results)
Additional Information
It happens during the FactoryBot.find_definitions call, though ultimately the error message occurs in psych's tree_builder.rb file but I wasn't able to track down why.

@composerinteralia thanks for the workaround, that does indeed do the trick!

I played around with #1144 a bit more, and I don't see a way of making it work without potentially breaking the code of anyone who is extending the definition proxy (BasicObjects don't have an #extend instance method). Since we don't offer an alternative way to extend factory_bot with additional methods, this is not something I want to mess around with at the moment.
Since I think this is a fairly uncommon edge case, and there is a reasonable workaround, I am going to close this issue for now. If the issue comes up again I will reconsider.
Thanks for opening! This was an interesting one.

I just bumped into this - your solution works, a small bit of debt I'll document. thank you

Ha! This is exactly what it is. Good sleuthing! I was trying to figure out what was special about these factories that it was causing this exception.
Definitely not an ideal fix but a minor eyesore to work around what should be a fairly rare issue.
Thanks!

@composerinteralia works perfect with add_attribute 💪🏿


Upgrade Angular dependencies

I'm currently working on this. A PR will follow shortly
I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request

What is the motivation / use case for changing the behavior?
Currently there's otherwise an issue that on some machines (apparently) the examples page of the demo app doesn't start.
Tasks

[x] Upgrade dependencies (currently working on here)
[ ] Adjust library packaging with ng-packagr (currently working on here)

@aitboudad Status update: will have some time probably next week to work on this and hopefully finish it. I'll send you a PR. It's not just the updating of the deps, which I already have. But a setup similar to what I tested here: https://github.com/juristr/ngx-tabs-libdemo/tree/with-demoproj-setup
Will let you know

if you're looking for a workaround to make ng-packagr working with the current base, see https://github.com/aitboudad/ngx-loading-bar/blob/next/.config/ng-packagr.patch ;)


@belak @indrajitr any thoughts on this PR?

    @belak @indrajitr any thoughts on this PR?

Originally posted by @Enzime in https://github.com/sorin-ionescu/prezto/issues/1982#issuecomment-1076909655

I'm guessing this was a mistake - the referenced PR was already merged a while back.
I'm closing for now but feel free to comment with more info and we can re-open it.


HTML Parser

I really need help with the parser. If someone could get it working that would be soooooo cool!!!

Switching to node soon, no need now I guess


Fix breaking changes from ESPHome 2022.9.3

esphome/eshpome#3817 introduced some changes that won't allow to update the component after doing the esphome update.

Seems to fix #55 here.


Proposition of change to Whitespace, an Esoteric language

As the title say's so. I believe that by moving nocode to the esoteric programming language called Whitespace would increase its performance and readability by numbers above 100%.

nocode compiles itself via bootstrapping, the source code of which can be viewed at [1], so the whitespace compiler is not needed.
Unfortunately the whitespace compilers available consist of code, which goes against the nocode phliosophy (please see no specifications), thus nocode bootstraps itself using ``.
[1]


Importing CSS file from CDN causes theme.js to not run

Problem
When trying to link an external stylesheet, theme.js fails to run. I'm importing other CSS files this way without an issue.
Replication steps

Run slate-tools start --env=development
Add <link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/bulma/0.7.1/css/bulma.min.css">  to theme.liquid in the head.
Code inside theme.js fails to run.
Remove the <link> and theme.js runs normally

For what it's worth, its more performant to copy this stylesheet into your project then to request it from another CDN. The extra DNS lookup required for this external call could be avoided.
Nevertheless this sounds peculiar.

Yes, I tried multiple ways and still had the same issue. For the sake of submitting the issue, I thought this was the easiest to replicate.
I tried all of these:

placing the file in vendors and using asset_url
importing the .css file into theme.scss via @import
copying the contents of the file into a .scss file and importing into theme.scss

Odd, I tried again today and it works. I'll reopen this if it happens again.


802- cucumber errors require message assertion

Description
Cucumber supports several different steps to verify the success/failure of the scenario. Some are not precise and only assert that an error occurred. This change requires each scenario to include the message/reason for the error.
Changes

Removal of the profile is invalid step, leaving the profile is invalid because "<reason>"
Removal of I am presented with an error message
The the profile is invalid because "<message>" step now accepts a regular expression to verify the message
Errors formatting a value during generation will now emit an InvalidProfileException
The type of the constraint operand/value is asserted during reading, an InvalidProfileException is thrown if it is not of a legal type (e.g. shorterThan "foo" operand/value is a String)
String length operands/values have a minimum length requirement (0 or 1 depending on the operator), resolves #822
String length constraints must be <= Integer.MAX_VALUE, Resolves #827
DataBagValue moved to the same package as DataBag to maintain an appropriate (restrictive) level of encapsulation
Cucumber framework captures InvalidProfileException and JsonParseException types in the the profile is invalid because "<message>" step, to cover issues deserialising values e.g. +12
Scenario created to assert that absent-values aren't formatted - #266

Issue
Resolves #802
Resolves #822
Resolves #827
Resolves #266

Codecov Report

Merging #832 into master will decrease coverage by 0.03%.
The diff coverage is 86%.

@@             Coverage Diff              @@
##             master     #832      +/-   ##
============================================
- Coverage     66.48%   66.44%   -0.04%
+ Complexity     1750     1747       -3
============================================
  Files           286      286
  Lines          6072     6080       +8
  Branches        699      696       -3
============================================
+ Hits           4037     4040       +3
- Misses         1788     1790       +2
- Partials        247      250       +3

Impacted Files
Coverage Δ
Complexity Δ

.../generator/generation/FieldSpecValueGenerator.java
100% <ø> (ø)
7 <0> (ø)
:arrow_down:

...tlogic/deg/generator/StandardGenerationEngine.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...ttlogic/deg/generator/outputs/GeneratedObject.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...ogic/deg/generator/utils/DataBagValueIterator.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...m/scottlogic/deg/generator/outputs/CellSource.java
25% <ø> (ø)
1 <0> (ø)
:arrow_down:

...enerator/violations/ViolationGenerationEngine.java
100% <ø> (ø)
6 <0> (ø)
:arrow_down:

...tor/outputs/datasetwriters/MultiDataSetWriter.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ator/outputs/datasetwriters/JsonDataSetWriter.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...eg/generator/outputs/targets/FileOutputTarget.java
20% <0%> (ø)
1 <0> (ø)
:arrow_down:

...generator/inputs/AtomicConstraintReaderLookup.java
95.51% <100%> (+0.84%)
50 <14> (ø)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfebb57...bb56b29. Read the comment docs.

I'm surprised that we've got so many functionality changes in this PR, the original intent of the issue was to convert existing cucumber scenarios to using the specific message where possible and raise bugs for areas where it wasn't possible. Instead we've tried to fix all of those issues as we've gone along and this has introduced a lot of weighty code to read through. I'm also concerned with the prevalence of InvalidProfileException in the code base now due to the data bag value changes. I'm wondering if it's worth cutting back these changes just to the cucumber side with additional issues raised to solve the class cast/formatting issue with more thought to the overall architectural changes?


✨ auto run page rank post crawl

Description

✨ auto run page rank post crawl

@transitive-bullshit Please review 👓 ✨


Fetch latest records first using 'position tail' and offset

Fix for https://github.com/logrange/logrange/issues/102

Also added test case for both cursor forward and backward usecases.


update: update README.md file with latest UI

currently README.md file contains old UI screenshots. update the README.md File with appropriate details.

@MustafaKhan026 @ruturaj-gh @tejasviurka @Sankalp20Tiwari

hello i am new to open source contribution and i am willing to learn, could you please assign me this task and guide me through it. I'll be sure to solve this issue

this will be counted as my PR for hacktoberfest 2023 right?

this will be counted as my PR for hacktoberfest 2023 right?

Yes


feat: update excalidraw package and others

related: https://github.com/dai-shi/excalidraw-animate/pull/28

The "new scene on every refresh" problem happens on the deploy for this branch as well

The problem stems from the useEffect in useScenes which seems to be asynchronously triggering itself

I'm working on a fix for this

Great! Merging.


CommandBar sample Settings button should have a command

Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?

[x] Modification to existing sample

If this is an addition/modification to an existing sample page, which one?
CommandBar, similar request to #258
Is your sample request related to a problem? Please describe it
The example shows a keyboard accelerator for the Settings command (which is hidden in the secondary commands).  However, if you hit 'Ctrl+S' on the sample page, you don't know if it worked, as the button doesn't do anything.
The button should have an action associated to it to show the user that it's been enacted and how the keyboard accelerator code works.
Additional context
Maybe the short-cut for 'Settings' shouldn't be Ctrl+S in the example as that's usually 'Save' in most applications? Opening the Settings app is 'Win+I', so maybe we use 'Ctrl+I' in the sample?

I just changed the keyboard accelerator, I agree with what you mentioned where you would use CTRL+S for saving and Win+I for settings.
As for the functionality, I'm not sure for this example but it doesn't seem like there needs to be an indicator that the button was pressed, but I can build that in as a separate PR.

There, that addresses the main issue you mentioned.


CM-655: Difference Between Returning and Awaiting a Task in an Async Method in C#

@markacker , great thanks for taking care of the naming standards. But the build is broken for a .DS_Store file. Please let me know if I need to look into this?

I’m not sure why this occurred. Perhaps because I am running Visual Studio on a Mac? If you have any ideas on how to fix it would be appreciated – I was trying to avoid having you fix the naming convention.
From: Ahsan Ullah @.>
Date: Friday, February 24, 2023 at 7:54 PM
To: CodeMazeBlog/CodeMazeGuides @.>
Cc: markacker @.>, Mention @.>
Subject: Re: [CodeMazeBlog/CodeMazeGuides] CM-655: Difference Between Returning and Awaiting a Task in an Async Method in C# (PR #898)
@markackerhttps://github.com/markacker , great thanks for taking care of the naming standards. But the build is broken for a .DS_Store file. Please let me know if I need to look into this?
—
Reply to this email directly, view it on GitHubhttps://github.com/CodeMazeBlog/CodeMazeGuides/pull/898#issuecomment-1444830386, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5LDUBHACD2UY52WGJ5LEU3WZFJ5FANCNFSM6AAAAAAVD2KWBU.
You are receiving this because you were mentioned.Message ID: @.***>

@markacker , yes, exactly this is because of Mac. No worries, I'm fixing this now.

@markacker , it's fixed now but I need to force push. So if it needs further changes from your side, you will need to reset your local branch. Again, thanks for doing this for me.

Thank you! It’s probably best if I avoid using Visual Studio on my Mac if I need to make any changes, I’m going to setup a Windows PC for that.
From: Ahsan Ullah @.>
Date: Friday, February 24, 2023 at 8:21 PM
To: CodeMazeBlog/CodeMazeGuides @.>
Cc: markacker @.>, Mention @.>
Subject: Re: [CodeMazeBlog/CodeMazeGuides] CM-655: Difference Between Returning and Awaiting a Task in an Async Method in C# (PR #898)
@markackerhttps://github.com/markacker , it's fixed now but I need to force push. So if it needs further changes from your side, you will need to reset your local branch. Again, thanks for doing this for me.
—
Reply to this email directly, view it on GitHubhttps://github.com/CodeMazeBlog/CodeMazeGuides/pull/898#issuecomment-1444863778, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5LDUBB2IL5VJEO7OYKRX3DWZFNA5ANCNFSM6AAAAAAVD2KWBU.
You are receiving this because you were mentioned.Message ID: @.***>


Add a debug switch

Need to be able to turn debugging for this module on/off in nginx conf.

Or not :) From what I see, overhead from leaving debugging code in there is minimal, so I'm just gonna disable the last directive which spits it out to the nginx error log.


Make responsive... get rid of export sidebar when settings sidebar is open

Create 'Share or Embed' button to close edit sidebar and open export sidebar.


Sort containers by state

Fixes #224 by enabling sorting container by state using 'o' menu shortcut.

[X] Functionality
[x] Docs
[x] CI build

Sorry for my delayed review!
Thinking out loud: in the abstract, it seems like we should have our container view's behaviour consistent with our services view given that they both basically list containers which could be running/exited/etc. But with services, you're never going to have that many, and sorting by whether they'res a container at all seems pretty sufficient because then you don't need to look so hard for any given service given they're always in the same order (so long as there's a container there).
 For this reason I'm actually thinking we should just make sorting of containers, as contained in this PR, the default. Rather than have a keybinding for sorting, I would add a config option that allows the user to specify that they want the old behaviour of sorting by name only. What do you think?

Sorry for the late reply too 😄 .
Sounds good to me. Will make it default and have a config option to allow user defined sorting 😉

@jesseduffield done.. included some tests too

@lpessoa just did a local test and fixed a bug where it crashed upon startup due to a malformed struct field tag. I also noticed that when sortContainersByName is true in my config the containers aren't actually sorted by name. We should either sort them by name in the code or change the config key to be more accurate

@lpessoa just did a local test and fixed a bug where it crashed upon startup due to a malformed struct field tag. I also noticed that when sortContainersByName is true in my config the containers aren't actually sorted by name. We should either sort them by name in the code or change the config key to be more accurate

I have developed the feature to default to the legacy behaviour when the setting is true but forgot to name the var accordingly 😞 (i was thinking on sort by name when developing it).
Do you want to keep the old behavior and change the setting to something like LegacySortContainers?

@lpessoa yeah LegacySortContainers works for me

@jesseduffield LegacySortContainersset for legacy behaviour. Updated the new behaviour to sort by state and name

Nice work!

Just as an FYI, i'm happy i found this PR because i find it very annoying that when i start a container the selected container is changed as they're resorted. Thus i'm now using the undocumented legacySortContainers. Another fix would be that the selection is persisted on container state change! (btw thank you for lazydocker, only just found about it).

@MartinCura could you raise an issue for that?


on pressing enter key - formatting reset issue -> resolved

Once we apply any format like bold, italic, font size, or font color, the formatting is clear by pressing the enter key.
So I found one solution: It does not clear the toolbar selection on enter and also does not flicker the selected value in the toolbar.

Why are there nextjs configuration files and some changes that don't make sense to solve the problem?
please rewrite your pull request with the only changes needed


linprog kwargs not recognised

scipy.optimize.linprog is supposed to accept keywords rr_method and autoscale, but they are not recognised (c.1.7.0 at least), raising a TypeError
Reproducing code example:
result = linprog(np.array([1,1]), A_eq=np.array([[1,0]]), b_eq=1, A_ub=np.array([[0,1]]), b_ub=np.array([2]), rr_method="SVD")
# ERROR

result = linprog(np.array([1,1]), A_eq=np.array([[1,0]]), b_eq=1, A_ub=np.array([[0,1]]), b_ub=np.array([2]), autoscale=True)
# ERROR

Error message:
Traceback (most recent call last):
  File <REDACTED>, line 7, in <module>
    result = linprog(np.array([1,1]), A_eq=np.array([[1,0]]), b_eq=1, A_ub=np.array([[0,1]]), b_ub=np.array([2]), rr_method="SVD")
TypeError: linprog() got an unexpected keyword argument 'rr_method'

similarly for autoscale
Scipy/Numpy/Python version information:
1.7.0 1.20.1 sys.version_info(major=3, minor=8, micro=6, releaselevel='final', serial=0)

Also doesn't work on 1.6

They are not keywords; they need to be part of the options dictionary, e.g.
result = linprog(np.array([1,1]), A_eq=np.array([[1,0]]), b_eq=1, A_ub=np.array([[0,1]]), b_ub=np.array([2]), options={'rr_method':'SVD'})

For new code, I'd recommend one of the HiGHS methods, which do not use these options.

Oh, I see, I didn't notice that they were subheadings of the option keyword documentation, not the documentation for the keywords themselves.

Hi! In case no one else is already on this, I would be down to adding an example for how to use 'options' to the docs.


Fix GENAI_KEY issue to allow demo_mode without requiring API key

fixes #287

Hi @Myrausman when I attempt to run your PR I still see the error:
File "<frozen os>", line 685, in __getitem__
KeyError: 'GENAI_KEY'

Are you running Kai locally?
If you are running Kai locally, please share how you are running so we can figure out why you are seeing this error.

Thank you @Myrausman
My apologies, I wasn't paying close enough attention and forgot we didn't yet default demo_mode to true.

Hey @jwmatthews, looks like this pr addresses #179 as well, so we can close that issue as well.

Hi @jwmatthews, should I remove api_endpoint or wait for your patch test?

Hi @jwmatthews, should I remove api_endpoint or wait for your patch test?

Hi @Myrausman yes, please remove the api_endpoint, I will make time to help test on Monday or Tuesday of coming week.

@Myrausman
I tested your branch with below change and with this I'm looking good to refresh cache on missing requests

$ git diff ../kai/service/llm_interfacing/model_provider.py
diff --git a/kai/service/llm_interfacing/model_provider.py b/kai/service/llm_interfacing/model_provider.py
index 819344d..bdf6176 100644
--- a/kai/service/llm_interfacing/model_provider.py
+++ b/kai/service/llm_interfacing/model_provider.py
@@ -54,7 +54,7 @@ class ModelProvider:
                 model_class = LangChainChatInterface
                 if os.getenv("DEMO_MODE") == "true":
                     api_key = os.getenv("GENAI_KEY", "dummy_value")
-                    api_endpoint = os.getenv("GENAI_API", "dummy_endpoint")
+                    api_endpoint = os.getenv("GENAI_API", "")
                     credentials = Credentials(
                         api_key=api_key, api_endpoint=api_endpoint
                     )


 In particular, the following are removed by this PR:

All Notebook-based examples (these live in qinfer/qinfer-examples now).
MacroPy-based macros for easily writing Model classes; neat, but buggy as hell. We may want to revisit other ways to do this later.
SMCUpdaterABC. This has been superceded by ALEApproximateModel.
UniformDistributionWith0. This has been superceeded by ConstantDistribution and ProductDistribution.
Dialogs, web progress bar and other UI. These were poorly-maintained, and are largely superceded by the new widget-based progress bar anyway.

Coverage increased (+4.3%) to 43.373% when pulling 9f31209e46ac4b6e8d87e179031b0452d027047a on fix-cleanup into 91b50bca039d906397673261735605294a17ba4d on master.

Coverage increased (+4.3%) to 43.394% when pulling 8613f2ea39b1d906e9b6eb7e85e3931d92a10a0e on fix-cleanup into 91b50bca039d906397673261735605294a17ba4d on master.

Coverage increased (+4.3%) to 43.394% when pulling b7e10b42be9c32cc774e6512e57ecbbfdce88e8b on fix-cleanup into a0fc9480bea68e71262ced328946ca8db4427283 on master.

Coverage increased (+4.3%) to 43.394% when pulling b7e10b42be9c32cc774e6512e57ecbbfdce88e8b on fix-cleanup into a0fc9480bea68e71262ced328946ca8db4427283 on master.

Coverage increased (+4.3%) to 43.394% when pulling 537de43dac77dd9174d0ac84385e1acc968fe7f1 on fix-cleanup into a0fc9480bea68e71262ced328946ca8db4427283 on master.

This has been working well for a little while now, so I think it makes sense to merge it in and focus on getting to 1.0.


Add background processes

Use devenv up -d to run honcho with nohup.
devenv down and devenv logs are also included and are analog to their docker-compose counterparts.

This is first and foremost a PoC, so feel free to voice any concerns you might have, I'm more than happy to address them :)

I'm still not sure about this one.
Could you explain what kind of workflow do you have that requires this interface?

I would like to call that also in Gitpod to have one shell.
devenv up -d
devenv shell
and let the user work in the shell and don't have to care about the running services

I guess so, yes

I recommend creating a prototype using https://github.com/NixOS/nixpkgs/blob/e66309ddcce8fc316b9addeabd11bf2187fa2eb9/pkgs/tools/system/daemonize/default.nix.
This works by wrapping arbitrary programs and turns them into daemon processes.
Should be what we need without relying on the programs to do this themselves.

Started discussion about upstreaming this feature to process-compose so we don't need the above comment:
https://github.com/F1bonacc1/process-compose/discussions/35
This way not only the honcho implementation could fulfill the new interface.

Another use case is bootstrapping the project.
E.g. I start Postgres and Django in the background and then I run some commands to run migrations and insert fixtures.
Afterwards I open the URL for the dev server in the browser.
The dev then can start developing and if he needs to reattach to the log view.
I'm currently doing this with overmind.

This is now implemented in #745


AudioPlayer.PlaybackFailed not handled

When I try to run this, I get an error when trying to play back the media file. This is sent as a 'AudioPlayer.PlaybackFailed' request, which doesn't have the applicationid in the sessiondetails, and that causes the following error:

Unhandled exception: Cannot read property 'applicationId' of undefined.

I think the 'pre' function needs to handle that case as well, and the app should probably log errors if it receives them.

@colinfrei did you manage to fix this? I have the same issue

I updated the alexa-app package so request.applicationId returns the correct information in app.pre. See if that works.

It seems to find stuff.  I had a few successful finds.  However, it doesn't play anything afterward.

Same here. Got the answer: {"state":"success","message":"Attempting upload ...","link":"https://s3-us-west-1.amazonaws.com/alexa-youtube-skill/audio/UC81i2M30Bc.mp3"} but it doesn't play any music

This is a known issue that Alexa doesn't play the audio. Can you guys @kadeschs @Firni95 @angelos1989 test this by giving the skill something to look up and then looking through your Lambda's CloudWatch logs? You might be getting something like:
{ message: 'Your GStreamer installation is missing a plug-in.', type: 'MEDIA_ERROR_UNKNOWN' }

Yes. It says it's missing the plug-in.

@dmhacker I have that issue with the Gstreamer as you described. Can we change the content type as suggested by @kadeschs and here : https://forums.developer.amazon.com/questions/59814/audioplayer-live-stream.html

@kadeschs  @angelos1989 I'm going to update the server to return a m3u file (content-type would then equal application/x-mpegurl). The m3u file basically would serve as a redirect to the actual mp3 file, which will still be hosted on the same S3 bucket.

Hi, I'm having the same issue as described with the missing plugin, see my latest Lambda invocation -
START RequestId: 5c7d0039-76ea-11e7-bdd0-534cefdb0c5f Version: $LATEST
2017-08-01T18:51:01.208Z	5c7d0039-76ea-11e7-bdd0-534cefdb0c5f	Searching ... this besito
2017-08-01T18:51:01.537Z	5c7d0039-76ea-11e7-bdd0-534cefdb0c5f	Found ... Luis Fonsi, Daddy Yankee - Despacito (letra official) ft. Justin Bieber - lyrics official.
2017-08-01T18:51:02.320Z	5c7d0039-76ea-11e7-bdd0-534cefdb0c5f	Processed.
2017-08-01T18:51:02.379Z	5c7d0039-76ea-11e7-bdd0-534cefdb0c5f	Stored @ https://s3-us-west-1.amazonaws.com/alexa-youtube-skill/audio/zlabsbE4aiQ.m3u8
END RequestId: 5c7d0039-76ea-11e7-bdd0-534cefdb0c5f
REPORT RequestId: 5c7d0039-76ea-11e7-bdd0-534cefdb0c5f	Duration: 1179.53 ms	Billed Duration: 1200 ms Memory Size: 384 MB	Max Memory Used: 40 MB
Any update on how to fix this issue?
@dmhacker Your help is highly appreciated

@dmhacker Try looking at https://github.com/Fenton-Fenton-Fenton/alexa-tube. They are accomplishing something similar with success.  They are passing the mp3 file temporarily to a dropbox account.  Might shed some light on what's going on here.

@ohadbenita @kadeschs @Firni95 @angelos1989
This is now fixed! The issue was that the mp3 file downloaded with ytdl-core in the Heroku server wasn't the correct bitrate. I fixed this by using ffmpeg to resave the file and modify the bitrate.
Yippee! Finally, no more GStreamer issues. If you are getting an issue or something isn't working, make sure everything you've done on your end matches the setup instructions in the README.


Add profile support to Vienna

As a developer I want to be able to launch Vienna with different profiles that point Vienna to a different set of preferences and a different database for testing.
This might be implemented through command line arguments and an applescript launcher.

Looks like most of this already exists: https://github.com/ViennaRSS/vienna-rss/blob/master/src/Preferences.m#L75-L83


Master server restarts causing reattach of DB

Alluxio Version:
2.4.1
Describe the bug
I am using Catalog Service and AWS Glue . I attached the Db from glue to Alluxio and able to see /catalog files
created in S3 bucket successfully. Also I am able to execute queries via Alluxio. However when master server get restarted
I have to detach and attach the Db again else it wont work. Is this a bug? or are there any parameters I have to set so that master server will reattach/sync/activate the catalog connection so that I should be able to use it as normal.
To Reproduce
a) Attach a Glue DB
b) Execute Query - Works
c) restart master server
d) Execute Query - fails
Expected behavior
Restart of master server should not affect the DB attachment

@pabrahamusa I have a question. You mentioned you have to detach after the restart. Could you provider more information about that?

@gpang   I am running Alluxio master and worker ina Kubernetes. And if due to any reason the master Alluxio pod crashes, or restarts or change a node (which is normal in kubernetes ) . Then after restart of master the search will stop working. Then my solution is
a) Detach the DB catalog
/opt/alluxio-2.4.1/bin/alluxio table detachdb alluxio_mydatabase
b)  Attach the Database back
/opt/alluxio-2.4.1/bin/alluxio table attachdb --db alluxio_mydatabase glue null mydatabase -o udb-glue.aws.region=us-east-1 -o udb-glue.aws.catalog.id=xxxxxxxxxx
After this two steps search will start to work. Also I have to do the same steps to see the latest data from S3. Why restarts causes master to lose DB information also why Allusio is not syncing with Glue regularly to fetch latest metadata

@pabrahamusa For the syncing, there is a sync cli command to fetch the latest metadata: https://docs.alluxio.io/os/user/stable/en/operation/User-CLI.html#sync
However, could you describe what happens when you DO NOT detach the catalog after a restart? What is the error? If you use the table ls command (https://docs.alluxio.io/os/user/stable/en/operation/User-CLI.html#ls-1) what does it show?

I don't currently have a glue setup yet, but I tried restarting the master locally, with an attached hive metastore, and the restarted Alluxio master still has all of the catalog information, without having to detach and attach.
Could you give us more information after the restart, for example, with the alluxio table ls ... command?

Thanks @gpang , I tried the ls command
bash-4.4$ /opt/alluxio-2.4.1/bin/alluxio table ls alluxio_mydatabase sb_s3_mydata
As you can see it  is listing correct S3
bash-4.4$ /opt/alluxio-2.4.1/bin/alluxio table ls alluxio_mydatabase sb_s3_mydata
This print all catalog information
The issue now is when you fire a query from Presto it will not work . To make it work we have to detach and attach the DB again.  Let me try sync and see.

@gpang , I tried the following and I can see data appearing with out detach attach. However I have to do the sync every time if master server got restarted.
/opt/alluxio-2.4.1/bin/alluxio table sync alluxio_mydatabase

@gpang  anu idea?

@gpang  anu idea?

I also tried setting this at master level however no effect
alluxio.table.catalog.udb.sync.interval: "45m"

I also tried setting this at master level however no effect
alluxio.table.catalog.udb.sync.interval: "45m"

@gpang @apc999  I solved it by adding one more container to do the sync, Hope this helps some till there a permanent soln
        - name: sync-ax-data
          image: {{ .Values.image }}:{{ .Values.imageTag }}
          imagePullPolicy: {{ .Values.imagePullPolicy }}
          securityContext:
            runAsUser: {{ .Values.user }}
          command:
          - /bin/sh
          - -c
          - /opt/alluxio-2.4.1/scripts/sync_ax_data.sh

apiVersion: v1
kind: ConfigMap
metadata:
  name: extra-script-config
  labels:
    name: extra-script-config
    app: {{ $name }}
    chart: {{ $chart }}
    release: {{ .Release.Name }}
    heritage: {{ .Release.Service }}
data:
  sync_ax_data.sh: |-
      #!/bin/bash
      set -x
      while [ 0 = 0 ]; do
        date
        /opt/alluxio-2.4.1/bin/alluxio table sync alluxio_mydatabase
        echo "Syncing AX data ...."
        sleep 900
      done

@gpang @apc999  I solved it by adding one more container to do the sync, Hope this helps some till there a permanent soln
        - name: sync-ax-data
          image: {{ .Values.image }}:{{ .Values.imageTag }}
          imagePullPolicy: {{ .Values.imagePullPolicy }}
          securityContext:
            runAsUser: {{ .Values.user }}
          command:
          - /bin/sh
          - -c
          - /opt/alluxio-2.4.1/scripts/sync_ax_data.sh

apiVersion: v1
kind: ConfigMap
metadata:
  name: extra-script-config
  labels:
    name: extra-script-config
    app: {{ $name }}
    chart: {{ $chart }}
    release: {{ .Release.Name }}
    heritage: {{ .Release.Service }}
data:
  sync_ax_data.sh: |-
      #!/bin/bash
      set -x
      while [ 0 = 0 ]; do
        date
        /opt/alluxio-2.4.1/bin/alluxio table sync alluxio_mydatabase
        echo "Syncing AX data ...."
        sleep 900
      done

Will close it for now, feel free to reopen it and contact us if this is a strong request.


Muting/unmuting ads won't affect video and vice versa

Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?

Not related
What version of Shaka Player are you using?

4.7.3
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Doesn't seem to matter. WIndows, Chrome for example, but seems to be browser independent.
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not related
What are the manifest and license server URIs?

Demo app is good, VMAP ad tags from https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags
What configuration are you using?  What is the output of player.getConfiguration()?

Default
What did you do?

Play video with ads
What did you expect to happen?
When ads/video start muted and I unmute ad/video, I expect video/ad to be unmuted also.
When ads/video start with sound and I mute ad/video, I expect video/ad to be muted also.
What actually happened?

Muting / unmuting applies only to currently playing media. Next elements (video, other ads) are not affected.
For example:

when video starts muted and I have midroll with three ads and I unmute the first ad, other two ads and proceeding video will remain muted.
when I have preroll, starting with sound and I mute the preroll, video will still continue with sound
etc

@Andekas PR to fix it: https://github.com/shaka-project/shaka-player/pull/6073


Generics use last rather than first matching overload

TypeScript Version:  2.7.0-dev.20171124
Code
class Foo {
    bar(): 1;
    bar(): 2;
    bar(): number {
        return 1;
    }
}

interface WithBar<R> {
    bar(): R;
}

function test<R>(a: WithBar<R>): R {
    return a.bar();
}

const foo = new Foo();
const n1 = foo.bar(); // Has type 1
const n2 = test(foo); // Has type 2

Expected behavior:
n1 and n2 have the same type, namely 1.
Actual behavior:
n2 gets the incorrect type 2. It seems that R is taken from the last matching overload, rather than the first.
I don't know if there's some detailed spec doc somewhere that I could use to confirm that this is a bug rather than a weird design, but it's definitely undesirable to me.

The assumption here is that the last signature is more general, and thus leads to better inferences.


letterboxd

Is there a way to change the dynamic link from say tmdb to use a letterboxd link

IDK how well that will work, since Letterboxd database doesn't hold the majority of Television series, so there will be a high percentage of unmatched id numbers.

Implemented in v2.6.0.
Use dynamic:letterboxd. Only works for movies.


NlSocketHandle: do not expect another ack message, if only an ack message is send

fix for #134

I guess the failing clippy pipeline is not from my changes.

@Kloenk Two comments:

The clippy failure is indeed not your fault. Don't worry about that one.
I don't actually return the ACKs but do validation for them in the NlSocketHandle. Your change would cause the ACK to be returned which I don't do anywhere else. I would prefer to pass back an Ok(None) after the ACK validation is done.

Can you tell me a little bit more about why you want the ACK passed back?

Mostly for sequence validation. But I could also work with just Ok(None). Only error ist really annoying

If I put up a PR, can you test it today?

Also just a note that if you ever want to parse the ACK yourself, recv_all() does not processing and just passes back all of the parsed packets in a sequence.

If I put up a PR, can you test it today? I'm looking to get the next release out today.

Yes, I can do that. Should I help somehow?

Just give #138 a try and let me know how that works.

On it, will probably take around an hour, as I have to compile a kernel to test it (This is only because I have a unsigned regdb, and does not change the nl80211 interface)

Not a problem! Let me know once you've verified it. Closing in favor of #138.


Server

Hi,
Thanks for this library. Very nice.
But i have an Question..
I need to start an Server on iOS. As example, in node.js it works like this:
        var rpcServer = rpc.createServer({
                host: "<IP_ADDRESS>",
                port: "8086"
        });
        console.log("Server started");
        sendInit();

       rpcServer.on('NotFound', function (method, params) {
                console.log("Notfound: " + method + " und " + params);
        });

        rpcServer.on('system.multicall', function (method, params, callback) {
Is it posible, to Start an Server on iOS?
If yes, can you say me what to do please?
One more example:
on node.js i send this request:
       rpcClient.methodCall('init', ["http://<IP_ADDRESS>:8086", "server"], function (err, data) {
After this call, i am in an queue for notifications. The other side sends now to this IP Adress xml notifications.
My goal:
1.) On iOS, start an xml Server, to response xml-data from server
2.) On iOS send request to server in local network like this:
       rpcClient.methodCall('init', ["http://<IP_ADDRESS>:8086", "server"], function (err, data) {
3.) the local Server sends now xml-data to <IP_ADDRESS>
In this example, <IP_ADDRESS> is my iPhone! Step 3 already works. My local Server sends xml-data. But my iPhone doesn't understand this ;-)
The iOS Server have to run all time, if App is running. I think AppDelegate.m has to extend.
Sorry for my bad Englisch.
Greetings from Germany.

Hi,
unfortunately this library doesn't provide a server that could be run on iOS.


sample fix

Broken condition fixed

Codecov Report

Merging #79 (188230d) into master (43fba0f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   66.94%   67.05%   +0.10%
==========================================
  Files          41       41
  Lines        2826     2826
==========================================
+ Hits         1892     1895       +3
+ Misses        934      931       -3

Files Changed
Coverage Δ

bamt/nodes/conditional_gaussian_node.py
87.15% <100.00%> (+0.91%)
:arrow_up:

... and 2 files with indirect coverage changes


Now with more Popups!

Popups all inherit from the @boundlessgeo/sdk/components/map/popup
component.
The popup component has a main "wrapper" function renderPopup
that is passed children.  It makes it easier for the sub-classes
to call renderPopup() and pass in the desired contents.
Popups are added using the map's "initialPopups" prop
or "addPopup" method.
Added Demo for the Popups.
Added uuid dependency so as not to depend on counters
for assigning ID's to items.
Added support styles for popups.

This has also been tested working on touch devices.

@wnordmann I think I've addressed everything, please check it out!

Another update that fixes autoPan and gets rid of the slightly awkward "this" referencing that onClick required in the previous version.
As having a Popup class allows us to abstract the implementation of the Popup (IE how it's rendered on the map) from the definition of the Popup (the class)... I still think having the classes is a good way to go about it.


NIFI-5097 add client-side HTTP redirect to error index.jsp

Existing web error index page suggests user may have meant /nifi/ and crafts a contextPath link, may as well redirect them automatically. Non-human (i.e. curl/wget) can still retrieve the original source without being redirected.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[Y] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[Y] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[N] Has your PR been rebased against the latest commit within the target branch (typically master)?

[Y] Is your initial contribution a single, squashed commit?

For code changes:

[N] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[N] Have you written or updated unit tests to verify your changes?
[N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[N/A] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Pretty such that the build was failing before this commit, FWIW.


Bag.roll link dead

http://doc.perl6.org/type/Mixy - in "Similar to a Bag.roll, but with Real weights rather than integral ones." paragraph

Thanks a lot! Fixed.
(For the future, note that doc.perl6.org repo is actually this https://github.com/perl6/doc)


Automatically install Codespaces extension if profile is created while connected to Codespace

When creating a new profile while connected to a Codespace, VS Code should automatically load the Codespaces extension. The current behaviour is that the user is disconnected from their Codespace and even if you install the Codespaces extension, there is no way to reconnect to the Codespace besides closing the remote connection.
https://user-images.githubusercontent.com/686963/199522601-fd13b920-794f-4f7f-824a-f5c21def4b07.mp4

@burkeholland thanks for filling this. We have to fine tune the Codespaces + remote experience for profiles. We already have this item for this https://github.com/microsoft/vscode-internalbacklog/issues/3128
However I think your point is valid and we should keep that in mind when improving the Codespace experience. Thanks

May be if users tries to create/switch profile when in a remote workspace, we shall be including the remote extension by default. But it is tricky because we do not know which remote extension is used for connecting to remote workspace.

Just had a discussion with @sandy081 and we have ideas on how to fix this. We will look into it this milestone most likely.

I assigned to Jan, so we do not lose track of this. @sandy081 hope that is ok.

Please, also support Dev Containers.  For more info see: https://github.com/microsoft/vscode/issues/116740#issuecomment-1352931492

Thanks for the feedback. We are looking into this. And we are thinking about a solution that would cover all remotes (ssh, wsl, containers...)

WSL Support would be really appreciated!

@sandy081 awesome 👏
@burkeholland now you can demo profiles all you want in Codespaces 😊


Trying to run the quick_start code and getting a problem.

Hi there, I am trying to run the code in the quick_start.ipynb file and getting the following error: OSError: [E053] Could not read config file from /usr/local/lib/python3.7/dist-packages/en_core_web_sm/en_core_web_sm-2.2.5/config.cfg
The solution online recommends to downgrade the version for spacy from 3.2.3 to 2.3.5 as a workaround for the above error, however when I try it the function spans in spacy library is not available in a version <3.0.
I would appreciate any insight in resolving this error.
Thank you!

Yes, skweak requires at least Spacy v3. You should upgrade your language model en_core_web_sm to the newest version -- for instance by removing the language model and installing it again.


[ICE] msvc 17.8 (glaze 2.8.1)

Just noticed this so figured I'd share.
See full log here.
See the 15/58 currently failing builds here.
# Visual Studio 17.8 (2022)

C:\tmp\dist\libglaze-2.8.1-a.0.20240612083834.9f44b0adacd6\include\glaze/json/write.hpp(1308): fatal error C1001: Internal compiler error.
(compiler file 'D:\a\_work\1\s\src\vctools\Compiler\CxxFE\sl\p1\c\symbols.c', line 32879)
 To work around this problem, try simplifying or changing the program near the locations listed above.
If possible please provide a repro here: https://developercommunity.visualstudio.com
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information

Try upgrading to the latest MSVC. MSVC has so many ICE issues that I have to work around that I can only guarantee the latest version working. But, I'm continuing to report issues and they are slowly fixing them. MSVC is just fragile with compile time programming.


OrderedListItem number alignment

Markwon version: 4.4.0

When rendering ordered lists, the numbers are always aligned to the right, which is a bit unusual, as most markdown engines display them aligned to the left. To reproduce it render any ordered list that has more than one item. Like this:
1. First
2. Second
3. Third

As far as I see there is no way of supporting that with the theme, but it would be great to have that, probably it would make sense to make it the default behavior.

Hello @BaloghTamas ,
the right alignment comes directly from the HTML as markdown has no special rules for rendering. Instead it relies on how browser would render HTML (which markdown rendered list would be converted to):

hello!

hello!

hello!

hello!

->

hello!
hello!
hello!
hello!

In my opinion right alignment makes more sense and is better in terms of UX. This is why I made it the default in the Markwon. What other markdown engines you are referring to?

Closing for now, feel free to comment to reopen this issue


Any plans to extend tensor type to 16bit-float halfs?

As this would cut down memory requirement for DNN by half allowing larger models to train and also likely increase the training/interference speed.
For a decent half-type implementation one could have a look at OpenEXR image format source.
CuDNN supports 16bit half tensor data structure for a while now and I see that Intel MKL-DNN has added something in that area too.
Alternatively one could make Tensor data structure a generic template type. That would allow even smaller data type or even simple binary,trinary networks in the future, but is probably a lot of work too.
Any thoughts?

I'm not planning on it right now, but it's something I've thought about.  It would require some reworking of the interfaces and is likely a little tricky to do in a way that doesn't cause the interfaces to have usability problems.  Although I'm sure it can be done.


Remove outdated auto-index info in Quickstart

As far I can see in the code. This is no longer correct as there is not such an action during quickstart.
There is no auto-index config option at all, it's automatically "enabled" in ldb add when a path is passed ?

@volkfox Should we remove this for now or add the setting?

I plan to add this option soon, so we can probably leave it in. I'll leave this PR open for now

Closing in favor of https://github.com/iterative/ldb/issues/209


What's the equivalence of tf.contrib.legacy_seq2seq.attention_decoder in tensorflow2?

Describe the feature and the current behavior/state.
I have to get a model that was built with tf1 to run with tf2 but didn't find the equivalence of the function tf.contrib.legacy_seq2seq.attention_decoder in the tf_addons seq2seq API, for example, how do you upgrade this functions in tf2? Is there any function that does the same work as attention_decoder or do I need to write an attention decoder myself?
tf.contrib.legacy_seq2seq.attention_decoder(
        decoder_inputs=decoder_inputs,
        initial_state=initial_state,
        attention_states=self._net,
        cell=cell,
        loop_function=self.get_input)

Which API type would this fall under (layer, metric, optimizer, etc.)
tfa.seq2seq

There is no direct replacement for this function but there are modules that achieve the same thing.

You can extend your RNN cell with an attention mechanism using tfa.seq2seq.AttentionWrapper
You can create a decoder with the RNN cell using tfa.seq2seq.BasicDecoder

There are small examples in these pages which should get you started with these modules.

Thanks for the reply, do you know any examples of implementing that?

Thanks for the reply, do you know any other more detailed examples or docs? I didn't find the Returns in the document.

You can also find an example in the module README which compares implementations with TensorFlow 1 and TensorFlow 2: https://github.com/tensorflow/addons/tree/master/tensorflow_addons/seq2seq#sample-code-and-migration-guide-from-tf-1x

hi @JiashuGuo, I'm dabbling with the same procedure, and I'm unable to get ahead.
Did you have any success? Please share!

hi @JiashuGuo, I'm dabbling with the same procedure, and I'm unable to get ahead.
Did you have any success? Please share!

Hi, it has been quite a while since I worked on this project, as I remember I managed to make the code ran in tf2 based on some workaround I found online, it just didn’t report any error but the model actually didn’t has correct structures as it need in tf2, so the model failed to be trained in the next step. And after that I gave up on this project. So, I would say I hadn’t got any working solution on this problem…Good luck in your digging though!

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


sizes  resolving has bugs

The getWidthFromLength function has two problems

It makes the document invalid by inserting a div as child of the root element.
It doesn't compute the length against the viewport if the root is not position:static and doesn't have the same width as the viewport.

I suggest inserting it in body and use position:fixed instead.

@aFarkas Another one of your fixes that didn't end up getting merged through the PR. Did this make it into 2.3/2.4/3.0?

Yes, this is in 3.0

Is this something we want to add to 2.3/2.4 or just leave it for 3.0?

Closin’ now that we’re doing the beta thing.


Link does not work under Health Services

How customers use Microsoft 365 Enterprise
https://www.microsoft.com/en-au/microsoft-365/blog/2018/07/16/lilly-strives-to-speed-innovation-with-help-from-microsoft-365-enterprise/?ms.o365url=lilly

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 863db1df-d804-e38c-a90c-fae6a0244653
Version Independent ID: 7d9d48a4-27a0-5bfc-a98f-8a94015dbde4
Content: Deploy Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/deploy-microsoft-365-enterprise.md
Service: o365-solutions
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

This resource is not available in your locale (en-au in the URL). I updated the link for the U.S version and should now work for you. Thanks for letting us know.

@TeamTerry - Thanks for your feedback, I'll get this over to the Enterprise writing team for clarification/correction.

@TeamTerry - Ignore above, I see that Joe has already commented. Closing this issue.


ValueError: You are using a deprecated configuration of Chroma.

I am a newbie to Chroma. I am trying it to get to know how a vector db works.
I have created a client and wants to run it.
Following is my code:
import chromadb
from chromadb.config import Settings

client = chromadb.Client(Settings(chroma_db_impl="duckdb+parquet",
                                    persist_directory="db/"))

collection = client.create_collection(name="Students")

student_info = """
Alexandra Thompson, a 19-year-old computer science sophomore with a 3.7 GPA,
is a member of the programming and chess clubs who enjoys pizza, swimming, and hiking
in her free time in hopes of working at a tech company after graduating from the University of Washington.
"""

club_info = """
The university chess club provides an outlet for students to come together and enjoy playing
the classic strategy game of chess. Members of all skill levels are welcome, from beginners learning
the rules to experienced tournament players. The club typically meets a few times per week to play casual games,
participate in tournaments, analyze famous chess matches, and improve members' skills.
"""

university_info = """
The University of Washington, founded in 1861 in Seattle, is a public research university
with over 45,000 students across three campuses in Seattle, Tacoma, and Bothell.
As the flagship institution of the six public universities in Washington state,
UW encompasses over 500 buildings and 20 million square feet of space,
including one of the largest library systems in the world."""

collection.add(
    documents = [student_info, club_info, university_info],
    metadatas = [{"source": "student info"},{"source": "club info"},{'source':'university info'}],
    ids = ["id1", "id2", "id3"]
)

results = collection.query(
    query_texts=["What is the student name?"],
    n_results=2
)`

This is my error:
  File "/home/ali/Test_Plugin/test.py", line 5, in <module>
    client = chromadb.Client(Settings(chroma_db_impl="duckdb+parquet",
  File "/home/ali/.local/lib/python3.10/site-packages/chromadb/__init__.py", line 188, in Client
    return ClientCreator(tenant=tenant, database=database, settings=settings)
  File "/home/ali/.local/lib/python3.10/site-packages/chromadb/api/client.py", line 138, in __init__
    super().__init__(settings=settings)
  File "/home/ali/.local/lib/python3.10/site-packages/chromadb/api/client.py", line 41, in __init__
    SharedSystemClient._create_system_if_not_exists(self._identifier, settings)
  File "/home/ali/.local/lib/python3.10/site-packages/chromadb/api/client.py", line 48, in _create_system_if_not_exists
    new_system = System(settings)
  File "/home/ali/.local/lib/python3.10/site-packages/chromadb/config.py", line 307, in __init__
    if settings[key] is not None:
  File "/home/ali/.local/lib/python3.10/site-packages/chromadb/config.py", line 244, in __getitem__
    raise ValueError(LEGACY_ERROR)
ValueError: You are using a deprecated configuration of Chroma.

If you do not have data you wish to migrate, you only need to change how you construct
your Chroma client. Please see the "New Clients" section of https://docs.trychroma.com/migration.
________________________________________________________________________________________________

If you do have data you wish to migrate, we have a migration tool you can use in order to
migrate your data to the new Chroma architecture.
Please `pip install chroma-migrate` and run `chroma-migrate` to migrate your data and then
change how you construct your Chroma client.

See https://docs.trychroma.com/migration for more information or join our discord at https://discord.gg/8g5FESbj for help!`
I checked the docs but couldn't understand it.```

Can you Change this line
client = chromadb.Client(Settings(chroma_db_impl="duckdb+parquet",
persist_directory="db/"))
To
client = chromadb.PersistentClient(path="db/")
That should fix your error!

It appears to be using SQLite underneath. Is it possible to specify the duckdb+parquet backend?


Task: cleanup new pipeline

There are some outstanding items that need to be tackled on the new pipeline:

Make sure to include the z-scored density values for KDE outputs, not just the percentiles. This will be more useful in ML, as it's continuous, rather than integer values, and also more interpretable for community partners.
For cases where we use parallel processing, make sure the number of workers is set dynamically based on the number of cores on the machine, not just set to what was working on my machine when I wrote the code.
Add data documentation--both a DAG and a data dictionary.
Add a "create date" for the final dataset.
Run ruff formatting and linting and make sure to actually address errors.
Make sure all code in the new pipeline has accurate docstrings and typing.
Figure out a better way to implement data QC.

In data dictionary, add a known_issues column with notes on known data quality/source issues (e.g., missing polygons in pwd_parcels.

Also update the development rank calculation to use the standard KDE function rather than the census bg bins (plus z-score and percentile cuts).

Consider updating guncrime priority to things 2 std above the mean--or will that be uninterpretable?


[OTHER] Add chad to the list of blocked words

What would you like to share?

Add chad to the list of blocked words.

Modify the src/config.ts file and add 'chad' after yessir.

Additional information

Thanks to @Vyvy-vi for providing this image. 🙂

I will do it

Fixed in #632


Fix not to overwrite something unexpectedly

Originally, some plugin helpers (e.g., storage, formatter, parser, ...) defines config_section for sets of parameters by included hook. It calls config_section with plugin class as receivers.
But, if plugin class calls config_section to override default value, that overwrites the section definition defined by plugin helpers.
It makes many unexpected behaviors (including breaking instance variables).
This change is to prevent overwriting section definitions by plugins. By inserting a mixin module, config_section definition in plugin classes overrides definitions in plugin helpers, instead of overwriting it.

@repeatedly Could you review this?

okay. I will review it later.

LGTM 👍


Added basic MDL UI

Here's a first CL that adds a basic UI thanks to Material Design Lite.
I also removed the ability to pick multiple manifests as it makes more sense (code wasn't working btw) and fixed a "tips" bug.
Here are the old/new screenshots:

R=@mounirlamouri

oh snap!, only feedback I would have is no button shadow, and the header needs an elevation shadow
other than that LGTM

I'm merging this because it looks way better. Two comments:

I think it would be good to have a menu to pick between copy/pasting, upload and URL
You dropped the "Fork me on GitHub" ribbon. Is that on purpose?

@samccone The button shadow is there just because the button is focused when I took the screenshot. Regarding the header, I'm not sure what you mean exactly.
@mounirlamouri Indeed I will add a menu when URL feature is implemented.
I did drop the "Fork me on GiHub" ribbon. The "View Source" in the footer was meant to replace it.
For info, https://manifest-validator.appspot.com/ still serves the non MDL UI. Is that normal?


If there is no question mark in question, need to check and add it in

check and add 497a9c3ea4febcd4b5afe600e89f90f65dd67acd


Correct typo in instruction for jspm

This should now be fixed on the es6 and es6-tutorial branches.
Thanks for the PR though!


Gateway Bridge not starting after reboot under Multitech v6.0.0

[x] I have searched the issues of this repository and believe that this is not a duplicate.

What happened?
After updating the mPower Firmware version from 5.3.3 to 6.0.0 the soft reboot via cli of the gateway no longer leads to the start of the Gateway Bridge after boot. When doing a hard shutdown and restart the Gateway Bridge starts like expected.
What did you expect?
The Gateway Bridge starts after soft "reboot" under mPower 6.0.0.
Possible solution
When having a look into the original chirpstack-gateway-bridge.init file of the Gateway Bridge the LSB Header is present:
### BEGIN INIT INFO
# Provides:          chirpstack-gateway-bridge
# Required-Start:    $all
# Required-Stop:     $remote_fs $syslog
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
# Short-Description: ChirpStack Gateway Bridge
### END INIT INFO
The vendor specific one for Multitech Conduit doesn't have the LSB Header.
When adding this header manually and reinitilizing the service, the reboot works like expected.
The Bridge also starts after reboot when adding the LSB Header under mPower 5.3.3.

Component
Version

Gateway Bridge
chirpstack-gateway-bridge_3.14.0-r1_arm926ejste

Multitech Gateway
MTCAP2-868-042A

Multitech Firmware Version
mPower 6.0.0

To take away any assumptions and making it easier to reproduce, could you describe the exact commands / steps for:

"soft reboot via cli" (do yo mean reboot)?
hard shutdown and restart (do you mean using shutdown and then power-cycling the gateway)?

I've been able to reproduce this, but in my case adding the above header did not solve it. What I think is that the ChirpStack Gateway Bridge starts too early (e.g. before network setup).
What I did see is that the mPower firmware provides Monit. I will update the .ipk such that:

Monit will be enabled on CGB .ipk install
CGB process will be monitored by Monit (in case of failure, it will be automatically restarted)


custom-marker tap is not working inside custom marker

I am using ng-map for creating custom map marker. There are few buttons inside custom markers. The ng-click is not working on mobile. It works fine on mobile version from chrome (using developers console) but does not work with actual mobile.

could you solve it?

Hi @tannubansal you solved it?

@juan9118 No I am not able to solve it yet. What I found out is that it works with info-window but not custom-marker. If anyone has any solution for it, please let me know

I was able to "solve" this, using hammerjs, and the hm-tap directive.

Have you tried this solution? Not responsible answer, but I haven't tried it yet.
https://stackoverflow.com/questions/25032237/ng-click-on-firing-on-mobile-or-tablet-devices


Containerizing ui and backend into one docker image

This PR refactors docker files by containerizing ui and backend into one docker image, makes both docker image creation and deployment easier. Using nginx as a reversed proxy to route traffic to correct down streaming ui or backend.
To build one docker image for hosting feathr ui and backend together, run the following commands:
Build docker
docker build -t blrchen/feathr-app .
Run and test locally
docker run --env CONNECTION_STR="Server=tcp:xxxxxxxx.database.windows.net,1433;Initial Catalog=testsql;Persist Security Info=False;User ID=xxxxxxxx;Password=xxxxxxx;MultipleActiveResultSets=False;Encrypt=True;TrustServerCertificate=False;Connection Timeout=30;" --env API_BASE=api/v1 -it --rm -p 3000:80 blrchen/feathr-app
Image has been published to DockerHub feathr-app for pilot, @jainr is trying to figure the path to publish under origination.
Test has been done on sql registry, will test on purview when @YihuiGuo 's new api is ready.
Closes #345

I don't see any UI files in this commit and how they are being hosted in FastAPI static pages?


Only check for conflicts/merging if the PR has not been merged in the interim (#10132)

Backports #10132

@lunny can you move milestone to 1.11.1 pleace


openldap: Properly handle OpenLDAP replication bootstrap

Ideally, this whole thing should go away and simply be inherited from tm-core.
There are some differences still (multi-admin) which will need to be ported before we can get rid of this


[SP-5701] Backport of PDI-18657 Memory leak when customer executes jo…

…bs on the server (Suite 9.0)

fix brittle unit tests

:white_check_mark: Build finished in 6m 57s
Build command:
mvn clean verify -B -e -Daudit -amd -pl \
plugins/json/core,plugins/xml/core

:ok_hand: All tests passed!
Tests run: 156, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


resolve table render

Coverage decreased (-0.2%) to 61.649% when pulling 07dc843f1e6ee628297f128a11c0e0dcca70878b on tianxiaoliang:master into fd97f9f761f72813cd9a723e1ef4fb17a44ba12f on ServiceComb:master.


Adding a patch for CAPT template actions

Description of changes:
Adding a CAPT patch to modify the workflow actions template
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Add module owner with tx and query

Description
Changes

Closes: #?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Freddy Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


PurchasedItem added data and signature specific android fields

@alamboley Thanks for the missing data types.

Thanks, would you mind to upgrade pub version?

@alamboley No problem


[ffmpeg with libsrt and x264 support]

Library name:
ffmpeg
Library description:
ffmpeg supporting x264 and SRT.
Source repository URL:
https://github.com/FFmpeg/FFmpeg.git
Project homepage (if different from the source repository):
Anything else that is useful to know when adding (such as optional features the library may have that should be included):
ffmpeg libraray wihich supports the h264 codec[x264] and the SRT protocoll[libsrt]
While building ffmpeg the flags --enable-libx264 and --enable-protocol='file,udp,rtp,srt'  should be enabled.

PR https://github.com/microsoft/vcpkg/pull/11277 would support this feature.

x264 has been added, however, it's broken on windows, the libsrt is still unavailable.

I'd like to add support for libsrt (and other dependencies) myself. How should I go about doing it? The problem is: I have only a very (very) rough idea of how vcpkg works internally and how FFmpeg build work. Documentation is scattered and/or massive (should I learn all of CMake?).
I tried some naïve blind copypasting to add libsrt, but build failed. :-)
Where/how should I start looking? (Docs, guides, examples, etc.)  Many thanks!

@hpablo, you can reference the following docs to get started:
installing-and-using-packages.md
packaging-github-repos.md
patching.md
control-files.md
maintainer-guide.md

FTR there is also a libsrt port now. But it is not used by ffmpeg.

Has anyone gotten this to work by any chance?

ffmpeg uses libsrt now when using ffmpeg[srt] (or ffmpeg[all] or ffmpeg[all-gpl] to also get x264)

@Sibras , thanks! Has this recently been added, or should it always have worked?

It was added last September in 26679

Thank you!

This should be closed, #26679.

This should be closed, #26679.

@PhoebeHui @Cheney-W


[MarcTK] Convenience API for grabbing multiple related fields from a record?

  For example, you can pass in an array or range of tags and get the matching fields back.  For example, record.each_by_tag( 600..699 ) will give you all of the 6XX fields.
See https://github.com/ruby-marc/ruby-marc/blob/c7604d0878169846c4e1dd66e460a58c1053be97/lib/marc/record.rb#L88-L91
Traject and SolrMarc have some nice strings you can pass in to specify which subfields you want to extract into a string or array.  For example, Traject::MarcExtractor('600|*0|vx:610|*0|vx:611|*0|vx').extract(record) will give you an array of values from 600vx, 610vx, and 611vx where the second indicator is 0.
See https://github.com/traject/traject/blob/5d720e2ba0a277cf7af455763f520cd6a2d956c7/lib/traject/marc_extractor.rb#L11-L14
Both of those save the user from needing to filter through the list of fields, which can be nice.  Would something like those fit into this toolkit?  And if so, what API makes the most sense?

I think they'd be great additions.
I like the "extract" and "each" terminology.  Are you thinking Iterators or Arrays for return types?  ("Each" seems to imply an iterator).  Iterators are probably the more correct approach, but they can also be Iterate-ified later if needed.  (I should probably Iterate-ify get_fields(), etc. as well).
Maybe:
each_field(a..b) -> Iterator<&Field>
each_control_field(a..b) -> Iterator<&ControlField>
extract(query) -> Iterator<&str>
I have a few simple iterators in EgValue for ref it that helps:
https://github.com/kcls/evergreen-universe-rs/blob/main/evergreen/src/value.rs#L1110
https://github.com/kcls/evergreen-universe-rs/blob/main/evergreen/src/value.rs#L1238
BTW, for the extract API, is the '600|*0|vx:610|0|vx:611|0|vx'-style expression a well established query format?  I find it a bit confusing with the pipes "|" separating the tag, indicator, subfield instead of the query parts as a whole (a la XPATH).  I might have gone with '6000vx|6100vx|...' instead.   If it's a thing people use, though, or changing it would cause confusion, I'm cool with it.
Thanks!

Maybe scratch/downgrade my comments re: Iterators.  Now I'm questioning my assumptions about whether they always make sense.
If an API returns a Vec<&Field> (or &Vec), which will have its own iterators, I'm not quite seeing the value of implementing custom iterators atop that.


[SPARK-25010][SQL] Rand/Randn should produce different values for each execution in streaming query

What changes were proposed in this pull request?
Like Uuid in SPARK-24896, Rand and Randn expressions now produce the same results for each execution in streaming query. It doesn't make too much sense for streaming queries. We should make them produce different results as Uuid.
In this change, similar to Uuid, we assign new random seeds to Rand/Randn when returning optimized plan from IncrementalExecution.
Note: Different to Uuid, Rand/Randn can be created with initial seed. Because we replace this initial seed at IncrementalExecution, it doesn't use the initial seed anymore. For now it seems to me not a big issue for streaming query. But need to confirm with others. cc @zsxwing @cloud-fan
How was this patch tested?
Added test.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1715/
Test PASSed.

Test build #94078 has started for PR 21980 at commit 1e0370e.

Test build #94078 has finished for PR 21980 at commit 1e0370e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94078/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1788/
Test PASSed.

Test build #94194 has started for PR 21980 at commit 39db5aa.

Test build #94194 has finished for PR 21980 at commit 39db5aa.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Uuid(randomSeed: Option[Long] = None) extends LeafExpression with Stateful
trait ExpressionWithRandomSeed
case class Rand(child: Expression) extends RDG with ExpressionWithRandomSeed
case class Randn(child: Expression) extends RDG with ExpressionWithRandomSeed

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94194/
Test FAILed.

retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1804/
Test PASSed.

Test build #94215 has started for PR 21980 at commit 39db5aa.

Test build #94313 has started for PR 21980 at commit 4afd548.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1869/
Test PASSed.

Test build #94313 has finished for PR 21980 at commit 4afd548.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1881/
Test PASSed.

Merged build finished. Test PASSed.

Test build #94331 has started for PR 21980 at commit f60a238.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1882/
Test PASSed.

Test build #94332 has started for PR 21980 at commit d4d8d0f.

Test build #94331 has finished for PR 21980 at commit f60a238.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94331/
Test PASSed.

Test build #94332 has finished for PR 21980 at commit d4d8d0f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94332/
Test PASSed.

thanks, merging to master!

LGTM2

LGTM3 😃


fix: fix tx insert to co_queue

Which docs this PR relation:

if no check_limit, should make sure tx inserted into co_queue
reduce real_queue repeated lock acquisition

Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
CI Switch
ci-runs-only: [Chaos CI, Cargo Clippy, Coverage Test, E2E Tests, Code Format, Unit Tests]

Codecov Report

Merging #350 (33bb577) into main (8fef63d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   35.98%   36.01%   +0.02%
==========================================
  Files         119      119
  Lines        8228     8230       +2
==========================================
+ Hits         2961     2964       +3
+ Misses       5267     5266       -1

Impacted Files
Coverage Δ

core/mempool/src/pool.rs
86.30% <100.00%> (+2.27%)
:arrow_up:

core/mempool/src/tests/mempool.rs
100.00% <100.00%> (ø)

core/mempool/src/tx_wrapper.rs
87.50% <0.00%> (-1.79%)
:arrow_down:

core/mempool/src/lib.rs
64.70% <0.00%> (-0.66%)
:arrow_down:


VIDEO section bug fix*

[ ] In Video section 1 video is not playing . Delete that particular video
[ ] Add some more videos in the video section
Put a screen-shot of your work and then do PR

@Soumyajit2825 can i work on this issue

Yes

@Anant2961 u can work on this also

Sure i will

Assign this bug to me as i have Resolved it

Yeah do PR now

done it


stratified performance quantification

Adding functionality similar to hap.py to calculate stratified performance metrics.

@ACEnglish I addressed your comments, cleaned up the code a little bit, and added test files to the rep_utils. I know it still needs more work. Can you take a look and let me know what you think. Thanks! Nate


Sorry @Daviex for the long delay for this. As always for first-time contributor, I want to thank for your time and effort. Keep committing, pushing and unleashing yourself.


ETC Emerald Wallet syncing very slow.

Its been 2 days and my ETC Emerald Wallet is still not updated.  I transferred some ETC from Bittrex which is still not showing in the wallet but shows transfer complete in Bittrex. Please help with some step as to how I can I speed up the Sync Process and show my ETC?

If you use a local node please wait until full chain is synchronized. Current block height is 5497117, and it usually take more than a week to synchronize to that point on a modern hardware

That's where it is now. Will my transfer be part of Hard Fork and the airdrop?

You're good. On which block do you have that transaction? Also make sure it's not marked as FAILED.

Block Height
5489249
Block Hash
0x9f6e18be2ecf97cf4f48ff02ae49ab914316e21a8d3708f658e79359a657dc16

so you have exactly same address as displayed on gastracker, you see balance on gastracker but nothing in emerald?

Yes balance on Gas....Zero in wallet

That's interesting. First of all, as Gastracker displays it, you got your transfer. It's strange you don't see in the wallet. Did you try to restart it?

Yep did several times.

@splix : Any help with this loss txn will be of great help

Woohoo!! I see my coin now!!

We didn't do anything yet, it was a strange glitch. We'll take a look at it though.
If it will happen next time, as I workaround I'd suggest to switch to a remote node (epool or gastracker, top right corner)

Thanks @Splix will try the workaround in case I face the same issue. Appreciate your help. You guys are doing a wonderful job.


Error GraphQL subscriptions

Intended outcome:
The GraphQL subscriptions work correctly.
Actual outcome:
I'm getting an error when I try to create a GraphQL subscription on Angular with the latest versions.
ERROR TypeError: Object(...) is not a function at ApolloBase.subscribe (webpack-internal:///./node_modules/apollo-angular/Apollo.js:54)
How to reproduce the issue:
I updated all dependencies to latest and have the following code:
const deviceLocationEvent = gql`
    subscription{
        deviceLocationEvent{
            id
            hostname
            groupName
        }
    }
`;

apollo.subscribe({
        query: deviceLocationEvent
}).subscribe(resp => {
   console.log('Subscription ', resp);
});

When I try to subscribe to a GraphQL subscription, I'm getting the error previously mentioned.
The error is also happening with the watchQuery method, here a code example where I was able to represent the same error with watchQuery.  I don´t know why but when the code is executed on Stackblitz the error is different:
https://stackblitz.com/github/javadababadoo/DemoGraphQLTest
https://github.com/javadababadoo/DemoGraphQLTest
using:
"apollo-angular": "1.1.1",
"apollo-angular-link-http": "1.1.0",
"apollo-cache-inmemory": "1.2.4",
"apollo-client": "2.3.4",
"apollo-link-context": "1.0.8",
"apollo-link-http": "1.5.4",
"apollo-link-ws": "1.0.8"

I guess it's related to #651, I'll check it after this weekend.


freehlded-bootstrap.sh: rewise build error

this is on Arch...
$ ./freehlded-bootstrap.sh
Cloning into 'REWise'...
remote: Enumerating objects: 44, done.
remote: Counting objects: 100% (44/44), done.
remote: Compressing objects: 100% (43/43), done.
remote: Total 44 (delta 20), reused 0 (delta 0), pack-reused 0
Receiving objects: 100% (44/44), 49.22 KiB | 462.00 KiB/s, done.
Resolving deltas: 100% (20/20), done.
mv: cannot stat 'rewise': No such file or directory

Wiggled it a bit and made the command check a bit more explicit.


Adding csr instruction support in riscv-ctg to create coverpoints for riscof

Dear All,
I have been trying to add csr instruction support in riscv-ctg by following these instructions. I have made the following updates in riscv-ctg:

Added csr registers in cgf.yaml datasets to add a few csr and pmp registers.
Added a new instruction node for csr instruction "csrw" in cgf.yaml according to the following template
Update template.yaml to add csr registers in metadata and added csrw node)
Added a new function in arch_test.h) to add support for csrw instruction.
Updated rv32i_priv.cgf to create nodes for new tests to verify the csrw.

Although I have followed all instructions given in RISC-V ISA Coverage Documentation but my riscof command is still not working. After running the command
$  riscof coverage --config=config.ini --cgf-file $PATH_TO_RISCV_CTG/sample_cgfs/dataset.cgf --cgf-file PATH_TO_RISCV_CTG/sample_cgfs/rv32i_priv.cgf --suite=PATH_TO_RISCV_ARCH_TESTS/riscv-test-suite/rv32i_m/privilege/ --env=PATH_TO_RISCV_ARCH_TESTS/riscv-test-suite/env/
My terminal gets stuck at line "RUNNING TESTS ON REFERENCE" without giving any error.
The tests are correct and have been verified by riscof with dummy nodes in rv32i_priv.cgf. Can someone please help in rectifying any mistake here?

The op you're testing  has the form
csrw csrdest, rs1
One problem is that  the SIGUPD macro has the form
SIGUPD basereg, xregdest, offset
but you're using a csrdest instead of an xregdest.
It isn't clear to me if the intent is perform a write, then read back to see if the write was correctly written (or if the WARL field was transformed correctly). SIGUPD won't do that. Just as SIGUPD_F was created to save an FREG, you'll either need

a new SIGUPD_CSR macro that does an explicit csrr savexreg, csrdest followed by store that saves that savexreg, or
you'll need to add that csrr to your TEST_CSRW code, along with adding the savexreg as a parameter.

@allenjbaum that was exactly my logic to perform a write, then read it back to see if the write was consistent or not. I got your point, I made a mistake while calling SIGUPD with csr register. I have made the updates and added a csrr line in TEST_CSRW code. Thanks for pointing the error Sir.


LEGO: Pull request from lego/hb_2939_20201112110606718 to master

LEGO: Pull request from lego/hb_2939_20201112110606718 to master with localized lcls

#8012 will contain these changes


Add missing create option for visual shader

The New Visual Shader option was missing from the shader create option menu.

I don't see a point either...

Sorry, my bad. I was comparing the UI to the 3.x branch. I totally missed the shader option in the new window.


ref #668: Update phpunit to be PHP8 compatible

Q
A

Branch
master

Bug fix?
no

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed issues
chameleon-system/chameleon-system#668

License
MIT

In an effort to update core components to PHP8 this updates phpunit to 8.x. This makes the tests runnable in PHP8 but drops support for running tests in PHP7.1.

Note: Seems like travis tries to run tests with PHP7.1.


Adding abbreviation annotations to all synonyms which are abbreviations

As there are more than 3K of these, I took a simplifying assumption:
This is the search string:
^(synonym: "[A-Z]+["][0-9: a-zA-Z\[\],/\.-_\-]*)$

This is is the replace string for Atom:
$1 {synonymtypedef="ABBREVIATION"}

@matentzn I can't view this diff. When I'm back from TG, can you show me an (easier) way of looking at this? Thanks!

GitHub desktop! Just go to the branch and click on the last commit in the history.

Ugh, @matentzn this isn't done correctly, I tried to fix one example and it created a ton of conflicts. I reverted my commit, but there are still conflicts.
So this isn't done correctly - it should look like this
synonym: "ALS" EXACT ABBREVIATION [DOID:332, NCIT:C34373, Orphanet:803]

No problem will fix soon

I will make a new one


Implement ranged queries for collections via GQL

For lists/sets/maps:
elements(at:) => returns single element
elements(at:, count:) => returns [at, at + count)
For sets/maps
elements(key:) => returns single element
elements(key:, count:) => returns count elements starting at key
elements(key:, through:) => returns elements [key, through]

I'm also adding keys, which only works on maps but allows you to pass in multiple keys.


Rollback new signing mechanism

Summary
Rollback new signing mechanism
Problem Definition
#258 's feature has  the potential for a DDoS attack. If there is no gas fee for the chain, an attacker can generate a lot of traffic by generating a lot of keys and sending tx.
Even if there is a gas fee, a tx sender need to receive coins from someone because sender need to have a certain amount of coins to pay for gas fee. At this time, since accountNumber is created in the existing system, there is no case where tx can be transmitted without accountNumber. So there is no need for a new signature mechanism using the existing sig_block_height.
Proposal
Rollback #258 issue (fixed by #265 )

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

We need to revert #293 by fixed #344.


Deprecate make-based building of documentation

Documentation can now be generated python setup.py build_sphinx. To generate different types of output one merely needs to write python setup.py build_sphinx -b <format>; where, format is the intended output type. This strategy reproduces pretty much anything except for the multistage latex outputs. To handle the latex to pdf case, a pdf command line argument is allowed for the format. This results in the latex being generated and then the pdf generated by pdflatex (if available). Even support for cleaning documentation artifacts has been provided. Ultimately, these changes should be refined to builders an the like for PRs to Sphinx.
TL;DR The Makefile and make.bat have become redundant as python setup.py build_sphinx has full functionality and is OS independent. Maintaining these two copies of the documentation build for two OSes allows for divergence and as such is prone to error. We would like to remove them and use setup.py directly.

Info about this method has been removed from the documentation, but the strategy still remains at present.

As this has basically been deprecated, this will be closed.