@nonull could have surprising effects in error cases

When a nullable field is marked @nonnull locally, it of course can still be returned as null by the backend. In particular this can happen in case of partial errors.
When that happens, a JsonDataException will be thrown at JSON reading time, in the Adapter's fromJson method.
If we consider that this will probably happen in typical uses, this may be considered surprising to users.

Maybe it's only a matter of adding a warning in the documentation.
Or we could investigate a way to throw something less "low level" and more descriptive

Linking https://github.com/apollographql/apollo-kotlin/issues/2520 as it seems to be the same request.
Implementation wise, we could have a FailSafeAdapter(wrappedAdapter) that wraps another Adapter and catches errors to propagate them up the tree to the next nullable field. From that other issue, looks like error handling will be the difficult thing but certainly sounds doable.

This is addressed with https://github.com/apollographql/apollo-kotlin/pull/5405
Using @nullOnlyOnError is explicit that the errors may throw and must be handled with @catch if needed


Add Installation Instructions

This is basic stuff.
We need to add a description about how in gods name people install and use the software as well as what the prerequisites are.

I've linked to them from main README


For which OS version is this?

Nice attempt. For which OS version is this? Not working on Big Sur

Big Sur and Catalina have changed more services and daemons than previous versions. Also there is the fact that Big Sur and Catalina do not use the bash shell in which this is coded in. They use the ZSH shell. It is pretty much a whole new coding language but I will make a version for Big Sur and Catalina.
I do know that Mojave and backwards do work, as I have multiple iMacs both new and old.

So no, it WILL NOT work in macOS Big Sur or Catalina.

Oh and one more thing. You need something called System Integrity Protection turned off, which renders this script useless if its on, and it is on by default. So if you don't know what it is then its probably on.


QT Creator compile issue

Required Info

Camera Model
R200, F200 or SR300

Firmware Version

Operating System & Version
Ubuntu

Kernel Version (Linux Only)
16.04

Build System
VS2013, XCode or Makefile

All, I grabbed the latest master this morning. Loaded up the QT project in QT.  When trying to build the solution, the build is running but I'm getting non stop warnings that state :
file '../librealsense.qtcreateor/all.pro' has modification time 40168 s in the future.
This error is being duplicated over and over. In fact over 17,000 times now and there is no end in sight of the build process ending.

In general this error occurs when you copy make file from computers with clocks that do not agree. In context of QT, I would recommend to right-click on the project and run qmake.

Ah.. ok
From: dorodnic<EMAIL_ADDRESS>Sent: Wednesday, September 7, 2016 11:07 AM
To: IntelRealSense/librealsense<EMAIL_ADDRESS>Cc: Rick<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [IntelRealSense/librealsense] QT Creator compile issue (#275)
In general this error occurs when you copy make file from computers with clocks that do not agree. In context of QT, I would recommend to right-click on the project and run qmake.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/IntelRealSense/librealsense/issues/275#issuecomment-245367694 , or mute the thread https://github.com/notifications/unsubscribe-auth/AF63RnGHd-hUsJ3YSlScMMSUpRMYZB0rks5qnv1MgaJpZM4J3MEr .  https://github.com/notifications/beacon/AF63RiD90nY5ClL1s9rKyE2klaHVmdtdks5qnv1MgaJpZM4J3MEr.gif


Simple use of this library! not really as simple as the 0.9.3

At code.runnable.com with old version 0.9.3 typeahead was easily implemented in a few lines of code.
http://code.runnable.com/UlXgeluakNULAAAv/create-an-autocomplete-input-box-with-typeahead-js-for-jquery-and-javascript
  <script type="text/javascript">
    // Waiting for the DOM ready...
    $(function(){
      // applied typeahead to the text input box
      $('#my-input').typeahead({
        name: 'countries',
        // data source
        prefetch: 'data/countries.json',
        // max item numbers list in the dropdown
        limit: 10
      });
    });
  </script>

But the latest version requires more code and effort using Bloodhound...
line 1->17 https://github.com/zenithtekla/typeahead/blob/8ff27225f8d047e47e4aa657b7b9a8fe0ed7c63e/experiment/async.js
// Instantiate the Bloodhound suggestion engine
var local = new Bloodhound({
    datumTokenizer: Bloodhound.tokenizers.obj.whitespace('name'),
    queryTokenizer: Bloodhound.tokenizers.whitespace,
    prefetch: {
        url: 'json/countries.json'
    }
}); // filter can be omitted, prefetch must use external url

// Initialize the Bloodhound suggestion engine
local.initialize();

// Instantiate the Typeahead UI
$('#async .typeahead').typeahead(null, {
    displayKey: 'name',
    source: local.ttAdapter()
});

Now tell me why it does have to be this complicated in the latter version? Is it so advanced that it can no longer take the form of simplest implementation?

+1 !

Grabbed old cold(from a linked runnable) and tried changing Typeahead library versions (from 0.9.3 to whatever the latest is) in the header. You will see the old form of simple implementation does not work.


Index Page has broken links

This issue is related to #8
Once the theme URLs will include also the links to the UI KIt Sections, the index should be updated accordingly.
After #8 is solved, the inner links on index should point to the corresponding UI KIT pages.
*** Sample Broken Link

*** App Runtime Error

Validated. Closing!
Ty @MySecondLanguage


升级到5.1.0 SqlServer 使用WITH (NOLOCK)破坏了原有的表名(多了空格)

SELECT
	count(0)
FROM
	(
		SELECT
			INFO.ID AS id,
			INFO.ORDER_ID AS orderId,
			INFO.STORE_CODE AS storeCode,
			INFO.BUSINESS_DAY AS businessDay,
			INFO.ORDER_TYPE AS orderType,
			INFO.[ ORDER ] AS [ ORDER ], RESULT.ORDER_RESULT_CODE AS orderResultCode,
			RESULT.ORDER_RESULT_MSG AS orderResultMsg
		FROM
			OC_ORDER_REISSUE_ORDER REISSU E WITH (NOLOCK)
		LEFT JOIN OC_ORDER_INFO INFO ON REISSUE.ORDER_ID = INFO.ORDER_ID
		AND REISSUE.ORDER_TYPE = INFO.ORDER_TYPE
		LEFT JOIN (
			SELECT
				A.ORDER_ID,
				A.ORDER_TYPE,
				A.ORDER_RESULT_CODE,
				A.ORDER_RESULT_MSG
			FROM
				OC_ORDER_RESULT A WITH (NOLOCK)
			WHERE
				NOT EXISTS (
					SELECT
						1
					FROM
						OC_ORDER_RESUL T WITH (NOLOCK)
					WHERE
						ORDER_ID = A.ORDER_ID
					AND ORDER_TYPE = A.ORDER_TYPE
					AND UPDATE_TIME > A.UPDATE_TIME
				)
		) RESULT ON INFO.ORDER_ID = RESULT.ORDER_ID
		AND INFO.ORDER_TYPE = RESULT.ORDER_TYPE
		WHERE
			INFO.STORE_CODE =?
		AND INFO.BUSINESS_DAY =?
		ORDER BY
			id
	) tmp_count

########OC_ORDER_REISSUE_ORDER 表名的别名REISSUE  中间多了空格，sql语法错误
########只要是使用了WITH (NOLOCK)  就会多个空格
FROM OC_ORDER_REISSUE_ORDER REISSU E WITH (NOLOCK)

FROM OC_ORDER_REISSUE_ORDER REISSU E WITH (NOLOCK)
这里原来是什么样子的？

原来是没有空格的
FROM OC_ORDER_REISSUE_ORDER REISSUE WITH (NOLOCK)

先用 simple 能不能解决？

else 里面是不是应该是this.replaceSql = new SimpleWithNolockReplaceSql();

对，错了。

已经发布5.1.1，这两个问题都解决了。


The master branch is not compatible with Python 3.5

The master branch is not compatible with Python 3.5:

marquiz_airflow/log.py
marquiz_airflow/dag.py

In both files you can find f-string. Also marquez_client has the same problem
Package version:
marquez-airflow==0.1.6
marquez-python==0.5.1
Python version:
Python 3.5.2

Thanks for opening this issue, @PacoPacov! I will re-open this issue against the marquez repo, and continue the discussion there.


Add disabled_on to /v3/event responses

Issue number: n/a
Description of change
Adds the disabled_on field to responses in /v3/event and /v3/event/<id>.
Checklist

[x] Have any relevant search models been updated?
[x] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[x] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[x] Has the admin site been updated (for new models, fields etc.)?
[x] Has the README been updated (if needed)?

Codecov Report

Merging #1024 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1024   +/-   ##
========================================
  Coverage    96.45%   96.45%
========================================
  Files          207      207
  Lines         5813     5813
  Branches       555      555
========================================
  Hits          5607     5607
  Misses         142      142
  Partials        64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694a69d...72b97f3. Read the comment docs.


Realtime Values Ignition 7.9

Add in support for realtime values in Ignition 7.9

Although you probably want to look at the most recent version of the Ignition-8 branch you can use 367cbc647d848d8fad1f6604cf6bf5d74e7236f9 as a reference for the bulk of the changes that need to be made.  There are some commits that touch these lines later on it the commit history.

And I have not looked at the API differences but so I have not evaluated if it is even be possible to support this functionality.


netboot: added support for retryable HTTP failures

Fixes https://github.com/systemboot/systemboot/issues/94
CC @gepoggio

Codecov Report

Merging #99 into master will decrease coverage by 0.38%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   44.61%   44.23%   -0.39%
==========================================
  Files          12       12
  Lines         464      468       +4
==========================================
  Hits          207      207
- Misses        232      236       +4
  Partials       25       25

Impacted Files
Coverage Δ

pkg/booter/netbooter.go
50% <0%> (-10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e30c4...94e08ca. Read the comment docs.


Not working when running headless Godot

Just added a map to a multiplayer game I'm developing, and I noticed that the terrain doesn't seem to calculate and set the heightmap for collisions when running the exported game with --headless as a server.
There don't seem to be any errors in the logs when running the server, it's just that the terrain collision seems to be completely flat. Tree/grass collisions seem to be placed on the xz coordinates, just fine, but they are also completely flat on the terrain plane.
When I run the server without --headless, the collisions seem to work perfectly.
Do you know if this is due to there not being a renderer when running as headless. I thought this might have something to do with the issue.
I don't have a minimum reproduction project to hand, but I could make one if that helps. It does require some basic multiplayer setup, but wouldn't take too long to get an MRP up and running. Let me know. I thought I'd just start a conversation on this issue to begin with.

Hello dear Nick
I never test this in --headless mode
But when the heightmap is flat it can have one problem, But I am not sure about that
If Terrain does not find any heightmap data in data directory it will create an empty flat heightmap data by default, It could be that it can not find the heightmap data, so it will create the flat one
Make sure it can find the heightmap data
If you know how to code c++ in the mregion.cpp in line 65
if(heightmap==nullptr){
		String f_name = "heightmap_x"+itos(pos.x)+"_y"+itos(pos.z)+".res";
		String f_path = grid->dataDir.path_join(f_name);

This is where if the heightmap is not founded it will create a flat heightmap data, you can print something in this if statement and if this Runs it means it can not find heightmap data so it create a flat heightmap data by default
If that was not the case, try to create a minimal project I will test that and see what is the problem

Hey @mohsenph69, thanks for that. I added the some debug output in the mregion.cpp file, and discovered that the data was not there. I was using Docker to spin up the servers, but had an issue the amount of files in the terrain_data directory. Found a little workaround for now.
Closing this out, as it turns out the issue is nothing to do with MTerrain.


Adding google_binary_authorization_attestor, google_binary_authorization_policy to v1beta1 version

Description of your changes
Adding 2 resources to v1beta1 version

[x] google_binary_authorization_attestor
[x] google_binary_authorization_policy

Fixes #96
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manual & Uptest:
google_binary_authorization_attestor -
google_binary_authorization_policy -

/test-examples="examples/binaryauthorization/attestor.yaml"

/test-examples="examples/binaryauthorization/policy.yaml"


Partially fixes #566

Adds a preference to show alerts to confirm deletion of feeds (default is true) and this is configurable in Settings / Preferences
Supports single (iOS/macOS) and multiple selection (macOS) for deletion

Known Issues:

Until folders are selectable (future beta, hopefully), selecting them for deletion is disabled.
The macOS sidebar doesn't always refresh after a deletion.

The iOS setting doesn't need its own section.  It can be included with FEEDS and just have the text "Confirm when deleting".


[Add]: "Buy Me Coffee" Section Is Not Proper Visible

Details
GSSOC'23
[Issue Description]: Buy Me Coffee Section is Not Proper Visible

When Click on Buy Me Coffee Icon, then It's not shows Full Image Design Card.

This Problem OR Issue Solve in 2 Ways
Scenario 1:

Remove The Too Much Margin-Bottom OR Margin-Top of This Link given in Bottom of The Coffee Design Card.

Scenario 2:

AddScroll Bar FeatureOn Buy Me Coffee Design Card.

Screenshots
Scenario 1:(SCREENSHOTS)
Screenshot-1

Screenshot-2

Scenario 2:(SCREENSHOT)

Add Scroll Bar Feature On Above Buy Me Coffee Design Card.

Type of Contribution

[ ] Update to an existing Animated Button
[ ] Adding a new Button
[ ] Resolving a bug
[ ] Proposal to the Repository
[ ] Changes related to documentation or README.md
[X] Other Changes

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue
[X] I am a GSSoC'23 contributor

No more UI fixes as of now because I had updated the UI and it will be live on Monday!


Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        Bluetooth Namespace
Provider ID:                        {06AA63E0-7D60-41FF-AFB2-3EE6D2D9392D}
Name Space:                         16
Active:                             1
Version:                            0

Indeed, if the flags weren't 0x2nnnnn, then that is definitely the cause. Trying to find out more about what Lavasoft web companion is - TBH, it looks like pseudo malware from first searches

Yeah i think you might be right. I am installing it again and hopefully it will break docker so we can confirm something. Initially I thought it was just the antiviruse software my company uses, then I checked another laptop I installed Docker for Windows on just now and it doesn't have Web Companion installed so I decided to remove it to see what would happen. Should have tried this a long time ago!

@jhowardmsft
Ok reinstalled Web Companion for testing and docker commands no longer are working just like the original issue on this thread. The output of netsh winsock show catalog is below:
Microsoft Windows [Version 10.0.14393]
(c) 2016 Microsoft Corporation. All rights reserved.

C:\WINDOWS\system32>netsh winsock show catalog

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry
Description:                        LavasoftLSP over [MSAFD Tcpip [TCP/IP]]
Provider ID:                        {1C39A736-9641-4F43-9C20-AEED81692A07}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService64.dll
Catalog Entry ID:                   1032
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x66
Protocol Chain Length:              2
Protocol Chain: 1031 : 1006

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry
Description:                        LavasoftLSP over [MSAFD Tcpip [UDP/IP]]
Provider ID:                        {7D80B943-CB6D-43E8-BEA7-A780CCE0E63A}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService64.dll
Catalog Entry ID:                   1033
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x609
Protocol Chain Length:              2
Protocol Chain: 1031 : 1007

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry
Description:                        LavasoftLSP over [MSAFD Tcpip [TCP/IPv6]]
Provider ID:                        {8F0A3CB9-4356-4A69-B9FB-C7A67C6217BA}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService64.dll
Catalog Entry ID:                   1034
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x66
Protocol Chain Length:              2
Protocol Chain: 1031 : 1009

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry
Description:                        LavasoftLSP over [MSAFD Tcpip [UDP/IPv6]]
Provider ID:                        {0444FC6C-E28D-4B79-BB09-4FDE8528CDFB}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService64.dll
Catalog Entry ID:                   1035
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x609
Protocol Chain Length:              2
Protocol Chain: 1031 : 1010

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        Hyper-V RAW
Provider ID:                        {1234191B-4BF7-4CA7-86E0-DFD7C32B5445}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1001
Version:                            2
Address Family:                     34
Max Address Length:                 36
Min Address Length:                 36
Socket Type:                        1
Protocol:                           1
Service Flags:                      0x20026
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD Tcpip [TCP/IP]
Provider ID:                        {E70F1AA0-AB8B-11CF-8CA3-00805F48A192}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1006
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x20066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD Tcpip [UDP/IP]
Provider ID:                        {E70F1AA0-AB8B-11CF-8CA3-00805F48A192}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1007
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD Tcpip [RAW/IP]
Provider ID:                        {E70F1AA0-AB8B-11CF-8CA3-00805F48A192}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1008
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        3
Protocol:                           0
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD Tcpip [TCP/IPv6]
Provider ID:                        {F9EAB0C0-26D4-11D0-BBBF-00AA006C34E4}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1009
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x20066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD Tcpip [UDP/IPv6]
Provider ID:                        {F9EAB0C0-26D4-11D0-BBBF-00AA006C34E4}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1010
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD Tcpip [RAW/IPv6]
Provider ID:                        {F9EAB0C0-26D4-11D0-BBBF-00AA006C34E4}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1011
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        3
Protocol:                           0
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        RSVP TCPv6 Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1002
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x22066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        RSVP TCP Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1003
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x22066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        RSVP UDPv6 Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1004
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x22609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        RSVP UDP Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1005
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x22609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD Irda [IrDA]
Provider ID:                        {3972523D-2AF1-11D1-B655-00805F3642CC}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1012
Version:                            2
Address Family:                     26
Max Address Length:                 32
Min Address Length:                 8
Socket Type:                        1
Protocol:                           1
Service Flags:                      0x20006
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider
Description:                        MSAFD RfComm [Bluetooth]
Provider ID:                        {9FC48064-7298-43E4-B7BD-181F2089792A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1013
Version:                            2
Address Family:                     32
Max Address Length:                 30
Min Address Length:                 30
Socket Type:                        1
Protocol:                           3
Service Flags:                      0x20026
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Service Provider
Description:                        LavasoftLSP
Provider ID:                        {2B611370-2190-4059-9AF8-5BC0F58FB742}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService64.dll
Catalog Entry ID:                   1031
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        0
Protocol:                           0
Service Flags:                      0x66
Protocol Chain Length:              0

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry (32)
Description:                        LavasoftLSP over [MSAFD Tcpip [TCP/IP]]
Provider ID:                        {D719DC48-514F-4997-8A3D-0A6142E03579}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService.dll
Catalog Entry ID:                   1027
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x66
Protocol Chain Length:              2
Protocol Chain: 1026 : 1006

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry (32)
Description:                        LavasoftLSP over [MSAFD Tcpip [UDP/IP]]
Provider ID:                        {BAEAE07A-3A73-4F62-B82A-234337478B78}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService.dll
Catalog Entry ID:                   1028
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x609
Protocol Chain Length:              2
Protocol Chain: 1026 : 1007

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry (32)
Description:                        LavasoftLSP over [MSAFD Tcpip [TCP/IPv6]]
Provider ID:                        {2F0AD0D2-1CF6-4F68-BD46-F24C9DB412E1}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService.dll
Catalog Entry ID:                   1029
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x66
Protocol Chain Length:              2
Protocol Chain: 1026 : 1009

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Chain Entry (32)
Description:                        LavasoftLSP over [MSAFD Tcpip [UDP/IPv6]]
Provider ID:                        {AE0B1D40-9102-4B4E-8B85-FE1FB7B93B7C}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService.dll
Catalog Entry ID:                   1030
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x609
Protocol Chain Length:              2
Protocol Chain: 1026 : 1010

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        Hyper-V RAW
Provider ID:                        {1234191B-4BF7-4CA7-86E0-DFD7C32B5445}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1001
Version:                            2
Address Family:                     34
Max Address Length:                 36
Min Address Length:                 36
Socket Type:                        1
Protocol:                           1
Service Flags:                      0x20026
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD Tcpip [TCP/IP]
Provider ID:                        {E70F1AA0-AB8B-11CF-8CA3-00805F48A192}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1006
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x20066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD Tcpip [UDP/IP]
Provider ID:                        {E70F1AA0-AB8B-11CF-8CA3-00805F48A192}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1007
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD Tcpip [RAW/IP]
Provider ID:                        {E70F1AA0-AB8B-11CF-8CA3-00805F48A192}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1008
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        3
Protocol:                           0
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD Tcpip [TCP/IPv6]
Provider ID:                        {F9EAB0C0-26D4-11D0-BBBF-00AA006C34E4}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1009
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x20066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD Tcpip [UDP/IPv6]
Provider ID:                        {F9EAB0C0-26D4-11D0-BBBF-00AA006C34E4}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1010
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD Tcpip [RAW/IPv6]
Provider ID:                        {F9EAB0C0-26D4-11D0-BBBF-00AA006C34E4}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1011
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        3
Protocol:                           0
Service Flags:                      0x20609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        RSVP TCPv6 Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1002
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x22066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        RSVP TCP Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1003
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        1
Protocol:                           6
Service Flags:                      0x22066
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        RSVP UDPv6 Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1004
Version:                            2
Address Family:                     23
Max Address Length:                 28
Min Address Length:                 28
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x22609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        RSVP UDP Service Provider
Provider ID:                        {9D60A9E0-337A-11D0-BD88-0000C082E69A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1005
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        2
Protocol:                           17
Service Flags:                      0x22609
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD Irda [IrDA]
Provider ID:                        {3972523D-2AF1-11D1-B655-00805F3642CC}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1012
Version:                            2
Address Family:                     26
Max Address Length:                 32
Min Address Length:                 8
Socket Type:                        1
Protocol:                           1
Service Flags:                      0x20006
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Base Service Provider (32)
Description:                        MSAFD RfComm [Bluetooth]
Provider ID:                        {9FC48064-7298-43E4-B7BD-181F2089792A}
Provider Path:                      %SystemRoot%\system32\mswsock.dll
Catalog Entry ID:                   1013
Version:                            2
Address Family:                     32
Max Address Length:                 30
Min Address Length:                 30
Socket Type:                        1
Protocol:                           3
Service Flags:                      0x20026
Protocol Chain Length:              1

Winsock Catalog Provider Entry
------------------------------------------------------
Entry Type:                         Layered Service Provider (32)
Description:                        LavasoftLSP
Provider ID:                        {2B611370-2190-4059-9AF8-5BC0F58FB742}
Provider Path:                      C:\WINDOWS\system32\LavasoftTcpService.dll
Catalog Entry ID:                   1026
Version:                            2
Address Family:                     2
Max Address Length:                 16
Min Address Length:                 16
Socket Type:                        0
Protocol:                           0
Service Flags:                      0x66
Protocol Chain Length:              0

Name Space Provider Entry
------------------------------------------------------
Description:                        E-mail Naming Shim Provider
Provider ID:                        {964ACBA2-B2BC-40EB-8C6A-A6DB40161CAE}
Name Space:                         37
Active:                             1
Version:                            0

Name Space Provider Entry
------------------------------------------------------
Description:                        PNRP Cloud Namespace Provider
Provider ID:                        {03FE89CE-766D-4976-B9C1-BB9BC42C7B4D}
Name Space:                         39
Active:                             1
Version:                            0

Name Space Provider Entry
------------------------------------------------------
Description:                        PNRP Name Namespace Provider
Provider ID:                        {03FE89CD-766D-4976-B9C1-BB9BC42C7B4D}
Name Space:                         38
Active:                             1
Version:                            0

Name Space Provider Entry
------------------------------------------------------
Description:                        Network Location Awareness Legacy (NLAv1) Namespace
Provider ID:                        {6642243A-3BA8-4AA6-BAA5-2E0BD71FDD83}
Name Space:                         15
Active:                             1
Version:                            0

Name Space Provider Entry
------------------------------------------------------
Description:                        Tcpip
Provider ID:                        {22059D40-7E9E-11CF-AE5A-00AA00A7112B}
Name Space:                         12
Active:                             1
Version:                            0

Name Space Provider Entry
------------------------------------------------------
Description:                        NTDS
Provider ID:                        {3B2637EE-E580-11CF-A555-00C04FD8D4AC}
Name Space:                         32
Active:                             1
Version:                            0

Name Space Provider Entry
------------------------------------------------------
Description:                        Bluetooth Namespace
Provider ID:                        {06AA63E0-7D60-41FF-AFB2-3EE6D2D9392D}
Name Space:                         16
Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        E-mail Naming Shim Provider
Provider ID:                        {964ACBA2-B2BC-40EB-8C6A-A6DB40161CAE}
Name Space:                         37
Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        PNRP Cloud Namespace Provider
Provider ID:                        {03FE89CE-766D-4976-B9C1-BB9BC42C7B4D}
Name Space:                         39
Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        PNRP Name Namespace Provider
Provider ID:                        {03FE89CD-766D-4976-B9C1-BB9BC42C7B4D}
Name Space:                         38
Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        Network Location Awareness Legacy (NLAv1) Namespace
Provider ID:                        {6642243A-3BA8-4AA6-BAA5-2E0BD71FDD83}
Name Space:                         15
Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        Tcpip
Provider ID:                        {22059D40-7E9E-11CF-AE5A-00AA00A7112B}
Name Space:                         12
Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        NTDS
Provider ID:                        {3B2637EE-E580-11CF-A555-00C04FD8D4AC}
Name Space:                         32
Active:                             1
Version:                            0

Name Space Provider Entry (32)
------------------------------------------------------
Description:                        Bluetooth Namespace
Provider ID:                        {06AA63E0-7D60-41FF-AFB2-3EE6D2D9392D}
Name Space:                         16
Active:                             1
Version:                            0

OK, that confirms it. Thanks for your patience and assisting root causing this. TBH, I'm not sure whether to "fix" docker by looking to see if there is a non-IFS BSP or LSP installed and skip FILE_SKIP_COMPLETION_PORT_ON_SUCCESS, or not. Looking at https://en.wikipedia.org/wiki/Lavasoft, it sounds like alerting people to malware by failing might be a better solution... 😇

@jhowardmsft Since LSPs are deprecated in Windows, it may be better to disable their functionality in docker/dockerd. This can be done by disabling all extension points when the processes start: SetProcessMitigationPolicy, ProcessExtensionPointDisablePolicy flag.

Neat, thanks @jstarks

Great work, Thanks!

OMG, just found out that WebCompanion was installed on my PC, too. Deleted it - and now Docker seems to be working fine.

Thanks for working this out.
@jhowardmsft @jstarks if you make a PR for docker to disable the extension points could you cc me so we can also make the changes to the the proxy? thanks

In the meantime I had taken the nuclear option and re-imaged because we could at that stage and I wanted to rule in or out the VPN client. But I do remember that Lavasoft had accidentally been installed on the initial install.
It's not installed now and everything is working bar one exception, possibly unrelated to this particular issue. Upon reboot I still do get the error that Docker is unavailable similar to @mcking49 and indeed the service is not running. Changing the service to be Automatic but delayed resolves this.
-paul

Indeed, uninstalling WebCompanion fixed Docker for me as well.

I had the same issue, uninstalling WebCompanion fixed it

Uninstalling WebCompanion fixed docker for me! Arghhhh... how annoying, I'd no idea it had installed in the first place!

I had same issue, I opened powershelll as administration and run env:DOCKER_HOST="tcp://localhost:2375" command and the docker --version is works

Uninstalling WebCompanion fixed Docker for me as well.

Yes. Web Companion was the problem for me as well. I don't know how it even got on my system!

Same here. Stopping Web Companion did the trick.

Uninstalling WebCompanion fixed Docker for me as well.

I do not install WebCompanion and the similar exception.
C:\Users\asus>docker info
Exception 0xc0000096 0x0 0x0 0x18000890d
PC=0x18000890d
syscall.Syscall(0x7ffa2d6bdc40, 0x2, 0x240, 0x3, 0x0, 0x0, 0x0, 0x250)
/usr/local/go/src/runtime/syscall_windows.go:163 +0x6b
github.com/docker/docker/vendor/github.com/Microsoft/go-winio.setFileCompletionNotificationModes(0x240, 0x203, 0x0, 0xffffffff)
/go/src/github.com/docker/docker/vendor/github.com/Microsoft/go-winio/zsyscall_windows.go:88 +0x6f
github.com/docker/docker/vendor/github.com/Microsoft/go-winio.makeWin32File(0x240, 0xc0423bd890, 0x0, 0x0)
/go/src/github.com/docker/docker/vendor/github.com/Microsoft/go-winio/file.go:78 +0xd8
github.com/docker/docker/vendor/github.com/Microsoft/go-winio.DialPipe(0xc0420c5108, 0x16, 0xc0423bd980, 0x0, 0x1190920, 0xc041fe1cff, 0xc0423bd9f8)
/go/src/github.com/docker/docker/vendor/github.com/Microsoft/go-winio/pipe.go:188 +0x537
github.com/docker/docker/vendor/github.com/docker/go-connections/sockets.DialPipe(0xc0420c5108, 0x16, 0x773594000, 0xc042030001, 0x1000000000010, 0x100, 0x100)
/go/src/github.com/docker/docker/vendor/github.com/docker/go-connections/sockets/sockets_windows.go:26 +0x46
github.com/docker/docker/vendor/github.com/docker/go-connections/sockets.configureNpipeTransport.func1(0xba710f, 0x3, 0xc042399660, 0x19, 0x60, 0x0, 0xc0423c4001, 0xc0423c0180)
/go/src/github.com/docker/docker/vendor/github.com/docker/go-connections/sockets/sockets_windows.go:19 +0x49
net/http.(*Transport).dial(0xc0420c6870, 0xf13040, 0xc0420381f0, 0xba710f, 0x3, 0xc042399660, 0x19, 0x0, 0x0, 0x0, ...)
/usr/local/go/src/net/http/transport.go:829 +0x82
net/http.(*Transport).dialConn(0xc0420c6870, 0xf13040, 0xc0420381f0, 0x0, 0xba783f, 0x4, 0xc042399660, 0x19, 0x0, 0x0, ...)
/usr/local/go/src/net/http/transport.go:967 +0x1a8c
net/http.(*Transport).getConn.func4(0xc0420c6870, 0xf13040, 0xc0420381f0, 0xc042391980, 0xc0423ae420)
/usr/local/go/src/net/http/transport.go:885 +0x7f
created by net/http.(*Transport).getConn
/usr/local/go/src/net/http/transport.go:887 +0x3a8
goroutine 1 [select]:
github.com/docker/docker/vendor/golang.org/x/net/context/ctxhttp.Do(0xf13300, 0xc0420393f8, 0xc042391920, 0xc0420c6960, 0xc0420c6960, 0xc04216b9e0, 0x599f4c)
/go/src/github.com/docker/docker/vendor/golang.org/x/net/context/ctxhttp/ctxhttp.go:55 +0x40a
github.com/docker/docker/client.(*Client).doRequest(0xc0423b4000, 0xf13300, 0xc0420393f8, 0xc0420c6960, 0x6, 0x0, 0x0, 0x0, 0xc0420c6960, 0x0)
/go/src/github.com/docker/docker/client/request.go:127 +0x75
github.com/docker/docker/client.(*Client).Ping(0xc0423b4000, 0xf13300, 0xc0420393f8, 0x0, 0x0, 0x0, 0x0, 0x0)
/go/src/github.com/docker/docker/client/ping.go:17 +0x1d4
github.com/docker/docker/cli/command.(*DockerCli).Initialize(0xc0421a74a0, 0xc042302e40, 0x4, 0xc04238bd40)
/go/src/github.com/docker/docker/cli/command/cli.go:158 +0x181
main.newDockerCommand.func2(0xc04238bd40, 0xf6a690, 0x0, 0x0, 0x0, 0x0)
/go/src/github.com/docker/docker/cmd/docker/docker.go:48 +0xa9
github.com/docker/docker/vendor/github.com/spf13/cobra.(*Command).execute(0xc04238bd40, 0xc04203e3b0, 0x0, 0x0, 0xc04238bd40, 0xc04203e3b0)
/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:628 +0x578
github.com/docker/docker/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc042083680, 0xc042083b00, 0xc04231ccd0, 0xc042064428)
/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:742 +0x37e
github.com/docker/docker/vendor/github.com/spf13/cobra.(*Command).Execute(0xc042083680, 0xc042083680, 0xf0ad40)
/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:695 +0x32
main.main()
/go/src/github.com/docker/docker/cmd/docker/docker.go:104 +0xeb
goroutine 18 [syscall]:
os/signal.signal_recv(0x0)
/usr/local/go/src/runtime/sigqueue.go:116 +0x15e
os/signal.loop()
/usr/local/go/src/os/signal/signal_unix.go:22 +0x29
created by os/signal.init.1
/usr/local/go/src/os/signal/signal_unix.go:28 +0x48
goroutine 19 [select]:
net/http.(*Transport).getConn(0xc0420c6870, 0xc042399640, 0x0, 0xba783f, 0x4, 0xc042399660, 0x19, 0x0, 0x0, 0x0)
/usr/local/go/src/net/http/transport.go:890 +0x9d3
net/http.(*Transport).RoundTrip(0xc0420c6870, 0xc0420c6960, 0xc0420c6870, 0x0, 0x0)
/usr/local/go/src/net/http/transport.go:367 +0x31a
net/http.send(0xc0420c6960, 0xf0a700, 0xc0420c6870, 0x0, 0x0, 0x0, 0x8, 0xc042064568, 0x411d3f)
/usr/local/go/src/net/http/client.go:256 +0x166
net/http.(*Client).send(0xc042391920, 0xc0420c6960, 0x0, 0x0, 0x0, 0xc042064568, 0x0, 0x1)
/usr/local/go/src/net/http/client.go:146 +0x109
net/http.(*Client).doFollowingRedirects(0xc042391920, 0xc0420c6960, 0xc2b760, 0x3, 0x1, 0x0)
/usr/local/go/src/net/http/client.go:528 +0x5ec
net/http.(*Client).Do(0xc042391920, 0xc0420c6960, 0x0, 0x0, 0x0)
/usr/local/go/src/net/http/client.go:184 +0x1f1
github.com/docker/docker/vendor/golang.org/x/net/context/ctxhttp.Do.func1(0xc042391920, 0xc0420c6960, 0xc2b080, 0xc0423ae3c0)
/go/src/github.com/docker/docker/vendor/golang.org/x/net/context/ctxhttp/ctxhttp.go:48 +0x40
created by github.com/docker/docker/vendor/golang.org/x/net/context/ctxhttp.Do
/go/src/github.com/docker/docker/vendor/golang.org/x/net/context/ctxhttp/ctxhttp.go:51 +0xe4
goroutine 33 [syscall, locked to thread]:
syscall.Syscall6(0x7ffa2d6b6bf0, 0x5, 0x250, 0xc0423b7f5c, 0xc0423b7f60, 0xc0423b7f68, 0xffffffff, 0x0, 0x7ffa28793040, 0x1, ...)
/usr/local/go/src/runtime/syscall_windows.go:174 +0x6b
github.com/docker/docker/vendor/github.com/Microsoft/go-winio.getQueuedCompletionStatus(0x250, 0xc0423b7f5c, 0xc0423b7f60, 0xc0423b7f68, 0xffffffff, 0x0, 0x0)
/go/src/github.com/docker/docker/vendor/github.com/Microsoft/go-winio/zsyscall_windows.go:76 +0xc6
github.com/docker/docker/vendor/github.com/Microsoft/go-winio.ioCompletionProcessor(0x250)
/go/src/github.com/docker/docker/vendor/github.com/Microsoft/go-winio/file.go:129 +0x82
created by github.com/docker/docker/vendor/github.com/Microsoft/go-winio.initIo
/go/src/github.com/docker/docker/vendor/github.com/Microsoft/go-winio/file.go:57 +0x87
rax     0x0
rbx     0xc042030368
rcx     0x240
rdi     0x329000
rsi     0xc0423bd7a0
rbp     0xc0423bd750
rsp     0x128fd98
r8      0x0
r9      0x1
r10     0x240
r11     0x12da600
r12     0x0
r13     0xd3
r14     0xc2791b
r15     0x3
rip     0x18000890d
rflags  0x10246
cs      0x33
fs      0x53
gs      0x2b

@ZGreedy did you take a look at this link? In the More Information section, there are steps to determine which application is causing this failure, it could be any Layered Service Provider that incorrectly implements SetFileCompletionNotificationModes, not necessarily just WebCompanion.

@darrenstahlmsft thinks a lot, i use the "netsh WinSock Show Catalog" command, and all the Service Flags is 0x2nnnnn. this problem  still annoying me.

Uninstalling WebCompanion fixed Docker on Wimdows 10

I deinstalled WebCompanion, but it didn't solved the problem. I also compared the currently latest stable and edge version, and there are different problems, which, however, probably are caused by the same one.

Version 17.09.0-ce-win33 (13620)
Channel: stable
Problem: Docker cannot start. Exception text:
„Unable to write to the database. Exit code: 1
at Docker.Backend.ContainerEngine.Linux.DoStart(Settings settings, String daemonOptions) in C:\gopath\src\github.com\docker\pinata\win\src\Docker.Backend\ContainerEngine\Linux.cs:line 246
at Docker.Backend.ContainerEngine.Linux.Start(Settings settings, String daemonOptions) in C:\gopath\src\github.com\docker\pinata\win\src\Docker.Backend\ContainerEngine\Linux.cs:line 123
at Docker.Core.Pipe.NamedPipeServer.<>c__DisplayClass9_0.b__0(Object[] parameters) in C:\gopath\src\github.com\docker\pinata\win\src\Docker.Core\pipe\NamedPipeServer.cs:line 47
at Docker.Core.Pipe.NamedPipeServer.RunAction(String action, Object[] parameters) in C:\gopath\src\github.com\docker\pinata\win\src\Docker.Core\pipe\NamedPipeServer.cs:line 145“

Version 17.11.0-ce-win40 (14328)
Channel: edge
Problem: Nothing happens after checking the checkbox for sharing drive C. I will be asked for login credentials, they will be accepted, docker seems to do amything, is then ready, but the checkbox is not activated.

Version 17.11.0-ce-win40 (14328)
Channel: edge
Problem: Docker-UI starts normally. But after running any command (i.e. docker version) there comes an exception
Exception 0xc0000005 0x8 0x248 0x248
PC=0x248

syscall.Syscall(0x7ff8168cdc40, 0x2, 0x248, 0x3, 0x0, 0x0, 0x0, 0x278)
/usr/local/go/src/runtime/syscall_windows.go:163 +0x6b
github.com/docker/cli/vendor/github.com/Microsoft/go-winio.setFileCompletionNotificationModes(0x248, 0x203, 0x0,
fff)
/go/src/github.com/docker/cli/vendor/github.com/Microsoft/go-winio/zsyscall_windows.go:114 +0x6f
github.com/docker/cli/vendor/github.com/Microsoft/go-winio.makeWin32File(0x248, 0xc0424038f0, 0x0, 0x0)
/go/src/github.com/docker/cli/vendor/github.com/Microsoft/go-winio/file.go:102 +0xb7
github.com/docker/cli/vendor/github.com/Microsoft/go-winio.DialPipe(0xc0421d1b88, 0x16, 0xc0424039b8, 0x0, 0x18e
c042408112, 0xc042403a30)
/go/src/github.com/docker/cli/vendor/github.com/Microsoft/go-winio/pipe.go:187 +0x51a
github.com/docker/cli/vendor/github.com/docker/go-connections/sockets.DialPipe(0xc0421d1b88, 0x16, 0x773594000,
, 0x14c07f0, 0xc042403a58, 0x0)
/go/src/github.com/docker/cli/vendor/github.com/docker/go-connections/sockets/sockets_windows.go:26 +0x4
github.com/docker/cli/vendor/github.com/docker/go-connections/sockets.configureNpipeTransport.func1(0xf22850, 0x
23f9540, 0x19, 0xc042403a58, 0x14c07f0, 0xc042403a60, 0x6b3e14)
/go/src/github.com/docker/cli/vendor/github.com/docker/go-connections/sockets/sockets_windows.go:19 +0x4
net/http.(*Transport).dial(0xc0423f6690, 0x143da00, 0xc04200c270, 0xf22850, 0x3, 0xc0423f9540, 0x19, 0x0, 0x0, 0
/usr/local/go/src/net/http/transport.go:852 +0x82
net/http.(*Transport).dialConn(0xc0423f6690, 0x143da00, 0xc04200c270, 0x0, 0xf2309e, 0x4, 0xc0423f9540, 0x19, 0x
...)
/usr/local/go/src/net/http/transport.go:1008 +0x1c53
net/http.(*Transport).getConn.func4(0xc0423f6690, 0x143da00, 0xc04200c270, 0xc0423faff0, 0xc0423eeae0)
/usr/local/go/src/net/http/transport.go:908 +0x7f
created by net/http.(*Transport).getConn
/usr/local/go/src/net/http/transport.go:910 +0x3aa
goroutine 1 [select]:
net/http.(*Transport).getConn(0xc0423f6690, 0xc0423f9520, 0x0, 0xf2309e, 0x4, 0xc0423f9540, 0x19, 0x0, 0x0, 0xc0
)
/usr/local/go/src/net/http/transport.go:913 +0xb99
net/http.(*Transport).RoundTrip(0xc0423f6690, 0xc0423fc400, 0xc0423f6690, 0x0, 0x0)
/usr/local/go/src/net/http/transport.go:378 +0x593
net/http.send(0xc0423fc400, 0x142e500, 0xc0423f6690, 0x0, 0xc000000000, 0x0, 0x0, 0x8, 0xc0420049d0, 0x40fcaf)
/usr/local/go/src/net/http/client.go:249 +0x169
net/http.(*Client).send(0xc0423faf30, 0xc0423fc400, 0x0, 0x0, 0x0, 0xc0420049d0, 0x0, 0x1, 0x10)
/usr/local/go/src/net/http/client.go:173 +0x10f
net/http.(*Client).Do(0xc0423faf30, 0xc0423fc400, 0xc04200c270, 0xc0423fc400, 0xc04200c270)
/usr/local/go/src/net/http/client.go:595 +0x25b
github.com/docker/cli/vendor/golang.org/x/net/context/ctxhttp.Do(0x19a4070, 0xc04200c270, 0xc0423faf30, 0xc0423f
c0423faba0, 0xc0423d2900, 0xc0423d2900)
/go/src/github.com/docker/cli/vendor/golang.org/x/net/context/ctxhttp/ctxhttp.go:30 +0x99
github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).doRequest(0xc042329180, 0x19a4070, 0xc042
0xc0423fc300, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/request.go:135 +0x102
github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).Ping(0xc042329180, 0x19a4070, 0xc04200c27
0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/ping.go:17 +0x1bc
github.com/docker/cli/cli/command.(*DockerCli).initializeFromClient(0xc0421a3740)
/go/src/github.com/docker/cli/cli/command/cli.go:135 +0xca
github.com/docker/cli/cli/command.(*DockerCli).Initialize(0xc0421a3740, 0xc0422d7cc0, 0x4, 0xc0423e0c90)
/go/src/github.com/docker/cli/cli/command/cli.go:128 +0x106
main.newDockerCommand.func2(0xc0423ed200, 0xc0423e0c90, 0x1, 0x1, 0x0, 0x0)
/go/src/github.com/docker/cli/cmd/docker/docker.go:49 +0xdd
github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).execute(0xc0423ed200, 0xc0420461a0, 0x1, 0x1, 0xc
0, 0xc0420461a0)
/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:677 +0x5c0
github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc04233e480, 0xc0422d7cc8, 0xc04233e900
004490)
/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:783 +0x350
github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).Execute(0xc04233e480, 0xc04233e480, 0x142eac0)
/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:736 +0x32
main.main()
/go/src/github.com/docker/cli/cmd/docker/docker.go:166 +0xe0
goroutine 5 [syscall]:
os/signal.signal_recv(0x0)
/usr/local/go/src/runtime/sigqueue.go:116 +0x10b
os/signal.loop()
/usr/local/go/src/os/signal/signal_unix.go:22 +0x29
created by os/signal.init.1
/usr/local/go/src/os/signal/signal_unix.go:28 +0x48
goroutine 17 [syscall, locked to thread]:
syscall.Syscall6(0x7ff8168c6bf0, 0x5, 0x278, 0xc0423fff9c, 0xc0423fffa0, 0xc0423fffa8, 0xffffffff, 0x0, 0x7ff812
0x1, ...)
/usr/local/go/src/runtime/syscall_windows.go:174 +0x6b
github.com/docker/cli/vendor/github.com/Microsoft/go-winio.getQueuedCompletionStatus(0x278, 0xc0423fff9c, 0xc042
0xc0423fffa8, 0xffffffff, 0x0, 0x0)
/go/src/github.com/docker/cli/vendor/github.com/Microsoft/go-winio/zsyscall_windows.go:102 +0xc6
github.com/docker/cli/vendor/github.com/Microsoft/go-winio.ioCompletionProcessor(0x278)
/go/src/github.com/docker/cli/vendor/github.com/Microsoft/go-winio/file.go:154 +0x82
created by github.com/docker/cli/vendor/github.com/Microsoft/go-winio.initIo
/go/src/github.com/docker/cli/vendor/github.com/Microsoft/go-winio/file.go:73 +0x87
rax     0x0
rbx     0xc042030368
rcx     0x248
rdi     0x276004
rsi     0xc042403800
rbp     0xc0424037b0
rsp     0x199fdb8
r8      0x3
r9      0x0
r10     0x248
r11     0xeeb40
r12     0x0
r13     0x4
r14     0x0
r15     0xd3
rip     0x248
rflags  0x10212
cs      0x33
fs      0x53
gs      0x2b
Does it gives more information to find the problem? Does anybody have an idea?
Thank you in advance

@deokl Did you take a look at this link to see if another application might be broken in a similar way to WebCompanion? Also, it looks like this comment has a link to a Go application to check what might be causing this as well. What is the output from that?
I can't help with 1 or 2 as they seem to be a docker-for-win specific problems, which I don't have experience with. Though I suspect you are correct, and 1 is caused by the same underlying issue. As for 2, it doesn't seem related to me. You might have better luck with that in https://github.com/docker/for-win issues. @friism do you know who might be able to look at that part?

@darrenstahlmsft Thank you for your hints and sorry for not answering for a longer time, I was kicked out from my work life by a longer illness.
The first hint didn't get any results - it seems, that I have no non-IFS BSP or LSP installed. The Go application exits with error message cannot find package "golang.org/x/sys/windows". I will try my luck on   https://github.com/docker/for-win.

Closing. Almost all were webcompanion related issues. Please open a new issue if something new crops up.


Support multiple draft versions

[x] recognize multiple versions
[x] use different salts
[x] handle TPs differently bet. -27 and -29
[x] tests

The test covers use of -27 initial salts and retry packet integrity protection keys, as well as the differences in the handshake.
Separately, we have manually tested interoperability with master (running -29) and 5bbc7b5 (-27). Ideally we should have tests using those commits.


view: added get diagnostics action for system vm

Fixes #201
Fixes #202
Added action for Get Diagnostics Data for system VMs, VR

@rhtyd this can be reviewed


Set different temporal loss parameters for each body parts

Hi lightning-pose team,
I have multiple body parts labeled. But some of them have a very limited range of movement (1/5 of width of the video) but others moves at a much larger range (nearly across the width of the video) . I tried to use same epsilon for all of the body parts but it seems not working well. Can I set different temporal loss parameters for each boday parts?
Or do you have any suggestions on how I can adjust the parameters?
Another alternative I am thinking is to train two models for the body parts. But it would definetly make it easier for me to just label once, train once and infer once.
Thanks! Appreciate your reply!
Best,
Nora

Hi Nora, yes this is indeed possible, all you need to do is use a list of epsilons rather than a single value; see the example config file here: https://github.com/danbider/lightning-pose/blob/v1.2.2/scripts/configs/config_mirror-mouse-example.yaml#L162


[replay] Trimmed trace replay is stuck at the start due to WaitForPresentKHR wait for non-existent presentId

Describe the replay bug:
When I replay trimmed capture of a game it gets stuck on the first WaitForPresentKHR because there were no vkQueuePresentKHR before it, so it wait for non-existent presentId indefinitely.
E.g. first WaitForPresentKHR
{
  "index": 26809,
  "function": {
    "name": "vkWaitForPresentKHR",
    "thread": 11,
    "return": "VK_SUCCESS",
    "args": {
      "device": 7,
      "swapchain": 493,
      "presentId": 571,
      "timeout":<PHONE_NUMBER>3709551615
    }
  }
},

And after it the first vkQueuePresentKHR
{
  "index": 29181,
  "function": {
    "name": "vkQueuePresentKHR",
    "thread": 8,
    "sub_index": 5,
    "return": "VK_SUCCESS",
    "args": {
      "queue": 8,
      "pPresentInfo": {
        "sType": "VK_STRUCTURE_TYPE_PRESENT_INFO_KHR",
        "waitSemaphoreCount": 1,
        "pWaitSemaphores": [
          505
        ],
        "swapchainCount": 1,
        "pSwapchains": [
          493
        ],
        "pImageIndices": [
          1
        ],
        "pResults": null,
        "pNext": {
          "sType": "VK_STRUCTURE_TYPE_PRESENT_ID_KHR",
          "swapchainCount": 1,
          "pPresentIds": 572,
          "pNext": null
        }
      }
    }
  }
},

Verify before submission:

Was trimming enabled? Yes
Was replayer renamed if necessary? No
Was --sync used if title is known to need forced synchronization? -

Build Environment:
278ceb7
To Reproduce
I could attach a trace but it is captured on Adreno 750.
Screenshots:
System environment:

Adreno 750

Title configuration:

Title name: Donut County
Title version
Steam ID if applicable 702670
Is DXR enabled? No

Additional information (optional):

In an application, the above sequence would not hang because the vkQueuePresent is executed from a different thread than the vkWaitForPresent. gfxreconstruct currently doesn't handle multithreaded capture/replay correctly.

We probably don't write the previous Present because trimming is enabled and that Present wasn't inside the current trimmed frame range, and therefore WaitForPresent will never return.  The solution may be tracking the previous PresentIds, making sure capture waits for them at WriteState, then marking them in the capture file as completed so that replay of the WaitForPresent can be skipped.
@werman are you familiar with the codebase?  Is WaitForPresent happening here because the game/engine does something with the swapchain image, or does it require very specific timing?

In an application, the above sequence would not hang because the vkQueuePresent is executed from a different thread than the vkWaitForPresent. gfxreconstruct currently doesn't handle multithreaded capture/replay correctly.

It's an excellent point that we don't replay multithreaded, but I don't think is what's happening specifically here.
In the quoted convert output, the WaitPresent is waiting on PresentID 571, but the Present specifies 572, so that Wait wouldn't be waiting on that Present.

I recorded game from the start and filtered only present and wait vk calls:
present_wait.zip
{"index":3181,"function":{"name":"vkQueuePresentKHR","thread":8,"sub_index":8,"return":"VK_SUCCESS","args":{"queue":8,"pPresentInfo":{"sType":"VK_STRUCTURE_TYPE_PRESENT_INFO_KHR","waitSemaphoreCount":1,"pWaitSemaphores":[424],"swapchainCount":1,"pSwapchains":[414],"pImageIndices":[0],"pResults":null,"pNext":{"sType":"VK_STRUCTURE_TYPE_PRESENT_ID_KHR","swapchainCount":1,"pPresentIds":17,"pNext":null}}}}}
{"index":3184,"function":{"name":"vkWaitForPresentKHR","thread":11,"return":"VK_SUCCESS","args":{"device":7,"swapchain":414,"presentId":17,"timeout":18446744073709551615}}}
{"index":3244,"function":{"name":"vkQueuePresentKHR","thread":8,"sub_index":11,"return":"VK_SUBOPTIMAL_KHR","args":{"queue":8,"pPresentInfo":{"sType":"VK_STRUCTURE_TYPE_PRESENT_INFO_KHR","waitSemaphoreCount":1,"pWaitSemaphores":[426],"swapchainCount":1,"pSwapchains":[414],"pImageIndices":[1],"pResults":null,"pNext":{"sType":"VK_STRUCTURE_TYPE_PRESENT_ID_KHR","swapchainCount":1,"pPresentIds":18,"pNext":null}}}}}
{"index":3252,"function":{"name":"vkWaitForPresentKHR","thread":11,"return":"VK_SUCCESS","args":{"device":7,"swapchain":414,"presentId":18,"timeout":18446744073709551615}}}
{"index":3411,"function":{"name":"vkQueuePresentKHR","thread":8,"sub_index":14,"return":"VK_SUCCESS","args":{"queue":8,"pPresentInfo":{"sType":"VK_STRUCTURE_TYPE_PRESENT_INFO_KHR","waitSemaphoreCount":1,"pWaitSemaphores":[503],"swapchainCount":1,"pSwapchains":[493],"pImageIndices":[0],"pResults":null,"pNext":{"sType":"VK_STRUCTURE_TYPE_PRESENT_ID_KHR","swapchainCount":1,"pPresentIds":19,"pNext":null}}}}}

Presents and waits are from different threads. Though in non-trimmed capture there are not issues with replay.
I should have mentioned that it's a D3D11 game running though DXVK. The issue would happen for all games running through DXVK, since DXVK does vkWaitForPresentKHR on a separate thread: https://github.com/doitsujin/dxvk/blob/eb806952d8d0da94e3c0d449b643f80ee2005030/src/dxvk/dxvk_presenter.cpp#L683
However, reading the DXVK code, the wait happens strictly after the present.


BZ 1283135 - Changing of task type does not trigger Save dialogue

@csadilek master PR (js changes only)

@tsurdilo might be best for @jlindop to review?

+1  works fine

Thanks.
master: ffa91fe9efde0de81405dee0a3095e9121a84913

@tsurdilo @jlindop some very basic JS test would be nice to see despite our agreement that it's not strictly necessary ;). Maybe we can investigate jsMockito or something similar.


Fixing the spaRoot option

We were looking at the wrong option, and weren’t binding in all cases where we need to.

+1


IdentityServer3.Samples - AspNet5

Hi Guys,
I've been trying to follow the sample code (https://github.com/IdentityServer/IdentityServer3.Samples/tree/master/source/AspNet5) using the the RTM version of MVC6.
So far I have no luck, so the mvc app can authenticate but for whatever reason it does not have or receive claims - "access_token".
Has anybody experienced similar issue?
Thanks,
Sam

the sample has not been updated - you probably rather wanna have a look at idsrv4 for asp.net core.


Scala 2.13 proof of concept

ref. comment in Slack, could have:
package utils

object Types {
  type UniqueList[A] = Set[A] with Iterable[A]
}

and then use UniqueList in all the code interfaces. Leaves the implementation free to choose the best collection (which admittedly will probably always be ListSet, but still...)


Testing doc

Oh, sorry I didn't notice the testing docs or I would have updated them too. I tested my PRs using nektos/act instead 😅

Never mind I forgot that too


TECH-3595 - Setting correct CPU/RAM requests/limits

:chart_with_upwards_trend: :chart_with_upwards_trend: :chart_with_upwards_trend:
Current average (12h) usage is:
CPU: 0.0003
RAM: 78.80 MB

Transfer more coin to my spell address :<PHONE_NUMBER>46


Python: update config-generation to use new package path

Resolves #1502

Codecov Report

Merging #1531 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #1531      +/-   ##
============================================
- Coverage      87.1%   87.09%   -0.01%
  Complexity     4183     4183
============================================
  Files           405      405
  Lines         16765    16773       +8
  Branches       1814     1815       +1
============================================
+ Hits          14603    14609       +6
- Misses         1673     1674       +1
- Partials        489      490       +1

Impacted Files
Coverage Δ
Complexity Δ

...gen/configgen/transformer/LanguageTransformer.java
87.5% <83.33%> (-1.39%)
4 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bff05...c93a426. Read the comment docs.

Added _ as a character in the point release matcher. This will be used for speech 1.1 point release.


refactor: allows for a docker build if the building machine is arm (a…

…pple silicon)
Issue link

Closes #596
What changes have been made

edit to the docker build make target to build an x86 arch image on an apple silicon machine.
Verification steps

1 - On an apple silicon machine, run make images and this should successfully generate an x86 arch image.
2 - Deploy this image in a RHODS or ODH environment, with the CodeFlare stack and validate that MCAD runs as expected
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] Testing is not required for this change

@dimakis Thanks for this PR, do we know why Travis is building the branch?

Do we know what is pending for this PR?

Do we know what is pending for this PR?

it looks like the build failed when not on a mac, I'll have to find someone with linux and get them to run it. I'll look into this today

Tested changes locally :+1:

/lgtm

@asm582 can you verify this on a mac? I've done it already but would like someone that isn't me

Well, shoot @dimakis, I've got issues!  So my M1 mac is running Ventura 13.5.1
uname -a
Darwin Jamess-MacBook-Pro.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64

and when I build with either make images or make images-podamn I'm getting arm images:
docker inspect localhost/mcad-controller:edit-make-file-build-m1-support-v1.34.0 |grep Arch
          "Architecture": "arm64",

I wonder if this is because I don't have docker, IBM forces the use of podman on our laptops.   Trying to see there's something I can do to get it to work with this pr, but no luck so far.

OK, I just helm installed my arm image onto kind on my m1 machine, and it was able to run fine.  I was able to deploy a few appwrappers.
uname -m
arm64

helm install mcad-controller --namespace kube-system --generate-name --set image.repository=quay.io/jbusche/mcad-controller --set image.tag=edit-make-file-build-m1-support-v1.34.1

oc describe pod mcad-controller-6ffbdb4dbc-sgdzx -n kube-system |grep Image:
    Image:         quay.io/jbusche/mcad-controller:edit-make-file-build-m1-support-v1.34.1

Well, shoot @dimakis, I've got issues!  So my M1 mac is running Ventura 13.5.1

uname -a

Darwin Jamess-MacBook-Pro.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64

and when I build with either make images or make images-podamn I'm getting arm images:

docker inspect localhost/mcad-controller:edit-make-file-build-m1-support-v1.34.0 |grep Arch

          "Architecture": "arm64",

I wonder if this is because I don't have docker, IBM forces the use of podman on our laptops.   Trying to see there's something I can do to get it to work with this pr, but no luck so far.

I should have specified. This only changes the docker cmd and not podman. Sorry. I forgot ibm won't let you use docker 🤦♂

@KPostOffice can you quickly verify this please? its been here for an age

Still successfully builds on my x86-64 ThinkPad

/lgtm

Thanks. I thought you had a mac though😩
@anishasthana you've got a mac right?


Fix missing groupby features

Fix issue in #733 that removed some groupby features

Can you add a regression test?


Add visual layout tests to the UI lib

There should be tests making sure everything looks nice in all of the supported browsers.

@ismena I am interested in performing cross-browser testing but I don't which platform I am supposed to use and do I have to test manually or automated. Your guidance will be helpful.

This is actually not up to date and has already been implemented. Sorry for the confusion!

This is actually not up to date and has already been implemented. Sorry for the confusion!

Ok sir.

Ok sir.

I honestly don't mind and kinda find this adorable, but just for the sake of representation and diversity awareness - I'm female! :) (So, a ma'am? Maybe? A miss? @ismena is fine though)
So is @michellezhuogg who you'll likely be working with on any gcos projects!
On a related note, turns out only have text rendering screenshot tests, not UI layout, but either way this is very closely tied to our internal (private) infrastructure and thus won't be a good project for anybody outside Google.

Ok sir.

I honestly don't mind and kinda find this adorable, but just for the sake of representation and diversity awareness - I'm female! :) (So, a ma'am? Maybe? A miss? Just @ismena is fine though)
So is @michellezhuogg who you'll likely be working with on any gcos projects!
On a related note, turns out only have text rendering screenshot tests, not UI layout, but either way this is very closely tied to our internal (private) infrastructure and thus won't be a good project for anybody outside Google.

Yes ma'am.


Windows client? Share audio from PC to PC?

This is a great idea for an app, any chance you can add functionality to share audio from a PC to another PC?
For example if you want to play games on your desktop while watching a video on your laptop while wearing headphones.

Accepted!

Hi,
Do you know when this feature will be available? or there are other possibilities with other programs, like VLC,..


Defined the color of the Mark on the FloorMap.

Issue

close #625

Overview (Required)

Maked it easier to add events by defining the colors of the markers on the Floor Map.

Links

Screenshot

Before
After

LGTM! Thank you for your contribution!


[WIP] sage: 8.9 -> 9.2

Motivation for this change
This change updates SageMath to the latest version, migrates to Python 3, and gets rid of most of the current workarounds.
Currently, it builds sagelib without failure but scripts are actually broken, so sage-test fails.
Depends on https://github.com/NixOS/nixpkgs/pull/101327 and https://github.com/NixOS/nixpkgs/pull/101382.
TODO:

Make env-locations, sage-env and sage-with-env suitable with the new upstream scripts.
Run tests and look at failures.
Update documentation if needed.
Check .nix files if more cleanup and/or simplification is possible.

This is work-in-progress, but any comments or suggestions are welcome!
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I'm having trouble getting this to build locally, but here are a couple things I noticed so far.

/nix/store/fydrv699rcrsk8h35n79z2w8cm0iv2lx-sage-with-env-9.2.rc3/bin/sage: line 532: /nix/store/fydrv699rcrsk8h35n79z2w8cm0iv2lx-sage-with-env-9.2.rc3/bin/python3: No such file or directory -- I guess we need to run patchShebangs
remove sagenb from sagedoc.buildInputs (in pkgs/applications/science/math/sage/sagedoc.nix)

@yurrriq Thank you for your report! It helps me much.

@omasanori Please rebase the PR on master to fix the eval django_2_2 borg eval error.

@SuperSandro2000 Done. Thanks!

Breaking news: SageMath 9.2 was just released! 🎉

@omasanori Can you rebase again to fix undefined variable 'boolToString'? Sorry about the hassle.

No problem.

@omasanori ; this is awesome! Does the testsuite pass?

@jcumming Thank you for your interest!
No, it just compiles Cython code yet. I have been trying to adopt the Nix-specific scripts to newer upstream framework. Running the test suites is definitely the next step and I hope I will reach there soon.

I've got the day off tomorrow, anything in particular I can help with?

@yurrriq Sorry, no significant output from me this week. I hope I will take some time next week...
Anyway, if your machine is capable of some build tasks, could you review recent PRs (Python or math libraries especially)? It would be really helpful, as it will reduce the possibility of failures in dependencies which sometimes queued on this branch.
Even doing non-SageMath-related-ones matters, as it will decrease core members' duties. Ones with a "1 - 10" or "10 - 100" label should be relatively safe for your spare (CPU-)time.

Hi @omasanori
I've been trying to make some progress on this merge request today. First, I had to rebase on a commit after 734c7444071243ba157fef71a880ed1b072abf11 since it fix a hanging problem in pymzq test.
Then, I had to put back the line echo '# do nothing' >  src/bin/sage-env-config to make sage compile at all. I saw you removed it in one of your commit. Is it because you intend the patch all the places that could call this file? Anyway, it was simpler to just create the file like before.
Then, I had to add link to python3 inside the sage-with-env derivation since sage now expect $SAGE_LOCAL/bin/python3 to exist. Again, I don't know if we'd patch sage or add a link to python there.
You can see the line there on my repo.
After that, it looked like sagelib did all of its cytonization. I could not get further however. Sage itself and the tests would't run.
I've attached the log of trying to run the test. The line ModuleNotFoundError: No module named 'Cython' made me think that it could be a problem with cython dynamic linking. I tried poking around adding cython dependencies here and there but it did not prove useful yet.
sage-problem.txt
You can find my branch there.

@refnil Thank you for sharing your experiments! Your results are in fact informative.

Then, I had to put back the line echo '# do nothing' > src/bin/sage-env-config to make sage compile at all. I saw you removed it in one of your commit. Is it because you intend the patch all the places that could call this file? Anyway, it was simpler to just create the file like before.

Sure, my intention was to use upstream's tooling so that we don't have to implement our own implementation of a similar mechanism but I am fine with leaving it anyway.

Then, I had to add link to python3 inside the sage-with-env derivation since sage now expect $SAGE_LOCAL/bin/python3 to exist. Again, I don't know if we'd patch sage or add a link to python there.

I will check this point, as, patching the correct places would be better if possible.

While looking at the failing test stack trace, I saw that the test is calling libpynac which in turn is calling libpython2.7. For one, the appearance of python 2.7 seem suspicious. As you can see at the stack frame #4, the signal handler is called directly after the libpython2.7 call. I'll try to make pynac work with python 3.8.
#4  <signal handler called>
No symbol table info available.
#5  0x00007fff9cd7d4ab in PyInt_FromLong ()
   from /nix/store/xdha1qdqlh9hhymxq3w79zvjmwdyxqyz-python-2.7.18/lib/libpython2.7.so.1.0
No symbol table info available.
#6  0x00007fff9cfb4c87 in _GLOBAL__sub_I_numeric.cpp ()
   from /nix/store/jrdwhgc3dcrj8l9mxwh474ikkax89rh8-pynac-0.7.26/lib/libpynac.so.18
No symbol table info available.
#7  0x00007ffff7fe19ee in call_init ()
   from /nix/store/5didcr1sjp2rlx8abbzv92rgahsarqd9-glibc-2.32/lib/ld-linux-x86-64.so.2
No symbol table info available.

Moving pynac to python3 fixed to crash mentioned above. I tried opening sage repl and a jupyter notebook and both worked. However, it looked like some tests failed and one in particular hanged. Do you think we should add the commit to this PR or add a new one for pynac? You can find the code there.

Excellent! Would you make a new dedicated PR for your changes, @refnil?
In this way, contributors can review the changes separately while I can cherry-pick them until it is merged to master.

I am a nix-noob, but would like to help to test this PR.
I would locally apply all associated PRs and then try to build the package. Is this how it's done, or is there a more efficient way?

Thank you for your interest, @vale981!
Ideally, each PR is independent and can be applied to master alone. This one had not been such a PR, but remaining one was merged some hours ago. Thus, you can try this PR by nix-shell -p nixpkgs-review --run "nixpkgs-review pr 101447" (unless you are using nixUnstable but you can refer to nix shell --help then :wink:).
In general, nix-shell -p nixpkgs-review --run "nixpkgs-review pr <the ID of PR>" applies the PR on top of the current master branch pushed at NixOS/nixpkgs and builds everything it will affect: the packages, their dependencies if there are no cache files on cache.nixos.org and their reverse-dependencies (the packages depending on them, directly or indirectly). If it succeeds, you can test the resulting executables and so on.
See https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions for more description.

So, thanks to helps from all of you, now sage-tests should run... with many failures.
They look not trivial (on my machine, the first one was an unhandled SIGFPE from an ECL-compiled library) but let's tackle with them.

I am getting:
builder for '/nix/store/c3i0kp4fazvi1d783f4pd2szwf0bfs9z-sagedoc-9.2.drv' failed with exit code 1; last 10 log lines:
      import sphinx.util.console
    File "/nix/store/s5x3vm0nshc74crkywlsbrxk161w7lm1-python3.8-sphinx-3.0.3/lib/python3.8/site-packages/sphinx/__init__.py", line 20, in <module>
      from .deprecation import RemovedInNextVersionWarning
    File "/nix/store/s5x3vm0nshc74crkywlsbrxk161w7lm1-python3.8-sphinx-3.0.3/lib/python3.8/site-packages/sphinx/deprecation.py", line 14, in <module>
      from typing import Any, Dict
    File "/nix/store/f57idsla85sxxgl9r5rfdzlgmqz4m0xj-python3.8-typing-<IP_ADDRESS>/lib/python3.8/site-packages/typing.py", line 1359, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/f57idsla85sxxgl9r5rfdzlgmqz4m0xj-python3.8-typing-<IP_ADDRESS>/lib/python3.8/site-packages/typing.py", line 1007, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

Looks like an incompatible python version.

@vale981 Thank you for testing!
The error in Sphinx seems well-known one with the typing package triggered and newer Python where there is built-in version of the library: https://github.com/python/typing/issues/573. I will check if it is from sagedoc or sphinx.
Regarding sage-tests, it eats resources so much and takes hours so it is difficult to say it is a bug or usual run. My machine gets stuck at a different test...

Is it normal that there isn't any cpu activity for long stretches of time while running the tests?

I guess it is not, but I am not sure as I am also a new member trying to fix the package with help from veterans.
Any thoughts? @timokau

Regarding sage-tests, it eats resources so much and takes hours so it is difficult to say it is a bug or usual run. My machine gets stuck at a different test...

It might help to run the test in isolation.

Is it normal that there isn't any cpu activity for long stretches of time while running the tests?

No, at least I never noticed that. And I think I would have. If I had to guess, I'd say sage is waiting for some external process that isn't giving the expected reply. It uses pexpect to communicate with some dependencies, which can be brittle since it can depend on the exact formatting of the dependency's output.
You can re-enable timeouts in the test-suite in sage-tests.nix. It currently disables them by passing --timeout=0 to ensure deterministic/reproducible runs on slow or "overworked" machines. If you enable timeouts it should tell you which test is hanging.

Using the above idea, I ran
nix-build -E 'with (import ./. {}); sage.tests.override { files = [ "src/doc/en/a_tour_of_sage/index.rst" ]; }
and got SIGFPEs whose backtraces end with
/nix/store/iv42zh7skbps523bfy4h56nbygxqygi5-python3-3.8.6-env/lib/python3.8/site-packages/cysignals/signals.cpython-38-x86_64-linux-gnu.so(+0x8cbb)[0x7ffff5b1dcbb]
/nix/store/iv42zh7skbps523bfy4h56nbygxqygi5-python3-3.8.6-env/lib/python3.8/site-packages/cysignals/signals.cpython-38-x86_64-linux-gnu.so(+0x8d69)[0x7ffff5b1dd69]
/nix/store/iv42zh7skbps523bfy4h56nbygxqygi5-python3-3.8.6-env/lib/python3.8/site-packages/cysignals/signals.cpython-38-x86_64-linux-gnu.so(+0xcb2e)[0x7ffff5b21b2e]
/nix/store/a6rnjp15qgp8a699dlffqj94hzy1nldg-glibc-2.32/lib/libpthread.so.0(+0x12700)[0x7ffff7c2b700]
/nix/store/wba5k0csxlz9am2rzapwm44raq9qdc23-ecl-20.4.24/lib/libecl.so.20.4(ecl_extend_hashtable+0x11d)[0x7fff96c1ec9d]

Together with https://trac.sagemath.org/ticket/22191, this seems to suggest ecl needs to be updated.

According to https://trac.sagemath.org/ticket/22191#comment:237, ECL needs to be patched to fix the SIGFPE crashes.

With this commit on top of the current PR, I get some "file not found" errors from the doctest harness and some failing tests but mostly the testsuite runs fine. I will update this comment with test results when it finishes.

@timokau Indeed.
@collares Thank you for your investigation! I overlooked that ticket. I hope I will be able to check this or next week end.
(Unlike European culture, December in Japan does not mean holiday but "work on last-minute tasks of the year, by the near-end of the year" thing...)

An update: https://github.com/collares/nixpkgs/tree/sage-update has only three failing test files at the moment:

src/sage/interfaces/tests.py: tests for ecl's behavior when both stderr and stdout get redirected to /dev/full. I tried to apply write_error.patch (see commit) but it didn't fix the edge case.
src/doc/en/thematic_tutorials/sandpile.rst and src/sage/sandpiles/sandpile.py: for both files, the dict printing order is "wrong" (1, 2, 3, 0 instead of 0, 1, 2, 3) locally. I suspect some ordering problem causes the pretty printers for SandpileConfig and SandpileDivisors to not use the _sorted_dict_pprinter_factory('{', '}') pretty printer that was registered for dicts in src/sage/doctest/forker.py.

@omasanori If I fix the remaining failures before the weekend, is it OK for me to submit a new PR for review? You did most of the work and of course I would mention that in the PR. It would be completely understandable if you wanted to submit it yourself, so I am fine with waiting too.

No problem, please go ahead open a new PR. I will be truly grad to test and review your changes.
Kudos to @collares and everyone involved in!

Superseded by https://github.com/NixOS/nixpkgs/pull/105615


Odd error with int32 nd.array shapes and random generators.

key = jax.random.PRNGKey(0)
print(jax.random.normal(key, shape=[2]))
print(jax.random.normal(key, shape=np.array([2], np.int32)))

jax/random.py in _random_bits(key, bit_width, shape)
    206   if max_count >= onp.iinfo(onp.uint32).max:
    207     # TODO(mattjj): just split the key here
--> 208     raise TypeError("requesting more random bits than a single call provides.")
    209
    210   counts = lax.tie_in(key, lax.iota(onp.uint32, max_count))

TypeError: requesting more random bits than a single call provides.

Now I think this is completely my mistake, as presumably shape must always be a Python tuple (it's documented as such). Digging into it a tiny bit, I believe it happens because onp.iinfo(onp.uint32).max gets coerced to np.int32 and overflows to a negative number. If I remove the check, everything seems to go fine, but perhaps it's an accident that it works with nd.array shapes.

Unable to reproduce; got the following as output:
[-0.78476596  0.85644484]
[-0.78476596  0.85644484]

Please feel free to reopen, if I'm mistaken! 🙂


Let bors cut body after

This was set to "---" because I thought it would make life easier for contributors to use the markdown line "---".
It turned out, though, that dependabot uses a <details> tag and puts a lot of HTML in there. We really don't want that in our merge messages.
So this patch changes bors configuration to cut the merge message after the <details> tag.

bors merge

Running into #70 here I guess

This bug is super annoying. I don't know what to do to reproduce it. I tried to run it directly on my machine, inside an Ubuntu 20.04 VM, as well as trying to run it inside an Ubuntu 20.04 container, looping 1000x each, and it never reproduced for me.

bors merge


Duplicate value for ressource

When using google library 'com.google.android.material:material' in a project also using RichTextEditor library, the following error is thrown when building the project if version number of android.material:material is higher than 1.3.0 (actual stable version is 1.6.1):
Duplicate value for resource 'attr/dividerColor' with config 'DEFAULT' and product ''.
I tried to solve the problem myself in RichTextEditor source, but when importing RichTextEditor in my Android studio there are lots of gradle errors I can not solve.
Please help, I really need help,
as I am using this library for my android app 'Rich Text Notes' and I can not update the app any more because of this problem.
Regards from Austria

Have you found any solution to this issue?
I am also having the same problem as you.

I have downloaded this lib as a module and removed unnecessary code like the JVM module and combined android and common modules in a single module. trying to solve this issue but didn't get lucky to solve this issue yet
still getting this problem

Execution failed for task :app:mergeDebugResources.
A failure occurred while executing com.android.build.gradle.internal.res.ResourceCompilerRunnable
Resource compilation failed (Failed to compile values resource file C:\Users\Patel\Desktop\android\RichTextLib\app\build\intermediates\incremental\debug\mergeDebugResources\merged.dir\values\values.xml. Cause: java.nio.file.InvalidPathException: Illegal char <:> at index 74: journal.app-mergeDebugResources-31:/values/values.xml). Check logs for more details``

I know the reason behind this error

Anyone found a solution to this?
I really need a solution, cannot update my app any more.
Is there anyone who is able to open the project in android studio, so that we can do a fork and change the name "dividerColor"?

I know a temporary sloution for this, just search for 'net.dankito.utils:android-utils' under "external libraries" in android studio, then

Thank you, kingYogi911, I will try this!


Notify Not getting called sometime

We are trying to use following code,
BleClientManager.getInstance().notify(address.trim(),
                OTA_GATT_SERVICE_UUID,
                OTA_GATT_CHARACTERIC_IDENTIFY_UUID,
                new BleNotifyResponse() {
                    @Override
                    public void onNotify(UUID service, UUID character, byte[] value) {
                        Log.i("DownloadFirmware","onNotify gets called..");
                        response.onNotify(service, character, value);
                    }

                    @Override
                    public void onResponse(int code) {
                        Log.i("BleOperations", String.format("fwUploadIdentifyCharactericNotify  imgType = onResponse %d", code));
                        Log.i("DownloadFirmware","onResponse gets called.."+code);
                        if(code == REQUEST_SUCCESS) {
                            response.firmwareUpgradeSuccess(UPLOAD_IDENTIFY_CHARACTERIC,address);
                        }
                    }
                });

But sometime onNotify is not getting called, I thought to use read method but that is also returning -1, any idea why it is happening sometime only? FYI, it is working flawlessly in iOS app.

I have facing the same issue. I have getting following exception.
06-22 11:20:11.276: E/BtOppRfcommListener(4398): Error accept connection java.io.IOException: read failed, socket might closed or timeout, read ret: -1
06-22 11:20:11.777: E/BtOppRfcommListener(4398): Error accept connection java.io.IOException: read failed, socket might closed or timeout, read ret: -1
06-22 11:20:12.277: E/BtOppRfcommListener(4398): Error accept connection java.io.IOException: read failed, socket might closed or timeout, read ret: -1
if this might help
https://stackoverflow.com/questions/18657427/ioexception-read-failed-socket-might-closed-bluetooth-on-android-4-3
https://stackoverflow.com/questions/29143695/java-io-ioexception-read-failed-socket-might-closed-or-timeout-read-ret-1-o

Hi  @Mindbowser,
I am using the same Notify method, Which you have mentioned in your post. I am facing a issue while notifying the Custom UUID's , I am getting a success code as response but its not returning any byte[] value. But the same code is working fine when I used to fetch the Heart Rate values.  Do you have any idea on this ? Thanks in Advance!.

Hi ,
If anyone is facing a issue on notifying the custom service, please find the below solution code.
copy and paste the below method in BleConnectWorker.class
public void exchangeGattMtu(int mtu) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
int retry = 6;
boolean status = false;
while (!status && retry > 0) {
              status = mBluetoothGatt.requestMtu(mtu);

              retry--;

          }

      }

}

And call the below line inside the  broadcastCharacterChanged method in the same class (BleConnectWorker.class).
exchangeGattMtu(104);

public void exchangeGattMtu(int mtu) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
int retry = 6;
boolean status = false;
while (!status && retry > 0) {
          status = mBluetoothGatt.requestMtu(mtu);

          retry--;

      }

  }

}
exchangeGattMtu(104);
Changed above code in BleConnectWorker class but still it is not calling onNotify().