Audio S3 Upload change for new workflow (staging Goobi)

When testing the new audio workflow in staging Goobi, I need to download the audio files from an S3 bucket, zip them on my hard drive, and upload them again to workflow-stage-upload.
We would like to be able to keep all audio files in the Cloud when ingesting in Goobi like we do for the films. In the film workflow, a folder with the process name is created under the A/V section and the appropriate files are placed in there via a S3 copy from another bucket.
This works for the film workflow because the Lambda knows to wait for:

One MXF, one MP4, one JPG (and maybe a PDF transcript)
One MPG, one JPG (and maybe  PDF transcript)

But the audio workflow is harder to pin down in terms of what the Lambda should expect because there's no set hard rule of what files will be uploaded for a given item. File combinations could include:

One or multiple WAV files and maybe a PDF transcript and/or a JPG poster image
One or multiple MP3 files and maybe a PDF transcript and/or a JPG poster image

So we cannot rely on the Lambda to trigger the ingest for us but is it possible for us to:

Create a folder with the process name in the A/V folder (or just an audio folder) in the workflow-stage-upload bucket
Move all files for an item via S3 copy into the folder on workflow-stage-upload bucket from another bucket
Manually trigger the ingest from workflow-stage-upload once all files needed are present (by something in Goobi, perhaps?)
The files continue in the new audio workflow as expected

Indeed that should work and we would like to implement it that way.
We would change the current av prefix to separate audio and video prefixes and implement a way to mark the ingest as complete in Goobi.
Actually the logic behind all these ingest mechanisms is part of Goobi, the different lambda functions trigger with each uploaded file and the function then triggers a matching endpoint in Goobi which handles the rest (check for a complete video upload etc.)

Changes for lambda and s3 triggers etc. can be found in PR #339 and have been deployed to staging. Therefore the av prefix is not used anymore, but audio and video should.

infrastructure has been adapted via PR #339

If we could change the behavior in the bucket that causes the bnumber folder to disappear under /video when you upload one file to it, we can close this. The bnumber folder should persist to allow multiple copies to it without needing to recreate it.

Closing this and opening #346


Wiki page and mailing list for VerifiedCaller Sub Project

@camaraproject/admins please create Wiki page and mailing list for VerifiedCaller Sub Project and update the README within the repository accordingly

Hi Herbert,
I will create the wiki page for this sub project.
Best,
Evan
On Mon, May 20, 2024 at 6:21 AM Herbert Damker @.***>
wrote:

@camaraproject/admins https://github.com/orgs/camaraproject/teams/admins
please create Wiki page and mailing list for VerifiedCaller Sub Project and
update the README within the repository
—
Reply to this email directly, view it on GitHub
https://github.com/camaraproject/VerifiedCaller/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BCR3Y5OSHZHP4KHLZYTOFPLZDH2HJAVCNFSM6AAAAABH7W7ZBOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDKOJZGI3DEMY
.


Update carousel picture ASAP

The carousel's first slide needs to use the following picture:

Katy requests this be completed with urgency. Thank you!
Resources

Figma design file: New carousel image

Updated the slide in PR #262

Amazing, thanks for the quick work @bhushankhope!


Add juju action to run a query

E.g. juju run ollama/0 generate "Why the sky is blue".

The feature was added here.


Weapons Lite Not Firing

I followed the tutorials to the best of my abilities, however my character still won't fire projectiles.  I was using a sidescroller set up and the only weapon I wanted the player to have was a projectile "spell".  I'm pretty sure its something on my end, but I couldn't tell.  Fire1 didn't seem to be working at all.

IsJumping will never be true, because in PlayerAnimController, animator.SetBool("isJumping", true); sets "isJumping" to true not "IsJumping". Make sure the name is exactly isJumping in your Animator parameters


feat(icons): add icons for transfer.nvim

Icons for plugin transfer.nvim
Before:

After:

Sorry, but that's way too specific. You can add it in your own config though.


Merging fork into logstash-plugin repo

Initial pull request for new plugin.

@jsvd @ph as windows heroes of logstash, can one of you take a look at this initial PR to have this plugin merge in?

As another logstash & windows user, I'm going to be testing this out. Also looking forward to this being merged into an official plugin.

Cool,
please go ahead, all testing is more than welcome, specially windows one.
you can use the issues of this repo to report issues.
We're going to merge this in as soon as is properly reviewed.
Looking forward to it,
On Friday, June 12, 2015, Brady Vidovic<EMAIL_ADDRESS>wrote:

As another logstash & windows user, I'm going to be testing this out. Also
looking forward to this being merged into an official plugin.
—
Reply to this email directly or view it on GitHub
https://github.com/logstash-plugins/logstash-input-perfmon/pull/1#issuecomment-111542818
.

--
Pere Urbon-Bayes
Software Engineer
https://www.elastic.co
https://twitter.com/purbon

It says that a CLA is missing for my last check-in. How do we fix that? And is testing still underway?

@NickMRamirez to get the CLA fix, you need to sign the CLA, or Contributor Agreement ... you can find more information at: https://www.elastic.co/contributor-agreement
Regarding testing, I'm not testing it right now, as of not being a windows expert myself ... i ask my colleagues in the group (@jsvd and @ph ) to provide his point of view. They are super busy, but I'm sure they will provide you with valuable feedback as soon as possible.
Thanks a lot for your patience and efforts.

purbon

Can we at least get the initial pull request done? And then test as needed? Seems kinda silly to have an empty repo here.

@NickMRamirez you need to sign the CLA as requested: https://github.com/logstash-plugins/logstash-input-perfmon/pull/1#issuecomment-131754711 then we could move on more.

I think I've signed the CLA twice now. Is it not showing up? I no longer see the warning about that.

@NickMRamirez you have signed the cla using hotmail.com email. This PR is from email hmbnet.com domain. Can you please resign the cla with the hmbnet email?

I don't understand the CLA process then. My github account is tied to my gmail account. I'm not sure how either a hotmail or hmbnet email figures in. This is really just me not understanding. Did I specify those emails earlier?

@NickMRamirez When signing the CLA, you had to manually provide an email address.  It did not come from your GitHub account automatically.

I forwarded it to my work email and signed it. Should be good now.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Can I become a maintainer for this?

Hi @NickMRamirez, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Hi @NickMRamirez, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@NickMRamirez can you rebase? we can merge this in

I've added my other emails and signed the CLA again.

Where is this now? Need anything from me?

Checking in. Where do we stand with integrating this?

apologies @NickMRamirez, we have had some reorg on our team over the past few months.
one thing that I see that would be great to do before we move forward is to update the gem dependencies so that this can be installed in Logstash >= 2.4.
#gemspec file
s.add_runtime_dependency "logstash-core-plugin-api", ">= 1.60", "<= 2.99"

and maybe remove the explicit gem declarations in the Gemfile
thanks!

@talevy I would prefer it if this branch could be merged first. I've been waiting for that for quite a while. Then we can add your request as an Issue that either I or someone else can work on.

sure


Create tmp files in /run and fix SELinux labels

https://bugzilla.redhat.com/show_bug.cgi?id=1352713 reports some issues
with SELinux and docker-storage-setup.
This fixes attempt to create the content in a /run instead of on /tmp which
prevents potentially hostile users from attacking the script.
The mv -Z calls will guarantee the content gets created with the correct
label.

Going through my old pull requests.  Could @rhvgoyal or @shishir-a412ed Look at this.

LGTM.

@rhatdan Your title says make temp files in /run/docker however you are creating it in /run. One of them needs to be updated, not sure which one. Otherwise LGTM.

Fixed the label on github, the layer in the pull request was correct.

@rhatdan, went through the bug quickly and could not understand what's the core issue. Can you please summarize the issue here and how this patch fixes it. In fact it would be better if it is part of commit message of the bug so that in future somebody can go through it and understand why this piece of code was changed.

I updated the pull request with updated comments

LGTM

@rh-atomic-bot r+


python programms

you can add more python programms

Assign this issue to me @pinak22dhir

@Nitinshukla88 no updates

I Have Snake game I can Contribute in the Project.

what tag you want?

@pinak22dhir  Hacktober fest

ok @Anshu370


Data URI base64 encoded .SWF file support?

Is it possible to load the .SWF file using data URI Base64 encoding instead of using a URL? The goal being to load the Flash object without having to make an external HTTP request.

I encoded an Swf, Tried the Data:ShockwaveFlashObject/swf;base64,DATAHASHHERE
and that didnt work, I tried swf on its own and a few other methods, but other then that... well it doesnt want to register it as ANYTHING. it just says that it doesnt exist

if anyone has an uptodate way of doing this to an SWF game file, and allow it to run successfully on Chrome, I would greatly Apreciatte it.


Upgrades for compat with latest Langchain

Newest release of Langchain has breaking changes, so for now this project is restricting the version to 0.0.137 until there's time to perform an upgrade.

fixed in 0.9.0 release


hugo mod removes non-Hugo modules from go.mod

I use mage to manage my sites (download data, publish via rsync, run pngquant on resized images…), and go mod adds mage's dependencies to go.mod.
Hugo removes them every time I run it.
 Is there an option to make it write its dependencies to, say, hugo.mod instead of the go.mod file?

Is there an option to make it write its dependencies to, say, hugo.mod instead of the go.mod file?

Not that I know of, but I would be happy to be proven wrong. I would say that I cannot currently fix your problem.

OK , thinking a little I think I know what we can do. I have implemented my own "tidy logic" because Go does not understand Hugo's imports. We can adjust that so:

Store away the go.* content
First run go tidy. In most situations this should make them empty.
Apply Hugo's logic, but keep any lefovers from 2)

Sounds like a reasonable workaround. Shame Hugo can't use a different file.

Shame Hugo can't use a different file.

Or Mage.

I have double-checked the Go source, and go.mod is very much hardcoded ... all over the place.
I will take another round on this and check what Go does with these files on regular use, but I suspect that it will be a variant of the above and that with your setup you cannot use "go mod tidy" as that will wipe out the non-Go entries.

Or Mage.

It's not Mage. It's go mod doing its thing.

go.mod is very much hardcoded ... all over the place.

That certainly is very hardcoded. Oh well…

as that will wipe out the non-Go entries

I'm not currently using Hugo modules. But it appears that the presence of a go.mod file causes Hugo to run its tidy routine when building or serving.
Also, wouldn't go mod only remove Hugo's entries if you explicitly run tidy?

If this isn't getting added any time soon, could you make Hugo behave the same as go mod and only remove entries from go.mod when explicitly told to do so (or at least only when hugo mod is run)?
Currently, it clears out go.mod every time I build the site or run hugo server, which means I have to undo its changes basically every time I run Hugo (and stop hugo server first, otherwise it'll just remove the entries again).

Just run into this as well. I'm not quite sure how Hugo modules are implemented, but I suspect they should be using an approach similar to the way in which tool dependencies are declared?
https://github.com/go-modules-by-example/index/blob/master/010_tools/README.md
i.e. the dependencies need to be declared in Go code if go mod tidy is to see them.

i.e. the dependencies need to be declared in Go code if go mod tidy is to see them.

Which is exactly what Hugo does (if you replace "Go code" with "Hugo source"), which is also where the problem lies.

I have "turned off" the tidy during regular builds. WIll be in Hugo 0.57.1. You will still see this problem if you do hugo mod tidy.

which is also where the problem lies.

Just wanted to make sure we're talking about the same thing here: for go mod tidy to work, the dependencies will need to be declared in Go code.
So if you have dependencies declared in "Hugo source" then you will likely need to code generate a build-ignored .go file that also includes those dependencies:
// +build ignore

package hugodeps

import (
	_ "example.com/hugo/dep"
)

Just wanted to make sure we're talking about the same thing here: for go mod tidy to work, the dependencies will need to be declared in Go code.

We're obviously not. This is not about go mod tidy.

Ah, glad I confirmed. I had understood from the conversation above that the Hugo module dependencies would be added to go.mod, but I guess that is not the case.

I had understood from the conversation above that the Hugo module dependencies would be added to go.mod, but I guess that is not the case.

They do, but the problem is still not about go mod tidy.

I had understood from the conversation above that the Hugo module dependencies would be added to go.mod, but I guess that is not the case.

They are. The issue is that Hugo currently behaves as if go.mod is exclusively for its own use and only for Hugo modules, so it removes any actual Go dependencies put there by go mod.
It's also very aggressive about doing that, and "tidies" go.mod when commands other than hugo mod tidy are run. Even when you aren't actually using Hugo modules.
The upshot is that Hugo currently does not play well with go mod.
Not running its tidy routines unless explicitly told to do so would solve the problems this is causing me, but imo, the proper solution is the one @bep initially suggested: Hugo shouldn't alter go mod's entries. After all, the go.mod file belongs to go mod, not Hugo.

After all, the go.mod file belongs to go mod, not Hugo.

Just to make my point clear:

go mod tidy acts as if it owns go.mod, which is probably a bug (but please don't start a discussion on this here).
hugo mod tidy does the same (which is this bug). I have in Hugo 0.57.1 turned off the "auto tidy" feature which should reduce some of this noise.

My main point is this: If you create a Hugo project, that is the spec you need to follow. If you create a "Go and Hugo" mixed module, that comes currently with some issues. If that becomes a problem, put them in each subfolder/module or something.

If you create a Hugo project, that is the spec you need to follow. If you create a "Go and Hugo" mixed module, that comes currently with some issues.

Thanks for clarifying that you distinguish between these two cases. We have a "Go and Hugo" module, hence why I was referring to go mod tidy above.
I think it's worth ensuring that go mod tidy works regardless because this is what people will  expect from any project that contains a go.mod. There's more cognitive load in saying "if it's a Hugo project then you need to run hugo mod tidy", especially because that instruction is unintuitive in a "Go and Hugo" mixed module.
go mod tidy could actually be made to work with either type of project. Every time hugo runs it could ensure that a "shadow" code-generated build-ignored .go file reflects the modules referenced in Hugo source. That way, any subsequent run of go mod tidy will see Hugo's requirements reflected via the code-generated .go file.

That way, any subsequent run of go mod tidy will see Hugo's requirements reflected via the code-generated .go file.

That doesn't work because Hugo modules aren't go modules. go mod doesn't understand Hugo modules, and Hugo doesn't understand Go modules.

go mod tidy acts as if it owns go.mod

It's called go.mod, not project.stuff…

That doesn't work because Hugo modules aren't go modules.

Then I'm not quite sure I understand why they are being put into go.mod? (https://github.com/gohugoio/hugo/issues/6115#issuecomment-521707171)

Then I'm not quite sure I understand why they are being put into go.mod?

They shouldn't be, imo, but Hugo leverages the go mod machinery to manage its modules, and the go.mod filename is very hardcoded, so Hugo can't easily put its stuff in hugo.mod instead.
In any case, go mod doesn't seem to mind Hugo's modules being in there, although go mod tidy will remove them. Now that Hugo v0.57.1 isn't removing go mod's stuff all the time, it's no longer an annoying problem in practice.
Thanks @bep!

I'm not entirely sure of the details of how you're using the go mod machinery, but:

You may want to leave a comment about your usage on https://github.com/golang/go/issues/31866.

You might be interested in the -modfile flag we're planning to add in Go 1.14 (https://tip.golang.org/doc/go1.14#go-flags).

@deanishe I had worked with a monorepo before so tried a solution and it's working well for me now. Take a look at magefiles. In the monorepo scenario, I've found it useful for this. The basics are:

Move your magefile (even if just one) into magefiles.
cd magefiles && go mod init mage.local && go mod tidy && go mod vendor (in my case I didn't use canonical name for the root repo as it's just a hugo project and don't need to remotely import).
In project directory, run hugo mod tidy && hugo mod vendor (if using hugo modules).

Optional: For cutting out multi-module language issues also run go work init && go work use . && go work use ./magefiles. For Go 1.18+ this helps solve multimodule repo gopls issues with completion/intellisense.

Go module for the hugo project isn't impacted then by the mage module tooling.
cc @natefinch as related to monorepo stuff.


[Bug]: Grounding in Gemini throws an error "invalid argument"

File Name
gemini/grounding/intro-grounding-gemini.ipynb
What happened?
While trying out Grounding with Generative AI, the command response = model.generate_content(PROMPT, tools=[tool]) throws the error :
_InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
    status = StatusCode.INVALID_ARGUMENT
    details = "Request contains an invalid argument."
    debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B2404:6800:4007:82b::200a%5D:443 {grpc_message:"Request contains an invalid argument.", grpc_status:3, created_time:"2024-04-11T16:48:11.261411+05:30"}"
>

Whereas response = model.generate_content(PROMPT) works just fine. I see that there's some issue in using the tools parameter.
Relevant log output
---------------------------------------------------------------------------
_InactiveRpcError                         Traceback (most recent call last)
File ~/.local/lib/python3.11/site-packages/google/api_core/grpc_helpers.py:76, in _wrap_unary_errors.<locals>.error_remapped_callable(*args, **kwargs)
     75 try:
---> 76     return callable_(*args, **kwargs)
     77 except grpc.RpcError as exc:

File ~/.local/lib/python3.11/site-packages/grpc/_channel.py:1176, in _UnaryUnaryMultiCallable.__call__(self, request, timeout, metadata, credentials, wait_for_ready, compression)
   1170 (
   1171     state,
   1172     call,
   1173 ) = self._blocking(
   1174     request, timeout, metadata, credentials, wait_for_ready, compression
   1175 )
-> 1176 return _end_unary_response_blocking(state, call, False, None)

File ~/.local/lib/python3.11/site-packages/grpc/_channel.py:1005, in _end_unary_response_blocking(state, call, with_call, deadline)
   1004 else:
-> 1005     raise _InactiveRpcError(state)

_InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.INVALID_ARGUMENT
	details = "Request contains an invalid argument."
	debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B2404:6800:4007:80a::200a%5D:443 {created_time:"2024-04-12T13:01:34.945989+05:30", grpc_status:3, grpc_message:"Request contains an invalid argument."}"
>

The above exception was the direct cause of the following exception:

InvalidArgument                           Traceback (most recent call last)
Cell In[29], line 4
      1 tool = Tool.from_google_search_retrieval(grounding.GoogleSearchRetrieval())
      2 tools=[tool]
----> 4 response = model.generate_content(PROMPT, tools=tools)

File ~/.local/lib/python3.11/site-packages/vertexai/generative_models/_generative_models.py:405, in _GenerativeModel.generate_content(self, contents, generation_config, safety_settings, tools, tool_config, stream)
    397     return self._generate_content_streaming(
    398         contents=contents,
    399         generation_config=generation_config,
   (...)
    402         tool_config=tool_config,
    403     )
    404 else:
--> 405     return self._generate_content(
    406         contents=contents,
    407         generation_config=generation_config,
    408         safety_settings=safety_settings,
    409         tools=tools,
    410         tool_config=tool_config,
    411     )

File ~/.local/lib/python3.11/site-packages/vertexai/generative_models/_generative_models.py:494, in _GenerativeModel._generate_content(self, contents, generation_config, safety_settings, tools, tool_config)
    469 """Generates content.
    470
    471 Args:
   (...)
    485     A single GenerationResponse object
    486 """
    487 request = self._prepare_request(
    488     contents=contents,
    489     generation_config=generation_config,
   (...)
    492     tool_config=tool_config,
    493 )
--> 494 gapic_response = self._prediction_client.generate_content(request=request)
    495 return self._parse_response(gapic_response)

File ~/.local/lib/python3.11/site-packages/google/cloud/aiplatform_v1beta1/services/prediction_service/client.py:2102, in PredictionServiceClient.generate_content(self, request, model, contents, retry, timeout, metadata)
   2099 self._validate_universe_domain()
   2101 # Send the request.
-> 2102 response = rpc(
   2103     request,
   2104     retry=retry,
   2105     timeout=timeout,
   2106     metadata=metadata,
   2107 )
   2109 # Done; return the response.
   2110 return response

File ~/.local/lib/python3.11/site-packages/google/api_core/gapic_v1/method.py:131, in _GapicCallable.__call__(self, timeout, retry, compression, *args, **kwargs)
    128 if self._compression is not None:
    129     kwargs["compression"] = compression
--> 131 return wrapped_func(*args, **kwargs)

File ~/.local/lib/python3.11/site-packages/google/api_core/grpc_helpers.py:78, in _wrap_unary_errors.<locals>.error_remapped_callable(*args, **kwargs)
     76     return callable_(*args, **kwargs)
     77 except grpc.RpcError as exc:
---> 78     raise exceptions.from_grpc_error(exc) from exc

InvalidArgument: 400 Request contains an invalid argument. [detail: "[ORIGINAL ERROR] generic::invalid_argument: The GenerateContentRequest proto is invalid:\n  * tools[0].tool_type: required one_of \'tool_type\' must have one initialized field"
]

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It's possible that you need to accept the additional Terms of Service for Grounding with Google Search in Gemini. You can find this in Vertex AI Studio:

And you can access the form directly here:
https://docs.google.com/forms/d/e/1FAIpQLSfj7SJNAqXOe7vB9Re-WtwJedTWjHkBKZ6OHaLoGoXRG93ymg/viewform
I'll update the notebook to include this step.

I accepted the Terms of Services using the form, but I am still facing an error. I am using the sample provided by Google.
Can I get get any help?
model = GenerativeModel("gemini-1.5-pro-preview-0409")
my_prompt = (
"What are the price, available colors, and storage size options of a Pixel Tablet?"
)
response = model.generate_content(my_prompt)
print(response.candidates[0].text)
tool = Tool.from_google_search_retrieval(grounding.GoogleSearchRetrieval())
response = model.generate_content(my_prompt,tools=[tool])
The Exception
Traceback (most recent call last):
File "C:\Users\shyam\GenAI\untitled1\GenAIGrounding.py", line 24, in
response = model.generate_content(my_prompt,tools=[tool])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\shyam\AppData\Roaming\Python\Python312\site-packages\vertexai\generative_models_generative_models.py", line 405, in generate_content
return self._generate_content(
^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\shyam\AppData\Roaming\Python\Python312\site-packages\vertexai\generative_models_generative_models.py", line 494, in _generate_content
gapic_response = self._prediction_client.generate_content(request=request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\shyam\AppData\Roaming\Python\Python312\site-packages\google\cloud\aiplatform_v1beta1\services\prediction_service\client.py", line 2102, in generate_content
response = rpc(
^^^^
File "C:\Program Files\Python312\Lib\site-packages\google\api_core\gapic_v1\method.py", line 131, in call
return wrapped_func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Program Files\Python312\Lib\site-packages\google\api_core\grpc_helpers.py", line 78, in error_remapped_callable
raise exceptions.from_grpc_error(exc) from exc
google.api_core.exceptions.InvalidArgument: 400 Request contains an invalid argument.
Process finished with exit code 1

@ShyamKadari did you get a confirmation that you were allowlisted for the feature?

No.
I did not get a confirmation email.
Shyam
On Fri, Apr 26, 2024, 12:05 PM Holt Skinner @.***>
wrote:

@ShyamKadari https://github.com/ShyamKadari did you get a confirmation
that you were allowlisted for the feature?
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/generative-ai/issues/536#issuecomment-2079765307,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BICC2YXXINDOQYFZHIDYQDDY7KCNPAVCNFSM6AAAAABGDUL73KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZG43DKMZQG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


What is "Inline Model #"?

    server.route({
        method: 'POST',
        path: '/auth/session',
        config: {
            tags: ['api'],
            response: {
                schema: Joi.object().label('schema').keys({
                    value: Joi.object().label('value').keys({
                        hello: Joi.number()
                    })
                })
            }
        },
        handler: function (req, reply) {
            reply(true);
        }
    });

that prints response model as
schema {
    value (Inline Model 1, optional)
}
Inline Model 1 {
    hello (number, optional)
}

I think that 'Inline Model 1' should be replaced with 'value', and there is no way to do that.

Hi this took me a while to sort out. I had to rewrite elements of how models are created.
Swagger-UI use the phase "Inline Model" when it cannot find a title property for an object. It currently has a bug where sometimes child object are not named even when a  title property is provided. I have a temporary work around I have hacked their Javascript to make this work and will file an issue on their repo.
You should now be able to label all your objects. You need to give each different structure its own unique name, but you can use a single structure as many times as you wish.
If you have any more problems please feel free to reopen the issue

Hi @glennjones, this is a terrible place to ask, but I see that you experienced issues with child objects in swagger-ui. I am also experiencing issues like this (not with hapi) and I was hoping you could share your patch and/or link to the issue you opened on their project? I would be very grateful!

I have seemed to be able to work around my issues given certain structure. Thanks all the same.


fix: HOME with different permissions

Make sure standard functionality works even when HOME has different permissions

added new tests

/kind enhancement

/rerun all

/test all

/retest-required

/retest-required

The main unit test is failing because "knative" user (GH actions/ something similar) has greater permissions, I suspect. Will have to update the new test.

@lkingland PTAL

/unhold


Remove extra file

How to categorize this PR?

/kind bug
/area os
/os garden-linux
What this PR does / why we need it:
Remove extra file
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

You have two unrelated commits in this PR. One looks like #362.


Self tracing broken in update?

I upgraded from 2.3.1 to 2.4.6 and had this error on startup. I was running
SELF_TRACING_ENABLED=true SELF_TRACING_SAMPLE_RATE=0.10 java -jar zipkin.jar
zipkin startsup with no problems when I removed the self tracing variables.

Application startup failed
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zipkinServerConfiguration.BraveTracedStorageComponentEnhancer': Unsatisfied dependency expressed through field 'brave'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'brave' defined in class path resource [zipkin/server/brave/BraveConfiguration.class]: Unsatisfied dependency expressed through method 'brave' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'braveTracer' defined in class path resource [zipkin/server/brave/BraveConfiguration.class]: Unsatisfied dependency expressed through method 'braveTracer' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'reporter' defined in class path resource [zipkin/server/brave/BraveConfiguration.class]: Unsatisfied dependency expressed through method 'reporter' parameter 2; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zipkinServerConfiguration': Unsatisfied dependency expressed through field 'httpCollector'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zipkinHttpCollector' defined in URL [jar:file:/home/zipkin/zipkin.jar!/BOOT-INF/classes!/zipkin/server/ZipkinHttpCollector.class]: Unsatisfied dependency expressed through constructor parameter 2; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'metrics': Requested bean is currently in creation: Is there an unresolvable circular reference?

thanks for reporting.. will look into it. In the mean time, please disable
self tracing

2.4.7 will fix this. it is going out now


Automatically set version based on API's data

curl -K "X-Api-Key: changeme" http://pdns:8081/api/v1/servers/localhost | jq .version returns the version, why ask it in the admin panel?

To avoid calling to that API to detect the version every time we make an API call (record applying for example). However, since the #604, I've dropped the old PDNS (3.x) support. I will need to think about a better way of handling the PDNS API version...


How to correctly install spectacle-code-slide

I tried installing spectacle-code-slide along with the spectacle-boilerprate: I clone the spectacle boilerplate first, then I type: npm i && npm i spectacle-code-slide --save. Then I modify presentation/index.js with your code (I define the theme, transition etc.), and put code.example into assets/.
When I run npm run start and go to http://localhost:3000/ the slides are just "stuck" and don't move with the arrows, but if I go to http://localhost:3000/0 it correctly works. I get a console error at http://localhost:3000 :
"Uncaught TypeError: Cannot read property 'scrollTop' of undefined"
What am I doing wrong?

uhh, what does your CodeSlide declaration look like?

`import React from "react";
import { Deck, Spectacle } from "spectacle";
import createTheme from "spectacle/lib/themes/default";
import CodeSlide from "spectacle-code-slide";
const theme = createTheme({
primary: "#ffffff"
});
export default class Presentation extends React.Component {
render() {
return (

<Deck transition={["slide"]} transitionDuration={0} progress="bar">
<CodeSlide
transition={["slide"]}
lang="html"
code={require("raw!../assets/code.example")}
ranges={[
{ loc: [0, 1],
title: "Learn HTML 5",
note: "Use arrow keys to navigate through the slides!" },
    { loc: [0, 1],
      title: "Learn HTML 5",
      note: "First line defines document type for HTML5" },

    { loc: [1, 2],
      note: "This is the main tag, any other HTML code is inside here" },

    { loc: [2, 6],
      note: "The <head> tag contains \"meta information\" and other useful tags which don't display directly on the page etc."},

    { loc: [6, 12],
      note: "The <body> tag is where we put anything we want to see in our page:"},

    { loc: [7, 11],
      note: "A <div> tag to enclose sections inside our page"},

    { loc: [8, 9],
      note: "A <h2> heading tag to define our page title"},

    { loc: [9, 10],
      note: "A <p> paragraph to enclose our page actual text contents."},

    { loc: [13, 14], note: "</html> is the definitive closing tag, it ensures we're done writing HTML in this file."},
    { loc: [13, 16], title: "Thank you!"}
  ]}
/>

  );
  }
}`
This is presentation/index.js
`

My first HTML page

My HTML page title
My HTML page content

`
and this is code.example inside assets/

Can you see if something is erroring with this line? https://github.com/thejameskyle/spectacle-code-slide/blob/master/src/CodeSlide.js#L108

hrm I'm not sure, console error yields:
scrollToElement.js:11 Uncaught TypeError: Cannot read property 'scrollTop' of undefined

This is the same error that #10. Problem is that container is undefined at time of initial scrolling. I will try to investigate it more tomorrow.

Moving to #10 since it details the issue more


[review] combine expand_args and args

http://lists.boost.org/Archives/boost/2017/04/234333.php
std::tuple as default

fixed via 6dbedb262136df0cdf0a442fbcb69b94a1f0a012


Inconsistancy in mdc-select api

Describe the bug
before v1.0.3 getSelectedValue()/setSelectedValue() returns and sets value with "any" type which is a correct value for mdc-select according to documentation. but in v1.0.3 these functions work with an "string" value while the "value" in mdc-select could be in "any" type. so I cannot set the value by an object anymore.
Expected behavior
Value should be in type "any" (like before) and the functions working with "value" should accept the type "any" instead of string.
What Angular MDC version are you using?
1.0.3
What OS are you using?:
All
What browser(s) is this bug affecting?:
All

Thanks for reporting this! On it.


Reject invalid scripts from our wallet

Fixes Issue #3205.
This PR introduces a flag to applyTx that lets us use different logic when the transaction was submitted by our local neighbor, the wallet.

@EncodePanda @Jasagredo What do you think about the new flag? Should we instead have introduced a new method? Is the naming reasonable? Should scriptsWereOK be its own class? Etc; please share your opinions -- the current decisions are just me following my initial instincts.

Once PR #3241 merges, we can rebase this and it'll change far fewer files.
It currently includes that other PR's commit because this PR will change one of the Golden test files that that PR belatedly adds.

The current commits are still reflective of my trailblazing; hence still Draft PR.
Also, this latest commit introduces some workarounds that will soon be properly provided by the ledger. The current tip is merely a proof of concept demonstrating that we can set type instance GenTx (ShelleyBlock era) = TxInBlock era.
Some Alonzo serialization golden tests fail, as expected. The Mary-to-Alonzo ThreadNet does pass; there are no Alonzo transactions in that, though, so it's not really proving much.

@nc6 @EncodePanda would you review again please. Context/reasons for Draft:

This PR's cabal.project targets input-output-hk/cardano-ledger-specs#2379 which I think will merge soon.

This PR currently includes the commits from Alexey's PR #3268, which integrates some cardano-ledger-specs changes that Clarke's upstream PR is branched off of. It will also merge soon.

I have a couple stray diffs (eg the inotify-tools) that I still need to tidy up.

@Jasagredo @nc6 I now think this is ready for merge; please do a final review. Thanks!
@EncodePanda you're welcome to review it if you need a short mixup from your Genesis focus etc, but don't feel obligated.

I addressed Clarke's comments and opened the #3276 follow-up. Rebased onto origin/master, which was automatic with no conflicts. Thanks, reviewers!

bors r+


Change counter copy from X requests to "Showing X of Y requests"

Somehow the counter only shows what is displayed on the map view not arithmetic total per country/jurisdiction.
Hacky fix: zoom out appropriately to include everyone.
Better fix: zoom out to include geopolitical correct entities + change counter copy as @nburt suggests below
https://github.com/findthemasks/findthemasks/blob/master/client/locations-list-map.js#L616-L630

The counter is synced with the total number that are visible on the map. I'm not against zooming out the default views to be more inclusive of Hawaii / Alaska (for US at least) but another thought would to change the counter copy.
Rather than "X requesters" we could have something like "Showing X of Y requesters", could be a little clearer that they don't have the full country visible

That sounds great!

For both Find the Masks and Find the Makers:
Masks: X requesters --> X of Y requests
Makers: X Groups --> X of Y maker groups


install error from source codes with anaconda

I try install the caffe2 from source codes ,so I use the command “conda build conda/cuda && conda install caffe2-cuda --use-local”. However, the error is as follows:
[ 80%] Building CXX object caffe2/CMakeFiles/caffe2_gpu.dir/sgd/iter_op_gpu.cc.o
make[2]: *** No rule to make target '/usr/local/cuda-9.0/lib64/libcudnn.so', needed by 'lib/libcaffe2_gpu.so'。 停止。
make[2]: *** 正在等待未完成的任务....
[ 80%] Building CXX object caffe2/CMakeFiles/caffe2_gpu.dir/sgd/learning_rate_op_gpu.cc.o
CMakeFiles/Makefile2:3195: recipe for target 'caffe2/CMakeFiles/caffe2_gpu.dir/all' failed
make[1]: *** [caffe2/CMakeFiles/caffe2_gpu.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
Traceback (most recent call last):
File "/home/flyfree/anaconda2/bin/conda-build", line 11, in
sys.exit(main())
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/cli/main_build.py", line 388, in main
execute(sys.argv[1:])
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/cli/main_build.py", line 379, in execute
verify=args.verify)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/api.py", line 185, in build
need_source_download=need_source_download, config=config, variants=variants)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/build.py", line 1776, in build_tree
notest=notest,
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/build.py", line 1122, in build
utils.check_call_env(cmd, env=env, cwd=src_dir)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/utils.py", line 676, in check_call_env
return _func_defaulting_env_to_os_environ(subprocess.check_call, *popenargs, **kwargs)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/utils.py", line 672, in _func_defaulting_env_to_os_environ
return func(_args, **kwargs)
File "/home/flyfree/anaconda2/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/bin/bash', '-e', '/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1520914363644/work/conda_build.sh']' returned non-zero exit status 2

Where are your CUDA and CuDNN installations? Can you post the cmake output, which should say where Caffe2 found CUDA and CuDNN during the build process?

@pjh5 I try to install the caffe2 again. but the new error appear is as follows:
[ 78%] Building CXX object caffe2/CMakeFiles/caffe2_pybind11_state_gpu.dir/python/pybind_state.cc.o
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:32,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.cc:17:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1190:0: warning: "_POSIX_C_SOURCE" redefined
#define _POSIX_C_SOURCE 200112L
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/utility:68,
from /usr/include/c++/5/unordered_map:38,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.cc:17:
/usr/include/features.h:228:0: note: this is the location of the previous definition
define _POSIX_C_SOURCE 200809L
^
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:32,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.cc:17:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1212:0: warning: "_XOPEN_SOURCE" redefined
#define _XOPEN_SOURCE 600
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/utility:68,
from /usr/include/c++/5/unordered_map:38,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.cc:17:
/usr/include/features.h:169:0: note: this is the location of the previous definition
define _XOPEN_SOURCE 700
^
[ 78%] Linking CXX executable ../bin/context_test
[ 78%] Linking CXX executable ../bin/smart_tensor_printer_test
../lib/libcaffe2.so：对‘leveldb::Status::ToStringabi:cxx11 const’未定义的引用
../lib/libcaffe2.so：对‘google::SetUsageMessage(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)’未定义的引用
../lib/libcaffe2.so：对‘leveldb::DB::Open(leveldb::Options const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, leveldb::DB**)’未定义的引用
../lib/libcaffe2.so：对‘google::base::CheckOpMessageBuilder::NewStringabi:cxx11’未定义的引用
collect2: error: ld returned 1 exit status
caffe2/CMakeFiles/context_test.dir/build.make:115: recipe for target 'bin/context_test' failed
make[2]: *** [bin/context_test] Error 1
CMakeFiles/Makefile2:1440: recipe for target 'caffe2/CMakeFiles/context_test.dir/all' failed
make[1]: *** [caffe2/CMakeFiles/context_test.dir/all] Error 2
make[1]: *** 正在等待未完成的任务....
[ 78%] Building CXX object caffe2/CMakeFiles/caffe2_pybind11_state_gpu.dir/python/pybind_state_dlpack.cc.o
../lib/libcaffe2.so：对‘leveldb::Status::ToStringabi:cxx11 const’未定义的引用
../lib/libcaffe2.so：对‘google::SetUsageMessage(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)’未定义的引用
../lib/libcaffe2.so：对‘leveldb::DB::Open(leveldb::Options const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, leveldb::DB**)’未定义的引用
../lib/libcaffe2.so：对‘google::base::CheckOpMessageBuilder::NewStringabi:cxx11’未定义的引用
collect2: error: ld returned 1 exit status
caffe2/CMakeFiles/smart_tensor_printer_test.dir/build.make:115: recipe for target 'bin/smart_tensor_printer_test' failed
make[2]: *** [bin/smart_tensor_printer_test] Error 1
CMakeFiles/Makefile2:1356: recipe for target 'caffe2/CMakeFiles/smart_tensor_printer_test.dir/all' failed
make[1]: *** [caffe2/CMakeFiles/smart_tensor_printer_test.dir/all] Error 2
[ 78%] Building CXX object caffe2/CMakeFiles/caffe2_pybind11_state_gpu.dir/python/pybind_state_mkl.cc.o
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.cc:17:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1190:0: warning: "_POSIX_C_SOURCE" redefined
#define _POSIX_C_SOURCE 200112L
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/cstdlib:41,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/core/context.h:20,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.cc:17:
/usr/include/features.h:228:0: note: this is the location of the previous definition
define _POSIX_C_SOURCE 200809L
^
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.cc:17:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1212:0: warning: "_XOPEN_SOURCE" redefined
#define _XOPEN_SOURCE 600
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/cstdlib:41,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/core/context.h:20,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.cc:17:
/usr/include/features.h:169:0: note: this is the location of the previous definition
define _XOPEN_SOURCE 700
^
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:32,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_mkl.cc:23:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1190:0: warning: "_POSIX_C_SOURCE" redefined
#define _POSIX_C_SOURCE 200112L
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/utility:68,
from /usr/include/c++/5/unordered_map:38,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_mkl.cc:23:
/usr/include/features.h:228:0: note: this is the location of the previous definition
define _POSIX_C_SOURCE 200809L
^
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:32,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_mkl.cc:23:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1212:0: warning: "_XOPEN_SOURCE" redefined
#define _XOPEN_SOURCE 600
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/utility:68,
from /usr/include/c++/5/unordered_map:38,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_mkl.cc:23:
/usr/include/features.h:169:0: note: this is the location of the previous definition
define _XOPEN_SOURCE 700
^
[ 79%] Linking CXX executable ../bin/net_gpu_test
../lib/libcaffe2.so：对‘leveldb::Status::ToStringabi:cxx11 const’未定义的引用
../lib/libcaffe2.so：对‘google::SetUsageMessage(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)’未定义的引用
../lib/libcaffe2_gpu.so：对‘google::FlagRegisterer::FlagRegisterer<std::__cxx11::basic_string<char, std::char_traits, std::allocator > >(char const*, char const*, char const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >)’未定义的引用
../lib/libcaffe2.so：对‘leveldb::DB::Open(leveldb::Options const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, leveldb::DB**)’未定义的引用
../lib/libcaffe2_gpu.so：对‘google::base::CheckOpMessageBuilder::NewStringabi:cxx11’未定义的引用
collect2: error: ld returned 1 exit status
caffe2/CMakeFiles/net_gpu_test.dir/build.make:115: recipe for target 'bin/net_gpu_test' failed
make[2]: *** [bin/net_gpu_test] Error 1
CMakeFiles/Makefile2:1398: recipe for target 'caffe2/CMakeFiles/net_gpu_test.dir/all' failed
make[1]: *** [caffe2/CMakeFiles/net_gpu_test.dir/all] Error 2
[ 79%] Building CXX object caffe2/CMakeFiles/caffe2_pybind11_state_gpu.dir/python/pybind_state_gpu.cc.o
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:32,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_gpu.cc:24:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1190:0: warning: "_POSIX_C_SOURCE" redefined
#define _POSIX_C_SOURCE 200112L
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/utility:68,
from /usr/include/c++/5/unordered_map:38,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_gpu.cc:24:
/usr/include/features.h:228:0: note: this is the location of the previous definition
define _POSIX_C_SOURCE 200809L
^
In file included from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/Python.h:8:0,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/detail/common.h:111,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pytypes.h:12,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/cast.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/attr.h:13,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/third_party/pybind11/include/pybind11/pybind11.h:43,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_dlpack.h:25,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:32,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_gpu.cc:24:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/python2.7/pyconfig.h:1212:0: warning: "_XOPEN_SOURCE" redefined
#define _XOPEN_SOURCE 600
^
In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/os_defines.h:39:0,
from /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h:482,
from /usr/include/c++/5/utility:68,
from /usr/include/c++/5/unordered_map:38,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state.h:19,
from /home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/caffe2/python/pybind_state_gpu.cc:24:
/usr/include/features.h:169:0: note: this is the location of the previous definition
define _XOPEN_SOURCE 700
^
cc1plus: warning: unrecognized command line option ‘-Wno-invalid-partial-specialization’
cc1plus: warning: unrecognized command line option ‘-Wno-invalid-partial-specialization’
cc1plus: warning: unrecognized command line option ‘-Wno-invalid-partial-specialization’
cc1plus: warning: unrecognized command line option ‘-Wno-invalid-partial-specialization’
[ 79%] Linking CXX shared module python/caffe2_pybind11_state_gpu.so
[ 79%] Built target caffe2_pybind11_state_gpu
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
Traceback (most recent call last):
File "/home/flyfree/anaconda2/bin/conda-build", line 11, in
sys.exit(main())
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/cli/main_build.py", line 388, in main
execute(sys.argv[1:])
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/cli/main_build.py", line 379, in execute
verify=args.verify)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/api.py", line 185, in build
need_source_download=need_source_download, config=config, variants=variants)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/build.py", line 1776, in build_tree
notest=notest,
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/build.py", line 1122, in build
utils.check_call_env(cmd, env=env, cwd=src_dir)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/utils.py", line 676, in check_call_env
return _func_defaulting_env_to_os_environ(subprocess.check_call, *popenargs, **kwargs)
File "/home/flyfree/anaconda2/lib/python2.7/site-packages/conda_build/utils.py", line 672, in _func_defaulting_env_to_os_environ
return func(_args, **kwargs)
File "/home/flyfree/anaconda2/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/bin/bash', '-e', '/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521114404271/work/conda_build.sh']' returned non-zero exit status 2
The location my cuda had installed is at 'usr/local'

This is now #1980 . Have you pulled the latest code since yesterday? What is gcc --version?

What directory are you running the command from that makes that error?
What is LD_LIBRARY_PATH and PYTHONPATH?
Can you run find /home/flyfree/anaconda2 -name libcaffe2.so

Sorry, the error information  I presented is wrong,it should be as following:
mkdir -p build && cd build && cmake .. && make -j4
-- Caffe2: Found gflags with new-style gflags target.
-- Caffe2: Cannot find glog automatically. Using legacy find.
-- Caffe2: Found glog (include: /home/flyfree/anaconda2/include, library: /home/flyfree/anaconda2/lib/libglog.so)
-- Caffe2: Found protobuf with old-style protobuf targets.
-- Caffe2: Protobuf version
-- Caffe2: CUDA detected: 9.0
-- Found cuDNN: v7.0.5  (include: /usr/local/cuda-9.0/include, library: /usr/local/cuda-9.0/lib64/libcudnn.so)
-- Added CUDA NVCC flags for: sm_30 sm_35
-- CUDA detected: 9.0
-- Added CUDA NVCC flags for: sm_30 sm_35
-- Found libcuda: /usr/local/cuda-9.0/lib64/stubs/libcuda.so
-- Found libnvrtc: /usr/local/cuda-9.0/lib64/libnvrtc.so
-- Found cuDNN: v7.0.5  (include: /usr/local/cuda-9.0/include, library: /usr/local/cuda-9.0/lib64/libcudnn.so)
-- Summary:
--   CMake version        : 3.5.1
--   CMake command        : /usr/bin/cmake
--   System name          : Linux
--   C++ compiler         : /usr/bin/c++
--   C++ compiler version : 5.4.0
--   CXX flags            :  -std=c++11 -O2 -fPIC -Wno-narrowing
--   Caffe2 version       : 0.8.2
--   Caffe2 include path  : /home/flyfree/anaconda2/include
--   Have CUDA            : TRUE
--     CUDA version       : 9.0
--     CuDNN version      : 7.0.5
-- Configuring done
-- Generating done
-- Build files have been written to: /home/flyfree/detectron/lib/build
make[1]: Entering directory '/home/flyfree/detectron/lib/build'
make[2]: Entering directory '/home/flyfree/detectron/lib/build'
make[3]: Entering directory '/home/flyfree/detectron/lib/build'
make[3]: Entering directory '/home/flyfree/detectron/lib/build'
[ 20%] Building NVCC (Device) object CMakeFiles/caffe2_detectron_custom_ops_gpu.dir/ops/caffe2_detectron_custom_ops_gpu_generated_zero_even_op.cu.o
nvcc fatal   : redefinition of argument 'std'
CMake Error at caffe2_detectron_custom_ops_gpu_generated_zero_even_op.cu.o.cmake:203 (message):
Error generating
/home/flyfree/detectron/lib/build/CMakeFiles/caffe2_detectron_custom_ops_gpu.dir/ops/./caffe2_detectron_custom_ops_gpu_generated_zero_even_op.cu.o
CMakeFiles/caffe2_detectron_custom_ops_gpu.dir/build.make:63: recipe for target 'CMakeFiles/caffe2_detectron_custom_ops_gpu.dir/ops/caffe2_detectron_custom_ops_gpu_generated_zero_even_op.cu.o' failed
make[3]: *** [CMakeFiles/caffe2_detectron_custom_ops_gpu.dir/ops/caffe2_detectron_custom_ops_gpu_generated_zero_even_op.cu.o] Error 1
make[3]: Leaving directory '/home/flyfree/detectron/lib/build'
CMakeFiles/Makefile2:104: recipe for target 'CMakeFiles/caffe2_detectron_custom_ops_gpu.dir/all' failed
make[2]: *** [CMakeFiles/caffe2_detectron_custom_ops_gpu.dir/all] Error 2
make[2]: *** 正在等待未完成的任务....
make[3]: Leaving directory '/home/flyfree/detectron/lib/build'
[ 60%] Built target caffe2_detectron_custom_ops
make[2]: Leaving directory '/home/flyfree/detectron/lib/build'
Makefile:127: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/home/flyfree/detectron/lib/build'
Makefile:13: recipe for target 'ops' failed
make: *** [ops] Error 2

the path I run the command 'make ops' is ~/detectron/lib$.
the  information is as follows:
export PATH="/home/freefly/anaconda2/bin:$PATH"
export PATH="~/anaconda2/bin:$PATH"
export PATH=/usr/local/cuda-9.0/bin${PATH:+:${PATH}}
export LD_LIBRARY_PATH=/usr/local/cuda-9.0/lib64${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}
export LD_LIBRARY_PATH="/lib/x86_64-linux-gnu:$LD_LIBRARY_PATH"
export PATH="~/anaconda2/conda-bld/caffe2-cuda_1520429019012/work/build:$PATH"

added by Anaconda2 installer
export PATH="/home/flyfree/anaconda2/bin:$PATH"
3.After I run the command you said ,the result is as follows:
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521169513805/work/build/lib/libcaffe2.so
/home/flyfree/anaconda2/conda-bld/caffe2-cuda_1521177360911/work/build/lib/libcaffe2.so
/home/flyfree/anaconda2/pkgs/caffe2-cuda-0.8.dev-py27hae06318_0/lib/libcaffe2.so
/home/flyfree/anaconda2/lib/libcaffe2.so

/home/flyfree/anaconda2/bin is the same as ~/anaconda2/bin, so you are adding /home/flyfree/anaconda2/bin to your path three times; it should only be added once.
~/anaconda2/conda-bld/caffe2-cuda_1520429019012/work/build should definitely NOT be in your path. No folder under ~/anaconda2/conda-bld should ever be added to your PATH or LD_LIBRARY_PATH.
Can you run which nvcc and nvcc --version ?
Is this on Ubuntu?


[Bug] Objects without any key can also be flatted, causing the control display to error

Hi, I have solved this problem.
reproduce:
just
const meta = {
  component: YourComponent,
  argTypes: {
    style: { control: 'object' },
    'config.fetchParam': {
      control: 'object'
    },
    'config.jumpParam': {
      control: 'object',
    },
  } as ArgTypes,
  parameters: {
    deepControls: { enabled: true },
  },
} satisfies Meta<typeof YourComponent>;

export const Default: Story = {
  args: {
    data: {
      fetchParam: {}, // 1. will be fixed in this pr!
      jumpParam: {a:1}, // 2. There is still an issue that requires the user to explicitly set argTypes manually. fixed
    },
    style: {}, // 3. As predicted, showed
    data: {}, // 4. As predicted, argTypes must be set explicitly manually
  },
};

bug:

Desired result:

@eric-gitta-moore thanks for raising this, I've considered the issue you raised and your PR and from what I can see there are 2 issues you are trying to address:
1 - An empty initial arg value will produce an object control with an empty object
You describe this as "causing the control display to error" however I don't agree its an error. I think preventing this happening means the addon will prevent some use-cases where the value can be any object.
For example, if we look at the example you provided, there is a property called style which has an initial value as an empty object. I don't think it would be practical for initial values to be defined for every possible style, so an empty object control seems like the right thing for the user to customise the value however they want. An alternative is to explicitly define an argType so this shows as an empty object, however I think its just adding extra steps and also it is easy to make an error, e.g.  in the argTypes you defined 'config.jumpParam' but the value actually has 'data.jumpParam', so the argTypes will be creating a new unexpected object.
I think the experience is better and more accurate if the controls are inferred from the values, so I don't think we should hide empty objects as they could be intentional.
2 - An object with some of its properties defined with argTypes shouldn't be flattened
I got this from the changes in your PR, let me know if I have misunderstood.
This actually relates to the main example in the documentation, ie
export const SomeStory = {
  args: {
    someObject: {
      anyString: "string",
      enumString: "string", // we only want specific values for this
    },
  },
  argTypes: {
    // so we define an argType for the property to use a radio control with specific values
    "someObject.enumString": {
      control: "radio",
      options: ["value1", "value2", "value3"],
    },
  },
};

Which produces:

If we made the change you suggest then this example would not flatten. I think its useful to be able to specify more specific types for some properties in an object and still have all the other properties flattened using the default logic, so I don't think we should make this change also.
I'm going to close this as wont do, however if you disagree please feel free to raise separate issue(s), one for each the 2 separate points above.


Join on multiple columns not working

I have a join on a subquery like this:
q_subquery = get_subquery().as_("q_subquery")
q = q.join(q_subquery).on(t_agg.x_id == q_subquery.x_id and t_agg.y_id == q_subquery.y_id)

For some reason, in the SQL generated only the second join condition is contained.
Am I doing the join the wrong way or is this a bug?

Seems you need to use & instead of and, will try this next week.

Yeah, try it with & instead of "and"

Did using & resolve your issue? you will likely have to make sure that () are around the terms that you are comparing


v13

When will discord.js-light support v13?

master version supports v13, you can install it with npm install timotejroiko/discord.js-light
when v13 is officially released, then discord.js-light v4 will also be released.

Will it work with the recent removal of Structures from Discord.JS? I'm asking because I noticed that that seems to be how this library works:

Where they removed Structures: #6027

there are other ways to make it work


BSP: Mill build Scala lib dep and forward env vars to server start

This fixes:

Some redness with the .sc files because if the missing Scala lib as dependency.
The BSP server boot command to forward the env vars. That's useful when you set env vars like JAVA_OPTS or COURSIER_REPOSITORIES.

Thanks

@lefou @lihaoyi This is ready to review


Problems in Facebook Marketing source with insights stream

Environment

Deploy method: docker-compose.yml
Jitsu version:  1.44.2
OS: KDE Plasma 5

Description
Hi!
I am trying to configure Facebook Marketing source, with some clients (a using previous version) it works perfectly, but with one specific client, insights streams breaks when finishing interval to sync.
To take into account, I am trying to write to a Clickhouse database.
Steps to reproduce

Connect Facebook Marketing.
Add insights stream with all fields at "ad" data.

Expected behavior
Write on table
Actual behavior
I am posting the log error message:
2023-03-31 08:17:57 [INFO]: [task:z7a7ry0utldswa5acd0grz_facebook_marketing_insights_9f5eb5f5_ceef_4562_b1cc_ce494e66a1ba]: Running [UTC_DAY_2023-03-31] synchronization 2023-03-31 08:18:40 [INFO]: [task:z7a7ry0utldswa5acd0grz_facebook_marketing_ads_ecfe427c_ea8b_4926_a334_244a18828819]: 0% Loading objects [1..1201] of 1201 to destinations ... 2023-03-31 08:18:41 [INFO]: [task:z7a7ry0utldswa5acd0grz_facebook_marketing_ads_ecfe427c_ea8b_4926_a334_244a18828819]: Flushing batch - adding 1201 objects to [facebook_marketing_ads]. Storage=[z7a7ry0utldswa5acd0grz.ym3heqofomb0i8qt5x10ui7] Attempt: 1 of 2 2023-03-31 08:18:41 [INFO]: [task:z7a7ry0utldswa5acd0grz_facebook_marketing_ads_ecfe427c_ea8b_4926_a334_244a18828819]: Chunk completed. 2023-03-31 08:18:41 [INFO]: [task:z7a7ry0utldswa5acd0grz_facebook_marketing_ads_ecfe427c_ea8b_4926_a334_244a18828819]: Interval [UTC_ALL_ALL] has been synchronized! 2023-03-31 08:18:41 [INFO]: [task:z7a7ry0utldswa5acd0grz_facebook_marketing_ads_ecfe427c_ea8b_4926_a334_244a18828819]: FINISHED SUCCESSFULLY in [44.62] seconds (~ 0.74 minutes) 2023-03-31 08:18:41 [INFO]: [z7a7ry0utldswa5acd0grz_facebook_marketing_ads_ecfe427c_ea8b_4926_a334_244a18828819] FINISHED SUCCESSFULLY in [44.62] seconds (~ 0.74 minutes) 2023-03-31 08:18:47 [INFO]: [queue: destination_clickhouse_z7a7ry0utldswa5acd0grz.ym3heqofomb0i8qt5x10ui7] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_recognition] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_identified] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:47 [INFO]: [queue: users_aggregated] current size: 0 2023-03-31 08:18:48 [INFO]: Processing of 0 files finished in 53.251µs 2023-03-31 08:19:01 [ERROR]: [z7a7ry0utldswa5acd0grz_facebook_marketing_insights_9f5eb5f5_ceef_4562_b1cc_ce494e66a1ba] Error [UTC_DAY_2023-03-31] synchronization: facebook: An unknown error occurred (code: 1; error_subcode: 99, error_user_title: , error_user_msg: ) 2023-03-31 08:19:01 [ERROR]: [task:z7a7ry0utldswa5acd0grz_facebook_marketing_insights_9f5eb5f5_ceef_4562_b1cc_ce494e66a1ba]: Error [UTC_DAY_2023-03-31] synchronization: facebook: An unknown error occurred (code: 1; error_subcode: 99, error_user_title: , error_user_msg: )
Moreover, in UI, error is no so descriptive:
2023-03-31 08:32:11 [INFO ] - Running [UTC_DAY_2023-03-31] synchronization
2023-03-31 08:33:14 [ERROR] - Error [UTC_DAY_2023-03-31] synchronization: facebook: An unknown error occurred (code: 1; error_subcode: 99, error_user_title: , error_user_msg: )

Thank you !

We built beta image where enabled airbyte version of Facebook Marketing source.
It is currently hidden behind 'Show deprecated sources' switch.
Only downside of this version that with Jitsu it's not possible to setup custom reports.
Can you please switch docker-compose to use beta tag of jitsu image and check whether this version of Facebook Marketing source works for you?


cytools error solution

Hello Patrick, I've written a new article on medium explaining everything about cytools error we talked about, I added a link to the article on the course index.

Awesome article and pull request! Could we actually add this article to the chronological issues file? If we add it to the bottom like in this PR, we are splitting where people should go when they run into issues. Ideally they'd first look in that chronological file when they run into issues installing python.

Yes you are right I'll change it to there then, thanks.


CEO-176 Add plot/sample file names to review page

Purpose

Show the plot/sample file names in the Project Review page.
Related Issues
Closes CEO-176
Screenshots

src/js/project/SampleDesign.js
224, does it make sense to just always add the tooltip?
src/js/project/PlotDesign.js
406, does it make sense to just always add the tooltip?


Bump golang.org/x/net to v0.7.0

Fixes CVE CVE-2022-41723

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?

Additional Notes for your reviewer:
Review Checklist:

[ ] Follows the developer guidelines
[ ] Relevant tests are added or updated
[ ] Relevant docs in this repo added or updated
[ ] Relevant carvel.dev docs added or updated in a separate PR and there's
a link to that PR
[ ] Code is at least as readable and maintainable as it was before this
change

Additional documentation e.g., Proposal, usage docs, etc.:

LGTM! (I am surprised that dependabot didn’t create a PR for this.)

 I think so long as we keep relatively up-to-date and the minors don't always introduce breaking changes, we can stick to minor updates by dependabot also

spoke too soon! Dependabot has made me obsolete. Closing in favour of https://github.com/carvel-dev/kapp-controller/pull/1110


Decouple GLUE entry point saving and loading logic

Currently, the GLUE entry point doesn't allow one to load from object store but save locally -- the saving and loading logic are tied to each other. This is a use case for our open-source users who may want to load a pre-trained checkpoint from object store but do not possess the credentials to write back to object store.
This PR removes this coupling, allowing for as much flexibility as the original composer entry point allows for.

(1) Did you test this locally with the new load locally functionality? It is always good to state this explicitly in the PR description.
Yes, tested locally with the new functionality. Will update the PR description!

(2) Do we have any test coverage for this entry point? I was hoping to see a new/updated test with this PR that confirms the change is tested. If we do not have a test we probably need to add one, even if basic, so that this entry point is not accidentally broken in the future. You can also add test coverage in another PR if you prefer.
Discussed with others offline and decided that unit tests were not necessary for v0 of the entrypoint since most of the tests would be on argparsing correctly. Will file a JIRA to make a more thorough testing scheme for this entrypoint.


Release 1.6.1

Fixes a bug - no review needed for the release.

Coverage: 31.601%. Remained the same when pulling 260d561b7188af1858ac99d2b8e7fa43811fbb0b on release_1.6.1 into 24a8a4e7a0568bb4a9188c0cb528d6e186f90a60 on stable_1.6.


Create KeyCertBundle

Use a KeyCertBundle to store the CA's key/certs in it, so that when the CA key/certs are rotated (in integrated mode), the CA is able to get the new key/certs seamlessly and consistently.

@myidpt: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
99999d2c091a3cd13225e2b955bcf91a1b7b252d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
99999d2c091a3cd13225e2b955bcf91a1b7b252d
link
/test istio-presubmit

prow/istio-unit-tests.sh
99999d2c091a3cd13225e2b955bcf91a1b7b252d
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
99999d2c091a3cd13225e2b955bcf91a1b7b252d
link
/test istio-presubmit

prow/istio-unit-tests.sh
d011e4a95358f77600a6b843f2410f91649ede2e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d011e4a95358f77600a6b843f2410f91649ede2e
link
/test istio-unit-tests

prow/istio-presubmit.sh
d011e4a95358f77600a6b843f2410f91649ede2e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d011e4a95358f77600a6b843f2410f91649ede2e
link
/test istio-presubmit

prow/istio-unit-tests.sh
84df53068b3ce09faed19f35a8032f68613e0585
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Generally lgtm, but just curious, it seems this PR combine several key/cert into a structure, but how to achieve "CA is able to get the new key/certs seamlessly and consistently."?
/lgtm

It's mostly about the consistency. I'm using RWMutex to protect the access to the KeyCertBundle. Also, all values are read altogether through GetAll() or GetAllPem(), this avoids reading different cert/key out while another thread is doing the update. Seamlessly means the CA doesn't need to maintain Mutex for access control :)
Does this make sense?

It makes more sense now, thanks for the clarification.

Great, thank you!


Building error:

Hi Jezzamonn,
I follow the step, npm i then npm run build.
Now I got this error, Is there anything I missed?
I am using Windows 11, node version 18, npm version 8.18.
Thank you!
PS C:\Users\User\Desktop\molly\github\ld-base>npm run build

><EMAIL_ADDRESS>build
> npm-run-all --parallel webpack sass static sprites music

><EMAIL_ADDRESS>webpack
> webpack

><EMAIL_ADDRESS>sass
> mkdir -p build/client/css && sass src/scss/styles.scss build/client/css/styles.css

><EMAIL_ADDRESS>static
> mkdir -p build/client/ && rsync -a --delete --exclude js/ --exclude css/ --exclude sprites/ --exclude music/ src/static/ build/client/

><EMAIL_ADDRESS>music
> mkdir -p build/client/music && rsync --delete -a --include='*.mp3' --exclude='*/' --exclude='*' music/ build/client/music/

><EMAIL_ADDRESS>sprites
> mkdir -p build/client/sprites && rsync -a --delete --exclude '*.aseprite' sprites/ build/client/sprites/

The command syntax is incorrect.
The command syntax is incorrect.
The command syntax is incorrect.
The command syntax is incorrect.

ERROR: "sass" exited with 1.

I don't know why but it works now.


Move the react grid components from the 'src/utility/' folder to the 'src/components/' folder.

No longer relevant in v0.3.0+.


Unable to pass process properties to systemd

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 4.10.12
Ruby: 2.1.9
Distribution: Ubuntu
Module version: 1.7.0

How to reproduce (e.g Puppet code you use)
N/A - Not a bug.
What are you seeing
N/A - Not a bug.
What behaviour did you expect instead
I'd like to suggest we add the ability to pass Process properties to Systemd; i.e. LimitRTPRIO/LimitLOCKS. This would be a key/value pair that would be optional.
I was thinking about adding an optional hash to jenkins::slave that would pass said hash to jenkins-slave.service.erb.
If you'd be open to said change, let me know. I'll be happy to create a pull-request for said behavior.
Output log
Any additional information you'd like to impart

@madelaney Sounds reasonable and we would be happy about a pull request.

The suggested solution is systemd drop ins or a patch that implements this. Closing the issue for now.


Memory leaks

2MB of ram leaks every 5 min.
Suspicion

The Notice Watcher, a new feature introduced few days ago

I hope this issue will be fixed soon :(

Gotcha!! 🐶

Good News
It reaches 149~150mb and it seems not growing anymore. Total memory consumption also stops at 840~842mb.

Bad News
It keeps eating more and more memories.

Total memory consumption grows to 1GB (mostly eaten up by mysqld). But still the eodiro-server consumes 150~155mb.

Witnessed duplicate Puppeteer Chromium instances.

Wow!! You're such a wonderful kid, I thought you'd do it
Now that surprised puppy is smiling

Stops at ~500mb

This issue was produced by Zombie.js (https://github.com/assaf/zombie/issues/672)
It will be replaced by Puppeteer in the next release.

@JeongBin0227, thanks for participating

Wow! It's really a celebration.

It's so cute, I can't even see my teeth


Update docstrings in client-superstaq

What is happening?
From Open-Beta week: "Update docstrings in client --> add docstrings to methods and classes (make sure there are no pragmas for disabling docstrings in clients)" ~(also do this server-side, unless that's already done?)~

Remove #pylint from test functions and add a single #pylint at the top of each test file
Update old docstrings
Review @pgoiporia's docstring spreadsheet and confirm changes

What are the current alternatives?
None.
Any additional context?
None.

Server-side updates are big enough to be it's own issue. I've re-titled this one to be more specific.

@dowusu-antwi
I think PR #565 should address the first bullet point and I am currently looking at files that require docstrings (I knew already for example that ops/qubit_gates.py requires it). Should we make a checklist here or do you have a suggestion on how we should proceed?

Sounds good, thanks!

Should we make a checklist here or do you have a suggestion on how we should proceed?

I think we can use the spreadsheet checklist Palash made (he mentioned it probably need updates).

@dowusu-antwi, going through the Excel file, all docstrings look to be fairly complete after merging #503 & #513. Further updates imo would mostly be of the 'nit kind' and increased conformity to the dev guide at the moment.

To keep track:

Remove #pylint from test functions and add a single #pylint at the top of each test file

Completed by https://github.com/Infleqtion/client-superstaq/pull/565 & https://github.com/Infleqtion/client-superstaq/pull/578

Update old docstrings

Addressed by #585, #588, #589, #590, & #591.

Review @pgoiporia's docstring spreadsheet and confirm changes

Done (spreadsheet also updated now).
This issue can be closed imo from merging the PRs listed above.


Update to be python-3.8.2 compatible

Validated with latest python buildpack. Also updated the README file.

@cdelashmutt-pivotal  - Can you take a look at the PR? Thanks


Availability for mobile app should be Summer 2021 not Summer 2020

In the paragraph that mentions availability for Viva Connections on Mobile should say Summer 2021 instead of 2020.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7210783d-e96e-9d14-9120-553f731d20ed
Version Independent ID: 84854221-f26b-4a19-b95e-0d5d7c640a46
Content: Add Viva Connections for Microsoft Teams desktop - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/viva-connections.md
Service: sharepoint-online
GitHub Login: @Holland-ODSP
Microsoft Alias: hokavian

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


docs:fixed two typos inside Dangers of mutability

Summary

fixed two typos in "Dangers of mutability"
"we've have" -> "we have"
"consiquences" -> "consequences"

@rmorshea This was my first ever pull request, feeling really happy

@danish-mehmood that's great to hear! Looking forward to seeing more from you in the future.

@rmorshea you sure will


Change CockroachCloud abbreviation to CC

Fixes #7122.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a0abfaaa62473e7b4ccd86e1c59bbc55e4b35041/


var_name_filter parameter of full pipeline is not passed correctly to filter_with_hvg component.

This was fixed with https://github.com/openpipelines-bio/openpipeline/commit/03a14c2024c2f4da4557f09d651fd488309988a8


Distribute as Flatpak

Please add a Flatpak build and distribute on Flathub. As an example, you can start with the manifest of the GTK4+Rust app NewsFlash.

Can I ask on what OS are you trying to use Pidif?

Mobian on PinePhone.

I'm sorry but it doesn't seem like I'm going to get to this anytime soon, as I've never used Flatpak myself and I have no idea how it works. If anyone submits a PR for that I would happily merge it (if it's even related to the project itself?). I'll leave this issue open in case someone wants to take it.

Could you create a meson.build file similar to NewsFlash? This also seems to be what GNOME Rust+Gtk4 apps use...


Site has more holes than a block of swiss cheese

I'd appreciate if meaningful issues are raised. Thanks

🧀


NOTICK - Use official postgres docker image for combined worker

Use official postgres docker image to resolve M1/ARM issues.

LGTM
Looking at the rest of this file, I see that it's already re-using bits of logic from the CLI but I can't help feeling there could be more.

Yes, see note in the top of the file.
It was explicitly kept as simple as possible as it was unclear what the desired experience should be in terms of what/when/how things get bootstrapped in the combined-worker vs. the cluster.
This is something that @mattbradburyr3 's team should be driving I think. If it ends up being so that the cli and this shares the same functionality, we need to refactor it so there's a common library.


Ability to see folder sizes

Is your feature request related to a problem? Please describe.
Navigating through papermerger, I need to know if a folder is empty before deleting etc. Currently having to enter the folder then exit it to check.
Describe the solution you'd like
Column in List view which displays the folder sizes

Hi @AlexanderEDavis,
Your suggestion definitely makes sense. However, this feature it is a little bit more tricky to implement correctly - the reason is that folders are recursive in nature and whenever a new document is added/removed the size field need to be recursively updated.
I will make sure that this feature will be part of 1.6 release (planned for late November 2020).
Thank you for opening this feature request!


build: Update Vulkan-Headers 1.3.245

This change also updates the code generation scripts to match the latest from Vulkan-ValidationLayers

CI Vulkan-ExtensionLayer build queued with queue ID 46564.

CI Vulkan-ExtensionLayer build # 297 running.

CI Vulkan-ExtensionLayer build queued with queue ID 46572.

CI Vulkan-ExtensionLayer build queued with queue ID 46572.

CI Vulkan-ExtensionLayer build queued with queue ID 46573.

CI Vulkan-ExtensionLayer build queued with queue ID 46573.

CI Vulkan-ExtensionLayer build # 300 running.

CI Vulkan-ExtensionLayer build # 300 failed.

Weird problems in generated code:
/home/lunarg/.jenkins/wvel/Release64/Vulkan-ExtensionLayer/utils/generated/vk_safe_struct.cpp: In constructor âsafe_VkAccelerationStructureTrianglesDisplacementMicromapNV::safe_VkAccelerationStructureTrianglesDisplacementMicromapNV(const VkAccelerationStructureTrianglesDisplacementMicromapNV*)â:
/home/lunarg/.jenkins/wvel/Release64/Vulkan-ExtensionLayer/utils/generated/vk_safe_struct.cpp:56190:59: warning: left operand of comma operator has no effect [-Wunused-value]
56190 |         ppUsageCounts = new VkMicromapUsageEXT[in_struct->usageCountsCount,1];
      |                                                ~~~~~~~~~~~^~~~~~~~~~~~~~~~
/home/lunarg/.jenkins/wvel/Release64/Vulkan-ExtensionLayer/utils/generated/vk_safe_struct.cpp:56190:25: error: cannot convert âVkMicromapUsageEXT*â to âconst VkMicromapUsageEXT* const*â in assignment
56190 |         ppUsageCounts = new VkMicromapUsageEXT[in_struct->usageCountsCount,1];
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                         |
      |                         VkMicromapUsageEXT*
/home/lunarg/.jenkins/wvel/Release64/Vulkan-ExtensionLayer/utils/generated/vk_safe_struct.cpp:56191:130: error: too many arguments to function âvoid* memcpy(void*, const void*, size_t)â
56191 |         memcpy ((void *)ppUsageCounts, (void *)in_struct->ppUsageCounts, sizeof(VkMicromapUsageEXT)*in_struct->usageCountsCount,1);
      |                                                                                ^
In file included from /usr/include/features.h:461,

Weird problems in generated code:

@mikes-lunarg

Weird problems in generated code:

I had to manually add a safe struct workaround to VVL for this https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/2cd22aa2add2b4dcf1dc422c880bcca97220578d#diff-6cb4072fbb883af4aa2e29886c4425a795cf86487bdd9920aba0404c1a1dc0f8R1466-R1477

CI Vulkan-ExtensionLayer build queued with queue ID 46674.

CI Vulkan-ExtensionLayer build queued with queue ID 46674.

Weird problems in generated code:

I had to manually add a safe struct workaround to VVL for this KhronosGroup/Vulkan-ValidationLayers@2cd22aa#diff-6cb4072fbb883af4aa2e29886c4425a795cf86487bdd9920aba0404c1a1dc0f8R1466-R1477

I updated the scripts directory to match VVL again, seems to be working now.

CI Vulkan-ExtensionLayer build # 301 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 46686.

CI Vulkan-ExtensionLayer build queued with queue ID 46686.

CI Vulkan-ExtensionLayer build # 302 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 46695.

CI Vulkan-ExtensionLayer build # 303 running.

CI Vulkan-ExtensionLayer build # 303 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 46741.

CI Vulkan-ExtensionLayer build queued with queue ID 46741.

CI Vulkan-ExtensionLayer build # 304 running.

CI Vulkan-ExtensionLayer build # 304 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 46789.

CI Vulkan-ExtensionLayer build # 305 running.

CI Vulkan-ExtensionLayer build # 305 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 47354.

CI Vulkan-ExtensionLayer build queued with queue ID 47354.

CI Vulkan-ExtensionLayer build # 306 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 47378.

CI Vulkan-ExtensionLayer build queued with queue ID 47378.

CI Vulkan-ExtensionLayer build # 307 running.

CI Vulkan-ExtensionLayer build # 307 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 47406.

CI Vulkan-ExtensionLayer build # 308 running.

CI Vulkan-ExtensionLayer build # 308 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 47444.

CI Vulkan-ExtensionLayer build # 309 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 47479.

CI Vulkan-ExtensionLayer build queued with queue ID 47479.

CI Vulkan-ExtensionLayer build # 310 running.

CI Vulkan-ExtensionLayer build # 310 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 47649.

CI Vulkan-ExtensionLayer build queued with queue ID 47649.

CI Vulkan-ExtensionLayer build # 311 running.

CI Vulkan-ExtensionLayer build # 311 passed.


Source APIs need to be separated into their own API JAR

The various interfaces & classes that support the development of pluggable sources need to be separated out of the core into their own API JAR.  Amongst other benefits this will help to prevent custom sources from accidentally becoming dependent on internal (private) classes.

Relates to issue #2.


Fixes #16

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   86.04%   86.04%
=======================================
  Files           6        6
  Lines          86       86
  Branches        8        8
=======================================
  Hits           74       74
  Misses         10       10
  Partials        2        2

Impacted Files
Coverage Δ

...n/java/org/mdkt/compiler/InMemoryJavaCompiler.java
85.71% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d84c404...ecef43a. Read the comment docs.