feat(cli): remove unused symbols from codegen

My attempt at solving #198 through method [2a].
I've built a rollup plugin (which is compatible with vite) that given the path to a codegen folder, detects calls to createClient using the generated descriptors, traces their usages and removes the unused descriptors from the build.
With the current example of vite/src/main.ts, the minified code is shaved by ~50kB:
minified
dist/assets/index-9b9328ce.js                       140.46 kB │ gzip:    53.27 kB
dist/assets/index-91969805.js                        89.86 kB │ gzip:    31.66 kB

Resulting built code without the plugin:

Resulting built code with the plugin:

This plugin is able to trace many common cases:
import { createClient } from "@polkadot-api/client";
import testDescriptors from "./codegen/test";

function transfer(alexa: Account, billy: Account, amount: bigint) {
  // Will be tracked even if `client` is defined further down in the AST
  client.tx.Balances.transfer_keep_alive.submit$(/* ... */);
}

const client = createClient(chain.connect, testDescriptors);

const { tx: transactions } = client;

// Will also be tracked even after the rename
const data = transaction.Slots.clear_all_leases.getCallData(0);

// Any file importing `transactions` and using it will also be tracked
export { transactions };

And it also covers the minimum for source map support. This can be used as an initial version where it covers many of the happy paths. There are still a few tweaks to improve and some challenges to solve:

Computed properties client.tx.Balances[method], or any thing that has to get solved in runtime. Currently it ignores it, but I would suggest bailing out from removing any symbol when detecting such cases.
Passing tracking variables through function arguments instead of directly referencing them. This could technically be solved by finding out the call arguments, with a few edge cases, but it will get more complex and tricky if the function is defined in a separate file.

function transfer(
  selectedClient: typeof client,
  alexa: Account,
  billy: Account,
  amount: bigint
) {
  // Currently won't be tracked :(
  selectedClient.tx.Balances.transfer_keep_alive.submit$(/* ... */);
}
const client = createClient(chain.connect, testDescriptors);
transfer(client, alexa, billy, 30n);

Currently destructuring is only supported one level deep, it should support going further down: const { tx: { Balances }} = client. There are other assignment patterns defined in the AST types that need to be handled as well.
Currently source maps just link the original code with all the symbols to the optimised code as a block, but doesn't go into the detail of which variables come exactly from where. It's just a technicality, but this is enough to let the consumer debug through the code.

I've added this as a new package rollup-plugin-descriptor-treeshake. I'm happy to change anything you might need, or if you think you want to use a different approach altoghether it's also fine; I just found this feature request interesting :).

🌟 This is absolutely fantastic work! I'm thrilled to see this progress and truly appreciate the effort you've put into this plugin. It's important to remember that this is a "nice to have" feature, so it's perfectly okay if it doesn't cover every edge case. Developers using @polkadot-api/client have several options, including:

Accepting a slightly larger bundle size in their dApps.
Maintaining a manual list of the chain interactions they need.
Adapting their coding patterns to align with this plugin's capabilities.

Now, let me share some thoughts on the specific points you raised:

Computed Properties (client.tx.Balances[method]): Your approach of ignoring runtime-resolved properties seems sensible. In cases where we have something like client.tx.Balances[method], ideally, the plugin should retain all tx.Balances.* descriptors and trim the others. Similarly, for client.tx[palletName][callName], keeping all tx descriptors while trimming the rest would be ideal.

Passing Tracking Variables Through Function Arguments: It's disappointing that this poses a challenge, but I understand the complexity. I had hoped it would be more straightforward, but I can totally see that it's trickier than I thought.

Destructuring Support: While deeper destructuring like const { tx: { Balances }} = client might be uncommon, it's a valid point. However, if it proves too complex to implement, we can simply document this as a pattern that the plugin does not support for now.

Source Maps: Your handling of source maps sounds completely adequate. It's more important that developers can debug through the code, rather than having a detailed mapping of every variable.

I can't express enough how grateful I am for your contribution. It's community efforts like yours that drive this project forward. Thank you so much for dedicating your time and skills to help improve our project. 🙏

Thanks for the feedback!
I have added a commit to handle nested destructuring, as it was rather simple to add.

Thanks for the feedback!
I have added a commit to handle nested destructuring, as it was rather simple to add.

This is awesome! Let's get this merged, for sure! We can take it from here, since the most difficult work has already been taken care off.
It would be very nice if you could take some time to look into the "Passing tracking variables through function arguments" edge-case 🙏
A tip proposal for this contribution has been submitted (using @polkadot-api/client in tinny dApp bundled with this plugin 😄. I'm serious! )
Thanks again!


Would it be possible?

Would it be possible to combine MultiOgar with Ogar-Unlimited?
I would like mainly these features:.

Minions, duh!

Minions, duh!

I will take a shot for every time I have heard this and had to say no.

true

That  suggestion would actually be pretty cool, then I could have custom bot names and I wouldn't have to give each and every one a different skin =D
And btw skins do work

Ah. I will take it off then

</random>``/random is easy If I have time to make it I will PR it

No lets not make MultiOgar like OgarUnlimited... PLEASE NO.

nvm its useless

i just want minions now...

yeah minions would be cool. If I have time I can make a pull request

OMG RAZOR
Please do

It wont be merged lol

True, but i can download that version with the commit >:D

Also true, just download the branch of who ever makes the commit :)

You can use ogarul or other servers which supports minion.
MultiOgar is designed for multiplayer game, but not for botplayer game.


Define auto dependency flow repo API

Broken down from https://github.com/dotnet/source-build/issues/146.
This tracks creating a uniform way to flow dependencies between repo builds in a source build. PR: https://github.com/dotnet/source-build/pull/181.

Doc created and merged, and changes will be tracked by new issues.


Not generating the test tag

Hello.
After run my tests the gercking results xml is generated but the test tags is not included, it’s empty.

Test tags are not used by Octane, so it is not included in XML attributes.


Update the whats next help topics

Update the help topic names and added them in the same content yaml file.

/ok-to-test

@Hyperkid123 How much time does it take for the content to be merged in this repo and then be available in the UI? I am trying to use these help topics in the UI but it is not working for some reason. Is there something missing in the PR?


Create a Connector to Pentaho Data Integration

Feature
Add Connector to Pentaho Data Integration
Describe the task
Add Connector to Pentaho Data Integration.

@AlexandreSilvaPereira please add extra details.

Which kind of connector should be implemented: a.e odbc.
Should we handle Kettle?
Do you have any potential use cases?


Sourcenext Compatibility

Is Sourcenext usable with this? The project wouldn't build with it's data.
It does however, boot on the original JS code.

Sourcenext should work with this project. Can you check the GAME_REGION variable in game/resource.go is set appropriately?

Some files show as JP, I changed the .bin files to direct paths and the game started, will check more later.

Tested further, crashes after entering 'original mode'

I assume it can't load/find the models and room properties, do you use discord?

GAME_REGION is supposed to be set to a value because it's not fixed. In your directory, you can check the folder OpenBiohazard2\data\PL0 and check whether there is a RDP folder or RDU folder. If the folder is RDP, set GAME_REGION = "P". If the folder is RDU, set GAME_REGION = "U".

I made a change to validate whether the game folders exist. Can you download the latest version of the project and rebuild to confirm all the game folders exist? If there are any issues, you should get a clear error message.

This is what shows in my PL0 folder. I have no such RDP or RDU folder, only 'rdt'. My game doesn't build since I pulled it, and I think we might have different game data files or they are named differently. I'm using the 'english' mod of sourcenext. Also your latest commit doesn't have GAME_REGION in it. Might I suggest sharing your files or showing your folder structure?

I removed GAME_REGION in the latest commit to simplify the logic. The file validation can be improved to catch these errors much more quickly.
I'm not sure why your RDT folder is called "RDT". It could be because the file extension for the rooms is .RDT, but I had only seen RDP or RDU before.


Technology tree UI squashing

Currently, there is a lot of unused space in Tech Tree, which is why it looks rather sparse and is difficult to scroll along. Is is possible to squash technologies closer to each other?

Probably, but I'm willing to bet that it's going to be very finicky. I
personally don't wanna touch it until the lower hanging fruits are all gone
On Sun, Oct 30, 2016, 1:30 PM Oak<EMAIL_ADDRESS>wrote:

Currently, there is a lot of unused space in Tech Tree, which is why it
looks rather sparse and is difficult to scroll along. Is is possible to
squash technologies closer to each other?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chaorace/cqui/issues/27, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGKcgLzW400Fj-ThAKfrkt4Rfl-Iggltks5q5NRPgaJpZM4Kkb9I
.

That's the very first thing i've looked over to adapt.. don't have any final results yet but i've already made framework tests and it looks promising.
Stay tuned. We simply NEED that precious SDK to commit our rational changes.


XMLHttpRequest Error

Hi, getDirections on flutter web creates XMLHttpRequest Error.

Feel free to reopen the issue, if the previous answer didn't address your issue.


There is no documentation available on how to integrate django-microsoft-sso with a Django custom user model.

Steps to Reproduce
Attempt to integrate django-microsoft-sso with the custom user model.
Encounter issues with the Django admin, specifically related to MicrosoftSSOUserAdmin.
Expected Behavior
The integration of django-microsoft-sso with a custom user model should work seamlessly, allowing for Microsoft SSO functionalities to be utilized with custom user attributes.
Actual Behavior
Encounter errors such as:
<class 'django_microsoft_sso.admin.MicrosoftSSOUserAdmin'>: (admin.E033) The value of 'ordering[0]' refers to 'username', which is not a field of 'users.User'.
<class 'django_microsoft_sso.admin.MicrosoftSSOUserAdmin'>: (admin.E108) The value of 'list_display[0]' refers to 'username', which is not a callable, an attribute of 'MicrosoftSSOUserAdmin', or an attribute or method on 'users.User'.
<class 'django_microsoft_sso.admin.MicrosoftSSOUserAdmin'>: (admin.E108) The value of 'list_display[2]' refers to 'first_name', which is not a callable, an attribute of 'MicrosoftSSOUserAdmin', or an attribute or method on 'users.User'.
<class 'django_microsoft_sso.admin.MicrosoftSSOUserAdmin'>: (admin.E108) The value of 'list_display[3]' refers to 'last_name', which is not a callable, an attribute of 'MicrosoftSSOUserAdmin', or an attribute or method on 'users.User'.
Additional Context
The Django project utilizes a custom user model (User).
Errors occur when attempting to register MicrosoftSSOUserAdmin with the custom user model in admin.py.
Running the Django development server (python manage.py runserver) results in an AlreadyRegistered error for User.
Same problem when running makemigrations
Environment
Django version: [4.2.10]
django-microsoft-sso version: [3.4.1]
Python version: [3.12.2]
Operating System: [Sonoma 14.5]

Hi @ecruz91, thanks for the message and PR. I'll look into it.

Can you please post here the admin.py code for your Custom User Model Admin? I can't reproduce the error here.


Show inputs on /transaction

We have an /input page, but we don't show and link to inputs on the /transaction page. We should do this, since it's useful for debugging transaction construction.

we do this


Made HiveAvroToOrcConverter compatible with Hive v0.13 version

Made HiveAvroToOrcConverter compatible with Hive v0.13 version

Minor change. Self approving.


Cannot set video (youtube) default iframe width/height

Hi guys,
i am using angular froala editor 2.8.5 (angular 6+).
When we are adding video:

Froala add iframe. But iframe has always same width 640px (constant). Sometimes container, where you want to add conent from froala is smaller -> so to improve user experience it would be perfect to change default width of iframe (and also height).
It is possible to make this constant -> configuration variable ?
Thanks
Martin

@martinduris please request it here: https://wysiwyg-editor-roadmap.froala.com. Thanks.


Update limits-specifications-teams.md

Fix in superscript

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


New model: endogenous medical expenses

Create module for models of endogenous medical spending.  Can be as simple as second consumption good with stochastic marginal utility.  Fairly straightforward to do once stochastic marginal utility is in consumption-saving model.

I'm going to take a stab at this for my own research in the coming weeks.  Will do the "two consumption good" model described above, then a version with an insurance contract for the second consumption good (i.e. medical spending).  Later I'll get to the insurance choice portion of that, which is a combination with the discrete-choice-continuous-space solver.

First model in this sequence has now been merged into master: second consumption good with random marginal utility.  Will proceed with other models in near future.


Import issues with npm package vs github cdn content

When utilizing this file (referenced from https://github.com/maptiler/cdn.maptiler.com/tree/main/maptiler-sdk-js/latest), the import works, I'm able to render the map successfully as expected, but the types are out of whack
https://raw.githubusercontent.com/maptiler/cdn.maptiler.com/refs/heads/main/maptiler-sdk-js/latest/maptiler-sdk.umd.js
My use case is below (deno fresh app which utilizes preact). I am doing some delayed importing so it imports client side.
import { IS_BROWSER } from "$fresh/runtime.ts";
import { useEffect, useRef } from "preact/hooks";

const tokyo = { lng: 139.753, lat: 35.6844 };

export const UserMap = (props: { className?: string }) => {
  const mapContainerRef = useRef<HTMLDivElement>(null);

  useEffect(() => {
    if (!IS_BROWSER) {
      console.error("IS_BROWSER is false");
      return;
    }

    if (typeof window === "undefined") {
      console.error("window is undefined");
      return;
    }

    const ref = mapContainerRef.current;
    if (!ref) {
      console.error("mapContainerRef.current is null");
      return;
    }

    (async () => {
      try {
        // ref: https://github.com/maptiler/cdn.maptiler.com/tree/main/maptiler-sdk-js/latest
        const maptilerSdk = await import("@maptiler/sdk");
        maptilerSdk.default.config.apiKey = "???";
        const { Map, MapStyle } = maptilerSdk.default;
        new Map({
          container: ref,
          // style: MapStyle.STREETS,
          center: [tokyo.lng, tokyo.lat],
          zoom: 14, // starting zoom
        });
      } catch (error) {
        console.error("Failed to load @maptiler/sdk:", error);
      }
    })();
  }, [mapContainerRef.current, IS_BROWSER]);

  return (
    <div
      ref={mapContainerRef}
      id="map"
      className={`flex ${props.className ?? ""}`}
    />
  );
};

When using npm, the types are nice, but it fails to import due to some relative import issues
TypeError: Failed to resolve module specifier "events". Relative references must start with either "/", "./", or "../".
I understand this is a pretty niche problem so if you need anymore info let me know

Very possibly Deno and the Events lib don't play well together, possibly because Deno already has an Event import from its core/standard-library so it's being confused at this package import. Since the Event library imported in the SDK has been last published 4 years ago, it was definitely not made for Deno. That's another argument to maybe remove it from SDK...

Hey, I am not sure I totally understand the situation. It looks like you are working on a frameworks that attempts at doing SSR and you don't want the SDK to be part of the SSRed bundle. In any case, I would strongly discourage to use the UMD bundle in this context as its main goal is to be used from vanilla JS in a basic HTML page.
Is the events import what's failing on server side for you? It's supposed to work on all platforms but when I read at the source there are bits that are run on top level, without calling any function so just importing it would run those bits, and that's what may cause the issue. I'll create a ticket internally to look more carefully into it and see if we can use any alternative.
One thing maybe you could do (but that I've never tried) is to import only the types synchronously, and then async import the module and somehow bind the types with the corresponding instances using as.
import type { Map as MapSDK } from "@maptiler/sdk";

Let us know of your progress, with more and more frameworks doing SSR, this kind of situation will become increasingly popular.

Ah, this worked like a charm. I have my types now. Thanks man! Of course this probably has problems, but at least I have usable types in the short term. Thanks for looking into this.
{
  // ...
  "imports": {
    "@maptiler/sdk": "npm<EMAIL_ADDRESS>    "@maptiler/sdk-web": "https://raw.githubusercontent.com/maptiler/cdn.maptiler.com/refs/heads/main/maptiler-sdk-js/v2.5.0/maptiler-sdk.umd.js",
  },
  // ...
}

Updated file
import { IS_BROWSER } from "$fresh/runtime.ts";
import { useEffect, useRef } from "preact/hooks";
import type mtSdk from "@maptiler/sdk";

const tokyo = { lng: 139.753, lat: 35.6844 };

export const UserMap = (props: { className?: string }) => {
  const mapContainerRef = useRef<HTMLDivElement>(null);

  useEffect(() => {
    if (!IS_BROWSER) {
      console.error("IS_BROWSER is false");
      return;
    }

    if (typeof window === "undefined") {
      console.error("window is undefined");
      return;
    }

    const ref = mapContainerRef.current;
    if (!ref) {
      console.error("mapContainerRef.current is null");
      return;
    }

    (async () => {
      try {
        // ref: https://github.com/maptiler/cdn.maptiler.com/tree/main/maptiler-sdk-js/latest
        const maptilerSdk = (await import("@maptiler/sdk-web"))
          .default as (typeof mtSdk);
        maptilerSdk.config.apiKey = "???????";
        const { Map } = maptilerSdk;
        const map = new Map({
          container: ref,
          // style: MapStyle.STREETS,
          center: [tokyo.lng, tokyo.lat],
          zoom: 14, // starting zoom
        });
      } catch (error) {
        console.error("Failed to load @maptiler/sdk:", error);
      }
    })();
  }, [mapContainerRef.current, IS_BROWSER]);

  return (
    <div
      ref={mapContainerRef}
      id="map"
      className={`flex ${props.className ?? ""}`}
    />
  );
};


Update CreateAssessment.java

Updating docs around sending user_ip_address, useragent, and Ja3 via createAssessment request.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist

[ ] I have followed Sample Format Guide
[ ] pom.xml parent set to latest shared-configuration
[ ] Appropriate changes to README are included in PR
[ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
[ ] Tests pass:   mvn clean verify required
[ ] Lint  passes: mvn -P lint checkstyle:check required
[ ] Static Analysis:  mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
[ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
[ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
[ ] Please merge this PR for me once it is approved

@Sita04 Can you please the PR?


Clean up files generated by node agent unit tests.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
Assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
Assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@incfly I think you may need to approve by clicking on "approve" in "review changes".

Because I'm not OWNER yet? Could you approve https://github.com/istio/istio/pull/4714?

I see. Add /lgtm to that PR.

/approve

@myidpt: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1bfa6dd890a7f66d04b7a408f2a3a99a65c33ddb
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1bfa6dd890a7f66d04b7a408f2a3a99a65c33ddb
link
/test e2e-simple

prow/istio-unit-tests.sh
ed9cd0825b8fbdb2e75a05729d86ef41723df854
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm


Avoid running coverage job if rs files weren't changed

Description
This patch allows to avoid run of coverage job if rust files weren't change
For avoiding duplication between workflows I have placed the job separately, which is aimed to provide info about any_changed rust files.
I'd like to test it more, so, now it is only draft.
Examples:
https://github.com/VitaliyaIoffe/pyrsia/actions/runs/2168406643
https://github.com/VitaliyaIoffe/pyrsia/actions/runs/2168401487
Close pyrsia/pyrsia#577

PR Checklist

[ ] I've read the contributing guidelines.
[ ] I've read "What is a Good PR?"
[ ] I've included a good title and brief description along with how to review them.
[ ] I've linked any associated an issue.
[ ] I've requested a review  from pyrsia/collaborators.

Code Contributions

[ ] I've built the code cargo build --all-targets successfully.
[ ] I've run the unit tests cargo test --workspace and everything passes.

changes, as they stand, look good. Minor requested changes can be done later if needed.

Sorry, it was a busy week. I haven't answered the @prince-chrismc question yet.

I'd prefer to see this as a Composite Action since that is better, but if you don't have the time we can merge this in for now and improve on it later 👍

I'd prefer to see this as a Composite Action since that is better, but if you don't have the time we can merge this in for now and improve on it later 👍

I am going to change reusable wf to composite under this pr :)


Add all keybindings

Pull Request Test Coverage Report for Build 762

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 11.792%

Totals

Change from base Build 758:
0.0%

Covered Lines:
306

Relevant Lines:
2595

💛  - Coveralls


tour: bump tour errors handling to new standards

Context: https://tour.golang.org/methods/21
Questions

What version of Go are you using (go version)?

latest - 1.14.1

What operating system and processor architecture are you using?

debian - x64

What did you do?

went through the tour

What did you expect to see?

the code that should be conformant to the latest guidelines

What did you see instead?

the issue I will present later

in this example:
r := strings.NewReader("Hello, Reader!")
b := make([]byte, 8)
_, err := r.Read(b)
if err == io.EOF {
 // Break
}

we can see in the last if statement the action of comparing an error to a similar error err == io.EOF . as is written in the docs that the new format is errors.Is(err,io.EOF)
I will soon add a PR to fix this, but wanted to give an explanation before

Sadly, this is not getting traction.
Closing


Poor rendering while zooming

I am facing a kind of "pixelate" issue when zooming in and out.
I thought that fix for issue #156 would prevent this when using:
pdfView.enableRenderDuringScale(false);
So I downloaded the project, rebuilt it and used as a library, but it does not help.
Is there anyway to go around this bad UX when zooming?
To better describe the problem, when zooming (doesn't matter if in or out) it looks like for a short while the text becomes bold, but without proper focus, from top to bottom more or less sequentially. It does not matter if zooming is done with tapping or pinching.
Thanks and keep up the good work!

Same problem here. Running this on a Nexus 9 (I don't see the pdfView.enableRenderDuringScale method anymore, though):
        pdfView.useBestQuality(true);
        pdfView.fromAsset(assetFileName)
                .enableSwipe(true)
                .enableDoubletap(true)
                .scrollHandle(new DefaultScrollHandle(this))
                .load();

Zooming is really grainy and has quite an observable "scanning" going on. Appreciate any help in advance.

+1

+1

--in pdfviewer.util;
--in Constants.java file
changing line below
public static float PART_SIZE = 250;
to:
public static float PART_SIZE = 600;
worked for me!
I did not dig that much about this static field but since this is a static field, according to your pdf size resolution, you can change value of this static field before rendering PdfView !!!

While setting this field rendering waiting time, below part shouldn't be forgetten;  As doc says:
/**
* The size of the rendered parts (default 256)
* Tinier : a little bit slower to have the whole page rendered but more reactive.
* Bigger : user will have to wait longer to have the first visual results
*/
Change will effect to waiting time.
So What you can do is adjusting value of PART_SIZE field but for better waiting rendering time you can make a trade-off between MAXIMUM_ZOOM and PART_SIZE fields. For example; You can say this MAXIMUM_ZOOM value suits my app requirements then according to that zoom value, You can set minumum value of PART_SIZE field!
Fields:
Constants.java
public static float PART_SIZE
public static float MAXIMUM_ZOOM = 10;


Improve error handling

In this PR, I have focused solely on making changes related to error handling.
We are utilizing eyre instead of anyhow here because eyre automatically provides line and column information for errors. I haven't explored whether there is an effortless way to achieve the same with anyhow yet.

Let me know anything I might've missed.

Ah, accidentally approved the PR without reviewing. I will review the PR and let you know if there is anything to my concern.
Thanks a lot for you contribution! ⭐

Also, I think I removed context to some of the errors, they can be added back with .wrap_err.

Yeah, sure! Most errors handled manually were something for which the default error message generated should be enough!
The relevant errors were those which dealt with cookie renewal, and as I can review, you already handled them with wrap_err.
I appreciate your contribution to this repository and for taking out time for the same.


Possibility to control external volume unit in sink mode

Hi, I'd like to ask if it's possible (or if it could be made possible, hopefully without too much work) to get notified of volume changes sent by the source instead of applying them via AlsaMixer. I'm building a bluetooth receiver on top of a Raspberry Pi for an amplifier which has motorised volume control - basically you can control the volume using a remote and the volume knob physically turns to the correct position. I'd like to keep using that feature, because the amp has multiple inputs and the bluetooth receiver should be just one of them, but I'd also like to integrate it with bluetooth volume control, so what I'm looking for is a way to specify e.g. an executable path which bluealsa-aplay would call when it receives volume commands instead of passing the commands to AlsaMixer. Is something like this possible?

Currently there is no code for forwarding volume level to hardware mixer via bluealsa-aplay. There is a PR #390 (currently stale, but it's still in the back of my head) which is a work in progress, which should handle such scenario. With current master code, however, you could use native volume control in bluealsa service bluealsa --a2dp-volume -p a2dp-sink which will disable software volume. Then, you can monitor bluealsa ALSA mixer volume knob (the same way the alsamixer -D bluealsa is monitoring it) and use it with your hardware volume application.

instead of passing the commands to AlsaMixer

I think it is important to clarify here that bluealsa-aplay does not send any commands to alsamixer, nor does it communicate with alsamixer in any other way.
The bluealsa daemon receives the volume change event from the bluez bluetoothd daemon via D-Bus. alsamixer -D bluealsa then fetches the event from bluealsa also via D-Bus, using the bluez-alsa CTL plugin.
So you would need an application that essentially does what alsamixer is doing, but uses the event notification to operate your motor instead updating a screen widget. You could  make that an ALSA application, and use alsamixer as a model for your code, or you could make it a D-Dus application, and subscribe to PropertiesChanged signals for the org.bluealsa.PCM1 interface - see src/asound/bluealsa-ctl.c for example code. The D-Bus approach is possibly simpler, as it could be scripted using Python, or shell script using a tool such as dbus-monitor or gdbus etc.

PR #390 has been merged into the master, so right now it is possible to forward volume information to ALSA mixer (I know that that is not what you want, but it might help). So, in order to be compatible with upstream bluez-alsa you can create a software control plugin for ALSA which will forward volume to your hardware device. Then you can use bluealsa-aplay as follows:
bluealsa-aplay --mixer=my-plugin --mixer-name=my-volume-element

Other option is to modify the code which is responsible for forwarding volume to ALSA mixer in bluealsa-aplay and instead of using ALSA API launch your custom control application.
I'm closing this issue, because right now it should possible to achieve what you want with built-in options (there is no need for any extra feature in bluez-alsa).


Some Videos couldn't download it

and show this Reason: Response status code does not indicate success: 403

Should be solved in the latest update (1.9.25)


Use sparse ledger for staged ledger diff application

This PR modifies the staged ledger diff application to use a sparse ledger for the transaction logic. This should significantly speed up catchup, where we have to apply a large number of blocks.
This PR builds upon https://github.com/MinaProtocol/mina/pull/14528, but also includes the sparse ledger fixes from https://github.com/MinaProtocol/mina/pull/14521 and https://github.com/MinaProtocol/mina/pull/14520.
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

!ci-build-me

!ci-nightly-me

!ci-build-me

Breaking change; closing.


Tasha Shukla A0

Added a profile picture and the bio

@tashashukla Now I'm curious about your favorite recipe to make. :-)


stream: allocate send RangeBuf with consistent sizes

This changes how RangeBuf objects are allocated when sending data.
Currently a new RangeBuf is allocated for each application write (of the
size of the write itself).
This change makes it possible to allocate RangeBufs of a pre-defined
capacity, whether the application data can fill it or not:

If the application data is bigger than the RangeBuf capacity, new
RangeBuf objects are allocated (with the same fixed capacity) until
all the application data has been stored.

If the application data is smaller than the RangeBuf capacity, the
RangeBuf is stored with the unused capacity at the back of the
SendBuf. Following writes will then try to fill the trailing RangeBuf
if it has any spare capacity.

The use of Arc<RwLock<>> for the RangeBuf's internal buffer makes
accessing the data somewhat more complicated as we can't slice the
Vec directly anymore, which is why the with() method was added.
However this added complexity is necessary to make sure Connection can
implement the Send trait, and due to the fact that Arc requires its
inner type to be both Sync and Send, we need to use RwLock (instead of,
say, RefCell) to satisfy the type constraints.

The RwLock thing is kind of annoying, need to do some benchmarks to see if it has any impact on performance. Also, in the future we probably want to do something similar for RecvBuf as well, but that will need some refactoring as well.

So anyway, RwLock seems to be making SendBuf::emit() slightly more expensive compared to just plain Arc, but it's so small that it's within the margin of error I think. In practice there should never be lock contention, so the cost is just acquiring and releasing the lock. We can improve this later on if it turns out to be a problem though.

We can improve this later on if it turns out to be a problem though.

The alternative is that we give up Connection being Send altogether, but it was requested explicitly by a user in https://github.com/cloudflare/quiche/pull/433 so I'd rather not do that if we can avoid it.

Rebased (again).


Create interface to properties_server

Goal
create interface to query the properties_server for job to run or molecular properties.
How it works
Use the CLI to:

Compute jobs like: moka compute input_compute.yml
Report results like: moka report input_report.yml
Query properties like: moka  query  input_query.yml
Add job like: moka add input_add.ym

TODO
Create functionality for the actions:

[x] compute
[x] report
[x] query
[x] add

All functionality is available


PIJuice comms issue - zero-w-v1-j

PiJuice not communicating with Pi.

PiJuice doesn’t have any power lights.
Camera not connecting, even with PiJuice disconnected.
Solder joints appear OK. But PiJuice has minor signs of heat damage around SW1/J5 - not where we’ve worked.
Following troubleshooting instructions at https://github.com/PiSupply/PiJuice/tree/master/Firmware#faq

Photos of possible heat damage, and next to another PiJuice that is working fine.

Camera looks like it was a loose connector on the camera board.

Supplying power to PiJuice ends up powering Pi - but no PiJuice leds illuminated.
Plugged in battery and registered and reported voltage. Flashing blue at 49% - perhaps red LED is out?

Was working, and now doesn't seem to be - have swapped out for another PiJuice.


wayland-utils: init at 1.0.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@wkral oh, our timing was a bit unfortunate, but thanks for the review :)


Use ErrorType in ValidationResult

I'm glad we made the switch to using the generic ErrorType for Result, but I'm confused why we aren't  using the same generic ErrorType in ValidationResult. I'd really like to pass my own custom errors into validation.
Is there a reason why we can't/shouldn't be doing this?

That's a great question! The answer is quite complicated so let me split it up.
Short Version
We don't want users to have to cast response serializer errors from ErrorType to NSError every time just to allow custom error types for Validation.
Long Version
All Alamofire errors encountered when making a request are stored in a request's TaskDelegate instance. That error then propagates to all the responser serializers. Since the majority of errors that can be encountered when making network requests are actually generated by NSURLSession rather than Alamofire, it makes sense to have Alamofire also generate NSError objects to maintain consistency. This makes the response serializers much less complicated.
In Alamofire 2.0, we made the unfortunate decision to switch the TaskDelegate error to an ErrorType rather than an NSError. This forced all users to have to cast the error in the response serializers to an NSError even if they didn't implement custom Validation closures. Not a great tradeoff considering we have thousands (maybe hundreds of thousands) of people using the response serializers and only hundreds creating custom Validation closures.
There are also many more details in #791 if you'd also like to check that out.

Got it. That makes perfect sense. Thanks for the quick reply @cnoon. I guess I'll just make my validation errors NSErrors.


Create Context and Reducer for Account Data

Create an account context
Create an account reducer

Commit: https://github.com/johneastman/todo/commit/5edbebfea6ed31b12495922a85b1ecfaa8901f99


restrict access

How to use cm with -users option?
./cm_linux_amd64 selenoid-ui start -users /etc/apache2/.htpasswd
Error: unknown shorthand flag: 'u' in -users
./cm_linux_amd64 selenoid-ui start -g -users /etc/apache2/.htpasswd

Using Docker

Your Docker API version is 1.41

Selenoid UI is already downloaded
Selenoid UI is already running
root@root:~/ms_ex_driver_sender# netstat -apn | grep 8080
clear...

@CraftedCat this is only supported when starting UI manually. Don't try to use this flag with CM.


Camera cannot focus due to wrong aspect ratio since plugin 6.0.5

Expected Behaviour
This Screenshot shows the Plugin on the same smartphone in version 4.1.0. Scanning of barcodes and QR-codes works fine.

Actual Behaviour
This Screenshot shows the Plugin in version 6.0.5. It looks like the plugin calculates the wrong screen resolution. The camera does not focus and the aspect ratio is wrong (drawn-out). It is impossible to scan Barcodes like this. QR-Codes are scanned very fast.

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 5.1.1
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Samsung Galaxy Grand Prime (SM-G531F)
Cordova CLI version and cordova platform version
6.4.0
Plugin version
phonegap-plugin-barcodescanner 6.0.5 "BarcodeScanner"

I see the same issue on the same device (Samsung grand prime). Plugin v6.0.4. The phone keeps trying to focus, but the image is blurred all the time when you put the barcode inside the square. It works fine when you increase the distance between the barcode and the phone.
The grand prime is not the only phone with the issue.
Any idea what might be the cause of it?

A way out of this situation would be to remove the grey area and only show the red line so that the users don't think they need to put the phone very close for the app to scan the code properly.
Could we have the option in the config to disable the greyed out area?

Any status on this?

We are seeing the same problem on different phone depending on the quality of the camera.
However if we use the xing bar code scanner (i'm assuming that the plugin also uses the xing library) on the same phone with the same bar code it scans fine. So our conclusion is that this is a problem with the barcode plugin and not the hardware/phone.
https://play.google.com/store/apps/details?id=com.google.zxing.client.android&hl=en

I am seeing the same issue using my Samsung Galaxy Tab 4 with Cordova CLI 6.4.0 and phonegap-plugin-barcodescanner 6.0.5.  The plugin is unable to focus and scan any barcodes.  I've attempted multiple different lighting scenarios as well as distance from the barcode.
I have downloaded ZXing Test and Barcode Scanner from the Play Store and both work fine.  I am able to consistently scan barcodes.
I downgraded phonegap-plugin-barcodescanner to 6.0.2 and I am now able to scan barcodes again.  It looks like there were several big changes to the android source that could impact the performance.
For now, I am using ionic plugin add<EMAIL_ADDRESS>as a workaround.  I deleted my platforms directory, add the plugin and then add my platforms:
rm -fr platforms
ionic plugin add<EMAIL_ADDRESS>ionic platform add android
ionic platform add ios

ionic run android --device

I do not see any difference on the Samsung Grand Prime with plugin version 6.0.2.

@Style117  I agree. the problem is present on 6.0.2 as well. Anyone found a fix that could be applied?

I am also having this issue (latest Cordova on Android). I tried several different versions, no luck. This is an absolute blocker!

At risk of sounding dumb, did you remove both platforms and plugins?
ionic platform rm ios
ionic platform rm android
rm -fr platforms
rm -fr plugins
ionic plugin add<EMAIL_ADDRESS>--save

ionic prepare

We have tested this on multiple devices and found it to work.  The key was removing platforms and plugins so that ionic could update everything properly.

I am not using ionic, just plain cordova. But I'll give it a try.

On 20 Jan 2017, at 01:35, Jesse Sanders<EMAIL_ADDRESS>wrote:
At risk of sounding dumb, did you remove both platforms and plugins?
ionic platform rm ios
ionic platform rm android
rm -fr platforms
rm -fr plugins
ionic plugin add<EMAIL_ADDRESS>--save
ionic prepare
We have tested this on multiple devices and found it to work. The key was removing platforms and plugins so that ionic could update everything properly.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@sebmaniac - it shouldn't matter if you are using just cordova... Ionic is just a wrapper around cordova.  Just replace ionic with cordova in the example I gave and it should work.

I just tried it, no luck. It is not working with 6.0.2., even after removing the entire plugins and platform.
From: Jesse Sanders<EMAIL_ADDRESS>Sent: Friday, January 20, 2017 2:15 PM
To: phonegap/phonegap-plugin-barcodescanner
Cc: sebmaniac; Mention
Subject: Re: [phonegap/phonegap-plugin-barcodescanner] Camera cannot focus due to wrong aspect ratio since plugin 6.0.5 (#392)
@sebmaniac https://github.com/sebmaniac  - it shouldn't matter if you are using just cordova... Ionic is just a wrapper around cordova. Just replace ionic with cordova in the example I gave and it should work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/392#issuecomment-274069268  it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/AA8MuAzMcOgvRz4PC63vPO_7Wh6T1_Avks5rULM3gaJpZM4LUz8O  the thread.  https://github.com/notifications/beacon/AA8MuJsrDr_CqBfBrXTjtezElBLyI5Ccks5rULM3gaJpZM4LUz8O.gif

Any news on this? Are the developers addressing this issue?

FYI this developer doesn't have a device that replicates the issue. My Nexus 6P and Samsung PRO8 behave just fine (correct aspect ratio's). Perhaps someone else with a 'problematic' device can take a look?

Any news on this? I'm having the same issue.

Hi everybody. I'm trying to work on this issue. I need some help on reproducing this issue. any movies or screenshots presenting the issue would be helpful.
@Style117 how do you know it is connected with wrong aspect ratio?

@gczudowski  I dont know if its connected to the wrong aspect ratio. But if you compare the two screenshots its all squeezed together.

any news? i have the same problem :(

Any news?

Here's a video of the aspect ratio problem on Samsung Galaxy Mega 5.8 (GT-I9152) trying to scan a QR Code.
barcode.m4v.zip

BarCodeSF550.avi.zip
Here's a video of the barcode failing. You'll notice that the 3rd and 4th time it scans the wrong number.

I was able to solve this issue successfully, it seems. The aar library needed some fine-tuning. Do you guys know where the current .aar library source code is located? I'd like to submit a pull request with the new lib, but is https://github.com/EddyVerbruggen/barcodescanner-lib-aar the current barcodescanner-release-2.1.2.aar?

Hey guys (especially those of you that experienced this issue),
Can you please give the latest version from GitHub's master branch a spin? It includes the changes @gczudowski made today. Like I said before I can't test them, I was only able to check for regression issues on my devices.

Hi, the error is fixed on my Grand Prime.
I tested it with:
cordova CLI: 6.4.0
Ionic CLI Version: 2.1.14
Ionic App Lib Version: 2.1.7
@gczudowski thanks for the update. 👍

The fix is confirmed on Samsung Galaxy Mega 5.8 (GT-I9152), thank you @gczudowski :thumbsup:

Hi Guys. Any update is this issue is fixed?
I facing same issue using<EMAIL_ADDRESS>I also downgrade version 6.0.2 & 6.0.5 but no luck.

Was fixed several months ago. I know we verified the fix here.
On Oct 2, 2017 05:31, "MUmer1124"<EMAIL_ADDRESS>wrote:

Hi Guys. Any update is this issue is fixed?
I facing same issue using<EMAIL_ADDRESS>I also downgrade version 6.0.2 & 6.0.5 but no luck.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/392#issuecomment-333484994,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB8h_dIMm_YVKDfhfMCWV9hhXfeoRZ9wks5soK1YgaJpZM4LUz8O
.

Thanks for your reply on time.
I deduce this issue was generated when I change my height & width of scanning area. But otherwise your lib is works cool.
Can you give me a suggestion how can I change the size of scanning area.
public synchronized Rect getFramingRect() {
if (framingRect == null) {
if (camera == null) {
return null;
}
Point screenResolution = configManager.getScreenResolution();
if (screenResolution == null) {
// Called early, before init even finished
return null;
}
        int width = screenResolution.x;
        int height = screenResolution.y;

        int rotation = context.getApplicationContext().getResources().getConfiguration().orientation;
        if (rotation == Configuration.ORIENTATION_PORTRAIT) {
            width = (int) getDeviceWidth(width, 90); // 90%
            height = (int) getDeviceHeight(height, 40); // 40%
        }
        else {
            width = (int) getDeviceWidth(width, 70); // 70%
            height = (int) getDeviceHeight(height, 50); // 50%
        }

        int leftOffset = (screenResolution.x - width) / 2;
        int topOffset = (screenResolution.y - height) / 2;
        framingRect = new Rect(leftOffset, topOffset, leftOffset + width, topOffset + height);
    }
    return framingRect;
}

The above code I change on your lib code then preview is generated fine. But scanner scanning speed is going too slow but its read correctly Code-39 format but not read QRCodes smoothly.
Thanks in advance.
From: wcalderw
Sent: Monday, October 2, 2017 4:17 PM
To: phonegap/phonegap-plugin-barcodescanner
Cc: MUmer1124; Comment
Subject: Re: [phonegap/phonegap-plugin-barcodescanner] Camera cannot focus dueto wrong aspect ratio since plugin 6.0.5 (#392)
Was fixed several months ago. I know we verified the fix here.
On Oct 2, 2017 05:31, "MUmer1124"<EMAIL_ADDRESS>wrote:

Hi Guys. Any update is this issue is fixed?
I facing same issue using<EMAIL_ADDRESS>I also downgrade version 6.0.2 & 6.0.5 but no luck.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/392#issuecomment-333484994,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB8h_dIMm_YVKDfhfMCWV9hhXfeoRZ9wks5soK1YgaJpZM4LUz8O
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


[Help] Trying to use System.Linq.Dynamic.Core with MongoDB IQueryable

I'm running into an issue when trying to use System.Linq.Dynamic.Core with MongoDB's client.
Example)
Works
IQueryable query1 = collection.AsQueryable<BsonDocument>().AsQueryable().Where("Birthdate <= @0", DateTime.Now);
Doesn't Work:
 IQueryable query1 = collection.AsQueryable<BsonDocument>().AsQueryable().Where("Birthdate <= DateTime.Now");
(Throwing the exception): System.Linq.Dynamic.Core.Exceptions.ParseException: 'Operator '<=' incompatible with operand types 'BsonValue' and 'DateTime''
BsonValue is the actual type of BirthDate and is wrapping DateTime.  I have tried to get the actual DateTime value, such as:
IQueryable query1 = collection.AsQueryable<BsonDocument>().AsQueryable().Where("Birthdate.AsDateTime <= DateTime.Now");
But receive a different exception: System.InvalidOperationException: 'The operands for operator 'LessThanOrEqual' do not match the parameters of method 'op_LessThanOrEqual'.'
Any thoughts, suggestions here?
I don't have issues with simple expressions such as:
IQueryable query1 = collection.AsQueryable<BsonDocument>().AsQueryable().Where("FirstName == \"John\"");

Maybe solved by #805.
Closing for now.


FossIdScanResults: Reduce the number of toSpdx() calls

Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

Merging despite the known failure of the Azure checks.


Updated UI windowing logic to keep dynamic sized windows within app window bounds.

Notes:

Not positive this is the right fix. Drag a dynamically sized window downwards and it stays in the screen. Drag it rightwards far enough, and its right edge will stop being contained within the bounds of the app window.
I tried having WindowLayoutFlag_StartupAlign_Right execute just once (removing flag when it runs), but that caused the Basis.x to never be correct. Doing a similar thing for WindowLayoutFlag_StartupAlign_Bottom seemed to work just fine.

Fixes scallyw4g/bonsai#47


Sixth Korean l10n work for release 1.18

Update outdated files in dev-1.18-ko.6 partly (#21714)
Translate StorageClass to Korean word (#21805)
Translate StatefulSet to Korean word in pods.md (#21794)
Translate tasks/run-application/delete-stateful-set/ in Korean (#21686)
Translate tasks/administer-cluster/change-default-storage-class in Korean (#21801)
update outdated docs (#21940)
Modify spacing term StatefulSet in Korean (#21871)
Translate /tasks/administer-cluster/coredns in Korean (#21876)
Fix typo in k8s.io/ko/docs/contribute/new-content/new-content/ (#21975)
Translation error correction in /concepts/containers/runtime-class.md (#21868)
Translate tasks/tls/certificate-rotation/ in Korean (#21838)
Translate /tasks/configure-pod-container/static-pod in Korean (#21798)
Update to Outdated files in the dev-1.18-ko.6 branch - (1/4) (#21911)
Fix English bugs in Korean documentation (#21994)
Update outdated dev-1.18-ko.6 partly (#22067)

Co-authored-by: Jerry Park<EMAIL_ADDRESS>Co-authored-by: PyungHo Yoon<EMAIL_ADDRESS>Co-authored-by: Yuk, Yongsu<EMAIL_ADDRESS>Co-authored-by: Jerry Park<EMAIL_ADDRESS>Co-authored-by: Seokho Son<EMAIL_ADDRESS>Co-authored-by: Jordy Ruiter<EMAIL_ADDRESS>Co-authored-by: bluefriday<EMAIL_ADDRESS>Co-authored-by: Dajin Gwon<EMAIL_ADDRESS>Co-authored-by: Hyungseok Lee<EMAIL_ADDRESS>Co-authored-by: Jihoon Seo<EMAIL_ADDRESS>Co-authored-by: coolguyhong<EMAIL_ADDRESS>Co-authored-by: jmyung<EMAIL_ADDRESS>Co-authored-by: June Yi<EMAIL_ADDRESS>

/assign @pjhwa

@pjhwa 리뷰 감사합니다. 다만, 이 PR의 목적은 ko.6 마일스톤 동안 공동의 작업을 master 브랜치에 단일 커밋으로 반영하고 ko.7을 시작할 수 있도록 하는 것이기에, 마일스톤 진행 중 공동의 작업이 누락 없이 반영되었는지 여부에 리뷰 초점을 맞추고, 지적해주신 내용은 ko.7 마일스톤에서 반영될 수 있도록 새로운 이슈나 PR을 여는 것이 좋을 것 같습니다.

/lgtm
/approve


Create operation for projections seems to miss "Checkpoints Enabled" function

Creating a projection via the UI and HTTP API has the following options:

Checkpoints Enabled
Emit Enabled
Track Emitted Streams
Enabled

The class CreateProjectionOptions only has:

emitEnabled
trackEmittedStreams

The following functions do not exist:

Checkpoints Enabled
Enabled - According to docummentation enable should be called after creation instead

DEV-228

Thanks for pointing that out. It will be amended.


Add Pattern Metadata for Each Python Sample

Follow this template, put the metadata.json file in the root directory of the sample:
https://github.com/aws-samples/serverless-test-samples/blob/main/python-test-samples/apigw-lambda-dynamodb/metadata.json

MR https://github.com/aws-samples/serverless-test-samples/pull/97


Adjusted method call for firing an event, Symfony 4.3 Support

This PR is dependent on an additional pull request against rockettheme/toolbox being merged.
https://github.com/rockettheme/toolbox/pull/27
Additionally, once rockettheme cuts a new version we'll need to update the composer.json here.

Seems your change fails in our automated tests. Please review the Travis output or run the built in tests on your fork bin/grav test

hey @rhukster,
Please see rockettheme/toolbox#27
I'm using Symfony 4.3 with Grav to have controlllers /routing and the rollback to Symfony 4.2 breaks our code base.
I migrated the method call for FireEvent to the newer Symfony 4.3 header, But this also relies on the above PR.

Symfony 4.3 supports the old ordering of the fields, which makes upgrading both Toolbox and Grav totally unnecessary at this point. We just cannot break all the code because of Symfony now supports  PSR-14 for the events and are deprecating the old behaviour.
It does not mean that I've not looked into this already and had plans to upgrade events, but for now because of all the other tasks I've decided to delay this new way until we get a bit closer to 2.0, which is not that far away.
In any case, if you read PSR-14, you will see that events will need to be fully redesigned to make the move, which is why I have a hard time accepting your changes. They are trying to use the new event system in the old way.
For PSR-compatible events dispatch() needs to take Event object and the object only as of the parameter -- event object itself acts as the event name. Also, there is no interface for the event class, you can use whichever class you want to. This makes Toolbox Event classes deprecated (read not needed anymore) and basically forces us to change how events work.

Understood. Would we possibly move forward with using Symfony EventDispatcher or is the idea to stick with rockettheme/toolbox ?

Well, we are actually already using Symfony, though we have extended it slightly to add some extra features. But basically what I was trying to say is that in the future any class can be used as an Event, you don't need to implement any interface or extend any class to do it. Then you just hook to listen for events using the class you're passing.


What is the meaning of x in the Equation 6?

Hello, what is the meaning of x in the Equation 6? I did not find its definition in the paper. Thanks!

Thanks for your interest in our work! I assume you’re referring to Eq. (6) in our paper "Similarity search in the blink of an eye with compressed indices". The variable x in that equation refers to the residual r (which is defined in the paragraph right before the equation), so it should actually be: Q_res(r; B') = Q(r; B', -delta/2, delta/2).


Fix IID/Messaging AutoInitEnabled test

Disabled temporarily until the tests can be fixed - tests pass locally but fail on pod lib lint.
cc @chliangGoogle

This wasn't actually disabled (the PR never landed), closing.


Colaboratory use

How to use this repo in Google Colaboratory?

Our code haven't supported the Google Colab, it would be helpful if you can try it on Colab and tell us. Thanks!


window.getComputedStyle no worky

I built a test runner for a jQuery plugin using jsdom and was surprised to find out that all my $('#foo').css('text-align') tests are failing.
I attempted to use window.getComputedStyle without jQuery and get back an empty array on any element.
https://developer.mozilla.org/en/DOM:window.getComputedStyle

yeah, the css object model is partially implemented.

I would love to see this completed for unit testing CSS. What is the scope of full implementation? I'm hoping to avoid one of the various headless webkit hacks out there. :)


create_transaction_event Does Not Properly Parse Dictionary (Python)

I encountered an issue with the create_transaction_event function in the Python SDK. It appears that this function does not properly parse this example dictionary and requires constructing the TransactionEvent directly. This issue causes unexpected errors during test executions.
Steps to Reproduce
Use the following example dictionary for creating a transaction event:
from forta_agent import create_transaction_event
from datetime import datetime

event_dict = {
    "transaction": {
        "hash": "0",
        "from": "0x0000000000000000000000000000000000000000",
        "nonce": 9,
    },
    "block": {
        "number": 0,
        "timestamp": datetime.now().timestamp(),
    },
    "receipt": {"logs": []},
    "chain_id": 1,
}

tx_event = create_transaction_event(event_dict)

Expected Behavior
The create_transaction_event function should parse the example dictionary correctly and create a TransactionEvent object without requiring additional manual steps.
Actual Behavior
The function raises a TypeError indicating that the block and chain_id arguments are missing, forcing the user to construct the TransactionEvent directly.
Workaround
Currently, I have to construct the TransactionEvent directly to avoid the error:
from forta_agent import TransactionEvent

event_dict = {
    "transaction": {
        "hash": "0",
        "from": "0x0000000000000000000000000000000000000000",
        "nonce": 9,
    },
    "block": {
        "number": 0,
        "timestamp": datetime.now().timestamp(),
    },
    "receipt": {"logs": []},
    "chain_id": 1,
}

tx_event = TransactionEvent(event_dict)

Environment

Library Version: forta_bot_sdk 0.2.3
Python Version: 3.10.14
OS: 5.15.160-1-MANJARO

Additional Information
This issue was encountered while running test cases using pytest while migrating a Forta starter kit bot to V2. The error messages indicated that the block and chain_id arguments were missing, even though they were included in the provided dictionary.

Moved to V2 SDK: https://github.com/forta-network/forta-bot-sdk-v2/issues/5


Parser, do not check indent for choices

Choices are the only things that the parser check the indent level to go out from menu state.
if we remove it, the user can indent his code like he want.

If you remove need for them then how user will end menu block ?

With new line, other rkscript instructions, or end of file

I see this is good idea @theludovyc

Yeah sometimes it happen 😂


Bug

	in := "1111111111"
	fmt.Println("in: ", in)
	v, err := base58.Decode(in)
	fmt.Println("decode:", v, err)

	fmt.Println("encode again:", base58.Encode(v))

Try this with your function names instead (by the way, I suggest you get rid of Trivial* and rename the fast versions to Encode and Decode). Output should look like this:
in:<PHONE_NUMBER>
decode: [0 0 0] <nil>
encode again: 111

Thanks for bug report.
This is problem in FastDecoding implementation, which was written by @njones. Excuse me that I merged without good testing.
I made functions Encode and Decode which call fast version for encoding and trivilal for decoding (as fast workaround).
I will fix fast decoding implementation tomorrow.

No worries Denis, I switched to btcutil until you sort this one out, I would love to use your much faster code. (after all we use base58 for tokens so it's definitely a hot path for us)
I think you can adapt these simple tests very easily https://github.com/btcsuite/btcutil/blob/master/base58/base58_test.go

fixed


MM-41532 - Gekidou Snack Bars

Summary
This PR adds the Toasts component after each post option menu action; for e.g. we're now going to show a toast after a link/message is copied to the clipboard.
Ticket Link
https://mattermost.atlassian.net/browse/MM-41532
Device Information
This PR was tested on:
Screenshots

Release Note
NONE

@avinashlng1080 is this ready for review? or is it still a draft?

@Willyfrog  The work on this ticket is done.  However, given that it is a Beta ticket, we have parked it for now.  Once we revisit it, we can include the new UI considerations/changes ( if any ) into it.
@matthewbirtch  FYI.
Link to the conversation: https://community.mattermost.com/core/pl/os6x1ging78adff15d3eajkicw


MudMenu Fails to Close When Translated: Remains Open on Page Clicks

Things to check

[X] I have searched the existing issues for this bug
[X] To rule out a caching problem I made sure the bug also happens in an incognito tab

Bug type
Component
Component name
MudMenu
What happened?
When a MudMenu is opened within an element (or a parent element) that has style: transform: translate(...), the menu fails to close when clicking anywhere on the page. Instead, it only closes when clicking within its parent element or when clicking the buttons.
Expected behavior
It should close everywhere when you click somewhere
Reproduction link
https://try.mudblazor.com/snippet/GkmyFEPynPJEgTQh
Reproduction steps
1.Make a MudMenu
2.give it the style: transform: translate(0px, 0px)
3.Click on the MudMenu
4.Try to close it.
Relevant log output
No response
Version (bug)
7.11.0 6.21.0
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The problem here seems to be related with the css transform property.
As pointed in the css spec (https://www.w3.org/TR/css-transforms-1/#propdef-transform),
For elements whose layout is governed by the CSS box model,
any value other than none for the transform property also causes the element
to establish a containing block for all descendants.
Its padding box will be used to layout for all of its absolute-position descendants,
fixed-position descendants, and descendant fixed background attachments.

So, in this example, maybe a simple ad-hoc/local solution (that does not require changes in mudblazor) is to set inners mud-overlay width/height
properties to 100vw/100vh, respectively.
.mud-overlay {
  width: 100vw;
  height: 100vh;
}

Another solution, could be to create a new OverlaySectionName property in MudMenu, to allow render mud-overlay outside the mud-menu hierarchy, so that it cannot be affected by custom transformations.
Like
<SectionOutlet SectionName="menu-overlay" />

<MudMenu
    style="Background:blue;transform:translate(0px,0px);"
    OverlaySectionName="menu-overlay">
    <MudMenuItem>
        Save
    </MudMenuItem>
</MudMenu>

@Schlutzkrapfen
What do you think? is it worth implementing the OverlaySectioName property?
or is the ad-hoc (css) solution enough?

@jgoday Thank you for your response! It would be nice if this could be implemented directly in MudBlazor, as it causes behavior that isn't intendet. It is like extra work for anyone who encounters the bug.

@jgoday Thank you for your response! It would be nice if this could be implemented directly in MudBlazor, as it causes behavior that isn't intendet. It is like extra work for anyone who encounters the bug.

Sorry for the delay, just created a PR (#10188) that adds an optional parameter (OverlaySection) to avoid css-transform problem

https://try.mudblazor.com/snippet/GucePwveviVQDAsE is an up to date snippet. Note V8 will not show MudMenu's with no label or Activation Context


Fix layout saving error

As a result of commit b49226e085 FileAccess::open no longer returns ERR_CANT_OPEN if the file cannot be found/opened.
Instead check against ERR_FILE_NOT_FOUND or ERR_FILE_CANT_OPEN.

Thanks!


Where is memcached memory in the config files?

Each time when I do --provision for turn on/off  'installed_extras' or on an other reason the 'memcached -m' setting is reset to '-m 64'.
I need restore this settings in the memcahed.conf file.
How Can I install it in the config files?

You can see the variables that can be used for the memcached configuration here:  https://github.com/geerlingguy/ansible-role-memcached
memcached_memory_limit: 64

Excuse me for a lame question.
How to install it on Drupal VM?

@ArtuGit not lame at all :)
Just make sure you have memcached in the list of installed_extras in config.yml; if it's in that list, the geerlingguy.memcached role is used, and all those variables are available to you.

Thank you,)


#202 try clang and gcc in travis file

This just does not work, sparsehash is not compilable with clang, and this needs to be done by someone with a ubuntu install so they can debug it


Additional Target Hooks RFC

This is the an initial RFC for adding additional hooks onto the Target to
allow splitting up some of the compile flow but also unifying the
registration of these additional functions.

CC: @tqchen @jroesch
I think this overlaps with the TE Compiler work, would be good to get your feedback :smile_cat:

Thanks for the work on this, after thinking about it for a while I believe the proposed hooks runs counter to goals of the TECompiler and "unified lowering" refactor that we've been working on in pieces. Our design goal is to not allow arbitrary customization of "lowering"  but instead seal it behind a stable interface. The lowering process should be a straight forward mapping from TE -> TIR, and then any necessary customization should be possible in resulting passes which are allowed to view the entire program including both the Relay code and TIR code.
The goal is to remove the need for many slightly different code paths through the central parts of the compiler and instead provide standard interfaces that allow targets, and users to customize the compiler without having to touch any of the flows or modify the data structures.  The proliferation of customizations in the old compile engine for example makes it nearly impossible to refactor the compiler in its current state, and has lead to the world where we need lots of per-flow customization because the compiler is insufficiently factored into a common prefix of code.
I plan on providing a longer form document on this hopefully this week that argues this more in depth but I believe the tenants should be customization of the compiler happens via passes, passes only can produce IRModules, and all data is stored in the IRModule. Today's compiler requires a little more work to get to this world, but I think we should push in this direction.
Now that doesn't mean the desire to have per target behavior is necessarily bad, but I think instead of overriding the lowering code with arbitrary functions we could provide hooks that allow the insertion of target specific passes at the "correct" time in the compiler flow. In this world the proposed hooks should return a Pass object which can be inserted after the appropriate phases.
Happy to discuss more, and have others such as @electriclilies @csullivan @mbs-octoml

Hi @jroesch,
It'd be great to discuss this further, as there's some interesting points you've raised.

The lowering process should be a straight forward mapping from TE -> TIR, and then any necessary customization should be possible in resulting passes which are allowed to view the entire program including both the Relay code and TIR code.

In the case of library adaptations such as CMSIS-NN, translating through Relay->TE->TIR isn't required as we can do a more straight forward translation directly from Relay->TIR without any of the other pass overheads. In effect, our hook here is a single Pass to run over any marked functions rather than aggregating other Passes so conceptually they're similar.

The goal is to remove the need for many slightly different code paths through the central parts of the compiler and instead provide standard interfaces that allow targets, and users to customize the compiler without having to touch any of the flows or modify the data structures.

I believe we're on the same page here, the eventual goal being to register and use the hooks directly as target properties that can be accessed as part of a standard flow. The hooks proposed here are slightly larger than you envisaged but should allow a standard and straight forward interface for users to customise the flow of the compiler. The initial implementation isn't as clean as I'd like due to the issues you've raised already with the current compile engine.

I plan on providing a longer form document on this hopefully this week that argues this more in depth but I believe the tenants should be customization of the compiler happens via passes, passes only can produce IRModules, and all data is stored in the IRModule. Today's compiler requires a little more work to get to this world, but I think we should push in this direction.

The hooks proposed could in fact be such Passes, going IRModule -> IRModule rather than taking a Relay Function. As stated above, it would be more optimal to be given a IRModule without TIR, just with the Relay attached.

Now that doesn't mean the desire to have per target behavior is necessarily bad, but I think instead of overriding the lowering code with arbitrary functions we could provide hooks that allow the insertion of target specific passes at the "correct" time in the compiler flow. In this world the proposed hooks should return a Pass object which can be inserted after the appropriate phases.

I'm interested to understand how this would appear to users in a way that allows them to compose the compiler passes efficiently, being able to write a pipeline of passes seems more intuitive than providing many hooks to insert at different times? Potentially the hooks should return an array of passes or one aggregate pass to ensure the contract is upheld?

Hi @jroesch @Mousius ,
I think having Pass'es (instead of functions) could also work.
I guess what we are after is the ability to assemble and re-use TVM's compilation passes on a target basis.
https://github.com/apache/tvm/pull/8110#discussion_r639559530
Continuing the above comment, this also removes various places otherwise devs need to insert custom passes. Therefore, centralizing them closer to the target seems much cleaner to me. Therefore, it becomes straightforward to follow what passes are being run in the lowering for a given target while also not running passes that are not relevant (that are currently run anyway due to them having identity effect on IRModule in the absense of special attr/nodes/vars in the IRModule).

I believe the tenants should be customization of the compiler happens via passes, passes only can produce IRModules, and all data is stored in the IRModule. Today's compiler requires a little more work to get to this world, but I think we should push in this direction.

I think we broadly agrees on this. @Mousius ?

The proliferation of customizations in the old compile engine for example makes it nearly impossible to refactor the compiler in its current state, and has lead to the world where we need lots of per-flow customization because the compiler is insufficiently factored into a common prefix of code.

While we agree that its better to share the many passes that are required, but does it need to mandate a monolith of TIR passes being applied irrespective of the target ? We'd like to hear you thoughts (I think this has a connection to the so-called phases in lower implementation, right ?). While we could codify the requirement, is it absolutely necessary ? Also will it (having target based pass pipeline) preclude us from having the code factored into a common prefix ?

but I think instead of overriding the lowering code with arbitrary functions we could provide hooks that allow the insertion of target specific passes at the "correct" time in the compiler flow.

The arbitrary function mentioned here could be a pass pipeline (and we could make it a requirement by making it a Pass as you suggested). However, it is interesting know if we can define a universally 'correct' time for the flow considering targets beyond CPUs and GPUs (w/o needing to do inverse lowering to recreate high-level abstraction that was forced lowered due to mandatory passes).  We would love to hear if you have an alternative suggestion to support target-based lowering

This is a great disscussion here. Actually, we are supporting a DSA with TVM, let me share my practice.
1, We only re-use some of tvm relay or tir passes, less than 10 passes, such storage flatten, we don't need most of tvm passes, keep them in our flow means wasting compilation time.
2, We develop passes, and enhance tvm passes for our target, such stroage rewrite.
3, We develop a hybrid ir on tir, in which we can do unified memory allocation and schedule insnstruction across operators.
So we are excited to see tvm can do these in main line.
What we want to have:
1, customzation compilation flow for both relay and tir flow.
2, unified ir to view both graph and tir, supporting inter/intra pass developing.

This LGTM but I'm thinking going back to relay_to_tir being a Function->PrimFunc packed func as you implemented in the companion PR is better since it makes it easier for all the caching, call rewriting, dynamic shape handling and other bookkeeping to be shared. Have you tried out the pass approach and convinced youself that reuse is still possible?

Hi @mbs-octoml, sorry I missed a few replies!
The reason I hoisted it outside of the LowerTE pass is that it effectively bypasses it anyway, LowerExternalFunctions in te_compiler.cc is a massive bypass which starts there and goes around most of TVM before it ends up as a runtime::Module right at the very end. Effectively what's happening is the "default" relay_to_tir is LowerTE and then Targets register their own variants. I think where @jroesch was going with the (IRModule, Function) -> (IRModule, GlobalVar) is that you will want to produce many PrimFuncs to implement one Function and thus you need the entire module, by just introducing this as a Pass we won't have to introduce a new signature specifically for this hook.

(IRModule, Function) -> (IRModule, GlobalVar)
I'm still is favor of this signature since it's a cheep and cheerful way to ensure we don't end up with N ways to implement the lower-and-rewrite-calls machinery embedded in te_complier. I think my earlier question still stands:
Have you tried out the pass approach and convinced youself that reuse is still possible?

@mbs-octoml  / @areusch apologies for the delay, there was a fair amount to tweak in here to reflect all the discussions around this RFC. Please could you take another look as I think this is lined up now :smile_cat:

Thanks @mbs-octoml, I've incorporated this back into the document :smile_cat:

LGTM again (CI will go faster that way, right?)

@areusch is there anything outstanding from you on this RFC? It seems ready to merge after the changes you've requested.

thanks for working through this with us @Mousius ! excited to see this land in TVM!


resize profile images to 740px

Build log
Preview build with this PR (commit): https://output.circle-artifacts.com/output/job/884aaee1-1326-4c80-aa80-eb6adf9f8f58/artifacts/0/index.html


Add more Mistral integration tests for YAQL/Jinja errors

Add more Mistral integration tests to ensure proper exception is thrown and bubbled up to StackStorm for YAQL and Jinja related errors. Rename some of the existing tests to be consistent.

:+1:


The game update cause hunterpie doesn't work

At 2023.10.17,MHW launched a update and changed file chunk/chunkG9.bin,chunk/chunkG60.bin,MonsterHunterWorld.exe,
steam_api64.dll in game folder,now hunterpie can't connect to the game instance.

Fixed in #461

Fixed in #461

Great thanks!


🐛 BUG: Uncaught TypeError: globalThis.XMLHttpRequest is not a constructor

What version of Wrangler are you using?
2.1.9
What operating system are you using?
Mac
Describe the Bug
Minimal repo to reproduce the bug: https://github.com/0xYYY/alpaca-excerpt-bot
Running wrangler publish will result in the following error:
 ⛅ wrangler 2.1.9
-------------------
▲ [WARNING] Enabling node.js compatibility mode for built-ins and globals. This is experimental and has serious tradeoffs. Please see https://github.com/ionic-team/rollup-plugin-node-polyfills/ for more details.

Total Upload: 2207.36 KiB / gzip: 399.23 KiB

✘ [ERROR] A request to the Cloudflare API (/accounts/314050a9a9d7e9c63b202201e738c2ac/workers/scripts/alpaca-excerpt-bot) failed.

  Uncaught TypeError: globalThis.XMLHttpRequest is not a constructor
    at index.js:4548:11 in checkTypeSupport
    at index.js:4569:38 in
  node_modules/rollup-plugin-node-polyfills/polyfills/http-lib/capability.js
    at index.js:15:56 in __init
    at index.js:9073:5 in
  node_modules/rollup-plugin-node-polyfills/polyfills/http-lib/request.js
    at index.js:15:56 in __init
    at index.js:10166:5 in node-modules-polyfills:https
    at index.js:15:56 in __init
    at index.js:10270:21 in node-modules-polyfills-commonjs:https
    at index.js:18:50 in __require2
    at index.js:12865:17 in
  node_modules/node-telegram-bot-api/src/telegramWebHook.js
   [code: 10021]

  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/wrangler2/issues/new/choose

Looks like you're relying on a Node package - the node_compat polyfills won't fix every Node API that a package might rely on.
In particular, Workers don't have XMLHttpRequest, they have the fetch web API. You'll have to polyfill that or find a package that is suited for browsers/Workers.

Understood, thanks for the explanation. I'll close this issue then.


Headers not showing in last library version

Headers disappears after update to the last version of JTAppleCalendar.

??
OK. thats bad.
Can you show your viewDidLoad code?

Fixed, thanks!


How to custom display on Slickgrid?

Hey Guys!
Has anyone tried to apply an alternative display to slickGrid in Serenity?
Here is the example:
https://mleibman.github.io/SlickGrid/examples/example8-alternative-display.html
Thanks!

@lechu90ns  Serenity has a demo like that at here
Unlucky, the demo page does not work at this time
But you can review its code, it will work for you
https://github.com/volkanceylan/Serene/blob/7544f351a3373741949c56081fd18fba4034aa65/Serene/Serene.Web/Modules/BasicSamples/Grids/VSGalleryQA/VSGalleryQAGrid.ts#L22-L46

Thank you for your point! closing


fix search for PQIR & unit

When adding unit or problem type, we use autocomplete. When we write something we filter out all non matching Items, I think we should sort, instead of filtering. Since there are so few options and since it is easy to write something wrong and then have no options.

Example of how sorting would work. All matching items will be above the divider, but all other choices are available as well. Same goes for choosing problem type in PQIRs.

I'll also increase the height of the dropdown list for selecting PQIR's so that we don't have to scroll to see the last two options.

@QiJin-Bouvet This is ready for test. We dropped adding the gray line that you can see between Months and Hours in the design since it's not possible in EDS.


Add urdf_capsule_generation.py

Upload of modified capsule generation script.
Changes since Integration Week July 2023:

Transformation between meshes was fixed, workaround removed
Added docstrings to every function
Added comments in code for easier understanding
Capsule for end effector is now automatically generated
Regex expression for relevant joints can be specified -> no manual removal of irrelevant joints like wheels required
number of joints automatically detected. Specified number only used for sanity checking
min_q, max_q and max_v automatically read from urdf file
added function to visualize joints (useful to check whether the two meshes of each joint get combined correctly)

Overall, the script should now work without any modifications to the URDF file, and all output yamls can be directly used.
Problems and Limitations:

Urdf files can specify offsets for the geometry of a mesh (link-> visual-> origin). In the current URDF, this is only specified for the EE (2cm offset).  In the capsule generation, this is currently ignored, and lead to a capsule that is slightly off.
Current script only works for alternating fixed and revolute joints. Other setups might require more complex solutions.
Capsules are still slightly off, but I doubt that it is caused by this script

I just noticed that the script only works for CONCERT robots. I will change that with the next commit

Commit https://github.com/JakobThumm/sara-shield/pull/15/commits/f771843beb2822bf697df778994070080190df24 enabled the script to work with non-Concert robots as well.
Changes include:

parameter to specify, whether every second join is fixed
scale of mesh is now read from urdf file instead of being hardcoded to 0.001
more warnings when problems occur, instead of silently skipping them


Print address the HTTP server is bound to, along with the context path.

LGTM. I've added you as a collaborator to this repository. Just go wild and do what you want. I'll do post-hoc review and if I see something I don't like, I'll just go in and tweak it myself.


Update dependencies

./bin/update_deps.sh; make gen-check; make update-golden

@elfinhe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
a6650cad1de39df2f52cf86aa39694c0520a5eb4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test gencheck_istio

integ-galley-local-tests_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test integ-galley-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test gencheck_istio

integ-galley-local-tests_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test integ-galley-local-tests_istio

lint_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test gencheck_istio

integ-galley-local-tests_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test integ-galley-local-tests_istio

lint_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test lint_istio

integ-new-install-k8s-tests_istio
3c6a5d2ec60b31a98175023e40bfc676018252d0
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Combine the two openapi files DatabaseCatalogAPI.yaml and DatabaseCatalogAPI_IAP.yaml

Describe the problem
These two files differ only by one line for the the type of authentication.
DatabaseCatalogAPI.yaml is for the public interface and DatabaseCatalogAPI_IAP.yaml is used internally after requests have been processed by the dispatcher.
Proposed solution
Both files could be combined in a source file and recreated during the build process by substituting the authentication line.
Alternatives you've considered
No response
Additional context
No response

Would it be okay to do this using yq? Or should we prefer a sed route?

I would prefer sed, but yq would be ok if it's simple to understand for a neophyte.

Duplicate of #146


Fix parameter change event

Signed-off-by: acuadros95<EMAIL_ADDRESS>Quick fix for parameter modifications notification:

Parameter value should be updated before rclc_parameter_prepare_changed_even is called.

Codecov Report

Merging #310 (3b9b453) into humble (7a85616) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           humble     #310   +/-   ##
=======================================
  Coverage   69.13%   69.13%
=======================================
  Files          16       16
  Lines        2715     2715
  Branches      765      765
=======================================
  Hits         1877     1877
  Misses        451      451
  Partials      387      387

Impacted Files
Coverage Δ

...lc_parameter/src/rclc_parameter/parameter_server.c
82.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Please backport to Rolling

@mergify backport master


Allow mirror to accept parameters to specify what to mount and where

Hi @TrabacchinLuigi ,
Thank you for the contribution 👍 💘  This had to be done much before and waited from others 😄 !


Sliding list sliding items not working in RTL

Ionic version:  (check one with "x")
[ ] 1.x
[x ] 2.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Sliding list don't show the sliding buttons correctly and few issues with the display.
Before sliding:

After sliding left:

After sliding right:

After sliding more and more right:

Expected behavior:

Sliding list should work and show the sliding buttons when trying to slide.
the ion lines should not be displayed under the buttons
Buttons should appeaer from the right side

Steps to reproduce:
Use ion sliding list in any RTL app
Related code:
<ion-list>
  <ion-item-sliding>
<ion-item *ngFor="let message of chatMessages | async">

test 1

test 2

</ion-item>
<ion-item-options side="right">
      <button ion-button color="primary">
        <ion-icon name="text"></ion-icon>
        Button 1
      </button>
    </ion-item-options>
    <ion-item-options side="left">
      <button ion-button color="primary">
        <ion-icon name="remove-circle"></ion-icon>
        Button 2
      </button>
          <button ion-button color="primary">
            <ion-icon name="trash"></ion-icon>
            Button 3
          </button>
        </ion-item-options>
  </ion-item-sliding>
</ion-list>

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.5
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.2
Xcode version: Not installed

I used to have problems with ionic 2 sliding items when using RC versions, try to update ionic to final and the problem will be solved.

@Abderrahmane-H It solves the problem only if style="direction:ltr" is set, RTL is same - not working correctly.

yes you are right , well there is a workaround until there is a fix :
-set the ion-item-sliding direction to ltr, dir="ltr" or by using sass
-set the ion-item direction to rtl,
this is one solved that issue for a blank app set to 'rtl' edited to have sliding items .

@Abderrahmane-H This is just about my previouso comment... it is a workaround but this issue still need to be fixed

Hello, thanks for using Ionic! We will take a look at this!

Hello, thanks for opening an issue with us! I am going to close this issue as a duplicate of https://github.com/driftyco/ionic/issues/8107.


Vendorize Rust dependencies

Use a script to remove any vendorized dependencies to build on Windows
Install rust using the rust-toolset RPM instead of downloading rustup from internet.

/retest