ToDo: diffs FF66-FF67b9

FF67 is scheduled for release 14th May
FF67 release notes [when ready]
FF67 for developers
FF67 compatibility
148 diffs ( 87 new, 31 gone, 30 different )
new in v67.0b9:

[x] pref("browser.aboutConfig.showWarning", true); 5000s - 1500542 - https://github.com/ghacksuserjs/ghacks-user.js/commit/6231d6ebed6302739d816945abf494b519709e4f
[ ] pref("extensions.allowPrivateBrowsingByDefault", false);
[x] pref("media.gmp-gmpopenh264.enabled", true);

no longer hidden - https://github.com/ghacksuserjs/ghacks-user.js/commit/8c12f4bb14048fd67e2cb35b2ddc34c21b68c28e

[ ] pref("ui.use_standins_for_native_colors", false); 2618 move to RFP ALTs

[x] no longer hidden - https://github.com/ghacksuserjs/ghacks-user.js/commit/411805b05cd94b7da77e77c4f797aed4e60f6158

pref("browser.newtabpage.activity-stream.asrouter.userprefs.cfr.addons", true);
pref("browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features", true);
pref("browser.newtabpage.activity-stream.darkModeMessage", false);
pref("browser.newtabpage.activity-stream.discoverystream.endpoints", "https://getpocket.cdn.mozilla.net/");
pref("browser.newtabpage.activity-stream.discoverystream.optOut.0", false);
pref("browser.newtabpage.activity-stream.discoverystream.rec.impressions", "{}");
pref("browser.newtabpage.activity-stream.discoverystream.spoc.impressions", "{}");
pref("browser.newtabpage.activity-stream.telemetry.structuredIngestion", false);
pref("browser.newtabpage.activity-stream.telemetry.structuredIngestion.endpoint", "https://incoming.telemetry.mozilla.org/submit/activity-stream");
pref("browser.tabs.remote.useCrossOriginOpenerPolicy", false);
pref("browser.tabs.remote.useCrossOriginPolicy", false);
pref("browser.tabs.remote.useHTTPResponseProcessSelection", true);
pref("browser.toolbars.keyboard_navigation", true);
pref("dom.prototype_document_cache.enabled", true);
pref("dom.storage.client_validation", true);
pref("dom.storage_access.auto_grants.delayed", true);
pref("dom.webnotifications.allowinsecure", false);
pref("dom.worker.use_medium_high_event_queue", true);
pref("features.normandy-remote-settings.enabled", false);
pref("medium_high_event_queue.enabled", true);
pref("network.cookieSettings.unblocked_for_testing", false);
pref("network.http.referer.defaultPolicy.trackers", 3);
pref("network.http.referer.defaultPolicy.trackers.pbmode", 2);
pref("network.proxy.allow_hijacking_localhost", false);
pref("prio.enabled", false);
pref("privacy.documentCookies.maxage", 0);
pref("security.remote_settings.intermediates.downloads_per_poll", 100);
pref("signon.autofillForms.autocompleteOff", true);
pref("signon.privateBrowsingCapture.enabled", true);

removed, renamed or hidden in v67.0b9:

[ ] pref("browser.cache.disk.smart_size.first_run", true); - 1001 - 1455723
[ ] pref("browser.newtabpage.activity-stream.asrouter.userprefs.cfr", true); - 5000s - 1528953
[ ] pref("dom.event.highrestimestamp.enabled", true); - 2428 - 1485264
[ ] pref("network.cookie.leave-secure-alone", true); - 2705 - 1526214

placeholder

changed in v67.0b9:

pref("browser.sessionstore.max_tabs_undo", 25); // prev: 10 1020
pref("dom.popup_allowed_events", "change click dblclick mouseup pointerup notificationclick reset submit touchend contextmenu"); // prev: "change click dblclick mouseup pointerup notificationclick reset submit touchend" 2212 - https://github.com/ghacksuserjs/ghacks-user.js/commit/e3349d0f076de90b70dfe75c78cfe697a71d12e6
pref("dom.targetBlankNoOpener.enabled", true); // prev: false 2429 - https://github.com/ghacksuserjs/ghacks-user.js/commit/c2034617f0dcef095dc4eda7741b10c8e0dce380
pref("extensions.webcompat-reporter.enabled", true); // prev: false 0518
pref("extensions.webextensions.restrictedDomains", "blahblah"); // prev: "blahblah,testpilot.firefox.com" 2662

placeholder

ignore
click me for details
==NEW
pref("app.update.log.file", false);
pref("apz.pinch_lock.buffer_max_age", "50");
pref("browser.contentblocking.cryptomining.preferences.ui.enabled", true);
pref("browser.contentblocking.fingerprinting.preferences.ui.enabled", true);
pref("browser.measurement.render_anims_and_video_solid", false);
pref("browser.tabs.unloadOnLowMemory", false);
pref("devtools.debugger.map-scopes-enabled", false);
pref("devtools.debugger.ui.editor-wrapping", false);
pref("devtools.layout.boxmodel.highlightProperty", false);
pref("devtools.markup.beautifyOnCopy", false);
pref("devtools.netmonitor.columnsData", "[{\"name\":\"status\",\"minWidth\":30,\"width\":5}, {\"name\":\"method\",\"minWidth\":30,\"width\":5}, {\"name\":\"domain\",\"minWidth\":30,\"width\":10}, {\"name\":\"file\",\"minWidth\":30,\"width\":25}, {\"name\":\"cause\",\"minWidth\":30,\"width\":10},{\"name\":\"type\",\"minWidth\":30,\"width\":5},{\"name\":\"transferred\",\"minWidth\":30,\"width\":10},{\"name\":\"contentSize\",\"minWidth\":30,\"width\":5},{\"name\":\"waterfall\",\"minWidth\":150,\"width\":25}]");
pref("devtools.netmonitor.features.resizeColumns", false);
pref("devtools.netmonitor.response.ui.limit", 10240);
pref("devtools.performance.recording.objdirs", "[]");
pref("devtools.webconsole.groupWarningMessages", false);
pref("dom.inputevent.data.enabled", true);
pref("dom.inputevent.datatransfer.enabled", true);
pref("dom.w3c_touch_events.legacy_apis.enabled", false);
pref("extensions.htmlaboutaddons.enabled", false);
pref("fission.frontend.simulate-events", false);
pref("fission.frontend.simulate-messages", false);
pref("gfx.webrender.debug.small-screen", false);
pref("gl.allow-high-power", true);
pref("identity.fxaccounts.pairing.enabled", true);
pref("identity.fxaccounts.remote.pairing.uri", "wss://channelserver.services.mozilla.com");
pref("identity.fxaccounts.toolbar.accessed", false);
pref("identity.fxaccounts.toolbar.enabled", true);
pref("javascript.options.experimental.fields", false);
pref("javascript.options.ion.full.threshold", 100000);
pref("layout.css.scroll-snap-v1.enabled", false);
pref("layout.cursor.block.enabled", true);
pref("layout.cursor.block.max-size", 32);
pref("layout.lower_priority_refresh_driver_during_load", true);
pref("media.gmp-gmpopenh264.visible", true);
pref("media.rdd-vorbis.enabled", false);
pref("media.wmf.low-latency.force-disabled", false);
pref("pdfjs.viewOnLoad", 0);
pref("privacy.resistFingerprinting.jsmloglevel", "Warn");
pref("privacy.trackingprotection.cryptomining.annotate.enabled", false);
pref("privacy.trackingprotection.fingerprinting.annotate.enabled", false);
pref("security.block_importScripts_with_wrong_mime", true);
pref("security.certerrors.mitm.auto_enable_enterprise_roots", false);
pref("security.certerrors.mitm.priming.enabled", true);
pref("security.certerrors.mitm.priming.endpoint", "https://mitmdetection.services.mozilla.com/");
pref("security.sandbox.rdd.win32k-disable", true);
pref("services.common.uptake.sampleRate", 1);
pref("services.sync.prefs.sync.media.autoplay.default", true);
pref("services.sync.prefs.sync.privacy.trackingprotection.cryptomining.annotate.enabled", true);
pref("services.sync.prefs.sync.privacy.trackingprotection.cryptomining.enabled", true);
pref("services.sync.prefs.sync.privacy.trackingprotection.fingerprinting.annotate.enabled", true);
pref("services.sync.prefs.sync.privacy.trackingprotection.fingerprinting.enabled", true);
pref("signon.showAutoCompleteFooter", true);
pref("toolkit.lazyHiddenWindow", true);
pref("webgl.default-low-power", false);

==REMOVED or HIDDEN
pref("app.normandy.remotesettings.enabled", false);
pref("browser.cache.disk.smart_size.use_old_max", true);
pref("browser.fission.simulate", false);
pref("devtools.browserconsole.ui.filterbar", false);
pref("devtools.canvasdebugger.enabled", false);
pref("devtools.debugger.features.pause-points", true);
pref("devtools.flexboxinspector.enabled", true);
pref("devtools.inspector.changes.enabled", true);
pref("devtools.inspector.flexboxHighlighter.enabled", true);
pref("devtools.inspector.fonthighlighter.enabled", true);
pref("devtools.inspector.scrollable-badges.enabled", false);
pref("devtools.inspector.shapesHighlighter.enabled", true);
pref("devtools.shadereditor.enabled", false);
pref("devtools.webaudioeditor.enabled", false);
pref("devtools.webaudioeditor.inspectorWidth", 300);
pref("devtools.webconsole.ui.filterbar", false);
pref("dom.clearSiteData.enabled", true);
pref("dom.idle-observers-api.fuzz_time.disabled", true);
pref("dom.push.alwaysConnect", false);
pref("dom.select_popup_in_content.enabled", false);
pref("dom.ua_widget.enabled", true);
pref("extensions.geckoProfiler.getSymbolRules", "localBreakpad,dump_syms.exe");
pref("gfx.canvas.skiagl.dynamic-cache", true);
pref("pdfjs.disableOpenActionDestination", true);
pref("pdfjs.disablePageMode", false);
pref("pdfjs.showPreviousViewOnLoad", true);
pref("privacy.permissionPrompts.showCloseButton", false);

==CHANGED
pref("app.releaseNotesURL", "https://www.mozilla.org/%LOCALE%/firefox/%VERSION%beta/releasenotes/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=whatsnew"); // prev: "https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/releasenotes/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=whatsnew"
pref("app.update.channel", "beta"); // prev: "release"
pref("app.update.url.details", "https://www.mozilla.org/%LOCALE%/firefox/beta/notes"); // prev: "https://www.mozilla.org/%LOCALE%/firefox/notes"
pref("app.update.url.manual", "https://www.mozilla.org/firefox/beta"); // prev: "https://www.mozilla.org/firefox/"
pref("browser.dictionaries.download.url", "https://addons.mozilla.org/%LOCALE%/firefox/language-tools/"); // prev: "https://addons.mozilla.org/%LOCALE%/firefox/dictionaries/"
pref("browser.newtabpage.activity-stream.asrouter.providers.cfr", "{\"id\":\"cfr\",\"enabled\":true,\"type\":\"local\",\"localProvider\":\"CFRMessageProvider\",\"frequency\":{\"custom\":[{\"period\":\"daily\",\"cap\":1}]},\"categories\":[\"cfrAddons\",\"cfrFeatures\"]}"); // prev: "{\"id\":\"cfr\",\"enabled\":true,\"type\":\"local\",\"localProvider\":\"CFRMessageProvider\",\"frequency\":{\"custom\":[{\"period\":\"daily\",\"cap\":1}]}}"
pref("browser.newtabpage.activity-stream.discoverystream.config", "{\"api_key_pref\":\"extensions.pocket.oAuthConsumerKey\",\"enabled\":false,\"show_spocs\":false,\"layout_endpoint\":\"https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic\"}"); // prev: "{\"api_key_pref\":\"extensions.pocket.oAuthConsumerKey\",\"enabled\":false,\"show_spocs\":true,\"layout_endpoint\":\"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic\"}"
pref("devtools.debugger.features.column-breakpoints", true); // prev: false
pref("devtools.debugger.features.log-points", true); // prev: false
pref("devtools.debugger.features.windowless-workers", true); // prev: false
pref("devtools.performance.recording.ui-base-url", "https://profiler.firefox.com"); // prev: "https://perf-html.io"
pref("dom.block_external_protocol_in_iframes", true); // prev: false
pref("dom.keyboardevent.keypress.hack.dispatch_non_printable_keys", "www.icloud.com"); // prev: ""
pref("dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode", "*.collabserv.com,*.gov.online.office365.us,*.officeapps-df.live.com,*.officeapps.live.com,*.online.office.de,*.partner.officewebapps.cn,*.scniris.com"); // prev: ""
pref("javascript.options.dynamicImport", true); // prev: false
pref("layers.shared-buffer-provider.enabled", true); // prev: false
pref("layout.dynamic-reflow-roots.enabled", true); // prev: false
pref("media.av1.use-dav1d", true); // prev: false
pref("network.proxy.no_proxies_on", ""); // prev: "localhost, <IP_ADDRESS>"
pref("pdfjs.scrollModeOnLoad", -1); // prev: 0
pref("pdfjs.sidebarViewOnLoad", -1); // prev: 0
pref("pdfjs.spreadModeOnLoad", -1); // prev: 0
pref("security.webauth.u2f", true); // prev: false
pref("toolkit.telemetry.enabled", true); // prev: false
pref("urlclassifier.disallow_completions", "goog-downloadwhite-digest256,base-track-digest256,mozstd-trackwhite-digest256,content-track-digest256,mozplugin-block-digest256,mozplugin2-block-digest256,block-flash-digest256,except-flash-digest256,allow-flashallow-digest256,except-flashallow-digest256,block-flashsubdoc-digest256,except-flashsubdoc-digest256,goog-passwordwhite-proto,ads-track-digest256,social-track-digest256,analytics-track-digest256,base-fingerprinting-track-digest256,content-fingerprinting-track-digest256,base-cryptomining-track-digest256,content-cryptomining-track-digest256,fanboyannoyance-ads-digest256,fanboysocial-ads-digest256,easylist-ads-digest256,easyprivacy-ads-digest256,adguard-ads-digest256"); // prev: "test-malware-simple,test-harmful-simple,test-phish-simple,test-unwanted-simple,test-track-simple,test-trackwhite-simple,test-block-simple,goog-downloadwhite-digest256,base-track-digest256,mozstd-trackwhite-digest256,content-track-digest256,mozplugin-block-digest256,mozplugin2-block-digest256,block-flash-digest256,except-flash-digest256,allow-flashallow-digest256,except-flashallow-digest256,block-flashsubdoc-digest256,except-flashsubdoc-digest256,goog-passwordwhite-proto,ads-track-digest256,social-track-digest256,analytics-track-digest256,base-fingerprinting-track-digest256,content-fingerprinting-track-digest256,base-cryptomining-track-digest256,content-cryptomining-track-digest256,fanboyannoyance-ads-digest256,fanboysocial-ads-digest256,easylist-ads-digest256,easyprivacy-ads-digest256,adguard-ads-digest256"

some bugzilla tickets

app.normandy.remotesettings.enabled
Bug 1519276 - Use Feature Gates for Remote Settings integration
Bug 1506175 - Fetch recipes from Remote Settings

app.update.log.file
Bug 1526475 - Add file logging to the updater

apz.pinch_lock.buffer_max_age
Bug 1451461 - Make pinch locking unaffected by input sensitivity.

browser.aboutConfig.showWarning
Bug 1500542 - Added ability to disable the disclaimer page of the new about:config.

browser.cache.disk.smart_size.first_run
Bug 1455723 - Firefox59 does not properly honor cache size set in autoconfig files,

browser.cache.disk.smart_size.use_old_max
Bug 1455723 - Firefox59 does not properly honor cache size set in autoconfig files,

browser.contentblocking.cryptomining.preferences.ui.enabled
Bug 1527917 - Enable cryptomining and fingerprinting blocking options in about:preferences.
Bug 1522567 - Add cryptomining and fingerprinting protection options to custom content blocking preferences.

browser.contentblocking.fingerprinting.preferences.ui.enabled
Bug 1527917 - Enable cryptomining and fingerprinting blocking options in about:preferences.
Bug 1522567 - Add cryptomining and fingerprinting protection options to custom content blocking preferences.

browser.dictionaries.download.url
Bug 1532208 - Update Add Dictionary Link in right click context menu.

browser.fission.simulate
Bug 1533467 - Rename the browser.fission.simulate pref.

browser.measurement.render_anims_and_video_solid
Bug 1525320: Add config prefs that let us tell media and animated images to paint only the first frame

browser.newtabpage.activity-stream.asrouter.providers.cfr
Bug 1528953 - Add pref to opt out of recommended features
Bug 1499110 - Make CFR/ASR preferences compatible with roll-outs

browser.newtabpage.activity-stream.asrouter.userprefs.cfr
Bug 1528953 - Add pref to opt out of recommended features

browser.newtabpage.activity-stream.asrouter.userprefs.cfr.addons
Bug 1528953 - Add pref to opt out of recommended features

browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features
Bug 1528953 - Add pref to opt out of recommended features

browser.sessionstore.max_tabs_undo
Bug 1135303 - Don't warn when closing multiple tabs if sessionstore can undo close the requested amount of tabs.

browser.tabs.remote.useCrossOriginOpenerPolicy
Bug 1529004 - Add browser.tabs.remote.useCrossOriginOpenerPolicy to all.js

browser.tabs.remote.useHTTPResponseProcessSelection
Bug 1528360 - Enable httpResponseProcessSelection by default
Bug 1522637 - Part 6: Enable httpResponseProcessSelection by default,

browser.tabs.unloadOnLowMemory
Bug 1533698 - Enable tab unloading in low-memory scenarios on beta too
Bug 675539 - Unload tabs in low-memory scenarios

browser.toolbars.keyboard_navigation
Bug 1506510 - add keyboard focus styling for toolbar/urlbar buttons.
Bug 1436086: Implement keyboard navigation for the main and Bookmarks toolbars.

devtools.browserconsole.ui.filterbar
Bug 1523861 - Remove toggle filter button and always show the filter buttons toolbar.

devtools.canvasdebugger.enabled
Bug 1403938 - remove Canvas Debugger client;

devtools.flexboxinspector.enabled
Bug 1526465 - Remove devtools.inspector.flexboxHighlighter.enabled and devtools.flexboxinspector.enabled prefs.
Bug 1509908 - Enabling the flexbox tools on all channels;

devtools.inspector.changes.enabled
Bug 1529379 - Remove devtools.inspector.changes.enabled pref.
Bug 1491887 - Enable tracking CSS changes and the Changes panel for all release channels;

devtools.inspector.flexboxHighlighter.enabled
Bug 1526465 - Remove devtools.inspector.flexboxHighlighter.enabled and devtools.flexboxinspector.enabled prefs.
Bug 1509908 - Enabling the flexbox tools on all channels;

devtools.inspector.fonthighlighter.enabled
Bug 1529468 - Remove devtools.inspector.fonthighlighter.enabled pref.
Bug 1486720 - Enable font highlighter.
Bug 1440855 - New font text-run highlighter used from the font inspector;r=gl

devtools.inspector.scrollable-badges.enabled
Bug 1528181 - Enable the scrollable badge for good;
Bug 1523543 - Enable the scrollable markup-badge in nightly;
Bug 1521776 - Add new scrollable markup badges;

devtools.inspector.shapesHighlighter.enabled
Bug 1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref.

devtools.layout.boxmodel.highlightProperty
Bug 1493677 - Link box-model values to their source CSS rules.

devtools.markup.beautifyOnCopy
Bug 1363990 - New pref to beautify HTML code when copying from the inspector;

devtools.netmonitor.columnsData
Bug 1358414 - Introduce column resizer in request list;

devtools.netmonitor.features.resizeColumns
Bug 1358414 - Introduce column resizer in request list;

devtools.netmonitor.response.ui.limit
Bug 1498565 - Getting Firefox to stop  freezing when large file is loaded in Response tab

devtools.performance.recording.objdirs
Bug 1504101 - Add UI to the performance pane that lets the user pick an objdir for local builds.

devtools.performance.recording.ui-base-url
Bug 1525358 - Rename perf.html to profiler.firefox.com;
Bug 1480593 - Allow setting a different instance of perf.html for the new performance panel, using a pref

devtools.shadereditor.enabled
Bug 1342237 - remove Shader Editor Panel;

devtools.webaudioeditor.enabled
Bug 1403944 - Remove Web Audio Editor front and panel;

devtools.webaudioeditor.inspectorWidth
Bug 1403944 - Remove Web Audio Editor front and panel;

devtools.webconsole.groupWarningMessages
Bug 1525613 - Create a preference to enable message grouping in the console.

devtools.webconsole.ui.filterbar
Bug 1523861 - Remove toggle filter button and always show the filter buttons toolbar.

dom.block_external_protocol_in_iframes
Bug 1522181 - multiple external protocol URL blocker behind pref,

dom.clearSiteData.enabled
Bug 1488957 - Get rid of dom.clearSiteData.enabled pref,

dom.event.highrestimestamp.enabled
Bug 1485264 - Removed dom.event.highrestimestamp.enabled pref

dom.idle-observers-api.fuzz_time.disabled
Bug 1532351.  Remove idle observer API on navigator.

dom.inputevent.data.enabled
Bug 998941 - part 1-1: Implement InputEvent.data of UI Events

dom.inputevent.datatransfer.enabled
Bug 998941 - part 2-1: Implement InputEvent.dataTransfer declared by Input Events

dom.keyboardevent.keypress.hack.dispatch_non_printable_keys
Bug 1538966 - Beta/Release - Use legacy keyCode and charCode for sites with known issues.

dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode
Bug 1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref.
Bug 1538970 - Add IBM domains as wildcard exceptions for legacy keyCode and charCode.
Bug 1538966 - Beta/Release - Use legacy keyCode and charCode for sites with known issues.
Bug 1510111 - Remove www.rememberthemilk.com from the blacklist of keyCode/charCode mirroring of keypress events
Bug 1502795 - Set keyCode or charCode of keypress event whose value is zero to the other's non-zero value by default again unless dispatched on known broken web apps

dom.popup_allowed_events
Bug 433274 - Allow popups from context menu events,

dom.prototype_document_cache.enabled
Bug 1527977 - Share XUL prototype cache with XUL and XHTML.

dom.push.alwaysConnect
Bug 1524655 - Remove dom.push.alwaysConnect and connect unconditionally.

dom.select_popup_in_content.enabled
Bug 1528098 - Remove content-select code.

dom.storage.client_validation
Bug 1517089 - Part 14: Use ClientManagerService for client validation;

dom.storage_access.auto_grants.delayed
Bug 1531538 - Delay resolving the promise returned from requestStorageAccess when the automatic storage access grants are invoked;

dom.targetBlankNoOpener.enabled
Bug 1503681 - rel=noopener implicit for target=_blank in anchor and area elements when no rel attribute is set,

dom.ua_widget.enabled
Bug 1507895 - Part V, Remove dom.ua_widget.enabled pref

dom.w3c_touch_events.legacy_apis.enabled
Bug 1412485, disable legacy touch APIs on desktop,

dom.webnotifications.allowinsecure
Bug 1429432 - Require Secure Context for Notifications.

dom.worker.use_medium_high_event_queue
Bug 1522316, use medium high priority queue for worker->main thread control messages,

extensions.allowPrivateBrowsingByDefault
Bug 1511636: update incognito support to use pref and permissions

extensions.geckoProfiler.getSymbolRules
Bug 1509549 - Use ProfilerGetSymbols for geckoProfiler WebExtension symbolication and remove all other sources of symbolication.

extensions.htmlaboutaddons.enabled
Bug 1514316 - Basic HTML list view for about:addons behind a pref

extensions.webextensions.restrictedDomains
Bug 1523980 Revoke special testpilot permissions

features.normandy-remote-settings.enabled
Bug 1519276 - Use Feature Gates for Remote Settings integration

fission.frontend.simulate-events
Bug 1533467 - Rename the browser.fission.simulate pref.

fission.frontend.simulate-messages
Bug 1533467 - Rename the browser.fission.simulate pref.

gfx.canvas.skiagl.dynamic-cache
Bug 1530471 - remove prefs for related to SkiaGL canvas

gfx.webrender.debug.small-screen
Bug 1531196 - Add a "small-screen" debug pref to shrink the overlay a bit.

gl.allow-high-power
Bug 1523728 - Add gl.allow-high-power:true, webgl.default-low-power:false.

identity.fxaccounts.pairing.enabled
Bug 1539211 - Enable the Firefox Accounts pairing preference.
Bug 1490671 - Add FxA device pairing.

identity.fxaccounts.remote.pairing.uri
Bug 1490671 - Add FxA device pairing.

identity.fxaccounts.toolbar.accessed
Bug 1524665 - Add FxA avatar toolbar menu,

identity.fxaccounts.toolbar.enabled
Bug 1524665 - Add FxA avatar toolbar menu,

javascript.options.dynamicImport
Bug 1517546 - Enable dyanmic module import by default
Bug 1522491 - Enable dynamic module import on nightly builds only
Bug 1342012 - Initial browser support for dynamic import from module scripts

javascript.options.experimental.fields
Bug 1529758 - Add a pref for fields.

javascript.options.ion.full.threshold
Bug 1382650 part 4 - Split Ion warmup threshold JitOption in 'normal' and 'full' options.

layers.shared-buffer-provider.enabled
Bug 1531417 - enable shared buffer provider for software canvas on all platforms.

layout.css.scroll-snap-v1.enabled
Bug 1528639 - Implement scroll-margin parser and serializer.

layout.cursor.block.enabled
Bug 1445844 - Add a pref to block large custom cursors outside of the viewport's bounds.

layout.cursor.block.max-size
Bug 1445844 - Add a pref to block large custom cursors outside of the viewport's bounds.

layout.dynamic-reflow-roots.enabled
Bug 1510369 part 3: Add about:config pref 'layout.dynamic-reflow-roots.enabled' (enabled by default).

layout.lower_priority_refresh_driver_during_load
Bug 1506949, use idle queue for RefreshDriver tick betweek fcp and load,

media.av1.use-dav1d
Bug 1536538 - Enable libdav1d on Linux on beta.
Bug 1534814 - pref on rdd and av1 for linux.
Bug 1535038 - Make dav1d the default AV1 decoder in OSX.
Bug 1533742 - Flip dav1d pref to on for windows.
Bug 1493400 - Implement platform decoder for dav1d.

media.gmp-gmpopenh264.enabled
Bug 1527811 - Hide OpenH264 by default on Windows on ARM.

media.gmp-gmpopenh264.visible
Bug 1527811 - Hide OpenH264 by default on Windows on ARM.

media.rdd-vorbis.enabled
Bug 1500596 - pt3 - Add remote audio decoding for Vorbis.

media.wmf.low-latency.force-disabled
Bug 1305340 - Enable low-latency decoding on Windows 10 and later.

medium_high_event_queue.enabled
Bug 1524006 - Add a medium-high priority queue between high and normal,

network.cookie.leave-secure-alone
Bug 1526214 - Get rid of network.cookie.leave-secure-alone,

network.cookieSettings.unblocked_for_testing
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo,

network.http.referer.defaultPolicy.trackers
Bug 1530076 - Part 1: Add support for modifying the default referrer policy that is applied to third-party trackers when the cookie policy is set to reject third-party trackers;

network.http.referer.defaultPolicy.trackers.pbmode
Bug 1530076 - Part 1: Add support for modifying the default referrer policy that is applied to third-party trackers when the cookie policy is set to reject third-party trackers;

network.proxy.allow_hijacking_localhost
Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set

network.proxy.no_proxies_on
Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set

privacy.documentCookies.maxage
Bug 1529836 - Part 1: Add support for capping the maximum life-time of client-side cookies;

privacy.permissionPrompts.showCloseButton
Bug 1479335 - Remove permissions close button

privacy.resistFingerprinting.jsmloglevel
Bug 1407366 - Part 4: Adding a test case for testing letterboxing.

privacy.trackingprotection.cryptomining.annotate.enabled
Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 3 - Cryptomining-annotation,

privacy.trackingprotection.fingerprinting.annotate.enabled
Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 2 - Fingerprinting-annotation,

security.block_importScripts_with_wrong_mime
Bug 1514680 - Strictly enforce the MIME type of scripts loaded by importScripts().

security.certerrors.mitm.auto_enable_enterprise_roots
Bug 1529643 - Implement MitM priming on certificate error pages.

security.certerrors.mitm.priming.enabled
Bug 1529643 - Implement MitM priming on certificate error pages.

security.certerrors.mitm.priming.endpoint
Bug 1529643 - Implement MitM priming on certificate error pages.

security.remote_settings.intermediates.downloads_per_poll
Bug 1404934 - Wire-up Intermediate Preloading

security.sandbox.rdd.win32k-disable
Bug 1511438 Part 2: Enable win32k lockdown on RDD process.

security.webauth.u2f
Bug 1539541 - Enable FIDO U2F API, and permit registrations for Google Accounts
Bug 1245527 - Rewrite U2F.cpp to use U2FTokenManager. r=keeler,

services.common.uptake.sampleRate
Bug 1535962: Introduce a sample rate for reporting uptake telemetry events

services.sync.prefs.sync.media.autoplay.default
Bug 1526945 - Sync Block websites from automatically playing sound option

services.sync.prefs.sync.privacy.trackingprotection.cryptomining.annotate.enabled
Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 3 - Cryptomining-annotation,

services.sync.prefs.sync.privacy.trackingprotection.cryptomining.enabled
Bug 1529560 - Sync new options of blocking Cryptominers and Fingerprinters

services.sync.prefs.sync.privacy.trackingprotection.fingerprinting.annotate.enabled
Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 2 - Fingerprinting-annotation,

services.sync.prefs.sync.privacy.trackingprotection.fingerprinting.enabled
Bug 1529560 - Sync new options of blocking Cryptominers and Fingerprinters

signon.autofillForms.autocompleteOff
Bug 1531135 - Honor autocomplete=off on password when signon.autofillForms.autocompleteOff is false.

signon.privateBrowsingCapture.enabled
Bug 1520960 - Allow login capture from form submissions in private browsing when pref'd on.

signon.showAutoCompleteFooter
Bug 1189618 - Add a 'View Saved Logins' footer to the password manager autocomplete popup.
Bug 1534442 - Turn on the signon.showAutoCompleteFooter pref.
Bug 1530029 - Turn on the signon.showAutoCompleteFooter pref.

toolkit.lazyHiddenWindow
Bug 827976 - Create the hidden window lazily on non-Mac platforms.

ui.use_standins_for_native_colors
Bug 1485266 - Use stand-ins for native colors when RFP is enabled

urlclassifier.disallow_completions
Bug 1329349 - Remove test lists from urlclassifier.disallow_completions.
Bug 1517641 - [2.0] Rename blocklist names to use a three-part naming scheme.
Bug 1517641 - [1.0] Add experimental ad-blocking category to the Tracking Protection API.
Bug 1513490 - Support update cryptomining and fingerprinting list in SafeBrowsing.
Bug 1519660 - Remove flash info bar from SafeBrowsing list.
Bug 1509555 - Part 2: Remove the core fastblock code

webgl.default-low-power
Bug 1523728 - Add gl.allow-high-power:true, webgl.default-low-power:false.

While looking at https://bugzilla.mozilla.org/show_bug.cgi?id=1519276 I got #688
You can check your DateTime on https://classify-client.services.mozilla.com/api/v1/classify_client/?format=json

@earthlng - dumped a load of items in ignore, feel free to scrutinize
extensions.allowPrivateBrowsingByDefault (default false). I thought it could go in 2664 if you're happy with that. What I'm not quite understanding is WTF this is doing. I just had a bit of a play, if you can confirm what I think it does exactly (which is not what I expected)
see: for pics and shit: https://support.mozilla.org/en-US/kb/extensions-private-browsing
bugzilla for code nerds: https://bugzilla.mozilla.org/show_bug.cgi?id=1511636

option1: When the pref is false, you can see a Run in Private Windows option on each ext

all extensions are disabled in PB mode by default
you have granular control (and will need to set it on install or manually when you update to 67)

options2: When the pref is true, you don't get any option

all extensions are disabled in PB mode by default
you have no granular control
I thought the pref was to change the default (radio button), but that's not what it does

Can you confirm that? That seems whack (although I get why they may have done it like this). I tested this by setting to true and opening a PB window, and sure enough all extension icons were removed
So I guess we add it and enforce it as false? Or don't add it?

When the preference is set to true, the extensions are enabled by default in private windows.
When the preference is set to false, the extensions are not enabled by default in private windows.
Regardless of this pref, all already installed extensions at the time of updating to 67 will remain to be allowed in private windows unless you go in and toggle them to off.

I tested this by setting to true and opening a PB window, and sure enough all extension icons were removed

true = allow in private browsing. It sounds like your testing suggests that the pref is doing the opposite of what it's supposed to do!? Are you sure you tested correctly?

dumped a load of items in ignore, feel free to scrutinize

the 3 security.certerrors.mitm.* might be worth considering since it's an outgoing connection that some people might not want

the 3 security.certerrors.mitm.* might

I'll move em back up, but I don;t really see any point in it. I know some people want a "quiet" fox and can see the trade-offs and think in shades .. but... <snipped for sanity>

Are you sure you tested correctly

Maybe not. I only had the one extension. But why would the extension option disappear then? I can check that a restart isn't required, but that makes no sense that it would. Did you test it?

note to self to read https://bugzilla.mozilla.org/show_bug.cgi?id=1536459

I think we could also move 2203 to RFP ALTs now we have letterboxing. I've added it to the list. What do you think - @earthlng

@earthlng release was pushed out by a week (I edited OP to show this). Do you want to do a new diff so I can rip into this .. just in case it prevents any mess-ups b9 -> b18

67.0b18 changes since 67.0b9
new
pref("browser.tabs.unloadOnLowMemory", true); // "new" with value false in 67.0b9
pref("devtools.netmonitor.features.resizeColumns", true); // "new" with value false in 67.0b9
pref("dom.webnotifications.requireuserinteraction", false);
pref("permissions.desktop-notification.postPrompt.enabled", false);
pref("permissions.eventTelemetry.enabled", false);
pref("permissions.postPrompt.animate", true);

changed
pref("dom.targetBlankNoOpener.enabled", true); // prev: false
pref("image.cache.max-rasterized-svg-threshold-kb", 204800); // prev: 92160
pref("layout.dynamic-reflow-roots.enabled", true); // prev: false
pref("media.autoplay.default", 1); // prev: 0

Oh nos .. https://www.zdnet.com/article/privacy-concerns-raised-about-upcoming-client-hints-web-standard/

67.0 changes since 67.0b18
new
pref("browser.contentblocking.introDelaySeconds", 1800);
pref("browser.tabs.remote.useHTTPResponseProcessSelection", false); // "new" with value true in 67.0b18
pref("network.protocol-handler.external.res", false);
pref("trailhead.firstrun.branches", "control");

removed, renamed or hidden
pref("browser.newtabpage.activity-stream.feeds.migration", true);
pref("browser.newtabpage.activity-stream.migrationExpired", false);
pref("browser.newtabpage.activity-stream.migrationLastShownDate", 0);
pref("browser.newtabpage.activity-stream.migrationRemainingDays", 4);
pref("dom.performance.enable_scheduler_timing", true);
pref("media.wmf.vp9.enabled", true);
changed
pref("app.releaseNotesURL", "https://www.mozilla.org/%LOCALE%/firefox/%VERSION�ta/releasenotes/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=whatsnew"); // prev: "https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/releasenotes/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=whatsnew"
pref("app.update.channel", "beta"); // prev: "release"
pref("app.update.url.details", "https://www.mozilla.org/%LOCALE%/firefox/beta/notes"); // prev: "https://www.mozilla.org/%LOCALE%/firefox/notes"
pref("app.update.url.manual", "https://www.mozilla.org/firefox/beta"); // prev: "https://www.mozilla.org/firefox/"
pref("extensions.webcompat-reporter.enabled", true); // prev: false
pref("toolkit.telemetry.enabled", true); // prev: false

Here's whats left.  These are false, so I think we can just ignore them
pref("browser.newtabpage.activity-stream.discoverystream.endpoints", "https://getpocket.cdn.mozilla.net/");
pref("browser.newtabpage.activity-stream.discoverystream.optOut.0", false);
pref("browser.newtabpage.activity-stream.telemetry.structuredIngestion", false);
pref("browser.newtabpage.activity-stream.telemetry.structuredIngestion.endpoint", "https://incoming.telemetry.mozilla.org/submit/activity-stream");

IDK what this all means, IDK if false is good or bad. Also keep in mind that a lot of things like this are off when first introduced (see more examples below) and get flipped in tests or when ready. If it's not that important, then maybe not worth adding? - @earthlng
pref("browser.tabs.remote.useCrossOriginOpenerPolicy", false);
  // https://bugzilla.mozilla.org/show_bug.cgi?id=1529004
pref("browser.tabs.remote.useCrossOriginPolicy", false);

IDK WTF this is
pref("browser.tabs.remote.useHTTPResponseProcessSelection", false);
  // https://bugzilla.mozilla.org/show_bug.cgi?id=1528360
  // https://bugzilla.mozilla.org/show_bug.cgi?id=1522637

These look cool. Note that we have SW's disabled. And that Mozilla will enable these soon. So again, IDK if it's worth adding.
pref("dom.webnotifications.requireuserinteraction", false);
pref("permissions.desktop-notification.postPrompt.enabled", false);
  // add these inactive true?
  // the first blocks WN until you have interacted with the site
  // the second, 99% sure, adds an icon in the urlbar to visually alert you, and so you can click it to change the WN permission (for that site)
  // test: https://www.bennish.net/web-notifications.html

Again. We clear cookies on close, or users use an extension (suckers!), or block them outright (like a ninja master). This will get changed when they play with it in studies. Might be ok to add inactive as a FYI?
pref("privacy.documentCookies.maxage", 0);
  // https://bugzilla.mozilla.org/show_bug.cgi?id=1529836

Not looked at yet
pref("signon.autofillForms.autocompleteOff", true);

Could maybe add this as a FYI to the passport section. Allows saving of pw's when in PB mode.
pref("signon.privateBrowsingCapture.enabled", true);

the first blocks WN until you have interacted with the site

Note that we have SW's disabled

WN = Web Notifications ...
SW = ? ...
I know you're doing a great job and handle settings so frequently that acronyms become obvious, but for those who wish to learn maybe having the full denomination rather than the acronym would help....

SW = ? ...

Service Workers. We might need to add a section to the wiki just for acronyms at this point... 😹

I just watched Captain Marvel .. i know what u are now :cat2:

Service Workers, OK I remember/know that.
I've been off for some from following user.js's development (though updating), have so many other things in mind, brains certainly not as zealous as 20 years ago, that I sort of forget letter links so to say. Forget, but others may just don't know them even if they know the full name...
 These are false, so I think we can just ignore them

Yes I think that's fine, because browser.newtabpage.activity-stream.feeds.discoverystreamfeed and browser.newtabpage.activity-stream.feeds.telemetry should kill that stuff early on anyway.

browser.tabs.remote.useCrossOrigin* is probably not ready to use yet. Best to ignore for now, IMO. (not even enabled in nightly either atm)

useHTTPResponseProcessSelection - not sure exactly what this is all about but probably best to wait until they enable it by default.

webnotifications - afaik we disable that shit anyway but maybe you changed that, idk. Frankly I don't understand what you're doing anymore. You removed so much useful stuff that my file is now so very different from the master that I don't even bother to sync the changes anymore.

(privacy.documentCookies.maxage) Might be ok to add inactive as a FYI?

yes. Could be handy for people who don't clear cookies on shutdown

signon.autofillForms.autocompleteOff - title of the ticket is "Honor autocomplete=off on password when signon.autofillForms.autocompleteOff is false." but we already disable signon autofills with 0905 so I don't think this matters at all.

privateBrowsingCapture - again, you removed so much FYI stuff that I don't know why you'd include one but remove others. Up to you. IMO it's totally unnecessary to FYI this because it simply allows to save logins in PB windows but people can still choose not to save them. So why disable it? IDK

Frankly I don't understand what you're doing anymore

When or if you do the changelog, you'll see that the effective difference to your browser is almost nothing. Almost everything that was removed was already covered by another active pref, or was already at default, or was inactive (the SB ones are three ticks in the UI, sorry for the loss of that info).
The few things that were changed, stemmed from all the things that people found troublesome, or overrode (not everything was changed, just revisited). They changed because they don't make sense any more (it's still a template). It's really not that much.

You removed so much useful stuff that my file is now so very different from the master that I don't even bother to sync the changes anymore

Well, I hope you do get back in sync. Nothing of any real importance was lost. Anything from changelog that you feel strongly about, can always be put back.

changes

The password one was just a suggestion - inactive for those who wanted to keep the status quo as the old PB mode, but you're right, it's just extra crap. Users have to tick "ask to save passwords" for starters (options UI). And then when using passwords FF prompts to save them. And it would still do the same in PB mode (default true on the new pref).
Web Notifications: we disable Service Workers only. That's all that is needed to stop SW and Web Notifications and Push. I was just suggesting maybe adding the two WN prefs for those who want SW+WN but could then limit them. But TBH, I really can't see the point: as I said earlier: these will get flipped when ready. It's these sort of entries that just end up being the items we end up removing down the track as dead wood, matching default.
Thanks for your thoughts on the others

@earthlng close this when you want me to do a release, thanks

^^ see my comment here. Other than that I think we're done here. Feel free to close and do a release. Thanks mate


Added Developer Guide, Refactored Location with Offense Class & added Request Command with limited cases

Codecov Report

Merging #115 into master will increase coverage by 1.51%.
The diff coverage is 55.88%.

@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
+ Coverage     33.25%   34.77%   +1.51%
- Complexity      185      191       +6
============================================
  Files            58       58
  Lines          1350     1392      +42
  Branches        149      151       +2
============================================
+ Hits            449      484      +35
- Misses          879      884       +5
- Partials         22       24       +2

Impacted Files
Coverage Δ
Complexity Δ

src/seedu/addressbook/common/Messages.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

src/seedu/addressbook/Location.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

src/seedu/addressbook/storage/jaxb/AdaptedTag.java
100% <100%> (ø)
4 <0> (ø)
:arrow_down:

src/seedu/addressbook/commands/RequestHelp.java
33.33% <33.33%> (ø)
2 <2> (?)

src/seedu/addressbook/inbox/Msg.java
9.33% <71.42%> (+9.33%)
0 <0> (ø)
:arrow_down:

src/seedu/addressbook/parser/Parser.java
82.4% <80%> (-0.25%)
26 <2> (+3)

src/seedu/addressbook/data/person/Offense.java
84.84% <87.5%> (-2.66%)
9 <6> (+1)

src/seedu/addressbook/data/person/Status.java
69.23% <0%> (-15.39%)
6% <0%> (-1%)

src/seedu/addressbook/inbox/WriteNotification.java
11.62% <0%> (+11.62%)
1% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78be6b0...8a87caa. Read the comment docs.


Are we actually going to do anything about the issues with the blocks?

There's been numerous issues concerning the new block design for Scratch 3 on Github and Scratch alike, and yet nothing's been addressed.
Here's a few examples:
The block colours are too bright and not diverse.
Scratch Forum, LLK/scratch-gui#851, LLK/scratch-gui#3914, #1032, #995
The block text doesn't contrast with blocks and fails WebAIM contrast tests, and it's too thin.
#1492
There's also numerous complaints about 3.0's block thickness, too numerous to reference.
Are any of these being addressed? There's been a lot of disscussion about these issues but nothing much seems to have been really set in motion.

The short answer is yes. The issues in Github are not an exhaustive list of our roadmap.


INSTALL.md is out of date with respect to facebook-clang-plugins

As of this commit: https://github.com/facebook/facebook-clang-plugins/commit/305d79cdda62e91e6713a83ce056c74821d9bb7e, it appears that facebook-clang-plugins requires C++14 support. C++14 support was only added to GCC 4.9/5.0: https://gcc.gnu.org/projects/cxx-status.html#cxx14
However, the building-from-source notes for Infer (https://github.com/facebook/infer/blob/master/INSTALL.md) state you can use GCC 4.7.2.
This is a conflict because 4.7.2 cannot build facebook-clang-plugins.
[avj@infer tmp]$ gcc -dumpversion
4.8.5
[avj@infer tmp]$ g++ -std=c++14 test.cpp
g++: error: unrecognized command line option ‘-std=c++14’

The easiest fix is probably just to modify the installation notes to require something like GCC 5.x (given that 4.9.x only has partial C++14 support).

Good catch! The manual should be updated.

Updated the manual on master. Closing the task.


Search history

Many sites show your recent searches, along with an X to clear, when going to do a new search. We should have something similar.

Question here: is this something you're looking to do locally or across devices?

For now, locally, and then we can hook into an API. Also, if we decide to only store like last 10 items, we may just be able to write fo the wallet.


Multiple Mime-Types for an extension

This relates to: koajs/koa#617.
As an extension can correspond to multiple mime-types, wouldn't it be correct to return an array of all matches and let libraries handle that?
Perhaps a .lookupAll() which strictly returns an array to avoid breaking existing code or over-complicating something which not everyone will want to make use of.

@dougwilson Anyone working on this?

HI @thihara nope. I see you made a PR, so awesome!

This still has value, I just ran into it now. I see the pr for allExtensions but not for lookupAll (all mime types from a single extension)
Makes it kind of difficult to check that the binary is what you are expecting from the extension or content-type headers.
I'm going to log an issue on our tracking system, if it doesn't move the odds are I will do it.

I took a crack at this today and have a PR open for it. Hoping it's a good starting point to discuss more!


chore(main): release 1.1.5

:robot: I have created a release beep boop
1.1.5 (2023-10-07)
Bug Fixes

auto-build (4c194ca)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/A7mooz/ts-gen/releases/tag/v1.1.5 :sunflower:


Overloading - inherit types

Suggestion

🔍 Search Terms

List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.
Overloading, inherit, types, parameter types, return type
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

when declaring functions with overrides make the types inherit from the override declarations
📃 Motivating Example

function add(a: number, b: number): number;
function add(a: string, b: string): string;
function add(a/* : number | string */, b/* : number | string */) /* : number | string */ {
	return a + b;
}

💻 Use Cases

This would be better because then the default types wouldnt be any on the main declaration.

Looks like #25352 to me


Speed up bulk processor flush and cut release

improve through put of flushing the bulk processor
set release artefacts

Consistency and speed issues are resolved.
The queue's stats are slightly off by one or two batches.
Example, for a dataset with 10k records and default parameters:
bp.flush_queue()
print(bp.stats)

Output:
{'total': 9975, 'queue': 0, 'failed_batches': 0, 'total_batches': 399, 'tables': {'test': 9975}}


explore packaging options

We could probably use some combination of these:

https://github.com/zeit/ncc
https://github.com/zeit/pkg
https://github.com/nexe/nexe
it seems that electron-builder could be used too, maybe at least app-builder which electron-build is using

Some other related tools:

https://github.com/yue/yackage
https://github.com/mischnic/proton-packager
https://github.com/electron-userland/electron-packager
https://github.com/electron-userland/electron-forge

It has to be tested and then documented.
We obviously want to support mac too but if there is a shorter way (ncc + pkg might be a one but I'm not sure) for linux/windows we should mention it too because not everybody needs to support mac.

Also checkout this list: https://github.com/styfle/awesome-desktop-js/blob/master/README.md#packaging

@styfle thx, BTW what is your opinion? do you have any experience/opinions with these tools?

I've used electron builder but never quite got it to work properly with magnemite.
The ncc tool is a little different than the others because it does not create a native binary. It's really more like a bundler such as browserify or webpack.
I would start with pkg since that was used in production for all zeit deployments for at least a year and seems to have a lot of mindshare around it.

ncc + pkg could work but it needs native extensions in the same directory, so it's not straightforward enough for beginners.
From this perspective, electron-builder might be a better option https://github.com/electron/electron/blob/master/docs/tutorial/using-native-node-modules.md


Console error - Uncaught (in promise) TypeError: Cannot convert undefined or null to object - reported by @aimane

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Visit https://staging.new.expensify.com/
Inspect / Console

Expected Result:
No console error
Actual Result:
Console error - Uncaught (in promise) TypeError: Cannot convert undefined or null to object
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.5-0
Reproducible in staging?: Y (need repro)
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/192842662-ae230865-507c-48fb-846b-d4bbcb2b5e05.mov
Expensify/Expensify Issue URL:
Issue reported by: @aimane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663221267406669
View all open jobs on GitHub

@aimane-chnaif are you able to still reproduce this?  I was not.

Closing for now - if you are able to reproduce this again @aimane-chnaif feel free to reopen this.


[typed-store] Offer a interface to avoid reserialization of retrieved values

We sometimes retrieve items from the databases just to send them over a network interface right after, and would like to avoid the deserialization-serialization:
https://github.com/MystenLabs/narwhal/blob/410ed5d51b7bd2a1e67fd8b2960986c39be58da9/primary/src/helper.rs#L61
We should offer an interface that allows shipping the raw bytes to their destination directly.

Closed in #137


Create dude-wheres-my-media.md

Hack submission
It's basically Delicious Library, but as a web app
Yeah, I know.

This sounds great!


Vickel: Watch drdrivingapk.net

Vickel requests the watch of the watch_keyword drdrivingapk\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

drdrivingapk\.net has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Fix package.json for Jupyter Lab extension

I ran into issues when installing the latest developer version of the Lab extension with:
jupyter labextension install js

With these changes, I'm able to successfully install it.

Thanks @astrofrog !


prtClassLibSVM doesn't like Singles as the input

It looks like LibSVM doesn't handle singles as its input, and displays an error, but then the PRT wigs out.
TestDataSet = prtDataGenUnimodal;       % Create some test and
TrainingDataSet = prtDataGenUnimodal;   % training data
classifier = prtClassLibSvm;              % Create a classifier
classifier = classifier.train(TrainingDataSet);    % Train
classified = run(classifier, TestDataSet);         % Test
Gives this error:
Error: label vector and instance matrix must be double
Error: label vector and instance matrix must be double
Index exceeds matrix dimensions.
Error in prtDataSetInMem/retainObservationData (line 612)
self.data = self.data(indices,:);
Error in prtDataSetInMem/retainObservations (line 195)
self = self.retainObservationData(indices);
Error in prtDataInterfaceCategoricalTargets/retainLabeled (line 392)
obj = obj.retainObservations(retainInd);
Error in prtClassLibSvm/trainAction (line 274)
auc = prtScoreAuc(yOut.retainLabeled);
Error in prtAction/train (line 221)
self = trainAction(self, ds);

I can't recreate?
TestDataSet = prtDataGenUnimodal; % Create some test and
TrainingDataSet = prtDataGenUnimodal; % training data
classifier = prtClassLibSvm; % Create a classifier
classifier = classifier.train(TrainingDataSet); % Train
classified = run(classifier, TestDataSet); % Test

I tried this, too, and it ran fine.  (I'm using an older version of Matlab,
and a version of PRT from December of 2014.)
From my Matlab session:

TestDataSet = prtDataGenUnimodal; % Create some test and
TrainingDataSet = prtDataGenUnimodal; % training data
classifier = prtClassLibSvm; % Create a classifier
classifier = classifier.train(TrainingDataSet); % Train
classified = run(classifier, TestDataSet); % Test

classified

classified =
prtDataSetClass
Properties:
nFeatures: 1
featureInfo: []
data: [400x1 double]
targets: [400x1 double]
observationInfo: []
nObservations: 400
nTargetDimensions: 1
isLabeled: 1
isEmpty: 0
name: 'prtDataGenUnimodal'
description: ''
userData: [1x1 struct]
nClasses: 2
uniqueClasses: [2x1 double]
nObservationsByClass: [2x1 double]
classNames: {2x1 cell}
isUnary: 0
isBinary: 1
isMary: 0
isZeroOne: 1
hasUnlabeled: 0
nUnlabeled: 0
isFullyUnlabeled: 0
Methods, Superclasses

On Wed, Dec 2, 2015 at 7:50 AM, Peter Torrione<EMAIL_ADDRESS>wrote:

I can't recreate?
TestDataSet = prtDataGenUnimodal; % Create some test and
TrainingDataSet = prtDataGenUnimodal; % training data
classifier = prtClassLibSvm; % Create a classifier
classifier = classifier.train(TrainingDataSet); % Train
classified = run(classifier, TestDataSet); % Test
—
Reply to this email directly or view it on GitHub
https://github.com/covartech/PRT/issues/42#issuecomment-161296577.

I too have been unable to recreate this problem.
@samkeene Does this still give you an issue? Looking at it, I'm not sure where the singles would have come from since prtDataGenUnimodal produces doubles.


Fix typos in docs

Brief Description of your Changes.
Fixes the typos in various parts of the docs. Fixes #149
Impact of your Changes
Clarity of docs.
Tests Performed
What have you done to ensure this change has the least possible impact on the project?
Additional Comments
The query intro still contains the same definition as the World intro. Not quite sure what to change it to

It is a bit difficult for me to review the changes on the phone so I will have to leave the review to someone else for the moment until I can view it on the computer.
As for the title, there is no need to prefix with docs: or fix:. It is not a convention or anything

Btw the query intro still contains the same definition as the World intro.


Consider removing/reworking SeedNetworkPoliciesTest integration test

How to categorize this issue?
/area testing
/kind bug
/priority 3
What happened:
Since longtime we have the following issues opened:

https://github.com/gardener/gardener-extension-provider-aws/issues/20
https://github.com/gardener/gardener-extension-provider-gcp/issues/20
https://github.com/gardener/gardener-extension-provider-azure/issues/23
https://github.com/gardener/gardener-extension-provider-openstack/issues/18
https://github.com/gardener/gardener-extension-provider-alicloud/issues/14

We should rather remove or rework this test as:

IIUC the test currently is not executed in presubmit or in any cron manner by the test machinery -> does not bring any value as we don't understand whether we have a regression or not
The test seems to always fail
The test is quite unmaintained - relies on Logging feature to be always enabled; does not handle the case where the ReversedVPN feature gate is enabled; etc.
The test is quite complex as it is generated by a huge string with golang code -> see extensions/test/e2e/framework/networkpolicies/generators/networkpolicies.go

/cc @mvladev

/assign


Update deps

Last round of updates including bugfix releases before rc.1 tag

Pull Request Test Coverage Report for Build 13d3f7d44c8fce66817afca21ed92aefe1cb44af-PR-579
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.488%

Totals

Change from base Build 7430d8e6032ba0d91fc0caee16d319a9317e5a20:
0.0%

Covered Lines:
1221

Relevant Lines:
1517

💛  - Coveralls

Pull Request Test Coverage Report for Build 13d3f7d44c8fce66817afca21ed92aefe1cb44af-PR-579
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.488%

Totals

Change from base Build 7430d8e6032ba0d91fc0caee16d319a9317e5a20:
0.0%

Covered Lines:
1221

Relevant Lines:
1517

💛  - Coveralls


Parsing skips object members in some cases

> const DSON = require("./build/DSON.js");
undefined
> DSON.parse('such "foo" is 1, "bar" is "baz" wow')
{ foo: 'baz' }
> DSON.parse('such "foo" is 1, "bar" is "baz", "bat" is "quz" wow')
{ foo: 'baz', bat: 'quz' }
>

Seems to be related to number parsing?

I don’t think I’ve ever looked at this parser code, but your conjecture seems right like it’s skipping the number and going to the next block. What if you have “foo” is “1”


[openimageio] FindOpenImageIO.cmake does not separate Release/Debug configurations

Building sample program in Release configuration links with debug openimageio library.
Environment
Windows10, MS VS 2017 15.9.16
To Reproduce
vcpkg.exe install openimageio:x64-windows

Configure, Generate sample(empty int main{}) program with CMakeLists.txt:
cmake_minimum_required(VERSION 3.12)
project(test_oiio)
find_package(openimageio REQUIRED)
add_executable(test_oiio test_oiio.cpp)
target_include_directories(test_oiio PRIVATE ${OPENIMAGEIO_INCLUDE_DIR})
target_link_libraries(test_oiio ${OPENIMAGEIO_LIBRARIES})

Gives test_oiio.vcxproj with:
  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
    <Link>
      <AdditionalDependencies>D:\ws\vcpkg\probe\openimageio\vcpkg\installed\x64-windows\debug\lib\OpenImageIO.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;comdlg32.lib;advapi32.lib</AdditionalDependencies>
  ...

Cause
find_package(openimageio) uses FindOpenImageIO.cmake (through vcpkg-cmake-wrapper.cmake), which does find_library ( OPENIMAGEIO_LIBRARY ...) without selecting configuration.
There is openexr port, which also uses FindOpenEXR.cmake, but separates configurations by
include(SelectLibraryConfigurations)
if(NOT OpenEXR_BASE_LIBRARY)
  find_library(OpenEXR_BASE_LIBRARY_RELEASE NAMES IlmImf-${OpenEXR_LIB_SUFFIX})
  find_library(OpenEXR_BASE_LIBRARY_DEBUG NAMES IlmImf-${OpenEXR_LIB_SUFFIX}_d)
  select_library_configurations(OpenEXR_BASE)
endif()

SelectLibraryConfigurations solution has a drawback, that it does not propagate dependencies (notable with openimageio static build #8049 ). Is it better to get installed openimageio targets, and enable traditional OPENIMAGEIO_LIBRARIES on top of targets?

There is open PR in OpenImageIO homepage (https://github.com/OpenImageIO/oiio/pull/2352) with cmake refactoring (including mark target's link_libraries and include_directories with PUBLIC/PRIVATE).
It would be easy then to add install targets.

Hi @janholt, thanks for reporting this issue!
I've fixed it in #8543, please update vcpkg and rebuild openimageio.
Thanks.


Cursors Size

Request different Cursors in size 24, 28, 32, 40, 48, 56, 64, 72, 80, 88, 96

4K hidpi monitor mouse pointer is too small, I like this theme

These cursors are hand-made raster ones, cannot be scaled (unless blurry & blocky look is acceptable for you ...). If you want variants those sizes, make them yourself.


requirements.txt: don't pin web3 to 5.18.0

We don't have any mechanism to freeze versions in this repo. Is it a good idea to not restrict the version in any way? I'm afraid of clearing the pip cache and suddenly getting errors I didn't get before.
Related to https://github.com/raiden-network/raiden/issues/6984


blueprint add with CompositionView

in sample Docs
from sanic import Sanic
from sanic.views import CompositionView
from sanic.response import text

app = Sanic(__name__)

def get_handler(request):
    return text('I am a get method')

view = CompositionView()
view.add(['GET'], get_handler)
view.add(['POST', 'PUT'], lambda request: text('I am a post/put method'))

# Use the new view to handle requests to the base URL
app.add_route(view, '/')

I m try....
This is possible?
if yes this is magnifcy
user_bp = Blueprint('teste', url_prefix='/user')

def get_handler(request):
    return json('I am TESTE')

def get_handler2(request):
    return json('I am TESTE 2')

view = CompositionView()
view.add(['GET'], get_handler)
view.add(['GET'], get_handler2)
user_bp.add_route(view, '/bla2')

SHOW Error
very thanks
AttributeError: 'CompositionView' object has no attribute '__name__'

add in dock
sorry!
def get_handler(request):
    return json('I am TESTE METHODS BLA')

user_bp.add_route(get_handler,methods=['GET'],uri='/bla2')

Hi there
I think the error is caused by a missing attribute name when you try to add your CompositionView to the blueprint. Here is an example from tests, please check is it help or not.
https://github.com/huge-success/sanic/blob/075affec23084f68a2a5817521d3cecdb25cd152/tests/test_blueprints.py#L619-L635

Thanks for repply!!!
This work perfecty

please write on documentation , will help very many.
Very Thanks!!


🚀 Feature: Add label-syncer action to sync labels

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
I recently came across RebeccaStevens template-typescript-node-package repo.
This repo uses https://github.com/micnncim/action-label-syncer and just provide labels in the path .github/labels.yml.
This will separate setting up the label in pnpm run setup.
Additional Info
References: https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues/262, https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues/331

You know, this is a good idea, but I'm reluctant to add noise to a repo after it's been set up. Repos will have to now set up a labels.yml file. There are already a lot of config files in the repos... then again, I do see the advantage of not having to set it up in the script, and making it easier to update later on.
Let's leave this open for a bit and see if more people have opinions?

Ok I've been poking around other repositories and haven't seen label syncing in use much. I'm going to go ahead and close this as it seems like a not-super-commonly-used thing. I personally am not excited about its benefits to warrant the extra file + workflows in a repo.
Thanks for suggesting though! ❤


Update index.html

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

HRESULT
WINAPI
ApplyPendingSavedStateFileReplayLog(
In    LPCWSTR                         VmrsFile
);


Implement implicit namespace packages

Since the implementation of PEP621 in flit, we can get namespace packages basically for free. The only required change is not reading or importing the module, when the information (description and version) has already been provided in pyproject.toml. This is accomplished with just one if. The other places already avoid reading the file when project.dynamic is empty in pyproject.toml. During sdist we also have to just not check for the module file.
Best,
Marten

I have used this PR successfully today via
[build-system]
requires = ["flit_core @ git+https://github.com/martenlienen/flit.git@namespace-packages#subdirectory=flit_core"]

to release hydra-experiment-sweeper, a plugin for hydra that needs to be packaged as a namespace package.

Thanks @martenlienen, and sorry it's taken me a while to look at this.
Truth be told, I like the old approach of #159 better, where you package something in the namespace, rather than the namespace itself. I.e. you would specify:
[tool.flit.module]
name = "hydra_plugins.experiment_sweeper_plugin"

And then it would work like any other Flit package - with support for dynamic version & description fields extracted from the package itself. I'm not be a big fan of namespace packages myself, but if we're going to support them, I'd rather do so properly than as a half feature.

Thanks for getting back to namespace packages after all. I agree that the other approach feels nicer. The obvious advantage of my PR is just that it is such a small change. Either way, I am looking forward to getting namespace support in flit eventually!

Thanks! A small diff is certainly nice, but I'd rather not have to explain that certain features aren't available when you're packaging something in a namespace package. :slightly_smiling_face:


make ScopeTemplate CRs communicate state

Description of the Change

Updates the ScopeTemplateStatus object to have a Conditions field that is of type []metav1.Conditions
Updates controllers/scopetemplate_controller.go to set a metav1.Condition with type Succeeded and updates the status of the condition accordingly
Updates controllers/scopetemplate_controller_test.go to:

Verify that the proper condition is being set
Create a unique ClusterRole for each iteration of a ScopeTemplate being created for the testing.

Before this, there was a clash in the tests in that the ClusterRole already existed even though the ScopeTemplate was being deleted and recreated. I think this raises the question: Should ClusterRoles be deleted if the ScopeTemplate that it is associated with is deleted?

Motivation for the Change
Fixes #4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 22 (40.91%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.06%) to 67.118%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/scopetemplate_controller.go
9
22
40.91%

Files with Coverage Reduction
New Missed Lines
%

controllers/scopetemplate_controller.go
4
60.75%

Totals

Change from base Build<PHONE_NUMBER>:
1.06%

Covered Lines:
347

Relevant Lines:
517

💛  - Coveralls

/hold cancel

/lgtm


Out and Print problematic as generic methods

I've run into problems with the Print<T> and Out<T> generics. These do a ToString() on whatever is passed in, which is generally nice for usability, but I have more than once accidentally passed in something that gets auto-stringized, rather than the compile failing and catching my mistake.
Furthermore, the generic blocks my ability to add extension methods for custom type handling. A great example of this is when I wanted to add an Out(Spectre.Console.Rendering.IRenderable) extension. Unfortunately, the Out<T> always wins over an extension, and for any parameter type. And if I simply forget to call AnsiConsole.Console.ToAnsi first, then I get the default/bad Object.ToString behavior. IMO these generic functions cause more problems than they solve.
I can think of a few potential improvements:

Remove Out<T> entirely
Rename to OutValue<T>
Move Out<T> to an extension method
Change it to Out(object) (as with System.IO.TextWriter, adding in a bunch of overloads for primitives to reduce boxing)

My favorite is the first option. Cathode feels to me much more close-to-the-metal API vs the console stuff .NET ships with. Lots of work has gone into minimizing allocs and avoiding copying. So these stringizing helper methods feel out of place to me.
(Related: https://github.com/vezel-dev/cathode/issues/192#issuecomment-2293660796)

Removing it outright would regress stuff like this:
https://github.com/vezel-dev/cathode/blob/095df821e21f1da9794de63e1071eb0e68dbd791/src/samples/scrolling/Program.cs#L11-L16
Obviously you shouldn't be writing code in that fashion when performance matters, but it is quite convenient when it doesn't. Not having some sort of "just output the stringified form of whatever I pass in" method will also likely be a significant paper cut for someone coming from System.Console.
The overloading problems do need to be solved though. I'm leaning towards the extension method approach since I don't think any of these methods need access to TerminalWriter internals anyway. Will think a bit more on it.
In regards to these methods being a performance trap: If it happens often enough, maybe you could make use of BannedApiAnalyzers? That's what Cathode itself does to ban System.Console. Since Cathode already pulls the analyzer in, I believe all you need to do is add this to your project file:
    <ItemGroup>
        <AdditionalFiles Include="BannedSymbols.txt" />
    </ItemGroup>

And then add the problematic methods to BannedSymbols.txt.

Cool, I didn't think to make it a locally banned API for myself. This will work 👍🏽

I'm using this banned list to start out:
M:Vezel.Cathode.Terminal.Error`1(``0)
M:Vezel.Cathode.Terminal.ErrorLine`1(``0)
M:Vezel.Cathode.Terminal.Out`1(``0)
M:Vezel.Cathode.Terminal.OutLine`1(``0)
M:Vezel.Cathode.IO.TerminalWriter.Write`1(``0)
M:Vezel.Cathode.IO.TerminalWriter.WriteLine`1(``0)
M:Vezel.Cathode.Text.Control.ControlBuilder.Print`1(``0)
M:Vezel.Cathode.Text.Control.ControlBuilder.PrintLine`1(``0)
M:Vezel.Cathode.VirtualTerminal.Error`1(``0)
M:Vezel.Cathode.VirtualTerminal.ErrorLine`1(``0)
M:Vezel.Cathode.VirtualTerminal.Out`1(``0)
M:Vezel.Cathode.VirtualTerminal.OutLine`1(``0)

...and immediately ran into a problem: I don't want to ban Out<string>(), because its ToString does not alloc, and most of the time I do have a string to pass in.
The banned symbols format doesn't support un-banning/exclusions, or selecting specific generic instantiations either. I can work around this by tacking on an AsSpan() everywhere, which is not nice.
I wouldn't mind adding my own Out(string) etc. overloads as extension methods, but that requires resolving the "cannot extend when there is a generic" issue.
For the moment, I'm locally modifying Cathode to add Out(string) type methods as needed.

...and immediately ran into a problem: I don't want to ban Out<string>(), because its ToString does not alloc, and most of the time I do have a string to pass in.

I think it'd be reasonable to add a string overload to resolve this.

Cool, I'll do a PR this weekend

I'm already putting together a patch to extract most of the methods out as extensions, so I'll just do it as part of that. I just posted the above to acknowledge that point. :slightly_smiling_face:

Even better. :) I look forward to reverting my local changes.

@scottbilas for Print<T>(), are you referring to the method on ControlBuilder?

Yes and PrintLine. My prev comment with the banned api list has the full set I discovered.

Ok, I pushed some initial work on this. Let me know how that looks to you.
Still need to do the WriteLine() family of methods. I never added all the same overloads to that as I did for Write(). I think it's because the implementation looks like this:
https://github.com/vezel-dev/cathode/blob/2d3ed1dd04e88bd0b85d5a094ed1d40f85aecaaf/src/core/IO/TerminalIOExtensions.cs#L236-L239
That is, it looks like it's atomically writing the value and the new-line character... of course, in reality, that's not how that plays out at all:
https://github.com/vezel-dev/cathode/blob/2d3ed1dd04e88bd0b85d5a094ed1d40f85aecaaf/src/core/IO/TerminalIOExtensions.cs#L74-L81
So I think it should just get the same treatment as Write().

Looks great! All the overloads would make me reach for some T4 codegen, personally. :D
One suggestion - given the nature of ControlBuilder, I also find it useful to have a Print(char) overload. This would also let you change a couple slightly awkward new(in ch) to just ch in that same file.
Regarding the *Line variants, I didn't realize the WritePartial chunking was going on. But it's also good to avoid the alloc+copying - overly expensive to do that, just to add a char or two at the end.

I think this is mostly done now.
One question that remains is: Should VirtualTerminal get the same treatment? It seems like someone trying to add extension methods to that would run into the same issues.

One suggestion - given the nature of ControlBuilder, I also find it useful to have a Print(char) overload. This would also let you change a couple slightly awkward new(in ch) to just ch in that same file.

Those should just be Print([ch]) (which I've just changed them to). Once C# allows params ReadOnlySpan<char>, it can even become Print(ch) without adding another overload.


Generalise the opening and creation of Tables

Previously, SafeTableProxy::Make took a filename argument which would open a table for reading.
This has been generalised to take a functor, allowing opening/creation of TableProxy's by arbitrary methods.

3.11 build failed due to http timeout.


PageObject.register_widget undefined method

I seem to be missing something on adding a widget.
I get the following error calling a widget named "group"
  Scenario: Login with valid id
    Given I am on the login page
    And I have entered valid credentials
      undefined method `group' for #<Watir::Browser:0x007fc12ebb78c0> (NoMethodError)
      ./features/step_definitions/login-steps.rb:10:in `block (2 levels) in <top (required)>'
      ./features/step_definitions/login-steps.rb:8:in `/^I have entered valid credentials$/'
      features/login.feature:5:in `And I have entered valid credentials'

ChoseSelect.rb
class ChosenSelect < PageObject::Elements::TextField
    def self.hello(msg)
      puts msg
    end
end

env.rb
equire 'rspec'
require 'selenium-webdriver'
require 'page-object'
require 'page-object/page_factory'

# Initialize PageObjects
World(PageObject::PageFactory)

# Load all the Page objects
require_relative './page-object/ChosenSelect'
PageObject.register_widget :chosen_select, ChosenSelect, :text
Dir['./pages/**/*.rb'].each {|file| require file }

LoginPage.rb
class LoginPage
	include PageObject

	page_url "#{FigNewton.url}/Traffic"

	chosen_select(:group, :xpath =><EMAIL_ADDRESS>
	text_field(:lan_id, :xpath =><EMAIL_ADDRESS>
	text_field(:password, :xpath =><EMAIL_ADDRESS>
	button(:login, :xpath => "//BUTTON[normalize-space(text())='login']")
	div(:alert, :css => "div.alert")
end

login-steps.rb
Given /^I have entered valid credentials$/ do
  on_page(LoginPage) do | page |
    page.populate_page_with data_for "LoginPage/valid"
    page.group.hello('jdjdj')
    page.login
  end
end

The method created by the accessor will be #group_element rather than #group, so you want:
page.group_element.hello('jdjdj')

Thanks for your response.  I created a standalone GEM and called the group_element.hello and that worked.


the chart in section <IP_ADDRESS> shows that primitive and object types are also valid for style=simple

.

As discussed on today's TDC, merging based on approvals above.


Change logging for debezium key value pairs

Explicitly print out the Key Value pairs for debezium tests.

It seems that this pull request contains changes from another one (https://github.com/apache/pulsar/pull/5158/files). Was it done on pupose?

@vzhikserg no it needs to be changed the focus right now is getting this merged
https://github.com/apache/pulsar/pull/5162


readSync() doesn't work

Consider following snippet:
var onoff = require("onoff");
var Gpio = require('onoff').Gpio;

function toggleGpioPin(pinNumber){
    var gpioPin = new Gpio(pinNumber, "out");
    if (gpioPin.readSync() === 0) {
        gpioPin.writeSync(1);
        return 1;
    } else {
        gpioPin.writeSync(0);
        return 0;
    }
}

toggleGpioPin(7);
toggleGpioPin(7);

I have found that readSync() doesn't really return actual value - it always  returns 0 instead 1 at the second toggleGpioPin(7) call.
I'm using Raspberry Pi A with Raspbian.
I've also used simplified code to ensure that readSync is a victime. Even if I have set mode to "in" it doesn't return proper value.
What am I doing wrong?

The first line of toggleGpioPin is
var gpioPin = new Gpio(pinNumber, "out");

This instantiates a new Gpio object, configures the corresponding GPIO pin to be an output pin and sets the value of that pin to 0. It does this every time toggleGpioPin. This explains why gpioPin.readSync() always returns 0. To resolve the issue instantiate one Gpio object during the initialization phase of the program and always use that Gpio object. Something like this should work:
var Gpio = require('onoff').Gpio;
var gpioPin = new Gpio(7, "out");

function toggleGpioPin(gpioPin){
    if (gpioPin.readSync() === 0) {
        gpioPin.writeSync(1);
        return 1;
    } else {
        gpioPin.writeSync(0);
        return 0;
    }
}

toggleGpioPin(gpioPin);
toggleGpioPin(gpioPin);

The documentation for the constructor should be improved to make it clear what it actually does.

The documentation for the Gpio constructor already mentions that the GPIO is configured when a Gpio object is instantiated. With commit 0118ab9c1fae07c15c65c8b76700a58ce8f72f4d the documentation was tweaked to makes things clearer.


Container centos7-rpm-builder script setup_rpm_users errors if group already exists

Error example:
# setup_rpm_users run
Value detected for variable '_USER_ID' = 1001
Value detected for variable '_GROUP_ID' = 999
Adding builder user/group (1001:999)
groupadd: GID '999' already exists
ERROR: process "/bin/sh -c setup_rpm_users run" did not complete successfully: exit code: 4

References:

https://github.com/urbdyn/build-utils/pkgs/container/centos7-rpm-builder/15029728
https://github.com/urbdyn/build-utils/blob/08028c28122b706e230841b770fa62180b3b11e7/centos7-rpm-builder/setup_rpm_users

Solved via #6


[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test

What is the purpose of the change
Harden the Avro Confluent Schema Registry nightly end-to-end test.
Brief change log

Wrap the error when execute cleanup command in retry_times_with_backoff_and_cleanup function.
Harden the way to loop in retry_times_with_backoff_and_cleanup

Verifying this change
Trigger the Avro Confluent Schema Registry nightly end-to-end test.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

cc @tillrohrmann
Travis gives green light to the relevant test.
https://travis-ci.org/KarmaGYZ/flink/builds/632126284

Thanks for the review @tillrohrmann . I've updated the PR.

Thanks for the review @tillrohrmann . I've removed the retry-delay and explained what happened in the loop.


Show Systems hierarchy

Currently, it is impossible to understand the flow of the systems. It will be very problematic to debug.
We need a visualization that will clearly display the current instantiated tree of groups and systems.
There is a built-in node canvas in UI Toolkit, consider using it

Fixed with the introduction of Arch Visualiser


Empty implicit table redefinitions are allowed

Following (at least on http://binarymuse.github.io/toml-node/):
[a]
b = "a"
[a.b.c]

parses, but shouldn't (key b is redefined).

Fixed in 2.2.3.


I I didn't understand this synchronized custom divide. Please explain its purpose or usage scenarios. Thank you

Question
I didn't understand this synchronized custom divide. Please explain its purpose or usage scenarios. Thank you

My current understanding is to refresh the list below, but I feel that something is wrong

just sync your data when losing data

丢失数据时只需同步数据

When I used Zookeeper to synchronize data, the control printed this error message. Is this normal?

丢失数据时只需同步数据

When I used Zookeeper to synchronize data, the control printed this error message. Is this normal?

which version?

2.6.0
When this issue occurred, the testing on the master branch was initiated

2.6.0 When this issue occurred, the testing on the master branch was initiated

thanks for your feedback, it may be a bug, can you fix it?


[Products page] The product page opens after clicking on the "Delete" button

Steps to reproduce:

Open Products page.
Press the "Delete" button (trash icon).

Expected Result:
The product is deleted.
Actual Result:
The product page is opened.

https://github.com/ita-social-projects/ZeroWaste/assets/145554575/51c2decf-75cd-445e-95bd-ee745591f2e9
The "Products" page does not open

These are not similar problems and require the opening of a separate issue like that https://github.com/ita-social-projects/ZeroWaste/issues/587

RETEST PLEASE


Data Transfer between Fragments

So I made a fragment for adding items to the Feeds fragment. But as I was trying to pass a string to the feeds fragment, the app crashes. So can anyone help with passing data between those two fragments?

You can share your error , would love to look at it. 👍

I push my changes to FeedsImplementation, you can run it and see the error

@emmaunel  thanks let me pull them.

@emmaunel  I see this the error you are getting the null object reference .
on a null object reference.

Yeah but the problem. It is not actually null

On the detach method I see you declared it null.

@emmaunel  Sorry i have seen. Lol,

@emmaunel just noticed interaction  is not initialized and is hence throwing a null pointer exception when you use it to reference the receive function. I was reading this https://developer.android.com/training/basics/fragments/communicating.html#Implement

So I am progressing but I just have one more problem.
When the apps first run, it loads up feedsfragment but the problem that same fragment gets data from the addFeeds activity. So when it loads addFeeds sents null to the feedsfragment.
What I need help is how to ignore the data from addFeeds activity at the launch of the app but after that, can then receive data from it

Update: I kind of fix the null pointer

@emmaunel  awesome, good news 👍 you can push and i will look at it.

yes please. my heads hurts from this.

@Madonahs check it out

@Emmanuel thanks. 😊 will keep you updated. 😎

@emmaunel  Going through it can you try receiving the bundle into a Bundle object using getArguments method and check it against null.

I see you did that 👍

@emmaunel  some recommendation

Lets remove unused method, activities can layouts.

Make sure you remove them on Manifest too.

Looks like error might be something small. Process looks good but too many unused.

@Madonahs ok


Failed to build from source with "OSError: exception: access violation writing 0x0000000000000000"

Description
I 'm trying to compile mxnet from source code in windows10, vs2017
with CPP_PACKAGE

mxnet clone tag 1.6.0
git clone --recursive -b 1.6.0 https://github.com/apache/incubator-mxnet mxnet_1.6.0

set opencv, openblas env
set OpenCV_DIR=C:\opencv-3.4.1_with_freetype2
set OpenBLAS_HOME=C:\OpenBLAS-0.3.7-x64

cmake
cmake -G "Visual Studio 15 2017 Win64" -T cuda=10.1,host=x64 -DUSE_CUDA=1 -DBUILD_CPP_EXAMPLES=1 -DUSE_CPP_PACKAGE=1 -DUSE_CUDNN=1 -DUSE_NVRTC=1 -DUSE_OPENCV=1 -DUSE_OPENMP=1 -DUSE_BLAS=open -DUSE_LAPACK=1 -DUSE_DIST_KVSTORE=0 -DCUDA_ARCH_LIST=Common -DCUDA_TOOLSET=10.1 -DCUDNN_INCLUDE="C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\include" -DCUDNN_LIBRARY="C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\lib\x64\cudnn.lib" "../"

build
"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe" mxnet.sln /p:Configuration=Release;Platform=x64 /maxcpucount

Error Message
     Traceback (most recent call last):
       File "OpWrapperGenerator.py", line 433, in <module>
         raise(e)
       File "OpWrapperGenerator.py", line 427, in <module>
         f.write(patternStr % ParseAllOps())
       File "OpWrapperGenerator.py", line 321, in ParseAllOps
         cdll.libmxnet = cdll.LoadLibrary(sys.argv[1])
       File "C:\Users\admin\AppData\Local\Programs\Python\Python38\lib\ctypes\__init__.py", line 451, in LoadLibrary
         return self._dlltype(name)
       File "C:\Users\admin\AppData\Local\Programs\Python\Python38\lib\ctypes\__init__.py", line 373, in __init__
         self._handle = _dlopen(self._name, mode)
     FileNotFoundError: Could not find module 'C:\Workspace\mxnet_1.6.0\build\Release\libmxnet.dll' (or one of its dependencies). Try using the full path with constructor syntax.

copy dependents dll file to Release folder(mxnet_1.6.0/build/Release)
cudart64_101.dll

rebuild

Error Message
     "Running: OpWrapperGenerator.py"
     Traceback (most recent call last):
       File "OpWrapperGenerator.py", line 433, in <module>
         raise(e)
       File "OpWrapperGenerator.py", line 427, in <module>
         f.write(patternStr % ParseAllOps())
       File "OpWrapperGenerator.py", line 338, in ParseAllOps
         r = ListOP(byref(nOps), byref(opHandlers))
     OSError: exception: access violation writing 0x0000000000000000

copy dependents dll file to scripts folder(mxnet_1.6.0/cpp-package/scripts)
libgcc_s_seh-1.dlll
ibgfortran-3.dll
libopenblas.dll
libquadmath-0.dll
mxnet_61.dll
opencv_world341.dll

in my case rebuild success

--
Environment
S/W
windows10 64bit
python 3.8.3
compiler : vs2017
CUDA 10.1

H/W
GTX 1080Ti

@harrysekim did you figure out what happened?

@szha
I have tried several things and copy all dependents dll(include not dependents dll) file to both folder(build/Release, cpp-package/scripts)
i check remove each dll file from floder and try build.
Finally I got the list of required dll files.


Failure when experimenting with Chat

I just tried to use the new AI Chat feature in Mathematica. Executing any cells brings up errors: even saying "Hello, chat" resulted in a Failure. See the attached screenshot.

Debug Data

Property
Value

Name
"Wolfram/Chatbook"

Version
"1.0.3"

EvaluationEnvironment
"Session"

FrontEndVersion
"Desktop: 13.2 for Mac OS X x86 (64-bit) (November 18, 2022)"

KernelVersion
"13.2.0 for Mac OS X x86 (64-bit) (November 18, 2022)"

SystemID
"MacOSX-x86-64"

Notebooks
True

DynamicEvaluation
False

SynchronousEvaluation
False

TaskEvaluation
False

Settings

Property
Value

Assistance
Automatic

AutoFormat
True

BasePrompt
Automatic

ChatContextCellProcessingFunction
Automatic

ChatContextPostEvaluationFunction
Automatic

ChatContextPreprompt
Automatic

ChatDrivenNotebook
False

ChatHistoryLength
25

DynamicAutoFormat
Automatic

FrequencyPenalty
0.1

IncludeHistory
Automatic

LLMEvaluator
``<

MaxTokens
Automatic

MergeMessages
True

Model
"gpt-3.5-turbo"

PresencePenalty
0.1

ShowMinimized
Automatic

StreamingOutputMethod
Automatic

Temperature
0.7

Tools
Automatic

ToolsEnabled
False

TopP
1

Data
``<

Container
Wolfram`Chatbook`Actions`Private`container$8367

CellObject
CellObject["fe2345cd-d867-4e79-ad41-a24baa69432a", "0124fb91-b19c-4788-abf1-6a754cd63553"]

Task
TaskObject[Association["TaskUUID" -> "bbf6e6cd-87bd-4163-90e2-2ce87cc08f81", "TaskEnvironment" -> "External", "TaskType" -> "Asynchronous", "AsynchronounsTaskID" -> 3, "EvaluationExpression" :> None, HandlerFunctions -> Association[], HandlerFunctionsKeys -> {"BodyChunk", "StatusCode", "Task", "TaskStatus", "EventName"}, AutoRemove -> True]]

Stack Data
catchTopAs
throwFailure
trimURL

Failure Data
<|
  "Evaluation" :> Wolfram`Chatbook`Actions`Private`writ

Hi, that Failure object response is a known bug that we're hoping is fixed in paclet version 1.0.4 - there's a pre-release available right now if you'd like to test it out!
PacletInstall["https://github.com/WolframResearch/Chatbook/releases/download/v1.0.4/Wolfram__Chatbook-1.0.4.paclet",
 ForceVersionInstall -> True]

Should install it. If you still see any Failure objects, let us know!
For the MetaInformation piece, there was a paclet updated to support some of the LLM functionality we added.
PacletInstall["Templating", UpdatePacletSites -> True]

should update that paclet so you see the proper formatting of prompts and personas from the Prompt Repository!

When I call the first PacletInstall, I receive the following message repeatedly:
ChannelObject::connfail: Could not connect to the server "mqtts://channelbroker-mqtt.wolframcloud.com:8883/".


Change to Mongo as separate service

This is not a bug but a question...
I have been running unifi with mongo as one docker container.  I saw the message in startup that said to consider running mongo as a separate container.  My question is if there is anything I need to do to export the mongo data to the separate mongo container?

You can take the UniFi data/db directory and attach it to an instance of https://hub.docker.com/_/mongo
You'll need to match that mongo version to the version or one version higher of your existing database files. Unless you've done something odd to your install a 3.6 version should work,
I'd heavily recommend making a backup copy of your data before messing around with converting to an externalized mongo DB.

No, I don't do anything special or unique or odd with the unifi container startup.  So I'm going to back up and then try your docker-compose script (separate containers), which calls the mongo image you stated so I think it should be OK.  My Previous start looks like:
docker run --name ${sn} -h ${sn}${se} -d -p 3478:3478/udp -p 6789:6789 -p 8080:8080 -p ${sp}:8443 -p 8880:8880 -p 8843:8843 -p 10001:10001/udp -v ${pd}/cert:${dd}/cert -v ${pd}/data:${dd}/data -v ${pd}/logs:${dd}/logs goofball222/unifi
where variables $sn $sp $pd $dd prior to the run.


Upgraded from V4 to V4 - simple Find(Query.All()) stopped working

Searched for this but found nothing.
Problem:
This works fine in V4, fails to produce usable results in V5.
This pretty basic operation has been upgraded to V5. Data file has been upgraded using LiteDB Studio.
           using (var db = new LiteDatabase(@ConfigDBConnection))
            {
                var items = db.GetCollection<Item>(collection);

                var results = items.Find(Query.All());

            }

New LiteDatabase produces what looks like a valid LiteDB.LiteDatabase reference.
GetCollection returns a seemingly valid object reference to the right type: "LiteDB.LiteCollection<AIMFacTool.Item>"
V5 Query.All produces an unusable "System.Linq.Enumerable.WhereSelectEnumerableIterator<LiteDB.BsonDocument, AIMFacTool.Item>" and an error in the ResultsView of "Error The function evaluation requires all threads to run."
Whereas V4 produces a usable "LiteDB.LiteCollection<AIMFacTool.Item>" object.
I am hoping there is a workaround or alternative I can use, otherwise I will have to revert back to V4.
Am looking forward to using LiteDB Studio though so I am keeping my hopes up that this is an easy fix.
Thanks in advance for your help.

I'm not sure why you call the result of the LiteCollection.Find method unusable. This class WhereSelectEnumerableIterator<T> is an internal C# class, and it implements IEnumerable<T>, so you can use it in many ways, like iterating with a foreach loop and calling ToList() or ToArray().
Also, the The function evaluation requires all threads to run error is related to a limitation of the Visual Studio debugger for multi-threaded code, it has nothing to do with LiteDB itself and should never happen when running it without a debugger attached.

Perhaps I should have said "I don't know how to use it" which is really what I was trying to say.
Casting the result to a List solved the problem, as in:
                var items = db.GetCollection<Item>(collection);
                var results = items.Find(Query.All());
                results = results.ToList();
                return results;

I did not have to do this in V4 and did not find anything in the documentation that mentioned this change in behavior.
Thanks again Leonardo.
LiteDB is a great little tool and overall I have had good success using it.
Keep up the good work!


Fix rolebindings creation on customer namespaces

Bug discovered that the operator is granting permisisons to dedicated-admin SA only and not to the dedicated-admins group (or vice versa). This bug is tracked on OSD-2572
How these changes fix this issue:
line #134 - continue instead of return reconcile.Result{}, nil because we do not want to exit reconcile
loop if rolebinding already exists, should just move on to next iteration
line #151 - reconcile loop exits while we are still in the inner for loop, this prevents other rolebindings
from being created
line #159 - reconcile loop exits after one permission, this prevents other permissions from being loop
through, thus prevents rolebindings from being created.
sample logs where line 151 is getting hit and reconcile exits when it should not be
{"level":"info","ts":1576855464.0256724,"logger":"controller_namespace","msg":"RoleBinding dedicated-admins-project-system:serviceaccounts:dedicated-admin created successfully in namespace test-ns","Request.Namespace":"","Request.Name":"test-ns"} {"level":"info","ts":1576855464.0256944,"logger":"controller_namespace","msg":"should not exit here! -- line 152 !@#$%!@#$!@#$!@#$","Request.Namespace":"","Request.Name":"test-ns"} {"level":"info","ts":1576855464.0257144,"logger":"controller_namespace","msg":"Reconciling Namespace","Request.Namespace":"","Request.Name":"test-ns"} {"level":"info","ts":1576855464.0404968,"logger":"controller_namespace","msg":"RoleBinding dedicated-admins-project-dedicated-admins created successfully in namespace test-ns","Request.Namespace":"","Request.Name":"test-ns"} {"level":"info","ts":1576855464.0405273,"logger":"controller_namespace","msg":"should not exit here! -- line 152 !@#$%!@#$!@#$!@#$","Request.Namespace":"","Request.Name":"test-ns"}
After the changes, we get sample logs:
{"level":"info","ts":1576865570.0363777,"logger":"controller_namespace","msg":"Reconciling Namespace","Request.Namespace":"","Request.Name":"new-ns"} {"level":"info","ts":1576865570.0741634,"logger":"controller_namespace","msg":"RoleBinding dedicated-admins-project-system:serviceaccounts:dedicated-admin created successfully in namespace new-ns","Request.Namespace":"","Request.Name":"new-ns"} {"level":"info","ts":1576865570.0853205,"logger":"controller_namespace","msg":"RoleBinding admin-system:serviceaccounts:dedicated-admin created successfully in namespace new-ns","Request.Namespace":"","Request.Name":"new-ns"} {"level":"info","ts":1576865570.0894377,"logger":"controller_namespace","msg":"!@#$!@#$ keep going !@#$!@#$","Request.Namespace":"","Request.Name":"new-ns"} {"level":"info","ts":1576865570.1037798,"logger":"controller_namespace","msg":"RoleBinding dedicated-admins-project-dedicated-admins created successfully in namespace new-ns","Request.Namespace":"","Request.Name":"new-ns"} {"level":"info","ts":1576865570.109332,"logger":"controller_namespace","msg":"RoleBinding admin-dedicated-admins created successfully in namespace new-ns","Request.Namespace":"","Request.Name":"new-ns"} {"level":"info","ts":1576865570.1180785,"logger":"controller_namespace","msg":"!@#$!@#$ keep going !@#$!@#$","Request.Namespace":"","Request.Name":"new-ns"}
with the expected rolebindings:
oc get rolebindings -n new-ns NAME                                                              AGE admin-dedicated-admins                                            49s admin-system:serviceaccounts:dedicated-admin                      49s dedicated-admins-project-dedicated-admins                         49s dedicated-admins-project-system:serviceaccounts:dedicated-admin   49s
Steps to reproduce:

start crc
deploy the operator manually
add a log message to line 134, 151, and 159 to see if we exit there or not
comment out the return statements
apply the SubjectPermission CRs to ensure proper rolebindings have been created

@sam-nguyen7 Can you show logs from testing this before and after the change, and the resulting rolebindings? Can you also give steps to reproduce?

/hold

Considering it has been tested and logs attached to the PR, can we go ahead and merge that fix?
cc @jharrington22 @sam-nguyen7 @fahlmant

@rogbas yes this is ready to be merged. @jharrington22 can you remove hold and approve?

/hold cancel

/lgtm


oda spec fixes

The current ODA spec has too many bugs and omissions.
We reverse-engineered their pdf to a simple markdown document, which can produce equal pdf's, and came to this diff.
https://github.com/LibreDWG/libredwg/blob/master/doc/ODA-5.4.2-libredwg-diff.pdf
I don't think that you are allowed to copy and publish their original pdf.
The various missing objects and entities are described at https://github.com/LibreDWG/libredwg/blob/master/src/dwg.spec

@rurban @DomCR
Thank you for bringing up this topic as I believe this was going to come around sooner or later and it is a very important one since this project has gained traction.
The main thing is licensure. Since this project is currently MIT, are you granting the right for this project to use the LibreDWG spec without switching the license of ACadSharp to GPL3?  It is pretty critical to maintain a MIT or similar license as GPL3 code in the C# arena is pretty much a contribution and usage death sentence.

I cannot grant any license, the FSF owns it. But the spec is just docs and a clean-room translations of the ODA spec.
Any additions and fixes from this spec are also just docs, not code.

Thanks a lot for the resource!


Need to merge updates to master into the testing branch...

@bwise-7365 or @ahowe42 I don't understand why there are so many merge conflicts between master and testing, but we need to merge the updates to the travis configuration and the build scripts into testing...

Something has gone amiss...