swapi query working & status code rendering

Description

Implemented fetch request to swapi api
implemented status code rendering in dashboard

Related Issue

still missing size & time in dashboard

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Awesome job!


Vite 5 Support

Clear and concise description of the problem
Vite 5 is out now, but histoire currently has these allowed Vite versions:
"vite": "^2.9.0 || ^3.0.0 || ^4.0.0",

When I installed vite 5 using --force, it appeared to run fine for me, apart from these warnings being emitted:
The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
`resolve.browserField` is set to false, but the option is removed in favour of the 'browser' string in `resolve.mainFields`. You may want to update `resolve.mainFields` to remove the 'browser' string and preserve the previous browser behaviour.

Suggested solution
Check the Migration from v4 Guide for any issues Histoire might run into, and after resolving them add ^5.0.0 to the allowed Vite versions.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Then I updated some of my packages and saw the error posted above by @throrin19
Adding this to my package.json seems to be a suitable temporary workaround:
  "overrides": {
    "@histoire/shared": {
      "vite": "^5.0.3"
    }
  },

Trivy started showing CVEs in the last days for some of our Histoire integrations depending on peer deps, specifically Vite. Those adding overrides or Yarn resolutions please keep this in consideration when adding version specifiers. Trivy is a CLI that can be run locally against any lockfile to expose CVEs for remediation.


function dot delete does not work

function GUI point is not deleted when I click the dot and press delete key.
Tested on OS Windows.

@Lucarda can you reproduce this?

Now it works, it only stops working when I have All_objects.pd documentation opened.

Looks like a conflict with object keyname from vanilla.

Same problem here. Point is not deleted when I click the dot and press delete key.
Tested on Nobara 39.
Pd version 0.54.1
pd-else version 1.0-0 RC-11


Local Daily Notifications

I've been searching around before opening this issue and wasn't able to find a previous answer anywhere else.
So I was pretty excited about Jasonette and there is only one thing that seems to be missing:
I wanted to build a pretty simple inspirational quotes app that once a day notify the user about the daily quote. The user tap notification and is brought into the app where he can read the quote.
This type of app wouldn't need any push notifications or a server, as the events, as well as their content, is completely known and shipped with the app (a daily quote, once a day). I'd rather avoid any dependency on internet connection for this notification.
I saw that a timer is already defined in Jasonette and the only thing that seems to be missing is a way to send a notification to the notification bar. Any suggestions? Is there anyway to go around this missing module?
BTW, I'd like to make this app on iOS as well, hope that it is possible to do that. Any thoughts?

This would actually be a good feature to add.
But I can't promise anything right now in terms of when this can be implemented, because I'm already working on couple of other things.
I will however update this thread when it is implemented. BTW we've been making sure when rolling out a new feature it's implemented both on iOS and Android because cross platform matters a lot for this framework. So when you do hear about it, it will be implemented on both platforms.
Also, if you would like to build it yourself before I get to the feature, feel free to take a look at the source and play around, and send a pull request. From my experience, the hard part is NOT implementing features (Actual implementation only takes a few hours for features like this), but coming up with a markup syntax.

Well I think this can be implemented by using calendar notifications.  https://jasonelle.com/docs/how-to-guides.html#how-to-add-events-to-calendar


pytorch kfserving fails in kfserving v0.5.1

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
we are trying to create pytorch isvc ( both v1alpha2 and v1beta1 api versions )
https://github.com/kserve/kserve/blob/release-0.5/docs/samples/v1alpha2/pytorch/pytorch.yaml
https://github.com/kserve/kserve/blob/release-0.5/docs/samples/v1alpha2/pytorch/pytorch_v1beta1.yaml
I am using the above two samples, also modified the storageURI as per our needs
        "pytorch": {           "v1" : {             "image": "slb.artifactory.local/org/kubeflow/kfserving/pytorchserver",             "defaultImageVersion": "v0.5.1",             "defaultGpuImageVersion": "v0.5.1-gpu",             "supportedFrameworks": [               "pytorch"             ],             "multiModelServer": false           },           "v2" : {             "image": "slb.artifactory.local/org/kubeflow/kfserving/torchserve-kfs",             "defaultImageVersion": "0.3.0",             "defaultGpuImageVersion": "0.3.0-gpu",             "supportedFrameworks": [               "pytorch"             ],             "multiModelServer": false           }         }
here is the configmap of kserving-controller-manager
What did you expect to happen:
sklearn predictor is working good! facing issues while running pytorch
  Conditions:     Last Transition Time:  2022-02-01T04:44:51Z     Message:               Configuration "pytorch-cifar10-predictor-default" is waiting for a Revision to become ready.     Reason:                RevisionMissing     Severity:              Info     Status:                Unknown     Type:                  PredictorConfigurationReady     Last Transition Time:  2022-02-01T04:44:51Z     Message:               Configuration "pytorch-cifar10-predictor-default" is waiting for a Revision to become ready.     Reason:                RevisionMissing     Status:                Unknown     Type:                  PredictorReady     Last Transition Time:  2022-02-01T04:44:51Z     Severity:              Info     Status:                Unknown     Type:                  PredictorRouteReady     Last Transition Time:  2022-02-01T04:44:51Z     Message:               Configuration "pytorch-cifar10-predictor-default" is waiting for a Revision to become ready.     Reason:                RevisionMissing     Status:                Unknown     Type:                  Ready
when I saw the yaml of ksvc
 image: 'slb.artifactory.local/org/kubeflow/kfserving/pytorchserver:'           name: kfserving-container           readinessProbe:             successThreshold: 1             tcpSocket:               port: 0           resources:
image: 'slb.artifactory.local/org/kubeflow/kfserving/pytorchserver:'
image tags are not being added to the image name
tried with image digests
both are failing
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version: 1.9.0
Knative Version: 0.14.3
KFServing Version: 0.5.1
Kubeflow version: 1.3.0rc1
Kfdef:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube version:
Kubernetes version: (use kubectl version): 1.18.6
OS (e.g. from /etc/os-release):

Try changing the config.
    "pytorch": {
          "v1" : {
            "image": "kfserving/pytorchserver",
            "defaultImageVersion": "v0.6.1",
            "defaultGpuImageVersion": "v0.6.1-gpu",
            "supportedFrameworks": [
              "pytorch"
            ],
            "multiModelServer": false
          },
          "v2" : {
            "image": "pytorch/torchserve-kfs",
            "defaultImageVersion": "0.4.1",
            "defaultGpuImageVersion": "0.4.1-gpu",
            "supportedFrameworks": [
              "pytorch"
            ],
            "multiModelServer": false
          }
        },

It's works for me.

Perhaps I misunderstood you, but try replacing your line with this:
"image": "pytorch/torchserve-kfs"

@vijay-nag pytorchserver is deprecated as of 0.8.0, please try to migrate to torchserve instead.
https://kserve.github.io/website/0.8/modelserving/v1beta1/torchserve/


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.180

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.180


Let props.item (itemsNodeList) be either an existing NodeList or …

…a selector string

thanks @soenkekluth 👍

just thought - to be more flexible we should also check for
props.item instanceof HTMLCollection
in case you just simply use grid.children
I will PR again.
what do you think - also check for an instance of an Array to be even more flexible in collecting the item nodes outside minigrid?

@soenkekluth hmm I'm thinking that most of the cases this wouldn't happen. I don't want to bloat the API. Check against HTMLCollection would make sense however instance of Array sounds like an exceptional case no?

@soenkekluth by the way please use the branch next for PR. I'll update the CONTRIBUTING doc.

@soenkekluth please ignore the branch next request. I just deleted this branch. Cheers


Fix LiteFileStream.SetReadStreamPosition

Fix for issue #2458. Not a great solution, since it makes seeking much more expensive, but it works in my situation. I don't think there's a way to make it significantly faster without making chunks uniform length, which would require changes on the write side and not work for existing databases.

What version can use this fix?

I would like to see some unitttests for this pr as i currently don't fully understand the issue.

Thank you for your contribution and bearing with me :D


How to close JSMpeg palyer?

It's seem player.destroy() is not a function.
my player:
this.player = new JSMpeg.Player(this.cameraSource, {
    preserveDrawingBuffer: true,
    canvas: canvas,
    autoplay: true,
    loop: true
   }

player.destroy() is a function, if you player instance is called player.
In your code you assigned the player instance to this.player, so you probably have to call this.player.destroy(). Depending on what exactly this is in your code, it may or may not be available when you want to destroy the player. Can't tell without more context.
Since this looks like a generic JS question, rather than a bug report, you're probably better of asking for help on https://stackoverflow.com/


Dark Theme picture unreadable

Note dark blue color font doesnt show well on black.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5c49da09-47e7-6df5-4d36-c952bd8bb997
Version Independent ID: de8550cd-9c3d-6795-4242-b0f3d909796c
Content: Azure IoT Hub device streams C# quickstart for SSH and RDP
Content Source: articles/iot-hub/quickstart-device-streams-proxy-csharp.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

@dc995 Thank you for your valuable feedback, our team will further look into it and get back to you at the earliest.

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

#assign JimacoMS3

@dc995 Thanks very much for bringing this to our attention. I've fixed the diagram so that it has a white background. This makes it much more readable in dark mode:

I also changed this in the c topic.
Again, thanks for pointing this out! I'm now going to close this issue. If you think it requires further attention, please @-comment me in your response.
Thanks,
Jimaco

#please-close


Release/0.9.0

Current coverage is 95.03% (diff: 100%)

Merging #3 into develop will not change coverage

@@            develop         #3   diff @@
==========================================
  Files             3          3
  Lines           141        141
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            134        134
  Misses            7          7
  Partials          0          0

Powered by Codecov. Last update 03ecc9f...e233bf8


Fix disappearing FE

the frontend does not handle null values, so an empty list is send instead

Haha you're not fixing the "disappearing FE", you're fixing the API spec :-P


Document Configuration resolution methods

Expected Behavior
Resolving a Configuration is documented
Current Behavior
Opposite of expected
Context
I want to use a Configuration to download some dependencies. However, it seems there is a dozen different ways to get the files.
val pluginsClasspath = project.configurations.create("pluginsClasspath")

// which one do I use...?
pluginsClasspath.resolve()
pluginsClasspath.dependencies
pluginsClasspath.incoming
pluginsClasspath.incoming.artifacts
pluginsClasspath.incoming.artifactView { }.artifacts.artifactFiles
pluginsClasspath.incoming.artifactView { }.artifacts.artifactFiles.elements
pluginsClasspath.incoming.artifactView { lenient(true) }
pluginsClasspath.incoming.artifactView { lenient(true) }.files
pluginsClasspath.incoming.artifactView { lenient(true) }.artifacts
pluginsClasspath.incoming.resolutionResult
pluginsClasspath.incoming.resolutionResult.allComponents
pluginsClasspath.incoming.resolutionResult.allDependencies
pluginsClasspath.incoming.resolutionResult.allComponents {  }
pluginsClasspath.incoming.resolutionResult.root.dependencies
pluginsClasspath.incoming.resolutionResult.rootComponent.map { it.dependencies }
pluginsClasspath.artifacts
pluginsClasspath.artifacts.files
pluginsClasspath.resolvedConfiguration.files
pluginsClasspath.resolvedConfiguration.lenientConfiguration.firstLevelModuleDependencies
pluginsClasspath.resolvedConfiguration.lenientConfiguration.files
pluginsClasspath.resolvedConfiguration.lenientConfiguration.getFirstLevelModuleDependencies { true }
pluginsClasspath.resolvedConfiguration.getFirstLevelModuleDependencies { true }

Some of these options aren't documented

I can't find any place in the location where all of these options are compared, so that I can decide which option to use, and in what circumstances. Why are there so many? Maybe some of them are planned for removal? Which of them are lazy? Which should I use as input for a task? What should I put into ConfigurableFileCollection.from()?

Thank you for your interest in Gradle!
Your issue appears to be a question about how to use Gradle. Your question might be answered in Gradle documentation or on our community Slack or forums. Find links to these resources on help.gradle.org.
If you think you have come across a Gradle bug, please file a new issue describing the problem and how to reproduce it.
If you think Gradle is missing a feature, please file a new issue describing your use case for the feature.

Those methods are documented in the Javadoc.
Here is your starting point https://docs.gradle.org/current/javadoc/org/gradle/api/artifacts/Configuration.html

Those methods are documented in the Javadoc. Here is your starting point https://docs.gradle.org/current/javadoc/org/gradle/api/artifacts/Configuration.html

I can't find the answers to any of my questions in the Javadoc.
The Javadoc is not easily discoverable (when I search for them in the docs, there are no results)
I can't find any documentation that compares the myriad of options and which should be used in which situations

We really should have a "Dependency management crash course" page. I agree our existing pages that describe variants and such never end up discussing the basics/how to leverage the API.
This is definitely something that needs to be worked on.
To answer your original question -- the Configuration class has way too many APIs.
resolve() and files() do the same thing. This is usually what you want
artifacts and incoming.artifacts do the same thing give you the artifacts that files() would give you (artifacts are files + metadata about those files)
Anything on resolutionResult lets you inspect the graph without looking at the files.
Do not use resolvedConfiguration and resolvedConfiguration.lenientConfiguration. These are legacy types.
artifactView is more advanced, and with withVariantReselection can do some really cool stuff. See: link
Using artifactView with lenient=true allows you to ignore missing dependencies
Using artifactView with componentFilter lets you filter out certain dependencies from your results.


release 27.09.2022 v3

:tada: This PR is included in version 1.0.30 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix .NET rules

The following terms need to be updated in the rules:
.NET Core framework > .NET
.Net Core framework > .NET
.Net framework > .NET

Related style guidance: https://redhat-documentation.github.io/supplementary-style-guide/#dotnet


LinkedLists-Easy-4 in Java

@stormfireuttam Please only add the links in README. DO NOT format it.


📖 fixed Query and Mutation examples on README.md

Docs

Updated README.md  QueryBuilder and MutationBuilder examples with changes included in commit 77e111bd333e1166ce70d51137efb4bc15031a76

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Why is preview not keeping the same column flattening structure as GA?

Changing from a '.' to a '_' might seem like a simple thing, but it just frustrates users finding differences between the GA and preview versions of TSI. And sometimes, they are differences like this that makes me wonder if I should keep using TSI for my needs, cause I don't know what MS will decide to change next.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddb074e8-7df6-5b8d-01c1-63ac213a111a
Version Independent ID: 4c4d5abf-1a29-92db-709a-0d1ebacbfce4
Content: Shape events - Azure Time Series Insights
Content Source: articles/time-series-insights/time-series-insights-update-how-to-shape-events.md
Service: time-series-insights
GitHub Login: @deepakpalled
Microsoft Alias: dpalled

@olivoarroba Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @olivoarroba, your frustration is valid! In the spirit of transparency, I want to let you know that we are iterating yet again on the flattening logic--the PAYG SKU of TSI is on the path to GA, and for the GA of this SKU the logic will be different and will be applied to new environments.
Note that there are no new features being developed on the current S1/S2 SKU of TSI, all efforts are being focused on PAYG. Do you have a sample payload that you can share? A sample just showing the JSON structure with the actual values redacted would be sufficient. Then I could walk you though how these new changes would affect you if you created a new instance. As a high level summary, the delineator will be a "." and brackets [] will escape special characters.
We've been in an odd situation with both a GA version and a Preview version, and all of the changes that we're making are attempts to better meet the needs of customers such as yourself--although early adopters can thus have a somewhat tumultuous experience. We do and have gotten things wrong. I want to assure you that once PAYG is in GA you can expect more stability.

Thanks @lyrana... So the idea is that for new GA delineator will go back to dot '.'? That's good...
Changing from dot to underscore is not a big change anyway, but it is just one of those things where its an unnecessary change that forces users to change their interaction with TSI. That's where the frustration is coming from.
Are u tracking the flattening logic in a task that can be linked to this issue? that way I would be fine with closing this ticket.

@olivoarroba Answer is yes as per the @lyrana suggestions.
@lyrana Can this issue be closed?

Hi @olivoarroba
I am glad to hear that our decision to go back to a '.' is in line with your expectations. Linking PBI 3775658
#please-close
Below is an example of the column names that the new flattening logic will produce and how to query them, let me know if you have any questions.
TS ID has been configured as data.items.id
timestamp is data.items.id.datapoints.time
{
	"schema": "plant/schemas/ingest/datapoints_v2",
	"data": {
		"items": [{
			"id": "<timeseries id assigned by Plant>",
			"datapoints": [{
					"time": "2019-11-01T10:00:01.000Z",
					"value": 124.2,
					"status": 192
				},
				{
					"time": "2019-11-01T10:00:01.000Z",
					"value": 124.2,
					"status": 194
				}
			]
		}]
	}
}

Columns:
$ts |schema_String | data.items.id_String | data.items.datapoints.value_Double | data.items.datapoints.status_Long

Query Access:
$event.$ts
$event.schema.String
$event.data.items.id.String
$event.data.items.datapoints.value.Double
$event.data.items.datapoints.status.Long


Blog Page

@divyashukla23 @himanshu007-creator I want to create the Blog Page for the site, where all blogs will be listed, and by clicking on an article the blog will open with a comment section below it. Can you please assign this task to me?

This issue already exists.

If so please close the issue


Move meltano add "Plugin-specific behavior" section to "Plugins" doc

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2244
Originally created by @DouweM on 2020-08-12 16:04:32

View 4 previous comments from the original issue on GitLab


bump to master (#dc4c5d2) compatibility

@bobf hi, great project bro, thanks for #26 just keeping up to date ...

@dgv Ah, thanks - currently working on another branch that won't be ready for a while so definitely a good idea to update this separately.
Thanks for the positive words. :heart:


zprint COS command does not work

I have installed WebTerminal on IRIS 2019.1.0 and it is working great.
However, a ZP (zprint) COS command does not work.
when issuing for example:
zl test zp
I get the USER> prompt without anything
(if issuing the same on IRIS terminal, all work fine... i.e the routine has a source).
I have seen that the ZP (zprint) command is missing on the StaticContent class.
I tried to add it there, and then autocomplete of ZP (to zprint) works, but still not output is sent back to the client.

Hello @yaronmunz! Thank you for reporting this issue.
The thing is, we have a group of issues labeled Core Enhancement (blocker), which doesn't allow to run something exactly because of how WebTerminal works under the hood (on top of ObjectScript xecute + I/O redirection). Some system routines have their own rules for input/output (they switch output devices or expect some core terminal/system variables to be set by underlying I/O system), hence new problems appear.
I assume this wouldn't be the case if I implemented, for example, WebTerminal over telnet (because telnet wraps all internal execution magic and works exactly like a terminal), but it seems that this approach also has its own problems. Looks like telnet has its own disadvantages (is it Windows-only?).
So, currently, I am looking for an approach to change WebTerminal's core, which I belive will fix all similar issues, including yours.

Hello,
Thank you for your email. I have actually looked into the code. This is a nice implementation of WebSockets.
I think that if you going to use a telnet (stream) object to handle all communication, it might be slower (in response) than the current response time with websocket.
However, I think that some of the issues that were reported (I looked at some of them in github) might be solved with minimal coding of those special cases. (probably the same way you implement the sql feature).
The command ZP (zprint) should not be an issue to use for example:
Set routine = ##class(%Routine).%New("test.int")
while 'routine.AtEnd { w !,routine.ReadLine() }
Yaron Munz
IRIS / Ensemble architect
MSC MEDITERRANEAN SHIPPING COMPANY SA
16, Avenue Eugène Pittard , 1206 Geneva, Switzerland
M: +41 78 721 6666 W: www.msc.comhttp://www.msc.com/
From: Nikita Savchenko<EMAIL_ADDRESS>Sent: Friday 28 June 2019 15:11
To: intersystems-community/webterminal<EMAIL_ADDRESS>Cc: Yaron Munz (MSC Geneva<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [intersystems-community/webterminal] zprint COS command does not work (#125)
Hello @yaronmunzhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fyaronmunz&data=02|01|yaron.munz%40msc.com|3c27b6714b8c4ff472ad08d6fbca2207|088e9b00ffd0458ebfa1acf4c596d3cb|1|0|636973242908433881&sdata=8VlIftxCLOzMehRwqnBLEt2E8nInY3U9EpnJaLtxiwU%3D&reserved=0! Thank you for reporting this issue.
The thing is, we have a group of issueshttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%3Fq%3Dis%253Aissue%2Bis%253Aopen%2Blabel%253A%2522Core%2BEnhancement%2B%2528blocker%2529%2522&data=02|01|yaron.munz%40msc.com|3c27b6714b8c4ff472ad08d6fbca2207|088e9b00ffd0458ebfa1acf4c596d3cb|1|0|636973242908443889&sdata=I6z1UynCcsOAmApYIugOwnCFrHUdGk5nrAH%2BvTefxQA%3D&reserved=0 labeled Core Enhancement (blocker), which doesn't allow to run something exactly because of how WebTerminal works under the hood (on top of ObjectScript xecute + I/O redirection). Some system routines have their own rules for input/output (they switch output devices or expect some core terminal/system variables to be set by underlying I/O system), hence new problems appear.
I assume this wouldn't be the case if I implemented, for example, WebTerminal over telnethttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%2F103&data=02|01|yaron.munz%40msc.com|3c27b6714b8c4ff472ad08d6fbca2207|088e9b00ffd0458ebfa1acf4c596d3cb|1|0|636973242908443889&sdata=C6ZqDZU0IH79Jm2zxoW67UBQexg5pWR%2FPdVI8r412x0%3D&reserved=0 (because telnet wraps all internal execution magic and works exactly like a terminal), but it seems that this approach also has its own problems. Looks like telnet has its own disadvantages (is it Windows-only?).
So, currently, I am looking for an approach to change WebTerminal's core, which I belive will fix all similar issues, including yours.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%2F125%3Femail_source%3Dnotifications%26email_token%3DAMO4CLKBZHHGPJIJSA4JVQLP4YEX7A5CNFSM4H32ZLQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2A72Y%23issuecomment-506728427&data=02|01|yaron.munz%40msc.com|3c27b6714b8c4ff472ad08d6fbca2207|088e9b00ffd0458ebfa1acf4c596d3cb|1|0|636973242908453902&sdata=aZNPUsfT6vsiZYoz%2FjfrnkWEdNSiC4nGy7ll%2B0lHc5g%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMO4CLJRMP5K475OY7IZX2TP4YEX7ANCNFSM4H32ZLQA&data=02|01|yaron.munz%40msc.com|3c27b6714b8c4ff472ad08d6fbca2207|088e9b00ffd0458ebfa1acf4c596d3cb|1|0|636973242908463910&sdata=W64s34ThGWaNOzzldcYcXHbLKBFxRQG3gC%2FmozwpY58%3D&reserved=0.
Sensitivity: Internal
This message and any associated files (together the "Contents") are intended solely for the addressee(s). The Contents are confidential and may contain private information or information that is subject to copyright or is a trade secret or which is privileged. Views or opinions expressed herein do not necessarily represent views or opinions of MSC Mediterranean Shipping Company, its agents or their affiliated companies and may only be the view or opinion of the author. If you are not the intended recipient of this email, you must not use, print, copy, store, forward, or disclose it or act in reliance of the Contents. Please destroy all copies of the message and any associated files and notify the sender immediately that you have received it in error. Thank you for your cooperation.------MSC LEGAL DISCLAIMER

However, I think that some of the issues that were reported (I looked at some of them in github) might be solved with minimal coding of those special cases. (probably the same way you implement the sql feature).

Do you mean just hard-coding some cases like "if command = this then execute this custom code"? If so, this is a very dangerous way to fix things... At least, it hides an original behavior from the user, which may mislead them if the command has some options not covered by this "dirty fix".

Hello Nikita.
Yes, I agree that  hard coding is "dangerous" and not the proper way to keep everything seamless.
However, the "zl routine zp" command is a very special case that is always done without anything else at that line.. so, I have hard coded that :
<EMAIL_ADDRESS>Yaron Munz
IRIS / Ensemble architect
MSC MEDITERRANEAN SHIPPING COMPANY SA
16, Avenue Eugène Pittard , 1206 Geneva, Switzerland
M: +41 78 721 6666 W: www.msc.comhttp://www.msc.com/
From: Nikita Savchenko<EMAIL_ADDRESS>Sent: Friday 28 June 2019 19:51
To: intersystems-community/webterminal<EMAIL_ADDRESS>Cc: Yaron Munz (MSC Geneva<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [intersystems-community/webterminal] zprint COS command does not work (#125)
However, I think that some of the issues that were reported (I looked at some of them in github) might be solved with minimal coding of those special cases. (probably the same way you implement the sql feature).
Do you mean just hard-coding some cases like "if command = this then execute this custom code"? If so, this is a very dangerous way to fix things... At least, it hides an original behavior from the user, which may mislead them if the command has some options not covered by this "dirty fix".

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%2F125%3Femail_source%3Dnotifications%26email_token%3DAMO4CLJFZKRBCNFPVHUOE3TP4ZFRXA5CNFSM4H32ZLQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2X57Y%23issuecomment-506822399&data=02|01|yaron.munz%40msc.com|e61913ec72504a1e0ecb08d6fbf13cd6|088e9b00ffd0458ebfa1acf4c596d3cb|1|0|636973410862790476&sdata=RyPfH945W%2BF6n8RPstvn3UXN96284%2FD0wd65R9GBfwA%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMO4CLNBR7DY5DOOPEI5RZTP4ZFRXANCNFSM4H32ZLQA&data=02|01|yaron.munz%40msc.com|e61913ec72504a1e0ecb08d6fbf13cd6|088e9b00ffd0458ebfa1acf4c596d3cb|1|0|636973410862790476&sdata=SUvrm4E1ETGoL4sSS9rEUdN%2B1Fnd3OyoSsTGkCcpQPQ%3D&reserved=0.
Sensitivity: Internal
This message and any associated files (together the "Contents") are intended solely for the addressee(s). The Contents are confidential and may contain private information or information that is subject to copyright or is a trade secret or which is privileged. Views or opinions expressed herein do not necessarily represent views or opinions of MSC Mediterranean Shipping Company, its agents or their affiliated companies and may only be the view or opinion of the author. If you are not the intended recipient of this email, you must not use, print, copy, store, forward, or disclose it or act in reliance of the Contents. Please destroy all copies of the message and any associated files and notify the sender immediately that you have received it in error. Thank you for your cooperation.------MSC LEGAL DISCLAIMER

I understand this case. However, I would keep hard-coding away from the "official" releases. Just another possible case from numerous cases... If the project goes wild (for example, a maintainer changes) then people will start to hard-code everything by example, and this will turn into a total mess.
I am closing this issue - please feel free follow WebTerminal project, I think it has a good chance to be fixed one day in the future, within the core patch making it 100% compatible with standard Cache Term.


[MM-55649] Fix margin of LatexInline

Summary
Modified style properties of latex inline.
Ticket Link
Fixes https://github.com/mattermost/mattermost/issues/25561
JIRA: https://mattermost.atlassian.net/browse/MM-55649
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on:
Screenshots

Before:

After:

Release Note
NONE

@Paul-vrn This doesn't seem to work in all scenarios. For example, the following text would show as the attached screenshot:
hello $\frac{\sqrt{x^n}}{x^2}$ world world world world world world world world world world world world world world $\frac{\sqrt{x^n}}{x^2}$  world world world world world world $test$

@Paul-vrn I was trying on Android emulator.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@Paul-vrn I saw your last change, and tried it on the android emulator, and still see the same behavior.

@Paul-vrn This doesn't seem to work in all scenarios. For example, the following text would show as the attached screenshot:
hello $\frac{\sqrt{x^n}}{x^2}$ world world world world world world world world world world world world world world $\frac{\sqrt{x^n}}{x^2}$  world world world world world world $test$

@larkox hey, that's weird, what device are you using? I can't reproduce this on my simulator (iphone X or iphone 13).

I reproduced it on the android emulator(14.0). If this issue hasn't been solved yet, I'd like to fix it.

Android (14.0)
iOS (17.0)

@Paul-vrn This doesn't seem to work in all scenarios. For example, the following text would show as the attached screenshot:
hello $\frac{\sqrt{x^n}}{x^2}$ world world world world world world world world world world world world world world $\frac{\sqrt{x^n}}{x^2}$  world world world world world world $test$

@larkox hey, that's weird, what device are you using? I can't reproduce this on my simulator (iphone X or iphone 13).

Hi @Paul-vrn This issue(inconsistent inline latex height between android and ios) resolved . It's your turn 😉

@Paul-vrn This Issue not resolved.

@Paul-vrn Now, You can resolve This Issue

@Paul-vrn Now, You can solve This Issue

yes but sorry, I don't have anymore time to work on it, I'm unsigning myself from it

Ok. Wishing you the best, Paul-vrn!


iPhone 6 daily kernel panic, reboots

iPhone 6 10.2 on yalu beta 7, the jailbreak will be stable for the first hour after initial reboot/jailbreak with yalu app; but while using games or apps in high memory, the device randomly panics. I'm able to reproduce the issue almost every time with certain games or occasionally with snapchat, so i'm not sure if this is a memory issue or not? While having games open on my device, i've been having 3-4 reboots daily since beta7..
This seems like a well known issue on iPhone 6 but not widely reported by people, just by browsing search on /r/jailbreak. https://www.reddit.com/r/jailbreak/comments/5qttpz/discussion_random_reboots_on_iphone_6_102/?st=izsqozov&sh=59abab2d Of course thinking this is because memory, i tried increasing the memory limit by setting UserHighWaterMark from 225 to 425 from com.apple.jetsamproperties.N61.plist in /System/Library/LaunchDaemons/. I even tried installing the iOS 9 Reboot Fix tweak after changing those values as well https://www.reddit.com/r/jailbreak/comments/4jncdl/tutorialhow_to_fix_random_ios_9_reboot_at_night/?st=izsr0797&sh=e5a869f6
I'm happy to provide as many panic logs as you want, i'm just wondering if this issue is being looked and will be fixed soon in the upcoming betas or release.
http://pastebin.com/tyHX00m5
http://pastebin.com/4S5NcuE1

然并卵

+1 same here...

Can confirm random kernel panics here... seems to happen about 4-5 days of uptime, even without Mobile Substrate or any tweaks running

1-2 days then it's booting into normal mode :/


Subfolders + Saving latents multiple times

I'm using multiple subfolders inside of a main train data folder to sort out files by theme and subject, however, seems like script goes the same amount of times to cache the latents as amount of folders :) It created latents from the first run (at least it looks like it is created), but it does it again and again (and I have like 8 folders).
Might be some sort of unnecessary forloop or something.

erhm... it processed the folders 3 times (less times than amount of folders) and began to train. Not sure why it is separated, but let this ticket be a headsup for the author, this might be done in a single pass possibly or the logic of caching latents could possible do extra runs for no reason

it processed the folders 3 times

It processed separatedly for 3 different resolutions with different batching - 512, 768 and 1024.

Got it, thanks.


fix: Don't add cluster CIDR to CNI Conflist if AzureCNIOverlay is Enabled 1/2

What type of PR is this?

/kind bug
What this PR does / why we need it:
Don't add cluster CIDR to CNI conflist if AzureCNIOverlay is enabled
Which issue(s) this PR fixes:

Fixes #
Requirements:

[X] uses conventional commit messages

[ ] includes documentation
[X] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Part 2 of PR #2408
Release note:
none

Do not block current logic with current cse script package. Current function Set-AzureCNIConfig does not support IsAzureCNIOverlayEnabled

It's not mandatory and false by default now


Dashboard not displaying commit activity details

Gitea version (or commit ref): v1.6.1
Git version: 2.11.0
Operating system: Debian GNU/Linux 9 (stretch) 4.14.52
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist: LINK

Description
Upgraded from v1.4.3 to v1.6.1. Everything seems to work fine, except the Dashboard, which won't display recent commit details anymore. Log details are attached in the gist above, and a screenshot is available on imgur at the link below. :smiley:
Screenshots
https://i.imgur.com/rnZsONb.png

could you reproduce that on https://try.gitea.io ? I cannot reproduce it locally.

I can't reproduce it on try.gitea.io.

I'm having the same issue on 1.6.0, running on Arch Linux, with MySQL as the database.
I checked the "action" table (i'm assuming that's where the info is coming from) and no commits since i upgrade from 1.5.3 to 1.6.0 have been added to the action table.
i couldn't find any relevant errors in any gitea log files either.
i'll try and do some deeper investigation to see if I can figure out why it's happening.

I just tried creating a new repo and pushing to it. It seems that the commits are showing up in the dashboard, but commits from before migrating to 1.6.1 are not showing up. So in my case it does not seem to be a permissions issue.
Also, looking at my log gist in OP, there seems to be an error:
ERROR: invalid character '\n' in string literal


remove npm-debug and add to .gitignore

the npm-debug file was nearly a meg. Typically those shouldn't be included with git repos as it adds unnecessary bloat. to the repo size.

 Thanks for that.

No worries :smiley:


grt: cleanup

Moves all global variables to FastRouteCore class as attributes
Moves all functions of the core code as FastRouteCore class methods

@maliberty I've fixed the code style of the class attributes.

Looks good to me


BUG: categorical doesn't handle display.width of None in Python 3 (GH10087)

closes #10087
I think this is fairly straightforward, however I am not sure if the prior code comparing display.width to 0 was correct... is display.width ever supposed to be set to 0? It looks suspiciously similar to a snippet from Series.__unicode__(), but that is looking at display.max_rows. Maybe it was brought over incorrectly?
If it should just be a simple comparison to None, not 0 as it was before, just let me know and I'll amend this.

I think my git skills have gone rusty. I am trying to amend my commit, but it doesn't like that I have already pushed it - it won't accept my new (amended) push, saying I am behind the remote counterpart. But the remote just has the changes before the amended commit. Any hints?

I just forced the push. Not sure if there was any better way.
At any rate, I incorporated most of your comment. I think 0 is a valid value, as it's checked against in code below.

@rosnfeld Yes, you need to force if you amend a commit.

Ok, good to know - thanks.
@jreback Travis is happy if you're happy (with this change).

@rosnfeld thanks! hope this exercised those git skills! maybe need another PR to work on that :)


Rename LeaseClient to BlobLeaseClient

Renames LeaseClient to BlobLeaseClient.

/azp run java - storage - ci

Validation failed due to transient testing issue, will merge once approved.


OCPBUGS-27366: add separate authentication config manifest for hypershift

This allows a new configuration on hypershfit by default that isn't in OCP self managed by default.
Long term we need to change how we generate these types to avoid having a fragile, potentially mismatching type.
/hold
needs testing and

move the rendering to merge first
update installer to pass the clusterprofile arg
update hypershift to pass the clusterprofile arg
merge the rest

tested with ./render  --cluster-profile=ibm-cloud-managed --rendered-manifest-dir=../installer-input-manifests --payload-version=fake --asset-output-dir=../output-hypershift --image-manifests=../image-input-manifests and the diff is correct for featuregate specified in input manifests and the clusterprofile in the arg.
A likely better approach in 4.16 with more time is to read the clusterprofile from the infra resource peer to featuregate.
@sjenning @stlaz
fyi @patrickdillon , this will be coming.  I need to open a bug.

/retest

/test integration

/hold cancel

/cherrypick release-4.15


build(deps): migrate to @fastify/error

fastify-error has been deprecated as the module has been moved to @fastify/error

CI is failing

CI is failing

#74 seems to be the reason


Fixing the default and max typmod arg cases for various datatypes in procedure

Description
Currently, end user is able to specify nvarchar(max) for output param while defining the procedure. Procedure will be created without any error but it will throw an error upon executing the procedure. This PR will handle the default and max output params for procedure. We have handled and tested the following datatypes :
NVARCHAR [ ( n | max ) ]
VARCHAR [ ( n | max ) ]
VARBINARY [ ( n | max ) ]
NCHAR [ ( n ) ]
SMALLDATETIME
DECIMAL [ ( p [ , s ] ) ]
BINARY [ ( n ) ]
BPCHAR [ ( n ) ]

Signed-off-by: Tanya Gupta<EMAIL_ADDRESS>Issues Resolved
BABEL-5059
Test Scenarios Covered

Use case based - YES

Boundary conditions - YES

Arbitrary inputs - YES

Negative test cases - YES

Minor version upgrade tests - NA

Major version upgrade tests - NA

Performance tests - NA

Tooling impact - NA

Client tests - NA

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

16 of 16 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 74.471%

Totals

Change from base Build<PHONE_NUMBER>6:
0.01%

Covered Lines:
44940

Relevant Lines:
60346

💛  - Coveralls


How is the JS code sandboxed?

Hi! Very nice project.
I was looking at the script.rs code and couldn't quite understand how the JS code is sandboxed. Is the sandboxing coming from the default Deno runtime configuration? What are the guarantees we can assume here?
Thank you!

Yes, Deno takes care of the sandboxing.
On its homepage, the mission statement includes:

Secure by default. No file, network, or environment access, unless explicitly enabled.

More detailed information can be found on the Permissions page. Those are not (yet?) provided by js-sandbox though.

Thanks! Very useful!


Update Pulumi SDK to reflect API's required CT arguments.

According to the Proxmox API viewer, the API requires vmid, node, and ostemplate. However, from experience, this alone is not enough. It will still complain if you don't supply at least one network interface, so I made that required too.
Unfortunately, I don't have much experience with 2/4 languages, so I only applied this to NodeJS and Python:

[x] NodeJS
[x] Python
[ ] .NET
[ ] Go

thank you for this PR and i appreciate spotting this!
however, i’m reluctant to merge this one due to the reason of how these files are being generated. basically, the underlying terraform provider specification is taken and all sdk specific files are autogenerated based on that.
in fact, if i were to update the provider version these changes are lost, and would have to be manually added again. this leads to the issue, and challenge, of not loosing them in a future update and this „bug“ appearing again.
hence, i‘m tending to not merge your changes. what i can imagine though are some words, and references to the proxmox api, in the README and/or the official docs of this provider?

I understand. I suppose documentation is better than nothing. Thanks!


Revert "Feature/add_json"

Reverts AyakorK/Project_PythonAPI#2

Correcting an error from branches merge to main


unused import false positive default Laravel User class

I think this is caused by the same bug as #49, right?
Lints for app/User.php
============
! There should be no unused imports.
6 : `use Illuminate\Foundation\Auth\User as Authenticatable;`

More than likely


[BUG] Allocation and Rebalance Constraints of WeightFunction are incorrectly reset to default if indexBalanceFactor, shardBalanceFactor or preferPrimaryShardRebalanceBuffer is updated

Describe the bug
In BalancedShardsAllocator, the update consumers of PREFER_PRIMARY_SHARD_REBALANCE and PREFER_PRIMARY_SHARD_BALANCE directly modifies the  constraint config of existing weightFunction. However, if indexBalanceFactor, shardBalanceFactor or preferPrimaryShardRebalanceBuffer is updated, a new weightFunction is constructed, which will discard the preferPrimary Constraint configs of previous weightFunction.
  /**
     * When primary shards balance is desired, enable primary shard balancing constraints
     * @param preferPrimaryShardBalance boolean to prefer balancing by primary shard
     */
    private void setPreferPrimaryShardBalance(boolean preferPrimaryShardBalance) {
        this.preferPrimaryShardBalance = preferPrimaryShardBalance;
        this.weightFunction.updateAllocationConstraint(INDEX_PRIMARY_SHARD_BALANCE_CONSTRAINT_ID, preferPrimaryShardBalance);
        this.weightFunction.updateAllocationConstraint(CLUSTER_PRIMARY_SHARD_BALANCE_CONSTRAINT_ID, preferPrimaryShardBalance);
        this.weightFunction.updateRebalanceConstraint(INDEX_PRIMARY_SHARD_BALANCE_CONSTRAINT_ID, preferPrimaryShardBalance);
    }

    private void setPreferPrimaryShardRebalance(boolean preferPrimaryShardRebalance) {
        this.preferPrimaryShardRebalance = preferPrimaryShardRebalance;
        this.weightFunction.updateRebalanceConstraint(CLUSTER_PRIMARY_SHARD_REBALANCE_CONSTRAINT_ID, preferPrimaryShardRebalance);
    }

 private void updateIndexBalanceFactor(float indexBalanceFactor) {
        this.indexBalanceFactor = indexBalanceFactor;
        updateWeightFunction();
    }

    private void updateShardBalanceFactor(float shardBalanceFactor) {
        this.shardBalanceFactor = shardBalanceFactor;
        updateWeightFunction();
    }

    private void updatePreferPrimaryShardBalanceBuffer(float preferPrimaryShardBalanceBuffer) {
        this.preferPrimaryShardRebalanceBuffer = preferPrimaryShardBalanceBuffer;
        updateWeightFunction();
    }

    private void updateWeightFunction() {
        weightFunction = new WeightFunction(this.indexBalanceFactor, this.shardBalanceFactor, this.preferPrimaryShardRebalanceBuffer);
    }

Related component
Cluster Manager
To Reproduce

set setting "PREFER_PRIMARY_SHARD_BALANCE" as true
set setting "SHARD_BALANCE_FACTOR_SETTING" as 0.5f (arbitrary value which differs from default value 0.45f)
the preferPrimary constraints of weight function will be incorrectly disabled.

Expected behavior
Updating indexBalanceFactor, shardBalanceFactor or preferPrimaryShardRebalanceBuffer will not reset preferPrimary constraints of weight function to default.
Additional Details
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

[Triage - attendees 1 2 3 4 5 6 7 8]
@KunjueYu Thanks for creating this issue, we'd welcome a pull request to address this bug

@peternied I would like to take this up


Time as an entity not a unit

For new term requests, please provide the following information:
Preferred term label
Time
Synonyms
Can use: http://purl.obolibrary.org/obo/PATO_0000165
Textual definition
Use PATO definition or:
A nonspatial continuant that is measured in terms of a sequence of events.
Suggested parent term
Operational
Attribution
0000-0003-1023-6239

Suggest removing the following as they are not in line with the model. Can more richly describe using other component parts in the ontology.
http://purl.obolibrary.org/obo/BSM_0400010
http://purl.obolibrary.org/obo/BSM_0400012
http://purl.obolibrary.org/obo/BSM_0400011
http://purl.obolibrary.org/obo/BSM_0400009
http://purl.obolibrary.org/obo/BSM_0400008
http://purl.obolibrary.org/obo/OBI_0001619


feat(DTFS2-6556): rename bank

Introduction
Renamed Virgin Money UK to Virgin Money
Resolution

Renamed bank.

Miscellaneous

Spelling fixes
Lint fixes
Dependences updates

Codecov Report

Merging #2046 (d201dac) into main (2390d16) will decrease coverage by 0.32%.
Report is 4 commits behind head on main.
The diff coverage is 7.69%.

:exclamation: Current head d201dac differs from pull request most recent head 80aac10. Consider uploading reports for the commit 80aac10 to get more accurate results

@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
- Coverage   21.01%   20.70%   -0.32%
==========================================
  Files        1030     1135     +105
  Lines       25229    26709    +1480
  Branches     4081     4437     +356
==========================================
+ Hits         5303     5531     +228
- Misses      17370    18429    +1059
- Partials     2556     2749     +193

Flag
Coverage Δ

api-test
0.48% <0.00%> (?)

ui-test
64.81% <32.35%> (ø)

unit-test
1.99% <2.30%> (+1.27%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...-function/acbs-amend-facility-loan-record/index.js
0.00% <0.00%> (ø)

...unction/acbs-amend-facility-master-record/index.js
0.00% <0.00%> (ø)

...nctions/acbs-function/acbs-amend-facility/index.js
0.00% <0.00%> (ø)

...unctions/acbs-function/acbs-facility-bond/index.js
0.00% <0.00%> (ø)

...unctions/acbs-function/acbs-facility-loan/index.js
0.00% <0.00%> (ø)

...ure-functions/acbs-function/acbs-facility/index.js
0.00% <0.00%> (ø)

...nctions/acbs-function/acbs-issue-facility/index.js
0.00% <0.00%> (ø)

azure-functions/acbs-function/acbs/index.js
0.00% <0.00%> (ø)

...on/activity-create-code-value-transaction/index.js
0.00% <0.00%> (ø)

...s-function/activity-create-deal-guarantee/index.js
0.00% <0.00%> (ø)

... and 115 more

... and 97 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


Add new MetaCyc pathways for lysine biosynthesis

Add GO terms for these MetaCyc pathways:
http://biocyc.org/META/NEW-IMAGE?type=PATHWAY&object=LYSINE-AMINOAD-PWY
http://biocyc.org/META/NEW-IMAGE?type=PATHWAY&object=PWY-3081
as children of 'lysine biosynthesis via aminoadipic
acid ; GO:0019878'.
For fig2go mapping.
Reported by: jl242
Original Ticket: "geneontology/ontology-requests/3292":https://sourceforge.net/p/geneontology/ontology-requests/3292

thanks www.movied.org


Patch for base64 0.21

While working on updating the base64 crate in Debian I prepared a patch to make condure build with the new base64. There were a couple of changes in the API of base64.

Rather than passing a config to encode_config_slice one now has to call encode_slice on an engine.
encode_slice now returns a result instead of panicing on error.

Patch is at https://salsa.debian.org/rust-team/debcargo-conf/-/blob/7f22f126538a2c811d44d05e6e7f770417fd59ab/src/condure/debian/patches/base64-0.21.diff

I updated the patch for condure 1.10, the new version is available at https://salsa.debian.org/rust-team/debcargo-conf/-/blob/171ebbf31695774186bd7d279031906c7f179082/src/condure/debian/patches/base64-0.21.diff


Syntax Highlighting in JS & PHP files is Removed when Adding those File Associations

When I open up my settings.json to add:
"files.associations": {
    "*.php": "html",
    "*.js": "html"
},

PHP and JS files have their syntax highlighting removed completely.

Ok so I see that these files are included by default, so no need to add them again, but they are not the first things to show up in the popup, any way to give HTML snippets more prominence over other snippets that show.

Hello,
If you want to add languages to the extension please follow this link
Make extension work in languages other than HTML


Unable to specify parking waypoint for ParkRobotIndefinitely request factory

Before proceeding, is there an existing issue or discussion for this?

[X] I have done a search for similar issues and discussions.

OS and version
Ubuntu 22.04
Open-RMF installation type
Source build
Other Open-RMF installation methods
No response
Open-RMF version or commit hash
2.0.3
ROS distribution
Humble
ROS installation type
Source build
Other ROS installation methods
No response
Package or library, if applicable
No response
Description of the bug
I want to make some changes in ParkRobotFactory class (currently it is using dedicated_charging_waypoint when a parking waypoint is not passed in, I want to change it to a dedicated parking waypoint so that the robot will be able to park at a dedicated parking waypoint instead of its charger). In order to make that change, I have cloned the rmf_task package from your repo to local, together with your rmf_demos codes, and all packages are building fine. However, when I use ros2 launch rmf_demos_gz_classic office.launch.xml to launch your office demo, all navigation paths are not showing up in Rviz, and the robot is not spawned in the map either. In terminal there is a relevant error message as below.
[fleet_adapter-16] ImportError: /opt/ros/humble/lib/librmf_fleet_adapter.so: undefined symbol: _ZN8rmf_task4Task7BookingC1ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEENSt6chrono10time_pointINS8_3_V212steady_clockENS8_8durationIlSt5ratioILl1ELl1000000000EEEEEESt10shared_ptrIKNS_8PriorityEERKS7_SG_b
[ERROR] [fleet_adapter-16]: process has died [pid 8350, exit code 1, cmd '/home/agsw/Desktop/teabot-http/install/rmf_demos_fleet_adapter/lib/rmf_demos_fleet_adapter/fleet_adapter -c /home/agsw/Desktop/teabot-http/install/rmf_demos/share/rmf_demos/config/20th_floor/tinyRobot_config.yaml -n /home/agsw/Desktop/teabot-http/install/rmf_demos_maps/share/rmf_demos_maps/maps/20th_floor/nav_graphs/0.yaml -sim --ros-args --params-file /tmp/launch_params_93ybb49j --params-file /tmp/launch_params_d36yp8ry'].
The local rmf_task package shall take priority over the underlay workspace (/opt/ros/humble). And I have tried to clone rmf_fleet_adapter_python package locally with the rmf_demos packages, it is working fine (builds fine, and Rviz launches fine). The issue is only with the rmf_task package. Hope you can shed some light on above error. Suggestions on other approaches to implement that change to ParkRobotFactory class are also welcome! Thanks much in advance.
Steps to reproduce the bug

clone rmf_demos codes
close rmf_task package, put it alongside with other packages in rmf_demos
colcon build, and source install/setup.bash
ros2 launch rmf_demos_gz_classic office.launch.xml to launch the office demo
navigation paths and robots are not showing up in Rviz

Expected behavior
No response
Actual behavior
No response
Additional information or screenshots
This is the file structure in my workspace.

Hi @CarlyyyChen,
Thanks for highlighting your problem.
Your experience highlights a problem in our EasyFullControl implementation which is used by the robot fleets in rmf_demos. See rmf_demos_fleet_adapter.
The issue is that as seen in the implementation linked above, we construct the ParkRobotIndefinitely factory without passing in a parking_waypoint. As a result, the default std::nullopt is passed which sets the parking waypoint as the charger waypoint and the robot always goes to it's charging waypoint assigned to the robot in the fleet config.
Here's my proposal for a more proper fix:

Update the rmf_task::State class to get/set a dedicated_parking_waypoint field similar to the existing dedicated_charging_waypoint.
Add a parking field to the config similar to charger.
Add std::vector<std::size_t> parking_waypoints to EasyFullControl::RobotConfiguration. And have EasyFullControl::Configuration::from_config_file to parse the parking field from the config and append the right waypoint to RobotConfiguration.
Add a RobotUpdateHandle::set_parking_waypoint() API here.
Take the parking waypoint form the RobotConfig and set it for the RobotUpdateHandle returned FleetUpdateHandle::add_robot() is called here
Update RobotContext to make and get an rmf_task::State with the dedicated_parking_waypoint property
Finally, update the ParkRobotIndefinitely::make_request() to actually plan to the state.dedicated_parking_waypoint()

@mxgrey @arjo129 I think this approach might play nicely with the Reservation system integration but please share otherwise!

Hi @Yadunund thanks for suggesting the plan. It is exactly the same as I have planned. But I was stuck at the very first step -- adding rmf_task package to local in order to change it. Appreciate if you can advise more on the ImportError and issue with Rviz!


[WIP] Implement FSharpQuickInfoProvider (by @OmarTawfik)

Could you add one or two unit tests that exercises ProvideQuickInfo please?  There are many other unit tests already for the underlying logic of course, but having something in place to enable further future testing at the level of ProvideQuickInfo would be great

@vasily-kirichenko Absolutely fantastic to see this in place.

Could you add one or two unit tests that exercises ProvideQuickInfo please? There are many other unit tests already for the underlying logic of course, but having something in place to enable further future testing at the level of ProvideQuickInfo would be great

I'd like to make it work first. I still throws exception.

It kind of works now. The tooltip is always positioned below all visible text, not close to the symbol.

@vasily-kirichenko Yeah, getting the positioning right is really important.

Great to see the progress!

@vasily-kirichenko See https://github.com/Microsoft/visualfsharp/pull/1855 for the methodology to add tests

@vasily-kirichenko This looks great.  I left a bunch of fairly minor comments.

The position is fixed:

Added a test.

The only issue left: it does not respect theme colors.

I've ported somewhat hacky code from VFPT to get current theme colors (https://github.com/fsprojects/VisualFSharpPowerTools/blob/03c613acd3aa67cb5e3a339d3dcf1c7c783f30c2/src/FSharp.Editing.VisualStudio/Common/VSColors.fs)
It works:

If anybody knows a better way to do it, please tell us.

Awesome!

This is fantastic. Looks ready to go to me, once green

@vasily-kirichenko Thank you!

Looks like it's pure hash table https://referencesource.microsoft.com/#mscorlib/system/runtime/compilerservices/ConditionalWeakTable.cs,464 Is it ok or I should remove the cache?

Yes, that's an object identity hash, not a call to obj.GetHashCode().  We should remove the cache for now

Just to mention that after this change both the QUickInfo and errors show when hovering over a red squiggly
This is good, but disambiguating between these using colors will be necessary

@dsyme we don't have control over errors formatting.

both the QuickInfo and errors show when hovering over a red squiggly

A long needed and overdue feature 😄

@vasily-kirichenko I'm noticing a lot of issues where VIsual Studio seems to hang while getting QuickInfo during debugging of F# code.
I'm not sure if this is our problem, but it feels like it is.  It may make sense to work out how to turn off semantic/error quick info while debugging F# code.  At least we need to investigate further

Is it quick info, or determining data-tip spans?  Perhaps something in that code path is sub-optimal?

@Pilchie Hard to tell. It's an outright hang of the VS IDE.  I got one stack trace where the main UI thread was on roslyn code calling through to a quick info provider in a blocking wait (the word "QuickInfo" was definitely on the stack.  I presume it was the F# provider for quick info tips. I'll try to repro and get better stack traces.
Is there a way to disable the F# Quick Info service when debugging is active if we need it?
thanks

Maybe it's not related, but I think this code https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.Editor/QuickInfoProvider.fs#L81-L88 is too heavy weight to get qualified name island, start column of the last part of it and its TextSpan. Maybe it's possible to use something like QuickParse.GetCompleteIdentifierIsland and create a TextSpan from it somehow?

@vasily-kirichenko Hmmm... it felt more async-lock-up-the-system than that

however, code is not changed during debugging, so FCS should cache everything and answer very fast. It's strange. I've not able to investigate it today, been trying to build behind the proxy.

@dsyme on a hello world console application debugger works OK for me: it does not show tooltips and it does show proper debug information (current variable values).
On VFT solution it does not work, hanging on this this dialog:

Did you mean this behavior?

@vasily-kirichenko I've noticed that too

If it hangs forever, a dump with heap would really make investigations go a lot faster.

@Pilchie it does not hang forever, sorry for misinformation. The dialog is shown until you move mouse somewhere else, after that VS is responsive until you hover the mouse over another symbol again.

I debugged it and I was wrong: IQuickInfoProvider.GetItemAsync is called in debug mode.

I make IBreakpointResolutionService  no-op and it has not helped:
interface IBreakpointResolutionService with
        member this.ResolveBreakpointAsync(_document: Document, _textSpan: TextSpan, _cancellationToken: CancellationToken): Task<BreakpointResolutionResult> =
            Task.FromResult null

(I mean "Getting datatip text" dialog still hangs)

I also make IQuickInfoProvider  noop, too and it has not helped either:
interface IQuickInfoProvider with
        override this.GetItemAsync(_document: Document, _position: int, _cancellationToken: CancellationToken): Task<QuickInfoItem> =
            Task.FromResult null

Obviously it hangs in ILanguageDebugInfoService.GetDataTipInfoAsync. I added try...with block around it and it did not help.

@vasily-kirichenko COuld you add a new bug with repro steps you are using?  This seems important to fix (even though we're only seeing it in the VisualFSharp.sln right now, I presume it happens on other large solutions)

@dsyme done https://github.com/Microsoft/visualfsharp/issues/1915


Error with godoc -url: "too many redirects" error

What version of Go are you using (go version)?

$ go version
go version go1.13.5 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/williampeake/Library/Caches/go-build"
GOENV="/Users/williampeake/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/williampeake/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/williampeake/Illuscio Dropbox/William Peake/Source_Code/libraries/spantools-go/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/l4/qjtbqs6n1qs_5s9f3rnq804w0000gn/T/go-build257338014=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I am trying to build a static html page for my libraries docs using a third party tool. To do this, I need to use -url pointing to my packages' url.
I ran the following command:
$ godoc -url=localhost:6060/pkg/fmt
NOTE: this is the commad for the fmt package, but yields the same error as my own package

What did you expect to see?
The printed html of the page
What did you see instead?
The following error message
2019/12/21 02:22:49 too many redirects

Nevermind, looks like I just needed to remove the host and port. Thank you.


Secret Value should not be visible to the admin

apiKey resource type currently exposes the secretValue to the admin. This needs to be fixed.

Closed in favor of rancher/rancher#3831


Wrong prefix in pkgconfig files

As a follow up of the previous pkg-confing issue, I've noticed that in the installed pc files the prefix is hardcoded to "/home/qt/work/install" rendering them unusable.
As a workaround I run this sed on Linux and everything builds fine now:
for file in $(ls $Qt5_DIR/lib/pkgconfig/*); do sed -i "s|^prefix=.*|prefix=$Qt5_DIR|" $file; done;
I'm running the job on ubuntu-latest.

I see, thank you

If this is still an ongoing problem, I would really like to handle it at aqtinstall, because it would affect aqtinstall users as well.
Unless I misunderstand the problem though, this is already fixed. Since https://github.com/miurahr/aqtinstall/pull/210, aqtinstall started patching all $Qt5_DIR/lib/pkgconfig/*.pc files, and that code was released in aqtinstall v1.1.0 on Feb 11, 2021.
The current version of the relevant code is here:
https://github.com/miurahr/aqtinstall/blob/179bea9a66204d850284db474ad8f88dcfa47214/aqt/updater.py#L100-L103

Can't say, I've switched to cmake since and it doesn't use the pkg-config files so it's not an issue anymore for me.
You might grep the *.pc files for "/home/qt/work/install" to check if they're still broken though.

On a Mac host:
$ python -m aqt version
INFO    : aqtinstall(aqt) v2.2.2 on Python 3.9.13 [CPython Clang 13.1.6 (clang-13<IP_ADDRESS>)]
$ python -m aqt install-qt mac android 5.15.2 android
... output ...
$ grep prefix="/home/qt/work/install" 5.15.2/android/lib/pkgconfig/* | wc -l
0
$ rm -rf 5.15.2
$ python -m aqt install-qt linux android 5.15.2 android
... output ...
$ grep prefix="/home/qt/work/install" 5.15.2/android/lib/pkgconfig/* | wc -l
210

The pkgconfig/*.pc files are all patched properly for same-platform installations, but not cross-platform installations.

I have closed miurahr/aqtinstall#560 because of this: https://github.com/miurahr/aqtinstall/pull/561#issuecomment-1229087569
Note that if you run the above grep commands on Qt installations installed by aqtinstall and by the official GUI installer, you get the same output. In this regard, the lib/pkgconfig/*.pc files installed by aqtinstall are identical to those installed by the official GUI installer.
I'm certain that this was a problem with aqtinstall at the time this issue was created, but as far as I can tell, it is now fixed. Please feel free to prove me wrong.


Add full URL to Next config to work with Heroku deployment

Fix for this error when deploying to Heroku:
destination does not start with /, http://, or https:// for route {"source":"/api/:path*","destination":"${host}/api/:path*"}

Just realised I can just edit my HOST config var to include "https://www." without having to hard code the change...


Terrain3DStorage: Add get_normal() utility function

Fixes #142

I looked closer at the shader and this is how it's calculated:
get_height(uv + vec2(_region_texel_size, 0));

get_height((vertex.xz + 0.5)/1024 + vec2(1/1024, 0));

That get_height is using 0-1 UV coordinates. Our C++ get_height uses full range values, so if we multiply the above by 1024 we get vertex.xz + 0.5 + vec2(1, 0). However the 0.5 is a texel offset specifically for the shader because of the weird way glsl works, and makes no difference here (I tested it to confirm). So we have this:
	real_t left = get_height(p_global_position + Vector3(-1.0f, 0.0f, 0.0f));
	real_t right = get_height(p_global_position + Vector3(1.0f, 0.0f, 0.0f));
	real_t back = get_height(p_global_position + Vector3(0.f, 0.f, -1.0f));
	real_t front = get_height(p_global_position + Vector3(0.f, 0.f, 1.0f));

I then tested this by adding an MMI to DemoScene._ready()
	var mmi := MultiMeshInstance3D.new()
	mmi.multimesh = MultiMesh.new()
	mmi.multimesh.transform_format = MultiMesh.TRANSFORM_3D
	mmi.multimesh.instance_count = 1024*1024
	mmi.multimesh.mesh = BoxMesh.new()
	mmi.multimesh.mesh.size = Vector3(.1, 1, .1)
	add_child(mmi)

	for x in 1024:
		for z in 1024:
			var xform := Transform3D()
			xform.origin = Vector3(x, 0, z)
			xform.origin.y = $Terrain3D.storage.get_height(xform.origin)
			var normal: Vector3 = $Terrain3D.storage.get_normal(xform.origin)
			xform.basis.y = normal
			xform.basis.x = -xform.basis.z.cross(normal)
			xform.basis = xform.basis.orthonormalized()
			mmi.multimesh.set_instance_transform(z*1024 + x, xform)

It looks pretty good.


Validate impurity and that no storage opcodes are generated in a pure context

I am finally really close to having a PR for this, but I have hit a minor related snag.  We already have checks in the compiler to disallow storage operations in non-contracts (and now the storage declarations too) but that includes libraries.
If a contract includes a library which does storage then that's OK, but if a script includes that library, no... right?  This is not possible to check in the current framework, we may be compiling a library and we have no idea who is going to use it later.
I want to just allow storage ops in libraries for now, and maybe we can create an issue to add internal purity attributes to libraries as we're compiling them, so that then if they're used in a script we can barf.  Is this fair?

OK, either way, the problem now is that if we put storage ops in a library they'll be blocked by an error.
error
  --> /usr/home/toby/prj/sway/sway-lib-std/src/storage.sw:8:8
   |
 6 |
 7 | #[storage(write)]
 8 | pub fn store<T>(key: b256, value: T) {
   |        ^^^^^ Impure function inside of non-contract. Contract storage is only accessible from contracts.
 9 |     if !__is_reference_type::<T>() {
10 |         // If copy type, then it's a single word and can be stored with a single SWW.
   |

So if a contract, which is allowed storage ops, includes this library it'll still fail.  We need to be able to tell what sort of program is including the library before we throw the failure.
So I'm temporarily enabling storage ops in libraries and suggesting we add a new issue to resolve it properly.

@adlerjohn you also opened https://github.com/FuelLabs/sway/issues/963 recently. Is there a place where we can look up the desired behavior of each VM instruction depending on its context (i.e. internal v.s. external)? Not every contract instruction has to be forbidden in scripts (like block height as you said).

I've mentioned this in the PR https://github.com/FuelLabs/sway/pull/1716#issuecomment-1151616089 but yeah, at the moment, while everything is inlined, it's hard/impossible to know whether a function is in a library or contract or just a local script.  We could tag them as such before inlining, which wouldn't be that hard I imagine.

Is there a place where we can look up the desired behavior of each VM instruction depending on its context (i.e. internal v.s. external)?

Yes, the specs 😂. Jokes aside, I think the only instructions forbidden to scripts are direct state read/write and mint/burn. This potentially warrants further separation of instructions into pure/non-pure/contract methinks.


[book] gobject-memory-management chapter unnecessarily uses a weak reference for number

As discussed, should also generally review usage of weak references.


Introduce jvm-engine buildpack

The existing heroku/jvm buildpack both provides and requires itself unconditionally. That means if you put heroku/jvm in a build order it will always run even if it is specified as optional.
What does that mean? Most build packs will always provide a resource (like "ruby") but only require it if it has a positive signal (such as presence of a Gemfile on disk). The JVM buildpack is different because the JVM ecosystem can be used with wildly different JVM applications, many of them do not have a single file that would indicate it needs the JDK. To support this set of various use cases it always installs the JVM.
This always-install behavior is a problem for the Ruby buildpack due to JRuby support. JRuby is provided by the same buildpack as Ruby the only difference is that it needs the JVM installed (and it downloads a jruby binary from S3). To install the JVM the heroku/ruby builder has heroku/jvm specified as an optional dependency. Due to existing behavior that means the JVM is installed for ALL ruby applications even if is not using the JVM. This eats up disk space and takes up build time.
There are possible fixes:

A: Introduce an only-provide buildpack and change the existing heroku/jvm buildpack to be a no-op that always requires the other buildpack. Then the heroku/ruby (and any other build packs) can optionally depend on the JVM through the regular require interface.
B: Introduce a new JRuby buildpack that fails to detect if jruby is not detected (via inspecting the Gemfile.lock). Use this to make a new group along with the heroku/jvm and place that group above the existing heroku/ruby group. Remove the heroku/jvm group from the heroku/ruby group. This would have the effect of only installing the JVM for JRuby apps.
C: Edit: Only require jvm when a valid file is matched on disk (https://github.com/heroku/buildpacks-jvm/pull/541)
D: Some other option

This PR implements option A. It moves the existing logic to a heroku/jvm-engine buildpack and removes its require. Then the heroku/jvm buildpack is stripped of all logic and all it does is require the jvm provided by the heroku/jvm-engine.
The upside of this approach is that any buildpack can use the heroku-jvm-engine much like the heroku-nodejs-engine to install the JVM optionally. As long as the existing heroku/jvm builder is updated with both build packs then this should be a non-breaking change save if someone was using the heroku/jvm buildpack directly (not through the builder), they'll now need to also add the heroku/jvm-engine buildpack as well.
Other thoughts
This interface is really funky. It's a very-round about way of expressing what should be a seemingly common use case. Having the builder separated from the buildpack and provide/require be based on a string instead of a specific resource leads to very difficult to reason about resolution logic.
Another option (but it won't meet our timescale) could be a change to the builder spec: For instance we could expose the optional flag to a buildpack in the detect phase to let a buildpack know if it is being treated as optional or not and change its behavior accordingly.
Longer term it's worth experimenting with alternative interfaces that we could build on top of these three primitives (builder, buildpack, provide/require build plans). I've proposed a theoretical middleware like interface (Rack middleware would be my design inspiration as I come from Ruby) but I've not sketched up any kind of implementation ideas.

C: Some other option

Another option would be to not add another buildpack, but instead:

Change the heroku/jvm buildpack so it only requires itself if some Java-related files are found
Make the heroku/java buildpack and other Java-related buildpacks explicitly require the JVM (just in case no Java related files are found in the project)
Make the Ruby buildpack conditionally require the JVM if the Ruby project is found to be a JRuby project

The only disadvantage of this approach would be that anyone using heroku/jvm directly (and not via heroku/java etc) would need to ensure they have a known Java-related files in their app source, or heroku/jvm would no longer pass detection.
However, to me this still seems preferable to creating an empty buildpack just for the sake of requires/provides.

Change the heroku/jvm buildpack so it only requires itself if some Java-related files are found

Manuel had this to say before "There is no "Java package manager" like there is for other languages. Many Java customers also install the JVM standalone without using any package manager. The last point is actually the main reason for requiring itself: sometimes it's the only thing a customer wants, there is no other buildpack that could ever require it."
To that end, one of the ways I think about usability is the number of steps something takes. I.e. declaring "use heroku/jvm as a buildpack" is one step and so is setting an env var or writing a file to disk. Another option could be:

Introduce a pseudo standard for declaring your app needs/wants the JVM

This is somewhat similar to the history of Procfile, and we also have app.json (maybe that could be utilized?) I would ideally propose something that gets checked in with the repo. Possibly just an empty system.properties file. Then we could have the jvm buildpack execute for every build group optionally, much like nodejs.

Make the Ruby buildpack conditionally require the JVM if the Ruby project is found to be a JRuby project

I don't think that's possible without a second builder. It's what we're doing today:

https://github.com/heroku/builder/blob/ec92d59f464e1e2e32638e9808c3c767ea1022bd/builder-22/builder.toml#L69-L72
https://github.com/heroku/buildpacks-ruby/blob/2022e5d2fea4acb3d082e121d95b99f8382da85e/buildpacks/ruby/src/main.rs#L52-L54

I intend(ed) to make a second PR to the Ruby buildpack to explore what it looks like to have a jruby-detect (or similar buildpack) that could be used to generate a second grouping that is non-optional. Something like this:
[[order]]
  [[order.group]] # Proposed jruby buildpack ordering
    id = "heroku/nodejs-engine"
    version = "0.8.24"
    optional = true
  [[order.group]]
    id = "heroku/nodejs-yarn"
    version = "0.4.4"
    optional = true
  [[order.group]]
    id = "heroku/jvm"
    version = "1.0.10"
    optional = true
  [[order.group]] # Fails if does not detect jruby in order
    id = "heroku/jruby-detect"
    version = "2.0.0"
  [[order.group]]
    id = "heroku/ruby"
    version = "2.0.0"
  [[order.group]]
    id = "heroku/procfile"
    version = "2.0.0"
    optional = true
  [[order.group]] # Current heroku/ruby buildpack minus the JVM buildpack
    id = "heroku/nodejs-engine"
    version = "0.8.24"
    optional = true
  [[order.group]]
    id = "heroku/nodejs-yarn"
    version = "0.4.4"
    optional = true
  [[order.group]]
    id = "heroku/ruby"
    version = "2.0.0"
  [[order.group]]
    id = "heroku/procfile"
    version = "2.0.0"
    optional = true

[[order]] # Current buildpack grouping without jvm
  [[order.group]]
    id = "heroku/nodejs-engine"
    version = "1.1.0"
    optional = true
  [[order.group]]
    id = "heroku/nodejs-yarn"
    version = "1.1.0"
    optional = true
  [[order.group]]
    id = "heroku/ruby"
    version = "2.0.0"
  [[order.group]]
    id = "heroku/procfile"
    version = "2.0.0"
    optional = true

Though now that I'm thinking of implementation, I see a failure mode:

If the JRuby group fails detection (due to some bug) then it would still pass detection for the regular ruby group, but the JVM wouldn't be installed yet. I guess that's not technically any different than what I've got today and I'm not doing anything to improve that failure mode. So while that behavior might be surprising, it's not worse than what we've got today.

Manuel had this to say before "There is no "Java package manager" like there is for other languages. Many Java customers also install the JVM standalone without using any package manager. The last point is actually the main reason for requiring itself: sometimes it's the only thing a customer wants, there is no other buildpack that could ever require it."

Yeah I wasn't meaning check for a package manager, but instead for say the presence of .jar files in the app source, or say a system.properties file (given that specifying an explicit JVM version should really be best practice, so if someone wants to run a JVM without a package manager, then it seems reasonable to say they have to have a system.properties file perhaps, if the .jar file idea isn't viable etc?).

Here's a spike on that idea @edmorley https://github.com/heroku/buildpacks-jvm/pull/541

Apart from issue I see with the engine naming, I think we should invert this and create an explicit jvm-standalone buildpack that users can opt-in to if they need the JVM for any reason when it's not required by another buildpack. This keeps things simple both for us implementation wise and the user.
I have the required changes locally already and will open a PR soon that implements ☝🏻. This should unblock @schneems' use-case with the Ruby buildpack.
I'm closing this in favor of the strategy I outlined before. Feel free to re-open if you disagree.

Linking PRs https://github.com/heroku/buildpacks-jvm/pull/545


one form item multiple controls bug

Reproduction link
https://stackblitz.com/
Steps to reproduce
I couldn't reproduce it in stackblitz (version diff?).
in html:
<form nz-form [formGroup]="Form">
      <nz-form-item>
        <nz-form-label nzSpan="6" nzFor="Name" nzRequired>Name</nz-form-label>
        <nz-form-control nzErrorTip="Name is mandatory!" nzSpan="7">
          <input nz-input id="Name" formControlName="Name"/>
        </nz-form-control>
        <nz-form-label nzSpan="4" nzFor="Family" nzRequired>Family</nz-form-label>
        <nz-form-control nzErrorTip="Family is mandatory" nzSpan="7">
          <input  nz-input id="Family" formControlName="Family"/>
        </nz-form-control>
      </nz-form-item>
</form>

in .ts:
Form:FormGroup = this.fb.group({
    Name: [null, Validators.required],
    Family: [null, Validators.required]
  })

What is expected?
Each control validates its own input.
What is actually happening?
If one control (input) has an error. Both are 'invalid'.

Environment
Info

ng-zorro-antd
11.4.1

Browser
Chrome, any

The status of nz-form-item is controlled by its subcomponent nz-form-control, so there should be only one nz-form-control component in an nz-form-item.
If you need multiple form elements in a row:

You can consider using inline layout, refer to: https://ng.ant.design/components/form/zh#components-form-demo-horizontal-login
Or you can use grid components, refer to: https://ng.ant.design/components/form/zh#components-form-demo-advanced-search

re #6439


MX Priority and Other Improvements

Changes

Support setting priority in MX type records
Add validation for required record proporties
Handle testing and no-change results in the saltstack preferred way
Small refactor for code reuse

@cloudflare, bump. Please review & merge. Current master is broken and need this change.


Refactor sample catalog screenshot production

The (Java) code used to save screenshots has been flaky on Linux. Refactored the code so that screenshot production can run on (just) MacOS.
Also:

The screenshot uploader is no longer a separate process.
... no longer tries to reuse an HTTP client after a timeout.
... logs the files that it has saved.

@yjbanov


Plex mark devices unavailable if they 'vanish' and clear media

Partial Fix for:
https://github.com/home-assistant/home-assistant/issues/10074
if a client vanishes it will persist in UI however it is marked Unavailable and media images are cleared

Did you see self._is_player_available? What's the difference?

Removing all my code and using player available results in player IDLE not unavailable

@syssi leaving _player_available till next cleanup (i've to add code to remove unavailable clients and update api to 3.0.6). But Have added prev comments
@balloob Can this make 0.65?


hello. i made an update to provide some generic discovery of TEMPerX probes if you would like to update

hello your code really helped me. i could not get this working on windows through the GUI because it only allowed a single device to be polled at a time. after research i found your library. thank you
i have made some small adjustments to it that allows it to be more dynamic for discovery of TEMPerX probe devices when loading temperatures.
you can see the following changes. these all have defaults so will be backward compatible with previous version:

*make class public (this is not needed, just for my use)
add device filter criteria to TemperWindows constructor
add get_temper_devices method with device filter criteria and fallback to all TEMPer devices if none are provided

this can be made private if you like

add device filter criteria to get_temperature method as an override to the TemperWindows instance fields

if you would like please include this in your codebase for release. if not i understand and will use my local version.
thank you again for your help.
"""
Windows USB direct access to TEMPerX probes

adapted from: https://github.com/tom-churchill/temper-windows

Original Author: Tom Churchill
Original License: MIT
"""

import time
import pywinusb.hid as hid

# all TEMPerX devices begin with this prefix
# magic string used as a fallback to load all devices if no HID filter criteria are provided
TEMPer_DEVICE_PREFIX = "TEMPer"

class TemperWindows:
    def __init__(self, product_name = None, vendor_id = None, product_id = None):
        self.read_data = None
        self.read_data_received = False

        self.product_name = product_name
        self.vendor_id = vendor_id
        self.product_id = product_id

    def raw_data_handler(self, data):
        self.read_data = data
        self.read_data_received = True

    @staticmethod
    def convert_data_to_temperature(data):
        return float(data[3] * 256 + data[4]) / 100

    def get_temper_devices(self, product_name = None, vendor_id = None, product_id = None):
        filter_dict = dict()

        if product_name or self.product_name:
            filter_dict = dict(product_name=(
                product_name or self.product_name))
        if vendor_id or self.vendor_id:
            filter_dict = dict(
                **filter_dict, vendor_id=(vendor_id or self.vendor_id))
        if product_id or self.product_id:
            filter_dict = dict(
                **filter_dict, product_id=(product_id or self.product_id))

        if filter_dict:
            return hid.HidDeviceFilter(**filter_dict).get_devices()

        return [dev for dev in hid.find_all_hid_devices() if TEMPer_DEVICE_PREFIX in dev.product_name]

    def get_temperature(self, thermometer_index: int = 0, product_name = None, vendor_id = None, product_id = None):
        self.read_data = None
        self.read_data_received = False

        devices = self.get_temper_devices(
            product_name=product_name, vendor_id=vendor_id, product_id=product_id)

        if thermometer_index > len(devices) - 1:
            return None

        device = devices[thermometer_index]

        try:
            device.open()
            device.set_raw_data_handler(self.raw_data_handler)

            write_data = [0x00, 0x01, 0x80, 0x33, 0x01, 0x00, 0x00, 0x00, 0x00]

            # reset read_data_received before sending our data
            self.read_data_received = False

            device.send_output_report(write_data)

            # wait for read data to be received
            # 0.01 to start with to avoid an unnecessary long wait for the majority of time
            sleep_amount = 0.01
            while self.read_data_received is False:
                time.sleep(sleep_amount)
                sleep_amount = 0.05  # 0.05 after to avoid causing high cpu

            # noinspection PyTypeChecker
            return self.convert_data_to_temperature(self.read_data)
        finally:
            device.close()

@tom-churchill actually i think this will not work because the write_data is to be specific to each device.
may i ask how you discovered what write_data to send to the device you wrote the program for? i am trying to use for TEMPer2 probes with vendor 0x1a86 and product 0xe025
write_data = [0x00, 0x01, 0x80, 0x33, 0x01, 0x00, 0x00, 0x00, 0x00]

update: i have sorted out. this was indeed the correct write data to send to the any TEMPer USB device. however, the issue had to do with my probe having 2 temperature sensors inside.
i have refactored the code to handle both single and multiple sensor readings. it is backwards compatible by making it an option to load both with default of False
this was a tough problem to solve. i had to find a "USB analyzer" tool to view the data packets and work out what was happening with the GUI program compared to the TemperWindows program.
i used this one freeusbanalyzer from HDD Software. i do not know this software so ran it through virus scan and it came clean for the exe download on 12/01/23. i did enable the free trial to use the "HID report" view which helped.
you can see here the HID report

from TEMPer v26 GUI

from TemperWindows

thank you again for your guidance. i did not know any of this before. hope this helps you or others.
"""
Windows USB direct access to TEMPerX probes

adapted from: https://github.com/tom-churchill/temper-windows

Original Author: Tom Churchill
Original License: MIT
"""

import time
import pywinusb.hid as hid

# all TEMPerX devices begin with this prefix
# magic string used as a fallback to load all devices if no HID filter criteria are provided
__TEMPer_DEVICE_PREFIX = "TEMPer"

# this is the "USB device output report data" used to trigger a temperature data response from the device
# determined by using FreeUsbAnalyzer (a USB traffic analyzer tool from HDD Software)
# https://freeusbanalyzer.com/
# virus scan as of 12/01/23: https://www.virustotal.com/gui/file/3bc7f717f1c83778786fca09b8f50b886596c1e86813be9fb50aa507a26ace4d
__TEMPer_DEVICE_TEMPERATURE_OUTPUT_REPORT_DATA = [
    0x00, 0x01, 0x80, 0x33, 0x01, 0x00, 0x00, 0x00, 0x00]

class HidDeviceReader:
    def __init__(self, device, timeout_seconds=0.1) -> None:
        self.device = device
        self.read_data = []
        self.timeout_seconds = timeout_seconds

    def __raw_data_handler(self, data):
        self.read_data = [*self.read_data, data]

    def load_data(self, output_report_data=[]):
        self.device: hid.HidDevice

        assert (self.device.is_plugged(
        ) and self.device.is_active), f"Inactive device {self.device} cannot be opened"

        try:
            if not self.device.is_opened():
                self.device.open()

            self.device.set_raw_data_handler(self.__raw_data_handler)
            self.device.send_output_report(output_report_data)

            load_time = 0
            sleep_time = 0.01
            while load_time <= self.timeout_seconds:
                time.sleep(sleep_time)
                load_time += sleep_time
                # progressively increase
                sleep_time += (2 * sleep_time)
        finally:
            self.device.set_raw_data_handler(None)
            self.device.close()

        return self.read_data

class TemperWindows:
    def __init__(self, product_name=None, vendor_id=None, product_id=None):
        self.product_name = product_name
        self.vendor_id = vendor_id
        self.product_id = product_id

    @staticmethod
    def convert_data_to_temperature(data):
        if not data:
            return None

        return float(data[3] * 256 + data[4]) / 100

    def get_active_temper_devices(self, product_name=None, vendor_id=None, product_id=None):
        filter_dict = dict()

        if product_name or self.product_name:
            filter_dict = dict(product_name=(
                product_name or self.product_name))
        if vendor_id or self.vendor_id:
            filter_dict = dict(
                **filter_dict, vendor_id=(vendor_id or self.vendor_id))
        if product_id or self.product_id:
            filter_dict = dict(
                **filter_dict, product_id=(product_id or self.product_id))

        if filter_dict:
            return hid.HidDeviceFilter(**filter_dict).get_devices()

        return [dev for dev in hid.find_all_hid_devices() if __TEMPer_DEVICE_PREFIX in dev.product_name]

    def get_temperature(self, temp_probe_device_index: int = 0, with_outer_temp=False, product_name=None, vendor_id=None, product_id=None):
        self.read_data_inner = None
        self.read_data_received = False

        devices = self.get_active_temper_devices(
            product_name=product_name, vendor_id=vendor_id, product_id=product_id)

        if temp_probe_device_index > len(devices) - 1:
            return None

        device = devices[temp_probe_device_index]

        device_reader = HidDeviceReader(device, timeout_seconds=0.1)
        temp_data = device_reader.load_data(
            __TEMPer_DEVICE_TEMPERATURE_OUTPUT_REPORT_DATA)

        inner_temp_c = self.convert_data_to_temperature(temp_data[0])
        outer_temp_c = self.convert_data_to_temperature(temp_data[1])

        return (inner_temp_c, outer_temp_c) if with_outer_temp else inner_temp_c