Inconsistent behaviour of GlobalMaxPooling2D Layer

[ ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[ ] Check that your version of TensorFlow is up-to-date. The installation instructions can be found here.

[x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

The Problem is that GlobalMaxpooling2D returns different values depending on the previous layer beeing one of the outputs or not. My guess is it ignores the activation function of the previous layer.
I find the problem kind of hard to explain but i think the following simple example will show what i mean:
from tensorflow import keras
import numpy as np

input = keras.layers.Input(shape=(1, 1, 1))
conv = keras.layers.Conv2D(1, (1, 1), activation="sigmoid", kernel_initializer=keras.initializers.constant(2))(input)
max = keras.layers.GlobalMaxPool2D()(conv)

model = keras.models.Model(
    inputs=input,
    outputs=[conv, max],
)

p = model.predict(
    np.ones((1, 1, 1, 1))
)
print(p)

This prints:

[array([[[[0.880797]]]], dtype=float32),
array([[0.880797]], dtype=float32)]

Important is to note that the value of the max output is roughly equal to 0.87 which is in between 0 and 1 as expected to be because of the previous sigmoid activation.
If i change the output of the model to be just the output of the GlobalMaxPool2D layer like shown here:
model = keras.models.Model(
    inputs=input,
    outputs=[max],
)

the output changes to

[[2.]]

which is not equal to the expected 0.87 and not even in the range [0,1] which is expected to be returned by the sigmoid activation of the conv2D layer.
It seems to me like the sigmoid activation of the previous Conv2D layer is ignored.

It seems like a TensorFlow bug to me. Or maybe there was a breaking change in TF?


Adding webjobs-list.json to project causes problems with resx resources in /t:package mode

Brief description
MSBuild doesn’t seem to work properly for web application with both: external resource project and WebJob list. Language folders in ./bin directory are missing.
Use case
Within a project I have couple web applications. Each of them is available in multiple languages. Since most of strings are used in multiple web apps, I decided to create a separate project with resx resource files only. One of these web applications utilizes WebJobs to perform some background tasks. WebJobs are build and deployed along with this web app thanks to webjobs-list.json mechanism.
To deploy the application to Azure, I would like to build an artifact using MSBuild.exe with /t:package parameter.
Steps to reproduce

Create new .NET Framework web application
Create new project with resource files in multiple languages
Create new WebJob project (console app)
Create a reference in web app to resource project and Microsoft.Web.WebJobs.Publish 2.0.0
-- at this point MSBuild correctly creates language folders in ./bin directory
Add webjobs-list.json to Properties of web application
Run MSBuild.exe with /t:package (the problem doesn’t occur when I run MSBuild.exe without /t:package parameter)

Expected  behavior
MSBuild  should create language folders in ./bin directory.
Actual behavior
Language folders in ./bin directory are missing.
Deleting webjobs-list.json and re-running MSBuild fixes the language folder problem, but then WebJob is not attached to web app.
Environment data
msbuild /version output: <IP_ADDRESS>856 (I tested on <IP_ADDRESS>996 as well)
Visual Studio builds and deploys the web application properly.
Sample project
Below you can find sample project to reproduce the issue. Language folders in ./bin directory are created properly until you add webjobs-list.json (included in .zip) to ./WebApplication/Properties.
WebApplication.zip
Script I use to build an artifact:
MSBuild.exe ".\WebApplication\WebApplication.csproj" /p:OutputPath="./Publish/" /p:Configuration=Release;platform="Any CPU" /v:m /m /nr:false /p:RunCodeAnalysis=False

@mlorbetske do you know of a good contact to look at this? Since it fails only when /t:Publish is run my first guess is that it's not a problem with core MSBuild but in Microsoft.Web.Publishing.targets.

@vijayrkn would probably know best

@rainersigwald @vijayrkn Any updates on this issue?


Fix Color Picker: Saving text background color saves text color instead

Context

Currently, when you click a text element's background color and try to save the background color to the local or global palettes, the element's text color is saved instead.
Summary

I am making use of the changedStyle prop in the ColorPicker component which is currently used for implementing changes in the element's attributes, to detect from which attribute the color picker was triggered from and save the correct color / background color accordingly.
Relevant Technical Choices

To-do

User-facing changes

Before
After

Testing Instructions

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Insert text element
Change bg color
Try to save bg color
make sure the correct color is added to both the local and global colors.
Make sure saving the text color also works correctly.

Reviews
Does this PR have a security-related impact?

No
Does this PR change what data or activity we track or use?

No
Does this PR have a legal-related impact?

No
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[ ] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #9891

@Trapsta Forgot to add that we should also add a new Karma test for it.


Watch youtube video with serverless-chrome

It's a question.
Can I watch maybe 10 seconds of youtube video loaded with screenshot,js? Youtube page with video loads fine, but screenshot always returns initial frame with 0:00 timing. If I add
await sleep(10000)
const screenshot = await Page.captureScreenshot({ format: 'png' })
nothing changes, it's still 0:00, but the function is obviously waiting, it's visible in AWS log timing.

The same idea works perfect locally. Delay really pushes video to 0:05. Maybe chromes are not the same? I use ordinary Chrome 61 in headless mode on local machine.


failed to run custom build command for `sppark v0.1.5'

error occurred: Command "nvcc" "-ccbin=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\cl.exe" "-Xcompiler" "-nologo" "-Xcompiler" "-MD" "-G" "-Xcompiler" "-Z7" "-Xcompiler" "-Brepro" "-I" "D:\hash\aleo\sppark-0.1.5" "-Xcompiler" "-W4" "-o" "D:\hash\aleo\sppark-0.1.5\rust\target\debug\build\sppark-9d1ea8dff2ab2e4d\out\src/lib.o" "-c" "src/lib.cpp" with args "nvcc" did not execute successfully (status code exit code: 2).
windows10 ,nvcc=12.3，gcc = 13.2, rustc = 1.75.0  gpu= rtx4060,

Formally speaking the description is incomplete to act upon. It's not generally sufficient to say "nvcc did not execute successfully," you have to provide error messages... However! In this particular case it's actually known fact that sppark doesn't work on Windows, so even if error messages were provided, the answer would still be the same, "yeah, it doesn't work." While Windows is not actually supported, the tip of the repository can be compiled on Windows. So if you want to help, test that and report back, an additional data point would be appreciated. Though it's important to set the expectations right. For example, you mention gcc, but nvcc doesn't support gcc on Windows, only Visual C... So what's up with you mentioning gcc? Well, it's a question for you to ask yourself...
On related note, it's actually known that CUDA and sppark work under WSL, Windows Subsystem for Linux, version 2, so consider even this as alternative.


Improve text scan operator

This PR updates the TextScanOperator to improve its performance.
There are three main changes:
(1) Pass text_offset and text_segment_size as parameters to each TextScanWorkOrder instead of really loading the data. Then each TextScanWorkOrder reads the corresponding piece of data directly from disk.
(2) Avoid extra string copying by passing const char ** buffer pointers into parseRow() and extractFieldString().
(3) Use ColumnVectorsValueAccessor as the temporary container to store the parsed tuples. Then call output_destination_->bulkInsertTuples() to bulk insert the tuples.
Note 1: This updated version follows the semantics of the old TextScanOperator except that it does not support the backslash + newline escaping, e.g.
(a)
aaaa\
bbbb

which is semantically equivalent to
(b)
aaaa\nbbbb

The updated version supports (b) but not (a). As (a) incurs extra logic that complicates code. Meanwhile, format (a) seems to be specific to PostgreSQL, and the documentation of PostgreSQL 9.6 says:
It is strongly recommended that applications generating COPY data convert data newlines and carriage returns to the \n and \r sequences respectively. At present it is possible to represent a data carriage return by a backslash and carriage return, and to represent a data newline by a backslash and newline. However, these representations might not be accepted in future releases. They are also highly vulnerable to corruption if the COPY file is transferred across different machines (for example, from Unix to Windows or vice versa).
Note 2: This PR relies on the fix from #18 to work correctly for loading TYPE compressed_columnstore tables.
Note 3: Using 40 workers, the expected loading time on cloudlab machines with current SQL-benchmark settings are ~465s for SSB SF100 and ~1050s for TPCH SF100 (*.tbl files on slowdisk).

@jianqiao This is fantastic! This is going to making a huge difference when loading large datasets. LGTM. As a perspective loading SSB used to take about 2800 seconds. Huge 6X improvement!
Merging.

From experiments this is the best size for both slowdisk and fastdisk on the cloudlab machines. The observation is that slowdisk loading favors smaller (256K) segment size and fastdisk loading favors larger (1M~4M, but 256K is okay) segment size. I haven't dived into the underlying details though.

@zuyu -- I think it is perfectly fine for you go clean it up and open a new PR.


loadingメッセージで最後の一つがずっとloading中になる

loaded: summary, mahjong, emoji-notifier, sushi-bot, shogi, tiobot, checkin, channel-notifier, prime, dajare, ahokusa, ricochet-robots, scrapbox, wordhero, wordhero/crossword, voiperrobot, lyrics, better-custom-response, anime, anime/anison, taiko, hayaoshi, hitandblow, api, hangman, hakatashi-visor, oauth, tunnel, emoxpand, oogiri, tsglive, context-free, amongyou, nojoin, mail-hook, twitter-dm-notifier, room-gacha, pocky, atcoder, discord, welcome, octas, emoji-modifier, sunrise, slack-log, ponpe, sorting-riddles, pwnyaa, achievements, deploy
loading: tahoiya

maybe useful log for @kom-bu
Jun 25 22:24:35 localhost node/home/slackbot/slackbot/index.ts  {"message":"plugin \"deploy\" successfully loaded","level":"info","timestamp":"2021-06-25T13:24:35.646Z"}
Jun 25 22:24:35 localhost node/home/slackbot/slackbot/index.ts  {"message":"Server launched at http://<IP_ADDRESS>:21864","level":"info","timestamp":"2021-06-25T13:24:35.661Z"}
Jun 25 22:24:36 localhost node/home/slackbot/slackbot/index.ts  {"message":"plugin \"tahoiya\" successfully loaded","level":"info","timestamp":"2021-06-25T13:24:36.028Z"}

上のマージの後ロードがうまくいかなくなり、 https://github.com/tsg-ut/slackbot/commit/e17d671e6afd9c05a8e7ce262676e6cf39cf077d によって直りました。


ssl_cert and ssl_key are required

The code below requires ssl_cert and ssl_key to be defined. But I have an include file that defines those instead :( Any way around this?
# Check to see if SSL Certificates are properly defined.
  if ($ssl == true) {
    if ($ssl_cert == undef) or ($ssl_key == undef) {
      fail('nginx: SSL certificate/key (ssl_cert/ssl_key) and/or SSL Private must be defined and exist on the target system(s)')
    }
  }

Also, I think the ability not to specify the ciphers would be nice.

Hmm... we could downgrade to a warning or info message instead of a hard fail.
Just wondering why the include file instead of using these parameters? I'm not blocking this just yet, but I want to understand the use case before changing the existing behaviour which is useful for 99% of our users. Warnings or info messages are more easily missed.

#945 now allows keys to have an empty value if set to undef. This has been merged in the most recent release (0.5.0), and should resolve your issue.

Awesome, thank you!


Explorer: copy symlink instead of target when doing copy/paste operations

VSCode Version: 1.27.2
OS Version: MacOS 10.14

Steps to Reproduce:

In Explorer. Right click on symlink/ copy
On any folder right click/ paste

Does this issue occur when all extensions are disabled?: Yes

@isidorn I think my change would not make a difference for this case. I am not sure what to do here best, we could detect if the thing that is selected is a link and then copy the link, but that might confuse people that expect the opposite to happen...

@bpasero yeah it is a bit leaning towards user preference. No action for now and let's wait for more feedback and we might introduce an option in the future.

@isidorn I think my change would not make a difference for this case. I am not sure what to do here best, we could detect if the thing that is selected is a link and then copy the link, but that might confuse people that expect the opposite to happen...

Hello, Thank You for the fast reaction.
I have my doubt that majory of people expect that coping symlink they will get whole folder been copied.
It's better look at OS behavior.

Finder copies just symlink

Terminal
cp Downloads temp/
cp: Downloads is a directory (not copied).
but
cp -R Downloads temp/
copied just symlink

BR.

This feature would support our workflow that uses symlinks to shared components. +1

User preference would be great.
Seeing as though symlink status is shown in the explorer, it would at least be obvious to the user what has been copied.
+1

Same issue here on Linux. For folders, I don't know. For files, I think it's reasonable to copy file content, not to point to original target. At least, a message should be emitted to inform what's happening.


add get_all_windows example

As the author of #143 I was just preparing to close it because after reading some more info online I realised I misunderstood the API :sweat_smile:


Feature/lw 8343 posthog start session event

NB!!! This is a Draft PR, because of dependencies on PR (https://github.com/input-output-hk/lace/pull/537)
Checklist

[x] JIRA - https://input-output.atlassian.net/browse/LW-8343 <link>
[x] Proper tests implemented
[ ] Screenshots added.

Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes

Allure report
allure-report-publisher generated test report!

smokeTests: ❌ test report for 6a7c98eb

passed
failed
skipped
flaky
total
result

Total
28
4
0
0
32
❌

@tommayeliog there are merge conflicts in this PR and please edit the PR description to remove any template text + add at least one sentence of description 🙏


core: improve signal handling

This PR tries to handle SIGUSR1, SIGUSR2 and termination signals via the main thread using signalfd.
I did that cause when we forceUpdateTimers, we are currently not safe in multiple ways.
We don't acquire the timers lock for m_vTimers, which we can't do cause we are in a async signal context.
We call other async signal unsafe functions.
So I tried moving forceUpdateTimers to the main thread (#536), but that has the problem that we need to wake the main thread somehow and that would require async signal unsafe functions again.
Considering hyprlock is event driven using signalfd made sense.
I hope that this fixes #535.
Some testing wanted before merging.
Thanks!

Needs a bit more work


Binary Package for MAC

I am finding it difficult to setup and run this on MAC OSX EL CAPITON

API Umbrella is currently only compatible with Linux. What purpose were you looking to run API Umbrella on your Mac for? Would it be to just try it out/demo it, or would it be for development purposes, or would the Mac your server?
There are a few virtualized options to run it on your Mac, though:

Create a Linux virtual machine, and install one of the Linux binaries into the virtual machine.

Similarly, we provide a Vagrant development environment that uses a Linux virtual machine environment, but is geared towards API Umbrella development.

If you run Docker on your Mac, then you can also run API Umbrella via Docker.

If you were looking for a non-virtualized option for the Mac, then we don't currently support that. I believe it should technically be possible, it's just that we have a variety of things in our build process that are currently hard-coded for the assumption we're running under Linux. So those build assumptions would need to be updated to account for building on the Mac. We don't have any plans to make those changes ourselves, but we'd welcome any pull requests that added direct Mac compatibility to the build process.


ReactJS: Cannot read property 'componentWillUpdate' of null

Current behavior
When using the latest version of ReactJS and GoldenLayout, an error occurs in the console which is the following:
Uncaught TypeError: Cannot read property 'componentWillUpdate' of null at ./node_modules/golden-layout/dist/goldenlayout.js.lm.utils.ReactComponentHandler._render
Expected behavior:
The error should not appear when using the example code supplied in the getting started section.
Codepen example:

Any update on this issue? Am also getting this error.

FYI fix is here https://github.com/deepstreamIO/golden-layout/pull/348

Closing in favor of #348


Use test queue for prod tests

Purpose

No ticket is linked to this PR.

Changes

No changes.

Review Instructions

No instructions.

@ehigham just reminded me that this queue is meant to be temporary while we're figuring out this hand-off with hOps. So I'm going to close this PR!

@ehigham just reminded me that this queue is meant to be temporary while we're figuring out this hand-off with hOps. So I'm going to close this PR!

Oh, I see. Thanks for the clarification, I'm confused by the switch between the queues. 🤕


Free Music Archive service

Added support for Free Music Archive API service

Coverage decreased (-0.2%) to 92.593% when pulling 242c63fa89beb81fc546cf41b0cc008ef3b32cf5 on fma-service into 5a91313ea6bd8db625625a1480ecc12da4a5a544 on master.

Coverage decreased (-0.2%) to 92.593% when pulling 242c63fa89beb81fc546cf41b0cc008ef3b32cf5 on fma-service into 5a91313ea6bd8db625625a1480ecc12da4a5a544 on master.


fix: typo

Thanks for you contribution.
But DCO check is failed. Clould you fix it?: https://github.com/fluent/fluentd-kubernetes-daemonset/pull/587/checks?check_run_id=3027102568

Thanks!


[FEATURE] v2 data engine supports ublk frontend protocol

Is your feature request related to a problem? Please describe (👍 if you like this request)
The Longhorn v2 data engine exposes a RAID block device to a block device using the NVMe-TCP protocol. However, IOPS and bandwidth are negatively impacted due to CPU contention among multiple NVMe layers in the current architecture.
Describe the solution you'd like
To mitigate the performance drop, v2 data engine can support the ublk frontend protocol, which reduces the overhead caused by the NVMe over Fabrics (NVMf) network protocol.
Describe alternatives you've considered

Additional context

cc @PhanLe1010 @shuo-wu @DamiaSan @innobead


[MATLAB] Enable clang-format in the matlab/ subfolder.

Describe the enhancement requested
Currently, there is no specific format that is enforced for the C++ code in the MATLAB interface. This makes it easy to make accidental formatting mistakes and leads to inconsistent code formatting (e.g. https://github.com/apache/arrow/pull/38189#discussion_r1353727208).
We should use clang-format on the source files in the matlab/ subfolder.
Component(s)
MATLAB

Issue resolved by pull request 40588
https://github.com/apache/arrow/pull/40588


Add support for custom components

Closes #29.
@FelixSchwarz You might consider this a rough draft, but it seems like it's working as expected. The test components could probably be more complex. Let me know what you think.
Components now support a component_name property (the majority of the file changes are just adding this one line).

@FelixSchwarz Updated - much cleaner now.

@FelixSchwarz I think I've addressed all of your requested changes. Let me know if I missed anything.

Can only say sorry again for letting you waiting so long. I updated the main branch, fixing the test suite (missing_ok, but also different image so we can have tests for Python 3.6) so unfortunately there is now a conflict.
Is it ok if I resolve that manually + squash your commits into a single one for merging?

Sure thing - go ahead and resolve/squash. I think you should be able to commit to my branch. Let me know if not and I can address.

I merged this manually (after fixing an import problem with the custom component test) as 4ce237628dbb9a8877add8e780b094e483f47cfc
Thank you very much for your work + persistence.


2.0 is not on PyPI

https://pypi.org/project/pyscf/

Hi all,
Is the PySCF v2.0.0a version (libxc 5.1.2) still not on pypi?
https://pypi.org/project/pyscf/#history
Could it be a naming problem,
may cause by a misspelled release version (2.0a instead of 2.0.0a)?
https://github.com/pyscf/pyscf/commit/b76d2ceae0011d06b279f937bb36ce3c137dc57b
I found a pypi version called 2.0a0
https://github.com/pyscf/pyscf/runs/2281914728?check_suite_focus=true#logs
https://test.pypi.org/project/pyscf/2.0a0/
which installs.
However, it seems still not support for instance r2SCAN ('497,498')?
Failed to load library libtblis_einsum
XC functional 497 not found

A PySCF version properly installing from pip with support of newer libxc versions would be very nice to have.
Best,
Sebastian

Hi there,
I was wondering about the same thing.
There seems to be a new 2.0 version, but via pypi I do not get it.
Also, having the most current GitLab version of LibXC as a standard would
be nice for the future.
Best,
Kai

Hi @yurivict , has this been resolved?


Removed calendar emoji and replaced with blue calendar SVG

Replaced calendar emoji with blue calendar SVG. The blue calendar was made using Figma so that the color could be matched to the acmBlue. The calendar will be hidden when the size of the screen decreases to a significant amount.

Mode
Before
After

Light

Dark

Fixed #467

Changed size to make it smaller as according to @jaasonw

works ofr me : )


update readme

move the ULSA stuff to its own file, add to readme (describe different files and the overall goal etc)

also make note on ARES installation


[BUG] Unable to load DLL 'libSkiaSharp': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

Description
I've added SkiaSharp to my vb asp.net (.net 4.6) project. As I ran into the "Strong Name Signature Problem" in 2.80.3, I've tried both 2.80.2 and 2.88.0 preview 155. Project compiles, but as soon as I do anything with SkiaSharp (in my case SKBitmap.Decode with local filename) I get this error message:
Unable to load DLL 'libSkiaSharp': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
In other reports i've seen that installing 2015 runtime fixed it. In my case it was already installed. I've additionally installed the 2015-2021 runtimes and restarted my machine, but problem still exists. In Bin-Folder I see SkiaSharp.dll but how could I get libSkiaSharp?
Basic Information

Version with issue:  2.80.2 and 2.88.0 preview 155
Last known good version:  ---
IDE:  Visual Studio 2019
Platform Target Frameworks:

Windows Classic: Windows 10

Detailed IDE/OS information (click to expand)

at SkiaSharp.SkiaApi.sk_filestream_new(Void* path)
   at SkiaSharp.SKFileStream.CreateNew(String path)
   at SkiaSharp.SKFileStream..ctor(String path)
   at SkiaSharp.SKFileStream.OpenStream(String path)
   at SkiaSharp.SKBitmap.Decode(String filename)

I've fixed it now by manually copying libSkiaSharp.dll from \packages\SkiaSharp.2.80.2\runtimes\win-x64\native\ (or \packages\SkiaSharp.2.80.2\runtimes\win-x86\native\ of course) to the bin folder.


fix for null pointers in TaskList returned by MapReduceFSFetcherHadoop2

For MapReduce jobs with succeeded status but containing failed tasks (by setting mapreduce.map.failures.maxpercent to non zero), MapReduceFSFetcherHadoop2 will construct a task list with null pointers. This PR fixes this bug and adds a unit test to distinguish it.

+1


Converting a base checkpoint to an MVDream checkpoint

Is it possible to convert other checkpoints to MVDream checkpoint, for example basic SDXL checkpoint or custom SDXL 2.1?

No, we fine-tune the model to learn multi-view consistency, so you will need to do the same for other models such as SDXL. For other SD2.1 models (e.g. LORA), you may try to merge the models, not sure about consistency after that though...


changed whatisnew to 255 instead of 250

#419
@wski @clarkjefcoat @tonyalletag

:+1:

akonsowski and I confirmed that the database field will hold 255 characters.  This frontend change is enough to fix the problem.
:+1:


Newtonsoft performance

Improve performance:

[ ] Use stream
[ ] Use of JsonConverters
[ ] Slice json and deserialize in parallel (maybe??)

See #190


But dps option works on the  Cloud Shell

PS Azure:> az iot dps --help
Group
az iot dps : Manage Azure IoT Hub Device Provisioning Service.
Subgroups:
access-policy : Manage Azure IoT Hub Device Provisioning Service access policies.
certificate   : Manage Azure IoT Hub Device Provisioning Service certificates.
linked-hub    : Manage Azure IoT Hub Device Provisioning Service linked IoT hubs.
Commands:
create        : Create an Azure IoT Hub device provisioning service.
delete        : Delete an Azure IoT Hub device provisioning service.
list          : List Azure IoT Hub device provisioning services.
show          : Get the details of an Azure IoT Hub device provisioning service.
update        : Update an Azure IoT Hub device provisioning service.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fdb078bf-8f6c-a3f6-d157-3ecf9d94f7e2
Version Independent ID: a5e7ccb7-7593-4c0c-bc95-66c8216ed35f
Content: az iot dps
Content Source: src/command_modules/azure-cli-iot/azure/cli/command_modules/iot/_help.py
Service: iot-hub
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Resolved, see below.

Needed to update Az Cli installation.


String.each_line includes "\n" character

Im not sure if it is intended behaviour but i believe string elements in the array which returned by String.lines (which is generated using String.each_line) shouldn't include "\n" characters.
"hello\nworld\nlast".lines # => ["hello\n", "world\n", "last"]

Ruby does the same. It allows preserving/differentiation between \r\n and \n, if you ever need to.
[70] pry(main)> "foo\nbar\nbaz\n".lines
=> ["foo\n", "bar\n", "baz\n"]
[71] pry(main)> "foo\nbar\nbaz\n".each_line.to_a
=> ["foo\n", "bar\n", "baz\n"]

It also makes  more sense for the variant taking a parameter, in case we're ever going to support that.
[74] pry(main)> "foo\nbar\nbaz\n".lines("o")
=> ["fo", "o", "\nbar\nbaz\n"]
[75] pry(main)> "foo\nbar\nbaz\n".each_line("o").to_a
=> ["fo", "o", "\nbar\nbaz\n"]

I thought about it. "String.split" does what i want for sure but "String.lines" is a better name.

This is something that I thought about many times: most of the time you need to use chomp afterwards and it's a bit more inefficient. We could maybe add an option to remove the newline, but just for efficiency (using chomp would have the same effect, only a bit slower).
One case I found where preserving the newline is useful is when parsing an HTTP::Request, the headers end when a "\r\n" line is found. Although... if gets discarded it, the condition could probably be "if the line is empty" (the current code also checks for "\n").
I don't know if there are other cases where preserving the newline is needed. Maybe we could make gets discard it, and using gets(char) would preserve it, so you can do gets('\n') if you need it.

Pondering this thread, I've come to the following conclusion: I'd much rather have semantics where #lines and #each_line without arguments will drop \r\n or \n characters as in:
"hello\nworld\nlast".lines # => ["hello", "world", "last"]
"hello\r\nworld\r\nlast".lines # => ["hello", "world", "last"]

This will make handling dos and unix text files much easier and eliminate a lot of special case handling for \r\n in every application that needs it.
#lines and #each_line with an argument would preserve that character as in:
"hello\nworld\nlast".lines('\n') # => ["hello\n", "world\n", "last"]
"hello\r\nworld\r\nlast".lines('\n') # => ["hello\r\n", "world\r\n", "last"]

Ruby just added a chomp optional argument to many methods, for example IO#gets. We could do the same. I always wanted to read lines and automatically have them chomped. Invoking chomp is OK, but will create a new string, so the chomp option will improve performance a bit.

@asterite Is it that common to need an un-chomped string? Maybe chomp: true should be the default.

@RX14 Yes, I wouldn't mind it being true by default

On the other hand, chomp in Ruby also applies to the given character if passed. For example:
io = StringIO.new "hello\nfoo\nbar"
io.gets(chomp: true) # => "hello"
io.gets('o', chomp: true) # => "f"
io.gets("ar", chomp: true) # => "o\nb"

So I'm not sure chomp should be true by default. When passing a character it's usually to say "read up until this char, and keep it". Maybe with \n it's different, but I don't know if it's good to have the chomp flag being true by default for some cases and false for others.

On the other hand, passing a delimiter to gets isn't very common, so it could be true by default when not passing any delimiter.

Hey! This is already fixed in 0.20.5 (and I think a couple of versions before that too):
"hello\nworld\nlast".lines               # => ["hello", "world", "last"]
"hello\nworld\nlast".lines(chomp: false) # => ["hello\n", "world\n", "last"]


Dim unfocused setting link does not work

Forked off from https://github.com/microsoft/vscode/issues/191618
The link in settings does not work:

I'm pretty sure I'm following this reference exactly though:
https://github.com/microsoft/vscode/blob/64f1488b7e388e744cd80cd1bf5b238c9f193b0a/src/vs/workbench/contrib/files/browser/files.contribution.ts#L259
Config is defined here:
https://github.com/microsoft/vscode/blob/64f1488b7e388e744cd80cd1bf5b238c9f193b0a/src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts#L127-L139

Found the issue; use the key markdownDescription instead of just description

This is not the first time I made that mistake 🤦


feat(react-query): add <HydrationBoundary/>

Overview

PR Checklist

[ ] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 74.30%. Comparing base (951d702) to head (e0cf4eb).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   78.40%   74.30%   -4.11%
==========================================
  Files          71       73       +2
  Lines         616      650      +34
  Branches      144      157      +13
==========================================
  Hits          483      483
- Misses        127      151      +24
- Partials        6       16      +10

Components
Coverage Δ

@suspensive/react
98.78% <ø> (ø)

@suspensive/react-dom
96.66% <ø> (ø)

@suspensive/react-native
100.00% <ø> (ø)

@suspensive/react-query
72.30% <ø> (ø)

@suspensive/react-query-4
0.00% <0.00%> (ø)

@suspensive/react-query-5
0.00% <0.00%> (ø)

@suspensive/jotai
0.00% <ø> (ø)

I'm curious why we need to add <HydrationBoundary/> than using just <Hydration/> of @tanstack/react-query


wallet.Wallet.Save method docs looks incorrect

according to docs, the wallet may be written to various byte streams. Instead, package doesn't provide any option to customize output stream other than filepath
suggest to either fix docs or support the documented functionality

The ability to write wallet to a custom stream may be useful, thus, I suggest to leave the doc as is and implement the custom output (although it may require some CLI/wallet refactoring).

@cthulhu-rider, is there any special demand to use anything except file to store the wallet? Or maybe @roman-khimov.
If not, then https://github.com/nspcc-dev/neo-go/pull/3255#discussion_r1422303697 solves this issue.

use anything except file

right now no

Good, then let's exclude this issue from 0.105.0, the doc itself is fixed in #3255.


HERE'S WAY To Watch Cagliari vs Inter live Free stream, TV channel,28 December 2024

🔴📺📱👉►✅Cagliari-Inter Live
🔴📺📱👉►✅Cagliari-Inter Live
🔴📺📱👉►✅ Cagliari-Inter Live
Cagliari is going head to head with Inter starting on 28 Dec 2024 at 17:00 UTC at Unipol Domus stadium, Cagliari city, Italy. The match is a part of the Serie A.
Currently, Cagliari rank 18th, while Inter hold 3rd position. Looking to compare the best-rated player on both teams? Sofascore's rating system assigns each player a specific rating based on numerous data factors.
On Sofascore livescore you can find all previous Cagliari vs Inter results sorted by their H2H matches. Sofascore also provides the best way to follow the live score of this game with various sports features. Therefore, you can:
Find out who scored in a live match
Get real-time information on which team is dominating the match using the Attack Momentum
Follow detailed statistics such as ball possession, shots, corner kicks, big chances created, cards, key passes, duels and more
Check all head to head matches – for instance, in the last season Cagliari and Inter played 2 games against each other
Track all home and away games for each team in the Serie A
Check out how Sofascore community votes on which team is more likely to win this match.
All of these features can help you decide on Cagliari vs. Inter game prediction. Even though Sofascore doesn't offer direct betting, it provides the best odds and shows you which sites offer live betting. Live U-TV odds are viewable on Sofascore's Football live score section.
Where to watch Cagliari vs. Inter? Under TV Channels section you can find the list of all channels that broadcast Cagliari – Inter live match. You can also live stream this match through our betting partners or click on any links on Sofascore for a legal live stream.
Event details:
NAME: Cagliari - Inter
DATE: 28 Dec 2024
TIME: 17:00 UTC
VENUE: Unipol Domus, Cagliari, Italy
More details:
Cagliari live score, schedule and results
Inter live score, schedule and results
Sofascore livescore is available as iPhone and iPad app, Android app on Google Play and Windows phone app. You can find us in all stores on different languages as "Sofascore".


Providing sample documents for every standard type

For example, for MPFA documents, we have them here:
https://github.com/riboseinc/mpfd-documents/
People usually work with only one type of standard, and that's all they need to know.  We should give them the samples they want to see, not saying something like "just read this syntax once and you can work with all types of Metanorma documents".

We should have a page for "General Metanorma input syntax". Right now only "AsciiDoc", but foreseeable to have LaTeX or Word.
Separate pages for syntaxes only pertaining to one (or more) types of standard documents.

All standards gems include in their spec/examples the same Asciidoctor document (either RFC 6350 or the ISO Rice document or both), as an example document. So the requirement for a document sample is already satisfied.
There is little syntax specific to most standards classes, except for GB and ISO. The syntactic peculiarities for each class are in the Readme of each gem, so the Asciidoctor extensions for each will need to be extracted from there. I will need to do an editorial pass to make sure they are up to date for the classes other than GB and ISO (now that the remainder of the standards all inherit from metanorma-standoc).

@opoudjis I’ll integrate the samples into project sites, so I think just the pointers would be enough. For now we can take ISO and a more generic standard type, and have up-to-date samples for those.

I have moved the Asciidoctor enhancements that are introduced in metanorma-standoc from the metanorma-iso Readme to the metanorma-standoc Readme; they are all but one of them. GB introduces one more instance, and all other variants introduce the same single instance (keyword). All documented in the readmes.

Hi @strogonoff , the presentation that I gave is in https://github.com/CalConnect/VCARD/tree/master/presentations/20180926-calconnect-mn-authoring .  The PDF may need to be explicitly built.  Let us know if problem.  Thanks!

@strogonoff @opoudjis
Here is the PDF slides of the Metanorma presentation that I gave:
20180926-calconnect-mn-authoring.pdf

It's all done now.


Support 3.11 on aarch64

The latest version of dockcross aarch64 does not yet support Python 3.11, blocking us from creating these artifacts. Once they do support it, we should start producing these artifacts. This image has not been updated on dockerhub for a year, so it's possible that this may require more than just waiting for a new release. I've raised the issue here to find out.

maybe an alternative could be to switch to pypa/cibuildwheel ?

is there a solution. i can't install due the same problem too

@gnossen do you think I could open a PR to switch from dockcross to qemu+aarch64 image instead ?
Even if it is super slow, at least it would work

maybe an alternative could be to switch to pypa/cibuildwheel ?

I haven't looked deeply into this, but it seems that integrates at the level of the CI system, e.g. Github Actions, Travis, Circle CI. For software supply chain security reasons, we use a private system called Kokoro and we would not be able to use these cibuildwheel directly, though we might be able to pull some components out of it to enable this case.

do you think I could open a PR to switch from dockcross to qemu+aarch64 image instead ?

We'd have to play around with CI configuration to make sure that our PR presubmits don't get blocked by a 5 hour build, but in principle, yes, a contribution like that would be greatly appreciated. Thank you for the offer!

I think the qemu is way too slow (the build timed out after 2h 😓 ).
I'll do some more tests to understand what can be done

PASSED: build_artifact.python_manylinux2014_aarch64_cp311-cp311 [time=798.4sec, retries=0:0]

I've been able to build a dockcross image with python 3.11 🎉
I'll try to create PRs for dockross & grpc in the next few days

It seems that the latest release 1.15.3 still doesn't include a 3.11 aarch wheel. Can you please check?

Hi @kasium
From my understanding, the aarch wheel will be available from 1.53.x (1.51.3 is a maintenance release and 1.52 was yanked)

@mgu I see. Thanks!


require node-fetch is throw error “ syntax error ”

I suspect you are trying out<EMAIL_ADDRESS>we converted our package to use only ESM syntax
we no longer support cjs and switched to using import/export instead

I know import is not supported in node，so it is a syntax error，but why not-fetch will use it?

I guess you are wrong. imports have been supported in nodejs ever since v12.20 (with top level await in v14 or something like that)
So here is what you have to do:

Update and use a newer nodejs version that is 12.20 or higher
Change package.json to include a "type": "module"
use import fetch from 'node-fetch'
or alternative use import('node-fetch') if you are stuck with using cjs

Locking b/c it's nicer to keep the discussion in one place.
(We still keep a open mind and looking for a solution - it dose not mean we will overlook this Issue)
Feel free to keep the discussion in #1227 where most of the discussion is already happening


Read Emails Aloud?

Knowing if you have a new email is nice, however this would be much more useful if Mycroft could actually read certain messages to you and ask if you'd like to mark them as read.

Many of my mails contains quotes of previous conversation so it would be nice to treat that differently while keeping bits in to still rpovide the context... Just a further idea


gcc: extend crtn workaround to alpha target

Without the change alpha-unknown-linux-gnu target is failing to build gcc:
$ NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix build -f ./. re2c --arg crossSystem '{ config = "alpha-unknown-linux-gnu"; }'
...
make[1]: *** No rule to make target '../../../gcc-12.3.0/libgcc/config/alpha/crti.S', needed by 'crti.o'.  Stop.
...
cc1: error: fp software completion requires '-mtrap-precision=i' [-Werror]

After the change it is able to produce working binaries:
$ NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix build -f ./. re2c --arg crossSystem '{ config = "alpha-unknown-linux-gnu"; }'
...
$ qemu-alpha ./result/bin/re2c --version
re2c 3.1

$ file result/bin/re2c
result/bin/re2c: ELF 64-bit LSB executable, Alpha (unofficial), version 1 (SYSV), dynamically linked, interpreter ...-glibc-alpha-unknown-linux-gnu-2.38-27/lib/ld-linux.so.2, for GNU/Linux 3.10.0, not stripped

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3276


aws codecommit support as a git host

We use codecommit to save our state file + tfvars. I am wondering if we can use atlantis to manage our gitops workflow.
Is codecommit could be used a an git host like github or bitbucket ?

Hi Atali, this kind of issue is best opened up in the main Atlantis repo (https://github.com/runatlantis/atlantis) because it's not related to deploying Atlantis in Fargate. I see you've already commented on the existing issue so this one can probably be closed.


Create documentation.md

Observability and Manageability Team Publications: Public blogs and cloud coaching clinic recordings.

I have read the CLA Document and I hereby sign the CLA


[BUG] Multiselect Dataview values not offered to choose from

Describe the bug
Normal Dataview entry seems to work but that allows only one value to be entered. Multiselect DV doesn't work.
To Reproduce
Make a form with Multiselect Dataview entry querying a property e.g. [...new Set(dv.pages("").flatMap(p => p.somepropertyName || []))].sort((a, b) => a.localeCompare(b))
Behavior
While making the form, Dataview query results are correctly shown. When the form is used in note creation process, no values are offered – not even one.
Expected behavior
All value results created with Dataview are offered to choose from, allowing multi values to be selected as well.
Current workaround
Use Multiselect static solution and add all currently available Dataview results to data.json file manually.

I tested that on my vault, and it works. I had to change the propety name to one that exist on my vault (in this case, tags) but everything works as I expect. May you tell me what is in that property name?

Happy to see you found the problem!


Server port: Auto-assign ports for database with report.

Hey team,
First off, great job with BGCflow! It is super useful!
I've noticed an issue when the original or default port is busy, and the BGCflow analysis report can be switched to a custom port. Everything works fine except for the antiSMASH data links, which don't connect properly because the file server is on a different port.
Could we update the automation to ensure the file server port is synchronized or updated when switching ports? This would really improve the workflow.
Thanks!
Best,
Shreyash

Hi @SPBorkar04, thank you for the suggestion. I guess we can build a randomize search for unused port. I will add this to the feature request.


WIP: [python-package] support Python 3.13

Add support for Python 3.13, now that it's available: https://docs.python.org/3/whatsnew/3.13.html
This also proposes a new standard process for Python version upgrades in this project. Proposing that when a new version is generally available, we do the following:

bump every Python version in all CI up by 1 major version (e.g., all 3.10 -> 3.11)
add any end-of-life versions to the test-old-versions CI job (as I've done here with Python 3.8)

based on https://devguide.python.org/versions/

This makes the updates easy to make and review, and reduces the risk of issues like #5969 and #6680 leading to maintenance work.
Notes for Reviewers
Just opening this to test. It's not ready for review... I expect more changes will be necessary, or at least that we'll need to wait for dependencies to update.

We'll need to wait for the rest of LightGBM's dependencies to get Python 3.13 packages on conda-forge.
LibMambaUnsatisfiableError: Encountered problems while solving:
  - package mypy-1.11.1-py310h5b4e0ec_0 requires python >=3.10,<3.11.0a0, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ mypy >=1.11.1  is installable with the potential options
│  ├─ mypy [1.11.1|1.11.2|1.12.0] would require
│  │  └─ python >=3.10,<3.11.0a0 , which can be installed;
│  ├─ mypy [1.11.1|1.11.2|1.12.0] would require
│  │  └─ python >=3.11,<3.12.0a0 , which can be installed;
│  ├─ mypy [1.11.1|1.11.2|1.12.0] would require
│  │  └─ python_abi 3.12.* *_cp312, which requires
│  │     └─ python 3.12.* *_cpython, which can be installed;
│  ├─ mypy [1.11.1|1.11.2] would require
│  │  └─ python >=3.8,<3.9.0a0 , which can be installed;
│  ├─ mypy [1.11.1|1.11.2] would require
│  │  └─ pypy3.9 >=7.3.15 , which requires
│  │     └─ python 3.9.* *_73_pypy, which can be installed;
│  ├─ mypy [1.11.1|1.11.2|1.12.0] would require
│  │  └─ python >=3.9,<3.10.0a0 , which can be installed;
│  └─ mypy 1.12.0 would require
│     └─ python_abi 3.13.* *_cp313 with the potential options
│        ├─ python_abi 3.13 would require
│        │  └─ python 3.13.* *_cpython, which can be installed;
│        └─ python_abi 3.13 would require
│           └─ python 3.13.* *_cp313, which can be installed;
├─ pyarrow-core >=17.0  is installable with the potential options
│  ├─ pyarrow-core 17.0.0 would require
│  │  └─ __cuda >=11.8 , which is missing on the system;
│  ├─ pyarrow-core 17.0.0 would require
│  │  └─ python >=3.10,<3.11.0a0 , which can be installed;
│  ├─ pyarrow-core 17.0.0 would require
│  │  └─ python >=3.11,<3.12.0a0 , which can be installed;
│  ├─ pyarrow-core 17.0.0 would require
│  │  └─ python_abi 3.12.* *_cp312, which can be installed (as previously explained);
│  ├─ pyarrow-core 17.0.0 would require
│  │  └─ python >=3.8,<3.9.0a0 , which can be installed;
│  └─ pyarrow-core 17.0.0 would require
│     └─ python >=3.9,<3.10.0a0 , which can be installed;
└─ python 3.13 *_cp* is not installable because it conflicts with any installable versions previously reported.

(build link)
But hey, at least lightgbm itself already has Python 3.13 packages on conda-forge! (https://github.com/conda-forge/lightgbm-feedstock/pull/63). That's thanks to lightgbm having such a small set of required dependencies... a good reminder that it's worthwhile to keep it that way 😁
We can check the state of LightGBM's dependencies here: https://conda-forge.org/status/migration/?name=python313

We can check the state of LightGBM's dependencies here: https://conda-forge.org/status/migration/?name=python313

pyarrow now has Python 3.13 packages. I just merged last master into this... let's see if all of LightGBM's recursive dependencies are now updated.

The conda-forge Python 3.13 migration is making progress, but looks like not all of lightgbm's dependencies have made it across yet. Looks like the next one we need is cffi.
PR to subscribe to: https://github.com/conda-forge/cffi-feedstock/pull/53


Support multipurpose keys with time threshold

Support modifying any key as a modifier as well as normal as in mooz/xkeysnail: Yet another keyboard remapping tool for X environment.
Another option that would be crucial here is to define a time threshold - when I press a key that is defined as both a modifier and a regular one, activate it as a modifier only when it is held down for longer than the threshold time. This is important otherwise you end up with wrong inputs if you are a type reasonably fast.

This has been asked before: https://github.com/snyball/Hawck/issues/8
It's possible but because of an unimplemented feature (passthrough scripts that can be pipelined,) the solution is a bit iffy for now.
-- Note: because of how this is implemented, it needs to be put in a separate script,
-- and needs to be the first script to run.
-- It also requires you to enable unsafe mode, as it needs to receive all keyboard input
-- to work.
caps_down = false
caps_as_ctrl = false
up + key "caps" => function ()
  caps_down = false
  if not caps_as_ctrl then
    kbd:press("caps")
  else
    kbd:up("control")
  end
  caps_as_ctrl = false
end

down + key "caps" => function ()
  caps_down = true
  caps_as_ctrl = false
end

down => {
  -- ... put the rest of your bindings here, inside down {}, but before any{} ...
  any => function ()
    if caps_down and not caps_as_ctrl then
      kbd:down("control")
      caps_as_ctrl = true
    end
    kbd:echo()
  end

Another feature standing in the way of this being shipped with hawck by default, is inputd scripts, i.e scripts that run inside a sandbox, so that they don't need whitelisting of keys.
But it should work, also note that this solution doesn't use any timing (that's left as an exercise to the reader.)

Reopening this so you can tell me whether or not that code works, or if you were able to improve on it with the timing features you needed.


Unable to add transparency

After assigning the Image With Rounded Corners script to the panel , when I try to reduce the alpha of the Image componentto implement transparency , it seems to have no effect on the sprite. Is there a way to implement a panel with rounded corners and a transparent Image with this library?

Hi maximus9600!
I am going to update shaders for this soon (today or this week).

Thanks for replying @Nobinator


Feature/error summary tabs

Checklist:

[x] Documentation
[x] Tests
[x] Ready to be merged

Add incrementing tabIndex to list of errors while mapping through errors array to enforce tabbing through errors.
closes #371

Codecov Report

Merging #372 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #372   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          77     77
  Lines         409    409
  Branches       14     14
=====================================
  Hits          409    409

Impacted Files
Coverage Δ

components/error-summary/src/index.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a7114...5261f2d. Read the comment docs.


bug in geotop aggregate_to_ds

When there are NaN values in the layer model that is used in aggregate_to_ds the kh and kv values are not calculated correctly. The bug is clearly visible in the geotop example notebook.

Solved by @OnnoEbbens in PR #287


[Question] How to make menu items dark

First of all: Sorry, I'm not very proficient with Win32 or C++ in general.
As the code is almost completely uncommented, how are the menu popup items in the top menu bar being set to dark? I found out that it has something to do with _SetPreferredAppMode (or _AllowDarkModeForApp for older versions), but when I try to implement this in my C# app using p/invoke, it does not make menus dark (and yes, I'm using MainMenu and not MenuStrip). Sorry if this is the wrong place to ask.
Also, is it possible for you to add detailed comments to the code so it can be understood more easily how to integrate dark mode in one's own app?

IIRC, C# is not using system menu. It uses it's own menu, so dark menu has no effects on it.
Also Qt is not using system menu.

As I said, I am using the MainMenu component and the ContextMenu component. I got it to work in the meantime. The trick is to not asign this.Menu = mainMenu1 (remove that line in YourForm.Designer.cs), then call SetPreferredAppMode (using p/invoke) and only then assign the MainMenu. Not doing that also for some reason breaks ContextMenus.

Sorry I misunderstood you.
So you mean the menu bar is still light? This is because Windows doesn't have dark theme resources for that.
What we can do is to owner draw menu bar.

Yeah, owner drawing is probably the best strategy for having a dark menu bar, at least until Microsoft adds one natively in the future.

As far as I understand, the only semi-solution is to install an unsigned theme on your computer that will force item menu to be dark (what works in my case), which is not directly related to new Windows dark mode, it need to be improved, as jonaskohl said.

As I said, I am using the MainMenu component and the ContextMenu component. I got it to work in the meantime. The trick is to not asign this.Menu = mainMenu1 (remove that line in YourForm.Designer.cs), then call SetPreferredAppMode (using p/invoke) and only then assign the MainMenu. Not doing that also for some reason breaks ContextMenus.
Now the only "bright" thing left is the menu bar itself, which can't be made dark (as discussed in #1)

I try to do this to make the menu of Unity Editor be dark，but it doesnt work.
`using System;
using System.Runtime.InteropServices;
using UnityEditor;
public class DarkModeMenu
{
enum GetAncestorFlags : uint
{
GA_PARENT = 1,
GA_ROOT = 2,
GA_ROOTOWNER = 3
}
const uint DWMWA_USE_IMMERSIVE_DARK_MODE = 20;

enum PreferredAppMode
{
APPMODE_DEFAULT = 0,
APPMODE_ALLOWDARK = 1,
APPMODE_FORCEDARK = 2,
APPMODE_FORCELIGHT = 3,
APPMODE_MAX = 4
}
[DllImport("uxtheme.dll", EntryPoint = "SetPreferredAppMode", SetLastError = true, CharSet = CharSet.Unicode)]
private static extern int SetPreferredAppMode(int preferredAppMode);

}
`


override OnFlashPointCommand for convert tab

addresses Esri/military-tools-for-arcgis#77 at 1.3 dev
@kgonzago please review and merge

@kgonzago @dhagens not sure if this flash method worked at 1.2 but if it does, the 1.2 branch will need this update also


Generic EntityReference

@MattB-msft I've given you access to our (private by now) CDS library. I intend to make this public at some point, but we're going thru some internal stuff that needs to get resolved first, and I would like to add documentation to the project too.
That said, if you look here you'll see that I created a generic version of EntityReference. This works great and greatly improves type safety, since, for example, an EntityReference<Account> is NOT the same as an EntityReference<Contact>, therefore we get compile time safety to not mistakenly assign one another.
Unfortunately, the CDS LINQ provider does not "know" my class at all, and therefore is unable to resolve queries like this:
EntityReference<Contact> contactId = GetMyContactId();

var accounts =
    CrmService.Query<Account>()
              .Where(x => x.PrimaryContactId == contactId)
              .ToList();

Since it attempts to serialize contactId and I get a WCF error saying that's not a known type.
I would be awesome if it was supported, so I propose 2 things here:

1 Please include a generic version of EntityReference in the first party SDKs
2 Add a way to extend the LINQ provider in such a way that these cases can be supported by third parties. NHibernate for example does this. It has extensibility points built in for it's own LINQ provider.

A generic version of EntityReference won't work since there are lookup fields in CDS that can point to more than 1 entity. Think about Customer or regarding lookups.
At compile time you don't know to which entity it will refer.
As for the LINQ provider. You can write your own QueryProvider around the CDS Linq provider which translates your expression (with your custom object) to a expression that the CDS linq provider can understand.

@mathiasbl

A generic version of EntityReference won't work since there are lookup fields in CDS that can point to more than 1 entity. Think about the customer or regarding lookups.
At compile time you don't know to which entity it will refer.

I disagree. This would improve 95+ percent of the cases, where entity references target a single entity. 100% of the custom entities for starters.
Also, for the remaining 5% where you can't determine the entity type up front, just keep the regular untyped EntityReference. I already did this and I'm running code in production right now which uses the EntityReference<T>. The change from untyped to typed was totally tranparent after I modified my early bound generator. Except for 1 case where by mistake an EntityReference<A> was being assigned an EntityReference<B>, which resulted in a compile error, rather than a runtime exception.

As for the LINQ provider. You can write your own QueryProvider around the CDS Linq provider which translates your expression (with your custom object) to a expression that the CDS linq provider can understand.

I didn't know this. Is there any sample code to use as a starting point? OrganizationServiceContext doesn't seem to have any configurable properties that I can use to tell it to use my custom LINQ provider.

@mathiasbl For the record:
I just performed a Find All References of both EntityReference and EntityReference<T>  in my largest project's model code. I found this:

356 usages of EntityReference<T>
31 usages of EntityReference.

Which confirms my ~90%-10% claim.

I didn't know this. Is there any sample code to use as a starting point? OrganizationServiceContext doesn't seem to have any configurable properties that I can use to tell it to use my custom LINQ provider.

On a second thought, I could simply wrap OrganizationServiceContext in my own abstraction and call it after having resolved the custom logic. For example replacing x => x.MyEntityRef == value with x => x.MyEntityRef == value.Id and so on.

From Microsoft's perspective you'd want a solution which fits 100% of the time. Which is what EntityReference brings today.
I can agree you might want more fool proof code but imo this shouldn't be part of the SDK.
As for the QueryProvider. We created an extension on IQueryable (I know it's not ideal but the EntitySets are IQueryables) which just returns a custom IQuerable implementation which has some additional logic.
        public static ID365Query<TSource> AsD365Query<TSource>(this IQueryable<TSource> queryable) where TSource : Entity         {             return new D365Query<TSource>(queryable);         }

Kind of off-topic, but EntityReference also lacks value object properties. It is a class (not struct), but there is no override for equals operator (==).
var efLeft = new EntityReference("account", Guid.Empty);
var efRight = new EntityReference("account", Guid.Empty);
var areEqual = efLeft == efRight;

areEqual is false, which is not any D365 developer would want in 99% cases. Same true for Money type. Taking in mind that any of them might be null simple equality check becomes a monster.
var areEqual2 = efLeft?.LogicalName == efRight?.LogicalName && efLeft?.Id == efRight?.Id;

It might get worse without null conditional operator.
Is there any chance this could be addressed in the future?
I can create separate issues for this and fire PR with changes.

@fberasategui regarding what your doing with a typecase entityreferance,  given that you extended the object, you could add a ISerializable and look at implementing the interfaces there to custom serialized the object back into a normal entity refence.  This is similar to how we do a number of things in the wire transport for talking to CDS.   Have you explored that?
@sergeytunnik,  that is something we have discussed a few times for several of our classes.
We have discussed it as part of core or we could add it as a extension in the client libs.
The tradeoff's are that the utility would be diminished if we only added it in the client libs.
I will pass your thoughts on to to the team to add to the discussion.

@MattB-msft thanks for the suggestion. One thing though: my class does not inherit from EntityReference, because that class is sealed


⚠ Bofrost.lu has degraded performance

In 2d9b741, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 938 ms

Resolved: Bofrost.lu performance has improved in ca74412 after 7 minutes.


Add TensorRT engine to DJL

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1216 (24a382b) into master (03549e1) will decrease coverage by 0.39%.
The diff coverage is 33.94%.

@@             Coverage Diff              @@
##             master    #1216      +/-   ##
============================================
- Coverage     70.53%   70.14%   -0.40%
- Complexity     5012     5039      +27
============================================
  Files           476      487      +11
  Lines         21974    22196     +222
  Branches       2323     2361      +38
============================================
+ Hits          15500    15569      +69
- Misses         5270     5420     +150
- Partials       1204     1207       +3

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/engine/Engine.java
35.64% <ø> (ø)

api/src/main/java/ai/djl/ndarray/NDManager.java
57.43% <ø> (ø)

...src/main/java/ai/djl/tensorrt/engine/TrtModel.java
0.00% <0.00%> (ø)

...c/main/java/ai/djl/tensorrt/engine/TrtNDArray.java
0.00% <0.00%> (ø)

...main/java/ai/djl/tensorrt/engine/TrtNDManager.java
0.00% <0.00%> (ø)

...main/java/ai/djl/tensorrt/engine/TrtPredictor.java
0.00% <0.00%> (ø)

...c/main/java/ai/djl/tensorrt/engine/TrtSession.java
0.00% <0.00%> (ø)

...in/java/ai/djl/tensorrt/engine/TrtSymbolBlock.java
0.00% <0.00%> (ø)

...rt/src/main/java/ai/djl/tensorrt/jni/JniUtils.java
0.00% <0.00%> (ø)

.../src/main/java/ai/djl/tensorrt/jni/TrtLibrary.java
0.00% <0.00%> (ø)

... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03549e1...24a382b. Read the comment docs.


ictest: Unity contract

(Builds off the FeeShare ICtest)
Adds the unity contract deploy & gov store test into this repo with interchain test
Review starts at 324e593b5c3fb79bd333acc7740f68599183b77c
files of importance:

interchaintest/contract_unity_deploy_test.go
interchaintest/contract_unity_submit_test.go

This is fantastic, thank you!

https://github.com/CosmosContracts/juno/issues/674

Thanks @dimiandre


HtmlFrame error on m1 macbook pro: incompatible architecture, and missing files

Source code snippet:
# gui2.py
import tkinter as tk
from tkinterweb import HtmlFrame

class GUI:
    def __init__(self) -> None:
        self.root = tk.Tk()
        self.root.geometry("815x416")

        self.info_html = HtmlFrame(self.root, width=1, height=1, horizontal_scrollbar="auto",
                                   messages_enabled=False)
        self.info_html.grid(row=0, column=0)

        self.root.mainloop()

if __name__ == "__main__":
    GUI()

Error:
$ python gui2.py
Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/bindings.py", line 82, in __init__
    load_tkhtml(master, folder)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/utilities.py", line 671, in load_tkhtml
    master.tk.eval("package require Tkhtml")
_tkinter.TclError: dlopen(/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/tkhtml/Darwin/64-bit/Tkhtml30.dylib, 0x0006): tried: '/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/tkhtml/Darwin/64-bit/Tkhtml30.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')), '/usr/local/lib/Tkhtml30.dylib' (no such file), '/usr/lib/Tkhtml30.dylib' (no such file)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/cuteufo/Projects/gui2.py", line 17, in <module>
    tradematch_GUI()
  File "/Users/cuteufo/Projects/gui2.py", line 9, in __init__
    self.info_html = HtmlFrame(self.root, width=1, height=1, horizontal_scrollbar="auto",
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/htmlwidgets.py", line 30, in __init__
    self.html = html = TkinterWeb(self, message_func, HtmlFrame)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/bindings.py", line 85, in __init__
    load_tkhtml(master, folder, force=True)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/utilities.py", line 671, in load_tkhtml
    master.tk.eval("package require Tkhtml")
_tkinter.TclError: dlopen(/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/tkhtml/Darwin/64-bit/Tkhtml30.dylib, 0x0006): tried: '/opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/tkhtml/Darwin/64-bit/Tkhtml30.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')), '/usr/local/lib/Tkhtml30.dylib' (no such file), '/usr/lib/Tkhtml30.dylib' (no such file)

Environment:
miniforge3 arm64
Python 3.9.7
tkinterweb 3.10.7
MacOS 12.1 Monterey on MacBook Pro M1 Max

Other notes:
1. same code can be run without errors if I switch to anaconda packaged Python 3.8.5 (Intel) environment
2. same errors when running in either terminal command line or PyCharm, as long as with miniforge Python (arm64)

Hello,
Sorry for the late reply. Thank you for letting me know about this. It looks like the backend for this project is not the right architecture for your computer. The Tkhtml30.dylib file was supposed to work across all MacOS platforms, but I guess I was wrong on that. I have uploaded Tkhtml30.zip. Try extracting the file inside the zipped folder and copying it to your Tkhtml folder (looking at your error code, it would be /opt/homebrew/Caskroom/miniforge/base/envs/tf/lib/python3.9/site-packages/tkinterweb/tkhtml/Darwin/64-bit/; just replace the existing file with the new one). I'm not sure if it would help, but it is worth a shot.
Let me know how it works out for you.

The backend for TkinterWeb was compiled before Apple switched from the traditional Intel chips to arm64 Apple silicon chips. Therefore, TkinterWeb should work fine on older macs, but will not load on most newer macs. I would need to re-compile Tkhtml on an m1 mac in order to resolve this issue. Unfortunately I don't have a mac to do this on, but I am trying to borrow one. In the meantime, you could try to compile Tkhtml yourself. You can download the source here. I haven't compiled anything on mac before, so I can't give you instructions, but you could definitely find information online and in COMPILE.txt and build_tkhtml.txt in the source folder. If you can compile the source code, simply replace the existing Tkhtml30.dylib file with your new file and TkinterWeb should work fine!

Hi @Andereoo if you use a github Actions to do the compile you'll have access to MacOS, Linux and Windows virtual machines to compile on (or run your test cases) even different versions of those OS's see here for the platforms available https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job
I'm still learning how to do this for my project but I managed to get my testing tool to run my python app to run under all three platforms and do some basic tests, so this might be useful for you as well 🤞🏻
Dave.

Thank you very much for letting me know about this!
Github Actions is a bit difficult to use because I need to compile both C and tcl files and it is not easy to browse system files with Actions, but hopefully I can get this all worked out soon!

The backend for TkinterWeb was compiled before Apple switched from the traditional Intel chips to arm64 Apple silicon chips. Therefore, TkinterWeb should work fine on older macs, but will not load on most newer macs. I would need to re-compile Tkhtml on an m1 mac in order to resolve this issue. Unfortunately I don't have a mac to do this on, but I am trying to borrow one. In the meantime, you could try to compile Tkhtml yourself. You can download the source here. I haven't compiled anything on mac before, so I can't give you instructions, but you could definitely find information online and in COMPILE.txt and build_tkhtml.txt in the source folder. If you can compile the source code, simply replace the existing Tkhtml30.dylib file with your new file and TkinterWeb should work fine!

By following this thread, I have compiled the "htmlwidget" source code you provided. This is my first time compiling C, so I'm not sure if I'm in the right way. The files generated are zipped and attached at the bottom with the name "build.zip".
(My device: MacBook Air with M1 chip)
The commands I used:
$ brew install tcl-tk  # according to the thread aforementioned, the tcl-tk in Xcode won't work
$ TCL="/opt/homebrew/opt/tcl-tk"
$ cd ~/Downloads
$ tar -xzf htmlwidget.MODIFIED.zip && mv "htmlwidget (MODIFIED)" htmlwidget
$ cd htmlwidget/tkhtml
$ tclsh src/cssprop.tcl && tclsh src/tokenlist.txt
$ tclsh src/mkdefaultstyle.tcl > htmldefaultstyle.c
$ mv *.c src && mv *.h src
$ mkdir ../build && cd ../build
$ chmod 755 ../tkhtml/configure
$ ../tkhtml/configure --with-tcl="$TCL/lib" --with-tk="$TCL/lib" --with-tclinclude="$TCL/include" --with-tkinclude="$TCL/include"
$ make
$ make install

However, after I renamed "libTkhtml3.0.dylib" with "Tkhtml30.dylib" and replaced the file under "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/site-packages/tkinterweb/tkhtml/Darwin/64-bit", the sample code raised an error:
Sample code:
from tkinterweb import HtmlFrame  #import the HTML browser
import tkinter as tk  #python3

root = tk.Tk()  #create the tkinter window
frame = HtmlFrame(root)  #create the HTML browser
frame.load_website("http://tkhtml.tcl.tk/tkhtml.html")  #load a website

build.zip
The error message:
An error has been encountered while loading http://tkhtml.tcl.tk/tkhtml.html: main thread is not in main loop.

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/site-packages/tkinterweb/htmlwidgets.py", line 174, in continue_loading
    self.load_html(data, newurl)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/site-packages/tkinterweb/htmlwidgets.py", line 416, in load_html
    self.html.reset()
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/site-packages/tkinterweb/bindings.py", line 287, in reset
    self.tk.call(self._w, "reset")
RuntimeError: main thread is not in main loop

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/site-packages/tkinterweb/htmlwidgets.py", line 196, in continue_loading
    self.load_html(self.broken_page_msg)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/site-packages/tkinterweb/htmlwidgets.py", line 416, in load_html
    self.html.reset()
  File "/opt/homebrew/Caskroom/miniforge/base/envs/tk/lib/python3.8/site-packages/tkinterweb/bindings.py", line 287, in reset
    self.tk.call(self._w, "reset")
RuntimeError: main thread is not in main loop

Hi @TsaiTung-Chen, I don't have a Mac to test on, so I have no way to debug that error. However, there are a few things you could try. For starters, don't forget to include the following at the bottom of your code:

frame.pack(expand=True, fill="both")

root.mainloop()

If you get the same issue, try setting frame.set_maximum_thread_count(0) and let me know what happens!

Thanks a lot for your reply. Setting frame.set_maximum_thread_count(0) really helps!
Now the HtmlFrame can work as expected on Apple Silicon Macs too!
Tested code:

from tkinterweb import HtmlFrame
import tkinter as tk

root = tk.Tk()
frame = HtmlFrame(root)
frame.set_maximum_thread_count(0)  # this helps
frame.load_website("http://tkhtml.tcl.tk/tkhtml.html")
frame.pack(fill='both', expand=1)
root.mainloop()

The result:

Would you consider adding the executable, compiled on Arm Mac, to tkinterweb to benefit others?

What is the current status of Mac support: still just Intel chips or arm64 as well? Seems like at least one user got the latter working. Thanks!

Hi @cuteufo @pdebelak @damies13 @TsaiTung-Chen I've finally managed to compile Tkhtml using Github Actions. Apologies for the delay. Try extracting
tkinterweb.zip and running __init__.py and let me know if it works.

Hi @cuteufo @pdebelak @damies13 @TsaiTung-Chen I've finally managed to compile Tkhtml using Github Actions. Apologies for the delay. Try extracting tkinterweb.zip and running __init__.py and let me know if it works.

I have tried the __init__.py script with the new "libTkhtml3.0.dylib" binary but failed and got the error message:
Traceback (most recent call last):
  File "/Users/tungchentsai/Downloads/tkinterweb/__init__.py", line 30, in <module>
    frame = TkinterWeb(root)
  File "/Users/tungchentsai/Downloads/tkinterweb/__init__.py", line 19, in __init__
    master.tk.eval("package require Tkhtml")
_tkinter.TclError: dlopen(/Users/tungchentsai/Downloads/tkinterweb/libTkhtml3.0.dylib, 0x0006): tried: '/Users/tungchentsai/Downloads/tkinterweb/libTkhtml3.0.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/tungchentsai/Downloads/tkinterweb/libTkhtml3.0.dylib' (no such file), '/Users/tungchentsai/Downloads/tkinterweb/libTkhtml3.0.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64'))

BTW, it works fine if I replace the binary with this version.

@TsaiTung-Chen would you be able to do me a favour and let me know if tkinterweb-simplified.zip works?

I've tried this new version. It works!🎉

@TsaiTung-Chen @damies13 @cuteufo @pdebelak @TsaiTung-Chen  @G-Donkey I have finally added support for M1 Macbooks. Apologies it took me so long! Please feel free to upgrade TkinterWeb and let me know if it works for you.

@Andereoo - yes, running pip install tkinterweb now works! I was able to run the example program from the readme.


[vm/ffi] Support inline arrays

Inline arrays have a statically-defined size, e.g. int[20], and can appear inside structs in their unpacked form.

duplicate of https://github.com/dart-lang/sdk/issues/35763.


Migrate from Jasmine gem to jasmine-browser-runner

The Jasmine Ruby gems have been deprecated and are not compatible with Rails 7, which is now becoming a blocker.
Trello card
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

@baisa I've just given this a rebase to see if it fixes the Gemfile problem in CI


What are Reviewers in the OWNERS file?

In the OWNERS file there is a reviewers section. What is the meaning of this?
The reviewers key has a special meaning when using the Kubernetes tools so it means something when Helm was part of Kubernetes. But, this code is no longer using the Kubernetes tools.
There may be some distinction outside of those tools. Just looking for a pointer (docs?).
cc @technosophos

I found this tidbit while grokking old issues/PRs: https://github.com/helm/helm/issues/1906

The trend in Kubernetes files is to have an OWNERS file at the project root that has two broad categories: reviewers and approvers. We should probably add one of these in Helm.

So your assumption about it being from the Kubernetes org seems correct.
Interestingly enough, @fibonacci1729 is noted as a reviewer but not as a maintainer. I presume that was an accidental typo.
Given that we've moved away from the Kubernetes org, it makes sense to remove this section. As far as I know there's no distinction between "reviewers" and "maintainers" in the development process - we're all either core maintainers or emeritus maintainers.
Would love if someone prior to my time could chime in to make sure that information is correct :)

@bacongobbler is correct. I created that file back when we were under the Kubernetes org. At that time, @fibonacci1729 was working on another project, so I put him down as a reviewer so we could use his expertise when we were doing Proto/gRPC stuff. But he has actually been a core maintainer since the early days of 2.0. So his name can be bumped up, and the reviewers section can be removed.


Delete the outdated next tag from NPM

The next tag for this package points to an old version. We can delete it as it's not in use now.
I believe this should do it for someone who has admin permissions.
npm dist-tag rm eslint-plugin-eslint-plugin next

https://www.npmjs.com/package/eslint-plugin-eslint-plugin
I can help with things like this and the publishing workflow if I receive NPM publishing privileges.

Removed it 👍


pkg/generator: Create generic file rendering function

Issue #303

This had been tested against the memcached user guide example and appears to be in working order

So generator.go still needs to be cleaned up, but this offers a single render function instead of the 9 separate files and functions which did functionally the same work of loading a template and replacing values from a struct

Fixed issue with creating olm directory


How to format/edit tasks?

Where can I find documentation on the correct formatting for the task list? I cannot seem to find instructions beyond inserting/deleting tasks.
What I would like to do is the following:

insert bullet points
insert new lines
use vim keys/shortcuts in the task view

are the above possible at all?

In order to edit a task, use i or a. I don't get what you mean by bullet points, but to mark completed tasks, use D (and undo with U).

I would like to itemise the entries in the task list like the following:
- first task
- second task
- ...

but carriage return exits the task mode; however, I have realised that o does produce a new line that I can use for indentation.
Furthermore: is visual mode not allowed in task/even mode?

What do you want visual mode for?

What do you want visual mode for?

Mainly to be able to select blocks of text at once and manipulate them more easily. However, I was only wondering if I had missed the documentation somewhere: I am not arguing that such modes must be present, the plug-in is fine as it is :).

I admit that the current editing way is not flexible but currently such modes are not implemented.


Contributor Console API - Organization Service Support

Summary
As part of the v2 Contributor Console UI redesign, we want to query the Organization/Company List from SalesForce.
Background
v1 and v2 API should query the Org Service to fetch the complete list of known/existing companies. The API should support look-ahead/partial match as the user types.
This is for Contributor Console PRD table 2 step 2; table 3 step 2; table 4 step 1.

User Searches => from v1 or v2 Contributor Console => Search Org Service via Filter => User Selects (we get: SF Org ID + Name + Owner)
Search the EasyCLA Company Table => Search by External ID => Find match?
If Company match found => return this as the company id => continue flow
If Company match not found => Go to user service and lookup Owner => search EasyCLA Users table for the match
If User match found => Create EasyCLA company => assign owner as the manager => continue flow
If User not found => create EasyCLA user entry, assign company => Create EasyCLA company => assign owner as the manager

Tasks

[x] Update the existing company search in the contributor conosle to query the Org Service for the list of companies. Present this list to the UI.
[x] Once the user selects the company, we need to ensure the EasyCLA company table includes the company record (add if missing / confirm external ID is set).  Add Org Service admins to the EasyCLA company_acl.

User Story
As a contributor, I want to query the complete list of companies so that I can select my company.
Assumptions

[x] Common API routine - should be leveraged by both v1 and v2 Contributor Consoles.

Questions
List any questions or clarifications that are needed to addressed to satisfy this request.

[...] Question 1...
[...] Question 2...

Acceptance Criteria
The "done" criteria when this feature or problem is resolved. Such as:

Unit Tests added and running in CI
Functional Tests updated to cover feature, if applicable
Demonstrate the set of capabilities to the product team while the code is running in the STAGING environment.

References
(Optional) Provide any code or specification references that would be helpful for the developer implementing this feature.

API: GET v3/organization/search?companyName=
Response:
{   "list": [     {       "organization_id": "string",       "organization_name": "string"     }   ] }
API: GET v3/company/external/{companySFID}
Response:
{     "companyACL": [         "prasanna.mahajan",         "prasanna1993"     ],     "companyExternalID": "0014100000Te0fMAAR",     "companyID": "eb4d7d71-693f-4047-bf8d-10d0e7764969",     "companyManagerID": "54300b8b-643f-11ea-b6cd-80ce62109433",     "companyName": "Pinterest",     "created": "2019-07-15T15:28:33.127Z",     "updated": "2019-07-15T15:28:33.127Z" }

added organization_website in response.

API:

https://api.dev.lfcla.com/v3/api-docs#operation/searchOrganization
https://api.dev.lfcla.com/v3/api-docs#operation/getCompanyByExternalID

cc @dealako @nirupamav
Assumption for implementation:
company will have company-admin role assigned in acs.
2nd api will fail if easycla database does not have company present in its db and acs does not have company-admin role assigned for this company.

Tested and observed below issues
Endpoint https://api.dev.lfcla.com/v3/api-docs#operation/searchCompany
1. 500 internal server is displayed when trying to search with special characters. The company names I tried to search is already existing in org service
Few other companies that exist in org service have same issue
Famous Dave's of America, Inc.

Anything before comma in search criteria is not considered to fetch search results
For e,g. I was trying to find Samsung Electronics America, Inc. and observed all companies that has Inc. is fetched

3. Empty object is returned when trying to search for company with name Landis+Gyr North America

Company exists in org service

Endpoint https://api.dev.lfcla.com/v3/api-docs#operation/getCompanyByExternalID
@dealako
What is the difference between company_acl and signature_acl
As of now the endpoint is fetcing company_acl

Our get company by External ID search:

Attempts to locate the company record in the EasyCLA database by external (SF) ID.  If found, returns the Company Record data model.
If we were unable to locate the Company Record in our EasyCLA database by the external ID, we attempt to locate the record in the SalesForce database via the Platform Organization Service API call.
If we find the SF Organization Record, we lookup the SF company admin associated with the company.
If the company admin does not exist in our EasyCLA database, we create the corresponding user record in the EasyCLA database.
If we find the SF Organization Record, we create the Company Record in our EasyCLA database.  We then return this record as a Company Record data model.

The company ACL is essentially the SF Company Admin - the same concept.
For this API call - we are not discussing signature ACL - this is only a company query - so, we show the company ACL - which is the company admin.

@rinkeshbhutwala I am assigning you this task. Can you please review the feedback that @nirupamav has provided above.  We need to do our best at searching and cleanup/validate the user's input.

@dealako For some special characters like + backend endcoding does not work so we need to add encodeURIComponent from frontend site before calling search organization endpoint.

@nirupamav For Landis+Gyr North America company instead of that you need to replace + to %2b

Tested and observed below issues and hence reopening the ticket
Endpoint https://api.dev.lfcla.com/v3/api-docs#operation/searchCompany
_1. 422 is returned when trying to search with special characters. The company names I tried to search is already existing in org service and I am able to query them in org service endpoint. _
Values tested
Famous Dave's of America, Inc.
StackEngine (now owned by Oracle)

cla-service

org-service

Issue2 is working fine
Issue3 searching with special characters is being tracked in https://jira.linuxfoundation.org/browse/PMM-657. Based on the feedback from org-service will check if we need to encode or directly use the special characters

@nirupamav searching with special characters gives swagger error so we need to finalize the pattern for which special characters need to allow.
@dealako Can you please confirm once so we can update the swagger pattern which allows special characters or should we just remove the pattern from search endpoint?

@dealako Have you finalize the swagger pattern with @pranab-bajpai  which allows special characters or should we just remove the pattern from search endpoint?

@amolsontakke3576 has indicated that we are using the same regex as provided by the Organization Service. We will use this regex going forward as this is what is supported by SalesForce. Closing this ticket now.


no-unused-variable configuration request

As the no-unused-variable is implemented now, I find it has too many false positives to really be useful. However, if I could just enable a portion of it that would check only local variables, that would be really useful.

Sorry if bumping this is against the rules - I've come across the same problem.
    class Test {
        private done: boolean;

        constructor() {
            (function (): void {
                this.doPrivateThing();
                (<Test>this).doPrivateThing();
            }).bind(this)();
        }

        private doPrivateThing(): void {
            this.done = false;
        }
    }

...gives the following error:
>> test.ts[11, 13]: unused variable: 'doPrivateThing'

It looks like tslint isn't checking inside the bound function. It's understandable that function.bind erases some information, but should <Test>this.doPrivateThing let it know that the variable's being used?

I have a similar problem maybe?
A variable used for type declaration will trigger the no-unused-variable rule.
import Foo = this.that.Foo;

module some.module.blah {
 export  class bar {
    private foo: Foo;
  }
}

returns the error  unused variable: 'Foo

The use of an import alias is also not detected when it's used with extends
import DateTimeOpts = Intl.DateTimeFormatOptions;

interface MyDateTimeOpts extends DateTimeOpts {
    timezoneOffset: number;
}

let opts: MyDateTimeOpts;
console.log(opts.timezoneOffset - 1);

@SenHeng, @nikklassen: those look like related issues; I've filed a new ticket for those false positives: #613.
as for the other issues in this thread, I think we could address them by adding a new option that makes the no-unused-variable rule skip private class members: #614. I don't want to do anything much more complex / involved than that; I really don't want to encourage any coding style that references private members with dynamic access as suggested in some of the examples above.

closing this for now. I can reopen if someone wants to discuss further... or feel free to file a new, more specific issue

I think we could address them by adding a new option that makes the no-unused-variable rule skip private class members

Forgive me if I'm misunderstanding, but does that not solve a different problem? Caring whether private variables are unused is different from correctly reporting whether they're unused, yes?
For further clarification, in the below example, waste should be flagged as unused, but done should not be.
class Test {
    private waste: boolean;
    private done: boolean;

    constructor() {
        (function (): void {
            this.doPrivateThing();
            (<Test>this).doPrivateThing();
        }).bind(this)();
    }

    private doPrivateThing(): void {
        this.done = false;
    }
}

ok, I think I see what you mean with the difference between waste and done there... but I don't see a straightforward approach that would correctly mark waste as unused while not also marking doPrivateThing() as unused. any ideas here?
basically the option I've suggested in #614 is a less strict version of the no-unused-variable rule for users who want to use dynamic access of private members/methods at all in their codebase.

Unfortunately I'm not familiar with the tslint codebase, so that brings up a question. Should the following line above should mark doPrivateThing as used?
(<Test>this).doPrivateThing();

...which brings up another question: does tslint know the anonymous function is being executed?
    constructor() {
        (function (): void {
            (<Test>this).doPrivateThing();
        }).bind(this)();
    }

No, we don't do much control flow analysis to know things like "is this anonymous function being executed". I'm hesitant to do that unless we have really good reasons to do so (it complicates the codebase).
(<Test>this).doPrivateThing() is the kind of dynamic access I'm referring to, and I don't even think the compiler recognizes that as a static reference to the private class method (@JKillian -- can you confirm please?). It mainly has to do with Function.prototype.bind, which erases some type information. So if the compiler doesn't count it as a reference, tslint will not do so either.

@JoshuaKGoldberg
There are currently proposals on supporting typing for this, but until then, TSLint won't be able to recognize that this.doPrivateThing(); from your example refers to an instance of Test and is using its method. And you can see why this would be tricky: the this in the function could be anything. (Just as a note, when in a class method, this is typed.)
However, I think (<Test>this).doPrivateThing() should be recognized as a reference to the method by TypeScript and thus and should not be marked as unused by TSLint. Is TSLint marking the method as unused? If so I'll look into it.

@JoshuaKGoldberg If I run TSLint on your example, I get an unused variable warning for waste but not for anything else. This is how it should work, right? :smiley: Are you getting differing results?

However, I think  (this).doPrivateThing()  should be recognized as a reference to the method by TypeScript and thus and should not be marked as unused by TSLint. Is TSLint marking the method as unused? If so I'll look into it.

This was the behavior in July, but I just ran it locally and seems to be working. Thanks for taking the time to look into it, @adidahiya and @JKillian ! Everything seems to be fixed :)

No problem! Always nice when bugs disappear haha