Add ISO8601 Date extension.

I needed more precision for dates on my models saved in the database, so thought it would be best to use ISO 8601 and thought it would be helpful to have in core.
There's also ISO8601DateFormatter introduced in iOS 10, but I'm not sure if this is available?

Codecov Report

Merging #30 into master will increase coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   90.57%   90.84%   +0.26%
==========================================
  Files          28       30       +2
  Lines         658      677      +19
==========================================
+ Hits          596      615      +19
  Misses         62       62

Impacted Files
Coverage Δ

Sources/Core/ISO8601.swift
100% <100%> (ø)

Tests/CoreTests/ISO8601Tests.swift
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 574bd5e...8e96686. Read the comment docs.

I unit tested this on linux and it looks like calendar identifier .iso8601 isn't available.
0  swift            0x00000000035c3c08 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 40
1  swift            0x00000000035c4367
2  libpthread.so.0  0x00007f0a58a05390
3  libFoundation.so 0x00007f0a522c2b02 CFCalendarSetLocale + 18
4  libFoundation.so 0x00007f0a522cc475
5  libFoundation.so 0x00007f0a522cac8a CFLocaleGetValue + 1194
6  libFoundation.so 0x00007f0a522c7cc2 CFDateFormatterCopyProperty + 754
7  libFoundation.so 0x00007f0a522c83f3
8  libFoundation.so 0x00007f0a52465a38 _TTSf4g_n___TFC10Foundation13DateFormatter23_setFormatterAttributesfCSo15CFDateFormatterT_ + 1416
9  libFoundation.so 0x00007f0a5245eb2c _TFC10Foundation13DateFormattergP33_2A990277F300ABF91C2A1D28B045CA0E9_cfObjectCSo15CFDateFormatter + 316
10 libFoundation.so 0x00007f0a5245f095 _TFC10Foundation13DateFormatter6stringfT4fromVS_4Date_SS + 37
11 libFoundation.so 0x00007f0a58d6a0de _TFC10Foundation13DateFormatter6stringfT4fromVS_4Date_SS + 110145646
12 swift            0x0000000000c59ef8 llvm::MCJIT::runFunction(llvm::Function*, llvm::ArrayRef<llvm::GenericValue>) + 808
13 swift            0x0000000000c5d922 llvm::ExecutionEngine::runFunctionAsMain(llvm::Function*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, char const* const*) + 1282
14 swift            0x00000000007f222b swift::RunImmediately(swift::CompilerInstance&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, swift::IRGenOptions&, swift::SILOptions const&) + 2555
15 swift            0x00000000007ea8c7
16 swift            0x00000000007e5b41 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2737
17 swift            0x00000000007ab263 main + 2787
18 libc.so.6        0x00007f0a5711e830 __libc_start_main + 240
19 swift            0x00000000007a8909 _start + 41
Stack dump:
0.	Program arguments: /root/swift-3.0.2-RELEASE-ubuntu16.04/usr/bin/swift -frontend -interpret main.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -color-diagnostics -module-name main

@kgn this looks like it might be nice, but right now, we're a touch apprehensive about including this because some of these date formatters have been a bit unpredictable for various scenarios. You'll be pleased to hear though that we did include them at a higher level we found more predictable, in Node for 2.0. If you're using Vapor, they should be right there available!


webview errors: Report browser version

Description
I have updated the details object to include additional
userAgent property which returns browser version during errors.
Issue(s) linked to this PR
This PR closes #4452
Screenshots
In react-native terminal:

In adb logcat:

In app:

Please review this :D

Thanks @im-adithya ! Merged, with a few tweaks:

I squashed the three commits together, because each one of the changes in them only makes sense combined with the others. (In particular the first commit alone, or the first two commits alone, don't pass our tests.) See discussion of coherent commits here: https://zulip.readthedocs.io/en/latest/contributing/version-control.html
I also rewrote the commit message, to align with our style. See the later part of that same doc, and also our mobile style guide.
I added a commit on top to leave the user-agent out from that red error banner, in part because it actually only shows up in development. (See its commit message for more details.) This also wasn't at all obvious from the code -- it's perfectly reasonable if you didn't notice it was development-only -- so I added some comments in the code to hopefully make that clearer.


We need to login...

...somehow.

+1

@zile-lhs We have disabled the 'Profile Edit' feature from demo, so users can't change the username. Now you can login as usual :
Username<EMAIL_ADDRESS>Password: 12345

Thanks, it's working now.

@zile-hls You're welcome :)


Fix popout widget changing position on second monitor

Changes
Moved deltaLeft and deltaTop calculations after rendering the content. Seems like when the popout widget is on the second monitor left and top values are set correctly only after the content is rendered.
Fixes #896.
Testing
Tested in electron. Regular browsers are not relevant because they will always open the child window on the primary monitor.

@Mergifyio backport release/4.15.x

Hi @ignas-k , do you think we can even backport this to 4.14.x? Would help us out a lot!

@Mergifyio backport release/4.14.x


error of "sh make.sh"

/home/CAD409/teng/faster_rcnn/lib/model/roi_pooling
Including CUDA code.
generating /tmp/tmpCfGCy3/_roi_pooling.c
setting the current directory to '/tmp/tmpCfGCy3'
running build_ext
building '_roi_pooling' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/roi_pooling
creating home/CAD409/teng/faster_rcnn/lib/model/roi_pooling/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _roi_pooling.c -o ./_roi_pooling.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _roi_pooling.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"
^
compilation terminated.
Traceback (most recent call last):
File "build.py", line 36, in
ffi.build()
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 189, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 111, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/usr/lib64/python2.7/site-packages/cffi/api.py", line 697, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/usr/lib64/python2.7/site-packages/cffi/recompiler.py", line 1520, in recompile
compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1
Compiling roi align kernels by nvcc...
In file included from :0:0:
/usr/local/cuda-8.0/bin/../targets/x86_64-linux/include/cuda_runtime.h:78:25: fatal error: host_config.h: No such file or directory
#include "host_config.h"
^
compilation terminated.
/home/CAD409/teng/faster_rcnn/lib/model/roi_align
Including CUDA code.
generating /tmp/tmpW_ee0T/_roi_align.c
setting the current directory to '/tmp/tmpW_ee0T'
running build_ext
building '_roi_align' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/roi_align
creating home/CAD409/teng/faster_rcnn/lib/model/roi_align/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _roi_align.c -o ./_roi_align.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _roi_align.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"
^
compilation terminated.
Traceback (most recent call last):
File "build.py", line 38, in
ffi.build()
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 189, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 111, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/usr/lib64/python2.7/site-packages/cffi/api.py", line 697, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/usr/lib64/python2.7/site-packages/cffi/recompiler.py", line 1520, in recompile
compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1
Compiling roi crop kernels by nvcc...
In file included from :0:0:
/usr/local/cuda-8.0/bin/../targets/x86_64-linux/include/cuda_runtime.h:78:25: fatal error: host_config.h: No such file or directory
#include "host_config.h"
^
compilation terminated.
Including CUDA code.
/home/CAD409/teng/faster_rcnn/lib/model/roi_crop
generating /tmp/tmpvEk43o/_roi_crop.c
setting the current directory to '/tmp/tmpvEk43o'
running build_ext
building '_roi_crop' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/roi_crop
creating home/CAD409/teng/faster_rcnn/lib/model/roi_crop/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _roi_crop.c -o ./_roi_crop.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _roi_crop.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"
^
compilation terminated.
Traceback (most recent call last):
File "build.py", line 36, in
ffi.build()
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 189, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 111, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/usr/lib64/python2.7/site-packages/cffi/api.py", line 697, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/usr/lib64/python2.7/site-packages/cffi/recompiler.py", line 1520, in recompile
compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1
[CAD409@cu03 lib]$ export PATH=$PATH:/usr/local/cuda/bin
[CAD409@cu03 lib]$ sh make.sh
running build_ext
skipping 'model/utils/bbox.c' Cython extension (up-to-date)
skipping 'pycocotools/_mask.c' Cython extension (up-to-date)
Compiling nms kernels by nvcc...
In file included from :0:0:
/usr/local/cuda-8.0/bin/../targets/x86_64-linux/include/cuda_runtime.h:78:25: fatal error: host_config.h: No such file or directory
#include "host_config.h"
^
compilation terminated.
Including CUDA code.
/home/CAD409/teng/faster_rcnn/lib/model/nms
['/home/CAD409/teng/faster_rcnn/lib/model/nms/src/nms_cuda_kernel.cu.o']
generating /tmp/tmpgryUN3/_nms.c
setting the current directory to '/tmp/tmpgryUN3'
running build_ext
building '_nms' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/nms
creating home/CAD409/teng/faster_rcnn/lib/model/nms/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _nms.c -o ./_nms.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _nms.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"
^
compilation terminated.
Traceback (most recent call last):
File "build.py", line 37, in
ffi.build()
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 189, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 111, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/usr/lib64/python2.7/site-packages/cffi/api.py", line 697, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/usr/lib64/python2.7/site-packages/cffi/recompiler.py", line 1520, in recompile
compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1
Compiling roi pooling kernels by nvcc...
In file included from :0:0:
/usr/local/cuda-8.0/bin/../targets/x86_64-linux/include/cuda_runtime.h:78:25: fatal error: host_config.h: No such file or directory
#include "host_config.h"
^
compilation terminated.
/home/CAD409/teng/faster_rcnn/lib/model/roi_pooling
Including CUDA code.
generating /tmp/tmp7WyIQK/_roi_pooling.c
setting the current directory to '/tmp/tmp7WyIQK'
running build_ext
building '_roi_pooling' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/roi_pooling
creating home/CAD409/teng/faster_rcnn/lib/model/roi_pooling/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _roi_pooling.c -o ./_roi_pooling.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _roi_pooling.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"
^
compilation terminated.
Traceback (most recent call last):
File "build.py", line 36, in
ffi.build()
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 189, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 111, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/usr/lib64/python2.7/site-packages/cffi/api.py", line 697, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/usr/lib64/python2.7/site-packages/cffi/recompiler.py", line 1520, in recompile
compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1
Compiling roi align kernels by nvcc...
In file included from :0:0:
/usr/local/cuda-8.0/bin/../targets/x86_64-linux/include/cuda_runtime.h:78:25: fatal error: host_config.h: No such file or directory
#include "host_config.h"
^
compilation terminated.
/home/CAD409/teng/faster_rcnn/lib/model/roi_align
Including CUDA code.
generating /tmp/tmpsssQkW/_roi_align.c
setting the current directory to '/tmp/tmpsssQkW'
running build_ext
building '_roi_align' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/roi_align
creating home/CAD409/teng/faster_rcnn/lib/model/roi_align/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _roi_align.c -o ./_roi_align.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _roi_align.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"
^
compilation terminated.
Traceback (most recent call last):
File "build.py", line 38, in
ffi.build()
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 189, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 111, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/usr/lib64/python2.7/site-packages/cffi/api.py", line 697, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/usr/lib64/python2.7/site-packages/cffi/recompiler.py", line 1520, in recompile
compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1
Compiling roi crop kernels by nvcc...
In file included from :0:0:
/usr/local/cuda-8.0/bin/../targets/x86_64-linux/include/cuda_runtime.h:78:25: fatal error: host_config.h: No such file or directory
#include "host_config.h"
^
compilation terminated.
Including CUDA code.
/home/CAD409/teng/faster_rcnn/lib/model/roi_crop
generating /tmp/tmpN0c8GN/_roi_crop.c
setting the current directory to '/tmp/tmpN0c8GN'
running build_ext
building '_roi_crop' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/roi_crop
creating home/CAD409/teng/faster_rcnn/lib/model/roi_crop/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _roi_crop.c -o ./_roi_crop.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _roi_crop.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"
^
compilation terminated.
Traceback (most recent call last):
File "build.py", line 36, in
ffi.build()
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 189, in build
_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
File "/usr/lib64/python2.7/site-packages/torch/utils/ffi/init.py", line 111, in _build_extension
outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
File "/usr/lib64/python2.7/site-packages/cffi/api.py", line 697, in compile
compiler_verbose=verbose, debug=debug, **kwds)
File "/usr/lib64/python2.7/site-packages/cffi/recompiler.py", line 1520, in recompile
compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 22, in compile
outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
File "/usr/lib64/python2.7/site-packages/cffi/ffiplatform.py", line 58, in _build
raise VerificationError('%s: %s' % (e.class.name, e))
cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1
[CAD409@cu03 lib]$ export PATH=$PATH:/usr/local/cuda/bin
[CAD409@cu03 lib]$ sh make.sh
running build_ext
skipping 'model/utils/bbox.c' Cython extension (up-to-date)
skipping 'pycocotools/_mask.c' Cython extension (up-to-date)
Compiling nms kernels by nvcc...
In file included from :0:0:
/usr/local/cuda-8.0/bin/../targets/x86_64-linux/include/cuda_runtime.h:78:25: fatal error: host_config.h: No such file or directory
#include "host_config.h"
^
compilation terminated.
Including CUDA code.
/home/CAD409/teng/faster_rcnn/lib/model/nms
['/home/CAD409/teng/faster_rcnn/lib/model/nms/src/nms_cuda_kernel.cu.o']
generating /tmp/tmpIG2BnD/_nms.c
setting the current directory to '/tmp/tmpIG2BnD'
running build_ext
building '_nms' extension
creating home
creating home/CAD409
creating home/CAD409/teng
creating home/CAD409/teng/faster_rcnn
creating home/CAD409/teng/faster_rcnn/lib
creating home/CAD409/teng/faster_rcnn/lib/model
creating home/CAD409/teng/faster_rcnn/lib/model/nms
creating home/CAD409/teng/faster_rcnn/lib/model/nms/src
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -std=c99 -fPIC -DWITH_CUDA -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/TH -I/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC -I/usr/local/cuda/include -I/usr/include/python2.7 -c _nms.c -o ./_nms.o -std=c99
In file included from /usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THC.h:4:0,
from _nms.c:493:
/usr/lib64/python2.7/site-packages/torch/utils/ffi/../../lib/include/THC/THCGeneral.h:12:18: fatal error: cuda.h: No such file or directory
#include "cuda.h"

oh,great!
I add some code into make.sh and then all work right~
export PATH=/usr/local/cuda-8.0/bin${PATH:+:${PATH}} export CPATH=/usr/local/cuda-8.0/include${CPATH:+:${CPATH}} export LD_LIBRARY_PATH=/usr/local/cuda-8.0/lib64${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}

i did not work for me.


Irregular images

Thank you for your project, but can the code handle irregular images? Because it is an irregular image, can the irregular parts be filled in with blank space? thanks

Hi!
Based on my understanding of the code algorithm, it does not handle such
images well as the algorithm actually tries to align borders with the x-y
axes, in short it only works on images with perfect rectangles.
Perhaps you may want to try a deep learning approach!
best of luck
regards,
Reiden
On Wed, 20 Sep 2023 at 9:58 AM, rreennyyii @.***> wrote:

Thank you for your project, but can the code handle irregular images?
Because it is an irregular image, can the irregular parts be filled in with
blank space? thanks
[image: image16]
https://user-images.githubusercontent.com/17348519/269134841-db9805bb-3ece-4dda-83ad-4be29a76ee6c.jpg
—
Reply to this email directly, view it on GitHub
https://github.com/reidenong/ComicPanelSegmentation/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APVVZ57U4WNOE6HBQO3Q3IDX3JEULANCNFSM6AAAAAA47E3OTQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


⚠ ClamAV has degraded performance

In 79de76b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 209 ms

Resolved: ClamAV performance has improved in ebb9101.


1.0.0-alpha2: No such property: Date

After updating to Alpha2 I instantly see this error when syncing Gradle files:

No such property: Date for class: org.gradle.api.internal.provider.DefaultPropertyState
Possible solutions: type

This is with Gradle 4.9 and Android Gradle Plugin 3.3.0-alpha07

I figured why I got that error. It was caused by me using old style mapping for custom types. I had to change this
 apollo {     customTypeMapping['Date'] = "java.util.Date"     customTypeMapping['DateTime'] = "java.util.Date" }
to this to get the build running
apollo {     customTypeMapping = [             "Date" : "java.util.Date",             "DateTime" :"java.util.Date"     ] }

Pr appreciated to update Readme 🙂

seems that no one reads readme :)
https://github.com/apollographql/apollo-android#custom-scalar-types

To be fair the new syntax doesn't work with alpha1, that's where I got confused about that


new version of yt-dlp

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
Dear all,
yesterday I got the new version of yt-dlp (option -U) and now I see (in difference to the version before) every position on downloading playlists;
is there an option to suppress the messages of already downloaded files?
Kind regards,
Kurt, Austria
Verbose log
No response

We can't read your mind or see your computer screen. We don't know what command you ran, what error you got or even what you are downloading... Show verbose logs!

How to get a verbose log?
Which option(s)?

Did you even read anything in the issue template?

If your question involves a yt-dlp command, provide the complete verbose output of that command.
Add the -vU flag to your command line you run yt-dlp with (yt-dlp -vU <your command line>), copy the WHOLE output and insert it below.

I hope this will do:
D:\Youtube_al>rem Abenteuer Leben
D:\Youtube_al>yt-dlp -vU --playlist-end 100 --download-archive ..\archive.txt  -i --geo-bypass -o "%(title)s.%(ext)s"  https://www.youtube.com/playlist?list=UUyVg1YLHU6xu-spjmLlC-qA
[debug] Command-line config: ['-vU', '--playlist-end', '100', '--download-archive', '..\archive.txt', '-i', '--geo-bypass', '-o', '%(title)s.%(ext)s', 'https://www.youtube.com/playlist?list=UUyVg1YLHU6xu-spjmLlC-qA']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.05.18 [b14d523] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19044-SP0
[debug] Checking exe version: ffprobe -bsfs
[debug] Checking exe version: ffmpeg -bsfs
[debug] exe versions: ffmpeg git-2020-06-28-4cfcfb3, ffprobe git-2020-06-28-4cfcfb3
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2021.10.08, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Loading archive file '..\archive.txt'
Latest version: 2022.05.18, Current version: 2022.05.18
yt-dlp is up to date (2022.05.18)
[debug] [youtube:tab] Extracting URL: https://www.youtube.com/playlist?list=UUyVg1YLHU6xu-spjmLlC-qA
[youtube:tab] UUyVg1YLHU6xu-spjmLlC-qA: Downloading webpage
[debug] [youtube:tab] Final URL: https://www.youtube.com/playlist?list=UUyVg1YLHU6xu-spjmLlC-qA
[youtube:tab] UUyVg1YLHU6xu-spjmLlC-qA: Downloading API JSON with unavailable videos
[download] Downloading playlist: Uploads from Abenteuer Leben
[youtube:tab] playlist Uploads from Abenteuer Leben: Downloading 100 videos
[download] Downloading video 1 of 100
[download] So schnell wird aus einem Hocker und ein paar Zeitschriftensammlern ein origineller Couchtisch! 😍 has already been recorded in the archive
[download] Downloading video 2 of 100
[download] So verrutscht das Schneidebrettchen beim Schnippeln nie mehr! has already been recorded in the archive
[download] Downloading video 3 of 100
[download] 3 Gänge für 3 Euro?! Budget-Küche vom Profi! | Abenteuer Leben | Kabel Eins has already been recorded in the archive
[download] Downloading video 4 of 100
[download] Cooler Keramik-Look für eure alten Vasen?🍾 #upcycling has already been recorded in the archive
[download] Downloading video 5 of 100
[download] Der perfekte Liebesbeweis für eure Männer❤ has already been recorded in the archive
[download] Downloading video 6 of 100
[download] Das Quäntchen mehr Geschmack - Pastagerichte | Abenteuer Leben | Kabel Eins has already been recorded in the archive
[

I don't see any diff with older versions. What exactly is the issue?

I tried with version 2022.04.08, which is much more quicker than version 2022.05.18; maybe because the new version changes colors (in every line 'video x of y' the 'x' to green and the 'y' to blue)?

https://github.com/yt-dlp/yt-dlp/issues/3786

How can I use/implement functools.cache (mentioned in #3786)??
Or is it integrated in the next version?
Kind regards
Kurt (Austria)

You can try to compile it yourself or install using PIP if you are able to follow the instructions. Otherwise, wait for new release


Fix configuration name for other players, add option to disable chat recolour

Add option to disable recolouring of player names in chat based on
player indicators configuration
Fix name of confifugration property to configure colors of other
players.

Preview:

See #1226


Import JS into theme and have it build

Is there a way to convert a theme over to slate?
I am trying to get brooklyn/narrative theme over to slate but can't seem to convert.
I mainly run into issues when trying to move over the scripts and styles over. Is there proper documentation on how to do so?
For example I am trying to convert the following into the new templating style.
  <!--[if (gt IE 9)|!(IE)]><!--><script src="{{ 'theme.min.js' | asset_url }}" defer="defer"></script><!--<![endif]-->
  <!--[if lte IE 9]><script src="{{ 'theme.min.js' | asset_url }}"></script><![endif]-->

I removed it completely from the theme.liquid and instead I am doing
   import './theme.min.js';
within the index.js file within templates folder. but i receive error

"Uncaught TypeError: Cannot read property 'loaded' of null"

There's an issue open on migrating to Slate v1, you can continue the discussion there : https://github.com/Shopify/slate/issues/542

I am trying to get brooklyn/narrative theme over to slate but can't seem to convert.

Brooklyn and Narrative are not open sourced and there are no plans to convert them to Slate v1 at the moment. Also, as you only get the dist folder, you won't easily be able to convert the theme to Slate.


Document the auto-sizing height of modals

We want to at least call out the fact that the height is auto-sized.
The wording here might not be the clearest. If there's a different way
to phrase this explanation, we can definitely change to that.
SDK PR: https://github.com/DataDog/ui-extensions-sdk/pull/55.

Thanks for the review!


Support Tuple and Dict spaces

If the obs_space of an environment is a spaces.Tuple, then DummyVecEnc breaks.
class DummyVecEnv(VecEnv):
    def __init__(self, env_fns):
        self.envs = [fn() for fn in env_fns]
        env = self.envs[0]
        VecEnv.__init__(self, len(env_fns), env.observation_space, env.action_space)
        obs_space = env.observation_space

        self.keys, shapes, dtypes = obs_space_info(obs_space)
        self.buf_obs = { k: np.zeros((self.num_envs,) + tuple(shapes[k]), dtype=dtypes[k]) for k in self.keys }

This breaks because self.keys is None. This happens when obs_space is spaces.Tuple, given that spaces.Tuple is not instance of spaces.Dict, and therefore obs_space_info returns [None], {None: None}, {None: None}.
So, I'm not sure how to use the DummyVecEnv now...

OMG. I just found this (undocumented) feature ->
A dictionary of simpler spaces.

    Example usage:
    self.observation_space = spaces.Dict({"position": spaces.Discrete(2), "velocity": spaces.Discrete(3)})

    Example usage [nested]:
    self.nested_observation_space = spaces.Dict({
        'sensors':  spaces.Dict({
            'position': spaces.Box(low=-100, high=100, shape=(3)),
            'velocity': spaces.Box(low=-1, high=1, shape=(3)),
            'front_cam': spaces.Tuple((
                spaces.Box(low=0, high=1, shape=(10, 10, 3)),
                spaces.Box(low=0, high=1, shape=(10, 10, 3))
            )),
            'rear_cam': spaces.Box(low=0, high=1, shape=(10, 10, 3)),
        }),
        'ext_controller': spaces.MultiDiscrete([ [0,4], [0,1], [0,1] ]),
        'inner_state':spaces.Dict({
            'charge': spaces.Discrete(100),
            'system_checks': spaces.MultiBinary(10),
            'job_status': spaces.Dict({
                'task': spaces.Discrete(5),
                'progress': spaces.Box(low=0, high=100, shape=()),
            })
        })
    })

I mean, am I so dumb that I missed it on the documentation, or this was just an undocumented piece of code?

Alright, spaces.Dict are also not supported. I've patched it.
If anyone is interested, here's my patch.
https://github.com/Atcold/baselines/commit/fd2203f4e4c9e7c0f42234acc974b24725f48b04

yes, support for Tuple and Dict spaces is on our TODO list (as of now the status is that they are not supported). I'll rename this accordingly and keep it open; @Atcold, feel free to make a PR with the patch :)

Yeah, I think Tuples are unnecessary, if you can pass Dicts.
And the patch I wrote is for my specific case, where I output a Dict observation. I was not caring about backcompatibility.

https://github.com/openai/baselines/pull/911 patches this Tuples


refactor: Frontend Directory Structure and Routes

🍰 Pullrequest
Clean up frontend subfolders, try to have consistent naming.
Issues

fixes #1565

Todo

[ ] Test that everything is working as expected

i have looked through it and looked at every changed page and i have pulled the PR and had it running successfully.
So far everything is ok from my point of view.

@ulfgebhardt The route changed affected by the emails is set in the backend. I tried it.


Yo @VilliansRule4000 you good bro?

Every day I see more and more useless issues, and everything seems like it is falling apart?

Also is he the real gliz who coded all of this or are these people lying?

I don't run this. Answering issues is a hobby. I cannot close issues, only answer them.
I am unsure if this is the real gliz.

Hey btw my old name was sdkhfgvwierg you might remember me I try to help people find blooket hacks now but no one looks at my repository you should check it out!


[improve] [broker] Upgrade the BookKeeper dependency to 4.16.0

Fixes #xyz

Master Issue: #xyz

PIP: #xyz

Motivation
Upgrade the BookKeeper dependency to 4.16.0
Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #20049 (e0162dc) into master (329e80b) will increase coverage by 11.38%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #20049       +/-   ##
=============================================
+ Coverage     61.50%   72.88%   +11.38%
- Complexity    25755    31660     +5905
=============================================
  Files          1859     1858        -1
  Lines        136792   137516      +724
  Branches      15043    15124       +81
=============================================
+ Hits          84129   100224    +16095
+ Misses        44857    29325    -15532
- Partials       7806     7967      +161

Flag
Coverage Δ

inttests
24.40% <0.00%> (-0.08%)
:arrow_down:

systests
24.83% <0.00%> (-0.19%)
:arrow_down:

unittests
72.18% <0.00%> (+13.53%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ker/stats/prometheus/metrics/LongAdderCounter.java
0.00% <0.00%> (ø)

...lsar/sql/presto/PulsarConnectorMetricsTracker.java
30.82% <0.00%> (ø)

... and 652 files with indirect coverage changes

/pulsarbot rerun-failure-checks


1.9: --fixed-cidr seems to be broken

Run the following to setup DIND:
docker run --privileged -v $(which docker):/usr/bin/docker -v /etc/ssl/certs/ca-certificates.crt:/etc/ssl/certs/ca-certificates.crt -it busybox

Then in the container run
brctl addbr docker0
ip link add '<IP_ADDRESS>/16' dev docker0
ip link set dev docker0 up
docker daemon -D --fixed-cidr "<IP_ADDRESS>/16" -s vfs

This results in the below failure
DEBU[0000] Warning: could not change group /var/run/docker.sock to docker: Group docker not found
DEBU[0000] Server created for HTTP on unix (/var/run/docker.sock)
DEBU[0000] [graphdriver] trying provided driver "vfs"
DEBU[0000] Using graph driver vfs
DEBU[0000] Using default logging driver json-file
DEBU[0000] Creating images graph
DEBU[0000] Restored 0 elements
DEBU[0000] Creating repository list
DEBU[0000] Option DefaultDriver: bridge
DEBU[0000] Option DefaultNetwork: bridge
INFO[0000] API listen on /var/run/docker.sock
WARN[0000] Running modprobe bridge br_netfilter failed with message: modprobe: can't change directory to '/lib/modules': No such file or directory
, error: exit status 1
WARN[0000] Running modprobe nf_nat failed with message: `modprobe: can't change directory to '/lib/modules': No such file or directory`, error: exit status 1
DEBU[0000] Fail to initialize firewalld: Failed to connect to D-Bus system bus: dial unix /var/run/dbus/system_bus_socket: no such file or directory, using raw iptables instead
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -D PREROUTING -m addrtype --dst-type LOCAL -j DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -D OUTPUT -m addrtype --dst-type LOCAL ! --dst <IP_ADDRESS>/8 -j DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -D OUTPUT -m addrtype --dst-type LOCAL -j DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -D PREROUTING]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -D OUTPUT]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -F DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -X DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -n -L DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t nat -N DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t filter -n -L DOCKER]
DEBU[0000] /usr/sbin/iptables, [--wait -t filter -N DOCKER]
DEBU[0000] Registering ipam provider: default
DEBU[0000] Allocating IPv4 pools for network bridge (4ba652e9bbfcb90074b4ea7ab2822272eb130f2caf667b9408b970023399951c)
DEBU[0000] RequestPool(LocalDefault, <IP_ADDRESS>/16, <IP_ADDRESS>/16, map[], false)
DEBU[0000] RequestAddress(LocalDefault/<IP_ADDRESS>/16/<IP_ADDRESS>/16, <nil>, map[])
DEBU[0000] ReleasePool(LocalDefault/<IP_ADDRESS>/16/<IP_ADDRESS>/16)
DEBU[0000] Cleaning up old shm/mqueue mounts: start.
FATA[0000] Error starting daemon: Error initializing network controller: Error creating default "bridge" network: failed to allocate gateway (): No available addresses on this pool

@mavenugo @aboch

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@ibuildthecloud --fixed-cidr is not broken entirely. its the case of fixed-cidr occupying the full-range. Its fixed now in libnetwork and is being vendored in : https://github.com/docker/libnetwork/pull/697.
As we vendor in the change, Can you please confirm by reducing the fixed-cidr range to not occupy the entire bridge subnet range ?


Feature request: Support markdown links

I recently starting using Mark Headboard. I love the simplicity and elegance!
It would be great if the cards could be markdown links. I'd like to be able to add each card as a link to a project page, followed by a list of checkbox items for that project.
For example:
Todo
proj3
Doing
proj2

[ ] do this
[ ] do that

Done
proj1

[x] do this

Thanks! Yes, I'd like for it to recognize when the card titles are/contain links. This does present a bit of a UI dilemma though, because currently clicking on the card takes you to that section of the markdown document, which is an important feature for me and I'd still want to be able to do that if the card title is a link. Perhaps clicking on the link text should open the link, while clicking within the card but outside the text should open the markdown file?

Thanks! Yes, I'd like for it to recognize when the card titles are/contain links. This does present a bit of a UI dilemma though, because currently clicking on the card takes you to that section of the markdown document, which is an important feature for me and I'd still want to be able to do that if the card title is a link. Perhaps clicking on the link text should open the link, while clicking within the card but outside the text should open the markdown file?

Alternatively, you could require a modifier key for following the link (e.g. option + click).

Alternatively, you could require a modifier key for following the link (e.g. option + click).

Released a rough version of this in 1.1.0. Currently only supports the [title](href) link syntax, and it's parsed via regex and won't handle stuff like escape characters right.
I liked the key modifier idea & went with that. It uses the javascript event metaKey property; on Mac, that corresponds to the command key. Let me know if that doesn't work on your platform.

I installed v1.1.0 and tried it out but I haven't been able to get it to follow an embedded link.
When I embed a link in a card (i.e. the second-level title in the markdown file) I can see the link icon on the card, and it shows the correct path when I hover over it, but Cmd-Click (I'm also using a Mac) doesn't follow it.

A regular click (no modifier) takes me to the correct location in the markdown file as expected
Cmd-Click behaves like a regular click on cards without links, but does nothing on cards with links
I also tried Opt-Click, which behaves the same as a regular click

When I embed a link in a column title (i.e. the first-level heading in the markdown file) I don't see a link icon, and hovering over it doesn't display anything. But if I edit the link while the board is open to the side, I can see that the text is being parsed as a link as I edit it.
I'm using traditional title links with relative paths. When I following the link in the markdown file (with Opt-Click) it takes me to the correct file so I know the link isn't broken. I also tried disabling all but the Mark Headboard extension in case other extensions were interfering with it. Is there anything else I can try to help debug this?

@rjgibson OK, I think the links aren't opening for you because they're relative paths. I used VSCode's openExternal function, which is for opening URLs in the browser etc. For relative paths, am I correct to assume that you want to open the linked file in VS Code itself? I should be able to make that change pretty easily.
Regarding the link icon/hovertext not showing on first-level headings, can you test with the following file? For me, both the column and the card get the link icon and can be opened with command-click.
# [Google](http://google.com)

## [Also Google](http://google.com)

That's it: FQDN's work; relative links don't. I also see the icon/hovertext on the first-level heading now. I think I missed it before because the rendered view seems to lag, or doesn't sync, with the markdown file in that respect. If I change the markdown link, the rendered view on the Board doesn't show the update when I hover over it, despite writing out the markdown file -- I have to close the Board and reopen it. This only appears to be a problem for first-level headings, though.
Yes, I'm hoping to be able to open relative links in VS Code. The idea is to have a todo file where each second-level header is a relative link to a project file in the same workspace. That way I can click on any todo item to get more information about it.

OK, I think those issues are fixed in 1.2.0.
This probably still needs a little refinement though because the links open in the same pane as the board - so if it's a split-screen view with the board on the right, the linked file opens in a tab on the right. That doesn't seem intuitive to me, though I'm not sure what the best way for it to decide where to open it is.

Looks good, thanks!
Regarding the problem of the link opening up in the tab on the right, I see that the VS Code Window class includes an activeTextEditor variable. While I'm not familiar with the VS Code API, I wonder if there might be a way to save the active editor at the time the user runs Open as Board to the Side and then switch focus to it when following any links from the Board.


Model relinquished instances as a separate state from not-ready

Instances become relinquished when the object they wrap has its ownership transferred to a C++ unique_ptr. Unlike ready instances, they can't be validly accessed (because the C++ object might have been destroyed without our knowledge). Unlike non-ready instances, they can't be validly constructed (because the C++ object might still be within its lifetime). They need a new state. This PR handles them by expanding the previous nb_inst::ready flag into a two-bit field nb_inst::state. Due to a careful choice of which number represents which state, this should have negligible overhead.
Fixes #550.

Awesome, this looks great!


⚠ ClamAV has degraded performance

In 0d09b89, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 414 ms

Resolved: ClamAV performance has improved in 40eaf91.


Creational methods : add support for ranges

LazyFutureStream.range(1,10);
LazyFutureStream.range(1L,10L);
LazyFutureStream.rangeBetween(1.00d,10.00d).withStep(0.05);

Released in 0.95 for simple ranges. Others are possible via primitive Stream types.


Rendering board as ascii

Ideally something like jira board which would yield some ascii generated table showing all the lines and where tickets are currently positioned.

Good idea, I agree this would be useful, however most of the apis dealing with sprint boards are pretty fussy to use.  I would find this command useful myself, so I may get around to it, but I am very limited on time.


v0.8.8_19: Scroll bar is missing on data warning pop up

SEVERITY: Minor
MODULE:  Bubble Chart
Platform: iPhone-4G(iOS 7.1.2)/ Safari
RELEASE: v0.8.8
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.8.8/preview/bubblechart.html
Bubble chart page will be loaded
Tap Data warning which is available on the right bottom of the chart
Small pop up screen is displayed
Note that scroll bar is missing on data warning pop up

ACTUAL RESULTS:
Scroll bar is missing on data warning pop up
EXPECTED RESULTS:
Scroll bar should be available on data warning pop up
SCREENSHOT:

I think our scrollbars are never shown on ios. Can someone double check how we can solve?

i should have fixed it now, although it's a blind shot as i have no iOS


Update Harper's book link

Original link returned 404. Source is Robert Harper's homepage: http://www.cs.cmu.edu/~rwh/

@mdsn Thank you very much! :+1: :dog:


Maya:  Bug - Frame range validation repair action for Layout with Review

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:
When creating Review for Layout, validate_frame_range validator repair action is looking for frame information on Layout instance instead of Review.
Expected Behavior:
Repair action should set the correct range on Review instance instead.
Version
3.17.3
What platform you are running OpenPype on?
Linux / Centos
Steps To Reproduce:

Create Layout instance
Create Review instance
Nest Layout under Review
Set incorrect frame range to trigger validator
Publish
Hit repair on failed frame range validator

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:
File "/mnt/studio/openpype-3-17-3/openpype/hosts/maya/plugins/publish/validate_frame_range.py", line 145, in repair
    cmds.setAttr("{}.frameStart".format(node), frame_start_handle)
RuntimeError: setAttr: No object matches name: layoutMain.frameStart

Additional context:
No response

Is this the same issue as any of these:

https://github.com/ynput/OpenPype/issues/5495
https://github.com/ynput/OpenPype/issues/4857
https://github.com/ynput/OpenPype/issues/4850

If so, fixing that might just solve a lot of issues at once hah!


exception handler draft

Btw @tanvirriyad please also take a look on those failing tests (pre-commit and unit-tests). The benchmarking job is expected to fail

Btw @tanvirriyad please also take a look on those failing tests (pre-commit and unit-tests). The benchmarking job is expected to fail

I looked at pre-commit failure. It happened for some docstring issues. I updated those. One unit test is failing because of return type issues.

Thanks Riyad, you are on the right track!
Btw, this part only takes care of exceptions thrown by event handlers. Client errors like in rx.call_script are still not handled. However, that's not as trivial to implement. If you want to collect some bonus points, also catch those errors and send them back to the backend. If you do not fully understand this, no worries, I am always here to answer all your questions or create an example for you.

I have a small question regarding rx.call_script(). this function executes front-end code, right? when a user writes frontend code, they would be able to pass a custom exception handler as an argument like rx.App()?

Thanks Riyad, you are on the right track!
Btw, this part only takes care of exceptions thrown by event handlers. Client errors like in rx.call_script are still not handled. However, that's not as trivial to implement. If you want to collect some bonus points, also catch those errors and send them back to the backend. If you do not fully understand this, no worries, I am always here to answer all your questions or create an example for you.

I have a small question regarding rx.call_script(). this function executes front-end code, right? when a user writes frontend code, they would be able to pass a custom exception handler as an argument like rx.App()?

I wanted to review your changes later this evening, but since you seem to be interested in the rx.call_script exception handling, I will give you some hints.
Here are the related reflex docs: https://reflex.dev/docs/api-reference/browser_javascript/#inline-scripts
rx.call_script is used to trigger JavaScript execution from the backend. You can use it in event handlers, reflex then sends the script over websockets to the client and executes it.
That's why your implementation will not work. There are no python exceptions to try/catch, the exceptions happen in the client's browser.
This is an example reflex app which throws such an error in the frontend. You can just run it, open your chrome dev tools and checkout the JS console while pressing the test button.
import reflex as rx

class State(rx.State):
    def test_handler(self):
        print("test_handler called")
        yield rx.call_script("error")

def index() -> rx.Component:
    return rx.button(
        "Test",
        on_click=State.test_handler,  # type: ignore
    )

app = rx.App()
app.add_page(index)
```

As already mentioned the implementation is not trivial, you would have to send this error to the backend and pass it to the exception handler there.


Setting the Occluder slot of a Single Tile to "New OccluderPolygon2D" crashes the Tile Editor, when trying to access the Occlusion Tab in Tileset Editor

Godot version:

Godot v3.1 alpha 2
OS/device including version:

Windows 10
UHD Graphics 630
Issue description:

I set the occluderPolygon2D Slot of a single Tile to new OccluderPolygon2D.
Afterwards I tried to edit the Occluder of the Tile in the Tileset-Editor.
Godot crashed with the attached ERROR Messages.
Steps to reproduce:
Set the Occluder Attribute of an existing Tile to new OccluderPolygon2D.
Open the Tileset Editor and try to access the Occluder Tab for that Tile.
Even accessing the Tile afterwards in the Editor crashes my Project.
Minimal reproduction project:

LD_43_Soulchange.zip

You are not suposed to set any oclusion, collision or navigation polygon directly with the editor, i'm not even sure why these properties are displayed on the inspector to start with...

Yeah, I know that this by now and if I do not do that everything works fine.
On the other hand, I guess that's the advantage if a Noob like me gets his hands on a new Engine.

This way you discover Bug a Pro wouldn't, I guess ;-)

yeah, i was not blaming, i was thinking outloud

I'm fine. I didn't feel blamed :-)
Just reminded me how we assured quality management for questionnaires
by also clicking randomly the answers, that made no sense.

@DocoDan @akien-mga i can't reproduce this error anymore, can you confirm?

I can still reproduce it in a1e73dcc9.

Click TileMap node, expand TileSet resource
Add new OccluderPolygon2D to tile 0 (Tile_1)
Open TileSet editor
Click tile 0 (the only tile in the MRP)
Select the "Occlusion" tab, crash

ERROR: canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers/visual/visual_server_canvas.cpp:727.
ERROR: get: FATAL: Index p_index=0 out of size (size()=0)
   At: ./core/cowdata.h:151.

Thread 1 "godot-git" received signal SIGILL, Illegal instruction.
0x0000000001218de2 in CowData<Vector2>::get (this=0x7fffffffbfc8, p_index=0) at ./core/cowdata.h:151
151                     CRASH_BAD_INDEX(p_index, size());

(gdb) bt
#0  0x0000000001218de2 in CowData<Vector2>::get (this=0x7fffffffbfc8, p_index=0) at ./core/cowdata.h:151
#1  0x000000000121790c in Vector<Vector2>::operator[] (this=0x7fffffffbfc0, p_index=0) at ./core/vector.h:85
#2  0x0000000002211d75 in TileSetEditor::draw_polygon_shapes (this=0x9fe6bf0) at editor/plugins/tile_set_editor_plugin.cpp:2466
#3  0x00000000021f668d in TileSetEditor::_on_workspace_draw (this=0x9fe6bf0) at editor/plugins/tile_set_editor_plugin.cpp:880
#4  0x00000000012544eb in MethodBind0::call (this=0xa097af0, p_object=0x9fe6bf0, p_args=0x7fffffffccc0, p_arg_count=0, r_error=...) at ./core/method_bind.gen.inc:54
#5  0x0000000003169517 in Object::call (this=0x9fe6bf0, p_method=..., p_args=0x7fffffffccc0, p_argcount=0, r_error=...) at core/object.cpp:943
#6  0x000000000316ad98 in Object::emit_signal (this=0xa024fa0, p_name=..., p_args=0x7fffffffccc0, p_argcount=0) at core/object.cpp:1229
#7  0x000000000316b407 in Object::emit_signal (this=0xa024fa0, p_name=..., p_arg1=..., p_arg2=..., p_arg3=..., p_arg4=..., p_arg5=...) at core/object.cpp:1285
#8  0x00000000028fa492 in CanvasItem::_update_callback (this=0xa024fa0) at scene/2d/canvas_item.cpp:455
#9  0x00000000012544eb in MethodBind0::call (this=0x5a15ee0, p_object=0xa024fa0, p_args=0x0, p_arg_count=0, r_error=...) at ./core/method_bind.gen.inc:54
#10 0x0000000003169517 in Object::call (this=0xa024fa0, p_method=..., p_args=0x0, p_argcount=0, r_error=...) at core/object.cpp:943
#11 0x0000000003160107 in MessageQueue::_call_function (this=0x4acf370, p_target=0xa024fa0, p_func=..., p_args=0x7ffff6f52050, p_argcount=0, p_show_error=false)
    at core/message_queue.cpp:256
#12 0x00000000031603a6 in MessageQueue::flush (this=0x4acf370) at core/message_queue.cpp:303
#13 0x00000000024dcb33 in SceneTree::iteration (this=0x5ea0920, p_time=0.0166666675) at scene/main/scene_tree.cpp:476
#14 0x00000000011f2683 in Main::iteration () at main/main.cpp:1861
#15 0x00000000011c6aed in OS_X11::run (this=0x7fffffffd2f0) at platform/x11/os_x11.cpp:3006
#16 0x00000000011b852d in main (argc=2, argv=0x7fffffffda78) at platform/x11/godot_x11.cpp:55


Update README.md - phrack link

WebArchive of http://www.phrack.org/issues/70/3.html#article

Ah thanks, this is because the article has moved out of the "paper feed" and into the real release. The new URL is http://www.phrack.org/issues/70/3.html#article do you want to update this PR? Otherwise I can also change the URL. Let me know!


Undeploy

shell_manager undeploy has a few bugs, I'm gonna start working on it just wanted to document them.

Calling undeploy with an incorrect number of instances leaves orphaned instances that cannot be removed.
A. Deploy -n 3 NAME
B. undeploy NAME
C. undeploy -n 2 NAME
Both B and C leave orphaned instances that cannot be removed using deploy.

If undeploy is given the correct number of instances, it is correctly removed from the problems directory, but shell_manager status shows the problem with 0 instances.
A. Deploy -n 3 NAME
B. undeploy -n 3 NAME

Following from 2, if there are 0 instances of a problem, and load deployment is selected from the management tab, the problems aren't removed from the deployment. It does not install the question again, the number of problems installed decreases, but the problem remains available on the platform.

Hey, thanks for submitting this. For the first two issues, I think there is some misunderstanding.
The -n flag is perhaps misnamed, because it actually means "the range of instances IDs from 0 to n-1". The behavior you are seeing in the first issue is actually expected.
Also, the instances aren't orphaned. They can still be undeployed using the -i [ID] option.
For the second issue, note that status will list all installed problems and their corresponding instances. A problem is considered installed if the debian package for it has been installed (and the source code is placed under /opt/hacksports/sources). Even if a problem has zero deployed instances, it is still considered installed.
The last issue is an issue that we may need to fix. In more detail, this is happening because the web server loads the instances using the shell_manager publish command, which only includes problems that have instances. I see two possible solutions to this:

On the web server, we can detect that a problem is no longer being supplied by the shell server, and remove all instances of it that are from that server.
We can make publish include problems that have zero instances.

In either case, we should not remove the problem itself from the database, but instead empty its instance list. The web server code currently depends too heavily on the problems always existing. We'll have to treat problems with an empty instance list the same as disabled problems.
Until we fix this, a workaround is to disable the problem on the admin page, and it will be treated as though it was removed.
Thanks again for reporting these!

After thinking a bit more, perhaps a clean fix would be to automatically disable problems that have zero instances, and reject any attempts to enable them until instances are added.

I would prefer option 2 of Tim's suggested workarounds (publishing zero instance problems). I think it makes a lot of sense to disable problems that have zero instances. Though I'm not sure what "disabling" should mean.
Problems are either enabled or disabled and stay visible to the admin management page. I would argue a problem with 0 instances should be hidden from view and implicitly disabled, i.e.
hidden? len(problem["instances"]) == 0
disabled? problem["disabled"] or hidden?
This should also affect bundle visibility. A bundle is included iff there exists some published problem in that bundle. This can easily be modified to a bundle is included iff there exists some published problem with non-zero instances in that bundle. I believe that change should be sufficient.


Uninstall previous versions when updating

Feature Request
When installing the newest update for AMP it doesn't remove previous versions, so I then have to go and uninstall each version individually. It would be helpful for the installer to check for previous versions and if there is uninstall them before installing the new one.
I confirm:

[x] that I have searched for an existing feature request matching the description.

Do multiple versions show up in Add/Remove programs? I'm assuming you're on Windows here.

Yes I am on windows. Yeah I had about 5 versions showing in my program list, before I manually uninstalled previous ones that is.

This should be addressed as of the <IP_ADDRESS> release.


nixos/php: init new php module for command line usage

Motivation for this change
Currently no convenient way to set php.ini system wide while invoking php from the command line.
Example usage:
programs.php.enable = true;
programs.php.phpPackage = pkgs.php71;
programs.php.phpOptions = ''
extension=${pkgs.php71Packages.mailparse}/lib/php/extensions/mailparse.so
'';
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I'm maybe a outsider on this opinion, but I'd be more in favor of someone just using environment.etc."php.ini".text to set their PHP config options than make a wrapper and module.

@grahamc my concern with that approach was that maybe httpd and phpfpm would read that configuration as well which would obviously have problems if you're mixing and matching php versions between httpd, phpfpm, and command line php.
I'll check if this if the case or not and report back.

@grahamc yeah so I tested mod_php and it didn't pickup any php configuration from /etc. So I guess I'm indifferent to this PR.
Thanks

@grahamc spoke too soon... mod_php actually did read in config from /etc so I'm back to thinking this PR is a good idea because the environment.etc way "pollutes" at least mod_php, if not php-fpm as well. As of 19.03 I believe php-fpm even explicitly supports running multiple versions of php concurrently so especially if php-fpm is picking up files in /etc this would be bad.

Just out of interest: wouldn't it make more sense to solve this on a package-level?
So basically something like this:
php.override {
  config = writeText "php.ini" ''
    ; php cfg
  '';
}

At least this is (more or less) what I'm currently doing for me PHP installation: https://gitlab.com/Ma27/nixexprs/blob/master/pkgs/php/overlay.nix

@Ma27 Recompiling php and all the extensions you use because you want to make a minor adjustment to your php.ini file doesn't sound fun.
Now you've got me interested... what benefit are you getting from recompiling php every time you need to change a runtime option?

I don't recompile PHP all the time, all changes are happening in a symlinkJoin (well, except for my custom configure flags). The main benefit from this IMHO is that this feature isn't tied to NixOS.
You could implement this as well in nixpkgs by adding e.g. a wrapper.nix which contains the symlinkJoin expression and reference the default.nix as php-unwrapped (to ensure that the PHP package itself is still overridable). An example for this approach is the rofi package in ./pkgs/applications/misc/rofi.
But don't get me wrong, this is mainly a suggestion how I'd like to prefer this (as someone using PHP quite regularly in my job currently), it's still possible that other maitainers disagree with me :)

Ah I see! That makes sense. Thanks for explaining.

To summarize so far there are 3 proposed solutions for providing a php.ini file to command line php:

environment.etc."php.d/php.ini".text = data;

This has the issue that it is applied to all instances of php on the system, regardless of version. phpfpm can run multiple versions of php at the same time so you wouldn't be able to put anything version specific in this. Basically introduces side effects and moves away from reproducibility in some cases.

Add a phpIni type option to the php package so you can call php.override { phpIni = data; }

This is a nice solution. It has added benefit that it can be used on anything (mod_php, phpfpm, cli). The downside is that it is inconsistent with how every other instance of php works in NixOS, as in both mod_php and phpfpm already have phpOptions.

What was originally proposed in this PR.

I still like my approach the best as it is consistent with the existing NixOS infrastructure.
Simply so this PR doesn't stagnate I'd love to get some direction on which way to go with this.

I'd vote for solution number 2, but as I said I might be missing some implications. Before somebody actually invests time to implements that, I'd like to hear the opinions from some more PHP users or package maintainers (i.e. @grahamc and @etu).g

Wouldn't number 2 cause a rebuild of PHP each time since the inputs are changed?
Personally I like the overlay that @Ma27 linked that just wraps PHP with a custom file pointed out since that won't cause any rebuilds.
But at the same time it would be nice to have something more discoverable than creating a wrapper package by your own, which works for the more experienced nix user, which number 3 provides. But that one also have issues mentioned, like if you want to use more than one version of PHP.
But then number 1 have even bigger issues, like if you define modules that are incompatible with older versions of PHP and then you launch an older version of PHP in a nix-shell which may break or so.
I think I'm mostly happy with some kind of wrapper package (like number 2) where you can provide the php derivation and additional configuration wrapped in. Then that derivation can be discoverable in searches and just 2 parameters to override to switch version of PHP and change the ini-file. And it won't cause rebuilds.

@etu sorry when explaining #2 i meant to say php wrapper package, as explained by @Ma27 in his link.
The more I think about this the more I think this conversation should be merged with https://github.com/NixOS/nixpkgs/issues/24432
I'm going to close this PR as some good working solutions have been provided.

Wouldn't number 2 cause a rebuild of PHP each time since the inputs are changed?

Not necessarily. If such an option is set, the expression can return a symlinkJoined environment rather than the PHP derivation itself.

@Ma27 are you interested in putting together a PR for your symlinkJoin method? :smile:

Yeah, why not actaully :)

Thank you!

@Ma27 ping. Any chance for 20.03? :smile:


[Storage][DataMovement] Refactor job completion logic to fix eventing

This change slightly refactors the logic we use to determine if a job is completed by adding a pending job part count that is incremented when jobs are added and decremented only when we get the status change event from the job part. Then, we only set the terminal job status once the pending job part count has reached zero.
Additionally, this change refactors the logic for setting the terminal job status to only iterate the list of job parts once (rather than the many iterations previously). Arguably this code looks a little uglier but should be far more efficient if the number of job parts is high.
Also enabled previously disabled check around eventing in tests since this change should fix that flakiness.

/azp run net - storage - tests

/azp run net - storage - tests

/azp run net - storage - tests

/azp run net - storage - tests

/check-enforcer override


new version and changes

Please provide some feedback

Coverage decreased (-0.02%) to 36.137% when pulling 7db9a110cbeca4123314b9307efd7bb539157c08 on simontorres:new_version_number into 3de240e637310eed728b1403b3d132a4e86118a5 on soar-telescope:master.


In_tail doesnt work as expected and causes dropped logs

Describe the bug
We are using fluentd with in_tail to foward our logs to other services. However, we are seeing an issue where after a log rotation, in_tail stops working and causes missing logs.
I see the following in the current reading position when the issue occurs:
/var/log/containers/file.log     ffffffffffffffff<PHONE_NUMBER>1bba10
To Reproduce
Doesn't happen always. Just randomly.
Expected behavior
After log rotation, the tail functionality should work properly and update the correct reading position which will result in no loss of logs.
Your Environment
- Fluentd version: 1.15.3
- Package version: td-agent version: 4.4.2
- Operating system: Ubuntu
- Kernel version:

Your Configuration
<source>
  @type tail
  path /var/log/containers/*.log
  exclude_path ["/var/log/containers/geneva-services*.log", "/var/log/containers/prom-mdm-converter*.log"]
  pos_file /var/log/fluentd-containers.log.pos
  tag kubernetes.*
  read_from_head true
  follow_inodes true
  <parse>
    # Reads logs in CRI format for Kubernetes v1.19+
    # The CRI format is documented here: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/kubelet-cri-logging.md
    @type regexp
    expression /^(?<time>.+) (?<stream>stdout|stderr)( (?<logtag>.))? (?<log>.*)$/
    time_format '%Y-%m-%dT%H:%M:%S.%N%:z'
    keep_time_key true
  </parse>
</source>

Your Error Log
In fluentd-containers.log.pos file:
/var/log/containers/file.log     ffffffffffffffff<PHONE_NUMBER>1bba10

Fluentd logs:
2024-10-14T19:33:21.803662079Z stdout F 2024-10-14 19:33:21 +0000 [info]: #0 following tail of /var/log/containers/file.log
2024-10-14T19:33:22.256006681Z stdout F 2024-10-14 19:33:22 +0000 [info]: #0 detected rotation of /var/log/containers/file.log; waiting 5 seconds
2024-10-14T19:33:25.844191091Z stdout F 2024-10-14 19:33:25 +0000 [info]: Exception encountered parsing namespace watch event. The connection might have been closed. Sleeping for 1 seconds and resetting the namespace watcher.error reading from socket: Connection reset by peer

Additional context
No response

It seems a known bug and we believe it's already fixed in v1.16.3 or later:
https://github.com/fluent/fluentd/releases/tag/v1.16.2
https://github.com/fluent/fluentd/releases/tag/v1.16.3
Could you try latest version?

So I close this for now.
Please let us know if you have similar issue with latest version.


Provider support for VMWare - VCenter or Vcloud director

Page: /setup/install/providers/
Feedback:
I would like to know if you have anything in pipeline to provide support for VCenter or Vcloud director?
Thanks,

None that I know of - @aglover, do you know of anything?

@ttomsu Is there any update to this issue? We would like to evaluate Spinnaker on Vmware

Would this be something that is worth re-addressing? I believe I can provide some resources on getting this across the line, but the scope seems immense.

Gonna reopen this issue, then move it to spinnaker/spinnaker. I think it's better off there.


[Question] excessively large volume of tensorboard event file - PPO2

##Hi, I have a question regarding Tensorboard event file. To start, I'm quite new to RL and Tensorflow, so please bear with me. I'm making an agent operating on CarRacing-V0, and since I have experimented this, i haven't got any big issue about using Tensorboard. I changed the model from PPO1 to PPO2, and the reason being is that parameters in PPO1 was not clear enough for me to adapt(I described my model below).
model = PPO2(policy=CnnPolicy, env=env, n_steps=256, nminibatches=128,
lam=0.95, gamma=0.995, noptepochs=8, ent_coef=0.01,
learning_rate=5e-4, cliprange= 0.2, verbose=0, tensorboard_log='graph/')
model.learn(total_timesteps=300000, callback=callback, tb_log_name="190304")
and I got this error message and could find that the volume of the event file was over 17GB.
OSError: [WinError 8] Not enough storage is available to process this command
It was only 5k steps operated before stopped. For comparing with others, other event files are lower than 100MB, after the learning of 300k steps was finished(PPO1).
As far as I checked the code, I was not able to figure out what makes this happened. Could anyone help this situation?
Thanks in advance.
Best regards
Jin Uk, Cho.
SungKyunKwan University

Hello,
Please fill the issue template completely.
I also recommend you to upgrade your stable-baselines version. (should be fixed since #185 )

Thanks for quick response.
Hope I edited it correctly.
I will check the version first and describe any changes.
Thank you.

Ok, then please upgrade your version (current is 2.4.1 (without the alpha)), it will solve your problem.
To update:

if installed locally, git pull in the stable-baselines folder
with pip: pip install stable-baselines --upgrade

Updated to the new version

Stable-baseline 2.4.1
Tensorflow 1.12.0

Tensorboard event file was much smaller than the previous one(17GB -> 500MB).
Thanks for your answer, and contribution.

Problem solved then.


Watch/livereload mode to develop

I wanted to edit something in the code, but it seems I always have to type yarn gulp build --platform=browser, even if I only change the slightest thing, and then wait a minute and reload the browser.
Isn't there a livereload mode or watch mode so it gets reloaded instantly while developing?

Is there any updates on this?

For now we haven't done this, although I looked into it briefly.  It looks like support for hot reloading electron apps is okay but tricky.  https://www.npmjs.com/package/electron-reload exists but still has a disclaimer that it's in early stages, so I didn't try to integrate it.  Theoretically something like electron-reload and using tsc --watch could help tighten up the dev cycle, but would also involve probably some changes to the build system to make sure that the output files go to the right place.
I would be very interested if anybody wanted to open a PR with something like this, does this comment help at all in getting started with that?

@JonathanDCohen For me, I would think it would be super helpful to just have live reload in the browser setup. That already helps so much when you just work in the UI – you don't care about electron at that point. We can think about integrating that later, I think it'd be already super valuable to just have livereload for yarn gulp build --platform=browser.

@dban0001 Having never implemented hot reload before, it seems to me that incremental rebuild is a prerequisite to this anyways.  Then we could do something like this (warning: stream-of-consciousness ahead.  There are probably flaws in my reasoning here, hence why I'm sharing it ^_^):

set up incremental rebuilds for tsc and gulp

For tsc we can use the --incremental flag although I think it has limitations on certain platforms depending on how they have to implement the filesystem watching.  I'd need to read more closely in to the details.
For gulp we could leverage  lastRun

Set up filesystem watching

For gulp, we can use watch.  For tsc we can use the --watch flag, with the same caveats as above.  This might require us adjusting our build system, since tsc --watch never terminates.  I guess at least we'd have to run the compiler in the background, but we'd want to be able to see error messages.  Anyways, these both seem tractable, and we can do the gulp separately so we cab at least speed up the build time when only working on ui_components.
So then whenever there's a file change, a build is triggered, and once it's done you can refresh the page.  It's not fully automatic but it's pretty close, seems workable with our current build system, and is a big improvement in the dev cycle.
How does this seem to you? @alalamav @fortuna thoughts?

I set up a somewhat hacky approximation of UI live reloading for our internal development branch. I can try to put together a PR at some point next week.
I set up a couple of gulp.watch tasks that watch src/www/ui_components/*.html and www/app/*.js, each running a different subset of the gulp tasks when triggered. I also run tsc --watch (in a separate shell), which writes out compiled files to www/app/*.js, triggering one of the aforementioned gulp watch tasks. I didn’t include the --incremental flag but I’m not sure why — it’s very possible I just didn’t know it was a thing!
We also trigger a browser reload (using AppleScript, which will only work on macOS) or Android install (via adb commands) once the rebuild is complete. My inclination is that these parts are too environment-specific to include in the main repo but I can add them to the PR if you’re interested.

The "watch" solution sounds good. The build for browser is fast enough that rebuilding on code change may be good enough. No need for incremental rebuild, which is hard to do.


The "run test" code lens is hidden when VS Live Share is active

Environment data

VS Code version: 1.29.1
Extension version (available under the Extensions sidebar):

Python extension: 2018.10.1
VS Live Share: 0.3.954

OS and version: macOS Mojave 10.14.1
Python version: 3.7.0 via homebrew
Type of virtual environment used: pipenv
Relevant/affected Python packages and their versions: pytest 4.0.0

Actual behaviour
When both the Python and VS Live Share extensions are enabled, the  "run test | debug test" code lens's are not displayed above test methods.
Expected  behaviour
Those code lens should be displayed
Steps to reproduce:

Have both the Python and VS Live Share extensions enabled with no other extensions active
Configure Python extension to use pytest. I've not tested unittest or nose but have no reason to think this is pytest specific.
Create a test file containing a simple test:def test_foo():
    assert True

Confirm that the test_foo test is discovered. It can be run from the statusbar and command palette but there is no code lens above it.
Disable the VS Live Share extension and reload the window
The code lens is now displayed as expected

Logs
Output for Python in the Output panel:
Starting Microsoft Python language server.
Microsoft Python Language Server version <IP_ADDRESS>
Initializing for /Users/[redacted]/.venv/bin/python
##########Linting Output - flake8##########
##########Linting Output - flake8##########

Output from Console under the Developer Tools panel:
INFO no standard startup: not a new window
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Create file systemwatcher with pattern */python
console.ts:134 [Extension Host] Python Extension: Create file systemwatcher with pattern */*/python
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Create file systemwatcher with pattern */python
console.ts:134 [Extension Host] Python Extension: Create file systemwatcher with pattern */*/python
console.ts:134 [Extension Host] Python Extension: Display locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: Notify locators are locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Detected refreshing of Interpreters, Arg 1: {}, Return Value:
console.ts:134 [Extension Host] Python Extension: Register Intepreter Watcher, Arg 1: {"$mid":1,"fsPath":"/Users/[redacted]","external":"file:///Users/[redacted]","path":"/Users/[redacted]","scheme":"file"}, Return Value:
console.ts:134 [Extension Host] Python Extension: Register Intepreter Watcher, Arg 1: undefined, Return Value:
console.ts:134 [Extension Host] Python Extension: Build the workspace interpreter watcher, Arg 1: {"$mid":1,"fsPath":"/Users/[redacted]","external":"file:///Users/[redacted]","path":"/Users/[redacted]","scheme":"file"}, Return Value: UNABLE TO DETERMINE VALUE
console.ts:134 [Extension Host] Python Extension: Build the workspace interpreter watcher, Arg 1: undefined, Return Value: UNABLE TO DETERMINE VALUE
console.ts:134 [Extension Host] Python Extension: Get language server folder name, , Return Value: "languageServer.0.1.60"
2console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Hide locator refreshing progress, , Return Value:
console.ts:134 [Extension Host] Python Extension: All locators have completed locating, , Return Value:
console.ts:134 [Extension Host] Python Extension: Checking whether locactors have completed locating, , Return Value:

A similar issue was reported in #2436. In that case it was Gitlens not VS Live Share which was the  conflicting extension. I cannot reproduce that problem with Gitlens  8.5.6

Confirmed that this fails with the current vscode-python extension & vscode live share.

Output pane from the Python Test Log:

INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\_pytest\main.py", line 181, in wrap_session
INTERNALERROR>     config._do_configure()
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\_pytest\config\__init__.py", line 629, in _do_configure
INTERNALERROR>     self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\pluggy\hooks.py", line 306, in call_historic
INTERNALERROR>     res = self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\pluggy\manager.py", line 67, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\pluggy\manager.py", line 61, in
INTERNALERROR>     firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\pluggy\callers.py", line 208, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\pluggy\callers.py", line 80, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\pluggy\callers.py", line 187, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\_pytest\cacheprovider.py", line 313, in pytest_configure
INTERNALERROR>     config.cache = Cache.for_config(config)
INTERNALERROR>   File "d:\dev\github\d3r3kk\test\3457_code_lense_on_test_gone_in_liveshare\.venv\lib\site-packages\_pytest\cacheprovider.py", line 47, in for_config
INTERNALERROR>     cachedir.mkdir()
INTERNALERROR>   File "C:\Python\Versions\3.7.0\lib\pathlib.py", line 1230, in mkdir
INTERNALERROR>     self._accessor.mkdir(self, mode)
INTERNALERROR> FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'd:\\dev\\github\\d3r3kk\\test\\3457_code_lense_on_test_gone_in_liveshare\\.pytest_cache'

Looks like live share must be hacking something.
Previously they would hack the debugger comms, and that broke the debugger.
I would report this up steam to live share as that's the culprit.
However we need to triage this and identify whether there's a bug in our code before doing so.

Closing in favour of https://github.com/microsoft/vscode-python/issues/14379.


Localization issue preventing startup on Windows 8.1 64bit

Hi,
I had the following issue which was discussed on reddit and found out that it is somehow related to the localization of the host, which required an according bundle for the strings.
Error when starting
"This application was configured to use a bundled Java Runtime Environment but the runtime is missing or corrupted."
I opened the project in Netbeans and made copy of the english string bundle, calling it "strings_de.properties" since I'm running the application on a German localized host. After that the build was working fine and the application started.
Hope that helps to fix the starting issue.
PS: Great tool by the way, thanks!
Best regards

Hey, thanks for looking at this. I pulled up the source (haven't looked at it in ages) and I noticed that there already was a German localization, added over a year ago. Did you have the latest version of the code when you tried this?

Hi, I used the "Download as ZIP" functionality, I hoped that would give me the latest version. I'm not used to Github though, maybe I looked at the wrong location :-S
It got me the properties files at "/FlagMaker/src/bundles/", which doesn't feature a German localization file.

Ah, that's because the "download ZIP" button gets you what's in the master branch, but the German localization is currently only in the develop branch.
I'm hoping to be able to test what's in develop on my Linux machine soon so I can pull that all into master and do a 2.1 release, which should fix all the localization issues people have been having.

Ah, thanks for the clarification. I guess the issue can be closed then.


enh(themes)  devibeans - inspired by vim's jellybeans theme

Added a new theme inspired by vim's jellybeans theme. A live preview can be viewed here.

Changes

Checklist

[ ] Added markup tests, or they don't apply here because...
[ ] Updated the changelog at CHANGES.md

Please update your header to include tagged fields:
/*!
   Theme: a11y-light
   Author: @ericwbailey
   Maintainer: @ericwbailey

   Based on the Tomorrow Night Eighties theme: https://github.com/isagalaev/highlight.js/blob/master/src/styles/tomorrow-night-eighties.css
 */

ie, Theme:, Author:, etc...
And can you please attempt a snap or two so someone can see it here for review without having to jump to an external website?  Also please show an HTML and Markup example as well so we can see how it looks highlighting the major different types of things we support.

Awesome.  I think it just needs a changelog entry...

Added a new entry under New Themes in CHANGES.md. that should do it, right?

I almost forgot about our new theme checker.  Can you please run it and have a look?
./tools/checkTheme.js src/styles/devibeans.css

There are quite a few things your theme omits.  Is this intentional?

I might hold this a bit longer until I can circle back and figure out which of those things should be warnings vs errors... we'd really like themes to be "complete" as well as start using the new punctuation, operator, etc... of course it's your theme... so we can't mandate anything or tell you to make it "more colorful" if you like it just how it is... but we can require a theme to explicitly "opt-out'... so that we know for sure you intended to not highlight something rather than that you simply weren't aware of it, etc...  this is important for long-term theme maintenance as new scopes are added to the parser.
IE:
/* we purposely do not highlight operators */
.hljs-operator {}

So the question is which items do we want to require manually opting out of and which are purely 100% optional.  That's what we're still figuring out.

Added the few missing tags, explicitly opted out of the ones I don't want highlighting for.

@terminaldweller Thanks fo much!