Axmodel query integration

The list of 'static' elements -- elements that are not modeled or referenced in ARIA - is quite long. It includes elements that we would expect to be represented in ARIA like <label> and <p>.
Browsers do model these elements in their AX Tree. So by taking the AXObject models into account, we gain a more complete understanding of how HTML and DOM are represented in the AX Tree.
These changes will disallow constructs like <label onClick /> and <label role="button" />.

Changes Unknown when pulling 0d1fc3d99b2c1b0364fcc6a6e342f3fcdb2f8e6e on jessebeach:axmodel-query-integration into ** on evcohen:master**.

Coverage increased (+0.02%) to 99.492% when pulling 0d1fc3d99b2c1b0364fcc6a6e342f3fcdb2f8e6e on jessebeach:axmodel-query-integration into 20cda7123158cc405b8a98f4f03ff221bf8df498 on evcohen:master.

General comment about all the explicit keys/entries iterators - most of them seem unnecessary. Can they be omitted?

Which ones do you mean? I'm worried I'm making the wrong assumption about what you mean to indicate.

Coverage decreased (-0.1%) to 99.366% when pulling b692d04b818eb75d6e24eceb20fbd1afda5564fd on jessebeach:axmodel-query-integration into b44ac6dc2a663b74ab668042a2db53496d02f8ef on evcohen:master.

Coverage decreased (-0.1%) to 99.366% when pulling b692d04b818eb75d6e24eceb20fbd1afda5564fd on jessebeach:axmodel-query-integration into b44ac6dc2a663b74ab668042a2db53496d02f8ef on evcohen:master.

Coverage decreased (-0.1%) to 99.366% when pulling d123ff77103c88fa5a35ca037f05e9521b495946 on jessebeach:axmodel-query-integration into b44ac6dc2a663b74ab668042a2db53496d02f8ef on evcohen:master.

@jessebeach np, i'll comment on each explicitly (just didn't want to overwhelm you with non-a11y-related nits)

Coverage increased (+0.02%) to 99.487% when pulling 978ea4be4b3a98a2b419b1b5de52494a630ff5a6 on jessebeach:axmodel-query-integration into b44ac6dc2a663b74ab668042a2db53496d02f8ef on evcohen:master.

Sorry for the deluge; happy to elaborate if any of my comments aren't clear.

No worries. I appreciate the input. I learned a lot about iterators tonight!

can you explain the difference between the AXObject and ARIA? Is ARIA the spec and AXObject the implementation?

Sure, I do this in the README

Coverage increased (+0.02%) to 99.487% when pulling 761e7fce7e910fc1f2cae73bafa82f616a9614a4 on jessebeach:axmodel-query-integration into b44ac6dc2a663b74ab668042a2db53496d02f8ef on evcohen:master.

Will continue to clean in followups that are smaller and targeted. This should be the last of the big commits. I've got a couple new rules and rule improvements on the way.


PyTorch Lightning DataParallel + ModelParallel benchmarks

Quick notes:

Can easily switch precisions (16, 32, 64)
Can easily switch strategies (currently only doing dp and fsdp)
Can switch between different profilers (simple, pytorch, etc):

Is there a way to make the output less verbose? The script appears to output percentage progress and stuff like that by default, but that mostly just clogs the logs.

Fixed in 78f6867

I think the important remaining step is putting the data where milabench wants it to be (see comment).

Fixed in 4362316


diff between two references on the same branch

Closes #603

Codecov Report

Merging #842 into master will increase coverage by 1.34%.
The diff coverage is 73.48%.

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   43.09%   44.44%   +1.34%
==========================================
  Files         136      137       +1
  Lines       10648    10585      -63
==========================================
+ Hits         4589     4704     +115
+ Misses       5461     5274     -187
- Partials      598      607       +9

Impacted Files
Coverage Δ

catalog/db.go
81.81% <ø> (+1.58%)
:arrow_up:

catalog/cataloger_diff.go
67.56% <72.13%> (+0.90%)
:arrow_up:

catalog/cataloger_merge.go
62.58% <90.00%> (+1.76%)
:arrow_up:

api/handler.go
70.52% <0.00%> (ø)

api/client.go
4.65% <0.00%> (+1.14%)
:arrow_up:

catalog/cataloger_create_branch.go
88.67% <0.00%> (+3.77%)
:arrow_up:

catalog/cataloger_create_repository.go
69.23% <0.00%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b1249...56378a1. Read the comment docs.


1.4:  d.ts definitions can only import ambient external modules in other ambient modules

I am writing a d.ts for hapi, and wish to specify that some types used by the API are nodejs types.
For example:
server.route({handler:(request,reply)=>{
//can pass a nodejs stream to reply
 }});

however, as nodejs's stream.Stream is declared inside an ambient module, I can not simply import stream = require("stream"); at the top of my hapi.d.ts file.   Doing so causes the error: Error   278 Ambient external modules cannot be nested in other modules.
I am forced to define hapi inside of an ambient module also:
declare module "hapi" {
    import stream = require("stream");
        ///hapi definitions here....
}

an unfortunate side effect of this limition is that all module definitions that depend on ambient modules must also be defined in ambient modules.   Instead, I would prefer defining modules in the following way:
declare module Hapi{
 ///hapi definitions here
}
declare module "hapi"{
 export = Hapi;
}

I prefer this methodology as it allows discovery/use of the type definitions without importing the ambient module.
Please consider allowing some workaround for this issue.

I join @mhegazy in desire to have above way of module definitions.
The reason for this is automation of creating declaration files. I have node module. gulp-typescript creates definitions. Now, making declarations that are good for DefinitelyTyped, requires manual spaghetti-shuffling.
Please, please, please. Either let above solution happen, or provide a scriptable (!) work-around, which can properly added into modern build process.

@3nsoft, can you elaborate on your scenario and the proposed solution?
You would want a single .d.ts file for all your node modules? or a definition file that works for both modules and injecting into the global namespace?

@mhegazy here is my scenario.
For my node library, which is made of many files, I can have an auto-magic gulp task, which creates definitions (.d.ts's) for all files. And definition for main script looks as follows (actual output):
/**
 * This file is an external interface of Ecma-NaCl library.
 */
export import secret_box = require('./boxes/secret_box');
export import box = require('./boxes/box');
export import nonce = require('./util/nonce');
export import signing = require('./signing/sign');
export import fileXSP = require('./file/xsp');
import sha512Mod = require('./hash/sha512');
export declare module hashing.sha512 {
    var hash: typeof sha512Mod.hash;
    var makeHasher: typeof sha512Mod.makeHasher;
}
import scryptMod = require('./scrypt/scrypt');
export declare var scrypt: typeof scryptMod.scrypt;
export import arrays = require('./util/arrays');
export declare function compareVectors(x: any, y: any): boolean;

When someone npm install's the library, they need a definition like:
declare module "ecma-nacl" {
...
}

The simplest thing in a build environment would be to put all exposed definitions (one file only) into this declaration "bracket".  Externally, it look like a folder with files, which can be copy-pasted into lib-user's declarations folder. And it can be easily send to DefinitelyTyped.
Can this happen, say, in a future version?
If not, what is an automatable work-around to generate ambient module declarations out of declarations that are generated on a classical node lib (commonjs external module)?
It does not matter if solution is a single or a multi-file. What matters is that it is automatic.
For further reference, here is a gulp task that does compilation, and creation of sources:
gulp.task('lib', function() {
	var ts = gulp.src([ SRC+'/lib/**/*.ts', SRC+'/typings/**/*.ts' ])
	.pipe(typescript({
		target: 'ES5',
		module: 'commonjs',
		declarationFiles: true
	}));
	return merge(ts.js.pipe(gulp.dest(DIST+'/lib')),
			ts.dts.pipe(gulp.dest(DIST+'/lib-declarations')));
});

May be there is a magic with typescript parameters, which will let me define ambient modules. So far I see no work-around to automate declarations part of a build process.

thanks @3nsoft. I think your request should be better covered by #2568. It is something we will be looking to add in 1.6.

@mhegazy  Which is a link for this feature request, where I should vote, sign a petition, etc. :)
On a serious note, till 1.6, is there a non-manual work around?

@mhegazy I am browsing referenced issues, and an emphasis there is about single file declarations. May be it is an internal view on how thing should be done.
My emphasis, As a lib developer with typescript, is "will it help me automate a build process of usable declarations".
The message is, help me automate this task. The solution may have one or many steps -- you, guys, have lots of room for internal design, but the task should be automatable.

I find it extremely constraining to force anything that depends on nodejs's definition to be an ambient module.
can you just "allow" import of ambient modules? (don't raise Error 278 Ambient external modules cannot be nested in other modules.) does that screw with namespacing?

the problem here is it does not really model reality. if i use your internal module typings that import http,
module app {
    import http = require("http");
    function createServer() :http.Server;
}

The compiler will not compain if i use it in a web application including the file in a script tag as:
var x = app.createServer();

This is clearly not going to work for multiple reasons. 1. I am not on node, and http does not exist, and 2. I am not using a model loader (i.e. calling require), so even if i am in node, nothing works.
This is the main difference between internal and external modules. external modules have a concept of dependencies and an expectation of a loader that manages them; and i do not see how you can impose that on internal modules, which are basically a variable pointing to an object literal.

@mhegazy I think you are conflating two issues:

my issue (defining d.ts non-ambient definitions that use ambient definitions)
using definitions without the proper modules loaded.

Reading my original issue post, I did not make one point clear:  the typings found in  node.d.tsare ambient purely for aesthetic reasons.  the typings could have been defined like this, with absolutely no change in behavior:
declare module Stream{
 ///nodejs stream module definitions here
}
declare module "stream"{
 export = Stream;
}

if the node.d.ts typings were done this way it would allow me to also construct definitions in a similar way.   however because the definitions are done in this way:
declare module "stream"{
 ///nodejs stream module definitions here
}

I am forced to write definitions that use stream typings as ambient definitions.

@mhegazy which reality are you talking about? For example, in my very-very common reality, gulp automatically (a) compiles all typescript files, and (b) browserify-es every node dependency into single package for browser's build. It all works, when everything is properly packed, and your example is incorrect, because browserify creates require utility with all packages for consumption in a browser.
What is missing, though, it is a 100% automatic generation of declarations. Currently declarations need manual intervention due to restrictions on mixing modules.
As you said, initial design of TypeScript has, quote,
main difference between internal and external modules. external modules have a concept of
dependencies and an expectation of a loader that manages them,

It happens to assume a certain loading. Loading can be done differently in javascript for the same business logic code. Most node packages loading for browsers is taken care by proper packaging with browserify. Let TypeScript work for other assumptions in loading.
When package is used in node, all dependencies are added to package.json, and npm automatically sets up environment, so that all required code is available. Again, your example is incorrect, as npm install fixes the worries you expressed.
And again, if there is no declaration, users cannot enjoy types. But making declarations is not automatable due to restriction on mixing modules in declarations.
I, personally, love typescript. Switched in last half year all my projects to it. The only pain. Real pain. Annoying pain. It is declarations.
And the funny thing is not that I have a problem without such declarations. I do not, because I have my lib's ts files in my folder. But when I use my lib the way other developer will, I notice that declarations are required.
In other words, if you want TypeScript to spread like fire, make creation of declarations automatable.
Put it another way. Do you want me to quietly write TypeScript, compile it, and tell the wider world that I give it a JavaScript library. Or, do you want me to tell the wider world that it is TypeScript library, here are declarations -- enjoy. What do you want me to tell others?
Again, it really does not matter how this is fixed / accomplished. On a first glance it looks like removal of restriction on module mixing will allow full build automation (among which is automation of declaration writing). But, if there is or should be another way of automating declarations, tell us, show it to us, or implement a work around, and tell us about it, so that we can spread TypeScript's glory further with our own works.

@jasonswearingen first part of you post is not showing on the web, but is showing in the email. I'll echo it here:
@mhegazy I think you are conflating two issues:

my issue (defining d.ts non-ambient definitions that use ambient definitions)

using definitions without the proper modules loaded.

ECHO END

I removed it because I decided it didn't really add anything constructive to the conversation.

I think the guy did conflated issues, and out of this confusion is not able
to see our pain.
2015-04-16 22:30 GMT-04:00 Jason Swearingen<EMAIL_ADDRESS>
I removed it because I decided it didn't really add anything constructive
to the conversation.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/2198#issuecomment-93880749
.

@3nsoft i believe i understand your request. and it is different from the original suggestion @jasonswearingen is proposing. and #2568 is a more appropriate place for your issue.

the typings found in node.d.tsare ambient purely for aesthetic reasons. the typings could have been defined like this, with absolutely no change in behavior:

it is true that types do not exist at run-time, but they model something that exist. when you define your module as an external module, you expect it to be loaded using its name, using a module loader. if you define it as an internal module you are defining it as a variable in the global namespace, that can be accessed as such. Allowing this specific pattern would make it easier for your scenario, but would break others.
TypeScript's type system is structural; so you can copy your type definitions from node, and put them in internal modules, or wrap them in another module; which is something that I had to do personally for tsserver.
I understand the convenience aspect, and the need to maintain two sets of typings, and the need for a better solution; this is why i have marked the issue as a "suggession". I do not agree with the proposed solution though.

@mhegazy you are correct that the object may or may not exist at runtime.  But we are discussing types, not instances of objects.  Types are not things, they are abstract "ideas".
I wish to make typings available for reuse without needing to construct the actual container (module) at runtime.  This is actually possible for me to do, unless one of my dependencies has an ambient definition In that case I am stuck, and can not reuse the types freely.  Thus my request.

I should mention:  Typescript types being abstract ideas.  (not true in most other languages)

here is a practical example where the current design fails:
in PhantomJs, to use the lodash external module you need to do the following:
var _:_.LoDashStatic = require("./lodash");

if the makers of the lodash.d.ts would have put the definition in an ambient module, the typings would NOT be usable in PhantomJs, as there would be no way for me to access them!  (PhantomJs does not allow ambient external modules)
Thankfully the lodash.d.ts makers did it the "right way".

I'm facing the same issue.
My env is both nodejs and browser (https://github.com/atom/electron)
In my app, I don't use the import extmodule = require("extmodule") syntax to load external modules but the var extmodule = require("extmodule") one.
Here some reasons for this choices:

To fasten my app startup, I load some modules asynchronously, when I need it, which seems not to be possible with the import syntax
My app is splitted is several parts including a common part that manage dependency loading. As a result, I need Typings in parts where I don't load dependencies.

As a result, and because of the design of node.d.ts, I can't get typings for all external module not defined as ambient.
I need an ambient definition, so I can define the type of the return of require:
interface NodeRequireFunction {
	(id: 'modulename'): TypeOfModule
}

Bad design ?
More widely, I think this is a bad design to link dependency loading with typings, these are 2 different things that are NOT related.
Typings could be used (by an app or third party module) without loading the module itself (for another implementation of a standard lib for example).
The ability to import an ambient module into another ambient module declaration is not a good solution,

because it is misleading (same syntax as runtime module loading, but it does not load the module, only definitions, isn't it?)
because it is not possible to use without loading a module (either the original one or the nested declared one)

What can be done
Update node.d.ts definition (and also all others)
@mhegazy is right in a way, it could be a breaking change to attribute the same name to non ambient modules, not because they may not exists at runtime but, because it may exists something else with the same name (events, stream, ... are common names) in the global namespace.
The solution is to keep the design of node.d.ts, which already define global interfaces (that does not exists at runtime) under the NodeJS namespace.
It would be:
declare module NodeJS {
	module ModuleName {
	 /// definitions here
	}
}
declare module "modulename" {
 export = NodeJS.ModuleName;
}
interface NodeRequireFunction {
	(id: 'modulename'): typeof NodeJS.ModuleName
}

But this is a bit off topic as most type def are maintained on https://github.com/DefinitelyTyped/DefinitelyTyped
If I catch the time to, I may post a few pull request to it
Allow import of typings from any context
And maybe with a different syntax than the module import syntax

@felicienfrancois

To fasten my app startup, I load some modules asynchronously, when I need it, which seems not to be possible with the import syntax
My app is splitted is several parts including a common part that manage dependency loading. As a result, I need Typings in parts where I don't load dependencies.

I believe these issues can be handled using the pattern described here: http://www.typescriptlang.org/Handbook#modules-optional-module-loading-and-other-advanced-loading-scenarios
If you import a module and use it solely for types, it doesn't generate a require() call.

old, will reopen if i run into this again.


Gather user projects and Testing for projects route

Convert schema/projectList.js to a JSON file, lib/schema/projectList.json

The test file is testing more than one unit. Separate the file into its constituent parts, one for the projects route (test/routes/projects.js) and one for the projects module (test/lib/projects.js).
Also, the projects module test cases should be structured using nested describes, the outer describing the module and inner describes for the module's functions. (As in the auth module tests.)

besides my comment about the describes and manually modifying json test case array, LGTM as Chance would say

LGTM


How to set a directory to install SDK?

I would like to install to another directory, not in the default directory.
But I haven't seen any option to set the installation directory.
How could I do this?

Hi @JANGSOONMYUN   If you are trying to install librealsense in a custom folder, I hope that the link below will provide information that is helpful to you.
https://github.com/IntelRealSense/librealsense/issues/5461

@MartyG-RealSense Thank you for reply. Therefore, I should install the SDK from the source, not exe file.

Thanks very much for the update @JANGSOONMYUN


[RESTEASY-2176]:Client-side SSL - HostnameVerificationPolicy.STRICT

shouldn't accept wildcard certificates

Copied from @jimma's https://github.com/resteasy/Resteasy/pull/2028.

@ronsigal  We don't a docbook section to talk about ssl configuring. I added in https://github.com/resteasy/Resteasy/pull/2032, and  the content about  HostnameVerificationPolicy is  under the ssl configuration section. please help review and correct.


Resource android:attr/lStar not found when building release APK

This error seems to be related to the sign_in_with_apple plugin.
Environment

supabase_flutter version: 1.10.25
sign_in_with_apple plugin version: 5.0.0
Android compileSdkVersion: 34
Android targetSdkVersion: 34

Steps to Reproduce

Add sign_in_with_apple plugin to pubspec.yaml
Run flutter pub get
Try to build a release APK with flutter build apk --release

What I've Tried
I've attempted the following solutions without success:

Updated Android SDK versions in build.gradle
Ensured AndroidX is enabled
Cleaned and rebuilt the project
Disabled resource shrinking and minification

Question
Is this a known issue with the plugin? Are there any workarounds or fixes available?
Any assistance would be greatly appreciated. Thank you!

You seem to be using an out-dated version of both supabase_flutter and apple_sign_in plugin. I would see if upgrading them would fix the issue.


Using oras-py to download the vulnerability data.

The current scheme uses the vdb library to sequentially download the vulnerability data from NVD, OSV, GitHub, etc. advisories. However, there exists a vdb image that has the data from all these advisories baked into it. Hence, instead of sequentially downloading data, the image artifacts can be downloaded.
Note:

This commit removes the "--cache-os" argument as it is no longer needed. The OS vulnerability data exists in the vdb image.
This commit does NOT remove the "--sync" argument as one might want to just sync (get the latest vulnerability data) instead of downloading everything.

Looks awesome! Any difference in performance?

@saketjajoo Thanks Saket! Worked well for me. @prabhu It was definitely faster than building from scratch.


[Bug]: No alternative to JupyterHub API present

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
There is currently no replacement for the JupyterHub API page/endpoints for KFNBC
Expected Behavior
There should be an equivalent API page/endpoints
Steps To Reproduce
No response
Workaround (if any)
No response
OpenShift Version
No response
Openshift Version
No response
What browsers are you seeing the problem on?
No response
Open Data Hub Version
No response
Relevant log output
No response

This is unlikely to be something we will do. We are talking to Kube, so there isn't an API for us to share with you. Currently we are using a note server to do this (so today we can do this) but in the near future (#259) the server will just be a pass through API and thus we will not have any API visible to external users.

If this is a need @lugi0 we can discuss this further -- but as it stands this won't be done.

I guess I only opened this bug because our aim is to have feature parity with existing JH functionality while utilizing the KFNC backend capabilities., as per #213.
As long as @jedemo @jkoehler-redhat and others are ok with dropping this functionality I don't personally see a need to reimplement something equivalent


fixed bad REST api URL added PY3 support

Changed docstring to point to README.md not README.rst
wrapped exception tuples in parenthesis
use f string to create url
switch to requests library to open url
change urllib2 to urllib

@edenbaus probably want to add a header w/User-Agent to the new requests code now that Open Secrets is currently preventing generic user agents from scraping their site.

@mdublin Good suggestion.
I’ll update the pull request with the relevant header/user agent code.


care with the --max_cores= flags

I had previously noted that before the --max_cores= was implemented, my laptop ran into the ground, the load was 20+, basically because I saw 8 threads of - in this case - ephem_batch running.   After the flag was implemented, I ran it with --max_cores=2 and noted two were running, but each with about 300% CPU. Clearly it seems, if I want to be able to do any other work, --max_cores=1 is my sweet spot.  Whatever code runs in a thread, must have parallel code (in numpy?) which is CPU hungry.  This also explains the load of 20+
Now running it with 1 core, I see the load going over 400% from time to time. I have 4 cores (2 threads per core), so usually anything over 400% will be bad for the threads. So for me it seems 1 is the best.

A colleague recently pointed out to me that numpy and scipy are intrinsically very efficient and often use a lot of the available resources to speed things up. My parallelizing things on top of that does seem to mean that the batch scripts such as align_batch and ephem_batch can easily use up all available resources. This hadn't been a problem as I used a server in the department when running my full dataset.
I'll add a note to the documentation suggesting using --max_cores=1 if using a laptop. Is that okay?

yes, this would be good.  Not many people realize that a lot of laptops that have the temperature sensitive cpus (the intel U series for example) will lower their CPU freq if they get hot. And when running all cores this can happen, and actually most codes will trash the CPU if the threads in a core are uses "as cores", So for CASA my sweet spot is always just to use the cores, and not the threads.

That's really interesting! I'm learning quite a bit though all this analysis into the performance of EMBERS, thanks :)
Have updated the documentation


Non-existing pages redirect to main page instead of 404

I currently have the 1.x version running on my "real" "production" site, but I am testing on pico 2.0.4.
My server software is nginx.
I recently upgraded php-fpm form 5 to 7 - for ALL my sites, not only the testing site. That was a major step, but the real (production) site is working as expected (I mention this because I don't know exactly when the problem started - it might have been there ever since I started using 2.0.4, it might have started after upgrading php-fm, or even later).
The testing site works fine, too, except for pico not displaying error pages.
I do have a custom 404.md in my content directory, the same that still works on the production site.
I have played a lot with the nginx server settings - they're slighty different for the production site and 2 testing sites - I switched them around, edited them, and came to the conclusion that pico is responsible here, not nginx.
But I have no other server software to test with, so I cannot be 100% sure.
The pages that are forbidden by nginx configuration show nginx' own 404 or 403 pages, so that works.
Pages that simply do not exist (and are not caught by nginx config rules) always redirect back to the web root (main page, index) instead of showing the custom 404.md.
URL rewriting is enabled both in config.yml and in nginx configuration.
I find no error messages in the logs.
Caching is disabled on the testing sites.
Here's my current nginx config and my config.yml.

Which URL is shown in your browser when navigating to a non-existing page? Are you redirected to Pico's index page (i.e. the base URL is shown in your URL bar), or are the contents of index.md shown instead (i.e. the non-existing URL is shown in your URL bar)?

the non-existing URL is still shown in my URL bar, but I see index.md.
i wish i knew how to troubleshoot this.

We can do this :smiley: Let's see what's going on after Pico has read the page's contents... Create plugins/PicoDebugPlugin.php with the following content, request a non-existing URL and provide the output:
<?php
class PicoDebugPlugin extends AbstractPicoPlugin
{
    public function onContentLoaded()
    {
        var_dump($_SERVER);
        var_dump($this->getPico());
        die();
    }
}

this will reveal some sensitive information!
I hopefully replaced all of it:
http://paste.debian.net/plain/1073565

Just as a follow up, I was also having this issue: Pico showing default content instead of a 404 page.
The reason in my case was that the rewrite_url setting in config.yml was not set (it was set to rewrite_url: ~)
Changing config.yml to read:
rewrite_url: true

fixed the issue for me.


test(react-client): clear smoke test

Current dependencies on/for this PR:

main

PR #2511   👈

This comment was auto-generated by Graphite.

⏳ This pull request is set to merge as part of a Graphite merge job
Job ID: TjscaZpRRoaMP5g5qoXy.
See details on graphite.dev


Feature: miranum deployment add file names to deployment

Issue
Description

Add more information to the deployment api like the file name
Adjust Github Release Action to allow SNAPSHOT releases for spring boot apps

Checklist

Code is easy to understand
No obvious errors or bugs
CI/CD Pipelines did run successfully
Tests were implemented
Documentation was created

Codecov Report
Patch coverage: 90.32% and project coverage change: +1.42% :tada:

Comparison is base (6b31a4c) 61.94% compared to head (1751a6d) 63.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #344      +/-   ##
============================================
+ Coverage     61.94%   63.36%   +1.42%
- Complexity       49       60      +11
============================================
  Files            35       36       +1
  Lines           452      475      +23
  Branches         42       43       +1
============================================
+ Hits            280      301      +21
- Misses          130      132       +2
  Partials         42       42

Flag
Coverage Δ

unittests
63.36% <90.32%> (+1.42%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...ver/adapter/out/MiranumDeploymentReceiverImpl.java
0.00% <ø> (ø)

...loymentreceiver/application/dto/DeploymentDto.java
70.00% <70.00%> (ø)

...eceiver/application/usecase/DeployFileUseCase.java
100.00% <100.00%> (ø)

.../miranum/deploymentreceiver/domain/Deployment.java
60.00% <100.00%> (-6.67%)
:arrow_down:

.../adapter/in/rest/DeploymentReceiverController.java
100.00% <100.00%> (ø)

...ver/application/usecase/DeployArtifactUseCase.java
100.00% <100.00%> (ø)

...on/miranum/deploymentserver/domain/Deployment.java
70.00% <100.00%> (+3.33%)
:arrow_up:

...tserver/adapter/out/MiranumEmbeddedDeployment.java
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Merge this PR and release version 0.2.1 of miranum deployment


Update build.gradle

Update Parchment mappings to 1.18.2 (closes #202)
Only use KFF 3.1.0 instead of 3.0.0 & 3.1.0

GitHub is not giving me the option to run the CI/CD against this. Stuff is pretty quiet these days so I'm just going to merge it and watch the resulting merge tests and revert if there's an issue.


"Saraiu" is listed in the drop-down menu

Description:
When user writes "Saraiu" the location appears in the drop-down menu next to the comune and the county which is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Saraiu"

Expected results
The location appears in the drop-down menu as "Comuna Saraiu, CONSTANȚA"


[Event Request] Table 1003 "Job Planning Line" OnBeforeLinesWithItemToPlanExist

Hello.  Could you please add the following "OnBeforeLinesWithItemToPlanExist" event to Table 1003 "Job Planning Line" into the procedure LinesWithItemToPlanExist?
    procedure LinesWithItemToPlanExist(var Item: Record Item): Boolean
    var
        IsHandled: Boolean;
        Result: Boolean;
    begin
       IsHandled := false;
       OnBeforeLinesWithItemToPlanExist(Item, Result, IsHandled)
       if IsHandled then
            exit(Result);

        FilterLinesWithItemToPlan(Item);
        exit(not IsEmpty);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeLinesWithItemToPlanExist(var Item: Record Item; var Result: Boolean; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10392.


Added ihsaan.glitch.me

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the GTMetrix report
[x] The domain is in the correct alphabetical order
[x] This site is not a ultra lightweight site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: ihsaan.glitch.me
  url: https://ihsaan.glitch.me/
  size: 99
  last_checked: 2022-03-09

GTMetrix Report:
https://gtmetrix.com/reports/ihsaan.glitch.me/HStnvzTe/

Although this is a cool little website, it falls into the 'ultra-minimal' bucket I'm afraid, so I won't be merging this one. Sorry.


Python Client segmentation fault (core dumped) or free(): invalid pointer Errors

Describe the bug
I wrote a very simple test method cause I do get some very hard to debug interactions between pulsar client 2.8 and 2.7 too with cv2 (all last 4 versions tested and same problem)
This is the Testprogram:

If I import cv2 first the core gets dumped at the line it wants to create the test producer:

If I import pulsar first the producer gets created successfully ( no suspicious logs at broker either) but as soon as cv2 gets to the second imread -> garbage collecting happens before I guess the core gets dumped again. so now the error is in cv2?!?

To Reproduce
Steps to reproduce the behavior:
Build pulsar-client-cpp and python client from source ( either 2.7 or newest master 2.8)
Try test program.
Desktop (please complete the following information):

OS: Pop OS 20.10 but tried with Ubuntu 19.10 as well
python 3.9.1 and 3.9
boost and python boost 1.75 but tried with 1.71 as well
gcc/++ 10.2

Maybe related to  #9796

I tried with OpenCV 4.5 that is installed by pip3 install opencv-python and Pulsar client that is built with latest master in MacOS Big Sur 11.2.
Then tried the command line with a Pulsar standalone, there's no error.
>>> import cv2
>>> import pulsar
>>> client = pulsar.Client(service_url='pulsar://localhost:6650')
>>> producer = client.create_producer(topic='my-topic')
2021-03-15 10:27:41.285 INFO  [0x117ca8e00] ConnectionPool:85 | Created connection for pulsar://localhost:6650
2021-03-15 10:27:41.295 INFO  [0x7000043a9000] ClientConnection:372 | [<IP_ADDRESS>:50925 -> <IP_ADDRESS>:6650] Connected to broker
2021-03-15 10:27:41.301 INFO  [0x7000043a9000] HandlerBase:54 | [persistent://public/default/my-topic, ] Getting connection from pool
2021-03-15 10:27:41.310 INFO  [0x7000043a9000] ProducerImpl:176 | [persistent://public/default/my-topic, ] Created producer on broker [<IP_ADDRESS>:50925 -> <IP_ADDRESS>:6650]
>>> producer.send('hello'.encode())
<_pulsar.MessageId object at 0x117b28190>
>>> img = cv2.imread('./images/lena.png')
>>> _, image_np_array = cv2.imencode('.jpg', img)
>>> print(image_np_array)
[[255]
 [216]
 [255]
 ...
 [207]
 [255]
 [217]]

The segmentation fault might be something with the dependencies conflicts with Pulsar and OpenCV. But it's hard to debug. I suggest that you can simplify your code and watch the result again. BTW, you can also try to print the backtrace, see https://stackoverflow.com/questions/16731115/how-to-debug-a-python-segmentation-fault

You are correct I just have tested it on my mac and no problems there though I use the exact same libraries? boost 1.75 and pulsar client 2.8 ( 84cfb3affa1ce5bc1db29baab5498205049019dd ). I also tried the backtrace with your suggestion , thanks for that.

First output with cv2 import first. Hangs again at second imread
Second output with pulsar import first. Error at creating producer.
I have now tested it on 3 different ubuntu machines (19.10, 20.04. and 20.10) and with boost 1.75 built from source or 1.71 with apt package manager and  opencv-python or opencv-python-headless ( version <IP_ADDRESS> till <IP_ADDRESS> ) and not a single combination works. I have also simplified the code that just cv2,pulsar and json have to be imported.
`
#!/usr/bin/env python3
import cv2
import pulsar
import json
def main():
client = {}
client["audience"] = "pulsar_service"
client["issuer_url"] = "https://example.com/auth/realms/test_company"
client["client_id"] = "pulsar-coco.detection.images"
client["client_secret"] = "secret"
client["grant_type"] = "client_credentials"
temp_client = pulsar.Client(
    "pulsar+ssl://<IP_ADDRESS>:6651",
    use_tls=True,
    tls_trust_certs_file_path="./pulsar-test/ca.crt",
    authentication=pulsar.AuthenticationOauth2(json.dumps(client)),
)
test_topic = "persistent://ml/test_company/test"
print(f"Testing client {client} in Realm on topic {test_topic}")
test_producer = temp_client.create_producer(
    topic=test_topic, send_timeout_millis=5000
)
img_list = [
    "./pulsar-test/images/8375743808_a43f504e44_b.jpg",
    "./pulsar-test/images/8886531759_033e06ea68_b.jpg",
]
for x in range(len(img_list)):
    print(f"{x} - Image")
    rnd_img = cv2.imread(img_list[x])
    print("after imread")
    _, image_np_array = cv2.imencode(".jpg", rnd_img)
    print("after imencode")
    image_byte_array = image_np_array.tobytes()
    print("after tobytes")
    # img_h, img_w, channels = rnd_img.shape
    # send to pulsar producer here...

if name == "main":
main()
`
Any advice on further debugging would be highly appreciated! thanks

The issue had no activity for 30 days, mark with Stale label.

Closed as answered. It seems the original issue has been resolved.
The development of the Python client has been permanently moved to https://github.com/apache/pulsar-client-python. Please open new issues there if any.


Update changelog

Thanks @peterfriese.
@paulb777, do I move the release tags to include this? Since https://github.com/firebase/firebase-ios-sdk/pull/9401 was merged since the last tag update, I'd have to create a separate release branch for this PR, right?

@ncooke3 No need to create a release branch.  It's not necessary for release notes to be on the release branch, since their version is specified in the file.  It's fine to stay in master.  cc: @morganchen12


Add type definitions badge

Hi @sindresorhus! I added this badge to Shields at your suggestion badges/shields#1252, and though I'd see if you'd like to include it here!

It is really long.
The reason I had included the version numbers was to help developers distinguish between well maintained libraries, whose defs are being kept up to date, and libraries which aren't. It seems like the version number is useful for that. That said, I'm relatively new to TypeScript and Flow so I appreciate your perspective on this!

Further thoughts?

The reason I had included the version numbers was to help developers distinguish between well maintained libraries, whose defs are being kept up to date, and libraries which aren't. It seems like the version number is useful for that.

What if my library is mature and stable and doesn't need updates? Many packages don't even have TS or Flow as development dependencies.

I would go for number 2.

I see. Thanks. :+1:
Could I ask a couple other questions?
For packages that don’t declare the dependencies, is there a better way to infer their type support?
Is it possible that a future breaking change to the language would require definitions to be updated, even if the library is mature?

For packages that don’t declare the dependencies, is there a better way to infer their type support?

For TS, you could look for a index.d.ts file in root or a types field in package.json.
For Flow, you could look for a index.js.flow file in root or a flow-typed directory in root.

Is it possible that a future breaking change to the language would require definitions to be updated, even if the library is mature?

Yes, but I don't think a version is a good enough indicator of that. TS might break a library in a minor release or never. It really depends on what features you use and how. For simple node modules, it's unlikely new versions will break much.

Great. Thanks so much for the feedback. Give me a few days and I will make some updates to the badge.

@paulmelnikow Can this be finished now?

Late to the game but 2 was the choice I would have made as well.
Just for some validation 💃

Resolved the conflicts. Only issue I see, which is super nit-picky, is a wrap of a single badge:

SGTM, thanks @sindresorhus and @paulmelnikow!

Ah yep! Thanks for merging this!


Fixed broken URL for dcode.vm

dcode.vm package is broken and throws error 404 when downloading installer.
ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://www.digital-detective.net/download/download.php?downcode=ae2znu5994j1lforlh03'. Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (404) Not Found."
The install of dcode.vm was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\dcode.vm\tools\chocolateyinstall.ps1'.
 See log for details.

Following the original link in browser returns...
https://www.digital-detective.net/download/downloadbac.php?downcode=ae2znu5994j1lforlh03
...downloadbac.php?... instead of ...download.php?...
Does the command, Get-WebFIle, have problems following redirects? Hope this is helpful.

@Ana06 thank you! I made the changes like you suggested, but it looks like my fix is not what is needed; both URLs produce the error. I tried downgrading chocolatey to 2.3.0 from the current 2.4.0 on my install of Flare - but that did not work either. I thought that maybe it could have been caused by the recent release.

@Ana06 sure - I'll share whatever logs from choco as well


feat: lsp find_def for dict type

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y #524

2. What is the scope of this PR (e.g. component or file name):
lsp
sema

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Enhance find_def in lsp for dict type, used for lsp goto def and hover

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.988%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2300

Relevant Lines:
2614

💛  - Coveralls


An optional type should be available with the CamundaBpmCorrelationKey

When sending the CamundaBpmCorrelationKey, it is automatically extracted as a String from the properties. This should be the default value. We added a new constant "CamundaBpmCorrelationKeyType" where e.g. the value "java.lang.Long" can be passed. This saves us from parsing the String over and over in out code, since we know it is a Long.
It was a minor fix in the org.camunda.bpm.camel.component.producer.MessageProducer class.
Tests were added and a new constant in org.camunda.bpm.camel.component.CamundaBpmConstants (CAMUNDA_BPM_CORRELATION_KEY_TYPE)

Hi ArashAmiri,
thank you for providing this pull request. The maintainer of this community extension @berndruecker  is currently on holiday and will look into it when he is back.
Best Regards,
Daniel


Remove deprecated POST /api/v2/withdraws

Closed by #1284.

@yivo I assume this functionality is replaced with some alternative workflow?
For example, member makes request to applogic and an admin then makes request to peatio via the management api.
Is that outlined somewhere?

@yivo I am also interested in the response to the question from @sramsden


Added delete icon in comments box and delete method to remove it from db

fixes #212

Registered users can delete their own comments.

sir i can delete anyone comment how ?

@TejasNasre : Fixed it. Now, you will able to delete only your comment


<EMAIL_ADDRESS>decompress error

Scoop version
> scoop --version
Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
c237f510a (HEAD -> master, origin/master, origin/HEAD) z.lua: Update to version 1.8.19

'extras' bucket:
d46f303ad (HEAD -> master, origin/master, origin/HEAD) wsltty: Update to version 3.7.6

The problem
Scoop returns an error when trying to install MSIAfterburner.
Here is what I am doing. I have replaced my home directory with ***.
> scoop install msiafterburner
Installing 'msiafterburner' (4.6.5) [64bit] from 'extras' bucket
MSIAfterburnerSetup.zip (56.2 MB) [===========================================================================] 100%
Checking hash of MSIAfterburnerSetup.zip ... ok.
Extracting MSIAfterburnerSetup.zip ... done.
Running pre_install script...ERROR Exit code was 7!
Failed to extract files from ***\scoop\apps\msiafterburner\4.6.5\MSIAfterburnerSetup*.exe.
Log file:
  ~\scoop\apps\msiafterburner\4.6.5\7zip.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=msiafterburner%404.6.5%3a+decompress+error

Here is the 7Zip log that Scoop mentions:
> cd ***\scoop\apps\msiafterburner\4.6.5
> cat .\7zip.log

7-Zip 24.08 (x64) : Copyright (c) 1999-2024 Igor Pavlov : 2024-08-11

Scanning the drive for archives:

Command Line Error:
Cannot find archive

Here is what's in this folder:
> ls

    Directory: ***\scoop\apps\msiafterburner\4.6.5

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          11/10/2024    10:53            154 7zip.log
-a---          05/09/2024    16:57       59236352 MSIAfterburnerInstaller465.exe

Seems that Scoop is trying to unzip this .exe (why though?) and is failing.

I am ready to provide additional info.

Use this for now: From #13671
scoop install https://raw.githubusercontent.com/ScoopInstaller/Extras/f8aced773f644a601ff38479a1ffc1f3615122c7/bucket/msiafterburner.json


feat: launcher icon auto detect from os name

Looks good but we can organize this better. Let's move the distroIcons array to lib/constants/distro.ts (new file). Then we can move the getDistroIcon() function into the bottom of Utils.

I also updated some code to use the helper capitalizeFirstLetter as we were doing it manually in different places


adds serveral result data

-adds new costrate class as the api returns this value
-adds some more fields that will be responded by the Api
-adds error handler thats outputs deserialization errors to console if json deserialization on the api fails
you can remove the
int mk=0; :)
this was for debugging

Hey, thanks for the contribution!
I just have a few suggestions:

Can you move error handling to a different PR (and replace console logging with ILogger and Log Error?
I couldn't find any of the new properties in the Clockify API docs. Can you point me to those endpoints, that you've found?

I will change the error handling as soon as i have some time left.
When you said, that the fields are not available in the api, i also counterchecked. you are right, they are not visible in the api documentation. But we use clockify at my company everyday and i modified your code, because one of my applications crashed because of these new? values. trust me, they are there.. I made a postman call to the clockify api and the fields (especially  the "myStartOfDay" fiield) is sent in the api response. I counterchecked with the clockify account settings, and the myStartOfDay value displayed in the api is the equivalent to "Day Start" (also see attached screenshot). Maybe there are other values as well that are not being documented in the api documentation but will be responded by the api. I contacted Clockify as well but did not get an answer yet.

I guess I can trust you. They aren't breaking changes anyway so I can merge it :)

I just received an answer from the clockify team.. they said, that indeed the values are not documented yet and the support guy will forward this to the dev team ^^.

I love Clockify support. They are awesome!


BAU - Update saml libs to use new verify-saml-libs repo

-Remove unused saml-domain-objects dependency
-Remove unused saml-test-utils dependency
-Remove unused ida-saml-extensions-test dependency
-Specify type of keys in TestRpAppRule
-Change module to provide, due to dependency injection being removed from saml-security
-Change Optionals to use java utils instead of Guava
Solo - @jhjava

@cobainc0 and I pair-reviewed it. Changes look good. Really tidy now that we use the saml-libs version!


bosh sync blobs sha1 mismatch

Not 100% why but latest version of bosh cli I get
/home/lnguyen/.rvm/gems/ruby-2.2.1/gems/blobstore_client-1.3163.0/lib/blobstore_client/sha1_verifiable_blobstore_client.rb:38:in `check_sha1': sha1 mismatch expected=3af011cc19b21c7180f2604fd85fbc4ddde97143 actual=e62d3649ce2710833408f1ab451a1c7ef506c631 (Bosh::Blobstore::BlobstoreError)

on bosh sync blobs. It worked for a friend on 1.3147.0 so I switched to using that and it works. Haven't had time to pin point version that it broke on. Anyone seeing this?

Does this happen consistently? This error is shown when downloaded blob did not match expected sha1. That may happen when somehow either remote blob is corrupted or download procedure was somehow corrupted and transferred bits are not correct.

It happen consistently, it's interesting that when I revert back to older version it just works and I know remote isn't corrupted because bosh.io can even cut releases. Will try again today and see what happens.
On January 6, 2016 at 7:49:27 PM, Dmitriy Kalinin<EMAIL_ADDRESS>wrote:
Does this happen consistently? This error is shown when downloaded blob did not match expected sha1. That may happen when somehow either remote blob is corrupted or download procedure was somehow corrupted and transferred bits are not correct.
—
Reply to this email directly or view it on GitHub.

Just met this with bosh-cli:  BOSH 1.3167.0
 bosh upload release ./releases/networking/networking-5.yml
Acting as user 'admin' on 'micro-bosh'
Downloading from blobstore (id=772fcc8a-c4c7-4119-9722-c51a9140c47a)...
Blobstore error: sha1 mismatch expected=28a1d88aba72724f0a4b0173a814c8c3bd36448c actual=f97f1ebad98e3d29ac2aed31c9df8381f25bea48

Any release that uses the encryption_key feature (like the networking release) will hit this problem if using a bosh cli version > 3144. See this post.

Ah that would be it. I just sent a response about this to the mailing list.
On Thu, Jan 7, 2016 at 10:32 AM, Ferran Rodenas<EMAIL_ADDRESS>wrote:

Any release that uses the encryption_key feature (like the networking
https://github.com/cf-platform-eng/networking-boshrelease/blob/master/config/final.yml#L9
release) will hit this problem if using a bosh cli version > 3144. See this
post
<EMAIL_ADDRESS>.
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry/bosh/issues/1079#issuecomment-169765003.


PooledConnection return on panic

In PooledConnection's Drop impl, it seems that unless the connection has been extracted via take, the connection is unconditionally returned to the queue. This concerns me, as the Drop may have been invoked during unwinding, and the connection itself may have initiated the panic, and as such may contain broken invariants, which has_broken and is_valid may not be appropriate to detect.
I considered wrapping my connection type in a type that detects panics on drop, but, of course, the inner connection type does not get dropped if it's returned to the pool. It might be possible to wrap the connection type after .get()ing it from the pool in a type that extracts and drops it on drop if the thread is panicking, but that seems awkward and error-prone. (I tried the outer wrapper approach, but take() isn't public.)
Is there currently an intended way to handle panics? If there isn't, then if my concern is valid, might it be reasonable to (maybe based on a flag) check std::thread::panicking in the Drop implementation, and drop the connection instead of returning it to the pool if it's true?

This concerns me, as the Drop may have been invoked during unwinding, and the connection itself may have initiated the panic, and as such may contain broken invariants, which has_broken and is_valid may not be appropriate to detect.

This seems pretty theoretical -- do you have a concrete scenario in mind?
I suppose it might not hurt too avoid calling put_back() in the panicking() case. However, in that case we should probably make sure to call replenish_idle_connections().

So I don't have a case for broken invariants within the underlying transport, but as a simple example, the current use case involves sending N messages on a WebTransport (~QUIC) stream and awaiting N messages in response. In case of a panic, there may still be messages in transit for that stream ID, so that implicit pairing of requests and responses may go out of sync. Of course, there are designs that can handle this better without closing the connection, but that's an example of a use case.


Mutaz Awad

📚 Documentation
(A clear and concise description of what the issue is.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)

😭😭😭😭


[keymgr] Correct error classication

Fix #7852
Correctly classify invalid kmac output error.
Previously it was somehow both a fatal error and an operational error.
Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

@weicaiyang can you see if this addresses your issues?
i think you are right and kmac_invalid_out was indeed mis-classified.


Better documentation for stoppable option

Codecov Report

Merging #251 into master will decrease coverage by 5.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #251     +/-   ##
=========================================
- Coverage   90.35%   85.26%   -5.1%
=========================================
  Files          20       20
  Lines        1307     1296     -11
=========================================
- Hits         1181     1105     -76
- Misses        126      191     +65

Impacted Files
Coverage Δ

src/reduce.jl
74.22% <ø> (-0.27%)
:arrow_down:

src/interop/onlinestats.jl
0% <0%> (-100%)
:arrow_down:

src/show.jl
72.5% <0%> (-22.5%)
:arrow_down:

src/processes.jl
75.47% <0%> (-11.33%)
:arrow_down:

src/progress.jl
76.59% <0%> (-10.64%)
:arrow_down:

src/library.jl
92% <0%> (-2.47%)
:arrow_down:

src/unordered.jl
95.74% <0%> (-0.09%)
:arrow_down:

src/core.jl
89.87% <0%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0c0d7...11e94fa. Read the comment docs.


rust-client/: Ensure client discovered public addrs before punching

For a hole punch to succeed, the local node needs to know its public (/external) address.
The current implementation depends on learning its external address through the relay node. In case the remote client initiates the DCUtR protocol before the relay node told us our public addresses the hole punch fails.
Consider connecting to some random node first, to learn ones public address before initiating the connection to the remote client and relay.
Related code in the rust-libp2p DCUtR client:
https://github.com/libp2p/rust-libp2p/blob/66c275520d8cf56152cce9a1c24bb4e2c42e0833/protocols/dcutr/examples/client.rs#L192-L223
//CC @elenaf9 I remember we talked about this, but I fail to recall what the result of that conversation was. Do you think the above might be an issue today?

//CC @dennis-tra as I am curious how the Golang implementation solves this. Just in case you know it already. Otherwise I will dive into the Golang code myself.

The go-client connects to PL's bootstrap nodes and blocks execution until it has learned its public addresses (this doesn't take long). There's this WaitForPublicAddr function:
https://github.com/dennis-tra/punchr/blob/dbad93c29b54580b40d1726ef61bd2ea6e923cb8/cmd/client/host.go#L134
I've copied that bit from the go holepunch implementation.


Add Wheels to PyPi

Well this is the big one, last summer I wasn't really aware of python wheels but this looks like a great way to distribute pre-built binaries. What is even better, I have read tutorials that show how to do this with appveyor and travis, so I could potentially have artifacts built for me by those services!

started working on this in #142.
Windows for now will probably be the only platform with python wheels, as linux does not support them from what I have read so far, but I could maybe do wheels for mac..

resolved in #142, sha: 1c3de19f1dadd99a3b18a82fcca2364ffc141e4b


Annotation PrivateOwned seems not enough to update an change in the list of children

I have two entities:
@Entity
@Table(name = "parent")
public class Parent {

    private long id;

    @PrivateOwned
    @OneToMany(mappedBy = "parent", cascade = CascadeType.ALL)
    private List<Child> children;
}

@Entity
@Table(name = "child")
public class Child {

    @ManyToOne
    @JoinColumn(name = "parentobjectid")
    private Parent parent;
}

I was using the following code:
Parent parent = createParentWithTwoChildren();
parent.save();
parent.getChildren().remove(0);
parent.save();

But after persisting a parent-entity with children, it was not possible to update the list of children without loading the entity again (using a finder).
Test 'shouldPass' will pass because a finder is used (maybe Ebean.refreshMany can also be used instead). Test "shouldPassButFails" will not pass.
@Test
public void shouldPass() throws Exception {
    Parent parent = createParentWithTwoChildren();
    parent.save();
    assertThat(parent.getChildren(), hasSize(2));

    Parent storedParent = Ebean.find(Parent.class, parent.getId());
    storedParent.getChildren().remove(0);
    storedParent.save();

    Parent modifiedParent = Ebean.find(Parent.class, storedParent.getId());
    assertThat(modifiedParent.getChildren(), hasSize(1));
}

@Test
public void shouldPassButFails() throws Exception {
    Parent parent = createParentWithTwoChildren();
    parent.save();
    assertThat(parent.getChildren(), hasSize(2));

    parent.getChildren().remove(0);
    parent.save();

    Parent storedParent = Ebean.find(Parent.class, parent.getId());
    assertThat(storedParent.getChildren(), hasSize(1)); // fails
}

Thanks @rbygrave !


Multi-Party Approval

Epic
Multi-Party Approval

Epic Title
Multi-Party Approval

T-shirt size default is L(arge)
L

Description
Allow for system to automatically triage approvals needing more than one person's approval prior to provisioning permissions to applications/systems for a specific person as per request.

Multi-Party Approval
The first supported scenario for multi-party approval will be for re-authorizations.
That means, someone is a member of a role, but their membership in that role must be re-confirmed or it will expire.
Re-Authorization is required by at least one role owner, and by the manager of the member.
Thus, from a User Interface standpoint, the first requirement is to visually distinguish Access Requests from Re-Authorization Requests.
We will add a type on the proposal, so you can distinguish them.
For example, presently we have type = ADD_ROLE_MEMBER
We will add REAUTH_ROLE_MEMBER
A question for @ChrisSpanton, if someone REJECTS a REAUTH request, does the member lose access to that role immediately or upon expiration. I presume the former.
The other element of Multi-Party Re-Authorization scenario, is that the user's manager will see the request in addition to the role owners. For this, the User Interface doesn't need to do anything; that assignment happens on the back-end.
So really, that is all there is to our first supported Multi-Party approval scenario. @pgobin
To demo this feature, we can configure reauthorization to be required every 6 months, and that re-authorization requests occur 6 months prior to expiration. In reality, the values will be 6 months and perhaps 1 month respectively.
A question regarding this feature, I presume the user should need to enter a reason why they still need access to the role prior to the Re-Auth Request being visible to the approvers? CC @ChrisSpanton
From a security standpoint, it could be valuable to allow any role owner to require any (or all) existing members to re-authorize. (A manual re-authorization trigger)
We could also configure a SECURITY_LEVEL configuration on a role, and have SECURITY_LEVEL = 1 (default) require 1 role owner, but SECURITY_LEVEL= 2 require 1 role owner + the manager. Thus would be equivalent to the Multi-Party requirements of Re-Auth, but requires no UI change at all.

migrated to new tmobile/sawtooth-next-directory repo


Add Filter class for commonly used filter

Issue

Add separate Filter class for commonly used filters. In this case add useful filter for trimming text
string to a certain amount of characters.
Decouple Twig class. Move all filter methods like add_list_separators , time_ago. (Not included in this pull request).
Solution

Create new class Filter. Add trim_characters method. Modify Twig class, add new Twig_SimpleFilter
Impact

Uses mb_strimwidth (PHP 4 >= 4.0.6, PHP 5, PHP 7) , wordpress functions __() for localization and
wp_strip_all_tags for striping all tags from input text.
Usage

By default string is trimmed to 60 characters.

                    {{ post.post_content|excerpt_chars }}

You can specify desired characters amount

                    {{ post.post_content|excerpt_chars(130) }}

It is possible to specify custom excerpt (more text). By default … is used

                    {{ post.post_content|excerpt_chars(130,'[...]') }}

Considerations

I would suggest to decouple Twig class and move all filters to the Filter class.

Coverage decreased (-0.2%) to 90.056% when pulling 73d74f6f3a168f2185205297e0ab0aa47310c95b on CROSP:content_filters into 64e4e960b544052dd10fe37d3f541f2023a1df64 on timber:master.

Current coverage is 91.80% (diff: 14.28%)

Merging #1176 into master will decrease coverage by 0.16%

@@             master      #1176   diff @@
==========================================
  Files            40         41     +1
  Lines          3275       3282     +7
  Methods         410        411     +1
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3012       3013     +1
- Misses          263        269     +6
  Partials          0          0

Powered by Codecov. Last update 64e4e96...e3c6309

Coverage decreased (-0.2%) to 90.056% when pulling 73d74f6f3a168f2185205297e0ab0aa47310c95b on CROSP:content_filters into 64e4e960b544052dd10fe37d3f541f2023a1df64 on timber:master.


Can't start react app created by create-react-app 3.4.0

What command I used: npx create-react-app my-app --template typescript
create-react-app:3.4.0 (npx create-react-app --version)

But I have check the version of babel-eslint in node_modules

I just create a project,didn't add any package to package.json
{
  "name": "my-app",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@testing-library/jest-dom": "^4.2.4",
    "@testing-library/react": "^9.3.2",
    "@testing-library/user-event": "^7.1.2",
    "@types/jest": "^24.0.0",
    "@types/node": "^12.0.0",
    "@types/react": "^16.9.0",
    "@types/react-dom": "^16.9.0",
    "react": "^16.13.0",
    "react-dom": "^16.13.0",
    "react-scripts": "3.4.0",
    "typescript": "~3.7.2"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

It is really strange.

I don't want to skip the preflight check,Is there any other solution?

Same to #8328

Resolved.
I found a package.json & yarn.lock & node_module in parent folder.
After I delete it. It works.


/boot not mounted after reboot

Possibly because of https://github.com/aanderse/teraflops/blob/9b7cc368ffb7b3b3694286316db5dbe8b34d0b5f/nix/hcloud/default.nix#L42-L44 not specifying the /boot filesystem.
This causes subsequent deployments to be "wiped" after a reboot, as nixos cannot switch the profile in the bootloader.
In my case, boot is /dev/sda15.
Using hetzner cloud

hey i have a number of hcloud machines and none of them have a separate /boot partition - did you specifically create this?
can you please paste your teraflops config? maybe some of the hcloud machines have a /boot depending on the server_type?

{
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";

    teraflops.url = "github:aanderse/teraflops";
    teraflops.inputs.nixpkgs.follows = "nixpkgs";
  };

  outputs = { nixpkgs, teraflops, ... }:
    let
      system = "x86_64-linux";

      hcloud-servers = [ "aries" "centaurus" ];
      hcloud-config = {
        server_type = "ccx13";
        location = "nbg1";
      };

      server-config = { pkgs, lib, ... }: {
        environment.systemPackages = with pkgs; [ htop nano zulu17 ];

        networking.firewall.enable = false;

        services.pufferpanel = {
          enable = true;
          environment = { PUFFER_PANEL_ENABLE = "false"; };
          extraPackages = with pkgs; [ bash curl gawk gnutar gzip ];
          package = pkgs.buildFHSEnv {
            name = "pufferpanel-fhs";
            runScript = lib.getExe pkgs.pufferpanel;
            targetPkgs = pkgs': with pkgs'; [ icu openssl zlib ];
          };
        };
      };
    in {
      teraflops = (

        ({
          imports = [ teraflops.modules.hcloud ];
          meta = { nixpkgs = import nixpkgs { system = system; }; };
        })

        // (builtins.listToAttrs (builtins.map (s: {
          name = s;
          value = { pkgs, lib, ... }:
            ({
              deployment.targetEnv = "hcloud";
              deployment.hcloud = hcloud-config;
            } // (server-config { inherit pkgs lib; }));
        }) hcloud-servers))

        # TODO: Other providers/manual servers
teraflops nix apply --reboot
      );
    };
}

The reason I suspect it's the boot not mounting, is the following error when changing the config, and running teraflops nix apply --reboot:
 teraflops nix apply --reboot
warning: Git tree '/home/polarizedions/programming/cosmos' is dirty
[INFO ] Using configuration: /tmp/teraflops.6q_uof5o/hive.nix
warning: Git tree '/home/polarizedions/programming/cosmos' is dirty
[INFO ] Enumerating nodes...
warning: Git tree '/home/polarizedions/programming/cosmos' is dirty
warning: Git tree '/home/polarizedions/programming/cosmos' is dirty
[INFO ] Selected all 1 nodes.
      🕚 33s 1 running, 5 succeeded
aries ✅ 4s Evaluated aries
      🕙 42s 1 running, 5 succeeded
aries ✅ 4s Evaluated aries
      🕑 47s 1 running, 5 succeeded
aries ✅ 4s Evaluated aries
      ❌ 53s Failed: Unexpected active profile: Profile(StorePath("/nix/store/2idgdn6h5gcwg0bk9ahpf6qf7fcmwzxk-nixos-system-aries-24.05pre-git"))
aries ✅ 4s Evaluated aries
aries ✅ 1s Built "/nix/store/a60y9mv85hc6dgvr0ranrww2pfrj09v8-nixos-system-aries-24.05pre-git"
aries ✅ 9s Pushed system closure
aries ✅ 5s Will be activated next boot
aries ❌ 34s Reboot failed: Unexpected active profile: Profile(StorePath("/nix/store/2idgdn6h5gcwg0bk9ahpf6qf7fcmwzxk-nixos-system-aries-24.05pre-git"))
[ERROR] Failed to complete requested operation - Last 1 lines of logs:
[ERROR]  failure) Unexpected active profile: Profile(StorePath("/nix/store/2idgdn6h5gcwg0bk9ahpf6qf7fcmwzxk-nixos-system-aries-24.05pre-git"))
[ERROR] Failed to reboot aries - Last 4 lines of logs:
[ERROR]  created)
[ERROR]    state) Running
[ERROR]  message) Waiting for reboot
[ERROR]  failure) Unexpected active profile: Profile(StorePath("/nix/store/2idgdn6h5gcwg0bk9ahpf6qf7fcmwzxk-nixos-system-aries-24.05pre-git"))
[ERROR] -----
[ERROR] Operation failed with error: Unexpected active profile: Profile(StorePath("/nix/store/2idgdn6h5gcwg0bk9ahpf6qf7fcmwzxk-nixos-system-aries-24.05pre-git"))

looks like there is a pretty important difference between hetzner servers with cx11, which i have been using, and ccx13, which you are using
taking a look at the results of nixos-infect:
cx11
cat /etc/nixos/hardware-configuration.nix
{ modulesPath, ... }:
{
  imports = [ (modulesPath + "/profiles/qemu-guest.nix") ];
  boot.loader.grub.device = "/dev/sda";
  boot.initrd.availableKernelModules = [ "ata_piix" "uhci_hcd" "xen_blkfront" "vmw_pvscsi" ];
  boot.initrd.kernelModules = [ "nvme" ];
  fileSystems."/" = { device = "/dev/sda1"; fsType = "ext4"; };

}

vs ccx13
{ modulesPath, ... }:
{
  imports = [ (modulesPath + "/profiles/qemu-guest.nix") ];
  boot.loader.grub = {
    efiSupport = true;
    efiInstallAsRemovable = true;
    device = "nodev";
  };
  fileSystems."/boot" = { device = "/dev/disk/by-uuid/36D5-538A"; fsType = "vfat"; };
  boot.initrd.availableKernelModules = [ "ata_piix" "uhci_hcd" "xen_blkfront" "vmw_pvscsi" ];
  boot.initrd.kernelModules = [ "nvme" ];
  fileSystems."/" = { device = "/dev/sda1"; fsType = "ext4"; };

}

a colmena user experienced the same end result you have and mentioned it here
unfortunately the hcloud_server doesn't (yet?) provide any disk info, so we'll have to resort to a less ideal solution like the ssh_resource

i provided a solution in #6, though note that your terraform package now requires the ssh plugin, like so: terraform.withPlugins (p: [ p.hcloud p.ssh p.tls ];


Translation

Some action, workflow or step descriptions are written in english, some in german. We should unify them to use english only.

https://github.com/it-at-m/.github/issues/85 ich würde das bei refractoring sehen


mobile: Remove unused mobile format workflow

We now use ktfmt to format Kotlin code, which is part of Format all workflow. This PR removes the workflow to format Kotlin code with ktlint.
Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign @abeyad


Git-for-Web-Development-Project Project!!

I am doing what the README.md is telling me to do.

looks good!


Mapped some more screens & openScreen methods + some other random thi…

…ngs.

Liach can you review the pr

@shedaniel Made your requested changes.


Drop F33 support and add F34/F35 image tests

distro: drop support for Fedora 33
test/api.sh: remove parts related to Fedora 33
Schutzfile: don't pin osbuild on Fedora and drop F33
test: add image test cases for Fedora 34 and 35

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Can we add tests for qcow2 for aarch64, or is there a blocker?

Can we add tests for qcow2 for aarch64, or is there a blocker?

I didn't try to be honest.
I used the same set of image tests which was used for F33. We could probably generate test case also for openstack and oci on aarch64 as they are supported by the distro definition.


fix(material): use bindings instead of formlyAttributes in material

HostBinding attributes like readonly are not respected by Material:
https://github.com/angular/material2/issues/14024
fix #1317
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
https://github.com/formly-js/ngx-formly/issues/1317
Bottom line, @angular/material is not compatible with formlyAttributes, therefore we have to change it to use input bindings (just for @ngx-formly/material).
As well material specific FormlyAttributes was created(FormlyMatAttributes), which does not add the following three attributes, because they should be always added as an inputs: placeholder, tabindex, readonly.
Please check if the PR fulfills these requirements

[x] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] A unit test has been written for this change.
[x] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[x] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

Other information:
Considering the changes made, unit test does not make much sense.
If there is a case where unit test should be implemented please let me know.

Thank you @klemenoslaj!


Update to build against head of badger

badger.Item Value method now takes a func that must return an error

great Chris :) thanks


chore: try codecov token again

I tried this recently in 1a1a820569f0883a317944973c15cf34431dd6c2 and then reverted in b8b1c4224d0ec7d631d26c78922c018dd5b895f5. Unfortunately I'm still seeing spurious failures from codecov, so let's try the token one more time.
This time I double checked the token is provided by https://app.codecov.io/gh/shelljs/shelljs/settings. I regenerated the token for good measure.

I verified that https://github.com/shelljs/shelljs/pull/1150 is being diffed against the right comment for coverage purposes. The real test will be to land 1 more change and see if the diff base stays up-to-date.


No custom channels have been configured on your environment.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fab3b773-a72f-d863-612c-c877366c1d70
Version Independent ID: 52b2322c-964b-24d4-e076-64ab37ddd706
Content: Step 4: Test your custom channel tile (Dynamics 365 Marketing Developer Guide)
Content Source: ce/marketing/developer/test-custom-channel-tile.md
Service: dynamics-365-marketing
GitHub Login: @alfergus
Microsoft Alias: alfergus

Thanks for your comment, @help4mcts. This issue has been assigned to the doc author for review.

Thanks for your question! The best place for product requests or troubleshooting is the Dynamics 365 Marketing forum at https://community.dynamics.com/365/marketing/f/dynamics-365-for-marketing-forum - repost your question there and a developer will be able to help you.


Undo or Clear Formats

Hi guys
I think it would be nice to add the option of undo, remove or clear formats.
What about the ability to preview editor code
thanks

Add this to actions
undo: {
icon: '↺',
title: 'Undo',
result: function result() {
return exec('undo');
}
},
redo: {
icon: '↻',
title: 'redo',
result: function result() {
return exec('redo');
}
},


Package up YARP as a gem

Summary

Wrap YARP as a gem

add a gemspec
add a "rake build" task to package the gem
add a "rake check_manifest" task to validate the gem packaging
extconf.rb knows how to make librubyparser
add CI jobs to test gem packaging and installation

Add test coverage for symbol visibility in static archives and shared objects
Switch the compile-time default to NOT export symbols on non-windows platforms, superseding #1111.

Notable changes
The 'compile' rake task is no longer a dependency of the 'test' task, to allow us to run the test suite against the installed gem in CI. CONTRIBUTING.md has been updated.
Introduce a new check_manifest rake task which validates the gem spec contents as part of rake build.
Notable design choice
"autoconf" is run during gem packaging, and the "configure" script is in the gem. This reduces the requirements on the installation system.

I'd like to merge https://github.com/ruby/yarp/pull/1088 first to avoid conflicts if possible, I fixed more things in the Makefile.
Also I'd be happy to review this PR next week

Right now the failing tests on ruby head are because we don't have a way to specify "load the gem's yarp.rb and yarp.so" and the stdlib versions are being loaded (which causes tests to fail). @k0kubun mentioned he has some ideas on how to handle this.

A notable design choice:
* "autoconf" is run during gem packaging, and the "configure" script is in the gem. This reduces the requirements on the installation system.

Definitely the best :) I did the same for TruffleRuby BTW because our macOS CI doesn't have autotools installed/in PATH by default.

@k0kubun mentioned he has some ideas on how to handle this.

Today I locally confirmed that non-builtin yarp.rb and yarp.so files could be loaded if you modify $LOAD_PATH. It means that technically it's not mandatory to gemify YARP in the interpreter to replace it with a gem.
I was thinking of somehow doing that somewhere, but since a gemspec is not evaluated when Gemfile loads yarp.gem IIUC, there's no way to make it happen automatically on Gemfile unless you add some hack to the interpreter, rubygems, or bundler.
So, just like the existing convention, I think the YARP that is shipped as part of CRuby should be gemified to allow replacing the YARP implementation with a gem.

@tenderlove @k0kubun @jemmaissroff I've updated this branch with:

test coverage of symbol visibility,
switch the compile-time default to hide symbols (superseding #1111)

Note that ruby-head is still failing because of the gem loading issue described above. That failure should go away once ruby stdlib yarp is gemified and contains these commits.
Please let me know what you think.

@tenderlove I answered above, but for posterity: the files listed explicitly in the gemspec which overlap with the globs are generated files, and are not in source control -- so we can't assume they exist. Explicitly listing them is a safety check, and attempting to package the gem without them will fail with an error.
Though, I'm noticing now that include/yarp/config.h is being packaged up because it matches a glob; but we shouldn't be packaging it -- so I'd like to switch to listing every file out individually.

I've force-pushed an update that lists every file in the gemspec individually, which also now correctly does not package include/yarp/config.h.


Variables Reference for Notebook Editor opened files

Environment data

VS Code version: 1.49.1
Extension version (available under the Extensions sidebar): 2020.8.109390
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): 3.7.8
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: -
Relevant/affected Python-related VS Code extensions and their versions: -
Value of the python.languageServer setting: Jedi

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour

path\to\notebook.ipynb echoed to task console

Actual behaviour

Error message:

'${relativeFile}' can not be resolved. Please open an editor.

Steps to reproduce:

Create shell task with "command": "echo ${relativeFile}", tasks.json example:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "ipynb",
            "type": "shell",
            "command": "echo ${relativeFile}"
        }
    ]
}

Run task while any .ipynb file is opened in Notebook Editor

Thank you for creating an issue @delmarrerikaine. I'm thinking relativeFile cannot be resolved because you might not be using a workspace, I was able to execute that task. I have a couple of questions for you.

Do you have an open workspace in vs code?
Could you try with ${file} instead of ${relativeFile} and see if that works.

For reference, my task looks a bit different:
{
    "version": "2.0.0",
    "presentation": {
        "echo": true,
        "reveal": "always",
        "focus": false,
        "panel": "shared"
    },
    "tasks": [
        {
            "type": "shell",
            "command": "echo ${relativeFile}",
            "label": "ipynb",
            "problemMatcher": [],
            "group": {
                "kind": "build",
                "isDefault": true
            }
        }
    ]
}

Thanks for looking into it @DavidKutu.

I am using the workspace.
both ${file} and ${relativeFile} show "${} can not be resolved. Please open an editor."

I have used your task file and error is easily reproducible with or without workspace on different projects with different settings.
Please see the repo with the most basic reproduce (done on a different machine) :

Thank you for the gif, that's very helpful. I have another question. Does that only happen with ipynb files? Does it work with py files?

Looking further into it, this should get solved when we release native notebooks.
You could try them out here: https://devblogs.microsoft.com/python/notebooks-are-getting-revamped/ and check if the issue persists.

This only happens with an ipynb files opened in notebook editor.
E.g., if we set: python.dataScience.useNotebookEditor to false which will open ipynb as JSON in a text editor - the behavior matches the expected one.
Native notebooks solve this issue; the problem is not reproducible there. Is there any ETA when it will be available as part of the regular VS Code version?

Unfortunately, I can't give you an ETA, but I can say we are working on it and its a priority for us.

@delmarrerikaine. Thanks for the feedback. There's another way to address this issue and that is to opt into the the "Custom Editor" experiment in user settings. Currently there's a bug that's keeping us from turning it on completely. When you save a notebook with ctrl-s, you may see an error that the save didn't work. However, it did. :)
"python.experiments.optInto": [
    "CustomEditorSupport - experiment"
  ],


Issue #924 - new lookup table and guards on table create SQL statements.

As described in issue #924, this PR is to add a lookup table to allow backend DB queries to expand the numeric values in the execution_flows.status field.   Additionally guards were put in place to prevent 'create table' statements from overwriting existing tables.  I also specified that InnoDB should be the default DB engine for each table.  (InnoDB is the default in MySQL 5.5.5 & newer.)
Testing was done manually.  After running 'gradlew distTar', I ran the schema script on a new database, followed by mysqldump to confirm the contents looked sane.   If there's a better way to test sql statements, I would be happy to test them.
Thanks.

@HappyRay requested I split this PR into multiple commits as several changes are included with this PR.  Will close this PR and submit new ones containing single changes.


Add OVERDOSE PARTY by mewingman

Song Name
OVERDOSE PARTY
Artist Name
mewingman
Source
Youtube
Youtube Link
OCV08i2rJJA
Direct File Link
No response
Song ID
888
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 110574739
Downloaded: Yes

I hope is good


Fix: Make calendar icon for input[type="date"][aria-invalid] clickable on Chrom*

On Chrom*, the calendar icon is currently not clickable (in order to open the calendar to pick a new date), if the input field (i.e. of type="date") has the aria-invalid attribute.
Minimal file to display the bug:
<!doctype html>

    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="stylesheet" href="https://unpkg.com/<EMAIL_ADDRESS>    <title>Date Input Field Bug</title>

Date Input Field Bug

Calendar icon is not clickable when aria-invalid attribute is present on Chrom*.

      Note: on Safari and Firefox it seems to work as expected.

Icon clickable as expected

      <input type="date" id="date" name="date">

Icon NOT clickable

      <input type="date" id="date" name="date" aria-invalid="true">
      <input type="date" id="date" name="date" aria-invalid="false">

Sorry, closed by mistake

@lucaslarroche No worries. 👍
Should I still rebase this branch to solve the conflicts shown above, or is this PR not relevant?
Cheers.

Thanks for the find.
I hadn't had time to test. I just did. Sorry for the delay.
I'm going to merge into dev, then change the syntax from :not([type="A"]):not([type="A"]) to :not([type="A"], [type="B"]) and add all the other types:   datetime-local, month, time, week


v1.9 backports 2021-04-07

#15357 -- cilium: encryption, auto-discover interface and subnet (@jrfastab)

Once this PR is merged, you can update the PR labels via:
$ for pr in 15357; do contrib/backporting/set-labels.py $pr done 1.9; done

test-backport-1.9


Standardization 4

Follow-up to #1131 #1161 #1164 #1282
Contributes to #1119

TODO after this:
crypto_derive
failure_macros
grpc_helpers
ir_to_bytecode
ir_to_bytecode_syntax
language_e2e_tests
libra_wallet
stackless_bytecode_generator
storage_proto
transaction_builder
vm_cache_map
vm_genesis
vm_runtime
vm_runtime_types
vm_validator

@bors-libra r+

:pushpin: Commit 6832304 has been approved by bmwill

:hourglass: Testing commit 6832304efa9a9cec5321e4262474e34a51ea2c17 with merge 1c21c42d2e184ba00f0e01e1d0c849da16594070...

@bmwill Does that output look right to you? Seems like cargo lockfile diff is giving weird output.

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bmwill
Pushing 1c21c42d2e184ba00f0e01e1d0c849da16594070 to master...

@metajack Ack. looking at the weird socket-bench-server / socket 2 output

@metajack Looks like its working as intended, since this diff removes crates with _ in their name and adds crates with - in their name


Preview releases should have the "Pre-release" marker in the GitHub release

When we create a release on GitHub (for a corresponding release to a public feed) and the release/tag contains the word preview in the version (or "b" for Python) we should have the "Pre-release" marker set for the release (example).  For preview 1 we manually edited the releases and checked the "This is a pre-release" box to accomplish this.
This needs to be done for releases from all 4 repos:

[x] azure-sdk-for-net
[x] azure-sdk-for-js
[x] azure-sdk-for-java
[x] azure-sdk-for-python

This does not need to be done for the partner release pipelines.

Resolved with a PR to azure-sdk-build-tools repo


feat: view LaneId on PathWithLaneIdFootprint plugin

Description

view lane id for each path points

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

pre-commit.ci failed. Could you fix it?
common/tier4_planning_rviz_plugin/include/path_with_lane_id_footprint/display.hpp:86:  Add #include <utility> for pair<>  [build/include_what_you_use] [4]
Done processing common/tier4_planning_rviz_plugin/include/path_with_lane_id_footprint/display.hpp

CI is good, so I'll merge it.


Added Awesome Software Patreons

This PR adds https://github.com/uraimo/awesome-software-patreons , a list of patreon accounts of individual software developers or software projects.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either fullwidth or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.
Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of sub-lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.
Yup, read and understood!

Hey, sorry for the lack of response, please see #1363.

Hi @uraimo
I have a couple of suggestions to improve your list (but on the whole your list seems to mostly comply to the current ruleset):

The Contents section should be the first in the list. You can add Contributing section below that, or at the end of the list
You have a LICENSE file, but you could add a License section at the end of the list, similar to that in the top-level awesome
Not sure if this is still a requirement, but the URL in the PR should better end with the #readme hash

@uraimo ⬆

All done, now waiting for something new to review :)

I've started reviewing PRs, will adde them below as I progress through the list:
#1358
#1375
#1393
#1319

It's open source or open-source, not opensource`.
iTerm2 - iTerm2. This is not a good description.
Descriptions should not be titlecase (unless of course it's a name): Ubuntu Email Client. => Ubuntu email client.. Applies to many other descriptions too.
Bittorrent => BitTorrent
ECommerce => Ecommerce
Javascript => JavaScript

GIMP - Øyvind Kolås, lead developer of GIMP.

The description should include what GIMP is.

Improved Initiative - D&D Combat tracker.

Should mention what D&D is.

Tiled - a 2D game level editor.

Not correctly capitalized.

Objective-See, various mac security tools and articles.

mac => Mac

Joey Hess - git-annex, keysafe, other linux software.

linux => Linux

Ethan Lee - XNA Preservation Tools and Linux/Mac Games

Should end in a dot.

Includes a succinct description of the project/theme at the top of the readme. (Example)

Thanks for the throughout review, I've fixed similar issues to the one you pointed out elsewhere and improved some project descriptions too.

Fixed conflict, should have been able to do it on its own...

Tweet: https://twitter.com/awesome__re/status/1049182112031465473


Support for other branches of Edge (Beta, Dev, Canary)

Could you please add this? Because I really don't use the Stable release...

It's already supported. Does it not detect your installation?

Oh sorry, it was just slow the first time, now it appears to work correctly!

Yes, the first time running the plugin it's a bit slow! Glad it's fixed


Whitehat Sentinel: Fix for report with zero findings

Description
The Whitehat sentinel parser was throwing an error when the number of alerts in the uploaded file was zero. This prevented the closing of open findings when the number of findings drops below 1.
Test results
No changes
Documentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.

[x] Make sure to rebase your PR against the very latest dev.
[ ] Features/Changes should be submitted against the dev.
[x] Bugfixes should be submitted against the bugfix branch.
[ ] Give a meaningful name to your PR, as it may end up being used in the release notes.
[ ] Your code is flake8 compliant.
[x] Your code is python 3.11 compliant.
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[ ] Add the proper label to categorize your PR.

Extra information
Please clear everything below when submitting your pull request, it's here purely for your information.
Moderators: Labels currently accepted for PRs:

Import Scans (for new scanners/importers)
enhancement
performance
feature
bugfix
maintenance (a.k.a chores)
dependencies
New Migration (when the PR introduces a DB migration)
settings_changes (when the PR introduces changes or new settings in settings.dist.py)

Contributors: Git Tips
Rebase on dev branch
If the dev branch has changed since you started working on it, please rebase your work after the current dev.
On your working branch mybranch:
git rebase dev mybranch

In case of conflict:
 git mergetool
 git rebase --continue

When everything's fine on your local branch, force push to your myOrigin remote:
git push myOrigin --force-with-lease

To cancel everything:
git rebase --abort

Squashing commits
git rebase -i origin/dev

Replace pick by fixup on the commits you want squashed out
Replace pick by reword on the first commit if you want to change the commit message
Save the file and quit your editor

Force push to your myOrigin remote:
git push myOrigin --force-with-lease

@37b closing this one for now. Feel free to reopen :)

@37b closing this one for now. Feel free to reopen :)

Uhh I forgot. Will do.