Manipulating the scene tree gets progressively slower with more nodes added to the tree in the editor.

Godot version
4.2 beta 1
System information
Windows 11 - Vulkan - Nvidia RTX 4070 - intel i5 13600KF
Issue description
The more nodes there are in the tree the slower working with the tree gets. I don't even have that many and moving one node in my tree in my game inside editor takes seconds (editor freezes for several seconds until it moves the node in the tree (not even moving it in space).
In the past in 4.1, or 4.0, I believe I had the same scene with much higher node count and it didn't seem to have this kind of slow down.
Link video: https://youtu.be/SAilvoE_ACc
(check how I release the mouse and move it away and how long it takes to make nodes move)
Use the MRP, there are two scenes, main and test_no_mesh_instances, feel free to use either just understand the main has an extreme amount of mesh instances in one places, the latter uses only Node3D hiearchy so it should be a lot less intensive on HW.
I've also purposely added a lot of nodes just to make the issue clear, in my game I don't have even nearly as many nodes but the freeze times are even longer than in MRP.
Please note my HW specs, it's not the highest end but certainly no slug either.
Steps to reproduce
Steps:

Open the MRP
Open one of the scenes
Add a Node3D, Camera3D, WorldENvironment or any node into the sceen tree
Move the tree from last position to the very top of the tree for example, then move it elsewhere if you want
Observer the editor freezing as it's moving your node in the sceen tree.
(6. if you have Frame Time open it will show yo ua spike for GPUT TIme and maybe even CPU Time in red after it moves the nodei n the tree)

Minimal reproduction project
ManyNodesSlowTreeMRP.zip
EDIT: Not just moving but also simply deleting a node takes forever too.

There might be some performance issues either in the Tree control itself or in the editor scene tree implementation when using a lot of nodes / tree items. Some was improved in https://github.com/godotengine/godot/pull/79325, but as the discussion there shows there might still be some performance issues left.
Testing with earlier Godot 4.0, 4.1 and maybe some 4.2 dev releases might give a better idea if this is a recent regression or an existing issue.

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/82105 and https://github.com/godotengine/godot/issues/70869.

I think this is an independent issue, or at least worth an investigation. https://github.com/godotengine/godot/issues/84910 was opened afterwards, which I believe is very much relevant here.
Let's give this a test and try to pin the cause. I believe someone on the chat identified that similarly to https://github.com/godotengine/godot/issues/84910 this is about updating various references in nodes and resources. So the bigger the tree, the more we need to iterate through.
Some sort of cache for relevant nodes/resources would be a good idea in that case.

The discussion started here: https://chat.godotengine.org/channel/editor?msg=hH42LhRaxLm6cLFK2 (do these links work? It's kind of 50/50 for me :D).
It was also confirmed by another user in dev chat new-contributors when we were profiling what's happening.

This is also an issue for me on 4.3-beta1. Seems like #85502 did not fix it.
In my own project I have many instanced scenes, but in testing I experienced increasing slowdown manipulating the scene tree with simply creating thousands of Node2Ds with a tool script.
I also went back and did the same thing on 3.5 and it was an issue there as well.

@AThousandShips Hi, can we please reopen this report. The PR does not solve this issue.
This is not related to drawing the tree but iterating over all nodes and their properties (recursively) and loads of type casting which slows the processing down a lot.
I've tested the PR and it makes no difference to this issue.
During testing I noticed a new issue or perhaps this issue again (I'm not sure, should I open a new bug report for this: https://youtu.be/zv4fFdvRSf0 - when selecting and unselecting a lot of nodes Godot pretty much freezes and takes very long time as you can see in the video until it selects the nodes, it might be relevant to this issue but I'm not sure)?

I didn't link this but I'll reopen it

I also find the scene tree to be extremely slow in the editor when there are thousands of nodes. In one large scene there are only a thousand or so nodes, but including subscenes, 62,000 nodes. I just spent 5 hours separating a large scene into several smaller ones and half of that time was wasted waiting for Godot to add, rename, move, or delete nodes. I had to spend this time to separate out these nodes because my environment artist couldn't work due to it being so slow. The scene tree is basically unusable past a certain point. I've heard the same complaint from people on my discord, so it's not just our project.
4.3-stable, 4.4dev4.

I was asked to run a profiler on dev chat, and got this file from very sleepy: capture.zip

Basically every property you have it checked, every animation is checked and it goes recursively to make sure there are no links left or something along those lines which means with 62k nodes and like 50 properties on a node on average you have a lot ot checks and type casts (StringName was the biggest hog from type casts if I remember correctly).

This sounds like a fundamental problem with how the engine does stuff.

I did some targeted profiling on just the steps suggested in the MRP and I found that 98% of the time is spend in free() during the pause.
I'll be looking into it further. But I wanted to share my finding so far.

@hpvb
Free as if freeing nodes? Is that also relevant to Renaming, moving around, ... operations, please?

There are a couple of things kinda slow, I'm working on a solution. I'm implementing a skiplist in the Tree data structure in the editor to make create_child() O(log(n)) instead of O(n), that will help with moving and creating nodes.
For the renaming nodes I will have to have another look. But the different operations are slow for different reasons. The 97% time spent in free() was for a renaming operation.

@hpvb Thank you for looking into this! If you don't mind, I don't know if you noticed but in the second half of my reply here I noticed another thing which might be something else but I just wanted point it out to keep it together (and if it's a different issue eventually I'd report it separately): https://github.com/godotengine/godot/issues/83460#issuecomment-2466950940
One more thing you don't mind, are these operations we talk about in the tree handled on a single thread or parallel, I could imagine when it comes to checks against the entire tree that parallelization could also improve the performance perhaps, though I haven't dove so deep into the sceen tree so I don't really know how this processing is handled?

Basically every property you have it checked, every animation is checked and it goes recursively to make sure there are no links left or something along those lines which means with 62k nodes and like 50 properties on a node on average you have a lot ot checks and type casts (StringName was the biggest hog from type casts if I remember correctly).

This sounds like a fundamental problem with how the engine does stuff.

This is/was not the problem, and this is not how it works. What happened was that on each change to the scene tree the SceneTreeEditor would re-create the GUI elements that represent the tree. There is no such checking of links and whatnot happening. This was purely an editor inefficiency, not some hidden design disaster as suggested here.

Basically every property you have it checked, every animation is checked and it goes recursively to make sure there are no links left or something along those lines which means with 62k nodes and like 50 properties on a node on average you have a lot ot checks and type casts (StringName was the biggest hog from type casts if I remember correctly).

This sounds like a fundamental problem with how the engine does stuff.

This is/was not the problem, and this is not how it works. What happened was that on each change to the scene tree the SceneTreeEditor would re-create the GUI elements that represent the tree. There is no such checking of links and whatnot happening. This was purely an editor inefficiency, not some hidden design disaster as suggested here.

I see, cool, this was what I was told in the editor dev channel, I don't really know the details but I'm glad you checked this issue out and worked on it, thank you very much!

What is currently improved is:
Creating nodes
Moving/re-parenting nodes
Deleting nodes
Renaming nodes

Thanks for working on this. These basics are the urgent, critical needs. I would love to see this merged in and cherry picked for 4.3.1.

Stuff that is still slow
Selecting a large number of nodes
Filtering nodes by name or type

These can come later as far as I'm concerned.
I will test your PR in my project soon, and comment there.

Tested locally with a scene containing just shy of 10,000 instanced nodes and delete operation now takes about 1 to 2 seconds, as opposed to 10 to 15 (or more) seconds prior. This is a massive relief. Its been one of my single biggest gripes regarding working in Godot at scale. Coming from using Unity and Unreal in my day-job I'd love it to be even more performant, but this fix alone is monumental! Nicely done all involved.


change httpError logic

if err==nil, then err.Error() will crash, so we need to check whether err is nil on function entry but not on exit, it's obviously meaningless to check on the exit point
Signed-off-by: Zhang Wei<EMAIL_ADDRESS>

ping @tiborvass, update as you suggested, please help review, thank you!
This is cool! Maybe I can help refactor more logrus format function. :D

Thanks @WeiZhang555 !
LGTM

LGTM


Pagination issue when using Semantic Search

Describe the bug
The pagination results behavior changes when I use semantic search. Specifically, it seems to get offsets 0-10 when I specify offset: 5, limit: 5.
To Reproduce
Steps to reproduce the behavior:
In the first two curl commands I turn off semantic search and get the expected results.
In the following ones I turn it on and get the unexpected behavior.
# curl -s -X POST -H "content-type:application/json" -d '{"q":"car","offset":0,"limit":5,"hybrid":{"embedder":"default","semanticRatio":0}}'  'http://localhost:7700/indexes/books/search'  | jq '.hits[].id'
"658c8e3c8e2163f80f97a743"
"658c8e1e8e2163f80f97a2e8"
"658c8fc1372f01b94b520b8e"
"658c8d938e2163f80f978ffe"
"658c8df48e2163f80f979c02"

# curl -s -X POST -H "content-type:application/json" -d '{"q":"car","offset":5,"limit":5,"hybrid":{"embedder":"default","semanticRatio":0}}' 'http://localhost:7700/indexes/books/search'  | jq '.hits[].id'
"658c8ec3372f01b94b51ea56"
"658c8dd58e2163f80f979a1a"
"658c913a372f01b94b523bc7"
"658c9153372f01b94b523f2d"
"658c9205372f01b94b525476"

# curl -s -X POST -H "content-type:application/json" -d '{"q":"car","offset":0,"limit":5,"hybrid":{"embedder":"default","semanticRatio":0.5}}'  'http://localhost:7700/indexes/books/search'  | jq '.hits[].id'
"658c8e3c8e2163f80f97a743"
"658c8e1e8e2163f80f97a2e8"
"658c8fc1372f01b94b520b8e"
"658c8d938e2163f80f978ffe"
"658c8df48e2163f80f979c02"

# curl -s -X POST -H "content-type:application/json" -d '{"q":"car","offset":5,"limit":5,"hybrid":{"embedder":"default","semanticRatio":0.5}}'  'http://localhost:7700/indexes/books/search'  | jq '.hits[].id'
"658c8e3c8e2163f80f97a743"
"658c8e1e8e2163f80f97a2e8"
"658c8fc1372f01b94b520b8e"
"658c8d938e2163f80f978ffe"
"658c8df48e2163f80f979c02"
"658c8ec3372f01b94b51ea56"
"658c8dd58e2163f80f979a1a"
"658c913a372f01b94b523bc7"
"658c9153372f01b94b523f2d"
"658c9205372f01b94b525476"

Expected behavior
To only get offset 5-10 when specifying offset: 5, limit: 5.
Meilisearch version:
v1.8.0

hello @runabol :wave:
The effect you are seeing is caused by the search algorithm of the semantic search. The semantic search uses an Approximate Nearest-Neighbor (ANN) search algorithm to find the limit+offset vectors that are the "closest" to the query vector.
Because the algorithm is approximate, increasing limit+offset might result in "closer" vectors being found, which means that the order of results is not guaranteed to remain stable for two distinct values of limit+offset.
As it is a design characteristic of ANN algorithms, and exact algorithms (kNN) don't scale with the number and size of vectors, this behavior is unlikely to be fixed.
As a workaround, you can set offset to 0, set a large value for limit, and then apply the pagination manually in frontend.
In the future, we might consider some mitigation to this behavior, where we would always, for example, consider the first few hundred results (as if limit+offset would be equal to, say 1000) regardless of the actual value of limit+offset. There's a correctness/performance tradeoff to measure here, though.
Thank you for the report :heart:

Fair enough. Was able to work around this. Thanks!


Fix two test runner issues

This PR contains fixes for:

Two test runner issues

test/index.ts -- This caused the issue that e2e-test step did not fail even when a test case failed
test/testScripts/e2eTestSuiteLauncher.test.ts -- This issue prevent non-Lightspeed e2e tests running regardless of the value of RUN_LIGHTSPEED_TESTS_ONLY envvar.

In addition to those fixes, this PR also contains changes for testDiagnosticsAnsibleWithoutEE. In testing with two fixes shown above, I found that the test "should complain about command syntax-check failed" did not work as expected, i.e. command syntax-check DID NOT fail against diagnostics/ansible/without_ee/2.yml. It looked like the file was recognized as a regular YAML file, not as a playbook. It was fixed by renaming 2.yml to playbook_2.yml.  1.yml was also renamed to playbook_1.yml to be consistent.

@TamiTakamiya Because this change has no effect on shipped code, we use skip-changelog. This avoids cluttering the release notes with work done on testing or CI/CD.


Update multi-region-setup.md

wrong indentation on list

This change is

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f7c610fb65636a98ac641ebf9a6cc16ac73c671c/
Edited pages:

v20.2/multi-region-setup.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f7c610fb65636a98ac641ebf9a6cc16ac73c671c/
Edited pages:

v20.2/multi-region-setup.md

@rmloveland, can you please take this one over? You may need to open a fresh PR at this point.

can you please take this one over? You may need to open a fresh PR at this point.

Sure!

In the meantime, this appears to be fixed everywhere now as of this writing

https://www.cockroachlabs.com/docs/v20.1/multi-region-setup.html
https://www.cockroachlabs.com/docs/v20.2/multi-region-setup.html
https://www.cockroachlabs.com/docs/v21.1/movr-flask-setup.html
https://www.cockroachlabs.com/docs/v21.2/movr-flask-setup.html

Thanks for the PR @fabiog1901 - sorry for my delay.  This is now fixed at least :-)


Mark CAPV as producing S3 artifacts

CAPV has manifests which need to be uploaded to S3.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Create backing ipynbs in a separate directory

For #12510 (see issue description for additional context)
The root cause of this bug is that although we have code to clean up these backing notebooks on a connection dispose, that code doesn't execute in time if VSCode is killed too quickly, or if the server is killed remote-side. This means that disposing the notebook on editor close, as was originally suggested in the bug issue, will suffer from the same problem.
The "solution" is to just move notebooks to a directory so that they aren't cluttering the workspace root. Unfortunately Jupyter's API doesn't expose a way to access the remote machine's temporary directory, so creating one with a standard name is the best we can do. Jupyter's API also doesn't expose a way to create directories with a specific filename, and missing parent directories are not automatically created (unlike VSC's filesystem API). Hence I had to create a temp directory, rename it to the desired directory, and clean up afterwards if the rename failed due to the directory already existing.

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #13197 into master will decrease coverage by 0.29%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #13197      +/-   ##
==========================================
- Coverage   59.56%   59.27%   -0.30%
==========================================
  Files         669      670       +1
  Lines       36787    36839      +52
  Branches     5181     5189       +8
==========================================
- Hits        21914    21837      -77
- Misses      13778    13932     +154
+ Partials     1095     1070      -25

Impacted Files
Coverage Δ

src/client/datascience/jupyter/jupyterUtils.ts
50.00% <0.00%> (ø)

src/client/datascience/jupyter/jupyterSession.ts
41.75% <70.00%> (-35.36%)
:arrow_down:

src/client/datascience/constants.ts
99.77% <100.00%> (+<0.01%)
:arrow_up:

...ent/datascience/jupyter/jupyterWaitForIdleError.ts
33.33% <0.00%> (-66.67%)
:arrow_down:

src/client/datascience/baseJupyterSession.ts
12.44% <0.00%> (-43.07%)
:arrow_down:

src/client/common/utils/async.ts
72.34% <0.00%> (-12.77%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/activation/common/activatorBase.ts
13.22% <0.00%> (-9.00%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e75a3...42af45a. Read the comment docs.

Closing in favor of #13209


(potential) typo in TI numbers for May 3

Cantonal website states 3235 cases (ncumul) while the provided excel states 3325. I would hope the increase from yesterday to today has only been 10 not 100 cases.

Fixed by f016703486


Login to soundcloud?

Is there a way for the bot to login to soundcloud and use sc go+?

No there is not. Youtube-dl does not support this particular feature.


Create missing admin auth functions.

Is your feature request related to a problem? Please describe.
supabase-js has several admin auth methods that can be called on the server side using service role key.
https://supabase.com/docs/reference/javascript/auth-admin-createuser
It would be great to have them on the Dart library as well.
Describe the solution you'd like
Add server side methods to the library

Delete user already exists as pr on the go-true repo.

@avalanche-tm I don't think the storage api supports that. I suggest you to use different SupabaseClient instances with different users logged in.
Closing this as already implemented https://github.com/supabase/gotrue-dart/pull/106

@Vinzent03 I'm still unable to create users using auth.admin.createUser function https://github.com/supabase/supabase-flutter/issues/356


Support for JSON snippets

I'd like to add support for a slight modification of the JSON lexer - that of JSON snippets, where surrounding braces or brackets are allowed to be missing.
This is a pattern I use in @sunlightlabs' API documentation, to document sections of response objects:
http://sunlightlabs.github.io/congress/legislators.html#fields/names
Right now, this is accomplished through a hack - in the original markdown documents, there are surrounding braces, but the content they surround is not indented. After documents are run through the syntax highlighter, any unindented JSON blocks inside braces get their braces removed. Without this hack, simply excluding the braces in the original code means the syntax highlighting for JSON doesn't trigger.
I've been poking through this repository, and @tmm1's pygments.rb, and the underlying pygments library, and I can't figure out how to begin doing the work myself. In what repo would I put this code, and what's the easiest way to go about it? Is there a way to "subclass" the existing JSON lexer and tweak the rules?

The highlighting is apparently the same between JavaScript and JSON now. Way to go! So just use js instead of json if you don't want JSON validation.


fix: 🐛 change the update method in the StateHistoryPlugin

instead of updating state we should be replacing it
✅ Closes: #619
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/datorama/akita/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
On undo/redo a store is being updated (merged), not replaced.
Issue Number: #619
What is the new behavior?
On undo/redo a store is being replaced.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
I had to update the EntityStore's replace method because of getting an error, something like:

Cannot assign to 'id' because it is a read-only property

Since the correction in EntityStore's replace method , the object given to the replace method doesn't keep its prototype (due to replaced[id] = { ...newState, [this.idKey]: id };)
When we get back this object from the store, we can't test the prototype anymore.

@lilas78 are you working with classes?

I have a unit tests that test object equality after updating the store. This test fails with the new version of Akita.  That's why I pointed out this change.
I have to change my test to make it work.

But the update method is also immutable.

Yes that's right.
It would have been nice to be able to rely on object's prototype after querying the store.
I will just change my test for the moment.
Thank you


Loader Plugin documentation

To make a doc more readable for any level, the code written should be more explicit: http://fuse-box.org/#loader-plugins
The exemple code here is like "obfuscated" for people that not familiar with this syntax.

Agreed, we need to have a seed as well!

Let's kindly ask @basarat to put some examples here https://github.com/fuse-box/fuse-box-hmr-examples ;-)
@basarat you have a write access. Thanks a lot!

Excellent! Thank you

@leon-andria code is what is used in here : https://github.com/fuse-box/fuse-box-ts-react-reflux-seed so you can take it for a spin and play with it :heart:
Will add a blog post once a few more things are done :rose:

The exemple code here is like "obfuscated" for people that not familiar with this syntax.

TypeScript syntax: Can't help much there, but I did write a free book on it Any attempt to explain the types without TypeScript generally results in creating a new syntax that you have to infer yourself while reading docs :rose:
Over all code complexity:

FuseBox.flush: Function is not documented right now, but used in HMR. @nchanged can I have a short description of what the function does. I will add to docs :rose:
FuseBox.dynamic already covered : http://fuse-box.org/#dynamic-modules :rose:
FuseBox.import already covered : http://fuse-box.org/#import
FuseBox.mainFile not documented. Its the main entry point for the default bundle. Will add to docs :rose:

The default HMR behavior used these function already. You now get to customize how you call them. Does that clear stuff up? :rose:

Simplified the docs to remove the concept overload. The objective should have been just to show how to add a plugin and I think https://github.com/fuse-box/fuse-box/pull/221 achieves it well :rose: :heart:


Add test coverage for build tag prioritization

Summary
See: https://github.com/astral-sh/uv/pull/3781 and https://github.com/astral-sh/uv/pull/9677.

The package from which those wheels were built is included in the first commit, but removed in the second to avoid clutter in the repo itself.


MRG fix for CNTEventType1 that don't have Latency

closes #7248
@quocdat32461997 can you have a look and test? I tried comparing the data with EEGLAB but I get here 101 events while EEGLAB gives me 100 (it skips the last one).

Hi MNE team,
The codes work for now. Hopefully, you guys update MNE on pip3 soon.
@agramfort I'll check the events.

in the mean time you can use:
pip install -U https://api.github.com/repos/mne-tools/mne-python/zipball/master


Adding new grid breakpoint size doesn't clear properly with grid-uniform

I added a new breakpoint size in timber.scss.liquid and although the CSS seems to be created properly it does not seem to work properly with grid-uniform as the clearfix-helper scss doesn't add in the new xlarge breakpoint.
Here is the code I added to timber.scss.liquid:
/*============================================================================
  #Breakpoint and Grid Variables
==============================================================================*/
$viewportIncrement: 1px;

$small: 480px;
$medium: 768px;
$large: 769px;
$xlarge: 1400px;

$postSmall: $small + $viewportIncrement;
$preMedium: $medium - $viewportIncrement;
$preLarge: $large - $viewportIncrement;
$preXlarge: $xlarge - $viewportIncrement;

/*================ The following are dependencies of csswizardry grid ================*/
$breakpoints: (
  'small' '(max-width: #{$small})',
  'medium' '(min-width: #{$postSmall}) and (max-width: #{$medium})',
  'medium-down' '(max-width: #{$medium})',
  'large' '(min-width: #{$large})',
  'xlarge' '(min-width: #{$xlarge})'
);
$breakpoint-has-widths: ('small', 'medium', 'medium-down', 'large', 'xlarge');
$breakpoint-has-push:  ('medium', 'medium-down', 'large', 'xlarge');
$breakpoint-has-pull:  ('medium', 'medium-down', 'large', 'xlarge');

Modification to product-grid-item.liquid:
{% unless grid_item_width %}
  {% assign grid_item_width = 'xlarge--one-quarter large--one-third medium--one-half' %}
{% endunless %}

Steps to reproduce:

Clone the repo
Add the breakpoint using the code above
Modify 'snippets/product-grid-item.liquid' using the code above.
Stretch browser window wider than 1400px on a collection page where more than 4 products are listed.

If you open the browser window above 1400px you will see that only 3 products are shown on one line due to the clearfix applied to the rule ".grid-uniform .large--one-third:nth-child(3n+1)"
It does not seem like any of the xlarge breakpoints are added to the clearfix-helper rule.  Am I missing something?

If you change the large breakpoint to:
'large' '(min-width: #{$large}) and (max-width: #{$preXlarge})', it looks to fix the grid-uniform issue. There may be other unintended consequences for that though. I'll see if I can make a more streamlined approach though. Closing for now.

The above-mentioned fix unfortunately brakes the grid on all pages expect for collection pages. I love Timber but the inability to add a breakpoints is a real problem I think. Adding breakpoints is especially important for collection pages which heavily rely on the grid. Is there another solution for adding breakpoints?

I just came out with a workaround that may be useful for your use case. With the idea from @cshold the clearfix problem is gone but the whole helper classes (hide, show, display-table...) will be "broken". Everywhere where large--* appears, should be added a xlarge--* and that would be too much work.
What I have done is following:
/*============================================================================
  #Breakpoint and Grid Variables
==============================================================================*/
$viewportIncrement: 1px;

$small: 480px;
$medium: 768px;
$large: 769px;
$xlarge: 1110px;

$postSmall: $small + $viewportIncrement;
$preMedium: $medium - $viewportIncrement;
$preLarge: $large - $viewportIncrement;
$preXLarge: $xlarge - $viewportIncrement;

/*================ The following are dependencies of csswizardry grid ================*/
$breakpoints: (
  'small' '(max-width: #{$small})',
  'medium' '(min-width: #{$postSmall}) and (max-width: #{$medium})',
  'medium-down' '(max-width: #{$medium})',
  'large' '(min-width: #{$large})',
  'large-to-xlarge' '(min-width: #{$large}) and (max-width: #{$preXLarge})',
  'xlarge' '(min-width: #{$xlarge})'
);
$breakpoint-has-widths: ('small', 'medium', 'medium-down', 'large', 'large-to-xlarge', 'xlarge');
$breakpoint-has-push:  ('medium', 'medium-down', 'large');
$breakpoint-has-pull:  ('medium', 'medium-down', 'large');

With this code, large classes will still be working as expected and you would just need following classes in the collection pages
xlarge--one-quarter large-to-xlarge--one-third medium--one-half


Invalid polygons

With turf.area, negative values means that the polygon has invalid geometry like crossing ways.  Let's use this to detect invalid polygons.

@geohacker @Rub21

@maning  .- what are the  invalid polygons?

@Rub2, for example, in this building shape analysis repo we calculate polygon area in one of the metrics.  Any polygon we detect that has negative numbers is an invalid polygon.  For example, this building.
As a start, we can run this linter for all buildings and mark as invalid poly if it has negative area value.

@maning  this is nice figured out, let's add on osmlit.

I saw here the Tilereduce procesor(https://github.com/mapbox/osm-building-shapes) made by @geohacker , Maybe he is the right person to add this on osmlint.

@Rub21 was thinking about this the other day! I can add this, will get you to look over once I push the code.

@geohacker @Rub21 @arunasank Can we do this? Context here: https://github.com/osmlab/labuildings/issues/92#issuecomment-222731623


fix: reason and log typos

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add escaping to prevent injection attacks

renderRead in postgres & sql server modules are the main areas this affects at the moment, only because many of the other renderings are missing; something that generalises to all modules that can be adapted for specific differences would be ideal.

I would like to do this one.

More specification needed.

https://github.com/zio/zio-sql/pull/624


Feature request: TrackHandle method to stop all sounds currently playing on that track

The closest I can get to this functionality on my own is to either:

manually track all sounds playing on a specific track and iterate through them to call their handle's stop() method
drop the track and make a new one (requiring me to also remake all the attached effects/routes)

I feel like this is a common feature that kira would benefit from having built in. Would it be feasible to implement this?

@TheBerkin by any chance would you also be interested in per-track polyphony controls? I'm considering making sounds live on a track, each of which has its own limit on the number of sounds that can be played simultaneously. In that case, it would be easier to implement this feature, although it's also possible currently. My concern is that I'd be restricting people's workflows too much by linking polyphony and mixing together into one feature.

Absolutely. As long as there's no limit (beyond technical) to the number of tracks you can make, I think your idea is fine.


Nested custom items

Godot version:
3.1
OS/device including version:
Windows 10
Issue description:
When I create custom nodes or resources, they are immediately parented to the root (Node or Resource respectively) in all interfaces (node selection dialog, resource creation panel and so on), even if it is not the case.
class Character : Node {} and class ThirdPersonChar : Character {}
are both just Nodes, because second parameter in
add_custom_type("ThirdPersonChar", "Node", script, icon)
defines only the main type of item, and what logically seems correct like
add_custom_type("ThirdPersonChar", "Character", script, icon)
will not work.
It is even more evident with resources. Consider the following:
//CustomMap.cs
public CustomMap : Resource { ... }

//CustomMapIndoors.cs
public CustomMapIndoors  : CustomMap { ... }

//MapLoaderIndoors.cs
[Export]
public CustomMapIndoors housePlan;

In this case in the inspector we will see a dropdown of all possible resource types, instead of just maps - which is not the case with any other resources.
Is there a way to define a correct inheritance or a "group"? Also, in the mentioned interfaces there are tooltips at the bottom with description of the item, which also seems not included in "add_custom_type".

An addition: found out that gd script nodes (but not cs!) that have class_name
appear automatically in the list of nodes and stack as they must,
though only with a strange syntax like this: extends 'res://NodeParent.gd'
Now we have a mess: cs nodes do not appear automatically even after build,
but gd can appear doubled: automatically and imported as plugin add_custom_type,
but only automatic ones stack in tree structure, and cs do not stack at all.
As so, I get that cs support is far from complete,  but gdscript - which seems
to be rather solid - also has a strange behaviour in this situation.

@ismslv Please test if this issue still exists with Godot 3.2.3 and/or the master branch.
If this issue does still exist for you, then you will need to include a minimal reproduction project.

Closing due to lack of response (see the above comment).


Add support for minecraft 1.18

Custom Items 9.14 will have experimental support for minecraft 1.18.


UNKNOWN_CODE_PLEASE_REPORT - regex

Node version: v12.18.0
mysqljs version: ^2.18.1
Got this error from mysqljs today:
  ERROR Error: UNKNOWN_CODE_PLEASE_REPORT: Syntax error in regular expression on line 1, character 11.
      at Query.Sequence._packetToError (/c/Users/.../node_modules/mysql/lib/protocol/sequences/Sequence.js:47:14)
      at Query.ErrorPacket (/c/Users/.../node_modules/mysql/lib/protocol/sequences/Query.js:79:18)
      at Protocol._parsePacket (/c/Users/.../node_modules/mysql/lib/protocol/Protocol.js:291:23)
      at Parser._parsePacket (/c/Users/.../node_modules/mysql/lib/protocol/Parser.js:433:10)
      at Parser.write (/c/Users/.../node_modules/mysql/lib/protocol/Parser.js:43:10)
      at Protocol.write (/c/Users/.../node_modules/mysql/lib/protocol/Protocol.js:38:16)
      at Socket.<anonymous> (/c/Users/.../node_modules/mysql/lib/Connection.js:88:28)
      at Socket.<anonymous> (/c/Users/.../node_modules/mysql/lib/Connection.js:526:10)
      at Socket.emit (events.js:315:20)
      at addChunk (_stream_readable.js:295:12)
      --------------------
      at Protocol._enqueue (/c/Users/.../node_modules/mysql/lib/protocol/Protocol.js:144:48)
      at PoolConnection.query (/c/Users/.../node_modules/mysql/lib/Connection.js:198:25)
      at internal/util.js:297:30
      at new Promise (<anonymous>)
      at PoolConnection.query (internal/util.js:296:12)
      at Connection.promiseQuery (/c/Users/.../server/connection.js:70:14)
      at /c/Users/.../server/sqlAdapter.js:86:35
      at processTicksAndRejections (internal/process/task_queues.js:97:5) {
    code: 'UNKNOWN_CODE_PLEASE_REPORT',
    errno: 3688,
    sqlMessage: 'Syntax error in regular expression on line 1, character 11.',
    sqlState: 'HY000',
    index: 0,
    sql: '\n' +
      '                SELECT\n' +
      '                    serial_number as serialNumber\n' +
      '                FROM\n' +
      '                    serial_numbers\n' +
      '                WHERE\n' +
      '                    configuration_id = 6 AND\n' +
      '                    serial_number REGEXP "18.?KM0D????"\n' +
      '                ORDER BY\n' +
      '                    serial_number DESC\n' +
      '            ;'
  }

Couldn't find anything about UNKNOWN_ERROR_PLEASE_REPORT having to do with regular expressions among the open issues. Perhaps mysqljs does not know how to interpret the error code for this error.
If it's not clear, "????" is not allowed in a regular expression, so I assume that's the source of the error.

3819 is also missing if I can lump it together with this reported issue

code 3688 = ER_REGEXP_RULE_SYNTAX as per this reference but it looks like the file lib/protocol/constants/errors.js is generated by tool/generate-error-constants.js. This error code was added in MySQL version 8.0.4, and lib/protocol/constants/errors.js says that it was generated with MySQL version 5.7.29. So I think the error codes file should be re-generated with the latest MySQL version, but I'm guessing there are compatibility issues with either the generated file or with the generator itself.

I've already created a pr that deals with this, #2386. It works well, though we'll have to see if it'll ever be merged

Thanks everyone! Yea, it looks like this is an error code added in MySQL 8.0.4 and is in the referenced PR to get merged in.


Drop support for Node 6

…as it is EOL

Yes, this will be part of a 2.0 release. @sdebarros had included it in #1938 but merging this separately now allows us to get all the currently broken @dependabot-bot PRs in.


Subquerys dont work as expected

I see statements like this dont work
SELECT (SELECT Name from SomeKindOfTable as sm WHERE sm.Id=m.Id)
FROM Main as m
Is it bug or not supported ?

ps I use indexeddb table.

Hmm. Does this work in other databases? Looks like you are doing a join without doing a join.
I would be really awesome if you could provide an example with the data in sm and m together with the expected output...
Have you tested with its not indexeddb?

SELECT HardServiceId,
h.ClientId,
h.Name,
h.Date AS RegDate,
h.Duration AS EndTime,
h.VisitDate AS PlanDate,
h.Address,
h.City,
(SELECT op.Name
FROM Options_Details as op
WHERE op.OptionDetailId = h.ServiceId) AS Type,
(SELECT op.Name
FROM Options_Details as op
WHERE op.OptionDetailId = h.StatusId) AS Status
FROM HardService as h
before I used sql.js https://github.com/kripken/sql.js/
now Iam doing
JOIN Options_Details as opse ON opse.OptionDetailId=h.ServiceId
JOIN Options_Details as opst ON opst.OptionDetailId=h.StatusId
because subselects dont work
javascript code:
alasql('ATTACH INDEXEDDB DATABASE database;USE database;', [],function(){
// Select data from IndexedDB
alasql.promise(sql_statement))
.then(callback);
});
sql_statement is SQL select above

Joins are slow if you only need 1 column. I dont want to join whole table to other table. Normly all sql engines allows you to do that like i showed.

I could be wrong about speeds :) in internal. but anyway subselect should work 😄 .


Add a small system test for sage2lib

This PR adds a very small test for sage2lib.

Hmm... the Windows error here seems to originate from Pyteomics within ms2ml 🤔
Do we actually care about supporting Windows here? Probably not.


Application not working on Android KitKat 4.4.2

Ionic 2
Blank page was displayed for kitkat.
Can you please update the minimum version required for ios, android in the documentation.

KitKat is definitely supported.

@dheran would you be able to tell me what version of ionic you were working with when you got this issue? There was a known issue with beta.4 that would cause white screens on some android devices. Also as far as android support goes we officially support android 4.1 and above, but we recommend you use crosswalk for anything below 4.4.4.

i tried beta 5

My managers will fire me for apk size if i use crosswalk

I tried beta 6 too. I'm getting blank page only.
I can't use crosswalk because of size constraints.

@dheran Sorry about this!  Are you getting any errors in the console?

@dheran How about Crosswalk Lite which is approximately half the size of the regular Crosswalk?
I also tested an Ionic 2 app on Android 4.4 and it's working, i.e. the problem might be somewhere else.
Could you provide more details about the problem that you're facing, e.g. error info, stacktrace, etc?

@jgw96 @iignatov
Yes there were errors.

04-27 17:38:28.562: I/chromium(5160): [INFO:CONSOLE(30929)] "EXCEPTION: TypeError: Cannot redefine property: length in [{{appt.formattedDate | date : 'yMMMdjm'}} in PlayersListPage@19:29]", source: file:///android_asset/www/build/js/app.bundle.js (30929)
04-27 17:38:28.562: I/chromium(5160): [INFO:CONSOLE(30929)] "ORIGINAL EXCEPTION: TypeError: Cannot redefine property: length", source: file:///android_asset/www/build/js/app.bundle.js (30929)
04-27 17:38:28.562: I/chromium(5160): [INFO:CONSOLE(30929)] "ORIGINAL STACKTRACE:", source: file:///android_asset/www/build/js/app.bundle.js (30929)
04-27 17:38:28.562: I/chromium(5160): [INFO:CONSOLE(30929)] "TypeError: Cannot redefine property: length
04-27 17:38:28.562: I/chromium(5160):     at defineProperty (native)
04-27 17:38:28.562: I/chromium(5160):     at Function.Object.defineProperty (file:///android_asset/www/build/js/angular2-polyfills.js:1083:17)
04-27 17:38:28.562: I/chromium(5160):     at freezeArray (v8/i18n:2004:8)
04-27 17:38:28.562: I/chromium(5160):     at initializeLocaleList (v8/i18n:286:8)
04-27 17:38:28.562: I/chromium(5160):     at resolveLocale (v8/i18n:1812:4)
04-27 17:38:28.562: I/chromium(5160):     at initializeDateTimeFormat (v8/i18n:1149:7)
04-27 17:38:28.562: I/chromium(5160):     at new Object.defineProperty.value.ax (v8/i18n:1227:8)
04-27 17:38:28.562: I/chromium(5160):     at Function.DateFormatter.format (file:///android_asset/www/build/js/app.bundle.js:28941:25)
04-27 17:38:28.562: I/chromium(5160):     at DatePipe.transform (file:///android_asset/www/build/js/app.bundle.js:6118:37)
04-27 17:38:28.562: I/chromium(5160):     at AbstractChangeDetector.ChangeDetector_PlayersListPage_2.detectChangesInRecordsInternal (viewFactory_PlayersListPage:943:105)", source: file:///android_asset/www/build/js/app.bundle.js (30929)
04-27 17:38:28.562: I/chromium(5160): [INFO:CONSOLE(30929)] "ERROR CONTEXT:", source: file:///android_asset/www/build/js/app.bundle.js (30929)
04-27 17:38:28.582: I/chromium(5160): [INFO:CONSOLE(30929)] "[object Object]", source: file:///android_asset/www/build/js/app.bundle.js (30929)

@iignatov already my apk size was 12 MB. Crosswalk Lite would consume additional ~15 MB which will double the size of the apk and also I'm instructed to keep the apk size less.

@dheran It seems that there's a problem with the Angular polyfills on Chrome 35 or older:

bug: number pipe not working on Chrome 34 or older (Cannot redefine property: length)
Angular 2 currency pipe doesn't work in chrome Version 34.0.1847.131 m
Angular 2 chatroom: I'm using old version of Chrome (35.0.1916.114)

@dheran are you using the date pipe available in angular 2?

@jgw96 yeah

Ahh, OK, so that's probably where the issue is coming from. Would you mind doing a test without the date pipe usage and see if you still get a white screen? Thanks!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

same issue on android browser :+1:

Hello @windwp! Ionic 2 does not currently support the Android browser, although we do support chrome for Android. The date pipe uses the internationalization API which is not supported in older browsers such as the Android browser. Sorry for any hassle that causes you, and thanks for using Ionic!

Will it be fixed or it should be handled by developer?

Hey @dheran! The date pipe is actually built into Angular 2, so there's not much we can do on the Ionic end of things for it. As I stated before, we do require crosswalk for support of Android devices older than 4.4, and that does fix the date pipe issue for those versions of Android, but I'm not sure we will ever be able to support the Android browser, as it just does not have the html5 and JavaScript support Ionic 2 needs. Have you been able to give crosswalk lite a try? This should give you the Android support you need, but with a smaller apk size.

Don't worry about it
Now i create a custom pipe use momentjs for display date.
@dheran

Hello I'm facing the same issue as well, The Toolbar alignment breaks up in android 4.4 and below. When I first installed the app on Android 4.4.2 I got a blank screen. It works perfectly on Android 5.0 and above. What could be the issue for this? Is this issue resolved in beta 25?

@jgw96 I think this issue needs to be made clear in the docs somewhere to use Crosswalk for apps on Android < version 5.

+1 for @dylanvdmerwe.
@jgw96 I think that the ionic team should be really clear about what features don't work on low-end or old android versions. As we speak, around 55% of android users have android <=4.4
For some who want an easy solution for the date pipe, you can use angular2-moment  and then use their pipe :
 {{myDate | amDateFormat:'LL'}}
This works on KitKat 4.4 (tested on 4.4.2)

Same issue for me except that no click or tap event is firing on the app running in Kitkat (API Level 19) on emulator or physical device. Thing's working fine above Kitkat.
the build process is successful without a single error. And no error is being thrown in the debug or stacktrace log or at least I couldn't see it.
I'm using Ionic 2 beta 27 with Typescript. And I've only tested on Android because I don't have other platforms setup yet. And apart from the providing cordova plugin during android build process I am not using any other cordova plugin.

Same issue for me using Android 4.4 with Ionic 1.3

@jgw96  is there any other way to use ionic 2 app in below 4.2 version mobiles "other then Crosswalk".
Pls.. Give some clarity.. Thanks..

Not as far as I know. It's a limitation of the older Android web engine that does not support things that Ionic needs. This is why you use Crosswalk so that the web engine is much more up to date on these older Android operating systems.

Having same issue on ionic 3.0.1 and android 4.4.2
any help or suggestions please ? ..

@xdabier did you try with crosswalk. For 4.4 it's recommended to use crosswalk

@chandanch I did try crosswalk but the problem is it makes the file too huge, which is not handful..

@Xdabier  one alternative would be to maintain two binaries one with crosswalk which supports android 4.4 and the other without crosswalk which will support 5 and above

@chandanch I got you.. should I remove the crosswalk plugin everytime I want to build for 5 and .. and install it back when building for 4.4 ? or there's a way over that ?

@Xdabier Thats the only way as of now I guess.

To my opinion you should always use crosswalk for any Android version you target. A few more mb will probably not bother anyone and it will make your build process easier and your app more consistent. Keep It Simple!

You can use cordova build --release -- --minSdkVersion=21 this will use the systemwebview instead of crosswalk

that's what I needed thanks a lot! ^^

Is there any solid solution to this problem yet? I attempted to install crosswalk. When I build and run on my 4.4.2 device, it get this message:
Crosswalk info:         After much discussion and analysis of the market,         we have decided to discontinue support for Android 4.0 (ICS) in Crosswalk starting with version 20,         so the minSdkVersion of Cordova project is configured to 16 by default.
Does that mean Im out of luck for api levels bellow 20?
Also, my app will actually run (very slowly) when simply using:
ionic cordova run android
but not when a release build is used or if I manually add optimize flags:
ionic cordova run android --optimizejs --minifycss --minifyjs

I am working on ionic1 app and app is not working on android tablet v5.1,  app is just showing white screen. Please help.

@rohitwebethics can you try remote debugging the application. You will find the root cause of it,
https://developers.google.com/web/tools/chrome-devtools/remote-debugging/


added bsacet domain

Added my college name to the repository it provides regular full time program for engineering degree in computer science and other branches
college website- https://bsacet.org

Added my college name to the repository it provides regular full time program for engineering degree in computer science and other branches
college website- https://bsacet.org/

@Anujkrsh I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host bsacet.Bsacet.org not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Halt in visit this context node

I don't know how I reached that place, but when I try to bootstrap my Pharo code, I hit an halt in:
https://github.com/guillep/espell/blob/master/src/Espell.package/EPASTInterpreter.class/instance/visitThisContextNode..st
Because of that I cannot bootstrap with my changes :(

@jecisc I think the problem is that you are using thisContext in a method that before it was not using. What are your changes? The interpreter to evaluate the code does not implement the thisContext.

I'll try to reproduce with a minimal change this problem because I have the impression that my code was working (the image I was using was working fine at least). I'll update this issue if I succeed (and I'll close it if I find an error in my code)

I get this error with this commit: https://github.com/jecisc/pharo/commit/6c211e88564e232f04a840a683fc4d78d09b06fc


[hotfix][docs] Update the missing parts of this fault_tolerance Chinese documentation.

What is the purpose of the change

Update the missing parts of this fault_tolerance Chinese documentation.

Brief change log

Update the missing parts of this fault_tolerance Chinese documentation.

Verifying this change

No need to test.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

@flinkbot run azure

@MartijnVisser ,Sorry to bother you again, can you help me review this pr? Thank you.

@wuchong , Sorry to bother you again, can you help me review this pr? Thank you.

@MartijnVisser ，Thank you very much for your review, I have revised her as you suggested.


 Maybe next to the bowler's name?

no, this code is based on the API response, which doesn't have?

Is the API documented anywhere?

It looks like in the API response feed there is the number of balls in the over
"ov":"16.2"
The first number is the over and the second number is the ball of the over.
Looks like you output that under the batting player name.
The non batting player is always showing 0 i think?
It would be better perhaps to remove that line and put the number of overs and the ball of the over somewhere else.
Maybe like this?
Over 16. Ball 2. Bowler  : Mohammad Imran

i don't know, maybe it works as it is.

okay i got it,I will make it on future update


write next state to vcd instead of curr state, since state is written just prior to commit

Fixes #429
I tested it and it seems to work!
@whitequark You can add a regression test later if you want.

So actually a better fix would be to accumulate pending throughout every delta cycle and then write things only once per step. Unless you need this fixed urgently I'd rather do that.

Would you be willing to merge this fix while you finish off the better fix, since this one is pretty simple? I'm not 100% sure, but I think #429 is blocking several people in Libre-SOC to some extent.

Thanks!


Block Body Must Support Secure Download Of Deploys Only

In order for fast sync to support replay attack mitigation, it must be able to securely download deploys.
However, the fast sync must also be extensible and not download the whole block (so that we can add additional functionality later).
The proposed solution is to change how block body hashes are computed.  The new way of hashing them would allow us to provide Merkle proofs when downloading fragments of a block body.

Should we consider this done, as it is on the feat-fast-sync branch and will get merged to dev together with the whole fast sync code? @cspramit @xcthulhu


Add typed converters to avoid casting of slot models

Currently there is a property
[JsonPropertyName("what")]
[JsonConverter(typeof(AliceEntityModelConverter))]
public AliceEntityModel What { get; set; }

and the developer should cast it each time in order to use its value:
var what = aliceRequest.Request.Nlu.Intents.TurnOn.Slots.What as AliceEntityStringModel;

It would be way better if it was possible to use it as follows:
[JsonPropertyName("what")]
[JsonConverter(typeof(AliceEntityStringModelConverter))]
public AliceEntityStringModel What { get; set; }

Slots classes are fully controlled by developers. You can use AliceEntityStringModel directly in your models:
[JsonPropertyName("what")]
public AliceEntityStringModel What { get; set; }

Created PR #6 with example. As currently it can be confusing how slot models are using.
@MrDaedra  Can you please check this PR and let me know if this is what you expect?

Yes, seems like this issue can be closed


can't access the store

Hi , i'm new to react and redux. below is my config for redux and routes but i can't access store and i cant see params and props in chrome inspector.
Route.js file
  import React from 'react'

import { createStore, combineReducers, applyMiddleware } from 'redux'
import { Provider } from 'react-redux'

import createHistory from 'history/createBrowserHistory'
import { Route } from 'react-router'

import { ConnectedRouter, routerReducer, routerMiddleware, push } from 'react-router-redux'

import reducers from './Store/Reducers' // Or wherever you keep your reducers

// Create a history of your choosing (we're using a browser history in this case)
const history = createHistory()

// Build the middleware for intercepting and dispatching navigation actions
const middleware = routerMiddleware(history)

// Add the reducer to your store on the `router` key
// Also apply our middleware for navigating
const store = createStore(
  reducers,
  applyMiddleware(middleware)
)

//Import Components
import App from './App';

const route = (
    <Provider store={store}>
    { /* ConnectedRouter will use the store from Provider automatically */ }
    <ConnectedRouter history={history}>
      <div>
        <Route exact path="/" component={App}/>
      </div>
    </ConnectedRouter>
  </Provider>
)

export default route;

index.js file
`
import ReactDOM from 'react-dom'
import Route from './Routes' //Defining all routes in this file , also redux configurations for route

import './assets/stylesheets/StageWindow.css'
ReactDOM.render(Route,document.getElementById('root'))

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


⚠ Bofrost.lu has degraded performance

In 1240682, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1928 ms

Resolved: Bofrost.lu performance has improved in d6f4b43 after 23 minutes.


Poor sample quality when using V-prediction model for unet in VSD

Hi! I tried using a v-prediction model (SD 2-1) for VSD guidance as suggested in #179 , and I applied v to epsilon conversion for the unet predictions as well. I ran this configuration over a 2D playground pipeline but the results are extremely poor. Has anyone else observed this too? Below are some 2D generated samples from VSD:

Yes, I also tried this and found a similar phenomenon to the third image. I am not sure whether it is because sd-2-1 is trained on 768x768 images and the 2D case is on a 512x512 canvas. I tried to optimize an image of 768x768 resolution but it caused OOM.

I agree this is caused by the higher resolution of sd-2-1 as mentioned by @thuliu-yt16 .
Tried SDS with sd-2-1 and could not get any good result like sd-2-1-base.


fix: fix ssr of sbb-select

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@138744f). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2341   +/-   ##
=======================================
  Coverage        ?   93.67%
=======================================
  Files           ?      239
  Lines           ?    23958
  Branches        ?     2090
=======================================
  Hits            ?    22443
  Misses          ?     1478
  Partials        ?       37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update the list of known Discord emoji

The repo we pulled our emojis from updated their list pretty significantly in July 2022: https://github.com/sevenc-nanashi/discord-emoji
Instead of copying the source of it to our repo, we should just pull in the discord-emoji library from PyPi (probably pin the version just in case) and fish out the table.DISCORD_TO_UNICODE dictionary.
Edit: Although we would need to implement an emoji blacklist or something in that case, as we've removed some emoji from the default list.

Done in https://github.com/anoadragon453/busty/pull/160.


Update credentials and multi-device validation logic to match identity doc

I'm going to defer on fine-grained validation for two reasons (heads up @neekolas):

There may be additional validation changes happening in OpenMLS
This isn't critical for EthDenver (although it is for actual release)


Url issue

Hi,
I work with Django 1.9 and I got an issue when I try to migrate.

SystemCheckError: System check identified some issues:
ERRORS:
?: (urls.E004) Your URL pattern ('^ckeditor/', (<module 'ckeditor_uploader.urls' from '/usr/local/lib/python2.7/dist-packages/ckeditor_uploader/urls.pyc'>, None, None)) is invalid. Ensure that urlpatterns is a list of url() instances.
HINT: Try using url() instead of a tuple.

If someone can help me on that. (suspect that come from the use of 1.9)
Thanks,
(PS : sorry for my english, really bad)

issue fix by an unknown magical intervention !
Hate when I don't understand why ... but apparently it's seem to be an error when python read the file


Pls help me(

Describe your problem here.

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

qhat did you do exactly? explain

qhat did you do exactly? explain

I just enter into the song

You're missing some difficulties (specifically hard)
Enter in on normal or create a hard chart...
(Call the chart hedge-hard.json)


Improve the error messages

Is your feature request related to a problem? Please describe.
Most comments by the action for errors are unclear, unhelpful, and appear to come from nowhere.
Example no permission to push to repo:

Git push to origin failed for case5-backport-target with exitcode 1

Describe the solution you'd like
Error messages should be clear about what was attempted, what went wrong, and what can be done to recover. For example:

Backport-action failed to generate a pull request cherry-picking these changes (workflow run). Tried to push branch backport-x-to-y, but not permitted to push to this repo.
You can use a Personal Access Token (PAT) with repo scope as the token input of the actions/checkout-action step to permit pushing to the repo.

Describe alternatives you've considered
..
Additional context
Some other example errors:
Not permitted to create pull request:

Resource not accessible by integration

Unable to cherry-pick
This error is clear about what happened, what went wrong, and how to recover. However, it still appears to come out of nowhere. A link to the workflow run would help.

Backport failed for stable/8.2, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin stable/8.2
git worktree add -d .worktree/backport-16634-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-16634-to-stable/8.2
git switch --create backport-16634-to-stable/8.2
git cherry-pick -x a472372cdb055835682b13515442139655126034 02910366c2d4aff900c41a4dfd8de1f0e926dfae

I have this problem as well, where the bot just comments that something went wrong after i successfully merged the backport. To me it looks like everything went well:

PS: It is probably of how am using target_branches. In our repo we dont really want the developer to having to specify all the branches that they should backport in.
But specifying a label filter and target_branches at the same time seems to still try and backport even the backports again - which fails.
Could it be possible to have labels that dont require a regex matchgroup but rather only serve as a tag?

@ggwpez It looks like your workflow is trying to backport the changes a second time. The merged PR's base to backport is the same as the selected target branch.
I think that's a bug, as backport-action could probably always exclude this case. I'd be interested to see the workflow run logs, particularly the lines regarding:

Determining target branches..

While we should eventually resolve that as a separate bug, you could work around this by excluding PRs that directly target your target branch.
Something like:
    # Only backport to my_target_branch, if PR did not just merge something to it
    if: >
      github.event.pull_request.merged &&
      github.event.pull_request.base.ref != 'my_target_branch'
    steps:
      - uses: actions/checkout@v4
      - uses: korthout/backport-action@v3
        with:
          target_branches: my_target_branch

Could it be possible to have labels that dont require a regex matchgroup but rather only serve as a tag to trigger for all target_branches?

You could also try this. You can use a similar condition checking for specific labels. It may be useful to split up the different usages into separate workflows then:

one workflow to backport using a label with capture group when that's needed
one workflow to backport to a specific branch/branches when a specific label is used

Hope it helps, and let me know if you run into issues. Feel free to open a bug if you encounter new issues.

Thanks for taking a look, your workaround with excluding the base.ref works. It seems to indeed end up with an empty commit while trying to backport the backport. I did not realize that it is using the workflow file from the stable branch instead of master. Full error log:
Details

Run korthout/backport-action@v3
  with:
    target_branches: stable[2](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:2)407
    merge_commits: skip
    github_token: ***
    label_pattern: A4-needs-backport
    pull_description: Backport #${pull_number} into `${target_branch}` (cc @${pull_author}).

    pull_title: [${target_branch}] Backport #${pull_number}

    branch_name: backport-${pull_number}-to-${target_branch}
    cherry_picking: auto
    copy_assignees: false
    copy_milestone: false
    copy_requested_reviewers: false
    experimental: {
    "conflict_resolution": "fail"
  }

    github_workspace: /home/runner/work/debug/debug
Retrieve pull request data for #85
Check whether pull request 85 is merged
Determining target branches...
Detected labels on PR: A[3](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:3)-backport
label 'A3-backport' doesn't match `label_pattern` 'A[4](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:4)-needs-backport'
Found target branches in labels:
Found target branches in `target_branches` input: stable2407
Exclude pull request's headref from target branches: backport-84-to-stable2407
Determined target branches: stable2407
Fetching all the commits from the pull request: 2
git fetch --depth=2 origin refs/pull/8[5](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:5)/head
From https://github.com/ggwpez/debug
 * branch            refs/pull/85/head -> FETCH_HEAD
Retrieving the commits from pull request 85
PR was merged using a squash or a rebase. Choosing squash strategy.
git fetch --depth=2 origin +1[6](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:6)4f1c6a4799a307be59dfc2ae9c298995a1e133:refs/remotes/origin/164f1c6a4[7](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:7)99a307be59dfc2ae9c298995a1e133
From https://github.com/ggwpez/debug
 * [new ref]         164f1c6a4799a307be59dfc2ae9c29[8](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:8)[9](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:9)95a1e133 -> origin/164f1c6a4799a307be59dfc2ae9c298995a1e133
Found commits to backport: 164f1c6a4799a307be59dfc2ae9c298995a1e133
Checking the merged pull request for merge commits
git rev-list --merges 164f1c6a4799a307be59dfc2ae9c298995a1e[13](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:13)3^..164f1c6a4799a307be59dfc2ae9c298995a1e133
Encountered 0 merge commits
Will cherry-pick the following commits: [16](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:16)4f1c6a4799a307be59dfc2ae9c298995a1e133
Will copy labels matching undefined. Found matching labels:
Backporting to target branch 'stable2407...'
git fetch --depth=1 origin stable2407
From https://github.com/ggwpez/debug
 * branch            stable[24](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:25)07 -> FETCH_HEAD
Start backport to backport-85-to-stable2407
git switch -c backport-85-to-stable2407 origin/stable2407
Switched to a new branch 'backport-85-to-stable2407'
git cherry-pick -x 164f1c6a4799a307be59dfc2ae9c298995a1e133
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
git cherry-pick --abort
Backport failed for `stable2407`, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.
``bash
git fetch origin stable2407
git worktree add -d .worktree/backport-85-to-stable2407 origin/stable2407
cd .worktree/backport-85-to-stable2407
git switch --create backport-85-to-stable2407
git cherry-pick -x 164f1c6a4799a307be59dfc2ae9c[29](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:30)8995a1e133
``
Create comment: Backport failed for `stable2407`, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.
``bash
git fetch origin stable2407
git worktree add -d .worktree/backport-85-to-stable2407 origin/stable2407
cd .worktree/backport-85-to-stable2407
git switch --create backport-85-to-stable2407
git cherry-pick -x 164f1c6a4799a[30](https://github.com/ggwpez/debug/actions/runs/10595239845/job/29360562571#step:3:31)7be59dfc2ae9c298995a1e133
``

For future readers, this is the workflow that am currently using:
Details

name: Backport into stable

on:
  pull_request_target:
    types: [ closed, labeled ]
  issue_comment:
    types: [ created ]
permissions:
  contents: write # so it can comment
  pull-requests: write # so it can create pull requests
jobs:
  backport:
    name: Backport pull request
    runs-on: ubuntu-latest

    # Excluding CI action user id `97796249`:
    if: >
      ( !startsWith(github.event.pull_request.base.ref, 'stable') ) &&
      ((
        github.event_name == 'pull_request_target' &&
        github.event.pull_request.merged &&
        contains(github.event.pull_request.labels.*.name, 'A4-needs-backport')
      ) || (
        github.event_name == 'issue_comment' &&
        github.event.issue.pull_request &&
        github.event.comment.user.id != 97796249 &&
        (
          startsWith(github.event.comment.body, '/backport') ||
          contains(toJson(github.event.comment.body), '\n/backport')
        )
      ))
    steps:
      - uses: actions/checkout@v4
      - name: Create backport pull requests
        uses: korthout/backport-action@v3
        id: backport
        with:
          target_branches: stable2407 stable2410
          merge_commits: skip
          github_token: ${{ secrets.GITHUB_TOKEN }}
          pull_description: |
            Backport #${pull_number} into `${target_branch}` (cc @${pull_author}).

            <!--
              # To be used by other automation, do not modify:
              original-pr-number: #${pull_number}
            -->
          pull_title: |
            [${target_branch}] Backport #${pull_number}

      - if: ${{ steps.backport.outputs.created_pull_numbers != '' }}
        uses: actions/github-script@v7
        with:
          script: |
            const pullNumbers = '${{ steps.backport.outputs.created_pull_numbers }}'.split(' ');

            for (const pullNumber of pullNumbers) {
              await github.rest.issues.addLabels({
                issue_number: parseInt(pullNumber),
                owner: context.repo.owner,
                repo: context.repo.repo,
                labels: ['A3-backport']
              });
              console.log(`Added A3-backport label to PR #${pullNumber}`);
            }


[SPARK-13078][SQL] API and test cases for internal catalog

This pull request creates an internal catalog API. The creation of this API is the first step towards consolidating SQLContext and HiveContext. I envision we will have two different implementations in Spark 2.0: (1) a simple in-memory implementation, and (2) an implementation based on the current HiveClient (ClientWrapper).
I took a look at what Hive's internal metastore interface/implementation, and then created this API based on it. I believe this is the minimal set needed in order to achieve all the needed functionality.

cc @hvanhovell

Test build #50374 has started for PR 10982 at commit 9e96106.

Test build #50374 has finished for PR 10982 at commit 9e96106.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50374/
Test FAILed.

OK I pushed a new version -- this one should have the basic pieces ready and we can parallelize the work after this.

Test build #50442 has started for PR 10982 at commit d1bb199.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50440/
Test FAILed.

Merged build finished. Test FAILed.

Test build #50442 has finished for PR 10982 at commit d1bb199.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50442/
Test FAILed.

Test build #50443 has started for PR 10982 at commit 964193d.

Test build #50443 has finished for PR 10982 at commit 964193d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class CatalogTestCases extends SparkFunSuite

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50443/
Test PASSed.

Merged build finished. Test PASSed.

Talked to @hvanhovell offline. I'm going to merge this first and parallelize the work.

(actually i will only merge it when my latest commit passes test)

Test build #50482 has started for PR 10982 at commit 01c5922.

Test build #50482 has finished for PR 10982 at commit 01c5922.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50482/
Test FAILed.

Test build #2485 has started for PR 10982 at commit 01c5922.

Test build #2485 has finished for PR 10982 at commit 01c5922.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Thanks - merging this in master.


Add Openstack application credential support

What is your current rclone version (output from rclone version)?
1.45
What problem are you are trying to solve?
Openstack application credential is not supported: https://docs.openstack.org/keystone/queens/user/application_credentials.html
Here is the code example on how it is done in gophercloud
How do you think rclone should be changed to solve that?
Handle application credentials. API reference.

I think this would need to go into the underlying library https://github.com/ncw/swift first.
Then using the env_auth option in rclone would just work.
Would you like to work on this?


CCTP: Per-message burn limit warning

The CCTP protocol implementations should fetch the per-message burn limit in the quote method and add a warning to the return value if the transfer amount exceeds the limit.
See: https://developers.circle.com/stablecoins/limits
Contract method on Ethereum for example (USDC token input address: 0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48) https://etherscan.io/address/0xc4922d64a24675e16e1586e3e3aa56c06fabe907#readContract#F1

Thank you for contacting us. We have logged your complaint regarding your recent service experience with ticket ID #TD1456. For the fastest resolution, please use our 24/7 live chat support here:
SUPPORT


New association type request -- chemical treats disease

Please describe the association type you would like added to the knowledge graph (KG)
Using the Biolink:ChemicalToDiseaseOfPhenotypicFeatureAssociation, assertions for chemicals that treat a disease should be included in the text-mined KG.
Please provide the relevant BioLink association
Biolink:ChemicalToDiseaseOfPhenotypicFeatureAssociation
Initial set of relevant relation(s):

biolink:treats

When complete, the assertions targeted by this issue should answer the type of query discussed in https://github.com/NCATSTranslator/testing/issues/41


Text substitution

Description of the new feature / enhancement
Replace a define text by another one
Same as Mac OSX
Scenario when this would be used?
Write quickly an email address
For instance @x2 will be replaced by the entire email addresss
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/5074