refactor: Remove src-functions files and also Axios package

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Refactoring

Context

[x] Closes #6937
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Copilot Summary

🤖 Generated by Copilot at 57c9432
This pull request removes the unused axios dependency and the Netlify lambda functions from the project. This is part of a refactor to simplify the project structure and improve its performance.

🤖 Generated by Copilot at 57c9432

The project had some extra weight
From axios and functions state
So they cleaned up the files
With some refactoring styles
And made the deployment more great

code lgtm

pay 20 usd

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.48 USD/DOT ~ 4.464 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x2e8b1c57899a2c14937a08e2ebe9d3cf5e231155febbf8fe97d84c7e5073fcd8
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Possible Fix For #67 - Change referenceSize static var to func

Why
This is a possible attempt to fix the issue #67.
It gives developers maximum flexibility while retaining a simple interface, which is the same of the PlasticNodeDescription's layout func.
Changes

[BC] Change ReferenceSizeable referenceSize var to func with injected props and state

Tasks

[ ] Add relevant tests, if needed
[ ] Add documentation, if needed
[ ] Update README, if needed
[ ] Ensure that all the examples (as well as the demo) work properly

Static variables can be computed, giving the same behavior as functions. It would probably be cleaner to do that instead (I don't think it requires any changes).

@Danappelxx how would you change the output of the getter if you can't pass any parameter to it?
You would need to use singletons and/or static properties of other struct/classes which somehow retain a state and this would be against the principle of having only pure functions. I'm very open to suggestions!

I don't think this is the way to go to be honest. I was thinking more to a double reference size, one for each orientation. But this is not the problem.
The problem right now is that we don't have any concrete use case in which we have this problem.
To be honest I don't want to introduce a change in Katana just because it feels the correct way to handle it. I'd like to introduce changes when we need (or the community needs) them. Because you have a concrete scenario as a benchmark. Here we don't have it. We will end up adding a breaking change which most likely won't work in some other scenario (and this will require another breaking change).
I'd postpone the solution to when someone has this issue

My bad! I somehow glanced over the parameters in the method :)

I though having a function that receives props and state to be the most agnostic and consistent way to tackle the issue. Two reference sizes for each orientation seems to me an approach that is too bound to the world of iOS (e.g. would probably won't work good enough for MacOS).
Anyways I suggest to use this thread to discuss only about this current PR proposal and use the #67 for all the rest.
I agree that having Breaking Changes is bad and in this specific case probably also unneeded.
I will try to fix this PR to avoid any BC.


Add Smithery to README

This PR makes two changes to the README.

Adds installation instructions to automatically install CMD Server for Claude Desktop using Smithery CLI. This makes it easier for users to install the MCP.
Adds a badge to show the number of installations from Smithery: CMD Server Smithery Link

Let me know if any tweaks have to be made!

Hey thanks for contributing, will merge.


br_netfilter doesnt exist in centos/rhel 6.6

# modprobe br_netfilter
FATAL: Module br_netfilter not found.

Is a fallback needed here: https://github.com/docker/libnetwork/blob/863fee7c2d33d7d6d4414774dd7094eb5eefb7d0/drivers/bridge/bridge.go#L111 ? Do other kernel modules need to be loaded to allow #312 to be addressed?

closing this one


Valid HTML5 custom elements render once but do not update

https://github.com/cferdinandi/reef/blob/master/src/components/render.js#L347
This code seems to make the assumption that one would never want to diff inside of a custom element / web component, but it's unclear to me why this assumption is made. This behavior was unexpected and took quite a bit of time to identify.
Test case: https://codepen.io/_x2a/pen/mdZrZoo

Yes, that's very much by design. Web Components handle their own state internally, and should not be differed by state-based UI libaries.

Yes, that's very much by design. Web Components handle their own state internally, and should not be differed by state-based UI libraries.
That's documented here: https://reefjs.com/advanced/web-components/#in-templates
You can use Reef inside your Web Component for Reactivity, though, if desired: https://reefjs.com/advanced/web-components/#reactive-web-components


ModuleNotFoundError

I followed the installation tutorial  using conda and right now, the only way it works in my system is if I run the script from the project's folder.
Here I tried to import it in both Python and the Getting Started tutorial. In both cases I get the error ModuleNotFoundError: No module named 'capymoa.datasets'; 'capymoa' is not a package.

However, if I run it from the project's folder, it works.

Is there any idea why this is not working? I know I can use docker, but it is always easier to use pip install and use it 😃

Hi @fabriciojoc , thanks for reporting that. @tachyonicClock can you please assist? I am a bit overwhelmed today

Hi @fabriciojoc thanks for your issue. Did you install using pip install capymoa or
git clone git@github.com:adaptive-machine-learning/CapyMOA.git # or your fork
cd CapyMOA
pip install --editable ".[dev]"

?

On second glance of your bug report it looks like a name conflict between you script and the capymoa module. Python is trying to look for capymoa.* in capymoa.py. This explains why you can import capymoa in other directories where the conflict does not exist.
Try renaming your script capymoa.py to run_capymoa.py.

Hi @fabriciojoc thanks for your issue. Did you install using pip install capymoa or
git clone git@github.com:adaptive-machine-learning/CapyMOA.git # or your fork
cd CapyMOA
pip install --editable ".[dev]"

?

Hi @tachyonicClock. Thanks for checking! I tried using pip install capymoa and it didn't work. Then I used pip install --editable ".[dev]" and it started working only in the project's folder.

On second glance of your bug report it looks like a name conflict between your script and the capymoa module. Python is trying to look for capymoa.* in capymoa.py. This explains why you can import capymoa in other directories where the conflict does not exist.
Try renaming your script capymoa.py to run_capymoa.py.
(See https://python-notes.curiousefficiency.org/en/latest/python_concepts/import_traps.html#the-name-shadowing-trap for more)

@tachyonicClock you were right! I think my Python was trying to import capybara through the script I created, even when I just typed import capybara in the Python terminal. So in the end, it is not a bug! Just to clarify, now it is working even without conda. By just using pip install capymoa, I can already use it! Thanks for clarifying!

Glad we could help :D


Change references to use a group email

Disclaimer: there may be more to this than just changing the field; if so, let's capture this PR on the "upgrade cert-manager" card


HXML MultiTarget project improvement

It would be nice to split js target in a HXML MultiTarget-project, so that js is launched in the browser from some index.html, and nodejs is like js now: node $(ProjectID).js.
The Projects/395 Haxe - HXML Project/hxml/nodejs.hxml.template file could be like this:
hxml/common.hxml
-lib hxnodejs
-js bin/js/$(ProjectID).js

Also, may be it is time to remove the deprecated as3 target from the list of default targets (in /Settings/Platforms/Haxe/multitarget.xml) because as3 target not supported in haxe 4.1+ anymore.

Perhaps it is better to leave this type of project as it is, but make a new type of project with a list of targets, which is formed from a hxml-file (for each --next entry), with different runners. But it is not yet clear how to organize runners for targets.

via #3138


$10k project idea #1 - Accessibility & Rocket.Chat

The government is starting to use Rocket.Chat for internal & external messaging in GCMessage.
Identify accessibility problems within this open source platform, search to see if they are already known in the community and if they aren't already known problems, submit them to the issue queue here https://github.com/RocketChat/Rocket.Chat/issues
If time allows, provide patches, screenshots or provide links to documentation to help existing issues be better understood and resolved.

The open source community is moving towards the Matrix.org protocol, and it looks like there's interest from Canada as well.
I wrote about the trend at https://colan.consulting/blog/representing-drupal-gsoc-2017-mentor-summit .  In there, I mention that the Rocket.Chat folks are working towards that protocol.  See Matrix and Riot confirmed as the basis for France’s Secure Instant Messenger app for France's involvement with a Canada mention.
I'm actually not sure that Rocket.Chat is the way to go when Riot is supported by the Matrix team.

Like so many choices, we can only know in hindsight. Matrix.org looks cool.
I just know that the Drupal community has chosen Rocket.chat for their Slack alternative:
https://www.drupal.org/node/2958812
I know that Riot was looked at too.
I don't see this as being an issue to debate Riot vs Rocket. Both have accessibility problems.
Please set up a new issue to look at addressing or identifying accessibility issues in Riot.

I just know that the Drupal community has chosen Rocket.chat for their Slack alternative:
https://www.drupal.org/node/2958812

That's news to me!  I thought it was Matrix.  I've been following all of those conversations, which led to https://www.drupal.org/project/matrixchat.
In any case, I won't be opening another ticket for this as I'm not super-invested in the topic.  I just wanted to make sure that folks are aware that energy has been invested in other products, and that should be considered before investing resources into Rocket.Chat.

You could be right. Could be that it's a segment of the IRC community that is going that way. There seems to be reasonable support for Rocket.Chat as a module https://www.drupal.org/project/rocket_chat
Very good to know that there are reasons for looking at other options too.  $10k to improve an open source project that the government is presently using (but might not be for long) isn't a waste. Might even be solutions that could get migrated over to other platforms.

From Medium post: https://medium.com/@mgifford/i-would-definitely-update-it-with-or-without-covid-19-e326e1882603
Update on issue from May 2020
#1 — Rocket.Chat is still great, as is Riot! But the GC seems to have completely failed to promote it internally. The hope that Microsoft Teams was going to solve the problem of messaging. From what I understand Teams tends to cement silos rather than dissolve them. I don’t agree with the strategy, but if the plan is to only use MS Teams, there’s not much point in investing in anything else.

Just adding the Riot accessibility label on github https://github.com/vector-im/riot-web/labels/accessibility


ERA5 and WRF simulation

Hi,
I want to analyse the simulated WRF output  with ERA5. Could you please tell the simple method. I am new to WRF and intial WRF output share my previous colleague.
Thanks
Suvarna

Hi,
Please look at the PostWRF documentation. It has several examples which can help you to easily visualize and post-process the WRF (and ERA5) outputs:
https://postwrf.readthedocs.io/en/latest/
In case of further problems, you can discuss it here.

Ok. Thanks.
I have already started to read it.

when I run
./postwrf.sh
Error massage is as follows
More than one task is on
Select only one task or section in namelist.wrf and run again

The message is clear. You can activate only one task-section at a time.
For example, if both WRF_Extract_ON_OFF = 1 and CONTOUR_ON_OFF = 1, you will face this error message

ok, Thanks

Its run successfully. I have choose Bilinear. Not able to see the output ascii file.

outputs will be stored in new directories
Their names are started with output

Output folder is saved but it is empty. I will try it again and get back to you.

You can send me any warning or error messages you get.
Is your data WRF or ERA5?
For the WRF data you shouldn't face such problems. But for ERA5, you may have chosen some variables that are not inside the file.

It is for WRF
Now not able to run upto interpolation , although work path is correct
================  PostWRF (Version 1.1)  =====================
Run './postwrf.sh -h' to get help
In case of problems, please contact<EMAIL_ADDRESS>
  EXTRACT VARIABLE             EXTRACT VARIABLE

  No WRF output files in the current directory.
  You can link or copy one or more files to the current directory.

Where is your WRF output files?
Copy or link them into the PostWRF directory, and run postwrf.sh again.

I already linked it. my data is in same directory which I linked but still this massage is coming.

What is the names of your WRF output files?
You shouldn't change their names. They must have their generic names, starting with wrfout_d02 or wrfout_d02, ...

Are you sure about your WRF file? Did you run it correctly? Maybe your desired variable is not simulated and stored in the WRF output.
Can you send your namelist.wrf or copy the contents of WRF/ERA5 DATA EXTRACTION (ON SURFACE)?

I am sure about my WRF data. I repeat the entire process again but still problem exist. Surprisingly yesterday it run on same path but as I informed you outfolder was empty. In your namelist file I have made following changes.
WRF_Extract_ON_OFF               = 1
ERA5_Extract_ON_OFF              = 0
Variable_names                   = sp
Location_names                   = Indore
Location_latitudes               = 22.7196
Location_longitudes              = 75.8577
+Vertical_profile_plot_on_off    = 0
+Vprofile_X_axis_decimals       = 3

Variable_names = sp

What is sp? I have not seen this variable before.  Do you see sp among the variable?

You can also select diagnostic variables (not inside the WRF output) in the the list bellow:
./postwrf.sh -d

List of choosable diagnostic variables

avo           ( Absolute Vorticity [10-5 s-1])
eth           ( Equivalent Potential Temperature [K] )
cape_surface  ( 2D fields of CAPE [J/kg] )
cin_surface   ( 2D fields of CAPE [J/kg] )
cape_3d       ( 2D fields of CAPE [J/kg] )
cin_3d        ( 2D fields of CAPE [J/kg] )
ctt           ( Cloud Top Temperature [degC] )
dbz           ( Reflectivity [dBZ] )
mdbz          ( Maximum reflectivity [dBZ] )
geopt         ( Full model geopotential [m2 s-2] )
geopotential  ( Full model geopotential [m2 s-2] )
helicity      ( Storm Relative Helicity [m-2/s-2] )
omg           ( Omega [C] )
tk            ( Temperature [K] )
p/pres        ( Full model pressure [Pa] )
pressure      ( Full model pressure [hPa] )
pvo           ( Potential Vorticity [PVU] )
pw            ( Precipitable Water )
rh2           ( 2m Relative Humidity [%] )
rh            ( Relative Humidity [%] )
slp           ( Sea Level Pressure [hpa] )
ter           ( Model terrain height [m] )
td2           ( 2m dew point temperature [C] )
td            ( Dew point temperature [C] )
tc            ( Temperature [C] )
th/theta      ( Potential temperature [K] )
tv            ( Virtual temperature [K] )
twb           ( Wet bulb temperature [K] )
updraft_helicity ( Updraft helicity [m-2/s-2] )
ua            ( U component of wind on mass points )
va            ( V component of wind on mass points )
wa            ( W component of wind on mass points )
z/height      ( Full Model Height [m] )
lfc           ( Level of Free Convection )
lcl           ( Lifted Condensation Level )
dust_total    ( Total Dust Concentration [Microgram/Kg_dry_air] )
dust_pm10     ( Dust Concentration equal to PM10 [Microgram/Kg_dry_air] )
dust_pm2.5    ( Dust Concentration equal to PM2.5 [Microgram/Kg_dry_air] )
wind_s        ( NCL6.5: Wind Speed [m/s] )
wind_d        ( NCL6.5: Wind Direction [degrees from north] )

Sorry by mistake I shared wrong. My variable is tr18_24. Whether it will run or not.
Correct information
================== WRF/ERA5 DATA EXTRACTION (ON SURFACE)- Indore ====================
WRF_Extract_ON_OFF               = 1
ERA5_Extract_ON_OFF              = 0
Variable_names                   = tr18_24
Location_names                   = Indore
Location_latitudes               = 22.7196
Location_longitudes              = 75.8577
+Vertical_profile_plot_on_off    = 0
+Vprofile_X_axis_decimals       = 3

What is tr18_24 exactly? I want to know if tr18_24 is inside your WRF output?
Run the command below (put your WRF file-name instead of wrfout). What do you see after running the command?
./postwrf.sh -f wrfout | grep -i tr18_24

run the command, no massage.

Show the whole command you ran.
"No message" is not possible, if the WRF file and name is okay.

./postwrf.sh -f wrfout_d01_2019-01-18_00:00:00 | grep -i tr18_24.
I checked wrfout put bu ncview, variable is their.

0.3134E-19  0.1302E-20  0.3929E-21  0.3757E-20  0.7027E-20  0.1201E-18
0.6118E-19  0.7452E-21  0.1043E-20  0.8516E-20  0.6330E-19  0.6330E-1
values like this

Go to the directory of wrfout_d01_2019-01-18_00:00:00:
Run the commands below:
ncl
a = addfile("wrfout_d01_2019-01-18_00:00:00", "r")
printVarSummary(a->tr18_24)

What do you see now?

all details of variable like
Variable: tr18_24 (file variable)
Type: float
Total Size: 4145568 bytes
1036392 values
Number of Dimensions: 4
Dimensions and sizes:   [Time | 1] x [bottom_top | 42] x [south_north | 124] x [west_east | 199]
Coordinates:
Number Of Attributes: 6
etc..........................

If wrfout_d01_2019-01-18_00:00:00 is your WRF file, and if you can display it by ncview, then your file is okay and ./postwrf.sh should recognize your file and work on it.
There is one point:

Dimensions and sizes: [Time | 1] x [bottom_top | 42] x [south_north | 124] x [west_east | 199]

What kind of physical variable is tr18_24? What is the name of it? This variable doesn't have any time series (because of [Time | 1]).

it is emission variables so we used different code for different 26 pollutants

Can you extract T2 from you wrfoutput?

WRF_Extract_ON_OFF = 1
ERA5_Extract_ON_OFF = 0
Variable_names = T2
Location_names = Indore
Location_latitudes = 22.7196
Location_longitudes = 75.8577

will try
On Wed, Nov 9, 2022 at 3:37 PM Amirhossein Nikfal @.***>
wrote:

Can you extract T2 from you wrfoutput?
WRF_Extract_ON_OFF = 1
ERA5_Extract_ON_OFF = 0
Variable_names = T2
Location_names = Indore
Location_latitudes = 22.7196
Location_longitudes = 75.8577
—
Reply to this email directly, view it on GitHub
https://github.com/anikfal/PostWRF/issues/11#issuecomment-1308861209,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AONKPU2BGCIP6UTM7XJ47TLWHOZKVANCNFSM6AAAAAARXO66NI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Dr. Suvarna Tikle
Postdoctoral researcher
Environmental Modeling Division
Max Planck Institute for Meteorology
Bundesstr. 53
D-20146 Hamburg
@.***
+91<PHONE_NUMBER>

same massage
=================  PostWRF (Version 1.1)  =====================
Run './postwrf.sh -h' to get help
In case of problems, please contact @.***>

 EXTRACT VARIABLE             EXTRACT VARIABLE

 No WRF output files in the current directory.
 You can link or copy one or more files to the current directory.

On Wed, Nov 9, 2022 at 3:38 PM Dr.Suvarna Tikle @.***> wrote:

will try
On Wed, Nov 9, 2022 at 3:37 PM Amirhossein Nikfal <
@.***> wrote:

Can you extract T2 from you wrfoutput?
WRF_Extract_ON_OFF = 1
ERA5_Extract_ON_OFF = 0
Variable_names = T2
Location_names = Indore
Location_latitudes = 22.7196
Location_longitudes = 75.8577
—
Reply to this email directly, view it on GitHub
https://github.com/anikfal/PostWRF/issues/11#issuecomment-1308861209,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AONKPU2BGCIP6UTM7XJ47TLWHOZKVANCNFSM6AAAAAARXO66NI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Dr. Suvarna Tikle
Postdoctoral researcher
Environmental Modeling Division
Max Planck Institute for Meteorology
Bundesstr. 53
D-20146 Hamburg
@.***
+91<PHONE_NUMBER>

--
Dr. Suvarna Tikle
Postdoctoral researcher
Environmental Modeling Division
Max Planck Institute for Meteorology
Bundesstr. 53
D-20146 Hamburg
@.***
+91<PHONE_NUMBER>

Can you send your WRF file to me?

Sorry but I can not because of our Maxplank policy.

Where is your WRF output files?
Copy or link them into the PostWRF directory, and run postwrf.sh again.

So in our meeting we realized this was the problem.

Yes.
Thanks for resolving the issue.
On Thu, Nov 10, 2022 at 10:19 AM Amirhossein Nikfal <
@.***> wrote:

Where is your WRF output files?
Copy or link them into the PostWRF directory, and run postwrf.sh again.
So in our meeting we realized this was the problem.
—
Reply to this email directly, view it on GitHub
https://github.com/anikfal/PostWRF/issues/11#issuecomment-1309991720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AONKPU6QBWYCWQCPDTKSVF3WHS4YPANCNFSM6AAAAAARXO66NI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Dr. Suvarna Tikle
Postdoctoral researcher
Environmental Modeling Division
Max Planck Institute for Meteorology
Bundesstr. 53
D-20146 Hamburg
@.***
+91<PHONE_NUMBER>


mptcp.service systemd unit file does not grant CAP_NET_ADMIN capability

Describe the bug
mptcpd requires the CAP_NET_ADMIN capability to be able to issue commands over the MPTCP generic netlink API exposed by the kernel, but it's mptcp.service file doesn't explicitly grant that capability since it runs mptcpd under an unprivileged dynamically created user.
To Reproduce
Steps to reproduce the behavior:
Server

Set up a host, such as a virtual machine, as an MPTCP server with multiple network interfaces.  Make sure the multipath-tcp.org kernel is built with the mptcp_netlink path manager enabled.
Build and install mptcpd (e.g. ./configure; make; sudo make install)
sudo systemctl daemon-reload
sudo systemctl restart mptcp
Execute an MPTCP capable process that listens for connections.

Client

Set up a host, such as a virtual machine, as an MPTCP client.  Make sure the kernel is built with MPTCP support enabled.
Execute an MPTCP capable process that establishes a connection with the process listening for connection on the server host.

Server
The server host's log will show "operation not permitted" errors from mptcpd.  The errors occur because the mptcpd process doesn't have the CAP_NET_ADMIN capability needed for sending MPTCP generic netlink API commands to the kernel.  See the Screenshots section below for a system journal excerpt showing the errors.
Expected behavior
MPTCP generic netlink API commands emanating from a mptcpd process started by systemd should not be rejected due to lack of privileges.
Screenshots
Jun 06 10:18:03 vm-server mptcpd[20672]: Path manager command error: Operation not permitted
Jun 06 10:18:03 vm-server mptcpd[20672]: Path manager command error: Operation not permitted
Jun 06 10:18:03 vm-server mptcpd[20672]: Path manager command error: Operation not permitted
Jun 06 10:18:03 vm-server mptcpd[20672]: Path manager command error: Operation not permitted
Jun 06 10:18:03 vm-server mptcpd[20672]: Path manager command error: Operation not permitted
Jun 06 10:18:03 vm-server mptcpd[20672]: Path manager command error: Operation not permitted

Desktop (please complete the following information):

Linux Kernel: 4.19 (multipath-tcp.org kernel built for an Ubuntu system)
Compiler: 8.3.0

Additional context
The mptcp.service unit file explicitly avoids starting mptcpd as the root user by setting DynamicUser=yes to minimize security risks.

Proposed patch:
diff --git a/src/mptcp.service.in b/src/mptcp.service.in
index 74419e9..37393fa 100644
--- a/src/mptcp.service.in
+++ b/src/mptcp.service.in
@@ -13,6 +13,7 @@ DynamicUser=yes
 Environment=LD_LIBRARY_PATH=@libdir@
 ExecStart=@libexecdir@/mptcpd --log=journal
 CapabilityBoundingSet=CAP_NET_ADMIN
+AmbientCapabilities=CAP_NET_ADMIN
 LimitNPROC=1

 [Install]


Adding SQL certification course

hi @avinash201199    I have added free SQL certification course please merge it.

also add in readme file

hi @avinash201199  I have updated the readme file please check it and merge it .
Thank you


[WIP] Iss32 recipe for CSV eval of one chip

Added nbsphinx and created a Jupyter Notebook recipe for comparing a proposal CSV to a ground truth CSV. Enabled rendering within sphinx, re-formatted documentations, and connected to rtfd.

See #32.


Pev2 vue3

This is an important update!
Now that PEV2 is even easier to use as a standalone project (See https://github.com/dalibo/pev2#all-in-one-local-no-installation-no-network), I decided to get rid of the "don't store immediately in DB" and the "share" button. Now the plans are always sent to server.
PEV2 has been updated and we're now using Vue3 + ViteJS for the build process. It's faster and requires less configuration.
Also because plans are stored in DB, localStorage usage is much less important. The issue #6 will not be relevant anymore.
I decided not to change entropy yet. I've never heard of anyone complaining of the lack of entropy in https://explain.depesz.com. Please correct me if I'm wrong.

I've never heard of anyone complaining of the lack of entropy in https://explain.depesz.com/. Please correct me if I'm wrong.

Depesz has an option to anonymize plans, which I've always used, while Dalibo doesn't. I also never felt comfortable using Depesz for anything sensitive, but I was able to use Dalibo all of the time since it didn't share my plans with the serevr. The two are not comparable. Why not just make the very simple change to increase entropy?

@nightpool thanks for your honest feedback. I'll consider adding more entropy. I left the issue you opened a while ago open.
Additional question: Are you aware that there is a standalone (browser only) version of PEV2? Do you use it?


feat(rbac): casl

The CASL is not needed. The existing RBAC is more than enough for our usage

The CASL is not needed. The existing RBAC is more than enough for our usage

I just like to ver engineer stuff

Adding Complexity is Not Engineering


[ENH] Experimenting with circleci

Ok, this PR cuts the runtime down to 4 min (it was 4'30'' :P)

30 seconds of sword fighting... lost forever!


Cannot parse non-alphanumeric characters when not encoded

envoy (which use http-parser as parser) cannot parse  unurlencoded non-alphanumeric characters (e.g. Chinese characters) correctly when process HTTP requests with it.
I know http standard does not allow double-byte characters in requests, it must be urlencoded. But we cannot control clients' behaviors and mandatory require them follow this standard. Even some unreasonable says that nginx have strong compatibility why envoy and http-parser can't?
Is there any way to compatible it?
related issue in envoy: https://github.com/envoyproxy/envoy/issues/4854

Thank you for reporting this!
Unfortunately, I'm afraid that http-parser does the right thing by rejecting such invalid requests.

If you really wanted to do this, you could float a patch on top of http-parser that extends the tokens array in http_parser.c to accept bytes in the range 128-255. But like Fedor said, the current behavior is not a bug.

@bnoordhuis Thanks for your help, it's really not a bug, I'll try it 😄


Missing deployment documentation

The README references some 'activator' script that is not part of the repository.
And beside deploying to Heroku there is no description of how to deploy the app to a self-hosted server.

@schleichardt do we want to re-enable the activator or remove it completely?

re-enable would be nice

Would you mind doing it yourself?

Ok https://github.com/sphereio/sphere-sunrise/issues/149

Thanks :)

Refer to Play deployment documentation

so should point in the readme to https://www.playframework.com/documentation/2.5.x/Deploying

https://github.com/commercetools/commercetools-sunrise-java-starter is now the place for that. It contains already some of the fixes and the rest should be as issues.


Memory Corruption in sha1_block_data_order

I've recently discovered memory corruption in 1.0.2l in the sha1_block_data_order logic. It's easily reproducible across OS's.
Using the imported static libs, call  SSL_CTX_new(TLSv1_2_method()) and set bp on sha1_block_data_order. Regardless of which jump is taken the RSP gets pushed down the stack and the stack pointers start to get overwritten with heap addresses:
u OpenSSL1_0_2!sha1_block_data_order l10
	00007ffb`5883b000 48897c2408      mov     qword ptr [rsp+8],rdi
	00007ffb`5883b005<PHONE_NUMBER>      mov     qword ptr [rsp+10h],rsi
	00007ffb`5883b00a 488bc4          mov     rax,rsp
	00007ffb`5883b00d 488bf9          mov     rdi,rcx
	00007ffb`5883b010 488bf2          mov     rsi,rdx
	00007ffb`5883b013 498bd0          mov     rdx,r8
	00007ffb`5883b016 448b0d73311000  mov     r9d,dword ptr [OpenSSL1_0_2!OPENSSL_ia32cap_P (00007ffb`5893e190)]
	00007ffb`5883b01d 448b0570311000  mov     r8d,dword ptr [OpenSSL1_0_2!OPENSSL_ia32cap_P+0x4 (00007ffb`5893e194)]
	00007ffb`5883b024 448b156d311000  mov     r10d,dword ptr [OpenSSL1_0_2!OPENSSL_ia32cap_P+0x8 (00007ffb`5893e198)]
	00007ffb`5883b02b 41f7c000020000  test    r8d,200h
	00007ffb`5883b032 744c            je      OpenSSL1_0_2!sha1_block_data_order+0x80 (00007ffb`5883b080)
	00007ffb`5883b034 41f7c200000020  test    r10d,20000000h
	00007ffb`5883b03b 0f8595100000    jne     OpenSSL1_0_2!sha1_block_data_order_shaext+0x16 (00007ffb`5883c0d6)
	00007ffb`5883b041 4181e228010000  and     r10d,128h
	00007ffb`5883b048 4181fa28010000  cmp     r10d,128h
	00007ffb`5883b04f 0f84f12f0000    je      OpenSSL1_0_2!sha1_block_data_order_avx2+0x16 (00007ffb`5883e046)

On this OS the jne to +0x16 is taken:
OpenSSL1_0_2!sha1_block_data_order_shaext+0x16:
        00007ffb`5883c0d6 488d6424b8      lea     rsp,[rsp-48h]

Once you step past this command, the stack is corrupted:
0:000> k
	 # Child-SP          RetAddr           Call Site
	00 00000031`bb8fec20 00005d49`00000000 OpenSSL1_0_2!sha1_block_data_order_shaext+0x1b
	01 00000031`bb8fec28 0000016b`22208d30 0x00005d49`00000000
	02 00000031`bb8fec30 0000016b`22209b50 0x0000016b`22208d30
	03 00000031`bb8fec38 0000016b`22206f20 0x0000016b`22209b50
	04 00000031`bb8fec40 00000000`00000048 0x0000016b`22206f20
	05 00000031`bb8fec48 00007ffb`58652a97 0x48
	06 00000031`bb8fec50 00000000`00000000 OpenSSL1_0_2!default_malloc_ex+0x27

These are mostly heap addresses where the stack pointers should be:
0:000> !heap
        Heap Address      NT/Segment Heap

         16b22190000              NT Heap
         16b21f90000              NT Heap
         16b220f0000              NT Heap

I've tested this on 1.0.2j, 1.0.2l, Windows 10x64, Windows 8x64.
The jumps are different depending on chipset but they all inevitably lead to similar corruption.
It looks like it's corrected with a mov rsp,rax command before returning so it is usually not noticeable but in some circumstances it leads to heap corruption and crash.

You're misinterpreting your observations. For starters lea rsp,[rsp-48h] doesn't push anything to stack, but reserves a frame [full of data remnants from previous call to some other subroutine]. There is no corruption, what you observe is inability of debugger to unwind stack backtrace for function without associated stack unwinding information. It's known limitation, just live with it.

@dot-asm
I would "just live with it" but unfortunately it is causing stack corruption, a c0000005 memory access violation and then c0000374 heap corruption with the AES-NI flow on the ApolloLake chipset.
I've noticed the only difference between the working flow and the AES-NI flow is that in the working flow, the rsi is saved to r8 and rax is being used to hold the rsp. In the non-working flow, rsi is overwritting rax which is then used for the rsp before the rep ret.
Working:
...
00007ffb`5883c143 4c8d4640        lea     r8,[rsi+40h]
...
00007ffb`5883c14b 490f45f0        cmovne  rsi,r8
...
00007ffb`5883c375 488be0          mov     rsp,rax
...

Non-Working:
...
00000001`80143e83 488d4640        lea     rax,[rsi+40h]
...
00000001`80143e8b 480f45f0        cmovne  rsi,rax
...
00000001`801440b5 4889c4          mov     rsp,rax
...

Working:

That's how 1.0.2l, one in report, look like. Yes, there was bug that was specific to Windows and processors with SHAEXT capability, and it was fixed a year ago.

I'm not misinterpreting the fact that there is a process crash.

 From one hand you assert that it's working, and from another that there is crash. There was crash in 1.0.2h and earlier, again, specific to Windows and some processors, but that's not what was claimed in original report.

@dot-asm
If you read the last line of the original report you will see where I stated it can lead to heap corruption and crash.
There are two flows that I observe:

The "working" one. This is the stack trace I originally provided because the stack looked incorrect to me. I assumed that this was an issue and was specifically related to the crash that I am seeing. I'll take your word for it that I am incorrect on this. Since you claim that this is normal and there is no crash here I am referring to it as the "working" one.

The non-working flow. Here the stack also looks incorrect to me just like in the working flow but unlike the other flow, the stack doesn't get restored when rax is moved to rsp. The function tries to return but doesn't know where to return to because the stack is incorrect. This is the one that is clearly not working correctly. It happens on 1.0.2j and 1.0.2l on x64 OS when AES-NI is enabled.

I apologize for not explaining this more clearly.

The non-working flow.

And the question where does it come from. Both 1.0.2j and 1.0.2l (as well as one in the middle and one prior) do not have lea rax,[rsi+40h]. Note that I'm not saying that the instruction in question wouldn't trigger crash upon return, what I'm saying is that there is no lea rax,[rsi+40h] in 1.0.2i and forward. If you have one, then you either have non-pristine source code, or [if your application is linked dynamically] somehow pick old DLL. In either case the question is rather for you to answer.

It happens on 1.0.2j and 1.0.2l on x64 OS when AES-NI is enabled.

It was happening up to 1.0.2h on Windows on processors with SHA instruction extension (which is not same as AES-NI).

We've cleaned and rebuilt the OpenSSL libs (we're statically linking), checked the imports and library pathing, and cleaned and rebuilt the project. I've confirmed that the project is running 1.0.2j.
The code works across many systems but we only see this problem with Intel ApolloLake processors and have only been able to work around it by setting openssl_ia32cap_p=~0x200000200000000 before the ssl_ctx_new call.

Well, it still doesn't answer the question where does lea rax,[rsi+40h] come from. If I download 1.0.2j and build it, I don't see the instruction in question in SHAEXT code path nor do I have problems executing it on Goldmont processor running Windows.

setting openssl_ia32cap_p=~0x200000200000000 before the ssl_ctx_new call.

What does it mean? Customarily users set OPENSSL_ia32cap environment variable, i.e. no _p, but it's not something that can be described as "before ssl_ctx_new call". You would set before starting application. There is OPENSSL_ia32cap_P private vector, but you are not supposed to use it in application code. Documented way for 1.0.2 is to call OPENSSL_ia32cap_loc() to obtain pointer. And just calling it clears SHAEXT as side effect [this is done for backward compatibility]. But even so setting value to ~0x200000200000000 would even set AVX bit, which would trigger invalid instruction exception, because processor in question doesn't support AVX. In other words the statement calls for irreconcilable questions...
I'm not going to answer anymore till reproducible problem description starting with "download 1.0.2j from ftp.openssl.org" is provided. Or rather 1.0.2l, as it's lesser point spending energy on out-of-date version.
P.S. Just in case for reference. Setting environment variable to any value actually zeros capability flags such as AVX2, ADCX as well as SHAEXT. In other words SHAEXT flag being cleared as result of ~0x200000200000000 in environment variable is known side effect. It's possible to zero specifically SHAEXT flag by setting environment variable in question to :0

Hello,
I have found out similar problem with openssl.
I have tested version 1.0.2g and then updated to 1.0.2p and it didnt help.
We get crashes from users and the DxDiags states following processors:
Processor: Intel(R) Pentium(R) CPU N4200 @ 1.10GHz (4 CPUs), ~1.1GHz
Processor: Intel(R) Celeron(R) CPU N3350 @ 1.10GHz (2 CPUs), ~1.1GHz
Which are the "ApolloLake" chipset processors.
@dot-asm repro would require to have such computers

updated to 1.0.2p and it didnt help.

I still can't confirm that upgrade from 1.0.2g to 1.0.2p doesn't help SHA1. I take sha1test.exe from 1.0.2g and it crashes on Windows on Goldmont. I take sha1test.exe from 1.0.2p and it does not. So I'd like you to download fresh copy of 1.0.2p and first configure it with no-shared. Then execute sha1test.exe from CMD prompt. Does it crash? Then reconfigure with shared, recompile, and run "shared" sha1test.exe. Does it crash? If it doesn't (it shouldn't) and application does, then application is either still picking old .DLL or it's different problem entirely.

We do not have the problems locally, we only have information for users. We use static version of openssl and we include it entirely into our dll. At least 5 users reported that zeroing the ia32cap (set OPENSSL_ia32cap=0 && Gwent.exe) solved the problem for them. We are looking for more general solution.

You don't have to have hardware, you can use Intel SDE (first hit in google search) to start your application on available hardware. In this case sde -glm Gwent.exe would do. As implied question is if it's actually same problem, so we should be looking for is to attach to process with debugger and examine crash point. Now, I know how to do it on Linux, but never tried on Windows, so you're rather on your own. You mention Gwent.exe, is it something I can download? And if so, what would I have to do to trigger crash. And what do users report? I mean does error message or event log entry provide any stack back-traces that actually confirm that it's problem with sha1?


New gem release

When are you guys going to release the next cut of cinch?  Are there open issues that need to be resolved before you are wiling to cut a new release?

The next version is going to be a new major version (2.0.0) and as such will come with some big changes, including an revised API and a lot of new features.
As such it will take quite some time until the next release, especially considering that I am rather busy with other things at the moment. I'm not seeing a new release in the next 2 months.


demoman primary weapon glow

Config used:
https://files.catbox.moe/r19cw0.fw
Description:
it only works on demoman and his weapon (dont know if it is intentional or not)
Additional context

Should be fixed in a6a9c856d57fcb220bfe37dc54e8344f523c0849


feat: added shipping price to delivery option and cart preview

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

https://github.com/vuestorefront-community/prestashop/issues/67

https://github.com/vuestorefront-community/prestashop/issues/79


Remove spurious inline specifier in the documentation and examples

Why? I understand that it works fine in this case. But if a user copy-pastes it, and then moves the body out of struct, that would not be inlined, right?

But if a user copy-pastes it, and then moves the body out of struct, that would not be inlined, right?

It depends.  Will the user copy/paste the static as well?


why I have  This  problem

Sorry to bother you I have this problem few days and still can not  find a solution . my tensorflow 0.11   I run python main.py --dataset mnist --is_train True , this problem occurs:
ValueError: Variable g_bn0/g_bn0_2/g_bn0_2/moments_1/moments_1/mean/ExponentialMovingAverage/biased does not exist, or was not created with tf.get_variable(). Did you mean to set reuse=None in VarScope?
can you help me   thank  you

ld@ld-To-be-filled-by-O-E-M:~/TensorflowProject/DCGAN-tensorflow-master$ sudo python main.py --dataset mnist --is_train True
[sudo] password for ld:
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcublas.so.8.0 locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcudnn.so.5 locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcufft.so.8.0 locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcurand.so.8.0 locally
{'batch_size': 64,
'beta1': 0.5,
'c_dim': 3,
'checkpoint_dir': 'checkpoint',
'dataset': 'mnist',
'epoch': 25,
'image_size': 108,
'is_crop': False,
'is_train': True,
'learning_rate': 0.0002,
'output_size': 64,
'sample_dir': 'samples',
'train_size': inf,
'visualize': False}
I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:936] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
I tensorflow/core/common_runtime/gpu/gpu_device.cc:885] Found device 0 with properties:
name: GeForce GTX 1060 6GB
major: 6 minor: 1 memoryClockRate (GHz) 1.759
pciBusID 0000:01:00.0
Total memory: 5.93GiB
Free memory: 5.35GiB
I tensorflow/core/common_runtime/gpu/gpu_device.cc:906] DMA: 0
I tensorflow/core/common_runtime/gpu/gpu_device.cc:916] 0:   Y
I tensorflow/core/common_runtime/gpu/gpu_device.cc:975] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 1060 6GB, pci bus id: 0000:01:00.0)
0k
yes
2
(<tf.Output 'real_images:0' shape=(64, 28, 28, 1) dtype=float32>, <tf.Output 'y:0' shape=(64, 10) dtype=float32>)
3
Traceback (most recent call last):
File "main.py", line 64, in
tf.app.run()
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 43, in run
sys.exit(main(sys.argv[:1] + flags_passthrough))
File "main.py", line 39, in main
dataset_name=FLAGS.dataset, is_crop=FLAGS.is_crop, checkpoint_dir=FLAGS.checkpoint_dir, sample_dir=FLAGS.sample_dir)
File "/home/ld/TensorflowProject/DCGAN-tensorflow-master/model.py", line 69, in init
self.build_model()
File "/home/ld/TensorflowProject/DCGAN-tensorflow-master/model.py", line 89, in build_model
self.sampler = self.sampler(self.z,self.y)
File "/home/ld/TensorflowProject/DCGAN-tensorflow-master/model.py", line 359, in sampler
h0 = tf.nn.relu(self.g_bn0(linear(z, self.gfc_dim, 'g_h0_lin')))
File "/home/ld/TensorflowProject/DCGAN-tensorflow-master/ops.py", line 34, in call
ema_apply_op = self.ema.apply([batch_mean, batch_var])
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/moving_averages.py", line 388, in apply
self._averages[var], var, decay, zero_debias=zero_debias))
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/moving_averages.py", line 70, in assign_moving_average
update_delta = _zero_debias(variable, value, decay)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/moving_averages.py", line 175, in _zero_debias
trainable=False)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/variable_scope.py", line 1024, in get_variable
custom_getter=custom_getter)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/variable_scope.py", line 850, in get_variable
custom_getter=custom_getter)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/variable_scope.py", line 346, in get_variable
validate_shape=validate_shape)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/variable_scope.py", line 331, in _true_getter
caching_device=caching_device, validate_shape=validate_shape)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/variable_scope.py", line 650, in _get_single_variable
"VarScope?" % name)
ValueError: Variable g_bn0/g_bn0_2/g_bn0_2/moments_1/moments_1/mean/ExponentialMovingAverage/biased does not exist, or was not created with tf.get_variable(). Did you mean to set reuse=None in VarScope?

@myw8
Have you fixed this issue?
I came across the same problem and i guess it relates to the new version of tensorflow

Sorry. I'm working on this problem and it will be fixed soon. I didn't keep in mind about the problem of legacy which is caused by the fast and wide upgrade of TensorFlow.

@may0324    I tried many times  conclude the conclusion ：use   cuda7.5  cudnnV4   tensorflow 0.8


RuntimeError: tensorflow/lite/kernels/read_variable.cc:74 variable_tensor->type != output->type (INT8 != FLOAT32)Node number 10 (READ_VARIABLE) failed to invoke.

Hello TF Lite Cummunity!
I'm doing tests with TF Lite converter on a machine, that, as far as I know, is equipped as follow:
1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux-5.4.188+-x86_64-with-Ubuntu-18.04-bionic
TensorFlow installation (pip package or built from source): installed via pip
TensorFlow library (version, if pip package or github SHA, if built from source): 2.8.2

2. Code
Starting from a TensorFlow model, I perform the following steps:

I perform a pruning operation on the model (everything works fine);
I convert the pruned model into a TensorFlow Lite model using tf.lite.TFLiteConverter.from_saved_model (everything works fine);
I evaluate such a pruned lite model using tf.lite.Interpreter(model_content=tflite_model) and subsequently interpreter.invoke() (everything works fine);
I then try to perform post-training full integer quantization and evaluate the model again; post-training full integer quantization seems to work fine because the model is properly converted. However, when I try to perform model evaluation, I got the following error "RuntimeError: tensorflow/lite/kernels/read_variable.cc:74 variable_tensor->type != output->type (INT8 != FLOAT32)Node number 10 (READ_VARIABLE) failed to invoke.", but I do not understand what could be the reason, and where I go wrong.

Here is the code:
interpreter.resize_tensor_input(input_details["index"], (2947, 128,9))
  interpreter.resize_tensor_input(output_details["index"], (2947, 6))
  interpreter.allocate_tensors()
  input_details = interpreter.get_input_details()[0]
  print("INPUT DETAILS POST RESIZE")
  print(input_details)
  output_details = interpreter.get_output_details()[0]
  print("OUTPUT DETAILS POST RISIZE")
  print(output_details)

  testX.dtype
  testX_numpy = np.array(testX, dtype=np.int8)
  testX_numpy.dtype

  # If required, quantize the input layer (from float to integer)
  input_scale, input_zero_point = input_details["quantization"]
  print("quantize the input layer (from float to integer)\n")
  x_test_ = testX_numpy / input_scale + input_zero_point
  x_test_ = x_test_.astype(input_details["dtype"])

  interpreter.set_tensor(input_details['index'], x_test_)
  interpreter.invoke()
  tflite_model_predictions = interpreter.get_tensor(output_details['index'])

3. Failure after conversion
As I've said, the model is properly converted, but during inference time interpreter.invoke() generates the following error:
RuntimeError: tensorflow/lite/kernels/read_variable.cc:74 variable_tensor->type != output->type (INT8 != FLOAT32)Node number 10 (READ_VARIABLE) failed to invoke.
5. (optional) Any other info / logs
Here is the result of prints from the above code:
INPUT DETAILS POST RESIZE
{'name': 'serving_default_lstm_input:0', 'index': 0, 'shape': array([2947,  128,    9], dtype=int32), 'shape_signature': array([ -1, 128,   9], dtype=int32), 'dtype': <class 'numpy.int8'>, 'quantization': (0.027058085426688194, -1), 'quantization_parameters': {'scales': array([0.02705809], dtype=float32), 'zero_points': array([-1], dtype=int32), 'quantized_dimension': 0}, 'sparsity_parameters': {}}
OUTPUT DETAILS POST RISIZE
{'name': 'StatefulPartitionedCall:0', 'index': 138, 'shape': array([2947,    6], dtype=int32), 'shape_signature': array([-1,  6], dtype=int32), 'dtype': <class 'numpy.int8'>, 'quantization': (0.00390625, -128), 'quantization_parameters': {'scales': array([0.00390625], dtype=float32), 'zero_points': array([-128], dtype=int32), 'quantized_dimension': 0}, 'sparsity_parameters': {}}
Here is the traceback:
RuntimeError                              Traceback (most recent call last)
in ()
--> 275   y_pred_qptfLite = predict_tflite_fullyint_quant(quantized_tflite_model)
in predict_tflite_fullyint_quant(tflite_model)
59
60   interpreter.set_tensor(input_details['index'], x_test_)
---> 61   interpreter.invoke()
62   tflite_model_predictions = interpreter.get_tensor(output_details['index'])
63
/usr/local/lib/python3.7/dist-packages/tensorflow/lite/python/interpreter.py in invoke(self)
914     """
915     self._ensure_safe()
--> 916     self._interpreter.Invoke()
917
918   def reset_all_variables(self):
RuntimeError: tensorflow/lite/kernels/read_variable.cc:74 variable_tensor->type != output->type (INT8 != FLOAT32)Node number 10 (READ_VARIABLE) failed to invoke.
I've Googled around to see if anyone had exactly the same kind of issue but did not find anything.

Hi @ChicchiPhD !
Have you provided a representative dataset and used
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8]
during integer quantization as per this document. .
Please provide complete code as colab gist (model snippet + quantization + inference) to replicate the issue.
Thank you!

Hi @ChicchiPhD !
It is replicating in 2.8, 2.9  but seems to be fixed in the nightly version. Could you let us know from your end.
Thank you!

Hi @mohantym !
I confirm that with nightly version know it works!
Thank you so much for your help!

Are you satisfied with the resolution of your issue?
Yes
No


PEP8 code style formatting

This PR adds pep8 and pycodestyle configurations so tools like autopep8 and pycodestyle can be used to keep the code consistent across different IDEs and developers workspaces.
It also runs autopep8 on every .py file so future diffs shouldn't show differences in formatting.

For developers I recommend this pre-commit hook to keep the code clean: https://gist.github.com/piojanu/50aefcef8d1b1d3e0761c6beea3a6336.

Thanks for this PR as well. I don't think I will merge this since we're using a different linter internally at Google. I might set up a linter configuration that's consistent with this (e.g. four space indent to continue lines) at some point in the future. On the other hand, I don't think this is very necessary for a research code base.


One API endpoint returning results for 2 different servers

Hey there,
I hope I'm writing about this in the right place.
When I fetch data from POWERBITS GAMETEAM HLL #2 public API to get the most recent state of the server, sometimes it provides data for one server and then for the other.
Is this some bug or some configuration fault on the side of Powerbits?
https://github.com/MarechJ/hll_rcon_tool/assets/65303812/708e40ad-f092-481a-bc33-c694c72c7d8e
Thanks

Peculiar, can you look at some of these mismatched ones and look at not just the response, but also the request and show us that as well?
Does it only happen on one page in the GUI (the public stats?) or can you reproduce it anywhere else.
Can you try running it against the API itself? http://localhost:8010/api/public_info as the URL for example and see if you can reproduce it?
I spammed the API request against our live server (has two servers in the same CRCON) and I could not reproduce it.

Including headers

https://github.com/MarechJ/hll_rcon_tool/assets/65303812/675a3b00-ebfd-4bbd-a903-d75a21f8915b


The delivered_at and last_attempt_at dates must be nullable for Notifications

🐛 Bug Report
When trying to retrieve notifications with client.list_notifications() validation errors might occur if there are still undelivered notifications because of any bugs in the webhook page.
🔬 How To Reproduce
Steps to reproduce the behavior:

Create a webhook page that raises a server error.
Create a notification setting reporting to that webhook
Trigger a notification by changing anything at Paddle sandbox
Try to list notifications using client.list_notifications()

Code sample
According to the docs, the delivered_at and last_attempt_at fields might be null. The Notification model definition must be changed.
https://developer.paddle.com/api-reference/notifications/overview
class Notification(BaseModel):
    id: str
    type: str
    status: str
    payload: NotificationPayload
    occurred_at: datetime
    delivered_at: datetime | None
    replayed_at: str | None
    origin: str
    last_attempt_at: datetime | None
    retry_at: str | None
    times_attempted: int
    notification_setting_id: str

Environment

OS: macOS
Python version: 3.10

Thanks for the report.
Fixed in https://github.com/websideproject/paddle-billing-client/releases/tag/v0.1.15

Thank you, bgervan!


MoneyFromMobs plugin

A short but important issue which is crucial .
The plugin works wonders really good plugin , But when killing a player I don't want the "Killed" player to lose money and vice versa, I just want it to be like a regular kill and get money (Like mobs) [And I know it could be a money machine that player can use but I don't mind it]
Lets say:
When killing a player the "killed" player doesn't receive money nor he loses money and the "Killer" is getting the money that I set it to be (say 100$)
Is there a way to set it like that ?

Hey, Sorry for the really long wait but this has been added in the latest update


Add support for PostgreSQL & PL/pgSQL syntax highlighting

Summary

Enables support for PostgreSQL & PL/pgSQL that is already supported on highlight.js library
Ticket Link

N/A
Related Pull Requests

Implemented following #5347
Screenshots

Thanks @ejose19 for your contribution! We will assign a Developer to review it. cc @hanzei

/update-branch

@bradjcoughlin friendly reminder to review this PR, thanks!

Thank you @ejose19
Highlighting looks great when using pqsql?
Quick follow up question:
Should the highlighting also apply when using postgresql and postgres?
Let me know. Thanks.

Hello @jgilliam17, I've tested it and here are my observations:
Highlighting works great, but there are 3 minor bugs that apparently are related to mattermost implementation (those don't show when using the library alone)

highlight breaks when using $anyword$ instead of $$

Using $$myfunc$$

Using $$

The opening $$ is adding a newline that shouldn't be there

Notice line 2, it's a single line taking 2 spaces

The closing $$ is taking away spaces between other words in the same line
( should be $$ LANGUAGE plpgsql )

I implemented it following https://github.com/highlightjs/highlight.js/blob/master/SUPPORTED_LANGUAGES.md which uses those 3 classes to apply the highlight. When testing in the browser just using the library alone, all 3 worked, but I'm not sure if it's because autodetection or indeed all 3 classes map to PostgreSQL syntax, perhaps we should only leave pgsql? Seems people will use it as it's shorter, the other option would be adding an alias for those 2.
Overall for people using postgresql it's great since highlight doesn't work on ```sql when using postgres keywords, so even with those small inconveniences the experience will be way better.

Thank you @ejose19 for a quick reply

When testing in the browser just using the library alone, all 3 worked, but I'm not sure if it's because autodetection or indeed all 3 classes map to PostgreSQL syntax, perhaps we should only leave pgsql? Seems people will use it as it's shorter, the other option would be adding an alias for those

Let me get some feedback from the dev team about this and also about the bugs you mentioned.

Thank you for your patience @ejose19
Can you please add aliases for postgres & postgresql, that way we would cover all the use cases.
As far as bugs are concerned, I'll create a follow up ticket to address those separately. Let me know if you have any questions or need more info.
Thank you again for your contribution 🙂

/update branch

/update-branch

@ejose19 can you please update the branch
I'm seeing a blank screen when opening the test server (I never tried updating before, no permissions I guess 🤔)

@jgilliam17 I'm also seeing that and was waiting for up to update to test

/update-branch

Ok, seems it's all good, all 3 works now.


ci: disable link check for doi.org

Attempts to mitigate https://github.com/celestiaorg/celestia-app/issues/1887

🤷♂ the links it claims are broken all seem to work fine. They're all relative to the data_structures.md page and link to other sections on the page.

Codecov Report

Merging #1965 (9069794) into main (2b74a9d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   21.34%   21.34%
=======================================
  Files         121      121
  Lines       13696    13696
=======================================
  Hits         2923     2923
  Misses      10485    10485
  Partials      288      288

It doesn't consistently for every subsection within the same file. Here it's able to actually find the link for example
https://github.com/celestiaorg/celestia-app/actions/runs/5316526912/jobs/9626144967?pr=1965#step:4:221

After merging in main, the most recent markdownlint ran successfully. See https://github.com/celestiaorg/celestia-app/actions/runs/5338755234/jobs/9676550256?pr=1965


use istiod flag to create istiod or Istiod-remote service

use istiod flag to create istiod or Istiod-remote service on remote cluster.  Believe the Istio-pilot service is gone in 1.6 now, so we can remove it.

@linsun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
f1c364f066d8888b2982753d445fe45bf6c59a78
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

I am a bit concerned this flag suddenly has a different meaning in remote case. If you are single cluster and say istiod.enabled=false then nothing happens, but if you are remote suddenly it changes the behavior which is confusing to me. Maybe it should be based on pilot.enabled - despite the name being legacy that actually controls if istiod is deployed or not

How confusing we are? I just realized we actually have istiod.enabled and pilot.enabled and I could have istiod.enabled but not pilot.enabled or istiod not enabled but pilot.enabled?

should we remove istiod.enabled now that rename has completed?  What value does it serve in 1.6+?

@howardjohn I've modified to pilot.enabled to be accurate.  PTAL and let me know any other comments you may have.

should we remove istiod.enabled now that rename has completed? What value does it serve in 1.6+?

I have been trying to get people to approve this for a while: https://github.com/istio/istio/pull/23355

should we remove istiod.enabled now that rename has completed? What value does it serve in 1.6+?

I have been trying to get people to approve this for a while: #23355

Ok great!  Sounds like folks are waiting to approve it till 1.6 is out.


Added note for debugging with serve configurations

Category

[x] Content fix
[ ] New article
Related issues: mentioned in #2140

What's in this Pull Request?
Added note for debugging with serve configurations as suggested in #2140 .

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/extensions/guidance/migrate-from-ecb-to-spfx-extensions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Chris, appreciated.


JSX transform incompatible with React 19

Describe the bug
According to React 19 documentation, React.createElement is not going to be supported anymore<EMAIL_ADDRESS>is still transforming its jsx using React.createElement instead of import { jsx } from 'react/jsx-runtime';
To be fair, React 19 is not out of canary status yet, but libraries should adapt prior to React 19 coming out of beta.
To Reproduce
I have not run the React 19 canary with react-datepicker yet. Going off of documentation, and react-datepicker build artefacts.

@pzaczkiewicz-athenahealth React-datepicker 7.3 is not React 19 compatible. My PR should fix this https://github.com/Hacker0x01/react-datepicker/pull/4979
I don't also see anywhere athat createElement is going to be deprecated https://react.dev/reference/react/createElement

Sorry, I meant to link the React documentation in my original post: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#installing.
What's confusing, is the React 19 canary doesn't appear to have the console.warn described in this documentation. Maybe React.createElement isn't going away with React 19, but the writing is on the wall that it will be deleted eventually.


Resources need the same restrictions that pointers have

Uniform validation requires knowing at compilation-time the bounds of resource arrays.

I don't remember what this means


Change to correct links

Switch repo links to https://github.com/Lea-fish/Leafish
Change reverse DNS schema to com.github.Lea-fish.Leafish

Closes https://github.com/Lea-fish/Leafish/issues/124.

Great... https://github.com/Lea-fish/Leafish/pull/129/checks?check_run_id=3556210574#step:4:34

Ha, fun. I suppose then you can just use com.github.Leafish.Leafish.


USGSws* Packages

Can we drop the USGSws* packages from here? There are still a lot of old instructions scattered about that tell people to install these packages. This can create a great deal of confusion for students when they are learning about dataRetrieval and the smwr* packages.

:+1: to minimizing confusion

No, it will cause other packages (rloadest, restrend and DVstats) to fail
if the user cannot load the USGSws... packages. I am working on getting
them updated. rloadest is now, but it takes time.
On Wed, Apr 1, 2015 at 3:11 PM, Jordan S Read<EMAIL_ADDRESS>wrote:

[image: :+1:] to minimizing confusion
—
Reply to this email directly or view it on GitHub
https://github.com/USGS-R/usgs-r.github.com/issues/47#issuecomment-88617517
.

Ah, ok. I'll leave this up here though. We will want to get that stuff down as those packages are updated.

I'd hope to get all caught up for R 3.2 so that the USGSws... packages will
not be supported for taht version.
On Wed, Apr 1, 2015 at 4:05 PM, Luke Winslow<EMAIL_ADDRESS>wrote:

Ah, ok. I'll leave this up here though. We will want to get that stuff
down as those packages are updated.
—
Reply to this email directly or view it on GitHub
https://github.com/USGS-R/usgs-r.github.com/issues/47#issuecomment-88631689
.


Back button behave weirdly when you open an internal asset

Reproduce: open http://moox.io/statinamic/, got to the video, click back. Good page is not restored...

Gonna comment it here https://github.com/MoOx/statinamic/commit/a707561a75bcd36852bb4ddd199e210164ca7370

This fix is a start, but not enough.

I think this will be fixed by #194

Fixed in #194


Searching for öüä saves suggestions with ??? sign instead of umlauts

When I m searching for words with umlauts. The word ist saved to the suggestinos list without umlauts but with questionsmarks instead of them

If this issue still applies, can you please open it on https://github.com/symbiote/silverstripe-extensible-search which will be the source of truth moving forwards.

If this issue still applies, can you please open it on https://github.com/symbiote/silverstripe-extensible-search which will be the source of truth moving forwards.


There are no screenshots for 4/8 in S3 for any state

http://covid-data-archive.s3-website.us-east-2.amazonaws.com/state_screenshots/

This has been fixed moving forward.


Sporadic Issue downloading drivers using AdminService

We're seeing a sporadic issue where devices hang on applying drivers during OSD.  Looking at the ApplyDriverPackage.log, the last entry in the log is "Starting package content download process (WinPE), this might take some time."  In the steps before, it properly identifies the driver package needed.  There is also a folder created under "C:_SMSTaskSequence\Packages" that matches the package ID for the driver pack.  However, the folder itself is empty.  If the same device with the issue is reimaged, sometimes it will download the package properly and image successfully.  Packages prior to the driver package download with no issues.  The issue doesn't seem to be model or driver package specific.
Outside of the ApplyDriverPackage.log, anywhere else to look to determine what the issue is?

Thank you for posting this Amg399, we're seeing the same thing where devices will just hang trying to download driver packages, then another deployment to the same machine works fine.  I've been trying look into Distribution Point issues, re-distributing driver packages, redistributing the MDM script package, etc., but I've been running in circles - it'll seem to be solved one day, then fail again the next.  I agree this doesn't seem to be specific to any make/model, although it seems to be more common for us with HP ZBook 14 G9's.  That could be simply because that's a very common model in our environment though.  I'm running ConfigMgr 2207 with Hotfix 15152495, and I'm one version back on the Invoke-CMApplyDriver Package script, which is 4.2.0, I believe..?

Glad I'm not the only one.   We're on 2203, using Invoke-CMApplyDriver Package script 4.2.1.  We recently switched from webservice to adminservice, and are noticing this now.  Packages are identical, and never had issues with driver packs downloading when on webservice.

It seemed that, at least for us, it may have started fairly soon after I upgraded to 2207, but I also added two new DPs right after that - so I was chasing multiple things that changed at the same time.  When we do see issues, it's consistently with driver packages - deployments to VMs always seem to work fine.  I was just assuming the driver packages had gotten corrupted when they were pushed/pulled out to the new DPs, but then we started seeing failures with packages that I had re-distributed, so I'm starting to rule that out.

Just figured out our issue.  The boundary group being used had three site servers associated with it.  Two of which shouldn't have been associated with the group.  Not sure why we were only seeing an issue with downloading driver packages, never seemed to be a problem with the webservice method.  Once we pulled those two servers out of the boundary group properties, the issue looks to be resolved.   That explained the randomness, as the client was most likely randomly pulling packages from one of the three sites associated with the boundary group, and two of which were problematic.

Very interesting, thank you for sharing your findings!  I will go back through my boundary groups and look for errors.   Thanks!


ecmaScript config can be strange

In tern file there is a new property confg.ecmaScript. In my case I don't use it and I set the well ecma version.
For instance I write this .tern-project :
{
  libs:["ecma5"]
}

But because of config.ecmaScript is set to true, ecma6 is added.
It should be cool if we could customize ecma, with libs :

if libs:["ecma5"] =>  config.ecmaVersion = 5
if libs:["ecma5", "ecma6"] =>  config.ecmaVersion = 6

We're defaulting to ES6 now (since it is backwards-compatible) and you have to explicitly set it to 5 to opt out. Including "ecmaScript: 5" is exactly as much work as explicitly loading the "ecma5" def (which would already be loaded by default), so I do not think this is a useful idea.

tern.java provides an UI to select tern plugins, and it's generic :

It adds in the libs field the selected plugins. So if I understand your comment, I must change my code for ecma and update the ecmaScript and not the libs.

Don't let the user choose the ecma* defs, just let them specify an ecmascript version and let the server's default behavior do the rest.

Ok thanks for your suggestion!

@marijnh IMHO I think there are more people which develop ES5 (and without ES6 modules). I think default config should be :
var defaultConfig = {
...
  ecmaScript: false,
  ecmaVersion: 5,
...
}

I'm afraid that tern users (like me) are lost with "es_modules" which doesn't use topScope (global scope).

That's a very good point, I actually didn't think the implications of enabling es_modules by default though. I've pushed a patch that fixes that (you have to explicitly enable ES6 modules if you want them).


fix: import paths weren't updated when moving options.ts

i did it boss, i fix the thing boss.

<3


"--require" does not honour "--compilers" file extension support

babel-register registers file extensions like ".es" and ".jsx". You cannot:
--compilers js:babel-register
--reporter mocha-multi
--reporter-options spec=-,xunit=./test-reports/file.xml
--require ./test/installDirtyChai

when installDirtyChai has a different extension: ./test/installDirtyChai.es

As far as I'm aware, --require just delegates to Node's require function, so this is unsurprising.
It might be nice to be able to load some compiled code before testing too, but I'm not sure off the top of my head what a good way to do it is.

@ScottFreeCode it does actually compile the code if you use ".js" files. But not in any of the other supported extensions.

It looks like https://github.com/mochajs/mocha/blob/master/bin/_mocha#L172 is hard-coded to only allow ".js" files rather than looking at "require.extensions" after the require hooks have loaded.

@graingert That code actually looks like it's trying to append .js to the required module name if it doesn't exist.

Well, --compilers js:babel-register means "compile .js files with babel-register", afaik.
So what if you did --compilers es:babel-register?
--compilers was intended for CoffeeScript really.  You can probably achieve what you want with --require babel-register --require ./test/installDirtyChai

Given require.extensions is deprecated, I'd probably avoid adding it.  If avoiding --compilers works for you, then I don't see a pressing reason to change this code.  It would be a good idea to update documentation.

@boneskull no, but changing the hardcoded ".js" to ".es" does work. This value should be direcly updated from "--compilers"


Release 4.9.0

No-Issue

There's a bunch of new files in CHANGES so you'll want redo the towncrier parts anyway, but also...
there is no AAH-3715 .. CHAGES/3715* was added in #3715 but I guess we should remove this from the changelog? (or figure out how to reference issues without jira).

Oh, and one more thing .. did we forget to clean up CHANGES/ on master after cutting 4.8? https://github.com/ansible/ansible-hub-ui/pull/3715 was already in 4.8.0 so it probably shouldn't even be in 4.9.0 changelog - guessing there may be more?

I might have forgotten about this. Also CHANGES.rst is missing 4.8.0 changes for some reason. I'll try to fix that


[Bug]: The database for applying for library permissions is not fully displayed

ODC version
odc431
OB version

What happened?

What did you expect to happen?
Display completely
How can we reproduce it (as minimally and precisely as possible)?
Select a project after entering the application library permission
Anything else we need to know?
No response

Fixed In Commit 4ea3890e386e41f9ca5742fd5069bef6392b0370
------
畅晚
Mon Jul 29 10:20:18 2024 +0800

The problem still exists

pass


Populate grpc hostname on heartbeat.

On a previous upgrade, new ingesters came up, added itself (with grpc hostname), but existing ingesters (who didn't know about this field) rewrote the ring on heartbeat, erasing the grpchostname.
This PR adds the grpc hostname to the ingester desc on heartbeat, to pave the way for removing the old http interface.

:+1:


Execution duration based tests may fail even when the tested code is correct

Tests based on execution duration may fail occasionally.
Let's consider two procedures (functions): A and B; and the case when the duration of A is less than duration of B: d(A) < d(B).
We cannot measure the duration d(A) and d(B) in the identical conditions, because the environment is not static (OS, other processes, etc.). In the real life we only measure duration d(A) + eps_A and d(B) + eps_B, where eps_* are random, so if we compare the measurements d(A) + eps_A < d(B) + eps_B, and the tested assumption is correct (d(A) < d(B) i.e. d(B) = d(A) + p, where p > 0) the test would fail if eps_A >= p + eps_B.
Therefore the following code is not correct:
https://github.com/NTAILab/bosk/blob/2cb191afda133c5a67c05e095759d9d8d2e90154/tests/comparison/comparison_test.py#L255

I totally agree that for the general task of performance measurements we should operate with some sort of statistics (mean values of times or more robust median), but for this particular test the conditions (i.e. the pipelines) were selected in such way that if the optimization is proceeded correctly, the assertion must be satisfied. For example, I've just run the test, and for my system optim_time is 0.25 s. and unoptim_time is 0.56 s. (the difference is more than twice!). I assume that the Optimization was useless assertion description is misleading, but the purpose of the test is to check whether the optimization mechamism works at all.
I prepare future pull request for the comparison subpackage, so I can handle this trouble myself. According to the above, there are several options I can offer:

Remove this assertion (but in this way I hardly understand how to easily perform the check of the optimization mechanism)
Replace the assertion description with the conscious one
Replace the system-wide timer with the one that counts the cpu-time to avoid some things that you described
Make experiment with several iterations and then count the mean time (but in this case this simple unit test will take much time)

What should I do?

First of all, I've opened this issue because the test failed on my laptop, so the bug is real and difference between these durations can have order of random measurements error.
From the other side, as you mentioned, this order is too large to be able to repeat test multiple times (even taking into account that it can be parallelized), and the test can't be considered as a classical (deterministic) unit test.
I think that the solution is to:

Replace time with some abstract metric of computational cost (e.g. in this case number of blocks to execute), if it is possible and easy to do;
Otherwise to replace total execution time with ticks count (prefer single-threaded blocks in a pipeline), if it is possible and easy to do;
Otherwise to remove this assertion, because when a test fail with a message like "Test can fail" it is hard to handle results.

Fixed this issue in the commit https://github.com/NTAILab/bosk/commit/ade53599dc11705c5bb01b96461469f58f05de01


docs: use QGB permalinks to appease markdown link check

Closes https://github.com/celestiaorg/celestia-app/issues/2749
Note: we've discussed avoiding backporting docs changes so we can close this PR if we're okay with markdown link check failing on the v1.x branch from now on.
Testing
On the v1.x branch, locally make markdown-link-check passes

We're currently processing your upload.  This comment will be updated when the results are available.

I think links to docs should use permalinks so that we don't break the links again due to a future rename or docs move. Also I think it's a bit confusing that the v1.x branch contains references to "qgb" and then links to "blobstream" docs. If we do that, we probably need to clarify the name change.

True, we're planning to write a small ADR around renaming so that it's more clear

IDK what to do for this PR but I don't think we should remain content with CI ❌ s on all future PRs to the v1.x branch. Three options I can see to get this moving forward (in order of preference from most preferred to least):

Remove the broken code links entirely
Replace the broken code links with permalinks to v1.x code
Replace the broken code links with permalinks to the same code on main. IMO confusing b/c the rename from QGB -> Blobstream which wasn't fully backported to v1.x

Ultimately I defer to you @SweeXordious b/c you're the primary owner on QGB docs


add missing dependency to build python-MySQLdb and add -y in freetype

on centos 7 Instalation fails without mysql_config which is provided by mariadb-devel package
this also adds missing -y

Thank you for this contribution! Sorry it took so long to test and commit.


Implement __array__ and __array_ufunc__ on itk.Image

Support direct use with NumPy while preserving metadata.
See pandas.Series, xarray (?), and work from @danielballan on Dask for reference.

That work is this documentation in numpy, which as of this writing is still a PR: https://github.com/numpy/numpy/pull/13979/files

__array__ added in #1158

References:

https://numpy.org/doc/stable/reference/ufuncs.html
https://numpy.org/doc/stable/reference/generated/numpy.ufunc.html#numpy.ufunc
https://numpy.org/neps/nep-0013-ufunc-overrides.html
https://numpy.org/doc/stable/reference/arrays.classes.html#numpy.class.__array_ufunc__
https://github.com/dask/dask/blob/7c419580037f552befc2650cb13967dd6bdef86a/dask/array/core.py#L1120-L1146
https://github.com/cupy/cupy/pull/1247/files

xref #4123


master broken for many arm boards

30529da0e4ab6ff967ccdd18dcae4f161de7be24 broke master for quite many arm boards.
See for example https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/17898/summary/console
Can be reproduced easily by running locally, for example:
sanitycheck -l -T tests/lib/sprintf/
96b_carbon                tests/lib/sprintf/libraries.libc                   FAILED: build_error
disco_l475_iot1           tests/lib/sprintf/libraries.libc                   FAILED: build_error
nucleo_f411re             tests/lib/sprintf/libraries.libc                   FAILED: build_error
nucleo_l476rg             tests/lib/sprintf/libraries.libc                   FAILED: build_error
stm32f411e_disco          tests/lib/sprintf/libraries.libc                   FAILED: build_error
nucleo_f412zg             tests/lib/sprintf/libraries.libc                   FAILED: build_error
nucleo_f429zi             tests/lib/sprintf/libraries.libc                   FAILED: build_error
nucleo_f401re             tests/lib/sprintf/libraries.libc                   FAILED: build_error
olimex_stm32_e407         tests/lib/sprintf/libraries.libc                   FAILED: build_error
olimex_stm32_h407         tests/lib/sprintf/libraries.libc                   FAILED: build_error
stm32f429i_disc1          tests/lib/sprintf/libraries.libc                   FAILED: build_error
olimex_stm32_p405         tests/lib/sprintf/libraries.libc                   FAILED: build_error
stm32f469i_disco          tests/lib/sprintf/libraries.libc                   FAILED: build_error
nucleo_f413zh             tests/lib/sprintf/libraries.libc                   FAILED: build_error
stm32f412g_disco          tests/lib/sprintf/libraries.libc                   FAILED: build_error
stm32f4_disco             tests/lib/sprintf/libraries.libc                   FAILED: build_error
nucleo_f446re             tests/lib/sprintf/libraries.libc                   FAILED: build_error
total complete:  102/ 102  100%  failed:   17
85 of 102 tests passed with 0 warnings in 141 seconds

CC @nashif

Same as #8593

Same as ...

@erwango : Uhm, ok, that one referred to another commit, and there does not seem to be an issue in 30529da0e4ab6ff967ccdd18dcae4f161de7be24^ == b312762

Working on it.

Closing since this is covered by #8593 & #8563


Provide a fallback provider for missing tile layer

Leaflet version : 1.2.0
More an improvement than a bug, but currently the fallback "errorTileUrl" for TileLayers only allows for an image to replace the missing tiles, but you can't request another provider for the tiles.
For instance, if I want to get tileLayers from my own server, but in case it's down, load google maps instead.
Here is what I wanted to achieve : https://jsfiddle.net/cLvcfw34/
As you can see, the parameters aren't replaced and therefore the fallback is failing.
I have slightly change the code to allow for another provider as a fallback (inspired by https://github.com/ghybs/Leaflet.TileLayer.Fallback) as follow :
I added in createTile function
tile._originalCoords = coords
And in replaced _tileOnError by:
`
_tileOnError: function (done, tile, e) {
	var errorUrl = this.options.errorTileUrl;
	if (errorUrl && tile.getAttribute('src') !== errorUrl) {
		//tile.src = errorUrl;
		this.setUrl(errorUrl)
		this.getTileUrl(tile._originalCoords)
	}
	done(e, tile);
}

`
As errorTileUrl is already used for image loading, would it might be useful to provide another option such as "fallbackUrl" for instance (and prevent for infinite looping if the fallback fail as well it should be replaced by errorUrl).
I hoped I did not miss something already in place. If you find this feature useful I can try to make a pull request.

Hi!
It looks like you already found @ghybs' fallback plugin - is there anything in particular that makes your suggested approach preferable compared to just using that plugin? In general, we try to keep Leaflet lean, and although I do understand your use case, I don't think it's that common, and better suited as a plugin than in Leaflet's core.
Also, a word of warning: using Google's tiles directly in a Leaflet map is a violation of Google's license, you need at least to use something like Google Mutant to display their tiles in Leaflet (although I wouldn't bet on the legality of even that).

Hi @MrSohey,
FWIW there is a fork of that plugin that sounds to do what you are looking for:
https://github.com/BenjaminVadant/Leaflet.TileLayer.Fallback

Plugin for Leaflet. Tries to load from another url if the first one is not available.

var myTileLayer = L.tileLayer.fallback([url,urlFallback], options);

I have not reviewed whether that fork works as advertised or not, neither how it avoid the infinite looping case you mentioned.
Since there seems to be at least 2 people needing this functionality, it might be interesting turning it into a proper Leaflet plugin.
Or the functionality could be merged into the original plugin, with a kind of configuration to say whether the fallback should use a different URL, or lower zoom.
Please feel free to submit a PR on https://github.com/ghybs/Leaflet.TileLayer.Fallback, I would be happy to review it and eventually to merge it.

Hi !
I have not seen the mentioned forked, I'll take a look at it !
I felt like the plugin was a bit too much code for a functionality that could be done with the addition of just a few liens of code, but I guess there might be more checking to do than I did (even though I mentioned it, I did not prevent infinite looping nor add a second fallback with an image). I'll try to tweak the plugin adequately :)
Thank you for the warning @perliedman, I did not know. I guess I'll switch to OSM then.

Hi. I stumbled over this old thread while searching for a solution to display tiles from a fallback source in case my free plan at stadiamaps runs out of credits. I see that https://github.com/ghybs/Leaflet.TileLayer.Fallback/pull/6 was closed and https://github.com/BenjaminVadant/Leaflet.TileLayer.Fallback mentioned above has been deleted.
I came up with the following solution, which works fine for me so far (had a bit of help from chatgpt tbh, since I'm not overly familiar with JS …). The idea is not to simply set the tile url as src, but to check the http status first. Setting the src to the base64 blob avoids requesting the image again in case of a success. A simple error event listener for the image element does not suffice, since 429 status codes from stadia are not treated as exception since stadia still returns a placeholeder image.

function setSrcWithStatusCheck(tile, url, fallback_url) {
    function setSrc(effective_url) {
        tile.src = effective_url;
    }

    // Make the request to fetch the image content
    fetch(url)
        .then(function (response) {
            if (!response.ok) {
                // Handle non-OK responses
                setSrc(fallback_url);
            } else {
                // Convert the image content to base64
                return response.blob();
            }
        })
        .then(function (blob) {
            return new Promise(function (resolve, reject) {
                var reader = new FileReader();
                reader.onloadend = function () {
                    resolve(reader.result);
                };
                reader.onerror = reject;
                reader.readAsDataURL(blob);
            });
        })
        .then(function (dataUrl) {
            // Set the source of the image using the base64 data URL
            setSrc(dataUrl);
        })
        .catch(function () {
            // Handle network errors
            setSrc(fallback_url);
        });
}

class Fallback extends L.TileLayer {
    constructor(urlTemplate, options, fallbackUrl) {
        super(urlTemplate, options);
        this.fallbackLayer = L.tileLayer(fallbackUrl, options);
    }

    createTile(coords, done) {
        const tile = super.createTile(coords, done);
        this.fallbackLayer._tileZoom = this._tileZoom;
        tile._originalCoords = coords;

        setSrcWithStatusCheck(tile, tile.src, this.fallbackLayer.getTileUrl(coords));

        return tile;
    }
}

Example usage:
const stamen_toner = new Fallback('https://tiles-eu.stadiamaps.com/tiles/stamen_toner_background/{z}/{x}/{y}.png', {
    minZoom: 1,
    maxZoom: 16,
    attribution: '© Stadia Maps © Stamen Design © OpenMapTiles © OpenStreetMap contributors',
}, 'https://tile.openstreetmap.org/{z}/{x}/{y}.png');

I don't have any ambitions on sending a PR or providing this as standalone package, just wanted to share this here in case someone ever finds it usefull :)


[WIP] Move VM 1.5

[ ] Update move and pont libs to the latest one.
[ ] Update VM to the latest after move and pont libs merge.
[ ] Need to fix package modules ordering in dove.
[ ] Migration to dove 1.5.2
[ ] Benchmarks are buildings/working, need to fix after VM and lib stabilized.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.226%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
96

Relevant Lines:
169

💛  - Coveralls


Beta release

First beta 🎂 🥳 🎉

Codecov Report

:exclamation: No coverage uploaded for pull request base (beta@1aa5051). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             beta     #546   +/-   ##
=======================================
  Coverage        ?   29.78%
=======================================
  Files           ?       88
  Lines           ?    10425
  Branches        ?        0
=======================================
  Hits            ?     3105
  Misses          ?     7029
  Partials        ?      291

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Automatically extracting data from form

Hi,
When developing a theme, you cannot know in advance which properties a product have. As a consequence, this:
CartJS.addItem(12345678, 3, {
        "size": "XL"
    });

Is not possible because we cannot know that it will have the "size" property. The problem is that jQuery does not have any nice built-in function to extract the data from a form in a way that is easily consumed by CartJS. Here is the boilerplate code I've been doing:
var formData = this.serializeForm(this.element.find('.product__form'));
CartJS.addItem(formData['id'], formData['quantity'], formData['properties'], {});

where serializeForm is as follow:
Plugin.prototype.serializeForm = function(form) {
    var hash = {};

    function stringKey(key, value) {
      var beginBracket = key.lastIndexOf('[');
      if (beginBracket == -1) {
        var hash = {};
        hash[key] = value;
        return hash;
      }
      var newKey = key.substr(0, beginBracket),
        newValue = {};
      newValue[key.substring(beginBracket + 1, key.length - 1)] = value;

      return stringKey(newKey, newValue);
    }

    var els = form.find(':input').get();

    $.each(els, function() {
      if (this.name && !this.disabled && (this.checked || /select|textarea/i.test(this.nodeName) || /hidden|text|search|tel|url|email|password|datetime|date|month|week|time|datetime-local|number|range|color/i.test(this.type))) {
        var val = $(this).val();
        $.extend(true, hash, stringKey(this.name, val));
      }
    });

    return hash;
  },

I'm not the author of this complicated code, but basically, it allows to parse the keys (such as "properties[foo]") and returns something like:
{
   "id": 123,
   "quantity": 1,
   "properties": {
     "size": "XL",
     "other": "foo"
   }
}

This boilerplate code is required all the time in themes. Therefore, it would be nice to have a "addItemFromForm" method that would accept any jQuery object representing a form, and do this logic internally.
I'd be happy to contribute for that, I just want to be sure you don't have a better idea for that first ;).
Bye!

Is there any reason adding a data-cart-submit attribute to the form in question wouldn't work for this use case? (Docs).

Actually I often need to do more than just submitting, like changing the button of the add to cart button, displaying "success" message... The data-cart-submit does not offer this flexibility.

Okay, fair enough. There is already the required logic inside the data-cart-submit functionality, I can look to pull it out and make it publicly accessible.

@bakura10 I have a branch to resolve this: https://github.com/discolabs/cartjs/tree/36_form.
It will add two public methods:
/**
 * Expect a DOM form object.
 * Returns an array of [id, quantity, properties] extracted from the form.
  */
CartJS.extractForm(form) {
  ...
}

/**
 * Expect a DOM form object.
 * Uses extractForm() to attempt to parse an item to add from the form and then adds it.
  */
CartJS.addItemFromForm(form) {
  ...
}

Does this look like it would solve your use case?

Perfect, that would solve it like a charm!

OK, great. I'll try to find some time to add tests and then merge.

Any news about tagging this? :)

Unfortunately I haven't had much time to work on Cart.js of late. That'll hopefully change later in the year.
In the meantime, if this is something you really need, happy to look at any PR adding tests to the above branch.


METRON-1462: Separate ES and Kibana from Metron Mpack

Contributor Comments
https://issues.apache.org/jira/browse/METRON-1462
This splits ES and Kibana into their own MPacks. Two comments for reviewers:

The original discuss thread mentioned putting this in metron-contrib.
I kept the Kibana templates and associated documentation in their current location and migrated them with the Kibana service. This is consistent with our current deployment and means we don't need to add a new set of features to the Metron MPack to publish them. A point in favor of moving this to Metron's MPack would be that we think this is in the purview of Metron and would make the Ambari design more consistent when we introduce Solr.

Testing
Spin up full dev and verify the Kibana dashboard is displaying information.
Pull Request Checklist
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

I think I mentioned contrib.  They don't have to go in contrib, I think at the time someone mentioned not wanting to maintain them.. If we don't then I thought contrib would make sense.
We can keep them normal.
Metron installation artifacts ( templates, schemas, kibana objects, queries, and dashboards ) should be managed separate from the kibana / es / solr /  packs.
They are artifacts of metron and we need to support installing them on existing installations.
If they need to be installed in a different phase, or as their own component, then fine.
we need to break that down more anyway ( like package the 'demo' system + parser configs as optional ) maybe.

+1
Works as advertised. I used both mpacks to deploy a 12-node CentOS 7 cluster (Ambari <IP_ADDRESS> and HDP <IP_ADDRESS>). Was able to kerberize the cluster and get bro indices into ES.

I spun this up in full dev and everything worked as expected.  The organization looks good to me and I can't find anything wrong with it.  +1

What about upgrading.md?

@ottobackwards I believe the repercussions are the same as they are for the existing MPack since the services are distinct from the MPack itself. We should probably consider a separate test for this.

Also, I will look at moving the Kibana templates to Metron as this is something that will need to be done for Solr as well.


How do I make Slash Commands appear?

I'm trying to make my bot automatically create a slash command for every normal command it has, and for the most part, that is working fine. But, I have a question.
The first one is that even after I create the slash command, it doesn't show in the slash menu. I know it is there, if I tell my bot to reply with all slash commands I can see they are there, but when I type "/", all I can see are the built-in commands, and slash commands from other bots. Anything I should do for that?
Here is my code. I am using the latest Discord.Net.Labs
static void PropertiesApproach(CommandService cmds)
            {
                foreach (CommandInfo cmd in cmds.Commands)
                {
                    SlashCommandCreationProperties b = new()
                    {
                        Description = cmd.Summary,
                        Name = cmd.Name,
                        Options = new(new()),
                    };

                    if (cmd.Summary.Length > 100) b.Description = cmd.Summary.Remove(97) + "...";

                    foreach (ParameterInfo param in cmd.Parameters)
                    {
                        ApplicationCommandOptionProperties o = new()
                        {
                            Description = param.Summary,
                            Name = param.Name,
                            Required = !param.IsOptional,
                            Type = ApplicationCommandOptionType.String,
                        };

                        if (param.Summary.Length > 100) o.Description = cmd.Summary.Remove(97) + "...";

                        if (param.Type == typeof(int) || param.Type == typeof(ulong) || param.Type == typeof(float)) o.Type = ApplicationCommandOptionType.Integer;
                        else if (param.Type == typeof(bool)) o.Type = ApplicationCommandOptionType.Boolean;
                        else if (param.Type == typeof(IUser)) o.Type = ApplicationCommandOptionType.User;
                        else if (param.Type == typeof(IChannel)) o.Type = ApplicationCommandOptionType.Channel;
                        else if (param.Type == typeof(IRole)) o.Type = ApplicationCommandOptionType.Role;

                        b.Options.Value.Add(o);
                    }

                    Internals.client.Rest.CreateGlobalCommand(b);
                }
            }

any answer would be appreciated, thanks

Global slash commands can take up to 1 hour to reach all of the servers the bot/application is in.

This limit is set by Discord.

ok


Bold in death messages

Hi, this error apparently is implemented with the arrival of /toggle, I see the death of all messages in bold, not just mine.

It work on bold when you are in the event. Try to get 2 friends, then one of him kill the other. You will se it with normal characters. If not, is an error.