Not able to create component in the terminal

Describe the bug
I was following through the steps to create a component (https://angular.io/start) by opening new terminal and it through an error:
~/projects/mr36pi--run
❯ ng generate component product-alerts
An unhandled exception occurred: Cannot set property global of # which has only a getter
See "/tmp/ng-lYupLT/angular-errors.log" for further details.
Link to the blitz that caused the error
https://stackblitz.com/run?file=src%2Fapp%2Fproduct-list%2Fproduct-list.component.ts
Steps to reproduce
Open new terminal in the project.
run "ng generate component product-alerts"
Expected behavior
Should generate a component
Parity with Local

[ ] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Browser name  = Chrome
Full version  = 98.0.4758.80
Major version = 98
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.80 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 96834451,
  "usedJSHeapSize": 92993967,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = d64d45524a435df425e7813603b52872ecfbe08e

Additional context
No response

Duplicate of https://github.com/stackblitz/webcontainer-core/issues/604


Implement EEPROM helpers to read/write buffers

This is a stripped-down version of #125 that ended up being "the simplest thing that could possibly work" for the project I was working on.
What I really wanted was an easy way to read and write structs in/out of EEPROM. The filesystem approach introduced a lot of extra complexity and an abstraction layer that leaked pretty badly in pathological cases.
I'd like to take another swing at the filesystem approach because I think it's clever and useful, but I need to write better tests for it and solve for some edge-cases before I'd call it "shippable".

My take on this is that removing the stdio integration from #125 is probably the best overall solution. We still get most of the benefits of the filesystem implementation like static declaration of files, checksums, etc. but just with functions to read/write each file in a single go.
The stdio integration is the part that was raising more concerns because it's hard to really simulate a full file system over a small EEPROM.

Closing in favor of https://github.com/DragonMinded/libdragon/pull/125


Remove hot issues word cloud

Closes #122.
A nice side-effect is that loading /hot-issues now takes only ~200 ms on my laptop, down from 1200 ms.

Thanks! I'll make a TODO for myself to deploy soon.

Finally deployed this! Thanks again!


Lab 04 / Practice 3 / Task 1 / Step 20 , Current directory is not correct.

Module: 04
Practice: 2
Task: 1
Step: 20
Wrong: 将当前目录设置为“AdventureWorks”
Correct: 将当前目录设置为“AdventureWorks.Context”

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team


Apply spotless on whole project and get rid of ratchet

Currently, we only apply spotless check on files that are touched only by the PR. The goal of this was to maintain git history.
However, I think we should just make one large spotless apply commit (as suggested here https://github.com/opensearch-project/k-NN/pull/328#discussion_r836714040) so that PRs dont contain changes unrelated to the PRs.
What are your thoughts @VijayanB @martin-gaievski ?

I agree with one time change.
How about the process after that bulky change? I vote for applying - "you touched it you own it" approach, so whatever code affected by change in PR must be addressed by author either in that PR (preferable way) or in second PR coming soon after (if bundling both changes are making PR to big/complex for review or anything like that). I think it should work with or without the "ratchet from"

@martin-gaievski I somewhat agree with the touched it you own it approach. However, if something is pointed out that would take weeks to fix, I dont think it is the person who submitted the PRs responsibility for fixing it. I think the person should be responsible for creating the issue to track it and then it should be assigned from there. Also, it is harder to enforce this across multiple PRs with external contributors.
If they are small changes that are close (i.e. same method, pulling out duplicate code into helper methods) to the changes of the code, I think it is reasonable to fix it within that PR.
Note Once the big spotless PR is applied, ratchet from will not be needed because all files will be compliant.

IMO, every commit should leave the repository in better place than before. I will still recommend refactor before add new feature if author is planning to update existing method/class to an extent that doesn't require design change.

I'm not sure it's always possible to foresee such refactoring tasks before doing actual change in logic/adding feature etc. It's pretty often comes up in the middle of PR or after review comments, and I was referring to that type of changes in my original comment. I agree on making refactoring beforehand if that is something we can plan


About vtransfrom

in vtransforms/base.py: 269
on_img = (
(cur_coords[..., 0] < self.image_size[0])
& (cur_coords[..., 0] >= 0)
& (cur_coords[..., 1] < self.image_size[1])
& (cur_coords[..., 1] >= 0)
it seems points with negtive depth(behind camera) will also be treated as on image?

in vtransforms/base.py: 258
cur_coords[:, 2, :] = torch.clamp(cur_coords[:, 2, :], 1e-5, 1e5)
cur_coords[:, :2, :] /= cur_coords[:, 2:3, :]
negtive depth is clamp to 1e-5, so negtive depth would leads to a very large xy cord, which would out of image
issue solved, i will close it


Truffle integration

Sorry if this issue has already been raised or discussed before.
We use both truffle and solium for our project but have to run the linter separately before pushing.
@duaraghav8 any chance you can integrate solium into truffle so we don't have to install or run anything seperetely? The lint output can be given as part of truffle compile
cc @gnidan

@Mridhul40 agreed, faced this problem myself.
@gnidan would you be interested in a solium integration? Since the linter comes as a js library, its easily pluggable. I could find time to submit a PR


Unable to update k8s on Imported AKS cluster when using Location other than eastus

Rancher Server Setup

Rancher version: rancher/rancher:master-head cf5a75f
Installation option (Docker install/Helm Chart): any
Proxy/Cert Details: -

Information about the Cluster

Kubernetes version: any AKS k8s
Cluster Type (Local/Downstream): custom local, Imported AKS (default values but region changed to westeurope)

Describe the bug
When MS Kubernetes services aka AKS is deployed from Azure Portal UI in different Location than eastus (eg to existing  Resource Group in westeurope location the cluster cannot be updated to newer k8s over rancher due problem with hardcoded location. On attempt to update from rancher the status of the cluster is Updating with following Error message:
Failed to update cluster: containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="InvalidResourceLocation" Message="The resource 'thehejik-aks-forimport' already exists in location 'westeurope' in resource group 'thehejik-rancher'. A resource with the same name cannot be created in location 'eastus'. Please select a new resource name."
Problem is that Location field when doing Edit Cluster is probably hardcoded to eastus value, it's inactive and cannot be changed:

To Reproduce

deploy a AKS in Azure Portal in different Location than eastus - I was deploying into my own Resource Group assigned to westeurope location
Import the AKS cluster into Rancher
Once the cluster is Active perform Edit Cluster, change k8s version and Apply

Result
Update will fail with the error message above.
Other info
The same works ok for Hosted AKS

Backend PR merged, will be ready to test when UI issue https://github.com/rancher/rancher/issues/33540 is complete

Tested on rancher/rancher:master-head e83ac8c with rancher/aks-operator:v1.0.1-rc15
The location is now correctly fetched for the imported AKS server living in norwayeast azure location on attempt to update the cluster from rancher.

But in later phase of update it failed on https://github.com/rancher/rancher/issues/33536
Anyway this seems to be fixed as well as #33540
Close.


Update prod and staging database setting for WA.

In ticket 4878 update schema for WA to suppress OBX-2-3,3, OBX-11-2,3, and OBR-25-2,3 instead of suppressing them in the code.  Therefore, we need to remove those fields in the suppressHl7Fields from the prod/stage database setting.

Prod and staging database setting update is completed 2022-04-05 @10:51 AM.


System Status: Add links to metrics dashboard to status page

system status will be sunset with dcp 1 not required


The ocean diagnostics package is not sufficiently documented,

Just writing a note to myself that the ocean diagnostics package is not sufficiently documented.
Please add a README file which includes:

a summary of the contents of this toolkit
instructions on how to use them,
A list of recipes which use these tools,
A user friendly documentation about how to write a ocean diagnostic recipe.

Good point, but rather than a README file I would suggest using sphinx.
In this way, the documentation will be part of the ESMValTool User Guide.
See the examples from v1 here.

Sorry, I've just noticed that there is already an example in the version2 documentation.

Please put documentation in the doc folder instead of with the code.

Okay, that's a good plan, I'll make sure it get moved there before a PR. However, I want to make sure that the documentation is also available in the ocean diagnostic tool. Can git handle internal symbolic links, or should I just describe where to find the documentation in a readme?
Also, is there a way to include figures in the documentation? I guess we don't want to carry about too many images around with the main git repository, but they would still be useful somewhere in the documentation.

The advantage of putting the documentation in the doc folder is that it will become available on the website with esmvaltool documentation, see e.g. the perfmetrics recipe documentation, which much more visible than somewhere burried inside your code. Indeed you can add figures in doc/sphinx/source/recipes/figures/, though you're right that this might make the repository rather large. I suggested a possible solution for that in #670, I think that could also work for figures.

Thanks for the pointers. The perfmetrics documentation is (alone) in a recipes section. In the case of the ocean diagnostics toolkit, I feel that it would be better to document the diagnostics than the recipes. The thinking behind this choice is that the oceans toolkit are generic tools to evaluate a wide range ofbehaviour in the ocean models.
I was planning to put my documentation under the "Diagnostic scripts" on the readthedocs page, then link to it again on the diagnostics packages page. Is that sensible?
Also, I want to make sure that my .rst code works on my branch before making a PR. Is there any way that I can test my documentation from my branch on readthedocs?
Sorry to ask seemingly obvious questions, but I don't want to be in the situation where I do a bunch of work, then it turns out to be the wrong way to do documentation.
Cheers!

You can build the documentation locally by running python setup.py build_sphinx, this command is only available if you have installed the required dependencies, you can do that by installing esmvaltool with the command pip install -e .[develop]. Make sure you fix all sphinx errors/warnings. You can then view the documentation you've just built with firefox doc/sphinx/build/html/index.html.
Maybe @mattiarighi can comment on what to put in which chapter?

It depends a bit on what you want to explain what the best approach is. If you just want to document how your functions work, the documentation extracted from the code is great and you can add your ocean module in the 'SMValTool Code API Documentation' chapter, either under 'Shared diagnostic script code' or under 'Diagnostic scripts'.
If in addition to that, you want to write more of a tutorial with figures and user friendly explanations, it would probably be good to add a Diagnostics section, similar to the Recipes section. Here is a good example of software documentation where they have both sections with nice tutorials e.g.  https://rasterio.readthedocs.io/en/latest/quickstart.html, https://rasterio.readthedocs.io/en/latest/topics/index.html and API documentation https://rasterio.readthedocs.io/en/latest/api/index.html.

I would suggest to follow the strategy of v1 and document the diagnostic on a recipe basis.
See the current documentation here.

I've added several images to the documentation of the ocean diagnostics but haven't done a git add & git commit yet. I'd like to add more, but the images already contribute close to 1MB. How much is too much?

Also, should I add a watermark to the figure before putting them in the git repository?


v0.0.7

Codecov Report

Merging #4 (fd75076) into master (756f640) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          163       164    +1
=========================================
+ Hits           163       164    +1

Impacted Files
Coverage Δ

guardpost/common.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756f640...fd75076. Read the comment docs.

Codecov Report

Merging #4 (fd75076) into master (756f640) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          163       164    +1
=========================================
+ Hits           163       164    +1

Impacted Files
Coverage Δ

guardpost/common.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756f640...fd75076. Read the comment docs.


added js file to dir

Able to merge, pull request created.

No conflicts with the base branch, pull request merged.


Version Bump

:sparkles: No lint errors found. :sparkles:

:sparkles: No lint errors found. :sparkles:

:+1:


Remove MBEDTLS_TEST_NULL_ENTROPY config option.

resolves #4388

Fixed typos and alignment in migration file

I am not competent to assert the proposed migration path but I count on @mpg for that. LGTM otherwise.

Thanks. Actually me neither, I used what chris proposed in #4388 description.


startOfDay returning incorrect value?

I live in a UTC + 2 timezone.
When calling DateTime.now().startOfDay I get:
Fri, 24 Jul 2020 00:00:00 UTC
Shouldn't the call to DateTime.now().startOfDay.local return:
Thu, 23 Jul 2020 22:00:00 GMT+0200?
It currently returns:
Fri, 24 Jul 2020 02:00:00 GMT+0200

@webfrea-k @soywiz
I think it shouldn't return 2200. When you have midnight at UTC, you have 2am at GMT+2 (the night just comes earlier to GMT+2 because it's closer to the east 😅).
I've also checked this at https://www.thetimezoneconverter.com/:

Finally, this is not related to startOfDay, for me even strict dates work the same way:
val a = DateTime(2021, 4, 14)
val b = a.local

println(a)  // Wed, 14 Apr 2021 00:00:00 UTC
println(b)  // Wed, 14 Apr 2021 03:00:00 GMT+0300

So I guess this issue can be closed.

Looks correct. I don't remember the case I was faced with back when I opened the issue, but the above makes sense @SerVB . Closing the issue.


move dataset specific scripts into subdirs

Coverage decreased (-0.3%) to 95.789% when pulling d1b4a4158e32ffa8a791d43dc096a4d7ca45dc9d on kashefy:dataset_subdirs into 6cb609ad129da900bec5a070e1a61ff99baf24c0 on nigroup:master.


Set jvm options to each components

sir, i have an questions to ask.
when i setting jvm options in pulsar_env.sh
for example:
# Extra options to be passed to the jvm
PULSAR_MEM=${PULSAR_MEM:-"-Xms4g -Xmx4g -XX:MaxDirectMemorySize=4g"}

Is that means  4g memory allocated for each components.
In my case, a node with 8G memory and there are zookeeper\bookie\broker on it.
So i think 8G is not enough...
Please tell me if i have the wrong idea, or can i set jvm options for singel components.
Thank you very much!

You should configure PULSAR_MEM to allocate memory for running Pulsar components.

It is recommended to configure -Xms to equal to -Xmx, so that JVM can allocate the whole heap memory during initialization.
Since Pulsar uses direct memory extensively, you should make sure allocating enough directory memory for JVM. It is recommended to configure -XX:MaxDirectMemorySize to be twice of -Xmx.
Make sure the total size of JVM heap and direct memory does NOT exceed the total available memory on your machine. It is also recommended to leave at least 1~2 GB for your operating system.

Let’s use a 8GB machine as an example, you can configure your maximum heap memory to be 2GB, directory memory to be 4GB and leave the remaining 2GB for your operating system. So your PULSAR_MEM will be:
-Xms2g -Xmx2g -XX:MaxDirectMemorySize=4g

@wenjun8888 Can you check @wolfstudy 's question?

ping @wenjun8888 , will close this issue, If you have any questions about this, please reopen it or let me know, thanks.


ollama run gemma:2b error

Error: Unable to load dynamic library: Unable to load dynamic server library: �Ҳ���ָ����ģ�顣

Same here i got this error in the logs
msg="Failed to load dynamic library /tmp/ollama136388332/cpu_avx2/libext_server.so  exception std::bad_alloc"

Hi, gemma requires ollama >=0.1.26, you can  check your ollama version using ollama --version.

@Howe829 Hi,I have 0.1.28 version

@cinnamon17 It seems there is a problem with loading OLLAMA Library.You can check this Markdown for more information troubleshooting

Hi @pythonHuang does this only occur with gemma:2b, or other models as well? Sorry this happened

I got the same error while trying to use wizardlm2:8x22b-q4_0:
llm_load_tensors: ggml ctx size =    0.22 MiB
llama_model_load: error loading model: create_tensor: tensor 'blk.0.ffn_gate.0.weight' not found
llama_load_model_from_file: exception loading model
time=2024-04-16T02:36:23.822Z level=WARN source=llm.go:170 msg="Failed to load dynamic library /tmp/ollama1100549038/runners/cpu_avx2/libext_server.so  exception create_tensor: tensor 'blk.0.ffn_gate.0.weight' not found"


Project-level config prettier-plugin-sql

Is there a way to specify a project-level config for prettier-plugin-sql via a .prettierrc? It seems that configuration only works via VSCode's settings.

It looks like that .prettierrc configure works if you use esbenp.prettier-vscode and installed prettier-plugin-sql in your project.


Is use of saltwater_internal_rst broken?

A user had a set of restarts that included saltwater_internal_rst and was reporting a crash. A brief investigation shows that indeed with the 1.3.11 version of GEOSgcm_App used by v10.17 of the GEOSgcm fixture, that the use of the saltwater_internal_rst appears to be broken.
The issue is that the gcm_run.j script never copies it to scratch so it can't get split...
I verified that if I added a copy of saltwater_internal_rst to scratch the splitter seemed to work fine and the model ran without incident.
Looking at the gcm_run.j script it looks like it gets the list of restarts to copy over by looking for _RESTART_FILE in the AGCM.rc. I'm wondering if even after we went to the split saltwater we kept saltwater_internal_rst in the AGCM.rc file so it would be copied if it existed? Maybe we removed this with unintended consequences? I can't really think of how else this would have worked in the past. Perhaps we need a manual check for saltwater_internal_rst?
Or remove the splitter logic if we don't support that but I'm assuming we still want to?

The answer is...yes it looks like. I strolled around the GitHub history and found this:
https://github.com/GEOS-ESM/GEOSgcm_App/commit/01486eb256239d3370764370211011c8777c342a
In that commit @sanAkel says:

Replace EXPDIR with SCRDIR for EMIP to work as well.

So I guess we fixed the EMIP but had the side effect of breaking the AMIP. I think back in the CVS days when this change occurred @lltakacs and I figured that the only thing that mattered was that the $SCRDIR had openwater_internal_rst and seaicethermo_internal_rst. I think that's why saltwater_internal_rst was removed from AGCM.rc.tmpl because it isn't required (or wanted) anymore.
Thus these lines:
if ( ( -e $EXPDIR/saltwater_internal_rst ) && ( $counter == 1 ) ) then

   # The splitter script requires an OutData directory
   # -------------------------------------------------
   if (! -d OutData ) mkdir -p OutData

   # Run the script
   # --------------
   $RUN_CMD 1 $GEOSBIN/SaltIntSplitter tile.data $EXPDIR/saltwater_internal_rst

   # Move restarts
   # -------------
   /bin/mv OutData/openwater_internal_rst OutData/seaicethermo_internal_rst .

worked because we ran SaltIntSplitter from $SCRDIR on the restarts in $EXPDIR. The splitter ran and its output was in OutData and we moved the openwater_internal_rst and seaicethermo_internal_rst to . which is $SCRDIR at this point. And after that, GEOSgcm.x would never make a saltwater_internal_rst and we'd be fine.
But apparently this was not good for EMIPs with a saltwater_internal_rst. I'm thinking our best strategy might be to have something like:
if ( (-e $SCRDIR/openwater_internal_rst) && (-e $SCRDIR/seaicethermo_internal_rst)) then
  echo "Saltwater internal state is already split, good to go!"
else
 if ( ( ( -e $SCRDIR/saltwater_internal_rst ) || ( -e $EXPDIR/saltwater_internal_rst) ) && ( $counter == 1 ) ) then

   if ( -e $EXPDIR/saltwater_internal_rst) cp $EXPDIR/saltwater_internal_rst .

   # The splitter script requires an OutData directory
   # -------------------------------------------------
   if (! -d OutData ) mkdir -p OutData

   # Run the script
   # --------------
   $RUN_CMD 1 $GEOSBIN/SaltIntSplitter tile.data $SCRDIR/saltwater_internal_rst

That is, test if you have saltwater_internal in $SCRDIR or in $EXPDIR and if it's in $EXPDIR copy into $SCRDIR.
I'll work on testing this and getting it working.

@mathomp4 that modification o logic for EMIP to work was worked out with @sdrabenh. He already had the split internal states, yet the script was looking was saltwater internal restart.
Our first (original) fix was for $SCRATCH set up when @yvikhlya was inadvertently using a salt water internal over and again in the middle of a long climate run: shocking it!
Maybe this is for later. How difficult is it generate a list of restarts? That works for all instances of the GCM?

The model does not need saltwater_internal_rst since long ago. If somebody wants to run with old saltwater internal restart, they need to convert it to open_water and seaice_thermo. This is a pre-processing step which needs to be done once. I don't really understand why this logic was put into a run script. Do we really need to do it every time we submit gcm_run.j?

@yvikhlya It was for convenience during the days of the split transition. But, as a user found out just a couple days ago, some want to use old restarts that while old, are still "valid" for the boundary conditions being used.
The reason we never saw this until this is that regrid.pl autosplits MERRA-2 now, so anyone regridding new restarts is safe.
Luckily, 99%+ of all users will be in the first "openwater and seaicethermo" exist case.


Play specific songs when using a mount

Have some way of choosing songs to play only when certain mounts are used (a way of not listening to ''The Rider's Boon'' on an Ozma for example, and switching to your own theme or BA theme) without need open manually every time.

Please note that this repository for the plugin is not being maintained, and this issues page is not monitored. Issues should be brought up here: https://github.com/lmcintyre/OrchestrionPlugin
This feature was added with <IP_ADDRESS>.


(format) Problem: xxx

screenshot: (as u want)
description: xxx
how to happen: xxx
email: xxx

format！


WIP: test for user service

#32

Current coverage is 68.13% (diff: 87.23%)

No coverage report found for master at cb950f7.

Powered by Codecov. Last update cb950f7...8be3297

@Sneezoo some of the reasons for the changes to Promise stuff are in the commit messages, but to pull it out here for clarity:

They were not testable. Probably $httpBackend.flush() does not resolve the
Promises, unless they are derived from Angulars' $q object. Removing
them for now because they are not needed.

What is the rationale for having both the user wrapper service and the user communication service? The wrapper service just passes everything through.

It looks to me like removing the wrapper is ok for now. The functions have the same signature as the functions they call, so actually adding the wrapper back in later seems to be easily possible.


[Court] Delegation modal allows to select to delegator

This results in me being able to sign a transaction that we know ahead of time will fail.

Dont understand this isse

Sorry, my bad. It was supposed tosay "the delegation modal allows to select no delegatee". So I'm able to push the button which makes me sign the transaction without selecting any delegatee. Which will definitely result in a failure.

This should be fixed. no build ready to test yet though


Ask: can i run dep-scan to generate SBOM only

Hi.
I am using dep-scan in my Jenkins Pipeline, Can I just generate SBOM of dependency without parsing, to reduce pipeline time

@ngocnn97 dep-scan internally uses my other project called cdxgen so best to invoke that directly.
https://github.com/CycloneDX/cdxgen

Thanks you !


Fail to receive binary message

I have a similar problem as https://github.com/socketio/socket.io-client-cpp/issues/287 says when receiving the binary message from my server. It fails to parse binary payload, and raises an error  terminating with uncaught exception of type std::invalid_argument: stoi: no conversion.
My case is that somehow the payload in packet_manager::put_payload function from sio_packet.cpp doesn't have any 'prefix' or 'frame', which means payload[0] is not a digit and thus packet::is_binary_message(payload) (https://github.com/socketio/socket.io-client-cpp/blob/master/src/internal/sio_packet.cpp#L485 ) return a false. This is also why stoi leads to an error.
I have a quick patch for my issue. Hope it helps.
diff --git a/src/internal/sio_packet.cpp b/src/internal/sio_packet.cpp
index 4b81098..4b2e475 100755
--- a/src/internal/sio_packet.cpp
+++ b/src/internal/sio_packet.cpp
@@ -246,7 +246,6 @@ namespace sio
     bool packet::parse_buffer(const string &buf_payload)
     {
         if (_pending_buffers > 0) {
-            assert(is_binary_message(buf_payload));//this is ensured by outside.
             _buffers.push_back(std::make_shared<string>(buf_payload.data(),buf_payload.size()));
             _pending_buffers--;
             if (_pending_buffers == 0) {
@@ -482,7 +481,7 @@ namespace sio
                     break;
                 }
             }
-            else if(packet::is_binary_message(payload))
+            else if(packet::is_binary_message(payload) || (m_partial_packet && !isdigit(payload[0])))
             {
                 if(m_partial_packet)
                 {

I have the same issue

I have the same issue

I have stopped using cppclient for a while, but it seems my fix works fine for my cases. Maybe you can have a try?

yes your patch works fine for me :+1:

I'm currently having the same problem in the latest version of the lib. Sending a binary message from C++ to a NodeJS works fine, but when receiving it (even without handlers), it crashes on std::stoi (from what I can tell, it passes an empty string).

I'm currently having the same problem in the latest version of the lib. Sending a binary message from C++ to a NodeJS works fine, but when receiving it (even without handlers), it crashes on std::stoi (from what I can tell, it passes an empty string).

have you found a fix, i have the same error

I'm currently having the same problem in the latest version of the lib. Sending a binary message from C++ to a NodeJS works fine, but when receiving it (even without handlers), it crashes on std::stoi (from what I can tell, it passes an empty string).

have you found a fix, i have the same error

I think I just implemented the fix proposed by OP... Not sure if I've done anything else.


[FEATURE] Dual control in Opensearch and Opensearch Dashboards

Is your feature request related to a problem?
There is a security requirement for supporting dual control.
What solution would you like?
`Explanation - Separation of duties may be also achieved by dual control, in which carrying out a single task requires approval of two authorized persons.
Here as far as I know separation of duties can be achieved via Roles. Additionally is there any plan to support dual control in Opensearch where a critical task requires approval of two authorized persons?`

@chaitrahegde115 Thanks for creating this feature request.  Could you provide more context to your scenario, maybe an example of the kinds of scenario you have today - and how you'd like to see that scenario work after this feature has been added?

[Triage] Hi @chaitrahegde115, thank you for filing this feature request. As a follow-up please provide your input to what @peternied commented last week. Could you provide further explanation to the feature you are requesting and what type of implementations you would like to see? Thank you.

Hi,
On a high level consider I have a crucial data stored in some indices of Opensearch. If a user has index level permission(apart from admin user) if he tries to delete the index then it allows user to delete that index. If there is dual control, then it should ask admin user / similar to admin user to authenticate the process deletion performed by that user.

@chaitrahegde115 Thanks for the additional detail.  I don't think this feature is in scope for the current vision of the security plugin, but I do see the overlap and we could be interested in reviewing a more detailed design or draft pull request if you'd like to build out this feature.

Closing for now, let's reopen once a more detailed proposal takes shape.


Roll Flutter Engine from 6975ee1b6de7 to 7d83d58b19e9 (4 revisions)

https://github.com/flutter/engine/compare/6975ee1b6de7...7d83d58b19e9
2023-08-15<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from AvjxPvh-niiyQpYoD... to -16K9GvYE3a4Bqs0G... (flutter/engine#44710)
2023-08-15<EMAIL_ADDRESS>Stop using deprecated GrBackendRenderTarget constructor (flutter/engine#44694)
2023-08-15<EMAIL_ADDRESS>Roll Skia from 022415d74e73 to d8d880c560f8 (1 revision) (flutter/engine#44708)
2023-08-15<EMAIL_ADDRESS>Roll Dart SDK from 8731e9796eb3 to d240bef060ed (1 revision) (flutter/engine#44707)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from AvjxPvh-niiy to -16K9GvYE3a4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add react/addons to webpack testing externals

Otherwise enzyme complains when using any React addon.
Ref

Isn't this already done?

Oh yeah, this is already done. Thanks @sotojuan, not sure how I missed this!


Rename babili to babel-minify

Hi! Is there any interest on this?

Thanks @michael-ciniawsky for fast review :)

I added the semver:major label to indicate as breaking change, but not really important since it will be publish under a new name on npm anyways :)
@boopathi How important is it being able to customize the babel & babel-preset-minify version via options ? :) What about a peerDependency instead?
I started porting parallelization support for this plugin from uglifyjs-webpack-plugin

@michael-ciniawsky let's fix all issues related to cache and parallelization in uglifyjs-webpack-plugin (and add tests) and we can implement same algorithm here :+1:

@boopathi How important is it being able to customize the babel & babel-preset-minify version via options ? :) What about a peerDependency instead?

Babel7 is in alpha now and almost everyone uses babel 6 in their toolchain. So it is important to have the ability to configure babel - i.e use babel7 for minification and babel6 for other transpiration or vice-versa.
babel and babel-minify are dependencies (and not peer deps) to have a good default and is the common case.

I added the semver:major label to indicate it as a breaking change, but not really important since it will be publish under a new name on npm anyways :)

I'll be publishing it as 0.2.0, to use the same version numbers as babel-minify.

I don't have permission to merge with failing checks. Can someone merge this?
Can someone give me push access to master to push release commits?

@boopathi need somebody from https://github.com/orgs/webpack-contrib/people who have Owner :disappointed:

Sry I can't, we are just grunt workers here :D Either set the status: Approved && pr: Merge ready labels or ping either (@)d3viant0ne (@)bebraw (@)TheLarkInn (@)SpaceK33z (@)jhnns (@)sokra to give you the appropiated access since you are lead maintainer here 😛

FYI - You have access to merge, it takes owner level access to override the checks.

I still need permission to push to master for release commits. How are release commits pushed to master in webpack-contrib?

@boopathi Just as a question, the package is released as 0.0.0 is it just for some internal reasons or not stable yet?

The first version will be 0.2.0 - mostly keeping it the same version as babel-minify(0.2.0)

OK so will wait for 0.2.0 before integrating with nuxt :)) Thanks for your hard work.


Force to supporting jalali calender

I use this module to localizing mat-datepicker and in some cases it call functions without argument ( e.g. year() return Gregorian year ).
I want to know why year, month and ... functions return Gregorian instead of jalali  when they call without argument.
Thank you for your effort

It's fixed in<EMAIL_ADDRESS>


400 | Error: Please specify QUIRREL_BASE_URL..

Bug Report
Current Behavior
When deploying to AWS (Fargate) Quirrel doesn't seem to work. It always asks for the QUIRREL_BASE_URL when calling the queue. I tried setting the QUIRREL_BASE_URL with https:// and without.
Input Code
Queue is in path: /api/emailQueue.ts (NextJS):
export default Queue("api/emailQueue", async ({ id }, meta) => {
...
})

Calling the queue:
emailQueue.enqueue(
          {
            id: r.data.id,
          },
          {
            retry: ["10sec", "60sec", "5min", "15min"],
          }
        )

Expected behavior/code
Pushing to the queue and don't return an error that the QUIRREL_BASE_URL isn't defined.
Environment

Quirrel version: 1.8.1
Node/npm version: Node 16

Does anybody know a solution?

hey @jatidevelopments! are you using the hosted Quirrel version (https://quirrel.dev), or a self-hosted instance? could you specify what "it always asks for the QUIRREL_BASE_URL" means? is that a log output you're seeing?

Hi @Skn0tt we are using the hosted Quirrel version. We deploy on AWS. I can't see anything in the Logsoutput but it happens when I try to call the emailQueue.enqueue function it returns "400 | Error: Please specify QUIRREL_BASE_URL".

Hmm :/ That error is thrown by this line:
https://github.com/quirrel-dev/quirrel/blob/ba995193d3db6f962c1e324f562f0a69db6daf04/src/client/config.ts#L103
It seems to me that somehow your environment variables aren‘t set correctly. Can you verify that QUIRREL_BASE_URL is indeed specified? For example by logging process.env.QUIRREL_BASE_URL right before your .enqueue call.

Okay, I will test it. Maybe it's because the env is from the Parameter Store at AWS. Do I need to add https:// in front?

Shouldn‘t make a difference. If there‘s no protocol given, it automatically uses https://:
https://github.com/quirrel-dev/quirrel/blob/ba995193d3db6f962c1e324f562f0a69db6daf04/src/client/config.ts#L106
but specyfing the protocol also works fine.

Now I get this error locally after switching the import from quirrel/vercel to quirrel/blitz

I assume that you were able to fix the QUIRREL_BASE_URL issue.
That error looks like you specified QUIRREL_ENCRYPTION_SECRET locally, but had pending jobs that weren‘t encrypted at all. So now it‘s trying to decrypt an unencrypted payload. Could that be the case?

I know the error
We use react-admin for the admin panel
This only works only at client side
So we disabled SSR
Quirrel cant get the QUIRREL_BASE_URL env on client-side
So yeah we need to create an API endpoint and then call the enqueue function in there
So it's solved! But thanks for the support!


Upgrade from v3.1.0 to v4.0.0 causes greatly increased thread count and caused thread starvation in Azure Durable Functions

Description
After upgrading Serilog.Sinks.ApplicationInsights to v4.0.0 and implementing the corresponding changes, I noticed a great increase in thread count in my azure durable function that caused thread starvation. This behavior did not happen in the the v3.1.0.
Reproduction
The only noticeable code change that maybe can be the source for this issue is changing the setup for the application insights from instrumentationKey to connectionString:
// In v3.1.0

ITelemetryConverter telemetryConverter = new CustomTraceTelemetryConverter();
string instrumentationKey = hostContext.Configuration[ConfigurationConstants.ApplicationInsightsInstrumentationKey];

Logger logger = new LoggerConfiguration()
                    .MinimumLevel.Is(logEventMinimumLevel)
                    .WriteTo.Console(outputTemplate: consoleSinkOutputTemplate)
                    .WriteTo.ApplicationInsights(instrumentationKey, telemetryConverter, restrictedToMinimumLevel: applicationInsightsMinimumLevel)
                    .Enrich.FromLogContext()
                    .Enrich.WithProperty("Environment", environment)
                    .Enrich.WithProperty("Version", version)
                    .CreateLogger();

// In v4.0.0
ITelemetryConverter telemetryConverter = new CustomTraceTelemetryConverter();
string connectionString = hostContext.Configuration[ConfigurationConstants.ApplicationInsightsConnectionString];

Logger logger = new LoggerConfiguration()
                    .MinimumLevel.Is(logEventMinimumLevel)
                    .WriteTo.Console(outputTemplate: consoleSinkOutputTemplate)
                    .WriteTo.ApplicationInsights(connectionString, telemetryConverter, restrictedToMinimumLevel: applicationInsightsMinimumLevel)
                    .Enrich.FromLogContext()
                    .Enrich.WithProperty("Environment", environment)
                    .Enrich.WithProperty("Version", version)
                    .CreateLogger();

// This is executed in the Startup.cs of the azure durable function

I also tested the function with both nuget package versions and only changing that part of the code and the results were the following:
Thread count during execution with v3.1.0:

Thread count during execution with v4.0.0:

Expected behavior
The expected beahvior should be the graph shown previously for the thread count while executing with the v3.1.0
Relevant package, tooling and runtime versions
Serilog.Sinks.ApplicationInsights 4.0.0 / 3.1.0
Serilog 2.12.0
Serilog.Extensions.Logging 3.1.0
Serilog.Sinks.Console 4.0.1
Microsoft.Azure.Functions.Extensions 1.1.0
Microsoft.NET.Sdk.Functions 4.1.3
Microsoft.Azure.WebJobs.Extensions.DurableTask 2.8.1
Microsoft.ApplicationInsights.WorkerService Version 2.21.0
.NET 6

No ideas here, unfortunately - the newer package includes a new set of app insights dependencies so the issue could be somewhere in there.
Just to check - is each function invocation using only a single Logger instance (not multiple calls to CreateLogger), and is the logger disposed properly when the function returns/exits? HTH!

Hi @nblumhardt could you clarify what dependencies where added?
In our Startup class we are configuring some telemetry initializers/processors as well,
so now I wonder if we have to filter these out from being stored:
public class Startup : FunctionsStartup
{

    public override void Configure(IFunctionsHostBuilder hostBuilder)
    {
            hostBuilder.Services.AddSingleton<ITelemetryInitializer, ExternalDataInitializer>();
            hostBuilder.Services.AddSingleton<ITelemetryInitializer, NoSensitiveDataInitializer>();
            hostBuilder.Services.AddApplicationInsightsTelemetryWorkerService(
                  hostBuilder.GetApplicationInsightsServiceOptions());
            hostBuilder.Services.AddApplicationInsightsTelemetryProcessor<FastSqlDependencyProcessor>();
            hostBuilder.Services.AddApplicationInsightsTelemetryProcessor<FastDependencyProcessor>();
            hostBuilder.Services.AddApplicationInsightsTelemetryProcessor
                <OnlyMemoryAndCpuUsagePerformanceCountersProcessor>();
    }

    public static ApplicationInsightsServiceOptions GetApplicationInsightsServiceOptions(this IFunctionsHostBuilder hostBuilder)
    {
            return new ApplicationInsightsServiceOptions
            {
                AddAutoCollectedMetricExtractor = false,
                EnableEventCounterCollectionModule = false,
                EnableDiagnosticsTelemetryModule = false,
                EnablePerformanceCounterCollectionModule = true,
                EnableDependencyTrackingTelemetryModule = true,
                ConnectionString = hostBuilder.GetContext().Configuration[ConfigurationConstants.ApplicationInsightsConnectionString]
            };
    }
}


chore(main): release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2023-12-28)
Bug Fixes

DTFS2-6472: improve /deals page sorting (#2446) (6050812)

This PR was generated with Release Please. See documentation.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6da84ce) 21.88% compared to head (870f973) 4.11%.
Report is 146 commits behind head on main.

Files
Patch %
Lines

dtfs-central-api/src/drivers/db-client.js
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2490       +/-   ##
==========================================
- Coverage   21.88%   4.11%   -17.78%
==========================================
  Files        1132     778      -354
  Lines       27048   18000     -9048
  Branches     4447    2848     -1599
==========================================
- Hits         5920     740     -5180
+ Misses      18403   15036     -3367
+ Partials     2725    2224      -501

Flag
Coverage Δ

api-test
0.48% <ø> (ø)

ui-test
?

unit-test
4.42% <0.00%> (+0.64%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:robot: Release is at https://github.com/UK-Export-Finance/dtfs2/releases/tag/v1.1.1 :sunflower:


cannot solve einstein's riddle

Hi, I tried to solve this constraint problem:
The situation
There are 5 houses in five different colors.
In each house lives a person with a different nationality.
These five owners drink a certain type of beverage, smoke a certain brand of cigar and keep a certain pet.
No owners have the same pet, smoke the same brand of cigar or drink the same beverage.
The question is: Who owns the fish?
Hints
the Brit lives in the red house
the Swede keeps dogs as pets
the Dane drinks tea
the green house is on the left of the white house
the green house's owner drinks coffee
the person who smokes Pall Mall rears birds
the owner of the yellow house smokes Dunhill
the man living in the center house drinks milk
the Norwegian lives in the first house
the man who smokes blends lives next to the one who keeps cats
the man who keeps horses lives next to the man who smokes Dunhill
the owner who smokes BlueMaster drinks beer
the German smokes Prince
the Norwegian lives next to the blue house
the man who smokes blend has a neighbor who drinks water
So I converted it into code like this, but the result is false. Is there a way to fix the code?
require "winston"
nat = %i(brit swede dane norwegian german)
house = %i(green white yellow blue red)
smoke = %i(pall dunhill bluemaster blend prince)
animal = %i(bird cat horse dog fish)
drink = %i(milk beer water tea coffee)
all = [nat, house, smoke, animal, drink]
csp = Winston::CSP.new
all.flatten.each do |v|
csp.add_variable v, domain: (1..5).to_a
end
all.each do |vs|
csp.add_constraint(*vs, constraint: Winston::Constraints::AllDifferent.new)
end
csp.add_constraint(:brit, :red){ |b, r| b== r }
csp.add_constraint(:swede, :dog){ |s, d| s== d }
csp.add_constraint(:dane, :tea){ |d, t| d== t }
csp.add_constraint(:green, :white){ |g, w| g == w - 1 }
csp.add_constraint(:green, :coffee){ |g, c| g== c }
csp.add_constraint(:pall, :bird){ |a, b| a== b }
csp.add_constraint(:dunhill, :yellow){ |a, b| a== b }
csp.add_constraint(:milk){ |a| a== 3 }
csp.add_constraint(:norwegian){ |n| n== 1 }
csp.add_constraint(:blend, :cat){ |a, b| (a- b).abs == 1 }
csp.add_constraint(:horse, :dunhill){ |a, b| (a- b).abs == 1 }
csp.add_constraint(:bluemaster, :beer){ |a, b| a== b }
csp.add_constraint(:german, :prince){ |a, b| a== b }
csp.add_constraint(:norwegian, :blue){ |a, b| (a- b).abs == 1 }
csp.add_constraint(:blend, :water){ |a, b| (a- b).abs == 1 }
p csp.solve

Hi @nurettin ,
Thanks very much for using it and giving feedback. Unfortunately, I'm a little too busy this week so it might take few days until I'm able to look into this. I just wanted to let you know that I saw your post and will get back as soon as I can.


Fix for metabase API change

Metabase changed the API response sometimes between 38 and 41 and client.get('/api/database/') returns a {"data": [{db info}, {...}]} instead of the previous [{db info}, {...}].

If you take this, the commit has to stay (so no deleting of the branch if you squash it), a mara instance depends on the commit ID...


[Metadata]: GodotEngine.GodotEngine version 3.1.x Copyright Notice Update

Description
A follow-up PR to those which've added versions 3.1, 3.1.1, and 3.1.2 of GodotEngine.GodotEngine Package. read more in 3.0.x Copyright Update PR

[!NOTE]
This PR changes Manifest's Copyright Field in multiple versions of GodotEngine.GodotEngine Package, If it's possible to accept this kind of PR (a PR that changes multiple manifests), then It'll save alot of headaches and time for both me & the maintainers.
If not, then I guess the only way to do this is by splitting these changes into 3 PRs.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Will close this PR according to this respond


Add command to retreive the package version

If PR #1  is merged with the main branch and distributed via PyPI, it is probably useful to add a command line feature to show the current package version. GitHub and PyPI might not be in sync, so this will help with debugging later on. It could be as simple as:
parser.add_argument('-v', '--version', action='version', version='<IP_ADDRESS>')

However, I recommend to get the version number from the setup.py file instead. This discussion on Stackoverflow lists a few options on how to get the package version at runtime.

You fixed this w/ your PR. Great job!


question: Declarative grafana configuration

Issue description
I would be interested in seeing declarative configuration of graphs in grafana, but it seems no such thing is currently supported.
What's the expected usage of Grafana if one wants to use e.g. the same Grafana configuration across multiple machines on different networks?
If that's not supported, what is the current expected usage of grafana?
Technical details
Any version of nixpkgs.

@coretemp Do the features implemented https://github.com/NixOS/nixpkgs/pull/53874 suffice for you?

Closing, this is sufficiently implemented IMHO (theoretically you can deploy alerting/dashboards/datasources with the module in here).
For examples see e.g. nixos/tests/grafana.


Add Library ID param to BWA map rule

Hi all - slightly reworked the params of the BWA map rule to specify the library id in the read group via a csv file relating sample name to library id. Wrote a small function in helperFun to read the csv file and store its info as a dictionary.
Tested these changes on our cluster with Slurm and verified the read group tags included the library id as specified by the csv file. I've included a example csv.
Let me know what you all think, as well as other features I can work on.

Cade,
This is a good start, however after some discussion today it we decided it would be good to add a few more pieces to this.

The most important step is that we need to extract all the sample information (sample id, run/fastq, library, reference genome) from the sample sheet. Currently the pipeline detects samples from the names of the fastq files in the fastq directory, and the reference genome from the name of the fasta file in the reference directory. Since your code just uses the metadata file for the library id, if there is a conflict between the fastq files in the directory and the sample sheet, it will break. To resolve this, we should change the code to extract samples and the reference genome so that it reads these from the sample sheet as well.

Secondarily, once we do that we need to check to make sure that the files exist in the right directories before proceeding. The most complete way to do this would be to write a fastq downloaded function and a genome downloaded function, using sra toolkit for the fastq download and just constructing a url for wget for the genome download. If these are written as snakemake rules, then if the files don't exist it will automatically fetch them.

Finally, since we get sample names from the fastq file, we assume right now that one sample = one fastq. But that is often not correct for sra data, where multiple runs may represent the same biosample. So, the bwa mem step needs to be updated to produce a bam for each run, and then the bams need to be merged (if there are more than one per run) before dedup. Most efficient would likely be to add sort to the mapping step and then replace sort with merge + index prior to dedup.

I will bounce this pull request back for now and we can work on this roadmap in this fork until it is finalized.

Hey Tim,
This all sounds good. Didn't want to mess with the flow of the workflow (how sample names were obtained) to begin with, but you're right it makes the most sense to use the sample sheet to determine sample name, library id, etc. Will work on implementing that. Would be great to confirm the format of the samples sheet, is what I have in samples.csv correct?

Hi Cade,
You can find an example of the sample sheet format here: https://github.com/sjswuitchik/compPopGen_ms/blob/master/SRA/cleaned-metadata/Amphilophus_amarillo_run_metadata.csv
But only the first four columns (sample, library id, reference genome, and SRA run id) actually matter for this, I think.

Perfect, thanks!

Hey Tim,
I'll commit my changes soon, but I'm trying to figure out how a sample with multiple SRRs will be represented in the sample sheet. Will there be multiple entries for a sample like so:
samp1, lib1, ref, SRR1
samp1, lib1, ref, SRR2
samp2, lib2, ref, SRR3
...

Yes, each unique SRR gets its own line.

Great. Thanks.

Hey Tim,
Got the workflow running with samples that have multiple SRRs as well as those that have one. Tested with samples.csv (in commit).

Hi Cade,
This looks very nice. One comment/question: am I just missing it, or is the get_ref_link function not used anywhere? It looks like the ncbi datasets is doing all the work to download the reference.
If that is the case, can you clean up the pieces of code not needed, test again, and then I'll approve the merge?
Tim

Hi Tim,
Removed get_ref_link. It was used for downloading the reference before I found NCBI datasets.


No support to custom validation rules

Describe the bug
There is no support to add custom validation rules
Reference: https://github.com/glorand/laravel-model-settings/issues/87#issuecomment-964529183
To Reproduce
Add a custom validation rule. You'll get "expression is not allowed as field default value".
Expected behavior
Convert the "settingsRules" property to a method like the "rules" method in Laravel FormRequest
Screenshots

😥

The project seems to be abandoned.
I am closing the issue because I have forked this project, fixed this issue, and also added other features.

@Lukasss93 sorry for late answer. Can you make a pull request for this feature. Thanks in advance!


ci: add workflow to publish crates to crates.io

This PR add a github action to automate the publish of crates to crates.io.
In this PR I added --dry-run so we could test it first to avoid anything wrong.
And this action need the tag used for creating release follow this syntax: {crate_name}_v{version_value}
This workflow depends on the secret CARGO_REGISTRY_TOKEN

Using environments for deployment: Then since we need secret to be used to publish new versions to crates.io , GitHub offers Configure environments to set rules before a job can proceed and to limit access to secrets. so jobs that need access to specific secret need approval, more ref: security-guides/encrypted-secrets

Need owner to add this organization level secret named CARGO_REGISTRY_TOKEN with proper access policy!
CC: @jethrogb  @Goirad  @chavipuri

bors r+


Sorted to expand closest args first

... had to refactor to make it work...
should help with sentences where both args are on the same side of the trigger and the further away arg swallows the closer, as with the sentence:
Areas of greatest concern include Wau , northwestern Jonglei , and central Unity , though given the severity of food insecurity across South Sudan and unpredictable nature of conflict , the possibility of Famine ( IPC Phase 5 ) should be considered in many states of the country .

I'm pretty sure this change is a good idea, but at some point I'm going to try to review anything with O(x) > O(n), like sorting and distinct.  I don't think that Scala keeps track of the sorted by values (distToTrigger(trigger, _)) and makes possibly expensive calculations multiple times.  (These are pretty simple ones, though.)
The RuntimeException is scary.
    for {
      m <- ms
    } yield addOverlappingAttachmentsTextBounds(m, state)

=>
ms.map(addOverlappingAttachmentsTextBounds(_, state))

or something.
I'm not sure about the math.abs.  In one case 2nd case it isn't necessary.  I'm not sure about the first with the start/end/abs and comparison of intervals.  If it works I can't complain.
Can m.arguments be mappend onto an immutable HashMap?  It can wait until a different pass if the code sticks around long enough and if it's even possible.

re: addOverlapping -- > I can do you one better, removed in a push I'm about to do! (it was kinda leftover from previous code)
re: RuntimeException -- huh? where is it?
re: math.abs -- you're right in that it should be fine without it......... I was trying to be safe, but perhaps I should assume and catch issues that fail my expectations?
re: m.arguments -- what line?

You tricked me!  Distracting me with unused code :-(  you were.  The m.arguments is between
    val newArgs = scala.collection.mutable.HashMap[String, Seq[Mention]]()
    for ((argType, argMentions) <- m.arguments) {
...
      newArgs.put(argType, attached)

It seems like it could be m.arguments.map{ ...; (argType -> attached) }.toMap.  I'm not sure which is more efficient, but one is prettier.

However, I think @bsharpataz should ignore tiny things like this.  Do you need Mihai to look at it?  I never know if multiple reviewers is an and or an or and consequently wait to long for the and.

I don't think I need him to, and he's kinda busy at the moment, so whatever
you think is best
On Fri, Nov 9, 2018 at 11:56 AM Keith Alcock<EMAIL_ADDRESS>wrote:

However, I think @bsharpataz https://github.com/bsharpataz should
ignore tiny things like this. Do you need Mihai to look at it? I never know
if multiple reviewers is an and or an or and consequently wait to long for
the and.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/506#issuecomment-437459695, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFIniYGFih9UIq1jAh1G6lFI__OqKYdfks5utc_WgaJpZM4YRNyq
.


Research and choose a suitable CI tool (e.g., GitHub Workflows,Jenkins, Travis CI, CircleCI).

Do some research on Continuous Integration tools

Did analysis and finalize Github workflows for Continuous integration as it has inbuilt workflows  in the marketplace

Completed research for GitHub workplace to use node.js from the workplace


Stuck when calibrating IMU

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 20.03

Kernel Version (Linux Only)
4.9.140-tegra

Platform
Jetson Nano

SDK Version
2.47.0

Language
Python

Segment
Robot

Issue Description
<Describe your issue / question / feature request / etc..>
I am trying to calibrate my imu using calibration tool provided by the SDK. But, I always stuck in this condition

waiting for realsense device...
Device PID:  0B3A
Device name:  Intel RealSense D435I
Serial number:<PHONE_NUMBER>41
Product Line:  D400
Firmware version:  <IP_ADDRESS>
Start interactive mode:
FOUND ACCEL with fps=63
FOUND GYRO with fps=200
*** Press ESC to Quit ***
Align to direction:  [ 0. -1.  0.]   Mounting screw pointing down, device facing out
Status.rotate:           [-0.0215 -0.0003 -0.0089]:                 [ True  True  True]

Hi @aaumar  This guidance is asking for the camera to be put on a flat surface with the bottom of the camera resting on the surface and the front of the camera facing straight ahead.  You then rotate the camera with your hands until the three values of Status.rotate match as closely as possible to the three values of Align to direction.
When the camera orientation is detected to be a match to the Align to direction, a counter that is represented as a lengthening line of dots should begin.
When the line of dots successfully reaches a certain length, the calibration tool should automatically proceed to the next stage and ask you to orient the camera to a different Align to direction position.  This process is repeated until all orientations have been successfully completed.
Are you able to get as far as the orientation being matched and the line of dots starting to increase, please?

Hi @MartyG-RealSense, it seems the calibration tool is fine after I restart my jetson.
But, there is another problem coming after finished doing 6 calibration poses (just after confirming to write the results to the camera). The error message is

Error: failed to set power state
Segmentation fault (core dumped)

I have seen a small number of past cases of this error when performing IMU calibration.  The majority of them were able to complete calibration and receive a 'Done' confirmation shown in the message below (indicating that the calibration had been written to the camera) before the segmentation fault occurred.

One Ubuntu user who just received the same confirmation-less message that you did changed to a different Ubuntu machine and received the version above (Done, and then the segmentation fault).
The IMU of the camera is calibrated in the factory during manufacturing though, so it may not be a serious problem if you cannot get to the 'Done' state on your particular computer.

Hi @aaumar  Do you require further assistance with this case, please?  Thanks!

Thanks very much @aaumar for the update!


Remaining Python bootstrapping fixes (part 1)

Description of changes
There are only a few dozen known breakages now from https://github.com/NixOS/nixpkgs/pull/248866 (and tracked in https://github.com/NixOS/nixpkgs/issues/247287). Instead of creating individual PRs like I have been doing, I'm going to try to batch the remaining ones for less noise and more efficiency.
I know this PR is larger than usual and thus a little more risk and a little harder to review. Thank you for your help and patience through this process.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build python310Packages.autarco python311Packages.autarco
@ofborg build python310Packages.celery-types python311Packages.celery-types
@ofborg build python310Packages.cemm python311Packages.cemm
@ofborg build python310Packages.cohere python311Packages.cohere
@ofborg build python310Packages.distributed python311Packages.distributed
@ofborg build python310Packages.esphome-dashboard-api python311Packages.esphome-dashboard-api
@ofborg build python310Packages.fastparquet python311Packages.fastparquet
@ofborg build python310Packages.grpc-interceptor python311Packages.grpc-interceptor
@ofborg build python310Packages.knx-frontend python311Packages.knx-frontend
@ofborg build python310Packages.laszip python311Packages.laszip
@ofborg build python310Packages.msprime python311Packages.msprime
@ofborg build python310Packages.multiset python311Packages.multiset
@ofborg build python310Packages.napalm-hp-procurve python311Packages.napalm-hp-procurve
@ofborg build python310Packages.netcdf4 python311Packages.netcdf4
@ofborg build python310Packages.newversion python311Packages.newversion
@ofborg build python310Packages.nitime python311Packages.nitime
@ofborg build python310Packages.pipdeptree python311Packages.pipdeptree
@ofborg build python310Packages.polyline python311Packages.polyline
@ofborg build python310Packages.py-dormakaba-dkey python311Packages.py-dormakaba-dkey
@ofborg build python310Packages.pydeck python311Packages.pydeck
@ofborg build python310Packages.pydicom-seg python311Packages.pydicom-seg

Merging into staging-next since contributors are already finding these errors, and I'd like to make their lives easier.


Updated Validations.py Python Script

Fixes # 1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

hi


Revert "lightweight -> lightWeight in jobs DSL's"

This reverts commit 61e89ed0618d026e40f817d44456b75d613cb046.
Signed-off-by: brmclare<EMAIL_ADDRESS>

/lgtm

/lgtm


open redirect config

Hi, can you help me please to configure the open redirect? Thank you
I got a lot of false positive using it even if I configure it like you did on youtube tutorial

thank you

HI @Teicu,
With this config its possible that you have false positives, because it's possible that the application return you regex but first another domain, it's your case?
If you want tell me more details about it, we can see if its possible resolve this.
Thanks for comment!


Using this library prevents excel DNA loading the functions to the xll.

If I swap over the attributes from ExcelFunction to ExcelFunctionDoc I get more fields available and I can add a summary. However this also means that all UDF disappear when I load the xll. Swapping back the attributes solves it. In both cases docs are generated.

Are you including a reference to ExcelDna.Documentation.dll in your .dna file? Otherwise I have an sample add in in src/samples. If you could upload a project that reproduces the error I can take a look.
Example .dna file

That will be the issue. I was using Costura to embed all dependencies prior to excelDna, hence my DNA file nly contained thew main assembly.
Thanks
Sean


Change color of typed text in List Widget to white/light gray

Might require changing theme to dark mode (this change is global so all pages would need to be adjusted)

Submitted issue to Esri Tech Support. Ticket info copied below:
Esri Case #03448770 - The icons in list widget become illegible when an item on the list is selected in Experience Builder
I regret to inform you that we will not be able to change the color of the typed text in the search bar and the icons in the Experience Builder. We can change the theme and the background color which by default changes the font color. For example, if we are selecting the light theme then the font color changes accordingly. I have changed the theme of the same experience builder I shared earlier. Kindly have a look at how the icons and font color changed.


Why bbox loss is always 0?

I have trained FPN and the bbox loss is always 0, except the first one hundrand iterations.
I have not found the problem.
Could you please give me some advice? Thank you.

I have not met this issue.
Could you offer more details, such as logs?

This could be due to negative annotations or the -1 when extracting the bounding boxes. This has been a regular issue when using similar code for faster rcnn.


[DataGrid] inserting rows does not work as intended

To reproduce (with the latest 3.0 preview)

start the DataGridDemo project
open the List<PlainObject> example
insert a row via right-click > Insert

The new row will be completely empty. Trying to modify this row or adding another row will throw an excepction.
Adding a new row at the bottom via the "+"-sign works as intended.

Possibly related: Deleting columns via the same right-click menu leaves the deleted row empty until the DataGrid is updated by other means (e.g. adding a new row).

I found the issue: The problem is the function GetItemsSourceIndex in DataGridOperator.cs - the part that is marked with TODO: find a better way to do this (l.298) seems to cause the problem. If the CollectionView is not yet refreshed, this can throw an IndexOutOfRange Exception.
Replacing the whole function with return index; fixes the problem for this special case. At the moment I don't really understand in which cases the ItemsSource index is different from the CollectionView index, so I'm not sure how to fix this.

An easy fix for both problems would be to insert a this.CollectionView.Refresh(); before this.UpdateGridContent(); in InsertRows() and DeleteRows() in DataGrid.cs. Then the CollectionView is already updated when GetItemsSourceIndex is called.
What do you think @objorke ? Do you want a "proper" fix (which I probably couldn't provide), or are you ok with this?

thanks for the tip! I added the refresh call in #140

Awesome! I will test and confirm it works in my project once the Nuget package is updated. Thanks! :)


Could .srt files to be added ?

If you can add the .srt files , it will be very awesome !!

I have been also thinking about adding .srt files but it seems like the way the program download the lectures now doesn't seem to allow me to do that(since the program just scrapes the site and finds an anchor tag with a "download" class and then download the lecture from that "href" attribute). If you have any other opinions or suggestions I would be delighted to hear you out.
Thank you


Update calendar_date_select.rb

Includes FormHelpers and IncludesHelper in the ActionView::Base instead of ActionView::Helpers.

Using this gem alone was working fine until I start to use another gem which was doing a ActionView::Base.send(:include, ...).
I don't understand why, but the next gem doing the include on the ActionView::Base removes the calendar_data_select_tag.
This commit make all working all together.

@timcharper any chance you have a look at this PR please?

@marcandre can you please have a look at this PR?

I think this gem is not really supported anymore. Moreover I don't understand the details of this change, nor how your original issue happens, sorry...

Thank you @marcandre for your comment.

I think this gem is not really supported anymore.

I can believe it but unfortunately the project I'm migrating is using it and we aren't ready to remove it yet (but should happen one day).

I don't understand the details of this change, nor how your original issue happens

This change fixes the compatibility of this gem with other gems injecting view helpers in Rails.
This gem works when running alone, but adding another gem injecting helpers makes calendar_date_select no more working.
This PR fixes this by using the normal way of adding helpers in the view context.


Hotfix for evolvable count

Short Description:
Fixes/Resolves/Closes (please use correct syntax):

Fixes evolvable count bugs
#5693

👍

another nice catch @alexyaoyang, sorry for the trouble


WebUI Enhancements and network setup page

Adds a new page under network called 'setup', which contains a form that interacts with wlanpi-core api to set the wpa-supplicant. future UI changes will be made to make it look better and less crowded.
Below it there is an iframe that shows a table from the interface scan results. this is asynchronous so the page loads and doesn't wait for this first.
There is also a pill in the navbar that shows the current mode that the wlanpi is in, in the future this will be a selector to change the mode from the UI, which I have already designed but commented out.

@Orbitix network_setup.html template is missing. Can you add?

@joshschmelzle html file added. should work now!

@Orbitix It looks like netscan_iframe.html is missing as well. Can you pull 280936f2161a56d35a79f196a789c02a3bdbd35f and then add netscan_iframe.html and push?
jinja2.exceptions.TemplateNotFound: netscan_iframe.html

@joshschmelzle I am away this weekend so I can't push anything untill Sunday.
The git repo on my pi didn't pick up new files, only the modified ones so that's why so many are missing.

Is there more to be done to this to prepare for merge

@Orbitix is there anything on your side remaining to commit? I can look early next week and get this merged for Prague.

@joshschmelzle everything on my end is commited and working. The code probably just needs to be cleaned up a bit, but other than that it should be fine

@joshschmelzle I have pushed the change that fixes the webui crash when nginx times out, so it will just return "Internal Server Error" in the message box on the network setup page instead of just going to a 500 page.
Is there anything else that needs doing with webui or is it all good to hand over to you?

I can take a look either late tonight or tomorrow

Hey @Orbitix, thanks for taking the time on this PR. I started reviewing your PR last night and noticed a few issues that are causing errors and can easily break when used in production.
There are quite a few areas that need polishing, and because of the size of the changes, it's taking me longer than expected to go through everything in detail. I really appreciate the effort you're putting in, but as it stands, the code isn’t quite ready to be merged.
Before we move forward, I wanted to ask—how comfortable are you with receiving feedback and making revisions on this PR? I'd be happy to go through the changes with you and guide you on how to improve them. This will likely delay this from making it into the Prague release. Alternatively, if you'd prefer, I can take it over from here and incorporate the changes myself.
Let me know how you'd like to proceed, and thanks again for all your effort on this.

Alright thanks, that would help a lot as I don't really know how to use htmx


How does grom get the total number of records while using the limit query？

Your issue may already be reported! Please search on the issue track before creating one.
What version of Go are you using (go version)?
go1.10.1 linux/amd64
Which database and its version are you using?
mysql
grom 如何使用limit查询的同时取得总的记录数？类似db查询时可以使用：SELECT SQL_CALC_FOUND_ROWS name, email FROM users WHERE name LIKE ‘a%’ LIMIT 10;
SELECT FOUND_ROWS();
谢谢大佬们，欢迎围观~
****

同想知道 解决了吗？

我也想知道

any body who knows it ?


White Preview Screen

Describe the bug
Every Browser I use I keep running into a white preview screen have not been able to see any previews? Trying to create a 3D CPQ
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-vgzces
Steps to reproduce
Prompt
-Create 3D CPQ for a Pool
Says it does it and i can see preview and I cant see preview
Expected behavior
I expect to see a preview I only see a white screen
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 46673062,
  "usedJSHeapSize": 44473982,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = WhitePine2024
Chat ID = 8c112a7c366b

Additional context
Have used: Shift, Edge, & Chrome

Appreciate the feedback. We are aware of this issue and are tracking is here: #1791.


Improve run in terminal experience

Ideas (WIP):

Add option to enable run in a new terminal every time
Add option to provide args when running in terminal
Add option to configure how we execute everything via launch.json

I suggest that the "run selection in terminal", RSIT, command favor the currently selected terminal, if it has a name that's in a cofigurable list, something like python.terminal_names.  python.terminal_names should support regex and the default should be something like: ['python*', 'ipython*', 'Python*'][^1][^2].
If the focused terminal's name doesn't match python.terminal_names, then RSIT can configurably open a new terminal or use the terminal that it is linked to if it exists.  New terminals might want to make a unique terminal name maybe "Python n", where n is just an incremental number.  This might cause confusion though with new users who would think "Python 2" is running python 2 so perhaps some other convention.
Also, because python.terminal_names is regex, users would be free to rename the terminal something more descriptive like "Python super awesome project", don't hover, just click and believe.
[^1]: 'python' and 'ipython' happen automatically, for me at least, when running python or ipython through powershell, which causes the name of the terminal to be changed.  'Python', of course, is the name that RSIT gives the terminal it creates.
[^2]: please pretend that this list was just one awesome regex string instead of three pleb jank fests; thank you!

Some ideas:

When running a Python file in a new terminal, name the terminal after the file not just a generic Python label. If you run one file multiple times or the name already exists for some other reason, just append (1), (2), etc. to the title.
+1 to Add option to enable run in a new terminal every time. It's annoying when I want to kick off 5 long running Python scripts in parallel and the run button does nothing because it keeps trying to run in the single terminal that is busy running the first script.
It would be good UX to have similar options and behavior on terminals & interactive windows. I think https://github.com/microsoft/vscode/issues/127998 is a good step towards this. I'd also like to see the same run in a new window and name window after filename ideas implemented on the interactive windows.


Share Code URL implementation using Environment URL

@mananjadhav @alex-mechler @kevinksullivan @AndrewGable
Details
The following changes can be done to incorporate the functionality in a common place:
a) Leverage the existing WithEnvironment component and add support for environmentURL. This variable will contain the environment-specific URL from Environment.
b) Use the environmentURL from WithEnvironment to decide on the URL for use with Share code functionality. Also, ensure that a trailing slash is present in the environment url.
Fixed Issues
$ https://github.com/Expensify/App/issues/19464
PROPOSAL: https://github.com/Expensify/App/issues/19464#issuecomment-1565190797
Tests

Android Native

Prerequisite:
Find out the latest production version at https://api.github.com/repos/expensify/app/releases/latest.
Tag_name will represent the latest deployed production version
"tag_name": "1.3.27-7",
Here, the latest deployed production version is 1.3.27-7
i) Staging:
Build an android app that uses a production environment configuration file with package version of 1.3.27-8
"version": "1.3.27-8", (i.e. in package.json)
Follow the steps as below:
a) Verify version in Settings->About
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://staging.new.expensify.com/
ii) Production:
Build an android app that uses production environment configuration file with package version of 1.3.27-7
"version": "1.3.27-7", (i.e. in package.json)
Follow the steps below:
a) Verify version in Settings->About
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://new.expensify.com/
iii) Development:
Follow the steps as below:
a) Verify 'dev' label next to Expensify in header.
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://localhost:8080/

mWeb-Android-Chrome/web:

i) Development Version:
a) Launch the expensify app at http://localhost:8080/
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://localhost:8080/

MacOS-Desktop:

i) Production Version:
a) Launch the electron production App
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://new.expensify.com/
ii) Staging Version:
a) Launch the electron staging App
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://staging.new.expensify.com/

iOS-Native-Simulator:

i) Production Environment:
a) Launch the production iOS Native app
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://new.expensify.com/

Safari-Dev
i) MacOS/iOS-Safari
a) Launch the dev version on Safari in MacOS
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://localhost:8080/

[x] Verify that no errors appear in the JS console

Offline tests
i) Android-Native Production Version:
a) Ensure mobile is offline (Disconnect from WiFi and Mobile Data)
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://new.expensify.com/
QA Steps
Following additional test steps are required:

Web
i) Staging Deployment:
a) Launch the expensify app at https://staging.new.expensify.com/
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://staging.new.expensify.com/

ii) Production Deployment:
a) Launch the expensify app at https://new.expensify.com/
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://new.expensify.com/

iOS Native App:

i) Staging:
a) Setup TestFlight for iOS and launch app
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://staging.new.expensify.com/
ii) Production:
a) Install production version from iOS App Store and launch app.
b) Copy URL to keyboard in Settings->Share code
c) Paste it in the compose box of one of the existing chat
d) Verify that the URL starts with https://new.expensify.com/

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android-Native-Staging (1->i)
https://github.com/Expensify/App/assets/3004659/85d465ba-3708-4e7f-8d42-08b66753175d

Android-Native-Production (1->ii)
https://github.com/Expensify/App/assets/3004659/47074b30-1c48-48e2-a5f3-1e591f88e290

Android-Native-Development (1->iii)
https://github.com/Expensify/App/assets/3004659/88f5d950-1cc2-4bec-a257-baf46eeb94d0

mWeb-Chrome-Development Version (2->i)
https://github.com/Expensify/App/assets/3004659/03adc59b-7a76-4b36-8a8a-81a4b6760458

MacOS / Desktop Production
https://github.com/Expensify/App/assets/3004659/46ffb591-e1ba-4dac-a605-06513f7af69f

MacOS / Desktop Staging
https://github.com/Expensify/App/assets/3004659/ab8506cc-558a-4991-97ab-1a4eda3b1c20

 iOS / Native - Simulator - Production
https://github.com/Expensify/App/assets/3004659/b97673bf-aa20-46d0-84d9-c9014fb47c86

 MacOS / Safari -Dev
https://github.com/Expensify/App/assets/3004659/0f933cf9-99fe-4f23-ba86-09b575014d54

 Offline - Android Native Prod
https://github.com/Expensify/App/assets/3004659/bdbb27b5-35d9-4d92-8941-ccd3181404b8

@mananjadhav Were you able to review and test the changes? Let me know if this is fine to merge. Or if any changes are required, will be glad to update.

@alex-mechler. I hope you are back today. Can you please add<EMAIL_ADDRESS>and<EMAIL_ADDRESS>to the high traffic account?

@mananjadhav, @alex-mechler, Friendly bump on review and next steps.

Added<EMAIL_ADDRESS>and<EMAIL_ADDRESS>as high traffic accounts

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/3069065/86f3c2fd-8147-4103-beb8-93cce55aa2c4

Mobile Web - Chrome
https://github.com/Expensify/App/assets/3069065/86c31221-55cb-4bae-931a-f49e7579931c

Mobile Web - Safari
https://github.com/Expensify/App/assets/3069065/e86f287e-ed6b-475c-9cde-e0612b8cef23

Desktop
https://github.com/Expensify/App/assets/3069065/69c64cd8-0bae-484c-84a6-6d02b36d04e8

iOS
https://github.com/Expensify/App/assets/3069065/b8942c9c-e085-493e-99ce-2fa899e9d41f

Android
https://github.com/Expensify/App/assets/3069065/358e05cc-eaa4-4ace-8c28-d9f23a46b4db

@alex-mechler all yours, I checked the URL by copying values from .env.staging to .env and it shows the correct value.

@mananjadhav @alex-mechler The lint issue due to prettier has been fixed. Also, I have done testing with the high-traffic account and have updated the checklist too with all checks. Kindly review and approve.

We did not find an internal engineer to review this PR, trying to assign a random engineer to #19464... Please reach out for help on Slack if no one gets assigned!

@mananjadhav  @MelvinBot  AFAIK, @alex-mechler  was supposed to review this as an internal engineer. Or is there any change?

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.31-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Update footer twitter logo.

Issue

The current logo of X (fka twitter) on the landing page is a deprecated one.
The current icons library "lucide-react" doesn't have the new "X" logo.

Solution

Just replace it with an SVG of the new "X" logo.

hi hanzalahwaheed will fix it but may I know why am I getting this

i have replaced the lucide with react icons beacuse the icons from lucide are deprecated and changed the twitter icon  @hkirat

should i raise the pr @hanzalahwaheed  @hkirat


Add rdbname description to docs

Fixes #104

Hey @naveen-ram, I think it may be better to take out the note about the RDB name for now. I will work on the formatting and wording on that and send a PR.