Locking case in SMP mode

Recently I use qemu to simulate the sabre-6quad board based on the SMP defconfig .
When turn on CONFIG_DEBUG_FEATURES  CONFIG_DEBUG_ERROR options  and run app/testing/smp program , the nuttx system was locked.
See call stack, I found the thread1 was locked at spinlock() and thread2 was locked at enter_critial_section().

Turn off the CONFIG_DEBUG_ERROR options and the SMP program runs normally.
What could be the problem?
My defconfig is as follows:
CONFIG_ARCH="arm"
CONFIG_ARCH_BOARD="sabre-6quad"
CONFIG_ARCH_BOARD_SABRE_6QUAD=y
CONFIG_ARCH_BUTTONS=y
CONFIG_ARCH_CHIP="imx6"
CONFIG_ARCH_CHIP_IMX6=y
CONFIG_ARCH_CHIP_IMX6_6QUAD=y
CONFIG_ARCH_INTERRUPTSTACK=2048
CONFIG_ARCH_IRQBUTTONS=y
CONFIG_ARCH_LOWVECTORS=y
CONFIG_ARCH_STACKDUMP=y
CONFIG_BOARD_LOOPSPERMSEC=99369
CONFIG_BOOT_RUNFROMSDRAM=y
CONFIG_BUILTIN=y
CONFIG_DEBUG_ASSERTIONS=y
CONFIG_DEBUG_ERROR=y
CONFIG_DEBUG_FEATURES=y
CONFIG_DEBUG_FULLOPT=y
CONFIG_DEBUG_INFO=y
CONFIG_DEBUG_SYMBOLS=y
CONFIG_DEBUG_WARN=y
CONFIG_DEV_ZERO=y
CONFIG_FS_PROCFS=y
CONFIG_HAVE_CXX=y
CONFIG_HAVE_CXXINITIALIZE=y
CONFIG_IMX6_UART1=y
CONFIG_IMX_DDR_SIZE=1073741824
CONFIG_INTELHEX_BINARY=y
CONFIG_MAX_WDOGPARMS=2
CONFIG_NFILE_DESCRIPTORS=8
CONFIG_NFILE_STREAMS=8
CONFIG_NSH_ARCHINIT=y
CONFIG_NSH_BUILTIN_APPS=y
CONFIG_NSH_FILEIOSIZE=512
CONFIG_NSH_READLINE=y
CONFIG_PREALLOC_MQ_MSGS=4
CONFIG_PREALLOC_TIMERS=4
CONFIG_RAMLOG=y
CONFIG_RAM_SIZE=1073741824
CONFIG_RAM_START=0x10000000
CONFIG_RAM_VSTART=0x10000000
CONFIG_RAW_BINARY=y
CONFIG_RR_INTERVAL=200
CONFIG_SCHED_HPWORK=y
CONFIG_SCHED_HPWORKPRIORITY=192
CONFIG_SCHED_WAITPID=y
CONFIG_SMP=y
CONFIG_SMP_NCPUS=2
CONFIG_START_MONTH=3
CONFIG_START_YEAR=2016
CONFIG_SYMTAB_ORDEREDBYNAME=y
CONFIG_SYSTEM_NSH=y
CONFIG_SYSTEM_NSH_CXXINITIALIZE=y
CONFIG_TESTING_SMP=y
CONFIG_TESTING_SMP_NBARRIER_THREADS=4
CONFIG_UART1_SERIAL_CONSOLE=y
CONFIG_USER_ENTRYPOINT="nsh_main"

@masayuki2009 could you help look at this issue? The deadlock can 100% repo on QEMU.

I've just enabled CONFIG_DEBUG_FEATURES CONFIG_DEBUG_ERROR but it works.
diff --git a/boards/arm/imx6/sabre-6quad/configs/smp/defconfig b/boards/arm/imx6/sabre-6quad/configs/smp/defconfig
index f871b91a12..335915089f 100644
--- a/boards/arm/imx6/sabre-6quad/configs/smp/defconfig
+++ b/boards/arm/imx6/sabre-6quad/configs/smp/defconfig
@@ -21,6 +21,8 @@ CONFIG_ARCH_STACKDUMP=y
 CONFIG_BOARD_LOOPSPERMSEC=99369
 CONFIG_BOOT_RUNFROMSDRAM=y
 CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
 CONFIG_DEBUG_FULLOPT=y
 CONFIG_DEBUG_SYMBOLS=y
 CONFIG_DEV_ZERO=y
@@ -28,7 +30,6 @@ CONFIG_EXAMPLES_HELLO=y
 CONFIG_FS_PROCFS=y
 CONFIG_HAVE_CXX=y
 CONFIG_HAVE_CXXINITIALIZE=y
-CONFIG_HOST_WINDOWS=y
 CONFIG_IMX6_UART1=y
 CONFIG_IMX_DDR_SIZE=1073741824
 CONFIG_INTELHEX_BINARY=y

My defconfig is as follows:

Hmm, you modified many configs in boards/arm/imx6/sabre-6quad/configs/smp/defconfig.
So I've just tried your defconfig again and ran the nuttx on qemu on ubuntu18.04 but it worked.

Just tried the latest version of the community, the problem did not repeat. Maybe my version is a little bit old. Thank you for your help. @masayuki2009

@liujianqiang1016

Just tried the latest version of the community, the problem did not repeat. Maybe my version is a little bit old. Thank you for your help. @masayuki2009

Thanks for your updates.
I think it relates https://github.com/apache/incubator-nuttx/pull/774. which I fixed recently.

@masayuki2009 we found that sabre-6quad:smp will always hang on QEMU if we add some log like the attached patch.
0001-Add-some-log-in-arm_decodeirq-to-repo-the-deadlock-i.zip

@masayuki2009 we found that sabre-6quad:smp will always hang on QEMU if we add some log like the attached patch.
0001-Add-some-log-in-arm_decodeirq-to-repo-the-deadlock-i.zip

@xiaoxiang781216 I've just confirmed the deadlock. I will take a look at what is happening tomorrow.

Sure, thank for take time to investigate SMP issue.

Hmmm... just looking at the code, it looks like arm_decode_irq() would be a bad place to put any debug output.  That is because arm_decode_irq() calls arm_doirq() and is where the interrupt mode is set:
 88   /* Current regs non-zero indicates that we are processing an interrupt;
 89    * CURRENT_REGS is also used to manage interrupt level context switches.
 90    */
 91
92   CURRENT_REGS = regs;

Prior to that, the system has no idea that it is in an interrupt handler.  Syslog will think it is in a normal task mode and will almost certainly do the wrong thing.  I have not tracked down all of that, but I have looked at enough to see that arm_decode_irq() is not a valid place to call syslog() functions.
If you move the __err to _arm_doirq() after CURRENT_REGS is set, it may work.

Another thing to be careful of is doing syslog output in the same logic patch that handles serial console output.  If you generate serial console output everytime a serial interrupt occurs, then you will also get into a different kind of infinite loop.  Best to check if the irq is the console irq and don't do syslog output.

@xiaoxiang781216 I've just confirmed the deadlock. I will take a look at what is happening tomorrow.

(gdb) target extended-remote:1234
Remote debugging using :1234
up_testset () at armv7-a/arm_testset.S:120
120             mov             r0, #SP_LOCKED
(gdb) info thread
  Id   Target Id                  Frame
* 1    Thread 1 (CPU#0 [running]) up_testset () at armv7-a/arm_testset.S:120
  2    Thread 2 (CPU#1 [running]) 0x10802eb0 in spin_trylock_wo_note () at semaphore/spinlock.c:178
  3    Thread 3 (CPU#2 [halted ]) 0x108081cc in up_idle () at chip/imx_idle.c:59
  4    Thread 4 (CPU#3 [halted ]) 0x108081cc in up_idle () at chip/imx_idle.c:59
(gdb) where
#0  up_testset () at armv7-a/arm_testset.S:120
#1  0x10802e70 in spin_lock (lock=lock@entry=0x10829379 <g_cpu_paused+1> "\001") at semaphore/spinlock.c:89
#2  0x10801250 in up_cpu_pause (cpu=cpu@entry=1) at armv7-a/arm_cpupause.c:282
#3  0x10813164 in sched_addreadytorun (btcb=btcb@entry=0x10836eb0) at sched/sched_addreadytorun.c:280
#4  0x10808148 in up_unblock_task (tcb=0x10836eb0) at armv7-a/arm_unblocktask.c:102
#5  0x10802e28 in nxsem_post (sem=sem@entry=0x10837f94) at semaphore/sem_post.c:165
#6  0x10804068 in nxtask_exitwakeup (status=277052944, tcb=0x10837e10) at task/task_exithook.c:547
#7  nxtask_exithook (tcb=0x10837e10, status=status@entry=0, nonblocking=nonblocking@entry=0 '\000') at task/task_exithook.c:677
#8  0x10803438 in exit (status=0) at task/exit.c:96
#9  0x1080341c in nxtask_start () at task/task_start.c:151
#10 0x00000000 in ?? ()
(gdb) thread 2
[Switching to thread 2 (Thread 2)]
#0  0x10802eb0 in spin_trylock_wo_note () at semaphore/spinlock.c:178
178       return SP_UNLOCKED;
(gdb) where
#0  0x10802eb0 in spin_trylock_wo_note () at semaphore/spinlock.c:178
#1  0x10802638 in irq_waitlock (cpu=1) at irq/irq_csection.c:137
#2  0x10802734 in enter_critical_section () at irq/irq_csection.c:345
#3  0x10806154 in ramlog_addchar (priv=priv@entry=0x10829130 <g_sysdev>, ch=ch@entry=97 'a') at syslog/ramlog.c:230
#4  0x10806478 in ramlog_putc (ch=97) at syslog/ramlog.c:749
#5  0x10814c48 in syslogstream_putc (ch=<optimized out>, this=<optimized out>) at syslog/syslog_stream.c:174
#6  syslogstream_putc (this=0x1082fb8c <g_irqstack_alloc+4004>, ch=97) at syslog/syslog_stream.c:130
#7  0x10806d60 in vsprintf_internal (arglist=0x0, numargs=0, ap=..., fmt=<optimized out>, stream=0x1082fb8c <g_irqstack_alloc+4004>) at stdio/lib_libvsprintf.c:909
#8  lib_vsprintf (stream=0x1082fb8c <g_irqstack_alloc+4004>, stream@entry=0x1082fb84 <g_irqstack_alloc+3996>, fmt=fmt@entry=0x10820de6 "%s: cpu = %d, irq %d.\n", ap=...) at stdio/lib_libvsprintf.c:1278
#9  0x10814c1c in nx_vsyslog (priority=priority@entry=3, fmt=0x10820de6 "%s: cpu = %d, irq %d.\n", fmt@entry=0x10807434 <vsyslog+36> "\f\320\215\342\004\360\235\344T\221\202\020\016", ap=0x1082fbac <g_irqstack_alloc+4036>, ap@entry=0x1082fba4 <g_irqstack_alloc+4028>) at syslog/vsyslog.c:148
#10 0x10807434 in vsyslog (priority=priority@entry=3, fmt=fmt@entry=0x10807434 <vsyslog+36> "\f\320\215\342\004\360\235\344T\221\202\020\016", ap=<EMAIL_ADDRESS>at syslog/lib_syslog.c:84
#11 0x10807458 in syslog (priority=priority@entry=3, fmt=0x10820de6 "%s: cpu = %d, irq %d.\n") at syslog/lib_syslog.c:116
#12 0x10800dd8 in arm_decodeirq (regs=0x10833c28 <g_cpu1_idlestack+1832>) at armv7-a/arm_gicv2.c:397

As you can see, the thread2 running on cpu#1 is in interrupt context.
However, as @patacongo pointed out, enter_critical_section() processes as if it were in normal tasking environment, because _err() was called before setting CURRENT_REGS.

As you can see, the thread2 running on cpu#1 is in interrupt context.
However, as @patacongo pointed out, enter_critical_section() processes as if it were in normal tasking environment, because _err() was called before setting CURRENT_REGS.

That is not expected to work.  That is a coding error that should result in a crash or a hang or other fatal consequence.

If you move the __err to _arm_doirq() after CURRENT_REGS is set, it may work.

I've just revert the patch which @xiaoxiang781216 attached and added the following code.
--- a/arch/arm/src/armv7-a/arm_doirq.c
+++ b/arch/arm/src/armv7-a/arm_doirq.c
@@ -91,6 +91,14 @@ static inline uint32_t *_arm_doirq(int irq, uint32_t *regs)

   CURRENT_REGS = regs;

+#if 1
+  int cpu = up_cpu_index();
+  if (cpu != 0)
+    {
+      _err("cpu = %d, irq %d.\n", cpu, irq);
+    }
+#endif
+
   /* Deliver the IRQ */

Actually hello app works on qemu. (smp and ostest apps also work)
qemu-system-arm -M sabrelite -smp 4 -kernel ./nuttx/nuttx -nographic -s
ABCDGHIJKNOPQ

NuttShell (NSH) NuttX-8.2.0
nsh> dmesg
_arm_doirq: cpu = 1, irq 1.
_arm_doirq: cpu = 2, irq 1.
_arm_doirq: cpu = 3, irq 1.
nsh> hello
Hello, World!!
nsh> dmesg
_arm_doirq: cpu = 1, irq 2.

@masayuki2009 and @patacongo thank for the explanation.
Maybe we can change up_interrupt_context to check the hardware status bit instead of CURRENT_REGS, then syslog can be called in any point, but it is another story.

Maybe we can change up_interrupt_context to check the hardware status bit instead of CURRENT_REGS, then syslog can be called in any point, but it is another story.

That might be much more compilicated than you think.  You should study the probleml before jumping into an unnecessary, alternative solution.  Nothing is broken.
Whenever, up_interrupt_context() returns true, the code also assumes that CURRENT_REGS is non-NULL.  That is the accepted semantics.  Those two things cannot be easily separated.  up_assert() is a good example.  In the interrupt context, it needs the CURRENT_REGS.  These are probably other less obvious dependences.
Also, high priority, nested, zero latency interrupts worked very differently.  They are not treated as interrupts at all.
I think this is not a good idea.  It is, at least, not something that you should do impulsively or without some significant analysis of the consequences.


add dynamo db adapter

Feature:

Adds new driven adapter for aws dynamodb
Creates default config for aws services

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[move-prover] Add the MVP_TEST_INCONSISTENCY to cargo test -p move-prover

This PR adds the MVP_TEST_INCONSISTENCY flag to the cargo test for Prover

To check the inconsistency during the unit test for Prover, use the following command:

MVP_TEST_INCONSISTENCY=1 cargo test -p move-prover

Running time measured from a experiment on a local Macbook machine (using the default value of cores (i.e., 4))

Without the "MVP_TEST_INCONSISTENCY flag

53s when "T=20", "T=40" and "T=80"

With the "MVP_TEST_INCONSISTENCY=1" flag

4m 39s when "T=20"
7m 10s when "T=40"
12m 32s when "T=80"

Motivation
Inconsistency check in CI
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test
MVP_TEST_INCONSISTENCY=1 cargo test

/land


Auto-converting paths between Windows and Linux

Code of Conduct

[X] I agree to follow this project's Code of Conduct

What would you like to see changed/added?
It would be nice if you could easily convert paths from Windows to WSL / Git Bash.
My idea for the format would look like this:
env:
  - name: POSH_THEME
    value: C:\Documents\theme.omp.yml
    convertPath: true

Converting backwards is probably not necessary, since this feature would mostly benefit Windows users, who'd probably write their Aliae configs with Windows in mind anyway. Plus, I think it would even be possible to convert backwards very easily.
Windows path can be converted to Linux via /mnt/c (WSL) or /c (Git Bash). You could check for the existence of the directories to detect which to use. Note that the drive letters become lowercase. This also only supports fixed drives, not network shares.
This would also be nice in combination with #31 to automatically converts lists of paths.

@RuiNtD I don't see why we'd need to add a switch to this. You can do this automatically as C:\ will never work on WSL and Git Bash.

Because you can't just assume every value in ENV should be converted if the program thinks it's a path. That creates a lot of edgecases. Default behavior should be that the Env is set to exactly what the user typed.


No API key in preferences.

When clicking the 'copy-shorturl' icon, "No API key in preferences" message is displayed. What is the meaning of this message and what action do I take to correct?
I'm running Firefox 68.0 on Windows 10 Home 1903.

Oops! My bad. I overlooked 'Bitly Generic Access Token (Generate an API key with Bitly)' on the options page. Not a bug!

Oops! My bad. I overlooked 'Bitly Generic Access Token (Generate an API key with Bitly)' on the options page. Not a bug!

Oh glad you found the problem! Hope you enjoy the add-on otherwise!!


Update PSPDFKit for Android version to 6.1.1

Details
With 6.1.1 being released we should update the wrapper to use the latest version.
Acceptance Criteria

[ ] Wrapper uses PSPDFKit for Android 6.1.1 by default.

Superseeded by https://github.com/PSPDFKit/PSPDFKit-Cordova/issues/22


Predicate returns nothing in this situation

JDK 11
QueryDSL 5.0.0
MySQL 8
Spring Boot 2.7.0
##Overview
I have two models, User and Tunnel.
Currently, the only user signed up in the system has no tunnel, ie: tunnel = null.
@Entity
@Table(name = "users")
public class User  {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @SequenceGenerator(name = "model", sequenceName = "")
    @Column(name = "id")
    private long id;

    @Column(name = "username", nullable = false, length = 512, unique = true)
    private String username;

    @Column(name = "password", updatable = true, nullable = false)
    private String password;

    @ManyToOne(cascade = CascadeType.REFRESH, fetch = FetchType.EAGER, optional = true)
    @JoinColumn(name = "tunnel_id")
    private Tunnel tunnel;

    @ManyToMany(fetch = FetchType.EAGER)
    @Fetch(FetchMode.JOIN)
    @JoinTable(
            name = "users_roles",
            joinColumns = @JoinColumn(name = "user_id"),
            inverseJoinColumns = @JoinColumn(name = "role_id"))
    private Set<Role> roles = new HashSet<>();
}

@Entity
@Table(name = "tunnels")
public class Tunnel {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @SequenceGenerator(name = "model", sequenceName = "")
    @Column(name = "id")
    private long id;

    @Column(name = "name_company", nullable = true)
    private String nameCompany;

    @JsonIgnore
    @OneToMany(fetch = FetchType.EAGER, cascade = CascadeType.ALL)
    @JoinColumn(name = "tunnel_id")
    private List<User> users = new ArrayList<>();
}

Observed vs. expected behavior
The predicate query RETURNS NOTHING when I search for user.tunnel.nameCompany or if I use any variable of tunnel.
The following restful URL on the project demonstrates it:
    @RequestMapping(value = {"/sys-admin/search"}, method = RequestMethod.GET)
    public ResponseEntity<Object> search() {

        //Could be a request parameter
        String keyword = "kenoby";

        QUser user = QUser.user;

        BooleanExpression predicateKeywordSearch
                = user.username.contains(keyword)
                        .or(user.tunnel.nameCompany.contains(keyword));

        return new ResponseEntity<>(repository.findAll(predicateKeywordSearch), HttpStatus.OK);

    }

Basically, when I add the user.tunnel to the predicate, it simply doesnt return any results anymore. because the only user that is signed has no tunnel, ie: tunnel = null.
Also, after debugging a bit Ive noticed hibernate add's a cross join to tunnels everytime I add tunnels to the predicate. Like this:
Hibernate:
    select
        user0_.id as id1_2_,
        user0_.password as password2_2_,
        user0_.tunnel_id as tunnel_i4_2_,
        user0_.username as username3_2_
    from
        users user0_ cross
    join
        tunnels tunnel1_
    where
        user0_.tunnel_id=tunnel1_.id
        and (
            user0_.username like ? escape '!'
            or tunnel1_.name_company like ? escape '!'
        )

sql = "select user0_.id as id1_2_, user0_.password as password2_2_, user0_.tunnel_id as tunnel_i4_2_, user0_.username as username3_2_ from users user0_ cross join tunnels tunnel1_ where user0_.tunnel_id=tunnel1_.id and (user0_.username like ? escape '!' or tunnel1_.nome_empresa like ? escape '!')"

hql = "select user\nfrom br.kenoby.models.User user\nwhere user.username like ?1 escape '!' or user.tunnel.nomeEmpresa like ?2 escape '!'"

With the help of a few friends, we made a project that exemplifies the situation :
https://github.com/KenobySky/BugQueryDSL

It's not a bug in Querydsl, as from your attached HQL it is obvious that Querydsl generates the right HQL query. You use an implicit join in Querydsl, and it's correctly represented as implicit join in the HQL. The SQL generation is done by Hibernate. Whether it is a bug there depends on how JPA mandates implicit joins are handled. Perhaps it is a bug in (some version) of Hibernate, or the spec simply mandates that implicit joins are inner joined. If you do need an outer join however, just join explicitly, like so:
     .leftJoin(user.tunnel, tunnel)
     .where(user.username.contains(keyword).or(tunnel.nameCompany.contains(keyword))


Continue on DNS lookup failure

Today, a single failed DNS lookup prevents the client from connecting to the Zookeeper cluster.  In other words, it should ignore the failure and try connecting to the rest of the nodes.
@samuel for review

Coverage increased (+0.05%) to 80.117% when pulling 5b19c57fe01abcd499d0cc1e9c4e1d3b83aa64af on JamesOwenHall:master into c4fab1ac1bec58281ad0667dc3f0907a9476ac47 on samuel:master.

This is the same as https://github.com/samuel/go-zookeeper/pull/188. @jdef had a reasonable concern that this new behavior would never try to connect to the dead node again. So https://github.com/samuel/go-zookeeper/pull/191 instead implemented a retry loop to periodically trying to add the dead node back to connect string list.

Good point. I'll close in favour of those.


Update set-up.md

Removed link to DA portal to prevent users who find the docs from being able to onboard
Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
Fixes #Issue_Number (if necessary)

@zdvorak : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.

Thanks @zdvorak.
There's also a link in the tutorial. Can you make that edit as well?
When you make the commit for that, if you add it to the same branch as this pull request (patch-1), then it will automatically get added to this pull request. Not a big deal to do a separate branch and separate pull request if that's easier for you.
Let me know if you have any questions.

@aczechowski Done!

@zdvorak hm, not seeing the change. I know you're travelling right now, so I'll insert that other change myself just to get this published.

#sign-off
p.s. @zdvorak as a Microsoft FTE, in the future, please use sccmdocs-pr repo. Use the same process, just after you click Edit on the article, switch the URL to sccmdocs -pr. 😃


Add documentation for latesthttpresponse in Send External Object action

Please refer this PR: https://github.com/mendix/docs/pull/4596, this one is based on outdated development


fix: fix build configuration

fix build configuration
PR summary

Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[X] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Compute slopes

Codecov Report
Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (407ff1a) to head (a6539b5).

Files
Patch %
Lines

src/PiecewiseLinearFunctions.jl
0.00%
8 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   89.83%   85.94%   -3.89%
==========================================
  Files           2        2
  Lines         177      185       +8
==========================================
  Hits          159      159
- Misses         18       26       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ClaimAffinity bugfix + UTs

Bugs this patch should fix:

Claim/Release claims/releases one block less than requested (off by one)
largerThanBlock always returns true for most cases
ClaimAffinity doesn't return failed blocks when one IP is claimed in a block, also it returns wrong claimed blocks

Test cases (ClaimAffinity):
Test 1: claim affinity for an unclaimed IPNet of size 64 - expect 1 claimed blocks, 0 failed and expect no error.
Test 2: claim affinity for an unclaimed IPNet of size smaller than 64 - expect 0 claimed blocks, 0 failed and expect an error error.
Test 3: claim affinity for a IPNet that has an IP already assigned to another host.

Assign an IP with AssignIP to "host-A" from a configured pool - expect 0 claimed blocks, 0 failed and expect no error.
Claim affinity for "Host-B" to the block that IP belongs to - expect 3 claimed blocks and 1 failed.

Test 4: claim affinity to a block twice from different hosts.

Claim affinity to an unclaimed block for "Host-A" - expect 4 claimed blocks, 0 failed and expect no error.
Claim affinity to the same block again but for "host-B" this time - expect 0 claimed blocks, 4 failed and expect no error.

LGTM - @gunjan5 could you please squash and merge?


hotfix with NPC not throwing on collision with player

hotfix with NPC not throwing on collision with player it will wait 1 second and throw

This works for now! I'll add a backlog issue to add additional options for this behavior.
Just as a note, it will be a low priority for a good amount of time while other more important features and bugs are worked on

Additional context: This changes the behavior of NPC to player collisions. Throwing is now the default state
If no recognizable player action is queued, the NPC will be thrown after a short delay of "holding" the NPC.
The current plan is to let a method define the default behavior in the future and let a parameter define when the throw takes place. Immediately, after a delay, etc...


Invalid Phone Number

I send some message to my private work number, the number is just 4 number

Ah sorry I don't see the skipPhoneValidation I'll be closed!


fix:[CORE-1879] create default region as us-east-1 for sdk client in policy rule

Description

for all the assetTypes which are not region specific, we added "global" as the default region
issue: aws sdk client doesn't have an enum "global" expected when creating the client, so it fails
fix: for assetType account, the default region was given as "us-east-1" which comes from cf_PolicyParams. Since, "global" was used as alternative for UI, we are fixing this by setting the default region if the region of the account is null/global

Problem
aws sdk client doesn't have an enum "global" expected when creating the client
Solution
setting the default region from cf_PolicyParams if the region of the account is null/global
Fixes # (issue if any)
policy "Enable AWS Config service"
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Chore (no code changes)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

[ ] replicated the issue by running the policy in local.
[ ] applied the fix and ran the policy. It was able to create the aws sdk client.

Checklist:

[ ] My code follows the style guidelines of this project
[ ] My commit message/PR follows the contribution guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Other Information:
List any documentation updates that are needed for the Wiki

After fix, the aws sdk client was created successfully


Event afterupdate?

Hello, guys.
I trying to do some work after update event, but I found that Riot tag support only mount, unmount, update and no event to handle DOM structure after update.
Here is example what I trying to do:

This div showed only if fileName have not empty value. I do not want to add style="background-image: url(/images/{ fileName })" because browser send wrong request when fileName have empty value.
That why I trying to catch element after update and set image by manipulate styles.
self.on('update', function() {
  var imagePreviewEl =  self.root.querySelector('.form-image-preview');
  console.log(imagePreviewEl); // null because event update fired before dom is updated
  if (self.fileName) {
    imagePreviewEl.style.backgroundImage = 'url(\'/images/' + self.fileName + '\')';
  }
});

Maybe I should do this in another way?

Could someone update the documentation since there is a trigger event called 'updated', it's just not in the docs.
In your tag definition you can do:
this.on('updated', function(){
    // Whatever you want to do after the update
});

@AndreasHeintze you are right we need to update the doc. Would you be interested in making a new pull request?

Cool, guys! You are stars! I can help with update docs, but I'm Riot beginner and have low skills in English. So I can prepare Pull request with one change to this doc https://github.com/muut/riotjs/edit/master/doc/api/tags.md:

"update" – right before the tag is updated. allows recalculation of context data before the UI expressions are updated.
- "updated" – right after the tag is updated. allows do some work with updated DOM
"mount" – right after tag is mounted on the page
"unmount" – after the tag is removed from the page

Thanks @jails

I sent pull request (https://github.com/muut/riotjs/pull/642) to dev branch.


fix SolidErrors.send_emails? that always returns true

Currently SolidErrors.send_emails? always returns true, even when disabled in configuration 👇🏻
config.solid_errors.send_emails = false

I think following condition has wrong default:
def send_emails?
  @send_emails ||= ENV["SOLIDERRORS_SEND_EMAILS"] || @@send_emails || true
end`

Excerpt from README:
If you have not set `send_emails` to `true` or have not set an `email_to` address, Solid Errors will not send any email notifications.

This PR fixes this.

Released version 0.4.3 now with this improvement


Sometime the axis shows negative value when all the data value are positive

Likely due to the error bar

geom_jitter gives padding on Y axis. Use  geom_jitter(height = 0) as default


Fix hostplumber v0.5.4

Stick to Alpine 3.16 in Hostplumber : Backport to v0.5.4 branch
Reason : Hostplumber build uses libexecinfo and libexecinfo-dev which has been removed in Alpine 3.17 - build fails in Teamcity with higher version of Alpine
https://github.com/DataDog/dd-trace-php/issues/1824
TODO: Can look into workarounds later to be able to support alpine 3.17 or higher
YMMV : https://github.com/awslabs/aws-lambda-cpp/issues/124#issuecomment-1829207396
Teamcity builds :

luigi-plugins : https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9ComponentsForKubernetes_LuigiPlugins/3167489

hostplumber : https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9ComponentsForKubernetes_Hostplumber/3167492

This should fix the lack of libexecinfo-dev. (Not sure about libexecinfo) : https://github.com/aws/aws-lambda-nodejs-runtime-interface-client/issues/68#issuecomment-1571877109


Help with making a screenshot

Hello,
I'm trying to create a screenshot of a graph. For this, I capture handles to the various canvases that sigma.js creates and I render them onto a new canvas, for which I then capture the image/png.
My fragment code looks like this:
precision mediump float;

// our 3 canvases
uniform sampler2D u_edges;
uniform sampler2D u_edgeLabels;
uniform sampler2D u_nodes;
uniform sampler2D u_labels;
uniform sampler2D u_hovers;
uniform sampler2D u_hoverNodes;
uniform sampler2D u_mouse;

// the texCoords passed in from the vertex shader.
// note: we're only using 1 set of texCoords which means
//   we're assuming the canvases are the same size.
varying vec2 v_texCoord;

// This is a helper function: return color from_, but when it's
// transparent, return to_.
vec4 or_transparent(vec4 from_, vec4 to_) {
     if(from_.a == 0.0) {  // is transparent, use to_
         return to_;
     } else {
         return from_;
     }
}

void main() {
     // Return overlay in this order: mouse, hoverNodes, hovers,
     // labels, nodes, edgeLabels, edges.
     // Ordering here should be the reverse of <canvas> layers on the
     // sigmajs side.
     vec4 tmp_color = texture2D(u_mouse, v_texCoord);  // Look up a pixel from edges canvas.
     tmp_color      = or_transparent(tmp_color, texture2D(u_hoverNodes, v_texCoord));
     tmp_color      = or_transparent(tmp_color, texture2D(u_hovers, v_texCoord));
     tmp_color      = or_transparent(tmp_color, texture2D(u_labels, v_texCoord));
     tmp_color      = or_transparent(tmp_color, texture2D(u_nodes, v_texCoord));
     tmp_color      = or_transparent(tmp_color, texture2D(u_edgeLabels, v_texCoord));
     tmp_color      = or_transparent(tmp_color, texture2D(u_edges, v_texCoord));

     gl_FragColor = tmp_color;
}

As you see it's nothing special, just render nodes in the reversed order that the canvases show up (taking into account the alpha channel).
Anyways, my question is this: under Firefox I don't get any nodes. Edges, labels, even hover, is fine. However no nodes. Under WebKit (be it Chromium or Brave) I get a proper screenshot.
Does anyone know what could be the issue here?

Hello @CGenie, did you try this from the png-snapshot example?

This works indeed and doesn't need webgl rendering, thank you!


How can i add subtitles?

HI,
i cant figure out how to show or add subtitles(SRT)?
Thanks.

+1 In our case WebVTT is the preferred format but that shoudl work on iOS,Android and UWP anyhow pretty easily.
I have code for UWP if it helps anyone working on this.

@JohnGalt1717 can you post your code here, or make a PR?


Zoom support.

Hey, I've added zoom support for both Camera and Camera2.
Feel free to use it as inspiration for future releases :)

Wow, that's... extensive! :-)
Just to confirm that I'm reading it correctly, you're going the pinch-zoom route for controlling the zoom level, right?
Many thanks!

That's right.
ScaleGestureDetector checks pinch-zoom => EventBus sends a ZoomEvent to CameraController => CameraEngine handles zoom :)

I'll definitely look at this and use it as a source of implementation suggestions. Issue #18 is the tracking issue for official zoom support, in case you want to keep an eye on it.
Thanks again!

OK, the next update to this library will contain zoom support. I have checked in code that handles this for the ClassicCameraEngine (and general support). I hope to add support for CameraTwoEngine before release.
There are some noteworthy differences in how I approached it versus your pull request:

It is opt-in. There is a zoomStyle() method on the CameraActivity.IntentBuilder that you need to call to enable zoom.

It supports either pinch-zoom or a SeekBar, via ZoomStyle.PINCH and ZoomStyle.SLIDER. Personally, I don't like pinch-zoom.

I am using the smooth zoom APIs on the original Camera class, where available. Or at least, in theory I am, as it seems like most devices don't support that.

My pinch and SeekBar code is on the fragment, not the activity.

So, stay tuned to issue #18 for the rest. And, once again, even though I am about to ruthlessly close it, thanks for the pull request!


Using /// breaks markdown headings

Using markdown headers within a doc-comment does not render the header correctly. This is very similar to https://github.com/lawmurray/doxide/issues/38 in that using /** ... */ works but /// does not but for the header instead. Below the same example code as in that case.
namespace example {

/** First function
 *
 * This one uses block comments and multiple paragraphs and such can be used.
 *
 * #### Example
 *
 * ```c++
 * first();
 * ```
 */
void first();

/// Second function
///
/// This one uses single-line comments and the paragraphs are broken.
///
/// #### Example
///
/// ```c++
/// second();
/// ```
void second();

} // namespace example

This renders the header correctly for first but not for second. From what I can see, the only difference in the rendered markdown is an extra space before the markdown in the instance that doesn't work.

Thanks for the report @grantroch. I've reproduced this and am looking into it.

A little more testing to come, but generally have this fixed now along with other related issues (e.g. admonitions had similar problems).

Thanks again for this report @grantroch . Fixes our now incorporated into v0.4.5 and released.

Thank you, @lawmurray!


How to set datetimepicker range title with variables

I want to set variable in place of range JSON key (titles). Like
ranges: {
today : [moment(), moment()],
yesterday : [moment().subtract('days', 1), moment().subtract('days', 1)],
lastSevenDays : [moment().subtract('days', 6), moment()],
lastThirtyDays : [moment().subtract('days', 29), moment()],
thisMonth : [moment().startOf('month'), moment().endOf('month')],
lastMonth : [moment().subtract('month', 1).startOf('month'), moment().subtract('month', 1).endOf('month')]
}
There all keys are variables. And i want the values of that variables to show...

Hey, you might be interested in this library for working with range in moment: https://github.com/gf3/moment-range

No, Let me clear it again.
I set variable for ranges like
var today = 'Today';   // For english
var today = '(today in french)';  // For french
means i use "today" variable to display title in different languages. But jquery fetch variable "today" as title in dropdown. Not value of that variable.


Add wildfly dependent maven

Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_Sandbox/162/console
Install dependent maven and there are other test failures. Keep it as disable.


platforms: fix linking for Snapdragon

The Qurt side doesn't have the time symbols with the px4_ prefix.
Fixes #11110.

These declarations were always needed for Qurt, I just had removed them by mistake. The definition come in somehow through dspal.
I suppose correct would be to include:
https://github.com/ATLFlight/dspal/blob/master/include/unistd.h
https://github.com/ATLFlight/dspal/blob/master/include/dspal_time.h

@dagar turns out these declarations were already available, see 5e0e2d1c2c31b9a0a642ca34dfd8334ee84af3df.

Even better!


Disputing: scalar invalid outcome doesn't activate submit

when user selects invalid for scalar market it needs to activate the button

this has been fixed


make fedora-e2e prow job as optional

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/retest

/hold

/retest

/retest

@vjayaramrh maybe we can close this one

/retest

@vjayaramrh maybe we can close this one

ok, I will close it


Understanding more about patterns, please?

I'm trying to figure out how the following problem should be solved:
I have a Bank entity.
Users of the system could be customer, manager, director or just a bank operator.
All of them will be a customer too, because to work on a bank, you should have an account.
So, should all of them implements ICustomer?
Should I have IManager which implements ICustomer? (always expanding my class, never changing it as OCP said).
Thanks guys

Hey @leandrofagundes, considering the information you provided it is right. But I would need more input to design something like that correctly.

I guess it's much more about when the customer is using the system, no matter (during a use case for Customer) if he is a manager or anything else.
He will need to generate the loan, open a new window (for a new use case, now as a manager) and execute the loan approval.
Probably there is another interface needed, like a person (under customer and manager), and not the manager implementing customer directly.
Just trying to create situations. I'll try to take time and courage to open a change with something like that and send to you a PR, so you can validate the idea. Courage, first!


fixed integer overflow when wrapping integer param

Thanks for the submission. On brief inspection it looks very reasonable, though I'm a little hazy on the implementation details. However, a little more detail would be appreciated. An example (or better still a test) showing where bug-free code resulted in an overflow would be really helpful.

Ah sorry, I haven't provided any details, please take a look at this example code chunk:
cnl::scaled_integer<int64_t, cnl::power<-20, 2>> number;
number = 10000;
std::cout << number << std::endl;
I encoutered an issue where the output is "1808" instead of "10000". the discrepancy occurred because during conversion, the result type was not convert to "int64_t", but remains as "int", causing an overflow in the result after scaled.
My submission tried to fix this issue.

Thank you for your response.
Perhaps it's just that our priorities are different; I'm more concerned about the API not having too many hidden issues in its usage.
Going back to my example, if the code were
number = 10000ll
or
number = (int64_t)10000,
there wouldn't be any problems. However, in practical use, explicit conversions like these are often overlooked. Your consideration also makes sense, but whether to convert to a wider type depends on the Represent Type(Rep template parameter) chosen at the time of definition. From my perspective, converting the input to the Represent Type also makes logical sense.
The above are just some of my suggestions. If you believe no changes are needed, I will close my Pull Request later.
Thank you.

@celestialkylin thanks again for the feedback.
I would argue that your priorities are served by CNL, but not served by scaled_integer in isolation. Early in the design of that API (when it was called fixed_point), it became apparent that while fundamental integers make it possible to represent fixed-point values, that there were some 'share edges', so to speak.
Out-of-range errors (sometimes resulting in overflow) are a much greater problem with fixed-point arithmetic when:

the range of the underlying type is saturated (think π with only 2 integer digits), or
a scaling conversion from one exponent to another occurs.

Both of these are exacerbated when combined with narrowing casts, which are sometimes implicit.
It's usually possible to design an API with a 'wide contract', i.e. one where results of all usage are defined. But sometimes, this involves is a tradeoff where quality is lower by some other measure, e.g. performance.
I'm fairly confident that different target users have contrasting priorities here, and I don't want to exclude any user in favour of any other - hence you need to use the correct type for managing overflow (which may sometimes be slower) in composition with the correct type for scaling integers.
For further details, see the question,

Q: Why doesn't cnl::scaled_integer prevent/avoid/detect overflow?

from the fixed-point overflow section of the FAQ.


remove velodyne ring artifacts from lazerscan

"Looks good to me" - Ryan Liao 4253B, Vex Media Relations


Can't set standalone presets in HA 2024.04.3

I'm trying to:
Set temperatures for not central managed thermostat.

As you can see, HA won't set it, because of a type issue. I tried with 23,0 and 23.0 but getting the same issue. Also tried to modify the values directly for the entities, but the issue is the same.
I installed your integration yesterday for 2024.04.2 and I was able to set presets for the central component. Today after the update I tried to create a new thermostat with it's own presets, but I run into this issue.

Hello @chriske ,
I will try with 2024.04.2 to see if something change. It keep you in touch.
What is not normal in your screen copy, is that all temperature are empty. And because the error log says "NoneType" I guess you try to send an empty temperature on some Number entity.
Maybe you can try to put some value to all other temperature.

Hello @chriske ,
I will try with 2024.04.2 to see if something change. It keep you in touch. What is not normal in your screen copy, is that all temperature are empty. And because the error log says "NoneType" I guess you try to send an empty temperature on some Number entity.
Maybe you can try to put some value to all other temperature.

Hi! Thanks for the response! I tried to populate every input but I'm getting the same issue for every one.

Hello, I have tested with HA 2024.4.3 and all is working fine on my side. Something went wrong on your environment (all temperature are empty which is not possible). I suggest to check logs. There is surely some messages explaining what goes wrong.
I will close the issue because it is not a VTherm issue but please post the logs messages here when you have.

Hi there!
Thanks for checking!
Here are the logs when I try to set any temperature:
2024-04-16 18:30:38.074 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140282818477248] float() argument must be a string or a real number, not 'NoneType'
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
response = await hass.services.async_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2543, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2580, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 971, in entity_service_call
single_response = await _handle_entity_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1043, in _handle_entity_call
result = await task
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/number/init.py", line 112, in async_set_value
await entity.async_set_native_value(native_value)
File "/config/custom_components/versatile_thermostat/number.py", line 462, in async_set_native_value
old_value = float(self._attr_native_value)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: float() argument must be a string or a real number, not 'NoneType'
As far as I can see, the exception's origin is the number.py class

One more clue:
I tried to create a new VTherm, and now I choosed to not use the min and max temperatures from central config. Now my temperatures are populated and I can change them:

Ooooh this is a great news.
What do you mean by " I choosed to not use the min and max temperatures from central config" ?
Can you send me screen copy of how you do that (because it seems related to the issue) ?

I changed my previously posted VTherm's settings to not copy the central temperatures

Does that means that you uncheck this checkbox (in french sorry) ?

Ooooh this is a great news. What do you mean by " I choosed to not use the min and max temperatures from central config" ? Can you send me screen copy of how you do that (because it seems related to the issue) ?

I changed my previously posted VTherm's settings to not copy the central temperatures

Does that means that you uncheck this checkbox (in french sorry) ?

Exactly :) thanks!

And for the min/max what have you done ?

These are my settings for the central configuration:

This was not my question. You said, you have done something with the min and max temperature. For me they are defined here:

But maybe there is a misunderstanding somewhere.

Yes, it seems we misunderstood each other somewhere. So, I will summarize everything I have done:
First, I created a central configuration where I set up the outdoor thermometer, the minimum and maximum temperatures, and the step. To the presets created this way, I set the appropriate temperatures. After that, I made 2 VTherms, of the climate type, and set each to use the central configuration. These are working nicely. Following that, I created a third VTherm, for which I set that I wanted to define my own presets, but I left the "use additional central configuration" switch turned on in the underlyings menu. If the new VTherm is created this way, then I cannot set the temperatures for the presets, that’s when I get the above exception. If I turn off "use additional central configuration" afterwards, then I can set the temperatures in the presets created for the VTherm.
This is how it works:

Hello,
I'm facing the same issue, and I did two videos to try to explain the behavior.
TLDR: if you do select "Use additional central main configuration" when creating a device, you won't be able to use device specific presets afterwards.
https://github.com/jmcollin78/versatile_thermostat/assets/2236444/3e9acabf-0137-4659-a259-ce0022099c65
https://github.com/jmcollin78/versatile_thermostat/assets/2236444/672d8488-579d-4174-ae52-496d2cdaed7a

Hello,
I'm facing the same issue, and I did two videos to try to explain the behavior.
TLDR: if you do select "Use additional central main configuration" when creating a device, you won't be able to use device specific presets afterwards.
https://github.com/jmcollin78/versatile_thermostat/assets/2236444/b3e2c143-552a-46e8-80ee-ad3244689e54
https://github.com/jmcollin78/versatile_thermostat/assets/2236444/7dadf402-e40e-4fe9-a906-79dbf264a316

Thanks @brunoleon for the reproduction case. I will able to reproduce and to fix now !

https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.2.3

Thank you for the fix and your support!


Implement a "--patch" argument

For who is trying to install specific old versions of nodejs on FreeBSD will face the issue #900.
However there is a good workaround to help the FreeBSD users to install it still using the nvm, it receive the list of patchs files and apply it after the checksum check.
For example:
--patch="file1.patch","file2.patch"

It's a bit manually but make it a lot easier, for example, I'm developing a shell script for a project and I've changed it to work on FreeBSD too, With that implementation I can instruct to download the patchs and apply on nvm or I can do it by myself through shell script.

So this would be a special argument to nvm install that would only apply in source mode (like -j is now)? How would it apply the patch exactly?

Yes, It should be only for source code, the the command would be something like that:
nvm install v0.9.3 --patch="file1.patch","file2.patch"
The script will start normally, download the file, make the checksum check and from there will apply the patch on the nvm source directory (for example: ~/.nvm/src/node-v0.9.3)
the command-line syntax is like that:
patch < file1.patch
patch < file2.patch

the commands above just need be executed in the node src directory (~/.nvm/src/node-v0.9.3)
after applying the patchs just proceed normally.

Is patch part of POSIX?

Not sure, I always use it on all linux that I had, let me google it if I found the answer.

From what I see right now, Linux distributions uses the GNU Patch, there are some notes about the traditional old patch POSIX:
COMPATIBILITY ISSUES
       The POSIX standard specifies behavior that differs from patch's traditional behavior.  You should be aware of these differences if you must interoperate with patch versions 2.1 and earlier, which do not conform to POSIX.

        · In  traditional  patch, the -p option's operand was optional, and a bare -p was equivalent to -p0.  The -p option now requires an operand, and -p 0 is now equivalent to -p0.  For maximum compatibility, use options like -p0
          and -p1.

          Also, traditional patch simply counted slashes when stripping path prefixes; patch now counts pathname components.  That is, a sequence of one or more adjacent slashes now counts as a single slash.  For  maximum  portabil‐
          ity, avoid sending patches containing // in file names.

        · In traditional patch, backups were enabled by default.  This behavior is now enabled with the -b or --backup option.

          Conversely,  in  POSIX  patch, backups are never made, even when there is a mismatch.  In GNU patch, this behavior is enabled with the --no-backup-if-mismatch option, or by conforming to POSIX with the --posix option or by
          setting the POSIXLY_CORRECT environment variable.

          The -b suffix option of traditional patch is equivalent to the -b -z suffix options of GNU patch.

        · Traditional patch used a complicated (and incompletely documented) method to intuit the name of the file to be patched from the patch header.  This method did not conform to POSIX, and had a few gotchas.  Now patch uses  a
          different,  equally  complicated (but better documented) method that is optionally POSIX-conforming; we hope it has fewer gotchas.  The two methods are compatible if the file names in the context diff header and the Index:
          line are all identical after prefix-stripping.  Your patch is normally compatible if each header's file names all contain the same number of slashes.

        · When traditional patch asked the user a question, it sent the question to standard error and looked for an answer from the first file in the following list that was a terminal: standard error,  standard  output,  /dev/tty,
          and standard input.  Now patch sends questions to standard output and gets answers from /dev/tty.  Defaults for some answers have been changed so that patch never goes into an infinite loop when using default answers.

        · Traditional patch exited with a status value that counted the number of bad hunks, or with status 1 if there was real trouble.  Now patch exits with status 1 if some hunks failed, or with 2 if there was real trouble.

        · Limit  yourself  to the following options when sending instructions meant to be executed by anyone running GNU patch, traditional patch, or a patch that conforms to POSIX.  Spaces are significant in the following list, and
          operands are required.

             -c
             -d dir
             -D define
             -e
             -l
             -n
             -N
             -o outfile
             -pnum
             -R
             -r rejectfile

FreeBSD uses their own patch program (probably due to license issue): patch 2.0-12u10 FreeBSD
     --posix
             Enables strict IEEE Std 1003.1-2008 (“POSIX.1”) conformance,
             specifically:

             1.   Backup files are not created unless the -b option is speci‐
                  fied.

             2.   If unspecified, the file name used is the first of the old,
                  new and index files that exists.

STANDARDS
     The patch utility is compliant with the IEEE Std 1003.1-2008 (“POSIX.1”)
     specification, except as detailed above for the --posix option.

     The flags [-BCEFfstVvxz] and [--posix] are extensions to that specifica‐
     tion.

Looking for Mac OSX on internet seems to uses the GNU Patch too: https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man1/patch.1.html
However in my perception, it would not try to be complex, if someone needs to uses some advanced changes this user must do it manually instead of just execute the "--patch"

My concern is that if it's not going to succeed, it should fail - meaning, --patch would need to account for any differences (that won't already cause it to error out).

I think it would affect more the advanced option than just applying the file into a current directory as default options.
I can make tests to make sure it wouldn't fail by different patch applications. But in case the problem isn't caused by the patch application but in user patch file (maybe the user select the wrong patch file) I think it should be throw the error on screen and exit the nvm.
Any other concern?

I agree, if the patch won't complete successfully I would want it to exit nvm and print an error.
I don't think I have any other concerns as long as the feature was accompanied by solid tests :-) PRs welcome!

This is related to #1207.

I'm closing this, since the solution to #1207 should work here.


Update specs2-core to 4.20.3

About this PR
📦 Updates org.specs2:specs2-core from 4.19.2 to 4.20.3
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.specs2", artifactId = "specs2-core" }
}]

labels: test-library-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, commit-count:1

Superseded by #357.


Buttons(Minmize, close etc) are unclickable after leaving the process idle for some time

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Microsoft Windows [Version 10.0.18363.900]
Windows Terminal version (if applicable):
1.0.1401.0
Any other software?

Steps to reproduce
Opened the terminal used it for some time, left it idle for long(working on something else).
Bring the terminal app to focus and click on any of the buttons on the app.
Expected behavior
I should be able to click buttons on the app(new tab, minimize, close etc.)
Actual behavior
Cant click anything on the app. Seen this multiple times.

Are you running PowerToys?

Yes I have PowerToys Running

Great, this is probably #6120 or #3325 - I'm really not sure which one of those threads is the master thread anymore tbh. PowerToys seems to do something strange with Windows Terminal windows, though we haven't tracked it down quite yet.
/dup #3325 #6120


Added hub-spoke topology RA

@telmosampaio,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference-architectures/dmz/trusted-dc-extension.md
:warning:Warning
View
Details

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md
:warning:Warning
View
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/trusted-dc-extension.md

Line 32: [Warning] Invalid file link:(~/reference-architectures/images/vdc-diagram.png).
Line 32: [Warning] Invalid file link:(~/reference-architectures/images/vdc-diagram.png).

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md

Line 64: [Warning] Invalid file link:(~/reference-architectures/hybrid-networking/expressroute-vpn-failover).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

We need to add it to the TOC.

Needs content dev review (whenever it's ready - let me know)

@MikeWasson I asked Peter already to go over it. I'll ask him to hold off until later today, since I am getting a lot of feedback.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@MikeWasson I made changes based on your feedback. Pong.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/vnet-topology-hub-spoke.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/hub-spoke.md
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/hub-spoke.md
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/hub-spoke.md
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/hub-spoke.md
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute-vpn-failover.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/vpn.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/hub-spoke.md
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute-vpn-failover.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/vpn.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/hub-spoke.md
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute-vpn-failover.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/vpn.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/_images/vnet-topology-hub-spoke/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/dmz/images/vdc-diagram.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/hub-spoke.md
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute-vpn-failover.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/expressroute.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke-no-gateway-routing.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spoke.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/hub-spokehub-spoke.png
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/images/vpn.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/hybrid-networking/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix the wrong way

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#15044

Merged. Thanks!


Remove backfill

The file and fallback exporters can also be removed.

(they don't have to be removed in this PR, but it's an option to resolve the missing coverage)

(they don't have to be removed in this PR, but it's an option to resolve the missing coverage)

I'm on it.


[Eloquent] Many to many relation with multi column

I have table relation in MySQL
table: apps
ID
Name

table: clients
ID
Name

And table relationship: app_client
app_id
client_id
version

field 'version' in table app_client is string type
How to create relational tables in MongoDB as containing the version column?
I create table in Mongodb:
table: apps
ID
Name
client_ids => is array: [ObjectID('client_id'), ObjectID('client_id')]

table: clients
ID
Name
app_ids => is array: [ObjectID('app_id'), ObjectID('app_id')]

My Eloquent (Model Client):
    public function apps(){
        return $this->belongsToMany('Model\App', null, 'client_ids', 'app_ids');
    }

But, not column version
Do you know what I mean? How to create column version in database mongodb for Eloquent?

In MySQL + Eloquent, I use $this->belongsToMany()->withPivot();
In MongoDB not used

@Vagabondtq, did you manage to do this with MongoDB?

I am looking into this now and it actually looks like the relationship model for many to many relationship will allow you to pass the attributes field in but it does absolutely nothing with the array.

+1

+1

+1

@jenssegers Could you please explain how can we achieve it or share the documentation link which helps to solve this?

+1


How to Start?

I am a newbie to the IAP world. Can you please guide me to where do I need to register myself for android and iOS to set up my account for this? What keys or information or anything is needed by react-native-iap and where to add it? How does firebase come into the picture? How does one link his bank account? Where does one link his bank account? I understand the usage part of this library but I don't quite understand the pre-requites. Can somebody please help me?

Can you please guide me to where do I need to register myself for android and iOS to set up my account for this?
You'll need to register your own account on Google Play Console and Apple Connect Store, see links below:

Register your account and application on: Google Play Console
Register your account and application on: App Store Connect

What keys or information or anything is needed by react-native-iap and where to add it?

You'll have to register your iOS app for "In-App Purchases" capabilities in Xcode and in Apple Developer Portal.
You'll also have to completely fill out the "Agreements, Tax and Banking" in App Store Connect..

How does firebase come into the picture?

What do you mean?

How does one link his bank account?

Register your bank account to receive royalties on: Google Play Console
Register your bank account to receive royalties on: App Store Connect

I understand the usage part of this library but I don't quite understand the pre-requites. Can somebody please help me?

I strongly recommend to read the following resources to understand the nuances of both Apple IAP and Google IAP, this will give you good insight on all steps needed to be completed to successfully implement IAP into your application (with or without react-native-iap).

https://developer.apple.com/documentation/storekit/in-app_purchase
https://developer.android.com/google/play/billing

@ixuz Do I have to change something in the code before publishing the app to the store? I mean, set an env for production or something like that?
I dind't find that in the docs.
Thank you very much!

@rodrigopasc Is your question "how do I publish a (React Native) app to the store?" That's sort of off topic. However, you just do the normal Android and deployments from within their individual projects. That information is abundantly available.

My problem is with iOS. Apparently it is not generating its receipt. (Only in production, in Test Flight and development works fine)

If you haven't already, you might try setting up a sandbox user https://help.apple.com/app-store-connect/#/dev8b997bee1 That might help you hone in on the problem.

My problem is with iOS. Apparently it is not generating its receipt. (Only in production, in Test Flight and development works fine)

We'll probably need a more detailed explanation of the problem to pinpoint the issue.

Make sure that the purchase flow complete (StoreKit) for the end-user.
When the purchase is completed, transmit it securely to your server.
And if you're dealing with subscriptions, you should handle Real-Time Server Notifications from Apple Connect Store (basically Apple pushing updates to your server without involving the end-user).

I am validating the receipts in my backend, like the Node.js example mentioned in the README.
For Android is working perfectly fine. But iOS, only in production is not generating any receipt.
During development and in Test Flight (the production build) works fine.


ci: improve workflow and fix ut error

Check out the checks below.

Gonna close #1255

Ready to merge.


Fix markdown formatting of bullets

They currently look as follows in the testing section of C++ track doc:

Once the build environment has been created by CMake, you can build your code using the appropriate command for your environment: * Linux with make: make * Windows with Visual Studio 2013: Select Build / Build Solution from the menu. * MacOS with Xcode: Select Build from the toolbar

instead of

Once the build environment has been created by CMake, you can build your code using the appropriate command for your environment:

Linux with make: make
Windows with Visual Studio 2013: Select Build / Build Solution from the menu.
MacOS with Xcode: Select Build from the toolbar

Thanks! There's an ongoing fix in progress at the level of the markdown parser (https://github.com/exercism/exercism.io/pull/2775) but we're stuck on some dependencies.

@kytrinyx oh I wasn't aware. Thanks for the pointer.


License?

I've been looking for a feature-rich renderer to use for one of my projects to quickly show models with some nice lighting and yours is quite complete! Great work with it! I was wondering if you'd consider adding a license (something compatible with MIT) so I could comfortably use it. Of course, your license would be included with my program, should you choose to add one and you'd be properly credited in the program once a credits window was added
I might also need to maintain a fork with some changes to integrate it with my project, though I'd be happy to work out a review stage and submit my changes as pull requests should they be of use to you

Hi. Sorry for late reply. I just added a license. This project is licensed under the MIT License! I hope the project goes well. Thank you.


Add support for EXIF orientation

Some pictures that have an EXIF orientation tag do not appear to be rotated correctly. It would be nice to add support for this so some pictures don't show up sideways.

After working on #109 , this one should be pretty easy

Hi, I guess this is still open right? Should there be a separate preference for EXIF orientation support, roughly like this:

EXIF_ROTATE_DIMEN: "Rotate image according to EXIF tag, if present"
AUTO_ROTATE_DIMEN: "Rotate image to landscape, if EXIF rotation preference is disabled or no EXIF tag is present"

Or do you think it should be combined in one? I would opt for two separate choices.
By the way, correct EXIF orientation handling seems not to be so easy: https://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/ (direct link to github repo with test images: https://github.com/recurser/exif-orientation-examples)


Clicking magnifying glass icon clears text and search results (instead of searching text)

Describe the bug
I noticed there's a few other issues about the search bar on the main site (https://search.freecodecamp.org/) but haven't seen this particular issue mentioned before. Apologies if it's been addressed already.
Clicking on the magnifying glass icon clears the text in the search bar instead of searching for the text entered. The icon even says "Submit the search query." when hovered over. I believe it's UI standard to have clicking the icon as an alternative to hitting Enter on a keyboard, so that's unexpected behavior.
This issue is similar to this one: https://github.com/freeCodeCamp/freeCodeCamp/issues/29311
But I wanted to point out that clicking the icon has a bug too. Once the icon is clicked on, then the search results and search text clear completely.
To Reproduce
Steps to reproduce the behavior:

Go to https://search.freecodecamp.org/
Search any term
Now type in another term in the search bar
Click on magnifying icon

Expected behavior
I would expect a search page populated with relevant results to what I typed into the search bar. The typed in text should still be in the search bar.
Screenshots
If applicable, add screenshots to help explain your problem.
Example of search page before clicking on magnifying glass icon:

Example of search page after clicking on magnifying glass icon:

Desktop (please complete the following information):

OS: macOS 10.13.6
Browser: Chrome
Version: 74.0.3729.169

Can i try to work on this?

@cmgonzales I would hold off as there have already been several PRs merged which fix many issues with the search bar.  The changes are on the master branch, so you can pull it down and get it running locally to test if this new issue exists as stated.  If you can reproduce it on the master branch code, then make sure to search through the other open PRs related to the search bar to make sure someone is not already working on a solution for it.
If you find out the problem reported above does not happen using the master branch code, then let us know and we can close this issue.
Thank you.


The default icon color on the desktop need to be optimized?

Describe the bug
The icon on windows desktop is not clear

To reproduce
by default
Expected behavior
More clear transparent icon
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response

lol with a flat background color and similar to the same color of the icon, it is normal that it is not visible.
You can fix it just by using a different background.

LOL  your idea is ridiculous
another background color

I don't think it's a normal visual effect

lol with a flat background color and similar to the same color of the icon, it is normal that it is not visible. You can fix it just by using a different background.

lol with a flat background color and similar to the same color of the icon, it is normal that it is not visible. You can fix it just by using a different background.

LOL your idea is ridiculous
another background color

I don't think it's a normal visual effect
These are the normal visuals on live tiles with the same background color

Apparently this is only on Windows 10. On Windows 11 it looks normal:

Maybe using the ZIP version would be a workaround

Thank you for your continued attention!
Yep it's workaround.
Windows 10 still has a high market share, so I hope to optimize it if you have time :-)
Thank you for your excellent work, this tool is very useful, I have recommended it to many people!


Inheritance may be a good solution, and not as complicated as it seems

mock_head will still work in this way, and I'll push to the branch later, maybe v2 or any other name.

The v2 branch has been completed, and I will create the v2.1 branch based on v2. The difference is that the nodes that maintain link relationships are not directly pointing to objects, but to nodes that maintain link relationships, the mock_head will still work in this way.

If we want to implement the v2.1 branch, there are some conflicts here, please refer to the following code:
struct isnode {
    struct isnode *right;
};

struct idnode {
    struct idnode *right;
    struct idnode *left;
};

The type of member right in isnode and idnode is different, so I will give up implementing the v2.1 branch.

Everything has been completed, it's time to close this issue!

Everything has been completed, it's time to close this issue!


[BUG] - Use kernel module

Quick question:
What is Backend "Use kernel module"?  How do you activate it?  I've got root, but still cannot toggle.
Thanks for the awesome project!

Never mind, ran across it while mindlessly surfing.
[]https://git.zx2c4.com/android_kernel_wireguard/about/


Add new gpg key for rvm

Cherry-picked from https://github.com/janschumann/puppet-rvm/pull/1

I was hoping this would just be fine cherry-picked from https://github.com/janschumann/puppet-rvm/pull/1, but since tests fail, I'm going to close this for now.


Removed unused code

http://www.wiremod.com/forum/cpu-gpu-hi-speed-discussion-help/8159-emufox-complete-zcpu-zgpu-console-screen-emulator.html - looks like an abandoned project, so okay

I remember EmuFox working brilliantly!

I'd rather see him doing that on the EmuFox side where it belongs. Doesn't look like it's too hard to do anyway.


add that one delegated subnet allowed per Vnet

@b-juche - Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
We'll close this PR. Thank you.


Fix the stack frame being captured

While using captureStack, it is sometimes
very easy to miss capturing the correct stack
frame. This should be correctly checked, by a
non anonymous (named) function.
Fix this and other test cases.

Coverage remained the same at 97.17% when pulling 25c1ac188cb356ae953eecbe39f45aa60299947a on fixStackFrame into 352167ccff99c37f7327166811ab5b657e859a90 on master.


The logviewer does not update the scene correctly in play mode when it reaches the edge of the buffered time range.

When it reaches the end of the buffered time range, the logviewer starts to show the different streams one after another. It should wait for frames is loaded and update the whole scene. Or it should update the stream as the data come but keep the other part of the scene unchanged.

It should wait for new data, i'll have to verify.  If you have a screen capture it would be useful (even if just mock data).
One part of keep the other part of the scene unchanged is worth noting.  XVIZ has a config TIME_WINDOW that defaults to 400ms.  It is a global time window for how long data is shown before we need another sample, otherwise we don't show since we don't know if it is valid any longer.
There are some changes coming both the ability to mark data PERSISTENT as well as a simpler application state management implementation option that simply stores all the streams and shows you them regardless of the TIME_WINDOW. This seems to be what you want.
Stay tuned.


Adding program for Swapping two Linked list nodes using python.

I would like add program for swapping of two linked list nodes in python.
I would like to work on this under KWoC.

Mention problem link

https://leetcode.com/problems/swap-nodes-in-pairs/
@adityabisoi
Can I contribute to this

https://leetcode.com/problems/swap-nodes-in-pairs/
@adityabisoi
Can I contribute to this

Sure, go ahead

https://leetcode.com/problems/swap-nodes-in-pairs/
@adityabisoi
Can I contribute to this

Go ahead

@khushibalyan220101 @Pranav016 I am afraid the repo currently supports only Hackerrank problems. Leetcode problems will be solved only after covering all of HackerRank's problems


Variable used uninitialized in hipDeviceGetAttribute

Clang 8 lets me know of the following:
../hip/nvcc_detail/hip_runtime_api.h:886:9: warning: variable 'cdattr' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
        default:
        ^~~~~~~
../hip/nvcc_detail/hip_runtime_api.h:891:41: note: uninitialized use occurs here
    cerror = cudaDeviceGetAttribute(pi, cdattr, device);
                                        ^~~~~~
../hip/nvcc_detail/hip_runtime_api.h:786:5: note: variable 'cdattr' is declared here
    enum cudaDeviceAttr cdattr;
    ^

Which seems to point to a bug in the implementation of hipDeviceGetAttribute.
I fixed it by changing the default branch to:
        default:
            return hipCUDAErrorTohipError(cudaErrorInvalidValue);

I believe that is the intended behaviour?

@PeterTh Thanks. Did you submit your fix?


parallel computing experiment

I did three different runs below, on different number of timesteps, for 100 timesteps and 1 month, it is successful, but for 1 year, still having the error.

1 spatial unit (5 degree * 5 degree), 7 variables, 100 timestep, on one core. The parameter for parallel execution is the Number of years = 3.

1 compute block (1 spatial unit, 7 variables, 1 month) on 1core. The parameter for parallel execution is the Number of years = 3.

1 compute block (1 spatial unit, 7 variables, 1 year) on 1core. The parameter for parallel execution is the Number of years = 3.

However I did not manage to get the result, it throw the error. Do you know the possible reason? The log file is at /projects/0/einf2480/global_data_Qianqian/slurm-2933096.out

1 spatial unit (5 degree * 5 degree), 7 variables, 100 timestep, on one core. The parameter for parallel execution is the Number of years = 3.

1 compute block (1 spatial unit, 7 variables, 1 month) on 1core. The parameter for parallel execution is the Number of years = 3.

1 compute block (1 spatial unit, 7 variables, 1 year) on 1core. The parameter for parallel execution is the Number of years = 3.

However I did not manage to get the result, it throw the error. Do you know the possible reason? The log file is at /projects/0/einf2480/global_data_Qianqian/slurm-2933096.out

The possible reason why I got the recursion error is the first two run was using the RF model I trained on CRIB which has recursionlimit 3000. I just realized snellius and CRIB has different recursionlimit, snellius is 1000. What I understand is the recursionlimit should depend on the place where you load the model not the place you train the model. But maybe it is not like this, because with the RF model trained on snellius, even to predict 1 month, I got the recursion error. So now I plan to increase the recursionlimit on snellius to 3000 to train the RF model, and then try to predict 1 month first, and then to predict 1 year.

I also tried Feb, also failed because two inputs of Feb are all nan values.

So the 32 hours for 1 year is based on only Jan has data, other months are all nan values in two input variables, line 151 only run for range(745), but 1 years should be 17519. After I make it 17519, it takes longer time to run (every timestep 20 seconds now, 4 seconds with range(745)). So now I am trying to run 6 months to be sure not exceed the timelimit.


DO NOT MERGE 2

Signed-off-by: Victor Seiji Hariki<EMAIL_ADDRESS>

External checks now seem to work! It now checkouts the correct pull head. Will be merging the changes in testing now and closing this pull.


Prepare New Release

Hey,
moved some of the Readmes to the Wiki.
Is there something, we should include to the new release?


Rename Style/DeprecatedHashMethods to Style/PreferredHashMethods

Fixes #3224
As stated by Matz in the discussion in #3224, the methods
Hash#has_key? and Hash#has_value? will not be deprecated. Hence
rename the cop and corresponding messages to not use the word deprecated.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it)
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.

This contradicts his original email with triggered the creation of this cop... But I guess this makes sense.

Probably this should be made configurable as well.

Thanks! Will work on making this configurable.


Build instructions now use GOPATH and build godep

Previously godep was fetched, but not built. Path to it was also not specified.

Please don't merge this. I did not manage to build using updated instructions after all.


[FAR-EDGE] Check for the workload running in apps shared CPU pool with cpu scheduling priority 0

It looks like you've forgotten to add the performance suite to the PR.

@bnshr , can you rebase your change to be able to test your PR in DCI?

@ramperher The DCI job still fails. Can we do something for it?

@ramperher The DCI job still fails. Can we do something for it?

the issue with the volume should be fixed starting tomorrow when updating the DCI packages in our clusters. Now, you can try a rerun when having this issue, I'll do it now

/dci-rerun

/dci-rerun


Android device memory information not available via API?

I'm trying to select a device with a minimum memory requirement however the memory info doesn't appear to be accessible via the API?
{"id"=>118,
 "creditsPrice"=>1,
 "displayName"=>"HTC Desire A8181",
 "frame100Url"=>"https://cloud.testdroid.com/resources/images/devices/htc-desire-h100.png",
 "frame160Url"=>"https://cloud.testdroid.com/resources/images/devices/htc-desire-h160.png",
 "frame400Url"=>"https://cloud.testdroid.com/resources/images/devices/htc-desire-h400.png",
 "frame80Url"=>"https://cloud.testdroid.com/resources/images/devices/htc-desire-h80.png",
 "frameExtraWidth"=>nil,
 "imageHeight"=>279,
 "imageLeft"=>41,
 "imagePrefix"=>"htc-desire",
 "imageTop"=>43,
 "imageWidth"=>168,
 "locked"=>false,
 "online"=>true,
 "osType"=>"ANDROID",
 "softwareVersion"=>{"id"=>7, "apiLevel"=>8, "releaseVersion"=>"2.2.2"},
 "vncSupported"=>false,
 "aroSupported"=>false}

It's under device properties:
https://cloud.testdroid.com/api/devices/118/properties

Thanks!

It might be nice to update device finder to showcase how to select based on RAM. In my experience the devices with lower memory on Android have more problems. I updated the Ruby port I'm using for work.