The documentation should explicitly state makeEwsRequestAsync require an on premise exchange server.

I want to start by saying how disappoint I am in the documentation. This has been long process to discover something that should be explicitly stated at the beginning.
If I am wrong, please let me know.
In my attempt to create an outlook add-in, I became stuck with using the function makeEwsRequestAsync .. After many unanswered git issues and stackoverflow questions, I read the function again to realize that the administrator of the exchange server must invoke an cmdlet command. There should be a method to write the add-in without needing to buy an exchange server, but I decided to play along. I used exchange online to create a new exchange server. I entered my credit card (there only exists a 1 year plan).
When I invoke the cmdlet command to set oauthentication to true. I received a message saying the command does not exist. After finally finding  the documentation on the command, I learned that this command can only be run on-premise exchange server.
I will admit that the responsibility was on me to read the documentation. Still, I feel that the documentation fail to put the necessary requirements to invoke the function at the beginning. There is no connecting link from the first mention of the command makeEwsRequestAsync and the cmdlet command.   The makeEwsRequestAsync and  It should have said "IMPORTANT: makeEwsRequestAsync requires you have on premise exchange server, and to setup an on premises exchange server for testing go here."
Please let me know if there is another way for me to invoke ews command because it seems I have to buy a computer to use the exchange server on premis?

@AlexJerabek Issue transferred!

@rjpruitt16 Could you please elaborate on the issues you faced when you say you were stuck with using the makeEwsRequest function? Were there any errors being returned? What client were you testing the add-in on (outlook for Windows/MAC/OutlookWebApp)?
Exchange server is a requirement for Outlook add-ins to work. Here's a link to the document that outlines the pre-requisites for Outlook add-ins: Outlook add-in requirements.
For reference I'm also adding a link that outlines steps to create and run your first add-in :Build your first Outlook add-in.
Hope this helps.

If you want to read more about my issue, you can find https://stackoverflow.com/questions/61451273/do-you-need-an-on-premise-exchange-server-to-call-makeewsrequestasync on stackoverflow. The problem I have with documentation is that it does not mention explicitly any where that you need a on premise exchange server to use almost every api useful for building an add in. It something that is not mention in the tutorial you posted nor in the requirements for the makeEwsRequestAsync. The latter notes you must set oauth to be true, but only after finding the command to set oauth, one come to the realization that you need an on premise exchange server. I spent so much time trying to create an add-in only to come to this realization that it is impossible without an 800 exchange server license. I was hoping you could put at the front of  makeEwsRequestAsync and here to explicitly state "In order to set oauth to true, you need an on premise exchange server. If you do not have one, you can use x to verify your plugin will work." I believe X does not exist, but if you know of a workaround, please let us know so no one will believe they have to spend 800 dollars on an exchange license. I tried using an online exchange server but it did not work.
https://docs.microsoft.com/en-us/javascript/api/outlook/office.mailbox?view=outlook-js-preview#makeewsrequestasync-data--callback--usercontext-

From my understanding, the code should work with an cloud exchange server, but there seems to be an bug that does not allow for it right now. So a better solution would be to write in makeEwsRequestAsync that it should work with online exchange servers by default. However, there is a bug currently.

@rjpruitt16 It seems like you've opened issue https://github.com/OfficeDev/office-js/issues/1139 to report this possible bug. Since there doesn't appear to be a doc need here, I'll close this issue.
If you hit any other issue, as appropriate do comment in this issue thread, or open a new issue in the office-js product repo or here in the docs repo.
Thanks.


Starting Nuxt in PM2 Cluster Mode

Hello,
Is it possible to set nuxt to start in cluster mode in pm2?
Something like: pm2 start nuxt start -i max
** Regarding that I am using a store to persist the session.

i use the koa template to build my project，then  i can use pm2 to start build/main.js.
you can think about it.

@rikez You can use this command: pm2 start node_modules/nuxt/bin/nuxt-start -i 3
It starts nuxt in cluster mode. Don't forget to run build before start.

@manico
This way works for me.
But cannot assign port with --port


Consolidate Scrolling actions

Description of the new feature/enhancement
After #8459, we'll have the following scroll actions:

scrollUp
scrollDown
scrollUpPage
scrollDownPage
scrollToTop
scrollToBottom

This seems to be a case of us introducing new actions when we should be introducing new arguments instead. I propose the following designs:
Design 1: 3 args

action: scroll
arguments:

direction: up|down
mode: system|page|buffer
rowsToScroll: <optional int>

Personally dislike that rowsToScroll only works if you're in "system" mode. But it avoids the override in Design 2.
Design 2: Override mode

action: scroll
arguments:

direction: up|down
mode: system|page|buffer|<int>

This is basically Design 1, except rowsToScroll is embedded inside mode. If we go with this approach, maybe mode should be renamed to something like "amount"?
Open to discussion. Go!

@zadjii-msft 2.0 -- fair?

Well, we've got an open PR here with #8459. Are we expecting to resolve this design before we merge that PR? IMO That PR seems perfectly sensible, and I'd merge it as-is. I do get the push to make it a parametrized action - it's the switchToTab1, switchToTab2 thing all over again.
What if it was
{ "command": { "action": "scroll", "direction":"up" } }, // defaults to the system number of lines
{ "command": { "action": "scroll", "direction":"up", "amount": 5 } },
{ "command": { "action": "scroll", "direction":"up", "amount": "page" } },
{ "command": { "action": "scroll", "direction":"up", "amount": "buffer" } },

Which is like design 2, but without the "system" enum value. Though, I really hate sticking the 5 in the enum.
{ "action": "scroll", "direction":"up" }, // defaults to the system number of lines
{ "action": "scroll", "direction":"up", "amount": 5 }, // defaults to lines
{ "action": "scroll", "direction":"up", "mode": "page" },
{ "action": "scroll", "direction":"up", "mode": "page", "amount": 5 }, // up 5 pages
{ "action": "scroll", "direction":"up", "mode": "buffer" },
{ "action": "scroll", "direction":"up", "mode": "buffer", "amount": 5  }, // sure, 5 buffers up. It's still the top.

Okay I think I like design 1 more

Well, we've got an open PR here with #8459. Are we expecting to resolve this design before we merge that PR? IMO That PR seems perfectly sensible, and I'd merge it as-is. I do get the push to make it a parametrized action - it's the switchToTab1, switchToTab2 thing all over again.

I'm ok with merging #8459. Mainly because idk when we/somebody would get around to implementing this.

What if it was
{ "command": { "action": "scroll", "direction":"up" } }, // defaults to the system number of lines
{ "command": { "action": "scroll", "direction":"up", "amount": 5 } },
{ "command": { "action": "scroll", "direction":"up", "amount": "page" } },
{ "command": { "action": "scroll", "direction":"up", "amount": "buffer" } },

So the default would be?:
{ "command": { "action": "scroll", "direction":"up", "amount": "system" } },

Which is like design 2, but without the "system" enum value. Though, I really hate sticking the 5 in the enum.
{ "action": "scroll", "direction":"up" }, // defaults to the system number of lines
{ "action": "scroll", "direction":"up", "amount": 5 }, // defaults to lines
{ "action": "scroll", "direction":"up", "mode": "page" },
{ "action": "scroll", "direction":"up", "mode": "page", "amount": 5 }, // up 5 pages
{ "action": "scroll", "direction":"up", "mode": "buffer" },
{ "action": "scroll", "direction":"up", "mode": "buffer", "amount": 5  }, // sure, 5 buffers up. It's still the top.

So the default would be?:
{ "action": "scroll", "direction":"up", "mode": "line", "amount": "system" },

I'm fine with either. I agree that your design 1 seems cleaner though. 😊


Write-good suggestions

Based on https://github.com/gepoch/linter-write-good suggestions for the readme.
Can't have "passive tones" 😆

We should probably apply this to Cachet.


Fix for DDC-3697 and DDC-3701

This is about the DQL parser generating wrong SQL because conditions may end in the "ON" clause of a LEFT JOIN instead of the WHERE clause (http://www.doctrine-project.org/jira/browse/DDC-3697).
It also fixes that the parser may be too sloppy on expected tokens, for example accepting a WHERE instead of WITH (http://www.doctrine-project.org/jira/browse/DDC-3701). The first problem probably would have surfaced earlier with this strict check in place.
Note after discussion with @Ocramius this explicitly allows the DQL BCNF identifier to start with a \.

@guilhermeblanco You've put many efforts into the parts touched by this PR – what do you think about it?

@Ocramius How can I help here to get this along?

Closed #1389 in favor of this PR as the problem is solved here. Added some tests for the #1389 problem.

Tests fail due to a change in doctrine/cache, see #1510

@mpdude since #1510 was merged, rebasing this should bring the tests back to green

@Ocramius tried to get as much as possible of your feedback into this. Would be great if you could have another look at it.

After a few hours of sleep I come to recognize that this way of changing T_IDENTIFIER cannot be the right solution, as if would for example allow expressions like "SELECT \u FROM ... u" or "SELECT u.\someField FROM ..." as well.
Do we really want to relax the DQL grammar and explicitly allow for leading \s? This may take some work to get it right.

No, that seems wrong indeed...
On Sep 20, 2015 17:24, "Matthias Pigulla"<EMAIL_ADDRESS>wrote:

After a few hours of sleep I come to recognize that this way of changing
T_IDENTIFIER cannot be the right solution, as if would for example allow
expressions like "SELECT \u FROM ... u" or "SELECT u.\someField FROM ..."
as well.
Do we really want to relax the DQL grammar and explicitly allow for
leading \s? This may take some work to get it right.
—
Reply to this email directly or view it on GitHub
https://github.com/doctrine/doctrine2/pull/1395#issuecomment-141761870.

@Ocramius @mpdude I should be able to review this during this week... =)

Support for leading \ in class names (and later stripping it) has been added in 0424d870999c9fb0a044a8b5773f250376d2368f as a fix for DDC-675. At a first glance it looks as if the lexer should have choked anyway because a \ was not allowed in the identifier preg back then.

The problem is that \Foo, Foo:Bar:Baz, Foo\Bar, Foo:\Bar etc. all match the regexp in the Lexer and are considered valid identifiers. identifier is used for the AbstractSchemaName, AliasIdentificationVariable, IdentificationVariable and so on.
So, if we want to catch "SELECT \u.foo:bar FROM Bar:Baz:\Qaz \u" at the parser level, we'd probably need to define identifier as [a-z_][a-z0-9_]* and have T_COLON and T_BACKSLASH types in the lexer.
Then
     AbstractSchemaName ::= FullyQualifiedClassName | NamespaceAliasedClassName
     FullyQualifiedClassName ::= ["\"] identifier {"\" identifier}*
     NamespaceAliasedClassName ::= identifier ":" identifier

But, as I see it, the colon prevents us from having the handy T_INPUT_PARAMETER token and we'd need to add some production rule for parameters as well...
As I see it this is already broken right now (nothing caused by this PR), so we could also just merge this and walk away as if nothing had happened.

I think I have fixed the issue of allowing backslashes (and colons) in the wrong places by making T_IDENTIFIER accept [a-z_][a-z0-9_]* only. For qualified and aliased names, two new token types are added.
Also added tests that hopefully illustrate it.
@Ocramius and @guilhermeblanco what do you guys think?

Can I do anything to make the review easier for you?

@mpdude overall big :+1: for the improvements around this PR in general, as we now have some decent coverage of this logic.
Missing bits to change would be in the EBNF documentation ( http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/dql-doctrine-query-language.html#ebnf - https://github.com/doctrine/doctrine2/blob/b055d78ea19835fab563dfc234d4804a9d04966a/docs/en/reference/dql-doctrine-query-language.rst )

@Ocramius Thanks! I followed all your comments.

@mpdude mpdude/doctrine2@033b473 broke the build though :-|

Ooops, forgot to remove the test that checks for the classname validation in AbstractSchemaName.

Tests are green now.

Closed in favor of #1549.
Thanks a lot for your help! It's not everyone that manages to dig so deeply and understand DQL parser and you've done an amazing job working on it. In the follow-up PR I basically re-introduced backslash to not create a BC and I fixed a couple hidden bugs I've found while traversing through you patch.
I'm very confident you now have a good understanding of how DQL parser works, so I'll explain which changes I've done, so you're aware.
Keywords had to be separate from identifiers. This was required because isNextToken() applied an exact match, while match() itself was very relaxed. That means match(FROM) was valid even though it was not FROM itself, because it could be considered as an identifier.
To address it, I updated your changed condition in match() and I separated non-terminals (0-99), identifiers (100-199) and keyword (200+). This helped me to make things more strict.


Add cache option to enable conditional request

Conditional request support was added on #80, although it's very trick to store and use the response etag in order to leverage this improvement.
This issue proposes that httpSend handles that out of the box. The cache could be enabled or disabled by a cache: true configuration option.

@eduardolundgren : although it's very trick to store and use the response etag in order to leverage this improvement.. How do you do that? I'm trying to implement the ETag mechanism, but I can't find a way to extract the ETag from a request.

I found the answer, using meta.etag from the response object. Should be documented somewhere...

I'm going to close this since the solution is synchronous, but I'll still look into adding a caching solution. Something like the following:
https://github.com/ekristen/node-github-cache
https://github.com/ptarjan/node-cache
https://github.com/SalesforceEng/tough-cookie


De-register a communication operation and close it

We need to deregister an operation and its callbacks, memory and close it properly

This is fixed


[feat] sfpegCard - Display Record on an Lightning App Page

Is your feature request related to a problem? Please describe.
I would like to display some record content into an App Page. Unfortunately the sfpegCard component is not available for an App Page.
Describe the solution you'd like
I'd like to be able for the sfpegCard  to be able to pass the Id of a record using sfpegMerge and display the data I want on an App Page.
Describe alternatives you've considered
X
Additional context
The idea here is to be able to display a Knowledge article via sfpegCard on an App Page

Thanks @Daphne971  I shall have a look at this ASAP.

Implemented in commit c2b9c35
One new sfpegAppCardCmp component added as a wrapper component example.


Add select-on-read (ala miriad)

somehow we need to support the kind of workflow where, if one knows the data one wants from a file we can just read out a small subset.
the miriad select function works by specifying filters and then only reading the matching records from the file.  See aipy.miriad.uv.select() or aipy.scripting.uv_selector()

This has been done on the uvfits side, but the Miriad part remains to be done (thus the issue name change)

The miriad part was done in PR #335


Automatic incremental synchronization of hive metastore metadata.

Feature request
Is your feature request related to a problem? Please describe.

After the hive external table is created, the user needs to manually execute the refresh table or specify the partition to execute the refresh partition to cache the latest metadata of the table in the Hive Metastore(hms). If the refresh operation is not executed, the newly updated data in hive metastore cannot be obtained during the query in StarRocks, and the data will be different. Because updating the cache through manual refresh is more complicated, we need to support automatic synchronization of metadata updates in hms.
Describe the solution you'd like

Each fe node periodically obtains the hms incremental update event, parses it, and updates the cache in fe to achieve automatic synchronization. The hms interface we need to call has getNextNotification and getCurrentNotificationEventId.
A metastore event is a instance of the class org.apache.hadoop.hive.metastore.api.NotificationEvent. Metastore can be
configured, to work with listeners which are called on various DDL operations like create/alter/drop operations on database, table, partition etc. Each event has a unique incremental id and the generated events are be fetched from Metastore to get incremental updates to the metadata stored in Hive metastore using the the public API get_next_notification. These events could be generated by external metastore clients like Apache Hive or Apache Spark configured to talk with the same metastore.
We could process the events that fetched during each rotation according to the following points.

create batch event
Create a batch of events based on the partition or table. It is convenient for us to process batch event in parallel.
filter event
For some partitions that are not cached in fe, and some events that only modify transient_lastDdlTime, we ignore these events.
merge event
For multiple alter table/ alter parititon events of a table or partition, we only process the last one.
parallel process
Because batch events are partition-level, each batch event is processed in parallel.

fe will only update the table/partition that exists in the cache. If the user has not queried the partition or manually refreshed the partition, the corresponding event of hms will not be processed.
Describe alternatives you've considered

Additional context

https://github.com/StarRocks/starrocks/pull/3036


Intent Detection not working properly when asked query with synonyms value

Rasa NLU version:
0.14.4
Operating system (windows, osx, ...):
windows
Content of model configuration file:
{
  "language": "en",
  "pipeline": [
    {
      "name": "nlp_spacy"
    },
    {
      "name": "tokenizer_spacy"
    },
    {
      "name": "intent_featurizer_spacy"
    },
    {
      "name": "intent_classifier_sklearn"
    },
    {
      "name": "pattern_ner_spacy"
    }
]
}

Issue:
I have a working installation of rasa_nlu, running Python 3.6.5. I was able to get the sample tutorial working. I'm running into trouble getting it to work with intent detection.
Here's the relevant portion of my training file, first-model.md.
intent:select

what is the max rating?

synonym:max

best
highest
maximum
Now, rasa_nlu correctly detects the intent and entity for a question such as what is the max rating?

{'intent': {'name': 'select', 'confidence': 0.9542820453643799},
'entities': [{'start': 12,
'end': 15,
'value': 'max',
'entity': 'operator',
'confidence': 0.8146240434922525,
'extractor': 'ner_crf'}],
'intent_ranking': [{'name': 'select', 'confidence': 0.9542820453643799},
{'name': 'identity', 'confidence': 0.036332450807094574}],
'text': 'what is the max rating?'}
However, when I use a synonym in the question, it doesn't detect the intent correctly. For example, what is the best rating?
No dice with a synonym. I've tried this both with spacy_sklearn and tensorflow_embedding, and see similar results.
From suggestion and blog, I came to know I need to added all example using Chatito but I don't think so it would be a great approach it will generate templates with all synonyms. If Max has ~1000 then do I need to create thousand template examples? for better intent classification?
I created all examples but it does not fit in a situation when Ihaving larger dataset entity synonyms. , it doesn't fully solve the problem. Now the system returns each synonym (e.g. highest, maximum, best) as the entity value instead of the actual value (max). For example, if I ask what is the best rating?, I expect the same intent like when I asked with training example query.
or Do I need to add those synonyms in lookup_tables.
Many thanks in advance. Would greatly appreciate any pointers.
Cheers.

Please ask these kind of questions in our forum


Accelerate by removing recursive renaming

execute_src_to_dst_operation does the operation recursively for every file in a directory which makes trashing a large item with hundreds of thousands of files in it as slow as rm, especially on hard disks. Actually it is not necessary since try_creating_placeholders has ensured thread safty -- only the one who has successfully created the placeholder has the chance to run the following code.

And here is the new release: https://github.com/Byron/trash-rs/releases/tag/v5.1.1


Add --environment Parameter to Support Docker Execution

Description:
Enhance the project to allow execution within a Docker container by introducing a new launch parameter --environment. By default, the project currently generates code, places it in the sandbox folder, compiles, and runs it on the host machine. This update will provide flexibility to run the processes either on the host or within a Docker container based on the specified environment.

Requirements:

Parameter Addition:

Introduce a new command-line parameter --environment with two possible values:

host (default): Executes the compile and run processes on the host machine.
docker: Executes the compile and run processes inside a Docker container.

Default Behavior:

If the --environment parameter is not specified, default to --environment=host.

Docker Integration:

When --environment=docker is specified:

Automatically create and configure a Docker container.
Ensure the sandbox folder is accessible within the Docker environment.
Compile and run the generated code inside the Docker container.
Handle any necessary Dockerfile creation or use an existing one.
Manage Docker container lifecycle (creation, execution, teardown) as part of the process.

I'll take it!


Typescript IDE FAQ is not working

I'm following this guide: https://vite-plugin-pwa.netlify.app/guide/faq.html#ide-errors-cannot-find-module-ts2307
In order to get rid of the TS errors in Vue SFC's, but it's not picking the types up when I add them to the config.

We temporarily close this due to the lack of enough information. Please provide a minimal reproduction to reopen the issue. Thanks.

I think it's actually Volar not being able to deal with monorepos.
It works fine if I open the app as the root in VScode, but not if I open the root of the repo.
Sorry for the bother!


Deleting layers from world and loading new layers instead

Hi everyone,
im currently working on the simulation_manager.cpp. My goal is to load new layers from bitmap png files on every episode while training and deleting the old layers. For this purpose i wrote a ros::Subscriber inside the simulation_manager.cpp and defined a callback function.
ros::Subscriber goal_sub = n.subscribe("/goal", 1, &SimulationManager::callback_goal, this);

void SimulationManager::callback_goal(geometry_msgs::PoseStamped goal_msg) {
    YamlReader world_reader = YamlReader(map_layer_yaml_file_);
    YamlReader layers_reader = world_reader.Subnode("layers", YamlReader::LIST);
    for (auto &layer : world_->layers_) { // delete layers
      if (layer->body_ != nullptr) {
        layer->body_->physics_body_ = nullptr;
      }
      delete layer;
    }

    world_->cfr_.layer_id_table_.clear(); // empty the layer_id_table

    world_->LoadLayers(layers_reader); // load "map" layer from png file
    world_->DebugVisualize();
  }

During roslaunch i start the simulation with an empty map
properties:
  velocity_iterations: 10
  position_iterations: 10
layers:
- name: static
  map: empty.yaml
  color: [0, 1, 0, 1]

and afterwards use world_->LoadLayers(layers_reader); to load the real map for training via this yaml file:
properties:
  velocity_iterations: 10
  position_iterations: 10
layers:
- name: map
  map: map.yaml
  color: [0, 0, 1, 1]

This works for the first episode of training and the visualization works as well, but flatland server process dies after the first episode.
[flatland_server-2] process has died [pid 9515, exit code -11, cmd /home/ducanor/catkin_ws/devel/lib/flatland_server/flatland_server __name:=flatland_server __log:=/home/ducanor/.ros/log/978f8eb0-d9aa-11eb-8ae5-00155d6d5b70/flatland_server-2.log].
log file: /home/ducanor/.ros/log/978f8eb0-d9aa-11eb-8ae5-00155d6d5b70/flatland_server-2*.log

My guess is that there is a problem with the deleting during the callback. Maybe "map" layer is not deleted properly and this causes the process to die.
P.S.: I tried without deleting, but this causes the process to die after loading layers the maximum amount of times (16). The layers will not be overwritten.

The code as-is isn't really designed to handle dynamic map loading like that, although there's no reason why it can't be fixed.
I think I need to understand your use-case a bit better.
Are you trying to:

Run one simulation, but modify the map over time by reloading the map layers.
Run multiple different simulation worlds one after another without restarting flatland server?

If you're trying to do the first, maybe the map layers can be cleared and then loaded into the existing layers (presumably it would be the same layer names/ids, with maybe some additions). This is how dynamic model loading works, except the world objects would persist (with just the layers being replaced in-place, or added as needed).
If you're trying to do the second, can you use case be satisfied by restarting flatland server for a new world + layers each time? Avidbots does this, using a single world.yaml symlinked into each different map directory. Since the layer file paths are relative, you can load whichever layer files you want by pointing to the folder that contains the layer files and the common world.yaml symlink. If restarting flatland_server isn't desired, can you explain what problems that's causing?

My use-case is the first. I tried to somewhat implement your idea with the following callback function:
void SimulationManager::callback(nav_msgs::OccupancyGrid msg) {
    YamlReader world_reader = YamlReader(map_layer_yaml_file_); // load layer information
    YamlReader layers_reader = world_reader.Subnode("layers", YamlReader::LIST);

    world_->layers_.clear(); // clearing layers vector from world_

    world_->cfr_.layer_id_table_.clear(); // clearing layer id table containing names

    world_->LoadLayers(layers_reader); // load new layers
    world_->DebugVisualize(); // visualize layer in rviz
  }

Currently the simulation runs without any processes dying. But it appears that the layers are stacked on top of each other and after some episodes there is no free space for the agent to be spawned and of course move around.
My idea was to clear the layers_ vector and load a layer with the same name and property over and over into world_. The only change would be the png file from which the layer is loaded. I dont get the "Layer with name $foo already exists" exception because I cleared the layer_id_table_ which contains all layer names and ids.
Im still missing something. The layers seem to remain in in the simulation.

Clearing layer id table isn't going to quite work all the time since if the layers in the world file/layer file are in a different order than they were before, layers will switch IDs but existing stuff (models) will still have the old layer ids which are now backwards. This is fine if the order doesn't change but not ideal.
I'm not sure why the layers are stacked on top of eachother, since I'd have expected the Layer destructor to delete the Layer->body_, which should delete all of the physics objects. It might just be the debug visualization?
Looking at the code though, Layer::DebugVisualize should clear the old layer if it has the same name. I'm also missing something. Can you push a branch to a clone of the repo with your changes, and maybe an example layer file or two so that I can reproduce the issue?
It would be a lot easier for me to debug that way than to try to manually figure out what's going on without testing the problem.

Here is a our copy of the flatland repo:
https://github.com/ignc-research/flatland/tree/task_generation
This is our github for the whole simulator:
https://github.com/ignc-research/arena-rosnav/tree/task_generation
Im working on the task_generation branch. If necessary the whole setup can be installed very quick following:
https://github.com/ignc-research/arena-rosnav/blob/task_generation/docs/guide.md
In here you can find the yaml files i use to load the layers.
https://github.com/ignc-research/arena-rosnav/tree/task_generation/simulator_setup/maps/random_map
map.world.yaml to load the world with empty layer
map_layer.yaml to load the map layer
random_map.png will be overwritten to load another map layer
https://github.com/ignc-research/arena-rosnav/blob/task_generation/simulator_setup/maps/map_generator_node.py
I use this script to create new random maps. I will upload some random maps for you to test into the random map folder.
Currently i changed the callback function in the simulation_manager.cpp to subscribe to the topic /chatter2 and i manually publish to this topic to control the loading of layers. I did the same with map_generator_node.py with the topic /chatter to control the creation of random maps and the publishing of the topic /map.
Please tell me if you need anything else. I very much appreciate your help!

I've created a branch of your branch, and have a proposed PR that may fix this issue:
https://github.com/ignc-research/flatland/pull/6
One other thing I noticed while I was in the code was that you've changed the rosParam's like world_path from local (/flatland_server/world_path) to global (/world_path).
In order to maintain compatibility I'd recommend not making that change, and instead passing in the world_path arg from a parent roslaunch file. Currently the roslaunch files in your flatland repo are broken since the  entries would have to be moved out of the flatland_server  into the  parent so that they'd be set correctly. If you keep the change, then your flatland roslaunch files won't be compatible with mainline (or other branches of flatland), which could cause some headache for your repo's users in the future. Additionally, the examples and documentation won't be correct unless they're changed as well.


Nick: Watch gw.delhi(?#gmail.com)

Nick requests the watch of the watch_keyword gw\.delhi(?#gmail.com). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

gw\.delhi(?#gmail.com) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Add dataclasses to perf aler tool and refactor code.

Fixes: https://github.com/apache/beam/issues/28395
Groups the variables in Dataclasses for better readability and extensibility

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Do we need to merge this PR to test whether it works or Performance alerting tool on Python load/performance/benchmark tests already tested it?

This PR is just mostly refactoring.  The unit tests tested the code. I tested the tool locally as well.


[FEAT] Assign Users to Organizations API

Description
Develop an endpoint that allows admin to assign users to  organization.
Acceptance Criteria
Functional API endpoint to support assigning users to organizations.
Purpose
Provide functionality for assigning users to organizations via an API.
Admins can assign users to organizations via the API.
Requiremients

Define API endpoint and request schema for assigning users.

Implement logic to assign users to organizations.

Handle success and error responses.

Write tests for the endpoint

#. Endpoint
POST /api/v1/organizations/{org_id}/users
Only accessible by admins.
. Request Schema:
{
  "user_id": 0,
}

. Success Response:
Status code: 200
{
  "organization_id": 0,
  "user_id": 0,

}

. Bad Request
status code: 400
{
  "error": "Bad Request",
  "message": "User ID is required."
}

. Not Found (Invalid Organization)
status code: 404
{
  "error": "Not Found",
  "message": "Organization not found."
}

. Not Found (invalid User)
status code: 409
{
  "error": "Conflict",
  "message": "User already assigned to organization."
}

status code: 404
{
  "error": "Not Found",
  "message": "User not found."
}

. Response incase User Already Assigned
status code: 409
{
  "error": "Conflict",
  "message": "User already assigned to organization."
}

. Unauthorized user
status code: 403
{
  "error": "Forbidden",
  "message": "User is not authorized to assign users to organizations."
}

Write test
. Write unit tests to cover various scenarios.
. Write integration tests to verify the endpoint functionality in a complete workflow.
Expected Outcome
Admins are able to assign users to organizations through the API. The endpoint handles various cases such as user already being assigned, organization not found, user not found, and authorization issues.

Team lead @mwihoti
Members
@mufidat3250
@aarondio
@Dolapo001


rl_tuner train

when i run rl_tuner_train using default checkpoint
NotFoundError (see above for traceback): Tensor name "rnn_model/fully_connected/bias/Adam_1" not found in checkpoint files /home/ali/.cache/bazel/_bazel_ali/7641c5cc658a2d9d5ea532c08e7667f6/execroot/magenta/bazel-out/local-opt/bin/magenta/models/rl_tuner/rl_tuner_train.runfiles/main/note_rnn.ckpt
[[Node: save_1/RestoreV2_2 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_recv_save_1/Const_0, save_1/RestoreV2_2/tensor_names, save_1/RestoreV2_2/shape_and_slices)]]
[[Node: save_1/RestoreV2_3/_19 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/gpu:0", send_device="/job:localhost/replica:0/task:0/cpu:0", send_device_incarnation=1, tensor_name="edge_94_save_1/RestoreV2_3", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/gpu:0"]]

I have a problem like this ,too.
It happens on restoring variables from checkpoint, maybe the codes needs the old version to run

You're right i trained melody_rnn for 100 iterations and loaded it into rl_tumer to test it and it worked without any problems


CreateReply on next should use impl Into<Cow<'a, str>> instead of impl Into<String>

serenity@next does this on most builders and there doesn't seem to be a reason to have a full owned String other than funky lifetimes?
Maybe I'm missing something.

Turns out this is already a thing on serenity-next (which is where it needs to be because serenity@current still has some stuff using String)


1⃣This emoji has not been accurately parse on parseTweet

1⃣This emoji has not been accurately parse on parseTweet
version: 3.0.1
Expected behavior
should be parsed as invalid
Actual behavior
This snippet is officially invalid, but the result of parseTweet is determined to be valid.
Steps to reproduce the behavior
1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣1⃣

Do a parseTweet on this snippet

What version of the library are you reproducing this on
In what language are you testing (Java, Ruby, ObjectiveC, JavaScript)?
If you are not compiling the library yourself, from where did you obtain the binary/package?
Can you reply with the unicode that represents that emoji, it's hard to tell if GitHub's rendering of it is obscuring any facts.

In what way is the snippet officially invalid? It appears to be 140 emoji, which is valid.
Thanks

これを再現するライブラリのバージョン

3.0.1

In what language are you testing (Java, Ruby, ObjectiveC, JavaScript)?

Javascript

If you are not compiling the library yourself, from where did you obtain the binary/package?

from package use by yarn

Can you reply with the unicode that represents that emoji, it's hard to tell if GitHub's rendering of it is obscuring any facts.

I copied from the snippet, but it is invalid.

yes, this has been fixed internally and deployed in the app, but we haven't released to github yet.  We will publish a new version soon. Thanks!

Hi @kaushlakers ,
Do you have any plan for a release in the next future?
Thank you very much for your help!

@kaushlakers
Thanks for the bug fix!
When is the release likely?

This should be fixed now in 3.1.0. Thanks for your patience here! 🙏🏽

Thank you @kaushlakers!


Add az cache support

This PR is to add az cache support, and rename function AvailabilityZone to RetrieveAvailabilityZone.

When the containers not the pod restarted, for example, docker restart, kubelet eviction casued containers restart, these will hit the az cache.

@zhuguihua How long does the lookup persist in the cache?

@liamawhite The cache would be persisted until the service node was deleted.

So there's no expiry on the cache?

Currently it is. Your suggestion?

Im happy to approve then. Even if we will only see it on edge cases like proxy container reload.

/approve

@liamawhite I'm so glad you approved this, thanks for your work.

/lgtm

@zhuguihua: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8d317c6b7c49384e68775f1655a38a205285dd11
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Missing files for os x

wget ... v0.5.0-rc.1/guard-darwin-amd64 => 404

Fixed in https://github.com/appscode/guard/releases/tag/v0.6.0


Add SECURITY.md

Please take a look.

Codecov Report

Merging #296 (d4c431a) into 2021.9.x (b441d86) will not change coverage.
The diff coverage is 30.00%.

@@            Coverage Diff            @@
##           2021.9.x     #296   +/-   ##
=========================================
  Coverage     43.22%   43.22%
=========================================
  Files           776      776
  Lines         70646    70646
=========================================
  Hits          30539    30539
  Misses        35877    35877
  Partials       4230     4230

Impacted Files
Coverage Δ

compose/service/values/validator.go
63.29% <0.00%> (ø)

system/service/user_actions.gen.go
51.45% <0.00%> (ø)

system/types/app_settings.go
54.28% <ø> (ø)

system/service/auth.go
27.63% <20.00%> (ø)

compose/service/values/sanitizer.go
75.33% <100.00%> (ø)

pkg/options/auth.gen.go
92.85% <100.00%> (ø)

system/service/auth_actions.gen.go
46.32% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e1d1c...d4c431a. Read the comment docs.


Hello, I ran 15 epochs with the code you gave, and the generated pth file was used to run the test set, but the test results were not as good as the pth path you gave, why is this?

Hello, I ran 15 epochs with the code you gave, and the generated pth file was used to run the test set, but the test results were not as good as the pth path you gave, why is this?

Hi, @yike5022
I assume you have settled everything down before running this code, like the code itself, and pre-trained weights. Also, could you send me the training logs here, so that we can look them over then?

I can't find my training logs.So I may need to retrain, this question can be closed for now, and I'll ask you back when I get the results.Thank you for your answer.

Surely. We can reproduce similar results according to our experience, but not sure what errors you encountered during your training.
This question is temporally closed

Hi, @yike5022
Have you reproduced the similar results now? The same thing happened on my devices.

I haven't tried it since, so please let me know if you have any new developments

Hi, @yike5022 Have you reproduced the similar results now? The same thing happened on my devices.

I haven't tried it since, so please let me know if you have any new developments


Update Your First PR instructions post monogem

Description
Remove references to running bundle install for each tool, and submitting separate PRs.

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

Tests:

Name
File

Fastlane Fastlane::FastFile Unlock keychain Integration doesn't add keychain to search list
unlock_keychain_spec.rb

  Generated by :no_entry_sign: Danger

Nice catch 👍


Bump all dependencies

Includes https://github.com/foriequal0/git-trim/pull/208 - merge that first perhaps?

Resolved in #214


feat(master): compress client/partitions response data

What this PR does / why we need it:

add feature of compressing client/partitions response data
flush log before exiting client

Which issue this PR fixes:

fixes #
Special notes for your reviewer:
Release note:

compress 是不是可以在很多接口上应用？ 可以再进一步设计个比较通用的使用方式


Layout issues with keyboards

Issue Description
Taping on a TextInput which is located only at the bottom of the screen causes Android to push the entire app up. Where as a TextInput located at the top does not.
Steps to Reproduce / Code Snippets
I have two TextInput one a the bottom of the screen and one at the top. There is a picture between them.
Here is the render
return (
        <View style={[{flex: 1}]}>
            <TextInput style={{left: 0, right: 0, height: 45}}
                  placeholder={'Enter your text!'}/>
            <Image source={{uri: 'http://img11.deviantart.net/072b/i/2011/206/7/0/the_ocean_cherry_tree_by_tomcadogan-d41nzsz.png', static: true}}
                     style={{flex: 1}}/>

            <TextInput style={{left: 0, right: 0, height: 45}}
                  placeholder={'Enter your text!'}/>

              <Image source={{uri: 'http://img11.deviantart.net/072b/i/2011/206/7/0/the_ocean_cherry_tree_by_tomcadogan-d41nzsz.png', static: true}}
                       style={{width: 50,height:50}}/>
            <keyboardSpacer/>
          </View>
        );

The keyboard spacer animates the view up when the keyboard appears.
    _keyboardDidShow(e) {
        Animated.spring(this.state.keyboardHeightAnim, {
            toValue: e.endCoordinates.height
        }).start();
    },

    _keyboardDidHide() {
        Animated.spring(this.state.keyboardHeightAnim, {
            toValue: 0
        }).start();
    },

    render() {
        return <Animated.View style={{ height: this.state.keyboardHeightAnim }} />;
    }

If you tap the top TextInput the desired outcome happens. the app is resized to fit the new view. However if you tap the bottom TextInput the whole app is pushed out of the way of the keyboard. The code also to animate the view away also happens.

GIF OF ISSUE

Open top text input
close it
Open it again
type in it
close it

Then the same on the bottom
Here is my AndroidManifest
<activity android:windowSoftInputMode="adjustResize"
...
Expected Results
Taping the bottom TextInput has the same behavior as the top.
Additional Information

React Native version: 38
Platform : Android
Operating System : Windows

Thanks

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


NEXT-8326/9171 Fix being unable to set a port in a Domain

1. Why is this change necessary?
Because it is currently impossible to specify a port number on a domain in the administration, which is quite useful in development setups.
2. What does this change do, exactly?
It uses URL.host  instead of URL.hostname. host has the port number, hostname does not.
3. Describe each step to reproduce the issue or behaviour.
Edit a SalesChannelDomain in the adminstration and try adding a colon to specify the port number.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-9171
https://issues.shopware.com/issues/NEXT-8326
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Closed because entering a colon still doesn't work. If the port number is entered first, for example localhost8000, then move the cursor between the 't' and '8', a colon can be entered.


Allowing manual 'sync now' after a reasonable time in enqueued state

Fixes https://github.com/CartoDB/cartodb-platform/issues/639

@rafatower CR of the small Ruby change. Just allows to also sync if at queued state for too long (probably stuck, as hasn't been processed). Is a last resort "feature" but nice to have.
No tests but checked manually
@xavijam CR of the small JS change (back when I added queued state I didn't add it to the JS states list, sorry)

/cc @iriberri This will help if a user has a table stuck in queued state, after the mandatory 15 min we can tell them to use the "Sync now" editor button/link, so less work for us.

Oh, super interesting. Thanks!

No problem in JS side.

Frontend tests were OK :+1: (details)

:+1:


Image support, fork from PR #28

Introduction
Hi ppl, I came across from PR #28 where the author has no time anymore to make changes, so in behalf of @mateusnava I did some fixes, added more tests and tried to follow some points issued by @senny on #28.

references issue https://github.com/senny/sablon/issues/6
fork from PR #28 (it should be closed once this one is merged)
contains some fixes made on @ascylto's branch
added images labeled by a definitive creative-commons license
updated README
includes PR #52 where it "Ensures missing loop variables won't raise error" (Please note once this PR is merged, #52 should be closed)

Usage example

The nice part on this solution is that the replaced image will inherit the properties (height, width, etc) of the placeholder, so the size will be exactly the same. Kudos to @mateusnava!
I kindly ask @senny and @stadelmanma for doing proper reviews on their time.
Thanks in advance.

I wanted to let you know that I pulled down a copy of your branch to lay some ground work on making a generic relationships processor. However, I am going to wait until #49 gets merged since some of the code added by that PR will play right into this one in terms of interacting with the environment instance.

Hey, great to hear! In fact I've been off since Friday and that's good you are going to help with this thing!
My intention with this PR was to move forward the image support work which fits well for my client. I have to look detailed about your suggestions which make sense and I'll also work on that.
About the placeholder, I think it's pretty useful once we can control the properties within the template hence these properties will be kept on the image replacement. If you mean we should have a "hybrid way", like using placeholder OR using a HTML tag, I agree, but some work has to be done only on the ImageProcessor I guess.

Didn't intend to suggest any more work on your part. I like the clean implementation here since it lets the user handle all the image configuration on their end without us having to worry about the details.
I am working on an overhaul of HTML code insertion, and supporting the <img> tag isn't something I have any plans for right now just looking forward into the future. That opens up a whole other can of worms since judging by the XML images seem to come with a fair amount of overhead.

@leandronsp when you have a chance can you rebase this against master? I ran through it on my local branch and it goes through pretty cleanly.

@stadelmanma just did rebase against master, however if you already pulled this branch will have to delete and pull again. Let me know if you prefer a merge (in case you already did a lot of work on this branch) so I rollback and execute a merge instead

@stadelmanma by running locally the tests, I see the failing test because the sample used for assertion (fixtures/image_sample.docx) has a different XML of (sandbox/images.docx) for some reason.
I remember while testing this last week I got this problem as well, but I that's because Word generates different rIds for different documents I guess? When I compared both, I see the XML is in fact different. To make the test pass, I copied the sandbox/images.docx to the fixtures/image_sample.docx, so they will have the same XML document, thus the test will pass. However I'm not sure if it's a problem on our side or it's a nature of Word documents.

Tests are passing but testing the branch against my real data it's not working anymore:
undefined method `attributes' for nil:NilClass
=> lib/sablon/processor/document.rb:137

@stadelmanma I remember I fixed this problem last week by changing the lib/sablon/processor/document.rb:122 from  node.ancestors ".//w:p" to  node.ancestors only, because the pic:cNvPr was not present within w:p. But now I wonder why this is happening again since the line 122 didn't change on your commit.

@leandronsp yeah I didn't have all the tests passing yet, I mainly wanted to open the PR so you could see what I was doing in order to prevent us from doing duplicate work.
I'm not sure the cause of that unless that 'pic:cNvPr' node doesn't have to be present in all cases. Maybe in your template the image has no properties being set so this node doesn't exist?
Also, the image_sample.docx fixture needed updated because the name attribute in pic:cNvPr needed changed. The other ones should not have been changed since that is some bug in the code I haven't tracked down yet. It was on the list of "kinks" I still needed to workout in the PR into your branch where somehow a readonly action is modifying the files in place (although they don't seem to change anymore after being updated).

Right @stadelmanma, my template didn't have properly the placeholder, just fixed, thanks!
But it's not working when no image is provided on the context (environment).
undefined method `name' for nil:NilClass
=> lib/sablon/operations.rb:59

I think we could check the image presence on evaluate?

Putting this under line 57 should do what you want.
        image = image_reference.evaluate(env.context)
        unless image
          block.replace([])
          return
        end

I am currently trying to figure out why MS Word thinks the document in corrupt (it recovers just fine with next to no changes) after processing, it didn't do that before. I slightly tweaked your code before my changes to make the image names match up and git diff show no plain text changes in any files. There are some binary differences but I have no idea where. I have the bug narrows down to line 56 in relationships.rb.
zip_out.put_next_entry(entry.name)
#process(xml_node, rels)
#zip_out.write(xml_node.to_xml(indent: 0, save_with: 0))

It appears merely changing the entry causes an error at some level since I continue to get the error even if I don't actually write anything.

Great call @stadelmanma! I haven't noticed the problem was about inplace modification. Sorry for have changed those template fixtures.
I just fixed the NoMethodError on operations.rb while evaluating nil images. For now I decided to keep the original placeholder on absence of context image, which is useful for my cases, what you think?

The general trend of sablon is to completely remove any field that should be populated by a context but isn't. I can see valid use cases for both removing the placeholder as well as retaining it. Especially since images typically have captions or are directly referenced.
I'm currently tracking down the source of document corruption after processing. There is absolutely no differences in the unzipped contents between the older version of images.docx that works and the version the code now produces during testing. I even went as far as checking the sha256 hashes of each file in the archive to no avail. My only guess is that rubyzip is somehow breaking the headers since the total number of bytes in the two files is slightly different even though the contents aren't.

Naive question: why do we have to sort entries?
I see that rubyzip opens the zip, sorts entries then writes them again into filesystem. With entries sorted, the diff will be the same because content hasn't changed, but I think the number of bytes would change a little bit. Does it make sense?

The entries have to be sorted so numbering.xml is processed after the document.xml. It also why the original fork worked beacause _rels was processed before document.xml. I am starting to believe their are bugs in rubyzip that only appear when working with docx files.
@senny maybe you can shine some light on this issue, the two blocks below should be functionally equivalent but they aren't. The first generates an images.docx file that MS word can open no problem (458476 bytes total). The second block creates a "corrupted" MS Word doc with exactly the same unzipped content and is 458793 bytes total.
Generates valid doc
        Sablon::Processor::Image.init!(context)
        # reading the file into a stream prevents inplace modification of file
        zip_file = IO.binread(@path)
        Zip::File.open_buffer(zip_file) do |docx_zip|
          # loop over entries inside zip file
          docx_zip.entries.each do |entry|
            entry_name = entry.name
            out.put_next_entry(entry_name)
            content = entry.get_input_stream.read
            if entry_name == 'word/document.xml'
              out.write(process(Processor::Document, content, env, properties))
            elsif entry_name =~ /word\/header\d*\.xml/ || entry_name =~ /word\/footer\d*\.xml/
              out.write(process(Processor::Document, content, env))
            elsif entry_name == 'word/numbering.xml'
              out.write(process(Processor::Numbering, content, env))
            elsif entry_name == 'word/_rels/document.xml.rels'
              out.write(process(Processor::Image, content, properties))
            elsif entry_name == '[Content_Types].xml'
              out.write(process(Processor::ContentType, content, properties, out))
            else
              out.write(content)
            end
          end
          # finally add all used images to the zip file
          env.images.add_images_to_zip!(out)
        end
      end

Generates corrupted doc
        Sablon::Processor::Image.init!(context)
        # reading the file into a stream prevents inplace modification of file
        zip_file = IO.binread(@path)
        Zip::File.open_buffer(zip_file) do |docx_zip|
          # write out relationships
          entry_name = 'word/_rels/document.xml.rels'
          out.put_next_entry(entry_name)
          rels_file = docx_zip.find_entry(entry_name)
          content = rels_file.get_input_stream.read
          out.write(process(Processor::Image, content, properties))
          # loop over entries inside zip file
          docx_zip.entries.each do |entry|
            entry_name = entry.name
            out.put_next_entry(entry_name)
            content = entry.get_input_stream.read
            if entry_name == 'word/document.xml'
              out.write(process(Processor::Document, content, env, properties))
            elsif entry_name =~ /word\/header\d*\.xml/ || entry_name =~ /word\/footer\d*\.xml/
              out.write(process(Processor::Document, content, env))
            elsif entry_name == 'word/numbering.xml'
              out.write(process(Processor::Numbering, content, env))
            elsif entry_name == '[Content_Types].xml'
              out.write(process(Processor::ContentType, content, properties, out))
            else
              out.write(content)
            end
          end
          # finally add all used images to the zip file
          env.images.add_images_to_zip!(out)
        end
      end

Hi everyone,
Great job on the gem and on the pull request! I just found the gem today and I've done some basic tests with the images feature and it works great so far. I would love to see it merged so other people can use it as well. Is there anything I can do to help you guys? Is there any other issue besides the rubyzip one?

The rubyzip issue was worked around so that the final docx files generated do not get corrupted.
The only minor thing that might need addressed is adding some way to gracefully handle reuse of images in the document. Currently if the same image is used 10 times it would get duplicated 10 times in the /word/media folder.

Thanks for the update.
Hm, when I add the image to be replaced inside a text box, the docx output comes out corrupted. Was this already known? I've never messed around with the the XML spec, but I will try to investigate what is happening when I find some time.
Here is a sample file that is getting corrupted: template.docx

@fernandobrito That would be a suitable fix if images were only being added to the document.xml file but each subfile (i.e. headers and footers) in a docx archive manages it's own relationships. I don't believe it is currently being tested but the code should allow image insertion into headers and footers.
If we kept the same rId for an image and it got reused in a different file then the document would end up being corrupted or rendering incorrectly (i.e. images get mixed up). The media file itself would ideally get reused it just needs to be assigned a different rId if the file being processed changes.
The image.name attribute gets randomly generated early on in content.rb [52-54] to prevent accidentally overwriting a pre-existing file when writing to /word/media/:
def initialize(path)
  super "#{Integer(rand * 1e9)}-#{File.basename(path)}", IO.binread(path)
end

It may be better to keep the original filename (perhaps the entire path) so reuse can be detected and instead somehow assign that random name somewhere when a new image is being registered. It would likely take some refactoring of the Environment.register_relationship and Images.register methods.
Do you have any thoughts on implementing this @leandronsp?

Actually, I think image rIds are already getting mangled somehow. I wonte time to look through the XML code itself until later this week but running the following script from sablon/test/sandbox will reproduce the issue.
image_template_mod.docx
require 'sablon'

def test_generate_document_from_template

  template = Sablon.template File.expand_path('./image_template_mod.docx')

  context = {
    header_image: Sablon.content(:image, "../fixtures/images/c3pO.jpg"),
    footer_image: Sablon.content(:image, "../fixtures/images/r2d2.jpg"),
    regular_image: Sablon.content(:image, "../fixtures/images/r2d2.jpg"),
    items: [
      {
        title: "C-3PO",
        image: Sablon.content(:image, "../fixtures/images/c3pO.jpg")
      },
      {
        title: "R2-D2",
        image: Sablon.content(:image, "../fixtures/images/r2d2.jpg")
      }
    ]
  }

  template.render_to_file File.expand_path('./image-output.docx'), context
end

test_generate_document_from_template


fetchzip does not work correctly with unicode file names

Describe the bug
When you have a zip file, and it contains files which have unicode characters in their name, you'll get the wrong results.
To Reproduce
Steps to reproduce the behavior:

Get a file with unicode characters in their file name, for example like https://extensions.gnome.org/extension-data/flypieschneegans.github.com.v4.shell-extension.zip
Prefetch it nix-prefetch-url --unpack https://extensions.gnome.org/extension-data/flypieschneegans.github.com.v4.shell-extension.zip
Download it using fetchzip: nix-build -E 'let pkgs = import ./default.nix {}; in pkgs.fetchzip { url = "https://extensions.gnome.org/extension-data/flypieschneegans.github.com.v4.shell-extension.zip"; sha256 = "15pkdslpyvmpn4dfgmz89nl63b1jk9xbb9dpfp9xffdkkir95kgy";stripRoot = false;}'
Diff them: diff -r /nix/store/h0xbzms5y4jyawcx0qxakiaql13cycwq-flypieschneegans.github.com.v4.shell-extension.zip /nix/store/mr1qgxb44kb79xw9rd7b44gc0nff00qm-source

Expected behavior
Both are identical.
Actual behavior
Only in /nix/store/h0xbzms5y4jyawcx0qxakiaql13cycwq-flypieschneegans.github.com.v4.shell-extension.zip/presets: ⚪ Default Bright.json
Only in /nix/store/h0xbzms5y4jyawcx0qxakiaql13cycwq-flypieschneegans.github.com.v4.shell-extension.zip/presets: ⚫ Default Dark.json
Only in /nix/store/mr1qgxb44kb79xw9rd7b44gc0nff00qm-source/presets: #U26aa Default Bright.json
Only in /nix/store/mr1qgxb44kb79xw9rd7b44gc0nff00qm-source/presets: #U26ab#Ufe0f Default Dark.json

You can see that the '⚪' symbol got replaced with '#U26aa' for some reason.
Notify maintainers
Who maintains fetchzip? Pinging previous contributors at random: @edolstra @oxij @MetaDark @Ericson2314
Metadata

system: "x86_64-linux"
host os: Linux 5.11.8-arch1-1, Arch Linux, noversion
multi-user?: no
sandbox: yes
version: nix-env (Nix) 2.3.10
channels: "nixpkgs-20.09.3686.da7f4c48425, nixpkgs-unstable-21.05pre278688.c0e88185200"
nixpkgs: ~/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

(Bumping issue, as am affected)

Oh wow, I didn't think this would ever happen to someone else. I guess the law of big numbers has struck again.
Could you please add your example to the list?

Well, actually it's for the same (gnomeExtensions.fly-pie)

We have also observed an issue related to Unicode in file names with fetchzip but it only affected Darwin. See: https://github.com/NixOS/nixpkgs/pull/138274#issuecomment-933322839

This was solved thanks to #176253


Stop filters modal button being triggered by the form submit action

When SearchFiltersMobile was being rendered, a click event would fire on the open button when the form was submitted (most obviously from the mobile native keyboard submit action, but also reproducible when pressing return in a sufficiently small viewport). This stops that from happening. I can see why a lot of people stopped using the native <form> element 🙃 .

nice catch

I can see why a lot of people stopped using the native  element 🙃 .

How would you do this sans-JS?


It's turning off on its own

the Plugin is getting turned off on its own and doesn't work even after re installing the plugin please fix this problem asap 🙏

duplicate of #18 , the issue has been fixed in the latest commit, restart discord to get the update

Thankss


[Bug]: Changing 'name' attribute on npm_package to anything but the default pak

What happened?
I have a package called "my_package", but it exists in a directory called "proto". When I set the 'name' attribute of npm package to "proto", my project builds. When I change it to anything else it complains with:
ERROR: /path/BUILD.bazel:10:22: in src attribute of npm_package_store rule //:.aspect_rules_js/node_modules/<EMAIL_ADDRESS>'//path/proto:proto' does not have mandatory providers: 'NpmPackageInfo'. Since this rule was created by the macro 'npm_link_all_packages', the error might have been caused by the macro implementation
ERROR: /path/BUILD.bazel:10:22: Analysis of target '//:.aspect_rules_js/node_modules/<EMAIL_ADDRESS>failed

I assume this is because something is assuming that the npm_package target is the default target of the proto directory, but I could not figure out where. Is this an assumption that rules_js makes?
# This fails
npm_package(
    name = "my_package",
    srcs = [":my_src"],
    package = "@company/my_package",
    visibility = ["//visibility:public"],
)

# This succeeds
npm_package(
    name = "proto",
    srcs = [":my_src"],
    package = "@company/my_package",
    visibility = ["//visibility:public"],
)

Version
Development (host) and target OS/architectures:
ubuntu
Output of bazel --version:
bazel 6.4.0
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
rules_js-1.35.0
Language(s) and/or frameworks involved:
pnpm, rules_proto_grpc
How to reproduce
No response
Any other information?
No response

From the error message, it looks like it fails at the npm_link_all_packages that's referencing this package, not a problem in the BUILD file you pasted.
'//path/proto:proto' is what something else is referencing. Can you find that in your repro, or post a full one so we can rerproduce?

Ah my bad, in that run I had named my proto_library target "proto" (which is eventually what I want to do). Here is the error I get when it doesn't see any targets with the default name.
/path/BUILD.bazel:10:22: no such target '//path/proto:proto': target 'proto' not declared in package 'path/proto' defined by /path/BUILD.bazel (Tip: use `query "//path/proto:*"` to see all the targets in that package) and referenced by '//:.aspect_rules_js/node_modules/<EMAIL_ADDRESS>

I still need to see more of a repro to be helpful. The error references /path/BUILD.bazel:10:22:  - I can't be much help without seeing that.

@alexeagle
https://github.com/cdelguercio/aspect_build_rules_js_issue_1448
Let me know if you need any extra info.

@alexeagle any chance you've looked over my example repo?

@cdelguercio is https://docs.aspect.build/rulesets/aspect_rules_js/docs/npm_translate_lock/#npm_package_target_name what you're looking for?

Yeah it's a bit odd depending on specific names, but I think was the only way of doing it :/


[Waypoint: Remove Classes from an element with jQuery] usually expected to not validate if using removeClass() without parameters

Added extra test to the waypoint to check if .removeClass was used with the "btn-default" parameter as most people expect to have to do (and are confused when the code validates before they've finished writing their function, as seen by the myriad of issues opened about it).
Closes #2302
Closes #2402
Closes #2301
Closes #2197
Closes #2160
Closes #1923
Closes #1898

Hello @souldreamer!
I can't pass your third test with your code. Constantly getting the "missing ) ..." error.

@bugron Fixed it now, I'd accidentally deleted a closing paren for the assert. Tested it on a local copy of FCC and it works.

:+1: Works as it should.

@souldreamer verified and merged! Thank you for your contribution!


Fixed #27944 -- Allowed Model.meta.get_field('pk') to return the primary key.

The test failure is from a system check. I want to switch it to be obj=self.model but am unsure of what the backwards compat guarantees are for system check messages. They seem looser altogether to me given that a few have been previously removed.

Please fix the test failure however you want -- backwards compatibility isn't a concern there. The those a closer audit of all usage of 'pk' could be done. For example, if param != 'pk' in db/models/query.py.

Fixed test and did the audit. The one that might be nice to remove is in this check:
https://github.com/django/django/blob/master/django/db/models/base.py#L1559
But it would require rewriting the check to use get_field instead of .fields and .related_objects which I don't think is worth it.

@timgraham @charettes any further thoughts on this? The test failure was just from a force push timing.

I'm still a bit reluctant to introduce this change as I'm afraid it could introduce subtle bugs in the ORM.

This is fair enough.
The whole idea is to centralize the special casing of 'pk' which occurs everywhere outside of .get_field but is needed in all places where we accept user input that ends up in .get_field. That fails loudly I grant you but it seems that the abstraction is a bit broken if we have to annotate it outside the function call every single time.

[snip] or I had to special case the field.primary_key case

Do you have an example of what this looks like, I'm just curious.

I'm also slightly concerned this could introduce some issues but I figured it was worth a try to commit it and see whether or not that's the case.

Added a couple test case examples.

Any further thoughts on this?

@charettes, should we see if the mailing list has any feedback? I just don't know about this.

@timgraham I think it would be the best course of action. Personally I'm still -0 about the change.

Josh, do you want to open a discussion?

Will do. There was an interesting comment about how this would play with composite primary keys in the future that I hadn't thought through and seemed like a fair point to raise so I never did but will open it now anyway to gather feedback.

https://groups.google.com/forum/#!topic/django-developers/H9WWMmYh6zU

No replies on the discussion, no more comments here, should this be closed or should we nudge more people? @jschneier

Closing due to lack of consensus.


Remove host ping test

#316 broke the tests. This fixes it.
We don't need to test host ping as the container isn't assigned an IP Address in that scenario.
@sameo @runcom PTAL
Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

Sounds good to me

integration tests run fine now, thanks!


onLongPress (and delayLongPress) triggers immediately

For some reason (I have no clue why) onLongPress triggers immediately, and onPress doesn't.
tested on : android simulator with genymotion (galaxy5) and real galaxy3 device
After adding delayLongPress i figured out that it's "stealing" 1000ms from the delay, and I guess the default delay is 1000, so it's triggering immediately.
for example :
  <TouchableOpacity
               delayLongPress={3800}
               onPress={()=>{
                  console.log(' onPress');
                  console.log(Date.now())}}
               onPressIn ={()=>{
                  console.log('TouchableOpacity onPressIn');
                  console.log(Date.now())
                }}
               onLongPress ={(e)=>{
                  console.log(' onLongPress');
                  console.log(Date.now());
                  console.log(e.type); //undefined
               }}
           >

when I calculate  : onLongPress time - onPressIn time , I get ~2800ms
without delayLongPress or with delayLongPress={1000} I get 10-20ms

Duplicate of this? #4088

Looks like the same problem,
closed  dev-tools (and added other display - not console.log) and it's working fine

+1 when i debugging in chrome i see this behavior.

When I debugging in Chrome I see no action onLongPress

similar thing happens for ScrollView.onScroll- also blocking the scroll

I tried to investigate this problem but could not replicate the behaviour. I used the example code provided by @yonatanmn and the onPress and onLongPress fired as expected.
Is there more to this, or has it been fixed?

Confirming that this happens only with chrome debugger enabled.

Also confirming that this happens only with chrome debugger enabled.

Same. Confirming that this happens only with chrome debugger enabled.

I've just tested that and it looks like it's reversed now ;)
Without debugging tools the longPress triggers after holding for ~500-600ms, but with Chrome debugging open you need to wait ~3400ms.
I don't know whether it's a bug or a feature, but it seems that the original problem (launching onLongPress instead of onPress) has been solved.

ExceptionsManager.js:71 Attempted to transition from state RESPONDER_INACTIVE_PRESS_IN to RESPONDER_ACTIVE_LONG_PRESS_IN, which is not supported. This is most likely due to Touchable.longPressDelayTimeout not being cancelled.reactConsoleErrorHandler @ ExceptionsManager.js:71console.error @ YellowBox.js:61_handleLongDelay @ Touchable.js:596proxiedMethod @ createPrototypeProxy.js:44(anonymous function) @ JSTimers.js:80callTimer @ JSTimersExecution.js:95callTimers @ JSTimersExecution.js:136__callFunction @ MessageQueue.js:236(anonymous function) @ MessageQueue.js:108guard @ MessageQueue.js:46callFunctionReturnFlushedQueue @ MessageQueue.js:107onmessage @ debuggerWorker.js:44

Hmm it randomly started happening, after testing on real device with RN Debugger. it was working fine, and suddenly stopped.

Im seeing this issue too.

@brentvatne @satya164 How can I help? (I'm seeing this, and it's causing me issues with my workflow, and also may be resulting in the app just randomly exiting).

i am seeing this issue as well

I've just encountered this issue as well when debugging on Android. React Native 0.43.4. I think this is due to #4470 The default press delay is 130ms and long press delay 470ms. This means that to be considered for a normal press, the release event needs to come between 130ms and 600ms. If I log the Touchable events I see this:
1493638393648 RESPONDER_GRANT
1493638393694 DELAY
1493638393696 LONG_PRESS_DETECTED
1493638393716 RESPONDER_RELEASE

DELAY fires 46ms after press, not 130ms which what is supposed to happen. LONG_PRESS_DETECTED fires 48ms after press, not 600ms, then release comes 68ms.
This shows that there's something wrong with setTimeout, which is noted in #4470 - although it's marked as fixed, I'm not confident it is.
Also, notice that DELAY and LONG_PRESS_DETECTED is so close together - that's because the two setTimeout calls are made simultaneously but with different timeouts (130, 600). However, this bug makes them fire really close together, and sometimes flipped around, which causes bugs like #1693 which @zyxcambridge mentioned above

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/onlongpress-and-delaylongpress-triggers-immediately

it's been inactive but still happening. it's even worse lately when using react-native-router-flux because it brings up a red box when transitioning between scenes with the error mentioned by @zyxcambridge

I started seeing this today too...using react native, and RNRF too.

Confirmed.. this is still happening.

Yes still happening..
Was working fine yesterday and today bam...

The opposite happens to me. onLongPress takes around 2 seconds to fire, regardless of delayLongPress time. If I turn of remote debugging it is working as expected.

+1 happening only with chrome debugger. I hope this doesn't happens in production.

A competition

hello,I am go away!

forgive

Ah, I thought I broke everything. Thankfully it's just because of Chrome debugger.
Works fine when I disable debugger. (Using Expo)

Still having this issue and only happen when connected to Chrome debugger.

This breaks when only when debug JS remotely is enabled. im using VSCode debugger.
this needs to be reopened

maybe a obvious mistake on my part but i was not passing onLongPress a function initially i was declaring a method instance which caused it to fire on load.
<TouchableWithoutFeedback onLongPress={this.someHandlerFunction}/>
whereas it should be
<TouchableWithoutFeedback onLongPress={() => this.someHandlerFunction}/>

@apn-james both of those should be ok (what might be missing in the first is a bind function unless that is an arrow function instance).
Did you write the first call with parans maybe?
<TouchableWithoutFeedback onLongPress={this.someHandlerFunction()}/>

The same problem while remote debugging.

Still happening randomly (but at high frequency) on external device when remote debbuger is on. Tested it on Android devices only not sure if it happens on iOS.


Insert primary keys in all MySQL tables

What would you like to be added:
Some tables doesn't have a PK.
Why is this needed:
Clusters (like Galera) need a PK in all InnoDB tables.
See https://galeracluster.com/library/documentation/mysql-wsrep-options.html#wsrep-certify-nonpk
See https://mariadb.com/kb/en/mariadb-galera-cluster-known-limitations/
This is also a MySQL good practice.

@solracsf Do you have suggestion on how to add a PK for those table which don't actually need it?

More info: MySQL 8.0.13 introduced a new option sql-require-primary-key to force using PK, which has to be OFF for now.
https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_sql_require_primary_key

Do you have suggestion on how to add a PK for those table which don't actually need it?

Sorry to disagree on this @davies. A PK should be added to every table. Here's a detailled explanation of why.
https://vettabase.com/blog/why-tables-need-a-primary-key-in-mariadb-and-mysql/


Chat box Button Idea added

Issue:

Awesome thank you!
@all-contributors please add @dsnehasish74 for idea


Wildcard Types don't emit error for illegal Keys

In Wildcard types test, this will not set as expected, but not emit error notification
_jsd.document.model = {
            bogus: false,
};

bug probably a side-effect of the fixes for polymorphism this morning

fixed with 1c23ef5888a357f2881ab26a4954370ecfb309e5


optimize: client check whether undolog table exist before cleaning undolog

Ⅰ. Describe what this PR did
when RM receive UndoLogDeleteRequest(send by TC), if user does not use AT mode at all(which mean their database does not have undo_log table), exception would occur(such as undo_log table doesn't existed~) and logger will print error info(which scares user~). Here, we check whether undo_log table exist before trying to delete undolog.

Codecov Report

Merging #4085 (041ca6c) into develop (9d5ff40) will increase coverage by 0.06%.
The diff coverage is 42.37%.

:exclamation: Current head 041ca6c differs from pull request most recent head 8cdae39. Consider uploading reports for the commit 8cdae39 to get more accurate results

@@              Coverage Diff              @@
##             develop    #4085      +/-   ##
=============================================
+ Coverage      49.44%   49.51%   +0.06%
- Complexity      3750     3763      +13
=============================================
  Files            700      700
  Lines          23571    23607      +36
  Branches        2912     2913       +1
=============================================
+ Hits           11654    11688      +34
+ Misses         10731    10728       -3
- Partials        1186     1191       +5

Impacted Files
Coverage Δ

...ata/rm/datasource/undo/AbstractUndoLogManager.java
49.72% <12.50%> (-1.71%)
:arrow_down:

...asource/src/main/java/io/seata/rm/RMHandlerAT.java
48.38% <46.93%> (+48.38%)
:arrow_up:

...m/datasource/undo/oracle/OracleUndoLogManager.java
11.76% <50.00%> (+2.38%)
:arrow_up:

...torage/file/store/FileTransactionStoreManager.java
57.41% <0.00%> (+0.64%)
:arrow_up:


Intermittent spec/system/donation_system_spec example failures

Summary
Related-to/split-from #2711
Running a2be5be spec/system/donation_system_spec on my dev box produces intermittent failures—e.g., with random seed 47352:
Failures:

  1) Donations When signed in as a normal user When creating a new donation Via manual entry Allows User to create a donation for a ProductDrive Participant source
     Failure/Error: expect(page).to have_xpath("//select[@id='donation_diaper_drive_participant_id']")
       expected to find visible xpath "//select[@id='donation_diaper_drive_participant_id']" but there were no matches. Also found "", which matched the selector but not all filters.
[...]

     # ./spec/system/donation_system_spec.rb:209:in `block (5 levels) in <top (required)>'
[...]

  2) Donations When signed in as a normal user When creating a new donation Via manual entry Strips extraneous data if the user adds both Donation Site and Product Drive Participant
     Failure/Error: select DiaperDrive.first.name, from: "donation_diaper_drive_id"

     Capybara::ElementNotFound:
       Unable to find visible select box "donation_diaper_drive_id" that is not disabled and Unable to find input box with datalist completion "donation_diaper_drive_id" that is not disabled

[...]

     # ./spec/system/donation_system_spec.rb:319:in `block (5 levels) in <top (required)>'
[...]

  3) Donations When signed in as a normal user When creating a new donation Via manual entry Allows User to create a Product Drive from donation
     Failure/Error: select "---Create new Product Drive---", from: "donation_diaper_drive_id"

     Capybara::ElementNotFound:
       Unable to find visible select box "donation_diaper_drive_id" that is not disabled and Unable to find input box with datalist completion "donation_diaper_drive_id" that is not disabled

[...]
     # ./spec/system/donation_system_spec.rb:225:in `block (5 levels) in <top (required)>'
[...]

  4) Donations When signed in as a normal user When creating a new donation Via manual entry Allows User to create a Product Drive Participant from donation
     Failure/Error: select "---Create new Participant---", from: "donation_diaper_drive_participant_id"

     Capybara::ElementNotFound:
       Unable to find visible select box "donation_diaper_drive_participant_id" that is not disabled and Unable to find input box with datalist completion "donation_diaper_drive_participant_id" that is not disabled

[...]
     # ./spec/system/donation_system_spec.rb:235:in `block (5 levels) in <top (required)>'

I saw something similar wihen I was working with the language stuff-- touching assets/javascripts/donations.js.erb seemed to make it go away for me, so I thought there might be some weird dependencies with the const values in that?  Or it may just have been magic.

I think this is related to some of the other asset/webpacker issues. I wonder in @bobmazanec's fix will take care of it.

Going to close this issue to avoid duplication as we have another issue to look into bad/flaky tests. See the comment here: https://github.com/rubyforgood/human-essentials/issues/2711#issuecomment-1076691406

I agree with the general "avoid duplication" sentiment, but want to make sure you considered my reasoning in https://github.com/rubyforgood/human-essentials/issues/2711#issuecomment-1055588885
Thanks

Absolutely. I'm not sure quite yet on if we should make issues for each or what the best way to handle it is. We can make an issue for each test failure that pops up but it really feels like there is something more at work here than a flakey tests. We've only recently started having consistently flakey tests and needed to add the rspec-retry gem. This leads me to believe that we have a configuration/gem/other issue that is at the root of it all.
I 100% agree with your approach and sentiment that it doesn't make sense to have an endlessly open issue. Especially given that I've been working on cleaning up the backlog :) Also that when we do figure out what is breaking the tests I'm going to ask you to fix it ;)


Row: prevent row image from shrinking

What You're Solving
In certain cases, the row image and actions are shrinking when the Words
section runs out of space (see attached screenshot). This fix makes sure the Words section will collapse all the way to zero before the other flex items start collapsing.
How to Verify
We've spent a while trying to reproduce this exact behavior and have not found a consistent way to do so outside our specific use case. We tested to make sure the fix did not change any of the examples in the design system site.
Before Fix

After Fix

@KaidenR Thanks for finding this and finding a solution accommodate the case.  The solution is non-intuitive to me at first.  What makes this work?  Or do you have a url you could point me to to learn about it?

@jaketrent The Flexbox spec says

By default, flex items won’t shrink below their minimum content size (the length of the longest word or fixed-size element). To change this, set the min-width or min-height property. (See §4.5 Automatic Minimum Size of Flex Items.)

So I'm pretty sure that was causing the Words section to reach it's automatic min size and then the image would start shrinking. So setting min-width: 0; would let it shrink all the way.
You can check out the bug here: https://app-stage.pluralsight.com/channels/details/1eda599f-aefa-4372-a1a5-2d54a9088b3d
Shrink the window down and the row image will start collapsing. But add min-width:0 to the Words section (class="css-1kx0lgw") and it will be fixed.


Add analyzer to warn about wrong UseGoogleTrace/UseMvc order

Resolves #1982
Recommend to review one commit at a time.

This also adds in support for easily auto-generating more analyzers in the future.
Analyzers are packaged into the nupkg file of the target assembly, but we can change that to make them their own NuGet packages if necessary.
My only question is about how we want to assign rule ids. I was using a "GCPxxxx" format for our internal analyzers, from 0001-0004 currently, but I think that format works nicely for the public analyzers as well, so I assigned this one to use "GCP0005". However, if we want a clean numbering from 1 for all the public analyzers, we can use a different format and/or range for the internal ones. Just let me know and I'll change the ids. I don't feel too strongly about it, but we should figure this out before release because changing it later would be a breaking change (rule severity customizations and in-source error suppressions wouldn't work after a change).

cc @SurferJeffAtGoogle

What need's to be done for the error reporting bits? Is it the same concept of an ordering requirement?

@evildour Yea it's pretty much the same thing it needs to be called before things you want uncaught exceptions logged for MVC is probably where the bulk of this would be.

@evildour Hit enter too soon.  It's probably worth doing error reporting in a separate PR as this is already fairly large.

Yeah I agree. I'd like to nail down the packaging strategy first so we can get this in. Then I'll generalize it in another PR.

Ok now the analyzers will be their own package. PTAL.

I guess just the package details because I think we should publish these analyzers after this PR is merged.
Note: I realized I forgot to actually look in the package to make sure things were correct before, and they weren't, so I also made a few fixes there. PTAL at the project generator.

Yeah, that might be a good idea, but in a different PR. Are you ok if I publish this right after merging?
@iantalarico are you still taking a look here or are you good?

(rebase)


Fix Bot userdata and -cf command parameter

Short Description:

Fix Bot userdata and -cf command parameter
Fixes:

Fix -cf argument
Fix Bot user data parameter

will fix the conflict..

Since the review of team, I'd like to close this PR. thanks.

@solderzzc Why was this PR closed?


Attempts to use api + kubelet ca and key for tls

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

/assign @simonswine


armour trims

hey, when I put an armor trim on my helmet the trim shows op in my face and takes up most of my field of view unless looking completely straight. is there a way to fix this on my side or do I need  to wait till you've updated it.

Duplicate of #362


allow for digit map overrides from service body configuration #385

@pjaudiomv can you give this a try when you get a chance?

I just tested this and it didn't work :( it also seemed to of then neglected my other service body setting as a result of it not working.

what do you mean by not working?

On Mar 20, 2020, at 10:45 PM, pjaudiomv<EMAIL_ADDRESS>wrote:
I just tested this and it didn't work :( it also seemed to of then neglected my other service body setting as a result of it not working.
https://user-images.githubusercontent.com/34245618/77217902-737b8880-6afc-11ea-93e0-b8d6c1182af4.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/bmlt-enabled/yap/pull/395#issuecomment-601982556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOD3OYZH25KFCKQV2D2M2DRIQS4LANCNFSM4LEW2OOA.

hold

So its not changing the digit maping, and once i do set digit_map_search_type it then ignores my custom_query and result_count_max and gos to location gathering


KVO doesn't work

I have tried create custom class
class CustomObject: NSObject {
    var age: Int

    init(age: Int) {
        self.age = age
    }
}

then create instance
self.object = CustomObject(age: 1)

then observe the age property
self.object.observe().keyPath("age", value: self.object.age).next { print($0) }

and finally change age
self.object.age += 1
self.object.age += 1
self.object.age += 1
self.object.age += 1
self.object.age += 1

But the value is printed only once.

You have to store the chain of operations otherwise it will be disposed.

Could you provide example please? Is it possible to use DisposeBag or I got it wrong? Thanks

Yes you can use DisposableBag to store your observations/bindings here is an example:
class MyClass {

    let disposableBag = DisposableBag()
    // .....

    private func setupObservations() {

        object.observe().keyPath("age", value: object.age)
            .next { print($0) }
            .disposeWith(disposableBag)
    }
}

Thanks

Well I tried that too but what I'm getting is Value of type 'KVOSignal<Int>' has no member 'disposeWith'

Ah, the 3.0 version hasn't been released on cocoapods, still using 2.0, thats the problem. Thanks for your help! :+1: could you push the new version to cocoapods please?

Just updated the podspec on the cocoapods.
Thanks


Has this project been abandoned?

Hello @DormyMo, this project has unmerged PRs from two years ago, do you have plans to continue with SpiderKeeper? :D
Thanks for your work!

Why not try ScrapydWeb, which is recommended by ScrapingHub.

Why not try ScrapydWeb, which is recommended by ScrapingHub.

I'll try it, thanks!


fix: Popups/dropdowns not displaying in FluentProfileMenu and other places

🐛 Bug Report
I've created a Blazor application using the Fluent Blazor templates - latest version. I've added both a FluentProfileMenu and a FluentMenuButton to show the issue in the repro, as when I click on either, nothing happens. No menu is displayed.
My guess is that there's a .js file missing. I have read the docs on https://www.fluentui-blazor.net but cannot see that I'm missing anything.
💻 Repro or Code Sample
Create a new Blazor site (I chose WASM) using the Fluent Blazor template, then paste in this code anywhere - probably in the header...
<FluentProfileMenu Image="https://static01.nyt.com/images/2016/01/04/fashion/04GATESQA/04GATESQA-articleLarge.jpg?quality=75&auto=webp&disable=upscale"<EMAIL_ADDRESS>                  HeaderLabel="Microsoft"                    Initials="BG"                    FullName="Bill Gates"<EMAIL_ADDRESS>                  Style="min-width: 330px;" />
I have included a sample as an attachment to this bug.
🤔 Expected Behavior
I would expect to see a dropdown menu. The samples on the example website (https://www.fluentui-blazor.net/ProfileMenu) work as expected.
😯 Current Behavior
Nothing happens when I click on the profile menu or dropdown button.
🌍 Your Environment

Windows 11
Microsoft Edge Version 125.0.2535.51 (Official build) (64-bit), Google Chrome Version 125.0.6422.114 (Official Build) (64-bit)
.NET 8 and Fluent UI Blazor library 4.7.2
WhereIsMyDropdown.zip

Hi,
This is not a library issue. You have put the Profilemenu in the Server project. That is not going to work. Everything that needs interactivity, needs to be in the Client project (compare with NavMenu.razor)

Thanks for the heads up here - and that makes sense.
There is another issue here, which again may be me being a novice with this, but if I move this code solely to client side razor files with no other changes I get runtime errors. I've tracked this down to the following line which is not in the template at present...
builder.Services.AddFluentUIComponents();
If I add this to my client project then the interactive components work great.

Yes, in that case it needs to be in your Client project as well