Use different defaults if scraper_config is created by OpenMetricsBaseCheck

What does this PR do?
This PR changes the defaults used in the scraper_config for an instance. Specifically, send_monotonic_counter and health_service_check is now default to False in mixins.py, with the default sets to True only if the config is being created by the OpenMetricsBaseCheck class.
Motivation
Previously, there were two sets of conflicting defaults used in the old GenericPrometheusCheck and PrometheusScraperMixin classes.
This meant that checks based on the PrometheusScraper class were not sending health service checks and were not sending count-type as monotonic_count-type metrics.
Since we are now getting all Prometheus-based checks to switch to OpenMetricsBaseCheck, we need to get all the checks that were based on GenericPrometheusCheck to continue to send health service checks and send counts as monotonic_counts, and we also need to get all the checks based on PrometheusScraper to not send health service checks and not send counts as monotonic_counts.
Review checklist

[x] PR has a meaningful title or PR has the no-changelog label attached
[x] Feature or bugfix has tests
[x] Git history is clean
[x] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Codecov Report

Merging #2135 into master will decrease coverage by 17.32%.
The diff coverage is 76.92%.


Merge with https://github.com/hyprland-community/hyprland-py?

I was recently searching for Hyprland Python bindings and saw both this repo and hyprland-community/hyprland-py. I haven't had the chance to take a deep look at either repo yet but I was wondering if you have considered merging your project with theirs so that there is no effort wasted on doing the same thing twice, and any unique features of either project is available to all?

Hey @georgetian3,
Thanks for pointing that out! I was also looking for python bindings and came across hyprland-py. It's very cool, but it mostly feels like a direct wrapper for hyprctl commands. There is also sadly no documentation for it, making it difficult to actually use. With hyprpy, I'm aiming for something that's simple and very intuitive to use for devs, backed by solid documentation.
The utlimate goal is abstracting away having to write any hyprctl commands or event listeners yourself. Please do take a peek at hyprpy's documentation, and you'll see what I mean.
It's early days of course, but in terms of features, I am absolutely taking inspiration from hyprland-py and other hyprland binding libraries.
Appreciate your input and always open to more feedback!


Docs use C# instead of CS for code-blocks

Hi! Minor nitpick!
I belive your should run a find/replace to replace  ```c# with  ```cs to make syntax highlighting work on the csharpier website ( https://csharpier.com).
The recognized codes for prism that you use for code higlighting in the docusaurus setup looks for one of these: csharp, cs, dotnet
Example: https://csharpier.com/docs/About the first code example here is not colored correctly and it would look better with a tiny change :)
Feel free to close this issue if you think its not worth fixing, or add a comment and I'll fix it and submit a PR

Edit: Tried myself at this, but it seems like there is something else wrong. It does not matter if i change to cs. Closing this until I figure it out.


iframe and touch sensitivity support?

I'm facing 4 issues.

the mouse scroll doesn't work in latest IE 11 and FF 38.0.1 while over an iframe (youtube in my case).
the touch scroll doesn't work while touch occurred in the iframe (youtube again).
scroll is super sensitive on mobile for long pages.
normal mouse wheel scroll in FF gets stuck when you scroll to the end and top of content a few times. it's happening on the demo site too. so I think it's important to resolve this first.

Is there anyway to solve these 4 problems?
Thanks.

I'm also getting a very sensitive scroll with long pages on touch screens. It's really hard to scroll to the right position.

Hi @resting,
Did you ever find a solution to issue 4 on your list?

FF/Gecko is problematic on my end as well; WebKit plays nicely

I realize this thread is quite dated, but if you've discovered a solution, sharing would be much appreciated 😃
· Jason

@designbymind I did manage to fix issue 4. Don't remember what I did though.

Hi @resting,
I found another solution but thanks for your reply!


Decimal precision and scale

Implementing Decimal precision and scale.
I have implemented create, and insert logic with deciaml precision and scale.
However, while I was trying to implement insert into t1 select ~~~ I thought we should discuss it before I go any further.
below is what I implemented in this draft.
We can create table with decimal(precision,scale) type.
CREATE TABLE DECIMAL_PRECISION_SCALE (d1 DECIMAL(5,2))

Also we can insert value into Decimal type. It validates the precision, and rounds conform to declared scale.
INSERT INTO DECIMAL_PRECISION_SCALE (d1) VALUES (123456); -- fail, exceeds precision.
INSERT INTO DECIMAL_PRECISION_SCALE (d1) VALUES (123.456); -- success with rounded value: 123.46

Since eq for Decimal type is not implemented, for now, it only supports create, insert, and select.
UPDATE DECIMAL_PRECISION_SCALE SET d1=234.567 WHERE d1=123.46 -- fail, we cannot compare decimal values and literal (eq is not implemented)

And below is what I have in concerned to go further.
We need to implement validate and round decimal value to conform to the declared schema.
For example, insert into t1 select decimal_value from t2 is available but validation and round is not implemented yet.(which means not perfect decimal type). For now, it only validate and round for literals.
In this situation, I thought about how to work only when inserting and updating values from literal without precision verification and scale of decimal.
One way to think of it is to add precision validation to the row validation process, and scale round process to round in try_into_value. The advantage of this method is. The process of converting from literal to value is kept as before, and validation and round are applied only to value, thereby simplifying the decimal operation process. The downside. Because logic for validation and round is added to the process of creating a row itself, the whole row operation may be slightly heavier.
If logic can be added to the row side, we will modify the code in the direction of applying precision and scale to decimal values that have already been converted from literal to value. If there are other better ways, that's even better.

Awesome!
It looks that now you may need to add Decimal wrapper module to data/ which wraps rust_decimal::Decimal.
Then, you can implement

binary operations between other primitive types in data/decimal module.
binary operations between Value::Decimal and other Value in data/value/binary_op/decimal.rs.
Then you can clearly define binary-op and validation by keeping module dependency acyclic.


Tests are slow since Findbugs

I really like the addition of findbugs, but the tests take 4:30 min to run on my computer, without findbugs it's < 3 min. Would it make sense to only run findbugs on travis and remove it from the default test cycle? Maybe we can add it to a different phase?

Yes, sounds good!

Can you try out https://github.com/spotbugs/spotbugs-maven-plugin/ if it is faster?

I have just seen that there are also statistical code analysis tools available in the Github marketplace. All of them are free for open source projects. Most also add code coverage and security checks. I have no experience with any of these tools, but maybe it would be also interesting to add one of them?

https://github.com/marketplace/codacy
https://github.com/marketplace/codebeat
https://github.com/marketplace/better-code-hub
https://github.com/marketplace/code-climate

They run checks before a PR can be merged, similar to Travis.

Can you try out https://github.com/spotbugs/spotbugs-maven-plugin/ if it is faster?

Sure, I can try this, but don't you think it would be enough to only run them before merging the PR?

but don't you think it would be enough to only run them before merging the PR?

Yes, this would be enough. But also we should use this new findbugs and hope it is faster ;)

But also we should use this new findbugs and hope it is faster ;)

I just tried the spotbugs plugin and I wasn't able to use the maxRank config, so it always failed the build because of some minor issues. I used the same config as the findbugs plugin, which is also documented like this.The spotbugs maven plugin is not yet released as a stable version but only as a RC and is a fork of the findbugs plugin, so I am not sure how big the performance boost will be? I think it will be released as a first stable version in shortly, see this issue.

Fixed via #1190 and #1191?

Yes should be fixed, thanks :).


scoop install \server\share\app.json fails with "error: The given path's format is not supported"

The docs suggest that installing manifests from UNC paths is supported, but it doesn't appear to work:
> scoop install \\server\share\app.json
WARN  error: The given path's format is not supported.
Couldn't find manifest for '\\server\share\app.json'

Fixed


[CI] Fix global pip cache disable change

Fixing my mistake in #8575.

The fix to disable cache needs to run after pip is installed
This is quick follow up fix after #8575

Note: I think it is important to run this command at the Dockerfile level, otherwise people that run the scripts locally on their machine might accidentally disable the cache, which for developers' workstations is useful.
cc @areusch @tqchen @Mousius for reviews

Cc @mbaret for a review and merge if possible.

Thanks @leandron and @Mousius, this is now merged.


Update license check

Don't use a Node.js matrix for license check, and drop private package exclusion.

:green_heart: Build Succeeded

Buildkite Build
Commit: 2a026c435a18c1f6b85ad18bdefcb601e7d0d642

:green_heart: Build Succeeded

Buildkite Build
Commit: 85870652f977df565d631f16b630fa21f744b3d8

History

:green_heart: Build #903 succeeded 2a026c435a18c1f6b85ad18bdefcb601e7d0d642


Add metadata timeout fields in RemoteRepository and add metadata time…

depends on galley's commit: https://github.com/Commonjava/galley/pull/101

retest this please

retest this please


Portfolio: details popup window

In this task, the following were implemented:

When the user clicks (or taps) the button to check project details, the popup with details about the project appears.
When the user clicks (or taps) the close (X) button, the popup disappears.
implement popups for both mobile and desktop screen sizes
use a JavaScript array to store all of the information for all projects.

Hi @medaminedev66 thanks for your feedback


Automated cherry pick of #10885

Cherry pick of #10885 on release-7.2.
/cc  @mkraft
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: ff5412904db84770495cff965ea9615b0d1a56e1


[FLINK-31166][table] Fix array_contains does not support null argumen…

What is the purpose of the change
Fix array_contains does not support null argument when the array element type is not null.

fix select array_contains(array[1, 2, 3], cast(null as int)); which has exception now

Verifying this change

add unit test

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing
Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? docs / JavaDocs

hi @snuyanzin do you have time to review it. i talk this problem as array_remove with you before

hi @snuyanzin What communication tools do you use? In order to facilitate communication with you, i want to use the same tool with you

thanks for your contribution
I will have a look next week.
Meanwhile may I ask you to improve the PR description?

@flinkbot run azure

have fixed, thanks, please have a look again

hi @snuyanzin please have a look. and other array builtin functions blocked here.

hi @snuyanzin ,thanks for your review and i learned a lot

thanks for contribution @liuyongvs , lgtm


Updated for php8

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4cc05ad). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   47.26%
  Complexity        ?      287
=========================================
  Files             ?       16
  Lines             ?      749
  Branches          ?        0
=========================================
  Hits              ?      354
  Misses            ?      395
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc05ad...f29197c. Read the comment docs.


feat(husky): add no only on precommit

What this PR does / why we need it:
happy dev
annoying while forgot to remove then push
time wasted on CI

Which issue(s) does this PR fixes?:

Fixes #
Additional comments?:

I think we might be able to accomplish this on eslint?

Probably also a good idea to update the enforcement of testing with toStrictEqual

https://www.npmjs.com/package/eslint-plugin-jest might be useful

These eslint changes highlight a few linting issues with our existing test, need to decide whether we should silent them or follow convention.


When Rogue is on, user can now signup via SMS for a campaign

What's this PR do?

Fixes bug so now when Rogue is on, user can go through SMS flow when texting in keyword to 38383.

When user texts keyword, first check if signup exists in Rogue and if not, create a new signup.

Returns Rogue signup object when Phoenix's GET /signups endpoint is hit.
Returns Rogue signup_id when Phoenix's /campaigns/[nid]/signup is hit.

Removes dosomething_rogue_check_sid_and_store_ref and anywhere that uses this since we no longer post info back to Phoenix from Rogue.

How should this be reviewed?

Turn Rogue on.
Signup for a new campaign.
Make sure signup makes it to Rogue.
Hit /campaigns/[nid]/signup and make sure Rogue signup id is returned.
Make sure signing up via SMS works (both for a new and existing signup).

Any background context you want to provide?
Just want to flag for @aaronschachter in case you see any issues because of this PR!
Relevant tickets
Fixes https://trello.com/c/S7cjnFL1/482-3-when-rogue-is-turned-on-user-cannot-sign-up-via-sms
Checklist

[ ] Documentation added for new features/changed endpoints.
[ ] Tested on staging.
[ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love
[ ] Post a message in #phoenix if this includes something that causes a rebuild!

@DFurnes I'm trying to flesh out the transformed response but noticed that when loading the campaign, not sure what translation to return for the below:
        language: {
          language_code: "en",
          prefix: "us"
        },

       tagline: "Send friends Thumb Socks to remind them not to text and drive.",
        status: "active",
        type: "campaign",
        reportback_info: {
          copy: "Send us a shot of your friend rockin' their Socks!",
          confirmation_message: "Thumbs up, Thumb Warrior! Thanks for keeping your friends -- and the streets -- safe.",
          noun: "Thumb Socks",
          verb: "shared"
        }

Is this transformation based on whatever the user's language is?

oh wait, I think I've figured a lot of that out!

This is a sample of the beginning of the response when Rogue is off:
{
  meta: {
    pagination: {
      total: 1,
      per_page: 25,
      current_page: 1,
      total_pages: 1,
      links: {
        prev_uri: null,
        next_uri: null
      }
    }
  },
  data: [
    {
      id: "243",
      created_at: "1400103603",
      campaign_run: {
        id: "1816",
        current: true
      },
      uri: "http://dev.dosomething.org:8888/api/v1/signups/243",
      campaign: {
        id: "1173",
        title: "Thumb Wars",
        campaign_runs: {
          current: {
            en: {
              id: "1816"

When Rogue is on, we don't return the meta info, just return the data. Should I try to mimic this in the response when Rogue is on?

@chloealee Yes!

@DFurnes this is ready for a look! Here's an example of the response when Rogue is on to mimic this response:
{
    "meta": {
        "pagination": {
            "total": 25,
            "count": 20,
            "per_page": 20,
            "current_page": 1,
            "total_pages": 2,
            "links": {
                "next_uri": "http://rogue.dev:8000/api/v2/activity?filter%5Bnorthstar_id%5D=5589c991a59dbfa93d8b45ae&filter%5Bcampaign_id%5D=1360&page=2",
                "prev_uri": null
            }
        }
    },
    "data": [
        {
            "id": 88,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 88,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": false,
                "reportback_items": {
                    "total": 3,
                    "data": [
                        {
                            "id": 1,
                            "status": "accepted",
                            "caption": "post 1",
                            "uri": null,
                            "media": {
                                "uri": "default",
                                "type": "image"
                            },
                            "created_at":<PHONE_NUMBER>,
                            "kudos": [
                                {
                                    "id": 26,
                                    "term": "heart",
                                    "reportback_item": 1,
                                    "user": "1234",
                                    "uri": null
                                },
                                {
                                    "id": 31,
                                    "term": "heart",
                                    "reportback_item": 1,
                                    "user": "5589c991a59dbfa93d8b45ae",
                                    "uri": null
                                }
                            ]
                        },
                        {
                            "id": 151,
                            "status": "pending",
                            "caption": "cam[y",
                            "uri": null,
                            "media": {
                                "uri": "https://s3.amazonaws.com/ds-rogue-prod/uploads/reportback-items/78-482cab927f6529c7f5e5c4bfd2594186-1497384143.jpeg",
                                "type": "image"
                            },
                            "created_at":<PHONE_NUMBER>,
                            "kudos": [
                                {
                                    "id": 26,
                                    "term": "heart",
                                    "reportback_item": 1,
                                    "user": "1234",
                                    "uri": null
                                },
                                {
                                    "id": 31,
                                    "term": "heart",
                                    "reportback_item": 1,
                                    "user": "5589c991a59dbfa93d8b45ae",
                                    "uri": null
                                }
                            ]
                        },
                        {
                            "id": 152,
                            "status": "pending",
                            "caption": "did i break this?",
                            "uri": null,
                            "media": {
                                "uri": "https://s3.amazonaws.com/ds-rogue-prod/uploads/reportback-items/88-482cab927f6529c7f5e5c4bfd2594186-1497467970.jpeg",
                                "type": "image"
                            },
                            "created_at":<PHONE_NUMBER>,
                            "kudos": [
                                {
                                    "id": 26,
                                    "term": "heart",
                                    "reportback_item": 1,
                                    "user": "1234",
                                    "uri": null
                                },
                                {
                                    "id": 31,
                                    "term": "heart",
                                    "reportback_item": 1,
                                    "user": "5589c991a59dbfa93d8b45ae",
                                    "uri": null
                                }
                            ]
                        }
                    ]
                }
            }
        },
        {
            "id": 89,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 89,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 90,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 90,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 91,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 91,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 100,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 100,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 101,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 101,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 102,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 102,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 103,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 103,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 104,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 104,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 105,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 105,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 106,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 106,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 107,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 107,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 108,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 108,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 109,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 109,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 110,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 110,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 111,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 111,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 112,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 112,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 113,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 113,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 114,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 114,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        },
        {
            "id": 115,
            "created_at":<PHONE_NUMBER>,
            "campaign_run": {
                "id": 1843,
                "current": true
            },
            "uri": null,
            "campaign": {
                "id": 1360,
                "title": "Solitary Statements",
                "campaign_runs": {
                    "current": {
                        "en": {
                            "id": "1843"
                        }
                    },
                    "past": []
                },
                "language": {
                    "language_code": "en",
                    "prefix": "us"
                },
                "translations": {
                    "original": "en",
                    "en": {
                        "language_code": "en",
                        "prefix": "us"
                    }
                },
                "tagline": "Create a visual petition to protest youth solitary confinement.",
                "status": "active",
                "type": "campaign",
                "reportback_info": {
                    "copy": "Let's see the pics you sent to Attorney General Holder -- make a collage and submit it, or submit multiple pics!",
                    "confirmation_message": "Thanks for fighting against the use of youth solitary confinement.",
                    "noun": "Pictures",
                    "verb": "Sent"
                }
            },
            "reportback": {
                "id": 115,
                "created_at":<PHONE_NUMBER>,
                "updated_at":<PHONE_NUMBER>,
                "quantity": 3,
                "uri": null,
                "why_participated": "3",
                "flagged": null,
                "reportback_items": {
                    "total": 0,
                    "data": null
                }
            }
        }
    ]
}

@DFurnes this is ready for another review! Rebased with @katiecrane 's changes in this PR.


[BUG]: Renaming Tables errors out on Turso

What version of drizzle-orm are you using?
0.28.2
What version of drizzle-kit are you using?
0.19.12
Describe the Bug
While planning schema, had to rename a few tables, and encountered this error.
On turso db, while running drizzle-kit push:sqlite

Expected behavior
The command drizzle-kit push:sqlite to work flawlessly.
Environment & setup
On my local machine, with a remote turso db.

Just found an issue. Fixing that

Just to double-check, did you make any other changes besides renaming?

Nope, just the renaming changes.

should be fixed in<EMAIL_ADDRESS>

@AndriiSherman, I maybe wrong on just the renaming changes,
This still happens on<EMAIL_ADDRESS>I get the same error.
Now, that there are 4 tables in db, device, log, space & user (user wasn't renamed, hence it didn't appear in the first comment).
I also deleted the migrations folder(I know I shouldn't have done this, but this is a dummy project),
Now, when I remove all tables from schema.ts except user, I still get the same columns of undefined error.

Humble Suggestion: Maybe, we could look into introspecting the db before pushing, if thats not too much, and have it display the conflicts/errors, instead of columns of undefined error.
Let me know, If this can be a good-first-issue, I can offer some help, or maybe guide me into fixing this.


Met "Missing or more than one assembly archive file *.tar.gz in /deployments" in karaf-camel-amq pod

It's failed to create camel-amq app due to miss file *.tar.gz in /deployments.
The steps to reproduce:

git clone https://github.com/fabric8io/ipaas-quickstarts.git
cd ipaas-quickstarts/quickstart/karaf/camel-amq/
mvn clean install docker:build
Push docker image to Docker Hub
docker tag -f fabric8/karaf-camel-amq:2.3-SNAPSHOT chunyunchen/karaf-camel-amq:2.3-SNAPSHOT
docker push chunyunchen/karaf-camel-amq:2.3-SNAPSHOT
Log into OpenShift and create a project
oc new-project chun
Create camel-amq app
oc new-app --docker-image=chunyunchen/karaf-camel-amq:2.3-SNAPSHOT
Check the logs of camel-amq pod
$ oc logs karaf-camel-amq-2-gdyf8
Checking for *.tar.gz in /deployments
Missing or more than one assembly archive file *.tar.gz in /deployments

@chunyunchen  Are you building on java 1.8.0?
'[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project karaf-camel-amq: Fatal error compiling: invalid target release: 1.8 -> [Help 1]'

@xiazhao2015 yes, the error you met will gone when using 1.8.0


Drop Python version range enforcement from PythonVersion::from_str

This caused some problems earlier, as it prevented us from listing Python versions <3.7 which seems weird (#7131)
I'm worried that without this the changes to installation key parsing in https://github.com/astral-sh/uv/pull/7263 would otherwise be too restrictive.
I think if we want to enforce these ranges, we should do so separately from the parse step.

@konstin looking to add this validation somewhere but not sure where it belongs
It looks like this error variant is never used?
https://github.com/astral-sh/uv/blob/4f2349119cf341eedf738d06a50ed136a5f207db/crates/uv-python/src/interpreter.rs#L560-L561
We probably need to check this during version requests too?
For future reference, explicit validation looks like this
diff --git a/crates/uv-python/src/python_version.rs b/crates/uv-python/src/python_version.rs
index 6c4a99487..db83bb4ac 100644
--- a/crates/uv-python/src/python_version.rs
+++ b/crates/uv-python/src/python_version.rs
@@ -165,6 +165,18 @@ impl PythonVersion {
         Self::from_str(format!("{}.{}", self.major(), self.minor()).as_str())
             .expect("dropping a patch should always be valid")
     }
+
+    /// Returns an error if the Python version is not supported.
+    pub fn check_supported(&self) -> Result<(), String> {
+        if version.version < Version::new([3, 7]) {
+            return Err(format!("Python version `{s}` must be >= 3.7"));
+        }
+        if version.version >= Version::new([4, 0]) {
+            return Err(format!("Python version `{s}` must be < 4.0"));
+        }
+
+        Ok(())
+    }
 }

 #[cfg(test)]

We should be filtering out too old interpreters at https://github.com/astral-sh/uv/blob/c9774e9c435b49e19cba54c6bdeb458849a7f5cd/crates/uv-python/python/get_interpreter_info.py#L446

Ah okay so it's constructed by the deserializer. Lgtm then.


plot to sanity check predictions

In one row, show rgz, norris, Fan et. al. and our own predictions.

Here's a couple of different ways the image could be scaled. I want a method that doesn't pack too many values down to the same value, and spreads out the distribution a lot. Constant stretching and logarithms look like good ideas.

How about log(x+1) where x is the pixel value? You want to avoid log(0), but at the same time there are a lot of black pixels, which you want to remain black.

+1 gives almost the same results as just using the original image. It's still a very sharp peak and hard to make out features.

Ok then. Constant stretching looks good from your plots.

I agree. My worry is that it bunches up a little at the top — so lots of bright areas have the same value.
For actually displaying, constant stretching is good, but I'm curious as to whether it would work as a pre-CNN filter.

The saturation at the top (255) and bottom (0) probably need some other procedure. Steve Gould recommended doing a Gaussian smoothing over the image to reduce the saturation at the top. At this point, I don't think it is worth it. I suggest that you get your code working (with good instructions), and then I'll try to convince one of his PhD students to optimise your CNN pipeline.

Sounds good. I think that even with the saturation it's probably better than the original, so I'll implement the stretching (pretty easy to do), train a CNN, and see how it goes.

Have you tried clipping + a sqrt or an asinh stretch?   These are the common stretches used by astronomers too.

I hadn't. Just tried sqrt which looks quite good. Not sure how to do an asinh stretch so I'll investigate that.

Here's the probabilities output by the classifier (circles), with larger/pinker circles representing higher probabilities. Green stars represent Norris et al. labels.

3ef72b2caa50f5127d67df2d065644f90271fec5


JCenter() alternative

Hi, I was just wondering if you have any plans to release this on Maven Central, or some other maven repository host, now that jcenter has been shut down: https://developer.android.com/studio/build/jcenter-migration.
Thank-you for your time.

Hi, I have plans to migrate this library to Maven Central.
Please wait for a while until the work is completed.

That's great! Thanks for your prompt reply.

@vewert I have released version 1.4.0 on Maven Central.
Available at implementation com.kazakago.cryptore:cryptore:1.4.0.
Please confirm! 🙏
If you face problems, please open an issue.

I updated to 1.4.0, which is available on Maven Central, so I can now remove my dependency on jcenter()!
I did a quick test of the new version with my app and it looks fine so far, thank-you so much for your quick response to this!

I can now remove my dependency on jcenter()!

That's great!!!!


Find a way to safely dispose streams

As pointed out in, https://github.com/simolus3/moor/issues/74#issuecomment-510961063, streams can be listened to multiple times. When users write code like
var stream = getMyQueryStream();
var stream2 = getMyQueryStream();
await stream.first; // listens and cancels
stream2.listen(...)

The stream and stream2 instances are managed by the same cache entry, in particular they share the same BroadcastStreamController. Of course, stream2 should still emit data, so we can't ever close the underlying stream controller. The controller will be garbage collected when its no longer used, but we should find a way to control this nevertheless.

Gave #3407c8e a test and it working. Thanks for the quick fix

The trade-off with that fix is that we never call .close() on the underlying StreamController. I guess this is ok, as

each listener is supposed to unsubscribe when he doesn't want to receive updates (StreamBuilders do this)
users are supposed to not reference the Stream returned by .watch() when they're done with it.

So we can assume that the StreamController will be garbage-collected and we don't have to call .close()


position on mobile trade page is missing price

Story details: https://app.clubhouse.io/augur/story/18008

Coverage remained the same at 56.073% when pulling f40edd784472c718db334793d2adb8244312becf on phoebemirman/ch18008/position-on-mobile-trade-page-is-missing into 3068d5d3dce2e7fcc42349db830608844f21542f on master.


[NLP] Add post renderers for embedding quote tweets in prompts

subtask of #89

[ ] Add backwards compatibility for existing prompts

Next up:

[ ] add quoted urls to quote tweet ref urls
[ ] make sure using QuoteRefPost instead of refpost where relevant
[ ] write quote tweet renderer

[ ] update prompt templates for topic and keywords as well

[ ] add quoted post content to metadata summary in prompt


[RFC] create: support oci spec memory limit

We should run VM(container) regarding oci config.json memory limit.
Fixes #381
Signed-off-by: WANG Chao<EMAIL_ADDRESS>

ping @grahamwhaley @jodh-intel
What do you think about https://github.com/clearcontainers/runtime/pull/390#discussion_r132362833
Can we leave extra memory for VM kernel out of this patch? We can come back when we have a better solution.

Hi @wcwxyz Yeah, I have been thinking on this :-)
So, thanks for the numbers, that really does help some.
Indeed, as you show, it is not a nice linear overhead. I believe there will be a static overhead (fixed kernel objects etc.), and then there is a more dynamic overhead that scales with the amount of memory - particularly the space and tables the kernel has to allocate at boot to map and manage the memory.
I think we are fine to go ahead without the extra VM overhead for now. It will only really affect the very small memory cases.
Just some extra notes:

I see you tested with centos. I deliberately chose alpine as possibly the smallest workload I could find so that workload overheads featured less in the results. if/when we pick this up again we can try multiple workloads to correlate.
just for reference, work that was done in rkt had a similar situation, and a similar simple solution - but, yes, more analysis and a more qualified solution would be nice: https://github.com/rkt/rkt/commit/f44c604a4367ba72f47cebece6515d73980c07db

@grahamwhaley Thanks for your input. I'll do more investigation later if I got a chance.

Coverage decreased (-0.7%) to 54.684% when pulling 7af965ffa99f6a9b042dfec25cb5e8f79cf5258f on wcwxyz:per-container-memory into 2eeb4f49cb4aa60a76bfedc6442dc142131fa054 on clearcontainers:master.

Coverage decreased (-0.7%) to 54.684% when pulling 7af965ffa99f6a9b042dfec25cb5e8f79cf5258f on wcwxyz:per-container-memory into 2eeb4f49cb4aa60a76bfedc6442dc142131fa054 on clearcontainers:master.

Coverage decreased (-0.7%) to 54.684% when pulling ffe8c191bc704adf75dfef626e240fc306d5edd6 on wcwxyz:per-container-memory into 2eeb4f49cb4aa60a76bfedc6442dc142131fa054 on clearcontainers:master.

Coverage decreased (-0.8%) to 54.607% when pulling cd5cdf3872e386e922ce3ded90840ca91ed50a5e on wcwxyz:per-container-memory into 2eeb4f49cb4aa60a76bfedc6442dc142131fa054 on clearcontainers:master.

This PR is a no-go for me because this has to happen in the oci package defined in virtcontainers repo: https://github.com/containers/virtcontainers/blob/master/pkg/oci/utils.go
The reason for this package is to translate OCI to virtcontainers structures directly and that's why we decided to put this into the virtcontainers repo.
-1

@sboeuf I understand.
The problem is we need to translate OCI spec spec.Linux.Resources.Memory.Limit to RuntimeConfig runtime.VMConfig.Resources.Memory. If it happens in virtcontainer internally, this will be opaque to runtime.
How do you like adding a exported function in oci package to update RuntimeConfig, and runtime call this function?

The runtime does not need to know about the internal way every option is translated. This means that from the runtimeConfig, the oci.Podconfig() or oci.ContainerConfig() function will translate this into virtcontainers structures.
The reason why we want this inside the oci package is that if someone wanted to write another runtime also based on OCI spec and relying on virtcontainers library, this code would be shared, which is what we expect. You have to see this runtime as a tiny wrapper on top of virtcontainers, nothing more.

Emm, ok. I'll do that in oci pkg.
I have a question though.  When both OCI spec and RuntimeConfig has set memory, which should we honor?

There is no way to set max memory with runtimeConfig, only a default value, therefore I don't think there is any conflict.

I close this one since https://github.com/containers/virtcontainers/pull/341 is the replacement.


MavenConversionIntegrationTest: Use replace() instead of replaceAll()

Context
replaceAll() takes a regex, but we do not provide one. Use replace()
instead, which despite its name also replaces all matching substrings.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Sign Gradle CLA
[ ] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective (already existing since this is a fix to tests)
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs
[ ] Recognize contributor in release notes

Hi @sschuberth,
Thanks for the pull request.  This change is purely aesthetic, right?  Or is it causing some sort of warning in a code analysis tool?

In this case, yes, the change is purely "cosmetic" as 'LOCAL_MAVEN_REPO_URL' happens to be both a valid regex and a plain string. But I consider it to be good practice to only use the more powerful replaceAll() if that additional power is actually needed. IMO replace() is clearer here and should also save some CPU cycles ;-)

Because it's purely cosmetic and only in test code, I am going to close this PR (without merging).  I'm not even sure that the more clearly named method replaceAll() doesn't outweigh the minimal performance hit.


[BUG] Clicking Copy Button Should Copy Link, Not Clicking Share Button

Description
Currently, clicking the Share button automatically copies the link to the clipboard. This is not the intended behavior. The link should only be copied when the user clicks on the Copy button that appears after clicking the Share butto
Expected behavior:
Clicking the Share button should display a Copy button. The link should only be copied to the clipboard when the Copy button is clicked.
Actual behavior:
The link is copied to the clipboard immediately upon clicking the Share button.
Reproduction Steps
1]Navigate to POWER OF KNOWLEDGE BLOG page
2]Click on the Share button.
4]Observe that the link is immediately copied to the clipboard.
Screenshots

@akshitagupta15june  Please assign this to me so that I can add functionality to the copy icon.

Go for it!


Add UX Sync unit tests

Description
The goal of this PR is to add unit-tests for UX Sync library, in order to improve code coverage of this library
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[*] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (b48130d) to head (126cb45).

Files
Patch %
Lines

lib_ux_sync/src/ux_sync.c
57.14%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   60.20%   60.61%   +0.40%
==========================================
  Files          12       13       +1
  Lines        1729     1813      +84
==========================================
+ Hits         1041     1099      +58
- Misses        688      714      +26

Flag
Coverage Δ

unittests
60.61% <57.14%> (+0.40%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


3.55a broke this plugin?

*updated: it's ACT FFXIV Plugin Problem
Since 3.55a I can't start ACT when FF14 (DX11) is running, it's stuck on Loading Settings/Plugins windows
I need to run ACT before FF14 or disable ACT.SpecialSpellTimer to run ACT when FF14 is running

Hi
I had the same issue when I disabled and reenabled some of the plugins.
This apparantly threw off the order the the plugins were loaded.
go to
"users/NAME/AppData/Roaming/Advanced Combat Tracker/Config" folder
and find "Advanced Combat Tracker.config.xml"
within this file find the  section
rearrange the plugins that FFXIV_ACT_Plugin comes first.
mine looks like that now:

So SupeSupe seems to load last now again. Since I changed this I havent had any issues again loading ACT up.
Hope this helps.

It's worked
Thank you Exodus1028 for the answer


radiospectra.sources.callisto - failing to open eCallisto files with incorrectly formatted end time

Describe the bug
eCallisto provides fits files that can have an incorrect timestamp (this happens with files created at 23:45:00 and after), which [radiospectra.sources.callisto  CallistoSpectrogram read() ]
tries to open, but doesnt factcheck the timestamp
ValueError: Input values did not match any of the formats where the format keyword is optional: {'datetime': TypeError('Input values for datetime class must be datetime objects'), 'ymdhms': ValueError('input must be dict or table-like'), 'iso': ValueError('Time 2022/01/01T24:00:06 does not match iso format'), 'isot': ValueError('Time 2022/01/01T24:00:06 does not match isot format'), 'yday': ValueError('Time 2022/01/01T24:00:06 does not match yday format'), 'datetime64': TypeError('Input values for datetime64 class must be datetime64 objects'), 'fits': ValueError('Time 2022/01/01T24:00:06 does not match fits format'), 'byear_str': ValueError('Time 2022/01/01T24:00:06 does not match byear_str format'), 'jyear_str': ValueError('Time 2022/01/01T24:00:06 does not match jyear_str format'), 'astropy_time': TypeError('Input values for astropy_time class must all be same astropy Time type.')}
To Reproduce
from radiospectra.sources.callisto import CallistoSpectrogram
import radiospectra.sources.callisto as cal
from astropy.io import fits
from datetime import datetime

time = datetime(2022,1,1,23,48)
station = "KASI"

url_list = cal.query(time, time, [station])
cal.download(url_list, "./")

file = "./KASI_20220101_234506_59.fit.gz"

with fits.open(file) as open_file:
    print(f'start: {open_file[0].header["DATE-OBS"]} {open_file[0].header["TIME-OBS"]}')
    print(f'end:   {open_file[0].header["DATE-END"]} {open_file[0].header["TIME-END"]}')

fail_to_open = CallistoSpectrogram.read(file)

Screenshots
No response
System Details
Python version 3.8 , 3.9
Windows and Linux
radiospectra==0.3.0
sunpy==3.1.3
Installation method
pip

Thanks for the report, do you happen to have a URL so I can download the file?

Thanks, I will investigate and see if I can work out how to fix it.

Hum ok I guess need to add a try catch around parsing the date and then look for a 24th hour 😆 from e.g 2022/01/01T24:00:06

So once #84 is merged this should be fixed. There has been a significant change to radiospectra so I've included update code for the example above here.
from matplotlib import pyplot as plt
from sunpy.net import Fido, attrs as a

from radiospectra import net
from radiospectra.net import attrs as ra
from radiospectra.spectrogram import Spectrogram

query = Fido.search(a.Time('2022-01-01T23:45', '2022-01-01T23:59'),
                                   a.Instrument.ecallisto, ra.Observatory('KASI'))
query
# <sunpy.net.fido_factory.UnifiedResponse object at 0x11ce42550>
# Results from 1 Provider:
#
# 1 Results from the CALLISTOClient:
#
#        Start Time               End Time         Provider Instrument Observatory  ID
# ----------------------- ----------------------- --------- ---------- ----------- ---
# 2022-01-01 23:45:06.000 2022-01-02 00:00:05.999 ECALLISTO  ECALLISTO        KASI  59
file = Fido.fetch(query)
spec = Spectrogram(file[0])
spec.plot()
plt.show()

With the current version of the software this is still an issue
from sunpy.net import Fido, attrs as a

from radiospectra import net
from radiospectra.net import attrs as ra
from radiospectra.spectrogram import Spectrogram

query = Fido.search(a.Time('2022-01-01T23:45', '2022-01-01T23:59'),
                    a.Instrument.ecallisto, ra.Observatory('KASI'))
query
<sunpy.net.fido_factory.UnifiedResponse object at 0x10bc4d370>
Results from 1 Provider:

1 Results from the CALLISTOClient:

       Start Time               End Time         Provider Instrument Observatory  ID
----------------------- ----------------------- --------- ---------- ----------- ---
2022-01-01 23:45:06.000 2022-01-02 00:00:05.999 ECALLISTO  ECALLISTO        KASI  59

file = Fido.fetch(query)
spec = Spectrogram(file[0])
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
...


feat: add Switch component

[!TIP]
It would be nice to have keyboard interaction in our form input components. Based on W3:
Space: When focus is on the switch, changes the state of the switch.

Please import your component in docs/components/[component].md file.


FIX Remap versioned ClassNames during build process

Problem
Missed ClassName remapping causes the default "Getting Started" page to render if the home page is a custom class (extending Page). Since the Live table will use HomePage and not be able to resolve it to a controller, then falls back to SiteTree  and renders a default template.
Re-publishing the page from admin fixes the problem, as the ClassName is updated to a FQCN.

Fix
This prevents the current behaviour from happening during DatabaseAdmin::doBuild:
mysql> select a.ClassName, b.ClassName, c.ClassName from SiteTree as a inner join SiteTree_Versions as b on a.ID = b.ID inner join SiteTree_Live as c on a.ID = c.ID where a.URLSegment = 'home';
+--------------------------+-----------+-----------+
| ClassName                | ClassName | ClassName |
+--------------------------+-----------+-----------+
| MyProject\Model\HomePage | Page      | HomePage  |
+--------------------------+-----------+-----------+
1 row in set (0.00 sec)

Updated behaviour:
mysql> select a.ClassName, b.ClassName, c.ClassName from SiteTree as a inner join SiteTree_Versions as b on a.ID = b.ID inner join SiteTree_Live as c on a.ID = c.ID where a.URLSegment = 'home';
+--------------------------+-----------+--------------------------+
| ClassName                | ClassName | ClassName                |
+--------------------------+-----------+--------------------------+
| MyProject\Model\HomePage | Page      | MyProject\Model\HomePage |
+--------------------------+-----------+--------------------------+

This seems a pretty delicate operation - is it possible to unit test this?

@dhensby I guess if I manually create some dodgy database records and trigger a build within a SapphireTest, that might do it?

Yes, but might also be a massive pain.. if you're feeling brave....

I'm not, at the moment :)


Package broken on Ubuntu Bionic

Problem Description
This package is unable to build on Ubuntu bionic

I will look at this after the presentation


transpose() --> transpose(1,0) for dim=2

For matrices, it makes sense that A.transpose() would transpose the only two dimensions. It's a special case which is undesirable, but there's no other possibility and it's clearly what's intended, which is desirable. Not sure whether this would be a minor or major version increment since .transpose() was technically a noop before (I believe?). Just a suggestion to make the API as unsurprising as possible for newcomers, but disagreement welcome.

Yeah, this is an unnecessary bell/whistle. .transpose(1,0) seems fine.


add the ability to preview  screenshot

Merged > https://github.com/KirisameMarisa/BocchiTracker/pull/61


Add 'deprecated' condition to Subscription status

As an OLM user, I would like to know when a Subscription has a deprecated Operator installed.
Acceptance Criteria:

When the catalog entry used by a Subscription is marked as "deprecated", the "Deprecated" condition will be added to the Subscription status.
Tests are written

This is closely related to the tests defined in https://github.com/operator-framework/operator-lifecycle-manager/issues/3103


Add more checks to CI

Add --examples and --tests flags to cargo clippy to make it check examples and tests
Add --examples to cargo build to also build examples

Before these changes it was possible to submit an example that doesn't compile and CI would pass

Maybe add -- --test-threads=1 to cargo test, since database tests can conflict when running parallel

Maybe add -- --test-threads=1 to cargo test, since database tests can conflict when running parallel

I didn't notice that the tests could conflict, good catch
test_unprepared_statement and test_batch  used the same table ks.t
I fixed them so that now all tests are  independent of each other so we can probably leave multiple threads until there will be some tests that require a single thread

I didn't notice that the tests could conflict, good catch
test_unprepared_statement and test_batch  used the same table ks.t
I fixed them so that now all tests are  independent of each other so we can probably leave multiple threads until there will be some tests that require a single thread

Clippy got an update with new warnings, I guess I can just fix this in this PR since it updates CI anyway

Clippy got an update with new warnings, I guess I can just fix this in this PR since it updates CI anyway


Add corresponding article version to comment and donation records

Description
After article versioning implementation, we also want comment and donation data have corresponding article version.
Todos

[ ] Migration
[ ] API updates

Stories

https://github.com/thematters/developer-resource/issues/321

article_translation


[proposal] move examples out of pnpm workspace

Clear and concise description of the problem
The projects under examples folder are currently in the pnpm workspace, which causes slow installation. And it would become slower as the number of examples grows,
Since the examples are hosted at StackBlitz, and don't involve any development or CI process, I thought it might be better to move these out of pnpm workspace.
Just tested it locally: The line number of pnpm-lock.yaml went from 20k+ to less than 10k
Suggested solution
Move examples out of pnpm workspace.
I'll submit a PR if this can be agreed.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I approve 👍🏻

We are using them for CI tests.

We are using them for CI tests.

Can we have sub-monorepo? :P

We are using them for CI tests.

Oh, I missed that. The CI did fail: https://github.com/vitest-dev/vitest/runs/6751171711?check_suite_focus=true
I'll look into it later to find better solution

Sub-monorepo will cause more duplication and it would be more complex to link-local packages for testing.
I guess if you really want to reduce the packages installed you might want to use pnpm install --fitler ./packages/* (I didn't test).


floorist: add separate blueprint floorist query (HMS-4496)

In case you feel like we need to keep the blueprints in the first query, we can do so.

Alright! So, I kept all the info we have for builds, including the version_id, blueprint_id, and a deleted_at. Even deleted_at might help us know more if we see that the blueprint was never built and was deleted.
So this just adds a new query now, and is rebased.

Of course, you are right, guys. I tested the query now, and this now would really work.

Schulz is red

Let's try after rebase:)

Meh, this failed again, even though I do not think the failure is related. :thinking:

Yeah probably unrelated, let me click the retry button and lets see :)

Nice! Thanks! :orange_heart:


use of wrong pattern to get variable value

In src/app/core/services/common/reuse-strategy.ts
// 是否允许复用路由
shouldDetach(route: ActivatedRouteSnapshot): boolean {
// 是否展示多页签，如果不展示多页签，则不做路由复用
let isShowTab = false;
this.isShowTab$.pipe(takeUntilDestroyed(this.destroyRef)).subscribe(res => {
isShowTab = res.isShowTab;
});
return route.data['shouldDetach'] !== 'no' && isShowTab;
}
This is a pattern for synchronous execution, but using subscribe on an observable results in asynchronous execution. The value of the variable isShowTab when evaluating the condition (return route.data['shouldDetach'] !== 'no' && isShowTab;) may not be as expected
Consider using :
// 是否有多页签，没有多页签则不做路由缓存
isShowTab$ = inject(ThemeStoreService);
.
.
.
shouldDetach(route: ActivatedRouteSnapshot): boolean {
// 是否展示多页签，如果不展示多页签，则不做路由复用
let isShowTab = this.isShowTab$.getCurrentThemesMode().isShowTab;
return route.data['shouldDetach'] !== 'no' && isShowTab;
}
.
.
.
.
adding to theme-store.service :
getCurrentThemesMode(): SettingInterface {
return this.themesMode$.getValue();
}

@factorx22 Thank you very much for your issue. In my understanding, rxjs can be executed synchronously in this way. Maybe your way might be easier to understand. If you have any questions, please continue to discuss with me。

@factorx22 If you have any questions, please reopen this issue


pkg/endpoint: simplify state directory synchronization

BPF regeneration writes state into a new temporary directory. Once it has succeeded we need to swap the old and new directory. This is currently achieved by "backing up" the current state by renaming the directory. This code has a bunch of corner cases around cleaning up old directories and so on.
Instead, use the RENAME_EXCHANGE flag to atomically exchange the two existing directories.

/test

/test

/test

/test

Thanks for the fix @lmb! Since this issue #15446 can be hit in any version, should we backport it to 1.13, 1.14, 1.15?

My gut feeling is that we'd only backport this if there is evidence of this happening in the wild. Do you see these? (Also some of these versions are EOL, so no backports will happen regardless.)


Fix AbstractBinderTests to populate properties

Some tests in AbstractBinderTests are rely on the partition header,
but that one can be populated only by the PartitionInterceptor.
To allow it we need to provide appropriate producer properties, like
partitionKeyExpression.

Populate test-based ProducerProperties to the
createBindableChannel() where PartitionInterceptor is populated
Fix checkstyle.xml static imports rule for Mockito-2.x as the
current base line

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6d22d03). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1161   +/-   ##
=========================================
  Coverage          ?   61.21%
  Complexity        ?      719
=========================================
  Files             ?      123
  Lines             ?     3491
  Branches          ?      502
=========================================
  Hits              ?     2137
  Misses            ?     1150
  Partials          ?      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d22d03...a37ace2. Read the comment docs.

OK! How about now?
Thanks

Merged as 7d2e3a38150bb509359a64ec4ececaa5f734cc16


Generator Templace also for JSdoc?

Would it be possible to get the typedoc template also for JSDoc because it is so beautiful :)

The TypeDoc theme relies on a lot of information which is provided by the TS compiler API. While it is theoretically possible that a similar theme could be created for JSDoc, it is out of scope for this project.


Exercise 2.2 - nested list incorrect

Not entirely sure why my nested list solution is wrong. I get the correct values for ylist and tlist, and just created a new list with variable name displacement where ylist and tlist are the elements

Hi @acse-92d36642, thank you for your question. If a is a list, then [a] will create a list in a list. displacement should be defined as:
displacement = [list, ylist]

I hope this answers your question. Please feel free to reopen this issue.


renovate: temporarily do not update GoBGP

Due to a breaking change in GoBGP v3.24.0, do not update GoBGP until the issue https://github.com/osrg/gobgp/issues/2777 is resolved and a new version is released.
Hit by CI in https://github.com/cilium/cilium/pull/31112

/test


[R] write_feather does not follow system-level umask setting

It appears that when using write_feather in R, it does not follow system-level umask settings.
When writing files using write_feather with a Sys.umask setting of 002, they appear to write files with rw-r--r-- permissions, which I would associate with a umask of 022. When I write files immediately after that while using write.csv, they write appropriately with rw-rw-r-- permissions.
I applied basically the same tests that were used in this issue (similar behavior that was happening with fwrite) https://github.com/Rdatatable/data.table/issues/2049
library(feather)
Sys.umask(mode = "002")
Sys.umask()

2

filename <- "~/Desktop/umask_test.feather"
system(paste0("rm ", filename))
test_df <- data.frame(x=c(0,1))
write_feather(test_df, filename)
system(paste0("ls -la ",filename))

-rw-r--r--  1 gngu  50513  176 Nov  9 09:23 /Users/gngu/Desktop/umask_test.feather

write.csv(test_df, "~/Desktop/umask_test.csv")
system("ls -la ~/Desktop/umask_test.csv")

-rw-rw-r--  1 gngu  50513  19 Nov  9 09:23 /Users/gngu/Desktop/umask_test.csv

sessionInfo()

R version 3.3.2 (2016-10-31)
Platform: x86_64-apple-darwin13.4.0 (64-bit)
Running under: macOS Sierra 10.12.3

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] feather_0.3.1

loaded via a namespace (and not attached):
[1] hms_0.3      tools_3.3.2  tibble_1.3.0 yaml_2.1.14  Rcpp_0.12.12

We had the same problem (feather_0.3.1 as well) and solved it with this workaround:
#' Obtain the chmod octal number from umask.
#'
#' @details  Applies https://en.wikipedia.org/wiki/Umask#Mask_effect.
#' Note that newly created files should not be executable
#' even if umask says so. https://en.wikipedia.org/wiki/Umask#Exceptions
#' Use the boolean executable argument to control behaviour.
#'
#' @examples Sys.chmod(path, chmod_from_umask())
#' @export
chmod_from_umask <- function(umask = Sys.umask(), executable = FALSE){
  umask <- unlist(strsplit(str_pad(umask, 3, pad = '0'), split = ''))
  bitop <- function(i) {
    packBits(intToBits(7)
             & !intToBits(i)
             & !intToBits(!executable),
             type = 'integer')
  }
  paste(sapply(umask, bitop), collapse = '')
}

#' Wrapper around write_feather that obeys sys.umask
#'
#' This function is necessary, because
#' \code{feather::write_feather} does not obey sys.umask
#' \url{https://github.com/wesm/feather/issues/323}
#' @export
write_feather <- function(x, path){
  feather::write_feather(x, path)
  Sys.chmod(path, chmod_from_umask())
}

If you can reproduce this issue with the Feather implementation in arrow please open a JIRA issue with the Arrow project at http://issues.apache.org/jira. We're working to change feather to use arrow internally


Add sophia1ch and NhoxxKienn to perun Lab

Please include NhoxxKienn and sophia1ch to the perun lab. They are already in the MAINTAINERS file in one of our repos.

GitHub IDs to add: NhoxxKienn, sophia1ch
Lab to be added to: perun
Role:

Write

invites sent. I removed some emeritus folks, and missed that matthiasgeihs and manoranjith were maintainers on other repos. I've re-invited them


Various issues

The example in the readme doesn't compile. The derive now seems to be called "Delta" instead of "Deltoid".
It's strange to require two crates: for example, with serde you just import Serialize from serde with the derive feature enabled, and then you can derive Serialize/Deserialize. serde_derive is an implementation detail that shouldn't be used directly by end-users.
#[derive(Delta)] macro expands to code which references serde_derive. Instead, deltoid should re-export all names required by macros under a deltoid::hidden module so that only the deltoid crate name needs to be accessible in the macro scope.
The derive macro itself is not documented, and it would be useful to add options like "opaque" (see https://docs.rs/serde-diff/0.4.1/serde_diff/derive.SerdeDiff.html for example)

Closed this issue due to inactivity from OP.


implement type-ahead for auto-completion

this is for having first candidate from pumvisible to be inserted in front of the cursor tentatively.
it really just comes down to the difference between autocompletion (we already have that) and typeahead as loosely define here:
https://www.flextras.com/blog/index.cfm/2011/3/11/The-Difference-Between-AutoComplete-and-LookAhead
here is an animation of typeahead in action:
https://www.arungudelli.com/wp-content/uploads/2013/10/Twitter-Typeahead-js.gif
xcode, apparently, has this implemented already:
https://i.stack.imgur.com/k8PRF.png

This is how completion already works.  With the default value for 'completeopt', the full text for the first match is inserted.
If you press <C-e> to cancel the completion, then whatever text you've explicitly typed remains, instead of what was inserted by the completion.
If you press <C-y> to accept the completion, it remains and the cursor is at the end of the text.
Otherwise, you can continue to type to refine the matches.
The only difference is that the animations you show leave the cursor at the end of the text that the user has typed and shows the completed text after the cursor (and faded).  There's no functional difference, just eye candy.

Would a different highlight group for the type-ahead part be useful in this case? Then colorscheme authors could define a lower contrast color for the part that is inserted with ins-completion but not yet accepted with <C-y>.