Versioned clients

Right now, pkg/client auto-converts everything to our internal, unversioned format. This is convenient for kubernetes components, but not so convenient for any 3rd party users. (The whole point of the versioning system is so that we can make changes to the unversioned structs without affecting downstream users.)
So we should maintain versioned clients.
It is possible that this is as easy as copying pkg/client and replacing the "pkg/api" imports with api "pkg/api/v1beta1". If so, we should do this soon. If it turns out to be much more complex than that, we can defer this change until after 1.0, I think.
When we deprecate an old client version, we should be nice and provide people a list of gofmt rewrite rules which will switch them to the next client version.

See #3955 and https://github.com/GoogleCloudPlatform/kubernetes/issues/1451#issuecomment-72144333.
Clients generating specific objects, such as kubectl run-container, should target a specific API version (or multiple specific versions).
Generic clients shouldn't be versioned. They should only get the schema via swagger.

On the timing of when to fix this. Goal is we want pkg/client users to work with versioned api types instead of unversioned types. So at some point we'll want to alias api to api/v1beta3 (in e.g. test code).
When we have v1beta3 as default but before we've accumulated many changes, then the diff between internal types and v1beta3 types should be minimized. ...so now would be a good time to think about doing this, actually.

cc @vishh

@lavalamp: My understanding was that we are are doing this before v1.0.
On Wed, Apr 1, 2015 at 10:24 AM, Brian Grant<EMAIL_ADDRESS>wrote:

cc @vishh https://github.com/vishh
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4874#issuecomment-88564790
.

I want to argue for a prio boost on this.  If we go 1.0 and we leave internal structs exposed, we're as good as frozen.
We should either
a) hide all the internal structs and have purely versioned client libs (how do we get DeltaFIFO and cache and controller framework etc for versioned?)
b) use swagger codegen to generate Go libs
c) not have a Go client library at all
Almost all of our own components would be better off with versioned interfaces, but I think all the work that has been done on client libs and controller framework has to apply.
I propose P2, enhancement, v1.0 milestone.  Needs an owner ASAP.

Casting aside the fact the either is not a ternary operator, if nobody else want to take this on then I'd be happy to help esp. if follow Daniel's proposal to have versioned Go client libraries but address the issues in (a). I think Brain said there were some technicalities to do with (b) w.r.t. encoding for a few fields but perhaps these could be overcome somehow. (c) would be a shame.

One option is to get an intern to work on (b) but it might be too little
too late
On Fri, Apr 10, 2015 at 12:04 AM, Satnam Singh<EMAIL_ADDRESS>wrote:

Casting aside the fact the either is not a ternary operator, if nobody
else want to take this on then I'd be happy to help esp. if follow Daniel's
proposal to have versioned Go client libraries but address the issues in
(a). I think Brain said there were some technicalities to do with (b)
w.r.t. encoding for a few fields but perhaps these could be overcome
somehow. (c) would be a shame.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4874#issuecomment-91457927
.

Swagger codegen for Go doesn't yet exist. And it doesn't yet work for any language for our API AFAIK.
There are no intrinsic blockers to codegen that I'm aware of. Some of the fields that require custom marshaling/unmarshaling would need custom client code, but that doesn't seem like a big deal. I don't think most clients would need complicated types, such as Resource Quantity. Users could just provide the strings.
If we have time, this would be great to do sooner rather than later. The problem will get bigger over time. I'm not sure there is a hard deadline, though.

Indeed swagger codegen for Go seems to be an open issue: https://github.com/swagger-api/swagger-codegen/issues/325
@bgrant0607 : let me be sure about what you mean. You mean "write a program that parses the swagger spec and spits out a Go client library?" Or do you mean something else?

My concern is that, based on our own experiences and the evolution of the
client-side caches and watch helper libs, the swagger generated client API
will be insufficient.
On Fri, Apr 10, 2015 at 9:23 AM, Satnam Singh<EMAIL_ADDRESS>wrote:

Indeed swagger codegen for Go seems to be an open issue:
swagger-api/swagger-codegen#325
https://github.com/swagger-api/swagger-codegen/issues/325
@bgrant0607 https://github.com/bgrant0607 : let me be sure about what
you mean. You mean "write a program that parses the swagger spec and spits
out a Go client library?" Or do you mean something else?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4874#issuecomment-91607391
.

/subscribe

If this is something that needs attention soon thenI am happy to direct some energy in this direction, although that may not please Tim since I am supposed to be learning about networking.

Package factoring to consider: #7584.

OK. Time to do this. The motivation is so that people can import pkg/client/v1 and have code that will continue to build against head without changes as long as v1 is supported.
Proposed factoring:

pkg/client/config
This has everything to do with certs, setup, etc.
pkg/client/rest
RESTClient moves here
pkg/client/unversioned
the current client.Client struct and interfaces move here.
pkg/client/v1
A copy of unversioned, but using pkg/api/v1 instead of pkg/api

I propose doing this in a few steps.

Copy pkg/client to pkg/client/v1 AND pkg/client/unversioned.
Change the import lines in pkg/client/v1 to go to pkg/api/v1.
Change references in the rest of the codebase to the appropriate client.
I know @bgrant0607 would love it if nothing ended up referencing pkg/client/unversioned. I wouldn't prioritize this at the moment. It's still a net improvement in that it will be clearly marked what uses v1 and what doesn't.
Extract common code into pkg/client/rest & pkg/client/config
This can happen in parallel with step 2.

On Tue, Jul 14, 2015 at 2:48 PM, Daniel Smith<EMAIL_ADDRESS>wrote:

OK. Time to do this. The motivation is so that people can import
pkg/client/v1 and have code that will continue to build against head
without changes as long as v1 is supported.
Proposed factoring:

pkg/client/config

This has everything to do with certs, setup, etc.

- pkg/client/rest
  - RESTClient moves here
- pkg/client/unversioned
  - the current client.Client struct and interfaces move here.
- pkg/client/v1
  - A copy of unversioned, but using pkg/api/v1 instead of pkg/api

Meaning you'll "lock down" this last one (it will reflect the unversioned
we have today, while pkg/client/unversioned will be the one that's always
up-to-date)?

I propose doing this in a few steps.

Copy pkg/client to pkg/client/v1 AND pkg/client/unversioned.

Change the import lines in pkg/client/v1 to go to pkg/api/v1.

2. Change references in the rest of the codebase to the appropriate

client.
1. I know @bgrant0607 https://github.com/bgrant0607 would love it
if nothing ended up referencing pkg/client/unversioned. I wouldn't
prioritize this at the moment. It's still a net improvement in that it will
be clearly marked what uses v1 and what doesn't.
3. Extract common code into pkg/client/rest & pkg/client/config
1. This can happen in parallel with step 2.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4874#issuecomment-121401567
.

Meaning you'll "lock down" this last one

Well, sort of-- I'll lock it down by changing the import line from "...pkg/api" to api "...pkg/api/v1.
There's no way to lock it down without doing this.

I'm working on a PR to do step 1 above. Then I'll try and draft some folks to help me do 2 & 3 in parallel.

Sorry, I accidentally replied by email which I think munged my question. Just trying to understand the difference between pkg/client/unversioned and pkg/client/v1
When we make changes to types.go, we'll make them in the former dir but not the latter, yes?

types.go is inside the pkg/api/ tree; I'm not copying that. But yes, there should be no backwards-incompatible changes inside pkg/api/v1 as of a month or so ago.

I still think we should discuss what our client library is.  Fat client
libs have a long history of coming back to bite people in the butt, but
"just a bunch of structs" is also problematic.  If we want to offer a
client library outside of our own codebase, we should start from the place
of deciding what feature set we want to offer to clients - not what structs
we can move around to suck less.
We're conflating two different things in pkg/api/v1 - it's simultaneously a
client lib (so make it reasonably friendly to use) and it's the thing we
use to decode JSON, including whatever tricks we pull to make it unmarshal
the way we want.
On Tue, Jul 14, 2015 at 3:42 PM, Daniel Smith<EMAIL_ADDRESS>wrote:

types.go is inside the pkg/api/ tree; I'm not copying that. But yes, there
should be no backwards-incompatible changes inside pkg/api/v1 as of a month
or so ago.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4874#issuecomment-121414271
.

I've started on #11280 and already found a number of places where we're not versioned as completely as we should be.

We're conflating two different things in pkg/api/v1

We should move conversion/registration functions out of v1; this solves that problem.

If we want to offer a client library outside of our own codebase, we should start from the place of deciding what feature set we want to offer to clients - not what structs we can move around to suck less.

I have a much more modest goal of just letting people write code against our v1 api, using our current client interface.
I want to make the addition of a versioned client now, offering our existing interface. That lets us give developers something we can promise to "keep working". We can fix things over time so that the thing we provide requires fewer and fewer dependencies (ideally, it would not depend on pkg/api!). But the important thing now is to get that interface up; we haven't yet drifted from v1 yet, so we can do this with minimum pain.
Otherwise folks will have to make changes in their code every time they fetch k8s from head.

It's hard to disagree with the goal, but I am very anxious abouyt exposing
to users the same struct that we use for unmarshalling.
As an example, I'd like to make ServicePort.NodePort into a pointer so we
don't always print it when it is 0.  From an API point of view that's a
transparent change - no client will see it.  After you make this change
we're more or less supporting the v1 structs as a published API forever.
I'd much rather say that officially we DO NOT HAVE A CLIENT LIBRARY YET.
People might link to our libs but they are not a client lib.
On Tue, Jul 14, 2015 at 6:09 PM, Daniel Smith<EMAIL_ADDRESS>wrote:

I've started on #11280
https://github.com/GoogleCloudPlatform/kubernetes/pull/11280 and
already found a number of places where we're not versioned as completely as
we should be.
We're conflating two different things in pkg/api/v1
We should move conversion/registration functions out of v1; this solves
that problem.
If we want to offer a client library outside of our own codebase, we
should start from the place of deciding what feature set we want to offer
to clients - not what structs we can move around to suck less.
I have a much more modest goal of just letting people write code against
our v1 api, using our current client interface.
I want to make the addition of a versioned client now, offering our
existing interface. That lets us give developers something we can promise
to "keep working". We can fix things over time so that the thing we provide
requires fewer and fewer dependencies (ideally, it would not depend on
pkg/api!). But the important thing now is to get that interface up; we
haven't yet drifted from v1 yet, so we can do this with minimum pain.
Otherwise folks will have to make changes in their code every time they
fetch k8s from head.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4874#issuecomment-121442377
.

As an example, I'd like to make ServicePort.NodePort into a pointer so we
don't always print it when it is 0.  From an API point of view that's a
transparent change - no client will see it.  After you make this change
we're more or less supporting the v1 structs as a published API forever.

Not to nitpick, but changing that to a pointer won't do what you want. It would just now let it print null instead of 0 when not initialized. You would have to add omitempty to the JSON field tag, and that would be an API change according to http://kubernetes.io/v1.0/docs/api-reference/definitions.html#_v1_serviceport

In the realm of strictly breaking changes this seems minor.  Is this likely
to cause any real problems?
On Mon, Jul 27, 2015 at 3:56 PM, krousey<EMAIL_ADDRESS>wrote:

As an example, I'd like to make ServicePort.NodePort into a pointer so we
don't always print it when it is 0. From an API point of view that's a
transparent change - no client will see it. After you make this change
we're more or less supporting the v1 structs as a published API forever.
Not to nitpick, but changing that to a pointer won't do what you want. It
would just now let it print null instead of 0 when not initialized. You
would have to add omitempty to the JSON field tag, and that would be an
API change according to
http://kubernetes.io/v1.0/docs/api-reference/definitions.html#_v1_serviceport
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4874#issuecomment-125373469
.

@thockin It depends on where you change it. If you do it in a way where a v1 client gets a message that doesn't have this field, any logic that depends on it being there (e.g. swagger spec based validation) will fail. I do not know how likely that is.
If you change it in a future version (say v1.1), you will just have an incompatibility, but v1 should still work. When clients upgrade our versioned client library from v1 to v1.1, they would see this field change and have to update the calling code.

What about:

experimental client
pkg/client/cache
pkg/client/metrics
pkg/client/record
pkg/kubectl/resource
#5660
#7584

The above WIP PR #13098 is a mess. To directly address those issues, I would
like to put RESTClient and Request into their own package that has no
dependencies on a version or group. Currently request.go has some custom
field selector filtering logic that depends on the version that I need to
understand. I think this would still leave it dependent on api.Status, but
we don't change that across versions/groups. I would also like to change it to
take the codec on each request instead of being embedded in the client. This
could allow multiple groups/versions to use the same RESTClient.
I would also like to move the VersionInterface and functionality into this
package as it is also independent of groups/versions.
There are some things which are in this package that I'm not sure belong in
the API client, but I don't know where I would put them. I'm open to
suggestions on:

KubeletClient
ContainerInfoGetter
flags.go

With those changes, the code left in the actual versioned clients should be
mostly boiler plate calls into this new package with the appropriate codecs
and type assertions on the return values.

@bgrant0607
My opinions on your concerns...

experimental client:
Should be it's own package separate from the versioned client.
pkg/client/cache:
We probably need to version the top level interface of this package as well.
Seems ripe for internal packages + code generation.
pkg/client/metrics:
I don't see a problem with this one. Is it version dependent in some way
that I don't see?
pkg/client/record:
What is the use case for this? Is it something a customer needs? Or
something we need internally? It might be ok to use runtime.Object
instead of concrete events for this.
pkg/kubectl/resource:
Still looking in to this one...
#5660 and #7584:
These goals are a way off. I think it would require a huge cleanup with our
many "schemes" and "codecs." I think the biggest step would be to completely
separate encoding/decoding from conversion. The only ones that should need
conversion are the API server and special utilities for upgrading various
resources. Another option is to just abandon the schemes and codecs in the
client code and roll our own simple ones. That with a types only package
from the API could make this achievable.

cc: @caesarxuchao

I think pkg/client/cache is and should remain version agnostic. It's a general caching layer and should work with runtime.Objects.

Currently request.go has some custom field selector filtering logic that depends on the version that I need to understand.

Should be moved into the high level client, or a generic high-ish level client (like kubectl's builder)

I would also like to change it to take the codec on each request instead of being embedded in the client. This could allow multiple groups/versions to use the same RESTClient.

I actually think we should leave the codec in the RESTClient. There should be an additional layer under RESTClient, the http connection/transport/cert layer; RESTClients that actually point at the same server can re-use that layer. This should help @smarterclayton with openshift integration.
Other misc thoughts:

RESTClient needs to become an interface instead of a struct.
If we have 10 groups with 3 versions each, it becomes infeasible to offer every combination as a typed client. Therefore, we must do one or both of:
Offer curated/tested versioned clients, where we select the versions for each group.
Switch our deliverable to be a versioned client generator, such that you specify the group/versions you wish and a high level client will be generated for you.

Explicit proposal in https://github.com/kubernetes/kubernetes/pull/15730

I think if #21408 merges, we can punt the rest of this to the next release.

#21408 has merged, time to punt?

@lavalamp @krousey What remains to be done here?

Clientset is our versioned client. The next step is extract the client lib into its own repo, then vendor it in the main repo, and convert pkg/controllers and pkg/kubelet to use the versioned client.
AFAIK, kubectl should use the dynamic client, @krousey is working on it and have more insight.

@caesarxuchao Is there a tracking issue for "next step is extract the client lib into its own repo"?

@ae6rt, it's https://github.com/kubernetes/kubernetes/issues/28559

Closing in favor of #29934 as it represents the remaining tasks and is owned by the person actively working on it.


Improvements

"Deutsche" in the translation dropdown should read "Deutsch" (#9)
Also shouldn't the English sources show up if no German translation is available?
Travis should run on pulls
The website should link to "https://github.com/bitcoin-core/website" (maybe in "About"?) (#10)
The license is MIT, so the "© 2016 Bitcoin Core." text should link to the MIT license text.
Design should look more "modern" and "trustworthy". (Maybe take it from https://bitcoin.org/en/bitcoin-core/ ?)
Does the website comply to the EU cookie law (maybe something like http://www.imaginit.net/legal.cfm#q7)?

The website should link to "https://github.com/bitcoin-core/website" (maybe in "About"?)

It is linked in CONTRIBUTING.md

The license is MIT, so the "© 2016 Bitcoin Core." text should link to the MIT license text.

Content cannot be MIT licensed, it would need to be some kind of CC. MIT covers code not design,

Design should look more "modern"

There's no problem with design overhauls or snazzing up the site but it should be distinct from bitcoin.org

Content cannot be MIT licensed

IANAL, but are you sure? Though, I agree using CC-BY or CC-BY-SA.

Afaik content and images can be MIT licensed (though it is rare for artists
to do so). If not we have a problem: The bitcoin core GUI images are
licensed as such.

Btw I agree that the english version of pages - esp blog items should be
shown if the translation is missing. E.g. content shouldn't be missing just
because a different lang is chosen.

@laanwj "software" is different since it's a bundle with documentation "this software and associated documentation files". It would be more usual to license content with a specific content license like CC. The website source is MIT licensed already, however unlike software we have no obligation to do so, nor to make content freely copyable. In any case, if we want to license content we definitely should use a CC license.
Agree about non-translated blog items, it's on my to-do list, default to showing the English version if not translated.

Right - Whatever license it needs to be clearly stated, so that
contributors know what is expected

Existing content, such as the release notes and the Bitcoin Core pages currently on Bitcoin.org (hopefully ported here soon) are MIT licensed.  I think we should continue with that license, especially since it does cover "documentation" and is handily identical to the license used for the Bitcoin Core software.
However, whatever license is chosen, I strongly agree we should mention it in the footer or at least link to it from the footer.

@btcdrak and @jonasschnelli addressed most of this.


[german] de/basics/basic-types.md

@WebFreak001 thanks a lot for your review - could you maybe have a look at this translation too?

@WebFreak001 accidentally did a force-push instead of appending. I am sorry if that messed up the review history :/

@WebFreak001 are we good to go here?


replace List with a class wrapped List

wrap List in a class to make it shared this is to prevent copying
use forward to get at the List interface

the original code has nasty copying going on during the parse which makes it N**2 copying.
what we really want is to build the list up as we go and not copy it every time we add and element.

class ListClass
{
    use List;
    type etype;
    forwarding var l: list(etype);
}

Yes, here is what I was thinking:
use List; // I don't think you can put this in the class definition
class ListClass
{
    type etype;
    forwarding var l: list(etype);

     // new init not required, values forwarded
}

var l = new shared ListClass(int);
// use `l` as regular list, all methods from the record are accessible on the class
l.append(5);

I was also planning on taking a look at transitioning to the forwarded class in the lisp code this week, but don't want to step on your toes if you would like to work on that.

I was also planning on taking a look at transitioning to the forwarded class in the lisp code this week, but don't want to step on your toes if you would like to work on that.

I am ok with you doing this, just leave me some comments so I can follow along ;-)


fix svg generation for windows

Line endings differences between windows and unix were previously
causing this to hang.
Fixes #5

This seems to fix the issue on windows, but I was not able to confirm on linux.

Coverage remained the same at 100.0% when pulling 738640512c482428774b1942ee81fe20b5b91b85 on corsen2000:fix-windows into 9ff23a584ad297d0bb7b027d840332413fa93cda on MMF-FE:master.


try_recv/recv/send

Simplify API

@ssrlive  Please publish a new version to crates.io after merging this PR.


zstd CLI should support GNU "--" separator for file list

gzip and other standard linux/GNU tools let you specify a parameter, "--", after which all parameters are file names and "-" interpretation is no longer performed.  This allows for manipulation of files that start with a "-" which is both convenient and a security feature.

Latest update in "dev" branch is now providing this functionality.

merged into v0.7.3


Publish 11/29/2021, 10:30 AM

Docs Build status updates of commit 0d1cc14:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OMEConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Added new feature: Modal/dialog should be closed with Esc key

I added a new feature for issue-7.
I used keycode to close modal and I used code that is similar to "function handleCloseLessonModal()"
let me know if I need to update more or have some issue
Thank you :)

Can you check this PR? because I have rebase problem :(

Ok cool. I'll close this PR. If you have rebase issues in the future these docs may help: https://docs.github.com/en/free-pro-team@latest/github/using-git/resolving-merge-conflicts-after-a-git-rebase


⚠ Bofrost.be has degraded performance

In fd0b676, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1017 ms

Resolved: Bofrost.be performance has improved in 19f5641.


Handle redirects for old Landing urls

moved from @dpordomingo comment at https://github.com/src-d/feature-idea/issues/133
Is your feature request related to a problem? Please describe.
After a redesign, or any other modification in Landing contents, urls can change, so previously shared ones will be no longer accessible, no matter they're in docs, blog posts, tweets, press notes...
Describe the solution you'd like

To check the error pages in Google Analytics, and to list the urls that are currently being used by our visitors, and are actually errors.
To have an inventory of current Landing urls, and compare with new ones when they appear.
To create and maintain redirects to address the problems described above.

Describe alternatives you've considered

To do nothing, and just to ignore that we could have broken links somewhere.
To update broken links manually whenever we find them if the source can still be edited.

Additional context
From https://github.com/src-d/feature-idea/issues/132 it was discovered that some urls are broken at least in bblfsh docs.

Actually this is a duplicate of https://github.com/src-d/landing/issues/459#issuecomment-527485321


bug: categorical metadata appears in dataset drawer

Relevant slack thread
To reproduce:
Published Dataset - doublet_status is in left sidebar drop-downs
Revision Dataset (no updates to that field) - doublet_status in the dataset drawer and not in the left sidebar
The difference is the following: In Published dataset, nan is a string and treated as a label. In Revision dataset, nan is a NaN (null value) and ignored. This is an issue in the processing pipeline. Categorical data should be converted to strings first.

This is a data portal issue.
Bug tracking is here now: https://github.com/chanzuckerberg/single-cell-data-portal/issues/3461


AppVeyor builds are not working

Users cannot "Get" the latest because the output build from AppVeyor does not work:
https://ci.appveyor.com/project/Wagnerp/krypton-net-5-470/history

Is AppVeyor for unit testing, if so I'll try to disable it.

It should be for performing builds, and then the artifacts can be downloaded by those who want cutting edge builds,
It has probably not been set up for .Net, I've never used for this type of project, but other have got it working within GitHub to produce .Net projects.

I'll have a look into it.

Hi @Smurf-IV
I've removed AppVeyor from the builds.


outdoor_temperature read once and no upcoming updates later

With 2023.9.12-Alpha-Core-Preview the sensor.luxtronik2_outdoor_temperature update once after integration setup, and the no other temperature update since then. even with proper https://github.com/BenPru/luxtronik/pull/121/commits/17731cfc5fa50d04c177f49b3c3d689e40537b41 implemented.
MSW4-16 + V3.89.1

Me too.

Have you something in the log?

config_entry-luxtronik2-d4f28c32d3b8e91d8b225dff9c803ca5.json.txt
The graph clearly shows when I upgraded to the preview version.

Now (preview 20) it works again, perfectly. Thanks so much! 👏

Thansk for the feedback. I close this ticket.


Number pattern allows empty value

Creating a test of
test(     [         [              "price" : regex(number())         ]     ] )
accepts empty values. This leads to generated tests that do not assert the correctness of field names.
Suppose we test this against a JSON like this one:
[   { 	"priceFoo": 123  } ]
A test will be generated:
assertThatJson(parsedJson).array().contains("['price']").matches("-?\\d*(\\.\\d+)?");
This test will not fail for any wrong field names for "price" as the regex accepts empty values.
Is this intended? If so, how can I write a test that fails for wrong field names?

Nope. That's not intended. As a workaround please use regex(...) and write a valid regex. You can also try filing the PR to fix the regex ;)

I've created a pull request but the tests fail for some reason.
Unfortunately, I am in a network environment where I can't build the change locally.
Can you have a look at what's wrong?

Yeah you broke 11 tests ;) https://circleci.com/gh/spring-cloud/spring-cloud-contract/2826?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

I've fixed the test failures


[NeuralChat] Support Triton on HPU

Type of Change
feature
API not changed
Description
NeuralChat Triton inference server validation on Habana Gaudi2.
JIRA ticket: https://jira.devtools.intel.com/browse/NLPTOOLKIU-1235
Expected Behavior & Potential Risk
User will be able to launch triton server following the README.
How has this PR been tested?
Tested on Habana Gaudi, 8 cards.
Dependency Change?
None.

@letonghan  @lvliang-intel  ready for merge?


Bump a few deps

Not all of them, but a number of them.
Travis CI wouldn't run on the bare branch for some reason, hence this PR.

Coverage remained the same at 75.055% when pulling 56abfd651ac8e818256eb7bdd838a752528043f1 on dep-bump into a660cadef2d999269066f7126270dd4d37370bce on master.


[Project] Ecosystems platform improvements

Overview
This project aims to track the platform improvements that we're planning to make the Ecosystem project possible.
Ownership

Owner: @Betree for now, to be reviewed for next sprint.

Note: Project owner responsibilities include coordinating all the different people that need to contribute to the project, defining specs and goals, communicating project progress, being the point person for decisions, QA, documentation, and a plan for ongoing maintenance. If the project owner can't continue, they need to hand the role over to another person explicitly.

### Secondary / bonus tasks
- [ ] https://github.com/opencollective/opencollective/issues/4738

This week

https://github.com/opencollective/opencollective/issues/7661
https://github.com/opencollective/opencollective/issues/7650

Adding https://github.com/opencollective/opencollective/issues/4341 to the list to enable a better UX when the iframe flow completes.

Closing the project as everything's completed, we may follow-up with more work next sprint depending on Ecosystems needs.


Complete Tensor

[x] Matrix extraction
[x] ContiguousMemory Slices + Operations (Accelerate support)
[ ] NonContiguousMemory Slices

[ ] Operations to make Contiguous

Matrix extraction in @9938319d2b5ff8872d5618d1322168027ab638f8

Fixed with https://github.com/aleph7/Upsurge/commit/eed4e904722a5c154aee876bc500bd143a3333f0


Added locks on ns_group update

DNS member ns_group updated by sending list of members which cause
invalid group members when some members update same ns_group
simultaneously.
So added locks which prevent group change between 'get_ns_group' and
'update_ns_group'.

LGTM


Warning causing OPTIONS request to return as 502

After upgrading from RC1 to RC2 our OPTIONS-requests (used for CORS) return 502 instead of 204, causing them not to work.
As it turns out, this is caused by a NullReferenceException at AspNetCore.Hosting.Internal.HostingApplication.DisposeContext().
The warning occours at every request, but requests returned by the MVC-pipeline return with the correct status code, while the requests that do not hit any route in the MVC-pipeline or are returned by the CORS-middleware return as 502. The IIS-logs tell us it is a 502.3 occuring in the AspNetCore-module.
Adding app.UseDatabaseErrorPage() causes the warning to disappear and everything to work correctly, but this is obvously not a viable solution for a production environment.
Here is a gist of our project.json
stdout log:
WARN   2210ms [12               ] Token=adb9793829ddae60 Log                - Connection processing ended abnormally Message: Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.AspNetCore.Hosting.Internal.HostingApplication.DisposeContext(Context context, Exception exception)
   at Microsoft.AspNetCore.Server.Kestrel.Http.Frame`1.<RequestProcessingAsync>d__2.MoveNext()

IIS-trace: https://drive.google.com/folderview?id=0B7YqWm3lf4vZMmNvdFpKZ2lxNGc&usp=sharing

I've asked @cesarbs to investigate.

@severisv Could you share more information on what else is in your request path? I've tried reproing with the template MVC app and an empty app with no success. I'm always getting a 204 response.

I have stripped our project down to a minimal setup that reproduces the issue and pushed it here: https://github.com/severisv/aspnetcore-rc2-cors-issue.
Note that the requests to non-existing endpoints also return 502.3 rather than 404.

@cesarbs Did you get a chance to look into this?

@severisv The problem is here:
https://github.com/severisv/aspnetcore-rc2-cors-issue/blob/master/src/SB.API/Configuration/Log4Net/Log4NetAdapter.cs#L94
This causes HostingApplication.DisposeContext to throw at:
https://github.com/aspnet/Hosting/blob/e62ceb852827d386b492abc9cc6801b1a8c70263/src/Microsoft.AspNetCore.Hosting/Internal/HostingApplication.cs#L83
To mitigate this you should do what we do in loggers that don't support scopes e.g.:
https://github.com/aspnet/Logging/blob/8387adbee91e86e35b6a3d2d0e75e5d59127879a/src/Microsoft.Extensions.Logging.Debug/DebugLogger.cs#L41
@Tratcher I think this warrants a defensive fix in HostingApplication i.e. only attempt to dispose Context.Scope is it's not null.

context.Scope?.Dispose(); would suffice.

I've pointed out a solution to @severisv and also changed HostingApplication so this doesn't happen again in the future. Closing.
@muratg @Eilon I've added appropriate tags and milestone.

Thanks!


Sync enterprise to OSS

Related to https://github.com/scylladb/scylla-enterprise/issues/4967
We need to apply the following:
https://github.com/scylladb/scylla-enterprise-machine-image/pull/72
https://github.com/scylladb/scylla-enterprise-machine-image/pull/73
https://github.com/scylladb/scylla-enterprise-machine-image/pull/74
https://github.com/scylladb/scylla-enterprise-machine-image/pull/76
Closes scylladb/scylla-enterprise-machine-image#78

test passed:
https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/402/

Merging this


Skip Remo-E and Remo-E-lite

Skip NatureNemoSensorAccessory if Remo-E Series
(Remo-E Series has no air quality sensors, so it was always showing 0 like below.)

@ayame-q Thank you for contribution!


Rails7 (updated)

This PR has all the work from PR#45 of atruskie rebased to accomodate the new CI.

Obsoleted by https://github.com/Faveod/arel-extensions/pull/54.


Fix typo in Response docs.

Coverage remained the same at 97.368% when pulling 20bb4bf87fcd017950fcc04b28019d5c2176c1e0 on ahmedcharles:patch-1 into f55a46c42223138ff002ab5ab342dcda6bc7fe1b on seanmonstar:master.

Coverage remained the same at 97.368% when pulling e59d895bfb105df7bf8f0255a132a09da844084a on ahmedcharles:patch-1 into f55a46c42223138ff002ab5ab342dcda6bc7fe1b on seanmonstar:master.

Thanks!


Render issue on 2019.3.0f6 w/ Built-In render pipeline

I've pulled this in and updated cimgui.dll to 1.78, which resolved the errors on startup, but it doesn't render anything with ImGui.ShowDemoWindow (the layout register works and it does hit this method in the OnLayout with the Unity Built-In Renderer.
If I try a simple window
ImGui.Begin("foo");
ImGui.TextUnformatted("barr");
ImGui.End();
I get the following null ref:
ArgumentNullException: Value cannot be null. Parameter name: value UnityEngine.MaterialPropertyBlock.SetTexture (System.Int32 nameID, UnityEngine.Texture value) (at <f38c71c86aa64e299d4cea9fb7c715e1>:0) ImGuiNET.Unity.ImGuiRendererMesh.CreateDrawCommands (UnityEngine.Rendering.CommandBuffer cmd, ImGuiNET.ImDrawDataPtr drawData, UnityEngine.Vector2 fbSize) (at D:/Downloads/dear-imgui-unity-master/dear-imgui-unity-master/ImGuiNET.Unity/Renderer/ImGuiRendererMesh.cs:160) ImGuiNET.Unity.ImGuiRendererMesh.RenderDrawLists (UnityEngine.Rendering.CommandBuffer cmd, ImGuiNET.ImDrawDataPtr drawData) (at D:/Downloads/dear-imgui-unity-master/dear-imgui-unity-master/ImGuiNET.Unity/Renderer/ImGuiRendererMesh.cs:76) ImGuiNET.Unity.DearImGui.Update () (at D:/Downloads/dear-imgui-unity-master/dear-imgui-unity-master/ImGuiNET.Unity/DearImGui.cs:157)
In ImGuiRendererMesh,  _texManager.GetTexture((int)(prevTextureId = drawCmd.TextureId)) is returning null. The TextureId being sent in is some large value, but the texture manager only has the atlas texture registered to it with ID 1.
I notice it tries to create textures in this manager if GetTextureId is called, but this doesn't appear to be done for anything except ImGui.Image* calls.

I've updated to version 1.84 with more features, you can check here https://github.com/psydack/uimgui


Idea: Have a way to trigger a upgrade proposal from GitHub

It would be nice if a GitHub action could submit an upgrade proposal for the chain off of a release branch.

Archive


Have you tried to downsample the mask directly using nearest neighbour?

I am curious about the method that you mentioned to obtain the mask of feature map. Why not downsample directly?

Emmm, in fact, several reasons.

Shift-Net is started in early 2017.  At that time, no works mention directly how to obtain the mask region in feature map. We have to use figure out the mask to perform shift, however, no prior work at all.  So we have to think up a method to handle it.
We define the threshold as 5/16 in our case, and find it is the optimal value. Several months later, I find 5/16 as the threshold performs exactly the same as NearestSampling... So I move the part of feature-mask defination to the supplementary in the v2 in arxiv. And totally remove it on the ECCV version.

You can find https://github.com/Zhaoyi-Yan/Shift-Net_pytorch/blob/master/util/util.py#L210 is directly adopting nearest sampling, which for torch(deprecated now), it is still the original version https://github.com/Zhaoyi-Yan/Shift-Net/blob/master/lib/myUtils.lua#L36

@Zhaoyi-Yan  Thanks for your explaination. Your work is very solid.


inlining and functions

Some of the functions could be inlined if the intermediate protected variables were used directly; makes the code less readable, but possibly faster.
Some of the more complicated intermediate variables could be calculated in a function that again can be inlined.

Also check precomputing products like deltataufrtd in HelmholtzDerivs
https://github.com/thorade/HelmholtzMedia/blob/master/HelmholtzMedia/Interfaces/PartialHelmholtzMedium/EoS/HelmholtzDerivs.mo

Maybe combine with #14 and CSE?
https://en.wikipedia.org/wiki/Common_subexpression_elimination


Corrected Typo in comments from sample.env

Hi @pipegris thank you for your participation ! This looks good to me.


Adding cursor following animation

@MitulSonagara
I would like to add a cursor following animation to the website
Kindly assign it to me

not planned yet


Basic 3 tiered RBAC

Is your feature request related to a problem? Please describe.
Most relevant resources like azure, azure devops, github support at least the basic RBAC of Administrator (or owner), contributor, reader. It would be great to support that on a team level.
Describe the solution you'd like
Ability to give team members a role. This role would also be set in every resource associated with the project.

closed because of solution redesign


Fixed missing toolbar colors for Gitea 1.20+

Small patch to fix theme on Gitea 1.20+
(see issue #9)

Thank you nicorac. I will test today!


ARROW-6125: [Python] Remove Python APIs deprecated in 0.14.x and prior

Codecov Report

Merging #5130 into master will decrease coverage by 22.58%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #5130       +/-   ##
===========================================
- Coverage   87.62%   65.04%   -22.59%
===========================================
  Files        1014      495      -519
  Lines      145892    67076    -78816
  Branches     1437        0     -1437
===========================================
- Hits       127843    43627    -84216
- Misses      17687    23449     +5762
+ Partials      362        0      -362

Impacted Files
Coverage Δ

python/pyarrow/__init__.py
71.25% <ø> (+4.2%)
:arrow_up:

python/pyarrow/parquet.py
92.42% <ø> (+0.13%)
:arrow_up:

python/pyarrow/_plasma.pyx
91.09% <100%> (+1.81%)
:arrow_up:

cpp/src/arrow/util/memory.h
0% <0%> (-100%)
:arrow_down:

cpp/src/gandiva/date_utils.h
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/util/memory.cc
0% <0%> (-100%)
:arrow_down:

cpp/src/gandiva/decimal_type_util.h
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/filesystem/util_internal.cc
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/compute/logical_type.h
0% <0%> (-100%)
:arrow_down:

cpp/src/parquet/hasher.h
0% <0%> (-100%)
:arrow_down:

... and 764 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747b476...cf69e85. Read the comment docs.

Travis build: https://travis-ci.org/wesm/arrow/builds/574380412


Watch relevant olivia announcements and attestations

Have a look at what I did here: https://github.com/comit-network/hermes/pull/178
I think triggering a message on an interval is easier to understand and also more flexible because we could in theory trigger the sync manually via another message.
Would you mind transitioning this implementation to something similar?


ARROW-76 Add performance testing for NumPy and optimize

Why didn't the task fail?

The fail condition is based on the ratio column, it should also check for failures of the tests themselves.


[Shift+tab] handler

while reading your very nice and clean code i've implemented the [shift+tab] handler to move to previous step.

Hi @lesion, in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.
To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older issues like this one to see if the OP is still interested in keep it going.

Thank you for the feedback :+1:


Bright black default color not visible

Which operating system does the issue occur on?
macOS 10.14.6
I think some people are using the bright black color to show comments or other things in gray. It would be helpful if the default bright.black color wasn't the same as the default background color. It took me some time to figure out that my comments were actually there but just the same color as the background. I would suggest to set the default bright.black color to something like 0x555555.

I just noticed that this has already been fixed in another commit. Sorry about that.


Node.js compatible ESM wrapper for CJS with cjs marker for distinguishing CJS transpiled to ESM

Work in progress to align with the new Node.js CJS to ESM interop.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Integrate Llama cuda kernels with Candle

This issue goal is to integrate the paged attention cuda kernels requested in #1 with the candle ML framework. We suggest following the code in here. The idea is to replace the attention kernels in the previous link, with the newly added paged attention algorithms that were added in #1 .

In order to complete this issue, we suggest following the steps:

[ ] Understand how the candle implementation leverages cudarc to load cuda kernels, in order to run fast AI inference on NVIDIA GPUs.
[ ] Identify each of the cuda kernels used in the implementation of the candle's Llama model, in here.
[ ] Once you have identified which kernels have been used, proceed into identifying how to introduce the paged attention kernels in #1 for the Llama model. You should replace the candle's own attention kernels with the paged attention ones.
[ ] Understand if there are other kernels that need to be replaced.
[ ] Feel free to add as many tests as you think is necessary to validate the hypothesis you have come into, while trying to resolve the steps above.
[ ] Open a PR, explaining how you changed the original candle implementation of the Llama model in order to introduce paged attention into it.

Would love to work on this. Please assign

Hello @jorgeantonio21! I’m Juan, new to OSS. I like this project since I have experience with training models. I would like to tackle this issue following the guidelines provided.

Hey @jorgeantonio21 Can I hop on this once it's available

@No-bodyq @JuanPabloRodriguezC @Josh-121 assigned you all. Notice that you need to tackle #1 before finishing this one, as it requires the cuda kernels to be added..


Allow binding to the wildcard host address ([::] / <IP_ADDRESS>).

Hey @iwasaki-kenta and Perlin team!
I was trying to connect to a bootnode on my network bound to the wildcard address and was getting the following error:
transport: authentication handshake failed: connected to peer with addr <IP_ADDRESS>:43949, but their id writes addr [::]:43949

This PR should fix the issue.
If there’s a better way to go about fixing this let me know!
Thanks!
-Mason

Looks great, thanks a lot for taking the time to put in the additional refactor bits :smile:. LGTM.


Require Linux-ARM64 release for cloudfoundry/cf-deployment-concourse-tasks

Hi Team,
I am building cloudfoundry/cf-deployment-concourse-tasks image for both AMD64 and ARM64 platforms and it’s failing on ARM64 due to below dependencies unavailable on arm64.
List of dependencies which are required on arm64:

cloudfoundry/cli
cloudfoundry/bosh-cli
cloudfoundry/log-cache-cli
cloudfoundry/bosh-bootloader

Do you have any plans for releasing it for Linux/arm64?
It will be really helpful if the above binaries and images are released for arm64 platform.
There is no specific release process is mentioned in the above projects to add arm64 builds and raise a PR. If interested, please share the release process and I will add and raise a PR.

Hi @odidev,
Unfortunately, we are not responsible for any of the tools you listed. I would suggest starting by creating an issue on each of those repositories to ask about the possibility of adding arm64 binaries to their releases and to ask whether they would be willing to accept a PR.
Regards,
Dave

The following releases still do not provide ARM binaries:

cloudfoundry/log-cache-cli
cloudfoundry/bosh-bootloader

Now only cloudfoundry/log-cache-cli does not provide ARM binaries.

The cli's are supporting 'arm' and the binaries are provided as well for log-cache-cli.
Further contributions are welcome to build the image. IF there is currently no need anymore we can also close the issue


When all etcd nodes in a cluster are powered off, new nodes cannot be added and etcd restore is not possible

Version: Master
Steps:
Case 1:

Create a custom cluster using S3 backup configuration:
N1: Control/Worker
N2/N3/N4: etcd
Create workloads
Power OFF N2,N3,N4
Add new etcd nodes
New nodes do not get registered and the cluster is stuck in "Updating" state.

This cluster is currently Updating; areas that interact directly with it will not be available until the API is ready.

Failed to reconcile etcd plane: Failed to create etcd client for host [a.b.c.d]: client: etcd cluster is unavailable or misconfigured; error #0: dial tcp c.d.e.f:2379: connect: connection refused

New nodes cannot be added and restore is not possible in this state.
Case 2:

Create a custom cluster using S3 backup configuration:
N1: Control/Worker
N2/N3/N4: etcd
Create workloads
Power OFF N2,N3,N4
Delete the etcd nodes
Add new etcd nodes

New nodes do not get registered and the cluster is stuck in "Updating" state.

Tested with master build from March 7.
Tested both use cases above:
Once new nodes are added, users are prompted to perform a restore.
Failed to reconcile etcd plane: Etcd plane nodes are replaced. Stopping provisioning. Please restore your cluster from backup.

After restore, the cluster is functional. All workloads and ingresses are functional.
For case 1, the related issue is here : https://github.com/rancher/rancher/issues/18657


Broken Client Side Validation for filtering select

Hi,
when a required attribute is left empty, upon form submission, a tool-tip is shown on the field.
When the required attribute is a relation, the client-side navigation does not work.
In Chrome there is no visible reaction, but in the console the following error pops up:
An invalid form control with name='property[feature_id]' is not focusable.
In Firefox, the tooltip shows up in a completely wrong location (see picture below).
I'm pretty sure the the cause is that for filtering-select, the invisible select tag has the attribute
required="required"
and this freaks out Chrome and breaks the positioning of the tooltip on Firefox.
I believe that for associations, the required attribute needs to be moved to the visible controls.

I'd gladly contribute a pull-requrest myself, but I don't understand very much the form-rendering logic in rails-admin.

look her #2339

Maybe related to my issue #2492

@SuperMasterBlasterLaser it is, so your issue is a duplicated one.
I suggest to close - a high issue count isn't precisely motivating!

I'm have same problem.
I'm have required field on model and use Enumeration for generate select-box with values. Generated  be hidden and have attribute 'required'. It's see like logic error. I think disable HTML validation it's not best solution, because then we will have more requests to server(HTML validation prevent many requests with invalid data). Plus, config.browser_validations = false will disable HTML validation for all input elements of rails_admin application.

Reproduced in for 1.1.0. Also prevents visible controls to be highlighted, the JavaScript console throws
An invalid form control with name='product[product_category_ids][]' is not focusable.

Flash notifications do not appear either. Probably because of the JS breakdown.
I'm calling for escalation, definitely not closure.

Hi, anyone found a way to fix this issue?

No =)

#2905 check this fix


chore(release): v0.3.4 🎉

:robot: I have created a release beep boop
0.3.4 (2023-08-05)
Bug Fixes

deps: lift out isPropertyNameAReferenceIntuitively method (e183150)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/sql-dao-generator/releases/tag/v0.3.4 :sunflower:


Support more repository values

It looks like repoFragmentToUrl cannot handle a lot of valid repository fragments. For example the following fragments are valid, but aren't recognized by lisense and result in repoBaseUrl being null:
"lodash/lodash"
// ➡ app:repoFragmentToUrl Can't handle:  lodash/lodash

"https://github.com/Rich-Harris/vlq"
// ➡ app:repoFragmentToUrl Can't handle:  https://github.com/Rich-Harris/vlq

"git://github.com/isaacs/rimraf.git"
// ➡ app:repoFragmentToUrl Can't handle:  git://github.com/isaacs/rimraf.git

{"type":"git","url":"git@github.com:tsertkov/exec-sh.git"}
// ➡ app:repoFragmentToUrl Can't handle GIT reference:  git@github.com:tsertkov/exec-sh.git

@exploids I'm sorry, I didn't got noticed about your issue and just saw it right now :-/

@exploids I finally worked on your request and add a lot of parsing logic for SCM "strings" and license extraction. For example the following SCM strings are recognized (left=input, right=output):
github:user/repo/goo.git                                                --> https://github.com/user/repo/goo.git
gist:0bce1161cfd2aa91ae7cad9abb42c342                                   --> https://gist.github.com/0bce1161cfd2aa91ae7cad9abb42c342
bitbucket:multicoreware/x265_git                                        --> https://bitbucket.org/multicoreware/x265_git/
gitlab:gitlab-org/gitlab.git                                            --> https://gitlab.com/gitlab-org/gitlab.git
npm/lodash                                                              --> https://www.npmjs.com/package/lodash
git@github.com:tsertkov/exec-sh.git                                     --> https://github.com/tsertkov/exec-sh.git
git://github.com/isaacs/rimraf.git                                      --> https://github.com/isaacs/rimraf.git
git+ssh://github.com/Azure/azure-sdk-for-js.git                         --> https://github.com/Azure/azure-sdk-for-js.git
<EMAIL_ADDRESS>                   --> https://github.com/Azure/azure-sdk-for-js.git
git+https://github.com/facebook/react.git                               --> https://github.com/facebook/react.git
github.com/megawac/MutationObserver.js                                  --> https://github.com/megawac/MutationObserver.js
<EMAIL_ADDRESS>  --> https://github.com/VadimDez/ng2-pdf-viewer.git/blob/master/

I hope this fits your need!


TrackTotalHits accepts only "bool" values

According to Elastic documentation, it's possible to send an integer value to "track_total_hits" search parameter. TrackTotalHits is currently accepting only "bool" values.
Elasticsearch Reference [master] » REST APIs » Search APIs » Request Body Search

TrackTotalHits method is generated from the REST API specs, which currently only specifies a boolean value
https://github.com/elastic/elasticsearch/blob/a17c47ec955811559357c2ee3356b1ba1dcc152f/rest-api-spec/src/main/resources/rest-api-spec/api/search.json#L202-L205
This needs to be addressed.
For now, it is possible to set the parameter as an integer, if the ISearchRequest is cast to an IRequest<SearchRequestParameters>, in order to access the query string set method
var client = new ElasticClient();

var searchResponse = client.Search<Document>(s =>
{
	IRequest<SearchRequestParameters> request = s;
	request.RequestParameters.SetQueryString("track_total_hits", 1000);

	return s;
});

which yields
POST default-index/_search?typed_keys=true&track_total_hits=1000
{}

Thanks for the reply. This solutions worked for me while I was requesting a single search. But now I need to use multi search request. How can I do this?

@marceloodiniz that's going to be a challenge with the ISearchRequest type at present because of how it's generated from the REST API spec. It will need a fix in 7.x to

Add [IgnoreDataMember] attribute to the TrackTotalHits bool? property  on the generated ISearchRequest
Add a new property on the non-generated ISearchRequest partial class that can model as both int and bool i.e. Nest.Union<int, bool> and attributed with [DataMember(Name = "track_total_hits"].
Implementation for the new property on SearchRequest and SearchDescriptor<T>

I've opened https://github.com/elastic/elasticsearch/pull/51846 to update the REST API spec

Closing due to age/inactivity. Code-gen work for v8 should resolve this. Please let us know if this issue is still a relevant priority for your usage?


Inference with extensional set equality

Implicit arguments can't currently be inferred from extensional set equality arguments. I.e., if we pass an argument of type s ≡ᵉ s' to a function, we still have to pass s and s' explicitly, which is pretty annoying. One way to fix this is by redefining _≡ᵉ_ as a data type, but this means that a bunch of things have to be rewritten. Maybe there is some better solution.

This also applies to extensional equality for finite maps


added custom language example

Added an actual example of how to define the tensorflow pipeline and how to train a model in a custom language.
Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog

@amn41 what do you think if we added an example like this?


Simplify isort configuration

It is the same thing :)

Oh, it actually fixed a bug that mimesis imports were mixed with other ones.


ux-redesign: VM Details > Disks Card

Closes: #775
What was added?
In View:

Handle "no disks" scenario
DiskListItem renedered per disk attached to the VM.  It includes:

Disk state icon (active, inactive, locked)
Alias/Name
bootable label if the disk is bootable
provisioned size in GiB
Edit mode can be activated with the pencil icon based on the user's authorization to edit the VM

In Edit:

Create New Disk link available
Each existing disk is given an edit and delete icon

A disk may be deleted if the VM is down, it isn't in process of being deleted and it isn't locked
A disk may be edited as long as it isn't in process of being deleted and it isn't locked

Create Disk:

To create a disk, a new modal dialog is opened
Creation requires:

Disk alias (one will be suggested based on VM name and existing disks)
Disk size (defaults to 1GiB)
Storage domain (if the VM already has attached Disks, the most commonly used storage domain will be selected by default)
Disk format (raw && !sparse or cow && sparse)

Edit Disk:

To edit a disk, a new modal dialog is opened
The current size of the disk is always displayed
Edits are only allowed on:

Disk alias
If the disk is an image type, Disk size (only to extend/expand the disk image)

Once change to a disk have been submitted (asynchronously) the card is kept up to date with the disk's state (it'll show as locked while the disk image is being expanded)

Delete Disk:

The VM must be stopped/down to allow deletion of a VM disk
A delete confirmation modal verifies the action
While the deletion is in progress, the locked state of the disk is kept current on the card itself

Legacy Disk Updates

Adopted the redux/ovirtapi updates
Fixed the way disks are created so they are attached properly.  See BZ1639630.

ovirtapi updates

In transforms, created new helper function cleanUndefined to remove keys from Objects whose values are undefined.  It makes it a bit easier to work with ImmutableJS and doing mergeDeepIn operations of transformed objects.
All redux create and delete related things moved to the top level
Added the ability to EDIT/UPDATE a disk attachment/disk (new actions, sagas, VMS reducers, and API calls)

NOTE: webadmin allows changing a disk's Storage Domain, but under the "Move" operation.  We wont support that in webadmin so Storage Domain cannot be changed by a user after creation

@bond95 - Please review my most recent changes.  Thanks!

VM with a single bootable disk (in context on the VM Details dashboard page):

When no disks are attached to a vm:

Disks card in edit mode (VM is down so delete is allowed):

Create New Disk modal with suggested name ("Charlie_Disk1" for VM named "Charlie") and storage domain:

Editing a normal image disk (alias can be changed and disk can be expanded):

Editing a DirectLUN disk (only the alias can be changed):

Immediately after the disk is created but before it is ready to use (disk is locked):
OR Immediately after the disk is edited but before the engine completes the operation:

Once the disk is ready to use:

Confirm on delete of disk:

After confirming delete and the delete command is given and before the disk is removed:

(squashed history and rebased, I had too many small commits after addressing code review concerns and finding a few minor issues that needed to be fixed)

ci build please

@sjd78 This is looking great! I just have a few comments.
For the 'Create New Disk' modal:

The field inputs look good to me but I would include info icons next to the storage domain and disk type fields and give the user brief explanations that they can't be edited once they have been selected. The text for the storage domain info tip could read something along the lines of 'Once you have selected a storage domain, you will not be able to edit it.' The same sort of message could be applied to the disk type.

I would also include an info tip next to the 'Size' field and include a message telling the user that they can only extend the size of the disk once it has been created. It could read along the lines of 'Once you have created a disk, you can only extend the size of the disk if you make edits to it.'

For the 'Edit Disk' modal:

I would get rid of the 'Extend size by' field and only have the 'Size' field. The 'Size' field could feature the same info tip that I noted in the comment above about 'Once you have created a disk, you can only extend the size of the disk if you make any edits to it.' The 'Size' field in edit mode could feature the up and down value adding buttons but have the down arrow disabled so the user could only increase the value. An error message could also appear below the field if they enter a value that is below the current size.

One tiny thing on the confirm modal, the title should be 'Confirm Delete' so both words are capitalized.
The 'Edit Disk' modal for a DirectLUN disk and the disk states in the card look good to me.

@sjd78 This is looking great! I just have a few comments.
For the 'Create New Disk' modal:

The field inputs look good to me but I would include info icons next to the storage domain and disk type fields and give the user brief explanations that they can't be edited once they have been selected. The text for the storage domain info tip could read something along the lines of 'Once you have selected a storage domain, you will not be able to edit it.' The same sort of message could be applied to the disk type.

I would also include an info tip next to the 'Size' field and include a message telling the user that they can only extend the size of the disk once it has been created. It could read along the lines of 'Once you have created a disk, you can only extend the size of the disk if you make edits to it.'

Added field help in create mode for all 3 fields:

For the 'Edit Disk' modal:

I would get rid of the 'Extend size by' field and only have the 'Size' field. The 'Size' field could feature the same info tip that I noted in the comment above about 'Once you have created a disk, you can only extend the size of the disk if you make any edits to it.' The 'Size' field in edit mode could feature the up and down value adding buttons but have the down arrow disabled so the user could only increase the value. An error message could also appear below the field if they enter a value that is below the current size.

One tiny thing on the confirm modal, the title should be 'Confirm Delete' so both words are capitalized.

Done!

The 'Edit Disk' modal for a DirectLUN disk and the disk states in the card look good to me.

:+1:

ci build please

RPMs:

ovirt-web-ui-1.5.0-0.20181102gitf20b911.el7.noarch.rpm
ovirt-web-ui-1.5.0-0.20181102gitf20b911.fc28.noarch.rpm

ci build please

ci build please

RPMs:

ovirt-web-ui-1.5.0-0.20181102gitf5b48c0.el7.noarch.rpm
ovirt-web-ui-1.5.0-0.20181102gitf5b48c0.fc28.noarch.rpm

(rebased to get the new rpm build changes to use the PR's last commit hash in the file name instead of the merge commit hash)

ci build please

RPMs

ovirt-web-ui-1.5.0-0.20181112git80ab0d2.el7.noarch.rpm
ovirt-web-ui-1.5.0-0.20181112git80ab0d2.fc28.noarch.rpm

@smacko - The current rpm build, liked to above, fixes #851 and fixes #852.


[spinel] MAC security frame counter can be saved / restored incorrectly during RCP recovery (#10633)

[spinel] MAC security frame counter can be saved / restored incorrectly during RCP recovery (#10633)

Where possible, check keyId before saving incoming MAC frame counter. keyId == 0xFF is used for Key ID Mode 2, and we don't want to overwrite the global frame counter in this case

Add LogDebg trace for MAC security frame counter

Resolved by #10635


Translating doesn't work in a Factory

Using gettextCatalog.getString() doesn't work in a factory. It returns the untranslated string.
Is there anything I can do about this?

Can you post more of your code? You most likely have something misconfigured, and it's impossible to tell what's going on otherwise.

export function PersonService(gettextCatalog) {
  return {
    /**
     * A dictionary with gender translations
     */
    genders: {
      'm': gettextCatalog.getString('Male'),
      'f': gettextCatalog.getString('Female')
    },

  };
}

The problem might be that translations are not yet initialized when creating the factory?

I can confirm that it does not work in my factory.

I had the same issue, and solved it by setting the strings as translatable :
export function PersonService(gettext) {
  return {

    // Set the strings as translatable
    gettext('Male'),
    gettext('Female'),

    /**
     * A dictionary with gender translations
     */
    genders: {
      'm': 'Male',
      'f': 'Female'
    },
  };
}

And then using the translate filter in my view (supposing you do that through a controller) :
{{genders.m|translate}}

No answer to this still?
How come in a directive: gettextCatalog.getString("yes") returns "oui"
...but in a factory:             gettextCatalog.getString("yes") returns "yes"
? I'd be very grateful of assistance else I will need to so some horrible hacking
Thanks :)

@rikpalmermm are you sure that factory is good place to translate strings? Could you anotate (call getext(key)) at factory layer and then use translate directive or filter at template;)
smth like:
key string
or
{{factory.prop | filter}}


usage clean up

OK with notes.

Isn't this going to conflict with the loc string handoff Eric just did?


Unable to ContinueToBuild transaction

I'm trying to split generating and executing transaction. I'm doing:
//first step:
var txBuilder = new TransactionBuilder();
var txResult = txBuilder
.AddCoins(coins.First().Value)
.Send(destinationAddress, money)
.SendFees(fees)
.BuildTransaction(false);
var txHex = txResult.ToHex();
//second step:
Transaction tx = Transaction.Parse(txHex);
var txBuilderNew = new TransactionBuilder().ContinueToBuild(tx);
var txResultNew = txBuilderNew
//   .AddCoins(coins.First().Value)
.AddKeys(bitcoinPrivateKey)
.BuildTransaction(true);
Here txResultNew is not valid until I uncomment adding coins string. But I do not want to request for balance again, is there a way just to sign and execute transaction on the step 2?
Thanks.

If you want to sign separately, then do not use BuildTransaction but SignTransaction.
Outside this, even if in some specific scenario TransactionBuilder might sign without the Coins, you should not rely on it:

In segwit, you need to sign the amount of the input (Information can be found in Coin)
For signing correctly the TBuilder need to know if you are signing segwit, p2sh or any other scheme. (Information in Coin as well)

You can try to use BuildTransaction(true) even without the keys, it might put some additional info into your txResult allowing the second part to sign, but this might still not work for lot's of reason, and I do not advise you to do that. Your signer need to be aware of the coins. (Transmit the coins AND the transaction)
You can very easily do by creating a new class like
public class SigRequest
{
   public Coin[] Coins {get; set;}
   public Transaction Transaction {get; set;}
}

Then serializing it with
var str = NBitcoin.JsonConveters.Serializer.ToString(sigRequest);

Deserializing
var sigRequest = NBitcoin.JsonConveters.Serializer.ToObject<SigRequest>(str);

SignTransaction does not sign transaction. Code:
Transaction tx = Transaction.Parse(txHex);
var txBuilderNew = new TransactionBuilder().ContinueToBuild(tx); //also tried new TransactionBuilder();
var txResultNew = txBuilderNew.AddKeys(bitcoinPrivateKey).SignTransaction(tx);

Code:
Transaction txResultNew = Transaction.Parse(txHex);
txResultNew.Sign(bitcoinPrivateKey, false);
is also fails because there is no ScriptSig filled.

Changing BuildTransaction(false) to BuildTransaction(true) does not change the result

NBitcoin.JsonConveters.Serializer worked, thanks! I tried Newtonsoft JsonConvert.SerializeObject before but it fails with StackOverflow exception, so I used custom CoinInfo class. But suggested approach is better and contains redeemScript field that I missed.

Do not use txResultNew.Sign(key, false) this is deprecated.
Yes, in general you need the Coins for signing, there might be corner case where it works without but this is only for legacy stuff, and not recommended.
You can use txResultNew.Sign(keys, coins), it will sign correctly.
or
tx = tbuilder.AddCoins(coins).AddKeys(keys).SignTransaction(tx);

Here example
ICoin[] availableCoins = null;
TransactionBuilder builder = new TransactionBuilder();

builder.AddCoins(availableCoins);
//builder.Send(...);
var tx = builder.BuildTransaction(false);

sigRequest.Coins = builder.FindSpentCoins(tx);
sigRequest.Transaction = tx;

// serialize, deserialize sigRequest

builder = new TransactionBuilder();
builder.AddCoins(sigRequest.Coins);
builder.AddKeys(keys);
var tx = builder.SignTransaction(sigRequest.Transaction);

@NicolasDorier Sorry for bringing this issue back but I'm running into a similar issue here.
I'm using a code that's very similar to what you suggested here but I keep getting an error: throw new InvalidOperationException("You need to provide P2WSH or P2SH redeem script with Coin.ToScriptCoin()");.
In my case I have a single transaction that contains coins from several different Multisig wallets and I'm sending this transaction to be signed by the owners of those wallets. I'm even sending the coins grouped by the owner wallet address so I easily find the ones each participant can sign but, as soon as I call the SignTransaction method, providing the current unsigned transaction I get the exception.
Here's an excerpt from the code I'm using:
var builder = new TransactionBuilder();
var newTransaction = builder
                    .AddCoins(coinsFromThisWallet)
                    .AddKeys(new BitcoinSecret(privateKey, _network))
                    .SignTransaction(unsignedTransaction);

And here's the Hex for the unsignedTransaction object:
010000000f85369d94509e439716dea7801d54752e146aa7396fa4746a45226b8481d7a67c0100000000ffffffff926755034a637ff14721c02b1874c6397f1ebe08d48dbb6cc9dfcd032c8430410100000000ffffffff939984eb73b5f2e44c9cdfb74f837532bc3135f0026b9731105341231fedd56c0100000000ffffffffe80766ddadc553f31679e6d79509516fbd2539b7c5e8e153b2e8698b40af81e40100000000fffffffff510571759794d4a677b52239d5e3444a780ac362bf519dd71e1a3f0188e5b220100000000ffffffff7d6f4e19b8516660aa0896acfe10025cbd86c5c21d9f644f98e64259050fe3030000000000ffffffff218c5828d9617eb609055885332f6e26ba5a9067865d82af8b54fd033699a1fc0100000000ffffffff2c233d3d9af2e711a2d7515decee07c240b48fa20a13ecea48d1935c4f538d340100000000ffffffff33019ee5dc24c054f12e95c4825af15ecee48e4451d2ec0fab18501f6686973b0000000000ffffffff5d466fa35ce0ac4e2e8d219de62106c0cb3259be9b2ff95362ee069a98c6898b9800000000ffffffff5e3b9f20fd0c867909f4aa0db3576ab1abaca2aab036e34f8b293fd42d9bd9870100000000ffffffff617c401cadeaf95d077949473b982734ce84ca5a4b1bdc7f743294a5d62a29300000000000ffffffff8a87942f6f056a9e17d34e1cf61f34194cbc1624a582ce32ed4d9ddcb211bef40000000000ffffffffbd3a324f84e794c3417388746e7d5e75a7a29b2b95b79be87794cd7e8e21870f0000000000fffffffff4f2d12f8dba20a1340bc743b8632fc2931c62384d6f5a93618283c8346ee8a70000000000ffffffff01a7adcc32000000001976a9142a29ebedf9c527beee8465df27efcfbca9a8a23588ac00000000


We should "productize" pelorus a bit more by auto-building our exporter images and pushing them to Quay.io

Rather than having to run our image builds in each cluster, we should provide already built images for our exporters.

we can use the s2i github action for this

We can give a try to the new official Red Hat actions: https://github.com/marketplace?query=redhat

We have images being published to Quay.io now. https://quay.io/organization/pelorus
Next step is to update the helm charts to consume those images.

I believe we can close this issue right @KevinMGranger ?

The images are definitely being published, yes. But we want using them be the end-user facing workflow, right? Or should we make a separate issue for that?

I've created PR #370  which fixes build of images that are being published to quay.io. Next step is to used them in the deployment. That was another issue #358. I've created #373 to track issue where we should use images from registry.

Closing as per https://github.com/konveyor/pelorus/issues/63#issuecomment-1276131946


NET Core, EPPlus and -Password

I see the same problem I'm encountering (ImportExcel 7.5.2) noted in #637, per comment: https://github.com/dfinke/ImportExcel/issues/637#issuecomment-592636559
@dfinke indicates in one comment in that issue from July 24, 2019:

I checked a couple months back on EPPlus to see if they were further along on their port to dotnet core. Don't know about the crypto support. I didn't see much check in activity then.

I'm out of my depth on how to contribute a fix, but I did find this sample from EPPlus released after @dfinke comment that deals with encryption: https://github.com/EPPlusSoftware/EPPlus.Sample.NetCore/blob/master/19-EncryptionAndProtection/EncryptionAndProtectionSample.cs?msclkid=ad003fd1d0ce11ec99e9f81da0377d80
Again, I'm out of my depth, but that sample code makes me think that EPPlus has dealt with the dotnet core encryption port?
The current version of ImportExcel (7.5.2) fails on line 124 of Import-Excel.ps1.  It's probably no small task to just update the EPPlus.dll that is 3 years old in the repo - I expect there's potential significant regression testing against an update like that, but I wanted to raise this old issue in case the EPPlus updates to support encryption were not known.
Any chance this support for password encrypted spreadsheets and PowerShell Core can be revisited now that EPPlus seems to have a released version that supports it?

Thanks, no plans to move to that version. That EPPlus version is their new version. No real plans to move to it. It requires a paid license for each person that uses it, I have no influence over it. Also, the upgrade has a lot of breaking changes.

Good clarification.  I thought in reading EPPlus licensing terms that they had support for develop/distribute scenarios, i.e., developer pays for a license but can distribute.  But either way, breaking changes is a big deal.
I have a scenario where I don't control the workbook source and the workbook comes password encrypted.  Do you have any recommended work-arounds for continuing to use Import-Excel or other options for those scenarios?  I suppose the answer might be to just keep using PowerShell 5.1?

I talked with the devs of EPPlus. Lots of grey areas. Plus, not sure I want to shell out annual/one time $$.
I don't know of work arounds for this. If EPPlus isn't able to handle the decryption, I think 5.1 is the way forward.
There may be someone who found a workaround with older .NET and the older EPPlus, check Stackoverflow.


feature request: gps edit <patch#>

Would be nice to have this edit the patch# specified instead of following the workflow of:
gps rebase
edit the line of the patch you want to start with "edit"
There's a patch# when you do "gps ls" already...if we can do gps edit #, that would simplify the flow.
Also add a shorthand of
gps rbc
command so you don't have to do
gps rebase --continue

Thanks for the feature request @kenyee I could see both of these being valuable. We will have to prioritize them.


hello world from viet nam

hello world from viet nam

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


Operation in an environment where the GPU does not work

associated with #210
CPU: Intel(R) Core(TM) i3-6006U CPU @ 2.00GHz   2.00 GHz
GPU: Intel(R) HD Graphics 520
displayed card info: 很遗憾您这没有能用的显卡来支持您训练
config.py: device = "cpu"
Ran the file: go-web.bat
Version: 20230428
Step 2b Error:
  File "C:\RVC-beta\extract_feature_print.py", line 92, in <module>
    logits = model.extract_features(**inputs)
  File "C:\RVC-beta\runtime\lib\site-packages\fairseq\models\hubert\hubert.py", line 535, in extract_features
    res = self.forward(
  File "C:\RVC-beta\runtime\lib\site-packages\fairseq\models\hubert\hubert.py", line 437, in forward
    features = self.forward_features(source)
  File "C:\RVC-beta\runtime\lib\site-packages\fairseq\models\hubert\hubert.py", line 392, in forward_features
    features = self.feature_extractor(source)
  File "C:\RVC-beta\runtime\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "C:\RVC-beta\runtime\lib\site-packages\fairseq\models\wav2vec\wav2vec2.py", line 895, in forward
    x = conv(x)
  File "C:\RVC-beta\runtime\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "C:\RVC-beta\runtime\lib\site-packages\torch\nn\modules\container.py", line 217, in forward
    input = module(input)
  File "C:\RVC-beta\runtime\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "C:\RVC-beta\runtime\lib\site-packages\torch\nn\modules\conv.py", line 313, in forward
    return self._conv_forward(input, self.weight, self.bias)
  File "C:\RVC-beta\runtime\lib\site-packages\torch\nn\modules\conv.py", line 309, in _conv_forward
    return F.conv1d(input, weight, bias, self.stride,
RuntimeError: "slow_conv2d_cpu" not implemented for 'Half'

full extract_f0_feature.log

Only Nvidia CUDA is supported in training now.


fix: revert mmkv submodule to last known stable commit (LTS release)

This PR fixes #723
What changed:

Moved MMKV submodule back to an older version (only 2 commits)
This older version doesn't have the recent changes to AESCrypt files

Why:

New changes in AESCrypt.cpp and AESCrypt.h were causing iOS build to fail
Moving back to the older version fixes these errors quickly

Testing:

I tested this fix on my local machine
The iOS build now works without errors

@mrousavy The latest LTS release of MMKV points to a different commit than the one we're currently using:
MMKV Releases
Therefore, I recommend using the version provided in this PR.

Cool, thanks!

released as 3.0.1


Add wandb.run.config_static

Sometimes people need to pass wandb.run.config to other processes.
Since wandb.run.config is a managed object this doesnt work very well.
wandb.run.config_static behaves like the wandb Config object in that you can refer to attributes or keys.
The difference is you cant change attributes/keys or add new keys/attributes
Note:
This is not adding onto the module.  For two reasons:

we should encourage people to use config and config_static off the run object
it is hard.  it can be done cleanly in python3.7+ and very hacky to create a property on a module

Closes #833

I simple test to assert a key in dynamic config exists in static would be good.

I will add a couple tests.
Was intentionally not going to support desc/value stuff since it more internal, not part of how users interact with wandb_config.Config

Yeah, I don’t want to support it.  Just wanted to be sure the data wasn’t
getting passed around with those keys in it.
On Wed, Feb 5, 2020 at 1:18 PM Jeff Raubitschek<EMAIL_ADDRESS>wrote:

I will add a couple tests.
Was intentionally not going to support desc/value stuff since it more
internal, not part of how users interact with wandb_config.Config
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/wandb/client/pull/840?email_source=notifications&email_token=AAAAAEL6WDJ5VSPBXJ2N7HLRBMULPA5CNFSM4KQR4VYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5ASHA#issuecomment-582617372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAAEO7G67NHBRFETCQULTRBMULPANCNFSM4KQR4VYA
.


Song Titles Won't Refresh

When using the app, the currently playing song title will not refresh. The music will continue to play just fine, but in order to see the currently-playing song title I have to close and reopen the app.
I'm on an iPhone 6 with iOs 10.2.1

Could you clarify whether it is the song title on the lock screen or the within the app? The lock screen song title should continue to update even if the app is in the background, however when the app is put in the background it won't update the view which includes the song title unless it has a good reason such as invalid or out of date information. That corrects itself within 10 seconds.

Closed until further information is acquired.


Recovery messages

Is it possible to configure recovery messages?

Ooops, that was quick: send_resolved is the key.


Feat: Add more environment variables to datadog

What this PR does / why we need it:
Which issue this PR fixes
This commit fixes the merge issues in:
https://github.com/helm/charts/pull/6766
Special notes for your reviewer:
I don't have rights to fix the origin PR. This simply fixes the merge issues of the original approved PR as per @davidkarlsen
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md

@cpanato is this good to go now?

/ok-to-test

@cpanato alright, updated and should be gtg now, hopefully 🤞

/lgtm

/assign @davidkarlsen

@gcallaghan please rebase to fix the conflict


Optional Unique ( String?  @unique) not working in MongoDB

Bug description
MongoDB Partial Indexes not creating
ts-node --transpile-only ./src/index.ts

PrismaClientKnownRequestError:
Invalid `prisma.user.create()` invocation in
PS C:\Users\muhad.bk\Desktop\playground\userOnboard> npm run tests

><EMAIL_ADDRESS>tests
> ts-node --transpile-only ./src/test.ts

done first
PrismaClientKnownRequestError:
Invalid `prisma.user.create()` invocation in
C:\Users\muhad.bk\Desktop\playground\userOnboard\src\test.ts:17:23

→ 17 await prisma.user.create(
  Unique constraint failed on the constraint: `User_mobile_key`
    at Object.request (\playground\userOnboard\node_modules\@prisma\client\runtime\index.js:45578:15)
    at async PrismaClient._request (\playground\userOnboard\node_modules\@prisma\client\runtime\index.js:46405:18) {
  code: 'P2002',
  clientVersion: '3.12.0',
  meta: { target: 'User_mobile_key' }
}

How to reproduce
schema
model User {
  id    String  @id @default(auto()) @map("_id") @db.ObjectId
  email     String?  @unique
  mobile    String?  @unique
}

index.ts
import { PrismaClient } from "@prisma/client";

const prisma = new PrismaClient();

async function main() {
    await prisma.$connect();

    await prisma.user.create({
        data: {
            email<EMAIL_ADDRESS>        }
    });
    console.log("done first");
    await prisma.user.create({
        data: {
            email<EMAIL_ADDRESS>        }
    });
}

main().catch(console.log).finally(async () => {
    await prisma.$disconnect();
});

Expected behavior
MongoDB Partial Indexes
Prisma Doc
It will create two new records where the email is set to NULL in the database.
Prisma information
model User {
  id    String  @id @default(auto()) @map("_id") @db.ObjectId
  email     String?  @unique
  mobile    String?  @unique
}

Environment & setup

OS: Windows
Database: Mongo DB
Node.js version:  16
Prisma 3.12

Prisma Version
3.12

Did you run npx prisma db push to create the unique constraint and index on the database?

Yes ,
npx prisma db push command running before project starts, that will automatically created all the collections and unique constraints and indexes.

Ref:
MongoDB Partial Indexes
Stack overflow Issue

I do not understand.
Your initial message shows how the insert is declined as there is already a value. And that is also how it looks to me after running db push:
PS C:\Users\Jan\Documents\throwaway\12827> node .\index.js
done first
done second
PS C:\Users\Jan\Documents\throwaway\12827> npx prisma db push
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Datasource "db"
Applying the following changes:

[+] Unique index `User_email_key` on ({"email":1})
[+] Unique index `User_mobile_key` on ({"mobile":1})

Your database is now in sync with your schema. Done in 1.77s

✔ Generated Prisma Client (3.12.0 | library) to .\node_modules\@prisma\client in 54ms

PS C:\Users\Jan\Documents\throwaway\12827> node .\index.js
done first
PrismaClientKnownRequestError:
Invalid `prisma.user.create()` invocation in
C:\Users\Jan\Documents\throwaway\12827\index.js:14:23

  11     }
  12 });
  13 console.log("done first");
→ 14 await prisma.user.create(
  Unique constraint failed on the constraint: `User_mobile_key`
    at Object.request (C:\Users\Jan\Documents\throwaway\12827\node_modules\@prisma\client\runtime\index.js:45578:15)
    at async PrismaClient._request (C:\Users\Jan\Documents\throwaway\12827\node_modules\@prisma\client\runtime\index.js:46405:18)
    at async main (C:\Users\Jan\Documents\throwaway\12827\index.js:14:5) {
  code: 'P2002',
  clientVersion: '3.12.0',
  meta: { target: 'User_mobile_key' }
}

What is "not working" for you then?

Hi @janpio ,
Prisma 3.12 MongoDB  not support partial unique indexs.
Here in the code, The first insert have a null value in that field, then other insertions are declined as there is already a value if the field is null or empty.

@unique indeed only allows you to create a full unique index as described at https://www.mongodb.com/docs/manual/core/index-unique/.
If you need a partial unique index (as maybe described at https://www.mongodb.com/docs/manual/core/index-partial/#partial-index-with-unique-constraint), that would be a new feature for Prisma that we do not support at all yet and would need a feature request issue.

Was doing some googling to make sure partial (and maybe wildcard?) indexes were on the roadmap. Glad to have found this issue.
@janpio  - looks like you have slated this as an enhancement. From your comment above, I just wanted to make sure you didn't still need someone to open a feature request issue. I can do that, if required.

No, all good: https://github.com/prisma/prisma/issues/3076 or https://github.com/prisma/prisma/issues/6974

Any update on this?

This is driving me mad - is there no way to use partial indexes in prisma? maybe with a rawquery?

@clearly-outsane , I think you can set manually in the MongoDB/ atlas console.

Feature request for this kind of index is now tracked at https://github.com/prisma/prisma/issues/6974. Closing this issue.


Setup .env in test run

Resolves #276
I ran into very similar issues with unit tests not accepting env var values for the PANO_* variables until I set them in my .env file. This PR tries to solve #276 in a similar way to how I solved this on my local machine.
I think it is due to the dotenv call in src/manage.py, but I'm not 100% sure.
Edit: I tested on my fork, it looks like it works!  https://github.com/james-otten/meshdb/pull/1

Ah, looks like there were problems loading the panorama env vars still 😅
https://productionresultssa1.blob.core.windows.net/actions-results/e1257899-d531-45f7-ac1e-c95cac421864/workflow-job-run-152bb3b5-7908-51f7-367b-02ffebb7d905/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-27T07%3A39%3A59Z&sig=2%2F2aKa3qI3%2BA1jFp3%2BjxqAGl8qJD2O0gVdGhZv01SaA%3D&sp=r&spr=https&sr=b&st=2024-03-27T07%3A29%3A54Z&sv=2021-12-02
I might need to revisit the way I'm pulling in these env vars. It's also like... an unnecessary amount of vars.
I also think we should mock the Github endpoint, because it has given me a 500 in a variety of contexts and I think is, simply put, flaky.

Use #285 instead


Font customization

For appearances, there is no option to change the font of the labels which lacks of the uniform of my currently developing app and I intend to use Avenir Next throughout. This would be a nice feature to add on.
New Issue Checklist

[x] I updated BulletinBoard to the latest version.
[x] I read the Contribution Guidelines.
[x] I read the documentation.
[x] I searched for existing GitHub issues.

Issue Description
It would be awesome if the PageBulletinItem.interfaceFactory has a property to control the font.
More an improvement here, not an issue.

Nice idea, I'll be working on this.

How about making the BulletinInterfaceFactory class "open" instead of "public"? This way we could inherit and override it to customise the properties. You'd also have to make the functions (e.g. makeTitleLabel open instead of public) for this to work, as well as change the PageBulletinItem.interfaceFactory from a let to a var property, so it can be changed.
Even better would be if you could use Protocols instead, but may not be something you want to do. It would just make it easier to override existing classes/functionality.

@jyounus You're right, making the class open instead of "public" would a fantastic idea for better inheritance and override availability.

@jyounus Using protocols is an excellent idea. I'll work on a PR to implement this.

I've made a PR (#26) that implements a better customization API. @CaliCastle @jyounus would you mind telling me if it suits your needs?

Implemented by #26


Generalization problem

Hi,
Thanks for the inspiring work!
I have two questions about this work. Could this method adapt to meshes with different number of vertices in both training and testing process? Also, would you release the pre-trained model for testing? Thanks!

Hi, thanks for being interested in our work.
For question 1, we tried training on DFAUST, FAUST and SMPL-NPT datasets, the number of vertices should be fixed to 6890, but for testing, the number of vertices can be different by using the max-pooling model (I will upload it later). The maxpooling model can take different size via a maxpool layer. The idea is inspired by the work of NPT. Please see here:
https://github.com/jiashunwang/Neural-Pose-Transfer/blob/master/model_maxpool.py

Thanks so much for your replying!
Best regards,
Jinnan
Get Outlook for iOShttps://aka.ms/o0ukef

From: mikecheninoulu @.>
Sent: Saturday, April 9, 2022 8:17:01 PM
To: mikecheninoulu/Unsupervised_IEPGAN @.>
Cc: #CHEN JINNAN# @.>; Author @.>
Subject: Re: [mikecheninoulu/Unsupervised_IEPGAN] Generalization problem (Issue #5)
Hi, thanks for being interested in our work.
For question 1, we tried training on DFAUST, FAUST and SMPL-NPT datasets, the number of vertices should be fixed to 6890, but for testing, the number of vertices can be different by using the max-pooling model (I will upload it later). The maxpooling model can take different size via a maxpool layer. The idea is inspired by the work of NPT. Please see here:
https://github.com/jiashunwang/Neural-Pose-Transfer/blob/master/model_maxpool.py
—
Reply to this email directly, view it on GitHubhttps://github.com/mikecheninoulu/Unsupervised_IEPGAN/issues/5#issuecomment-1093971112, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMXAHO2XHJKZZLQTFE5HKLDVEFYL3ANCNFSM5RTDRZZQ.
You are receiving this because you authored the thread.Message ID: @.***>
Disclaimer The sender of this email does not represent Nanyang Technological University and this email does not express the views or opinions of the University.

Hi, would you like to share the training and test list of DFAUST and FAUST dataset as well as pretrained model, thanks?


[Ballerina-GRPC] Unable to configure header size in Ballerina gRPC server configuration

Description:
I'm getting the following errors when trying to invoke a gRPC service from a Ballerina gRPC client, using a JWT header. The JWT is a bit lengthy.
Error 01
Compiling source
        viduranga/bal_grpc_client:0.1.0

Running executable

error: HTTP status code 431
invalid content-type: null
MESSAGE DATA:

Error 02
Compiling source
        viduranga/bal_grpc_client:0.1.0

Running executable

error: Remote host closed the connection before initiating inbound response

These error do not get thrown when the length of the JWT is shortened. Hence I believe this has something to do with the allowed header size.
Although a maximum header size configuration is available in the HTTP library, I was not able to find such a configuration in the gRPC library
Steps to reproduce:

Create a Ballerina gRPC server and a client
Send a request to the server from the client attaching a considerably large header value.

Affected Versions:
Ballerina 2201.8.0 (Swan Lake Update 8)
Language specification 2023R1
Update Tool 1.4.0

OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@vlgunarathne We have released gRPC v1.10.6 with the fix. You can use the field maxHeaderLength in grpc:ListenerConfiguration to increase the header size.


🐛 [Scrutiny] Memory leak since 0.8.1, april 8

Description
If I'm not mistaken, after the last Scrutiny update on April 8, a memory leak appeared, which has been slowly but surely growing for months.
I'll attach screenshots that show when the memory started leaking, and that the process /usr/libexec/udisks2/udisksd takes up 4.0% of my 16 GB of memory for 40 days of HAOS uptime.
When HAOS is restarted, 1.5 GB of memory is occupied and this process is not visible at all in the top, and after a month and a half, it's already 2.8 GB and that procces at the top2. Unfortunately, restarting HA Core or restarting all my addons does not help to return the memory, only restarting the entire HAOS helps.
Alex, can you check if the problem exists on your side?

HW:
Intel NUC10i3, HomeAssistantOS 12.4
Reproduction steps
1. Check used memory in SystemMonitor integration
2. Wait few weeks and check again, or show up history graph
3. You can check top10 process sorted by memory in Advanced SSH & Web Therminal by using command:

 run --privileged --rm -v /dev:/dev --pid host ubuntu:latest nsenter --target 1 --mount --uts --ipc --net --pid -- ps auxww --sort -pmem | head

Addon Logs
I dont have any.

Architecture
amd64
OS
HAos

+1 the some

Mmh very good point thanks. Alas I restart my homeassistant by automation weekly, and sometimes a bit more manually so I don't have long term data to compare. The is no mention of memory leaks in the scrutiny github, but there is some for HAos https://community.home-assistant.io/t/memory-leak-how-to-find-whats-causing-it/611482
I'll try to build a new version just to see if this helps by using updated dependencies

I'll try to build a new version just to see if this helps by using updated dependencies

Thank you, hope it helps.
ps: its a little hard to monitor processes memory use by all methods, because leakage around 30-35mb/day, it takes huge time to see real difference

Might be easy for me to say but implementing a nightly weekly restart might avoid some issues... That's what I'm doing as part of my weekly maintenance routine...
BTW have you tried ha su repair? I know that the supervisor has some leftovers (such as dangling images) that are greatly helped by a regular run of this command... I wouldn't see how that would affect memory usage but at least it should recover some space for you :)

Might be easy for me to say but implementing a nightly weekly restart might avoid some issues... That's what I'm doing as part of my weekly maintenance routine...
BTW have you tried ha su repair? I know that the supervisor has some leftovers (such as dangling images) that are greatly helped by a regular run of this command... I wouldn't see how that would affect memory usage but at least it should recover some space for you :)

Just updated to v0.8.1-4,  tried ha su repair, will look in one week or so, will it growth...
If nothing helps, I will implement host reboot every week, it will cause some another problems but I have ideas how to automate it.
Thanks! I'll write in one week about results.

It seems the latest update didn't help.  ha su repair command also does not bring results.
Well, I’ll have to implement the weekly OS reboot automation, apparently this is my last option.
Alex, thank you for your work and time!
Ps: if the reason of this behavior will identified in the future, fill free to reopen issue

@alexbelgium
I changed my ssd from NVMe to Sata2, and problem is gone ;)
Looks like it was something with SMART data caching/recording to db, according to nvme.

Thanks for reporting! This surely will be useful pt others too