Inconsistent message handling by ZMQ core broker

The Bug:
When doing scalability testing on ZMQ core with python API, the broker gives a "core tick" and "unable to terminate transmit connection" when running more than few federates and more than few publications/subscriptions.
The tests done involved many to one echo process i.e., a fixed number of federates (senders) sending a fixed number of messages to one echoer and the echoer sending back the corresponding messages it received from each federate (sender).
Test- example, and result:
Three different cases where 1000 publications and subscriptions were involved is explained below:

10 federates (sender) each sending 100 messages to one echoer and subscribing them back - Echoer gave a consistent "core tick" log.
100 federates (sender) each sending 10 messages to one echoer and subscribing them back  - Echoer gave an "unable to terminate transmit connection" log.
1000 federates each sending 1 message to the echoer and subscribing them back - completes the process cleanly but is inconsistent.

All three cases involved publishing/subscribing to the same number of messages but exhibit different outcomes.
Codes to reproduce the behavior: Python_fedgenerator.zip
Steps to reproduce the behavior: readme.txt in the zip folder
Python_fedgenerator.zip
Environment (please complete the following information):

Operating System: [Linux]
Language Extension: Python
HELICS version: --> 2.0.0 beta.1

I see that you are using the HELICS Runner. As far as I can see this piece of software has not been updated for 2.0 yet. Let me explain. For the 2.0 version of HELICS the broker needs to be executed differently than with 1.3. Specifically you need to do the following:
helics_broker --federates=<number of feds>
Looking at the source for the HELICS Runner this change is not made. Did you make this change locally?

I am using HELICS Runner to run the simulation, but not to create the broker.
I have the broker creation inside the echoer.py script where I create the broker using this coreinitstring:
coreinitstring = ("--federates=%s --name=mainbroker" %(number_sender+1)).
Also, the script is changed to adapt to new HELICS 2.0 functions.

I see, I should have looked more carefully!
I am able to reproduce your problem consistently on my end as well. I discussed with Mark and we were not able to immediately find a permanent fix for this. What causes the problem in this case seems to be two-fold. First problem is that the sender.py and echoer.py are not exiting at the same granted time (sender.py is not calling time request for the stop time while the echoer.py is). Second one is the fact that once each federate gets granted their last time to run they have different amount of code to run because the time request is in the beginning of the while loop. In a perfect world none of these factors should stall the simulation and have it not exit cleanly. I think we definitely need to get to the bottom of why this is happening.
In the mean time however, I do have a temporary fix you can use if you need to collect results now. For the temporary fix change the following:
sender.py:
Change line 54 from t = update_interval to t = 0
Move line 76  t = t + update_interval to line 55 (beginning of while loop)
After line 58 print("Granted Time = {}".format(currenttime)) add the following two lines:
if currenttime >= time_stop:
        continue

echoer.py:
After line 74 print("Granted Time = {}".format(currenttime)) add the following two lines:
if currenttime >= time_stop:
        continue

While tinkering with the code I did find two things I wanted to bring up:

From the description you mention that the echoer is suppose to just reply back what it receives. While it does do that it is not only sending the message back to where it came from but rather what happens is that you loop over each subscription and then publishes the received value on all the publication of the echoer. That means for a case with 10 federates, each with 100 messages the echoer is publishing 1,000,000 times rather than the 1,000 required to to echo the received values. Is that what you intended to do for this case?

Also, I noticed that you only set the timeDelta in the JSON config. Nothing wrong with doing this but that means that your base time will be nano seconds. I find that hard to read myself so while testing I added the period to be 1 seconds as well as that will force the time base to be 1 second. This helped me identify the temporary fix as well

I tested this with the changes from #531 and now the simulation exits as expected. A lot of warnings are thrown from broker that messages are being dropped but that is due to how the federates are designed

That is a good question. I will say that the first time I saw it I immediately thought something was wrong. I had to really pay attention and see what was causing it and then it made sense. I definitely think we should do something. Would it be possible to add a check to see if the federate disconnected. Then in the case where the federate is disconnected not log the message at warning level but rather summery level. I think the message is valid but as you mention I think many people will run into this and think something is wrong. I am open to suggestions as well and maybe we want to discuss with more people that might have input.

There is already a check before a message gets generated.  You see those warnings from messages that get sent in time between the check and the actual network transmission which could have disconnected.  And the network stuff doesn't know much about the disconnection.  It doesn't show the message if it is related to disconnection, otherwise you would see a bunch more.    Also the networking layer is not fully aware of the warning levels since that occurs pretty low down on the stack.    I will look into it further.

Thank you for the additional information. I will keep thinking about it as well. I am also pretty sure that one could avoid these messages with small changes to the federate design. I will try that on my end actually

I have been able to avoid the dropped message warning by ensuring that no federates are publishing on their last time step. This only works of course if all federates end at the same time but I think all the co-simulation I have worked on is intended to run this way.

I think this issue can be closed as the problem is no longer present after #531


Fresh install Cassandra setup issues

Installed cassandra correctly but per docs running
npm setup-cassandra-init

doesn't work. Anyways, looked at package.json and realized it's now just setup-cassandra. Also in
setup-cassandra.js the path is incorrect for ExpressCassandra.js. Anyways fixing those I get an 'urb' keyspace but no tables created. Not sure how to do so.
Thanks

Did you download the latest release, or master?
I am in the process of refactoring this whole thing, in order to add support for Monogo, Dynamo Db and MySQL. I will be refactoring this very shortly and uploading the updated documentation. As part of this, I will completely re-set my local setup and go through all the setup steps again and fix whatever is broken in the scripts and the documentation.

I looked at the code, indeed while refactoring I messed up the script. Either use the previous point release, or wait for the next one, I should be able to cut it within the next couple of days.

Wow! Thanks for getting to this so quickly. Ill test this out this afternoon.


If my collections source Tile are rectangles instead of squares, but I make them 0 margins, is it supported?

OpenSeadragon({
...
collectionMode:       true,
collectionRows:       1,
collectionTileSize:   1024,
collectionTileMargin: 0,
...
});

If my collections source Tile are rectangles instead of squares, but I make them 0 margins, is it supported?
How to do？
example:
collectionTileWidth:   1024,
collectionTileHeight:   768,

The collection mode is pretty rudimentary. Check out https://github.com/openseadragon/openseadragon/issues/1723 for some thoughts on things that can be done in this situation.


Optimize multiplication and division of xieite::big_int {}

https://en.wikipedia.org/wiki/Karatsuba_algorithm
https://gmplib.org/manual/FFT-Multiplication#FFT-Multiplication


Draft dex website wireframe for registration, login, etc.

There have been a lot of issues around registration, login flow, email registration, changing passwords, and (eventually) merging remote identities.
So far we've been dealing with these in a very ad hoc fashion (issue get's reported, we hack in a solution). But as dex moves forward, we'd like an overall design document to help developers understand were each step occupies in the larger flow.
This will also hopefully help when nailing down templates (#359).

Closing. We don't have any plans to do this, and it's not necessary to fix any existing issues.


Added additional check for local tag name.

I am having problems with parsing sheets with "AlternateContent" tags.
For example:
<mc:AlternateContent xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006">     <mc:Choice Requires="x14">         <controls>             <mc:AlternateContent xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006">                 <mc:Choice Requires="x14">                     <control name="Check Box 47" r:id="rId4" shapeId="47151">                         <controlPr autoFill="0" autoLine="0" autoPict="0" defaultSize="0">                             <anchor moveWithCells="1">                                 <from>                                     <xdr:col>15</xdr:col>                                     <xdr:colOff>0</xdr:colOff>                                     <xdr:row>85</xdr:row>                                     <xdr:rowOff>0</xdr:rowOff>                                 </from>                                 <to>                                     <xdr:col>15</xdr:col>                                     <xdr:colOff>247650</xdr:colOff>                                     <xdr:row>85</xdr:row>                                     <xdr:rowOff>0</xdr:rowOff>                                 </to>                             </anchor>                         </controlPr>                     </control>                 </mc:Choice>             </mc:AlternateContent>         </controls>     </mc:Choice> </mc:AlternateContent>
In this case, the <xdr:row> tag is mistaken for a regular row tag:
<row customFormat="1" hidden="1" ht="15" r="1" s="31" spans="1:32">
When you try to parse a value for "currentRow" from the "r" element, you get "NullpointerException".

Sorry for taking so long to review this. Could you add a test case that demonstrates this working with an Excel file?

I opened #65 with an alternate fix & test for this.
I decided to look at the namespace. I'm not sure http://schemas.openxmlformats.org/spreadsheetml/2006/main is the only legit namespace - I've seen references online to http://purl.oclc.org/ooxml/spreadsheetml/main - so for now I figured anything ending in "/main" is A-OK, as opposed to http://schemas.openxmlformats.org/drawingml/2006/spreadsheetDrawing which we need to ignore.

Closing as I believe #65 fixes this issue


Version solving failed

hello,
I am developing an application, which contains  this libraries-
dependencies:
flutter:
sdk: flutter
bloc: ^6.0.3
flutter_bloc: ^6.0.6
equatable: ^1.0.2
cupertino_icons: ^1.0.2
buttons_tabbar: ^1.2.1
tab_indicator_styler: ^2.0.0-null-safety
contained_tab_bar_view: ^0.7.1
speech_recognition: ^0.3.0+1
table_calendar: ^3.0.0
flutter_week_view: ^1.1.0
md2_tab_indicator: ^1.0.2
expandable: ^5.0.1
google_maps_flutter: ^2.0.3
http: ^0.12.2
encrypt: ^4.1.0
file_picker: ^3.0.1
archive: ^2.0.13
path_provider:
url_launcher:
pbkdf2_dart: ^2.1.0
dio: ^3.0.10
aes_crypt: ^0.1.1
intl: ^0.17.0
global_configuration: ^1.6.0
imei_plugin: ^1.2.0
device_info: ^2.0.0
sqflite: ^2.0.0+3
screenshot: ^0.3.0
camerawesome: ^0.2.2
path:
video_player:
shared_preferences: ^2.0.6
speech_to_text: ^4.2.1
image_editor_pro: ^1.1.8
while I import image_editor_pro: ^1.1.8 in the yaml file it seems something like this-
Because image_editor_pro >=1.1.0 depends on dio ^4.0.0 and test_app depends on dio ^3.0.10, image_editor_pro >=1.1.0 is forbidden.
So, because test_app  depends on image_editor_pro ^1.1.8, version solving failed.
pub get failed (1; So, because test_app  depends on image_editor_pro ^1.1.8, version solving failed.)
how can I fix this error. I need to use image editor in my app. Is there any way to solve this issue?
Thank you in advance.
I am adding some screenshot here.

Yes, it uses old versions of dependencies and version solving fails if we use new versions of those packages

Thanks for your information. Can you please tell me is there any way to resolve it?

Not from your side, the package should be updated to a new version.

Thanks a lot.


awkward phrasing in footer - definition of states

"NoneCookie" (SameSite=None) is invalid and should never rejected by the browser and never sent.

also, "reqursts" in:
"DefaultCookie" (No SameSite attribute) will always be sent on cross-site reqursts until your browser rolls out SameSite=Lax by default.


add nginx 1.25.2 to build/test/release

This is for #32.

Whoops, forgot to push the new build images. Let's try that again.

This is something we should be able to automate soon.


(WIP) Refactor existing code and add support for asset bundle generation.

Rough draft; need to look it over again. Does the following things--

Refactors out a BaseDistributionExtension with properties common to all slsv2 product types. This is inherited by an AssetDistr... and an ServiceDistr..., the latter being the existing class
Moves packages; com.palantir.gradle.javadist -> com.palantir.gradle.dist.(service|asset)
Lastly, adds a asset-distribution plugin which accepts mappings of sourceDir, relocatedDir that will be used to copy static content into the final asset bundle. As with the java dist plugin, the final tarball is created at ${project.buildDir}/build/distributions/${serviceName}-${versionName}.sls.tgz.

Note that I'm not renaming properties on the extension e.g. serviceName to be the more consistent productName (per slsv2) in the interest of not breaking existing users of the plugin. There is also an assumption here that we're not going to produce multiple slsv2 product type dists from the same gradle subproject (I re-use the distTar and distribution names), which should be ok as by convention we only have one configuration.yml per subproject anyway.
Happy to break it up as appropriate.

This change is

Can you separate the refactor from the feature PR, please? This is a bit
too bulky to review, sorry.
On Sat, Jan 21, 2017, 00:15 Divyanshu Arora<EMAIL_ADDRESS>wrote:

@darora commented on this pull request.
In
src/main/groovy/com/palantir/gradle/dist/service/tasks/CreateManifestTask.groovy
https://github.com/palantir/gradle-java-distribution/pull/157#pullrequestreview-17784281
:

@@ -32,6 +32,9 @@ class CreateManifestTask extends DefaultTask {
String serviceGroup

 @Input

String productType

@Input
Map<String, Object> manifestExtensions
CreateManifestTask() {

can be moved out of service specific dir
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/palantir/gradle-java-distribution/pull/157#pullrequestreview-17784281,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGOdwQ0eIFum5U_P6lW-uCazu3AgA6C1ks5rUUARgaJpZM4Lp2Iw
.

closing in favour of refactor in #158 ; will put up the feature after.


Scrolling inside animated tabs not working

Hi Vlad, I have been working with the kitchen sink and learning it and also the f7 docs.  I have made some test, and added the animation option to the tabs in the kitchen sink project.  But when i do this, the content inside the tabs is not scrollable any more.  if i use the regular tabs without animation, than it is scrollable.
this is the code i have in the tabs page:
Is this a bug or did I miss anything?
Thanks,
Shaul.

If you're like me and you copied the ''get started lay-out from the docs'' you'll need to change this class ()
Example:
.pages {
overflow: auto;
-webkit-overflow-scrolling: touch;
}
That'll fix it.

   .tabs-animated-wrap > .tabs > .tab  {
     overflow: auto;
     -webkit-overflow-scrolling: touch;
   }

This solved my issue.


Replace ListView with RecyclerView

I have replaced the ListView of the DayPickerView with a RecyclerView and applied few optimisation to the adapter.
I need to reformat the code. where can I find the formatter?

This was on my list of things to do.
I'll definitely be taking a closer look at this.
I'm not sure I understand what you mean with a formatter. Are you looking for a gradle task that applies a code style?

I'm glad you will consider it.
as you can see the codestyles in my AndroidStudio have changed everything.

You're right: having a code style will make contributing easier.
Let me see if I can make one that more or less matches the current style (it's a bit of a mess already)

sounds great!
also I have other big changes I have done on this code, (like I have extracted the controller from the Dialog, so the DayPickerView is now independent, or I have profiled and optimised some parts), and I would like to discuss with you if you are interested in receiving PRs like that

Definitely. Seems like you have the time I lack at the moment.
Let me block some time to go through your existing PRs at a high level, and then we can set something up.

I read through the code and this looks good to me.
I need to find some time to test the result on my test devices, but after that this should be good to go.
It will also make implementing horizontal scrolling in the version 2 layout a lot easier 👍

I was about to send you a message. this code is not ready yet (the scrolling is not very natural). On a separate implementation I have replaced the RecyclerView with this PagerView implementation using a RecyclerView (https://github.com/lsjwzh/RecyclerViewPager/blob/master/lib/src/main/java/com/lsjwzh/widget/recyclerviewpager/RecyclerViewPager.java) an it looks much more natural and smooth. I may consider to copy the logic for the scrolling and add it here

I'm really interested in this PR, so please update it.
Let me know when I should take a look at it again

I totally forgot to fix my PR. I have also realised that in support library 24.2.0 they have released a SnapHelper (https://rubensousa.github.io/2016/08/recyclerviewsnap) which can be helpful here. I need to find some time to fix it. sorry!

Good stuff. I'm really looking forward to this one.


Pull Request Preview Environments for increasing maintainer productivity

I would like to make life easier for roadmap maintainers by implementing Uffizzi preview environments.
Disclaimer: I work on Uffizzi.
Uffizzi is a Open Source full stack previews engine and our platform is available completely free for roadmap (and all open source projects). This will provide maintainers with preview environments of their PRs in the cloud, allowing them iterate faster and reduce time to merge.
Uffizzi is purpose-built for the task of previewing PRs and it integrates with your workflow to deploy preview environments in the background without any manual steps for maintainers or contributors.
TODO:

[ ] Intial PoC

Hi @waveywaves,
So basically, what is your question or issue here?

Hi @Cannonb4ll
I am proposing to implement a PoC for roadmap basically. I can see how the message might have gotten lost in the issue. Let me know what you think.

Sure feel free to send in a PR, I'll review that then 👏

Closed due to inactivity.


Not support Firebase version >= 10.0

[!] CocoaPods could not find compatible versions for pod "Firebase/RemoteConfig":
  In snapshot (Podfile.lock):
    Firebase/RemoteConfig (= 10.2.0, ~> 10.2.0)

  In Podfile:
    ARCore/Geospatial (~> 1.34.0) was resolved to 1.34.0, which depends on
      ARCore/GARSession (= 1.34.0) was resolved to 1.34.0, which depends on
        Firebase/RemoteConfig (< 10.0, >= 8.0)

    Firebase/RemoteConfig (~> 10.2.0)

Now, the latest version of firebase is 10.2.0.
Please update the dependencies.

This is already updated in ARCore 1.35.0.


Add LICENSE

Add some license stuff, probably MIT

Do you think that adding a license that tells the user that fork this work to contribute back with the code changes?
In this way, it helps to grow a single library and not fragment it.
The Linux kernel use this kind of License

That sounds interesting, linux kernel uses GPLv2 right?
I was thinking MIT license because I see a lot of other projects using it (e.g. nakamoto, or the rust bech32 library).
I don't know a lot about licenses. If you think GPL is good then that might also be an interesting choice. I think there's also a difference between GPLv2 and GPLv3, not sure which would be better.

That sounds interesting, linux kernel uses GPLv2 right?

Yes this is the one

I don't know a lot about licenses. If you think GPL is good then that might also be an interesting choice. I think there's also a difference between GPLv2 and GPLv3, not sure which would be better.

In my view GPLv2 is good and GPLv3 is bad because restricts some usage, and GPLv2 tell you just to contribute back with the changes.
But the license is really up to you as you are the creator of this project, personally I am a little bit strict with people that do not contribute back with changes to my project in order to help grow, but again this is just my idea and your can be different

Decided to go for the MIT license after all, since it's quite popular and I'm more confident in knowing the implications of this license.


Paths not updated before build

Hi there, thanks for maintaining this great fork of SceneReference.
The readme states the following:

Paths are updated during build (guaranteed by the ISerializationCallbackReceiver).

However my tests with the original SceneReference show that it does not handle path changes, renaming or moving scenes.
Could you confirm if it should work?
And if so how does ISerializationCallbackReceiver achieve this?

Hello,
You can check out the whole repository - it is a Unity project with some
test setup. Basically I have a starter scene in which with hotkeys 1 to 5
it loads other scenes by SceneReferences.
In this starter scene, I use SceneReferences to other scenes in a scene
GameObject field, in a prefab and in a ScriptableObject.
[image: image.png]
If I go and rename all target scenes, make a build and try out the hotkeys,
it does seem to work.
As far as I remember, when Unity builds scenes it opens each one of them
and serializes them to bundles. While doing this it calls
"OnBeforeSerialize()" on objects which updates the scene paths.
If you know some other ways this could fail, please let me know. It would
be best if you give me some reproduction steps.
For example - I haven't tested if this works with bundled scenes
(Addressables or similar).
Cheers :)
On Fri, Dec 2, 2022 at 3:06 AM Hamza Lazaar @.***>
wrote:

Hi there, thanks for maintaining this great fork of SceneReference.
The readme states the following:
Paths are updated during build (guaranteed by the
ISerializationCallbackReceiver
https://docs.unity3d.com/ScriptReference/ISerializationCallbackReceiver.html
).
However my tests with the original SceneReference shows that it does not
handle path changes, renaming or moving scenes.
Could you confirm if it should work?
And if so how does ISerializationCallbackReceiver achieve this?
—
Reply to this email directly, view it on GitHub
https://github.com/NibbleByte/UnitySceneReference/issues/2, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARZSRBTRNIG5KICOOEN2OLWLFDQ3ANCNFSM6AAAAAASRMIZPA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


can't install package

i want install package with:
composer require alexbowers/nova-prepopulate-searchable
but its not working :
`$ composer require alexbowers/nova-prepopulate-searchable
Using version ^1.0 for alexbowers/nova-prepopulate-searchable
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- alexbowers/nova-prepopulate-searchable v1.0.1 requires laravel/nova >=1.0.13 -> no matching package found.
- alexbowers/nova-prepopulate-searchable v1.0.0 requires laravel/nova >=1.0.13 -> no matching package found.
- Installation request for alexbowers/nova-prepopulate-searchable ^1.0 -> satisfiable by alexbowers/nova-prepopulate-searchable[v1.0.0, v1.0.1].
Potential causes:

A typo in the package name
The package is not available in a stable-enough version according to your minimum-stability setting
see https://getcomposer.org/doc/04-schema.md#minimum-stability for more details.
It's a private package and you forgot to add a custom repository to find it

Read https://getcomposer.org/doc/articles/troubleshooting.md for further common problems.
Installation failed, reverting ./composer.json to its original content.
`
my composer.json
{
    "name": "laravel/laravel",
    "type": "project",
    "description": "The Laravel Framework.",
    "keywords": [
        "framework",
        "laravel"
    ],
    "license": "MIT",
    "require": {
        "php": "^7.1.3",
        "achalj09/editresource": "^0.0.1",
        "benjaminhirsch/nova-slug-field": "^1.1",
        "caouecs/laravel-lang": "~3.0",
        "coderello/laravel-nova-lang": "^1.0",
        "doctrine/dbal": "^2.8",
        "fideloper/proxy": "^4.0",
        "fourstacks/nova-checkboxes": "^0.1.2",
        "friendsofphp/php-cs-fixer": "^2.13",
        "guzzlehttp/guzzle": "^6.3",
        "laravel/framework": "5.7.*",
        "laravel/nova": "*",
        "laravel/tinker": "^1.0",
        "maatwebsite/laravel-nova-excel": "^1.1",
        "predis/predis": "^1.1",
        "shivanshrajpoot/nova-create-or-add": "^0.0.1",
        "silvanite/novafieldcheckboxes": "^1.1"
    },
    "require-dev": {
        "beyondcode/laravel-dump-server": "^1.0",
        "filp/whoops": "^2.0",
        "fzaninotto/faker": "^1.4",
        "mockery/mockery": "^1.0",
        "nunomaduro/collision": "^2.0",
        "phpunit/phpunit": "^7.0"
    },
    "config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",
        "sort-packages": true
    },
    "extra": {
        "laravel": {
            "dont-discover": []
        }
    },
    "autoload": {
        "psr-4": {
            "App\\": "app/"
        },
        "classmap": [
            "database/seeds",
            "database/factories"
        ]
    },
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },
    "minimum-stability": "dev",
    "prefer-stable": true
}

@alexbowers there are different ways of installing Nova. I suggest removing the requirement of the package in composer.json.

Unfortunately, because this only works from version 1.0.13 onwards in Nova, I will be keeping the composer requirement.
The dependency we have is:
Add Macroable to Field.

For this package to be usable, you must also have installed nova via Composer.
For details on how to do that:
https://nova.laravel.com/docs/1.0/installation.html#installing-nova-via-composer


Optimizations for emacs package

Recognize functions that have special opcode in emacs.Call and replace function call with that.
Maybe instr_spec can be used as a map of function names.
emacs.Call("cons", a, b)
=>
stack-ref "a"
stack-ref "b"
cons

emacs.Call("list", 1, 2)
constant 1
constant 2
list2

...etc

Implemented simplest cases.
It is an open question how to handle defsubst or other forms that compile to the opcodes.

InstrCall does precisely this.


Using genql for server side (resolver) typing

It looks like genql can be used for inserting proper types when writing the actual resolvers too, instead of just client side. However the support isn't great.
In an AWS amplify world I get types I can use as follows:
import { AppSyncResolverEvent } from "aws-lambda"
import { Maybe, MutationFooArgs, Foo } from "../generated/graphql"

export const foo = async (
  event: AppSyncResolverEvent<MutationFooArgs>
): Promise<Maybe<Foo>> => {
  ...
}

With genql the best I could do was something like:
import { AppSyncResolverEvent } from "aws-lambda"
import { MutationGenqlSelection, Mutation } from "../generated/genql/schema"

export const foo = async (
  event: AppSyncResolverEvent<MutationGenqlSelection["foo"]["__args"]["input"]>
): Promise<Mutation["foo"]> => {
  ...
}

This is harder to write and get correct as autocomplete doesn't work well here it seems.
Could genql create some types that would work better in the backend?

Genql is not built for this use case, it's better if you use the previous types generator for this


Fix issue where GetIP in VirtualBox failes due to no SSH

This patch consolidates most of the SSH command and wait logic to the
drivers package.  The existing functions in host are just wrappers to the
real implementation in drivers.
Signed-off-by: Darren Shepherd<EMAIL_ADDRESS>

@nathanleclaire This is my attempt at fixing the VirtualBox issue I saw today where things randomly fail with RancherOS on VirtualBox because SSH is not always available immediately.
One random thing I changed was that WaitForTCP before would read 1 byte.  I changed it to just do a connect.  I was having issue where it would never succeed because it would just get an EOF on read.

I think I broke travis.  The build associated with this PR has the wrong commit ID.

@nathanleclaire This is my attempt at fixing the VirtualBox issue I saw today where things randomly fail with RancherOS on VirtualBox because SSH is not always available immediately.

Nice.

One random thing I changed was that WaitForTCP before would read 1 byte. I changed it to just do a connect. I was having issue where it would never succeed because it would just get an EOF on read.

Yeah, I noticed that.  I wonder what the original motivation was.  I'm fine with this change, it makes sense to me.

I think I broke travis. The build associated with this PR has the wrong commit ID.

Odd.  Can you try adding a comment or something + rebasing this into a different commit SHA + force pushing to try and kick off a new build in case something went weird on their side?  Meanwhile I'll check it out locally.  Looks pretty good to me.

Fixed.  It was actually my problem.  I misunderstood what travis was doing.  I guess travis merges before the build (which is good).  There was a compilation error.  Anyhow fixed.

Nice.  LGTM cc @ehazlett

LGTM


to solve the over length of bar problem

to solve the over length of bar problem for me (as i have really big number in prediction)
it's about the find_max function , the original function only find the biggest number in target array, so i change the fucnction to:
def find_max(list_):
    """Return the maximum value in sublist of list."""
    m1=max([sublist[-1] for sublist in list_])
    m2 = max([sublist[0] for sublist in list_])
    return max([m1,m2])

and solved my problem :)

@songmuyi Do you have a sample data that I can test with?


Iteration Plan for June 2019

This plan captures our work in June. This is a 4-week iteration. We will ship our June Update in early July.
We'll focus on smaller, highly upvoted features such as improvements to the minimap, and we'll keep stabilizing and improving the remote development extensions.
Endgame

June 24, 2019: Endgame begins
June 28, 2019: Endgame done

The endgame details for this iteration are tracked in TBD
Plan Items
Below is a summary of the top level plan items.
Legend of annotations:

Mark
Description

:runner:
work in progress

:hand:
blocked task

:muscle:
stretch goal for this iteration

:red_circle:
missing issue reference

:large_blue_circle:
more investigation required to remove uncertainty

:black_circle:
under discussion within the team

UX

[ ] :runner: Iconography re-design https://github.com/Microsoft/vscode/issues/8017 @misolori

Workbench

[x] Support to hide/show status bar items contributed by extensions @bpasero https://github.com/microsoft/vscode/issues/3874
[ ] :runner: Add support for indentation guides in trees https://github.com/microsoft/vscode/issues/17777 @joaomoreno
[ ] Provide easy access to online services settings https://github.com/microsoft/vscode/issues/75215 @rmacfarlane
[ ] :muscle: Flatten folder hierarchies in the explorer https://github.com/Microsoft/vscode/issues/41627 @isidorn @joaomoreno

Editor

[ ] Render search results in the editor minimap https://github.com/microsoft/vscode/issues/75216 @rmacfarlane
[ ] :muscle: Provide setting for visually indicating whitespace in selections https://github.com/microsoft/vscode/issues/1477 @rmacfarlane

Terminal

[x] xterm.js improvements https://github.com/microsoft/vscode/issues/74861 @tyriar
[x] :runner: Investigate providing a clean environment for the terminal https://github.com/microsoft/vscode/issues/70248 @tyriar

Git

[ ] :runner: Support watching files outside of the workspace https://github.com/microsoft/vscode/issues/41085 @joaomoreno

Languages
LSP

[ ] :runner: Add support for progress reporting for client initiated work https://github.com/microsoft/language-server-protocol/issues/70 and https://github.com/microsoft/vs-streamjsonrpc/issues/139 @dbaeumer
[ ] :runner: Explore support for reporting partial results (e.g. workspace symbols) https://github.com/microsoft/vs-streamjsonrpc/issues/139 @dbaeumer

CSS/HTML/JSON

[ ] Adopt latest LSP improvements https://github.com/microsoft/vscode/issues/75271 @aeschli

TS

[x] Provide support to easily use the nightly of TS inside VS Code @mjbvz https://github.com/microsoft/vscode/issues/75222

Debug

[ ] :runner: Investigate support for 'Move execution point to line' support https://github.com/Microsoft/vscode/issues/25653 @weinand @isidorn

API

API finalization: query
API proposals: query

Extension Contributions

[ ] Improve getting started experience with the TS Lint extension @mjbvz https://github.com/microsoft/vscode-typescript-tslint-plugin/issues/99
[ ] Improvements to the Remote extensions (see plan here) team

Engineering

[ ] :runner: Update to electron 4.0 @bpasero @deepak1556 https://github.com/microsoft/vscode/issues/61787
[ ] Adopt new Tree implementation in Custom Views https://github.com/microsoft/vscode/issues/63566 @alexr00 @sandy081
[ ] :runner: Categorize/analyze currently open accessibility issues @isidorn
[ ] :red_circle: :runner: Explore providing tooling for GDPR code annotation extraction @lramos15
[ ] :red_circle: :muscle: Explore using TS for our GDPR code annotations @lramos15

Deferred Items

None

@kieferrm
You mentioned minimap, is there a chance to look at this minimap enhancement issue #21404 that I opened 2.5 years ago?
Another topic that I'd like to see improvement, to be more user friendly, is the color picker especially this issue #33568
Keep up the good work, that is by far my favorite editor!

🔴 🏃 Add support for indentation guides in trees @joaomoreno

here is missing issue reference
https://github.com/microsoft/vscode/issues/17777

@pie6k added the issue reference, thanks!

Hi there. electron nightly version comes to v7,  VSCode still use v4.  come on , let's do something.

@NateLing it's missing on the plan but we're exploring Electron 6 support right now.

@NateLing it's missing on the plan but we're exploring Electron 6 support right now.

Great to hear it. I hope that upgrading to the v. 6 will solve this annoying visual error in Win10 - https://github.com/microsoft/vscode/issues/74047

@kieferrm Gotta add #75985 endgame to top

Is June session closed?
What's going on with: Provide setting for visually indicating whitespace in selections - #1477
I was waiting for it very much 😞

Home sweet heart .


Install sram

Incorporates the change already in openroad  ( ?= -> +=) and adds flexibility provided by the open_pdks configure script (handles yes, no and directory correctly).

cancel this. need to rebase first.


Customize the Temporary File Path for GIF

I want to customize the temporary file location where GIFs are saved when an online GIF path is entered.
In short, Path.GetTempPath() is used by default. We should be able to customize this.

Hi @Taiizor,
Thanks for the feedback!
I'm not against the idea, but what is the rationale for this? Why is %TEMP% not an appropriate location for your use case?

Hi @Taiizor,
Thanks for the feedback! I'm not against the idea, but what is the rationale for this? Why is %TEMP% not an appropriate location for your use case?

Actually, it's suitable, but my application has a Cache directory, and I don't want my application to create a temporary file in another location. Therefore, it would be better if we could customize the temporary location ourselves.

Ah, I see. I guess that would be possible.
Just not sure what the best way to expose the feature would be. Most of the library's API is through the AnimationBehavior class, with attached properties set through XAML. But an attached property wouldn't be appropriate here, since you typically want to set the cache directory globally.
Exposing this on UriLoader would make sense, but the class is internal, and I'd rather not expose it just for this.
Maybe just a static method on AnimationBehavior, that you would call when the app starts?
e.g. AnimationBehavior.SetDownloadCacheLocation(@"C:\my\custom\path")
Would you be willing to submit a PR for this?

In the changes made, briefly, AnimationBehavior.SetDownloadCacheLocation(imgComponent, @"C:\my\custom\path") now changes the temporary file directory of the selected image component.

That's not what I had in mind. I don't think it's useful to be able to specify a different path for each image control. It's almost certainly overkill, and just adds complexity. That's what I said "an attached property wouldn't be appropriate" in my previous message 😉. I think it should just be a static field, shared by the whole app.

Additionally, I added support for .NET 6, .NET 7, and .NET 8.

No, you didn't, because they were already supported 😉. An assembly targeting .NET 5.0 can be consumed by an app targeting any version >= .NET 5.0.
I know you meant well, and I appreciate it, but please refrain from making more changes than what has been discussed.

In the changes made, briefly, AnimationBehavior.SetDownloadCacheLocation(imgComponent, @"C:\my\custom\path") now changes the temporary file directory of the selected image component.

That's not what I had in mind. I don't think it's useful to be able to specify a different path for each image control. It's almost certainly overkill, and just adds complexity. That's what I said "an attached property wouldn't be appropriate" in my previous message 😉. I think it should just be a static field, shared by the whole app.

Additionally, I added support for .NET 6, .NET 7, and .NET 8.

No, you didn't, because they were already supported 😉. An assembly targeting .NET 5.0 can be consumed by an app targeting any version >= .NET 5.0.
I know you meant well, and I appreciate it, but please refrain from making more changes than what has been discussed.

Actually, support for .NET Core 3.1 and .NET 5 has ended. I was planning to remove them and add .NET 6, 7, and 8, but I wanted to add them without removing them.

Actually, support for .NET Core 3.1 and .NET 5 has ended. I was planning to remove them and add .NET 6, 7, and 8, but I wanted to add them without removing them.

Indeed. Usually I keep supporting older target frameworks as long as it's not painful to do so, but at some point I will remove .NET Core 3.1 and .NET 5. But I'll do this in a major release, since it's a breaking change.

I just published the new version, it should appear shortly on NuGet.
Thanks again for the contribution @Taiizor!


confusion about depends_on and version keys in compose file

File: compose/compose-file/index.md
This is about docker-compose 1.11.1. I'm confused about the depends_on with condition in version 3 format.
Version 3 doc advertises it (https://docs.docker.com/compose/compose-file/#dependson), whereas docker-compose 1.10.0 release notes (https://github.com/docker/compose/releases/tag/1.10.0) state that "This feature will not be ported to version 3 Compose files".
The latter seems to be true, as the following compose fails with version 3 as follows:
version: '3'
services:

  service1:
    build: .
    container_name: one
    entrypoint: ["echo", "one complete!"]
    depends_on:
      service2:
        condition: service_healthy

  service2:
    build: .
    container_name: two
    entrypoint: ["sh", "-c", "sleep 5 && nc -l 5559"]
    healthcheck:
      test: "echo 'bababa' | nc localhost 5559"
      interval: 3s
      retries: 3

$ docker-compose up
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.service1.depends_on contains an invalid type, it should be an array

Trying to fix this with:
    depends_on:
      - service2
          condition: service_healthy

results in:
$ docker-compose up
ERROR: yaml.scanner.ScannerError: mapping values are not allowed here
  in "./docker-compose.yml", line 10, column 20

Is depends_on supported in version 3 or not? If not, please adjust the docs as needed. Or maybe I'm just doing it wrong? An example for format 3 next to the 2.1 one would come in handy then.
FYI, the Dockerfile used in build is:
FROM centos:latest

RUN yum --quiet --assumeyes upgrade \
    && yum --quiet --assumeyes install nmap-ncat

It's been 2 weeks without any reply on this seemingly simple, yet confusing issue. Please clarify the situation. That's all I'm asking. I need to know the actual status to be able to proceed with docker-compose for our project here. It will be on hold until your docs provide a clear reference information in regard to depends_on with condition vs version 3 docker-compose file format.

I'll take a look / claim this one.

So, I looked at this and I don't see anything wrong here really. The docs for version 3 say:
Version 3 no longer supports the condition form of depends_on.

It still supports depends_on for simple container startup order, just not the condition form. I don't see any examples that are inconsistent with that message.

@johnharris85
I opened this ticket on 13 Feb.
The note you refer to was added a month later, on 15 Mar (https://github.com/docker/docker.github.io/commit/37333c8fe86884e6b334fca1fcceb967581e54a4).
In the same commit the version 2 - specific example, that will not work with version 3, was also removed from the version 3 - specific doc.
Nice. These changes fix the issue I complained about.
What's worrying me however is that you didn't you check those facts yourself.

You are right, apologies.

Since this ended up being a no-op bug, the points value for closing this is 25, which goes to @johnharris85

Thanks @johnharris85, you get points for realizing this one can be closed. :)


creating a staging model for training

Can we get this merged @ian-r-rose. The failure is expected in the .yml file. It'll be fixed when trainees reference real values.


add release workflow to build and publish container image to ghcr

The following secrets are required for docker login to publish image to GHCR:
GHCR_USERNAME - this could be any string value; GH doesn't care
GHCR_PASSWORD - this is likely to be a personal access token generated at the guac repo or guacsec org
The release workflow will be triggered as a release is published. Release tag will be used as image tag.

It should probably just use
permissions:
  packages: write # To publish container images to GHCR

So that the normal GHA github token has permissions.
Example: https://github.com/ossf/allstar/blob/main/.github/workflows/release.yaml


How to add dispatchTouchEvent to multiple frameLayout

I followed gvr-events and I create two frameLayout scene. I add dispatchTouchEvent to both frameLayouts but the problem is when i click any frameLayout buttons both frameLayout Events are executed at the same time. Is there is any solution for that?

You should be able to filter events based on the scene object, here is one way you could do it:
https://github.com/rahul27/GearVRf-Demos/commit/2f9e138ae6121b6f9da2a22dd30c1dd37f3b34a0

Thanks, you're Genius man.


AWS Lambda Managed Layers for Python 3.11

Is there any plan to have the managed layer for Python 3.11?
Thank you.

Yes we are working on it and should be available in the coming days


GitHub gist support?

Could use gh gist create or probably the REST/GraphQL API. Feel free to close if you're not interested in supporting it, though.

Added in 6d13d50db59ce53a7991820b0c188715070ec656
https://gist.github.com/ (provider = "gist")
    command: "curl" (default) or "gh".
    token: PAT token string or function returning token string, required if command = "curl" | nil.

The use case for gists was a bit murky for me personally which is why I never added it, because they're a bit more permanent, allow updating them, etc. Probably it could suit a nicer interface for posting revisions.


Removed the git conflict markers in the source, accepting the HEAD code

I just found that there are still a git conflict markers left in the rpc-demo.html file. I just made an adjustment to accepts the HEAD's piece of code. If that's what you want, feel free to just pull it, or you could do it yourself. Just a heads up. Thanks for your work.

You removed the markers but keep both changes, can you remove jquery.terminal-src.js file and only keep jquery.terminal.min.js. If you do so I will merge.

I've removed the markers.


Update scaler powershell version to 7 in dockerfile

Update scaler powershell version to 7 in dockerfile

Closes #31


autocomplete doesn't work for non-ASC identifiers on Win7, and some cases on Mac

Steps to cause the bug to occur

Below are the sample codes I used to reproduce the issue:

for 名字 in range(1, 10):
    # 有补全（Mac下），输入”名“
    print(名字)

When keying in the parameter of print, typing in the first character should trigger auto-complete, as the ASC identifier works.
Actual & Expected behavior

This 名字 variable triggers auto-complete under Mac:

However a a different name 序号 doesn't work under Mac:

Additionally, neither case works under Windows 7.
Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running:                       Local | Remote | N/A
Extension version:                               2019.10.44104-xxx
VS Code version:                                1.39.2
Setting python.jediEnabled:               true | false
Python and/or Anaconda version:     3.7.3 under Mac, 3.6.5 under Win7
OS:                                                     Windows | Mac
Virtual environment:                           N/A

Developer Tools Console Output

None.

I'm not sure that this is an LS issue as much as it would be a VS Code issue to do with when they choose to send the completion request in this scenario. For example, I can hit Ctrl-Space to manually trigger a completion request, and we behave as expected.
@xgdgsc If you hit Ctrl+Space after typing the first character, does the expected thing happen?

I wonder what happens with the same character in, say, C# or C++.

I know that the input method in the issue isn't the Wubi method (I think this is macOS's pinyin mode), but it may be similar to microsoft/vscode#83428 as the input method replaces written text with another string.

@MikhailArkhipov TypeScript works under Mac for both cases as below, IIH.
名字：

序号：

@jakebailey I'm using a third-party pinyin input method (Sogou), but I can test with other input method.

TS is somewhat special as it ships with VS Code (I think they're able to do things outside the LSP), so there might be a difference there.

@jakebailey thanks for informing. C++ seems to have the same issue under Mac (序 doesn't get auto-completion):

Extension: ms-vscode.cpptools 0.25.1

Thanks for checking.
You may want to respond on microsoft/vscode#83428 or create a new issue on the VS Code repo with your info (and potentially a link here), as this seems to be a VS Code bug involving input methods that do text replacement, rather than something language specific that we can handle on our end.

I've linked this thread on their issue for more datapoints, but it's going to have to be a VS Code fix.


How to include a parent folder in the zip package

I am using your package successfully which is zipping everything I need within a specific folder except the parent folder itself.  Are there any parameters we can use to either include the parent folder, or create a parent folder that wraps the zipped content?  The name of my parent folder is called astra-child.  It's a child theme folder for a WordPress project I am working on.
This is what I am using within an npm & gulpfile.babel.js setup....
import gzip from 'gulp-zip';

//LATER...

const paths = {
  packageWP: {
    src: ['**/*','!.vscode{,/**}','!inc{,/**}','!node_modules{,/**}','!packaged{,/**}','!src{,/**}','!.babelrc','!.gitignore'],
    dest: 'packaged'
  }
}

//LATER...

export const packageWP = () => {
  return gulp.src(paths.packageWP.src)
  .pipe(gzip(`astra-child.zip`))
  .pipe(gulp.dest(paths.packageWP.dest));
}

//LATER...
export const _prod = gulp.series(...all my stuff...);
export const _package = gulp.series(_prod,packageWP);

If I run gulp _package from my terminal, it will execute your zip package and package all my child theme assets, except the parent folder itself.
What should I do to include the parent folder?

I stand corrected.  this is a non-issue, as a parent folder is generated when I follow my normal process.


Update publish-site.yaml to remove  build_from_code_artifact

In an attempt to fix the Issue #457, remove build_from_code_artifact: 'true' from build job of the publish-site.yaml.

@brian-rose @dcamron please see this one and let me know what you think

The publish-site action run from this branch past!

Despite the previous convo in this PR, now we are adding include-hidden-files into upload-artifact re this release note per @brian-rose 's comment.


Bumped Mesos to latest master (bb2deb3).

High Level Description

Bumped Mesos to latest master (apache/mesos@bb2deb3).
Bumped dcos-mesos-modules to latest master (dcos/dcos-mesos-modules@6ffea4242dd39e7f84a39bf40855ae11a9d2d0a8)

Related Issues
Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
Tests included as part of Mesos test suite.
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review):
Mesos Changelog
dcos-mesos-modules Changelog

[x] Test Results: Apache Mesos Jenkins CI Job

[ ] Code Coverage

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@asridharan: The mesos-modules package is failing to build. Any ideas/suggestions around that?

@karya0 not sure. Looks like the google protobuf compiler has changed, or the google protobuf version in Mesos has changed. Could you try compiling the repo against the HEAD and try debugging it from there?

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

This PR must still be linked to a corresponding DC/OS JIRA ticket.

Dropping in favor of #2142


Question about transaction

Hi, I'm executing (exec query) the stored procedure, which have the transaction inside. I'm setting autocommit to false, but when I see results it looks like the transaction is opened by PYODBC too.
I found in internet the following:

"That was from SQL server's perspective. In python, set autocommit = False will start an explicit tran,which equivalent to BEGIN TRANSACTION. "
Is it right? How can I prevent opening transaction by pyodbc?

Please first make sure you have looked at:

Documentation: https://github.com/mkleehammer/pyodbc/wiki
Other issues

Environment
To diagnose, we usually need to know the following, including version numbers.  On Windows, be
sure to specify 32-bit Python or 64-bit:

Python: 3.8.10
pyodbc: latest
OS: Linux
DB: SqlServer
driver: mssql 17

Issue
Often it is easiest to describe your issue as "expected behavior" and "observed behavior".

I have a transaction inside stored procedure, so it caused nested transaction...


[Usage] loss is 0.0 and tokenization mismatch: 102 vs. 104. (ignored)  on liuhaotian/llava-v1.6-34b

I have the same problem, could you please share me how to fix it?

same problem

i am facing the same problem

I ran into this yesterday. managed to fix it with advice from this  issue https://github.com/haotian-liu/LLaVA/issues/661#issuecomment-1778630921 . depending on if you're finetuning different models you'll need to adjust the calculations there. for me, I was using the </s> separator with tiny llama, so i needed to start cur_len = 1 and make cur_len += round_len + 1 to account for the separator tokenization in process_mpt

face the same problem

Plus, make sure to set the version value as 'mpt' due to the separation token.


Remove unneeded require

Fix https://github.com/discourse/prometheus_exporter/issues/222

superseded by #255, thanks for alerting!


Use envvar for DuckDB version in setup script

Changelog
Make duckdb version an versiable

@assignUser this is my first PR in velox, may I ask how a PR is merged?  For I foud all PR is closed but not merged in github, thanks.

@JackyWoo as this is a Meta project the code actually lives in the Meta monorepo. So PRs from github get reviewed and tested here but a meta employee has to import them into the internal monorepo. Once that is done and has passes checks it gets exported into the facebookincubator/velox repo by facebookbot and the PR is closed. It looks weird in your gh activity but the code does get merged properly ^^
It's a bit of a process and we are working towards are more streamlined  open-source first approach but that's stll a while of.

@assignUser really thanks.


Freeze "Data View" Tab

Hi there,
When I run a new query, the previous results shown in "Data View" Tab would be gone, is there any way to freeze this tab so I can switch across these tabs?
Thanks for your effort on this great project.

You can press ctrl + alt + x for executing your statement in a new tab. I can't find any function to "pin" tabs like sqldeveloper.

You can also ctrl+\ to execute the current statement in a new tab.
Pin Tab is not an option in the first tab. It is available in all other tabs through the tab context menu.
There is an issue filed in the 4.1.1 milestone to make the first tab pinable and also fix an issue with the way those tabs work. (Pin first tab)

Yes, it is ticket #1508 . Moved to 4.1.2 milestone.


How to implement multiple languages in one page

I'm submitting a ...  (check one with "x")
[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[x] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request

My use case is that I need the web site localized in all of the supported languages, but I also need part of an app (invoice editor) to be localized in different locale, depending what language the invoice is made with. (Think US based worker, that speaks french and is using the app in french, but she is sending an invoice to someone in Spain, and wants to preview the invoice in Spanish.) In this case, there area actually multiple selected locales at the same time in play: the ui should be in french, but the are containing the invoice preview should display spanish.
Any ideas how to tackle this one? Can I have multiple instances of TranslateService? We're using AOT.

Yeah, I got the same problem.

I ended up doing it like this:
import { Pipe, Injectable, Inject, ChangeDetectorRef } from '@angular/core'
import { Http } from '@angular/http'

import { TranslatePipe } from '@ngx-translate/core'
import { TranslateService, TranslateDefaultParser, MissingTranslationHandler, MissingTranslationHandlerParams } from '@ngx-translate/core'
import { TranslateHttpLoader } from '@ngx-translate/http-loader'

@Injectable()
@Pipe({
    name: 'translatecustom',
    pure: false // required to update the value when the promise is resolved
})
export class TranslateCustomPipe extends TranslatePipe {
    constructor(@Inject('customTranslator') private customTranslator: CustomTranslationService, private _theRef: ChangeDetectorRef) {
        super(customTranslator, _theRef)
    }
}

@Injectable()
export class CustomTranslationService extends TranslateService {
  constructor(http: Http) {
    super(null, new TranslateHttpLoader(http, '/assets/i18n/custom.', '.json'), new TranslateDefaultParser(), new MyMissingTranslationHandler(), true)
  }
}

export class MyMissingTranslationHandler implements MissingTranslationHandler {
  handle(params: MissingTranslationHandlerParams) {
    let key = params ? params.key : 'no key!'
    if (console) {
      console.log('Translation missing for ' + key)
    }
    return 'Translation missing for ' + key
  }
}

Notice the /assets/i18n/custom. part, that configures the loader to read from /assets/i18n/custom.en.json for an example.
And in your app module:
@NgModule({
  declarations: [
    ...,
    TranslateCustomPipe
  ],
  providers: [
    CustomTranslationService,
    { provide: 'customTranslator', useExisting: CustomTranslationService }
  ]
})
...

After this you can {{ 'valuutta' | translatelasku }} in your component, and inject CustomTranslationService to your components to use different language etc.
Note that you need to adapt this solution if you use different loader + the usual ymmv and code is provided as is and may contain bugs etc.
It would be EXTREMELY nice to see proper support for multiple TranslationServices and the option to specify which one is used in pipe / directive etc. Think of named services, where the current is default and used if nothing is specified.
The solution given here may break in future releases.

Good Idea.

Nice. Works as intended

Is there any update on this? Is this still the way to do it in late 2019? Thank you!

Seems I'm looking for similar functionality but looking at pipe, function, or service that could translate the same key to multiple languages. E.g. translate | 'en-US' within html template and following lines translate |  'nl-NL' etc

I also used in my case the approach proposed by @swftvsn, however for the CustomTranslationService example is a bit outdated and the constructor is expecting now some more parameters. I ended up with something like:
import { Injectable } from '@angular/core';
import { HttpClient } from '@angular/common/http';

import { TranslateService, TranslateDefaultParser, FakeMissingTranslationHandler, TranslateFakeCompiler } from '@ngx-translate/core'
import { TranslateHttpLoader } from '@ngx-translate/http-loader';

@Injectable()
export class CustomTranslationService extends TranslateService {
  constructor(http: HttpClient) {
    super(null, new TranslateHttpLoader(http, 'assets/i18n/', '.json'), new TranslateFakeCompiler(), new TranslateDefaultParser(), new FakeMissingTranslationHandler(), false, true, false, null)
  }
}

The last parameter is for the default language, which I however don't know upfront. Later you can then just call CustomTranslationService.use(lang) and use the service like you are used to. Of course the loader, compiler etc can be replaced as well with custom ones. Maybe this update saves somebody some time :man_shrugging:


Remove remain dependancy

The remain dependency is incredibly frustrating to work with as it produces a compile error and requires you to manually sort your enum variants alphabetically. This is exacerbated by the very long compile times which are wasted when you realise the enum is not in order for the third time in a row.
It is not clear that the code is easier to read if the enums are in alphabetical order. Even if it were, then the solution would be to add an option to rust fmt or another linter.
Therefore the remain dependency and any uses of it can be removed.

I'm open to that if it's a pain point for you. The original idea was to standardize the ordering so the enum definition and message handler match arms would be in a predictable location relative to one another, which had gotten to be a bit of a problem. I really wish rustfmt had some way to keep enums and match statements alphabetized, but alas rustfmt seems to be borderline abandoned which is sad.
I did also have some ideas in mind to use macro metaprogramming to basically hide away the boilerplate of the separate enum variant definitions (in *_message.rs) and the message handler match arms (in *_message_handler.rs) by basically just writing the code for each handler in a top-level function within *_message_handler.rs and letting the macro copy out the code and stick it in the match arms as well as also inserting a matching variant in the message enum definition. I'm no macro expert but I wonder if that's feasible.

It isn't really possible to generate an enum with variants containing identifiers from several different macro calls (as enums have to be declared with all the variants). You could have a macro on the MessageHandler impl that looks for a match statement in a process_message function and then creates an enum from that.


111 allow user to select asset for fee

General
Closes #111
Refactored SendModal and extracted FeeAssetSelector component with all logic related to fee calculations and managing assets to use.
Implemented SetDefaultFeeAssetModal, which allows to select Asset to pay fee and update settings as described in issue comments.
Added settings entry for default fee asset selection and integrated it with new modal.
Integrated default fee asset settings into Fee Schedule view of the wallet.
General
Please make sure the following is done:

Pull request is onto develop
If you haven't already, have a look at

https://github.com/bitshares/bitshares-ui/blob/develop/CODE_OF_CONDUCT.md
https://github.com/bitshares/bitshares-ui/blob/develop/CONTRIBUTING.md

Code Preparation
Please review all your changes one last time before committing

[x] Check for unused code
[x] No unrelated changes are included
[x] None of the changed files are reformatting only
[x] Code is self explanatory or documented
[ ] All written text is properly translated (english language)

Testing
The branch has been tested on the following browsers (desktop and mobile view)

[x] Chrome
[ ] Opera
[x] Firefox
[ ] Safari

User interface changes
Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

[x] Dark
[x] Light
[x] Midnight

Please provide screenshots/licecap of your changes below

please reference the issue of our repository on a PR and not the one in bitshares
please use a styleguide table in "Select asset to pay fee" modal for consistency, styling can be default
please display the chosen default fee asset in the settings component, with the button next to it

Will do integration test and code review on monday

See here as well, starting https://github.com/blockchainprojects/bitshares-ui/issues/111#issuecomment-502655596

@sschiessl-bcp , all TODOs and referenced issues are closed now, if there are no other change requests I believe this request can be synced with actual develop branch and merged

You can try my account on mainnet (no login necessary)
http://localhost:8080/account/sschiessl
When the modal is opened, the default asset for fee and the fee amount is loaded and then the remaining assets of the user account queried and displayed in the fee asset select dropdown.
I want to change the logic: Show the default asset and asset fee as is now, but only load other choices lazily when the user clicks on the dropdown.
Following reasoning:

When I first open the modal and don't do anything, it does heavy amount of re-renders (probably due to loading all my assets and check them for fee selection).
The dropdown does not reliable get editable after loading is complete. I must manually enter something in the memo, which triggers fee re-calculation, and then the dropdown becomes unlocked
I expect 95% of users being fine with the default, thus that is unnecessary effort

Ideally, the modal loads the default and the checkbox is clickable. When the user click, a loading indicator is shown and when done the dropdown expands.

The select modal also doesnt seem to load properly when opened from within the new component. Select e.g. BADCOIN from my account

@sschiessl-bcp , I fixed all the places to use default fee asset from settings appropriately.
Left to do is lazy loading of available assets, which will be done today.

@sschiessl-bcp , all stated tasks are done.

We have a few modals left that could be refactored to use new FeeAssetSelector. Should those be refactored too?

@sschiessl-bcp , all stated tasks are done.

We have a few modals left that could be refactored to use new FeeAssetSelector. Should those be refactored too?

Which modals are you referencing that could be refactored?

Please state which modals are missing. I will forward this PR now to not get out of touch with codebase too much. We can use new issue to streamline usage.

@sschiessl-bcp , modals I am talking about:

app/components/Dashboard/SimpleDepositWithdraw.jsx
app/components/Showcases/Barter.jsx
app/components/Modal/HtlcModal.jsx
app/components/Modal/WithdrawModalNew.jsx
app/components/Modal/DirectDebitModal.jsx
app/components/Modal/DirectDebitClaimModal.jsx


Test issue

@thenetworkgrinch You there??

@Dylan-Watson Tell me if you get a notification via the github app

I got a notification on my GitHub


Create automated releases as drafts, or add tooling to generate changelogs

The GH workflow for our releases sets draft: false. I wonder if we should create a release as a draft, and then manually update the release notes with a changelog of some kind.
Alternatively, we could use tooling like git-chglog to generate a changelog for the release and include that in the release description during the workflow.

If the latter (generating a changelog), I think it would be good if we consider standardizing on commit message styles. I prefer conventional-commits.

This seems like a good idea to me.


Support woff2

Hello,
Is there planned support for the woff2 format? For example, allsorts supports it. This format is convenient to embed fonts, for example in games.
kind regards

Plans - yes, but no timeline. It will be done when it will be done.

I wonder if it would be more appropriate to put WOFF support in a separate crate (or at least outside of Face/RawFace).  I'm just spitballing here but…
WOFF Considerations

Dependencies (brotli, zlib).  There are pure rust implementations of both, but this is still a big first step.
Heap allocation.  It's certainly possible to inflate stuff in a no-std environment and/or without heap allocations, but it's that much more archaic.
WOFF1 compresses each table individually, so it's probably not too intrusive to track whether a table should be inflated and use something like a ZlibStream struct.
WOFF2 encodes everything as one brotli stream after optionally applying some per table transformations.  This is different enough there's a risk of creating spaghetti code.
A separate struct could simply handle the table lookup and inflation and pass the "raw" inflated data back to the appropriate ttf-parser structs.  At that point it's probably (maybe?) worth extracting most of Face into a trait for ease if interoperability.

My approach would be to have a separate WOFF to TTF converter crate. I don't see much benefits of having WOFF support directly in ttf-parser. But I haven't looked deep enough into it.
It definitely feels like something that should not belong in ttf-parser.


Handle chain information in explicit form in invoices

This is a breaking change since inside the invoice structure we make chain non-optional; plus we add new error cases and make set_chain return Result. Thus I am making this PR against v11 branch.
Closes #103

Any reason why it is non-optional instead of optional as discussed in #103?

@fedsten the parameter is optional as was discussed, thus the invoice string is backwards-compatible. However, for each given invoice we always know which network it belongs to (since we are defaulting to mainnet as discussed), thus we must have a non-optional field.

Got it,  for clarifying.

In other words, a wallet will always know and be sure to which network a given invoice belongs. If the invoice has conflicting network information (like an address network doesn't match the network provided in a parameter) it will error during the parse procedure. But each parsed invoice always knows which network it is valid for,

@zoedberg wait, we do not have CI set up for this repo? Oh, I'll fix it.
I did this PR originally against v0.10 branch which was used rust-bitcoin v0.30. Then I understood it's breaking, so moved to v0.11, which doesn't depend on rust-bitcoin at all and have a different Address type (from bp-std) with different API. Thus the issue. Will fix.

Closing in favor of solution from https://github.com/RGB-WG/rgb-std/pull/118


[Bug] When the hive engine is scheduled, the error log of the engineConnManager is as follows: method did not exist: SessionHandler:

Search before asking

[X] I searched the issues and found no similar issues.

Linkis Component
linkis-commons
What happened + What you expected to happen
When the hive engine is scheduled, the error log of the engineConnManager is as follows: method did not exist: SessionHandler:

Relevent platform
·
Reproduction script
·
Anything else
This question comes from the QA documentation of the Linkis community
QA Link：https://docs.qq.com/doc/DSGZhdnpMV3lTUUxq
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Under the hive engine lib, the jetty jar package conflicts, and jetty-security and jetty-server are replaced with 9.4.20


remove unused types

code generation produced some types that ended up unused

Should cause no regressions -- nothing in particular to test

Verified manually for the types mentioned in this issue in Eclipse. They are no longer available.


VideoPress Deep Integration

Feature Description

Now that we have better support for VideoPress videos in the media library, we could consider going even further.
Right now, when one drops a video into the editor it is optimized locally and then uploaded to WordPress.
If using VideoPress, one might want to skip the local optimization and upload straight to VideoPress.
This requires some discovery to see whether this is actually feasible.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

For reference we could look into

gutenberg-video-upload.js - Gutenberg intergration.
videopress-plupload.js - Plupload intergation.

We should disable transcoding / cross origin isolation if videopress is in use. We will like need to add a PR to jetpack for this integration. I am hoping it is matter of enqueue these two scripts in the right place.


[Bug]: Days before and after Epiphany

Contact Details
<EMAIL_ADDRESS>What happened?
The counting of the days before and after Epiphany seems to be wrong.
The days before Epiphany should be named “Feria VI temporis Nativitatis” for “Friday Christmas Weekday”.
The days after Epiphany should be named “Feria II post Epiphaniam” for “Monday Christmas Weekday”.
Sources for the Latin and English are the Ordo Missae Celebrandae et Divini Officii persolvendi and the Liturgical Calendar for the Dioceses of the United States of America.
As things stand, we seem to be following the rule stated in the Romcal Project:
If Epiphany is celebrated on Jan. 6:
2. Days from Jan. 2 through Jan. 5 are called "*day before Epiphany"
5. Days between Jan. 6 and the following Sunday are called "*day after Epiphany"
If Epiphany is not celebrated on Jan. 6 (i.e., celebrated on Sunday):
2. Days after Jan. 1 but before the Sunday occurring from Jan. 2 through Jan. 8 are called "*day before Epiphany"
5. If Epiphany occurs on or before Jan. 6, then the days of the week following Epiphany are called "*day after Epiphany"
I have noticed in a few situations that the rules for RomCal seem to follow the English liturgical calendar (in England), so I have had to correct a few of them to be in line with the Universal Calendar and most other national calendars. I will try looking into this a bit more, to see how exactly it is printed in the liturgical calendars for Italy and the United States, perhaps a correction may have to be made.
Version
v3 (Default)
Which browsers are you seeing the problem on?
No response
Relevant error messages
No response

Follow up note from Steven van Roode:

In the 2008 Missale Romanum all weekdays during Christmas Time are called “feriae temporis Nativitatis” (see p. 102 no. 12 and p. 178-189). The distinction between before and after Epiphany is only made in the Mass formularies themselves, in rubrics for the collect and the preface. That's regardless on what day Epiphany is celebrated, January 6 or on Sunday.
In the Lectionary however, the readings are assigned to dates from January 2 to January 12, not to weekdays. Only when Epiphany is celebrated on Sunday, the readings for the days after Epiphany are assigned to weekdays  instead of dates. This results in two sets of readings for January 7: either before Epiphany (when it is celebrated on Sunday) or after Epiphany (when it is celebrated on January 6).
For the names of the weekdays of Christmas Time on the calendar, however, one should look at the Missale Romanum, and in the naming it makes no difference between before and after Epiphany. So it’s "Feria secunda (or II) temporis Nativitatis”, etc.
In Dutch they are called “Maandag van de kersttijd”, etc. (see Altaarmissaal p. 214). In English “Monday of Christmas Time”, etc. (see The Roman Missal, p. 190). But both in Latin, Dutch and English the exact terms are a little ambiguous, because the weekdays fall under the heading “Weekdays of Christmas Time” and the days themselves in that section are only named “Monday”, “Tuesday”, etc.

In Italian, on the Liturgical Calendar of the CEI, these days are called by date: Feria propria del 3 gennaio ...

this seems to have required a few commits to get working:

0af947bb5b4b4358649e5a7e9cf68f9344d7c1ed
fac935c63e1401bdfc88b79dfce7b07cbd0018ed
0e5e0494916c29cb9029526c9fc8c1eac9739e9e
49c1e24772bb90cd6c1b75fae9fa06a24915de20

And yet, we seem to now be having a problem in removing weekdays of Epiphany where Memorials are present, for the USA national calendar in all years except 2022 ??? See fullcalendar example...

as regards the last bug mentioned, for the USA national calendar, that in the year 2022 the weekdays between Epiphany and Baptism of the Lord perhaps are not even being generated. And Epiphany falls on Sunday January 2nd. To confirm this hypotheses, let's find another year where Epiphany falls on January 2nd...

In fact, in 2011 and 2028 and 2033, January 2nd falls on a Sunday, and again we have the same situation: weekdays after Epiphany are not being generated in the USA national calendar.

Ok this last bug is fixed in commit 96b8706


What is the main difference between Seata and DTX versions?

Seata版本开源的免费  DTX产品是收费的，想了解下主要的区别是什么，开源版本是否可以实现分布式事务，谢谢

Seata itself is a distributed transaction middleware. It is used to deal with distributed transactions.

Seata itself is a distributed transaction middleware. It is used to deal with distributed transactions.

you said i know, i want to know the differents!!

@githubyangxd  Seata is an open source version of DTX, and their main functions are almost the same.

I will close this issue,if you have further question about this issue,please comment here.thank you!


The big dilemma

This is currently the big dilemma, which is how the world parsing engine should work. I see three options:

Rewrite it from scratch in TypeScript.
Rip BZFlag's out and get it to run on WebAssembly.
Rewrite BZFlag's from scratch in C++ and make it compatible with WebAssembly, and make fairly easy to "drop in" to BZFlag as a replacement.

As far as I'm concerned wripping out BZFlag's and rewriting it would be almost the same difficulty (at least for me). The third option would be quite interesting, but would also be a lot of work. You're thoughts are welcome!

I'm leaning towards writing it from scratch in TypeScript.

I'd personally lean towards writing a new implementation; there's no way I'd trust BZFlag code outside of BZFlag 😅
The parsing itself shouldn't be too difficult? There's a lot to write and it'll be tedious, but there's no logic to parse. It's just objects to read and transform in respective TS objects.
For inspiration, JeffM has written a parser in his LibBZFlag project, https://github.com/JeffM2501/LibBZFlag/tree/master/BZFlag.IO.BZW

I'd personally lean towards writing a new implementation; there's no way I'd trust BZFlag code outside of BZFlag 😅
The parsing itself shouldn't be too difficult? There's a lot to write and it'll be tedious, but there's no logic to parse. It's just objects to read and transform in respective TS objects.
For inspiration, JeffM has written a parser in his LibBZFlag project, https://github.com/JeffM2501/LibBZFlag/tree/master/BZFlag.IO.BZW

Just got an idea on how it can be made a lot better 😄
Thanks for the link, that'll be extremely useful!

Just got an idea on how it can be made a lot better 😄
Thanks for the link, that'll be extremely useful!


Changing the CNI directory to mirror plugin-manager

Superceded by https://github.com/rancher/cniglue/pull/9


Update with Upsert

In 2.0.1 FongoConnection.update line 104 update is called with only two properties, the filter and the data to update, it ignores multi and upsert. The result is that for Mongo driver 3.0.2 it calls DBCollection.update on line 500. This call defaults to false for upsert and for multi. The behavior is such that if you call a collection.updateOne(query, update, updateOptions).upsert(true), the update will not be written if the query does not return a result. I believe the fix should be on line 104:
final WriteResult writeResult = collection.update(dbObject(update.getFilter()), dbObject(update.getUpdate()), update.isUpsert(), update.isMulti());

Hi,
have you try against the 2.0.2 version of fongo ?
https://github.com/fakemongo/fongo/commit/91ba255e1d522971fada9c348d0edfb15d57008f

That did the trick, thanks!


Update for prometheus-community

Update git locations.
Update CONTRIBUTING.md from prometheus/prometheus.
Set @superq as the first maintainer.

Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

@frodenas, would you like to remain as a maintainer?

@SuperQ I don't have enough bandwidth to be a maintainer, thanks for taking the lead!

No problem, thanks for creating a useful exporter and giving it to the community.


can' create or delete directories (webdav)

https://cetteup.com/36/cant-create-or-delete-directories-on-an-nginx-webdav-server-here-is-how-to-fix-that/
https://serverfault.com/questions/901325/how-to-rewrite-webdav-http-destination-request-header-on-nginx
https://www.robpeck.com/2020/06/making-webdav-actually-work-on-nginx/

maybe we I'll do it in Lua
https://www.nginx.com/resources/wiki/modules/lua/


Rush stack compiler made optional for 1.9.1 upgrade, fixes #1222

Rush stack compiler made optional for 1.9.1 upgrade, fixes #1222

Coverage remained the same at 100.0% when pulling 5dabd73eb552aae0167972c34e0d4f7a971c24d6 on VelinGeorgiev:fixes-1222 into 3042bbe08f8c20d16fa959c4b6a0c5a07f5415d8 on pnp:dev.

should we also look for other versions of the rush stack and suggest upgrade for those as well?

Before we proceed with this, I'd love to hear what you guys think: https://github.com/pnp/office365-cli/issues/1222#issuecomment-559858665

Merged manually. Thanks! 🚀


angular_router - example of best practice for routing in template files

Using router2 I have my numerous RoutePath exported to my components. What is the recommended way of using the routes from a template? To expose the RoutePath to the template I need to do something like:
RoutePath get routeUpdateProfile => updateProfileRoute;

This seems clumsy (and confusing needing two names per route). The alternative is not to use the routerLink directive and call a component method on (click) or (trigger). Neither way seems elegant.
Is there a better way I’ve not yet discovered?

Just discovered the hacker_news_pwa example so I think the way I am doing is correct:
https://github.com/dart-lang/angular/blob/master/examples/hacker_news_pwa/lib/app_component.dart


'w0', 'w$' position are wrong when screen is invalid since v8.0.515

Hi! I updated Vim and I noticed that a test for my plugin failed with breaking and maybe unexpected behavior change of line('w0') and line('w$').
How To Reproduce
v8.0.515 and above (HEAD, v8.0.515)
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "echo getpos('w0') getpos('w$')" --cmd quit
[0, 0, 1, 0] [0, -1, 1, 0]
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "call setline(1, range(100))" --cmd "echo getpos('w0') getpos('w$')" --cmd 'quit!'
[0, 1, 1, 0] [0, 0, 1, 0]

Before v8.0.514 (v8.0.514) (Expected behavior)
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "echo getpos('w0') getpos('w$')" --cmd quit
[0, 1, 1, 0] [0, 1, 1, 0]
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "call setline(1, range(100))" --cmd "echo getpos('w0') getpos('w$')" --cmd 'quit!'
[0, 1, 1, 0] [0, 42, 1, 0]

(The number "42" depends on the terminal height )
As I showed above, line('w0') and line('w$') value changed since v8.0.515 with vim -e -s ....
(Without -s flag, it works as expected)
Here is the problematic line.  https://github.com/vim/vim/commit/d5d37537d1fa46fd468bd378af2006dd09840f38#diff-730e42441ff982fa04a4df341a0c3e24L180
!screen_valid(TRUE) check changed.
We can fix this issue by simply revering this change, but it also means the problem patch 8.0.0515 fixed happens again too, so I cannot figure out how to fix it.
Vim Version
8.0.515 and above

haya14busa wrote:

Hi! I updated Vim and I noticed that a test for my plugin failed with breaking and maybe unexpected behavior change of line('w0') and line('w$').
How To Reproduce
v8.0.515 and above (HEAD, v8.0.515)
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "echo getpos('w0') getpos('w$')" --cmd quit
[0, 0, 1, 0] [0, -1, 1, 0]
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "call setline(1, range(100))" --cmd "echo getpos('w0') getpos('w$')" --cmd 'quit!'
[0, 1, 1, 0] [0, 0, 1, 0]

Before v8.0.514 (v8.0.514) (Expected behavior)
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "echo getpos('w0') getpos('w$')" --cmd quit
[0, 1, 1, 0] [0, 1, 1, 0]
$ vim -X -N -u NONE -i NONE -n -V1 -e -s --cmd "call setline(1, range(100))" --cmd "echo getpos('w0') getpos('w$')" --cmd 'quit!'
[0, 1, 1, 0] [0, 42, 1, 0]

(The number "42" depends on the terminal height )
As I showed above, line('w0') and line('w$') value changed since v8.0.515 with vim -e -s ....
(Without -s flag, it works as expected)
Here is the problematic line.  https://github.com/vim/vim/commit/d5d37537d1fa46fd468bd378af2006dd09840f38#diff-730e42441ff982fa04a4df341a0c3e24L180
!screen_valid(TRUE) check changed.
We can fix this issue by simply revering this change, but it also
means the problem patch 8.0.0515 fixed happens again too, so I cannot
figure out how to fix it.
Vim Version
8.0.515 and above

Well, in silent Ex mode there isn't really any display.  So the previous
results were already wrong.
Returning a zero line number doesn't make sense though, getpos('w0') can
return line one, which is the first line, even with an empty buffer.
Then for getpos('w$') we return the last visible line.  But there isn't
one.  This would also happen for a window that has been reduced to zero
height.  To remain consistent with tools that compute the number of
lines, it should return one less that 'w0'.  Thus the results become:
 [0, 1, 1, 0] [0, 0, 1, 0]

No matter what you put in the buffer.  I'll make a patch for that.
It won't fix your test.  I would argue that relying on any visible
information while in silent Ex mode was wrong, since it's silent and the
display is not updated.
--
Two fish in a tank. One says to the other:
"Do you know how to drive this thing?"
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Update CHANGELOG.md, fix a typo

I really enjoyed using this project, nice work! Caught a couple of typos in the CHANGELOG though 😛

thanks!<


Issue with dragging nodes on multipolygon outers

The nodes on this multipolygon can't be dragged.
http://localhost:8080/#background=Bing&id=r276895&map=16.77/40.37391/-74.93380

Here is a non-local link:
https://openstreetmap.us/iD/master/#background=Bing&id=r276895&map=16.00/40.3769/-74.9077
The nodes can't be dragged when the multipolygon is selected, but they can be dragged when the way is selected.


Create React App integrated in an existing application

If I have a react app nested in a server-side rendered page, how would I be able to get react to live-reload while in dev?
Right now, the server renders the page which has a DOM element the CRA app mounts to, to display within the application. It works great since we can't stop to rewrite the entire application just yet, but we can't get it to live-reload this way.
Basically my structure is
/app (server)
/public (css/js)
/ui (cra)
/views (server-side)

ui is all the react code, and it gets transpiled and pushed to the /public directory, where it then looks for div ids in /views to mount to. The server generates the page, loads the JS, and React starts running inside the rendered pages, wherever it mounts.
How can I run this app and have react hot-reload to /public for me?
Thanks!
Also, this would be nice to do without ejecting.

did you ever figure out a solution to this?

Nope.

our work app has a similar structure to yours. i was messing around with it today and found out you can get live-reloading if you run npm start in the react app and have your server load localhost:3000/bundle.js instead of the final production version of bundle.js

Interesting. That works pretty well but doesn't live-reload the component,
just updates the JS. Do you have a way to do that?
On Fri, Mar 23, 2018 at 9:54 PM, qwertwerty21<EMAIL_ADDRESS>wrote:

our work app has a similar structure to yours. i was messing around with
it today and found out you can get live-reloading if you run npm start in
the react app and have your server load localhost:3000/bundle.js instead
of the final production version of bundle.js
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/issues/4133#issuecomment-375846959,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKwACQ0_FManpzUop8ipCigAHBnqiJlkks5thdGVgaJpZM4Sktuk
.

--

Nathan Hyland
(602)740-5705

nope. still don't have true live-reload, but i figure it's still a better dev workflow than having to rebuild every time you want to see a change

Have a look at https://github.com/facebook/create-react-app/issues/3071


Improvements

Hello,
Thanks for your efforts.
Elinize sağlık, güzel bir kütüphane olmuş :)
I think it should be some improvements.

[ ] Country Priority (Boost) in List (I choose Turkey as 1, Russia 2, USA 3 etc..)
[ ] Alternative country names (For example: Turkey is same as Türkiye, Netherland same as Holland)
[x] 3. Country Exclude List (Maybe i exclude some of countries)

Oops,
I see "itemFilter" in source code :)
Remove the 3. item.

How about the ability to sort?
I am using country names and it looks wired. Kind of sort by field would be good I think?

Andorra
United Arab Emirates
Afganistan

@ziyan-junaideen it's good idea

Thanks for the kind words @muarifer =)
I'll think about first checkbox but I'm not sure about second(alternative names).

I'll think about sort by field, too @ziyan-junaideen

Alrightie, I added priority list and sort by field features with version 1.2.0. Thanks for suggestions.


Using the CacheExpirationInterval option does not work on a console app

We need to get a the latest feature flag value every time we read from Azure App configuration - FeatureManager.
By using:
.UseFeatureFlags(options => options.CacheExpirationInterval = TimeSpan.FromSeconds(15))
The above extension works as expected when used within an API project.
The same approach does NOT work on a console app.
Extra info: The extensions AddAzureAppConfiguration & UseAzureAppConfiguration are correctly used.
Steps to reproduce:

Create a console app (.Net 6 or 7)
Add an hosted service (eg. builder.Services.AddHostedService<MyHostedService>();) as BackgroundService
Add the Microsoft.FeatureManagement package and make sure to add and use it for your app as:
3.1 Services.AddAzureAppConfiguration()
3.2 app.UseAzureAppConfiguration();
3.3 .UseFeatureFlags(options => options.CacheExpirationInterval = TimeSpan.FromSeconds(15))
Create a Feature flag on  your Azure named "featureTest" as disabled
On the background service MyHostedService class add the following code during the ExecuteAsync overridden method:
while (!stoppingToken.IsCancellationRequested) {  var featureTestEnabled = await _featureManager.IsEnabledAsync("featureTest")  if (featureTestEnabled)  {      //do something  }  else  {      //do something else  }  await timer.WaitForNextTickAsync(stoppingToken); }
Run the code and verify the featureTestEnabled is false
Enable the featureTest feature flag on Azure and wait for the expiration time setup on startup.
Run the code again and verify the featureTestEnabled is still False while it should be TRUE

Hello @pregoli ,
For console apps (and Azure Functions), I believe the only way to refresh is to explicitly call TryRefreshAsync. See the Azure Functions Guide for an example.
I'll continue to look into this, because it's not clear to me why the refresh is restricted in this way.

Thanks for your reply @rossgrambo but I think refreshing explicitely is not the way We or The consumers of this library aim to go. You could end up refreshing on a schedule way even when there's no need to refresh it because no changes happened on FFs values.
I think the current behavior is due to the refresh/trigger is happening within the ASP.Net pipeline middleware while in the backgroundservice is not.
Please keep us in the loop.
Thanks!

After syncing with some other members, I see now why it's built the way it is. Here's a summary of it, only a couple parts might be of interest to you.

The library that handles dynamic configurations (.AddAzureAppConfiguration()) is our Provider Library.
This library reads from our server, and places it into Configuration for the app. Configuration is a part of .NET and can be thought of as a dictionary for traversing json-like data.
Configuration doesn't have a hook we could add a refresh check in, so when refreshing was built it used a timer approach and would update the config in a scheduled way. As you called out, this led to a bunch of refreshes for no reason. This was especially bad for stale apps, that continued to ping us without users or purpose.
The timer was replaced with a middleware. The middleware is setup via UseAzureAppConfiguration() where it adds AzureAppConfigurationRefreshMiddleware to be invoked during http requests. To refresh, TryRefreshAsync is called as an http request comes in. TryRefreshAsync does nothing if we're still within the cache expiration interval, otherwise it checks for a refresh. This means it's safe to call it multiple times.
Console apps don't have a consistent workflow we can add a hook to in the same way. So the current state is to leave it to the developer to trigger the refresh appropriately. Allowing a flag to change mid-execution might not make sense for some apps.
Here's a guide for now to setup refreshing for a .NET Core app: https://learn.microsoft.com/en-us/azure/azure-app-configuration/enable-dynamic-configuration-dotnet-core?tabs=core6x

All of that to say, I think you should add TryRefreshAsync() above your IsEnabledAsync() check. Because it's ignored when the cache hasn't expired, it should be safe to do. Alternatively, you could write a helper method that does the refresh and IsEnabled call.
I could see a world where we add a TryRefreshAsync onto calls to IsEnabledAsync as a part of FeatureManagement. This would add a dependency between FeatureManagement and the Provider which hasn't existed, and there are other concerns like flag flipping mid execution. Currently there's a clear separation of the libraries: FeatureManagement just reads from the Configuration, while the Provider manages updating the Configuration.

Closing this for now.


Uri cannot be constructed for URI reference of absolute path with colon and numbers

PHP version: x.y.z (hint: php --version)
8.1.4 (but also reproduced in 8.0, 7.4)
Description
A Uri cannot be constructed for a specific URI reference (consisting only of a path, used for imgproxy).
It is a valid URI reference though (by applying the regular expression from RFC 3986 and testing with other languages).
How to reproduce
<?php

use GuzzleHttp\Psr7\Uri;

$uri = new Uri('/_img/Lkc9WXxgdKTzoqaupsmHX6OpgIagQrg0GS8DcoLhUSg/fn:2/q:75/rs:fit:250:250:0:0/czM6Ly9yZWdlbmJvZ2VuLW5lb3MvbmVvcy9yZXNvdXJjZXMvcGVyc2lzdGVudC81MGRlNDg3YTE0NGNjNDZmZmI4OWY1OTczM2ZhNDhiNWY5N2FmNjI4');
// Fatal error: Uncaught GuzzleHttp\Psr7\Exception\MalformedUriException: Unable to parse URI: ...

If fn:2 is replaced by fn:some-filename, the URI reference can be parsed:
<?php

use GuzzleHttp\Psr7\Uri;

$uri = new Uri('/_img/Lkc9WXxgdKTzoqaupsmHX6OpgIagQrg0GS8DcoLhUSg/fn:some-filename/q:75/rs:fit:250:250:0:0/czM6Ly9yZWdlbmJvZ2VuLW5lb3MvbmVvcy9yZXNvdXJjZXMvcGVyc2lzdGVudC81MGRlNDg3YTE0NGNjNDZmZmI4OWY1OTczM2ZhNDhiNWY5N2FmNjI4');

Possible Solution
The path component fn:2 seems to be misinterpreted as the port of an authority by parse_url.
There might be other cases where URIs and URI references are not correctly parsed by parse_url according to the notes on https://www.php.net/manual/en/function.parse-url.php.
Using a regular expression based on the example in RFC 3986 might be a viable substitution.

I think this is because the path you've provided contains invalid characters - you can't use a colon. Replace all the colons with %3A and it should work.

Hi, thanks for the swift reply!
Well, it is not invalid according to https://datatracker.ietf.org/doc/html/rfc3986#appendix-A which includes colons for path segments in this scenario. I would expect Uri to be standards compliant here.
Additionally it's not that colons generally cause this issue. It's only if paired with a number - I guess it's because parse_url is just not meant for URIs but only full URLs and gets confused by an apparent host / port.

There's not much other option if you want to not pass a valid URI through to the Url class. Parse URL is not mis-interpreting it - it just is not meant to be given just a path. ;)


Grohe Sense über IOBroker

Hello. I´d like to ask about the plugin. I have installed an Homebridge adapter (in Wrapper-Modus) on IOBroker. Then i have installed your pluggin in homebridge on iobroker. It works nice but i cant control the valve of the Grohe Guard. Its not there or i cant see it in Objects in IOBroker. Other stuff are there (see pictures)... Control Sense Guard from HomeKit is checked. Can you help please ?

I have a branch Im working on where HomeKit characteristics are split out compared to today where they are bundled together in the same accessory. Im hoping this will make it easier to create automation scenes from the Home app, and possibly also solving your issue


codegen dicts of input/output types

...so we can use them for introspection, validation, variable coercion, etc.
I made the generics on InputType and OutputType covariant (+T) or contravariant (-T) as needed. This is so that we can refer to e.g. a list of arbitrary input types as InputType<mixed>, which is impossible if the generic type is invariant.

I made the generics on InputType and OutputType covariant (+T) or contravariant (-T) as needed. This is so that we can refer to e.g. a list of arbitrary input types as InputType, which is impossible if the generic type is invariant.

After reading this PR I understand co- and contravariance more than I ever have before, which is to say, I 50% understand them.

After reading this PR I understand co- and contravariance more than I ever have before, which is to say, I 50% understand them.

Heh, I just realized that part of this PR was actually unnecessary, since the lists should only contain NamedInputType/NamedOutputType, and those don't have any generics. I'll revert that part to keep things simple.

After reading this PR I understand co- and contravariance more than I ever have before, which is to say, I 50% understand them.

Heh, I just realized that part of this PR was actually unnecessary, since the lists should only contain NamedInputType/NamedOutputType, and those don't have any generics. I'll revert that part to keep things simple.

Oh, true! That is simpler.

After reading this PR I understand co- and contravariance more than I ever have before, which is to say, I 50% understand them.

If you wanna go from 50% to maybe 80%, https://docs.hhvm.com/hack/generics/variance has a decent overview, but I guarantee no one will ever 100% understand this :)

If you wanna go from 50% to maybe 80%, https://docs.hhvm.com/hack/generics/variance has a decent overview, but I guarantee no one will ever 100% understand this :)

Ha, I’ve read it a few times over the past year and it has helped somewhat, but I think encountering real-world use-cases is illuminating. It’s slowly coming together 😅

The array of animals example is pretty helpful: a read-only array of cats can be passed to a function which expects an array of animals, and a write-only array of animals can be passed to a function which expects an array of cars.