[SPARK-31164][SQL] Inconsistent rdd and output partitioning for bucket table when output doesn't contain all bucket columns

What changes were proposed in this pull request?

For a bucketed table, when deciding output partitioning, if the output doesn't contain all bucket columns, the result is UnknownPartitioning. But when generating rdd, current Spark uses createBucketedReadRDD because it doesn't check if the output contains all bucket columns. So the rdd and its output partitioning are inconsistent.
Why are the changes needed?

To fix a bug.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Modified existing tests.

Test build #119861 has started for PR 27924 at commit 6c7543b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24591/
Test PASSed.

Test build #119861 has finished for PR 27924 at commit 6c7543b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119861/
Test FAILed.

Test build #119864 has started for PR 27924 at commit 69b484e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24594/
Test PASSed.

Test build #119864 has finished for PR 27924 at commit 69b484e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119864/
Test FAILed.

cc @dbtsai since this is related to table bucketing.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24624/
Test PASSed.

Test build #119898 has started for PR 27924 at commit 85d5324.

Test build #119898 has finished for PR 27924 at commit 85d5324.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119898/
Test PASSed.

thanks for reviewing, merged to master/3.0

Thank you, @wzhfy and @cloud-fan

@cloud-fan @wzhfy
I'm wondering whether bucketed scan with UnknownPartitioning is valid.
As I understand it, bucketed scan has two effects

decides how we partition input files
benefits downstream operators (e.g. bucket join)

When 2 is not effective, we may still make use of 1. For example, we can have a bounded number of FilePartition, which could blow up driver memory without bucketed scan. Or is there a correctness issue I've missed?

I don't think limiting the number of file partitions was the design goal of the bucketed table. We can set spark.sql.files.maxPartitionBytes to a large number like 1GB to reduce the partitions.

Yes, but the effect has leaked into user space and this breaks it. As to my original question, is HashPartitioning a hard requirement for bucketed scan?

I don't think so, and Spark will disable bucketed scan if it has no benefit for downstream operators, see the rule DisableUnnecessaryBucketedScan

That rule can be disabled but this change can't.

That rule means this is by design. We believe bucketed scan is more expensive than a normal scan and only want to use it if it can avoid shuffles. Maybe this does not apply in your case but it applies in many other cases. If you found this issue before we release it, we can revert to avoid perf regression. But revert is not an option today as it may cause perf regression for more people.
I'd suggest revisiting your requirement and considering spark.sql.files.maxPartitionBytes. We should not abuse bucketed table here.

I'm not asking for revert here but to explore an option to disable this behavior, and hence the question about partitioning and bucketed scan.
Bucket table is built to avoid shuffle but it's a table and we cannot prevent downstream users from using it in other ways. As a platform, we'd better keep backward compatibility with some general options rather than asking users to fine tune their jobs.

I'm fine to keep backward compatible with some "by-accident" features if the cost is small. Feel free to open a PR to bring back the old behavior if

we do not re-introduce the correctness bug
the code is simple (less maintenance cost)

@cloud-fan please help check https://github.com/apache/spark/pull/36733


Update sizes.md

Current document returns HTTP 404 - Fixing Hyperlink
../linux/sizes?toc=/azure/virtual-machines/linux/toc.json&bc=/azure/virtual-machines/linux/breadcrumb/toc.json

@tedmanlee : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@tedmanlee Thanks for the contribution!
#sign-off


fix: link notifier time property to notify-send expire-time flag

The time property specified in the documentation had
no effect since it wasn't link to notify-send
expire-time flag

Thanks!


[Q] Transfer wandb-local data between servers

Hi. I want to transfer wandb-local data between servers and I have deleted the wandb directories created in the project directories. So my only way is doing it wand the wand docker volume. Manually copy/pasting it does not work and I cant login in the new instance. Is there any proper way to do it?

Hi @hussein-jafarinia
Good day and thank you for reaching out to us. Happy to help you on this!
Would it help you if you export your runs into a csv file and then log them to your new server/instance as a new run?
You can do something like a script (below) to "export" a run into a csv and then check this guide  on how you can log a run from a csv file.
import wandb
import pandas as pd

# Retrieve the run
run = wandb.Api().run("mohammadbakir/test_slow_wandb/q5x7ip2i")

# Scan the run history
history = run.scan_history()

# Convert the history to a list of dictionaries
history_list = [row for row in run.scan_history()]

# Convert the list of dictionaries to a DataFrame
history_df = pd.DataFrame(history_list)

# Save the DataFrame to a CSV file
history_df.to_csv('run_history.csv', index=False)

print("Run history saved to run_history.csv")

@paulosabile-wb
Thanks for the help. It not an option because my runs are actually a lot (in order of thousands) and some of them are in sweeps and some capabilities that wandb provides like watching aggregation of sweeps in forms of mean, std of metrics, ... are important and it would be a very very laborious thing to do all of these manually.

I'm sure there is another way. Because the docker volume is actually there. I just don't know how to make it work on a new machine (probably some problems with the mysql database)

Hi @hussein-jafarinia Good day and thank you for patiently waiting for my update. I checked this with our team and at this time, there isn't any supported migration offerings from one instance to another instance. We apologize for this.

Hi @hussein-jafarinia , since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!


Add scripts to make it easier to inspect source coverage

What the title says. Makes it easier for folks to generate coverage reports themselves, and gives direction on how to get source coverage information.

@bors-libra r=sblackshear

:pushpin: Commit 3e6f38a has been approved by sblackshear

@bors-libra retry

@bors-libra r=sblackshear

:pushpin: Commit 04c4766 has been approved by sblackshear

:hourglass: Testing commit 04c4766290002c2e4517406fe049d1a8f295d0b8 with merge f9e6d82e0c81c13b9ec13d75ef636ecee4fa27d3...

:broken_heart: Test failed - checks-actions_land_blocking_test

@bors-libra r=sblackshear

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit 04c4766 has been approved by sblackshear

:hourglass: Testing commit 04c4766290002c2e4517406fe049d1a8f295d0b8 with merge 0424ded4c9eb5ec7799a9b467a71371c00b1f924...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing 0424ded4c9eb5ec7799a9b467a71371c00b1f924 to master...


add Grid components (Container, Row, Col)

closes #749
This PR brings in the Grid layout components from React Bootstrap. A few devs have asked for some basic layout components and thought it would be valuable to have. Hopefully it should be intuitive enough to align and manage basic content across all breakpoints, especially as we try to create better experiences on mobile screens.
Chromatic build: https://62d040e741710e4f085e0647-bcwpacclug.chromatic.com/?path=/story/layouts-container--default
(ask me for the join link if you don't already have access to Chromatic)

Going to explore potentially updating the CardContainer component or maybe a different layout component that has the intention and guidance of aligning and stacking cards, but also has the flexibility to put other stuff in between. Just thinking about deciding if this is a layout, determining the proper breakpoints and columns.
https://user-images.githubusercontent.com/37383785/193342821-45ba2597-0447-4b61-a4e0-3e1034ccbf68.mov
example code looks something like this:
 <Container>
    <Row>
      <Col sm={{ span: 8, offset: 2 }} md={{ span: 8, offset: 2 }}>

A heading

        <Card title='Gain command over your panel of thousands (or millions) of users'>
        Customize your brand voice everywhere — emails, sender profiles, landing pages, opt-in forms, and screeners. Your customers will have a top-notch experience every time they interact with a researcher on your team.
        </Card>

          <Button variant='primary'>Submit</Button>

        <Card title='Card Stack 2'></Card>

Some arbitrary text

More text

        <Card title='Card Stack 3'></Card>
      </Col>
    </Row>
  </Container>

Re: the CardContainer with things other than Cards example: is there a way to set the gap space on the grid so that each item doesn't need to specify its own margin? Curious because margins can be annoying. We have a problem in forms where the form elements have a margin-bottom, but then the last in the list we usually have to remove the margin-bottom. So wondering if our layouts can handle consistent spacing between items w/out margin

Re: the CardContainer with things other than Cards example: is there a way to set the gap space on the grid so that each item doesn't need to specify its own margin? Curious because margins can be annoying. We have a problem in forms where the form elements have a margin-bottom, but then the last in the list we usually have to remove the margin-bottom. So wondering if our layouts can handle consistent spacing between items w/out margin

@rroppolo I think it's possible to use the utility classes from bootstrap to create gaps on the parent container (i don't think react-bootstrap has built it into their API yet tho). https://getbootstrap.com/docs/5.1/utilities/spacing/#gap Not sure if that's the route we would want to take since I think we're shying away from utility classes, but I've heard cases for and against


Julia 1.0 compat

Updates to allow this package to be used with Julia 1.0. It seems to work with Julia 0.7 as well. Tests pass in both versions.

Hi thanks for these efforts.  Please be aware there seems to be a similar effort in #12, at some stage I have to choose.

It is actually nice that more people care about this package. I see that the other pull request is very similar to mine, so choose one of them.


CIFuzz turning dry_run off

CIFuzz is working well with OpenSSL detecting bugs such as:
https://github.com/openssl/openssl/actions/runs/56917737
https://github.com/openssl/openssl/runs/504787714?check_suite_focus=true
This PR will allow CIFuzz to report errors.

@paulidale Can you take a look at this?

This issue is in a state where it requires action by @openssl/committers but the last update was 30 days ago

Ping @openssl/committers

Pushed! Thanks!


Organize cmd package

The cmd package is now organized into sub-package (and sub-directories) that match the CLI structure.
This also moves the create-pr and replace commands under the experimental sub-command to better represent their state.
The fs and withFs helper functions have been moved to the generic internal/utils package to avoid cyclic imports. It also seems to be a better home for it as it may be used in other parts of the code base.
https://issues.redhat.com/browse/HACBS-1736
Structure looks like this:
cmd
├── experimental
│   ├── create_pr.go
│   ├── experimental.go
│   ├── replace.go
│   └── replace_test.go
├── fetch
│   ├── fetch_commit.go
│   ├── fetch.go
│   ├── fetch_k8s_resource.go
│   └── fetch_policy.go
├── inspect
│   ├── inspect.go
│   └── inspect_policy.go
├── root.go
├── track
│   ├── track_bundle.go
│   ├── track_bundle_test.go
│   └── track.go
├── validate
│   ├── image.go
│   ├── image_test.go
│   ├── pipeline.go
│   ├── pipeline_test.go
│   ├── test_application_snapshot.json
│   └── validate.go
└── version
    ├── version.go
    └── version_test.go

There was an issue that the acceptance tests caught :tada:
It now seems to be hitting the random 404 errors. The tests do work on my machine :tm:

It now seems to be hitting the random 404 errors. The tests do work on my machine tm

I retry for those, this is the ever looming HACBS-1354.


Error 500 on /dashboard/ | Docker (docker-compose)

``Hi there,
I ran (as a test pre-migrating) PowerDNS-Admin with docker-compose against the same DB we're using with a locally "installed" git clone of PowerDNS-Admin.
Login is possible, same API-Key and Hash are used with docker-compose like we use it in our "installed" PowerDNS-Admin.
But on /dashboard/ it greets us with a 500 Error.
docker-compose logs -f has this for us:
powerdns_admin  | [2022-05-11 21:04:19,376] [app.py:1891] ERROR - Exception on /dashboard/ [GET]
powerdns_admin  | Traceback (most recent call last):
powerdns_admin  |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 2447, in wsgi_app
powerdns_admin  |     response = self.full_dispatch_request()
powerdns_admin  |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 1952, in full_dispatch_request
powerdns_admin  |     rv = self.handle_user_exception(e)
powerdns_admin  |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 1821, in handle_user_exception
powerdns_admin  |     reraise(exc_type, exc_value, tb)
powerdns_admin  |   File "/usr/lib/python3.8/site-packages/flask/_compat.py", line 39, in reraise
powerdns_admin  |     raise value
powerdns_admin  |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 1950, in full_dispatch_request
powerdns_admin  |     rv = self.dispatch_request()
powerdns_admin  |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 1936, in dispatch_request
powerdns_admin  |     return self.view_functions[rule.endpoint](**req.view_args)
powerdns_admin  |   File "/usr/lib/python3.8/site-packages/flask_login/utils.py", line 272, in decorated_view
powerdns_admin  |     return func(*args, **kwargs)
powerdns_admin  |   File "/app/powerdnsadmin/routes/dashboard.py", line 192, in dashboard
powerdns_admin  |     detailedHistories = convert_histories(history)
powerdns_admin  |   File "/app/powerdnsadmin/routes/admin.py", line 914, in convert_histories
powerdns_admin  |     detailedHistories.append(DetailedHistory(histories[i], None))
powerdns_admin  |   File "/app/powerdnsadmin/routes/admin.py", line 766, in __init__
powerdns_admin  |     detail_dict = json.loads(history.detail)
powerdns_admin  |   File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
powerdns_admin  |     return _default_decoder.decode(s)
powerdns_admin  |   File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
powerdns_admin  |     obj, end = self.raw_decode(s, idx=_w(s, 0).end())
powerdns_admin  |   File "/usr/lib/python3.8/json/decoder.py", line 353, in raw_decode
powerdns_admin  |     obj, end = self.scan_once(s, idx)
powerdns_admin  | json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
OS: Ubuntu 22.04
Docker-Version: 20.10.15, build fd82621
Docker-Compose-Version: v2.5.0
It's running unprivileged under a normal useraccount (not root). All other pages within PowerDNS-Admin are working, connection to our PDNS server is also working.
Any ideas? Maybe I'm just dumb and blind - I just don't know.
BR
Tim

Magically, without changing anything, it now is functional, no further errors. Sorry for disturbing. :-D

I have similar issue

Hello,
Do you also use the docker image to run PDA ? You need to use v0.2.5 or later, as well as upgrading your 'not containerized' app and then run 'flask db upgrade' otherwise.
Regards


How to eliminate the single point of drag and drop, by the user complete control of drag-and-drop behavior

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Please use any of the available templates on either
jsFiddle,
plunker,
or codepen to give a reproducible example showcasing the issue.
Expected behavior
A clear and concise description of what you expected to happen.

Hey @zhelizhu,
Sorry, but could you elaborate a little more on what you are trying to achieve?
Furthermore, as it seems this is rather asking for advice than describing a bug, I'd like to redirect you to the Discussions section.


The Repo is read only

when trying to clone the repo it tells me it's read only. Could you change that please?

But it works on my device 🙂
Try after update pkg (git)


Update outputs from 'shield target' and shield update-target'

Currently, when viewing a target in the shield CLI, it does not give any information about the configuration for said target. This PR adds a Configuration line to the output of target and update-target to show the operator the current or the updated configuration without having to run targets

:+1:


http: Allow grpc_http1_reverse_bridge to translate 201.

When using the grpc_http1_reverse_bridge filter, one will encounter HTTP services that return 201 instead of 200 when the request resulted in creating a new resource.
Previously, these 201 return codes will turn into gRPC status UNKNOWN, crashing gRPC clients.
This commit updates the filter to also translate the 201 code into a gRPC OK status.

I made this PR because I encountered a 201 in the wild breaking this filter.
However, I'm also interested in people's opinions on including the other common HTTP success codes: 202 and especially 204.

I think it's hard to say what the correct behavior is here. I think you could argue that in some cases any one of 201-204 might be something to be considered success. Perhaps this should be a configuration option that allows operators to control whether what response codes are deemed success, and default to the current behavior of 200 only?

I think it's hard to say what the correct behavior is here. I think you could argue that in some cases any one of 201-204 might be something to be considered success. Perhaps this should be a configuration option that allows operators to control whether what response codes are deemed success, and default to the current behavior of 200 only?

I am not sure who owns this decision for the Envoy project, but I'm not sure if we could find an example where HTTP 201, 202, or 204 should be considered a semantic failure.

| I'm not sure if we could find an example where HTTP 201, 202, or 204 should be considered a semantic failure.
Even 200 should convert to a failure (of type unknown) unless there's a grpc-status header that indicates success (see https://github.com/grpc/grpc/blob/master/doc/http-grpc-status-mapping.md). We violate that because it's so common for http1 apps not to produce the grpc-status header when handling application/grpc requests. Given that, I suppose it's ok to accept other 2xx responses, it's just not clear to me that all operators would want this behavior. I think it'd be enough just to add a flag in the filter config that allows all 2xx to be considered success vs only 200 (which would remain the default).
In any event, I think we probably also need to modify the response's status code to be 200, since that's the only valid grpc response code.

I can do the conversion to 200 Status Code, but adding an extra filter option is not an entirely trivial change (in the sense that it requires locally building and testing which is very slow on my hardware), so I am going to punt until I have more bandwidth, likely mid-June.
Closing this PR for now, although if others want to make this change instead in the meantime, I have no objections. :)


[DatabaseGenerated(DatabaseGeneratedOption.Computed)] Workaround?

1. Description
Is there any way to get around the
[DatabaseGenerated(DatabaseGeneratedOption.Computed)]
attribute? The underlying property is maintained via a DB trigger.  I realize that implementing a trigger might be too much  work, but what I am looking for: is there a way I can get around this and update the underlying data myself?  I can override the Dbcontext SaveChanges and implement my own trigger there in c#, but I cannot figure out how to updated the in-memory DB values manually.

Hmm thats an actually decent work around.. Awesome thanks for this!

I would similarly like to be able to write C# code to define behaviour of a generated column when using Effort. Is there any workaround for this which can be applied to database-first EF programs?

He posted the answer above. Its works Great

you can add a c# trigger by overriding the savechanges and using changetracker

The answer posted above is for a code-first application. OnModelCreating is never called in a database-first application so you cannot disable the DatabaseGeneratedOption that way.

id say give it a shot. it works for me

I crreated a new TestFakeClass that derives from my Production context. Then override the OnModelCreating to add the code to remove the HasDatabaseGeneratedOption(DatabaseGeneratedOption.None)
Then if you need those columns to be computed like the database does via triggers, you just override the savechanges and use ChangeTracker to find the things that are changing and update the columns appropriately.  It works really well and im very happy with the above answer for all of my Integration tests.

You can make a fully in-memory context that behaves exactly like a real Database.

Overriding OnModelCreating is pointless in a database-first application because OnModelCreating is never called. If it works for you great, but I can't see any way that would work unless you are using a code-first approach.
I am asking for a different workaround because the one already presented does not work for me with my database-first application. So respectfully, if you do not have anything new to add to the conversion, please just leave it at that and let someone else answer.


Update login endpoint to r0.4.0

https://matrix.org/docs/spec/client_server/r0.4.0.html#post-matrix-client-r0-login

I don't think I will get back to this PR any time soon. I've realized that updating ruma to the latest matrix spec is way too much work for me and there's basically nobody else working on it at the moment. But as a note to my future self if I do get back to it eventually, or anybody wanting to finish my work here, I've just discovered that serde has a dedicated serde_test crate that should probably be used for the tests in place of serde_json.


Libnd4j: Make div forward op allowed datatypes match div_bp

Currently div allows mixed datatypes, e.g. float / long -> float.  However, div_bp does not, which can cause unexpected errors.  They should match.

@agibsonccc  it seems that the case is done intentionally.
first of all,  while making one of the divide arguments to be fixed point I get that it should be a floating variable to be trainable.
if  I make it as a constant. this time its gradient output expects the same type ( in that case long).
Besides making it flexible as the way op wants I should consider all operations inside and decide valid propagation as well.
so for now I'll put it on hold till I get clarification.
And I believe besides divBpOp the same case applies to SubOp and SubBpOp and probably others too


remove gap between indent lines #28

Hi @chingucoding,
as per your invitation for PR, I've added below code to fix issue #28
It worked like charm.

Best Regards

Thank you for creating this PR!


Missing Ionicons outline pack

Guys, the package @styled-icons/ionicons-outline isn't available on npm registry.
Could you add it? Thanks!

Hey, yes this is expected, we've encountered an issue where the SVG optimizer breaks the Ionicons icons - this is waiting on #1190 to be completed, after that it'll be published.

Does this concern the other packages from ionicons? I am unable to find anylooking a the npm registry.

Same here. Unable to import any of the ionicons.
Anything blocking #1190 that I might be able to help with?

Seems like it's affecting all the ionicons indeed. Been trying to add the sharp package with little success

Okay, I have some free cycles today, let me see if I can fix the color issue (ionicons-outline failed to publish as the icon colors got mangled by an SVG optimizer).

@jacobwgillespie I can review quickly if you get around to it. If not, I was going to try to take a look today or tomorrow.

@stramel Yep, exactly that (see https://github.com/svg-icons/svg-icons/pull/8) - I've switched back to the svgo-based optimizer, removing the Rust fork of svgcleaner, as while Rust is super cool, the JS is much more maintainable given the (lack of) available time I have at the moment. 🙂
There's now a CURRENT_COLOR environment variable that can strip out colors conditionally - ionicons hard-codes the icon colors to #000, so for those packs specifically, we set the env var.

This has been published as v10.3.0 - thank you all for your patience! 🎉 Let me know if you run into any issues.

@jacobwgillespie Can confirm ionicons working again in v10.3.0. Thanks a lot!

Wow, this was quick. Great job @jacobwgillespie!


forced minimum window width breaks common use cases

Expected behavior: shrink window to fit half-screen or portrait aspect ratio secondary monitor
Actual behavior: arbitrary minimum width prevents this, application overflows onto primary monitor and out of valid display area causing GPU crash
This app has a responsive GUI making this un-necessary, remove the artificial width limit restriction and let me decide whether I want to accept the reduced viewing area or not instead of making that decision for me and breaking my workflow.

I've noticed that not all elements work correctly in windowed mode.  For example on the Items tab, if you reduce the vertical direction too much, the box for "pre-crafted" rare items simply disappears.  There's no way to get it back and it remains hidden even if you scroll bar down.  I'm guessing there is some core functionality on one of the pages that simply breaks.


branding: add ability to customize sidebar logo

Description
under app-config now you can set fullLogoSize to change width of the logo
Which issue(s) does this PR fix

Fixes #1203

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[x] Unit Tests are updated and passing
[x] E2E Tests are updated and passing
[x] Documentation is updated if necessary (requirement for new features)
[x] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer
Set the below in your config to change width of the logo
app:
  branding:
    fullLogoSize: ${FULL_LOGO_SIZE}

/retest

/lgtm


Add support for creating empty reviews

Hello world,
Our company needs to be able to create a review from Jira, but due to security reasons we cannot get FishEye connected. I've updated this plugin to allow users to create empty Code Collaborator reviews from Jira without having FishEye changesets attached to the issue.
Best,
~Chris

Hi Chris; thank you!  The fellow that's the primary author on this is out on vacation until Monday.  I'll ask him to take a look when he gets back.

Great, thanks! =]

Hey @volkadav , Just wondering if the primary author has been able to take a look at this yet. Happy to work with you all to address any concerns with this update!
Best,
~Chris

Hey @ploko, I updated the IssueRest.java file per your concerns. Let me know how it looks when you get a chance!

Hi @creyes17  Your changes looks good. I created internal issue for our QAs to test these changes on real environment. So as soon as they approve that nothing is broken - I will merge this pull request.
Thanks a lot for you efforts.
Good job!

Was tested in COLLAB-1979


[Feature]: Support for pytorch for ROCm 6.1 release.

Suggestion Description
Currently the torch stable support is at ROCm 5.7 and nightly support is untill 6.0. The official ROCm pytorch image supports upto ROCm 6.0.2.
When can we expect a docker image release with torch on ROCm 6.1? Is there is any plan to provide ROCm 6.1 stable support on torch?
Operating System
Ubuntu
GPU
MI300X
ROCm Component
ROCm

@kannan-scalers-ai,
•	When can we expect a docker image release with torch on ROCm 6.1 ?
o	Rocm/pytorch docker images will be showing up in a few days as QA is currently testing them. Generally speaking, the rocm/pytorch docker images show up a few days after GA for any ROCm release.
•	Is there any plan to provide ROCm 6.1 stable support on torch ?
o	We are currently working on getting PyTorch nightly wheels upgraded to ROCm6.1. PyTorch2.4 will be the earliest version where will have stable wheels with ROCm6.1 or later.

@nartmada Thanks for your updates on the release timeline.


Docker nancy - no route to host

I have a docker container which hosts a web api written in Nancy. Here is the exception that occurs after a web request is made when the container is first fired up:
    4/22/2016 2:40:50 PM  at API.SearchModule+<SearchModule>c__AnonStorey0.<>m__0 (System.Object _) <0x41380aa0 + 0x00850> in <filename unknown>:0
    4/22/2016 2:40:50 PM  at (wrapper dynamic-method) System.Object:CallSite.Target (System.Runtime.CompilerServices.Closure,System.Runtime.CompilerServices.CallSite,System.Func`2<object, object>,object)
    4/22/2016 2:40:50 PM  at Nancy.Routing.Route+<>c__DisplayClass4.<Wrap>b__3 (System.Object parameters, CancellationToken context) <0x4133d350 + 0x00166> in <filename unknown>:0
    4/22/2016 2:40:50 PM2016-04-22 13:40:50,177 ERROR: System.Net.WebException: Error: ConnectFailure (No route to host) ---> System.Net.Sockets.SocketException: No route to host
    4/22/2016 2:40:50 PM  at System.Net.Sockets.Socket.Connect (System.Net.EndPoint remoteEP) <0x41374320 + 0x001b8> in <filename unknown>:0
    4/22/2016 2:40:50 PM  at System.Net.WebConnection.Connect (System.Net.HttpWebRequest request) <0x41372b50 + 0x00609> in <filename unknown>:0

The app queries elasticsearch when a web request is made, initially I thought it was blowing up because it couldn't find elastic (another docker container), however this doesn't seem to be the case as locally if I stop elastic the api will continue serving requests albeit it will throw exceptions. Once elastic is back online, the api continues to serve requests this time without exceptions.
The bizarre thing is if the docker container is restarted again the web requests against the api are successful at querying elastic.
Is there anyway I can replicate this issue locally so I can attempt to work on a fix? I had thought that if I run it locally with elastic offline I would get the same error, however this doesn't seem to be the case which makes me think it's some sort of network connectivity issue.
What do you guys think it could be?

Networking is moving at fast pace. Please, feel free to open a new issue if this is still a problem and fill the template with requested info.


Interpolation near coast

Yhanks @angus-g for your corrections. I'll make the 3D function as soon as possible.

Thanks for writing these C-functions, @pierrick-giffard
I've now incorporated them into parcels. They can be set with interp_method=linear_invdist_land_tracer. I've also made a very rudimentary unit test to check if the method works as expected. Things to do now

[ ] Develop a better/more sensitive unit test
[ ] Add warnings/errors when interp_method=linear_invdist_land_tracer is used on velocities (?)
[ ] Add documentation (both in docstring and perhaps in notebook tutorial)
[ ] Implement SciPy equivalent to interpolation method (?)

looks conceptually similar to the Natural Neighbour Interpolation

the square-root on the distance being computed 4*N per run is a bit expensive

Is the square-root needed? Couldn't we get away with working with the squared distance?

One note about the square root. I realized that my figure done here https://github.com/OceanParcels/parcels/issues/803#issuecomment-617260630 was computed without the square root (it means working with squared distance). I just tried with and without square root. The results are pretty close, and working with the squared distance seemed slightly better. In MITAS and MITASOVA 1998 it is written inverse distance weighting is typically used with square distance. Though, I propose to remove the square root.


[REVIEW] buymeacoffee.js

Project link
https://buymeacoffee.js.org/
Repo: https://github.com/warengonzaga/buymeacoffee.js

@WarenGonzaga Eddie usually likes to check out the repo of the project too on his streams, please inculde that in your description.

@WarenGonzaga Eddie usually likes to check out the repo of the project too on his streams, please inculde that in your description.

Done!

Thanks!
On Mon, 21 Feb 2022, 4:07 am Waren Gonzaga, @.***>
wrote:

@WarenGonzaga https://github.com/WarenGonzaga Eddie usually likes to
check out the repo of the project too on his streams, please inculde that
in your description.
Done!
—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/support/issues/3563#issuecomment-1046336126,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTL4AZ4BPJIVXRACLHDU4FUJ7ANCNFSM5OR2JRZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


[Infrastructure] Store golden test failures as workflow artifacts (Resolves #1658)

[Infrastructure] Store golden test failures as workflow artifacts. Resolves #1658
Currently, if a golden test fails only on CI, we have no way to inspect the failure because we cannot access the generated images.
This PR adds a step to the test_goldens_super_editor and test_super_editor_markdown jobs to store the failures as as artifacts in the test workflow.
If a golden test fails, a golden-failures.zip will be generated containing all images that are inside all "failures" directories.
It's possible to configure a retention period. If not set, it uses the retention limit set by the repository, organization, or enterprise

@matthew-carroll The workflow run for this PR already uploaded the golden failures. The file is displayed in the test summary.


Ubuntu 18.04 LTS install fails when deps are installed with snap.

When you install ubuntu you are asked as part of the installer if you choose to install docker. When doing so, it installs via snap.
root@atomicpi:~# snap list
Name        Version     Rev   Tracking  Publisher              Notes
core        16-2.37.1   6350  stable    canonical✓             core
docker      18.06.1-ce  381   stable    canonical✓             -
jq          1.5+dfsg-1  6     stable    canonical✓             -

Please note I also installed jq via snap and all the other reps via apt-get.
[Warning] No NetworkManager support on host.
[Warning] Create DNS settings for Docker to avoid systemd bug!
[Info] Restart Docker and wait 30 seconds
Failed to restart docker.service: Unit docker.service not found.
[Info] Install supervisor Docker container
[Info] Install supervisor startup scripts
Created symlink /etc/systemd/system/multi-user.target.wants/hassio-supervisor.service → /etc/systemd/system/hassio-supervisor.service.
[Info] Install AppArmor scripts
Created symlink /etc/systemd/system/multi-user.target.wants/hassio-apparmor.service → /etc/systemd/system/hassio-apparmor.service.
Job for hassio-apparmor.service failed because the control process exited with error code.
See "systemctl status hassio-apparmor.service" and "journalctl -xe" for details.```

root@atomicpi:~# curl -sL "https://raw.githubusercontent.com/home-assistant/hassio-installer/master/hassio_install.sh" | bash -s
[Info] Install supervisor Docker container
[Info] Install supervisor startup scripts
[Info] Install AppArmor scripts
[Info] Run Hass.io
Failed to start hassio-supervisor.service: Unit docker.service not found.

It seems that if any deps are installed via snap then Hassio fails to start.

docker.service is not available...

I run into this same problem.  I think the installer needs some special handling for specifically adjusting when using a snap.
The service when installed as a snap is snap.docker.dockerd.service.
So I make some adjustments to the systemd units:
Supervisor
[Unit]
Description=Hass.io supervisor
Requires=snap.docker.dockerd.service
After=snap.docker.dockerd.service dbus.socket

[Service]
Type=simple
Restart=always
RestartSec=5s
ExecStartPre=-/snap/bin/docker stop hassio_supervisor
ExecStart=/usr/sbin/hassio-supervisor
ExecStop=-/snap/bin/docker stop hassio_supervisor

[Install]
WantedBy=multi-user.target

Apparmor
[Unit]
Description=Hass.io AppArmor
Wants=hassio-supervisor.service
Before=snap.docker.dockerd.service hassio-supervisor.service

[Service]
Type=oneshot
RemainAfterExit=true
ExecStart=/usr/sbin/hassio-apparmor

[Install]
WantedBy=multi-user.target

That leads to:
hassio-supervisor[22553]: /usr/sbin/hassio-supervisor: 20: /usr/sbin/hassio-supervisor: docker: not found

So I adjusted /usr/sbin/hassio-supervisor to refer to /snap/bin/docker since /snap/bin isn't in $PATH for that script.
That then leads to this failure:
docker[24665]: hassio_supervisor
systemd[1]: Started Hass.io supervisor.
hassio-supervisor[24702]: time="2019-05-18T02:40:08Z" level=error msg="error waiting for container: context canceled"
hassio-supervisor[24702]: Error response from daemon: error while creating mount source path '/usr/share/hassio': mkdir /usr/share/hassio: read-only file system
hassio-supervisor[24702]: hassio_supervisor
hassio-supervisor[24702]: docker: Error response from daemon: error while creating mount source path '/usr/share/hassio': mkdir /usr/share/hassio: read-only file sysytem
hassio-supervisor[24702]: time="2019-05-18T02:40:09Z" level=error msg="error waiting for container: context canceled"

Don't really have a solution for that though.

I ended up putting the hassio data in /root/snap (which the snap does have access to) and got past that, so I have a fully working setup now.

@niemyjski you can try my branch that I referenced in the PR to set it up if you haven't already.

I can the next time I format. I have it all up and running in prod. The changes look good tho


Taking ownership of memmove.S

This pull is incomplete. Do not merge.
I'm beginning development on memmove.S.

Ready to merge, all test pass!

@Achierius OK to merge!


Locking fixes

expire locks
pass lockid from the InitiateUploadRequest via metadata to the FinishUpload, so that we don't need to provide that info the the datagateway
enable lock modification for app based locks independently of the user
implement locking for public storage provider

LGTM +1 But lock tests are red...

I fixed them in https://github.com/cs3org/reva/pull/2625/commits/520f58b4f53dde011c5b25331ee6a5133cb87865


Conflict with Voyager

Expected Behavior
Acutal Behavior
It's conflict with voyager 1.2.6.
Can't be load admin dashboard.
Environment

PHP Version: 7.2
Laravel Version: 5.8
LaravelCaffeine Version: 0.8.1

Stack Trace

Hi @meesudzu, thanks for reporting this. I don't use Voyager, so if you could provide a PR that fixes this issue, that would be great.

Same issue here. I had to remove laravel-caffeine to use Voyager. I do not know why it is conflicting.

Hi @meesudzu, @mikebronner and anyone who is experiencing this issue. I was able to find a workaround to void the conflict.
Workaround: Configure the laravel-caffiene to use middleware 'use-route-middleware' => true, and only apply that middleware to your main site. There are many ways to do that with a group route. Avoid having laravel-caffiene while voyager is active. You can use php artisan caffeine:publish --config to publish the config file.
This does not address the problem but allows me to utilize both when needed.

Updated readme with conflict warning, and mention of work-around.


add extra terms for various dictionaries

Extra terms for html, miscTerms and npm dictionaries

Coverage remained the same at 97.944% when pulling 1200c67f5de950b92242dd837c31e511edc03d2c on DenisVuyka:extra-terms into 0f4acf49738648d03e9ce72be52d16da78785e23 on Jason3S:master.

Thank you.


Fix underflow in subtract_steps

This change is

We're currently processing your upload.  This comment will be updated when the results are available.


[HUDI-2803]Remove the aws packages from hudi flink bundle jar

What is the purpose of the pull request
Remove the aws packages from hudi flink bundle jar
Brief change log

Remove the aws packages from hudi flink bundle jar

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.

@danny0405 cc


Add sub title for DML and DDL doc on our website

We have many parts in DML and DDL doc, but without a sub title, it's difficult for users to find a specific part. If you say "we can use the search function", but if we don't know the function name exactly, it's still difficult to use.

We can learn from Cassandra doc:

And the effect I expect is that the subtitle will not be displayed at the beginning, it will show when you click the main title.

And the effect I expect is that the subtitle will not be displayed at the beginning, it will show when you click the main title.


ModuleNotFoundError: No module named 'MyPackage.tools.debug_log'

I cannot find it,thanks.

thanks for your question，delete this import statement and any other code about 'debug_log' will be ok, we just fixed it.


🎉 Add fonts

We need to offer more fonts.
These fonts are all free to use for non-commercial projects.
Added 5 readable fonts plus 2 ideograms (Canthan, Ascalonian)
Fixed New Krytan

The 5 free fonts added are a close match to commercial fonts that ArenaNet uses.

Matching fonts
Elizabeth (+italic support) and Stowe Open Face which match the font in this picture.
PTSerif (+italic support) and Cagliostro which match the Guild Wars 2 main font. (See forum thread)
Other fonts
Stowe Titling (+italic support. Same as Stowe Open Face but non-hull letters.)
Canthan Ideogram
Ascalonian
GWTwo Font Version 1.1 (known fan-made title font)
New Krytan Version 1.4 (See https://www.properdave.com/gw2/)

Removed the old bad new krytan fnt conversion from the Content pipeline. It wasn't hooked up with the FontFace enum anyway.

These fonts are pre-compiled and included in the project as "Content" with "Copy If New" set since this works way better and faster than to try and get fonts into the fnt format for MonoGame to process them with BMFont (Remember; I tried converting New Krytan before and it was not only tidious and complex but I only got loosely results.). It's also the method for ttfs described in MonoGame docs.
I added a small extension method to make use of an "Description" tag on enums because some font names included a dot and I thought I had to name the file names according to the reference to the installed fonts (for compilation) which I realized is not the case. I was able to rename the compiled versions. I kept the method because I think it might come in handy later (displaying friendly names for example).
I had to edit a little bit of code under the ContentService to fallback to Regular if the specified style is not available for a certain font. We are able to offer every size but not every font has every style.
I would appreciate it very much if this set could be the exception in stuff that core doesn't directly use but offers to modules.

Updated post to show italic support.

#423 we will track the plans/progress for the new font handling system.  Once implemented, modules will be able to use any combination of fonts that they wish to use instead of us integrating them into core.


Large database optimisation solution

I've done quite a bit of googling recently on this as, at only 20MB it is becoming really slow, especially when using Jaccard similarity.
My proposed solution is to use something like the MinHash algorithm as a replacement. It is ten times faster when comparing strings of documents, so I think it will be a great addition or replacement for the Jaccard similarity code - as it basically does the same thing.

Hi @talentoscope, I'd be happy to accept contributions for the MinHash algorithm. In the mean time, I'd recommend Levenshtein distance for faster comparisons than Jaccard similarity (https://chatterbot.readthedocs.io/en/stable/comparisons.html#chatterbot.comparisons.LevenshteinDistance).
ChatterBot's performance with large sets of data is an issue that I am well aware of. I think it's worth mentioning that the major bottleneck in speed at the moment is not the speed of the comparisons, but the fact that ChatterBot currently needs to compare every statement in the database in order to search for a match to the input for every response it generates. This is a problem that I am working to address in the 1.0 release.

Something similar to lemmatization is being added in 1.0 (using partial matches to reduce the size of the search set). The current reason that all statements are compared is because of the need to do the text comparison for searching. Most similar statements are not exact matches and so inefficient query cannot be created for a database and therefore iterative comparisons are required.

Have you been looking into searching in the sqlite by adding the extension spellfix1? Im not sure how or if it fits into this context but it looks like they support some distance-functions and have ranking of words/text etc.
Not that it will fix the issue for mongodb users though..

two low ，just use as an toy。。。

@gunthercox @alentoscope, have you ever think about a clustering algorithm to reduce the number of comparisons?
For example if we have 100,000 dialogue (sentence pair) in db, then for each new query in the current version we need 100,000 comparison (distance evaluation), but if we first perform an offline clustering  and have 1000 cluster for example with about 100 dialogue in each cluster, then we need only (approximately) 1000+100=1100 comparisons! 1000 comparisons with clusters median and 100 comparison with each member of the best cluster.

Bk-trees could be used to pre-calculate the Levenshtein (or any metric) distance.


What is the plan for adding more Providers

Is your feature request related to a problem? Please describe.
PingId provider support
Describe the solution you'd like
You can add more Identity Providers, as @authhs has.
Describe alternatives you've considered
I am using @authjs in my current setup. I want to explore more libraries as: better-auth

We only plan to add commonly used providers that can genuinely be considered "social" providers. For other OAuth providers, you'll need to use our generic OAuth plugin and pass your own configuration. In the future, we may provide a list of configurations, but we don't aim to maintain an exhaustive list of providers like Auth.js and other libraries. Said that, If you have a specific provider request that you think we should support by default, feel free to open another issue :)


npm install issues, project unusable in 2022.

🚨 Build failed.
@parcel/package-manager: Could not find module "@parcel/transformer-sass" satisfying 2.6.2.
/Users/perfecto/Desktop/simplefolio/package.json:23:5
22 |   "devDependencies": {

23 |     "@parcel/transformer-sass": "^2.0.1",
|     ^^^^^^^^^^^^^^^^^^^^^^^^^^ Found this conflicting local requirement.
24 |     "parcel": "^2.0.1",
25 |     "prettier": "^2.4.1"

The following worked for me:

Run 'npm audit fix'
Run 'npm i @parcel/transformer-sass'

Don't forget to do cd insite the simplefolio or else it won't work 😂

The following worked for me:

Run 'npm audit fix'
Run 'npm i @parcel/transformer-sass'

This worked for me. Thank you very much!!

The following worked for me:

Run 'npm audit fix'
Run 'npm i @parcel/transformer-sass'

Work for me! thank uuuu

Run 'npm audit fix'
Run 'npm i @parcel/transformer-sass'

Fixed up, Thanks


feat: implement the net/http.Handler interface for Handler

Add a new ServeMux and a ServeHTTP method, making it easier to embed the api in other servers.
Example:
// gin
router.Any("/cast/*any", gin.WrapH(http.StripPrefix("/cast", casthttp.NewHandler(false))))

Thanks!


I hope the method with the same name can be executed multiple times

TestNG Version

Note: only the latest version is supported

Expected behavior
I have a requirement to use the < include > method to execute the same method with different parameters. However, the same method is found to be executed only once.how can i do?
xml code
<suite name="Suite">
    <parameter name="way" value="1"></parameter>
    <test verbose="2" preserve-order="true" name="webAddSalesCostContractActualProductGoodsCase200">
        <classes>
            <class name="com.zhoupu.quality.test.Test">
                <methods>
                    <include name="fun">
                        <parameter name="case" value="{case json1}"></parameter>
                    </include>
                    <include name="fun">
                        <parameter name="case" value="{case json2}"></parameter>
                    </include>
                </methods>
            </class>
        </classes>
    </test>
</suite>

Actual behavior
fun method can be  executed  twice
Is the issue reproductible on runner?

[ ] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse
[*] IntelliJ
[ ] NetBeans

Test case sample

Please, share the test case (as small as possible) which shows the issue

Could you please provide a simple code for how to reproduce this issue.

@linavaos - This is currently not possible in the way in which you are doing.
The reason being TestNG retrieves the methods from a class using reflection (and so there's no way that the same method is going to be retrieved multiple times because Java mandates that a method has to be unique in a class) and then runs the retrieved methods as a comparison against the ones that you specified via the <include> tag to check which one to execute and which one to skip. I think you should just use a data driven approach for this.

Closing this off with resolution as Question Answered


83: Account for no sample id

Fixes #83
To test:

Confirm new unit tests pass

I'm not sure why GDA uses a sample id of 0 for no sample (and why it doesn't run into the same error when trying to store it). But if we're going to store a null value for the sampleid I'd prefer to pass a null value to artemis in the JSON rather than adding conditionals to our ispyb methods.

Hmm... You're right, I should have thought a bit more about this. I think you're right that a Noneis better, we should also accept no sample_id being specified in the JSON

See also https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/35058/5..6

I've left the unit tests in as they're still valid, also allowed the interface to not have the sample info specified as I think that's cleaner.
Added the barcode more explicitly at https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/35058/6..7/configurations/mx-config/scripts/gridscan/artemis_grid_scan.py


Spellchecker perturbation

This transformation helps add noise to a sentence by replacing words using a specified
probability with suggestions generated by a spell-checker.
PyEnchant library is used to generate suggestions for the selected word and a random
word from the top-5 suggestions is picked as a replacement for perturbation.
This can make the model adapt to noise via replaced noisy words.

Hi @gurunath-p, would you like to complete this pending PR?

Hi @kaustubhdhole @Saad-Mahamood @tuetschek
Apologies for my late reply.
I will check the requested changes and make it ready this weekend. Regarding the tests, because of randomness, the outputs don't always seem to match the input. Will check how to do this better.

I am closing this now since there haven't been changes since a while and the library pyenchant is not MIT/Apache License. Please feel free to repoen it later when you make changes before September 1.


Interpolate sigma for the near wake

I went ahead and interpolated sigma for the near wake.

The math looks good and the tests pass, but it would be good if you could add a test to make sure the new interpolation is done right. Also, I'd prefer to have an option of some kind so that the pervious approach to the near wake interpolation could still be used. Your updated way should be default.

Okay, let me know if I didn't follow good testing protocol, otherwise I am pretty confident in the interpolation.

This looks better. There are still a couple of things that need to be fixed:

dx_interp has been dropped in favor of xd, but this is confusing. xd is the point of discontinuity and dx_interp is our artificial x point just for interpolation. Rather than clobber xd, assign a new variable. There should not be any allocation cost because these are scalar values.
The bound has been adjusted so that there will be a discontinuity at x0 in the current code when interpolation is false. The spread will jump at x0 from the x0 real spread to the xd spread. Compare your current code to commit d0d9ce66a996c30029b8ba7687b3d3475f178573 .
The test data needs to be cited or explained in the comments in some way so that we know where the numbers came from and that they were not just the values you got out after writing the code. We need to be testing against theory or data.

This looks good, but tests are failing now. Once the tests are passing we should be good to merge.


After install plugin

I install plugin by command line
php artisan plugin:install bedard.debugbar

And i got the following error

PHP Fatal error:  Class Illuminate\Cache\FileStore contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Illuminate\Contracts\Cache\Store::many, Illuminate\Contracts\Cache\Store::putMany) in /Users/HFY/www/october/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php on line 250
PHP Fatal error:  Cannot instantiate abstract class Illuminate\Cache\FileStore in /Users/HFY/www/october/vendor/laravel/framework/src/Illuminate/Cache/CacheManager.php on line 151

After i delete vendor of plugin directory, it works , so i hope it can be installed by composer

Solved by #17


HSEARCH-682 DSL cannot handle fieldBridge for @IndexEmbedded fields

Hi, I've adapted the test attached to the JIRA (https://hibernate.onjira.com/browse/HSEARCH-682).
I think there were some mistakes.
Let me know if I missed something.
Cheers

Padded class replaced.

This was merged some days ago, forgot to close it.


svg with fragment not support

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
https://codesandbox.io/p/devbox/new-night-8nwzdf
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
dont know
Describe the Bug
Module not found: Can't resolve './fonts/slick.svg#slick'

Expected Behavior
currect load svg
To Reproduce
https://codesandbox.io/p/devbox/new-night-8nwzdf
the docs label
Additional context
update package.json then is work
	"scripts": {
		-- "dev": "next dev --turbo",
		++ "dev": "next dev",
	}

or update node_modules/slick-carousel/slick/slick-theme.css
-- url('./fonts/slick.svg#slick')
++ url('./fonts/slick.svg')

so it is mean turbo not support *.svg#fragment?
No response

Related to https://github.com/vercel/next.js, not turbo

Related to https://github.com/vercel/next.js, not turbo
@Netail
hi,
update package.json then is work

	"scripts": {
		--   "dev": "next dev --turbo",
		++ "dev": "next dev",
	}

or update node_modules/slick-carousel/slick/slick-theme.css
--   url('./fonts/slick.svg#slick')
++ url('./fonts/slick.svg')

so it is mean turbo not support *.svg#fragment?

Related to https://github.com/vercel/next.js, not turbo
@Netail
hi,
update package.json then is work

	"scripts": {
		-- "dev": "next dev --turbo",
		++ "dev": "next dev",
	}

or update node_modules/slick-carousel/slick/slick-theme.css
-- url('./fonts/slick.svg#slick')
++ url('./fonts/slick.svg')

so it is mean turbo not support *.svg#fragment?
can you forward to nextjs? if is nextjs problem?

I mean, Turbopack has moved to the next.js repo. This repository is only turborepo now

@Netail
hi,
https://github.com/vercel/next.js
report bug to this repo?
ok, i got it.


SEEPS

We should add SEEPS to scores https://doi.org/10.1002/qj.656
It's a WMO metric and used in several ML papers to evaluate precipitation forecasts.

Hi Nicholas,
SEEPS has been implemented in weatherbench2. I will just link it here, and maybe their scripts can help.
https://github.com/google-research/weatherbench2/blob/75fb2b94cf00bae4c632948d1addfcc86cacc300/scripts/compute_climatology.py#L147
https://github.com/google-research/weatherbench2/blob/75fb2b94cf00bae4c632948d1addfcc86cacc300/weatherbench2/metrics.py#L418
It has two parts: (1) Calculate quantile-based thresholds; and (2) Compute SEEPS on each grid.

Thanks @yingkaisha! I've already created some prototype code. I'll compare my version to see if it gives the same results as the WeatherBench2 implementation.
I was actually thinking of using WeatherBench2 data for the tutorial for this as it has the ERA5 SEEPS thresholds.


libgc on Android

Adds a script to fetch, configure and compile libgc to be deployed on Android. This script will have to be tweaked and improved, but this version works.
You (and Jenkins) will need to execute the script once before compiling any Android programs.
I still have to look at the possibility to release memory on explicit OS calls to do so. it will be for a future PR.

+1

I'va added a check to make sure the setup script has been executed. It will show cleaner errors.

+1. est-ce que la consommation mémoire est maintenant raisonnable?

Oui, mineit ne crash plus après 5 minutes. En fait, il ne crash plus par manque de mémoire.

Rerolled so that nitc launches the script by itself.

The build toolchain of libgc really doesn't like spaces in the absolute path, so my script doesn't work in Jenkins workspaces.
@privat Do you want to take a look? Or would you mind if we rename "CI github" to "CI_github"?
I could also build in /tmp or something similar.

Pas de pb pour renommer CI github. ptet attendre que jenkins ait fini ses tests par contre.

+1


GetThreadID memory access violation for e9_hook

Sorry if this isn't enough information, threading is not my strong suit. Please let me know.
I'll occasionally get access violation errors when using a midhook for an x64 program. This is happening when the threads are resumed.
 	ntdll.dll!NtQueryInformationThread()	Unknown
 	KernelBase.dll!GetThreadId()	Unknown
	BF2VR.dll!safetyhook::execute_while_frozen(const std::function<void __cdecl(void)> & run_fn, const std::function<void __cdecl(unsigned int,void *,_CONTEXT &)> & visit_fn) Line 139	C++
 	BF2VR.dll!safetyhook::InlineHook::e9_hook(const std::shared_ptr<safetyhook::Allocator> & allocator) Line 323	C++
 	BF2VR.dll!safetyhook::InlineHook::setup(const std::shared_ptr<safetyhook::Allocator> & allocator, unsigned char * target, unsigned char * destination) Line 191	C++
 	BF2VR.dll!safetyhook::InlineHook::create(const std::shared_ptr<safetyhook::Allocator> & allocator, void * target, void * destination) Line 147	C++
 	BF2VR.dll!safetyhook::InlineHook::create<unsigned char *,unsigned char *>(const std::shared_ptr<safetyhook::Allocator> & allocator, unsigned char * target, unsigned char * destination) Line 108	C++
 	BF2VR.dll!safetyhook::MidHook::setup(const std::shared_ptr<safetyhook::Allocator> & allocator, unsigned char * target, void(*)(safetyhook::Context64 &) destination) Line 110	C++
 	BF2VR.dll!safetyhook::MidHook::create(const std::shared_ptr<safetyhook::Allocator> & allocator, void * target, void(*)(safetyhook::Context64 &) destination) Line 56	C++
 	BF2VR.dll!safetyhook::MidHook::create(void * target, void(*)(safetyhook::Context64 &) destination) Line 48	C++
 	BF2VR.dll!safetyhook::create_mid(void * target, void(*)(safetyhook::Context64 &) destination) Line 13	C++
 	BF2VR.dll!BF2VR::BF2Service::Initialize() Line 209	C++
 	BF2VR.dll!BF2VR::MainThread(HINSTANCE__ * hModule) Line 108	C++
 	kernel32.dll!BaseThreadInitThunk()	Unknown
 	ntdll.dll!RtlUserThreadStart()	Unknown

I read up on GetThreadId and from what I understand, it shouldn't be possible to crash the program. It's showing an access violation at 0x0.
Please let me know what I need to send to help with this. Thanks.

Try using this PR and see if your issue goes away https://github.com/cursey/safetyhook/pull/51
However that is still quite strange if GetThreadId is crashing, I haven't heard of this. Would need to look at a disassembled dump of the surrounding bytes in ntdll

The only thing I can think of off the top of my head is that something in the TEB or PEB may be invalid for a short time, but still will need the surrounding bytes of where it crashed

I will mention that I'm using PR #51 as well as your codecave scanner since I was getting a bunch of out of ranges.
Original

Hooked

Trampoline cave

Trampoline

This is the crash in ntdll

Here, sorry. Missed a bit before the ret

Well that was a fun 3 hours.
Turns out GetThreadId wasn't causing the crash, it just consistently happened after a previous ResumeThread call that caused the crash.
Looking at the freezer, I see const auto suspend_count = SuspendThread(thread);. There is a check if it is -1 (error) but it just continues. I ran GetLastError() and it is returning 5 which should mean access denied. I think this is barely handled and messes up the threads when resumed.
I'll check later but I need a break.

One thing I kind of had an issue with with the suspender was that it just goes through the entire thread list again with the same NtGetNextThread rather than keeping a list of previously suspended handles (or thread id's and using NtOpenThread) and just iterating over those. Because any thread could be destroyed or created in the process of iterating over existing ones.
Did you try out the trapping PR?


Fastlane session is expired every day when releasing an app to TestFlight via Azure DevOps

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

I am publishing my app to TestFlight via Azure DevOps. In order to do that you have to create a service connection.

My apple id account uses 2FA. I am generating a Fastlane session using this command
fastlane spaceauth -u [my_apple_id_email]

Unfortunately every new day I am receiving an error:
"Fastlane session is not available anymore. Continuing with normal login."
Any my release fails because it cannot bypass 2FA.

Docs says that the Fastlane session should be valid for one month but this is not true. From my observations, I think that the Fastlane session expires after one day, not after one month.
Why is this working like that? Is there any possibility to set the duration of Fastlane session. Because right now it is very annoying that I have log every day on Azure DevOps and update Fastlane session in service connection.

@fastlane-bot
I will do that later. Right now I don't have access to the machine where Fastlane is installed.
But it doesn't matter in this issue. This a problem with a session in the newest version of Fastlane.

There was some changes on the Apple's side of things few months ago. It seems like sessions are quite short now.
Your account uses 2FA by choice or because  it is Account Holder? Maybe you will be better creating another apple id with Developer role and add it to your team(s)? Developer will not be enforced to add 2FA. We took that road, works like a charm.

@Katsz
Ok, I will try adding this new account with "Developer" role.
My account has "App Manager role". I have enabled 2FA by choice.


Support HTTPS

This should hopefully resolve #178. It uses the example given in the
micro examples of with-https. It has some rough edges still that
needed to be sanded down:

Choosing a specific short flag name for ssl (and if the initial flag
should still be called ssl; I'm tempted to rename it to https or what
have you) - would like if someone chimed in about their design thoughts for this.

The example always acks with 200 and the example object - should just be a matter of passing off the handler as fn to microHttps.

It does not support compression and merely overwrites the previous
server var - should also be trivial, just compress the handler before handing it off to whichever server will take it.

I should be able to get to  last two bullet points without much delay; the first needs someone to chime in on design wise. :slightly_smiling_face:

Last commit should resolve the latter two bullet points; just need to know if we should change the flag name? (I'm going to vote 'yes'! Maybe https?)

Also just realized there should probably be:

a check for at least min of node v7.6 to support the async keyword unless it's unnecessary.
a way to pass the cert + key manually if one is inclined to do so.

Looks like http-serve has --ssl and -S for the flags they use, so it might be ok to keep it and introduce -S here for consistency.

wow, this looks awesome! I added a few tiny comments.

Thanks! I'll be sure to run npm to update thepackage-lock.json :smile:

Per lib/server.js conflicts, I think the global version of prettier I have installed may reintroducing that. I'll resolve here to circumvent it running.
Per package-lock.json I'll just resolve to what master has for now.

Should be good, and should also be using the appropriate non-master (npm install) package-lock.json. :+1:

Thank you so much! I'll make sure to update the snapshots and lockfiles to be really sure.

:nice: use of the micro example 👍

No worries, and thanks for writing that example, @albinekb! Make hacking up the diff a snap :ok_hand:

OSS FTW! 💯

This needs documentation in the README.

Does this feature has been disabled? The --ssl flag doesn't exists anymore, and neither nothing related to it in the --help flag.

Indeed need documentation! I don't know what to do

@justanotherdot What happened to your flag? The --ssl flag doesn't work anymore and there's only --ssl-cert and --ssl-key.

I am unsure I’m afraid. I was not responsible for the change removed the
flag. Looks like those new flags made their way in over at
https://github.com/vercel/serve/pull/520
On Thu, 13 Aug 2020 at 4:40 pm Nermin Skenderovic<EMAIL_ADDRESS>wrote:

@justanotherdot https://github.com/justanotherdot What happened to your
flag? The --ssl flag doesn't work anymore and there's only --ssl-cert and
--ssl-key.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vercel/serve/pull/274#issuecomment-673292948, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABI2FECNMQHOUTMKMPJAVGTSAODGLANCNFSM4D6TOCHA
.

@leo why was support for automatic HTTPS removed? As per #520 and #511 it is understandable that users might want to use manual certs and keys, but there is still, no even more, use cases for automatic SSL/HTTPS. One of the biggest reasons why serve is so popular is because it's a one-line command to literally "serve" your application. If a user wants or for some reason needs HTTPS they don't wanna have to go through a whole process of installing another tool just to get it.
Personally I stumbled upon serve when building my create-react-app and wanted to "serve" it. But because I use service workers and push notifications I need to serve it over HTTPS so I can test on other devices on the network. Sure I can get HTTPS for my self as per #520, but my co-workers can't, since they might not have their own manual certs and keys... you see the problem?
There is no reason why both manual and automatic HTTPS can't be supported.


Error    SA1636    The file header copyright text should match the copyright text from the settings.

I am facing below issue. Even I added the company name in the settings.
Error    SA1636    The file header copyright text should match the copyright text from the settings.
In my class file I added header like this
// <copyright file="RoleController.cs" company="Sandbox">
// Copyright (c) . All rights reserved.
// </copyright>

In my settings file
{
  "$schema": "https://raw.githubusercontent.com/DotNetAnalyzers/StyleCopAnalyzers/master/StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json",
  "settings": {
    "documentationRules": {
      "documentInterfaces": true,
      "documentInternalElements": false,
      "companyName": "Sandbox",
      "copyrightText": "Copyright (c) . All rights reserved.",
      "xmlHeader": true,
      "fileNamingConvention": "metadata"
    },
    "layoutRules": {
      "newlineAtEndOfFile": "require"
    },
    "orderingRules": {
      "systemUsingDirectivesFirst": "true",
      "usingDirectivesPlacement": "outsideNamespace"
    }
  }
}

What change does the code fix suggest be made?

Did you properly add the stylecop.json to the .csproj as follows?
  <ItemGroup>
    <AdditionalFiles Include="./stylecop.json" />
  </ItemGroup>


Update Dockerfile

Added:

Updated htslib and bcftools to 2.20 (tabix multithreading!)
Added ldstore v2

ldstore maybe a bit useless addition, what do you think?

I don't think it hurts to have  it there! go ahead


Org Settings

Delete users, accept requests,  change org name, accept cross-org channels, add or remove user admin priv, and delete channels

This has been divided up into 5 smaller issues.


View Add Title: Dialog variants?

Adding a title by hand can be done for a book, a database, a journal, a monograph and a series.
All of these different title types actual gets the same ui fields, but that can not be correct. So we need further specification what is needed in the type context,  see page 39.

journal and serial are just different names for the same type - JournalInstance, book and monogaph too: BookInstance, database points to a DatabaseInstance. They all are subclasses of TitleInstance. The UI fields you are referring to (Ausgaben, Bände) are actually properties of the TIPPCoverageStatement, not the TitleInstance itself.

The question is which input fields are relevant for what. We need different gui prototypes.

Further investigation into the old ui shows more input fields than the actual concepts offers. But it shows also the differences between the known title types. I have created a word document that shows the results and can be used to discuss this topic in detail.

Is there a way to add remarks and comments to that document? Maybe a DAV-link to edit it offsite?

Unfortunately, it's impossible to add comments to that document.

Simply download and edit.

Instead of typing around in a copy, I'd rather want to edit the real thing so you know can read and react to the comments, as this is key to a discussion, don't you think?

This is sciebo and I think you have no account, so we must/should share it via email or deploy it elsewhere. Try this
https://drive.google.com/file/d/141zfnaUogl8OYM1Y_59eFS83nezYBfUv/view?usp=sharing

Same problem: without an account, no editing.


Fixed: [Android] Error: Duplicate resources #22234

Fixed error "Duplicate resources" while building APK file in Android
"[drawable-.../...]/.../android/app/src/main/res/drawable-mdpi/FILE [drawable-.../...] /.../android/app/build/generated/res/react/release/drawable-mdpi-v4/FILE: Error: Duplicate resources"

Summary

Changelog

Android Fixed - Fixed error "Duplicate resources" while building APK file in Android
Test Plan

Added Changelog

I think that folder names are hard coded, which won't work for flavors and targets. Could you please make it work with flavor and target configurations.

Hey @Ovi, do you mind addressing @dulmandakh's comments?

I think that folder names are hard coded, which won't work for flavors and targets. Could you please make it work with flavor and target configurations.

As far I have seen in many places that only "drawable-..." folder makes the issue while creating build.
@dulmandakh please let me know if you face this issue with any other file/folder.

Thanks for this! I'm going to merge https://github.com/facebook/react-native/pull/24518 which is based on your PR.


Client management

Can you please add feature of adding profiles? Or it would be hard to implement in docker way?
There is an implementation in another repo, which works fine
https://github.com/GubernievS/AntiZapret-VPN/blob/main/setup/root/add-client.sh

We have plans to move openvpn to separate docker container with graphical interface. In same manner as wireguard/easy-wg container.  Something like https://github.com/d3vilh/openvpn-ui
Here is discussion: https://github.com/xtrime-ru/antizapret-vpn-docker/discussions/77

Understand, sounds nice, thx


Tesla.Mock.pdict_get/0 doesn't work inside of Broadway

Finding an issue with https://github.com/elixir-tesla/tesla/pull/668 as of 1.10.0 on our project. Something with running pdict_get/0 inside of a process that Broadway owns returns an atom for pid_holder:

leading to the following error:
[error] ** (ArgumentError) errors were found at the given arguments:

  * 1st argument: not a pid

    :erlang.process_info(:"Broadway1.Broadway.ProcessorSupervisor")
    (elixir 1.16.2) lib/process.ex:839: Process.info/1
    (tesla 1.10.0) lib/tesla/mock.ex:238: Tesla.Mock.pdict_get/0
    (tesla 1.10.0) lib/tesla/mock.ex:204: Tesla.Mock.call/2
    (tesla_mock 0.1.0) lib/consumer.ex:20: MyBroadway.handle_message/3
    (broadway 1.0.7) lib/broadway/topology/processor_stage.ex:159: anonymous fn/6 in Broadway.Topology.ProcessorStage.handle_messages/4
    (telemetry 1.2.1) /Users/cfb/code/playground/tesla_mock/deps/telemetry/src/telemetry.erl:321: :telemetry.span/3
    (broadway 1.0.7) lib/broadway/topology/processor_stage.ex:146: Broadway.Topology.ProcessorStage.handle_messages/4
    (broadway 1.0.7) lib/broadway/topology/processor_stage.ex:65: anonymous fn/2 in Broadway.Topology.ProcessorStage.handle_events/3
    (telemetry 1.2.1) /Users/cfb/code/playground/tesla_mock/deps/telemetry/src/telemetry.erl:321: :telemetry.span/3
    (gen_stage 1.2.1) lib/gen_stage.ex:2578: GenStage.consumer_dispatch/6
    (gen_stage 1.2.1) lib/gen_stage.ex:2767: GenStage.take_pc_events/3
    (stdlib 5.2.3) gen_server.erl:1095: :gen_server.try_handle_info/3
    (stdlib 5.2.3) gen_server.erl:1183: :gen_server.handle_msg/6
    (stdlib 5.2.3) proc_lib.erl:241: :proc_lib.init_p_do_apply/3

I have set up a minimal reproduction here, as I couldn't get it to reproduce in the unit tests in this library in my fork: https://github.com/cfbender/tesla_mock_example
Hope this helps! We will just pin to 1.9.0 for now

Could this be solved with https://github.com/elixir-tesla/tesla/pull/683

I related https://github.com/elixir-tesla/tesla/releases/tag/v1.10.1, which may fix the issue; please reopen if that didn't work, or much better, send a pull request; you have my support with it.

@yordis that should work, I was testing a similar fix on my fork locally. Thanks so much for the prompt response!


Assertion: http.DefaultTransport.(*http.Transport) ... makes mocking impossible

Regarding https://github.com/grafana/grafana-openapi-client-go/blob/3ad0f7e4ee52421b606af2486d7bccd7a0776ae6/client/grafana_http_api_client.go#L416
I was using github.com/jarcoal/httpmock with the old (now deprecated) API client our app. We have a test suite must run mocking tests before running integration tests as the next step. Upon upgrading to the this new OpenAPI client, I discovered that at this point, we're running into a panic caused by that line of code:
interface conversion: net/http.RoundTripper is *github.com/jarcoal/http.MockTransport,
not *net/http.Transport

It seems like an overly opinionated or short sighted requirement, that the transport MUST be *net/http.Transport. For one thing this breaks mocking.  Looking at it another way, whats the point of allowing the user to set TransportConfig if down the line you're making an assertion that its a specific thing?

On a side note, for any one else running into this, the work around for the issue with that particular mocking framework is not to use httpmock.Activate() to activate the framework, but instead to use httpmock.ActivateNonDefault(&http.Client{}).
However, that should not detract from the larger issue .. I still think the issue for taking a custom TransportConfig, then asserting its something specific, is misleading.


NDArray.make creates array but then dataSync() returns null

I am trying simply to create a new NDArray directly using NDArray.make or  new NDArray() and then retrieve the values using dataSync() but I am getting null ( before version 0.4.1 I was getting undefined)

const dl = require('deeplearn');
var q = dl.Array3D.new([3,1,1], [1, 2, 3]);
q.dataSync()
Float32Array [ 1, 2, 3 ]       // works as expected
var q = dl.NDArray.make([1,1,1], [4,5,6])
q.dataSync()
null
var q = new dl.NDArray([1,1,1], [4,5,6])
q.dataSync()
null

I expect this to be some sort of banality from my side but from the documentation, I dont see what I am doing wrong.
NDArray.make

Makes a new ndarray with the provided shape and values. Values should be in a flat array.

Thanks!

NDArray is gone, and make is also not the public API for making tensors now.


Multiple SVG errors in JSON   Error: Invalid value for  attribute width="undefined"

The plugin is great.  We have created 9 different animations, with 6 of them working flawlessly.  The final 3 all seem to have issues.  One renders alright, but certain elements are out of place and not animated.  Two others just throw console errors like crazy.  I'd be happy to send the AE file, however would prefer not to make it publicly available.  Is there an email I can send it to for help?
  Thank you.

@bodymovin I seem to be having a similar issue, and I've attached a screenshot of my console logs. I was wondering what the solution for this was?

@Tswan nice! :)

I have the same issue like @Tswan.
This is my code
import bodymovin from 'bodymovin'
export const heroHomeSvgAnimation = () => {
  const animationData = require('./json/item-man-home-hero.json')
  const animationItem = bodymovin.loadAnimation({
    wrapper: document.getElementById('svgItemManHero'),
    animType: 'svg',
    loop: true,
    animationData
  })
}

where animationData is this file converted in simple json file.
any hint?
i've tried to changeanimationData to path and this is the result:

Thank you so much!

@giacomoalonzi can you share a link where it fails so I can check the error?

@giacomoalonzi in my case it required me to write a path to the json file. It could be absolute or relative, but the way I did it so the script started from the root directory was:
var myBodyMovinVariable = bodymovin.loadAnimation({     container: document.getElementById('example'), // the dom element     renderer: 'svg',     loop: false,     autoplay: false,     path: 'inFolderLocatedInMyRootDirectory/js/data.json' //Could be 'js/data.json' if the js folder in in the root   });
I'm thinking this may be related to writing the correct path?

Should be animationData: animationData.default
See: https://github.com/chenqingspring/vue-lottie/issues/20

Works for me:
`render() {
const animationData = require('./box.json')
const defaultOptions = {
loop: true,
autoplay: true,
animationData: animationData,
rendererSettings: {
preserveAspectRatio: 'xMidYMid slice'
}
};
return (
    <Lottie options={defaultOptions} height={400} width={400} />
)

}`

Should be animationData: animationData.default
See: chenqingspring/vue-lottie#20

Works for me! But how you know that's are the solution?


Struggle with formData append

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
FilePond.setOptions({
server: {
                process: '/api/upload_photos.php',
                method: 'POST',
                ondata: (formData) => {
                    formData.append("dir", "5550b41d6c01323de9439b50feca8e07");
                    return formData;
                }
            }
});

In this way the data doesn't arrive at my endpoint.
I check this in PHP as:
if (isset($_POST['dir']) && !empty($_POST['dir'])) {
        $dir  = $_POST['dir'];
} else {
    $dir = 'bla';
}

I expect the $dir to have the variable passed, however it was always 'bla'.
I also struggled to get error messages back from the server, onload didn't trigger even onerror filepond events not.
I could make it work with this example:
https://pqina.nl/filepond/docs/api/server/#process-1
FilePond.setOptions({
server: {
                process: (fieldName, file, metadata, load, error, progress, abort, transfer, options) => {

                    const formData = new FormData();
                    formData.append(fieldName, file, file.name);
                    formData.append("dir", "5550b41d6c01323de9439b50feca8e07");

                    const request = new XMLHttpRequest();
                    request.open('POST', '/api/upload_photos.php');

                    // Should call the progress method to update the progress to 100% before calling load
                    // Setting computable to false switches the loading indicator to infinite mode
                    request.upload.onprogress = (e) => {
                        progress(e.lengthComputable, e.loaded, e.total);
                    };

                    // Should call the load method when done and pass the returned server file id
                    // this server file id is then used later on when reverting or restoring a file
                    // so your server knows which file to return without exposing that info to the client
                    request.onload = function () {
                        if (request.status >= 200 && request.status < 300) {
                            // the load method accepts either a string (id) or an object
                            console.log(request.responseText);
                            load(request.responseText);
                        } else {
                            // Can call the error method if something is wrong, should exit after
                            error('oh no');
                        }
                    };

                    request.send(formData);

                    // Should expose an abort method so the request can be cancelled
                    return {
                        abort: () => {
                            // This function is entered if the user has tapped the cancel button
                            request.abort();

                            // Let FilePond know the request has been cancelled
                            abort();
                        },
                    };
                },
            }
});

Hope this helps someone. Still figuring out why the other methods don't work.
Reproduction
FilePond 4.31.1
Environment
- Device: Mac M2
- OS: MacOS
- Browser:Chrome 125.0.6422.142

Hi, I'm not sure, the ondata callback should add to the existing formdata object, you could inspect the request in the developer console to see the package it sends and the fields that it contains.

I spend a morning trying, logging, but I couldn't grab what was going on.
Could be also a knowledge gap from my side or something I overlook.
I'll close this, because I think I have to document this issue more in detail.
I hope this issue somehow helps as archive if other people might come across this.
Thanks for making this tool available as open source. Much respect for your work
and sharing your work and approach with the community.
Kasper


Error after calling NOTIFYDATASETCHANGED

This is my Exception after i try to call
MyAdapter.notifyDataSetChanged();
Caused by: java.lang.IllegalArgumentException: ViewStub must have a valid layoutResource
What should i do?

Hi!
You can use SwipeableUltimateViewAdapter...
Have example [here] (https://github.com/cymcsg/UltimateRecyclerView/blob/master/UltimateRecyclerView/app/src/main/java/com/marshalchen/ultimaterecyclerview/demo/rvComponents/SwipeAdapter.java)


2 Deprecation Warnings

Every time the action runs it outputs 2 Deprecation warnings/notices and urges the action to be updated
Node.js 12 actions are deprecated.
For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: oracle-actions/run-oci-cli-command

and
The `set-output` command is deprecated and will be disabled soon.
Please upgrade to using Environment Files.
For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Thanks for the report.


feat(esm): move to ESM

Current dependencies on/for this PR:

main

PR #9   👈

This comment was auto-generated by Graphite.


oiqcbufr.f adjust format for printout

Need a cosmetic change to avoid ***** in OIQC printout
NTOT too large for I6 format in printout for stats from upper level check  - increase to I7

Thanks, Ricardo.


Update netty version for compatibility/staying current

Description
This PR updates Netty to 4.1.100 for compatibility with the version of com.google.protobuf:protobuf-java that the mysql-connector updated here: https://github.com/apache/cloudstack/pull/8753.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 9320

@blueorangutan test

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian Build Failed (tid-9913)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.13%. Comparing base (cadbb56) to head (b112960).
Report is 4 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8945      +/-   ##
============================================
- Coverage     15.13%   15.13%   -0.01%
- Complexity    13469    13472       +3
============================================
  Files          4863     4863
  Lines        326031   326031
  Branches      45838    45838
============================================
- Hits          49349    49347       -2
  Misses       270066   270066
- Partials       6616     6618       +2

Flag
Coverage Δ

simulator-marvin-tests
15.13% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[SF] Trillian test result (tid-9930)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52992 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8945-t9930-kvm-centos7.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_events_resource
Error
296.89
test_events_resource.py

test_01_events_resource
Error
296.91
test_events_resource.py

test_08_upgrade_kubernetes_ha_cluster
Failure
3672.76
test_kubernetes_clusters.py

test_04_deploy_vm_for_other_user_and_test_vm_operations
Failure
89.95
test_network_permissions.py

ContextSuite context=TestNetworkPermissions>:teardown
Error
1.38
test_network_permissions.py


Windows cmd error

hey there -
I got the below error when attempting to run the bat file:
"The system cannot find the batch label specified - MP"

Same issue here, running Windows 10 Pro on [ Version 10.0.19042 Build 19042 ]
Can't install using Powershell or Command Prompt (Installing using Linux shell through WSL also doesn't work, but I wasn't expecting it to)
It seems like this error might be in reference to line 66, although if you delete that line, the code still does not execute properly, even if it doesn't throw an error


Columbia University : Natural Language Processing ADDED

@BinodAryal thanks for the submission. I have been thinking about what types of courses we want to allow in the repo. We are currently focusing on new courses for now considering 2021 courses and upwards. This particular course seemed dated now.


[Core] formatting

The result of running rush format.

After today's offline discussion, we will wait to get acknowledgement from our partners. @ramya-rao-a would you please ask them to put a review/acknowledgement?
For the sake of completeness, I will outline below the assumptions I made and how this hook affects our workflow.
Assumptions:
1- It is very likely that prettier already runs in your editor using the configuration files located in the sdk directory.
2- You do not mind waiting anywhere between well less than a second and a few seconds when you issue a git commit to run the hook script first before your commit is actually performed. This waiting time depends for the most part on how many files have been changed. So for the typical case of a few files, the waiting time is less than a second.
3- You could be interested in looking at the formatting changes before actually commit them.
4- You want to move fast so you do not want to get your commit aborted for any reason.
5- It does not matter how many commits you might need to make because they will always get squashed at the time of merging with master.
Description:
This is a pre commit git hook that runs when you issue a git commit. The script calls precise-commits which in turn calls prettier on the changed parts of the changed files and will write the result to disk, if any, without staging or committing them. Consequently, the commit operation will go through and all your original staged changed will only be part of the commit. After the commit, if there are formatting changes, they will remain unstaged so you can inspect, stage, and commit them.
Of course, not everyone will like the assumptions I made and another hook behavior might suit them better. So to get an idea about the consensus, please upvote this comment if this works for you. If not, please post another comment with your assumptions and a description of the behavior you like more.

@ramya-rao-a please take a look.

@xirzec does the PR look good to you? I would like to get it merged so I can merge #10219.


Typo on line 73?

I'm not sure, but on this line should be a short array-syntax
https://github.com/flextype-components/session/blob/0df3200441d2529b909ca550b7a0137973a4144e/Session.php#L73

@pafnuty it is okey)
http://php.net/manual/en/function.session-destroy.php


Notifications?

I can't find any documentation on notifications.
Looking though the issue posts I found people using something like this
note = new Notification('hello');
..but this doesn't work.
I've tried to guess the required file name to go with it like..
require('notification')
require('notifications')
require('OSX-notifications')
but nothing
Could anyone advise or direct me to some documentation?
Thanks

Notifications only work on OS X and sometimes Linux, no require needed: https://developer.mozilla.org/en-US/docs/Web/API/notification

Thanks @paulcbetts,
Are native notifications not available? I've seen them floating around on here, well at least OS X notifications.

Just found this npm module! https://www.npmjs.com/package/node-notifier
Its got windows, mac and linux support with a fulback to Growl if it exists.

@paulcbetts what's the issue with Windows?
I haven't tried it yet but It looks like atom/browser/ui/win/notify_icon.cc Implements Shell_NotifyIcon() and sets the balloon/notification data with NOTIFYICONDATA.

@vinnyp Tray balloons are not the same as notifications, anyone using them as such should be Punished :)

@paulcbetts maybe we're mixing up terminology, can you help clarify?
Windows has two native mechanisms for displaying notifications:

Notifications (What you mention above as tray balloons. Supported in XP+)

Toast Notifications, supported in Win8+. Only apps using the new app model (Modern) can use this.

I'm assuming what you mean by notifications is Google's desktop notifications (e.g. Slack's notifications), correct?

When I hear notifications for Windows, I think of 1 & 2. I was a Program Manager on Windows for 9 years so that's what I think of :)
In what cases do you expose Balloons to developers in Electron?

In what cases do you expose Balloons to developers in Electron?

These are exposed on their own object called Tray, which lets you do everything'ish that Shell_NotifyIcon does

Toast Notifications, supported in Win8+.

Yeah, so this is what we should add to Electron, they actually can be used from Desktop apps as well (unofficially in Win8, and officially in Win10), via the same COM / WinRT'y API. The only caveat is that you must have a shortcut in the Start Menu or else they don't show in Win8. Outlook does this for example.

Google's desktop notifications

Chrome's desktop notifications are actually custom-implemented and aren't in Electron (they're part of Chrome's notification system with the Bell in the tray and Google Now and stuff).

(e.g. Slack's notifications)

Slack's notifications are actually custom code that are none of these options above! What a world!

Are there any future plans for the work @paulcbetts mentioned here? We're going to go with node-notifier for now probably and will track this to remove the reference when implemented in electron.


Regenerate resource docs for AWS, Azure AD, GCP and Random

Proposed changes
This PR replaces #3270.
A handful of provider releases were already in-flight when the PR to restore generation of resource docs as part of provider releases was merged. So this PR contains the docs regenerated for those providers/packages with the latest version.
Unreleased product version (optional)
N/A
Related issues (optional)
N/A

So the diffs largely look good to me. Lots of new additions due to Python examples becoming available for resources. In some cases, though, it seems that we have lost an example. For example, here's one case in AWS. Perhaps a conversion failure?

I’m going to investigate some of these failures separately


cdxgen fails to fetch license information for some projects even though they are present in npm metadata

I have a project with the following yarn.lock:
<EMAIL_ADDRESS>  version "1.0.0"
  resolved "https://registry.yarnpkg.com/boolbase/-/boolbase-1.0.0.tgz#68dff5fbe60c51eb37725ea9e3ed310dcc1e776e"
  integrity sha512-JZOSA7Mo9sNGB8+UjSgzdLtokWAky1zbztM3WRLCbZ70/3cTANmQmOdR7y2g+J0e2WXywy1yS468tY+IruqEww==

<EMAIL_ADDRESS>  version "1.2.1"
  resolved "https://registry.yarnpkg.com/browser-assert/-/browser-assert-1.2.1.tgz#9aaa5a2a8c74685c2ae05bfe46efd606f068c200"
  integrity sha512-nfulgvOR6S4gt9UKCeGJOuSGBPGiFT6oQ/2UBnvTY/5aQ1PnksW72fhZkM30DzoRRv2WpwZf1vHHEr3mtuXIWQ==

<EMAIL_ADDRESS>  version "0.1.2"
  resolved "https://registry.yarnpkg.com/exit/-/exit-0.1.2.tgz#0632638f8d877cc82107d30a0fff1a17cba1cd0c"
  integrity sha512-Zk/eNKV2zbjpKzrsQ+n1G6poVbErQxJ0LBOJXaKZ1EViLzH+hrLu9cdXI4zw9dBQJslwBEpbQ2P1oS7nDxs6jQ==

<EMAIL_ADDRESS>  version "0.1.4"
  resolved "https://registry.yarnpkg.com/imurmurhash/-/imurmurhash-0.1.4.tgz#9218b9b2b928a238b13dc4fb6b6d576f231453ea"
  integrity sha512-JmXMZ6wuvDmLiHEml9ykzqO6lwFbof0GG4IkcGaENdCRDDmMVnny7s5HsIgHCbaq0w2MyPhDqkhTUgS2LU2PHA==

The resulting bom.json contains no license information, even though for boolbase and imurmurhash the license is explicite stated in the npm metadata.
For the other two projects npm metadata states none license, but the license is mentioned elsewhere, so perhaps it might be deduced as well.

https://github.com/CycloneDX/cdxgen/pull/672


Add spread element check when the last element is a spread.

The current behavior is: if the last list element expression is a spread, the parser will not check the rest element whether contains a spread expression.
This PR adds a spread element check when the last list element is a spread.
Please see #670 for more details.

OK, I'll try that.

I think I have done it, please check again. Thank you for reviewing!