refactor: not to use enum for URLs

Task linked: GHORG-47 Refactor not to use enum for URLs

Codecov Report

Merging #50 (031ab09) into master (c2c4a18) will increase coverage by 0.14%.
The diff coverage is 70.96%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   62.92%   63.06%   +0.14%
==========================================
  Files          11       13       +2
  Lines          89      111      +22
  Branches       13       17       +4
==========================================
+ Hits           56       70      +14
- Misses         33       41       +8

Impacted Files
Coverage Δ

...es/errors/selling-partner-mismatch-region-error.ts
50.00% <50.00%> (ø)

...s/errors/selling-partner-not-found-region-error.ts
50.00% <50.00%> (ø)

src/helpers/api-client-helpers.ts
76.47% <72.22%> (-4.49%)
:arrow_down:

src/api-clients/sellers-api-client.ts
100.00% <100.00%> (ø)

...pi-clients/amazon-selling-partner-api-base-path.ts
100.00% <100.00%> (ø)

src/types/api-clients/index.ts
100.00% <100.00%> (ø)

src/types/errors/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c4a18...031ab09. Read the comment docs.


State of pipelines is not correct

From https://github.com/datahq/specstore/blob/b4bbf554869230fdc2664a41524dc834f331dd2e/specstore/controllers.py#L77-L78 we can see that state set to REGISTERED when update time of pipeline is older than update time of spec. So I have tested with one package to see what happens when I just repush my dataset without any changes:
Checked source api to see the state of the pipeline https://api.datahub.io/source/90998f7f90e086bd5fc7c9075dfda43b/co2-ppm/info and in here update_time of pipeline is the first push time:
{
  ...
  "pipeline": {
    "pipeline": [...],
    "update_time": "2017-08-15T05:54:36.488076"
  },
  ...
}

But if we take a look at specs table in the database, we can see that updated_at value is the date of the last push (2017-08-29). So because of that we are always getting TRUE in the following statement:
if spec.updated_at and spec.updated_at.isoformat() > update_time:
    resp['state'] = 'REGISTERED'

Possible solution: pipeline's update_time should be updated as the spec's one.

I believe this problem was solved in https://github.com/frictionlessdata/datapackage-pipelines-sourcespec-registry/commit/c233cf35baf2f48fb3800df766705da723e4ecf3
Please re-open if this reoccurs.


Fix issue 17482: Fix Nullable!Variant equality checks.

The circleci stuff seems to be complaining about something in std.json which wasn't even touched by this PR.

I suggest adding a unittest which tests opEquals for other value types: structs and fixed length arrays.

The circleci stuff seems to be complaining about something in std.json which wasn't even touched by this PR.

Oops, that looks like my fault.

The circleci stuff seems to be complaining about something in std.json which wasn't even touched by this PR.
Oops, that looks like my fault.

->  https://github.com/dlang/phobos/pull/5560


catkin_make issue

Hello,sir
I want to know how your repo works, I have down all the codes to my workspace. But When i run catkin_make ,there is a error
`user@ubuntu:~/Drilling_WS$ catkin_make
Base path: /home/user/Drilling_WS
Source space: /home/user/Drilling_WSc
Build space: /home/user/Drilling_WSild
Devel space: /home/user/Drilling_WS/devel
Install space: /home/user/Drilling_WS/install

Running command: "make cmake_check_build_system" in "/home/user/Drilling_WSild"

-- Using CATKIN_DEVEL_PREFIX: /home/user/Drilling_WS/devel
-- Using CMAKE_PREFIX_PATH: /home/user/Drilling_WS/devel;/home/user/catkin_ws/devel;/opt/ros/melodic
-- This workspace overlays: /home/user/Drilling_WS/devel;/home/user/catkin_ws/devel;/opt/ros/melodic
-- Found PythonInterp: /usr/bin/python2 (found suitable version "2.7.17", minimum required is "2")
-- Using PYTHON_EXECUTABLE: /usr/bin/python2
-- Using Debian Python package layout
-- Using empy: /usr/bin/empy
-- Using CATKIN_ENABLE_TESTING: ON
-- Call enable_testing()
-- Using CATKIN_TEST_RESULTS_DIR: /home/user/Drilling_WSild/test_results
-- Found gtest sources under '/usrc/googletest': gtests will be built
-- Found gmock sources under '/usrc/googletest': gmock will be built
-- Found PythonInterp: /usr/bin/python2 (found version "2.7.17")
-- Using Python nosetests: /usr/binsetests-2.7
-- catkin 0.7.26
-- BUILD_SHARED_LIBS is on
-- BUILD_SHARED_LIBS is on
WARNING: Package name "dianaS1_moveit_config" does not follow the naming conventions. It should start with a lower case letter and only contain lower case letters, digits, underscores, and dashes.
WARNING: Package name "dianaS1_description" does not follow the naming conventions. It should start with a lower case letter and only contain lower case letters, digits, underscores, and dashes.
WARNING: Package name "dianaS1_gazebo" does not follow the naming conventions. It should start with a lower case letter and only contain lower case letters, digits, underscores, and dashes.
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- ~~  traversing 13 packages in topological order:
-- ~~  - franka_description
-- ~~  - franka_ros (metapackage)
-- ~~  - franka_msgs
-- ~~  - franka_gripper
-- ~~  - franka_visualization
-- ~~  - franka_hw
-- ~~  - franka_control
-- ~~  - franka_example_controllers
-- ~~  - franka_polishing
-- ~~  - franka_spacenav
-- ~~  - franka_udrilling
-- ~~  - franka_simulation
-- ~~  - panda_moveit_config
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- +++ processing catkin package: 'franka_description'
-- ==> add_subdirectory(franka_description)
-- +++ processing catkin metapackage: 'franka_ros'
-- ==> add_subdirectory(franka_ros)
-- +++ processing catkin package: 'franka_msgs'
-- ==> add_subdirectory(franka_msgs)
-- Using these message generators: gencpp;geneus;genlisp;gennodejs;genpy
-- franka_msgs: 2 messages, 0 services
-- +++ processing catkin package: 'franka_gripper'
-- ==> add_subdirectory(franka_gripper)
-- Using these message generators: gencpp;geneus;genlisp;gennodejs;genpy
CMake Error at franka_gripper/CMakeLists.txt:17 (find_package):
By not providing "FindFranka.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Franka", but
CMake did not find one.
Could not find a package configuration file provided by "Franka" (requested
version 0.7.0) with any of the following names:
FrankaConfig.cmake
franka-config.cmake

Add the installation prefix of "Franka" to CMAKE_PREFIX_PATH or set
"Franka_DIR" to a directory containing one of the above files.  If "Franka"
provides a separate development package or SDK, be sure it has been
installed.
-- Configuring incomplete, errors occurred!
See also "/home/user/Drilling_WSild/CMakeFiles/CMakeOutput.log".
See also "/home/user/Drilling_WSild/CMakeFiles/CMakeError.log".
Makefile:320: recipe for target 'cmake_check_build_system' failed
make: *** [cmake_check_build_system] Error 1
Invoking "make cmake_check_build_system" failed
`
And my Ubuntu version is 18.04,ROS version is Melodic
Why can it happen? Can you help me
Thanks ,
-Jian

Hi，Hélio Ochoa，
I have try to fix this issue，what i have done are below：
sudo sh -c 'echo "deb http://packages.ros.org/ros/ubuntu $(lsb_release -sc) main" > /etc/apt/sources.list.d/ros-latest.list' sudo apt-key adv --keyserver 'hkp://keyserver.ubuntu.com:80' --recv-key C1CF6E31E6BADE8868B172B4F42ED6FBAB17C654
 sudo apt update sudo apt install ros-melodic-libfranka ros-melodic-franka-ros cd to my ws and then catkin_make`
A new issue show as below picture

Could you please upload the Keyboard.hpp
Thanks,
Best regards,
-Jian


1.0 UX / QA Runbook

Create a dogfood / QA runbook to go through before beta is released.

Here are notes from the November 3, 2023 walkthrough — https://docs.google.com/document/d/1x02b7UjyYp5R0MXyXf7UsxQB_7uRQZeBvDo8BmXz9ZA/edit?usp=sharing

Fixed by #3043


How to set different color of bars by if condition?

There're some QAs in matplotlib/python, refer, but it seems that the mechanism of Archimedes is different from python world.
I didn't find Archimedes repo in Github, so I created an issue here, let me know if I was wrong.
I was wondering if maybe we could set different color of bars by condition?
A minimal test case would like:
#require "graphics";;
#require "jupyter-archimedes"

let rec walk acc p i =
  if i = 0 then List.rev acc else begin
    let q = if Random.bool () then succ p else pred p in
    walk (q :: acc) q (pred i)
  end

let points = List.map float @@ walk [] 0 10

let vp = A.init ~w:560. ~h:260. ["jupyter"] in
A.Axes.box vp ;
A.List.y vp ~style:(`Bars 0.9) ~fillcolor:A.Color.dark_slate_grey ~fill:true points ;
A.close vp

It would look like:

For example, I would like to set the bars under 0 using red color.

@pivdets Sorry for late reply. I think this is the simplest way:
let rec walk acc p i =
  if i = 0 then List.rev acc else begin
    let q = if Random.bool () then succ p else pred p in
    walk (q :: acc) q (pred i)
  end ;;

let points = List.map float @@ walk [] 0 10 ;;

let vp = A.init ~w:560. ~h:260. ["jupyter"] in
A.Axes.box vp ;
A.List.y vp ~style:(`Bars 0.9) ~fillcolor:A.Color.dark_slate_grey ~fill:true
  (List.map (fun y -> if y < 0.0 then 0.0 else y) points) ;
A.List.y vp ~style:(`Bars 0.9) ~fillcolor:A.Color.red ~fill:true
  (List.map (fun y -> if y > 0.0 then 0.0 else y) points) ;
A.close vp


Feature/cms pages

Ability to add simple page with html content. We should migrate the rest of pages to use this simpler API.

Oh.. and there's some issue with the Linter.


Add support for Java 9 multi release jars

I've just updated a dependancy and it is now providing a multi release jar. This results in the following error when building:
Can't process class [META-INF/versions/9/com/teamdev/jxbrowser/chromium/internal/JavaVersion.class] (Unsupported class version number [53.0] (maximum 52.0, Java 1.8)))
Proguard doesn't yet support Java 9 but does have a workaround for this, which is to exclude the versions folder for library jars, eg:
--libraryjars somelib.jar(!META-INF/versions/**)
I've added support for this by blindly adding this exclusion for all library jars.
Does this sounds like an acceptable solution? If so I'll put a pull request together.

Thanks for reporting this and pointing to the workaround.
I personally would tend to not include your pull-request, as this should be fixed with ProGuard first. As you wrote, this is a workaround, but a proper fix might be better.
I'll leave the decisions to @wvengen how to handle this.

Thanks for taking the time to look at this @FibreFoX, much appreciated. I do agree that ProGuard should be fixed. They do have a workaround for this, which is to supply:
--libraryjars somelib.jar(!META-INF/versions/**)
However it isn't possible to provide this configuration option via the plugin currently.
Without this change (or another that provides a means to the same end) users of the proguard-maven-plugin will have to reject all library updates that provide multi release jars until ProGuard updates with Java 9 support, which may be sometime.
The only other options I can think of would be stripping the jar's manually before running ProGuard or writing their own mojo / shell script to do this.

There is another option I can think of: making it possible to pass own strings instead of hard-coding some, this would make this maven-plugin more compatible to further adjustments, including that workaround without binding it to that specific one.
How do you think about this idea?

I think that's a better approach, and saves having to unwind things in the plugin when Java 9 support is added to ProGuard.
How do you see this working from a configuration point of view? A single setting that sets this for all library jars?

Your approach inside the ProGuardMojo was like a single property :) so I assume we should just introduce a new one. Btw: nice catch for refactoring same code fragments 👍

Excellent - I've done that and issued a new pull request.

@liamsharp How did you get your change to work with jxBrowser? When adding the option for jxbrowser-6.18.jar I get error that the jar is specified twice.

@rcantrel Is this question related to the proposed change?
With this fix in place, I've just had to update my configuration to include, which should work for all multi release jar's, it's not specific to JxBrowser:
<libraryJarExclusion>(!META-INF/versions/**)</libraryJarExclusion>
Can you build with a version of JxBrowser before they added Java 9 support? If you have some code I can check out I can take a quick look for you.

@liamsharp yeah it was related to the proposed change.  Proguard newbie apparently.  To use the libraryjars configuration option, I needed to remove my dependency to jxbrowser-6.19.jar.  Thanks for this this PR, btw.

@liamsharp I was rereading you last comment and think you are saying that there is a better way to do what I want.  Is there a way to do something like in my pom?
<option>-libraryjars *.jar(!META-INF/versions/**)</option>
or
<option>-libraryJarExclusion (!META-INF/versions/**)</option>
So I don't have to specify a particular jar? Neither of the above options worked for me.

@rcantrel I've just got jxbrowser as a dependancy and the exclusion mentioned before. If you create an example cutdown project to demonstrate the issue I can take a look for you.

@liamsharp @rcantrel a bit off-topic? ;) further discussion should be done in a separate project, makes a bit noise here.

hi @wvengen , is there any update regarding this issue? I was trying out Proguard for my project for the first time and I am currently stuck with this.

Seems like this is fixed by #103. Can be reopened if this is not the case.

From https://wvengen.github.io/proguard-maven-plugin/
You can use inLibsFilter to apply ProGuard classpathentry Filters to all input lib jars
    <inLibsFilter>!META-INF/versions/**</inLibsFilter>


FQDN hostname no longer works in wsl.conf

Windows Version
10.0.19043.2364
WSL Version
1.1.6
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu-20.04
Other Software
No response
Repro Steps
WSL2 started changing my hostname defined in  /etc/wsl.conf file.
[network]
hostname=name.someName.OtherSection.Domain
now results in the dots in the hostname removed:
$ hostname
name.someNameOtherSectionDomain
This started about a months now. I searched the web but no luck.
Any help on how to get the hostname working correctly  as defined in the wsl.conf file will be great.
Expected Behavior
hostname should display the name defined in the /etc/wsl.conf file
Actual Behavior
wsl removes dots from the hostname defined in the /ect/wsl.conf file
Diagnostic Logs
No response

Is this breaking something for you? We recently updated the hostname logic to obey Linux rules.

Yes, I do development and have a lot of apache hosts setup on the  on my WSL Ubuntu which depend on the hostname. Now, none of them is working. Everything is breaking. Now, I have to manually force the hostname on the ubuntu to be what I want before some of the applications will work.
If you changing this to follow Linux rules, then how do some of us that depend on this hostname get the same result? Do you have a new setting that can be used to produce the same as before?
If not, need suggestion how to deal with it. Thanks

@mkuivi I think just "hostname" should produce the host part of the FQDN, and "hostname -f" should produce the FQDN.

@mkuivi I configured it now like this:
/etc/wsl.conf:
[network]
hostname=hostname-aki
generateHosts=false

/etc/hostname:
hostname-aki

cat /etc/hosts | grep aki   # i removed the <IP_ADDRESS> line. no idea what's that for
<IP_ADDRESS>       hostname-aki.non.existing.domain.lan hostname-aki localhost

To test:

hostname
hostname-aki
hostname -f
hostname-aki.non.existing.domain.lan
I tested and xorg apps still work.

Yes, I do development and have a lot of apache hosts setup on the on my WSL Ubuntu which depend on the hostname. Now, none of them is working. Everything is breaking.

Aren't you setting the virtual host ServerName?

If you omit the ServerName directive from any name-based virtual host, the server will default to a fully qualified domain name (FQDN) derived from the system hostname. This implicitly set server name can lead to counter-intuitive virtual host matching and is discouraged.

I'm seeing the same thing:
[network]
hostname=host.domain.name.tld

$ hostname -f
host.domaainnametld

this is a regression. please fix asap.

$ man 1 hostname
...
The  recommended  method of setting the FQDN
is to make the hostname be an alias for  the
fully  qualified name using /etc/hosts, DNS,
or NIS. For example,  if  the  hostname  was
"ursula",   one   might   have   a  line  in
/etc/hosts which reads

    <IP_ADDRESS> ursula.example.com ursula
...

By following this config, both hostname and hostname -f return the expected values.

@aki-k this doesn't work. I need hostname to return the fqdn.
wsl is broken.
it worked fine before.
this is a REGRESSION.

further evidence of brokenness:
$ sysctl kernel.hostname
kernel.hostname = host.domaainnametld

$ sysctl kernel.domainname
kernel.domainname =

go on. tell me kernel.domainname exists for no reason.

$ sysctl kernel.domainname
kernel.domainname =
go on. tell me kernel.domainname exists for no reason.

I don't know about that sysfs entry, but on my host that I configured like above, I see this:
$ dnsdomainname
redacted.fi

I haven't configured redacted.fi anywhere else than to /etc/hosts on that localhost line that now has:
<IP_ADDRESS> hostname.redacted.fi hostname localhost

let me guess, you're using a debian-derived distro?

It's Fedora 36

ugh. it seems systemd has truly infected everything.

I have the same problem...
I need to set the hostname that includes my organization domain for some names resolutions to work.
It was working fine a few days ago so in my wsl.conf i set
hostname = "myname.orgname.com"
but hostoname displays
myname.orgnamecom
The last dot is removed.

@frabul Configure it like this: https://github.com/microsoft/WSL/issues/9897#issuecomment-1499095770 so both hostname, hostname -f and dnsdomainname work properly.

Is this breaking something for you? We recently updated the hostname logic to obey Linux rules.

When the second dot is dropped on my system (i.e., subdomain.domain.tld becomes subdomain.domaintld) sudo gives an error message:
sudo: unable to resolve host subdomain.domaintld: Name or service not known
I've got various Ubuntu and RaspberryPiOS boxes all over the place and none of them do this, just WSL 2 under Windows 11.
I tried putting two dots in /etc/wsl.conf: subdomain.domain..tld, but that had no effect. Every time I restart WSL 2, the contents of /etc/hostname become subdomain.domaintld, even after removing all write privileges from that file.

Please fix this regression.
Arbitrarily stripping the dots out of what the user explicitly supplied in their manually written configuration file makes no sense whatsoever.
Unfortunately, there is a lack of standardization between Linux distributions about whether to set the kernel hostname to the short or fully-qualified domain name. Some distros lean one way, some the other. So sometimes you encounter software expecting the kernel hostname to be a FQDN. Right now, WSL is performing a bizarre textual transformation on what the user specifies - just trust the user editing wsl.conf to know their own requirements.

@maxb You have some process/service that requires that?

Yes

@maxb What process/service you're running requires you to have the FQDN in /proc/sys/kernel/hostname ?

Some proprietary software that expects that because it was written for Linux distros such as Red Hat where that is the standard out of the box configuration.

@maxb What's the error from the software that you get if the FQDN is not in /proc/sys/kernel/hostname ?

No specific error. Complex malfunctions because the result of reading the kernel hostname does not map to an expected Kerberos domain.
However this is NOT THE POINT. The issue is not the specific software I happen to be using right now. The issue is that WSL is performing illogical undocumented textual transformations upon user input in configuration files, and should cease doing that.

@maxb I can only describe what the man page for this says:
$ man 1 hostname

       The recommended method of setting the FQDN is to make the hostname be an alias for
       the fully qualified name using /etc/hosts, DNS, or NIS. For example, if the  host‐
       name was "ursula", one might have a line in /etc/hosts which reads

              <IP_ADDRESS>    ursula.example.com ursula

The DNS domain name is the part after the first dot.

The man page in that means the hostname (ursula) is the part before the DNS domain name (example.com).
And then the FQDN is ursula.example.com.

The recommended method in the particular man page you have chosen to quote is quite irrelevant.
Major distributions do it both ways, and regardless, WSL should not be arbitrarily mangling input strings.

@maxb Well I think this is the first time I hear someone say a man page is irrelevant.

man pages are not standard across distributions. You are trying to use a version that suits your personal preferences to justify something I have already explained differs between major distributions.

@maxb What does your distro's "man 1 hostname" say about it?

Huh... it turns out the man page on CentOS fails to document the common practice on CentOS.
Anyway, have a read of https://serverfault.com/questions/331936/setting-the-hostname-fqdn-or-short-name which shows widespread difference of opinion on this point.
However, again, this really is not getting to the core of the issue here:
There are plenty of people who think the kernel hostname should be the short name. There are plenty of people who think the kernel hostname should be the FQDN.
WSL should avoid choosing a side in this difference of opinion, in order to be useful to people in both camps, and should definitely not arbitrarily delete dots from what the user specified:
If the user specifies ursula.example.com, then making up the hostname ursula.examplecom is definitely wrong, because the examplecom DNS label is a nonsense invention.

Rocky Linux 9 (RHEL 9) "man 1 hostname" includes the same text I pasted above:
       The recommended method of setting the FQDN is to make the hostname be an alias for the fully qualified name using /etc/hosts, DNS, or NIS. For example, if the hostname was "ursula", one might have a line in /etc/hosts which reads

              <IP_ADDRESS>    ursula.example.com ursula

       Technically: The FQDN is the name getaddrinfo(3) returns for the host name returned by gethostname(2).  The DNS domain name is the part after the first dot.

https://github.com/microsoft/WSL/issues/9897#issuecomment-1499095770 is a workaround.
i would expect setting a fqdn hostname in /etc/wsl.conf would result in the proper hosts file to be generated on startup.  as it is, you are forced to manage the hosts file yourself in order to fix improper hostname parsing.

Similar problem.
Why hasn't this been fixed yet?
Why is it done so that the point is deleted?

@KoRn0509 Use the short hostname in /etc/wsl.conf.
/etc/wsl.conf:
[network]
hostname=hostname-aki
generateHosts=false

Then in the WSL 2 instance:
/etc/hostname:
hostname-aki

/etc/hosts:
<IP_ADDRESS>       hostname-aki.non.existing.domain.lan hostname-aki localhost

Reboot (wsl --shutdown) and test (bash):
$ hostname
hostname-aki
$ hostname -f
hostname-aki.non.existing.domain.lan
$ dnsdomainname
non.existing.domain.lan

@aki-k This does not work. I want to set up the iRedmail mail server for testing. To install it, you need to set the FQDN mail.mydomain.com
How can i do this?

@KoRn0509 Did you try using the FQDN with iRedmail after configuring the hostname like I described above?

@KoRn0509 Use the short hostname in /etc/wsl.conf.
/etc/wsl.conf:
[network]
hostname=hostname-aki
generateHosts=false

/etc/hostname:
hostname-aki

/etc/hosts:
<IP_ADDRESS>       hostname-aki.non.existing.domain.lan hostname-aki

Reboot (wsl --shutdown) and test:
$ hostname
hostname-aki
$ hostname -f
hostname-aki.non.existing.domain.lan
$ dnsdomainname
non.existing.domain.lan

This does indeed work for me and has survived across multiple reboots. I don't know why it's different in WSL compared to Ubuntu and Raspberry Pi OS, but thank you for providing what most of us likely will refer to as a workaround.

@atrocity2001 I'm not sure why you think this method is only for WSL 2?
$ man hostname

The  recommended  method of setting the FQDN is to make the hostname be an alias for  the fully  qualified name using /etc/hosts, DNS, or NIS. For example,  if  the  hostname  was "ursula",  one   might   have   a  line  in /etc/hosts which reads

       <IP_ADDRESS>     ursula.example.com  ursula

@atrocity2001 I'm not sure why you think this method is only for WSL 2?
$ man hostname
The recommended method of setting the FQDN is to make the hostname be an alias for the fully qualified name using /etc/hosts, DNS, or NIS. For example, if the hostname was "ursula", one might have a line in /etc/hosts which reads
<IP_ADDRESS> ursula.example.com ursula

I've simply never had to do that on any Ubuntu or Raspberry Pi OS I've run. And I've run Ubuntu for years. So it may technically be correct, but what's confusing to me and others in this thread is that WSL2, allegedly running Ubuntu, strictly enforces that convention while vanilla Ubuntu does not.
And I also assume it's a change, because I certainly didn't know enough to set up my own host/hostname file 15+ years ago, so I just modified what was already there by default. As others here have indicated, WSL2 itself didn't used to demand that, though I have only started using it recently and can't speak to that from personal experience.

I agree with the OP.
The reason hostname is set to the FQDN is to ensure a device is reported correctly to external systems.
A hostname can be duplicated across domains on separate devices or on the same device where its multihomed.
There are many products that run both locally and externally that rely on the hostname reported by the OS to be an FQDN, to prevent ambiguity and confusion.
This includes Red Hat Satellite, which presents devices based on the output of 'hostname'.
If the 1000's of devices reported the short hostname, how would I differentiate between host1.customer1.com and host1.customer2.com?
The standard practice is to set the hostname to the FQDN so that the lowest common denominator method, across all Linux distros and versions can be used to discover a clients hostname reliably and consistently.
The kernel reporting a short name cannot be guaranteed as unique to an environment and then relies on a default domain, so what happens when the same hostname exists across multiple domains? How do systems that only know the host as "ursula" differentiate between "ursula.default-domain.com" and "ursula.corporate-domain.com" or ursula.customer1.com and ursula.customer2.com etc.
But if WSL is only for the home hobbyist, fine.

@sedstr

The reason hostname is set to the FQDN is to ensure a device is reported correctly to external systems.

This is false.
Please show the output from these three commands:
hostname
hostname -f
dnsdomainname

This is not a theocratic discussion. My statements are valid and true.
The hostname commands output is the result of the administrator's decision, it's as simple as that.
Every Linux and Unix OS has honored setting the hostname to the FQDN.
WSL also honored this in previous iterations but has changed.
This thread is a discussion about why the historical behavior should be maintained, not what is true, false, right or wrong.
I would much rather WSL produce predictable and consistent results, and considering this behavior was introduced after working as expected since the first release, a reasonable outcome would be to revert the change or add an equivalent option to the wsl.conf to ensure that hostnames are reported as the desires. Not based on what seems to be a zealous demand for compliance.

@sedstr So you're embarrassed to show the output of those commands because it would show your system is not configured right.

@aki-k - you seem to be having difficulty comprehending.
I'm simply stating facts while you seem to be preaching like this is some kind of religion.
 We all learn something every day.

Workaround I found to circumvent WSL overwriting FQDN hostname on boot:

Set hostname to FQDN, eg: subdomain.domain.tld
sudo hostnamectl set-hostname subdomain.domain.tld

/etc/wsl.conf:
[network]
hostname=subdomain.domain.tld
generateHosts=false

Change attributes on hostname file to make it immutable:
chattr +i /etc/hostname

After produced steps the WSL-system keeps the dots in the FQDN-hostname after reboot.


⚠ 한경주요지수-코스피200 has degraded performance

In bd00959, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 5912 ms

Resolved: 한경주요지수-코스피200 performance has improved in 061acc7.


[1622] Content changes to error messages

Context
https://trello.com/c/MaOwWunO/1622-error-message-changes
Changes proposed in this pull request
See the checklist on the trello ticket.
Guidance to review
Visit the pages as described on the trello ticket, submit the forms empty to see the error messages.

 Error message changes


Images: Attribution & Deletion

When adding an image to be associated with a gall, there should be a way to also add its origin. Two possible ways to handle this, maybe not mutually exclusive:
For images from a text source, add an image uploader to the Map Species & Source page.
Create an independent image uploader admin page that allows users to associate a new image with an existing source or add either an attribution by text (eg if the image was obtained with permission from an individual) and/or link to an iNaturalist, Bugguide, etc observation where it was obtained from (with the benefit of providing additional ecological info).

I have this stuff in the database schema but currently there is no UI for it. Adding the ability to add images from multiple places is not that hard. I think it makes sense to do it both ways you describe. I can also easily disable the ability to add an image from the main species pages. It would be a PITA to have to try and add attribution UI there.

I have this stuff in the database schema but currently there is no UI for it. Adding the ability to add images from multiple places is not that hard. I think it makes sense to do it both ways you describe. I can also easily disable the ability to add an image from the main species pages. It would be a PITA to have to try and add attribution UI there.

Yeah I figured that adding them on the main species page would not be convenient to add this additional info. If we can't edit other info from there anyway, I see no reason we need to add images there.

Yeah I figured that adding them on the main species page would not be convenient to add this additional info. If we can't edit other info from there anyway, I see no reason we need to add images there.

Adding to the work for this (as it is related):

[ ] Add a way to delete images
[ ] Add a way to re-associate an image to a different species (not required but might be convenient)

Adding to the work for this (as it is related):

[ ] Add a way to delete images
[ ] Add a way to re-associate an image to a different species (not required but might be convenient)

I am working on this and wanted to get some thoughts/feedback.
I think that we should have the following ways to manipulate images:

add/delete/edit metadata via new Image Admin (see below for details)
add/delete via species-source mapping admin page (this will automatically map the image to that source)
display on species details pages (gall and host)

The Image Admin page will look something like this:

From there you will be able to view all images assigned to a species, add new images, select for deletion one or more images, and edit image metadata. The edit piece will happen via a modal that looks like this:

The fields shown are the current fields as they exist in the database right now. The uploader field is automatically populated at time of upload and is not editable.
Currently the other fields are just strings. We could allow the source field to map to an actual Source but then that would preclude it from being anything other than that. Maybe what we want is the option to map to a Source and the the option to just type in a text source.

I am working on this and wanted to get some thoughts/feedback.
I think that we should have the following ways to manipulate images:

add/delete/edit metadata via new Image Admin (see below for details)
add/delete via species-source mapping admin page (this will automatically map the image to that source)
display on species details pages (gall and host)

The Image Admin page will look something like this:

From there you will be able to view all images assigned to a species, add new images, select for deletion one or more images, and edit image metadata. The edit piece will happen via a modal that looks like this:

The fields shown are the current fields as they exist in the database right now. The uploader field is automatically populated at time of upload and is not editable.
Currently the other fields are just strings. We could allow the source field to map to an actual Source but then that would preclude it from being anything other than that. Maybe what we want is the option to map to a Source and the the option to just type in a text source.

I think the Source field has to map to actual sources because that's the only way to cause the dropdown menu to appear and autocomplete the titles, right? I think the solution is to make mapping a Source optional, so if the image is from an iNat user or elsewhere we can just put a hyperlink instead, maybe in a new field? I think we should try to encourage one or the other--it's hard to imagine a case where we'd be putting up a photo that doesn't occur either in a primary source or somewhere else online, where there will be more info about the observation.
If we have a link field, we could use it for images from Source mappings too, in addition to the page link for the text description (this would be convenient in that they're often separated by many pages in the old sources, where the plates are all in the back). Not sure how we'd present that on the Map Species and Source page. I guess we'd just need a second link field?

I think the Source field has to map to actual sources because that's the only way to cause the dropdown menu to appear and autocomplete the titles, right? I think the solution is to make mapping a Source optional, so if the image is from an iNat user or elsewhere we can just put a hyperlink instead, maybe in a new field? I think we should try to encourage one or the other--it's hard to imagine a case where we'd be putting up a photo that doesn't occur either in a primary source or somewhere else online, where there will be more info about the observation.
If we have a link field, we could use it for images from Source mappings too, in addition to the page link for the text description (this would be convenient in that they're often separated by many pages in the old sources, where the plates are all in the back). Not sure how we'd present that on the Map Species and Source page. I guess we'd just need a second link field?

Here is what I have now:
Edit Image Details

Selecting a Source from those that are already mapped to the species

Hover over tips to help guide the way

Thoughts?

Here is what I have now:
Edit Image Details

Selecting a Source from those that are already mapped to the species

Hover over tips to help guide the way

Thoughts?

So eg you could add a picture from a source on BHL, then put the source link to the specific page below? The "and/or" is a bit ambiguous to me. It looks like you've got all the fields there though. What's the difference between Creator and Attribution?

So eg you could add a picture from a source on BHL, then put the source link to the specific page below? The "and/or" is a bit ambiguous to me. It looks like you've got all the fields there though. What's the difference between Creator and Attribution?

The thought is that you would normally only add one or the other of "Source" or "Source Link". Source being an internal reference to existing source that is defined in the system and Source Link being an external URL. I have been struggling with how to convey the and/or nature of this in the UI.
Attribution is an open-ended field for adding attribution notes, creator would be a named individual or link to an individual.

The thought is that you would normally only add one or the other of "Source" or "Source Link". Source being an internal reference to existing source that is defined in the system and Source Link being an external URL. I have been struggling with how to convey the and/or nature of this in the UI.
Attribution is an open-ended field for adding attribution notes, creator would be a named individual or link to an individual.

I will also be adding the ability to add an image from the Species-Source mapping page that will (I think) not have all of this detail.

I will also be adding the ability to add an image from the Species-Source mapping page that will (I think) not have all of this detail.

My impulse would just be to clarify this with more text--maybe there's a more elegant way to do it with web design and I'm open to that but in the meantime I'd just break this into two blocks and say:
"If your image is from a publication:" and include these two fields. Only this part would be replicated on the Species-Source mapping page.
Source
Direct Link to Image Page (if available, eg at BHL or HathiTrust. Do not duplicate main source-level link or link to a pdf):
then "If your image is not from a publication:" and include the fields you have now. I would alter the tooltip on Source link to say "Link to the original image location" though, since we're looking for the observation, not the literal hyperlink to the image itself.

My impulse would just be to clarify this with more text--maybe there's a more elegant way to do it with web design and I'm open to that but in the meantime I'd just break this into two blocks and say:
"If your image is from a publication:" and include these two fields. Only this part would be replicated on the Species-Source mapping page.
Source
Direct Link to Image Page (if available, eg at BHL or HathiTrust. Do not duplicate main source-level link or link to a pdf):
then "If your image is not from a publication:" and include the fields you have now. I would alter the tooltip on Source link to say "Link to the original image location" though, since we're looking for the observation, not the literal hyperlink to the image itself.

Here is what I have now:

Behind the scenes, the "Direct Link to Image in Publication" and "Observation Link" are the same field so they can not both exist. I will add logic to the form that will prevent both from being filled out at the same time. My thoughts are, if a Source is selected then the Observation Link field will be disabled.

Here is what I have now:

Behind the scenes, the "Direct Link to Image in Publication" and "Observation Link" are the same field so they can not both exist. I will add logic to the form that will prevent both from being filled out at the same time. My thoughts are, if a Source is selected then the Observation Link field will be disabled.

That looks good although I think we should encourage ppl to fill out the bottom parts with an iNat or BG link. They're not really optional, even if they are technically available through the other site. That info could go down, etc, and we should credit photographers on our end too.
Also I can't tell if you've already coded it this way but license should be a dropdown, there's only a few possibilities for that.

There are actually an infinite number of options for photo licensing since anyone can write a license and grant it for a photo that they own copyright to. What I will do is come up with a list of licenses that we can support and only allow those. I think it is a subset of CC licenses plus Public Domain.

I suppose that's true but if 8 are good enough for iNaturalist then those 8 are good enough for us. Their list is:
No license (all rights reserved)
Attribution-NoDerivs
Attribution-NonCommercial NoDerivs
Attribution-NonCommercialShareAlike
Attribution-NonCommercial
Attribution
No Copyright (CC0)

I disagree. Those CC-N* licenses are troublesome. Until we get an entity other than me to take on legal responsibility for the hosting of the site I am only allowing:

Public Domain / CC0
CC-BY

There was a thread on the iNat forum recently that went over some of the issues with the CC-N* licenses: https://forum.inaturalist.org/t/a-case-for-changing-the-default-license-to-not-include-a-nc-clause/18690
I do not think that we can use CC-Attribution-NoDerivs since I have to scale the images so that we do not get killed with bandwidth costs on large images.
Basically, Creative Commons is a good idea, but is not well-executed and we have a very troubled and litigious society.

Ok, even simpler.
What kind of entity do we need to take legal responsibility? Isn't that why I incorporated the non-profit? Is there something else I need to do on that end?
How does this work for licensed images (ie not CC or public domain) we individually obtain permission to use though?

For individual permission we can track it in the Attribution field for now.
Currently the Digital Ocean, AWS, and Github, accounts are all setup under me personally. We would need to setup up accounts for all of these under the org and the transfer the resources. It is a good amount of work from the tech side. I want to stop using Digital Ocean. As part of that work, #48, I will setup a new AWS account and we can make that one owned by the org. Then I can figure out how to transfer the stuff that is in my AWS account over to that one.
As for GitHub I think we would need to create a user that represents the org. Then move the project over to that user away from me. Another alternative is to create an Org in GitHub, but that costs $4/user/month which quickly adds up.
I will look into all of this stuff more once we get the site to a stable point.

So just to be clear, this is what you have in mind? If I got permission from a user to use a licensed image, I would select All Rights Reserved in the License field and write "Photog Name (Used with permission)" in the Attribution field?
Let me know if you need any info about the org or if there's anything else you'd like my input on. I bet we could raise a small chunk of money per month on Patreon to cover monthly expenses if we found some that seemed really worthwhile.

Yes, that is what I am thinking.
Ok RE Org. I think what I will need from you, eventually, is that we will need to use contact info from the org etc. for setting up accounts. I will figure out when the time comes and let you know.

You mentioned having host relations pre-populate in #41--is that a relatively easy thing to do? I think it will get pretty tedious adding the same rights and attribution for dozens of images from the same source (exacerbated by the fact that I want to use the consistent name formatting whenever the same person appears in multiple fields so I am looking it up each time at the moment), so it seems like having those pre-populate as well and then allowing the user to replace them where needed would be very helpful. But if it's not easy to do then it's not a priority.

Similarly, you can select multiple images and delete them at once, but that doesn't seem to let you fill in the source/attribution info for multiple images at once. Is that something that can be easily changed?

The multi-select Edit should be doable without too much issue, though I have to think about how to show that you have multiple images selected when in the edit modal.
I can look at also having the fields prep-populate from data that exists for a pre-existing source-species-image.


Race condition with shared images leads to crash

Create a new scene with a Cesium3D Tileset with asset ID 2757071 from the CesiumJS Cesium ion account.
Double-click to zoom to it
Set the georeference origin to this location
Move the camera so you're closer to the tileset and in front of it.
If you haven't already crashed, click Refresh Tileset until you do.

The problem is that this tileset uses shared images, so multiple tiles refer to a single image. Each tile is loaded in a separate thread, so if two threads happen to, for example, hit generateMipMaps for the shared image at the same time, both will be trying to modify it simultaneously.
Possible solutions:

Set GltfReaderOptions::pSharedAssetSystem to nullptr so that images are never shared.
Detect shared images while doing Unity-specific resource prep and copy them for each tile.
Add actual support for shared images to Cesium for Unity.

The last is obviously the best by far, but may be a significant amount of work.

AFAICT Unity does not have any support for having one copy of a texture on the GPU and then accessing it using different sampling settings. We can use Graphics.CopyTexture to avoid re-uploading the texture from the CPU, at least.


fix: only escaping invalid data, keep valid escaping untouched

this commit avoid escaping twice for query already escaping

@Vkt0r Done

@SolaWing Please update the CHANGELOG.md file with a description of your changes.

@michaelenger done

@michaelenger done


Fix test running in Ruby 2.2.x

The tests will not currently run under Ruby 2.2.x.  This includes the test-unit gem to the Gemfile.  Also adds Ruby 2.1.0 and 2.2.0 to the .travis.yml file to make sure nothing breaks in the future for these versions.

Awesome. Thanks!


[11/10/22]: Refractor code to improve the UI of the site plus added functionalities for better UX(Mobile view).

Summary
First,  the OSCSA logo on the nav bar is too large with respect to the size of the nav bar itself. Second, the padding of the body contents is inadequate. Lastly, the images in the funders section are not well aligned.
Note: all these apply for mobile view.
What needs to be done?

[x] Reduce the size of the OSCSA logo.
[x] Increase the padding of the Open Science Practices section.
[x] Implement a marquee feature for the Funders section.
Greatly improves the interface and users experience.

Who want to work on this issue?
My name is Ebuka, I will like to be assigned to this, to offer my first contribution as an Outreachy intern.
@BatoolMM

@oEbuka i would like to  work on this, can you assign it to me


Update reactjs-components to 0.16.0-beta.13

This PR updates reactjs-components to 0.16.0-beta.13 which includes the following changes:

Specify c++ version for Travis build
Update stylelint deps
Make virtual list bind its onScroll function correctly
Fix modal height calculations in IE11
Explicitly set dropdown positioning properties to auto
Push commit and tags in release script
Properly remove event listener

Checklist

[ ] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

run unit tests

There's a legit unit test failing here. I'm debugging now.

run unit tests

works great, and built and tested it locally

Same here!

Retest this please


Add params_to_tune method

🚀 Feature Request
For AutoML track we need knowledge of hyperparameters to tune for Transformers and Models and Pipelines.
We should add method params_to_tune to all classes.
Proposal

Add default method for Transform and *AbstractModel's it should return empty dict
Add to method to AbstractPipeline
Add method for Pipeline it should iterate over transforms and model and collect all params.
Add implementation for Ensemble and Stacking - raise NotImplementedError
return value of params_to_tune is supposed to be like

 params = {
    "model.n_iterations": optuna.distributions.CategoricalDistribution((10, 100, 200)),
    "transforms.0.mode": optuna.distributions.CategoricalDistribution(("per-segment", "macro")),
}

Test cases

check  default implementation for  Transform and Models
check if Pipeline correctly combine params
check if Ensemble and Stacking rise error

Additional context
No response

Closed by #1073.


Remove browserid

This removes the support of browserID. If this is interesting for you...
I've tested and the owner of the instance can still use the "self-login" authentication method.
Collaborators can login using Facebook (if enabled).
I've fixed a bug in the file login.php (the "facebook" CSS class was missing for the "Facebook connect" button.

@cedricbonhomme Thanks for this PR. Can you branch off master and cherry-pick 28331f2 and re-open this PR from that branch? The first commit is in your other PR which I left a comment on.

Yes, sorry for the mistake I just did a new PR. A a branch remove-persona and cherry-pick 28ee1f2

PR replaced by PR #1589.


No logging for deleteEmptyDirs plugin

The mentioned plugin is lacking logging.
The submitted PR adds info level logging

It's been two months, I'm going to close this.


Check marks

Verify that the mark entered is within 0 and full marks for the test.

This can be done by adding constraints to the table itself in hsql.  Check to see how the Table Control deals with entries that exceed constraints.


Questions about the released dataset

Hi, thanks for your great contribution of the dataset. When I download  cc3m, the index of my images seems different from yours.

for example, when point to '0000000/0000008.jpg', the caption of mine is "# of the sports team skates against sports team during their game .", while the 'raw_caption' of yours is ''modern luxe has a very simple look , and offers a bold monogram of the couple 's initials .".  I download CC3M via img2dataset.
I think providing another file with 'image_path' and its respective 'url' is a potential solution. Can you provide it? Thanks!!

It is a good question.
I have provided a json file in google drive, and the example of this file is:

https://drive.google.com/file/d/1iRaYLxrW_pHODzMpvIvjSNfpsM_9OGiL/view?usp=sharing
Moreover, we will release CC12M in this week~
Best
Kecheng

Thank you for your great work. I tried to used your google drive link but it shows me below.
Can you share the valid link for "cc3m_path2url.json" again?

We have updated the CC3M&12M files as follows: 3 types of short captions have been added, and we replace 'path' to image ‘url’ in these csv files.
CC3M:
https://drive.google.com/file/d/1RPcFS8jrVolA9RzHXD581E8BxR7jYDap/view?usp=sharing
CC12M:
https://drive.google.com/file/d/12iUhceznPNWd-l_bGSF5rSnzdruP4Jtr/view?usp=sharing


glad to learn your article

I'm very  interested  in your article, expect your code updating! So when it come?

Hi Rossichan. I am also very eager to share my code, only to wait for the company's permission. I will work on this after the current project's deadline (Jan 2023). Additionally you can refer to this repository since this is my code base.

Thanks for your response and look forward to your results!

Thanks for your response and look forward to your results!

Hi, Rossichan. We have uploaded the code just now.

It's so surprised your project becomes complete, and i have some trouble after enjoying your work, such as what's the processing data step1: the raw log file , i can't find it

It's so surprised your project becomes complete, and i have some trouble after enjoying your work, such as what's the processing data step1: the raw log file , i can't find it

Hi Rossichan. Sorry for replying late. I am not sure what do you mean by "raw log file"? Could you elaborate more? You may directly download the whole processed dataset instead


Added support for multiple base URLs

Added support for multiple base URLs for multiple servers (with different domain names) running in same environment. Done for both 2.x & 3.x

sheehan » grails-console #143 FAILURE
Looks like there's a problem with this pull request
(what's this?)

:+1:


collapse_data_source method fixed

method now drops rows with duplicate identifiers and duplicate body response
in case of duplicate identifiers where one response is empty, keeps only row with non-empty response
there has been no rows with duplicate identifier and non-duplicate non-empty response found yet, but might need to solve it later

@DominikMartinat I think that it would be better to fix this in the relevant annotators, as the number of columns might not be the same across different annotators. (L92: columns[4:])

@tabbassidaloii I know. This way it works with 4 or more columns. First four are for the mapping data frame frome BridgeDB. The rest is output from database query. But I can fix it in annotator itself too.

The output of BridgeDb does not always have 4 columns. Now we also support the differential expression table, meaning that the input has multiple columns and therefore, the BridgeDb file would have more than 4 columns

Ah I understand now. Thanks for explanation. I will fix it in annotator then.

Ah I understand now. Thanks for explanation. I will fix it in annotator then.

@DominikMartinat Thank you too :)
I think implementing the drop before merging would make more sense. I mean dropping the duplication in the query output.


Resource Update: PLT_CAR_L5AC_A00 pedestal_size_z

Hi everyone,
This is an update PR for resource PLT_CAR_L5AC_A00 based on the data I gathered and showcase in this video:

Old pedestal_size_z = -5.0 mm.
The data shows a 95% confidence interval between 4.68 - 4.78 mm.
I therefore change it to the mean pedestal_size_z = -4.74.

@fderop, thought I might tag you directly because our a little back and forth regarding updating this attribute is what inspired me to gather this data.
In the end your value of 4.76 is very much in the confidence interval identified 😊

thank you Camillo
For posterity, just so it's clear: the image above links to youtube: https://www.youtube.com/watch?v=_uPf9hyTBog

@fderop, thought I might tag you directly because our a little back and forth regarding updating this attribute is what inspired me to gather this data.
In the end your value of 4.76 is very much in the confidence interval identified 😊

Awesome, thank you @BioCam


feat: create basonta church  groups

mutations for creating basonta church groups.
Description

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
I tested it locally.

Screenshots/Videos (if appropriate):
https://www.loom.com/share/cac250c4c93b487eb84fef3715d781e5 - Mutation for creating a ministry
https://www.loom.com/share/25e986de7d0d4a7e8e02b8d8e2c4dac8 - Mutation for creating a hub
https://www.loom.com/share/b1bd19f75715405c85a249569c037094 - Mutation for creating a sonta
https://www.loom.com/share/61d61b325f1141a7a8de5711b4420a27 - Mutation for creating a basonta

@AsiakN can you close this and reopen the PR to the branch for admin-497?


[#135948443] Fix name of java buildpack.

What
The package was renamed in CF v246[1]. This omission wasn't an obvious
problem for existing deployments because the buildpack had already been
uploaded, however for a clean deployment the java buildpack would be
missing. For existing deployments it means that the buildpack wouldn't have
been updated from the previous version.
[1]https://github.com/cloudfoundry/cf-release/commit/72222a8
How to review
Do a fresh deploy from master and verify that the java buildpack is present.
Who can review
Anyone but myself or @combor

The change makes sense and the test ensures that it works. I will merge.

👍  for test.

For existing deployments it means that the buildpack wouldn't have been updated from the previous version.

Should we warn tenants about this?


Suggestions for #1093

This PR is closed to keep it out of the PR list. See this commit for suggested changes: https://github.com/wxt-dev/wxt/pull/1168/commits/6830b78eb6083bb251e1785a1457e187c52c8354
CC @windmillcode0 here are my suggested changes. Will close and push to your PR if you enabled maintainers to push to it.

This PR is closed to keep it out of the PR list. See this commit for suggested changes: https://github.com/wxt-dev/wxt/pull/1168/commits/6830b78eb6083bb251e1785a1457e187c52c8354


i18n(es): Adds microcms.mdx

What kind of changes does this PR include?

New or updated content
Translated content

Description

What does this PR change? Give us a brief description.
Creates translated cms/microcms.mdx

LGTM ✅


Revert "B-21636 Update PPTAS LOA Fields"

Reverts transcom/mymove#14234
reverting per team request

I'll be the annoying one - requesting merge to int first since it isn't a hotfix

@cameroncaci here are the INT reverts
https://github.com/transcom/mymove/pull/14354
https://github.com/transcom/mymove/pull/14355

I'll be the annoying one - requesting merge to int first since it isn't a hotfix

@cameroncaci here are the INT reverts
#14354 #14355

INT reverted
@cameroncaci


<asset> in routes should not be case sensitive

done here https://github.com/CounterpartyXCP/counterparty-core/pull/2041/commits/304af795d2d4481e4282e63b5951b757f0486b27


[KYUUBI #1699] Improve codahale metric

Why are the changes needed?

Improve the codahale metric registered in MetricsSystem.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[x] Add screenshots for manual tests if appropriate

Before:

After:

[x] Run test locally before make a pull request

thanks, merged to master


Adds myself as codeowner for various administration things.


Fix attribute behavior for  and  (both centered="true" and shadowed="true")

Makes centered="true" and shadowed="true" both work (separately or together) for <h1> and <h2> elements.
Consolidates common code from HeadingOneTagElement and HeadingTwoTagElement into new, parent HeadingTagElement class

Before:

After:

Github web interface confusing me... just adding this comment for no great reason.


Add .nf to Groovy file extensions

Add .nf extension to Groovy file extensions (so nextflow files are detected as Groovy)
This PR fixes #106017
Replaces #106018

Thanks @nvuillam !


feat(gridsome): Add more details to settings section

Right now we are still missing a few things from old hub:

Environment variable form
Default value
"How to Use" section

target-redshift is a good example to review as well https://github.com/meltano/hub/blob/main/_data/meltano/loaders/target-redshift/transferwise.yml https://hub.meltano.com/loaders/target-redshift
Confirming key things to display:

environment variable form <plugin_name>_<setting_name>
default value
description (in YAML file)
How to use section can be autogenerated based on the setting name and either the default or the kind (integer, password, etc.)

How to use section can be autogenerated based on the setting name and either the default or the kind (integer, password, etc.)

From #663 - I'm not sold that we shouldn't have this section as-is, but currently there are no instructions on the preview. I'm fine with either recreating what we have or having instructions on setting with --interactive, but we need to have something. We can take another post-launch iteration on what we want there for each setting. @aaronsteers @rwfeather does that work?

@tayloramurphy - How about a simple "Configuration" header after settings list, with instructions for --interactive as per the below:

Settings
The dbt-postgres settings that are known to Meltano are documented below. To quickly find the setting you're looking for, click on any setting name from the list:
project_dir
profiles_dir
host
user
password
port
dbname
schema
keepalives_idle
search_path
role
sslmode
You can override these settings or specify additional ones in your meltano.yml by adding the settings key.
Please consider adding any settings you have defined locally to this definition on MeltanoHub by making a pull request to the YAML file.
Configuration
All of the below settings can be configured by running meltano config set {plugin_name} --interactive
[...Dynamic settings list here...]

But instead of {plugin_name}, it would be the actual plugin name. I can mock this up real quick if this works for you.

A small alteration on the paragraph above could be:

All plugin settings can be configured by running meltano config set {plugin_name} --interactive or with environment variables.

This gives users a clear and simple suggestion to use --interactive, while also sending them to the appropriate pages to learn more if they want to do it another way. While it's a critical feature for advanced users, I don't really want to be promoting env variables in the Hub because it leads to confusion in the new-user experience, when we want users to have a clear "golden path" without unnecessary distractions or hurdles.

@aaronsteers love that suggestion and it works for me 👍


Build a Python driver to submit DPC++ generated SPIR-V kernels to a device

We can build a small driver function that uses dpctl.program to submit DPC++-generated SPIR-V kernels to a device.

Such a driver program should technically be part of a tools directory in numba-dpex rather than dpbench. Closing this issue here and we will track it with numba-dpex.


Kotlin gradle syntax checker

Please add a license.
The IsAvailable() function is not needed.
You don't need to escape spaces in errorformat.
You don't need an exec in CreateAndRegisterChecker() if it's the same as name.

On second thought, it's probably better for you to maintain this outside syntastic.  I have only a vague idea what Kotlin is, and I can't really test that your checker works at all.  Sorry, but no.


Update gpw

Use Dataset class
Check for updated data to import

Added COG conversion to dataset class implementation for this pipeline, did a full run into pre_geo for testing and moved resulting data into geo (no new ingest needed since data / file structure did not change)


Setting necessary for allowing custom authentication/transport for http backend

Current architecture does not allow for any other authentication than 'static' HTTPBasicAuth user+password. It is impossible to authenticate MJML server via API Keys, OAuth2, custom auth header without monkey-patching or forking the code.
Simplest idea: there could be provided a new MJML_HTTP_TRANSPORT setting with a string being dotted module path to a transport function, accepting kwargs: url, auth, data, headers, timeouts.
Such a config would allow users to procure custom authentication inside and call requests.post or any other transport from user's code. If not provided, requests.post could be used as-is.
Using dotted path string will avoid importing this function in settings.py - this follows typical django pattern. The transport function can be imported lazily before use through django.utils.module_loading.import_string

@alex-kowalczyk  Is there any MJML backed that uses API Keys or OAuth2?

@liminspace I don't think that backends support that authentication directly, but it is quite common for self-hosted setups to host services behind authentication proxy, for instance with OAuth2-based JWTs in Google Cloud. Custom transport allowing to plug any authentication would be useful to integrate with such self-hosted backends.

@liminspace would you be open for a PR for this?
We are hosting the MJML function in AWS Lambda with an API Gateway and one easy way to limit access to it would be to add ApiKey Auth.
There are 2 ways I seed that could handle this use-case:

adding a different key to the settings (like API_KEY) and simply add it to the headers in https://github.com/liminspace/django-mjml/blob/main/mjml/tools.py#L119 (but this would be maybe too specific)
allow HTTP_AUTH to be whatever is accepted by requests, and not just a tuple.

I think the 2nd solution would be easy to implement and non-breakable. If you’re willing to consider it, I can propose a PR.

@Alexerson sure, you can show your solution and I'll take it in implementing the feature

Thanks. See PR.


Spurious change to abstract modifier

// Global.scala
package scala.tools.nsc
class Global

// Analyzer.scala
package scala.tools.nsc
package typechecker
trait Analyzer extends AnyRef with StdAttachments {
  val global : Global
}

// StdAttachments.scala
package scala.tools.nsc
package typechecker
trait StdAttachments { self: Analyzer =>
  type UnaffiliatedMacroContext = scala.reflect.macros.contexts.Context
  type MacroContext = UnaffiliatedMacroContext { val universe: self.global.type }
}

// Context.scala
package scala.reflect.macros
package contexts
import scala.tools.nsc.Global
abstract class Context {
  val universe: Global
}

// Macros.scala

package scala.tools.nsc
package typechecker
trait Macros { self: Analyzer =>
  val _openMacros = List[MacroContext]()
}

compile (compile everything)
add whitespace to Macros.scala and run compile; observe:

[diff] -val _openMacros: scala.collection.immutable.this#List[scala.reflect.macros.contexts.this#Context {abstract val universe: scala.tools.nsc.typechecker.Macros.this#global}]
[diff] +val _openMacros: scala.collection.immutable.this#List[scala.reflect.macros.contexts.this#Context {override abstract val universe: scala.tools.nsc.typechecker.Macros.this#global}]

I have not succeeded at minimizing this further yet. For example, annotating _openMacros's type explicitly makes the problem go away. The same goes if I change RHS to List[MacroContext](): List[MacroContext]) (!!!)

Possibly related to sbt/sbt#726 that was also about spurious changes to override flag.

I managed to minimize it a bit more by getting rid of dependency on List. It turns out that for some reason repeated parameters are involved. If I change foo to be def foo[A](): Foo[A] = null then the bug goes away. 😳

I've encountered this problem in scala/scala repo. The workaround I found is to explicitly annotate return type of a var:
diff --git a/src/compiler/scala/tools/nsc/typechecker/Macros.scala b/src/compiler/scala/tools/nsc/typechecker/Macros.scala
index bcf9e01..e6b14bd 100644
--- a/src/compiler/scala/tools/nsc/typechecker/Macros.scala
+++ b/src/compiler/scala/tools/nsc/typechecker/Macros.scala
@@ -496,7 +496,7 @@ trait Macros extends MacroRuntimes with Traces with Helpers {
   /** Keeps track of macros in-flight.
    *  See more informations in comments to `openMacros` in `scala.reflect.macros.whitebox.Context`.
    */
-  var _openMacros = List[MacroContext]()
+  var _openMacros: List[MacroContext] = Nil
   def openMacros = _openMacros
   def pushMacroContext(c: MacroContext) = _openMacros ::= c
   def popMacroContext() = _openMacros = _openMacros.tail

I suspect that the problem we're seeing with abstract modifier and refinements is another manifestation of https://issues.scala-lang.org/browse/SI-7361?focusedCommentId=63662&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-63662
With a known workaround that's not too bad and expected high effort to fix this (if possible at all), I'm putting this on the back-burner for now.


[BUG] access token needs to be stored again

User feedback from yesterday's hands-on workshop: apparently, the arc remote accesstoken get ... needs to be repeated, if one uses a different network / wifi.
I was unable to reproduce this error, but multiple users had to redo this step although the computer was already token authorized.

Hey @Brilator,
to my understanding, the token stored should not be dependent on the network. @j-bauer, any idea what might be the issue behind this?

I was also surprised...

Any updates on this?
I don't think that this is something the ArcCommander can fix, so I would close this issue.

Not sure. I ran into this issue repeatedly when using arc commander on a fresh machine, recently.
Can close for now, but might have to re-open with the next workshop series.

Maybe this is an issue of the lifetime of the token. I think it's set to just 2 hours or something. @j-bauer?

I will try to reproduce the issue but can you give me some information on how the problem arises? Or just a timestamp when it happened to look at the logfiles in that time range. Just get a token from the ARC commander and try to use it x minutes later until the unauthorized errors appear?
The issue is most likely related to the lifetime of the token issued by GitLab, not the token issued by Keycloak. The ARCC requests a token from GitLab directly. The user is then redirected to Keycloak to login but that is only for GitLab to authenticate the user. When that is done, GitLab issues the token itself and does not forward/re-use the Keycloak token. In other words, the Keycloak lifetime configuration does not impact the lifetime of the GitLab token directly. There is no configuration parameter to configure the lifetime of the GItLab token as far as I can see in the documentation. However, the usual mechanism in oAuth/OIDC is the use of refresh tokens, which seems to be the recommended way to handle this particular problem:
Here is the relevant part from the documentation about expiring tokens:
https://docs.gitlab.com/ee/integration/oauth_provider.html#access-token-expiration
There it is stated, that we should use the refresh token to retrieve a new access token after it expired:
https://docs.gitlab.com/ee/api/oauth2.html#authorization-code-flow (3. bullet point).
That should be the approach to aim for. @HLWeil we can do a live coding session where we tackle that problem? It shouldn't be too hard to implement in the ARC Commander.

Maybe this is also of help/interest to you guys:
I recently tried to sync an local arc with the datahub. I retrieved my accesstoken using Arc Commander version 0.5.0 via arc remote token get, and initiated the push via arc sync. The upload failed, I assume that my token also expired before the task finished.
Here are the logs:
2023-11-22 18:00:12.0406 GitSyncLog TRACE: Push
2023-11-22 18:00:12.0406 ExecuteGitCommandLog TRACE: Run git push -u origin main
2023-11-22 18:00:14.1916 ExecuteGitCommandLog INFO: GIT: warning: redirecting to https://git.nfdi4plants.org/zimmer/NMJ.git/
2023-11-22 18:00:18.3712 ExecuteGitCommandLog INFO: GIT: Locking support detected on remote "origin". Consider enabling it with:
2023-11-22 18:00:18.3712 ExecuteGitCommandLog INFO: GIT:   $ git config lfs.https://git.nfdi4plants.org/zimmer/NMJ.git/info/lfs.locksverify true
2023-11-23 08:44:45.1594 ExecuteGitCommandLog ERROR: GIT: fatal: helper error (-1): User cancelled dialog.
2023-11-23 08:44:45.1897 ExecuteGitCommandLog INFO: GIT: bash: line 1: /dev/tty: No such device or address
2023-11-23 08:44:45.1897 ExecuteGitCommandLog ERROR: GIT: error: failed to execute prompt script (exit code 1)
2023-11-23 08:44:45.1897 ExecuteGitCommandLog ERROR: GIT: fatal: could not read Username for 'https://git.nfdi4plants.org': No such file or directory
2023-11-23 08:44:45.1897 ExecuteGitCommandLog INFO: GIT: Uploading LFS objects:  99% (159/160), 1.2 GB | 176 KB/s, done.
2023-11-23 08:44:45.1897 ExecuteGitCommandLog INFO: GIT: batch response: Git credentials for https://git.nfdi4plants.org/zimmer/NMJ not found.
2023-11-23 08:44:45.2023 ExecuteGitCommandLog ERROR: GIT: error: failed to push some refs to 'https://git.nfdi4plants.org/zimmer/NMJ'
2023-11-23 08:44:45.2023 ProcessCommandLog INFO: Done processing command.

Thanks @ZimmerD , that is indeed valuable information. It is most likely due to expiring access tokens as you hypothesized. With the timestamp, we can have a more detailed analysis of the logfiles to confirm that theory. I will update when we know more.


Allow custom CPU/RAM for nodes

Add options to group_vars/all.yml to specify CPU and RAM

This is resolved by PR #59


Update vue.md

update to support typescript

Don't both versions work in both TS and JS?

nope, It's complaining about the type definition not found.

I'm using VS Code

Can we just have the new version, rather than both, then happy to merge

Thing is I don't know if this is works in javascript. The one I have added is for typescript

It should be fine

Thanks


Fix to fflib_SObjectSelector.cls

Fix to fflib_SobjectSelector.cls  introduced in commit f8f41621e33b028ba0a81d33030359c33cad64d1

Canceling PR as issue was fixed elsewhere

Ooops sorry @ImJohnMDaniel  didn't spot this, its fixed now.

LOL.  No worries @afawcett.  No worries.  ;-)


Chunksize FutureWarning cannot be silenced without affecting "chunks"

What happened:
While fixing h5netcdf-changes over in xarray https://github.com/pydata/xarray/pull/6200 I found that those FutureWarnings cannot be silenced keeping current behavior.

chunks=None -> chunks=None with FutureWarning
chunks="h5py" -> chunks=True
chunks="h5netcdf" -> chunks=_get_default_chunksizes

What you expected to happen:
Silencing the FutureWarning keeping current behavior should be possible.
@dionhaefner Could you take a look here?

Actually I'm not quite sure whether we want to do chunks="h5py" -> chunks=None. The way I see it the proper migration is this:
f.dimensions = {"x": 1, "time": None}

# OLD

# uses h5py chunking and throws warning
f.create_dataset("foo", ("x", "time"))  # could also be chunks=True

# no unlimited dims -> no warning
f.create_dataset("foo2", ("x",))  # could also be chunks=True

# NEW

# keep using h5py chunks, no warning
f.create_dataset("foo", ("x", "time"), chunks="h5py")

# no unlimited dims -> no warning (unchanged)
f.create_dataset("foo2", ("x",))

The distinction between chunks="h5py" and chunks="h5netcdf" is only relevant if unlimited dimensions are present. In this case, chunking is mandatory anyway. So the question boils down to: what do we want this to do?
# no unlimited dimensions present, so this would be unchunked by default
f.create_dataset("foo2", ("x",), chunks="h5py")

I think the path of least confusion is to treat this like chunks=True. Since something is passed to the chunks keyword I would interpret this as "the user wants chunking". But if you disagree I'm fine with changing it to h5py's chunks=None.

@dionhaefner I appreciate this comprehensive representation of the different possibilities. I mostly agree and I think your outlined solution might be the way to go. But do you have a solution at hand for those users, who do not want to use the new default chunking after we switch to it?

That's essentially my last code snippet, which boils down to

If your variable has unlimited dimensions, use chunks=h5py.
If not, just keep using what you are using now.

This recipe should work in all cases to keep the current behavior.
For the record, I also like your suggestion of a chunking_heuristic keyword that would side-step these subtleties, and that could go through a similar depreciation cycle (start with chunking_heuristic=None which defaults to h5py and emits a warning if unlimited dimensions are present, then switch to chunking_heuristic="h5netcdf" at 1.0).

Thanks! Let's reconvene early next week for a decision.

I the light of upcoming h5netcdf v1.0 our solution should be bullet proof to be sustainable over the lifetime of v1.0.
As we've seen handling those subtleties can be quite challenging and it might lead into a dead-end at some point in time. There is another solution which should at least be considered, an options-object. Several Python packages are using config/options one way or the other and in our situation it would really help simplifying things.
So my suggestion would still be using chunk_heuristics, but as a kwarg of that options-object.
Minimal implementation:
H5NETCDF_OPTIONS = {"chunk_heuristics": "h5py"}

class set_options:
    """Set options for h5netcdf.

    Parameters
    ----------
    "chunk_heuristics : {"h5py", "h5netcdf"}, default: "h5py"
        Heuristics used, if chunking is needed or requested.
    """

    def __init__(self, **kwargs):
        self.last_options = {}
        for k, v in kwargs.items():
            if k not in H5NETCDF_OPTIONS:
                raise ValueError(
                    f"{k!r} is not a valid option. Valid options are {set(H5NETCDF_OPTIONS)}."
                )
            chunk_heuristics_options = set(["h5py", "h5netcdf"])
            if k == "chunk_heuristics" and v not in chunk_heuristics_options:
                errmsg = f"Expected one of {chunk_heuristics_options!r}"
            else:
                errmsg = ""
            if "Expected" in errmsg:
                raise ValueError(f"invalid value {v!r} for option {k!r}. " + errmsg)
            self.last_options[k] = H5NETCDF_OPTIONS[k]
        self._update_options(kwargs)

    def _update_options(self, new_options):
        H5NETCDF_OPTIONS.update(new_options)

    def __enter__(self):
        return

    def __exit__(self, type, value, traceback):
        self._update_options(self.last_options)

def get_options():
    """Get options for h5netcdf."""
    return Frozen("H5NETCDF_OPTIONS")

use current default ("h5py"), will trigger the future warning
import h5netcdf
with h5netcdf.File(tmp_local_netcdf, "w") as ds:
    ds.dimensions = {"x": 10, "y": 10, "z": 10, "t": None}
    v = ds.create_variable(
        "hello2", ("x", "y", "z", "t"), "float", chunks=None
    )

set options "h5py" (will not trigger the future warning)
import h5netcdf
h5netcdf.set_options(chunk_heuristics="h5py)
with h5netcdf.File(tmp_local_netcdf, "w") as ds:
    ds.dimensions = {"x": 10, "y": 10, "z": 10, "t": None}
    v = ds.create_variable(
        "hello2", ("x", "y", "z", "t"), "float", chunks=None
    )

use "h5py" with context (will not trigger the future warning)
import h5netcdf
with h5netcdf.set_options(chunk_heuristics="h5py):
  with h5netcdf.File(tmp_local_netcdf, "w") as ds:
      ds.dimensions = {"x": 10, "y": 10, "z": 10, "t": None}
      v = ds.create_variable(
          "hello2", ("x", "y", "z", "t"), "float", chunks=None
      )

The above will work the same way with chunk_heuristics="h5netcdf".
The major advantage over our other possible solutions is that almost no code has to be changed. It boils down to only one line -> setting the option.

I think global options make sense (and I use them in a lot of projects), but IMO it's a bit awkward if you only have 1 option to set :)
If you have several things in mind that would make sense to access through it, sure, go for it. Otherwise I think it's still good design to use the chunk_heuristic keyword, and add that to a global options object later if there is demand for one. I don't think people usually have dozens of different calls to create_variable with unlimited dimensions, so it's probably a O(1) line change anyway.

And in terms of bullet proofness, I agree. So we probably should implement that chunk_heuristic keyword, and not overload chunks. But whether or not that can also be set through an options object is a separate discussion, isn't it?

And in terms of bullet proofness, I agree. So we probably should implement that chunk_heuristic keyword, and not overload chunks.

Yes, it would be very difficult handling an overloaded chunks keyword.

But whether or not that can also be set through an options object is a separate discussion, isn't it?

Yes, we can separate that and move that in at any later point.

Sorry, fat fingers...

Do you want me to do that in #150 or will you do it in #148?

Do you want me to do that in #150 or will you do it in #148?

I can do it tomorrow in #148. If you have additional cycles to do it in #150, please go ahead. Thanks.

Resolved with #150


OpenAPI Evaluation lib

I've created a library for evaluating HTTP request and response messages according to an OpenAPI 3.1 spec. It uses JsonSchema.NET for JSON instance evaluation. Have a look, I'd love some feedback!
https://github.com/Fresa/OpenAPI.Evaluation
https://github.com/Fresa/OpenAPI.Evaluation.AspNet

@Fresa have you seen Graeae?
I'll have a look at yours.  Thanks for mentioning it!

I have glanced at it, but I haven't tried it. I should :)
I've extended the Json Schema output format to include request and response evaluation path and introduced parameter value parsers to support parameter evaluation, those might be the most interesting parts, I've written an article about it here https://blog.fkan.se/net/openapi-evaluation/


Reorganize project and expose internals

This project has solved a lot of problems other linux distribution would need to solve to properly package golang. I'm curious if its beneficial to reorganize the project and expose the internals so it's easier to reuse the code.
Any thoughts on this?

Which parts specifically would be interesting to you?

Everything from these seems usefull:

description.go
estimate.go
metadata.go
progress.go

And from make.go:

upstream struct
debianNameFromGopkg

I have plans to attempt package golang packages in Arch Linux the same way debian does it.

Okay. I’m not opposed to doing this, but have little time right now.
I would recommend:

copy the files into your project for the time being
report back once you have a working tool
report any changes you needed to make, if any (my gut feeling is that some changes might be needed)
we can clean up and expose the pieces of code you needed
you can remove the copied files and we can collaborate on any improvements going forward

Does that sound reasonable?

I think forking this project and working with it as a library is a better move. Easier to get an overview of the changes made and what could be merged back into the project.
Rest of it is completely reasonable and i'll gladly contribute the needed patches.


guacone files needs to emit identifier strings to collectsub service

Currently, guacone's ingest function does not handle identifier strings. It should do so an emit entries to the csub server when it can.

This could be done as part of #719  CLI rework.

Yea. It would not talk to NATs but directly to the csub server, which is
part of the parser logic. It’s just not been updated to do so, more of an
oversight in implementing the Collectsub
On Wed, Apr 19, 2023 at 11:55 AM Jeff Mendoza @.***>
wrote:

Which ingest? guacone files?
I would think guaccollect files would be the one we want to talk to
nats/csub and guacone files would be GQL-only?
—
Reply to this email directly, view it on GitHub
https://github.com/guacsec/guac/issues/745#issuecomment-1514977574, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXLDBT4P4UCZODI7E3B2Q3XCADGTANCNFSM6AAAAAAXDMECKU
.
You are receiving this because you authored the thread.Message ID:
@.***>


fix zero division error when there are no numeric columns (fixes #143)

When there are no numeric columns in the dataframe, ProfileReport() errors with a zero division error. Fix this issue (#143) by checking if the correlations dataframe is empty, before generating the correlation plot.

@JosPolfliet Are you still looking for maintainers for the package? I am interested and would like to know how I can contribute to maintaining the package.


Cannot build on Kernel 4.9

Hello,
I'm running OpenSuse Tumbleweed with Kernel 4.9 and can't build the module:
# wget -O /tmp/evdi.zip https://github.com/DisplayLink/evdi/archive/devel.zip
# unzip /tmp/evdi.zip
# cp -r evdi-devel/module/ /usr/src/evdi-devel
# dkms add evdi/devel

Creating symlink /var/lib/dkms/evdi/devel/source ->
                 /usr/src/evdi-devel

DKMS: add completed.
# dkms build evdi/devel

Kernel preparation unnecessary for this kernel.  Skipping...

Building module:
cleaning build area....(bad exit status: 2)
make KERNELRELEASE=4.9.0-2-default all INCLUDEDIR=/lib/modules/4.9.0-2-default/build/include KVERSION=4.9.0-2-default DKMS_BUILD=1....(bad exit status: 2)
Error! Bad return status for module build on kernel: 4.9.0-2-default (x86_64)
Consult /var/lib/dkms/evdi/devel/build/make.log for more information.

# cat /var/lib/dkms/evdi/devel/build/make.log
DKMS make.log for evdi-devel for kernel 4.9.0-2-default (x86_64)
Sun Jan  8 11:54:48 CET 2017
make KBUILD_VERBOSE=1 SUBDIRS=/var/lib/dkms/evdi/devel/build SRCROOT=/var/lib/dkms/evdi/devel/build CONFIG_MODULE_SIG= -C /lib/modules/4.9.0-2-default/build modules
make[1]: Entering directory '/usr/src/linux-4.9.0-2-obj/x86_64/default'
make -C /usr/src/linux-4.9.0-2-obj/x86_64/default KBUILD_SRC=/usr/src/linux-4.9.0-2 \
-f /usr/src/linux-4.9.0-2/Makefile modules
mkdir -p /var/lib/dkms/evdi/devel/build/.tmp_versions ; rm -f /var/lib/dkms/evdi/devel/build/.tmp_versions/*

  WARNING: Symbol version dump ./Module.symvers
           is missing; modules will have no dependencies and modversions.

make -f /usr/src/linux-4.9.0-2/scripts/Makefile.build obj=/var/lib/dkms/evdi/devel/build
  gcc -Wp,-MD,/var/lib/dkms/evdi/devel/build/.evdi_drv.o.d  -nostdinc -isystem /usr/lib64/gcc/x86_64-suse-linux/6/include -I/usr/src/linux-4.9.0-2/arch/x86/include -I./arch/x86/include/generated/uapi -I./arch/x86/include/generated  -I/usr/src/linux-4.9.0-2/include -I./include -I/usr/src/linux-4.9.0-2/arch/x86/include/uapi -I/usr/src/linux-4.9.0-2/include/uapi -I./include/generated/uapi -include /usr/src/linux-4.9.0-2/include/linux/kconfig.h -I/usr/src/linux-4.9.0-2//var/lib/dkms/evdi/devel/build -I/var/lib/dkms/evdi/devel/build -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -std=gnu89 -fno-PIE -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -m64 -falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387 -mpreferred-stack-boundary=3 -mskip-rax-setup -mtune=generic -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args -DCONFIG_X86_X32_ABI -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 -DCONFIG_AS_FXSAVEQ=1 -DCONFIG_AS_SSSE3=1 -DCONFIG_AS_CRC32=1 -DCONFIG_AS_AVX=1 -DCONFIG_AS_AVX2=1 -DCONFIG_AS_AVX512=1 -DCONFIG_AS_SHA1_NI=1 -DCONFIG_AS_SHA256_NI=1 -pipe -Wno-sign-compare -fno-asynchronous-unwind-tables -fno-delete-null-pointer-checks -Wno-frame-address -O2 --param=allow-store-data-races=0 -Wframe-larger-than=2048 -fstack-protector -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-var-tracking-assignments -pg -mfentry -DCC_USING_FENTRY -fno-inline-functions-called-once -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -Werror=implicit-int -Werror=strict-prototypes -Werror=date-time -Werror=incompatible-pointer-types -DCC_HAVE_ASM_GOTO  -I/usr/src/linux-4.9.0-2/include/drm  -DMODULE  -DKBUILD_BASENAME='"evdi_drv"'  -DKBUILD_MODNAME='"evdi"' -c -o /var/lib/dkms/evdi/devel/build/.tmp_evdi_drv.o /var/lib/dkms/evdi/devel/build/evdi_drv.c
In file included from /usr/src/linux-4.9.0-2/arch/x86/include/asm/realmode.h:5:0,
                 from /usr/src/linux-4.9.0-2/arch/x86/include/asm/acpi.h:33,
                 from /usr/src/linux-4.9.0-2/arch/x86/include/asm/fixmap.h:19,
                 from /usr/src/linux-4.9.0-2/arch/x86/include/asm/apic.h:11,
                 from /usr/src/linux-4.9.0-2/arch/x86/include/asm/smp.h:12,
                 from /usr/src/linux-4.9.0-2/include/linux/smp.h:59,
                 from /usr/src/linux-4.9.0-2/include/linux/percpu.h:6,
                 from /usr/src/linux-4.9.0-2/include/linux/percpu-rwsem.h:6,
                 from /usr/src/linux-4.9.0-2/include/linux/fs.h:30,
                 from /usr/src/linux-4.9.0-2/include/linux/seq_file.h:10,
                 from /usr/src/linux-4.9.0-2/include/linux/pinctrl/consumer.h:17,
                 from /usr/src/linux-4.9.0-2/include/linux/pinctrl/devinfo.h:21,
                 from /usr/src/linux-4.9.0-2/include/linux/device.h:24,
                 from /usr/src/linux-4.9.0-2/include/linux/dma-mapping.h:6,
                 from /usr/src/linux-4.9.0-2/include/drm/drmP.h:37,
                 from /var/lib/dkms/evdi/devel/build/evdi_drv.c:10:
/usr/src/linux-4.9.0-2/arch/x86/include/asm/io.h:43:31: fatal error: asm/early_ioremap.h: No such file or directory
 #include <asm/early_ioremap.h>
                               ^
compilation terminated.
make[4]: *** [/usr/src/linux-4.9.0-2/scripts/Makefile.build:295: /var/lib/dkms/evdi/devel/build/evdi_drv.o] Error 1
make[3]: *** [/usr/src/linux-4.9.0-2/Makefile:1495: _module_/var/lib/dkms/evdi/devel/build] Error 2
make[2]: *** [Makefile:150: sub-make] Error 2
make[1]: *** [Makefile:24: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/linux-4.9.0-2-obj/x86_64/default'
make: *** [Makefile:22: all] Error 2

The same issue happens with the sources included in the ubuntu package that can be downloaded from the displaylink website.

As you can download commits as patches on github, you can also just download this patch and apply it after extracting.

@daugustin thanks a lot for your reply. Please correct me if I'm wrong, but I guess what the linked patch does is already in the files isn't it?
https://github.com/DisplayLink/evdi/blob/devel/module/evdi_connector.c#L147-L150
https://github.com/DisplayLink/evdi/blob/devel/module/evdi_modeset.c#L375-L377
I also tried to apply the patch in the reverse order with
patch -p1 -R < b7606bccc0cb9484c2845a3e556faf60ed3c0bff.patch
but still the same error occurs.

Oh sorry, didn't realize you were already using devel and not the provided evdi zip.

Should be fixed in 793a65a

@displaylink-mlukaszek correct me if I'm wrong, but that commit is already in devel branch which couldn't be compiled in my case (please note that the link wgetted above is the zip from current devel branch)

@bonanza123 note it was not pushed onto devel branch before I commented.

@bonanza123 Have you got it to work on openSUSE Tumbleweed 42.3 ?

@hjaltioj I actually followed the versions provided in the repo https://github.com/sinfomicien/displaylink-evdi-opensuse and particularly in the issue https://github.com/sinfomicien/displaylink-evdi-opensuse/issues/4


Patch mysql vendored curl for CVE-2023-23914

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patch vendored curl for CVE-2023-23914
Change Log

Patch vendored curl for CVE-2023-23914
Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-23914

Test Methodology

Pipeline build id: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=372497&view=results

Is there a way we can switch to system curl ?

Thanks Sumedh Alok Sharma for pointing out mysql is building with WITH_CURL=none so there's no need to patch it, closing this


As you stated, only the merge commit is associated with the pull request, so it's very difficult to try to handle commit overrides in the plain merge case.

          As you stated, only the merge commit is associated with the pull request, so it's very difficult to try to handle commit overrides in the plain merge case.

We highly recommend squash-merging (to keep a linear history and ensure every commit in the release branch is stable). We will update the docs to reflect this.
Originally posted by @chingor13 in https://github.com/googleapis/release-please/issues/1899#issuecomment-1502061231

          As you stated, only the merge commit is associated with the pull request, so it's very difficult to try to handle commit overrides in the plain merge case.

เราขอแนะนำอย่างยิ่งให้รวมสควอช (เพื่อเก็บประวัติเชิงเส้นและให้แน่ใจว่าทุกคอมมิชชันในสาขาการเผยแพร่นั้นเสถียร) เราจะอัปเดตเอกสารเพื่อสะท้อนสิ่งนี้
โพสต์ดั้งเดิมโดย@chingor13ใน#1899 (ความคิดเห็น)


Timeout for PDI_example_decl_netcdf_C

See https://gitlab.maisondelasimulation.fr/pdidev/pdi/-/jobs/25466
703/721 Test #703: PDI_example_decl_netcdf_C ...........................................................................................................................................................................***Timeout   5.01 sec
[PDI][Decl'NetCDF][000000][15:34:00] *** info: Plugin loaded successfully
[PDI][Decl'NetCDF][000001][15:34:00] *** info: Plugin loaded successfully
[PDI][MPI][000000][15:34:00] *** info: Plugin loaded successfully
[PDI][MPI][000001][15:34:00] *** info: Plugin loaded successfully
[PDI][Decl'NetCDF][000002][15:34:00] *** info: Plugin loaded successfully
[PDI][000001][15:34:00] *** info: Initialization successful
[PDI][000000][15:34:00] *** info: Initialization successful
[PDI][MPI][000002][15:34:00] *** info: Plugin loaded successfully
[PDI][000002][15:34:00] *** info: Initialization successful
iter=      0; time=  0.153; next_reduce=      2

In GitLab by @ksiero on Feb 5, 2021, 10:55
I think we have few information what is going on here. This error is not deterministic, I would wait for trace logger level in PDI example (needs a feature to load different yaml file, e.g. from ENV variable).


Smeltery Crash/bug : March 6th 2015

When you scroll over the lava in the smeltery controller or put lava into the seared tank you will crash your client. (this could be why some bases you can't go to if they auto inject lava into the smeltery)

Crash report?

Here is the log, it is at the very bottom of it
http://paste.atlauncher.com/view/398d2ba1

Ah typical render issue lol. Forges fault. Gonna have to wait until Cauldron updates its forge version to at least 1384 before I put this fix in.

Resolved as of version 2.2.19-2


Installation Docs

Your install docs say in Step 2:
Change files in public/pages and public/config.php
But, change them to what?
Also, public/pages is a folder, what are u supposed to change?

See updated version http://sphido.org/docs/installing


About the question_answer?

How can I test the model in the QA task? Just input the text like " How many teeth do humans have?"  or if i need to add the prefix,like "QA: How many teeth do humans have?"

I found these prefixes in the examples provided in the GitHub:
bioasq4b: ...
bioasq5b: ...

It doesn't work. However, I find the input data format of the QA task for the t5 model, for example, "question*: .... context*: .... ".

Did you use the fine tuned model (SciFive) with T5 prefixes? Was it better than T5 itself?

The paper shows that both have similar results. And the model(SciFive) is a trained t5 model.


quick question about smoother transitions

is it possible to (a) turn off loading message and (b) continue rotation during scene fade out?
Great library thanks, and good documentation / examples

(a) Is you use a multiresolution panorama, there's no loading message.
(b) This isn't possible, since the fade is done by saving a rendered frame from WebGL and then fading the captured image; after the fade starts, the original panorama can no longer be rendered.


Copy updates for np beta flow

Task/Issue URL: https://app.asana.com/0/488551667048375/1205145153997777/f
Description
Design/copy updates
Steps to test this PR
QA optional

Current dependencies on/for this PR:

develop

PR #3431   👈

This comment was auto-generated by Graphite.


Crash

man nc
Then page to the end, then repeatedly hit "b", it crashes here:
        precondition(start < self.count)
with start = 188
count = 111

shiftElements sometimes increases count beyond the maxLength, which looks like a bad issue.

Fixed in 94a954a