Notification feature

Related Issuse

no notification feature

Closes: #435
Describe the changes you've made

added notification model
added getNotifications route in the new controller file
added the corresponding route in the notification route file

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.(Specially for Backend)
[x] My changes generate no new warnings.

Screenshots

Original
Updated

no getNotifications route

@mitalirs Resolve conflict as well.

done

@mitalirs Resolve conflict as well.


[AutoRelease] t2-network-2022-08-25-91575(Do not merge)

https://github.com/Azure/sdk-release-request/issues/2985
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1031
BuildTargetingString
azure-mgmt-network
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/2985


Add dotnet-template tag

I have created a "dotnet-template" tag in github, can you add the tag to this repository so it shows up in the dotnet-template search result?

I don't have the necessary permissions on this repo.
@Eilon, could you add the dotnet-template topic to this repo? Instructions here: https://help.github.com/articles/classifying-your-repository-with-topics/

Done!

Thanks


Empty game list or only one game is showing up ("Space War")

The server that SAM pulls its game list from is currently down as of July 27th, 2022.
The server that SAM pulls its game list from is currently online.
I'm working on resolving this, but as a temporary workaround, you can manually add games to SAM.

Search for your game on SteamDB.info.
On that game's page, there is an App ID. This is the ID you need.

For example: For Team Fortress 2, the ID is 440.
In SAM, in the top left next to Refresh Games you can enter this App ID.

Next to where you entered the App ID, click Add Game.

Assuming you own the game, it will show up.

Same here, but it resolved by itself after a while

This may be happening for some people currently, site was migrated to a new server today/yesterday.

This is currently occurring, will be fixed as soon as possible.

it is currently happening to me! blank screen only showing Spacewar. Was fine a few days ago

Thanks for being ontop of this.

Is there a rough estimate on how long this will take? My SAM has been like this for the past few days when it was fine at the beginning of this week.

@KariRenaeRose No current ETA. If you need to use SAM, you can manually add games. Instructions are in the first post.

Any plans on updating SAM so we don't need to constantly redownload all the thumbnails for the games each time we open SAM? I remember there was talk about this ages ago about having it be stored locally. Can we store the images in the SAM folder?

I m also getting the problem hope it will be fixed soon but for now i will just follow the steps

You can also see the game ID by right clicking it in your Library, going to Properties, then go to the Updates tab.

This has been an issue for a few weeks, when are you hoping to resolve it?

@anusface It has not been an issue for a few weeks. It's been an issue since Monday the 16th.

@anusface A few weeks, tf you talking about? Only been like this for under a week.

how much longer can it take?

Just wanted to say thank you Gibbed for this tool.

The problem still exists ...
Until a few days ago, the program worked properly, but for some time now, it no longer works like before and does not show any games in its list, and this is very bad.

keeps saying i do not own the game :/ any possible fix?

@Tobbeishere If you are getting this error trying to add a game per the instructions and you actually do own this game, you probably have an alternate region version with a different application ID.
What game are you trying to add?

Wow I cannot believe people are still asking the question why its not working, using the game ID and adding the game works just fine, you have not paid for it so be patient and stop being a snot nosed child whining!

Wow I cannot believe people are still asking the question why its not working, using the game ID and adding the game works just fine, you have not paid for it so be patient and stop being a snot nosed child whining!

its not that serious

The server is online again.

Right now I am having issues with the black screen, did I do something wrong?

This is currently occurring, will be fixed as soon as possible.

Can't wait for it to be fixed. Been down for awhile. I hope it isn't Steam doing it. This is very needed due to 80% of the games I play are messed up.

It's not Steam. There are instructions on manually adding games in the issue post itself.

Can't wait for it to be fixed. Been down for awhile. I hope it isn't Steam doing it. This is very needed due to 80% of the games I play are messed up.

It's not Steam. There are instructions on manually adding games in the issue post itself.

does it work when i am using family share? i am trying to edit the achievements of a game i have because of family share, but its saying i don't own the game

Thank you for the work you do. ♥

I see this issue is back. Hopefully it gets fixed soon. Thank you!
Question: I have always wondered why the list of the games you own isn't stored/cached locally instead of having to generate it every time the program is launched? When you have hundreds or even 1K+ games on your account that's also a lot of thumbnail images to download.

This issue is @gibbed 's White Whale from Moby Dick. Thing keeps popping up like a weasel in that bop 'em game. Thanks for trying to fix. I'm sure there are other things you'd rather be doing than getting spammed with messages about the same issue year after year lol.

Thanks for the notice. The work you do is much appreciated!

The server is online again as of yesterday, March 17th, 2022.

This is currently occurring, will be fixed as soon as possible.

This is currently occurring as of today, July 27th, 2022, will be fixed as soon as possible.
I forgot to update when access was last restored, so it looks a bit odd now.

Again same issue with the only game appearing is "SpaceWar"

Today not even showing one single game...

for me the game popped up right away after I added it and made me skip step 5, it worked

thank you so much, I was wondering what was happening here... how often is this type of outage going to happen?

Can't wait for it to be fixed. Been down for awhile. I hope it isn't Steam doing it. This is very needed due to 80% of the games I play are messed up.

It's not Steam. There are instructions on manually adding games in the issue post itself.

does it work when i am using family share? i am trying to edit the achievements of a game i have because of family share, but its saying i don't own the game

Exact same thing is happening to me :( as of August 1st 2022

does it work when i am using family share? i am trying to edit the achievements of a game i have because of family share, but its saying i don't own the game

Exact same thing is happening to me :( as of August 1st 2022

Repentance does not have achievements nor stats. Rebirth does.

does it work when i am using family share? i am trying to edit the achievements of a game i have because of family share, but its saying i don't own the game

Exact same thing is happening to me :( as of August 1st 2022

Repentance does not have achievements nor stats. Rebirth does.

even with that being that case, it happens with rebirth also, but i can check again

The server is online again as of August 2nd, 2022.

As per today, it is not showing any game list, is this because of the server again ?

same problem happened today. is it come from server things again?

Est-ce que ça marche quand j'utilise le partage familial ? J'essaie de modifier les succès d'un jeu que j'ai grâce au partage familial, mais il indique que je ne possède pas le jeu

Il m'arrive exactement la même chose :( à partir du 1er août 2022

La repentance n'a pas de succès ni de statistiques. La renaissance, oui.

même si c'est le cas, cela arrive aussi avec la renaissance, mais je peux vérifier à nouveau edit : j'ai donc vérifié, tous mes jeux s'affichent maintenant, mais SAM.game.exe ne s'ouvre pas. edit 2 : j'ai donc trouvé une solution (ou je suis stupide) si j'exécute SAM.game.exe en tant qu'administrateur et non SAM.picker, alors cela fonctionne

I have the same problem as you, on half of my games, but despite the solution you gave, I still have the same problem. 2 months ago it was still working


Support Active Job

Works just like regular Sidekiq jobs.
Open Questions, and Problems

[ ] There's a fair bit of duplication going on. In the Rails version of Active Job, it more clearly wraps the Sidekiq Client with an Active Job Client. Perhaps I should refactor this solution accordingly? On a similar note, perhaps these changes should live an entirely different library that merely consumes this one?
[x] This PR assumes #4 is merged

The more I think about this, the more I'm convinced that this shouldn't live in this package. I'm going to close the PR and start a new project to handle Active Job concerns.


calling ad sp credential list  returns empty

When calling  az ad sp credential list it returns  empty value but after renewing a password for the first time it shows the correct value.
To Reproduce
Create a spn and then call
 az ad sp credential list --id {app id}

then renew a password for the spn and call the above command again
Expected behavior
It should show the expiry date of spn before renewing the password.
After further investigation I noticed the command is calling below url:
'https://graph.windows.net/tenant/applications/{objectid}/passwordCredentials?api-version=1.6'
which is the same url for  az ad app credential.
It should call
'https://graph.windows.net/tenant/serviceprincipals/{objectid}/passwordCredentials?api-version=1.6'
What's more ,if url of serviceprincipal is called it doesn't return the latest expiry date after renewing the password which is another issue.
azure-cli                         2.32.0

@jiasli for awareness

az ad sp credential list does the same thing as az ad app credential list. This is the designed behavior (https://github.com/Azure/azure-cli/issues/11458). We plan to rectify this behavior in Microsoft Graph migration (https://github.com/Azure/azure-cli/issues/12946).

What's more ,if url of serviceprincipal is called it doesn't return the latest expiry date after renewing the password which is another issue.

I will keep this in mind and take a look during Microsoft Graph migration.

I suspect that I am hitting this issue. The output of az ad sp credential list --id "$SP_ID" --query "[].endDateTime" -o tsv is the expiration time of the original credentials. These have been reset months ago, but im still seeing the old date.
I need to figure out in advance which cluster credentials need to be reset soon. After wrestling with the ms graph API for a while (filtering should not be that hard, right) I decided to give the updated az-cli a try.
az ad sp show --id $SP_ID

# ...
#  "passwordCredentials": [
#    {
#      "endDateTime": "2022-02-16T17:55:54.2217355Z",
#      "keyId": "...",
#      "startDateTime": "2021-02-16T17:53:08.7185779Z"
#    }
#  ],

The credentials are already reset, but all I can see are the original ones. This is not exactly ideal, any ways to get around this problem?
These docs are no longer up to date too: https://docs.microsoft.com/en-us/azure/aks/update-credentials#check-the-expiration-date-of-your-service-principal

The issue is from Graph api because by using powershell you'll see the same issue.
The workaround is to use
az ad app credential

If it's empty then use
az ad sp show

The issue is from Graph api because by using powershell you'll see the same issue. The workaround is to use
az ad app credential

If it's empty then use
az ad sp show

Thanks, I didn't think of this. Its decent as far as workarounds go :)

I encounter the same issue, is any updates

@tonystz, which issue did you encounter? az ad sp credential list missing credentials or showing credentials that shouldn't be there?

Hello. I also get empty response on az ad sp credential list --id <<sp.appId>>.
When I search for the service principal in portal, I was able to found the expiry info and obfuscated secret under AAD->Apps Registrations->Certificates and Secrets
$ az version
Azure-cli    Azure-cli-core    Azure-cli-telemetry
-----------  ----------------  ---------------------
2.38.0       2.38.0            1.0.6

Azure Portal can only show app's credential, not service principal's. Use az ad app credential list to get the same behavior as Azure Portal.

The docs for az ad sp credential say:

The credential update will be applied on the Application object the service principal is associated with. In other words, you can accomplish the same thing using "az ad app credential".

Which is not correct if az ad app credential list is managing a separate set of credentials as az ad sp credential.

This issue still appears to be occurring with the latest version.  az ad app credential list and az ad sp credential both return empty results.  The scripts mentioned here seem to be operating as intended but it is cumbersome to have to go to a specific PS 5.1 only module to get this working.
Even alternatives Get-AzAdServicePrincipal or Get-AzAdSpCredential don't seem to work as expected.

This issue still appears to be occurring with the latest version. az ad app credential list and az ad sp credential both return empty results. The scripts mentioned here seem to be operating as intended but it is cumbersome to have to go to a specific PS 5.1 only module to get this working.

An additional complication I have noticed while investigating this is that it takes a while after I use az ad app credential reset before the new credential shows up in the Azure portal.
With the hidden/undiscoverable nature of sp-specific credentials. the misleading documentation and the lag before changes display in the portal, Microsoft couldn't have designed a more confusing and frustrating system if they tried!


System tests: use generated client for DM API

Feature Request
The project should include a generated client for the Data Management API, which should be used in system tests (instead of RestAssured).
Which Areas Would Be Affected?
System tests
Why Is the Feature Desired?

Greatly reduce the verbosity, and improve the clarity of system tests
Ensure the scope of system tests is not integration testing of the controllers, that can be done in specific RestAssured tests
Provide a client module in Maven that can be directly used by end users running on JVM
Dogfood our OpenAPI definition

Solution Proposal
We've had good results with openapi-generator-maven-plugin, the equivalent plugin exists for Gradle.
Type of Issue
Improvement
Checklist

[ ] assigned appropriate label?
[x] Do NOT select a milestone or an assignee!

@paullatzelsperger @ndr-brt @bscholtes1A a penny for your thoughts on this :)

Having an EDC REST client would be great, I never got the chance to try the openapi generator, but looking forward for that.

@paullatzelsperger @ndr-brt @bscholtes1A @zeier I built a quick spike at https://github.com/agera-edc/DataSpaceConnector/pull/249. Happy for your comments and feedback on proposed decision points.

https://github.com/agera-edc/DataSpaceConnector/pull/249
Objectives

Develop a REST client module with generated code from the OpenAPI definition, and use it in system tests
Reduce the verbosity, increase the maintainability and improve the clarity of system tests
Ensure the scope of system tests is not integration testing of the controllers, that can be done in specific RestAssured tests
Provide a client module in Maven that can be directly used by end users running on JVM
Dogfood our OpenAPI definition

Results

The org.openapi.generator plugin appears to work reliably as part of the build, and is fast (8 seconds).

The plugin generates an entire gradle project in the build/ directory. We have the option:

Running the plugin manually and committing the files we want, as we are doing for the OpenAPI definition.
Run the plugin as part of every build, and simply add the generated src/main/java folder to the source set.

Since the execution is fast, we opted for the latter option here.

In EDC, we standardise on OkHttpClient and Jackson. The plugin can use various HTTP client libraries and JSON serialisation frameworks. If generating for OkHttpClient, only GSON serialisation can be used. This means that new generated DTO classes must be used on the client side.
The generated DTO classes are mutable, and are created with this style: new MyDto().field1(value1).field2(value2)
An alternative would be to use the native Java HttpClient (Java 11+) and Jackson serialisation. We could then reuse the existing DTO classes. We would then have to refactor existing data management API modules to separate DTOs from services into separate packages.

Decisions

Reuse existing DTOs or generate new DTOs? For quality purposes, my recommendation would be to avoid reusing DTO classes and use generated ones. This ensures that the client behaves exactly and only as specified in the OpenAPI definition, so that the Java client does not have any difference to any other client generated for another language.
Commit generated client code, or regenerate on build? My recommendation would be to regenerate the client on build. This keeps the repo lean, ensures the code is always up to date and does not get manually modified. The time impact is very modest, and should be hardly noticeable in practice thanks to gradle build parallelism and caching.
Choice of client library: My recommendation would be to use the native HttpClient rather than OkHttpClient to maximise portability and reduce client code size (OkHttpClient pulls in Kotlin). Clients who would want the additional advanced features of OkHttpClient would anyway be sophisticated enough that having to regenerate their own client from the OpenAPI definitions would hardly be an issue.

This is currently blocked by https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/issues/1264

@algattik in my opinion this would have been useful, will someone work on it?

@ndr-brt work on this would require first #1264 to be resolved


Resetting index.js

Since this scratchpad file is used through the XState course, I'm resetting it back to how it looked when the course starts so students can code along with the scratch pad examples.

Thank you!


DMG over SMB Share

When uploading a DMG over an SMB share the plist that is generated is (null)-(null).xxx
This worked a few versions back when you explicitly fixed it in one of the prior versions.  Since then the change may have regressed.

Thanks for reporting, I've seen this occasionally too. Is this happening every time you import items, for certain types of items or is it random?

This is happening for me on pretty much all dmg imports of certain packages. The one I'm wrangling with now is TeamViewer QS.


As a developer, I want documentation on testing the landing page (github pages) locally, so that I don't have to test in production

https://github.com/ethereum/grid/tree/master/docs
it's published. you may want to test it to see how accurate it is. My environment is biased :)


Handle re-throws with "throw;"

Handle re-throws with throw; in catch-block.
try
{
    throw new InvalidOperationException();
}
catch(InvalidOperationException)
{
    // Assumes "InvalidOperationException"
    throw;
}

And for:
try
{
    throw new InvalidOperationException();
}
catch
{
    // Assumes "Exception"
    throw;
}

Actually, would be great if the analyzer could know what exceptions are rethrown with catch  { throw; }

Would be nice if the analyzer would know what exceptions are rethrown with catch  { throw; } and tell you to handle them.

Need to check this.

Rethrows in explicit catch statement with exception types have not been handled since last change. I think I know how to get it back. There is a placeholder telling it to ignore. Just have to copy some code from below.
I have made the change, and the existing tests pass. Need to write new ones for this too.

Fixed stuff in #51. This is sufficient for now.


ts-api-utils and tslib dependencies should be used or removed

Dependencies should be included for a reason. These are included but not used:

https://www.npmjs.com/package/ts-api-utils
https://www.npmjs.com/package/tslib

Either they should be used in the example main.ts or removed.

This has already been discussed.
tslib is a runtime library for TypeScript importHelpers. When this compiler option is enabled, you need to ensure that the tslib module is available at runtime.
For an explanation about ts-api-utils, please see https://github.com/jsynowiec/node-typescript-boilerplate/issues/37 and https://github.com/jsynowiec/node-typescript-boilerplate/issues/44.

Thanks for your prompt response. I understand what the libraries are, i'm questioning the need for them.
https://www.npmjs.com/package/tslib and importHelpers configuration reduces code size when compiling to es2015, but your project uses es2022.
For example:
git clone https://github.com/jsynowiec/node-typescript-boilerplate.git
cd node-typescript-boilerplate
npm install
npm run build
cat ./build/src/main.js

Then update tsconfig.json value"importHelpers": false and then:
npm run build
cat ./build/src/main.js

Notice nothing has changed in the built main.js file.
Then update tsconfig.json valueES2015 and then:
npm run build
cat ./build/src/main.js

Notice the bloat code is there for es2015, so tslib is useful for es2015.
I didn't try every helper method in: https://github.com/microsoft/tslib/blob/main/modules/index.js
but my assumption is many of these are not needed when compiling to es2022

I appreciate your comment. Because this project has been around for 8 years now, and went through many updates and switched over several Node and TypeScript LTS versions and ES targets, this indeed may be an obsolete artifact now. I will take a look at some point if it is fine to remove, and it does not break anything.
However, I am still convinced that ts-api-utils needs to stay pinned. It is used by, for example, eslint. In the past, there were at least a few non-obvious problems related to version incompatibilities with the old tsutils, what ts-api-util replaces, and the linter and its dependencies.


Update updates page for DCP 40

New projects (3):

Dandelion uses the single-cell adaptive immune receptor repertoire to explore lymphocyte developmental origins
Dynamic scRNA-seq of live human pancreatic slices reveals functional endocrine cell neogenesis through an intermediate ducto-acinar stage.
Human SARS-CoV-2 challenge resolves local and systemic response dynamics

Updated Projects (30):

A single-cell atlas of human teeth
Single-Cell Transcriptomics of the Human Endocrine Pancreas
Single-cell RNA-seq reveals ectopic and aberrant lung-resident cell populations in idiopathic pulmonary fibrosis
Single-cell multi-omics analysis of the immune response in COVID-19
Single-cell transcriptomes identify human islet cell signatures and reveal cell-type–specific expression changes in type 2 diabetes
Anomalous Epithelial Variations and Ectopic Inflammatory Response in Chronic Obstructive Pulmonary Disease
Comparative Analysis and Refinement of Human PSC-Derived Kidney Organoid Differentiation with Single-Cell Transcriptomics
Genetic ancestry effects on the response to viral infection are pervasive but cell type specific
Human oral mucosa cell atlas reveals a stromal-neutrophil axis regulating tissue immunity
Local and systemic responses to SARS-CoV-2 infection in children and adults
Molecular characterization of foveal versus peripheral human retina by single-cell RNA sequencing
Organoid single-cell genomic atlas uncovers human-specific features of brain development
Pathogen-induced tissue-resident memory T H 17 (T RM 17) cells amplify autoimmune kidney disease
Resolving the intertwining of inflammation and fibrosis in human heart failure at single-cell level
Single cell RNA sequencing of human liver reveals distinct intrahepatic macrophage populations
Single cell profiling of COVID-19 patients: an international data resource from multiple tissues
Single-Cell Analysis of Human Pancreas Reveals Transcriptional Signatures of Aging and Somatic Mutation Patterns
Single-Cell Heterogeneity Analysis and CRISPR Screen Identify Key β-Cell-Specific Disease Genes
Single-Cell Transcriptome Profiling of Human Pancreatic Islets in Health and Type 2 Diabetes
Single-Cell Transcriptomics of a Human Kidney Allograft Biopsy Specimen Defines a Diverse Inflammatory Response
Single-cell RNA sequencing identifies celltype-specific cis-eQTLs and co-expression QTLs
Single-cell RNA sequencing reveals profibrotic roles of distinct epithelial and mesenchymal lineages in pulmonary fibrosis
Single-cell sequencing unveils distinct immune microenvironments with CCR6-CCL20 crosstalk in human chronic pancreatitis
Single-cell transcriptomes of the human skin reveal age-related loss of fibroblast priming
Single-cell transcriptomics reveals cell-type-specific diversification in human heart failure
Single-nucleus cross-tissue molecular reference maps toward understanding disease gene function.
Spatial proteogenomics reveals distinct and evolutionarily conserved hepatic macrophage niches
The Tabula Sapiens: A multiple-organ, single-cell transcriptomic atlas of humans
The single-cell transcriptomic landscape of early human diabetic nephropathy
scRNA-seq assessment of the human lung, spleen, and esophagus tissue stability after cold preservation

Complete


What is step-progess css class?

Hi,
I have seen in your documentation that this can be used in the application to use react-stepzilla:
<div className='step-progress'>
  <StepZilla steps={steps}/>
</div>

I am not fully sure if step-progress is CSS class coming as a part of the react-stepzilla npm package or this is a CSS class I have to create myself? (Just got confused as StepZilla component is rendered inside a div with a class).

@jagjitsingh700 It's just a class. It doesn't convey any purpose. There is no css attached to this class.


Release machinelearningservices microsoft.machine learning services 2024 10 01

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/azp run

@ragovada Please fix LintDiff and PrettierCheck errors.

/azp run

All looks good from my side, but please also get approval from breaking change committee.

No details in CI report for Python SDK breaking so added the approval label directly.

/azp run

/azp run

/azp run

Please fix Swagger LintDiff issues at https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4256339&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
I see the initial page for LintDiff is not showing any issues, but the check is failing.

/azp run

Please fix Swagger LintDiff issues at https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4256339&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
I see the initial page for LintDiff is not showing any issues, but the check is failing.

Looks like there are lot of errors and warnings in the lintdiff which is causing the tool to behave incorrectly. Please address the lintdiff issues.


TDI-37812 Snowflake component tests are not properly isolated.

Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[X] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
Tests fail when run concurrently because they used the same schema.
What is the new behavior?
Tests work when run concurrently (tested 3 concurrent tests)
Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
A couple of other small corrections. Also removed the running of the plain tests (by making it an abstract class), only the Spring and OSGi tests are being used.

LGTM


GH-230 Implement Sponge platform support

Closes #230
Hi, sorry for being super late!
Here is a Sponge 8 support (it's the latest stable API, included in all modern Sponge builds).
I added a ServerPlayer argument, ServerPlayer contextual and test /tp <player> [player] command. You can test it yourself using ./gradlew :examples:sponge:runServer. I also wanted to add a /gm command, but Sponge has... special... API design and I couldn't understand how to make proper suggestions (but the parsing was relatively fine). However, I believe it's enough for this platform.

It's the newly opened version of my previous PR. Changes in this one:

Based on newest master branch
Register ServerPlayerArgument and ServerPlayerOnlyContextual automatically, just like in Bukkit platform
Use MessageKey system to handle argument/contextual messages instead of using legacy contructor variant
Make ServerPlayerOnlyContextual return ServerPlayer, not Player

@BlackBaroness Thanks for your pull request. I tested all changes and fixed a few issues. There is also a new example of kick command 😸. Check out the new changes and give me your feedback if everything is okay with my changes (I don't have any experiences with the sponge platform.

Check out the new changes and give me your feedback if everything is okay

Everything looks good (I don't use Sponge either btw)
Did you test it? I believe I had errors when LiteSpongeCommand and LiteSpongePlatform were not public, that's why I did it like that. Sponge tried to access these classes for some reason

Check out the new changes and give me your feedback if everything is okay

Everything looks good (I don't use Sponge either btw)
Did you test it? I believe I had errors when LiteSpongeCommand and LiteSpongePlatform were not public, that's why I did it like that. Sponge tried to access these classes for some reason

Yeah, you are right. Sponge does not support package-private classes :/. I will fix that.


Does watcher notify if set the same value

I watch a key, and set the same value interval. Does the watcher call callback function every time if the value not changed?

yes. for this kind of questions, i would suggest you to read the doc first. or you can do some simple experiments on your local dev env. or you can post to the mailing list:https://groups.google.com/forum/?hl=en#!forum/etcd-dev.


add travis ci

i added some travis ci configuration.
it runs the test suite on every Pull Request and on every update or commit someone adds on the PR.
Github shows the result: passing with a green check mark or failing with a red X next to commits.
The integration badge on the readme tracks master branch since we want to display the passing or failing status of master, not PRs or other random branches:

since it's configured to my fork temporarily it needs to be updated. @sustrik, you can login to travis with your github credentials. You'll see a list of all your repos. Click the checkbox on libmill to activate the integration--it hooks into .travis.yaml and then we can update this  badge to point back here. At that point the ci integration begins.

Uh. No OSX for now. Which makes the whole exercise almost useless :( Anyway, I am merging the patch now and we'll wait whether OSX becomes available...
Thanks for the patch!

sure, when they stop the ban on os x repos, I'll ping you. btw an all lowercase readme.markdown is probably quicker to type than the old fashioned way

It's a matter of custom. Old-style hackers like me look for README, COPYING, AUTHORS and such.

ya totally the .md is a big step :+1:


Uncaught TypeError: Cannot read property 'expand' of undefined

[Enter steps to reproduce below:]

Enable: CTRL-ALT-O
Click a collection file in Configs -> lib -> collections

Atom Version: 1.7.4
System: Mac OS X 10.11.5
Thrown From: mantrajs package, v0.4.4
Stack Trace
Uncaught TypeError: Cannot read property 'expand' of undefined
At /Users/Nadeem/.atom/packages/mantrajs/lib/directoryHandler.coffee:87

TypeError: Cannot read property 'expand' of undefined
    at Function.module.exports.DirectoryHandler.revealActiveFile (/Users/Nadeem/.atom/packages/mantrajs/lib/directoryHandler.coffee:87:15)
    at HTMLLIElement.<anonymous> (/Users/Nadeem/.atom/packages/mantrajs/lib/mantra-pane-view.coffee:65:24)
    at HTMLLIElement.jQuery.event.dispatch (/Users/Nadeem/.atom/packages/mantrajs/node_modules/space-pen/vendor/jquery.js:4681:9)
    at HTMLLIElement.elemData.handle (/Users/Nadeem/.atom/packages/mantrajs/node_modules/space-pen/vendor/jquery.js:4359:28)

Commands
     -1:06.2.0 application:add-project-folder (atom-text-editor.editor.is-focused)
     -0:59.9.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -0:56.3.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:56.3.0 core:cancel (atom-text-editor.editor.mini.is-focused)
  3x -0:50.2.0 mantrajs:toggle (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "spell-check"
    ],
    "packagesWithKeymapsDisabled": [
      "atom-lupa",
      "tool-bar",
      "sync-settings",
      "atom-ternjs"
    ]
  }
}

Installed Packages
# User
Quick-JavaScript, v0.16.0
atom-bracket-highlight, v0.3.1
atom-ternjs, v0.14.1
autocomplete-modules, v1.4.1
docblockr, v0.7.3
emmet, v2.4.3
emmet-snippets-compatibility, v1.0.6
formatter, v2.12.3
formatter-jsbeautify, v1.0.2
highlight-column, v0.5.1
highlight-line, v0.11.1
language-babel, v2.24.1
lebab-convert, v0.9.0
linter, v1.11.4
linter-codeclimate, v0.1.2
linter-eslint, v7.2.2
linter-jscs, v4.0.2
mantrajs, v0.4.4
meteor-api, v2.20.0
opened-files, v0.3.6
react, v0.15.0
sync-settings, v0.7.2
tool-bar, v0.4.0
tool-bar-almighty, v0.6.1
underscorejs-snippets, v0.2.2

# Dev
No dev packages

It seems this happens if you toggle the project directory:
No exception if you click on a file:

Throws exception when you click on a file:

Having this issue as well. But when I select a file in a module.
It prevents me from using this great plugin :(


Document required values of GOMODCACHE (and maybe also GOPATH)

Apparently, in order to use Go plugins, you have to ensure that both the main binary as well as the plugin binary have been built with the same value of  GOMODCACHE (which defaults to $GOPATH/pkg/mod). See golang/go#63230. (Exception: If you use -trimpath as build option for building both binaries. But I assume this is not an option for krakend, as all current plugins would break if krakend introduced that parameter in their build chain).
This was a bit surprising to me, as the error message is also not very helpful (plugin was built with a different version of package golang.org/x/xerrors/internal or similar, since Go apparently considers the two plugin versions to be different because of a different file path ).
So it might be helpful to document the required values in https://www.krakend.io/docs/extending/writing-plugins/:

The value of GOMODCACHE should always be /go/pkg/mod (default is GOMODCACHE=$GOPATH/pkg/mod)
You usually only have to set this value manually if you use a different GOPATH than the default path /go
Tip: You can check go environment variables with go env GOMODCACHE or just go env (list all), since they are not necessarily set in the system's environment variables

Side note: Maybe it would make sense renaming that documentation page to "Building custom plugins"? Since it's more about the build setup and commands, and less about writing the actual code. I found that heading a bit misleading.

Hi @fxedel,
Renaming the heading to "building plugins" is a good suggestion. This page was originally about writing plugins, but it was split into multiple pages, and the title stayed.
About the GOMODCACHE  value, you are right, and because Go plugins are complex we offer a builder image, so developers do not need to care about this. If you faced this is because you are compiling plugins without any of the builders.
I think that adding this details, while we try that users use the builder, is adding unnecessary information.

Hi @alombarte, actually I was using the builder image, but I added the GOMODCACHE environment variable to speed up the build process. As I'm new to plugin development in Go, I was unaware that this caused the Go plugin to be unusable and it took me some time to identify GOMODCACHE as the cause of failure. Using the builder image actually removes the need for deep knowledge of Go plugins, so I think having a note on this environment variable would indeed be very helpful, especially for builder users.


Extendend whitelist options

Description
This PR fixes #1600 adding more whitelists to the configs
The most complex whitelist was the Shelley Stake Address as it stored in the table stake_address.
The functionality is if the stake address doesn't match in the whitelist on any of the inserts into the following tables, then we don't insert at all:

[x] collateral_tx_out
[x] delegation
[x] delegation_vote
[x] epochstake
[x] govaction_proposal
[x] instant_reward
[x] pool_owner
[x] pool_update
[x] reserve
[x] reward
[x] stake_deregistration
[x] stake_registration
[x] treasury
[x] treasury_withdrawal
[x] tx_out
[x] withdrawal

Checklist

[x] Commit sequence broadly makes sense
[x] Commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes are noted in the changelog
[x] Code is formatted with fourmolu on version <IP_ADDRESS> (which can be run with scripts/fourmolize.sh)
[x] Self-reviewed the diff

Migrations

[ ] The pr causes a breaking change of type a,b or c
[ ] If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
[ ] Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

Run into following error message with executable built from this branch, on sanchonet:
[db-sync-node:Error:68] [2024-04-09 19:18:08.57 UTC] Error SNErrDefault: "resolveGovActionProposal.queryGovActionProposalId missing GovAction (TxKey {unTxKey = SqlBackendKey {unSqlBackendKey = 1878}}, 0)" [db-sync-node:Info:68] [2024-04-09 19:18:08.57 UTC] Shutting down DB thread
Longer log:
[db-sync-node:Info:68] [2024-04-09 19:18:08.15 UTC] Insert Conway Block: epoch 241, slot 20899080, block 1045000, hash 63f067e9e3ea707046130d460f1ab5fa9b66a6e28a2b00db937b7919d92db6c4
[db-sync-node:Info:68] [2024-04-09 19:18:08.16 UTC] queryOrInsertRewardAccount: "e0e23ef55a0099f4f3c0bf172828424d91ae0d61ef2d1456ba59117f59"
[db-sync-node:Info:68] [2024-04-09 19:18:08.17 UTC] queryOrInsertRewardAccount: "e0e23ef55a0099f4f3c0bf172828424d91ae0d61ef2d1456ba59117f59"
[db-sync-node:Info:68] [2024-04-09 19:18:08.17 UTC] queryOrInsertRewardAccount: "e0e23ef55a0099f4f3c0bf172828424d91ae0d61ef2d1456ba59117f59"
[db-sync-node:Info:68] [2024-04-09 19:18:08.17 UTC] queryOrInsertRewardAccount: "e0e23ef55a0099f4f3c0bf172828424d91ae0d61ef2d1456ba59117f59"
[db-sync-node:Info:68] [2024-04-09 19:18:08.21 UTC] queryOrInsertRewardAccount: "e05d7925e67a3c06e73529044636347d622f825cfbf8f2901bce2a4076"
[db-sync-node:Info:68] [2024-04-09 19:18:08.23 UTC] queryOrInsertRewardAccount: "e0d7b6df431bcd4f6547370dd91a84b9f19baa531fed0050d06d3eccbf"
[db-sync-node:Info:68] [2024-04-09 19:18:08.23 UTC] queryOrInsertRewardAccount: "e0d7b6df431bcd4f6547370dd91a84b9f19baa531fed0050d06d3eccbf"
[db-sync-node:Info:68] [2024-04-09 19:18:08.23 UTC] queryOrInsertRewardAccount: "e0d7b6df431bcd4f6547370dd91a84b9f19baa531fed0050d06d3eccbf"
[db-sync-node:Info:68] [2024-04-09 19:18:08.23 UTC] queryOrInsertRewardAccount: "e0d7b6df431bcd4f6547370dd91a84b9f19baa531fed0050d06d3eccbf"
[db-sync-node:Info:68] [2024-04-09 19:18:08.43 UTC] queryOrInsertRewardAccount: "e08411259f67557f242a8a3ce67ad49533861d88619493b0d2909a85ce"
[db-sync-node:Info:68] [2024-04-09 19:18:08.44 UTC] queryOrInsertRewardAccount: "e08411259f67557f242a8a3ce67ad49533861d88619493b0d2909a85ce"
[db-sync-node:Info:68] [2024-04-09 19:18:08.44 UTC] queryOrInsertRewardAccount: "e08411259f67557f242a8a3ce67ad49533861d88619493b0d2909a85ce"
[db-sync-node:Info:68] [2024-04-09 19:18:08.44 UTC] queryOrInsertRewardAccount: "e08411259f67557f242a8a3ce67ad49533861d88619493b0d2909a85ce"
[db-sync-node:Info:68] [2024-04-09 19:18:08.46 UTC] queryOrInsertRewardAccount: "e0fbfde89e03ec91335ea6a634f5c0c25b23fc0ea5bf12b6ad38b5e4dd"
[db-sync-node:Info:68] [2024-04-09 19:18:08.46 UTC] queryOrInsertRewardAccount: "e0fbfde89e03ec91335ea6a634f5c0c25b23fc0ea5bf12b6ad38b5e4dd"
[db-sync-node:Info:68] [2024-04-09 19:18:08.47 UTC] queryOrInsertRewardAccount: "e0fbfde89e03ec91335ea6a634f5c0c25b23fc0ea5bf12b6ad38b5e4dd"
[db-sync-node:Info:68] [2024-04-09 19:18:08.47 UTC] queryOrInsertRewardAccount: "e0fbfde89e03ec91335ea6a634f5c0c25b23fc0ea5bf12b6ad38b5e4dd"
[db-sync-node:Info:68] [2024-04-09 19:18:08.48 UTC] queryOrInsertRewardAccount: "e0608b8ec1b50edf6973e68b882c0e316eb0aa003f26be94d8cfd29b22"
[db-sync-node:Info:68] [2024-04-09 19:18:08.49 UTC] queryOrInsertRewardAccount: "e0892f36af0ddfd1ab639143893140b513f96ed48f7759ee6e4a652818"
[db-sync-node:Info:68] [2024-04-09 19:18:08.49 UTC] queryOrInsertRewardAccount: "e0892f36af0ddfd1ab639143893140b513f96ed48f7759ee6e4a652818"
[db-sync-node:Info:68] [2024-04-09 19:18:08.49 UTC] queryOrInsertRewardAccount: "e0892f36af0ddfd1ab639143893140b513f96ed48f7759ee6e4a652818"
[db-sync-node:Info:68] [2024-04-09 19:18:08.49 UTC] queryOrInsertRewardAccount: "e0892f36af0ddfd1ab639143893140b513f96ed48f7759ee6e4a652818"
[db-sync-node:Info:68] [2024-04-09 19:18:08.51 UTC] queryOrInsertRewardAccount: "e01d036f6ffdaf8341c63e4cf02ce788f5bcecd9b517cae17d22a08b53"
[db-sync-node:Info:68] [2024-04-09 19:18:08.52 UTC] queryOrInsertRewardAccount: "e01d036f6ffdaf8341c63e4cf02ce788f5bcecd9b517cae17d22a08b53"
[db-sync-node:Info:68] [2024-04-09 19:18:08.53 UTC] queryOrInsertRewardAccount: "e01d036f6ffdaf8341c63e4cf02ce788f5bcecd9b517cae17d22a08b53"
[db-sync-node:Info:68] [2024-04-09 19:18:08.53 UTC] queryOrInsertRewardAccount: "e01d036f6ffdaf8341c63e4cf02ce788f5bcecd9b517cae17d22a08b53"
[db-sync-node:Info:68] [2024-04-09 19:18:08.56 UTC] queryOrInsertRewardAccount: "e0192a8eb77a6f405d8196dd96db13950c48300a0ff8b6f42e7901a2ef"
[db-sync-node:Info:68] [2024-04-09 19:18:08.56 UTC] queryOrInsertRewardAccount: "e0192a8eb77a6f405d8196dd96db13950c48300a0ff8b6f42e7901a2ef"
[db-sync-node:Info:68] [2024-04-09 19:18:08.56 UTC] queryOrInsertRewardAccount: "e0192a8eb77a6f405d8196dd96db13950c48300a0ff8b6f42e7901a2ef"
[db-sync-node:Error:68] [2024-04-09 19:18:08.57 UTC] Error SNErrDefault: "resolveGovActionProposal.queryGovActionProposalId missing GovAction (TxKey {unTxKey = SqlBackendKey {unSqlBackendKey = 1878}}, 0)"
[db-sync-node:Info:68] [2024-04-09 19:18:08.57 UTC] Shutting down DB thread

Another question would be - should we have validator for stake addresses in config whitelisting ?
    "shelley": {
      "enable": true,
      "stake_addresses": ["ABCDEF248f556b733c3ef24899ae0609d3796198d5470192304c4894dd85cb"]
    },

I used this and no errors on cardano-db-sync side.

@ArturWieczorek

run into following error message with executable built from this branch, on sanchonet
what version of cardano-node are you using at the moment I can't even get things to start syncing locally. I can see in the code where the issue is happening. Will try to get sanchonet working today 👍

Another question would be - should we have validator for stake addresses in config whitelisting
The problem with that is if you add the stake address before starting a fresh sync, there is no way to validate if it's existence as it's not been yet created.

@ArturWieczorek
what version of cardano-node are you using at the moment?

@Cmdv
For checking it I used:
cardano-node 8.9.0 - linux-x86_64 - ghc-9.6
git rev f7900cd232b33aa96e18e7a533454ce077d299c1

not sure if this is right - it seemed to work with this version.

I am using...
node:
./cardano-node version
cardano-node 8.9.1 - linux-x86_64 - ghc-8.10
git rev da945ea983d4722a9ffe54250edba9a193a57cf0

db-sync:
db-sync-node/bin/cardano-db-sync version
cardano-db-sync <IP_ADDRESS> - linux-x86_64 - ghc-8.10
git revision efa38c28ce7ebe666d2649299e38c4701dbca495

Network: sanchonet
Network Configs:
wget https://book.play.dev.cardano.org/environments/sanchonet/config.json \
  https://book.play.dev.cardano.org/environments/sanchonet/db-sync-config.json \
  https://book.play.dev.cardano.org/environments/sanchonet/submit-api-config.json \
  https://book.play.dev.cardano.org/environments/sanchonet/topology.json \
  https://book.play.dev.cardano.org/environments/sanchonet/byron-genesis.json \
  https://book.play.dev.cardano.org/environments/sanchonet/shelley-genesis.json \
  https://book.play.dev.cardano.org/environments/sanchonet/alonzo-genesis.json \
  https://book.play.dev.cardano.org/environments/sanchonet/conway-genesis.json

db-sync config:
  "insert_options": {
    "tx_out": {
      "value": "enable"
    },
    "ledger": "enable",
    "shelley": {
      "enable": true,
      "stake_addresses": ["e083d27f03b197750ee41b7dca02c806718164b934b0fbfa747349e8f2"]
    },
    "multi_asset": {
      "enable": true
    },
    "metadata": {
      "enable": true
    },
    "plutus": {
      "enable": true
    },
    "governance": "enable",
    "offchain_pool_data": "enable",
    "json_type": "text"
  },

OK, I think I got it something more.
So basically adding return address
sancho=# select * from gov_action_proposal limit 3;
 id | tx_id | index | prev_gov_action_proposal |  deposit   | return_address | expiration | voting_anchor_id |        type         |                                                                                description                                                                                | param_proposal | ratified_epoch | enacted_epoch | dropped_epoch | expired_epoch
----+-------+-------+--------------------------+------------+----------------+------------+------------------+---------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------+----------------+---------------+---------------+---------------
  1 |  1878 |     0 |                          |<PHONE_NUMBER> |           1024 |        251 |                1 | TreasuryWithdrawals | {"tag": "TreasuryWithdrawals", "contents": [[[{"network": "Testnet", "credential": {"keyHash": "248f556b733c3ef24899ae0609d3796198d5470192304c4894dd85cb"}},<PHONE_NUMBER>0000]], null]} |                |                |               |               |

in this case id=1024:
sancho=# select * from stake_address where id=1024;
  id  |                           hash_raw                           |                               view                               | script_hash
------+--------------------------------------------------------------+------------------------------------------------------------------+-------------
 1024 | \xe0192a8eb77a6f405d8196dd96db13950c48300a0ff8b6f42e7901a2ef | stake_test1uqvj4r4h0fh5qhvpjmwedkcnj5xysvq2plutdapw0yq69mccrcnd7 |
(1 row)

to stake_addresses whitelist:
      "stake_addresses": ["e083d27f03b197750ee41b7dca02c806718164b934b0fbfa747349e8f2","e0192a8eb77a6f405d8196dd96db13950c48300a0ff8b6f42e7901a2ef"]

Moved error past epoch 241:
[db-sync-node:Info:68] [2024-04-10 16:52:15.19 UTC] Starting epoch 243
[db-sync-node:Info:68] [2024-04-10 16:52:15.19 UTC] Insert Conway Block: epoch 243, slot 20995259, block 1048448, hash b1bbaf1289853643b930e143c20f88d02433804eaba473e071dff13f7aeaa617
[db-sync-node:Info:68] [2024-04-10 16:52:15.20 UTC]
Inserted epoch 242 from updateEpochWhenSyncing with Cache.
 epoch: Epoch {epochOutSum =<PHONE_NUMBER>9466, epochFees = DbLovelace 280783544, epochTxCount = 1411, epochBlkCount = 2974, epochNo = 242, epochStartTime = 2024-02-12 00:30:50 UTC, epochEndTime = 2024-02-13 00:29:06 UTC}
[db-sync-node:Info:76] [2024-04-10 16:52:15.24 UTC] Asynchronously wrote a ledger snapshot to ledger-state/sancho_whitelist/20995146-631926b413-242.lstate in 0.058838804s.
[db-sync-node:Info:68] [2024-04-10 16:52:15.74 UTC] Inserted 1 EpochStake for EpochNo 244
[db-sync-node:Info:68] [2024-04-10 16:52:16.97 UTC] Insert Conway Block: epoch 243, slot 21043666, block 1050000, hash e4ed716d1560fc7d3051b4da271410f31a28e233bb0c3462142fcd2950470f87
[db-sync-node:Error:68] [2024-04-10 16:52:17.55 UTC] Error SNErrDefault: "resolveGovActionProposal.queryGovActionProposalId missing GovAction (TxKey {unTxKey = SqlBackendKey {unSqlBackendKey = 4222}}, 0)"
[db-sync-node:Info:68] [2024-04-10 16:52:17.55 UTC] Shutting down DB thread

So if stake address for return_address is filtered out it will cause this exception.

@Cmdv  With latest version on this branch I am left stuck at Reached EpochNo 301 message.
I see that tables listed below are empty while the non whitelisted version of DB have records for them ( the common thing is that they have gov_action_proposal_id field ):
select * from constitution;
 id | gov_action_proposal_id | voting_anchor_id | script_hash
----+------------------------+------------------+-------------
(0 rows)

select * from new_committee_info;
 id | gov_action_proposal_id | quorum_numerator | quorum_denominator
----+------------------------+------------------+--------------------
(0 rows)

select * from new_committee;
 id | gov_action_proposal_id | deleted_members | added_members | quorum_numerator | quorum_denominator
----+------------------------+-----------------+---------------+------------------+--------------------
(0 rows)

select * from new_committee_member;
 id | gov_action_proposal_id | committee_hash_id | expiration_epoch
----+------------------------+-------------------+------------------
(0 rows)

select * from voting_procedure;
 id | tx_id | index | gov_action_proposal_id | voter_role | drep_voter | pool_voter | vote | voting_anchor_id | committee_voter
----+-------+-------+------------------------+------------+------------+------------+------+------------------+-----------------
(0 rows)

Also do not see records in those tables ( contrary to non whitelisted DB version )
off_chain_pool_data
off_chain_pool_fetch_error
off_chain_vote_fetch_error

@ArturWieczorek thanks a lot for the very thorough reports 🙏

With latest version on this branch I am left stuck at Reached EpochNo 301 message.
I wonder if it has something with stopping and restarting as I got to 301 last week and that was the tip but now we're on 306. So this morning I restarted and like you it was just not moving forward. I can't fully tell it's it's node not providing more data or something is going on on our side. Will investigate more.

This is related to plutus whitelisting.
So it's doesn't just whitelist against script hash, it also checks payment creds. Which was the existing functionality. I'm unsure as to the reasoning but it's functionality was kept. Code here

What I would like to see for this is

documentation about what db fields remain empty for the new options
what is the testing coverage, testing method and what combinations of networks and options were used
what ensures that if this options are not enabled, default db-sync schema is not affected by this pr
possible remaining issues

What I would like to see for this is

documentation about what db fields remain empty for the new options

All tables effected were documented for Shelley stake address but just updated, Multi asset Policies + Plutus Script hashes

what is the testing coverage, testing method and what combinations of networks and options were used

The test check that each whitelist does indeed omit data going into tables given whitelist (couldn't test sanchonet related tables as they are not currently filled) also there are tests for checking parsing of config for the whitelist.

what ensures that if this options are not enabled, default db-sync schema is not affected by this pr

All existing implementation remain the same and functionality only changes if whitelists are present.

possible remaining issues

Everything worked in preprod + mainet but had issue with sanchonet where db-sync would hang around epoch 301-302 as per @ArturWieczorek observations above.
Artur should also be able to double check if adding whitelist doesn't break existing functionality with preprod + mainnet
I've not tried testing multiple whitelist in conjunction with each other, but doubt that would cause issues, can always try.

There's still an HLint failure: https://ci.iog.io/build/3779994/nixlog/1

@Cmdv I ran into this: Error SNErrDefault: "resolveScriptHash tx hash \"205f623b31de74b6f6886202a81a781edfb06b7f028aca7cdb28a7fe10b587ca\""
[db-sync-node:Info:73] [2024-05-07 09:45:26.76 UTC] Starting epoch 29
[db-sync-node:Info:73] [2024-05-07 09:45:26.76 UTC] Insert Babbage Block: epoch 29, slot 10886468, block 188291, hash c254a37774be4de2ee204dc8e9d438045f359ce78d576f5aab3c45b35da6c0f1
[db-sync-node:Info:73] [2024-05-07 09:45:26.76 UTC]
Inserted epoch 28 from updateEpochWhenSyncing with Cache.
 epoch: Epoch {epochOutSum =<PHONE_NUMBER>1738724661, epochFees = DbLovelace 877160908, epochTxCount = 4045, epochBlkCount = 14739, epochNo = 28, epochStartTime = 2022-10-19 00:00:04 UTC, epochEndTime = 2022-10-23 23:59:32 UTC}
[db-sync-node:Info:82] [2024-05-07 09:45:26.77 UTC] Asynchronously wrote a ledger snapshot to ledger-state/preprod_whitelist_stake_addresses/10886372-baa629e75d-28.lstate in 0.02101376s.
[db-sync-node:Info:73] [2024-05-07 09:45:28.86 UTC] Insert Babbage Block: epoch 29, slot 10921207, block 190000, hash d6b9ddf01626b84b8dcb8cba20464611ad0a40603294b6f2d45843d11b653339
[db-sync-node:Info:73] [2024-05-07 09:45:29.44 UTC] Inserted 1 EpochStake for EpochNo 30
[db-sync-node:Error:73] [2024-05-07 09:45:33.93 UTC] Error SNErrDefault: "resolveScriptHash tx hash \"205f623b31de74b6f6886202a81a781edfb06b7f028aca7cdb28a7fe10b587ca\""
[db-sync-node:Info:73] [2024-05-07 09:45:33.93 UTC] Shutting down DB thread

on preprod using :
  "insert_options": {
    "tx_out": {
      "value": "enable"
    },
    "ledger": "enable",
    "shelley": {
      "enable": true,
      "stake_addresses": ["e04bec2d4e59e40ffc8ac4ed7e3b1e5b32cdc821f5f4b8447cc06d021f", "e0849201473a18ed31ddf126eb36b9ece9d11c8ec5b98cac8dd9c2df6b", "e016a4092303be48b6477c2a0593a8cd483ca045284585eb4853e84726"]
    },
    "multi_asset": {
      "enable": true
    },
    "metadata": {
      "enable": true
    },
    "plutus": {
      "enable": true
    },
    "governance": "enable",
    "offchain_pool_data": "enable",
    "json_type": "text"
  },

db-sync-node/bin/cardano-db-sync --version
cardano-db-sync <IP_ADDRESS> - linux-x86_64 - ghc-8.10
git revision cc66f77e9951229f7b73275042b37c9c393c8d26

@ArturWieczorek could you double check this PR for me when you next get the chance? 👍

@Cmdv
On sanchonet:
  "insert_options": {
     "preset": "only_gov"
  }

with:
./cardano-node version
cardano-node 9.0.0 - linux-x86_64 - ghc-8.10
git rev 2820a63dc934c6d5b5f450b6c2543b81c6476696

./db-sync-node/bin/cardano-db-sync version
git revision c4f7e83ba267b3784a019b31783e39131c6b1477

I ran into [db-sync-node:Error:77] [2024-07-25 11:23:45.57 UTC] Error SNErrDefault: "resolveGovActionProposal.queryGovActionProposalId missing GovAction (TxKey {unTxKey = SqlBackendKey {unSqlBackendKey = 1283}}, 0)" :
[db-sync-node:Info:77] [2024-07-25 11:23:36.81 UTC] Starting epoch 393
[db-sync-node:Info:77] [2024-07-25 11:23:36.81 UTC] Insert Conway Block: epoch 393, slot 33955211, block 1698926, hash 2bbcce48b0580dd58831de1fb1349133ae130b37b0462a3d72728e07892119b6
[db-sync-node:Info:85] [2024-07-25 11:23:36.85 UTC] Asynchronously wrote a ledger snapshot to ledger-state/sancho_only_gov/33955151-163957d025-392.lstate in 0.039110436s.
[db-sync-node:Info:77] [2024-07-25 11:23:37.60 UTC] Inserted 0 EpochStake for EpochNo 394
[db-sync-node:Info:77] [2024-07-25 11:23:38.84 UTC] Insert Conway Block: epoch 393, slot 33976998, block 1700000, hash 48490c35b1cbd36546ec51ccd8b89954b23be572455cf4e2857b4797f550bb60
[db-sync-node:Info:77] [2024-07-25 11:23:45.53 UTC] Removing old epoch boundary file ledger-state/sancho_only_gov/33436789-a577f01423-386.lstate
[db-sync-node:Info:77] [2024-07-25 11:23:45.54 UTC] Removing 0 orphaned rewards
[db-sync-node:Warning:77] [2024-07-25 11:23:45.54 UTC] validateEpochRewards: rewards spendable in epoch 394 expected total of 3 but got 0
[db-sync-node:Info:77] [2024-07-25 11:23:45.54 UTC] Persistant SQL Statement Cache size is 44
[db-sync-node:Info:77] [2024-07-25 11:23:45.54 UTC]
Cache Statistics:
  Stake Addresses: cache sizes: 0 and 0, hit rate: 0%, hits: 0, misses: 97
  Pools: cache size: 0, hit rate: 0%, hits: 0, misses: 1703194
  Datums: cache capacity: 250000, cache size: 0, hits: 0, misses: 0
  Multi Assets: cache capacity: 250000, cache size: 0, hits: 0, misses: 0
  Previous Block: hit rate: 49%, hits: 1703193, misses: 1703194
  TxId: cache size: 1390, cache capacity: 300000, hits: 0, misses: 0
[db-sync-node:Info:77] [2024-07-25 11:23:45.54 UTC] Starting epoch 394
[db-sync-node:Info:77] [2024-07-25 11:23:45.54 UTC] Insert Conway Block: epoch 394, slot 34041601, block 1703194, hash 2588a19fd69700dae6edaf56ee64116ccb19508b66faff27b8b840f096d042f1
[db-sync-node:Error:77] [2024-07-25 11:23:45.57 UTC] Error SNErrDefault: "resolveGovActionProposal.queryGovActionProposalId missing GovAction (TxKey {unTxKey = SqlBackendKey {unSqlBackendKey = 1283}}, 0)"
[db-sync-node:Info:77] [2024-07-25 11:23:45.57 UTC] Shutting down DB thread

@Cmdv  Looks like full preset is missing data for tx_cbor table:

Full
This is equivalent to enabling all other settings.

sancho_new_test_config_full=# select * from tx_cbor;
 id | tx_id | bytes
----+-------+-------
(0 rows)

@Cmdv So far it looks good:
    "multi_asset": {
      "enable": true,
      "policies": [
        "3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a",
        "c70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143"
      ]
    },

and DB:
sancho_test_policies=# select * from multi_asset;
 id |                           policy                           |                              name                              |                 fingerprint
----+------------------------------------------------------------+----------------------------------------------------------------+----------------------------------------------
  1 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \x37f9a73217d919ef97332211ade0afd42732e38b11577c82bbddfd9f2301 | asset16vajwx08w7wgwazxu9fe6lvvpxakgtxftmfc4w
  2 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \xe8a0e694ab11691ed96275dbb8e02c6ab7ae9af840e1e119830ae4e72300 | asset1uqx7htnvmw9az0qwvdhc5e06ep6qg535uwne2f
  3 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \x1c64222c787d10d13247d24b92563a28da34edcbdd918a1c280d02aa2300 | asset1jm3gee8mm3mmrep49c0qx7xmz0wugulx8fcs7l
  4 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \xeda822c2552732f57e749ed4d9c6056a0989884b12ac863301e83ecd2300 | asset129za0pu050u8ulhh0a08zdkwde8ued5cdgpcj2
  5 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x5e249e4b897fe25aea28119031cbb7931ccd4ae135caec5c90fabe3d2301 | asset146w8yfx0c5gue58v44nasvz7rx6c52wmapdprn
  6 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x5ea4fa27f12cda53293b37f721092eedad3f3221832c3a6c706e8d3a2300 | asset1enqrads9txxszt3kt4mx5sqwyq5ur8lne8yfak
  7 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x72f5eeb05dcacbab058506ef94443c0d9a513c61b6a4e442513692702301 | asset1en2qcllrneuh7fc26h3kcwfst3syz5kr204era
  8 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x0826e33c43dce633a67a41528d87352f7b940282d8e5a5a29f8c8abd2300 | asset13gddghj7j2y53tfdjlvcmfc762g56r6wfe26rr
(8 rows)

VS database synced with "standard"  config:
sancho_normal=# select * from multi_asset where policy = '\x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a' or policy = '\xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143';
 id |                           policy                           |                              name                              |                 fingerprint
----+------------------------------------------------------------+----------------------------------------------------------------+----------------------------------------------
  1 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \x37f9a73217d919ef97332211ade0afd42732e38b11577c82bbddfd9f2301 | asset16vajwx08w7wgwazxu9fe6lvvpxakgtxftmfc4w
  2 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \xe8a0e694ab11691ed96275dbb8e02c6ab7ae9af840e1e119830ae4e72300 | asset1uqx7htnvmw9az0qwvdhc5e06ep6qg535uwne2f
  3 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \x1c64222c787d10d13247d24b92563a28da34edcbdd918a1c280d02aa2300 | asset1jm3gee8mm3mmrep49c0qx7xmz0wugulx8fcs7l
  4 | \x3da414859ddd0955cf6694a20cbbc000d60c4cb49dcbf46ad543568a | \xeda822c2552732f57e749ed4d9c6056a0989884b12ac863301e83ecd2300 | asset129za0pu050u8ulhh0a08zdkwde8ued5cdgpcj2
  5 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x5e249e4b897fe25aea28119031cbb7931ccd4ae135caec5c90fabe3d2301 | asset146w8yfx0c5gue58v44nasvz7rx6c52wmapdprn
  6 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x5ea4fa27f12cda53293b37f721092eedad3f3221832c3a6c706e8d3a2300 | asset1enqrads9txxszt3kt4mx5sqwyq5ur8lne8yfak
 38 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x72f5eeb05dcacbab058506ef94443c0d9a513c61b6a4e442513692702301 | asset1en2qcllrneuh7fc26h3kcwfst3syz5kr204era
 55 | \xc70ef82c7ff32b5dda84e3519d8d2b8cbd29c1d2a93cc2e183797143 | \x0826e33c43dce633a67a41528d87352f7b940282d8e5a5a29f8c8abd2300 | asset13gddghj7j2y53tfdjlvcmfc762g56r6wfe26rr
(8 rows)

For
    "shelley": {
      "enable": true,
      "stake_addresses": ["e092a56d8920af4451021a07a0d59f7d0d8a1f3359158c98e1d9cf2be4", "e003d205532089ad2f7816892e2ef42849b7b52788e41b3fd43a6e01cf"]
    },

This does not seem right :
sancho_test_address_filtering=# select * from stake_address;
 id |                           hash_raw                           |                               view                               | script_hash
----+--------------------------------------------------------------+------------------------------------------------------------------+-------------
  1 | \xe092a56d8920af4451021a07a0d59f7d0d8a1f3359158c98e1d9cf2be4 | stake_test1uzf22mvfyzh5g5gzrgr6p4vl05xc58enty2cex8pm88jheqrpmt2u |
  2 | \xe008f121b36abf2bcdd7daa2551c1e6653413a78c419e170d3319924d3 | stake_test1uqy0zgdnd2ljhnwhm23928q7vef5zwnccsv7zuxnxxvjf5c0swgr8 |
  3 | \xe0e0d4c1ce0503af576155012f78f5601fe3593a93e4e7690b69813c3b | stake_test1ursdfswwq5p674mp25qj7784vq07xkf6j0jww6gtdxqncwcpy58kc |
  4 | \xe072715e17c335384378239b830eca11de0f76f436c231337395a4acdf | stake_test1upe8zhshcv6nssmcywdcxrk2z80q7ah5xmprzvmnjkj2ehch9nrjd |
  5 | \xe0c66ad2e4be6c8b6f4ff32b08be6d8b0c757782a6d116239a6903bf59 | stake_test1urrx45hyhekgkm607v4s30nd3vx82auz5mg3vgu6dypm7kgcnxs8z |
  6 | \xe06d77fe1ae0aa1037e054657f1d91cd503efd0538f2566704d232c723 | stake_test1upkh0ls6uz4pqdlq23jh78v3e4gralg98re9vecy6gevwgcd32r5a |
  7 | \xe0b17951d65a7ec99d008d3bc888b1986088b26c44792631bdbb29c8bd | stake_test1uzchj5wktflvn8gq35au3z93npsg3vnvg3ujvvdahv5u30gxuggdt |
  8 | \xe09b632f3bc249952490afcd6557cd3be2f09f15637b097f24ae5bb093 | stake_test1uzdkxtemcfye2fys4lxk247d8030p8c4vdasjley4edmpycgmrxs2 |
  9 | \xe0176b66617c48f76b3ee4a86e488b51e6969e0b5e81ed2147039159bf | stake_test1uqtkkenp03y0w6e7uj5xujyt28nfd8stt6q76g28qwg4n0c3tkc8s |
 10 | \xe0c5ffc5c5445bb4cc9d8dc986768700959e7901e0916788d2512e08e9 | stake_test1urzll3w9g3dmfnya3hycva58qz2eu7gpuzgk0zxj2yhq36g466keq |
 11 | \xe0c13582aec9a44fcc6d984be003c5058c660e1d2ff1370fd8b49ba73f | stake_test1urqntq4wexjylnrdnp97qq79qkxxvrsa9lcnwr7ckjd6w0cr04y4p |
 12 | \xe0df1992dd82b1e2c3f1389ce800701cc49300de7ce71b7af57cb4feca | stake_test1ur03nykas2c79sl38zwwsqrsrnzfxqx70nn3k7h40j60ajsle7at7 |
 13 | \xe01bf1e138f2f8beabc963c94cc28ee8ed4b41744601f2edaf50b21efd | stake_test1uqdlrcfc7tuta27fv0y5es5wark5kst5gcql9md02zepalg9yxxuz |
 14 | \xe0ccf6ffabac700363af242c39fee6228e3a53b5fc7dae4c5675af8904 | stake_test1urx0dlat43cqxca0yskrnlhxy28r55a4l376unzkwkhcjpqeqdp0r |
 15 | \xe07b0a8d15d72c6d497a43ae127b3d03b1dc34e1f18fcd86acd5457d77 | stake_test1upas4rg46ukx6jt6gwhpy7eaqwcacd8p7x8ump4v64zh6acrjhemn |
 16 | \xe0992d25f1234f161763f5faaeea857baf06de242547bde90895019cde | stake_test1uzvj6f03yd83v9mr7ha2a6590whsdh3yy4rmm6ggj5qeehstm86lq |
 17 | \xe031e66d448f7fe215f77ab30eb7409585f9196c7037487130b8c81eaa | stake_test1uqc7vm2y3al7y90h02esad6qjkzljxtvwqm5sufshrypa2sulwjzz |
 18 | \xe0480b7d18a26a3d1c8097038cc2268066f88d09266ef771b17f375afd | stake_test1upyqklgc5f4r68yqjupces3xspn03rgfyeh0wud30um44lg583k50 |
 19 | \xe023066388b51eefb6f405ae8bae44d11e1efc15062748b628f5c8be0b | stake_test1uq3svcugk50wldh5qkhghtjy6y0palq4qcn53d3g7hytuzcav7rp0 |
 20 | \xe0e7cd215fa76c70b9987c4f983766ee63dc8e31cdd8cbd491a2807426 | stake_test1urnu6g2l5ak8pwvc038esdmxae3aer33ehvvh4y352q8gfszxrpxq |
 21 | \xe08141d8651e0139b3bfc9c31f76d885431f83957329d75e0e53a65c2a | stake_test1uzq5rkr9rcqnnvale8p37akcs4p3lqu4wv5awhsw2wn9c2sey6zya |
 22 | \xe08fb4b1cbf9dd257d83859ab5833541ade22c3d01ca02e22d5500ed10 | stake_test1uz8mfvwtl8wj2lvrskdttqe4gxk7ytpaq89q9c3d25qw6yqj5c6wh |
 23 | \xe003d205532089ad2f7816892e2ef42849b7b52788e41b3fd43a6e01cf | stake_test1uqpayp2nyzy66tmcz6yjuth59pym0df83rjpk0758fhqrnc8dx6fl |
 24 | \xe06f7b4bb2492b2ca9ebd5da5cc28ff453b35c71997a643957a7a1de9d | stake_test1uphhkjajfy4je20t6hd9es5073fmxhr3n9axgw2h57saa8gpvk6j8 |
 25 | \xe03bdb8a34e61405507e0321511bf4afbcfa40a8ad87f97112a5777145 | stake_test1uqaahz35uc2q25r7qvs4zxl547705s9g4krljugj54mhz3gk5lc36 |
 26 | \xe00062f6f5b4951b27d1c8948b7f5f07a434f6f7e5d629380e1648946c | stake_test1uqqx9ah4kj23kf73ez2gkl6lq7jrfahhuhtzjwqwzeyfgmq380acx |
 27 | \xe0e356224fb5a313bbe98353e4ccd02f396baaafafbf85393bdbf680ad | stake_test1ur34vgj0kk338wlfsdf7fnxs9uukh24047lc2wfmm0mgptgq7849c |
 28 | \xe0609ffae0a55723de7a69397c77f29c19bf0ef58f2c782877b8abbba1 | stake_test1upsfl7hq54tj8hn6dyuhcaljnsvm7rh43uk8s2rhhz4mhgg7slyup |
 29 | \xe010ae59b652be66c7fd26a9dce502e56f3a64d77a531465383b1e30be | stake_test1uqg2ukdk22lxd3lay65aeegzu4hn5exh0ff3gefc8v0rp0sgkn67g |
 30 | \xe01cf186c852a7e3644d84fdbe03ef221bd7647470c341bd11e9c90057 | stake_test1uqw0rpkg22n7xezdsn7muql0ygdawer5wrp5r0g3a8ysq4c72ax2e |
 31 | \xe021af6d5199f45b1ea76320e598ccbf4e4d38c842e64f53e3280f2a58 | stake_test1uqs67m23n869k848vvswtxxvha8y6wxggtny75lr9q8j5kqgqsq3u |
 32 | \xe09f01ce7841ab8eb33bb1baf48462cc9565aba9e85714b4c543827c18 | stake_test1uz0srnncgx4cavemkxa0fprzej2kt2afapt3fdx9gwp8cxqa5qrpn |
(32 rows)

sancho_test_address_filtering=# select * from stake_registration;
 id | addr_id | cert_index | epoch_no | tx_id | deposit
----+---------+------------+----------+-------+---------
  1 |       1 |          0 |      393 |  1352 | 2000000
  2 |      23 |          0 |      437 | 23126 | 2000000
(2 rows)

Should not stake_address contain only those two addresses ?

@Cmdv  Should the table instant_reward be present in the table list ? I do not see it.

Looks like there might be issue with reward_rest table - it contains addresses with different ids:
sancho_test_address_filtering=# select * from reward_rest LIMIT 3;
 addr_id |      type       |    amount    | spendable_epoch | earned_epoch
---------+-----------------+--------------+-----------------+--------------
       2 | proposal_refund |<PHONE_NUMBER>00 |             395 |          394
       1 | proposal_refund |<PHONE_NUMBER>00 |             411 |          410
       3 | proposal_refund |<PHONE_NUMBER>00 |             412 |          411
(3 rows)

sancho_test_address_filtering=# select * from stake_registration;
 id | addr_id | cert_index | epoch_no | tx_id | deposit
----+---------+------------+----------+-------+---------
  1 |       1 |          0 |      392 |  1238 | 2000000
(1 row)

but in filter there is only 1 address:
  "insert_options": {
    "shelley": {
      "enable": true,
      "stake_addresses": ["e0e0d4c1ce0503af576155012f78f5601fe3593a93e4e7690b69813c3b"]
    },
  },


throw new Error('predict - expected FaceRecognizer to be trained with at least 2 different classes')

I am getting this error:
throw new Error('predict - expected FaceRecognizer to be trained with at least 2 different classes')
What is the possible cause of this one?

TRY mORE TRAING

Well its what the error says, you have to train the model with two different classes (persons) first


tag boost-1.71.0 - staged libs are 1_72?

hello,
I checked out tag boost-1.71.0 and ran bootstrap and b2 and the libs that it built all have the 1_72 tag on them (eg boost_atomic-vc140-mt-x64-1_72.dll).
I just wanted to check if this was intentional and I should be checking out a different tag or if I messed up somewhere in my config.
TIA for any advice you have

nvm please disregard I somehow re checked out the latest commit


FLPATH-1257: supply default workflow with an existing one in cluster

These GPT templates for assessment were designed for local dev purposes and not intended for integration with CI/CD pipelines in a cluster. The failure reported is due to the absence of a default infrastructure workflow in the returned workflow options but also in the cluster.
This PR enhances the assessment templates by setting a default infrastructure workflow option upfront that is known to be already deployed in the cluster, such as the greeting workflow which is part of the workflows deployed from the orchestrator installation manifest. As a result, when the user input is 'default' during assessment, the greeting workflow will be returned; otherwise, no workflow will be returned.

This PR enhances the assessment templates by setting a default infrastructure workflow option upfront that is known to be already deployed in the cluster, such as the greeting workflow which is part of the workflows deployed from the orchestrator installation manifest. As a result, when the user input is 'default' during assessment, the greeting workflow will be returned; otherwise, no workflow will be returned.

The statement that the Greeting workflow will always be installed on the cluster isn't correct.
We enabled the installation of each workflow separately and there is a high probability that the Greeting workflow will exist only in a test environment.
Therefore, I'd prefer not to set default values of a workflow that may not exist and leave those fields as empty.

This PR enhances the assessment templates by setting a default infrastructure workflow option upfront that is known to be already deployed in the cluster, such as the greeting workflow which is part of the workflows deployed from the orchestrator installation manifest. As a result, when the user input is 'default' during assessment, the greeting workflow will be returned; otherwise, no workflow will be returned.

The statement that the Greeting workflow will always be installed on the cluster isn't correct. We enabled the installation of each workflow separately and there is a high probability that the Greeting workflow will exist only in a test environment.
Therefore, I'd prefer not to set default values of a workflow that may not exist and leave those fields as empty.

This PR enhances the assessment templates by setting a default infrastructure workflow option upfront that is known to be already deployed in the cluster, such as the greeting workflow which is part of the workflows deployed from the orchestrator installation manifest. As a result, when the user input is 'default' during assessment, the greeting workflow will be returned; otherwise, no workflow will be returned.

The statement that the Greeting workflow will always be installed on the cluster isn't correct. We enabled the installation of each workflow separately and there is a high probability that the Greeting workflow will exist only in a test environment.
Therefore, I'd prefer not to set default values of a workflow that may not exist and leave those fields as empty.

Thanks for the clarification on the greeting workflow! If we leave those fields empty, it will cause the same issue reported in the bug ticket. An empty field means no workflow ID and name from the workflow options returned by the assessment, which will cause an error when rendering the assessment result in the Orchestrator plugin UI.
To mitigate his, I suggest keeping the default infrastructure input upfront so developers can relate it to the assessment workflow evaluation. Then add a pre-check operation in the workflow to filter out non-existent or unavailable workflows from the returned workflows. Alternatively, we could skip the evaluation in the assessment and always return an empty object.

This PR enhances the assessment templates by setting a default infrastructure workflow option upfront that is known to be already deployed in the cluster, such as the greeting workflow which is part of the workflows deployed from the orchestrator installation manifest. As a result, when the user input is 'default' during assessment, the greeting workflow will be returned; otherwise, no workflow will be returned.

The statement that the Greeting workflow will always be installed on the cluster isn't correct. We enabled the installation of each workflow separately and there is a high probability that the Greeting workflow will exist only in a test environment.
Therefore, I'd prefer not to set default values of a workflow that may not exist and leave those fields as empty.

Thanks for the clarification on the greeting workflow! If we leave those fields empty, it will cause the same issue reported in the bug ticket. An empty field means no workflow ID and name from the workflow options returned by the assessment, which will cause an error when rendering the assessment result in the Orchestrator plugin UI. To mitigate his, I suggest keeping the default infrastructure input upfront so developers can relate it to the assessment workflow evaluation. Then add a pre-check operation in the workflow to filter out non-existent or unavailable workflows from the returned workflows. Alternatively, we could skip the evaluation in the assessment and always return an empty object.

How about marking those fields as required and forcing the user to provide the workflow ID?
We can add a description that the referred workflow must exist in the target cluster, but for the sake of development, it can be specified with temporary values.

This PR enhances the assessment templates by setting a default infrastructure workflow option upfront that is known to be already deployed in the cluster, such as the greeting workflow which is part of the workflows deployed from the orchestrator installation manifest. As a result, when the user input is 'default' during assessment, the greeting workflow will be returned; otherwise, no workflow will be returned.

The statement that the Greeting workflow will always be installed on the cluster isn't correct. We enabled the installation of each workflow separately and there is a high probability that the Greeting workflow will exist only in a test environment.
Therefore, I'd prefer not to set default values of a workflow that may not exist and leave those fields as empty.

Thanks for the clarification on the greeting workflow! If we leave those fields empty, it will cause the same issue reported in the bug ticket. An empty field means no workflow ID and name from the workflow options returned by the assessment, which will cause an error when rendering the assessment result in the Orchestrator plugin UI. To mitigate his, I suggest keeping the default infrastructure input upfront so developers can relate it to the assessment workflow evaluation. Then add a pre-check operation in the workflow to filter out non-existent or unavailable workflows from the returned workflows. Alternatively, we could skip the evaluation in the assessment and always return an empty object.

How about marking those fields as required and forcing the user to provide the workflow ID? We can add a description that the referred workflow must exist in the target cluster, but for the sake of development, it can be specified with temporary values.

Agreed with that direction and did changes accordingly.


"Currently active component" is unhelpful at best, misleading at worst

It seems this condition is put here to reassure users that redrawing in a given route state will not draw the views of components for other routes, but it's difficult to imagine how somebody might worry that might happen.
As it is, people end up believing that redraw acts per-component, which is highly misleading in a situation where there are nested components or multiple mount points, and the call to redraw is invoked within one of those components.

Maybe "currently active tree" or something to that effect?

@barneycarroll Maybe "currently active tree" or something to that effect?

In some ways that's better — it's certainly less liable to one particular misinterpretation, namely that only the component in which the redraw is invoked will redraw. But introducing new terminology without any clear definition isn't an ideal resolution — what is the "active tree"? If I'm forced to guess, I might well believe that this particular mount point defines a tree, and my other mounted components won't redraw.
I really believe less is more. The only thing this extra text can possibly intend to mean is that if you are on route X, then the views associated with the components mapped to routes Y and Z will not redraw. You have to ask yourself: how could somebody possibly end up worrying that might be the case?
Several times I've participated in long support conversations where we eventually realise the supplicant believes Mithril has isolated redraw islands, and this text is the culprit. These people believe there is some special significance to this text and get stuck trying to imagine how they might re-render the "inactive" components. The idea that someone might worry that a call to redraw will somehow render a view that isn't mounted is frankly impossible to imagine — I certainly haven't encountered it. Is it really worth adding verbosity to the first sentence of the redraw documentation to guard against this?

I see what you're talking about. And I think this would work. It's
definitely clear from context what it should be redrawing.
On Mon, Feb 8, 2016, 03:16 Barney Carroll<EMAIL_ADDRESS>wrote:

In some ways that's better — it's certainly less liable to one
particular misinterpretation, namely that only the component in which the
redraw is invoked will redraw. But introducing new terminology without any
clear definition isn't an ideal resolution — what is the "active tree"? If
I'm forced to guess, I might well believe that this particular mount point
defines a tree, and my other mounted components won't redraw.
I really believe less is more. The only thing this extra text can possibly
intend to mean is that if you are on route X, then the views associated
with the components mapped to routes Y and Z will not redraw. You have to
ask yourself: how could somebody possibly end up worrying that might be the
case?
Several times I've participated in long support conversations where we
eventually realise the supplicant believes Mithril has isolated redraw
islands, and this text is the culprit. These people believe there is some
special significance to this text and get stuck trying to imagine how they
might re-render the "inactive" components. The idea that someone might
worry that a call to redraw will somehow render a view that isn't mounted
is frankly impossible to imagine — I certainly haven't encountered it. Is
it really worth adding verbosity to the first sentence of the redraw
documentation to guard against this?
—
Reply to this email directly or view it on GitHub
https://github.com/lhorie/mithril.js/pull/958#issuecomment-181250192.


[RFR] ciao-controller: Return a meaningful error when workload does not exist

When running ciao-cli instance add -workload not-a-workload the error
returned is not clear on the cause of it.
Fixes #292
Signed-off-by: Alberto Murillo<EMAIL_ADDRESS>

Coverage decreased (-0.04%) to 61.77% when pulling 158c3720d3dbb6ac835cbe412127737446c188da on albertomurillo:workload into 5a036d82ade421fbc7cef2ca575bed5b24e24b2e on 01org:master.

Coverage decreased (-0.002%) to 61.805% when pulling<PHONE_NUMBER>47155755422620ce68783e764ba9ac on albertomurillo:workload into 5a036d82ade421fbc7cef2ca575bed5b24e24b2e on 01org:master.

@albertomurillo Looks good to me except for the commit message that should describe which error message the current code is returning.

Coverage decreased (-0.03%) to 61.83% when pulling 7642551bd3308d67d49ecfbdaf6b2604cd69e1a9 on albertomurillo:workload into 9c47545cb6b6466e53ac9724efc8f1273209282e on 01org:master.

Coverage decreased (-0.03%) to 61.83% when pulling 7642551bd3308d67d49ecfbdaf6b2604cd69e1a9 on albertomurillo:workload into 9c47545cb6b6466e53ac9724efc8f1273209282e on 01org:master.

Looks good to me.  Tested on the single machine setup and everything seems okay.  I removed the RFR in front of the title of the PR.


Upload, When uploading a large file, the server needs to wait for a period of time to receive the file

The larger the file, the longer the waiting time. When the progress bar is 100%, the server does not immediately receive the file information. It needs to wait for a period of time before it can be received in the background

望知悉，默认情况下，前端获取的是上传进度，而不是服务器接收进度，这不是el的问题，也不是js的问题，你可以对大文件进行切片，来尽可能实现服务器立即接收

Thank you very much. This problem has been solved. The reason is the problem of nginx. What happened in the middle is still a little vague. Do you know why?


Omegascans.org

Source name
Omega scans 1.4.42
Source language
English
Source link
https://omegascans.org
Other details
Site redirect to discord invite link
Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source website is down.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

Issue already mentioned in #3646


[feature] #3354: Different fuel limit for Executor

Linked issue

Closes #3354

Benefits
Now users can specify different limits for Executor and for other WASM

Checklist

[x] I've read CONTRIBUTING.md
[x] I've used the standard signed-off commit format (or will squash just before merging)
[x] All applicable CI checks pass (or I promised to make them pass later)
[ ] (optional) I've written unit tests for the code changes
[ ] I replied to all comments after code review, marking all implemented changes with thumbs up

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-6 of 19 (68.42%)  changed or added relevant lines in 6 files are covered.
2948 unchanged lines in 53 files lost coverage.
Overall coverage decreased (-0.3%) to 56.506%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tools/kagami/src/genesis.rs
0
2
0.0%

core/src/executor.rs
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

core/src/sumeragi/network_topology.rs
1
98.78%

tools/kagami/src/crypto.rs
1
12.12%

data_model/src/metadata.rs
2
78.87%

primitives/src/unique_vec.rs
2
91.24%

config/src/kura.rs
3
80.0%

config/src/logger.rs
5
72.73%

logger/src/lib.rs
5
94.12%

tools/kagami/src/main.rs
5
0.0%

telemetry/src/dev.rs
7
0.0%

core/src/smartcontracts/isi/mod.rs
8
76.49%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
22412

Relevant Lines:
39663

💛  - Coveralls


⚠ Bofrost.be has degraded performance

In f6558c4, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2018 ms

Resolved: Bofrost.be performance has improved in 8ae16ce.


Pattern: Develop Link group - Prod level version

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create/change the Link group

so that I can:
provide the ibm.com adopter developers patterns/components they can use to build ibm.com web pages

Additional information

Story within Storybook with corresponding knobs
Utilize Carbon
Design specs issue (#2035  )
Functional specs issue (#1840  )
Design QA testing issue (# )
Prod QA testing issue (# )

Acceptance criteria

[ ] Include README for the react pattern and corresponding styles
[ ] Minimum 80% unit test coverage
[ ] A comment is posted in the Design QA issue, tagging Wonil and Roberta, when development is finished
[ ] A comment is posted in the Prod QA issue, tagging Praveen and Chetan, when development is finished

The Link List functionality will be expanded to include Link Group.  See the Link List design issue (#2030) for James Dow's comments.  The Link Group issues are no longer needed.  Closing


Add time slider and show decay

Previous versions of this application included a "time slider" that allowed a user to change an "elapsed time" value, on a logarithmic scale, which in turn caused isotopes to fade as half lives are surpassed.

Implemented with recent commits.


Bug in READM.md file.

Is your feature request related to a problem? Please describe.
Links in "Get Involved" section are not working.
Describe the solution you'd like.
Add working links to the respective link names.
Additional context.
After alterations, links are supposed to work properly and redirect user to the destination pages.
@Sulagna-Dutta-Roy
I am willing to work on this issue. Kindly assign this to me under GSSOC24.
Could you give me your project's working URLs for Discord, Slack and Twitter.
Thank you.

Hello, It seems I do not have any GGextensions communities. You can remove this from the readme.md file.
Project URL is:
https://github.com/Sulagna-Dutta-Roy/GGExtensions

Hello there,
On it. Thanks for the reply.
On Sat, 11 May 2024 at 19:06, Sulagna Dutta Roy @.***>
wrote:

Hello, It seems I do not have any GGextensions communities. You can remove
this from the readme.md file.
Project URL is:
https://github.com/Sulagna-Dutta-Roy/GGExtensions
—
Reply to this email directly, view it on GitHub
https://github.com/Sulagna-Dutta-Roy/GGExtensions/issues/23#issuecomment-2105749105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2JGSHX7NNF6CIAM32G72ULZBYNHNAVCNFSM6AAAAABHR5Y6N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVG42DSMJQGU
.
You are receiving this because you were assigned.Message ID:
@.***>

I've generated the PR request. Kindly look into it.
Thank you.
On Sat, 11 May 2024 at 19:09, Anushka sharma @.***>
wrote:

Hello there,
On it. Thanks for the reply.
On Sat, 11 May 2024 at 19:06, Sulagna Dutta Roy @.***>
wrote:

Hello, It seems I do not have any GGextensions communities. You can
remove this from the readme.md file.
Project URL is:
https://github.com/Sulagna-Dutta-Roy/GGExtensions
—
Reply to this email directly, view it on GitHub
https://github.com/Sulagna-Dutta-Roy/GGExtensions/issues/23#issuecomment-2105749105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2JGSHX7NNF6CIAM32G72ULZBYNHNAVCNFSM6AAAAABHR5Y6N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVG42DSMJQGU
.
You are receiving this because you were assigned.Message ID:
@.***>

I've generated the PR request. Kindly look into it.
Thank you.


Error Connecting to SCC Service

The script was working fine yesterday, however, today I'm getting the error below when trying to connect to the SCC service. I'll note "compliance.protection.outlook.com" without the ps. does resolve, I tried to find where this was in the module code to test, but couldn't seem to track it down for some reason.
connect-ms365 -Service SCC
Connect-SCC : Could not connect to SCC.
Connecting to remote server ps.compliance.protection.outlook.com failed with the following error message : The WinRM
client cannot process the request because the server name cannot be resolved. For more information, see the
about_Remote_Troubleshooting Help topic.
At C:\Program Files\WindowsPowerShell\Modules\Connect-MS365\1.3.9\Connect-MS365.psm1:138 char:17

            Connect-SCC

            ~~~~~~~~~~~

CategoryInfo          : ConnectionError: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Connect-SCC

Apologies, it seems I was having some very..."unique" DNS issues.


Issue 18: Creation of menu card in the menu page.

#18
Closes: #18
--->Firstly I remove " div class="carousel-img-container"></div "this particular element this was creating a semi-transparent grey layer over the whole page
---> the class menu-card-container as the name suggests acts as a container for the whole menu card
---> the menu-card and card classes act as containers a single menu card I made the float left so that they would appear like a row I wanted to use grid or flexbox but I have very little knowledge in them
Give a clear description what modifications you have made
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Describe how have you verified the changes made
Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots
Original
https://user-images.githubusercontent.com/89822646/183250856-f670930c-e61b-40c1-95cd-cb8be8fb4b12.mp4
Updated
https://user-images.githubusercontent.com/89822646/183250977-36bbfeec-7146-4e1b-a02e-294074f2cd98.mp4

i have closed the old pr since i had to make changes please review this one

Congrats @Rishi1003 your PR is merged.


Update virtual-machines-windows-nsg-quickstart-powershell.md

Fixed typos.

Hi @alexandair, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

@alexandair : Thanks for your contribution to the Azure documentation! The author, @iainfoulds, has been notified to review your proposed change.

Thanks for the updates, @alexandair!
@tysonn : This PR can be merged.


schemasheets diff dashboard

Script that generates diff dashboard comparing schemasheets tsv sheets.

Thank you for the detailed review @turbomam. I think I will be going with approach 3 and writing an email with instructions to help Ramona and other possible users to get setup with the environment necessary to get this up and running.

Actions: @sujaypatil96 will review to check a few potential error, change the source of truth that is being compared from the google sheets to https://github.com/GenomicsStandardsConsortium/mixs/blob/main/mixs/excel/mixs_v6.xlsx, ask @turbomam  to review, then merge into branch 511.

thanks @sujaypatil96 this was a good idea. Let's keep thinking of ways to generate diff reports, even if that is just raining users to look at GitHub diff pages.


chore(consensus): Cleanup Hardforks

Description
Cleans up hardforks further to split bytecode into a legible directory.

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#288 👈
main

This comment was automatically generated by st.


Backup Status screen stops updating once it's been running for a while

title says it all - debug why it stops updating after a lot of backup loops

the last time this happened, it was after flagging the next backup and adding a note


[IOTS-496] UI shows incorrect device list on user list page for a given user

Enrolled devices by user displays the devices by other users.Reference: https://wso2.org/jira/browse/IOTS-496

@Nirothipan Will verfiy.

This issue is not reproduced in IoTs 3.1.0.
I created a new user and enrolled a device with that user.
Enrolled devices by user displayed the correct device lists for both users (admin and newly created one).
Hence closed.

Closing this issue as this cannot be reproduced.

Pubudu is trying to reproduce this issue.

@sinthuja
I was able to reproduce the issue by running the attached two scripts concurrently on a fresh IoT 3.1.0 GA build.
It looks like the issue happens If User A registers device A with device identifier ID1 and User B registers device B with device identifier ID1 then User A's device A is listed under user B's registered devices. We should add relevant validation for this.
IoT.zip

Hi all,
I could reproduce this issue in IoT server 3.0.0.
I created 2 users ( user1 and user2 ) and enrolled one device for each user ( device 1 and device2 respectively), as mentioned in the ticket, I could able to view the device1 in user2 and device 2 in user1.
This issue is fixed in IoT server 3.1.0 and no longer present.
Hence this can be closed.
Thank you.


961 add footer for frontend pages

Implemented a footer.

When there is long page, this footer will sink to the bottom
When there is a short page, this footer stick to the bottom of the view part
When side bar opens and collapses, this footer shrink/expand accordingly

To test, please try various pages and see how it looks.
Some screenshots.

It looks good. There is no footer for the public page. Is that intended?

sorry just added that to public page too


Codecov numbers are probably incorrect

Each build in Travis submits a report to codecov. It's not clear what codecov does when it receives multiple reports for the same commit, but since some tests behave differently (or are skipped) in different builds, it seems like the numbers in the report would differ.
If codecov takes the first or the last report as the definitive one, then it's essentially random as to which build generates the coverage number.
Perhaps we should just run codecov for just one build configuration.

And perhaps disable it for circleci (or disable circle altogether).

Sound like good ideas.
On Wednesday, March 30, 2016, Matt Brown<EMAIL_ADDRESS>wrote:

And perhaps disable it for circleci (or disable circle altogether).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/spotify/docker-client/issues/406#issuecomment-203698235

--
David Xia
Software Engineer
<EMAIL_ADDRESS>

I removed the CircleCI webhook so this project doesn't build there anymore.

@mattnworb Can we close this issue?