[BACKLOG-27694] Updates for additional VFS Connections

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/connections/ConnectionManager.java
  core/src/main/java/org/pentaho/di/connections/vfs/BaseVFSConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetailsProvider.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.connections.ConnectionManager

Branch Change: -3.7% :small_red_triangle_down:
Complexity Change: -4.8% :small_red_triangle_down:
Instruction Change: -7.6% :small_red_triangle_down:
Line Change: -5.4% :small_red_triangle_down:
Method Change: -6.8% :small_red_triangle_down:

:new: org.pentaho.di.connections.vfs.BaseVFSConnectionProvider

Coverage: 0% :exclamation:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetailsProvider.java

:heavy_exclamation_mark: Unused import - org.pentaho.di.connections.ConnectionManager. at Line: 29 Column: 8

:heavy_exclamation_mark: Unused import - org.pentaho.di.connections.vfs.VFSConnectionProvider. at Line: 31 Column: 8

:heavy_exclamation_mark: Unused import - java.util.function.Supplier. at Line: 36 Column: 8

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/connections/ConnectionManager.java
  core/src/main/java/org/pentaho/di/connections/vfs/BaseVFSConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetailsProvider.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.connections.ConnectionManager

Branch Change: -3.7% :small_red_triangle_down:
Complexity Change: -4.8% :small_red_triangle_down:
Instruction Change: -7.6% :small_red_triangle_down:
Line Change: -5.4% :small_red_triangle_down:
Method Change: -6.8% :small_red_triangle_down:

:new: org.pentaho.di.connections.vfs.BaseVFSConnectionProvider

Coverage: 0% :exclamation:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

@ddiroma


Improve visual clarity and consistency of the send_button_html and download_list_html() elements

The current buttons are a little messy, especially if you have two separate bundles:

The download_list_html() buttons and the send_button_html() buttons:

Are not on the same grid
Are not clearly separated or grouped by a proper amount of white space
Have a confusing visual hierarchy--the h5 that labels the send_button_html() output is larger than the name of the document, and the document title is bold while the "send as email" heading is fairly light weight
Are not clearly grouped together as one logical unit (unifying the send button with the list of documents)

See also #562

@mnewsted would want to coordinate on any changes to this with you, since you usually want to avoid look and feel changes that are "upstream". Or let us know if you're fine with any changes to improve this

Here are some adjustments. They depart from past decisions by right-aligning the "view" and "download" buttons, leaving a big gutter between the document's titles and their buttons. The document titles are also right aligned here, which really makes that gutter stick out:

I couldn't get the same final page as the one above, so I couldn't address item 2 in the concerns expressed above.

Get rid of the heading "get a copy in email" (just leave it to the developer to decide if editable or not)
Put the send button into the same container--an optional field output by download_list_html()
Add some more whitespace between bundles. And make the title of the bundle and optional thing to display.

Thanks for including me in this @nonprofittechy Sorry I didn't see it until today. I'm not sure how all of these changes will impact the current layout of our download screen (see below example). Maybe because we haven't broken down our forms on the download page into forms for personal use v. forms to be filed, the current layout (single download table, single email button) works for us. I do think the "Get a copy of the documents in email" could be removed, as long as we can add our own header/text, which I think we can since it's part of the subquestion.

as long as we can add our own header/text

@mnewsted - your own header text for the bundle or your own header text for the email sending section?

@plocket I was referring to the email field/button header "Get a copy of documents in email" (or "Get a copy of your forms by email" in the ILAO interview). I think developers can include whatever text is appropriate above that field/button in the subquestion.

@mnewsted - if we align the "send" button to the right as shown above, would that still work for you?

New send email row

[ ] add a new parameter to download_list_html() to include the send email button row
[ ] No header, no "include editable"
[ ] remove the big gutter between the buttons and the text

Current send email button

[ ] remove the H4 and replace with H2 class="h4"
[ ] Possibly right align the send button (after feedback from collaborators)

We talked about replacing the "download zip" button with two buttons of the same size as "view" and "download".

This is an interesting idea. Very interesting. I agree button size might need to be adjusted for consistency. Also, What was decided with the location & formatting of the send email field/button? Thanks!

I think the styles for the isolated email section (for the email field and the button), the widths and alignment are the only things changing and they're still being decided. As far as technical details go, we're turning that section into a fieldset and the current h5 tag will become a legend tag, but the style of the heading will stay the same. I don't recall working with you on style adjustments there, but if yours need updating I can try to help with that, @mnewsted.

Da's fields are left aligned, so I couldn't implement that without messing up our right-hand alignment. I tried something else:

The table "send" button isn't the same width as the other buttons and generally the columns don't align with the ones above. The gap looks wider between the email field and the send button, but it's really the same as the other rows. I can line up those columns if we're ok with the email field being significantly smaller.
I'm not sure what we want to do with the formatting of the "send email" fields of the isolated email section. I made the button a little wider. Haven't worked on the HTML there, just showing what it looks like visually. I can work on having them align with the table fields better, but then I'll have to put them into bootstrap columns like the table.
Thoughts?

I like this change--the formatting seems clearer to me than the last revision.
I think it's most important to do what you've done here, which is put the primary buttons all in a strong right hand alignment.


V1.1.0 and later versions do not support the same name file upload and cover it?

If upload the same name file will prompt "There is already a file on that path"
You can add a function, prompt the user to have the same name file already exists, and let the user manually select whether to overwrite.

By the way, if you later add the language file content, remember to inform me. :rofl:

Hey @ToyoDAdoubi,
I'll implement this when I can.
About the language files, I added this to the files section:
sortByName: Sort by name
sortBySize: Sort by size
sortByLastModified: Sort by last modified

@hacdias complete! https://github.com/hacdias/filemanager/pull/189

Just added some stuff to the translations file: https://github.com/hacdias/filemanager/commit/6ee846ef0eab0f3b91ff3557877cd2eb63acb505#diff-fe6ccd8f0bf41f00b9ff5d61b8e0e3e9
I already fixed this issue and it will be available on the next release 😄

@hacdias complete! https://github.com/hacdias/filemanager/pull/191


[OoB-5.9]: Deprecation warning is not visible enough.

The warning message must appear on the source files (main.cpp) as well for cases where not everyone in the outside world reads the README first :-) ..
Also, (side note) deprecation warning has been added to master branch. This is only a note but during OoB, changes are expected on the OoB branch and no further changes to master until the release.

ARM Internal Ref: IOTSEC-700

fixed via https://github.com/ARMmbed/mbed-os-example-uvisor/commit/8b313c1928f45822a00d88d2cf09cecb0bd65254


compilation error on karate-gatling dependency need updated. Version 4.1.1

modified:   karate-gatling/pom.xml
gatling-maven-plugin
4.2.7

that's a very inadequate description. I'm closing this as wontfix so we would invite code-contributions. a similar request can be found here for more context: https://github.com/karatelabs/karate/issues/2253


[in_app_purchases]  Duplicate plugin key: InAppPurchasePlugin

I have a problem building the iOS app with the in_app_purchases plugin: 3.0.7
Error:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Duplicate plugin key: InAppPurchasePlugin

flutter doctor -v
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.4, on macOS 12.6 21G115 darwin-arm, locale de-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.2.2)
[✓] VS Code (version 1.72.0)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

• No issues found!

Hi @Tutorialwork, are you by any chance using two plugins with conflicting names?
Please provide a complete minimal reproducible code sample along with steps to reproduce.
Please also provide your pubspec.yaml & pubspec.lock.
Thank you

This is my implementation: The app crashed when I try to start it.
Future<void> listenForPurchases(
    InAppPurchase inAppPurchase,
    Function(bool) onPurchaseStateChanged,
    VoidCallback onPurchase,
    BuildContext context
    ) async {
  final Stream<List<PurchaseDetails>> purchases = inAppPurchase.purchaseStream;
  final SharedPreferences sharedPreferences = await SharedPreferences.getInstance();
  StreamSubscription<List<PurchaseDetails>> subscription;

  subscription = purchases.listen((List<PurchaseDetails> purchaseDetailsList) {
    purchaseDetailsList.forEach((PurchaseDetails purchaseDetails) async {
      if (purchaseDetails.status == PurchaseStatus.error) {
        onPurchaseStateChanged(false);
        AlertManager().openMessageDialog(context, AppLocalizations.of(context).translate('purchase_failed'), AppLocalizations.of(context).translate('unexpected_error'));
      } else if (purchaseDetails.status == PurchaseStatus.purchased || purchaseDetails.status == PurchaseStatus.restored) {
        onPurchaseStateChanged(false);

        ValidatePurchase validatePurchase = new ValidatePurchase();

        bool isPurchaseValid = false;

        if (Platform.isIOS) {
          isPurchaseValid = await validatePurchase.validateIosPurchase(sharedPreferences.getString('accessToken'), purchaseDetails.verificationData.serverVerificationData);
        } else {
          isPurchaseValid = await validatePurchase.validateAndroidPurchase(sharedPreferences.getString('accessToken'), purchaseDetails.verificationData.serverVerificationData);
        }

        if (isPurchaseValid) {
          print("PURCHASE SUCCESS");

          /**
           * Set for UI not persistent ads boolean to false.
           * Ads boolean is persistent set in backend.
           */
          onPurchase();

          await inAppPurchase.completePurchase(purchaseDetails);

          AlertManager().openMessageDialog(context, AppLocalizations.of(context).translate('purchase_success'), AppLocalizations.of(context).translate('purchase_success_message'));
        } else {
          AlertManager().openMessageDialog(context, AppLocalizations.of(context).translate('purchase_failed'), AppLocalizations.of(context).translate('unexpected_error'));
        }

      }
    });
  }, onDone: () {
    subscription.cancel();
  }, onError: (error) {
    print(error);
  });
}

That is my pubspec.yaml
name: pricenotify
description: A new Flutter application.

# The following line prevents the package from being accidentally published to
# pub.dev using `pub publish`. This is preferred for private packages.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 3.9.0+49

environment:
  sdk: ">=2.7.0 <3.0.0"

dependencies:
  webview_flutter: ^2.0.14
  http: ^0.13.3
  device_info: ^2.0.2
  firebase_messaging: ^10.0.7
  url_launcher: ^6.1.5
  in_app_review: ^2.0.3
  firebase_core: ^1.24.0
  intl: ^0.17.0
  package_info: ^2.0.2
  shared_preferences: ^2.0.8
  firebase_crashlytics: ^2.9.0
  flutter_spinkit: ^5.1.0
  google_mobile_ads: ^2.1.0
  firebase_analytics: ^9.3.8
  cached_network_image: ^3.1.0
  syncfusion_flutter_charts: ^20.1.61
  image: ^3.0.5
  path_provider: ^2.0.5
  sign_in_with_apple: ^3.1.0
  google_sign_in: ^5.1.0
  uni_links: ^0.5.1
  open_mail_app: ^0.3.0
  skeleton_text: ^3.0.0
  flutter_svg: ^0.22.0
  in_app_purchase: ^3.0.7
  in_app_purchase_ios: ^0.2.0+1
  in_app_purchase_android: ^0.2.3+5
  quick_actions: ^0.6.0+7
  flutter_sfsymbols: ^2.0.0
  flutter_countdown_timer: ^4.1.0
  receive_sharing_intent: ^1.4.5

  flutter:
    sdk: flutter

  flutter_localizations:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^1.0.3

dev_dependencies:
  flutter_launcher_icons: ^0.9.1

  flutter_test:
    sdk: flutter

flutter_icons:
  image_path: "assets/images/appicon.jpg"
  android: true
  ios: true

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
    - assets/languages/en.json
    - assets/languages/de.json
    - assets/languages/es.json
    - assets/languages/fr.json
    - assets/images/appicon.jpg
    - assets/images/google-logo.png
    - assets/images/flags/ae.png
    - assets/images/flags/au.png
    - assets/images/flags/br.png
    - assets/images/flags/ca.png
    - assets/images/flags/cn.png
    - assets/images/flags/com.png
    - assets/images/flags/de.png
    - assets/images/flags/eg.png
    - assets/images/flags/es.png
    - assets/images/flags/fr.png
    - assets/images/flags/in.png
    - assets/images/flags/it.png
    - assets/images/flags/jp.png
    - assets/images/flags/mx.png
    - assets/images/flags/nl.png
    - assets/images/flags/pl.png
    - assets/images/flags/se.png
    - assets/images/flags/sg.png
    - assets/images/flags/tr.png
    - assets/images/flags/uk.png
    - assets/images/flags/sa.png
    - assets/images/onboarding/explain.svg
    - assets/images/onboarding/notification.svg
    - assets/images/onboarding/pricehistory.svg

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font.
Can you try removing them to see if you still experience this issue?

Thanks, this solves my issue.


Routed component's top node always destroyed

Please see this example: https://codepen.io/zaceno/pen/vRwERE?editors=0011
Each page ("A" and "B") has a plain p with no key as its top node.  Notice when you navigate between "PageA" and "PageB" the console reports that ondestroy is being called for the element.
This is unexpected, since the usual behavior for Hyperapp, when it encounters a node with the same tagName as the previous render, it will not destroy and recreate the element, but rather reuse it. (unless the node is keyed differently -- but that's not the case here)
Oddly, this destruction and recreation of the element can be prevented by adding a static key to the p, but that's not something one normally would need, since the vdom structure is identical each render.
So is this a serious problem? Not really. But it's unexpected if you believe yourself to understand how keys work and when their needed and not. In particular it can be confusing when using the router together with @hyperapp/transitions, as in this issue: https://github.com/hyperapp/transitions/issues/10

@zaceno Your view needs an unchanging root/top-level virtual node. Isn't that what this is about? 🤔

@jorgebucaran Nope that's not it. The thing is that the root (of each Page component) is unchanging. It's the same no matter which page you are routed to. Even so, for some reason Hyperapp is destroying and recreating the element every time I navigate to a different page, (causing ondestroy to be called on it).
So to clarify: the unexpected thing, in the example above, is that the ondestroy handler is being called, each time I navigate between pages.

@zaceno Good catch, this is somehow related to lazy components.

@zaceno I narrowed it down to resolveNode. The problem is resolveNode resolves to "" for null and undefined virtual nodes, which in the case of Route, is the case when a route doesn't match.
This means we always compare the node or oldNode (<p> in the example) against an empty string.
The correct solution is a proper fix to @jonlov's https://github.com/hyperapp/hyperapp/pull/636.

Aha! Makes perfect sense. Also explains how I was able to work around this behavior by using a common key for the root node of the two pages. Thanks!

The reason lazy components exists is because of all the boilerplate required in 1.0 to access the state and actions. In 2.0, since actions are no longer "wired" to your app, the boilerplate to pass the state around is minimal, so I see the lazy components used for something else, not to access the state, but to enable dynamic views instead.

If you wrap the routes with the <Switch> component it doesn't destroy the parent components. I'm not sure if we should change resolveNode to resolve to an empty element or leave it as it is. 🤔
If we return null on a component it shoudn't create any element, but it should reuse the old element if it was the same. How can we do this?
Does this mean that resolving "" is wrong?

So, I see this feature better directed to enable dynamic views instead (which are actually lazy).

I mean that I'll reuse the implementation of lazy components to implement dynamically imported components import(), but 1.0 lazy components will be removed from 2.0.

Got it! So this issue will be left like this for Hyperapp 1.0?

I think so, yes.

But I don’t think that it is a bug.
Just requiring that every element that has any lifecycle methods associated with it be keyed would solve that problem.


Support T5 models

I tried to load a T5 model but it seems not supported.
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
Cell In[5], line 7
      4 dtype = None # None for auto detection. Float16 for Tesla T4, V100, Bfloat16 for Ampere+
      5 load_in_4bit = True # Use 4bit quantization to reduce memory usage. Can be False.
----> 7 model, tokenizer = FastLanguageModel.from_pretrained(
      8     model_name = "google-t5/t5-large", # Choose ANY! eg mistralai/Mistral-7B-Instruct-v0.2
      9     max_seq_length = max_seq_length,
     10     dtype = dtype,
     11     load_in_4bit = load_in_4bit,
     12     # token = "hf_...", # use one if using gated models like meta-llama/Llama-2-7b-hf
     13 )

File ~/anaconda3/envs/pytorch_p310/lib/python3.10/site-packages/unsloth/models/loader.py:127, in FastLanguageModel.from_pretrained(model_name, max_seq_length, dtype, load_in_4bit, token, device_map, rope_scaling, fix_tokenizer, trust_remote_code, use_gradient_checkpointing, resize_model_vocab, revision, *args, **kwargs)
    125     dispatch_model = FastQwen2Model
    126 else:
--> 127     raise NotImplementedError(
    128         f"Unsloth: {model_name} not supported yet!\n"\
    129         "Make an issue to https://github.com/unslothai/unsloth!",
    130     )
    131 pass
    133 # Check if this is local model since the tokenizer gets overwritten

NotImplementedError: Unsloth: google-t5/t5-large not supported yet!
Make an issue to https://github.com/unslothai/unsloth!

All model support in the future will make T5s work!

Bump, this would be great!

Hi @danielhanchen, Is there any update on this feature?


Recent simplehtmldom broke VkBridge

Here: https://feed.eugenemolotov.ru/?action=display&bridge=Vk&u=id1&format=Html
Added following var_dumps for debuging.
diff --git a/bridges/VkBridge.php b/bridges/VkBridge.php
index 5274180..c95f8b9 100644
--- a/bridges/VkBridge.php
+++ b/bridges/VkBridge.php
@@ -144,6 +144,8 @@ class VkBridge extends BridgeAbstract

                        // get video on post
                        $video = $post->find('div.post_video_desc', 0);
+var_dump($post->outertext);
+var_dump($video->outertext);
                        $main_video_link = '';
                        if (is_object($video)) {
                                $video_title = $video->find('div.post_video_title', 0)->plaintext;

Here simple_html_dom somehow finds div.post_video_desc which does not exist in $post var.
But if I use page with that only that post, simple_html_dom does not find div.post_video_desc (which is good): https://feed.eugenemolotov.ru/?action=display&bridge=Vk&u=wall1_2442097&format=Html
Reverted these commits:
https://github.com/RSS-Bridge/rss-bridge/commit/052844f5e13c71ceefd743136a71f71226a0eefb
https://github.com/RSS-Bridge/rss-bridge/commit/014b698f6751655d3efe047cb0b951641936b9fe
https://github.com/RSS-Bridge/rss-bridge/commit/5656792cee3ddf4b38a60b6d05b5b08fa705a4c3
And it is fine: https://feed.eugenemolotov.ru/dev-vk/?action=display&bridge=Vk&u=id1&format=Html

Wow, this is really a nasty bug, took me quite a white to understand what is going on. Essentially the shiny new remove function is buggy and needs fixing upstream. Reverting 052844f5e13c71ceefd743136a71f71226a0eefb fixes it for now. I'll push in a few minutes. Let me know if you find further issues.

Let me know if you find further issues.

Looks like it is fine now.

Btw, thanks for quick fix!


snake

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Other: <!-- Please describe: -->

Current behavior

Expected behavior

Environment
Browser:

- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:

- Live Server: <!-- Check which version is installed -->
- Platform:  <!-- Mac, Linux, Windows -->
- Visual Studio Code: <!-- `code --version` -->

Others

what is the issue? I'm closing the issue since there are no details.  Feel free to create another issue request if you're facing anything.


Include  element in WriteCodeFragment header

to make analyzers happy.
Fixes #1925
cc @rainersigwald because I don't know better
Any chance to get this into 15.3? (happy to rebase)

Do you know if this made it into Core 2 Preview 2?

@bencyoung It missed the Preview 2 release, but will be in .NET Core SDK 2.0.0 final (and is in daily builds--I tested with 2.1.0-preview1-006635). I fixed up the release for MSBuild 15.3.388 to mention that it is what's included in .NET Core SDK 2.0.0 Preview 2.


Typo in cd command

The guide to create a wordpress docker container using docker-compose states:

if you named your directory my_wordpress:
 $ cd my-wordpress/

Obviously, you should cd into my_wordpress (with underscore).
The guide refers to my_wordpress later on (but never to my-wordpress).
This commit fixes just that.

Thanks, @ivanperez-keera  :)


sussy

Source? I don't imagine you ever ratting anything but uhm yeah. Also, I'd love to see some of that juicy menu code. Maybe I could implement my esp preview and my resolver if I can fix that dumb command nullptr bs. Or is this your project or?

or you could contact me on discord if you don't wanna publicly share the source: Smellon#8460 I got alot of ideas but I don't got any good sources to do anything with. I could also defo improve that menu.


A list of priority enhancements

end game at X number of rounds
show final score
social media share buttons

listing these as separate enhancements


examples: fix up

The examples merged in #52 were broken (and I merged them knowing this) so now let's work to make the implementation support them.
Relevant bugs:

#62
#63

Going to close this PR and resubmit due to shenanigans going on on GitHub/my local checkout.


Update Metadata

Keep meta consistent with contents of DB
Summary of Changes:

Adjusted Sri Dasam Granth section page numbers to reflect data

Move Kabiyobach Benti Choupai as a subsection of Charitropakhyan

Rename source to Vaaran Bhai Gurdas Ji
Rename source to Kabit Savaiye Bhai Gurdas Ji
Rename source to Guzals Bhai Nand Lal Ji
Rename source to Zindginama Bhai Nand Lal Ji

Change length to 1

Rename source to Ganjnama Bhai Nand Lal Ji
Rename source to Jot Bigaas Bhai Nand Lal Ji

Change section name to Farsi
Move Jot Bigas (Punjabi) as Punjabi section
Change length to 2

Fix Rehitname source page names
Move Uggardanti to last position
Rename writer to Guru Amardas Ji
Rename writer to Guru Ramdas Ji
Rename writer to Satta and Balwand

My proposal here: https://docs.google.com/spreadsheets/d/1Iu6o0C6FfzjpH0Us9fDZAlabQBrV9rP3miRlKMnWIG8/edit?usp=sharing

Closing in favor of new PR


Add -print-zero-stats to fix ensure_no_astgen.swift in release mode

as stats collection depends on asserts enabled or forced stats collection.
Fix diagnostic when compiler is built without statistics support.

@swift-ci please test

@swift-ci please test

Test Case '-[SwiftDocCTests.DeclarationsRenderSectionTests testAlternateDeclarations]' started.
/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift-docc/Tests/SwiftDocCTests/Rendering/DeclarationsRenderSectionTests.swift:147: error: -[SwiftDocCTests.DeclarationsRenderSectionTests testAlternateDeclarations] : XCTAssertEqual failed: ("1") is not equal to ("2")
Test Case '-[SwiftDocCTests.DeclarationsRenderSectionTests testAlternateDeclarations]' failed (1.262 seconds).

swift-docc test failure appears unrelated as it is happening during other CI runs.

@swift-ci please smoke test


Bug Fix: Fix issue where triple-clicking a cell would dangerously select entire document

Description
Triple-clicking may seem esoteric at first but it's a relatively common interaction for quickly selecting whole blocks. For example, triple clicking a paragraph selects the entire paragraph (at least on macOS).
We were seeing a strange issue for some of our users: their entire document would go missing. When we worked with some of these users, we found that previous revisions of their doc showed that it consisted of only a single large table.
After it happened to one of our team members, we found that it was very easy, particularly on mobile, to accidentally select the entire table while trying to tap a single cell to edit. It's my theory that when tapping very rapidly on mobile, a triple-click event gets processed.
Nonetheless, it's easy to replicate this issue on desktop in the playground:

Create a table of any size
Write some text in the last cell
Triple click on the text in the last cell

Result: entire document get highlighted. One keystroke at this point is all it would take to wipe your entire document.
Expected result: only the text in the cell gets highlighted.
In my opinion the code responsible seems relatively dangerous: reaching out to the parent to grab some more nodes for selection. And in fact the issue that the original code was added to address does not seem to be affected by the removal of this code, as evidenced by the passing of the test added in that commit: https://github.com/facebook/lexical/commit/2b2a4f61b6b0c66721fd22e2c7900d0e4c3114d5
It's also my opinion that for large open source projects like this, tests should be the ultimate way of determining what stays and what goes. At some point there will no longer be anyone involved in the project who has all the historical context necessary to determine whether a change is harmful or beneficial, and its up to the tests to defend each change.
In this case, the removal of this code does not harm anyones tests, and improve the usecase mentioned above.
Test plan
A test was added that fails without the fix. Without the fix, the test would fail because the entire document would be highlighted.
Before
https://github.com/user-attachments/assets/a3bacdd1-1a75-492a-ace9-89c3600d7954
After
https://github.com/user-attachments/assets/1c2a3251-42e6-4969-b6ee-43883f5e0390

Thank you, this logic was introduced just recently #5766, @ivailop7 @AlexanderReznik @Shubhankerism do you have some thoughts here?

I'm OK with this change

This has broken the selection when started inside of the table on the edge (1st or last row) that goes outside.

You can see on the gif that the lexical selection is not matching the dom selection and not the whole table is selected.

Honestly it's not unexpected that there wouldn't be some side-effects. This is a symptom of the problem of e2e tests not being required for every PR here.

While it would be of course ideal to have 100% code coverage that tests every possible use case I'd say it's quite unrealistic to expect from an open source project of this scale. And given that there isn't a 100% test coverage just relying on the fact that the tests are passing is not enough.
Please next time you contribute spend some time to understand what the code actually does.
https://sproutsschools.com/chesterton-fence-dont-destroy-what-you-dont-understand/

I'd say this is the likely fate of any large open source project: https://news.ycombinator.com/item?id=18442941
Ultimately it's up to the maintainers to accept/reject changes. For changes outside a particular reviewer's area of familiarity/expertise, I honestly can't imagine how they can do their job properly other than basing it off tests. The alternative is that PRs would never get merged from fear and you'd have a stagnate project. This codebase is well written but deals with a domain that is just too complex and vast for any one person to understand.
I've opened a PR that fixes the regression: https://github.com/facebook/lexical/pull/6579

I think the problem here is more that there's a lack of specification. With or without tests, there's no clear description of what should be happening in a lot of these complicated cases where you have many different components interacting. The tests lock in a sort of specification but without a clear description of intent it could just be a "snapshot" test of some implementation quirk.


Topic Recognition (s47605790): StyleGAN on the ADNI dataset (Task 8)

Hello Teaching Team,
This is my pull request for my project, which involves the implementation of a StyleGAN model on the ADNI dataset using PyTorch (Task 8). The model is designed to generate synthetic brain images similar to those in the ADNI dataset.
Included files and folders:

dataset.py: Prepares the data for the model
modules.py: Contains the components of this project
train.py: Responsible for training the model and generating the loss plot
predict.py: Used for testing the model and generating the UMAP embedding plot
README.md: Documentation of the project
readme_materials: Assets used in the README.md
All project details are documented in the README.md file.

Thanks,
Tin Trung Nguyen
Student ID: 47605790

Recognition problem: StyleGAN on ADNI ---- Hard Difficulty

Algorithm solves the problem: (3 Marks)
Not clear generated images (noise and grids) -1;
Unreasonable losses (even for GAN) -0.5;
Unreasonable embedding (on real/generated images instead of the style code) -0.5

Algorithm demonstrated and functions: (2 Marks)
Alaogirhtm demonstrated properly yet does not function as required -1

Design: (1 Mark)
Modularized design

Commenting: (1 Mark)
Sufficient docstrings and comments

Algorithm above Normal Difficulty: (5 Marks)

Algorithm is Hard difficulty: (5 Marks)

Suggestions:

The poor generated images suggest the model structure and its training process could be problematic, something I spotted for example:
-- No activation in the mapping network, so no non-linearity to map the z to w;
-- upsampling in the generator performed without following with a convolution, so the upsampled/stretched values could be in grid patterns;
-- training G more often could be helpful to avoid overly powerful D, but it also could introduce noises as it tries to "fool" the D too much without much useful feedback from the D ---- you can try gradient penalty on D instead;
-- scheduler with step 20 could still be too much, you can try "ReduceLROnPlateau" or smaller LRs;

The UMAP should be plotted on the style code w, not the stacked_images = np.vstack([generated_images_np, np.vstack(all_images)]). So your UMAP demonstrates difference between real and generated images, not the learned two classes;

This is an initial inspection, no action is required at this point

Solves problem: Good introduction of the network. The training loss indicated the model was not yet converged. The generated images are quite noisy and have no clear structures. The UMAP plot showed a clear separation between generated and real images, this indicates the inputs of UMAP are generated images and real images, but the input should be style code. UMAP is to estimate AD and NC.
Implementation: Hyperparameters were hard-coded. Otherwise, it's all good and well-modulized.
Design: Good
Comment: Detailed and sufficient
Difficulty: Hard

Note
pycache should not be committed.

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation. -1
Spacing and comments.
Header blocks.
Recognition Problem
OK solution to problem. Low image quality, unreasonable loss.-3
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found.
Difficulty : Hard. StyleGAN (Hard Difficulty)
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Acceptable. Unreasonable embedding.-1
Model/technical explanation :Good.
Description and Comments :Acceptable. No usage.-1
Markdown used and PDF submitted. PDF Checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). ON time.
No Feedback required. Remove cache files for merge.
Request Description is good.
TOTAL-6

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

Feedback marks possible +2 if the requested changes are made (see above).

Hello, thank you for the marking and feedback request. I have made the changes and updated the pull request. Thanks again!

The quality and loss issues -2 +2 for feedback.


Using Concatenate&ParamSpec leads to skipped parameter in popup-window.

 Environment data

Language Server version: 2022.8.50
OS and version: darwin arm64
Python version (and distribution if applicable, e.g. Anaconda): 3.8.13
python.analysis.indexing: null
python.analysis.typeCheckingMode: off

 Code Snippet

P = ParamSpec("P")
def tester(c: Callable[Concatenate[int, str, P], None]) -> Callable[Concatenate[int, P], None]:
    pass

@tester
def foo(a: int, b: str, c: str, d: str):
    pass

Using python 3.8 and typing_extensions package.
The first parameter P captures isn't  shown in the popup-window when calling foo.
Note that this does not happen when using just P as the return value.
 Expected behavior
Parameter 'c' should be coloured blue.
 Actual behavior
Parameter 'd' is assumed to be the next parameter.

Also:

If each argument is documented the correct argument documentation is shown while the blue 'you're currently at that argument'-marker is still wrong.

When naming the parameter (e.g. foo(3, c="h...) the behaviour still holds that one parameter to the right is blue - even with more parameters.

Yes, this looks like a bug in the "signature help provider", which is the part of pylance responsible for providing the signature help displayed in this popup window.

This issue has been fixed in prerelease version 2022.9.21, which we've just released. You can find the changelog here: CHANGELOG.md


express middleware doesn't allow user to configure custom transports

Originally reported here: https://github.com/googleapis/nodejs-logging-winston/pull/182#issuecomment-484692277

Either we should provide users to configure a set of transports for the winston loggers we create.
Or we should not be in the business of creating winston loggers. The users should instantiate the logger and pass to us. This is probably too complicated because we conditionally need to create two loggers.

@googleapis/node-team opinions?

I'd definitely prefer if there was a way to pass in a root logger which the middleware one would inherit from!
But FWIW I found a workaround to the transport issue which does the job:
// index.ts
app.use('/graphql', (req, res, next) => {
  // this is where we call the Google logging middleware so that it can generate the tracing code
  if (googleMiddleware) {
    return googleMiddleware(req, res, next)
  }
  next()
})

app.use('/graphql', (req, _, next) => {
  if (googleMiddleware) {
    // in development we need to add the Console transport to Google logging middleware's Winston
    // instance injected above so we can see the output
    if (DEV) {
      req.log.add(new winston.transports.Console())
    }
  }
  next()
})

For further context I also define a global logger which then gets updated using the instance returned by the middleware. I'm using Winston's configure method to write my settings back, which then also get inherited by the child instances created per request:
// logger.ts
import util from 'util'

import winston from 'winston'
import { LEVEL, SPLAT } from 'triple-beam'

export const DEV = process.env.NODE_ENV !== 'production'

export const defaultMeta = {
  app_name: process.env.APP_NAME,
  release: process.env.RELEASE,
}

let winstonFormat = winston.format.json()
if (DEV) {
  winstonFormat = winston.format.combine(
    winston.format.colorize(),
    winston.format.timestamp(),
    winston.format.printf(
      ({
        level,
        message,
        timestamp,
        // we're destructuring these Symbols so that they don't show up in meta
        [LEVEL]: levelSymbol,
        [SPLAT]: splatSymbol,
        ...meta
      }) => {
        return `${timestamp} ${level}: ${message}\n${util.inspect(meta, {
          colors: true,
          depth: 5,
        })}`
      },
    ),
  )
}

export let logger
export function createLogger(loggerInstance) {
  logger = loggerInstance
  logger.configure({
    level: process.env.DEBUG ? 'debug' : 'info',
    transports: loggerInstance.transports,
    format: winstonFormat,
    defaultMeta,
  })
}

createLogger(
  winston.createLogger({
    transports: [new winston.transports.Console()],
  }),
)

export default logger

To make this work without the very awkward async init function I bootstrap the middleware like this:
// index.ts
let googleMiddleware
LoggingWinston.express
  .middleware({
    serviceContext: {
      service: process.env.APP_NAME,
      version: process.env.RELEASE,
    },
    level: process.env.DEBUG ? 'debug' : 'info',
  })
  .then(({ logger: googleLogger, mw }) => {
    // we need to update our logger with the instance supplied by the Google library
    createLogger(googleLogger)
    googleMiddleware = mw
    logger.info('Google logger Express middleware initialised')
  })
  .catch(error => {
    logger.warn(
      'Could not initialise Google logger Express middleware, error:',
      { error },
    )
  })

I'd highly recommend updating the code snippet in the README as the async function creates a lot of issues, amongst others breaking Nodemon, making Express non-responsive for ~2 seconds longer, etc.

What I realised while testing in GKE is that winston.transports.Console needs to be added in the deployed service too, otherwise the output won't be under container logs (only projects/<project id>/logs/winston_log_applog), unless I'm missing something?

The container logs via winston.transports.Console will not have the trace metadata though 😿
Is there any chance setting the resource bit?

There needs to be a wrapper for the winston.createLogger function that returns your own logger, but configured for express.

What I realised while testing in GKE is that winston.transports.Console needs to be added in the deployed service too, otherwise the output won't be under container logs (only projects/<project id>/logs/winston_log_applog), unless I'm missing something?

Hi daaain did you get any further with this?

@EdByrnee yeah, with the latest version (1.1.0) it's almost there...
This is how my code looks now:
// logger.ts
import util from 'util'

import winston from 'winston'
import { LEVEL, SPLAT } from 'triple-beam'

export const DEV = process.env.NODE_ENV !== 'production'

export const defaultMeta = {
  app_name: process.env.APP_NAME,
  release: process.env.RELEASE,
}

let winstonFormat = winston.format.json()
if (DEV) {
  winstonFormat = winston.format.combine(
    winston.format.colorize(),
    winston.format.timestamp(),
    winston.format.printf(
      ({
        level,
        message,
        timestamp,
        // we're destructuring these Symbols so that they don't show up in meta
        [LEVEL]: levelSymbol,
        [SPLAT]: splatSymbol,
        ...meta
      }) => {
        return `${timestamp} ${level}: ${message}\n${util.inspect(meta, {
          colors: true,
          depth: 5,
        })}`
      },
    ),
  )
}

export let logger
export function createLogger(loggerInstance) {
  logger = loggerInstance
  logger.configure({
    level: process.env.DEBUG ? 'debug' : 'info',
    transports: [
      new winston.transports.Console(),
      ...loggerInstance.transports,
    ],
    format: winstonFormat,
    defaultMeta,
  })
}

createLogger(winston.createLogger({}))

export default logger

// index.ts
...

let googleMiddleware
LoggingWinston.express
  .middleware({
    serviceContext: {
      service: process.env.APP_NAME,
      version: process.env.RELEASE,
    },
    level: process.env.DEBUG ? 'debug' : 'info',
  })
  .then(({ logger: googleLogger, mw }) => {
    // we need to update our logger with the instance supplied by the Google library
    createLogger(googleLogger)
    googleMiddleware = mw
    logger.info('Google logger Express middleware initialised')
  })
  .catch(error => {
    logger.warn(
      'Could not initialise Google logger Express middleware, error:',
      { error },
    )
  })

app.use('/graphql', (req, res, next) => {
  // this is where we call the Google logging middleware so that it can generate the tracing code
  if (googleMiddleware) {
    return googleMiddleware(req, res, next)
  }
  next()
})

// OPTIONAL
app.use('/graphql', (req, res, next) => {
  // insert tracing header into response so we can log on the client
  if (googleMiddleware) {
    res.set('x-cloud-trace-context', get(req, 'headers.x-cloud-trace-context'))
  }
  next()
})

...

In the Global view I get the requests bundled now (although in the wrong order 😞 ), but in the container log (via winston.transports.Console) it's just a linear log. Which is maybe because the middleware only sends the special bundler log message via the built in transport?

Oh, and almost forgot to mention that the containers do not log in the Global logs (only the local development instance in Docker Compose), but in the GKE Container one. Which annoyingly is not the same as the one you can access when clicking on the Container logs link under a GKE Workload. So currently I have logs from the same application in 3 different places / logs.
I think that's because the resource metadata isn't filled in properly.
This is how it looks like in log entries under GKE Container stored by the middleware:
 resource: {
  labels: {
   cluster_name: "master"
   container_name: ""
   instance_id: ""
   namespace_id: "default"
   pod_id: ""
   project_id: "basis-janssen-test"
   zone: ""
  }
  type: "container"
 }

And this is how it looks like in the "proper" container logs, currently stored via Console transport:
 resource: {
  labels: {
   cluster_name: "master"
   container_name: "graphql"
   location: "europe-west2-a"
   namespace_name: "default"
   pod_name: "graphql-85bf76c55c-vqstq"
   project_id: "<project id>"
  }
  type: "k8s_container"
 }

Maybe I should open this as a new issue? Though this might be an upstream one?

the async function is too awkward

Async function is necessary because, various things can fail (asynchronously) trying to instantiate a connection to Stackdriver Logging service. The middleware needs to open this connection on your behalf. If we do not make the construction async, things would be even more awkward. Failure to initialize logging would be considered to be a fatal problem by many folks.
If the construction is sync, we have only two choices:

Throw error asynchronously. You cannot catch async errors except through global uncaught exception handlers.
Raise the error when you attempt to log. Most people don't install callbacks on individual log messages, so this error would go silently ignored by most. Even if that was not an issue, it would quite awkward to have each log statement in your app installing a calling to deal with an async init failure.

The only alternative to async init I can think of is for the users to initialize a @google-cloud/logging instance and pass that in. That way, the middleware would not be responsible for async init, and the onus of dealing with errors would be entirely on the users.

@ofrobots I completely understand the library's internal init being async, my beef was using the async function in user code as in the code example in the readme.
As you can see in the code examples I posted above it's completely possible to not have an async function, but work with the promise. But ideally this should be something the library does for me.
The main issue with doing it this way is that the logger instance is undefined until the async middleware init returns its own, so that's why I create a Console only Winston instance and replace it with the middleware's one once it's ready.
Not only does this solve the async problem, but makes the logger importable anywhere in the source code without having to wait for the async function to return the instance everywhere in the codebase which would be horrendous.

In order to keep the discussion focussed, I've split the async init issue to #355. Let's keep this issue focused on allowign users to customize transports.
@daaain

I'd definitely prefer if there was a way to pass in a root logger which the middleware one would inherit from!

We actually need (conditionally) two loggers to be provided as we need to use different transports for the application log and the request log. This is a requirement for request bundling to work correctly. I am afraid this would be too complex for users to understand.
An alternative would be for a createLogger function to be provided by the user that we could call. You could install your transports there. Would that work ?

@ofrobots couldn't both of these loggers be created as children of the root logger passed in, like you do with the request loggers?
Or, since the LoggingWinston.express.middleware constructor accepts an options object parameter, there could be a config property on it which can be used to pass any standard Winston config. This would be used as the starting config which the middleware can then enhance with additional transports, metadata, etc and create children of for each request.
Ideally the logger instance should be returned immediately alongside the async promise to be available for use (and export) right away, instead of when the promise returns. The log messages could be queued up until async the Stackdriver transport is ready, but emitted immediately on other transports.
This is pretty much what I implemented in the code examples above (except the queue), but would be great if the library took care of it and I only needed to pass my formatter and conditionally add console transport if it's in dev.

I figured out a way to do this without needing two different TransportStreams (and hence two different winston Loggers). https://github.com/googleapis/nodejs-logging-winston/pull/364


Remove -dev from manifests

Fixes this error:

LGTM

Reviewed files:

src/chrome/app/manifest.json @ r1
src/chrome/extension/manifest.json @ r1

Comments from the review on Reviewable.io

sorry, I didn't mean to push these to dev-requireify. Can you check the firefox one too?


Poing 7 fixes

• The script didn't work, it just sent you back to AGS since it failed — Poing 7 has a different structure than the others. (It might work on your local version if you probably created/copied these files to the save directory)
• Poing 7 doesn't define a default.levels file, so we have to pick one (ReadMe file mentions jb1.levels, so I picked that one — Poing 6 uses jb2, there's also g10.levels and gerske.levels, plus Poing 1/4/5 levels)
• There's no default.scores file, and since they are incompatible across level sets, it's probably better to just let the game create one when launched, so I removed that line

👍


Support for Blizzard Interactives new Dev/OAuth API

Not really an issue as much as a request.
Blizzard Interactive has announced a new set of API's for their systems, including publicly available ones that are trimmed with OAuth security.
https://dev.battle.net
I tried to use the 'generic' OAuth objects in the Owin.Security.Providers to no avail.  Any chance you could take a look at their implementation and see what it would take to support it?
I have an active blizzard account and so would be able to help as best I can.
Thank You

This code is hardcoded to work only against the authentication servers in Europe. I'd like this to be generalized - for starters by including more of the configuration strings in the options class as I see it is done for example in the vNext code. I'll give it a try if you're OK with that.
Are there plans to port this package to ASP.NET 5? Or is there another repository for that? Seeing the code for the Microsoft packages for Microsoft accounts, Google, Facebook and Twitter in https://github.com/aspnet/Security/ that shouldn't be hard to do at all.

Ah, you are right. My mistake and I'll look into it as soon as possible.

@ericwj As far as ASP.NET 5 is concerned, I reached out to see whether I could upgrade these providers to support ASP.NET 5 and then integrate it into the aspnet/Security repo, but they were not keen on that and suggested that they may set up another organization where "community" projects like these go.
That being said, once ASP.NET 5 comes out, the need for this project will go away almost completely. They have added a new, very generic, OAuth provider which can be make to work against most providers with a little bit of configuration. See https://github.com/aspnet/Security/blob/dev/samples/SocialSample/Startup.cs
Sometimes the configuration can become a little bit elaborate, as you can see in some of those demos, so what I am in the process of doing is setting up a website (oauthforaspnet.com) where I will give people the correct source code to configure ASP.NET 5 to work against the service of their choice.
I have not added this work to the live website yet, as the stuff around the Security providers is too much in flux at the moment. Maybe by the time the next beta hits it will be at such a stage that I can start doing my work to add them to the website.

Yeah if it's in that repository, it actually means Microsoft will actively support it even by phone and whatnot, so they will want to keep it fairly limited.
Yet to only have code samples to copy from a website is perhaps a step back. I can imagine it'd be more valuable even to have each provider have its own .nupkg in the feed - that would fit nicely with the strategy for NuGet going forward.
Those projects will be mostly very small as a result of the generic one being - well, generic, but then there's special stuff that can go in such a project as well, for example the 5 OAuth servers that Blizzard actually has and each provider has quirks, special claims to make or data that would be useful to type just once...the ideal would still be to only have to add a package, type a secret or two and get going, shouldn't it be?

@KetaSwe didn't mean to put the heat on you, I wrote some code myself already ;)

@ericwj Thanks for your feedback. Once the Security API stabilizes a bit more and I have a clearer direction of exactly what Microsoft is doing with the new versions I will re-evaluate. If it makes sense to write tiny little wrappers arounds the generic one in certain instances then we can certainly approach it like that.

I have made a pull request now with changes to the battle.net provider. I added a Region property in Options where you can specify the region you want for the authentication.

What's the expected pattern if you want to authenticate against any region?  Can you register BattleNetAuthenticationOptions multiple times with different Regions?

I am not sure about the Blizzard implementation, but here is a blog post about registering providers multiple times. Maybe it will help:
http://umbraco.com/follow-us/blog-archive/2015/3/26/configuring-aspnet-identity-oauth-login-providers-for-multi-tenancy


Multiple include blocks

This is the implementation of the feature described in https://github.com/gruntwork-io/terragrunt/pull/1803
This is backward compatible for the most part, except for the expose feature, where you must now index into the label - any prior references to exposed include must be updated to include[""]. E.g., if the user had:
include {
  path = find_in_parent_folders()
  expose = true
}

inputs = {
  region = include.locals.region
}

the include.locals.region reference must be updated to include[""].locals.region.
include {
  path = find_in_parent_folders()
  expose = true
}

inputs = {
  region = include[""].locals.region
}

Thanks for review! Will merge this in, cut a new release as backward compatible (given how much code change there is to the include machinery), and then open a follow up PR to update that function docs.


Minor improvements to READMEs of docker-compose-based install methods.

@cla-bot[bot] check

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.


CoffeeLint for CodeMirror

Look at enabling this addon:
https://github.com/codemirror/CodeMirror/blob/master/addon/lint/coffeescript-lint.js

closing as dupe of #271


add Mastodon link to the website

It will be great to have a Mastadon account for privacytests! Adding it to the website helps in discoverability. Also, you can make it a bot account so that whatever you tweet on Twitter will be reflected in your Mastadon profile.


Logging revamped

Description
Now we are using python logging best practices, each module.py has it's own logger with logger.getLogger(), formatting is also a lot better now.
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Resolves #308
"BEFORE" and "AFTER" output
BEFORE
Example log output:

Unknown log level selected, using info

AFTER
Example log output:

2020-03-04 13:24:52,826 WARNING root Unknown log level selected, using info

Contribution checklist

[X] I have read the Contributing Guidelines.
[X] The commits refer to an active issue in the repository.
[ ] I have added automated testing to cover this case.

Notes
Logging is ignored by setup.cfg so no need to test it

Codecov Report

Merging #318 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   60.11%   59.56%   -0.55%
==========================================
  Files          41       41
  Lines        1963     1939      -24
==========================================
- Hits         1180     1155      -25
- Misses        783      784       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c34a62...864ef31. Read the comment docs.


Improve sound features of bug UI

Maybe with a SoundProvider at the top of the application. Maybe use sound names rather than filenames.

There's probably a nice library to do this for you...?

We're already using a library to run sounds as hooks, there's no reason they can't be wrapped in a provider at the top of the application. A simple lookup could allow you to call them by name rather than filename


Fix Python 3.8 compatibility

Recent change introduced typing that is incompatible with Python < 3.9. There are other Scylla projects relying on CCM (e.g. most drivers) and for some of them this change caused CI failures (as of now - for Rust driver and Python driver).
This PR fixes the problem by making this typing compatible with older Python versions.
It also adds CI that runs on older Python. I wanted it to be 3.6, because that's the oldest version supported by Python driver, but it seems this version can't be installed by setup-python@v4 action, so I bumped it to 3.7

@Lorak-mmk we are not running python-driver integration tests with all versions of python (only the unittests)
I'm o.k. with doing 3.8 and up.
but we should upgrade CI where it's relevent to to 3.9 at least


fix: Patch KFP Profile Controller service port

Patch the port specified in the K8s service created by Juju to point to the one the controller pod responsible for running the sync.py script listens to.
Closes https://github.com/canonical/kfp-operators/issues/317
Refs https://github.com/canonical/kfp-operators/issues/314

Persistence and API integration tests are expected to fail until this is addressed:

https://github.com/canonical/kfp-operators/issues/316

Reproduced as described in #317
Rebuiled kfp-profile-controller charm using this PR branch.
Followed steps in #317, but deployed locally build kfp-profile-controller charm.
Verified that port is set correctly to 80:
 kubectl -n kubeflow get svc kfp-profile-controller -o yaml
apiVersion: v1
kind: Service
metadata:
  annotations:
    controller.juju.is/id: 02e83337-6eaf-458e-857e-c334bf9a82a7
    juju.is/version: 2.9.44
    model.juju.is/id: d1d9e28e-d9f3-4aaa-8cfe-5636e57f914c
  creationTimestamp: "2023-09-06T20:02:24Z"
  labels:
    app.juju.is/created-by: kfp-profile-controller
    app.kubernetes.io/managed-by: juju
    app.kubernetes.io/name: kfp-profile-controller
  name: kfp-profile-controller
  namespace: kubeflow
  resourceVersion: "5710"
  uid: 5341c184-fe8d-4c92-b9b8-94bc6c3509af
spec:
  clusterIP: <IP_ADDRESS>
  clusterIPs:
  - <IP_ADDRESS>
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - name: http
    port: 80
    protocol: TCP
    targetPort: 80
  selector:
    app.kubernetes.io/name: kfp-profile-controller
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

Verified integration test. Works as expected, all test passed.
Test execution
test


chore: automate go version upgrade

We use the latest version of Golang for executing the tests.
We change the structure of the Makefile and the run-test GitHub action to bump the Golang version automatically in the Makefile, go.mod and GitHub action files.
#186180915

We avoid updating the Golang version so as not to force external projects to use a different version of Golang than desired


Closing Settings takes more than 20s

When page is reloaded inside some of the settings pages (Extensions, Preferences, Cluster Settings etc) user need to wait more than 20s (> 30s in dev build) after hitting ESC key without any meaningful "loading..." messages.
We should speed up this process or at least provide some visible "Loading" component.
Dev build
https://user-images.githubusercontent.com/9607060/115831576-72610d00-a41a-11eb-97d3-8bbff339e73e.mov
Production build
https://user-images.githubusercontent.com/9607060/115832087-1f3b8a00-a41b-11eb-897d-373e2b072bae.mp4

Maybe fixed by #2591, would you mind checking again @aleksfront ?

I have checked and it now takes about 4s on a dev build. So I think that the above helped a lot

Fixed in #2591


fix: constrain version for iam-role-for-service-accounts-eks module

constrain version to prevent inheritance of breaking changes as described here

/update autoformat

/test make=pre-commit-renovate region=us-gov-west-1

We can close this with the upstream changes fixed in https://github.com/terraform-aws-modules/terraform-aws-iam/pull/532


Logging of every GraphQL Request

Currently the API is logging every mutation that a user is doing.
While this is great we don't have logging on the requests that are reading only.
this can be a quite easy log with these parameters:

GraphQL Query
GraphQL Parameters
User that does the query

https://github.com/uselagoon/lagoon/pull/3520


Stop colorizing the JSON output

If using a terminal then jq prints out JSON with color.
I suggest color should either be disabled always or with some other flag (more complicated)
jq flag: -M monochrome (don't colorize JSON);

Thanks @james-portman-contino, what is the use case for this? If you process the json output, what is the point is having it with or without color?
Sent with GitHawk

It is not actually possible to process it (with code/machine) with colored output, so it is only human readable at that point.
I think the default should be for it to actually output as valid JSON (not colored).
If someone wants it colored then they could pipe it into jq with color enabled, or whatever else they prefer

That’s weird because I know about so many people using it that way with splunk, ELK, etc. I also integrated it with Wazuh using default json output. In any case having json output colored or not is not important so let’s merge it and if any other user complaints we can always revert it easy.
Sent with GitHawk

Thanks, the bit I might have missed is that jq colors the output depending on whether you have a terminal or not, in my case it was docker-compose making a terminal by default, which in turn made jq turn color on.
I think jq should really change its default to not color but that might take longer to fix..


Added flag to check unique urls only once

@ntotten are you still interested in completing this?

I've made the requested changes since this would be helpful for me on #8.
The only thing that I didn't agree with @stevenvachon on was that the request should be returned multiple times if cachedResponses is set to true. If the user specifies that they only want the request made once, I think it would be confusing to have a response reported multiple times. This is especially true since they are likely making this request with the understanding that the decreased verbosity means that some requests might be made multiple times.
Happy to discuss on #8.


Navigator transition glitch nested navigators macOS

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
It only happens on macOS. On Linux and Windows it doesn't happen because the animation is different.
When you navigate to a new screen inside a nested navigator, the transition has an strange glitch. See the attached code and the attached video.
Expected results
The transition should not have that glitch.
Actual results
The animation has a glitch. See the attached video.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Nested navigators',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class NavigatorScreen {
  final String label;
  final GlobalKey<NavigatorState> globalKey;

  const NavigatorScreen({
    required this.label,
    required this.globalKey
  });
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final List<NavigatorScreen> globalKeys = [
    NavigatorScreen(
      label: "Screen 1",
      globalKey: GlobalKey<NavigatorState>()
    ),
    NavigatorScreen(
      label: "Screen 2",
      globalKey: GlobalKey<NavigatorState>()
    ),
    NavigatorScreen(
      label: "Screen 3",
      globalKey: GlobalKey<NavigatorState>()
    ),
    NavigatorScreen(
      label: "Screen 4",
      globalKey: GlobalKey<NavigatorState>()
    ),
    NavigatorScreen(
      label: "Screen 5",
      globalKey: GlobalKey<NavigatorState>()
    ),
  ];

  int selectedScreen = 0;

  @override
  Widget build(BuildContext context) {

    void onScreenChange(int val, BuildContext context) {
      if (selectedScreen == val) {
        globalKeys[val].globalKey.currentState!.popUntil((route) => route.isFirst);
      } else {
        if (mounted) {
          setState(() {
            selectedScreen = val;
          });
        }
      }
    }

    return Material(
      color: Colors.transparent,
      child: Row(
        children: [
          Expanded(
            flex: 1,
            child: Scaffold(
              appBar: AppBar(
                title: const Text("Nested navigator"),
              ),
              body: ListView.builder(
                itemCount: globalKeys.length,
                itemBuilder: (context, index) => ListTile(
                  title: Text(globalKeys[index].label),
                  onTap: () => onScreenChange(index, context),
                )
              ),
            )
          ),
          Expanded(
            flex: 2,
            child: IndexedStack(
              index: selectedScreen,
              children: globalKeys.asMap().entries.map((e) => Navigator(
                key: e.value.globalKey,
                onGenerateRoute: (route) => MaterialPageRoute(
                  settings: route,
                  builder: (context) => Scaffold(
                    appBar: AppBar(
                      title: Text(e.value.label),
                    ),
                    body: Center(
                      child: ElevatedButton(
                        onPressed: () => Navigator.push(context, MaterialPageRoute(
                          builder: (context) => Subroute(routeName: e.value.label)
                        )),
                        child: const Text("Navigate to subroute")
                      ),
                    ),
                  ),
                ),
              )).toList(),
            )
          )
        ],
      ),
    );
  }
}

class Subroute extends StatelessWidget {
  final String routeName;

  const Subroute({
    Key? key,
    required this.routeName
  }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("$routeName subroute"),
      ),
      body: Center(
        child: Text("$routeName subroute"),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://user-images.githubusercontent.com/47545344/235250688-0d3e9270-eb39-44fb-8813-2a69d5c0e6ff.mp4

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.3.1 22E261 darwin-arm64, locale es-ES)
    • Flutter version 3.7.12 on channel stable at /Users/juan/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (11 days ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/juan/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/juan/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.3.1 22E261 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 112.0.5615.137

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@JGeek00  I remember seeing this issue before but cannot find the link to it. Not sure if it was by design, but the solution was to wrap the Widget with in a ClipRect. In your case, wrapping the IndexedStack widget with ClipRect will eliminate the overflow animation.
PS: To replicate the same undesired behavior on any platform, you can replace the MaterialPageRoute with CupertinoPageRoute

Hi @JGeek00, this issue has been fixed on the master & beta channels and should be available on the stable channel sometime in the future. The root cause of this issue is https://github.com/flutter/flutter/issues/113130.
Per our triage policy, I'll close this since it has already been fixed on the master channel. If you run into this issue on the master or beta channel, kindly leave a comment below and I will reopen this issue.
Thank you

@JGeek00 I remember seeing this issue before but cannot find the link to it. Not sure if it was by design, but the solution was to wrap the Widget with in a ClipRect. In your case, wrapping the IndexedStack widget with ClipRect will eliminate the overflow animation.
PS: To replicate the same undesired behavior on any platform, you can replace the MaterialPageRoute with CupertinoPageRoute

That worked for me. Thank you.


No documentation for searchEntry

I was unable to find any reference documentation for searchEntry. This seems like something that most users would need.

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.


Import SQL: Add and clean up progress logs

Description
Our logs for imports are quite sparse right now.
We've gotten requests to separate/better organize logs, especially for imports that complete really fast.

Current Logs

Adding logs for search and replace progress
Require confirmation from users to verify search-replace values + send Track event if user bails
Note the start & stop of each piece for better clarity (S-R, SQL validation, etc.)
When we exit on error, log a message instead of just exiting suddenly

Also some fixes:

Upon cancelling the confirmation prompt when the in-place flag is set, exit instead of continuing on
Ensure we're returning the outputFileName when the in-place flag is set

Steps to Test

Check out PR.
Run npm run build
Run an import:

VIP_PROXY="<proxy>" node ./dist/bin/vip-import-sql @2909.develop /path/to/file/dump.sql --search-replace="platform-import-test.go-vip.net,test-import.com"

Verify you see the correct progress logs:

Revised Logs

Try the command again and answer no/false to some of the prompts. Verify that the program exits
This time, try the command with the --in-place flag and verify the appropriate logs

Thank you for the review! Tests were also failing, but I finally got them working 😌
Should be good to go now 👍

Thank you for the review! Tests were also failing, but I finally got them working 😌
Should be good to go now 👍


Hunleff pet glow not updating with metamorphosis

drop hunleff
change color
glow is the 1st color and does not update

this issue was fixed here https://github.com/RS117/RLHD/pull/92


feature -  profile

Github Issue URL/Tags (required)
What's this PR do? Please give a technical summary (required)

[x] mvvm
[x] dummy data

Any references (stackoverflow …) (optional)

:+1: There are no linter violations.


createSchema method on stores

Will help to initialized the DB (create Tables, indexes, collections, column family depending on underlying implementation.)

All stores have the createSchema(), sometimes it does nothing.
A new button is available in the console as well


Fix for browse_catalog_bundles failing with HTTP 400 when using bundle_relationship_type::bundles_with_product

@CameronGoodwin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@CameronGoodwin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Explanation of @PerActivity

This is not really an issue, as much as a question: How is the @PerActivity scope enforced?
I can never seem to find how exactly scopes work in Dagger 2. Could you may be eleborate more on that? (or provide a link where it is explained?)

http://fernandocejas.com/2015/04/11/tasting-dagger-2-on-android/

So if I'm understanding it right, the @PerActivity will work exactly the same as @Singleton if we never recreate the ActivityModule?

It would be nice to try that by the way...

This is actually one of my concerns with "Scoped" components in Dagger 2. The PerActivity, PerFragment or other annotations are leading you to think that Dagger will magically manage the scope of those components for you, but it doesn't.
So correct me if I'm wrong, bu unless you destroy your component in Activity.onDestroy() (which might not get called anyway http://developer.android.com/reference/android/app/Activity.html#onDestroy()), the component will not be garbage collected, and you will leak everything that's inside of it (probably your Activity).
And then, how does this even work if your Activity or Fragment is started twice? They will share the same component (the first one that was created). Which means that if you are using that component to provide an Activity instance to your fragments, this might return another Activity than the one your fragment is attached to.
That is very scary to me and I wouldn't use custom scopes for that reason unless I knew exactly what I was doing...

@nbarraille onDestroy is not guaranteed to be called only in the case the host process is being killed outright. Therefore, you won't leak anything - the hosting process dies along with all its ClassLoaders/statics, and there's nothing to leak.
If the Activity is started twice in the same process, onDestroy will be called.

@cmc5788 :+1:

If the Activity is started twice in the same process, onDestroy will be called.
Wait, what? No, this is not true, in general you can start one Activity as many times you want.


add pip requirements

add a file to specify which pip packages are required
also specifies that the pyyaml package is also a dependency

Thanks for this!


ORC-743: Convert SearchArguments to Filter to take advantage of LazyIO

What changes were proposed in this pull request?
Added conversion of SArg into filters to take advantage of the LazyIO introduced by ORC-742
* Created Vector filters for leaf, And, Or, Batch
* Code generation for data type and operator filters
* Test code generation for data type and operator filters
* Benchmark tests for the filters in the bench module
Why are the changes needed?
With ORC-742, FOLLOW (non-filter) columns are evaluated lazily. Spark and Hive are already passing down SearchArguments to ORC. This change allows the conversion of the SearchArguments to a filter to gain the improvements of ORC-742.
How was this patch tested?

Unit tests were added
Performance tests were added to the Bench module

Could you resolve the conflicts by rebasing to the master branch?

Could you resolve the conflicts by rebasing to the master branch?

Could you resolve the conflicts by rebasing to the master branch?

done

Could you resolve the conflicts by rebasing to the master branch?

done

In general, this patch looks too risky due to the massive size, +9,192 −669.

I agree that this is a large patch, to give a little more details, this is what the distribution of changes looks like:

Percentage
Directory

16.3%
java/bench/core/src/java/org/apache/orc/bench/core/filter/

6.2%
java/bench/core/src/test/org/apache/orc/bench/core/filter/

4.8%
java/bench/

12.9%
java/core/src/gen/filters/

6.7%
java/core/src/java/org/apache/orc/filter/impl/

3.8%
java/core/src/java/org/apache/orc/filter/

6.2%
java/core/src/java/org/apache/orc/util/

16.1%
java/core/src/test/org/apache/orc/filter/impl/

8.0%
java/core/src/test/org/apache/orc/

7.9%
java/gen/src/main/java/org/apache/orc/gen/

4.5%
java/mapreduce/src/test/org/apache/orc/mapreduce/

6.1%
java/

27.3% of the lines changes are in the bench module
28.6% of the remaining changes are in tests, primarily from addition of new tests for evaluating the SArg conversions

I am open to suggestions on better to submit this change.

In general, this patch looks too risky due to the massive size, +9,192 −669.

I agree that this is a large patch, to give a little more details, this is what the distribution of changes looks like:

Percentage
Directory

16.3%
java/bench/core/src/java/org/apache/orc/bench/core/filter/

6.2%
java/bench/core/src/test/org/apache/orc/bench/core/filter/

4.8%
java/bench/

12.9%
java/core/src/gen/filters/

6.7%
java/core/src/java/org/apache/orc/filter/impl/

3.8%
java/core/src/java/org/apache/orc/filter/

6.2%
java/core/src/java/org/apache/orc/util/

16.1%
java/core/src/test/org/apache/orc/filter/impl/

8.0%
java/core/src/test/org/apache/orc/

7.9%
java/gen/src/main/java/org/apache/orc/gen/

4.5%
java/mapreduce/src/test/org/apache/orc/mapreduce/

6.1%
java/

27.3% of the lines changes are in the bench module
28.6% of the remaining changes are in tests, primarily from addition of new tests for evaluating the SArg conversions

I am open to suggestions on better to submit this change.

Yes, let's spin off benchmark part. We can proceed that in a separate ORC JIRA later.

Yes, let's spin off benchmark part. We can proceed that in a separate ORC JIRA later.

Closing this request and opening a new one with the latest changes.


serverless/console content

Content of https://github.com/serverless/console (as a first step of merging two repositories)

LGTM. I confirmed that full history appears to be there, and my latest commits are there also. No concerns merging this from my end.


dateFormat string

Provide the ability to display "Today", "Tomorrow", "Yesterday" as appropriate in the input.
E.g. if dateFormat="MMMM do yyyy" then it displays the date as normal except for if the date is today in which case it states "Today".

Closed. Solution via the "value" prop.


analyze and propose solution on how to implement and enforce each policy in terms of repositories and their requiredness

Fill in the design gap left open after the high level design of Policy Service. Specifically, design a way through which individual policy's business logic can be encoded and executed.
Ideally the solution would allow for a new policy to be added via means of data augmentation or configuration rather than coding new implementation.

I believe this has been satisfied by the concrete design and DSL plan https://docs.google.com/document/d/1cPNN9TFUCLX-4yVoRuhmM0Vcrh3WYWNs-rwAszuJWXk/edit


odeint documentation refers to t0 instead of t

The ode integrator scipy.odeint should solve the equation
dy/dt = f(y, t)
according to the tutorial. However, the documentation indicates that it is solving
dy/dt = f(y, t0).
the scipy.ode function documentation correctly states that it is solving the first equation.
Scipy/Numpy/Python version information:
0.19.1 1.11.3 sys.version_info(major=3, minor=6, micro=0, releaselevel='final', serial=0)

Hi,
i can take care of this one if you want.
Function has def odeint(func, y0, t, ...) so it migh be good to make documentation like dy/dt = func(y0, t, ...), right?


build: Update to header 1.2.189

Update known-good
Generate source (no change)

CI Vulkan-Tools build queued with queue ID 21517.

CI Vulkan-Tools build # 504 running.

CI Vulkan-Tools build # 504 passed.

It seems to be failing CI

Looks like it was github issue. I re-ran the jobs and they are passing now.


Export profile confirmation dialog should be an info dialog

Version: 1.75.0-insider
Commit: 0a6c277e4faa44a6b6eb82ddca8bfeccf7fecef6
Date: 2023-01-24T05:22:50.699Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.15.0-56-generic
Sandboxed: Yes

Export a profile to a file
Confirmation dialog shows a question mark, but there's no question here

It's better on Windows:

We can change all dialogs from IDialogService.show to use info instead of question type. This only seems to have an impact on Linux and changes the icon to an info icon.


Fix bash syntax in auto completion script

This broke in https://github.com/fastlane/fastlane/pull/4152 with a syntax error

👍 🚢  it


Remove usage of deprecated ::set-output

Closes #11

Hey @luispabon , any news on this one? Thanks

Apologies @Djiit , I didn't get around testing it and slipped. I'll do this today.

Works for me. Thanks for your contribution 👍


Return Nil rather than '' from .get at EOF

I noticed when using an IO::Blob object with Text::CSV.getline that it
wasn't ending (returning an empty list,) when it reached EOF.
It appears that Text::CSV is testing for the definedness of the return
of .get, which is consistent with the documented behaviour of the core
IO::Handle.get.
So this adjusts .get to return Nil at EOF rather than the empty string.

I appreciate your contribution. Looks good to me, I've just merged this.


Iteration5

Create pub/sub and Notification system.
PR Type

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Others. (Please describe)

PR Info.
Changes

Return Error when there's duplicate reminder time.
Create Pub/Sub system.
Create notification system, to remind user through Line application.

Fixes

BUG: Assignment due date cannot be None.
BUG: Cannot send notification if tag's subscriber is None.

Codecov Report

Merging #50 (7b652c7) into master (0086a4a) will decrease coverage by 3.43%.
The diff coverage is 60.58%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   85.70%   82.27%   -3.44%
==========================================
  Files          59       64       +5
  Lines        1042     1207     +165
  Branches       53       79      +26
==========================================
+ Hits          893      993     +100
- Misses        134      196      +62
- Partials       15       18       +3

Impacted Files
Coverage Δ

config/settings.py
100.00% <ø> (ø)

garnbarn_api/models.py
95.34% <ø> (-0.71%)
:arrow_down:

garnbarn_api/tests/test_view.py
100.00% <ø> (ø)

garnbarn_api/services/line_message_generator.py
30.95% <30.95%> (ø)

...es/notification/platforms/notification_platform.py
37.93% <37.93%> (ø)

garnbarn_api/authentication.py
40.74% <50.00%> (ø)

garnbarn_api/serializer.py
68.96% <60.00%> (-3.26%)
:arrow_down:

garnbarn_api/services/line.py
44.23% <60.00%> (+9.85%)
:arrow_up:

...rnbarn_api/services/notification/platforms/line.py
66.66% <66.66%> (ø)

...arn_api/services/notification/send_notification.py
70.00% <70.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0086a4a...7b652c7. Read the comment docs.


Implement metadata for aio unary call

Implement metadata for  Aio  UnaryUnary Call .
Fix https://github.com/grpc/grpc/issues/20144

Thanks for the work done!
Take a look at the YAPF and the Linter checks both are failing.

Thanks for the work done!
Take a look at the YAPF and the Linter checks both are failing.

The pylint says there are too many arguments, could we ignore it?

@ZHmao  do not know why but seems that someone has removed the calling to the metadata observer [1], so once you merge the changes in master to your branch the metadata receiver might not work so maybe you would need to recover the piece of code where the metadata observer is called with the operation result /cc @lidizheng
[1] https://github.com/grpc/grpc/blob/master/src/python/grpcio/grpc/_cython/_cygrpc/aio/call.pyx.pxi#L143

@pfreixes Can you also take a loop at the conflicts for this PR?

@ZHmao if you don't mind I would take care of this PR for resolving the conflicts!


Add feature flag for slow tests

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.30%. Comparing base (c5a0fdc) to head (b85e657).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #797   +/-   ##
=======================================
  Coverage   92.30%   92.30%
=======================================
  Files          91       91
  Lines       12417    12417
  Branches    12417    12417
=======================================
  Hits        11462    11462
  Misses        849      849
  Partials      106      106

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error building example clientset: No Auth Provider found for name "gcp"

I run
$ ./example -kubeconfig ~/.kube/config

and I get
F0510 12:14:20.618026   25427 main.go:30] Error building example clientset: No Auth Provider found for name "gcp"
goroutine 1 [running]:
github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog.stacks(0xc4203d4e00, 0xc420218000, 0x72, 0xc7)
	/Users/acabrera/go/src/github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog/glog.go:769 +0xcf
github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog.(*loggingT).output(0x21da2c0, 0xc400000003, 0xc4200ee630, 0x216c8b4, 0x7, 0x1e, 0x0)
	/Users/acabrera/go/src/github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog/glog.go:720 +0x32d
github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog.(*loggingT).printf(0x21da2c0, 0x3, 0x1aff178, 0x24, 0xc420487cd8, 0x1, 0x1)
	/Users/acabrera/go/src/github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog/glog.go:655 +0x14b
github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog.Fatalf(0x1aff178, 0x24, 0xc420487cd8, 0x1, 0x1)
	/Users/acabrera/go/src/github.com/openshift-evangelists/crd-code-generation/vendor/github.com/golang/glog/glog.go:1148 +0x67
main.main()
	/Users/acabrera/go/src/github.com/openshift-evangelists/crd-code-generation/cmd/example/main.go:30 +0x166

For GKE clusters you need this import: https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go#L32

Thanks!


Update Issue Templates to use GitHub Issue Forms

As aforementioned, this Pull Request resolves #1 by using GitHub Issue Forms to update the Issue Templates of this repository. Please let me know if there are any changes due.
I am not able to open an Issue on my fork, regardless the templates look good.
Will be in anticipation of your response!

Reopening the PR following the updates on #1.


use semver as annotation version

fix #468

@horis233
Could you update the annotation.version for the CRs of cert-manager as well? Thank you!
https://github.com/IBM/ibm-common-service-operator/blob/master/controllers/certmanager/cert_cr.go#L25
https://github.com/IBM/ibm-common-service-operator/blob/master/controllers/certmanager/cert_cr.go#L43
https://github.com/IBM/ibm-common-service-operator/blob/8a3fcadce0019cec80da238091687b9256e42ac5/controllers/certmanager/cert_cr.go#L60


Fix vertical alignment on mobile / tablet screens

Often times current media queries are made for arbitrary resolutions, which is not ideal, considering many known display resolutions can be tested easily with DevTools. DOM elements must align perfectly on all resolutions.

[ ] Fix carousel modal overflowing when height < 800px long.

[typeahead-container][id^="ngb-typeahead"][id$="-"]:not([id*="-"]) {
    height: 500px !important;
  }

doesn't work. Try using styling on an elementRef instead.


KDE Invent support

KDE Invent is the gitlab based git forge used by KDE, the group responsible for developing the Plasma Desktop Environment for Linux as well as numerous applications for it.
Unfortunately, it offers no way for users to register their own OAuth apps, so it would be great if git-credential-oauth talked to them and registered an instance wide OAuth application.

Is there a mailing list or contact information for the admins of https://invent.kde.org/ ?

https://discuss.kde.org/ should do I think

Does this work?
git config --global credential.https://invent.kde.org.oauthclientid 36ee2eeb4f179b38db8f066fd4ca9751f4b003653a205fc1422f110ca60181f6

No, git credential-oauth does not even appear to try and generate a URL:
[bernardo@computer project] GIT_TRACE=1 git push origin test-branch
13:08:55.909354 git.c:463               trace: built-in: git push origin test-branch
13:08:55.912276 run-command.c:657       trace: run_command: GIT_DIR=.git git remote-https origin https://invent.kde.org/bernardogn/project
13:08:55.913935 git.c:749               trace: exec: git-remote-https origin https://invent.kde.org/bernardogn/project
13:08:55.913971 run-command.c:657       trace: run_command: git-remote-https origin https://invent.kde.org/bernardogn/project
13:08:56.901160 run-command.c:657       trace: run_command: 'git credential-cache --timeout 7200 get'
13:08:56.904713 git.c:463               trace: built-in: git credential-cache --timeout 7200 get
13:08:56.905047 run-command.c:657       trace: run_command: 'git credential-oauth get'
13:08:56.908155 git.c:749               trace: exec: git-credential-oauth get
13:08:56.908193 run-command.c:657       trace: run_command: git-credential-oauth get
13:08:56.928326 run-command.c:657       trace: run_command: /usr/bin/ksshaskpass 'Username for '\''https://invent.kde.org'\'': '
[bernardo@computer project] printf 'protocol=https\nhost=invent.kde.org\nwwwauth=Bearer realm=Gitlab\n' | git credential-oauth get
# No output
[bernardo@computer project] git config credential.helper
oauth

How about this?
git config --global credential.https://invent.kde.org.oauthclientid 36ee2eeb4f179b38db8f066fd4ca9751f4b003653a205fc1422f110ca60181f6
git config --global credential.https://invent.kde.org.oauthAuthURL https://invent.kde.org/oauth/authorize
git config --global credential.https://invent.kde.org.oauthTokenURL https://invent.kde.org/oauth/token
git config --global credential.https://invent.kde.org.oauthScopes "read_repository write_repository"

That works fine! Thank you very much

Fixed in v0.11.1 https://github.com/hickford/git-credential-oauth/releases/tag/v0.11.1


[UI ISSUE]on iOS 18 devices, there is an UI issue when long-pressing the send button.

On iOS 18 devices, there is an issue with the animation when long-pressing the send button. Previously, the button would gradually expand into a circle with 0.9 scale, but this effect is now missing.

IOS 18.1(Beta6)

This issue already solved in ios prod version 2.2.11(4).
Tested on ios version 18.1.1
https://github.com/user-attachments/assets/56ad207d-f7f6-471b-8e3d-6fc1bf1d7a1b


npm request deprecated

request has been deprecated, see https://github.com/request/request/issues/3142
Please update dependencies.
Thanks.

Hi
thank you for letting us know. We will see to do that in near future.
Igor

Hi,
if no fancy stuff is needed, maybe google's teeny-request is enough?https://github.com/googleapis/teeny-request (apache-2 license)
retries can be added using https://github.com/stephenplusplus/retry-request (MIT license)
@google-cloud/common depends on both, so I don't think those are going anywhere soon.
The only real downside is that the lib does not support promises, so it's all callback hell.

https://github.com/wildbit/postmark.js/pull/60 Thank you.

You are welcome, we have released the update