Added ContentDisposition only if it is not already specified

Is related about the issue #3

Ignore it, I've overwritten the ContentDisposition directly on the HttpResponseMessage

This is a reasonable request and I'd rather make this easy on people, so I'm going to reopen it. Thanks for bringing it to my attention!


Replace stub with hints and code solution

[ x] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x ] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x ] My changes do not use shortened URLs or affiliate links.

See my suggested change.

Thanks, I've committed. I'll do that in the future. Cheers

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉
IMPORTANT INFORMATION!!!
@ailyntang Until further notice, we are not going to be accepting/merging any new PRs for changes to the Guide articles in the certifications folder. There will be an announcement at a later date on the forum about how to update the curriculum related articles, but for now, just hold on to your solutions. We will work on approving the ones you have already created though.
Thank you.


Enable GitHub code scanning with CodeQL (to replace the soon-to-be-deprecated LGTM.com)

Hi team!
You might have seen that LGTM.com will go off-line later this month. The team that built LGTM (including me!) joined GitHub a couple of years ago, and we've natively integrated the CodeQL engine that powers LGTM into GitHub.
This PR enables the CodeQL analysis for DSpace. Just like with LGTM, alerts will show up in pull requests (but better). In addition, all alerts can be browsed on the "Security" tab of the repository.
I tried to configure GitHub code scanning as similarly/closely as possible to the original LGTM configuration — do feel free to tweak and adjust as you see fit. If you have any questions, check out the FAQ below, and I'm of course happy to help as well.
FAQ

Click here to expand the FAQ section
How often will the code scanning analysis run?
By default, code scanning will trigger a scan with the CodeQL engine on the following events:
On every pull request — to flag up potential security problems for you to investigate before merging a PR.
On every push to your default branch and other protected branches — this keeps the analysis results on your repository’s Security tab up to date.
Once a week at a fixed time — to make sure you benefit from the latest updated security analysis even when no code was committed or PRs were opened.
What will this cost?
Nothing! The CodeQL engine will run inside GitHub Actions, making use of your unlimited free compute minutes for public repositories.
What types of problems does CodeQL find?
The CodeQL engine that powers GitHub code scanning is the exact same engine that powers LGTM.com. The exact set of rules has been tweaked slightly, but you should see almost exactly the same types of alerts as you were used to on LGTM.com: we’ve enabled the security-and-quality query suite for you.
How do I upgrade my CodeQL engine?
No need! New versions of the CodeQL analysis are constantly deployed on GitHub.com; your repository will automatically benefit from the most recently released version.
The analysis doesn’t seem to be working
If you get an error in GitHub Actions that indicates that CodeQL wasn’t able to analyze your code, please follow the instructions here to debug the analysis.
How do I disable LGTM.com?
If you have LGTM’s automatic pull request analysis enabled, then you can follow these steps to disable the LGTM pull request analysis. You don’t actually need to remove your repository from LGTM.com; it will automatically be removed in the next few months as part of the deprecation of LGTM.com (more info here).
Which source code hosting platforms does code scanning support?
GitHub code scanning is deeply integrated within GitHub itself. If you’d like to scan source code that is hosted elsewhere, we suggest that you create a mirror of that code on GitHub.
How do I know this PR is legitimate?
This PR is filed by the official LGTM.com GitHub App, in line with the deprecation timeline that was announced on the official GitHub Blog. The proposed GitHub Action workflow uses the official open source GitHub CodeQL Action. If you have any other questions or concerns, please join the discussion here in the official GitHub community!
I have another question / how do I get in touch?
Please join the discussion here to ask further questions and send us suggestions!

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR modifies the REST API, I've opened a separate REST Contract PR related to this change.

(I don't think any of the above applies)

@sj : Thanks for the reminder on this.  Just as an FYI, we're already working on it!  We have an early PR at #8548 which I'm hoping to finalize next week sometime, so that we are fully migrated prior the the retirement of LGTM.
I will see if there's ay changes/suggestions here that can be pulled over into the active PR.
Thanks!

We have an early PR at https://github.com/DSpace/DSpace/pull/8548 which I'm hoping to finalize next week sometime, so that we are fully migrated prior the the retirement of LGTM.

Sorry to have missed that, @tdonohue! Yes, I'll of course leave it up to you to cherry-pick bits from both PRs, and then close the one that you don't need.
Having taken a quick look, I noticed two differences between the two PRs:

My PR specifically installs Java 11 (because that was specified in your lgtm.yml file). Clearly that might not be needed!
My PR runs the Java and JavaScript analysis in parallel (using a matrix configuration), rather than one after the other.


Functions.Azure

Build Functions.Azure project that works in linux and windows

Refactor the Functions.Azure project to work with linux and windows.


Wsavran GitHub actions

Codecov Report

Merging #32 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #32   +/-   ##
=======================================
  Coverage   39.54%   39.54%
=======================================
  Files          25       25
  Lines        3566     3566
  Branches      490      490
=======================================
  Hits         1410     1410
  Misses       2097     2097
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebd82b...496ad58. Read the comment docs.


LAB 5 - Deploy the fine-tuned model

Module: 5
Task: Deploy the fine-tuned model
Step: 02
Description of issue:
Deployment of Finetune model fails every time it is being deployed.
FYI, I have used the suggested location for gpt-35-turbo but still same results.
The error says:
Validation error: The workspace MSI does not have deployment/write permissions to the underlying resource.

This can be related to security policies in your subscription. Try out the troubleshoot tips mentioned in the instructions:

In the Azure portal, select the AI Services resource.
On the IAM page, in the Identity tab, confirm that it is system assigned managed identity.
Navigate to the associated Storage Account. On the IAM page, add role assignment Storage blob data reader.
Under Assign access to, choose Managed Identity, + Select members, and select the All system-assigned managed identities.
Review and assign to save the new settings and retry the previous step.


HTTPProxy cannot be aware of timeout of waiting response

In case using httputil.ReverseProxy, the error returned by RoundTrip(), is only recorded by Logger. https://github.com/golang/go/blob/master/src/net/http/httputil/reverseproxy.go#L203 .
Therefore, it seems the HTTPProxy cannot distinguish whether it is a timeout or a normal response, when it tries to gather the metrics. https://github.com/fabiolb/fabio/blob/master/proxy/http_proxy.go#L134
Also, the backend service timeout causes the response have 502 code and without body. And the body cannot be customized right now. The worst is timeout error is not logged with enough context information, for example, which service or which URI gets timeout.

I can always fork httputil.ReverseProxy and hack this in. Then file an issue with the Go team and hope for a future fix.

What is the behavior you would like to see?

Also, I'm already injecting a single-use round tripper which captures the *http.Response so that I can use it for access logging. I can capture the error there as well and handle it.
https://github.com/fabiolb/fabio/blob/master/proxy/http_handler.go#L52-L64

Thanks. Another problem is ReverseProxy returns 502 without body to the client. I am hoping to customize the body according to each err type. It seems I have to copy ReverseProxy and make my own version. I wonder if there is a simpler way to achieve that.

I guess I found a work-around. Replace the out writer of ErrorLog in ReverseProxy with a custom one, which writes a JSON format body to the client. I am working on it.

I guess I found a work-around. Replace the out writer of ErrorLog in ReverseProxy with a custom one, which writes a JSON format body to the client. I am working on it.


improve: more smart selection of string decoding functions

This is a kind of tragedy that TextDecoder is not always the best way. I wish someday when these complex conditions are completely obsolete, but for now, this is the best.
benchmark results:
$ npx ts-node benchmark/decode-string.ts

## string "A" x 10 (byteLength=10)

utf8DecodeJs x 6,820,213 ops/sec ±5.21% (82 runs sampled)
utf8DecodeWasm x 1,030,221 ops/sec ±3.86% (81 runs sampled)
TextDecoder x 788,986 ops/sec ±2.04% (79 runs sampled)

## string "A" x 100 (byteLength=100)

utf8DecodeJs x 825,191 ops/sec ±1.89% (86 runs sampled)
utf8DecodeWasm x 507,129 ops/sec ±2.98% (81 runs sampled)
TextDecoder x 495,937 ops/sec ±10.66% (66 runs sampled)

## string "A" x 200 (byteLength=200)

utf8DecodeJs x 406,791 ops/sec ±3.24% (80 runs sampled)
utf8DecodeWasm x 339,505 ops/sec ±3.38% (83 runs sampled)
TextDecoder x 485,291 ops/sec ±2.81% (76 runs sampled)

## string "A" x 1000 (byteLength=1000)

utf8DecodeJs x 65,969 ops/sec ±4.95% (69 runs sampled)
utf8DecodeWasm x 83,295 ops/sec ±3.22% (76 runs sampled)
TextDecoder x 260,622 ops/sec ±4.55% (83 runs sampled)

## string "A" x 10000 (byteLength=10000)

utf8DecodeJs x 8,696 ops/sec ±2.89% (81 runs sampled)
utf8DecodeWasm x 9,953 ops/sec ±3.42% (82 runs sampled)
TextDecoder x 45,540 ops/sec ±4.64% (82 runs sampled)

## string "A" x 100000 (byteLength=100000)

utf8DecodeJs x 408 ops/sec ±4.20% (83 runs sampled)
utf8DecodeWasm x 84.42 ops/sec ±3.50% (72 runs sampled)
TextDecoder x 3,443 ops/sec ±4.34% (80 runs sampled)

## string "あ" x 10 (byteLength=30)

utf8DecodeJs x 4,456,073 ops/sec ±4.75% (75 runs sampled)
utf8DecodeWasm x 1,030,237 ops/sec ±3.24% (86 runs sampled)
TextDecoder x 626,129 ops/sec ±5.00% (70 runs sampled)

## string "あ" x 100 (byteLength=300)

utf8DecodeJs x 512,368 ops/sec ±9.75% (75 runs sampled)
utf8DecodeWasm x 423,180 ops/sec ±5.45% (80 runs sampled)
TextDecoder x 390,576 ops/sec ±2.21% (81 runs sampled)

## string "あ" x 200 (byteLength=600)

utf8DecodeJs x 339,130 ops/sec ±0.90% (93 runs sampled)
utf8DecodeWasm x 347,386 ops/sec ±2.08% (90 runs sampled)
TextDecoder x 250,218 ops/sec ±4.65% (77 runs sampled)

## string "あ" x 1000 (byteLength=3000)

utf8DecodeJs x 54,151 ops/sec ±7.31% (75 runs sampled)
utf8DecodeWasm x 71,328 ops/sec ±9.33% (75 runs sampled)
TextDecoder x 62,094 ops/sec ±7.82% (68 runs sampled)

## string "あ" x 10000 (byteLength=30000)

utf8DecodeJs x 6,474 ops/sec ±2.55% (87 runs sampled)
utf8DecodeWasm x 9,338 ops/sec ±1.50% (90 runs sampled)
TextDecoder x 8,195 ops/sec ±2.76% (89 runs sampled)

## string "あ" x 100000 (byteLength=300000)

utf8DecodeJs x 372 ops/sec ±3.82% (80 runs sampled)
utf8DecodeWasm x 85.82 ops/sec ±2.21% (73 runs sampled)
TextDecoder x 895 ops/sec ±1.22% (89 runs sampled)

## string "🌏" x 20 (byteLength=40)

utf8DecodeJs x 2,951,171 ops/sec ±1.22% (91 runs sampled)
utf8DecodeWasm x 732,553 ops/sec ±7.60% (72 runs sampled)
TextDecoder x 511,127 ops/sec ±9.85% (59 runs sampled)

## string "🌏" x 200 (byteLength=400)

utf8DecodeJs x 140,319 ops/sec ±16.40% (39 runs sampled)
utf8DecodeWasm x 255,222 ops/sec ±9.40% (74 runs sampled)
TextDecoder x 320,214 ops/sec ±4.21% (77 runs sampled)

## string "🌏" x 400 (byteLength=800)

utf8DecodeJs x 169,404 ops/sec ±6.21% (83 runs sampled)
utf8DecodeWasm x 176,243 ops/sec ±5.15% (79 runs sampled)
TextDecoder x 177,882 ops/sec ±10.15% (67 runs sampled)

## string "🌏" x 2000 (byteLength=4000)

utf8DecodeJs x 26,572 ops/sec ±6.99% (71 runs sampled)
utf8DecodeWasm x 43,111 ops/sec ±3.76% (80 runs sampled)
TextDecoder x 52,740 ops/sec ±5.80% (75 runs sampled)

## string "🌏" x 20000 (byteLength=40000)

utf8DecodeJs x 3,234 ops/sec ±4.96% (75 runs sampled)
utf8DecodeWasm x 4,254 ops/sec ±4.55% (80 runs sampled)
TextDecoder x 5,502 ops/sec ±3.99% (78 runs sampled)

## string "🌏" x 200000 (byteLength=400000)

utf8DecodeJs x 176 ops/sec ±6.27% (68 runs sampled)
utf8DecodeWasm x 33.61 ops/sec ±6.59% (44 runs sampled)
TextDecoder x 546 ops/sec ±4.38% (79 runs sampled)

cc: @sergeyzenchenko

Codecov Report

Merging #39 into master will decrease coverage by 0.08%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   95.65%   95.56%   -0.09%
==========================================
  Files          14       14
  Lines         759      767       +8
  Branches      160      162       +2
==========================================
+ Hits          726      733       +7
- Misses         14       15       +1
  Partials       19       19

Impacted Files
Coverage Δ

src/wasmFunctions.ts
91.83% <100%> (+1.36%)
:arrow_up:

src/Decoder.ts
98.55% <66.66%> (-0.72%)
:arrow_down:

src/utils/utf8.ts
90.58% <80.95%> (+0.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f338b2...5d85f73. Read the comment docs.

Codecov Report

Merging #39 into master will decrease coverage by 0.21%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   95.65%   95.43%   -0.22%
==========================================
  Files          14       14
  Lines         759      767       +8
  Branches      160      163       +3
==========================================
+ Hits          726      732       +6
- Misses         14       15       +1
- Partials       19       20       +1

Impacted Files
Coverage Δ

src/wasmFunctions.ts
93.87% <100%> (+3.4%)
:arrow_up:

src/Decoder.ts
98.55% <66.66%> (-0.72%)
:arrow_down:

src/utils/utf8.ts
88.23% <80.95%> (-1.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f338b2...46f1ec9. Read the comment docs.


render-site file not found

Sorry if this is jumping the gun while you're in progress: getting error not finding ./render-site when doing a Preview:
[clojure-agent-send-off-pool-4] INFO com.platypub - Generating CSS...
[clojure-agent-send-off-pool-4] INFO com.platypub - CSS done
[qtp169775100-19] ERROR com.biffweb.impl.middleware - Exception while handling request
clojure.lang.ExceptionInfo: chmod: cannot access './render-site': No such file or directory
 {:exit 1, :out "", :err "chmod: cannot access './render-site': No such file or directory\n"}
        at com.biffweb.impl.util$sh.invokeStatic(util.clj:66)
        at com.biffweb.impl.util$sh.doInvoke(util.clj:62)
        at clojure.lang.RestFn.applyTo(RestFn.java:137)
        at clojure.core$apply.invokeStatic(core.clj:667)
        at clojure.core$apply.invoke(core.clj:662)
        at com.biffweb$sh.invokeStatic(biffweb.clj:61)
        at com.biffweb$sh.doInvoke(biffweb.clj:56)
        at clojure.lang.RestFn.invoke(RestFn.java:436)
        at com.platypub.feat.sites$generate_BANG_.invokeStatic(sites.clj:121)
        at com.platypub.feat.sites$generate_BANG_.invoke(sites.clj:107)
        at com.platypub.feat.sites$preview.invokeStatic(sites.clj:128)
        at com.platypub.feat.sites$preview.invoke(sites.clj:125)

https://github.com/jacobobryant/platypub/blob/fda203e6351e6523148fb070913ce871bf050453/src/com/platypub/feat/sites.clj#L121

yeah, things are a bit of a mess right now... however I went ahead and cleaned some stuff up, including updating all the default theme code (which I just finished writing for https://blog.thesample.ai anyway), so things should work now. after pulling the new code, you'll need to re-copy themes.TEMPLATE/default to themes/default, and I've also included some more details in README.md and themes/default/README.md. Also see config.edn.TEMPLATE for a comment about setting some recaptcha config which is new.
I just did a test speedrun with a fresh clone and everything seems to be working. The site's deployed at https://sparkling-sprinkles-125cac.netlify.app/ in fact. Let me know if you run into any pitfalls. The user experience could definitely use more work.


[putItem] unexpected error: TypeError: Cannot read properties of undefined (reading 'S')

upgraded from version 6.2.2 to recent one 6.2.3
I see below error in the hub report lambda function while inserting usage data into Hub dynamoDB table. This is happening only for source coming from Trust Advisor. It is able to insert values coming from source service quotas.
Error:
[WARN] [putItem] unexpected error: TypeError: Cannot read properties of undefined (reading 'S')
Please verify at the earliest. Thanks

Thanks for reporting, looking into it.

We will include the fix in the next release.

@abe-aws  - I had to upgrade from version 6.2.2 to the recent one 6.2.3 because there was a vulnerability issue in 6.2.2 as mentioned in the change logs in this repo.
Is there a work around in the CloudFormation templates which I can change as a work around to fix this problem?  Need this ASAP. Thanks

@abe-aws  - I had to upgrade from version 6.2.2 to the recent one 6.2.3 because there was a vulnerability issue in 6.2.2 as mentioned in the change logs in this repo.
Is there a work around in the CloudFormation templates which I can change as a around until this fix comes in next release? Need this ASAP. Thanks

6.2.3 is to address this. That is a dev dependency used only when you run tests (npm test). So you can deploy / continue using 6.2.2 without any impact.

Fixed in release v6.2.4


Improve command line argument parsing

-detect duplicated options -d/--dest
-clean up unused import in helper.py
-update CHANGELOG.md

Hi, @sonia9703! Thanks for opening this PR!

In the file connector-packager/connector_packager/package.py:

Line 30:100: E231 missing whitespace after ','

In the file tdvt/tdvt/config_gen/test_config.py:

Line 141:9: F405 'logging' may be undefined, or defined from star imports: ..resources
Line 138:21: F405 'logging' may be undefined, or defined from star imports: ..resources

In the file tdvt/tdvt/tdvt.py:

Line 707:5: F405 'logging' may be undefined, or defined from star imports: .tabquery
Line 691:26: F405 'os' may be undefined, or defined from star imports: .tabquery
Line 664:1: E302 expected 2 blank lines, found 1
Line 443:121: E501 line too long (147 > 120 characters)
Line 426:121: E501 line too long (150 > 120 characters)
Line 408:121: E501 line too long (125 > 120 characters)
Line 101:40: F405 'os' may be undefined, or defined from star imports: .tabquery
Line 100:35: F405 'os' may be undefined, or defined from star imports: .tabquery
Line 19:1: E402 module level import not at top of file

In the file tdvt/test/tdvt_test.py:

Line 197:121: E501 line too long (152 > 120 characters)
Line 197:38: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 97:24: F405 'os' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results

For reference: Error Code Reference, PEP8, Python code style

LGTM but I don't see the changes to the changelog yet.


Add support for canonical event field names for data-points/tags

This allows specifying document fields to be use for data-points/tag set.

Hi!
Any chance to merge this PR?
Thanks,
Regards!


Add a bus_renamed AudioServer signal

Adds a new signal and uses it to avoid unnecessary rebuilds of the audio bus editor, softening some lag spikes.
A slightly compat-breaking alternative to #81611 that also adds a new feature. The compat-breaking could be called a bugfix, depending on how you want to look at it. See the first few comments of the linked PR.

Funnily, the old docs description is even more overbearing, it suggests any change in the AudioBusLayout is supposed to signal. Including... things like muting, bypassing, solo, volume changes, maybe even effects! I don't know what the signal is truly intended for at this point, so might as well invent a proper meaning now?

Yup I saw in the blame. Since the signal never did what the documentation describes anyway, I think we can break compatibility here.
Unfortunately, I think that the initial idea was that the "bus layout changed" signal was meant to be for when the active AudioBusLayout changed - but the idea was forgotten over the eons as people interpreted "layout" as its standard meaning - the positioning of things.
I thought the intention of the signal was to alert things that the user-facing part of AudioBusLayout has changed, which does include renaming since buses can be accessed via their names.
So, idk what to do with this, man. I hope I provided the facts and the different possible perspectives here.

Note on merging: This is one of two alternatives to address the problem, https://github.com/godotengine/godot/pull/81611 is the other one. We likely need to pick just one, because they don't really make sense together.

This one could be merged into master for 4.2 and the other one into 4.0 and 4.1, no?

@MJacred This is not how we maintain Godot's codebase. Discrepancies like that makes it harder to support several branches at the same time, so the solution must come through all branches, or not come through at all. Unless it's something really really critical, but in this case it's just some lag.
If we want to preserve the compatibility and cherry-pick this fix, there are other options, as I've mentioned.


--exclude-pattern only works when the files to run are directories

Subject of the issue
Say we have a test file: spec/examples/example_spec.rb. The expectation is that if I set it in --exclude-pattern, it should not run. It turned out that the --exclude-pattern only works when the files to run are directories. It does not work when the files to run are files.
Files to run are directories
This exclusion will work and spec/examples/example_spec.rb will not run:
rspec spec/examples --exclude-pattern "spec/examples/example_spec.rb"
Files to run are files
This will not work, and spec/examples/example_spec.rb will still run:
rspec spec/examples/example_spec.rb --exclude-pattern "spec/examples/example_spec.rb"
I think this is due to this:
https://github.com/rspec/rspec-core/blob/v3.7.1/lib/rspec/core/configuration.rb#L1997
Where the exclude-pattern is only applied here when the file to run is a directory:
https://github.com/rspec/rspec-core/blob/v3.7.1/lib/rspec/core/configuration.rb#L2015
The exclude-pattern is not applied when the file to run is not a directory:
https://github.com/rspec/rspec-core/blob/v3.7.1/lib/rspec/core/configuration.rb#L2049
Why would someone put a file in the pattern to run and then place it in the --exclude-pattern to make it not to run? One use case is the parallel_tests gem https://github.com/grosser/parallel_tests where directories of files are expanded and invoked as files on parallel rspec commands. In this case if rspec is invoked by files, it would not honor the --exclude-pattern option that we specify on parallel_rspec.
Your environment

Ruby version: 2.5.1
rspec-core version: 3.7.1

I'm afraid this is by design, when you mention a file specifically you are essentially creating an inclusion filter, which take priority over exclusion filters.
Why? Your example creates a good use case here:
rspec spec/examples/example_spec.rb --exclude-pattern "spec/examples/example_spec.rb"
While this is pretty non-sensical on its own, (why would you exclude the file you've specified to run?) we should consider that you could have run rspec spec/examples/example_spec.rb but have --exclude-pattern "spec/examples/example_spec.rb" in a .rspec or other external configuration and not know it.
If we were to use the exclusion pattern you would see 0 examples, 0 failures etc which would be pretty confusing, so instead we will always run files directly mentioned. (See also if you mention an example by id or line number that is always run too).
I suggest that parallel_rspec should either not execute specs by file by shelling to us, (you could execute RSpec programmatically which would allow you to specific the specs to run yourself, you should still be able to managing forking here, we do something similar in our own bisect tool) or if it's going to do this it should respect --exclude-pattern itself and not even attempt to run such specs.

The parallel test case laid out by @johnwu96822 is a good example and one I have come across leveraging CircleCI's parallelization. When one wants to parallelize but still blanket exclude tests, their CirlceCI config will have a series of commands similar to:
TESTFILES=$(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)
EXCLUDEFILES=**/tests/that/{we,want}/to/exclude**/*_spec.rb
bundle exec rspec $TESTFILES --exclude-pattern $EXCLUDEFILES --format RspecJunitFormatter --out /tmp/test-results/rspec/results.xml --format progress

In this situation, we want the exclusion filter applied to the files specified inclusion filter. This is also the behavior I would expect (as opposed to ignoring the exclusion filter).

This is also the behavior I would expect (as opposed to ignoring the exclusion filter).

It's not ignored, it's just a lower priority filter than the files you have specifically included and this behaviour is unlikely to be changed.
However you should be able to achieve your circle CI command with:
EXCLUDEFILES="tests/that/\(we\|want)/to/exclude/.*_spec.rb"
TESTFILES=$(circleci tests glob "spec/**/*_spec.rb" | grep -v $EXCLUDE_FILES | circleci tests split --split-by=timings)
bundle exec rspec $TESTFILES --format RspecJunitFormatter --out /tmp/test-results/rspec/results.xml --format progress

(Note I changed the glob to a pattern for grep, but other command line tools are capable of producing a correct output without out help here).


Add tests for GET /users/games

Pull Request Test Coverage Report for Build 250353956

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.5%) to 71.795%

Totals

Change from base Build 249544269:
1.5%

Covered Lines:
672

Relevant Lines:
936

💛  - Coveralls


Sync branches

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support Clone for SendRequest

Is your feature request related to a problem? Please describe.
I'm using the hyper::client:conn APIs to create a client over a connection. When using those APIs, seems like I need to forfeit h2 multiplexing: conn::handshake returns a RequestSender, and calling send_request takes a mutable reference to that RequestSender, which prevents me from having two in-flight requests over a single connection.
Describe the solution you'd like
I don't have a strong preference, but one of two would work:

send_request could take &self instead, or
RequestSender could support Clone like h2's SendRequest does.

Describe alternatives you've considered
I can wrap the type in an Arc<Mutex> to have it be clone and provide concurrency support, but that doesn't really address the fundamental problem of not being able to take advantage of h2 multiplexing.

Turns out this only a problem because I'm using a 0.x version of hyper. The latest version does support Clone for SendRequest: https://docs.rs/hyper/latest/hyper/client/conn/http2/struct.SendRequest.html


Remove WorkspaceDetails entry from db when matching workspace is removed

Hi,
I encountered a problem and I was wondering if this issue here actually means the same problem (hard to tell with no description). If not I'll open a new one.
The problem I'm facing:
When I try to delete a user, I get an error saying
An exception occurred while executing 'DELETE FROM neos_contentrepository_domain_model_workspace WHERE name = ?' with params ["user-redakteur"]

SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`<db-name>`.`shel_neos_workspacemodule_domain_model_workspacedetails`, CONSTRAINT `FK_923CCEA8D940019` FOREIGN KEY (`workspace`) REFERENCES `neos_contentrepository_domain_model_workspace` (`)

Is that what you encountered here too or a different problem entirely?

Hi @so-grimm, I'm not aware of that problem. This is actually resolved and I just tested it locally 🤔
Can you open a separate issue with more details like your Neos version, Plugin version, etc.


Corporate Console - Error message is not displayed in UI and no action is performed when trying to add CLA Manager with invalid data

Background

Launch Corporate Console
Login as CLA Manager (who has company with project signature)
Click on the Company
Click MANAGE APPROVED LIST
Click on ADD CLA Manager button
Enter only spaces for CLA Manager Name and CLA Manager LFID and invalid email format for CLA Manager Email

Click Save. Observed that no action is performed and error message is displayed in console

Verified and observed that Save button is not enabled when invalid date is provided for the fields

Issue already verified as per above comments


Add Framework Templating feature

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 3

Complexity increasing per file
==============================
- src/Templating/Twig.php  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/Templating/Twig.php  2

See the complete overview on Codacy


Add a limit of 10,000 HL7 records

Currently we limit CVSs to 10,000 records.
This ticket is to have the same limit for HL7s.
Look at the CSV code - the idea is to check this as early on as is reasonable - fail early, prior to wasting a lot of processing power on data that's going to fail.
So, 10,000 HL7 test-records should succeed.
10,001 should fail, reasonably quickly, with a nice error message similar to the one used for CSVs.
And of course this is test-records, NOT rows.   Each HL7 test-record is many rows, typically 10 - 20 or so rows of data each.

a) 17.5k HL7 items (8.3Mb) post request failed with  error.
Response code:Non HTTP response code: java.net.SocketTimeoutException
Response message:Non HTTP response message: Read timed out

only difference between this and the previous successful 17.5k HL7 (5Mb) item request was individual item was larger.
https://recordit.co/tu1JqqertA
curl -vvv POST -H "Content-Type:application/hl7-v2" -H "client: ignore.ignore-hl7" --data-binary @./line_request_17500.txt 'http://localhost:7071/api/reports'
curl -vvv POST -H "Content-Type:application/hl7-v2" -H "client: ignore.ignore-hl7" --data-binary @./line_request_17500_fail.txt  [line_request_17500_fail.txt](https://github.com/CDCgov/prime-reportstream/files/6888173/line_request_17500_fail.txt) 'http://localhost:7071/api/reports'
line_request_17500.txt
line_request_17500.txt
So potentially have to restrict HL7 post body by the byte size rather than item size.

another potential consideration see azure http function timeout setting
Regardless of the function app timeout setting, 230 seconds is the maximum amount of time that an HTTP triggered function can take to respond to a request. This is because of the default idle timeout of Azure Load Balancer. For longer processing times, consider using the Durable Functions async pattern or defer the actual work and return an immediate response.

i'm noticing at around 1200 HL7 items, staging post report call fails with a 503 service unavailable response code
line_request_1200_staging.txt
HTTP/1.1 503 Service Unavailable Cache-Control: no-store Content-Length: 994 Content-Type: text/html Server: Microsoft-IIS/10.0

Well, right now senders are only sending one HL7 at a time, so this is very low priority.


updated assignment of data values to not overwrite data list

@perrydv @paciorek
Fixes #941
I made a change.  It's a one-liner, but make no mistake, this is deeply rooted.  If either of you guys are uncomfortable with this, I will not take offense.
It changes how the "data" variables are assigned into the model.  Changes the assign() statement to begin looking "up" one environment, so as not to over-write the local variables, in this case, the data list, but there's also the potential for other conflicts (with other local variables) depending on what users name their model (data) variables.
Anyway, if testing passes, then I'll have confidence in it, but you'd better both take a look, and please weigh in here.

I'm confused how it ever worked, as it looks like we were assigning the data value into an object in the local frame of setData() rather than into the model itself. I must be missing something.

@paciorek IICU assign would look upward, and find the existence of the variable (say x), and assign into there.
But in the case of assigning into data, it finds the local variable first (before starting any search upwards through enclosing environments), and thus overwrites the local data variable (formerly).
Now, assign begins is search in the correct environment, that one which contains the correct x (or data) variable.

@danielturek thanks for explanation - I guess this behavior is specific RefClasses, since if one just has a function, assignment will create a new object in the local frame:
y <- 3
myfun <- function() {
   assign('y', 7)
}
myfun()
y
[1] 3

Ok, not sure what I was seeing before, but if uses inherits=TRUE (as we do in setData) then if 'data' doesn't exist in the local environment, it IS assigned into the parent and that is why things generally work.
y <- 3
myfun <- function() {
   assign('y', 7,inherits=T)
}
myfun()
y
[1] 7

Sorry about the noise...

Closing this as PR #946 will accomplish this goal by directly assigning into the field of the class rather than via use of scoping.


KAFKA-17136 Added Documentation for Shell Methods

Added documentation to make the longer and more complex methods easier to understand incase they need to be changed in the future.
No code was modified, only added docs.

Please not only 4 files were changed, and no code was altered only documentation was added.


Add filter to user and group fetch for directory sync enabled providers

Add two fields, userFilter and groupFilter to directory sync providers that support user and group filters.
We may need some investigation to determine the best syntax for this. A first implementation might use the lowest common denominator syntax compatible with all providers, according to their docs.
The use case here is applying a filter for groups based on name matching, and a filter for users based on email matching, so if wildcards prove to be too complex, having a <textarea> that accepts a CSV of the above would probably suffice.

Another option is to keep the catch-all sync like we have now and filter the received entities in the Firezone backend, which would allow us to apply a consistent format to filtering.
This means we waste a bit of bandwidth syncing entities we will throw away.


Arco data and VQP

Closes [#53 ]

@mgrover1, should I put the whole link? I have been trying to find the issue but not sure what is happening...

Looks like the link is resolved 👍

Can you add the tags for the image in the CI/binder folder?

I've described the three locations here: https://github.com/openradar/erad2024/pull/68

@aladinor Please add the tag at the other two locations, too. Thanks!

Thanks for making all those changes! This looks good to merge 👍


Add support for BrowserContext

Steps to reproduce
Tell us about your environment:

Puppeteer version: 2.1.1
Platform / OS version: macOS
Node.js version: 13.8.0

** Puppeteer Feature Request **
Playwright introduces the concept of BrowserContext objects:

Playwright also aims at being cloud-native. Rather than a single page, BrowserContext abstraction is now central to the library operation. BrowserContexts are isolated

It would be really nice to see these in Puppeteer as it allows you to run isolated independent tests using a single browser instance.
Example code:
		browser = await playwright.chromium.launch();
		context = await browser.newContext();
                page = await context.newPage( 'https://google.com' );

Great suggestion @alisterscott. Would the dev team consider adding it? If so is that something you'd want to take on or would you welcome a PR?


[Doc Update] Helidon Version update

version update from 3.0.0-SNAPSHOT to 3.0.0, Since it started giving issues while pulling the artifacts.
Below issue

@mkhalid-s Thanks for contributing this, but it turns out the root cause of the problem is in our release script that was not updated after we refactored our documentation. This is fixed by PR #4689. So I'm going to close this in deference to that PR.


Opening a form file = unnamed

Issue / opportunity
When opening a form file sent by someone else or my own, the imported draft is an unnamed form file.
Screenshot

Additionally with the latest release, this means you can't see what's actually in the form.
Private Zenhub Image

Closing as a duplicate of 4079


update_interval not working

Adding the default section to the inverter configuration and then restarting HA does not change the update rate. Code from commit c55af98
default:
  update_interval: 30
  digits: 6

Run it with debug enabled please a place the log here.
Don't forget to obfuscate the serial.

Here we go.
home-assistant_solarman_2024-07-22T17-04-45.682Z.log

Could you also show me how your inverter profile looks like?

Ah never mind I know what is the issue...

Registers which will be part of a request are decided dynamically (when not set in the inverter profile)

Can be requested individually in specific intervals according to their 'update_interval' value set in the inverter profile file (defaults to 60 seconds)

5a93aa1
default:
  update_interval: 30
  code: 0x04
  digits: 6

And delete whole requests segment.

I still barely understand this implementation cause there is so little whings which really makes sense but yeah I would love to support as much as possible. :-)
When comes to the log.. oh god that's strange... can you show me your profile file?

f422188

Fixed it and the update_interval issue :clap:


Installation Requires Thor

Current installation instructions neglect to mention Sheldon's dependency on Thor.
Installing and running Sheldon on a fresh OS X install raises the following runtime exception:
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- thor (LoadError)

Fixed by packaging Sheldon as a gem (#3c1a958ebf6543147d5a151c7bb7f5efce134987)


pipe stdout to a json streaming parser

This will remove a huge block of code from your module...
That one seems fairly recent:
https://github.com/fent/node-jstream

Right, thanks. I considered a similar solution early on but
decided that I could not count on commands going to exiftool sequentially.
Additional calls could be made in closure statements etc.
This was the easiest solution at the time. Could be reworked to use a
streaming
protocol but again you have the headache of sequencing the calls and
associated output.
So when you call sendCommands it returns a reference to the promise
created for the results of that particular command.
On Fri, Jan 29, 2016 at 4:28 PM, Jérémy Lal<EMAIL_ADDRESS>wrote:

This will remove a huge block of code from your module...
That one seems fairly recent:
https://github.com/fent/node-jstream
—
Reply to this email directly or view it on GitHub
https://github.com/crussell42/exiftool-node-stayopen/issues/3.


Implement MapSkipError, analogous to VecSkipError, but for map-like data structures.

Currently, there is a VecSkipError for resiliently handling heterogenous sequences. However, there are also heterogenous maps in the wild, notably the bundle version information plist from Apple.
This PR implements MapSkipError, analogous to VecSkipError, deserializes an entry only if both the key and value are deserializable.
Notable Changes

The impl of VecSkipError is moved to a new file de/skip_error.rs and ser/skip_error.rs to reuse GoodOrError with MapSkipError.
The impl of MapSkipError works for all the maps enumerated by impls::macros::foreach_map.

Unanswered Questions

[x] Do we also need to implement this for kv-tuple lists?
[x] Do we also need to implement modules under serde_with::rust for BTreeMap and HashMap?

Thanks for the PR, this looks all really good.
Regarding your questions:

It is not necessary to support kv-list. You can add support if you want, but this PR is fine to merge as is.
No, you shouldn't add more to serde_with::rust. The VecSkipError doesn't have any other variations either. In general, it is difficult to combine such different behaviors and if you combine too many you have a giant compatibility matrix.

Cooool.
You are right. Under the current way of enumerating different types of map, adding support to kv-list probably means adding support for MapPreventDuplicates and alike, which is out of the scope of this PR. I don't plan to further change this PR then.

Thanks for the work :) I try to prepare a new release this weekend.


Better support for Vuex strict mode

Hi,
I have a vue component, essentially like the below, allowing user to edit myCopy with v-model fields, then commit or reject the changes.
<template>
    <div v-if="myCopy">
        <input v-model="myCopy.title" type="text">
        <input v-model="myCopy.text" type="text">
        <button @click.prevent="commitCopy()">Save</button>
    </div>
</template>
<script>
import { mapGetters } from "vuex";
export default {
  computed: {
    ...mapGetters("someService", {
      myCopy: "getCopy"
    })
  },
  methods: {
    commitCopy() {
      // Commit Copy stuff
    },
  }
};
</script>

This works great until i start to edit one of the input fields, and I get this error:
[vuex] Do not mutate vuex store state outside mutation handlers.

I can prevent the issue, by changing my store.js file like this solution:
https://github.com/nuxt/nuxt.js/issues/1917#issuecomment-338471402
I don't feel like that is the right answer, and was just wondering if the getCopy getter should support a Two-way Computed Property like so:
https://vuex.vuejs.org/en/forms.html
Many thanks

Are you using Vuex in strict mode?  If so, you might not be able to use the copy feature.  I'm not certain that this would be the issue, though.
By the way, there's a new API coming that will allow multiple copies, you can check out the tests here: https://github.com/feathers-plus/feathers-vuex/blob/models/test/service-module/service-module.test.js#L29

Thanks for the reply... and the incredible work with this package! Yep, thats right, if i disable strict mode it allows the mutations. Is that the ideal solution? Any other way around it? Cheers :)

Nuxt ships with vuex strict mode by default, but its easy to disable in the store itself if anyone stumbles across this.
https://vuex.vuejs.org/en/strict.html

Uggh.  I personally don't use strict mode, although I can see how it would be beneficial.  It basically means you have to create a mutation for every change to an object.  So, to update a user's age, instead of just pulling down a user record and doing user.age = 45, you have to create a setAge mutation and do commit('users/setAge({user, age: 45})  It's certainly useful to prevent errors during development, but you definitely don't want to ship an app in strict mode.
The official stance on vuex strict mode is that it requires much more work to implement it, period.  The new API will open it up to allow better support for strict mode in a future release.  The goal of feathers-vuex is to remove as much boilerplate code as possible.  It does a great job of this outside of strict mode.  In strict mode, the developer will have to write more custom mutations, which is just the nature of developing for strict mode.
The simplest way for somebody to support strict mode right now would be to create their own deep-cloned copy of a record as it comes out of the store, make changes to it, then use the updateItem mutation to update the store.

I'm really glad you opened this issue because it got me thinking more about strict mode.  I thought that adhering to strict mode would definitely be a problem for the relational stuff that I'm working on.  I just tested it out and, thankfully, all of my efforts will not be in vain!
So here's a preview of what's coming:  Suppose you had an API that returns data in the following format, where the todo record has an itemId and the item is populated as part of the response:
const todo = new Todo({
  id: 'todo-1',
  description: 'todo description',
  itemId: 'item-2',
  item: {
    id: 'item-2',
    test: true,
    todo: {
      id: 'todo-1',
      description: 'todo description'
    }
  }
})

I've got it currently setup so that when this todo is inserted in the store, feathers-vuex will store the todo in the todos store, as you'd expect, but it will first automatically create the item in the items service store.  When the todo instance is stored, it contains a reference to the item in the items store.  I thought that due to the way strict mode is setup, it would have a fit with this, even if you used a mutation to make the changes.  The good news is that it works without errors as long as you use a mutation!
Here's a mostly-full example:
// Setting up the store
this.store = new Vuex.Store({
  strict: true,
  plugins: [
    service('todos', {
      instanceDefaults: {
        id: null,
        description: '',
        isComplete: false,
        taskId: '',
        task: 'Task', // This sets up the relationship
        item: 'Item'
      }
    }),
    service('items', {
      instanceDefaults: {
        test: false
      },
      mutations: {
        // Here's our custom mutation for updating the `test` boolean
        toggleTestBoolean (state, item) {
          item.test = !item.test
        }
      }
    })
  ]
})

// Now, assume the below code is in a component
const { Todo, Item } = this.$FeathersVuex

// When you create instances that already have an `id`, they get added to the store, automatically
const todo = new Todo({
  id: 'todo-1',
  description: 'todo description',
  itemId: 'item-2',
  // Because we setup the relationship, this gets added to the `items` store, since it also has an `id`
  item: {
    id: 'item-2',
    test: true
  }
})

const storedTodo = store.state.todos.keyedById['todo-1']
const storedItem = store.state.items.keyedById['item-2']

// Calling the mutation to change a record's property works fine in strict mode
store.commit('items/toggleTestBoolean', storedItem)

// Changing the property directly will throw errors in strict mode
todo.item.test = false

assert.equal(todo.item.test, false, 'the nested todo.item.test should be false')
assert.equal(storedTodo.item.test, false, 'the stored todo.item.test should be false')
assert.equal(storedItem.test, false, 'the stored item.test should be false')

So, if everything works out, this will all work in strict mode.  It works in the tests, but I have to still test it out in a production app.

The pre-release works really well with strict mode, by default.  I'm closing this issue because the pre-release is stable.

My issue was that some parent scope data was being changed outside the async block. The solution is to define anything you modify in the same block.
Bad when you have more than 1 page:
 fullFind: async function ({ commit, dispatch, getters, state }, args) {
      const sm = { p: { limit: 0, skip: 0, total: 1 } }
      const myArgs = args ? Object.assign({query: {}}, args) : {query: {}}
      myArgs.query = Object.assign({}, myArgs.query)

      while (sm.p.total > (sm.p.limit+sm.p.skip)) {
        myArgs.query.$skip = sm.p.skip + sm.p.limit // BAD
        sm.p = await dispatch('find', myArgs)
      }

      return getters.find(args)
    }

Good always:
fullFind: async function ({ commit, dispatch, getters, state }, args) {
      const sm = { p: { limit: 0, skip: 0, total: 1 } }

      while (sm.p.total > (sm.p.limit+sm.p.skip)) {
        const myArgs = args ? Object.assign({query: {}}, args) : {query: {}}
        myArgs.query = Object.assign({}, myArgs.query)
        myArgs.query.$skip = sm.p.skip + sm.p.limit
        sm.p = await dispatch('find', myArgs)
      }

      return getters.find(args)
    }

In this example sm.p doesn't trigger the error because i'm not modifying it's values, only a reference.


Add more robust handling of long descriptions

This PR makes some major improvements in how we handle the long_description field from setuptools:

Now if the long description is given as an inline string in setup.cfg or setup.py (as far as we can tell) rather than being loaded from a file, it will be kept as an inline string in pyproject.toml.
If there's no content type provided and one cannot be definitively determined from the file extension, the user can provide it with a new option --readme-content-type; otherwise the program will guess text/plain.
It fixes the error where the long description would sometimes be missing from the command options, closing #132.
The code is refactored to be more modular and more testable.

Thanks to contributors on a Mastodon thread for some useful discussion.

@diazona No problems, well I can review and hold off on actual merging if you think there might be last-minute changes.  I'll fix that and re-push - the overall diff will be the same, I just have to move a few patch fragments from one commit to another.

OK done! I can go ahead and merge this, since you already approved. (Which brings to mind the separate issue of whether approvals should be reset when the branch is rebased; I feel like it's more "technically correct" to do so, but it really doesn't matter in this context.)


🗺 Fetcher Tweaks

Discussion: #7698
React Router PR: https://github.com/remix-run/react-router/pull/10949
Remix PR: https://github.com/remix-run/remix/pull/7704

Brought back working on a couple bugfixes


Add accept-charset UTF-8 for POST requests

By default POST body should be supposed to be encoded in Latin-1/ISO-8859-1.
So if we want to pass some data with POST requests via $.fileDownload there's a possibility that server will read that data as ISO-8859-1. Usually it's not that users want. It differs from ajax request via XHR which are always in UTF-8. So it would make sense to add explicit encoding for POST request. For the case when data are being sent via hidden form it should be specified in form attribute as:
<form enctype="application/x-www-form-urlencoded;charset=UTF-8">
OR
<form accept-charset="UTF-8">

Sure, feel free to add that as an option!


Make README formatting more consistent

Description
This change aims to make the formatting of the README a bit more consistent, mainly for ease of viewing on the command line. The bulk of the change is to break lines at sentence boundaries pretty much always, roughly in the spirit of semantic line feeds. Along the way I fixed a couple of typos, wrapped a few items in backticks, and removed some tab vs. whitespace contention.
This change does not intend to add/remove/declarify any documentation, so if I've mucked anything up I'd be more than happy to fix.

Closing for now, as this is a fairly low priority PR and there is a lot of other activity going on! Feel free to re-open and merge at your leisure 😄


zotero refuses to export Better BibLaTex formatted citations

support log ID : EKE9YJ2X-euc
System :
MacOS v10.15.7
Zotero v<IP_ADDRESS>
Better BibLaTex v6.1.7
All citation styles and exportation formats work on my system (by cmd-shift-C of an item in a collection) except those provided by Better BibLaTex that lead to an error message "An error occurred while trying to export the selected file."
Re-installing the Better BibLaTex module, updating its exportation formats, changing the different options in the preferences leads to the same failure.
Too bad.
Thanks in advance for your help.
Sylvain
PS: Follows the detailed log of the error.

zotero(3)(+0005055): Keyboard shortcut: copySelectedItemsToClipboard
zotero(3)(+0000002): {better-bibtex error} +336016 Zotero.Translate.Export::translate error:
zotero(4)(+0000001): Translate: Binding sandbox to http://www.example.com/
zotero(4)(+0000006): Translate: Parsing code for Better BibTeX (ca65189f-8815-4afe-8c8b-8c7c15f0edca, 2022-01-19)
zotero(3)(+0000167): Translate: Beginning translation with Better BibTeX
zotero(1)(+0000002): TypeError: this.preferences.skipFields is undefined
init@chrome://zotero/content/xpcom/translation/translate_firefox.js line 425 > eval:65591:7
doExport@chrome://zotero/content/xpcom/translation/translate_firefox.js line 425 > eval:75195:5
rest@chrome://zotero/content/xpcom/translation/translate.js:1356:28
Zotero.Translate.Base.prototype._translateTranslatorLoaded</<@chrome://zotero/content/xpcom/translation/translate.js:1346:37
zotero(2)(+0000000): Translate: Translation using Better BibTeX failed:
TypeError: this.preferences.skipFields is undefined
init@chrome://zotero/content/xpcom/translation/translate_firefox.js line 425 > eval:65591:7
doExport@chrome://zotero/content/xpcom/translation/translate_firefox.js line 425 > eval:75195:5
rest@chrome://zotero/content/xpcom/translation/translate.js:1356:28
Zotero.Translate.Base.prototype._translateTranslatorLoaded</<@chrome://zotero/content/xpcom/translation/translate.js:1346:37
tryCatcher@resource://zotero/loader.jsm -> resource://zotero/bluebird/util.js:16:16
module.exports/Promise.prototype._settlePromiseFromHandler@resource://zotero/loader.jsm -> resource://zotero/bluebird/promise.js:547:13
module.exports/Promise.prototype._settlePromise@resource://zotero/loader.jsm -> resource://zotero/bluebird/promise.js:604:13
module.exports/Promise.prototype._settlePromise0@resource://zotero/loader.jsm -> resource://zotero/bluebird/promise.js:649:5
module.exports/Promise.prototype._settlePromises@resource://zotero/loader.jsm -> resource://zotero/bluebird/promise.js:729:13
_drainQueueStep@resource://zotero/loader.jsm -> resource://zotero/bluebird/async.js:93:9
_drainQueue@resource://zotero/loader.jsm -> resource://zotero/bluebird/async.js:86:9
Async.prototype._drainQueues@resource://zotero/loader.jsm -> resource://zotero/bluebird/async.js:102:5
Async/this.drainQueues@resource://zotero/loader.jsm -> resource://zotero/bluebird/async.js:15:9
downloadAssociatedFiles => true
automaticSnapshots => true
zotero(5)(+0000001): Translate: Running handler 0 for error
zotero(5)(+0000001): Translate: Running handler 0 for done
zotero(3)(+0000000): Alert:
Une erreur s'est produite lors de la tentative d'exportation du fichier sélectionné.
Possibly unhandled rejection:

Can you

Restart with debug logging enabled from the Help menu
retry the above, reproducing the error
send a new debug log ID

there's no need to paste the log here, the debug log ID should give me enough information (but in this case I did not see an attempt in EKE9YJ2X-euc)

Hi @retorquere -
Having an issue with the Quick Copy. Here is my support log ID: NRE6UDS7-refs-euc

Thank you. I have it reproducible, which means a fix should be quick.

I have the same issue. my support log ID is D920051477

I enabled biblatex log and get the ID MUEDWVK3-euc
thanks in advance

I have it reprodicuble. No further logs are needed until a test build drops here.

Can you guys confirm this fixes it?

it worked perfectly thank you so much

Hello,
I tried the corrected version. It works perfectly !
Thank you so much. You are so incredibly reactive !
best regards,
Sylvain
Le 23/01/2022 à 19:39, Emiliano Heyns a écrit :

Can you guys confirm this fixes it?
—
Reply to this email directly, view it on GitHub
https://github.com/retorquere/zotero-better-bibtex/issues/2029#issuecomment-1019542569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASNS4SPRXBBQED4FBGC4XGDUXRDO5ANCNFSM5MPXXXWQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Dr. Sylvain Douté
Researcher in Planetary Physics
Webpage :http://ipag.osug.fr

Institut de Planétologie et d’Astrophysique de Grenoble (IPAG)
Université Grenoble Alpes / CNRS-INSU
UMR 5274
Postal address:
IPAG,
Université Grenoble Alpes,
Bât OSUG A
CS 40700
38058 Grenoble Cedex 9
Tel : +33 (0)<IP_ADDRESS>.71
Fax : +33 (0)4 76 51 41 46

Super, thanks for the confirmation, a new release is building. You will be upgraded automatically.

Also working for me. Thank you for the quick fix!


Custom Prometheus exporter configuration

This PR:

Modifies operator to use a user created Config Map to add custom configuration for the prometheus exporter.
Updated docs and templates

JIRA: https://jira.d2iq.com/browse/D2IQ-60293

@shubhanilBag you need to run
tools/docker.sh tools/compile_templates.sh
tools/docker.sh tools/generate_parameters_markdown.py
tools/docker.sh tools/format_files.sh

and commit any changes done indocs/monitoring.md and docs/parameters.md


[backport 1.x] Added option for httpHostPort and transportHostPort

Description
This change adds options for httpHostPort and transportHostPort in 1.x (Backport)
Issues Resolved
Resolves #335 in 1.x
Check List

[x] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[x] Helm chart version bumped
[x] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sbnmanthey Can you resolve the conflicts here and also address the lint failure?

@TheAlgo @DandyDeveloper  I've bumped the chartVersion as requested, can you approve my PR?

@sbnmanthey Please resolve conflicts. Thank you!

Backport was already applied in #411. I close this PR unmerged.


Java flight server with different producers

Implement a Java Flight server with two producers: InMemoryProducer and RelayProducer

Done in https://github.com/mesh-for-data/arrow-data-plane/pull/21.


Add suggested completions for key chords

With more complex key chords, it would be incredibly helpful to have "suggested" completions, based on the first element of the chord. For example, consider the following complicated workflow:

You type CMD + K
Visual Studio Code waits for the next key of the chord (but doesn't tell you what valid options could be typed)
User forgets or doesn't know the shortcut he wants, so he hits ESCAPE
User hits F1 to search for the desired command and keyboard shortcut
User hits ESCAPE
User executes keyboard shortcut

Instead, what should happen is that VS Code should show the users all of the key chords (or perhaps most commonly used commands by that specific user, based on telemetry data), that could possibly be pressed.
This would have the following benefits:

Significantly improve the user experience
Ease the learning of new keyboard shortcuts
Tailor the Visual Studio Code environment to each user (optional)

Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell
https://trevorsullivan.net
https://twitter.com/pcgeek86

Eclipse does this and it is very nice.  You have a popup menu after waiting about 1 second.  You can then use the cursor keys to pick an item or finish the key chord.

http://spacemacs.org/ has this too and I love it. I makes discovering and learning key bindings easy.

Eclipse does this and it is very nice. You have a popup menu after waiting about 1 second. You can then use the cursor keys to pick an item or finish the key chord.

Blender also pops up a menu when there are more chords available.

Has there been any progress on this topic? I came here searching for how to use shortcut chords, thinking VSCode already had this feature.

Is there any plans to support it? Or are there any extensions which might help with that? The one above is not exactly what the topic starter meant I guess

Just to expand on this; I think that it's important to have this feature if you want to build up a set of mnemonic chords for shortcuts, similar to how Spacemacs is set up. This, plus the addition of 3-step chords (#6966), would make VSCode really flexible for the users that want to make sure their setup is exactly the way they want it.

+1 to this, I'm trying to move from spacemacs and the which key extension is amazing, I want to setup my keybinds so that all non-text editing keybinds are using chords and it is a pain in the arse. This would make my life so so much easier

Shameless plug, but in this vein I created a keymap called Chord Heavy, inspired by Spacemacs chords. It’d greatly benefit from having this feature added!

I'm also interested in this, I think it would be a great addition. What's the requirement for getting this approved/ voted, etc?

Was hoping to find it already existed. How frustrating.

Just found this, which may help some folks out. Not at my PC so haven't tried it
https://marketplace.visualstudio.com/items?itemName=VSpaceCode.whichkey&ssr=false#overview

I think this would greatly enhance the user experience for many, many people. Furthermore, the addition of this feature would, in my humble opinion, help with VSCode product adoption. I use both Neovim and VSCode, but have been transitioning to using the latter much more often lately.
I miss the feature provided by which-key, a popular Neovim plugin that has been mentioned within this ticket above. The plugin emulates the exact behavior that is being requested by this issue. I personally use a lot of key chord combinations, as it greatly increases the number of actions one can do at any given time and makes things (generally) more convenient. Furthermore, VSCode itself has tons of built-in chord combinations.
I truly think it would help others transition from Vim/Neovim to VSCode if this feature were to exist, or have better support for it. As a human, it is, unfortunately, very difficult to remember every sequence of keys, all of the time. It's great when we do, but can really interrupt our flow when we forget, and have to refer to our key-bindings again (and again, maybe! ;).
Is there anything that is blocking this issue? I don't see any contributor activity in this issue, so I figured I would ask. I do fully understand that this is mainly a quality-of-life enhancement, and likely has low priority, but it would definitely be a huge enhancement to user/developer experience.

@ellacrity yes, see VSpaceCode and vscode-which-key

Is there any update on this matter? VSpaceCode](https://github.com/VSpaceCode/VSpaceCode) and vscode-which-key are ok for Vim extension users, but it would be beneficial to have the idea presented by @pcgeek86 built in the VSC, to support native chords.


Adding details to destroy() documentation

Adding details of optional paremeters for Widget.destroy(), from issue https://github.com/marko-js/marko-widgets/issues/61.

Looks great. Thank you!


[FEATURE] 🤔 Conditional Refresh

Problem
Sometimes the payload to receive from the so called single source of truth (eg: the database, a remote service, etc) can be quite big, and in those situations it is a waster to get and process it (eg: deserializing) each and every time even when the data has not changed.
Ideally there should be a way to keep track of the "version" of the cached data and, when requesting for a refresh of that, be able to handle a scenario where the data is not changed, so to keep the "stale" data which, in such a case, would not actually be stale.
As pointed out quite well by the community member @aKzenT in their original issue, it would be nice if FusionCache natively supported what's commonly known as conditional requests, but for when refreshing the cache.
And so the name: Conditional Refresh.
Solution
Native support should be added to FusionCache, thanks to the addition of a 2 new tracked props: string? ETag and DateTimeOffset? LastModified: these new props will be available in the FusionCacheFactoryExecutionContext<TValue> (see below for more), which is the ctx param we normally see when calling some of the available overloads of the GetOrSetAsync(...) method.
Also in the context we'll need to add support to for accessing the stale value, if any, thanks to the new StaleValue prop, of type MaybeValue<TValue> (so we can check if it actually has a stale value or not).
This is how the code would look like:
var product = await cache.GetOrSetAsync<Product>(
	$"product:{id}",
	async (ctx, ct) =>
	{
		using var req = new HttpRequestMessage(HttpMethod.Get, $"/api/product/{id}");

		if (string.IsNullOrWhiteSpace(ctx.ETag) == false && ctx.StaleValue.HasValue)
		{
			// LAST MODIFIED + STALE VALUE -> TRY WITH A CONDITIONAL GET
			req.Headers.Add("ETag", ctx.ETag);
		}

		using var resp = await client.SendAsync(req, ct);

		resp.EnsureSuccessStatusCode();

		if (resp.StatusCode == HttpStatusCode.NotModified)
		{
			// NOT MODIFIED -> RETURN STALE VALUE
			return ctx.StaleValue.Value;
		}

		// NORMAL RESPONSE: SAVE ETAG + RETURN VALUE
		ctx.ETag = resp.Headers.ETag?.ToString();

		return await resp.Content.ReadFromJsonAsync<Product>();
	},
	opt => opt.SetDuration(duration).SetFailSafe(true)
);

It should be noted that this will require a breaking change, since previously the context was of type FusionCacheFactoryExecutionContext and now it should become FusionCacheFactoryExecutionContext<TValue>, so that the stale value would accessible, and typed correctly.
This may break existing calling sites, but only the ones that use the overloads WITH the context AND that do NOT specify the type (eg: GetOrSet(...) instead of GetOrSet<TValue>(...)). This is because the current C# compiler is not able to infer the type of the context based on the inner return type of the lambda (factory).
The added value is so big, and the existing call sites should not be that many, that this is a worthy breaking change (and most probably the last one) before the final v1.0.

The proposed design is similar to my original proposal except for one thing. I originally proposed that the factory returns a "NotModified" sentinel when the value is unchanged.

I thought about that, but that would've meant not returning a value from the lambda, which is not possible: actually there's a way to do that, but basically it meant having a method on the context that internally would have thrown a special exception caught "outside", but I don't like using exceptions for control flow.

In your version you are simply passing the stale value to the factory which can choose to return that stale value. I think your design is more flexible and therefore preferible.
So, I don't see any issues from my side.

Good 👍
Another detail is that I've added 2 props, one for the LastModified and one for the ETag: the idea was that in case of a DateTimeOffset it would have allocated less space than a string.
But.
But then i remembered something I've read in the specs for the Last-Modified header, and the format for the value is not really that friendly to be parsed as a DateTimeOffset, so I can probably just use 1 prop with a generic name, for both the ETag case and the Last-Modified and leave the detail of the string itself to the implementers.
Thoughts?

Hey,
while that is true, as far as I see, .NET parses these header values to DateTimeOffset in most places. So you would probably not need to work with the raw strings.
We could still unify that to one prop, but then maybe we would need another name and might consider making it an "object". Or even providing a generic Metadata dictionary that users and plugins can fill as they see fit.

while that is true, as far as I see, .NET parses these header values to DateTimeOffset in most places. So you would probably not need to work with the raw strings.

Yeah I've made some tests, and it seems that it is true.
On the other hand, the way DateTimeOffset are currently normally serialized is such that the timezone specifier is usually converted to UTC and then lost, so basically it would mean getting GMT from the server, storing it as UTC and then sending it back as UTC, maybe resulting in a different match.
I have to do some tests...

We could still unify that to one prop, but then maybe we would need another name

I'm playing locally with Version, plain and simple.

and might consider making it an "object".

Nope, that would not work with the 2nd level (eg: serialization).

Or even providing a generic Metadata dictionary that users and plugins can fill as they see fit.

Mmmh, probably too heavyweight.
Will update you soon on these issues.

Hi @aKzenT , I've played with the 2 different approaches:

1 prop: string? Version
2 props: string? ETag + DateTimeOffset? LastModified

After some back and forth, here are my thoughts.
Version prop
Having only string? Version seems easier, and we may store into it either and ETag or a Last-Modified header in the shape of a single string.
On the other hand though it can also seem limiting since for different reasons we may want to also store a potential Last-Modified header: for example the specs suggest, when we have both, to send them both in a refresh request, even though the server must use ETag first.
Finally, the name "Version" may feels fine with "ETag" (they are both version identifiers), but a little bit less so with "LastModified" because yes, such a value may be used to identify a version of a value, but it's not a version itself.
We may pick a different name, but I don't feel there's a single name that can be used to confidently communicate it can be used for both (even though this is a small issues, because of xml docs, tutorials, etc). But still.
LastModified + ETag props
The Last-Modified header seems to be in fact easily parsable by the DateTimeOffset class: on top of that, there are ready-made methods and props that does that automatically in a strongly type way like this and this.
The ETag header instead is quite easier to work with, since it's just a plain string?
Having both an ETag and a LastModified props can cover more situations.
Make It Easier
While I was at it, I've also added to the context class 2 new props and 2 new methods:

public bool HasStaleValue { get; }: to quickly check if there is a stale value
public bool HasETag { get; }: to quickly check if there is an ETag specified
public bool HasLastModified { get; }: to quickly check if there is a LastModified specified
public TValue NotModified(): used to clearly show in code the intent of returning the currently cached value, because it was not in fact modified and is still valid
public TValue Modified(TValue value, string? etag = null, DateTimeOffset? lastModified = null): used to clearly show in code the intent of returning a modified (eg: new) value, potentially along with a value for the ETag, the LastModified, or both of them (the props are also directly modifiable on the context, of course)

Working Branch
I've pushed a working branch with all of this, if you want to take a look at it.
Example
The resulting code using all of this looks something like this.
To me it seems quite clear and concise: what do you think?
More?
It's important to avoid re-creating parts of an http client caching handling with something like a dictionary, because frankly it seems too heavyweight. And just give the most common use-cases a quick and easy way of being handled, which means having the 2 most common props: ETag and LastModified, with ETag being the most used.
For any scenario that needs more advanced stuff (like storing all the response headers, etc) users can just create their own "wrapping" class with whatever extra props they may need, and cache that instead, like this:
public class MyResponse<TValue> {
  public Dictionary<string, string> Headers {get; set; }
  public int StatusCode {get; set; }
  public TValue Value {get; set; }
}

// ...

cache.GetOrSet<MyResponse<Product>>(
  ...
);

By caching this + using the new ctx.StaleValue prop + the 2 new ctx.NotModified() and ctx.Modified(...) methods, it should be pretty darn easy to implement more advanced conditional refresh scenarios, without having to pay the extra cpu and memory every single time for anybody else out there.
Your thoughts?
What do you think about this train of thoughts? Any suggestion or corrections?

I agree with that reasoning. I also feel that "Version" could mean a lot of things in a caching framework and it is not obvious that it should be used for ETags, etc. without reading the docs.
The example looks good to me. I think that would work nicely.
Long-term I still think there would be a benefit to having the entry class be a bit more extensible. While wrapper classes work for many scenarios, they shift caching-concerns into the consumer instead of allowing them to live separately, e.g., in the form of a plugin. But that is a separate discussion, which does not need to be addressed in this PR.

Hi all, v0.21.0-preview1 is out which includes this, too.

Hi, v0.21.0-preview2 is out: one more week of baking and the official v0.21.0 will be released 🎉

Hi all, I just release v0.21.0 which includes this 🎉


Added is_published field in curated watchtower and curated slashdot f…

…or essays app.
Resolved issue #164 by adding is_published object into CuratedWatchtower and CuratedSlashdot for essays app.

Hi Abu,
When ticking the ‘Is published’ box (switch) in the Admin dashboard, the behavior of the web app doesn’t change. The toggle is useless.
The feature already exists in a different web app, specifically Essay articles as demonstrated in this video:
https://user-images.githubusercontent.com/6686723/150201844-3fa5a806-4cae-4c02-b5fd-27ef81f3865c.mp4
This is how the feature should behave. But the way you implemented it, you just added a bool field which does nothing.

Once I have the above question answered, I think I'll be able to merge this PR into master.


z-index and multiple popup instances

There is a bug with z-index when there are multiple popup instances.
In this code (http://jsfiddle.net/3t74x6v0/3/), my_popup2 is initialized before my_popup and my_popup2 (yellow popup) is above my_popup (red popup)
In this code (http://jsfiddle.net/3t74x6v0/4/) my_popup2 is initialized after my_popup and my_popup2 (yellow popup) is under my_popup (red popup). Is this behavior normal? Why?

Thanks for reporting. Fixed in v2.1.0 (14b77ea).
The issue was reproducible on pages that had no z-index set on any element on the page, so the maximum z-index was 0.


Specify governance constants

As of #1109 we export an object of committeeIds which is intended to hold constant ID values for the various committees on a per-chain basis. These should be added as soon as the relevant chains have been deployed. Same applies to guaranteeFundEscrowIds and rewardFundAddresses.

Is this in scope of IOV-Core? I think this should remain configurable, such that the wallet can use different values for the development/staging/production networks using different config files.

It turns out that those values can very well be managed in the network-dependent configuration files of the governance app. New id to address helpers have managing the addresses sufficiently convenient. For this reason we should instead remove the entire ./committees module as well as the reference in const { /* committeeIds, guaranteeFundEscrowIds, */ Governor, ProposalType } = require("@iov/bns-governance");


Create an awesome page you could probably live without.

made w/ github editor.
yeet.

Nice. Thanks!


Remove spaces before and after tags and values to improve user experi…

…ence

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

This is fine to change, please update changes.md in the root.
We need that for releasing.


Running individually packaged functions locally

I have a Python function I'm individually packaging with requirements with a config like
plugins:
  - serverless-python-requirements
package:
  individually: true
functions:
  hello:
    handler: handler.lambda_handler
    module: func1

With a file structure like
serverless.yml
func1/
  __init__.py
  handler.py
  requirements.txt

I can deploy this function and it works fine, but when I try to invoke it locally, it fails. It looks like it doesn't do anything with the module, and just tries to run handler.lambda_handler instead of ./func1.handler.lambda_handler. If I change handler to func1.handler.lambda_handler, it runs locally, but obviously would fail when deployed.
Is there something I'm missing to make this work, or is this something that's possible to do with this plugin?

good catch. @cgrimal, i think we could fix this by tapping in to the invoke local event and modifying functions.FUNCNAME.handler by prepending functions.FUNCNAME.module if it's set. Does that sound reasonable?

@dschep It looks like even prepending the module to the handler would create some side effects like relative imports https://github.com/UnitedIncome/serverless-python-requirements/issues/520.
I'm curious if we can set the PYTHONPATH to module before an invoke:local:invoke event (if the module is defined) since the definition of module in this plugin is kind of implying where we want Python to search for the function(?)


Thrust and native threading (C++11 only)

I was wondering if Thrust provides abstracted support for std::threading ( Say for like when a CUDA device is not there but a rather respectful CPU is).  The idea is to allow a developer to author a Thrust supported application on a native host and later, with little or no change to code, supporting a GPU.
If this is not an available aspect of Thrust would it be of value for someone (like myself) to add it in support of the Thrust community?

There are OpenMP and TBB backends already implemented, along with a serial C++ backend.  These three different backends already make it convenient to develop on the CPU, and just recompile to run on the GPU when you need to.
Regarding std::thread in particular, there's nothing in this repository that uses std::thread as far as I am aware.  I have no idea if the Thrust developers are interested in adding additional backends, but I personally think a std::thread backend would be pretty useful, since it would just use standard C++ to achieve parallelization, without requiring an external library (TBB) or language extension (OpenMP).

There is a cpp backend, which is currently based on C++03 facilities. In principle, the cpp backend could target facilities from later language standards. One problem with attempting to target std::thread in particular is that it is not particularly helpful on its own. It would require quite a bit of infrastructure built on top of C++11 concurrency functionality for the backend to be worthwhile. Since we already have CPU-enabled parallelism via other means, it might be most productive to let the cpp backend simply wait for C++17 parallel algorithms.

We should have implementations of the C++17 parallel algorithms from major vendors in the next few months; this should cover the CPU space. It would probably be low effort to have the cpp backend target your compiler's native CPU parallel algorithms implementation (as Jared suggests, IIUC).

@brycelelbach
Can you point me to ETA for PSTL in GCC, Clang, etc? I use Intel PSTL and GCC's hackish approximation to PSTL. I haven't seen any discussion on Clang list in a while, but perhaps I'm not on the right one.
Is Thrust going to become the official NVIDIA C++17 PSTL implementation?

@jeffhammond,
Please forgive me; I saw your comment a few weeks ago, meant to reply, and forgot.

ETA for PSTL in GCC, Clang, etc?

I anticipate Visual Studio will be the first of the major three C++ compiler/standard library implementations to release a feature complete parallel algorithms library. Billy O'neal has been spending a lot of time working on it (he and I have had some interesting discussions about implementation details on twitter).
GCC, Clang - at least a couple of months out, I think. They both have seasoned standard library maintainers working on it.
I wouldn't be surprised if libstdc++ has it first, and libc++ ends up being the last standard library with an implementation. It's just a matter of manpower - libc++ needs more people working on it.

Intel PSTL

I've actually haven't played around with this one yet.

Is Thrust going to become the official NVIDIA C++17 PSTL implementation?

We're still in the process of formulating future plans for Thrust.

@brycelelbach
Thanks for the update.  I don't use Windows so anything in MSVC isn't useful to me, but it is good to hear that libstdc++ and libc++ are working on it.  https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html seems like it's close enough that GCC will have this soon enough if people put in the effort.
Since my first post, Intel released its PSTL implementation (https://github.com/intel/parallelstl) and I have tested it in conjunction with Intel, GCC, and Clang via the PRK (e.g. https://travis-ci.org/ParRes/Kernels/builds/287622978).  This looks like an existence proof that PSTL can be standalone relative to libstdc++ and libc++ (TBB 2018 is the critical dependency).

Still can't comment on PSTL plans. But I'm going to go ahead and close this one, as I think the cpp backend has this functionality, although it probably needs some love.


Does it work on nuxt 2 as well?

Hello.
Does it work on nuxt 2 as well?

I have no experience with Nuxt, if the framework can work with VueJS components I would think so.


Datepicker overflow issue on IOS

Hi
Following this issue #86, and applying
.jsgrid` {
    overflow: visible;
}

I solved the described issue on all browser except Iphones/Ipads one...where the datepicker stay hidden...
Any Idea to solve it?
Thanks

Could you provide a jsfiddle or something showing the problem, so it's possible to see the issue and play with it?

Impossible today to reproduce the bug on JSFiddle. Maybe a conflict with other js/css files in my main project.
I keep trying tomorrow and come up with news

No reply. Closing


Add app screenshots to Readme.md

@mananwason here you go.
Cheers.

@championswimmer Have a look at this too.
I have resent a PR to add app screenshots to Readme.md
Cheers.


crash on startup

lessmsi-gui.exe and lessmsi.exe are crashing on startup, showing the default windows "... has stopped working" notice.
This is with version 1.6.1
If I remove all files in c:\Users%userprofile%\AppData\Local\LessMsi\ it works again.
If I edit the user.cfg to remove all previous msi files (that don't exist anymore) it works again.
lessmsi-gui.exe_Url_x0j5sudoke0qszxie0k512s0c5i5wuri.zip

Bummer, but thank you for reporting this! I'll look into this when I have a moment. If you would like help preparing a fix and pull request let me know!

I can't program my way out of a cardboard box, so that's not going to help.
However, I have two different configuration files for you:
lessmsi2342.zip
If I remove one previous file entry from the config file it works. Would I add a random item back, it will fail again. Maybe the reader of this part can't handle more than nine strings at a time?

I have the same problem. Event Viewer reports the exception:
Application: lessmsi-gui.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IndexOutOfRangeException
   at LessMsi.Gui.MruMenuStripManager.FixupMenuItems()
   at LessMsi.Gui.MruMenuStripManager.OnItemsChanged()
   at LessMsi.Gui.MruMenuStripManager.LoadPreferences()
   at LessMsi.Gui.MruMenuStripManager..ctor(System.Windows.Forms.ToolStripMenuItem)
   at LessMsi.Gui.MainForm..ctor(System.String)
   at LessMsi.Gui.Program.Main(System.String[])

Thanks for the note @c0shea ! If you would like help preparing a fix and pull request let me know!


It just doesn't work after update

After extension was updates, I get nothing more then { "isTrusted": true} as a response to all queries and mutations. I used this extension a lot, so I know how it works. Now it's broken.

@UlyanaKiklevich Sorry this isn't sufficient information. Can you use the issue template? What platform are you using? What version of the app? Any screenshots?

I have the same problem. Always getting  { "isTrusted": true}
App Version: 2.4.2 used as chrome extension
Google Chrome Version 79.0.3945.88 (Official Build) (64-bit)
On graphiql same request works but on altair doesn't.

Is the GraphiQL hosted in your domain? What error do you see in the developer console in Altair? Is it CORS related?

I too experienced this issue after previously using it without issues.  I am using the Firefox add-on.
Initially, the issue appeared to be CORS (which previously was not a problem, despite not changing anything on my end).  Upon changing my CORS configuration, the problem is now that the Altair client is not sending the cookies necessary for my authentication setup.  Again, previously this all worked perfectly.

Same issue on latest Chrome build and Altair extension as well.

https://www.chromium.org/Home/chromium-security/extension-content-script-fetches

TLDR - The chromium team are making changes to the way extensions work with cross origin requests. I'll need to update the extension to work with this new standard.

TLDR - The chromium team are making changes to the way extensions work with cross origin requests. I'll need to update the extension to work with this new standard.

However, that doesn't explain why Firefox is also having the same issue.

I removed some open ended permissions from the browser extensions, in an attempt to better conform to the policies the browser agents are incorporating (like the one in the link I shared). The permission about access to all sites is what allowed the extension to work without CORS for any site before the update.
I would add the permission back for now, but unfortunately the direction the browser agents are going for extensions would require having these web limitations in the browser extensions as well.
I have written about the limitations of the web app previously (https://sirmuel.design/altair-graphql-web-app-limitations-b671a0a460b8) and it might happen that the extensions would have these limitations within the year, so the recommendation of using the desktop apps if possible still stands.

Correct me if I'm wrong, but this means there is no longer a method of using Altair with cookies, right?  Therefore, if your authentication technique relies on cookies, not just headers, there is no way to use Altair.

You could always specify cookies in the desktop apps. The limitations of the browsers don't affect the desktop apps in the same way.

In the meantime (at v2.4.3), you would still be able to use the cookie based authentications in the browser extensions as before, until anything changes from the chromium team.

v2.4.3 fixes the issue.  Thank you!


My dad left

😠This 😠made 😠my 😠dad 😠not 😳cum😳  😠back 😠from 😠the 😠milk 😠bar

still not back


Propose upgrading client to Beta [skip ci].

All the bugs for the milestone are closed.
/cc: @jabubake @billyjacobson @jefesaurus.

LGTM from me as well!!!!!


feat: event storage using firestore

What changed? Why?

[x] implemented event storage using firestore
[x] add integration tests

How did you test the change?

[x] unit test
[x] integration test
[x] functional test
[ ] adhoc test (described below)

I have no idea why firestore automatically create index for every field including nested, disabling it definitely improve write performance and reduce storage size. 500 is the batch write limit, not the system bandwidth.


change(test): Create test harness for calling getblocktemplate in proposal mode, but don't use it yet

Motivation
We want to use getblocktemplate in proposal mode in the acceptance test to check that it's producing valid templates.
Solution

Add proposal_block_from_template fn for making a block proposal from GetBlockTemplate data
Add a test harness for calling getblocktemplate in proposal mode with the hex-encoded block proposal data, but don't use it yet

Review
Anyone can review.
Reviewer Checklist

[x] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[x] Are the PR labels correct?
[x] Does the code do what the ticket and PR says?

[x] Does it change concurrent code, unsafe code, or consensus rules?

[x] How do you know it works? Does it have tests?

Thanks for this, having tests makes the other PR easier to review. Would you mind rebasing this one as well?

supersedes #5803.

I'm not sure if this PR entirely covers the tests in ticket #5803. Or do we have another ticket for testing that Zebra actually works for mining pools?
(We can do that ticket after we've finished the other RPCs that mining pools need, but it's still a test we need to do.)

Thanks for this, having tests makes the other PR easier to review. Would you mind rebasing this one as well?

supersedes #5803.

I'm not sure if this PR entirely covers the tests in ticket #5803. Or do we have another ticket for testing that Zebra actually works for mining pools?
(We can do that ticket after we've finished the other RPCs that mining pools need, but it's still a test we need to do.)

We have https://github.com/ZcashFoundation/zebra/issues/5304.

Thanks for this, having tests makes the other PR easier to review. Would you mind rebasing this one as well?

supersedes #5803.

I'm not sure if this PR entirely covers the tests in ticket #5803. Or do we have another ticket for testing that Zebra actually works for mining pools?
(We can do that ticket after we've finished the other RPCs that mining pools need, but it's still a test we need to do.)

We have #5304, I think #5803 was supposed to be a manual version of this with the zcashd block proposal (see discussion #5804).

Yep, CI is very different from a once-off test. I've updated the ticket name to make that clearer.

I'm probably going to review this PR after PR #5870 gets updated, and those changes are applied here. (I think I just did my final big review on #5870.)
I also tweaked the PR description to put the "depends on" field in the mergify format:
Depends-On: #5870

https://docs.mergify.com/actions/merge/#queue-depends-on

I'm going to merge in the latest main branch so I can work off this PR, feel free to rebase or overwrite the merge if that works better for you!

@mergifyio update

I think that running this new test in CI is blocked on fixing the merkle tree bug in the getblocktemplate RPC.

This PR can't merge for now:

I don't think we should do this in CI until we can confirm it manually

https://github.com/ZcashFoundation/zebra/issues/5685#issuecomment-1381915157

This PR can't merge for now:

I don't think we should do this in CI until we can confirm it manually

#5685 (comment)

I unblocked this PR by disabling the test for now, and updating the PR description.
So we're ok to merge the test harness, and all the PRs that depend on it, because it doesn't actually change CI yet.

I can't work out how to stop it closing issue #5685 though!

Failed due to a GitHub runner network or setup issue in the merge queue:
https://github.com/ZcashFoundation/zebra/actions/runs/3934132575

@mergifyio refresh


Updated denon component to play nice with the 3808CI that doesn't sup…

…port NSFRN command
Description:
Related issue (if applicable): fixes #8884
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @randellhodges,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!