Patch/read hdf5

Updates:

Read and average embeddings into hidden dim in parallel
Read codon level embeddings (no average) in parallel

Do we want to add optional support for reading the md5sums as well? I needed this for another application. We could return a dictionary from the process_fn’s of the form {“embeddings”: embeddings, “md5sums”: na_hashes} where the embeddings are either averaged or full depending on the process_fn and md5sums is only read from the h5 and returned if a Boolean argument is set to true. We could set the Boolean argument in the partial function definition like return_md5sums=True (this would be user specified).

smart, I can work on that. MD5 sums are good to have (and have had others ask for this as well)


Various fixes and improvements

Do not merge until backend pull request (https://github.com/pennlabs/clubs-backend/pull/6) has been merged!
Fixes

Fix all Javascript errors that occur in console

Need to use Next.js Head tag instead of normal head tag
When using map with React components, need to ensure that the key attribute is uniquely set
Use the className attribute instead of class for CSS classes added to React components
CLUBS_PURPLE was used but commented out

Fix favorite heart icon alignment in card view
Remove old debugging console log statements
Refactor template inheritance system

renderPage handles header/footer/login information
renderListPage does what renderPage used to do

Major Feature Improvements

Implement club creation/editing forms
Finish implementing auth flow (login, profile page, logout)
Implement server side favorites system

Individual club page displays number of favorites
Uses localStorage fallback if not logged in
We should encourage logins to get more information about club popularity and so that users have favorites synced between computers

Implement rich text for club descriptions

Minor Feature Improvements

Add linting and circleci config

No unit tests yet

Add unified method to retrieve default club image URL
Add larger click area for logo/title, dropdown titles, and checkboxes
Increase tag font sizes to increase readability
Lossless compression of PNG images
Add favicon
Update yarn dependencies

TODO

A bug still exists where hitting "Clear All" does not uncheck any of the checkboxes and forces them into an inconsistent state
The frontend for deactivating a club was created but no backend exists for that
There is a privacy/notifications settings box with no content
There are currently no links to the create club page and no permissions (any authenticated user can create)
Write unit tests

Going to merge this before it becomes too large.


Where has defaultEasingFunction gone?

I just upgraded to v3. It works great with rc6. However, typescript started complaining that:
Property 'defaultEasingFunction' does not exist on type 'typeof PageScrollConfig'.

I've looked into the src config file and indeed, there doesn't seem to be a a defaultEasingFunction config class property. The README still mentions it though

Hi,
looks like I definitely overlooked that one. It has been renamed to defaultEasingLogic, as the object type has changed as well.
I just updated the Readme

Thank you @Nolanus !! So quick!! Working like a charm


Getting the foreground mask from each pixel

First, Thanks for your great work!
In paper page 4, "the M() is the foreground mask acquired by integrating the volume density along the ray of each pixel.", How could calulate the density in pixel?
For example, the naive NeRF gets density (sigma) from 3d coord query. Then just add them in all samples in ray and normalize?
Thanks.

https://github.com/guochengqian/Magic123/blob/7f051875e48988dc624b2bd8425aea370c093588/nerf/renderer.py#L1073


CR: TypeError: data is undefined

TypeError: data is undefined
Affects two pdfs:
http://downloads.globalchange.gov/usimpacts/pdfs/climate-impacts-report.pdf
http://www.energysavers.gov/pdfs/energy_savers.pdf
http://people.mozilla.com/~bdahl/corpusreport/test/ref/compare.html#climate-impacts-report_d5d4fb5c5eeffbd4a7f856c3e26ed487
http://people.mozilla.com/~bdahl/corpusreport/test/ref/compare.html#energy_savers_a41bcbe213f639fe027c1f713adf5bd8
Part of the corpus report issues: #881

Might be the same problem #704.

I try to look at #704 and check back, if it's really the same.

@jviereck It looks like the same issue. Its when we have a non-native jpeg with a native jpeg soft mask.  There's an easy fix of just using the jpg.js code to decode it but its not optimal.  Either it will all have to be done in the main thread or we may have to decode in the main thread and send the data back for the soft mask.

@brendandahl I tried to understand what's going wrong here, but I can't really understand it. It seems like you already have an idea, how to fix it. Can you give me some more pointers what needs to get fixed or take this on up on your own?

@jviereck I can work on it.  I've noticed a few more issues since I started looking at it too.  If you're curious the easy fix is just add
this.bytes = bytes;
to the constructor of JpegStream so jpg.js can decode the image.

@brendandahl, thanks for that pointer! That made it :) I have something working now, but some images only render some pixels in height from the top and the rest is missing. Will take a closer look at it later.
You can find the current code here: https://github.com/jviereck/pdf.js/commit/97349cc158e2629a95598e9c3dcc980f56c99898


Fixes 2537: Improve 'status' to handle cases when the checkpoint API is not available

weave status now prints:
failed to check latest version - see logs

when the checkpoint API is not available.
Periodicity of the checks is left unchanged.
Smoke tests based on iptables rules added to reproduce the failure.

Fixes 2537.


Adding the Environment Tag Helper

Adds the Environment Tag Helper (#1553). This is not a design review, for comment or otherwise. I repeat, this is not a drill! Please review.
I added the Tag Helper related projects to the Mvc.NoFun.sln as part of this because it makes Tag Helper people super happy devs.

Review pls @NTaylorMullen @dougbu @yishaigalatzer

:watch:

:watch:

:shipit:

:shipit: after at least wrapping the 2 (I think) long lines, squashing commits, and reverting the leftover file

OK this is good to go once the dev branch is safe for RC commits.

Merged in 759fbbd661fe4f8d51203fd8b521e72f3f63e96d


EID-1105: Reverted code for trust anchor signing code, and updated to the latest library code.

Why are we reverting this code? As in - does the current version of the trust anchor library (without this revert) work as expected?


Make it clear where code snippets go

Perhaps I'm spoiled by Treehouse, but the TOH tutorial is extremely frustrating in that code snippets are shown all by themselves without any context as to where they go in the file. For a newbie this is maddening and adds unnecessary frustration to the already increasingly complex amount of material. I've found it to be so in prior parts but Part 4 (https://angular.io/docs/ts/latest/tutorial/toh-pt4.html) is the worst so far. I hate to be forced to "cheat" and look at the code files at the end of the chapter.

I am super curious to see what does Treehouse provide that you are missing here. Any opportunity to improve is always good.

@Foxandxss :
Same suggestion & possibly either typo or a bug report ...
Most snippets include sufficient "landmarks" to orient you & help place the relevant code properly (e.g. it shows the export class line immediately above/below/surrounding the snippet) , other times not.
Also, while most of the tutorial is very clear & detailed, sometimes steps are ambiguous or unclear.
Ex: Section 5. Services
The example above (https://angular.io/docs/ts/latest/tutorial/toh-pt4.html) in particular says:

In app.component.ts, where you cut the HEROES array, add an uninitialized heroes property:

This is not accurate, because "where you cut the HEROES array" was above outside the class declaration. You need to put the new property below inside the class declaration.
Right file, unclear location, and perhaps not an obvious instruction for people new to OOP/Typescript.
Also, this link still says "pt4," but it's now "pt5."
Ex: Section 6. Routing
Begins with Configure Routes

Create a configuration file for the app routes...
Define the first route as a route to the heroes component: //Route Code Snippet

Is this a NEW file?? It says to do this in src/app/app.module.ts.
Where is the RouteModule.forRoot() code in the 1st example actually supposed to go?
Then Make the router available:
In the next lines you do the exact same work to import the RouteModule again, and add the exact same code to the imports array, again in app.module.ts, the same file.
So do you put this code in 2 places as stated, or just 1?
I kept getting different errors despite replicating the example - eventually it just worked.
This particular functionality gets refactored shortly thereafter anyway, so it's not critical.
But this is supposed to be the introduction to routing, and it is rather confusing.
https://angular.io/tutorial/toh-pt5#configure-routes
Thanks~

@mccumb01 I would love you open a new issue with that information at angular/angular so we don't forget about it :)


Add QT_PLUGIN_PATH to AppRun file

First I want to say major thanks for this tool, it's perfect for novices like me who want to quickly create AppImages. 🙏
Second I would like to suggest that this line gets added to generated AppRun files:
export QT_PLUGIN_PATH="${HERE}"/usr/lib/qt5/plugins

This seems to be an easy fix for Qt5 applications to work, as otherwise they throw an error about missing plugins and refuse to start. One example is mGBA which I just packaged today using this fix.
Cheers.

Sorry for the delay in answer, but i added this on commit https://github.com/sudo-give-me-coffee/make-portable/commit/291b0dc24b1528fb7d38dd749c742315cd483115


sync: on-demand sync missing exclude files capability

Is your feature request related to a problem?
No
Which solution do you suggest?
If it will be possible, extend on-demand devspace sync cli cmd with the missing capabilities that already present in yaml declared sync for dev (https://devspace.cloud/docs/cli/configuration/reference#devsync) like:

excludePaths
downloadExcludePaths
uploadExcludePaths

Which alternative solutions exist?
Run sync via devspace dev spin up procedure.
Additional context

/kind feature

@dsuievalov thanks for opening this issue! We currently have a flag in devspace sync for  excludePaths, its --exclude, is that not sufficient?

@FabianKramm Have rechecked our workflow and I think we will be satisfied with  --exclude argument. Sorry for opening and issue instead of clarifying with devspace sync cmd.


Replace default method calls from Glam types with explicit const

it's a followup of #1550
I think calling explicit methods/values instead of default makes the code easier to read: "what is Quat::default()" vs "Oh, it's Quat::IDENTITY"
Transform::identity() and GlobalTransform::identity() can also be consts and I replaced the calls to their default() impl with identity()

Good calls all around. Thanks!

bors r+


"Expand Editor" button icon seems to have disappeared

The "Expand Editor" button seems to have disappeared, but works once clicked.
Grafana Cloud version: Grafana v11.1.0-70724 (89f6845739)
Google BigQuery plugin (grafana-bigquery-datasource): version 1.2.7
note: the bug still seems to occur on Google BigQuery plugin version 1.6.1

in grafana11.0.0 it is still correct.
but in grafana-main-branch it is not.

fixed in https://github.com/grafana/google-bigquery-datasource/pull/261


Dockerfile Build Error http.Client Timeout

On building with the Dockerfile I'm getting an error message:
github.com/QubitProducts/bamboo
./bamboo.go:185: client.Timeout undefined (type *http.Client has no field or method Timeout)
Scott

Is this with master? The recent event streaming feature sets client.Timeout, so we may need to up the minimum Go version.

Yes

Just a git clone https://github.com/QubitProducts/bamboo.git

Hit this issue too.

me too

+1 ran into this issue as well when following the readme instructions for performing a Docker build. Whats the fix for this ?

Timeout was added to http.Client in Go 1.3, wasn't it?

Looks like an issue with go lang version 1.2 in ubuntu:14.04.  So change ubuntu:14.04 in the dockerfile FROM to ubuntu:15.10 and call it a day.

I changed "FROM to ubuntu:15.10 " and now get pas the above error, but now have
Step 8 : RUN gem install fpm
 ---> Running in 0ac84ad6abf2
/bin/sh: 1: gem: not found
The command '/bin/sh -c gem install fpm' returned a non-zero code: 127

The fix for that was to add "RUN apt-get install -yqq gem ruby"

Also if you want to stay with ubuntu TLS which is not a bad idea in production.  You can also just upgrade go from 1.2 to at least 1.3.  Boran that might help if you don't find an easy resolution to ruby.


[wip] feat: add speed profiling to client build

In my quest for speeding up webpack builds, I find it useful to add a plugin that can trace it. Due to the nature of said plugin, one cannot easily attach it as a user but would need to wrap the generated config. This PR does exactly that as opt-in.
This is work in progress (docs and options missing), but I would appreciate it to be considered.
Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Add plugin to client config.
Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #6712 into dev will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##              dev    #6712      +/-   ##
==========================================
- Coverage   95.79%   95.72%   -0.07%
==========================================
  Files          78       78
  Lines        2713     2716       +3
  Branches      702      703       +1
==========================================
+ Hits         2599     2600       +1
- Misses         99      101       +2
  Partials       15       15

Flag
Coverage Δ

#e2e
100% <ø> (ø)
:arrow_up:

#fixtures
64.61% <33.33%> (-0.04%)
:arrow_down:

#unit
92.23% <33.33%> (-0.07%)
:arrow_down:

Impacted Files
Coverage Δ

packages/webpack/src/config/client.js
94.64% <33.33%> (-3.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc962f...791675e. Read the comment docs.

Hi, thanks for this request. Indeed it can be supported simply with a module. Also, we already have advanced profiling support from webpackbar. Simply use --profile or build.profile: true.
Docs: https://nuxtjs.org/api/configuration-build/#profile
Results:

@pi0 thanks. Missed that one


Send Confirmation Bottom Sheet: Display statistics for all recipients

-Verified this issue on dev app v1.5.0(245)


Add OSGi bundle configuration to pom so that Spark will build as a bundle.

This supersedes pull request #121 (mine) which was conflicted. I resolved the conflict, but overly polluted the history, so here's a clean pull request.
This also supersedes pull request #164 (not mine) which had exactly the same changes and is now also conflicted.
As discussed previously, the only effect of this change is to add OSGi metadata into MANIFEST.MF, allowing the Spark jar to be seen as a bundle by any OSGi container. This change has absolutely no effect on anything other than the generated MANIFEST.MF file.

:+1:


[iOS]  fix: Show livebadge only on live

Issue

N/A

Overview (Required)

Show Livebadge only on live.

I just judge whether the talk session is on live or not by the value of session.isOnGoing.
Links

@KaoruMuta This PR can review now?

@ry-itto
Sorry for late reply.
It seemed that it was conflicted, and I resolved the conflict.
So, this PR can be reviewed now.

I'm relieved, thanks!

Sorry, I find a really minor problem in my scripts.
As usual, the indentation is a tab, but in case it's a space.
Do you think it should be resolved? If you agree, I'm going to resolve.

I'm sorry... I missed. Please fix it 🙏


Full support for entering and exiting DORMANT mode

I noticed that there were the beginnings of some support for the RP2040 dormant lowest-power sleep but that several loose ends remained.
I've taken care not to make any breaking changes in this pull request to maximise its prospects. However, I think an interesting future change would be to add an addiitional pll::State to represent a powered down PLL. This would streamline the process of restarting the PLLs following dormancy.
Looking forward to your feedback and hopefully an approved pull request. I'm keen to hear of any areas that don't meet rp-rs standards or where I've done something that isn't idiomatic - apologies in advance for any crimes against these!
Andrew

Thanks @ithinuel, that's a good suggestion. I've replaced the XOSC Initialized and Dormant states with an Unstable state. And ROSC no longer changes state on after waking.
I'm not convinced of the benefit of adding StableOscillatorTokenAlreadyIssuedError however: it seems overly picky to return that error given we can only redeem the token once via get_stable(), regardless of how many times we request a token. Am I missing something here?

Hi @ithinuel, is there anything I can do to help progress this PR?

I never used the dormant state and didn't think about it enough to decide if these changes are sufficient to make dormant mode usable. From reading the diffs I get the impression that the changes make sense, and I don't see anything obviously wrong. @ithinuel, as you already worked on your own implementation of dormant support, you are probably more qualified to review this merge request. But if you don't have time to do a review, I could plug together some test setup on a breadboard to try out the example, and approve the PR if everything works as expected.
@andrewh42, you wrote that you avoided breaking changes to make merging easier. As the next release probably will include breaking changes anyway, are there any improvements you'd want to add?

@andrewh42, you wrote that you avoided breaking changes to make merging easier. As the next release probably will include breaking changes anyway, are there any improvements you'd want to add?

Thanks for asking @jannic. I was thinking it could be useful to add an addiitional pll::State to represent a powered down PLL. At present the PLL's disable() reconstructs the Disabled state by reading the PLL's registers, so that initialize() can be used to restart the disabled PLL. The alternative I have in mind is to replace disable() with, say, stop() and return a new Stopped state that  then requires less work to restart. initialize() might then return a Stopped PLL, in order to keep the code DRY. Giving us the following state transitions when starting up:
Disabled -> Stopped -> Locking -> Locked

And these transitions when stopping and then restarting (e.g. as part of going dormant):
Locked -> Stopped -> Locking -> Locked

Does that sound reasonable? Either way, I'd prefer to do this in a separate PR so this one doesn't stick around for too long and gather more complexity. Does that sound OK?

Hi @ithinuel and @jannic, is there anything I can do to help complete this PR?

Sorry for not answering sooner. Currently, my focus is on getting 0.10.0 out the door, so I neglected some older pull requests.
Currently, there are some merge conflicts. Could you try to resolve them?

Hi @ithinuel and @jannic, is there anything I can do to help complete this PR?

Sorry for not answering sooner. Currently, my focus is on getting 0.10.0 out the door, so I neglected some older pull requests.
Currently, there are some merge conflicts. Could you try to resolve them?

No worries, done.

BTW I also verified that the dormant mode actually makes a difference. Even with a cheap USB power meter, I see 0.02A in wfi mode, while in dormant mode, it shows 0.00A. The absolute numbers might be very inaccurate, but it's obvious that the dormant mode is different from the wfi sleep.

I'm happy with this. We can always come back later to this if we need to make improvements.
I have a ppk2 at home so I could take some samples and post screenshots here.


Implement Dockerfile and CI/CD to DockerHub

This PR adds a Dockerfile to clairvoyance with the following considerations:

Adds deterministic base images for reproducible builds.
Adds a multi-stage build that keeps the image size at about 60MB in size.
Adds a least-privileged user in compliance with Docker security best practices.

We also have a workflow with a CICD pipeline to DockerHub. All you need to do is to add the DOCKER_HUB_USERNAME and DOCKER_HUB_ACCESS_TOKEN secrets to the repository and all pushes/merges to the master branch will automatically push an image to DockerHub.
This is a nice tool but I needed to run it from a Docker container, so here is my contribution. If you merge I'll go ahead later and add a few installation instructions for Docker to the README.md file.

This is a cool feature! Thank you very much 😃
I've just changed an event that triggers a publishes an image to Docker Hub at 928ee90 so it publishes an image only if tests finished successfully.

The image should be pullable from https://hub.docker.com/r/nikitastupin/clairvoyance

Great! I'll add some simple instructions on how to use it with Docker to the README.md file and do a new PR.


Feat:Add indian writers

Describe the feature
Feat:Add indian writers and add options to navbar
Add ScreenShots
Feat:Add indian writers and add options to navbar
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

openleaflet

thank you mam


uncaughtException: invalid large-object descriptor

I get an uncaughtException when trying to access more than one large object at once.
The app I'm writing is a webservice that's storing larg files into Postgres, then retrieved via secure URLs. The problem is that a browser may request content in parallel, and many browsers can do as well. But, to fix this issue, I'd need to build a queue system. However, is there any way to fix this on this module's end?
error: uncaughtException: invalid large-object descriptor: 1
   [ 'Error: invalid large-object descriptor: 1',
     '    at Connection.parseE (/home/xxxxx/dev/vitex/node_modules/pg.js/lib/connection.js:534:11)',
     '    at Connection.parseMessage (/home/xxxxx/dev/vitex/node_modules/pg.js/lib/connection.js:361:17)',
     '    at Socket.<anonymous> (/home/xxxxx/dev/vitex/node_modules/pg.js/lib/connection.js:105:22)',
     '    at Socket.EventEmitter.emit (events.js:107:17)',
     '    at readableAddChunk (_stream_readable.js:159:16)',
     '    at Socket.Readable.push (_stream_readable.js:126:10)',
     '    at TCP.onread (net.js:514:20)' ] }

I have not seen this error before. Are you sure that you are using a transaction, even when reading a large object?  The open, read and close must all be within the same transaction (this is a limitation of postgres).
Note that pg-large-object does not create a transaction for you in any of its methods.
I use this to serve files using express & sequelize. I just did a load test using ab -c 100 -n 100 http://localhost:1337/foo/bar and I never saw that error (-c is for concurrent connections).

The app is using co and koa.js to serve files, and perhaps this the main difference. This is the code I have (it works) :
var locks = [];

var suspend = require('co-suspend');
var LargeObjectManager = require('pg-large-object').LargeObjectManager;
var Connections = require('beyo-model-mapper').Connections;

function * getStream(oid) {
  var marker = suspend();
  var adapter = yield Connections.get(options.adapter);
  var lo = new LargeObjectManager(adapter);

  if (locks.locked) {
    locks.push(marker);
    yield marker.wait();
  }

  locks.locked = true;

  // When working with Large Objects, always use a transaction
  adapter.query('BEGIN', function(err, result) {
    if (err) {
      marker.resume(err);
    } else {
      lo.openAndReadableStream(oid, BUFFER_SIZE, function(err, size, stream) {
        if (err) {
          marker.resume(err);
        } else {
          stream.on('end', function() {
            adapter.query('COMMIT');

            locks.locked = false;

            if (locks.length) {
              locks.pop().resume();
            }
          });

          marker.resume(null, stream);
        }
      });
    }
  });

  return yield marker.wait();
};

I sometimes forget that not everyone works with yieldables :)
But, also this same problem will occur if you ever switch to a Promise/A+ base API.

The unit tests in this repository are all done using promises ;)
Although nowadays I use bluebird instead of q.
var Promise = require('bluebird');
var LargeObjectManager = require('pg-large-object').LargeObjectManager;
Promise.promisifyAll(LargeObjectManager.prototype); // adds *Async methods

return sequelize.transaction(function (transaction)
{
    var man = new LargeObjectManager(transaction.connection);
    return man.openAsync(123).then(function(obj)
    {
        return [obj, obj.sizeAsync()];
    }).spread(function(obj, size)
    {
        console.log('size is', size);
        return obj.closeAsync();
    });
});

I do not really get around using ES6 yeild because browser support is lagging.


Please publish in Maven Central

Is your feature request related to a problem? Please describe.
Please publish in Maven Central

i requested access to OSSRH: https://issues.sonatype.org/browse/OSSRH-94772

Todos:

OSSRH requires Javadocs:Missing: no javadoc jar found in folder '/de/darkatra/feign-aws-sigv4-sdkv2/2.0.16'
Missing: no javadoc jar found in folder '/de/darkatra/feign-aws-sigv4-sdkv1/2.0.16'
Missing: no javadoc jar found in folder '/de/darkatra/feign-aws-sigv4-common/2.0.16'

OSSRH requires Name, Description and Url in top level pom:Invalid POM: /de/darkatra/feign-aws-sigv4/2.0.16/feign-aws-sigv4-2.0.16.pom: Project name missing, Project description missing, Project URL missing

OSSRH requires GPG signing (https://central.sonatype.org/publish/requirements/gpg/):Missing  Signature:  '/de/darkatra/feign-aws-sigv4-sdkv2/2.0.16/feign-aws-sigv4-sdkv2-2.0.16.pom.asc'  does not exist for 'feign-aws-sigv4-sdkv2-2.0.16.pom'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-sdkv2/2.0.16/feign-aws-sigv4-sdkv2-2.0.16-sources.jar.asc'  does not exist for 'feign-aws-sigv4-sdkv2-2.0.16-sources.jar'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-sdkv2/2.0.16/feign-aws-sigv4-sdkv2-2.0.16.jar.asc'  does not exist for 'feign-aws-sigv4-sdkv2-2.0.16.jar'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4/2.0.16/feign-aws-sigv4-2.0.16.pom.asc'  does not exist for 'feign-aws-sigv4-2.0.16.pom'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-sdkv1/2.0.16/feign-aws-sigv4-sdkv1-2.0.16.jar.asc'  does not exist for 'feign-aws-sigv4-sdkv1-2.0.16.jar'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-sdkv1/2.0.16/feign-aws-sigv4-sdkv1-2.0.16-sources.jar.asc'  does not exist for 'feign-aws-sigv4-sdkv1-2.0.16-sources.jar'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-sdkv1/2.0.16/feign-aws-sigv4-sdkv1-2.0.16.pom.asc'  does not exist for 'feign-aws-sigv4-sdkv1-2.0.16.pom'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-common/2.0.16/feign-aws-sigv4-common-2.0.16-sources.jar.asc'  does not exist for 'feign-aws-sigv4-common-2.0.16-sources.jar'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-common/2.0.16/feign-aws-sigv4-common-2.0.16.jar.asc'  does not exist for 'feign-aws-sigv4-common-2.0.16.jar'.
Missing  Signature:  '/de/darkatra/feign-aws-sigv4-common/2.0.16/feign-aws-sigv4-common-2.0.16.pom.asc'  does not exist for 'feign-aws-sigv4-common-2.0.16.pom'.


I have now tried to build a built-in display successfully.

Before opening the issue, have you...?

[X] Searched for existing issues

Question
I have now tried to build a built-in display successfully.
At the same time, the brightness slider of the display is called out.
https://bbs.pcbeta.com/viewthread-1947168-1-1.html
After using the software, you can control the brightness slider of the built-in display, but the backlight will not change. Can you improve the software to support the DDC dimming of the built-in display.
You can try the linked scheme to make improvements. If it can be realized, ordinary displays will be perfect.

Hi there, sorry for responding so late. It depends on how did you build the built-in display and what control board it uses and whether the board supports DDC or not (sometimes it's just a matter of a firmware setting). Without the details it's a bit difficult to answer to this.


Fix failing test cases, improve coverage

The Header.test.js is failing.
I'm planning to fix the failing tests and add the below test cases

Click login button and expect the useGoogleLogin function to be called
Click logout button and expect the localStorage.removeItem("accessToken") to be called

Please assign this issue to me if its valid.

Go ahead

Thanks, please let me know if you have any file that needs test cases on priority. I will work on them after this.

You can go ahead and test the functionality mentioned above since it's a small-sized app. I'd like to provide opportunities to other developers as well. If you come across any issues during your analysis, please create them. This would be helpful for me to assign tasks to other developers. Thank you for your contribution.


[$1000] When you triple tap on a message and copy it then it also copies emojis from context menu

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Go to any chat
Triple tap a message & copy it
You'll notice that extra emojis have been copied along with the message

Expected Result:
message is copied
Actual Result:
Extra emojis along with the message gets copied
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.81-1
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/224204200-20091953-d000-44d3-9667-e58b40a9f03c.mp4
https://user-images.githubusercontent.com/43996225/224204222-f50d5c31-d131-483e-9650-d0309fd8c0e0.mov
Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678358066038339
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0136ad60bd0af53825
Upwork Job ID:<PHONE_NUMBER>095542784
Last Price Increase: 2023-03-10

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

i can reproduce this:
https://user-images.githubusercontent.com/38016013/224371829-06483346-3686-43f5-964c-d93a843b2e95.mp4

not a dupe - https://expensify.slack.com/archives/C049HHMV9SM/p1678397732479089

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

looking for a buddy check to confirm if this should be an internal or external issue. lmk!

External is fine :)

Job added to Upwork: https://www.upwork.com/jobs/~0136ad60bd0af53825

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Current assignee @Beamanator is eligible for the External assigner, not assigning anyone new.

📣 @Alpha-T30! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Proposal
Please re-state the problem that we are trying to solve in this issue.
Triple-click selection selects text that should be unselectable.
What is the root cause of that problem?
The SelectionScraper selects any text without taking into consideration if it's supposed to be selectable. This is not necessary a bug in the SelectionScraper as that's the default behaviour of the Selection API.
What changes do you think we should make in order to solve the problem?
Explicitly check the if captured text is supposed to be unselectable and if so ignore it. This can be achieved by extending the condition here and as pseudo code that would be:
if dom type is a text that should be unselectable
    set data to empty string
else
    set data as we normally do
endif

data is what we end up coping
text is considered unselectable if it's parent's style has user-select: none;
What alternative solutions did you explore? (Optional)

Avoid the issue by moving the mini context menu to be rendered outside the hierarchy of chat messages e.g. createPortal

Proposal
Please re-state the problem that we are trying to solve in this issue.
Triple-click selection selects text that should be unselectable.
What is the root cause of that problem?
The SelectionScraper selects any text without taking into consideration if it's supposed to be selectable. This is not necessary a bug in the SelectionScraper as that's the default behaviour of the Selection API.
What changes do you think we should make in order to solve the problem?
Explicitly check the if captured text is supposed to be unselectable and if so ignore it. This can be achieved by extending the condition here and as pseudo code that would be:
if dom type is a text that should be unselectable
    set data to empty string
else
    set data as we normally do
endif

data is what we end up coping text is considered unselectable if it's parent's style has user-select: none;
What alternative solutions did you explore? (Optional)

Avoid the issue by moving the mini context menu to be rendered outside the hierarchy of chat messages e.g. createPortal

@s77rt Is the approach you mentioned above following the same idea as listed here?
Also, do you agree that we're trying to solve the same problem in this issue as well?

@allroundexperts Ah yeah nice catch! Not exactly the same idea (not the same place where to apply the fix) but in general yes about the same. We can fix both issues with the same fix!

I did some research on this when proposing for this issue. We can't / shouldn't use portals because the same behaviour exists for the reaction icons that appear in the next row (once the user has reacted on something). Of course, that is not something that should be placed outside of the component hierarchy.
Also, if dom type is a text that should be unselectable would be sort of inefficient because we'll have to rely on getComputedStyles method on each child in order to check if user-select is false. I think a better approach might be to use some sort of data-id which if present will be ignored from selection.
Lastly, we can also convert our emoji's to be images instead of text. This will solve the problem as well (Slack uses images instead of text).

Thanks for the info @allroundexperts.

I agree with you here, using portals is not a universal solution, so the main solution should be the way to go.
getComputedStyles won't be used, I have sent you the implementation details in Slack.
There was/is a plan to use images for emojis but that's not in the near future besides this is also not a universal solution.

The results look promising :eyes:
https://user-images.githubusercontent.com/16493223/224516571-a2ba685d-55af-4317-8f75-5394580ce38c.mp4

Let's pause (non-proposal) comments here not to flood the GH until things get cleared up :+1:

Proposal
My proposal https://github.com/Expensify/App/issues/15194#issuecomment-1465221995 for the issue https://github.com/Expensify/App/issues/15194 will also fix this one. Please check there for the details (it already follows the proposal template).

@Beamanator - will you take a peek at these proposals when you have a chance and let us know how we should move forward? thank you!

Ooh I've been waiting for @eVoloshchak to start reviewing - @eVoloshchak are you free to review these proposals soon?

@Beamanator, yeah, I'm looking at them right now, will post a review in a couple hours

This is essentially a duplicate of https://github.com/Expensify/App/issues/15194, all proposals above are applicable for that issue and vice versa
@s77rt is  correct here about the root cause:

The SelectionScraper selects any text without taking into consideration if it's supposed to be selectable.

Proposal (the general approach) was discussed in   https://github.com/Expensify/App/issues/15194, I agree we should avoid selection manipulation
@tienifr's proposal looks very promising, but an argument could be made that it's a workaround, since we're adding a pseudo-element to avoid browser's default behavior.
So the question is: is browser's default behavior (i.e. SelectionScraper selecting all of the text) expected behavior or a bug?

I still think we should hold this for https://github.com/Expensify/App/issues/15194, it's older and there is a lot more discussion. They're essentially the same, so they both will be fixed by a single proposal

noted! thanks for pointing that out @eVoloshchak.
do you think we're good to close out this particular issue in favor of https://github.com/Expensify/App/issues/15194?

changing to weekly while we wait for the other PR to merge.

still holding!

Still on hold

still on hold - switching to monthly until its off hold


seed data

I am working in the process of creating seed data for all models.

[ ] Categories and Sub-Categories
[ ] Posts
[ ] Users
[ ] Chat and Messages
[ ]


Release for Kibana 6.8

Hi @fbaligand ,
as the version 6.8 of Kibana was released, is there any plan to make a new release of the kibana-enhanced-table plugin?
Thanks in advance!

Hi @ch-bas,
I just published enhanced-table plugin v1.2.0 for Kibana 6.8.0 and Kibana 7.1.0 here :
https://github.com/fbaligand/kibana-enhanced-table/releases/download/v1.2.0/enhanced-table-1.2.0_6.8.0.zip
https://github.com/fbaligand/kibana-enhanced-table/releases/download/v1.2.0/enhanced-table-1.2.0_7.1.0.zip


Revert "[Android] Add method to config XWalkView render backend"

This patch will case application crash when using XWalkActivity,
revert it temporarily for a better solution.
This reverts commit f8cb0458c9a59cc5658fd0907a9887ba1ecb9978.

@axinging @halton @lincsoon

Our bots look fine, I thought the tests there would be crashing according to the description. Do you have more information about what's going on? Is a fix difficult?

@rakuco yes, if the MainActivity of the test application extends  XWalkActivity instead of Activity, the application will crash while launch.
I am still finding the root cause, there is a replacement by using Android meta-data, but we think the current solution is better, so what I mean is to find the fix for the crash.

ok, let's revert then


Using OAuth.io within a Chrome Extension

Hi,
I am currently trying to use OAuth.io (Using the Stackoverflow provider) into a Chrome Extension. Note:

It is a BrowserAction type extension. And the place where I try to get authorisation from the user is the Popup page.
I am using OAuth.io with the standard oauth.js library via the popup method.

It almost go through the entire process but, unfortunately, the window can't send back the token to the opener.
Therefore, the callback in the Javascript code is never called and it's impossible to make further API calls.
I am afraid that there will be no other possibility than using, one way or another, the specific methods provided by Google to send message across windows/tabs. As suggested and documented here:

http://stackoverflow.com/questions/11812786/window-open-returns-undefined-in-chrome-extension
http://developer.chrome.com/extensions/messaging.html

And I am under the impression that this kind of modifications will require commit into oauthd as well as oauth-js.
Can you tell me if there is already existing solutions to avoid this issue? And if not, do you think it would be reasonable work to provide a specific solution in order to develop a Chrome Extension?
Thank you.
Aurélien

Hey, I have a followup question. I'm also trying to use this in a chrome extension, calling te Oauth.popup method from the extensions popup. But I'm getting a {message: "The popup was closed"} error, even though I see "successfully access granted" after clicking a grant button in the loginpopup. It waits for a second, then closes the popup automatically, then I see the error.

Using the newest version.
"externally_connectable" :{"matches": ["https://oauth.io/*"]}
also in permissions

Are there other reasons this could throw the error wrongfully?
Thanks

I'm also having an issue. I'm not seeing anything in the popup, at all; a window pop ups and closes itself without displaying any text inside of it. My console says that r.get isn't working, even though I have jQuery loaded. in the <head> as well. Is there something I am missing?

No longer getting this issue, as of: https://github.com/oauth-io/oauth-js/issues/63.


Not seeing it installable in SBT3

Probably because it's not compatible with Sublime Text 3. I'd love to see compatibility. :)

I cloned the repository to my Sublime Text 3 packages folder and this package worked as expected (on Windows). I think it just needs to be added to packagecontrol.io as instructed here: https://packagecontrol.io/docs/submitting_a_package.
Thank you.

@ramiabughazaleh That's good news! Thanks for trying it out :-)
Do you happen to know the new packagecontrol.io format? I'd be happy to submit. I'm just not ready to spend the time researching it yet to make sure it's installable on both ST2 and ST3.

Just added it to Package Control in https://github.com/wbond/package_control_channel/pull/4465.

It was merged in!
Thanks for opening the issue @ryancastro, and for reminding me about this @ramiabughazaleh.


S5 with FW3.5.7 Room Switch toggle bug

To replicate the issue.

Turn on Room toggle. The Vacuum fan speed value doesn't update.
Get out of HomeKit, come back in. The app will do an "update", and both Vacuum Fan and Room Toggle will be off.
The Fan Speed will sometimes come back with a value, but disappears on / off.

There's no way to tell what Room is being currently cleaned.

Duplicate of #119


Add license and repo fields where they were missing

I had quite a hard time figuring out the license and where the source code for @softarc/native-federation was located since all links I found related to it pointed to its npmjs link. This PR adds those fields to the package.json of all libraries that don't have those fields defined and assumes that all source code in this repo is licensed under the MIT license in the root of the repo.

Closing due to lack of interest/communication.


handlebars: Make our handlebars templates use 4-space indents

I have never understood why our handlebars templates have 2-space indents but our Django templates (mostly) have 4-space templates.  Actually, I do sorta know the reason--I think handlebars comes from a culture where people like 2-space indents--but Zulip uses 4-space indents in most other places.
Some of the old Django templates are a mess and combine 2-space indents with 4-space indents.

I think 4-space is conceptually preferable for consistency, but worry that it might be a mess in practice and make some of the files unreadable, such that we would want to first do a project to reorganize before changing indentation.
I think to decide this we should look through our handlebars templates and see what the deepest indents would be and how that might change.  Maybe easiest to just have a tool re-indent them (we'll want the tool to standardize either way), and look the diff/result to see how bad it is.

There are 123 lines in the handlebars code that are over 110 characters even with the 2-space indents.  They are indented by an average of 11.05 spaces.
You can look at that two ways:

It's so bad now, let's not aggravate it with 4-space indents.
Two-space indents aren't helping much to begin with, as just short of 90% of the line lengths are caused by code.

I look at it the second way.  It's not clear to me why we have to put all the attributes for a single tag on the same line.
Here's the quick code I used to do the analysis.
import glob
import re

cnt = 0
total_indent = 0
for fn in glob.glob('*.handlebars'):
    for line in open(fn):
        m = re.match('( *)(.*)', line)
        indent = m.group(1)
        code = m.group(2).strip()
        if len(indent + code) > 110:
            print indent + code
            cnt += 1
            total_indent += len(indent)

print cnt
print total_indent * 1.0 / cnt

I think we may want to do some pre-factoring of things that will end up looking really bad into their own files before we make a final call here.  I would like to do 4-space indent, but e.g. settings_tab.handlebars has some stuff (e.g. default_language_modal) that is already 26 characters indented, and changing that to 52 seems like a disaster.  Most things like that are highly nested components that should just be broken into their own files, but I don't really want to have the project sitting in a state with them indented >50 characters...

So at least one file, alert_word_settings_item.handlebars, has 4-space indents.

It's really just these three files have 2-space indents and deep nesting:
admin_tab.handlebars
settings_tab.handlebars
single_message.handlebars
I'll create a ticket to clean them up.

#1662 to clean up the three deeply nested handlebars files

#1778 starts to address the automation of cleaning up templates.

@zulipbot claim

@zulipbot Yes i have this in mind.
Its currently not merge conflict safe to push in more cleanup tasks.


incompatible character encodings: UTF-8 and US-ASCII in a Jenkins Pipeline

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Complete output when running fastlane, including the stack trace and command used
I'm trying to integrate my fastlane project in Jenkins 2.51. I'm facing the following issue (either in a fast lane env or using a lane). I'm not facing the issue when running it manually in the project.
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Build and upload to Crashlytics)
[Pipeline] sh
[workspace] Running shell script

export TERM=xterm-256color
TERM=xterm-256color
[Pipeline] sh
[workspace] Running shell script
export LANG=en_US.UTF-8
LANG=en_US.UTF-8
[Pipeline] sh
[workspace] Running shell script
export LANGUAGE=en_US.UTF-8
LANGUAGE=en_US.UTF-8
[Pipeline] sh
[workspace] Running shell script
export LC_ALL=en_US.UTF-8
LC_ALL=en_US.UTF-8
[Pipeline] sh
[workspace] Running shell script
ruby --version
ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]
[Pipeline] sh
[workspace] Running shell script
/usr/local/bin/fastlane env
[14:54:25]: Generating fastlane environment output, this might take a few seconds...

Looking for related GitHub issues on fastlane/fastlane...
➡  character encoding: US-ASCII and UTF-8
https://github.com/fastlane/fastlane/issues/8234 [open] 2 💬
a week ago
➡  fastlane not working after updating ruby.
https://github.com/fastlane/fastlane/issues/8529 [open] 3 💬
2 weeks ago
➡  No value found for 'username' when try to Jenkins Integration with Fastlane. But the lane run successful via SSH.
https://github.com/fastlane/fastlane/issues/4785 [closed] 2 💬
19 Nov 2016
and 2 more at: https://github.com/fastlane/fastlane/search?q=incompatible character encodings: UTF-8 and US-ASCII&type=Issues&utf8=✓
🔗  You can ⌘ + double-click on links to open them directly in your browser.
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/fastlane/lib/fastlane/environment_printer.rb:25:in get': [!] incompatible character encodings: UTF-8 and US-ASCII (Encoding::CompatibilityError) 	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/fastlane/lib/fastlane/environment_printer.rb:4:in output'
from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/fastlane/lib/fastlane/commands_generator.rb:233:in block (2 levels) in run' 	from /usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.4/lib/commander/command.rb:178:in call'
from /usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.4/lib/commander/command.rb:153:in run' 	from /usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.4/lib/commander/runner.rb:476:in run_active_command'
from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:38:in run!' 	from /usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.4/lib/commander/delegates.rb:15:in run!'
from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/fastlane/lib/fastlane/commands_generator.rb:303:in run' 	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/fastlane/lib/fastlane/commands_generator.rb:42:in start'
from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/fastlane/lib/fastlane/cli_tools_distributor.rb:65:in take_off' 	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.23.0/bin/fastlane:20:in <top (required)>'
from /usr/local/bin/fastlane:22:in load' 	from /usr/local/bin/fastlane:22:in '
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: script returned exit code 1
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.3

Ruby
2.2.4

Bundler?
false

Git
git version 2.7.1

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.3 (16D32)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
true

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.23.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

CFPropertyList
2.3.5

activesupport
<IP_ADDRESS>

addressable
2.5.0

babosa
1.0.2

bigdecimal
1.2.6

bundler
1.14.3

claide
1.0.1

cocoapods
1.2.0

cocoapods-core
1.2.0

cocoapods-deintegrate
1.0.1

cocoapods-downloader
1.1.3

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.0.0

cocoapods-trunk
1.1.2

cocoapods-try
1.1.0

colored
1.2

commander
4.4.3

commander-fastlane
4.4.4

domain_name
0.5.20161129

dotenv
2.2.0

escape
0.0.4

excon
0.54.0

faraday
0.11.0

faraday-cookie_jar
0.0.6

faraday_middleware
<IP_ADDRESS>

fastimage
2.0.1

fourflusher
2.0.1

fuzzy_match
2.0.4

gh_inspector
1.0.3

google-api-client
0.9.26

googleauth
0.5.1

highline
1.7.8

http-cookie
1.0.3

httpclient
2.8.3

hurley
0.2

i18n
0.7.0

io-console
0.4.3

json
1.8.1

jwt
1.5.6

libxml-ruby
2.9.0

little-plugger
1.1.4

logging
2.1.0

memoist
0.15.0

mime-types
3.1

mime-types-data
3.2016.0521

mini_magick
4.5.1

minitest
5.4.3

molinillo
0.5.7

multi_json
1.12.1

multi_xml
0.6.0

multipart-post
2.0.0

nanaimo
0.2.3

nap
1.1.0

netrc
0.7.8

nokogiri
1.5.6

os
0.9.6

plist
3.2.0

power_assert
0.2.2

psych
2.0.8

public_suffix
2.0.5

rake
10.4.2

rdoc
4.2.0

representable
2.3.0

retriable
2.1.0

rouge
1.11.1

ruby-macho
0.2.6

rubygems-update
2.5.2

rubyzip
1.2.0

security
0.1.3

signet
0.7.3

slack-notifier
1.5.1

sqlite3
1.3.13

terminal-notifier
1.7.1

terminal-table
1.7.3

test-unit
3.0.8

thread_safe
0.3.5

tty-screen
0.5.0

tzinfo
1.2.2

uber
0.0.15

unf
0.1.4

unf_ext
<IP_ADDRESS>

unicode-display_width
1.1.3

word_wrap
1.0.0

xcodeproj
1.4.2

xcpretty
0.2.4

xcpretty-travis-formatter
0.0.4

generated on: 2017-03-28

I've solved my issue : in Jenkins,
I've set an environment variable : LC_ALL with the value en_US.UTF-8.
Every build is ok now


Keep in background audio

Hi, thanks a lot for works on this project, it's really awesome!
I'm developing an app to get stream from Janus, one to many, server to client. All works great, but i have a problem to keep audio on in backgroung, in iOS and Android. After 30s-1m audio service ends.
Log message
[BackgroundTask] Background Task 175 ("Flutter debug task"), was created over 30 seconds ago. In applications running in the background, this creates a risk of termination. Remember to call UIApplication.endBackgroundTask(_:) for your task in a timely manner to avoid this.
Any idea to avoid this?

Well you need to run a foreground service as far as i know in Android you can't have background service without starting app with service in foreground for ios same needs to happen you probably have to research on that
Since this operation is beyond the scope of this project i will be closing this one, if you find any other issue feel free to open new one.


Is there a 1.19 branch?

I'm not a modpack developer, but I have basic knowledge to edit values in code, I want to change the damage of the weapons and the hp of entities, but when I tried building the .jar file, I realized that it was for 1.20.

Yes - it was named main. I changed it to 1.19.2 now to avoid confusion 👍
You may be better off changing the item damage using scripting tools such as Kube JS 🤔(not sure how to change the entity HP and stuff though)

Thank you for your help!


Update DID - JSON Exception

When attempting to select a DID, a popup appears that says: "Update DID: Unable to parse VoIP.ms api response (jsonexception).

Issue was resolved by removing INUM DID from account.

I'm seeing this error with the last update too. I'm not able to confirm that the problem is solved by removing the INUM DID, since I use that DID.

I'm seeing the same error when I try to select a DID.  I tried removing (deleting) my INUM DID from my account, but I'm still seeing the error.  I have the following DIDs remaining on my account: 1 x 1-800 us/canada number, 1 x UK (London) number, 3 x Toronto local numbers, and 1 x NYC number
Thanks for the update, even though it's not usable for me yet since I can't select a DID.

Unfortunately, "JSONException" is too general for me to debug. I can try adding an INUM DID to my account and seeing what happens, though. I'll also update the app with a more robust logging mechanism so the next time you see that error, you'll be able to send me logs that I can use to diagnose the problem.

Thanks.  I'll report back once the debugging log thing is in place.
Looks like the error message happens at line 329 of /src/main/java/net/kourlas/voipms_sms/api.java

Good news! I've figured out what the problem is. The app wasn't checking to see if SMS was available for a DID before checking if it was enabled.
I'll release an updated version shortly.

Done! Check Google Play in a few hours.


Implement commenting on failure based on config

If there is the failure_comment_message defined in the config, notify users via comment on failure using the configured message. Comment only once per commit SHA and job (utilising check of previous identical Packit comment).
Fixes #1911
TODO:

[x] Update or write new documentation in packit/packit.dev. (packit/packit.dev#735)

RELEASE NOTES BEGIN
We have introduced a new configuration option notifications.failure_comment.message that enables notifying users on failure via a comment using the configured message.
RELEASE NOTES END

Amazing, thank you! Can't wait to trying it out next week! :100:

Tested here.

@lbarcziova This is awesome. podman team will be relieved to have this so they won't have to manually tag me going forward :D


[TW#27105] stop httpd will stuck all the time when recevie wifi disconnect event.

Environment

Development Kit:      [ESP32-DevKitC]
Kit version (for WroverKit/PicoKit/DevKitC): [v4]
Core (if using chip or module): [ESP-WROOM-32D]
IDF version (3276a1316):
Development Env:		[Make]
Operating System:		[Ubuntu]
Power Supply:         [USB]

Problem Description
stop httpd will stuck when wifi disconnect.
code refer to examples/protocols/http_server/simple/main/main.c
Expected Behavior
Normally works.
Actual Behavior
sometimes httpd stop will stuck all the time.
Steps to repropduce
test 24 hours reproduce this issue, the probability is about 1-10%.
Debug Logs
    while (hd->hd_td.status != THREAD_STOPPED) {
        httpd_os_thread_sleep(1000);
        ESP_LOGW(TAG, "stopping httpd status(%d)...", hd->hd_td.status);
}

I (134462841) httpd: stopping httpd status(32768)...
I (134463841) httpd: stopping httpd status(32768)...
I (134464841) httpd: stopping httpd status(32768)...
I (134465841) httpd: stopping httpd status(32768)...
I (134466841) httpd: stopping httpd status(32768)...
I (134467841) httpd: stopping httpd status(32768)...
I (134468841) httpd: stopping httpd status(32768)...

```c

@outermanle Thanks for pointing out this issue. We'll try to resolve this as soon as possible

Thanks for your quick response.
During wifi status change, the ctrl sock(ctrl_fd) no response and server maybe  not receive the shutdown msg.

During wifi status change, the ctrl sock(ctrl_fd) no response and server maybe not receive the shutdown msg.

@outermanle That's one possibility.
But the status value printed is 32768, while status is an enum with only 4 possible values (0 to 3) and has a well defined value while the server is running. I suspect it has to do with the server handle, which could have gone invalid, though again that seems highly unlikely as handle is set to NULL when server stops.

I also doubt the status value with 32768, uint16_t -1 ?

@outermanle enums in this case are int32_t

I got the previous log, before add the status printed. It may be helpful. @anurag-kar
I (15264377) wifi: state: run -> init (0)
I (15264377) wifi: pm stop, total sleep time:<PHONE_NUMBER>1 us /<PHONE_NUMBER>6 us
I (15264377) wifi: n:1 0, o:1 1, ap:255 255, sta:1 1, prof:1
I (15264387) wifi: SYSTEM_EVENT_STA_DISCONNECTED
W (15264387) httpd_txrx: httpd_default_recv: error in recv = 113
I (15264397) wifi: disconnect reason: Assoc leave(8)
W (15264407) httpd_txrx: httpd_resp_send_err: 408 Request Timeout - Server closed this connection
I (15264407) wifi: send SYSTEM_EVENT_STA_DISCONNECTED succeed.
I (15264407) queue-srv: ACTION_WIFI_DISCONNECTED
W (15264417) httpd_txrx: httpd_default_send: error in send = 113
W (15264437) httpd: httpd stopping
I (15264437) httpd: httpd_stop: begin to sent control msg to stop server
W (15264447) httpd_txrx: httpd_default_recv: error in recv = 113
I (15264457) httpd: httpd_stop: sent control msg to stop server.
W (15264467) httpd_txrx: httpd_resp_send_err: 408 Request Timeout - Server closed this connection
W (15264467) httpd_txrx: httpd_default_send: error in send = 113
W (15264477) httpd_txrx: httpd_default_recv: error in recv = 113
W (15264487) httpd_txrx: httpd_resp_send_err: 408 Request Timeout - Server closed this connection
W (15264497) httpd_txrx: httpd_default_send: error in send = 113
I (15265467) httpd: stopping httpd...
I (15266467) httpd: stopping httpd...
I (15267467) httpd: stopping httpd... （while sleep 1s）
I (15268467) httpd: stopping httpd...
I (15269467) httpd: stopping httpd...
I (15270467) httpd: stopping httpd...
I (15271467) httpd: stopping httpd...
I (15272467) httpd: stopping httpd...
I (15273467) httpd: stopping httpd...

@outermanle Thanks.
Is this for examples/protocols/http_server/simple?

yes, I refer to this example and implement myself logic get/post handler.

I see. If there is more log, that'll be helpful.
Are you sure that httpd_stop() is not called twice with the same handle (could happen if SYSTEM_EVENT_STA_DISCONNECTED is triggered twice)? Calling httpd_stop() on an invalid handle will cause undefined behavior.
To avoid such situation the handle is assigned NULL, right after httpd_stop() is called, like it's done in the event_handler in examples/protocols/http_server/simple

yes, I have done this protection to prevent call twice.
wifi disconnected event
    if (httpd_server != NULL) {
        stop_webserver(httpd_server);
        httpd_server = NULL;
    }

wifi connected event
     if (httpd_server == NULL) {
            httpd_server = start_webserver();
        }

@outermanle I'll try to reproduce this situation. Hopefully get some insight out of that

@anurag-kar
Thanks.
Here is my test procedure:

wifi connected and delay 1-2 minutes then disconnect, repeat this.
open browser and request one page to httpd and then do nothing.

@anurag-kar
Can you provide debug patch? I can add it and reproduce it at the same time.

Can you provide debug patch? I can add it and reproduce it at the same time.

Thanks a lot. I've been trying to reproduce it with the simple example but still no luck.
You can try with this patch. Send me the full log if possible (attach a log file if too long).

I do some tweaks to it, if I change status to 2 and still restore to 65536.
I doubt if this heap boundary leak or wild poniter issue.
tweak code, active delete task if timeout
esp_err_t httpd_stop(httpd_handle_t handle)
{
    struct httpd_data *hd = (struct httpd_data *) handle;
    if (hd == NULL) {
        return ESP_ERR_INVALID_ARG;
    }
    int retry = 3;
    struct httpd_ctrl_data msg;
    memset(&msg, 0, sizeof(msg));
    msg.hc_msg = HTTPD_CTRL_SHUTDOWN;
    //ESP_LOGI(TAG, LOG_FMT("begin to sent control msg to stop server"));
    ESP_LOGW(TAG, LOG_FMT("server thread status before stopping = %d"), hd->hd_td.status);
    /* TODO: if blocked here then set hd->hd_td.status = THREAD_STOPPING; */
    cs_send_to_ctrl_sock(hd->msg_fd, hd->config.ctrl_port, &msg, sizeof(msg));
    ESP_LOGI(TAG, LOG_FMT("sent control msg to stop server."));
    while (hd->hd_td.status != THREAD_STOPPED) {
        httpd_os_thread_sleep(1000);
        if (retry-- == 0) {
            /* allow 3 seconds to process, oresle set directly. */
            ESP_LOGW(TAG, LOG_FMT("Timeout to stop server, set directly!"));
            hd->hd_td.status = THREAD_STOPPING;
        }
        ESP_LOGW(TAG, "stopping httpd status(%d)...", hd->hd_td.status);

        if (retry < 0) {
            if (hd->hd_td.status > THREAD_STOPPED) {
                ESP_LOGE(TAG, "pointer issue? fatal err!");
            }
            hd->hd_td.status = THREAD_STOPPING;
            vTaskDelay(22000/portTICK_PERIOD_MS);
            ESP_LOGE(TAG, "reset status again, httpd status(%d)...", hd->hd_td.status);

            if (hd->msg_fd != -1) close(hd->msg_fd);
            if (hd->ctrl_fd != -1) cs_free_ctrl_sock(hd->ctrl_fd);
            httpd_close_all_sessions(hd);// crash here
            if (hd->listen_fd != -1) close(hd->listen_fd);
            hd->hd_td.status = THREAD_STOPPED;
            ESP_LOGW(TAG, LOG_FMT("begin to delete httpd task"));
            if (hd->hd_td.handle != NULL) {
                ESP_LOGW(TAG, LOG_FMT("delete httpd task"));
                vTaskDelete(hd->hd_td.handle);
                hd->hd_td.handle = NULL;
                break;
            } else {
                ESP_LOGW(TAG, LOG_FMT("already delete httpd task"));
            }
        }
    }

    ESP_LOGI(TAG, LOG_FMT("server stopped"));
    httpd_delete(hd);
    return ESP_OK;
}

crash log
I (119938306) wifi: state: run -> auth (ec0)
I (119938306) wifi: pm stop, total sleep time:<PHONE_NUMBER>8 us /<PHONE_NUMBER>8 us
I (119938306) wifi: n:6 0, o:6 0, ap:255 255, sta:6 0, prof:1
I (119938316) wf: SYSTEM_EVENT_STA_DISCONNECTED
I (119938316) wf: disconnect reason: Mic failure(14)
I (119938326) que: ACTION_WIFI_DISCONNECTED
Interface not up, skipping 0x3ffd1f94
W (119938336) httpd: httpd stopping
I (119938336) httpd: httpd_stop: begin to sent control msg to stop server
I (119938346) httpd: httpd_stop: sent control msg to stop server.
Interface not up, skipping 0x3ffd1f94
W (119939356) httpd: stopping httpd status(65535)...
W (119940356) httpd: stopping httpd status(65535)...
W (119941356) httpd: stopping httpd status(65535)...
W (119942356) httpd: httpd_stop: Timeout to stop server, set directly!
W (119942356) httpd: stopping httpd status(2)...
E (119954356) httpd: reset status again, httpd status(65535)...
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.
Core 0 register dump:
PC      : 0x4016621e  PS      : 0x00060b30  A0      : 0x80136038  A1      : 0x3ffc2cf0
0x4016621e: httpd_sess_iterate at /home/xxx/components/http_server/src/httpd_sess.c:228
A2      : 0x3fad5672  A3      : 0x000000a8  A4      : 0x3ffc2ce0  A5      : 0x0000000c
A6      : 0x00000001  A7      : 0x00000000  A8      : 0x00000000  A9      : 0x00000000
A10     : 0xffffff2f  A11     : 0x00000000  A12     : 0x0000ffff  A13     : 0x3ffc29a0
A14     : 0x3ffc29a0  A15     : 0x00000003  SAR     : 0x00000004  EXCCAUSE: 0x0000001c
EXCVADDR: 0xffffff2f  LBEG    : 0x400014fd  LEND    : 0x4000150d  LCOUNT  : 0xfffffffe
Backtrace: 0x4016621e:0x3ffc2cf0 0x40136035:0x3ffc2d10 0x401367e4:0x3ffc2d30 0x400db3cc:0x3ffc2d60 0x400d445f:0x3ffc2d80 0x400d6b8b:0x3ffc2e30
0x4016621e: httpd_sess_iterate at /home/xxx/components/http_server/src/httpd_sess.c:228
0x40136035: httpd_close_all_sessions at /home/xxx/components/http_server/src/httpd_main.c:108
0x401367e4: httpd_stop at /home/xxx/components/http_server/src/httpd_main.c:416
0x400db3cc: stop_webserver at /home/xxx/examples/xxx/main/webserver.c:1244

================= CORE DUMP START =================
UD0AABIAAABkAQAA
qL/7PzAs/D8EL/w/
UCz8P6Au/D8kCbcAPED7PzxA+z+ov/s/NED7PxQAAAB4v/s/eL/7P6i/+z8AAAAA

crash line 282
int httpd_sess_iterate(struct httpd_data *hd, int start_fd)
{
    int start_index = 0;
    int i;

    if (start_fd != -1) {
        /* Take our index to where this fd is stored */
        for (i = 0; i < hd->config.max_open_sockets; i++) {
            if (hd->hd_sd[i].fd == start_fd) {
                start_index = i + 1;
                break;
            }
        }
    }

    for (i = start_index; i < hd->config.max_open_sockets; i++) {
        if (hd->hd_sd[i].fd != -1) { // <----------crash line 228
            return hd->hd_sd[i].fd;
        }
    }
    return -1;
}

@anurag-kar
I got this crash log.
I (12115192) wifi: state: run -> init (0)
I (12115192) wifi: pm stop, total sleep time:<PHONE_NUMBER> us /<PHONE_NUMBER> us
I (12115192) wifi: n:11 0, o:11 0, ap:255 255, sta:11 0, prof:1
I (12115202) wf: SYSTEM_EVENT_STA_DISCONNECTED
W (12115202) httpd_txrx: httpd_default_recv: error in recv = 113
I (12115222) wf: disconnect reason: Assoc leave(8)
I (12115252) que: ACTION_WIFI_DISCONNECTED
W (12115232) httpd_txrx: httpd_resp_send_err: 408 Request Timeout - Server closed this connection
Interface not up, skipping 0x3ffd1fb4
Interface not up, skipping 0x3ffd1fb4
W (12115282) httpd_txrx: httpd_default_send: error in send = 113
W (12115292) httpd: httpd stopping
I (12115332) wifi: n:6 0, o:11 0, ap:255 255, sta:6 0, prof:1
E (12115342) http: close socket for exception
I (12115352) http: HTTP_EVENT_DISCONNECTED
W (12115332) httpd: httpd_stop: server thread status before stopping =<PHONE_NUMBER>
Guru Meditation Error: Core  1 panic'ed (Interrupt wdt timeout on CPU1)
Core 1 register dump:
PC      : 0x4000c271  PS      : 0x00060034  A0      : 0x8008b452  A1      : 0x3ffc2c00
A2      : 0x3ffc1f00  A3      : 0x3f40390a  A4      : 0x00000014  A5      : 0x3ffb0bd0
A6      : 0x3ffb0c18  A7      : 0x00000001  A8      : 0x00000001  A9      : 0x3f40390b
A10     : 0x000000a5  A11     : 0x00000000  A12     : 0x8008bdab  A13     : 0x3ffb0ba0
A14     : 0x00000020  A15     : 0x00000020  SAR     : 0x0000001c  EXCCAUSE: 0x00000006
EXCVADDR: 0x00000000  LBEG    : 0x400014fd  LEND    : 0x4000150d  LCOUNT  : 0xfffffffd
Backtrace: 0x4000c271:0x3ffc2c00 0x4008b44f:0x3ffc2c20 0x4008cc00:0x3ffc2c50 0x4008cbb6:0x00000000
0x4008b44f: vTaskSwitchContext at /home/xxx/components/freertos/tasks.c:5120
0x4008cc00: _frxt_dispatch at /home/xxx/components/freertos/portasm.S:406
0x4008cbb6: _frxt_int_exit at /home/xxx/components/freertos/portasm.S:206
Core 0 register dump:
PC      : 0x4014e374  PS      : 0x00060a34  A0      : 0x8014e588  A1      : 0x3ffc8240
0x4014e374: SHA1Transform at /home/xxx/components/wpa_supplicant/src/crypto/sha1-internal.c:219
A2      : 0xd5417cfc  A3      : 0x67d2af6e  A4      : 0x250763c8  A5      : 0x34635acb
A6      : 0xfc50235f  A7      : 0x594bb29f  A8      : 0x754214b4  A9      : 0x74bc8bc4
A10     : 0x4a266f69  A11     : 0x4b58ddbc  A12     : 0x6d9e9ed4  A13     : 0x2d26d071
A14     : 0xca62c1d6  A15     : 0x109735f7  SAR     : 0x00000002  EXCCAUSE: 0x00000006
EXCVADDR: 0x00000000  LBEG    : 0x4000c2e0  LEND    : 0x4000c2f6  LCOUNT  : 0x00000000
Backtrace: 0x4014e374:0x3ffc8240 0x4014e585:0x3ffc8300 0x4014e67d:0x3ffc8320 0x4014cd3c:0x3ffc83a0 0x4014cdae:0x3ffc8460 0x4014e844:0x3ffc8490 0x40129dd5:0x3ffc8520 0x4012ad42:0x3ffc8540 0x4012ad51:0x3ffc8580 0x40118841:0x3ffc85a0 0x40118b48:0x3ffc85e0 0x401196b8:0x3ffc8620 0x401196ea:0x3ffc8670 0x401155f1:0x3ffc86c0 0x4011591c:0x3ffc8710 0x40118129:0x3ffc8730 0x4011814a:0x3ffc8750 0x40117cb4:0x3ffc8770 0x40117fce:0x3ffc8790 0x40086db8:0x3ffc87b0
0x4014e374: SHA1Transform at /home/xxx/components/wpa_supplicant/src/crypto/sha1-internal.c:219
0x4014e585: SHA1Update at /home/xxx/components/wpa_supplicant/src/crypto/sha1-internal.c:267
0x4014e67d: sha1_vector at /home/xxx/components/wpa_supplicant/src/crypto/sha1-internal.c:44 (discriminator 3)
0x4014cd3c: hmac_sha1_vector at /home/xxx/components/wpa_supplicant/src/crypto/sha1.c:80
0x4014cdae: hmac_sha1 at /home/xxx/components/wpa_supplicant/src/crypto/sha1.c:111
0x4014e844: pbkdf2_sha1_f at /home/xxx/components/wpa_supplicant/src/crypto/sha1-pbkdf2.c:54
 (inlined by) pbkdf2_sha1 at /home/xxx/components/wpa_supplicant/src/crypto/sha1-pbkdf2.c:91
0x40129dd5: wpa_set_bss at ??:?
0x4012ad42: wpa_config_bss at ??:?
0x4012ad51: wpa_sta_connect at ??:?
0x40118841: cnx_sta_connect_led_timer_cb at ??:?
0x40118b48: cnx_sta_connect_led_timer_cb at ??:?
0x401196b8: cnx_remove_all_rc at ??:?
0x401196ea: cnx_start_handoff_cb at ??:?
0x401155f1: free_bss_info at ??:?
0x4011591c: scan_inter_channel_timeout_process at ??:?
0x40118129: chm_end_op at ??:?
0x4011814a: chm_end_op_timeout_process at ??:?
0x40117cb4: wifi_station_stop at ??:?
0x40117fce: ieee80211_timer_do_process at ??:?
0x40086db8: ppTask at ??:?

================= CORE DUMP START =================
YEIAABIAAABkAQAA
XIj8PzCC/D9UiPw/
MIL8P/CH/D+Qhvw/uEH7P7hB+z9ciPw/sEH7PwEAAADEv/s/qO37P1yI/D8AAAAA
GAAAAFh6/D93aWZpAHr8P3dpZmkAxawAAAAAAFSI/D8AAAAAIQAGABcAAAABAAAA
AAAAAAAAAAAAAAAAqOj6PxDp+j946fo/AAAAAAAAAAABAAAAAAAAAJAZQD8AAAAA
SB0AQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

@anurag-kar
I doubt there is heap corruption in the wifi driver.
I check all of my code and can't find any suspicious.
Or you can give me some tips to check heap leak.
I monitor the heap size all the time, and there is no memleak, I think it should be heap corruption issue.
And this issue only trigger when wifi disconnect event. The probability is about 1-10%.

Refer to this for debugging heap corruption : https://docs.espressif.com/projects/esp-idf/en/latest/api-reference/system/heap_debug.html#heap-tracing-to-find-heap-corruption

@anurag-kar  After enable CONFIG_HEAP_POISONING_COMPREHENSIVE, this issue disappeared.
There is any update about memory issue in wifi driver recently? Specially during WIFI disconnect event.
#
 # Heap memory debugging
 #
-CONFIG_HEAP_POISONING_DISABLED=y
+CONFIG_HEAP_POISONING_DISABLED=
 CONFIG_HEAP_POISONING_LIGHT=
-CONFIG_HEAP_POISONING_COMPREHENSIVE=
+CONFIG_HEAP_POISONING_COMPREHENSIVE=y
 CONFIG_HEAP_TRACING=
+CONFIG_HEAP_TASK_TRACKING=

@outermanle Not that I know of. Let me check with someone who would be more appropriate to answer this.

Okay, Thanks.

@anurag-kar
Update to the newest master branch 12b2268ee56dac79988b75dbb49a453629ed8022 and this issue hasn't happened yet.
But trigger one time about watchdog in wifi driver, so stuck all the time.
I think there is true condition loop all the time in the wifi driver version 12b2268ee56dac79988b75dbb49a453629ed8022.

the handle passed to stop httpd is different with that one in httpd thread...

@outermanle That means that the thread argument is corrupt which may imply FreeRTOS task stack overflow!
Could you try increasing the stack_size in httpd_config_t structure passed to httpd_start()? (The default value is 4096).
httpd_config_t config = HTTPD_DEFAULT_CONFIG();
config.stack_size = 8192;

Thanks @anurag-kar , I will try it.

the handle passed to stop httpd is different with that one in httpd thread...

@outermanle Could you also tell me how you check this? Because, if that is the case, it still doesn't explain why the status value is a garbage, when accessed using the handle (valid handle) provided to httpd_stop().

@anurag-kar
Enable stack check but get nothing tips.
In my home AP, the probability is about 40-50%.
start server handle
I (560799) httpd: Starting httpd on port: '80'
I (560809) httpd: Started HTTP server=0x3ffd3938 on port: '80'
I (560819) httpd: Max URI handlers: '12'
I (560819) httpd: Max Stack Size: '4096'
I (560829) httpd: Registering basic handlers
I (560829) httpd: Number of handlers = 12
I (560839) httpd: Success

stop server handle
W (12390139) httpd: httpd stopping handle=0x3f0b12c5
E (12390199) httpd: handle=0x3f0b12c5

I (560799) httpd: Starting httpd on port: '80'
I (560809) httpd: Started HTTP server=0x3ffd3938 on port: '80'
I (560819) httpd: Max URI handlers: '12'
I (560819) httpd: Max Stack Size: '4096'
I (560829) httpd: Registering basic handlers
I (560829) httpd: Number of handlers = 12
I (560839) httpd: Success

@outermanle Could you tell me from which function you are printing the above?

W (12390139) httpd: httpd stopping handle=0x3f0b12c5
E (12390199) httpd: handle=0x3f0b12c5

And this?

W (561160) mst: http handle=0x3ffd3308 (print in other monitor thread)
W (562160) mst: http handle=0x3ffd3308
W (563160) mst: http handle=0x3ffd3308
W (564160) mst: http handle=0x3ffd3308
W (565160) mst: http handle=0x3ffd3308
E (565830) httpd: httpd_server: handle=0x3ffd3308, timeout=1  (print in httpd_server)
W (566160) mst: http handle=0x3ffd3308
W (567160) mst: http handle=0x3f8f77a9  (changed!!!! and change after sometimes )
W (568160) mst: http handle=0x3f8f77a9
W (569160) mst: http handle=0x3f8f77a9

@anurag-kar
How can I debug global static variable change be others?
Got nothing tips when enable stack and heap debug in config file.

@outermanle First thing, ensure that the pointer to the static handle variable, which you get as argument to the event_handler is correct.
Print the pointer to static variable in main function first :
void app_main()
{
    static httpd_handle_t server = NULL;
    ESP_LOGI(TAG, "app_main : ptr to server handle : %p", &server);

    ............................
    ............................
    ............................
}

And print the pointer to static variable in event handler :
static esp_err_t event_handler(void *ctx, system_event_t *event)
{
    httpd_handle_t *server = (httpd_handle_t *) ctx;
    ESP_LOGI(TAG, "event_handler : ptr to server handle : %p", server);

    ............................
    ............................
    ............................

    return ESP_OK;
}

Do these match?

yes, they match.
but not match with the original one  which store in the httpd thread.

but not match with the original one which store in the httpd thread.

The argument to httpd_thread stores the value of handle (which is a pointer to internal struct httpd_data). So this is not a problem
Let's try moving the handle to heap:
void app_main()
{
   httpd_handle_t *server = calloc(1, sizeof(httpd_handle_t));
    ESP_LOGI(TAG, "app_main : ptr to server handle : %p", server);
    ............................
    ............................
    ............................
    initialise_wifi(server);
}

Now check if the value of handle changes in the event_handler

You should check what other global data is placed near your variable with objdump

Also, if JTAG debugging is an option, try setting a watchpoint on the variable which gets corrupted. It will trigger when other code modifies it.
If you don't have access to JTAG, you can also set watchpoint from your application, calling esp_set_watchpoint function.
E.g. esp_set_watchpoint(0, &httpd_server, 4, ESP_WATCHPOINT_STORE);
The declaration of this function is in esp_panic.h.
Without JTAG connected, watchpoint will trigger a debug exception, and you will get the backtrace.

@negativekelvin @igrr
I have no JTAG.
That's good suggestion, Thanks a lot!

@igrr @anurag-kar @negativekelvin
Thank you very much.
Solved by add esp_set_watchpoint, The reason is array boundary exceeded.


[TypeScript] highlight breaks after type definition

VS Code Version: 1.53.2 & 1.54.0(insiders)
OS Version: windows 19042.746

Steps to Reproduce:

create a new file
write following code

type TestType = {}
foo

change file type to TypeScript(typescript)
highlight breaks after the type definition

Does this issue occur when all extensions are disabled?: Yes

Looks like foo has the scope:
entity.name.type.ts
meta.type.declaration.ts
source.ts
``

This is working as intended because of limitation of textmate grammar rules which doesn't allow lookup beyond line. Duplicate of #352


Running a game with two bots in real-time mode.

Hi,
I'm trying to run a game with two bots in real-time mode, but it looks like it doesn't register end of the game.
If i run bot vs computer both in real-time and in not real-time mode, or bot vs bot in not real-time mode, it works, but not when running bot vs bot in real-time.
Do anyone know a solution for that?
I was trying to debug that problem and it looks like response object:
response.ParseFromString(response_bytes)
doesn't contain player_result
Example from non-real-time mode:
  player_result {
    player_id: 1
    result: Victory
  }
  player_result {
    player_id: 2
    result: Defeat
  }

This is an issue in the protocol level, and it's we cannot fix it in the library easily. I opened issue in the protocol repo more than a year ago: https://github.com/Blizzard/s2client-proto/issues/90


[Bug] Ban on double space between words

System Information

Operating System: Ubuntu 18.04
Python Version [e.g. 2.7.16]

Bot Configuration
What have you changed in config.ini? (besides passwords/keys/accounts):
AutoLogin=True
ChatLogging=True
DebugMode=True
DebugToFile=True
KickAsAutoban=False
NotifyOnBan=True
TryTimeBasedCheck=False

[integers]
DebugLevel=20
MaxMatchBans=3
ThreadPool=25

Describe the bug
A user will be banned if there are 2 spaces between words.
To Reproduce
Steps to reproduce the behavior:

Say test  test.
Get banned.

Expected behavior
Should not be banned for having bad grammar.
Tracebacks and Errors
[21:04:23:200] nickname: test  test
[21:04:23:296] [SYSTEM]: _ banned nickname
[21:04:23:298] nickname:2447937 left the room.

debug.log contains nothing useful.

Due to having */n/n in string_bans.txt
>>> a = "*\n\n"
>>> # in "anything you want"
>>> a.rstrip("\n").replace("*","") in ""
True


Add support for HTTP basic auth to the kube-apiserver.

Re-opening #6508 on a new branch for discussion.
/cc @brendandburns @smarterclayton @lavalamp @liggitt @deads2k

As long as the authenticator is optional and folks can disable it I'm not opposed to it existing.  Post 1.0 we can have the larger oauth discussion and discuss tokens and behavior.

This is the first half of #7399 (the second half is adding some GCE salt configuration to enable this).

@lavalamp - feedback addressed. I'll work on the salt changes in a follow-up PR.

LGTM

:+1:

I don't know if you want this merged yet, but it needs to be rebased if you do.

Rebased and back into the queue for travis.

Merging on manual validation w/ @roberthbailey while Travis is sooooo sloooooooow


Update en_CA locale units

We're pretty inconsistent when it comes to units here, but we are
theoretically a metric nation.

Neat - thanks!


United Kingdom Number Name Not Show

United Kingdom Number Name Not Show
Like truecallerjs -s<PHONE_NUMBER>xx --name
output Unknown

This package won't really extract the  name of a person with phone number. It will extract  the name as per the Truecaller database. If it is unknown, then there is no information about that number.


Fix inconsistent tab and spaces in protoc-gen-template

Also remove an auto application which is not supported in Scala3.
I noticed these issues when opening the project in Scala3 mode.

Thank you!


Add version info banner

The version info banner was missing from files in dist folder.

ping @katspaugh

another attempt: ping @katspaugh (perhaps you can give me merge rights?)

@thijstriemstra hey, sorry, missed your message. Adding rights!

Thanks mate!


Singleton connection to SQLite

For operators that need to write to the database such as DbInsert and ProfillingLogger, we create new connections in either their constructors or init()s. This works fine for Postgres but not for SQLite since SQLite only allows one writer at a time. If there are multiple threads with writers, we get "database is locked". The solution, seems to be only using a singleton SQLiteAccessMethod instance for each worker, then write requests should be handled by the sqliteQueue inside.

Once we have standardized on dependency injection with Tang (byproduct of the REEF work I'm doing), we could inject the SQLiteAccessMethod singleton instance in the operator constructor.


[WIP] Add missing indexes

I was looking into speeding up tests and decided to run mongodb with --notablescan option to find out if we have any queries which result in table scans (aka index not being used).
It turns out we do indeed have such offenders.
This pull request adds missing indexes which should speed up some queries in production installations with a lot of data.
Going forward, I would propose running MongoDB on Circle CI with --notablescan option. This will immediately let us know if we are missing an index since a query which would result in a table scan and as such the test case itself will fail.
Based on top off #3465 (once that PR is approved and merged the diff will look much saner).

Going forward, I would propose running MongoDB on Circle CI with --notablescan option. This will immediately let us know if we are missing an index since a query which would result in a table scan and as such the test case itself will fail.

+1

I believe I caught and fixed most of the missing indexes now.
There is still one weird issue / error I haven't managed to track down:
Traceback (most recent call last):
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/eventlet/hubs/poll.py", line 115, in wait
    listener.cb(fileno)
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/eventlet/greenthread.py", line 214, in main
    result = function(*args, **kwargs)
  File "/data/stanley/st2common/st2common/services/triggerwatcher.py", line 139, in _load_triggers_from_db
    for trigger in Trigger.query(type=trigger_type):
  File "/data/stanley/st2common/st2common/persistence/base.py", line 114, in query
    return cls._get_impl().query(*args, **kwargs)
  File "/data/stanley/st2common/st2common/models/db/__init__.py", line 295, in query
    result = result[offset:eop]
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/mongoengine/queryset/base.py", line 175, in __getitem__
    queryset._cursor_obj = queryset._cursor[key]
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/mongoengine/queryset/base.py", line 1547, in _cursor
    self._cursor_obj = self._collection.find(self._query,
AttributeError: 'NoneType' object has no attribute 'find'
Removing descriptor: 13
Traceback (most recent call last):
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/eventlet/hubs/poll.py", line 115, in wait
    listener.cb(fileno)
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/eventlet/greenthread.py", line 214, in main
    result = function(*args, **kwargs)
  File "/data/stanley/st2common/st2common/services/triggerwatcher.py", line 139, in _load_triggers_from_db
    for trigger in Trigger.query(type=trigger_type):
  File "/data/stanley/st2common/st2common/persistence/base.py", line 114, in query
    return cls._get_impl().query(*args, **kwargs)
  File "/data/stanley/st2common/st2common/models/db/__init__.py", line 295, in query
    result = result[offset:eop]
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/mongoengine/queryset/base.py", line 175, in __getitem__
    queryset._cursor_obj = queryset._cursor[key]
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/mongoengine/queryset/base.py", line 1547, in _cursor
    self._cursor_obj = self._collection.find(self._query,
AttributeError: 'NoneType' object has no attribute 'find'
Removing descriptor: 14

It happens when querying for TriggerDB - indexes and everything is in place so not sure yet what is going on there.

OK, finally fixed all the missing index issues.
Will go ahead and enable --notablescan mongodb mode on Circle CI.


Issue with mutex and windows 22

Recently we created a new build machine (Self hosted Azure Devops, Windows 22). On this machine we host 3 agents. Every agent runs with its own user account. (Local admins .\agent1, .\agent2, .\agent3). Reason we use different accounts is because the PS modules used by the agent are installed on user level. This allows us to use different versions of the same PS module between the agents.
In the past we used W2019 servers, for which this worked just fine.
With Windows 22 we see following errors when containers are being created:

As far as I know the error is coming from this part:

PS Script: Artifacts\Download-Artifacts.ps1

https://developercommunity.visualstudio.com/t/Access-violation-in-_Thrd_yield-after-up/10664660 - says something about MSVCP140.dll being required by mutex - maybe this is missing on your machines.

I narrowed done the issue with following test case:

Setup W22 machine with 2 agents
Each agent running as service with different local admin accounts
Yml file for this build has 1 step (See below)
When triggering two builds in parallel the 2nd build will run with following error:
New-Object : Exception calling ".ctor" with "2" argument(s): "Access to the path 'TestMutex' is denied."

  - task: PowerShell@2
    displayName: 'Create Container'
    inputs:
      TargetType: 'Inline'
      Script: |
        $appMutexName = "TestMutex"
        $appMutex = New-Object System.Threading.Mutex($false, $appMutexName)
        try {
            if (!$appMutex.WaitOne(1000)) {
                Write-Host "Waiting for other process downloading artifact '$($artifactUrl.Split('?')[0])'"
                $appMutex.WaitOne() | Out-Null
                Write-Host "Other process completed download"
            }
            Write-Host "start sleep"
            Start-Sleep -Seconds 30
            Write-Host "Completed"
        }
        catch [System.Threading.AbandonedMutexException] {
            Write-Host "Other process terminated abnormally"
        }
        $appMutex.ReleaseMutex()
    env:
      TOKEN: $(System.AccessToken)

Strange.
Mutex isn't really a BcContainerHelper construct - it is a dotnet construct.
If it doesn't work - I don't expect BcContainerHelper to be able to solve that.
If you RDP into the W2022 machine and start two PowerShell instances - and run:
$appMutex = New-Object System.Threading.Mutex($false, 'TestMutex')

On both - and then run
$appMutex.WaitOne()

on both - one after the other - the second one should wait until you run
$appMutex.ReleaseMutex()

Also read about this issue here: https://github.com/microsoft/navcontainerhelper/issues/3164
It seems to be an issue with network/ad accounts and services
If I ran the agent as local system account it does work. But running it as a local "admin user" it doesnt...

Your test scenario with just two PS sessions works fine. The problem occurs when using windows services

So I guess I had heard about this before... - totally forgot all about that other issue :-(
Anyway - you have your workaround - run as a local system account instead (which also is more secure).

The local system account solves the problem with the mutex. But it introduce a new problem. If all agents run under the same account its hard to differentiate between PS module versions. Normally we install them with user scope. So modules are installed in %HOME%\Documents\Powershell Modules
If all agents run with same account this will not work...

Understood, but this is a very specific problem and not something I will have the time to investigate.
You could run different runners for different versions maybe?
Or if you indeed find a way to fix this, feel free to create a PR on BcContainerHelper (if it is risk free).


Use consistent names

read/write for operations that return ok/error
from/to for operations that are direct conversions

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


[question] Debugging "CMake failed"

Hello!
I'm a first-time user. After running TMP=tmp python -m build ., I received the following error message:
Command '['cmake', '-S', '/home/senyai/projects/videoreader/tmp/build-via-sdist-jj4bps4l/videoreader-0.0.1', '-B', '/home/senyai/projects/videoreader/tmp/build-via-sdist-jj4bps4l/videoreader-0.0.1/.py-build-cmake_cache/cp310-cp310-linux_x86_64', '-C', '/home/senyai/projects/videoreader/tmp/build-via-sdist-jj4bps4l/videoreader-0.0.1/.py-build-cmake_cache/cp310-cp310-linux_x86_64/py-build-cmake-preload.cmake', '-D', 'CMAKE_BUILD_TYPE:STRING=RelWithDebInfo']' returned non-zero exit status 1.
I want to debug the CMake script to understand what is going wrong, but the tmp directory is cleaned up afterward. Is there a way to prevent the files from being deleted?

By default, PyPA build will build your package from the sdist in a temporary directory. I'm not aware of any option to prevent it from removing that directory, but you can use build's -w flag to skip the sdist step and build in the source directory directly:
python -m build -w

Thanks. When I run python -m build -w, the project compiles successfully. However, I took a fresh look at my project and realized that I was missing some files.
before:
[tool.py-build-cmake.sdist]
include = ["CMakeLists.txt", "src/*", "include/*.*"]

after:
[tool.py-build-cmake.sdist]
include = ["CMakeLists.txt", "src/*", "include/videoreader/*.*"]


Rename symbol

From @microshine on September 7, 2016 16:49

VSCode Version: 1.4.0
OS Version: Windows 10 x64

Source code
let arr = {
    item: "Hello"
};

const {item} = arr;

console.log(item);
console.log(arr.item);

Trying to rename item symbol (F2) to itemA
Result
let arr = {
    itemA: "Hello"
};

const {item} = arr; // TSError: Has no property `item`

console.log(item);
console.log(arr.itemA);

Copied from original issue: Microsoft/vscode#11641

@microshine thank you for opening this issue. This is a TypeScript service issue. Moving to their repo.

Looks like a duplicate of #6312.

Duplicate of #6312 / #15787


Remove set library from business_time gem

Due to https://github.com/ruby/rbs/issues/1250

Yard also has set in its manifest.yaml so I tried to remove it too. But the generator introduces unexpected differences. So I gave up fixing Yard gem. cc/ @ksss

@pocke Thanks for sharing.
I'll fix yard gem later.


RemovePeerFromSet NullReferenceException

A nullreferenceexception can be thrown on RemovePeerFromSet if NetPeer is null.
If you are interested in steps to reproduce this bug was filed on my github here https://github.com/FirstGearGames/FishNet/issues/709
Stack trace:
NullReferenceException: Object reference not set to an instance of an object
LiteNetLib.NetManager.RemovePeerFromSet (LiteNetLib.NetPeer peer) (at Assets/FishNet/Runtime/Transporting/Transports/Tugboat/LiteNetLib/NetManager.HashSet.cs:171)
LiteNetLib.NetManager.RemovePeerInternal (LiteNetLib.NetPeer peer) (at Assets/FishNet/Runtime/Transporting/Transports/Tugboat/LiteNetLib/NetManager.HashSet.cs:152)
LiteNetLib.NetManager.RemovePeer (LiteNetLib.NetPeer peer) (at Assets/FishNet/Runtime/Transporting/Transports/Tugboat/LiteNetLib/NetManager.HashSet.cs:146)
LiteNetLib.NetManager.ProcessEvent (LiteNetLib.NetEvent evt) (at Assets/FishNet/Runtime/Transporting/Transports/Tugboat/LiteNetLib/NetManager.cs:513)
LiteNetLib.NetManager.PollEvents (System.Int32 maxProcessedEvents) (at Assets/FishNet/Runtime/Transporting/Transports/Tugboat/LiteNetLib/NetManager.cs:1501)
FishNet.Transporting.Tugboat.CommonSocket.PollSocket (LiteNetLib.NetManager nm) (at Assets/FishNet/Runtime/Transporting/Transports/Tugboat/Core/CommonSocket.cs:137)

I made some untested changes but I figured you may want to dig deeper to see if there's anything else that could come from this...
        private bool RemovePeerFromSet(NetPeer peer)
        {
            if (_buckets == null)
                return false;
            if (peer == null)
                return false;

Library version: 1.0.1-1
Framework: Unity.
OS: Issue happens on Mac.

Fixed. And added some logs to detect problem better

I discovered this is part of an improvement I made locally that you had not merged, so it shouldn't be present in your release. But I do wonder if this is still intended to be caught...
I added this change to pool the peerId
                case NetEvent.EType.Error:
                    _netEventListener.OnNetworkError(evt.RemoteEndPoint, evt.ErrorCode);

Should evt.Peer be null there? What happens to the NetPeer reference during an error? If the Peer is null then the Id from it cannot be cached. Even without the caching fix, this would eventually result in an overflow if clients were to exploit this by forcing errors until no more Ids were available.

@FirstGearGames there can be null Peer because this error notification can happen without peers.

Okay, but it's not always null? So handling it with the null check should suffice then I imagine.

@FirstGearGames it's not always null. But you shouldn't remove peer here. It will be removed later if there real connection error by timeout (or by another reason)

Gotcha. Long as the peerId ends up back in the queue at some point. That's the only reason I called RemovePeer on that line, as well here ...
                case NetEvent.EType.Disconnect:
                    var info = new DisconnectInfo
                    {
                        Reason = evt.DisconnectReason,
                        AdditionalData = evt.DataReader,
                        SocketErrorCode = evt.ErrorCode
                    };
                    _netEventListener.OnPeerDisconnected(evt.Peer, info);
                    RemovePeer(evt.Peer); //THIS WAS ADDED
                    break;

If the call is not needed I'll remove them so they don't go into my queue fix PR.

Awesome. I'll make those changes before submitting the PR.


fix up some problem in idl.ts

export DefinitionType enum in order to use it at outside.
move to initialization position of |definitions|.
present, new Array was assiged whenever iterating,
so definitions can have only last one item

ISSUE=None

lgtm :)


[CARBONDATA-3719] upgraded hive version to 3.1.0

Why is this PR needed?
Upgrade hive version to take advantages of new optimizatons n hive.
What changes were proposed in this PR?

Version upgrade and compilation fixes for same

Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/407/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2108/

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/411/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2112/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/518/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2218/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/523/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/527/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2227/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/531/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2231/

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/549/

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/555/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2255/

LGTM