replaced single line DOMAIN in openvpn config with multi-line DOMAIN-…

@jfelten
What this PR does / why we need it:
replaced single line DOMAIN in openvpn config with multi-line DOMAIN-SEARCH to make it work with Mac OSX and tunnelblick
Working with this chart, the DNS search domains were throwing an error when using Tunnelblick on Mac. I determined that the desired dhcp-option was DOMAIN-SEARCH and that only a single domain per line is allowed. I updated the configure script so that the openvpn.conf file was modified with a block of DOMAIN-SEARCH options instead of a single line.

/ok-to-test

/lgtm


Ipc\Zmq API should be made consistent or at least similar to Ipc\Socket

Those repositories have been split, its no longer necessary for them to have similar interface.


Determine a Versioning Scheme

Once #44, https://github.com/rht-labs/openshift-jenkins-s2i-config/issues/52 and https://github.com/rht-labs/openshift-sonarqube/issues/16 are merged, we need to cut a release of this repo.
Before doing that, we should decided on a versioning schem.

A pre-release was cut to have a "fall-back" strategy before merging the big clean-up PRs. This pre-release is using vX.Y.Z versioning scheme, but this can always be revamped before cutting the "v1" release.
https://github.com/rht-labs/labs-ci-cd/releases/tag/v0.1.0

Good call. Thank you.
@oybed is there a versioning scheme in casl we can follow?

@sherl0cks CASL is following major.minor OpenShift releases and uses the vX.Y.Z approach:
https://github.com/redhat-cop/casl-ansible/releases


display color icon that has values >100

i can't figure out if is possible to give a certain color for identity thats has values bigger than 100.
I am using this card to display the watt of some smart plug. The value more than 100 doesn't change the icon color

I have the same issue and question.
I have used the card for listing device link quality. When a device has a link quality above 100 lqi, the color does not change.

no ideas?

Same problem, using it with my smart plugs to follow power consumption but above 100w, I can't change the colors.

still no answer?


DOC: update brief documentation on visualization projects

[ X] passes git diff upstream/master | flake8 --diff

Minor Documentaion change to note that Vincent project has intentionally been abandoned and is not longer maintained.  Add a pointer to IPython Vega successor.

[Current coverage][cc-pull] is 84.33%

Merging [#13528][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master     #13528   diff @@
==========================================
  Files           138        138
  Lines         51107      51107
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          43103      43103
  Misses         8004       8004
  Partials          0          0

Powered by Codecov. Last updated by [9e73c71...b1fbee0][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/9e73c714433fe071a4441bf1e22dd6c01bd01717...b1fbee0fb810239f0c4d03ae10aef231e0a1d13d
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/13528?src=pr

Thanks!


Automated Package Upgrade

:tada: This PR is included in version 5.3.112 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


need import to path / how to use this with an remix.config.msj?

great library!
not sure if its itentional but I had to add
const path = require("path");

below the import statement to get this to work.
Also I tried to use this with a remix.config.msj but got all kinds of issues could you advice how I would use it correctly with a .msj extension? ( required for my mono repro ) <3

path is a node native package and in some environments they are included as globals but it's best not to rely on that – I will update the examples to include it explicitly
a .mjs file is for ES Modules (syntax would look like import { routeExtensions } from 'remix-custom-routes' whereas I have only packaged this for Common JS (syntax like const { routeExtensions } = require('remix-custom-routes')
I do plan on adding ESM support, which will make this work with .mjs files and should solve it for you, but I'm pretty new to packaging modules so I don't know how to do that yet.


Sentry 3.0 doesn't exist...

https://github.com/BootstrapCMS/Credentials/blob/master/composer.json#L32
https://packagist.org/packages/cartalyst/sentry
I might be doing something wrong but packagist isn't showing a 3.0 branch.
Thanks for making this package!

https://github.com/rweas/Credentials/blob/master/composer.json#L32
This seems to work so far.

I can create a PR if you would like.

You need to use my fork of sentry. Packagist says you shouldn't repackage forks, so the name remains the same.

Also, your suggestion on your fork is incorrect.

Thanks! I saw your fork but didn't think to use it.
On Fri, Feb 27, 2015, 1:44 PM Graham Campbell<EMAIL_ADDRESS>wrote:

Also, your suggestion on your fork is incorrect.
—
Reply to this email directly or view it on GitHub
https://github.com/BootstrapCMS/Credentials/issues/27#issuecomment-76458894
.


Inflate removing precision from Double

I'm using InflatePaths on a triangle, and using the PathsD format doesn't work properly. Using Paths64 and upscaling the polygon gives the expected result, a bigger triangle with 'rounded edges'
PathsD polyD = new PathsD();
PathsD resD;
Paths64 poly64 = new Paths64();
Paths64 res64;

polyD.Add(ClipperFunc.MakePath(new double[] { 218.57, 500, 618.57, 500, 218.57, 800 }));
resD = ClipperFunc.InflatePaths(polyD, 5, JoinType.Round, EndType.Joined);

poly64.Add(ClipperFunc.MakePath(new int[] { 2185700, 5000000, 6185700, 5000000, 2185700, 8000000 }));
res64 = ClipperFunc.InflatePaths(poly64, 50000, JoinType.Round, EndType.Joined);

resD:

res64:

The result using double is snapped into integer values, so I'm guessing this is caused by converting PathsD into Paths64 inside the InflatePaths function

H, try increasing the internal precision: PathsD polyD = new PathsD(15);

I did that and nothing changed. Wouldn't that line just set the initial capacity of the PathsD list?
I'm on C# btw

I think I found the source of the problem, it occurs when adding the pathsD to the ClipperOffset object.
public void AddPaths(PathsD paths, JoinType joinType, EndType endType)
{
	int cnt = paths.Count;
	if (cnt == 0) return;
		_pathGroups.Add(new PathGroup(ClipperFunc.Paths64(paths), joinType, endType));
}

It converts directly from PathsD to Paths64, rounding the values to an integer. It would need to use ScalePaths64() function that the ClipperD class uses in its addPaths:
public void AddPaths(PathsD paths, PathType polytype, bool isOpen = false) {
	base.AddPaths(ClipperFunc.ScalePaths64(paths, _scale), polytype, isOpen);
}

One fix would be making the conversion in the InflatePaths function:
public static PathsD InflatePaths(PathsD paths, double delta, JoinType joinType,
  EndType endType, double miterLimit = 2.0, int roundingDecimalPrecision = 3)
{
  if (roundingDecimalPrecision < -8 || roundingDecimalPrecision > 8)
    throw new ClipperLibException("Error - RoundingDecimalPrecision exceeds the allowed range.");
  double _scale = Math.Pow(10, roundingDecimalPrecision);
  double  _invScale = 1 / _scale;

  ClipperOffset co = new ClipperOffset(miterLimit);
  co.AddPaths(ScalePaths64(paths, _scale), joinType, endType);
  Paths64 tmp = co.Execute(delta);
  return ScalePathsD(tmp, _invScale);
}

This is an easy fix, but makes the handling of decimal precision inconsistent:
InflatePaths scales and converts PathsD prior to adding them.
BooleanOp adds PathsD and the conversion is done by the ClipperD class
Another option would be creating a ClipperOffsetD, like the ClipperD, which is consistent but a more complex fix.

Hopefully fixed now 😁.

Won't compile in Delphi Berlin ;-)
function AreaTriangle(const pt1, pt2, pt3: TPoint64): double;
begin
result := double(pt3.y + pt1.y) * double(pt3.x - pt1.x) +
double(pt1.y + pt2.y) * double(pt1.x - pt2.x) +
double(pt2.y + pt3.y) * double(pt2.x - pt3.x);
end;

I prefer to work with Delphi 6. Nostalgia.


VS1053 settings (Volume and Tone) are not saved in the ini file

Hi, first thank you very much for this awesome project.
The Volume and Tone settings  are not saved in the ini file, the ESP don't remeber them.
Thanks!

The Volume and Tone settings are not saved automatically.  In the ESP32 version they will be saved automatically.
You have to use the "save" button in the config page of the webinterface.  In the logging you should see:
D: FileRequest received /config.html
D: Response sent
D: Command: getnetworks with parameter 0
D: FileRequest received /radio.ini
D: Response sent
D: /radio.ini saved


Add support for pgp_keys when issuing a start_rekey

Also adds support for multiple keys to be passed to rekey via a new rekey_multi helper method, similar to the unseal_multi operation.
Integration tests pending.

:+1:


[SPARK-14210][SQL] Add a metric for time spent in scans.

What changes were proposed in this pull request?
This adds a metric to parquet scans that measures the time in just the scan phase. This is
only possible when the scan returns ColumnarBatches, otherwise the overhead is too high.
This combined with the pipeline metric lets us easily see what percent of the time was
in the scan.

Here's a screenshot of what this looks like.

Test build #54340 has started for PR 12007 at commit b17bac4.

Test build #54346 has started for PR 12007 at commit b1943cc.

Test build #54346 has finished for PR 12007 at commit b1943cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54346/
Test PASSed.

Merged build finished. Test PASSed.

Test build #54340 has finished for PR 12007 at commit b17bac4.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54340/
Test PASSed.

cc @sameeragarwal

cc @davies would be great if this can make it into our nightly perf run

LGTM, merging this into master.


Runs are exposed across contexts via the WES API

Describe the Bug
If a user has two MiniWDL contexts deployed in the same project, they can access the same set of runs via the /ga4hg/wes/v1/runs/{run_id} endpoint regardless of what context they use. It does not appear that the runs are bound to a given context. The run list endpoint works appropriately and only shows runs that have been submitted to the individual context
Steps to Reproduce

Create a new MiniWDL context (Not sure if this bug applies to other engines)
Run a workflow and record the run_id
Create a new MiniWDL context
Using the WES API for the new context, visit the GET /ga4gh/wes/v1/{run_id} where the run_id was from the previous run

Expected Behavior
The API to return a 404 status error indicating that the run does not exist
Actual Behavior
The Old RunLog from the previous context is returned
Screenshots

Additional Context
I am using the WES api directly

I agree, each context should have it's own APIGateway wes endpoint and it's own WES Adapter and that WES Adapter should not return information for runs that are not part of the same context.


Only call JSON.stringfiy during format if verbose option is specified

This will add a performance benefit, and prevent issue 196 in a production environment.

Can you push the changes to npm?

Has been addressed.


test_bad_stdout_specs vs writeable /

Describe the bug
One of our Outreachy participants, @SobiaAman, discovered that on WSL2, this test fails for them in make test:
===================================================================== FAILURES ======================================================================
______________________________________________________ test_bad_stdout_specs[nonexistent_dir] _______________________________________________________

spec = '/bad/dir/t.out'

    @pytest.mark.issue363
    @pytest.mark.parametrize('spec', speclist, ids=testids)
    def test_bad_stdout_specs(spec):
        """Testing bad stdout spec cases"""

        fn = echo_to_streams("Hello world", stdout=spec, stderr='t.err')

        try:
            fn.result()
        except Exception as e:
            # This tests for TypeCheckError by string matching on the type name
            # because that class does not exist in typeguard 2.x - it is new in
            # typeguard 4.x. When typeguard 2.x support is dropped, this test can
            # become an isinstance check.
            assert "TypeCheckError" in str(type(e)) or isinstance(e, TypeError) or isinstance(e, perror.BadStdStreamFile), "Exception is wrong type"
        else:
>           assert False, "Did not raise expected exception"
E           AssertionError: Did not raise expected exception
E           assert False

parsl/tests/test_bash_apps/test_stdout.py:54: AssertionError

This test assumes that / is not writeable and a permissions error can be tested by attempting to write to /.
This is not true in this user's case (and I have over the years experienced other unix environments where / is writeable, such as single-user-targeted OS X laptops).
To Reproduce
Run this test in an environment where / is writeable - for example, in a suitably disposable fileystem image, chmod a+w / and then run the test suite.
Expected behavior
This test should not be reliant on configuration of the / directory of the hosting environment.
Environment
WSL2
Recreateable in my containerized linux dev environment

Hello @benclifford
I have tried to surpass it for a while by replacing the Assert fail with the message istead so the code contiues testing without throwing Assertion Error.

this issue was also encountered in a container running flux, see issue #3159, so i changed the title away from WSL

a possible approach to fixing this test:
the test needs a directory that cannot be written. the assumption so far (which is wrong) is that / would be such a directory.
a different way to get such a directory would be to use the tmpd_cwd fixture to give you a temporary directory, then use os.chmod to make it non-writeable.
I'm not sure how that would fit into the way that the test is laid out - it might be better to move the non-writeable directory test out of the parameterized test test_bad_stdout_specs into its own separate test in the same file, so that the non-writeable directory mentioned above can be created there.

a possible approach to fixing this test:
the test needs a directory that cannot be written. the assumption so far (which is wrong) is that / would be such a directory.
a different way to get such a directory would be to use the tmpd_cwd fixture to give you a temporary directory, then use os.chmod to make it non-writeable.
I'm not sure how that would fit into the way that the test is laid out - it might be better to move the non-writeable directory test out of the parameterized test test_bad_stdout_specs into its own separate test in the same file, so that the non-writeable directory mentioned above can be created there.

@benclifford, based on your suggestions, I created two test cases to address the issue. The first test verifies the writability of a directory before attempting a write operation. The second test, test_write_to_non_writable_directory is designed to validate that it handles and raises exceptions when writing to such directories.
Despite these efforts and confirming the expected behavior locally, the CI run does not yield the expected BadStdStreamFile exception for the test_write_to_non_writable_directory case.

PR #3483 adds a pytest marker to disable tests affected by this issue


Fix for khcheck-storage template

This address https://github.com/Comcast/kuberhealthy/issues/895
Many of the variables referenced inside khcheck-storage failed with the following error:
Error: template: kuberhealthy/templates/khcheck-storage.yaml:24:23: executing "kuberhealthy/templates/khcheck-storage.yaml" at <.Values.check.storage.image.registry>: can't evaluate field Values in type interface {}
Error: template: kuberhealthy/templates/khcheck-storage.yaml:44:25: executing "kuberhealthy/templates/khcheck-storage.yaml" at <.Values.check.storage.resources.requests.cpu>: can't evaluate field Values in type interface {}
this due to helm not being able to render the variables correctly inside the given {{ range }}. The $ notation fixes this (ref: https://helm.sh/docs/chart_template_guide/variables/)
I was able to test this in my local env with the default values.yaml, except with the addition of:
`  storage:
external check from registry
https://github.com/ChrisHirsch/kuberhealthy-storage-check
**enabled: true**
# empty string indicate default storage class
# kubectl get storageclass
# or put storage class names into list
**storageClass: ["managed-premium"]**
runInterval: 5m
timeout: 10m
image:
  registry: chrishirsch
  repository: kuberhealthy-storage-check
  tag: v0.0.1
extraEnvs:
  CHECK_STORAGE_IMAGE: bitnami/nginx:1.19
  CHECK_STORAGE_INIT_IMAGE: bitnami/nginx:1.19
nodeSelector: {}
tolerations: []
#- key: "key"
#  operator: "Equal"
#  value: "value"
#  effect: "NoSchedule"
resources:
  requests:
    cpu: 10m
    memory: 50Mi`

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I was able to reproduce this error and confirm the fix.  Thanks @blame19 for addressing this.


docs(readme): update Arch Linux noting official package

I guess you made this package @alerque. Thanks a lot !
I am not familiar with the community package maintaining, will it update automatically on the next Cocogitto releases or
do you have to update the package manually ?
Also shall I remove the existing AUR packages ?

No it will not update automatically, I or another Arch Linux TU will need to bump it manually (and make any adjustments to accommodate upstream changes) when releases come out. I am subscribed to release notifications, but there is no harm in using the "Flag Package Out-of-Date" link on the package page when you tag a release as well.
I've submitted deletion requests for the redundant AUR packages (the VCS one is not redundant and should stay) but you can't delete them directly so no further action needed.


feat: forge inspect should show event topics

Component
Forge
Have you ensured that all of these are up to date?

[ ] Foundry
[X] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
No response
Operating System
None
Describe the bug
When using forge inspect to get methods, you get a list of methods and their identifiers.
$ forge inspect Ownable  methodIdentifiers

{
  "owner()": "8da5cb5b",
  "renounceOwnership()": "715018a6",
  "transferOwnership(address)": "f2fde38b"
}

But when using it to get events, you get a list of events - with their events string repeated...
$ forge inspect Ownable  events

{
  "OwnershipTransferred(address,address)": "\"OwnershipTransferred(address,address)\""
}

seems much more useful to return the topic (keccak) as value, instead of repeating the string representation.

Hi @drortirosh thanks for your suggestion
I agree that it would be more useful to display the hash than an escaped string (perhaps as eventIdentifiers to not break backwards compatibility?)
forge inspect simply introspects the artifact which does not contain this information directly but it looks like we are already doing this for errors
https://github.com/foundry-rs/foundry/blob/dad390189d0a2b3861e074f3d49d22c9e2e8fd7e/crates/forge/bin/cmd/inspect.rs#L130-L162

Hi @zerosnacks, I'd like to work on this issue


Replace usage of minUTxOValue with coinsPerUTxOByte

It was brought up by the audit that current implementation of paramsWellFormed is incorrect https://github.com/IntersectMBO/formal-ledger-specifications/blob/2e29cba60e5bbe4bbfa835ba73b976dd993b6bf6/src/Ledger/PParams.lagda#L102-L107
Instead of minUTxOValue in it should be using coinsPerUTxOByte, because minUTxOValue has been removed back in Alonzo era.
The only ticket that I could find ab out this is: https://github.com/IntersectMBO/formal-ledger-specifications/issues/162, which I think should have been taken care of properly and minUTxOValue should have been removed. It would have prevented it from being used in the current Conway specification.
Quick repo search also revealed that it minUTxOValue is also still used in the Utxo rule https://github.com/IntersectMBO/formal-ledger-specifications/blob/76ad4e9ba6ff84d7181d74e5e2dfc797ea45af4e/src/Ledger/Utxo/Haskell.agda#L104 which is also quite wrong

Yeah, there's a certain tension between historical stuff and new things. At some point we need to give in and deal with this properly, but it's best to do that as late as possible so that we don't need to duplicate a whole lot of work. And we have arguably more important things to work on still.
In this specific case I think replacing minUTxOValue with coinsPerUTxOByte everywhere is fine, and I guess we could even remove it. We'll just have to add it back later when we do previous eras.


Installer failed with exit code: 0x80070002 : The system cannot find the file specified.  (Microsoft.WingetCreate)

Brief description of your issue
Result of installing WingetCreate is
Installer failed with exit code: 0x80070002 : The system cannot find the file specified.
Steps to reproduce
Open powershell adminstrator cmd and execute:
winget install Microsoft.WingetCreate --verbose-logs
Expected behavior
Expected Microsoft.WingetCreate to be installed
Actual behavior
Installation fails.
Log is showing [FAIL] D:  ...
PC does not have a drive D:
WinGet-2022-06-08-15-25-02.762.log
Environment
Windows Package Manager v1.2.10941
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.1706
Package: Microsoft.DesktopAppInstaller v1.17.10941.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Hey @katdti,
Thanks for filing this issue. It is hard for us to know exactly what went wrong without more information. The best way to do that is to file a bug via Feedback Hub. Once we get your report, we'll be able to dive into the logs further and identify the problem.

@katdti we've released a newer version of wingetcreate. Can you reproduce this error?

Problem still exists with wingetcreate 1.1.2 and winget v1.4.2161-preview
Sources:
C:\Users\knr>winget source list
Name   Argument
---------------------------------------------
winget https://cdn.winget.microsoft.com/cache

Logs from running the command
winget install Microsoft.WingetCreate --verbose-logs
is attached:
WinGet-2022-08-09-08-19-26.956.log

@ryfu-msft do you have a bug for this at wingetcreate or do you understand the problem well enough with this Issue to fix it here?

It is unclear if this is a winget problem or wingetcreate package problem.
No - I have not a bug at microsoft/winget-create only a bug here at microsoft/winget-cli.

@katdti can you submit a  Feedback Hub report so we get logs to dig into?

Feedback submitted via Feedback Hub again.

Thank you.


use c8s as base system for pipelines

Is the available inventory the same as what we were using prior?

Which inventory are you talking about?

Hah, yea, that is a bit of an overloaded term. The available inventory of machines for our tests to run against over in ci.centos.org

Oh yeah, you mean the ones over at https://wiki.centos.org/QaWiki/CI/Duffy?
It's the same systems. Well, same rack/chassis, different blade.

Upstream, this should be the last place.
Downstream, this is also used and I have no idea what the pipelines run on (cc @pcreech @zjhuntin @Odilhao)


C-c M-J should inject figwheel-sidecar

No it shouldn't, because Clojure tooling is a train wreck that should probably be removed from this config entirely.


GraphNode resize not working

Godot version:
3.0.4-Mono
OS/device including version:
Windows 10 Desktop
Issue description:
The resize handles on the GraphNode don't seem to respond to mouse events, so GraphNodes cannot be resized
Steps to reproduce:
Create a GraphEdit with a GraphNode as a child. Check the checkbox for the GraphNode's resizable property in the inspector. Run the scene and try to resize the GraphNode.
Minimal reproduction project:
I can provide a project if really needed, but this is trivial enough to reproduce, I don't think it's necessary.

Click on your GraphNode in the editor
Switch to 'Node' tab (instead of 'Inspector')
Double click on 'resize_request(Vector2 new minsize) under GraphNode signals
A window opens, click ok (it will create a handler for the signal)
Write the resize procedure in the script ( for example : self.rect_size = new_minsize )

It lets you deal with resize events the way you want, maybe a default handler would be nice though


added decoding for special characters in git branch names

We are using branch names containing #, hence the missing possibility to encode these characters is a problem for us.
I propose this change, which lets the user use encoded special characters for the two characters used to split the branch name from the repo name.
Does this need to be documented in the Readme, or can we trust that smart software developers try encoding the characters according to standard URL encoding rules?

thanks for the report! posted https://github.com/tilt-dev/tilt-extensions/pull/497 as an alternative

actually, i changed my mind, i like this pr better. can you add a test case for it under ./test?

Test cases added. Also decided to add one sentence to the Readme. In case you do not like it I can remove the Readme-Commit.
Anyway, I am glad to solve my problem and contribute to the project. My first time pushing code to an open source repo. :)


Regenerating SDKs following introspection of schemas.

#210  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JasonCWang and the rest of your teammates on  Graphite

Merge activity

Oct 10, 12:33 PM EDT: A user merged this pull request with Graphite.


Fix goto attr def from attr def itself, add test cases on goto-def and find-refs

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[X] Y

close #754
It turns out the the find refs failed from the schema attribute def, is caused because the goto-def ignored the case when goto-def from schema attr def. Thanks to @He1pa we fixed the bug and added more tests on it.

2. What is the scope of this PR (e.g. component or file name):

the fix:

kclvm/tools/src/LSP/src/util.rs

the tests:

kclvm/tools/src/LSP/src/find_refs.rs
kclvm/tools/src/LSP/src/goto_def.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Fix goto attr def from attr def itself, add test cases on goto-def and find-refs

[X] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[X] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[X] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

61 of 62 (98.39%)  changed or added relevant lines in 3 files are covered.
26 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-16.8%) to 71.265%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/tools/src/LSP/src/find_refs.rs
44
45
97.78%

Files with Coverage Reduction
New Missed Lines
%

compiler_base/session/src/lib.rs
26
58.06%

Totals

Change from base Build<PHONE_NUMBER>:
-16.8%

Covered Lines:
36308

Relevant Lines:
50948

💛  - Coveralls


Inconsistent boolean GET parameters

From https://api.tumblr.com/console/calls/blog/posts, to include reblog info in each post I can do this:
client.posts('staff.tumblr.com', reblog_info=True)

In practice I have to do this:
client.posts('staff.tumblr.com', reblog_info='true')

because pytumblr adds uppercase boolean values as GET parameters ('True'), which the Tumblr API ignores.

This no longer seems to be a problem, both True and 'true' are including the reblog info


Nodejs API - __dirname is not defined

I'm unable to get Kuzu working from Nodejs Api, to be used in conjunction with a React application.
My high-level setup is the following one:

Windows 10
Node 20.1
Vite 5.0.12 + React 18.2.0
Kuzu 0.3.2

Whenever I try importing the module I get:
Uncaught ReferenceError: __dirname is not defined
    at node_modules/kuzu/kuzu_native.js (kuzu.js?v=8343ca34:51:27)
    at __require (chunk-Y2F7D3TJ.js?v=92c3fae6:3:50)
    at node_modules/kuzu/connection.js (kuzu.js?v=8343ca34:254:22)
    at __require (chunk-Y2F7D3TJ.js?v=92c3fae6:3:50)
    at node_modules/kuzu/index.js (kuzu.js?v=8343ca34:585:22)
    at __require (chunk-Y2F7D3TJ.js?v=92c3fae6:3:50)
    at kuzu.js?v=8343ca34:605:16

Probably I'm missing something, but I wanted to point this out just in case it is a bug.

Hi @fedehann,
Could you please share more details about your setup or upload a minimal reproducible example?
Thanks.

I did a quick test and the API seems to work fine for me on Windows in the Node.js REPL v20.2.0:
PS C:\test-kuzu-js> npm i kuzu

> kuzu = require('kuzu')
undefined
> db = new kuzu.Database('./test')
Database {
  _database: NodeDatabase {},
  _isInitialized: false,
  _initPromise: null
}
> conn = new kuzu.Connection(db)
Connection {
  _database: Database {
    _database: NodeDatabase {},
    _isInitialized: false,
    _initPromise: null
  },
  _connection: null,
  _isInitialized: false,
  _initPromise: null
}
> conn.query('RETURN 1').then(res => res.getAll()).then(console.log)
Promise {
  <pending>,
  [Symbol(async_id_symbol)]: 1100,
  [Symbol(trigger_async_id_symbol)]: 1099
}
> [ { '1': 1 } ]
>

Thank you @mewim, I confirm that I also have no problem executing the code directly from Node.
Probably it has something to do with Vite + React.
I generated the base template using:
npm create vite@latest my-app -- --template react
Then I installed Kuzu in the project folder:
npm i kuzu
Here is the code of the React entry point (App.jsx).
The error is triggered directly by the import phase.
import { useEffect } from 'react'
import './App.css'
import * as kuzu from 'kuzu'

function App() {
  // useEffect(async () => {
  //   const db = new kuzu.Database("./demo.db");
  //   const conn = new kuzu.Connection(db);

  //   const queryResult = await conn.query("RETURN 1");

  //   // Get all rows from the query result
  //   const rows = await queryResult.getAll();

  //   // Print the rows
  //   for (const row of rows) {
  //     console.log(row);
  //   }
  // })

  return (
    <>
    </>
  )
}

export default App

I see the issue. It seems that your are trying to import kuzu into your frontend. Note that the Node.js bindings of kuzu is backend module. It only works for Node.js but not in browser. A WebAssmbly version might come later this year: https://github.com/kuzudb/kuzu/discussions/3327.

Got it, thanks!


Questions about camera intrinsics

Hi, @AAnoosheh ,
I use your test code and pretrained model to test my own testset, which is a little bit different from Oxford dataset, because mine contains more grasses and trees, and the buildings may look diferent. The night-to-day transformation results seem unsatisfying.
Since you mentioned that 'Because of sesitivity to instrinsic camera characteristics, testing should ideally be on the same Oxford dataset photos ', so how does the intrinsic influence the night-to-day transformation result? How can I change the camera intrinsic in the code?
Really hope to get your reply. Thanks in advance!

Hi,
The instrinsics refer to camera lens shape, distortion, color range, motion blur, FOV, etc., and these cannot be changed via code, unfortunately.
You would need to retrain on your dataset, since the camera used in the Oxford dataset produces very unique images, and neural networks are highly sensitive to changes in the aforementioned image statistics.
Best,
Asha


DXCDT-326: align --number usage across commands

🔧 Changes
Aligns the usage of the --number flag across commands to be consistent and show the relevant description in each help screen
📚 References
🔬 Testing
📝 Checklist

[x] All new/changed/fixed functionality is covered by tests (or N/A)
[x] I have added documentation for all new/changed functionality (or N/A)

Great first contribution 👍🏻 @ewanharris 🥳


[jax2tf] Add input and output names to the TensorFlow graph generated by jax2tf.

Can you please give some background for this change? Is this to help with profiling or for some other graph inspection?
Is there a standard practice for doing something like this in TF? I am asking because depending on how this is used, it has the potential to become part of the requirements for jax2tf.convert, and I'd like to understand those requirements.

Peter is OOO this week but I can provide some more context.
The goal is to allow graph inspection and manipulation (e.g. prune the resulting TF graph between input and output tensors).
Currently we are using tf.function to extract a graph, and this provides names for input tensors (in the form arg_{idx}_{n} iirc) but not outputs (although I suspect if we look hard enough we can find output tensor names).
Peter and I wanted to ensure that the name matching was indeed a supported part of the public API that we were using and it was not clear if this was a supported part of tf.functions contract (although I suspect it is). It seemed "cleaner" to do this in jax2tf regardless.
We did discuss whether we could simply do this "around" jax2tf.convert (e.g. in another library). This would be possible, but is slightly complicated by the custom gradient registered by jax2tf (which we cannot decorate/wrap). We currently do not need the gradient for our use case so this is not a blocker, but we felt that on balance it was a useful feature for jax2tf users so wanted to upstream.
No worries if this is not a part of the public API you want to commit to, we can use a similar approach in a wrapper function to name function inputs/outputs and then solve "the gradient problem" in the future if we need to.

Thanks for the explanation.
Since the use case seems to be something that would apply to a tf.function even if not coming from jax2tf, I feel that it would be best if we can use existing TF mechanisms for this, with the vision that jax2tf produces something that behaves as if it was written with TF, and can be processed with existing TF mechanisms.
If it is more expedient to make this change, let's do that now, but keep this behavior undocumented, hoping that we can remove it, or replace it with an expanded naming metadata mechanism (which we are thinking of doing anyway, for visibility in xprof and such).
I will wait for your answer, and then I am ready to merge this change.

@petebu I think that now is a good time to merge this. Servomatic will also use this mechanism to do some static analysis for the jax2tf models.

@petebu I think that now is a good time to merge this. Servomatic will also use this mechanism to do some static analysis for the jax2tf models.


[Bigtable] Expose BigtableClientImpl constructor

Oh, I hadn't considered that. It will probably be cleaner. I'll make the change in a new commit here so we can see how it looks.

Actually, it will require a few other changes, but I think it will end up cleaner in the end.

Yes, I definitely think it should be internal if possible. IIRC, you can ask Moq to treat properties like a stub, so you can just set the property on the mock, and the code fetching it will see that value.
But could the code that applies the AppProfileId be part of BigtableServiceApiClient instead of BigtableClient, when modifying requests? That would be nice in terms of it being part of BigtableServiceApiSettings. We definitely can modify the requests there - is there any reason we'd particularly not want to? We could expose the AppProfileId as a property for inspection in BigtableServiceApiClient too (and delegate to it in BigtableClient). I think it would be worth copying it from the settings on construction rather than letting it change over time.
As an aside, it's unclear to me whether it's worth getting the first commit of this PR merged and then deciding the AppProfileId part separately. If you want to do that, I'm fine with it - but they may be sufficiently interlinked that it's not worth it.

Oh yeah, that's much cleaner. Thanks!
I think I'd prefer to do it all now because they are quite interlinked. And I'd rather not change and expose the ...Impl constructor just to then change it again.

PTAL

Thanks Jon! Yes, I like the way this turned out. I'll merge on green.

Thanks for all the back and forth - I think we've come to a better solution than either of us would have reached on our own :)


Feat: New services part 3

Note

All templates with (tested and works) have been tested and fixed by myself and are now fully functional
This PR does not only include PRs from contributors, I also added some templates myself.
Templates form myself are: Freshrss Postgres, Freshrss MariaDB, Freshrss MySQL, Nextcloud MariaDB, Nextcloud MySQL

Changes

Fix: Nexctcloud
Fix: Glitchtip
Add CloudBeaver (tested and works)
Add Freshrss sqlite (tested and works)
Add Freshrss Postgres (tested and works)
Add Freshrss MariaDB (tested and works)
Add Freshrss MySQL (tested and works)
Add Traccar (tested and works)
Add Vvvweb (tested and works)
Add Vvvweb MariaDB (tested and works)
Add Vvvweb MySQL (tested and works)
Add Nextcloud with Postgres (tested and works)
Add Nextcloud with MariaDB (tested and works)
Add Nextcloud with MySQL (tested and works)
Add Kimai (tested and works)
Add ntfy (tested and works)
Add qbittorrent (tested and works)
Add Homebox (tested and works)
Add Cryptgeon
Add Unsend

@cupcakearmy I think you are the creator of Cryptgeon it seems to have some problem I always get this error:
Note could not be be created.
Please try again.

Can you please deploy it via this file https://github.com/coollabsio/coolify/blob/b10a22960f749edf3682e35a654826b1a72a2bae/templates/compose/cryptgeon.yaml and tell me what is missing? Do we need a volume mount or no?


datahub-ingestion not support sudo!

The docker image of "linkedin/datahub-ingestion:head" does not support the user of datahub to run SUDO privilege.
How can I run "apt-get install" ?
In order to solve the problem, I have to build my own docker image from zero.
The build costs several hours.
The image is so complex and large, we need more privilege to custom it!

The linked issue suggested a workaround which should be sufficient for this. Please create a new issue if this is not solved.


Update EOS license year 2019

Fix license of use,
update 2019;
Format ISO 8869-1;
in Memoriam Guto Schiavon

R.I.P pioneer and friend.
#ripGUTO

@larryk85
thank you.


Rule expressions are case insensitive

How to achieve case sensitive string comparison in rule expression.
Example, object1.Name == "SAM" and object1.Name == "sam" should be treated differently for my scenario.
Appreciate any suggestions.

Can you share the version of RulesEngine you are using ?
Also string.Equals(object1.Name,"SAM") should be case sensitive. Let me know if this works.

Thanks for your response. I use RulesEngine 4.0.0. I tried with the way you suggested. This also behaves as case insensitive.


Can't build in Angular with errors in types/postprocessing.d.ts

I'm having issues with building after including the EffectComposer.
I assume I'm doing something wrong because I haven't found any results about this. But I have no idea where to look, the error is as follows:
In an empty Angular project I install three, @types/three and postprocessing.
import {EffectComposer} from 'postprocessing' triggers the following errors:
'fullscreenMaterial' is defined as an accessor in class 'Pass', but is overridden here in 'AdaptiveL
uminancePass' as an instance property.
'fullscreenMaterial' is defined as an accessor in class 'Pass', but is overridden here in 'CopyPass'
 as an instance property.
'fullscreenMaterial' is defined as an accessor in class 'Pass', but is overridden here in 'DepthCopy
Pass' as an instance property.
... and many more

Does someone know where I have to look?

Reverting back to version 6.25.0 (last one without type files) and declaring postprocessing as a module allows me to compile the project. Not really a solution though.

There's has to be something wrong with your setup. Any chance you could provide a repository with a minimal reproduction of the issue?

Thanks for your reply @vanruesc , it happens in an empty Angular project with the steps I mentioned above.

I've had the same issue, but not while using Angular. I'm using threejs 0.143.0, which is currently the latest release, and I'm also using `"@types/three": "^0.143.0".
My full dependencies are as follows:
	"devDependencies": {
		"@types/three": "^0.136.1",
		"autoprefixer": "^10.4.0",
		"prettier": "^2.5.0",
		"sass": "^1.43.5",
		"typescript": "^4.3.2",
		"vite": "^2.6.14"
	},
	"dependencies": {
		"path": "^0.12.7",
		"three": "^0.136.0",
		"lil-gui": "^0.16.0",
		"vite-plugin-live-reload": "^2.1.0"
	}

The types have been updated and validated in<EMAIL_ADDRESS>Please check again if the reported issue still persists.

Good news: no more errors for me, personally, upon updating to<EMAIL_ADDRESS>Thanks for the update!

Closing this as it seems to be resolved.


修复metrics搜索白屏的BUG

路由跳转错误，正确的应该是/metrics/index

Codecov Report

Merging #614 into develop will increase coverage by 0.14%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #614      +/-   ##
=============================================
+ Coverage      21.44%   21.58%   +0.14%
- Complexity       315      318       +3
=============================================
  Files             88       88
  Lines           3516     3516
  Branches         557      556       -1
=============================================
+ Hits             754      759       +5
+ Misses          2684     2679       -5
  Partials          78       78

Impacted Files
Coverage Δ
Complexity Δ

...apache/dubbo/admin/service/RegistryServerSync.java
92.53% <0.00%> (+7.46%)
22.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cb785...501dad9. Read the comment docs.


Emit larger chunks

We have an application which performs better when the stream is built from larger underlying fs2 chunks.  The current implementation always emits chunks of size 1.  This PR changes it to emit chunks comprising all remaining buffered messages.
It is almost a completely non-breaking change from point of view of users of the library.  I think there is one very subtle change in behaviour: the user-provided errorHandler callback will now get called for all messages in the chunk before the chunk gets emitted downstream.  It's because I've used evalMapChunk, which is not lazy on every single element.
For most users, I would guess the benefits of larger chunks will outweigh the non-laziness of the error handler callback.
Try it out with:
    PubsubGoogleConsumer
      .subscribe[IO, Array[Byte]](blocker, projectId, subscription, errorHandler, config)
      .chunks
      .evalTap { chunk =>
        IO.delay(println(s"size: ${chunk.size}")) *> IO.sleep(5.seconds)
      }

Thanks @istreeter, this is a good change I think! Certainly using the drainTo alone would be worth it. @CremboC (who wrote this library originally) actually made the PR which added evalMapChunk to fs2 (https://github.com/typelevel/fs2/pull/1793), so we do know it can be a big performance win! This library came first though...
If it's alright I'm going to re-open this against the master branch, and will backport to CE2. The PR will be basically the same, I've just avoid a collection conversion from List to Chunk. I agree that this isn't actually really a breaking change, so we can probably be cheeky and cut a patch release of the CE2 branch...

Hi @bastewart - it's certainly ok with me if you rebase it and backport to CE2.  I was just being lazy, because I had only tested the CE2 version.

the user-provided errorHandler callback will now get called for all messages in the chunk before the chunk gets emitted downstream

On this I think that is fair as well. Generally either the user will decide to terminate their app (potentially after n failures) or record some metric. Worse-case is previously they would have successfully process an element which they now don't because the app died earlier than needed, but as long as they didn't ack it the element should be redelivered anyway...
Btw @istreeter do you have any kind of numbers for the app you changed this in? Like throughput increase and a rough description of what it does? We actually run the HTTP variant exclusively in prod so don't have a way to test this. It does definitely look like it should be an improvement though.
Also in the past the PubSub emulator didn't work with the Java library (🤦) so we don't have local benchmarks. That might have changed now (https://github.com/googleapis/google-cloud-java/issues/2248), so we could add some.

Hi @bastewart , I'm a colleague of @istreeter.

do you have any kind of numbers for the app you changed this in?

Our app is reading from PubSub, doing some transformation, and writing data to another PubSub topic.
On a small machine with 2 CPUs and 1GB of memory we went from 55 000 events / minute to 65 000 when using chunks.

I'm happy to close this PR in favour of #330, which is much neater than what I submitted!


Roller blind E1766 and E1757 are now managed as percent roller blind

Create a switch to manage percent roller blind in the plugin.
Use this new switch for Ikea E1766 and E1757 products

Thanks!


Fix storm.py which breaks when client.jartransformer.class is not set

When such configuration is not set, confvalue returns nil in 1.x branch, and null in master branch.
Such difference is based on whether language storm script runs:

for 1.x, it runs org.apache.storm.command.config_value which is Clojure file
for master, it runs org.apache.storm.command.ConfigValue which is Java file

I accidentally changed that value from nil to null without recognized the difference between master and 1.x.
Since it breaks all deployments on 1.x branch when client.jartransformer.class is not set, so it must be fixed before releasing.

+1


[error handling]: REPL should catch and report exceptions instead of crashing the process

If you manage to trigger some exception from the invoke> prompt, it currently prints the traceback and crashes the whole process.
It should act more like ipython does, where it shows you the exception but if it's at all possible, leave the process running and ready to accept a new command.

Mostly the CLI does catch exceptions that occur during the generation process, but it crashes out if it gets something truly unrecoverable like being unable to load any models. Please indicate how you got the crash and I'll address.


Pointer initialization. Fixes #382 and #381

Close #382
Close #381

This change is

Reviewed 5 of 5 files at r1, 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

tests/cast.c, line 43 at r2 (raw file):

	assert(f == NULL);
	char   *c = (char   *) 0;
	assert(c == NULL);

Please use is_ok(c == NULL) instead so that only the assert.c tests need to use assert.h. Also we can guarantee that is_ok will work, assert may be disabled and we would not know if this would fail in the future.

tests/if.c, line 28 at r2 (raw file):

		pass("%s", "NULL is zero");
	} else {
		pass("%s", "NULL is not zero");

Use fail instead. Neither the C or the Go should reach in here.

tests/if.c, line 32 at r2 (raw file):

	if ( ! NULL) {
		pass("%s", "Invert : ! NULL is zero");

Use fail instead. Neither the C or the Go should reach in here.

Comments from Reviewable

This is a great PR :thumbsup:

Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

Review status: 6 of 9 files reviewed at latest revision, 3 unresolved discussions.

tests/cast.c, line 43 at r2 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
Please use is_ok(c == NULL) instead so that only the assert.c tests need to use assert.h. Also we can guarantee that is_ok will work, assert may be disabled and we would not know if this would fail in the future.

done

tests/if.c, line 28 at r2 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
Use fail instead. Neither the C or the Go should reach in here.

done

Comments from Reviewable

Reviewed 3 of 3 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Push history state from frame navigations

Closes https://github.com/hotwired/turbo/issues/50
Closes https://github.com/hotwired/turbo/issues/361
Closes https://github.com/hotwired/turbo/pull/167

Extend of built-in support for  elements with data-turbo-action
(with "replace" or "advance") to also encompass <turbo-frame>
navigations.
Account for the combination of of [data-turbo-frame] and
[data-turbo-action] to navigate the target <turbo-frame> and
navigate the page's histroy push state, supporting:

turbo-frame[data-turbo-action="..."]
turbo-frame a[data-turbo-action="..."]
a[data-turbo-frame="..."][data-turbo-action="..."]
form[data-turbo-frame="..."][data-turbo-action="..."]
form[data-turbo-frame="..."] button[data-turbo-action="..."]
form button[data-turbo-frame="..."][data-turbo-action="..."]

Whenever a Turbo Frame response is loaded that was initiated from one of
those submitters, forms, anchors, or turbo-frames annotated with a
[data-turbo-action], the subsequent firing turbo:frame-render event
will create a Visit instance that will skip rendering, won't result in
a network request, and will instead only update the snapshot cache and
history.

I'd like to use this, but in my case I'm navigating the frame by setting the src attribute from a Stimulus controller. Do you think this should/could be included?

I'd like to use this, but in my case I'm navigating the frame by setting the src attribute from a Stimulus controller. Do you think this should/could be included?

@mhw  clicks and <form method="get"> submissions both result in modifying the frame's src attribute, which ends up using the same code paths as something like FrameElement.src = or frame.setAttribute("src", ...). Does that cover your use case?

Ah yes, yes it does. I can put the URLs in hidden links with the right attributes and click() those from JavaScript. I'm having an issue with it not working in some cases, but I think that's going to be due to something in my code. It looks to be working well though.

FYI, one developer suggested the turbo should have the following convention to navigate frames using js (I thought was a good idea).
Turbo.visit(location, { frame: 'frameId' })

Something like this might solve this issue, and provide a new way to navigate frames:
see: https://discuss.hotwired.dev/t/navigate-with-js/3215/5

Hmm; this is working well for me in the case where the link is within a turbo-frame element, but I found it wasn't working when the link is outside of any turbo-frame. Part of my HTML looks roughly like this:

Label
scalar Url

<turbo-frame id="frame"></turbo-frame>

When the details element is opened a Stimulus controller activates the link in the summary element with click() and the frame contents load, but the URL isn't updated.
I've dug into the Turbo implementation and found that in this case the link clicks are being captured by the LinkInterceptor attached to the html element, rather than one attached to a turbo-frame element. As a result they are handed off to FrameRedirector instead of FrameRenderer. But I'm not sure if there should be further events triggered following this that lead to the changes in this PR.
I then looked at the functional tests you've added to see when I'd missed, and just got baffled further. I can see that the test navigating frame with a[data-turbo-action=advance] pushes URL state test passes when run by intern, but if I run yarn run start, browse to http://localhost:9000/src/tests/fixtures/frames.html, and then click the Navigate #frame with data-turbo-action="advance" link, then the turbo-frame navigates but the URL does not update.
I expect the issue is at my end somewhere, but any suggestions would be gratefully received.

That's great - with those changes it's working nicely for me now. Good spot on the duplicated id in the test fixture: I thought I'd looked everywhere, but missed that.
I tried out your suggestion of using the loading="lazy" attribute, but the code path that uses when the frame becomes visible (elementAppearedInViewport -> loadSourceURL -> visit) doesn't hit the changes in this PR and so it doesn't update the URL.
That said, I'm not sure loading="lazy" should be in scope of this PR. It feels different somehow from updating the URL in response to a form submission or link click.

That's great - with those changes it's working nicely for me now. Good spot on the duplicated id in the test fixture: I thought I'd looked everywhere, but missed that.

I'm happy to hear it suits the needs of your use case!

I tried out your suggestion of using the loading="lazy" attribute, but the code path that uses when the frame becomes visible (elementAppearedInViewport -> loadSourceURL -> visit) doesn't hit the changes in this PR and so it doesn't update the URL.

Did you also add the [data-turbo-action="replace"] attribute to the lazily-loaded frame? I was hoping that all frame loading code paths traversed the portion that checks for data-turbo-action.

Did you also add the data-turbo-action="replace" attribute to the lazily-loaded frame? I was hoping that all frame loading code paths traversed the portion that checks for data-turbo-action.

I did: here's the turbo-frame element I've tried:
<turbo-frame loading="lazy" data-turbo-action="replace" id="frame_57" src="/frame/57">
...
</turbo-frame>

Good to proceed with this @seanpdoyle, if you want to square the merge conflict.

@seanpdoyle how do you cover this case described in #167:

You can also manually override the URL to whatever value you may need:
<turbo-frame id="history">
 Show messages
</turbo-frame>

In my case, I want to refresh the content of the frame with a different URL than the one that should be promoted to the navigation bar.


Hitting limits of the Google geocoder api

I may try switching us to bing instead which has higher limits and is also a bit faster.

I haven't seen this issue in  the past month but I haven't done any further work on it.

Well, it looks like the address limits are 2,500 addresses per day according to the Google page. Considering the way that the app is constructed now, I'd find it hard to imagine us hitting that limit anytime soon. This merits a close unless something changes, IMO.


Improve OBI documentation

Building on #1046, we are always saying that we need better docs.

Discussed 2019-10-28. Damion will continue work on this through upcoming months.


fix(default-theme): remove button on product page

Changes

removed save for later button
removed add to compare button
removed unnecessary SwButton import component

Checklist

[x] I followed contributing guidelines

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Krecik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

related #864, #865


Some resources don't display

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[✓ ] I have read the wiki page and cheat sheet, but there is no information I need.
[✓ ] I have searched in existing issues, but did not find a same one.
[ ✓] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
Some images aren't display on the image view, after using "kf.setImage" we got imgview.image = nil
What
We have set of images most of them are equal in size and dimensions, but not all of them are displaying using kingfisher however they are displaying correctly on the browser.
This image displays correctly: https://storage.googleapis.com/gorillainc/tshirt2.jpg
This not: https://storage.googleapis.com/gorillainc/tshirt3.jpg
[Tell us about the issue]
Reproduce
This is the code we use, we put it in cell for row
let newUrl = URL(string: "https://storage.googleapis.com/gorillainc/nike_sweatshirt1.jpg")
self.shopImageView.kf.setImage(with: newUrl)
[The steps to reproduce this issue. What is the url you were trying to load, where did you put your code, etc.]
Other Comment
[Add anything else here]

Although this image (https://storage.googleapis.com/gorillainc/nike_sweatshirt1.jpg) contains a JPEG extension, actually it is a webp image. Kingfisher does not support webp internally, maybe you need some external library to load it. See this for more.
Or you can ask your server to convert the image to a widely supported format, like JPEG or PNG.


Unable to merge image and audio (mp3) input to an video output (mp4)

I want to combine an image and an audio file to create a video output.
I'm able to do it from command line:
ffmpeg -loop 1 -i /tmp/image.jpeg -i /tmp/audiot.mp3 -vf 'scale=320:trunc(ow/a/2)*2' -acodec  libvo_aacenc -b:a 192k -shortest /tmp/output.mp4
But when  I'm trying to implement the same behavior using ffmpeg-cli-wrapper java, the program just keeps running indefinitely.
If I try the same program without setting -loop 1, then it executes successfully but only converts audio to video and ignores the image.
I couldn't find any example for this online. If someone knows how to implement this behavior, please let me know.
I have attached my sample test java program.
Test.txt

I ran your sample program, and it does indeed run indefinitely, however, when it does the same if ran directly from the command line. So this is not a limitation of this library, but a misuse of ffmpeg.
However, you have two options to fix this. Either:

Set a duration, "-t 30", and the video will end up being 30 seconds long

FFmpegBuilder builder = new FFmpegBuilder()
    ...
    .addOutput(Samples.output_mp4)
    .setDuration(30, TimeUnit.SECONDS)
    ...

Or add the "-shortest" flag, in which case the video will be the length of the shortest input, which should be the length of your audio track.

FFmpegBuilder builder = new FFmpegBuilder()
    ...
    .addOutput(Samples.output_mp4)
    .addExtraArgs("-shortest")
    ...


WIP.

This change is

#462  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 12.14953% with 94 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@724ac68). Learn more about missing BASE report.

Files
Patch %
Lines

crates/gateway/src/config.rs
6.93%
94 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage        ?   78.63%
=======================================
  Files           ?       37
  Lines           ?     1802
  Branches        ?     1802
=======================================
  Hits            ?     1417
  Misses          ?      308
  Partials        ?       77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

replaced with: https://github.com/starkware-libs/sequencer/pull/27


Larger queries hanging

Using the example from the snowflake-api README, I'm finding that relatively small queries are working fine, but when I run a larger query (larger in terms of resultset size) it seems to hang and never return with the results. I can see from the snowflake console that the query finishes successfully, relatively quickly (couple seconds), so shouldn't be a timeout issue.
Any ideas? Is there any known limitation to the 'undocumented' API like this? The same query is working fine through other tools like DataGrip (which I think is going through JDBC?)
Also had the same problem with another rust crate: snowflake-connector-rs, which I think is using the same undocumented API.

Could you somehow make a reproducible example? Maybe some more details on expected result size (lines, bytes), what cloud you're deployed on, etc.
A set of queries will suffice, eg:
CREATE OR REPLACE TABLE ...;
INSERT INTO ...; -- with generator
SELECT FROM ...;

You can also run try running the example the query with trace level set RUST_LOG=trace cargo run --example run_sql, which will give more information of what's happening under the hood.

Not sure if this is a related issue. The fork that I am using has problems with long-running queries. Here is an example query that takes 2 minutes in my warehouse. You can add/remove 0's to make it slower/faster as needed.
WITH RECURSIVE Compute_CTE AS (
    SELECT 1 AS n
    UNION ALL
    SELECT n + 1
    FROM Compute_CTE
    WHERE n < 10000000
)
SELECT SUM(n)
FROM Compute_CTE

@milevin I took a look and it appears that when Snowflake detects that query will run much longer than an http timeout it'll return a handle instead, which you can poll to get the result. This isn't implemented yet and it should've been erroring out as that type of response the library shouldn't be able to parse correctly.
I was looking to at least add proper parsing for that kind of reply, but supporting for async (on the snowflake side) queries is not that trivial.
If you want to take a shot I think https://github.com/mycelial/snowflake-rs/pull/38 is a good place to start, after you've gotten the handle it needs to be polled until the result is available, which will come in the same format as other results.

@andrusha, great. We will look into this. cc: @xuliangs


Run jobs from a git repo

This feature should feel similar to the way you can go get a library in golang.
One question that we should think about is how we're going to do versioning in this system.

Can we close this since this is the default on master now?

Yup.


Emit "onClickDetailIcon" when user clicks the icon in detail panel

Emit "onClickDetailIcon" when user clicks the icon in detail panel.
Add also add triggerOnRunAfterOnClickDetailIcon to catalog entity metadata.labels to avoid breaking changes. (Both WebLink.metadata.labels.triggerOnRunAfterOnClickDetailIcon and KubernetesCluster.metadata.labels.triggerOnRunAfterOnClickDetailIcon are set to "true")
Add prettier to be able to use .toMatchInlineSnapshot()

I don't understand the need for this but instead of adding onClickDetailIcon can't you add something to the run context that lets onRun determine if the icon was clicked? Breaking change?

I don't understand the need for this but instead of adding onClickDetailIcon can't you add something to the run context that lets onRun determine if the icon was clicked? Breaking change?

That would also be a possible solution. However, according to @msa0311 this is desirable to happen on attempts for onRun. So from that POV the name of even this proposed function is wrong.

I don't understand the need for this but instead of adding onClickDetailIcon can't you add something to the run context that lets onRun determine if the icon was clicked? Breaking change?

Because we need to add the hooks to onRun via extension, from extension there is no way of changing onRun...


fix: add fallback for step metrics

Fix for the following error:
Traceback (most recent call last):
  File "/Users/me/Desktop/Projects/project/.venv/bin/openai", line 8, in <module>
    sys.exit(main())
  File "/Users/me/Desktop/Projects/project/.venv/lib/python3.10/site-packages/openai/_openai_scripts.py", line 63, in main
    args.func(args)
  File "/Users/me/Desktop/Projects/project/.venv/lib/python3.10/site-packages/openai/cli.py", line 527, in sync
    resp = openai.wandb_logger.WandbLogger.sync(
  File "/Users/me/Desktop/Projects/project/.venv/lib/python3.10/site-packages/openai/wandb_logger.py", line 73, in sync
    fine_tune_logged = [
  File "/Users/me/Desktop/Projects/project/.venv/lib/python3.10/site-packages/openai/wandb_logger.py", line 74, in <listcomp>
    cls._log_fine_tune(
  File "/Users/me/Desktop/Projects/project/.venv/lib/python3.10/site-packages/openai/wandb_logger.py", line 162, in _log_fine_tune
    step = metrics.pop("step")
KeyError: 'step'

should be fixed in the latest version. could you try downloading the latest package?

Hello! I have the same problem and I have just dowloaded the latest version.

We'll be releasing the latest patch today on pypi.  In the meantime: if you'd like to test out the change, you'll need to git clone this repo and install it from source.

0.26.3 is live!


react-native 0.69.9  ios 11  crash

Description
crash info
dyld: Symbol not found: __ZNSt19bad_optional_accessD1Ev
Referenced from: /private/var/containers/Bundle/Application/18A8216C-D9DE-4985-A873-5B90C503041C/OPTapp.app/Frameworks/CoreModules.framework/CoreModules
Expected in: /usr/lib/libc++.1.dylib
in /private/var/containers/Bundle/Application/18A8216C-D9DE-4985-A873-5B90C503041C/OPTapp.app/Frameworks/CoreModules.framework/CoreModules
(lldb)
React Native Version
0.69.9
Output of npx react-native info
System:
OS: macOS 13.2.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 97.16 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
Yarn: 1.22.17 - ~/.yarn/bin/yarn
npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK:
API Levels: 18, 19, 23, 25, 26, 27, 28, 29, 30, 31, 32, 33
Build Tools: 23.0.3, 26.0.2, 28.0.3, 29.0.0, 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0
System Images: android-23 | Google APIs ARM EABI v7a, android-25 | Google APIs ARM EABI v7a, android-29 | Google Play Intel x86 Atom, android-31 | Google APIs Intel x86 Atom_64
Android NDK: 22.1.7171670
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8512546
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 11.0.11 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.9 => 0.69.9
react-native-macos: Not Found
Steps to reproduce
Create a sample 0.69.9 project running on an ios11 phone that will reproduce
Snack, code example, screenshot, or link to a repository
Create a sample 0.69.9 project running on an ios11 phone that will reproduce

System:
OS: macOS 13.3.1
CPU: (8) arm64 Apple M1
Memory: 126.73 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 8.18.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
Android SDK:
API Levels: 23, 25, 26, 28, 30, 31, 32, 33
Build Tools: 28.0.3, 30.0.2, 30.0.3, 31.0.0, 33.0.0
System Images: android-33 | Google APIs ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2022.2 AI-222.4459.24.2221.9971841
Xcode: 14.3/14E222b - /usr/bin/xcodebuild
Languages:
Java: 11.0.15 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: ^18.2.0 => 18.2.0
react-native: 0.71.4 => 0.71.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Have the same exception


Rotation on particle

Hi there!
Thank you for this great library!
Is there a way to rotate the particle randomly? I mean that right now, all my shapes have the same rotation. I would like to have a different rotation for each particule, to have something more random, like this: https://snipboard.io/N21pQ0.jpg
Thank you in advance,
Cedric

Hi @cedriccharles4,
This library was abandoned years ago, I resumed this project some months ago and added other features, which includes the one you are asking.
The rebooted project is this: https://github.com/matteobruni/tsparticles
And you can see a working sample here:

https://codepen.io/matteobruni/pen/GRJLZye
https://codepen.io/matteobruni/pen/bGdomGq

Hi @matteobruni !
Perfect, thank you 👍

Oh, I think this project has not been abandoned, on the contrary it is very powerful and convenient. Please respect the author.


Default export to?

Hi @ChrisChinchilla,
Thanks so much for continue maintaining the extension.
One suggestion:
I only export to HTML. Therefore I would like to set HTML to be the default export format.
What do you think of a setting by which people can define their preferred export format?
And if chosen, the command "Render" would directly render into that format!

Sure, I'll have a think about that and see what i can do :)

Nice, thank you! Maybe a new command on the palette like "Pandoc render to default"?
And then default can be defined on the settings. :)

Another thought: can the sub-menu selection (HTML, PDF, ...) be shown on the command palette under recently used?


Fix SmoothSeasonality Sine Wave Generation.

Issue #, if available:
No associated issue.
Description of changes:
There was a small error in the code for generating synthetic seasonal data using rcp.SmoothSeasonality. In short, the phase parameter was being using incorrectly, not following the standard formula for a sine curve (see here). The code has been updated to match the correct formula.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This doesn't strike me as a bug, but rather a (admittedly somewhat unusual) parametrization of the phase parameter in the same units as the period. I'm ok with making this change to radians, but it will be breaking change. Maybe providing a docstring that calls out the somewhat unusual units might be a viable alternative?
If we make this change, the synthetic data generation tutorial also needs to be updated: https://github.com/awslabs/gluonts/blob/6148459b6c91944b4f3a28f208864974f45965e4/docs/tutorials/data_manipulation/synthetic_data_generation.md.template#L199

Is there some reference we can cite for this parametrization? If so, putting a reference in the doc string makes sense to me and it will avoid the breaking change. Otherwise, updating the code and tutorial may avoid future confusion. What do you think?


Corrected network policy port notation

Corrected how the ports are defined in the network-policy documentation.

@delaman was this throwing validation errors for you?
I think the current yaml is correct - the "from" and "ports" sections are ANDed together.

@delaman - thank you for taking the time to help us improve this! It seems from Casey's comment that the original is intended to be correct, and that your suggestion would result in validation errors - could you double check that please?
If it is correct, could you please sign the CLA so that we could consider your contribution.

/assign

I am pretty sure Casey's right on this one.

thanks @thockin

I signed the CLA
I verified that my PR doe not cause a validation error.  Both the current and my PR do not give validation errors.
My PR in JSON format makes more sense to me:
{
  "apiVersion": "networking.k8s.io/v1",
  "kind": "NetworkPolicy",
  "metadata": {
    "name": "test-network-policy",
    "namespace": "default"
  },
  "spec": {
    "podSelector": {
      "matchLabels": {
        "role": "db"
      }
    },
    "policyTypes": [
      "Ingress",
      "Egress"
    ],
    "ingress": [
      {
        "from": [
          {
            "ipBlock": {
              "cidr": "<IP_ADDRESS>/16",
              "except": [
                "<IP_ADDRESS>/24"
              ]
            }
          },
          {
            "namespaceSelector": {
              "matchLabels": {
                "project": "myproject"
              }
            }
          },
          {
            "podSelector": {
              "matchLabels": {
                "role": "frontend"
              }
            }
          }
        ]
      },
      {
        "ports": [
          {
            "protocol": "TCP",
            "port": 6379
          }
        ]
      }
    ],
    "egress": [
      {
        "to": [
          {
            "ipBlock": {
              "cidr": "<IP_ADDRESS>/24"
            }
          }
        ]
      },
      {
        "ports": [
          {
            "protocol": "TCP",
            "port": 5978
          }
        ]
      }
    ]
  }
}

I take it back.  I accept the current documentation.
My fault.  Thanks for your time guys.


ITrackingSpan section doesn't describe the SpanTrackingModes properly

Look at the section about ITrackingSpan, it refers to SpanTrackingMode in all cases instead of the actual SpanTrackingMode enum value.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f9f6314-07f7-4a22-2f4a-e29636bdda91
Version Independent ID: d109c631-e7c0-5364-c6e4-12e2c47b1974
Content: Inside the Editor - Visual Studio
Content Source: docs/extensibility/inside-the-editor.md
Service: unspecified
GitHub Login: @gregvanl
Microsoft Alias: gregvanl

@kylereedmsft thanks for your feedback.

Many enum field links were broken during the conversion from MSDN to docs.microsoft.com.


Revert "Chore/update for sdk conway era"

Reverts input-output-hk/lace#734
Reason: missing updates for the SDK packages results in broken build & tests.

Changes unknown
when pulling 3cef9ddd4185592d996371762703a495a6fa2ec9 on revert-734-chore/update-for-sdk-conway-era
into ** on feat/sanchonet**.


Add dependabot.yml file to the repo's

Background
Add the below code to .github/dependabot.yml files in each repo to automatically bump dependency and github action versions.
To get started with Dependabot version updates, you'll need to specify which package ecosystems to update and where the package manifests are located.
Please see the documentation for all configuration options:
https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
version: 2
updates:

package-ecosystem: "bundler"
directory: "/"
schedule:
interval: "daily"
package-ecosystem: "terraform"
directory: "/terraform"
schedule:
interval: "daily"
package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
package-ecosystem: "pip"
directory: "/"
schedule:
interval: "daily"
package-ecosystem: "npm"
directory: "/"
schedule:
interval: "daily"

applied to:
acronyms
all-org-members-github-team
cloud-platform-maintenance-pages
developer-portal
dns-iac
github-actions
github-collaborators
github-repository-standards
moj-ip-addresses
moj-prototype-template
mta-sts
no-verified-domain-email-repo
operations-engineering
technical-guidance
template-documentation-site

need to review the above repo's again as the paths to dependancy files ie Gemfile, has to be more specific, also some versions of GH actions are using main or master rather than v1 or v2 and therefore do not get updated, need to review if have any other GH actions that have been abandoned but are used by our repo's to up their dependencies as well.


Fast breeder reactor enrichment receipe has no rates

Title is pretty explicit.
The FBR enriches 1.2 blanket fuel per 60 at 1x rate (should be 4.8 at the max rate used).

Fixed in v1.0.19


Verbosity of the GradientOperator

When the GradientOperator is called a message is printed.
Gradient = GradientOperator(self.domain, correlation = self.correlation, backend = self.backend)

Initialised GradientOperator with C backend running with  20  threads

This is ok for our unittests, but it is not  useful when we run our algorithms. Maybe, we can use a debug variable which will be False by default and True in the unittests.

I believe we should use logging and in particular the StreamHandler which would dispatch the various logging info to the sys.stdout and sys.stderr depending on the logging level. See also https://docs.python.org/3/howto/logging.html#loggers


minHeight and maxHeight are not handled properly

Describe the bug
Related issue:

https://github.com/go-gitea/gitea/pull/19003
The related code (only a few lines): https://github.com/go-gitea/gitea/pull/19003/files

In some cases, we need to set minHeight and maxHeight at the same time.
However, although the EasyMDE document has described the details of minHeight/maxHeight handling, the current logic is not ideal.
To Reproduce
Current logic:
{minHeight: '80px', maxHeight: 'calc(100vh-200px)'} becomes style="min-height: calc(100vh-200px); height: calc(100vh-200px)"
Then users are not able to make the heights correct in some cases.
Expected behavior
Just pass minHeight to min-height and maxHeight to max-height as they are.

We may be able to change the behaviour when both values are set.
The current behaviour was introduced in https://github.com/Ionaru/easy-markdown-editor/pull/222 as a fix for https://github.com/Ionaru/easy-markdown-editor/issues/206 and possibly https://github.com/Ionaru/easy-markdown-editor/issues/212.

According to standard, we do not need to process if max-height is less than min-height, in such case, min-height works.
https://developer.mozilla.org/en-US/docs/Web/CSS/min-height
https://developer.mozilla.org/en-US/docs/Web/CSS/max-height
max-height overrides height, but min-height overrides max-height.
The element's height is set to the value of min-height whenever min-height is larger than max-height or height.

I see the plan about "3.0 rewrite", close this one as not planned?


Client Allocation Request for: Googlier LLC

Client Allocation Questions
Core Information

Name: Googlier LLC
Website / Social Media: https://googlier.com
Region: North America
DataCap Requested: 1TiB
Addresses to be Notarized: f1xvhr65jcozzo6bjhkst7oiqplgidzn7qdyuizhq
Notary Requested: dannyob

@reterik Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hey Googlier! Could you tell me a little about your project? We're looking for evidence that a) you are who you say you are, b) that the data is public and open (and you have the rights to distribute it), and c) you plan to use your datacap with a number of different miners.

I am backing up my DNA decode to provide it open source on this page (I got the decode from nebula.org):
https://github.com/reterik/Joseph-Hettich-DNA-Sequence-Decode
This is me, I am sole-proprietor of Googlier LLC, do you need KYC?
https://www.linkedin.com/in/joehettich
I plan on triple backing up ~150 GB of DNA data, so I could probably get away with 400 GB total.
I cannot afford the costs of data packs on Github so I am looking for a better solution.

This affirms what @googlier has said above.


feat: validate links in the astro.config.mjs sidebar directive

Is your feature request related to a problem?
When handling the sidebar manually, links can become incorrect as you move content around. Having the link validator handle this would be a great catch before pushing broken sidebar links to production.
Describe the solution you'd like
The link validator would help find broken sidebar links.
Describe alternatives you've considered
No response
Additional Context
No response

Starting with Starlight version 0.25.0, internal sidebar links can be specified using their slug either as a string or an object with a slug property:
starlight({
  title: 'My Docs',
  sidebar: ['getting-started', { slug: 'guides/installation' }],
});

When using this approach, on top of being easier to write, Starlight will error out if a specified slug does not exist:

Considering this validation exists in Starlight, I don't think adding a similar feature to the plugin would be beneficial.


406 api error

Hi,
I tried to insert a code using asset API of Shopify. but it returned a 406 error - Client error: PUT https://good-time-store.myshopify.com/admin/themes/14690353211/assets.json resulted in a 406 Not Acceptable response
This is my code
$api = $shop->api();
$asset = [
[
'key' => 'layout/theme.liquid',
'value' => 'hello'
]];
    $result = $api->request(
        'PUT',
        '/admin/themes/14690353211/assets.json',
        ['asset' => $asset]
    );

@nithinnitzarya  try
$asset = [
    'key' => 'layout/theme.liquid',
    'value' => 'hello'
];

It looks like you have an unnecessary  array

@ncpope
I changed that but again got an another error  - Client error: PUT https://good-time-store.myshopify.com/admin/themes/14690353211/assets.json resulted in a 422 Unprocessable Entity response: {"errors":{"asset":["Missing {{content_for_header}} in the head section of the template","Missing {{content_for_layout}} (truncated...)

@ncpope @ohmybrew  Any Solution? still am getting these errors tried a lot of combinations

@nithinnitzarya keep in mind this package provides a wrapper to Guzzle for making the HTTP request.  What @ncpope recommended resolved the 406 error - have you looked specifically at the 422 error response in terms of the missing content?
The 422 is telling us that the request was processed by Shopify's API and it didn't meet the validation for updating the underlying resource.
Hope this helps.

@brianakidd @ncpope Wow !!! Finally !! Validation was the issue. I was trying to write on the theme file without header and layout.
I have added that and the error vanished ;)
Thanks a lot


04 - CSS:  (All) Style header and nav bar

Style header (logo, title/slogan, and nav bar) in CSS

Styled our nav bar links to show which page is currently on


Realtime module not referred to in the crud module docs

The problem faced currently?
A new user going through the documentation of the crud module wouldn't be able explore the option of a realtime query. We might miss out on a potential user due to that.
How can we solve it?
Maybe we can reference the real-time module on the read page for the database docs. This way we are informing the user about the realtime module at the appropriate place.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Lets merge the realtime and the crud module into one.

Solved


entity doesn't display last update in persian language

hello. there is a bug when I set language to فارسی , entity doesn't display last update after updating HA to 0.95.4 version. how ever it shows the graph.
thanks in advanced

Is this still an issue?


[Bug] Rest API smart substitution breaks if the evaluated value has "?" symbol in it

@ApekshaBhosale @vnodecg Hey team! Can you please add your planning poker estimates with ZenHub


Doesn't build under Ubuntu

I rebuild ghc, haskell-plattform and even LibClang from source but everytime it gives me the same error:
Setup.hs:17:8:
    Could not find module `Distribution.Simple.Program.Find'
    Perhaps you meant
      Distribution.Simple.Program.Ld (from Cabal-1.16.0)
      Distribution.Simple.Program.Run (from Cabal-1.16.0)
      Distribution.Simple.Program.Ar (from Cabal-1.16.0)
    Use -v to see a list of the files searched for.

Do I have to fix something in the dependencies?
Thanks

The issue is the version of the cabal library. I don't know if hand if it is expecting something older or newer. Cabal update, cabal install Cabal cabal-install, retry?

The Cabal version should be >=1.18
Will update the Cabal file to match that version dependency
On Oct 21, 2016 6:57 AM, "Thomas M. DuBuisson"<EMAIL_ADDRESS>wrote:

The issue is the version of the cabal library. I don't know if hand if it
is expecting something older or newer. Cabal update, cabal install Cabal
cabal-install, retry?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chetant/LibClang/issues/63#issuecomment-255361967,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqxXFY957Mrgps-nmcECWMPN-bugwFAks5q2KidgaJpZM4Kc_KO
.

Fixed in e8723e4


Enabled_Version1000 doesn't exists anymore

Hi,
the Detection Method of this Example Application and which is called inside the documentation on Lines 352-363 doesn't exist anymore could you please update this article for other admins. The new Surface Deployment Powershell Scripts are updated with other RegistryKeys.
Thx and Regards,
Daniel

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: c7ac548b-be6c-efba-76ee-67dd7af18891
Version Independent ID: 947b62e7-1225-2f5e-14ba-fe5dccbbe124
Content: Use System Center Configuration Manager to manage devices with SEMM (Surface)
Content Source: devices/surface/use-system-center-configuration-manager-to-manage-devices-with-semm.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

@officedocsbot assign @mypil

@Dan-Fink - Thank you for submitting feedback.
I will get this issue over to the Win10 ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@Dan-Fink - From our understanding, the issue has been resolved but it may take a few days for the merged content to appear in the article. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


bug: test_pending_ping is failed  intermittently

Describe the bug
test_pending_ping is failed  intermittently
Steps to reproduce
cargo test --all
Node logs
failures:

---- tests::test_pending_ping stdout ----
thread 'tests::test_pending_ping' panicked at 'assertion failed: service.pending_pings.contains_key(&node.id)', crates/net/discv4/src/lib.rs:1940:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Platform(s)
No response
What version/commit are you on?
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

should be fixed on main ref #1440


(maint) keep data-util open

Quick update to keep the data-util container running.
Otherwise on every puppet run, docker-compose up results in the data-util container starting up and exiting. This results in a changed report every run due to corrective change. This change should be included in the release so the tag will need to be moved to this commit when merged.
The change also should be put into the deploy-docker compose file within the lidar repo.

The tag has also been updated


Apache Log4j2 2.14.1 Remote Code Execution

Consider upgrading UniFi to 6.5.54.
Provides fix for a security vulnerability found in a 3rd party library (CVE-2021-44228) - Apache Log4j2 2.14.1 Remote Code Execution.
https://community.ui.com/releases/UniFi-Network-Application-6-5-54/d717f241-48bb-4979-8b10-99db36ddabe1
https://community.ui.com/questions/UniFi-Controller-security-concern-zero-day-Log4j-exploit/007103a6-823b-4316-ae76-17942539208c#answer/b098ad67-22aa-42ce-9580-c0a7d91c4b89

FYI I had already put in mitigation for the log4j2 issues on 2021-12-10 in 5f61aef. Latest commit 97ef850 updates the 6.5/official tag to v6.5.54. Thanks for the heads-up, the UniFi releases and "oh we'll just change the post on the community from RC to official instead of actually announcing" makes it awful to track when things change.


[CONTINT-3898] Run kind tests on ubuntu-20.04 as well

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

Will do it with the gitlab ci finally


Allow the target push tag to be customized for origin

Allows us to cut a tag, run push_origin_release on it.
@stevekuznetsov

/lgtm
@smarterclayton pushed


Rare Crash

Every now and then, very rarely, I get this crash:
http://pastebin.com/bDf5vU9p
I'm using the latest version of NEI, CodeChickenCore, and CodeChickenLib for 1.8.

Oops, I didn't know the other one got posted, so I made a duplicate.


Redirect ServerFoundCallback to be invoked on the main thread + Continue server discovery even after one server is found

Currently, when a server is found, the ServerFoundCallback is invoked in the worker thread that was started with the Task.Run() command. Invoking the ServerFoundCallback on the worker thread causes its linked delegates (e.g. ServerFoundCallback += OnServerFound) to also be executed on the worker thread. If the delegate calls ANYTHING related to Unity engine (such as enabling/disabling GameObjects), this either causes an error or your calls to be completely ignored, as Unity hates any code that is not run on the main thread. This commit changes this, and invokes the callback inside the Update() function, which ensures that the callback occurs in the main thread.
I have encountered this issue while I was building my main menu UI for local connections. I wanted to enable a button that would help you connect to the server whenever one was found, however it didn't work. Upon applying the fix on this commit, I was able to get my buttons to enable without a problem.
In addition, previously, the server discovery would instantly stop after a server was found, so if there were more than one server on your network, you were out of luck. This commit also fixes that, and allows the script to discover more than the first server by saving the previously found servers on a list, and then comparing the newly found endpoints to the previous ones to check if they are newly discovered servers.

After further review of the code, the changes have been reverted due to the code being inefficient and the inconsistent code style.

What part of it did you find inefficient?

What part of it did you find inefficient?

Nested loops inside Update method
Usage of List<T> instead of HashSet<T>
Conversion of IPAddresss to strings for comparison instead of using the IPAddress.Equals method

While I agree that the usage of HashSet would have been better, the other ones are not matters that were done by choice. IPEndPoint.Equals does not consistently return true in our case, as network conditions are very prone to change and string comparison is the most reliable method, and the choice of using it Update was because we needed to return the invocation of the ServerFoundCallback back to the main thread (probably in an environment where Time.timeScale is set to 0 as LAN game searches will happen in the UI). If this was an update that was going to be overwritten by your own update anyways, why'd you revert what makes the code work for nanoseconds worth of optimizations?

This is a public project that people rely on in their projects, both during development and on release, having inefficient/poorly written code cannot be tolerated at all.

Yet it's been in this barely-functional state since your last commit which was over a year ago. I will admit that you are right in terms of the optimizations that could have been done much better (I am still a junior dev that is far from being able to write perfect code) but you could have actually compiled these mistakes for me to correct and I would have worked on that had you have good intentions. Keep your project and good luck in your future endeavors.


Some Kernel32 functions

As I was looking around on the enums, I have noticed that some introduced a zero-state None field, but the naming is inconsistent. Some are just None, some follow the inner enum naming system like SH_FLAG_NONE. which one is the most appropriate? If it is the inner naming system, can I add the fix to this commit?

On the zero state I think it could be nice to avoid using default(EnumName). For the name I think it would be named None as we try to respect the C# naming except when something already have a name in the original header files.

Except for GetProcAddress movement, LGTM.
4 PRs in a row :+1: :beers:

Ohhh damn. I tried moving SafeLibraryHandle but the CodeGenerator started throwing all kinds of complains. Can you help me move SafeLibraryHandle to Shared to be able to use GetProcAddress on UWA and Desktop?
I will be out tomorrow and will resume my activities only on Friday, so no commits tomorrow :cry:

Thanks!


Xcode 8, Swift 3

Hello!
I am getting the following error:

I also set Use Legacy Swift Language Version to YES but it still doesn't work
Project was integrated via Cocoapods
Maybe you can add a swift version file indicator, as per http://stackoverflow.com/a/39618219/743923 ?

@danipralea we do have the swift-version file in the project.
Which version of ObjectMapper are you using?

@tristanhimmelman .swift-version file is for linting podspec. We need s.pod_target_xcconfig in podspec which is added in https://github.com/Hearst-DD/ObjectMapper/commit/e7408cab845c4204752ff20e2cce1d48cac962bc . So @danipralea, you have two options:

Use ObjectMapper 2.1.0

Add this script at the end of the Podfile:
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['SWIFT_VERSION'] = '3.0'
    end
  end
end

yeah, I ended up using 2.1.0
I had the 1.1 version somehow (I copy pasted the pod from an old project).
Thank you very much for your help!


feat: removing snyk

:tada: This PR is included in version 1.2.0-beta.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


IPv6 Support

Enhancement request to support IPv6 in all applicable functions and objects and add AAAA support.

Hi @nahun,
IPv6 support for DHCP objects has been done and we are working on supporting DNS objects.
The changes are in develop branch https://github.com/infobloxopen/infoblox-go-client/tree/develop . Please do use the same and provide the feedback.

We have added support for DNS objects as well.
Now the feature is available at master branch. Will be available as part of v2.0.0


Get Python error when try to run Windows portable yt-dlp-gui.exe

Here what I get from the very start of the program:
Traceback (most recent call last):
File "app.py", line 8, in
ImportError: DLL load failed while importing QtWidgets: The specified procedure could not be found.

Did you extract all the files beforehand?

Did you extract all the files and run the exe from the directory its been extracted to?

Yes, did exactly like this a few times, no success.

Same problem in Windows 8.1 64bit

Only tested on Windows 10.

Yes, did exactly like this a few times, no success.

I'm sorry but I cannot reproduce this error, give me some extra details please what OS what yt-dlp-gui version?

many thanks for the reply
Yt-dlp-gui last version
The problem is only in Windows 8.1 (tested with two different machine) , in Win 10 works fine
In Windows 8.1 only this old version works

many thanks for the reply Yt-dlp-gui last version The problem is only in Windows 8.1 (tested with two different machine) , in Win 10 works fine
In Windows 8.1 only this old version works

Windows 7 and 8 are no longer supported by Qt6 see https://stackoverflow.com/a/71742165


Use pipenv lock instead of pipenv-to-pip

Ref: https://github.com/heroku/heroku-buildpack-python/issues/678

Lock is not designed to work with --system. It creates a virtualenv, which is expensive, both in time and disk space.


Feature request: to publish binary for PowerPC ppc64le architecture

Expected Behaviour
Publish a binary for PowerPC ppc64le architecture
Current Behaviour
No binary available

Netty is successfully built on powerPC, and is required by many packages as one of the dependencies.

You can build binary by yourself.

@hyperxpro Actually, we are hoping for official binaries to set up CI for Power.

TBH, there is no difference in binary if you build by yourself. ppc64le architecture is not as popular as amd64 or arm so chances of official build is fairly low.


sway: remove swaybg from path

Avoids polluting the environment for sway's children.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@primeos How's this look?

@primeos How's this look?

@deviant looks good, thanks!

@deviant looks good, thanks!

@alexarice Are you using any overlays?

@alexarice Are you using any overlays?

I'm using the nixpkgs-wayland overlay

I'm using the nixpkgs-wayland overlay

ah, this will be missing the patch right?

ah, this will be missing the patch right?

Yeah. What's happening is it overrides the sway-unwrapped attribute here, but doesn't override the wrapper. Since the wrapper no longer puts swaybg in its $PATH, the nixpkgs-wayland version cannot find it.

Yeah. What's happening is it overrides the sway-unwrapped attribute here, but doesn't override the wrapper. Since the wrapper no longer puts swaybg in its $PATH, the nixpkgs-wayland version cannot find it.

Will make an issue there, thanks for the help

Will make an issue there, thanks for the help