Unable to get neotest to run tests for a minitest file

When I run lua require('neotest').run.run(vim.fn.expand('%')) I get "No tests found". But if I run :!ruby % then the tests run and provide output.
Any help in figuring out what I am missing would be great.

Hey @exosyphon could you share the file you're trying to run the tests on? Maybe the treesitter query that detects tests isn't detecting the tests.

Sure thing! This is an example from https://exercism.org/tracks/ruby/exercises/two-fer
require 'minitest/autorun'
require_relative 'two_fer'

# Common test data version: 1.1.0 c080bdf
class TwoFerTest < Minitest::Test
  def test_no_name_given
    assert_equal 'One for you, one for me.', TwoFer.two_fer
  end

  def test_a_name_given
    skip
    assert_equal 'One for Alice, one for me.', TwoFer.two_fer('Alice')
  end

  def test_another_name_given
    skip
    assert_equal 'One for Bob, one for me.', TwoFer.two_fer('Bob')
  end
end

Does the file name end in _test.rb? I tried to reproduce with the example you gave and I'm only getting the behaviour you described when the file name doesn't end in _test.rb.
This adapter only recognizes test files that end in _test.rb. See https://github.com/zidhuss/neotest-minitest/blob/25dbe6e56a245899661f025a957b6e2502900a0d/lua/neotest-minitest/init.lua#L18-L23

The test file does end with _test.rb but it is at the same level as the implementation. Not sure if that matters. Here is the directory structure:

README.md
two_fer.rb
two_fer_test.rb

The default test command assumes a Gemfile because it runs bundle exec ruby -Itest.
The b3fde2c commit made the test command configurable. To get your example to work you can modify your default test command:
require("neotest-minitest")({
    test_cmd = function()
        return vim.tbl_flatten({
            "ruby",
            "-Itest",
        })
    end,
}),

I still couldn't get this to work for me. I ended up just generating a Gemfile and that got the tests to run.


Load content script as string with esbuild plugin

This plugin builds on #224 and extracts the injected page content script to a separate ts file, which gets loaded by the custom script-to-file plugin in tsup.config.ts.
This is much cleaner, adds type safety and allows us to bundle other modules into the content script. Can replace #239 (although that one and #224 should probably be merged first).
I also added kleur for the terminal colors.
Please check the changes here: https://github.com/bryanjtc/test-runner/compare/bundle-tsup-swc...hansottowirtz:test-runner:content-script-plugin
In the built files, the addContentScript call looks as follows:
// script-to-text:<root>/src/page.content-script.ts?script-to-text
var page_content_script_default = '(() => {\n  var __create = Object.create;\n  var __defProp = <the rest of the file...>';

await page.addScriptTag({
  content: `
const __CONTENT_SCRIPT_viewMode = ${JSON.stringify(__CONTENT_SCRIPT_viewMode)};
const __CONTENT_SCRIPT_renderedEvent = ${JSON.stringify(__CONTENT_SCRIPT_renderedEvent)};
const __CONTENT_SCRIPT_testRunnerVersion = ${JSON.stringify(__CONTENT_SCRIPT_testRunnerVersion)};
const __CONTENT_SCRIPT_referenceURL = ${JSON.stringify(__CONTENT_SCRIPT_referenceURL)};
const __CONTENT_SCRIPT_debugPrintLimit = ${JSON.stringify(__CONTENT_SCRIPT_debugPrintLimit)};
const __CONTENT_SCRIPT_targetURL = ${JSON.stringify(null)};
${page_content_script_default}`
});

This is interesting work, and we're looking at it. @yannbf will redo the PR that this is based on, so we can target that as a base here, to only include the actual changes.

I cleaned up some commits, should be good to go now.


Ensure display of full username on choose account screen

E.g. with overflow-wrap

We already have designs for this: https://www.figma.com/file/aXnNi8MOmN3CDrVwaDXXuqX3/Product?node-id=7059%3A0


Errors in reproducing results correctly by training models

I tried running the code using the given checkpoints and was able to verify the results.
The meshes obtained with texture applied are as follows:

But when I tried steps 2-5 on my own, I received some inconsistent results. The inter-surface maps were a bit off. I have attached screenshots with texture applied on them

As can be seen, the mapping on the nose and the shoulder is a bit off center. The same is true for the other shoulder. I have uploaded the intersurface maps obtained in the link here
This happened on multiple runs of the model and I am unable to figure out whether something is wrong with the way I am running the code or not.
The steps I followed to obtain the model were as follows:

Create output_sample.pth for bimba and beethoven models using the given parametrised mesh and their corresponding oversampled versions.
Train a surface map using given output_sample.pth files. The config files given to hydra were unchanged.
Create parameterisation map using the surface map of bimba and beethoven
Create intersurface map using the surface map of bimba and beethoven
Visualise the maps as meshes using show_surface_map, show_param_map, and show_intersurface_map.

Hello,
the textures are clearly misaligned.
Did you set the landmarks for the two surfaces?
The configuration file has landmarks_g and landmarks_f to set. The default value is an empty list.
For example:
landmarks_f : [22335, 4982, 11633]
landmarks_g : [14505,  182, 12108]

I did forget to mention this in the README file, apologies.


[DO NOT MERGE YET] Change layout of homepage

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
What
Change the layout of homepage so that the 'Popular' and 'Services and information' sections are presented in a row on desktop. Use the new parameter new_design to conditionally toggle the layout style and styling.
Why
As part of several incremental changes being made to the homepage. The use of the parameter means we can merge changes into frontend ahead of time and makes further work on changes to the homepage easier as a result.
Trello Card
Visual Changes
Before

After

@hannalaakso thanks for finding and reporting the spacing issue, I've fixed this issue on a recent commit:

I've also completed a secondary review of changes made today and it looks good to go.


Investigate incompatible device types

A team member did os-config json with a JSON for a RPi 3 board, but his original config is of Balena Fin device. This did not error out. I need to investigate this, since we compare device types, and this should not have occurred.

Discussed in the arch call and agreed to have the check done in os-config and have the tool reject the config.json when the device-type conflicts.


Remove references to "JBoss" in AMQ role

"JBoss" has been removed from branding for AMQ, and it's now just "Red Hat AMQ". We should remove references to "JBoss" to avoid confusion. This includes the name of the broker systemd service, and the name of this repository, unfortunately.

Many JBoss references were removed in #17 but there are still more. Leaving this open for now.


Native coverage integration for the CTest test controller

This change addresses item #4040
This changes visible behavior and documentation
The following changes are proposed:

Integrate native vscode coverage analysis for the CTest test controller using the VSCode Testing API

Other Notes/Information
This implementation only adds support for GCOV/LCOV based coverage data, but the implementation could be expanded in the future to support additional coverage data.
There are no unit/integration tests added, as it's unclear if the CMake Tools maintainers would be interested in this implementation. If the interest is there, I would be willing to add tests. I have tested the implementation however, and it does work for me.

Some screenshots of this working on your end locally, would also be great to put in the description of the PR.

This looks pretty interesting, so I believe we'd be willing to consider taking this addition into the code, but we would definitely want tests.
Glad to hear! And I agree that tests make sense to include.

From my reading, it looks like this is the test coverage tool for GCC, is that correct? Or does this work for other compilers?

This implementation supports lcov coverage data files. lcov is a graphical front-end for GCC's coverage testing tool gcov. It's worth noting however, that other compiler toolchains, such as llvm clang are able to produce lcov coverage data files, for example from clangs documentation:

This document explains how to use clang’s source-based code coverage feature. It’s called “source-based” because it operates on AST and preprocessor information directly. This allows it to generate very precise coverage data.
Clang ships two other code coverage implementations:

- [SanitizerCoverage](https://clang.llvm.org/docs/SanitizerCoverage.html) - A low-overhead tool meant for use alongside the various sanitizers. It can provide up to edge-level coverage.
- **gcov** - A GCC-compatible coverage implementation which operates on DebugInfo. This is enabled by -ftest-coverage or --coverage.

However, if this were to be merged, from my point of view one could also welcome adding support for other coverage data types in addition to the lcov format.

What exactly does this do? I see that you've added another ctest run helper, as well as settings for what target to build before and after .What does running with this coverage do? Why do we need to specify targets to be built before and after?

The settings for targets to be build before and after the tests are executed with coverage are intended for the user to specify utility targets in their CMake setup that prepares for a run with coverage as well as generating the appropriate coverage data files. See "Recommended procedure when capturing data for a test case:" in https://man.archlinux.org/man/lcov.1.en. Essentially, the user is expected to have utility targets that does something similar to this procedure. This is not something I would think the extension can handle, since it will probably look different for different projects. Therefore, it makes sense for the project to have utility targets that would have handle these operations. The extension will then only parse files from the cmake.coverageInfoFiles setting (that is also added in this PR) to add coverage information to the editor.

Some screenshots of this working on your end locally, would also be great to put in the description of the PR.

Sure, I'll provide some screenshots or GIFs to show you how it works in the near future as I also work on adding tests.
Let me know if there any more things I clarify, or if there are any considerations regarding the design of the implementation

@TSonono Great! Thanks for the explanation. I'll wait on reviewing this further until tests are added, and then it could be useful to add some of the context you just mentioned, into a comment somewhere in the code you added. It doesn't have to be overly verbose, just enough so that when people come back to this for any implementation around this can easily understand. Thanks!

One last thing, please add a CHANGELOG.md entry. Thanks

Done


Updates on plotting routines and coordinate transforms to openPMD and OPAL

added functionality to plot_projections
added OPAL-to-bmadx coordinate transformation in pmd_utils
added more openPMD-to-bmadx transformations in pmd_utils
renamed beam generator to distgen_utils

@roussel-ryan

I recommend leaving conversions from OPAL and other codes to the ParticleGroup object, and keep Bmad-X clean. So, in Bmad-X there should be its internal particle structures, and openPMD-beamphysics.

@ChristopherMayes I agree, but I didn't find any OPAL reader in openPMD-beamphysics

https://github.com/ChristopherMayes/openPMD-beamphysics/blob/master/pmd_beamphysics/interfaces/opal.py

We could add a reader there

I see, thanks. The OPAL coordinates were given to me as an ASCII file instead of an h5 file. I will ask for the h5 file. For now, I will leave this PR open and work in my dev branch.

Well if you have time, make a PR to openPMD-beamphysics adding a opal_ascii_to_data(filePath).

Will work on OPAL-openPMD coord transforms in distgen


style(compiler-sfc): tweak api and types export

generateCodeFrame should be placed at "API" group

BTW, consider bumping prettier to 2.1.0+ ?
It would have better support for typescript 4.0.0:
https://prettier.io/blog/2020/08/24/2.1.0.html#typescript
One breaking change it the trailingComma config it set to es5 by default:
https://prettier.io/blog/2020/03/21/2.0.0.html#change-default-value-for-trailingcomma-to-es5-6963httpsgithubcomprettierprettierpull6963-by-fiskerhttpsgithubcomfisker

Prettier is pinned because of the nested ternary formatting. I'll probably only considering bumping if there are new TS syntax that cannot be handled.


Sanitize index

Closes #971
cc @alimanfoo

Thanks @mrocklin. I realise now the problem was triggered by me passing the indices as a tuple to da.take(), whereas you expected a list. I see you have added support for a pandas series deeper within the sanitise_index function, but passing a tuple to da.take() still causes a problem. Can I suggest that within da.take() you coerce the indices argument to a list or whatever you want to handle internally before passing through? That way da.take() could accept the indices as any sequence-like (e.g., numpy.take() is quite happy with indices as a tuple, list, array, ...).


Secure metrics for shared resource nodes

/assign @gabemontero

we are going to trial and error here wrt https://prow.ci.openshift.org/job-history/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.10-e2e-aws-techpreview
/approve
/lgtm

/refresh


Apply Fused QKV to Llama

Llama model for Gaudi should have FusedQKV, which is available on Optimum Habana, if not from HuggingFace.

I think that DeepSpeed Inference already handles this.


[Bug] [Core] JobEventHttpReportHandler is invalid

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
PG-CDC to Starrocks job，no events (or related logs) were received
SeaTunnel Version
2.3.5
SeaTunnel Config
none

Running Command
none

Error Exception
no error

Zeta or Flink or Spark Version
Zeta
Java or Scala Version
No response
Screenshots

JobEventHttpReportHandler has been loaded

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@hailin0 Do you have time to look at it?


It would be great to have an omit_background option so you can take transparent PNG screenshots

It's in the options, but I don't think it's available.
https://playwright.dev/python/docs/api/class-locator#locator-screenshot-option-omit-background

Seeing an error with this in CI: https://github.com/simonw/shot-scraper/actions/runs/4815473826/jobs/8574190652
Screenshot of '.day' on 'https://simonwillison.net/' written to 'examples/selector-all.png'
Screenshot of 'https://simonwillison.net/' written to 'examples/simon-narrow.png'
Error: TypeError: Cannot set properties of undefined (setting 'backgroundColor')
    at eval (eval at evaluate (:195:30), <anonymous>:1:60)
    at eval (<anonymous>)
    at UtilityScript.evaluate (<anonymous>:195:30)
    at UtilityScript.<anonymous> (<anonymous>:1:44)

Looks like the error is from: https://github.com/simonw/shot-scraper/blob/ebc2e909821f926979550bb6e1295b59b7a93da0/tests/run_examples.sh#L33-L37
That gives me the same error locally too:
% shot-scraper https://simonwillison.net/ \
  -h 800 -o examples/simonwillison-transparent.png \
  --javascript "document.getElementsByTagName('body').style.backgroundColor='transparent'" \
  --omit-background
Error: TypeError: Cannot set properties of undefined (setting 'backgroundColor')
    at eval (eval at evaluate (:197:30), <anonymous>:1:60)
    at eval (<anonymous>)
    at UtilityScript.evaluate (<anonymous>:197:30)
    at UtilityScript.<anonymous> (<anonymous>:1:44)

It's because document.getElementsByTagName('body') returns an array-like collection. I'm going to try document.querySelector('body') instead.

This worked without an error:
shot-scraper https://simonwillison.net/ \
  -h 800 -o examples/simonwillison-transparent.png \
  --javascript "document.querySelector('body').style.backgroundColor='transparent'" \
  --omit-background

And produced this image (which has a transparent background, though you can't see that on GitHub Issues because the background here is white too):


need command line feature to load saved config.

Hello.I run Genshin on two stream device,and it has different controll device(touchscreen ->controller for tablet,kb+mouse for another computer)
Is it possible to add a cmdline to toggle to change default controller in game?(I need change from KB+Mouse to Console everytime,this game can't support auto switch input device,which is awful.)
thanks

Unfortunately, this isn't possible. There's no device selection in the config, game decides, what controller it will be using. This one would require injecting code into Genshin's process, what's against the ToS


fix: Weights clipping range is wrong

Instead of $[-max(|a|, |b|), max(|a|, |b|)]$, use $[min(a, b), max(a, b)]$ as the safe value range.
Here's an example of merge using add difference with $\alpha = 1.0$, A = ghostmix_v12, B = lyriel_v16, C = sd_v15
before:

old `-wc` procedure

after:

new `-wc` procedure

now we should update the wiki

Agree. I need to write something for the other merge methods.


How is the state handled when using the forking feature?

Summary
Before starting, Please note that this is a question, not an issue as I'm not sure about the expected behaviour.
I'm not sure if I understand the --fork feature of ganache-cli. I have a contract Mine, which only exists in localhost net when I deploy it to ganache with mainnet fork at a specific block, so I use a node with archive state. I deploy it, then make a transaction to it. The function that I called on the contract Mine, calls another function on another contract Theirs. This Theirs contract actually exists in the archive state of mainnet. The called function  on Theirs contract interact with an ERC20 token, which is again in the archive state of mainnet. While processing the transaction, ERC20 contract reverts because of insufficient balance, while in reality the Mine contract has sufficient balance. Note that these all happen in a single atomic transaction.
Is this the expected behaviour when using the fork feature? My observation is that when Mine interacts with Theirs, transaction happens as 'intended', but when 2 contracts which are present in the archive state of mainnet (Theirs and ERC20), they interact in a fashion that the state is solely based on the archive state and things happening in the ganache fork are disregarded.

I asked about this on gitter: [X ]
Link to my question on gitter: https://gitter.im/ConsenSys/truffle?at=5f7b73dadfe47e4d574ca889

Expected Behavior
When two contracts that exist solely in the archive state of mainnet interact which other, the state in ganache fork should be taken into consideration.
Current Behavior
The ganache fork state is disregarded.
Context
See summary.
Your Environment

Version used: Ganache CLI v6.11.0 (ganache-core: 2.12.1)
Version of Truffle/Remix/Other tools used: Truffle v5.1.45
NodeJS Version: v10.19.0
Operating System and version (include distro if Linux): Ubuntu 20.04
Link to your project or repro gist:
Commit hash to use with above link for reproduction:
I intend to submit a pull request to fix this issue: [ ]

Sounds like a bug. I'll add it to this backlog of forking to be worked in the near future.
If you don't mind, can you try the latest ganache-cli@beta? run npm install ganache-cli@beta -g to install it.

Hi @davidmurdoch , I can confirm the same issue with Ganache CLI v6.11.1-beta.1 (ganache-core: 2.13.0-beta.0).

@kmotoko any chance you could give us more reproduction steps and/or code? Supposedly we thought we got to the bottom of this issue in<EMAIL_ADDRESS>(which is now in stableganache-cli@6.12.0). I'm not sure what else to investigate without code to reproduce.


what is difference bewteen jumpto and navigate  in tab

<Button
title="Go to profile"
onPress={() => navigation.jumpTo('Profile', { owner: 'Michaś' })}
/>
or
<Button
title="Go to profile"
onPress={() => navigation.navigate('Profile', { owner: 'Michaś' })}
/>

I believe navigate is a common action that traverses nested navigators and jumpTo is specifically for the current navigator only.

the effect will be the same if you have a tab by the name Profile. but if you don't, and you have a parent navigator with a route by the name Profile, then navigate will switch to that but jumpTo will not. jumpTo is only handled by tab navigators.


trial expiration blocking page should not be able to dismiss

We should hide the x icon there, user can not dismiss that page once their membership is expired. The page is used to block the usage.
One piece to logic need to add though is the logic to reload the membership when the page is viewed so if the user has updated (from web or other source), client shall auto dismiss the page.

What does this have to do with Flurry's SDK?


cordova camera plugin  ios problem ,  how can i show videos only when camera.getPicture ?

as mentioned,  camera.getPicture   with  mediaType:1 ,
expect behavior : show videos only for user to pick up
Result: not only show video but also pictures
iOS 13.3
cordova: 9.0.0
cordova ios : ios 5.1.1
cordova-plugin-camera 4.1.0 "Camera"
how can I show videos only to user  ? Thanks

const options: CameraOptions = {
     destinationType: this.camera.DestinationType.FILE_URI,
     sourceType: this.camera.PictureSourceType.PHOTOLIBRARY,
     mediaType: this.camera.MediaType.VIDEO
   };
   this.camera.getPicture(options).then(
     async videoUrl => {
       console.log("videoUrl: ", JSON.stringify(videoUrl));

this is what i have done for picking video from gallery and it shows only video

Thanks a lot for your issue, however the issue template exists for a reason. 😊.
It helps us to debug the issue further and to provide a solution much faster. With important information missing, we unfortunately can't help you.
Therefore, please edit this issue accordingly or close and create a new one and make sure to provide all the required information.


cluster: fix kvdb unit test

It looks like #5702 was merged prematurely and broke the kvdb unit
tests.

It looks like #5702 was merged prematurely and broke the kvdb unit
tests.

Sorry that was me! I thought auto-merge only ran if all the CI checks passed?

Sorry that was me! I thought auto-merge only ran if all the CI checks passed?

No, I merged the PR manually. I thought the failed test was a known flake, that's why I ignored it. But apparently I didn't look hard enough :(

No, I merged the PR manually.

Good to know the robots aren't taking over just yet 😬 🤖


coverage exlude option overrides defaults

Describe the bug
When using test.coverage.exlude options defaults are being overwritten instead of appending. If it's intentional , then it should be possible to import defaults or optionally append excludes
Reproduction
set test.coverage.exlude, all defaults are being ignored
System Info
System:
    OS: macOS 12.2.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 2.38 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
    Yarn: 3.1.1 - ~/.nvm/versions/node/v16.14.0/bin/yarn
    npm: 8.3.1 - ~/.nvm/versions/node/v16.14.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Browsers:
    Chrome: 99.0.4844.74
    Edge: 99.0.1150.39
    Safari: 15.3
  npmPackages:
    vite: ^2.8.6 => 2.8.6
    vitest: ^0.7.4 => 0.7.4

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Of course it is intended behaviour. If you need to merge them, import defaults from vitest/config.


It should mention that owner role is required if use the default command to create aks cluster

Follow the example, and I got this error:
Waiting for AAD role to propagate[################################    ]  90.0000%Could not create a role assignment for ACR. Are you an Owner on this subscription?
Searched online and found some threads discussing it
Actually, it is an implicit requirement if using the default command, which is mentioned here https://docs.microsoft.com/en-us/azure/aks/cluster-container-registry-integration
It should be stated clearly here.
Making the change to this:
"Note that it requires Owner or Azure account administrator role on the Azure subscription, to avoid it, see ACR authentication with service principals or Authenticate from Kubernetes with a pull secret. Or you can use a managed identity instead of a service principal for easier management."

@dylanw-oss : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dylanw-oss : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dylanw-oss : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dylanw-oss : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Nickomang  can you look at this one as part of the refresh as well?

@Nickomang  can you look at this one as part of the refresh as well?

@dylanw-oss, Thanks for the feedback. I've made a few wording changes and rolled your contribution into a larger PR that encompasses numerous other fixes. Expect to see it live on the docs site by the end of the week.
#please-close

@dylanw-oss, Thanks for the feedback. I've made a few wording changes and rolled your contribution into a larger PR that encompasses numerous other fixes. Expect to see it live on the docs site by the end of the week.
#please-close


Fixed module failure

Owner

[x] Nickname(Tuya): 伽拉
[x] Intra-group review（组内审阅人员）：萧瑟

Description
Fixed module failure.
Package
Please select the relevant package.

[ ] tuya-panel-animation-sdk
[ ] tuya-panel-api
[ ] tuya-panel-electrician-sdk
[x] tuya-panel-ipc-sdk
[ ] tuya-panel-lamp-sdk
[ ] tuya-panel-lock-sdk
[ ] tuya-panel-robot-sdk
[ ] tuya-panel-outdoor-sdk

Type of change
Please select the relevant option.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Self CheckList
Please check all options.

[ ] Intra-group review
[ ] ESLint lint
[ ] Example Run
[ ] Jest Run
[ ] No Grammer Error
[ ] No Spell Error
[ ] No Merge Conflict

Codecov Report

Merging #119 (edfafdf) into main (e09fd08) will increase coverage by 1.86%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   62.29%   64.16%   +1.86%
==========================================
  Files         226      238      +12
  Lines        8538     9021     +483
  Branches     1998     2153     +155
==========================================
+ Hits         5319     5788     +469
  Misses       3212     3212
- Partials        7       21      +14

Impacted Files
Coverage Δ

...-ipc-sdk/src/ty-ipc-native/player-manager-func.tsx
16.47% <66.66%> (-0.07%)
:arrow_down:

...c-sdk/src/ty-ipc-native/tyrctOrientationManager.ts
100.00% <100.00%> (ø)

packages/tuya-panel-api/src/robot/gyroDataApi.ts
9.72% <0.00%> (ø)

packages/tuya-panel-api/src/robot/laserDataApi.ts
8.88% <0.00%> (ø)

...l-gateway-sdk/src/components/setPassword/index.tsx
48.27% <0.00%> (ø)

...-gateway-sdk/src/components/addDeviceTip/index.tsx
40.74% <0.00%> (ø)

...teway-sdk/src/components/deviceListPanel/index.tsx
41.88% <0.00%> (ø)

...rician-sdk/src/components/curtain/curtain-base.tsx
1.03% <0.00%> (ø)

...cian-sdk/src/components/layout/modal-container.tsx
3.48% <0.00%> (ø)

...sdk/src/components/ele-setting/container/index.tsx
22.80% <0.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09fd08...edfafdf. Read the comment docs.


Bug: eqMac crashing on startup.

Attaching crash log from Problem Report dialog. It says eqMac quit unexpectedly.
crashlog.txt

Related to #222


[BACKLOG-14992] Fix to conversions from String when a mask isn't already set.

@pentaho/millenniumfalcon @TatsianaKasiankova please review
The second commit is a cleanup (removing deprecated Assert.* ) and it is the source of most of changed lines

@TatsianaKasiankova sorry for merging so quickly, didn't notice you were mentioned. Please review and comment if you find something, this can be reverted if needed.

the default mask is shit,i cannot update from 6.1 to 8.0,because the big number has .0
the modify is faild, not good for big number,and has no reason to modify the default mask


Add documentation for writing tests with signed actor cookies

I use this pattern in a lot of plugin tests, e.g. https://github.com/simonw/datasette-edit-templates/blob/087f6a6cabc20020f2b0524f11aa3a7836320848/tests/test_edit_templates.py#L55-L58
    actor = ds.sign({"a": {"id": "root"}}, "actor")
    response1 = await ds.client.get(
        "/-/edit-templates/_footer.html", cookies={"ds_actor": actor}
    )

I should add this to the documentation on this page: https://docs.datasette.io/en/latest/testing_plugins.html

This can now be done with datasette.client.actor_cookie({"id": "root"}).
https://github.com/simonw/datasette/blob/48148e66a846d585e08ec6ab4ae3da8e60d55ab5/datasette/app.py#L1884-L1891

New docs are here: https://docs.datasette.io/en/latest/testing_plugins.html#using-datasette-client-in-tests


New Stylus Logo

SVG located at http://stylus-lang.com/img/stylus-logo.svg

Updated 4413382f761cfa4446446bc1f52cd30df12102f0
Thanks


Revert "CLOUD-52680 azure images"

Reverts sequenceiq/cloudbreak#1365

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2181/


Memory leak issue with maskrcnn

❓ Questions and Help
I am running maskrcnn_benchmark in the server and facing an issue of memory leak. I have made a flask application which when gets a request utilizes 800 MB of memory. On making another request the memory starts accumulating from 800 MB and goes further. On sending multiple requests simultaneously the program occupies all the allocated memory and exits.
I am not able to figure out where the memory is leaking.
I am attaching some code snippets where I am using maskrcnn in my program.
def process_maskrcnn(self,front,side):
        # try:
        self.obj_maskrcnn.loader()
        frontrcnnmask,frontmask = self.obj_maskrcnn.run_maskrcnn(front,'f')
        sidercnnmask,sidemask = self.obj_maskrcnn.run_maskrcnn(side,'s')
        cv2.imwrite("frontmaskrcnn.jpg",frontrcnnmask)
        cv2.imwrite("sidemaskrcnn.jpg",sidercnnmask)
        gc.collect()
        return True,frontrcnnmask,sidercnnmask,frontmask,sidemask

def run_maskrcnn(self, image,pose):
        if pose == 'f':
            predictions = self.compute_prediction(image)
            top_predictions = self.select_top_predictions(predictions)
            result = image.copy()
            maskimg,maskimgall = self.overlay_mask(result, top_predictions)
            # kernel = cv2.getStructuringElement(cv2.MORPH_ELLIPSE, (3, 3))
            # maskimg = cv2.dilate(maskimg, kernel)
            # maskimgall = cv2.dilate(maskimgall, kernel)
            if cfg.debug == 'True':
                cv2.imwrite(self.outputdir + '/front.jpg', maskimg)
            return maskimg, maskimgall
        if pose == 's':
            predictions = self.compute_prediction(image)
            top_predictions = self.select_top_predictions(predictions)
            result = image.copy()
            maskimg, maskimgall = self.overlay_mask(result, top_predictions)
            kernel = cv2.getStructuringElement(cv2.MORPH_ELLIPSE, (15, 15))
            maskimg = cv2.dilate(maskimg, kernel)
            maskimgall = cv2.dilate(maskimgall, kernel)
            if cfg.debug == 'True':
                cv2.imwrite(self.outputdir + '/side.jpg', maskimg)
            return maskimg, maskimgall

def compute_prediction(self, original_image):
        image = self.transforms(original_image)
        image_list = to_image_list(image, self.cfg.DATALOADER.SIZE_DIVISIBILITY)
        image_list = image_list.to(self.device)
        with torch.no_grad():
            predictions = self.model(image_list)
        predictions = [o.to(self.cpu_device) for o in predictions]
        prediction = predictions[0]
        height, width = original_image.shape[:-1]
        prediction = prediction.resize((width, height))
        if prediction.has_field("mask"):
            masks = prediction.get_field("mask")
            masks = self.masker([masks], [prediction])[0]
            prediction.add_field("mask", masks)

def select_top_predictions(self, predictions):
        scores = predictions.get_field("scores")
        keep = torch.nonzero(scores > self.confidence_threshold).squeeze(1)
        predictions = predictions[keep]
        scores = predictions.get_field("scores")
        _, idx = scores.sort(0, descending=True)
        return predictions[idx]```

I have the same problem. Have you solved your problem?

@sanli0 What OS are you running maskrcnn_benchmark?

centos

I used something like this to resolve the issue:
def process_maskrcnn(self, image):
        try:
            manager = multiprocessing.Manager()
            return_dict = manager.dict()

            def worker_process(return_dic, image):
                imagercnnmask,  imagemask = self.obj_maskrcnn.run_maskrcnn(image)
                return_dic['1'] = True
                return_dic['2'] = imagercnnmask
                return_dic['3'] = imagemask
            p = Process(target=worker_process, args=(return_dict, image))
            p.start()
            p.join()
            return return_dict.values()

        except:
            return False, None, None, None, None

@sanli0 Did it solve your problem?


Selection tool not working

Not working since installing the newest version of AppGeo.Clients.dll (10/27/2015 build)

Our testing of the most current development branch release gives the selection tool click and drag functionality for multi-feature selection, which was missing previously.  Some selection testing on this deployment http://gis.amherstma.gov/gpv2015/viewer.aspx in Chrome was successful.  Please reopen a new issue if your selection issue persists with some more details.  Thanks

I'm sorry that I didn't provide more details. I tested this feature on Safari on a Mac, on which selection still does not work.
I've done some quick testing on a few other browsers:
Single-feature selection works on: MS IE/Edge on Windows, Firefox on Mac
Select with Shift or crtl works on: MS IE/Edge on Windows, Firefox on Mac
Multi-feature select by click/drag works on: MS IE/Edge on Windows

This is still an issue.  I cannot select features using my Android tablet in Chrome 46.

This wasn't caused by AppGeo.Clients.dll.  Rather it was a misunderstanding of how touch events work on a mobile device.  Now fixed.


Extend testing options for functional-test automation

What would you like to be added:
Currently there's not a good way to perform per test setup/breakdown for things outside of k8s artifacts.
Why is this needed:
Some tests may require setting up specific scenarios before/after a given functional test. Example:
NodePort test should add an annotation to the target namespace and then remove it when done.
Ideally this is done in a generic way where each resource type can have a setup/breakdown related hook.

Some examples depending on the level of granularity:
Per Resource type:
resources:
name: deployments
    pre:
      - pre-script1.sh
      - pre-script2.sh
    post:
      - post-script1.sh
      - post-script2.sh
    tests:
      pass:
        - test-deploy01.yaml
        - test-deploy03.yaml
        - test-deploy04.yaml
        - test-deploy05.yaml
        - test-deploy06.yaml
        - test-deploy07.yaml
        - test-deploy08.yaml
        - test-deploy09.yaml
        - test-deploy10.yaml
        - test-deploy11.yaml
      fail:
        - test-deploy02.yaml

Per Test:
resources:
name: deployments
    tests:
      pass:
        - test-deploy01.yaml
          pre:
            - pre-script1.sh
          post:
            - post-script1.sh
        - test-deploy03.yaml
          pre:
            - pre-script1.sh
          post:
            - post-script1.sh
        - test-deploy04.yaml
      fail:
        - test-deploy02.yaml

Accepting something like this would allow you to have a similar functionality to declaring large blocks of pre/post scripts (like having pre/post resource scope scripts but it would also allow you to declare deployment tests that have different pre/post setups as well. In this case you have tests 1-11 having the same setup as with the resource scope declaration but you also have test 12 which could now have an entirely different setup as referenced in pre/post-script3.sh scripts. It comes at a cost of increased verbosity though because instead of having a single declaration area at the resource scope which defines the pre/post scripts for all testing scenarios on that resource (i.e pass only, fail only or all) you now really should ensure that pre/post are declared inside pass and inside fail scopes even if they are the same exact setup scripts being run. This would help with cases where you run pass only on all resources types. If pre/post are not declared and cleaned up inside the pass block then cleanup would not be occurring which could lead to failures of CI because pre run scripts for testing on 1 resource type that do not get cleaned up might interfere with the setup for the next resource type.
Per Test but pre/post not required:
resources:
name: deployments
    tests:
      pass:
        - test-deploy01.yaml
          pre:
            - pre-script1.sh
            - pre-script2.sh
        - test-deploy02.yaml
        - test-deploy03.yaml
        - test-deploy04.yaml
        - test-deploy05.yaml
        - test-deploy06.yaml
        - test-deploy07.yaml
        - test-deploy08.yaml
        - test-deploy09.yaml
        - test-deploy10.yaml
        - test-deploy11.yaml
          post:
            - post-script1.yaml
            - post-script2.yaml
        - test-deploy12.yaml
          pre:
            - pre-script3.sh
          post:
            - post-script3.sh

      fail:
        - test-deploy02.yaml
          pre:
            - pre-script1.sh
            - pre-script2.sh
          post:
            - post-script1.yaml
            - post-script2.yaml

In this idea the setup scripts would need to accept a mandatory argument "setup, teardown, reset"
resources:
name: deployments
    tests:
      pass:
        group:
          setup: script1.sh
          manifests:
            - test-deploy01.yaml
            - test-deploy02.yaml
        group:
          setup: script2.sh
          manifests:
            - test-deploy03.yaml
            - test-deploy04.yaml

Should this manifest format be versioned so no version or say v1 would be the current behavior and if you specify v2 it would allow this grouping and scripting?
version: v2
resources:
name: deployments
    tests:
      pass:
        group:
          setup: script1.sh
          manifests:
            - test-deploy01.yaml
            - test-deploy02.yaml
        group:
          setup: script2.sh
          manifests:
            - test-deploy03.yaml
            - test-deploy04.yaml

I don't think that's necessary. We have a small number of tests right now and should be able to accomplish the transition atomically within a single PR. Do you see a need to keep the old logic around once we've transitioned to the new format.

I thought it might be something worth considering but if you see no real benefit to maintaining some support for the old manifest format I agree its simpler and keeps the code base cleaner to just migrate over to the new format all at once.


Fix (most of) mem problems

Reference Issue
This PR is in relation with issue #2107. It may be considered as a followup for PR #2113.
What does this implement/fix? Explain your changes.
This PR includes fixes to most mem problems detected by using what I suggested in #2113.
Most of the fixes are in test files, but there are also some fixes in RDKit code. Probably some of those fixes won't be the best solution (I tried not to break anything else), so please feel free to use those that you see fit, or to change them to something better.
Due to the extension of this PR, instead of submitting all of the changes in a single commit, I thought it might be a better idea to push my work branch directly, since each commit more or less addresses the problems discovered in a single test file.
An updated rdkit_valgrind.suppressios file is also provided. It contains suppressions for the following mem problems:

Boost libraries (not really a problem, since the memory is recovered by the OS at program termination).
Some leaks in externals MaeParser & Coordgen.
Leaks in SMILES/SMARTS/SLN parsers. These leak on parser failures. I tried to address some of them by patching smiles.yy, but I am not familiar with flex/bison, so I cannot make much progress in that.

Thanks for this!
Since it's a big set of changes, it's going to take me a bit to go through them (and #2113) to make sure I'm comfortable with it. I will try to get it done this week.

No problem, Greg. It was actually fun chasing these.
Please let me know if you need any clarifications on the changes, or if you think there is a better option that the one I used (I'm sure there will be!).

I've now gone through all the changes to the non-testing code and think things mostly look good - just a few suggestions there.
I still want to confirm that everything builds and the tests pass on my windows machine, but I'm not anticipating any problems there.
With the questions/comments made above addressed, I'd be willing to merge this.

@bp-kelley : this works for me on windows and linux and the travis tests are passing on both linux and the mac. I think it's fine to merge as is. You ok with that?

Heck yes!  This is too much good work to ignore :). Merge away.


Move dependency requirement to client

Thanks for working on this directive.
This PR moves the vue dependency to peerDependencies.
Also, I couldn't find anywhere in the code where core-js was being used. I moved it to devDependencies.

That's indeed more appropriate, thanks !


Create common px4 config for avoidance

Previously, the px4 configuration in the avoidance_sitl_mavros.launch was located under the local planner. However, this launch file is used by both local and global planner. This required to build local_planner in the workspace to use global_planner
This PR adds a new px4_config.yml configuration file that is under the avoidance package that can be shared by all planners. The contents are currently identical with the config file in local planner. I have not deleted the config file under local planner in case we need local_planner specific configuration of the firmware

@mrivi I have tested against local and global planner.

@Jaeyoung-Lim cool, thanks! Safe landing planner is working as well.
Do you mind updating the generate_launchfile.sh for both the local and safe landing as well?

@jkflying Can we get this merged? I am repeatedly running into this problem when trying to clean up the workspace and build global_planner


Added type annotation to helpers, added ts declaration files for angu…

Issue:
Modules "storybook/angular" and "storybook/anguar/demo" has no type declaration files and
angular helpers has no proper typings. ts-loader throws many errors with "noExplicitAny" flag enabled. Issue
What I did
Added type declaration fles for "storybook/angular" and "storybook/anguar/demo" modules. Annotated angular helpers functions
How to test
Set "noExplicitAny": true in tsconfig.json
Is this testable with jest or storyshots?
no
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
no

Not sure if this is you or on master but it looks like the tests are broken:
WARNING in /tmp/storybook/node_modules/<EMAIL_ADDRESS>122:24-38 "export 'InjectionToken' was not found in '@angular/core'
 @ /tmp/storybook/node_modules/<EMAIL_ADDRESS><EMAIL_ADDRESS> @ /tmp/storybook/app/angular/dist/client/preview/angular/helpers.ts
 @ /tmp/storybook/app/angular/dist/client/preview/render.js
 @ /tmp/storybook/app/angular/dist/client/preview/index.js
 @ /tmp/storybook/app/angular/dist/client/index.js
 @ ./.storybook/config.js
 @ multi /tmp/storybook/app/angular/dist/server/config/polyfills.js /tmp/storybook/app/angular/dist/server/config/globals.js /tmp/storybook/app/angular/node_modules/webpack-hot-middleware/client.js?reload=true ./.storybook/config.js

WARNING in<EMAIL_ADDRESS>123:57-89 "export 'ɵCodegenComponentFactoryResolver' was not found in '@angular/core'
<EMAIL_ADDRESS> @ /tmp/storybook/app/angular/dist/client/preview/angular/helpers.ts
 @ /tmp/storybook/app/angular/dist/client/preview/render.js
 @ /tmp/storybook/app/angular/dist/client/preview/index.js
 @ /tmp/storybook/app/angular/dist/client/index.js
 @ ./.storybook/config.js
 @ multi /tmp/storybook/app/angular/dist/server/config/polyfills.js /tmp/storybook/app/angular/dist/server/config/globals.js /tmp/storybook/app/angular/node_modules/webpack-hot-middleware/client.js?reload=true ./.storybook/config.js

WARNING in<EMAIL_ADDRESS>128:45-49 "export 'ɵcmf' was not found in '@angular/core'
<EMAIL_ADDRESS> @ /tmp/storybook/app/angular/dist/client/preview/angular/helpers.ts
 @ /tmp/storybook/app/angular/dist/client/preview/render.js
 @ /tmp/storybook/app/angular/dist/client/preview/index.js
 @ /tmp/storybook/app/angular/dist/client/index.js
 @ ./.storybook/config.js
 @ multi /tmp/storybook/app/angular/dist/server/config/polyfills.js /tmp/storybook/app/angular/dist/server/config/globals.js /tmp/storybook/app/angular/node_modules/webpack-hot-middleware/client.js?reload=true ./.storybook/config.js

@ndelangen who can review these angular PRs? there's a few of these just sitting around now

@danielduan I think it is some npm packages conflict in parent branch: https://stackoverflow.com/questions/44656265/export-ɵcmf-was-not-found-in-angular-core

FYI: test passes on upstream branch: https://circleci.com/gh/storybooks/storybook/24979

Here it fails because of errors not warnings:
ERROR in /tmp/storybook/app/angular/src/client/preview/angular/helpers.ts
(52,5): error TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in /tmp/storybook/app/angular/src/client/preview/angular/helpers.ts
(151,5): error TS90010: Type 'PlatformRef' is not assignable to type 'PlatformRef'. Two different types with this name exist, but they are unrelated.

ERROR in /tmp/storybook/app/angular/dist/client/preview/angular/helpers.ts
(52,5): error TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in /tmp/storybook/app/angular/dist/client/preview/angular/helpers.ts
(151,5): error TS90010: Type 'PlatformRef' is not assignable to type 'PlatformRef'. Two different types with this name exist, but they are unrelated.
  Property '_injector' is missing in type 'PlatformRef'.

@alterx do you want to approve and merge this?

@ndelangen lets wait until we approve and merge https://github.com/storybooks/storybook/pull/2467/files/a55741d4e1e7de20553a826172fa946d518e396e..fef3b9883089409971a028dc59db1f9b5e8b5dae

Seems like the CLI tests are breaking over this:
ERROR in /tmp/storybook/app/angular/src/client/preview/angular/helpers.ts
(139,5): error TS2345: Argument of type '(PipeTransform | IComponent | typeof AppComponent)[]' is not assignable to parameter of type '(any[] | Type<any>)[]'.
  Type 'PipeTransform | IComponent | typeof AppComponent' is not assignable to type 'any[] | Type<any>'.
    Type 'PipeTransform' is not assignable to type 'any[] | Type<any>'.
      Type 'PipeTransform' is not assignable to type 'Type<any>'.

ERROR in /tmp/storybook/app/angular/src/client/preview/angular/helpers.ts
(179,68): error TS2345: Argument of type '{ component: any; props: { message: string; stack: string; }; propsMeta: {}; }' is not assignable to parameter of type 'Data'.
  Property 'pipes' is missing in type '{ component: any; props: { message: string; stack: string; }; propsMeta: {}; }'.

ERROR in /tmp/storybook/app/angular/dist/client/preview/angular/helpers.ts
(139,5): error TS2345: Argument of type '(IComponent | PipeTransform | typeof AppComponent)[]' is not assignable to parameter of type '(any[] | Type<any>)[]'.
  Type 'IComponent | PipeTransform | typeof AppComponent' is not assignable to type 'any[] | Type<any>'.
    Type 'PipeTransform' is not assignable to type 'any[] | Type<any>'.
      Type 'PipeTransform' is not assignable to type 'Type<any>'.
        Property 'apply' is missing in type 'PipeTransform'.

ERROR in /tmp/storybook/app/angular/dist/client/preview/angular/helpers.ts
(179,68): error TS2345: Argument of type '{ component: any; props: { message: string; stack: string; }; propsMeta: {}; }' is not assignable to parameter of type 'Data'.
  Property 'pipes' is missing in type '{ component: any; props: { message: string; stack: string; }; propsMeta: {}; }'.
Child html-webpack-plugin for "index.html":
         Asset    Size  Chunks  Chunk Names
    index.html  569 kB       0
       [0] /tmp/storybook/node_modules/html-webpack-plugin/lib/loader.js!/tmp/storybook/app/angular/dist/server/index.html.ejs 1.7 kB {0} [built]
       [1] /tmp/storybook/node_modules/lodash/lodash.js 540 kB {0} [built]
       [2] (webpack)/buildin/global.js 509 bytes {0} [built]
       [3] (webpack)/buildin/module.js 517 bytes {0} [built]
Child html-webpack-plugin for "iframe.html":
          Asset    Size  Chunks  Chunk Names
    iframe.html  568 kB       0
       [0] /tmp/storybook/node_modules/html-webpack-plugin/lib/loader.js!/tmp/storybook/app/angular/dist/server/iframe.html.ejs 886 bytes {0} [built]
       [1] /tmp/storybook/node_modules/lodash/lodash.js 540 kB {0} [built]
       [2] (webpack)/buildin/global.js 509 bytes {0} [built]
       [3] (webpack)/buildin/module.js 517 bytes {0} [built]
error Command failed with exit code 1.

@ndelangen @alterx  I fixed conflicts, but i think we should enable "noImplicitAny" flag in tsconfig, because without it typescript is useless, and we will get broken typings after each merge.

What do you think @alterx @igor-dv ?

Yeah, I agree. If we're going to have type definitions we need to enforce its use.
On a non-related note, I think we need to fix IGetStory to include the new moduleMetadata

👏


Add an Eliza-style chatbot.

This example is intended to demonstrate how to use the DetailedList widget to implement a chat interface.

@Ocupe The perils of last minute refactoring :-) I've just pushed an update that should correct the problems you found - can you re-check?

@freakboy3742 now it works!


Added custom callback function for directive, and shorten the timeouts

I need this for resizing my custom reCaptcha form from the default.

I think this has been abandoned. Please, reopen otherwise.


shipping-experimental-feature-in-modular-design

This PR is meant to design on how to ship experimental features in modular design.

@jeremymeng @witemple-msft Thanks for your comments, I feel like there might be some misunderstand of what the experimental features refer to.
From my limited conversation with @bterlson, I guess what we want to experiment is some kind of client side features, some kind of TypeScript language proposals that may have not been accepted by the TypeScript Team or the committee yet but we want to try out in our SDK similar like this one https://github.com/Azure/azure-sdk-for-js/pull/25893. it should not tie up to any particular service versions,
For example,
In the view of the track1 SDK, we have enabled async/await feature to replace the callback in track2 SDK. that would count as a new experimental feature at that time.
in the view of the track2 SDK, Modular would count as a new experimental feature.
The reason why we want to have a place to do such kind of experiments, I guess, is that we are trying to get some early feedbacks from our customers about those experimental features, which in return may help provide evidence for accelerating the experimental features to go GA or Withdrawn.
Feel free to correct me if I misinterpret anything from you @bterlson  :)
cc @xirzec @mpodwysocki

@qiaozha sorry for any confusion I may have introduced. We've previously had some discussions on the team about a totally different subject that uses almost the exact same set of terms to describe it.

@qiaozha sorry for any confusion I may have introduced. We've previously had some discussions on the team about a totally different subject that uses almost the exact same set of terms to describe it.

I am not sure, maybe I was wrong.

FWIW I did not have that understanding of "experimental" either, I was talking more about experimental client APIs (that often but not always involve calling experimental/"preview" service endpoints). Generally this is used to light up some new feature that is coming that we want to get feedback on, and the idea is if we include such APIs in the GA package (but clearly delineated and opt-in) it will be much easier for users to try and give feedback. But I think this is a superset of what you were saying - adopting a new language feature that has a large impact on our API surface area would be a good usecase as well, tho I would imagine not very common.


BLE Mesh On Net Buffer free issue

FUNCTION1
https://github.com/zephyrproject-rtos/zephyr/blob/2b84c726c8893eaaa1bf26dfddf2798b159cd47d/subsys/bluetooth/mesh/friend.c#L90-L111
FUNCTION2
https://github.com/zephyrproject-rtos/zephyr/blob/2b84c726c8893eaaa1bf26dfddf2798b159cd47d/subsys/bluetooth/mesh/adv.c#L242-L252
FUNCTION3
https://github.com/zephyrproject-rtos/zephyr/blob/2b84c726c8893eaaa1bf26dfddf2798b159cd47d/subsys/bluetooth/mesh/friend.c#L166-L205
FUNCTION4
https://github.com/zephyrproject-rtos/zephyr/blob/2b84c726c8893eaaa1bf26dfddf2798b159cd47d/subsys/bluetooth/mesh/adv.c#L159-L196
when the buffer create from FUNCTION1, then the buf ref=1, we send this buffer use FUNCTION2, this time the buf ref=2, when the friend terminated and buf also in adv_queue, the FUNCTION3 will be call, in this function unref the last_buf, and set BUSY=0, so buf ref=1,when FUNCTION4 get cpu times, will get buffer from adv_queue, but the BUSY flag we already cleared, so this buffer not send, and the buf also ref=1. so at this time the memory leak occurs.
If I infer that it is correct, Can be modified like this:
 	if (BT_MESH_ADV(buf)->busy) {
 		BT_MESH_ADV(buf)->busy = 0U;
 		adv_send(buf);
 	}
        else{
                net_buf_unref(buf);
        }

@jhedberg

@menglingao1997 your suggested fix looks correct. Do you want to try creating a pull request for it? I'm still on vacation, so I'll be able to do it earliest next week.

Isn't this a duplicate of #17936 ?

look like this, and may be able to solve in the same way.


Docs.MS CI Updates for Azure.Template

CI Update for release of Azure.Template

Docs Build status updates of commit 52c5902:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 52c5902:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

bundlepackages/azure-dotnet-preview.csv
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add Reflection Probes + Reflection Probe Blending

We want to add reflection probes to our https://github.com/webaverse/three/tree/r143 branch of three.js
Mozilla has done this here:
https://github.com/MozillaReality/three.js/pull/59/files
https://github.com/MozillaReality/three.js/pull/60
Finally, we want to be able to add these reflection probes into our .scn file so they can be loaded and tested. We may need to create a new type like 'application/reflectionprobe' type. This could follow the other apps (see .scn files in the scenes folder for examples of different app implementations)

Just a heads up, the way we manage our threejs patches is slightly odd. We have a branch called hubs-patches-141 where each commit is an individual patch. This is the current latest version of the reflection probe patch https://github.com/MozillaReality/three.js/commit/7c6fb585ffa7737544871d2bbd4b0864c316f148 but it is best to check https://github.com/MozillaReality/three.js/commits/hubs-patches-141 as it gets rebased sometimes when we need ot make changes.
The current implementation is somewhat hacky and fairly barebones, but it mostly works. Note that right now it requires that all reflection probes and the environment map for the scene are all the same resolution. In the version of ThreeJS this patch was originally written for, all environment maps were statically resized during PMREM generation, but that was later fixed in ThreeJS. This requires that we actually more properly add support for the secondary environment map, which we just haven't bothered to do yet since our Blender addon just enforces this constraint, and it has not really been a concern for artists.
We are also keeping an eye on GLTF extensions in this space, and work being done in upstream ThreeJS.


Please add two pages view in pdfviewer

Configuration:

Web browser and its version:Version 110.0b9 (64-bit)
Operating system and its version: Windows 10 Pro
PDF.js version:
Is a browser extension:No

Steps to reproduce the problem:

It shows only a single page but I want it to be a two page view like a book

It should look as if we see pages of pdf in form of  book with two pages to be seen.

What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Duplicate of #590, which was implemented in PR #9208 over four years ago :-)


Support for fasthttp

Hey!
I am wondering does this lib support https://github.com/valyala/fasthttp integration, if instead of using net/http we use fasthttp? That would be great if that was possible to use fasthttp instead of std lib!

I've written some glue code to support fiber, and theoretically fasthttp could be used in a similar way.
package main

import (
	"bufio"
	fiber "github.com/gofiber/fiber/v2"
	"github.com/lxzan/gws"
	"log"
	"net"
	"net/http"
	"net/url"
)

func main() {
	upgrader := gws.NewUpgrader(&Handler{}, nil)

	app := fiber.New(fiber.Config{})

	app.Get("/connect", func(c *fiber.Ctx) error {
		r, err := getRequest(c)
		if err != nil {
			return err
		}
		c.Context().HijackSetNoResponse(true)
		c.Context().Hijack(func(conn net.Conn) {
			w := &responseWriter{
				conn: conn,
			}
			socket, err := upgrader.Upgrade(w, r)
			if err != nil {
				log.Printf(err.Error())
				return
			}
			socket.ReadLoop()
		})
		return nil
	})

	app.Listen(":3003")
}

func getRequest(c *fiber.Ctx) (*http.Request, error) {
	URL, err := url.Parse(string(c.Request().URI().FullURI()))
	if err != nil {
		return nil, err
	}

	var r = &http.Request{
		Method: c.Method(),
		Header: http.Header{},
		URL:    URL,
	}
	c.Request().Header.VisitAll(func(key, value []byte) {
		r.Header.Set(string(key), string(value))
	})
	return r, nil
}

type responseWriter struct {
	conn net.Conn
}

func (r *responseWriter) Hijack() (net.Conn, *bufio.ReadWriter, error) {
	return r.conn, nil, nil
}

func (r *responseWriter) Header() http.Header { return http.Header{} }

func (r *responseWriter) Write(bytes []byte) (int, error) { return 0, nil }

func (r *responseWriter) WriteHeader(statusCode int) { return }

type Handler struct {
	gws.BuiltinEventHandler
}

func (c *Handler) OnMessage(socket *gws.Conn, message *gws.Message) {
	defer message.Close()
	socket.WriteMessage(message.Opcode, message.Bytes())
}

I will try to give it a try sometime later, not sure how tricky it would be as fasthttp is not directly net/http compatible.
i believe there are some libraries that have websocket built on top of the fasthttp (seen them in readme of the fasthttp) including port of gorilla websocket, but i do like/prefer this lib as the code is very clean an well structured, and it is nicer to go through etc…

Was able to hook it up to fast API, seems to work correctly! A quick question, we are converting the fast API request to default http request by copying over the headers and other items. And wrapping in to the response writer the connection. In your opinion does it have any negative impact on performance ? (just curios, have not done any testing myself yet)

The performance will be reduced a bit, you can test it.


Number or time picker preference not exists ?

Hello,
I'm trying to add a preference like EditTextPreference.
This should be a dialog where the user have to pick time (with time or number picker).
Using inputType attribute seems to be no longer available.
I have looked into this project sample but I don't find any way to do that.
Is it possible to do that with Androidx lib ?
Thanks.

solution : https://medium.com/@JakobUlbrich/building-a-settings-screen-for-android-part-2-2ba63e2d7d1d


BackgroundCheck.destroy();

Hi there!
After applying:
BackgroundCheck.destroy();
There is in Google Chrome console:
Uncaught Unknown property - windowEvents
z @ background-check.min.js?ver=4.2.2:5
x @ background-check.min.js?ver=4.2.2:5

is fixed with pull-request #46


Support Tekton "Bundles" stored in Git repos

Feature request
Via https://github.com/tektoncd/pipeline/issues/1839 we now support referencing versioned Tasks and Pipelines in OCI registries (https://github.com/tektoncd/pipeline/blob/master/docs/pipelines.md#tekton-bundles).
As highlighted in @ImJasonH 's early design doc this opens up the possibility to refer to Tekton resources (bundles?) in other locations as well, specifically in this issue I'd like to request/propose we add support for referencing Tasks and Pipelines in git, e.g. something like:
apiVersion: tekton.dev/v1alpha1
kind: TaskRun
metadata:
  name: my-task-run
spec:
  taskRef:
    git:
      url: https://github.com/my/repo
      commit: deadbeef
      path: path/to/my/task.yaml

Use case

I would like to set up a triggering system that uses my git repo as the source of truth for my Pipelines and Tasks, so that they can be versioned alongside my code, and so that I can make changes to these Pipelines and Tasks in my PRs that are picked up and used by CI

For example I could make a TriggerTemplate like:
apiVersion: triggers.tekton.dev/v1alpha1
kind: TriggerTemplate
metadata:
  name: run-tests
spec:
  params:
  - name: commitish
    description: The commitish to grab the Pipeline from to run
    default: master
  resourcetemplates:
  - apiVersion: tekton.dev/v1beta1
    kind: PipelineRun
    metadata:
      generateName: run-tests-$(uid)-
    spec:
      pipelineRef:
        git:
          url: https://github.com/my/repo
          # This would let me include any changes to the Pipeline in the PR testing
          commit: $(params.commitish)
          path: path/to/my/pipeline.yaml

Additional info

We'll have to figure out how to provide credentials for this as well
We've been talking about whether or not our git-init cmd binary continues to live in this project ( + @sbwsg ), if we want git support in the Tekton Pipelines controller I wonder if it might stick around after all

"Support Tekton "Bundles" stored in Git repos" should probably renamed to "Support TaskRef/PipelineRef to refer to Git repos" instead :wink:

@bobcatfish Which then is a duplicates from https://github.com/tektoncd/pipeline/issues/2298 :stuck_out_tongue_closed_eyes:

hahaha that's how much I like this feature!


Make verbose compile more verbose...

This changes compile do print the proper command output when running in verbose mode (-v).
Eg: arm-none-eabi-gcc -D... bla.o ...
Also removed a "duplicated" (kinda) link message.

I haven't seen before the ShellCommand already prints the command if loglevel==debug. Will close this one for now.


A way to prevent vars array auto-expansion

As far as I understand (maybe I'm missing something?) there is no way to pass an array as a vars property value without promptfoo assuming it is specifying multiple test-cases and auto-expanding the test definition, running it multiple times using a different array element in each run. This is a nifty feature, but it would be great to have a way to turn it off, ideally at the test-definition level, but even globally for the whole promptfoo configuration file.
Example configuration -
Assuming a prompt that looks like this
const prompt = ({ vars:  ingredients }) => {
	return [
		{
			"role": "system",
			"content": "You are a recipe suggestion bot, suggest a recipe that that uses the list of ingredients provided";
		},
		{
			"role": "user",
			// here I'm joining the values with line breaks, but you could imagine I might want to compare this
			// with another prompt version in which the values are numbered, for example.
			"content": ingredients.join("\r\n")
		}
	];
};
module.exports = prompt;

One might want to construct a test like this -
tests:
  - vars:
      ingredients:
        - Microwave popcorn
        - Ground beef
        - Pop Rocks

But as far as I can see there is no way to make this work, currently. When running, the prompt will get called 3 times with a ingredients being a string (i.e. a single array element each time) instead of the expected array.

#476 adds an envar that disables var expansion.  Unfortunately our options are limited because I don't want to break people who are using this feature.  Will merge after I test etc

@typpo thanks for the quick response!
What if it was a setting on the testCase itself? i.e. somthing like
tests:
  - disableVarExpansion: true
    vars:
      ingredients:
        - Microwave popcorn
        - Ground beef
        - Pop Rocks

That way you're giving more granular control without breaking any existing setups (assuming disableVarExpansion defaults to false, which it should).
Also, considerting env vars are not a super convenient way to configure things, especially if you have multiple prompfoo files that you're using with different settings, it might be a good idea to just add a new "global settings" section to the promptfoo config definition. Something like that would make it much simpler to "share" test within teams, because you don't have to configure your run environment before every run, which - for a team - would require documenting the "extra steps" needed to make a test work (i.e. which env vars should be set to what value).
i.e. something like
globalSettings:
  disableVarExpansion: true
  disableTemplating: true

tests:
  - vars:
      ingredients:
        - Microwave popcorn
        - Ground beef
        - Pop Rocks

Another option (which I think isn't as good but could also provide an answer to the sharing problem I discribed) would be addin support for .env files. If promptfoo eval would look for an .env file placed next to the prompfoo configuration file itself, and automatically load it, that would also make it easier to share setups without requiring an additional section in the configuration file.

This is published in 0.42.0


Accessory is not reachable when trying to pair with Homekit app

I am trying to set up Homebridge with the latest SmartThings plugin.  It seems to be running fine on my Windows 10 server:
C:\Users\Howard\AppData\Roaming\npm\node_modules\homebridge\bin>node homebridge
[10/2/2016, 5:14:53 PM] Loaded plugin: homebridge-http
[10/2/2016, 5:14:53 PM] Registering accessory 'homebridge-http.Http'
[10/2/2016, 5:14:53 PM] ---
[10/2/2016, 5:14:53 PM] Loaded plugin: homebridge-smartthings
[10/2/2016, 5:14:53 PM] Registering platform 'homebridge-smartthings.SmartThings'
[10/2/2016, 5:14:53 PM] ---
[10/2/2016, 5:14:53 PM] Loaded config.json with 0 accessories and 1 platforms.
[10/2/2016, 5:14:53 PM] ---
[10/2/2016, 5:14:53 PM] Loading 1 platforms...
[10/2/2016, 5:14:53 PM] [SmartThings] Initializing homebridge-smartthings.SmartThings platform...
[10/2/2016, 5:14:53 PM] [SmartThings] Fetching Smart Things devices.
[10/2/2016, 5:14:54 PM] [SmartThings] Device Added - Group switch, Name Garage North, ID 6878311e-c831-4842-8f1f-bb5d84c53041
[10/2/2016, 5:14:54 PM] [SmartThings] Device Added - Group switch, Name Garage South, ID ee95e6ae-bb22-4560-b115-5e9b7482812b
[10/2/2016, 5:14:54 PM] [SmartThings] Device Added - Group sensor, Name SmartSense Motion/Temp Sensor 1, ID d34f0538-c147-4fe6-8f5a-d731f560926e
[10/2/2016, 5:14:54 PM] [SmartThings] Unknown Capabilities: ["Relay Switch"]
[10/2/2016, 5:14:54 PM] [SmartThings] Initializing platform accessory 'Garage North'...
[10/2/2016, 5:14:54 PM] [SmartThings] Initializing platform accessory 'Garage South'...
[10/2/2016, 5:14:54 PM] [SmartThings] Initializing platform accessory 'SmartSense Motion/Temp Sensor 1'...
Scan this code with your HomeKit App on your iOS device to pair with Homebridge:
┌────────────┐
│ 031-45-154 │
└────────────┘

[10/2/2016, 5:14:54 PM] Homebridge is running on port 51826.
I can see Homebridge in Home when I go to add an accessory.  But when I click on Home bridge I get the following:

I'm afraid I am pretty new to all of this and have no idea how to diagnose this issue.  Can anyone point me in the right direction please?
Thanks

I've finally fixed my issues, they were at the end of the day all bonjour issues, download the Discovery - Bonjour Browser App and make sure you can see _hap._tcp. in the local domain, depending on your network setup you may need to enable multicast Forwarding or in my case my wireless controller need to know to snoop for "_hap._tcp.local."

I was able to see _hap._tcp in Discovery all along.  Unfortunately that doesn't seem to address the issue I'm facing.

same problem for me too !


Updated requests rolled back to default after switching to DESIGN mode and then back to DEBUG mode

I have imported the design from the openAPI3.0 file.
I needed a few more requests and tried adding and reordering the requests in the debug mode. but every time I switch back to design mode, my changes are lost and the view resets to the default imported APIs
Here, I added the Auth folder and added a new request Some New Request, and ordered the Login API inside the Auth folder, and renamed it as Reordered Login inside Auth Folder.

When I switched to the design mode and returned back to the debug mode again, all the changes except newer requests are lost and the default environment variables are overridden.

It even clears the form data
before

after

Steps To Reproduce

Create a blank project
In the design tab, add OpenAPI 3.0 design
switch to the DEBUG tab
Reorder the requests (create a folder and move the request inside it, rename the request, etc.)
switch back to the DESIGN tab
again switch back to the DEBUG tab

Might be able to make something happen here, there are some questions that need to be answered before doing exploration though. Especially about user experience. Perhaps the first step is to prevent them from changing and later on show some form of a dialog or alert that there are "updates", and a button to "update now".

Might be able to make something happen here, there are some questions that need to be answered before doing exploration though. Especially about user experience. Perhaps the first step is to prevent them from changing and later on show some form of a dialog or alert that there are "updates", and a button to "update now".


How to import open-im-sdk-wasm in webpack4.x

What would you like to share?
How to use openIM3. x without upgrading to webpack5, the webpack ^ 4.4.2 used in Vue2
Additional information
No response

add patch-package

npm i patch-package

update package.josn scripts

"scripts": {
+  "postinstall": "patch-package"
 }

update open-im-sdk-wasm

node_modules->open-im-sdk-wasm->lib->index.js(index.es.js)

function initWorker() {
    if (typeof window === 'undefined') {
        return;
    }
    // use for webpack 4
    const IMWorker = require('worker-loader!./worker.js');
    worker = new IMWorker.default();
    // use for webpack5+ or vite
    // const isViteEnvironment = import.meta.url.includes('.vite/deps');
    // const isSupportModuleWorker = supportsModuleWorkers();
    // const getWorkerUrl = (url) => url.href.replace('.vite/deps', 'open-im-sdk-wasm/lib');
    // const workerUrl = isSupportModuleWorker
    //     ? new URL('worker.js', import.meta.url)
    //     : new URL('worker-legacy.js', import.meta.url);
    // worker = new Worker(isViteEnvironment ? getWorkerUrl(workerUrl) : workerUrl, {
    //     type: isSupportModuleWorker ? 'module' : 'classic',
    // });
    // This is only required because Safari doesn't support nested
    // workers. This installs a handler that will proxy creating web
    // workers through the main thread
    initBackend(worker);
    rpc = new RPC({
        event: new RPCMessageEvent({
            currentEndpoint: worker,
            targetEndpoint: worker,
        }),
    });
}

patch change

npx patch-package open-im-sdk-wasm

add web worker loader

npm i worker-loader worker-plugin -D

update webpack config

const WorkerPlugin = require("worker-plugin");

...
plugins: [new WorkerPlugin()]
...

import and use

import { getSDK } from 'open-im-sdk-wasm';

const IMSDK = getSDK();

按照上面执行完之后报这个异常怎么解决，之前也出现过但过了一天自己就好了，这次更新了一下sdk又有这个问题了

 按照上面执行完之后报这个异常怎么解决，之前也出现过但过了一天自己就好了，这次更新了一下sdk又有这个问题了

It looks like it failed when calling the cache API. You can raise a separate issue to discuss this issue.


[Bug]: CLI format/diarize issue

What happened?
I'm trying to transcribe and diarize audio from CLI using this command line:
vibe ^
 --model "C:\Users\Cedric\AppData\Local\github.com.thewh1teagle.vibe\ggml-medium.bin" ^
 --diarize ^
 --diarize-vad-model "C:\Users\Cedric\AppData\Local\github.com.thewh1teagle.vibe\segmentation-3.0.onnx" ^
 --diarize-speaker-id-model "C:\Users\Cedric\AppData\Local\github.com.thewh1teagle.vibe\wespeaker_en_voxceleb_CAM++.onnx" ^
 --format txt ^
 --write out.txt ^
 --file "F:\Temp\MP3 Conversion\Output\6cbcc955-b0e6-45ff-8515-57636a97609d.mp3"

2 issues happen:

The output is "defaulted to srt"
There is no diarization

The same file is transcribed and diarized as expected when started from the GUI
Steps to reproduce
exactly as show in the "What happened?" step

What OS are you seeing the problem on?
Windows 11
Vibe v2.6.3 (reported as v0.0.6 when invoked with vibe --version)
Relevant log output
G:\Vibe>vibe ^
More?  --model "C:\Users\Cedric\AppData\Local\github.com.thewh1teagle.vibe\ggml-medium.bin" ^
More?  --diarize ^
More?  --diarize-vad-model "C:\Users\Cedric\AppData\Local\github.com.thewh1teagle.vibe\segmentation-3.0.onnx" ^
More?  --diarize-speaker-id-model "C:\Users\Cedric\AppData\Local\github.com.thewh1teagle.vibe\wespeaker_en_voxceleb_CAM++.onnx" ^
More?  --format txt ^
More?  --write out.txt ^
More?  --file "F:\Temp\MP3 Conversion\Output\6cbcc955-b0e6-45ff-8515-57636a97609d.mp3"

G:\Vibe>Transcribe... 🔄
ggml_vulkan: Found 1 Vulkan devices:
Vulkan0: NVIDIA GeForce RTX 3070 Ti (NVIDIA) | uma: 0 | fp16: 1 | warp size: 32
ggml_backend_sched_alloc_splits: failed to allocate graph, reserving (backend_ids_changed = 1)
ggml_gallocr_reserve_n: reallocating NVIDIA GeForce RTX 3070 Ti buffer from size 0.00 MiB to 25.73 MiB
ggml_gallocr_reserve_n: reallocating CPU buffer from size 0.00 MiB to 0.92 MiB
ggml_gallocr_needs_realloc: graph has different number of nodes
ggml_gallocr_alloc_graph: cannot reallocate multi buffer graph automatically, call reserve
ggml_backend_sched_alloc_splits: failed to allocate graph, reserving (backend_ids_changed = 0)
ggml_gallocr_reserve_n: reallocating NVIDIA GeForce RTX 3070 Ti buffer from size 0.00 MiB to 160.77 MiB
ggml_gallocr_reserve_n: reallocating CPU buffer from size 0.00 MiB to 0.00 MiB
ggml_gallocr_needs_realloc: graph has different number of nodes
ggml_gallocr_alloc_graph: cannot reallocate multi buffer graph automatically, call reserve
ggml_backend_sched_alloc_splits: failed to allocate graph, reserving (backend_ids_changed = 0)
ggml_gallocr_reserve_n: reallocating NVIDIA GeForce RTX 3070 Ti buffer from size 0.00 MiB to 5.86 MiB
ggml_gallocr_reserve_n: reallocating CPU buffer from size 0.00 MiB to 0.00 MiB
ggml_backend_sched_alloc_splits: failed to allocate graph, reserving (backend_ids_changed = 1)
ggml_gallocr_reserve_n: reallocating NVIDIA GeForce RTX 3070 Ti buffer from size 0.00 MiB to 92.14 MiB
ggml_gallocr_reserve_n: reallocating CPU buffer from size 0.00 MiB to 0.88 MiB
{
  "processing_time_sec": 0,
  "segments": [
    {
      "start": 0,
      "stop": 206,
      "text": " Ok so let's start the"
    },
    {
      "start": 206,
      "stop": 460,
      "text": " recording. Do you care"
    },
    {
      "start": 460,
      "stop": 700,
      "text": " about how long it is?"
    },
    {
      "start": 700,
      "stop": 1323,
      "text": " How long can... should"
    },
    {
      "start": 1323,
      "stop": 1805,
      "text": " it be? 10 seconds."
    },
    {
      "start": 1805,
      "stop": 1900,
      "text": " Please stop then."
    }
  ]
}
Invalid format specified. Defaulting to SRT format.
Transcription completed in 3.2s ⏱
Done ✅

I have the same Issue using the CLI

Exact same, no diarization
-f txt  says "Invalid format specified"
/Applications/vibe.app/Contents/MacOS/vibe \
 --model '/***/Library/Application Support/github.com.thewh1teagle.vibe/ggml-medium-q8_0.bin' \
 --diarize \
 --diarize-vad-model '/***/Library/Application Support/github.com.thewh1teagle.vibe/segmentation-3.0.onnx' \
 --diarize-speaker-id-model '/***/Library/Application Support/github.com.thewh1teagle.vibe/wespeaker_en_voxceleb_CAM++.onnx' \
 -f vtt \
 --write out.txt \
 --file "/***/2.wav"


User registration

After entering into the user registration process we can not return to the main application page. Need to resolve and the inputs are not used for the login. Only id is used which is a very inefficient design.
We need to fix the registration process.

Include attributes like username, password, first name and last name for the registration and check whether a user is creating a unique user name.

Now in the registration process, someone will need to provide valid username input to make the registration complete. Also, we need to provide an email and password in the registration process.
2f22d9dd8f8087a017acd6687340fb857c49e86b

Thanks for looking into this!


Infrastructure for GPU devices

An attempt to allow assigning GPU devices through OpenFL.
The PR introduces an optional 'device monitor' plugin for Envoy and two information flows:

GPU status goes from Envoy through Director to the Frontend.
GPU utilization policy that goes the same path but in reversed order.

The Director_Pytorch_Kvasir_UNET example is modified to utilize the new infrastructure.
There are 2 envoys, one that utilizes GPUs and one that does not.
Device assignment for experiment is done through 'device assignment policy' which may be 'cuda preferred' or 'cpu only'

ok to test

ok to test


Feature Request: Push tables to an existing PostgreSQL server

Feature request
Is your feature request related to a problem? Please describe.
I want a streamlined way to push tables from postgres.new to an existing PostgreSQL server.
It is difficult to push tables from postgres.new to an existing PostgreSQL database. The only option is .tar, which is a bad option. When using .tar, errors are thrown on transfer if the sending server's PostgreSQL version does not match the receiving server's PostgreSQL version.
Describe the solution you'd like
Not quite sure. An ironclad way to transfer tables.
Describe alternatives you've considered
.tar
Additional context
Add any other context or screenshots about the feature request here.

Thanks @nogurtMon - we're working with @samwillis to support this via a WASM version of pg_dump. Stay tuned!

@gregnr and @samwillis: Will this also work the other way round? Downloading a table from an existing hosted PostgreSQL server to use it in database.build with the LLM assistant. That would be another feature request.


signal: add hooks for calling fatal error handlers from non-envoy signal handlers.

Commit Message: Add hooks for calling fatal error handlers from non-Envoy signal handlers.
Additional Description:
Move register/removeFatalErrorHandler from SignalAction into a new FatalErrorHandler namespace, and add a new function, callFatalErrorHandlers, which runs the registered error handlers. This makes the crash logging from issue #7300 available for builds that don't use ENVOY_HANDLE_SIGNALS, as long as they do use ENVOY_OBJECT_TRACE_ON_DUMP.
Risk Level: Low
Testing: bazel test //test/...
Docs Changes: n/a
Release Notes: yes
Fixes #11984

Trying to replicate the presubmit failures on my machine. I suspect the mock ends up allocating some memory, but having trouble confirming.

Replicated the failure under Docker, so this should fix it.

Sorry, @mkbehr could you check CI?

Asan CI should be fixed. Clang-tidy is taking a few tries since I'm not able to run it locally and it seems to be picking up old errors - hopefully this run will work.

CI is passing now - can you have a look?

Syncing to head will help with the conflicting files.

CI failure doesn't look related to this PR: it just timed out trying to compile a test.

@zuercher, have you had a chance to look at this?

/assign @zuercher

A few presubmit failures in the latest push, but they look unrelated.

Looks good, but you'll need to merge master again.

@lizan do you know why clang-tidy is complaining about the null pointer dereference despite the NOLINTNEXTLINE directive?
test/common/signal/signals_test.cc:57:22: error: Dereference of null pointer (loaded from variable 'nasty_ptr') [clang-analyzer-core.NullDereference,-warnings-as-errors]
        *(nasty_ptr) = 0;

@zuercher https://github.com/envoyproxy/envoy/pull/12372

Thanks @lizan!
@mkbehr If you merge master once more it should resolve this last test error. Sorry for the churn.

Ugh. Looks like you caught bad merge that landed on master.

Okay, trying again.

Looks like I caught yet another bad merge. Trying again.
As a heads up, Friday will be my last day working on Envoy, so hopefully we can get this merged by then.

Okay, looks like I found a good merge.


Advertise all supported interfaces as Tailscale Subnets

Revives PR #116
Fixes #96
PR #130, #131, #132 and #133 precedes this PR
Proposed Changes
Advertise all supported interfaces as Tailscale Subnets not only the default interface.
Related Issues
#96

Not stale, waiting for review/merge...

Not stale, waiting for review/merge...


A Cooler Wallet!

Like this one: https://steembottracker.com/steemdash/?account=steemit
It look so much cooler when there are more digits and more live action.
Yaba has the code, he probably share if you ask.
Love the browser functionality. Hope to replace my current browser completely with eSteem soon.
Rock on!

yes i agree, here is a screenshot,
https://steembottracker.com/steemdash/?account=steemit

Thanks guys... Looking good, I agree about live changes, we will take a look for sure.


Feature/ripple billing

Register new Ripple addresses, monitor them for payments, credit contracts upon payment.

Add tracker tag to commit message: [Finishes #88077334]

Does this need to be rebased?

LGTM

+r


Czechia replaces Czech Republic

As of 17 May 2016, Czech Republic is now named Czechia.

Hi @theforcedk thanks for the patch! merged.


Fix Indicator delete #360

Purpose
Permissions: https://docs.google.com/spreadsheets/d/1mWGhO-Acin5SQnfOrHm58UCY3Y965x98fk9i6-ozpq0/edit#gid=0
Ticket: https://github.com/toladata/TolaDataV2/issues/360

Coverage increased (+0.2%) to 49.118% when pulling a9eb61a39fb540b62a1effdc5ffd234cb084dec6 on Menda:360-fix-indicator-delete into 19a3920fc9b521b01ca134b52b0f3c6c5b72ee16 on toladata:dev-v2.

Coverage increased (+0.2%) to 49.118% when pulling b6531ef22bd9483926a0f283359663d6f93ffc41 on Menda:360-fix-indicator-delete into 19a3920fc9b521b01ca134b52b0f3c6c5b72ee16 on toladata:dev-v2.


Donations: Adyen Giving example assumes that the user always donates with cards

In the Giving Example, we currently assume that the user always make a donation with cards (see here)
Definition of done

The payment method is dynamically passed

Bro please review this

Any update on this

Hi @Rohans-7, thank you for your contribution. I saw that you've created a PR for this issue, I'll have a look at it!


Increase SCP slot timeout

Our timeouts were a bit agressive for a globally distributed arbitrarily large network. Let's see if this will help decrease our externalization time for the current state of the production.

Integration test restarted as it failed.


Print graphql queries to logs

Problem
When writing pipelines using the Go SDK, it's not always clear exactly what the resulting graphql query (or queries) will look like. This is especially needed when debugging, and learning Dagger.
Solution
Change the engine logger so that it prints raw graphql queries, rather than only buildkit-specific information.

Would this qualify as size/small @vito @sipsma ?

Would this qualify as size/small

We'd have to hook into the buildkit progress logs. There's a chance that's easy for someone familiar with those, but even then it may be easier said than done. If someone's not familiar with buildkit progress logs, then no, not small probably.
Or other option is to abstract on top of buildkit progress logs and use our own logging system (similar to Europa). Good thing to do, not small.
tl;dr no, I don't think so. Happy to be wrong though

What if you had to choose between two completely different log streams: 1) buildkit or 2) graphql, and we made no attempt to integrate the two. You just get one bytestream or the other. Would that make it simpler?
For example in my case I would gladly turn off buildkit logs in exchange for a clean log of graphql queries as they are being routed - more relevant to my debugging.

What if you had to choose between two completely different log streams: 1) buildkit or 2) graphql, and we made no attempt to integrate the two. You just get one bytestream or the other. Would that make it simpler?

I think so. It would solve the problem of the logs otherwise being interleaved (on char-by-char basis). You could add an optional to dagger.Connect, which would then enable printing from codegen client.
So yeah pretty small then.
Only con left I can think of is backcompat in future if we change logging more, but I am inclined to not care, too minor relative to benefit.

This is addressed by new TUI. Yay!


create separate bundles for external modules

With the support of bundling external packages, we bundle the included packages along with the source journey files to be able to run them via Heartbeat later without installing any packages. This is good, but it changes the source line numbers and column numbers of those particular journeys and might be a bad UX if we have to go back to the original source.

More details in here - https://github.com/elastic/synthetics/pull/580#pullrequestreview-1082955330
The ultimate goal of our push command is to replicate exactly how your folder structure is on your local and run the same inside HB when pushed. This would make it presentable in Kibana when we add unzipping support and allow users to view and edit monitors.
TLDR: If i push below example journey code
// examples/bundled-code/test.journey.ts
import { journey, step, monitor, expect } from "@elastic/synthetics";
import isPositive from "is-positive";
import leftpad from "leftpad";
import * as utils from "./utils";

journey("example journey", ({ page, params }) => {
  step("example step", () => {});
});

Our bundled zip folder should be in the below format.
examples/bundled-code/test.journey.ts
examples/bundled-code/utils.ts
examples/bundled-code/is-positive.js
examples/bundled-code/leftpad.js

We have a way to create the separate file for each journey file and utils without recreating the files during bundling instead using the source-maps to recover the file structure in Kibana if required in the future. The error stack trace is fixed via the PR - #687, but since we dont have a UI in Kibana to showcase the file structure, we dont need to solve this issue for now and have it in our backlog.


Is Featherlight intercepting React handleClick events?

I've got the featherlight box working completely fine, and my React components too. Yet when I put my React components inside the lightbox, none of the handleClick events work from React. Is Featherlight intercepting handleClick events? My React components are working as expected outside of the lightbox.

@karlhadwen were you ever able to resolve this? I am running into a similar issue in Vue.


Add allowParallel flag to allow multiple readers to be created

Handy for multithreaded work, we also use it in an extension of pye57:
https://github.com/davidcaron/pye57/commit/7d2dd716b5574063559e1fc7d355355ed68f38a4
CC @chpatrick

Thanks Niklas.
This library wasn't designed to handle anything parallel/threaded. That's probably why they put that check in there.
So I'm reticent to add a "skip this error" flag that would imply that it's supported in any way....

Hi Andy,
I think that's totally sensible, but our use case is completely read-only,
and I think in that case it makes sense to opt into multi threading at your
own risk.
On Thu, Jun 20, 2024, 23:08 Andy Maloney @.***> wrote:

Thanks Niklas.
This library wasn't designed to handle anything parallel/threaded.
That's probably why they put that check in there.
So I'm reticent to add a "skip this error" flag that would imply that
it's supported in any way....
—
Reply to this email directly, view it on GitHub
https://github.com/asmaloney/libE57Format/pull/292#issuecomment-2181565633,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGLJTZI5XY7AIBMVRATBHLZINAGNAVCNFSM6AAAAABJM2JE5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGU3DKNRTGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Right, in the same way as any other C++ data structure allows, e.g. std::vector. It allows parallel reading even though .push_back() is completely thread-unsafe.
The way I see it, your library provides a way to prevent parallel access (better than std::vector in this regard which has no saferails). But there should be a way to turn that off for read-only use cases.

After thinking about it a bit, this feels more like a workaround than a proper solution.
Some of the code in this library is kinda... old & gnarly. To feel more comfortable with moving in this direction, I'd like to see:

a test added to the test suite doing CV reads on multiple threads
a test using multiple threads with the "simple" API reader (probably run into this)
the CI fixed for the two cases that are broken so we know this works across all tested platforms

Then with the tests in place:

fix any other issues that come up
remove the readerCount() check in CompressedVectorNodeImpl completely

Then the lib would fully support multiple readers.

Ouch.  We have a backlogged ticket for testing multi-threaded reading and writing of seperate point clouds.
We may be able to contribute to this effort, at least by running it though some internal test coverage.


More generic dashboard

Two things that I would like to see:

Making this applicable to all builds, not just Build configurations of type deployments. Is there any reason it has to be deployment build configs?
Being able to switch off the highlighting of the latest "version".

My use case: We have a "project" that collects higher-level test suites running in a multitude of environments. It would be great to have a dashboard that displays the current status of each of those. This pretty much permits us to do that, though the two features above are "annoyances" for that use-case.
Is this something you might consider fixing, accept a PR for, or would it be better to fork the dashboard for our own needs?

Understandable comments... On the first question, just because it suits my particular purposes as we have a lot of builds and few deployments. I'd be happy to get a PR for these changes, but tbh it would be a bit to make this configurable. However, to just make the above changes for your use case, I think it should be pretty easy.
So I recommend the following:

Fork the project
Open the DeployFinder class and remove the ".filter { isDeployment(it) }" call (and update/disable any tests as needed)
Open the Deployment.css file and change the "#deploys .status-older" selector to "opacity: 1.0"
Rebuild

I haven't tested this, but hopefully it's as easy as that.
Building the plugin wasn't particularly easy/obvious though, so just today I've added a Docker build and build.sh wrapper script so it should now be trivial (hopefully) for you to do above.
If there is more demand for these features I'll consider adding above into the main codebase, but I don't get a lot of time to work on this so I'll close this for now, but feel free to comment or ask for help on above.
I do have a few minor features/fixes to do in the next few weeks so you might want to keep an eye out in case these are useful for you.

NP. Thanks for the quick response.


Put current git branch name as value when renaming

Currently when you rename a branch you get an empty input box, and if you just want to fix a typo in the branch name, you need to retype the branch name from scratch.
This is a simple change to put the current branch name in the input box when renaming with the text selected, so current workflows don't need to be changed (it also seems to fit other commands in VS Code).
Please let me know if there's anything else I need to do / add.

Thanks! 🍻