Feature request : remove old backups by date or count

Limiting the backups by total size is not always ideal due to variance in world size. Currently a small 200 MB world could preserve backups 25x that size wasting disk space.
Automatically remove backups after a configured number of days and/or backups.

Add 'days to keep backups' config setting would specify the number of days of backups to preserve. Delete backups older than this date, except those with dependents.
Add 'max number of backups' config setting would specify the number of backup files to preserve. If total count of backup files is greater than the specified value, delete oldest backup, except those with dependents.

Other suggestions:

Change config.advancedbackups.size to accept lower than 5 GB would be useful with smaller worlds. And better yet, change it to be a float value, allowing the limit to be set to less than 1 GB.

So, I've been thinking about this one.
I'm thinking that we add both of your suggested config values, and then set all three to have a minimum value of 0 - which would then disable the purging for that option altogether.
As an example:
config.advancedbackups.purge.size=50
config.advancedbackups.purge.amount=100
config.advancedbackups.purge.days=0

This would delete the oldest backup when the total space used reaches 50gb, or when there are more than 100 total backups. Alternatively,
config.advancedbackups.purge.size=0
config.advancedbackups.purge.amount=0
config.advancedbackups.purge.days=30

This would keep 30 days of backups, and ignore the other two options.
I wanted to grab your opinion before implementing these, given you were the one who made the suggestion - what do you think @sbenedict?

Sounds like a good solution, exactly as I envisioned!

@sbenedict I've got an early run out here if you want to test it out - I've got some more testing to do on my end but it should be all fully working.

Okay, now it's all working, and has been tested on several versions.
Will push this to CF and Modrinth.


Handle Console.messageRepeatCountUpdated event

When a console.log is executed and the logged string is the same as the last logged string a Console.messageRepeatCountUpdated event is raised. On this event we should print the last message again in the debug console.

Fixed: 29094d7f9139cff40512e1ebaa126cdf4e2828b9


Use date range picker instead of year / month filters

Overview
Use a date range picker to filter on date in the browse view
Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
~- [ ] Symlinks from new migrations present or corrected for any new migrations~
Demo

Notes
We don't have a way to create open-ended filters right now
Testing Instructions

Run "yarn" to install the new libraries before starting the frontend with "yarn dev"
Go to the browse view
Verify that the date range picker picker works as expected.
Verify that disabling the picker removes the filter
Verify that the picker still persists its filter within the same browser session (nav to another view and back)

Closes #996

@designmatty Styles neccessary for the picker to show up properly have been added to styles/sass/_shame.scss, and we import the the library css inside index.vendor.js.
If you want to do styles for it from scratch, you can remove the import from the latter.


Incorrect email in Stripe checkout

Hey, I assume there's some code in this repo that helps pre-fill the Stripe email. If I sign up to saaskit with a new user, I see the Stripe email is of a previous/old user:

Hold up, I disabled RLS because of https://github.com/denoland/saaskit/issues/78 - just for testing, I guess that's why I'm seeing this behaviour!

@umaar, are you still seeing this issue?

Haven't tried it again, but feel free to close if you can't repro!

I could not reproduce this issue on my local machine or the online demo app. I'll close this issue for now, but if you reencounter it, please feel free to re-open it.


Received tool input did not match expected schema

Is this a bug or am i missing something, i have attached my chatflow and the output in the chat
flowise 1.6.6

Here's a more professional rewrite of your message:
"I encountered a similar error recently. To resolve it, I utilized the Tool Agent, which effectively addressed the issue for me. However, the specific component that needs fixing in your case might differ. Please let me know if you need further clarification."

Here's a more professional rewrite of your message:
"I encountered a similar error recently. To resolve it, I utilized the Tool Agent, which effectively addressed the issue for me. However, the specific component that needs fixing in your case might differ. Please let me know if you need further clarification."

ToolAgent should works right? Generally recommend to use ToolAgent when connecting with tools


add .asf.yaml file for deploying website

The website is no longer updated anymore after July 1st because of we are using Git rather than SVN.
see (Apache id login needed):
https://lists.apache.org/thread.html/raf30ca1c77b81bc8c535c53b7aff38e1ff3c755ce84f4a40a6d8ad53%40<users.infra.apache.org>
According to the doc:
https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-WebSiteDeploymentServiceforGitRepositories
I add the .asf.yaml file for deploying the website.
See the page for checking whether the website is healthy:
https://infra-reports.apache.org/site-source/

Coverage increased (+0.01%) to 68.284% when pulling 16dc2d4fa2d686eaa90c64c95f69b3af679521e5 on website-asf-yaml into 204b7d31fe06b6f723b4b4d15d90704adf5b8a6c on master.


eval/adopt new build instructions from Istio

Istio has published new adapter build information here:
https://github.com/istio/istio/blob/master/mixer/doc/deploy-mixer-with-custom-adapter.md#make-and-push-a-docker-image-of-mixer-with-your-custom-adapter
Evaluate to see if we can improve our build using these instructions - especially wrt. eliminating bin/codegen.sh script.

The link above is now broken and I can't find the reference. At this point, I think figuring out a new build process can just wait until we can build separately from Mixer.


Not working all the commands

Working- 2, 3, 6, 7, 8
Not working- 1, 4, 5, 9

this project seems dead

I feel like I keep having to reiterate. If you were to read the README.md, this project has completely been put to rest as I'm genuinely too lazy to update the APIs used. I made this project when I was 16, drunk, in my bed on my 2017 Macbook Air. It was working great after first deploying it and then over time things just break ('things" = APIs). I moved on to bigger and better projects, private and public, and just completely disregarded Scylla. As I expressed in the README.md, the community is more than welcome to use Scylla's source code as a base to build bigger and better OSINT tools.  For next time, please read the README before opening up an issue.


All docs modified

Hi,
I have updated the docs, and have checked the rendering. Looks good.

The table citation is not working here. And I ran the Make script and found that the cl_report.png is missing

Talked with @abhiket. Will commit another change on doc/06_Results.Rmd


Add ZMOK API

New Web3 provider - https://zmok.io

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

This PR is inactive, so the API was added in another PR/commit.
More information at: #2002


Groupadmin cannot make groups

Feature
Bug Report
Not sure if this is a feature request or a bug report, but a groupadmin cannot create groups(didtn scheck users yet), while via icommadns a groupadmin can create users.  The same command does work with a rodsadmin user.
iRODS Version, OS and Version
irods 4.3.0
ubuntu 20.04
http-api 0.2.0
What did you try to do?
Create a group via the api with a groupadmin:
curl https://our.dns.nl/irods-http-api/0.2.0/users-groups -H 'Authorization: Bearer sometoken'   --data-urlencode 'op=create_group' --data-urlencode 'name=BINSQL'

Expected behavior
Group is created
Observed behavior (including steps to reproduce, if applicable)
No priviledge to create group
logging in irods:
 {"acl_operation":"{\"acl\":\"read\",\"entity_name\":\"BINSQL\"}","log_category":"api","log_facility":"local0","log_level":"error","log_message":"iRODS Exception:\n    file: /irods_source/
plugins/api/src/atomic_apply_acl_operations.cpp\n    function: void (anonymous namespace)::throw_if_invalid_entity_id((anonymous namespace)::id_type)\n    line: 202\n    code: -130000 (SYS
_INVALID_INPUT_PARAM)\n    message:\n        Invalid entity\nstack trace:\n--------------\n 0# irods::stacktrace::dump() const in /lib/libirods_common.so.4.3.0\n 1# irods::exception::assem
ble_full_display_what() const in /lib/libirods_common.so.4.3.0\n 2# irods::exception::what() const in /lib/libirods_common.so.4.3.0\n 3# 0x00007F7A8BEEDC7C in /usr/lib/irods/plugins/api/li
birods_atomic_apply_acl_operations_server.so\n 4# 0x00007F7A8BEEC658 in /usr/lib/irods/plugins/api/libirods_atomic_apply_acl_operations_server.so\n 5# irods::experimental::catalog::execute
_transaction(nanodbc::connection&, std::__1::function<int (nanodbc::transaction&)>) in /lib/libirods_server.so.4.3.0\n 6# 0x00007F7A8BEEB000 in /usr/lib/irods/plugins/api/libirods_atomic_a
pply_acl_operations_server.so\n 7# irods::api_call_adaptor<BytesBuf*, BytesBuf**>::operator()(irods::plugin_context&, RsComm*, BytesBuf*, BytesBuf**) in /usr/lib/irods/plugins/api/libirods
_atomic_apply_acl_operations_server.so\n 8# std::__1::__function::__func<irods::api_call_adaptor<BytesBuf*, BytesBuf**>, std::__1::allocator<irods::api_call_adaptor<BytesBuf*, BytesBuf**>
>, irods::error (irods::plugin_context&, RsComm*, BytesBuf*, BytesBuf**)>::operator()(irods::plugin_context&, RsComm*&&, BytesBuf*&&, BytesBuf**&&) in /usr/lib/irods/plugins/api/libirods_a
tomic_apply_acl_operations_server.so\n 9# int irods::api_entry::call_handler<BytesBuf*, BytesBuf**>(RsComm*, BytesBuf*, BytesBuf**) in /usr/lib/irods/plugins/api/libirods_atomic_apply_acl_
operations_server.so\n10# rsApiHandler(RsComm*, int, BytesBuf*, BytesBuf*) in /lib/libirods_server.so.4.3.0\n11# readAndProcCl

logging in http-api:
[2024-03-08 14:13:43.290] [P:1] [error] [T:10] op_create_group: SYS_NO_API_PRIV: Failed to add group [BINSQL].

[2024-03-08 14:14:13.290] [P:1] [error] [T:1] fail: read: The socket was closed due to a timeout

I've confirmed that iRODS 4.2.12 and later allow groupadmin users to create groups.
SYS_NO_API_PRIV is an error code that is only returned by the iRODS server. Perhaps iRODS doesn't know how to handle proxying for groupadmin users. If that turns out to be the case, then we'll move this issue to the irods/irods repo.
We'll confirm and let you know what we find.

I've reproduced the issue outside of the HTTP API.
The problem has to do with proxy users.
Below is the minimum example c++ code for triggering the behavior.
// Connect to iRODS without authenticating.
irods::experimental::client_connection conn{
    irods::experimental::defer_authentication,
    "localhost",
    1247,
    {"rods", "tempZone"}, // (proxy) rodsadmin user
    {"tom", "tempZone"}}; // groupadmin user

// Authenticate the rodsadmin.
char pw[] = "rods";
clientLoginWithPassword((RcComm*) conn, pw);

// Try to add a group as the proxied groupadmin user.
irods::experimental::administration::client::add_group(
    conn, irods::experimental::administration::group{"tom_group"});

This issue needs to be transferred to the irods/irods repo.


Where are all the Response structs?

Where are all the Response structs at?  I don't think they exist.
If not, I struggle to understand why they are not implemented.  Is the expectation that I am going to write my own models to parse every API's Body response?  This is a massive waste of time and maintenance burden on the consumers of this SDK and is a missed opportunity to address some of the challenges with consuming the Elasticsearch APIs (such as _cat apis returning strings for everything).

Hello, this question comes up periodically — I think the last time I've responded in detail was in https://github.com/elastic/go-elasticsearch/issues/120.
The short answer "why they are not implemented" is that there's no specification to generate them, as opposed to the surface of the API, which is fully generated, and therefory fully in sync with three major versions of Elasticsearch.
I will find some time to write up a summary and pin it to the issues page, so it's easier to find. Also, I have some ideas how to make it hurt a little less.

(...) such as _cat apis returning strings for everything (...)

That is by design — Cat APIs are usually consumed in a shell script. In Go, you probably want to set the format parameter to "json".

I upvoted this issue, because I agree with the basic premise the API needs Response structs to be an effective tool for developers. There is some discussion in elastic/elasticsearch#25152 that might be helpful regarding automating the client apis.

I

I upvoted this issue, because I agree with the basic premise the API needs Response structs to be an effective tool for developers. There is some discussion in elastic/elasticsearch#25152 that might be helpful regarding automating the client apis.

I totally agree. I am running into this issue now. I guess this is a larger problem for Elasticsearch. I often struggle to find the definition of response bodies in their documentation. Isn't it standard practice to document your API's response types?

@johnbuonassisi  So I ran into similar issues with the docs. Prior to 7.x, the rest endpoints weren't explicitly documented. Since our major cluster is 6.x, I frequently have both open so I can look at the API docs and finh roughly what I need.
They still don't really document error conditions, so it can still be a bit challenging to write against. Especially in something like go. But that's somewhat off topic.
That all aside, the suggested tidwall/gjson library is helpful. But it is a wierd way to handle the API. It seems more appropriate for reading arbitrary json off some third-party source than to be the recommended interface for the official go library.

Do the concerns from the comment above still apply today? I'm not sure if we're still inhibited by the same limitations

Is there any progress on this matter soon?
I have been told the Elasticsearch is already public product since years ago, but it is hard to believe that the error response is not clearly defined.

The Elasticsearch Java API does have requests/responses classes generated somehow e.g. IndexResponse.
I'd at least expect to have the same in all ES libraries/modules 😕

The response struct is now embedded within<EMAIL_ADDRESS>Weird decision.


osx-arm64 build is broken

Needs a release with https://github.com/inducer/meshpy/commit/3d31449724a9c8aa72380fddd8dee18bdbfe487e#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
cc @inducer

But it built successfully? Do we need better tests?
Anywho, #8. Needed a release anyway.
One thing I'm concerned about is that both TetGen and Triangle use fancy "robust geometric primitives" that reconfigure the floating point unit (to pick rounding modes). That may all need some work on ARM.

But it built successfully? Do we need better tests?

It did, but we are disabling the tests for osx-arm64. That's because we are cross compiling and has no way of running tests on CI and a person with access who is running a daily cron job gave the test results to me.

One thing I'm concerned about is that both TetGen and Triangle use fancy "robust geometric primitives" that reconfigure the floating point unit (to pick rounding modes). That may all need some work on ARM. (i.e. I'm worried that even if we get them build, they may not work as intended.)

Hmm, we might need better tests.

works now and pytest tests pass, but they might not indicate that it works on ARM

Thanks for checking! That's good enough for me. Let's wait until somebody complains.


EnSQL client methods

This PR adds support for EnSQL queries via the query method on the client.
I have made the following changes:

Implemented the query method on the client
Updated tests

TODOs and questions

[x] Is the commit message formatted correctly?

[x] Do all of your functions and methods have docstrings?
[x] Have you added/updated unit tests where appropriate?
[x] Have you run the unit tests using pytest?
[x] Is your code style correct (are you using PEP8, pyflakes)?

@rebeccabilbro We probably don't need both right now - it's about distinguishing between the user-level errors and library-level errors but they could probably be the same error.


set default draw to mpl

Describe the Issue
The default method for drawing circuits using my_circuit.draw() should be matplotlib instead of text.
Instead, we now specify the argument output='mpl'.
Expected Solution
Set up the config file as explained here so that the default drawer is matplotlib.
https://qiskit.org/documentation/getting_started.html#step-4-visualize-the-circuit

I have a couple of reservations about this:

If the reader can't see our config then they might not understand why they are seeing text drawings and the textbook is displaying mpl drawings. Could potentially fix this by explaining in the prereq section but not every reader will go through that.
Due to bugs in qiskit/mpl some gates do not render correctly with mpl (mainly the initialize gate) so we have reverted to text drawings for these


Uncaught Kotlin exception: kotlin.native.internal.IrLinkageError: Function 'UIKitViewController' can not be called:

Describe the bug
When using Paywall UI, in ios I get this error:

Uncaught Kotlin exception: kotlin.native.internal.IrLinkageError:
Function 'UIKitViewController' can not be called: No function found for symbol
'androidx.compose.ui.interop/UIKitViewController|UIKitViewController(kotlin.Function0<0:0>;
androidx.compose.ui.Modifier;kotlin.Function1<0:0,kotlin.Unit>?;
androidx.compose.ui.graphics.Color;kotlin.Function1<0:0,kotlin.Unit>?;kotlin.Function2<0:0,kotlinx.cinterop.CValue<platform.CoreGraphics.CGRect>,kotlin.Unit>?;kotlin.Boolean;androidx.compose.runtime.Composer?;kotlin.Int;kotlin.Int){0§<platform.UIKit.UIViewController>}[0]'

Any recommendation for quick fix?
Android works perfectly though

looks like because of compose version:
https://github.com/RevenueCat/purchases-kmp/blob/cdf0e8dfeb1eb475e9e73b9a84f2faa0e91f5130/gradle/libs.versions.toml#L32
Bumping to latest compose version (1.7.0-beta01) should fix the issue I guess.
Similar issue: https://github.com/KevinnZou/compose-webview-multiplatform/issues/219

for anyone having this issue, quick fix is to downgrade compose version to 1.6.11

Thanks for reporting! And thanks for the suggested workaround. Which version of Compose does your project use? And which version of Kotlin? That might help pin this down to a specific combination of those 2.

@JayShortway
kotlin version: 2.0.20
compose version: 1.7.0-beta01

Thanks! There seems to be a binary incompatibility between Compose 1.6.x and 1.7.0. As soon as 1.7.0 is stable, we should be able to support it and fix this issue.

FYI 1.2.0+13.6.0 was just released with Compose Multiplatform 1.7.0.


containers: events: fix event types

@miq-bot add_label providers/containers, ui, bug

@simon3z @dkorn please review

@moolitayer Is there a BZ that this PR is associated with?  We'll need one if we want this cherry picked to the released branches.

@moolitayer what about the events that were already received, do we need a migration or the categorization is done at runtime depending on the yml file?

@moolitayer Is there a BZ that this PR is associated with? We'll need one if we want this cherry picked to the released branches.

yes there are: 1288146 with 1289623 clone.

@moolitayer what about the events that were already received, do we need a migration or the categorization is done at runtime depending on the yml file?

generated at runtime;
I tested by 1.) collecting events with master 2.) seeing the old categorization 3.) checking out this change (restart is needed) 4,) verified the new categorization.

@dkorn @simon3z please review

@moolitayer please have Dafna to look at this. IMO LGTM :+1:

fyi @avi3tal

events new location seem good to me


provde option to ignore barrel files

Summary
i want to exclude barrel files from tree

Details
What are barrel files:
https://dev.to/tassiofront/barrel-files-and-why-you-should-stop-using-them-now-bc4

Standard questions
Please answer these questions to help us investigate your issue more quickly:

Question
Answer

Would you consider contributing a PR?

Hello @andriyor, I'll think a little bit about how we could come up with that kind of feature without impacting skott's genericity when dealing with files, and I'll come back at you.

Currently in most cases i use typescript, so i decided to create small library based on ts-morph  which uses ts API under the hood
https://github.com/andriyor/ts-tree
Also i made CLI tool for it https://github.com/andriyor/ts-tree-cli and web app https://github.com/andriyor/coverage-tree-next
With this tools i can generate such test coverage report

Such a nice library you have there @andriyor, great job!
To be honest excluding barrel files is such a specific use case in the context of TypeScript so I'm less likely to land that in skott's core. However if the need arises of doing such specific things (requiring AST introspection), I might be able to inject traversed AST information into a specific API function that keeps or not nodes so that people could decide to say given this AST node should it make it to the final graph or not.
The addition would be something like:
skott({
  onNode: (context, [keep, exclude]) => {
    if(isBarrelFile(context.nodeAST)) return exclude();
    keep();
  }
})

Where isBarrelFile would be either coming from utility exposed by skott or whatever library that can deal with TypeScript AST nodes.
What do you think?

Barrel files is not only TypeScript feature https://uglow.medium.com/burn-the-barrel-c282578f21b6
Yeah it would be niche to provide API to make custom import handling
Also you can take a look on recently published package https://github.com/thepassle/module-graph which have pretty nice api

Yes I know barrel files are not specific to TypeScript I was referring to JS/TS context in general, what I wanted to say is that this is such a specific feature around the ECMAScript ecosystem but ideally I would make these specific things external to the core itself and provide specific adapters/plugins to make it work, as in the future I would like to expand skott to other ecosystem such as Python or Go.

Yeah it would be niche to provide API to make custom import handling

Then let's make it happen, I'll provide an API that allows each node to be checked and discarded/kept before internal logic kicks in.

Also you can take a look on recently published package https://github.com/thepassle/module-graph which have pretty nice api

Thanks for the reference, indeed skott's API exposes way more graphs primitives but one thing lacking is the ability to deal with the AST node upfront (import/export etc declarations). With the custom dependency resolver API we already have a way of handling module declarations but we don't really know from where they come from (only the identifier is kept so it's higher level) hence we need a lower-level API that operates on the AST so I'll get that implemented.

Regarding your use case of ignoring barrel files, what do you exactly have in mind after getting rid of them? If we just ignore them, the problem is that the final graph will contains holes as barrel files are often nodes linking other nodes so just getting rid of them will create orphans and sub graphs with no dependencies between each other.
One solution would be to change all the nodes depending on the barrel files to make them depend on nodes the barrel was depending on. But in that case, it makes skott creating a whole another graph that does not contain any barrel but still preserve the relationships between nodes. This could even be useful to create a tool to transition from a codebase containing barrel files to another one without any barrel.

By ignoring barrel files, I mean the solution that you already mentioned. Just to remove the noise of redundant nodes


[WIP] Add condition for shallow clone

Description
The integration tests perform a deep checkout of the opensearch repository. Instead, we can perform a shallow clone the main branch to improve the speed and performance of the tests.
Issues Resolved
Fixes #52
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The build fails.
https://github.com/vchrombie/opensearch-py/runs/3415891606

subprocess.CalledProcessError: Command 'cd /code/opensearch && git reset --hard 34550c5b17124ddc59458ef774f6b43a086522e3' returned non-zero exit status 128.

Since, we are not cloning the whole repository, it couldn't find the 34550c5b17124ddc59458ef774f6b43a086522e3 commit I guess. We need to find a workaround for this.
As a hotfix, I commented out the line and the build passes.
https://github.com/vchrombie/opensearch-py/runs/3415915005
    print(sha)
    # subprocess.check_call("cd %s && git reset --hard %s" % (repo_path, sha), shell=True)

I just pushed a commit https://github.com/vchrombie/opensearch-py/commit/cab41f49bbc974c6fc5b3c93171d63cf0f39866f to a new branch test-issue-52. I tried removing the code from run_tests.py#L61 to run_tests.py#L82. Not sure if it is the right thing to do, but the workflows seemed to be almost the same.

https://github.com/vchrombie/opensearch-py/runs/3418310013
https://github.com/vchrombie/opensearch-py/runs/3415915005

I was just skeptical because we are missing out on this condition if opensearch is running run_tests.py#L70.
I would like to listen to your comments on this.

If you check here https://github.com/opensearch-project/opensearch-py/blob/6fcc78a58cc84396a5b771d829c38f28623cce1a/test_opensearch/run_tests.py#L68  the hash is derived by calling the server code, and we need to check out at that point. I think it is important that we pull server code at the correct commit, else it'll have problems in future when there are multiple releases/branches.
Taking inspiration from this stackoverflow, we can do something like this:
mkdir ~/tmp
cd ~/tmp
git remote add origin git@github.com:opensearch-project/opensearch-py.git
git fetch --depth=1 origin $SHA # sha is the one derived from build_hash
# do work in this directory
rm -rf ~/tmp

Sorry if this increases the scope of the work in this PR :)
Also, while you're at it, if possible, could you also change this line
https://github.com/opensearch-project/opensearch-py/blob/6fcc78a58cc84396a5b771d829c38f28623cce1a/test_opensearch/run_tests.py#L65
to say 'server' instead of 'client'? Thanks again.

Hi @rushiagr, I completed the work as per your suggestions.
Can you take a look when you are free?
Looks like the time is reduced to almost half in github actions. I haven't tested locally tho.
https://github.com/opensearch-project/opensearch-py/actions/runs/1187109252 took 5m 6s
https://github.com/vchrombie/opensearch-py/actions/runs/1189548548 took  2m 44s

Closing this PR in favour of https://github.com/opensearch-project/opensearch-py/pull/70.


[Discussion] [Proposal] Code Generation and Scale

I asked a question in gitter yesterday that seemed to spark some proposals for future work so I'd like to move that conversation here for posterity and further discussion. The question was:
Does code generation scale?
For large projects that contain hundred (or thousands) of components the Entity and Pool classes become very cluttered. Very quickly after starting a project the generated API becomes untrustworthy i.e. using most of the generated API methods in any particular scenario would be a logical error and would raise an exception.
@alerdenisov mentioned that this isn't a problem for pools because they could be separated but unless I'm missing something it appears that all SingleEntity methods are generated on the base Pool class which means most pools are capable of doing things they shouldn't.
Proposed Solutions
Entity Lenses
@mzaks proposed experimenting with "Entity Lenses". This involves changing the code gen to output interfaces like so:
interface HasPosition{
  Entity addPosition(int x, int y);
  Entity removePosition();
  Entity replacePosition(int x, int y);
}
interface HasVelocity{
  Entity addVelocity(int x, int y);
  Entity removeVelocity();
  Entity replaceVelocity(int x, int y);
}

Which we can manually use to create the following:
interface MyEntity : HasPosition, HasVelocity {}

Improved Interfaces and Code Gen
I propose the following changes:

Create a formal interface for Entity: IEntity (I think this should happen regardless).
Use the code generator to create entity interfaces that hold all the component related methods for a particular pool:

interface CorePoolEntity : IEntity {
  CorePoolEntity AddVelocity(int x, int y);
  CorePoolEntity AddPosition(int x, int y);
  // etc
}

Make Pool generic on T where T : IEntity.

public partial class Pool<T> where T : IEntity {
  ...
  public virtual T CreateEntity() {
    ...
  }
}

Create typed pools in the generated Pools.cs file:

public static Pool<CorePoolEntity> core {
  get {
     ...
  }
}

I like this solution because it:

It completely solves the API scaling problem for entities (I think).
Requires no action after you've generated code. Everything is kept up to date automatically.
Its safe because it's generated.

Thoughts?

I like it!
This adds safety on pool methods because one cannot use the wrong components on them.

But using the Has* interfaces @mzaks proposed it's possible to guarantee the usage of a subset of components in a System for example:
class ExampleSystem : IReactiveSystem {
  private interface MyEntity : IEntity, HasPosition, HasVelocity {}

  void Execute(IEntity[] entities) {
    for (MyEntity entity in entities.getSubsetOf(typeof(MyEntity))) {
      myEntity.AddPosition(...);
    }
  }
}

getSubsetOf would be an extension method on IEntity[]. It won't be generic since the type is only used to get its inherited interfaces and check the array for entities that implement them all. AFAIK in C# class A : IOne, ITwo is not of type IAggregate where interface IAggregate: IOne, ITwo.
If the system uses only one type of IEntity (eg. IReactiveSystem) its trigger could maybe be replaced by returning MyEntity with a trigger event somehow?

Maybe it's possible to tell the compiler about everything:

which components are available in a pool
which components an entity must have & in which pool the entity must be

If it isn't possible (or the implementation allows no performant fetching) to have both, I'd vote for the pool safety. Having the compiler help with which components are available in a pool sounds better than my idea above.
Just thinking out loud. :smile:

I agree that @mzaks solution can be used to add extra safety :+1: . I also agree in that pool safety / entity interface cleanliness is my highest priority.
I just started writing C# a few days ago so my knowledge there isn't strong but I'd like to think we could implement both of these solutions.

Giving this some more thought I realized this would be a pretty serious departure from the current architecture and would break all existing projects. Since pools are generally passed around as just a Pool reference I don't think migration tools would be able to migrate to something like this.
I have a solution for this:

Create an IPool interface and move existing Pool interface there.
Have Pool conform to this interface and keep generating Pool as we are (with all single entity methods, etc). This is for backwards compatibility.
Create a new generic pool class as described in the initial comment:

public partial class Pool<T> where T : IEntity { }

Closed by #266

Giving this some more thought I realized this would be a pretty serious departure from the current architecture and would break all existing projects

Oh yes, this was a huge change :)


One unicorn name is wrong

Please change Incertis to Icertis.
Thanks

Can you do that? You can make a pull request.

can I make this pull request?
you can assign it to me

Sure, go ahead.

The unicorn name is already changed

d

The unicorn name is already changed

Ohh okay. Ummm if you are interested you can add more unicorns as I think a lot of unicorns have been added recently. Thanks

I tried adding a few names and sent a pull request but all the checks failed don't know why.

Ohh dw... Ignore the checks.

Okay I have sent the pull request

Okay I have sent the pull request

Thanks a lot. Have merged the changes

This issue can be closed


fix: do not remove visible tiles

This is a hard to hit case where:

tile A was used as proxy in the previous iteration and
tile B (the last tile) referencing A as proxy has been loaded in the current
iteration, so A will be added to removeTiles (line 227)
tile A became 'visible' in the current iteration.
when tile A is not has not been loaded (and is therefore added to loadTasks)
this will lead to a SEGV in loadTiles() line 390.
So this should be the proper fix for  ba6d3f9515e33f8a5164516f7b00011ef92bf5d5

This problem could also be solved by updating the tile isVisible state at the beginning of
updateTileSet when new readyTiles are available.

Nice catch.


Error when on_connection_closed called

I get the following error when on_connection_closed is called. This causes sdx-downstream to die. Looks like it's because we're not passing param=value arguments to structlog logger.
sdx-downstream_1          | 2016-07-18 12:42:25,551|ERROR: sdx-downstream: Calling <bound method AsyncConsumer.on_connection_closed of <__main__.Consumer object at 0x7f8b3f122b38>> for "0:_on_connection_closed" failed
sdx-downstream_1          | Traceback (most recent call last):
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/callback.py", line 236, in process
sdx-downstream_1          |     callback(*args, **keywords)
sdx-downstream_1          |   File "/app/async_consumer.py", line 98, in on_connection_closed
sdx-downstream_1          |     reply_code, reply_text)
sdx-downstream_1          | TypeError: _proxy_to_logger() takes from 2 to 3 positional arguments but 5 were given
sdx-downstream_1          | Traceback (most recent call last):
sdx-downstream_1          |   File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
sdx-downstream_1          |     "__main__", mod_spec)
sdx-downstream_1          |   File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
sdx-downstream_1          |     exec(code, run_globals)
sdx-downstream_1          |   File "/app/consumer.py", line 38, in <module>
sdx-downstream_1          |     main()
sdx-downstream_1          |   File "/app/consumer.py", line 33, in main
sdx-downstream_1          |     consumer.run()
sdx-downstream_1          |   File "/app/async_consumer.py", line 327, in run
sdx-downstream_1          |     self._connection.ioloop.start()
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/adapters/select_connection.py", line 355, in start
sdx-downstream_1          |     self.process_timeouts()
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/adapters/select_connection.py", line 283, in process_timeouts
sdx-downstream_1          |     timer['callback']()
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/heartbeat.py", line 88, in send_and_check
sdx-downstream_1          |     return self._close_connection()
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/heartbeat.py", line 121, in _close_connection
sdx-downstream_1          |     text)
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/connection.py", line 1368, in _on_disconnect
sdx-downstream_1          |     self._process_connection_closed_callbacks(reply_code, reply_text)
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/connection.py", line 1397, in _process_connection_closed_callbacks
sdx-downstream_1          |     reason_code, reason_text)
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/callback.py", line 60, in wrapper
sdx-downstream_1          |     return function(*tuple(args), **kwargs)
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/callback.py", line 92, in wrapper
sdx-downstream_1          |     return function(*args, **kwargs)
sdx-downstream_1          |   File "/usr/local/lib/python3.5/dist-packages/pika/callback.py", line 236, in process
sdx-downstream_1          |     callback(*args, **keywords)
sdx-downstream_1          |   File "/app/async_consumer.py", line 98, in on_connection_closed
sdx-downstream_1          |     reply_code, reply_text)
sdx-downstream_1          | TypeError: _proxy_to_logger() takes from 2 to 3 positional arguments but 5 were given

Fixed in #7


Adapt code to get it working with SES7.1

Signed-off-by: Volker Theile<EMAIL_ADDRESS>Describe your changes
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] CHANGELOG.md has been updated should there be relevant changes in this PR

This bugfix is related to https://tracker.ceph.com/issues/55460.


updated chardet version requirement

Updated chardet version requirement to match the one on the requirements.txt in the main repo.

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@basnijholt please review :)

Thanks for the ping!


Packaging and automatic dependency resolution

I suggest releasing packages for some of the major operating system. Package managers can then automatically resolve most of the required dependencies, and thus simplify the installation process.
I'd offer my help with setting up the packaging for Apt (Debian/Ubuntu/...).

Somewhat related: I created a docker container for OCRmyPDF which should be usable on every platform that supports docker.

Thank you paul! I already gave up on this due too endless dependancy resolving loops but now it just works out of the box.

@paulstaab. Real interesting idea. I actually have a use for this - I'd like to run large batch OCR jobs on EC2 but don't want to spend my life configuring Amazon Linux images.
I get an error message when running the container:
parallel: Warning: $SHELL not set. Using /bin/sh.

export SHELL=/bin/sh would probably clear that up.
@1337sup3rh4x0r : I'll link to it in readme.md. Fritz is less active at the moment.

I updated the container with SHELL defined, the warning should now be gone.
Thanks for linking to the container in the readme!

Done in v3.0rc2


The 'zappa' distribution was not found and is required by the application

This is an annoying warning that you get if you're using a local version of Zappa for devving/testing. It's in the version updated checker code.

I'm not getting this error. How are you using a local version of zappa? I have been using setuptools.

This is just if you use a local Zappa with a symlink.


signed 0x permit2 should be durable across updated quotes

Please validate that this works as expected before implementation (permit2 isn't coupled to a quote)

a signed permit isn't unique to a specific quote and should be fine to be used if the quote is updated
validate this and implement a solution here so that we are able to better update quotes without having to have a user sign an updated permit.
we may need to decouple the permit2 signing from the transaction itself
we need track the expiration on the permit2 to make sure it doesn't time out before the quote is executed.

as a follow up to this ticket we should either then add updates to the quote or if we cannot accomplish this then update the network fees at the least.

as a follow up to this ticket we should either then add updates to the quote or if we cannot accomplish this then update the network fees at the least.

@0xean FYI this issue is actually decoupled from 0x permit2 work
https://github.com/shapeshift/web/pull/8313 went in yesterday which closes https://github.com/shapeshift/web/issues/8271 - in its current state, https://github.com/shapeshift/web/issues/8271 was effectively a subset of this issue, so to make it Li.FI-y and not mix issues, 8313 closed it by effectively fixing Li.Fi network fees when we can (tokens with approval/native assets).
It did not do any kind of network fees refetch since that's the scope of this issue.
Will start work on this one which will achieve what we originally intended for Li.Fi (but even better, given we now have correct network estimates from the get-go at rate time in 2 out of 3 cases 🎉)

https://github.com/0xProject/0x-settler/blob/ac08d41d594288dd6c240d743706514a67ccc884/README.md?plain=1#L776
Initially I saw something that made me guess that the permit2 message was containing some data linked to the quote:
PermitWitnessTransferFrom(TokenPermissions permitted,address spender,uint256 nonce,uint256 deadline,SlippageAndActions slippageAndActions)
SlippageAndActions(address recipient,address buyToken,uint256 minAmountOut,bytes[] actions)
TokenPermissions(address token,uint256 amount)

PermitWitnessTransferFrom contains actions, nonce could also be sent through the calldata for compare reasons
So I decided to ask the ZRX team a confirmation, they confirmed it's impossible to use another permit message with a second quote because the calldata contain some informations that the permit2 message also contain:
https://discord.com/channels/435912040142602260/1159284824750702682/1318694036457918505

I think we're stuck because of upstream on this issue, closing it, if you feel like there is another solution, feel free to open again 🙏


[Docs] Update description of Hipster store sample app

Current State
The Hipster sample application's description in Meshery Docs is out of date: https://docs.meshery.io/guides/sample-apps#hipster.
Desired State
This sample application, https://github.com/GoogleCloudPlatform/microservices-demo, has been renamed to Online Boutique

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

I would like to give it a try.
// assign

here you go @afzal442


When using the colorpicker to pick a color from the screen, the program crashes

1.Problem Description
When running controls.exe, the colorpicker window opens; the program crashes。
The vs2019 debug output window displays the following error message
HEAP CORRUPTION DETECTED: after Normal block (#706823) at 0x08A84EB0.
CRT detected that the application wrote to memory after end of heap buffer.

2.Cause of the bug
In the GetMousePosBitmap function of the ColorPicker.cpp file,
pDestPixelBits[++destColorIndex] = pPixelBits[colorXY];
the access subscript of ++destColorIndex starts at 1, so pDestPixelBits will be written out of bounds; it crashes when released; the problem is solved after changing to
pDestPixelBits[destColorIndex++] = pPixelBits[colorXY];

这个缺陷已经修复。


Fix/cancel file icon

Problem
A previous PR of mine left the styling incorrect on the icon that removes/cancels the uploaded file:
It had the default trash icon and also only appeared during hover.
There are couple little tweaks to button and select styling here, as well as some css organization.
Antd button was hard to target and change icon of, so I put display: none on that class and implemented a simple function on a div to replace it.
Old/incorrect:

New:

Design:

Steps to Verify:
Should look like the design, and when you click the red icon, any uploaded file should be removed.

Adding a comment so Github tracks it, will re-review once the styling for the cancel icon is moved!

@ShrimpCryptid what do you think of this pattern? FWIW, it matches a couple of pairs of icons in the same file.


Start the simulator stopped.

"flash" starts the simulator
"stop" can now stop it entirely, rather than drop to the REPL
"restart" restarts the current program.

This seems to work as expected but it's unexpectedly slow to run a new program. Not yet looked at what step is slow (suspect awaiting the main C entry point).

This seems to work as expected but it's unexpectedly slow to run a new program. Not yet looked at what step is slow (suspect awaiting the main C entry point).

@microbit-robert and I can no longer reproduce this. At some point I had a hacky local version with a 3 second timeout, perhaps I confused myself and used an old browser tab.


Structure improvement  functional tests

What is the purpose of this pull request?

[ ] Bug fix
[ ] New feature
[ ] Docs update
[x] Other: partially implements #252

In summary, create a python structure with a pyproject.toml file to:

isolate possible python environments with poetry and its dependencies;
structures the format procedure for python code with black;
structures the lint procedure for python code with pylint;
structures the organization of automated tasks with poethepoet (allowing better management for when function tests increase).

Like suggested by @jaoleal, started to lint some codes (added some docstrings and did some changes on relevant warnings that the linter has accused).

Nice, when the work is complete, could you squash all the commits into expressive one(s) ?

Changed a little of code in test_framework.py (and example_test.py and restart.py) at
2f5ccf8 to follow some principles in BitcoinCore functional tests (and to make it more flexible). Should i wait for some review before squash it?

@qlrd I think you can squash now, and I'll make a full review.
Also, this needs rebase

@jaoleal, @Davidson-Souza i think it's done

@qlrd you have a conflict with tests/example_test.py. A rebase should fix it

ACK 3fdb8c0


RDK-34568: Expand AVInput RDK Service to include HDMIInput and Compos…

…iteInput APIs
Reason for change: Combine HdmiInput and CompositeInput Plugins into AVInput
Test Procedure: sanity testases on HDMI and COMPOSITE inputs
Risks: Low
Signed-off-by: Dhivya Ilangovan<EMAIL_ADDRESS>

APIs should follow the JSON-RPC spec https://www.jsonrpc.org/specification#response_object
APIs should not use XRE Service Manager legacy params like "success".
Please use ThunderInterfaces and the generated classes instead of JsonObject.

Please include generated interfaces/json/JsonData_AVInput.h and use the generated classes instead of JsonObject.
ex.
uint32_t getInputDevicesWrapper(const JsonObject& parameters, JsonObject& response);
->
uint32_t getInputDevicesWrapper(JsonData::AVInput::GetInputDevicesResultData& response);

uint32_t writeEDIDWrapper(const JsonObject& parameters, JsonObject& response);
->
uint32_t writeEDIDWrapper(const JsonData::AVInput::WriteEDIDParamsData& parameters);

uint32_t getEdidVersionWrapper(const JsonObject& parameters, JsonObject& response);
->
uint32_t getEdidVersionWrapper(const JsonData::AVInput::GetEdidVersionParamsInfo& parameters, JsonData::AVInput::GetEdidVersionResultData& response);

In handlers please use the generated properties.
ex.
parameters["portId"].String();
->
parameters.PortId

response["edidVersion"] = "HDMI1.4";
->
response.EdidVersion = "HDMI1.4";

@dhivya-ilangovan events "onAVInputActive" and "onAVInputInactive" seem to be removed. With your change AVInput::event_onAVInputActive and AVInput::event_onAVInputInactive are unused. "JSON-RPC events" section of the unit test also becomes unused. However AVInput.json is still referening these events. Can you clarify are you removing them and will you clean up?

@dhivya-ilangovan events "onAVInputActive" and "onAVInputInactive" seem to be removed. With your change AVInput::event_onAVInputActive and AVInput::event_onAVInputInactive are unused. "JSON-RPC events" section of the unit test also becomes unused. However AVInput.json is still referencing these events. Can you clarify are you removing them and will you clean up?

Removed "onAVInputActive" and "onAVInputInactive" from all places.

looks good

Created new PR to avoid multiple commit messages.
https://github.com/rdkcentral/rdkservices/pull/3166


Seed Data

Make some!

bump @ez500

lol sry been busy
On Mon, Oct 14, 2024 at 19:42 leo-minton @.***> wrote:

bump @ez500 https://github.com/ez500
—
Reply to this email directly, view it on GitHub
https://github.com/GatherPack/gatherpack/issues/52#issuecomment-2412528621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALDC7L7WBTITXYUFBM4CQL3Z3RJFLAVCNFSM6AAAAABJO33L46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJSGUZDQNRSGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Automatically build ubuntu package out of toolchain + libs

This way we can

Skip the 1 hour compilation of gcc toolchain every time we start on a new machine
Get all the dependencies right (i.e. GCC w. C++11 for vmbuild, qemu etc.)
Make proper binary releases

you could use cmake (cpackage) to build debian/ubuntu packages after the build system was switched over..

speaking of which: https://github.com/hioa-cs/IncludeOS/pull/918 . Still lacking many features, but at least a debian deb file with include files, libraries is build. Next step would be to add all mandatory dependencies.


ci: update to build 2 parallel jobs per run

Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

needed for CI migrations


Calendar: Calendar is not updated when click out and in

Huge mega shit, but fixed. Refactored Source to useSource.


⚠ Blutopia has degraded performance

In ef27469, Blutopia ($BLU) experienced degraded performance:

HTTP code: 502
Response time: 4092 ms

Resolved: Blutopia performance has improved in deccd22 after 30 minutes.


Collapse and Expand all in the scene tree.

This adds two buttons on the right click menu in the scene tree that allows you to collapse or expand all selected nodes and their children.

Icons looks not nice, I'd leave these options without icons at all - otherwise you should add it to all other Expand/Collapse places for consistensy

scene_tree_dock.cpp - is not formatted correctly, you should use clang-format on all cpp/h files you have been modified, see - http://docs.godotengine.org/en/latest/community/contributing/code_style_guidelines.html

Already proposed and ready to be merged in #19936. 😕

Ahh @Xrayez I didn't see your PR Ill update my implementation based on the feedback you got then.  Or if people want yours more I can close this one.


Fixed #78: Changed ObservedObject by StateObject

It looks like the Markdown.store.state changes to "notRendered" at some point.

This PR fixes the disappearing markdown view in my project with the currently released version!
Thanks @heltena!
@gonzalezreal can you please have a look and merge it if it's ok for you?

Hi,
Thanks for having a look at this. I am trying to find the root cause for the bug, that is, why the state changes to notRendered. Changing ObservedObject to StateObject is not fixing the bug, only hiding it.

Hey @heltena,
I have fixed the issue with a different approach (#83), considering other uses cases of the library (see the Dingus example, for instance). Notice that the fix is in the release-1.0 branch, together with other breaking changes I am making for the 1.0 release, which is still a work in progress.


[FR] Interested on easily serving this data as a REST API?

Hey, first of all, thanks for building this! Until we find a better way to maintain these registries on-chain, I find these data collections in JSON format very useful.
I've just added a wrapper for the official cardano-token-registry to serve its data as a mocked API and was wondering if serving this repo in the same way is something you'd be interested on.
I could adapt my work for the dbless-cardano-token-registry and send a PR to this repo if it helps. I will probably do it anyways and integrate it as a Dandelion service, but just wanted to know if contributing the code in this repo works for you. Let me know WDYT :)

We already have this but it is not open source. I can add you as a contributor. It is a simple java service.

Is there any chance that this might be open sourced soon?


Ensure changeKernels always resolves, even in error states

We've had a number of issues where the kernels/attach to dropdown can get stuck in error states.
With the current design, we are waiting on changeKernels to resolve in notebookModel before proceeding to populate the dropdowns.
Either change this design to deal with error conditions like rejecting, or ensure that we always resolve.

Moving to March - have a fix, and this will help with canceling Python install. Needs testing before pushing through ASK mode


Wdunn001/gpu

adding commands from non gpu version

here is what I get with run.sh for openwakeword:
usage: main.py [-h] [--uri URI] --model MODEL [--models-dir MODELS_DIR]
[--preload-model PRELOAD_MODEL] [--threshold THRESHOLD]
[--trigger-level TRIGGER_LEVEL] [--output-dir OUTPUT_DIR]
[--debug] [--debug-probability]
main.py: error: the following arguments are required: --model
/run.sh: line 3: --uri: command not found
whsiper:
usage: main.py [-h] --model
{tiny,tiny-int8,base,base-int8,small,small-int8,medium,medium-int8}
--uri URI --data-dir DATA_DIR [--download-dir DOWNLOAD_DIR]
[--device DEVICE] [--language LANGUAGE]
[--compute-type COMPUTE_TYPE] [--beam-size BEAM_SIZE]
[--debug]
main.py: error: the following arguments are required: --model, --uri, --data-dir
/run.sh: line 3: --uri: command not found
/run.sh: line 4: --data-dir: command not found
/run.sh: line 5: --download-dir: command not found
piper:
usage: main.py [-h] --piper PIPER --voice VOICE [--uri URI] --data-dir
DATA_DIR [--download-dir DOWNLOAD_DIR] [--speaker SPEAKER]
[--noise-scale NOISE_SCALE] [--length-scale LENGTH_SCALE]
[--noise-w NOISE_W] [--auto-punctuation AUTO_PUNCTUATION]
[--samples-per-chunk SAMPLES_PER_CHUNK]
[--max-piper-procs MAX_PIPER_PROCS] [--update-voices]
[--debug]
main.py: error: the following arguments are required: --piper, --voice, --data-dir
/run-gpu.sh: line 3: --piper: command not found
/run-gpu.sh: line 4: --cuda: command not found
/run-gpu.sh: line 5: --uri: command not found
/run-gpu.sh: line 6: --data-dir: command not found
/run-gpu.sh: line 7: --download-dir: command not found

resolved this issue now receiving two issues with piper and openwakeword
Piper:
usage: main.py [-h] --piper PIPER --voice VOICE [--uri URI] --data-dir
DATA_DIR [--download-dir DOWNLOAD_DIR] [--speaker SPEAKER]
[--noise-scale NOISE_SCALE] [--length-scale LENGTH_SCALE]
[--noise-w NOISE_W] [--auto-punctuation AUTO_PUNCTUATION]
[--samples-per-chunk SAMPLES_PER_CHUNK]
[--max-piper-procs MAX_PIPER_PROCS] [--update-voices]
[--debug]
main.py: error: unrecognized arguments: --cuda
OpenWakeWord:
Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.10/dist-packages/wyoming_openwakeword/main.py", line 176, in
asyncio.run(main())
File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/usr/local/lib/python3.10/dist-packages/wyoming_openwakeword/main.py", line 87, in main

assert (
AssertionError: Missing model: hey_jarvis
(looked in: /usr/local/lib/python3.10/dist-packages/wyoming_openwakeword/models)

from the piper docs

If you'd like to use a GPU, install the onnxruntime-gpu package:
.venv/bin/pip3 install onnxruntime-gpu
and then run piper with the --cuda argument. You will need to have a functioning CUDA environment, such as what's available in NVIDIA's PyTorch containers.

do we need to do this on image build?

Do I need a PyTorch instance to run piper on gpu?

I think preloading the model should fix the opwnwakeword issue. Not sure if we should preload that one, feels the more neutral and easy to pronounce to me, but maybe I'm wrong.
Seems like the maintainer was using ok_nabu, but because 'Nabu Casa' is the company where he works, personally I think the dafault should be something neutral and non comercial word, then they can use it for their products with whatever model they want.

I just wanted to update you I cannot get OpenWakeWord going I tried preloading a model but they can't be found. I need to redo the docker file so I can peak into the default folder to see if the model is actually there. What I think might need to happen is we allow the end user to define the model location and provide a ling for download to a list of default models. I haven't had time to set all that up recently.


fetchFromGitHub lacks leaveDotGit feature of fetchgit

Issue description
fetchFromGitHub lacks leaveDotGit feature.
fetchgit has it.
Sometimes it is useful https://github.com/NixOS/nixpkgs/pull/24151#pullrequestreview-28112520

leaveDotGit is a time bomb, and is a false friend that almost always breaks fixed-output derivation hashes every time we upgrade git. In almost all cases, build tools use it to figure out their own version (or more rarely, which files are checked into the current tree), and we don't need the complexity of 99% of the rest of the .git directory.
I'd actively oppose adding it to fetchFromGitHub unless it could be done in a way that doesn't suffer from those issues. But in general, I think just amending builds not to rely on .git is the better direction.

One possible dummy implementation of .git (that if we adopt we should use in fetchgit too) would be something like:

Initialize an empty repository
Craft a commit from the complete current source tree, with either a dummy commit message (and deterministic times, etc.) or the correct commit message from upstream (which would require teaching fetchFromGitHub about the GitHub API and all that awkwardness, instead of just being a fetchzip wrapper.
Lie about the hash in the git storage: the commit in the previous step will have the wrong hash, so we rename the backing file and repoint the ref to the new hash. If anyone runs git fsck, they'll be sad. I think most git commands won't check the hash though.
Create a tag ref for the current fetchFromGitHub rev attribute, if it was symbolic. Point it to the fake commit hash we crafted above.

But all of that seems like far more work than just making builds behave properly.


Partition as args in SparkHiveDataSet

Description
I can only partition my data with SparkDataSet and not SparkHiveDataSet whereas I want to save my data in a Hive table, and so use the _save_validate  method to make sure the columns are OK.
Context
Saving my data in Hive without having this extra validation on the schema might be risky.
Possible Alternatives
Why not using something similar to SparkDataSet: have a "save_args" in "__init__" method of SparkHiveDataSet and passing the "partitionBy" item. Then use it in the _insert_save method, using the partitionBy in the SQL statement: something like  "INSERT INTO [TABLE] [db_name.]table_name [PARTITION partitionBy] select_statement"

Hello @jpoullet2000, welcome to kedro, and thank you very much for the suggestion. I don't know too much about spark so can't make any particularly insightful comments, but it sounds like a very sensible idea. My main question would be about how to implement it.
You suggest adding save_args to SparkHiveDataSet.__init__. This would be consistent with SparkDataSet, but I'm not sure it's the right approach here. save_args is typically used in a kedro dataset to be passed into the _save method as **save_args. This would not be possible in SparkHiveDataSet, since there's no function into which those arguments would be passed; instead we'd need to extract save_args["partition_by"] and insert into the SQL statement. If anyone tried specifying other arguments in save_args then they wouldn't actually do anything, which is potentially quite confusing.
Possibly a better approach would be to just add a new partition_by argument. We already have a few arguments here:
def __init__(
        self, database: str, table: str, write_mode: str, table_pk: List[str] = None
    ) -> None:

... and these are exactly the same arguments used in the SQL query:
            f"insert into {self._database}.{self._table} select {columns} from tmp"  # nosec

So if partitioning is a common requirement for this dataset it would seem best to add it as an argument to __init__ rather than using save_args. Does this make sense to you?

It makes sense to me, @AntonyMilneQB.
Is anybody planning to work on this? I would like to implement this.

@brendalf Go for it! You might like to have a quick read of our guide for contributors.

Thanks guys!
Le jeu. 18 mars 2021 à 11:22, Antony Milne @.***> a
écrit :

@brendalf https://github.com/brendalf Go for it! You might like to have
a quick read of our guide for contributors
https://github.com/quantumblacklabs/kedro/blob/master/CONTRIBUTING.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/quantumblacklabs/kedro/issues/725#issuecomment-801803792,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFHEHWI33PYJA34OM5O3ULTEHH5LANCNFSM4ZIZII6Q
.

Hi @AntonyMilneQB, can you take a look at #745?

Hi @jpoullet2000, hope you're well!
SparkHiveDataSet has now been fully rewritten and partitionBy support has been added, including access to other save_args.
You can find the changes in the latest develop code. If you wish to wait for a proper release, you can expect these changes to materialise in version 0.18.0.
Hope this helps!

Hi,
Thanks a lot. I'm looking forward to testing it.
KR,
JB
On Wed, May 5, 2021 at 4:59 PM Jiri Klein @.***> wrote:

Hi @jpoullet2000 https://github.com/jpoullet2000, hope you're well!
SparkHiveDataSet has now been fully rewritten and partitionBy support has
been added, including access to other save_args.
You can find the changes in the latest develop code. If you wish to wait
for a proper release, you can expect these changes to materialise in
version 0.18.0.
Hope this helps!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/quantumblacklabs/kedro/issues/725#issuecomment-832758988,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFHEHXRYLWG3NEZVDSIE5LTMFMOJANCNFSM4ZIZII6Q
.


Moved [self didChangeValueForKey:@"currentState"] into correct scope

I found '[self didChangeValueForKey:@"currentState"];' is outsite of the if{} scope,that confused me, maybe it should be insite.

Thanks!


More organic timing

Randomize the time a bit in an attempt to mimic humanity; essentially untested because I don't have a Twitter account.

i want tests!

(i tested it locally and it's great, merged!)


Modelines are re-executed when focus is lost/gained

Whenever a terminal running tmux & vim loses focus, any modelines get re-executed. This wouldn't be a problem, except that my .vimrc's modeline contains set foldlevel=0, so every time I alt-tab to another window, all my folds get closed. I've tested with a fairly minimal .vimrc, and I don't think this is being caused by any other plugin; it also doesn't happen outside of tmux.
To reproduce: have this .vimrc, open it, observe that you can open and close the fold with za, and if you alt-tab with the fold open, it stays open. Then, add the line " vim: set foldlevel=0: to the end of the .vimrc (no need to save), open the fold, alt-tab, and see that the fold closes.
.vimrc:
set nocompatible

" Plugins {{{1

call plug#begin()
Plug 'tmux-plugins/vim-tmux-focus-events'
call plug#end()

" }}}

set bg=dark

set foldenable
set foldmethod=marker

set modeline
set modelines=5

Thanks for reporting. From what I can see #8 resolves this.

Changes in PR #8 have been merged to master. That should fix this issue. Let me know if you still have problems.


Publish to open-vsx.org?

Please consider publishing this extension to: https://open-vsx.org/
So that users of VSCodium can use it too.

Hi!
I'm a VS Code-OSS user, a FLOSS version of VS Code, it's the same code but without the Microsoft's telemetry and branding.
I want to request if it's possible to add the selectline-statusbar extension on the open-vsx.org marketplace, because it's unclear if Microsoft marketplace is legal to use on VS Code forks, see here.
This is how to publish a new extension.
Thanks.


Add GenericTemplateView helper

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #1   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      3    +1
  Lines          18     24    +6
  Branches        2      2
=====================================
+ Hits           18     24    +6

Impacted Files
Coverage Δ

template_helpers/views.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82904f...8df2421. Read the comment docs.


Makes tests client-side only + updates to latest arq-core

With @Deployment(testable = false) all tests are executed as-client and none of Arquillian extensions are deployed together with application war. This makes it a bit leaner and closer to the reality. Also fits better REST tests which are blackbox.

Thank you!


Cannot load GTK 4 (3.96.0)

lua53: ./lgi/override/Gdk.lua:23: bad argument #1 to 'registerlock' (userdata expected, got nil)
stack traceback:
        [C]: in function 'lgi.core.registerlock'
        ./lgi/override/Gdk.lua:23: in main chunk
        [C]: in function 'require'
        ./lgi/namespace.lua:183: in function 'lgi.namespace.require'
        ./lgi/namespace.lua:170: in function 'lgi.namespace.require'
        samples/console.lua:7: in main chunk
        [C]: in ?

Line 23 is:
core.registerlock(core.gi.Gdk.resolve.gdk_threads_set_lock_functions)

According to https://developer.gnome.org/gdk3/stable/gdk3-Threads.html#gdk-threads-set-lock-functions, gdk_threads_set_lock_functions was deprecated in Gdk 3.6. I guess that means it was removed in Gdk / Gtk 4. According to https://developer.gnome.org/gdk4/stable/, the whole threads API was removed (???).
The only way forward that I see is to just drop this lock-related code (just remove line 23 of said file) and update the documentation to point out explicitly that in GTK 4, we do not provide thread-safety, because GTK 4 provides All GDK and GTK+ calls should be made from the main thread as the replacements for the dropped APIs.
(Note that removing line 23 will likely just uncover more problems. Line 24 tries to call gdk_threads_init(), which was also deprecated and I bet dropped in Gtk 4.)

Another thing to point out here, GtkContainer no longer exists, so overrides for it will no longer work
https://developer.gnome.org/gtk4/stable/ch41s02.html#id-<IP_ADDRESS>.29
The idea with this change was to simplify the creation of custom widgets, in addition to encouraging the concept of "composition over inheritance" and "everything is a widget"

This is an old comment but I just wanted to add:

The only way forward that I see is to just drop this lock-related code (just remove line 23 of said file) and update the documentation to point out explicitly that in GTK 4, we do not provide thread-safety, because GTK 4 provides All GDK and GTK+ calls should be made from the main thread as the replacements for the dropped APIs.

GTK has never been thread safe, the locks were never enough to be thread safe, and they were removed because people thought it was thread safe.

any updates on this?

any updates on this?

Yes please.  I'm considering using Gtk4 for a new project but i need to have Lua scripting.

I fiddled with this but it requires a decent amount more work I believe: https://github.com/TingPing/lgi/commit/eeafbb5dd4a724811431e84edb4c259aa82b1961

is LGI ever going to support GTK4 at all?


[dcmtk] Build error

Host Environment

OS: windows 11
Compiler: visual studio 2017

To Reproduce
Steps to reproduce the behavior:
./vcpkg install dcmtk
Failure logs
Computing installation plan...
The following packages will be built and installed:
    dcmtk[core]:x64-windows -> 3.6.7#3
Detecting compiler hash for triplet x64-windows...
Restored 0 package(s) from C:\Users\94836\AppData\Local\vcpkg\archives in 91.1 us. Use --debug to see more details.
Installing 1/1 dcmtk:x64-windows...
Building dcmtk[core]:x64-windows...
-- Using cached DCMTK-dcmtk-a137f1aff4e1df3fbefe53ee8b160973c74c96dd.tar.gz.
-- Cleaning sources at C:/Study/vcpkg/buildtrees/dcmtk/src/73c74c96dd-40e15685f3.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Study/vcpkg/downloads/DCMTK-dcmtk-a137f1aff4e1df3fbefe53ee8b160973c74c96dd.tar.gz
-- Applying patch dcmtk.patch
-- Applying patch windows-patch.patch
-- Using source at C:/Study/vcpkg/buildtrees/dcmtk/src/73c74c96dd-40e15685f3.clean
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:131 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v -j21
    Working Directory: C:/Study/vcpkg/buildtrees/dcmtk/x64-windows-dbg
    See logs for more information:
      C:\Study\vcpkg\buildtrees\dcmtk\install-x64-windows-dbg-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  ports/dcmtk/portfile.cmake:43 (vcpkg_cmake_install)
  scripts/ports.cmake:147 (include)
error: building dcmtk:x64-windows failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+dcmtk
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[dcmtk]+Build+error
Include '[dcmtk] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2022-12-14-7ae0d8527fb488fde10a89c2813802dc9b03b6f9
    vcpkg-scripts version: 739824a6d 2023-01-07 (12 hours ago)

Additional context
from console it mention the install-x64-windows-dbg-out.log, I am not sure that I should post here because it  has more than 1000 rows logs info.

Could you please provide the C:\Study\vcpkg\buildtrees\dcmtk\install-x64-windows-dbg-out.log file to me? Thank you.

We haven't been able to repro this; if more information comes up, or this issue appears again, please reopen.


As dotnet tool

with options to generate an example config and use a custom confg to generate a report from toggl

Thank you, great additions! Could you please also be so kind and update the readme to explain the new command line options?

Added requested changes :)


ADD table of Content and API Documentation on README file

Pull Request
Title
Add Table of Contents and API Documentation in README file
Description
This pull request adds a comprehensive Table of Contents and API documentation to the README file, enhancing navigation and providing clear information about the project's features.
Related Issues : #649
Changes Made

Added a Table of Contents section to the README.
Included detailed API documentation for various predictions (fertilizer, crop, soil quality, yield, mushroom edibility).

Checklist

[ ] I have tested the changes locally
[x] Documentation has been updated (if necessary)
[ ] Changes are backward-compatible

Screenshots (if applicable)

Additional Notes
No additional information.

@manikumarreddyu  the task has been completed.


Branks42 Consistent Token Error Messages

Work Completed

Change token authorization error messages for consistency across all partners
Update tests...

Steps Required

N/A

Great thinking


Fixed error message on importing statsmodels

I found a customised error message that wasn't working (you try and add something to the end, but it doesn't actually get output, see below).  Also err.message is deprecated and isn't in py3, so this might fix a headache in the future.
Before:
    830     """
    831     try:
--> 832         import statsmodels.api as sm
    833     except ImportError as err:
    834         err.message += "\n You need to install statsmodels to use the FFT based correlation function."

ImportError: No module named statsmodels.api

After:
    830     """
    831     try:
--> 832         import statsmodels.api as sm
    833     except ImportError as err:
    834         err.args = (err.args[0] + "\n You need to install statsmodels to use the FFT based correlation function.",)

ImportError: No module named statsmodels.api
 You need to install statsmodels to use the FFT based correlation function.

Good catch, thanks!


feat: foxWallet

@DanielSinclair the issue should be fixed, could u check again

@DanielSinclair kindly pls check again

@DanielSinclair seems all the issue have been fixed ? Could u update the labels, thanks

@icodeface Please enable changes from maintainers on this PR

Sorry, i cannot find the option "Allow edits from maintainers" in this page, could be the issue: https://github.com/orgs/community/discussions/5634
So i just add you to my repo with write permission, is it ok ?


Remove teaser class from Snippets pages

Teaser class was for the Main view. I replaced the teaser class with snippets class to reserve it for styling.

Clarification, the change also improved the visual style.


ci(release): 3.1.0

Automated changes by create-pull-request GitHub action

:tada: This PR is included in version 3.2.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[Bug]: BLE operation lock not released when cleaning up characteristic notify subscriptions before closing connection

Component/Nuget
BluetoothLE Client (Shiny.BluetoothLE)
What operating system(s) are effected?

[ ] iOS (13+ supported)
[ ] Mac Catalyst
[X] Android (8+ supported)
[ ] Windows (.NET 7 Target - only Core is currently supported, BLE is coming)

Version(s) of Operation Systems
Android 13
*This issue was tested against a device running iOS 15.7.7 and was NOT reproducible.
Hosting Model

[X] MAUI
[ ] Native/Classic Xamarin
[ ] Uno
[ ] Manual

Steps To Reproduce

Connect to BLE peripheral
Subscribe to Characteristic that supports Notify
App operation
Start "disconnecting" from the device
a. Dispose subscription to characteristic notify
b. Call CancelConnection on peripheral
Attempt to reconnect to the device
Peripheral reconnects
Subsequent attempts to read/write to and characteristic timeout because BLE operation lock cannot be obtained

Expected Behavior
BLE operational lock is released, regardless of temporal proximity to canceling connection on a peripheral
Actual Behavior
BLE operational lock is NOT released if called immediately before canceling connection on a peripheral
Exception or Log output
Clean connection to peripheral:

Disconnection WITH delay between disposal and canceling connection:

Disconnect WITHOUT delay between disposal and canceling connection:

*NOTE: BLE operation lock was not released before close().
Failed "connection" to peripheral AFTER disconnecting WITHOUT delay between disposal and canceling connection:

*NOTE: BLE operation lock is not obtained, then characteristic write operation times out.
Code Sample
A code sample not applicable as a connection to BLE peripheral with a notifiable characteristic is required for the reproduction of this issue.
Code of Conduct

[X] I have supplied a reproducible sample is NOT FROM THE SHINY SAMPLES!
[X] I am a Sponsor OR I am using the LATEST stable/beta version from nuget (v2.7.1 stable - ALPHAS are not taking issues)
[X] I understand that if I am checking these boxes and I am not actually following what they are saying, I will be removed from this repository!

Thank you for thorough report.  I have a test failing likely due to this.  Should be easy enough to fix

Awesome! Thank you.

Confirmed this evening that the problem is resolved! Thanks!


Added "add database columns" to form builder

This PR adds the "add database columns" feature to the form builder component.
Let me know what you think!

I also stumbled upon a bug where the datatable dropdown does not seem to work correctly when loaded in a popup. A fix is available, I'll work on a proper PR with a proof of the bug later today.
Edit: PR for this bugfix is here: https://github.com/octobercms/october/pull/4807
Just keep in mind to apply this fix to your installation if you are testing this PR:
https://github.com/OFFLINE-GmbH/october/commit/6ec2a85becc6f0a764013568674bde95fc19fe64

@tobias-kuendig, it looks awesome! :)

@tobias-kuendig this looks pretty awesome! We'll try to get your bugfix included in 460 so that this could be supported on 460

@tobias-kuendig This looks fantastic! My only suggestion would be the terminology for "Add database columns" is probably misleading - you are not adding actual database columns, but instead adding fields based on the columns. Perhaps this could be "Add fields from database"?

Good point, @bennothommo! I have changed the wording accordingly.

I had to add another parameter to the addControlToPlaceholder method that allows to explicitly pass in a field name. Otherwise the method would only generate text1, text2, etc.
The method now has five parameters, I hope this is still acceptable.

Is there anything I can do to get this merged?

@tobias-kuendig We just need people to test it out and confirm it works with weird field types and large field sets.

Is there anything specific blocking this PR? We could use this every day :grin:!

LGTM! Thanks as always @tobias-kuendig

Wow, this is really super cool @tobias-kuendig
Thanks for the addition!


define a consistent version variable

This one fixes #274 and introduces a very nice an clean way to handle the version number in setup.py

consider using semver going forward?

release management is yet another issue... I'll change it to 3.1.0-dev then.


Clarification on event simulator parameter changes frequency in event data generation

Hello!
Thank you for providing the DataPreparation.md guide! It's an excellent resource for simulating and generating event voxels. However, I have some confusion regarding Step 1: Event data generation. Specifically, I would like to understand how frequently the parameters of the event simulator are randomized. Do these parameters change each time an entire video sequence is processed, every time a partial frame of the video sequence is processed, or perhaps in some other way?
I appreciate your assistance and look forward to your response. Thanks!

@W-Shuoyan Hi, for each video that requires event simulation, the random numbers Cp and Cn are generated once. This means that each simulated video has a unique random threshold. Thank you for your interest in our work.


chore: bump cairo version in examples

Introduced changes

Updates the scarb / starknet version / edition in examples
Adds required imports,  removes useless imports

currently this doesn't compile because snforge test doesn't seem to be compiling contracts under default features.
Checklist

[ ] Linked relevant issue
[ ] Updated relevant documentation
[ ] Added relevant tests
[x] Performed self-review of the code
[ ] Added changes to CHANGELOG.md - where would this go?

This should work after #2570 is merged


Multiple archives in sources

We found a case - kernel that has multiple archives in sources:

SOURCES/kernel-abi-whitelists-4.18.0-211.tar.bz2
SOURCES/kernel-kabi-dw-4.18.0-211.tar.bz2
SOURCES/linux-4.18.0-211.el8.tar.xz

dist-git-to-source-git can now work only with one archive.

how exactly are they being unpacked in %prep?

Only linux-4.18.0-211.el8.tar.xz is used unpacked, the other two are used as they are https://git.centos.org/rpms/kernel/blob/c8s/f/SPECS/kernel.spec#_500

they are unpacking it in %build -_-
https://git.centos.org/rpms/kernel/blob/c8s/f/SPECS/kernel.spec#_1391

For our case it doesn't matter, does it? we only care about about %prep

I hope so, it really depends how the generate the archives - if they are coming from different git repos or branches, we may be in trouble


unable to remove documentation

We've moved our documentation and would like to be able to take it down here so that there isn't outdated documentation floating around, but can't seem to. Is there a solution to this?
The page is
http://pycbc.readthedocs.org/en/latest/

Should be gone.


Remove "inverse" relationships in SYSTEM.sadl

We have 2 pairs of inverse relationships in SYSTEM.sadl (source is inverse of provides and destination is inverse of requires). The domain and range for these 2 pairs are such that they are not inverses. And since we do not really use (or enforce) the inverse property, it was decided to drop both of these inverse relationships.

Related to PR https://github.com/ge-high-assurance/RACK/pull/523


DexException, Can not cordova compile

Expected Behaviour
cordova should be able to compile
Actual Behaviour
cordova compile fails with exception
Reproduce Scenario (including but not limited to)
Default webapp for meteor + pushPlugin
List of plugins:
cordova-plugin-console 1.0.2 "Console"
cordova-plugin-meteor-webapp 1.3.0 "Meteor Webapp"
cordova-plugin-splashscreen 3.2.1 "Splashscreen"
cordova-plugin-statusbar 2.1.2 "StatusBar"
cordova-plugin-whitelist 1.2.1 "Whitelist"
cordova-plugin-wkwebview-engine 1.0.2 "Cordova WKWebView Engine"
phonegap-plugin-push 1.6.3 "PushPlugin"
Steps to Reproduce
cordova compile
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 5.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
HTC
Cordova CLI version and cordova platform version
cordova -v
6.0.0
cordova platform version android
Installed platforms: android 5.1.1
Plugin version
1.6.3

Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem
gradle dependencies:
+--- com.android.support:support-v13:23+ -> 23.1.1
|    --- com.android.support:support-v4:23.1.1
|         --- com.android.support:support-annotations:23.1.1
+--- com.google.android.gms:play-services-gcm:+ -> 8.4.0
|    +--- com.google.android.gms:play-services-base:8.4.0
|    |    --- com.google.android.gms:play-services-basement:8.4.0
|    |         --- com.android.support:support-v4:23.0.0 -> 23.1.1 ()
|    --- com.google.android.gms:play-services-measurement:8.4.0
|         --- com.google.android.gms:play-services-basement:8.4.0 ()
--- project :CordovaLib
UNEXPECTED TOP-LEVEL EXCEPTION:
com.android.dex.DexException: Multiple dex files define Lcom/google/android/gms/actions/ItemListIntents;
at com.android.dx.merge.DexMerger.readSortableTypes(DexMerger.java:579)
at com.android.dx.merge.DexMerger.getSortedTypes(DexMerger.java:535)
at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerger.java:517)
at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.java:164)
at com.android.dx.merge.DexMerger.merge(DexMerger.java:188)
at com.android.dx.command.dexer.Main.mergeLibraryDexBuffers(Main.java:504)
at com.android.dx.command.dexer.Main.runMonoDex(Main.java:334)
at com.android.dx.command.dexer.Main.run(Main.java:277)
at com.android.dx.command.dexer.Main.main(Main.java:245)
at com.android.dx.command.Main.main(Main.java:106)

phonegap-plugin-push doesn't have any problem, but meteor 1.3 does, wrong place to put this. I will close this. Sorry.


Set  when viewing a beta notification

When viewing a notification in the new beta notifications feature, the  of the window is just "Notifications". If you have several notifications open, it makes it difficult to find which one you were looking for.
https://github.com/notifications/beta/MDE4Ok5vdGlmaWNhdGlvblRocmVhZDQyMjY0MjY5Njo4MTE5NTQ=?query=is%3Aunread

My suggestion is that the title of the window is updated to match the name of the issue/PR that you're looking at, like regular issues are.
https://github.com/tobias/dynapath/issues/12

Perhaps you'd also add " - Notification" to the end of it to distinguish the tab from an issue view.
Example URL: https://github.com/notifications/beta/MDE4Ok5vdGlmaWNhdGlvblRocmVhZDQyMjY0MjY5Njo4MTE5NTQ=?query=is%3Aunread

We are not in the beta, so we cannot do anything about this until it’s out of beta. I would strongly recommend that you suggest this using the feedback link in the notifications beta.

Sorry, I should have mentioned I did suggest this change in the beta, but it was declined.

They did it. Also thankfully the URL is not under /notifications/ but it's from the real issue 🎉 so all our features work


not supported 10.0.19041.1387

someone have this error?

Duplicate of https://github.com/stascorp/rdpwrap/issues/1630


VSCode requires Mono even for dnxcore50 version OmniSharp

Repo
Issue is found on Linux. It should apply to Unit, too

Install VS Code
Download a dnxcore50 version OmniSharp
Set up csharp.omnisharp path
Start a project

[INFO] Starting OmniSharp at '/home/troydai/code/omnisharp-roslyn'...
[ERROR] Error: Cannot start Omnisharp because Mono version >=4.0.1 is required. See http://go.microsoft.com/fwlink/?linkID=534832#_20001

This is already fixed by PR #106. Try using C# extension from the https://github.com/OmniSharp/omnisharp-vscode/tree/dev branch.


[Feature Request]: Display Song Specifications & Song Preference Settings

Hi jjdenhertog!
First off, I just want to say a big thank you for this app. It was exactly what I was looking for. Long story short, I recently decided to not renew my Spotify subscription because I do have lots of music on my NAS. But what it really lacked is having playlists that matches the music I have on Plex! 🙏 Anyway, I'm now able to listen to pretty much the same music I like, but in FLAC format, and with no subscription, all locally on my LAN. 🎉
I have a feature requests that might enhance user experience, if you don't mind. No pressure, it's more for the upcoming versions.
Display Song Specifications:
When selecting a song, it would be great to see its specific details, such as bitrate and format. This would allow users to make informed choices based on their preferences.
Song Preference Settings:
It would be really helpful to have a setting to prioritize certain song formats. For example, if I prefer FLAC files, the software could automatically select those when available. This would save time and effort, especially when multiple options are present. It tends to take what I'm guessing is the first entry found, but it may not be the best selection.
I hope these ideas are valuable,  and again, thanks for your great hard work! 😊

Hi Alex,
Thanks a million! It really looks like the reason why I also created this. I'm using my NAS with Plex at home to listen to high quality music. But I found that I switched to Spotify because I was missing the playlists.
I will add the features to the list. The settings for the "Song Preference" will probably need to be expanded a bit. Currently it tries to find matches as good as possible and then go for "the best match". Which means the best match on song title / artist / album.
As I see it you would need to options:

Prefer FLAC (default on) when matches are the same
Enforce FLAC (default off)

The "enforce flac" option will try to match the FLAC even if the algorithm isn't marking the song as "best match".
Cheers,
Jaap

Hi Japp,
I'm glad to hear I wasn't the only one in this situation. 😅 I mean, I've been a long time subscriber of Spotify, starting around 2010 with a paid subscription. But Spotify never went the lossless route and I love hires music. having Tidal, Spotify & Amazon Music started to pile up on the monthly bills, so I took the decision to cut them off and use my local music on Plex.
Then, I realized I'd spend the vast majority of my time searching that music back, creating playlist manually, etc., while this data is technically available for free on Spotify. 🎉 Truth be told, I had found other script that did something similar, but they were scripts, meaning you had to build a config file and there wasn't much choice selection if the song was the wrong one. Customization was non-existent, but it worked. I've done it for a while, until I found your repo. I definitely prefer your option as it comes with a UI and it runs in dockers. And it will be community driven, meaning it'll evolve over time. I personally run Unraid, so this is a perfect docker solution for me.
Thanks so much for wanting to integrate these suggestions. 🙏 I agree with you the initial idea about Song Preference was rather limited. If you have control over the search logic, perhaps it could be that after it found one or many exact matches, then it tries to go per user's preference. I like your idea as a first iteration to prefer or enforce FLAC, as long as it goes back to other format when it doesn't find it in FLAC format. I think what could be even more interesting is having the choice of multiple format, bitrate, etc. Something like this as an idea:
Format Selection: mp3 / aac / alac / flac / aiff / wav (in no particular order - but the idea would be to sort them a bit like in the *arr suite where you can decide the priority based on a weight/number, or something like that.)
Min/Max Bitrate Selection (mostly useful for mp3s, in case you have 128kb but also have a 320kbs version and you'd want to have the 320kbs if available.)
And these would only be fulfilled if such a format/bitrate is available within those range. It's nitpicking but I feel this would make the software even more customizable. And I just want to reiterate that this is just an idea and this could be implemented totally differently. It's mostly to make sure it scales up well with any audio format, not wanting to assume everyone uses FLAC as the official lossless standard, since others are using alac, wav, etc.
Thanks again for your time and have yourself a great day! 😊
Alex


Unit testing

Thinking of using https://github.com/bats-core/bats-core

Closed in https://github.com/jyn514/crappy-server/commit/b4a1be0925503c8b80bc8b59ccfa16bb1115754e


lrs3 dataset

Where do you download your lrs3 data sets? Is there a download link? Can you share?

Has it been resolved？ Can you share with me

Hello, have you got this dataset?


Categories showing i18n and en

It does not list the tags included in the posts

?

It is a specific issue as follows:
I tried to create a Chinese/English website. I used plugins multilang.rb. It works but the categories for the posts are not shown as intended.
So I am still searching for the best way to create a Chinese/English website. I just upgraded Jekyll to the latest version.

你在自己的项目里提issue 打算等谁回答

自己 ：）


issue4: Make function wraps into class variables instead of instance …

…variables

Could this not have been achieved with @classmethod instead?

@glubsy  - Yes that would have achieved the same goal.  That might have made the code a bit more flexible instead of hard-coding the name of the class in the function.   :)


Enable dual-stack cluster for e2e test

In this PR,
We enable the dual-stack cluster for flow-visibility e2e test in order to test IPv6 traffic.

/skip-all


Create and pass a UID in the login success response that can be tied back to that user

Feature request
I'd like to identify users in LogRocket as described here. We need to generate an anonymous UID, but I can't do so safely in generating it on the client.
Proposed solution
Tie a unique, immutable, ID value to each user and pass it in the login response.

Is the UID supposed to be anonymous but still tied back to the user?  Even between sessions?

Yes, but now that I think about it more, it seems tough to do on the back-end without privacy/security raising eyebrows.
https://stackoverflow.com/a/4445584/7304377
It sounds like I can do it all on the client w/ some degree of accuracy :)


feat: new homepage design

why 3 lines in collections card if there are only 2 when they are loaded?

if price is displayed like 12e232 then it means it's a number being converted to a string, you should use format/parseUnits from ethers

images overflow parent container


Add math/factor

Related: #147

Adds math/factor:

(math/factor n)

Returns an array containing the prime factors of `n`.

Speeds up miller-rabin-prp?

Did some testing.  The following seemed to agree with an online checker.
$ JANET_PATH=~/src/spork.primo-ppcg/jpm_tree/lib ~/src/janet/build/janet
Janet 1.30.0-d2dd241e linux/x64/gcc - '(doc)' for help

repl:1:> (upscope (import spork/math) :done)
:done

repl:2:> (math/factor 1023)
@[3 11 31]

repl:3:> (math/factor 1024)
@[2 2 2 2 2 2 2 2 2 2]

repl:4:> (math/factor (int/u64 "77777777777777777"))
@[<core/u64 7> <core/u64 2071723> <core/u64<PHONE_NUMBER>>]

repl:5:> (math/factor (int/u64 "1888888881188888888"))
@[<core/u64 2> <core/u64 2> <core/u64 2> <core/u64 41> <core/u64<PHONE_NUMBER>600271>]

repl:6:> (math/factor (int/u64 "547716131821"))
@[<core/u64<PHONE_NUMBER>21>]


Fix testing gaps for CRT

Adding in minor test tweaks to fix issues discovered with CRT during the CLI v2 migration.

Codecov Report

Merging #221 (05c7a9c) into develop (cdd4ad4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #221   +/-   ##
========================================
  Coverage    85.41%   85.41%
========================================
  Files           16       16
  Lines         2764     2764
========================================
  Hits          2361     2361
  Misses         403      403

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd4ad4...05c7a9c. Read the comment docs.