README.md: Add a build note for Intel Macs

I just had a conversation on Slack where a user attempting to install
on an Intel Mac got a build error because it was trying to build with
Apple M-series GPU support. Adding an explicit build instruction to
disable that support made the build successful. Add this to the
install docs.
Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

@russellb I confirm, the doc change make sense to me


Use Gradle version catalogs

Using Gradle version catalogs helps to:

unify where dependency versions are defined
improve build performance (eliminates defining dependencies in buildSrc)
enable the usage of Renovate to automatically update dependencies via pull-requests

Blocked by #41.


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Coverage remained the same at 86.64% when pulling 6b6711c9f33ef8b949983489a422320cfef0bdf0 on analysis-q1WZ7N into 3776bc652545a64eded894e760359a70d42e26c8 on master.


"Run python file in terminal" opens Terminal panel although a terminal in the editor is (and should be) used.

Does this issue occur when all extensions are disabled?: No

Version: 1.59.0-insider
Commit: 9520f0a515e7e24802c92f885a0efb242fca3831
Date: 2021-07-14T05:14:09.735Z
Electron: 13.1.6
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Linux x64 5.12.15-arch1-1
Steps to Reproduce:

Have "terminal.integrated.defaultLocation": "editor" in your settings.json and the panel hidden
Open a .py or .R file with any command
Run using ctrl + enter or the "Run" Icon
Panel will pop up and a new terminal will be created and used in the editor area. The panel won't be used and should not pop up.

Example for python:

Example for R:

This does not occur when using the python interactive window:

I truly hope this bug was not already reported. I could not find it. Since it affects at least 2 extensions I hope it was reasonable to post it here.

Created PR #128866 fixing this

Verified that running a python file no longer shows the terminal panel with "terminal.integrated.defaultLocation": "editor" configured
Version: 1.59.0-insider (user setup)
Commit: e437d424c5e6de97632f5513229c7ebc2cf27a32
Date: 2021-07-28T05:13:47.114Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19043


Depend on bitcoin v0.32.0-rc

Test the latest bitcoin release candidate. Includes bumping the version numbers so we can use this branch to test crates further up the stack.

Testing is done, new release is out.


Run azd up fail in codespace and windows

Describe the issue:
When executing azd up according to README.md, the error is as follows:

Repro Steps:

Run azd auth login
Run azd up

Environment:

OS: Windows desktop and CodeSpace.

Expected behavior:
Run azd up can pass.
@tataraba ,@rajeshkamal5050 for notification.

Looks like it was an issue of nested quotes. Azure doesn't like the nested single quotes, so I replaced the command line to match another sample app in AZD Templates Python to-do app

This was fixed.


Set up file structure for concrete model

Previously, I had the concrete model all in one file, and it wasn't exactly clear what was part of the TCB and what was part of various different layers of abstraction. My previous setup also diverged from the code in several places in terms of how it handled success/failure and what I called address types. I have fixed both issues with the following steps:

Made my functions return success/failure booleans instead of the option monad
Changed my address-type names so they match the code
Created a new subdirectory Concrete/Assumptions where I put the interfaces to all of the files that aren't currently in scope. These are transcribed as directly as possible from the header files; functions have the same names and type signatures (except where functional programming requires me to return a new state, like for mpool).

I modified ConcreteModel.v to use the new setup. The most substantial lines-of-code changes here are my moving some of the code from ConcreteModel.v into a new file State.v that sets up the concrete model's state type, so that ConcreteModel.v has almost nothing but transcriptions of C functions.
Eventually, I aim to get rid of ConcreteModel.v entirely and separate out the transcriptions into files corresponding to mm.c and api.c, but that is left for a later PR.

Wow, this is a pretty significant change. Probably, the most productive way for me to follow up this change is to let it merged first then read the updated files thoroughly. I will begin making comments later.


Filename of resolved handle address displayed instead of handle in 01_sendlovelaces.sh

./scripts/01_sendLovelaces.sh wallet/smallwallet4 '$arcter' ALL
     Version-Info: cli 1.35.3 / node 1.35.3          Scripts-Mode: online            Mainnet

  Found $adahandle '$arcter' on Address: addr1qys8....... 7zl
  Sending lovelaces from Address wallet/smallwallet4.addr to Address /tmp/adahandle-resolve.addr:

also at
     Lovelaces to send to /tmp/adahandle-resolve.addr:  9.828779 ADA / 9828779 lovelaces

yes the script creates a temporary address file in the tmp folder. normally you have the address files ready on the hdd. the intention behind showing the file was to have a confirmation again that the right address was choosen. the file -> address is shown resolved at the top.

Yes, it would be consistent  to reshow the e input to the command , showing the  handle $arcter ,  instead of the  temporary working file.  The name of the temp file means little to the user.
Just a cosmetic change, I am easy either way.

Changed it. Currently in Testnet-Folder, will be moved to Mainnet-Folder too later on.


Add cloud-first release notes for v24.2.0

Fixes DOC-10586, DOC-10587, REL-1220

@mdlinville just pushed latest changes based on your feedback
one open question about one of your comments I did not understand
PTAL!
PS still need to confirm with release team whether we're calling the release date today (8/12) or tomorrow
will update the PR once I confirm that info


ensure requirements.yml works with actual ansible versions

Gonna close this since Ansible is now >1.8 and thus requirements.yml is the way.


[merge] Add support for line mode

It looks like the current MergeView is using the "word" mode in diff-match-patch. It would be awesome if there was an option in the merge addon to use "line" diffs instead. For example, this looks a little confusing and would look better as a line diff:

More info: https://github.com/google/diff-match-patch/wiki/Line-or-Word-Diffs

That'd be reasonable, and would be a small change, I guess. Want to submit a patch?

Yep, I'll give it a go 👍


[#1349] improvement(server-common): Modify the default value of allowMethods for CorsFilter

What changes were proposed in this pull request?
Modify the default value of allowMethods for CorsFilter
Why are the changes needed?
Our alter api uses the method PUT. It will be more convenient for users.
Does this PR introduce any user-facing change?
Modify the document.
How was this patch tested?
By hand.

cc @danhuawang

Create an issue to track this thing.

Create an issue to track this thing.

https://github.com/datastrato/gravitino/issues/1349
Created.


Added cost calculation for the construction calculator

Added tooltip text detailing how many of each material is required.
I've edited the entries to only some of the actions in the skill resource json file, needs to be completed.
Possible to use the same actions and calculations to add a cost calculator for herblore.

Used the code style scheme provided in the wiki to format the files  I've touched (including the resource json file).
added the license header to Material.java, and added my name in the SkillCalculator.java credits (if this contribution isn't sufficient to add that let me know and I'll change it).
Changed the imports as was mentioned.
and I've moved the tooltip and cost setting into the getMaterials null check block (also added comments explaining them if it matters).

After searching similar cases, it seems it's also related to issue #11154
Just needs to add similar field (albeit redundant) to the resource for prayer, as the code I've added only calculates cost if the skill resource file contains the "materials" field (to avoid trying to calculate cost for non buyable skills such as hunter/wood cutting)


Bugfix/market details screen nav

❓ Context

Impacted projects: live-desktop

Linked resource(s):

Fixes issue on navigation on market details page.
Now data shows up instantly + double breadcrumb fix + removal of forced refresh when coming back to main list page.
✅ Checklist

[ ] Test coverage: Did you write any tests to cover the changes introduced by this pull request?
[X] Atomic delivery: Is this pull request standalone? In order words, does it depend on nothing else?
[ ] Breaking changes: Does this pull request contain breaking changes of any kind? If so, please explain why.

📸 Demo
https://user-images.githubusercontent.com/11752937/165238987-94d9f682-e2ca-42d7-8761-28495a29f46f.mp4

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Hey hey @LFBarreto, can you please add a changelog 🙏 ?

/generate-screenshots


[StaticSite]: Can we make deployment prefixes "optional"?

In-place Deploys: (3mins - avg build time)
In the past we have never really been concerned about true blue-green deploys and so out production deploys of our static sites would just use the aws cli to sync and remove orphans with each deploy.
sst.StaticSite Deploys: (16mins - avg build time)
Contrasting this to us now using sst.StaticSite and its use of deployid as a bucket prefix.
This now means that the CloudFront distro needs to be updated (origin path) so that adds 6-15mins of replication/deploy time.
Optional prefixes and us
With optional prefixes, I would like to write a CDK construct that handles Cloudfront distro cutovers and true blue-green deploys. We would only do that for production, while dev deploys stay spicy fast. Even without this construct… one could at lease make the deploy prefixes optional for Prod only, again, keeping dev deploy fast.
Happy to write and present a PR for this if you're agreeable to it.

PR Submited #1327

Deploy prefix is removed in v0.61.3


Call GlWindow#resize on resize events in examples

Additional call is required on mac/wayland, see glutin docs & this comment

This is what you were after right @mitchmindtree?

Thank you!


[FEAT] Add number of comparisons to match weights chart

Is your proposal related to a problem?

Linked to #1442 and #1434
It would be helpful to have a quick reference to the number of pairwise comparisons considered in each comparison level in the match weights chart. This could be particularly useful when dealing with model training issues as a result of small samples.
Describe the solution you'd like

Add the count and percentage of pairwise comparisons considered by each comparison level.
Describe alternatives you've considered

Additional context

Potentially relevant image from this Slack discussion
In addition to the m, u and match weight charts, there used to be a "proportion of comparisons" chart showing how all comparisons were distributed among the levels. This shows where levels rarely or never appear, even if their model parameters appear sensible, or explaining why model parameters aren't sensible (#1434)


add ability to edit ghost colors

About the PR

Fixes a CRITICAL issue, caused by sprite being removed from server, that affects me continuously as I admin.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

probably could just be a command, if it's being used this frequently. It's kinda a weird thing to be shoving onto the ghost component itself.

emphasizing critical

Very important


add public npm registry url as publishConfig

  "publishConfig": {
    "registry": "https://registry.npmjs.com"
  }

https://github.com/paypal/react-engine/pull/8


Avoid build breakage by switching Dockerfile dependencies

Last couple of builds have failed, seems like something to do with the Debian python3-cryptography package not installing all the necessary libraries. I swapped out using [installation directions from cryptography's docs]
(https://cryptography.io/en/latest/installation/#building-cryptography-on-linux), and am no longer getting Dockerfile build failures locally.

:heart:, thanks!

Success <3


Health Probe with -addr=:50051 Does Not Respect no_proxy Environment Variable

When using the health probe with the address configuration -addr=:50051, it appears that the probe does not respect the no_proxy environment variable. This is likely because no explicit host is specified, and localhost/<IP_ADDRESS> is implicit.
Steps to Reproduce:
Set the http_proxy and no_proxy="localhost,<IP_ADDRESS>" environment variables.
Run the health probe with the configuration -addr=:50051.
Observe that the probe does not respect the no_proxy setting and attempts to use the proxy for the health check.
Expected Behavior:
The health probe should respect the no_proxy environment variable, especially when targeting the local host.
Actual Behavior:
The health probe attempts to use the proxy even when targeting the local host, ignoring the no_proxy setting.
Possible Solution:
Ensure that the health probe checks the no_proxy environment variable and handles implicit localhost addresses correctly.

Hi Ahmetb,
thank's for your response.
The no_proxy environment variable is indeed a standard used in Unix and Linux systems. It specifies a list of IP addresses, domains, or hostnames that should be accessed directly, bypassing the proxy specified in the http_proxy or https_proxy environment variables.
The no_proxy variable is commonly used in conjunction with the http_proxy and https_proxy variables to define exceptions for hosts that should not be accessed via the proxy. For instance, when accessing local resources within an intranet, it's often necessary to bypass the external proxy. This is where the no_proxy variable comes into play.
You can find documentation on this in various places, including:
man pages: If you check the man page for wget or curl, you'll find references to the no_proxy variable.
GNU Wget documentation: Link to Wget documentation
cURL documentation: Link to cURL documentation
Given its widespread use and the fact that many tools and libraries respect this variable, it would be beneficial for the health probe to also recognize and adhere to the no_proxy settings, especially when targeting localhost or <IP_ADDRESS>.
I hope this provides clarity on the significance of the no_proxy environment variable. Let me know if you need any further information or references.

@dSchaexn

This is likely because no explicit host is specified, and localhost/<IP_ADDRESS> is implicit.

Correct. According to Go's default transport docs/code, it should be excluding localhost, <IP_ADDRESS>, or ::1 from proxies by deafult, per https://pkg.go.dev/net/http#ProxyFromEnvironment and https://cs.opensource.google/go/x/net/+/refs/tags/v0.19.0:http/httpproxy/proxy.go and it should be still respecting no_proxy env var if specified.

Possible Solution:
Ensure that the health probe checks the no_proxy environment variable and handles implicit localhost addresses correctly.

This is likely a wontfix because as the user, you can specify localhost explicitly.

@ahmetb 👋 I don't quite think that works. I haven't chased down why yet. But, here's my setup:

That is, no_proxy=localhost,<IP_ADDRESS>,::1,.service.skc.name,.local.skc.name,.cluster.local,<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/12,<IP_ADDRESS>/16.
Regardless, health checks crash loop:

This is in registry.k8s.io/nfd/node-feature-discovery:v0.14.2 that runs as part of the nvidia gpu-operator.


Error in loops.md in documentation

Bicep version
Bicep CLI version 0.1.37-alpha (f88c6d95ad)
Describe the bug
The documentation is incorrect
variables subnets = [
  {
    name: 'api'
    subnetPrefix = '<IP_ADDRESS>/24'
  }
  {
    name: 'worker'
    subnetPrefix: '<IP_ADDRESS>/24'
  }
]

Should be
var subnets = [
  {
    name: 'api'
    subnetPrefix: '<IP_ADDRESS>/24'
  }
  {
    name: 'worker'
    subnetPrefix: '<IP_ADDRESS>/24'
  }
]

To Reproduce
Steps to reproduce the behavior:
Additional context
Add any other context about the problem here.

Thanks for reporting this. We'll fix it.


Table alignment in Markdown not working

Version: 1.45.0-insider
Commit: 6e9a34c0de4181a99f11e106733ee3e8c9db79f1
Date: 2020-04-16T05:41:45.257Z
Electron: 7.2.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

Steps to Reproduce:

Use setDecorations API in extension
Set hoverMessage as below

new MarkdownString(`
| A    | B     |
|-----:|-------|
|    a | b     |
| aaaa | bbbbb |
`)

The a in the first row should be aligned to right.
I remember it was working in some old versions last year. But not sure exactly when this broke.

Simpler repro: hover over this:
/**
 * | A    | B     |
 * |-----:|-------|
 * |    a | b     |
 * | aaaa | bbbbb |
 */
function test() {}

Now it's consistent with GitHub.

A
B

a
b

aaaa
bbbbb

@mjbvz fyi, the issue is align is ignored for th and `td. https://github.com/jupyterlab/jupyterlab/issues/3180 and https://github.com/jupyterlab/jupyterlab/issues/1812.

Thanks for the quick fix!

np, btw wenyan is very interesting, I'd be interested in helping with editor support. Let me know if I can help :p


Add default extras

@josephabrahams What extras do you want by default in the project? We already have a few of these, but I'm looking at what's included in https://github.com/h5bp/html5-boilerplate/tree/master/dist as a reference. I'm thinking:

humans.txt
404.html
favicon.ico
other favicons per https://github.com/audreyr/favicon-cheat-sheet#optional-but-encouraged
robots.txt

Something I'm struggling with: Should we remove all the references to ISL from these repos (i.e. humans.txt, etc.) and add that stuff manually? If we're aiming for these to be adopted outside of ISL then perhaps they should be a bit more generic. Thoughts? @jcarbaugh @jray

Yea depends on our end goal. If we're developing FOR open source and just using this stuff then yep, take it out. On the other hand if we're just developing ISL stuff in the open, then it's fine to keep in and other folks can change it.

I'm going to add a favicon.ico in the root of the build by default in order to stop getting 404's on page load.

I think these project templates need to be specific to our needs so we should be developing in the open, not developing for general use. mo repos can serve as examples, not necessarily usable by others without modification.

Related discussion at https://github.com/istrategylabs/mo-static/pull/23#issuecomment-194421555

I added humans.txt, robots.txt, and updated the favicons.


Hooks in resize mode

Hi there, first of all thanks for the plugin, it's great.
Could you add hooks when entering and exiting the resize mode.

What's the use case?

In my case what I'm trying to do is to integrate it with this plugin so it would be useful to pass a function to be executed when exiting the resize mode.

I've added the functionality and made a pull request, I'd appreciate if you could check it out.


[Feature Request] Unable to use CDN that doesn't support HEAD requests

Context
I'm using an internal basic Git based CDN and it currently doesn't support HEAD requests. This makes it impossible to run storybook tests against the hosted versions.
https://github.com/storybookjs/test-runner/blob/1ba363fb1d8bc26cb3eebb84fac2cf2138406e5f/src/test-storybook.ts#L186
Proposed Solution
I would like to be able to skip the server check using a CLI flag such as --skip-server-check
Alternate Solution
Alternatively, adding a configuration flag for the type of request to make to ensure the server is running, such as --req-method=GET

I understand the reasoning behind choosing to use a HEAD request, but to reduce these kinds of issues in the future I believe it makes sense to just switch this to a GET request.
There isn't any side-effects from this, since fetch buffers the response body and since we never read from it we are just returned the data we need to perform the status check.
(async () => {
    console.time('HEAD');
    const head = await fetch('https://raw.githubusercontent.com/json-iterator/test-data/master/large-file.json', {
        method: 'HEAD',
    });
    console.log(head.status);
    console.timeEnd('HEAD');

    console.time('GET');
    const get = await fetch('https://raw.githubusercontent.com/json-iterator/test-data/master/large-file.json');
    console.log(get.status);
    console.timeEnd('GET');
})();

200
HEAD: 104.648ms
200
GET: 93.117ms

In my tests the GET request usually resolve negligibly faster, though the primary benefit is just using the most basic request method and avoiding these types of issues being brought up in the future.


Add support for Options's description

As per the title, I'd like to have the ability to set a description for the Option object.

For providing HTML-like experience, jsx-slack has provided components based on context. It means <Option> is for <Select> and similar interactive components, that description are not used in them.
To generate Option object with description, try using <Checkbox> or <RadioButton> instead.
import { Checkbox } from 'jsx-slack'

console.log(
  <Checkbox value="value" description="description">text</Checkbox>
)

{
  "text": {
    "type": "mrkdwn",
    "text": "text",
    "verbatim": true
  },
  "description": {
    "type": "mrkdwn",
    "text": "description",
    "verbatim": true
  },
  "value": "value"
}

See this example on REPL...

Oh, it's first time to know that select components allow description field in option object.


Diagnosing problems with dmdtask -- metadata mismatch?

Staff have detected an issue where sometimes the wrong DMD XML is stored.
We haven't yet been able to get sample data that fails.

https://github.com/crkn-rcdr/cihm-metadatabus/issues/48 was opened to make notes about the latest testing.


New Extension: Gitpod 🍊

Raycast Extension for Gitpod
A BLAZINGLY FAST way to work with Gitpod 🍊

Currently Supported Features

"Open in Gitpod" -> Experience the power of Gitpod Contexts!

Find the repository from Github (you can even see if the repo is Gitpodified...it glows up ✨)

You can now see and find all the branches, PRs and Issues which you can directly open in Gitpod with a single Keypress!

You can filter and search further using the following tags

/b for branch
/p for PRs
/i for Issues
/me for anything and everything related to

eg. /me /p would refer to your Pull Requests in a particular repository!

Open using "CMD + Enter" to open the selected Branch, PR or Issue directly on Gitpod

"Recent Repositories" -> Faster Access of Recent Workspaces from menubar

By default you can see the latest visited Repository to start with!

Is there no way to use the OAuth flow that would make the initial setup a bit easier?

Hey @pernielsentikaer, there is indeed the OAuth flow way to do the above as well and we've already implemented it as well!
But the reason we've not enabled it "FOR NOW" is that in the future releases of the extension we'd be removing GitHub as a primary dependancy for our extension!
It's just that the OAuth flow is not yet supported by @gitpod (the APIs are still in beta and will be integrated by the next release) and supports only API tokens currently, and hence to maintain consistency FOR NOW we've decided to keep entering "API tokens" for both "Gitpod and GitHub"!
Hope you'd understand, thank you so much....we'll certainly change it to only oAuth in the future for GitHub 🧡

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

Hey @pernielsentikaer, would love to have your review...we've made the necessary changes and explained the others, thank you 😄

Hi 👋
Thanks for the updates 🔥
Do you know why it takes so long for the searchbar placeholder text to be updated here
Raycast-wYYT0upd.mp4

Ohhh I understood what's going on, during the previous changes to removing /me..... from the navigationTitle, we missed a small part on updating the placeholder in one part! Will make the changes asap, would love to know if there's some more feedback you have for us so that we could make all the required changes as soon as possible! Thank you!

Hi 👋
Thanks for the updates 🔥
Do you know why it takes so long for the searchbar placeholder text to be updated here
Raycast-wYYT0upd.mp4

Hey @pernielsentikaer, we've made the changes...could you please check, thank you!

Hi 👋
Thanks for the updates 🔥
Do you know why it takes so long for the searchbar placeholder text to be updated here

Hey @pernielsentikaer we've made the changes, please let us know if we need to make any more changes, it has been some time and we'd love if we could this into the store, thank you 😄

Hi 👋
Approved; let's 🚢 it!

Yess let's go!!


Latest Chart version release not in sync with the actual github release

The latest Chart release number is 1.14.3 however, the latest release packed on github is 1.14.1. This breaks the coredns helm deployment at the moment as the patch for the cluster role is not present.

Looks like there is something wrong with automatic releases


Update 2018 blog index

Currently missing two latest posts, Launch of Aragon Nest and Introducing aragonOS 3.0 alpha, the new operating system for protocols and DApps.

@john-light I have now updated the Publishing process with the additional subtask of updating blog index.


[controls] Vive controls forward/backward movement bug?

Hi!
I am testing universal-controls here at this Networked A-Frame page:
https://sugar-sponge.glitch.me
wasd and HTC Vive and Daydream controls all work, thank you!
However, the HTC Vive controller forward and backward motion seems reversed:

pushing forward on the Vive controller (towards top of controller) moves camera back
pushing backward on the Vive controller (towards bottom of controller) moves camera forward

The similar forward/backward motions on the Daydream trackpad do the opposite (and more-seemingly correct) thing for me.
Thank you!
Evelyn

I was able to replicate this using an oculus on steam where the controls appeared to be vive controls.

This is a really old issue. Please test again with aframe master and latest aframe-extras master and create a new issue if you still have an issue. Closing it.


Change default serialization format to Ion binary

Description of changes:
Change default serialization format to Ion binary, which aligns with the design and the assumption in driver serialization library
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #58 (d9c836c) into main (7ffb491) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   94.85%   94.84%   -0.01%
==========================================
  Files          38       38
  Lines         933      932       -1
  Branches      133      133
==========================================
- Hits          885      884       -1
  Misses         30       30
  Partials       18       18

Flag
Coverage Δ

unittests
94.84% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

Amazon.IonObjectMapper/IonSerializer.cs
92.40% <ø> (-0.04%)
:arrow_down:

Amazon.IonObjectMapper/IonSerializationOptions.cs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffb491...d9c836c. Read the comment docs.


Add code table overwriting to advanced_usage.ipynb

@johanvdw I'm not confident that the addition to the jupyter notebook is ok ... It worked, but I'm not sure about the correct rendering.

Are you sure you want to change this:
https://github.com/inbo/niche_vlaanderen/pull/165/files#diff-dec2aad1bbbac876e838452e24def595R209
In general you should try doing  (from the "kernel" menu in jupyter:
Restart and run all cells to check if everything works as expected, and
then Restart and clear all results before committing. That way all output
is removed from the file and built again when making the documentation.
On Mon, May 7, 2018 at 5:04 PM, DriesAdriaens<EMAIL_ADDRESS>wrote:

@johanvdw https://github.com/johanvdw I'm not confident that the
addition to the jupyter notebook is ok ... It worked, but I'm not sure
about the correct rendering.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/inbo/niche_vlaanderen/pull/165#issuecomment-387094880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1AUi2YdF97pEzw-Q0NYMnAGOpQVqKhks5twGJ7gaJpZM4T1ID6
.

OK, I will try again then. This pull request can then be closed?


Don't log successful open substreams

This happens every ping so it's quite spammy

Closing in favour of #2456


Fix UIRefreshControl frame

It really is too low, not just on @florianschmidt1994's device.

Not doing anything with the frame or custom stuff, all this is built-in. Will keep it in mind, but apparently this is how it's supposed to be^^


Documentation of the actual build steps to generate the test runner executable

I would like to be able to compile, link and run the test in a ceedling based project after one ran the command
ceedling test:test_bla.c

I had a look at ceedlings output when using verbosity[4], but the commands there do not generate object files, as all commands in that files use -E (preprocess only) and none of the commands was related to the test runner source (test_bla_runner.c).
So one question is: Is there some hidden option that shows what ceedling is actually doing? This would be sufficient for me to know.
The workflow I would like to achieve can then look something like that:
ceedling test:test_bla.c
# ceedling magic happens
# now I can compile the tests by hand on the command line
gcc -c -I"include/this" -I"include/that" -DFOO test_bla.c -o test_bla.o
gcc -c -I"include/this" -I"include/that" -DFOO test_bla_runner.c -o test_bla_runner.o
gcc test_bla.o test_bla_runner.o -otest_bla_runner
./test_bla_runner

Any tips on how to achieve this are very welcome. Or links in the source so that I can fiddle how ceedling links the test executable.

Hi.
If you'd like to see what ceedling is doing at any time, just change the verbosity... for example, show all:
ceedling verbosity[4] clobber test:bla

Wow - THAT was a super fast answer!
I did that (without the clobber part, but I did a clean build). But I only found calls to gcc -E. There were no gcc commands that indicated that files were actually compiled or linked.

Curious. Running a test definitely requires a number of files to be compiled and linked, and then the exe run. ;)
Is something failing along the way, or is it claiming it did it?
The -E calls are likely because your project file has enabled preprocessing of files. This is optional... but it's just an extra step. It shouldn't take the place of any of the other steps.

Yes, I enabled preprocessing.
I am on the wrong machine to try it now, but I will do right away tomorrow morning again! Maybe I have overseen something and not built as clean as I thought.
But as far as I understand, I should definitely see the commands with all information (falgs etc.) I need, to run these commands afterwards again.
Thanks for your prompt replies, I will give feedback as early as possible!

Awesome. Good luck. Let us know if anything seems amiss.

The good thing is
ceedling verbosity[4] clobber test:bla

solved the issue, and I saw all the compilation and link commands etc.
However the strange thing is, I did - or at least I thought I did - a clean build:

I did a rm -rf *bla* in the unit test directory. All files related to the test were gone after the rm thing.
No recompliation etc happend when I ran afterwards ceedling verbosity[4] test:bla , but preprocessing did happen. The logs clearly showed that.

After all that, running ceedling verbosity[4] clobber test:bla, it did compile etc.
I did not have the time to test it more in detail, but I will and report back.
In general: Does my description make any sense to you?

A question, that is related to the overall task I would like to achieve:
When running these three tests through ceedling (assumption: all tests include the same mock, e.g., MockThis.h):
ceedling test:test_bla.c            # step 1
ceedling test:test_foo.c            # step 2
ceedling test:test_bar.c            # step 3

Question: Is it safe to assume, that ceedlings mock generator generates the exact same mock for all three tests (or does not regenerate them if they exist), so that I can rely on:

after step 1: MockThis.h and MockThis.c are generated
after step 2: MockThis.h and MockThis.c are identical to after step 1
after step 3: MockThis.h and MockThis.c are identical to after step 1 (and therefore to after step 2)

My concern is the following: When I do
ceedling test:test_bla.c            # step 1
ceedling test:test_foo.c            # step 2
ceedling test:test_bar.c            # step 3
./recompile_and_run_tests.sh        # step 4

do the compilation and link steps I will do in step 4 see the same inputs as they did in step 1, step 2, step 3, or might it have happened that step 1 and step 3 have seen different mocks for a function xyz?

CMock will only generate the mock the first time, unless one of the following is true:

The header that was used to generate the mock has since changed.
You've told ceedling to clobber or otherwise removed the mocks.
You have custom compilation turned on for certain tests. For example, you have a test_bar.yml file which specifies new #define settings for compiling test_bar.c.

If none of the above are true (which is the case for your example above), you can rely on ceedling only telling cmock to generate that mock once, and then using it always. Additionally, it won't recompile the object files for any files that already exist either.
Also, you can do this all in one step for better performance:
ceedling test:blah test:foo test:bar
The "better performance" gains in this case are because it doesn't have to trace all files and the dependencies 3 times... it only needs to do that the first time. In EITHER case, it should only generate the files its needs that haven't changed.

Ok, perfect, that was what I actually hoped for.
Thanks for the detailed answers and your time!

No problem!


Functional Tests Refactor

Now that we have several scenarios, decided to align all of them with a single structure and use common methods.
Some decisions:

Use json strings for request and response. (@itye-msft your hunch was right). Both easy copy from postman, and no need to transform the payload to python dict (null -> None, true > True).
Place the jsons in the scenario, for easy read-in-one-go, and compare the request and the response easily. This has the assumption that our payloads should be fairly small, and that we focus on the API layer, where complex scenarios will be added to the service integration test. @shiranr I left some of your tests reading from files, I want your approval to transform them.
Added json strings equality helper methods so that we won't have to sort lists and objects in the scenarios.

@navalev @omri374 I've committed another change moving some of the scenarios (that were jsons in the first place) from functional to anonymizer integrations. @shiranr those are yours do you agree with moving?


Support TLS on Sentinel and Cluster Client

Add TLS config to sentinel and cluster client options

Closing since does not look good as is. Please reopen with fixes if you are still interested.


Don't let widgets to be added when not having geometries on the data

rel with: https://github.com/CartoDB/cartodb/issues/9546

could you take care of it @nobuti please?
Same message as we have for style or data panel could do the trick 💋


Fix installation with git via pip

Fixes the bug in this issue

@pseudo-rnd-thoughts  I'm a little confused, could you emphasize further? The reason I had to wrap this in a try/except is because when the project is installed via pip install *.whl or pip install git+... , the retro/VERSION file isnt included in the install, which was the cause of the original bug

To my understanding, the file is rather retro/../VERSION, i.e., just VERSION in the root folder
We might need to update https://github.com/Farama-Foundation/stable-retro/blob/ee019a6d58f43cefdea3f7021553572625b3c736/setup.py#L104 to VERSION rather than VERSION.txt but this seems unrelated

Trying the colab, I found that none of the package data was included, therefore, I think there is an issue with that.
I found the workaround was to put the VERSION file in retro only.
Previously, the project had two version files however to me this seems like a stupid idea that can cause issues and is easier to have a single file for this.

I agree, two version files is a bad idea. I can implement that workaround later today

Issue has been fixed. @pseudo-rnd-thoughts please take another look when you have a free second, thank you!


revert: "feat(portal): Add 'temp account' feature for launch HN"

Reverts firezone/firezone#6153

Just tried this locally. If we keep the temp accounts in the DB and someone tries to access their temp account it will result in a crash, because it's trying to use a provider that doesn't exist. Not sure if that's a concern, but wanted to give a heads up.

Yeah we should probably purge those when this ships. Is there an easy way to query them?

Is there an easy way to query them?

Yep.  Just shared a doc with you that has all the temp account IDs/names/slugs.


Identify which attributes need to be included

@emjohnst  - I think this was about hiding some values in the report view. Now that we're limiting to the details page this should be unnecessary. Moving to QA - if you agree, please move to done.

@bferguso yes, or this ticket might be a duplicate of #645 I have attached that ticket to the epic now and will close this ticket.


Imported function PATHS.strip_slash() missing

Exported function strip_slash() renamed to stripSlash() causing twigjs compilation command fail.

The compile doesnt work without this fix, but it doesn't look like it's been merged into the build... Any ideas how to get this fix into the release?

The compile doesnt work without this fix, but it doesn't look like it's been merged into the build... Any ideas how to get this fix into the release?

I opted to switch to PUG


Project_name is empty in controls output

Should reflect the project that the blanks/controls refer to.

@ackermag I might need clarification on where this is occurring in the user interface.

To clarify, this is the 16S workflow's prep-information-file download (controls output file - 1 file of 2).

Confirmed Project_name column is empty in controls output. @ackermag says we can pull project_name 'Palmer_11479' from the sample_plate column ('Palmer_11479_Plate_1') for now, if need be (ignoring case where two projects are on the same plate.) Note samples file does have a populated Project name column ('Palmer GWAS, SG_B0014')

The code strongly suggests that study.study_alias is blank for controls:
study.study_alias AS project_name
result['project_name'] isn't touched in any way, until the column name is changed to 'Project_name'. I thought this was worth making a note of. At least for the short term, we'll probably have to copy and modify the value in the 'sample_plate' column.

This issue and https://github.com/jdereus/labman/issues/483 are not the same, but they are definitely kissing cousins.  Please keep both in mind when attempting a fix.

See #483 for question

When solving this issue, we may want to determine if it intersects with/is affected by #387 "Add new was_pooled field to amplicon prep file for blanks" ... e.g., does it make sense to assign blanks/controls to a particular project if they weren't ever actually pooled (and thus sequenced)?  My understanding is that in the amplicon pipeline, usually only 2 blanks are pooled; see below.
https://github.com/jdereus/labman/blob/645c798e0094e9962973c2d111c4860b1e8e5b23/labcontrol/gui/handlers/process_handlers/pooling_process.py#L238-L243

@AmandaBirmingham Is this a question for @ackermag? My thought was that every control would be part of a project, but you're saying that if the control/blank wasn't plated, you'd prefer for it to remain blank in the controls prep sheet?

@charles-cowart Given today's discussion, that will not be the case: ALL controls on a plate will get the study for that plate, and labcontrol will not create output for any case where a plate has >1 study on it (to avoid creating misleading output).  I will modify the issues to reflect our conclusions either tonight or tomorrow morning.


Add PodPresetBinding as a distinct API resource to integrate OSB bindings with PodPreset

Specific action item for #994
There should a resource distinct from Binding (or ServiceBinding, or whatever it's called next week) that integrates the OSB binding results with a PodPreset according to the lifecycle of the binding.  Rough sketch of this resource:
type PodPresetBinding struct {
	metav1.TypeMeta
	metav1.ObjectMeta

	Spec   PodPresetBindingSpec
	Status PodPresetBindingStatus
}

type PodPresetBindingSpec struct {
	BindingRef metav1.LocalObjectReference

	// other information about the PodPreset to create goes here
}

type PodPresetBindingStatus struct {
	// looks like the status type we are used to
}

This should be in a separate API group from the servicecatalog API group.  Other integrations that we choose to build in this repo (if any; I expect that there may be at least one or two more) should be in their own API groups.
There should be a controller backing this resource that hooks into the lifecycle of the Binding referenced in the spec:

When the Binding is ready, the controller should create the PodPreset
When the Binding is deleted, the PodPresetBinding should be deleted by the garbage collector and finalized by the controller

After this change is made, we should remove the AlphaPodPresetTemplate field in the Binding resource after a couple releases (or whatever timeframe we agree to; definitely should be removed before beta).

@pmorie looks reasonable. 3 questions:

Why put these resources into a new API group?
Follow-on from (1), why create a new controller to manage these?
Will these resources still be serviced by the same svc-catalog API server?

I'm removing the 0.1.0 label because all of our discussion so far has indicated that the initial beta release will not have any PodPreset integration.

PodPresetBinding resource (or similar) could provide a mapping between raw JSON credentials object and a secret with injectable environment variables. Credentials object is not necessarily a flat map[string]string, and thus could require data transformation. See https://github.com/kubernetes-incubator/service-catalog/issues/1109 for the details.


Use generics in RunGetManyQueryForSchema

Description
After switching to Go 1.18 we can use generics. This will allow us to not parse output from database to [][]byte and then unmarshal it to []storage.* but immediately parse to []storage.*. So no intermediate slice will be created and we can save up some memory and allocations.


Arrays: Left Rotation has a timeout error.

The challenge results in a timeout when an extremely large vector and rotation count is used.

This was fixed by changing the way the positions of the items in the new vector was calculated. Instead of looping over the vector 'd' times, we calculate the index offset and set the value in the new vector at the calculated index.


Camel - Endpoint Browse

@mmelko This one is coupled with #181. Please have a look at this next.


Option to keep or not the textual translations

As most apps aren't translated, I found odd the mixed language on apps, so I thought it would be useful to have a locale with formatting but no translation. this way the apps language are all in english, but the format for numbers, dates, etc are in my locale.
As forum post: http://forum.espruino.com/conversations/371915/#comment16353541

Thanks! Just replied in the forum post above about this. I totally agree with it, but longer term I'll be removing them anyway so I'm not sure if it'll be confusing for folks to put the setting in and then just take it out later

Just a note that translations are now working in https://github.com/espruino/BangleApps/issues/1311
So I think once everyone seems ok with that, the next step will be to pull the translations out of locale completely.

Translations are in - but actually I'll pull this in now, and change the default to false


Feature/cert manager

Cert Manager Installation

Hi @alizard0, yes, but last week I mentioned that we will use Vault for two reasons:

We keep everything internal (no communication to Let's encrypt)
Provides CRL endpoint

I will push the code to this PR by end of the week.


There were a lots of directories named instance-*** and after stopping the fuzzer and deleting them it worked again.
commit 169724fe
go version 1.13.8

this is the  syz-manager config
{
    "target": "darwin/amd64",
    "http": "<IP_ADDRESS>:56741",
    "sshkey": "/Users/user/.ssh/id_macos115",
    "workdir": "/Users/user/sk_darwin/",
    "kernel_obj": "/Users/user/115/obj/",
    "kernel_src": "/Users/user/115/src/",
    "syzkaller": "/Users/user/go/src/github.com/google/syzkaller",
    "procs": 2,
    "type": "qemu",
    "cover": true,
    "image": "/Users/user/115/macos_11_5.qcow",
    "vm": {
        "count": 2,
        "cpu": 2,
        "mem": 4096,
        "efi_code_device": "/usr/local/share/OVMF/OVMF_CODE.fd",
        "efi_vars_device": "/usr/local/share/OVMF/OVMF_VARS.fd",
        "apple_smc_osk": "XXX"
    }
}

When it happed I stopped the fuzzer and deleted all the leftover directories sk_darwin and started the fuzzer again.
The bug happened after a few days of fuzzing, so it hasn't happened yet.


Typo: s/artefact/artifact/

Hi, I just noticed $sbj in many places across the repo. It's easy to auto-replace to fix it so I'll let somebody else send a PR.

Thanks for raising this 👍


:sparkles:Added initial validation Webhook for all the resources

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #13

cc: @alexander-demichev

@JoelSpeed what do you mean by dependency tie? The pattern looks similar to other CAPI repositories.

All the review comments are being addressed in the latest commit and the PR is ready for review.

what do you mean by dependency tie? The pattern looks similar to other CAPI repositories.

Yes, CAPI suffers from this problem across the board and it has been brought up in community calls before. Basically, to import the API package, I shouldn't have to import any dependencies apart from possibly some imported types from the apimachinery repo. But, because we have all this extra code in here for webhooks, we now have to import a whole bunch of controller-runtime to just import the API types. This is undesirable as it makes dependency management harder for projects that are building on top of these API types.
As an alternative, we can create separate wrappers in a different directory and make those the sources of the webhooks, rather than including all this extra code in our API repo.

what do you mean by dependency tie? The pattern looks similar to other CAPI repositories.

Yes, CAPI suffers from this problem across the board and it has been brought up in community calls before. Basically, to import the API package, I shouldn't have to import any dependencies apart from possibly some imported types from the apimachinery repo. But, because we have all this extra code in here for webhooks, we now have to import a whole bunch of controller-runtime to just import the API types. This is undesirable as it makes dependency management harder for projects that are building on top of these API types.
As an alternative, we can create separate wrappers in a different directory and make those the sources of the webhooks, rather than including all this extra code in our API repo.

If you could provide some hint on the implementation, I would like to give a try

I was thinking in a separate package, you can create a struct like below which then implements the interface of the validator.
type BootstrapProviderWebhook struct {
  BootstrapProvider *operatorv1.BootstrapProvider
}

With the setup with manager, you need need to give it the inner bootstrap provider I think
func (r *BootstrapProviderWebhook) SetupWebhookWithManager(mgr ctrl.Manager) error {
	return ctrl.NewWebhookManagedBy(mgr).
		For(r.BootstrapProvider).
		Complete()
}

I haven't tested this but it looks like it might work from the code

@JoelSpeed @alexander-demichev Created webhooks and moved it to a separate directory. Please take a look when you get a chance

Review comments are addressed in new commit and the PR is ready for Review.

/lgtm

This looks good. @Karthik-K-N we have to install cert-manager in e2e tests before operator in order to make them work https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/e2e_suite_test.go#L227

sure, Will try to update

@alexander-demichev All the tests are passed, Could you please take a look.


Write a script to import spreadsheet data into the system for use during the dry run

Since Lisa will be picking up the work of the person who came before her, we'll want to give her a little bit of seed data so she can have a more realistic experience of what using the system is like in a live-fire situation.
Let's plan on writing some kind of script (and checking it into version control so we can iterate on it as we continue to roll out) that will let us take a spreadsheet and dump it into the system.

@colinxfleming @lwaldsc if you don't have time to get to the script I'll help input the data by hand.

@NerdyGirl537 It's a problem we're going to have a few times in the next few months, so I want to make sure we make some forward progress on it. If you're coming tomorrow I might stick you with a dev and have you pair on it to get it going.

Untagging deploy since this has the potential to be a very messy operation, sad to say.

I'm marking this backlog for two reasons:

it's not necessary for release to DC
right now I think we should be focusing on features that bring CM happiness.

Overtaken by events, now. Closing.


Jump to solution

As a user, I should have an easy way to get to the accepted reply so that I can quickly find the most likely solution to my issue.

What I thought we could do is something like Laracasts and show the accepted reply on top of the other ones.

The only thing I find with that type of layout is that you sometimes loose the context I would be more for the have a  "go to accepted solution" link

The only thing I find with that type of layout is that you sometimes loose the context I would be more for the have a "go to accepted solution" link

Agree with you. I prefer to see the progression of the replies and how the final answer / solution was reached.


enhancement/read-only-on-get

@mandrigin running this code seems to run into a deadlock at one point, need to investigate further.

It’s unlikely there, this code is pretty straightforward, but if you call Get or Set inside Map, that might bring trouble.


Nested portals have really janky collision

Trying to enter a nested portal seems to shunt you back to the overworld under the floor.
https://cdn.discordapp.com/attachments/303638037844197376/942522455988240394/wha_Trim.mp4

Immptl does not yet have two-layer indirect cross portal collision.


Update isOpenPR and related detections

From
exists('#partial-discussion-header [title="Status: Open"], #partial-discussion-header [title="Status: Draft"]')

to
exists('.gh-header-meta [title$="Open"], .gh-header-meta [title$="Draft"]'),

but more likely a mix of the 2.
Note: let's not use :is yet, it'd be a breaking change.

Curios why?

You mean about :is? Using it increases the previous minimum browser support.

No ⬇

From
exists('#partial-discussion-header [title="Status: Open"], #partial-discussion-header [title="Status: Draft"]')

to
exists('.gh-header-meta [title$="Open"], .gh-header-meta [title$="Draft"]'),

I assumed that RG’s selector is more up to date and that this one was outdated. I guess not.


Adding convert_tz and datetime functions to SQL and PPL

Description
PR adds support for convert_tz and Datetime for PPL and SQL languages.
convert_tz
Syntax for convert_tz:
convert_tz(datetime string, from timezone, to timezone)
It converts the datetime string from the from timezone to the to timezone. Converts from negative to positive timezone, from positive to negative, from positive to positive or negative to negative time zones. Works across year roll-over and leap years.
Example:
opensearchsql> SELECT convert_tz('2021-05-12 00:00:00','-12:00','+13:00');
fetched rows / total rows = 1/1
+-------------------------------------------------------+
| convert_tz('2021-05-12 00:00:00','-12:00','+13:00')   |
|-------------------------------------------------------|
| 2021-05-13 01:00:00                                   |
+-------------------------------------------------------+

opensearchsql> SELECT convert_tz('2021-05-12 12:34:56','-00:00','+01:00');
fetched rows / total rows = 1/1
+-------------------------------------------------------+
| convert_tz('2021-05-12 12:34:56','-00:00','+01:00')   |
|-------------------------------------------------------|
| 2021-05-12 13:34:56                                   |
+-------------------------------------------------------+

nulls
It returns null for time zones outside of the allowed range (allow range is -12:00 -> +14:00)
opensearchsql> SELECT convert_tz('2021-05-12 12:34:56','-00:00','+15:00');
fetched rows / total rows = 1/1
+-------------------------------------------------------+
| convert_tz('2021-05-12 12:34:56','-00:00','+15:00')   |
|-------------------------------------------------------|
| null                                                  |
+-------------------------------------------------------+

opensearchsql> SELECT convert_tz('2021-05-12 12:34:56','-13:00','+10:00');
fetched rows / total rows = 1/1
+-------------------------------------------------------+
| convert_tz('2021-05-12 12:34:56','-13:00','+10:00')   |
|-------------------------------------------------------|
| null                                                  |
+-------------------------------------------------------+

Leap year
opensearchsql> SELECT convert_tz('2005-02-28 20:00:00','-10:00','+10:00');
fetched rows / total rows = 1/1
+-------------------------------------------------------+
| convert_tz('2005-02-28 20:00:00','-10:00','+10:00')   |
|-------------------------------------------------------|
| 2005-03-01 16:00:00                                   |
+-------------------------------------------------------+

opensearchsql> SELECT convert_tz('2004-02-28 20:00:00','-10:00','+10:00');
fetched rows / total rows = 1/1
+-------------------------------------------------------+
| convert_tz('2004-02-28 20:00:00','-10:00','+10:00')   |
|-------------------------------------------------------|
| 2004-02-29 16:00:00                                   |
+-------------------------------------------------------+

DateTime
DATETIME(timestamp_expression [, time_zone])
fetched rows / total rows = 1/1
+---------------------------------------------------+
| DATETIME('2008-12-25 05:30:00-05:00', '+05:00')   |
|---------------------------------------------------|
| 2008-12-25 15:30:00                               |
+---------------------------------------------------+

opensearchsql> SELECT DATETIME('2008-12-25 05:30:00', '+05:00');
fetched rows / total rows = 1/1
+---------------------------------------------+
| DATETIME('2008-12-25 05:30:00', '+05:00')   |
|---------------------------------------------|
| 2008-12-25 10:30:00                         |
+---------------------------------------------+

opensearchsql> SELECT DATETIME('2008-12-25 05:30:00+10:00');
fetched rows / total rows = 1/1
+-----------------------------------------+
| DATETIME('2008-12-25 05:30:00+10:00')   |
|-----------------------------------------|
| 2008-12-25 05:30:00                     |
+-----------------------------------------+

opensearchsql> SELECT DATETIME('2008-12-25 05:30:00');
fetched rows / total rows = 1/1
+-----------------------------------+
| DATETIME('2008-12-25 05:30:00')   |
|-----------------------------------|
| 2008-12-25 05:30:00               |
+-----------------------------------+

Issues Resolved
#703
#46
Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented.

[x] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add tests with non-round-hour-offset timzones, like Asia/Katmandu +05:45, Asia/Kabul +04:30, Australia/Broken_Hill +09:30.
And a test where TZ shift is exactly 24 hours - you should get the same time, but on another date.
Non existing TZ

Other optional tests:

Switch between winter/summer timezones when they have shift
Switch from a TZ to the same TZ

Please, keep in mind, we don't test java, but we should ensure that user will get a valid result or a clear error message of incorrect input/limitation.

opensearchsql> SELECT convert_tz('2021-02-30 12:34:56','UTC','+03:00');
fetched rows / total rows = 1/1
+----------------------------------------------------+
| convert_tz('2021-02-30 12:34:56','UTC','+03:00')   |
|----------------------------------------------------|
| 2021-02-28 15:34:56                                |
+----------------------------------------------------+
opensearchsql> SELECT DATETIME('2021-02-30 12:34:56');
fetched rows / total rows = 1/1
+-----------------------------------+
| DATETIME('2021-02-30 12:34:56')   |
|-----------------------------------|
| 2021-02-28 12:34:56               |
+-----------------------------------+

Queries on Feb 30 don't fail. A bug?

@MitchellGale-BitQuill looks good to me.
Andrew made lots of good suggestions, I hope you'll consider them as well before merging this PR.

lgtm @MitchellGale-BitQuill !


Moved screenshot to another screenshot directory

Moved README screenshot images to a screenshots/ directory

@yadavsairaj  Thanks - can you also need to edit the README.md file and change the markdown links to point to the new Screenshot locations?

@yadavsairaj Also, to get Hacktoberfest credit, you probably don't want it merged until October 1st. :)

@yadavsairaj Thanks - can you also need to edit the README.md file and change the markdown links to point to the new Screenshot locations?

Ya sure! will do that.

The directory is not visible. So when i add markdown list it is not updating and it goes to a 404 page.
TRYING AGAIN.


Note: scikit-learn version compatibility

Hi,
I initially tried running TargetRNA3.py with the most up to data packages installed (numpy, pandas, etc.) and was getting an error with sklearn. I believe I was using version 1.5. I uninstalled this version and reinstalled sklearn version 1.3.2. After doing this my error went away, and the program ran to completion.
This is not so much an issue but more a suggestion that may help others with the same issue.

Good point. The model was developed (and saved with pickle) using an earlier version of sklearn and pickling/unpickling is not supported across different sklearn versions. As you note, sklearn version 1.3 works. The preferred solution is to use sklearn version 1.3. If you need to use sklearn version 1.5, as a work-around, a new version of the model has been added that can be used with sklearn version 1.5. The file is located at DataFiles/model.pickle.sklearn.1.5. Delete the local file DataFiles/model.pickle and rename DataFiles/model.pickle.sklearn.1.5 to be DataFiles/model.pickle.


[Feature Request] Lock metadata in Kavita

Metadata added to Kavita via the API is lost when a scan occurs, so would it be possible to have an option to lock the metadata?

I know this is extremely old, but if you're loosing metadata in-between scans, you have an issue with your setup and should reach out to Kavita support for help.


Remove project fields

The project field is underspecified – is it required to be a cloud project ID? Or just more metadata? Or both? It could be defined via the tags field, which would make it simpler to filter via ListTasks and might fit to #84 which uses tags for cloud/deployment  specific resource requests.

FWIW for a system we're putting on top of Cromwell we went with the tag route. We found that project was both too limiting as well as too generically named, as you note yourself.
We decided that systems sitting on top of Cromwell could set tags to their hearts content and work that way and that way clients could have whatever they want.

tl;dr that's a :+1: for tags instead of project

👍


event/goEvent.h:  No such file or directory

Please speak English (English only), this is the language everybody of us can speak and write.
Please take a moment to search that an issue doesn't already exist.
Please make sure Golang, GCC is installed correctly before installing RobotGo.

Please give all relevant information below for bug reports, incomplete details will be handled as an invalid report.

You MUST delete the content above including this line before posting, otherwise your issue will be invalid.

Robotgo version (or commit ref):
Go version:go version go1.17.3 windows/amd64
Gcc version:gcc version 12.2.0 (GCC)
Operating system and bit:Windows 10
Resolution:
Can you reproduce the bug at Examples:

[x] Yes (provide example code)
[ ] No
[ ] Not relevant

Provide example code:

package main

import (
	"github.com/go-vgo/robotgo"
)

func main() {
	robotgo.TypeStr("Hello World")
}

Log gist:

Description
PS D:\study\projects\src\test> go install<EMAIL_ADDRESS>PS D:\study\projects\src\test> go mod vendor
PS D:\study\projects\src\test> modvendor -copy="**/.c **/.h **/*.proto" -v
PS D:\study\projects\src\test> go run .\test.go
github.com/robotn/gohook
vendor\github.com\robotn\gohook\hook.go:22:10: fatal error: event/goEvent.h:
No such file or directory
22 | #include "event/goEvent.h"
|          ^~~~~~~~~~~~~~~~~
compilation terminated.
...

The copy directory was overwritten
直接拷贝目录进行覆盖

@caihy05 留个v or +我 huizhang_001

Closed because of duplicates. #174

不好意思才看到，问题还没解决吗，主要是go mod  vendor 缺了东西动态链接库文件没有拷贝，建议不执行go mod  vendor ，不需要vendor目录


getting some errors when install

Found an issue or bug? Tell me all about!
Describe the issue / bug.
#
getting err message when running install
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 69
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 15.6.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/brodyr/Documents/Sites/smart-lock/node_modules/nslog
gyp ERR! node -v v4.5.0
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok

How can I reproduce this problem?
Install vue-cli and scaffold boilerplate
npm install -g vue-cli
vue init simulatedgreg/electron-vue my-project
Install dependencies and run your app
cd my-project
npm install
npm run dev
If visual, provide a screenshot.
#
Tell me about your development environment.

Node version:  4.5.0
NPM version: 3.10.8
vue-cli version: (if necessary)
Operating System: macos

If you are looking to suggest an enhancement or feature, then feel free to remove everything above.

@brody182
You need to update your node version to 5 or higher (I'd recommend going to 6 for performance), as some dependencies and scripts rely on specific ES2015 features. If you need to have multiple version on node on hand I'd recommend using nvm.


feat: added add button for queries and js sections

Description
This PR added the add new button for queries and JS sections.
PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/29082
Media
https://github.com/appsmithorg/appsmith/assets/87797149/8bce820a-b383-4ca9-80af-03b3b49d6483
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing
How Has This Been Tested?

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features

Introduced new routing paths for API and queries editors, enhancing navigation within the app.
Added sections for JavaScript and queries in the pages pane, improving organization and accessibility.
Expanded analytics to include tracking for interactions within the pages pane.

Enhancements

Updated entity focus logic to support a new CURL plugin type, streamlining the development process for CURL-based APIs.
Refined the QueriesSection component to better handle the rendering of queries and APIs.

Bug Fixes

Corrected routing inconsistencies, ensuring a smoother user experience when navigating between editors.

Documentation

Updated internal documentation to reflect new routing paths and component structures.

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true


Why didn't you use home-assistant-js-websocket?

So not an issue with the code, but a question.
Home Assistant maintains home-assistant-js-websocket. A JS lib that is also used by the frontend and the Node-Red plugin to communicate with Home Assistant.
I see that you created your own for this plugin. Did you miss any functionality that you decided to go down this path?

It was not a real "decision", but more or less a night of coding - ignoring the possibility that something useful like this library may already exist. As this project is my first contact with javascript (as any experienced JS dev may notice), it started without use of modules - just as plain JavaScript.
I will take a look at the lib and consider to replace my hand-made solution. I will create an issue for that. Thanks for the hint :)


Ethical Hosting Provider

At the moment forum.solidproject.org and solidproject.org are hosted on AWS.
As discussed at the Solid Team meeting with minutes on https://www.w3.org/community/solid/wiki/Meetings#2020-07-15 the intention is to move towards a third party hosting provider that is:

equivalent in price to AWS
equivalent in service convenience to AWS
green energy
hosted legally and physically in Europe to be linked to GDPR without the involvement of "third countries"

Any objections to https://greenhost.net/products/hosting/?
Any suggestions to other solutions that have the criteria mentioned above?

I may have previously shared https://ethical.net/resources/?resource-category=web-hosting somewhere..
I use Infomaniak (CH based) for some of my personal sites. See their "actions for sustainable, responsible growth":
https://www.infomaniak.com/en/green-hosting . I don't know how they compare to AWS on resource/pricing but worth a look.

Yes, I found Green Host on ethical.net. Of the web hosting options listed on ethical.net it was the only one that fit all the criteria above.
Infomaniak looks like a good option and although not in Europe strictly it is on the adequate country listing https://ec.europa.eu/info/law/law-topic/data-protection/international-dimension-data-protection/adequacy-decisions_en

Any reason not to go with GreenHost?

What would it take to switch to GreenHost?
[] Open GreenHost account with MIT CC
[] Clone the setup onto GreenHost
[] Switch DNS
[] Wind down old service
I assume

As this issue is not yet resolved, I would like to introduce a few more suggestions to the discussion. These are derived from the Librehosters network, and have proven significantly stable, while grown out of grassroots, social and solidarity or cooperative environments. Some also run their own data centres, and all usually use renewable energy.
In declining order of a likely fit to your requirements, without knowing them furthen than the above:

Indiehosters
They have a long standing record of supporting the IndieWeb, hence the name, and communicating the subject of decentralisation to 'social innovation' communities. Founder Pierre Ozoux also organised the Labs Camp #3 at Mozilla 2015, where Michiel used to work, and Henry Story, Harry Halpin and Primavera di Phillipi were recurring guests over the years. They keep close ties with Framasoft and la Quadrature du Net and are at the core of the Commons movement in France (Assemblée Virtuelle, Remix the Commons). They are in course of migrating their containerised infrastructure into a fault-tolerant Kubernetes thing. Who doesn't remember elf Pavlik, who would also vouch for them.
LibreOps
The collective is very well rooted in Greece' activist-libertarian world, and engages against austerity and for the Commons. Their active contributors have participated in the open source sattelite SatNOGs programme, run the Athens hackerspace and also run data centres for research infrastructure with grnet.
Hostsharing eG
A cooperative that operates their own physical hardware with 20 years of experience in running in production. The members are actively bridging operations with civic-society initatives and participate in German discourses around 'Bits & Bäume' for sustainable use of technology. They are very well versed in finding a suitable Service Level Agreement and are known for their stability. Due to their size, they also provide multiple levels of virtualisation (shared hosting, KVM, containers) and have a larger team for support.
Wehost
Wehost colocate in a data centre with physical access in Amsterdam and are hence at a great spot for international connectivity.

This comment is primarily motivated by offering other GDPR-hosted organisations for choice, other than for-profit companies. Librehosters and Hostsharing are both registered as legal bodies and work in a cooperative, not-for-profit manner, and the others would eventually also be able to provide individual contracts/agreements.
My proposal is to support the social and solidarity economy wherever possible, even when only directing small financial amounts in its direction to support the idealists and counter culture. small is beautiful (:
All are very well experienced in hosting static websites and Discourse.


[MM-18819] Backport desktop notification changes to 5.9

Summary
Backport of functionality required by Desktop v4.3 to support Desktop Notifications. See ticket and PR below
Ticket Link
https://mattermost.atlassian.net/browse/MM-18819
https://github.com/mattermost/mattermost-webapp/pull/3718

@amyblais, this PR is for backport to v5.9


[SPARK-12424][ML] The implementation of ParamMap#filter is wrong.

ParamMap#filter uses mutable.Map#filterKeys. The return type of filterKey is collection.Map, not mutable.Map but the result is casted to mutable.Map using asInstanceOf so we get ClassCastException.
Also, the return type of Map#filterKeys is not Serializable. It's the issue of Scala (https://issues.scala-lang.org/browse/SI-6654).

Test build #48008 has started for PR 10381 at commit 95e3ff2.

LGTM except one minor comment.

Test build #48010 has started for PR 10381 at commit d3fc82d.

Test build #48008 has finished for PR 10381 at commit 95e3ff2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48008/
Test PASSed.

Test build #48010 has finished for PR 10381 at commit d3fc82d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48010/
Test PASSed.

Merged build finished. Test PASSed.

Test build #48019 has started for PR 10381 at commit 080e983.

Test build #48019 has finished for PR 10381 at commit 080e983.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48019/
Test PASSed.

cc: @mengxr @jkbradley

LGTM

Test build #48364 has started for PR 10381 at commit ea924e9.

Test build #48364 has finished for PR 10381 at commit ea924e9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48364/
Test PASSed.

Thanks @srowen , @BenFradet and @yanboliang for the review. I'm merging this into master and branch-1.6.


release: version "go1.4" does not match go tool version "go1.9beta1"

##### Building packages and commands for linux/amd64.
runtime/internal/sys
# runtime/internal/sys
compile: version "go1.4" does not match go tool version "go1.9beta1"

/cc @bradfitz

Also for linux/ppc64le:
compile: version "devel +47c7451 Thu Apr 7 20:41:55 2016 +0000" does not match go tool version "go1.9beta1"

I sent https://golang.org/cl/45778 before I noticed there was a bug number.

Interestingly enough, I have gotten this very same problem when installing go1.9 from source (not beta) on a machine which previously had go1.8.3. Is there a fix?

@GwynethLlewelyn this issue was marked closed a few months ago. Please open a new issue following the template provided. Thank you.

There is no need for opening a new issue — deleting all previous instances of Go and installing a fresh copy of 1.9 (and using the provided binaries) did the trick. The point of making a question four months after the issue was closed was simply because there are next to zero results on searching for this creepy error except for this thread on GitHub (the few other things found by Google do not apply); for future reference, it makes more sense to provide a solution/fix without needing to actually patch the Go lang code. There are other occasions when this issue appears: more specifically, when having multiple instances/installations of Go side-by-side, some libraries/packages might have been compiled with one version and not the other, and this error is common (even desirable!) in such occasions. There might be other, less intrusive ways of avoiding this error to appear besides deleting everything and starting from scratch, but at least, for future reference for poor Go developers in despair, there is at least one possibility they can explore without needing to wait for a future, patched release of Go to be launched...

We don't the issue tracker to ask questions. Please see https://golang.org/wiki/Questions for good places to ask. Thanks.


Comprehend

Issue #, if available:
fixed the destination bucket name issue for the sample documents
Description of changes:
use the outputBucketName in calling comprehendHelper, instead of using the bucketName variable,  which is not the same in the case of a sample document
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

let me redo this


Add ability to override felix.cfg with environment variables

This makes it much easier to configure felix when it's running under a docker container.

Isn't felix.cfg already obsolete now?  I thought it had been entirely replaced by the ../config parts of the etcd data model.

Oh, I see.  We're still using felix.cfg for settings involved in connecting to etcd in the first place.
I think that now leaves us with a rather confusing overall config model, and that we should consider streamlining it.  IIUC, we now have:

a hardcoded /etc/calico/felix.cfg (which could be problematic, e.g. if someone wanted a trial install under /usr/local) ...

... from which we read 3 values: EtcdPort, EtcdHost and FelixHostname

environment variables that may override those 3 values from felix.cfg

all other config read from Etcd.

(We also used to have a --config-file command line option, but I see that's been removed.)
I suggest the following.

We don't need felix.cfg anymore.  Let's just allow environment variables to override the coded defaults for EtcdPort, EtcdHost and FelixHostname.

It looks to me as though we might not need Felix-specific env vars for EtcdPort and EtcdHost.  https://coreos.com/docs/distributed-configuration/etcd-configuration/ documents an ETCD_ADDR variable.  AFAICS this is currently honoured by the etcd server (and proxy?), not by the etcd client library or by python-etcd; but I don't see why we couldn't use the same name and make Felix honour it.  (We could do that either at the Felix level, or by submitting a patch to python-etcd.)

If using the same name doesn't feel quite right, I think it would still be good to follow their convention of a single var specifying both host and port, instead of two separate vars.

Any Felix-specific env vars that we honour should definitely include 'FELIX' or 'CALICO'.

If you agree, that boils down to just 2 Felix-specific vars: FELIX_HOSTNAME and FELIX_ETCD_ADDR.  Or possibly 1 Felix-specific (FELIX_HOSTNAME) and 1 compatible honouring of ETCD_ADDR.

I don't think environment variables play nice with the OpenStack approach, which is all config-file based.  @plwhite @Lukasa do you have an opinion?  Using a config file wasn't a decision I was part of; I'm just maintaining the status-quo there.
I was keen to make the environment variables able to override any of the config in that file rather than special-casing just a few cases.  (I'd forgotten about the FelixHostname variable, but my code still handles it so I think that was the right design choice.)
Combining into one variable and prefixing with FELIX or CALICO sound like good ideas.  I'll make those changes.
We lost the ability to specify the config file when we moved to python 2.6.  I've filed #329 to cover that since it's orthogonal to this pull req.

I see no reason not to allow both a config file and environment variables, allowing the environment to override the config file. Make the config file optional and then we can look like the etcd-style model (command line args and environment vars) and the OpenStack model (configuration files).

In general, though, we shouldn't just keep stuff because we can, should we?  I'd say we need a positive reason for keeping a config file and that, if we don't have one, we should enjoy the code simplification to be gained from discarding it.

I think the positive reason is that the install code uses it now. If we could do that install another easier way, then I'm happy to nuke the config file.

I've prepared a code change to nuke the config file at https://github.com/Metaswitch/calico/pull/366.

@fasaxc Coming back to your original premise: "This makes it much easier to configure felix when it's running under a docker container."  Why is that?

That's due to dockers file-system architecture.  It downloads a snapshot file system and runs the application on top of it.  The snapshot is mainly read-only (in any case it's hard to modify from outside the container).
Files that the container does need to share (e.g. its persistent data files) are mounted into the container as volumes.
That's overkill for "bootstrap" config so they've settled on a de-facto standard of passing in environment variables.
Tentatively closing this, please re-open if you think that's premature...


CFTypeRef marshalling from create or copy function

Currently CFUUIDCreateString returns a JS string primitive, which can't be CFRelease-d.
More info:

Create rule
CFUUIDCreateString

This should also be applicable to CFDateRef and CFNumberRef.

So there are still some functions like CGPathCreateMutable() which are not memory managed by the runtime. I'll have a look at them.

So it turns out that Swift has hardcoded the following types to be bridged: https://gist.github.com/anonymous/02bdf73ede2f68a6432a

We will memory manage only functions in CF_IMPLICIT_BRIDGING_ENABLED blocks. I'll modify the metadata generator to respect it.

Here is an update with other functions removed: https://gist.github.com/jasssonpet/327862790a058523179c/revisions

What's wrong with UTTypeCopyDescription? It's memory-managed even though it's not in an CF_IMPLICIT_BRIDGING_ENABLED block?

UTTypeCopyDescription returns JavaScript string which can't be released in NativeScript.

I'll create the JSString subclass that was supposed to manage primitives in the first place. However, do you think we might have to deal with CFNumbeRef values? The subclass-the-primitive approach won't work for numbers.

Well, there is CFNumberCreate().

I meant to say CFNumberRefs returned from functions that would require a manual CFRelease.

All functions from the list above return CFStringRef only, so we shouldn't worry for CFNumberRef and CFDateRef, imo.

We have decided to adopt Swift's Unmanaged<Instance> approach.

Fixed by implementing the Unmanaged return type in #386


[Bug]: Dynamic slides not scrolling

Which variants of Embla Carousel are you using?

[X] embla-carousel (Core)
[X] embla-carousel-react
[ ] embla-carousel-vue
[ ] embla-carousel-svelte
[ ] embla-carousel-autoplay
[ ] embla-carousel-auto-scroll
[ ] embla-carousel-solid
[ ] embla-carousel-auto-height
[ ] embla-carousel-class-names
[ ] embla-carousel-fade
[ ] embla-carousel-docs (Documentation)
[ ] embla-carousel-docs (Generator)

Steps to reproduce
https://github.com/user-attachments/assets/1b4180af-326c-4a0e-8465-7cadbc413ead
The bug occurs when I try to scroll slides using emblaApi?.scrollNext().
It’s important to note that those slides are dynamically managed using React’s useState hook to allow new slides to be added via a button click
steps to reproduce:
git clone https://github.com/gnllucena/embla-dynamic-slides
cd embla-dynamic-slides
npm install
npm run dev
Expected Behavior
The slides should scroll
Additional Context
While searching the issues I've stumbled upon this piece of code to re init the carousel when new slides are added, unfortunately it's not working for me:
  useEffect(() => {
    if (emblaApi) {
      emblaApi.reInit()
    }
  }, [emblaApi, slides])

What browsers are you seeing the problem on?
Chrome, Microsoft Edge
Version
8.3.0
CodeSandbox
https://github.com/gnllucena/embla-dynamic-slides
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues
[X] I agree to follow this project's Contributing Guidelines for bug reports

@gnllucena thanks for your bug report. If you want help faster, please create a CodeSandbox instead. You may fork any of the examples on the documentation website and change it so it reproduces the problem. Please don’t forget to strip it from all unnecessary details so I can debug effectively.

There you go, @davidjerleke:
https://codesandbox.io/p/sandbox/embla-carousel-generator-react-forked-8dh3f8?workspaceId=22c95318-cd64-4dd2-b59d-9cfa7b818618

@gnllucena I don't think this is a bug but rather the way you have markup in your states. This works as expected.

hey, @davidjerleke!
Yeah, I do have markup in my state because they’re supposed to be different components.
My use case is: depending on the products you choose to buy, a different checkout experience is presented to you. Embla controls that workflow, with different components at each step of the carousel.
I’ve created a new sandbox detailing that: https://codesandbox.io/p/sandbox/embla-carousel-generator-react-forked-8dh3f8?file=%2Fsrc%2Fjs%2FEmblaCarousel.tsx%3A68%2C43&workspaceId=22c95318-cd64-4dd2-b59d-9cfa7b818618
(For the sake of simplicity, the slides all look the same, but in my case, they’re wildly different. Hence, I don’t think your example fits the problem I'm describing.)
In the first step, there’s only one slide on the carousel. If you click Move to next or drag the slide, you’ll notice that there are no other slides:
https://github.com/user-attachments/assets/dd7b6676-f0bc-41ed-9023-5aeac6d8f91d
If you click on Add old Product, React adds two new slides into the carousel. You’ll notice that the Move to next button does not work, BUT if you drag the slides, it actually works! Even weirder: if you click on Move to next on the second slide, it also works:
https://github.com/user-attachments/assets/8d95da16-2738-48e9-bf01-6bfcac18cee6
if you think that's not a bug, do you have any suggestion on how to have very different dynamic slides on Embla?

React adds two new slides into the carousel. You’ll notice that the Move to next button does not work, BUT if you drag the slides, it actually works! Even weirder: if you click on Move to next on the second slide, it also works.
@gnllucena I think this is expected, because my understanding of React is that you shouldn't use useState's with markup. They're supposed to be isolated states containing either primitive data types or complex like objects or arrays. They should not be responsible for rendering. As you can see the scrollNext is the functionality that never works in your code examples, that's the common thread. Because it's added into the setState where it shouldn't be.
With that said, Embla doesn't restrict you from rendering different children, it allows for any children. Se a modified sandbox for one way to solve it. Another way would be to simply pass children to the EmblaCarousel component and map the children with a slide wrapper but other than that just render the child content as is, which you can read about here.
This isn't a bug because I think you're using React as it's not intended to be used when putting markup in your states.

I was able to make dynamic scroll work based on your example. thanks for the help, @davidjerleke


Path issues with custom admin routes

Hi,
The plugin admin buttons don't work with custom admin routes or custom server paths, getting a 404 error.
I took a look at progressbar.js and I noticed the admin path is static, like:
 $.ajax({
            url: '/admin/plugins/webp/images',
            type: 'GET'
        }).

I usually change the admin route value on all my websites for security reasons (ex: /admin123), and my server URL is something like https://localhost/sites/foobar, so my final admin URL is https://localhost/sites/foobar/admin123, and not https://localhost/admin as your script suggests.
I think you could implement something like
<script> var adminroute = {{ base_url|e ~ config.plugins.admin.route }};</script>
in your twig files to pass the correct URL to JavaScript.

Hello @diegomagikal,
Thanks for Your report.
As I noticed in grav-plugin-admin there is a place where admin route is defined (depends on config):
https://github.com/getgrav/grav-plugin-admin/blob/develop/themes/grav/templates/partials/javascript-config.html.twig
So I used  window.GravAdmin.config to fix this problem.
Fixed in new release.
Related commit: https://github.com/greenrivers/grav-plugin-webp/commit/3e330d18edd4044798fe03997a0cce5e8a3abe20

It worked, thanks :-)


Use Gentoo-Based pdns

Using Gentoo allows customized compiler flags. I've set the optimization to sandybridge, which is what is appriopriate for our machines.
This PR also contains performance measurement tools.

[ ] Check upgrade notes for pdns 4.7
[ ] Pin version to 4.7
[ ] do not deploy dnsperf
[x] make sure it's actually faster :)

@robertbuhren

I've set up a benchmark using real-world queries from one of our frontend nodes and dnsperf as integrated in this PR on my laptop. I've tested Ubuntu-based pdns 4.6 vs. Gentoo-based pdns 4.7. Result:

Ubuntu pdns 4.6 query time:  2.034ms (sd: 0.527)
Gentoo pdns 4.7 query time:  2.159ms (sd: 0.585)

No significant difference. :nerd_face:
We could go on and test 4.6 vs 4.6 or 4.7 vs 4.7 and so on. Or we just take the performance test bench from this PR and keep using Ubuntu.
To run the performance test, generate dnsperf input file from a frontend server traffic dump dump.pcap:
tcpdump -nr dump.pcap "dst port 53" | grep -oE '\s[A-Z]+\?\s.*' | awk '{print $2 " " substr($1, 0, length($1) - 1)}' | gzip > dnsperf.in.gz

This file needs to fed into dnsperf:
docker-compose up -d ns
zcat dnsperf.in.gz | docker-compose run dnsperf dnsperf -s ns

To make the test meaningful, ns needs to have a recent copy of the lmdb (see README on how to backup/restore).
Output will look like this:
Statistics:

  Queries sent:         2359455
  Queries completed:    2359455 (100.00%)
  Queries lost:         0 (0.00%)

  Response codes:       NOERROR 2216757 (93.95%), SERVFAIL 188 (0.01%), NXDOMAIN 89477 (3.79%), REFUSED 53033 (2.25%)
  Average packet size:  request 31, response 59
  Run time (s):         51.141168
  Queries per second:   46136.118753

  Average Latency (s):  0.002159 (min 0.000084, max 0.008775)
  Latency StdDev (s):   0.000585

@peterthomassen What are your thoughts on how to integrate dnsperf into the docker-compose application? As a separate .yml-file perhaps?

Or we just take the performance test bench from this PR and keep using Ubuntu.

I think this is the best way forward.

@peterthomassen What are your thoughts on how to integrate dnsperf into the docker-compose application? As a separate .yml-file perhaps?

Did so in b922208ddf46d5c48434a104eebfde7f452c9b25.
Would you like to pursue the Gentoo approach further? (I'm not sure it's worth it.)

Likely not heading this way, but thx for the fish!