e2e failed to run occasionally

logs:

Here are the very first debug process:

add cron job to run the ci hourly
add df -lh at every essential position
add journalctl -r |head -n200 when the gm:localup image is deleted

nothing suspicious found.
After a day or two, I realized that kubelet has the image gc logic, and the edgecore is based on kubelet.
Then I found imageGCHighThreshold in edgecore's config, after following the code, I got the key message at
https://github.com/kubeedge/kubeedge/blob/fc8f3aa355b8e1cd2ef49855d1f035a300823038/vendor/k8s.io/kubernetes/pkg/kubelet/images/image_gc_manager.go#L300-L308
So add grep -C99 'Disk usage on image filesystem' /tmp/edgecore.log,
here are the failing log:
gm image sha 256 b7f1838ba0fe is cleaned by image_gc_manager

Solutions
Obviously we can close the image_gc_manager of edgecore by setting imageGCHighThreshold to 100%.
But since currently we install kubeedge by running local_up_kubeedge.sh, there's no way to close it.
In another way,  since edgecore image_gc_manager only prunes these unused images(used means used by k8s pod), cleans the image by least used/detected time(code), we can start kubeedge first, and build/use our images immediately.


Use standard Go "context" package [phab:D1202]

Created by schroederc at 2016-12-29 20:25:32:
https://golang.org/doc/go1.7#context

shahms accepted this revision at 2016-12-29 23:27:38

schroederc closed via commit 7503e2f4cc89e8c10c7a8121fcc43d1fa354b7dd at 2016-12-29 23:32:21


Make Web UI Sign-up Optional

Hi,
Would it be possible to make the Web-UI signup functionality optional?  Perhaps a value that can be overidden during the helm installation?

BTW while we are at this, perhaps we can style the sign-up page a bit differently, because currently the two pages (sign-up and sign-in) are styled IIRC exactly the same, so users may not even notice where they are.
We can leave only one big sign-in button with a small text underneath "If you do not have an account yet, please sign up here" (and the link will bring people to a dedicated sign-up page, where we could later have captcha and email verification and stuff).
And, for this ticket at hand, the text under sign-in would simply read "If you don't have an account yet, please contact REANA administrators" with a mailto for site admins.
So the sign-in UI design would be similar for the two cases.

Discussed offline:

Keep the sign-up form always and enable Invenio-Accounts email confirmation so the account is only usable once confirmed. After that, the user must request the token as usual.

@hollowec would this fulfill your needs?

Hi @mvidalgarcia , that would help a lot, but I would prefer to also have the option to disable the sign-up completely if possible.

Hi @mvidalgarcia , that would help a lot, but I would prefer to also have the option to disable the sign-up completely if possible.

The problem with this approach is that,

a) At the moment, as you well mentioned on Gitter, it's not possible to set a password to newly created users via reana-admin;
b) If we implement this, the safest way to do it would be autogenerating a random password for the new user. Then, it'd responsibility of the admin to send this password to the user, with the safety problems that it involves;
c) We still don't have the possibility for users to change their password, so that autogenerated password would be compromised from the very first moment. We will have to make the changing password available before.

If enabling email confirmation would already help a lot, we will most likely implement this first, as it seems the easiest/fastest/most common approach to us, and then we will consider applying the rest of the functionalities. I'm pretty sure that some of them such as changing passwords will come sooner or later.
Thanks so much for your input!

Hi @mvidalgarcia, OK sounds good, thanks!  Can captcha be enabled for sign-up as well?

Hi @mvidalgarcia, OK sounds good, thanks! Can captcha be enabled for sign-up as well?

We will definitely explore this option in the future.

Closing this as the main functionality has been implemented and published in the 0.7.2 release.
Separate issue created for the captcha implementation: https://github.com/reanahub/reana-ui/issues/177


Added vims paste before 'P'

P behaves like p but instead of inserting after the cursor P inserts before the cursor. P moves the cursor one to the left before pasting. This move does not occur if the cursor is at the beginning of the line and therefore behaves like vims P.

The unsuccessful check was due to a network error. It has nothing to do with the added code.

The unsuccessful check was due to a network error. It has nothing to do with the added code.

Thanks for mentioning it; I told the check to re-run.

Sorry for reopening this. I forgot about this PR and deleted my head repository. Is there anything holding this PR back or did it just go under? @MinusGix

It's waiting for @dzhou121 to review it

With this fix, if the cursor is at the beginning of the line it pastes after the first char. It think it should paste at the very beginning of the line. That is how it works in vim.

Okay, I will fix this later today or on the weekend.


Initial attempt to port to golang 1.8.x

Note, be critical of the changes. I have observed that the xen runtime (hello image) behaves ok in vagrant, but exhibits some inconsistent behavior.


tiny update to test pull request template

Pull Request Template:
If you are merging in a feature or other major change, use this template to check your pull request!
Basic Info
What's this pull request about?

Deleted a small hyphen on a comment to test PR

Feature Documentation
Did you document your feature? Make sure you do the following before you pull request!

[ ] Copy the Template. Go to the Feature Wiki and Copy/Paste the Feature Template into a new page.
[ ] Fill out the Template. Fill out the basic information for the feature in the template. Use the template to document your plan for implementation and major design decisions; if anything changes along the way, update the documentation as you go.
[ ] At the top of my feature, I indicate whether the feature is conversation level or chat level.

Code Basics

[ ] My feature is a .py file.
[ ] My feature uses snake case in the name. That means the name of the format is my_feature, NOT myFeature (camel case).
[ ] My feature has the name, NAME_features.py, where NAME is the name of my feature.
[ ] My feature is located in feature_engine/features.

Testing

[ ] I have thought about test cases for my features, with inputs and expected outputs.
[ ] I have linked to a location (e.g., .py or .ipynb) where I can run my test cases and show they work (inputs match expected outputs).

The location of my tests are here:

[PASTE LINK HERE]

If you check all the boxes above, then you ready to merge!

woohoo! PR template works~


Exchange heartbeat subscriptions (streaming)

Having an issue with CoinbasePro where disconnects on the web socket were getting triggered every so often after some period of inactivity (this due to the fact that on my user channel I don't produce too many trades so messages can be sparse).
I solved this by effectively copying out CoinbaseProStreamingService.java amongst other classes to subscribe to CoinbasePro's heartbeat channel which receives heartbeats once a second and prevents web socket from dying.
I am now seeing a similar issue with Bitstamp (albeit not as frequently) on their regular trades channel with some symbols. Bitstamp does not have a heartbeat channel but suggests using web sockets ping pong mechanism. Sending a way to send a non text based web socket frame is not exposed in the NettyStreamingService.java class.
In short, I would like to make two changes (or more) to the library:
1). Allow users the ability to subscribe to heartbeat channel as an exchange spec config for CoinbasePro (or have it by default subscribe by don't pass heartbeat messages back to user of class-- Kraken does this).
2). Either expose method in NettyStreamingService.java to write non text based messages or just a ping method so that users can trigger web socket ping with some interval.

NettyStreamingService already responds to ping with pong. I assume Bitstamp are suggesting that client should do the ping? If yes, then I think an overload of sendMessage that takes a generic Netty frame seems like a reasonable addition.
I can't think of a good reason to make the Coinbase Pro behaviour optional. It has very low cost and adds reliability for everyone. Once a second seems a little too frequent though. How often does it need to be to prevent disconnect? Half that seems safe enough.
For both Bitstamp and Coinbase, there's an existing pattern of just using an Observable.interval subscribed on connect and disposed on disconnect. See https://github.com/knowm/XChange/blob/develop/xchange-stream-bitfinex/src/main/java/info/bitrich/xchangestream/bitfinex/BitfinexStreamingService.java#L99.

The only documentation Bitstamp has is here https://www.bitstamp.net/websocket/v2/ nothing about this however, is unique to Bitstamp this is just part of the web socket spec. And yes I am just trying to expose a way to send a ping periodically to Bitstamp to keep the connection alive.
The only reason I would think this being optional would be someone wanting to operate in a low-garbage environment where the heartbeat messages may create unwanted garbage (seems unlikely as I don't see low/no GC being a bit part of the library). As far as heartbeat rate-- that isn't controlled client side, you simply open a subscription with CoinbasePro on its heartbeat channel and messages are sent from Coinbase. I had observed heartbeat messages coming about once a second when testing https://docs.pro.coinbase.com/#the-heartbeat-channel.
The other bit, from testing it looked like the disconnect came from the client (xchange) not from the exchange. I suspect this because public void channelInactive(ChannelHandlerContext ctx) was triggered after a period of time without messages from the CoinbasePro.
I am not following how the observable patten you described ties into this?

try this: add to BitstampStreamingService, I thought I had done this already for Bitstamp.
This causes a Ping/Pong Frame to be send (not quite the same as message), and I think this should be the default implementaion for NettyStreamingService anyway.
  @Override   protected void handleIdle(ChannelHandlerContext ctx) {     ctx.writeAndFlush(new PingWebSocketFrame());  }
No guarantee, totally untested tonight

I think this may actually be the best way to fix this (if testing goes well) and a good default implementation.
Also sounds much cheaper then opening a subscription to the heartbeat channel for CoinbasePro.

Hi everyone,
Implemented the change suggested by @mdvx and works as expected https://github.com/knowm/XChange/pull/3526.
Did have to default idle time so that protected void handleIdle(ChannelHandlerContext ctx) would be triggered.

Nice to see the idle feature I added a while ago get used for something! Seems sensible.

Only thing is that now client exchanges need to call super to avoid losing the ping/pong behaviour. Have you checked that there aren't any doing so?

There are only two exchanges that override it Lgo + Gemini, but the override does the same thing as the feature we just added.


chore: patternProperties should be included in the output

Description
This PR ensures that patternProperties are included in the output.
Related issue(s)
resolves #43

This is a wrong implementation since it should be moved to CommonModel


Kong + Gzip doesn't work

Probably a newbie question here, but I am struggling with it for 2 days and can't find the answer...
So: I can't manage to make Kong accept the  "Accept-Encoding: gzip" header.
Whenever I make a request with the "Accept-Encoding: gzip" header, I have a correct 200 OK status, but my answer is empty ...
And gzip on the openresty nginx server seems already activated as it already answer "Accept-Encoding: gzip" in the response header...
The problem is that this header is automatically set by browsers, so I can't demo my API if I setup a Kong proxy.
So how to make Kong accept (or ignore) this header ?

Ok, I manage to make it work by deactivating the "response-transformer" plugin.
Any idea what is the link between those 2 things ?

What does "BC" means ?

@diwann just labels we use to track issues infernally...
we are actively looking at the gzipping questions for Kong.

This is caused when the plugin tries to access the body of the request/response, and it's unable to read it because it's gzipped.

I have the following settings:

curl 'https://kong.XXXX/plugins' -X PUT -H 'Content-Type: application/json' --data '{"api_id":"XXXXX-7edf-41dd-9115-16f0e324c882","name":"response-transformer","config":{"remove":{"json":"links"}}}'

However, I haven't checked yet if it's still the case with Konk 0.9

Yes, I just checked, and it's still the case with 0.9.0 (and "next")

ok, I finally found a solution: in order to access to the json structure, the response-transformer plugin need to access the body of the response from the backend.
But this body is compressed as soon as the client accept gzip encoding.
So the trick is to make Kong and the backend to communicate in plain text, and to handle the gzip compression on Nginx side.
For that, you need to hide the "Accept-Encoding" header when the query come in, which you can do in the nginx configuration file, under the "location /" section, with:
proxy_set_header Accept-Encoding "";

Then, you need to activate the gzip compression on nginx side, under the "server" section, with:
gzip on;
gzip_types text/plain text/css application/json;

🎉

@Diwann thx for reporting back with the solution you found!

This is great - @Diwann if you submit a PR I will be happy to tweak and merge it.

A variation to @Diwann 's suggestion from https://github.com/Kong/kong/issues/1200#issuecomment-257940259 is to use the request-transformer plugin and replace the Accept-Encoding header to force Accept-Encoding:identity. I posted it here https://discuss.konghq.com/t/custom-transformer-with-body-filter-for-compressed-response/7963

ok, I finally found a solution: in order to access to the json structure, the response-transformer plugin need to access the body of the response from the backend. But this body is compressed as soon as the client accept gzip encoding. So the trick is to make Kong and the backend to communicate in plain text, and to handle the gzip compression on Nginx side. For that, you need to hide the "Accept-Encoding" header when the query come in, which you can do in the nginx configuration file, under the "location /" section, with:
proxy_set_header Accept-Encoding "";

Then, you need to activate the gzip compression on nginx side, under the "server" section, with:
gzip on;
gzip_types text/plain application/json;

🎉

I have the nginx-kong.conf file with 3 server blocks kong, kong_gui, kong_admin
i have to add proxy_set_header Accept-Encoding "";  in server_name kong location /  block ?
when i restart the kong it overrides those directive, i see the kong.conf have a nginx inject block but i didn't find a way to inject in location / block


HBASE-28001: Add request attribute support to BufferedMutator

Design Doc
As of https://github.com/apache/hbase/pull/5326, we have been able to set request attributes on Table instances via TableBuilder::setRequestAttribute. With request attributes, users can send an attribute once per request, instead of once per operation.
In this PR, we extend the feature to BufferedMutators. One can set a request attribute on a BufferedMutator via a new method BufferedMutatorParams::setRequestAttribute(String key, byte[] value).
Map<String, byte[]> REQUEST_ATTRIBUTES = Map.of(...);
...
BufferedMutatorParams params =
    new BufferedMutatorParams(REQUEST_ATTRIBUTES_TEST_TABLE);
REQUEST_ATTRIBUTES.forEach(params::setRequestAttribute);
BufferedMutator bufferedMutator = conn.getBufferedMutator(params);
// all calls generated via this buffered mutator will include the given attributes

Jira
cc @bbeaudreault @hgromer @bozzkar @rmdmattingly @krconv @sidkhillon

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s

master passed

+1 :green_heart:
compile
4m 50s

master passed

+1 :green_heart:
checkstyle
1m 10s

master passed

+1 :green_heart:
spotbugs
3m 13s

master passed

+1 :green_heart:
spotless
1m  4s

branch has no errors when running spotless:check.

-0 :warning:
patch
1m 19s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 30s

the patch passed

-1 :x:
compile
3m 33s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
3m 33s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 44s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
hadoopcheck
14m 36s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 24s

patch has 68 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s

The patch does not generate ASF License warnings.

53m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux b681e50e4118 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b897921c41e0c84bc61c46a8e6d173111def21ee

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 58s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 48s

the patch passed

+1 :green_heart:
shadedjars
5m 18s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 37s

hbase-client in the patch passed.

-1 :x:
unit
234m 56s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

263m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux bb0e53983dff 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b897921c41e0c84bc61c46a8e6d173111def21ee

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/1/testReport/

Max. process+thread count
5647 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 10s

master passed

+1 :green_heart:
compile
3m 49s

master passed

+1 :green_heart:
checkstyle
0m 51s

master passed

+1 :green_heart:
spotbugs
2m 13s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

-0 :warning:
patch
0m 58s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  1s

the patch passed

-1 :x:
compile
2m 56s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
2m 56s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 50s

the patch passed

+1 :green_heart:
spotbugs
2m 45s

the patch passed

+1 :green_heart:
hadoopcheck
11m 30s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s

The patch does not generate ASF License warnings.

41m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux b5eb6e479592 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 23e657e91904b91b44349fefd43429ce36144830

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
90 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed

+1 :green_heart:
shadedjars
5m 23s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 36s

hbase-client in the patch passed.

+1 :green_heart:
unit
229m 43s

hbase-server in the patch passed.

258m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux a0956dd715ea 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 23e657e91904b91b44349fefd43429ce36144830

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/2/testReport/

Max. process+thread count
5292 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  2s

master passed

+1 :green_heart:
compile
3m 46s

master passed

+1 :green_heart:
checkstyle
0m 50s

master passed

+1 :green_heart:
spotbugs
2m 19s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

-0 :warning:
patch
0m 56s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s

the patch passed

+1 :green_heart:
compile
3m 45s

the patch passed

+1 :green_heart:
javac
3m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

the patch passed

+1 :green_heart:
spotbugs
2m 29s

the patch passed

+1 :green_heart:
hadoopcheck
11m 25s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 38s

patch has 29 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

41m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux a5462799fae5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e1e241e8c81b21d3da7715baab1dd1d209fd8966

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/3/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed

+1 :green_heart:
shadedjars
5m 22s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 38s

hbase-client in the patch passed.

+1 :green_heart:
unit
227m 33s

hbase-server in the patch passed.

255m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 6f6d4907100a 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e1e241e8c81b21d3da7715baab1dd1d209fd8966

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/3/testReport/

Max. process+thread count
5368 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  2s

master passed

+1 :green_heart:
compile
3m 45s

master passed

+1 :green_heart:
checkstyle
0m 56s

master passed

+1 :green_heart:
spotbugs
2m 18s

master passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

-0 :warning:
patch
0m 59s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
3m 46s

the patch passed

+1 :green_heart:
javac
3m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
spotbugs
2m 32s

the patch passed

+1 :green_heart:
hadoopcheck
10m 26s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s

The patch does not generate ASF License warnings.

39m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux bc7f977552ab 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 46aa8b5371f065af8146210fdc5b1b1e5f683126

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 23s

the patch passed

+1 :green_heart:
compile
1m 52s

the patch passed

+1 :green_heart:
javac
1m 52s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed

+1 :green_heart:
shadedjars
6m 34s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  0s

hbase-client in the patch passed.

+1 :green_heart:
unit
246m 16s

hbase-server in the patch passed.

283m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux a3fc86f4989e 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 46aa8b5371f065af8146210fdc5b1b1e5f683126

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/4/testReport/

Max. process+thread count
5472 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Do we have anything that demonstrates use of connection or request attributes in hbase-examples? If yes, please add example overage there. If not, would you mind filing an issue to add something to that module? Thanks @eab148 !

Do we have anything that demonstrates use of connection or request attributes in hbase-examples? If yes, please add example overage there. If not, would you mind filing an issue to add something to that module?

We do not. I can create an issue to add request attribute example coverage to the hbase-examples module.

Since this is public API, let's see if others have an opinion here.

Makes sense! Happy to field any questions/concerns and make adjustments.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  4s

master passed

+1 :green_heart:
compile
2m 12s

master passed

+1 :green_heart:
javadoc
3m 26s

master passed

+1 :green_heart:
shadedjars
5m 21s

branch has no errors when building our shaded downstream artifacts.

-0 :warning:
patch
5m 56s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 42s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
1m 33s
/patch-compile-root.txt
root in the patch failed.

-0 :warning:
javac
1m 33s
/patch-compile-root.txt
root in the patch failed.

+1 :green_heart:
javadoc
3m 22s

the patch passed

-1 :x:
shadedjars
4m  6s

patch has 16 errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
1m 51s
/patch-unit-root.txt
root in the patch failed.

29m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 2866f66ed182 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7abdc55daae768685817801ac612e2f62dea9e39

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/testReport/

Max. process+thread count
310 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  9s

master passed

+1 :green_heart:
compile
7m 47s

master passed

+1 :green_heart:
checkstyle
1m 11s

master passed

+1 :green_heart:
spotbugs
10m 29s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

-0 :warning:
patch
1m 13s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 42s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
4m 16s
/patch-compile-root.txt
root in the patch failed.

-0 :warning:
javac
4m 16s
/patch-compile-root.txt
root in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  9s
/results-checkstyle-root.txt
root: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1 :green_heart:
xmllint
0m  0s

No new issues.

-1 :x:
spotbugs
0m 47s
/patch-spotbugs-hbase-server.txt
hbase-server in the patch failed.

-1 :x:
spotbugs
4m  4s
/patch-spotbugs-root.txt
root in the patch failed.

-1 :x:
hadoopcheck
2m  0s

The patch causes 16 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
4m  2s

The patch causes 16 errors with Hadoop v3.4.0.

-1 :x:
spotless
0m  6s

patch has 25 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

-1 :x:
asflicense
0m 39s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

45m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint

uname
Linux 658dbfe571e3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7abdc55daae768685817801ac612e2f62dea9e39

Default Java
Eclipse Adoptium-17.0.11+9

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/artifact/yetus-general-check/output/patch-javac-3.4.0.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/5/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
192 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server hbase-examples . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

-1 :x:
mvninstall
3m 37s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
2m 20s

the patch passed

+1 :green_heart:
javac
2m 20s

root generated 0 new + 69 unchanged - 5 fixed = 69 total (was 74)

+1 :green_heart:
javadoc
3m 27s

the patch passed

-1 :x:
shadedjars
4m  7s

patch has 10 errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
1m 50s
/patch-unit-root.txt
root in the patch failed.

33m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux bedd5d855d15 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 014c1a6e2837fafb36b9e014e39867f3ac53d88d

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/testReport/

Max. process+thread count
330 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 53s

master passed

+1 :green_heart:
compile
12m  9s

master passed

+1 :green_heart:
checkstyle
1m 40s

master passed

+1 :green_heart:
spotbugs
16m 35s

master passed

+1 :green_heart:
spotless
1m  8s

branch has no errors when running spotless:check.

-0 :warning:
patch
1m 52s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

-1 :x:
mvninstall
4m 39s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
10m 39s

the patch passed

+1 :green_heart:
javac
10m 39s

root generated 0 new + 1202 unchanged - 3 fixed = 1202 total (was 1205)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 22s
/results-checkstyle-root.txt
root: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
11m 47s

the patch passed

-1 :x:
hadoopcheck
5m 37s

The patch causes 13 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
11m 21s

The patch causes 13 errors with Hadoop v3.4.0.

-1 :x:
spotless
0m 12s

patch has 46 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

-1 :x:
asflicense
0m 43s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

81m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint

uname
Linux 6782f90fb4e4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 014c1a6e2837fafb36b9e014e39867f3ac53d88d

Default Java
Eclipse Adoptium-17.0.11+9

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/artifact/yetus-general-check/output/patch-javac-3.4.0.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/6/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
188 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server hbase-examples . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

-1 :x:
mvninstall
2m 56s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
2m 10s

the patch passed

+1 :green_heart:
javac
2m 10s

the patch passed

+1 :green_heart:
javadoc
3m 10s

the patch passed

-1 :x:
shadedjars
4m  7s

patch has 10 errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
296m 42s

root in the patch passed.

330m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux c2d650c9f126 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / daf6b7953a1bc6087b339352f86cd1455607c150

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/7/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/7/testReport/

Max. process+thread count
8615 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/7/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s

master passed

+1 :green_heart:
compile
7m 48s

master passed

+1 :green_heart:
checkstyle
1m  9s

master passed

+1 :green_heart:
spotbugs
9m 54s

master passed

+1 :green_heart:
spotless
0m 42s

branch has no errors when running spotless:check.

-0 :warning:
patch
1m  6s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s

Maven dependency ordering for patch

-1 :x:
mvninstall
3m  5s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
7m 50s

the patch passed

+1 :green_heart:
javac
7m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 12s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
10m 29s

the patch passed

-1 :x:
hadoopcheck
5m 31s

The patch causes 13 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
11m  8s

The patch causes 13 errors with Hadoop v3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

60m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint

uname
Linux 28229a458d47 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1812fd643981d5c4ea7b5a9622990321a757c0d4

Default Java
Eclipse Adoptium-17.0.11+9

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/8/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/8/artifact/yetus-general-check/output/patch-javac-3.4.0.txt

Max. process+thread count
189 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-examples . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

-1 :x:
mvninstall
2m 58s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
2m 10s

the patch passed

+1 :green_heart:
javac
2m 10s

the patch passed

+1 :green_heart:
javadoc
3m  8s

the patch passed

-1 :x:
shadedjars
5m 24s

patch has 13 errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
317m 49s
/patch-unit-root.txt
root in the patch failed.

352m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux bff8f0041ae0 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1812fd643981d5c4ea7b5a9622990321a757c0d4

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/8/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/8/testReport/

Max. process+thread count
5447 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-examples . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/8/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 23s

master passed

+1 :green_heart:
compile
4m 14s

master passed

+1 :green_heart:
checkstyle
0m 58s

master passed

+1 :green_heart:
spotbugs
2m 43s

master passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

-0 :warning:
patch
1m  2s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  1s

the patch passed

+1 :green_heart:
compile
4m 14s

the patch passed

+1 :green_heart:
javac
4m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
spotbugs
3m  1s

the patch passed

+1 :green_heart:
hadoopcheck
11m 37s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s

The patch does not generate ASF License warnings.

44m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux e2959e92a79c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0a04b6087ad03c05e791a4e3af764858887cefc7

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-examples U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/9/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s

master passed

+1 :green_heart:
compile
1m 43s

master passed

+1 :green_heart:
javadoc
1m  5s

master passed

+1 :green_heart:
shadedjars
5m 21s

branch has no errors when building our shaded downstream artifacts.

-0 :warning:
patch
5m 48s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
1m 43s

the patch passed

+1 :green_heart:
javac
1m 43s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed

+1 :green_heart:
shadedjars
5m 19s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 38s

hbase-client in the patch passed.

-1 :x:
unit
225m 44s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
unit
2m 14s

hbase-examples in the patch passed.

257m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux be40005f33d7 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0a04b6087ad03c05e791a4e3af764858887cefc7

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/9/testReport/

Max. process+thread count
5731 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-examples U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/9/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Test failure is unrelated to this change
[ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 768.803 s <<< FAILURE! - in org.apache.hadoop.hbase.TestAcidGuaranteesWithEagerPolicy
[ERROR] org.apache.hadoop.hbase.TestAcidGuaranteesWithEagerPolicy  Time elapsed: 618.862 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 780 seconds
	at java.base@17.0.11/java.lang.Object.wait(Native Method)
	at java.base@17.0.11/java.lang.Thread.join(Thread.java:1313)
	at java.base@17.0.11/java.lang.Thread.join(Thread.java:1381)
	at app//org.apache.hadoop.hbase.MultithreadedTestUtil$TestContext.stop(MultithreadedTestUtil.java:103)
	at app//org.apache.hadoop.hbase.AcidGuaranteesTestTool.runTestAtomicity(AcidGuaranteesTestTool.java:390)
	at app//org.apache.hadoop.hbase.AcidGuaranteesTestTool.doWork(AcidGuaranteesTestTool.java:130)
	at app//org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:150)
	at app//org.apache.hadoop.hbase.AcidGuaranteesTestBase.runTestAtomicity(AcidGuaranteesTestBase.java:102)
	at app//org.apache.hadoop.hbase.AcidGuaranteesTestBase.testMobGetAtomicity(AcidGuaranteesTestBase.java:122)
	at java.base@17.0.11/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base@17.0.11/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base@17.0.11/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base@17.0.11/java.lang.reflect.Method.invoke(Method.java:568)
	at app//org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at app//org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at app//org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at app//org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at app//org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at app//org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at app//org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at app//org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at app//org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at app//org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at app//org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at app//org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at app//org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at app//org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at app//org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at app//org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at app//org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.base@17.0.11/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base@17.0.11/java.lang.Thread.run(Thread.java:840)

[ERROR] org.apache.hadoop.hbase.TestAcidGuaranteesWithEagerPolicy  Time elapsed: 618.878 s  <<< ERROR!
java.lang.Exception: Appears to be stuck in thread MiniHBaseClusterRegionServer-EventLoopGroup-3-1
	at app//org.apache.hbase.thirdparty.io.netty.channel.epoll.Native.epollWait0(Native Method)
	at app//org.apache.hbase.thirdparty.io.netty.channel.epoll.Native.epollWait(Native.java:193)
	at app//org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.epollWait(EpollEventLoop.java:312)
	at app//org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:376)
	at app//org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at app//org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at app//org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base@17.0.11/java.lang.Thread.run(Thread.java:840)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 29s

master passed

+1 :green_heart:
compile
4m 15s

master passed

+1 :green_heart:
checkstyle
0m 59s

master passed

+1 :green_heart:
spotbugs
2m 46s

master passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

-0 :warning:
patch
1m  3s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s

the patch passed

+1 :green_heart:
compile
4m 13s

the patch passed

+1 :green_heart:
javac
4m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
spotbugs
3m  3s

the patch passed

+1 :green_heart:
hadoopcheck
11m 35s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 48s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

45m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6076

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 6a199395ebc9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0a04b6087ad03c05e791a4e3af764858887cefc7

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-examples U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6076/10/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Thanks a lot for the contribution @eab148 ! Can you please also provide a new PR for branch-2? You can start by cherry-picking the commit that landed on master. Do ping me when you have the PR up, thanks!


Bugfix for: Ensuring that JerseyRequest scoped ClientConfig gets prop…

…agated to HttpUriRequest #939
The change makes the config changes introduced via Invocation.Builder#property(propertyName, propertyValue) effective. We want to use this pattern because it is truely request creation scoped. In contrast the current implementation is only effective if config changes are being introduced via WebTarget#property(propertyName, propertyValue) which unfortunatly creates a new copy of copy of org.glassfish.jersey.client.ClientRuntime which effectively makes it innefective for implementing dynamic configuration (we saw OutOfMemmory errors due to that).
Original change can be founde here: https://github.com/dropwizard/dropwizard/pull/939

This LGTM, any feedback @arteam ?

@jplock I noticed you've added it to the 0.9.0 milestone. Does this mean there will be no 0.8.2?

@velocipedist correct, we already cut 0.9.0-rc1, so ideally this would make it into rc2

A bit OT, but will ask anyway.
@jplock what are the timelines for this? I'm asking because we found a bug with the metrics library version used by 0.8.1 where request durations are not reported correctly for async resource usage. We were hoping to patch this (unless already done) before the next release of dw.

Unfortunately the metrics releases are a bit out of our hands.  @ryantenney has been working on a roadmap for v4.x but I don't have any visibility into its release schedule.  It may be best to work around it manually for now if you have a workaround.  We're hoping to get Dropwizard 0.9.0 out in July.  /cc @carlo-rtr

FYI: @chrisgray (see the comment around release schedules and metrics)

This also looks good to me. I've applied the patch to master with some commit message polishing.

Metrics 4 isn't going to happen anytime soon.  I wanted to get a 3.2 release out, with some fixes/small features like this.  We could probably make that happen before the Dropwizard 0.9 release.


Changes view: staging file from a bucket collapses entire tree

Previously reported in #101094.
This still happens for me, it's not fixed (although this does not only happen for the last file but for every file).

Seems to be fixed now

I'm seeing this same behavior, also reported in #113656.

I'm seeing this same behavior, also reported in #113656.


Loading from local storage is bugged and/or doesn't match docs

Describe the Bug(s)
The documentation on using local storage isn't consistent between these two links.

https://labelstud.io/guide/storage.html#Local-storage
https://labelstud.io/guide/start.html#Run-Label-Studio-on-Docker-and-use-local-storage

For example, the environment variables mentioned in each are different. Also, note that neither of these pages describes what actually works (see below).
I'm trying to use local storage to label some files. Without working docs, I'm trying different things out and doing my best to get it working. Here are some iterations.
docker run -itd -p 8080:8080 -v /mnt/e/label-studio-backend-stuff:/label-studio/data --env LOCAL_FILES_SERVING_ENABLED=true --env LABEL_STUDIO_LOCAL_FILES_DOCUMENT_ROOT=/mnt/e/data -v /mnt/e/data:/label-studio/files heartexlabs/label-studio:latest
For anyone else struggling, note the env variables, which I think are correct in my example.
I then use the UI to add local storage. Here are two examples.
I use the absolute local path /mnt/e/data/example-data-dir-01, as described in https://labelstud.io/guide/storage.html#Local-storage.

I do some problem solving and try /label-studio/files-example-data-dir-01. I chose this because that's where the files are mounted in the Label Studio container.
I can add them.

But I can't sync them.

Here's the full stack trace.
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/django/utils/decorators.py", line 43, in _wrapper
    return bound_method(*args, **kwargs)
  File "/label-studio/label_studio/io_storages/api.py", line 87, in post
    storage.sync()
  File "/label-studio/label_studio/io_storages/base_models.py", line 147, in sync
    self.scan_and_create_links()
  File "/label-studio/label_studio/io_storages/localfiles/models.py", line 84, in scan_and_create_links
    return self._scan_and_create_links(LocalFilesImportStorageLink)
  File "/label-studio/label_studio/io_storages/base_models.py", line 81, in _scan_and_create_links
    data = self.get_data(key)
  File "/label-studio/label_studio/io_storages/localfiles/models.py", line 68, in get_data
    relative_path = str(path.relative_to(document_root))
  File "/usr/lib/python3.8/pathlib.py", line 908, in relative_to
    raise ValueError("{!r} does not start with {!r}"
ValueError: '/label-studio/files/example-data-dir-01/image_0.jpg' does not start with '/mnt/e/data'

This command works, but it's nothing like what's in the Label Studio documentation.
docker run -itd -p 8080:8080 -v /mnt/e/label-studio-backend-stuff:/label-studio/data --env LOCAL_FILES_SERVING_ENABLED=true --env LABEL_STUDIO_LOCAL_FILES_DOCUMENT_ROOT=/label-studio/files -v /mnt/e/data:/label-studio/files heartexlabs/label-studio:latest

Even with this working, whenever I go to add local storage as an option in Label Studio, it generates two entries.

When I try to delete the 2nd, unnecessary one (see below)...

... both get deleted (see below).

To Reproduce
See above.
Expected Behavior
I expect the docs to be consistent and correct. I also expect that I should relatively easily be able to mount local storage and label files from local storage.
Screenshots
None. Ask if you want screenshots.
Environment
I'm on Windows 11. Label Studio is running in WSL2. Label Studio should be the latest version because that's what Docker is grabbing.
Additional Context
None. Ask if you want any more details.

As for the files showing up 2x, I just realized I was using 1.2. I'm now testing this on 1.3.post0 and I'll update this comment when I have results.

Similar problem mentioned in slack: https://label-studio.slack.com/archives/C01Q5G6NMKR/p1634559875204200

These docs problems were fixed.
https://labelstud.io/guide/start.html#Run-Label-Studio-on-Docker-and-use-local-storage
The duplicated storage was fixed too (in 1.3post0 and later commits).


[$500] Don't show RBR on the LHN for transaction threads with violations if the report has already been reimbursed/settled

Slack discussion (internal)
Transaction threads for transactions that have violations show up on the LHN with a RBR for the use that's requesting money
The idea behind RBR is to show the user a path to take an action to fix a potential issue
This is reasonable for the user requesting money because their requests/transactions may contain violations that can prevent them from getting approved and paid
Once the requests are paid, we agreed to continue showing violations in order to show that the request may not be in compliance with the current workspace rules, which is useful for the users requesting money, and also users paying those requests
However, the RBR specifically on the LHN isn't as relevant because the main idea behind that is to show a path to fix an issue, but in this case, the "issue" is the request has violations, but since they've been paid/settled, this isn't important for the requestor to do

Given that, let's not show RBR on the LHN for transaction threads with violations, if the transactions/money requests have been paid/settled
@trevor-coleman @lindboe can you please comment here so I can assign you? Thanks

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.43-14
Reproducible in staging?: Presumably
Reproducible in production?: Presumably
Issue reported by: @situchan https://github.com/Expensify/App/pull/35449#issuecomment-1961141823
Action Performed:

Make sure you're on the violations beta
Request money without adding a category from workspace that requires category (it should have a missing category violation)
Submit the request if you need to
Approve the request as a workspace admin
Open the transaction thread as the requester. You may need to navigate to another chat, and then back to the transaction thread

Expected Result:

RBR should not be shown on the LHN for the submitter

Actual Result:

RBR is shown on the LHN for the submitter

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e69e67564d338f8f
Upwork Job ID:<PHONE_NUMBER>954891264
Last Price Increase: 2024-02-23
Automatic offers:

situchan | Reviewer | 0
FitseTLT | Contributor | 0

Commenting for assignment

ReportUtils PR was just merged, so we're starting to work on other issues, but that one was priority

Still a priority but other issues are being worked on first

@cdanwards this is the ticket you were pulling into optimistic IDs, right? since we're already making RBR changes there?

WIP

Happy to take this as C+ since I already have context

@situchan can you check the reproduction steps and make any relevant updates?
@CortneyOfstad let's manage this like a regular bug and get proposals, and @situchan will be the C+ reviewing

Proposal
Please re-state the problem that we are trying to solve in this issue.
Don't show RBR on the LHN for transaction threads with violations if the report has already been reimbursed/settled
What is the root cause of that problem?
We are not checking if it is setteled here
https://github.com/Expensify/App/blob/d701972794f6c93d9df4848b5ddc42d99f00946f/src/libs/SidebarUtils.ts#L238-L239
What changes do you think we should make in order to solve the problem?

Change it to
    result.brickRoadIndicator = (hasErrors || hasViolations) && !ReportUtils.isSettled(report) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';

What alternative solutions did you explore? (Optional)

Repro step looks correct.

@situchan , how do we enable violations beta on our expensify account ?

You can raise request on slack

@FitseTLT bump on the comment here
@codinggeek2023 i didn't see any requests in Slack for enabling violations, but if you need any assistance with that, just let me know! Thanks!

Oh thx @CortneyOfstad
@situchan I have received the permission and verified my solution works. U can proceed 👍

@FitseTLT's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

@FitseTLT I think the change you shared under Change it to is better than putting it inside ReportUtils.doesTransactionThreadHaveViolations since it's used in other places, or in the line with  result.brickRoadIndicator

@FitseTLT can you provide an update on when you think you'll have a PR created? EOD, EOW? Thanks!

@zanyrenney I am heading OoO, but will be back March 11th. We're waiting on @FitseTLT to provide an update on when the PR will be created at this stage. Thanks!

nice, thank you @FitseTLT

PR is on review stage 👍

Good movement on the linked PR. Ideally we can even get it merged before the week closes out.

PR is merged

FYI this still seems to be broken for me. I left a more detailed comment in the PR: https://github.com/Expensify/App/pull/37767#issuecomment-2015654957.

I'm pretty sure that error is unrelated, and this is happening  because OpenReport is failing with a JSON error

It looks like this started on Friday

I found the issue and submitted a PR

That said, the problem is unrelated to this GH issue, so I'm going to close this one since it's done

@cead22 What about Payments?? 😆

Argh, they always get me. I see the upwork jobs were created, but not sure what else we need for payments -- @CortneyOfstad @zanyrenney can you help with this please?

No worries — since it was just deployed today, we will need to wait the 7-day period, so going to adjust the title to reflect the payment date if there are no regressions 👍

Payment has been completed! Will post payment summary below.
@situchan does this need a regression test? For some reason the checklist is not populating, so just wanted to confirm. Thanks!

Payment Summary
@FitseTLT (Contributor) — paid $500 via Upwork
@situchan (C+) — paid $500 via Upwork


.data([mesh(json, json.objects.something, function(a,b){...})])

Is it the expected behavior that :
d3.json("./admin_0.topo.json", function(error, json) {
    var L0 =  json.objects.admin_0;
//inland borders lines
    svg.append("g").attr("id","border")
        .attr("style", mesh)
    .selectAll("path")
        .data([topojson.mesh(json, L0, function(a, b) { return a !== b; })]) // (!)
    .enter().append("path")
        .attr("d", path);
});

produces:

I'am aware mesh returns a single MultiLineString:
{
 type: "MultiLineString",
 coordinates: [
     […], // this is an arc, contains points [ lat,lon ]
     […], //many more
 ]
}

Yet, shouldn't the successful (!) projection be a set of closed svg paths ? (without these artifacts)

To close or delete. Bug due to `style="stroke-dasharray:4,4;". My apologizes.

FYI: https://code.google.com/p/chromium/issues/detail?id=364866

Reporting back on chromium bug tracker.


Test and refactor GetUserInfoFromToken

Looks good other than the compile error.

@consolethinks if you have any free time, could you check and fix this PR (or close it all together if not relevant to your changes)?

@consolethinks if you have any free time, could you check and fix this PR (or close it all together if not relevant to your changes)?

Sure I'll check on it today or next week


cannot find module gatsby-transformer-inline/package.json

I cannot build the template.
Node version : 18.14.0
NPM version : 9.5.0
λ npm run build -- --verbose

><EMAIL_ADDRESS>build
> gatsby build --verbose

verbose set gatsby_log_level: "verbose"
verbose set gatsby_executing_command: "build"
verbose loading local command from: REDACTED\node_modules\gatsby\dist\commands\build.js
verbose running command: build
verbose Running build in "production" environment
success compile gatsby files - 2.146s
success load gatsby config - 2.784s

 ERROR  UNKNOWN

plugin "gatsby-transformer-inline-svg threw the following error:
 Cannot find module 'gatsby-transformer-inline-svg/package.json'

The dependencies are the following:
  "dependencies": {
    "gatsby": "^5.9.0",
    "gatsby-theme-portfolio-minimal": "^4.5.0",
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  },

Hey @Xstoudi! Thanks for opening this issue. That's indeed weird since the package is included as a theme dependency. I need to look into it.
If you want to have a quick fix meanwhile, you can add the plugin manually to your deps:
  "dependencies": {
    "gatsby": "^5.9.0",
    "gatsby-theme-portfolio-minimal": "^4.5.0",
    "gatsby-transformer-inline-svg": "^1.2.0",
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  },

It works for now =)

@Xstoudi Just released a new version (v4.5.1) that should fix this :)


Serving Multible Apps per Parse instance

Hello,
i have been using Parse.com to host 3 of my mobile apps , now i knew that i would need to have single Parse Server instance per App .

so, in terms of hosting (mine will be digital ocean) , how many Parse server instances could run per single VPS ?
what is the optimal config to have 3 Parse Server instances run on single VPS ?
any plan or workaround to have the Parse Server become a multi-tenant (Single Instance for many Apps)?

@flovilmart is working on some multi-tenant stuff, but it's pretty experimental and there are still a lot of open questions, like what should go in separate process and what shouldn't.
How many instances you can run on one server will depend on very many variables, including the size of the server, how many queries you are serving, what fraction of them are writes, latency to the DB, etc. running 3 on one server shouldn't be a problem if they are low-traffic, but I'd recommend doing some load testing before moving production apps.

i will dynamically create parse server instance like back4app


State issue for fivetran_connector with 0.7.2

After upgrading from 0.7.1 to 0.7.2, attempting to show the terraform state for our fivetran_connector results in an error.
$ terraform state show fivetran_connector.postgres
missing expected [
# fivetran_connector.postgres:
resource "fivetran_connector" "postgres" {

This works as expected with 0.7.1.

@jramos did you follow migration guide https://registry.terraform.io/providers/fivetran/fivetran/latest/docs/guides/version_update_guides#migration-guide?
Or just updated the version in .tf file?

I have this problem too.  I had been on 0.7.2-pre and went to 0.7.2 today.
I had already updated / split the schedule out https://registry.terraform.io/providers/fivetran/fivetran/latest/docs/guides/version_update_guides#migration-guide
and this morning I reran terraform init -upgrade
previously working on 0.7.2-pre is not working on 0.7.2
Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: missing expected [
│
│   with fivetran_connector.braze_connector,
│   on braze.tf line 44, in resource "fivetran_connector" "braze_connector":
│   44:   config {
│
╵
╷
│ Error: missing expected [
│
│   with fivetran_connector.dynamodb_connector,
│   on dynamo.tf line 14, in resource "fivetran_connector" "dynamodb_connector":
│   14:   config {
│

the ddb connector
resource "fivetran_connector" "dynamodb_connector" {
  group_id           = data.aws_ssm_parameter.fivetran_group_id_external_id.value
  service            = "dynamodb"
  run_setup_tests    = true
  trust_fingerprints = true
  trust_certificates = true

  destination_schema {
    name = local.dynamodb_connector_name
  }

  config {
    aws_region_code = var.app_data_mapping.app_aws_region
    // this role is created by app-environment/cdk-data-fivetran after data-infra/tf-fivetran-bastion
    role_arn = "arn:aws:iam::${var.app_data_mapping.app_aws_account}:role/data/${var.app_data_mapping.app_instance}-${local.cross_account_target_bc}-v4-data-fivetran"
  }
}

the braze config
resource "fivetran_connector" "braze_connector" {
  group_id           = data.aws_ssm_parameter.fivetran_group_id_external_id.value
  service            = "braze"
  run_setup_tests    = true
  trust_fingerprints = true
  trust_certificates = true

  destination_schema {
    name = local.braze_connector_name
  }

  # bucket created in cdk-braze
  config {
    # s3_export_bucket = data.aws_ssm_parameter.fivetran_braze_bucket_name # only s3bucket
    s3bucket            = data.aws_ssm_parameter.fivetran_braze_bucket_name.value
    cloud_storage_type  = "AWS_S3"
    export_storage_type = "AWS_S3"
    s3folder            = "currents"
    # s3_export_folder = "currents" # only s3folder, no s3_export_folder
    # enable_exports = true # option dne
    api_url = "https://rest.iad-05.braze.com"
    api_key = data.aws_secretsmanager_secret_version.fivetran_to_braze_secret_value.secret_string
    # "s3_export_role_arn": "arn:aws:iam::376986651642:******",
    s3external_id = data.aws_ssm_parameter.fivetran_group_id_external_id.value
    s3role_arn    = data.aws_ssm_parameter.fivetran_braze_environment_role_arn.value
  }

}

@ann8ty

and this morning I reran terraform init -upgrade

so you were already on v0.7.2-pre, but re-ran terraform init -upgrade once more?
There was no need to do that actually, there's no schema breaking changes between this versions.
Anyway - it looks like v0.7.2 has some bugs, will investigate

@ann8ty UPD: reproduced the issue, investigating! Thank you for detailed description and example

@jramos @ann8ty
UPD:
Found the issue - the problem is with "fivetran_connector.config.servers" field.
It's type was changed from string to set of strings, but state migration not prepared in code.
To fix the issue you can manually update .tfstate file, replace the following lines:
"resources": [
    {
      "mode": "managed",
      "type": "fivetran_connector",
      "name": "connector_name",
      "provider": "provider[\"registry.terraform.io/fivetran/fivetran\"]",
      "instances": [
        {
          "schema_version": 1,
          "attributes": {
            "auth": [],
            "config": [
              {
               ....
               "servers": "" -> "servers": null
              ....
              }
              ...

for ALL connector resources defined in your config.
Another way is to de-grade back to v0.7.2-pre and wait for new v0.7.3 with fixed migration and migrate on-to v0.7.3 directly.
This won't affect those who created a new configuration using v0.7.2 - they will be able to migrate to v0.7.3 also without any issues.

v0.7.3 seems to be working nicely, thanks @beevital !

Same here, thanks @beevital!!!


Wall image upload

This PR should solve a few issues:

#382. The API can be tested independently by using any REST client like Postman.
#376 and #329. Image upload and saving.
#332
#330 Clearer design of content area of wall
#328

Needs a npm install in both root and oauth-proxy folders
Link for testing: http://aneesh-ojl02abl.cloudapp.net/wall

Where can we test it? Please provide a link to your server to see how things work.

Here http://aneesh-ojl02abl.cloudapp.net/wall
I am still working on the icons to display correctly, but apart from that everything else should work.

Checked, quite smooth! Bravo!

Choose Image does not work on test site for me.

Works in Chrome, not in Firefox. Fixes on the way.


Atriadhiakri2000 patch 1

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
YES
Description
(Write your answer here.)
Checklist

[ Y ] I've read the contribution guidelines.
[ Y ] I've checked the issue list before deciding what to submit.
[ Y ] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

@iamrajiv  Please check my pull Request


Customer feedback | az aks create (both Core & Extensino) |

Describe the bug
This GitHub issue is being moved from MicrosoftDocs/azure-docs-cli issue #4659 so the AKS service team can respond.
Engineering request

Please update the short-summary description for az aks create --service-principal parameter and provide more information.
Service principals can be application or managed identity. Don't assume the customer understands the difference and kindly state the type of SP this command is creating.
Consider providing a proving a link to the Entra ID article.

Type of issue
Outdated article
Feedback
regarding the parameter "--service-principal" the doc says that "If not specified, a new service principal is created and cached at $HOME/.azure/aksServicePrincipal.json to be used by subsequent az aks commands."
this is no longer the case if we create an aks cluster without specifying the parameter  "--service-principal" it will use system managed identity instead of creating a SP and make cluster use it.

Page URL
https://learn.microsoft.com/en-us/cli/azure/aks?view=azure-cli-latest
Content source URL
https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/aks.yml
Related command
az aks create
Errors
n/a
Issue script & Debug output
n/a
Expected behavior
n/a
Environment Summary
Azure CLI 2.65.0
Additional context
No response

Thank you for opening this issue, we will look into it.


Execution failed for task ':opencv:compileDebugAidl'.

What went wrong:
Execution failed for task ':opencv:compileDebugAidl'.

Could not read path 'C:\reactnative\ggg\node_modules\react-native-openalpr\android\libraries\opencv\build\generated\a�dl_source_output_d�r\debug\compileDebugAidl\out\org\opencv'.

why don't you answer here?

Sounds like the versions of SDK, Build Tools and Gradle Plugins doesn't match.
https://stackoverflow.com/questions/29766830/execution-failed-for-task-appcompiledebugaidl-aidl-is-missing


[backport-1.2] [FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo serialization

This is a backport of #3517 for release-1.2.

+1 to merge

@tzulitai The merge didn't close the PR :) I think the "this closes #xxx" thing only works for commits to master.

Thanks for the reminder :-D


Functional testing of Dockerfile and RAML on TravisCI

Coverage remained the same at 95.161% when pulling 1bba7fd1716fc5094ae4b865f846b29ed3cdc5db on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling efeec1141064b7b7352e6820699b520589466b16 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling 9100c042ee0325e6ef79188cb2ca94f5792d05ee on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling 1bc1cf67c45e4eb2a9d19e89a091eff8d64b9318 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling 72971d9b5229fb098958abcd7796417337fda271 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling 7b356de5b1f85585c9b4a512fb2b22d77974cd7c on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling 144fd3d0727972c3c3afbaa83b9cadb3ecc76ba4 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling efe5144e8decafaeab8917ab5faac3175c45057c on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling 5b8649208087076063a7d8066dd072e9cb5f2211 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling e8b6069df07fdc94b8674787ff40c3f000709513 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling dc3462d9468a8b10236189a3234b15fac6166225 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

Coverage remained the same at 95.161% when pulling c8dbac61624dd2f7fc280c206b00a3c44c6dbf05 on check-ceagle-dockerimage-on-travisci into a9c749969ed1ab25af83fd49625c5922d5658938 on master.

so this is really  awesome begging I have one comment, however it's not blocking I am merging this stuff.


Wallet Backup and Restore

ord wallet is actually really useful as a user-friendly alternative to bitcoin-cli, which can be obtuse, unforgiving, and unhelpful. For example, I'm having trouble exporting my bitcoin-cli wallet created through the tutorial. I think it's an HD wallet now, so dumpwallet won't work, but bitcoin-cli doesn't list its own help commands, and backupwallet fails and provides no reason why.
So, anyway, it might be nice for lazy users like me who like to just type ord help and ord wallet help, then I could type ord wallet backup ordinals-signet-wallet.txt and it saves either the mnemonic or something that can be used to restore the wallet.
It'd then be nice to have a restore command, and also a --dry-run option on the restore command so I can make sure it's all backed up. Or, maybe a better UX is if importing the same file to a wallet that's already loaded, it prints the message "wallet already exists. nothing changed.", letting the user know it's reliably backed up.

Great minds think alike! I actually just opened an issue suggesting that we should be able to backup and restore from a seed phrase, see #1063.

Nice! Your issue actually doesn't cover backup of existing wallets, however. Feel free to mix and match this issue with that issue, I suppose. Not sure what we should do with this issue.

Backup of existing wallets is challenging in general, I think. If we create a wallet, we can guarantee it's an HD wallet with a single root secret, which we can back up with a seed phrase. If it's an arbitrary bitcoin core wallet, then it could have multiple secrets, descriptors, etc.
I think that backing up existing wallets in a general way isn't possible easily, so closing in favor of #1063.

By the way, I really like the idea of making ord a good simple wrapper wallet for Bitcoin Core. Seems like there's a real need for that.

Well, if the xprv descriptor string is backed up to a txt file, that'd actually be an adequate substitute, imo. Maybe that could be the default behavior, and a mnemonic seed phrase could be optional.

I finally figured out how to export descriptor xprvs:
bitcoin-cli -signet -rpcwallet=ord listdescriptors true
Passing true toggles between xprvs and xpubs. I discovered this here, I'm not sure where else I'd find this documented:
https://github.com/bitcoin/bitcoin/pull/21500
I'd imagine if I just > this file to json, I could then import it with importdescriptors. I think that's basically what I had in mind.


PCL isn't a thing according to fsharp.org

According to fsharp.org

At the time of writing, creating portable libraries was not yet fully supported in IDES on Mac and Linux, though you can normally build portable libraries successfully using xbuild and command-line tools on these platforms. If you are developing on Windows, or using libraries on Windows, then consider creating portable libraries to ease cross-platfom use.

– I was looking for guidance on how to convert a library to PCL but found none. Only discussion about Visual Studio.
Ref https://github.com/logibit/Logibit.Hawk/issues/9

Portable libs are supported in Xamarin Studio

@haf We should really have a specific document on this at http://fsharp.github.io/
The project file fragments in http://fsharp.github.io/2015/04/18/fsharp-core-notes.html#examples-of-how-project-files-reference-fsharpcore-and-the-f-targets-file are a good start.

There should also be a checklist of where to find the alternative APIs and what the different numbers 78, 258 etc mean for library authors.


Output full path in JSON

A number of the results I've come across so far have been been in test type directories. If the full path to the file was available in the JSON it would make it quicker at a glance to easily dismiss results without having to track down the leak manually
Thanks

addressed https://github.com/zricethezav/gitleaks/releases/tag/v0.2.0


Missing messages in csv which are associated to images

I am using the compiled version for windows and for me it looks like all messages are missing in the csv export which were sent in combination with images.

Same problem.
The reason is that messages containing images are treated as MMS.  Signal creates several tables, namely "sms" and "mms", each with its own set of messages.  If signal-back only reads from the "sms" table we have a problem.

Same problem.
The reason is that messages containing images are treated as MMS.  Signal creates several tables, namely "sms" and "mms", each with its own set of messages.  If signal-back only reads from the "sms" table we have a problem.

Has anyone found a solution for this?

Maybe you might be interested to have a look at another tool: https://github.com/pajowu/signal-backup-decode
I use it to convert a Signal backup file into a sqlite3 database.  Then I parse the content of the tables with SQL queries to get a copy of both SMS and MMS messages.

Interesting! I will have a look


Swap convertStringToHTML with html-escaper module

I replaced the new convertStringToHTML function with the html-escaper module (GitHub repo).
According to the developer of this module:

do not ever replace one char after another if you are transforming a string into another

Because it might produce unexpected/unwanted results like this.

Sounds good, nice catch. I always end up with bizarre results when I'm
working with emojis in strings, so it'd make sense there would be a bug in
just "straight up" character replacement.

Thanks! Can we just copy over the escape function to lib/utils? Would prefer not to have an additional dependency for a small utility function.

Isn't the point of the npm ecosystem to add dependencies that can be
maintained instead of making one-off utils? I'm just curious what the
advantage would be.

That's the story of left-pad...

That's the story of left-pad...

Oh yeah, I remember this.
For those who are interested in reading about left-pad more, you can read the Arstechnica article and npm blog post.
I just imported the escape function locally and tested it.

LGTM, thanks!


[Chore] Setup Unit test

Why
To ensure the quality of the codebase and code performs as expected
Acceptance Criteria
Setup unit testing using Jest

Jest is already installed with the react template. This is the proof of work.
npm test

So I'll close this issue.