Make TypeUrl handling generic in ADS

This is part 1 of future PRs that will make more of the special logic we
have now in each type move to generic handling. This includes ACK, NACK,
nonces, versions, etc. For now I will keep a small diff and make it just
the TypeUrl
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Got it. I would translate v2 type to v3 - at some point we'll get rid of
v2, and then it'll be simpler.
For example - in 1.8 we could probably get rid of v2.
On Mon, Jun 22, 2020 at 7:18 PM John Howard<EMAIL_ADDRESS>wrote:

@howardjohn commented on this pull request.
In pilot/pkg/proxy/envoy/v3/model.go
https://github.com/istio/istio/pull/24877#discussion_r443923519:

const (
ClusterType  = resource.ClusterType
EndpointType = resource.EndpointType
ListenerType = resource.ListenerType
RouteType    = resource.RouteType
)
+
+var (

ListenerShortType = "LDS"
RouteShortType    = "RDS"
EndpointShortType = "EDS"
ClusterShortType  = "CDS"
+)

+func GetShortType(typeURL string) string {
comment explaining this is on the TypeUrl, probably should be here though.
Basically, we don't want to key by TypeUrl, because we should have the same
key for v2.Cluster and v3.Cluster. So this transforms typeurl -> key. We
could just translate v2 types to v3, I don't really care either way - its
all internal anyways
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/24877#discussion_r443923519, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2VXSTHWFNEQ2E7CZ3LRYAGIPANCNFSM4OFEARDA
.

Actually I forgot one other reason I had this - when we actually start making this more generic we will want the logs to still remain the same/similar (I think so, at least) like ADS:CDS: ACK...  etc. So the short type would be used there as well.
We could always have that be a different translation anyways though

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
44b4a67daa3a27cdf648d80048035a8d3bbe8436
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-security-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

lint_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

lint_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test lint_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-operator-controller-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

lint_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test lint_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
da6854d7da6b2f81d95eb3c2814fe994ef5d10d6
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

lint_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test lint_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test unit-tests_istio

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

lint_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test lint_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test release-test_istio

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-operator-controller-tests_istio

unit-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-ipv6-k8s-tests_istio

integ-galley-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
be7aef801cd2054c89a9f7d0a6394f2f00826920
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
b429943c2da9c5f0971cc5bed7ef4771e3b217b8
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
3dc4570b2ffb60bc0c851993833a994f9a7aeb10
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm there is a race because https://github.com/istio/istio/blob/f505ae645c2df97040fd0d2ad08e4113d13fb4d7/pilot/pkg/proxy/envoy/v2/internalgen.go#L94 reads the type url and its written on new connections. I don't really want to add a mutex for the connection, we have avoided it for this long. It would be fixed if internal gen followed the same pattern as the others where it enqueues a request which are then processed, but that's really a ton more overhead (we would add all N connections to the queue on every connection, even though we likely have 0-1 connections that need it). WDYT? Anyway we can avoid a mutex that I am missing?

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm there is a race because
https://github.com/istio/istio/blob/f505ae645c2df97040fd0d2ad08e4113d13fb4d7/pilot/pkg/proxy/envoy/v2/internalgen.go#L94
reads the type url and its written on new connections. I don't really want to add a mutex for the connection, we have avoided it for this long. It would be fixed if internal gen followed the same pattern as the others where it enqueues a request which are then processed, but that's really a ton more overhead (we would add all N connections to the queue on every connection, even though we likely have 0-1 connections that need it). WDYT? Anyway we can avoid a mutex that I am missing?

A mutex is cheaper than queuing all connections. I don't think we intentionally avoided using any mutex - the queue was
used to throttle and do stuff in background if I remember correctly.
On the other hand - if this starts getting used more it may end up having to scale and need same queue.
I would go with whatever is simpler/faster - this is right now an early experiment, no need to rush.

The mutex will impact the production code path though unless I duplicate the "watched resources" map as part of the prod code path and the experiment code path?

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test unit-tests_istio

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm to avoid making either part of the code worse, for now I just split them. We can converge in the future

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

lint_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

lint_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test lint_istio

integ-operator-controller-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

lint_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test lint_istio

integ-operator-controller-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

lint_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test lint_istio

integ-operator-controller-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

lint_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test lint_istio

integ-operator-controller-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

lint_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test lint_istio

integ-operator-controller-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

lint_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test lint_istio

integ-operator-controller-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test unit-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-ipv6-k8s-tests_istio

lint_istio
f3ddba4bb02d1414798c78505bee551539de8350
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

release-test_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test release-test_istio

integ-pilot-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
16d181e9f567da0bd709b8db324f92898f72c5cf
link
/test integ-multicluster-k8s-tests_istio

lint_istio
f3ddba4bb02d1414798c78505bee551539de8350
link
/test lint_istio

unit-tests_istio
f3ddba4bb02d1414798c78505bee551539de8350
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
6be702b79ee29f662adc221d7ebf15cd060bb54a
link
/test analyze-tests_istio

unit-tests_istio
f3ddba4bb02d1414798c78505bee551539de8350
link
/test unit-tests_istio

lint_istio
684cc8d4d07e0aed34927e0066c3aa15ecc58ad2
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


don't send expired JWTs

We might want to verify the JWT expiry date locally before sending to the server to query for data, then if there's a refresh_token stored locally we might be able to refresh it before making the request, or otherwise triggering a listenable event on the client
related: https://github.com/supabase/supabase/discussions/889
related: https://github.com/supabase/supabase-js/issues/178

I am still experiencing this issue with "@supabase/supabase-js": "^2.1.4" - I have only tried locally with "supabase": "^1.24.0", not in production.

If not fixed, with v2 there should be better behavior. We're not seeing problems on app.supabase.com or many other projects.
With #564 this should become even better. I'll close the issue now, do continue to comment if you have any further issues.
@cohlar Would you mind using the very latest v2 of the library. Do have in mind that if you're doing server side rendering there can be some confusing behavior that looks like this issue.


Add missing build dependencies

Add audit-libs-static so that static builds ("make binary") will work again, and add procps-ng so that unit tests that try to run "top" on Fedora will be able to run it (RHEL and CentOS images already include it by default).

Merged


updated links to pendo links, fixed a typo, remove anchor links that …

…were not working

@Hyperkid123 we had to update the links - they were opening up a blank new page

/ok-to-test


Creating two interfaces in same vlan and deleting one deletes both

I can't really be sure about this, because I totally lost access to the device and had to flash via serial, but these are the steps and what I was doing.
I use openwrt in a router for vlan tagging, I have the WAN interface tag all the traffic with 802.1q. In order to manage the port tagging, I have a management interface (MNG) in one of those VLANs.
I wanted to change from vlan 40 to vlan 50, and in order not to loose access to the device, and maintain the same interface:

created another interface (TMP) in the vlan 50, with an static IP.
accessed through the TMP interface to the luci config
moved the inteface MNG to vlan 50 with another static IP in the same net (and vlan)
accessed through the MNG interface to the Luci dashboard
removed TMP interface
lost access to either of both interfaces

I also noticed that in the interface overview, TMP and MNG had the same ips, which makes me suspect that though they appeared split in the interface, when I clicked to remove TMP, it deleted both interfaces.

Did you try rebooting after waiting a few minutes (to ensure config was written)?  It's possible the interface just went down and came back up.  Having multiple ip addresses to the same interfaces (e.g. eth1.50) works fine for me, and delete one interface only deletes that interface.  I'm wondering also whether you were using static IP addresses on the client or DHCP.

I am afraid that it has been so long that I no longer remember what happened, or whether this situation is reproducible any more...
I will close the issue


Add option for semicolon?

Hello, is there any setting to activate semicolon when generating snippets?

Ok, this is a duplicate,
sorry


[hotfix] Access token info icon fails to display because of extra quotation mark [#OSF-6321]

Purpose
Ensure that tooltips display correctly on "personal access tokens: create" page: http://localhost:5000/settings/tokens/create/

This fixes an issue where the quotation marks added around strings by sjson interfered with the quotation marks used to denote an attribute in HTML.
Changes
Replace the sjson | n filter (which trusted the string as given) with the entity filter. All possible strings for this field are plain text with no entities, apostrophes, or quotation marks.
Side effects
None expected, but if a scope description ever adds an apostrophe, it will render oddly for reasons outlined below. No current descriptions are affected by this. Long term we plan to use a different system of tooltips in future frontend code.
Weirdness documented
Origin: This field is strange because it looks like a javascript context, but behaves slightly different (at the mercy of knockout's parser). Normally correct HTML attribute escaping failed to work, and gave a "cannot parse bindings" error.
I tried removing the sjson, n filter entirely (so that apostrophes would be subject to regular HTML attribute escaping in mako's default filters). Even though the attribute value showed the special characters as an escaped apostrophe: ', it did not parse correctly in knockout.
Applying the entities filter double-escapes the string. The alternative would be to just use the n filter and treat the text as given (since the value is not user entered)... but this is fragile. If a scope description ever allowed apostrophes or quotation marks, the page would break in weird ways. I'd rather the failure mode be obvious and easy to correct with a text change.
Ticket
https://openscience.atlassian.net/browse/OSF-6321

🎉 🐧 🎉


A11y_Visual Studio Code Client_Menu bar Options_Screen reader: Narrator/NVDA is reading incorrect role for appearance & layout as "checkbox".

GitHubTags
#A11yTCS; #A11ySev2; #A11yMAS; #A11yWCAG; #DesktopApp; #Visual Studio Code Client; #WCAG1.3.1;#BM-VisualStudioCode-Win32-Nov2021;#Win32; #ScreenReader; #Element:listitem; #NVDA; #Narrator;#Win10; #AINotInscope;
Actual Result
Narrator/NVDA is reading incorrect role for appearance & layout as "checkbox".
Expected Result
Narrator/NVDA  should read correct role for appearance & layout as list item under view menu button.
Environment Details
Application Name: Visual Studio Code Client
Version:1.62.1 (user setup)
Windows Version: Windows 10  (21H1)
Repro Steps
1)Start Narrator/NVDA.
2)Open Visual studio code editor
3) Using "Alt+F" key navigate to the "File" menu bar option .                                                                                3)Using
4)"Alt+E" key navigate to the "Edit" menu bar option
5)Using "Alt+S" key navigate to the "Selection" menu bar option .
6)Using "Alt+V" key navigate to the "View" menu bar option
7)Using "Alt+G" key navigate to the "Go" menu bar option.
8)Using "Alt+D" key navigate to the "Help" menu bar option.
9)Using "Alt+T" key navigate to the "Tasks" menu bar option.
10)Using "Alt+H" key navigate to the "Help" menu bar option.
11) Using "Down" arrow key navigate to the menu items in the file menu option and observe that screen reader is announcing the correct label information.
User Impact
Screen reader users  will face difficulty as Narrator/NVDA is reading incorrect role.

@Shivanikupatkar thanks for filling this issue
@sbatten no need to read the long description. The problem seems to be that we are setting role=checkbox and aria-checked for submenu items in the main menu. This is incorrect. This is probably just a corner case from your fix https://github.com/microsoft/vscode/issues/120597

I have verified the fix indeed fixes the issue -> verified


Short build log

Today i've noticed the build log is not verbose as it used to be:
remote: -----> Python app detected
remote:      $ pip install -r requirements.txt
remote:
remote:      $ python manage.py collectstatic --noinput
remote: Verifying deploy......................................................... done.
To<EMAIL_ADDRESS>   d1111111..e111111  master -> master

What is missing is the output of bin/post_compile hook file, which contain a lot of useful information like migration and django-compress in our case, also this part is missing:
-----> Discovering process types
       Procfile declares types -> web
-----> Compressing...
       Done: 1.0M
-----> Launching...
       Released v1300
       https://app.herokuapp.com/ deployed to Heroku

However, the  Deploy -> build log in Heroku dashboard show the full build log with all the missing information

Seems to be fixed now


Add PlotX (PLOT) Info and Logo

Please check the following to ensure a successful verification of Token Profile
.json and .png document checklists

[x] logo dimensions: 120*120 px
[x] logo background: Transparent
[x] At least one transaction on the token contract
[x] For ERC-20 project teams: Upper and lower capitalized alphabets in token address (For checksum purposes)
[x] Same document name for both .json and .png (Including capitalization)

Project Background:
Project basic information: PlotX is a non-custodial prediction market protocol that enables users to earn rewards on high-yield prediction markets. Dubbed as the Uniswap of Prediction Markets, PlotX uses an Automated Market Making algorithm to settle markets and distribute rewards on the Ethereum Blockchain without any counterparty risk. Markets are focused on crypto-pairs like BTC-USD & ETH-USD and created in intervals of 4h, 1d, and 1w.
Project current situation: Beta on Ethereum Mainnet: https://app.plotx.io/
CoinMarketCap page: https://coinmarketcap.com/currencies/plotx/
CoinGecko page: https://www.coingecko.com/en/coins/plotx
Etherscan Page: https://etherscan.io/token/0x72F020f8f3E8fd9382705723Cd26380f8D0c66Bb
Media publications:

https://www.coindesk.com/investors-india-defi-scene-central-bank-ban
https://cointelegraph.com/news/looks-like-defi-is-coming-to-prediction-markets
https://www.newsbtc.com/all/former-nexus-mutual-and-govblocks-developers-launch-uniswap-for-prediction-market/
https://blockonomi.com/plotx-guide/

Tradeable exchanges: Uniswap, BitMax
Recommended Gas Limit for the transaction: 60,000
Website: https://plotx.io
Twitter: https://twitter.com/TryPlotX

Telegram: https://t.me/plotx_official

Logo需背景透明

Logo需背景透明

Okay. I’ll get it fixed.

@sfsy520 I have updated the Logo to the Transparent Background.

@sfsy520 All checks passed. Please check and let me know if there's still anything missing.

欢迎在社区中推荐用户使用 imToken 2.0 ，imToken 支持比特币, 以太坊, Comos, EOS, 波场, Nervos, 比特币现金, 莱特币，波卡等资产管理；同时支持去中心化币币兑换功能 Tokenlon；转账页面支持 ETH, USDT, EOS, BTC OTC 功能；另外对于没有 ETH 矿工费的用户，也提供 ETH 手续费充值功能。


Add ponyfill link to Declarative Shadow DOM

That’s pretty much it :octocat:

Thanks!

It’s not that important. But could you add the HACKTOBERFEST-ACCEPTED label to this PR?
Thanks anyway :octocat:

Hmmm okay


Alt+Arrow keys seems not to work in Windows Terminal Preview (nor VSCode integrated terminal)

I tried setting shortcuts to Alt-Arrowkeys and nothing seems to happen. I use the Windows Terminal Preview (https://github.com/microsoft/terminal) and the VS Code integrated terminal. I'm not quite sure how we could debug this yet, but I'm a Go developer and I'm happy to debug on my own if you could give me some pointers as to where to look :)

@Xjs, What do you mean by "setting shortcuts to Alt-Arrowkeys"? Do you mean creating a key binding such as
edit:insert:binding[Alt-Left] = { echo "WTF" >/dev/tty }

in your ~/.elvish/rc.elv?
What Elvish version were you using? Which MS Windows version? Which version of that third-party "terminal" app?
More importantly, I can't figure out if VS Code is even relevant. You linked to a third-party terminal emulator. Does the problem manifest itself if you run elvish inside that terminal emulator but outside of VS Code?

@krader1961 thanks for your reply. I'll try to clarify.
I have the following bindings configured in my ~.elvish\rc.elv:
edit:insert:binding[Alt-Left] = $edit:move-dot-left-small-word~
edit:insert:binding[Alt-Right] = $edit:move-dot-right-small-word~

I can reproduce the issue with elvish v0.14.0-143-g5ec11cfe (built from 5ec11cfe2bf91b8b385cd995527e8935ff7180c5 just now).
The issue occurs both in the Windows Terminal and VS Code's Integrated Terminal (which AIUI are two distinct terminal emulators but it could be that they use similar APIs, I don't know a lot about this).
I can reproduce it using the Windows Terminal from the Microsoft store, apparently the version number is 1.3.2651.0.
I can reproduce it as well using VS Code's integrated terminal in VS Code 1.50.0-insider (0580328b).
My Windows version is Windows 10 Pro Insider Preview 2004, build 20221.1000.
All those version numbers are very volatile and it never worked with any version I used ;)
FTR: In the legacy Windows terminal (Conhost.exe) the alt-arrowkey bindings do work. In the two terminals I use, both Ctrl-Arrow and Ctrl-Alt-Arrow work and can be distinguished.

Dealing with all the minutiae of legacy terminal emulations is hard. :smile: The core issue is there are multiple, wildly used, terminal emulations that provide a different answer when pressing Alt-arrow-key. I tested Terminal.app and iTerm.app on macOS, and the Msys2 terminal and the command.exe terminal on Windows. Pressing Alt-Left produced one of the following sequences depending on the terminal:

\033[B (Terminal on macOS)
\033[1;9D (iTerm on macOS)
\033[1;3D (Windows)

It seems likely that the "VS Code integrated terminal" emits something other than the sequence I observed on Windows (item three above). On UNIX platforms I run something like od -tx1z to see what sequence a particular key sends. Not sure what to propose as an equivalent inside the VS Code integrated terminal. But it seems likely that Elvish might need some tweaks to recognize multiple sequences that map to each Alt-arrow-key.


Fix broken link + typos and add 0.3.3 as stable version

There's a failing doc test somewhere in the CLI and I have no idea why, but that's from something I've done, so this is good to merge!


Improve metrics docs to describe how to configure metrics using helm

This page currently lacks instructions about how to enable/disable the metrics using helm:
https://docs.cilium.io/en/stable/operations/metrics/#exported-metrics
The prometheus.metrics option can be used to configure this for the cilium metrics. See the reference here:
https://docs.cilium.io/en/stable/helm-reference/
It would be useful to have a brief description about how to use prometheus.metrics while installing/upgrading Cilium in order to enable the metric.

@bharitwal sure, I'll assign you.

@joestringer Is this issue still up for grabs?

Yep, feel free to post a PR and link to this issue in the PR.

https://docs.cilium.io/en/stable/operations/metrics/#exported-metrics

@joestringer, I could not find how to edit this page. Could you please help me ?


Update readme.md

@ArtsemKazimirau Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Resolved : [TextInput] Auto correction doesn't call onChangeText after submit #2552

Hi There ,
This is my first ever attempt for pull request in react-native. Im very happy to be part of it.
We were having an issue regarding TextInput onChangeText call when user selects value from auto correction.
onChangeText doesn't get called was the issue.
So solution for that could be just add a function call to textFieldDidChange in method textFieldEndEditing.
[self textFieldDidChange];
So it will look like,

(void)textFieldEndEditing
{
[self textFieldDidChange];
[_eventDispatcher sendTextEventWithType:RCTTextEventTypeEnd
reactTag:self.reactTag
text:self.text
key:nil
eventCount:_nativeEventCount];
}

Thanks,
RD.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

By analyzing the blame information on this pull request, we identified @lacker and @RetroPoktan to be potential reviewers.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

You didn't set up the pull-request correctly, can you send a new one?


server security checklist

For any servers we run exposed to the Internet (e.g. Quiver):

Automate security updates
Disable password-based SSH login
Set up fail2ban
Drop packets originating from unrecognized networks, e.g. anything that isn't Google (so we can SSH in) and for Quiver, anything that doesn't come from the CDN whose domain is being fronted
Make sure anyone whose DigitalOcean/AWS/etc account has access to the server has 2FA set up (or at least a strong password)

Please add anything I missed

Can we switch this from an issue to a wiki page?

@jpevarnek Good idea, updated the title and description. My thinking in leaving this open though is it also represents concrete work we should do for our extant public-facing (e.g. Quiver) servers.

I already got through implementing most of the stuff on https://github.com/uProxy/uproxy/wiki/Server-Security-Checklist for one of our Quiver servers, and was hoping to look at incorporating those changes back into the docker image for them soon.

ref: uProxy/uproxy-docker#71 -- looks like that added the unattended-upgrades package but we still need to add config to enable them

Closing as we've now enabled unattended upgrades and the rest is not a priority right now.


Lines converted to points when georeference by lon/lat without warning

I'm opening this issue about a little "comment" that I realised while I was testing. It's not important, but I think that it would be useful in case you (@CartoDB/Design) want to think about this in the new editor design.
The issue is that if you have a lines dataset and you click on georeference by lon/lat (for example with a new row), all the dataset is converted automatically, without any warning. And then, you can't "undo" (at least easily) and having your "clear" lines dataset.
Steps to reproduce:

Import a lines dataset.
Create a new row (optional).
Click on Georeference by lon/lat.
-> Result: All rows are points.

Gif:

My opinion is that it's not a bug; but, at least, the user should be warned about the fact.
So, my "proposal" is that a modal window should appear in cases like this (when your data is going to change) .

Yep, you can close it, we already took care of this :)
Thaaaanks!

Oh, great! :clap:
thank you too!


[AKS] az aks check-acr: Append acr suffix to option --acr acording to cloud env

Related command

az aks check-acr
Description

Based on the changes in PR #23505, now the acr suffix is appended according to current cloud env.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

AKS


How can I go back to the previous version?

Hello, after updating to the latest version, the similarity of the characters has decreased. How can I return to the previous version?Thanks.

duplicate https://github.com/cubiq/ComfyUI_InstantID/issues/48


[fix] dark mode logo version

Description

Fix the dark mode logo issue

Issue Ticket Number
Fixes #496

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Fix or improve the documentation
[ ] This change requires a documentation update

Checklist

[x] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[ ] I have created an issue ticket for this PR
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have performed a self-review of my own code
[ ] I have run tests locally to ensure they all pass
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes needed to the documentation

works perfectly, thanks @HarshitVashisht11
Thanks for your contribution! Because it was made in October, you're eligible for some Hacktoberfest swag. Please send me an email with your name, GitHub username, and link to this PR to<EMAIL_ADDRESS>where I'll provide further instructions. Happy Hacktoberfest!

@all-contributors please add @HarshitVashisht11 for doc


[BEAM-3713] Add pytest option to run_integration_tests

DO NOT MERGE, for testing only
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.