split template into 2 opinionated runtimes: AccountId20 + AccountId32

Motivation
Ever since the merge of https://github.com/paritytech/frontier/pull/1019/ , we have the option of using AccountId20 as the native account type. The PR applied this new type into frontier-template-runtime, overwriting all the previous configurations for AccountId32.
Suggested Solution
As discussed in https://github.com/paritytech/frontier/pull/1053, ideally there should be two template runtimes, so that newcomers can become familiar with the fact that both approaches are viable options (and how to use them correctly).
I thought this was going to be pretty quick to implement, so I started writing a solution.
I soon learned that the implementation wasn't going to be as straightforward as I initially thought. So I'm writing this issue to summarize my findings, so that I (or someone else) can try this again with more available time in the future.
The goal is making the template directory look like:
template
├── ...
└── runtime
    ├── accountid20
    │   ├── Cargo.toml
    │   ├── build.rs
    │   └── src
    │       └── lib.rs
    ├── accountid32
    │   ├── Cargo.toml
    │   ├── build.rs
    │   └── src
    │       └── lib.rs
    └── common
        ├── Cargo.toml
        └── src
            ├── lib.rs
            └── precompiles.rs

Here's a list of crates that would also need to be refactored (additionally to template/runtime):

fc-mapping-sync: references to frontier_template_runtime::RuntimeApi inside unit tests.
fc-cli: references to frontier_template_runtime::RuntimeApi inside unit tests.
template/node: multiple modules with references to frontier_template_runtime::*.

These can be solved with something like:
#[cfg(feature = "accountid20")]
use frontier_template_runtime_accountid20 as frontier_template_runtime;

#[cfg(feature = "accountid32")]
use frontier_template_runtime_accountid32 as frontier_template_runtime;

...

These documentation files should also be modified accordingly:

docs/accounts.md
template/README.md

PR #1061 was closed in favor of #1186
the approach there is different from the one originally proposed on this issue
in fact, it is much simpler
it simply introduces one extra feature (unified-accounts) without creating two separate template runtimes.


Listeners return a value, so that the value can be used...

… in the case of synchronous listeners

I think this could be a bad idea since it would break for framed or merged listeners and would prevent you from making a listener async without breaking things.
What do you need this for (DOM listeners?)?

Yes. Listeners returning values is used in SMW.


Style the TopNav and SidebarNav

Summary
As an admin, I would like the layout of InKind to look good.
Things to Consider
This PR embodies updating the colors/fonts/icons/proportions for the layout of this application. Not the styles in the main body of the page (from the mockup).
Dark purple color in top nav bar is: #311B92
Light purple color for a selected item in the sidebar is: #EDE7F6
If you have trouble finding/getting the exact icons, reach out for help in the #team-inkind Slack channel.
There are no notifications yet, so leave off the bell icon in top right corner for now.
The hamburger dropdown icon is in there, and pops when the page shortens to ipad/mobile size. But it's black and hard to see. And clicking it reveals the avatar link instead of the sidebar links. Fixing this is a bonus, but not a hard requirement that prevents other styling improvements from shipping first.
Criteria for Completion

[ ] Colors and sizing matches the attached mockup
[ ] Icons in the sidebar nav match the mockup (these are Fluent icons)
[ ] Change "Dashboard" nav title to "Home" (only Home, Volunteers, Students, Admins & Tickets exist so far)

Can I have a look at this issue?

Here's a slightly newer version. Looks like a some small difference that the "Built with Love by Ruby for Good" is now in the left nav (it should be there already). And when a nav item is clicked, the text & icon becomes a darker purple.
Feel free to give this a shot. But also know there's no need to get everything done in one pass. Since this project is still pre-MVP, I'm looking to merge anything that represents a step in the right direction.


can't import generators

First I got this response:

Python 3.5.2 (default, Nov 17 2016, 17:05:23)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.

from sknano.generators import SWNTBundleGenerator

/usr/local/lib/python3.5/dist-packages/sknano/core/refdata/element_data.yaml
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.5/dist-packages/sknano/generators/init.py", line 59, in
from ._base import *
File "/usr/local/lib/python3.5/dist-packages/sknano/generators/_base.py", line 19, in
from sknano.core.atoms import StructureAtom as Atom, StructureAtoms as Atoms
File "/usr/local/lib/python3.5/dist-packages/sknano/core/atoms/init.py", line 113, in
from ._atoms import *
File "/usr/local/lib/python3.5/dist-packages/sknano/core/atoms/_atoms.py", line 21, in
from sknano.core.refdata import atomic_masses, atomic_mass_symbol_map,
File "/usr/local/lib/python3.5/dist-packages/sknano/core/refdata/init.py", line 45, in
from ._element_data import *
File "/usr/local/lib/python3.5/dist-packages/sknano/core/refdata/_element_data.py", line 21, in
'element_data.yaml'))
File "/usr/local/lib/python3.5/dist-packages/sknano/core/_io.py", line 299, in loadobj
kwargs["Loader"] = Loader
NameError: name 'Loader' is not defined

I checked out the "_io.py" and realised I need something like "yaml" to define "Loader". This was not obvious from the output...
Then I googled and installed the following:
$ sudo pip3 install pyyaml
Now it forwards to less files but still doesn't work:

Python 3.5.2 (default, Nov 17 2016, 17:05:23)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.

from sknano.generators import SWNTBundleGenerator

Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.5/dist-packages/sknano/generators/init.py", line 59, in
from ._base import *
File "/usr/local/lib/python3.5/dist-packages/sknano/generators/_base.py", line 19, in
from sknano.core.atoms import StructureAtom as Atom, StructureAtoms as Atoms
File "/usr/local/lib/python3.5/dist-packages/sknano/core/init.py", line 128, in
from ._io import *
File "/usr/local/lib/python3.5/dist-packages/sknano/core/_io.py", line 298
return yaml.load(fp, *args, **kwargs)
^
IndentationError: unindent does not match any outer indentation level

What to do?

I have met the same problem.
Just try (sudo or not)
(1) pip uninstall scikit-nano
(2) pip install pyyaml
(3) ip install scikit-nano


convert prefetched values generator to reusable iterator

One way to address the issue I opened last week: https://github.com/graphite-project/graphite-web/issues/2318

Codecov Report

Merging #2322 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##           master   #2322      +/-   ##
=========================================
- Coverage   79.62%   79.6%   -0.02%
=========================================
  Files          85      85
  Lines        8847    8850       +3
  Branches     1893    1894       +1
=========================================
+ Hits         7044    7045       +1
- Misses       1544    1545       +1
- Partials      259     260       +1

Impacted Files
Coverage Δ

webapp/graphite/render/datalib.py
98.55% <33.33%> (-1.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7244a2c...cd90bd2. Read the comment docs.

Need to dig into this a bit and make sure there's no performance regression

I'm pretty sure this will have performance regressions. Doing it in two loops (first getting all the generators, then expanding them) would maybe work.

Thanks, I'll move the generator expansion to render.evaluate.evaluateTargets and
I'll try to add a meaningful test too.  If only the rrdtool backend is returning values in
a generator maybe it'd be better to address this there?

 I won't have a stable  internet connection in the next three weeks so I can't validate your patch, but it looks like it would work (maybe add some code comments to explain why it is done this way).
Thanks

Is it OK to merge that? @DanCech @iksaif ?

I think it's still missing comments to explain why it is done this way. Else it's likely that the code will be changed again at some point.

I've added a brief comment explaining the change.


Add a C bindings generator

This commit adds the initial implementation of a C bindings generator. The intention for this generator is to be a second implementation of a "guest" language compiled to WebAssembly. The hope is that this is developed alongside the Rust implementation to ensure that anything implemented in one can also reasonably be implemented in the other.
Lots of plumbing to put things in the right places here. I haven't paid too too much attention to C idioms or customizability, but I presume those can come over time.

:+1: Good job!


Animate #testSuite to focus user on errors

Challenge Name
This applies to any challenge that has the button [Run tests]
Issue Description
For a new user clicking multiple times in the [Run tests] button looks like nothing is happening.
We should animate the div that contains the errors ( #testSuite ) to let the user know that something is wrong
Browser Information

Browser Name, Version: Google Chrome V51
Operating System: Win 10
Mobile, Desktop, or Tablet: Desktop

Hello

@katrina562, hey :wave: :joy:

Hi


Implement color inheritance and background colors

This PR implements color inheritance as requested in #14, #5
A new option is added in the settings to enable inheritance. If enabled, then if a color is set on a folder, all the children will inherit the same color. Colors set on children will override the parents.
The only slight downside is that if people go crazy with setting colors, it may be difficult to determine which files have colors set. I think it's not a big issue though, since the first different color in the folder hierarchy is the one that has a color set.

I also added ability to color the background instead of the text. #3
The two new options look like this:

Samples:
Background color on, no inheritance:

Background color on, with inheritance:

Background color off, with inheritance:

Background color off, no inheritance (same as the original):

I haven't worked with Typescript before and couldn't quickly figure out how to get proper typing for some things, so I didn't add a new component for the toggle area. Hopefully that's okay.

Hey, I just wanted to say I really appreciate the contribution. I'll take a look at it over the weekend, and see about getting it merged.

@ecustic changes done. I feel that "cascading colors" is better than "inherit colors" so I swapped out the naming in the code for that. I tested all 4 combinations and everything looks good :+1:

Super cool, thanks for adding this!
On my personal wish list would be the option to have it work different for files and folders. That is: To optionally have all folders use the background coloring, but all files just the name coloring. Or a little border maybe. Because currently I find them hard to distinguish on a glance.

@Thomas-Schmall you're welcome!
Isn't it the same as the behavior without this plugin? The way to distinguish files and folders is the little dropdown icon to the left of the folder. I think a CSS snippet might be best for you to accomplish this.

Isn't it the same as the behavior without this plugin?

Not sure I follow. Without the plugin either there are no colors or in some themes there are random default colors for the top folders. The good thing about the second version is that the distinction is clearer.
There are gray drop-down icons - but they're hard to see on a glance.

I think a CSS snippet might be best for you to accomplish this.

Yeah, I was just musing on how I would like it in my dream world 😅 Ideally one could see with one look what is files and what is folders - and what is the top level. I was trying hard, but with my limited CSS knowledge I found no way to clearly select the top nodes vs the child nodes in the file tree. They're not clearly tagged.
There is also some bug in Obsidian that makes the indentation styling jump around. When I have time I'll write them a bug report.

@Thomas-Schmall you can use this CSS to apply styles to top-level folders:
.workspace-leaf-content[data-type="file-explorer"] .nav-files-container .mod-root > .nav-folder-children > .nav-folder > .nav-folder-title {
    border-style: solid;
    border-width: 1px;
    border-color: black;
}

The > indicates "direct child" so that not all children recursively get the styles. Probably "top level folder styles" could be its own plugin rather than a file color plugin, but that's just me.
You can also make the collapse icon a more bright, distinct color to help distinguish folders from files:
.collapse-icon svg.svg-icon {
   color: #FF0000;
}

This is exactly what I was going to ask for. Thanks @eblanshey !

@eblanshey Thank you so much for the CSS! This is awesome. It works nicely for quick-glances.
I used it to color the border for sub-folders. And files just get the name colored.
I've put a screenshot of my implementation in the other thread (not to clog this one).

I've encountered this too, thought it was an issue with the theme, but probably not. Please report it!

Will do.

@eblanshey / @ecustic  any updates? Can folks help in any way? These changes would be a great addition to the plugin.

Hey, I'm also quite a bit short on time, and don't really use the plugin anymore. Would you be willing to update the code yourself? Your suggestions are sound. We can merge this into a development branch, if you'd like?

Hey, I'm also quite a bit short on time, and don't really use the plugin anymore. Would you be willing to update the code yourself? Your suggestions are sound. We can merge this into a development branch, if you'd like?

Sure, let's retarget this PR to the feature/color-cascade branch, merge it and I'll take it from there.


How to run the service？

i want to try run it in ubuntu 23.04 and pfsense.
how i do run it with service?

Hello, @liuxyon!
Deploying on Ubuntu and other Linux distros with systemd
1. Install the binary
Put compiled dtlspipe binary to /usr/local/bin/dtlspipe
2. Create systemd unit
Put file with following contents into /etc/systemd/system/dtlspipe-server.service:
[Unit]
Description=dtlspipe server
Documentation=https://github.com/Snawoot/dtlspipe/
After=network.target network-online.target
Requires=network-online.target

[Service]
EnvironmentFile=/etc/default/dtlspipe-server
DynamicUser=yes
StateDirectory=dtlspipe
Environment=HOME=%S/dtlspipe
ExecStart=/usr/local/bin/dtlspipe $OPTIONS
TimeoutStopSec=5s
PrivateTmp=true
ProtectSystem=full

[Install]
WantedBy=default.target

3. Create configuration
Put file with following contents into /etc/default/dtlspipe-server:
OPTIONS=server <IP_ADDRESS>:2815 <IP_ADDRESS>:56218
DTLSPIPE_PSK=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

where OPTIONS are corresponding command line arguments and DTLSPIPE_PSK is PSK. We pass it as an env variable to hide it from process command line in the process list like ps -ef.
Set actual listen address instead of <IP_ADDRESS>:2815.
Set actual destination UDP endpoint instead of <IP_ADDRESS>:56218.
4. Enable and start the service
Execute following commands as root:
systemctl daemon-reload
systemctl enable --now dtlspipe-server

Deploying on pfSense
You'll need to put binary somewhere as well, e. g. to /usr/local/bin/dtlspipe.
Then you should auto start it with arguments as you need. Here is pfSense documentation how to do it: https://docs.netgate.com/pfsense/en/latest/development/boot-commands.html

this tool is use DTLS1.3 version?

No, it operates DTLS1.2 only

Can you clarify how the various run option parameters are written in the configuration file?

Note that dtlspipe itself has no configuration files, it accepts only command line arguments. All files above are actually SystemD files: unit file and env file with options. Please refer to systemd documentation for further reference.
In systemd case above words from OPTIONS go as is to command line arguments of startup command /usr/local/bin/dtlspipe $OPTIONS. That means, in that example actual command line will be run is: /usr/local/bin/dtlspipe server <IP_ADDRESS>:2815 <IP_ADDRESS>:56218, which corresponds to command line for server operation.
If you need to add option -skip-hello-verify, then your /etc/default/dtlspipe-server will look like this:
OPTIONS= -skip-hello-verify server <IP_ADDRESS>:2815 <IP_ADDRESS>:56218
DTLSPIPE_PSK=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

@liuxyon not sure if nohup is needed at all, maybe you can even get away with /root/dtlspipe/dtlspipe.freebsd-amd64 client ... ... > /dev/null 2>&1. But yes, you got the idea. It may take a bit of experimentation, though.

And once again, it does not support config files, only command line arguments. See Usage and Synopsis section of documentation.

thanks! The connection is successful using ipv4, is it possible to connect using ipv6? server [::]:2815 [::1]:56218 it is right?

Yes, you may use any combination between endpoints. E.g. [::]:2815 <IP_ADDRESS>:56218 will work as well.

In addition, I would like to know how many additional data headers MTU will be added using DTLS?

It might be dependent on negotiated ciphersuite, but last time I checked I think it was between 29 and 81 bytes. So, I guess, subtract 100 from MTU for a good measure. Or check with tcpdump/wireshark exact numbers.

how i get list of DTLS1.2 ciphers ?

With dtlspipe ciphers command. It's mentioned in help.

What is used by default ciphers value？

By default ciphers list from dtlspipe ciphers subcommand are used. Client and server negotiate first common cipher from their lists (which can be set with -ciphers option).

When can I upgrade to DTLS1.3? now i am using WG MTU 1390 for test.
Options: -ciphers value
I saw some articles writing that DTLS1.3 has better performance https://www.wolfssl.com/whats-new-dtls-1-3/ https://inria.hal.science/hal-03035402/document

DTLS 1.3 will be available when pion/dtls library will support it.

client side use ipv6 show wrong: /root/dtlspipe/dtlspipe: No match. it is can't run. use remote ipv4 is normal.

I tested, works for me.

Check if PSK key on server and client are the same.
Check if server is reachable via IPv6 at all:

Check if firewall doesn't prevent access on this port
Check if IPv6 address is added on interface of your server machine. It may happen that IPv6 is enabled in the hosting panel, but still not enabled on machine itself.

You may also try to check IPv6 both on client and server machine with following command: curl https://api6.ipify.org. It should output public IPv6 address.

Here it shows that PSK is weak. Is it considered more secure?

It lacks perfect forward secrecy, but still good. Or, If you really need that property, use TLS-ECDHE-PSK-WITH-AES-128-CBC-SHA256.

In addition, how to deploy services on windows 11 ,windows server 2022 and andriod system？

Deploying on Windows as a background service
Method 1
Use task scheduler to run command in background: https://pureinfotech.com/prevent-command-window-appearing-scheduled-tasks-windows-10/
Method 2
Use simple VBS wrapper to run a program without window: https://superuser.com/questions/1168587/how-to-run-an-exe-application-as-a-background-task-on-startup/1619817#1619817
Method 3 (best option)
Use NSSM to run any command as a service: https://nssm.cc/usage
Method 4
Use srvstart to run any command as a service: https://github.com/rozanski/srvstart
Deploying on Android
Just use some terminal emulator to run a command. One convenient option is Qute, which has shortcuts and autostart, as far as I remember.

Just run multiple instances of application.

https://fedoramagazine.org/systemd-template-unit-files/

what's i do change the dtlspipe-server.service?

1. Cleanup old unit
systemctl disable --now dtlspipe-server

2. Rename file /etc/systemd/system/dtlspipe-server.service to<EMAIL_ADDRESS>3. Make its content look like this:
[Unit]
Description=dtlspipe server
Documentation=https://github.com/Snawoot/dtlspipe/
After=network.target network-online.target
Requires=network-online.target

[Service]
EnvironmentFile=/etc/default/dtlspipe-server-$i
DynamicUser=yes
StateDirectory=dtlspipe
Environment=HOME=%S/dtlspipe
ExecStart=/usr/local/bin/dtlspipe $OPTIONS
TimeoutStopSec=5s
PrivateTmp=true
ProtectSystem=full

[Install]
WantedBy=default.target

Note that EnvironmentFile is now parametrized by name of instance of dtlspipe.
4. Apply systemd configuration
systemctl daemon-reload

5. Create environment files (configs) for each instance
For example, let's say we need two dtlspipe instances for Alice and Bob. Then we need to create following files:
/etc/default/dtlspipe-server-alice:
OPTIONS= -skip-hello-verify -timeout 60s -ciphers TLS-ECDHE-PSK-WITH-AES-128-CBC-SHA256 server <IP_ADDRESS>:39883 <IP_ADDRESS>:39781
DTLSPIPE_PSK=XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

/etc/default/dtlspipe-server-bob:
OPTIONS= -skip-hello-verify -timeout 60s -ciphers TLS-ECDHE-PSK-WITH-AES-128-CBC-SHA256 server <IP_ADDRESS>:39885 <IP_ADDRESS>:39782
DTLSPIPE_PSK=YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY

6. Enable and start Alice and Bob instances
systemctl enable --now dtlspipe-server@alice

systemctl enable --now dtlspipe-server@bob

good idea!

made a typo: it's %i instead of $i. I updated the comment.

https://t.me/dtlspipe


Tries to install html-webpack-plugin-loader if ^2.21.0

If html-webpack-plugin ^2.21.0 is installed (tested with 2.26.0), npm-install-webpack-plugin tries to install it as a loader. Interestingly 2.21.0 works just fine. A release after that broke the behavior as it gets detected improperly.
To make this easier to debug, I set up a repository. npm install and npm start to get
Installing html-webpack-plugin-loader...
npm ERR! Darwin 16.3.0
npm ERR! argv "/usr/local/Cellar/node6-lts/6.9.1/bin/node" "/usr/local/bin/npm" "install" "html-webpack-plugin-loader" "--save"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code E404

npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/html-webpack-plugin-loader
npm ERR! 404
npm ERR! 404  'html-webpack-plugin-loader' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

To be more accurate, it looks like html-webpack-plugin 2.25.0 is the first broken version. So something changed in between 2.24.0 and 2.25.0 that broke the behavior.

Here is a diff between the versions. I hope that helps.

I see now. html-webpack-plugin has a line like this now:
template = 'html-webpack-plugin/lib/loader.js!' + path.resolve(context, template);

So it actually has a loader inside. That's why npm-install-webpack-plugin logic triggers the way it does I think.
I wonder if there's a good way to detect this type of case.

Got it. resolveLoader gets result.request like this html-webpack-plugin/lib/loader.js.
I would suggest checking whether or not that file exists in the file system (fs.exists or so against node_modules). If it does, then installing can be skipped.

I'm also seeing this with a fallback in place to account for what html-plugin is now doing. Will investigate further.
    // As of v2.25.0, html-webpack-plugin no longer outputs an absolute path to
    // its loader, so we must fall back to nwb's node_modules/ for global usage.
    resolveLoader: {
      fallback: path.join(__dirname, '../node_modules'),
    },

Making NpmInstallPlugin#resolveLoader() behave more like NpmInstallPlugin#resolveModule() fixes this for me:

https://github.com/insin/npm-install-webpack-plugin/commit/c748308fdc3eb166b571d2a1bcf55d6343d5de15

I'm assuming my change gives Webpack a shot at resolving the loader first, allowing it to use your resolveLoader config?
Does this seem correct to someone more familiar with what Webpack is doing? I can fix the tests and create a PR if so.

@ericclemmons How do you want to move with this? Should I prepare a little PR with the check outlined above? Any better ideas? Also what @insin mentioned could be worthwhile.

@bebraw @insin's fix seems to be the best way to resolve it, IMO:

https://github.com/insin/npm-install-webpack-plugin/commit/c748308fdc3eb166b571d2a1bcf55d6343d5de15

With the way things have been going with webpack2, loader & module resolution should work largely the same...

@ericclemmons Awesome.


Unlabeled filter field in main spec page

The main spec page has an unlabeled filter field at the very end of the main spec table. It is able to include obsolete revisions in the search results.

I pulled the changes and it's working now. Not sure what happened since it didn't look like there were any changes to the UI code apart from rearranging some lines.


fix(color): change parse error message to single color

Found while enabling https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_result_states

These messages should be lowercase.

Thought about that too, but it's about the struct Color.

These messages should be lowercase.

Thought about that too, but it's about the struct Color.

Failed -> failed

My main intention was to enable this lint and fix the mistake of outputting colors instead of color. As this seems to be more complicated about stuff I don't use in the first place (= don't care much about it) I'll just close this.


Removed UDP where it is not used

The port list also describes whether TCP or UDP ports or both are required. The list is wrongly says UDP is required in some cases. Especially, UDP does not support TLS, so in these cases, UDP is certainly not used. Fetching CRLs over HTTP (port 80) also does not use UDP.
The remaining cases where UDP is in the list may be correct, but may also be incorrect. I have not found convincing evidence that UDP is not used in these cases.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bb-froggy sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@bb-froggy : Thanks for your contribution to the Azure documentation! The author, @billmath, has been notified to review your proposed change.

Fixes MicrosoftDocs/azure-docs#6012

@Billmath please take a look at this and sign-off if it makes sense.

@bb-froggy We went over this pretty thoroughly when it was created so I am going to have to verify this with engineering.  I have created a work item for this, as it may take a little while.  Once I hear back from them and they are okay with merging then we can re-open this and merge.  Thanks!
#please-close


Highlights and icons in BugPathView

Checker messages resulting from functions deeper down the call stack will have different background to easily distinguish function blocks.
Certain common checker messages are given custom icons (Calling, Entered call, Loop actions, assumes)
Better generic iconization for bug categories (compliant to usual severity colouring schemes) and messages (instead of plain :file_folder: and :page_facing_up:)
If the BugPath only contains one line (such as the case with deadcode.DeadStores and most of clang-tidy), don't show the result two times)
Filenames are not shown if the BugPath is restricted to a single file only; and if not, the too long filenames are cropped.

Note! The severity categories not having any bugs as children are only shown on the images for demonstration purposes, the code still hides empty categories.

The icons used in this change are subset that of FontAwesome.
(closes #560)

@Xazax-hun wrote:
Maybe these string could be separated into a JSON instead of being hardcoded?

I disagree. Depending on where we read the JSON file, we will always end up having an extra HTTP request for the file itself, which could, at the wrong place, tremendously hinder the experience...
... unless we put the JSON into one of the JS files itself.
But with this route, we also have a problem: the match rules are not simple, and because this is an initial implementation, I am not expecting them to be simple as we discover further "common" _bugevent_s. As you can see in this code, we have matches where (to prevent multiple string matching), we need to extract a token, sometimes we match a substring (where the behaviour of else if is neccessarsy, as Assuming is a substring of Assuming the condition), and at some places because the check message is not a template, we use full string equality.

Oh, I see. These messages are the subject to change, such changes are not frequent though. Do you have an idea how to handle compatibility with multiple clang versions in case such changes are introduced? What about regexes to deal with the different kinds of matching strategies?

DO NOT MERGE UNTIL I FIX THIS
I have came to the realisation that we could at some places better use a startsWith instead of an indexOf. 🙂
Also we need to update the README with this feature's changes.

@Xazax-hun wrote:
[...] Do you have an idea how to handle compatibility with multiple clang versions in case such changes are introduced? [...]

See #566, such information stored for the run itself could, at a later point, also be used here for such distinction.
Though I don't think this is an issue at this point, as the highlights were only made for the most common and most important checker messages (I went through the code of the implemented checkers in current master LLVM, looking for bugstep prints), and everything else is getting (though, unfortunately, not visible on the screenshots I attached) a "command-line" icon (>_) which also sort of highlights the message, showing that it is important because it is not a "general" thing usually seen in BugPaths.
(However, the level of how general a message is were my/our arbitrary decision (such is the case with Severity levels also!)


HDDS-1798. Propagate failure in writeStateMachineData to Ratis. Contributed by Supratim Deka

https://issues.apache.org/jira/browse/HDDS-1798
unit test is pending. Will add the infra required for testing this change as part of https://issues.apache.org/jira/browse/HDDS-1818
writeStateMachineData() currently returns a future to Ratis. The scope of this jira is to signal any errors or failures encountered as part of the operation - WriteChunk / handleWriteChunk() to Ratis via this future. As of now, the future does not track failures.
This change is required to complete the failure handling done in HDDS-1603.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
513
trunk passed

+1
compile
272
trunk passed

+1
checkstyle
70
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
948
branch has no errors when building and testing our client artifacts.

+1
javadoc
170
trunk passed

0
spotbugs
349
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
555
trunk passed

_ Patch Compile Tests _

+1
mvninstall
470
the patch passed

+1
compile
277
the patch passed

+1
javac
277
the patch passed

+1
checkstyle
80
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
741
patch has no errors when building and testing our client artifacts.

+1
javadoc
174
the patch passed

+1
findbugs
579
the patch passed

_ Other Tests _

+1
unit
347
hadoop-hdds in the patch passed.

-1
unit
2362
hadoop-ozone in the patch failed.

+1
asflicense
43
The patch does not generate ASF License warnings.

7830

Reason
Tests

Failed junit tests
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.container.server.TestSecureContainerServer

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.om.TestSecureOzoneManager

hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestContainerStateMachineFailures

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.om.TestOzoneManagerHA

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.ozone.client.rpc.TestContainerStateMachine

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1113

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f4c8d4834b55 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4e66cb9

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/1/testReport/

Max. process+thread count
5057 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service U: hadoop-hdds/container-service

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
568
trunk passed

+1
compile
348
trunk passed

+1
checkstyle
63
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
807
branch has no errors when building and testing our client artifacts.

+1
javadoc
160
trunk passed

0
spotbugs
414
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
605
trunk passed

_ Patch Compile Tests _

+1
mvninstall
561
the patch passed

+1
compile
347
the patch passed

+1
javac
347
the patch passed

+1
checkstyle
70
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
621
patch has no errors when building and testing our client artifacts.

+1
javadoc
148
the patch passed

+1
findbugs
633
the patch passed

_ Other Tests _

-1
unit
293
hadoop-hdds in the patch failed.

-1
unit
1569
hadoop-ozone in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

7011

Reason
Tests

Failed junit tests
hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1113

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 04b6a6feb7b7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aebac6d

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/2/testReport/

Max. process+thread count
4835 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service U: hadoop-hdds/container-service

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
106
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
68
Maven dependency ordering for branch

+1
mvninstall
628
trunk passed

+1
compile
382
trunk passed

+1
checkstyle
73
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
940
branch has no errors when building and testing our client artifacts.

+1
javadoc
191
trunk passed

0
spotbugs
482
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
726
trunk passed

_ Patch Compile Tests _

0
mvndep
33
Maven dependency ordering for patch

+1
mvninstall
634
the patch passed

+1
compile
427
the patch passed

+1
javac
427
the patch passed

+1
checkstyle
90
the patch passed

+1
mvnsite
0
the patch passed

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
804
patch has no errors when building and testing our client artifacts.

+1
javadoc
171
the patch passed

+1
findbugs
667
the patch passed

_ Other Tests _

+1
unit
359
hadoop-hdds in the patch passed.

-1
unit
2101
hadoop-ozone in the patch failed.

+1
asflicense
43
The patch does not generate ASF License warnings.

8609

Reason
Tests

Failed junit tests
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.om.TestSecureOzoneManager

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1113

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 18c1db4e2dff 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d086d05

Default Java
1.8.0_212

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/3/artifact/out/whitespace-eol.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/3/testReport/

Max. process+thread count
5328 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1113/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

Thanks @supratimdeka for working on this and @mukul1987 for review. I have committed this change to trunk.


Crash on Server Startup [1.16.5]

Hello! Not sure what issue the server is outlining in this log but it seems to mention this mod or Rayon as the cause. This is the only mod in my pack with Rayon embedded, so I'm just confused as to what is causing a conflict or if something needs fixing. Thanks!
Latest Log:
latest.log

Can you tell me what version of fabric you're using along with the version of Dropz?

Can you tell me what version of fabric you're using along with the version of Dropz?

Actually, I figured out what the problem is. I'll likely have a fix out later today

Actually, I figured out what the problem is. I'll likely have a fix out later today

A new release has been published which contains the fix. Thanks for the heads up!

A new release has been published which contains the fix. Thanks for the heads up!

Thanks for such a quick response!

Thanks for such a quick response!


Audit operator's RBAC

The operator currently has a broad set of RBAC grants:
https://github.com/projectcontour/contour-operator/blob/main/internal/operator/operator.go#L55-L74
These are a combination of:

permissions the Operator needs in order to create/update/delete Contour itself (e.g. CRUD on deployments, daemonsets, jobs, etc.)
transitive permissions the Operator needs in order to create Contour's ClusterRole (e.g. get/list/watch endpoints, services, etc)

It'd be nice to:

Organize the kubebuilder RBAC comments based on the above two categories. This should make maintenance easier, particularly keeping the second category in sync with upstream Contour's ClusterRole / the golang definitions at https://github.com/projectcontour/contour-operator/blob/main/internal/objects/clusterrole/cluster_role.go#L64
Audit the permissions in the first category, to ensure we're only granting what's needed.

xref #265


RuntimeError: Error building extension 'segment_cumsum_cuda' #7

Hi !
I'm trying to run Block-NeRF and I faced this error:
Using /root/.cache/torch_extensions/py310_cu116 as PyTorch extensions root...
Detected CUDA files, patching ldflags
Emitting ninja build file /root/.cache/torch_extensions/py310_cu116/segment_cumsum_cuda/build.ninja...
Building extension module segment_cumsum_cuda...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/1] c++ segment_cumsum.o segment_cumsum_kernel.cuda.o -shared -L/opt/conda/lib/python3.10/site-packages/torch/lib -lc10 -lc10_cuda -ltorch_cpu -ltorch_cuda_cu -ltorch_cuda_cpp -ltorch -ltorch_python -L/opt/conda/lib64 -lcudart -o segment_cumsum_cuda.so
FAILED: segment_cumsum_cuda.so
c++ segment_cumsum.o segment_cumsum_kernel.cuda.o -shared -L/opt/conda/lib/python3.10/site-packages/torch/lib -lc10 -lc10_cuda -ltorch_cpu -ltorch_cuda_cu -ltorch_cuda_cpp -ltorch -ltorch_python -L/opt/conda/lib64 -lcudart -o segment_cumsum_cuda.so
/usr/bin/ld: cannot find -lcudart
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
  0%|                                                                                | 0/100000 [00:04<?, ?it/s]
Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1900, in _run_ninja_build
    subprocess.run(
  File "/opt/conda/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/docker_block_nerf/Block_NeRF/run_FourierGrid.py", line 115, in <module>
    run_train(args, cfg, data_dict, export_cam=True, export_geometry=True)
  File "/home/docker_block_nerf/Block_NeRF/FourierGrid/run_train.py", line 382, in run_train
    psnr = scene_rep_reconstruction(
  File "/home/docker_block_nerf/Block_NeRF/FourierGrid/run_train.py", line 274, in scene_rep_reconstruction
    loss_distortion = flatten_eff_distloss(w, s, 1/n_max, ray_id)
  File "/opt/conda/lib/python3.10/site-packages/torch_efficient_distloss/eff_distloss.py", line 93, in forward
    segment_cumsum_cuda = load(
  File "/opt/conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1284, in load
    return _jit_compile(
  File "/opt/conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1508, in _jit_compile
    _write_ninja_file_and_build_library(
  File "/opt/conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1623, in _write_ninja_file_and_build_library
    _run_ninja_build(
  File "/opt/conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1916, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error building extension 'segment_cumsum_cuda'
(base) root@user:/home/docker_block_nerf/Block_NeRF#

That is RuntimeError: Error building extension 'segment_cumsum_cuda'. How can I resolve it ?

Add cuda to library path.

Add cuda to library path.

How to do it ?

I found that env variable CUDAHOME is not defined though I pulled nvidia/cuda docker image. I will look for another docker image. I'm closing issue for now.


Is there a way how to fix styles issues?

I try to implement Django-Filer to my project, but there a lot of css issues.
How can I override styles of template to include custom style fixes.
I use Django 1.11 (for Django 2 it even )
I have already provided css fixes in admin interface but how can I add styles for this popup? And what is this second button right after Choose File (it open popup with file names and not change anything on select in parent window)?

I have the same problem :(

1.3.1 is on its way. I will release it tomorrow at the latest
Thanks all for reporting and investigating


Nice paper. When will the code be released?

Hi @liujiaheng, thanks for your interest in BoxTeacher! We're planning to release the code and models at the end of this year~


feat: Add vehicle endpoint

Implements vehicles endpoint feature #151

Thank you for the amazing work on this @kk5190 Happy hacktoberfest 👍


[Improvement][Component Model Generator]: Provide backend support for graphQL services

Description
Currently the mapping to a graphQL service is invalid in the Application Architecture Diagram

Please refer to the code base here.
Need to implement the mapping for graphQL queries and mutations
.
Describe your problem(s)
No response
Describe your solution(s)
No response
Related area
-> Other Area
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

For now we have decided to hide the methods of GraphQL service into a single unit, as mapping to GraphQL methods needs to be discussed on how to do the mappings. This is due to GraphQL query string has to be processed to do  the mapping which can be either defined or can be passed at the runtime.


Bug: overlay,userxattr directory created in roots// during squashfs biulds

stacker version
v0.40.1-e54a685
Describe the bug
When building a squashfs layer, a directory named 'overlay,userxattr' is left under stacker roots/layer/
Reproduce
$ stacker build
preparing image minbase...
loading docker://alpine:edge
Copying blob a71ff8a5264a done
Copying config 09b6b3579b done
Writing manifest to image destination
Storing signatures
+ echo all done.
all done.

$ ls -l roots/minbase/
total 24
drwxr-xr-x 3 smoser smoser 4096 Jan 10 09:07 overlay
-rw-r--r-- 1 smoser smoser  458 Jan 10 09:07 overlay_metadata.json
drwxr-xr-x 2 smoser smoser 4096 Jan 10 09:07 overlay,userxattr
drwxr-xr-x 2 smoser smoser 4096 Jan 10 09:07 rootfs
drwxr-xr-x 3 smoser smoser 4096 Jan 10 09:07 work
drwxr-xr-x 2 smoser smoser 4096 Jan 10 09:07 workaround0

The 'overlay' dir is probably not necessary to be there (stacker could just create a tmpdir always on mount), but the 'overlay,usrexattr' dir is I think fallout of GetLXCRootfsConfig in pkg/overlay/overlay.go doing :
    return fmt.Sprintf("overlay:%s,userxattr", lxcRootfsString), nil

I think that lxc is not understanding the intent of userxattr there.
See stacker.yaml below.
$ cat stacker.yaml
minbase:
  build_only: true
  from:
    type: docker
    url: ${{DOCKER_BASE:docker://}}alpine:edge
  run: |
    echo all done.

I think #389 is intended to fix this.

Assigning this to myself, but not sure when I'll have a chance to look, so anyone please feel free to assign yourself if you do happen to start on it.

is it just a matter of removing the ,userxattr ?

Oh we're doing that for lxc.rootfs string?  Then yes, I think so.


Datasets and Models  ?

Thank you for your work. Are there any plans to release datasets and models in the near future?

Many thanks for your interest and patience. Yes! Very excited to open source them. Actually, we‘re expanding our datasets and testing our new methods. The datasets and models will be released as soon as new work is published.


Add --preserve-variables option to allow variables passthrough

Fixes #18 - allows a person to pass --preserve-variables to keep CSS variables intact.

<3


[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Ubuntu (Default) (Ubuntu 22.04.2 LTS)
Other Software
Visual Studio 2022 - 17.8.3
Repro Steps
Open a C++ CMake project. VS will then show this:

Then press "Install WSL". Then this "installation guide" shows:

It says "CPU virtualisation is enabled in BIOS. You must enable virtualisation... etc", with a yellow warning triangle. This is very confusing: CPU virtualisation is enabled on my machine in BIOS, and the Task Manager confirms it - and WSL works of course. So I would expect a green checkmark for this item, not a yellow warning triangle.
Expected Behavior
I would expect a green checkmark for this item, not a yellow warning triangle.
Actual Behavior
A yellow warning triangle is shown, even though virtualisation is enabled and WSL works without any problems.
Diagnostic Logs
No response

Closing since this is a Visual Studio issue and not a WSL one.

I reported this on the VS bugtracker https://developercommunity.visualstudio.com/t/WSL-dialog:-CPU-virtualisation-warning/.


Support for intl ^0.18.0

I'm closing this, already supported on month_picker_dialog version 2.0.0, sorry


Measurements of all the metrics

Hey,
Thanks for sharing this wonderful tool - it was super helpful to use it for measuring the mutation score of other projects as well.
Do you plan to share the code of measuring all the other metrics as well or at least a full documentation of how did you use all the other tools for measuring the other metrics? It will be really helpful to reproduce your results on different code repositories.
Many thanks!

Hi there. I just included here some code that allows the computation of the metrics.

Thanks @giograno!
While following your instructions I get the following:
'Could not resolve dependencies for project org.example:metrics-api-usage:jar:1.0-SNAPSHOT: Failure to find raykernel.apps.readability:raykernel.apps.readability:jar:1.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced'
I tried to added the jar from here but it doesn't seem to work either, do you have any idea what exactly should I install?
Dor

@dormaayan did you manage to solve your issue? I received I notification but I don't find your post anymore.

Hey @giograno,
For computing BUSWEIMER, it seems like the tool uses a jar which is not available: raykernel.apps.readability.jar
Do you have this jar, I couldn't find it online?

Hi @dormaayan, you can find that jar at this link.
Anyway, I've updated the project such that all the dependencies are now available. You can just try out again (just run the commands in the README) and let me know if you face any issue.
Thanks.


[Batch] Add composer-require-checker CI

Added composer-require-checker according to https://github.com/yiisoft/actions/pull/9

⚠ This PR requires https://github.com/yiisoft/translator-message-php/pull/40


Various packages for Jessie

+1
Thanks for filling those in!
links I checked

https://packages.debian.org/jessie/dnsmasq
https://packages.debian.org/jessie/gdal-bin
https://packages.debian.org/jessie/libmicrohttpd-dev
https://packages.debian.org/jessie/libnl-3-200
https://packages.debian.org/jessie/libnl-genl-3-200
https://packages.debian.org/jessie/libnl-3-dev
https://packages.debian.org/jessie/libnl-genl-3-dev
https://packages.debian.org/jessie/libturbojpeg1
https://packages.debian.org/jessie/libturbojpeg1-dev
https://packages.debian.org/jessie/mapnik-utils
https://packages.debian.org/jessie/osm2pgsql
https://packages.debian.org/jessie/postgresql-9.4-postgis-2.1
https://packages.debian.org/jessie/python-cherrypy3
https://packages.debian.org/jessie/python-colorama
https://packages.debian.org/jessie/python-mapnik
https://packages.debian.org/jessie/tilestache


Allow dropping on all items, but target node should always be a folder?

I want to let the user drag and drop a node onto any other node, but if the target node is not a folder, the target should instead be the target node's parent (This is how most file-pickers work). Unfortunately setting canDropOnNonFolder to true causes the uncontrolled tree environment to attempt rendering the dragged node as a child of the non-folder target node, so this doesn't work.
Does anyone know if this sort of behavior is possible?

You can use an Controlled Environment instead of an uncontrolled environment, there you can define the drop logic yourself. You can use the drop implementation of the uncontrolled environment as an example (the uncontrolled environment react component is just a wrapper around the controlled environment, so technically you can just copy its implementation and change the drag logic).
But the use case is definitely justified, I don't have time to look into this this week, but will look into this soon if it makes sense to support this straight from the library.

Thanks @lukasbach. I will wait until you implement this feature to continue transitioning my company's file-picker to use this library.

Hey, sorry didn't get to look into this recently, but added this today and released this as of 2.1.0.

Looks like there's a bug if you drop a folder onto a child folder, both of them will disappear.


Release EKS Go: v1.22.1-1

Increment release file to publish new EKS Go artifacts for v1.22.1-1

Release artifacts built in: https://github.com/aws/eks-distro-build-tooling/pull/1358

/lgtm

/approve


📦 Update AMI to use packer variables

Use packer variables for extended modularity
Create variables on-the-fly during validate and build stages using HCP Packer
Continuously build and deploy AMIs using these variables

FIx build CD pipeline to include pkrvars.


⚠ Bofrost.es has degraded performance

In 63d9ac4, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 7174 ms

Resolved: Bofrost.es performance has improved in 32fad0a.


Be clear about the usage of sudo when loading the SA

Following the discussion here this PR updates the docs to include sudo in the chunkwm --load-sa command.

This is incorrect. Loading the scripting addition is simply sending an apple even and this can be done as an unprivileged user.

Oh ok, thanks for clarifying. I wonder what the solution to the problems people are having in #626 is then.


Test: sorting JSONC on save

Refs https://github.com/microsoft/vscode/issues/175893

[x] anyOS @mjbvz
[x] anyOS @alexdima
[x] anyOS @brettcannon (Optional)

Complexity: 1
Create Issue

This iteration it has been made possible to sort JSONC files on save using the inbuilt JSONC sorting mechanism.

Enable the setting json.sortOnSave.enable.
Open a JSON or JSONC file, make some changes to make the file dirty. You can add comments (block or line) in the file.
Save the file and verify that the file is sorted in alphabetical order and formatted.
Verify that the sorting behaves as expected:

Is the json object sorted alphabetically?
Is the json object formatted as you would expect?
Are the comments in the JSONC files sorted as you would expect? Currently the comments are associated to the JSON properties below them. The only exceptions are when the comments start on the same line as a property or are the last comment in a JSON scope, in which case they are associated to the last property before them.

:warning: There is a known issue which is that when there is a trailing comma in the file, the sorting mechanism fails its sorting. This issue is tracked here: https://github.com/microsoft/vscode/issues/178229

One thing that surprised me is when there's no way to have a section comment, e.g.:
{
    // Big block comment

    "b": false, // more B stuff
    "C": 42, // C stuff
    // stuff
    "A": true
    // B stuff
}

will sort // Big block comment with "b" instead of leaving it in-place.


[BUG] Blur & CostumFont conflicting with CatEars

Describe the bug
In the gui turning on blur & cat ears with costum font makes cat ears have black background instead of transparent
To Reproduce
Steps to reproduce the behavior:

Turn on cat ears
Enable blur (in gui)
Turn on costum font
See error

Additional context
Not a biggie but it triggers me lol
Checklist

[x] I know how to properly use check boxes.
[x] I have included logs, screenshots, exceptions and / or steps to reproduce the issue.
[x] I followed the issue template.

I have included logs
did you?

very good solution: dont use clickgui catears

also it also says "or steps to reproduce the issue." which i provided

error logs/stack traces always help and makes it easier for the developer

i mean... he can easily replicate the bug himself + it'll be better


Removed hardcoded categories from jugantor and kalerkantho.

@aniruddha-adhikary
For Jugantor, taking only the archive news shown in archive panels rather than menu categories.

@bdcodefreak we would like to have as many options of crawling possible, available to end-users. If you check my latest commits and the Status page, that should speak out.


VIS Prt File Export Doesn't Export all VIS Data

Exporting any VIS prt from maps (tested with hl1 retail maps) exports a file only containing a single number (the leaf count).

@marigi64 yes, I can't do export .ptr file, BSP has very hard to understand structure, so this feature not completed.
Now only RAD.exe data can be exported for rerun rad.exe compiler.


BDCraft.net support request

Domain
https://bdcraft.net
Link
https://bdcraft.net/download/?z=PureBDcraft 128x MC118&pack=purebdcraft-minecraft&guide=install%2Fminecraft
Version
0.0.0
What browsers are you seeing the problem on?
Firefox, Chrome, Brave, Microsoft Edge
What OS are you seeing the problem on?
No response
(Optional) Anything else?
You will have to agree terms to access the countdown
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Bump I guess?

Why isn't anybody replying

I guess no one will ever reply to this issue


Updated Context and theme information

Clarified what information can be used in a Tabs URL, returned by the microsoftTeams.getContext() object, and clarified the wording for theme change handling.

:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/tabs/tabs-context.md
:warning:Warning

Details

msteams-platform/concepts/tabs/tabs-context.md

Line 21: [Warning] Invalid file link:(~/concepts/authentication).
Line 26: [Warning] Invalid file link:(~/resources/schema/manifest-schema#permissions).
Line 39: [Warning] Invalid file link:(~/concepts/tabs/tabs-configuration).
Line 40: [Warning] Invalid file link:(~/concepts/deep-links).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Move change entry to breaking changes

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@72af062). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6277   +/-   ##
=========================================
  Coverage          ?   83.22%
  Complexity        ?    12812
=========================================
  Files             ?     1478
  Lines             ?    48462
  Branches          ?     5920
=========================================
  Hits              ?    40333
  Misses            ?     5369
  Partials          ?     2760

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72af062...a455418. Read the comment docs.


Use PETSc.Log.getTime() instead of time.perf_counter()

In file examples/square_inclusion.py, lines 97 and 99.
Initially reported by @vptran.

Fixed in 4319dc23dc318580e8a1d4ff7334a8a32dd3d131.


Too easy to refresh local list of artists, albums, etc. by mistake

Hi there,
Context: I have a rather large collection of music, so the Kore's local list of artists takes quite some time to build/refresh.
Issue: While the material design concept of pulling from the top of the list to refresh a list is aesthetically pleasing, and makes a lot of sense for lists of entries that are often updated and are in chronological order (ie: Twitter feed), it doesn't make so much sense in our context: we don't really browse to the top of the list and then want to see if there's anything new.
Worse, it's happened to me twice recently as I was scrolling up and down my list of artists to involuntarily refresh the list. (This also puts Kore in that weird in-between state where it takes a long time to finish, but if I go into an artist and interrupt the update, I end up with missing artists and/or empty artists, so I'm just left waiting)
Proposed solution: I think it would be better to have the refresh option as a dedicated button.
Two options I can think of for that:

put the refresh icon (set of revolving arrows or whatever) next to the magnifying glass and remote icon, top right of the music screen
or put refresh icon directly next to the word Music, in the side pull menu, so that 90% of the button goes to the Music screen and 10 % refreshes the content of the Music screen.

Sorry for the lengthy explanation and thanks for considering this issue :)
cheers
axe

+1 Happens to me too very often.
I don't think you need a separate button. The way to pull down as currently implemented is awkward and not best practice in mobile apps. In standard controls that provide this with a pull to update, a flick for scrolling should not activate it, only a drag. In addition, it should show a visual indication of the end being reached and start to "stretch" and not invoke the reload until it is "stretched" some distance. This allows the user to let go and not have it refresh/reload. The current private implementation does neither and so going to the top and not being sure whether one is at the top can easily result in invoking the reload.

I agree and I created an implementation I am currently still testing and cleaning up. If you are familiar with building an android app from source you can get it at https://github.com/poisdeux/Kore/tree/issue%23103
Would be nice if you could test it as well. It adds a refresh icon to the toolbar and animates it while a sync process is in progress.

After playing with the refresh icon in the toolbar I must say I do not really like it. Especially the animation draws too much attention away from the actual app.
My proposal: adding a Refresh option to the overflow menu and disable the slide refresh option. When user selects refresh from the menu it will start the refresh animation in the list just like with the current slide refresh action.

@axelsimon I see your point. I'm not totally convinced but i agree that it can be a nuisance. I didn't understand your second option, but it doesn't look like it is something standard and usual in Android.
Putting an option in the top right menu is the easiest and standard way to do it, but, like i said, i'm not convinced that it is better than the pull to refresh.
Furthermore, if we put the refresh icon on the top right menu, the remote icon would probably need to be hidden in an overflow menu (putting 3 icons in the top row is too much - search, refresh, remote).
BTW, if during the update you go into an artist/album/whatever, the update should continue to run, and should end. You won't see the success message, but it won't stop and the list will be updated afterwards (if you exit the list screen and reenter).
@gvkt Not sure what you're talking about, as the pull to refresh control being used is the standard one, so if you have any complaints about it, you might redirect them to Google.

If you are using the standard Android control SwipeRefreshLayout, the later versions of this  library has the
setDistanceToTriggerSync(int distance)
method that allows you to set how much the layout has to be pulled down before it triggers the refresh. Best practices suggest that the greater the cost of refresh and more infrequent the usage, the longer you set this distance, not just the default since applications for this control vary a lot in requirements some of which require it to be very sensitive (lazy scrolling of an endless list, for example)
The above method was not available in earlier versions of the control and made it useless for many applications including this one.
Just experiment with different values for the distance and the feedback icon/color scheme settings and you will find a reasonable range for that value where it prevents almost all of the inadvertent refreshes from swiping to scroll and not painful when you really want to refresh.
A separate button on the toolbar makes this function more obvious (discoverable) because as OP pointed above pull to refresh is not the intuitive action for this type of list (not chronological and not continuously updated at the top). So, it might be OK to leave this in the overflow menu (as it is not used very frequently) for discovery reasons but also have the pull to refresh with sufficiently large distance for the "power users" that prevents inadvertent refreshes.


Creating token via macro that has compendium art mapping results in incorrectly sized token

If you use the below macro to import an actor from the Monster Core compendium pack it results in a token that is incorrectly sized compared to importing the actor from the Bestiary Browser.
const actor = await fromUuid("Compendium.pf2e.pathfinder-monster-core.Actor.Xo4IGzw28hivgMmM");
const imported = await Actor.create(actor);
const token = await imported.getTokenDocument();
canvas.scene.createEmbeddedDocuments("Token", [token]);

The one on the left was created with the above macro, while the one on the right was created from the Bestiary Browser.

Have you tried not passing documents to create methods?

Have you tried not passing documents to create methods?

I am not sure what you mean, it's retrieving the Zombie Shambler from the compendium pack and creating an actor using that document. If I don't do that then it's not going to have the compendium art mapping.

I figured out what the issues was, it's using Actor instead of ActorPF2e to create the actor. Switching over to Actor.implementation.create fixed the issue.
const actor = await fromUuid("Compendium.pf2e.pathfinder-monster-core.Actor.Xo4IGzw28hivgMmM");
const imported = await Actor.implementation.create(actor);
const token = await imported.getTokenDocument();
canvas.scene.createEmbeddedDocuments("Token", [token]);


Document Review Workflow on SharePoint

I will design a document review workflow on the SharePoint for our deliverables.

Workflow has been published and is ready to test with @VikkiM

Helpdesk ticket created for Nintex support team to tell me how to run workflow on item in document library--unable to find the workflow in "available workflows"

Productive helpdesk session corrected error in workflow design--workflow must be built inside the Shared Documents library. Shared Documents > Library Ribbon > Workflow Settings > Create Workflow. Rebuilding workflow now.

Document review is successful--Allison approved documents via the workflow. We will use the workflow in the future to gain acceptance on text-based deliverables. Closing this item.


Implement hello eval with Enzyme.

I'm mostly interesting in feedback on the Dockerfile/Makefile setup. In principle supporting the remaining evals should be straightforward.
Updating the version of Enzyme in the Dockerfile should not be difficult, assuming they don't change the build instructions or add interesting new dependencies.
I think the C++ infrastructure ported from ADBench really shows its advantages here. Perhaps something similar should be done for all the trivial Python wrappers - they are very similar.

Marking as draft since the Enzyme tool is claiming to support GMM but actually fails on it; feel free to undraft once that's no longer the case.

GMM has been purged.


Error on opening saved session

Neovim version (nvim -v | head -n1)
head
Operating system/version
macOS 12.4
How to reproduce the issue
Error executing vim.schedule lua callback: UnhandledPromiseRejection with the reason:
...site/pack/packer/start/nvim-ufo/lua/ufo/fold/manager.lua:141: Vim(foldopen):E490: No fold found
stack traceback:
        ...re/nvim/site/pack/packer/start/nvim-ufo/lua/ufo/fold.lua:44: in function <Anonymous:25>

I'm getting this error when using the plugin with auto-session plugin, looks like some folds cannot be restored after entering session.
Expected behavior

save session
exit nvim
enter nvim
no error appear

Actual behavior

save session
exit nvim
enter nvim
the reported error appears

NOTE: The error doesn't happen always, and I can't understand why it fails sometimes.

NOTE: The error doesn't happen always, and I can't understand why it fails sometimes.

Do you mean files or a single file? If a single file always happens, please provide the session file.

Not always a single file, it happens with different files too (but somewhat randomly). My hunch is that fold couldn't be found (opened) to due invalid session saved or smth. And then the ufo plugins breaks on that, it doesn't affect the overall loading of session, just the ufo.


Secp256k1/Curve25519 support for PIV auth-sign

In the docs it seems there is no support for Secp256k1 or Curve25519. As far as I understand 5.2.3+ should support these curves. Is there be support for these curves (without going through PGP)?

Hi @jpopesculian
No. These algorithms are only supported by the OpenPGP application of the YubiKey. The PIV application only implements the algorithms listed on the first page that you have linked.
Sorry!


how to define pallas kernels usable in both fwd and bwd mode?

right now, there's clear documentation re how to use custom_jvp and custom_vjp, but the automatic transposition of custom_jvp isn't necessarily going to be very good for pallas kernels (is it even defined?) and using custom_vjp isn't compatible with jvp.

#17840 might be of relevance here, as this PR makes it possible to do jvp-of-custom_vjp.
In practive it's still a little buggy and I haven't had the chance to fix it up yet, but it might be the essence of the solution needed.

cc @sharadmv @apaszke @mattjj (I suspect one of you would be able to comment on this...)

but the automatic transposition of custom_jvp isn't necessarily going to be very good for pallas kernels (is it even defined?) and using custom_vjp isn't compatible with jvp.

As Patrick implied, this seems to be more of a JAX issue than a pallas specific one. If JAX supports defining both custom vjp/jvp simultaneously, this pallas use case would work. @froystig


Created Pull Request, Answers Done

Added some creativity for coding answers, checkout once line no 41 in answers.md

Thanks @adityasharma28
We'll review and get back to you


Draft: Audit log

Related issue

Proposed changes

Checklist

[ ] I have read the contributing guidelines.
[ ] I have read the security policy.
[ ] I confirm that this pull request does not address a security
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
<EMAIL_ADDRESS>from the maintainers to push
the changes.
[ ] I have added tests that prove my fix is effective or that my feature
works.
[ ] I have added or changed the documentation.

Further comments

The pull request adds audit log possibilities to oathkeeper.
The audit log is enabled using regular configuration file:
auditlog:
  enabled: true
  schema: "/auditlog.schema.json"
  config: "/auditlog.json"

The schema file describes json schema to validate audit log configuration file.
Here is a class diagram for new features. The ProxyAuditLogDecorator decorates oathkeeper's Proxy and adds logging features.

Audit Log configuration example:
[
  {
    "url_pattern": "http://(localhost|<IP_ADDRESS>):8080/return200",
    "http_method": "GET",
    "filter": {
      "request_header": ["User-Agent"]
    },
    "description_template": "Curl GET to localhost returned {{meta.response_code}}"
  }
]


More language models

It would be nice to be able to plug in more language models. Below are some candidates to add
[ ] Bert
[ ] Seqvec
[ ] One-hot encoding (related to #29)
Leave a comment if interested in contributing these models (since many of these already have implementations).

We have switched everything over to Protrans.  We may explore using ESM2, but we'll leave this to future exploration.


Update aws-java-sdk-core to 1.12.575

About this PR
📦 Updates com.amazonaws:aws-java-sdk-core from 1.12.459 to 1.12.575
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #644.


support specifying existing volume in grafana dataStorage

Description
In order to reference an existing volume (e.g. for a specific blob/file-storage) it must be possible to specify the volumeName in the PVC.
The PVC will be created using the attributes in Grafana.spec.dataStorage, so I added a new attribute volumeName that will be used when creating the PersistentVolumeClaimSpec
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[X] This change requires a documentation update
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added a test case that will be used to verify my changes
[X] Verified independently on a cluster by reviewer

Verification steps

Create a PersistentVolume on your Cluster and make sure, that the ReclaimPolicy is Retain (e.g. by following this guide: https://docs.microsoft.com/en-us/azure/aks/azure-files-volume#mount-file-share-as-a-persistent-volume)
Update the CRD for Grafana on your Cluster
Change your Grafana.yaml to reference the created volume (for an Example see deploy/examples/persistentvolume/Grafana-existingVolume.yaml)
Apply the changes to the cluster and wait for the grafana-deployment POD to come up
check that the automatically created PVC "grafana-pvc" is bound to the previously created Volume kubectl get pvc -n your-namespace

What is the need for this feature @Iridias? Why not let the operator manage the PV? You can already define a storage class what else do you need?
There probably is a good reason but it would be good to define it.

What is the need for this feature?

When we're "updating" one of our clusters, we're in fact rather setup a new one, deploy everything on it and switch the routing (all automated of course). But this leads to the situation, that everything that is not stored on a volume/storage outside the cluster, will be lost.
And unfortunately, the dynamic storage-provisioner of AKS (Azure Kubernetes Service) will always generate a random UID for the storage - so you can't target an existing azure-storage with a PVC! You must create the PV manually in order to do that and reference that PV in the PVC!

What happens when a user defines a grafana CR without the volume name specified, and then the CR is updated with a new name, will the old pvc be deleted and replaced with a new one?

I would assume, that the PVC will be updated, but the previously created PV will be deleted - as the default reclaim-policy is "Delete". Have not tested it tough.

LGTM, thanks allot for your contribution @Iridias, I did a minor change in the example so it works out of the box with the ingress config.


Optional new and const crash during compilation on Flutter 0.2.7-pre.6

My code is here:
https://github.com/flutter/flutter_attract/tree/dart2
(original code without optional new and const is in the master branch).
Crash:
[C:\git\flutter_attract] flutter run
Using hardware rendering with device Android SDK built for x86. If you get graphics artifacts, consider enabling software rendering with "--enable-software-rendering".
Launching lib/main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...                                       0.9s
Resolving dependencies...                                    1.0s
Running 'gradlew assembleDebug'...
compiler message: lib/main.dart:105:26: Error: The keyword 'const' or 'new' is required here. Due to an implementation limit, the compiler isn't able to
infer 'const' or 'new' here.
compiler message:                   style: TextStyle(
compiler message:                          ^
compiler message: Unhandled exception:
Crash when compiling file:///C:/git/flutter_attract/lib/main.dart,
at character offset 2237:
lib/main.dart:105:26: Internal problem: Unhandled invalid-expression "lib/main.dart:105:26: Error: The keyword 'const' or 'new' is required here.

* Where:
Script 'C:\git\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 441

* What went wrong:
Execution failed for task ':app:flutterBuildDebug'.
> Process 'command 'C:\git\flutter\bin\flutter.bat'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s
Gradle build failed: 1

[C:\git\flutter_attract]

Flutter doctor output:
[C:\git\flutter_attract] flutter doctor -v
[√] Flutter (Channel master, v0.2.7-pre.6, on Microsoft Windows [Version 10.0.14393], locale en-US)
    • Flutter version 0.2.7-pre.6 at c:\git\flutter
    • Framework revision 0c89920069 (17 hours ago), 2018-04-01 17:35:05 -0700
    • Engine revision c903c217a1
    • Dart version 2.0.0-dev.43.0.flutter-52afcba357

[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at C:\Users\timsneath\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)
    • All Android licenses accepted.

[√] Android Studio (version 3.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)

[√] VS Code, 64-bit edition (version 1.21.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Dart Code extension version 2.11.1

[√] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

Note from the doctor output that the SDK in the error report is build against https://github.com/dart-lang/sdk/commit/52afcba

@dgrove Looking at the cut-down example above (I can't find https://github.com/flutter/flutter_attract/tree/dart2), it looks like the problem is that BoxFit isn't defined. Could you try adding an import of package:flutter/painting.dart and telling me whether you're still seeing an error? (I'd try it myself, but I don't have a machine set up with Flutter at this point.)

/cc @Hixie re: previous comment

Adding the import didn't change anything.
On Mon, Apr 2, 2018 at 1:20 PM Brian Wilkerson<EMAIL_ADDRESS>wrote:

@dgrove https://github.com/dgrove Looking at the cut-down example above
(I can't find https://github.com/flutter/flutter_attract/tree/dart2), it
looks like the problem is that BoxFit isn't defined. Could you try adding
an import of package:flutter/painting.dart and telling me whether you're
still seeing an error? (I'd try it myself, but I don't have a machine set
up with Flutter at this point.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/32737#issuecomment-378032261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAsW8ob55jqIyC-e-p1RaLyJfG2dxTUks5tkogHgaJpZM4TD0hQ
.

Ok. I managed to get set up enough to verify that BoxFit is exported from material.dart. So the "missing" import was a red herring. Sorry about the distraction.
I don't know everything that's going on, but it appears that the exception is caused by handing the ConstnessEvaluator (the piece that determines whether to infer new or const) a constructor invocation with an argument that has been compiled into an invalid expression. I'm not sure which constructor it's visiting, nor which expression is invalid, but I don't see anything obvious in the code to indicate that the invalid expression is correct. So my suspicion is that the first bug is in the fact that an invalid expression was produced.
The second bug is that invalid code can presumably cause an exception. The ConstnessEvaluator clearly needs to handle this case gracefully.

Maybe it's because the constructor for Padding is asserting that padding != null, and that throws (since the padding argument is omitted)?

I think this boils down to not yet handling constant fields:
const constTopLevelField = 42;

class C {
  const C(x);
  static const constField = 87;
}

main() {
  C(C.constField);
  C(constTopLevelField);
}

Sorry, I haven't actually tested this locally.

Thank you for the example, Peter.  It is exactly the kind of yet unhandled expression kind that caused the issue.  CL 49140 adds the support for static gets, and I was able to compile the example code without error with that.
The compiler crash is another issue.  It is because the evaluator didn't support nested expressions that require new/const insertion.  So, if the inner expression with implicit new/const leads to a compile-time error, the generated invalid-expression node that signals about this compile-time error is then visited during new/const insertion for the outter expression.  But, because invalid expressions aren't explicitly handled by the visitor, it leads to an invocation of defaultTreeNode that throws the exception.  CL 49122 is supposed to fix that behavior.  Interestingly enough, we didn't have tests to catch this issue when I was landing https://github.com/dart-lang/sdk/commit/59d859645ef0557bc7f8e2ee07957f506b755255.

@kmillikin @stefantsov Is there any work remaining here?

This should be fixed.  We will reopen if it recurs.

Just had the same error. Here is the code.
import 'package:flutter/material.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/foundation.dart';
import 'dart:async';
void main() {
return runApp(CBNConcept());
}
class CBNConcept extends StatelessWidget {
final ThemeData _defaultTheme = ThemeData(
primaryColor: Colors.grey[300],
primaryColorLight: Colors.grey[200],
primaryColorDark: Colors.grey[500],
primaryColorBrightness: Brightness.light,
accentColor: Colors.redAccent,
);
@override
Widget build(BuildContext context) {
return MaterialApp(
title: "Radio Cbn",
home: CBNHome(),
theme: _defaultTheme);
}
}
class CBNHome extends StatelessWidget {
final String stubImage = "http://estaticos.globoradio.globo.com/fotos/2017/09/d49d707a-a3f6-49bf-b49a-1c0ef5bbab10.jpg.295x295_q80_box-721%2C1%2C3079%2C2359_detail.jpg";
final String stubNews = "Presidente diz nao ter duvidas da responsabilidade do regime sirio";
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text("Radio CBN")),
body: Card(
child: Container(
margin: EdgeInsets.all(8.0),
child: Column(
children: [
Image.network(stubImage),
Text(
"Emmanuel Macron",
style: TextStyle(fontSize: 18.0),
),
Text(
stubNews,
style: TextStyle(fontSize: 14.0),
),
],
),
),
),
);
}
}
After adding new keyword it compiled
Flutter Doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, v0.2.8, on Microsoft Windows [Version 10.0.16299.371], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[√] Android Studio (version 3.1)
[√] Connected devices (1 available)
• No issues found!

Just had the same error. Here is the code.
import 'package:flutter/material.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/foundation.dart';
import 'dart:async';

void main() {
  return runApp(CBNConcept());
}

class CBNConcept extends StatelessWidget {
  final ThemeData _defaultTheme = ThemeData(
    primaryColor: Colors.grey[300],
    primaryColorLight: Colors.grey[200],
    primaryColorDark: Colors.grey[500],
    primaryColorBrightness: Brightness.light,
    accentColor: Colors.redAccent,
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        title: "Radio Cbn",
        home: CBNHome(),
        theme: _defaultTheme);
  }
}

class CBNHome extends StatelessWidget {
  final String stubImage = "http://estaticos.globoradio.globo.com/fotos/2017/09/d49d707a-a3f6-49bf-b49a-1c0ef5bbab10.jpg.295x295_q80_box-721%2C1%2C3079%2C2359_detail.jpg";
  final String stubNews = "Presidente diz nao ter duvidas da responsabilidade do regime sirio";

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text("Radio CBN")),
      body: Card(
        child: Container(
          margin: EdgeInsets.all(8.0),
          child: Column(
            children: <Widget>[
              Image.network(stubImage),
              Text(
                "Emmanuel Macron",
                style: TextStyle(fontSize: 18.0),
              ),
              Text(
                stubNews,
                style: TextStyle(fontSize: 14.0),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

After adding new keyword it compiled
Flutter Doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, v0.2.8, on Microsoft Windows [Version 10.0.16299.371], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[√] Android Studio (version 3.1)
[√] Connected devices (1 available)
• No issues found!

Hi @AndreHaueisen -- thanks for building with Flutter!
The fix hasn't made its way to the beta channel yet, but I've tested the code you wrote and it works perfectly without new on the latest builds from the dev and master channels.
You can try for yourself by running flutter channel dev and then flutter upgrade, if you're comfortable to be closer to the bleeding edge.

Hi @timsneath
My mistake then. Thanks for clarifying that.
Keep up the good work.

@timsneath but i could have widgets without 'new' in beta 1 with dart 2 enabled.. but i cant do the same in beta 2 with dart 2 enabled...why?

Hi @rajeshzmoke.  That's due to churn as we (the Dart team) sorted out how this feature should work.
In beta 1, we would infer new almost everywhere, unless you were already inside an outer const.
We wanted to try to see if we could come up with a simple way to infer const in more places when there was a const constructor available.  While we worked on that, we made it an error to have code that relied on us inferring const or new where both were possible so you wouldn't rely on behavior that we intended to change.  Inferring const was still OK if it was required, and inferring new was still OK if const wasn't possible.
If all your widgets have const constructors, then it will probably look quite a bit like the feature just doesn't work in beta 2 at all.
We've settled on the original (beta 1) behavior for the time being, so all this churn was unnecessary and I apologize for it.


Wrong cache type when using shell command

System Information

[x] lsb_release -a
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.1 LTS
Release:        18.04
Codename:       bionic

[x] ee cli version
EE 4.0.0-beta.6

[x] ee cli info

+-------------------+----------------------------------------------------------------------------+
| OS                | Linux 4.15.0-30-generic #32-Ubuntu SMP Thu Jul 26 17:42:43 UTC 2018 x86_64 |
| Shell             | /bin/bash                                                                  |
| PHP binary        | /usr/bin/php7.2                                                            |
| PHP version       | 7.2.9-1+ubuntu18.04.1+deb.sury.org+1                                       |
| php.ini used      | /etc/php/7.2/cli/php.ini                                                   |
| EE root dir       | phar://ee.phar                                                             |
| EE vendor dir     | phar://ee.phar/vendor                                                      |
| EE phar path      | /root                                                                      |
| EE packages dir   |                                                                            |
| EE global config  | /opt/easyengine/config.yml                                                 |
| EE project config |                                                                            |
| EE version        | 4.0.0-beta.6                                                               |
+-------------------+----------------------------------------------------------------------------+

[x] wp --allow-root --info
PHP binary:     /usr/local/bin/php
PHP version:    7.2.9
php.ini used:   /usr/local/etc/php/php.ini
WP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:      phar://wp-cli.phar/vendor
WP_CLI phar path:       /var/www/htdocs
WP-CLI packages dir:
WP-CLI global config:
WP-CLI project config:
WP-CLI version: 2.0.1

Steps to reproduce the problem:

Create a site with cache ee site create site_name --type=wp --cache --le
Use CLI, ee shell site_name
Now see which cache is being used. wp cache type
The result should not be default as EasyEngine should be using Redis.

Actually, I'm not sure if it is a bug on EasyEngine or WP CLI because of the shell. But I presume the value there should not be default.

@renatonascalves I've looked into it and what wp-cli does is it checks if there are specific plugins (like wp-redis ) and shows output based in that. Currenly we have haven't added any object cache plugin, but based on this issue, we'll soon add wp-redis by default.
For now you can follow following manual steps to enable redis cache in wp -
ee shell <sitename>
wp plugin install wp-redis
wp plugin activate wp-redis
wp redis enable
vim wp-content/plugins/wp-redis/object-cache.php (search for <IP_ADDRESS> and replace it with redis)

After this if you type wp cache type, you'll see output Redis.

@kirtangajjar Question!
What exactly does --cache do if no install the redis cache?

vim wp-content/plugins/wp-redis/object-cache.php (search for <IP_ADDRESS> and replace it with redis)

This is the wrong way. You shouldn't edit plugin files but do install as per
@renatonascalves please follow setup instruction here https://github.com/pantheon-systems/wp-redis#installation
Please use redis instead of <IP_ADDRESS>.  redis is hostname for redis-server.

@rahul286 Thanks! I'm not against installing it manually, I'm more concerned about the expectation of such a cache.
If the flag ---cache exists, one would expect a cache to be installed. In the past, I don't remember the issue, it was debated and chosen redis for the default cache.
So I presumed that EasyEngine would install it automatically. So is it something EE will do in the future or my expectations are wrong?

@kirtangajjar Understood. I was under the impression the redis object cache would come by default, not page cache.
Thanks for the feedback.

@renatonascalves

If the flag ---cache exists, one would expect a cache to be installed. In the past, I don't remember the issue, it was debated and chosen redis for the default cache.

Your expectation is correct. wp-redis should be installed and configured automatically when a ee site create --wp is run with --cache flag.
This is a bug.

@rahul286 Got it! Thanks again! Will continue testing the current RC. :)

@rahul286 this site install cache flag and subsequent lack of cache related features backend confused me too, in the past an install with cache had a cache plugin installed and we could clear cache from backend of wp. new installs on v4 as of today do not. i will try the manual install

--cache implementation is broken currently.
Closing this issue in favor of https://github.com/EasyEngine/site-type-wp/issues/50


Add constexpr to IndexRange, and let BSplineInterpolationWeightFunction make use of it

Added constexpr to many IndexRange functions
Estimated the OffsetToIndexTable of BSplineInterpolationWeightFunction at compile-time

incidentally, commit 01b5ca36ef1589b59929947d8cbafd94656fb3da has removed one of the unbalanced group Doxygen warnings (issue #3654):
https://open.cdash.org/viewBuildError.php?type=1&onlydeltan&buildid=9647938


🌟Feature request: Allow non-floating mode for menu

Is your feature request related to a problem? Please describe.
I want my select and comboxes to float on desktops just like they do now but on mobile I want them to become a 'bottom-sheet'. Like following image: (taken from this issue)

Desktop
Mobile

Describe the solution you'd like
I use CSS grids for overlaying content as I find it more logical to work with so not using position on menu based on some option property should do the job. Then I can just place it however I want using CSS grid or if I want melt to handle it then I toggle that option property back on.
Describe alternatives you've considered
I tried using option element inside a nested dialog (my select is inside a dialog) but option element is coupled with menu as was mentioned in this discord thread

You can disable floating UI on any builder. Just set position to null