Keep original port number in bcexporter & loki config

Issue ticket number and link
NONE
Description
There is no need to override the port number in the blockchain exporter config file. I am testing with custom ports and realized this with trial and error. As soon as I reverted the port number to the default one, which is the one that the process within the container uses, it started working fine and showing the metrics in the dashboard.
Type of change
Please delete option that is not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

We still want to allow port flexibility. So long as you update the server.exporter_endpoints.blockchain with the same port you're launching the client up with, it should be functional.
Can you give us steps to replicate the behavior you're experiencing?

We still want to allow port flexibility. So long as you update the server.exporter_endpoints.blockchain with the same hostip:port you're launching the client up with, it should be functional.
Can you give us steps to replicate the behavior you're experiencing?

Sure! Let me describe a bit since there is a possibility that I misunderstood something along the way and could be in the wrong here.
I did set up the server and clients using custom port numbers (no default ports). When I launched everything, node + container monitoring worked fine but the chain monitoring dashboard was not working. The dashboard was just empty.
Then I proceeded to check the blockchain_exporter logs and it seemed to be working fine given that it was logging stuff like this
http://<ip:port> sent metrics for chain 0021
Status: synced
Current Height: 15899825
Latest Height: 15899825

Given my lack of knowledge in the area, I went into trial an error mode. I hypothesized that maybe the exporter_port in the config.yml of the blockchain_exporter was supposed to be based on the container port number (9877) rather than the host port number (which I had set to 19877) for the process. So I manually changed it from 19877 to 9877 and then restarted the container and everything started to work fine and the chains dashboard started to show the graphs and data. Note that my blockchain exporter is still listening to 19877 in the host, but it seems that the the exporter_port in the config.yml of the blockchain exporter should be set to the container port number (9877) and not the host port number. At least thats how I got it working on my side.
I can share more details and log data if necessary.

Also, according to https://github.com/prometheus/client_python#http, it seems that it should be the container port that should be specified there, given that it is the port that the server will listen to because it runs inside the container.

@tohoPF I found a similar issue with the loki config. For example, I used 13100 as the custom host port for the loki process and I observed that loki-config.yml http_listen_port was set to 13100.
This makes the loki process unreachable since the docker container port mapping for loki is set to host-port:3100 (3100 is hardcoded as the container port), so http_listen_port should also be set to 3100 instead of the custom host port.

If you're doing manual setup, I highly recommend using our settings.yml and setup.py. The blockchain_exporter's port should be set to the same one that is public facing in docker compose which by default is 9877. This is how Prometheus is able to access the exporter and scrape the metrics.
As for Loki, http_listen_port is where loki is listening. Currently, the only thing that pushes to loki is Promtail for logs. Promtail uses a push model and is able to push logs to that port. This is why we use the public port and not the internal port.
Can you retry with latest staging branch using settings.yml and setup.py and tell me if you still face the same issues?

If you're doing manual setup, I highly recommend using our settings.yml and setup.py. The blockchain_exporter's port should be set to the same one that is public facing in docker compose which by default is 9877. This is how Prometheus is able to access the exporter and scrape the metrics.
As for Loki, http_listen_port is where loki is listening. Currently, the only thing that pushes to loki is Promtail for logs. Promtail uses a push model and is able to push logs to that port. This is why we use the public port and not the internal port.
Can you retry with latest staging branch using settings.yml and setup.py and tell me if you still face the same issues?

I am using settings.yml and setup.py. I am not doing any custom configuration other than specifying custom ports. Then I run the setup.py first and then I start the containers in the client/server side with the docker compose command. The only way it works if I leave the container port in the app specific settings in each of the services.
I did try again and ran everything from scratch because to be honest, I have custom ip tables stuff for firewall purposes so there is a possibility that I have something wrong there, but for me it only works if I specify the container port in the config files referenced in this PR.
Sorry to bug you here, but could you try custom ports and let me know if it works for you? Note that for blockchain_exporter, you need to rebuild the image/container because if you ran with default ports previously and you don't rebuild it will stick with the default port and it will work (this is what happened to me in the past). So to be 100% sure, docker exec to it and confirm that it has the custom port specified.
For reference, here is what my settings.xml file looks like, I just add 10000 to every port number.
clients:
  node_exporter:
    port: 19100
  cadvisor:
    port: 18080
  promtail:
    port: 19080
    loki_endpoint: <redacted>
    loki_port: 13100
    log_root_path: /var/log/nginx
  blockchain_exporter:
    port: 19877
    alias_enabled: True
    alias_name: LOCALHOST

server:
  host_ip: <redacted>
  loki:
    port: 13100
  prometheus:
    port: 19090
    exporter_endpoints:
      cadvisor: ["<redacted>:18080"]
      blockchain: ["<redacted>:19877"]
      node: ["<redacted>:19100"]
  grafana:
    port: 13000
  minio:
    port: 19000
  promtail:
    port: 19080
  alerts:
    interval: 60s
    contactpoints:
      slack:
        enabled: False
        url: https://hooks.slack.com/services/your_slack_webhook_string
      discord:
        enabled: True
        url: <redacted>
      teams:
        enabled: False
        url: https://ms_teams_url
      email:
        enabled: False
        addresses<EMAIL_ADDRESS><EMAIL_ADDRESS>      webhook:
        enabled: False
        url: https://endpoint_url
        httpMethod: POST # <string> options: POST, PUT
        username: my_username
        password: my_password
        authorization_scheme: my_bearer
        authorization_credentials: my_credentials
        maxAlerts: '10'

Wait, so now that I am thinking about this. Let me try again on a different environment with minimal iptables config to see how it goes for me.

Thanks @fortsoftware , we'll be replicating this on our environment today

@fortsoftware Hey I pushed some changes and tested. Let me know if the new commit on staging branch is working better for you.

Hello @tohoPF! Sorry for the late reply here. I got very busy during the past couple of days. I am going to test again tomorrow and let you know how it goes. Thanks for the changes!

@tohoPF it works fine now! Thanks! I will be closing this PR since it is not necessary anymore.

Changes not necessary anymore.


OverlappingObjectsWarning issued for perpendicular gates and rails

consider the following blueprint:

$ python3
Python 3.10.10 (main, Mar  5 2023, 22:26:53) [GCC 12.2.1 20230201] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import draftsman.blueprintable
>>> draftsman.blueprintable.get_blueprintable_from_string("0eNqdknELgjAQxb/L/b0ip3O6rxIRVocd6JRtRiL77jmlCBLE/rzj3u8ejzfApeqwNaQdqAHo2mgL6jiApVIXVdi5vkVQQA5rYKCLOkymoAo8A9I3fIKK/IkBakeOcNZPQ3/WXX1BMx58lNaN2vLudhOCQdvYUdXo8CqQYsmgB7UTIvae/YD4B1QWDpf0Yi/ehGgvRo83MnidT/gCMV4lyo3EZJWYbiSKP+KLluJLV61lG63J7daS3Ie+TI1SXwVk8EBj509ZlMicyzTnhyzm3r8A63LY5Q==")
<stdin>:1: OverlappingObjectsWarning: Added object 'straight-rail' (StraightRail) at (137.0, -551.0) intersects 'gate' (Gate) at (137.5, -551.5)
<stdin>:1: OverlappingObjectsWarning: Added object 'straight-rail' (StraightRail) at (137.0, -551.0) intersects 'gate' (Gate) at (136.5, -551.5)
<draftsman.classes.blueprint.Blueprint object at 0x7f70fbda0ca0>
>>>

The rail and gate are perpendicular so they're valid.
if they were parallel it should still probably emit, though.

Added a special case to check this for StraightRail and Gates. Ideally this would be abstracted out of spatial hashmap, but I'll leave that as a TODO for 2.0. This fix will be in 1.0.5.


Hosting

after running docz build i get a dist folder in .docz is that what i'm supposed to host? cos when i ran it, I got a blank page

Yes, the .docz/dist folder contains the build output. It's a static site with an index.html in it. It won't work just opening index.html in a browser, you need to serve it with a web server.

yeah i hosted it with now and got the same result: https://docz-wwrmllyirk.now.sh/dist/

If I open your site and look at the network activity in Chrome Dev Tools I'm getting a bunch of 404 for all the JS file Docz generates. Did you make sure to deploy the entire contents of the dist folder?

yeah even when i run it locally with a local server i get the same thing

oh fixed now... i actually deployed the .docz folder and the navigated to dist/... so right now i just deployed dist/ dicrectly

Is there any way to make it into a static build, instead of making dynamic calls to each component that I load. I want it to be static, i.e. no network calls.

It is already a static build. A static build doesn't mean no network calls, it means it can be served with a basic static file server. Sounds like what you're after is a version that doesn't do any code splitting, and you get the whole app with the first request? I don't think that's supported.
What's your use case? You need network connectivity to make the first request, so what's the problem with the subsequent ones?


Weird behaviour around __call

Hey.
Currently PropertyAccessor checks for the existence of magic __call method, and if it exists, attempts to call getFieldName() or setFieldName() methods, even though the field was defined as a property. What's worse is that this checks seems to be broken for __call:
#[Type]
class SomeDto {
    public function __construct() {
        #[Field]
        public readonly string $something,
    }

    public function __call(): void {}
}

Such code results in a ReflectionException: Method SomeDto:getSomething() does not exist in /app/vendor/thecodingmachine/graphqlite/src/Utils/PropertyAccessor.php:111 because it attempts to check whether method getSomething is public without checking if it even exists.
This is trivial to fix, but while we're here, why does it even try to call __call? In my case __call only exists for backwards compatibility with older style properties that had getters, so __call just directs all $this->getSomething() to $this->something, but I'd imagine it doesn't work that way in all cases, so it seems strange to me that __call has the priority over setting the property directly.
I'd advocate that graphqlite should follow the general logic of PHP here: if a "hardcode" property/method exists, it's always used and magic methods are never called. In this case, I'd expect it to first check for a real getter method, then a real property, and only then a magic setter method.
Does this make sense?

Yes, it makes sense.  I think these magic methods were added initially as a way to keep "clean" objects.  But with recent improvements to PHP's class syntax, they're really unnecessary.  Nonetheless, I agree with your take that if the method exists it should take precedence.


i hava change SDK to 24 , why still call me Error:Failed to resolve: com.android.support:design:25.0.0

i want to use SDK 24 and i change it :
compileSdkVersion 24
buildToolsVersion "24.0.3"
compile 'com.android.support:appcompat-v7:24.2.1'
compile 'com.android.support:recyclerview-v7:24.2.1'
compile 'com.android.support:cardview-v7:24.2.1'
compile 'com.android.support:design:24.2.1'
but when i gradle sync
it still call me Error:Failed to resolve: com.android.support:design:25.0.0
thx u  please ~

I do not know....library is based on last version of support libraries, so you should probably use same version in your project.


Emissions variable Domestic Aviation - add back in

Somehow, the Domestic Aviation emissions variable did not make it in the previous pull request.
This was previously available under Emissions|*|Energy|Demand|Transportation|Aviation.
For clarity, I propose to reintroduce it as Emissions|*|Energy|Demand|Transportation|**Domestic** Aviation for clarity.
(thx @merfort for pinging me on this; @IAMconsortium/common-definitions-emissions )

OK, I see.
But then this can only be on the global/international level, correct?
You only have global aviation?
Does the regional 'Transportation' variable include or exclude emissions from domestic aviation?

Would it be an issue for you @merfort if we don't add that aggregate variable in the reporting template?
See https://github.com/IAMconsortium/common-definitions/pull/228#issuecomment-2522490286 .
@danielhuppmann ; thing it, we will need to create it still for the CMIP7 harmonization anyhow, as we'll need to align with the CEDS variable.

Thanks! It is fine for now. I will come back to it later.

About reporting for international bunkers (emissions and fuel), these values are still available at national resolution, just not consistently counted to national statistics.
Whether a model represents international bunkers at the model-native regional resolution or only at global level is a different question.


Using alt and title attribute

Only for SEO, it would be great if fotorama respect the title and alt attributes. I put it them but the fotorama script cut them off.

++++++++++++++

From SEO prospective if you place attributes on the page it's enough for crawler catch them. It doesn't matter what some js does on the page after load. Crawler will get full version of code.
So why do need fotorama might support alt and title attributes?

Step one:
Open file fotorama.dev.js and search this string:
frameData.state = '';
add the following line:
if ( frameData.data.hasOwnProperty('alt') ) {
 img.alt= frameData.data.alt;
 }
 if ( frameData.data.hasOwnProperty('title') ) {
 img.title= frameData.data.title;
 }

Step two:
Search string:
height = numberFromMeasure(imgData.height || $img.attr('height'));
And replace it:
height = numberFromMeasure(imgData.height || $img.attr('height')),
 alt = $img.attr('alt'),
 title = $img.attr('title');
 if (alt){
 $.extend(imgData, {
 alt: alt
  });
  }
  if (title){
  $.extend(imgData, {
  title: title
  });
  }

Step three:
Minify and rename file to fotorama.js
tested in 4.6.4 version.
P.S. sorry for my English =)

in my case it did not work as described above.
But i change second block of code
 height = numberFromMeasure(imgData.height || $img.attr('height')),                 alt = $child.attr('alt'),                 title = $child.attr('alt');             if (alt){                 $.extend(imgData, {                     alt: alt                 });             }             if (title){                 $.extend(imgData, {                     title: title                 });             }
This is very strange, but $img - is object of <a> tag, but $child is <img>

I don't understand why author can't add support for alt and title attributes. I will make fork of fotorama just for add alt and title attrs. Maybe after this author will make needed changes.

My version
height = numberFromMeasure(imgData.height || $img.attr('height')),
    alt    = $child.context.alt,
    title  = $child.context.title;

    if (alt)   { $.extend(imgData, { alt: alt }); }
    if (title) { $.extend(imgData, { title: title }); }

Closing this as duplicate of #329


Pipeline resolvers, without lambda function

Which Category is your question related to?
I'm trying to create a pipeline of resolvers without lambda function
Amplify CLI Version
4.17.2
Provide additional details e.g. code snippets
type Blog @model(mutations: null, subscriptions: null) {
     id: ID!
     name: String!
}

type Post @model(mutations: null, subscriptions: null){
     id: ID!
     title: String!
}

type Query {
     doubleResolver(ID: ID!): Blog
}

Let's say, for no particular reason, I want to create a Post and read a Blog,

can a resolver do an update and a get operation? something like transact resolver but with update and get

Edit: I did more researches and found out the answers to the previous questions, now I just leave this one because I couldn't find it anywhere

@mdepascale Yes, you can use update/get in each resolver. Each function in the pipeline gets its own resolver.

thank you


feature: add abstract interface for llama and chatglm

TODO: implement the chatglm2 train

@mikecovlee can you test if the llama output is the same as before?

Confirmed Good.


Can't connect account

Glad to hear you made some progress. I added the custom repository, downloaded it, restarted.
I see "everlights bridge" in my list of integrations available to be added. When I click on it to begin the configuration, it prompts me to sign into my mill.com account.
I did try entering my everlights email just to see if it was just a bad label but I get "unknown error occurred."

It connects locally - redownload 0.1.5 (I fixed the config_flow translations that I "borrowed" from my mill integration)
It should prompt for a host.  you can enter an IP or hostname if you have local DNS.
You have a mill food recycler too?

I do not have any products or an account through mill.
The onboarding still prompts for the mill account but I typed the IP of my hub and it pushed through.
So now the integration is seeing my hub but isn't producing any devices or entities.
I'm not at home at the moment, though I don't see why that would matter. I will check again when I get home just to be sure.

I'm still figuring out the deployments/config_flows, but I'm pretty sure it is cached.
You will want to delete your hub and re-add it though.  it most likely stored your IP as your username in the config

Still having the same problem.  I fiddled with the code for a little while but couldn't make any progress so I deleted what I had and redownloaded to make sure we are still working from the same page.  I have also deleted and re-added my bridge several times but it hasn't helped.
Here is the error I'm getting:
Error while setting up everlightsv3 platform for light
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/everlightsv3/light.py", line 20, in async_setup_entry
host = config.data[CONF_HOST]
~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'host'

Hey, I've still been trying but can't get anywhere. Every time I remove and re-add my bridge, it's the same thing. Do you have any other ideas?

Delete the integration, the EverLights HACS integration, and restart. Then reinstall everllights HACS integration and add the integration.

Logger: homeassistant.components.light
Source: helpers/entity_platform.py:359
Integration: Light (documentation, issues)
First occurred: 9:37:19 AM (3 occurrences)
Last logged: 9:38:11 AM
Error while setting up everlightsv3 platform for light
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/everlightsv3/light.py", line 20, in async_setup_entry
host = config.data[CONF_HOST]
~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'host'
That's what I get no matter what combination of deleting, restarting, re-adding. Every single time.

Yup - I can reproduce...
I'm getting my arms around this config flow of the setup.  Hang in there.

All good! Let me know when you are ready for me to give it another shot.

Alright...  Delete the integration, the EverLights HACS integration, and restart. Then reinstall EverLights HACS integration (.0.2.0) and add the integration.  There is still some refresh issues, but you should have control of your light.

@theOrakle do you have a list of “things still to do”? I’d be happy to help.

Updated and seems to be working. Thank you and nice job!
Feel free to close this.

@theOrakle do you have a list of “things still to do”? I’d be happy to help.

I do not yet...  I wanted to get it reverse engineered and rough functionality before Halloween.


[Suggestion] Compress backups

CDDA saves are highly "compressible" (200Mb->30Mb) thus compressing backups would not only save storage space would would be actually faster on most "modern" pcs (time to write 200Mb is usually higher than time to compress 200Mb + time to write 30Mb).

As soon as this goes through.


Beneficiary ID in menu

When beneficiaries log in, show their ID in the top right. I hope this will help admin user notice that they are in beneficiary accounts.

Replaced with #703. I don't think showing Ben IDs in the menu is a good idea, charities may not want users seeing their IDs for instance.


Bug: problem with the application start

Describe the bug
Bug Description
Missing requests library at game launch
Expected Behavior
The game starts after the setup instructions
Steps to Reproduce
Follow the Setup instructions

As instructed, clone the repository from the master branch to a new folder
Perform all steps 2 - 4
Game does not start

Additional Context
An error will appear in the console:
(venv) PS D:\projects\python\pydew-valley-uzh> python main.py
pygame-ce 2.5.0 (SDL 2.30.3, Python 3.13.1)
Traceback (most recent call last):
  File "D:\projects\python\pydew-valley-uzh\main.py", line 18, in <module>
    from src.client import send_telemetry
  File "D:\projects\python\pydew-valley-uzh\src\client.py", line 5, in <module>
    import requests  # type: ignore[import-untyped]
    ^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'requests'
(venv) PS D:\projects\python\pydew-valley-uzh>

To run the game, manually install the missing library in src/client.py:
requests==2.32.3

Version
0.1.0
Which aspect(s) of the project is this bug affecting?
area: code quality, area: dependencies
Screenshots

Relevant log output
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Install the latest PowerShell for new features and improvements! https://aka.ms/PSWindows

PS D:\projects\python> git clone https://github.com/sloukit/pydew-valley-uzh.git
Cloning into 'pydew-valley-uzh'...
remote: Enumerating objects: 6922, done.
remote: Counting objects: 100% (1982/1982), done.
remote: Compressing objects: 100% (382/382), done.
remote: Total 6922 (delta 1762), reused 1600 (delta 1600), pack-reused 4940 (from 3)
Receiving objects: 100% (6922/6922), 19.06 MiB | 6.48 MiB/s, done.
Resolving deltas: 100% (4783/4783), done.
PS D:\projects\python> cd .\pydew-valley-uzh\
PS D:\projects\python\pydew-valley-uzh> python -m venv venv
PS D:\projects\python\pydew-valley-uzh> venv\Scripts\activate
(venv) PS D:\projects\python\pydew-valley-uzh> pip install -r requirements.txt
Collecting PyTMX==3.32 (from -r requirements.txt (line 1))
  Using cached PyTMX-3.32-py3-none-any.whl.metadata (1.0 kB)
Collecting pathfinding==1.0.10 (from -r requirements.txt (line 2))
  Using cached pathfinding-1.0.10-py3-none-any.whl.metadata (4.6 kB)
Collecting pygame-ce==2.5.0 (from -r requirements.txt (line 3))
  Using cached pygame_ce-2.5.0-cp313-cp313-win_amd64.whl
Collecting openpyxl==3.1.5 (from -r requirements.txt (line 6))
  Using cached openpyxl-3.1.5-py2.py3-none-any.whl.metadata (2.5 kB)
Collecting et-xmlfile (from openpyxl==3.1.5->-r requirements.txt (line 6))
  Using cached et_xmlfile-2.0.0-py3-none-any.whl.metadata (2.7 kB)
Using cached PyTMX-3.32-py3-none-any.whl (24 kB)
Using cached pathfinding-1.0.10-py3-none-any.whl (22 kB)
Using cached openpyxl-3.1.5-py2.py3-none-any.whl (250 kB)
Using cached et_xmlfile-2.0.0-py3-none-any.whl (18 kB)
Installing collected packages: pathfinding, PyTMX, pygame-ce, et-xmlfile, openpyxl
Successfully installed PyTMX-3.32 et-xmlfile-2.0.0 openpyxl-3.1.5 pathfinding-1.0.10 pygame-ce-2.5.0
(venv) PS D:\projects\python\pydew-valley-uzh> pip install -r requirements-dev.txt
Collecting ruff~=0.5 (from -r requirements-dev.txt (line 1))
  Using cached ruff-0.8.4-py3-none-win_amd64.whl.metadata (25 kB)
Collecting pygbag==0.9.2 (from -r requirements-dev.txt (line 2))
  Using cached pygbag-0.9.2-py3-none-any.whl.metadata (7.4 kB)
Collecting rich==13.9.4 (from -r requirements-dev.txt (line 3))
  Using cached rich-13.9.4-py3-none-any.whl.metadata (18 kB)
Collecting markdown-it-py>=2.2.0 (from rich==13.9.4->-r requirements-dev.txt (line 3))
  Using cached markdown_it_py-3.0.0-py3-none-any.whl.metadata (6.9 kB)
Collecting pygments<3.0.0,>=2.13.0 (from rich==13.9.4->-r requirements-dev.txt (line 3))
  Using cached pygments-2.18.0-py3-none-any.whl.metadata (2.5 kB)
Collecting mdurl~=0.1 (from markdown-it-py>=2.2.0->rich==13.9.4->-r requirements-dev.txt (line 3))
  Using cached mdurl-0.1.2-py3-none-any.whl.metadata (1.6 kB)
Using cached pygbag-0.9.2-py3-none-any.whl (171 kB)
Using cached rich-13.9.4-py3-none-any.whl (242 kB)
Using cached ruff-0.8.4-py3-none-win_amd64.whl (9.7 MB)
Using cached markdown_it_py-3.0.0-py3-none-any.whl (87 kB)
Using cached pygments-2.18.0-py3-none-any.whl (1.2 MB)
Using cached mdurl-0.1.2-py3-none-any.whl (10.0 kB)
Installing collected packages: ruff, pygments, pygbag, mdurl, markdown-it-py, rich
Successfully installed markdown-it-py-3.0.0 mdurl-0.1.2 pygbag-0.9.2 pygments-2.18.0 rich-13.9.4 ruff-0.8.4
(venv) PS D:\projects\python\pydew-valley-uzh> pip install -r requirements-test.txt
Collecting pytest==8.3 (from -r requirements-test.txt (line 1))
  Using cached pytest-8.3.0-py3-none-any.whl.metadata (7.5 kB)
Collecting tox==4.16 (from -r requirements-test.txt (line 2))
  Using cached tox-4.16.0-py3-none-any.whl.metadata (5.0 kB)
Collecting pytest-cov==5.0.0 (from -r requirements-test.txt (line 3))
  Using cached pytest_cov-5.0.0-py3-none-any.whl.metadata (27 kB)
Collecting iniconfig (from pytest==8.3->-r requirements-test.txt (line 1))
  Using cached iniconfig-2.0.0-py3-none-any.whl.metadata (2.6 kB)
Collecting packaging (from pytest==8.3->-r requirements-test.txt (line 1))
  Using cached packaging-24.2-py3-none-any.whl.metadata (3.2 kB)
Collecting pluggy<2,>=1.5 (from pytest==8.3->-r requirements-test.txt (line 1))
  Using cached pluggy-1.5.0-py3-none-any.whl.metadata (4.8 kB)
Collecting colorama (from pytest==8.3->-r requirements-test.txt (line 1))
  Using cached colorama-0.4.6-py2.py3-none-any.whl.metadata (17 kB)
Collecting cachetools>=5.3.3 (from tox==4.16->-r requirements-test.txt (line 2))
  Using cached cachetools-5.5.0-py3-none-any.whl.metadata (5.3 kB)
Collecting chardet>=5.2 (from tox==4.16->-r requirements-test.txt (line 2))
  Using cached chardet-5.2.0-py3-none-any.whl.metadata (3.4 kB)
Collecting filelock>=3.15.4 (from tox==4.16->-r requirements-test.txt (line 2))
  Using cached filelock-3.16.1-py3-none-any.whl.metadata (2.9 kB)
Collecting platformdirs>=4.2.2 (from tox==4.16->-r requirements-test.txt (line 2))
  Using cached platformdirs-4.3.6-py3-none-any.whl.metadata (11 kB)
Collecting pyproject-api>=1.7.1 (from tox==4.16->-r requirements-test.txt (line 2))
  Using cached pyproject_api-1.8.0-py3-none-any.whl.metadata (2.7 kB)
Collecting virtualenv>=20.26.3 (from tox==4.16->-r requirements-test.txt (line 2))
  Using cached virtualenv-20.28.0-py3-none-any.whl.metadata (4.4 kB)
Collecting coverage>=5.2.1 (from coverage[toml]>=5.2.1->pytest-cov==5.0.0->-r requirements-test.txt (line 3))
  Using cached coverage-7.6.10-cp313-cp313-win_amd64.whl.metadata (8.4 kB)
Collecting distlib<1,>=0.3.7 (from virtualenv>=20.26.3->tox==4.16->-r requirements-test.txt (line 2))
  Using cached distlib-0.3.9-py2.py3-none-any.whl.metadata (5.2 kB)
Using cached pytest-8.3.0-py3-none-any.whl (341 kB)
Using cached tox-4.16.0-py3-none-any.whl (156 kB)
Using cached pytest_cov-5.0.0-py3-none-any.whl (21 kB)
Using cached cachetools-5.5.0-py3-none-any.whl (9.5 kB)
Using cached chardet-5.2.0-py3-none-any.whl (199 kB)
Using cached colorama-0.4.6-py2.py3-none-any.whl (25 kB)
Using cached coverage-7.6.10-cp313-cp313-win_amd64.whl (211 kB)
Using cached filelock-3.16.1-py3-none-any.whl (16 kB)
Using cached packaging-24.2-py3-none-any.whl (65 kB)
Using cached platformdirs-4.3.6-py3-none-any.whl (18 kB)
Using cached pluggy-1.5.0-py3-none-any.whl (20 kB)
Using cached pyproject_api-1.8.0-py3-none-any.whl (13 kB)
Using cached virtualenv-20.28.0-py3-none-any.whl (4.3 MB)
Using cached iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Using cached distlib-0.3.9-py2.py3-none-any.whl (468 kB)
Installing collected packages: distlib, pluggy, platformdirs, packaging, iniconfig, filelock, coverage, colorama, chardet, cachetools, virtualenv, pytest, pyproject-api, tox, pytest-cov
Successfully installed cachetools-5.5.0 chardet-5.2.0 colorama-0.4.6 coverage-7.6.10 distlib-0.3.9 filelock-3.16.1 iniconfig-2.0.0 packaging-24.2 platformdirs-4.3.6 pluggy-1.5.0 pyproject-api-1.8.0 pytest-8.3.0 pytest-cov-5.0.0 tox-4.16.0 virtualenv-20.28.0
(venv) PS D:\projects\python\pydew-valley-uzh> python main.py
pygame-ce 2.5.0 (SDL 2.30.3, Python 3.13.1)
Traceback (most recent call last):
  File "D:\projects\python\pydew-valley-uzh\main.py", line 18, in <module>
    from src.client import send_telemetry
  File "D:\projects\python\pydew-valley-uzh\src\client.py", line 5, in <module>
    import requests  # type: ignore[import-untyped]
    ^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'requests'
(venv) PS D:\projects\python\pydew-valley-uzh>

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

I forgot to mention:

the version of my operating system: Windows 11 Home
the version of Python: Python 3.13.1


Kata discipline is not documented

Please create a documentation page on the site :smile:

I see a list of disciplines at http://www.codewars.com/docs/kata-creator.  Is that what you are referring to?

yes ty :)


C++ files may take a .C extension.

In languages.yml,  please consider adding the line
- ".C"
to the C++: extension list, since capital C is a valid C++ extension for the gnu compiler and its omission from the list is causing mis-classification of my repository.
Thank you

See pchaigno's comment at https://github.com/github/linguist/pull/2930. Linguist treats extensions case-insensitively. I mentioned a solution at https://github.com/github/linguist/pull/3937 but haven't got a reply yet

I managed to solve the problem by adding a .gitattributes file to my repository as suggested in the Overrides section of the README.md of github/linguist.


add sharded data parallel all gather time estimation

When using fsdp shard_grad_op and full_shard, model weights are unsharded through allgather before being used for execution. This PR adds the time estimation of the all gather. If the all gather time > layer compute time, all gather time cannot be fully overlapped with compute. The time estimation relies on intra node and inter node memory bandwidth efficiency, which depends on the size of the data to transfer. 0.8 is a good estimation for data size > 128MB. for small data size, set the efficiency to a lower number.

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (21d9fa3) 80.33% compared to head (60fc071) 80.64%.
Report is 2 commits behind head on main.

Files
Patch %
Lines

llm_analysis/analysis.py
88.23%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   80.33%   80.64%   +0.30%
==========================================
  Files           8        8
  Lines        1083     1121      +38
==========================================
+ Hits          870      904      +34
- Misses        213      217       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support for speed calculation

( Length of ship / time in seconds ) * 1.944

Finished this and added.


Fix warning message

Codecov Report

Merging #387 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master    #387      +/-   ##
===========================================
- Coverage     52.06%   51.9%   -0.16%
  Complexity      443     443
===========================================
  Files           124     124
  Lines          1990    1992       +2
  Branches         97      98       +1
===========================================
- Hits           1036    1034       -2
- Misses          890     893       +3
- Partials         64      65       +1

Impacted Files
Coverage Δ
Complexity Δ

...rvicebus/converter/ServiceBusMessageConverter.java
37.03% <0%> (-10.97%)
7 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e4bff...e4194c8. Read the comment docs.


Deploy to DigitalOcean

The DigitalOcean deployment of Empirica worked after you changed the http port from 8080 -> 3000; the below configuration file called stringray-app.yaml is the correct one:
name: stingray-app
region: nyc
services:
- dockerfile_path: Dockerfile
  github:
    branch: james-ngrok-debug
    repo: Watts-Lab/deliberation-empirica
  http_port: 3000
  instance_count: 1
  instance_size_slug: basic-xs
  name: deliberation-empirica
  routes:
  - path: /
  source_dir: /

@JamesPHoughton Please review and close the issue if the fix makes sense.

Unfortunately, we are still running into this issue on the DO server: https://github.com/Watts-Lab/deliberation-project/issues/34#issuecomment-1138631980. To fix it, we need a deeper change to empirica: https://github.com/empiricaly/empirica/issues/99 (hopefully still less than is needed to build prod).


PHP 7.3

Hi.
Why is 7.4 written in the dependencies, although it requires 7.3 in Fortify?

I think that's just leftover from the Spatie Skeleton. I can update it to match Fortify.

Updated! Thanks for notifying me.


python311Packages.marimo: 0.3.12 -> 0.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.marimo is: A reactive Python notebook that's reproducible, git-friendly, and deployable as scripts or apps
meta.homepage for python311Packages.marimo is: https://github.com/marimo-team/marimo
meta.changelog for python311Packages.marimo is: https://github.com/marimo-team/marimo/releases/tag/0.4.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.0 with grep in /nix/store/12mq3fglabj60v1dlbn8aj052b8p0xwz-python3.11-marimo-0.4.0
found 0.4.0 in filename of file in /nix/store/12mq3fglabj60v1dlbn8aj052b8p0xwz-python3.11-marimo-0.4.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
marimo
python311Packages.marimo
python312Packages.marimo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/12mq3fglabj60v1dlbn8aj052b8p0xwz-python3.11-marimo-0.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.marimo https://github.com/r-ryantm/nixpkgs/archive/94436f928800ec5d2cd19b8214c8c6b44eaa183f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/94436f928800ec5d2cd19b8214c8c6b44eaa183f#python311Packages.marimo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/12mq3fglabj60v1dlbn8aj052b8p0xwz-python3.11-marimo-0.4.0
ls -la /nix/store/12mq3fglabj60v1dlbn8aj052b8p0xwz-python3.11-marimo-0.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages built:

marimo (python311Packages.marimo)
marimo.dist (python311Packages.marimo.dist)
python312Packages.marimo
python312Packages.marimo.dist

Maintainer pings
cc @akshayka @dmadisetti for testing.

Dupe of #304456


Godot 4.0 support?

Hey, great add-on. Is this compatible with Godot 4.0? If not, are you planning on updating it?
Thanks.

Yes, this will be updated to Godot 4.0, currently it is not compatible.

Has there been any progress on this? I've been trying to port this myself and I'm not having too much luck.

I've been busy with my own game, this will be rewritten for Godot 4 on the next weekend :)

Thank you!!
if it's not any trouble would you be willing to explain what you change? I don't fully understand how websockets work and even less so the way they changed from Godot 3.5 to 4, It looks like WebSocketClient is completely gone.

Done, please test if everything works properly <3

Looks like it's working, thank you!! 🙇 🙇 🙇


Limited Power on XPS 9370

Hello and good day,
I'm testing a little more at the moment with the XPS 9370 and the new --monitor feature.
It seems that Power is limited most of the time with the charger plugged in. I'm using the official 45W charger and an XPS 15 charger with a lot more juice and an USB-C adapter.
s-tui says it just consumes 11W of 18W max.
On battery the Power value is OK because of the lower TPD (I guess).
Perhaps someone has a clue where I could look further.

Can you please check with --debug if all the values are correctly written?

Thank you for the quick response.
It seems so - this is my output:
[D] core 0 thermal status: thermal limit status = 0
[D] core 0 thermal status: thermal limit log = 0
[D] core 0 thermal status: prochot or forcepr status = 0
[D] core 0 thermal status: prochot or forcepr log = 0
[D] core 0 thermal status: crit temp status = 0
[D] core 0 thermal status: crit temp log = 0
[D] core 0 thermal status: thermal threshold1 status = 0
[D] core 0 thermal status: thermal threshold1 log = 0
[D] core 0 thermal status: thermal threshold2 status = 0
[D] core 0 thermal status: thermal threshold2 log = 0
[D] core 0 thermal status: power limit status = 0
[D] core 0 thermal status: power limit log = 0
[D] core 0 thermal status: current limit status = 0
[D] core 0 thermal status: current limit log = 0
[D] core 0 thermal status: cross domain limit status = 0
[D] core 0 thermal status: cross domain limit log = 0
[D] core 0 thermal status: cpu temp = 59
[D] core 0 thermal status: temp resolution = 1
[D] core 0 thermal status: reading valid = 1
[D] core 1 thermal status: thermal limit status = 0
[D] core 1 thermal status: thermal limit log = 0
[D] core 1 thermal status: prochot or forcepr status = 0
[D] core 1 thermal status: prochot or forcepr log = 0
[D] core 1 thermal status: crit temp status = 0
[D] core 1 thermal status: crit temp log = 0
[D] core 1 thermal status: thermal threshold1 status = 0
[D] core 1 thermal status: thermal threshold1 log = 0
[D] core 1 thermal status: thermal threshold2 status = 0
[D] core 1 thermal status: thermal threshold2 log = 0
[D] core 1 thermal status: power limit status = 0
[D] core 1 thermal status: power limit log = 0
[D] core 1 thermal status: current limit status = 0
[D] core 1 thermal status: current limit log = 0
[D] core 1 thermal status: cross domain limit status = 0
[D] core 1 thermal status: cross domain limit log = 0
[D] core 1 thermal status: cpu temp = 57
[D] core 1 thermal status: temp resolution = 1
[D] core 1 thermal status: reading valid = 1
[D] core 2 thermal status: thermal limit status = 0
[D] core 2 thermal status: thermal limit log = 0
[D] core 2 thermal status: prochot or forcepr status = 0
[D] core 2 thermal status: prochot or forcepr log = 0
[D] core 2 thermal status: crit temp status = 0
[D] core 2 thermal status: crit temp log = 0
[D] core 2 thermal status: thermal threshold1 status = 0
[D] core 2 thermal status: thermal threshold1 log = 0
[D] core 2 thermal status: thermal threshold2 status = 0
[D] core 2 thermal status: thermal threshold2 log = 0
[D] core 2 thermal status: power limit status = 0
[D] core 2 thermal status: power limit log = 0
[D] core 2 thermal status: current limit status = 0
[D] core 2 thermal status: current limit log = 0
[D] core 2 thermal status: cross domain limit status = 0
[D] core 2 thermal status: cross domain limit log = 0
[D] core 2 thermal status: cpu temp = 59
[D] core 2 thermal status: temp resolution = 1
[D] core 2 thermal status: reading valid = 1
[D] core 3 thermal status: thermal limit status = 0
[D] core 3 thermal status: thermal limit log = 0
[D] core 3 thermal status: prochot or forcepr status = 0
[D] core 3 thermal status: prochot or forcepr log = 0
[D] core 3 thermal status: crit temp status = 0
[D] core 3 thermal status: crit temp log = 0
[D] core 3 thermal status: thermal threshold1 status = 0
[D] core 3 thermal status: thermal threshold1 log = 0
[D] core 3 thermal status: thermal threshold2 status = 0
[D] core 3 thermal status: thermal threshold2 log = 0
[D] core 3 thermal status: power limit status = 0
[D] core 3 thermal status: power limit log = 0
[D] core 3 thermal status: current limit status = 0
[D] core 3 thermal status: current limit log = 0
[D] core 3 thermal status: cross domain limit status = 0
[D] core 3 thermal status: cross domain limit log = 0
[D] core 3 thermal status: cpu temp = 59
[D] core 3 thermal status: temp resolution = 1
[D] core 3 thermal status: reading valid = 1
[D] core 4 thermal status: thermal limit status = 0
[D] core 4 thermal status: thermal limit log = 0
[D] core 4 thermal status: prochot or forcepr status = 0
[D] core 4 thermal status: prochot or forcepr log = 0
[D] core 4 thermal status: crit temp status = 0
[D] core 4 thermal status: crit temp log = 0
[D] core 4 thermal status: thermal threshold1 status = 0
[D] core 4 thermal status: thermal threshold1 log = 0
[D] core 4 thermal status: thermal threshold2 status = 0
[D] core 4 thermal status: thermal threshold2 log = 0
[D] core 4 thermal status: power limit status = 0
[D] core 4 thermal status: power limit log = 0
[D] core 4 thermal status: current limit status = 0
[D] core 4 thermal status: current limit log = 0
[D] core 4 thermal status: cross domain limit status = 0
[D] core 4 thermal status: cross domain limit log = 0
[D] core 4 thermal status: cpu temp = 59
[D] core 4 thermal status: temp resolution = 1
[D] core 4 thermal status: reading valid = 1
[D] core 5 thermal status: thermal limit status = 0
[D] core 5 thermal status: thermal limit log = 0
[D] core 5 thermal status: prochot or forcepr status = 0
[D] core 5 thermal status: prochot or forcepr log = 0
[D] core 5 thermal status: crit temp status = 0
[D] core 5 thermal status: crit temp log = 0
[D] core 5 thermal status: thermal threshold1 status = 0
[D] core 5 thermal status: thermal threshold1 log = 0
[D] core 5 thermal status: thermal threshold2 status = 0
[D] core 5 thermal status: thermal threshold2 log = 0
[D] core 5 thermal status: power limit status = 0
[D] core 5 thermal status: power limit log = 0
[D] core 5 thermal status: current limit status = 0
[D] core 5 thermal status: current limit log = 0
[D] core 5 thermal status: cross domain limit status = 0
[D] core 5 thermal status: cross domain limit log = 0
[D] core 5 thermal status: cpu temp = 57
[D] core 5 thermal status: temp resolution = 1
[D] core 5 thermal status: reading valid = 1
[D] core 6 thermal status: thermal limit status = 0
[D] core 6 thermal status: thermal limit log = 0
[D] core 6 thermal status: prochot or forcepr status = 0
[D] core 6 thermal status: prochot or forcepr log = 0
[D] core 6 thermal status: crit temp status = 0
[D] core 6 thermal status: crit temp log = 0
[D] core 6 thermal status: thermal threshold1 status = 0
[D] core 6 thermal status: thermal threshold1 log = 0
[D] core 6 thermal status: thermal threshold2 status = 0
[D] core 6 thermal status: thermal threshold2 log = 0
[D] core 6 thermal status: power limit status = 0
[D] core 6 thermal status: power limit log = 0
[D] core 6 thermal status: current limit status = 0
[D] core 6 thermal status: current limit log = 0
[D] core 6 thermal status: cross domain limit status = 0
[D] core 6 thermal status: cross domain limit log = 0
[D] core 6 thermal status: cpu temp = 59
[D] core 6 thermal status: temp resolution = 1
[D] core 6 thermal status: reading valid = 1
[D] core 7 thermal status: thermal limit status = 0
[D] core 7 thermal status: thermal limit log = 0
[D] core 7 thermal status: prochot or forcepr status = 0
[D] core 7 thermal status: prochot or forcepr log = 0
[D] core 7 thermal status: crit temp status = 0
[D] core 7 thermal status: crit temp log = 0
[D] core 7 thermal status: thermal threshold1 status = 0
[D] core 7 thermal status: thermal threshold1 log = 0
[D] core 7 thermal status: thermal threshold2 status = 0
[D] core 7 thermal status: thermal threshold2 log = 0
[D] core 7 thermal status: power limit status = 0
[D] core 7 thermal status: power limit log = 0
[D] core 7 thermal status: current limit status = 0
[D] core 7 thermal status: current limit log = 0
[D] core 7 thermal status: cross domain limit status = 0
[D] core 7 thermal status: cross domain limit log = 0
[D] core 7 thermal status: cpu temp = 59
[D] core 7 thermal status: temp resolution = 1
[D] core 7 thermal status: reading valid = 1
[D] TEMPERATURE_TARGET - write 0x5 - read 0x5 - match OK
[D] CONFIG_TDP_CONTROL - write 0x0 - read 0x0 - match OK
[D] MSR PACKAGE_POWER_LIMIT - write 0xcc816000dc8160 - read 0xcc816000dc8160 - match OK
[D] MCHBAR PACKAGE_POWER_LIMIT - write 0xcc816000dc8160 - read 0xcc816000dc8160 - match OK

I see the same issue on my 9370 after upgrading to recent version (I had not done so for several months).
If I boot with AC power connected, it limits power as per the configuration file.  I have to disconnect and reconnect AC power for it to recognise it is there.
Despite this, "cat /sys/class/power_supply/AC*/online" returns the correct value at all times.

reconnecting the power cord does not have an effect for me.
When it's connected it's limited.
When I disconnect the AC the settings of the battery section are working fine.
When I connect the AC it's limited again.
Thunderbolt ports on the left and the USB-C on the right don't make a difference.

I just flashed the older BIOS 1.5.1 again (had 1.6.3 before) and the issue persists.

I see the same issue on my 9370 after upgrading to recent version (I had not done so for several months).
If I boot with AC power connected, it limits power as per the battery section of the configuration file. I have to disconnect and reconnect AC power for it to detect it and remove the power limit.
Despite this, "cat /sys/class/power_supply/AC*/online" returns the correct value at all times.
I am not sure if it makes any difference, but power is connected via a Thunderbolt / USB-C hub.

This sounds like a bug to me. It might be related to the event-based code which previously was just constantly polling the value from sysfs.

@erpalma Thanks for the hint.
I'm using v0.3 for now and it works fine.

I've just updated the monitor mode to print the power source. This way you can check if there is a mismatch and thus a bug in that code.

I also observed a similar behavior a couple of times, but it was related to TLP. Restarting the daemon fixed the issue.

I for myself hadn't TLP installed. I used powertop --autotune on boot.

I repeated test and rather than disconnect/reconnect AC, tried starting/stopping TLP service as well as manually running "tlp true" and "tlp false" but this did not do anything, the problem still existed.
I then disabled TLP and repeated the test by disconnecting/reconnecting AC and got the same result as yesterday:

Booting with AC connected seems to enforce 18W / 11W power limits that are not in config file.  Disconnecting and reconnecting AC enforces correct specified limits. (debug log attached)
Booting with AC disconnected applies power limit of 15W correctly as specified in config file.  When AC is later connected it correctly applies the higher limit specified in config file.

If you look closely you can see when it kicks in to life, momentarily applying the 15W limit whilst on battery immediately before switching to AC power.
lenovo2.log
lenovo_fix.conf.txt


feat: add option to customize template in custom admin views config

Description
Currently a custom views in beta are wrapped with the Minimal template by default and you can't remove it and neither change it to the Default template. Because of this i can't migrate the views in my application from 2.0 to 3.0 (in 2.0 we were importing templates directly, but i guess this way could be better as less boilerplate)
Adds also abillity to apply classname to the template
Included e2e
change requires to update the doc but currently the doc mentions react-router so i think it's not updated to beta at this point.

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes

this is the only thing why i'm using a custom version of Payload now
you clearly cannot migrate a custom view that uses default template from 2.0 to 3.0 without this change (or custom next js page, which could be  awkward)
or i'm missing something?


samples: ipc: static_vrings add NXP boards support

This commit adds support for these NXP Multi-core boards for IPC static_vrings sample using OpenAmp lib:

lpcxpresso55s69
mimxrt1160_evk
mimxrt1170_evk
mimxrt1170_evkb

@carlocaione @kartben Rebased and HWMv2 support done. Ready to be checked. Thanks!

@kartben, @arnopo Rebased and HWMv2 support done. Ready to be checked. Thanks!


Can I create from a Bitmap an a specification ?

It's possible that I can create a speficification from a Bitmap binary or hex ?

Duplicate of https://github.com/moov-io/iso8583/discussions/232


Request for Review: DF Scene Enhancement

The QuickSceneView module is outdated and hasn't been updated for 0.7.x, I built a module that has that view feature but on clicking the card instead of in the menu, and a few more features that are very useful.

Navigate to scene instead of displaying config when clicking a scene on the Scenes Tab.
Display dialog with Config, Journal, and Navigate options when clicking a scene link in a Journal Entry.
Set custom Thumbnail for a scene.
Allow players to see the Scenes Tab with the scenes they have access to.

DF Scene Enhancement

Hi @flamewave000 thank you so much for jumping in to let me know about your module. Can't wait to try it out, sounds like some nice and intuitive usability improvements.

Hi @flamewave000 thank you so much for jumping in to let me know about your module. Can't wait to try it out, sounds like some nice and intuitive usability improvements.

This repo is no longer maintained, going to close this out.


bad input_ms.select_corr entries produce confusing errors

I had a 2-corr MS, and I set input_ms.select_corr = [0,3] by mistake. This resulted in a rather baffling stack trace, as per below.
It is entirely user error of course, but a friendlier message would be nice.
#   File "/home/oms/.venv/stimela/lib/python3.8/site-packages/xarray/core/variable.py", line 1186, in isel
#     return self[key]
#            │    └ (slice(None, None, None), slice(None, None, None), [0, 3])
#            └ <xarray.Variable (row: 211792, chan: 1024, corr: 2)>
#              dask.array<read~WEIGHT_SPECTRUM~[2,0,0]-1563189318_sdp_l0-A3528N_corr.ms...
#   File "/home/oms/.venv/stimela/lib/python3.8/site-packages/xarray/core/variable.py", line 779, in __getitem__
#     data = as_indexable(self._data)[indexer]
#            │            │    │      └ OuterIndexer((slice(None, None, None), slice(None, None, None), array([0, 3])))
#            │            │    └ <member '_data' of 'Variable' objects>
#            │            └ <xarray.Variable (row: 211792, chan: 1024, corr: 2)>
#            │              dask.array<read~WEIGHT_SPECTRUM~[2,0,0]-1563189318_sdp_l0-A3528N_corr.ms...
#            └ <function as_indexable at 0x7fe5db79c280>
#   File "/home/oms/.venv/stimela/lib/python3.8/site-packages/xarray/core/indexing.py", line 1228, in __getitem__
#     return self.array[key]
#            │    │     └ (slice(None, None, None), slice(None, None, None), array([0, 3]))
#            │    └ <member 'array' of 'DaskIndexingAdapter' objects>
#            └ DaskIndexingAdapter(array=dask.array<read~WEIGHT_SPECTRUM~[2,0,0]-1563189318_sdp_l0-A3528N_corr.ms, shape=(211792, 1024, 2), ...
#   File "/home/oms/.venv/stimela/lib/python3.8/site-packages/dask/array/core.py", line 1889, in __getitem__
#     index2 = normalize_index(index, self.shape)
#              │               │      │    └ <dask.utils.cached_property object at 0x7fe5e6968730>
#              │               │      └ dask.array<read~WEIGHT_SPECTRUM~[2,0,0]-1563189318_sdp_l0-A3528N_corr.ms, shape=(211792, 1024, 2),
dtype=float32, chunksize=(...
#              │               └ (slice(None, None, None), slice(None, None, None), array([0, 3]))
#              └ <function normalize_index at 0x7fe5e63b7820>
#   File "/home/oms/.venv/stimela/lib/python3.8/site-packages/dask/array/slicing.py", line 917, in normalize_index
#     check_index(axis, i, d)
#     │           │     │  └ 2
#     │           │     └ array([0, 3])
#     │           └ 2
#     └ <function check_index at 0x7fe5e63b78b0>
#   File "/home/oms/.venv/stimela/lib/python3.8/site-packages/dask/array/slicing.py", line 980, in check_index
#     raise IndexError(
#
# IndexError: Index is out of bounds for axis 2 with size 2

Ah, noted. Will sort out a fix.

Fixed by #164.


Several things that may be cool to implement.

First and foremost: Lovely mod, it has so much potential.

You should be able to see your purse when interacting with a villager or shop.

When exploring or just killing pillagers, you either find purses or silver and bronze coins seperately.
Two issues with that:
First, it is going to clog up your inventory. Three spaces - that temporarily (I give you that) - are used for money even though you have a purse and aren't really going to use it in an explorational context where sometimes even one space makes the difference.
Second, you have to right click them in your hotbar for them to get into your purse.
I really hope you see how annoying this can be throughout the whole game. I just found out you can stack the seperate coins into a moneybag and so you have one slot you take, but you still have to put it in a hotbar to right click.
My solution (feel free to ignore this): If you get money out of pillagers or maybe even just collect them from the ground, it gets into your purse directly. In no situation would this cause an inconvenience. (Though I don't know the coding on this one)

You can just put moneybags/coins into the purse icon and it gets added. Maybe so to say, a slot where only four items can be put into (Money bag, gold/silver/bronze coin).

I just tried to setup the infinity shop and I put some items innit, but I couldn't buy anything from it. I guessed that the person who sets up his own shop can't buy his items? But the infinity shop shouldn't be like this. I also don't know what the money counter under the sell trinket is (see in screenshot about point 7). The money you get from buying? What about infi shop "owner": Is he able to collect money from it?

I'm assuming for any shops (except infinity shop) to work, the items have to be in the inventory shop. Okay, yes. And it's cool that you can put items innit through hoppers, but what purpose does it serve for the infi shop? And does the infinity shop also need the items in it's inventory? If yes, I still couldn't buy anything from it. And also the one setting up the infi shop has access on the inventory even in survival. That's kinda meh and not bulletproof.

I figured this is a newly developed mod (which will be a musthave in the future). But I must say as someone who has read about the mod and decided to give it a try, I was sometimes confused on how it works. How to get coins etc. And that you can stack moneybags in your inventory and all those little tweaks that exists and will exist. Would you see a Patchouli book you can craft with a book and a bronze coin or shop as useful? For newer players who don't know how 7 total items from a mod can change the gameplay in a server so severely, I do see a use for that.

I tried /numismatic balance and it didn't work at all. Oh and what does the networth below actually mean? This value does say something about the value of a single piece of currency, but I haven't played that enough to know how I should setup the infi shop. Maybe also a little instruction on how to balance the infi shop and how to look out for inflation.

When setting up the shop and having Roughly Enough Items (and having cheats activated), you will delete your items when trying to put your item into the sell socket. Small inconvenience and somewhat situational (especially having cheats on) and it does have a fix (either disable cheats or Ctrl+o), but something I stumbled upon when trying to setup the infi shop.

That is everything for now, but again: I have a lot to look forward to in this mod
Sincerely
Ikibo

Hey, sorry for taking a while to respond. Been a busy few weeks.
Thank you for opening such a detailed issue. I do want to go over all the points you raised regarding Numismatic:
1: This is something we agree with. Adding the Purse Overlay to the Villager Trade Screen when in a Villager Trade screen should be easy enough to do.
4: I do agree that the Hopper toggle button inside an Inexhaustible Shop is redundant. We might remove that from its interface in the future.
6: The numismatic balance command has another subcommand, which lets you choose how to query the balance of the player/range. This value comes in raw coins (50 = 50 bronze coins, 164 = 1 silver, 64 bronze coins, etc.). This is not something we have documented on the wiki, so thank you for pointing that out!
7: Thanks for noticing, we will see to get that fixed in the next release.
2, 3, 5: All of these points are in regards to documentation. While Patchouli is a possible solution, we do not believe most players would actually spend their time reading it, and for this mod most of the mechanics should be straight-forward enough that you wouldn't need to.
We do recieve a lot of questions though, and we have made the effort of documenting most of the mod through our wiki (available over at https://docs.wispforest.io/numismatic-overhaul/home/), and we even have a video-guide should you wish to view that instead.
To quickly address your questions; When you have a ton of loose change in your inventory, simply shift clicking your purse icon will instantly deposit all coins from your inventory. It will ignore money bags, so that you can still hold money in your inventory without depositing it on accident.
If you are an owner of a shop block, if you sneak + use the shop, you will open the trade screen as if you were another player, and you are even able to buy from your own shop.
Hopefully I managed to answer everything, and thank you for using Numismatic Overhaul.


Improve advice in verifyPackageTree.js

Just a small update to the wording of one of the error messages.

@mrmckeb build timed out :/

Yes, it was unrelated to your work. Thanks again @sjalgeo.


Replace internal json serialization with SimpleJson

This looks good! Had a quick play with a very very simple app on the fork and all seemed good.
@NancyFx/most-valued-minions @thecodejunkie @grumpydev I'd like to get this in ASAP so we can rebase CoreCLR branch with it, can you review?

:shipit:

Unless @grumpydev or @thecodejunkie have any objections. I'll merge this tonight. (giving them time to see my message)

Yeah I do. I think we need to consider the fact that if we get Simple-Json in, then we need to make sure we also build in the following concepts https://github.com/NancyFx/Nancy/wiki/Extending-Serialization-with-Converters
I think these are used quite a bit and it also helps you customize your serialization process

From what I can see of the code it seems the concept of JavaScript converters still exist - https://github.com/jasonmead/Nancy/blob/SimpleJson/src/Nancy/Json/Simple/NancySerializationStrategy.cs#L23-L36

There is a lot of logic going on in NancySerializationStrategy all of these needs some sort of test coverage. There are date/time related code etc and nothing to make sure it works across time zones and so on

@jchannon @phillip-haydon you guys are going back to code-review school =)

There's also some reflection stuff going on.. we need to make sure that's compatible with the CoreCLR .. things like using GetTypeInfo()

Why do that when I can threaten to merge and get you to finally take a look ;)

@jasonmead Please don't take the review comments the wrong way. You have done some fantastic work in this pull-request, however since this is replacing something, that is very essential to Nancy, we have to set the bar high.

@phillip-haydon touché ;)

Left a PR for @jasonmead with the required syntax changes

Anything in this PR that accesses properties on Type need to be refactored to use Type.GetTypeInfo() or it won't be compatible with the CoreCLR. A quick glance shows that it's accessing things like IsEnum, FullName, IsGenericType and so on. Please limit the number of calls to GetTypeInfo to a minimum and instead reuse the instance (at least scope it to a method)

Latest should address most if not all issues presented here. I had to do a force push because I was following the contribution guidelines and rebased with upstream master. (I was hesitant about doing so but wasn't sure how to proceed).
@thecodejunkie, to address your concerns about passing JsonConfiguration into NancySerializationStrategy, I was able to refactor a bit and get the constructor parameters down to only needing the retainCasing boolean. I did this by removing support for recursion and max json length as discussed in the issue thread.
I added more tests for NancySerializationStrategy and everything has test coverage.
Let me know if anything else is needed.

@thecodejunkie No offense taken. You have your standards. I'm just happy to contribute. (Again) For future reference, are the code formatting standards documented anywhere?

@jasonmead It's somewhat documented under CONTRIBUTING.md. Otherwise you'd have to use existing code as an example, though we have some bit that are nicked from the Mono codebase etc. that have pretty horrible (non-existent) standards.

Sent a PR to @jasonmead about some of the comments left. Oddly some of those lines referenced are already fixed so not sure why Github thinks they are still there

@jchannon :+1:

Looks like the GetTypeInfo() has been added.
@thecodejunkie you want to re-review?

@jasonmead You're doing a fine bit of work here. Thanks for doing this :grin::+1:

Just want to check that the de/serialization will continue adjusting properties to lowerCase and vice-versa?

you mean camelCase?
yes this is covered
On 1 March 2016 at 21:40, Ovan Crone<EMAIL_ADDRESS>wrote:

Just want to check that the de/serialization will continue adjusting
properties to lowerCase and vice-versa?
—
Reply to this email directly or view it on GitHub
https://github.com/NancyFx/Nancy/pull/2313#issuecomment-190917578.

thanks @jchannon

Right, added what I think is the last round of review comments. This is very close on being pulled in now! :heart:

@jasonmead :heart: :heart: :heart: Will take a closer look tomorrow morning, with a fresh pair of eyes, but I think this is ready to be pulled in!

What are your plans on merging upstream with official SimpleJson repo?
These days I don't work on .net so I don't have time to look at CRs. But if anyone is interested I could start merging CRs if you guys approve it and in the long term actually give push permission.

:heart: :heart: :heart: :+1: :+1: :+1: Huge thanks @jasonmead . Nice work!

@prabirshrestha Not sure we've made any changes to Simple-Json? I think @jchannon and @jasonmead can bring us up to speed
We've sent on PR to make it compatible with the CoreCLR https://github.com/facebook-csharp-sdk/simple-json/pull/70 by @yantrio
I think we'll just have to wait and see if, and if so how many, changes that will happen in Simple-Json inside of Nancy.. too early to say, we need to get 2.0 out so we shake the tree a bit

The issue with that PR is what @khellang said, it's hard to target all dotnet5x monikers and we can't see a nice solution going upstream. I'm open to suggestions @prabirshrestha :)

@prabirshrestha The only change that was made to SimpleJson was to make the reflection caches in PocoSerializationStrategy static so that we don't have to repopulate them every time we new up a NancySerializationStrategy. I can open a PR is you think people would find that useful.


Add fog ability for Scene

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Codecov Report
Base: 43.41% // Head: 44.53% // Increases project coverage by +1.12% :tada:

Coverage data is based on head (dac961b) compared to base (8cb3f9f).
Patch coverage: 32.43% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.0    #1238      +/-   ##
===========================================
+ Coverage    43.41%   44.53%   +1.12%
===========================================
  Files          347      346       -1
  Lines        18315    18322       +7
  Branches      2543     2546       +3
===========================================
+ Hits          7951     8160     +209
+ Misses        9756     9512     -244
- Partials       608      650      +42

Impacted Files
Coverage Δ

packages/loader/src/MaterialLoader.ts
4.44% <0.00%> (-0.21%)
:arrow_down:

packages/core/src/Scene.ts
67.95% <30.30%> (-7.05%)
:arrow_down:

packages/core/src/enums/FogMode.ts
100.00% <100.00%> (ø)

packages/loader/src/AnimationClipLoader.ts
28.57% <0.00%> (ø)

packages/core/src/shadow/ShadowUtils.ts
9.63% <0.00%> (+1.20%)
:arrow_up:

packages/math/src/Vector2.ts
81.81% <0.00%> (+1.51%)
:arrow_up:

packages/core/src/Transform.ts
55.15% <0.00%> (+1.51%)
:arrow_up:

packages/core/src/Component.ts
82.22% <0.00%> (+2.22%)
:arrow_up:

packages/core/src/Engine.ts
84.37% <0.00%> (+2.67%)
:arrow_up:

... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


GH-34535: [C++] Move ChunkResolver to the public API

Rationale for this change
See https://github.com/apache/arrow/issues/34535.
What changes are included in this PR?

[ ] Check unit test coverage and expand as necessary to handle edge cases
[x] Move ChunkResolver out of the internal namespace

[x] Refactor current usages of the class in Arrow C++ as necessary

[ ] Update the documentation

[x] Update the API/reference docs as necessary
[ ] Add a section, perhaps in the User Guide or Examples, on how to use this class

As requested by @felipecrv, this PR also contains a minor simplification to ChunkResolver's existing interface.

Are these changes tested?
Opening PR in draft state, unit tests still need to be implemented.

Are there any user-facing changes?
Yes, users will now be able to use the ChunkResolver from the public ::arrow namespace. There are no breaking changes.
Opening PR in draft state, some documentation may still need to be added.

GitHub Issue: #34535

I implemented Valid and Next in #40368. Feel free to copy and paste here.

Hey @SChakravorti21!
I was thinking about adopting this PR. Would you be okay with that?

Hey @SChakravorti21!
I was thinking about adopting this PR. Would you be okay with that?

Hey @anjakefala! I'm so sorry for dropping the ball on this. Yes, please free to take it over if you'd like :)

Superseded by #44357


Cards are not showing in Web Demo

Regular text shows as expected. Cards do not.
Cards show up only in console.dialogflow.com "test" runs.
    agent.add(new Card({
        title: 'Vibrating molecules',
        imageUrl: wikipediaTemperatureImageUrl,
        text: 'Did you know that temperature is really just a measure of how fast molecules are vibrating around?! 😱',
        buttonText: 'Temperature Wikipedia Page',
        buttonUrl: wikipediaTemperatureUrl
      })
    );

I have some problem also, how to resolve this ??  did u fix it @karliszarins ?


Add syntax highlighting to code blocks at README

:smile:

Good fix :)
Sphinx already highlights it but apparently the Github RST parser is even more limited than I had hoped (for reference: http://progressbar-2.readthedocs.io/en/latest/usage.html)


flatpak-builder: add support for D-Bus tests

If the run-test input is true, automatically start a session bus and add
DBUS_SESSION_BUS_ADDRESS environment variable when modifying the manifest.
fixes #25

This is not terribly elegant, but I didn't want to refactor a bunch of the code flow and make it too difficult to review. I believe all the potential exceptions are caught, though.

it looks pretty good to me! before getting this one merged, I would like to tackle #60 as the repo was moved to the Flatpak repo and we would like to keep only the base image here and have the runtime ones produced by Flathub itself along with something like flathub-publish

The codespell check seems not to be correct nor related to this PR, so we can merge it and figure out what to do with Codespell after.


Feature request: svg support with mjml-image

Hi all, i found that SVG images does not appear in some programs.
Then i found this article on css-tricks:
https://css-tricks.com/a-guide-on-svg-support-in-email/
This approach works and may be we can add support of "svg + jpg fallback" in mjml-image?

Hi @Bogdaan ,
Coming back to this issue, I think this can be achieved by a custom component, but the use-case seems really limited to me. What do you think ?

Yeah SVG support cross browser is hideous. If anybody has figured out a viable workaround, please share, but it looks like converting SVGs to image format is the move for the time being

Hi, some updates about that?
Maybe theres a n ew version that support SVG?
thanks!

Support of svg haven’t got any better as far as I know stick with regular img insteadOn 16 Aug 2024, at 14:58, evaicash @.***> wrote:
Hi, some updates about that?
Maybe theres a n ew version that support SVG?
thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>


0/0 mods loaded in 1.1.0k

Initialize engine version: 2019.4.26f1 (e0392c6b2363)
[Subsystems] Discovering subsystems at path J:/SteamLibrary/steamapps/common/Pathfinder Second Adventure/Wrath_Data/UnitySubsystems
GfxDevice: creating device client; threaded=1
Direct3D:
Version:  Direct3D 11.0 [level 11.1]
Renderer: NVIDIA GeForce RTX 3060 (ID=0x2504)
Vendor:
VRAM:     12143 MB
Driver:   <IP_ADDRESS>41
Begin MonoManager ReloadAssembly
[Manager] Injection...
[Manager] Initialize.
[Manager] Version: <IP_ADDRESS>.
[Manager] OS: Microsoft Windows NT 10.0.19042.0 AMD64.
[Manager] Net Framework: 4.0.30319.42000.
[Manager] Unity Engine: 2019.4.261.
[Manager] Game: Pathfinder: Wrath of the Righteous.
[Manager] Mods path: J:\SteamLibrary\steamapps\common\Pathfinder Second Adventure\Mods.
Fallback handler could not load library J:/SteamLibrary/steamapps/common/Pathfinder Second Adventure/Wrath_Data/Mono/data-0000021B5B203020.dll
Fallback handler could not load library J:/SteamLibrary/steamapps/common/Pathfinder Second Adventure/Wrath_Data/Mono/data-0000021B5B5E2AC0.dll
[Manager] Injection successful.

Completed reload, in  0.542 seconds
D3D11 device created for Microsoft Media Foundation video decoding.
 Initializing input.

 Input initialized.
 Initialized touch support.
UnloadTime: 0.586500 ms
[Manager] Start parsing game version.
[Manager] Found game version string: '1.1.0k'.
[Manager] Game version detected as '1.1.0'.
[Manager] Parsing mods.
[Manager] FINISH. SUCCESSFUL LOADED 0/0 MODS.
[Manager] Spawning.
[MonoSingleton] There is no object of type Kingmaker.Utility.CoroutineRunner. Creating new.
[MonoSingleton] There is no object of type Kingmaker.Settings.Graphics.ApplicationFocusObserver. Creating new.
Cannot Prepare a disabled VideoPlayer
(Filename:  Line: 315)
[Manager] Checking updates.
The referenced script on this Behaviour (Game Object 'Male_BaseSkeletonGeneric_HalfOrc') is missing!
(Filename:  Line: 334)
Kingmaker.Localization.SharedStringAsset must be instantiated using the ScriptableObject.CreateInstance method instead of new SharedStringAsset.
(Filename:  Line: 683)
Kingmaker.Localization.SharedStringAsset must be instantiated using the ScriptableObject.CreateInstance method instead of new SharedStringAsset.
(Filename:  Line: 683)
Kingmaker.Localization.SharedStringAsset must be instantiated using the ScriptableObject.CreateInstance method instead of new SharedStringAsset.
(Filename:  Line: 683)
Kingmaker.Localization.SharedStringAsset must be instantiated using the ScriptableObject.CreateInstance method instead of new SharedStringAsset.
(Filename:  Line: 683)
The referenced script on this Behaviour (Game Object '') is missing!
(Filename:  Line: 334)
The referenced script on this Behaviour (Game Object '') is missing!
(Filename:  Line: 334)
The referenced script on this Behaviour (Game Object '') is missing!
(Filename:  Line: 334)
The referenced script on this Behaviour (Game Object 'UnityThreadHolder') is missing!
(Filename:  Line: 334)
Received stats and achievements from Steam
Unloading 6 Unused Serialized files (Serialized files now loaded: 226)
Unloading 14750 unused Assets to reduce memory usage. Loaded Objects now: 174904.
Total: 284.912500 ms (FindLiveObjects: 7.877900 ms CreateObjectMapping: 11.637500 ms MarkObjects: 259.142500 ms  DeleteObjects: 6.254200 ms)
The referenced script on this Behaviour (Game Object '') is missing!
(Filename:  Line: 334)
The referenced script on this Behaviour (Game Object '') is missing!
(Filename:  Line: 334)
WARNING: Shader Unsupported: 'Hidden/Nature/Terrain/Utilities' - All passes removed
WARNING: Shader Did you use #pragma only_renderers and omit this platform?
The loaded level has a different lightmaps mode than the current one. Current: Non-Directional. Loaded: Directional. Will use: Non-Directional.
(Filename:  Line: 276)
Uploading Crash Report
NullReferenceException: Object reference not set to an instance of an object
at Kingmaker.Visual.Particles.FxAoeSpawner.SpawnFxOnEntry (Kingmaker.Visual.Particles.FxAoeSpawner+Entry entry) [0x00017] in :0
at Kingmaker.Visual.Particles.FxAoeSpawner.OnEnable () [0x000d3] in :0
(Filename:  Line: 0)
NullReferenceException: Object reference not set to an instance of an object
at Kingmaker.Visual.Particles.FxAoeSpawner.SpawnFxOnEntry (Kingmaker.Visual.Particles.FxAoeSpawner+Entry entry) [0x00017] in :0
at Kingmaker.Visual.Particles.FxAoeSpawner.OnEnable () [0x000d3] in :0
(Filename:  Line: 0)
NullReferenceException: Object reference not set to an instance of an object
at Kingmaker.Visual.Particles.FxAoeSpawner.SpawnFxOnEntry (Kingmaker.Visual.Particles.FxAoeSpawner+Entry entry) [0x00017] in :0
at Kingmaker.Visual.Particles.FxAoeSpawner.OnEnable () [0x000d3] in :0
(Filename:  Line: 0)
NullReferenceException: Object reference not set to an instance of an object
at Kingmaker.Visual.Particles.FxAoeSpawner.SpawnFxOnEntry (Kingmaker.Visual.Particles.FxAoeSpawner+Entry entry) [0x00017] in :0
at Kingmaker.Visual.Particles.FxAoeSpawner.OnEnable () [0x000d3] in :0
(Filename:  Line: 0)

This looks like nothing to do with ToyBox and everything to do with some config issue.  Please come find us on the WoTr discord https://discord.gg/F9Tjzg99 and ask for help on #mod-user-general


Expiration date of incoming token is not validated if token_ttl is set to null

I understand that token_ttl should not be set to null, but it is possible and a non-expiring token is still a valid token.
Currently, the token_ttl setting is serving two purposes:

it sets the expiry of newly created tokens
it switches expiry validation on or off for all incoming tokens

I propose the token_ttl setting should be purely used to set the expiry of newly created tokens, and all incoming tokens should be validated according to the data in the token, regardless of the token_ttl setting.
Setting the ttl to null and validating a token with expiry date is not is not covered in the current tests as the tests do not use the 3rd parameter of the LoadedJWT. You will see that the test fails to reflect the token is expired if the 3rd parameter is set to false, which I think is incorrect. A token is expired based on the content of the token, not the system settings.
public function testVerifiedWithExpiredPayload()
{
    $payload = $this->goodPayload;
    $payload['exp'] -= 3600;

    $jws = new LoadedJWS($payload, true);

    $this->assertFalse($jws->isVerified());
    $this->assertTrue($jws->isExpired());
}

To resolve this, a simple change is required to LoadedJWS, which ensures correct validation of all tokens
Current:
public function __construct(array $payload, $isVerified, $hasLifetime = true, array $header = [], $clockSkew = 0)
    {
        $this->payload     = $payload;
        $this->header      = $header;
        $this->hasLifetime = $hasLifetime;

Proposed:
public function __construct(array $payload, $isVerified, array $header = [], $clockSkew = 0)
    {
        $this->payload     = $payload;
        $this->header      = $header;
        $this->hasLifetime = isset($payload['exp']) ? true : false;

Would you like me to create a pull request for this?

Is there any appetite to change this? Would a PR be considered?

If you have some time, please review the PR. We are about to go into production and I would like to continue using your bundle and not my own forked one.


Can't generate epub: undefined method `to_ios'

I have a pretty simple adoc file and asciidoctor 1.5.2. Tried to generate epub and got this:
$ asciidoctor-epub3 joiningCTOschool.adoc
undefined method `to_ios' for #Asciidoctor::Epub3::Packager:0x007faf990a79e0
Use --trace for backtrace
Running with --trace produced this:
Yakov:ctoschool yfain11$ asciidoctor-epub3 --trace joiningCTOschool.adoc
/Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:303:in postprocess_xhtml': undefined methodto_ios' for #Asciidoctor::Epub3::Packager:0x007f99db82d288 (NoMethodError)
from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:250:in block (3 levels) in add_content'     from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:248:ineach'
from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:248:in each_with_index'     from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:248:inblock (2 levels) in add_content'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/resource_builder.rb:40:in instance_eval'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/resource_builder.rb:40:inblock in ordered'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/package.rb:166:in ordered'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/book.rb:205:inordered'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/resource_builder.rb:39:in ordered'     from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:245:inblock in add_content'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/resource_builder.rb:33:in instance_eval'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/resource_builder.rb:33:ininitialize'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/builder.rb:292:in new'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/builder.rb:292:inresources'
from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:240:in add_content'     from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:422:inblock in package'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/builder.rb:185:in instance_eval'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/gepub-<IP_ADDRESS>/lib/gepub/builder.rb:185:ininitialize'
from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:340:in new'     from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/packager.rb:340:inpackage'
from /Users/yfain11/asciidoctor-epub3/lib/asciidoctor-epub3/converter.rb:37:in write'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/asciidoctor-1.5.2/lib/asciidoctor/document.rb:1051:inwrite'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/asciidoctor-1.5.2/lib/asciidoctor.rb:1504:in convert'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/asciidoctor-1.5.2/lib/asciidoctor/cli/invoker.rb:94:inblock in invoke!'
from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/asciidoctor-1.5.2/lib/asciidoctor/cli/invoker.rb:86:in each'     from /Users/yfain11/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/asciidoctor-1.5.2/lib/asciidoctor/cli/invoker.rb:86:ininvoke!'
from /Users/yfain11/asciidoctor-epub3/bin/asciidoctor-epub3:13:in `'

If I remember correctly, Asciidoctor EPUB3 is fussy about having just the right structure for the document. We obviously want to fix this. Until then, refer to the following example and be sure to follow the same structure, working backwards from the example to your doc.
https://github.com/asciidoctor/asciidoctor-epub3/blob/master/data/samples/sample-book.adoc

To provide some context...Asciidoctor EPUB3 was flexible to handle any AsciiDoc document at one point, but somewhere along the line I broke it. Tests would obviously be a huge benefit here :)

I have detailed the required structure in the README. See https://github.com/asciidoctor/asciidoctor-epub3#structuring-your-manuscript

I'm going to close this as a duplicate of #47. It's the same issue.


Update Chromium Embedded Framework to new repository

New repository. They moved: https://bitbucket.org/chromiumembedded/cef

Done.


Regarding 1.7 release authorization procedure

Hi AVS Team,
There is one query regarding avs-device-sdk 1.7 release.
As there is a new mechanism of Authorization in 1.7 release, it provides link and code in the console logs.
Is it possible that Alexa client can authorize itself from the application?? i,e there is no need for the user to manually open the link and enter the code to complete the authorization.
I want no changes in the running application. So it would be better if I run my Sample App, it comes up and authorize itself. The login credentials can be given in the AlexaClientSDKConfig.json file.
Thanks,
Sumit

Hi @sumit3817,
We don't currently provide a means for the client to authorize itself. Feel free to implement your own self-authorization solution on top of the SDK -- maybe an additional piece of code that can take the credentials and the CBL code and authorize?
Fede


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

Codecov Report

Merging #311 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   64.21%   64.19%   -0.03%
==========================================
  Files          63       63
  Lines        3532     3516      -16
==========================================
- Hits         2268     2257      -11
+ Misses       1264     1259       -5

Impacted Files
Coverage Δ

...rogressIndicatorView/CircleProgressIndicatorView.m
47.24% <0%> (-2.01%)
:arrow_down:

...nents/CircleProgressIndicatorView/CircleIconView.m
45.19% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46361a9...00ab5e7. Read the comment docs.

@bryant1410 Thank you!


Prepare Identity for Jul release

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


feat: use new tool name Chromoscope and domain (chromoscope.bio)

This PR updates the names and URLs of our tool throughout the code (SVELT & GosCan → Chromoscope).
@dmaziec1 Can you check whether the updates look good to you? Especially, I updated the code under clustering folder, which would be great if you can confirm the changes.

I will try to make the demo work first with the chromoscope.bio


Clock icon won't disappear when sending a DM

Checking logs I noticed that the issue is related to slow responses from Relays, even though the relay confirms the reception, Nostros won't remove the clock icon until the message is received again from al least one relay.
I'll leave this bug open in case there are more issues and another reason is discovered.


Quickstarts - Add default configs for google auth

A non-empty value is required to run "out of the box", otherwise
the google handler will throw when it is added.

re #51


fix: don't use relative imports in makecode-node

completely untested!

And should fix https://github.com/microsoft/pxt-mkc/issues/105 / https://github.com/microsoft/pxt-mkc/issues/97, will go ahead and merge to get it testable


Consolidate login flow to always call Login

@keybase/react-hackers, @patrickxb Wanted this since it can help reset users.

Let me try this out with my branch before merging...thanks!

This works great...
I pushed my rebase by accident, but presumably that won't matter.
Please merge!  Thanks!


Nested Query Doesn't Work

as you can see on code below :
public class ReceiveMoneyVoucher
{
public Guid Id { get; set; }
[Nested]
public List VoucherItems { get; set; } = new List();
}
I've defined nested mapping which can see the result below:
"voucherItems": {
"type": "nested",
"properties": {
But nested query Doesn't return the expected result as can see below :
var res = await ElasticClient.SearchAsync(s => s
.Index(IndexName)
//.From(searchParam.PageNumber - 1)
//.Size(searchParam.PageSize)
//.Query(searchQuery));
.Query(q => q.Nested(n => n.Path("voucherItems").Query(nq => nq.Match(t => t.Field("voucherItems.description").Query("hesam hesam"))))));

@hesamdarbandi I need a more complete issue in order to investigate this, please. What version of Elasticsearch and the client are you using? The code above looks incomplete (missing generics on lists for example) but in principle that query looks like it should work. You state it doesn't return the expected response. What response are you receiving and what are you expecting?
Assuming the following mapping and initial data:
PUT repro-6141
{
  "mappings": {
    "properties": {
      "voucherItems": {
        "type": "nested"
      }
    }
  }
}

PUT repro-6141/_doc/1
{
  "id" : "73f9e18d-0487-40a4-bf5b-0e380e152d79",
  "voucherItems" : [
    {
      "description" : "hesam hesam"
    }
  ]
}

GET repro-6141/_search
{
  "query": {
    "nested": {
      "path": "voucherItems",
      "query": {
        "bool": {
          "must": [
            { "match": { "voucherItems.description": "hesam hesam" }}
          ]
        }
      }
    }
  }
}

And the following C# code (.NET 6):
using Nest;

var client = new ElasticClient("CLOUDID",
    new Elasticsearch.Net.BasicAuthenticationCredentials("elastic", "PASSWORD"));

var res = await client.SearchAsync<ReceiveMoneyVoucher>(s => s
    .Index("repro-6141")
    .Query(q => q.Nested(n => n.Path("voucherItems").Query(nq => nq.Match(t => t.Field("voucherItems.description").Query("hesam hesam"))))));

Console.ReadKey();

public class ReceiveMoneyVoucher
{
    public Guid Id { get; set; }

    [Nested]
    public List<VoucherItem> VoucherItems { get; set; } = new List<VoucherItem>();
}

public class VoucherItem
{
    public string Description { get; set; }
}

When I execute the query I receive a single hit as I'd expect.
I'll need complete reproduction steps (and possibly more details about your mapping and data) for your scenario in order to assist further. Thanks!

I Appreciate For Your Consideration And Response, I've used nest client version 7.16.0 and dotnet 5.0
I have Parent Object That Called ReceiveMoneyVoucher that have nested List in it that called VoucherItems,So
I create mapping for parent and specify nested for  VoucherItems in it.
My nested array data looks like below
new List VoucherItems = new List
{
new VoucherItem { Description = 'apple' },
new VoucherItem { Description = 'orange' }
}
query is
var res = await client.SearchAsync(s => s
.Index("receivemoneyvouchers")
.Query(q => q.Nested(n => n.Path("voucherItems").Query(nq => nq.Match(t =>   t.Field("voucherItems.description").Query("apple"))))));
so I expect The Response as below
List of ReceiveMoneyVoucher
[
Id = "73f9e18d-0487-40a4-bf5b-0e380e152d79"
VoucherItems = [
{
Description = 'apple'
}
]
]
but It has return null

I've created an index for the parent

ElasticClient.Indices.Create("receivemoneyvouchers", m => m.Map<T>(x => x.AutoMap()));

ElasticClient.IndexAsync(receiveMoneyVoucher, m => m.Index("receivemoneyvouchers"));

@hesamdarbandi What property is null in your case? If you index the document in code (as above), then you may need to wait for up to 1 second for it to appear in subsequent search results. I've attempted to reproduce based on your information above and cannot. Here is the code I'm using:
using Elasticsearch.Net;
using Nest;

var cloudPool = new CloudConnectionPool("CLOUDID", new BasicAuthenticationCredentials("elastic", "PASSWORD"));
var client = new ElasticClient(new ConnectionSettings(cloudPool).EnableDebugMode());

var cleanup = await client.Indices.DeleteAsync("receivemoneyvouchers");

var createResponse = await client.Indices.CreateAsync("receivemoneyvouchers", m => m.Map<ReceiveMoneyVoucher>(x => x.AutoMap()));

var receiveMoneyVoucher = new ReceiveMoneyVoucher();
var indexResponse = await client.IndexAsync(receiveMoneyVoucher, m => m.Index("receivemoneyvouchers"));

await Task.Delay(1000); // need to wait for the new document to be available for searching - could force a refresh here too

var searchResponse = await client.SearchAsync<ReceiveMoneyVoucher>(s => s
    .Index("receivemoneyvouchers")
    .Query(q => q.Nested(n => n.Path("voucherItems").Query(nq => nq.Match(t => t.Field("voucherItems.description").Query("apple"))))));

Console.WriteLine(searchResponse.DebugInformation);

Console.ReadKey();

public class ReceiveMoneyVoucher
{
    public Guid Id { get; set; } = Guid.NewGuid();

    [Nested]
    public List<VoucherItem> VoucherItems { get; set; } =
        new List<VoucherItem>
        {
           new VoucherItem { Description = "apple" },
           new VoucherItem { Description = "orange" }
        };
}

public class VoucherItem
{
    public string Description { get; set; }
}

Response (as expected)
{
  "took" : 1,
  "timed_out" : false,
  "_shards" : {
    "total" : 1,
    "successful" : 1,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : {
      "value" : 1,
      "relation" : "eq"
    },
    "max_score" : 0.6931471,
    "hits" : [
      {
        "_index" : "receivemoneyvouchers",
        "_type" : "_doc",
        "_id" : "78550039-2151-487e-87cd-3083ac1f5436",
        "_score" : 0.6931471,
        "_source" : {
          "id" : "78550039-2151-487e-87cd-3083ac1f5436",
          "voucherItems" : [
            {
              "description" : "apple"
            },
            {
              "description" : "orange"
            }
          ]
        }
      }
    ]
  }
}

If you still experience issues, could you identify anything different you're doing in your code? Also, please enable  DebugMode as shown in the same above and collect the DebugInformation on your responses which may provide further clues.

Thanks a lot @stevejgordon
Could you Checkout this Please
here is expecting a respond  Based on your query

{
  "took" : 1,
  "timed_out" : false,
  "_shards" : {
    "total" : 1,
    "successful" : 1,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : {
      "value" : 1,
      "relation" : "eq"
    },
    "max_score" : 0.6931471,
    "hits" : [
      {
        "_index" : "receivemoneyvouchers",
        "_type" : "_doc",
        "_id" : "78550039-2151-487e-87cd-3083ac1f5436",
        "_score" : 0.6931471,
        "_source" : {
          "id" : "78550039-2151-487e-87cd-3083ac1f5436",
          "voucherItems" : [
            {
              "description" : "apple"
            }
          ]
        }
      }
    ]
  }
}

@hesamdarbandi I'm not sure what you're asking exactly but will make an assumption is about the inclusion of "orange" in the array of voucherItems in the _source object? If so, the _source field will include any and all voucher items from the original document. No filtering is applied and it's purely the original JSON document that was indexed. In this case, the document had two voucher items, so both are part of the source document. A nested query allows you to query inside a nested object, but the result is the original root document(s) that match the query clauses.


setup script does not fail if unzip-operations fail

For example if unzip is not installed, the script does not warn the user that some operations were not done correctly

There is no longer any usage of unzip in the setup script, so this can be closed.


Adding LTM Auth endpoint

Problem:
LTM auth endpoints were missing from the SDK, despite that some of the LTM auth features were discontinued(due to move to APM), this is still used and is a valid rest point.
Analysis:
Added LTM auth endpoint to SDK, some of the features require a retured client auth module addon (still available on some older platforms, i.e 1600, 3600, 3900 etc.) i have tested those against hardware unit, however they are skipped by default, and were added for completeness.
Tests:
Flake8
Functional Tests
Unit Tests
Files Added/Changed:
f5-common-python/f5/bigip/tm/ltm/init.py
f5-common-python/f5/bigip/tm/ltm/auth.py
f5-common-python/f5/bigip/tm/ltm/test/test_auth.py
f5-common-python/test/functional/tm/ltm/test_auth.py

@caphrim007 @zancas are we going to push this anytime :) its ready to go :)

@wojtek0806 can you rebase on top of the latest devel and squash those commits?