Blank map on Android, only on some screens, after upgrading to 1.0.0

Summary
11/7/22 EDIT:
After updating my Kotlin version to 1.6.0 in my build.gradle file (needed to do it to solve an error coming from another dependency), we are now back to where we were on an emulator, with 1/3 screens working on Android. On a physical device, all screens work but are zoomed out to Africa. I have some luck setting initialRegion on 2/3 of those screens but I didn't need to set that before in order for the maps to work(I'm calling fitToCoordinates) and I can't get it to work on the one that matters the most, where real-time tracking is happening.
11/3/22 EDIT:
I have upgraded to 1.3.2 and updated Google Play Services (I didn't understand what that was before and thought because I had the Google Play app I was fine). Results were the same. Then I tried enabling the new Google Maps renderer and progress! All maps are showing up now in Android but they are way zoomed out on Africa. Everything works awesome on a physical ios device. An ios simulator takes a really long time to display the map, like 15-20 seconds, and sometimes crashes.
8/23/22 EDIT:
Without changing anything, I tried again today with 1.0.0 and the map showed up on 2/3 of the screens, up from 1/3. So, progress. I then upgraded to 1.3.0 with the same results. However, the third screen is still blank.
Hello!
I don't know that this is a bug report, it was the only option though. No one else seems to be having this issue so I bet it's something small I've overlooked. I'm upgrading an app from 0.28.0 to 1.0.0. It worked fine before but now on Android the map is blank (with a google logo) on 2/3 of the screens I use it on. On the screen it is rendering on, it isn't showing the correct region. I read through the changelogs and the installation process and I did see that some things have changed for 0.31.0 and above. I tried the suggestions and also the troubleshooting, but nothing has helped. It's working on iOS okay, though it does take like 10-15 seconds to load, which is atypical. Here is the result when I adb logcat "Google Maps Android API":

I am importing like this:
import MapView, { Marker, PROVIDER_GOOGLE } from 'react-native-maps';
8/23/22 EDIT: This screen is now rendering. The view is a little far away but at least I can see it.
Here are the MapView props and a screenshot for one of the screens not rendering:
<MapView
  ref={(ref) => { this.mapRef = ref; }}
  moveOnMarkerPress={false}
  onMapReady={() => this.onMapLayout()}
  style={{ ...Layouts.container, width: StyleConfig.width, height: StyleConfig.height }}
  customMapStyle={MAP_STYLES}
  provider={PROVIDER_GOOGLE}
  showsIndoors={false}
  >
  {markers}
</MapView>

Here is what it should look like:

8/23/22 EDIT: This screen is now rendering better, at least in the right geographical region, the points are still somewhat offscreen, but it's better.
Here is the code and screenshot for the screen that is rendering, with wrong view (the user location and drop point is working, it's just offscreen):
<MapView
  ref={(ref) => { this.mapRef = ref; }}
  onLayout={() => {
    this.mapRef.fitToCoordinates(
      [userCoordinates,
        dropPointLocation],
      {
        edgePadding: this.generateEdgePadding(styles.edgePadding),
        animated: false,
      },
    );
  }}
  style={[styles.map, { ...Layouts.container }]}
  customMapStyle={MAP_STYLES}
  provider={PROVIDER_GOOGLE}
  showsIndoors={false}
  mapPadding={{ bottom: 50, left: 15 }}
>

Here is what it should look like:

I tried using onLayout instead of onMapReady in the first instance, but that just led to a never-ending loading screen.
Reproducible sample code
Other than the above, I can't provide a reproducible example in this case, I'm sorry, the codebase is just so large, not even sure where to start.

Steps to reproduce
Same as above, I know this is not helpful. It is working 1/3 times so not sure what needs to be tweaked in order for it to work/not work.
Expected result
The map should be rendered with user location and drop points on the first screen.
Actual result
The map is blank, except for the google logo.
React Native Maps Version
1.0.0
What platforms are you seeing the problem on?
Android
React Native Version
0.67.4
What version of Expo are you using?
Not using Expo
Device(s)
Galaxy S9 physical device, Android 12, and Galaxy S21 emulator, Android 12
Additional information
Just that I'm grateful for anyone's time and help with this. It's not my best GitHub issue, not sure what else would be helpful to include.

That's kind of weird. I'm having the same problem.
My problem is that onMapReady is not being called on iOS. Not even once.
I'm having this problem after upgrading from Expo SDK 44 to SDK 46 (I made 2 jumps in 1 day).

@BrodaNoel I was having that issue with react-native-maps 0.31.0 (not sure if that correlates to one of the SDKs you mentioned) and saw there was a fix in one of the 1.0.0 betas, so that's why I upgraded to 1.0.0.

I'm using 0.31.1, because I'm using Expo, and that's the compatible version :(

Related: https://github.com/react-native-maps/react-native-maps/issues/4066

That's kind of weird. I'm having the same problem.
My problem is that onMapReady is not being called on iOS. Not even once.
I'm having this problem after upgrading from Expo SDK 44 to SDK 46 (I made 2 jumps in 1 day).
Related: https://github.com/react-native-maps/react-native-maps/issues/4066

@BrodaNoel onMapReady not being called is unrelated to this issue and was caused by the js prop being bridged too late :)
@gabriellend we use the Github Discussions section for anything not related to bugs, but until we determine whether this is a bug or not, I'm fine keeping this as an issue.
First of all, I appreciate you taking the time to fill out the issue template thoroughly.
Other than the above, I can't provide a reproducible example in this case, I'm sorry, the codebase is just so large, not even sure where to start. describes how I'm left after going through this issue 😄 Joking aside, would you be able to share the project code privately with me? (Since you painted over parts of the app, I assume that it isn't suitable for public sharing).

@Simon-TechForm Thank you so much for your response! Ok, noted about the GitHub Discussions, thank you, I'm still somewhat new at this stuff and haven't used that yet. Yes, this is for my job so I didn't think it prudent to share any identifying information publicly. I have asked my boss if it would be ok to share. I doubt he will be ok with sharing the whole project, as it's the intellectual property of the company (maybe I will be surprised), but maybe pertinent parts are okay. Will get back to you!

@Simon-TechForm I was given permission to share the parts of the code related to react-native-maps. I created a private repo with just those parts and shared it with you. A new development has happened. On iOS, if I make a small change in my editor, revert it back, and save, everything works fine. I have to do that each time I build it though so that's not feasible. This doesn't happen on Android though. Appreciate your time.

Summary
Hello!
I don't know that this is a bug report, it was the only option though. No one else seems to be having this issue so I bet it's something small I've overlooked. I'm upgrading an app from 0.28.0 to 1.0.0. It worked fine before but now on Android the map is blank (with a google logo) on 2/3 of the screens I use it on. On the screen it is rendering on, it isn't showing the correct region. I read through the changelogs and the installation process and I did see that some things have changed for 0.31.0 and above. I tried the suggestions and also the troubleshooting, but nothing has helped. It's working on iOS okay, though it does take like 10-15 seconds to load, which is atypical. Here is the result when I adb logcat "Google Maps Android API":

I am importing like this: import MapView, { Marker, PROVIDER_GOOGLE } from 'react-native-maps';
Here are the MapView props and a screenshot for one of the screens not rendering:
<MapView
  ref={(ref) => { this.mapRef = ref; }}
  moveOnMarkerPress={false}
  onMapReady={() => this.onMapLayout()}
  style={{ ...Layouts.container, width: StyleConfig.width, height: StyleConfig.height }}
  customMapStyle={MAP_STYLES}
  provider={PROVIDER_GOOGLE}
  showsIndoors={false}
  >
  {markers}
</MapView>

Here is what it should look like:
Here is the code and screenshot for the screen that is rendering, with wrong view (the user location and drop point is working, it's just offscreen):
<MapView
  ref={(ref) => { this.mapRef = ref; }}
  onLayout={() => {
    this.mapRef.fitToCoordinates(
      [userCoordinates,
        dropPointLocation],
      {
        edgePadding: this.generateEdgePadding(styles.edgePadding),
        animated: false,
      },
    );
  }}
  style={[styles.map, { ...Layouts.container }]}
  customMapStyle={MAP_STYLES}
  provider={PROVIDER_GOOGLE}
  showsIndoors={false}
  mapPadding={{ bottom: 50, left: 15 }}
>

Here is what it should look like:
I tried using onLayout instead of onMapReady in the first instance, but that just led to a never-ending loading screen.
Reproducible sample code
Other than the above, I can't provide a reproducible example in this case, I'm sorry, the codebase is just so large, not even sure where to start.

Steps to reproduce
Same as above, I know this is not helpful. It is working 1/3 times so not sure what needs to be tweaked in order for it to work/not work.
Expected result
The map should be rendered with user location and drop points on the first screen.
Actual result
The map is blank, except for the google logo.
React Native Maps Version
1.0.0
What platforms are you seeing the problem on?
Android
React Native Version
0.67.4
What version of Expo are you using?
Not using Expo
Device(s)
Galaxy S9 physical device, Android 12, and Galaxy S21 emulator, Android 12
Additional information
Just that I'm grateful for anyone's time and help with this. It's not my best GitHub issue, not sure what else would be helpful to include.

I am having the same issue! It was loading before on android but its not working! Is there any solution?

@SammonBabu Is it working on any screens, or none? There is no solution yet. I just reverted back to 0.28.0 in the meantime.

@Simon-TechForm Update: I tried again today with the same version(1.0.0) and 2/3 of the screens worked, up from 1/3. I then upgraded to 1.3.0 with same results.

The map rendering because you have the google logo.
try
style={StyleSheet.absoluteFill}

I don't think that's an package related issue.
Log if u are using the new renderer.

@Willham12 Hey, thank you for your input. I will try that.
@pinpong Thank you as well, what do you mean by "Log if u are using the new renderer"?

The map rendering because you have the google logo. try
style={StyleSheet.absoluteFill}

I tried that on MapView in place of my styles but it didn't work. This is what my styles are in case it jogs anything:
{
  flex: 1
  width: 100%
}

And it is inside a View with flex: 1
My styles didn't change and the map was working before so it doesn't seem to me that it would be a style issue but I could be wrong.

Commenting to keep this open. I will try again this week and see what the status of things is.

i think i got similar issue when try running example folder https://github.com/react-native-maps/react-native-maps/discussions/4534

So I thought i share my experience with that issue:
In my case the problem was indeed not using onMapReady - I called animateMapTo on componentDidMount which caused the Map weirdly only at expo 47 (in expo 45 it was working with componentDidMount fine) not to load - while the other one did.

@putuoka That does look like what's happening with mine. Is this happening on Android only?

@TheSilentHorizon Thanks for your comment! I am using onMapReady on one of the screens, I can't remember at this point if it's a working one or not. I will go back and try using it on all of the screens. I'm not using Expo but it's worth a try. Were you having the same issue of it working on some screens and not others? What about emulator verses physical device?

@putuoka That does look like what's happening with mine. Is this happening on Android only?

yes happen in android. i think the repo is outdate because i just copy from example folder and can't make it work also try to simple install and not working as well. that's make me to try rnmapsbox with openstreetmap free map without google api key

@TheSilentHorizon Thanks for your comment! I am using onMapReady on one of the screens, I can't remember at this point if it's a working one or not. I will go back and try using it on all of the screens. I'm not using Expo but it's worth a try. Were you having the same issue of it working on some screens and not others? What about emulator verses physical device?

I had a screen where it was working and one that didnt, tested only on android, but same result on emulator and device.

I am also facing that full grey map issue, on react-native 0.69.7, latest react-native-maps version.
The "onMapReady" event is triggered although nothing shows, I am clueless.

🎉 SOLUTION: (USING EXPO SDK 47.0.8) 🎉
UNDERSTADING THE PROBLEM:

Development environment use debug SHA1
Production environment use appSigning SHA1
Your API KEY in CLOUD have permission for Production, but not for Debug.

STEP 1: in your expo project, run npx expo run:android
STEP 2: run cd android
STEP 3: run gradle signingReport
STEP 4: Look for > Task :app:signingReport with text /android/app/debug.keystore you will see your debug keystore, look for SHA1 (this is the debug SHA1 that you need to insert on cloud)

POSSIBLE PROBLEM AND HOW TO FIX:
** Look for > Task :expo:signingReport with text Error: Missing keystore if is missing, do this:
--STEP A: COPY the debug.keystore file in YOUR_ROOT_PROJECT/android/app/debug.keystore
--STEP B: run open /Users/inaciopires/.android/ and PASTE the debug.keystore file
--STEP C: lets, check, run again gradle signingReport and check if your keystore is not missing anymore.

STEP 5: create a new API KEY for dev debug in https://console.cloud.google.com/google/maps-apis/credentials
and add your SHA1 that you find in STEP 4.

🎉  CONGRATULATIONS 🎉
Now your development debug environment will works again

IF YOUR PRODUCTION OR INTERNAL TEST NOT WORKING

STEP A: open the console https://play.google.com/console/u/1/developers/ and select your App
STEP B: Search for App Integrity and select the tab App sign
STEP C:  copy the SHA-1 certification
STEP D: follow the STEP 5 and create your API KEY for this SHA1

🎉  CONGRATULATIONS 🎉
Now your production environment will works
🇧🇷 Thanks, I hope I helped 😉

@vinaciotm Thanks for your comment, I appreciate your time. I'm not using Expo so I don't think this was my issue but maybe it will help someone else. I think my issue had to do with having Android-specific edgePadding (see the most recent update to my original post).

@Simon-TechForm You can go ahead and close this issue if you'd like. I'm still facing challenges but the initial issue has been resolved. The problem seemed to be that I had custom edgePadding for Android. I didn't see anything about the behavior changing in the docs (possible I could have missed it) so would still like to know more about this if you can shed any light.


[12.1] ISPN-13676 XStream 1.4.19

https://issues.redhat.com/browse/ISPN-13676

merged! thanks @tristantarrant !


add option to exit ng serve on error

Command
serve
Description
right now we are facing a big problem in our e2e pipeline because of https://github.com/angular/angular-cli/issues/27167
it's even worse when it happen with serve than build, because it doesn't exit and the e2e never run and the pipeline stuck for hours till someone notice it and kill it manually or it timeout
it's wasting us a lot of time and resources, at least it should exit when it fails
Describe the solution you'd like
add option similar to --exit-on-error or even better a production flag --ci so that it disable the watch for file changes, make it exit on error and do any needed optimization for this use case
Describe alternatives you've considered
I can't think of any
if someone has a workaround for this please share

I'm a little puzzled about why you're running ng serve in your CI setup. However, if you still need to do so, you can disable file watching to ensure the process terminates upon encountering an error.
ng serve --no-watch

Check out: https://angular.io/cli/serve

hi @alan-agius4
I don't see --no-watch option in https://angular.io/cli/serve, I guess it's undocumented option, but anyway it doesn't make the application exit, it still stuck if it encounter an error
nx s --no-watch

> nx run web-app:serve:dev --no-watch

Warning: This is a simple server for use in testing or debugging Angular applications
locally. It hasn't been reviewed for security issues.

Binding this server to an open connection can result in compromising your application or
computer. Using a different host than the one passed to the "--host" flag might result in
websocket connection issues. You might need to use "--disable-host-check" if that's the
case.

\ Building...X [ERROR] TS6133: 'visiblePrice' is declared but its value is never read. [plugin angular-compiler]

    packages/web/src/app/widgets/price-chart-widget/utils/forward-curves.util.ts:108:2:
      108 │   visiblePrice: PriceTypes,
          ╵   ~~~~~~~~~~~~

X [ERROR] TS6133: 'symbol' is declared but its value is never read. [plugin angular-compiler]

    packages/web/src/app/widgets/price-chart-widget/utils/forward-curves.util.ts:109:2:
      109 │   symbol: string,
          ╵   ~~~~~~

X [ERROR] TS6133: 'prices' is declared but its value is never read. [plugin angular-compiler]

    packages/web/src/app/widgets/price-chart-widget/utils/forward-curves.util.ts:110:2:
      110 │   prices: Map<string, PhysicalPriceEntry>,
          ╵   ~~~~~~

X [ERROR] TS6133: 'fillType' is declared but its value is never read. [plugin angular-compiler]

    packages/web/src/app/widgets/price-chart-widget/utils/forward-curves.util.ts:111:2:
      111 │   fillType: TimeSeriesFillType,
          ╵   ~~~~~~~~

Application bundle generation failed. [86.325 seconds]

about our CI setup, we are using nx which has "devServerTarget": "web-app:serve:e2e" which depend on the serve command of Angular to run the application before the cypress test start
how do you suggest to run the e2e test otherwise?

update, trying it in a brand new angular 17 application, it does exit
it seems nx issue

All Boolean options can be negated using the -—no prefix.
See https://angular.io/cli#boolean-options


Add standardised testing files

We should check these generate in CI to prevent regressions

Duplicate of #766.


Slow SVD

I found AF's SVD implementation is quite slow comparing to DGEMM with Radeon HD 7950/FGLRX driver on Debian Jessie:
`In [47]: from pylab import randn, svd
In [48]: x_0 = randn(1000, 1000)
In [49]: %time y_0 = svd(x_0)
CPU times: user 1.24 s, sys: 1.01 s, total: 2.24 s
Wall time: 287 ms
In [50]: x_1 = af.Array(x_0.ctypes.data, x_0.shape, 'd')
In [51]: %time y_1 = af.svd(x_1)
CPU times: user 3.64 s, sys: 3.97 s, total: 7.62 s
Wall time: 3.25 s
In [52]:
`
AF's SVD takes more than 9 times of Numpy's SVD to solve the same matrix, However, the in DGEMM,   AF is faster (but not much) than Numpy:
`
In [75]: from pylab import dot
In [76]: %time z_0 = dot(x_0.transpose(), x_0)
CPU times: user 52 ms, sys: 20 ms, total: 72 ms
Wall time: 10.6 ms
In [77]: %time z_1 = af.matmul(x_1.T, x_1)
CPU times: user 0 ns, sys: 0 ns, total: 0 ns
Wall time: 8.38 ms
`
I am wondering if there are anything I should tune/adjust before proceeding.

@GongYiLiao can you show the out put of af.info() ?

`In [91]: af.info()
ArrayFire v3.3.2 (OpenCL, 64-bit Linux, build default)
[0] AMD     : Tahiti, 3035 MB -- OpenCL 1.2 AMD-APP (1912.5) -- Device driver 1912.5 (VM) -- FP64 Support: True -- Unified Memory (False)
-1- AMD     : Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz, 31865 MB -- OpenCL 1.2 AMD-APP (1912.5) -- Device driver 1912.5 (sse2,avx) -- FP64 Support: True -- Unified Memory (True)
In [92]:
`

Hello,
I can confirm that svd is abnormally slow under python-arrayfire as compared to scipy. I have benchmarked it using the attached file test_svd_af_gul.py, similar to bench_fft.py. Results are presented in arrayfire-test_svd_gul.txt, showing a 10 TIMES SPEED DECREASE with cuda backend as compared to cpu backend or scipy. Moreover opencl backend is not working, despite I can run bench_blas with it, for instance. What is strange is that GPU is almost not used with cuda backend.
I choose scipy rather than numpy because there is a bug with svd in single precision (https://github.com/numpy/numpy/issues/9516).
Thanking you,
GuL916
test_svd_af_gul.py.txt
arrayfire-test_svd_gul.txt


Request to publish your CodeBuild configuration

Hi all,
I see you are building and testing this layer on AWS CodeBuild. As someone currently trying to set up cloud CI for his own Yocto project, it would be interested in seeing how you did it. Specifically if and how you are reusing your sstate cache and download directories. When the build is finished, do you push them to a S3 bucket which is made accessible via HTTP and set as SSTATE_MIRRORS/MIRRORS/PREMIRRORS inYocto? That's the idea I had, but perhaps you came up with something better. You are directly at the core of AWS knowledge, after all. :-)
Not sure if the "Issues" section is the right place for this, didn't see any other support channel.
Thanks!
Manuel

@manuel-wagesreither I am happy to answer here until we start using Github discussions or another venue.
Currently, all our CodeBuild configurations are in the meta-aws-ci repository here.  https://github.com/aws/meta-aws-ci
There is also workshop content there to help you get started.  The more interesting section for you is in Module 2 since Module 1 is building manually through Cloud9.

Please feel free to continue to ask questions here and either me or team members will help you.

Also, regarding finished product propagation - yes, in the class I gave at Embedded World earlier this year I showed this.  The pathway does differ between distros.  However, you will see how simple it is to do with CodeBuild.

Thank you a lot! I will consume the material you mentioned and will give notice in case I need some advice. Much appreciated.
Shall I close this issue or leave it open? Would you prefer questions here or shall I raise them with individual tickets?

Hi @manuel-wagesreither please feel free to open another ticket as challenges arise. If it relates to content in meta-aws-ci feel free to open tickets there.  Hopefully in the very near future we will have a discussion board.


Allow local currency

Expected behavior and actual behavior.
Get the local currency from WooCommerce settings options and send to the pay services.

Duplicate of #285?

@gpressutto5 yes, it was duplicated 😆 thanks bro!
@licianeandreatta another settings that I'm looking for is that:

The merchant can set the countries that wanna sell. I will take into consideration this woocommerce feature.

We can't get these settings, but this is doing automatically by WooCommerce, please, forget my last comment.


ember, ember-data and ember-cli 1.13

The build failed... looks like it stalled out for some reason. I'll restart it

Very nice! I left some comments

Looks like Travis failed again... can you try bumping .travis.yml to node 0.12?

@bcardarella is it ok to merge?

@clairton could you rebase into a single commit? Then I can merge. Thank you again for this!


Regression in floating-point handling in JSON (uppercase exponent E)

I'm using swift protobuf version v0.9.29 with XCode 8.3 (8E162)
{"mileage":6.6678272E7}
The parsing of this JSON fails (JSONDecodingError.failure)
because the textual representation of the floating-point number contains an uppercase E.
I dig in the source and found that the function JSONScanner.parseBareDouble is looking only for the lowercase character e.
The comment of the function parseBareDouble refers to the RFC 7159.
RFC 7159 says [Page 6]
An exponent part begins with the letter E in upper or lower case,
   which may be followed by a plus or minus sign.

I see no reason to refuse a floating-point with an uppercase E.
Debug steps:
JSONDecoder.decodeSingularFloatField() calls
JSONScanner.nextFloat() (line 737) calls
JSONScanner.parseBareDouble`` stop the parsing before the letter E` because it's uppercase.
Then:
JSONDecoder.nextFieldNumber() calls
try scanner.skipRequiredComma() (line 40)
finally JSONScanner.skipRequiredCharacter fail on the letter E
Vivien

Good catch!  Apparently, we forgot to test this case, so it slipped through.

Fixed by #448.


DOC: doc build is broken

See:
https://app.circleci.com/pipelines/github/scipy/scipy/17890/workflows/c9620cd5-3df9-4d95-bfd1-f4ee20b9719e/jobs/61287
https://app.circleci.com/pipelines/github/scipy/scipy/17892/workflows/5ba17356-9d1e-420e-87e6-57ec90212c62/jobs/61291
Also building locally yields the same error

Looks like this might be a numpy issue as pinning an old version fixes the problem

I think this may be due to numpy/numpy#23063

Yes this is due to NumPy moving some things to the C API. Sebastian knows about it and is working on it.

This looks to be fixed now


add  spring cloud invoke dubbo rest & others program language invoke …

…dubbo rest by http client   demo
What is the purpose of the change
add  spring cloud invoke dubbo rest & others program language invoke dubbo rest demo
Brief changelog
Verifying this change
@AlbumenJ

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #12200 (c1329e5) into 3.2 (4f86a3b) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12200      +/-   ##
============================================
- Coverage     69.83%   69.58%   -0.26%
+ Complexity      318        2     -316
============================================
  Files          3406     1593    -1813
  Lines        159452    65437   -94015
  Branches      26575     9526   -17049
============================================
- Hits         111356    45535   -65821
+ Misses        38389    15515   -22874
+ Partials       9707     4387    -5320

see 1844 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Bug]: documentation for options is broken

Current Behavior

Expected Behavior
options are shown
Steps To Reproduce
https://jupyenv.io/documentation/options/
OS
irrelevant

Version
master
Additional Context
lib.mdDoc was removed in https://github.com/tweag/jupyenv/pull/563
Relevant log output
Uncaught TypeError: Cannot read properties of undefined (reading 'style')
    at options.js:151:51
    at NodeList.forEach (<anonymous>)
    at initializePage (options.js:149:6)
    at options/:711:5

seems like options.py  is no longer working
Tagging @garbas and @djacu since they are the only authors

I found that nest_options_in_dom function is producing empty DOM. However both  nix build .\#lib.x86_64-linux.options.optionsJSON and  html = md.render(commonmark) in above options.py seems to yield the same format as before.


[Bug]: WindmillStateReader can generate invalid request due to batching multiple fetches for the same OrderedListState

What happened?
WindmillStateReader performs batching of all pending reads.  However batches containing multiple reads of the same OrderedList state family and tag are not supported by the backend.
This could be handled similarly to Multimap (which has similar limitations) which uses delayUnbatchableMultimapFetches method to generate valid batches.
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[X] Component: Google Cloud Dataflow Runner

.take-issue


Refs #26605 -- Isolated a migrations state test.

@charettes, I found this after this error popped up in the --reverse build on Jenkins:
Migrations for 'migrations':\n  /tmp/django_3ihfl309/tmptjvdadh2/tmpwggjjr4i/migrations
/0004_searchablelocation.py\n    - Create model SearchableLocation\n

I wonder if you have any ideas about adding some sort of check in runtests.py or something to better catch non-isolated models. Do you think it might be feasible?

@timgraham I think the best way would be to set django.db.models.options.Options.default_apps with an instance of an Apps subclass that errors on register_model once all models are loaded. Now that proxy models don't dynamically generate model classes anymore there shouldn't a lof of tests require adjustments from doing this.
This makes me think that we should probably refactor runtest.py to call django.setup() before importing any of Django's stuff like we recommend doing in our documentation. The way runtest.py is architectured  right now causes a couple of issues, #8210 and the fact we can't have anything indirectly imported from it that depend on settings values.


[AKS] Add network policy support to aks subcommand

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@mboersma sorry, what is 'VCR tests'? Appreciate if you could help on that.

@feiskyer in the tests/latest directory under acs are the "VCR" tests. They record CLI interactions with a live server as JSON files so they can be replayed for testing.
It's not reasonable to cover every possible CLI variation in these tests, but we could add this new flag --network-policy to one of the existing commands to give it some test coverage. I would be glad to make that change if we want to do so after this PR is merged--I didn't mean to hold it up.


Working example?

Hello - is this in use anywhere that I can take a look?
Kind regards

I didn't keep it up to date, and it's broken on my blog. My long term plan is to rewrite it.

Thanks for the answer Jim.
On Tue, May 22, 2018 at 02:51 Jim Pick<EMAIL_ADDRESS>wrote:

I didn't keep it up to date, and it's broken on my blog. My long term plan
is to rewrite it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jimpick/lambda-comments/issues/18#issuecomment-390730839,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfRSOOstpjSjYp413Owm5rs0SH1UEdiks5t0v6jgaJpZM4UGUBQ
.

--
Rick Cogley
<EMAIL_ADDRESS>| M: 090-9959-5452

Bilingual IT solutions and management firm—eSolia**Next Japan National
Holiday: "*Marine Day" 16 July, 2018
See Our Refreshed Websites: https://esolia.com and https://esolia.co.jp

--
This email message and any attachments are confidential, and are meant to
be read by the intended recipient only. If you are not the intended
recipient, we would request you delete this message or any attachments
without reading or distributing, and kindly advise eSolia Inc. (contacts:
esolia.com/about http://esolia.com/about). Thank you in advance.


dm: dm ci support qa-release-test trigger

qa-release-test will trigger dm ci from v5.3.0

replay test ci

https://ci.pingcap.net/blue/organizations/jenkins/dm_ghpr_compatibility_test/detail/dm_ghpr_compatibility_test/2/pipeline/
https://ci.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/3/pipeline/


Adding the facility to convert between an IP_ADDRESS type to STRING f…

Add a conversion method to convert an IP_ADDRESS into a STRING.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: vinayvenkat
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @vinayvenkat. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Sync VM

I have noticed that this only sync device and not VM's
Could there be an option to also sync VM's

Looking into this in more detail

It would be nice if you could assign a Zabbix template directly on the device and not only on the device type
a.	Use case would be device type DL 280 server. This could be a windows or Linux install and would require a different template.
i.	I have tried this but if there is no template added to the device type it fails , this makes sense as I am sure it is only looking on the device type for the zabbix_template. The workaround would be to make a DL 280-windows , DL 280-linux but this does not seem like a great way forward.
To add a VM you would also add the custom fields zabbix_hostid and zabbix_template to Virtualization > virtual machine . This way you could allocate a different template
Adding multiple templates would be usefully but not as much of a big issue as the workaround is make a template and link all of the required templates directly in  Zabbix

This project was never intended to synchronize VM's. A couple of reasons but mostly;

Personally i've never seen an implementation of Netbox with VM's administrated and actually being used as SOT for other underlying systems
I wanted to keep the scope of this project small and only focused on physical devices

I'll look into the options but VM's require a whole different API point, different checks, different custom fields. Basically rewriting a shitload of code. I'm currently very busy in my own time so don't expect the scope of this project to change anytime soon, unless someone else wants to start with the work. At the same time it could be interesting so i won't close the issue either. Just very busy a.t.m. and cannot spend any time with such a big feature request.

So i've looked into this and there are (mostly) 2 deal breakers.

The hostgroup pattern has some variables which VM's do not posses or are not required. For example a manufacturer name. Furthermore now that you can assign a custom field as variable, this custom field needs to be present on 2 different object types.
The option of assigning a template to a device type seems logical. It makes sense that 2 devices which are the same type are also using the same type of Zabbix template. However i have no real logical way of defining this data under a VM since there is no device type associated with a VM.

So for right now i will not implement VM sync. This doesn't mean that it will never be implemented but it does mean that other more important issues and enhancements are processed before this.


Highlighting when bounds are present shouldn't be whitespace-sensitive

trait Foo : Bar    // `Foo` is highlighted like a type
trait Foo: Bar {}  // `Foo` is not highlighted like a type

This is hitting the field name case in rust-mode-font-lock-keywords:
     ;; Field names like `foo:`, highlight excluding the :
     (,(concat (rust-re-grab rust-re-ident) ":[^:]") 1 font-lock-variable-name-face)

Maybe one option would be to have rules that match both the "trait" keyword and the type name and then highlight both with a single rule.

This seems to work now.


lib/simbricks: properly closing simbricks channels to not get other simulators stuck

This will require extending the base protocol with a termination message, and simulators to stop sending new messages so the queues don't fill up with other simulators blocked waiting for new slots.

This should be mostly implemented by commits 96273b5ffc360e9493c13b6a0cb47ab654b48d59 ... 042fadfd7df22bd7734c68898c1c34598c8b2d77 .


KAFKA-6170; KIP-220 Part 2: Break dependency of Assignor on StreamThread

This refactoring is discussed in https://github.com/apache/kafka/pull/3624#discussion_r132614639. More specifically:

Moved the access of StreamThread in StreamPartitionAssignor to TaskManager, removed any fields stored in StreamThread such as processId and clientId that are only to be used in StreamPartitionAssignor, and pass them to TaskManager if necessary.

Moved any in-memory states, metadataWithInternalTopics, partitionsByHostState, standbyTasks, activeTasks to TaskManager so that StreamPartitionAssignor becomes a stateless thin layer that access TaskManager directly.

Remove the reference of StreamPartitionAssignor in StreamThread, instead consolidate all related functionalities such as cachedTasksIds  in TaskManager which could be retrieved by the StreamThread and the StreamPartitionAssignor directly.

Finally, removed the two interfaces used for StreamThread and StreamPartitionAssignor.

Some minor fixes on logPrefixes, etc.

Future work: when replacing the StreamsKafkaClient, we would let StreamPartitionAssignor to retrieve it from TaskManager directly, and also its closing call do not need to be called (KafkaStreams will be responsible for closing it).
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

FAILURE
No test results found.
--none--

FAILURE
No test results found.
--none--

FAILURE
No test results found.
--none--

@dguy @mjsax @bbejeck This PR is ready for review. It contains more LOC than usual but the core changes are summarized in the title and many would be trivial changes.

left some comments

@dguy @bbejeck Addressed your comments, and add a few more unit tests on the TaskManager's public APIs.

retest this please

Looked into shouldInjectProducerPerTaskUsingClientSupplierOnCreateIfEosEnable and cannot reproduce the issue locally. Also since it seems not have any timing races I'd suspect is not related to this PR.

retest this please

Removed part of the shouldInjectProducerPerTaskUsingClientSupplierOnCreateIfEosEnable as it calls values() on the map which does not guarantee ordering at all.

@dguy could you take another look?

Thanks for the reviews! Merged to trunk.


Prosodic features

Hello,
Can we get the prosody features of any Language with this library as you have not mentioned the specific language in it.
I want to compute the prosody features of the French and English Language.
And If we need to compute the prosody features of the other language how shall we do it with this library
Thank you

Sorry for my reply with delay
I have checked for French and Japanese, it worked quite well for French


x/tools/go/packages: support packages entirely defined in overlays

From comments on https://golang.org/cl/172409:
"I think in the long run we are either going to have to have some complicated logic to associate go files with packages the same way go list would, or we are going to have to write all the overlays to a temporary directory and actually run go list on them."

@stamblerre aren't we done here now?

With @matloob's changes, I believe so. Thanks for noticing this - closing now.

wooooooh!~


Add new Zehnder ComfoAir 350 integration

Description:
This integrates support for Zehnder ComfoAir 350 ventilation units and compatibles. This is not to be confused with the comfoconnect component, which integrates the newer Q350 units.
It allows reading temperature sensors and setting fan speeds. Currently it expects a CC Ease controller to be present.
Documentation will be written if feedback indicates a chance to merge.
Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10964
Example entry for configuration.yaml:
comfoair:
  name: ComfoAir
  serial_port: /dev/ttyS0

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

@frenck: I've added docs now.

If this is the same brand as the  comfoconnect integration, just a different model, we should combine both models into a single integration. We can use a config option to select between the models and logic paths.
It's ok to depend on different libraries for the different models.

CC @michaelarnauts

The two models are quite different, but are from the same vendor. Comfoconnect is using a bridge to communicate, and this uses a serial connection. I don't think there is code to share between the two implementations, so I'm not sure if there is a benefit to merge them.

Yes, they really don't have anything in common.

It's our standard to merge different models of devices from the same brand into the same integration.

We could just merge the files and use different classes, but the register for the sensors are also different, so the config validation will probably be quite messy.

We can also rename comfoair to jsstorkair to use a different but compatible brand.
In any case, merging this code into a module called comfoconnect seems insane, because comfoconnect is just a bridge you can buy as an accessory to connect newer, incompatible devices to a network.

@MartinHjelmare I can't find a requirement that components from a vendor have to be merged together. I can understand this from a user perspective, but it just doesn't make sense to merge them since they are completely different implementations for different devices with different features.
I took a quick look at the integrations list and found a bunch of other examples:
Both Aruba Presence Detection, but different implementations:

https://www.home-assistant.io/integrations/aruba/
https://www.home-assistant.io/integrations/cppm_tracker/

Both Bluetooth trackers, but a different version:

https://www.home-assistant.io/integrations/bluetooth_le_tracker/
https://www.home-assistant.io/integrations/bluetooth_tracker/

Both Cisco Presence Detection, but different implementations:

https://www.home-assistant.io/integrations/cisco_ios/
https://www.home-assistant.io/integrations/cisco_mobility_express/

All three components are Media Players of Denon:

https://www.home-assistant.io/integrations/denonavr/
https://www.home-assistant.io/integrations/denon/
https://www.home-assistant.io/integrations/heos/

I've stopped looking at the letter D, I'm sure there are a lot more examples.

Examples in our code base cannot be used as argument why we should do something. The rules evolve over time and there will always be code not following our latest set of rules.
I think that in this case, it's ok to keep them separate, since they are a complete different API (serial vs IP)

@michaelarnauts: I addressed your comments and rebased my branch. However, your recommendation to use vol caused some trouble, i.e. CONF_RESOURCES did not appear in config. That's why I left it out for now. You can see the additional patch here: https://github.com/mtdcr/home-assistant/commit/5846640fbdb8b4e777aa9af8b6ba47a27d721af1
Can you please take a brief look at it? Maybe you can see at a glance what's missing to properly glue it together.
I also removed the dependency on pyserial-asyncio, which was only indirect, and moved another import to the top.
It would be nice if someone with the necessary privileges could remove the „docs-missing“ label.

@michaelarnauts: I addressed your comments and rebased my branch. However, your recommendation to use vol caused some trouble, i.e. CONF_RESOURCES did not appear in config. That's why I left it out for now. You can see the additional patch here: mtdcr@5846640
Can you please take a brief look at it? Maybe you can see at a glance what's missing to properly glue it together.
I also removed the dependency on pyserial-asyncio, which was only indirect, and moved another import to the top.
It would be nice if someone with the necessary privileges could remove the „docs-missing“ label.

I don't immediately see why the PLATFORM_SCHEMA is wrong. Maybe @MartinHjelmare can see more?
You can fix your import errors by running isort on your files.

@MartinHjelmare, thanks for your thorough review! As the remaining two changes require an updated library, would it be possible to handle them in a follow-up PR? It will make the library more complex and therefore will need some time to develop and test. The current version works pretty stable, AFAICT.

I think we should wait here for an updated library. We don't want to add protocol specific code in home assistant. It's one of our basic rules.

PR has gone stale. Closing it.


Copy address when clicking on text

copy the address/blinded utxo to clipboard if user clicks on the string, not just when clicking on copy button.

Feature added in 0.1.4


bug: AAO trace and optimize exclusions don't exclude (at least on MA manual bake)

The exclusions feature does not guaranteed to exclude from all optimizations. for some optimizations, it's hard to exclude some portion of avatar.
Which optimization and which portion do you intended to exclude?

it was removing parts of PCS added through VRCFury, because I believe it thinks some of the objects never activate

The manual bake feature of MA / NDMF doesn't support VRCFury since VRCFury is not on the NDMF.
If you want to preview, it's much better to use play mode.

@fuyushi Is my previous answer fixes your problem?


CORS

Hi! When I try to create a new docker-compose.yml from Swagger UI (http://<IP_ADDRESS>:5000/api/), I get a CORS error.

But in console where I run my local server (WooPyAPI) I dont have any error.

At first, I thought the error was caused by me, or my .env file I had generated, but later I generated a new mock .env and faced the same problem again. Here you can find the .env that I generated using web.py as a reference. P.S: Same file used in Swagger
#Database Configuration
DATABASE_NAME=pizzify_db
DATABASE_USER=pizzify_user
DATABASE_HOST=localhost
# Mail Configuration
MAIL_SMTP_HOST=smtp.example.com
<EMAIL_ADDRESS># Cache Configuration
CACHE_HOST=localhost
CACHE_PORT=6379
# Website Configuration
WEBSITE_TITLE=Ja Pizzify
WEBSITE_HOSTNAME=japizzify.com
WEBSITE_ADMIN_USERNAME=admin
<EMAIL_ADDRESS># Proxy Configuration
PROXY_TITLE=JaPizzifyProxy
PROXY_HOSTNAME=japizzify-proxy.com
# Host Configuration
HOST_HOSTNAME=ja-pizzify-server
HOST_IP=<IP_ADDRESS>
HOST_MAC=00:11:22:33:44:55
HOST_CPU=4
HOST_RAM=8GB
HOST_OS=Linux
HOST_KERNEL=4.19.0
HOST_DOCKER=20.10.3

Since nothing was working with the web part, I wanted to experiment with the CLI and followed this path:
1-) I created a test file within the project (Root Directory).
2-) I created an .env file in the test file.
And as a result, my file impression was like this:
 VSProjects/woopy/test/.env
Then I run command witch has written in README.md
I wrote the generate command:
 python -m cli gen-dc test
But as a result, I kept getting errors again.

Thank you!

BTW: After typing the python3 -m web command, the terminal sends us to localhost:5000, but by default Flask does not run on localhost, it starts at port <IP_ADDRESS>/. I am sharing with you the article link that may be helpful to fix this.
How to change start posrt in flask?

issue has been resolved


Where can I find the raw unprocessed reads?

Hey,
is there a possibility to download the tabula muris data as unaligned, not adapter trimmed data from AWS, or is this only possible on SRA?
Ich checked the AWS bucket but both folders '10x_bam_files' and 'facs_bam_files' seem to only contain bam files with the *.Aligned.out.sorted.bam suffix. And in this case I would assume that even when unaligned reads are kept, the reads have all been preprocessed/trimmed?
Thanks!
Falko

@jamestwebber might be able to help

The data on AWS is not adapter trimmed–the insert size for these reads is pretty large so there was no need to do so.

Thanks for the response! I also assume discordant reads where kept, so I could get all original reads from the bam file?

I believe so, but I haven't verified this by doing the round-trip back to a fastq file and verifying...if you give it a try we could compare read #s with the original fastq files.
We discussed with the AWS public data folks and decided to upload only BAM files because we thought that would cover everyone's needs. But if they are missing reads (maybe chimeric reads or something) that might need to be changed.

Thanks for the swift reply! I will download a few and report back in latest about a week or so.
Best,
Falko

We checked three files:
SRR6571079 / A1-MAA000400-3_8_M-1-1
SRR6571474 / A10-MAA000586-3_8_M-1-1
SRR6571475 / A11-MAA000586-3_8_M-1-1
See below. The fastq column contains the number of reads as reported in "spots read" by fasterq-dump [SRR]. The bam column shows the number of unique read pairs from the aws bam files as reported by samtools fastq [BAM]
Total read pairs:
SRR                 FASTQ       BAM
SRR6571079   3288555     3048963
SRR6571474   1284467     1175468
SRR6571475   2070727     1903004
So it seems that the bam files do not contain all reads?

Hm you must be right. The BAM files on AWS are the output from STAR, and my best guess is that it split out reads that it identified as chimeras or splice junctions. That's unfortunate--it would have been nice to have the raw files in that resource, rather than only in SRA.

Do you have any plans of uploading the raw files to aws? Having either fastq/unaligned bam files as well would be awesome!

We ended up uploading the BAM files after discussion with the AWS public data team, but we didn't realize we'd be missing out on a small number of reads that are potentially interesting. Given that AWS is hosting the data for us I don't think there's a plan to add the fastq files as well, but they should be available from SRA if you want them.

I'm using the 10x "bamtofastq" tool to attempt recovery of the original fastq reads from the AWS bam files. The tool runs, but the barcodes are found in the R "reads" files, and these only contain 26 nt total for all reads.
This is my first time playing with this type of data, so I may be out of bounds here, but I'm guessing these BAMs aren't useful for recovering the raw reads with 10x's tool ?

For the 10x data, I believe the bamtofastq tool should produce a 26bp R1 file containing the barcode and UMI, an 8bp file of indexes, and an R2 file which contains the actual mRNA read. Is that what you're getting?

 I stand corrected. I just found those R2 files and came back here to delete my comment, but you beat me to it :p
Thank you!


Please add new model

Hello,
First of all, thank you for the working local integration. My TP09 is now FINALLY in HA. Would it be possible to update the database for the newer models too please? The one missing for me is Purifier Hot+Cool Formaldehyde™ (HP09, Device Type is 527K).
Thank you!

I've used PR #30 as a base to manually add support and it connects fine, so it's just a matter of adding a few lines to support it.
That PR identifies it as a Hot+Cool only so the formaldehyde measurements are missing, but everything else seems to be working well as far as I can tell.
I'll try to see if I can open a PR myself to add proper support for it including the formaldehyde sensor.

Okay so here's what I've got so far :
diff --git a/libdyson/libdyson/__init__.py b/libdyson-new/__init__.py
index 7b05791..ae8fb07 100644
--- a/libdyson/libdyson/__init__.py
+++ b/libdyson-new/__init__.py
@@ -15,6 +15,7 @@ from .const import (
     DEVICE_TYPE_PURE_HOT_COOL_LINK,
     DEVICE_TYPE_PURE_HUMIDIFY_COOL,
     DEVICE_TYPE_PURIFIER_HUMIDIFY_COOL_FORMALDEHYDE,
+    DEVICE_TYPE_PURE_HOT_COOL_FORMALDEHYDE,
 )
 from .const import CleaningMode  # noqa: F401
 from .const import CleaningType  # noqa: F401
@@ -32,7 +33,7 @@ from .dyson_device import DysonDevice
 from .dyson_pure_cool import DysonPureCool
 from .dyson_pure_cool import DysonPureCoolFormaldehyde
 from .dyson_pure_cool_link import DysonPureCoolLink
-from .dyson_pure_hot_cool import DysonPureHotCool
+from .dyson_pure_hot_cool import DysonPureHotCool, DysonPureHotCoolFormaldehyde
 from .dyson_pure_hot_cool_link import DysonPureHotCoolLink
 from .dyson_pure_humidify_cool import DysonPureHumidifyCool, DysonPurifierHumidifyCoolFormaldehyde
 from .utils import get_mqtt_info_from_wifi_info  # noqa: F401
@@ -58,6 +59,8 @@ def get_device(serial: str, credential: str, device_type: str) -> Optional[Dyson
         return DysonPureCoolFormaldehyde(serial, credential, device_type)
     if device_type == DEVICE_TYPE_PURE_HOT_COOL_LINK:
         return DysonPureHotCoolLink(serial, credential, device_type)
+    if device_type == DEVICE_TYPE_PURE_HOT_COOL_FORMALDEHYDE:
+        return DysonPureHotCoolFormaldehyde(serial, credential, device_type)
     if device_type in [
         DEVICE_TYPE_PURE_HOT_COOL,
         DEVICE_TYPE_PURE_HOT_COOL_NEW,
diff --git a/libdyson/libdyson/const.py b/libdyson-new/const.py
index 254e1cb..d655aa0 100644
--- a/libdyson/libdyson/const.py
+++ b/libdyson-new/const.py
@@ -13,6 +13,7 @@ DEVICE_TYPE_PURIFIER_HUMIDIFY_COOL_FORMALDEHYDE = "358E"
 DEVICE_TYPE_PURE_HOT_COOL_LINK = "455"
 DEVICE_TYPE_PURE_HOT_COOL = "527"
 DEVICE_TYPE_PURE_HOT_COOL_NEW = "527E"
+DEVICE_TYPE_PURE_HOT_COOL_FORMALDEHYDE = "527K"

 DEVICE_TYPE_NAMES = {
     DEVICE_TYPE_360_EYE: "360 Eye robot vacuum",
@@ -27,6 +28,7 @@ DEVICE_TYPE_NAMES = {
     DEVICE_TYPE_PURE_HOT_COOL_LINK: "Pure Hot+Cool Link",
     DEVICE_TYPE_PURE_HUMIDIFY_COOL: "Pure Humidify+Cool",
     DEVICE_TYPE_PURIFIER_HUMIDIFY_COOL_FORMALDEHYDE: "Purifier Humidify+Cool Formaldehyde",
+    DEVICE_TYPE_PURE_HOT_COOL_FORMALDEHYDE: "Pure Hot+Cool Formaldehyde"
 }

 ENVIRONMENTAL_OFF = -1
diff --git a/libdyson/libdyson/dyson_pure_hot_cool.py b/libdyson-new/dyson_pure_hot_cool.py
index 3ceb789..561b383 100644
--- a/libdyson/libdyson/dyson_pure_hot_cool.py
+++ b/libdyson-new/dyson_pure_hot_cool.py
@@ -1,8 +1,17 @@
 """Dyson Pure Hot+Cool device."""

+from typing import Optional
+
 from .dyson_device import DysonHeatingDevice
 from .dyson_pure_cool import DysonPureCool

-
 class DysonPureHotCool(DysonPureCool, DysonHeatingDevice):
     """Dyson Pure Hot+Cool device."""
+
+class DysonPureHotCoolFormaldehyde(DysonPureHotCool):
+    """Dyson Pure Hot+Cool Formaldehyde device."""
+
+    @property
+    def formaldehyde(self) -> Optional[int]:
+        """Return formaldehyde reading."""
+        return self._get_environmental_field_value("hcho")

Instantiates and works fine, but the formaldehyde entity is still missing, not sure why.
I'll have another look later on, but hopefully this is about it and just need a small fix to get the sensor to register.

Quick update, this actually works fine, I was just missing a change in the actual integration to use that sensor.
Basically in sensor.py for the dyson local integration you just need to add DysonPureHotCoolFormaldehyde to the import, and or isinstance(device, DysonPureHotCoolFormaldehyde) line 71 in the condition and it works fine.
Interestingly the sensor doesn't have a unit in HA, so I'm not sure what to make of the readings, but it is reading.
I'll open proper PRs now

Quick update, this actually works fine, I was just missing a change in the actual integration to use that sensor.
Basically in sensor.py for the dyson local integration you just need to add DysonPureHotCoolFormaldehyde to the import, and or isinstance(device, DysonPureHotCoolFormaldehyde) line 71 in the condition and it works fine. Interestingly the sensor doesn't have a unit in HA, so I'm not sure what to make of the readings, but it is reading.
I'll open proper PRs now

Hi, do you have news for Formaldehyde sensor?
Thanks

@terzo33 Have a look at my two PRs, works fine with them

@terzo33 Have a look at my two PRs, works fine with them

Can I have link? Thanks

Quick update, this actually works fine, I was just missing a change in the actual integration to use that sensor.
Basically in sensor.py for the dyson local integration you just need to add DysonPureHotCoolFormaldehyde to the import, and or isinstance(device, DysonPureHotCoolFormaldehyde) line 71 in the condition and it works fine. Interestingly the sensor doesn't have a unit in HA, so I'm not sure what to make of the readings, but it is reading.
I'll open proper PRs now

I made the change on import and then I add this string here(line 81).  is that okay?

I managed to integrate the Formaldehyde sensor but the values do not coincide with the Dyson application values.  for example on the Dyson application it marks 0.004 mg/m3 while on the home assistant it marks 1.5 (without units of measurement).  even if on the Dyson application the unit of measurement is mg/m3 and on HA it is µg/m3... 0.004mg/m3 would be 4µg/m3 and not 1.5 as marked on the home assistant.  so there is something wrong...

Yes, the formaldehyde sensor in the current version isn't correctly defined, that's also addressed in my PR.
As for the values themselves some of the fields in the app are indexes, meaning it's not actually letting you see the real value, that may be why. It may also be doing some kind of aggregation over time, I'm not sure maybe @shenxn would know.
https://github.com/shenxn/ha-dyson/pull/175
https://github.com/shenxn/libdyson/pull/36


approximate_gamma issue on Linux with AMD 7900X CPU

I don't know what the exact cause is, but there's an issue when converting RGB to YUV for a color conversion and approximate_gamma=true.
I'm experiencing the problem running VapourSynth on MX Linux (AMD 7900X CPU), or with AVSResize running in Wine, but not when running the Windows version of either program on Windows 11 in VirtualBox. I initially mentioned the problem at doom9 and nobody running Windows in the doom9 thread could duplicate it.
clipA = \
BlankClip(color=color_red)\
.ConvertToYUV420(matrix="rec2020")\
.Spline36Resize(240,240)\
.ConvertBits(16)

clipB = clipA\
.HistoTop().Subtitle("BlankClip")

clipC = clipA\
.z_ConvertFormat(colorspace_op="2020:2020:2020:limited=>rgb:linear:xyz:full", pixel_type="RGBP16")\
.z_ConvertFormat(colorspace_op="rgb:linear:xyz:full=>709:709:709:limited", pixel_type="YUV420P16")\
.HistoTop().Subtitle("ag true")

clipD= clipA\
.z_ConvertFormat(colorspace_op="2020:2020:2020:limited=>rgb:linear:xyz:full", pixel_type="RGBP16", approximate_gamma=false)\
.z_ConvertFormat(colorspace_op="rgb:linear:xyz:full=>709:709:709:limited", pixel_type="YUV420P16", approximate_gamma=false)\
.HistoTop().Subtitle("ag false")

clipE= clipA\
.z_ConvertFormat(colorspace_op="2020:2020:2020:limited=>rgb:linear:xyz:full", pixel_type="RGBP16", approximate_gamma=false)\
.z_ConvertFormat(colorspace_op="rgb:linear:xyz:full=>709:709:709:limited", pixel_type="YUV420P16", cpu_type="avx512f")\
.HistoTop().Subtitle("ag true     cpu_type avx512f")

StackHorizontal(clipB, clipC, clipD, clipE)

There's also something odd happening when limiting the CPU instructions for Avisynth itself (running in Wine) that wasn't effecting anyone at doom9 running Windows. I haven't investigated whether it's possible to limit the CPU the same way in VapourSynth so I don't know if it's a zimg issue as such. It might be some sort of Wine anomaly.
The same script as above, only with SetMaxCPU("ssse3") added to the beginning.

Cheers!

Doom9 reference: https://forum.doom9.org/showthread.php?t=173986&page=19

The first issue with the darkening is fixed. The other issue with the green image is not reproduced.

It's probably the same issue, but I have a question anyway....
I realized after reporting the bug that the same thing was happening without the need to convert to/from RGB.
z_ConvertFormat(colorspace_op="2020:2020:2020:limited=>709:709:709:limited", pixel_type="YUV420P16")

My question though is....
It seems to be traditional for color conversions to be done by converting to RGB first then back to YUV, but while I was experimenting, at least with single colors, there appeared to be no difference between a direct conversion and converting to RGB first, so I was wondering if it's necessary for zimg. The only exception to that rule I've found so far is when the color being converted is red. I've only played around with conversions from rec.2020 to rec.709 at the moment.
Thanks!
clip = BlankClip(color=color_purple).ConvertToYUV420(matrix="rec2020").Spline36Resize(240,240).ConvertBits(16)
clipB = clip\
.z_ConvertFormat(colorspace_op="2020:2020:2020:limited=>rgb:linear:xyz:full", pixel_type="RGBP16", approximate_gamma=false)\
.z_ConvertFormat(colorspace_op="rgb:linear:xyz:full=>709:709:709:limited", pixel_type="YUV420P16", approximate_gamma=false)
clipC = clip\
.z_ConvertFormat(colorspace_op="2020:2020:2020:limited=>709:709:709:limited", pixel_type="YUV420P16", approximate_gamma=false)
Compare(clipB, clipC)

z.lib will automatically convert YUV to RGB when performing a colorspace conversion. Creating an intermediate RGB clip may affect the result if the input has out-of-range colors and the intermediate format is integer, as this will cause clipping.

Thanks for the info.


refs #74 minify css in production

Description
Minify css in production #74
Motivation and Context
Reduces the size of css file.
How Has This Been Tested?
Tested with npm run build The file /dist/style.css is minfied.
Screenshots (if appropriate):

Types of changes

[x] Bug fix (Enhancement)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thank you for the help! It works great 🎉
One small nitpick. You used a mix of tabs and spaces for indentation which caused the linter to throw a warning. I would suggest installing http://editorconfig.org/ in your editor or IDE which will configure the coding style each project uses automatically.

@TalAter , Sorry about that and thanks for letting me know. I will use it for future commits.


Getting an errors in console when listing users and groups after creating a secondary user store

Describe the issue:
After adding a secondary user store Ldap Read/write or ReadOnly,
There are errors when listing users & groups in console
*No errors in the management console
How to reproduce:
1.Add new Ldap user store via management console / console
2. Login to console and list users & groups
Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: 5.12.0 alpha9
OS: [Mac
Database: Mysql
Userstore: JDBC -mysql Primary

Uploading issue.mp4…

@NilukaSripalim mp4 which shows reproduce steps, is not uploaded properly. Could you please re upload it?

Updated,
https://user-images.githubusercontent.com/39120228/149073784-7909bb26-8f1f-4055-8901-2930bc61a059.mp4

Fixed with https://github.com/wso2/carbon-kernel/pull/3251


Minimalist example projects with tests: JavaScript Calculator

Soon, campers will be able to build all front end projects right on FreeCodeCamp.com (no need for CodePen). We will also use automated tests to check whether campers have completed all of the agile user stories (and code review will become optional).
This means we need to redesign these projects to have user stories that can be tested. And we should err on the side of having lots of tests (I'm thinking ~10 tests per project).
At the same time, we've heard feedback that campers are intimidated by the highly polished example projects we use. Instead of having fancy example projects, we should have minimalistic project examples that focus on functionality rather than appearance, animations, etc.
So we need:

[ ] New agile user stories with one automated test each
[ ] Minimal example project that fulfills all of these user stories

The current user stories for the JavaScript Calculator are these:

[ ] I can add, subtract, multiply and divide two numbers.
[ ] I can clear the input field with a clear button.
[ ] I can keep chaining mathematical operations together until I hit the equal button, and the calculator will tell me the correct output.

To complete this:

reply to this issue with the user stories and their tests
Link to a CodePen of the minimalist code

I'm moving this to the curriculum development repo.


scale up cluster failed to umount tmp rootfs.

2021-05-27 15:13:02 [WARN] failed to umount /tmp/my-cluster, err: device or resource busy
2021-05-27 15:13:02 [EROR] failed to remove dir /tmp/my-cluster

https://github.com/alibaba/sealer/pull/200


Update the read bug

The condition of the product, no longer needs to be passed in the payload while trying to read a record.

Codecov Report

Merging #78 (2589d73) into master (4e175cf) will decrease coverage by 1.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   98.01%   96.86%   -1.15%
==========================================
  Files           6        6
  Lines         352      351       -1
==========================================
- Hits          345      340       -5
- Misses          7       11       +4

Impacted Files
Coverage Δ

service/routes.py
96.94% <100.00%> (-3.06%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Refresh downloads on demand

Preparation step for #128
- Summary
This feature enables users to get access to downloads which have been added to products from their orders after their purchase. Changes in the product metadata are going to be picked up.
Use the endpoint /orders/{order_id}/downloads/refresh to fetch updates on demand.
There is an unfinished implementation of an automatic, periodic refresh task that is planned to be introduced soon. This is a first step.
- Test plan
There is a http test for the /orders/{order_id}/downloads/refresh endpoint
- Description for the changelog
Refresh order downloads periodically and on demand
- A picture of a cute animal (not mandatory but encouraged)

Closed in favor of https://github.com/netlify/gocommerce/pull/184


Installation

Hey,
I have sourcekitten installed via homebrew, and running sourcekitten in a shell works.
I'm getting this in the Sublime Console though:
reloading plugin SourceKittenSubl.subl
plugins loaded
Package Control: Skipping automatic upgrade, last run at 2017-01-09 11:59:13, next run at 2017-01-09 12:59:13 or after
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 591, in on_query_completions
    res = callback.on_query_completions(v, prefix, locations)
  File "/Users/rudedogg/Library/Application Support/Sublime Text 3/Packages/SourceKittenSubl/subl.py", line 18, in on_query_completions
    suggestions = subl_source_kitten.complete(offset, file, project_directory, text)
  File "/Users/rudedogg/Library/Application Support/Sublime Text 3/Packages/SourceKittenSubl/dependencies/../src/subl_source_kitten.py", line 16, in complete
    collection = source_kitten.complete(offset, file, project_directory, text)
  File "/Users/rudedogg/Library/Application Support/Sublime Text 3/Packages/SourceKittenSubl/dependencies/../src/source_kitten.py", line 25, in complete
    return _execute(cmd, _json_parse)
  File "/Users/rudedogg/Library/Application Support/Sublime Text 3/Packages/SourceKittenSubl/dependencies/../src/source_kitten.py", line 86, in _execute
    return _execute_cached("§§§".join(cmd), result_handler)
  File "./python3.3/functools.py", line 275, in wrapper
  File "/Users/rudedogg/Library/Application Support/Sublime Text 3/Packages/SourceKittenSubl/dependencies/../src/source_kitten.py", line 92, in _execute_cached
    with Popen(cmd, stdout=PIPE, stderr=PIPE) as p:
  File "./python3.3/subprocess.py", line 819, in __init__
  File "./python3.3/subprocess.py", line 1448, in _execute_child
FileNotFoundError: [Errno 2] No such file or directory: 'sourcekitten'

Did I go wrong somewhere?

Did a little searching and found this: http://stackoverflow.com/questions/18855932/file-not-found-error-when-running-local-binary-with-popen
Changing line 18 of source_kitten.py to "/usr/local/bin/sourcekitten" did the trick.

Sorry for not responding sooner, I thought I had emails enabled for notifications.
I wonder why I don't get this issue... Is /usr/local/bin in your shell $PATH variable (run echo $PATH to check)? And do you launch Sublime Text from command line?

@Dan2552 No problem!

Is /usr/local/bin in your shell $PATH variable

Yes I have /usr/local/bin in the echo $PATH output.

And do you launch Sublime Text from command line?

No, I just use launch it from the dock. I tried it from the command line just to check - and get the FileNotFoundError: [Errno 2] No such file or directory: 'sourcekitten' error.

@rudedogg You mean changing this:
calculated_offset = _calculate_source_kitten_compatible_offset(offset, text)

to this?
calculated_offset = "/usr/local/bin/sourcekitten"

@dielsonsales the line numbers have probably changed a bit
Give this a go:
https://github.com/Dan2552/SourceKittenSubl/blob/master/src/source_kitten.py#L23
-        "sourcekitten",
+        "/usr/local/bin/sourcekitten",

Thanks! It's working now.

This should be resolved in https://github.com/Dan2552/SourceKittenSubl/pull/22


back shortcut key not origin file page

Issue Type: Bug
1、create TestA.ts and TestB.ts
//TestA.ts
import { TestB } from "./TestB";

/**
 * TestA
 */
export class TestA {
    public testMethodA() {
        let b = new TestB();
        b.testMethodB();
    }
}

//testB.ts
/**
 * TestB
 */
export class TestB {

    public testMethodB() : void{

    }
}

2、open TestA.ts and TestB.ts file
3、Open a new TestA.ts at a time TS window, now TestA.ts is 2 window, TestB.ts is 1 window.

4、left window TestA.ts line 9 'b.testMethodB();', use key F12 auto jump left window TestB.ts
5、use Key ctrl+-
Expected behavior
focus is rollback left window TestA.ts
Actual behavior
focus is right window TestA.ts
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:37:28.172Z)
OS version: Darwin x64 21.2.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-8100B CPU @ 3.60GHz (4 x 3600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
5, 5, 6

Memory (System)
20.00GB (0.06GB free)

Process Argv
--crash-reporter-id 1575bad4-d5b3-4fc9-aa72-0a862d0f44dc

Screen Reader
no

VM
0%

Extensions (25)

Extension
Author (truncated)
Version

cocos-creator
Chu
0.0.1

cocos-debug
Chu
0.0.1

githistory
don
0.6.19

gitlens
eam
11.7.0

rest-client
hum
0.24.6

vscode-language-pack-ja
MS-
1.63.3

vscode-language-pack-zh-hans
MS-
1.63.3

csharp
ms-
1.23.17

vscode-dotnet-runtime
ms-
1.5.0

remote-ssh
ms-
0.70.0

remote-ssh-edit
ms-
0.70.0

js-debug-nightly
ms-
2022.1.1317

live-server
ms-
0.2.12

vscode-typescript-next
ms-
4.6.20220113

vetur
oct
0.35.0

java
red
1.2.0

cloudbase-toolkit
ten
0.3.1

tencent-cloud-vscode-toolkit
ten
2.0.17

vscodeintellicode
Vis
1.2.15

vscode-java-debug
vsc
0.37.0

vscode-java-dependency
vsc
0.18.9

vscode-java-pack
vsc
0.20.0

vscode-java-test
vsc
0.33.1

vscode-maven
vsc
0.34.2

aegikit
yes
1.0.1

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vscop804:30404766
vs360:30404995
vsrem710cf:30416617
vsccppwtstudy:30421978

See https://github.com/microsoft/vscode/labels/workbench-history for duplicates. Specifically making navigation aware of editor groups.

Sorry, my English is very poor. I don't know what information you need me to provide.
Is this the edit group area on the right? I provided a screenshot of this in step 3.
Or do you need me to provide other information?

I was suggesting to look https://github.com/microsoft/vscode/labels/workbench-history for a duplicate of this one, I am quite sure there is.

There is indeed a similar #9526, but it is a backward between different lines within the same file range. However, I'm not sure whether this issue is belongs to duplication because it involves the jump between multiple files

Yeah that is the one I had in mind.


Merge pull request #1 from c21u/master

Update from original

Closing as this makes no source changes.


Improve accuracy of matching

Glenfiddich 12 Year Old Amontillado Sherry Cask Finish Scotch Whisky
https://www.astorwines.com/item/48699
Glenfiddich 12yr Special Edition Amontillado Sherry Cask Finish Single Malt Scotch Whisky
https://woodencork.com/collections/whiskey/products/glenfiddich-12-year-old-amontillado-sherry-cask-finish-scotch-whisky
We didnt have "Glenfiddich 12-year-old Amontillado Sherry Cask" (the preferred name) in the db, so it matched on "Glenfiddich 12-year-old".
Here's some quick thoughts on a tokenization strategy that might work:

Do a prefix search on the distillery with a max tokens approach:

tokenize name, select up to N tokens to search for distillery e.g.
name is 'Macallan 12-year-old Cool bottle'
select from entity where name = 'Macallan' OR name = 'Macallan 12-year-old' OR name = 'Macallan-12-year-old Cool';

do token matching with prefix and consecutive

name is 'Macallan 12-year-old Cool bottle' in the db
BUT the store lists it as 'Macallan 12-year-old Special Edition Cool bottle'
select from bottle where brand = 'Macallan';
split all bottles on tokens
[Macallan, 12-year-old, Special, Edition, Cool, Bottle]
we find consecutive matches:
[Macallan, 12-year-old], [Cool, Bottle]
In this case its the only match, so we're probably fine, but what if thats a different bottle? Probably nothing we can do (like the original problem identified here). We might be able to do a threshold so if e.g. <40% of tokens match, or the token prefix match is < 60% of the length?
Another example, what do we do if the db has:
Macallan 12-year-old Cool Bottle
Macallan 12-year-old Special Edition Cool Bottle
It needs to match the latter, which would be a full token match, or longest token?
number of tokens likely wont work because it could have lots of useful words (like Single Malt). Full match in this case is fine, but what if one adds e.g. "Single Malt" to the end. Probably still longest token should work.
We will need to make it so we can override matches, and when do we, we should simply store those as alternative names on a bottle. We may also use those concerns to improve the rulesets (e.g. its possible we choose to ignore certain words, like the bottle category name, in tokenization).

See also #51

Another example problem:

This is a wildly long match. Really need to mock up the MVP of this idea.

One problem I didn't answer last time: what happens when theres just a "best" match? I think we have to disqualify it, store it somewhere, maybe match it up later.
We'll also want to store all the name mappings so the lookups are free after the first time.
May rely on ChatGPT to help w/ low confidence matches too.

Need to dig in more into things like BM25 and see if they're a more efficient and effective alternative to embeddings for finding similar matches
https://en.wikipedia.org/wiki/Okapi_BM25#:~:text=BM25 is a bag-of,their proximity within the document.
Next step though at this point is building a fast accessible moderation queue and removing the non-precise upserts.


New release requires Java 11 or greater.

I could not get docx4j to pass tests with Java 8 and gave up for now.
Updated the project to Java 11 and released 0.64.0
If this is a show stopper for anyone please let me know and I will see if I can figure out how to keep Java 8 going a bit longer.

I usually try to stay on older language levels for a while.  In my project I just transitioned to Java 9 to use module features but I have stayed away from Java 11 features. I could isolate the Java 11 requirement to the module that uses flexmark, but I would then have a Java 11 dependency for just one module at runtime.  Do what you have to do but I think it could break a lot of people, particularly crossing the Java 8/9 boundary.

Hey! First off, thank you for the excellent library!
I maintain a wrapper in the Clojure language, which strives to maintain backwards compat as much as possible. As such, I would much prefer if we'd stay on Java 8 for as long as we can. I don't know how many of my users are on Java 8, but it aligns with the strong "updates shouldn't break anything" ethos.

Wouldn't it make sense to:

keep the 0.x.x releases compatible with Java 8, and
have a new 1.x.x release line that requires Java 11.

That would be compatible with the Semantic Versioning approach, which is more or less a de facto standard nowadays.

I used the latest version, but unfortunately it only supports jdk11, so I returned 6.2.2.


Make network restart non blocking for OSx and use <IP_ADDRESS> as nameserver

Right now, we are blocking the start in case of a mac host is not able to reach to the network
after network restart. If a host offline then it will block start forever which we don't want.
In current logic if a host is initially connected to vpn and then network restart happen, that means host
now have a different nameserver than before and this test will fail.
Making it non blocking allow us to overcome both the situation without much compromise.
In case of a host connected to vpn restart of network going to change the host nameserver and that will surely fail to ping the previous stored nameservers. If we are changing it to a well known nameserver at least 90% case it will succeed, going to fail only if a organisation block icmp from this nameserver.

In the log, I'd have a preference for using "fatal", "will not start", "will fail to start" rather than "blocking"/"non-blocking" which I associate with "we are going to start a go routine to handle network restarts"

Thinking some more about this issue, I would deal with it this way https://github.com/cfergeau/crc/commits/issue328
Go back to try to ping the nameservers from /etc/resolv.conf after the network has been restarted as was done before commit 5419bb458c. As /etc/resolv.conf can be temporarily missing during network restarts, we need to try a few times to read it before giving up.
With that done, if there are still some situations when waitForNetwork() can fail, then we can just ignore its error, ie add this on top of that branch above:
diff --git a/pkg/crc/services/dns/dns_darwin.go b/pkg/crc/services/dns/dns_darwin.go
index b79517d..30e56cc 100644
--- a/pkg/crc/services/dns/dns_darwin.go
+++ b/pkg/crc/services/dns/dns_darwin.go
@@ -96,7 +96,9 @@ func restartNetwork() error {
                }
        }

-       return waitForNetwork()
+       waitForNetwork()
+
+       return nil
 }

 // Wait for Network wait till the network is up, since it is required to resolve external dnsquery

@cfergeau @gbraad After giving it more thought, why we even need to check if network is started or not? We anyway have to support offline use case where it doesn't even matter. Can't we just get rid of that waitforNetwork() ?

dns.go needs to read values from /etc/resolv.conf to copy them to the VM after calling runPostStartForOS so we need the network to be done restarting when we get there, or we might have the same issue with /etc/resolv.conf being missing.

dns.go needs to read values from /etc/resolv.conf to copy them to the VM after calling runPostStartForOS so we need the network to be done restarting when we get there, or we might have the same issue with /etc/resolv.conf being missing.

@cfergeau we don't copy the host /etc/resolv.conf to the VM, what we do is read the VM's /etc/resolv.conf and add the internal dnsmasq nameserver to it and update that resolv.conf file.


Usage with MPI

Would it be possible to use an Arrow table with MPI communication primitives? Could we use MPI broadcasting for example to move an Arrow table around processes?

Theoretically....yes? I'm not very familiar with MPI or how it communicates things between processes. But essentially you can always do Arrow.Table(::Vector{UInt8}) where the byte vector points to valid arrow memory. So if you were to Arrow.write("data.arrow", ...) some data, then you could do Arrow.Table("data.arrow") from multiple processes and they'll all point to the same mmapped arrow data, for one example. If MPI has a way to move a blob of bytes between processes, then this should be possible. One example of doing this in memory would be something like:
io = IOBuffer()
Arrow.write(io, data)
seekstart(io)
MPI.sendbytes(another_process, read(io))
# from other process
received_bytes = MPI.receivebytes(other_process)
tbl = Arrow.Table(received_bytes)

Thanks for your reponse!
MPI does let you communicate bytes between processes so I actually think something like your example would work.

io = IOBuffer()
Arrow.write(io, data)
seekstart(io)

This would not be zero-copy, right?

tbl = Arrow.Table(received_bytes)

But would this be?
I'm thinking about how distributed shuffles could be implemented with MPI + Arrow and trying to understand if performance would be comparable to implementation using other Arrow-based work like Ballista and Arrow IPC.

When you do Arrow.write(::IOBuffer, ...), it's writing the arrow data in the IPC format into the IOBuffer, which will grow it's internal Vector{UInt8} in order to fit the data. To then avoid an additional copy, we could do view(io.data, 1:io.ptr-1)) to send the bytes to another process. You're correct that Arrow.Table(received_bytes) is zero-copy; the returned Arrow.Table object is just a "view" into the input byte vector interpreting the data.
I'm not familiar with what "distributed shuffles" means.

Thanks for your help.
By distributed shuffle, I mean doing doing an all-to-all communication like what is required for hash joins for example.
It seems like implementing a shuffle should be possible using MPI.jl and Arrow.jl. MPI.jl provides an Alltoallv! for communicating Array{UInt8}s (they also support communicating Ptrs or Refs interestingly...). These buffers can be converted to and from Arrow.Tables using Arrow.write and Arrow.Table constructor. And the actual splitting/concatenating of tables (for example for a hash join) can be done through the DataFrame interface.
The only part I'm unsure about is whether I should be communicating Array{Uint8}s or Ptrs..

Yeah, it'd be worth looking into what actually gets passed around; if they have a way of safely sharing Ptrs between processes, then that's probably pretty efficient as opposed to sending entire Vector{UInt8} over the wire. Going to close for now as I don't think there's anything to be done in Arrow.jl; but feel free to comment if you run into any issues or if you think there's something that coudl be easier here.

Thanks for your help here! I'll let you know how it goes.


Alpine mirrors support

In my country, install packages from alpinelinux.org are very slow, usually we use mirrors for speed. How about support set mirror url by Environment Variables?
https://github.com/jlesage/docker-baseimage-gui/blob/a246245ad6e7a76a0083fb2218faa15f8b5d870b/README.md?plain=1#L159
https://github.com/jlesage/docker-baseimage-gui/blob/a246245ad6e7a76a0083fb2218faa15f8b5d870b/rootfs/etc/cont-init.d/10-cjk-font.sh#L13

Ok, I will try to see if this can be implemented in a generic way, to support all baseimage types.

We can check if a env is empty, and if it is, do nothing.
I use it in a Dockerfile to change it.
ENV APT_MIRROR="mirrors.xxx.com"

RUN sed -i "s/deb.debian.org/${APT_MIRROR}/g" /etc/apt/sources.list \
&&  sed -i "s/security.debian.org/${APT_MIRROR}/g" /etc/apt/sources.list \
&&  sed -i "s/archive.ubuntu.com/${APT_MIRROR}/g" /etc/apt/sources.list \
&&  sed -i "s/security.ubuntu.com/${APT_MIRROR}/g" /etc/apt/sources.list \
&&  apt-get update && apt-get install -y --no-install-recommends curl \
&&  rm -rf /var/lib/apt/lists/*

Ok, I will try to see if this can be implemented in a generic way, to support all baseimage types.

This is now implemented via the PACKAGES_MIRROR environment variable.


missing whitespace for file with BOM(UTF-8)

Bug Report

4.5.1:
2.2.2:
Node.js API

TypeScript code being linted
[BOM]import * as $t from 't';

with tslint.json configuration:
"whitespace": [
      true,
      "check-branch",
      "check-decl",
      "check-operator",
      "check-module",
      "check-separator",
      "check-type",
      "check-typecast"
    ]

Actual behavior
.ts[1, 2]: missing whitespace
Expected behavior
No error

I have a similar issue with UTF-8 + BOM encoded files and tslint.json configuration:
"align": [
    true,
    "statements"
]

Actual behaviour
.ts[2, 1]: statements are not aligned
.ts[3, 1]: statements are not aligned
etc.
(reported for every statement in the file that is at the beginning of a line)
Expected behavior
No error

We have same whitespace issues with files having utf-8 with BOM encoding

We have the same problem with the whitespace rule, it's the "check-typecast" option that is the cause.
I think the problem is for everyone using Visual Studio (and maybe others).
We use tslint: 5.3.2 and TypeScript 2.3.3.

We are also having a similar issue with files that were edited in Visual Studio.  The files are in UTF8-BOM format.  With tslint 5.2.0 they lint without issue but with 5.3.2 we get a "missing whitespace" error on line [1,2] for every file.  If we edit the file to remove the BOM then tslint is happy again.  I seem to remember something like this happening before so this might be some sort or regression.

Is there any update on this issue?  As of 5.5.0 it still appears to be a problem.  Or if someone knows of a way to get Visual Studio 2017 to save without the BOM that would work too.