Invalid discriminant whilst choosing authentication method

when trying to log in via both mail and token, it gives an error: Found an Option discriminant that wasn't 0 or 1

What version are you using, and what platform?

I use windows I apologize for the long answer

and yes I am using 0.2.0

It took a while, but I got a Windows virtual machine setup. I downloaded the Windows asset from the v0.2.0 release and ran it, but I didn't encounter any issues. Could you please make a screen recording showing the bug?

Try setting the RUST_BACKTRACE environment variable to 1 and then run the program and send the result. If the syntax on Windows is like the syntax on unix based machines, then you can do that by running RUST_BACKTRACE=1 ./bonelab_mod_manager.exe in a terminal while in the directory containing the program. (You can use the dir command to navigate directories in a terminal on Windows, in case you aren't familiar, like dir ./Downloads.)

I don't quite understand if you could record a video or something like that

https://github.com/valentinegb/bonelab_mod_manager/assets/35977727/d1d3f1f1-96a6-420a-9e48-04e56b30f8c4
I'm not sure how helpful this'll be since I'm on macOS, but the process should be similar. You should replace cd in the video with dir.

dir Developer/bonelab_mod_manager/target/release/ writing this in windows powershell throws a dir error: Cannot find the path "C :\Users\KUVYLDA\Developer\bonelab _ mod _ manager\target\release" because it does not exist.
line: 1 character: 1

dir Developer/bonelab_mod_manager/target/release/

CategoryInfo          : ObjectNotFound: (C:\Users\КУВЫЛД...target\release:String) [Get-ChildItem], ItemNotFoundException
FullyQualifiedErrorId: PathNotFound, Microsoft.PowerShell.Commands.GetChildItemCommand maybe I'm not writing it there?

The path I went to in the video is the path to my installation, but it isn't the same as yours. You need to go to the directory that contains your bonelab_mod_manager.exe file.

I have this file in downloads

Then you would probably type something like dir Downloads

i must write dir downloads/bonelab_mod_manager/target/release? but when i make the same mistake

and then? I did it yesterday but I can't change anything there

Then try running RUST_BACKTRACE=1 ./bonelab_mod_manager.exe and use the program as you would to produce the error you reported

PS C:\Users\КУВЫЛДА> RUST_BACKTRACE=1 ./bonelab_mod_manager.exe
RUST_BACKTRACE=1: The name "RUST_BACKTRACE=1" is not recognized as the name of the cmdlet, function, script file, or program being executed. Verify that the name is spelled correctly and that the path exists and is correct, and then try again.
line: 1 character: 1

RUST_BACKTRACE=1 ./bonelab_mod_manager.exe

CategoryInfo          : ObjectNotFound: (RUST_BACKTRACE=1:String) [], CommandNotFoundException
FullyQualifiedErrorId : CommandNotFoundException

Okay, try setx RUST_BACKTRACE "1" and then ./bonelab_mod_manager.exe

gives it away

PS C:\Users\КУВЫЛДА> RUST_BACKTRACE=1 ./bonelab_mod_manager.exe RUST_BACKTRACE=1: имя "RUST_BACKTRACE=1" не распознается как имя выполняемого командлета, функции, файла сценария или программы. Убедитесь, что имя написано правильно и что путь существует и является правильным, а затем повторите попытку. строка: 1 символ: 1

RUST_BACKTRACE=1 ./bonelab_mod_manager.exe

Информация о категории: ObjectNotFound: (RUST_BACKTRACE=1:String) [], исключение CommandNotFoundException
Ошибка с полным правом : исключение CommandNotFoundException

ok

PS C :\Users\SOMERSAULT > setx RUST_BACKTRACE "1"
Success. The specified value is saved.

and about the second the same

PS C:\Users\КУВЫЛДА> RUST_BACKTRACE=1 ./bonelab_mod_manager.exe RUST_BACKTRACE=1: имя "RUST_BACKTRACE=1" не распознается как имя выполняемого командлета, функции, файла сценария или программы. Убедитесь, что имя написано правильно и что путь существует и является правильным, а затем повторите попытку. строка: 1 символ: 1

RUST_BACKTRACE=1 ./bonelab_mod_manager.exe

Информация о категории: ObjectNotFound: (RUST_BACKTRACE=1:String) [], исключение CommandNotFoundException
Ошибка с полным правом : исключение CommandNotFoundException

but the application has the same error

Don't run RUST_BACKTRACE=1 ./bonelab_mod_manager.exe, just ./bonelab_mod_manager.exe

just ./bonelab_mod_manager.exe after dir downloads just I can't do it

What's the output of echo %RUST_BACKTRACE%?

PS C:\Users\КУВЫЛДА> echo %RUST_BACKTRACE%
%RUST_BACKTRACE%
PS C:\Users\КУВЫЛДА>

What about echo $Env:RUST_BACKTRACE?

PS C:\Users\КУВЫЛДА> echo $Env:RUST_BACKTRACE
PS C:\Users\КУВЫЛДА>

Try setx RUST_BACKTRACE "1" & echo $Env:RUST_BACKTRACE

PS C :\Users\SOMERSAULT > setx RUST_BACKTRACE "1"
Success. The specified value is saved.
PS C :\Users\SOMERSAULT > echo $ Env: RUST _ BACKTRACE

setx RUST_BACKTRACE "1" & echo $Env:RUST_BACKTRACE is meant to be executed exactly as it is on one line

PS C:\Users\КУВЫЛДА> setx RUST_BACKTRACE "1" & echo $Env:RUST_BACKTRACE
строка:1 знак:25

setx RUST_BACKTRACE "1" & echo $Env:RUST_BACKTRACE

                    ~

Амперсанд (&) не разрешен. Оператор & зарезервирован для будущих версий. Добавьте двойные кавычки до и после амперсанда ("&"), чтобы передать его как строку.
+ CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : AmpersandNotAllowed

Alright, at this point I'm giving up on trying to debug this lol, clearly I don't know enough about Windows to be able to
What you should try to do to fix this issue for yourself is navigate to %AppData% and delete the folder called bonelab_mod_manager, then the next time you run the program it will recreate the folder

I will try

should I close the problem?

lol

this was all that had to be done

thank you

Don't worry about closing the issue, just let me know if you get it working or not and I'll handle it accordingly
Yeah- I'm sorry it took so long to get to this point, my goal was to find out what exactly was wrong so I could fix the code and prevent it from happening again, but oh well

Oh you already closed it lol, that's fine


The target “Gloss” contains source code developed with an earlier version of Swift.

When I use
pod 'Gloss', '~> 1.1'
to integrate Gloss into my project. When I do so, I get the "Convert to current Swift Syntax" message. My project is Swift 3.0. Should't the pod be downloading from the Swift 3.0 branch?

By any chance, do you have a post install script which forcefully sets swift version on pods?
If you do:

pod deintegrate
update your cocoapods version
go to your project and set your project target swift version to Unspecified
remove the post install script from your pod file
pod install

I actually got it all working. Seemed to be a cocoapods issue. Thank you.
FGR

On Dec 31, 2016, at 8:45 AM, Hesham Salman<EMAIL_ADDRESS>wrote:
By any chance, do you have a post install script which forcefully sets swift version on pods?
If you do:
pod deintegrate
update your cocoapods version
go to your project and set your project target swift version to Unspecified
remove the post install script from your pod file
pod install
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Articles break in Pocket

If you try to save http://www.gwern.net/Causality, Pocket will only save the quotes from the appendix. Haven't tried it elsewhere, but it's possible this will also be a problem for screenreaders and other parsers.
I suspect this is because the site isn't using article or header tags anywhere. For example, you have:

Why Correlation Usually ≠ Causation: Causal Nets Cause Common Confounding

There's no way for Pocket (or any parser) to know that this is actually the header of the article, rather than, say, an unrelated sidebar. This is compounded because you're using repeated h1 tags, so even naive document outline parsing won't help (it's totally valid to use multiple h1 tags, but not many browsers, screenreaders, etc... actually pay attention to that part of the spec)
I'm not completely sure, but if you switched from
 to ,
 to , and
 to
, that might be all you need to get everything working.

For the most part, I am using Pandoc's defaults, and the repeated h1 tags are simply # headers.
As far as the edits go, I'm concerned about it breaking the CSS. I style all of main/header/content a fair bit, and your suggested edits seem to break it. Using these changes:
diff --git a/static/css/default.css b/static/css/default.css
index 40cb6c3..dc7e8a7 100644
--- a/static/css/default.css
+++ b/static/css/default.css
@@ -16,11 +16,11 @@
         line-height: 150%; /* see A/B tests */
     }

-    #header {
+    header {
         margin-bottom: 15px;
     }

-    div#main {
+    main {
         margin-left: 0.5em;
         margin-right: 0.5em;
         border: none;
@@ -103,7 +103,7 @@
 /* Apparently, setting “overflow” on an element creates a new formatting context which fixes this. “overflow: hidden” will do this witho
ut actually changing how overflow is handled. Unfortunately, if we do that, the bullet points and numbering inexplicably disappear and we
 have to move them “inside”. Once we fix that,

…

 creates two new block contexts, causing blank lines on some bullet point
s on pages like this. */
 /* Note that I’m only messing with non-section children of sections and list elements (not the lists themselves). This is because I’m as
suming you want paragraphs and lists to wrap around the TOC" */
 /* result: http://imgur.com/lhvneyP */
-div#content>:not(section), div#content section>:not(section) {
+article>:not(section), article section>:not(section) {
     overflow: auto;
 }

@@ -126,7 +126,7 @@ body {
     max-width: 1600px;
 }

-div#header h1 {
+header h1 {
     text-align: center;
     vertical-align: middle;
 }
@@ -157,7 +157,7 @@ div#disqus_thread { padding-left: 0.5em; }
 a {
     color: #303C3C; /* off-black */
 }
-div#content a { word-wrap: break-word; /* force the occasional inline URL or other long word to break at max-width */
+article a { word-wrap: break-word; /* force the occasional inline URL or other long word to break at max-width */
                  text-decoration: none;
 }

diff --git a/static/templates/default.html b/static/templates/default.html
index 8910164..0f53c57 100644
--- a/static/templates/default.html
+++ b/static/templates/default.html
@@ -20,7 +20,7 @@

-

+

@@ -74,11 +74,11 @@
         </script>

-

+

$title$

-

+

-

+

         Please enable JavaScript for math equation rendering.

@@ -91,8 +91,8 @@

         $body$

-

-

+

+

Still bored? Then try my Google+ news feed.

and syncing produces the following brokenness with stuff overflowing everywhere:

(Web development is a bitter mystery.)

When I make the same changes locally, I'm not seeing any issues. The overflow you're seeing is roughly consistent with what I see if I make the HTML changes locally but don't apply any of your CSS changes. Off the top of my head could be a caching issue, but if that's the case I'm surprised you haven't run into it before.
Depending on how much you actually want a solution, you could also fall back on aria roles:

 becomes
, and so on with the other elements. This would allow you to add the semantics without changing your actual CSS, since all of the selectors, ids, and elements themselves would remain untouched.
It's not generally recommended to use aria roles this way, but at the same time... nobody other than people like me will ever actually notice or call you out on it, and I don't know where you live so what do you care? :)
The other thing to note is that I'm really just guessing that this will solve the Pocket issue; I'm working under the assumption that they pay attention to HTML semantics and correctly parse repeated h1 tags per the official HTML specs. That's not a universal guarantee. If nothing else this will certainly make it easier for other web scrapers to identify main content, metadata, and keywords, and it should in theory make screen readers work better.
How much that matters? I assume you know your target audience better than I do.

Hm. Caching is a possibility. I did force reload but that might've not cleared out the Cloudflare cache of the CSS. I have run into issues where that has confused me in the past. I'll try remaking those changes and emptying the CF cache and check that an updated version is being served.

Yes, looks like it was stale CSS. I've redid the changes, checked in the W3C Validator & tidy, synced, flushed the CF cache, and looked around, and it seems like those changes haven't broken anything or made it invalid HTML5. Can you check if it fixes your Pocket app?

Heh, close. It catches the article tag, but still reverse parses it and grabs just the one h1. This isn't your fault, using multiple h1 tags in a single page is valid, especially when they're nested under sections.
I'll file a bug on their end, everything is fine on yours. Thanks for taking the time to look at it!

Great. Then I'll commit that change & close this.


Create Tiramissu

fixed #4

THank you very much - looks good, just some checks flagged up the instructions missing a "#", could you fix that please, thanks!


Fix explanation of boost queries seeking beyond query result.

Closes #2137

Codecov Report

Merging #2142 (ad3e1cd) into main (b92082b) will increase coverage by 0.00%.
The diff coverage is 77.77%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #2142   +/-   ##
=======================================
  Coverage   94.35%   94.36%
=======================================
  Files         320      320
  Lines       61527    61515   -12
=======================================
- Hits        58053    58046    -7
+ Misses       3474     3469    -5

Files Changed
Coverage Δ

query-grammar/src/query_grammar.rs
97.95% <33.33%> (+0.14%)
:arrow_up:

bitpacker/src/blocked_bitpacker.rs
87.60% <100.00%> (-0.21%)
:arrow_down:

src/core/json_utils.rs
99.58% <100.00%> (ø)

src/query/boolean_query/boolean_weight.rs
93.50% <100.00%> (ø)

src/query/boost_query.rs
73.17% <100.00%> (-0.09%)
:arrow_down:

... and 2 files with indirect coverage changes

Thank you!

Thanks for the fix. Any idea when will this be released in the next Tantivy version?


WIP Webpack

This is a WIP PR to switch to bundling with webpack. Modules are imported using requires instead of  just reading global variables. Cycles in the dependency graph are broken up.
Progress
Use requires in all files instead of globals
Switch off globals in eslint
Use context.require to require all files in main entry point
Resolve circular dep message_list_view → rows → message_store
Require jquery in blueslip
Extend jquery with expectOne function from setup.js
Add this extended jquery as requires in the files that use it using ProvidePlugin
Currently stuck on
subs.js requires stream_color.js
stream_color.js has one function that calls subs.js,

    function picker_do_change_color(color) {
        var stream_id = $(this).attr('stream_id');
        var hex_color = color.toHexString();
        subs.set_color(stream_id, hex_color);
    }
    subscriptions_table_colorpicker_options.change = picker_do_change_color;

Automated message from Dropbox CLA bot
@arpith, it looks like you've already signed the Dropbox CLA. Thanks!

For the circular dependency with stream_color.js, I think we want to clean that up that in a separate commit before we do this big one, and we can have a callback mechanism..  I'll post a PR that sketches it out.

Totally agreed we should fix the circular dependencies on preparatory branches that we can just merge now.

The ui.js one should be safe to merge right now, though can you also do that same work for the other modules we apparently don't have this setup properly for?  Then we can merge that whole piece and simplify what remains in this PR.
$ git grep --files-without-match 'typeof module' static/js/*.js
static/js/api.js
static/js/blueslip.js
static/js/compose.js
static/js/debug.js
static/js/message_edit.js
static/js/popovers.js
static/js/scroll_bar.js
static/js/setup.js
static/js/signup.js
static/js/src/main.js
static/js/viewport.js

Thanks @showell :)
@timabbott I've created https://github.com/zulip/zulip/pull/2979 for the missing exports.

Closing this, since while it's a useful reference, we're unlikely to merge it directly given the amount of churn since then :).


Move experimentation report from post-processor to reporting-worker

To-Do:

Experimentation reporting related logic should be moved from post-processor to reporting-worker
Have two separate schedules for audits & reports:

Audits should be daily
Reports should be weekly

This is completed - https://github.com/adobe/spacecat-reporting-worker/pull/4


Plant 2 million Trees with our NFT'S!

We have a new project focused on reforestation efforts.
Unearthed Designs plans on having a 6 piece collection of NFT'S that will fund our reforestation efforts. Purchase 2,500, 4,000, 10,000, 14,000, 23,000, or 52,000 Trees per NFT. This will greatly reduce our carbon footprint, and bridge the gap between Blockchain and forest restoration. Once we reach our 2 million Tree goal the remainder of the first collection will be burned locking in the amount of each one available. A second collection will be minted to support our next goal of 10 Million trees with our NFTS. Over time we would like to expand into even more humanitarian efforts driven by blockchain utilities. With the help of our partnerships we plan on planting trees in countries all over the world and becoming a major contributor in worldwide reforestation and ecological restoration efforts. Here is a link to our website, Https://uneartheddesignsllc.com We look forward to gaining an abundant amount of partners and contributors and would love to have you along for the ride.
Thank you - Andy

Hi Andy, Web3 Foundation doesn’t partner with any project and since this issue is unrelated to our grants program or our ecosystem, I’m going to close it. Please don’t use this repository, for advertising purposes.


A solution on how to embed Kyma extensions in Busola

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)
Closes #1860

/test all

/retest

/test all

/retest

/retest


feat(extractors/services): Add support for fail2ban

Hi There.
I wasn't sure whether or how to include the “ban time increments” string.
Should I have put it in info instead of details.listen.text?
Or should I have gotten rid of it altogether?

Thank you


python3Packages.spglib: 1.12.1.post0 -> 1.14.1.post0

Motivation for this change
fix seekpath build
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @
[13 built, 17 copied (171.3 MiB), 70.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73899
13 package were built:
python27Packages.seekpath python27Packages.spglib python37Packages.boltztrap2 python37Packages.dftfit python37Packages.lammps-cython python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.seekpath python37Packages.spglib python37Packages.sumo python38Packages.boltztrap2 python38Packages.seekpath python38Packages.spglib

@GrahamcOfBorg build python27Packages.seekpath python27Packages.spglib python37Packages.boltztrap2 python37Packages.dftfit python37Packages.lammps-cython python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.seekpath python37Packages.spglib python37Packages.sumo python38Packages.boltztrap2 python38Packages.seekpath python38Packages.spglib

aarch failure due to sumo package not compatible
darwin failed due to known sqlalchemy failure


CPU profiling Memory and CPU overhead

I have done some internal workloads to analyze system level CPU and memory impact while doing CPU profiling.

Java stack depth and profiling sample count has significant impact on CPU, the overhead range observed  between 0.8% to 5.6%.
What seems to be concerning is Memory usage, in a 64G host, the Memory usage increased to 8 to 9%, which is ~5G.  I am analyzing this.
But meanwhile, let me know if any analysis is already carried out on Memory usage during CPU profiling.

I have also done Memory profiling for same workload.

The CPU and Memory overhead is much higher with Memory profiling.

Dumping call tree can take huge amount of memory. I suggest you measure with "summary" output format.

I have done these tests with flat,traces output  format.

ОК. I would suspect the memory is taken by jmethodIDs, JIT symbols or NativeCodeCaches. Haven't analyzed this yet.
How do you measure memory utilization?

using /proc/meminfo
%Memory Used:  100*(MemTotal - MemFree - Buffers - Cached)/MemTotal

BTW, there is already an issue #14 for overhead related discussion.

I'll close this one and leave #14 open for further discussion on profiler overhead.


Update endpoint synopsis: Add international standing order apis

Description

Add Here the international standing order endpoints documentation.

Acceptance criteria

[ ] The endpoint synopsis has been updated with international standing order apis endpoints documentation.

Hey team! Please add your planning poker estimate with Zenhub @frlaura-jianu @mariantiris


Re ordering not happening

I installed the django-modeladmin-reorder using pip. Included admin_reorder in my INSTALLED_APPS and also 'admin_reorder.middleware.ModelAdminReorder' to my MIDDLEWARE_CLASSES.  Below is my ADMIN_REORDER section
ADMIN_REORDER = (
    # Other
    {
        'app': 'auth',
        'label': 'Authentication and Authorization',
        'models': ('auth.Group', 'auth.User', )
    },
    {
        'app': 'other',
        'label': 'Payments',
        'models': ('other.Currency', 'other.ExchangeRate', 'other.PaymentMethod', )
    },
    {
        'app': 'other',
        'label': 'POS Management',
        'models': ('other.DeviceInfo', 'other.Environment', )
    },
    {
        'app': 'other',
        'label': 'Reason Codes',
        'models': ('other.ReasonCodeCategory', 'other.ReasonCode')
    }

)

This doesnot give the desired output. Where am I going wrong ?

What do you mean by "does not give the desired output"? Can you provide a screenshot? Have you checked your app name i.e is is called other?

Have attached the screenshot. Yes I am sure about the app name. It is 'other' . I am using django 1.8 and also a django-material library. Will it be a problem ?

I've never used django-material before.  Can you try removing material.admin from INSTALLED_APPS and try using vanilla Django admin .. to see if the problem persists?

Yes I did try. Now it works. But I would want it with material. Do I have to put 'admin_reorder' in any specific place so that it works?

I'm sorry but I don't know how django-material works... and I simply don't have the time to investigate.  django-modeladmin-reorder simply modifies/reorders view context via a middleware... maybe you can debug it by using django debug toolbar.  Good luck.


Keeping focus in composer when pin button is pressed

Details
Keeping focus in composer when pin button is pressed
Fixed Issues

$ https://github.com/Expensify/App/issues/18534
PROPOSAL: https://github.com/Expensify/App/issues/18534#issuecomment-1538967283
Tests

Go to any chat
Make sure focus is in composer
Press pin/unpin button
Make sure focus is still in composer

[x] Verify that no errors appear in the JS console

Offline tests
Same as above(tests)
QA Steps

Go to any chat
Make sure focus is in composer
Press pin/unpin button
Make sure focus is still in composer

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/59907218/ad58f3f9-ccb8-432b-a8e5-5d3423419f91

Mobile Web - Chrome

https://github.com/Expensify/App/assets/59907218/9f468277-0e07-4c1d-9957-ce313d84422b

Mobile Web - Safari
https://github.com/Expensify/App/assets/59907218/dae7ee4f-e6ae-43d9-8c77-47f6857cba1b

Desktop

https://github.com/Expensify/App/assets/59907218/5349af8a-c948-4e68-b0bb-2a7fb22381f6

iOS
https://github.com/Expensify/App/assets/59907218/bd53b752-76c0-4fce-8140-b9606f75f53a

Android
https://github.com/Expensify/App/assets/59907218/556d22f3-5c8d-4280-ab9f-cae1ae71b094

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/16493223/3af18c67-8f98-4556-b1ab-d7326939d6d5

Mobile Web - Chrome

https://github.com/Expensify/App/assets/16493223/b07e2c98-b37c-4665-bf66-1bb0bdddfb57

Mobile Web - Safari

https://github.com/Expensify/App/assets/16493223/15e08ec2-b673-4a1e-bc9f-2a150f5ff0d7

Desktop

https://github.com/Expensify/App/assets/16493223/4b1ed8ae-c912-479c-9fc6-9861046452a2

iOS

https://github.com/Expensify/App/assets/16493223/6fb0e0fb-0eb9-4299-9001-561485ef6f05

Android

https://github.com/Expensify/App/assets/16493223/0e8fd3b4-fbbc-4089-9dea-d969cfbea1a8

Ok so I'd like to move forward with this PR, but first can y'all test to see if https://github.com/Expensify/App/issues/17538 is still reproducible?
Since we're touchin the Pin button in this PR and we technically don't want to change anything related to https://github.com/Expensify/App/issues/17538, I want to make sure we're not changing anything OTHER than what we want in this PR. Does that make sense?

It's still reproducible. But it will be fixed with this PR.

@s77rt so just to be clear, if this PR does change behavior that we decided not to change in https://github.com/Expensify/App/issues/17538: I think we need to open a slack discussion

@Beamanator Sure, here asked on Slack.

Closing b/c we decided we don't want to implement this.
Discussing compensation in the issue.


Troubleshooting

I've got an ESP8266 (NodeMCU v3 CH340 https://www.amazon.com/gp/product/B09F8GCVC8/ref=ppx_yo_dt_b_asin_title_o03_s00?ie=UTF8&th=1)  with some WS2812B RGBNW and for some reason its just not doing anything. Logs don't say much https://pastebin.com/P0qma9DR. I know the LEDs work (tested them with ESPHome).
I flashed it successfully. I've tried different USBs to connect from the Pi to the NodeMCU and connected them to Gpio 2 (D4). I am at a complete loss. It sees the device but I don't know what I'm doing wrong.
Suggestions?

Hi
Always provide full logs not just a part of it: don't see an issue here. Install v19beta2 from the release section and use 'esp32/esp8266 handshake' and provide logs again. Or you can compile the firmware online for 921600 already as fake ch340 is the most suspected reason. You can find manual here in the wiki.


Add a way to specify arbitrary query parameters

Add a way to specify query parameters by name and string value. This is intended as an untyped, low-level accessors to bypass limitations of the Query class (e.g. unsupported parameters).
Note: this is a backport of a feature already implemented in the upcoming v3 of the Swift client.
Remark: Solving this issue would automatically fix #23 and #24.

Our entire implementation is in obj-c. We have a need to set minimumAroundRadius, but we are stuck as we are not finding any docs to set this in obj-c. Can you please help guide us how to set this in obj-c.


EfficientDet models are unable to load None weights

This fails:
model  =  EFFICIENTDETD2(base_weights=None, head_weights=None)

This was fixed here https://github.com/oarriaga/paz/pull/294


Assignment unwrapping fails when return args are involved

This will crash at runtime:
use sam-assert

Ditto: class {
    s: String
    init: func (=s)

    operator + (other: This) -> This {
        new(s + other s)
    }
}

Container: class {
    ditto := Ditto new("john")
    init: func
}

Peeker: class {
    inner: Object
    init: func (=inner)
    peek: func <T> (T: Class) -> T { inner }
}

describe("should unwrap += correctly even with returnArgs", ||
    c := Container new()
    p := Peeker new(c)

    // forced to unwrap, only has '+' operator
    p peek(Container) ditto += Ditto new(" doe")

    expect("john doe", c ditto s)
)

Because:
p peek(Container) ditto += Ditto new(" doe")

Is turned into:
p peek(Container) ditto = p peek(Container) ditto + Ditto new(" doe")

But really, what happens is that
p peek(Container) ditto += Ditto new(" doe")

Is turned into: (mix of C & ooc syntax.. (a, b, c) is a comma sequence - executes all statements, evaluates to last element)
tmp: Container
(p peek(Container, tmp&), tmp) ditto += Ditto new(" doe")

And then unwrapped, since Ditto only has a + operator, but somehow it's the commaSequence that's being cloned, and FunctionCall doesn't clone its returnArgs, so it ends up looking like:
tmp: Container
(p peek(Container, tmp&), tmp) ditto = (p peek(Container, NULL), tmp) ditto + Ditto new(" doe")

And obviously that crashes, not when calling the rhs peek (it'll happily write nothing if returnArg is NULL) but when trying to access "ditto" from it (since, you know, it's null).

So, since we can't really tell the FunctionCall in advance that it's going to be cloned at some point so we can unwrap an assignment... the "fix" is to let CommaSequence know where it comes from, so that when a CommaSequence is cloned, if it comes from an unwrapped FunctionCall, it returns a clone of that instead, leaving it a chance to unwrap again, in the new context.
Thus:
p peek(Container) ditto += Ditto new(" doe")

Is turned into (mix of C & ooc)
tmp1, tmp2: Container
(p peek(Container, tmp1&), tmp1) ditto = (p peek(Container, tmp2&), tmp2) + Ditto new(" doe")

And even though that's really wasteful, at least it's correct.


Moving to psychic.css from psychic-ui

LGTM @anusaini, let me merge and publish a new version! 😄

released in https://github.com/gabrielcsapo/build.sh/releases/tag/0.2.8 😄


build improvements

TODO:

maybe imagebuild.sh should use make container as well test this

@yamt Is this ready for merge or do you want to complete that TODO first?

@marun either way works for me

Thanks @yamt,
/lgtm

lgtm

/approve


Change default port

PufferPanel is using local port 8080 by default. Since something else on my infrastructure are using this port is there a way to change that 8080 to something else? For eg. 8082. If not it would be great to add option to do that.

Please use our Discord (https://discord.gg/v8dz49e) for issues, questions, or help with installation or configuration of PufferPanel.


Bootcamp first layout

Motivation and context

Screenshots:

Before
After

[before screenshot]
[after screenshot]

Testing

New environment variables:

env var : env var details

New dependencies:

dependency : dependency details

New dev dependencies:

dependency : dependency details

![image](https://user-images.githubusercontent.com/67734870/157532660-e84a6e7a-a506-4a2a-b5c3-9131


Double backup

Fixes https://github.com/keras-team/keras/issues/20463

The only point I doubt is the type of exception. In my issue it is OSError. But possibly we should use something more general.

Codecov Report
Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 59.88%. Comparing base (ccb07df) to head (785af6b).

Files with missing lines
Patch %
Lines

keras/src/callbacks/backup_and_restore.py
16.66%
15 Missing :warning:

keras/src/utils/file_utils.py
16.66%
5 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (ccb07df) and HEAD (785af6b). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (ccb07df)
HEAD (785af6b)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20465       +/-   ##
===========================================
- Coverage   82.03%   59.88%   -22.16%
===========================================
  Files         515      515
  Lines       47346    47370       +24
  Branches     7427     7434        +7
===========================================
- Hits        38842    28367    -10475
- Misses       6705    17256    +10551
+ Partials     1799     1747       -52

Flag
Coverage Δ

keras
59.88% <16.66%> (-22.01%)
:arrow_down:

keras-jax
?

keras-numpy
59.88% <16.66%> (-0.03%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bump dependencies to allow for Laravel 9

Goal
to allow for Laravel 9

Testing
ran tests, all pass

hey @jdanino - thanks for getting started on this. We're planning to add support for the Laravel 9 release. We'll keep the thread over at https://github.com/bugsnag/bugsnag-laravel/issues/469 updated with progress. 👍

Thanks for the PR, @jdanino!
This ended up with a conflict in the composer JSON, so I've rebased it in #477


increased memory jenkins MEMORY_LIMIT default value to 3Gi

Increased default MEMORY_LIMIT value to "3Gi", nagios memory check is around 56% now.
ping @wei-lee

@odra can we make this configurable? The default can be 3Gi but really admin user should be able to specify the value.

@wei-lee should we add all parameters as ansible vars?

@odra what other parameters are you talking about?

Openshift template parameters: https://github.com/aerogear/digger-installer/blob/master/deploy-jenkins/tasks/main.yml#L19
Currently it's only using "enable_oauth" from the role vars, we are adding "memory_limit" now, should I add all parameters(volume size, etc) into the command as well?

@odra yeah, I think volume capacity should be parameterised as well.

@wei-lee  added volume capacity param as well.


is ti posible (Model) get tableName from view_table

i cant mixing 2 table from different database using Model,
so i think can if make some view_table..
I have made view_table of different 2 database, let say v_package
...
class ModPackage extends Model {
  static get tableName() {
    return "v_package";
  }
}
...
const Package = ModPackage.bindKnex(codes);

...
const mPackage = async () => {
  const sql = await Package.query()
    .select("packageid", "name", "navigation")
    .where("productid", "=", 1);
  return sql;
};
...

but why the response always null..?
{
  "data": {
    "mPackage": {
      "packageid": null,
      "name": null,
      "navigation": null
    }
  }
}

can u help me..

done


[Feature Request] - Lost characters

Is your feature request related to a problem? Please describe.
Someone gaves me a character already in my list and when I checked it, he was neither in mine and his.
Describe the solution you'd like
I would like to be able to stack duplicate character gained in trade.
Describe alternatives you've considered - optional
Gimme back my lost character :'(

It would mean verifying if the user has already got it, if the user has got it then the give is blocked. If it's not, then it's good to go.
Just reuse the "verify" function you implemented and place it before the DB rewrite.

There is no issue to having multiple time the same character as it is just stored as a mongo array,
I'll look deeper into the code, but as I see it there shouldn't be an issue like this with the current code, I may work more on this if it reiterates


Allow for fully-qualified assets via SingleAssetExit.AssetMetaData

This PR enables cross-chain accounting. IE,specifying assets across multiple EVM compatible distributed ledgers (Ethereum, Arbitrum, FVM, etc etc).
Questions:

in this PR, a singleAssetExit reverts when a qualified asset is not local to the executing contract. Should it fail silently instead? Case: executeExit will always revert when an outcome spans multiple asset holders. Countercase: silent failure seems pretty passive. Middle ground: emit some event and fail?
with this PR, assets are qualified at the singleAssetExit level. Is there a case for applying the same metadata to individual allocations instead of to the asset?

Future work:

this PR does not allow for fully qualified assets which are of type EIP-721 (nft) or EIP-1155 (multitoken standard). New combined types could be created to accommodate this. (eg, AssetType.Qualified721).

in this PR, a singleAssetExit reverts when a qualified asset is not local to the executing contract. Should it fail silently instead? Case: executeExit will always revert when an outcome spans multiple asset holders. Countercase: silent failure seems pretty passive. Middle ground: emit some event and fail?

I think silent "failure" is fine, and no need to emit an event. We should not revert for nonlocal assets, because this will prevent other local / valid assets from being paid out.

with this PR, assets are qualified at the singleAssetExit level. Is there a case for applying the same metadata to individual allocations instead of to the asset?

I think not. Qualifying it where you have fits nicely and preserves the "compression" effect of nesting similar assets together under the same metadata.

Another discussion point, for posterity:
We could choose to have all assets qualified by default, to remove the need for duplicated existing asset types with qualified versions.
The downsides seem to be a lack of backwards compatibility, and a greater gas burden for applications targeting a single chain only and therefore not requiring fully qualification. Those applications will need to be cognisant of our replay protection via channel nonce.
Side note -- with this change it would become safe to reuse a channel nonce on a separate chain, as long as the assets were always fully qualified correctly. But just because something is safe to do, it doesn't mean we would recommend it!


Hi could you please help me fix this error. I get it when I upgrade from 4.0.3 to any higher version.

I think it may be a particular game causing the issue.
Maybe PES C19?
Try removing that game from the psp folder and deleting this folder:
uxO:/data/RetroFlow/TITLES/
If that works, can you let me know the name of the game so I can try to create a fix please?

You were right, I had PES installed, but not with the Code ame ULUS****, In fact it had the full name, i remove that game and one of dragon ball, then I continued with the folder TITLES, install and it worked, thank you very much for your help, PES was the problem.


Question about the regularization added to the loss

Hi Authors,
I had a question about the implementation of the depth loss.
The depth calculated in the colmap depth loader  seems to be the z value of the point in camera frame, but the depth computed from the NeRF seems to be the distance of the point along the ray's direction.
What am I reading incorrectly here?

Both the depths are the z value of the point. Check the get_rays functions here. The ray directions are not given in unit length, but [x,y,-1] in the camera frame.

Thanks for the reply!
It indeed isn't unit length, but is built of the point [i/focal_length, -j/ focal_length, -1] which is equivalent to [i, -j, -focal_length], right?
That means the value of the summed z is in direction of the ray. Or did I miss something?

Given this definition of ray direction rd and ray origin ro, if a point is specified by p = ro + rd * z, z should be the distance along z-axis

I get it now, my understanding of z-vals and the distances were incorrect in the integration function. Thanks for taking out the time to explain this!


Feature: LexicalTypeaheadMenuPlugin not works with CodeHighlightPlugin

the Typeahead Menu would't be triggered if registered code highlight( registerCodeHighlighting(editor)).
I'm not sure if it's a bug or not, however hope this can be a feature.
thanks.

Same issue here. Any workaround ideas?


Adding Item Url option

Hi,
great job for you plugin !
It will be perfect i we will have the ability to create an item url on the table.  Have you plan to add this functionnality ?

Can you precise your need please?
Currently, in a computed column, you can define a template, and in template, you can set a url link.
For example :
{{value}}

No answer for more than 1 month ago, so I close the issue.


Add a conda build config for py 3.6, 3.7 and 3.8

This will make it easier to build all supported python versions in one go.

@xylar Thank you for the PR! We also would like to make zstash build noarch. Not sure how to edit the yml file, would you please help...Thanks a lot!

Ah, to make it noarch, you don't want the this PR at all.  I'll close and do noarch instead.  Give me an hour or so.  Off to a meeting...

@xylar That would be great! Thank you.


Enable spectest on riscv64

Test result : https://github.com/no1wudi/wasm-micro-runtime/actions/runs/7055453059

Latest spec test here: https://github.com/no1wudi/wasm-micro-runtime/actions/runs/7081980946


Self publish updates

Changes
CLI

build-static command added
ability to select assets folder from the list of available subfolders
ability to choose not to use assets folder
E2E adjustments

Content

enhanced frontpage self-publish and publish sections
enhanced self-publish tutorial

Couple of quick comments:

don't think you need the statement If you don't need a static build, run npx flowershow build. - it makes me as a user confused (what is a static build and why wouldn't i want one). In fact i wonder if we just have build-static be build for now (do we need the old build functionality on its own ever?)
also maybe show what happens when you do build-static like you do on screenshot above (?) - or at the very least show that it outputs a folder full of files perhaps with a link to instructions in our tutorial of how to publish these online (many users may not know what to do)

Browser metadata
Path:      /
Browser:   Opera 91.0.4516.65 on Mac OS 10.15.7
Viewport:  1400 x 801 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved


What is the difference between "Search" and "Quick Search"?

Beside the fact that "Quick Search" is broken.

Once it's working, quick search, if it finds a single match, will take you directly to the page of the part you are searching for. That's fine if you want just that part. However, say you want all parts with "3001"? Quick search will take you to parts/3001.dat, the search page will not and there needs to be a way to get to the search page without typing jibberish into the quick search box. Also, the search page has more search options as quick search's default will be "Filename and header".


Add animation group in the Babylon file loader

Update the Parse method for:

Bone => add the id
AnimationGroup => create the method

Update the babylon.babylonFileLoader.ts file for AnimationGroup

Can you revert the changes in dist folder?

I removed my last commit that made changes in the dist folder.


htaccess variables

Is there any way around using the htaccess variables for email setup

Yes, you have to edit sendmail.php and fill in any calls to #getEnv w/ the corresponding hard-coded values like in this gist: https://gist.github.com/jonmbake/0e5b175a72ad9ba64167.


PR merge test

This PR is testing if we can merge PRs into main. The only thing that has changed is the README.md file. No content was changed, only formatting, which was done with mdformat with the standard line length defined by black, and standardization of the markdown.
Motivation
Please describe your motivation for the changes. Provide link to any related issues.
Changes proposed
Outline the proposed changes and alternatives considered.
Test Plan
Please provide clear instructions on how the changes were verified. Attach screenshots if applicable.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] The title of my pull request is a short description of the requested changes.

Interestingly the tests that are failing are due to a gcc error in macOS and Windows. Will hunt these issues down.

closing as @zaxtax finished the fixes


Scuttle Logging cannot be disabled

Brief summary
Scuttle enables logging by default. This is problem because its logs end up in the initializer logs, causing the operator to be unable to unmarshal it into JSON. Adding scuttleLogging: false does not work though because the controller does not insert environment variables into the pod spec when their value evaluates to false. This applies to all boolean Scuttle parameters, but it's only a problem for scuttleLogging because default value in Scuttle is true.
Here is the offending line: https://github.com/grafana/k6-operator/blob/main/pkg/resources/jobs/helpers.go#L87
You can see that it checks for a value that evaluates to false instead of checking for the presence of the parameter. I've tested this with scuttleLogging and neverKillIstioOnFailure. When true, the environment variable is present. When false, they are not present. These, and other scuttle values, are defined as boolean in the CRD, which seems unnecessary since the values get converted to strings when inserted as pod environment variables and is one of the reasons this bug occurs.
k6-operator version or image
v0.0.9rc1, v0.0.8, v0.0.8rc3, v0.0.8rc2, v0.0.8rc1, v0.0.7, v0.0.7rc4, v0.0.7rc3, v0.0.7rc2, v0.0.7rc
K6 YAML
apiVersion: k6.io/v1alpha1
kind: K6
metadata:
  name: load-test
  namespace: k6-operator-system
spec:
  parallelism: 10
  runner:
    metadata:
      labels:
        sidecar.istio.io/inject: "true"
  scuttle:
    enabled: "true"
    envoyAdminApi: 'http://<IP_ADDRESS>:15000'
    istioQuitApi: 'http://<IP_ADDRESS>:15020'
    scuttleLogging: false
  script:
    configMap:
      name: test-cm
      file: test.js

Other environment details (if applicable)
Istio is installed.
Steps to reproduce the problem
On a cluster with Istio installed:

Create a test config map.
Create a K6 object with the following scuttle and runner settings:  runner:
    metadata:
      labels:
        sidecar.istio.io/inject: "true"
  scuttle:
    enabled: "true"
    scuttleLogging: false

Expected behaviour
SCUTTLE_LOGGING appears in the initializer pod spec under env with value "false".
Actual behaviour
SCUTTLE_LOGGING does not appear in the initializer pod spec.

Hi @cogren1, thank you for reporting this! I've added the fix for it here: #182.
I think this matter with logging was a bug since scutlle was added and just wasn't noticed before :disappointed: To avoid confusion with what this option means, I've renamed the setting itself to disableLogging -- that should be clear enough. This will be a breaking change for those who relied on scutlleLogging option (hopefully, not too many!) so I'll wait for feedback a bit before merging it.

Are there any news on this issue? :) The pull requests seem to be stuck at the moment..
Would love to use k6 in combination with Istio!

Hi @MerzMax, thanks for the ping! Yes actually, I think it can be merged now: nobody complained about breaking change so it should be fine :slightly_smiling_face:  I'll merge it in now.
Btw, there might be other changes to Istio setup once we get to #195

Fixed by https://github.com/grafana/k6-operator/pull/182


Gulp not working on io.js v.1.6

I want to use gulp in my project that uses io.js v.1.6.0 but when i try to run gulp i get an error
path.js:8
    throw new TypeError('Path must be a string. Received ' +
          ^
TypeError: Path must be a string. Received null
    at assertPath (path.js:8:11)
    at Object.posix.basename (path.js:560:3)
    at Liftoff.buildEnvironment

I tried re-installing gulp but with no success. Is this a known issue? I saw there was some issues with previous version of io.js https://github.com/gulpjs/gulp/issues/873 but i thought it was fixed.

gulp 3.8.11 and gulp 4.0 work fine for me with io.js 1.6 or 1.7

gulp 3.8.11 and gulp 4.0 work fine for me with io.js 1.6 or 1.7

:+1:  same here

2 people tested successfully - closing.


"Caching" - Support

Describe the feature you'd like to request
I'd like to be able to not run the optimization on images that have already been optimized before.
Describe the solution you'd like
Haven't looked in detail in the code yet so there might be a better approach, but I'd suggest adding 2 configuration parameters, "cache" (boolean) and "cachePath" (string). If cache is set to true, we save a file in the cachePath which is basically a list of the image path + name and it's related hash. This way we could check if an already cached image was changed if not, there is no need to rebuild it
Additional context
We are using this plugin at JetBrains right now to rebuild our blog. As you can imagine we have plenty of pictures and graphics and stuff, so optimizing the image takes roughly 6 minutes right now, every single time
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Hello, @niklas-wortmann and @pauleveritt, I apologize for not getting back earlier. I am amazed that JetBrains is employing my plugin! Let me address your questions:
a) It was in my backlog, but at that time, I didn't have the requirement for extensive image processing. Ideally, it would work similarly to how Prettier and ESLint cache functions, I believe.
b) Currently, I'm quite busy with work and won't be able to devote time to build this feature. However, I'm always happy to welcome a PR if you folks are open to contributing it.

Great we are more than happy to file a pr for this. I will look into Prettier and ESLint caching and see what we can do

PR is in! Happy to make any changes you see fit.

Thanks a bunch @FatehAK

Thank you for the PR and coordinating this. I hope this saves you folks a good chunk of time and enables swift deployments for your blog 😄

We managed to shave off 4 minutes, which is quite nice 🙂 Thanks for the swift review!

That's Awesome 😀


Combination of Sortable and Soft-deletable

Hi all,
I'm having an issue with a combination of Soft-Deletable and Sortable extensions. Can these 2 be used together? And how do i resolve this issue?
Example:
Item 1 - Position 0
Item 2 - Position 1
Item 3 - Position 2
Item 4 - Position 3
Delete Item 2
Item 1 - Position 0
Item 2 - Position 1 - Deleted at xxx
Item 3 - Position 2
Item 4 - Position 3
List of item positions shows: 0 - 2 - 3
Greets,
Joeri

While writing my issue, I've just realised i shouldn't use the position value on my frontend and just print the index of the item on the frontend.
For example:
What i used to do:
{% for item in items %}
    Position: {{ item.position }}
{% endfor %}

What i should do:
{% for item in items %}
    Position: {{ loop.index }}
{% endfor %}

So this does work correctly and the sortable recalculation keeps working even with soft-deleted items.

The class Gedmo\Sortable\Mapping\Event\Adapter\ORM should detect if there is a SoftDeleteable filter attached to the same entity to solve this problem.  The queries should be adjusted here for softdeleteable.

I seem to have been a bit to hasty thinking this was a solution to my problem, yes this solves the frontend part but backend this can still provide us with some issues.
Example:
Item 1 - Position DB: 0 Front: 1
Item 2 - Position DB: 1 Front: 2
Item 3 - Position DB: 2 Front: 3
Item 4 - Position DB: 3 Front: 4
Delete Item 2
Item 1 - Position DB: 0 Front: 1
Item 2 - Position DB: 1 Deleted at xxx
Item 3 - Position DB: 2 Front: 2
Item 4 - Position DB: 3 Front: 3
Move Item 2 to position 2 (Front)
Item 1 - Position DB: 1 Front: 1
Item 2 - Position DB: 0 Deleted at xxx
Item 3 - Position DB: 2 Front: 2
Item 4 - Position DB: 3 Front: 3
As you can see putting it on position 2 makes it stay on position 1 because there is a hidden item it has to jump over in the database.

I was wondering, if a combination of these 2 extensions would need a listener to see if an entity also has a position, and if so on delete move it to the bottom of the list?

it is too complicated to manage extension dependencies, user always can change the listener order and add his own listener which would break the behavior. I would suggest to manage it yourself, you can easily add another listener before softdelete and sortable, which would change the position for sortable entity which is being softdeleted. It is easy to find listeners from entity manager and get their metadata for specific entity.

Yeah that's how i solved it right now. I have a listener to send the delete item to the last position so it doesn't interfere with positioning of other items.

could you add a documentation entry regarding this issue with a listener example? in case someone asks the same.

I'll write one later tonight or this week and open a PR.

thanks ;)


Updated publish and subscribe pub/sub method added

updated most of the functions based on new @google-cloud/pubsub library.

topic.subscribe to topic.createSubscription
topics[topic].publish to topics[topic].publisher().publish
now need to pass data as string buffer or array.

@idoshamun take a look this new changes I have tested and it is working for me with
@google-cloud/pubsub v0.19.0

@ftechiesnitin thanks for the contribution! Released in v1.1.2


Assert binding ready before getting a11y listener

This adds an assert to verify that we have already got a binding when we
get a semantics listener. Otherwise we crash. (I mean, we still crash,
but now in checked mode we crash on an assert instead. Progress?)

LGTM


Can't build from source on Windows

Describe the bug
I followed the steps in https://github.com/aspnet/AspNetCore/blob/master/docs/BuildFromSource.md to build from source but can't get past the SDK requirement.
Screenshots

Additional context
I've tried a few additional troubleshooting steps:

A full update of VS2019
Installed the latest 3.x and 5.x netcore SDKs (for the latter, 5.0.100-alpha1-014044)
Ran ./eng/scripts/InstallVisualStudio.ps1 and ./eng/scripts/InstallJdk.ps1. I should note the former only tried to install the 2.0 and 2.1 netcore SDKs (????)
Installed latest nodejs and confirmed that it works
Ran build.cmd -restore

Do I specifically need sdk rev 13788?
dotnet info
Host (useful for support):
  Version: 5.0.0-alpha1.19454.5
  Commit:  33d05af6ff

.NET Core SDKs installed:
  1.0.3 [c:\program files\dotnet\sdk]
  1.0.4 [c:\program files\dotnet\sdk]
  1.1.0 [c:\program files\dotnet\sdk]
  2.1.3 [c:\program files\dotnet\sdk]
  2.1.4 [c:\program files\dotnet\sdk]
  2.1.200-preview-007474 [c:\program files\dotnet\sdk]
  2.1.201 [c:\program files\dotnet\sdk]
  2.1.300-preview2-008324 [c:\program files\dotnet\sdk]
  2.1.401 [c:\program files\dotnet\sdk]
  2.1.507 [c:\program files\dotnet\sdk]
  2.1.508 [c:\program files\dotnet\sdk]
  2.1.800-preview-009696 [c:\program files\dotnet\sdk]
  2.2.400-preview-010219 [c:\program files\dotnet\sdk]
  3.0.100-preview9-014004 [c:\program files\dotnet\sdk]
  5.0.100-alpha1-014044 [c:\program files\dotnet\sdk]

I should also note that the VS2019 option to enable preview SDKs is missing for me.

This issue was moved to dotnet/arcade#4196


pcsx2: 1.7.5004 -> 1.7.5270

Description of changes
Update to the latest version.
One thing I'm not able to implement: one of the changes made upstream is the disabling of Wayland, but you can enable it using the I_WANT_A_BROKEN_WAYLAND_UI environment variable.
This is the best I could do (inside qtWrapperArgs):
    ''--set QT_QPA_PLATFORM "\''$(if [[ -z $I_WANT_A_BROKEN_WAYLAND_UI ]]; then echo 'xcb'; else echo \'\'; fi)"''

Can someone more knowledgeable of Bash and escape hells fix this?

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 273330 run on x86_64-linux 1

1 package built:

pcsx2

That wayland env seems to just be for the upstream appimage. Wayland is still enabled by default in the cmake flags between these two version.
option(WAYLAND_API "Enable Wayland support" ON)

And from nixpkgs-review build log
-- Found Wayland_Client: /nix/store/pdgavpdmzfwf90k46ybca08bwlc3hzdc-wayland-1.22.0/lib/libwayland-client.so (found version "1.22.0")
-- Found Wayland_Egl: /nix/store/pdgavpdmzfwf90k46ybca08bwlc3hzdc-wayland-1.22.0/lib/libwayland-egl.so (found version "18.1.0")
-- Found Wayland: /nix/store/pdgavpdmzfwf90k46ybca08bwlc3hzdc-wayland-1.22.0/lib/libwayland-client.so;/nix/store/pdgavpdmzfwf90k46ybca08bwlc3hzdc-wayland-1.22.0/lib/libwayland-egl.so (found version "1.22.0") found components: Egl

On KDE I get the wayland app icon when running pcsx2-qt

Alright, I managed to implement I_WANT_A_BROKEN_WAYLAND_UI correctly.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3124

Hi, thank you very much for your (ongoing) contributions!
If I understand it correctly, I_WANT_A_BROKEN_WAYLAND_UI is redundant to QT_QPA_PLATFORM=xcb but added to be compatible with the AppImage/official documentation, is this right?

Yes.

Tested it locally, could however not test with wayland.
Thank you very much for your great work! :+1:


Saliency map of SOD and COD

Hello, this is a very good job.
We recently want to compare our results with EVP, but the provided results do not include SOD saliency maps. Also, when I load the EVP pretrained model, it prompts that the main component is "freq_adaptor", but this seems to be FP's parameter?
Can you please tell me if I made any mistakes here? Or can you provide your saliency maps?
Thank you!

Thanks for your interest in our work.
'freq_adaptor' in an extended version here, please specify model['encoder_mode']['name'] to 'fp' in the config file to use it, and find the corresponding model here.
If you want to compare your results with EVP, please specify model['encoder_mode']['name'] to 'evp' and use the corresponding model.

I guess the author might not run the whole test dataset to get the saliency maps since there exists the test.py....:)


[info] Example automatically generated

In order to provide CDK users with code samples in every language, we automatically translate snippets of TypeScript sample code into other languages.
You can recognize these translated example blocks by them starting with a text similar to the following:
# Example automatically generated. See https://...

This translation is currently experimental, and we'd like you to let us know how this is working out for you. Please comment on this issue if there's something you would like to discuss.
Examples we couldn't compile
We try compiling all the samples before translating them. This is necessary to extract type information that is necessary to render the correct translation of non-TypeScript languages.
However, compilation of sample code requires some setup that we haven't been able to do for all of our code samples yet. That means that many samples are translated without complete type information, and may hence be incorrect. You can recognize them by starting with a comment similar to:
# Example automatically generated without compilation. See https://...

If you encounter issues with some of these samples that are caused by its lack of compilation, we'd love it if you could help out by submitting a Pull Request to make the samples compile! See the following section to figure out what to expect.
Translation mistakes in uncompiled samples
The most common mistake in uncompiled samples is going to be around Structs, which are pure data objects passed to constructors and methods.  They are typically called something like FooProps or FooOptions, and in samples they appear something like this:
new SomeClass('param', {
  prop1: 'value1',
  prop2: 'value2'
})

MISTAKE 1: is it a struct or a map?
Mistake 1 the translator may make in translating the preceding code example without having any type information available, is that it can't know whether the argument to new SomeClass is intended to be of type {[key: string]: string} (i.e., a map of string to string), or of type interface SomeClassProps (i.e., a struct).
The caller side for both types looks exactly the same in TypeScript, so the translator can't distinguish between them, and so it is forced to guess.
In most cases uses like this will be structs, so that's what the translator will guess given no other information.  However, some classes legitimately take a map as argument (for example, GenericLinuxImage takes a map of region-to-ami), and in those cases the translator will have guessed wrong and produce an incorrect translation.

N.B.: The Java translator will prefer to guess that an untyped value is a map, rather than a struct.

MISTAKE 2: what is the struct's name?
When the translator guesses that something is a struct, it needs to translate it. In a language like Python, structs get translated into keyword arguments and so they don't need names. In other languages like Java and C#, structs get translated into data classes, and you need their name to instantiate them.  Unfortunately, the name of the structs doesn't appear in the code sample and since we have no type information we can't look it up.
In those cases, the translator will generate a placeholder name called Struct, with the understanding that you will need to go and look up the actual name when using this code. For example, the C# translator will have translated the above snippet into:
new SomeClass('param', new Struct {
    Prop1 = "value1",
    Prop2 = "value2"
})

You will need to go and look at the documentation of SomeClass to figure out that new Struct actually needs to be new SomeClassProps, or something to that effect.
How to make samples compile successfully
We'd rather have all samples compile successfully. To achieve that, modules need some boilerplate added to make it possible to compile the examples.  Typically, this boilerplate file will just import some names or set up some variables. This is called a fixture.
For example, making our running example compilable would look something like this.
Add a file to the package called rosetta/my-fixture.ts-fixture, and put the following into it:
import { SomeClass } from 'my-library';
/// here

And update the example to look like this:
```ts fixture=my-fixture
new SomeClass('param', {
  prop1: 'value1',
  prop2: 'value2'
})
```

The example code will be inserted into the fixture file at the location marked by /// here, and the resulting complete file should compile.
For more information, see the "Examples" section of aws-cdk's Contribution Guide or the "Fixtures" section of the rosetta tool.
Known Issues
The following are known issues with the translation tool:
Language keywords are not respected: Sometimes TypeScript code uses identifiers which are reserved keywords in other languages. The translated code may copy those identifiers without modification, leading to code that won't compile (example: import aws_cdk.aws_lambda as lambda won't actually work in Python as lambda is a reserved keyword).
Single values are interpreted as code snippets: The @example doc comment directive is used both for code snippets, as well as exemplar values for properties. The translator tries to translate the sample values, which will maul them (example).

The initial PR is here: https://github.com/aws/jsii/pull/827

How is this effort going? My team would absolutely love working python examples on the docs. For now we are relying on the excellent aws-cdk-examples for python, but it would be nice to have working examples inlined in the docs:

Good catch, that needs to be sorted as well.

lambda is a keyword in python and can't use used as an import alias.
import aws_cdk.aws_lambda as lambda

Ex: https://pypi.org/project/aws-cdk.aws-lambda/
should be
import aws_cdk.aws_lambda as lambda_

Like the aws-sdk-examples do. Ex: https://github.com/aws-samples/aws-cdk-examples/blob/master/python/lambda-cron/app.py

The Java examples seem to have a lot of issues as well with Classes/Builders and imports: https://docs.aws.amazon.com/cdk/api/latest/java/index.html?software/amazon/awscdk/services/dynamodb/package-summary.html
 Table table = new Table(this, "Table", new TableProps()
         .partitionKey(new Attribute().name("id").type(dynamodb.AttributeType.getSTRING())));

should be
   TableProps tableProps = TableProps.builder()
                .partitionKey(Attribute.builder()
                        .name("id")
                        .type(AttributeType.STRING)
                        .build())
                .build();

Sorry to do this to your @RomainMuller  but since you're working on Rosetta right now anyway, might as well work in these bug reports at the same time? 😇

Leaving a note here that I recently came across an issue that involved a python example that does not compile and leads to some confusion.
Example
# Example automatically generated without compilation. See https://github.com/aws/jsii/issues/826
from aws_cdk.core import CustomResource
import aws_cdk.aws_logs as logs
import aws_cdk.aws_iam as iam
import aws_cdk.custom_resources as cr

on_event = lambda_.Function(self, "MyHandler")

my_role = iam.Role(self, "MyRole")

my_provider = cr.Provider(self, "MyProvider",
    on_event_handler=on_event,
    is_complete_handler=is_complete, # optional async "waiter"
    log_retention=logs.RetentionDays.ONE_DAY, # default is INFINITE
    role=my_role
)

CustomResource(self, "Resource1", service_token=my_provider.service_token)
CustomResource(self, "Resource2", service_token=my_provider.service_token)

This example requires some modifications in order to compile. Here's is a modified version of the above example that works. (Given the 2 lambda handlers are provided in external files)
from aws_cdk import core as cdk
import aws_cdk.aws_lambda as lambda_
import aws_cdk.aws_logs as logs
import aws_cdk.aws_iam as iam
import aws_cdk.custom_resources as cr

class FooStack(cdk.Construct):
    def __init__(self, scope: cdk.Construct, id: str, **kwargs) -> None:
        super().__init__(scope, id, **kwargs)

        with open("src/lambda_handlers/on_event.py", encoding="utf-8") as fp:
            on_event_code_body = fp.read()

        on_event = lambda_.Function(self, "on_event",
            runtime=lambda_.Runtime.PYTHON_3_7,
            handler="index.on_event",
            code=lambda_.InlineCode(on_event_code_body),
        )

        with open("src/lambda_handlers/is_complete.py", encoding="utf-8") as fp:
            is_complete_code_body = fp.read()

        is_complete = lambda_.Function(self, "is_complete",
            runtime=lambda_.Runtime.PYTHON_3_7,
            handler="index.is_complete",
            code=lambda_.InlineCode(is_complete_code_body),
        )

        my_role = iam.Role(self, "MyRole",
            assumed_by=iam.ServicePrincipal("lambda.amazonaws.com")
        )

        my_provider = cr.Provider(self, "MyProvider",
            on_event_handler=on_event,
            is_complete_handler=is_complete, # optional async "waiter"
            log_retention=logs.RetentionDays.ONE_DAY, # default is INFINITE
            role=my_role
        )

        cdk.CustomResource(self, "Resource1", service_token=my_provider.service_token)
        cdk.CustomResource(self, "Resource2", service_token=my_provider.service_token)

Bug with Python translation of JavaScript instanceof keyword (aws-s3, https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_s3/README.html#encryption):
assert(bucket.encryption_key instanceof kms.Key)

Python doesn't have the instanceof keyword.  The correct form is:
assert(isinstance(bucket.encryption_key, kms.Key))

Bug with Python translation of JavaScript ?? (nullish-coalescing operator) (aws-cdk/core, uniqueid = "GloballyUniqueIdForSingleton"return stack.node.try_find_child(uniqueid) ?? sns.Topic(stack, uniqueid))
uniqueid = "GloballyUniqueIdForSingleton"return stack.node.try_find_child(uniqueid) ?? sns.Topic(stack, uniqueid)

It should be
uniqueid = "GloballyUniqueIdForSingleton"
return stack.node.try_find_child(uniqueid) or sns.Topic(stack, uniqueid)

(Also, there's a missing newline between the string literal and the return keyword 🤔)

# Example automatically generated without compilation. See https://github.com/aws/jsii/issues/826
assets.Asset(self, "BundledAsset",
    path="/path/to/asset",
    bundling={
        "local": {
            def try_bundle(self, output_dir, options):
                if can_run_locally: return Truereturn False
        },
        # Docker bundling fallback
        "image": DockerImage.from_registry("alpine"),
        "entrypoint": ["/bin/sh", "-c"],
        "command": ["bundle"]
    }
)

if can_run_locally: return Truereturn False

Looks wrong to me.

Another instance where JSII doesn't play nice with python, in
python cdk docs.
product = servicecatalog.CloudFormationProduct(self, "MyFirstProduct",     product_name="My Product",     owner="Product Owner",     product_versions=[{         "product_version_name": "v1",         "cloud_formation_template": servicecatalog.CloudFormationTemplate.from_url("https://raw.githubusercontent.com/awslabs/aws-cloudformation-templates/master/aws/services/ServiceCatalog/Product.yaml")     }, {         "product_version_name": "v2",         "cloud_formation_template": servicecatalog.CloudFormationTemplate.from_asset(path.join(__dirname, "development-environment.template.json"))     }     ] )
but when actually running cdk commands the field cloud_formation_template requires cloudFormationTemplate.  Both of these seem odd to me since cloudFormation is one word, and most python translations are snake case.

Another issue here in the docs
Specifically, FlinkApplicationProperties doesn't work the way the documentation describes here
    property_groups=PropertyGroups(
        FlinkApplicationProperties={
            "input_stream_name": "my-input-kinesis-stream",
            "output_stream_name": "my-output-kinesis-stream"
        }
    )

Mimic this example and you will fail with this error:
__init__() got an unexpected keyword argument 'FlinkApplicationProperties'
More information can be found about this issue in this comment here

I've just hit this when trying to use ILocalBundling. I couldn't find the docs so I kept searching for tests in jsii, and the closest I found was closed https://github.com/aws/aws-cdk/issues/17928.
I'd be more than happy to contribute to the docs if I manage to find a solution.
@jsii.implements(ILocalBundling)
class LocalPipInstall:
    @staticmethod
    @jsii.member(jsii_name="tryBundle")
    def try_bundle(output_dir: str, **kwargs) -> bool:
        install_command = f'pip install .\[pydantic\] --platform manylinux1_x86_64 --only-binary=:all: -t {output_dir}'
        subprocess.run(install_command, shell=True)
        return True

    @staticmethod
    @jsii.member(jsii_name="tryBundle")
    def tryBundle(output_dir: str, **kwargs) -> bool:
        install_command = f'pip install .\[pydantic\] --platform manylinux1_x86_64 --only-binary=:all: -t {output_dir}'
        subprocess.run(install_command, shell=True)
        return True

....
            code=Code.from_asset(
                path=str(SOURCE_CODE_ROOT_PATH),
                bundling=BundlingOptions(
                    image=DockerImage.from_build(
                        str(Path(__file__).parent),
                        build_args={"IMAGE": PythonVersion[PYTHON_RUNTIME_VERSION].value["image"]},
                    ),
                    command=["bash", "-c", " && ".join(build_commands)],

					# Here
                    local=LocalPipInstall(),

                ),
            ),


chore: adaptations for nightly-2024-06-19

This contains adaptations for

leanprover/lean4#4481
leanprover/lean4#4497
leanprover/lean4#4387 (Thanks to @JovanGerb  for these)
leanprover/lean4#4487

A lot of changes, but none of the changes looks too bad by itself.
bors merge
(do we use bors to merge into non-master branches?)

(bors is fine, but not necessary, on non-master branches)


support previous/next navigation

Provides initial support to have previous/next navigational links at various locations of a document based on a user's configuration. The option confluence_prev_next_buttons_location (default disabled with None) can be configured with the following to respectively render previous/next buttons for a detected ordered list of documents: bottom, both, top, None.

This is a useful feature -- would be great to see it merged in


Add TypeScript definition file

Hey! I added types based on the API I found in readme so that people can comfortably use this with TypeScript.

@crazycodeboy It would be really awesome to have this merged, any chance it can be done ? Please do not hesitate to let me know if I can help anyhow

can you please merge it ?


Filling variables whose input comes from simtel and corsika

Some of the metadata fields that are stored as attributes are currently not being filled, specifically:

CORSIKA_ver
E_max
E_min
prod_site_B_field
prod_site_alt
prod_site_array
prod_site_coord
prod_site_subarray
simtel_ver
spectral_index

These data can be found in the simtel history block, but retrieval of such a block through pyhessio/ctapipe has not been implemented (see this issue https://github.com/cta-observatory/pyhessio/issues/52).

I have been looking over pyhessio and ctapipe.io modules and I have managed to retrieve some of the required metadata already considered in pyhessio, at least those I could find easily. This  is how it looks so far.


Add purge and ban buttons to /explore page

:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on:

v1.2.0
Chrome Web Store
GitHub release

Your semantic-release bot :package::rocket:


Mica

Now in 1.3
https://learn.microsoft.com/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.media.micabackdrop

That was quick. Did I do something wrong?

Sorry for the confusion, in order to properly manage the issues, we have to close issues that don't follow the issue templates.


[1.12.2] Held Item Tooltips broken?

Minecraft: 1.12.2
Forge: <IP_ADDRESS>36
Mods: 1
ConsoleHUD-v1.3-1.12.2

Unless it's just me... I don't see the Tooltip appearing when selecting items. Tried with Enchanted Items, Shulker Boxes, and still... no Tooltip shows.
Going back to 'ConsoleHUD-v1.2-1.12.2'... the Tooltip appears as normal.

Issue still occurs in 'ConsoleHUD-v1.3.1-1.12.2'. I also tried updating Forge to '<IP_ADDRESS>38' and that didn't seem to do anything.

Yeah, I feared that might become an issue. What you need to do is to go into your options.txt file and change heldItemTooltips to true.

The reason this happened is that before v1.3 I was deactivating vanilla held item tooltips by changing that option. That wasn't a good thing, because after removing the mod the option might stay deactivated, so exactly what happened in your case. V1.3+ still checks for the heldItemTooltips options which is causing your problems. Will remove the check in the next version.

A fix was pushed as commit 530e3d1 and can be found as v1.3.2 on Curse.


Lab1 fibinocci: creating a new PR from a branch for Fibinocci

Fixes #
Changes proposed in this PR:

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      2    +1
  Lines           2     11    +9
=====================================
+ Hits            2     11    +9

Impacted Files
Coverage Δ

01_fibonacci/main.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8055b5...1443624. Read the comment docs.

Use the imperative form in the PR title: "create" not "creating"
Fill in the PR description template.

Hi,
There has been  no activity in the last 20 days so I will close this PR.
Feel free to open it again if you have something to add.
Thanks!
Julia


factor: panic attempting to factorise powers of two.

Like that
rgmbp:coreutils rg$ ./build/factor 2
thread '<main>' panicked at 'Range::new called with `low >= high`', /Users/rg/.cargo/registry/src/github.com-0a35038f75765ae4/rand-0.3.11/src/distributions/range.rs:60
2:rgmbp:coreutils rg$

I can't reproduce this issue.
llama@llama:...Code/rust/coreutils$ rcu-factor 2
2: 2
llama@llama:...Code/rust/coreutils$ rcu-factor 4
4: 2 2
llama@llama:...Code/rust/coreutils$ rcu-factor 8
8: 2 2 2

Ubuntu 15.04, with the latest nightly.

Sorry I've overbureaucratized this issue: #703 -- is the pull request that fixes that.

b04796 -- panics;
545549 -- does not panic.


What steps a and b?

it says two times "Upgrade to the latest Microsoft Dynamics NAV 2017 cumulative update (CU) by following steps a and b above."
But there are no steps a and b anywhere in this document and it's not clear what to do with a higher CU for NAV2017

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4bd117bf-692a-a466-873f-2000c4d78852
Version Independent ID: 280c6e15-ff52-6815-f34a-748b9cadf5a2
Content: Upgrade Microsoft Dynamics NAV - Dynamics NAV
Content Source: dynamics-nav/Upgrading-to-Microsoft-Dynamics-NAV-2017.md
Service: unspecified
GitHub Login: @jswymer
Microsoft Alias: jswymer

Thanks for your feedback. This will be fixed in the next refresh of the documentation.


[CSP] violation when loading add-on details page

Relates to #995
Steps to reproduce:

Load AMO-stage page https://addons.allizom.org/en-US/
Load any add-on details page (i.e. https://addons.allizom.org/en-US/firefox/addon/firebug/?src=hp-dl-mostpopular) with the console opened (and Security tab checked)
Observe the console

Expected results:
There are no issues CSP related.
Actual results:
There is a CSP violation.
Notes/Issues:
Verified on FF43(Win 7). Reproducible in AMO-stage and AMO-dev.
Screenshot for this issue:

@ValentinaPC I can't reproduce the same issues. Can you check the STR and make sure that page is the one generating the errors.
Similarly can you check -dev and see if that has the same problem as it might have a more up-to-date config.

I can repro this on FF 43.0.4 on windows 10. Seems to be CSP blocking the image loads in link elements: e.g:
<link rel="prefetch" href="https://addons-dev-cdn.allizom.org/user-media/previews/full/0/846.png?modified=1331247702">

Looks to be a platform bug in FF for windows only.
It to be fixed in 45.0.a2 (dev edition) but not in 44.0 Beta Update channel. I will see if there's a relevant bug related to this somewhere.
We'd need to look at what the impact on this might be.

Fwiw I tried adding a hint attribute as="image" but it didn't make any difference.

We're probably going to turn-off report-only on -dev tomorrow. I'm thinking we should test this there and see if there's any noticeable impact.

Turns out this isn't windows specific. I had prefetch turned off on osx.

Since CSP is going to block all the pre-fetching it seem like it will be a plan to remove it. I'm also going to look into if a platform bug exists for this and make a test-case.

There is a bit of a delay because the images are now requested when you open the image carousel. But this is a trade-off. If we can find a better solution as a workaround for the CSP violation we can always add this back.


[formal] improvement on formal TLUL assertions

[x]  TLUL assertion:
Current implementation: disable assertions and converted it assumptions in tcl file
New proposal: In TLUL_assert.sv, has a parameter to control using assertion or assumption. In DV all the assumptions are treated as assertions, so assert checking still works in DV.

[x]  Update the immediate assertions in TLUL_assert.sv to concurrent assertions, and explore some methods to only use posedge of the clk instead of both.

[x] find a better to replace "disable assert" in the tcl file for the TLUL assertions.

[x] Add assertions for tl_error cases.

@cindychip what is the status of this issue? Are the tasks above still open?

Hey Michael, thanks for checking. They are not our current priority anymore. Do you mind we just leave it for tracking until we have more bandwidth?

Ok no worries, just wanted to double check (I am on a mission to close down old issues ;)).

Last item documented in issue #11243


Cannot interact with the dapp

I have done all the steps and deployed the contracts. I got the front page too, but nothing is happening when I input email id or random numbers. Any help would be appreciated!
P.S : Great work on this project!

Assuming you are still having this issue, please provide screenshots of the app once you set it up and run it. Also, another screenshot of the javascript errors that you get when attempting to interact with the app.

It keeps saying email address not valid. How does it register an email address?

The valid domains for e-mail addresses are found in Migrations/2_deploy_contracts.js
deployer.deploy(Registrar, ['gmail.com', 'yahoo.com', 'hotmail.com'].map(x => web3.utils.asciiToHex(x)), {

You can change the domains before deploying to accept whatever you want.

Closing this issue assuming you understood what needs to be fixed to run the web dApp.


Group State Logging (left, deleted, name etc)

Pretty simple, just logging joining and leaving groups, identifying groups that have been deleted, and also maybe groups that change their names.

VRCX already does this.

I see no logging or info anywhere on groups that have been deleted.  I only see the "cannot find group id" popup and that is it.

'groupChange' is then event type, that popup is from friends joining deleted group instances.

I guess i just haven't seen a group get removed then if it's recent.  Most recent change i see of any kind was the 30th.  I was thinking another group i was in was taken down.


Adding BASE_DIR import when using 'theme'

relates to #1
Using the config/settings/local.py  being generated from config/settings/sample.local.py the app will not find start and crashes when having uncommented
THEME_DIR = os.path.join(BASE_DIR, 'theme')

The reason is that BASE_DIR is not defined because we also must import it in the first place via
import os
from . import BASE_DIR

Thanks!