Modernize for Ska3

This makes the eng_archive package compliant with Ska3 recommended practices:

Remove OCC-specific processing since syncing to clients is either rsync or via the client sync tools.
Fix setup.py to install all necessary files in the package.
Make console entry point scripts and remove custom launcher scripts that had been installed to share.
Update code for moved archfiles_def.sql file.
Remove Makefile

Passes tests with https://github.com/sot/ska_testr/pull/18.
Closes #162.

Additional testing:

Made a fresh Ska3 production environment /proj/sot/ska3/test-cheta
Uninstalled conda ska.engarchive
Installed  (with pip) this branch at dba6cf059aae77cd9f65f78e9360ead6969b624b
Make a fresh (independent) data directory /proj/sot/ska3/test-cheta/data
Copied acis4eng content from flight to /proj/sot/ska3/test-cheta/data/eng_archive/data/.
Make a cron job on luke-v /proj/sot/ska3/test-cheta/bin/skare task_schedule3.pl -config eng_archive/task_schedule.cfg
Cron job ran and produced expected results
Confirmed data for one MSID 1WRAT.

It can wait.  I want to write tests for the sync'ing stuff and get that all tidied for a release.


Reduce seed data for demo site

Heroku says: [warning] Database disruption imminent, row limit exceeded for hobby-dev database on Heroku app somerville-teacher-tool-demo.  Here's the relevant Heroku docs: https://devcenter.heroku.com/articles/heroku-postgres-plans#hobby-tier
We don't need that much data in the demo site, let's just remove some students or schools or homerooms, etc.

I could help with this, is that cool?

Hey @KaraAJC. This is a great way to get to know our data model. I'd say go for it!
My only advice is to keep at least one elementary school (likely Healey) and Somerville High School.
Let us know if you have any questions!

OK! sounds good! If there are any important representations I shouldn't remove, in terms of interesting homerooms or students that often get used as an example, let me know..

@KaraAJC awesome, and nice to meet you!  I updated the issue to have a link to the Heroku docs about these limits if that's helpful (so you know what the limit is and can check how many rows are in the database locally).  This will help the school district avoid having to pay more money each month for the demo site! 💰

@kevinrobinson OMG you read my mind! I've been researching the error specifically, after doing a quick read of the seed file and thinking "doesn't look bad to me" 😸
I'd like to be able to review the actual row counts by table, as this blog post suggests
so THANKS!
That will definitely help!

Oh hi there @KaraAJC! Nice to see you on here and thanks for tackling this issue! 🙌

@KaraAJC closed this last month! Nice job @KaraAJC! Closing this issue.


raftstore: consider duplicated mvcc versions when check compact

What is changed and how it works?

Issue Number: Ref #15282
What's Changed:

consider duplicated mvcc versions when check compact

This PR check-pick duplicated mvcc checks from https://github.com/tikv/tikv/pull/14536.
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
None

/merge


Add amount to onchain qr, just like unified QR

Awesome update with the unified qr. The QR of the unified qr contains the amount to be paid which will take the amount over in the wallet.
That works great, is it possible to implement this for the 'regular' onchain QR as well?

Did some additional testing. PR breaks some things, so I delete it.
The BIP21 is shown when Onchain only as well, so then for supporting wallets the amount is included.


Improve this doc broken on API pages v2

If you go to the 2.0 API (http://ionicframework.com/docs/v2/api/) and click on Improve this doc for any of the API entries, you'll get a github 404, e.g.:
http://ionicframework.com/docs/v2/api/components/infinite-scroll/InfiniteScroll/
Refers to (404):
https://github.com/driftyco/ionic/edit/2.0//home/ubuntu/ionic/ionic/components/infinite-scroll/infinite-scroll.ts#L2
It seems to work properly outside the API section of the site.

thanks! fixed


Debug support in compose

Add to JAVA_OPTS:
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005

Should be disableable and flexible port

Implemented. Just add
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=<IP_ADDRESS>:8000 to JAVA_OPTS env


Bug 4809 Docker Run Script Fixes and Improvements

Description

Changes to our Docker run scripts (run_docker.sh/bat & run_docker_notebook.sh/bat):

Remove dependency for coreutils on Linux/Mac
Bash scripts handle already running containers
Mirror .sh changes to .bat scripts to maintain uniform functionality
Store results in ./Results dir by default
Update readmes with any functional changes

Special thanks to @kazazes for starting these changes
Related Issue

Closes #4809
Closes #4810
Motivation and Context

Coreutils problem mentioned in #4809
Some quality of life improvements as well for easy use in linux environment
Requires Documentation Change

Readmes have been updated
How Has This Been Tested?

Ran a three variations of both scripts on Ubuntu 20.04 and Windows 10
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Gotcha! Just added a option to update the image, by default it is set to yes! Just didn't want to force updates if someone is running it offline with local data for backtesting.

Also, thats very weird ? I haven't had that happen when running from command line 🤔 Even with an outdated image. But either way I think the auto update of the image is a good feature to tack on!


fix: update display name providers

fix: update display name providers

@jdsermu1 Are you going to make the changes or shall I close the PR?

You are right I will close this PR and run the event list generator again in anther one given that more changes might have been made.


Model properties don't have typehint specified

Larastan Version: 6.x
--level used: 7

Description
As Laravel needs to support older versions of php they are unable to typehint the properties on the base model. So when you overwrite those properties you get errors like Property App\Models\User::$dates has no typehint specified..
For now I have added these to ignoreErrors as seen below. However when models are in a different namespace than App\Models you still get those errors. Any way we can ignore these errors based on the Model class in this package?
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$attributes has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$original has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$changes has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$casts has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$dates has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$dateFormat has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$appends has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$guarded has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$touches has no typehint specified.#'
- '#Property App\\Models\\[a-zA-Z0-9\\_]+::\$timestamps has no typehint specified.#'

Laravel code where the issue was found
use Illuminate\Database\Eloquent\Model;

class FooModel extends Model
{
    protected $dates = ['booking_date'];
}

Would adding checkMissingTypehints: false be okay for you?

That comes close, except I like to get an error when I forget to set a type hint. E.g.
/** @var array */
public $bla = [];

is valid with checkMissingTypehints: false on.

The best would be to open an issue at @phpstan and state your PHP version and where you wish to receive errors.

I don't think it's an @phpstan issue as the checkMissingTypehints: false does exactly what it's supposed to do. It's because Laravel has to be backwards compatible that they cannot add the typehint, but in projects that do use php 7.4 I still want to receive the error.

Any way we can ignore these errors based on the Model class in this package?

I see!


ci: remove image push to the official image repository and use the test instead

Summary
cherry pick of #9074 #9170 #8987 in the release 6.0 branch
Ticket Link
Release Note
NONE

Test reporting seemed off in github today, I still saw the as running when you merged :\


Morphlines hashDigest command

Initial commit for hashCommand implementation and tests

Link to https://issues.cloudera.org/browse/KITE-1122

What's the probability of hash collision (two different messages returning the same id) with the MessageDigests vs. GenerateUUID impl? How much less likely is a collision with SHA-256 than with that we have already today?

Regarding comparison vs GenerateUUID - the latter is guaranteed to be unique regardless of the input document - i.e. running the same document through a billion times will give a billion UUIDs.
This new function will always return the same result for the same input - hence its desirability.
Whether a collision is likely depends on the algorithm chosen and the number of inputs, but casually speaking is close to zero :-)

Thanks for reviewing @whoschek - I've updated based on your feedback.

Also, let's rename the name of the test case class to HashDigestTest in order to reflect the "hashDigest" name.

Thanks again for the great contrib! I think we're almost there. After the final minor outstanding changes please squash the multiple commits into a single big commit, and then we're ready to merge.

Also would be good to add corresponding docs in kite-morphlines/src/site/confluence/morphlinesReferenceGuide.confluence but that can be done in a separate commit if you like.

To read the html output that is generated from the confluence docs, or for debugging: cd kite; mvn post-site -pl kite-morphlines; open kite-morphlines/target/site/index.html

Also, for better perf consider using UTF16 instead of UTF8 for string conversion.

Regarding using UTF16 rather than UTF8 - this would give different results as the input byte array would be different. I think in general people would expect UTF8 (for example http://www.miraclesalad.com/webtools/md5.php) however actually we can make that configurable fairly simply. I'll set the default to UTF-8 but add a parameter call charset as per readCSV command.

Thanks for reviewing @whoschek  - much appreciated.

Updated the docs onto the same commit. Let me know if there's any further changes required.

Hi Tristan. I merged this. Thanks for this great contrib!

Thanks Wolfgang for your feedback and swift turnaround.
Tristan
Tristan Stevens
Senior Solutions Architect
Cloudera, Inc. | www.cloudera.com
m +44(0)7808 986422 |
On 27 Apr 2016 8:18 p.m., "Wolfgang Hoschek"<EMAIL_ADDRESS>wrote:

Hi Tristan. I merged this. Thanks for this great contrib!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/kite-sdk/kite/pull/443#issuecomment-215198599


Adaptations to nan 2.2.1

The first commit is an error, my apologies.
Please give me your feedback

@Will-I4M I've cherry-picked your commit to node-four-update branch and do some code style fixes. It is still broke Travis build, working to fix it.

+1

Thanks, another version is comming, with better performances on fetch (~3x). I'm just waiting before push because i'm working on a faster method to build the v8 objects (as we can expect in some cases 10x or more). I'm not sure to understand this error with travis. Need help ?

Can you also check it with nightly node 6
https://nodejs.org/download/nightly/

I'm quite sure the code need some changes to be v6 ready. For example : https://github.com/nodejs/nan/issues/548 -> the callback APi has changed. I'll check it but not in the next few days ;)

@Will-I4M  How can I install this module from your PR?

Sorry for this late answer ... You can install it from my fork, if you need it now.
I'll try to push the next release this we, or next week.

Any updates?

I've continue fixing this in node-nan-update branch, feel free to make further pull request on top of it.


Having problem

Analyzer Feedback from IntelliJ

Can you provide any details? SDK version? Dart plugin version?

it working fine now


Fix for Issue #283: Invalid Weave BLE scan response from nRF5 Device Layer

-- Corrected a mistake in the encoding of the Weave BLE device identification block that gets sent as BLE service advertisement data by the nRF52840.  The previous version of the code omitted two fields, which caused considerable heartburn for the Nest mobile application.
-- Corrected another minor mistake in the encoding of the device identification block on the ESP32 which resulted in the wrong data block type being sent.  This bug didn’t seem to bother the mobile application.
-- Created a common data structure for encoding and decoding a Weave BLE device identification block and refactored the nRF5 and ESP32 code bases to use this structure.

Codecov Report

Merging #288 into master will increase coverage by 1.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   53.11%   54.29%   +1.18%
==========================================
  Files         276      289      +13
  Lines       53721    56107    +2386
==========================================
+ Hits        28534    30464    +1930
- Misses      25187    25643     +456

Impacted Files
Coverage Δ

src/system/SystemClock.cpp
28% <0%> (-10.1%)
:arrow_down:

src/inet/IPAddress-StringFuncts.cpp
90% <0%> (-1.31%)
:arrow_down:

src/lib/core/WeaveMessageLayer.cpp
16.26% <0%> (-0.7%)
:arrow_down:

src/test-apps/TestInetAddress.cpp
99.1% <0%> (-0.17%)
:arrow_down:

src/lib/core/WeaveConnection.cpp
0% <0%> (ø)
:arrow_up:

src/system/SystemMutex.cpp
60% <0%> (ø)

src/test-apps/TestInetLayerDNS.cpp
90.76% <0%> (ø)

...i/security-support/native/WeaveSecuritySupport.cpp
73.33% <0%> (ø)

...rity-support/native/WeaveKeyExportClientNative.cpp
42.56% <0%> (ø)

src/lib/profiles/security/WeaveKeyExportClient.cpp
72.83% <0%> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe9f08...1a3aded. Read the comment docs.


Feature/emr query filter

EMR Query Filtering and Terminate
This is a new feature for Cloud Custodian, specifically for the EMR resource.
Problem
Cloud Custodian currently queries all EMR clusters in an account before doing output filtering on it. On accounts with large amounts of EMR clusters ( >1000 ) we are seeing API rate limits from AWS, and this breaks the functionality.
In addition, only the default actions (notify and lambda-invoke) are available for the EMR clusters.
Solution
Query filtering has been implemented for EMR. At the moment, only the ClusterStates filter is supported, but more will be added in the future. The implementation was inspired by the query filtering for EC2.
The terminate action has also been added to EMRs.
Related Issues
https://github.com/capitalone/cloud-custodian/issues/485
https://github.com/capitalone/cloud-custodian/issues/488

I will be implementing the delete operation in the same branch, as this will make it a bit easier to deal with commits and merges.

Terminating EMR clusters has been implemented.


Allow Activity Feed to have User entity Updates

Describe your changes:
Fixes #13373

I worked on ... because ...

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani let me know if we need to wait for UI changes in this PR , or they will be coming in separate PR?


week 3 review ticket

Quality of work

[ ] Share link(s) on slack to final work:  GitHub pages, Replit, Review Ticket(s), TimeBox, or other methods you have used to organize work.

Coding Review
Individual Coding:

[ ] GitHub Pages showing key learnings and challenges conquered from Tech Talks
[ ] GitHub commits you have made, show GitHub insights into your code commits.
[ ] Show Code running on Replit as well as IntelliJ
[ ] Menu review illustrating use of Lists and navigation: show runtime, code organization, code and comments
[ ] List and Loops: show runtime, code organization, code and comments
[ ] Class review and understanding: show runtime, code organization, code and comments
[ ] Show Crossover contribution:  Highlight work you did in crossover project: show their Replit runtime, code commit(s) in their
[ ] GitHub repo. Show anything you have done to enhance what you have learned from Python code

Video 2 minutes: showing the above, quality suggested as follows

[ ] Make sure you cover everything, but create your own order and optimize time
[ ] Use Voice or Captions.   Try not to wiggle mouse a lot or over scroll.  Make sure you have a clear plan before you start.
[ ] Perform video in small parts 15-30 seconds and finish a key subject.  Then put the final Video together with Video editing or Youtube playlists.

VIdeo Link
Website

GitHub Pages showing key learnings and challenges conquered from Tech Talks 0.75/1 - notes failed to include key learnings
GitHub commits you have made, show GitHub insights into your code commits. 1/1
Show Code running on Replit as well as IntelliJ 1/1
Menu review illustrating use of Lists and navigation: show runtime, code organization, code and comments 1/1
List and Loops: show runtime, code organization, code and comments 1/1
Class review and understanding: show runtime, code organization, code and comments 1/1
Show Crossover contribution: Highlight work you did in crossover project: show their Replit runtime, code commit(s) in their
GitHub repo. Show anything you have done to enhance what you have learned from Python code 1/1
Video 2 minutes: showing the above, quality suggested as follows
Make sure you cover everything, but create your own order and optimize time 1/1
Use Voice or Captions. Try not to wiggle mouse a lot or over scroll. Make sure you have a clear plan before you start. 1/1
Perform video in small parts 15-30 seconds and finish a key subject. Then put the final Video together with Video editing or Youtube playlists. 0.5/1 - video ran for too long.
Final Score: 9.25/10


Upgrade Node12 to Node16

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16<EMAIL_ADDRESS>

FYI: There is a fork with Node16: https://github.com/fertrig/create-file-action

I have upgraded the dependency to node 20 with the latest v0.3.
Closing the issue


chore: set the sentry cli path

Description
Starting with version 1.13.0, the plugin bundles both macOS and Windows 64 bit executables of sentry-cli. We need therefore to specify a custom sentry-cli path by adding sentry_cli_path to all sentry related actions. see https://github.com/getsentry/sentry-fastlane-plugin#specify-custom-sentry-cli-path
Bonus:
Added a check cli is installed action to make sure we can bail early in case it's not there
This PR sets the sentry cli path with the fastlane actions. As of 1.13.0, this needs to be set

QA Testing

Acceptance Criteria

Both builds succeed and the sentry actions do not fail at any step

Setup Instructions

PR Checklist

[x] I tested my changes on iOS / Android.
[x] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[ ] I hid my changes behind a feature flag.
[ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

fix sentry upload errors - mounir

Need help with something? Have a look at our docs, or get in touch with us.

The same code worked for android and not for iOS 😄. I will update @sentry/cli

The update solved the issue - also i did some testing in the app and everything seems to be working fine. I will merge this PR to unblock the release. Let me know if you have any feedback


Identify patients who went through CABG in eicu database

Here is my code, any comments?
select distinct patientunitstayid from physionet-data.eicu_crd.patient
where apacheadmissiondx in ("CABG alone, coronary artery bypass grafting","CABG redo with valve repair/replacement",
"CABG with mitral valve replacement","CABG alone, redo","CABG with double valve repair/replacement",
"CABG with aortic valve replacement","CABG with other operation","CABG with mitral valve repair","CABG redo with other operation","CABG with pulmonic or tricuspid valve repair or replacement ONLY.","CABG, minimally invasive; mid-CABG")

Possible to pickup some more in the diagnosis table.

Thanks. I does find more patients with diagnosis table. My updated query is like this:
select distinct * from (
select distinct patientunitstayid from physionet-data.eicu_crd.pasthistory
where pasthistorypath in (
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/jaundice",
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/UGI bleeding",
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/encephalopathy",
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/ascites",
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/varices",
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/biopsy proven",
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/clinical diagnosis",
"notes/Progress Notes/Past History/Organ Systems/Gastrointestinal (R)/Cirrhosis/coma")
union all
select distinct patientunitstayid from physionet-data.eicu_crd.apachepredvar
where cirrhosis=1
union all
select distinct patientunitstayid from physionet-data.eicu_crd.diagnosis  where icd9code in ("571.2, K70.3",
"571.5, K74.60", "571.6, K74.5", "571.5, K74.69")
)
order by patientunitstayid

I searched cabg in diagnosis table and got the following items.
It seems to be CABG patients before this admission.
cardiovascular|cardiac surgery|s/p CABG < 7 days
cardiovascular|cardiac surgery|CABG < 7days
cardiovascular|cardiac surgery|s/p CABG < 7 days|with CPB
cardiovascular|chest pain / ASHD|coronary artery disease|s/p CABG
cardiovascular|cardiac surgery|s/p CABG >= 7 days
cardiovascular|chest pain / ASHD|coronary artery disease|no previous CABG
cardiovascular|cardiac surgery|s/p CABG < 7 days|minimally invasive


Default Post-Login Redirect

Post-login URI defaulted if someone starts a new session on the login page (Jetty doesn't know where to go after..).
Current behaviour is to default to "/" in some circumstances but that is fragile with path-proxied installations.

Leaving this here until someone requires support for this edge-case being configurable (path-proxied installations with auth configured)


How do i make my own rooms?

This is an "engine"and i want to make a simple room in this "engine".  How would i do that?

You can't. It doesn't have an editor, if thats what you mean.

Look at how the example rooms are programmed to understand which method does what, then apply these principles to what you want to create. That's the best approach I can think of.

but then how do i recompile it with g++?

Something like this might help: https://github.com/ikonst/make-it-so

That particular project is probably too old for this purpose, but you can google for similar tools.

it says its for linux, but im on windows 10, would it still work?

you'd have to install wsl and most likely x410, but yea, you could probably get it working, @IPlayMinecraftYT

I've managed to do it. You need to create a new level file (cpp and header) and create a new file for the meshes you want to add. This isn't efficient so I'm gonna find a way to add meshes with out the need for a individual file. it reads mesh data from 'Mesh.cpp' and only supports .obj
You can add support for more file types like dae but it will take some work since the file is kinda hardcoded for .obj only. Hope this sorta helps.


EKF feature options to disable features at compile time

The EKF when used within PX4 (ekf2) is a relatively enormous 124 kB to 161 kB of flash depending on optimization level (-Os vs -O2). This can become problematic for inclusion on relatively flash constrained boards that might be found in FPV quadcopters (with GPS) or CAN peripheral nodes.
Are there certain features we can completely strip out at build time for simpler cases? Everything would still be on by default, but specific builds could then start to specialize.
Ideas

GPS heading fusion (requires higher end GPS most don't have)
airspeed fusion (maybe could be captured in something more general for fixed-wing usage?)
drag fusion
vision

If we move forward with this I'll extend the testing within this repository to additionally build and run testing with all flags disabled, and then all enabled individually.

This will be very useful on the ARK Flow and ARK GPS boards to run the ekf.

Are we still exposing the relevant parameters in the ekf2 module? How does the user know this feature is not available if the parameter shows in the GCS?

Are we still exposing the relevant parameters in the ekf2 module?

At the moment yes, but the defines could be extended around those parameters as well (ekf2 side). Then they wouldn't even be in the build, show in QGC, etc.

Having all those ifdefs adds a lot of noise in the code. If we want to disable functionalities at compile time, I think we should first refactor all the fusion type in separate classes/files that we can then en-/dis-able cleanly


Show only the selected payment_method  in PaymentSheet

Is your feature request related to a problem? Please describe.
Ok, maybe I'm missing something. If I create a PaymentIntent with a certain payment_method specified and then I do the initPaymentSheet and presentPaymentSheet combo I always see all the attached cards, and for my use case is bad since I need to charge users differently based on the paymentmethod.card.country value. So let's say that

I create a PaymentIntent with amount 100 for an IT card
the user select a US card the PaymentSheet
The amount paid is 100 even though it should have been 110 (bad for me).
The viceversa is also true, so they pay 110 instead of 100 (bad for users).

Describe the solution you'd like
When a PaymentIntent is created with a payment_method, that payment_method should be the only one displayed in the PaymentSheet
Describe alternatives you've considered
I resolved my use case via backend by creating/updating/confirming the PaymentIntent on the backend, but this only works well when the confirmation doesn't fail => I need to reinvent the wheel in order to handle all the other cases, e.g. handling 3DS
Additional context

All the payment_methods used are cards and created via the SetupIntent
I also need to use Stripe Connect

I think I solved it using the useConfirmPayment hook without the initPaymentSheet and presentPaymentSheet combo. So I can create and update the payment intent as I prefer and the the user can manually confirm the payment and, if necessary, do the strong authentication required


Bug: valid_json language string missing in /system/Language/en/Validation.php

PHP Version
8.1
CodeIgniter4 Version
4.2.6
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
macOS, Linux
Which server did you use?
fpm-fcgi
Database
MySQL 8
What happened?
The valid_json language string is missing in /system/Language/en/Validation.php.  I can certainly fix this by providing my own string, but given this is a stock validation rule, it probably aught to exist.
Steps to Reproduce
create a validation rule containing valid_json, and pass invalid json.
Expected Output
I would expect to see something like:
The content field must be valid json.
Instead i get:
Validation.valid_json
Anything else?
No response

Thank you for reporting. I confirmed this bug.
We welcome a PR.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

I send PR #6624


Talos mishandles parameters that have to be ints

I'm trying to do a really general hyperparameter search, and I have a model function model_ta that requires that params['conv_count'] is an integer, not a float64.
Under certain circumstances, talos violates this requirement in a way that dosen't make too much sense.
Compare:
h = ta.Scan(x=ret_train,
            y=Y_train,
            params={
                'dense_count': [1, 2, 3],
                'dense_units': [50, 100, 150, 200],
                'conv_count': [0],
                'l2reg': [1, 100, 1000],
                'epochs':[4],
                'batch_size':[32]
            },
            model=model_ta,
            grid_downsample=0.1,
            functional_model=True)

and
h = ta.Scan(x=ret_train,
            y=Y_train,
            params={
                'dense_count': [1, 2, 3],
                'dense_units': [50, 100, 150, 200],
                'conv_count': [0],
                'l2reg': [1.0, 100, 1000],
                'epochs':[4],
                'batch_size':[32]
            },
            model=model_ta,
            grid_downsample=0.1,
            functional_model=True)

The previous results in a perfectly normal hyperparameter search, while the latter results in a bunch of errors. See that 1.0 replacing 1 in the second l2reg? That's what's different between these two.
If I run the second scan with my model function, I get:

TypeError                                 Traceback (most recent call last)
~/anaconda3/lib/python3.6/site-packages/talos/scan/scan_round.py in scan_round(self)
27     try:
---> 28         _hr_out, self.keras_model = ingest_model(self)
29     except TypeError as err:
~/anaconda3/lib/python3.6/site-packages/talos/model/ingest_model.py in ingest_model(self)
9                       self.y_val,
---> 10                       self.round_params)
 in model_ta(x_train, y_train, x_val, y_val, params)
3     # replace the hyperparameter inputs with references to params dictionary
----> 4     mdl = model(params)
5
 in model(params)
91     #merged = Concatenate(subnets)
---> 92     net = make_net(returns_input, params)
93
 in make_net(input_layer, params)
29     if params.get('dense_count', 0) !=0:
---> 30         for dense_num in range(params['dense_count']):
31             newDense = Dense(
TypeError: 'numpy.float64' object cannot be interpreted as an integer
During handling of the above exception, another exception occurred:
TalosReturnError                          Traceback (most recent call last)
 in ()
11             model=model_ta,
12             grid_downsample=0.1,
---> 13             functional_model=True)
~/anaconda3/lib/python3.6/site-packages/talos/scan/Scan.py in init(self, x, y, params, model, dataset_name, experiment_no, x_val, y_val, val_split, shuffle, round_limit, grid_downsample, random_method, seed, search_method, reduction_method, reduction_interval, reduction_window, reduction_threshold, reduction_metric, reduce_loss, last_epoch_value, talos_log_name, clear_tf_session, functional_model, disable_progress_bar, print_params, debug)
164         # input parameters section ends
165
--> 166         self._null = self.runtime()
167
168     def runtime(self):
~/anaconda3/lib/python3.6/site-packages/talos/scan/Scan.py in runtime(self)
169
170         self = scan_prepare(self)
--> 171         self = scan_run(self)
~/anaconda3/lib/python3.6/site-packages/talos/scan/scan_run.py in scan_run(self)
19                      disable=self.disable_progress_bar)
20     while len(self.param_log) != 0:
---> 21         self = scan_round(self)
22         self.pbar.update(1)
23     self.pbar.close()
~/anaconda3/lib/python3.6/site-packages/talos/scan/scan_round.py in scan_round(self)
31             raise TalosTypeError("Activation should be as object and not string in params")
32         else:
---> 33             raise TalosReturnError("Make sure that input model returns 'out, model' where out is history object from model.fit()")
34
35     # create log and other stats
TalosReturnError: Make sure that input model returns 'out, model' where out is history object from model.fit()

And printing all the parameters in my model function shows that all parameters have been converted to float types, which does not happen when I don't have the float-type l2reg value.

I hereby confirm that my Talos is up to date, and that my model function works outside Talos : 2

Model function:
from keras.models import Model
from keras.layers import Input, Dense, Conv1D, Flatten, Concatenate
from keras import regularizers

def make_net(input_layer, params):
    net = input_layer

    if params.get('conv_count', 0) !=0:
        for _ in range(params['conv_count']):
            newConv = Conv1D(
                    activation='relu',
                    filters=params['conv_filters'],
                    kernel_size=params['conv_kernel_size'],
                    kernel_regularizer=regularizers.l2(float(params['l2reg'])))
            net = newConv(net)
            # optional pooling
            if params.get('pool_size', None) is not None:
                newPool = keras.layers.MaxPooling1D(
                        pool_size=params['pool_size'],
                        strides=params.get(
                            'pool_strides',
                            params['pool_size']),
                        )
                net = newPool(net)

        net = Flatten()(net)

    if params.get('dense_count', 0) !=0:
        for dense_num in range(params['dense_count']):
            newDense = Dense(
                    units=params['dense_units'],
                    activation='relu',
                    kernel_regularizer=regularizers.l2(float(params['l2reg'])),
                    )
            net = newDense(net)

    return net

def make_optimizer(params):
    opzr = keras.optimizers.Adam(**params.get('optimizer', {}))
    return opzr

import keras.backend as K
def model(params):

    def metric_correlation(y_true, y_pred):
        logger.warn(f'[metric_correlation] y_true size: {y_true.shape}, y_predy size: {y_pred.shape}')

        def m(x, w):
            """Weighted Mean"""
            return K.sum(x*w) / K.sum(w)
        def cov(x, y, w):
            """Weighted Covariance"""
            return K.sum(w* (x - m(x, w))*(y - m(y, w)))/ K.sum(w)

        def corr(x, y, w):
            """Weighted Correlation"""
            return cov(x, y, w) / K.sqrt(cov(x, x, w) * cov(y, y, w))
        print(y_true.get_shape())
        return corr(y_true, y_pred, K.ones_like(y_true))
    inputs = []

    subnets = []

    inpt = Input(shape=(30,), dtype='float32', name='returns_input')
    inputs.append(inpt)

    net = make_net(inpt, params)

    condenser = Dense(units=1, activation=None, use_bias=False)
    net = condenser(net)

    model = Model(inputs=inputs, outputs = net)

    opzr = make_optimizer(params)
    model.compile(
        loss='mean_squared_error',
        optimizer=opzr,
        metrics=[metric_correlation])
    return model

To reproduce problem, run with:
h = ta.Scan(x=np.random.normal(loc=0.0, scale=1.0, size=(5000, 30)),
            y=np.random.normal(loc=0.0, scale=1.0, size=(5000, 1)),
            params={
                'dense_count': [1, 2, 3],
                'dense_units': [50, 100, 150, 200],
                'conv_count': [0],
                'l2reg': [1.0, 100, 1000],
                'epochs':[4],
                'batch_size':[32]
            },
            model=model_ta,
            grid_downsample=0.1,
            functional_model=True)

PS: I know the solution to this problem is to do float-to-int conversion for each parameter supplied to model_ta(), but I would like to have talos and not me handle this.

PPS: I just pulled the newest commit on daily-dev

@mikkokotila
mikkokotila Merge pull request #124 from awilliamson/early_stopper

and the problem persists.

Regarding the error you are getting, did I gather it correctly and you are able to run the experiment when all the values are ints?
Unfortunately we can't change all floats to ints, as some parameters are floats (like dropout and lr). There could of course be some simple system that converts values to ints if all values are whole numbers in float form. That way there is no possible downside it seems.
That said, the error you are getting might have to do with something other than what it seems to have to do. As I see, the error itself comes from trying to use a float for range (or so it seems). I have witnessed rare cases where something similar happened with a similar effect, where actually the error messages gave zero indication of the actual issue (?!). These were caused by:
1) model is not in standard format
First regarding the input model, to be safe, the format always has to be:
def model_ta(x_train, y_train, x_val, y_val, params):

    # the model contents is here

    return out, model

The key point here is that the model arguments has to be exactly like that, and the return has to be exactly like that as well (where model that is created inside the function, and out is the history object),.

some of the parameters that are expected to follow standard naming convention (eg. 'first_neuron' and 'dropout') were using some other names

In such cases (these were never reported but is my own experience arising from extensive use) 0 of the time the error saying something about dtype had something to do with dtype. If this happened 10 times, then 9 times it was because of one of the two reasons above.
Can you check these in your end and see what happens then.

model_format: I'm dumb. Forgot to include this: (I'll give you a full quote that actually replicates everything)

def model_ta(x_train, y_train, x_val, y_val, params):
    print(params)
    # replace the hyperparameter inputs with references to params dictionary
    mdl = model(params)

    history_callback = mdl.fit(x_train, y_train,
                batch_size=params['batch_size'],
                epochs=params['epochs'],
                verbose=1,
                validation_data=[x_val, y_val])
    history_callback.history['val_acc']=[42]
    # modify the output model
    return history_callback, mdl

dtype issue: I'm pretty sure the issue is caused by talos though. the thing is this:
when I provide a single float for l2reg, all the OTHER parameters get changed to float. So things like layer count and number of neurons in the layers. Parameters should have their dtypes handled individually, amiright?

naming convention: thanks for telling me that. I'm new to ML so I know nothing.

I'll compile a file with the appropriate code to replicate the problem; expect it in a few minutes.

https://gist.github.com/renxida/0f708665aeff7bca2fdbbbae9a147462

this is the first time in my lifetime that I got an issue with a label like 'high priority fix' : )
Thanks. It makes me feel incredibly happy about contributing to this project.

Nice. Thanks :)
It seems that you found something interesting there with forced float conversion, this should clearly not happen. I will go through the codes to identify where and how this happens. I changed the name title of issue to reflect our current understanding of it.

When numpy array is created from a list, if the list has ints and floats, it's all converted to floats. If there is also string (and floats and ints) nothing is converted.
So any case where only int and float is present in params dictionary, and as long as there is even a single float, all the values will be converted to float. That's clearly a problem. The issue is created here:
  def _param_grid(self):

       '''CREATE THE PARAMETER PERMUTATIONS

       This is done once before starting the experiment.
       Takes in the parameter dictionary, and returns
       every possible permutation in an array.
       '''

       ls = [list(self._p[key]) for key in self._p.keys()]
       _param_grid_out = array(list(product(*ls)))

       return _param_grid_out

The fix is to declare dtype='object' in the array creation. It's now merged up until dev. The right version is 0.4.5.
Thanks a lot for helping, it's really great to have this bug out.

Glad I could help.
Over the summer of 2018 I've been doing some hyperparameter searching with a set of scripts I've written. They work, but they're a mess, and I'm looking to migrate everything to Talos, which is superior in that it's better organized.
Expect more issues & PRs from me over the winter break as I perform the migration : )


IonTabs loads all ionicons - can this be more dynamic?

<script lang="ts">
    import { onMount } from "svelte";

    import * as ionIcons from "ionicons/icons";

Undesirable

Fixed by refactoring IonTabs with layout and changing the imports


Fix for certain child modules not getting cleared

When clearing a module, certain child modules seem to be skipped.
This seems to be because the require.cache[idx].parent.children array is mutated with an Array.splice-call inside the next recursive call to clear(), skipping certain indices in the outer for-loop over children.
while (i--) {
	if (require.cache[filePath].parent.children[i].id === filePath) {
		// seems to mutate iterator in snippet below, one level of recursion above
		require.cache[filePath].parent.children.splice(i, 1);
	}
}

for (const {id} of children) { // certain indices of `children` do not get cleared?
	clear(id);
}

Making a new array fixes the issue.
Looking at the test clearModule() recursively, before using clearModule, delete require.cache[require.resolve(id)]; is executed. I am not sure if this is part of the expected usage of the function, but the test fails if it is removed. If you swap the order of the imports in fixture-with-dependency.js, the test succeeds.
I chose to split the commits into three so that you may first review the failing test, and then consider how the fix should look.

Thanks for fixing 👍


Bug on activity_feed & tasks

In the approval workflow, when a term is added and Activity Fedds & Tasks is clicked, the page goes to an incorrect link. We didn't find any request address for /activity_fedds/ in the code。

@karanh37 This bug occurs when the glossary is Chinese

https://github.com/open-metadata/OpenMetadata/assets/37568108/7cbbe8a6-ea02-41df-bff8-539178bc2ba9


have agent registration to master communication done

still need to store connected agents in master

Coverage decreased (-7.4%) to 36.239% when pulling 2893ebd726d2a5a464c903ad12b378a9cb40b16f on agent-communication into f95824dc34d2289db78aee2561cbd6c2383a7ed7 on master.

Coverage decreased (-9.1%) to 34.528% when pulling a213af8945f3928c89237bb02d0d2d0212f1db0f on agent-communication into f95824dc34d2289db78aee2561cbd6c2383a7ed7 on master.

Closes: #35


dialog modify events not getting figured

Hey Dave, I hope all is well!

Drachtio doesn't fire 'modify' on the dialog when I unhold a call, because line 364 resolves to true (see if statement on line 379) - and instead it just does whatever the the default action is... which seems to be just return the currently last known SDP?

Yes, I am trying to simplify handling of a few re-INVITE scenarios for the developer:

a session refreshing re-INVITE.  Generally, there is no need for the app to do anything about this, but it may want to be notified.
a session that has been placed on hold by the far end.  Ditto.
a session that has been taken off hold (audio restored) by the far end.  Ditto

In those cases, the Dialog object emits 'refresh', 'hold', and 'unhold' events, respectively.
The thing in the code about redacting the o= line is that the version in the o= line will be incremementing, and we want to eliminate that from our comparisons when seeing what changed.
If none of the above are true with respect to a re-INVITE, then it is an INVITE with a new SDP that the application will want to (need to) handle, and we emit a 'modify' event in that case with (req, res) so the app can inspect the new sdp, do whatever and respond.
Does that help?  Is there something you need in your handling above and beyond this?

Aah, yeah okay that makes sense.
In my case, if lets say a mobile device is being invited, so the ANSWER is being stored, then on the first HOLD, modify triggers, but is then the local SDP is set to the content of the INVITE that issues the hold. The following UNHOLD then triggers the unhold event I guess?
Is there some fancy way to disable this, and just throw everything into the modify event? Right now I'd have to subscribe to both modify, hold and unhold to essentially do the same thing

I want to make sure I can understand your scenario, because you say "on the first HOLD, modify triggers.."  Do you mean that the call is established, then you get a re-INVITE on hold but the 'modify' event is triggered, rather than the 'hold' event?  Because that would be a bug.
I want to make sure that the current logic is currently classifying invites-on-hold and invites-off-hold, because it almost sounds like you are experiencing an error/bug related to that

So the flow of what happens
Call establishment:
Asterisk - INVITE (SDP) ->   Drachtio   - INVITE (SDP) -> Device
Asterisk <-  OK (SDP)   <-   Drachtio   <-   OK (SDP)   - Device

Then HOLD ('modify' is triggered):
Asterisk <- (Re)INVITE (SDP) <- Drachtio <- (Re)INVITE (SDP) - Device
Asterisk --  OK (SDP)   -->     Drachtio    --- OK (SDP) ----> Device

Then UNHOLD ('unhold'ø' is triggerd):
Asterisk <- (Re)INVITE (SDP) <- Drachtio <- (Re)INVITE (SDP) - Device
Asterisk --  OK (SDP)   -->     Drachtio    --- OK (SDP) ----> Device

From looking at the code, I think it's because the SDP returned during call establishment (200OK) is different from the SDP the device generates when it sends out a re-invite to hold the call - meaning modify gets triggered on the first hold, but because the re-invite to unhold is near identical to the hold SDP, then the local triggers the unhold event on the unhold-event (and on all subsequent re-invites from the device, presumably the hold event would also fire).

All this being said, it's not impossible that my drachtio code is a bad. I'm battling all sorts of issues with hold/unhold right now where it straight up doesn't work when the call is initiated from the device - I think it's something with the from/to tags not being correct and RTP Engine not doing what it's supposed to...
And I've got this annoying bug where some times (like 50%) when I unhold a call established from the Asterisk side, then the call audio doesn't reestablish correctly either...

can you send me (separately to daveh at drachtio.org) the drachtio log trace (at info level) from the scenario above, showing the INVITE, the 'hold', and then the 'unhold'?

There are sort of 2 problems here:

We weren't smart enough to detect the first re-INVITE was an invite on hold, so we emitted 'modify'
We then did detect that the next re-invite was an invite off hold, but emitting an 'unhold' when we never emitted 'hold' previously led to problems.

First thing, I have fixed #2.  So this means you will now get 2 'modify' events rather than 'modify' then 'unhold'.
To test, can you npm install drachtio-srf@beta. ?

Alright I've taken the beta version for a spin. It works as expected for the first hold/unhold, but for subsequent hold/unholds it starts firing the hold/unhold events, instead of modify. I don't know if this is intended?
This is what happens:

HOLD: modify fired
UNHOLD: modify fired
3: HOLD: hold fired
4: UNHOLD: unhold fired

I'm in doubt on how I'm supposed to implement the hold/unhold events, if I was to use them. In dialog.js, we've got the following code:
       if (refresh) {           this.emit('refresh', req);         }         else if (hold) {           this.local.sdp = this.local.sdp.replace(/a=sendrecv\r\n/g, 'a=recvonly\r\n') ;           this.emit('hold', req) ;         }         else if (unhold) {           this.local.sdp = this.local.sdp.replace(/a=recvonly\r\n/g, 'a=sendrecv\r\n') ;           this.emit('unhold', req) ;         }         if ((refresh || hold || unhold) || (modify && 0 === this.listeners('modify').length)) {           debug('responding with 200 OK to reINVITE') ;           res.send(200, {             body: this.local.sdp,             headers: {               'Contact': this.local.contact,               'Content-Type': 'application/sdp'             }           }) ;         }         else if (modify) {           this.emit('modify', req, res) ;         }
When it fires hold/unhold it does some modification on the localsdp based on a stringe replacement, and then that result is returned to the UAC? I need to pass this SDP through RTP Engine, pass it to Asterisk, and then pass Asterisk's answer through RTP Engine, and then return that to the UAC.

Right, so you need a feature to completely disable the hold/unhold features.  I will wok on that next

What about if it only do this internal hold/unhold logic if those events are actually subscribed?
Downside I guess is that it would change the current behaviour for those who rely on this logic even if they're not subscribed for those events. They don't appear to be in the documentation though?

Yes, I kind of like that approach

addressed in 4.4.19


Now with real tool calling

With this addition function signatures written once in rust can be sent as JSON to a tool calling LLM (only ollama tested right now) and tool calls from the LLM API response can call said functions. All without typing the function name, the arguments or the types of the arguments more than once.
There are some error handline and type conversion issues remaining, along with the need for a helper function to parse the returned JSON (or perhaps use ollama-rs).

closes #4


Allow ipv6 config

Allow ipv6 configuration of node ifaces.
Currently, only enabling/disabling ipv6 is allowed

/verified


seed is not executed in priority order

I have three seeders and these are executed in random order without taking the priority value

can you please give more details about your issue
it will be fixed as soon as we can check the reasons
and please try to use the latest version if you have an earlier version
thank you for your contribution ^_^

@raulodev


Make more compatible OCI images

👍

If we can get this tool working I think many people in the Erlang community will find it useful. Especially now that containers have become the easiest way to deploy Erlang/OTP applications to cloud platforms.


add external references to the Beam Community page

There's lots of good third party content out there about Beam; we should highlight it as well:
https://stackoverflow.com/questions/tagged/apache-beam
https://towardsdatascience.com/tagged/apache-beam

Imported from Jira BEAM-12972. Original Jira may contain additional context.
Reported by: sachinag.

The StackOverflow page is already in the Join the Conversation section of the Community page: https://beam.apache.org/community/join-beam/


Please SYNC adapter Repo to current LATEST

Currently this adapter is listed with version 2.8.2 at npmjs while this repository is at level 2.70 (2 years older).
The effective adapter code provided to users is based on fork https://github.com/GermanBluefox/ioBroker.rssfeed.
There is a PR (https://github.com/oweitman/ioBroker.rssfeed/pull/55) to sync created by bluefox.
Please resync as fast as possible as this situation is blocking update of stable repository and is inaczeptable for latest repository too.
If you do not plan to maintain this repo, we can adapt the repository links to the real source of the adapter.
If you have any questions on how to synchronize, please contact @GermanBluefox
Please react  until 07.06.2024 as we could decide to change repository entries if no action / reaction occures

iobroker.rssfeed 2.9.1 is available on npm.js


Set up CI with Azure Pipelines

This pull request introduces 1 alert and fixes 2 when merging c648ebba5569ce77292d480d979d773e2bdb9b7a into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging f5cb909e05270dcb18812a7a77b480f291686b44 into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging 82cf36ed59f7ea8f53838cde91937e0b7f67f214 into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging cc31686962a315ead48d81b795e865f08098da6d into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging fa03fed9f9b8f79293ab85ce07b18da73f7483c0 into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging 126e8fd35ee84ba61dabcdd4de70053d117e8ec2 into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging e12d848b49608c0addb9ccac4cab674716d605b3 into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging af9b6e7b29fc72ce8e7f41f6e1e29881581a23cd into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging 9449a658a7b430d0991ecb172670d5c2f2b127ae into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 2 when merging 0771b9bb6fabfc394041914a66d5665e8dbd7077 into 6353f105af9641e3c4f48ac01bf5f2549403ca2a - view on LGTM.com
new alerts:

1 for Unreachable code

fixed alerts:

2 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com


Create Battle UI

Create the Battle UI that the Users will see while playing.

Resolved on the following commit: https://github.com/BraisGlezArias/TheHeroNeverDies/commit/932f809ab1b196320133b9a3d68ebaef60423ef7


[Chip] Delete icon ripple not visible for Chip when background color is set

This issue is a bug report.
Chip with backgroundColor set, and delete icon, will not display the ink response in the foreground.
Steps to Reproduce
Chip(
        backgroundColor: Colors.pink,
        label: Text('Test'),
        onDeleted: () {},
)

Go to flutter_gallery under Chips and delete a chip with a background color set
The icon ripple is then not visible
If you do the same for a chip that does not have a background color, it shows it correctly

The ink response is behind the chip (with background color set):
On a chip without background color the ink response is visible:

Logs

$ flutter doctor -v
Downloading android-arm-profile/darwin-x64 tools...                 0.9s
Downloading android-arm-release/darwin-x64 tools...                 0.7s
Downloading android-arm64-profile/darwin-x64 tools...               0.8s
Downloading android-arm64-release/darwin-x64 tools...               0.7s
[✓] Flutter (Channel master, v1.10.1-pre.309, on Mac OS X 10.14.6 18G95, locale en-DE)
    • Flutter version 1.10.1-pre.309 at /Users/perc/development/flutter
    • Framework revision 1696975ef3 (24 minutes ago), 2019-09-27 11:39:41 +0200
    • Engine revision 18bc0b2596
    • Dart version 2.6.0 (build 2.6.0-dev.0.0 403c4af720)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/perc/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-stable, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.3, Build version 10G8
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio with Blaze.app/Contents
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (1 available)
    • iPhone Xʀ • FAA0F7B9-5367-4003-90C4-866BC84154F8 • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-4 (simulator)

• No issues found!

This is the same issue as #36133.

This issue can be fixed with https://github.com/flutter/flutter/pull/41463, but we do no longer have any ripples on chips with only onDeleted set (see issue), thus the tests in the pull requests fails on master.
After the issue 43534, and we have ripples with only onDelete again, the already existing pull request can be re-merged to master.

Issue still exist
Code Sample
// Flutter code sample for DeletableChipAttributes.onDeleted

// This sample shows how to use [onDeleted] to remove an entry when the
// delete button is tapped.

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

/// This Widget is the main application widget.
class MyApp extends StatelessWidget {
  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: Center(
          child: MyStatefulWidget(),
        ),
      ),
    );
  }
}

class Actor {
  const Actor(this.name, this.initials);
  final String name;
  final String initials;
}

class CastList extends StatefulWidget {
  @override
  State createState() => CastListState();
}

class CastListState extends State<CastList> {
  final List<Actor> _cast = <Actor>[
    const Actor('Aaron Burr', 'AB'),
    const Actor('Alexander Hamilton', 'AH'),
    const Actor('Eliza Hamilton', 'EH'),
    const Actor('James Madison', 'JM'),
  ];

  Iterable<Widget> get actorWidgets sync* {
    for (Actor actor in _cast) {
      yield Padding(
        padding: const EdgeInsets.all(4.0),
        child: Chip(
          avatar: CircleAvatar(child: Text(actor.initials)),
          label: Text(actor.name),
          backgroundColor: Colors.white,
          onDeleted: () {
            setState(() {
              _cast.removeWhere((Actor entry) {
                return entry.name == actor.name;
              });
            });
          },
        ),
      );
    }
  }

  @override
  Widget build(BuildContext context) {
    return Wrap(
      children: actorWidgets.toList(),
    );
  }
}

class MyStatefulWidget extends StatefulWidget {
  MyStatefulWidget({Key key}) : super(key: key);

  @override
  _MyStatefulWidgetState createState() => _MyStatefulWidgetState();
}

class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  @override
  Widget build(BuildContext context) {
    return CastList();
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.4 19E266,
    locale en-GB)
    • Flutter version 1.12.13+hotfix.9 at /Users/taha/Code/flutter_stable
    • Framework revision f139b11009 (3 days ago), 2020-03-30 13:57:30 -0700
    • Engine revision af51afceb8
    • Dart version 2.7.2

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • SM M305F • 32003c30dc19668f • android-arm64 • Android 10 (API 29)

• No issues found!

Reproducible on the latest versions of flutter.

video
https://user-images.githubusercontent.com/88313112/176665079-69ba9e39-a30c-4e6c-bff1-fd759908f944.mov

code sample
// Flutter code sample for DeletableChipAttributes.onDeleted

// This sample shows how to use [onDeleted] to remove an entry when the
// delete button is tapped.

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

/// This Widget is the main application widget.
class MyApp extends StatelessWidget {
  static const String _title = 'Flutter Code Sample';

  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: const Center(
          child: MyStatefulWidget(),
        ),
      ),
    );
  }
}

class Actor {
  const Actor(this.name, this.initials);
  final String name;
  final String initials;
}

class CastList extends StatefulWidget {
  const CastList({super.key});

  @override
  State createState() => CastListState();
}

class CastListState extends State<CastList> {
  final List<Actor> _cast = <Actor>[
    const Actor('Aaron Burr', 'AB'),
    const Actor('Alexander Hamilton', 'AH'),
    const Actor('Eliza Hamilton', 'EH'),
    const Actor('James Madison', 'JM'),
  ];

  Iterable<Widget> get actorWidgets sync* {
    for (Actor actor in _cast) {
      yield Padding(
        padding: const EdgeInsets.all(4.0),
        child: Chip(
          avatar: CircleAvatar(child: Text(actor.initials)),
          label: Text(actor.name),
          backgroundColor: Colors.white,
          onDeleted: () {
            setState(() {
              _cast.removeWhere((Actor entry) {
                return entry.name == actor.name;
              });
            });
          },
        ),
      );
    }
  }

  @override
  Widget build(BuildContext context) {
    return Wrap(
      children: actorWidgets.toList(),
    );
  }
}

class MyStatefulWidget extends StatefulWidget {
  const MyStatefulWidget({Key? key}) : super(key: key);

  @override
  _MyStatefulWidgetState createState() => _MyStatefulWidgetState();
}

class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  @override
  Widget build(BuildContext context) {
    return CastList();
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.3, on macOS 12.4 21F79 darwin-arm, locale en-GB)
    • Flutter version 3.0.3 at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 676cefaaff (5 days ago), 2022-06-22 11:34:49 -0700
    • Engine revision ffe7b86a1e
    • Dart version 2.17.5
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.68.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (3 available)
    • M2007J20CG (mobile) • 5dd3be00 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)     • macos    • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)        • chrome   • web-javascript • Google Chrome 102.0.5005.115

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1442, on macOS 12.4 21F79 darwin-arm, locale en-GB)
    • Flutter version 3.1.0-0.0.pre.1442 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision caadc255b7 (8 hours ago), 2022-06-30 10:50:05 +0800
    • Engine revision 870bc6062c
    • Dart version 2.18.0 (build 2.18.0-238.0.dev)
    • DevTools version 2.14.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E500a
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.68.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 103.0.5060.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Any update ?,  the ripple it still shows behind the chip with background color in Flutter 3.7


chore(deps): updated yarn.lock to fix yarn workspace app add command error

What does this PR do?
chore(deps): updated yarn.lock to fix yarn workspace app add command error
This fix excludes fix for ""@janus-idp/shared-react@2.6.3":" as it's been included in #1731
Signed-off-by: Yi Cai<EMAIL_ADDRESS>Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
error when run yarn workspace app add command
For example:
error Invariant Violation: expected workspace package to exist for "@babel/core"
    at invariant (/opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:2318:15)
    at _loop2 (/opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:91024:9)
    at PackageHoister.init (/opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:91083:19)
    at PackageLinker.getFlatHoistedTree (/opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:48552:20)
    at PackageLinker.<anonymous> (/opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:48563:27)
    at Generator.next (<anonymous>)
    at step (/opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:310:30)
    at /opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:328:14
    at new Promise (<anonymous>)
    at new F (/opt/homebrew/Cellar/yarn/1.22.21/libexec/lib/cli.js:5540:28)

How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:

[x]  The Eclipse Contributor Agreement is valid
[x]  Code produced is complete
[x]  Code builds without errors
[ ]  Tests are covering the bugfix
[x]  The repository devfile is up to date and works, if one exists
[x]  Sections What issues does this PR fix or reference and How to test this PR completed
[ ]  Relevant user documentation updated
[ ]  Relevant contributing documentation updated
[ ]  CI/CD changes implemented, documented and communicated

Reviewers
Reviewers, please comment how you tested the PR when approving it.

yarn lock update also included in #1731 because the PR failed without it. Assuming I can safely close this; if that's wrong and you want to rebase it, please reopen and do so.

@nickboldt #1731 doesn't have the fix this PR provides. Reopened it. Please take a look. Thanks.

Oh I don't have the access to reopen this PR. Can you help me with it?

Seems I can't reopen it either. Can you create a new one that doesn't have merge conflicts?

Raised ##1735 for the same fix.


Adding a method to get all tracks given an album

Small change to have an option to find tracks given an album, something like:
https://api.spotify.com:443/v1/search?q=album:Sonic Highways&type=track

I've added the invalid tag because this feature was merged into branch v2_requests, but not into the master branch yet. This way I have a better overview over all PRs.


Fix backend compatibility with QEMU as frontend

Wasn’t sure whether to PR this here or to @arronwy’s dragonball branch, which I see is a PR to rust-vmm’s copy of the repo.
I’ve been trying to use cloud-hypervisor’s vhost-user-net backend with QEMU. In doing so, I’ve found a few compatibility problems resulting from cloud-hypervisor not quite correctly following the vhost-user spec. This series contains the changes to this crate required to use the cloud-hypervisor vhost-user-net with QEMU. There’s another thing that’ll have to be fixed in the cloud-hypervisor tree itself.

Fixed in 2e4396c9ccd38afa05078826e41857ed03559b23.


Using with Echo?

Greetings
Is it possible to use this library with Labstatck's Echo framework?
TIA

Hi, yes, there's an example here.

Thanks for your answer. I've tried the example but got this error:
send on closed channel in sse.go line 82:
		c := newClient(lastEventID, channelName)
		s.addClient <- c
		closeNotify := response.(http.CloseNotifier).CloseNotify()

What am I doing wrong?

OK I found it, I left "defer shutdown" in the caller, sorry.


Conditional cast from 'any Error' to 'any Equatable' always succeeds... but doesn't

Description
The compiler tells me that the cast from 'any Error' to 'any Equatable' always succeeds, but then tells me that it doesn't.
Reproduction
enum SomeError: Error {
	case error
}

let t: any Error = SomeError.error

func needsEquatable<E: Equatable>(e: E) {
}

if let t = t as? (any Equatable) { // Warning: Conditional cast from 'any Error' to 'any Equatable' always succeeds
	needsEquatable(e: t)
}

needsEquatable(e: t) // Error: Global function 'needsEquatable(e:)' requires that 'E' conform to 'Equatable'

Expected behavior
I don't think that Error is Equatable, so the warning is probably wrong.
Environment
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Additional information
No response

@AnthonyLatsis this one seems to have been overlooked. This is still an issue in Xcode Version 16.0 beta 4 (16A5211f).

+1


new REST APIs has a  link which is broken

new REST APIs has a  link which is broken
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 413163f0-28c3-a2a7-d626-fcb81bcb2257
Version Independent ID: 57c127da-2b1e-d29e-9abb-a3c258762ccf
Content: .NET Client Libraries for Azure DevOps Services (and TFS)
Content Source: docs/integrate/concepts/dotnet-client-libraries.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

@ranjan-ranjan @elbatk, this is interesting. PR #1283 by @eriawan should have fixed this.
If you click the .md content source file, it shows you the correct link.

But on the live page it still shows the old link, hence this issue.

Any thoughts?

It's been a while, but I've fixed this issue! :)

I've just completed a PR, fixing this link, which should go live sometime this morning. Until then, here's the link.


Cluster plugin

Is the cluster plugin capable of handling a few thousands of points ?

There are two options for clustering. One way is to add a geoJson source and then using runtime styling to cluster or to use the clustering plugin found in the repo. Since this tickets stale, going ahead and closing

@cammace Not much idea about GeoJSON. Are you suggesting geojson would give faster results ?

Yes, using runtime styling to handle clustering is significantly more performant. Have a look at this example


Fail to run basic example

Run basic example on Windows 8, python 3.5.1
aiodns==1.0.1
aiohttp==0.21.5
chardet==2.3.0
maxminddb==1.2.0
proxybroker==0.1.2
pycares==1.0.0
Error message:

D:\Temp\proxybroker\venv\Scripts\python.exe D:/Temp/proxybroker/example.py
Traceback (most recent call last):
File "D:/Temp/proxybroker/example.py", line 7, in
broker = Broker(proxies, loop=loop)
File "D:\Temp\proxybroker\venv\lib\site-packages\proxybroker\api.py", line 45, in init
self._setup(timeout, attempts_conn, max_concurrent_conn, verify_ssl)
File "D:\Temp\proxybroker\venv\lib\site-packages\proxybroker\api.py", line 53, in _setup
self._loop.add_signal_handler(signal.SIGINT, self._done)
File "D:\ProgramFiles\Python35\lib\asyncio\events.py", line 472, in add_signal_handler
raise NotImplementedError
NotImplementedError

@fygul thank you for feedback!
The error raised because the function add_signal_handler() is not supported on Windows  =(
I made the necessary fix in release 0.1.3. Please update your version and it will work.

New version works, it's amazing.

still getting that error
`From cffi callback <function _sock_state_cb at 0x03A8F970>:
Traceback (most recent call last):
  File "C:\users\user\appdata\local\programs\python\python38-32\lib\site-packages\pycares\__init__.py", line 91, in _sock_state_cb
    sock_state_cb(socket_fd, readable, writable)
  File "C:\users\user\appdata\local\programs\python\python38-32\lib\site-packages\aiodns\__init__.py", line 104, in _sock_state_cb
    self.loop.add_reader(fd, self._handle_event, fd, READ)
  File "C:\users\user\appdata\local\programs\python\python38-32\lib\asyncio\events.py", line 501, in add_reader
    raise NotImplementedError
NotImplementedError`


Support for html attributes on Rails helpers

Thanks for taking the time to write this plugin!
For my use case, I would love to see support for Alpine in Rails helpers, like this:

<%= form_with @model, html: { "x-data": "Alpine comes here"  } %>

I know you haven't had the motivation to maintain this for the last few years (and have no obligation to do so, either!) so even though I don't know Kotlin I would love to help you out and try to write, or help write, the code to make this possible.
From what I can tell from reviewing the code base, it currently relies on standard IntelliJ modules to parse HTML, right? So the first question would be if there's a standard IntelliJ way to parse html attributes in Rails helpers, or if I have to write a regex or something to parse them? Does anyone know?

Hm. I know nothing about Rails or how IntelliJ handles Ruby. I would assume there's some language injection component, so I'd look into figuring out how to tell the IDE where to inject JS into that snippet. That's really all the plugin does right now (it's just telling the IDE that everything inside the x-data attribute is JS and providing a little context).


source_sink `library(log4p)' does not exist

This pertains to prolog_lsp.pl
I'm using vscodium, windows

ah, I think @devolskii this is a matter of installing the log4p package first. I don't think swi-prolog auto-installs dependencies (at least not by default).
Try doing a pack_install(log4p) and then giving it a shot again?
I'll try to dive in a little more, too

and super sorry for the delay!

Actually, swi-prolog (as of at least 9.x) does auto-install dependencies.


ERROR not found errors

Hi @janczizikow ,
I have similar problem as @spsharman #11 . I executed all steps as described in the [Installation] (https://github.com/janczizikow/sleek) description . Only the start/Home site seems to work well, for all other sites (for example: contact) i got the following errors:
Configuration file: /home/micha/roszak/sleek/_config.yml
            Source: /home/micha/roszak/sleek
       Destination: /home/micha/roszak/sleek/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 0.473 seconds.
 Auto-regeneration: enabled for '/home/micha/roszak/sleek'
    Server address: http://<IP_ADDRESS>:4000/sleek/
  Server running... press ctrl-c to stop.
[2018-08-01 16:38:05] ERROR `/404/index.html' not found.
[2018-08-01 16:38:05] ERROR `/about/index.html' not found.
[2018-08-01 16:38:05] ERROR `/assets/img/icons/android-chrome-256x256.png' not found.
[2018-08-01 16:38:05] ERROR `/assets/css/main.css' not found.
[2018-08-01 16:38:05] ERROR `/assets/img/icons/android-chrome-192x192.png' not found.
[2018-08-01 16:38:05] ERROR `/assets/img/favicon.jpg' not found.
[2018-08-01 16:38:07] ERROR `/sw.js' not found.

Do you have any idea, what could be wrong? Many Thanks.

Issue is solved.


Add warning for no checkbox selected

If the user searches without selecting any checkbox in the field we should give them warning that no checkbox selected.
We intend to create a status bar towards the bottom of extension in the footer div. If user has not mentioned search query we will mention it there. If user has not ticked checkbox same for that. So basically we intend to create a feedback status bar towards the bottom of the extension. Keeping everything inside the popup window only.

CLosed with dd7146d7d049832ee9fb6b7e5bb41c8ef978856c


[RabbitMQ]Component is lost from library and flow

Test case
Instance: next
Tenant: Regression Tests
Flow: RabbitMQ_Send

Moved to frontend


Update overview-database-templates.md - new Azure Synapse database te…

…mplates available
Five more industries now available:
Agriculture
Energy & Commodity Trading
Freight & Logistics
Oil & Gas
Utilities
https://techcommunity.microsoft.com/t5/azure-synapse-analytics-blog/new-azure-synapse-database-templates-in-public-preview/ba-p/2955431

@isdataninja : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@gsaurer bump! are we waiting on anything else on this? please advise.

#reassign:@SnehaGunda please review this public PR

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver , @SnehaGunda, 4 more announced today!

Automotive Industries
Genomics
Manufacturing
Pharmaceuticals

https://techcommunity.microsoft.com/t5/azure-synapse-analytics-blog/four-additional-azure-synapse-database-templates-now-available/ba-p/3058044


Bump @types/react and csstype

Description
Bump @types/react and csstype

These are needed to be kept in sync with OSD's.
Switch css-loader to an alternate to match that of OSD's, just in case.

Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] All tests pass

[ ] yarn lint
[ ] yarn test-unit

[ ] Update CHANGELOG.md
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This looks fine - but it still doesn't fix the OSD build issues?

No OSD needs changes too.


Fix strict mode errors

Fixes #550. Sorry about the end-of-line spacing changes, my editor seemed to do that automatically for some reason.

It is no surprise, but this also solves the problem with node 0.12.0.
However, I wonder if this wouldn't be better to explicitly check for "object" instead of an inequality with "string". I could try myself, but right now, I'm back to v0.10.36 ;-)

Thanks a lot for your contribution @andrewbranch - we appreciate it a lot! This really should make it into a new release as soon as possible :+1:
Before we can merge this, I'll have to ask you to revert all unnecessary changes (like the end-of-line changes, etc.) so that we can keep our Git History clean and don't clutter it with changes which shouldn't be in history (the history should show only real code changes, nothing more).
Also, I guess it would be of further value, if you could add a line in our .travis.yml file to include node v0.12.0 for testing along with your commit. If you do so, please amend and force push, or squash and force push your changes as we request 1 commit per PR as stated in our Guidelines for Submitting a Pull Request.

@mdhooge — I agree; changed to object.
@herom — I’m not sure how to overwrite commits I already pushed to GitHub. You can see that what I just tried kind of made things messier—my apologies. Would it be easiest to delete this PR and start a fresh one? Sorry for the inconvenience.

Fixed the commit history, but it looks like there are other issues arising with newer node versions. Working on adding fixes to the pull.

Most of the failing tests from the last build were caused by server.address().address() returning ::. I have no idea what that’s about, but I checked for it and replaced with <IP_ADDRESS>. However, there are still two failing tests that I don’t know how to fix. Would appreciate help from someone more familiar with the project.

It looks like you can fix the error by copying the conditional you used in server-test.js to the beforeEach of ssl-test.js, namely:
if (test.server.address().address === '<IP_ADDRESS>' || test.server.address().address === '::') {
I didn't checkout your branch to confirm, but that looks to be the issue.

Everything looks good now! Thanks to @mdhooge, @herom, and @robertjneal for the input/guidance!

Thanks a ton @andrewbranch :dancers:

@herom My pleasure—one step closer to using io.js on Heroku!


Does it work with submodules?

Typically I use modules within nn.Sequential or custom-defined modules.
class TwoLayerNet(torch.nn.Module):
    def __init__(self, D_in, H, D_out):
        super(TwoLayerNet, self).__init__()
        self.fc = torch.nn.Sequential(
            torch.nn.Linear(D_in, H),
            torch.nn.Linear(H, D_out)
        )

    def forward(self, x):
        return self.fc(x)

and then layers = model.parameters(). However, I get an error:
Traceback (most recent call last):
  File "example_submodule.py", line 43, in <module>
    stats = CheckLayerSat('regression/h{}'.format(h), layers)
  File "/Users/pmigdal/not_my_repos/delve/delve/main.py", line 50, in __init__
    self.layers = self._get_layers(modules)
  File "/Users/pmigdal/not_my_repos/delve/delve/main.py", line 167, in _get_layers
    for name in modules.state_dict().keys():
AttributeError: 'generator' object has no attribute 'state_dict'

(for full code example, see: https://gist.github.com/stared/b598c03ade397baf3fa03c52bd79e90d)
Does it work with submodules?

@justinshenk Awesome! And I am impressed by your pace. :)


[ Application ] Add android resnet application example

This PR includes the android resnet application example with cifar100 dataset. The dataset is not included becuase of the size of dataset, but user can download and set properly into asset direcotry in application.
This applicaiton demonstrate how nntrainer is used in android application through JNI interface and train, test, stop during processing, and inferencing.
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2149. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @jijoongmoon, Applications/Android/ResnetJNI/app/src/main/jni/resnet_jni.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @jijoongmoon, The last line of a text file must have a newline character. Please append a new line at the end of the line in Applications/Android/ResnetJNI/.idea/compiler.xml.

:octocat: cibot: @jijoongmoon, Applications/Android/ResnetJNI/app/src/main/jni/resnet.cpp includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

:octocat: cibot: @jijoongmoon, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2149-202303201015360.79067492485046-32f3d3971e5cc35d8a1a97e6222f23cb5311b4c5/.

:octocat: cibot: @jijoongmoon, Applications/Android/ResnetJNI/app/src/main/jni/image.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @jijoongmoon, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2149-202303201052240.72631311416626-ce1816f6f2777c5342f4409416425dc40181124f/.


Snapshot Mints Error

Error :
2022-02-08T11:34:46Z WARN  metaboss] Using a public RPC URL is not recommended for heavy tasks as you will be rate-limited and suffer a performance hit.
Please use a private RPC endpoint for best performance results.
Error: HTTP status client error (410 Gone) for url (https://api.mainnet-beta.solana.com/)
Caused by:
HTTP status client error (410 Gone) for url (https://api.mainnet-beta.solana.com/)

That endpoint is now blocking calls to the token-metadata program so you need to use a different one. Check out this list to find a custom one: https://docs.metaplex.com/community#rpc

how to use my custom RPC in this command "metaboss snapshot mints --candy-machine-id <CANDY_MACHINE_ID/CREATOR> --output <OUTPUT_DIR>"

how to use my custom RPC in this command "metaboss snapshot mints --candy-machine-id <CANDY_MACHINE_ID/CREATOR> --output <OUTPUT_DIR>"

"metaboss snapshot mints -r <RPC_URL> --candy-machine-id <CANDY_MACHINE_ID/CREATOR> --output <OUTPUT_DIR>"

error: Found argument '-r' which wasn't expected, or isn't valid in this context
USAGE:
metaboss.exe snapshot mints [FLAGS] [OPTIONS]
For more information try --help


Progress of jobs are not working in IE11/Edge

Hi!
Progress of builds is not working on IE11/Edge webbrowser (Unfortunately we are obliged to use them on our TV for monitoring master).
We were able to fix that with this workaround:
in controllers.js
directive('animateOnChange', ['$animate', '$timeout', function($animate, $timeout) {
    return function(scope, elem, attr) {
        scope.$watch(attr.animateOnChange, function(newValue, oldValue) {
            if (newValue !== oldValue) {
                var cssClass = 'updated';

                elem[0].style.width = newValue + '%';  //------> THIS LINE IS ADDED

                $animate.addClass(elem, cssClass).then(function() {
                    $timeout(function() {
                        $animate.removeClass(elem, cssClass);
                    }, 5);
                });
            }
        });
    }
}]).

And progress starts to working on IE11/Edge.
However I'm not sure if that solution is ok to make PR from it :)
Regards

Hey @khipis, yeah, that could work, but I think the problem you're seeing has something to do with how IE interprets angular's directives - angular/angular.js#2186
I've just tweaked the implementation slightly, would you mind letting me know if the latest build works better for you?
Thanks,
Jan

Yeah, thank you, I will back with feedback as soon as possible (probably end of next week) cheers

Brilliant, if it's all good for you I'll push an update.

Hi, sorry for late response.
But now it's confirmed - your solution for this problem works pretty well. Progress is showing on IE11/Edge now.
Thank you very much :+1:

Great stuff, thanks for the confirmation. I'll push the latest build to the Update Centre shortly.


Add support for array-valued attributes

See https://github.com/open-telemetry/opentelemetry-specification/pull/368

As long as I'm looking at this: There seem to be a number of places where the type of attributes is not being validated, for example https://github.com/open-telemetry/opentelemetry-ruby/blob/master/api/lib/opentelemetry/trace/event.rb#L39
Should I add validation in these places, raising ArgumentError in cases where attributes is invalid?

Having the observability system raise runtime exceptions is frowned upon see: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/error-handling.md. The preferred approach is to use defaults or discard data that doesn't conform and log a message about it.

Another trend you may notice, is that validating data can sometimes be expensive to do up front, and since data is sampled, it often is more efficient to validate, drop or correct data on export.


Fixed references to Accidental and AccidentalType

I noticed that fa clefs were not working when the chant contained a ti/te, and the exception getting thrown indicated that it would be a fairly simple fix, so I thought I might as well submit a pull request.  Exceptions were also getting thrown on clefs with accidentals, so I changed two lines affecting that as well.
Great work on this, Father!

Thanks @bbloomf!


change cert serial format

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

23 of 25 (92.0%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-2.1%) to 86.74%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/biz/tpm_cert_verifier.go
23
25
92.0%

Files with Coverage Reduction
New Missed Lines
%

service/biz/tpm_cert_verifier.go
8
83.67%

Totals

Change from base Build<PHONE_NUMBER>:
-2.1%

Covered Lines:
314

Relevant Lines:
362

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

23 of 25 (92.0%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-2.1%) to 86.74%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/biz/tpm_cert_verifier.go
23
25
92.0%

Files with Coverage Reduction
New Missed Lines
%

service/biz/tpm_cert_verifier.go
8
83.67%

Totals

Change from base Build<PHONE_NUMBER>:
-2.1%

Covered Lines:
314

Relevant Lines:
362

💛  - Coveralls


[Feature][Module Name] Global Param passed by sense dependencies

the param of task requires optimization,Need according to the dependency relationship between the nodes pass a variable's value, different depend on the chain of nodes before there is the same but different meanings, parameters can be distinguished from processInstance. GlobalParam, taskInstance. LocalParam

Can we determine the value of param1 in Task2's varpool ? It may come from Task1 or generate by Task2

Can we determine the value of param1 in Task4's varpool?

The varpool might be huge in the back task, and they save the same data.

Suggestion

thanks for you suggestion.
1.The Direct of the params that  generate in the Task2 is OUT,and the Direct the params that get form the Task1 is IN.So we can  determine the source of this value by the Direct of the params.I think this is the same way with your suggestion.
2.When the previous tasks have the same param name,we will use the value which is't null.If more than two values are non-null,we will use the value that the earliest task's varpool.
3.This is the question of this plan ,We will optimize this issue in the future
So far I have finished coding,and will It will be submitted in a few days

close by #5691 5603


Reproduce the scores in the paper

I read your paper and tried to reproduce the scores shown in the paper.
However, I could not get those scores. Could you give me any idea to reproduce the scores on GQA (val: 73.6, test-dev: 72.1)?
I followed the instruction in this repository and got the score 71.43 (99.86) with test.sh.
Does split 'val' produce the score for val (should be 73.6)?
With split 'test', I got the following error.
Traceback (most recent call last):
  File "evaluate.py", line 159, in <module>
    eval_cfrf_score, _, _, _, bound = evaluate(model, eval_loader, args)
  File "src/FFOE/train.py", line 158, in evaluate
    for i, (v, b, w, e, attr, q, s, a, ans) in enumerate(dataloader):
ValueError: too many values to unpack (expected 9)

I really appreciate it if you could answer my question.

I have questions about their results too. In their original paper, there is no mention of integrating LXMERT into their model. In the code base, the model is already LXMERT-integrated. No way to verify the performance of their method before integration.