Possibility and necessity of auto-generating CoinType+Address.swift from TWHRP.cpp and Coin.cpp

Would that be better or necessary that CoinType+Address.swift could be auto-generated from TWHRP.cpp and Coin.cpp?
There could be some benifits of doing so.

C++ implementation would just work for Swift.
Implementation discrepancies as follows could be eliminated.

CoinType+Address.swift
        case .bitcoin, .litecoin, .viacoin, .qtum, .digiByte, .ravencoin:
            if let addr = SegwitAddress(string: string), addr.hrp == hrp {
                return addr
            } else if let addr = BitcoinAddress(string: string), prefixSet.contains(addr.prefix) { return addr }

Coin.cpp
    case TWCoinTypeBitcoin:
        return Bitcoin::SegwitAddress(publicKey, 0, HRP_BITCOIN).string();

duplicated with #449


Phaser is not rendering inside time callback nested in a tween

Phaser: 2.6.2
I have a function fire_event() outside update(). Inside this function, I do these things:
function fire_event(){
    my_flag = false;
    do_stuff_1();
    game.add.tween(sprite).to( { alpha: 1.0 }, Phaser.Timer.HALF, Phaser.Easing.Linear.None, true).onComplete.addOnce(function(){
        game.time.events.add(Phaser.Timer.HALF, function(){
            do_stuff_2();
            game.add.tween(sprite).to( { alpha: 0.0 }, Phaser.Timer.HALF, Phaser.Easing.Linear.None, true).onComplete.addOnce(function(){
                my_flag = true;
            }, this);
        }, this);
    }, this);
}

function update(){
    if(my_flag){
        do_update_stuff();
    } else {
        //do nothing
    }
}

Everything that need to be rendered on function do_stuff_2(), is not rendering... only when the most inner tween finishes things got rendered. Everything go rendered, till the code reaches do_stuff_2().
In short words: do_stuff_2() removes sprites from groups, then add new layers to them, and change some sprites position.
The thing is, everything inside do_stuff_2() only happens when the tween under do_stuff_2() finishes.
The inner tween makes alpha channel goes from 1 to 0 immediately.
The problem happens always in the fade out. Fade in works.
QUESTION:
Does a time event inside a tween, like the example above, make things do not render excepting when everything is finished? Don`t things get rendered when I nest callbacks?

Instead of using a timer, I also tried using tween delay. Also didn't work:
function fire_event(){
    my_flag = false;
    do_stuff_1();
    game.add.tween(sprite).to( { alpha: 1.0 }, Phaser.Timer.HALF, Phaser.Easing.Linear.None, true).onComplete.addOnce(function(){
        do_stuff_2();
        game.add.tween(sprite).to( { alpha: 0.0 }, Phaser.Timer.HALF, Phaser.Easing.Linear.None, true, Phaser.Timer.HALF).onComplete.addOnce(function(){
            my_flag = true;
        }, this);
    }, this);
}

Detailed info about functions if needed:
do_stuff_2():
underlayer_group.removeAll(); //clear group
overlayer_group.removeAll(); //clear group
map_name = current_event.target; //thats just a string
maps[map_name].setLayers(underlayer_group, overlayer_group); //I'll provide a more details on it, but it basically add new layers to these groups
hero.body.x = current_event.x_target * maps[map_name].sprite.tileWidth; //hero is a sprite. Changing it x position
hero.body.y = current_event.y_target * maps[map_name].sprite.tileHeight; //hero is a sprite. Changing it y position
shadow.x = hero.x;  //shadow is a sprite. Changing it x position
shadow.y = hero.y;  //shadow is a sprite. Changing it y position

//reconfig world physics
game.physics.p2.resume();
map_collider.body.clearShapes();
map_collider.body.loadPolygon(maps[map_name].key_name, maps[map_name].key_name);
mapCollisionGroup = game.physics.p2.createCollisionGroup();
map_collider.body.setCollisionGroup(mapCollisionGroup);
map_collider.body.setZeroDamping();
map_collider.body.setZeroRotation();
hero.body.collides(mapCollisionGroup);
map_collider.body.collides(heroCollisionGroup);
game.physics.p2.updateBoundsCollisionGroup();

setLayers():
setLayers(underlayer_group, overlayer_group){
    this.map_sprite = game.add.tilemap(this.key_name); //set map sprite
    this.map_sprite.addTilesetImage(this.tileset_name, this.key_name); //set tilemap image

    for(var i = 0; i < layers.length; i++){
        var layer = this.map_sprite.createLayer(layers[i].name); //create a layer
        layer.resizeWorld();
        if(layers[i].properties.over != 0) //just test a property to determine which group this layer is going to make part
            overlayer_group.add(layer);
        else
            underlayer_group.add(layer);
    }
}

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


Update move-support-resources.md

(Code: ResourceMoveValidationFailed) Resource move is not supported for resource types 'Microsoft.Datadog/monitors

@mumian

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@shubhamagarwalMSFT - thank you for your contribution.
#sign-off


fix seg fault in logs

Signed-off-by: ivan<EMAIL_ADDRESS>srvRo will be nil when we remove the Service resource, which results iin a SIGSEGV error.
metallb: fix SIGSEGV error when Service resource is deleted.

Thanks for the PR @Inode1! Could you please amend the commit message to something like metallb: fix SIGSEGV error when Service resource is deleted please?

Thanks for the PR @Inode1! Could you please amend the commit message to something like metallb: fix SIGSEGV error when Service resource is deleted please?

Hello, here you are.

/test


Added composer.json so it can be packaged

This way people can use this repo with the composer require command.

Composer is a PHP package manager. jCCV is a JS library. You can use Bower to install and manage it.


Implement parsing await.

Several bugs fixed for parsing yield as well.

Thank you for the review. I fixed the issues.


Support showing Jetton (TEP-74) balance on Ton Network

Jetton Processing: https://docs.ton.org/develop/dapps/asset-processing/jettons
Jetton Metadata: https://docs.ton.org/develop/dapps/asset-processing/metadata
TEP-74: https://github.com/ton-blockchain/TEPs/blob/master/text/0074-jettons-standard.md

merged into
https://github.com/Koniverse/SubWallet-Extension/pull/3386


Re-enabled RealityDataSource test

Re enabled "should get RealityDataSource for reality data attachment in iModel" test.
More test user rights had to be fixed.

/azp run iTwin.js

/azp run iTwin.js Docs - YAML


Performance analysis & Baseline Profiles

should these templates include some dummy Macrobenchmark tests & Baseline Profiles generation?

I lean towards no to keep them simple, but @keyboardsurfer @mlykotom thoughts?

I'm conflicted.
On one hand, I'd say let's have it, because it's almost free performance improvement and it might help people who haven't heard about them.  Ideally we think everyone should generate them for their app, which is a + for having it in the template.
On the other hand, it's not architecture per se.

For maintenance reasons we currently only keep baseline profile generation and macrobenchmarking in the performance samples and Now in Android at the moment. Instead of adding them into the templates at the moment, WDYT of linking to the samples?

any decision on this request?

We're going to keep these templates simple by relying on the official performance samples and NiA. Thank you for the great suggestion!


Rename database url env var

DO NOT MERGE!
It seems like Heroku create an environment variable with datasource data, called DATABASE_URL for review apps. Let's try if they can be properly deployed if we retrieve this info to instantiate data source.

Test concluded


Biber executable cannot be found (texlive-new)

When running
nix-shell -p 'texlive.combine {inherit (texlive) biber scheme-small; }' --pure
the biber executable cannot be found.
I'm using nixpkgs-16.03pre71332.f490186

Yes, that's a known bug, i.e. it hasn't been packaged properly yet as it needs special care unlike most texlive.

Damn. Back to texliveFull. :/

Someone around here claimed the biber executable from the old packaging can be used along with the newly packaged TeX stuff.

@vcunat Do we know who is going to fix this issue, and when?

I know about these open TeX issues, but I don't know when they get to the top of my ToDo, and neither I do know about anyone else planning to solve them (there's the assignee slot for that).

Has anyone got a working version of Biber? I have tried multiple installation combinations (TexLive, TexLive combine, TexLive Full, with and wihtout separate Biber), using 16.03 and unstable channels, but can't get Biber and BibLaTeX to work together.

nix-shell -p biber gives a working biber command.  However, the biber and the latex biblatex packages need to have precisely corresponding versions, see the table here: https://sourceforge.net/projects/biblatex-biber/files/biblatex-biber/current/documentation/biber.pdf/download
Right now we have biber 2.5 and biblatex 2.9a, which are apparently not compatible:
± biber hg.bcf
INFO - This is Biber 2.5
INFO - Logfile is 'hg.blg'
INFO - Reading 'hg.bcf'
Use of uninitialized value $bltxversion in concatenation (.) or string at /nix/store/vdgvbdwax4izpsf91hsf4z07flc80wlq-perl-biber-2.5/lib/perl5/site_perl/5.22.2/Biber.pm line 415.
ERROR - Error: Found biblatex control file version 3.0, expected version 3.1.
This means that your biber (2.5) and biblatex () versions are incompatible.
See compat matrix in biblatex or biber PDF documentation.
INFO - ERRORS: 1

@ttuegel (maintainer): what about updating biber then?

It's actually the other way around: our biber version is too new for biblatex version in texlive.  Either we upgrade biblatex, or we downgrade biber to version 1.9 (if I read the documentation correcly).
Given that these packages are that closely linked, shouldn't biber be packaged as part of texlive then?

Oh, then it might be fixed by https://github.com/NixOS/nixpkgs/pull/16391.

I suppose it could be integrated. I haven't done it because it's considered nontrivial: http://tug.org/texlive/build.html#biber

Oh, then it might be fixed by #16391.

Yes, biber 2.5 corresponds to the biblatex 3.4 in texlive 2016.  We just need to make sure to only upgrade biber when we upgrade texlive.

Yes, it looks like Biber was updated to work with that PR
https://github.com/NixOS/nixpkgs/pull/16391#issuecomment-229350134
If anyone is having the same issue, this package override worked for me:
biber = pkgs.biber.overrideDerivation (
  oldAttrs: rec {
    version = "2.4";
    name = "biber-${version}";
    pn = "biblatex-biber";
    src = fetchurl {
      url = "mirror://sourceforge/project/${pn}/${pn}/${version}/${pn}.tar.gz";
      sha256 = "1gccbs5vzs3fca41d9dwl6nrdljnh29yls8xzfw04hd57yrfn5w4";
    };
  }
);

But for that to work you have to override as a downgrade from Biber 2.5 rather than an upgrade from Biber 1.9, (i.e., use the unstable channel) because 16.03 doesn't seem to have the right Perl dependencies.

@vcunat: could we close this issue now that TeXLive 2016 is integrated?


[Bug] Export-DbaDbRole Not Including Roles For Multiple Databases Specified With -ExcludeFixedRole

Report

Host used

[X] powershell.exe
[X] ISE
[X] VS Code
[ ] Other (please specify)

Errors Received

No errors.
Steps to Reproduce

Export-DbaDbRole -SqlInstance InstanceGoesHere -Database Databases,Go,Here -ExcludeFixedRole  -FilePath ".\Instance.DatabaseRoles.sql"
Expected Behavior

The file "Instance.DatabaseRoles.sql" would have the user-created database roles for the databases "Databases", "Go", and "Here" in one file.
Actual Behavior

The file "Instance.DatabaseRoles.sql" only has the database roles for one database.  (Which database it is looks to be not be related to the order specified.  In actuality, I passed 6 databases in, and only the roles for the 3rd database ended up in the file.)
Including -Append outputs all user database roles.
Not including -ExcludeFixedRole includes all user database roles, along with system ones.
Environmental information
PowerShell Version        : 5.1.19041.906
dbatools latest installed : 1.0.145
Culture of OS             : en-US

SQL Server:
Microsoft SQL Server 2019 (RTM-CU8-GDR) (KB4583459) - 15.0.4083.2 (X64)
	Nov  2 2020 18:35:09
	Copyright (C) 2019 Microsoft Corporation
	Enterprise Edition (64-bit) on Windows Server 2019 Standard 10.0 <X64> (Build 17763: ) (Hypervisor)

us_english

Hi,
I think this is the expected behavior.
Have a look at the documentation:

-FilePath
Specifies the full file path of the output file. If left blank then filename based on Instance name, Database name and date is created.
If more than one database or instance is input then this parameter should normally be blank.

The content of every database is written to the same file. So you want to add -Append or use -Path instead of -FilePath.

I will close this as "no bug" / "works as designed", but you can reopen it if you have further questions.


nixos/version: PRETTY_NAME in /etc/os-release uses the release now

instead of full version to be more suitable for presentation to the user

Motivation for this change
Fix https://github.com/NixOS/nixpkgs/issues/74276
This fits the purpose of PRETTY_NAME more:

A pretty operating system name in a format suitable for presentation to the user. May or may not contain a release code name or OS version of some kind, as suitable. If not set, defaults to "PRETTY_NAME="Linux"". Example: "PRETTY_NAME="Fedora 17 (Beefy Miracle)"".

https://www.freedesktop.org/software/systemd/man/os-release.html
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @edolstra

I wonder if this will fix the VMWare vSphere output... :thinking:

@aanderse they seem to include the whole file, so it would just be different content.
you could start it with strace to see which system call they use to get it. maybe you could add lsb_release to the dependencies to get a cleaner output?

I have never really looked into it. I'm not sure if the vmware client running on the vm reports that info, or if vSphere grabs the data :man_shrugging: A nice to have, but oh well...

@aanderse you can create an issue and maybe someone will look into it.

@davidak it requires someone with vSphere... which is me. My impression is that @peterhoeg and I are among the few only people using NixOS on VMWare. Maybe one day I'll spend a few minutes playing around with it to figure it out.


refactor: use indoc for multiline strings

This PR refactors the code to replace standard multiline strings with the indoc crate, which helps maintain readability and also trims the indentation from the real string (doing that can actually reduce LLM token usage by a bit)

Can you rebase with main and resolve the conflicts :)

Can you rebase with main and resolve the conflicts :)

Done!

Great work!


final version of the Enumerable Methods

Enumerable Methods

Created #my_each
Created #my_all?
Created #my_any?
Created #my_none?
Created #my_count
Created #my_map
Created #my_inject
No Linter Issues

I fixed the issues from the previous PR
I also changed the branch name so I had to create another PR, closed the previous one

fixed all the problems! (hopefully xD)

should be good to go


Add support for asynchronous cacheMap

When dealing with large datasets it would be nice to be able to use also other cache drivers as Redis, memcache etc. as it could be too much for just memory storage, so DataLoader should be able to handle Promise specifically when using get() to retrieve cached Promise on cacheMap ...

This is exactly the issue I have created #23 but I auto-closed it because it's silly.
The purpose of Dataloader is to prevent at most round trips generated by a data source (Redis, PostgreSQL, whatever...) induced by their network nature. So permitting to create a async remote cache goes against the benefit of using Dataloader hence becoming useless.
Strictly speaking Dataloader doesn't realy implement a cache but a memoize mechanism.
If you want a real cache in front of a slow data source/store/base, make it in an upstream batch function.

@vieks it makes sense in how you put it, thank you for explanation & closing issue.

@vieks is correct here. DataLoader's cache is purely a local (in memory per instance) cache. It is not a distributed cache like memcached.
Here is a rough example of how you might implement a "read through" distributed cache with DataLoader:
function loadValue(id) {
  return fastLoader.load(id).catch(err => slowLoader.load(id));
}

let fastLoader = new DataLoader(ids => batchLoadFromMemcache(ids));

let slowLoader = new DataLoader(ids => batchLoadFromSQL(ids).then(values => {
  writeToMemcache(ids, values); // fire and forget
  return values;
}));

Hey Lee, @leebyron
Do you think this concept could be used on the level of the internal Cache Storage?
Thanks.


[SPARK-47597][FOLLOWUP] Streaming: Migrate logInfo with variables to structured logging framework

What changes were proposed in this pull request?
The pr is following up https://github.com/apache/spark/pull/46192
Why are the changes needed?
When I reviewed the spark code, I found that some logs in the streaming module were not fully migrated to the structured logging framework, let's to complete unfinished work.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.

In addition, I found that other modules have similar issues. In another PR https://github.com/apache/spark/pull/46986, I did similar actions, some were omitted, and some were added but did not comply with the new structured log specifications.

cc @gengliangwang

@panbingkun Thanks for the work. There is another pending PR created before this one: https://github.com/apache/spark/pull/46980
Let's hold this one until https://github.com/apache/spark/pull/46980 is merged.

@panbingkun Thanks for the work. There is another pending PR created before this one: #46980 Let's hold this one until #46980 is merged.

Oh, okay, let's hold it first and turn it into a draft state first.


More specific error message when firmware update fails

I had the DNS server not exposed on localhost which caused opnsense to not be able to resolve the update URLs. The error message I got was only: "Connection error."
This is not very specific and was not particularly helpful in finding the cause. It would have been better to return something like "DNS resolution failed".

I'm going to change it to "Failed to connect to the selected mirror." as it could fail for a number of reasons.

Would it be much effort to return the real error cause?
I'm not sure if just altering the generic error message would help people to more easily identify the underlying root cause? (In my case it was the DNS resolution that failed not a real connection problem.)
Or maybe the message could point/hint to the logs one could consult to find out the real problem (I still have no clue which ones those would be).

Define "real error". DNS resolution can fail on typos, suboptimal DNS resolution, IPv6 problems (latent).
We possibly have two errors that are somehow returned by "pkg update -f": DNS resolution failure or connection timeout. Right now we don't see those errors, but that's partly due to the current design.
So the question is not how to show "real errors" but how to help people troubleshoot their setups in a more meaningful way. So the first step would be to ask if the firmware section is the best way to do this?

Agree it's mostly about giving hints where to look for the problem. What really happened behind the scenes gives clues where to look further...
Imho if a problem occurs in the context of a process/action (ie. an attempt of updating the firmware) it should be displayed in that particular context.
Maybe just changing the super generic error message into something
"check DNS resolution on the OPNsense host (https://opnsense.localdomain/diag_dns.php) / check connectivity..."
could help if it's not easily possible to return the real error messages from the executable that fails (wget, curl, ...?).
(I'm aware the provided example text is far from perfect but just as an idea)

Want to limit the process to pkg-update, pkg-install and pkg-upgrade... pulling in other checks/tests will bloat the code, add spurious checks / slowdowns and other problems in parsing these tool's outputs down the road.
What I can easily do is add a "timeout" error that basically means DNS resolution went through but could not update the repository while trying to connect. If that was IPv4 or IPv6 in the end is not visible though..

PS: forcing an unresolvable DNS entry kills most of pkg's defined behaviour making the firmware page more or less unusable. Oh joy. ;)

What I can easily do is add a "timeout" error that basically means DNS resolution went through but could not update the repository while trying to connect. If that was IPv4 or IPv6 in the end is not visible though..

Being able to distinguish between DNS or connectivity issues even only on a high level could indeed already be valuable - that sounds like a good improvement to me.

Thanks for your help and discussion! Now I have:

No address record found for the selected mirror. (breaks check early now)
Could not authenticate the selected mirror. (breaks check early now)
The current package configuration is invalid. (breaks check early now)
Timeout while connecting to the selected mirror. (more or less the previous error)
An error occurred while connecting to the selected mirror. (this one is unspecific on purpose because we don't know what happened, maybe it can not even be triggered but better to catch it than not)

Cheers,
Franco

Awesome! That'll certainly help people to more easily identify potential root causes of problems.
I thank, good job! 👍🏻

Thank you for the report. :)
I don't tknow when this will hit 18.1.x, certainly not the next 1-2 iterations but it will be available before we jump to 18.7.

Given that it's not critical but rather an annoyance this makes a lot of sense. Anyway, looking forward to it ;) thx again


Pipeline Runs + Costs as a potential risk

Note which leads are already processed.

Both IP stakeholders agreed to spend more money on the APIs. That means they really value our work!
Well done, Team!

Create a low prio research task to compare GPT and Tedxtblob (NLTK)


cli command for changing charset also converts unrelated tables

The cli command concrete5 c5:database:charset:set utf8mb4 converts ALL tables to utf8mb4. But since it is a c5: command I had expected it to only target known c5 tables. Instead it converterd additional tables as well.

concrete5 (and the underlying libraries) requires that all the tables in the concrete5 database use the same charset/collation.
If you have tables that are not part of concrete5 you can consider to use another database/connection

concrete5 (and the underlying libraries) requires that all the tables in the concrete5 database use the same charset/collation.

That is perfectly reasonable when you mean the tables that are under control of the CMS. But I have packages that add extra tables and libraries that are under different assumptions.

If you have tables that are not part of concrete5 you can consider to use another database/connection

That isn't always an option. Often a host only provides just one database

why would it be a problem for those other tables to be utf8mb4?

I have packages that add extra tables and libraries that are under different assumptions.

How does your code create these tables? If those tables are created via Doctrine Entities or via Doctrine DBAL, they will have the same charset/collation as the "standard" concrete5 tables.

why would it be a problem for those other tables to be utf8mb4?

If we are looking at severity, then in my specific case it'll probably work fine. Changing other tables then your own adds to my list to make sure the other system uses utf8mb4 or doesn't break if it would. The point I'm trying to make is that I can't trust concrete5 to behave as expected if it just takes a hammer and smashes my square peg through a round hole. This isn't the only unexpected side effect of this command (#7757).

How does your code create these tables? If those tables are created via Doctrine Entities or via Doctrine DBAL, they will have the same charset/collation as the "standard" concrete5 tables.

It doesn't reallly matter how they where made as that is besides the point. Sometimes more then one system must live in one database. As said this is sometimes not under my control. Most CMS'es I've worked with prefix their tables so to be able to work in the same database as another system. (Joomla*=jos_, Worpress*=wp_, Magento*=mg_, Contao=tl_) *can be changed. I'm not saying concrete5 should start doing prefixes (although that is a security measure).

Tracking tables that are created by concrete5 and tables that are not created by concrete5 may be really hard.
I think that the only option we have is to add a configuration key that contains a list of tables that whose structure shouldn't be touched by concrete5.
BTW please keep in mind that table charsets/collations are strictly tied to the connection you use to read/write them: when opening a database connection we configure its charset so that it's consistent with the tables charset.
So, if you really want to use another charset for some tables, you should access them with another connection.


How to do a sobel operation in symbol layer

there is a symbol layer , its size is ( 1 ,1 ,300 ,300 ) .How to use it to do a sobel operation.
I kown that  we need to use symbol.broadcast_add/broadcast_sub......
But how to select the specif area, Symbol can be used as numpy ?
Symbol[ : ,: , 1:W, 1: H] - Symbol [:,:,0:W-1,  0: H-1]  this is right?

Sobel filter is just a filter with a specific 3x3 kernel, so you can mimic it with a convolutionnal layer ?

Something like this? The example is in ndarray but you can pass the kernel values in through sym.var.
from mxnet import ndarray as nd

data = nd.random_uniform(shape=(1, 1, 300, 300))

kx = nd.array([[1, 2, 1]]).T * nd.array([[1, 0, -1]])
ky = kx.T.reshape((1, 1, 3, 3))
kx = kx.reshape((1, 1, 3, 3))

gx = nd.Convolution(data, kx, kernel=(3, 3), num_filter=1, no_bias=True, layout='NCHW')
gy = nd.Convolution(data, ky, kernel=(3, 3), num_filter=1, no_bias=True, layout='NCHW')

out = nd.sqrt(gx*gx + gy*gy)


Lost control to air conditioner

🐛 Describe the bug
由1.7.0更新至1.7.1之後，喪失對冷氣的控制
控制裡面只剩下 "Month Selector"
Environment Information
HA version: 2024.5.4
JCI version: 1.7.1
Device: RAS-36MJF、RAS-22MJF、RAS-71MJF

Can people facing similar issues comment on this?

If no one comments on this then I would say the issue is likely towards your HA setup.

If no one comments on this then I would say the issue is likely towards your HA setup.

thanks for ur reply, I'll check my HA configuration!


Add cmd PkgREPL command

This is useful because the run PkgREPL command was picking up my system mamba even though MicroMamba was in use. This is some type of a PATH issue probably, but at any rate, this approach which will reliably target the correct executable seems like a useful addition since it can be more robust.

This is so similar to conda run that maybe they should be merged? That is, change conda run so that if the first arg is conda (or mamba or micromamba?) then run whatever CondaPkg runs?

That makes sense. So to confirm the plan would be:

Do the same as conda cmd procedure when any of these match
Don't do it when they are quoted
Document this in the docstring of conda run

I'll modify this PR with these changes soonish

Done

Thanks for the PR - I came to review it and had some comments, but in the end decided it would be quickest to just implement my ideas directly. I went with a simpler version, which just checks if the first arg is "conda" regardless of quoting. I didn't think the extra complexity was worth it for what is really just a convenience function. It's released now.


Server error<EMAIL_ADDRESS>

<EMAIL_ADDRESS>ENOENT: no such file or directory, open '/var/app/current/.tmp/05b2145966ffb37743a5bdba8d3770c65a9c7b61/package/index.js.js'

The package doesn't specify an entry file. Please add a module field


feat(coil-extension): safari workaround for missing webNavigation apis etc

TODO:

[x] workarounds for missing apis as in #1076
[x] use window 'storage' event rather than localStorageUpdate sent via browser.runtime.sendMessage

Solve the localStorage==null issue #1077

[x] some background -> popup command mechanism

maybe window dom events ?

send via chrome.extension.getViews({type: 'popup'}) from the bg page ?

does not work

[x] localStorage based ? serialized command and react using window 'storage' event ?
window.close() in response to {command: 'closePopup} from bg also causes a bad state! (#1077)

[x] Find a way to detect safari browser

[x] refactor to use some kind of contextual event bus

should support multiple instances of the popup in one window

[x] Open issue on Apple Feedback Assistant re: popup communication woes

https://feedbackassistant.apple.com/feedback/8926137

[x] Open issue re: missing apis

https://feedbackassistant.apple.com/feedback/8730949

This is still an issue as of 15/12/2020

Popup issue is still there in Safari 14.1 as of 27/1/2021

Popup issue is still there in Safari 14.1 as of 27/1/2021

Closing as this branch is now stale after the popup refactor
Will scavenge for spare parts


[Bug] When results from multiple table are queried in MySQL, only the result from 1st table is displayed.

Description

On query statements like "select * from table1; select * from table 2; ..." only the result from table1 is displayed in tabular form, even though all the results are obtained successfully.

Steps to reproduce the behaviour:

Create mysql datasource.
Write select query : "select * from table1; select * from table2;"

Important Details

Version: Any
OS: Any
Browser: Any

@sumitsum this seems like it might be something specific to MySQL. This doesn't happen in postgres and the backend is only returning the first statement. I believe the contract is only for single statements so unless there is a use-case for multi statements, can we close this?

Hi @Nikhil-Nandagopal , the mysql returns multiple results as per the latest code in release branch - as shown in the image - result body has two results mapped against indexes 0 and 1 but the result from 0 is only displayed. I had checked with @riodeuno on this. He said that ideally both the results need to be displayed with some kind of join operation.

I understand that but is this expected to happen in every database? If no
then why should we support this? I tried this in postgres and it doesn't
work. Also sending the rows combined is not a join operation and the user
should explicitly write a join statement to achieve this. Does this
multiple statement syntax work in any MySQL tool?
On Fri, Dec 4, 2020, 00:12 Sumit Kumar<EMAIL_ADDRESS>wrote:

Hi @Nikhil-Nandagopal https://github.com/Nikhil-Nandagopal , the mysql
returns multiple results as per the latest code in release branch - as
shown in the image - result body has two results mapped against indexes 0
and 1 but the result from 0 is only displayed. I had checked with
@riodeuno https://github.com/riodeuno on this. He said that ideally
both the results need to be displayed with some kind of join operation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/2005#issuecomment-738211044,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5XPJRGGV6R6OQ6AHXO2RDSS7LYRANCNFSM4ULLQLXQ
.

Hi @Nikhil-Nandagopal, I am not aware whether chaining of sql queries is allowed by design. I had assumed so after my conversation with @riodeuno . In case it is not, then yes the bug report needs to be closed.

@mohanarpit can you shed some light here. AFAIK only single statements are supported from backend and this is probably an unexpected side-effect

I don't think both results should be displayed in the UI in any kind of join operation. This goes against what a "Join" is and will only confuse the users. From all DB management software (pgAdmin, Robo3T etc), the last operation's results are displayed instead of the first ones. So if I have chained 3 SQL queries, the UI should display the results of the 3rd one instead of the 1st one.
Having said this, @sumitsum, I'm intrigued by the screenshot that you pasted. Since each plugin returns an array of objects, what happens if each query has multiple rows instead of single rows. Is it even possible to distinguish between the output of the 1st query and the 2nd query within the plugin?
This can be resolved by either:

The server only returning the last object in the array so that the client doesn't have to take a call on what data to show.
The client only displays the last result in the UI and binds it to other parts of the data tree.

Hi @Nikhil-Nandagopal @mohanarpit , I am closing this bug report in favor of a new one: https://github.com/appsmithorg/appsmith/issues/2028


[ RFC, entropy_src ] Enable signal REGWEN protected

In the entropy_src design it is currently impossible to enable or disable the entropy source once the registers are REGWEN locked.

Given that for energy saving purposes it would be nice to enable and disable the entropy source, would it be appropriate to move the ENABLE signal so it is no longer locked?
If ENABLE locking is desired, would it be appropriate to create second REGWEN_ENABLE register to allow the ENABLE signal to be independently lockable from the other critical registers?

I agree that EBABLE should not be locked.
Also note that it should be possible to restart the RNG subsystem at any time, e.g., in case of FIPS health test failure.

My understanding of the REGWEN function is that if you want security post hardware configuration, lock it all down. If flexibility is preferred, don't lock it.
In the case of power savings, directly controlling RNG would save the most power. Entropy_src can stay enabled and locked, but will not do anything with no input, and not consume any real power.

Thinking about this some more, I suppose separating the master enable from other configuration fields may be useful, and perhaps not present any security issues.  From a CI passing perpective, it would be best to keep the current register structure as is. Need consensus on this one.

Thinking about this some more, I suppose separating the master enable from other configuration fields may be useful, and perhaps not present any security issues.  From a CI passing perpective, it would be best to keep the current register structure as is. Need consensus on this one.

a bit late here. But i'm fine with this. I think we should keep the regwen in case in some use case it becomes useful.
For the cases we are discussing here, we will most lkely use it as a functional reset as you say.

Also coming to this late, sorry.
The typical security issue that comes to mind immediately is if somehow the entropy_src could be disabled but the rest of the EDN can be fooled into thinking it's capturing valid entropy (but in reality it's sampling all zeros).  The health checks should be failing like crazy at that point, for one, and there ought to be some other interlocks on not sampling a disabled entropy_src. (Presumably this is the case?)  @mwbranstad maybe have a think about any cases like this - I think we are pretty well covered but good to give a few minutes more thought to it.
Otherwise agree with @tjaychen - keep the regwen in case it becomes useful.  If you want to break out the main enable so it can be regwen'd separately, I think that's ok.
However, it does feel a little weird to me to use the main enable as a reset - if we really need a subsystem-level soft reset, shouldn't we have such a thing as a dedicated feature rather than overloading an enable bit?
  As @mwbranstad said above, if the hard macro ("RNG") is off, the synthesized logic is not switching so the power consumption there is minimal.
I understand the desire to power down the hard macro, but then again my security concern is the same as above, make sure we can't be faked into consuming all-zeros from a disabled hard macro.

@cdgori so the way i view the enable... is that in a stricter system... should the entropy_src ever fail, we are just going to say "reboot, something terrible has happened".
In a more permissive system, (this is probably the point @zi-v was trying to raise), we will probably allow the software to recover without taking the whole system down.  I think @mwbranstad designed the enable with the intent of being able to enable / disable without breaking.  So I think in "that" sense it's kind of like a reset, in that we will go back to default state of the FSM and start over again.

Note that due to 90B's 'Continuous health tests' requirement, every time we stop the clock (e.g. as in sleep state) or the continuous health tests from any other reason, we essentially need to run 90B's 'Start-up health tests' in order to regain 'fips' level entropy generation capability. Is it possible to do that if the 'enable' bit is locked?
@cdgori a large portion of a module consumption comes from its clock tree. So if clock is not stopped, the power save resulting from having module inactive is limited.

The real point of this issue to allow more options for the system (SW) to control this module.
@cdgori Tim's explanation above is what I envision as well. Turning the enable off after running for awhile allows the state of ES to "start over" when re-enabled. However, it is not a complete reset since it does not reset the register values. The original idea was that boot runs, enable is set. After boot, ES is disabled, new (final) thresholds are written in regs, then enable is set again.
This issue provides a way to lock all controls EXCEPT enable for a normal use case. But of course, maybe there is a case where even the enable needs to be locked, so it is provided.
@zi-v To answer your question, once the main enable is locked, it requires a hw reset to undo. This issue provides a way to run ES and be able to do a logical reset at any time.

@zi-v: to clarify on Mark's point: setting enable will always go through the full 90B start sequence (and optionally add our boot sequence as well)

@mwbranstad thanks for clarifying the "reset" - it's more like "restart the FSM" (trying to find the right phrase, but I think you understand).  I think all is good and you should keep the current REGWEN but split out this enable to be under a separate REGWEN to allow this functionality (and the re-running of 90B on resume from sleep, which is a must).
@zi-v also understood about the clock power though I assumed, perhaps incorrectly, that clock stops were going to be ultimately done in clkmgr (or pwrmgr), not locally.  I suppose this enable/disable bit could be a "vote" into the clock stop request, such that if this is disabled then clkmgr could gate the clock to ES.  But maybe I don't know the actual plan there.

Thanks all. It sounds that we are fine if we don't lock the enable. What's the use case for locking the enable? If we do, does it mean that we must keep clock & health test running constantly from one boot to the next (or until health test eventually fails)?

That scenario sounds correct. So for some usages the enable should never be locked. For some usages in the future, it may be deemed that it should be locked, at least that is the idea of a separate lock.

yeah i think there may be very restrictive usage in the future (beyond what we have planned now).


[ENH] Pylance support

It would be great to get Pylance support for Cython. See this issue, and in particular the following comment by @erictraut (pylance author/maintainer).

I think the right answer here is for Cython toolchain to add support for generating stub files with docstrings. Those stubs can then be distributed along with the library. Any other approach I can think of (including scraping based on runtime reflection) will produce results that leave significant gaps in terms of completeness and correctness. The maintainers of Cython are in a much better place to do this work than the Pylance team. We are happy to work with the Cython community in an advisory manner.

Duplicate of #3150


BIG TCP cannot be enabled when virtual interface is configured as NodeIP

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
summary:
BIG TCP cannot be enabled when virtual interface is configured as NodeIP.
detail:
The IP address of the virtual interface (dummy0) is set to the Node's Internal IP.
root@kf2-0a-sv004:~/k8s# kubectl get nodes kf2-0a-sv004 -o wide
NAME           STATUS   ROLES           AGE   VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE       KERNEL-VERSION      CONTAINER-RUNTIME
kf2-0a-sv004   Ready    control-plane   21d   v1.26.2   <IP_ADDRESS>    <none>        Ubuntu 22.10   5.19.0-35-generic   containerd://1.6.19

root@kf2-0a-sv004:~/k8s# ip a sh dummy0
8: dummy0: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default qlen 1000
    link/ether b6:13:23:25:09:9c brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/32 scope global dummy0
       valid_lft forever preferred_lft forever
    inet6 fd00:0:0:2::4/128 scope global
       valid_lft forever preferred_lft forever
    inet6 fe80::b413:23ff:fe25:99c/64 scope link
       valid_lft forever preferred_lft forever

And tried to enable BIG TCP.
root@kf2-0a-sv004:~/k8s# cilium config view | grep -E "big|strict|devices"
devices                                        enp65s0f0 enp65s0f1
enable-ipv6-big-tcp                            true
kube-proxy-replacement                         strict

The dummy0 interface is also detected as a device, and attempts to set gro_max_size and gso_max_size on it fail.
root@kf2-0a-sv004:~/k8s# kubectl logs -n kube-system cilium-nkvqg | grep -i big
Defaulted container "cilium-agent" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), clean-cilium-state (init)
level=info msg="  --enable-ipv6-big-tcp='true'" subsys=daemon
level=info msg="Setting up IPv6 BIG TCP" subsys=big-tcp
level=warning msg="Could not modify gro_max_size and gso_max_size, disabling BIG TCP" device=dummy0 error="invalid argument" subsys=big-tcp
level=info msg="Resetting gso_max_size and gro_max_size" device=dummy0 subsys=big-tcp

root@kf2-0a-sv004:~/k8s# kubectl exec -it -n kube-system cilium-nkvqg -- cilium status
Defaulted container "cilium-agent" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), clean-cilium-state (init)
KVStore:                 Ok   Disabled
Kubernetes:              Ok   1.26 (v1.26.2) [linux/amd64]
Kubernetes APIs:         ["cilium/v2::CiliumClusterwideEnvoyConfig", "cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumEnvoyConfig", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "core/v1::Namespace", "core/v1::Node", "core/v1::Pods", "core/v1::Secrets", "core/v1::Service", "discovery/v1::EndpointSlice", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement:    Strict   [dummy0 <IP_ADDRESS> fd00:0:0:2::6 (Direct Routing), enp65s0f0 <IP_ADDRESS> fd00::d, enp65s0f1 <IP_ADDRESS> fd00:0:0:1::d]
Host firewall:           Disabled
CNI Chaining:            none
CNI Config file:         CNI configuration file management disabled
Cilium:                  Ok   1.13.0 (v1.13.0-c9723a8d)
NodeMonitor:             Listening for events on 48 CPUs with 64x4096 of shared memory
Cilium health daemon:    Ok
IPAM:                    IPv4: 10/126 allocated from <IP_ADDRESS>/25, IPv6: 11/126 allocated from fd85:ee78:d8a6:8607::1:180/121
IPv6 BIG TCP:            Disabled
BandwidthManager:        Disabled
Host Routing:            BPF
Masquerading:            Disabled
Controller Status:       54/54 healthy
Proxy Status:            OK, ip <IP_ADDRESS>, 0 redirects active on ports 10000-20000
Global Identity Range:   min 256, max 65535
Hubble:                  Ok   Current/Max Flows: 1609/4095 (39.29%), Flows/s: 0.63   Metrics: Disabled
Encryption:              Disabled
Cluster health:          1/4 reachable   (2023-03-23T07:52:14Z)
  Name                   IP              Node        Endpoints
  kf2-0a-sv004           <IP_ADDRESS>      reachable   unreachable
  kf2-0a-sv005           <IP_ADDRESS>      reachable   unreachable
  kf2-0a-sv007           <IP_ADDRESS>      reachable   unreachable

Cilium Version
v1.13.0
Kernel Version
5.19.0-35-generic
Kubernetes Version
v1.26.2
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

any update？

Hey team! I have the same problem.
Cilium pods on startup bailing with
level=info msg="Setting up BIG TCP" subsys=big-tcp
level=info msg="Setting IPv6 gso_max_size to 65536 and gro_max_size to 65536" device=eno2 subsys=big-tcp
level=warning msg="Could not modify IPv4 gro_max_size and gso_max_size, disabling BIG TCP" device=eno2 error="invalid argument" subsys=big-tcp
level=info msg="Resetting IPv4 gso_max_size and gro_max_size" device=eno2 subsys=big-tcp

i suspect the problem is eno2 is master for underlaying dot1q vlan.2014@eno2. And vlan.2014 IP address is used as node InternalIP.
Br, Alex


Implement fuse flush function

Codecov Report

Merging #13103 (8b199f0) into master (f5a5ea7) will decrease coverage by 26.85%.
The diff coverage is 11.90%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eefdfd9...8b199f0. Read the comment docs.

@Binyang2014 This PR is still useful, could you solve the conflicts and update the PR?

@LuQQiu Do I need to wait for your PR: https://github.com/Alluxio/alluxio/pull/13113 merge back to master?

That PR merges Master into a feature branch and is unrelated to this PR.

alluxio-bot, merge this please


feat: add support for bbs-signatures library

Solves #57
Description
Removes the dependency on node-bbs-signatures and adds a dependency on bbs-signatures which has the node fallback built in now.

[ ] Tests for the changes have been added (for bug fixes / features)
[x] The commit message(s) follow conventional commits
[ ] Documentation has been added / updated (for bug fixes / features)
[x] Changes follow the contributing document.

Motivation and Context
To allow this library to run in non-node environments (browser, wasm, non-wasm e.g. react native)
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Which merge strategy will you use?

[ ] Squash
[x] Rebase (REVIEW COMMITS)

Tests are passing on local. They're failing here because the latest unstable release of bbs-signatures on npm does not include the latest build which has the node fallback.

Looks like we faced the same issue after the latest commit as described here - https://github.com/mattrglobal/bbs-signatures/issues/35
Will resolve using the workaround here - https://github.com/mattrglobal/bls12381-key-pair/pull/19/files#diff-2d0cd5d10b9604941c38c6aac608178aR7

Unable to reproduce the errors being faced in the github workflow runner on my local. Will be doing some debugging on here directly. We can squash the commits later during merge.

The tests are passing fine now. We believe the coverage is failing because this is a PR from my fork of the project, and the Github secret token is not being shared with my fork.
@tplooker can we merge?


Show documentation attached to constructors of associated types

It looks like Haddock does not see documentation attached to constructors of associated type instances, whereas it does see documentation attached to constructors of regular types.
Example:
{-# LANGUAGE TypeFamilies #-}
class Foo a where data DF a

instance Foo Int where
  newtype DF Int =
    -- | Make DF
    MkDF Int

newtype Ty =
    -- | Make Ty
    MkTy Int

*Main> :doc MkTy
MkTy :: Int -> Ty     -- Data constructor defined at DF.hs:10:5
-- | Make Ty
*Main> :doc MkDF
<has no documentation>

I would expect :doc MkDF to cough up the line -- | Make DF, but this is not the case.
Trying to extract the documentation via Template Haskell's getDoc function gives similar results: the documentation attached to MkTy can be found just fine, but getDoc 'MkDF comes back empty.

Adding insult to injury, you get warnings about the missing documentation for the constructors.

Hi, thank you for this ticket, but Haddock now lives full-time in the GHC repository!
Read more at https://discourse.haskell.org/t/haddock-now-lives-in-the-ghc-repository/9576.
Let me know if you feel it is still needed, and I'll migrate it. :)


[Bug]: Token delegate remains after frozen NFTs are thawed

Issue description
Steps to reproduce:

Use sugar to Launch a candy machine v2 with freeze function enabled.
Wait for freezeTime to elapse and then use sugar thaw --all to thaw all frozen NFTs.
The thawed NFTs will still have a token delegate which is causing issues in some staking contracts.

The token delegate should be removed when the NFT is thawed if possible. Here is an example NFT that was minted that still has a token delegate.
NFT token address: 5amipwGeRre846raWLSs6QqpN99KKh6HxgcV8sCAkbhT
Token delegate for above NFT: 84FVX6CkVpWRPjZfsmwf1JeeHsSajpnYjLDdoaA5LRzP
Let me know if you have any questions on the above or if you think that this is a feature and not a bug. Thank you!
Relevant log output
No response
Priority this issue should have
Medium (should be fixed soon)

It tries to revoke the SPL token delegate, but only the owner can do it, so if you're signing as the update authority to do the thaw it can't revoke for you and owners will either need to call thaw on their own token or to run revoke themselves.

The other thing users can do is just transfer the NFT between two of their wallets as the delegate exists on the token account and so will be cleared with the token is transferred to a new token account.


⚠ ClamAV has degraded performance

In 1c64283, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 75 ms

Resolved: ClamAV performance has improved in 87b7d9b.


Support jvm_opts on scala_toolchain

Add support for jvm_opts, equivalent to java_toolchain: https://docs.bazel.build/versions/master/be/java.html#java_toolchain.jvm_opts

I believe (though I am not sure!) that this can be achieved through --jvm_flag either passed at the command line or in a .bazelrc file

Yeah, there is a --jvmopt, which has no effect in combination with scala_binary and scala_test.


Fix 'PropertyOnlyAdapter' to allow calling base methods

PR Summary
Fix #6386
For a PropertyOnlyAdapter, the property may come from various sources, but methods, including parameterized properties, still come from DotNetAdapter. So, the binder should be able to optimize on method calls for objects that map to a custom PropertyOnlyAdapter.
Therefore, the original SiteBinderCanOptimize property is changed to a method CanSiteBinderOptimize(SiteBinderOperatesOn opType). For PropertyOnlyAdapter, the method returns false for property operations and true for method operations.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[x] User-facing Documentation needed

[x] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[x] Add [feature] if the change is significant or affects feature tests

With last commit it seems the PR summary should be corrected.


Installation Issue

Steps to trigger behavior

Add implementation 'com.graphhopper.navigation:navigation-android:0.1.0' to android/app/build.gradle
Run build

Expected behavior
Successful installation of this library.
Actual behavior
It is unclear what the installation issue is. I also attempted to replicate installation from the example, with no success.

Use this:
implementation 'com.graphhopper:graphhopper-navigation-android-ui:0.1.0-SNAPSHOT'
this implementation worked for me but ran into another issue after that. The repo contains mapbox-android-sdk-6.5 and I'm adding
implementation 'org.maplibre.gl:android-sdk:9.4.0' t use the latest maplibre. This is causing issues with duplication and not sure what the solution is.
I've tried excluding the module 'mapbox-android-sdk' but that causes another issue with the xml files.
Lot of interlocked dependencies.

Lot of interlocked dependencies.

It is important to note that currently this repo is not yet compatible with maplibre SDK. See #6


Breaking issue in 1.0.1

TypeError: binary is not a function
    at Function.from (native)
    at from (native)
    at _base64encode (/x/node_modules/passport-openid/node_modules/openid/openid.js:97:10)
    at _bigIntToBase64 (/x/node_modules/passport-openid/node_modules/openid/openid.js:106:10)
    at Object.openid.associate (/x/node_modules/passport-openid/node_modules/openid/openid.js:608:35)
    at chooseProvider (/x/node_modules/passport-openid/node_modules/openid/openid.js:816:16)
    at /x/node_modules/passport-openid/node_modules/openid/openid.js:830:7
    at /x/node_modules/passport-openid/node_modules/openid/openid.js:580:7
    at /x/node_modules/passport-openid/node_modules/openid/openid.js:446:16
    at Request._callback (/x/node_modules/passport-openid/node_modules/openid/openid.js:209:7)

Which version of Node is this, and which provider are you trying to associate to?

Node version: 4.3.1
We are using a custom provider
1.0.0 works, but when updating to 1.0.1 we get this error.

We are using: https://github.com/jaredhanson/passport-openid
We hade to fork to: https://github.com/EmmEm/passport-openid
And set openId version to 1.0.0 instead of 1.x.x to keep using it.

Fixed in 1.0.2.


(2.2.19) "It's not possible to reach the tile from the last waypoint" when trying to caravan

Very rarely when you try to caravan, when you right-click on a tile for your destination you get a message saying "It's not possible to reach the tile from the last waypoint" and you can't form the caravan. I don't know how to reproduce, it has happened once before on a fresh vanilla save, and twice on a modded save. There are no errors. Reloading fixes the issue, so I can't provide a save.
Mod list (For vanilla report, it has to be same as below list.)

Harmony
Core
Royalty (optional)
HugsLib
RimThreaded

This issue seems related to https://github.com/cseelhoff/RimThreaded/issues/527


Astro 2.0.x has not been supported yet?

Hi, developers. Thank you for this awesome astro integration.
I tried to configure my project that depends on<EMAIL_ADDRESS>to integrate this pwa plugin , but the following error was occurred.
02:47:00 PM [astro] Unable to load /workspaces/takpedia/astro.config.mjs

 error   Cannot read properties of undefined (reading 'default')
  File:
    /workspaces/takpedia/node_modules/vite/dist/node/chunks/dep-3007b26d.js:52400:9
  Code:
    52399 |         const initModule = new AsyncFunction(`global`, ssrModuleExportsKey, ssrImportMetaKey, ssrImportKey, ssrDynamicImportKey, ssrExportAllKey, '"use strict";' + result.code + `\n//# sourceURL=${mod.url}`);
    > 52400 |         await initModule(context.global, ssrModule, ssrImportMeta, ssrImport, ssrDynamicImport, ssrExportAll);
            |         ^
      52401 |     }
      52402 |     catch (e) {
      52403 |         mod.ssrError = e;
  Stacktrace:
TypeError: Cannot read properties of undefined (reading 'default')
    at eval (/workspaces/takpedia/astro.config.mjs:21:172)
    at async instantiateModule (file:///workspaces/takpedia/node_modules/vite/dist/node/chunks/dep-3007b26d.js:52400:9)

After that, I also tried to reproduce it with creating new clean project with npm create astro command.  Same error was occurred at the project too.
The clean project's astro.config.mjs is simply the below.  (They were generated by create astro and were added only configurations for  pwa integration.)
{
	"name": "nebulous-neutron",
	"type": "module",
	"version": "0.0.1",
	"scripts": {
		"dev": "astro dev",
		"start": "astro dev",
		"build": "astro build",
		"preview": "astro preview",
		"astro": "astro"
	},
	"dependencies": {
		"astro": "^2.0.14"
	},
	"devDependencies": {
		"@vite-pwa/astro": "^0.0.1"
	}
}

import AstroPWA from "@vite-pwa/astro"

// https://astro.build/config
export default defineConfig({
    integrations: [
        AstroPWA()
    ]
});

Sorry for my hasty...  #5 will solve this.
Thank you.

@NewGyu released v0.0.2


Improved FixAll for TokenSpacingCodeFixProvider

Fixes #1987

Current coverage is 93.38%

Merging #2074 into master will increase coverage by +0.04% as of 4482f2d

@@            master   #2074   diff @@
======================================
  Files          566     566
  Stmts        35887   35891     +4
  Branches      2311    2310     -1
  Methods
======================================
+ Hit          33499   33516    +17
  Partial        759     759
+ Missed        1629    1616    -13

Review entire Coverage Diff as of 4482f2d

Powered by Codecov. Updated on successful CI builds.


env variable for crd request generator rems profile

this pr is part of the crd request generator pr - https://github.com/mcode/crd-request-generator/pull/3


Statically typed function argument silently converted to null if the type doesn't match

Godot version:
3.2.1.stable.official
OS/device including version:
Arch Linux (installed godot-bin from AUR)
Issue description:
Static typing on function arguments can under some circumstances result in an argument silently being converted to null when the type doesn't match, rather than throwing an error.
Steps to reproduce:
tool
extends EditorScript

func _run():
	var bar = "hello"
	print("bar outside foo: ", bar) # prints "hello"
	foo(bar)

func foo(bar: Node):
	print("bar inside foo: ", bar) # prints "Null"

Expected result:
An error because the argument type String does not match the parameter type Nullify.
Actual result:
bar outside foo: hello
bar inside foo: Null

Interestingly, the error is detected correctly if I change the function to take Array instead of Node. But it also breaks if I use a custom type registered with class_name.
Minimal reproduction project:
Just paste the above code into a new GDScript file and hit Ctrl+Shift+X to run it.

This is working correctly. The bar variable can be Node, so there are no warnings.

@dalexeev Maybe you misunderstood. I'm not trying to fix my example code. I'm trying to say there's an obvious bug in the example code, and not only does the static typing fail to catch it, it's actually altering behaviour of the code at runtime.

Yes, you are right, at runtime this should cause an error. Just the issue title is a bit confusing.

It's not shown in the doc, but I thought print's varargs were all Variant? Because as you can see, you can send numbers or vectors too without problem:
print("Hello", 42, Vector3())

So that also includes arrays, dictionaries, and objects like Node. Objects can be null, so it does print null when it's null. No bug here.

at runtime

Ideally, at runtime, when the script gets parsed (as opposed to being run), IMO ;)

at runtime, when the script gets parsed (as opposed to being run)

I am not sure that this analysis is possible even for local variables (and even more so for class members).
func _run():
    var bar = "hello"

    if randi() % 2:
        bar = Node.new()

    foo(bar) # What type of `bar` is it now?

func foo(bar: Node):
    ...

The only way is to check the type at the time of calling foo().
Another thing is if the bar variable is statically typed - in this case the error will be visible already when writing the code.

Oh, I was referring to a situation like this:
func _run():
	var bar := "hello"
	print("bar outside foo: ", bar) # prints "hello"
	foo(bar)

If not typed then yeah it can only defer to runtime (and induce a cost).

In this situation, everything seems to work correctly, the line with the error is highlighted in red.

(I wrote about this in my first comment.)

I'm going to look at making a PR now, and if it turns out to be over my head I'll post back here.

Colour me surprised: this behaviour is coded explicitly.
https://github.com/godotengine/godot/blob/a2da99f40cf2123c0906c734a2eb01e9b65a45a2/modules/gdscript/gdscript_function.cpp#L339-L349
Paraphrasing: whenever the actual argument isn't convertible to the expected type, rather than immediately giving up with an error, we first check whether null is a valid value for the expected type. If that is the case, we replace the argument by null and proceed. So this also happens also in cases where you pass e.g. a Node where a Node2D is expected, or a Node2D where a Node3D is expected, and similar with custom classes. I'm baffled why nobody has reported this before...
This was added in f0efc75 because "Previous version resulted in confusing (but actually right) errors". Fair enough, but now it results in confusing (and actually wrong) runtime behaviour.
But there is some good news: the error message seems to have improved since that commit was written, so it may no longer be necessary. Here's my testing code:
extends Node

func _ready():
	# Using call_deferred to avoid stopping at the first error.
	call_deferred("foo", Node.new())   # Correct type (Node)
	call_deferred("foo", Node2D.new()) # Correct type (Node subclass)
	call_deferred("foo", RegEx.new())  # Object type, but not a Node
	call_deferred("foo", "hello")      # String type
	call_deferred("foo", [])           # Array type
	call_deferred("foo", null)         # null type

# Using an extra level of indirection through this untyped `foo` because
# call_deferred seems to silently ignore invocations with the wrong signature.
func foo(bar):
	print("bar inside foo: ", bar)
	foo_impl(bar)

func foo_impl(bar: Node):
	print("bar inside foo_impl: ", bar)

And the resulting output, when I run this in a build with f0efc7521e7302e60ebaab31a42fafd3ea2bda68 reverted:
bar inside foo: [Node:1132]
bar inside foo_impl: [Node:1132]
bar inside foo: [Node2D:1133]
bar inside foo_impl: [Node2D:1133]
bar inside foo: [RegEx:1134]
SCRIPT ERROR: foo: Invalid type in function 'foo_impl' in base 'Node (nullify.gd)'. The Object-derived class of argument 1 (RegEx) is not a subclass of the expected argument class.
   At: res://nullify.gd:14.
bar inside foo: hello
SCRIPT ERROR: foo: Invalid type in function 'foo_impl' in base 'Node (nullify.gd)'. Cannot convert argument 1 from String to Object.
   At: res://nullify.gd:14.
bar inside foo: []
SCRIPT ERROR: foo: Invalid type in function 'foo_impl' in base 'Node (nullify.gd)'. Cannot convert argument 1 from Array to Object.
   At: res://nullify.gd:14.
bar inside foo: Null
bar inside foo_impl: Null

Those look like fine error messages to me! @bojidar-bg Would you agree to a pull request to revert that commit?

So this also happens also in cases where you pass e.g. a Node where a Node2D is expected, or a Node2D where a Node3D is expected, and similar with custom classes. I'm baffled why nobody has reported this before...

This is actually convenient. In my case I have a Player class and in various methods I do this:
func on_body_entered(body: Player):
    if body:
        #collided with player

I would be sad if this gave an error :I
(I know I could just use is though...)

https://xkcd.com/1172/ is just too true, isn't it... But seriously, this auto-nulling behaviour is undocumented, inconsistent (it doesn't happen if you have Array instead of Player) and extremely surprising to anyone who's ever worked with statically typed languages (which is a large number of people). It may make the code slightly easier to write in some very specific cases like this, but it makes it much harder to understand. I would strongly recommend not to rely on it.


GME & the future?

Hi,
with the announcement that rivers are being discontinued in 2.0, and are discouraged from 1.5 on, will this affect Go-Mysql-Elasticsearch?
Will you be pursuing other alternatives?  We are looking into ways of syncing using the recommended method which best suits us (in our case we dont want to start from zero, so looking at Logstash)...  Are you/will you be considering GME as an input to logstash perhaps? or is there too much overlap in code alreadt in your opinion?
Logstash doesnt have a mysql input layer, and probably wont ever have something binlog capable... on the otherhand, logstash is already bulking requests and inserting them using the correct apis on ES, so a bridge between GME and logstash could be a natural progression?
I'd like to hear the dev's opinions...

Hi @RVN-BR
I know that ES will discard river feature, but this doesn't affect GME, because I don't use river feature at all.
GME is a service acting as a MySQL slave to sync MySQL binlog and then update the data changes into ES with ES http bulk API.
Btw, if you want to sync MySQL binlog and write the changes into logstash, you can use my another project github.com/siddontang/go-mysql, you can use the canal package to sync binlog and  write the json format changes in a place which logstash can get.

@siddontang Makes perfect sense!  I didnt realize GME was using bulk api and not river api...  I guess thats future-proof then :)
Thanks

Hi @RVN-BR
Thank you reminding me, maybe we can build another repository named go-mysql-logstash, it will sync the mysql data and then write the json format in a place.
But I  haven't used logstash, so I don't know the proper format the logstash needs.

@siddontang It appears it shouldnt be an issue to configure from the format files in GME to get the appropriate mappings...
I'm now been investigating another interesting and promising project called Crate.io, built on top of ES, but which is more SQL-esque.  It allows me to use ES but also to query some data in a structured fashion where it makes more sense.  I'm looking into making a driver for GME for crate.  It shouldnt be too difficult... crate has a bulk api too, it differs a bit in format from ES, but I'm going to poke around a bit of GO and see if I can eventually try something...
In theory, one can insert straight to ES, but Crate does its own internal type, id, etc mapping which may be difficult or impossible to reproduce statically, so it may be best to try to do it straight to the crate api... https://crate.io/docs/stable/sql/rest.html#bulk-operations
anyways, I am thinking crate may be useful... I'm thinking abt using it as a "bridging gap" for when some things need to be quickly shifted from mysql into a more search-esque backend :)  GME might be a great tool to keep the data in sync.  At the same time we can still use logstash and other great tools on ES, as well as having a running ES cluster... win win :+1:

Thanks @RVN-BR, I will look it later. :-)


Found Malware

Just on the Release file executable, I found detection score of 2/74 at VirusTotal. CrowdStrike Falcon and Cynet are claiming that.
Just check and disinfect your executable. Thanks!

Those detections are false positives, if the file contained real malware, way more antivirus engines would have flagged the file as malicious.
Some antivirus programs will flag any keygen or cracking program as "malicious" no matter what, even if the file isn't malicious at all.
If you don't trust a binary executable file, your only option is to compile the code yourself.

Yes WinRAR Keygen is flagged as virus in Malwarebytes. Don't  use it. Your privacy will be leaked

Yes, like @Sonic-The-Hedgehog-LNK1123 said, If you don't trust a binary executable file, your only option is to review the source code yourself and compile it yourself.
Or, you can try running it in an isolated environment. 🐞
The information I can provide is that WinRAR Keygen does not detect the threat in Kaspersky.

Wrong, this file is completely safe. These are just false positives.

The update supports Github Actions. 🎉
Now you can run it in the cloud without worrying about security issues, please refer to the README for details.


Spinner in Large Buttons

spinner in large buttons doesn't match a text line.
// --- here's a fix:
.btn-lg span.spinner-border-sm {
vertical-align: baseline;
}

Not every use case can be considered for every component, so it makes sense you may need to optimize things with custom styles or utilities. We do have some alignment utilities that could help here, but if you can provide a live demo of the problem, we can revisit.


Does it recalculate efficiently on frequent DF appends?

Many indicator can be efficiently recalculated without calculating all previous ohlcv records. it hits the performance.
Usual use cases -  live OHLCV stream. Also when appending - there is mismatch column problem.
I didn't found any interface for that that under the hood (talib).
Maybe someone has some idea for that? or am i missing something and it already calculates latest ohlcv indicators without recalculating old one?

Hello @timabilov,

Many indicator can be efficiently recalculated without calculating all previous ohlcv records.

Which? Please be specific.

I didn't found any interface for that that under the hood (talib).

Know of other sources that do with relevant code?

Usual use cases - live OHLCV stream. Also when appending - there is mismatch column problem.

Do you have examples and reproducible code?

Maybe someone has some idea for that? or am i missing something and it already calculates latest ohlcv indicators without recalculating old one?

Pandas TA calculates the chosen indicators for the ohlcv DataFrame. It is just one component of a Trading Platform. It is the responsibility of the user to manage their own data pipeline including data acquisition, cleaning, feature generation (this package), post analysis, backtesting, , signal generation, visualization, forward testing, broker integration, portfolio management, order management and execution.
Furthermore, this has been somewhat discussed before. Please see Pinned Issue #87 How to utilize this Framework for live ticks for more information and other ideas.
Kind Regards,
KJ

Hi @twopirllc ,
Sorry for making all the things hard here.
Anyway i checked pinned issue and it seems there is no other way.
The point is - when we have a new tick, we append  this OHLCV record to DataFrame. Short example to clarify:
def update_ohlcv(klines: pd.DataFrame, row: list):
    index = kline_start_to_index(start=row[0]) # datetime index
    row = [float(cell) if cell else None for cell in row]
    row.extend((len(klines.columns) - len(row)) * [None]) #  HERE my bad i guess, cause new tick has no indicator  columns..
    klines.loc[index] = row
    indicatorize(klines) # klines.ta.macd and etc

    return klines.loc[index]

Each time when we append  one OHLCV to our klines(DataFrame) indicators should be recalculated for all DataFrame.
For example, considering only MA for now,  new MA value for new OHLCV record  can be calculated using previous OHLCV record's MA value( klines.loc[index -1] ).
Main question is - does underlying lib or pandas-ta consider previous value for any recurring indicator like MA, EMA and etc?
I can be wrong here, sorry. But if it is recalculated for whole records indeed, then i  am trying  to find more eloquent way to handle that situation.

Know of other sources that do with relevant code?

No actually, other than calculating all the things for myself which is not the right way when you handle finance, you know.
I hope that this clarifies all the things.

@timabilov,
Apologies for the delay in the reply. I wanted to dig around a little more and check some additional sources.

Sorry for making all the things hard here.

Comes with the territory. 😆

Main question is - does underlying lib or pandas-ta consider(not calculate whole df records) previous value for any recurring indicator like MA, EMA and etc?

In short, no it does not because you still have to manage the process of calculation and appending to the prior DataFrame; as you have coded. This is not a self aware DataFrame and has no insight when data arrives. Nor I have seen any TA library or package that does so yet.
What you want are Incremental Computations (such as mean, variance, et al....) and they are small subset of indicators. Unfortunately, I have yet to find a list of equations that support Incremental Computations. However if you could help me identify and source these particular equations, I think I can modify those existing indicators to process only two rows to speed up the computations for this case.
However, there are many indicators where this is just not possible. Some of which require rather complex logic just to determine it's value like psar or supertrend et al.
Also you might know of Jane Street (Quantitative Trading Firm), they have released some OCaml Open Source and an Incremental Library that maybe useful for you if you are somewhat familiar with OCaml or Functional Programming.
In regards to managing the process of a Trading Platform, I also recommend reading TradingView's Execution model of Pine scripts to understand how their approach. However other well known platforms (IB, ToS, TradeStation, et al) are more black box in their management.

I can be wrong here, sorry. But if it is recalculated for whole records indeed, then i am trying to find more eloquent way to handle that situation.

We all want fast calculations. You are preaching to the choir here. Not only is this library has few dependencies, is comprehensive and accurate, but it's not that slow. Here are some run time stats on processing on an Apple Macbook Pro M1:

Of course, your use case will vary and not everyone will be running ALL the indicators to generate features and determining trade signals.
Out of curiosity, what are you developing and for what exchanges and assets?
Hope this helps.
Kind Regards,
KJ

Thank you for really detailed answer!
Yes, we can call that as incremental computation for some specific recurrent indicators.
My tests are on mac M1 is also pretty well, but that is no go,  considering low cost production VPS or whatever.
It is just and auto trader which should be easy-scaled as SaaS, and that is very scary, although  i know that there are tons of workarounds like streaming all indicators from central server, but anyways. Just wanted to check.
It is still ok for me of course. That's lib is really awesome! Thank you
All of the problems are still nothing compared to the "working" autotrader, you know

Hello @timabilov,

Thank you for really detailed answer!

👍🏼 I'm still learning new things also. 😓

My tests are on mac M1 is also pretty well, but that is no go, considering low cost production VPS or whatever.

Understandable.

It is just and auto trader which should be easy-scaled as SaaS, and that is very scary, although i know that there are tons of workarounds like streaming all indicators from central server, but anyways. Just wanted to check.

Yeah. Welcome to the club! 😎  There are already existing open and closed source platforms and SaaS implementations in the wild. Trying to build my own in my spare time also.
You may be interested in this Algo Trading Summit happening on July 15th; check the link there may still be free tickets left.

It is still ok for me of course. That's lib is really awesome! Thank you

I hear ya. In between Issues, I have been trying to increase it's speed, reduce the ETL process and make it easy to Backtest with vectorbt.

For a more detailed version, check out the development branch Example Notebook

All of the problems are still nothing compared to the "working" autotrader, you know

👍🏼
KJ

I know this is closed, I just wanted to mention that I stumbled upon https://github.com/nardew/talipp which is incrementally updating indicators. Maybe that could help with this problem?


hiding elements from homeview

Describe the bug
Elements from Homeview are not hiding
Versions

Mushroom-Strategy: 1.0.1
HACS: 1.33.0
Mushroom: 3.2.2
Home Assistant: 2023.12.4

To Reproduce
Steps to reproduce the behavior:
added this to my config
strategy:
type: custom:mushroom-strategy
options:
homeView:
hidden:
- greeting
- persons
Expected behavior
items do not get hidden

sorry, did not realize it was reported already, closing this issue!
https://github.com/AalianKhan/mushroom-strategy/issues/82


Chart unloads after changed div position

I'm trying to load C3 chart on widget. we can drag and drop the widget in my application. So initially, chart is getting load into div. After drag and drop the widget, chart gets unload. please let me know how to solve this issue.

after moved position

@rjkmrgh usually to get some answer, you need provide some working demo(from codepen, jsfiddle, jsbin, etc) for that.

I have the same issue, when using drag and drop with charts. Here is jsfiddle - https://jsfiddle.net/6dLdawg5/22/
My code starts at line 290 (had to include drag and drop lib before in JS section, it does not have CDN link, maybe there is better way to include it, but I don't know jsfiddle too well).
You can see that if you try to drag and drop graphs - graph, which is dragged, looses it's content, but once you resize browser a bit or hover over chart, content appears.

@knospina what browser are you seeing this issue in? In Chrome everything works wonderfully.

@schwassj I see this issue in Chrome, my Chrome is -  Version 56.0.2924.87 (64-bit)

No activity for a while, the only provided fiddle is working, closing.


Student Application Process New Sample

| New sample?     |  Yes                     |
Solution Details

Q
A

Solution requires premium license
no

Solution uses experimental features (see licensing guidelines)
no

Which connectors are used?
Sharepoint, Power Automate

Solution uses on-premises connectors?
no

Solution uses custom connectors?
no

Layout
Tablet

What's in this Pull Request?
This application is built for prospective students at a university/college. It allows them to register and apply for a program at the college/university by submitting relevant details and documents.

@Laskewitz here ya go!

Hi @sam-404,
Thanks for all the hard work on this sample! I made some minor changes:

I removed the logo from all the screens
I removed the logo from the app
I removed the "allcountries" list from the app - that was not being used, so I guess that won't do any harm
I edited the readme a little to make sure it includes the right links

I'll go ahead and merge the PR! Thanks for your submission!


How to set this

app.use(`/apiProxy`, proxy({
  target: 'http://<IP_ADDRESS>:10241',
  // target: 'http://<IP_ADDRESS>:4000',
  changeOrigin: true,
  logLevel: 'debug',
  proxyReq: function (req) {
    console.log(req)
  }
}));

when i ajax get(/apiProxy/TaxRate/GetTaxRates)  i want to refer to http://<IP_ADDRESS>:10241/TaxRate/GetTaxRates
not http://<IP_ADDRESS>:10241/apiProxy/TaxRate/GetTaxRates
How did i do this?

Hi,
Thank you for your question.
Please use StackOverflow. I think that would be a better place to troubleshoot your setup.
Thanks.


Reduce warnings in pytest runs.

From 2233 down to 412.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Python PreCommit

Run Python PreCommit

Run Python PreCommit

@lukecwik Do you have time to review this?


How to extract steps into spearate files in ./steps directory

Hi,
at first big thank you for this library, it's really great!
I'd like to extract steps into separate file(s) in ./steps directory in similar manner how features are (README mentions that it's possible), but I'm not sure how to do that. Could you please show some example (ie. based on code from README) how can I do this?

Hey @BerhorShadowbuckle!
The current released version does make doing that kind of inflexible at the moment. The version on the develop branch is async-aware and replaces the macro with a builder that should make it a bit more obvious how to go about this.
I'll try to make a release of the develop branch plus some documentation over the weekend.

@BerhorShadowbuckle are you trying to achieve something like that?
tests
├── cucumber.rs
├── steps
│   ├── my_step.rs
│   └── mod.rs
└── world.rs

If so, then the following setup seems to work for me:
// tests/cucumber.rs

mod world;
mod steps;

use cucumber::{cucumber, before, after};

before!(a_before_fn => |_scenario| {
});

after!(an_after_fn => |_scenario| {
});

fn setup() {
}

cucumber! {
    features: "./features",
    world: crate::world::MyWorld,
    steps: &[
        steps::my_step::steps
    ],
    setup: setup,
    before: &[ a_before_fn ],
    after: &[ an_after_fn ]
}

// tests/world.rs

pub struct MyWorld {
    pub foo: String
}

impl cucumber::World for MyWorld {}

impl std::default::Default for MyWorld {
    fn default() -> MyWorld {
        MyWorld { foo: "".to_string() }
    }
}

// tests/steps/mod.rs

pub mod my_step;

// tests/steps/my_step.rs

use cucumber::steps;

steps!(crate::world::MyWorld => {
    given "something" |world, step| {
        // this should work
    };
});

@ianlet Thanks for the hint! I'll check it :)

I have now published Cucumber 0.7.0. If you have a look at the example in the readme, you will see for simplicity I have made the steps definition in an inline mod. This could very easily be another file that is a module.
Once you have done that, you specify the steps to be used in the cucumber builder. That's it!

Thanks! :)

I would keep this open as a documentation issue.
The issue of concern is that cucumber-rusts recommendation to place step files inside test rather than adopt upstream conventions (java, java-script, ruby, kotkin) of placing steps under features.
The reason why tests is a poor idea, in my experience, is that it muddles unit tests and executable features.
Features tend to be written first, then the step definition makes you write a high level function that would make the test green.  This is the end result you need to call to make that Feature step green.  In the course of implementing the function called by the step definition you implement many unit tests - these go in the tests folder.

Hmm, should this be re-opened? According to the Rust docs, each file under tests is actually compiled as its own crates, meaning that we shouldn't be using mod <file> in the tests directory.
https://doc.rust-lang.org/book/ch11-03-test-organization.html


Verify that all dependencies use friendly licenses

As suggested in #843, this change checks the licenses of all dependencies transitively against a white-list. I've assumed that everything currently in use is OK; see the white-list near the bottom of the diff for a full list. Note especially that there are dependencies that don't specify their license.
Other than that, the only interesting thing in here is the insane amount of license aliasing. Review of that is especially appreciated. To check that all is well, run the task downloadLicenses, open ./build/reports/license/license-dependency.html, and apply legal knowledge :) Removing the aliases for the duration of the test can maybe help that process.

CC @mstine @adriancole

Thanks. good start. I suspected there'd be a crapload of licenses (because crapload of dependencies).
I think it is most important to know the licenses "per binary" like, collector, web, query.
Do you mind running this and place the example html output in a comment, image a pastebin? That will lower the barrier to review for folks who don't have gradle setup. (Also, you could raise this as a openzipkin branch, too)

We should be able to do per subproject (=== per binary) simply, I'll give it a go today.
I've added the license reports for review, easy way to check: http://htmlpreview.github.io/?https://github.com/abesto/zipkin/blob/license-check/build/reports/license/license-dependency.html

I'll raise a pull request to switch out mysql driver for mariadb. There's an exception to the GPL clause, but still unnecessarily scary: https://www.mysql.com/about/legal/licensing/foss-exception/

SGTM. In the meanwhile, the check is now run separately for the collector, query and web services, as well as for the root project, just in case.

https://github.com/openzipkin/zipkin/pull/853 wrt killing the GPL dep

hehe one last whack-a-mole! "verifyLicensesLicense "LGPL-2.1" is not on the list of allowed licenses. The dependencies using it: [mariadb-java-client-1.3.0.jar"

Whackamole is down, GPL removed from the whitelist :fireworks: The license listing is also updated.

Moving a conversation here from a changed / removed line: there's a couple of dependencies with no license specified.

Some of these are Zipkin projects; for those, this is a good opportunity to add license information to the POM files (https://github.com/hierynomus/license-gradle-plugin/blob/master/src/main/groovy/nl/javadude/gradle/plugins/license/LicenseResolver.groovy#L192 shows that's what the plugin uses, as opposed to LICENSES files or some other heuristic)
The rest are external dependencies, where we can track down licenses where available and tell the plugin about those explicitly in the build definition of Zipkin, as shown in https://github.com/hierynomus/license-gradle-plugin#license-reporting

I propose we break these out into two separate issues.

sgtm. Let's merge this when you're ready.

New issues created, commits squashed. Ready for final review and merge.


Fix jq variable substitution

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/infinitered/publish-docs?version=0.2.4

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/infinitered/publish-docs?version=0.2.5


chore: Bump version to 1.3.0

What this PR does / why we need it:
Bump version to 1.3.0
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

None

/lgtm

/approved


Getting several errors on files

Followed the instructions and getting the following - not sure if this issue should be here or against the css modules repo, but hope someone can help:
=> Started proxy.
=> Started MongoDB.
[Error: File 'control' not found at any of the following paths: ["control","cont
rol.scss","control.sass","./_control","./_control.scss","./_control.sass"]]
[Error: File 'spinner' not found at any of the following paths: ["spinner","spin
ner.scss","spinner.sass","./_spinner","./_spinner.scss","./_spinner.sass"]]
[Error: File 'select' not found at any of the following paths: ["select","select
.scss","select.sass","./_select","./_select.scss","./_select.sass"]]
[Error: File 'mixins' not found at any of the following paths: ["mixins","mixins
.scss","mixins.sass","./_mixins","./_mixins.scss","./_mixins.sass"]]

TypeError: Cannot set property './components.scss.js' of undefined
    at ImportScanner._checkSourceAndTargetPaths (C:\tools\isobuild\import-scanne
r.js:256:7)
    at C:\tools\isobuild\import-scanner.js:159:12
    at Array.forEach (native)
    at ImportScanner.addInputFiles (C:\tools\isobuild\import-scanner.js:158:11)
    at C:\tools\isobuild\compiler-plugin.js:834:15
    at Array.forEach (native)
    at Function.computeJsOutputFilesMap (C:\tools\isobuild\compiler-plugin.js:80
5:19)
    at ClientTarget._emitResources (C:\tools\isobuild\bundler.js:913:8)
    at C:\tools\isobuild\bundler.js:684:12
    at C:\tools\utils\buildmessage.js:359:18
    at [object Object].withValue (C:\tools\utils\fiber-helpers.js:89:14)
    at C:\tools\utils\buildmessage.js:352:34
    at [object Object].withValue (C:\tools\utils\fiber-helpers.js:89:14)
    at C:\tools\utils\buildmessage.js:350:23
    at [object Object].withValue (C:\tools\utils\fiber-helpers.js:89:14)
    at Object.enterJob (C:\tools\utils\buildmessage.js:324:26)
    at ClientTarget.make (C:\tools\isobuild\bundler.js:675:18)
    at C:\tools\isobuild\bundler.js:2474:14
    at C:\tools\isobuild\bundler.js:2563:20
    at Array.forEach (native)
    at Function._.each._.forEach (C:\Users\genyd\AppData\Local\.meteor\packages\
meteor-tool\1.3.2_4\mt-os.windows.x86_32\dev_bundle\lib\node_modules\underscore\
underscore.js:79:11)
    at C:\tools\isobuild\bundler.js:2562:7
    at C:\tools\utils\buildmessage.js:271:13
    at [object Object].withValue (C:\tools\utils\fiber-helpers.js:89:14)
    at C:\tools\utils\buildmessage.js:264:29
    at [object Object].withValue (C:\tools\utils\fiber-helpers.js:89:14)
    at C:\tools\utils\buildmessage.js:262:18
    at [object Object].withValue (C:\tools\utils\fiber-helpers.js:89:14)
    at C:\tools\utils\buildmessage.js:253:23
    at [object Object].withValue (C:\tools\utils\fiber-helpers.js:89:14)
    at Object.capture (C:\tools\utils\buildmessage.js:252:19)
    at Object.exports.bundle (C:\tools\isobuild\bundler.js:2455:31)
    at C:\tools\runners\run-app.js:591:36
    at Function.run (C:\tools\tool-env\profile.js:489:12)
    at bundleApp (C:\tools\runners\run-app.js:581:34)
    at AppRunner._runOnce (C:\tools\runners\run-app.js:634:35)
    at AppRunner._fiber (C:\tools\runners\run-app.js:887:28)
    at C:\tools\runners\run-app.js:411:12```

In my copy and paste haste... i missed an @ on one of the imports... added it and all is peachy.


OpenFl 3.6.0 and Lime 2.9.0 compilation fixes

-Fixed compilation errors under new versions of OpenFl and Lime
Removed lots of untyped Object, and ObjectMap<Object,Object>
Also removed TweenLite, as I was unable to fix it to compile under 3.6.0, and moved to Actuate
Beware that the performance is worse than the original version, still working on it.
Polygon sample, doesn't compile yet

Thanks Marc. I will try it soon and let you know.

First of all thanks a lot for this hard work. I've tested your fixes and it's pretty good :+1:
But I have some comments :
1- The most recent version of modestmaps is modestmap js 3.3.6 with features like cabspotting or spotlight that are not yet included in the haxe version. So I don't think we should change the library directory version to 3.3.7 until we reach to port all those features.
2 - Both samples mapselector and polygons don't compile but I have the fixes.
3 - I don't really like the performance of Actuate maybe we will back to the previous Tweenlite after the merge. I've already worked on it.
So I will ask you perform another pull request with the good library version directory please.
Thanks and regards
Marcus

Hi Marcus,
Thanks for your encouragement, this is my first approach to Haxe and OpenFL as a night hobby.
It feels great to write some code again ;)
I will change to 3.3.6 and will update the repo during the weekend.
I agree that the performance of actuate is worse, but I was unable to fix the compile errors of the Tweenlite class, if you can it would be awesome.
After the merge, I will try fo fix the errors for the html5 output if you agree with that.
Best regards,
Marc

I'll push the fix for html5 compilation very soon...
Thanks and regards
Marcus


Large file size when storing GHEtool projects

When you have, for example, 10 scenario's calculated, saving them would require 60mB of data (due to the fact that also all the borefield objects are stored in a JSON-format). On the other hand, discarding the borefield objects and just storing the values within the gui itself, only requires 31kB.
For sharing purposes, it can be beneficial to only send the minimum amount of information (in the example above 31kB) instead of the whole, 60mB version.
It can be a good idea to implement two features:

[x] store borefield objects: yes/no
[x] next to 'save project', implement a button for 'export project', where the borefield objects are not storedµ

In a next step:

[x] investigate if we can store only part of the borefield object data

Therefore, an 'export borefield' icon should be created.

A third option could be to reduce the borefield saved data. Due to the fact, that the main time is needed to calculate the g-function. An option could be to just store this variable and calculate the rest of borefield variables.

Hi @tblanke ,
That is indeed a good idea. For now, I already removed the time_L4 variable and made it a property. This already excludes an enormous amount of data (100kb/scenario instead of 6mB), and hences solves already a lot of such storage problems.
However, when working with hourly data, the problem is even worse for it stores (for a simulation period of 20 years) not only 8760*20 values for heating/cooling load, but also that much in g-function data. We can investigate that further.

The returned pygfunction g-function is normally pretty small < 10 values. And the calculated values can be recalculated again, so just 8760 values from the external file have to be stored, I think.

This issue is solved in v2.2.0, together with the backwards compatibility issues.