fix: auto update nginx helm chart

Signed-off-by: ankitm123<EMAIL_ADDRESS>

/cc @tomhobson @babadofar @msvticket

/test gsm

/retest

/retest

/test gsm

/test gsm

/test gsm

/test gsm

/test gsm

/test gsm

/retest

/hold

/retest

/test gsm

/test gsm

I'm actually sceptical to this fix. Shouldn't the version rather follow the version stream?
To recollect: The reason for installing nginx with terraform is so the loadbalancer service is deleted before the cluster is destroyed so that the ELB is removed. But I would prefer to go back to installing the ingress controller with helmfile and
instead delete the services explicitly on destroy of the cluster.
That will also IMO make it easier to configure nginx.

The reason for installing nginx with terraform is so the loadbalancer service is deleted before the cluster is destroyed so that the ELB is removed.

It is only true in case of AWS, and even that is not the default option.

But I would prefer to go back to installing the ingress controller with helmfile and
instead delete the services explicitly on destroy of the cluster.

This is still the default option atm.
All this PR does is automatically upgrade the nginx charts when there is a new version available upstream.
Atm, we do it manually, and as we have seen in the past, we get stuck on old versions all the time.

/approve

/hold cancel

failed because of unrelated issue:
no need to gh auth as using github.com
--
  |   |   |   | Flag --confirm has been deprecated, Pass any argument to skip confirmation prompt
  |   |   |   | GraphQL: Could not clone: Name already exists on this account (cloneTemplateRepository)

Will investigate this issue soon, for now, good to merge.

/override gsm

Actually this issue happens because of 2 reasons:

We dont delete repos after testing :facepalm:
When we create a pa, we only take into account existing pa's in the cluster, not the ones stored in LTS.

In this case, all pas for this PR are gc'ed from the cluster, so it creates a pa with build number 1. But a repo exists with the same name, and so it fails.


Support for IDisposable?

Your example code:
public interface IGitHubApi
{
  [Get("users/{userId}")]
  Task<User> GetUserAsync([Path] string userId);
}

IGitHubApi api = RestClient.For<IGitHubApi>("https://api.github.com");
User user = await api.GetUserAsync("canton7");

If I want to dispose the RestClient after use, is this possible like:
public interface IGitHubApi : IDisposable
{
  [Get("users/{userId}")]
  Task<User> GetUserAsync([Path] string userId);
}

using (IGitHubApi api = RestClient.For<IGitHubApi>("https://api.github.com"))
{
  User user = await api.GetUserAsync("canton7");
}

See the README. Disposing the IGitHubApi will dispose the underlying HttpClient.
That said, you do not want to keep creating and disposing HttpClients. You want to create a HttpClient, and keep it around. There are plenty of blog posts on this topic.

Hi, does that answer your question?

Can you provide a link to some more details why httpclient should not be disposed/shortlived?

Here with some discussion.

Thanks.


chore: min_lines required default value '0'

feat(#38)
feat(#36)
doc(#46): simulation tests
doc(#25)
feat(#25): ChangesCount, ChangesCountTest, files.json
feat(#25)
feat(#25): branch cov down
feat(#25): no comments
feat(#25): clean for qulice
chore: default 0
required true default 0

PR-Codex overview
This PR increases the min_lines property in the action.yml file from optional to required.
Detailed summary

Changed min_lines property from optional to required in action.yml file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 3min)

@rultor release, tag is 0.0.14

@rultor release, tag is 0.0.14

@h1alexbel OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.14

@h1alexbel Done! FYI, the full log is here (took me 3min)


Missing options to Page::pdf

Added method to set header necessary for basic auth.

Hi @mschwerin I apologize for delays. I merged. I'll need to review and document the features before I tag the version. Stay tuned.


npm start should write the generated bundle.js to the filesystem.

Hi there. First than anything, thank you for this super awesome tool and all the hard work.
The reason of this ticket is that I think there should be an option to write the dev bundle.js to the filesystem. The reason is that I only use JS for the frontend. I have a monolith app written in PHP where I integrate other JS apps from standalone github repos. This is easy as just including their javascript bundle file in my html templates (those templates live in my php app) and then serve my html thru my own http server (nginx + fpm in my case).
I noticed that npm start command doesn't really write the bundle to any file, but serves it on the go. This is quite inconvenient for my use case. Not all of my JS apps are production ready, and I'd like to be 100% developing both JS and my PHP apps at the same time.
If the dev bundle.js file was written to the filesystem, my workflow would be:

I have a php app.
Inside a directory in that php app I cloned a react app from a github repo of mine.
In my html templates from my php app I should be able to reference the static/bundle.js file.
I make many edits to my JS app but npm start takes care of rapidly compiling everything.
I refresh my PHP web site that is served by NGINX.
I see my react app changes on the fly.
Once I'm happy with my react app, I use npm build.
I reference the production-ready bundle file in my PHP app html.
I deploy my PHP app to the cloud.

I think 90% of today apps are using JS in the frontend, but I doubt that's the exact case for backends. Further more, I personally do not require the built-in server (at least not atm). I just need something that watches my files and display nice error messages in the CLI.
All this said, I started looking at the code to see if I can spot what changes are required to achieve this. However I've found it difficult to grok all bits and pieces from the generated code (I was browsing the code that is generated after ejecting).
I'll keep looking into this, though I'm not an expert on webpack config. I'd also like to know if you think this level of implementation is too detailed that only fits my use case, or if you think others can benefit from such feature.
Sorry for the long post. Best regards.

Have you tried npm run build?

Hi @Guria. That is for building a production-ready bundle afaik, isn't it? I need the exact same behavior as npm start, just that I need a reference to the generated static/bundle.js file, thought currently it is served from memory and never written to the filesystem. If I'm missing something let me know please. Thank you!

Haha, it seems we are seeing more and more issues that is not really create-react-app, but about the usage of underlying tools.
Anyway, @leftdevel , as you might know, we use something called webpack to do those bundling things. There is actually an issue in its repo about writing bundle.js in developement (npm run start, as you called). I suggest you to take a look at the discussion in this issue. You will see several options to make that possible in webpack.

@dvkndn. Many thanks! By reading that thread you referenced I see the issue is on the webpack dev server side. Someone recommends running webpack with '--watch', though I'm not sure if that would be a 'plug&play' change I can make given the create-react-app dev setup. In any case I'll give it a go and I'll close this issue until I have a clearer picture.
Thank you all.

@leftdevel I think there is also an option that use a plugin. Either case, to make changes to underlying tools such as Webpack, you can reject or fork Create React App

I think it is still worth adding watch (or call it watch-build?) command to CRA which starts webpack --watch without starting a server. This will make integrations with non-Node.js backends much easier. I know, there's proxy functionality in WDS but some backends are to complex to be made reached by proxied so it will be easier to just serve bundles directly with them,

@andreypopp Can you file a new issue describing the use case in more detail?

Or is this description matching why you want it?
Do you only need this for prod builds?
Would npm run build -- --watch work for you?

@gaearon sorry, I wasn't being clear.
Yes, my use case is that I have a dev environment where static assets are served using a non-Node.js server (I think that's pretty common). I still want to do watch my source code and rebuild bundle when changes happen.

Would npm run build -- --watch work for you?

If that means a non-production bundle then yes.

Yes, my use case is that I have a dev environment where static assets are served using a non-Node.js server (I think that's pretty common).

I think that's a use case we don't properly support now for a variety of reasons (own development server being the biggest reason: trying to get two different servers to work together is a huge pain as can be seen in hundreds of webpack issues about that).
Of course we support doing that in production but why use a different development server?

why use a different development server?

Exactly because

trying to get two different servers to work together is a huge pain

and a non-Node.js dev server is basically something which is needed for app development in our environment — it exposes API and so on.
I think having a command which rebuilds a bundle and writes it onto filesystem is the simplest possible integration between CRA and already existing dev environments.

why use a different development server?

To be more clear, developers are not only working on frontend but also on backend (which happens to be coded in Python), which is why a different (env-specific) dev server is used. Such dev server should somehow integrate with CRA.

We suggest using proxy for this. Can you tell me more about why it doesn't work for you

The dev environment is on a remote server and served using an nginx which uses uwsgi to serve a Python app. We can make it work but it would be significantly more complex and costly rather than doing a simple integration through the filesystem (bundlers writes bundle onto fs, python app serves bundle from there).

What do you use CRA for? Just Webpack config mostly? It seems like most of its usefulness is the devserver (which is hard to configure by yourself) but things like Babel configs are already separated into presets.

@gaearon production builds, running tests.
Also one part of the developers use dev server (because they are developing locally) but others prefer remote workflow.

Makes sense. Should I reopen this issue or do you want to create a new focused one?

Created #1070

@andreypopp What about setting up a reverse tunnel so you can connect to the remote instance for dev?

unable to rebuild my project. this is happening after updated my package.json versions .
Can anyone help me with the possible solutions.


Automatically configure Git line endings for users at a repo-level

What
Automatically configure line endings for Git users to use Linux-style endings.
Why

Avoids mysterious 10k line diffs for new contributors on Windows.
Somewhat hilariously, unbreaks our shader import macro when folks clone down the Bevy repo or write their own imports. We can and should fix this directly, but there are other good reasons to do this anyways.

How
Follow these instructions.

Removed from the milestone and downgraded importance, as the consensus seems to be to fix the macro anyways.


No inventory was parsed, only implicit localhost is available

Hi,
Same issue and when I try to skip the index.html creation, no hosts matched.
$ansible -m ping all
[WARNING]: Ansible is being run in a world writable directory (/mnt/c/Splunkenizer/Vagrant/Splunkenizer), ignoring it as an ansible.cfg source. For more information see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-world-writable-dir
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

How should I specify the host created with vagrant?
I'm using Vagrant and VirtualBox.
Originally posted by @JuGuSm in https://github.com/splunkenizer/Splunkenizer/issues/18#issuecomment-967321546

I have created a separate issue for this, since it is not related to #18.

The inventory created by vagrant looks good so far. But from the warning in your first output you can see, that ansible is ignoring the ansible.cfg file if the directory is world writable. This means it does not find the inventory which is explaining the issue. You should change the mount options like mentioned here:
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-world-writable-dir
The quicker way to resolve this issue is to clone the repository in a non windows shared location inside the WSL virtual machine. So, it should be outside of the '/mnt/c/' directory.

@JuGuSm Could you please tell me, if you were able to solve this issue?

I did not get any feedback so far. So assume this is not an issue anymore.


Fix warnings with latest clippy

Summary
These aren't failing CI, which uses clippy at MSRV, they're just triggered by more recent versions.

Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

2 of 4 (50.0%)  changed or added relevant lines in 2 files are covered.
30 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 89.722%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/accelerate/src/target_transpiler/nullable_index_map.rs
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/expr.rs
1
94.02%

crates/qasm2/src/lex.rs
5
91.73%

crates/qasm2/src/parse.rs
24
96.23%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.03%

Covered Lines:
67319

Relevant Lines:
75031

💛  - Coveralls

I removed the stable backport tag here because the target rust code does not exist in stable/1.2 it was merged on main for 1.3.

Oh yeah thanks, I forgot about that.


[Feature Request] add PlainValidatorFunctionSchema support

@plusls Hi,
could you elaborate your request, please.

@dapper91 possibly the same as #229


Suggestion: Implement JS Standard Style

I wanted to suggest adoption of JavaScript Standard Style. This is purely in the interest of enforcing some consistency in the code from many contributors. Since it's pretty early in the codebase's life, it wouldn't be too hard to do, and it may help a lot down the road.

I was about to agree with this, but then I saw some questionable choices such as "No semicolons" and "Space after function name".
For something that calls itself "standard", you'd be hard-pressed to find JS code that uses zero semicolons. Also, people like to put spaces between ifs and their conditions while removing it from functions, to allow distinguishing between the two visually like
'''
if (this) {
thenThat(a,b);
} else {
otherThing();
}
'''

I agree that some of the formatting choices are not my favorites. I do love my semi-colons.
But I use Sublime Text, so I installed a package that auto-formats my .js files when I save them: https://packagecontrol.io/packages/StandardFormat . This makes it a lot easier.

Update 8/13/15:
We’re currently working on a document that outlines the specifications for JAWS v1.0.0.
A proposed resolution to this issue in particular is included in that document.
Today or tomorrow, we will share the document for everyone to comment on because your feedback is essential.

We're using airbnb's style guide, so this issue can be closed.

@ashack293 check https://github.com/jaws-stack/JAWS/pull/64 for our proposed implementation / enforcement of airbnb (with 2 tweaks).  Make sure to checkout the README.md cuz our choice of JSCS makes it easy to use with most editors.  FWIW I use WebStorm 11 and its working very nicely.

@doapp-ryanp yeah, I made a comment in the spec referring other Sublime Text users to the SublimeLinter package for enforcement of airbnb. I didn't really care which standard we used, so long as we use one ;)

Yup - JSCS overview has one too for sublime.    Totally up to you.

Cool, thanks!


Changed min Express version to 4.8.0 to avoid sendFile method bug

Node-inspector uses the method ServerResponse.sendFile, which does not exist in versions of Express prior to 4.8.0. However, package.json depends on ^4.0.
Closes https://github.com/node-inspector/node-inspector/issues/541 (theoretically ^^)

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <Re: [node-inspector] Changed min Express version to 4.8.0 to avoid sendFile method bug (#581)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Landed via 00ee378, I have fixed the commit message to follow the 50/72 rule. Thank you for the contribution.


Unable to resolve the request "adldap/login".

Hey @thepitagroup - really glad for your hard work on this plugin. We're trying to get it to work in our organization for a little micro-site. I'm not sure why, but I keep getting the error: Unable to resolve the request "adldap/login". I'm also noticing that the plugin isn't saving the Craft User Group handle.
I followed the readme, have a Pro version of Craft, and a user group set up.
Any ideas? Thanks in advance!

Thanks you for feedback. There was a couple issues that I resolved and commited back. That should fix the issue with the group not displaying on the back end.
For the resolve request issue,

make sure that in you /config/general.php you have the
,'loginPath'=>'login'
,'postLoginRedirect' => ''

like in this example
'*'=>array(
'omitScriptNameInUrls' => true,
'maxUploadFileSize' => 268435456,
'defaultTemplateExtensions' => array('twig')
,'loginPath'=>'login'
,'postLoginRedirect' => ''
),

make sure that the page that you want to password protect behind LDAP has this

{% requireLogin %}
{% if currentUser.isInGroup("WhateverTheGroupHandleYouHavePickedInYourSettings") %} //With matching closing {% endif %}

and last but not least in the login page which unless modified in the loginPath abaove should be at the root of your template and should contain this:
//CUSTOMIZE TO WHAT YOU NEED  DID NOT PUT LABEL

    {{ getCsrfInput() }}

Hi, @thepitagroup , I think that the issue that @joshkennedy is referencing comes from the fact that the "controllers/AdldapControllers.php" file should actually be named "Adldap/Controller.php". That fixed the route not being recognized for me.

I can confirm that. After renaming "AdlapControllers.php" to "AdldapController.php" it works.

@joshkennedy , @chrdavid Thank you both for pointing the problem. The controller name has been updated.


Search by reserve value doesn't work

I've tried h<0, h:-1 and h:1, and they return nothing.
Is that only for plot cards, and not modifiers?

It's only for plot cards, yes.


Punching zombie pigman with syringe gives "zombie" essence

As title says, Punching zombie pigman with syringe gives "zombie" essence. Prevents creating the "creative essence" required for the creative environmental controller module
Tested with 1.10-5.56 on 1.10.2 w/ FML <IP_ADDRESS> & Forge <IP_ADDRESS>9
Modpack: hermitpack

Looking at it further - looks like the tooltip contains an error, not the function of extracting essence.
I was able to use the "zombie" essence that I got from the pigman in the peaceful essence recipe. I was not able to use "zombie" essence obtained from a zombie inside the peaceful module recipe.


Label onClick Called Twice

I believe this to be related to this closed issue: https://github.com/rebassjs/rebass/issues/57
When I add an onClick on a Label element it is called twice.
https://codesandbox.io/s/dank-rgb-on5rg?file=/src/App.js
<Label
  sx={{ cursor: "pointer" }}
  onClick={event => console.log("Trigered Twice: ", event.target)}
>
  <Checkbox /> Will Get Called Twice
</Label>
<Label sx={{ cursor: "pointer" }}>
  <Checkbox
    onClick={event => console.log("Triggered Once: ", event.target)}
  />{" "}
  Only gets called Once
</Label>

Ah, this is probably a misunderstanding on my part. I researched on and found that is how it works with plain JavaScript with a label wrapping an input element. I updated the sandbox to demonstrate. I will close this issue as it is not Rebass specific


Customize ProblemDetails result of NotFound() call?

Is your feature request related to a problem? Please describe.
Starting with an ASP Core 3.0 API:
I return the result of NotFound() in my action.
[HttpGet("{id}")]
public async Task<IActionResult> Get(int id)
{
    var customer = await _db.GetCustomerAsync(id);

    if (customer == null)
        return NotFound();

    return Ok(customer);
}

The NotFoundResult is serialized to
{
    "type": "https://tools.ietf.org/html/rfc7231#section-6.5.4",
    "title": "Not Found",
    "status": 404,
    "traceId": "|b0f4249b-47f338d62c97e9a9."
}

Describe the solution you'd like
I'd like to comply with the RFC 7807 + pass some more detailed information to the user, maybe:
Returning NotFound($"Customer#{id} not found.") results in
{
    "type": "https://tools.ietf.org/html/rfc7231#section-6.5.4",
    "title": "Not Found",
    "detail": "Customer#123 not found.",
    "status": 404,
    "traceId": "|b0f4249b-47f338d62c97e9a9."
}

Is that or something similar possible?

@aureole82 you could return a Problem instance for this:
if (customer == null) { return Problem(statusCode: 404, detail: "Customer#123 not found."); }

@pranavkm Your answer is wrong. It always returns HTTP 200 OK!
It's far more verbose:
var problem = Problem("Customer#123 not found.", statusCode: (int) HttpStatusCode.NotFound);
problem.StatusCode = (int) HttpStatusCode.NotFound; // DRY?
return problem;

@aureole82 thanks. That's a bug that we addressed in 3.1.0: https://github.com/aspnet/AspNetCore/issues/14663.


Error exporting Data Package

Current Behaviour
I exported a Data Package .zip file. It shows as 0 bytes. When I unzip it a file with the same name but . cpgz is appended and shows as bytes >0. When I try to open that, a .zip with the original name is created.
Expected Behaviour
The exported Data Package .zip unzips to reveal the Data Package .JSON, CSV files and readme.metadata
Steps to Reproduce

create a Data Package in Data Curator
attempt to open the Data Package .zip file

Your Environment

Data Curator version: 1.1.0
Operating System and version: e.g. macOS Mojave 10.14.5

I am seeing this behavior as well in Data Curator 1.1.0 and MacOS 10.15.1 (Catalina)

Hi @Stephen-Gates @chriswhong
Atm negotiation is underway with our sponsors for  next round of work. I'll be able to look at this as soon as we get the go-ahead. Apologies for the delay.

Ok Various bug fixes and upgrade libraries for this first pre-release which include fixing export - will keep this open however until have a beta release version to test.


Added glassmorphism search bar

Fixes Issue🛠
#293 New Glassmorphism search bar
Closes #293
Description👨💻
Added new Glassmorphism search bar in Search bar component.
It is made using HTML and CSS.
How this has been tested✅
It is tested by me by running the website, no error found!
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷
https://github.com/Rakesh9100/Beautiify/assets/149922307/aa83acf5-11b0-4c2f-8a9a-c38c81e4a246

Pls edit the PR description and check the checkboxes by writing x in the bracket with no extra spaces everytime @AbhineshJha

Pls edit the PR description and check the checkboxes by writing x in the bracket with no extra spaces everytime @Prince-kushwaha-2004

@Rakesh9100
Done sir !

Merged 🥳 @Prince-kushwaha-2004


Add report view for email signups

This change adds a Wagtail report for pages with email signup blocks. The report view will show page metadata (title, updated date, type, status, URL) along with the email signup ID and an edit button linking to that email signup. The report is downloadable in CSV form as well.
Right now as a report view, there's no way to filter/search for specific pages or sign-ups. But I believe the basic outline of how to query for email signups could be ported to the email signup snippet view itself at a later date to make management of specific signups a little easier still.
There's some Django ORM wizardry that makes this possible in only 2 queries. I've tried to richly-comment that code in get_queryset on the EmailSignupReportView class, but please let me know if there's anything more that should be added.
How to test this PR

Download the latest data with ./refresh-data.sh
Pull this branch
Visit the report at http://localhost:8000/admin/reports/page-emailsignups/

Screenshots

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)

@csebianlander for awareness too.

This PR needs to hold. We're getting the wrong email signup IDs through in the report.


Compliance Report | Copy Paste should not be case sensitive |2|

Task:
This card is to have the compliance reporting spreadsheet plug-in not be case sensitive when copying and pasting values. For example, biodiesel should be accepted as a fuel type as well as Biodiesel. Currently only the latter is accepted when copying and pasting.
Affected Schedules & Columns:
This applies to the following columns:

Schedule B: Fuel Type, Fuel Class, Provision of the Act
Schedule C: Fuel Type, Fuel Class

https://trello.com/c/m1o7sLQE/1647-compliance-report-copy-paste-should-not-be-case-sensitive-2

 Compliance Report | Copy Paste should not be case sensitive |2|


Release "dev" branch to NPM?

Hi, I was wondering if it would be possible to merge the dev branch to master and release that to NPM? Or is there anything still needing done in the branch before it is merged that we can help with?
My problem is the dev branch has the required fixes for prop-types being moved to it's own package and currently we are having trouble updating a RN project because the NPM version of cacheable image still references React.PropTypes which is no longer available in React 16.

Ill get this merged over to master this weekend.

Hello. What about update?

@jayesbe thank you.


[Breaking Change][False positive] openapi-diff should filter out client parameters before checking parameter order

The ChangedParameterOrder rule should only fire when the order of the parameters for the method -- parameters not marked with x-ms-parameter-location: client change.
This rule triggers many false breaking change errors for some API definitions that are converted from OpenAPI to TypeSpec, e.g.
https://github.com/Azure/azure-rest-api-specs/pull/25569

doc for x-ms-parameter-location

Basically, this rule says that when generating language (e.g. C#) SDK clients, the parameter will either be a C# property on the client class (value: client), or it will be a C# method parameter on the C# client (value: method).
@mikekistler you wrote:

The ChangedParameterOrder rule should only fire when the order of the parameters for the method -- parameters not marked with x-ms-parameter-location: client change.

I understand that strictly speaking you wanted to say:

The ChangedParameterOrder rule should only fire only on parameters with x-ms-parameter-location: method property.

Correct?
What you said is effectively equivalent a little bit by coincidence. This is because:

When a parameter has no x-ms-parameter-location, its value is by default client so order doesn't matter
When a parameter has x-ms-parameter-location set to client, then its order doesn't matter.
The only other remaining valid case is when x-ms-parameter-location is set to method, and this is the only case when the order matters.

Correct?

All correct.


#2404 Modal open calls should complete in order

This is a second PR attempt for issue #2404. (PR #2443 has rebase issues and will be closed.)

On superficial review, this LGTM, but I'd like to review it more once we fix the tests in master and test this out.

I wanted to comment on your last remark on #2443 questioning the decision to have a chained modal resolve even if a modal above it in the stack was rejected.  It's a fair point.  If you're firing off a stack of modals and one in the middle fails, then continuing to open other modals on top of where it would have been is questionable.  There isn't really a recovery strategy there since you can't insert into the middle of the stack.
On the other hand, exposing the rejected value from higher in the stack to modals below is a minor encapsulation leak.  Those modals may not be aware that they are stacked, and receiving a rejection from outside their own scope is questionable.  And the stacked modals could (due to the asynchronous nature of resolution) be fully resolved and ready to go as far as their dependencies go which might create issues in the client code if it's not aware that a successful resolve could be blocked by an outside factor.
I left the code as it was (ignoring an upstream rejection) for now.  Going the other way isn't hard, but I don't think there's a completely satisfactory approach, and it doesn't seem likely to be a common concern.


(BKR-766) Install puppet agent on huaweios

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2369/
Test PASSed.

@kevpl Fixed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2393/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2396/
Test PASSed.


Suggestion! 1.19.2.

Hey there!
Awesome mod, first time trying it out.
Would it be possible to make spawned bosses not despawn like regular mobs?
Sometimes a rare boss spawns, and it despawns before I can even get to it, since it's, for example; across a lava lake.
I figured since they're named, they wouldn't despawn by default, yet they still do.
Checked the config files, but I don't see an option related to boss despawning, so I figured I'd post a suggestion here!
Cheers!

I can't make them never despawn as they would eventually start piling up too heavily.  You could install https://www.curseforge.com/minecraft/mc-mods/mob-despawn-timers to ensure that all mobs stick around for a certain duration before being removed by the spawn process.

I can't make them never despawn as they would eventually start piling up too heavily. You could install https://www.curseforge.com/minecraft/mc-mods/mob-despawn-timers to ensure that all mobs stick around for a certain duration before being removed by the spawn process.

Ah, that does make sense.
But what if the game (in this case your mod) would check for existing bosses in loaded chunks before spawning new ones, in which case it won't if there are; let's say, 5 Apotheosis bosses, ?
I'm no mod developer, so I'm likely unaware of what I'm actually even asking in terms of difficulty and hassle, in which case I do apologize. - But, what are your thoughts?
But I'm definitely going to try out the mod you just suggested and make do with that.
Cheers!


[Stoch] PC coefficient database

A database with the SSFEM coefficients for the various M and p needs to be implemented (@isaar/stochastic)

refer to @dgiov16 for help on this

The structure of the augmented matrix is not always fixed and it depends on the choice of the problem's random parameters. For instance, considering both the elastic modulus and the moment of inertia as random fields will yield a different formulation for the stochastic stiffness matrix.


Texture Background

Hi, i'm a eSports manager and currently working on a MTGA tournament series. Someone showed me the tracker, but as far as i can see i can forge results in a print with minimal knowledge. A complex background would help a lot in preventing this issue.
Ps: Also feel free to contact me if you guys have any ideas regarding tournaments, i will probably email you eventually anyway :)

Hi! We have tournament platform on other CCG project, TES Legends. You can take a look here: https://teslegends.pro/tourn/
And same system is planned to be implemented for MTGA. If you are interested in tournament organization, please email me on<EMAIL_ADDRESS>


Compilation error on OSX with nix 0.3.7 and mio 0.3.5

I get the following message at compile time:
mio-0.3.5/src/sys/unix/kqueue.rs:1:5: 1:19 error: unresolved import `nix::fcntl::Fd`. There is no `Fd` in `nix::fcntl`

same here.

woops

I pushed a fix to the v0.3.x branch (https://github.com/carllerche/mio/tree/v0.3.x) could somebody verify it is good and I can push a release.

Compiled without any issue.
~/Developer/rust/mio (v0.3.x)
❯ cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading tempdir v0.3.4
 Downloading nix v0.3.7
 Downloading bytes v0.2.9
 Downloading rand v0.3.8
   Compiling bitflags v0.1.1
   Compiling libc v0.1.8
   Compiling gcc v0.3.8
   Compiling bytes v0.2.9
   Compiling nix v0.3.7
   Compiling log v0.3.1
   Compiling time v0.1.26
   Compiling mio v0.3.5 (file:///Users/lishuo/Developer/rust/mio)

Here you go: https://crates.io/crates/mio/0.3.6
Hopefully this fixes it! Open another ticket if there are any other issues :tada:


Fix the create-pr job selection

I'm gonna merge this as this shouldn't break anything :tm: , but it's blocking deploying a fix on the build-definitions repo.

It did work!


Transformation of string to raw string literal in caniuse_feature_matching

Transformation of string to raw string literal in caniuse_feature_matching. https://github.com/oxc-project/oxc-browserslist/issues/23#issuecomment-2143506720

Thank you so much! We also need to check in the generate file
https://github.com/oxc-project/oxc-browserslist/blob/0faa9688d98b7f8dc90df9e5bf0f3d0c0e2462e8/.cargo/config.toml#L2


Panic in adapted simple_window example when using use_system_lib feature.

I changed the simple_window example to use xdg_shell instead of wl_shell (code).
It works as expected when use_system_lib is not set, but when it is, the program panics with the message Attemping to create an object from a non-attached proxy. (stderr with RUST_BACKTRACE=full and WAYLAND_DEBUG=1.
It's entirely possible that I'm doing something bad, but I'd expect the program to work the same way whether use_system_lib is set or not.
System info:
Fedora 30
gnome 3.32.2 or sway 1.2-rc1-48-ga085e649
rustc 1.38.0 (625451e37 2019-09-23)
libwayland-client 1.17.0
wayland-client (rust) 0.24.0

Indeed, the use_system_lib feature should not change the behavior, so there is definitely a bug in wayland-client.
Your code looks correct, so I suspect the issue is with the code using the system lib.

If I remove this check the program works as expected, but the proxy_create_unattached test fails.
I'm still receiving events on the WlSeat object, which I wouldn't expect to be the case if it truly was non-attached (assuming it refers to not being attached to an event queue).
It also seems weird to have an is_none check and then use unwrap_or right after.

In wayland-client's wording, "attached" does not refer to the wayland object, but to the proxy (handle to the object). An object is always assigned to an event queue on creation, and this assignation can never change. However, when a proxy is attached to an event queue, this makes new objects created by this proxy to be assigned on this event queue. This is why methods that create new objects can only be called on AttachedProxy (or MainProxy, which counts as attached to the same event queue as the underlying object is assigned).
The check you identified, ensures that creating an object is never attempted from a non-attached proxy (as the newly created object wold not be assigned to any event queue). However, there appears to be an issue in the code tracking which event queue a proxy is attached to, making it believe it is not attached while it should be.
I suspect I messed things up in the tracking of invariants, and the unwrap_or you spotted is a hint of that. An attached proxy with the C libwayland backend should have self.wrapping set to Some(..) if it is attached, and to None otherwise.

When I do an event_queue sync_roundtrip() after I attach the buffer I get "[wayland-client] Protocol error 3 on object xdg_surface@9: xdg_surface has never been configured"
https://paste.gg/p/anonymous/8b18f797ec224a9baebfca6b75828e4e


Tiny patch

Just have no idea for what here used slow function to switch between two constants. Is there deep meaning?

Just for semantic reasons. Before was clear valid arguments and then the default fallback.

Closing, as the branch is no longer available.


[Spike] Email notifications

User stories
As a owner I want recieve lending requests via Email in order to get updated on current events, without checking the web app.
As a borrower I want the get notified throughout the lending process in order to lent the item and return it in time.
Dependencies
Depends on:

#14
#46

UI Mockup
not applicable
Context
Users should receive an Email when receiving a notification on the notification page (#30).
Acceptance Criteria

[ ] create the possibility to send notifications automatically via email to the recipient
[ ] All important notifications have templates for emails

What are important notifications?

This article explains everything regarding mails in rails: The ultimate guide to sending email in rails 7


Modrinth version?

While updating my 1.20.4 modrinth profile today, fabrishot automatically updated to version 1.13.0, which gives the following error:
Incompatible mods found!
net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other!
A potential solution has been determined, this may resolve your problem:
	 - Replace mod 'Fabrishot' (fabrishot) 1.13.0 with any version that is compatible with:
		 - minecraft 1.20.4
More details:
	 - Mod 'Fabrishot' (fabrishot) 1.13.0 requires version 1.20.5 of 'Minecraft' (minecraft), but only the wrong version is present: 1.20.4!
	at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:51)
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:195)
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:146)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Looks like the mod is built against minecraft 1.20.5, but was uploaded to modrinth with minecraft version 1.20.4
Manually changing fabrishot's version back to 1.12.1 allows the game to load, so it's not a major issue, just ever so slightly annoying ;)

Oh it looks like they update forgot to update that... fixed now


Testing, please ignore. (xmdruv)

This is a bug bounty test. Please ignore.. Please DO NOT APPROVE THIS! (xmdruv)

Why are you sending environment variables to an environment?


Improved termination heuristic when response is < batchsize/2 and the…

… resulting event stream has contigious sequence numbers.
I'm unsure if its a bug or by design, but the current sql support can/will fail if a given aggregate has jumps in sequence numbers that are > batchSize.
This feature requires that batchsize be doubled from its current value to retain existing (somewhat questionable) behaviour.
I will admit that I find the batchSize vs maxGapOffset somewhat confusing (the docs on maxGapOffset are beyond my comprehension).
I somehow perceive batchSize to be at a lower layer controlling interactions with a single store. As such
this termination heuristic is applied at the same level.
It might be that someone needs to rethink the overall architecture somewhat around this.

This pr can hopefully be applied on top of  #1689  or straight on master. It is an additional feature and totally independent of 1689. I have tried to use all my conflict-avoidance skills to make these two prs individually mergable.
Given the current "feature" of not supporting gaps in event sequence numbers larger than batchSize, users should considering doubling batch size to retain existing behaviour.

This pr can hopefully be applied on top of  #1689  or straight on master. It is an additional feature and totally independent of 1689. I have tried to use all my conflict-avoidance skills to make these two prs individually mergable.
Given the current "feature" of not supporting gaps in event sequence numbers larger than batchSize, users should considering doubling batch size to retain existing behaviour.

I see the failing testcases, which suggest to me that coupling the early termination criteria to batch size might be a bad idea. I am unsure of the required support for sequence number jumps. For good (or bad) we have renumbered all of our sequence numbers in those cases we have deleted events. I suppose it might make sense to not encode the early termination criteria as batchSize /2 but make it a separate builder parameter that only works when enabled.
I await your feedback on this before adapting further

I see the failing testcases, which suggest to me that coupling the early termination criteria to batch size might be a bad idea. I am unsure of the required support for sequence number jumps. For good (or bad) we have renumbered all of our sequence numbers in those cases we have deleted events. I suppose it might make sense to not encode the early termination criteria as batchSize /2 but make it a separate builder parameter that only works when enabled.
I await your feedback on this before adapting further

I have suite surprisingly been looking int this same area not too long ago.
More specifically followed by issue #1682
The mentioned issue, I would imagine a window of opportunity that the retrieved batch contained no events.
Simply because of the use of a historic and active EventStorageEngine, which obviously deviate with their sequence numbers.
Whenever another storage engine is used, however, I would assume the gaps between events no to exceed the batch size, ever.
In any sense, it is definitely not intended too.
So, would you mind elaborating for which exact storage engine implementation you would desire this adjustment?
And furthermore, for which operation on said storage engine you require this change?
Thanks in advance @krosenvold!

We're using the plain sql mysql implementation with dual databases, just like #1689. As for my observations about failing when gaps exceed batchsize they may have been done on a slightly outdated axon version, and I see that you added lots of testcases fairly recently. So I find it reasonable to just "forget" any comments I had about missing events, especially after #1689 was resolved. The issue still remains though, that the termination criteria seem to be quite heavily slanted in favour of people with large gaps in sequence numbers - to the point of giving users with "clean" databases a noticeable performance disadvantage. I see the flag fetchUntilEmpty is implemented but seems to be fairly obviously buggy because it can fail at the loss of a single sequence number in the wrong place (and is not in use anywhere).

I am uncertain what your argumentation of a "clean" database is in this case @krosenvold.
I would wager that a single EventStore storing your events should not, ever, have any gaps for aggregate events.
The only case gaps would occur for aggregate stream retrieval, is when using the SequenceEventStorageEngine, as this introduces N potential stores which carry your info.
If you would be able to shed some light on your perspective of "what a clean event store" is, I could provide better argumentation, if neccesary.
Now, going back to the "termination heuristic", it is worth the discussion whether the BatchingEventStorageEngine should be the place to even do this at.
As stated in the aforementioned issue #1682, we see the following comment from haraldk:

As mentioned in the PR #1683 discussion, I think the problem is really caused by the JdbcEventStorageEngineand/or the EventStreamSpliterator in BatchEventStorageEngine. That's what I meant by "partial".
I think the main problem is in the SQL generated that sets an upper bound on the sequence number, rather than using limit to create the correct batch size. The current implementation will still cause problems if there are somehow gaps in the sequence numbers (as the batch fetching code in the spliterator will stop if the number of results are less than the batch size).
Perhaps this should be filed as a separate issue, otherwise I suggest leaving it open until this is addressed.

I'd lean more towards this idea too. It is the SQL performed which should be different if not everything returned whenever using the SequenceEventStorageEngine.
Changing this to a vendor-specific SQL which limits the number of rows returned seems to me to be an easier solution to implement.
Going the vendor-specific route in Axon Framework is however taking it a step too far, as that would require us to implement any conceivable approach out there.
This is why the JdbcEventStorageEngine (which I assume you are using two instances off given your description) allows you to configure the SQL being used to retrieve events as well.
Now, to conclude this comment, I am not entirely sure whether this resolves the problem you are facing.
Mainly, because I am still unsure whether you use the JdbcEventStorageEngine, JpaEventStorageEngine, MongoEventStorageEngine and/or the SequenceEventStorageEngine at all.

Just to be certain we're discussing the same thing; I'm talking about the "sequenceNumber" column that is local to a specific aggregate. This should always be sequential and without gaps, even with multiple databases. (So should not be confused with the "id" column, which has gaps)
I believe the root cause of this whole "design" is that the world is a harsh and unfair place to live in. So while events in the database should not be deleted, reality has a way of challenging this every now and then. Say some runaway process created 50 million events on a single aggregate overnight. For most users this means deleting events in the database just to restore normal operations. There are also a few other "plausible" reasons why a user might want to delete events within an aggregate.
When I say our database is "clean" I simply mean that when we have deleted events, all the subsequent sequence numbers have been renumbered so the sequence numbers are contiguous.
And all of the termination logic within the sql driver indicate a certain tolerance for missing sequence numbers. There appears to be a certain consensus that this "cannot happen". but it happens - and not just to us (I am the original author of the axon plain sql driver and this tolerance has been there since before I implemented this driver!).

Hi @krosenvold, not our biggest display of speedy reactions 😉, but it took a while to get my head around what you were exactly trying to achieve and how best to do that.
I have made some changes to your to make the termination heuristic configuration through the builder. That way, besides the "either empty or not full" approach that was already available by overriding a method, there is now a less intrusive way to configure the exact heuristic you'd like to use.
Let me know if this doesn't address the problem you have. Happy to discuss any changes.


Breaking changes we want to make

What kinds of currently-working semantics are we OK with breaking?

Description
Dropping a value of type  Box<ZST> twice, where ZST is a zero-sized type,
Reason for breakage
We may want to add debuginfo for all allocations.
Example that will become UB
fn main() {
    let mut b = Box::new(());
    drop(unsafe { Box::from_raw(&mut *b) });
    drop(unsafe { Box::from_raw(&mut *b) });
}

This is more of a library issue, but I am afraid people are already abusing it.

Description

The ordering of fields in a non-repr(C) struct may change.

We may want to exclude alignment padding from the size of a type (https://github.com/rust-lang/rfcs/issues/1397)

Reason for breakage
Better struct packing, lower cache usage.
Problems

This will break any code that makes assumptions about the layout of non-repr(C) types.

This will break code that overwrite a value by writing to mem::size_of::<T> bytes. As far as I know the only affected crate is atomic-rs, which needs to use mem::size_of_inner::<T> instead.

@Amanieu number 2 is unlikely to change, afaik. It would result in slower, more complicated code. However, it is possible.

I feel like collecting these in a single issue will quickly become annoying. I propose that we create a tag ("proposed-breaking-change") and then just create issues for each of them.

Closing for now. non-repr(C) field order has indeed changed; for the "tail padding" of a type see https://github.com/rust-lang/unsafe-code-guidelines/issues/176 and https://github.com/rust-lang/unsafe-code-guidelines/issues/306; and the Box change should probably have its own thread if someone wants to pursue this.


Private key & public key usage clarified

@ulhaq : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Optimize performance / energy use of GitHub actions

Documentation extraction depends on the same build steps that the regular build/test does, use dependent jobs to do the build steps once for both cases
LLVM setup is an early build step that is depended on by build steps for different configurations on a given platform; the same kind of refactor could be used
Evaluate the relative time it takes to do things on the different platforms, including the devcontainers, and consider choosing the platform for doc extraction differently.
Consider whether there's anything we can do to use cacheing (actions/cache@v3) more effectively, e.g. cacheing the results of LLVM builds.

See also #950, which is related.

Documentation extraction depends on the same build steps that the regular build/test does, use dependent jobs to do the build steps once for both cases
LLVM setup is an early build step that is depended on by build steps for different configurations on a given platform; the same kind of refactor could be used

You can't simply use dependent jobs to ingest build artifacts from other jobs. See this stackoverflow question for proof. The suggestion is to add the dependency and transfer the artefacts with actions/upload-artifact and actions/download-artifact. Since the entire setup is downloading and installing, the former should already be cached and the latter cannot be cached, there is not really anything to be gained here.
For the LLVM artefacts we can cache the downloading of the binaries but not the installation on the specific platform. See [documentation[(https://github.com/KyleMayes/install-llvm-action#example-usage-with-caching). This would be worth doing.

Any alternative is fine with me.  The use of dependent jobs wasn't really supposed to be a part of the goal, even if it was phrased that way.

Also it would be good to evaluate our existing cache steps to see if they are providing any value.

@WalterSmuts IIRC you found that caches were a net loss, and this seems to confirm that.

Yup, it was triggered by https://github.com/KyleMayes/install-llvm-action/issues/56


Website fails to load on some web browsers

CoVizu crashes when loading the page on Safari and Firefox, but not Google Chrome.
Error messages when loading the page on Safari:
[Error] Error: Invalid value for <line> attribute x1="NaN"
	(anonymous function) (d3.js:1211)
	selection_each (d3.js:1176)
	drawtree (drawtree.js:151)
	(anonymous function) (covizu.js:152)
	fire (jquery.js:3496)
	fireWith (jquery.js:3626)
	done (jquery.js:9786)
	(anonymous function) (jquery.js:10047)
[Error] Error: Invalid value for <rect> attribute width="NaN"
	(anonymous function) (d3.js:1211)
	selection_each (d3.js:1176)
	draw_clusters (drawtree.js:338)
	(anonymous function) (covizu.js:154)
	fire (jquery.js:3496)
	fireWith (jquery.js:3626)
	done (jquery.js:9786)
	(anonymous function) (jquery.js:10047)
[Error] Error: Invalid value for <rect> attribute x="NaN"
	(anonymous function) (d3.js:1197)
	selection_each (d3.js:1176)
	draw_cluster_box (drawtree.js:52)
	(anonymous function) (covizu.js:169)
	fire (jquery.js:3496)
	fireWith (jquery.js:3626)
	done (jquery.js:9786)
	(anonymous function) (jquery.js:10047)

I backtracked through the commit history and it seems that my fix for #331 works in Chrome but not Safari, hence resulting in the NaN error messages. I've found an alternative that works cross browsers so I'll push that to dev. However, the issues with Firefox seem to predate that commit so I'm not sure what's up with that.


helios-solo: use bridge interface for http healthchecks

If the agent is using unix:// to communicate with Docker, then the
HttpHealthChecker ends up using localhost as the host in the URL it
constructs to healthcheck the job.
When the agent is running in helios-solo (i.e. in a Docker container
itself), the agent uses the default unix:///var/run/docker.sock endpoint
to talk to Docker but a HTTP request to
localhost:external-port will not work as localhost refers to the
container itself.
In the scenario where the agent is running in helios-solo and docker.host
is using the unix protocol, this change will have the
HttpHealthChecker instead use the bridge address of the container to send
it's healthcheck to.
In order for the agent to know if it is running within helios-solo, added a
system property in the helios-solo startup script. This property is also
enabled for the master as well in case it is needed in the future.
This is a tweak of #828 so that the logic to use the bridge interface is only applied when using helios-solo.

Current coverage is 45.68%

Merging #833 into master will decrease coverage by -0.13% as of 9cacdfe

@@            master    #833   diff @@
======================================
  Files          262     262
  Stmts        11052   11057     +5
  Branches      1542    1535     -7
  Methods          0       0
======================================
- Hit           5063    5051    -12
+ Partial        441     440     -1
- Missed        5548    5566    +18

Review entire Coverage Diff as of 9cacdfe

Powered by Codecov. Updated on successful CI builds.

:fireworks: :tada: all the tests pass on the first try :tada: :fireworks:
@negz @gimaker @rohansingh @davidxia

to be clear having the HttpHealthChecker branch on a system property to check if it is running inside helios-solo or not feels pretty hacky; but I wasn't sure how to programmatically have the agent know if it is running inside a container (which is on the same host as the container for the actual job).

LGTM
It does feel a little hacky, but I can't think of a better way.

:100:

Would prefer to change the logic so that it uses the bridge address when Helios ís running in a container, regardless if it's helios-solo or not.

@gimaker fair point. See ce5a65c

:+1:


BracketPair no longer works

BracketPair has stopped working altogether. I code in Apex, and the brackets in my code are all white. (When I swap to another language, the brackets become colored again)

Thanks for reporting. I will include this in the next release

Should be fixed in v1.0.37
PrismJs doesn't support this language so I mapped to be treated as Java


[bug]: Service update tab does not indicate "update available" tag on services

Prerequisites

[X] I have searched for existing issues that already report this problem, without success.

EmbassyOS Version
<IP_ADDRESS>
Device
Laptop/Desktop
Device OS
Linux
Device OS Version
5.16
Browser
Firefox
Browser Version
99
Current Behavior
Update tab shows green "Installed" badge, instead of yellow "Update available" tag
Expected Behavior
Show tag as described above
Steps to Reproduce

Updates tab in Marketplace
View a service with an update

Anything else?
No response

This is a bug that needs investigation.
This is related wrt needing better copy. These two issues can likely be resolved together.

CC @MattDHill for reprioritization

Ditto on this issue, I have been running an old version of LND as I missed this upgrade due to misreading the update page: I understood "installed" to mean that I had the most recent version

Ditto on this issue, I have been running an old version of LND as I missed this upgrade due to misreading the update page: I understood "installed" to mean that I had the most recent version

This is reasonable as older versions of EmbassyOS did inform when updates were available on the marketplace. At some point a refactor introduced this bug, and it should be relatively easy to sort out.

Moving to 0.3.1 and assigning to self.


When user add product in cart from category page it redirects them to cart page.User should not redirect to cart page if he click on  Add to cart button

Framework Version: 0.1.5

Framework Version: 0.1.5
Fixed


Schedule API Access, "personal" feature gate

First, we should introduce a new feature called personal. This feature only works if the api feature is enabled. The idea is that this feature, if enabled, allows the user to access data specific to their account (hence the "personal" name). For example, the user will be able to get their schedule through an endpoint in the API if the personal feature is enabled. We can also use this opportunity to add endpoints like enrolling in classes automatically.
As mentioned above, we should give the user the ability to access their own schedule using the API. This endpoint's code is very similar to the code used by the other endpoints, the only difference being that there's a feature gate on the corresponding code.

Not doing this due to it being out of scope of project


Init 22.06 changelog [skip ci]

Signed-off-by: Peixin Li<EMAIL_ADDRESS>Init changelog of 22.06 w/
GITHUB_TOKEN=XXX scripts/generate-changelog --releases=21.06,21.06.1,21.06.2,21.08,21.08.1,21.10,21.12,22.02,22.04,22.06

We will have a final update changelog update before release

@sameerz @GaryShen2008 please help review if any PR/Issue titles/labels need to be adjusted, thanks!

@pxLi I reviewed the issues, feel free to regenerate the changelog.

build


Add support for disabled attribute on dropdown menu items

Hi! I added support for the disabled attribute on the dropdown_menu_item component.
I don't know whether this is the correct way to apply styling. I tried to mirror the approach that the button component uses.
Also, sorry for the giant diff! I removed the annoying brackets the formatter adds everywhere. Btw, that has been fixed a while ago in ElixirLS, see elixir-lsp/elixir-ls#526.

Thanks - looks good. Yeah we used string interpolation elsewhere in the project, although now I think the best way is to use a list.. eg "#{@class} pc-dropdown__menu-item #{get_disabled_classes(@disabled)}" => [@class, "pc-dropdown__menu-item", get_disabled_classes(@disabled).
Is it possible to add a test in dropdown_test.exs?

On it!

So the Link.a component that's used under-the-hood expected a :string in the attrs, so I changed that to :any, since I don't think the syntax supports union types.

🙏

Released in 1.4.6. Thanks for this!


Can't uninstall packages that I installed with home-brew.

i was trying to uninstall an app that I installed with home-brew.
Then I realize that I can't uninstall and getting
Error: No such keg: /usr/local/Cellar/vivaldi

I have tried brew doctor and it didn't fix the problem. And here is my config file if anyone considering.
My config file at ubuntu paste.
And here is the detailed short video

From the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from every submitting issues to Homebrew again.

If you add the necessary information this issue may be reopened.

Edited.

@MuhammedKpln We still don't have your brew doctor output or the brew commands you've run to produce your error.


[Bug]: MudExPopover does not appear to properly dispose of JS click event listener when re-rendering the component

Contact Details
<EMAIL_ADDRESS>What happened?
I have a table where each cell uses a MudExPopover for editing the cell value.
I noticed that if the parameters on the page have changed several times, then the page begins to behave very slowly.
I've tracked this issue down to the MudExPopover and the fact that each time the component re-renders, more and more click event listeners are getting added to the document.
I have enabled 'DisposeEvent' on the component but that doesn't appear to solve the issue, in fact it only serves to cause the following error to appear in the browser log each time the popover component is rendered:
Uncaught (in promise) Error: System.ArgumentException: There is no tracked object with id '7'. Perhaps the DotNetObjectReference instance was already disposed. (Parameter 'dotNetObjectId')    at Microsoft.JSInterop.JSRuntime.GetObjectReference(Int64 dotNetObjectId)    at Microsoft.JSInterop.Infrastructure.DotNetDispatcher.BeginInvokeDotNet(JSRuntime jsRuntime, DotNetInvocationInfo invocationInfo, String argsJson)     at kt.endInvokeDotNetFromJS (blazor.server.js:1:3700)     at blazor.server.js:1:72077     at Array.forEach (<anonymous>)     at kt._invokeClientMethod (blazor.server.js:1:72063)     at kt._processIncomingData (blazor.server.js:1:70105)     at connection.onreceive (blazor.server.js:1:64508)     at o.onmessage (blazor.server.js:1:48842)
Refreshing the page solves the problem as all of the JS events will be cleared.
Using the command getEventListeners(document); in the browser console shows that the list of 'click' listeners increases with each render of the popover.
Expected Behavior
Disposing of a MudExPopover component should be properly disposing the JS click event.
Screenshots
Screenshot of browser log error

Screenshot of usage of MudExPopover in code

Screenshot of JS function adding click event listener

Reproduction link
https://trymudex.azurewebsites.net/snippet/wkQHvbEwoRUrrWnK
What application type are you referring to?
ServerRendered
Custom Application Type
No response
MudBlazor.Extension Version
1.7.75
MudBlazor Version
6.11.0
What browser are you using?
Edge
Sample Solution
No response
Pull Request
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I've been doing a bit more digging. Could it perhaps be caused by BlazorJsEventInterop? It appears to be adding event listeners but doesn't remove them when DotNetObjectReference is disposed.
I found this StackOverflow question which describes a similar issue: Link

Thanks for reporting. I will have a look on it.

I've fixed the issue. Will be released in 1.7.76.
You can test it with the preview package 1.7.76-prev-2311022342-main
Please ensure browser scripts are not cached when testing it. For example use incognito tab

Perfect. That's solved our issue completely. Thank you very much :)

you're welcome.


add user judgegodwins to beta testers

I'd like to join the list of beta users. I'd also like to contribute to fonoster

I have read the CLA Document and I hereby sign the CLA

@judgegodwins
Welcome to the private beta 😀


Can BTM be used to assign topics to new sentences?

Hi,
We're working on short text topic modelling at DataWeave, and are interested in using bi-term topic modelling to try to scalably assign products to product titles sourced from e-commerce websites.
We are interested in using your library for this purpose, but so far this library only seems to be able to assign topics to sentences in its training set.
Is there a way to be able to segment training and prediction into two separate tasks i.e. where we could train on a subset of documents, and attempt to predict another subset?
Failing that, if training on all new documents is necessary, would BTM be scalable i.e. would it repeat training over all documents, or cache an existing training model and then update the training model with the new document?
Thank you.

Dear Mahajan:
Thanks for your interest of our work.
There is no barrier for BTM to infer the topics in another subset of
documents. The only thing you need to care is to filter out the words out
of the vocabulary of the training set.
If you new document set is very large, you can scalable BTM with spark. Or
if your just want update the model incrementally, you can use the online
BTM: https://github.com/xiaohuiyan/OnlineBTM. The algorithms is described
on the paper: http://shortext.org/paper/BTM-TKDE.pdf
Bests,
Xiaohui
2015-06-26 12:50 GMT+08:00 Akshat Mahajan<EMAIL_ADDRESS>
Hi,
We're working on short text topic modelling at DataWeave
http://dataweave.in/, and are interested in using bi-term topic
modelling to try to scalably assign products to product titles sourced from
e-commerce websites.
We are interested in using your library for this purpose, but so far this
library only seems to be able to assign topics to sentences in its training
set.
Is there a way to be able to segment training and prediction into two
separate tasks i.e. where we could train on a subset of documents, and
attempt to predict another subset?
Failing that, if training on all new documents is necessary, would BTM be
scalable i.e. would it repeat training over all documents, or cache an
existing training model and then update the training model with the new
document?
Thank you.
—
Reply to this email directly or view it on GitHub
https://github.com/xiaohuiyan/BTM/issues/1.


Fix cstyle error in src/assert.h

Repo: openebs/istgt
Branch: replication
File: src/assert.h
Steps to compile in: README.md
PR subject should be like: fmt(cstyle): cstyle fixes in <filename>
./src/assert.h: 109: preprocessor statement not in column 1
./src/assert.h: 113: preprocessor statement not in column 1

I would like to work on this one

Thanks for showing interest, and, please go ahead @avnish98

@avnish98 Okay, I will open a work in progress pull request

As there is not activity related to this issue , making it UpForGrabs for other contributors


Fork master

Codecov Report

Merging #36 into master will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   94.33%   94.79%   +0.46%
==========================================
  Files          42       42
  Lines         618      615       -3
==========================================
  Hits          583      583
+ Misses         35       32       -3

Impacted Files
Coverage Δ

ReportPortal.Client/Service.cs
100% <ø> (+10.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bf84b...4f674cb. Read the comment docs.

This PR resolves #36


Maximum characters request name

Hi,
I'm looking for an alternative for Postman and came along Bruno. I really like the application. I have a lot of collections with a lot of requests. Some names of those requests exceed the maximum of 50 characters Bruno allows. The collections are imported from Postman and are visible in Bruno. Some names have more than 50 characters. However when I try to rename some requests (remove the server name from the name of the request) I get the message 'must be 50 characters or less'. The names of the requests are the same as the names of the endpoints and should not be changed. I can cange the name of file of the request and the contents. Afterwards the request just shows up fine. This is a hack of course and it takes a lot of time. Could the maximum of characters be removed? Also when the left pane has a lot of requests and you scroll down, the right pane also scolls down.

Hey @RichardArling
Glad that you like Bruno!
Sure, I can increase the limit on the request name to 500 characters.
Do you think that would be sufficient?

Also when the left pane has a lot of requests and you scroll down, the right pane also scolls down.

Will get this fixed as soon as I can.

Hi @helloanoop
500 characters should be enough.
Thanks in advance.

Bruno no longer imposes a maximum character limit when creating or renaming requests and folders.

@helloanoop We saw this was closed but looking at the code commit, there was only a change to the limit on the rename of collections, NOT on the create of collection or anywhere else that the 50 character limit is imposed.  Is this what was intended?


Fix signer interface to conform to expected cryptoservice behavior

Fixes #714
Adds interface-specific tests so that anything that purports to implement the interface can use a standard set of tests, so hopefully all implementations behave similarly.

LGTM!

LGTM. Definitely warrants a v0.3.0-RC5


Add CBMC harness for QueueReceiveFromISR

Description

Add CBMC harness for QueueReceiveFromISR. See the harness and README.md for assumptions.
Depends on #774, #697, #688.
Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closed in favor of https://github.com/aws/amazon-freertos/pull/1324.


accounts_manager is overwriting existing linux account

We are running some legacy software on Google Compute, that creates a well known linux user account, with a home directory of /export/home/<user> and set some specific sudo rules.
If we use gcloud to SSH into a box as that same user, the Google daemon overwrites the users passwd entry and breaks the sudo rules.
It would helpful if either:

the google daemon detected the existing user settings and didn't trash them
we are able to blacklist certain usernames that we don't want the google daemon to manage

I just re-tested this again with a more recent CentOS 6 base image, and the problem could not be reproduced. I guess this issue has already been fixed in the google daemon.
Thanks


Inconsistent behavior in Android

Alarm plugin version
3.0.14
Describe the bug
The plugin behaves a little bit differently across various Android contexts:
Android simulator

On Kill Notification: it doesn't always show up. Sometimes it shows, sometimes it doesn't. It seems arbitrary as far as I can tell.
App on foreground: stream receives the event of the alarm firing and notification shows up. All good!
App on background: Notification shows. Tapping on it stops the sound and opens the app, but the stream doesn't receive any event, which means that the app cannot navigate to a screen that shows that an alarm has fired. In iOS, the stream does receive an event and the notification doesn't stop the sound. Only the app stops the sound, which is good I think, considering that snoozing is a popular feature.
App killed: even with the app killed, the alarm still fires. One of my user uninstalled the app to avoid the alarms being fired because they felt they cannot control them. I don't think this is good. Delivering alarms is important, but as long as the on kill notification is there and the user understands that killing the app means no alarms, it's sufficient. It also offers parity with iOS which is important, I think.

Samsung Galaxy A33

On Kill Notification: it works, but it doesn't use the app icon, title or description that is provided. This is problematic because my app is localized while the default plugin notification isn't. Weird! I hope this is just because of the closed testing thing, but I will test on more devices soon.
App on foreground: stream receives the event of the alarm firing and notification shows up. All good!
App on background: notification shows up, tapping on it opens the app and the stream receives an event. All good!
App killed: the app is suddenly opened and the notification is shown. The sound doesn't loop and stops by itself after playing once.

To Reproduce
Just deploy and test
Expected behavior
I'm not sure what is supposed to be the ideal behavior of the plugin, as there seems to be some differences between iOS & Android. As far as I'm concerned, it should be something like this:

On Kill Notification: must work consistently and use the app icon, title & message
App on foreground: no need for the notification to show, but if it does, it's fine. The stream must receive an event and interacting with the notification must not stop the alarm. The alarm should only be stopped from the app itself since it's the one that scheduled it and might have its own process on how to do that.
App on background: the notification must be displayed. Tapping on it must not stop the alarm. Instead, it must open the app and the stream must receive an event so that the app can update its UI and offer the user its own way of stopping the alarm.
App killed: no alarms. It's really scary to know that you have killed an app and yet, it still might fire an alarm regardless of the Do Not Disturb state. This is parasitic behavior that makes the user feel as though they lost control.

Screenshots
No screenshots needed.
Device info
Android simulator, Samsung Galaxy A33... Will update with more devices.
Additional context
None

I have tested on another Android device. It's similar to the Galaxy A33.
Honor PCT

On Kill Notification: it works but isn't customizable! It uses the default text and message, and a different icon: white with a red dot. Japanese flag? :)
App on foreground: stream receives the event of the alarm firing and notification shows up. Works great!
App on background: sometimes, tapping the notification opens the app with the stream having received the event and the sound still playing. Sometimes, tapping the notification opens the app but the stream hasn't received any event and the sound stops. Weird!
App killed: the app is suddenly opened and the notification is shown. The sound doesn't loop and stops by itself after playing once. Same behavior as the Galaxy A33.

Hi @younesouhbi
Thank you so much for your feedback ! It's very helpful.
About stream issues, I recently released v3.1.0 with some fixes. Some users had issues with their stream due to conflicts with other packages they used, like Firebase Messaging. More details here: #110 #122.
About the notification icon, it's a known issue I need to fix: #54.
About the alarm that is stopped on notification tap, it's also a known issue: #177.
A lot of work needs to be done ! Unfortunately I'm mostly alone working on the plugin so it can take a while. I hope some developers will contribute someday so issues can be resolved faster.

About the notification icon issue, I just released version 3.1.1 with a potential fix. Let me know if it works for you.

I do want to help, however seeing that native Android development is new to me, I'm going to need time to understand top level concepts before being of any help.
One of my Android testers reported not being able to turn off the alarm at all. Tapping the notification didn't stop the sound, and when they got into the app, the stream didn't receive the event, which means that there were no screen to let them stop the alarm. So they had to restart their phone.
I would say that the plugin works pretty well in iOS, but in Android, its behavior is too inconsistent. I will be spending the next few days reading and trying to understand how the Android version works. If you can offer some general idea how the various classes work and interact, it would be great.
Thank you for all your work on this!

I'm trying to understand how the plugin works. This is the process that supposedly executes when "setAlarm" is called. Is this correct?

I have a couple of questions if you don't mind.
How many instances are there of AlarmService? Is it only one or is a service created for every alarm that is scheduled? On one hand, it seems like it is one service per alarm, because AlarmService plays the sound and handles per alarm settings. However, I also see that it has a list of ringing alarm Ids? This part confused me, especially since this is the first Kotlin code I'm reading.

Hi @younesouhbi,
Thank you so much for your work. I'm aware that the codebase could be improved significantly. Unfortunately, sometimes I've had to prioritize releasing features and fixing issues over maintaining quality. Your improvements would be incredibly helpful, and I'm looking forward to your pull request! I'm confident that the alarm plugin will be successful if we work together to enhance it. It's a big relief to know that someone with your skills is willing to contribute to the native code. I started learning Kotlin and Swift through this plugin.
Regarding the iOS part of the plugin, I'm currently experimenting with battery consumption by testing various silent audio lengths. I’m also developing a method to play silent audio for just one second every ten seconds to minimize active playback while ensuring the app remains operational in the background. I'll keep you informed on this. It’s important to note that iOS background fetch intervals can vary significantly, especially when the system is handling other intensive tasks like gaming or downloads. The techniques I’m using, like silent audio and background fetch, are the result of multiple experiments to maintain app activity in the background, ensuring the alarm sounds precisely when scheduled, even days later.
Thanks again for everything, and please reach out if you have any questions!

@younesouhbi I'd be particularly interested in getCurrentlyRingingAlarmId
I've got an app using this package, and it behaves perfectly fine in the android emulator, but on two Moto android devices, it's impossible to dismiss the alarms unless I kill the app. If I can getCurrentlyRingingAlarmId when the app is opened, I could at least stop the alarm there

I'm closing this issue because in the meantime version 4.0.0 was released including a significant refactoring of the code and many bug fixes. Feel free to reopen if needed !


Added All Curricula to Curriculum

Description
Curricula has been added to Curriculum (JC, TY, SC, LCVP)
What
Parents can now access the subjects offered in Mount Sion C.B.S.
Why
Curricula is now accessible.
Verification Steps
http-server, on navbar go to Curriculum and ensure that Junior Cycle, Transition Year, Senior Cycle and LCVP are present along with the pages themselves with content.
Checklist:

[x] This pr is linked to the related trello card
[x] My code follows the style guidelines of this project
[x] I have requested a code review from (at least) two team members
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] This change has been verified by another team member

@laurafitzgerald could you please take a look at this PR and review it when you have the time? Thanks :)


[PyTorch] ImplementationError: The following operators are not implemented: ['aten::embedding_bag']

when I try to relay dlrm (pytorch model), I encounter the error:
ImplementationError: The following operators are not implemented: ['aten::embedding_bag']
pytorch=1.7.0, tvm is the latest

hello, have you finished importing the DLRM model，i have the same task

no i haven't
发自我的iPhone
------------------ Original ------------------
From: GoodNight-bye @.>
Date: Mon,Jun 21,2021 4:26 PM
To: apache/tvm @.>
Cc: Ivy Zhang @.>, Author @.>
Subject: Re: [apache/tvm] ImplementationError: The following operators are not implemented: ['aten::embedding_bag'] (#7986)

是的
发自我的iPhone
------------------ Original ------------------
From: GoodNight-bye @.>
Date: Mon,Jun 21,2021 4:30 PM
To: apache/tvm @.>
Cc: Ivy Zhang @.>, Author @.>
Subject: Re: [apache/tvm] ImplementationError: The following operators are not implemented: ['aten::embedding_bag'] (#7986)

我这边是把网络拆分了，embedding的部分不放在NPU上执行，但是后面有个index算子的问题

embedding_bag is supported in relay/frontend/onnx.py, you can refer to this file.

I have done the job, DLRM is already running on our NPU. If you have any question, you can contact me.

I have done the job, DLRM is already running on our NPU. If you have any question, you can contact me.
您好， 我目前也遇到这个算子不支持的问题， 能给个联系方式吗？感谢！

I have done the job, DLRM is already running on our NPU. If you have any question, you can contact me.
您好， 我目前也遇到这个算子不支持的问题， 能给个联系方式吗？感谢！

aten::embedding_bag relay层直接参考onnx的实现，算子侧的话需要实现对应的take算子

embedding_bag is supported in relay/frontend/onnx.py, you can refer to this file.

Hi, I`m also relay from onnx dlrm model, in this file(onnx.py), the implementation of embedding_bag use a reshape op(        indices = _op.reshape(indices, indices_shape)), however, if the indices_shape is [3, -1],  the size of indices is [13, ], the indices can not be reshape to the size[3, ?],how to do it!


Git bash issue

(Name of my computer) MINGW64 ~/spotify2mp3 (main)
$ python spotify2mp3.py
Traceback (most recent call last):
  File "C:\Users\Assayes2.0\spotify2mp3\spotify2mp3.py", line 202, in <module>
    utils.print_splash_screen()
  File "C:\Users\Assayes2.0\spotify2mp3\utils.py", line 18, in print_splash_screen
    print(colours.SPOTIFYGREEN + '''
  File "C:\Python312\Lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: 'charmap' codec can't encode characters in position 51-65: character maps to <undefined>

my python is updated

Hi Zied, can you try using Python 3.8 instead? Python 3.12 is not supported.


AutoHotkey syntax is not visible

I'm trying to add some AutoHotkey syntax in my Jekyll posts:
{% highlight ahk %} ; AutoHotkey classic or IronAHK
DllCall("MyFunction", "uint", ptr) {% endhighlight %}
{% highlight ahk %} ; AutoHotkey_L or AutoHotkey v2
DllCall("MyFunction", "ptr", ptr) {% endhighlight %}

Unfortunately, this is not processed, it just disappears from the page. Maybe this has to do with the pygments version you use?
(Other languages work).

Might be a bit off-topic:
Unfortunately I can't reproduce this locally. Trying to do so gives me
Liquid error: undefined method join' for "\nMsgBox Hello, World!\n":String

instead. Does anyone know the reason for this?


paper pdf figures overlap

Closed as of a9630d48ff6e5c85d16f51dcf8189a0795ece474

I was wrong. figure 4 and 5 still overlap, at least when I built this at home


BUILD.bazel being ignored causes problems with bazel projects with vendored libraries

On .gitignore there is an instruction to ignore BUILD.bazel. This is a problem for our project because we vendor our libraries, and we use bazel + gazelle, because the files generated by gazelle will not be tracked by git. When the code is checked-out from git it will be missing the files and and bazel will fail.
How to reproduce:

create a new go project
add github.com/google/s2a-go as a dependency
go mod tidy && go mod vendor
configure bazel with gazelle
bazel run //:gazelle
bazel test //... # will run and show that there are not tests to run
git commit -am "initial" # CAUSE OF THE ISSUE HERE: all BUILD.bazel files generated by bazel on
vendor/github.com/google/s2a-go will not be tracked
git push ...

On another machine:

git clone ...
bazel test //... # << unexpected behavior here

Expected result:
The same result as on the machine that created the git repository: bazel should run and say that there are no tests to run
Observed result:
An error like the one here:
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 5e938a9f-6e8b-4dfa-ad90-37fa2720ac22
ERROR: /home/xyko/tmp/events3/vendor/google.golang.org/api/internal/BUILD.bazel:3:11: no such package 'vendor/github.com/google/s2a-go/fallback': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /home/xyko/tmp/events3/vendor/github.com/google/s2a-go/fallback and referenced by '//vendor/google.golang.org/api/internal:internal'
ERROR: Analysis of target '//vendor/google.golang.org/api/internal:internal' failed; build aborted: Analysis failed
INFO: Elapsed time: 3.812s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (522 packages loaded, 329 targets configured)
ERROR: Couldn't start the build. Unable to run tests

Comments

I believe the library should NOT list BUILD.bazel on .gitignore.
The issue affect indirect users of this library, like users of google.golang.org/api

same here. I updated some google package and it included this as a dependency and now my builds are failing

Thanks, I updated the gitignore file in v0.1.3

Solved. Thanks for the quick fix.


Don't defer event handlers in debug/rundown mode

Don't defer event handlers in debug/rundown mode, because we need to create a full FunctionBody for the script body.

@abchatra


Enable psalm to detect return type of EasyDB::tryFlatTransaction()

This has been bugging me for a while, but just came up again; adding additional docblocks to allow psalm to detect the appropriate return type based on the return type of the passed callback.
snippet:
        $out = $this->db->tryFlatTransaction(
            /**
            * @return array<int, Event>
            */
            function(EasyDB $db) use ($now, $limit) : array {

prior to this patch, psalm will detect $out as being mixed, then report the appropriate MixedInferredReturnType, MixedAssignment, and MixedReturnStatement errors.
With this patch, psalm appears to detect the "correct" type of array<int, Event> for the assignment.
Based on:

manually patched paragonie/easydb v2.9.0
psalm 3.2.7

I'm not entirely sure what the minimum version of psalm would be required for end users to take advantage of this docblock change (perhaps @muglug might be able to weigh in here?)

whilst 3cb6def evidently does not resolve the nullable issue, it does make things a little bit clearer.

Support for callable came in version 2 I think?

Support for callable came in version 2 I think?

@muglug if template tags were in v2 as well, I suppose I should rollback 3cb6def- any thoughts on the nullable issue ?


As a pet owner, I want to be able to create message groups with different pet owners so that I can form groups for outings or get together [2]

completed


Allow empty table name

Coverage increased (+0.09%) to 90.91% when pulling 7e0495a4fe71db54a81fe4ab003690de841b27b6 on damianoporta:develop into 8a8e3a4f0b65d3d742ea5add9671642fb0365602 on davidyell:develop.

Seed can also be customised so perhaps it should check that also?


Private laws suggested api (new api) broken on $fillter

Example: trying to filter by knesset_id
http://knesset.gov.il/KnessetOdataService/LawsData.svc/privatelaw?$filter=knesset_id eq '20'
Same for filtering over law number ( in knesset site, not the primary key)

We need to use without enclosing ''
since type is int


Updated Swagger API - User Email Regex

Updated the regex to support longer email suffix (from 5 to 10 characters)

Resolves: #3649
Signed-off-by: David Deal<EMAIL_ADDRESS>

Also included a minor Makefile update to support different build architectures based on the host build machine.


Ballerina Quick Tour - Calculator - main.bal

The ballerina/io import doesn't work in the composer, giving the error " extraneous input '/' "
package calculator;

**import ballerina/io;**

function main(string... args) {

    int c = 0;
    while ( c != 5) {
        // print options menu to choose from
        io:println("Select operation.");
        io:println("1. Add");
        io:println("2. Subtract");
        io:println("3. Multiply");
        io:println("4. Divide");
        io:println("5. Exit");

        // read user's choice
        string choice = io:readln("Enter choice 1 - 5: ");
        int c = check <int>choice;

        if (c == 5) {
            break;
        }

        // Read two numbers from user to be used for calculator operations
        var input1 = io:readln("Enter first number: ");
        float a = check <float>input1;
        var input2 = io:readln("Enter second number: ");
        float b = check <float>input2;

        // Execute calculator operations based on user's choice
        if(c == 1) {
            io:print("Add result: ");
            io:println(add(a, b));
        } else if(c == 2) {
            io:print("Subtract result: ");
            io:println(subtract(a, b));
        } else {
            io:println("Invalid choice");
        }
    }
}

@PradeepaJey1 what's the ballerina version you are trying?

@nadeeshaan  Package declaration line is auto-generated by the composer and without the package declaration add and subtract functions get undefined.
Ballerina version - 0.975.1

I got a syntax error while the package declaration is there.

Error says extraneous input 'import'
When the  package declaration is removed, the syntax error is removed.
But there is an execution error coming when trying to execute the command 'ballerina run calculator' as follows

@HishanIndrajith @ThejanRupasinghe This package name auto-generation has been fixed with the following https://github.com/ballerina-platform/ballerina-lang/issues/9437

@HishanIndrajith  @ThejanRupasinghe Closing this issue as per the above comment. If you have further queries, please feel free to reopen this issue or create a new one.


[$250]  IOS - Transfer owner - App returns to empty screen when swiping right on success screen

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

User is invited to a workspace
User is also promoted to admin

Go to app
Go to workspace settings > Members
Tap on the owner
Tap Transfer owner
Proceed to success screen
Swipe right on the screen (iOS style)

Expected Result:
App will return to member profile page
Actual Result:
App returns to an empty Transfer owner screen
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/c98bc362-8ba4-4680-8b9e-97dd1a2f20cb
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01054e6abc7abcdf2c
Upwork Job ID:<PHONE_NUMBER>527773045
Last Price Increase: 2024-06-27

Issue OwnerCurrent Issue Owner: @c3024

@MitchExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
App returns to an empty Transfer owner screen
What is the root cause of that problem?
When we go to the success or error page, we navigate to this page so the WorkspaceOwnerChangeWrapperPage still present in the navigation stack.
https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx#L39
https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx#L45
And then when we swiping, this page appears with empty because the check is complete now.
https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/pages/workspace/members/WorkspaceOwnerChangeCheck.tsx#L36-L39
What changes do you think we should make in order to solve the problem?
We can use navigate with type is up here so the WorkspaceOwnerChangeWrapperPage can be removed from the navigation stack.
if (!policy.errorFields && policy.isChangeOwnerFailed) {
    // there are some errors but not related to change owner flow - show an error page
    Navigation.navigate(ROUTES.WORKSPACE_OWNER_CHANGE_ERROR.getRoute(policyID, accountID), CONST.NAVIGATION.TYPE.UP);
    return;
}

if (!policy?.errorFields?.changeOwner && policy?.isChangeOwnerSuccessful) {
    // no errors - show a success page
    Navigation.navigate(ROUTES.WORKSPACE_OWNER_CHANGE_SUCCESS.getRoute(policyID, accountID), CONST.NAVIGATION.TYPE.UP);
    return;
}

https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx#L39
https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx#L45
What alternative solutions did you explore? (Optional)
NA

Are there some dummy card details that can be added at this step?

@c3024 I commented this validate in PaymentCardForm, fill the form and  then test this bug in the fail page.
// if (values.cardNumber && !ValidationUtils.isValidDebitCard(values.cardNumber.replace(/ /g, ''))) {
//     errors.cardNumber = translate(label.error.cardNumber);
// }

Thank you for your proposals.
Both solutions fix the issue.
Since the fix pertains to popping of screens in the same RightModalNavigator, as far as I know both goBack and UP work the same way.
As I see goBack much more commonly used in our repo than UP, I think we can go with @layacat 's proposal here.
🎀 👀 🎀 C+ Reviewed

@puneetlath do you agree with the decision to assign @layacat based on their proposal?

Not overdue, Melvin

Reassigning as I'm heading on parental leave 🙇

This is due for payment on 17-07. I'll complete the checklist.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@c3024] The PR that introduced the bug has been identified. Link to the PR: #37869
[x]  [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/commit/4844b40e2fc66c86eb44004a8915849f54b1b82f#r144319754
[x]  [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because this could not be identified earlier.
[x]  [@c3024] Determine if we should create a regression test for this bug. Yes
[x]  [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Avatar icon (Account Settings) > Workspaces > Click on a workspace > Members
Click on Owner
Click Transfer Owner
Fill required fields and proceed to Success or Failure screen
Click on browser back button/iOS swipe right/device back button (on Android)
Verify that the Profile page of the member/owner in Step 2 appears

Regression test issue: https://github.com/Expensify/Expensify/issues/413387
@c3024 has been paid.
@layacat I've sent you an offer. Can you ping me here when you've accepted?
Also, can you follow the steps here so that in the future offers get automatically sent to you.

All paid. Thanks everyone!


Issue with Column Virtualization in Material-React-Table with Next.js

material-react-table version
v3
react & react-dom versions
v17
Describe the bug and the steps to reproduce it
Hi,
I am working on a Next.js project where we are using material-react-table to manage table data. We recently encountered performance challenges due to a large number of columns, so we implemented column virtualization to improve efficiency.
However, despite not using any hooks inside my component, the column virtualization is not functioning as expected. We are encountering the following error:

This is my component

Could you provide guidance on resolving this issue?
Minimal, Reproducible Example - (Optional, but Recommended)
create next js project
add material-react-table
give 100 columns and rows
scroll right
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
No, because I do not know how
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Hi
I found the issue scenario.
If i add multiple header for my table this issue is coming.


Develop the consumer in MVC 5 web application to run for forever to get the data from producer.

Description
This question for help...
How should I develop the Conluent.kafka consumer in MVC5 web application to run for forever to receive the data from kafka producer. I want to show data with some calculation in UI. Multiple people can access but value should be same at the same time (Stock market  website). I am thinking to use the SignalR to broadcast the data to All Client. But, I am not sure how should I develop the consumer so it would not make web app freeze for all user.
I have tried the Thread to run but didn't get success.
Checklist
Please provide the following information:

[x] Confluent.Kafka nuget version: 1.0.0-beta3
[ ] Apache Kafka version: latest
[ ] Operating system: Win 10

we plan to write an example of how to do this in ASP.NET Core using hosted services ( see here: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/hosted-services?view=aspnetcore-2.2 ). stay tuned for that!

Thank you so much for real quick response. I would be waiting for it meanwhile I would try to implement it. Thanks again for give me hint.

we plan to write an example of how to do this in ASP.NET Core using hosted services ( see here: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/hosted-services?view=aspnetcore-2.2 ). stay tuned for that!

I have done this in my system, Can I contribute to the community? how?

hi @dhavalsp - you can open a PR to this repo - that'd be great! note that we carefully review every contribution, and we might not get time to do this immediately depending on other priorities. small, high quality contributions is key!
another thing you can do is blog about it, or do something else independently. If I know about it, i'll tweet about it for sure.

@dhavalsp hi. I'd like to see your implementation of this scheme. Is it possible? Or maybe you wrote article about it. @mhowlett is example still in plans?