Tree sitter hack

🤔 What's changed?
Tweaked the web-tree-sitter WASM loader to tolerate undefined symbols.
⚡ What's your motivation?
Fixes #164
VS Code 1.78 ships with Electron 22, and something has changed in V8 to make it hostile toward loading the tree-sitter language support WASM. It was recommended to allowUndefined: true as a workaround, and lo, things seem to work if we monkey patch that workaround into the codebase.
🏷 What kind of change is this?

🙃 Crazy hack that helps tide us over until Tree Sitter can make a proper fix. See tree-sitter/tree-sitter#2274 for details.

♻ Anything particular you want feedback on?
This would seem like the only expedient way to restore the plugin's functionality. I've recruited some beta testers from Slack who will hopefully play with it before we publish it. Seems better than nothing, to me!
📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code

[ ] I have added/updated tests to cover my changes.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] Users should know about my change

[ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

After chatting with mpkorstanje, my plan of action for this PR is never to merge the branch. We'll release a version of the extension from this feature branch.

Any update? :)

Sorry, no; I was waiting until Tree Sitter released their new major version, but I've since confirmed that it's still broken.
See tree-sitter/tree-sitter#2338 for details.
I will see about rebasing this branch off of a recent main (to pick up additional fixes) and then releasing.

FYI @LukasLewandowski and others -- I've built a new pre-release VSIX that you can install; it uses a less scary hack to work around the still-unresolved TreeSitter bug, and it upgrades several packages to improve the Gherkin editing experience. I will propose to the rest of the team that we release it as an official 1.8.0.
In the meantime, feel free to use the VSIX linked above and let me know if you have any problems. Thanks!

I am still not getting cucumber language features on my feature files. I created these settings in my settings.json to try to fix it but to no avail. Can you help me get important cucumber features like clicking to step definition from feature files?
   "files.associations": {         "*.feature": "feature"     },     "cucumber.features": [         "oneOfManySubprojects/features/**/*.feature"     ],     "cucumber.glue": [         "oneOfManySubprojects/tests-onehub/step-definitions/**/*.js"     ]

Closed this PR in favor of waiting for VS Code 1.82.0 which fixes the underlying incompatibility! 🎉


update_on_kvstore error setting with multiple machines

When I was training with multiple machines, i found that model.py:_create_kvstore function sets update_on_kvstore to True. In the gluon interface (trainer.py), i found the following code:
 if 'dist' in kvstore.type:
    update_on_kvstore = False
    for i, param in enumerate(self._params):
        param_arrays = param.list_data()
        kvstore.init(i, param_arrays[0])
        kvstore.pull(i, param_arrays, priority=-i)

while in module.py, update_on_kvstore is not set to False.
Is this a bug?
Besides, the gluon interfaces pull all param_arrarys whatever update_on_kvstore is. But in the python interface (model.py), only when update_on_kvstore is True, the params are pulled.  Any reasons?
def _initialize_kvstore(kvstore, param_arrays, arg_params, param_names, update_on_kvstore):
    """Initialize kvstore"""
    for idx, param_on_devs in enumerate(param_arrays):
        name = param_names[idx]
        kvstore.init(name,  #arg_params[name])

        if update_on_kvstore:
            kvstore.pull(name, param_on_devs, priority=-idx)

Overall, how to save_optimizer_states properly in distributed training?

@rahul003 @piiswrong - You want to take a look at this?

It doesn't look like a bug per se. The update is still done after pulling from the kvstore. I'm not sure if there is a reason why the update is done here rather than on the kvstore
Regarding the second point, that is just the init. And update_on_kvstore is only false when kvstore is local. Maybe there is one pull that can be saved, need to look into that.

Thank you for your reply. Do you have any ideas on how to save_optimizer_states property in distributed training, especially when update_on_kvstore is True?

@yuewu001

Trainer is now fixed and uses the same logic as in Module. [Here in Trainer](- https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/gluon/trainer.py#L188) is where you create the KVStore using model._create_kvstore. However, please note that, it is not recommended to use KVStore when grad is sparse, hence, it will be set to false when grad is sparse.
To save optimizer states, you can use trainer.save_states(file_name). https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/gluon/trainer.py#L376

Resolving the issue. Please reopen, if your still have questions/issues.


Empty res.json() with valid res.body

Hi folks,
I'm using Marty 0.10.4, and I'm attempting to follow the recommendations for removing dependence on the automatic parseJSON call, but I'm seeing a strange behavior: When my valid data source requests finish with 200 OK, calling res.json() returns an empty object {}.
I'm calling Marty.HttpStateSource.removeHook('parseJSON'); in my server.js to remove the automatic parseJSON hook, then in my data source, doing a simple GET:
class ThingSource extends Marty.HttpStateSource {
  getThing(id) {
    return this.get(`/api/things/${id}`).then((res) => {
      console.log(res.body); // returns { id: 42, ... } with parseJSON hook, { _opts: {}, ... } without
      console.log(res.json()); // always returns {}
      if (res.ok) {
        return res.json();
      }
      throw new Error('Failed to get thing');
    });
  }
}

If I temporarily omit the removal of the parseJSON hook, res.body is in fact the JSON text that I expect to parse by calling res.json(), so I can see that my requests are succeeding. I just can't figure out why, in either case, res.json() always just returns {}.
Am I missing something?
Thanks so much!

The body on a request is a readable byte stream that should only be consumable once anyway. Do you still see res.json() returning empty results if you comment out the console.log(res.body) line?

Hi @taion, thanks for responding so quickly :)
Even when I log only res.json(), I still get {}. Is there any way I can dig deeper into what's happening under the hood?
Thanks!

res.json() actually returns a promise - you'd have to do e.g. res.json().then(json => console.log(json)).

Aha! That worked — that successfully logged out the data I'm expecting. Hmm, so maybe the API calls are working correctly, and the fact that my Marty container's failed method is being called is the result of something else.

Interesting... If I dig into the errors passed to the failed Marty container method, I see...
{"things":{"name":"Not found","message":"Not found","status":404}}
...despite the fact that my API method is returning 200 OK, with data, as application/json.

The process for a fetch is:

Hit the local handler.  If it returns undefined then...
Hit the remote handler.
Hit the local handler again.  If it returns undefined then...
Trigger a failed state on the fetch.

So presumably your issue that the local handler is still returning undefined even after the remote API call completes.  Obvious causes:

Your remote handler isn't causing the store to update correctly.  eg, your dispatching an event but nothing in the store is handling it, or the handler in the store is storing the new data under the wrong key.
Your local handler isn't fetching data from the store correctly, eg, it's looking for data under the wrong key.

I'd suggest looking at your store's state after the failure.  Is the remote data actually in the store?

OH, that's totally it!
I was intentionally returning undefined from my locally handler to force invocation of the remotely handler, with the thinking that I would get remote data working first, then worry about storing it, then get it to my component. Turns out, Marty is smarter than I assumed it was.
This is great! Thanks @codyhatch and @taion!


How can I get XYZGrid value  in XYZDialog?

Hi ! As the title said, I want to get the XYZGrid value when I in a XYZDialog , the dialog and the grid are the same entity . Must I write a service ? Is there another way I can achieve it?

Use this.entity or Retrieve method of your service. Dialog shouldnt access its grid. Pass it to dialog on creation, e.g. InitDialog method if required.


[stable\mongodb-replicaset] Add DB User and Role

What this PR does / why we need it:

Enables someone to add an additional user credential to the replicaset
Fixes logic for an existing secret for metrics
Only adds Prometheus annotations when metrics is enabled
Sets the default readme example TLS config to work with SSL, not using Mutual TLS
Updates StatefulSet API version to the latest based on Kubernetes version

@paulczar @unguiculus you both had conflicting desires on where to place the values.  I changed the path to be auth.additionalUser per @unguiculus's feedback requests.

@unguiculus You also had a request to have additional roles for a user underneath auth.additionalUsers.  I started to implement this on this commit here, but then I hit a wall and don't have time to continue working on this enhancement request.
More specifically the wall I hit was in having helm properly evaluate the [template command here(https://github.com/dtzar/charts/commit/b2aa27a03c890f9551a71a76879e36c70d0eec12#diff-9707ad19eeff7b95904599011488b0d1R125) inside the range loop which gave the error below indicative of it cannot find a value.  This feels like a helm bug since the same exact syntax works fine when not inside a range loop, but possible I'm missing something.
Error: render error in "mongodb-replicaset/templates/mongodb-statefulset.yaml": template: mongodb-replicaset/templates/_helpers.tpl:54:18: executing "mongodb-replicaset.dbSecret" at <.Values.auth.existin...>: can't evaluate field auth in type interface {}

I believe this PR adds a lot of additional value to everyone as-is.  @unguiculus would you be open to merge as-is and then file an issue on the enhancement request you desire?

Speaking as a user of the chart, I think it would be nicer to be able to create multiple users (each with multiple roles) instead of just a single additional. I think this could be simplified if the user definition is stored in a configmap that is mounted by the bootstrap container. The configmap could even contain the exact json that db.createUser() needs. That way environment variables are not needed and the creation of metrics user and additional could be combined. I've simplified user creation in PR #8115 so it's only done in one place.

@steven-sheehy I like the configmap idea and agree it would be nice to have the ability to have multiple users with multiple roles per user.  This is a bit more work I don't have the time for at the moment and think this would be a good future addition to the public chart.  Looking at your PR I also believe the changes proposed here shouldn't cause any conflicts.

I confirmed that the approach I started on above for multi-user will not work due to limitations with helm itself.  More details can be found on this thread here.
@unguiculus - Would you consider moving forward with the PR how it is now? I have addressed some of your requests, just not the desired enhancement for multiple roles with a single user.  I believe the approach @steven-sheehy mentions would be more comprehensive and also require more time refactoring the chart. Hopefully, someone could pick it up in a future PR.

@unguiculus - Thoughts?
@steven-sheehy - I just updated the code for the db user creation in the on-start.sh to be the same as what you did for the metrics user creation.
@paulczar - Look good to you now?

Error: render error in "mongodb-replicaset/templates/mongodb-statefulset.yaml": template: mongodb-replicaset/templates/_helpers.tpl:54:18: executing "mongodb-replicaset.dbSecret" at <.Values.auth.existin...>: can't evaluate field auth in type interface {}

@dtzar You have a different context inside the range loop. You could either capture the root context in a variable before the loop or use $ instead of . inside the loop to access the root context.
See https://docs.helm.sh/chart_template_guide/#variables
I still think this should allow multiple users to be added.

@dtzar I agree with @unguiculus. I think a solution that allows multiple users would be preferred (and multiple roles per user). Adding it as is and changing it later would break users that started depending upon its format. If you don't have time to enhance it, maybe split out your other non-additional user fixes and we'd be happy to approve.

@unguiculus - I've removed the additional user, so now there are only minor improvements in the PR which should be easier to approve/merge.

You need to make sure all your commits are signed-off. Also, looks like you mistakenly removed metrics.resources from README.
@unguiculus Is if/else necessary for api version change or can we directly specify v1. Not sure how that is handled on upgrades.

@steven-sheehy fixed the readme and signoff

/assign
/lgtm


Bug in equistore.allclose()

I don't think the new API changes in equistore were reflected in the logic suite, and when I ran equistore.allclose(tensor_1, tensor_2), I got an error because looping through a tensor_map no longer yields a (key,block) pair.
  for key, block_1 in tensor_1:
      try:
          allclose_block_raise(
              block_1,
              tensor_2.block(key),
              rtol=rtol,
              atol=atol,
              equal_nan=equal_nan,
          )
      except NotEqualError as e:
          raise NotEqualError(f"blocks for key '{key}' are different") from e

This is an easy fix:

make these for loops loop through tensor.items() rather than tensor
Improve code coverage in the docstring so that we actually hit this case -- the docstring didn't test for two equal tensorblocks which is why this error was not caught
Propagate these changes through to the rest of the logic functions

The origin of this issue was an out-of-date version of equistore-operations.


Update roulette's command example

The old description was from !duel

#173 takes care of this ;-;

@joaopms #173 gives the wrong message


Accesssimulator link doesn't go anywhere

resolution_fixed   |    by<EMAIL_ADDRESS>
Has the ACCESS homepage gone somewhere? Is there something better that we can point to?

Issue migrated from trac:15 at 2024-01-31 17:52:20 +1100

<EMAIL_ADDRESS>commented

Instead point to cawcr.gov.au

<EMAIL_ADDRESS>changed status from new to assigned

<EMAIL_ADDRESS>commented

Make sure there isn't too many ssssses or just link to cawcr

<EMAIL_ADDRESS>changed owner from `` to saw562

<EMAIL_ADDRESS>commented

Remove it

Scott Wales<EMAIL_ADDRESS>changed resolution from `` to fixed

Scott Wales<EMAIL_ADDRESS>changed status from assigned to closed

Scott Wales<EMAIL_ADDRESS>commented

In [changeset:"dc83f3391d3a5e672262ea7ecc5f1fe7cc6a0b4b/puppet"]:
#CommitTicketReference repository="puppet" revision="dc83f3391d3a5e672262ea7ecc5f1fe7cc6a0b4b"
Remove accessimulator link

Fixes #15

<EMAIL_ADDRESS>commented

Milestone Future deleted

<EMAIL_ADDRESS>removed milestone (was Future)


fix the empty noproxy in baremetal

issue: https://github.com/open-cluster-management/backlog/issues/17702
Signed-off-by: Zhiwei Yin<EMAIL_ADDRESS>

/lgtm


Database schema for sensors and readings

Yes, good point, forgot it out of the first sketch, but yes SensorLocation should be included.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@a908e79). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head f8e1b95 differs from pull request most recent head f3194c6. Consider uploading reports for the commit f3194c6 to get more accurate results

@@            Coverage Diff             @@
##             develop      #15   +/-   ##
==========================================
  Coverage           ?   85.63%
==========================================
  Files              ?       17
  Lines              ?     1309
  Branches           ?        0
==========================================
  Hits               ?     1121
  Misses             ?      188
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This now brings sensors to be almost on par with locations in functionality. Still missing are:

Several end points for deleting things (locations need these as well),
End points for inserting and getting sensor data (sensors.py functions exist)
Everything related to SensorLocations
Maybe more API tests, for malformed input

Could be merged already if so desired.


SASS-4100 - Update README.md file for State Benefits BE

Description
Update README.md file for State Benefits BE
Add a link to the relevant story in Jira
SASS-4100
Checklist PR Reviewer
Before Reviewing

[x]  Have you pulled the branch down?
[x]  Have you assigned yourself to the PR?
[x]  Have you moved the task to “in review” on JIRA?
[ ]  Have you checked to ensure all dependencies are up to date?
[ ]  Have you checked to ensure its been rebased against the current version of main?

Whilst Reviewing

[ ]  Have you run the tests?
[ ]  Have you run the journey tests?

[ ]  Have you run the performance tests?
[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current main that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

Checklist PR Raiser
Before creating PR

[ ]  Have you run the tests?

[x]  Have you rebased against the current version of main?
[ ]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[x]  Have you checked the PR Builder passes?

Can you please update the SBT version? You don't need to to that for the FE.

Please include a Feature Switches section and add Encryption


CSS4 Specify the subject of a selector by prepending $

CSS4 Specify the subject of a selector by prepending $
http://www.w3.org/TR/2011/WD-selectors4-20110929/#subject

This issue was imported from Google Moderator
Moderator votes: +6
Issue added by Daniel Heath on 2011-12-07
To vote this issue up or down, simply include +1 or -1 in your comment.

Refs #1182.

This feature was removed in the 2012 draft (http://www.w3.org/TR/2012/WD-selectors4-20120823/) and remains gone in the current editor's draft (https://drafts.csswg.org/selectors-4/).
See also:

Changes
[...]

Replaced subject indicator feature with :has().

And :has() is covered by #1268.

@Fyrd This suggestion seems to have become invalid; see above comments.

Yeah, you're right. Closing.


Typo in usr_04

Hey, this is a very quick one:
https://github.com/vim/vim/blob/6bfc475f717aa0412d13163d47ff6210fa611fb5/runtime/doc/usr_04.txt#L467
should be either "to make a correction" or "to make corrections".
Thanks!

Alessandro Caputo wrote:

Hey, this is a very quick one:
https://github.com/vim/vim/blob/6bfc475f717aa0412d13163d47ff6210fa611fb5/runtime/doc/usr_04.txt#L467
should be either "to make a correction" or "to make corrections".

"a correction" sounds correct.  Thanks!
--
BROTHER MAYNARD: Armaments Chapter Two Verses Nine to Twenty One.
ANOTHER MONK:    And St.  Attila raised his hand grenade up on high saying "O
Lord bless this thy hand grenade that with it thou mayest
blow thine enemies to tiny bits, in thy mercy. "and the Lord
did grin and people did feast upon the lambs and sloths and
carp and anchovies and orang-utans and breakfast cereals and
fruit bats and...
BROTHER MAYNARD: Skip a bit brother ...
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Fixed in 9faec4e.


Trigger monorepo dep group releases properly if repo doesn’t actually depend on the current package

From #892:
Assume a repo has:
 devDependencies: {
  'enzyme': '^3.3.0',
  'enzyme-adapter-react-16': '^1.5.0'
}

…both of which are part of the enzyme release group. Then enzyme-adapter-utils gets a 1.6.0 release. This correctly triggers a group update for enzyme on the repo, but since the repo doesn’t actually depend on the new package:

The wrong version number gets used as oldVersion: that of enzyme, in this case.
An update of the monorepo group is triggered on this repo even if none of the repo’s actual dependencies from this group were updated. So in this case we get a commit chore(package): update enzyme to version 3.4.4, but a PR with the title Version **1.6.0** of the **enzyme** packages was just published.

Update: in registry-change.js, satisfyingVersions is empty because 1.6.0 never satisfies^3.3.0, which in turn leads to oldVersionResolved being undefined. So, by the time we get to create-version-branch:

oldVersionResolved is undefined
oldVersion is ^3.3.0
Both are wrong.

The core of the problem is that the map we do over filteredSortedPackages() isn’t capable of handling the case that it should trigger a job for create-version-branch that shouldn’t actually update the current dependency, but only package files that depend on other dependencies from the same group, provided that those have actually also received an update in this monorepo group release.
So in this example:

yes, enzyme-adapter-utils should contribute to a group release for enzyme
yes, it should do so even if no repos depend on it directly, because it may be the last release in the group. So as long as there are any repos that depend on any releases in this dependency’s group, we continue. This is already the case.
yes, a create-version-branch job should be created even for repos that don’t depend on this release, provided they depend on the releases’s group. However: these version branches should only:

create updates for the group dependencies that the repo actually has
create updates for the group dependencies that actually received updates, and use their respective old and new version numbers

Fixed, deployed, works! 🚀


[stack] Enhance amp stack ls with number of running services and status

Currently amp stack ls reports:
$ amp stack ls
ID                NAME    SERVICE  OWNER  OWNER TYPE
29abfcc4fd78c501  voting  6        user   USER

It would be a nice enhancement to get:
$ amp stack ls
ID                NAME    SERVICE  STATUS    OWNER  OWNER TYPE
29abfcc4fd78c501  voting  4/6      STARTING  user   USER

and
$ amp stack ls
ID                NAME    SERVICE  STATUS    OWNER  OWNER TYPE
29abfcc4fd78c501  voting  6/6      RUNNING   user   USER

ref: #1216
moving to 0.11.0 milestone


fix tc to add func types to the ast

closes #1109

The GitLab CI failure is unrelated to the changes in this PR...


var compositor = new Compositor(); An exception of type 'System.UnauthorizedAccessException'

var compositor = new Compositor(); An exception of type 'System.UnauthorizedAccessException' in WPF .NET 5

I've got a unit test for this now as a repro. It's not throwing UnauthorizedAccessException but instead Class not registered (A COM Exception).
Call stack:
System.Private.CoreLib.dll!System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(int errorCode)	Unknown

WinUI.dll!WinRT.BaseActivationFactory.BaseActivationFactory(string typeNamespace, string typeFullName) Line 286	C#
WinUI.dll!WinRT.ActivationFactory<Microsoft.UI.Composition.Compositor>.ActivationFactory() Line 312	C#
[Native to Managed Transition]
[Managed to Native Transition]
System.Private.CoreLib.dll!System.RuntimeType.CreateInstanceDefaultCtorSlow(bool publicOnly, bool wrapExceptions, bool fillCache)	Unknown
System.Private.CoreLib.dll!System.Activator.CreateInstance<WinRT.ActivationFactory<Microsoft.UI.Composition.Compositor>>()	Unknown
WinUI.dll!WinRT.WeakLazy<WinRT.ActivationFactory<Microsoft.UI.Composition.Compositor>>.Value.get() Line 202	C#
WinUI.dll!WinRT.ActivationFactory<Microsoft.UI.Composition.Compositor>.ActivateInstance<WinRT.Interop.IUnknownVftbl>() Line 318	C#
WinUI.dll!Microsoft.UI.Composition.Compositor.Compositor() Line 6924	C#

I am using it in .NET 5 project only. I haven't checked it in WinUI. You are trying it in WinUi.

Do you have a repro I can look into?

Do you have a repro I can look into?

Create a WPF project with . NET 5,then try to create an object.

I see, here's the actual call stack with the issue you posted about.

System.Private.CoreLib.dll!System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(int errorCode)	Unknown
Microsoft.Windows.SDK.NET.dll!WinRT.BaseActivationFactory._ActivateInstance<WinRT.Interop.IUnknownVftbl>()	Unknown
Microsoft.Windows.SDK.NET.dll!WinRT.ActivationFactory<Windows.UI.Composition.Compositor>.ActivateInstance<WinRT.Interop.IUnknownVftbl>()	Unknown
Microsoft.Windows.SDK.NET.dll!Windows.UI.Composition.Compositor.Compositor()	Unknown
ConsoleApp2.dll!ConsoleApp2.Program.Main(string[] args) Line 11	C#

I see, here's the actual call stack with the issue you posted about.

System.Private.CoreLib.dll!System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(int errorCode)	Unknown
Microsoft.Windows.SDK.NET.dll!WinRT.BaseActivationFactory._ActivateInstance<WinRT.Interop.IUnknownVftbl>()	Unknown
Microsoft.Windows.SDK.NET.dll!WinRT.ActivationFactory<Windows.UI.Composition.Compositor>.ActivateInstance<WinRT.Interop.IUnknownVftbl>()	Unknown
Microsoft.Windows.SDK.NET.dll!Windows.UI.Composition.Compositor.Compositor()	Unknown
ConsoleApp2.dll!ConsoleApp2.Program.Main(string[] args) Line 11	C#

Is there a solution available for this issue of its it still work in progress?

I'm working on it

I'm working on it

Ok thank you. It would be nice to add some real life examples and samples for FromAbi , As<> etc methods other than the usage file.

I tried the same repro in a C++/WinRT app and got the same error.
Output window:
Exception thrown at 0x756C6862 (KernelBase.dll) in ConsoleApplication1.exe: WinRT originate error - 0x80070005 : 'Access is denied.'.
'ConsoleApplication1.exe' (Win32): Loaded 'C:\Windows\SysWOW64\bcrypt.dll'. Symbols loaded.
'ConsoleApplication1.exe' (Win32): Loaded 'C:\Windows\SysWOW64\sechost.dll'. Symbols loaded.
onecoreuap\windows\dwm\dcomp\winrtnested\wrtcompositor.cpp(621)\dcomp.dll!7AFA0E3D: (caller: 7AF8D556) ReturnHr(1) tid(1a88) 80070005 Access is denied.
    Msg:[The caller must initialize DispatcherQueue on this thread before this operation.]
onecoreuap\windows\dwm\dcomp\winrtnested\global\wrtcompositorg.cpp(102)\dcomp.dll!7AF8D56D: (caller: 7AF95D96) ReturnHr(2) tid(1a88) 80070005 Access is denied.
onecoreuap\windows\dwm\dcomp\winrtnested\wrtcompositor.cpp(9072)\dcomp.dll!7AFF4D5F: (caller: 008B2B53) ReturnHr(3) tid(1a88) 80070005 Access is denied.
Exception thrown at 0x756C6862 in ConsoleApplication1.exe: Microsoft C++ exception: winrt::hresult_access_denied at memory location 0x00EFEF2C.

Call Stack:
 	KernelBase.dll!756c6862()	Unknown	No symbols loaded.
 	KernelBase.dll![Frames below may be incorrect and/or missing, no symbols loaded for KernelBase.dll]	Unknown	No symbols loaded.
>	ConsoleApplication1.exe!winrt::impl::factory_cache_entry<winrt::Windows::UI::Composition::Compositor,winrt::Windows::Foundation::IActivationFactory>::call<winrt::Windows::UI::Composition::Compositor (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &)>(winrt::Windows::UI::Composition::Compositor(*)(const winrt::Windows::Foundation::IActivationFactory &) && callback) Line 6084	C++	Symbols loaded.
 	ConsoleApplication1.exe!winrt::impl::call_factory_cast<winrt::Windows::UI::Composition::Compositor (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &),winrt::Windows::UI::Composition::Compositor,winrt::Windows::Foundation::IActivationFactory,winrt::Windows::UI::Composition::Compositor <lambda>(const winrt::Windows::Foundation::IActivationFactory &)>(winrt::Windows::UI::Composition::Compositor::winrt::Windows::UI::Composition::Compositor <lambda>(const winrt::Windows::Foundation::IActivationFactory &) && callback) Line 6123	C++	Symbols loaded.
 	ConsoleApplication1.exe!winrt::Windows::UI::Composition::Compositor::Compositor() Line 9150	C++	Symbols loaded.
 	ConsoleApplication1.exe!main() Line 10	C++	Symbols loaded.
 	ConsoleApplication1.exe!invoke_main() Line 78	C++	Symbols loaded.

The above was done in a console app, in a UWP app however the code executes fine. We think this indiciates that the Compositor API needs to run in a certain context.

I suspect this api has CoreWindow or IFrameworkView dependencies, get the same error on NetCore3.1. Let me dig around to find out how to use it from an hwnd based app.

It works in. Net framework. Check composition sample for graphics capture

I have built and run the HelloComposition sample with net5.0-windows10.0.19041.0 and there was no UnauthorizedAccess issue. I am seeing a different exception get thrown, but it is after a Compositor is made via new Compositor()
Our working theory is that your issue is arising from not porting code correctly.

I have built and run the HelloComposition sample with net5.0-windows10.0.19041.0 and there was no UnauthorizedAccess issue. I am seeing a different exception get thrown, but it is after a Compositor is made via new Compositor()
Our working theory is that your issue is arising from not porting code correctly.

Did you try this : https://github.com/microsoft/Windows.UI.Composition-Win32-Samples in . NET 5

I tried one of those samples, the HelloComposition one, in Net5

All I'm trying to do is create an object of Compositor class in WPF . NET 5 project send this issue comes

Yes in that sample I am mentioning (WPF, NET5) they make a Compositor object and when I run it, that line does not throw UnauthorizedAccessException

@aqibbanday I think you need to do this
I tried running the app with that line commented out, and got UnauthorizedAccessException

@aqibbanday I got confirmation from @robmikh that you'll need to create a dispatcher queue (on the same thread) to create the Compositor. The method  to create such a queue on the current thread is not provided by CsWinRT. You can look at this sample for guidance.

CompositionHelper class library needs an update to support .NET 5.
public static DispatcherQueueController CreateDispatcherQueueControllerForCurrentThread()
{
var options = new DispatcherQueueOptions
{
dwSize = Marshal.SizeOf(),
threadType = DISPATCHERQUEUE_THREAD_TYPE.DQTYPE_THREAD_CURRENT,
apartmentType = DISPATCHERQUEUE_THREAD_APARTMENTTYPE.DQTAT_COM_NONE
};
        DispatcherQueueController controller = null;
        uint hr = CreateDispatcherQueueController(options, out IntPtr controllerPointer);
        if (hr == 0)
        {
            //controller = Marshal.GetObjectForIUnknown(controllerPointer) as DispatcherQueueController;
            controller = DispatcherQueueController.FromAbi(controllerPointer);
            Marshal.Release(controllerPointer);
        }

        return controller;
    }

The above code should fix the issue for CoreMessagingHelper.cs for .NET 5

    public static void SetWindow(this GraphicsCapturePicker picker, IntPtr hwnd)
    {
        var interop = (IInitializeWithWindow)(object)picker;
        interop.Initialize(hwnd);
    }

    public static GraphicsCaptureItem CreateItemForWindow(IntPtr hwnd)
    {

#if NET5_0
        var interop = GraphicsCaptureItem.As<IGraphicsCaptureItemInterop>();
        var itemPointer = interop.CreateForWindow(hwnd, GraphicsCaptureItemGuid);
        var item = MarshalInterface<GraphicsCaptureItem>.FromAbi(itemPointer);
        Marshal.Release(itemPointer);

        return item;

#else
var factory = WindowsRuntimeMarshal.GetActivationFactory(typeof(GraphicsCaptureItem));
var interop = (IGraphicsCaptureItemInterop)factory;
var itemPointer = interop.CreateForWindow(hwnd, GraphicsCaptureItemGuid);
var item = Marshal.GetObjectForIUnknown(itemPointer) as GraphicsCaptureItem;
Marshal.Release(itemPointer);
        return item;

#endif
}
    public static GraphicsCaptureItem CreateItemForMonitor(IntPtr hmon)
    {

#if NET5_0
return null;
#else
        var factory = WindowsRuntimeMarshal.GetActivationFactory(typeof(GraphicsCaptureItem));
        var interop = (IGraphicsCaptureItemInterop)factory;
        var temp = typeof(GraphicsCaptureItem);
        var itemPointer = interop.CreateForMonitor(hmon, GraphicsCaptureItemGuid);
        var item = Marshal.GetObjectForIUnknown(itemPointer) as GraphicsCaptureItem;
        Marshal.Release(itemPointer);

        return item;

#endif
}

Thanks, @aqibbanday! I should probably move that sample to .NET 5 soon.

@aqibbanday I think the interop documentation would be useful for you to check out, it covers topics like you just covered (using FromAbi).
I think there's no issue now with C#/WinRT, so I will close the issue soon. Please leave a comment if you have concerns! Thank you for this discussion.

A simpler way to create a dispatcher queue is to use the managed adapter, DispatcherQueueSynchronizationContext:
                var context = new global::Microsoft.System.DispatcherQueueSynchronizationContext(global::Microsoft.System.DispatcherQueue.GetForCurrentThread());
                global::System.Threading.SynchronizationContext.SetSynchronizationContext(context);

Note that the WinUI desktop project templates already take care of this but there are scenarios where it may be explicitly required (background threads)

@aqibbanday I think the interop documentation would be useful for you to check out, it covers topics like you just covered (using FromAbi).
I think this issue is resolved as far as C#/WinRT is concerned, so I will close the issue soon. Please leave a comment if you have concerns! Thank you for this discussion.

I am having issues with initializing Compositor in .NET 5, is it possible for you to provide a sample of the same.

@aqibbanday Sure, I was able to build and run the following net5.0 app (using target framework net5.0-windows10.0.19041.0). Let me know if this doesn't work for you.
This CoreMessagingHelper class is coming from the sample I linked above
   public static class CoreMessagingHelper
    {
        enum DISPATCHERQUEUE_THREAD_APARTMENTTYPE
        {
            DQTAT_COM_NONE = 0,
            DQTAT_COM_ASTA = 1,
            DQTAT_COM_STA = 2
        }

        enum DISPATCHERQUEUE_THREAD_TYPE
        {
            DQTYPE_THREAD_DEDICATED = 1,
            DQTYPE_THREAD_CURRENT = 2
        }

        struct DispatcherQueueOptions
        {
            public int dwSize;
            public DISPATCHERQUEUE_THREAD_TYPE threadType;
            public DISPATCHERQUEUE_THREAD_APARTMENTTYPE apartmentType;
        }

        [DllImport(
            "CoreMessaging.dll",
            EntryPoint = "CreateDispatcherQueueController",
            SetLastError = true,
            CharSet = CharSet.Unicode,
            ExactSpelling = true,
            CallingConvention = CallingConvention.StdCall
            )]
        static extern UInt32 CreateDispatcherQueueController(DispatcherQueueOptions options, out IntPtr dispatcherQueueController);

        public static DispatcherQueueController CreateDispatcherQueueControllerForCurrentThread()
        {
            var options = new DispatcherQueueOptions
            {
                dwSize = Marshal.SizeOf<DispatcherQueueOptions>(),
                threadType = DISPATCHERQUEUE_THREAD_TYPE.DQTYPE_THREAD_CURRENT,
                apartmentType = DISPATCHERQUEUE_THREAD_APARTMENTTYPE.DQTAT_COM_NONE
            };

            DispatcherQueueController controller = null;
            uint hr = CreateDispatcherQueueController(options, out IntPtr controllerPointer);
            if (hr == 0)
            {
                controller = DispatcherQueueController.FromAbi(controllerPointer);
                Marshal.Release(controllerPointer);
            }

            return controller;
        }
    }

    public class Program
    {
        [STAThread]
        static void Main(string[] args)
        {
            Console.WriteLine("Hello World!");
            CoreMessagingHelper.CreateDispatcherQueueControllerForCurrentThread();
            var y = new Windows.UI.Composition.Compositor();
        }
    }

CompositionHelper class library needs an update to support .NET 5.
    public static DispatcherQueueController CreateDispatcherQueueControllerForCurrentThread()
    {
        var options = new DispatcherQueueOptions
        {
            dwSize = Marshal.SizeOf<DispatcherQueueOptions>(),
            threadType = DISPATCHERQUEUE_THREAD_TYPE.DQTYPE_THREAD_CURRENT,
            apartmentType = DISPATCHERQUEUE_THREAD_APARTMENTTYPE.DQTAT_COM_NONE
        };

        DispatcherQueueController controller = null;
        uint hr = CreateDispatcherQueueController(options, out IntPtr controllerPointer);
        if (hr == 0)
        {

//controller = Marshal.GetObjectForIUnknown(controllerPointer) as DispatcherQueueController;
controller = DispatcherQueueController.FromAbi(controllerPointer);
            Marshal.Release(controllerPointer);
        }

        return controller;
    }

The above code change fixes the issue for CoreMessagingHelper.cs for .NET 5

Oh! Sorry i had solved that issue, now issue is with composition sample.

I don't follow you, please more information of what you are asking. If you are asking about updating sample apps to net5.0, I believe @robmikh is working on that.

I don't follow you, please provide more information of what you are asking. If you are asking about updating sample apps to net5.0, I believe @robmikh is working on that -- in fact, it looks like Robert updated the sample apps yesterday...

I conveyed this to robmikh thanks.

I made an update to that comment, as I think Robert was working on his personal sample apps and maybe I was misunderstanding what you were referring to different composition samples.

Here is what I have so far - https://github.com/j0shuams/Windows.UI.Composition-Win32-Samples/blob/jlarkin/movetonet5/dotnet/WPF/HelloComposition/HelloComposition/CompositionHost.cs
The app runs fine, but after you close it an invalid cast is thrown. I am working on fixing this now, I believe it has to do with the property in the ICompositionTarget interface not being "ABI"-ified

Closing this issue since the OP is resolved. A second issue was brought up to have a composition sample app done in net5, that can be tracked on #627


Integrate #4795

Description
This PR integrates changes in ouroboros-network #4795. Which basically removes the computePeers callback from diffusion functions and provides a cleaner interface for consensus.
Note: This PR probably depends on #808 to be merged since bootstrap peers work has already been merged in ouroboros-network.

Thank you @bolt12 :raised_hands: I'll merge these changes into the 8.10 branch, which will be eventually merged into main.

This was cherry-picked in #1032.
(Note however that there will be changes in this area again soon, see https://github.com/IntersectMBO/ouroboros-network/issues/4839.)


Add fields and RDF mapping to Document media type

Drupal added a new "Document" media type. We should add our usual Islandora-specific fields and an RDF mapping.
Slack conversation

This PR is just some configs if someone wants a relatively simple PR to do.


Repository shortcut syntax not handled correctly

Thanks in advance for your bug report!

[X] Have you reproduced this issue in incognito/private browsing?
[X] Have you made sure you issue doesn't already exist?

Where is the URL that this occurs?
https://web.pulsar-edit.dev/packages/modular-keymaps
What's your issue?
If you click the Github repo link it takes you to https://web.pulsar-edit.dev/packages/danielbayley/atom-modular-keymaps which obviously doesn't exist. This seems to be because the metadata is assuming github as the repo so has:
    "metadata": {
      ...
      "repository": "danielbayley/atom-modular-keymaps",

And it seems we are expecting the full url here instead.
I propose that, for legacy packages (as we have plans to allow other forges) we need to make sure that any repository field like this is treated as a GH owner/repo format and we add the GH URL around it.
Additional info from @confused-Techie in Discord:

So investigating this a bit more, and it doesn't just apply to legacy packages.
According to the NPM docs https://docs.npmjs.com/cli/v9/configuring-npm/package-json#repository
This is perfectly valid, so it has to be valid for us to. That is any URL that will resolve via NPM can be used in the repository field, which includes user/repo (Only if on GitHub), github:user/repo, gist:gistID, bitbucket:user/repo, and gitlab:user/repo.

Supporting this does introduce some complexity when we eventually consider adding additional VCS platforms, since it means supporting NPM conventions will again force GitHub as the default, and fallback option. Which I had hoped to avoid, but it would at least be understandable as GitHub for such a long time has been the only supported platform.

To add to the above, with the legacy packages we can be certain they are 100% github regardless of npm convention where new ones can simply be a mistake
For example we could maybe disable user/repo and enforce the forge:user/repo shortcut style
(along with the long/full style one of course).
Which OS/Browser/Version does this happen on?
N/A
Steps to Reproduce/Additional Details:
See full conversation at https://discord.com/channels/992103415163396136/992110095641088001/1097587445110943874

Thanks for this, I'll see what I can do, here and on the backend, appreciate you finding this one!


Refactor/general performance

Adds some additional methods required by geojson-modelica package
refactors selectors and transformer to:

use full xpaths for selectors (at least to reach the base node a selector works off). This makes selectors a good bit faster
add option to walk the tree with a listener and applying selectors along the way rather than walking a path for each selector. From some simple benchmarking it's generally not faster to use this pattern, but might be a nice option to have depending on file sizes and edits being made

selector = MySelector()
transformer = Transformer('myfile.mo')
transformer.add(Transformation(selector, Edit.make_delete()))

# use listener pattern
transformer.execute(walk_tree=True)

sounds like the "walk" method may help with performance? Looks good.


Nuke the rest of middleware code

In an effort to make the code a little more straightforward[^1] I once again am
removing code. This time it is remaining cleanup from the middleware removal.
This ended up also requiring me to take a second look at how we parse the module
data during codegen, since previously that code was wrapped by the middleware
code.
[^1]: …to modify…

Makes sense to me!
My overall feelings here are:

we probably don't need WASM->WASM middlewares in wasmer -- our instrumentation which happens completely outside is more flexible and engine independent. It does incur an extra copy of WASM, but, given that it happens once during compilation, that's probably not too bad.
at some point, we might want to add WASM->Machine Code style middlewares, to generalize our intrinsification and otherwise tweak codegen. But we don't use middleware infra for that today (its mostly just hard-coded) and, anyway, this sounds like something we want to design once we have a specific need.


Add types.

Add types to P2PKH.ts

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   94.73%   94.73%
=======================================
  Files          19       19
  Lines        1120     1120
  Branches      102      102
=======================================
  Hits         1061     1061
  Misses         34       34
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d26113...ffe38c4. Read the comment docs.


Filter for x86_64 architecture

Make sure we're getting AMI for the correct architecture.
Otherwise you can get AMI for arm64

You can try searching manually to confirm that it's needed:
https://console.aws.amazon.com/ec2/v2/home?region=us-east-1#Images:visibility=public-images;ownerAlias=amazon;name=amzn2-ami-hvm*;creationDate=>2019-01-01T00:00+01:00;sort=name


install ondemand-dex from source where is config file?

https://osc.github.io/ood-documentation/latest/authentication/dex.html#installing-ondemand-dex-from-source
The guide has me install

/usr/sbin/ondemand-dex
/etc/systemd/system/ondemand-dex.service
and nothing else.

It says right below that guide that

The default location for Dex configurations is /etc/ood/dex/config.yaml

But it doesn't tell me what to write in such a file.
When I start the service, It says file not found.
I thought maybe it could use the dex: config that I put in ood_portal.conf, but it can't.

The configuration of Dex is the same if you install from package or from source: https://osc.github.io/ood-documentation/latest/authentication/dex.html#configuring-ondemand-dex

Going to close, soon OnDemand 2.0 will have Ubuntu 20.04 and 18.04 packages.


Make 'ITorrentFile.Priority' read-only and expose a public method to change priority

Add an internal event (or something?) so that anything which cares about priority can update deterministically.
For example the PriorityPiecePicker and the PartialProgressUpdater could both be updated at that point.

Done - except PriortyPiecePicker still needs updating.

I'll close this one off. The only reason to update priority picker would be performance. However, updating it would require a more complex API which i don't think is worth the tradeoff right now.
Let's leave things as-is unless another usecase comes up!


[Help] How to set height for the table based on the list

how to set height for the table based on the list

@kunalprabhu21
There is no function to set the height of the table according to the rows.
You have to set the height manually, such as with Sizedbox or Container.

Ok thanks for your reply..will figure something out

Ok thanks for your reply..will figure something out

I think I have done the same thing so you may figure it out by below code snippets.
SizedBox(
height: AppConstants.customTableTopHeaderHeight /Top Header/ +
AppConstants
.customBottomPaginationHeight /Bottom Pagination Widget if data is within shown range/ +
(AppConstants
.customTableRowAndDividerHeight /Row's height + divider/ *
_getRowsPerPageCount()) +
2 /Extra Height to manage inside scroll/,
child: PlutoGrid(
In above I have created _getRowsPerPageCount() which returns the no of rows by calculating between currently selected row count [10, 50, 100, 500, 1000] and the rows you have loaded by state manager.
You can set rowsPerPageCount directly if you not using pagination. But if yes, then you also need to update your page size and Page also like below whenever you select any of these [10, 50, 100, 500, 1000]
void _handleChangeHeight() {
_plutoGridStateManager!.setPageSize(_getRowsPerPageCount());
_plutoGridStateManager!.setPage(1);
Future.delayed(const Duration(milliseconds: 300)).then((value) {
if (mounted) {
setState(() {});
}
});
}
Change according to your need, hope this will help you.


✨ Introduce home pages to routes

@fernandolucchesi Do you mind to add a description about why we are doing this change? Nice to have for future references, and I'm not 100% sure if I know all the whys myself

@fernandolucchesi Do you mind to add a description about why we are doing this change? Nice to have for future references, and I'm not 100% sure if I know all the whys myself

This PR is an experimental approach (should have probably opened it as a draft instead).
My reasoning behind this was to remove the option from the editors of creating "child routes" from the "parent home", to prevent editors from doing some dumb stuff such as adding all the pages (routes) as children routes of "/".
I also believe this approach makes the setup/change of the home page easier for the editors since it makes the "create a home page journey" more intuitive, and consequently understanding the whole "route" concept may also become easier.
However, some issues are going on with the conditional fields (thread on sanity-poc going on) and this will need more tweaks.


Adding e2e test for cert renewal with given private key pem file

Signed-off-by: Pravin Pushkar<EMAIL_ADDRESS>Description

Parse provided pem encoded file before passing to x509.ParseECPrivateKey
e2e tests added for renewing cert with given pem encoded private key file.
Added an example-root.key file added in testdata

Issue reference
Related to issue #892
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

@yaron2 please review ...


Add AddNullMethodArgument recipe

What's changed?
Add recipe AddNullMethodArgument
What's your motivation?
When changing a method we often add a nullable argument. Sometimes overriding it as to not break existing consumers. With this recipe we can migrate more quickly by adding a null value as the argument.
Anything in particular you'd like reviewers to focus on?
line 104 of the recipe, creating the actual null literal.
~Also addArgumentsConsecutively is not working as expected. Any suggestions? If not I'll give it another try soon.~
Anyone you would like to review specifically?
@timtebeek
Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've read and applied the recipe conventions and best practices
[x] I've used the IntelliJ IDEA auto-formatter on affected files

@shanman190 Thanks, not sure how I missed those 🙈


fixed de-indentation of tabs (aka 4 spaces)

@mfussenegger made a separate PR for the test related issues: https://github.com/crate/crash/pull/229

Coverage increased (+0.5%) to 83.84% when pulling 0a24a3024bf85045ce82f09b01b6f65f41ec7a02 on h/fix-tab-deindent into 6c5820abc01cdd143ef867a620e7010fa120c7f3 on master.

Codecov Report

Merging #228 into master will increase coverage by 0.48%.
The diff coverage is 83.72%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   83.35%   83.84%   +0.48%
==========================================
  Files          17       19       +2
  Lines        2175     2203      +28
==========================================
+ Hits         1813     1847      +34
+ Misses        362      356       -6

Impacted Files
Coverage Δ

src/crate/crash/test_keybinding.py
100% <100%> (ø)

src/crate/crash/tests.py
100% <100%> (ø)
:arrow_up:

src/crate/crash/repl.py
62.32% <50%> (+4.46%)
:arrow_up:

src/crate/crash/keybinding.py
66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c5820a...0a24a30. Read the comment docs.


Add accountOperator (IN, NOT_IN) to TransactionsCollectionQuery

Current dependencies on/for this PR:

main

PR #9582   👈

This stack of pull requests is managed by Graphite.

What's the use case for NOT IN ?

@znarf to be able to filter on only Hosted Collectives, and exclude the host account itself: https://github.com/opencollective/opencollective/issues/7154.
But, I think I will close this PR in favour of https://github.com/opencollective/opencollective-api/pull/9585 that instead adds a includeHost (default: true) argument. That seems cleaner and is more straightforward to implement in the frontend


TransferOperator estimator

@datseris, when you have time, could you have a look at this?

New estimator type TransferOperator that takes a single input argument: a RectangularBinning. Analogous to VisitationFrequency, but here the probabilities are not computed as a histogram over the boxes, but from an approximation to the transfer operator over the boxes.
probabilities(x::AbstractDataset, est::TransferOperator{RectangularBinning}) computes probabilities. This works by partitioning the state space according to the provided binning, then approximating the transfer operator (n-by-n matrix, where n is the number of boxes visited by the points in x) subject to that binning. The transfer operator gives the transition probabilities between states/boxes, and probabilities are computed as the left-invariant distribution of the transfer operator.
Utility functions for estimating transfer operators and invariant measures.

This already exists in PerronFrobenius.jl, but the code here is optimized for working with Datasets, which gives huge performance increases when working with a large number of points (say, >100,000 points). I plan to just import this in PerronFrobenius when a new version of Entropies.jl that includes this PR is tagged.
This PR is also a requirement for efficiently generating transfer operator surrogates. I plan to include a TransferOperatorSurrogate (or something along those lines) in TimeseriesSurrogates.jl when this is merged.

Codecov Report

Merging #31 (b2859ee) into master (eb2f99b) will increase coverage by 0.56%.
The diff coverage is 80.90%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   78.96%   79.52%   +0.56%
==========================================
  Files          13       14       +1
  Lines         271      381     +110
==========================================
+ Hits          214      303      +89
- Misses         57       78      +21

Impacted Files
Coverage Δ

src/binning_based/rectangular/TransferOperator.jl
80.90% <80.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2f99b...b2859ee. Read the comment docs.

Perhaps you can give a couple of comments on why we need TransferOperatorApproximationRectangular and TransferOperator. It seems to me that all functions use the first version so far?
The main think I am thinking about what does the package TransferOperator.jl do, if all computations of transfer operators are done here...?

I have another question: is the invariant measure computation that you added here better than just using the standard histogram via binhist?

The main think I am thinking about what does the package TransferOperator.jl do, if all computations of transfer operators are done here...?

TransferOperator.jl isn't a package, so I am not sure what you mean. Are you referring to TransferEntropy.jl?
The implementation of the transfer operator approximation (not related to transfer entropy) - is here is a more efficient version that what exists in PerronFrobenius.jl.
PerronFrobenius.jl also contains transfer operator approximation based on simplices, which is computationally very expensive (due to exponental scaling with dimension). I could also just import PerronFrobenius.jl here and move the efficient implemention here to that package. But PerronFrobenius.jl depends on PyCall, which I think is an unneccessarily heavy dependence for Entropies.jl to have. I therefore go the other way around: re-implement transfer operator approximation in Entropies.jl, and import it in PerronFrobenius.jl once this is merged.

yes I got confused sorry.
Regardless,  this PR adds 5 new exports:
TransferOperator,
    transferoperator, TransferOperatorApproximationRectangular,
    InvariantMeasureEstimate, invariantmeasure,

First of all, what is the difference between TransferOperator, TransferOperatorApproximationRectangular? They both seem to be based on a rectangular binning. Secondly, what is the difference between InvariantMeasureEstimate, invariantmeasure ? Lastly, why does the function transferoperator exist? In Julia, a function that just creates an instance of some Type is simply called Type. Is there a specific reason to have additional names?

First of all, what is the difference between TransferOperator, TransferOperatorApproximationRectangular? They both seem to be based on a rectangular binning. Secondly, what is the difference between InvariantMeasureEstimate, invariantmeasure ? Lastly, why does the function transferoperator exist? In Julia, a function that just creates an instance of some Type is simply called Type. Is there a specific reason to have additional names?

TransferOperator is a probabilities estimator, like NaiveKernel or VisitationFrequency. TransferOperatorApproximationRectangular is just a struct that contains the results of a call to transferoperator(x::Dataset, est::TransferOperator).
If I later decide to implement the simplex-based approach here too, TransferOperatorApproximationTriangulated would be another return type.
To actually get the probabilities from the transfer operator, more steps are needed. Specifically: estimating the invariant probabilities/measure from the transfer operator, which is what invariantmeasure does. Precisely how this is done, depends on how the transfer operator was constructed. Therefore, invariantmeasure(to::TransferOperatorApproximationRectangular) dispatches on TransferOperatorApproximationRectangular, to let it know that the approximation was over a rectangular binning. In the future, invariantmeasure(to::TransferOperatorApproximationTriangulated) might also be necessary, because the estimation method for the probabilities are different for a triangulation.
I also created a return type InvariantMeasureEstimate, which contains both the original TransferOperatorApproximationRectangular that was used for the computations, as well as the actual estimate of the measure/probabilities. However, invariantmeasure can also just directly return a Probabilities instance, which would reduce complexity.

Okay, let's discuss what are the end goals for the user API. We two don't "care" about it, because we know all internals and can access all internals in pacakges downstream.
So a user needs to get probabilities and/or entropies. Since you cite this:
function probabilities(x::AbstractDataset, est::TransferOperator{RectangularBinning})
    to = transferoperator(x, est.binning)
    iv = invariantmeasure(to)
    return iv.ρ
end

it is not immediately clear to me why the intermediate names TransferOperatorApproximationRectangular, transferoperator should be exported.
Regarding the invariantmeasure, I think this function should indeed be part of the public API and we can think of it as the "third" thing that a user will obtain. An "invariant measure", no matter what it is, after all is just a tuple of probabilities and state space locations. binhist returns probabilities and binedges; simply returning probabilities would not be enough as you need to know to which part of the state space the probabilities exist. invariantmeasure should do something similar.
A convenience function for invariantmeasure, similar to binhist should exist as well. Furthermore, for me, from the docstring of invariantmeasure it is not clear what it does or how I should use it. Oh but now I see:
"""
    binhist(iv::InvariantMeasureEstimate) → ρ, bins
    binhist(to::TransferOperator{RectangularBinning}) → ρ, bins
    binhist(x::AbstractDataset, est::TransferOperator{RectangularBinning})→ ρ, bins
Analogous to `binhist` for a rectangular binning, but here probabilities are estimated from
an approximation to the transfer operator subject to that binning.
See also: [`TransferOperatorApproximationRectangular`](@ref),
[`InvariantMeasureEstimate`](@ref), [`TransferOperator`](@ref).
"""
function binhist(iv::InvariantMeasureEstimate)
    return iv.ρ, iv.to.bins
end

function binhist(to::TransferOperatorApproximationRectangular)
    iv = invariantmeasure(to)
    return iv.ρ, to.bins
end

Why do we need so many intermediate types and functions? You first make an invariant measure and then pass it to binhist, but why do we need so many steps? The API that this PR adds is really complicated, but it is not yet clear to me why it is so complicated...

One of the things I am missing is how different invariantmeasure is from the original binhist. If I calculate binhist with binning ε and do the same for invariantmeasure with same ε, do I get "improvement" if I use invariantmeasure? Is there a way to show this graphically?

I have another question: is the invariant measure computation that you added here better than just using the standard histogram via binhist?

The distribution obtained using the transfer operator approach and the naive histogram approach are equivalent in the limit of enough data points, which is ensured by the ergodic theorem.
See https://mathworld.wolfram.com/BirkhoffsErgodicTheorem.html. The densities obtained from the transfer operator estimate the right-hand side of the equation in the theorem, while the visitation frequency approach estimatets the left-hand side of the equation.
For the visitation frequency approach to actually converge to the true densities, very long time series are needed. One could argue that the transfer operator approach is "better" for shorter time series, because it is based on a probabilistic approximation to the underlying map that generated the observations.
Another advantage of the transfer operator is that it not only gives you the densities in certain regions of the state space, but also the transition probabilities between states, which can be useful in itself.

Alright that is great, but then we should include this useful information in the docstrings!

Okay, let's discuss what are the end goals for the user API. We two don't "care" about it, because we know all internals and can access all internals in pacakges downstream.
It is not immediately clear to me why the intermediate names TransferOperatorApproximationRectangular, transferoperator should be exported.

You are absolutely right. These don't need to be exported. It's good to have someone else to sanity check these things!

Regarding the  invariantmeasure, I think this function should indeed be part of the public API and we can think of it as the "third" thing that a user will obtain. An "invariant measure", no matter what it is, after all is just a tuple of probabilities and state space locations.

Referring to my previous comment about what the visitation frequency and the transfer operator approaches actually estimate, I agree. I think invariantmeasure should be the equivalent of binhist: returning the probabilities, as well as information about bin coordinates, as you said.

Alright that is great, but then we should include this useful information in the docstrings!

Agreed!
I'll fix these points and commit them as soon as I get the chance.

@Datseris And thanks again for the thorough review! This is very useful not only for getting the package up to speed, but also getting into the habit of good programming/Julia practices.

Here is an idea: the name InvariantMeasureEstimator can be improved, since as you said, this "structure" contains information for the transition probabilities as well. Which go beyond the measure in itself. I propose to define:
invariantmeasure(X, ε::Real_or_Vector) # creates internally Binning and TransferEstimator and InvariantStruct
invariantmeasure(ρ::invariant_struct) -> p, bins

Now, the "invariant struct", if I get it right, is it just the transfer operator? So, how do we name this struct? TransferOperator is already a probabilities estimator...

Here is an idea: the name InvariantMeasureEstimate can be improved, since as you said, this "structure" contains information for the transition probabilities as well. Which go beyond the measure in itself.

What if we instead of using the name InvariantMeasureEstimate, we just define
struct InvariantMeasure{TO}
    to::TransferOperatorApproximation
    p::Probabilities()
    args::NamedTuple # parameters used to estimate `p` from `to`
end

Then, as you propose
invariantmeasure(X, ε::Real_or_Vector) # creates internally Binning and TransferOperator and InvariantStruct
invariantmeasure(ρ::invariant_struct) -> p, bins

Then
probabilities(X::Dataset, est::TransferOperator)

just returns the probabilities obtained by invariantmeasure in the steps above.
Does that sound good?

That sounds great. Just for my own curiosity, how do I get the transition probabilities from the InvariantMeasure type? I would imagine a function transitionprobabilities that returns bins, p::Matrix. Perhaps we add it here for convenience (because it might be used in more that 1 packages later on)?

(p.s.: just to ensure we're on the same page, bins is a Vector{SVector}, right?)

(p.s.: just to ensure we're on the same page, bins is a Vector{SVector}, right?)

Yes, precisely.

That sounds great. Just for my own curiosity, how do I get the transition probabilities from the InvariantMeasure type?

I think I will update the field names for the TransferOperatorApproximationRectangular return type to
struct TransferOperatorApproximationRectangular{T}
    transfermatrix::AbstractArray{T, 2} # should be 2-dim SparseArray, I just don't remember the signature now
    ϵ::RectangularBinning
    mini
    edgelengths
    bins
end

Then
x = Dataset(rand(1000, 4))
iv = invariantmeasure(x, RectangularBinning(0.5)) # iv = invariantmeasure(x, 0.5) if you're still using the old way
iv.to.transfermatrix # gives the transfer matrix, containing transition probabilities

But as you say, we could just define transitionprobabilities to do that.

Completely unrelated to anything: what command do you use to get ε in the Julia console? I type \epsilon to get ϵ. Are these different greek letters, or just variants of the same?

it is \varepsilon , haha they are the same greek letter but with different styling.

this is good to go from my end.


net/http.NewRequest panics on nil body

What version of Go are you using (go version)?

$ go version
go version go1.18.1 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="//Users/myusername/go/bin"
GOCACHE="/Users/myusername/Library/Caches/go-build"
GOENV="/Users/myusername/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/myusername/go/pkg/mod"
GOOS="darwin"
GOPATH="/Users/myusername/go"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/opt/go/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/opt/go/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/myusername/src/weavelab.xyz/diff-generator/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sz/5rthrj0j2pz0xqwsf52xxs8m0000gq/T/go-build668136691=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.18.1 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.18.1
uname -v: Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64
ProductName:	macOS
ProductVersion:	12.3.1
BuildVersion:	21E258
lldb --version: lldb-13<IP_ADDRESS>
Apple Swift version 5.6 (swiftlang-<IP_ADDRESS>3.62 clang-13<IP_ADDRESS>)

What did you do?
package main

import (
    "bytes"
    "log"
    "net/http"
)

func main() {
    var bodyBuffer *bytes.Buffer
    _, err := http.NewRequest("GET", "test", bodyBuffer)
    if err != nil {
        log.Fatalln("Err: ", err)
    }

    log.Println("Success")
}

What did you expect to see?
Running this code should log "Success".
This is confirmed by the following code which functions as I would expect.
package main

import (
    "log"
    "net/http"
)

func main() {
    _, err := http.NewRequest("GET", "test", nil)
    if err != nil {
        log.Fatalln("Err: ", err)
    }

    log.Println("Success")
}

What did you see instead?
Running the provided example results in a panic: runtime error due to a nil pointer dereference.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x111eb84]

goroutine 1 [running]:
bytes.(*Buffer).Len(...)
	/usr/local/Cellar/go/1.18.1/libexec/src/bytes/buffer.go:73
net/http.NewRequestWithContext({0x11923e8?, 0xc0000b2008}, {0x115c94b?, 0xc0000021a0?}, {0x115cb6d?, 0x4?}, {0x1191780, 0x0?})
	/usr/local/Cellar/go/1.18.1/libexec/src/net/http/request.go:893 +0x564
net/http.NewRequest(...)
	/usr/local/Cellar/go/1.18.1/libexec/src/net/http/request.go:831
main.main()
	/Users/myusername/src/net_http_bug/main.go:11 +0x4e
exit status 2

@brandon-ja if you provide a *bytes.Buffer, it will need to be valid (not nil).
It may be that you are getting confused by the difference between a nil *bytes.Buffer and a nil io.Reader. See https://go.dev/doc/faq#nil_error.
Closing as there is no issue here that I can see.


Option to lock generated files

Implements feature request #361

          1 Error

:no_entry_sign:
Any changes to library code need a summary in the Changelog.

  Generated by :no_entry_sign: Danger

I'm working on some tests. Regarding Sourcery owning the files: it's not possible (not recommended) because a user must have the ownership and I'd say that creating a new user just for that is unnecessarily intrusive.
We can use xattr (extended file attributes) to store if a file was created by Sourcery, does that approach look ok for you?
I didn't try it with inline code generation, I'll look into it.

@fpg1503 extended file attributes will do the work I think. Will it work only on macOS or on Linux too?

@fpg1503 did you have any success with using extended file attributes for this feature?

Any update on this @fpg1503 ?

I wonder how it will work with APFS, don't know much about it.


The problem of using two i2s interfaces at the same time in esp32s3 (IDFGH-7255)

I want to use two i2s port,one as rx and another as tx
But it is found that the two can work normally when they are separated, but the crash occurs when they are put together.
below is code:
void init_microphone(void)
{
    // Set the I2S configuration as PDM and 16bits per sample
    i2s_config_t i2s_config = {
        .mode = I2S_MODE_MASTER | I2S_MODE_RX ,
        .sample_rate = 32000,
        .bits_per_sample = I2S_BITS_PER_SAMPLE_32BIT,
        .channel_format = I2S_CHANNEL_FMT_RIGHT_LEFT,
        .communication_format = I2S_COMM_FORMAT_STAND_I2S,
        .intr_alloc_flags = ESP_INTR_FLAG_LEVEL2,
        .dma_buf_count = 2,
        .dma_buf_len = 200,
        .use_apll = 0,
    };

    // Set the pinout configuration (set using menuconfig)
    i2s_pin_config_t pin_config = {
        .mck_io_num = I2S_PIN_NO_CHANGE,
        .bck_io_num = 12,
        .ws_io_num = 13,
        .data_out_num = I2S_PIN_NO_CHANGE,
        .data_in_num = 14,
    };

    // Call driver installation function before any I2S R/W operation.
    ESP_ERROR_CHECK( i2s_driver_install(I2S_NUM_0, &i2s_config, 0, NULL) );

    ESP_ERROR_CHECK( i2s_set_pin(I2S_NUM_0, &pin_config) );

    ESP_ERROR_CHECK( i2s_set_clk(I2S_NUM_0, 32000, I2S_BITS_PER_SAMPLE_32BIT, I2S_CHANNEL_MONO) );

}

#define I2S_SAMPLE_RATE     (16000)
#define SAMPLE_BITS     (16)

#define MASTER_WS_IO 36
#define MASTER_BCK_IO 37
#define DATA_OUT_IO 38
#define DATA_IN_IO 39
void hal_i2s_speaker_init(void)
{
    esp_err_t err;
    // master driver installed and send data
    i2s_config_t master_i2s_config = {
        .mode = I2S_MODE_MASTER | I2S_MODE_TX ,
        .sample_rate = I2S_SAMPLE_RATE,
        .bits_per_sample = SAMPLE_BITS,
        .channel_format = I2S_CHANNEL_FMT_ONLY_RIGHT,
        .communication_format = I2S_COMM_FORMAT_STAND_I2S,
        .dma_buf_count = 2,
        .dma_buf_len = 200,
        .use_apll = 0,
        .intr_alloc_flags = ESP_INTR_FLAG_LEVEL2 ,
    };
    i2s_pin_config_t master_pin_config = {
        .mck_io_num = I2S_PIN_NO_CHANGE,
        .bck_io_num = MASTER_BCK_IO,
        .ws_io_num = MASTER_WS_IO,
        .data_out_num = DATA_OUT_IO,
        .data_in_num = I2S_PIN_NO_CHANGE
    };

    err = i2s_driver_install(I2S_NUM_1, &master_i2s_config, 0, NULL);
    ESP_LOGI(TAG,"i2s_driver_install status %d",err);
    err = i2s_set_pin(I2S_NUM_1, &master_pin_config);
    ESP_LOGI(TAG,"i2s_set_pin status %d",err);
    i2s_set_clk(I2S_NUM_1, I2S_SAMPLE_RATE, (i2s_bits_per_sample_t)16, (i2s_channel_t)1);
}

Hi @Kingwulin ,
Thanks for the report. Could you provide more descriptions of how they put together? Do you mean allocate both tx and rx channel on a same port meanwhile adopt different configurations?
For the current driver, the tx and rx channels on ESP32 and ESP32S2  shares some register, so they are only allowed to using same configuration on a same port or different configurations on different ports. But yes, the tx and rx channel on ESP32C3 and ESP32S3 are separate, they support using different configurations on a same port, however, due to the limitation of the legacy driver, this is not supported for now, but will support while IDF v5.0 release. A branch new I2S driver will come out at that time.


iPad - can't scroll in Crop/Extend dialog

On iPad (iPadOS 15)
Page zoom in a lot (so scrollbars show up in dialogs)

Going to be kind of glitchy. Reorient tablet a few times, or reload the page.

Open Crop/Extend dialog
Scroll -> it works
Touch the preview, or any of the inputs (in Crop/Extend dialog)
Scroll -> doesn't work anymore
Reopen dialog -> still doesn't work

I don't know what causes this.

Can't reproduce in iPadOS 15.4.1 anymore.


Fixed the issue #10654 by adding overlays for each modal

https://github.com/zulip/zulip/issues/10654
Testing
After clicking on edit email or full name or password, the modal pops over and the background is disabled against clicks. Clicking anywhere except on the modal closes the modal. I have done this testing manually.
This is my first PR in zulip. Any feedback and suggestions are appreciated.

@akritianand thanks for the contribution!  @shubhamdhama I'd really appreciate it if you can give this a review, since you've done a lot of work with these overlays in the past.

@shubhamdhama Yes, I understand now.
So I was thinking that I can make a new common class for all modals and use that to remove 'show' in overlays.js instead of individual id(s) of each modal.

This was fixed properly via https://github.com/zulip/zulip/issues/10985


Documentation for MuJoCo and Swimmer

This PR adds two things:

It creates a mujoco directory and creates a mujoco.md file that gives an overview of the mujoco environments - what is MuJoCo, how to install them and how to download MuJoCo, and some general information on the state and action spaces.

Details on swimmer-v2 environment

I am missing the version history on the Swimmer environment - I was hoping to be redirected to it and I can add those couple lines as well!

I've added the version control, this PR should now be good to go @jkterry1

@RushivArora could you please fix merge conflicts (and remove all .DS_Store files and add it to .gitignore?)

@jkterry1 took care of the merge conflicts, and combined #6 here to avoid merge conflicts with the upstream when you merge this PR!


Add new file for en check list PP-54563

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Added handling to escape unmapped undefined_table and undefined_column error to go to catch block

Description
Currently, for unmapped errors with PostgreSQL error codes ERRCODE_UNDEFINED_TABLE and ERRCODE_UNDEFINED_COLUMN when thrown in from a lower level of execution in TRY CATCH block it does not go to the CATCH block. This PR adds a handling to fix this issue by allowing unmapped errors with PostgreSQL error code ERRCODE_UNDEFINED_TABLE and ERRCODE_UNDEFINED_COLUMN when thrown from a lower level execution to go to the catch block.
Authored-by: Rohit Bhagat<EMAIL_ADDRESS>Signed-off-by: Rohit Bhagat<EMAIL_ADDRESS>Issues Resolved
BABEL-5186
Test Scenarios Covered

Use case based - YES

Boundary conditions - NA

Arbitrary inputs - NA

Negative test cases - NA

Minor version upgrade tests - NA

Major version upgrade tests - NA

Performance tests - NA

Tooling impact - NA

Client tests - NA

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 74.517%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tds/src/backend/tds/tdscomm.c
2
76.03%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
45219

Relevant Lines:
60683

💛  - Coveralls


Minor spelling fix

'retun' to 'return'

@cptbrkfst whoah, nice and very important catch. Much appreciated!


⚠ Bofrost.at has degraded performance

In c534a37, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1824 ms

Resolved: Bofrost.at performance has improved in e19a18b.


Remove extra quotes in tracing tags

Tested with new image built from this (quay.io/acatterm/authorino-operator:fix-tracing-tags):
Authorino CR spec:
spec:
  clusterWide: true
  healthz: {}
  listener:
    ports: {}
    tls:
      enabled: false
  metrics: {}
  oidcServer:
    tls:
      enabled: false
  supersedingHostSubsets: true
  tracing:
    endpoint: rpc://jaeger-collector.istio-system.svc.cluster.local:4317
    insecure: true
    tags:
      random-key: random-value
      test-key: test-value
  volumes: {}

Resolves #171

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b0796bc) 61.78% compared to head (638fbdc) 61.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   61.78%   61.78%
=======================================
  Files           2        2
  Lines         785      785
=======================================
  Hits          485      485
  Misses        249      249
  Partials       51       51

Flag
Coverage Δ

unit
61.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Agreed, removed in commit 00db9df


Cannot use mysql-libmysqlclient from debian package

Successfully installed mysql-libmysqlclient using aptitude. Trying to use module:
var mysql = require('mysql-libmysqlclient');
Fails with error:
Error: Cannot find module 'mysql-libmysqlclient'

I do not provide OS packages with mysql-libmysqlclient, and do not know who does. Please give me a link to download this package or some other usefull info. Also please tell me about your Node and mysql-libmysqlclient versions.
It looks like this package was generated from outdated npm package for node.js v0.4.x.

Sorry, libmysqlclient-dev I mean

Ok :)
libmysqlclient is only a dependency for this module. To install it, you should do it via npm or build from source. 'Installation' and 'Build and use' sections in readme should help you.

@twirl: apt-get install build-essential libmysqlclient-dev should suffice. After that go with the npm route.

Installed build-essential and all works great
Thank you for your help.


Remove dependencies already installed by azure-cli

There are 3 required dependencies in setup.py now:
https://github.com/Azure/azure-devops-cli-extension/blob/2bd72a1d76cc00a84b348f573e9f8e14dfb42c5b/azure-devops/setup.py#L20-L24
python-dateutil and msrest are also required dependencies by azure-cli (check the requirements file). They should be removed as they will slow down the installation of the azure-devops extension and they will not be used after installed in the extension directory since modules of the same name installed by azure-cli have higher priority when loaded by python.

Done
Removed the stated dependency from the code.


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.10.158

from: https://github.com/jenkins-x/jx

/retest

/retest

/retest

/retest

/override gsm


neovim-nightly 0.10.0-1746  hash check failed

Prerequisites

[X] I have used the predefined issue title. (e.g. "xxx@xxx: hash check failed")
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name and Version
<EMAIL_ADDRESS>

this is my log:
Installing 'neovim-nightly' (0.10.0-1746) [64bit] from versions bucket
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: c3dd1a|OK  |   2.5MiB/s|C:/Users/cx/scoop/cache/neovim-nightly#0.10.0-1746#https_github.com_neovim_neovim_releases_download_nightly_nvim-win64.zip
Download: Status Legend:
Download: (OK):download completed.
Checking hash of nvim-win64.zip ... ERROR Hash check failed!
App:         versions/neovim-nightly
URL:         https://github.com/neovim/neovim/releases/download/nightly/nvim-win64.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    b8fbfbd012ab6acc215c839403f1002e2f1d6f522ee7e7ea11891b570e4355f0
Actual:      952f59debd89933c4457d4b55fe36caab35f76b22133a664deeaa6d0382b4249
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Versions/issues/new?title=neovim-nightly%400.10.0-1746%3A+hash+check+failed

cannot reproduce with current version.


provide advice on a procedure allowing users to easily re-install custom components after a VM update

(details in slack conversation with Okko)

being addressed by @junghanw as part of https://github.com/srvk/DiViMe/tree/develop/refactor_vagrant

for the specific case of adding htk after the fact, there is a new routine that addresses this (vagrant ssh -c "utils/install_htk.sh").


Add config for golangci-lint and fix errors

/lgtm
/retest

The code essentially hasn't changed, so marking this PR as approved.
/label qe-approved
/label docs-approved
/label px-approved

/retest


'PosixPath' object has no attribute 'read_text'

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
not yet installed
Python release (python3 --version):
3.4.2
Component/platform:
Install on Raspbian Jessie
Description of problem:
aiohttp error
During venv install i got this error:
AttributeError: 'PosixPath' object has no attribute 'read_text'

Expected:
successful install
Traceback (if applicable):
  Running setup.py (path:/tmp/pip-build-nujs0bey/aiohttp/setup.py) egg_info for package aiohttp
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "/tmp/pip-build-nujs0bey/aiohttp/setup.py", line 59, in <module>
        txt = (here / 'aiohttp' / '__init__.py').read_text('utf-8')
    AttributeError: 'PosixPath' object has no attribute 'read_text'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 17, in <module>

  File "/tmp/pip-build-nujs0bey/aiohttp/setup.py", line 59, in <module>

    txt = (here / 'aiohttp' / '__init__.py').read_text('utf-8')

AttributeError: 'PosixPath' object has no attribute 'read_text'

Additional info:
aiohttp-3.0.6 (from homeassistant)
tail of ~/.pip/pip.log
Command python setup.py egg_info failed with error code 1 in /tmp/pip-build-tsqbduc9/aiohttp
Exception information:
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.4/site-packages/pip/basecommand.py", line 122, in main
    status = self.run(options, args)
  File "/srv/homeassistant/lib/python3.4/site-packages/pip/commands/install.py", line 290, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/srv/homeassistant/lib/python3.4/site-packages/pip/req.py", line 1230, in prepare_files
    req_to_install.run_egg_info()
  File "/srv/homeassistant/lib/python3.4/site-packages/pip/req.py", line 326, in run_egg_info
    command_desc='python setup.py egg_info')
  File "/srv/homeassistant/lib/python3.4/site-packages/pip/util.py", line 716, in call_subprocess
    % (command_desc, proc.returncode, cwd))
pip.exceptions.InstallationError: Command python setup.py egg_info failed with error code 1 in /tmp/pip-build-tsqbduc9/aiohttp

Python 3.4 is no longer supported by Home Assistant - read_text is only available since Python 3.5


Refactor apb/client contents

Marking as DO NOT MERGE because I need to make sure the rebase on top of the docker removal didn't corrupt anything. Still open for comment since hopefully nothing major will change.
Ready for review
First commit is a squashed version of what I had in my personal org, prior discussion: https://github.com/eriknelson/ansible-service-broker/pull/2
Turns out, embedding EtcdConfig into the DaoConfig will not play nice with the yaml unmarshalling; it doesn't respect the annotations of the embedded type (correct me if I'm wrong!). I just kept them as fields on the Dao and added a convenience getter for EtcdConfigs.
Needed to manually remove some things as a result of the rebase for the third commit. Making sure this still makes sense.
Still looking to add one more commit with feedback items from my linked PR.

Rebased to pick up golinter compliance PR.

Of particular attention on this one is moving towards panicing the client constructors if errors are reported, and initializing everything as early as we can in App::Start. Thanks to @shawn-hurley for the suggestion, nicely cleans up clients package. If you can't get at your clients, you're probably FUBAR anyway and need to let someone know to go fix things.

Added PR addressing review feedback. Mainly, @shawn-hurley had some good suggestions for the interface accessors to nil check and return errors.

Merging this based on ACKS and IRC OKs. @jmrodri if you got a problem, yell at me :)

Fixes Issue #229 and #231


Project monitoring fix

Base on PR: https://github.com/rancher/system-charts/pull/36
This PR contains following changes

Remove RBAC resource from project monitoring charts
Use the service account injected by Rancher in project monitoring charts

Related issue: https://github.com/rancher/rancher/issues/19381

LGTM

LGTM, just small lint failures.
charts/rancher-monitoring/v0.0.3/values.yaml
  35:9      error    trailing spaces  (trailing-spaces)
  49:9      error    trailing spaces  (trailing-spaces)
  63:9      error    trailing spaces  (trailing-spaces)
  83:9      error    trailing spaces  (trailing-spaces)
  100:9     error    trailing spaces  (trailing-spaces)
  123:9     error    trailing spaces  (trailing-spaces)
  135:9     error    trailing spaces  (trailing-spaces)

Can we have drone for system-charts? @loganhz

Updated

LGTM


Updated version to v0.1.1

Issue #, if available:
Description of changes:

Updated version to v0.1.1
DO NOT MERGE until after v0.1.0 release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-983-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-983/1/index.html


How to debug in deeplab2

Hello,
I tried to debug 'Kmax Deeplab' but I cannot go into the call function in [deeplab2/model/kmax_deeplab.py](https://github.com/google-research/deeplab2/blob/main/model/kmax_deeplab.py) when I set the breakpoint as follows, and then the debugger just passes through the whole forward process.

so I tried to debug and finally got to the code that seemed to execute the forward function
the code is in quick_execute'function in my_path/tensorflow/python/eager/execute.py as follows

after I run this code,
tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name
I checked that the forward process was already finished
before I go into this function, I checked executing_eagerly == True lik this
executing_eagerly = ctx.executing_eagerly() in /home/kimdaehyun/.cache/JetBrains/PyCharm2021.3/remote_sources/-1311538014/-1764294251/tensorflow/python/eager/function.py
I use Pycharm IDE and I set the debugging environment like this.

what should I do?
Thank you :)

Hi @daebakk,
we're not supporting this way of debugging by default. Our trainer does not run in eager mode. We're using orbit for the training logic (see trainer.py). That again uses orbit which uses tf.functions by default. You could try to play around with the following, but we don't provide support here: https://www.tensorflow.org/api_docs/python/orbit/StandardTrainerOptions
Feel free to share your experience.
Best,
Mark

Hi @daebakk,
we're not supporting this way of debugging by default. Our trainer does not run in eager mode. We're using orbit for the training logic (see trainer.py). That again uses orbit which uses tf.functions by default. You could try to play around with the following, but we don't provide support here: https://www.tensorflow.org/api_docs/python/orbit/StandardTrainerOptions
Feel free to share your experience.
Best, Mark

Hi, @markweberdev
Thank you for your advice.
Then, How can I debug deeplab2 model?
Could you give some examples?

I'd recommend starting with some tf.print for example. "debugging" in graph mode is a common issue, you'll find infos when googling/stackoverflow. It's not as convenient as you are used to.

I'd recommend starting with some tf.print for example. "debugging" in graph mode is a common issue, you'll find infos when googling/stackoverflow. It's not as convenient as you are used to.

I understood!
Thank you :)


Test-Path ignores -Filter arguments

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Follow-up to #13764, which I think was closed inappropriately.

A -Filter argument passed to Test-Path should either be honored or, if a given provider cannot honor it, report an error.
Currently, the FileSystem provider quietly ignores a -Filter argument.

# On Windows
Test-Path $env:SYSTEMROOT -Filter *.nosuch

Expected behavior
$false

Actual behavior
$true

Error details
No response
Environment data
PowerShell Core 7.3.1

Visuals
No response

Somewhat xly, the way to make it work is to append \* to the -Path argument:
Test-Path $env:SYSTEMROOT\* -Filter *.nosuch # OK -> $false

That is, it works like with the (rarely used) Get-Item cmdlet, not like with Get-ChildItem.


Added possibility to decorate generated migration files with a custom suffix

It is rather hard to find a certain migration with the current filenames:
PropelMigration_1456744599.php
PropelMigration_1457186710.php
PropelMigration_1457212222.php
PropelMigration_1458157955.php
PropelMigration_1461870141.php
PropelMigration_1462121943.php
PropelMigration_1462860381.php
PropelMigration_1462946617.php
PropelMigration_1463383579.php
PropelMigration_1464338765.php

This PR allows an optional suffix to be specified when creating migrations, so that the filenames directly hint at what the migrations contain:
PropelMigration_1456744599_import_process_data_model_enhancements.php
PropelMigration_1457186710_user_entry_rows_cascade_delete.php
PropelMigration_1457212222_data_model_correction.php
PropelMigration_1458157955_transaction_row_additional_booleans.php
PropelMigration_1461870141_additional_fields.php
PropelMigration_1462121943_input_results_created.php
PropelMigration_1462860381_import_improvements.php
PropelMigration_1462946617_core_mapping_indices.php
PropelMigration_1463383579_correct_utf8_encoding_for_foo_table.php
PropelMigration_1464338765_user_table_definition_correction.php

Create addition, thanks!


Add support for taking min and max over predicates

Dear @joewatt95 - It seems that we missed your PR. Please, accept our apology for any inconvenience. We are still checking what happened. Do you still need the PR?
Best regards,

Oh sorry, it was an accident!

No problem them. Thank you the ack.


Completion support

Hi. I'd like to add basic completion support.

I've almost done the basic completion support. Currently, the new editor is totally broken on mobile browsers (especially Chrome on Android) since Monaco editor doesn't support them. So I've left the plain textarea editor just in case.

I realized I can't edit existing query and have fixed it :sweat_smile:

I released version 0.5.0.beta1.
https://rubygems.org/gems/adhoq/versions/0.5.0.beta1
Please, use and feedback.


Small improvements to the country picker (background, touch background to close)

I've played a bit with the package and added a patch to it. Facilitating the changes I added using new properties could benefit someone else.
Most of it may only be visible on Android.
diff --git a/node_modules/react-native-phone-input/lib/countryPicker.js b/node_modules/react-native-phone-input/lib/countryPicker.js
index 46659fc..0f4ec31 100644
--- a/node_modules/react-native-phone-input/lib/countryPicker.js
+++ b/node_modules/react-native-phone-input/lib/countryPicker.js
@@ -1,5 +1,5 @@
 import React, { Component } from 'react';
-import { Text, TouchableOpacity, View, Modal, Picker } from 'react-native';
+import { Text, TouchableOpacity, View, Modal, Picker } from "react-native";
 import PropTypes from 'prop-types';

 import Country from './country';
@@ -90,14 +90,16 @@ export default class CountryPicker extends Component {
     const itemStyle = this.props.itemStyle || {};
     return (
       <Modal
-        animationType="slide"
+        animationType="fade"
         transparent
         visible={this.state.modalVisible}
+        statusBarTranslucent={true}
         onRequestClose={() => {
           console.log('Country picker has been closed.');
+          this.onPressCancel()
         }}
       >
-        <View style={styles.basicContainer}>
+        <TouchableOpacity activeOpacity={0} style={styles.basicContainer} onPress={this.onPressCancel}>
           <View
             style={[
               styles.modalContainer,
@@ -133,7 +135,7 @@ export default class CountryPicker extends Component {
               </Picker>
             </View>
           </View>
-        </View>
+        </TouchableOpacity>
       </Modal>
     );
   }
diff --git a/node_modules/react-native-phone-input/lib/styles.js b/node_modules/react-native-phone-input/lib/styles.js
index ffb7365..721b36f 100644
--- a/node_modules/react-native-phone-input/lib/styles.js
+++ b/node_modules/react-native-phone-input/lib/styles.js
@@ -15,6 +15,7 @@ export default StyleSheet.create({
     flex: 1,
     justifyContent: 'flex-end',
     alignItems: 'center',
+    backgroundColor: '#00000088',
   },
   modalContainer: {
     width: SCREEN_WIDTH,

Also the hit slop for the flag could be made a bit bigger for default implementation :). Sorry for not submitting a PR :(.


handle error when user is trying to insert into a table more values than it has columns

SQL to reproduce:
create schema schema_name;
create table schema_name.table_name (column_in_table smallint);
insert into schema_name.table_name values (1, 2);

Expected result in psql:
ERROR:  INSERT has more expressions than target columns

additionally print line with the error like:
LINE 1: insert into empty values(1);

Actual result:
insert into schema_name.table_name values (1, 2);
INSERT 0 1

storage/src/frontend/mod.rs method
    pub fn insert_into(
        &mut self,
        schema_name: &str,
        table_name: &str,
        values: Vec<Vec<String>>,
    ) -> SystemResult<Result<(), OperationOnTableError>> {

does not check the number of columns in a table

Hello @alex-dukhno, I would like to contribute to this project. Do you know if anyone is working on this issue? If not, I would like to.

Hi @AndrewBregger, generally speaking, if no one is assigned then no one is working on it 😄
So yeah, you can start working on it.
The only thing is that I hope @silathdiir is not going to implement it in #124.
If it is bothering you, the other variant is #76

Alright, good to know., Since @silathdiir work on #124 could also resolve this issue, I will work on #76.

The PR #124 has already been merged. But this issue has not been fixed yet. Please feel free to take it.