Move to event based text input

Closes issues:

https://github.com/ppy/osu/issues/3125
https://github.com/ppy/osu/issues/3326
https://github.com/ppy/osu/issues/6338
https://github.com/ppy/osu-framework/issues/1965

Closes PRs:

https://github.com/ppy/osu-framework/pull/1742
https://github.com/ppy/osu-framework/pull/4709

all of the ideas/changes from there have now been implemented

Turns out to be quite simple, with minimal changes to textbox.
Mirrors existing key-blocking behavior, just that consumingText is replaced by RecentTextInput.
RecentTextInput is more robust, allowing us to remove the dodgy modifier key checking logic.
This PR is made with the following in mind:

a text event will always come before a key press that caused it

that key press should be be blocked/consumed
this ordering is guaranteed because text events are sent from the main/input thread, while key event are sent from the update thread

it's not neccassray that a key press happens after a text event
if a key is held, it's not guaranteed that every repeating text event will have exactly one repeating key event (one or the other may be more frequent)

this is because the OS handles text repeat, while InputManager handles key repeat

Tested working as expected on Windows and Android.
Issues
• Dead keys are not handled properly
SDL limitation, we don't get a text event for those.
Dead keys are commonly activated with AltGr, possibly causing problems with keyboard shortcuts getting activated when they shouldn't.
• Arrows (and other text editing keys) don't work while RecentTextInput is true
Importantly, backspace is not affected.
Possible real-world example:
Hold Shift, press a key (eg. W), then try to select text with Shift+←. Nothing will happen.
Selecting works fine if you release all the keys and then use Shift+←.
This could probably be fixed by more complex logic in OnKeyUp(), but is unnecessary.
Setting RecentTextInput = false when all keys are released seems like a reasonable and simple solution that would cover >99% use cases.

None of these issues are a deal-breaker, and they are also present on master.

this ordering is guaranteed because text events are sent from the main/input thread, while key event are sent from the update thread

Can you elaborate on this? I am not feeling this too much. In general "guaranteed event ordering" raises immediate red flags because the point of events is that their order shouldn't matter.
Is it really impossible to have something like the following happen?
input thread						update thread

receives key event
schedules handling of key event to update thread
							receives and handles key event
receives text input event

The above may be impractically rare, sure, but I want to know how strong the guarantees are here for certain.

Have now done a lot of testing and arrived at the following.
@bdach
Looking at an isolated key press+text input event combo, there simply is no way that will happen. We get the two SDL events in the same pollSDLEvents() call, first SDL_KEYDOWN and then SDL_TEXTINPUT.
From my testing, there is at least an order of magnitude difference between the two paths.
Using Stopwatch.ElapsedTicks for counting from the time that the keyboard event is enqueued in InputHandler, it takes 30~50 ticks to enqueue the text event at TextBox. Compare that to the difference between the last input dequeuing (last chance to enqueue the keyboard input) and keydown arrving at TextBox: >400 ticks. Even if the keyboard key is enqueued just as the queue is emptying, there will always be enough time for the text event to reach TextBox.
But this leads us to the following problem:
Key events being so much delayed that a previous keyup will happen in-between the next text input and keydown, thereby resetting RecentTextInput.
Example of a failure:
textinput: j
KeyDownEvent: J
textinput: n
keyup: J   // J released, and all keys released, as reported by framework, but N is down according to SDL.
KeyDownEvent: N   // not handled by textbox
keyup: N

But this is very rare, happening 1-2 times in 3 minutes of keyboard mashing, and not once on a release build of visual tests.
Even if a single keyboard key goes trough, it's not such a bit deal. It probably won't be handled by anything.
For TextBox, it's important that it handles potential global keyboard shortcuts, and those are usually made up of multiple keys so no problems there, as we block until all keys are released.

If I'm honest my doubts are not assuaged too much by the above explanation. While the empirical measurements check out now, they may not do so anymore at any given point in the future if either we or SDL upstream changes literally anything in the event ordering/timing/dispatch/whatever.
The main question for me is: do we absolutely have to interleave keypress and text input streams like this?
In other words: I would probably rather have TextBox force-block some or all key events everywhere else when focused than have this solution. My proposal would avoid the problem entirely by not having to attempt to correlate text input events with keypress events at all. And if the user wants to do something else despite the textbox being focused, too bad, they have to drop the focus by pressing Escape, or clicking away, or otherwise. Not sure what others think of that though.

I would probably rather have TextBox force-block some or all key events everywhere else when focused than have this solution.

I think it would be beneficial if we look at some usages of TextBox, particularly in environments where keyboard shortcuts are used.

osu! editor setup screen, where you might want to save with Ctrl+S when you eg. change a difficulty name
chat, where Alt+1~9 is used for switching tabs, which may collide with option key combinations on macOS

should probably change the shortcut for that anyways

FocusedTextBox, used frequently across osu!, force-blocking here is not going to work

Could use different blocking logic. But i think that might be confusing as then some textboxes block keyboard shortcuts, while others don't.

If you want, we could strike a middle-ground. Keep the current logic as-is in this PR, which should block most key events as expected. But in case RecentTextInput == false also have the old logic, which would force-block some key events.

Finally got around to looking at this one.
Firstly, I think this is a good direction to take. But I also agree the flag is a bit haphazard (that said, so is text input across various platforms...)
I've done a refactor pass, half to make sure I understand what's going on, and half to tidy up usage around the flag to hopefully make it easier on the palette? @bdach interested to see if the changes make this change any better for you.
@Susko3 can you read through my commit and see if there's anything you disagree with?
I'm tentatively approving because this does solve multiple issues and the only way we're going to know if it's robust enough is to get it in users' hands.

Hmm, I intended to put it on the explicit scheduler to enforce order of execution. Any reason for using the drawable one instead?

I've went trough the problematic case described in that comment. And I can safely say that it doesn't matter what scheduler is used.
The exact problem is fixed with both schedulers.
OLD denotes behaviour without the schedule, NEW with.
// many frames ago, in an update frame, text and keydown event for 'O' processed as expected

--- begin update frame

UserInputManager.Update()  // no key events

// it's important for the bug that the event happens in between the two Update() calls.
SDL: keyup 'O' + keydown 'N' + text event 'N' (in that order)

TextBox.Update()   // text event processed:
                   // `textInputBlocking` set to true (no change, it was already true from the OnKeyDown)

--- end of update frame

// sleep until the next frame...

--- begin update frame

UserInputManager.Update() // the enqueued key events are processed:
 OnKeyUp: 'O'
  // OLD: set `textInputBlocking` to false
  // NEW: schedule `revertBlockingStateIfRequired()`
 OnKeyDown: 'N'
  // OLD: `textInputBlocking` is false, and no text events are scheduled, so this key event is not handled.
  // NEW: update the scheduler: run `revertBlockingStateIfRequired()`
  // this call to revertBlockingStateIfRequired() will not change the state of `textInputBlocking`, as a key is pressed
  // (I originally thought that this would set `textInputBlocking` to false, so that's why I used the drawable Scheduler.)

TextBox.Update()
 // if using drawable `Scheduler`, it's updated here. as you can see there is no difference
 // as revertBlockingStateIfRequired() will also not change the state here.

--- end of update frame

Now imagine what will happen if the second key is not N but something like Enter, or F11 (hint: it'll be erroneously handled by textbox).
Anyways, the chances of this exact scenarion are very slim. Keys have to be pressed and released in the middle of an update frame. And worst case scenario (with the schedule) is that the key is handled when it shouldn't have been, so the user just presses it again.
And for the other cases, I feel like it should be beneficial to always have the text events have priority over revertBlockingStateIfRequired(), as we want to block eagerly -- the drawable Scheduler is better for that. We are already blocking more than necessary since we only clear the flag once all keys are released.

I feel a lot better having everything setting that flag in one scheduler, but let's see what others say.

Let's go with what we have here and see how things play out.


Add TS types

There is a better way of writing these types so that it's not manually encoding by quantity, but I can't quite remember how it was right now. Anyway good to merge for the time being.


caches: add a Windows ARM64 cache file

This is useful for restoring the Windows ARM64 port of the runtime.
This currently does not build due to issues in the module.map
definitions causing a build failure.  However, adding the file enables
others to reproduce the build and help.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test


New Repeated R task from a manifest.

This is what I am needing help with.  Gotta run but let me know if this doesn't make sense/needs clarification.

My understanding is that the approach is essentially the same as the array jobs in here: https://github.com/FredHutch/slurm-examples/tree/master/mp-array/array
I just forget how to triangulate how I set up the Rscript part with kicking off the array jobs/sbatching and when/where to load the module/version of R I want.  I think I just need an EVEN MORE literal example where the instructions come from a csv.


scipy.optimize.minimize automatically convert scalar x0 to list

My issue is about scipy.optimize.minimize. When the input x0 is a scalar, it is converted to a list. Since the user defined object function still assumes x0 to be a scalar, it can cause VisibleDeprecationWarning. I think a solution could be simply raising a traceback for scalar input
Reproducing code example:

from scipy.optimize import minimize
import numpy as np
def g(x):
    print(x)
    y = np.array([1, x, 3])
    return x * x
minimize(g, 2, method='BFGS')

Error message:

[2.]
<ipython-input-18-7dbf1cec2b87>:5: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray
  y = np.array([1, x, 3])
[2.00000001]
[0.99]
[0.99000001]
[-1.88846401e-08]
[-3.98347888e-09]

Scipy/Numpy/Python version information:

serial 1.5.3 1.19.4 sys.version_info(major=3, minor=8, micro=3, releaselevel='final', serial=0)

My knee-jerk reaction is that np.array([1, x, 3]) is a user error, it should probably be np.r_[1, x, 3] or some such.

I agree. The documentation states that x will be passed in as a 1D array. I don't think we should raise an error when x0 is a scalar because that would raise errors in existing code. Does that make sense @nosarthur ?

I agree it is a user error. In my real code, the object function is related to y and it actually behaves as expected (for example, you can change the return to np.linalg.norm(y)) Maybe minimize first flattens x0.  It is thus not noticed until this warning shows up.
Not raising error sounds good too. I guess at some point this warning will become an error anyways. It is just slightly less obvious what the issue is.

OK. If we can't raise an error, are there changes to the documentation that would help?

The document of scipy.optimize.minimize is quite clear. Please feel free to close the case. Thanks


kiwix: init at 0.9.

This adds kiwix, an offline reader for Web content (like Wikipedia).
xulrunner is included here because it needs a specific version to compile and run.
Likewise for pugixml.

Package built fine on my machine. Going to close and reopen to try Travis again.

You shouldn't close PR's you can force push them to re-evaluate. Knowing travis he will just time out again. Also you're missing a license meta field.


date.js modifyStrToUnixCronSyntax() method returns incorrect nth day of week

Relating to the issue #845, nth day of week becomes n-1th day of week due to replacing all numbers in the cron expression that are in range 1-7 to 0-6. This does not look like a bug in later.js. One possible fix would be replacing the numbers up to the pound sign.

@kunkun-tang Happy new year! Looks like this bug is in date.js rather than later.js. If you can confirm, maybe @jh3155 can create a pull request?

@jh3155 @NaanProphet Still confused. Could you have a concrete example show what bug it is ?

@kunkun-tang You could reference issue #845 for an example.

@mariacioffi I couldn't see any correlation with #845. I'm able to see what happened on #845, but confused on this issue. If you are able to fix the bug #845 , feel free to open a pull request. I will review.

@kunkun-tang Happy new year!
I will make a pull request


use nan for supporting node(v8) major version upgrade

https://github.com/rvagg/nan

Updating for node-4 finished by ad1b1c94468e21c65ea49633325d935c665b3d1f


Handling notifier cancel in multiple languages

Implement #877

Re-enable AfterTextInput called with cancelButtonText. @ewpatton
But I'm still thinking about the difference between choose dialog & text input dialog.
The call back value of choose dialog can be controlled by developers, but the text input dialog cannot.
Is It more necessary to seperate the TextInputCanceled event and AfterTextInput event?

@ColinTree The issue is not whether to separate them but rather to prevent breaking apps that were built around the old behavior. By removing the call, any app that relied on it to detect a cancelation will be broken since it's a non-backwards-compatible change to the semantics of the component.

Done swaping @ewpatton

Can we alert user when the components are upgraded?
We can notify user to upgrade their events instead of keeping a backward compatible.

We will provide some information in the release notes, but it shouldn't be required that users adapt their code to continue using existing App Inventor projects.

@ewpatton I'm about to merge this one, I'm going to do the update to YOUNG_ANDROID_VERSION because that way every commit in ucr (and master) represents a working system.

@ColinTree MERGED (https://github.com/mit-cml/appinventor-sources/commit/eda075ad90cd5da2cc0bf89c83a5e09845434e82)


Proximity Sensors beyond 5V

What is involved in getting a 6-36V or 10-30V inductive proximity sensor to work correctly?
I have a 12V power supply I can use to power the sensor, and then I would need a resistor or other electronics of some type to lower the voltage for the input of the esp32?
Thanks,

Most proximity switches pull the signal to ground. I think if you supply the 12V to the sensor and tie the ground on sensor and the ground at the switch together it should work.
Here is a link to Slack. The is the primary support channel for questions like this.


Updated travis setup

Removed Erlang 18 as moving from gen_fsm to gen_statem will break the
builds
Updated contact emails for notifications

This fixes issue #329

Travis in the long term may only keep the latest release of each major version, in this case 19.3. Perhaps this would be a good time to replace 19.1 with 19.3?


Integrate Shorebird for Over The Air Updates

Is your feature request related to a problem? Please describe.
Currently Play Store does not allow rolling back updates, which means in case of critical bugs we will have to publish a new release and will have to wait until Google approves it (it can take around upto 10-12 hours)
Describe the solution you'd like
Integrating Shorebird, which provides Over the Air update functionality, we can push fixes to critical bugs without having to rely on Play Store. It is very similar to Code Push for React Native
Describe alternatives you've considered
There aren't any alternatives, Shorebird is created by the creator of Flutter itself
Additional context
https://shorebird.dev/

Hi @josancamon19, Already working on this, please assign me to this task.

Nothing against anyone, but in my opinion, @josancamon19 himself should integrate Shorebird. The integration process only involves creating an account and setting the app IDs in Shorebird, which is done automatically. Even after @Becca-Saka integrates it, Joan will have to follow all the steps again. If Joan shares the credentials for the Based Hardware account with Rebecca, then the setup won't need to be repeated.

Yeah, I get you, I had reached out to @josancamon19 earlier on discord on how we should go about that.

Done


Handle integer overflows and other stuff

I fuzzed things. Things broke.
Fixes #1616.
This changes the type of rdo_lookahead_frames in EncoderConfig from u64 to usize. API change; merge this before 0.1 if possible?

Fixed, rebased, etc.

Coverage decreased (-0.3%) to 69.579% when pulling 6399bb2e9ba3c4b7e7fbf36c3476174785048c51 on YaLTeR:fix-things into b9975f824fe832a749dea13ba0c2c771b7be7138 on xiph:master.


Bump SDK to 0.8.0

Compatible with upcoming CLI 0.15.0

Closed in favor of https://github.com/cartesi/application-templates/pull/7


Copy-DbaLogin bug

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[ ] feature
[x] bug:

Details
semi addressed in #1540
WARNING: [Copy-Login][22:13:29] BASE\sqlserver is the destination service account. Skipping drop.
 ---> Microsoft.SqlServer.Management.Common.ExecutionFailureException: An exception occurred while executing a Transact-SQL
                    statement or batch. ---> System.Data.SqlClient.SqlException: Supplied parameter sid is in use.
                       at Microsoft.SqlServer.Management.Common.ConnectionManager.ExecuteTSql(ExecuteTSqlAction action, Object execObject, DataSet fillDataSet, Boolean
                    catchException)
                       at Microsoft.SqlServer.Management.Common.ServerConnection.ExecuteNonQuery(String sqlCommand, ExecutionTypes executionType)
                       --- End of inner exception stack trace ---
                       at Microsoft.SqlServer.Management.Common.ServerConnection.ExecuteNonQuery(String sqlCommand, ExecutionTypes executionType)
                       at CallSite.Target(Closure , CallSite , Object , Object )
                       --- End of inner exception stack trace ---
                       at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
                       at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
                       at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
                       at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
DateTime          : 2017-07-02 22:13:29.875

WARNING: [Copy-Login][22:13:29] Failed to add dbcollectionlogin to SQL2016 | Exception calling "ExecuteNonQuery" with "1" argument(s): "An exception occurred while executing a
Transact-SQL statement or batch."
SourceServer      : sql2014

@potatoqualitee  This is fixed by #1540 unless you still get the error even after that logic was added?
I also don't know that we want to kill EVERY process tied by that login just simply supplying the -Force parameter. It would be to easy for folks to have accidents in production :)

Yeah i still get the error - i also wanted some more eyes and fixes - i sorta just replaced code that was giving errors ;)

that only happens with -Force no?

Yeah, Force is going to drop the login but if the login has active sessions (sleeping or otherwise) you cannot drop them.
I would think this would be as design. I'm not sure I would want to see this include additional logic on dropping any session in use. I think it is catching what it should.
I will see if I can clean up the notes to just include the error message and not the full stack.

Adjusted per discussion on Slack channel. Added KillActiveConnection parameter to handle connections on destination.

sweet AF


documentation: __meta* variables are not exposed to <metric_relabel_configs>

I've been bitten by that, trying to make it work. _meta* variables are
exposed to <relabel_configs> but not to the metric relabelling rules.
Document the current status.

PR updated to mention that __meta* labels - not __* - don't reach  metric relabelling.
@brian-brazil I don't see any mention of that in the <relabel_configs> section at https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config. Just that __ labels are removed, which is misleading wrt <metric_relabel_configs>.

Just that __ labels are removed, which is misleading wrt <metric_relabel_configs>.

Yes, those are the docs.

@brian-brazil PTAL

This is already documented, no need to duplicate it in other places.


make storage async, attempt 3.

addresses #108, #75
obsoletes #120, #121
co-authored with @aszepieniec.
This PR builds on #120.  @aszepieniec was able to remove the Mmr trait which resolves this headache and I added some further cleanups and fixes to get all tests passing afterwards.
Unlike #120, this PR does not spawn an OS thread for each method call in ArchivalMmr(or any method).
All tests are passing.  however it is important to note that f3384fbe6f642de9ca4474b4e5b4ead37a4da36c contains a questionable fix to ArchivalMutatorSet::batch_remove() that should be carefully reviewed by @aszepieniec prior to merging this..   edit: fixed properly by @aszepieniec in d602858f3d77933119153d9dc0a60e512e52a099
I should also note that this PR requires much less code to become async than #121.
dependencies: this code depends on github builds of twenty-first and tasm-lib.  The required changes are already in master of each crate, so once new releases are published we can use those instead.
Also, I have another PR in the pipeline that depends on this one.

In some places we .await inside a loop, which sounds bad performance-wise especially if it resolves through a database IO. Could you comment on how that affects performance and what the idiomatic way to do things asyncly is?
Also worth noting that this PR gave rise to issues #126 and #127 which are about avoiding repeated IO calls (and other optimizations) in the course of archival MMR and mutator set logic.

In some places we .await inside a loop, which sounds bad performance-wise especially if it resolves through a database IO. Could you comment on how that affects performance and what the idiomatic way to do things asyncly is?

The await just means "pause until this call completes, and meanwhile process other pending tasks".   Whereas in the old code with blocking storage layer, the same DB call meant "pause this entire OS thread while we wait on disk IO, blocking all pending tasks, until this call completes".
So awaiting inside a loop is not bad per-se.  And indeed compared to the old code, we are much more concurrency-friendly.
For illustration, let's examine the same scenario with non-async DB calls vs async calls.
non-async:
We get an RPC call that performs a lot of DB operations, say 1000 ops, and each op takes 10 ms.  (just for example).  Ok, so that's 100 seconds spent processing that RPC call, just for the DB ops.   And the tokio thread executing that task is just sitting there twiddling its thumbs waiting for the db/disk during those 100 seconds.  It may well have 30 other tasks that it should be processing, but it can't because it is waiting on blocking I/O.   More tasks are coming in from the network (peers, rpc, etc) and they pile up.
async:
We get the same RPC call that in aggregate takes 100 secs in the DB (primarily disk i/o).   Each call to the DB is followed by await which immediately returns control to the tokio executor.  So as the DB begins processing, tokio's executor has begun processing the next pending task, and when it hits an await, the executor moves on to the next one, and so on.    The CPU remains utilized whenever a task needs attention and thus no pile-up occurs.
The tokio executor is very similar to an OS scheduler, except that it requires cooperation (via calling await) whereas OS schedulers are pre-emptive and can rip execution away from any thread at any time.  Since the tokio executor relies on cooperation (by calling await) its performance degrades rapidly when tasks do not cooperate (by executing for a long time without any call to await).
I'm likely stating things you already know, but I hope there's a helpful nugget in there somewhere.   ;-)


Better errors for array/dictionary method calls that return mutable

Fixing #3154.
These .._mut() methods are called when the value was evaluated from an expression that is the lhs operand of a BinOp::*Assign expression.

I'm not a big fan of the "so cannot get a mutably entry from it" messages. I think having array.first() = 1 yield array is empty is pretty reasonable. The problem in #3145 is imho more the "no default specified" part. Specifically, I think array.at(1) = 4 should just yield array index out of bounds (index: 1, len: 1) without the default part. For dictionaries, we could also add a hint that insert should be used when the key doesn't exist yet, e.g. error dictionary does not contain key "b" with hint use `insert` to add a new pair instead.

The problem in #3145 is imho more the "no default specified" part.

Hi, this PR is addressing the "no default specified" part - the error message for .at(i) = .. and .at(i, default:..) = .. is trying to say "I know you may have provided the default value, but this assignment requires an entry from within the array/dict, and I can't retrieve such an entry because the index/key doesn't exist".
But what you said above also sounds good to me. Please advise.

Sure, updated the PR. However, I did not add the hint of use insert to add a new pair instead because the method requires a return type of StrResult<..> not a HintedStrResult<..>.

If you add a new impl IntoResult for HintedStrResult in cast.rs it should work. It's missing that.

Thanks!


main -> live 2024-09-30

Changes happened to /index.md which is outside of the cone of changes allowed by the main to live pipeline. This manually merges to live to establish the baseline.
Changes to /index.md are just metadata changes included in a large find/replace. These changes are OK to go to live.

The OPS build status must be stuck. OPS site says this passed. I'm going to override OPS and merge.


Update TurboGrafix16.json - No more Mednafen / replace with Beetle PCE.

Needs to have Beetle PCE since Retroarch core was renamed from Mednafen.

These 2 seems synonymous. And libretro seems like alias it.


Improvements to GetOrdinal behavior

Avoid an unnecessary call to Task.Run if we already have metadata but haven't populated the field index
Add GetOrdinalAsync for async callers who want to avoid Task.Run entirely

Note that GetOrdinal is called by GetFieldValue and this[string], which are called after Read/ReadAsync - this would previously have involved a Task.Run call for a task that completed immediately, whereas now we'll spot that we already have metadata, and complete synchronously.
Fixes #5114

I'm running integration tests and snippets locally, but it's looking promising so far.
This was a much nicer fix than I'd expected to be able to create :)

(Integration tests and snippets all passed.)


Add display_timezone support to dateTime element

Motivation
A new feature was added on kontent-ai side - support for timezones (https://portal.productboard.com/kontent/2-kontent-ai-public-roadmap/c/176-configure-timezones-when-working-with-date-and-time-element). By default the "value" field contains the UTC time, but REST API now also stores a new field called "display_timezone", which should contain a timezone string.
Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added (updated snapshots)
[x] Tests are passing
[x] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

Hey, thanks for the PR :) There is a planned migration to the Gatsby 5. Would you like to have this PR already in v4 or is it enough to have it in v5?

Hey, ideally I'd like it included in v4, but v5 would be fine as well.

Hey, ideally I'd like it included in v4, but v5 would be fine as well.

Hello @kszot-ref,
I think we can include this feature into the v4 supported package and release it as a minor version as the last and then we move on with v5 supported and release a new major version of gatsby packages.
Would it be possible to rebase your PR to resolve the conflicts? I have merged the prior feature requests - asset renditions #215.

Hi @Simply007,
I've updated my branch - squashed the changes into a single commit and rebased it against your master branch

Was released in 9.2.0: https://github.com/kontent-ai/gatsby-packages/releases/tag/9.2.0


Fix the API token field in JSON config

Maybe we should define the JSON config in this package, however, others are not, so we need https://github.com/libdns/godaddy/pull/1 to be merged..
@mholt  @artknight

merged
On Oct 29, 2022, 4:08 AM -0400, Xiaochao Dong @.***>, wrote:

Maybe we should define the JSON config in this package, however, others are not, so we need libdns/godaddy#1 to be merged.. then I will update the go.* files.
@mholt @artknight
You can view, comment on, or merge this pull request online at:
https://github.com/caddy-dns/godaddy/pull/1
Commit Summary
• cdf732f Fix the API token field in JSON config
File Changes
(2 files)
• M go.mod (2)
• M go.sum (4)
Patch Links:
• https://github.com/caddy-dns/godaddy/pull/1.patch
• https://github.com/caddy-dns/godaddy/pull/1.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Exclude coordinates from main search results

NetBox version
4.0.7
Topology Views version
4.0.0
Feature type
Change to existing functionality
Proposed functionality
This may be asking too much for too little actual benefit, but let's see.
When coordinate saving is enabled, discrete database objects are created under Device Coordinates. These are linked to their respective device by its name. A side effect of this is that when you look up a device through the main search, even if the name is an exact match, there are always at least two results, i.e. you're directed to a results page showing the coordinate pair and the device itself instead of going straight to the device page.
So what, big deal, you might say, one more click, but I dunno... I do a lot of work and searching in our NB instance on a daily basis and it kind of adds up? Especially considering that the coordinate objects aren't really relevant as a result anyway and it might even be a tad confusing to someone not familiar with the plugin?
If I want to view or delete coordinate assignments, I can do this just as well by going directly to Device Coordinates and filtering by device name. For 99.99% of cases there is no reason that I can see to have this object show up in the results and all it does is add time and navigation effort.
Use case
Improve clarity and save time and effort.
 I could've sworn the search drops you directly at the page if there is only one result, but evidently that's not true. There's a results page either way...
Welp, disregard. Sorry.

Its true that the coordinates are visible in the search (added in netbox_topology_views/search.py).
I agree that it might not be all that useful.
But if you know you are looking for a device you might use the search function from the devices page instead of the global search, that way you avoid any other results showing up and it might be a little bit faster, i understand that is also less elegant to use.

@Azmodeszer @mattieserver
While this has been closed already, personally I have no problem with changing the behavior. If I am not completely wrong, it is sufficient to delete search.py, where these searches have been defined. I would be interested in your opinion.

For 99.99% of cases there is no reason that I can see to have this object show up in the results and all it does is add time and navigation effort.

I completely agree.

Glad to see my issue wasn't completely pointless after all. Yeah, I don't really see any utility in having the coordinates show up in the search.

Hmm, just tested the idea of removing the search.py. Unfortunately this leads to an error: 'NoneType' object has no attribute 'display_attrs'
I don't know why this error occurs, not why the search.py should be mandatory. The docs suggest, it's optional: https://netboxlabs.com/docs/netbox/en/stable/development/search/


Refreshing of the page when navigating thru the history

Hi there,
firstly thanks for the nice plugin, it's exactly what I am looking for :)
When there new state in the url and for example I want to go back, the whole pages reloads, which is not very good ux and it's unnecessary really.
When I was manipulating query by myself, I didn't have the issue, I was changing the url as this:
router.push({       query: { ...router.query, param: 'value' },     });
Would it be possible to rewrite like this in the library so the unnecessary reload is not there?
Thanks!

Thanks for your interest!
I tried your suggestion but it had no affect.
Actually, Next.js internally transforms the URL object into string.
Please refer to:
https://github.com/vercel/next.js/blob/2f744a1ae32a65f1362af0957e3c57f33d102914/packages/next/shared/lib/router/router.ts#L1178
and
https://github.com/vercel/next.js/blob/2f744a1ae32a65f1362af0957e3c57f33d102914/packages/next/shared/lib/router/router.ts#L304-L306
Thus I think your code would be equivalent to passing a string URL.
(Perhaps I am misunderstanding your meaning, please provide a working example repository if possible.)
If we could use a static Router (import Router from 'next/router') instead of useRouter, we can avoid re-rendering, I think.
However, the current implementation needs isReady, so useRouter must be used

Well I started to experiment a bit, I have created example repo here: https://github.com/Daidalos117/url-state
What I have found is that if I use the recoil sync, there is sadly no history. Sync is probably using just replaceUrl, which is something I don't want. My primary target is to have history with all the states, so the user can go back.
I think I will just need to write my own syncer.
I recorded small videos with differences between working
[https://drive.google.com/file/d/14gk7wTcy7OJWqDEUAdjaJtp4VFzxu4Jp/view?usp=sharing](Manul handling)
[https://drive.google.com/file/d/1g_LObOvoF39bommMCBeM4F6rf8SMo90Y/view?usp=sharing](Recoil sync)

@Daidalos117

Sync is probably using just replaceUrl, which is something I don't want.

You can use pushState instead of replaceState.
https://recoiljs.org/docs/recoil-sync/url-persistence#push-vs-replace

Actually, that solved everything. I didn't notice that option, really sorry and big thanks for both the support and the library itself!


Enhance: Remove executing new shell to change dir

so there's still no way to use wt to change worktrees without creating a new shell ?


RNGoogleSignin.h "RCTBridgeModule.h" file not found

Hello guys
I have the error because of which i cannot run my project - RNGoogleSignin.h "RCTBridgeModule.h" file not found
Help me please
Use version of RN 0.39.2

Hey @zizizi17! RNGoogleSignin.h is not a part of React-Native but a bit of digging it seems it is a part of https://github.com/devfd/react-native-google-signin
I would recommend opening an issue over on that repo!

@facebook-github-bot close


Feature Request: Add .translate(x=..., y=..., z=...) kwarg overloads

Currently, the only way to use .translate(...) is by supplying a tuple/vector. If you only want to translate on a single axis, you must provide a tuple (or similar) with two 0 elements.
It would be awesome to be able to call .translate(y=12) to move on just one axis.
This would be especially helpful to avoid deeper indentation when using an autoformatter, for example when one argument is very long and the rest are zero.

translate doesn't just move the object (i.e. change the object's location) but actually recreates the object in the new position which is quite an expensive operation.  Users should generally use the mechanisms to re-locate an object: move, moved, locate, located, obj.position = (...), obj.position += (...) or the Algebra* operator.
The Pos class returns a Location and supports a keyword interface (X, Y, Z) so obj.move(Pos(X=#)) or Pos(X=#) * obj does what you'd like to do in a more efficient way than translate. Here is an example:
from build123d import *
from ocp_vscode import show_all

b = Box(1, 1, 1)
b.color = Color("Blue")
scaled = Pos(X=1.5) * scale(b, (1, 1, 0.5))

show_all()

translatemay be eliminated from the API or re-implemented as a move in the future.

I way prefer method chaining compared to the mulitplication operation. I maintain my point.
The internal implementation of a move vs. a translate has nothing to do with this feature request

Method chaining is not the preferred design pattern of build123d. There is no guarantee that the direct api and the operations are exactly the same.


Add declare class fields in the class docs

Nice one, I knew it was worth waiting for your review- thanks


ol-contextmenu v5 upgrade > Module not found

After updating from ol-contexmenu 4.1.0 to any of the v5 I get the following errors while compiling my react project (which is using typescript)

Module not found: Error: Can't resolve 'ol/control/Control' in 'C:\Users\0user\Documents\blabla\frontend\node_modules\ol-contextmenu\dist'
Did you mean 'Control.js'?
BREAKING CHANGE: The request 'ol/control/Control' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.
ERROR in ./node_modules/ol-contextmenu/dist/ol-contextmenu.js 17:0-35
Module not found: Error: Can't resolve 'ol/control/Control' in 'C:\Users\ub40user\Documents\holo\syrius\frontend\node_modules\ol-contextmenu\dist'
Did you mean 'Control.js'?
BREAKING CHANGE: The request 'ol/control/Control' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.
I found several solutions online involving babel & webpack.config but I for myself I'm using react-scripts and do not know hot to fix the import since it concerns a file inside the node_modules folder.

Thank you very much, I forgot to include the second rule yesterday while trying out a similar solution. Problem solved.
Have a lovely day 😃


Random seed support

Finally we get reproducible workflows!
Changes:

add seed field to generators
change DPRandomGenerator to inherit from DPGeneratorNode
Autorefresh is disabled by default since seed makes the result fully deterministic when arguments are the same (unless some underlying wildcard files change
add DPMultilineString node that passes string as is without applying dynamicPrompts to it
change PROMPT input time to STRING so that the text widget can be converted into input (intended for use with DPMultilineString for example)

Caveats:

I'm new to modding ComfyUI so could mess up in the code
DPJinja has seed input but ignores it at the moment
I don't understand what is special about PROMPT and what unforeseen consequences it could have when I changed it to STRING
I didn't update any docs/examples (and to lazy too do it, so maybe someone else can handle that)

As an offtopic, I see "view prompt" item in your to do list. There is a working implementation in Custom Scripts plugin but it involves some JS hacks

I stumbled on your PR while looking for a way to get reproducible workflows using this extension and gave it a try. It does seem reproducible, but it also seems to break wildcards in the random prompts node (tested by dumping the generated prompt to the console using a node from the WAS node suite). Anyway, thank you for making this PR, this would be very nice to have :heart:

@Robzz oh this is because of the change of DPRandomGenerator to inherit from DPGeneratorNode instead of DPAbstractSamplerNode as it doesn't initialize the wildcard_manager. TBH I don't exactly know why only random and combinatorial nodes had support for wildcards and not others, maybe wildcard support should be moved to a base class so that all nodes support it?
By the way, I'm currently working on wildcard pipes in a separate branch of my repo, so maybe common code for loading wildcards both from files and the pipe can be moved there.

Not sure whether other people think think that this approach to wildcards is useful. I use it for smaller item lists to split my large prompts into pieces while keeping everything inside the workflow.

Hi @romeobuilderotti
Thanks for the PR. I'm looking at it now, but I don't understand why you removed the WildcardManager from the Random Prompt generator.

@adieyal I made DPRandomGenerator inherit from DPGeneratorNode which is a better fit for random generation rather than DPAbstractSamplerNode which deals with deterministic generation. At least this is how I understood the need for 2 different base classes.
Probably in addition to that WildcardManager should be extracted to a separate file so that both DPAbstractSamplerNode and DPGeneratorNode support it. What is the reason why jinja, feeling_luckly and magicprompt didn't support wildcards? I didn't use file based WildcardManager so I lack experience with it


Uncaught exception when working with mutltiple python files

When I open multiple python files (as tabs) I get the following error every time I try to save one of them:
Error detected while processing function <SNR>50_BufWritePostHook[4]..<SNR>50_UpdateErrors[15]..<SNR>50_C
acheErrors[39]..285[1]..284[24]..SyntaxCheckers_python_python_GetLocList[9]..SyntasticMake[30]..syntastic
#util#system:
line   16:
E605: Exception not caught: E484
Error detected while processing function <SNR>50_BufWritePostHook[4]..<SNR>50_UpdateErrors[15]..<SNR>50_C
acheErrors:
line   39:
E170: Missing :endfor
Error detected while processing function <SNR>50_BufWritePostHook[4]..<SNR>50_UpdateErrors:
line   15:
E171: Missing :endif

E484 is a file access problem, this looks like a configuration error in your Vim, probably related to system().
Please open a Python file, run :SyntasticInfo, and post the output.

No feedback, no cry.


Dvir/transactions module changes

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

crates/papyrus_load_test/src/main.rs line 12 at r3 (raw file):
Previously, dan-starkware wrote…
So now this is not used, right? If so, please remove.

It was removed in the nex pull request (#503)


New Service Support: S3

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Tell us about your request
Add support for a basic S3 client

S3 has landed! Please keep an eye out for bugs an issue and let us know!


Add NarodMon.app v1.5.2

Thank you for the contribution. It needed some fixes, so they were made in adafaa2ad735b5c40c174b6b3d08b3d98a2da2f9. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Move internal component data off of components

Fixes #222. Storing internal component data on component definitions caused problems when running multiple apps simultaneously.

Made a number of changes here, the biggest being adding a concept of registering a component and adding an internal id to it so that we can store internal data on it.
Looking at unit tests, the existing ones seem to test output while all of the changes here are for internal things, so I didn't add any. Please let me know if any of these internal things should be tested.
Also I'm unsure the best way to ensure that nothing broke. All unit tests pass but that's about all the assurance I've got.

Looking good. You could probably add a test case for the original problem you had: not being able to run two apps at the same time using the same components but with different sources. If that passes then it should be good to merge in.

Cool I'll write something for that shortly. Any protocol for ensuring that stuff doesn't break other than unit tests?

@anthonyshort Interesting thing happened when writing tests for this—I couldn't get the tests to fail on master because I realized that all of the properties stored on components (which I'm removing in this PR) are added due to sources. No other code seems to use them. So it's possible all of this code will be removed anyway when sources are removed. Thoughts?

Looking into these cloud failures in FF.

Yup this is all used for sources. We probably won't need sources if we implement some of the other features we're looking at. But if this is something you need now, I'm happy to merge it when its ready.

This is ready whenever you're happy with it. I'll be interested to see how contexts (or other things) replace sources. Is that something you see coming about in the coming weeks or is it probably still months out?

Awesome, I'll have a look through it now. Here's a discussion going on about the changes we could make: https://github.com/dekujs/deku/issues/218
It's probably not too far out, but they'll be breaking changes. I'm guessing we'll make these changes and move it to a v1.0 if everything works out.

Great, thanks for the heads up.


modify rosebush.conf to have default in path so changes to versions is transparent

resolution_fixed   |    by<EMAIL_ADDRESS>
hi everyone
rosebush.conf has version hardwired so needs changing each time rose is updated.
Change to default version and let default point to current version.
Needs to be done on accessdev, twister, webnm-dev ( I think ) ?
Robin

Issue migrated from trac:131 at 2024-01-31 18:06:33 +1100

ibc599 commented

Only on webnm-dev.
Accessdev doesn't support multiple versions of software (Rose/Cylc/FCM/UMUI)
Twister doesn't support rose bush.

<EMAIL_ADDRESS>changed resolution from `` to fixed

<EMAIL_ADDRESS>changed status from new to closed

ibc599 changed _comment0 which not transferred by tractive

<EMAIL_ADDRESS>commented

Changed on webnm-dev so points to default now.
Robin

<EMAIL_ADDRESS>removed milestone (was Future)

<EMAIL_ADDRESS>commented

Milestone Future deleted


Changelog/Version History

Is there a changelog somewhere for users of previous versions? I couldn't find one anywhere and the github/releases isn't used. Makes it hard to know when updating is useful/necessary, and which accustomed-to behaviors might have changed.

Turns out there's a changelog file in the root, PatchNotes.md
https://github.com/JusKillmeQik/PoE-Leveling-Guide/blob/master/PatchNotes.md


Just end up in "lv_label_create(NULL,NULL)", what's the problem?

Resume to check this graphic lib these days, found more people involved, good job to the author.
I update to the latest lib, and find the code just end up in lv_label_create() and I just trace it. Finally it go to a dead loop in "void * lv_mem_alloc(uint32_t size); -----> e = ent_get_next(e);"
It just keep this operate and "alloc" just still remain NULL, then "e" just became NULL not long after.
I just can't figure it out.

I just found I didn't initialize the lib. = =


Improvements to the README and documentation

Codecov Report

Merging #44 (aedeff7) into main (9a73333) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   93.18%   93.18%
=======================================
  Files          20       20
  Lines         690      690
=======================================
  Hits          643      643
  Misses         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a73333...aedeff7. Read the comment docs.


New version: DucFabulous.UltraViewer version 6.6.63

- [X] Have you signed the Contributor License Agreement?

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.5 schema?

Resolves #132374

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

1/2/2024 10:18:07 PM
Installer Verification Analysis Context Information:
Installer https://dl2.ultraviewer.net/UltraViewer_setup_6.2_en.exe
Scan request id: 'f50bb34f-6f28-4e85-bf15-e1d8a02e95ac'
Error information: BlockingDetectionFound

Automatic Validation ended with:

1/2/2024 10:18:07 PM
Installer Verification Analysis Context Information:
Installer https://dl2.ultraviewer.net/UltraViewer_setup_6.2_en.exe
Scan request id: 'f50bb34f-6f28-4e85-bf15-e1d8a02e95ac'
Error information: BlockingDetectionFound

(Automated response - build 525.)

@wingetbot run


Refactor SemanticsData and SemanticsNode to use Diagnosticable.

Also added tests as test coverage was very limited.
This time around I changed the output a bit to normalize with how the widget tree is displayed.
Feel free to commend on any cases where the existing output isn't good enough and you would like the output to more closely match the previously slightly more bespoke output. In particular, I don't have a strong preference how the actions should be displayed.

I'll update this code shortly adding a breaking change rename of the optional positional arguments to toStringDeep to  optional named arguments. This will also help with an upcoming CL to support specifying a verbosity level for diagnostics properties.

Ready to review. Switched toStringDeep to take named parameters.

How easy is it actually to configure the output even further beyond just child order? Two things I would like to see added at some point in the future are:

An option to show the transform matrix directly without translating it into a string representation.
An option to collapse leaf merged nodes into one node instead of showing the individual nodes.

I'd recommend always just showing the transform matrix using TransformProperty and instead focus on making the display of TransformProperty better (both toString and in the future in IntelliJ). It would be reasonable to have TransformProperty provide custom toString representations for matrixes that are simply translate, rotates, and scales and that would benefit all places where transforms are displayed.

You could extend this change to support optionally collapsing merged nodes with only a few more lines. Add the extra named parameters to _SemanticsDiagnosticableNode, debugDescribeChildren, and debugFillProperties to drive the custom behavior.

OK. Sounds good. Thanks for the explanation.

Coverage decreased (-48.2%) to 37.117% when pulling 0b64d61d578084fa1cdf5070c4f6baeca829883a on jacob314:semantics_refactor into c46347b6df27abdb91b8b7c63e90255fefc86a6e on flutter:master.


Using a custom "title" attribute breaks the fallback string when the attribute is undefined

Defining a custom attribute to hold the twipsy message ("title" option) causes twipsy to display the string "undefined" when the attribute is undefined, instead of the fallback string.
The problem is at the end of getTitle.  When the custom title attribute is not defined, the title variable is undefined. The title variable is cast to a string, which causes the undefined value to become the string "undefined" - which then gets displayed.
Potential fix:
https://gist.github.com/d9a988579d60224e36df

This line title = $e.attr(o.title == 'title' ? 'data-original-title' : o.title) is apparently written incorrect, because it looks at the attribute value of what you write as options.title. Proper fix would be:
//faulty line -> version 1.4.0 bootstrap-twipsy.js line 160
title = $e.attr(o.title == 'title' ? 'data-original-title' : o.title)

//correct one
title = o.title === 'title' ? $e.attr('data-original-title') : o.title;

you can no longer specify an attribute other than title in 2.0


Ability for httpsync script to compare file list files

Rsync is able to make use of file list files provided at the mirrors. This enables an easier check with less calls on source but also assumes that the file list is correct with reality.
The httpsync script lacks this feature and would benefit for an easier approach when mirrors containing such files is available.
The following features are to be added to the httpsync script:

New argument for providing a filelistfile
Compare the file between source and destination, extract a list of files to be added or removed ad destination
Keep the exclude query matches based on paths

The following to be done to the main script:

Add the checkresult status from httpsync just like rsync has

The scope for how advance this should be is lower. A simple check whether the files are equal or not is sufficiant. Does not need to be via the httpsync script


[BUG] Failed to start RKE2 server

Describe the bug
VM install with iPXE success, but starting rke2 fail as:

To Reproduce
Steps to reproduce the behavior:

use ipxe-example to install harvester
use virt-manager to monitor session

Expected behavior
rke2 start should success.
Environment:

Harvester ISO version: master-cdb4841-head
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): qemu/KVM single node

Additional context

rk2e-server.log
last tested success version: master-f5bde7fa-head

seems the default route is not found, did u rebase to the latest ipxe changes with https://github.com/harvester/ipxe-examples/commit/f99de09c33f1d82ddf53ab4ce98a213fdbf48d21

@guangbochen :thinking: i didn't pull the repo recently, do we change the default route policy in last few builds?
I will try the last commit (of ipxe-examples) again, if it is resolved, I will close this issue. :bow:

tested on Provo's machines and updated ipxe-examples, cant reproduce it...
this should be false alarm. :bowing_man:


Can ConSinGAN apply to SR and animation task?

This project is a very impressive job. I am wondering how to apply this model to SR and animation as SinGAN does. In SinGAN SR process, it need to up-sample several times, wherein those generators can't be run separately.

Hi, we haven't tested animation and super-resolution with our model yet, but I would be interested to see how well it works.
For animation I believe it should work just as well as SinGAN, since I think the main idea is to just perturbate z_opt at test time. However, if I remember correctly SinGAN changes some hyperparameters for animation training (different --min_size, different noise padding, possibly others). An easy way to test animation would be to train a ConSinGAN model on the image of interest and then slightly perturbate the input noise z_opt at test time to see results (maybe check how SinGAN perturbates the noise exactly). I think SinGAN does something like 0.95z_opt + 0.05random_noise, but the details might be more involved.
For SR it's a bit more challenging as you observed. One idea to do this in our model would be to upsample the feature maps produced by the final generator (but before applying self.tail()) and feeding them again into the final generator block. This approach could be repeated several times until the desired resolution is reached. But I haven't tried this so not sure how well it will work and you might have to play around a little with the upsampling operation, i.e. by how much you upsample before feeding the upsampled features back into the final generator block.

Edit: I just added code/examples (see readme) for image animation. Training is the same as for uncondtional image generation. At test time we simply add random noise to z_opt to create minor variations for the animation.

Thank you! I will tried this out and give more feedback.

Thank you! I will tried this out and give more feedback.

Hi, I am also working on this project recently. Have you successfully applied ConSinGAN in the super resolution task?

Hi, @tohinz thanks for the great work! I would also be very interested to hear if there are any updates about the super resolution task. Perhaps someone else has already addressed the issue.

Hi, we haven't spent any time on testing ConSinGAN for super resolution. There are some ways this could be implemented but we are not planning on working on this. I'm happy to help with any specific questions or if you run into problems with the code though.

Hi, ok thanks for your response! I might come back to you when I start implementing myself.


Added Mckinnon Secondary College

Added Mckinnon Secondary College

@kaveh-es First stage of verification passed, official domain for Mckinnon Secondary College is mckinnonsc.vic.edu.au as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@kaveh-es Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


apply common conventions vis a vis persistence to the chart

Signed-off-by: Kent Rancourt<EMAIL_ADDRESS>

Looks good, let me know when the PR is ready to be merged!

It's g2g.


Surveyor view: Assignment homes list - clicking dialog menu should show [something] instead of 'undefined undefined'

What data is meant to be displayed here?

fixed undefined.


wrong attributes in MinimumSizeActivity in AndroidManifest.xml

The declaration of the MinimumSizeActivity in AndroidManifest.xml contains an inner layout declaration. There are two attributes android:minimalWidth and android:minimalHeight which do not really exist and cause an error message in the Gradle build.
Fix: Rename attributes to android:minWidth and android:minHeight.

Commons: Remix from Creative Commons on Vimeo

Looks like this is fixed on master and can be closed

indeed. closing.


Trust dialog: "Learn more" link is not functional

Testing #122232

I cannot reproduce

-> Linux

still do not reproduce on linux

Ok then feel free to close, I am in Parallels, Ubuntu 20 ARM.


tarball for osx build gives a warning to user that github is not a trusted developer

Adam previously said that there was a warning of tarball for osx build gives a warning to user that github is not a trusted developer    so we need to be careful to make sure the steps are clear.  If it is just a warning that doesn't require action, just say "ignore the warning", etc.

I can make a PR proposed changes to the readme later tonight. In summary, the solution entails the user double-clicking on the executable (haven't tested the command line since it wasn't responding at all initially) and seeing a warning that the app can't be trusted, and then going into the security settings on the mac and authorizing the vchdfe app.


Update the recommendations for cluster settings to improved changefeed related latency

Fixes DOC-9015, DOC-9297, DOC-9300
This PR updates the Advanced Changefeed Config page to correct and provide detail on the various closed timestamp settings. These settings are really aimed at users with large-scale changefeeds/workloads, but the settings' interactions with changefeeds are relatively complex and the docs were not accurate.
Rendered preview: src/current/v23.2/advanced-changefeed-configuration.md

Incorporated all feedback, thanks @florence-crl


Allow coverage to drop by 1%

Proposed changes
As the title says, this reduces the amount of false positives in detecting test coverage regressions.
Type of change

[x] 🐛 Bugfix (change which fixes an issue)
[ ] 🚀 Feature (change which adds functionality)
[ ] 📚 Documentation (change which fixes or extends documentation)

Checklist

[x] Lint and unit tests (if any) pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All commits have been signed for DCO

beluga_ros limit is set to 90% as a special case for now, so this works as expected. Let's merge and see how it goes in other PRs.


Fix public chat

There were several codepaths where CryptKeysWrapper was used to look up TLF information for public TLFs.  This fixes all of that.  It also doesn't use GetCryptKeys to look up TLF information, so there could be a minor performance gain there.
It also fixes the CLI UX to show public information about the conversations in the list view and conversation selector shown in keybase chat read.
r? @mmaxim
cc @malgorithms who reported the issue.

The commits 8f4535cf8105...691b1ef02340 introduce visual changes on linux. :mag_right: 1 changed

Changed: Menubar-Private_Async_Writing (before) (after)


Getting a "Application Not Responding: System UI" error on Boot Start and when I run ./gradlew connectedAndroidTest in headless mode

I'm on an amd64 arch with accel off and while the boot start gets going (though I still have to run start_emu_headless.sh twice for the device to boot correctly even if I increase timeout to say 15 minutes), it mostly starts off with an error of System UI not responding when I run the command to see the window focus. I then apply the adb command to hit the home button to clear the pop-up, but then when I try to run ./gradlew connectedAndroidTest, it again shows the error. I have tried to run with more memory (3GB and 4GB), but the error persists. Any ideas why? No change to the docker image btw, just running the device in headlessmode.

I forgot to add it, but as a test, I have been trying to run the gradle command on this simple repo

@FruitPunchSamurai1961 seems related to this issue, there you can find a solution
https://webdriver.io/blog/2023/05/31/guied-for-xplatform-nativeMobile-app#system-ui-crush

Thanks for getting back to me @amrsa1! Actually, I did try that and the issue still persists.


Downgrade logback 1.4.x

It seems like logback 1.5.x is compiled using Java 21 (https://github.com/qos-ch/logback/issues/802), and can cause some build problems when using older versions of Gradle (similar to https://github.com/FasterXML/jackson-core/issues/955)
One option is to require users to use newer versions of Gradle (Gradle 8.5 and up seems to work), or downgrade to an older version of logback.
For better compatibility, for now, we should downgrade logback. Note: logback version must be 1.4.14 or higher, to make sure it has the CVE fix (See issue #4).
We can look at moving to version 1.5.x for a later release.

Downgraded logback to 1.4.14


support multiple version of jfsmount

Made some changes:

use /jfs/$(volumeID) as mount root, volumeID is different for each PVC, so each mount process can use its own mount path, then multiple versions will be supported.
clean both mount paths and mount ref paths, make sure node driver is cleaned when PVC is deleted.
use env JFS_AUTO_UPGRADE to enable or disable auto upgrading of jfsmount.

It seems travis-ci is asking for go 1.13. Not sure why it didn't fail before.
note: module requires Go 1.13FAIL	github.com/juicedata/juicefs-csi-driver/tests/sanity [build failed]
333M

Feel free to modify the configuration to make it pass. @tonicbupt

a little change in JFS_AUTO_UPGRADE:

if it's not set, then auto upgrade is ignored
if it's an integer value, the value will be timeout in seconds for upgrading
if it's not an integer, then timeout will be set to 10 seconds as default

deploy/k8s.yaml not changed yet, i accidentally clicked ready for review button =___=

a little change in JFS_AUTO_UPGRADE:

if it's not set, then auto upgrade is ignored
if it's an integer value, the value will be timeout in seconds for upgrading
if it's not an integer, then timeout will be set to 10 seconds as default

This is too tricky. Better to name JFS_UPGRADE_TIMEOUT for readability.

@yujunz as you said... after i removed code from Controller.CreateVolume and sanity tests failed...

now two env vars will be used: if JFS_AUTO_UPGRADE is not set, jfsmount will not upgrade automatically. if JFS_AUTO_UPGRADE is set and JFS_AUTO_UPGRADE_TIMEOUT is set to an integer, this value will be used as upgrade timeout, and default to 10s.
CreateVol is now lazily called in NodePushlishVolume
Dynamic provisioning will add mode in VolumeContext, and will be used in NodePushlishVolume to identify dynamic / static provisioning

since I have tested all the yamls in example directory, is it possible to remove sanity tests, otherwise CreateVol is still necessary in controller driver

@davies @yujunz

CreateVol is now lazily called in NodePushlishVolume

This does not  feel right, might be violating the spec. See https://github.com/container-storage-interface/spec/blob/master/spec.md#createvolume
The return code CreateVolume indicates the result of provisioning the storage, so we need to check auth and quota (when supported in the future).

Besides, node driver may not have the permission to create volume in some cases.

it's soooo ugly to cheat sanity ... @yujunz @davies

ok ... @davies @yujunz

works fine for all examples @yujunz @davies


Generic UTXO selection

extract code from bitcoin, so that other utxo chains can reuse it

[ ] Move TransactionPlan to Common.proto
[ ] Add common UTXO proto model (id/index/amount)
[ ] Add TWUTXOSelector interface (max amount / dust filter / fee)

will work on this in week or so

Being part of #1480

This one can be closed? new utxo chain should just reuse InputSelector @catenocrypt

Done with #1650 .


Use ipvs

New How to for Networking tab

Final review by Brendan
Can merge at any time

Deploy preview for calico ready!
Built with commit 277cd7b41a1b58fbe9df69af50d3a990653ad9aa
https://deploy-preview-2890--calico.netlify.com


migration: chatting and hub with some features

[x] Have you renamed the PR title to something meaningful?

Related Issue

Closes #165

Description

migrates Hub Page
chatting page
update chatbot feature
and more features

How Has This Been Tested?

Screenshots (if applicable)

Type of Change

[x] Bug fix
[x] New feature
[x] Code style update
[ ] Breaking change
[ ] Documentation update

Good


Ability for user to have multiple subscriptions

Is it on the roadmap to implement multiple subscriptions to cashier? I have a situation where a user is subscribing one or more students to a plan, and it would be great to do this with cashier.

:+1:

you could make your students model billable, instead of the user table. and have a foreign key reference to the user in the student table. I have achieved this where one user subscribes multiple companies to a plan.

@GavinCS Please can you state how you exactly achieved this?

@minisoftgroup

you could make your students model billable, instead of the user table. and have a foreign key reference to the user in the student table

This sounds like the best way to go.


Uncaught TypeError: Cannot read property 'file' of null

Has been working fine for months. this morning I tried to autocompile and got this error. tried reinstalling, rebooting, but to no avail
/Users/sammy/.atom/packages/sass-autocompile/lib/sass-autocompile-view.coffee:143 TypeError: Cannot read property 'file' of null     at SassAutocompileView.module.exports.SassAutocompileView.erroneousCompilation (/Users/sammy/.atom/packages/sass-autocompile/lib/sass-autocompile-view.coffee:143:24)     at /Users/sammy/.atom/packages/sass-autocompile/lib/sass-autocompile.coffee:451:34     at Function.module.exports.Emitter.simpleDispatch (/Users/sammy/.atom/packages/sass-autocompile/node_modules/event-kit/lib/emitter.js:25:14)     at Emitter.module.exports.Emitter.emit (/Users/sammy/.atom/packages/sass-autocompile/node_modules/event-kit/lib/emitter.js:125:28)     at NodeSassCompiler.module.exports.NodeSassCompiler.onCompiled (/Users/sammy/.atom/packages/sass-autocompile/lib/compiler.coffee:602:26)     at /Users/sammy/.atom/packages/sass-autocompile/lib/compiler.coffee:563:30     at /Users/sammy/.atom/packages/sass-autocompile/lib/compiler.coffee:469:21     at /Users/sammy/.atom/packages/sass-autocompile/lib/compiler.coffee:489:21     at ChildProcess.exithandler (child_process.js:209:7)     at emitTwo (events.js:106:13)     at ChildProcess.emit (events.js:191:7)     at maybeClose (internal/child_process.js:877:16)     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

Were you able to fix the problem I got the same issue?
TypeError: Cannot read property 'file' of null
at SassAutocompileView.module.exports.SassAutocompileView.erroneousCompilation (/Users/Hannah/.atom/packages/sass-autocompile/lib/sass-autocompile-view.coffee:143:24)
at /Users/Hannah/.atom/packages/sass-autocompile/lib/sass-autocompile.coffee:451:34
at Function.module.exports.Emitter.simpleDispatch (/Users/Hannah/.atom/packages/sass-autocompile/node_modules/event-kit/lib/emitter.js:25:14)
at Emitter.module.exports.Emitter.emit (/Users/Hannah/.atom/packages/sass-autocompile/node_modules/event-kit/lib/emitter.js:125:28)
at NodeSassCompiler.module.exports.NodeSassCompiler.onCompiled (/Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.coffee:602:26)
at /Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.coffee:563:30
at /Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.coffee:469:21
at /Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.coffee:489:21
at ChildProcess.exithandler (child_process.js:209:7)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:877:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

No, unfortunately not. It affected all of my apps. I switched to Gulp after
a day of trying g to solve the issue
On Feb 3, 2017 6:35 AM, "Hannah"<EMAIL_ADDRESS>wrote:

Were you able to fix the problem I got the same issue?
TypeError: Cannot read property 'file' of null
at SassAutocompileView.module.exports.SassAutocompileView.erroneousCompilation
(/Users/Hannah/.atom/packages/sass-autocompile/lib/sass-
autocompile-view.coffee:143:24)
at /Users/Hannah/.atom/packages/sass-autocompile/lib/sass-
autocompile.coffee:451:34
at Function.module.exports.Emitter.simpleDispatch
(/Users/Hannah/.atom/packages/sass-autocompile/node_modules/
event-kit/lib/emitter.js:25:14)
at Emitter.module.exports.Emitter.emit (/Users/Hannah/.atom/packages/
sass-autocompile/node_modules/event-kit/lib/emitter.js:125:28)
at NodeSassCompiler.module.exports.NodeSassCompiler.onCompiled
(/Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.coffee:602:26)
at /Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.
coffee:563:30
at /Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.
coffee:469:21
at /Users/Hannah/.atom/packages/sass-autocompile/lib/compiler.
coffee:489:21
at ChildProcess.exithandler (child_process.js:209:7)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:877:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/armin-pfaeffle/sass-autocompile/issues/105#issuecomment-277227062,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASkvtOdOtOt9IDvncTc105VMv6Ax2n-0ks5rYxDngaJpZM4Lz-XA
.

Oh Boy... ok thanx though for the quick answer :)

Hey together! Sorry for my late answer, having a lot to do at the moment.
Hm... Can you give me your node-sass verison? Go to terminal and enter node-sass --version.

node-sass 3.10.1 and libsass 3.3.5

I nearly have the same version. My libsass 3.3.6.

Can you give me a description (or perhaps the corresponding files), so I can try to reproduce this error?!


Add instructions and sample built in logging

Show dotnet run output and VS ASP.NET Web server output
Show web api todo sample failing in model binding. Debugger doesn't help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 967496ea-59b6-1f17-4f39-1e4c232126c6
Version Independent ID: 09bb2010-fe5c-1061-23ec-a0dcc92bdd3f
Content: Troubleshoot ASP.NET Core projects
Content Source: aspnetcore/test/troubleshoot.md
Product: aspnet-core
Technology: aspnetcore-test
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

no time for this.


Installation doesn't work on Laravel 5.6

Tried to install this package. There was no auto-discovery, nothing. Publishing vendor assets didn't work. Tried just running publish and the package wasn't listed.
Tried clearing config cache, dumping autoload, adding the provider to config. Nothing works.

Tried debugging this a bit. I've tried installing it on a 5.5 project and I saw that it installed a different version than on 5.6.
It installed 0.2.14 on 5.5 and 0.2.7 on 5.6.
Tried specifically to require 0.2.14 on 5.6 and I was met with dependencies issues.

devdojo/chatter 0.2.14 requires luketowers/purifier ~3.0 -> satisfiable by luketowers/purifier[3.0.0, 3.0.1, 3.0.2, 3.0.3].
- luketowers/purifier 3.0.0 requires illuminate/filesystem 5.1.|5.2.|5.3.* -> satisfiable by illuminate/filesystem[v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8, v5.2.0, v5.2.19, v5.2.21, v5.2.24, v5.2.25, v5.2.26, v5.2.27, v5.2.28, v5.2.31, v5.2.32, v5.2.37, v5.2.43, v5.2.45, v5.2.6, v5.2.7, v5.3.0, v5.3.16, v5.3.23, v5.3.4].
- luketowers/purifier 3.0.1 requires illuminate/filesystem 5.1.|5.2.|5.3.* -> satisfiable by illuminate/filesystem[v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8, v5.2.0, v5.2.19, v5.2.21, v5.2.24, v5.2.25, v5.2.26, v5.2.27, v5.2.28, v5.2.31, v5.2.32, v5.2.37, v5.2.43, v5.2.45, v5.2.6, v5.2.7, v5.3.0, v5.3.16, v5.3.23, v5.3.4].
- luketowers/purifier 3.0.2 requires illuminate/filesystem 5.1.|5.2.|5.3.|5.4. -> satisfiable by illuminate/filesystem[v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8, v5.2.0, v5.2.19, v5.2.21, v5.2.24, v5.2.25, v5.2.26, v5.2.27, v5.2.28, v5.2.31, v5.2.32, v5.2.37, v5.2.43, v5.2.45, v5.2.6, v5.2.7, v5.3.0, v5.3.16, v5.3.23, v5.3.4, v5.4.0, v5.4.13, v5.4.17, v5.4.19, v5.4.27, v5.4.36, v5.4.9].
- luketowers/purifier 3.0.3 requires illuminate/filesystem 5.1.|5.2.|5.3.|5.4.|5.5.* -> satisfiable by illuminate/filesystem[v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8, v5.2.0, v5.2.19, v5.2.21, v5.2.24, v5.2.25, v5.2.26, v5.2.27, v5.2.28, v5.2.31, v5.2.32, v5.2.37, v5.2.43, v5.2.45, v5.2.6, v5.2.7, v5.3.0, v5.3.16, v5.3.23, v5.3.4, v5.4.0, v5.4.13, v5.4.17, v5.4.19, v5.4.27, v5.4.36, v5.4.9, v5.5.0, v5.5.16, v5.5.17, v5.5.2, v5.5.28, v5.5.33, v5.5.34].

I do not believe it supports Laravel 5.6.
We are open to pull requests.

I tried and created a Laravel 5.6 project from scratch. Then required chatter, it installed v0.2.16 and it's working (apart from the db:seed command). For luketowers/purifier it installed v3.0.4.
But I must say I tried the same thing last week and also couldn't get it to work. The service provider auto discovery didn't work then..

It's because luketowers/purifier was updated to work with Laravel 5.6 yesterday so it fixed this package's dependency. Seems to work for me too now.

Glad you got it solved.


Fix Issue 46

This PR fixes issue #46: using %{key} in the uri(s) didn't get interpolated
with the key name being looked up. This used to be the behaviour with
hiera v3.
The reason for this is that the new uri(s) options now get interpolated
by expand_uris in location_resolver, even before it reaches the
backend. That meants that by the time the call reaches the hiera
backend, %{key} is no longer there.
I worked around this by implementing a simple string replacement that
looks for KEY and replaces it with the key name.
To verify this change, use __KEY__ as part of the uri or uris options.
The request should include the name of the key instead of __KEY__

Thanks for this fix - yes I agree it's probably the best way forward for now.


Implementation of OAK-D Camera

Adds an OAK_Camera and OAK_Odometer class to openVO. Not importable automatically in init files so no changes needed for anything else, but will need custom installs for use.
Looking for review to see if I messed anything up.
Future work hopefully will move all VO specific functions in the odometer classes into their own file and should reduce code duplication a lot.
All files have also been autoformatted with black.

Closing since I am going to transfer the OAK Camera implementation into another repo and have OpenVO depend on that. Reasoning for switching is that it makes more sense to me to store the OAK_Camera class apart since it does not strictly have to be for odometry. I plan to continue working on it and supporting custom pipelines, custom operations using premade torch models, etc...
Once that is done, there will be a single odometer class again to simplify the code on this side.


update(build/registry): make sure new artifacts requirements contain …

…the new engine_version_semver key.
All the rules are already modified to contain a semver string

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry
/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:
Find more details in https://github.com/falcosecurity/falco/pull/2899
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: loresuso
Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, loresuso
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c2ce80e8858cb99acd035d90382c265b60cf8d01


Update versions

@melix can you investigate the CI failure?

Seems that one error is no left space on device (!) and the other is a timeout. Let me restart the workflows.


Changed depth perception to point around nose bridge

Description
This PR addresses issue #67.  This can lead to the camera detecting the depth of the fork rather than the user's mouth. This pull request updates the depth perception to a 9x9 square around the bridge of the nose, which does not get covered by the fork.
Testing procedure
Test and run using the same procedure as https://github.com/personalrobotics/ada_feeding/pull/36#issue-1805648854. I have not run this code on the robot yet.

[x] Run your code through pylint and address all warnings/errors. The only warnings that are acceptable to not address is TODOs that should be addressed in a future PR. From the top-level ada_feeding directory, run: pylint --recursive=y --rcfile=.pylintrc ..

Before Merging

[ ] Squash & Merge

Also, I just realized that this code returns the entire 3d point for the of the bridge of the node. It shouldn't do that -- the x and y should still be the stomion x and y, and the depth should be for the bridge of the nose.
However, I just realized a problem with the assumption that the depth of the bridge is the depth of the stomion: it depends on the camera pose relative to the face (because depth is in the camera frame). For example, if the RealSense is below the mouth, then the bridge of the nose will inherently be farther from the camera than the stomion is. The assumption only really holds true if the camera is half-way between the bridge and stomion, facing the user's face.
Thoughts @egordon ? The above is how the old code did it, but given that we'll be playing around with staging location, maybe we want a more reliable approach?

@amalnanavati Relaying out discussion on the potential solution to this:
Outlier rejection: remove face points that are too close (i.e. right around the fork).
If there are at least a few mouth points remaining, average those to get the stommion depth.
If not: fit a plane to the rest of the face points (i.e. depth = np.dot(theta, [u; v; 1]), solve for theta), then use np.dot(theta, [u_stommion, v_stommion, 1]) as the depth for the mouth.

Closed by #130


Feedback for "Explore and Install VS Code Extensions"

https://help.sap.com/docs/SAP Business Application Studio/9d1db9835307451daa8c930fbd9ab264/d83a580979b841c3a424e6aa50ed2483.html?q=extensions
Update the extensions icon

Updated. Is it hard to see in this color theme, though? It's the default theme so I think we should use it, but it's kind of unclear.
https://help.sap.com/docs/SAP Business Application Studio/daa8adb7947848d8af8fc62e838e830e/d83a580979b841c3a424e6aa50ed2483.html?locale=en-US&state=DRAFT

Updated:
https://help.sap.com/docs/SAP Business Application Studio/daa8adb7947848d8af8fc62e838e830e/d83a580979b841c3a424e6aa50ed2483.html?state=DRAFT
Looks better now! Thanks for sending the image.

Yes, looks better. I would maybe still make it a bit smaller. What do you think?

I think it looks good now. :)


benchmarks depends on latest available RoaringBitmaps available

When one runs benchmarks via run.sh on the outdated feature branch the codebase is published as let's say 0.6.45-SNAPSHOT. If in the mean time the newest version was released (e.g..0.6.50) https://github.com/RoaringBitmap/RoaringBitmap/releases then it will be used in the class path for the benchmark.
I've been hit by that while working on https://github.com/RoaringBitmap/RoaringBitmap/pull/169 and noticing no improvement with the changes (and I knew there were here a months ago when I've started). And I suppose it might hit me when I was working on iterators performance merge request - which I decided to close because of benchmarks.

I am not sure I understand the issue. Are you able to identify the fault in the script?
https://github.com/RoaringBitmap/RoaringBitmap/blob/master/jmh/run.sh

c.c. @gssiyankai

@ppiotrow
If I understand correcltly your point, you mean that your local version of RoaringBitmap was 0.6.45-SNAPSHOT while a more recent release version 0.6.50 was available on maven central ?
If so, I agree that you are not benchmarking 0.6.45-SNAPSHOT but  0.6.50 and of course there is no difference between 2 runs.
Still, I don't think this is an issue. IMHO, you should merge master in your local branch more frequently. In the example given above, after merging, you would be benchmarking 0.6.51-SNAPSHOT which is the most recent version overall.
In case you are in a situation where you cannot merge because you are in the middle of a long dev, I recommend you to run maven offline with mvn -o ...

IMHO this is an issue. I used to run benchmarks that were checking local version of the codebase. I lack knowledge on how to define dependencies in maven. I could try to be always rebased with master but I could sometimes forget - which causes difficulties in development process - for me at least two times . Being not rebased is not explicitly stopping the run.sh script.

The only solution I can see to avoid the difficulties you are referring to is to explicit set the version of RoaringBitmap in jmh/pom.xml. We already had a discussion about this:
https://github.com/RoaringBitmap/RoaringBitmap/commit/94ffa2a02c3404698b93bb69101418d770891686#commitcomment-20354923
We can reopen the discussion if you like.

@gssiyankai

The only solution I can see to avoid the difficulties you are referring to is to explicit set the version of RoaringBitmap in jmh/pom.xml.

We have been there before and it is harder than it seems (not saying that it is not possible!).
The script clearly leads the user (of the script) to believe that he/she will benchmark whatever gets built. It is unintuitive that it would pick up something other built. I think we can reasonably consider this to be a bug in the script. Or, at least, a dangerous limitation.
What we would need is...

Some way to query the version tag of what has been built...
Some way to query the version tag that will be used by JMH...

Sadly, maven does not seem to allow us to query such things.
I don't think it is the end of the story however. A bash script could compare the just built RoaringBitmap jar file, then look at the just built benchmark jar file and check that they have the same versions. It is fragile, but if it issues a warning that the user of the script cannot fail to see, then we are good.

Hello, if I allow myself interfering, I expect all pom versions to be aligned - in any situation. The usual way to managed this is to have a parent maven project with packaging=pom, referring underlying modules. Each release is done on the parent maven modules, leading to a pom version increment on each sub-modules.
Right now, the top maven module have packaging-jar. Changing this would require moving a lot of code. Not really nice for git histories, but quite trivial to do. An alternative, is to add a maven module with packaging=pom as sub-module as ensure the top module have it as parent, with the proper relativePath. Just the same, the new parent/subFolder module refers to the other modules with relative pathes. mvn versions:set or mvn release ... will need to be done over the parent/subFolder module.
Anyway, a clean solution (i.e. not querying versions in a bash script) will anyway require an additional pom with packaging=pom (@lemire I feel you can not get things clean and simple with maven without this packaging=pom additional pom.xml).
As an additional step, the root module can not have sonatype as parent, as it needs to have the new parent/subFolder as parent. I manage this by rather relying on
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>

I unsure the understand if current travis behavior is fully satisfying or not.
I sketched this in https://github.com/RoaringBitmap/RoaringBitmap/pull/179

Thanks. Personally, I don't mind moving the files around as long as we give everyone hacking the code a chance to sync. In this instance, @ppiotrow is the one with suspended code contributions, but I don't think he would mean the files moving... his changes are quite localized and easy to track manually.
Whatever we do, we definitively want to make sure that the travis tests keep on passing. Otherwise, it is a step backward.

Git or me will manage to migrate my code to the new files.

@blasd  Right, so we can reorganize the directory structure.

I assumed that this is fixed.


Failed transactions

Describe the bug
Description of the bug transactions mainly consists with horse to other assets getting failed
Steps to reproduce
Steps to reproduce here.
Additional context
Additional context here.

In order to help you we need more information.

TTtok token from katla to holesky sometimes getting failed

TTtok token from katla to holesky sometimes getting failed

Please provide details such as transaction hash and the type of error you are getting. We will look into it

stale


not compatible with<EMAIL_ADDRESS>

when I try to parse and repack a tarball, the result looks like a tar file,
but is not compatible with gnutar.
//extract.js
var tar = require('./')
var zlib = require('zlib')

process.stdin
  .pipe(zlib.createGunzip())
  .pipe(tar.Parse())
  .pipe(tar.Pack())
  .pipe(zlib.createGzip())
  .pipe(process.stdout)

then I run this command:
node extract.js < ~/.npm/tar/0.1.19/package.tgz | tar -tz

which should transform a tarball into a node-tar tarball,
and then list it's entries with the tar command.
output:
package.json
.npmignore
tar: Skipping to next header
README.md
tar: Skipping to next header
LICENCE
tar: Skipping to next header
tar.js
tar: Skipping to next header
.travis.yml
extracter.js
tar: Skipping to next header
reader.js
tar: Skipping to next header
buffer-entry.js
tar: Skipping to next header
entry-writer.js
tar: Skipping to next header
entry.js
extended-header-writer.js
extended-header.js
extract.js
global-header-writer.js
header.js
pack.js
parse.js
00-setup-fixtures.js
extract.js
header.js
pack-no-proprietary.js
pack.js
parse.js
zz-cleanup.js
fixtures.tgz
tar: Exiting with failure status due to previous errors

It looks like there is something messed up with the paths?
when I do: |gunzip | less I see that the directories have been chopped off.
package.json^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@000644 ^@001750 ^@000012 ^@0000000744 ^@12173645457^@011435 ^@0^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@ustar^@00^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
^@^@^@^@^@000000 ^@000000 ^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@{
  "author": "Isaac Z. Schlueter<EMAIL_ADDRESS>(http://blog.izs.me/)",
  "name": "tar",
  "description": "tar for node",
  "version": "0.1.18",
  "repository": {
    "type": "git",
    "url": "git://github.com/isaacs/node-tar.git"
  },
  "main": "tar.js",
  "scripts": {
...

there also seems to be spaces at the end of the numbers, but there isn't spaces at the end of numbers in the tarball which does work.
Is there an option that makes this work by default? I've been looking through the npm code to see how it packs/unpacks stuff, but I can't find anything unusual.

Any ideas on this?
Happening to on ubuntu 14.04

The pac module also uses this implementation, and therefore tars created using pac can't be extracted using the Ubuntu 14.04 default tar utility (gnu-tar).
As a temporary workaround for trying to extract on Ubuntu 14.04, I've installed bsdtar (apt-get install -y bsdtar), but I'd love to address this compatibility issue here in the tar module.
I'm not certain if this is a different issue or the same issue, but I here's a detailed run down of my use-case and problem

The tarballs created by this module are now working fine with gnutar and vice versa.  But there isn't a way in v3 to do stuff like stream.pipe(Parse()).pipe(Pack()).pipe(Parse()).pipe(Pack()) which never worked anyway.  Pack reads from the file system, Unpack writes to it, Parse emits entry objects from a tar stream.  There's no parse->pack chain.  I want to add that eventually, so that we can have support for tar cf output.tar @input.tar stuff.


Not responsive Extension issue

Issue Type: Bug
Extension Name: check-npm-updates
Extension Version: 1.7.7
OS Version: Windows_NT x64 6.3.9600
VS Code version: 1.55.2

:warning: We have written the needed data into your clipboard. Please paste! :warning:

I don't understand what the problem is. What does it mean "not responsive"? How does it look like?


Added .gitattributes file

Added .gitattributes file to stop corruption of configuration files within .zips.
Issue #23

Added .gitattributes file for fixing issue #23
Need to re-upload hands-on config file before closing issue.


armv7a in anroid emulator crash  undefined symbol: __popcount_tab

MuMu android emulator
android 6.0
Used “arm transmitter”.
system.loadLibary fail.
undefined symbol: __popcount_tab

Thanks for bug report but it does look related to gperftools. You sure you filed it into right project?


Workaround to bug 83713: GTID, MTR and relay log corruption

We have been bitten by what appears to be https://bugs.mysql.com/bug.php?id=83713
In this PR orchestrator responds to Error 1201 by issuing a sequence of operations which are expected to mitigate the error.
We are still to reliably reproduce the error.

While unable to reproduce the bug, this has been tested in production to at least not cause damage 😆  for almost two weeks. Merging.


Some highlighted texts have bounding box and some don't.

https://docs.minio.io/docs/golang-client-quickstart-guide

@deekoder It look fine for me. All code block looks the same

it went away


WIP Show better error when using ref cell instead of not

Well that looks good :)

ready for inital review

Looks good to me.
@forki Thanks for taking care of this.
Kevin

👍


Some analysis-related bugs

Fixes Outling typo
Fixes relative imports
Fixes non-recursive module search
Fixes imports of submodules

👍

@huguesv Aren't you supposed to be on vacation? :)
I added some more changes - found the ResolveModuleName tests and they were correct, so I made the proper fix.

👍
vacation starts tonight!


panel_20

Closes #270
Original NCL plot: http://www.ncl.ucar.edu/Applications/Images/panel_20_lg.png
Current Python plot:

I'd like to choose a better colormap for the contour plots, but I'm not sure what to use. I was thinking of using the diverging BlueRed colormap, but I don't know how to force the transition from blue to red to happen at zero. Any ideas of how to do this?
This is what it looks like when I just swap out the colormap

I'd like to choose a better colormap for the contour plots, but I'm not sure what to use. I was thinking of using the diverging BlueRed colormap, but I don't know how to force the transition from blue to red to happen at zero. Any ideas of how to do this?

Yeah! You can do this with DivergingNorm. See [this matplotlib example].(https://matplotlib.org/3.1.0/gallery/userdemo/colormap_normalizations_diverging.html#sphx-glr-gallery-userdemo-colormap-normalizations-diverging-py)
By adding the line divnorm = colors.DivergingNorm(vmin=-15, vcenter=0, vmax=40) under the colormap selection and adding norm=divnorm to the contourf calls, I was able to produce the following plot:

Is this more like what you had in mind?

I added a couple of formatting fixes, but over all code is running and looking good so far! I did want to ask about if you've done a local build of Sphinx and if it was successful? I ask because I tried to build locally but the code didn't produce anything past the beginning text lines, which I think is just an issue on my side, but wanted to double check.

Yeah! You can do this with DivergingNorm. See this matplotlib example.
By adding the line divnorm = colors.DivergingNorm(vmin=-15, vcenter=0, vmax=40) under the colormap selection and adding norm=divnorm to the contourf calls, I was able to produce the following plot:

Is this more like what you had in mind?

Thank you! This is exactly what I was trying to do.

I added a couple of formatting fixes, but over all code is running and looking good so far! I did want to ask about if you've done a local build of Sphinx and if it was successful? I ask because I tried to build locally but the code didn't produce anything past the beginning text lines, which I think is just an issue on my side, but wanted to double check.

I have generated the documentation and it looks fine to me. I don't see any glaring issues.

One last formatting style update and I also now see a warning that DivergingNorm is depreciated after 3.2 and should be replaced with TwoSlopeNorm instead. It looks like it will be a relatively similar implementation process, so a pretty easy update. After those two updates, I am ready to approve this PR!