mob_init: ImportError: No module named ete3

Just noticed this error  in the middle/end of the mob_init process?
2019-11-05 12:30:36,543 INFO: Sketching complete plasmid database [in /home/linuxbrew/.linuxbrew/opt/python/lib/python3.7/site-packages/mob_suite/mob_init.py:215]
2019-11-05 12:30:52,922 INFO: Init ete3 library ... [in /home/linuxbrew/.linuxbrew/opt/python/lib/python3.7/site-packages/mob_suite/mob_init.py:227]
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named ete3
2019-11-05 12:30:52,960 INFO: MOB init completed successfully [in /home/linuxbrew/.linuxbrew/opt/python/lib/python3.7/site-packages/mob_suite/mob_init.py:241]

I have ete3:
pip3up ete3
Requirement already up-to-date: ete3 in ./.linuxbrew/lib/python3.7/site-packages (3.1.1)

What does python -c "import ete3" command return? It looks like ete3 library did not install correctly even though pip reports it as being installed (ete3 has so many dependencies ...). In the mob_init it should start downloading the taxonomy file from NCBI that will help with taxid conversion to full taxonomic lineage. I did not see this issue when testing PyPI mob_suite 2.0.1 package. I will test it tomorrow too. ete3 is so picky ... that is why we've removed tree PNG rendering as so many users had issues with mesa drivers on their clusters. I have a strong desire to rewrite ete3 dependencies to make mob_suite more system agnostic.

I've just tried to run pip install on our HPC cluster in Winnipeg (waffles) and pip installed ete3 there correctly. I use a clean conda environment in order not to interfere with the system libraries. All dependencies were installed via pip (except to scipy which is a bit temperamental). I recommend installing ete3 via conda if pip does not work.
% (mobsuitepip) [kbessono@waffles ~]$ python -c "import ete3"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'ete3'

#Let's install this missing package via pip (not conda)
% pip install ete3
Building wheels for collected packages: ete3
  Building wheel for ete3 (setup.py) ... done
  Created wheel for ete3: filename=ete3-3.1.1-cp37-none-any.whl size=2226264 sha256=8afbc2d10976d58cf26fe1e25ab5141469e76dd32470bbd37d9dd5753e67906c
  Stored in directory: /home/CSCScience.ca/kbessono/.cache/pip/wheels/14/90/50/5c10d965e7fb68343d9c5349cce2787ff3e38397946468d640
Successfully built ete3
Installing collected packages: ete3, PyQt5-sip, pyqt5
Successfully installed PyQt5-sip-12.7.0 ete3-3.1.1 pyqt5-5.13.2

#Let's see if we can import it without any errors
(mobsuitepip) [kbessono@waffles ~]$ python -c "import ete3"

#Let's install mob_suite 2.0.1
% pip install mob_sutite==2.0.1
Building wheels for collected packages: mob-suite
  Building wheel for mob-suite (setup.py) ... done
  Created wheel for mob-suite: filename=mob_suite-2.0.1-cp37-none-any.whl size=31457968 sha256=5a52f0ab92302debf0ff4d7df303f38d47d3e7074c60ec67062f1375b25c03a5
  Stored in directory: /home/CSCScience.ca/kbessono/.cache/pip/wheels/71/09/77/7bbf6b90a4778bae6f2ac303e687f3cff3b8b5d698f2f403bf
Successfully built mob-suite
Installing collected packages: mob-suite
  Found existing installation: mob-suite 2.0.0
    Uninstalling mob-suite-2.0.0:
      Successfully uninstalled mob-suite-2.0.0
Successfully installed mob-suite-2.0.1

#Let's run mob_init
%mob_init
<...>
2019-11-04 21:05:12,797 INFO: Init ete3 library ... [in /home/CSCScience.ca/kbessono/.conda/envs/mobsuitepip/lib/python3.7/site-packages/mob_suite/mob_init.py:227]
Downloading taxdump.tar.gz from NCBI FTP site (via HTTP)...
Done. Parsing...
Loading node names...
2179768 names loaded.
212398 synonyms loaded.
Loading nodes...
2179768 nodes loaded.
Linking nodes...
Tree is loaded.
Updating database: /home/CSCScience.ca/kbessono/.etetoolkit/taxa.sqlite ...
 2179000 generating entries...
Uploading to /home/CSCScience.ca/kbessono/.etetoolkit/taxa.sqlite

Inserting synonyms:      210000
Inserting taxid merges:  55000
Inserting taxids:       2175000
2019-11-04 21:08:25,549 INFO: MOB init completed successfully [in /home/CSCScience.ca/kbessono/.conda/envs/mobsuitepip/lib/python3.7/site-packages/mob_suite/mob_init.py:241]

I think the problem is somehow connected to this 3 year old bug:
https://github.com/etetoolkit/ete/issues/195
I'll tell the postdocs to use it on conda elsewhere.

I was doing more testing on Debian image and also found that ete3 installs with no errors, but when importing NCBITaxa submodule from ete3, it fails due to dependency on package six. We had included this requirement in setup.py and re-released pip package with version <IP_ADDRESS> (as PyPI does not allow to replace existing versions). I agree that conda is the easiest way to install mob_suite as it depends on circlator, amos, mash and an array of python libraries. We hope that this pip would also work.

FYI - pip has issues with 4 digit versions X.Y.Z.W. Stick to semantic versioning https://semver.org


disable debug logging django_debug_mode

Hello ,
Do you know how to disable DEBUG Logging for django_debug_mode in hue.ini?
What would be the default value for django_debug_mode ?
Thanks,
Bharath

Hi Bharath,
Default value for django_debug_mode is true.
Cheers,
Jean-Francois
On Fri, Jun 1, 2018 at 9:17 AM Bharath<EMAIL_ADDRESS>wrote:

Hello ,
Do you know how to disable DEBUG Logging for django_debug_mode in hue.ini?
What would be the default value for django_debug_mode ?
Thanks,
Bharath
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudera/hue/issues/706, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHCQzxaLO0aSbea9BQeS2ig6znEPf4P9ks5t4Wk2gaJpZM4UW9uE
.

Hello  @jdesjean ,
Thanks for the quick response. So in order to disable  "django_debug_mode=false" will do the job ?
Thanks,
Bharath

Correct.
On Fri, Jun 1, 2018 at 9:30 AM Bharath<EMAIL_ADDRESS>wrote:

Hello @jdesjean https://github.com/jdesjean ,
Thanks for the quick response. So in order to disable
"django_debug_mode=false" will do the job ?
Thanks,
Bharath
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudera/hue/issues/706#issuecomment-393935436, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHCQz56YutTZDaYsQJ2qBV-8tt3_OK8Xks5t4WwQgaJpZM4UW9uE
.

django_debug_mode=false will be tested . But closing this for now


Issue with chapter 15 Sentiment Analysis with LSTM. Getting 100% accuracy while training.

Hello @rasbt.
I am facing some issue with chapter 15 part 2 notebook. I tried running the notebook on colab.
Issues:

According to the book the IMDB test data should have 25k samples. Currently the IMDB test data has 12.5k samples.
Need for installation of portalocker.
While training I am getting 100% validation accuracy right from from first epoch. (100% accuracy for all further epochs), and the test accuracy is also 100%.

Hi there,
I think that's because there were a few changes in torchtext. In order to reproduce the results in the book, you can try
pip install torchtext==0.10.0

to install the version I used in the book from https://pypi.org/project/torchtext/0.10.0/

Hello I just tried installing the said version but torch text 0.10.0 seems unavailable.

I can confirm. It jumps from 0.6 to 0.12. They must have removed this version. This is so weird. It's still available online but it seems that there is no source file anymore: https://pypi.org/project/torchtext/0.10.0/#files

I guess changing the code to suite the new torchtext is only option. Will try that.

Yeah, that might be the unfortunate consequence of that. Sorry about that! I am a bit hesitant to update the original notebook since it would then be different from the book text, which could be confusing for some. But if you get it to work with a newer version, I'd appreciate a PR. We could include this as an alternative notebook here on GitHub and then link it from the original one.

Surely I will work on it.

Hello, I have created PR please check.


Fix python code to actually compile

🚀 Deployed on https://65f4962bd3f04410e1eb99cd--cozy-fox-0defec.netlify.app


refactor code a bit, improve network address handling and related improvements

[ ] closes #215
[ ] closes #214
[ ] closes #213
[ ] closes #212
[ ] closes #202

Replaced by other PRs.


grok giving internal compiler error

Running grok on RHEL5
Internal compiler error: unrecognized character after (?<
Regexp: (?!<\\)%\{(?<name>(?<pattern>[A-z0-9]+)(?::(?<subname>[A-z0-9_:]+))?)(?:=(?<definition>(?:(?P<curly2>\{(?:(?>[^{}]+|(?>\\[{}])+)|(?P>curly2))*\})+|(?:[^{}]+|\\[{}])+)+))?\s*(?<predicate>(?:(?P<curly>\{(?:(?>[^{}]+|(?>\\[{}])+)|(?P>curly))*\})|(?:[^{}]+|\\[{}])+)+)?\}

Are you running Ruby 1.8.x? If so, you'll have to upgrade. Grok requires Ruby 1.9.3 or newer.


V0.5.0

Codecov Report

Merging #139 (a950ca8) into master (707779a) will increase coverage by 0.08%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   84.20%   84.28%   +0.08%
==========================================
  Files          22       22
  Lines        3475     3520      +45
==========================================
+ Hits         2926     2967      +41
- Misses        549      553       +4

Impacted Files
Coverage Δ

neurodiffeq/solvers.py
85.00% <76.92%> (+0.42%)
:arrow_up:

neurodiffeq/callbacks.py
94.23% <82.92%> (-1.83%)
:arrow_down:

neurodiffeq/losses.py
62.50% <0.00%> (+12.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707779a...a950ca8. Read the comment docs.


Shortcut conflict

This is logseq 0.7.7-1 on Linux. When installing tabs plugin I get

same issue here

As it is stated in the error dialog, there are shortcut conflicts. You may want to change the tabs' toggle pin shortcut from the plugin's setting page to another to mute the issue.

I understood the error message. Unfortunately, I did not find a way to list all given shortcuts so that it is easier to find a suitable one for tabs-toggle-pin.
My suggestion would be that the default shortcuts defined in tabs should not interfere with the basic shortcuts of Logseq.
Any recommendation what a suitable shortcut could be for tabs-toggle-pin.

@manfredlotz you are right, I did not anticipate that this could someday conflict with the default shortcut of Logseq. I will push a fix to change the pin tab short cut to as unset, because I am bad at choosing the right one.

@pengx17 Yes, it is difficult to find an alternate shortcut. Thank you very much.


RSP DropZone docs

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

I opted to leave out anatomy diagrams entirely because there really isn't much to show in the RAC version. It would basically be a drop zone area with an optional text context but that's it. If others feel strongly about including an anatomy diagram in the RAC docs just lemme know and I can include it but otherwise, I think it should be fine without one.


Wrap "Already upgraded..." text in the subscription tab

We have no issue for this one but the text exceeding the line width is not visible - these changes fix that.
Test plan

play with Cody tool window width
verify that the text is wrapped

Before
After


Order of elements is being destroyed

Parsing the following Xml:
"<c id='c1'/>"
yields:
 {"a":{"$":{"id":"1"},"b":[{"$":{"id":"b1"}},{"$":{"id":"b2"}}],"c":[{"$":{"id":"c1"}}]}}
which destroys the fact that c1 occurs before b2.   I cannot afford that, I'm switching to another library.

@UnbearableBear May I ask which one? I also can't seem to get order preserving roundtrips out of this lib...

@bluenote10 I use this one which works fine to me but I'm not sure it is maintained anymore https://github.com/nashwaan/xml-js

Thank you for the alternative.
I tried preserveChildrenOrder: true, then explicitChildren: true, preserveChildrenOrder: true, and it was not working, I couldn't guess I need these 3 options.
I think it's not intuitive to just keep the xml content order, and yes the result is too much duplicated.

Ran into this issue and switched to xml-js to fix.

Faced the same issue, unfortunately there was no way to get the exact order.
explicitChildren: true, preserveChildrenOrder: true, charsAsChildren: true
Even if you use above three options, you will get a lot of duplicated data.
I switched to https://github.com/nashwaan/xml-js that worked for my requirements. It preserves the order.
Also if your input xml is deeply nested, you might find the https://marketplace.visualstudio.com/items?itemName=nidu.copy-json-path plugin useful (I guess similar plugins are available for other IDE's as well). You can easily navigate the output JSON using this plugin. This saved a lot of time for me.


ghcjsHEAD: bump ghcjs shims

@cocreature @peti here's the fix for  https://github.com/NixOS/nixpkgs/pull/30711#issuecomment-338626434.

I pushed an additional commit which fixes the build of haskell.packages.ghcjsHEAD.fail which failed with:
haddock: No input file(s).

The fail package only exposes the Control.Monad.Fail module when build with GHC(JS) older than 8.0. For some reason the haddock phase when building with ghcjs fails when there are no modules to document. The strange thing is that the haddock phase does succeed when building with ghc.


Option to cancel loading vlcControl.

I am having an issue with Vlc.DotNet in my Win Forms application.
On form load when 'VlcLibDirectoryNeeded' is fired I am giving the user the option to locate their vlc install directory or ignore this and continue without video functions support. But it seems I cannot do the ignore functionality because I cannot get the VlcControl to ignore this fact. At the moment I've tried removing the control from the form and disposing it, neither have worked. Is there any way I can remove the control or get it to just not load, the error happens in EndInit method from ISupportInitialize

Vlc.DotNet version: 3.0.0
Vlc.DotNet project used: WinForms
libvlc version: x86, Got it with my standard vlc installation.
.net version: 4.7.1
Project language: C#
Project build architecture: x86
Operating system: Win10 64bit

This is not an issue with this library I am just looking for how to perform this functionality, if it is not possible can we possibly work it into this project?
Thanks in advance.

Hi,
Thanks for reporting. At first, I was tempted to say that we could just pass a boolean in the event args and handle that in the library, but I fear that the incomplete initialization would cause issues.
I think that the best way is to open your own dialog beforehand, and create the VlcControl afterwards and add it to your view. When doing this, you don't even need the DirectoryNeeded event, since there is a propery you can set before calling EndInit()

That being said, the event-based API should have a proper way to "cancel", because if someone doesn't have a VLC on his machine... I'm not sure how do people are handling this currently...

Maybe worth some thought, It would be nicer than having to dynamically create them all the time in my project. I even have one form that has 2 VlcControls playing simultaneously, it would be a pain to have to dynamically create them both. If there was a property on the 'VlcLibDirectoryNeededEventArgs' class perhaps called 'ignore' or maybe setting the 'VlcLibDirectory' property to null...

This is the code that calls the VlcLibDirectoryNeeded event:
https://github.com/ZeBobo5/Vlc.DotNet/blob/a63a6f5de23fa660bbd2b4221ffd810f95167df1/src/Vlc.DotNet.Forms/VlcControl.cs#L94
When you set VlcLibDirectory to null in the callback, an exception is thrown.
After reading through the file, I think that every reference to myVlcMediaPlayer is checked for null before using. In theory, we could replace that throw ... by a return without harming the code.
However, doing that is a breaking change for users that are catching this exception, and I'm not sure that this is really a nice thing to do.
I'm not really sure that asking the user for a folder during initialization is the right thing to do for the User eXperience. I'd rather let him the choice far before the VideoView initialization, and save that in a setting on the disk. If he does provide a valid path, only then you can create a VideoView and initialize it (and then you don't need the callback either, since there is a VlcLibDirectory property)
Closing as won't fix, since code provides a more flexible alternative to the designer already.
Feel free to continue asking questions 🙂


Note for 1.20.x version

If you plan on releasing a version for 1.20.x and keep Apotheosis compat you will need to change this:
https://github.com/LNatit/EnchantmentSort/blob/a1d8b7266f0fdc111e12562a2fe2f55ec0c2185d/src/main/java/com/lnatit/enchsort/ApotheosisSupport.java#L25
shadows is now dev.shadowsoffire

Git it!


License

I was considering doing a inclusion submission on F-Droid open source repository for Android devices. Could you please add a LICENSE file on the repository stating under which license this application is being released? Thank you

All source files are prefaced with the BSD 2-Clause licence. Regardless, I have added a LICENCE file replicating it.


Outpainting on M1 not working (AttributeError: module 'scipy' has no attribute 'signal')

Last login: Mon Oct  3 18:43:52 on ttys000
(base) ➜  ~ conda activate ml
(ml) ➜  ~ cd sd-gui
(ml) ➜  sd-gui git:(main) ✗ python app.py
Init mode: edge_pad
Traceback (most recent call last):
  File "/Users/bamboozle/sd-gui/ui/editor_tab.py", line 366, in do_outpaint
    iarr, marr = self.edge_pad(iarr, marr)
  File "/Users/bamboozle/sd-gui/ui/editor_tab.py", line 544, in edge_pad
    res = scipy.signal.convolve2d(
AttributeError: module 'scipy' has no attribute 'signal'

I fixed that last night before I went to bed. If you pull from my repo again, you should have the fixed code.


python312Packages.libpysal: 4.12.0 -> 4.12.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.libpysal is: Library of spatial analysis functions
meta.homepage for python312Packages.libpysal is: https://pysal.org/libpysal/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.12.1 with grep in /nix/store/jcsbgvq3viapww24c3fsp5q87frplhip-python3.12-libpysal-4.12.1
found 4.12.1 in filename of file in /nix/store/jcsbgvq3viapww24c3fsp5q87frplhip-python3.12-libpysal-4.12.1

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)

9 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.inequality
python311Packages.libpysal
python311Packages.mapclassify
python311Packages.momepy
python312Packages.inequality
python312Packages.libpysal
python312Packages.mapclassify
python312Packages.momepy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jcsbgvq3viapww24c3fsp5q87frplhip-python3.12-libpysal-4.12.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.libpysal https://github.com/r-ryantm/nixpkgs/archive/115819deb5b1e1ac7c33df7a0bd3a4b1c99d77c1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/115819deb5b1e1ac7c33df7a0bd3a4b1c99d77c1#python312Packages.libpysal

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jcsbgvq3viapww24c3fsp5q87frplhip-python3.12-libpysal-4.12.1
ls -la /nix/store/jcsbgvq3viapww24c3fsp5q87frplhip-python3.12-libpysal-4.12.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

16 packages built:

python311Packages.inequality
python311Packages.inequality.dist
python311Packages.libpysal
python311Packages.libpysal.dist
python311Packages.mapclassify
python311Packages.mapclassify.dist
python311Packages.momepy
python311Packages.momepy.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.momepy
python312Packages.momepy.dist

Maintainer pings
cc @autra @imincik @l0b0 @nh2 @nialov @sikmir @willcohen for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 338306 run on x86_64-darwin 1

16 packages built:

python311Packages.inequality
python311Packages.inequality.dist
python311Packages.libpysal
python311Packages.libpysal.dist
python311Packages.mapclassify
python311Packages.mapclassify.dist
python311Packages.momepy
python311Packages.momepy.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.momepy
python312Packages.momepy.dist


Gap After  tag

I have a problem after a img tag when i add img with u-full-width inside of that column theres a gap and I couldnt find why or where is this gap
 theres a gap after img tag and theres no margin , padding or some code for that

Can you post an example? Sometimes these things are browser-specific as well. What browser are you using when you see the problem?
Walter
On Jul 22, 2015, at 5:51 AM, Uğur Oruç<EMAIL_ADDRESS>wrote:

I have a problem after a img tag when i add img with u-full-width inside of that column theres a gap and I couldnt find why or where is this gap
theres a gap after img tag and theres no margin , padding or some code for that
—
Reply to this email directly or view it on GitHub.

Its a chrome and i looked on firefox theres same gap ketcap.github.io/Timeline theres a demo

This rule is one of my default resets, seems to fix your gap.
/* to prevent a gap from showing below images in some browsers */
img {vertical-align: bottom;}

Thank you so much =) worked very vell =)

you can also 'display: block' if you're not using the image inline


Switch from TensorFlow to Keras

In order to simplify the code of this project, a major improvement should be to switch from TensorFlow library to Keras one.
Keras would allow us to handle data in an easier way; TensorBoard will be still callable as well.

This issue is strongly related to issue #32 and #33 . Issues #34 and #35 have to be addressed according to this new framework as well.

We can consider that this issue is solved with the PR #61 merging. I close it.


Remove a footer from a Hub site

Category

[x] Bug

We have been having an issue with double footers and have removed the footer using PnP PowerShell as in issue 388 (https://github.com/pnp/sp-starter-kit/issues/388).  I ran the PowerShell to remove the footer and now when a new communication site is created there is only one footer.  Get-PnPCustomAction and Remove-PnPCustomAction.
However if you associate it with the hub site the Contoso footer then appears again as well as the out the box SharePoint footer.  Any advice on how to remove the hub site footer would be appreciated.
Expected or Desired Behavior
We would like only one footer to appear on the pages.
Observed Behavior
Double footer on hub site
Steps to Reproduce
Associate a communication site with the hub site and the Contoso footer then appears again as well as the out the box SharePoint footer.
Environment Details (Development & Target environment)
SharePoint Online

Starter kit version: SharePoint Starter Kit in SP Online
OS: Windows 10
Target Environment: SharePoint Online
Framework: [Node.js v6/v8/v10/v12]
PnPPowerShell Version : 1.5.0
Browser(s): Chrome Version 90.0.4430.212 (Official Build) (64-bit)
Additional details: The more context you can provide, the easier it is (and therefore quicker) to help.

Hi, can you clarify a bit. Do you have multiple PnP Footers? Or you have 1 Footer, and 1 out of the box footer?

Hi Beau,
When the communication site is created it just has the out the box footer but when it is associated with the hub site it adds the PnP footer as well as the out the box footer.
@.***D757BE.755D71E0]
Thanks.
Kind regards,
Joanne
Joanne Ciano
Microsoft Solutions and Power Platform Support Consultant
t: 0333 220 0777
e: @.***
w: www.tsg.com
TSG Support now offers Live Chat! Please visit tsg.com to chat to us regarding any issues you are experiencing or click here for further information.
You can learn about the various ways you can request support via our new support section at www.tsg.com/contact-support
Any urgent faults can still be reported by calling 0333 220 0777
If you’ve received this email by mistake, we’re sorry for bothering you. It, and any attachments, may contain information that’s confidential, so please delete it without sharing it. If you let us know, we can try to stop it from happening again. Thank you.

Please make sure that you scan this email and any attachments for viruses. We may monitor any emails sent or received by us, or on our behalf. If we do, this will be in line with relevant law and our own policies.

Technology Services Group is the trading name of Technology Services Group Limited. Registered Office Q11, Quorum Business Park, Newcastle, NE12 8BU. Company Reg No. 04816673 VAT no. 605300983
Before printing this email, please consider your environmental responsibility. Ask yourself whether you need a hard copy
From: Beau Cameron @.>
Sent: 01 June 2021 18:46
To: pnp/sp-starter-kit @.>
Cc: Joanne Ciano @.>; Author @.>
Subject: Re: [pnp/sp-starter-kit] Remove a footer from a Hub site (#495)
This message contains suspicious characteristics and has originated outside your organization.

Hi, can you clarify a bit. Do you have multiple PnP Footers? Or you have 1 Footer, and 1 out of the box footer?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/sp-starter-kit/issues/495#issuecomment-852324402, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUHNQXGSGGV6NFKJZ4BH3KDTQUMHJANCNFSM45SH5U5Q.
Disclaimer
The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.
This email has been scanned for viruses and malware, and may have been automatically archived by Mimecast Ltd, an innovator in Software as a Service (SaaS) for business. Providing a safer and more useful place for your human generated data. Specializing in; Security, archiving and compliance. To find out more visit the Mimecast website.

Thank you. I'm having trouble reproducing this. You aren't creating the communication site via a Site Design Template are you?  I create a new Communication Site, attached it to the PnP Start kit Hubsite, and I do not have a secondary footer at the bottom.


posix_fallocate fails on ZFS+FreeBSD

This error never shows up on Linux because glibc tries to emulate fallocate. However, it seems this call could be emulated with truncate on FreeBSD.

@P-E-Meunier by "emulate," do you mean a call that avoids unnecessary truncating? i.e. something like this?
#[cfg(target_os = "freebsd")]
pub fn allocate(file: &File, len: u64) -> Result<()> {
    let fd = file.as_raw_fd();
    let len = len.try_into().unwrap();

    let ret = unsafe {
        let mut stat: libc::stat = mem::zeroed();
        let len_new = if libc::fstat(fd, std::ptr::addr_of_mut!(stat)) == 0 {
            stat.st_size.max(len)
        } else {
            len
        };
        libc::ftruncate(file.as_raw_fd(), len_new)
    };

    if ret == 0 { Ok(()) } else { Err(Error::last_os_error()) }
}

I believe so, but it was quite some time ago, I don't remember exactly what the issue was. It was also reported to me indirectly.
My use of fs2 , when running on ZFS, is also hard to understand, since I'm doing copy-on-write (in the sanakirja crate) on top of a copy-on-write filesystem.

I have a current version of FreeBSD and ZFS running with this crate. posix_fallocate will fail with EINVAL.
diff --git a/src/unix.rs b/src/unix.rs
index 5c2f4f2..79f7595 100644
--- a/src/unix.rs
+++ b/src/unix.rs
@@ -96,7 +96,6 @@ pub fn allocated_size(file: &File) -> Result<u64> {
 }

 #[cfg(any(target_os = "linux",
-          target_os = "freebsd",
           target_os = "android",
           target_os = "emscripten",
           target_os = "nacl"))]
@@ -138,6 +137,7 @@ pub fn allocate(file: &File, len: u64) -> Result<()> {

 #[cfg(any(target_os = "openbsd",
           target_os = "netbsd",
+          target_os = "freebsd",
           target_os = "dragonfly",
           target_os = "solaris",
           target_os = "haiku"))]

A suitable workaround seems to be to make FreeBSD use the same allocate implementation as the other BSDs, but I'm not yet sure if this is a Good Idea :tm:
I tested another approach which would use ftruncate(2) on FreeBSD. Either really works for the higher level application I am using here which relies on this functionality.
I am not sure whether @danburkert has any preference to the approach taken here.

@rtyler I'm not sure if fs2 is maintained any more, the last commit was >5 years ago and several important PR's have been left open for nearly as long.
You may consider fs4 as an alternative. It is a fork of fs2 that is now actively maintained, and they accepted my PR to fix the FreeBSD+ZFS issue you are describing.

@ryanavella fs4 does bubble up the EINVAL but still does not provider a suitable allocate implementaiton, but I will take that up with that maintainer instead :smile:

I think the reason FreeBSD returns EINVAL with posix_fallocate is that fallocate doesn't really make much sense on a copy-on-write filesystem.
My workaround is to match on fs4::allocate and ignore the returned error if it is EINVAL, instead of blindly bubbling it up with the ? operator. In a lot of cases fs4::allocate will be paired with a ftruncate anyways, so there isn't much to do if EINVAL is returned other than continue.


Quote commands break if default prefix is set to a single quote

If the defprefix is set to a "'" Nadeko cannot perform any quote tasks other than adding a quote,
the "..." or "'.." command doesn't work at all
the ".." or "'." command produces a too few parameters error in console.
0 00:02:41 CommandHandler | Command Errored after 0/0/0s         User: seanieb#6464 [141321435103756288]         Server: Stasia and Joshy's Funland~! [179065904468852736]         Channel: bot [181999562561552384]         Message: '. Stasia         Error: The input text has too few parameters.

I think you got it confused.
.. and . are the real names of the commands.
if you have a prefix . then it becomes
... and .. for show and add
So if you have a prefix of ' the commands are
'.. and '.


[MRG] Fix handling of memory limit command line argument

If a string of only numerals is passed as argument we assume it should
be converted to an integer and specifies a size in bytes.
When BinderHub constructs the repo2docker command-line it passes a value in bytes without a suffix. This is with a value of "3G" set in the values.yaml.
I think this will allow us to try out https://github.com/jupyterhub/mybinder.org-deploy/pull/954

I added a unit test to make codecov happy.


Typos in OOP Meaning – What is Object-Oriented Programming? Article

Describe the Issue
One of the paragraphs within the article happens to be as follows:

In this article we will go over Object Oriented Programming (OOP) as a whole, without relying on a particular language. You'll learn what it is, why it's so popular as a programming paradigm, it's structure, how it works, its principles, and more.

Instead, it should be as follows:
In this article, we will go over Object Oriented Programming (OOP) as a whole, without relying on a particular language. You'll learn what it is, why it's so popular as a programming paradigm, its structure, how it works, its principles, and more.
NOTE: In the second sentence, instead of saying it's structure, it should be saying its structure.

One of the paragraphs within the article ( second paragraph within the following instance to be specific ) happens to be as follows:

For example, you'll define an employee object that defines all the overall characteristics of employees in your company.
You'll be able to then define a manager object that inherits the characteristics of the worker object but also adds characteristics unique to managers in your company. The manager object will automatically reflect any changes within the implementation of the worker object.

Instead, it should be as follows:
You'll be able to then define a manager object that inherits the characteristics of the employee object but also adds characteristics unique to managers in your company. The manager object will automatically reflect any changes within the implementation of the employee object.
NOTE: Within this paragraph, since we are trying to refer to the employee object ( defined within the paragraph right before the above paragraph ), keeping that in mind it should be saying employee object instead of saying worker object.
Affected Page
https://www.freecodecamp.org/news/what-is-object-oriented-programming/
Steps to Reproduce
Just viewing the article itself within the browser, should be sufficient to reproduce the problem.
Recommended fix or suggestions
For the first issue, updating the paragraph as follows should fix the typo:
In this article, we will go over Object Oriented Programming (OOP) as a whole, without relying on a particular language. You'll learn what it is, why it's so popular as a programming paradigm, its structure, how it works, its principles, and more.
NOTE: In the second sentence, instead of saying it's structure, it should be saying its structure.

For the second issue, updating the paragraph as follows should fix the typo:
You'll be able to then define a manager object that inherits the characteristics of the employee object but also adds characteristics unique to managers in your company. The manager object will automatically reflect any changes within the implementation of the employee object.
NOTE: Within this paragraph, since we are trying to refer to the employee object ( defined within the paragraph right before the above paragraph ), keeping that in mind it should be saying employee object instead of saying worker object.
Screenshots

Thank you @AnonSar and @sidemt - fixed! It'll render after the next site build.


RSS is missing an icon

The RSS link at the bottom of the page is missing an icon, here's a freely licensed, transparent one, that could be used to fix this:

Hey @marek-lach, would you be able to provide a link to your website? The icon shows up fine on the demo site.

Hey @marek-lach, would you be able to provide a link to your website? The icon shows up fine on the demo site.

Oh, strangely, just this one icon was blocked by my add blocker, while the others showed fine.


Have Natalie be smart about targets in xcodeproj

One feature request I'd like is for Natalie to allow an xcodeproj file as argument, parse it to find out which storyboards are included in which targets and generate a Storyboards.swift for each target. Like that, if the project has storyboards in an app target and in an extension target, Natalie will generate a separate file to include in each target that only makes the targets storyboards visible. It will also solve name collisions when targets have storyboards with the same name.
As a side note, I'm currently implementing this by wrapping Natalie around a ruby script which parses an xcodeproj file with the Xcodeproj gem (which came out of the Cocoapods project) and feeds Storyboard files to natalie. Unfortunately, there doesn't seem to be equally good Xcodeproj parsing libs in Swift.

Carthage is doing something like this. It's not impossible to do, as xcode project syntax is not that magic.

Documentation about xcode project format
http://www.monobjc.net/xcode-project-file-format.html : here a list of elements
http://danwright.info/blog/2010/10/xcode-pbxproject-files/
https://github.com/apple/swift-package-manager/tree/master/Sources/Xcodeproj
swift library
https://github.com/phimage/XcodeProjKit/ (mine)
https://github.com/xcodeswift/xcproj
https://github.com/yonaskolb/XcodeGen


Fix csi-snapshotter RBAC yaml version

Caught in this PR:
https://github.com/kubernetes-csi/external-snapshotter/pull/298
Testing this change in this PR:
https://github.com/kubernetes-csi/external-snapshotter/pull/299

/release-note-none

/lgtm
/approve


KAFKA-2170, KAFKA-1194: Fixes for Windows

This branch fixes several Windows specific issues, both in the code and in the tests.  With these changes the whole test suite passes on my Windows machine.  I found the following issues that were relevant in Jira: KAFKA-2170 and KAFKA-1194, but there may be some others.  I also have a branch with these changes done against <IP_ADDRESS> if there's any interest in merging to the 0.8 series.

I ran the failing test on both Mac and Windows with my changes and it does not reproduce.  I also looked at the code of the failing test, and it does not seem like it's related to my changes

Hi, I'd like to see this patch fixing the problem finally.
Looks like @asfbot is a bot and won't tell us any details here, more over that their jenkins doesn't keep whole build history. I cannot check what was wrong with that particular build.
Do you have any details as to what exactly has gone wrong?
Was it test failing or a merge conflict (as is usually the case with those jenkins builds)?

It was a test failure (can't remember exactly which test).  I looked at the failing test and it did not seem related to my changes as far as I could tell, and I could not reproduce the test failure in my environment.

@mpoindexter why not amend this commit (without changing anything) so that a new build is triggered? We will be able see if anything fails in the new build.

ok, @mpoindexter, now who do we need to kill so that fix is merged?

@clumsy Wish I knew!  I really don't know much of anything about Kafka, but KAFKA-1194 is making a few things difficult for me so I figured I'd take a stab at fixing it.

@mpoindexter Try reaching out project members on Apache Kafka's issue tracker, this KAFKA-1194 in particular.

@mpoindexter Sorry this sat for so long without comment. It needs updates to bring it up to date with trunk, but if we get an updated patch I'd be happy to review, test, and merge.

I'm not working on the project that uses Kafka on Windows any more at the moment, so if anyone else wants to run with this my patch might provide a good starting point.  I've pinged some of my old colleagues, I think they are interested in moving this along, and at some point they will probably submit a new PR with an updated patch.  If and when that happens I'll link to it here.

Hi, I have created a new pull request. See #12331


Update rubocop to .49 to fix CVE-2017-8418

update rubocop to fix vuln CVE-2017-8418
https://github.com/bbatsov/rubocop/issues/4336

@bundlerbot r+

@bronzdoc am i meant to do anything else after the rebase? the tests passed now, but the bot didnt do anything.

Thanks @matthewalbani!
@bundlerbot r+


Modify project structure

Description

Related Issues

Checklist

[ ] Is this code covered by new or existing unit tests or integration tests?
[ ] Did you run make unit-testing and make integration-testing successfully?
[ ] Do new classes, functions, methods and parameters all have docstrings?
[ ] Were existing docstrings updated, if necessary?
[ ] Was external documentation updated, if necessary?

Additional Notes or Comments

Great PR !!

Thanks!


Fixed the tests warning on Xcode 8.3

Codecov Report

Merging #116 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage    92.3%   92.28%   -0.02%
==========================================
  Files          53       53
  Lines        3053     3059       +6
==========================================
+ Hits         2818     2823       +5
- Misses        235      236       +1

Impacted Files
Coverage Δ

LayoutKitTests/LabelLayoutTests.swift
99.4% <75%> (-0.6%)
:arrow_down:

LayoutKitTests/ButtonLayoutTests.swift
85% <75%> (-0.72%)
:arrow_down:

LayoutKit/Views/ReloadableViewUpdateManager.swift
92.64% <0%> (+1.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278d1c2...d0ffff4. Read the comment docs.

can you include text or screenshot of the warnings you are fixing?


feat: add GetCallee to kitexutil to get the service name of callee

What type of PR is this?
feat

Check the PR title.

[ ] This PR title match the format: <type>(optional scope): <description>
[ ] The description of this PR title is user-oriented and clear enough for others to understand.
[ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.
zh: feat: kitexutil 添加 GetCallee 方法以获取对端服务名
(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):
(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Try to add a comments //lint:ignore SA1019 we will remove this later above svcInfo := generic.ServiceInfo(serviceinfo.Thrift)


feat(builder): use find-cache-dir to support customizing cache directory location

Add support for customizing the cache directory using the CACHE_DIR environment variable via https://www.npmjs.com/package/find-cache-dir.
Resolves: https://github.com/rspack-contrib/storybook-rsbuild/issues/197

Thank you!

Thank you. General LGTM, I'm wondering do we need to document this out, and I found it's also not documented in Storybook's site.

Thank you. Generally LGTM, I'm wondering do we need to document this out, but I found it's also not documented in Storybook's site.

@fi3ework Thank you for checking this so quickly; let me know if there are any further changes you'd like to see for the contribution. I couldn't find the cache dir env variable documented on the main Storybook configuration either besides the Github issues and the Vite builder source code such as here: https://github.com/storybookjs/storybook/blob/abe4c8813017be23b96b3a4faee11344bd2d6163/code/builders/builder-vite/src/plugins/external-globals-plugin.ts#L55

Thank you. Generally LGTM, I'm wondering do we need to document this out, but I found it's also not documented in Storybook's site.

@fi3ework Thank you for checking this so quickly; let me know if there are any further changes you'd like to see for the contribution. I couldn't find the cache dir env variable documented on the main Storybook configuration either besides the Github issues and the Vite builder source code such as here<EMAIL_ADDRESS>
Since the solution could be found in Storybook, I think we don't need to add documentation for now.


HDDS-11442. Add dashboard for memory consumption metrics

What changes were proposed in this pull request?
Added Ozone - Memory Consumption Metrics.json to measure memory consumption for the services: OM, SCM, DN and Recon. The following metrics are tracked:

Heap usage
Non-heap usage
GC stats
Thread stats
JVM load

Also, the dashboard includes these metrics for Ozone:

The number of keys
The key creation rate

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11442
How was this patch tested?
Deployed locally.

@tanvipenumudy @kerneltime Hi, I merged some changes based on the comments and would like you to review it. Thank you for your time!

/pending review comments

Re-opened this one after discussing with @len548 about continuing this effort.

Thank you for reviews, @kerneltime and @tanvipenumudy although it was a long time ago. I addressed all the comments so can you review again please?


Modified file list showing items from .gitignore

I've noticed that this plugin generally processes .gitignore correctly.  However, it seems to be showing ignored files in a project with a .gitignore containing:
*/node_modules/*

It seems to work correctly with "node_modules" or "node_modules/", but not with "/node_modules" or "/node_modules/".  Unfortunately, the hundreds of files in nodemodules makes atom run incredibly slowly when I'm working on that particular code base.

Hi @MattFlower this plugin uses components from Atom core to fetch repositories data and find out modified files. This looks more like a bug on Atom core libraries than this plugin alone. I will if I can pass the issue down to the Atom developers.


Validation Error message in FIM portal

When we don't specify required filed value it shows a generic validation error message in FIM "The required field cannot be empty".
Is there any way to customize this error message.
Here I am talking about validation error message not about hint or description.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1584e6a9-c3cc-d7b7-2703-53e43814b5da
Version Independent ID: ee693503-56e7-1ce2-648e-385be0eabb4e
Content: Resource control display configuration XML reference
Content Source: MIMDocs/reference/rcd-configuration-xml-reference.md
Product: microsoft-identity-manager
GitHub Login: @billmath
Microsoft Alias: billmath

Closed


Build failure under Rust 0.11.0

   Compiling etcd v0.5.4
/home/kallisti5/.cargo/registry/src/github.com-1ecc6299db9ec823/etcd-0.5.4/build.rs:27:37: 27:50 error: mismatched types [E0308]
/home/kallisti5/.cargo/registry/src/github.com-1ecc6299db9ec823/etcd-0.5.4/build.rs:27             serde_codegen::register(&mut registry);
                                                                                ^~~~~~~~~~~~~
/home/kallisti5/.cargo/registry/src/github.com-1ecc6299db9ec823/etcd-0.5.4/build.rs:27:37: 27:50 help: run `rustc --explain E0308` to see a detailed explanation
/home/kallisti5/.cargo/registry/src/github.com-1ecc6299db9ec823/etcd-0.5.4/build.rs:27:37: 27:50 note: expected type `&mut syntex::Registry`
/home/kallisti5/.cargo/registry/src/github.com-1ecc6299db9ec823/etcd-0.5.4/build.rs:27:37: 27:50 note:    found type `&mut inner::syntex::Registry`
error: aborting due to previous error
error: Could not compile `etcd`.

To learn more, run the command again with --verbose.

oh... looks like a fix was already pulled.  Any chance of another release?

This Cargo.toml line is a temporary workaround:
etcd = { git = "https://github.com/jimmycuadra/rust-etcd.git", branch = "master" }

Just released v0.5.5.


fix: Update Insight search to exclude non-matching documents

Previously, Insights could be included in the results due to a filter match like itemType: insight, even if they didn't match any search terms.  This resulted in a score of 0.0, but these documents would still appear in the search page.
This change adds the minimum_should_match field to the SearchMatch and SearchPhrase terms.  It will ensure that matching documents match at least one of the should clauses.  Searches without any should clauses (e.g. #tag) won't be affected.

:tada: This PR is included in version 3.3.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Download for EPL is corrupted

Downloaded via CKAN (http://taniwha.org/~bill/ExtraplanetaryLaunchpads_v6.99.3.zip):

Downloaded via web browser (http://taniwha.org/~bill/ExtraplanetaryLaunchpads_v6.99.3.zip):

Quick fix:
Change extra planetary launchpads to use github (https://github.com/taniwha/Extraplanetary-Launchpads/releases/tag/v6.99.3), where I have no issues with corruption upon unzipping
Feature fix:
Change CKAN to automatically skip files corrupted files

This should be reported to the mod author, whose server has been distributing corrupted ZIPs for a while now (maybe a failing disk?):

https://github.com/taniwha/Extraplanetary-Launchpads/issues

The GitHub releases are not usable because the source archive does not contain the plugin. You can unzip them, but the mod won't work.

Thanks, I did not realize the "release" contained no plugin. To be fair, CKAN could skip corrupted files like windows does but this is a distribution issue

Skipping corrupted files would be installing the mod incorrectly. Mod authors tend not to like it if CKAN installs their mods incorrectly, so we go to great lengths to avoid that.

That makes sense but does that mean via direct download would be incorrect then? It seems like there is no way to get the mod now. Anyways, thanks

I don't know what you mean by "via direct download would be incorrect", so I can't answer that.
Yes, it's quite problematic that this author's mods are unreliably available. We're not able to solve that, though.

The server problems have been reported to the mod author here:

taniwha/Extraplanetary-Launchpads#202
taniwha/Extraplanetary-Launchpads#205

No response so far. If @taniwha isn't active anymore, maybe we should freeze these mods and redirect their downloads to archive.org.

Bad sector on firewall noted about 8 months ago:
https://forum.kerbalspaceprogram.com/topic/54284-112-extraplanetary-launchpads-v6993/?do=findComment&comment=4201640


SVG as blog logo made button disappear in Admin Control Panel

Hello, I set a .svg file as blog logo, it worked but after this the button to change the logo disappeared from Administration cp.

Hi @kassius, welcome to Ghost! :smiley:
We've had this issue before, in #4959. The consensus was that a malformed SVG is the cause, but a fix was implemented to handle this.
It's be great if you could update this issue with the version of Ghost you're running and a few other details, that way we have a bit more information we need. There's a handy template in the contributing guidelines.

Hi @kassius please can you confirm which version of Ghost you were using, and if possible provide the file or try validating it to ensure it is well formed?
Without more info, it's not possible to reproduce this so I'm going to close it for now. Will reopen when more info is provided. Thanks :+1:


embedded/lpc55: Use external flash in USB mode

This patch changes the external storage for the lpc55 SoC in the embedded runner to the external flash unless the device is in passive NFC mode.  In this case, 1024 bytes of RAM are used to simulate the external flash.
TODO:

[x] investigate RamStorage formatting
[x] investigate RamStorage size
[x] investigate RamStorage bounds
[x] ensure NFC is configured

Updated:

Rebased onto main.
Changed RAM storage size to 256 bytes.
Changed lpc55 storage initialization to ignore NoSpace errors caused by the simulated EFS.

Initialization tested via USB in normal and provisioner mode and via NFC in normal mode.  No write tests to the external flash yet.  Should be tested with a vanilla device to make sure that NFC is initialized correctly by the provisioner.


wip acme-dns

Codecov Report

Merging #121 into master will decrease coverage by 1.63%.
The diff coverage is 5.43%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   31.37%   29.74%   -1.64%
==========================================
  Files          78       81       +3
  Lines        8628     9176     +548
==========================================
+ Hits         2707     2729      +22
- Misses       5556     6073     +517
- Partials      365      374       +9

Impacted Files
Coverage Δ

api/resources/acmeserver.go
0.00% <0.00%> (ø)

api/resources/common.go
1.29% <ø> (ø)

api/resources/https_cert.go
2.55% <0.00%> (-0.11%)
:arrow_down:

controller/controllers/acmeserver_controller.go
0.00% <0.00%> (ø)

...ntroller/controllers/httpscertissuer_controller.go
26.64% <0.00%> (-8.50%)
:arrow_down:

controller/controllers/kalm_ns_controller.go
76.10% <ø> (-1.77%)
:arrow_down:

api/handler/acmeserver.go
56.52% <56.52%> (ø)

controller/controllers/httpscert_controller.go
69.27% <58.33%> (-2.26%)
:arrow_down:

api/handler/handler.go
93.02% <100.00%> (+0.25%)
:arrow_up:

controller/controllers/gateway_controller.go
73.91% <0.00%> (-3.48%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1b2c3...0f6fd51. Read the comment docs.

@mingmin-101 please merge to develop branch.

merged in https://github.com/kalmhq/kalm/pull/159


chore(at_commons): wrap all vars in at_constants.dart

- What I did

Wrapped the variables in src/at_constants.dart in the class called AtConstants
Created deprecated variables in src/at_constants which point to the values in AtConstants

- How I did it
- How to verify it
- Description for the changelog
chore(at_commons): wrap all vars in at_constants.dart

@murali-shris I separated them into at_constants.dart and at_constants_legacy.dart
I used a part/part of declaration so that only at_constants_legacy.dart has the header:
// ignore_for_file: constant_identifier_names


[BUG] Pipeline stream unexpectly being closed when using extract

What / Why

When you attempt to extract a tarball through streams sometimes it will be closed with an error: [ERR_STREAM_PREMATURE_CLOSE]: Premature close, although the files are successfully extracted. No Errors Codes are shown in the process.
It seems to happen only on newer versions of Node > v18
Looking at the spec it seems now that streams that emit a close event before a end event trigger this error, so worth taking a look on that.
When

n/a

Where

n/a

How
Current Behavior

It throws an ERR_STREAM_PREMATURE_CLOSE Error when trying to extract

Steps to Reproduce

$ nvm install 18.7.0
$ npm install tar got
$ mkdir output

import stream from 'node:stream';
import { promisify } from 'util';
import tar from 'tar';
import got from 'got';

const pipeline = promisify(stream.pipeline);

pipeline(
  got.stream('https://codeload.github.com/npm/node-tar/tar.gz/main'),
  tar.extract({ cwd: './output' }, ['node-tar-main/lib'])
)

Expected Behavior

It should extract the content of the archive without any issues

References

Related to Next.js Issue #39321

does this mean instead of
https://github.com/npm/node-tar/blob/9d71c5673683d6309c75e6a85e78fa285dbe9a2d/lib/parse.js#L85-L94
you would do
    this.on('end', () => setTimeout(() => this.emit('close')))

    if (opt.ondone) {
      this.on(DONE, opt.ondone)
    } else {
      this.on(DONE, _ => {
        this.emit('prefinish')
        this.emit('finish')
        this.emit('end')
      })
    }

essentially? @jeferson-sb @lukekarrys

@webark yeah looks like it is related to that one line

meant to say "odd" addition. I was going to try to add a test case.

I tried adding this test
t.test('ensure an open stream is not prematuraly closed', t => {
  const file = path.resolve(tars, 'body-byte-counts.tar')
  const dir = path.resolve(extractdir, 'basic-with-stream')

  t.beforeEach(async () => {
    await rimraf(dir)
    await mkdirp(dir)
  })

  const check = async t => {
    t.equal(fs.lstatSync(path.resolve(dir, '1024-bytes.txt')).size, 1024)
    await rimraf(dir)
    t.end()
  }

  t.test('async promisey', t => {
    return pipeline(
      fs.createReadStream(file),
      x({ cwd: dir }, ['1024-bytes.txt'])
    ).then(_ => check(t))
  })

  t.end()
})

But it is still passing without any modifications to the code 🤔😔 Any ideas?


Update OWNERS

Add jan--f as reviewer/approver
Signed-off-by: Jan Fajerski<EMAIL_ADDRESS>

/lgtm
Love to see that!


feat: Support MacOS MPS/CPU

https://github.com/EmbarkStudios/pdm-plugin-torch/blob/main/pdm-plugin-torch/pdm_plugin_torch/config.py#L43C30-L43C30

There is no way to download the wheel package for MacOS currently, or we can just download it directly from pypi?

Hey!
I'd love a better solution. Before the recent release; we'd actually not use a tag at all for CPU. But that lead to bad behavior in other cases, where we'd end up with GPU-compatible binaries from pypi when it failed to find a suitable CPU variant. So I opted for being more literal, but now Mac is broken (again).
A PR to improve this would be very welcome. I'm wondering whether one could simply use markers to say ...+cpu; os != darwin and ...; os = darwin -- in the CPU case.


Tablet Class

Precursor tablets are also their own class of item, and not working with the basetype thing.... Same as before just thrown another rule copying the style etc of the existing one

Thanks!


Image Layouts

@joe-loco I particularly like having a good image grid primitive :)

Love it, look at it! 😻

I guess another thing we want to support is having the images being the same wider width as the code cells? Not sure if we want to support this in addition to or as a replacement for the content width.


Fix race condition when setting MaxRetries on provisioning controller.

What type of PR is this?
/kind bug

What this PR does / why we need it:
To fix race condition when setting MaxRetries on provisioning controller.
Which issue(s) this PR fixes:

Fixes #2470
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/test pull-kueue-test-multikueue-e2e-main

/retest

@mbobrovskyi could you rebase this PR?

/retest

@alculquicondor @tenzen-y

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/46 nodes are available: 3 node(s) had untolerated taint {node-group: stable}, 43 Insufficient cpu. preemption: 0/46 nodes are available: 3 Preemption is not helpful for scheduling, 43 No preemption victims found for incoming pod..)

Is it possible some how to increase limitation?

/retest

/retest

Is it possible some how to increase limitation?

No, that's the k8s-infra cluster. The only thing we can do is reduce the size of our test pod, but we usually need all those resources to avoid timeouts.


Implement mono-repo

This project has a mock-api implementation in the lib folder. This needs to be moved to a separate folder.

[ ] break out API server into its own project
[ ] handle environment variables across projects
[ ] share dependencies
[ ] manage versions so a compatible version of each project is always used together

turborepo setup https://www.youtube.com/watch?v=YQLw5kJ1yrQ


added itsmurphy-html portfolio

added itsmurphy.html file inside html folder

Good work. I am merging your PR.
Do give us a star by hitting the star button of this repo!


[k3s upgrade] K3s upgrade stuck when one of the control plane nodes is powered down.

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Scenario 1:

Import a k3s cluster (2 control plane and 2 worker) - version v1.16.3
Power down 1 control plane, wait for it to become unavailable.
Upgrade to v1.16.7 with server/worker concurrency 1

Result:

Upgrade started with a latency of around 10 mins on the control plane node which was active.
Upgrade stuck.

Scenario 2:

Import a k3s cluster (2 control plane and 2 worker) - version v1.16.3
Power down 1 control plane, wait for it to become unavailable.
4 Upgrade to v1.16.7 with server/worker concurrency 1
When upgrade is stuck on powered down node, edit the cluster and change the server concurrency to 2

Result:

Upgrade started on the control plane node which was unavailable initially.
After editing the server concurrency to 2, upgrade started on the control plane node which was active.
Upgrade stuck for both nodes.

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-2431-head- a1bb0a3e9
Installation option (single install/HA): Single

I moved the issue to rancher/k3s as it's in our wheelhouse.

Scenario 1:

Neither of the given options worked. After deleting the node, the other Control Plane node began upgrading but became stuck after it was Cordoned. It is showing Kubelet stopped posting node status. and will not progress.
Editing cluster to have different Control Plane Concurrency values did not fix this.

Multi-mast upgrade does not work consistently. Sometimes it happens that once the original leader goes down nothing will ever come back up. The reason for secondary masters to fail to start-up had to do with embedded dqlite which should no longer be in use. This scenario should be re-tested using embedded etcd.

Scenario 2:

Deleting the node from the cluster worked and the rest of the nodes upgraded successfully afterwards.
Powering on the node did not work.

Powering on the node did not work in either scenario.

How long did you wait? Failing jobs can and will fail and be recreated on a 15-30 minute window, depending on failure mode.

I don't remember exactly how long I waited, but it was probably less than 30 minutes I can retry scenario 2 and wait longer to ensure the information is accurate.
As for re-testing with embedded etcd, we will either need a couple of stable rc's created so that we have something to upgrade to, or wait for another release cycle to do that as it is currently only available in our unreleased v1.19 branch.


Don't use socket.getfqdn

It's deadly slow and makes importing luigi...painful.
Before
$ time python -c 'import luigi'

real	0m5.172s
user	0m0.080s
sys	0m0.075s

After
$ time python -c 'import luigi'

real	0m0.172s
user	0m0.092s
sys	0m0.078s

This is on an OSX machine, which by default doesn't associate the local hostname with it's own ip in /etc/hosts.
I haven't heard anybody ever actually needing getfqdn (most times they just want the output of hostname). However if you do depend on it, let me know, and I'll just make this lazily-evaluated.

Nice!
One of these commits that suggest that commit message length and commit size is negatively correlated :) http://erikbern.com/2015/02/26/the-relationship-between-commit-size-and-commit-message-size/

Wow, nice! There's no documentation around why it's using getfqdn in the code, so I assume it's arbitrary.


Readme includes instructions for building/running w/ Grunt, but project appears to use webpack

I believe the documentation is outdated. There does not appear to be a bower.json and grunt does not appear to be included as a local dependency. However, webpack appears as a dependency, and there are a number of NPM scripts.

Whoops, guess I forgot to update that... Thanks for letting me know!


Queue destroying on stopping

Destroying the queue on stop or finish happens either when the items in the queue itself becomes 0, or after a timeout. But originally I thought that queue destroying occurs when the queue becomes empty and all workers have finished their work. So the queue is destroyed before the worker with the last element finishes its job. This may be only my problem, but if this is the expected behavior, it would be nice to clarify it in the documentation, as there are a number of cases where we want to expect not only the queue to be empty, but all its workers to complete. E. g.:
local copas = require("copas")

local function main()
    local queue = copas.queue.new()

    for i = 1, 3 do
        queue:push(i)
    end

    queue:add_worker(function (number)
        copas.pause(2)
        print("Queue handler #" .. number .. " done")
    end)
    queue:finish()
    print("Exit from parent thread")
end

copas.addthread(main)
copas()

Result is:
> luajit queue_test.lua
Queue handler #1 done
Queue handler #2 done
Exit from parent thread
Queue handler #3 done

I use the following code to guarantee the behavior when the queue ends with all the workers:
local copas = require("copas")

local function main()
    local queue = copas.queue.new()
    local tasks = 0

    for i = 1, 3 do
        tasks = tasks + 1
        queue:push(i)
    end

    queue:add_worker(function (number)
        copas.pause(2)
        print("Queue handler #" .. number .. " done")
        tasks = tasks - 1
    end)
    queue:finish()

    while tasks > 0 do
        print("Waiting for the handlers to complete...")
        copas.pause(1)
    end
    print("Exit from parent thread")
end

copas.addthread(main)
copas()

Result is:
Queue handler #1 done
Queue handler #2 done
Waiting for the handlers to complete...
Waiting for the handlers to complete...
Queue handler #3 done
Exit from parent thread

I also tried to use queue:get_workers() to check which workers were still working, but that produced the same result as the first one.  But maybe you have a better solution. Thanks.

That's an interesting case. This should do the trick;
queue:finish()
while #queue:get_workers() > 0 do copas.pause(0.1) end

But I think your expectations make sense. finish shouldn't return until the work is done.
Internally it now create a lock used as a timeout. We can probably update that to be a semaphore to which each exiting worker releases a resource until all done. That would prevent having to do the above loop with a sleep-call.
But it would also require the worker to be running protected (which it currently doesn't), since if it errors out, the semaphore will never be released. Though that will trigger the timeout again 🤔 , so should be ok.

That's an interesting case. This should do the trick;
queue:finish()
while #queue:get_workers() > 0 do copas.pause(0.1) end

But I think your expectations make sense. finish shouldn't return until the work is done.
Internally it now create a lock used as a timeout. We can probably update that to be a semaphore to which each exiting worker releases a resource until all done. That would prevent having to do the above loop with a sleep-call.
But it would also require the worker to be running protected (which it currently doesn't), since if it errors out, the semaphore will never be released. Though that will trigger the timeout again 🤔 , so should be ok.

Thanks for reply. Yes, I was thinking about using get_workers(), unfortunately that doesn't work. For it's not possible to get the number of active workers after destroying the queue, since queue object redefines its metatable to { __index = destroyed_func } after destroying it and get_workers() will always return nil+"destroyed" after finish.
https://github.com/lunarmodules/copas/blob/master/src/copas/queue.lua#L120-L129C4

yep, you're right. So this needs a fix then.

#168 should fix this. Can you give it a spin @ventureoo ?

#168 should fix this. Can you give it a spin @ventureoo ?

Yes, indeed, that fixes my issue. Thanks.


Failed to get token

abbot
TypeError: Cannot read property '1' of null
    at getToken (C:\Users\Namit Piriya\Desktop\jstest\node_modules\duckduckgo-images-api\src\utils.js:20:49)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Object.image_search (C:\Users\Namit Piriya\Desktop\jstest\node_modules\duckduckgo-images-api\src\api.js:19:21)
Failed to get token
[]

when trying to search for abbot I got this error

Same issue here. Did you manage to resolve it?

Hi, i wanted to contribute then I seen this post. I runned the exemple/exemple.js code to see if there's an error but i didn't find yours. As I can see it could come from src/utils.js line 20. this is a regex which return null if there's no match. if there's one it return the token.
I suppose this error:

TypeError: Cannot read property '1' of null

come because it didn't find or recognize the token. I don't know what you're searching with it but with "naruto" it work fine.
I hope I will help..

I tried with the exemple/exemple.js, i changed "naruto" by "abbot", i seem to work.

Same here.


Integration with Redux Devtools?

Are there any examples of integrating Redux Devtools with this? Any reason why it shouldn't work?  I seem to be having some troubles getting it to work but admittedly that may have more to do with my lack of knowledge around the inner-workings of this library and/or Redux.

Seems reinspect might be the best way to use Redux Dev Tools (browser extension) with useReducer. Something has to make it work when you can effectively have multiple "stores" with several useReducers and no redux.combineReducers.
But then, am I missing something or the API of reinspect.useReducer is basically incompatible with useEnhancedReducer?  Neither one seems pluggable to let you supply an optional "underlying useReducer" instead of React.useReducer


Ignore body_might_complete_normally_catch_error violations

Ignore body_might_complete_normally_catch_error violations
Related to https://github.com/flutter/flutter/issues/105750
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@srawlins are you still planning to land this one? You will probably have to check go/flutter-rob about the pending Google testing check.

I sure am. I've just punched up a master merge.


Play button doesn't enter play state when clicking on thumbnail to start.

Frank said they fixed this


Investigate CPM warnings for dirty cache on the windows-latest runner

For some reason in the CI, the configure complains that the CPM cache is dirty. It doesn't seem that it's actually dirty, though. We need to invetigate this

Lol... I can't type

Will continue once we enable cache in other repos


Add user-managed custom rules feature

Hey there. I've been using this project for a while now and thought it would be great to let users input their own custom rules to changes the heartbeat's language based on the filename. While searching the code, I found something very similar here and thought it would be great to have a way to edit those rules on a per-user basis.
To do this, I added a custom_rule model and services and added endpoints to let the user create/delete them. Then, when an heartbeat is received, the rule is applied in the Augment function.
Heres some screenshot:
I was inspired by this (From wakatime):

In Wakapi :

Let me know what you think. BTW, are there any linter / code format tools I should be using for go? Should I use any of them before opening a PR?

Hi @notarock, thanks a lot for your contribution! I like it, however, I have a few remarks regarding your implementation, which I would like you to take a look at:

[ ] Did you test with MySQL or Postgres? Because it looks like the new tables are not created in case of using one of those. The reason is probably, that you didn't specify to AutoMigrate the new model (see here). There's a (bit ugly) distinction between using SQLite and one of the other two databases. For MySQL and Postgres, table creation and modification is handled by GORM through its auto migration functionality. However, for SQLite, this doesn't work. So in the case of SQLite, database modifications are done using raw SQL scripts in the migrations directory, like the one you provided.
[ ] Please take a look at config/config.go and models/config.go (added in your commit). There seems to be an overlap, but mostly, they're the same. There has been some refactoring to the config recently, so  I assume a merge conflict was not resolved properly here?
[ ] Although your implementation gives more flexibility to individual users, it essentially overrides the old functionality provided by the custom_languages config. Imagine you're hosting a Wakapi instance with several users and have defined custom_languages globally on your server. With your change, they're obsolete, i.e. from the moment the new version is deployed, .vue (for instance) will never be resolved to Vue unless each user adds a custom rule for themselves. I'd like to keep supporting the global custom languages and I see two options. Option 1 is to keep both in parallel, the custom_languages and your new custom rules feature. Both are applied two new heartbeats, while user-defined custom rules take precedence over server-defined rules in case of conflicts. Option 2 is to automatically migrate the "legacy", server-defined rules and add according custom rules for every currently registered user. Afterwards (some time in the future), the the custom_languages can be abolished entirely. This option removes any control about extension-to-language replacements from the server operator. But at least already existing behavior wouldn't be changed from one moment to the other. I like option 1 better, but it's probably also more effort to implement. What do you think?
[ ] Please at a very brief (~ one sentence) explanation in the "Custom Rules" section of the UI about the new feature, as "custom rules" is not necessarily very descriptive by itself and a user wouldn't immediately know that they can specify extension-to-language mapping there.
[ ] Minor: if you want, make the new input fields in the UI the same height (incl. padding) as the other input fields on that page and maybe also align them vertically.
[ ] Few more minor changes, which I'll comment right in the code.

Sorry, among all those change requests I want to emphasize again that I highly appreciate your efforts! I'm glad that there are people who help bringing Wakapi forward :slightly_smiling_face:

Fair enough, I was prepared for code review because I was more focused on making this work than writing clean code at first :eyes: . As for the questions:

I tested this using Postgres with the docker-compose setup. This means that the database was fresh everytime I ran the migrations. I will make sure that the SQLite migrations works when I go over your changes requests, because I'm not too sure if I tested it yet.
Config.go changed while I was developing and I didn't constantly rebase on your master, so its probably just a rebase/merge conflict error...
For the custom_language config, I think I will put back the old Augment function (Maybe rename it to AugmentWithConfigRules), and create a new AugmentWithUserRules that will works based on the user's rules.
True. It's not very user-friendly if there's no way to know what it does.
Will fix
Will fix

I just tested with SQLite and everything works as expected.

I fixed the style, it now looks like this:

LMK if it's missing something

Thanks a lot for respecting those change requests! I'll have a detailed look at it later, but on first sight everything looks great now.

Jfyi: I added this little change in addition, which was required to properly set up tables in existing MySQL / Postres instances. Also, I did a few minor adaptions to the compose file.
Thanks again for your contribution :+1: Hope to see more from you in the future!


Fix TypeError: 'type' object is not subscriptable

Syntax of list[], tuple[] are only supported since python3.9. This change makes this code runnable for python3.8

@ronenlu if you decide to land this, please make sure we add matrix tests for different python versions to make sure this fix doesn't break other users' apps.

@mondwan Thank you for your contribution.
But since python 3.8 is no longer officially supported,  I dont think this fix is necessary.

As py3.8 is marked on pyproject.toml, that's that's why I suppose this is a tool for supporting py3.8.
Any suggested py version for running this tool then?

As py3.8 is marked on pyproject.toml, that's that's why I suppose this is a tool for supporting py3.8.
Any suggested py version for running this tool then?

You can run with latest py: 3.13


theme editor popups after login on the frontend

hello just logged on the checkout page and the theme editor pop ups in the frontend... testing checkout on the new theme...
regards

php7


Updated clean_strain() to return spike model when return_mcmcs is tru…

…e, and removed extraneous lines of code

I'm curious about the return values here---why don't you return the time-domain line model instead of the real and imag freq components?  (Just thinking about Fourier transform conventions---everything input to the cleaner is real, and if everything output from the cleaner is also real, then we don't have to fuss about definitions of FTs, because it's all internal; as well, it's easier to understand the time-domain line model, no?)
Also: why are you just returning the real part of the data frequency series?  Sort of the same question?

Also, also: isn't there an extra s in the return pred_sampless?  Does this code path even work?  :cringe:

Finally, finally (I hope): note that you can extract the frequency components of the line model already from the predicted samples---so maybe it would be better just to store the td line model in the prediction instead of returning separately?


Remove the optimizer_to_device logic if possible

Outline & Motivation
The trainer uses a function optimizer_to_device here:
https://github.com/Lightning-AI/pytorch-lightning/blob/631911c00413ad028e2887d83eb264cb4822097e/src/lightning/pytorch/strategies/strategy.py#L160-L161
In #19955 an issue was raised that the function moved the "step" parameter in the optimizer state to the CUDA device, causing device-to-host syncs during optimizer.step() because the "step" tensor was expected to remain on CPU. #20019 fixed this with special treatment of that key. However, good arguments were made in #19955 that this optimizer_to_device shouldn't even be necessary in the first place (https://github.com/Lightning-AI/pytorch-lightning/issues/19955#issuecomment-2197353178).
Pitch
Remove optimizer_to_device and show that it is redundant by running the tests. We will still need a optimizer_to_cpu for teardown.
Additional context
No response
cc @justusschock @awaelchli @borda

Thanks @awaelchli .
The analysis I have done on the code seems to indicate that we can remove this function (see https://github.com/Lightning-AI/pytorch-lightning/issues/19955#issuecomment-2232309700). The remaining points I think are of note:

This function is also called by Strategy.teardown(). The idea is to transfer the optimizer back from the GPU to the CPU. Maybe we don't really care about this since when the fit is complete either the optimizer will be checkpointed or discarded. The questions is if users really depend on this final transfer behavior but I would guess not.
I created additional tests in https://github.com/Lightning-AI/pytorch-lightning/pull/20062 that I think are helpful in verifying that the function is not needed. I believe that some of these may be helpful in a PR to remove this function.

Also tagging @janeyx99 for visibility.

I am likely not the right person to respond to this q, but my instinct agrees with you and doesn't think moving the optimizer back to CPU needs to be a part of the teardown. I'd defer to others on this though.
I reviewed the part of the tests that move the state_dict back and forth. Left my comments on the PR!


Make favicon transparent

Closes #428

It looks great. New one on the left, old one on the right:


WIP: Add Contributing Guidelines

Resolves #2753
Changes

Added contributing.md, for the benefit of new contributors.
Checklist

[x] Added markup tests, or they don't apply here because... this is just a documentation change
[x] Updated the changelog at CHANGES.md - see above
[x] Added myself to AUTHORS.txt, under Contributors - see above

See https://github.com/highlightjs/highlight.js/pull/2760#discussion_r506686019
Also, I'm not comfortable writing the philosophy section having barely contributed anything 😄. Do you mind taking care of that?
Lastly, I can get to work on the "reporting an issue" section. What kinds of issues are useful, and are there any specific rules?

Also, I'm not comfortable writing the philosophy section having barely contributed anything 😄. Do you mind taking care of that?

Yeah, I was planning to.  Give me the weekend.  I'll try and skeleton in some thoughts on the other stuff as well.

@joshgoebel friendly ping (regarding"build & test" and "philosophy" sections)

@allejo @egor-rogov Any high level thoughts here (or i guess tiny concerns also welcome)?  I'm ok if this is a bit bare-bones initially and we flesh it out over time, but it definitely needs to be "useful" before we merge it.

@allejo @egor-rogov Any high level thoughts here (or i guess tiny concerns also welcome)? I'm ok if this is a bit bare-bones initially and we flesh it out over time, but it definitely needs to be "useful" before we merge it.

This is looking good to me! Just a few minor grammar concerns here and there but I'll hold off of that until this PR is ready to be reviewed.
My only thought right now would be to have the "Setup and Run" section be third instead of last. I personally like trying to figure out if I can build/run a project before I get involved with tackling issues/PRs. But other than that, I think the order and sections included here are good.

My only thought right now would be to have the "Setup and Run" section be third instead of last.

Sounds reasonable.

@joshgoebel Update: I know I've let this pull request snowball :facepalm:. There are a couple of suggestion threads which have grown stale, and I'm not sure whether to wait for a response or to disregard them. The "reporting an issue" section needs some TLC. Beyond that, can you outline for me what's keeping it from being merged?

Let me have another look-see.

Can you work on the small things I just flagged and remove all the "draft" mentions... then I'll got over it myself with one last edit pass and we can merge!


Fixed typos in comments and docs

Some instances of "kmonad" have been left unchanged (capitalization) since they (probably) refer to the executable.

Thanks!


nik4: init at 1.8

Add nik4, a program that can render a map from OpenStreetMap data as an image.
openstreetmap-carto is an OpenStreetMap style. It defines how the map looks.
Also disable the broken python3Packages.python-mapnik test, since I need this dependency. It seems to work fine for this use-case.
I also wrote a NixOS test to show how everything fits together. If you run it (and wait many minutes), you get a nice map in the output.
I may or may not have gone a bit overboard with the openstreetmap-carto package, where I made it not depend on the internet, so it can run in the NixOS VM test. I also regenerate all automatically generated files that I could find and check that we get the same files. I also separated different parts into their own outputs. This way the closure size should be reduced if you don't need certain parts. For example the get-external-data.py script only needs to be run once to import the map into the database and after that, its huge closure (over two gigabytes) is no longer needed (unless you want to update the map).
I chose to use the latest git revision of openstreetmap-carto because it supports the flex layout, unlike the latest release.
@NixOS/geospatial please review.
I think this is a super cool demo.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Also see https://nixcademy.com/posts/nixos-openstreetmap/ and https://github.com/tfc/nixos-openstreetmap, which does something similar.

I plan to create similar NixOS tests for calculating a route between two coordinates and also for full text search in the future.

Great work @Luflosi ! I'll review ASAP.


ReferenceError: window is not defined

as a subject after yarn dev
lib/cjs/strintToReact.js:16:1
lib/cjs/index.js:8:45

@dadmor, thanks for asking. this plugin is not designed for server side rendering, however there is a tricky solution since version 3.0.2 :
function App() {
  const [isMounted, setIsMounted] = useState(false);
  useEffect(() => {
    setIsMounted(true);
  }, []);
  if (isMounted == false) {
    return null;
  } else {
    return (
      <StringToReactComponent>
        {`(props)=>{
           ...
         }`}
      </StringToReactComponent>
    );
  }
}

for older versions, you also need to load the above-mentioned StringToReactComponent component lazily.


Support Gradle Kotlin DSL

Please add support for Gradle Kotlin DSL which is close to a stable release (currently at v0.9.1). Does the plugin use the current Gradle plugin APIs (action based ones)?

The plugin should work fine with Kotlin DSL as far as I know.
Is there something particular you are not able to do?

Both the old and new versions of the Gradle plugin work fine with the Gradle Kotlin DSL. Previously there was the issue of the new plugin not being found but that has since been resolved. Would be an excellent idea to explicitly mention that the plugin works with the Gradle Kotlin DSL in the documentation.


after ssr

After rendering the page, I observe the variable window.__NUXT__= { ... } in HTML code

Is it possible to somehow remove it from HTML?
If it is impossible to comply with paragraph 1, can it be better to apply obfuscation? So that the data is not available in explicit form (for some projects, this is a critical point)

Yea, I've noticed .env get stored there

@lmj0011 There is stored not only .env, but most of the generated data on the server

Hi, we can't remove it from HTML.
This part is used by Vue for the Server Data Fetching


[Storage] Change get_epoch_change_ledger_infos to return first n epoch changes

Motivation
So when the response length exceeds the limit n, it returns the first n results and a flag indicating there is more to follow, instead of returning an error.
The caller still asserts that this flag is false. We are not changing the behavior of the public API yet.
Have you read the Contributing Guidelines on pull requests?
No.
Test Plan
CI.
Related PRs
None.

@bors-libra r=zekun000

:pushpin: Commit 6b52e1f has been approved by zekun000

:hourglass: Testing commit 6b52e1f582d040b8feeacb12f94328ef64bbeedc with merge 7027cc702e1a18394e260dbd80a8c266566d8585...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: zekun000
Pushing 7027cc702e1a18394e260dbd80a8c266566d8585 to master...


fine-tune model with language model head

Hi
I would like to fine-tune esm with a language model head. I tried
import torch
model = torch.hub.load("facebookresearch/esm", "modelWithLMHead", "esm1_t34_670M_UR50S")

but I got
RuntimeError: Cannot find callable modelWithLMHead in hubconf
Is there a simple way to do this? Thanks

Hi @wjs20, you don't need to specify modelWithLMHead. Following our README, simply do:
import torch
model = torch.hub.load("facebookresearch/esm", "esm1_t34_670M_UR50S")

Then, when you call result = model(...) or result = model.forward(), you'll get a dictionary where result['logits'] contains the output from the language modeling head. To fine-tune ESM with a language modeling head, you should setup your loss with respect to that output.

Thanks for making these models available. They are very useful!
I'm also trying to further fine-tune the provided models using masked language modeling for a specific protein family and have just a few questions on the training procedure (reopening this because they pertain to your previous answer):

I noticed that <eos> is an available token in the alphabet provided, but calling batch_converter(data) returns tokens with only <cls> and <pad>. Should the <eos> token be added to the end before feeding to the model, or was this an unused token for language modeling during initial training?
The accompanying publication states "Our model was pre-trained using a context size of 1024 tokens". Should <pad> tokens be appended to sequences that would otherwise be shorter than 1024 tokens? The batch_converter only adds padding tokens up to the length of the longest sequence in the batch.
Based on the output, I believe this is the case, but just to confirm: Are the outputs given by results["logits"] unnormalized scores? In other words, can they be passed directly into an instance of torch.nn.CrossEntropyLoss() without further modification?

Hi @brucejwittmann, thanks for the great questions!

We did not use the <eos> token during pretraining for the ESM-1 models.
No, you don't need to append <pad> tokens. The batch_converter only adds these tokens so that sequences of different length can be included in the same batch. When we pre-train the models, the loss function ignores any <pad> positions. This means that we get the same loss for any arbitrary number of <pad> tokens. For sequences longer than 1023 tokens, we used a random crop of 1023 tokens and then pre-pended a <cls> token, for a total of 1024 tokens.
Yes! They are unnormalized logits that can be passed to torch.nn.CrossEntropyLoss(). Just make sure to ignore pad tokens with ignore_index so that they don't contribute to the loss.

Hi @joshim5 , thanks for your quick and helpful response! Just to clarify on the use of ignore_index: My understanding from your paper is that loss was calculated for predictions made for masked tokens only. Does this mean that <pad> tokens were sometimes the ones that were masked? I was planning to design my masking function such that it never masks a padding token (in other words, it knows the length of each given protein and just masks amino acid tokens). If I were to do that, my understanding is that ignore_index wouldn't be needed as <pad> could never be a target. I suppose I have a few follow-up questions, then:

Was loss calculated against more than the masked tokens in your original work?
Were <pad> tokens masked in the original work? If so, is this because there is a downside to restricting padding to amino-acid tokens only?

Thanks again!

Hi @brucejwittmann, to quickly answer your questions:

No, not for pretraining
No
You asked about <pad> tokens in the batch_converter, so I brought up ignore_index as a warning just in case you implement it in a way where masks could be introduced on <pad> tokens. However, the design plan you just described sounds great and ignore_index won't be needed in that case.


[Bug]: Available Balance incorrect on foundation address

Issue description
The available balance shown at the foundation's address from the supply increase is incorrect.
https://explorer.iota.org/mainnet/addr/iota1qp8h9augeh6tk3uvlxqfapuwv93atv63eqkpru029p6sgvr49eufyz7katr?tab=Transactions
Expected behaviour
It should show the available balance stemming from the outputs which are available (not timelocked anymore)
Actual behaviour
It shows 715302.14 IOTA being available even though there are at least 4 outputs which are no longer time locked and are not yet spent amounting to a total >11266259.4 IOTAs.
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue
No response
Errors
No response
Duplicate declaration

[X] I have searched the issues tracker for this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@panteleymonchuk the problem seems to be on the chronicle endpoint, sigLockedBalance is not "available balance" but rather something like is_trivial_unlock which is not very useful, we are discussing with the chronicle team to decide on a solution

Blocked by https://github.com/iotaledger/inx-chronicle/issues/1312


Add no-index meta tag to alpha/sponship page

Context
To avoid the test page being indexed we should add a no-index flag.
This can be done by adding the meta tag to the page: <meta name="robots" content="noindex">
Current Behavior
Indexed as a normal page.
Screenshot
The page can be seen here: https://www.codu.co/alpha/sponsorship

Would love to have a go of this issue :)

Absolutely!


Idk - error popped up

Which OS are you using?
MacOS
Expected Behaviour
Idk error popped up
Actual Behaviour
...
I also see the following error:
[2023-03-08 09:59:48] |   ERROR   |         Git        | fatal: Unable to create '/Users/lbniese/Library/Application Support/Code/User/globalStorage/sumneko.lua/addonManager/.git/index.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

Reproduction steps

Go to '...'
Click '...'
See error '...'

Additional Notes
No response
Log
No response

Hello, did you have multiple VS Code windows open?

Yeah, I did.

I am unable to replicate this, at least not on Windows. I have two addon managers open in two different workspaces, and they are both able to enable/disable addons with no issues. Has this issue persisted?


How to reset the configuration for its default values in nlog.config

Hi Guys,
I have the following scenario:
I am logging with the configuration automatically loaded from the config file. At runtime I change the fileName configuratio. After some time I want to reset the configuration fot its default values from the nlog.config.
How can I do it? In log4net there is a method called reset that does it. I was looking for something similar.

XmlLoggingConfiguration.reload() should do the trick
See http://nlog-project.org/documentation/v3.2.0/html/M_NLog_Config_XmlLoggingConfiguration_Reload.htm

did'nt work. Any other idea?

Can you post the code you tried?

Depending of your situation:
     LogManager.Configuration.Reload();
            //OR
            LogManager.Configuration = new XmlLoggingConfiguration("path to .config");

I will assume your question is answered. If not, feel free to re-open.


Problem in Android Program of 2048(Getting Stuck)

Hi Mr.Cirulli. There's a problem with your android 2048.
If your program would be played on Sony Xperia Z1 C6903 for over ten minutes, the program would get some graphical issues and won't work and you have to press the "restart grid" button over the grid, even though the game could be continued.

Can you send a screenshot?


slicing along non-first axis of an ndarray and element updating

Hi, I wish to compute the batch_dot between one particular position (as rnn node) of one feature map A( batch , channel , i-1, j) (where i and j range at [1, 63] ) and weights W( batch , channel , i, j) (where i and j range at [0, 63]). However, ndarray does not support indexing except first axis slicing.
I found out that there is a function "slice_axis" and successfully located elements that I want (in the previous case, it was batch_dot between a number of 64 by 64 ndarraies dot a number of 64 by 1 ndarraies). However, the output of "slice_axis" does not share the same memory of the input ndarray and thus prevents me updating the rnn node. How should I solve this problem please?

The slice axis indeed copies the content, currently, what we can do was to write the update by concating the data back into the full content and write

@tqchen Hi, Tianqi, Thanks a lot for your answer!
Suppose I want to change [[1,2,3],[4,5,6]] to [[1,2,3],[10,5,6]], am I supposed to do like this:
a = mx.nd.array([[1,2,3],[4,5,6]])
a_line = mx.ndarray.slice_axis(a,axis=0,begin=1,end=2)   //get the second line of a
a_line = a_line.T     //transpose
a_line[0:1] = 10     // change the element value
a_line = a_line.T   //transpose back
a_other_line = mx.ndarray.slice_axis(a,axis=0,begin=0,end=1)   //get other lines
b = mx.ndarray.concatenate([a_other_line,a_line],False)   //concatenate
Are there more succinct solutions please? Thanks!

This is okay when only one matrix is computed. However, when I do it batch-wise, or batch-and-channel wise, the concatenate function does not fit as it requires the dimension of the arrays to be the same only except the first.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Question: Using multiple rest sources

All,
I'm trying to use AOR with multiple rest endpoints
 <Admin title="Admin" dashboard={Dashboard} restClient={jsonServerRestClient('http://localhost:3001')} restClient={jsonServerRestClient('http://localhost:3002')}>

I get
Line 10:  No duplicate props allowed  react/jsx-no-duplicate-props

What is the best way to use multiple rest sources?

You'll have to make a custom restClient for that

Also see #682