Support forward-only reverse dependencies

Issue #1818 was about reverse dependencies and optional dependencies. However, the way they were implemented doesn't support the use case I need them for. Using the example code from that issue:
Task("A");
Task("B").IsDependentOn("A");
Task("C").IsDependentOn("B").IsDependeeOf("D");
Task("D").IsDependeeOf("E");

RunTarget("D");

I would have expected the task traversal
D -> E
or changing the final line to run target C,
A -> B -> C -> D -> E
That is, I personally was expecting a sort of finally block for tasks, where .IsDependeeOf(task) is equivalent to .Finally(() => {RunTask(task);}), just like .IsDependentOn(task) could be approximated by including RunTask(task) in the Does block.
Additionally, pull request #1819 did not add the parameter required to the extension methods IsDependentOn and IsDependeeOf.

@jmeberlein You declared that C is a dependency of D via .IsDependeeOf("D"). That means you require that D cannot run until C runs.
I'm interested what the use case is, why you'd want to cause E to run after D when you say you want to run D. It's like you want the relationship to be switched so that E is actually a dependency of D but runs afterwards.

The actual use case: I'm using Cake to support development across Windows and Linux. It currently has most of the same features as other tools like Visual Studio, but because of how I'm using it, there's no way to say "I only changed this one file, so don't recompile this project's dependencies, only the rest of the chain". It's not vital to have that feature, but it would certainly be nice.
A general case, however, of where post-dependencies could be useful is clean up tasks. Pre-dependencies let multiple tasks share a setup task, but post-dependencies would let them share a common teardown task. In code:
Task("Setup");
Task("Build A").IsDependentOn("Setup").IsPostDependentOn("Teardown");
Task("Build B").IsDependentOn("Setup").IsPostDependentOn("Teardown");
Task("Teardown");

Looking at the source code, I already know how I would implement this. I would color the edges Up or Down, in reference to Hasse diagrams, and write a slightly more complex function to generate build orders. It would first run over the graph after it's constructed with Tarjan's algorithm to check for circular time dependencies (as opposed to include cycles), use a BFS to find all nodes which need included in the output, and finally use a modified DFS to convert that to a total order.
And @patriksvensson, I didn't mean to imply that IsDependeeOf was implemented incorrectly. I understand why it's implemented the way it is. This issue was just inspired by my initial misunderstanding of it.

Changed the name to call them "post-dependencies" instead of "forward-only reverse dependencies", because I realized after opening this that that's a clearer name.


Error installing Barong

docker-compose run --rm barong bash -c "./bin/link_config && ./bin/setup"
ERROR:
Can't find a suitable configuration file in this directory or any
parent. Are you in the right directory?
    Supported filenames: docker-compose.yml, docker-compose.yaml

@elielbeck report this issue in workbench


Update to angular 7

While it appears to be working correctly, the version compatibility should be updated.

Push - would like to see this too!

package.json is updated already. @phenomnomnominal @mattlewis92 Can you publish updated version to npm? Or there is some work in progress that you want to complete before?


MacPilot 16.0

MacPilot gives you the power of UNIX and the simplicity of Macintosh, which means a phenomenal amount of untapped power in your hands! Use MacPilot to unlock over 1,200 features, and access them all with the easy and familiar Macintosh user interface. No command line tools or complicated file operations!


Get a stable link for FAIR assessment doc v0.1

Hi, @oyadenizbeyan @madhavij
I am working on providing links to the FAIRplus indicators v0.1. I want to give people links to the FAIR indicator v0.1 and FAIR assessment documents.
However, currently, even if there is a formal release, I don't know where to find the version 0.1 specific links.
Also, the current spreadsheet is provided in xlsx format, which makes it difficult for sharing with external reviewers. Something that can be directly displayed without downloading would be better?
Could you please help me out?
thanks a lot!

Got the link. https://github.com/FAIRplus/CMM/tree/v0.1


how to use styled-jsx for theming?

Just adding this issue as a way to discuss what's the best way to do theming with styled-jsx.  Particularly styling a component with multiple variations
eg.

red button
blue large button
green xxl button

I believe pr #61 will open a lot of techniques in this domain.

For static variations i.e. defined upfront without dynamic properties one can do className toggling.
It gets tricky when values are dynamic e.g. padding for the large variant is not a static value say 40px but a prop defined in its context.
In this case if you are lucky enough you can use css custom properties, otherwise styled-jsx doesn't provide a way to do so and probably it will never do because css is not processed/scoped at runtime.
I would probably use inline styles and props to reproduce the behaviour of css custom properties. So every dynamic / configurable css value would be inlined instead of being defined in styled jsx.
Caveats are:

the specificity of these rules is higher (probably not an issue tho since they are final values)
media queries and states like hover, focus need to be handled with js.

Personally I think that most of the times className toggling and some constants (#61) are all I need and theming is more about multi themes websites which I rarely do.
I think that styled-jsx would benefit from some degree of separation of concerns – if styles are moved outside of the component then one can reuse the component itself instead of doing a lot of overrides in a variant. This could be hard though since transformations right now are static – I have some ideas to solve this issue feel free to ping me on slack if you want to discuss about it.

I don't understand the i18n case? Wouldn't that just toggle a class like rtl based on a property?

@rauchg with inline styles you'd need to flip all the relevant rules. In that case an HOC would do it imho. A decorator would make it even easier.

In that case an HOC would do it imho. A decorator would make it even easier.

Assuming that one passes the ruleset instead of values eg:
{
   marginRight: 10,
   right: 0
}

@rauchg for example:
Say this is your default style:
{
  right: 0,
  color: red;
  background: blue;
}

And say if you switch to locale you want to have this style applied to an element
{
  background: url(...)
}

With all styles removed except that.   How would you do it, assuming you have 18 to 30 different variations of this?

It sounds like you want: className={ i18n ? 'background-class' : 'default-class' } ?
Sorry if I don't exactly follow.
Maybe it would help me if you can give me the concrete product example? Locales and backgrounds don't fully make sense to me either.

hi @rauchg , let's use your example.  so you'll have two classes one for default and one for a different locale.  Now multiply that for say 20 locales you are supporting.  And that's just one single component.  What if you multiply it with a couple of dozen components.  Having a bunch of ternary / class map, kinda hard to manage?

I don't think an app should ship a component with code for 20 locales. The question reveals the solution, in my opinion. That's why I keep wondering about the product reasoning behind this.
The more concrete, the better. I also don't think locales should impact CSS that much, so I don't understand where the 20 is coming from.

@rauchg internalization is just example but since we are discussing it already in our app we have css overrides for images that needs locale.
For example a banner is different on all those 20 locales, so we have code like this
.banner { background... }
.es .banner { background... }
.fr .banner { background... }
.de .banner { background... }

Right now we just add class in the root cointainer and just target it like that.  But since styled-jsx is per component, we would do it like this right?
.banner { background... }
.banner.es { background... }
.banner.fr { background... }
.banner.de { background... }

So going back to the premise you have on the Meta components, should these styles on different locale live on a totally different component?  So instead of one component with 20 style override, I would make 20 components with their style intact?

Personally, I wouldn't want to ship all those URLs to all of my users, specially if you're saying you have many components. You're looking at dozens of kilobytes probably
In this case, I would do:
export default ({ locale }) => (

    Hi

)
const urls = {
  en: '…'
}

or
export default ({ locale }) => (
  <div className={`banner ${locale}`}>
    Hi

)

and CSS like you mentioned. You could set up a global class in the  and use :global(), but I don't think components should depend on global settings.

Also, if you want to have a completely separate stylesheet that you load per-language with global overrides, you can do that. It's just not as ideal as having meta-components.

Love the solution @rauchg , just a question about shipping all those URLs to users,  what's the difference between the map-based solution you have:
const urls = {
  es: '…',
  fr: '...',
  de: '...'
}

vs having the urls in the styled-jsx
.banner.es { background... }
.banner.fr { background... }
.banner.de { background... }

They're both gonna end up in the user's browser anyway (In terms of kilobytes added).  Also browsers just download the image that matches the css selector.  So if even if they have 3 declaration of background image and only one matches that's the only background that's going to be downloaded.

The difference is that if it's just one property, the inline style is probably more convenient to write. But other than that they're pretty equivalent

While styled-components has this nice plugin https://github.com/diegohaz/styled-theme, a similiar feeling approach can be accomplished by what is described in this article, it works nicely with styled-jsx https://medium.com/@mweststrate/how-to-safely-use-react-context-b7e343eff076

In order to support themes we need to implement dynamic styles support :)


Monitor stucks at PENDING

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Today I had an outage on two services that I monitor.
Both services were stuck in the PENDING state and did not go to the DOWN state.
Truth be told, both services are of the PUSH type. Unfortunately (thankfully) I didn't have an outage on another type of monitor, so I can't say if it's just PUSH.

👟 Reproduction steps

Create a push monitor
Visit URL to make push online
Leave the push without activity

👀 Expected behavior
The monitor should go down after 3 failed attempts
😓 Actual Behavior
Monitor remains in pending state
🐻 Uptime-Kuma Version
1.12.1
💻 Operating System and Arch
Debian 11
🌐 Browser
Latest Google Chrome
🐋 Docker Version
20.10.12
🟩 NodeJS Version
No response
📝 Relevant log output
No response

This ticket is closed but related. I have the same issue.
https://github.com/louislam/uptime-kuma/issues/922

@TimothyGillespie I'm not sure if this is exactly the same issue, but ok.

I don't consider this related to Timothy's. I have same issue. Fresh install. Status shows pending for the monitor, rather than up or down. Nothing to do with notifications.

I can confidently say this was fixed with #1627 and #1428.
Back then, the push code looks like this:
                } else if (this.type === "push") {      // Type: Push
                    const time = R.isoDateTime(dayjs.utc().subtract(this.interval, "second"));

                    let heartbeatCount = await R.count("heartbeat", " monitor_id = ? AND time > ? ", [
                        this.id,
                        time
                    ]);

                    debug("heartbeatCount" + heartbeatCount + " " + time);

                    if (heartbeatCount <= 0) {
                        // Fix #922, since previous heartbeat could be inserted by api, it should get from database
                        previousBeat = await Monitor.getPreviousHeartbeat(this.id);

                        throw new Error("No heartbeat in the time window");
                    } else {
                        // No need to insert successful heartbeat for push type, so end here
                        retries = 0;
                        this.heartbeatInterval = setTimeout(beat, beatInterval * 1000);
                        return;
                    }

heartbeatCount only looks for heartbeats since the last regular interval, and doesn't consider retries. The result is that it counted the last PENDING beat, goes to the else branch and retries keep getting reset to 0.

@chakflying you are missing a call to action in your descriptions:
@karelkryda (only you or Louis can close issues 😉)
I believe this issue has been resolved and you can safely close this issue.
The fix for this issue is available after 1.16.1

Alright, I will try to include that and copy your template if you don't mind ;)

You're probably right. I'm not aware of having dealt with anything like this recently. I'm closing this issue.

In latest version (1.23.3) also many of my services were down but Uptime Kuma stayed "Pending" state for 12 hours and did not send out alerts.
Maybe send alerts also out if "Pending" is more than 60 minutes?


Resizing an event to the right creates an additional event in the previous row in the calendar

Check that this is really a bug

[X] I confirm

Reproduction link
https://jquense.github.io/react-big-calendar/examples/index.html?path=/docs/addons-drag-and-drop--example-3
Bug description
The bug is also reproducible on the https://jquense.github.io/react-big-calendar/examples/index.html?path=/docs/addons-drag-and-drop--example-3 storybook.
See attached video for reference. When resizing an event, an additional event instance is added to the previous week, even though I am resizing the event to the right.
I was not able to identify the source of the issue when inspecting the source help. Any advice?
https://user-images.githubusercontent.com/43579417/210632082-f9083670-bf0f-44d1-9757-f028bb2d058b.mov
Expected Behavior
No response
Actual Behavior
No response
react-big-calendar version
1.5.2
React version
16.8.6
Platform/Target and Browser Versions
MacOs Chrome 108.0.5359.124
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

[X] I'm willing to open a PR

having same problem


Great, now how the hell do I do that in java?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 957649d9-8576-a551-716a-e273b9f3dadb
Version Independent ID: af706ddf-6af2-9158-c153-998c6d56cbc5
Content: Tutorial - .NET Web app accesses Microsoft Graph as the user - Azure App Service
Content Source: articles/app-service/scenario-secure-app-access-microsoft-graph-as-user.md
Service: app-service
Sub-service: web-apps
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@bryanidsts,  Thanks for the feedback!
The doc aims to provide flow for .Net and JavaScript apps.
Tutorial: Access Microsoft Graph from a secured .NET app as the user
Tutorial: Access Microsoft Graph from a secured JavaScript app as the user

Based on my initial check and understanding of your scenario, you may take a look similar approach outlined below, for Java:
public class Startup
{
    // This method gets called by the runtime. Use this method to add services to the container.
    public void ConfigureServices(IServiceCollection services)
    {
        services.AddAuthentication(OpenIdConnectDefaults.AuthenticationScheme)
                .AddMicrosoftIdentityWebApp(Configuration.GetSection("AzureAd"))
                    .EnableTokenAcquisitionToCallDownstreamApi()
                        .AddMicrosoftGraph(Configuration.GetSection("Graph"))
                        .AddInMemoryTokenCaches();

        services.AddRazorPages();
    }
}

// Index.cshtml.java

import com.microsoft.graph.models.extensions.IGraphServiceClient;
import com.microsoft.graph.models.extensions.User;
import com.microsoft.graph.requests.extensions.IUserRequestBuilder;
import com.microsoft.graph.requests.extensions.IUserPhotoStreamRequestBuilder;
import com.microsoft.graph.requests.extensions.UserRequestBuilder;
import com.microsoft.graph.requests.extensions.UserPhotoStreamRequestBuilder;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Controller;
import org.springframework.ui.Model;
import org.springframework.web.bind.annotation.RequestMapping;

import java.io.IOException;
import java.io.InputStream;
import java.util.concurrent.ExecutionException;

@Controller
public class IndexController {

    @Autowired
    private IGraphServiceClient graphClient;

    @RequestMapping("/")
    public String index(Model model) throws InterruptedException, ExecutionException, IOException {
        IUserRequestBuilder meRequest = graphClient.me();
        User me = meRequest.buildRequest().get().getBody();
        model.addAttribute("me", me);
        model.addAttribute("name", me.displayName);

        IUserPhotoStreamRequestBuilder photoRequest = graphClient.me().photo();
        InputStream photoStream = photoRequest.buildRequest().get().getBody();
        byte[] photoByte = IOUtils.toByteArray(photoStream);
        model.addAttribute("photo", Base64.getEncoder().encodeToString(photoByte));

        return "index";
    }
}

I'd repro'd and tested for Java sample. Apologies! you may try a similar approach for new version of the library.
Having mentioned that, the doc provides samples for Net and JavaScript apps.
Your feedback has been shared with the content owner ( @rwike77), to consider adding tutorial for Java, in the next successive iterations.
We will close this now, if you have any questions, please let us know.


[docs] Lit 2 and Lit 3 upgrade guides should be visible in both versions

Fixes issue: https://github.com/lit/lit.dev/issues/1170
Context
We want both upgrade guides to be visible regardless of the dropdown selector.
Prior paths:

v2 selected: /releases/upgrade/ is the Lit 2 upgrade guide.
v3 selected: /releases/upgrade/ is the Lit 3 upgrade guide.

These paths are unchanged, but the following have been added.

v2 selected: /releases/upgrade-to-v3/ is the Lit 3 upgrade guide. It contains a pre-release warning.
v3 selected: /releases/upgrade-to-v2/ is the Lit 2 upgrade guide.

versionLinks frontmatter has been updated so that if you switch the version selector then you stay on the correct upgrade guide.
The titles have also been updated from Upgrade Guide to Lit N Upgrade Guide. This doesn't change the url, and is visual only.
Testing
Tested manually and via:

https://pr1178-404c018---lit-dev-5ftespv5na-uc.a.run.app/docs/v2/releases/upgrade/
https://pr1178-404c018---lit-dev-5ftespv5na-uc.a.run.app/docs/v2/releases/upgrade-to-v3/
https://pr1178-404c018---lit-dev-5ftespv5na-uc.a.run.app/docs/v3/releases/upgrade-to-v2/
https://pr1178-404c018---lit-dev-5ftespv5na-uc.a.run.app/docs/v3/releases/upgrade/

Agree. After looking at preview I also think that v2 probably should not have v3 in it yet. Downgrading to draft status right now.
We can decide in the future whether to implement this change, part of this change, or close the change.


Merge with SPA Archetype

We want to merge the AEM SPA Archetype into the regular AEM Project Archetype, because there are many commonalities between the two, and because this should make it easier to keep the two in sync.
We want only one starting point for creating AEM Sites, regardless whether they are SPA/PWA or not. The AEM Project Archetype should be that starting point, but there will obviously be an option about whether a SPA should be generated out of it or not. We should however seek to keep the difference between the two as small as possible.

+1 to this initiative!

+1 to this for sure!


Activity 8.01 TypeError in book.cover.save(cover.name, image_file)

Hi, I'm getting a TypeError when using the exact same code as in the example:
Python: 3.8.7
Request Method: POST
Request URL: http://<IP_ADDRESS>:8000/books/1/media/
Django: 3.2
Excpetion Type: TypeError
Exception Value: expected str, bytes or os.PathLike object, not tuple
In the following statement:
book.cover.save(cover.name, image_file)
(Line 158 from the example)
I tried for a while now and cannot find a solution.

That took a while: I had an error in the settings field in
MEDIA_ROOT = BASE_DIR, 'media'
it should say
MEDIA_ROOT = BASE_DIR / 'media'
as in the media_project before.
There was a tuple :)


Add UNITY_LICENSE_PATH

Good work! and thanks a lot for your pull request. Same comments as for https://github.com/webbertakken/unity-builder/pull/69 apply here.

fixed discrepancy in 31ae95179db4865aac73882a291f543f19c0b945


AnimEncoder API?

Hi there!
I'm wanting to create animated WebP images but it doesn't seem like this exposes AnimEncoder.
AFAICT nothing currently supports encoding to animated WebP from NodeJS so it'd be super cool if that worked.

@aendra-rininsland I think you might could try gif2webp as a workaround.


[snappy] Initial commit for Google Snappy library

Thanks! Nice job noticing vcpkg_from_github() -- we should teach create to select a different template when we detect you're using a GitHub URL or perhaps a dedicated create-github command?
I swapped out the RENAME/REMOVE of SnappyTargets-debug.cmake with a call to vcpkg_fixup_cmake_targets(); this should make it easier in the future.


Sketch: Use a complex key for preset colors

Allows for multiple presets with the same color but different titles.

Great one, thanks!


Meta: open todo or "help wanted" issues

Hey! This is an awesome project :)
At this time, it isn't exactly clear what:

Is done
Is working but needs improvement
Has a design but needs implementation
Needs a design

Would you be able to put some of these things into separate issues with a "help wanted" label where relevant? This would make it easier for contributors to jump in.
Also, could you enable the discussions tab? Not super relevant now, but it's nice to separate problems from questions/comments as the project scales.

Hey!
You're right that those things aren't currently documented. One concern I have, is that if I document all that, it can quickly fall out-of-date, or require quite a bit of work to keep up-to-date. But I guess it's a trade-off and perhaps I'm too far at the end of not documenting any of it - which has worked well while it's been mostly just me working on stuff - but perhaps should change as others start to contribute or want to contribute.
Writing up some issues and tagging them with good-first-issue seems like a good step. It can be tricky to find suitable issues though because they need to be something that doesn't need to be done right away. I've filed one so far, but will add more as I think of them.
But if you or anyone else is keen to try to contribute, I'm always up for discussing the project via a video call (see calendar link from my github to find a time), or if you don't like video calls, ping me on the rust-lang Zulip, send me an email or file issues or discussions (thanks for the suggestion, I've just enabled them). I've just updated the contributing section in the README with this info. I also added a what's-done section.
The big things that aren't yet done, at least those that I'm aware of are listed in the README. e.g. debug info being the next big one.
Currently I'm working on fixing bugs with what's there. Today I'm working on fixing some bugs related to thread-local variables in shared objects. I'm working towards making it possible to link rustc using Wild.

Thanks for the update! Oh yeah totally understood that it's still in the bringup phase, but just having an idea of what you are working on vs. what is lower priority for you personally (so possibly open for somebody else) is awesome. Much apprecaited 👍


Controlled input validation on blur

Describe the bug and the expected behavior
I'm setting up a shadcn select, like this:
https://github.com/juanpmarin/conform-issue-repro/blob/b3324dbcddfa201b4f1165b7aeb95cfd980cf2be/components/buggy-form.tsx#L57-L114
And I'm setting shouldValidate to onBlur, because control.blur is invoked when the select is closed, validation should be triggered and error message should hide, it does not work as expected.
Conform version
v1.2.2
Steps to Reproduce the Bug or Issue

Clone and run this project
Submit the form without selecting a value from the dropdown
An error message will appear
Select a city from the dropdown menu
The error message does not disappear

What browsers are you seeing the problem on?
No response
Screenshots or Videos
No response
Additional context
No response

I did some initial investigation. Below are some notes with my findings.
The useControl hook uses the useInputEvent hook internally, which adds a focusout event listener to manage its internal state for the blur event logic.
https://github.com/edmundhung/conform/blob/cb984945e9cf3a5448bafeef490d8a2dcc845226/packages/conform-react/integrations.ts#L184C1-L207C12
Conform will focus the first invalid field when the form is submitted. Since the native select element is focused on submission, the aforementioned focusout event listener will be triggered after another element gains focus, either programmatically via focus delegation of the custom control or if a user interacts with the page.
https://github.com/edmundhung/conform/blob/cb984945e9cf3a5448bafeef490d8a2dcc845226/docs/api/react/useInputControl.md?plain=1#L65C1-L66C1
As a result, the blur event is not dispatched for the native select when the controls blur method is called after the options menu closes.
https://github.com/edmundhung/conform/blob/cb984945e9cf3a5448bafeef490d8a2dcc845226/packages/conform-react/integrations.ts#L247C1-L264C6
If you add a second select field to the form, the issue is only replicable for the first field since only the first field is focused on submission after being invalidated.


Derivation tree: What happens to subgoals, like in findall/3?

Just noticed new derivation tree feature. What happens to
subgoals, like the goal argument in findall/3. It disappears:

From other testing I see that by derivation tree you understand a
complete derivation tree. So (X=1;X=2) has a complete derivation tree,
but it gets not show by a findall/3 invocation. This might be a design
desicion of the derivation tree visualizer, or maybe an option somewhere?

That's because some subgoals are calculated in separate threads of the session, and the pointers to those nodes are not collected. But the tree shows all the answers:

findall/3 has only one answer. The bagof/3 did run p(X,Y), so I don't see
the p(X,Y) derivation when I run bagof/3? No option to see this?

Not yet. I have to review those predicates to try to get the lost nodes.

Maybe findall/3 and bagof/3 are not high priority. But showing for example more
for (+)/1 could be interesting for teaching and research. What I figured out that
once/1 works. You also show failed sub derivations by the color red, and the cut is
correctly respected:
?- X = b, once((X = a; X = b; X = c)).

But then for example the (+)/1 does not yet showe any sub-derivation. I guess it
has a similar subderivation like the once/1 example, except for a different
overall outcome:

Maybe this way?
?- X = b,  \+ ((X = a; X = b; X = c)).

?- X = b, \+ ((X = a; X = c; X = d)).

Or better implemented with the cut?
not(X) :- call(X), !, false.
not(X).

?- X = b, \+ ((X = a; X = b; X = c)).

?- X = b, \+ ((X = a; X = c; X = d)).

I just fixed sub-derivations for the following predicates:

\+/1
findall/3
bagof/3
setof/3
catch
->;

If you find more predicates, you can reopen this issue. Thanks!
?- findall((X,Y), append(X,Y,[1,2,3]), L).


Added KMP Algorithm for string searching

Hey, maybe some indentation would help

Sure thing!

Hey, it stills badly indented, please check: https://en.wikipedia.org/wiki/Indentation_style


Adds getOriginalBytes function

The proposed function retrieves bytes as they would appear in the original binary.

Regarding the inefficient comment, how about instead returning a ByteProvider? You could use FileBytesProvider and then ByteProviderWrapper to set the boundaries.

To be honest, I copied the "inefficient" comment from the getBytes function that was already there. I think for most applications, I'd really want to get a byte array as the result, but I can look into the provider classes to see if they would be as comfortable to use. I chose the visibility because I was expecting only subclasses of FlatProgramAPI to have access to the flat API and protected seemed like a good choice; I see now that most of the flat API calls are public and I'll change that to match them.

ByteProvider works best when used with a BinaryReader. Having the InputStream available and stuff from ByteProvider allows for efficient writing to files and stuff in java.


Handle constant aliases in the indexer

Currently, the indexer does not properly take aliases into account. I think the best way of storing this is to create an Alias entry type that basically just proxies to the real entry. That way we know it's an alias, but also know what it resolves to.
One concern is how to properly handle if we discover the alias before we discover the aliased constant. For example
# file 1. Gets indexed first
Alias = SomeClass

# file 2. Gets indexed after
class SomeClass
end

For this case, we will not know which constant is proxied by the alias when we discover it. We may need to make the Alias entry just keep the name for which it aliases to and then resolve it once someone tries to access it, when the index is fully built.

Yes, you should, but that's not enough to fully handle aliases.
For example, in the Ruby LSP's own code, we alias RubyLsp::Interface to LanguageServer::Protocol::Interface. This means that when we do this
module RubyLsp
  Interface::Hover
end

We need to be able to resolve Interface::Hover to the correct class, which is LanguageServer::Protocol::Interface::Hover. For simpler cases, where you're just referencing the alias constant directly, there's no need to know what it proxies to. But these more complex cases are currently unhandled.

Ah, makes sense.
Note that constant definitions can be conditional, for example when depending on architecture or or dependencies:
if rand(0..1) # could be for a specific arch or if a dependency is loaded
   X = String
else
   X = Integer
end

Yeah, I'm not sure how well we can handle condition declarations like those. Without a proper typechecker, we'll probably not be able to understand cases that aren't trivial. We might be better off ignoring those if they are inside conditionals.


Sort the available help channels in #how-to-get-help by position

Currently the dynamic message in #how-to-get-help doesn't sort the available help channels, so this PR sorts the channel by position.

Tested, it works well.


Black screen on bleem!

When trying to run bleem! in hardware mode, I only get a black screen. Otherwise, software mode works fine. Albeit, the image is skewed as seen below when it's not in the lower left corner of the screen. This problem also seems to happen with popcap games.
Windows is at lower left:

Window is not at lower left:

Hi, I found some problems with rendering to the window. Please try the new version, it should fix it.

Hi, I found some problems with rendering to the window. Please try the new version, it should fix it.

Hello, it still seems to persist w/ popcap games on both vbox and vmware. I am yet to test lego island


Update benchmark results

Codecov Report

Merging #58 (3f23850) into master (69dcd34) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          511       511
  Branches        98        98
=========================================
  Hits           511       511

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69dcd34...3f23850. Read the comment docs.


actions: promote release action

Re https://github.com/nodejs/build/issues/3838#issuecomment-2394864184

Follow up pr will be made addressing comments


Runtime Support for Strictness and Optional Laziness

Summary
While Luna is currently a lazy language, our performance goals mean that we should instead prefer defaulting to strictness. This task exists to track the discussion around making Luna strict-by-default, and allowing optional laziness annotation.
Value
Making Luna strict-by-default will make it significantly easier to meet our performance goals for the language. However, we don't want to prevent users from taking advantage of Laziness where useful. To this end, it will support laziness annotations to mark certain data and functions as Lazy.
Specification

Hold a discussion regarding the intended strictness of the new runtime.
Discuss how to handle virality of laziness annotations.

Acceptance Criteria & Test Cases

[x] The below thread records the main points of the discussion around building a strict runtime.
[x] These points have been incorporated into the Runtime RFC.

Notes from the Discussion

It is clear that the performance goals for Luna mean that we should execute Luna code as strict-by-default, providing predictable and consistent performance in the average case.
However, when working with small portions of large data, laziness can often save significant computation, and hence be a boon.
To this end, Luna wants to support laziness annotations on values, meaning the runtime needs to support tagging data with laziness metadata.

A Skeleton Design for Runtime Laziness Handling

Every runtime value will be tagged (as part of its metadata blob, along with type, monad, error, etc).
This acts as a key to tell the evaluator how to execute the code in question, and whether code generation needs to generate code for thunks.

Incorporated into the WIP RFC in commit 95184f0.


feat: automatic query param decoding

Fixes #184

Codecov Report
Patch coverage: 61.66% and project coverage change: -3.69 :warning:

Comparison is base (0664462) 85.90% compared to head (6e9b0d7) 82.22%.

:exclamation: Current head 6e9b0d7 differs from pull request most recent head 314d422. Consider uploading reports for the commit 314d422 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
- Coverage    85.90%   82.22%   -3.69%
===========================================
  Files           83       84       +1
  Lines         1518     1665     +147
  Branches       207      234      +27
===========================================
+ Hits          1304     1369      +65
- Misses         214      287      +73
- Partials         0        9       +9

Impacted Files
Coverage Δ

src/faas/v0/handler.ts
100.00% <ø> (ø)

src/faas/v0/context.ts
54.22% <18.98%> (-22.11%)
:arrow_down:

src/faas/v0/start.ts
32.23% <27.58%> (-1.37%)
:arrow_down:

src/resources/api.ts
84.03% <86.11%> (+0.70%)
:arrow_up:

src/resources/bucket.ts
83.33% <94.87%> (+8.97%)
:arrow_up:

src/api/events/v0/events.ts
98.30% <100.00%> (+0.02%)
:arrow_up:

src/api/queues/v0/queues.ts
96.29% <100.00%> (-0.05%)
:arrow_down:

src/api/storage/v0/storage.ts
97.00% <100.00%> (+0.12%)
:arrow_up:

src/resources/queue.ts
78.94% <100.00%> (ø)

src/resources/schedule.ts
100.00% <100.00%> (ø)

... and 2 more

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Generating a PDF from docs/*.md

I've been struggling creating a single VCPKG.PDF from all docs/*.md files with little success.
First trying with Pandoc (latest v2.14.1), but it does not follow and convert internal links like:
  - [FAQ](about/faq.md)

to a sensible link and content. This was my command:
pandoc  --output VCPKG.pdf --pdf-engine xelatex --metadata title="VCPKG documentation" ^
  --table-of-contents --listings --self-contained --reference-links --to=pdf --from=gfm README.md

I assume some Pandoc filter is required for this. But I'm not so into this. Anybody?
Then a tip in https://github.com/microsoft/vcpkg/pull/1111/files hinted on trying:
pwsh docs\regenerate.ps1 -VcpkgRoot . -WarningAction Stop

which did absolutely nothing.
So how should I create a single offline VCPKG.pdf file?

@gvanem, I haven't used pandoc before, I have no idea why it doesn't work here.
I know a simple way to same the .md file to .pdf, however, I'm not sure if it matches your requirements:
Open the .md file with Chrome -> Print -> Destination: Save as PDF -> Save


Gracefully handle missing changelog

I think this is a combination of a bug fix and a slight improvement. Previously, if a change log was missing in the repo, the bot would fail silently. Now it should provide a helpful message.
Also, I don't think the loop that looked for change logs with different names was working properly prior to this update.

Coverage decreased (-0.2%) to 68.153% when pulling fa8c056b2a3a18d1194728f92bcff364fa480da7 on drdavella:missing-changelog into e46245dc6fcb98d3e83bddcadbf4c298676b8156 on astropy:master.

Coverage decreased

Hmm. Add a test? 👻

Coverage increased (+1.8%) to 70.162% when pulling cb61b8f5662aa7a607b74ab01f87a98e5475042a on drdavella:missing-changelog into e46245dc6fcb98d3e83bddcadbf4c298676b8156 on astropy:master.

In addition to this, but maybe work for a separate PR, is handling a change log that does not adhere to the assumed format. For example, when I inserted a change log file with no sections, the bot ignores it. Maybe this is the desired behavior for the bot, but can be confusing for user (is the change log acceptable or not in this case?). One option is to clarify in README the expected format in a change log (must have at least 2 sections?), which can actually be done over at #52 if you want.

Yes, please wait... for my sanity. LoL. :ghost:
I'll wrap the other one up some time today.

Please rebase to resolve conflicts. Sorry!

Coverage increased (+0.5%) to 84.372% when pulling 364be89f46c41f3ea5082d93e528dae748fa5dfd on drdavella:missing-changelog into 0e957d3860647b0d3549425733587f12b581a5d5 on astropy:master.


RTL support for select and labels

Please add RTL support for:
1- Select (as the direction of the arrow and the text is not aligned correctly).

wrong alignment

correct alignment (after applying logical class names of tailwind)

2- Labels.. either select, inputs, autocomplete or any component has a label, the label is not aligned correctly.

Originally posted by @E-Naeim in https://github.com/nextui-org/nextui/discussions/2004

RTL is still not supported by NextUI


Popover not trapping Escape key when rendered inside the Modal component

When a Popover component is used inside a Modal component and if the popover is open, pressing the Escape key closes both the popover and the modal.
Expected behavior: Pressing Escape key when the popover is open should only close the popover. Modal should remain open.

This line may help also. In the Combobox PR fix, this is what stops the event from bubbling
https://github.com/salesforce/design-system-react/blob/master/utilities/key-callbacks.js#L16
if (stopPropagation) {
			EventUtil.trapEvent(event);
		}

So something like this should do it in
https://github.com/salesforce/design-system-react/blob/master/utilities/keyboard-navigable-dialog.js#L46
case KEYS.ESCAPE:
	if (isOpen) {
		toggleOpen();
		EventUtil.trapEvent(event);
	}
break;


Remove gif in images?

great plugin.
One suggestion is remove gif from the plugin and clean up the .git (may need to purge all history to reduce the .git size). You can provide a URL of the gif from wiki/gist in the Readme.
The repo is 13MB ATM

I will not add more image on this repo.
I am not familiar with change history on git and force push is not my favorite command so thank for your suggestion

One way is re-run git init and it will clean all git history. Yes, it is a bummer. Another way would be to patch everything after gif was created.
Personally, I would do it earlier rather than late. As each time you update the gif when you have a feature update, it will add an extra 6.5MB in your repo.


How to create a button to reset/refresh the grid?

I want to be able to reset the grid back to default by clicking a button. Is that possible?
thanks!

Save a clone of the gridster config and items in your component controller. Then bind the button to a method on your controller that overwrites the gridster config and items with the backed up config.


Fix a view migration "renaming" a view property.

View properties and links do not actually exist as columns in real
tables, so when migrations that rename them are reflected into SQL they
must not produce any changes to the tables.
Fixes #748.

Can you look for other places with endswith? if there are any please fix them in separate prs

There does not appear to be any more suspicious endswith usage.


fix tests

[x] Added or updated tests
[ ] Documented user facing changes
[ ] Updated CHANGELOG.md

Changes
Fix failing test introduced by line number changes in b15252672a9677e0dbb4336cde16c2407098b33c
Fix failing CollectionStub tests caused by changes to checkExplicitMixed in https://github.com/phpstan/phpstan-src/commit/6ba9ef29cb5ccd5b540815e899c95e6a1602ccad
I'm not 100% sure about the Collection related changes and the effect this will have on existing projects. I am happy to make amendments if the stub changes need adjusting.
Breaking changes

I'm not 100% sure about the Collection related changes and the effect this will have on existing projects. I am happy to make amendments if the stub changes need adjusting.

They look ok. We can make changes if anyone complains 😄 Also with Laravel 9 we will have this in the framework itself.
Looks good. Thank you!


Update TagBot

Pull Request Test Coverage Report for Build 371725037

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.595%

Totals

Change from base Build 355667922:
0.0%

Covered Lines:
105

Relevant Lines:
111

💛  - Coveralls


Live Documentation

So the more I think about it, as great as fixing  the current priority issues/enhancements I think this needs to be bumped to the top.
The idea is that when the "book" looking icon is clicked, the live documentation running on that jupyter server will boot up. I want to be able to have the documentation be the foundation for the testing suite. Each example presented in the docs will be interacted with via selenium to create the tests. The examples in the docs will be located right next to the files that correspond to them. The text explaining that feature will actually be written within the code files themselves. The docs will extract that text out and present it within the documentation.
The docs will be split into user docs and development docs. The aim is that each file in the source code will have a document somewhere in the documentation explaining what that file is for. An explanation which is itself extracted from that file which is being explained. The top level user facing features will have their explanation within the user docs. Any other file will fall into the contributor docs.
Ideally I'll use python to do a glob of the source code directory. Then search for documentation within the source files. The table of contents for the development docs can mimic the file tree of the source. The user docs will need something else...

@OxygenLithium @robmarkcole @sunyu0410 what's your opinion about having feature and bug fixes go on hold for a few weeks while I sort out the docs?
Once we're happy with 0.9.1dev3 I'll release it as 0.9.1 proper. And then focus on docs. This means issues such as colunn hiding, and that bug with the table options will go on hold for a bit.

Hi @SimonBiggs I agree that documentation should be the priority at this point, but still with essential bugfixes addressed.
Your approach sounds very novel so I am looking forward to seeing it in action! Will you be using https://jekyllrb.com/ ?
Home-assistant use it and I really appreciate the simplicity of just editing markdown to create the website. This actually gave me another thought; that if scriptedforms can be used to embed live examples of python into webpages that could potentially be a huge draw to the code as a use for documentation?
Cheers

Lets avoid any yaml :)

Sounds like a plan :)


[feature] Adding a parameter for title generation prompt

Solving #540 request to add the 'prompt for title generation' as a configuration item

PR rebased with last week's changes


LitmusCTL doesn't work with DEX

To use a different account than a password-based one, it's necessary to log in via the portal, copy a valid JWT token issued after authentication via DEX and paste it in the .litmusconfig file in order to be able to get projects assigned to an IDC user.

cc: @rajdas98

currently, litmusctl isn't supporting dex. This is the first request we are getting for it. So, we'll start working on this.


Remove unused keys in final layout

Remove keys that never get used in any "optimal" paths

e2ab9f18352462d151e736f6d7d823bce4485014


[Fix] nvm debug: awk: not an option: --version

On Debian, the default awk/mawk doesn't support the --version option, instead there's mawk specific -W version. See https://linux.die.net/man/1/mawk

Does that mean Debian isn’t posix-compliant, or that the --version command isn’t part of posix?


Replace deprecated .URL parameter

Running Hugo v0.55.6 I see:
WARN 2019/07/21 19:36:38 Page's .URL is deprecated and will be removed in a future release. Use .Permalink or .RelPermalink. If what you want is the front matter URL value, use .Params.url.

This needs to be updated in the theme's layout files.

I can do that if you want ! 😉👌🏽

Thanks @tanohzana :+1:

Little update on this. I have not forgotten about it. I'll do it today 👌

@hanzei can reproduce the warning 🤔 also I found this online:
https://github.com/gohugoio/hugo/issues/5868
TLDR: Apparently .URL is not deprecated for menu. You probably got the warning from something you coded that does not belong to the theme. Check if you have any .Page.URL...
Let me know 😉

I'm using v0.56.1 and I'm not seeing this warning. I also don't see a use of .URL in the code outside of menu elements.
@tanohzana @victoriadrake Can you please check again?

Can no longer reproduce. :woman_shrugging:


I opensourced an old version of Ultanium

https://github.com/UniqueName12345/Ultanium

What should its description be?

idk. just mention the fact that the repo is completely innacurate to the new version (which at the moment is closed source)

Yeah but how should I describe the bot? What is Ultanium?

bump

bump 2

bump 3

I have been perma banned from Meower, and I'd rather not be associated with this bot anymore


[Bug] Axial view on a volume not working on 2.0.0 beta

Describe the Bug
The following issue is with the 2.0.0 beta running on Next.js as described in the nextjs-cornerstone3d example repo.
When I try to load and view an axial view on a volume in orthographic mode it seems to break Cornerstone3D. Sagittal, coronal in orthographic mode and volume_3d mode work just fine. However, when I try to render the axial view and call setVolumesForViewports:

it does not display (blank element view)
the volume 3D view seems to break (preset not applied)
In the console I see the error:

TypeError: Cannot destructure property 'imagePositionPatient' of '_metaData__WEBPACK_IMPORTED_MODULE_3__.get(...)' as it is undefined.
    at getClosestImageId (getClosestImageId.js:31:17)
    at VolumeViewport.getViewReference (VolumeViewport.js:354:110)
    at VolumeViewport.addActors (Viewport.js:197:34)
    at VolumeViewport.setActors (Viewport.js:166:14)
    at VolumeViewport._setVolumeActors (BaseVolumeViewport.js:669:14)
    at VolumeViewport.setVolumes (BaseVolumeViewport.js:513:14)
    at async eval (setVolumesForViewports.js:17:9)
    at async Promise.all (index 0)
    at async setVolumesForViewports (setVolumesForViewports.js:19:5)
    at async setup (testing.tsx:116:13)

I have tried loading both wadouri: and wadors: volumes.
Steps to Reproduce

Clone nextjs-cornerstone3d repo
Change page.tsx line 60 to orientation: Enums.OrientationAxis.AXIAL,

The current behavior
Blank view displays
The expected behavior
Axial view renders
OS
macOS 14.6.1
Node version
20
Browser
Chrome 126.0.6478.183

Note: editing details to better reflect Steps to Reproduce

It seems that this issue only occurs when using wadouri:. So this issue seems to be a duplicate of https://github.com/cornerstonejs/cornerstone3D/issues/958.
I will close this now and reference there.


output argument of inference is ignored

Whatever value you pass to the inference script, the output always gets written to output_sample.jpg.

--output argument works fine for me. Can you give me more information?

Hmm maybe I had a typo in my command, sorry anh oi! :)


Gmail

resolves #35

This change is

Reviewed 42 of 47 files at r1, 1 of 2 files at r2, 1 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


No migration guide yet ?

Issue Summary
As per the README,

v6.0.0 is a complete rewrite of this SDK for all endpoints. To upgrade from v5.X and lower, please begin here.

But the link links back to the README, it seems like no migration instructions have been written yet. Do you know when it will get updated ?
Steps to Reproduce

Checkout the README

Technical details:

sendgrid-nodejs Version: master (latest commit: [01a9efe370a0e707da8d0b904209b90da8363281])

Hello @cadesalaberry,
There is not really a direct path from v5 to v6. For example, compare the previous Hello Email to the current. So my current recommendation is to rewrite your code based on the new README/USE_CASES documentation.
Obviously, I have not done a good job making that clear. Perhaps instead of

v6.0.0 is a complete rewrite of this SDK for all endpoints. To upgrade from v5.X and lower, please begin here.

we should say

v6.0.0 is a complete rewrite of this SDK for all endpoints. To upgrade from v5.X and lower, we suggest you update your code based on the examples found here for mail send and here for all other endpoints.

If this seems unacceptable, what type of documentation were you expecting?
Thanks again for taking the time to bring this issue to light, we greatly appreciate it!
With Best Regards,
Elmer

Thanks Elmer !
Yes, that seems great to me, I was missing some sort of documentation of the new API, the USE_CASE is exactly what I was looking for :smile: I made a PR to update the changes accordingly (https://github.com/sendgrid/sendgrid-nodejs/pull/434)
Cheers,
PS: Btw for clarification, this sentence is in the CHANGELOG, not the README as I mentionned.


[ENG-734]Build validations from schemablock groups

Ticket: ENG-734
Feature flag: n/a

Purpose

Build a validations helper to build validations for a given schema page
Summary of Changes

Added a validations helper that takes in an array of SchemaBlocks and returns a validation object based on the inputs in that array. The validation object will use the registrationResponseKey to assign validations to each input.
Added a custom validator to check if file-input has the format expected with id and name.
Added PageResponse type. This is the model that the validations are built for.
Added groupType property on SchemaBlockGroup. This property is the same as SchemaBlockGroup.inputBlock.blockType
Side Effects

N/A
QA Notes

N/A

Pull Request Test Coverage Report for Build 3377

40 of 43 (93.02%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 75.58%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/packages/registration-schema/validations.ts
27
28
96.43%

app/validators/validate-response-format.ts
13
15
86.67%

Totals

Change from base Build 3374:
0.06%

Covered Lines:
7625

Relevant Lines:
8855

💛  - Coveralls


possible to save dall-e image locally?

Is it possible to generate a dall-e image and save it locally as ?

"call openai dalle to generate a pic of a cat in suit, then save it locally" worked for me


TypeError: Cannot read property 'name' of undefined

When I register my entity like described here (https://aurelia-orm.spoonx.org/api_entitymanager.html)
import {Entity, validatedResource, association,type} from 'aurelia-orm';

export class Client extends Entity {
	@type('string')
	name = null;
}

with
import Client from '../services/client';
constructor(em:EntityManager) {
		em.registerEntity(Client);
}

I get the error message
myty-aurelia.dev.js:8820 ERROR [app-router] Error: Error invoking ClientsManager. Check the inner error for details.
------------------------------------------------
Inner Error:
Message: Cannot read property 'name' of undefined
Inner Error Stack:
TypeError: Cannot read property 'name' of undefined
    at Function.forTarget (http://localhost:9000/3rdParty/jspm_packages/npm/aurelia-orm@6.1.2/aurelia-orm.js:262:93)
    at EntityManager.registerEntity (http://localhost:9000/3rdParty/jspm_packages/npm/aurelia-orm@6.1.2/aurelia-orm.js:913:30)
    at new ClientsManager (http://localhost:9000/tycon/modules/clients/components/manager.js!transpiled:36:9)

The examples are wrong. You have to write
import {Client} from '../services/client';

@mreiche Nice catch. Yes, if you use named exports, you need to use named imports.


The months and days may occur negative.

What happened?
While calculating the age, the months and days may be negative.
For example: DOB is 10/10/2003 and today's date is 03/10/2003, the days are negative.

How can we reproduce this bug?
The age must be positive. Saying 21 years, 1 month, -7 days is not right. If the result is negative, it should not be printed.
Like the result should be, "21 years and 1 month" only.
Desktop Information (Optional)
No response
Urgency (Optional)
None

Please assign this issue to me.

Hi, thanks for the response! My contributions were not part of any specific event; I raised this issue while working independently on the project.
Could you please assign this issue to me and add the labels: "gssoc-extd "and "hacktoberfest"? Also, could you specify the level of this issue?
If you need any further information, please let me know.
Thanks!

I apologise for the oversight. Actually, the issue with the code was if DoB is 10/10/2003 and today's date is "03/10/2024", then the number of days in the age were "-7".
I mistakenly wrote the 2003 as current date in the issue section.
You may check the screen shot posted in the issue for a better understanding of my issue.
Thank You for being patient with me throughout the process.
I'll make sure not to repeat these mistakes.
Thank you!

@KashishJuneja101003 Ok, will check

@Kushal997-das Do I need to raise the pull request once more?
Since in my dashboard, it is still invalid.

03/10/2024

Could you check if you are receiving any instances where the number of days is negative? It seems to be working perfectly fine for me.

10/10/2003 is valid now because 10/10/2024 has already passed.
It will show negative months and years if you try with any future date with year < 2024.
For example,

I posted the issue on 03/10/2024. Thus the output was negative that day. After 10/10/2024 arrived, it became valid.
I hope this comment clears up any misunderstanding.
Thank You!

@Kushal997-das kindly assign this issue!!


Value mismatch with JNCryptor java

My web server uses JNCryptor java implementation for API. The problem i am facing is that
Encrypted data returned from server is successfully decrypted but the Encrypted data that i am passing to server is not decryptable by server. Server is not getting the value out if it
Is there any information that i can share with you for reproduce? This is very important for me.

Hi @arif2k17, please could you send me the code that you are using on the server to decrypt the data.


Units on timeseries .plot and .quantity are inconsistent

When I extract a quantity from a STIX quicklook lightcurve using .quantity, the units are in ct. However, when I visualize that same data with peek or plot, the y-label says the units are ct s-1 keV-1. The latter appears to be hardcoded in the plot method.

Thanks for reporting, yes the raw data is ct but often for plotting want it in ct s-1 keV-1 or even ct s-1 keV-1 cm-2. I'm not sure what to do here as I dont think there's a way to support different units in Timeseries? I guess as a hack I could create addition columns for the different units counts: ct, count_rate: ct s-1,  differential_count_rate:  ct s-1 keV-1,
differential_count_flux: ct s-1 keV-1 cm-2.

There is also a bug in the code which I will fix where the units are hardcoded to be ct but the data are converted to ct s-1 keV-1 during loading.


ERROR] TypeError: Cannot read property 'dropDatabase' of undefined

$ db-migrate db:drop rgb-lab.net
[ERROR] TypeError: Cannot read property 'dropDatabase' of undefined
at /tmp/node_modules/db-migrate/api.js:761:9
at Object.exports.connect (/tmp/node_modules/db-migrate/lib/driver/index.js:95:16)
at Object.exports.driver (/tmp/node_modules/db-migrate/connect.js:83:10)
at executeDB (/tmp/node_modules/db-migrate/api.js:743:9)
at run (/tmp/node_modules/db-migrate/api.js:936:9)
at Object.dbmigrate.run (/tmp/node_modules/db-migrate/api.js:358:5)
at /tmp/node_modules/db-migrate/bin/db-migrate:35:11
at /tmp/node_modules/resolve/lib/async.js:44:21
at ondir (/tmp/node_modules/resolve/lib/async.js:187:31)
at onex (/tmp/node_modules/resolve/lib/async.js:93:22)
at /tmp/node_modules/resolve/lib/async.js:24:18
at FSReqWrap.oncomplete (fs.js:82:15)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/31866881-error-typeerror-cannot-read-property-dropdatabase-of-undefined?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

not actual, it' only when not installed npm db-migrate-mysql

but for create it still actual
db-migrate db:create rgb-lab.net
[ERROR] TypeError: Cannot read property 'createDatabase' of undefined
at /tmp/node_modules/db-migrate/api.js:745:9
at /tmp/node_modules/db-migrate/lib/driver/index.js:109:9
at Handshake._callback (/tmp/node_modules/db-migrate-mysql/index.js:424:14)
at Handshake.Sequence.end (/tmp/node_modules/mysql/lib/protocol/sequences/Sequence.js:96:24)
at Handshake.ErrorPacket (/tmp/node_modules/mysql/lib/protocol/sequences/Handshake.js:103:8)
at Protocol._parsePacket (/tmp/node_modules/mysql/lib/protocol/Protocol.js:280:23)

Please always post all information needed to reproduce.
used:

db-migrate version
node version
npm version
used driver + version

And always post the result of a verbose run.

"db-migrate": "^0.10.0-beta.11",
node: v5.4.1
npm: 3.3.12
mysql driver
"db-migrate-mysql": "^1.1.6",

Verbose run is missing, please also post your configuration (replace sensible information with dummies) as this does not seem to be a bug but a configuration issue,

[INFO] Detected and using the projects local version of db-migrate. '/var/www/node_modules/db-migrate/index.js'
[INFO] Using dev settings: { driver: 'mysql',
user: 'dev',
password: '******',
host: 'db',
database: 'rgb-lab.net',
multipleStatements: true }
[INFO] require: db-migrate-mysql
[INFO] connecting
[INFO] connected
[SQL] CREATE DATABASE IF NOT EXISTS rgb-lab
[INFO] Error: Failed to create database! { [Error: ER_DBACCESS_DENIED_ERROR: Access denied for user 'dev'@'%' to database 'rgb-lab']
code: 'ER_DBACCESS_DENIED_ERROR',
errno: 1044,
sqlState: '42000',
index: 0 }
seams problem with mysql user rights, and not with db-migrate, thanks for your time and your help

Yes this is an easy to fix one ;)
To help yourself, running in verbose mode often reveals the important bit of information.


Skip RemotePreconditionProbingTest on non-remote executor

With @RemoteOnly, if there's network issue connecting to remote executor, that test fails with an error. This is not what we want, we want it to be skipped in this case.

I've triggered a build for you. Click here to see all failures if there's any.


Verify payload gas limit against validator setting

If the requested gas limit is 0, validate the block as if it was 30 million (default)

Reference implementation:

if registeredGasLimit == 0 && header.GasLimit == utils.CalcGasLimit(parent.GasLimit, 30_000_000) {
  // Prysm has a bug where it registers validators with a desired gas limit
  // of 0. Some builders treat these as desiring gas limit 30_000_000. As a
  // workaround, whenever the desired gas limit is 0, we accept both the
  // limit as calculated with a desired limit of 0, and builders which fall
  // back to calculating with the default 30_000_000.
} else {
  calculatedGasLimit := utils.CalcGasLimit(parent.GasLimit, registeredGasLimit)
  if calculatedGasLimit != header.GasLimit {
    return fmt.Errorf("incorrect gas limit set, expected: %d, got: %d", calculatedGasLimit, header.GasLimit)
  }
}


Cannot access Tailwind colors when using daisyUI theme

I'm using Tailwind CSS along with daisyUI for a NextJS project. I have my tailwind.config.js file set up as:
/** @type {import('tailwindcss').Config} */
/* eslint-env node */
module.exports = {
    content: [
        './pages/**/*.{js,ts,jsx,tsx}',
        './components/**/*.{js,ts,jsx,tsx}',
        'node_modules/daisyui/dist/**/*.js',
        'node_modules/react-daisyui/dist/**/*.js',
    ],
    theme: {
        extend: {},
        fontFamily: {
            sans: ['Roboto', 'sans-serif'],
        },
    },
    daisyui: {
        themes: [
            {
                mytheme: {
                    primary: '#8855B4',
                    secondary: '#00C9AF',
                    accent: '#f3d0f5',
                    neutral: '#373f4a',
                    'base-100': '#FFFFFF',
                    info: '#3ABFF8',
                    success: '#36D399',
                    warning: '#FBBD23',
                    error: '#F87272',
                },
            },
        ],
    },
    plugins: [require('daisyui')],
}

When I try to use a color defined within my daisyUI theme, it works fine:

Your Trips

But when I use a color defined from Tailwind, it does not work.

Your Trips

As you can see, the text is black instead of red-400.
It seems like daisyUI is overriding my access to Tailwind colors? How can I use the base Tailwind colors when using a daisyUI theme?

Do you have any other CSS code on your page that may change the colors?
I am only using Tailwind and don't have any other CSS code on any of my pages.
Are you using any other styling packages that may change the colors?
No, I'm using only daisyUI for some components.
Can you check the browser devtools to see where the black color is coming from?
I see this when I inspect the element in the Element's tab.

However, this is what it looks like (not red):

does text-red-400 even exist in the devtools? is it overridden by another style?
Yes, as you can see in the above screenshot, it shows text-red-400.


Does anyone know why parameters of C8C1I increases?

Does anyone know why parameters of C8C1I increases?
I try to mainly modify the config as
    "upsample_rates": [8, 1],
    "upsample_kernel_sizes": [16, 15],

or
    "upsample_rates": [8, 1],
    "upsample_kernel_sizes": [16, 1],

but neither of their parameters changed as shown in the table.

inspecting what you are trying to do, it should be more like:
   "upsample_rates": [8,1],     "upsample_kernel_sizes": [16,2],
though that alone won't be enough, you also need to update the iSTFT parameters gen_istft_n_fft and gen_istft_hop_size  so you get perfect upsampling to 256 samples per frame

inspecting what you are trying to do, it should be more like:
 "upsample_rates": [8,1], "upsample_kernel_sizes": [16,2],
though that alone won't be enough, you also need to update the iSTFT parameters gen_istft_n_fft and gen_istft_hop_size so you get perfect upsampling to 256 samples per frame

had done that. you can see that C8I also need it but it doesn't increase the parameters.


video-caption pair

I noticed that the caption csv file seems to have many overlaps for each clip. I want to see the long range pair, but I think it'll be a problem if I just concatenate them. Is there any way to get a video-caption pair? Do I have to use ASR on my own?
By the way, thanks for sharing nice work.

What about if you remove the redundant overlapping part of the concatenated clips?

@jihwanp I noticed this as well. The textual overlap is in the ASR subtitles from Youtube already.
However, that actually depends on the subtitle format you download from Youtube.
VTT has the issue while the TTML subtitles look more clean.
Note: The overlap is still there but only in the timestamps. The text itself is clean.
I guess this is due to limitations of the subtitle format to achieve the desired effect on screen, as those formats are meant for visualization and not data storage.
Hope this helps.
Example (video qREX695vxKs):
VTT:
00:00:04.400 --> 00:00:06.309 align:start position:0%
hey there real woman of philadelphia and

00:00:06.309 --> 00:00:06.319 align:start position:0%
hey there real woman of philadelphia and

00:00:06.319 --> 00:00:06.950 align:start position:0%
hey there real woman of philadelphia and
paula dean

00:00:06.950 --> 00:00:06.960 align:start position:0%
paula dean

00:00:06.960 --> 00:00:09.030 align:start position:0%
paula dean
my name is peyton kaminski and i'm about

TTML:

hey there real woman of philadelphia and

paula dean

my name is peyton kaminski and i'm about

to be moving to florida in a couple


Stuck when try add big file

When you try to add a large file to distribution, you get the feeling that everything is frozen and nothing is happening.
Example file:  magnet:?xt=urn:btih:ea025791bb0d72c646ac10577dbb3939660cacc4&dn=Home.Alone.1990.BDREMUX.2160p.HDR.seleZen.mkv&tr=http%3A%2F%2Fbt02.nnm-club.cc%3A2710%2F00a9ec2fa523035b91123e9bcb7eb2c5%2Fannounce&tr=http%3A%2F%2Fbt02.nnm-club.info%3A2710%2F00a9ec2fa523035b91123e9bcb7eb2c5%2Fannounce&tr=http%3A%2F%2Fretracker.local%2Fannounce.php%3Fsize%3D61869858789%26comment%3Dhttp%253A%252F%252Fnnmclub.to%252Fforum%252Fviewtopic.php%253Fp%253D10807645%26name%3D%25CE%25E4%25E8%25ED%2B%25E4%25EE%25EC%25E0%2B%252F%2BHome%2BAlone%2B%25281990%2529%2BUHD%2BBDRemux%2B%255BH.265%252F2160p%255D%2B%255B4K%252C%2BHDR%252C%2B10-bit%255D&tr=http%3A%2F%2Fbt02.ipv6.nnm-club.cc%3A2710%2F00a9ec2fa523035b91123e9bcb7eb2c5%2Fannounce&tr=http%3A%2F%2Fbt02.ipv6.nnm-club.info%3A2710%2F00a9ec2fa523035b91123e9bcb7eb2c5%2Fannounce&tr=http%3A%2F%2F%5B2a01%3Ad0%3Aa580%3A1%3A%3A2%5D%3A2710%2F00a9ec2fa523035b91123e9bcb7eb2c5%2Fannounce

Hi, currently progress is based on the files number, I will change it to bytes based progress later, thanks.


Carbon-clickhouse Reload or soft reboot

Hello.
The essence of the need is that I clean up non-daily metrics indexes (table tree or part of new table index).
After that, I noticed that some of the new metrics do not appear again today, only next day (probably due to the application cache).
Rebooting the service helps. But there is a possibility of losing metrics.
If it were possible to reset the cache (if this is the problem) or first turn off the port, add data to clickhouse-server and then turn off the service completely, then this would probably be correct.

Two ways:

Store cache in files for persistence during restart - it's simple
Soft reload - more difficult, it's required redisign of some components.

I planned one of them some time later.


Router doesn't route when using service bindings

Hello there, I have a wee bug report. On branch next, it seems like the router fails when when using the service bindings Cloudflare API.
Steps:

Clone this reproduction repo https://github.com/vladinator1000/worktop-service-bindings/tree/main
cd into the api folder
npm i && npm start
Open another terminal
cd into the pages folder
npm i && npm start
In your browser, open http://localhost:9787/api
You should see "Hello from Worktop!" but instead there's "Not found"

Hi @lukeed, after some more digging, it looks like the issue looks related service bindings. I've updated the issue description to include a full reproduction.

In Pages I'm doing
    if (url.pathname.startsWith('/api')) {
      return env.API.fetch(request)
    }

But in the API I was doing
let router = new Router();

router.add('GET', '/', (_request, context) => {
	return new Response('Hello from Worktop!');
});

It didn't find an /api route so it returned "Not Found"...
 It happens :)
PS I would suggest using router.mount so that you can omit the /api/ prefix inside all your API route definitions.
Also, I'm personally not a fan of service bindings. They're just an extra abstraction that makes you think about separation but is never actually separate. SO if I were you, I'd add a pre-build script inside the Pages project that produces the _worker.js file... I'm not familiar with Pages latest build rules/automations, so if they pick up a _worker.ts automatically, then great

I agree... The only reason I'm using service bindings is because it runs faster because the workers run on the same thread and bypass the network.
I build my the _worker.js with this script:
import { $ } from 'zx'

let branch = process.env.CF_PAGES_BRANCH

let mode = branch === 'main' ? 'production' : 'staging'
await $`yarn vite build --mode ${mode} --ssr src/_worker.ts --emptyOutDir false`.pipe(
  process.stdout,
)

My worker ended up looking like this
// This is the entry point of the server
// https://developers.cloudflare.com/pages/functions/advanced-mode/
interface Env {
  ASSETS: Fetcher
  API: Fetcher
}

let handler: ExportedHandler<Env> = {
  async fetch(request, env): Promise<Response> {
    const url = new URL(request.url)

    if (url.pathname.startsWith('/api')) {
      url.pathname = url.pathname.replace('/api', '')

      let apiRequest = new Request(url, request)

      return env.API.fetch(apiRequest)
    }

    return env.ASSETS.fetch(request)
  },
}

export default handler

The build script for the client bundle is very similar. Just vite build --mode ${mode}
Honestly I want to have a monorepo where the API is part of the pages worker, but my project is multi-repo, started before Pages was a thing.

My suggestion is to bundle the API code directly within your pages/_worker.js -- you get all the same performance benefits (but more, actually) since it's literally the same Worker/isolate w/o any fake/feigned separation between them
But ya, you might have other repo/Pages challenges to deal with first. Manual deployments will help you out a lot... relying on Pages build pipeline to react to new commits gets old fast (and really is what limits monorepos)

@lukeed don't tempt me... I'm afraid of getting lost in a monorepo tooling binge 😅

Come on in, water's warm


Not working after update vue1.0.0.alpha3 - vue-router0.6.0

Hello,
recently i tried to update my application from 0.12.5 -> 1.0.0.alpha3 i also wanted to update router from 0.5.0 -> 0.6.0 .  Generated function body:  /scope.parameter/{{scope.firstParam.clinic_id}}/{{scope.firstParam.id}}

When i downgrade router to 0.5.2 i get app working correctly

Thanks, there will be a 1.0 compatible release for the router soon.

Please make sure to upgrade to latest 1.0 alpha (router tests pass with 1.0.0-alpha.5)


allow money requests on instantly submitted reports

@Ollyws @Beamanator
Details
This PR allows handling money requests for expense reports when instant submit auto-reporting frequency is set for the policy and when the expense report itself is in submitted state.
Specifically, we allow:

To place money requests from Expense Reports.
Delete money requests from Expense Report/Transaction Thread Report

Fixed Issues
$ https://github.com/Expensify/App/issues/35814
PROPOSAL: https://github.com/Expensify/App/issues/35814#issuecomment-1949882692
Test
Precondition:

Use a Collect Workspace
Set scheduled submit frequency to Instant

Steps:

Create a new Expense Report with one manual money request.
Navigate to the Expense Report.
Verify that on clicking composer FAB button, the menu displays Request money option. —> Test 1
Click on Request money and generate a new manual request.
Verify that the newly generated Money Request action is generated in the same Expense Report —> Test 2
Verify that the Context Menu for the generated Money Request action displays Delete request option —> Test 3
Click on the generated Money Request action to navigate to the Transaction Thread Report of the money request.
Verify that the header menu displays Delete request option  —> Test 4

[x] Verify that no errors appear in the JS console

Offline tests
Same as the Steps in Tests Section.
QA Steps
Same as the Steps in Tests Section.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Safari
https://github.com/Expensify/App/assets/3004659/77d960a1-c18a-484a-a466-defe4a6331c4

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3004659/b7e55083-fe45-4bf5-9800-010c8653c00b

MacOS: Desktop
https://github.com/Expensify/App/assets/3004659/9d926f2f-a033-4d36-95bb-08b2ac63f111

iOS: Native
https://github.com/Expensify/App/assets/3004659/d4579397-7951-46c7-9b36-ce571b512258

Android: Native
https://github.com/Expensify/App/assets/3004659/2325d55e-b7cb-46fb-a1e9-d29ee6c16d14

Android: mWeb Chrome
https://github.com/Expensify/App/assets/3004659/3262891d-d05a-4639-ab16-588b67a81b7e

@Ollyws
In addition to the scenarios mentioned in the proposal, I also noticed an additional use case for Delete request from within the context menu of the money request action.
I have added that too in this PR.
I have completed the PR checklist. The PR tests well too.
All yours for review.

This should be the case - Are we currently able to see the Submit button when the auto reporting frequency is instant? If so, please let me know and I'll definitely make a new bug report for that :D 👍

Yes, we are able to see Submit button. Please find the steps and the video for the same. And I have also proposed a solution for the same.
If the solution is acceptable, maybe we can increase the bounty here itself and do this here as we already have the context here and it could also help things move faster. Do you think this is fine? Or do we take this up in a new issue itself?
cc @Beamanator @Ollyws
Proposal
Please re-state the problem that we are trying to solve in this issue.
Name: Submit button should be hidden when instant reporting frequency is set.
Steps:

Use OD to set Scheduled Submit reporting frequency to Manual.
As an Employee, generate a Money Request within a collect workspace.
Verify that Submit button is displayed in Report Preview of the Workspace Chat.
Navigate to the Expense Report and verify that Submit button is displayed in the header.
Go to OD and set Scheduled Submit reporting frequency to Instant.
Reload the ND to ensure that Instant reporting frequency is set locally.
Verify the presence of Submit button in Report Preview and in the header of Expense Report

Actual Behaviour: Submit button is not hidden when instant reporting frequency is set.
Expected Behaviour: Submit button should be hidden in step (7) when instant reporting frequency is set.

Test Video - Actual Behaviour
https://github.com/Expensify/App/assets/3004659/00ed99b5-6460-4f7f-8076-50f971c1c4ad

What is the root cause of that problem?
Submit button is displayed in two places: a) Report Preview action in Workspace Chat and b) Header of the Expense Report. And, we have not yet considered instant report frequency while showing/hiding of the submit button. This is the root cause.
What changes do you think we should make in order to solve the problem?
The Submit button on the header of expense report gets displayed here for large screen devices and here for small screen devices. We need to additionally check here for instant reporting frequency to decide on show/hide of the Submit button like this:
const shouldShowSubmitButton = isDraft && !isOnInstantSubmitPolicy && reimbursableSpend !== 0;

Further, for Report Preview, the Submit button get’s displayed here and the decision to show/hide submit button happens here. Here too, we need to consider instant reporting frequency to decide on show/hide of the submit button like this here.
const shouldShowSubmitButton = isDraftExpenseReport && !isOnInstantSubmitPolicy && reimbursableSpend !== 0;

What alternative solutions did you explore? (Optional)

@rojiphil - about the Submit button, let's deal with that in a separate PR, but see my comments about this PR here

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Build fails with an exception when building for Windows

I am getting this error when running following command to build exe for Windows!
flutter_distributor package --platform windows --targets exe --artifact-name=TargetMate-windows-0.6.6.exe

Crash:
Unhandled exception:
BuildError
BuildError
#0      AppBuilder.build (package:flutter_app_builder/src/builders/app_builder.dart:68:7)
#0      AppBuilder.build (package:flutter_app_builder/src/builders/app_builder.dart:68:7)
<asynchronous suspension>
#1      FlutterDistributor.package (package:flutter_distributor/src/flutter_distributor.dart:154:27)
<asynchronous suspension>
<asynchronous suspension>
#1      FlutterDistributor.package (package:flutter_distributor/src/flutter_distributor.dart:154:27)
#2      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
<asynchronous suspension>
#2      CommandRunner.runCommand (package:args/command_runner.dart:212:13)

<asynchronous suspension>

Can you provide your configuration file

This was working before I added rive as dependency! So tried after removing Rive and it seems to be working just fine now! I guess it may not have anything to do with this package but it is interesting how this package throws because of it!


Spring Kafka Listener uses stale oauthbearer token, fails to connect after initial token expired.

Back port of issue: https://github.com/spring-projects/spring-kafka/pull/2613

Fixed via https://github.com/spring-projects/spring-kafka/commit/52ff892c13045f7b70cf59bb18542f64ae2c340d


Add bash max duplicate checker

Added this feature to the most current bash version. Have been using this addition on an older version for quite some time, allows me to only download the most recent content. Useful in combination with a cron job/schedule, for example to each day download only my new favourites to a larger folder of already downloaded favourites, where there won't be any missing files from further back in time.
This was tested working on MacOS Mojave 10.14.6 with some modification to the mkdir/mktemp parameters to ones that MacOS was happy with. I have changed them back to how they were for this pull request, so I hope the feature still works for Linux.
Cheers!


io500 app verify warnning

I get the result by the new io500-app with script and C version. But when I use the ./io500 --verify，I get this warnning WARNING Verify the output with the matching version of the benchmark(I don't change nothing). Is this correct or have any problems? and can this result be the official result to be summit?
thank you!

That shouldn't be a problem more likely due to the version changes we did.
Please submit the version then we can check.
On Wed, Jul 1, 2020 at 5:12 AM 小泽一<EMAIL_ADDRESS>wrote:

I get the result by the new io500-app with script and C version. But when
I use the ./io500 --verify，I get this warnning WARNING Verify the output
with the matching version of the benchmark(I don't change nothing). Is
this correct or have any problems? and can this result be the official
result to be summit?
thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/VI4IO/io500-app/issues/26, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGW5SXYHYG4NGOLCLNAAD3RZKZSLANCNFSM4ONAFOJA
.

--
Dr. Julian Kunkel
Lecturer, Department of Computer Science
+44 (0)<PHONE_NUMBER>
http://www.cs.reading.ac.uk/
https://hps.vi4io.org/
PGP Fingerprint: 1468 1A86 A908 D77E B40F 45D6 2B15 73A5 9D39 A28E

That shouldn't be a problem more likely due to the version changes we did. Please submit the version then we can check.
…
On Wed, Jul 1, 2020 at 5:12 AM 小泽一 @.***> wrote: I get the result by the new io500-app with script and C version. But when I use the ./io500 --verify，I get this warnning WARNING Verify the output with the matching version of the benchmark(I don't change nothing). Is this correct or have any problems? and can this result be the official result to be summit? thank you! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGW5SXYHYG4NGOLCLNAAD3RZKZSLANCNFSM4ONAFOJA .
-- Dr. Julian Kunkel Lecturer, Department of Computer Science +44 (0)<PHONE_NUMBER> http://www.cs.reading.ac.uk/ https://hps.vi4io.org/ PGP Fingerprint: 1468 1A86 A908 D77E B40F 45D6 2B15 73A5 9D39 A28E

Yes, the version is diffierent. I use the io500-verify can get this version         = io500-isc20-13-gc155836d31c1-30 result file ver = io500-isc20_v4-1-g18c6d03b40b0-17.
What can I do to make the version be same.

I suppose there is an issue with the naming of the patched version lately.
Don't worry about it. We will sort it out for the next version.


Created Screen Recording Demo for pyautoeasy

fix #13
Created Screen Recording Demo for pyautoeasy usage.
Added to the video demo, markup file, and demo script to the examples folder

@dingusagar  so how do I add the compressed video to the markdown file, should I create a new PR or is it possible to edit the current PR (Sorry I m new to this stuff)

@dingusagar thanks a lot for the help. I had a great time learning and working with you


Allow paths with spaces for OutputDirectory

I tried to run:
DotNetCoreAliases.DotNetCorePublish(inSolutionDetails.context, iterProjectLocation + "\\project.json", new DotNetCorePublishSettings() {
    Configuration = "Release",
    OutputDirectory =inSolutionDetails.ArtifactsFolder + "\\" + projectName,
});

Note: inSolutionDetails.ArtifactsFolder has spaces in it (\Visual Studio) and .NET Core CLI will return an error:
Unrecognize command or argument 'Studio'.

The error is actually commind from the project.json location (I am sendinf the full path) not the OutputDirectory.
I used "\""+iterProjectLocation + "\\project.json\"" to specify the project location and it worked.

Unrecognize command or argument 'Studio'.
The error is actually commind from the project.json location (I am sendinf the full path) not the OutputDirectory.

I used """+iterProjectLocation + "\project.json"" to specify the project location and it worked.

@SavaNDragos I moved your comments to the issue and fixed the formatting.

@SavaNDragos this should be available in the next release of Cake.


OrgConfig returns if multi-currency is enabled

Critical Changes
Changes
Dynamically choose to run tasks in a flow whether or not multi-currency is enabled in the org.
Example:
flows:
    load_storytelling_data:
        steps:
            1:
                task: load_dataset
                options:
                    mapping: datasets/with_mutli_currency/mapping.yml
                    sql_path: datasets/with_multi_currency/data.sql
                when: org_config.is_multi_currency_enabled
            2:
                task: load_dataset
                options:
                    mapping: datasets/without_multi_currency/mapping.yml
                    sql_path: datasets/without_multi_currency/data.sql
                when: not org_config.is_multi_currency_enabled

Issues Closed

Note: I ran make docs  just in case it was needed to capture the doc string for OrgConfig.is_multi_currency_enabled.   I saw there were a lot of changes to flows.rst and tasks.rst that were unrelated to my changes, so I did not commit those changes.

@spelak-salesforce Is it possible for a task to turn on multi-currency? If so, it's theoretically possible for the cached value to be out of date.
I am thinking that we should give CumulusCI the ability to run the same preflight checks that are used for MetaDeploy install plans (which can be used to skip a step, among other things). Then they would run before the main flow starts, rather than prior to a particular step. It would also mean we could do things like cci flow info --org [org] where we run just the preflight checks on the org and then show the adjusted flow steps that are applicable to that org.

@spelak-salesforce Is it possible for a task to turn on multi-currency? If so, it's theoretically possible for the cached value to be out of date.

@davisagli , I don't know but will look into if it's possible to programmatically enable multi-currency.  This approach at least checks the state of the org when the first org_config.is_multi_currency_enabled is called.

@spelak-salesforce Is it possible for a task to turn on multi-currency? If so, it's theoretically possible for the cached value to be out of date.

@davisagli , I don't know but will look into if it's possible to programmatically enable multi-currency. This approach at least checks the state of the org when the first org_config.is_multi_currency_enabled is called.

@davisagli , I can't find definitive proof that mutli-currency cannot be enabled via API, but MultiCurrency is a scratch org definition feature which suggests enabling this feature cannot be done via API.

@spelak-salesforce ok, it's probably not worth worrying about then. I'll try to give this a closer review soon.

A task can't turn on multi-currency, as far as I know, because it is a scratch org feature (not a Settings deployment).
@spelak-salesforce  Can you form your when clauses by looking at the org shape instead? That should be no code required.

A task can't turn on multi-currency, as far as I know, because it is a scratch org feature (not a Settings deployment).
@spelak-salesforce Can you form your when clauses by looking at the org shape instead? That should be no code required.

@davidmreed , what do you mean by org shape?   Like checking the name of the scratch org def file?
The intent of this PR is to support running tasks only if an optional Salesforce feature is enabled while being easy to interpret its usage in cumulusci.yml.  In this case, support checking if multi-currency is enabled.
This method is a similar to OrgConfig.is_person_accounts_enabled, and it's been super useful to have when clauses like not org_config.is_person_accounts_enabled.

Checking the scratch org definition file doesn't sound like a great option because then it wouldn't work for persistent orgs.

I don't think this is a concern for the purpose here, but wanted to call out that Advanced Currency Management is a separate layer from the basic multicurrency enablement and doesn't respond to the same checks (as I learned recently in collaboration with Michael Smith).

ncern for the purpose here, but wanted to call out that Advanced Currency Management is a separate layer from the basic multicurrency enablement and doesn't respond to the same checks (as I learned recently in collaboration with Michael Smith).

I'll dig into this scenario and make sure this solution supports both Currency Management + Advanced Currency Management.

@davisagli  @davidmreed
I dug into both Multiple Currencies and Advanced Currency Management (ACM) and found both can programmatically be enabled via Metadata API through the CurrencySettings.
<?xml version="1.0" encoding="UTF-8"?>
<CurrencySettings xmlns="http://soap.sforce.com/2006/04/metadata">
    <!-- Enables Multiple Currencies -->
    <enableMultiCurrency>true</enableMultiCurrency>

    <!-- Enables Advanced Currency Management (ACM) -->
    <enableCurrencyEffectiveDates>true</enableCurrencyEffectiveDates>
</CurrencySettings>

Notes

Multiple Currencies cannot be disabled once enabled.
ACM requires Multiple Currencies to be enabled.

Via REST API, we can detect if:

Multiple Currencies is enabled by checking if the CurrencyType describe returns a 200.

Enabling Multiple Currencies exposes both the CurrencyType and DatedConversionRate Sobjects.

ACM is enabled by checking if the DatedConversionRate describe both returns a 200 + is createable.

Implementation:

Since Multiple Currencies and ACM can be programmatically enabled, we cannot generally cache the result.
Since Multiple Currencies cannot be disabled once enabled, we can cache the result when we detect Multiple Currencies is enabled to save CumulusCI from doing future describe calls.
ACM can be programmatically disabled, so we need to always check the describe call to verify if ACM is enabled or not.

@davisagli , this is ready for re-review.


How to implement TypeScript 2.2 plugin?

TypeScript 2.2 will provide the capability to customize TypeScript tsserver commands with plugin.
Today it exists 2 plugins :

A plugin for Angular2 => https://github.com/angular/angular/tree/master/modules/%40angular/language-service
A plugin for tslint => https://github.com/angelozerr/tslint-language-service

I'm trying to implement tslint plugin like Angular2 plugin, but it should be cool if we could have a guide like "How to implement TypeScript plugin". For instance I have noticed that Angular2 plugin waits a method create(info: ts.server.PluginCreateInfo). Could you specify please which properties contains ts.server.PluginCreateInfo (it seems that there is languageServiceHost, languageService and project)
Could you tell me please the strategy for loading the plugin? How tsserver which plugins it must load?
Many thanks for your clarification!

This is still work in progress. so there is not really a TS 2.2 plugin. you can follow the progress in https://github.com/Microsoft/TypeScript/pull/12231

Thanks @mhegazy for your answer. Now I see how to plugins to load are declared (in the tsconfig.json).
Thanks again!


Periodic loading of grid data causes control to fallback on 1st page

I am using ng-react-grid with page-wise display. I need to reload the grid data periodically, for which I am using $timout of angular. I am able to reload the grid data periodically, but if before the page gets refreshed, control is on second page and page refresh happens, control falls back on first page. It seems that when page refresh happens, layout is re-drawn. Is there any way by which data gets refreshed without re-drawing layout?

Hmm @sohanboost could you post some sample code for me to look at?

Apologies for misconception. Its not an issue hence closing it.


Updated versions for release of java, spring, spark and encryption SDK

Updated versions for release of java, spring, spark and encryption SDK

API change check for com.azure:azure-cosmos
API changes are not detected in this pull request for com.azure:azure-cosmos

API change check for com.azure:azure-spring-data-cosmos
API changes are not detected in this pull request for com.azure:azure-spring-data-cosmos

API change check for com.azure:azure-cosmos-encryption
API changes are not detected in this pull request for com.azure:azure-cosmos-encryption