python310Packages.pyairvisual: 2023.11.0 -> 2023.12.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pyairvisual is: Python library for interacting with AirVisual
meta.homepage for python310Packages.pyairvisual is: https://github.com/bachya/pyairvisual
meta.changelog for python310Packages.pyairvisual is: https://github.com/bachya/pyairvisual/releases/tag/2023.12.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2023.12.0 with grep in /nix/store/pqlz8b7v3s7s1kvj6ha3l36w4vrkj9s3-python3.10-pyairvisual-2023.12.0
found 2023.12.0 in filename of file in /nix/store/pqlz8b7v3s7s1kvj6ha3l36w4vrkj9s3-python3.10-pyairvisual-2023.12.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.airvisual
home-assistant-component-tests.airvisual_pro
python310Packages.pyairvisual
python311Packages.pyairvisual

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pqlz8b7v3s7s1kvj6ha3l36w4vrkj9s3-python3.10-pyairvisual-2023.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pyairvisual https://github.com/r-ryantm/nixpkgs/archive/062a0f6f61e685edfc3671113a10d4b9148ec7db.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/062a0f6f61e685edfc3671113a10d4b9148ec7db#python310Packages.pyairvisual

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pqlz8b7v3s7s1kvj6ha3l36w4vrkj9s3-python3.10-pyairvisual-2023.12.0
ls -la /nix/store/pqlz8b7v3s7s1kvj6ha3l36w4vrkj9s3-python3.10-pyairvisual-2023.12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.pyairvisual
python311Packages.pyairvisual

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 275886 run on x86_64-linux 1

4 packages built:

python310Packages.pyairvisual
python310Packages.pyairvisual.dist
python311Packages.pyairvisual
python311Packages.pyairvisual.dist


Rubocop

Coverage decreased (-3.8%) to 81.792% when pulling 498181009aa1c9292116ff1928af37e03f567f53 on itowtips:rubocop into 6d54850fb90debd07cfe1a2f467541f58a4f5be3 on shirasagi:master.

Coverage decreased (-0.005%) to 85.586% when pulling dda6e5f746094dae69bdb028aef94a9d17378627 on itowtips:rubocop into 6d54850fb90debd07cfe1a2f467541f58a4f5be3 on shirasagi:master.

Coverage decreased (-0.002%) to 85.598% when pulling 98159e4446f071e723c8722b0579c8c616e2f34a on itowtips:rubocop into 22f6965678f7a8c50deaf1b4f448068e41b37377 on shirasagi:master.


GH-644: documenter clean

writeDocumentation cleans the output directory before writing any documentation files per default.
I think for the other public writeXYZ method, clearing the directory does not make any sense since writeModulesAsPlantUml, writeIndividualModulesAsPlantUml and writeModuleCanvases are called from writeDocumentation - additional cleans in those methods would delete previously created files.
@odrotbohm your feedback would be appreciated! :)
Thanks!

Thanks for the feedback! Sure, no problem - I will add Javadoc and make use of var.
I will investigate into the "wipe once approach" - I hope I find some time soon :)

Do you have a rough estimate when you would get to this? I'd love to get the changes into the release next Friday. I am happy to take it from here but don't want to break your flow if you're still considering it.

Hi!
I tackled the points regarding the documentation and the use of var.
Unfortunately, I do not have time before Friday to work on the "wipe once approach" - it would be great if you could take it from here.
Thanks!

No worries at all! Thanks for the contribution so far!

That's polished and merged against GH-644, thanks!


Hyperlink (cache-accelerated worker instance types ) does not work

[Enter feedback here]
I was trying to open the hyperlink (cache-accelerated worker instance types) but it takes you nowhere.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 65645010-95a5-2fd1-f626-06e2ee8e8bdb
Version Independent ID: 65645010-95a5-2fd1-f626-06e2ee8e8bdb
Content: Optimize performance with caching on Azure Databricks - Azure Databricks
Content Source: databricks/optimizations/disk-cache.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@Amitkpdatabricks
Thanks for your feedback! We will investigate and update as appropriate.

@kateglee-db
Can you please check and add your comments on this doc update request as applicable.

Thanks for providing feedback that helps improve our documentation. We've created an internal work item (DOC-13812) to address your feedback. The timeline for resolution varies based on resourcing.
#please-close


Can I use Koffi with DLL from .NET?

I have a .dll from .Net project that contain class inside a namespace.
Is it possible to use Koffi with this type of DLL?

suggestion:

https://learn.microsoft.com/en-us/dotnet/core/deploying/native-aot
https://learn.microsoft.com/en-us/dotnet/core/deploying/native-aot/libraries

Experimental: https://www.npmjs.com/package/node-api-dotnet


Fixed tomcat distro uri in deploy example

Currently link points to 404 page, therefore this change

LGTM  thx!!

Can one of the admins verify this patch?


Repair functionality of swap cleared/flag and goal indicator functionality

Somehow, an important increment to actOnChange got lost and the swap cleared/flag feature introduced with pull #94 and the goal indicator with pull #90 did not operate correctly.
Also, fighting with code indents is probably one of my least favorite things

That'd be my fault, apologies. Must have botched the merge. Thanks for submitting this.

I use Atom and beautify. :-)

Ok, I'm merging this in but there were merge conflicts again. With all the changed whitespace it's really hard for me to tell exactly what this was meant to look like. I think I got it, please let me know if I didn't.

Okay, I'll check on this.
When I save and commit, the indents look fine on my machine. Then in GitHub, the formatting is whack because of a mix of tabs and spaces that I don't see in my sublime editor :(
And, maybe I will ignore minor formatting gaffes until I figure out what's going on.

Sublime: in the bottom status bar-
Spaces: 4, Click: Convert Indentation to Spaces.
:-)


bug/Disable the submit button when the variable name field is empty - #576

https://github.com/Agenta-AI/agenta/assets/128676129/2ce30d42-06b8-44fb-a418-27af4866f04a

Closes #567

@all-contributors please add @yeokyeong-yanolja for code


How does enforcePinning configuration works?

I looked at source code and the only thing I could not find anywhere that it is skipping pinning check when it is "false". And the only reference I could find is in PinningFailureReport

Hi,
You can find more information in the Getting Started guide: https://github.com/datatheorem/TrustKit-Android/blob/master/docs/getting-started.md#always-start-with-pinning-enforcement-disabled . When enforcement is disabled, connections that fail pinning validation do not get blocked (so the App works as usual) but reports are still being sent so you can have an idea of how many users would be getting errors, if enforcemenet was to be enabled.


filtering rows on vector/matrix

Could we add a filter operation on broadcasted rows/ vectors/ matrices?
use case 1:
inputData(*, ::).filter(....).map(....)
use case 2: filter out NaN cells from a vector
val newVector = vector.filter(x => !x.NaN)
currently I do it with findAll and slicing:
vector(vector.findAll ( !_.isNaN ))
ps.
I asked this question sometime ago on mailing list but nobody responded, probably it was missed.

hey sorry, yeah i'll get to it
On Tue, Sep 15, 2015 at 2:05 AM, Daniel Korzekwa<EMAIL_ADDRESS>wrote:

Could we add a filter operation on broadcasted rows/ vectors/ matrices?
use case 1:
inputData(*, ::).filter(....).map(....)
use case 2: filter out NaN cells from a vector
val newVector = vector.filter(x => !x.NaN)
currently I do it with findAll and slicing:
vector(vector.findAll ( !_.isNaN ))
ps.
I asked this question sometime ago on mailing list but nobody responded,
probably it was missed.
—
Reply to this email directly or view it on GitHub
https://github.com/scalanlp/breeze/issues/445.

what should filter do on matrices?
On Tue, Sep 15, 2015 at 9:50 AM, David Hall<EMAIL_ADDRESS>wrote:

hey sorry, yeah i'll get to it
On Tue, Sep 15, 2015 at 2:05 AM, Daniel Korzekwa<EMAIL_ADDRESS>
wrote:

Could we add a filter operation on broadcasted rows/ vectors/ matrices?
use case 1:
inputData(*, ::).filter(....).map(....)
use case 2: filter out NaN cells from a vector
val newVector = vector.filter(x => !x.NaN)
currently I do it with findAll and slicing:
vector(vector.findAll ( !_.isNaN ))
ps.
I asked this question sometime ago on mailing list but nobody responded,
probably it was missed.
—
Reply to this email directly or view it on GitHub
https://github.com/scalanlp/breeze/issues/445.

Imagine you have a training set [NxD], N points, D features, and you read it with csvread(.),
then you would like to make some predictions for particular rows in a training set, so:
val data = csvread(.)
data(*,::).filter(r => r(0)==1).map(r => predict(r) //get transactions when promo offer was given to customer

Currently, first I convert data:DenseMatrix[Double] to Seq[DenseVector[Double]] and then use Scala collections API with filter, groupBy, etc. Maybe that is what I should do anyway and adding filter, groupBy to breeze Matrix api is wrong, what do you think? But, having broadcasting with map() on DenseMatrix, we might have filter, groupBy as well.

filter on rows/columns (via broadcasting) I understand and we should
definitely have them.
I think filter and flatMap on matrix don't make sense, but otherwise I'm on
board.
On Tue, Sep 15, 2015 at 11:36 PM, Daniel Korzekwa<EMAIL_ADDRESS>wrote:

Imagine you have a training set [NxD], N points, D features, and you read
it with csvread(.),
then you would like to make some predictions for particular rows in a
training set, so:
val data = csvread(.)
data(*,::).filter(r => r(0)==1).map(r => predict(r) //get transactions when promo offer was given to customer
Currently, first I convert data:DenseMatrix[Double] to
Seq[DenseVector[Double]] and then use Scala collections API with filter,
groupBy, etc. Maybe that is what I should do anyway and adding filter,
groupBy to breeze Matrix api is wrong, what do you think? But, having
broadcasting with map() on DenseMatrix, we might have filter, groupBy as
well.
—
Reply to this email directly or view it on GitHub
https://github.com/scalanlp/breeze/issues/445#issuecomment-140644493.

I have a use case for filter as well. For bivariate social networks (aka affiliation networks), it's sometimes important to remove rows and/or columns where the sum total is 1 or less. If you consider an n X m matrix where n are members of clubs, and m are the clubs and you want to see similarities among clubs based on memberships, it's usually not very interesting to analyze a case where only one person is a member of a club.
Consider the following matrix:
0 1 1 0 0 0
1 0 0 1 1 0
0 1 0 1 0 0
0 1 1 0 1 0
0 0 0 0 0 1

In order to get a useful result in the correspondence analysis, you would want the matrix to look like this:
1 1 0 0
0 0 1 1
1 0 1 0
1 1 0 1

In case it's helpful to anyone else, I used:
val sliceRow = (0 to myMatrix.rows -1)
      .filter(x => sum(myMatrix(x, ::)) > 1).toSeq
val sliceCol = (0 to myMatrix.cols -1)
      .filter(x => sum(myMatrix(::, x)) >1).toSeq
matrix(sliceRow, sliceCol)

Would be nice to have a broadcast, so I could just write this:
val newMatrix = myMatrix(*, ::).filter(x => sum(x) > 1)
val finishedMatrix = newMatrix(::, *).filter(x => sum(x) > 1)

It also follows the usual patterns of map, filter and reduce for collections. There might be other ways to do this, but filter was the first thing that came to mind since it's such a common function.

Imagine you have a training set [NxD], N points, D features, and you read it with csvread(.), then you would like to make some predictions for particular rows in a training set, so:
val data = csvread(.)
data(*,::).filter(r => r(0)==1).map(r => predict(r) //get transactions when promo offer was given to customer

Currently, first I convert data:DenseMatrix[Double] to Seq[DenseVector[Double]] and then use Scala collections API with filter, groupBy, etc. Maybe that is what I should do anyway and adding filter, groupBy to breeze Matrix api is wrong, what do you think? But, having broadcasting with map() on DenseMatrix, we might have filter, groupBy as well.

How do you convert densematrix to a seq[DenseVector] easily?

for rows, dm(*, ::).toIndexedSeq, for columns, dm(::, *).toIndexedSeq
On Wed, Dec 8, 2021 at 3:08 PM Min Shi @.***> wrote:

Imagine you have a training set [NxD], N points, D features, and you read
it with csvread(.), then you would like to make some predictions for
particular rows in a training set, so:
val data = csvread(.)
data(*,::).filter(r => r(0)==1).map(r => predict(r) //get transactions when promo offer was given to customer
Currently, first I convert data:DenseMatrix[Double] to
Seq[DenseVector[Double]] and then use Scala collections API with filter,
groupBy, etc. Maybe that is what I should do anyway and adding filter,
groupBy to breeze Matrix api is wrong, what do you think? But, having
broadcasting with map() on DenseMatrix, we might have filter, groupBy as
well.
How do you convert densematrix to a seq[DenseVector] easily?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/scalanlp/breeze/issues/445#issuecomment-989299962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACLIK57WIJUHEWR5UXFIDUP7QNLANCNFSM4BPV336Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


ArkDark Neovim Plugin

Request a feature
🤷 Motivation
Currently ArkDark only supports VSCode.
💡 Solution
Reuse the existing tmLanguage definitions to create a version of ArkDark that can be published as a Neovim plugin.

i likes arktype over zod or valibot, can you make an arkdark for jetbrains ides ?

@alphaelf That would be great, and particularly easy if JetBrains supports textmate since we already have those rules written.
Maybe you could create a separate issue requesting that? Would be happy to accept contributions.


[Bug] cheat tries to rcs with usp

Cheat tries to rcs with usp and it messes up my aimbot

Add a check for the ID of the weapon you're holding in the RCS code, duhhh.
And USP does have recoil? so how is it messing up your aimbot? That doesn't make any sense lol

Add a check for the ID of the weapon you're holding in the RCS code, duhhh.
And USP does have recoil? so how is it messing up your aimbot? That doesn't make any sense lol

It does make sense but you don't have a brain, the usp has recoil when its fired automatically, Nobody fires the usp automatically, first shot always misses

Add a check for the ID of the weapon you're holding in the RCS code, duhhh.
And USP does have recoil? so how is it messing up your aimbot? That doesn't make any sense lol

It does make sense but you don't have a brain, the usp has recoil when its fired automatically, Nobody fires the usp automatically, first shot always misses

what are you trying here?.. you ask for help that I'm willing to give, and then you attempt to correct me? Which you didn't by the way.. hmm. I know the answer to your issue.  Thanks X)

Mmh


fix: validate files to be uploaded

This PR is part one of two, ensuring that only files of specific types are uploaded to our system. This does file upload validation on the client side, but we must also implement some server-side validation.
Fixes FER-2070

@trevorblades thoughts on adding this to the docs-validation package (link)?
This way when a user runs fern check they will get a validation error that will automatically notify them that they can't upload those specific files.

That's a good idea! I can do that. Does the docs validator run before docs publishing, and would its failure stop a publish command? What I'm getting at is if you see this as something that lives in the docs validator and here in the publish command, or just in the validator.

@trevorblades thoughts on adding this to the docs-validation package (link)?
This way when a user runs fern check they will get a validation error that will automatically notify them that they can't upload those specific files.

That's a good idea! I can do that. Does the docs validator run before docs publishing, and would its failure stop a publish command? What I'm getting at is if you see this as something that lives in the docs validator and here in the publish command, or just in the validator.

Just in the validator works! the validator runs and has to be passed in order to hit publish

@dsinghvi I moved the file type check to the validator CLI and added some tests to confirm it's working as expected. Lmk if that looks like what you had in mind!


Using DirectML from C#

Is there any plans to build a wrapper to use DirectML from C#

Hi,
At the moment there is no direct wrapper of DirectML in C#.
However, DirectML is exposed as a backend to WinML and OnnxRuntime, and both are projected into the C# languages:

https://www.nuget.org/packages/Microsoft.AI.MachineLearning/
This package supports C# UWP Apps and Desktop .NET5 applications via the WinML API.

https://www.nuget.org/packages/Microsoft.ML.OnnxRuntime/
This package support C# .NET Standard 2 compatible apps via OnnxRuntime Managed API.

You should be able to perform Inference using DirectML as a backend with either of these options in C#.
Do these solutions meet your scenario?
Thanks,

Well Thanks for your quick response but I want to use DirectML to train ML.NET models . The above mentioned are all runtime for the model, they can't be used to train as far as I know.

Can you provide a pointer to the docs for the specific APIs that you're trying to use? I suspect there's some work that we've done that may be helpful, but we need a little more context.

I was trying to run a regression model using ML.NET in C#. I have an amd gpu , so can't use CUDA. Yeah , CPU can be used but it's dataset size is around 3 Gb ,to fasten it it would be nice if we had directML support in C#. I don't know anything about DirectML nor have learnt it. Excuse me, as I can't provide you with a pointer to the API docs


Add sync with map and filter legend config panel

The (?) button will show a tooltip explaining that feature

two different options? u sure?

Okay I'll let just one if you can always pick what you want to show on the legend, right?

closing this due final version here #5114


Aes reseed

This PR is, unfortunately, a little big due to changes on RTL side that voided my previous PR.
this PR contains 3 commits.

adding support for the sideload (keymanager sideload agent)
clean up of some lint issues
updates that supported the changes to :

aes_operation register
updates to support aes_aux_ctrl register
updates to support aes_regwen register
support for changes to the reseeding behavior

the first and second commit  compiles but tests will fail due to the changed behavior in RTL.
the 3rd commit has a lot of changes to the base sequence as the added registers and the reseed behavior changed a lot of the underlying behavior to get the tests passing again.

do we have a case that sideload is enabled via CSR, but key valid is low (due to a fault in keymgr or a FW configuration issue)? perhaps we should report an error for it. And we need to make sure if keymgr clears the key, AES should not use it.

this scenario is outside spec - the spec clearly states that you cannot enable sideload before the key is valid @vogelpi can you comment on what the behavior will be if sideload is enabled and the sideload key is not valid?

This is correct. If sideload is enabled before the sideload key is valid, the module will simply not start. What can be done in this case is to rewrite the control register twice ( == start a new message) after the sideload key is valid. Also the IV has to be provided again in this case.

do we have a case that sideload is enabled via CSR, but key valid is low (due to a fault in keymgr or a FW configuration issue)? perhaps we should report an error for it. And we need to make sure if keymgr clears the key, AES should not use it.

this scenario is outside spec - the spec clearly states that you cannot enable sideload before the key is valid @vogelpi can you comment on what the behavior will be if sideload is enabled and the sideload key is not valid?

This is correct. If sideload is enabled before the sideload key is valid, the module will simply not start. What can be done in this case is to rewrite the control register twice ( == start a new message) after the sideload key is valid. Also the IV has to be provided again in this case.

@weicaiyang  I think this is best handled in a directed test, I can add that later

sure, sgtm


bump HTTP compat to v1

Thanks!

@hustf  Can you please ping the registrator bot so this goes to the general registry?


VSCode/Win 11 Crashing/Freezing - requiring complete reboot

Issue Type: Bug
Hi, I am creating a PS script to connect to AzureAD and get data etc.
I am using Windows 11 and VSCode with the ISE and LiveShare extension, i keep getting interrupted because VSCode will freeze crash and often cause the whole OS will become unstable - Ctrl-alt-delete doesn't work so i have to  reboot laptop to restart work.
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz (8 x 2304)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.78GB (23.07GB free)

Process Argv
--crash-reporter-id e4a350d3-a179-43dd-b4a3-0f57180e612b

Screen Reader
no

VM
15%

Extensions (2)

Extension
Author (truncated)
Version

powershell
ms-
2021.12.0

vsliveshare
ms-
1.0.5273

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30425749
pythontb:30283811
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263cf:30335440
vscoreces:30384385
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dsc:30424895
pythonvs932:30410667
vscop804:30404766
vs360cf:30404996
vsclayoutctrc:30425945
vsrem710:30416614
vsbas813:30426126

@SteCCX Does the crash reproduce without using those extensions? If you are able to consistently reproduce, can you please follow the steps at https://github.com/microsoft/vscode/wiki/Native-Crash-Issues to create a .dmp file?

Hi, Thanks for the reply. I think the issue can be closed. I moved to ISE and the system was still freezing, leading me to think its more of a Windows 11 problem or perhaps MS ATP interfering (event viewer showed the service frequently needed restarting) as work have recently enabled this.
Anyway, the issue seems to have gone away since i joined the insider program and downloaded a cumulative win 11 update and the system is no longer locking up.


Delete R code (and move the functionality elsewhere)

the R code is a massive pain and it does not belong here.

acceptance criteria: no R code remains in hellbender (and no R code gets generated, eg  in VQSR) and code to make plots is migrated elsewhere (or ported to a JVM language). This ticket may be too large - in that case, split.

Could we change our tools so that they MAY produce plots if R exists, but we do not guarantee that they will?  We can spin the RScriptExecutor off into it's own repo and move all the R dependent tests there.


feat: port Algebra.Algebra.Spectrum

[x] depends on: #4804

This PR/issue depends on:

leanprover-community/mathlib4#4804
By Dependent Issues (🤖). Happy coding!

bors merge


Adding doc to goa swagger generator

Adding doc to goa swagger generator

@ibuziuk snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1916-1

Codecov Report

Merging #1916 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage   60.71%   60.63%   -0.09%
==========================================
  Files         143      143
  Lines       13183    13183
==========================================
- Hits         8004     7993      -11
- Misses       4464     4473       +9
- Partials      715      717       +2

Impacted Files
Coverage Δ

remoteworkitem/jira.go
75% <0%> (-25%)
:arrow_down:

remoteworkitem/scheduler.go
53.65% <0%> (-7.32%)
:arrow_down:

controller/workitem.go
81.84% <0%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad6e24...b98efc7. Read the comment docs.

@ibuziuk snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1916-2


Large Profit Bot -FP

Attacker: 0xdce95463e2f3f778bbebea3bf01d80fcf5736e14
AD Alert: https://app.forta.network/alerts/0x840a0ddfefc61a67bbdfc365cb856b106f4a1e4f5a5b798cc0b576e7cc30ebfb
Base bots:  Large Profit Bot and Large Transfer Out alerted
Potential cause: base alert is FP ,txn  treat aEthWETH same as WETH .

I'm not getting the FP alert locally, so I'm assuming there was a network issue with the price API.


Instance setup should set scheduler to none on systems using blk-mq

There's no kernel parameter for this yet; it must be done from userspace after boot.

@hopkiw isn't scheduler set by udev rules defined in https://launchpad.net/ubuntu/+source/gce-compute-image-packages:
cat /lib/udev/rules.d/99-gce.rules
# Give syslog write access to the kernel logs
KERNEL=="console", GROUP="syslog", MODE="0620"
# Switch to using NOOP as the default scheduler per GCE request
SUBSYSTEM=="block", ENV{DEVTYPE}!="partition", ACTION=="add|change", ENV{ID_VENDOR}=="*Google*", ATTR{queue/schedul
er}="noop"

for new kernel (> 5.3 https://wiki.ubuntu.com/Kernel/Reference/IOSchedulers) it should be none, not noop


[Hacktoberfest]: Add "Facebook F8" to the Conferences Section

🆕🐥☝ Beginners Only:
This issue is reserved for people who are new to Open Source. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
To do:

Add Facebook F8 to the Conferences Section
See below for link to step-by-step tutorial
Go down to Conferences section - it starts at around line 173
Using the following template, put in the correct info for that conference (Search for it on the internet to find the correct details) underneath the last row in the table, ensuring there is still an empty row before the next table.

| [Conference Name](Website Address) | Conference Name or Organising Org | 10 | Description of the Conferences, found on their website |

Add your details in the contributors section at the bottom of the page using the same formatting as the last one

📋 Step by Step
Step-By-Step Tutorial
Remember to observe the Code of Conduct - by which we mean, in short - Be Kind, Be Positive, Be Helpful

This should be closed with PR #174


pypy support

xref: https://github.com/conda-forge/climlab-feedstock/issues/63
xref: #88
xref: #129
Are we building for pypy or are waiting for pypy38 to renable it? I don't see pypy in #129

cc @conda-forge/pandas


⚠ Visual-Crew_Builder has degraded performance

In 080d4f2, Visual-Crew_Builder (https://visual-crew-builder.ai) experienced degraded performance:

HTTP code: 200
Response time: 1410 ms

Resolved: Visual-Crew_Builder performance has improved in a598030 after 15 minutes.


Show example out puts for versioning Scheme

#versioningScheme: 'off' # Options: off, byPrereleaseNumber, byEnvVar, byBuildNumber
The documentation does not show examples of what the versions will actually be for the various options. (Would save much time)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0fa37a3f-6551-16ad-e164-a4ac522cdaab
Version Independent ID: a3fd6935-2b99-92ef-4eb3-3249fca01f8a
Content: NuGet restore, pack, and publish
Content Source: docs/pipelines/tasks/package/nuget.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

@StevenTCramer Thanks for letting us know, I am assigning this to the author of the article to get it fixed.

@alexmullans hey, can we throw some examples inline here?

Sure.
For byPrereleaseNumber, the version will be set to whatever you choose for major, minor, and patch, plus the date and time in the format yyyymmdd-hhmmss.
For byEnvVar, the version will be set as whatever environment variable e.g. $(MyVersion) you provide, so make sure the environment variable is set to a proper SemVer e.g. 1.2.3 or 1.2.3-beta1.
For byBuildNumber, the version will be set to the build number, so you should ensure that your build number is a proper SemVer e.g. 1.0.$(Rev:r).

Awesome, thanks Alex. I hope this helps, @StevenTCramer , I'm adding this to the documentation as well to help future inquirers :)

Yes will save the next guy some time.  Thanks :)


Add logical (|| , &&, !) and rename functional versions

As of 0.10 R.or, R.and, and R.not all operate on functions. While this is certainly useful, the names sound more like functional implementations of the operators. The matching operator functions are not present in the library. We offer many other operator functions (R.add, R.eq, R.gt, etc),  and I think ||, &&, and ! are valid additions to complete the suite.
I propose:

R.or renamed to R.either
R.and renamed to R.both
R.or = (a,b) => a || b
R.and = (a, b) => a && b

! is a bit trickier. I'm having difficulty coming up with an intuitive name for the functional "not".
Logical "not" should certainly be R.not = (a) => ! a but best I have for functional not is R.opposite or R.notBy.
Thoughts?

in your proposal does the function || e.g. follow the javascript semantics of returning the first operand that is truthy (else false)? or should it be guaranteed to return a Boolean no matter what?

I can't remember the rationale (in #40) for removing these and renaming the old orFn, andFn, and notFn to or, and,and not.
It just seems funny to be thinking about going in the other direction now, although these are definitely better names.
The thing that concerns me about functions like these is that they will mislead users.  People are used to short-circuiting ors and ands in JS.  But, as parameters, these could never be short-circuited.  In true FP, of course, it should never matter, but it's easy to see someone trying to turn this:
if (obj && obj.prop) {...}

into
if (R.and(obj, obj.prop))

and not understanding why it now breaks.  Come to think of it, that might be the reason we dropped these functions in #40.

I think we should assume that users at least have a basic understanding
about how JavaScript function syntax works. This isn't #jQuery

@buzzdecade yeah, I'd choose not to coerce it to bool. Less for the user to have to learn.

If the user is blanket-replacing operators with functions they probably need the epiphany the bug may provide. There's always R.either if they need the lazy evaluation, or they could just use the operator.

There's always R.either if they need the lazy evaluation, or they could just use the operator.

Right, but that could also be an argument against including these functions.
I'm not actually really opposed.  But I am tired of having functions renamed or disappear.  I'm really ready for our API to settle down.  (That's mostly me being grumpy; I do want to figure all this stuff out right ahead of 1.0.)
I guess I'm looking for a stronger case than "wouldn't it be nice if...?"

I agree with settlement on names.so we just need to decide if we're never
providing these operators as functions, because if we do then there aren't
more intuitive names than || == or and we'll have to rename. Better to do
it now than post 1.0
On Feb 26, 2015 10:31 AM, "Scott Sauyet"<EMAIL_ADDRESS>wrote:

There's always R.either if they need the lazy evaluation, or they could
just use the operator.
Right, but that could also be an argument against including these
functions.
I'm not actually really opposed. But I am tired of having functions
renamed or disappear. I'm really ready for our API to settle down. (That's
mostly me being grumpy; I do want to figure all this stuff out right
ahead of 1.0.)
I guess I'm looking for a stronger case than "wouldn't it be nice if...?"
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/issues/843#issuecomment-76236534.

i also do not recall the rationale for excluding the simple boolean operator functions. I am also tired of the API changes, but I do believe the worst is behind us.

I like:

R.or renamed to R.either
R.and renamed to R.both

For R.not, how about R.nix?

R.nix is better than anything else I came up with. I hope R.either doesn't get confused with the monad.

I prefer negate to nix.  "Nix" sounds more to me like "decide against" rather than "the opposite of" or "the inverse of".

Isn't there already R.negate?
On Feb 26, 2015 8:13 PM, "Scott Sauyet"<EMAIL_ADDRESS>wrote:

I prefer negate to nix. "Nix" sounds more to me like "decide against"
rather than "the opposite of" or "the inverse of".
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/issues/843#issuecomment-76327921.

Oh yeah, I guess that's a problem...  :smile:

belie? gainsay? refute?  I think I'm starting to like nix!  :smile:

:thumbsdown: on these functions. || has been a significant source of bugs in this project, and many others I'm sure. It should only be used on Boolean values: the arbitrary distinctions between "true" and "false" values for other types lead to unclear and sometimes incorrect programs.
Interestingly, Sanctuary's or function does have type a -> a -> a, though its behaviour is very different from that proposed in this issue:
S.or([], []);  // => []
S.or([], [99]);  // => [99]
S.or([42], []);  // => [42]
S.or([42], [99]);  // => [42]

S.or(S.Nothing(), S.Nothing());  // => S.Nothing()
S.or(S.Nothing(), S.Just('bar'));  // => S.Just('bar')
S.or(S.Just('foo'), S.Nothing());  // => S.Just('foo')
S.or(S.Just('foo'), S.Just('bar'));  // => S.Just('foo')

@davidchambers I'm not sure what your actual objections are.

I guess the real problem is that no one has come up with a strong use case for operator functions. My proposal boils down to "We have other operators, we should have &&, ||, and ! for consistency and completeness". I guess we can close this until the value is made clear. Still, I worry that if we do change it later the api will be so stable that we'll have to come up with silly names for the operator versions.

@davidchambers I'm not sure what your actual objections are.

Fixes for Ramda bugs caused by incorrect use of &&, ||, and !: #236, #496, #505, #507, #533, #785. I'm sure many similar bugs are still to be discovered.
I don't endorse function equivalents of these operators unless they are much stricter. All three functions should only accept Booleans (and possibly types which provide a suitable hook such as an or method).

@jethrolarson did you want to do a PR on this? Looks like you may face some resistance, but I think there is a good case to be made for having straight boolean operator functions. In any event, we should settle on this before 1.0

As this was just brought up again in Gitter, I think it's worth pursuing.
I don't share David's worries about coercing to booleans.  Yes, it can be used incorrectly, but it is also very useful, and is is how people are using -- and how they want to use -- Javascript.  I've had codebases where I insisted on forcing to booleans.  There are good reasons in some circumstances to be worried.  But I don't think that's the concern of a library like Ramda.  And my biggest concern about a [Bool] -> Bool version would be how often we had to explain it, and that we'd end up adding a coerce function and telling all the complainants to map(coerce) before calling or.  Something just seems wrong with that.
I still wish I could remember why we dropped the older versions of these functions.  Maybe it was simply to make way for the current functions (which still seem to me the more useful ones) to claim the best names.

Sure. I'll see if I can whip it up.

Feels weird that the sig for both of them is * -> * -> * but it also feels right in a way.

I didn't feel comfortable switching R.not to R.nix so I'm leaving that out for now.

At behest I've added R.nix to the PR. R.anti doesn't sound like a verb to me. Ixnay the ooleanbay!

ha, i like ixnay

Should we add to this to some upgrade guide once it's in?

Should we add to this to some upgrade guide once it's in?

When we release 0.12.0, yes.


Remove Karma flakiness by providing browser shims

This fixes the travis karma flakiness, and removes the allowed failure. This does this by adding in airbnb-browser-shims to the karma tests so that we don't have to worry about which version of chrome they are running on.

This appears to have not actually fixed the flakiness.... so it seems like this is not the reason for the karma flakiness :/

@lelandrichardson it did fix flakiness caused by lack of polyfills,it just didn't fix the other cause of flakiness,some tests appear to cause a full page reload. This shoudl still be merged

@nfcampos any thoughts on how to fix the page reload issue? It'd be nice to fix karma in a single PR if possible.

Rebased this on top of #1096.


pm: s/power-domain/power-domains and add power-domain-names

Some devices may belong to >1 power domain, so with the current design this is something not possible to describe. It's worth to note that Linux also uses the power-domains naming scheme, not power-domain. This patch also introduces power-domain-names so that each entry in power-domains can be given a name if needed.

@gmarull  does Zephyr support multiple power domains attached to a device? Or this is just a name change for a property and the support for multiple power domain is in progress?

@gmarull does Zephyr support multiple power domains attached to a device? Or this is just a name change for a property and the support for multiple power domain is in progress?

Zephyr does not support them, but I need to describe peripherals that belong to >1 in an upcoming PR.


Change tag to
...

It seemed strange to me that there is a nav tag in the footer tag.

Hey @snxx-lppxx  thx for the PR. Although a  is perfectly fine inside a  it's true that it's probably overly verbose (and mozilla actually lists this as an example where a  is not necessary). But I'm not too happy having the
 in there either since it's already in a  element which is redundant. If you change the
 to a
 I'd be happy to merge this.


This basic DDL cannot be parsed

ddl.zip

Hi @PhBastiani
Thanks a lot for the report, it was due to forgetting \r ^^
It's fixed now :smile:

Fixed with side effect on the display

Hi @PhBastiani
You had no luck of trying it just during the rollout of a bug ^^
It's fixed now.
Can you check this and close the issue if it's fine ?
Thanks!

Great success :)


Remove vue-chartjs

The last update of vue-chartjs was a year ago. Should be removed.

Seems it's getting updated pretty often novadays.
https://www.npmjs.com/package/vue-chartjs


Where should I define the configuration ?

Hi!
First, thanks you for making this !  All other Musicbrainz gems seems outdated since a long time ago.  Yours is more than welcome !
I'm a Ruby newbie so sorry for this question :
Where should I define the configuration ?
MusicBrainz.configure do |c|
  c.app_name    = 'MyApp'
  c.app_version = '0.0.1.alpha'
  c.contact     =<EMAIL_ADDRESS>end

client = MusicBrainz::Client.new

I would like it to be shared by several files within my app, should I put this somewhere in /config ?
Thanks !

MusicBrainz.configure defines a global configuration.
You can then initilaze a Client wherever you want.
For example, in a Rails application :
# config/initializers/musicbrainz.rb

MusicBrainz.configure do |c|
  c.app_name    = 'MyApp'
  c.app_version = '0.0.1.alpha'
  c.contact     =<EMAIL_ADDRESS>end

# app/models/artist.rb

class Artist < ApplicationRecord
  def client
    @client ||= MusicBrainz::Client.new
  end

  def assign_musicbrainz_uuid
    self.musicbrainz_uuid = client.artists(name)[0].id
  end

  def musicbrainz_data
    client.artist(musicbrainz_uuid)
  end
end

Thank you so much !


Oracle db metadata reader

Implement Oracle metadata reader. Since it's used by two drivers, I've put it into a standalone module.
Since there's a ton of schemas, and Oracle's catalogs are terribly slow to read, I tried implementing dynamic filtering to skip all of them except the one matching the current user. This has a somehow surprising effect where you don't get any results unless you use commands like \dtS sometable%. I thought it's an issue with binding params, lost 3 hours staring at the screen, and implemented support for ECHO_HIDDEN setting. I went ahead and added it for all readers, since it will be very useful for debugging.
We need to circle back around filtering out system objects. Doing this in the writer is ok-ish for most databases, but too late or Oracle. I should probably remove it for Oracle completely.
Closes #174  and closes #153

I just found out that Trino considers these schemas to be internal:
            .add("ctxsys")
            .add("flows_files")
            .add("mdsys")
            .add("outln")
            .add("sys")
            .add("system")
            .add("xdb")
            .add("xs$null")

Ok I made the list of Oracle's system schemas constant.

I wasn't able to merge this change, as it conflicts drastically with the other metadata ones. You seem to have 2 different APIs in play here?

I wasn't able to merge this change, as it conflicts drastically with the other metadata ones. You seem to have 2 different APIs in play here?

I was expecting conflicts because I also implemented ECHO_HIDDEN in this PR. At least it's a separate commit at least. Anyway, I resolved them and It should be ready for merging now.


Reset dev database

[x] clear the data and schema from the eil_db_1 database
[ ] drop the eil_db_1_cp database
[x] restart the database-api and ensure it runs without error to setup the new schema
[ ] figure out how to test something to ensure the database is still working.
[ ] create bug tickets for code owners if anything comes up

Dropping schemas and recreating public
DROP SCHEMA ADMIN CASCADE;
DROP SCHEMA public CASCADE;

CREATE SCHEMA public AUTHORIZATION postgres;

figure out how to test something to ensure the database is still working.

The easiest way is to use Showcase App to ensure everything is set up well.
If we need some kind of smoke testing in runtime, we may implement that in database-api in some rest endpoint


added support for disk encryption based on existing AMS KMS key

This PR contains additions to the AWS config template and property replacement within the BOSH manifest to enable AWS disk encryption.

pulled in following https://github.com/cloudfoundry/bosh-deployment/pull/223


RHBRMS-2651: Validation messages in DRL files are being multiplied by the number of KBases models kmodule.xml

See https://issues.jboss.org/browse/RHBRMS-2651
@mariofusco Hi Mario, this PR contains an ignored failing unit test demonstrating the reported problem.

Jenkins please retest this.


add emoji code for flag of sri lanka

@isurunuwanthilaka  yeah  header file already got correct unicodes for Sri Lanka flag. Btw we can use this issue to add it to README as @anjulalk  mentioned


added the following inherited methods to the docs:

get_params
score
set_params

Simply removing the list of inherited classes from inherited-members automatically adds all the members of all the inherited classes to the docs? The three new functions will appear in our documentation with their corresponding definition from scikit-learn?

Yes, this is the case. The docs on https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html say the following:
For example; If your class Foo is derived from list class and you don’t want to document list.len(), you should specify a option :inherited-members: list to avoid special members of list class.
It's a bit strange and also in combination with other options I do not see a consistent way how sphinx handle the different settings.


Plans to add Multi thread?

Hi!
First of all , you have done a great job developing this library.
Has any plan to addd Multi thread  support to this library?
Regards!

Unfortunately I don't have any plans to add support for threading myself. If you'd like to work on it I'm open to PRs :)


docs: Adding 'Troubleshooting' to the 'Migrating to devfile v2' docs

Signed-off-by: Ilya Buziuk<EMAIL_ADDRESS>Related issue - https://github.com/eclipse/che/issues/21005

@l0rd thanks for review, I have set a clear context for the troubleshooting section

Other tools could contribute to this doc by adding another tool specific section e.g. odo errors after the devfile v2 migration

@rkratky could you please review
my understanding is that once merged the docs team will cherry-pick it to relevant branches.

@rkratky thanks, the suggestions have been applied


Add high-level future

TODO: Add test
TODO: Are there race conditions?

Could you also add an example?
Though I'm wondering if this is worth maintaining anymore since it appears the Rust community is centering around polling as the generic fd-polling reactor of choice.


Missing target Threads::Threads when building with CMake 3.21.1

I get many errors like the following when configuring MFEM 4.3 with CMake 3.21.1:
CMake Error at config/cmake/modules/MfemCmakeUtilities.cmake:60 (add_library):
   Target "mfem" links to target "Threads::Threads" but the target was not
   found.  Perhaps a find_package() call is missing for an IMPORTED target, or
   an ALIAS target is missing?
Call Stack (most recent call first):
   CMakeLists.txt:474 (mfem_add_library)

Adding a call to find_package(Threads REQUIRED) in the top level CMakeLists.txt file fixed it for me.

The Threads package is not directly needed by MFEM, there must be an optional package you are using that needs that. Can you post the full cmake command you are using?


[BUG] "Check Versions" option - bad version detection

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
After using the "Check Versions" option, it detects an incorrect current version. From my observations, it checks the final number and if it is larger, it considers it a newer version, and it should check each of the 4 elements and if one of them starts to differ (it will be a higher number) it should be considered the latest version.

Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Mod Assistant Version: 2.0.9
- OS: Win10 22H2
- Virtualized: No

Anything else?
No response

Grrr.  This one bugs me.  I can't begin to say how many really good libraries are available the compare semver versions.  But of course, these are not semver, just sorta close.  Thanks for catching this :)  (of note, this also has to be able to call back on simple string comparison, because "Beta-0.1" is a totally valid version so far as the game is concerned, even if they won't let it on modhub)

Turns out I was only doing half the comparison.  If it would have grabbed the <IP_ADDRESS> CP version first, it would have detected that 2 is bigger than 1 and set the "best" version to <IP_ADDRESS> - but when it grabbed <IP_ADDRESS>, 1 isn't less than 2, but the 2 of <IP_ADDRESS> is bigger than 0, so it reset it.  Both directions covered now. Thanks again.

closing as complete


haskellPackages.req: fix build, update default version

Motivation for this change
haskellPackages.req doesn't build due to upstream's failing tests; default package version is outdated.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I disabled the test suite in https://github.com/NixOS/cabal2nix/commit/5a860e4c5a38beab6ecfca908e39ce67acdea79e. The new version of the build will arrive in master within a few days.

@peti re: edit, sorry, I just grepped through. Shall be more diligent next time.
Thanks for detailed comments and a quick update.


VISUALS (SPECS): Menu (via Work Items kebab)

Verification Requirements:
Refer to previous visual story: VISUALS: Menu (via Work Items kebab), then:

Add specifications to previous visuals work
Post new visual specs to InVision, review with UX team members
Link to InVision prototypes from this story
Tag story as "Ready for Development"

Posted mockup & specs to InVision

@bdellasc - is this complete and ready to close?

Yes, sorry. Closing it now.


Clarified remark about authorizers determining groups

The old text said that this is expected, which does not match
my understanding.  The new text says that it is allowed,
and none of the standard authorizers does so.

This change is

@devin-donnelly see the revised submission.

@lavalamp @devin-donnelly is there anything I need to do in order to move this forward?

I don't actually understand the relevant system enough--if my suggestion is
as far off as it sounds like it was, perhaps that is an indication that
this paragraph could use significant expansion, or added definitions.
On Tue, Oct 4, 2016 at 9:04 PM, Mike Spreitzer<EMAIL_ADDRESS>wrote:

@MikeSpreitzer commented on this pull request.
In docs/admin/accessing-the-api.md
https://github.com/kubernetes/kubernetes.github.io/pull/1303:

@@ -52,8 +52,10 @@ On GCE, Client Certificates, Password, Plain Tokens, and JWT Tokens are all enab
If the request cannot be authenticated, it is rejected with HTTP status code 401.
Otherwise, the user is authenticated as a specific username, and the user name
is available to subsequent steps to use in their decisions.  Some authenticators
-may also provide the group memberships of the user, while other authenticators
-do not (and expect the authorizer to determine these).
+also provide the group memberships of the user, while other authenticators
+do not.  An authorizer may determine as well as use groups (or any other

@lavalamp https://github.com/lavalamp Thanks for the review. I am not
sure I understand it. Why do you think the reader might imagine group
information comes from something besides the authenticator or internal
activity of the authorizer? What exactly do you mean by "source"? Clearly
some code running in the apiserver can not itself be an "ultimate" source,
it could only derive group information by some means from some thing(s). I
am not sure I understand the distinction you are asking about between "use
groups from some other source" vs "itself be a source of groups".
I fear we may be working too hard to document something that is, as far as
I know, entirely hypothetical (no authorizers known to me behave as we are
trying to document). Perhaps the better part of valor is to simply delete
the hypothetical discussion, and let the text end with "Some authenticators
also provide the group memberships of the user, while other authenticators
do not".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/pull/1303, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAngli2CcJl9i-QBM-oo52NT70TpL4OOks5qwyHYgaJpZM4KGBep
.

@lavalamp: in that case, can we get a review from someone more familiar with the subject matter?

I'm not completely unfamiliar with this system :)
Honestly I think the sentence about "determine as well as use" is legitimately unclear--if I can't understand it, I don't think others reading this document will, either. I actually recommend just dropping the whole sentence. I don't think the inner details are relevant. Alternatively, move this sentence into the below section. I've just realized that a large part of my confusion is due to a sentence about authorizers being in the section about authenticators.
Actually this whole document seems pretty weirdly targeted, but that's not your problem to fix :)
@deads2k @erictune is it true that either the authn OR the authz step could decide group membership? Why on earth did we do that?

@deads2k @erictune is it true that either the authn OR the authz step could decide group membership? Why on earth did we do that?

It's an internal detail I wouldn't expect to be exposed to users generally, but yes, it can be done.  @erictune and CoreOS had use-cases for large numbers of groups which they didn't want to resolve unless absolutely necessary.  As I recall, they even went so far as to load "likely matches" first.
In any case, the group determination inside of an authorizer should be entirely hidden from general user-facing documentation and be left as a detail in the authorizer which (hopefully) doesn't require external configuration for a group weighting.
Also, I don't know of any authorizer that actually got built using that feature, but I think that CoreOS carries a fork of the api server.  Again, I wouldn't expect it to leak into the general kube docs.

I would be quite happy to strike all the verbiage here about authorizers determining/deriving group info, on the grounds that internal workings of some authorizers do not belong in documentation about the framework.

@lavalamp @deads2k please see latest revision.

lgtm

lgtm


Add stub tests for multisegment extractor

At the moment the stubbing machinery is not working with multi segment extractors:
See:
https://github.com/TheChymera/neuralynx_nwb/issues/9
The problem is that frame_slice, the method that we use to stub in spikeinterface, does not support multi segment recording objects. It is not clear to me yet where this should be fixed, most likely at the spikeinterface level but I need to discuss with @alejoe91.
In the meanwhile this PR does two things:

It adds a new generator interface for testing ecephys interfaces. Most of the tests that we have work only at the recorder level so this will allow us to test behavior at the interface level. Right now, it probably needs some work but at this stage it works for testing his behavior and we can build from that as needed.
Tests for stubing and mult-segment stubing.

EDIT: OK, I talked with @alejoe91 and he does not want the frame_slice to handle multi-segments as he does not believe that the use-case is enough to justify the increase in API complexity. Therefore, I am implementing the logic for stubbing here.

All is pasing. Dev tests are failing for reasons unrelated to this.

Looks good for the most part - one comment about where to put the testing interface, once that is resolved it should be good to go
Thanks for the tests as well!

Amazing, thanks!


Better README

badges, install instructions, import, mac & linux

As far as I can see it's now done by @skreutzberger .


Page ordering raises PermissionError

Issue Summary
When sorting pages (from the menu option "sort menu pages") nothing happens due to a 'permission denied' error:
wagtail.core.actions.move_page.MovePagePermissionError: You do not have permission to move the page to the target specified.
"POST /admin/pages/627/set_position/?position=4 HTTP/1.1" 403 135

Steps to Reproduce

Create a website with a page, and within that page two or more subpages
Try to reorder these subpages
The page order doesn't get saved

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: (~yes~ / no)

Technical details

Python version: 3.8.2
Django version: 3.2.12
Wagtail version: 2.16.1
Browser version: Firefox 96.0.3

What have I found out already?
Within admin/views/pages/ordering.py, in the method set_page_position, the following occurs on line 34 and further:
if position_page:
    # If the page has been moved to the right, insert it to the
    # right. If left, then left.
    old_position = list(parent_page.get_children()).index(page_to_move)
    if int(position) < old_position:
        page_to_move.move(position_page, pos="left", user=request.user)
    elif int(position) > old_position:
        page_to_move.move(position_page, pos="right", user=request.user)

I think that the move method on the page_to_move thinks that position_page wants to be its ancestor or something.

This was a sloppy issue, I created it in a hurry and therefore I closed it.


PPL Migration

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

This PR implements the migration towards a PPL (packed project libraries) based build for the FPGA Addon custom device.

Why should this Pull Request be merged?

Updates the project build specs from source distributions to packed project libraries.
Updates Engine code to ensure PPL compatibility.
Updates the custom device XML configuration file.
Removes obsolete targets support.
Updates system tests.
Updates unit tests.

What testing has been done?
Both the unit and the system tests are passing.

Referencing #139.

I saw this PR had not built yet, so I kicked one manually. It looks like the first one failed to clone the repo randomly.

I saw this PR had not built yet, so I kicked one manually. It looks like the first one failed to clone the repo randomly.

Hey @Karl-G1, I noticed the manual build passed, but no diffs were generated. Do you have any idea why we have no diffs? Thanks!

@phutanu @DStavilaNI
The diff pipeline is timing out after an hour. 160 files may be too large for one PR if you want a visual diff, or you can work with @buckd to increase the timeout in certain cases.

Is there a reason for doing this?

When you can already do this in LabVIEW:

How do we validate that the dependency was added successfully if the code does not report any error when the refnum is invalid?

Shouldn't we close also this references after deleting the child nodes?

Are we validating this path somewhere?

Why do we include dependencies for all the targets in the XML, when only Windows and Linux_64 targets are supported for the next VeriStand release?

Should we report an error in case the "Generated files in" array is empty?

This can be included as a global variable and in case the Build Spec name for the configuration changes, it is an easy fix to change this globally.

Can you please explain me more on why we close all the node references when the "Supported Target Type" is empty?

We should validate this path before executing the code.
Can you please explain more regarding the "filtering" for Custom Device versus Custom Devices?

Why are we closing this tag in both cases? This is not the case for other code submitted, and I am wondering why we decided to do it for this particular node.

Typo.

Why are we closing this reference? I would expect to have parity. If we open the reference outside of this VI, to close it when we are sure we are done with it.

Regarding all the existing System Level tests that were modified in this PR.
We should not add mutation code to those before deploying, instead we should update the test assets (system definition files, etc) to the latest FPGA Addon version.
If we want to test mutation code specifically, let's add a specific test/tests for this.
We should not make system level tests dependent on mutation code/VIs. This is not reproducible, and not a good practice.

Is there a reason for doing this?
When you can already do this in LabVIEW:
Also, this error cluster has got into a fight.

Implemented

How do we validate that the dependency was added successfully if the code does not report any error when the refnum is invalid?

Implemented

Shouldn't we close also this references after deleting the child nodes?

No, it is deleted automatically by the "Remove Child" method.

Why do we include dependencies for all the targets in the XML, when only Windows and Linux_64 targets are supported for the next VeriStand release?

implemented

Should we report an error in case the "Generated files in" array is empty?

Implemented

This can be included as a global variable and in case the Build Spec name for the configuration changes, it is an easy fix to change this globally.

I disagree and I think it would be unnecessary to do this kind of refactor here. If required, it could be done as part of a separate PR. As a matter of coding preference - I do avoid using Global or Local variables, unless completely necessary.

Can you please explain me more on why we close all the node references when the "Supported Target Type" is empty?

This code is redundant, so it was removed.

We should validate this path before executing the code.
Can you please explain more regarding the "filtering" for Custom Device versus Custom Devices?

Define "Validate" please. At this point in the code, we do not care yet if the project file exists or not at that particular location - this will happen later, once we attempt to open the Configuration XML derived from that path - and if it does not exist, an error will be thrown. What we care about here, is we can find an expected name and location for a CD XML file. This is based on the naming convention for custom devices - at least those generated via the LV CD Wizzard.  The XML file has to be somewhere on the project directory, and typically, it will have a format like  "Custom Device " or "Timing and Sync " depending on the CD type.
What the code does, is attempt to find the CD configuration XML based on the project name and location -> this implies that the custom device is following the VS CD Conventions.

Why are we closing this tag in both cases? This is not the case for other code submitted, and I am wondering why we decided to do it for this particular node.

This reference is not further needed, hence it is closed. There is no particular reasoning behind it - it was a simple styling choice

Typo.

Implemented

Why are we closing this reference? I would expect to have parity. If we open the reference outside of this VI, to close it when we are sure we are done with it.

There is parity. The reference is opened (and closed) within the same context.

Regarding all the existing System Level tests that were modified in this PR.
We should not add mutation code to those before deploying, instead we should update the test assets (system definition files, etc) to the latest FPGA Addon version.
If we want to test mutation code specifically, let's add a specific test/tests for this.
We should not make system level tests dependent on mutation code/VIs. This is not reproducible, and not a good practice.

If dedicated tests are necessary to test specifically mutation, this can be done as part of a separate PR.
Regarding this specific implementation choice -> As it is, this implementation has the advantage that the "mutation" code can easily be disabled if need be (for instance for debugging or other purposes). Since the assets are unmodified, they can be used to test a wider range of functionalities, pertaining to older versions of the CD.
That being said, I did suggest during our sync-ups, that I would like to update the test assets to reflect the changes to the custom device, however, if I recall correctly, the decision was taken to not do so.

Abandoning this PR. We are currently not pursuing this modification to the custom device.


Add EditorConfig support

Haven't added any tests yet. Only tested zip export. Tried to match the existing style, but see how this looks and I'll make changes / finish it up.

Sorry for the delay.. I've been busy the past days. There are still some issues.

No rush, will fix the rest of these sometime next week.

If you're not comfortable with java, I can adjust that part accordingly.
Haven't looked at it yet, but shouldn't be an issue.

FYI: I forked your branch and applied some long overdue update to the code.

Moved from webpack to parcel
Upgraded all dependencies
Moved from javafx to electron for the cli version
extracted common logic into a new file loader.ts
added autodetection for code writer options in case no editorconfig exists.
https://github.com/Lusito/web-ext-translator/tree/version-3

It still needs a bit of testing and cleanup, but I think it's a good step forward.

Oh, nice work! I'll try testing it out later and report back.
I'll close this too, then.

Thanks for the work!

@Lusito version-3 branch doesn't work for my test case loading from zip. No error, just silently fails.
Archive.zip

Fixed it @hensm

@hensm and @rugk version 3 is getting closer to being released. If you could test it, that would be very helpful.

git clone https://github.com/Lusito/web-ext-translator.git
cd web-ext-translator
git checkout version-3
npm i
npm start => will start a local server at localhost:1234
cd wet-cli
npm i
npm run build => app must be build first
npm start => will launch desktop app.

Thanks!

Only tested import/export with changes, but seems to work just fine and .editorconfig formatting is all good for my test case.


ast: ArrayExpressionElement vs ExpressionArrayElement is confusing

AstKind has two variants with almost identical names:

AstKind::ArrayExpressionElement(_) which contains an ArrayExpressionElement
AstKind::ExpressionArrayElement(_) which contains an Expression.

From digging around the code, it looks like ExpressionArrayElement is visited when an ArrayExpressionElement contains an Expression
    // crates/oxc_ast/src/generated/visit.rs, line 1662
    #[inline]
    pub fn walk_array_expression_element<'a, V: Visit<'a>>(
        visitor: &mut V,
        it: &ArrayExpressionElement<'a>,
    ) {
        let kind = AstKind::ArrayExpressionElement(visitor.alloc(it));
        visitor.enter_node(kind);
        match it {
            ArrayExpressionElement::SpreadElement(it) => visitor.visit_spread_element(it),
            ArrayExpressionElement::Elision(it) => visitor.visit_elision(it),
            match_expression!(ArrayExpressionElement) => {
                visitor.visit_expression_array_element(it.to_expression())
            }
        }
        visitor.leave_node(kind);
    }

Is this intentional? If it is, we should document the difference between the two since it's quite confusing. If not, we should remove one of these in favor of the other.

I would like to remove these "special cases" like ExpressionArrayElement entirely. As you say, it's confusing, and it complicates our code. If we get rid of it, then you can still figure out if the Expression you're visiting is an element of an ArrayExpression or not - just look up the parent.


[Bug] [API] NullPointException occurs when creating Prometheus configuration

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

What you expected to happen
生成Prometheus配置时，程序运行正常
How to reproduce
在PrometheusActor类的130增加判空处理
Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

#332


TypeError: Cannot read properties of undefined (reading 'events')

Describe the bug
After mock contract deployment, it just throws the exception.
Reproduction steps

Create a very basic contract
Initialize a simple test suite and use @defi-wonderland/smock later version with Hardhat latest version
Deploy the mock contracts on the test suite
Run the unit test and observe it failing throwing the exception Cannot read properties of undefined (reading 'events')

Expected behavior
A clear and concise description of what you expected to happen.
It should throw exception after mock contract deployment in before or beforeEach hooks
The exception to throw: Cannot read properties of undefined (reading 'events')
Screenshots
If applicable, add screenshots to help explain your problem.

System Specs:

OS: Pop_OS
Package Version (or commit hash): ^2.3.0

Additional context
Add any other context about the problem here.

yoo @carlomigueldy, code looks solid to me, have u tried a beforeAll instead of before?
blz submit full SavePakistanSmock.ts to give a proper-er advice

yoo @carlomigueldy, code looks solid to me, have u tried a beforeAll instead of before? blz submit full SavePakistanSmock.ts to give a proper-er advice

gm bro, unfortunately there is not beforeAll available only before and beforeEach and so I tried beforeEach and still throwing the same exception
Here be the entire test suite as you ask:
import { MockContract, MockContractFactory, smock } from "@defi-wonderland/smock";
import { SavePakistan, SavePakistan__factory } from "../typechain-types";
import chai, { expect } from "chai";
import { TokenVariant } from "../utils";
import { BigNumber } from "ethers";

chai.should();
chai.use(smock.matchers);

describe("Smock: SavePakistan", () => {
  let savePakistanFactory: MockContractFactory<SavePakistan__factory>;
  let savePakistan: MockContract<SavePakistan>;

  before(async () => {
    savePakistanFactory = await smock.mock<SavePakistan__factory>("SavePakistan");

    savePakistan = await savePakistanFactory.deploy();
    console.log("savePakistanMock.address", savePakistan.address, "...");
  });

  it("should be cool", async () => {
    console.log("COOL");
  });

  // it("should make it", async () => {
  //   console.log("savePakistanMock.address", savePakistan.address, "...");
  //   savePakistan.mintByPayingEth
  //     .whenCalledWith(TokenVariant.HygieneKit, BigNumber.from("1"))
  //     .returns(undefined);
  // });

  // it("should mock the shit out of it", async () => {
  //   savePakistanMock.USDC_ADDR.returns("carlo");

  //   const usdcAddr = await savePakistanMock.USDC_ADDR();
  //   console.log("usdcAddr", usdcAddr);
  // });

  // it("should call getters", async () => {
  //   expect(await mock.count()).to.equal(1);
  // });

  // it("should call methods", async () => {
  //   await mock.add(10);
  //   expect(await mock.count()).to.equal(11);
  // });

  // it("should be able to override returns", async () => {
  //   mock.count.returns(123);
  //   expect(await mock.count()).to.equal(123);
  // });

  // it("should be able to override a function that reverts", async () => {
  //   mock.doRevert.returns(true);
  //   expect(await mock.doRevert()).to.equal(true);
  // });

  // it("should be able to check function calls", async () => {
  //   await mock.add(10);
  //   expect(mock.add).to.be.calledOnceWith(10);
  // });
});

Copied and run, it works cool.
Because of our repo structure, I had to change the import to:
import { SavePakistan, SavePakistan__factory } from "../../typechained";

Idk if it had something to do...

damn, can you share me your repo + dependencies? lol

Sure fren, i'd recommend it to bootstrap and boost-up any project:
https://github.com/defi-wonderland/solidity-hardhat-boilerplate

Sure fren, i'd recommend it to bootstrap and boost-up any project: https://github.com/defi-wonderland/solidity-hardhat-boilerplate

The suggested template/boilerplate for Hardhat works very well!
So I feel safe to close this issue as this template works the best :+1:

I'm having this issue as well - @carlomigueldy did you ever figure out why the repo structure caused this error?


cannot pass props to children of a Responsive component

I am using the common use case indicated in the ReadMe:
const Desktop = props => (
  <Responsive {...props} minWidth={1680} maxWidth={2560} />
)
const LaptopL = props => (
  <Responsive {...props} minWidth={1440} maxWidth={1679} />
)

...
and I have a prop (bottleState) that I am trying to pass to specific components inside the Responsive component (eg Desktop)
const WineHeader = ({ bottleState }) => (
  <HeaderCard>
    <Desktop>
      <WineBox />
      <WineBackgroundBox />
      <VineyardBackgroundBox />
      <WineInfoContainer>
        <LeftContainer>
          <WineTypeBox bottleState={bottleState} />
          <WineTitleBox bottleState={bottleState} />
          <WineDescriptionBox bottleState={bottleState} />
        </LeftContainer>
        <WineProperties />
      </WineInfoContainer>
    </Desktop>

    <LaptopL>
      <WineBox />
      <WineBackgroundBox />
      <VineyardBackgroundBox />
      <WineInfoContainer>
        <LeftContainer>
          <WineTypeBox />
          <WineTitleBox />
          <WineDescriptionBox />
        </LeftContainer>
        <WineProperties />
      </WineInfoContainer>
    </LaptopL>
     ...
  </HeaderCard>
)

WineHeader.propTypes = Object.freeze({
  bottleState: PropTypes.object, //eslint-disable-line
})

export default WineHeader

When logging the bottleState prop in one of the above child components in which I am trying to access it - it is not available (the log returns undefined) :
const WineTypeBox = ({ bottleState }) => (
  <WineTypeStyle>{console.log(bottleState)}</WineTypeStyle>
)

> undefined  ---- WineTypeBox.jsx?a13c:36

and when I simply remove the Responsive component, I can access the bottleState prop as expected:
const WineHeader = ({ bottleState }) => (
  <HeaderCard>
    <WineBox />
    <WineBackgroundBox />
    <VineyardBackgroundBox />
    <WineInfoContainer>
      <LeftContainer>
        <WineTypeBox bottleState={bottleState} />
        <WineTitleBox bottleState={bottleState} />
        <WineDescriptionBox bottleState={bottleState} />
      </LeftContainer>
      <WineProperties />
    </WineInfoContainer>
    ...
  </HeaderCard>
)

returns the bottleState object when logged to the console:
{wineCollection: "Classics", wineType: "Semi Sweet Red", bottleName: "Khvanchkara", bottleImage: Array(1), bottleNoteText: "
test
", …}
bottleImage: ["http://localhost/uploads/bottle.png"]
bottleName: "Khvanchkara"
bottleNoteText: "
test
"
temperatureHigh: null
vintage: null
volume: null
wineCollection: "Classics"
wineType: "Semi Sweet Red"
__proto__: Object ---- WineTypeBox.jsx?a13c:36

Any ideas why this is the case? I have tried defining the desktop function inside the WineHeader functional component, because that is the function where I am pulling off the bottleState prop from this.props but this doesn't change the behaviour; when throwing a debugger before the return statement of the Desktop component, I can clearly see the bottleState prop being passed in, I do not even need it to be passed in as I am directly passing it into other components nested further down the DOM tree without any issue when the Desktop Component is not wrapping them, but the fact that my other components that need to access this prop are nested inside the Desktop component is causing the props to be blocked for some reason. Any help is greatly appreciated. Thanks,
Corey

Can you make a codesandbox for this? I'm almost 100% sure this is something else in your stack - if it was a bug in this module we would probably have hundreds of bug reports about it already.

You are 100% correct; I will go ahead and close this. Thanks for your timely reply and for this awesome module!
Corey

@coreycosman No worries 👍