Want to translate to Arabic, Japanese, French, etc.?

Starting to translate to Korean.
Feel free to collaborate.
Check it out here.

Awesome! Anybody here that has a translation that is completed I will link to in a Translations section! Thanks for your help 😄

Starting to translate to Chinese, please check here , when I finished the translation, there will be a pull request!

@beginor i have the same idea, let's do this.

I started with the german translation. There will be a pull request soon!

@Hanney-Ryu @ryanmcdermott
Oh... I already translated it into Korean.
Check here
And I request PR #157

@qkraudghgh
OMG, I tried searching here but didn't find.
It's okay. I did't translate everything.
Thanks for the translation.

@Hanney-Ryu
I'm sorry and thank you.

I started translate to Russian. https://github.com/maksugr/clean-code-javascript
In near future there will be PR)

Awesome Roman! Send a PR whenever you are ready 😄

There is a WIP for Vietnamese version here. There will be a pull request soon!

I can help with french  ;)

Is there anybody working on the spanish translation? If not i would love to help doing it.

French WIP here : https://github.com/xavhan/clean-code-javascript/tree/french-translation
@ryanmcdermott how do you want me to submit it ?

Readme.fr.md in a i18n folder
as a link to my repo ?

I dont know what is the way :s
Also there is some rules specific to non-english languages like the "only english, even in comments" rule, we need to implement.

Starting to translate to Turkish, I'll send a PR when it's ready 🎉

Nobody claim the spanish translation so im going to work on it. I'll send you a PR as soon as it's done.

@raerpo oh, I started with it yesterday as well... forgot to write here and just started... But I would review yours if you desire.

@xavhan Great! Add another line in the Translation section using the same format as the other languages listed.

@japel Thanks! that would be great. This is the first time i will make an OS contrib so i appreciate that you help me checking if its OK.

Thanks @raerpo!

I'm starting to translation in Spanish.

Excellent @7agustibm!

Actually, no spanish PR. :rescue_worker_helmet:

@fizzvr I'am working with spanish translation.

No worries @fizzvr, thank you for your updates!
That's wonderfu @7agustibm, take your time, I'm happy to approve a PR 🎉

@ryanmcdermott  submitted a PR for the Spanish translation if you could approve it.

If there is some french translators, little help would be welcomed ;)
https://github.com/xavhan/clean-code-javascript

Is there anyone working on the portuguese translation? If not, I would like to do it.

Hi @ryanmcdermott , I have just completed the Polish translation and submitted a PR https://github.com/ryanmcdermott/clean-code-javascript/pull/217 with the link.

Hello @ryanmcdermott , I have just completed the Bahasa Indonesia (Indonesian Language) translation in this link. thank you 😉

@ryanmcdermott
I'm starting to translation in Bangla.

@xavhan 2 years later I come to you to ask : what happend for the french translation ? :)

@tobudim no idea :) is it still needed ?

@xavhan if you have already done something I'd like to contribute instead of doing it all again from blank. :)

hey guys do you require an hindi translation? i can help


Add wireguard vpn section

Signed-off-by: Andy Doan<EMAIL_ADDRESS>

Docs for 97db5e70939e2f54a98264cd0b9a399ea45b5a91 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/437/docs/artifacts/html/index.html

+1 to merge as is and we'll shuffle this around during the documentation changes

Docs for 7be74665b86ed906b89e1958f5ef9f1fbe4f3319 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/438/docs/artifacts/html/index.html


As a head nurse, I can filter staff members by their specialisation (e.g., cardiologist, pediatrician)

... so that I can identify and contact the right healthcare professionals based on their expertise

Have decided to add this in the future.


dotnetCorePackages.{aspnetcore,netcore,sdk}*: bump

Motivation for this change
patch bumps to the dotnet sdks
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80992
16 package built:
dotnet-aspnetcore dotnet-netcore dotnet-sdk dotnet-sdk_3 dotnetCorePackages.aspnetcore_3_0 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.netcore_3_0 dotnetCorePackages.netcore_3_1 dotnetCorePackages.sdk_3_0 eventstore fsharp41 jellyfin msbuild python37Packages.dotnetcore2 python38Packages.dotnetcore2 wasabiwallet

@GrahamcOfBorg build dotnet-aspnetcore dotnet-netcore dotnet-sdk dotnet-sdk_3 dotnetCorePackages.aspnetcore_3_0 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.netcore_3_0 dotnetCorePackages.netcore_3_1 dotnetCorePackages.sdk_3_0 eventstore fsharp41 jellyfin msbuild python37Packages.dotnetcore2 python38Packages.dotnetcore2 wasabiwallet


Updating the hashes for NVlabs/cub package.

PR to fix master cmake builds.

Jenkins, test this please.


try upgrade l1geth

Description
try to pick geth-utils changes  from upstream https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1797/files.  we can build pass , but fail to run normal tests now.
Issue Link
[link issue here]
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Contents

[item]

Rationale
[design decisions and extended information]
How Has This Been Tested?
[explanation]

How to fill a PR description
Please give a concise description of your PR.
The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.
MUST: Reference the issue to resolve
Single responsability
Is RECOMMENDED to create single responsibility commits, but not mandatory.
Anyway, you MUST enumerate the changes in a unitary way, e.g.
This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices
RECOMMENDED to:

What types of design choices did you face?
What decisions you have made?
Any valuable information that could help reviewers to think critically

tried to use PR https://github.com/scroll-tech/zkevm-circuits/pull/1216


khronos-Monster is offset in filament.js

Describe the bug
Exactly one model in the entire khronos glTF 2.0 test suite appears to be offset in filament.js. Note everything here lines up except khronos-Monster: https://googlewebcomponents.github.io/model-viewer/test/fidelity/results-viewer.html
To Reproduce

Load khronos-Monster
Put the camera at (0, 0, 100), looking at the origin
Note the model appears offset to the left and slightly up.

Expected behavior
The model should be centered horizontally (in X).
Screenshots
Expected:

Filament.js:

Tested on v1.4.1, but does not appear to be a regression.

Note that your screenshots are using the model's rest pose, which is significantly different from its orientation with animation applied.
The center of the asset's rest pose AABB appears to be at (-4.07, 16.08, 3.90), both according to its min/max annotations and according to Filament's built-in AABB computation.  This is also consistent with what I see after importing the model into Blender and clearing out the pose data.
By the way our glTF web sample does not auto-translate the model into the unit cube at the origin, although our gltf_viewer native app lets you control this behavior via the -s argument.
So, I think this isn't a bug...but thanks for the report.  Keep 'em coming.


bump global version of kmc

Description
Changes proposed in this pull request:
bump the global version of the kmc image
Related issue(s)

HI @friedrichwilken, I think this bump is covered here https://github.com/kyma-project/control-plane/pull/2712, but we are still waiting for a review from your team.

Closed in favour of https://github.com/kyma-project/control-plane/pull/2712. Thank you, @MarekMichali


Vi input mode: incremental search

Based on top of the implementation of #282, being able to incrementally search and highlight would be awesome.

[x] enter incremental search mode (/)
[x] while entering the search term, incremental search should live-update the viewport and highlighting
[x] as soon as a non-insert mode is entered, reserve one bottom for extra input (such as /-search-term).

Depends on: #282.

implemented quite some time ago already. :)


win32: don't patch on arm64 machine

arm64's patch is incomplete and conflicts with system's native jit.
see https://learn.microsoft.com/en-us/windows/win32/winprog64/wow64-implementation-details
Short story: gperftools' win32 patcher doesn't get prepared for arm64 assembly. It could fail in silence if the patch conflicts with the system's x86 to arm64 jit enginee.

The crash without this patch could be repeated via calling SHGetFolderPathW from a x86/x64 tcmalloc-linked binary on a windows 11 arm64 machine.

Thanks for the patch, but I'll need a lot more details what is being fixed here. Are you saying MS somehow fails to emulate x64 correctly or what ?

Correct. If you run executable with tcmalloc linked (both of x86 and x64, both mingw and msvc) on an arm64 windows operating system, you are likely to get killed. With this patch, it is safe to run.
If you cannot repeat somehow, please try building an executable containing above call or building a gui executable.

Thanks for the patch, but I'll need a lot more details what is being fixed here. Are you saying MS somehow fails to emulate x64 correctly or what ?

In more precise terms, x86 is emulated but x64 is jitted. Both cases fail with the same reason.
You can refer to the link in commit message or just get the list of loaded DLL libraries of an x64 process on an arm64 windows. There are many informations on the internet as well.

It is a simple patch. The code explains it all. If you need more comments, I would say it simply skips patching which is causing troubles on an arm64 windows. IsWowProcess2 is introduced in windows 10 and it is guaranteed to set native machine property to arm64 if and only if the executable runs on an arm64 windows.

This is one way of the only two ways to tell whether it is arm64 windows. The other way is checking environment variables (pretty dirty, I thought). Please refer to the link in message 0.

I am sorry, but I don't get why we have to patch workaround for what you claim to be a failure of MS to keep their promise of having functional x64 support on arm64 machines? Why not report this as a bug to them ?

I don't attach the binary to a debugger such as windbg or something like that. But I only get noticed via Event Viewer. If you want to rootcause the failure and improve the patch, please do it. I only guarantee this patch works.

I am sorry, but I don't get why we have to patch workaround for what you claim to be a failure of MS to keep their promise of having functional x64 support on arm64 machines? Why not report this as a bug to them ?

For short, I don't know if jit program is guaranteed to run via emulation just like chrome. And I won't work for Microsoft. There is no software department of Microsoft in my country.

And you need "software department of Microsoft in my country" to simple report bugs? ;)
To look at this from another perspective, it is entirely possible that our patching code has bugs (plural). But simply saying, "well, on version/platform it doesn't work so lets turn it off", is not how we fix bugs.

In my understanding, you cannot jit x64 assemblies into an arm64 process because the cpu won't execute x64 intrinsics. For example, if you run v8 engine on arm64 inside an x64 chrome executable/process, you might get troubles without patch.

And you need "software department of Microsoft in my country" to simple report bugs? ;)
To look at this from another perspective, it is entirely possible that our patching code has bugs (plural). But simply saying, "well, on version/platform it doesn't work so lets turn it off", is not how we fix bugs.

Yes. The users team won't answer or report to the software team.
For bugs, I would say tcmalloc works for x86/x64 windows and no obvious bugs are found. It is only a nice feature to run for arm64 windows directly instead of switching to link with arm64 tcmalloc.

I cannot take this patch without understanding what is the thing we're fixing or working around.
Perhaps, consider explaining more carefully and more in-depth what is it, that you're fixing. And also please explain why not patching (which effectively disables libtcmalloc) is the fix rather than simply not linking.

Sure. Let me explain again.
For tcmalloc internals, it patches x86 on x86 process via PatchWindowsFunctions and patches x64 on x64 process via the same function. This function will patch every dll's HeapAlloc and HeapFree via assemblies and patch LoadLibray to patch the library's calls of HeapAlloc and HeapFree via assemblies. tcmalloc doesn't patch any arm64 process for now.

For windows internals, the above way works for x86 even on x64 operating system because the execuable runs on x86 emulation (via wow64.dll).

For arm64 operating system, it becomes different because only x86 runs on emulation not x64 (via xtajit.dll).

(x86 via xtajit.dll ProcessMachine: IMAGE_FILE_MACHINE_I386)

(x64 via xtajit64.dll ProcessMachine: IMAGE_FILE_MACHINE_UNKNOWN)

I believe the failing case happens on x64 binaries running arm64 because the MS way is no longer emulation but JIT. If you patch x64 assemblies on an native arm64 (JITted via xtajit64.dll) process, the cpu won't run any x64 intrinsics.

ProcessMachine
x86 os
x64 os
arm64os

x86 binary
IMAGE_FILE_MACHINE_I386
IMAGE_FILE_MACHINE_I386
IMAGE_FILE_MACHINE_I386

x64 binary
x
IMAGE_FILE_MACHINE_AMD64
IMAGE_FILE_MACHINE_UNKNOWN

arm64 binary
x
x
IMAGE_FILE_MACHINE_ARM64

IMAGE_FILE_MACHINE_AMD64/IMAGE_FILE_MACHINE_I386/IMAGE_FILE_MACHINE_ARM64: Native/Emulation
IMAGE_FILE_MACHINE_UNKNOWN: jitted

Hopefully, you might know more internals of tcmalloc than me. If you need more explains, please let me know.

cc-ed windows team via X.

And the patch would be improved by detecting if process is JITed (IMAGE_FILE_MACHINE_UNKNOWN) than detecting arm64 (IMAGE_FILE_MACHINE_ARM64) so we can exclude x86 binaries from disabling tcmalloc (because it is never JITed).

For record, I tried windbg (both of x64 and arm64 versions), the problem doesn't appear. I am looking for something that generate crash report for windows applications.

For record, if we use chromium's delayload trick with ucrt (not msvcrt), it is possible to run x64 program on top of arm64 windows without disabling tcmalloc.

This trick doesn't apply to gcc (mingw) because only lld linker supports msvc-like --delayload=dll_name option.

In my understanding, you cannot jit x64 assemblies into an arm64 process because the cpu won't execute x64 intrinsics. For example, if you run v8 engine on arm64 inside an x64 chrome executable/process, you might get troubles without patch.

I think my previous guess is wrong. someone clarified the v8 (jit issue) at x.com.

Considerring https://github.com/gperftools/gperftools/pull/1520#issuecomment-2143317194, there is something wrong with  actual patching. However I still cannot start debugging because I don't know how to create crash report from it.

I still don't understand you. It is particularly puzzling how you oppose jitting and emulating. Perhaps in windows world those words have somewhat special meaning (i.e. like "WORD" still being 16 bits :) ), but to me from general software engineering perspective jit is just one way to do emulation. I.e. implementation detail. Why that matters is unclear to me.
With that said, here is one guess what might be happening here. libtcmalloc doing "patching" of code that calls to heap routines is by design going into guts of all other loaded dlls. And it only understands very specific subset of instructions. So it is by design super-brittle. I can imagine that if (and that is "if" you could help clarify) we're dealing with processes that load both x64 and arm64 dlls. Then we could be in trouble. My understanding is MS went ahead and somehow choose to support this.
But at least this use-case (i.e. mixing arm64 dlls into x64 process) would clearly be not possible to support sensibly. And who knows maybe MS even choose to have "native" and thus faster dlls always loaded for stuff like system's dlls even for x64 processes. Then we're in more trouble.
Either way, I am not sure if simply disabling patching and those "breaking" tcmalloc is the way to go. Especially that you're claiming that it "works" in some cases.
BTW it might be useful for you to look at how mimalloc is handling this. They also offer that patching way and should have same or similar problems (via mimalloc-redirect which is built against some MS open-source general patching library which I struggling to locate now). And yes we're open to accepting commit(s) to reimplement our patching to use that MS more general and more expertful patching thingy. If you're open to that

I still don't understand you. It is particularly puzzling how you oppose jitting and emulating. Perhaps in windows world those words have somewhat special meaning (i.e. like "WORD" still being 16 bits :) ), but to me from general software engineering perspective jit is just one way to do emulation. I.e. implementation detail. Why that matters is unclear to me.
With that said, here is one guess what might be happening here. libtcmalloc doing "patching" of code that calls to heap routines is by design going into guts of all other loaded dlls. And it only understands very specific subset of instructions. So it is by design super-brittle. I can imagine that if (and that is "if" you could help clarify) we're dealing with processes that load both x64 and arm64 dlls. Then we could be in trouble. My understanding is MS went ahead and somehow choose to support this.
But at least this use-case (i.e. mixing arm64 dlls into x64 process) would clearly be not possible to support sensibly. And who knows maybe MS even choose to have "native" and thus faster dlls always loaded for stuff like system's dlls even for x64 processes. Then we're in more trouble.
Either way, I am not sure if simply disabling patching and those "breaking" tcmalloc is the way to go. Especially that you're claiming that it "works" in some cases.
BTW it might be useful for you to look at how mimalloc is handling this. They also offer that patching way and should have same or similar problems (via mimalloc-redirect which is built against some MS open-source general patching library which I struggling to locate now). And yes we're open to accepting commit(s) to reimplement our patching to use that MS more general and more expertful patching thingy. If you're open to that

mimalloc doesn't work at all.

Well, thats actually somewhat of a good news IMO. Now you can bug them instead. They're part of MS and definitely more experful on all things windows. And despite lack of MS representation in your country ;) they're likely to respond. And once the fix and/or better understanding of the problem emerges you can come back here and offer a solution.

Well, thats actually somewhat of a good news IMO. Now you can bug them instead. They're part of MS and definitely more experful on all things windows. And despite lack of MS representation in your country ;) they're likely to respond. And once the fix and/or better understanding of the problem emerges you can come back here and offer a solution.

At least, I have a working solution through it doesn't work for windows arm64 natively. But for gperftools, it is incomplete workaround because it only works for msvc compiler and clang(lld linker). It still needs troubleshooting to locate the bug in the dark side of hotpatching and x64 jit but sadly Microsoft doesn't provide a way to do it. windbg and logging doesn't help.

In short, it can be worked around but doesn't work for gcc compiler.

Well, we don't have arm64 support on windows. (mimalloc's patching is likely to support it, btw; but not necessary "hybrid" thingy). And with lack of arm64 support, we don't have to work around something we don't understand. IMHO.
With that, I am closing this pull request. I understand that from your perspective it looks like a fix and small adjustment of our code. But we have single maintainer (me) who is not super-qualified on things around windows. And I cannot accept patch that "just" fixes something I don't understand. Because I won't be able to test it or maintain this code.
If you have strong arguments, please, feel free to reopen.

With additional help of crash dump, it said the crash in arm64 windows is due to heap corruption.


Add Fish Shell support.

I thought Linguist was still using Pygments, so I went ahead and committed a FishLexer to the main repo @ BitBucket. Later found out Linguist uses Textmate grammars so I set out to write one for Fish. Fortunately, I found this relic, tested it with LightShow and added the relevant references in this commit.

@brj any idea how hard it might be to convert a Pygments syntax to something compatible with linguist? Both of the fish bundles references in this thread (l15n and toru-hamaguchi's) seem to have significant issues after the test of time, and neither are quite active projects at this point.

@RSully I don't know how hard it would be to convert it, but shouldn't be we looking just at https://github.com/davidcelis/language-fish-shell/blob/master/grammars/fish.cson?

@brj if I was personally going to start working on a fish grammar I'd be starting from scratch, maybe using bash/zsh as a starting point and using the existing fish stuff as inspiration and for head scratchers; I simply do not have high confidence in either of the existing solutions, and I'd rather not spend time trying to hack on them to become correct.
My interest in conversion is a question of having to maintain multiple versions once a proper grammar finally is written. Fish moves a lot faster than other shells, and I don't want to be manually duplicating changes.


New Wallet -  Change Disclaimer Texts

[x] I understand that I am a sole owner of a private 12-word Secret Key which is securely stored on my phone and enables me to control funds on my wallet.

[x] I understand that if this app is ever moved, deleted or malfunctions, the access to my wallet can be only recovered with that Secret Key.

[x] I understand that developers of this app can not be held responsible for any unintended bugs or issues that may arise while using this app.

Update texts


Fix issue #22

Remove the subject header otherwise it will be duplicated.

@matbech can you please add tests for this?

The Subject header is added by the php mail function on Windows. If an extra Subject header is present in the header array the result is a message with two Subject headers.
The request for an automated test is not reasonable because:

There is already enough evidence of the bug:

Manual test (reason for this PR)
php source where the "Subject" header is added:
https://github.com/php/php-src/blob/0437aa2abf1eb494e4555d7d4dfbdbf566a59bdc/win32/sendmail.c#L595
https://github.com/php/php-src/blob/0437aa2abf1eb494e4555d7d4dfbdbf566a59bdc/win32/sendmail.c#L702

Writing an STMP server to intercept the mail communication from Window's php:mail is unreasonable, considering the evidence already presented.

@matbech can you just make test that if OS is windows the header is removed? not sure if the isWindows result can be mocked.

I'm sorry but I have a hard time to understand your sentence. This has been tested on Windows with PHP 7. There is no good reason to leave this bug open for more than 6 months now.

Did you test all other supported versions too?, PHP < 7
I'm trying to help, i don't care for one bit for windows support personally!

We've asked for tests, and blocked this for lack of tests; it's not a question of whether or not we want the fix, but wanting to ensure it stays fixed.
You can test this by mocking the result of what isWindowsOs() returns (potentially by extending the transport to hardcode the value), and checking the message generated to see if the header was removed.
If/when you are able to do that, please open a new pull request; until then, I'm closing this for now.


Check that marker is on map before setting the icon

There is a race condition in the case the following situation happens:

User updates the icon of a Pin with a BitmapDescriptorFactory.FromView()
Immediately after remove the Pin from the map

This results in this library calling SetIcon() on the native marker AFTER it has been removed from the native map. This results in Google Maps throwing a Java.Lang.IllegalArgumentException: Unmanaged descriptor exception.
By checking that the marker hasn't been removed before calling SetIcon() we can prevent this exception.

Fixes #657

Thanks for your contribute!


Reorganized footer nav

Fixes #446

Updated the Docs section
Moved "Tutorial" to More
Renamed Community to Channels, and included "GitHub"
Dynamicized Docs and Community sections (uses section title, but links to the first item in the array)

cc @gaearon

Can we have "quick start" point to "Hello World" like top level nav does? This is to avoid scaring people with installation content when they just want to learn the basics.

Looks good, thanks!


Explicit import of apps

https://github.com/buildingSMART/ifc-gherkin-rules/pull/145#issuecomment-1952902399

Outdated. Found another solution.
Linked to https://github.com/buildingSMART/ifc-gherkin-rules/pull/145


Unexpected network traffic to SMB shares

Steps to reproduce

Open terminal
Observe the popup about an outgoing connection on port 5000 by your firewall of choice (if it's configured to warn about that)

Expected behavior
According to DHowett on Hacker News you do not expect any outgoing connections unless explicitly requested
Actual behavior

Source is my desktop computer
Remote is my NAS device with some SMB file shares (but none of them are mapped to drive letters)

That's crazy - I really wouldn't expect that to happen. Does this repro with cmd.exe as your shell? Maybe this is powershell trying to enumerate some file?
Also, what Windows version and Windows Terminal version are you running? I wouldn't expect this on any version, but you never know

Yes, I have just reproduced it with cmd.exe as the default shell in profiles.json and I have also reproduced it with an empty PowerShell profile (I had some small customisations in my profile.ps1).
Windows Terminal Version: 0.10.781.0
Windows Version: 10.0.18362.720

Huh, that's certainly weird. Maybe this is caused by us trying to enumerate the pwsh installs you have?
Could you try adding this to the root of your profiles.json?
    "disabledProfileSources": ["Windows.Terminal.PowershellCore"]

and try again? That should disable the lookup for pwsh installs. You could also try
    "disabledProfileSources": ["Windows.Terminal.PowershellCore", "Windows.Terminal.Wsl", "Windows.Terminal.Azure", "Windows.Terminal.Telnet"]

to be comprehensive about all the possible dynamic profiles

Thanks for your help! It turns out that it was entirely my own fault.
 With a custom icon that's being loaded from the NAS...
Sorry for bothering you with this! After removing the custom icon it stopped happening.

Hey no problem! I'm glad it was something in your own config after all, thanks for following up!

@JannesMeyer (thanks for following up! I was really curious about this one when I saw you on Hacker News 😄)


Should call the property of parentRouteName properly

I appreciate that you edited the code and point me out that it should throw error. But i think the property of parentRouteName properly should use "[]" and not by "." notation.
I hope we can setup the test and CI for this  as soon as possible so we can guard stuff like this with test.
Still this is related to issue #1606

Oh of course, thanks for catching that!


Adding translations to Robot36

So far, we've added the following translations:
Simplified Chinese:
https://github.com/xdsopl/robot36/blob/v2/app/src/main/res/values-zh-rCN/strings.xml
German:
https://github.com/xdsopl/robot36/blob/v2/app/src/main/res/values-de/strings.xml
Russian:
https://github.com/xdsopl/robot36/blob/v2/app/src/main/res/values-ru/strings.xml
I am not a native speaker of Russian and Olga does not know the technical terms in Russian either, so can you please @ropucyka  help confirm that the Russian translations are okay?
The original English strings are here:
https://github.com/xdsopl/robot36/blob/v2/app/src/main/res/values/strings.xml
If you are reading this and speak another Language than listed above, please contact us here.

Hi there.
I would like to contribute with PT-BR :)

@fuyukihidekii, would you like to create a pull request or should I first try to make a translation with ChatGPT and you tell us if it looks ok? ChatGPT is very helpful but having a native speaker that knows the technical jargon is much more valuable.

I will check this today, later.

Im working on it

Created pull request
https://github.com/ropucyka/robot36/commit/f517ecfeb859b39f8a69e97d0da7b3168efe16fb?diff=split&w=0

v2.8 is released with Simplified Chinese, German and Russian translations. Happy testing!

Realized these things about the Russian translation after the release:

Wherever we looked,  По-умолчанию seems to be written without the hyphen: По умолчанию
We should capitalize each menu item word, so необработанный режим should be Необработанный режим

По-умолчанию is writing ONLY WITH hyphen. Im russian an know these rules perfectly.
По-китайски, по-прежнему, по-нашему

необработанный режим

This string not exist in file. Exist only string № 20: "source_unprocessed">Необработанный which written correctly by default.

wtf

Long tap on Mode button show popup text "Automatic mode" even if it switched on Force mode.
Long tap on Share button doesn't show "Share" popup.
Added pull request with 1 translation fix based on natural testing.

ONLY WITH hyphen

Not arguing, only observing. We also had many moronic changes in the German language recently which were supposed to make things simpler and more modern, but ..

Long tap on Mode button show popup text "Automatic mode" even if it switched on Force mode.

Maybe we can call it "Mode Toggle" or something?

Long tap on Share button doesn't show "Share" popup.

Sorry, Google needs to fix that button :(

Mixing names with translations is always difficult. I understand what you mean but it will be not practical with all the translations in the future.
I need to find out if changing the menu item name is feasible but usually it is better to keep it constant.
It is a difficult design decision .. give me time to think about it.

Exmple if localized xml (but in english):
	<string name="share">Share</string>
	<string name="auto_mode">Auto</string>
	<string name="force_mode">Force Mode</string>
	<string name="raw_mode">Raw</string>
	<string name="mode">Mode</string>
	<string name="mode_Robot36Color">Robot 36 Color</string> - static, not for localization but present in every language` xml's

Localized bottom popup for Auto will be: <string name="mode">Mode</string>: <string name="auto_mode">Auto</string>
or for selected forced mode:
<string name="mode">Mode</string>: <string name="mode_Robot36Color">Robot 36 Color</string>
Longtap popup always be localized from <string name="mode">Mode</string>
I dont see point of problem, but of course maybe i dont understand core of problem.

Thank you for bringing these design ideas to the table. I appreciate the thought and effort you've put into this. After considering our options, I've decided to take a different approach. Toasts, while useful in certain situations, can sometimes disrupt the user experience and are generally not well-received. They are non-interactive, ephemeral, and can overlap with other UI elements, which might lead to a cluttered interface and disrupt the user's flow.
I believe using an icon that changes between 'auto' and 'lock' modes, along with displaying the current mode in the menu title, is a more effective way to convey this information. This approach offers continuous, non-intrusive feedback to users, ensuring they are always aware of the current mode without any interruptions. It aligns with our goal of maintaining a seamless and intuitive user experience. Let's continue exploring ways to improve our design with these alternatives in mind. Your input is valuable, and I look forward to collaborating on this further.

I have renamed Force Mode to Lock Mode. I think that sounds less aggressive and is clearer, as the icon is also a lock symbol. Added "Toggle Mode" string for the mode toggle icon. Please check the translations.

renamed Force Mode to Lock Mode

haha it much harder to translate correctly in logic. in russian this phrase can have few variants with different logic:
Блокировка режима (Lock of current mode), Режим блокировки (Lock mode), Зафиксировать режим (Lock mode [alt.]) or even Выбор режима (Mode choice). I'll add translation fix after next test release if it will be needed. Just need to watch this on usage. Funny crosswords, yes.

@ropucyka thank you for helping me. I really enjoy our conversations and appreciate your attention for detail.

v2.9 is out now

Translation update done, with new fixes it must feels for russian language users very easy and like a native ru lang app.
SSTV Encoder will be updated/translated also?

SSTV Encoder does need an overhaul, yes, but not now .. too busy

Thinking about PD 290 every time when i opening robot36 page on github)
Maybe you can see a little bit increased downloads count of both apps in last ~2 days for v2.7 here and for Encoder on f-droid.

Language selection menu item?
Or menu item to switch between local language (available translation in app) and international english, named like:
Русский / English, Deutsch / English Or this can be expandable flag icon of available languages.
Reason example: if i take device which using chinese language, start the app and see only 奇怪的东西 - i must be able to easy switch app language to international - english. Or if user just want to use app with it native language (like me with many another machine shtranslated apps). Considering the purpose of the application, and offering ideas, I always keep in mind that the user is in a place without the Internet or any other connection, in a dangerous environment or situation, for example in a forest, with only radio device. I watch on app from this point first, never thought it was a toy.

I've just added a language selection icon in form of a globe. Will make another release after @fuyukihidekii's contribution

Screen_recording_20240521_082859.webm

Yes, but now it looks not so beautiful. This icon overlaps the status area in vertical screen orientation and looks redundant there. Maybe this option will take it place in menu list? at 3rd position from bottom of menu list?
In translated verion it can be looks like that: Русский \ Language, Deutsch \ Language But in English interface it can be named just - Language.
I see you started experiments with your own image codec? Saw your last video on youtube, and based on this, I think assempix will show image receive in realtime from first bytes, like Robot36 but aka progressive draw instead of sequental :) Sounds cool.

Yes, but now it looks not so beautiful.

Could not find a nice way to have an icon in the menu list without tricks. Maybe it will be contributed?

I see you started experiments with your own image codec?

Yes, but without an external viewer or image editor, those experiments are just that.

Maybe it will be contributed?

Haha by me? I can only work with text, because it easy.
No, im talking about classic menu entry for translations, not icon, example like "Audio seetings"

those experiments are just that.

Just want that everything works out for you with it.

Haha by me?

There are many developers who like to find something small to contribute but it needs to be specified clearly. It's like a sport for them. Lookup Hacktoberfest for example.
Specified clearly means a feature request is needed. Short and sweet. A low hanging fruit.

No, im talking about classic menu entry for translations, not icon

I understand. But this is the way. Which string can be used that is readable in any language? See, none.
Android development is a PITA. I am doing this for free. I really would like to get back to my BBS project.
This is why I need outside help. Can't do everything myself. This Android stuff is very frustrating to grok and a constantly moving target which causes a huge maintenance burden.

You are almost finished updating the application, and then you decided to add translations into other languages, mentioning me, and so I came and I think that the result was excellent. You translated it into German, another user translated it into Chinese, and I corrected the Russian. Your application has received almost all common languages, except Portuguese and, possibly, Arabic, Japanese. A good result has been achieved.  And it will be easier for you to start thinking about other ideas. In order not to create an off topic, I won’t write anything else. But if you need my unstoppable flow of thoughts, you can always ask me anytime in telegram @DVD108

@xdsopl PR sent, can you do a build for checking it?

can you do a build for checking it?

v2.10 is out for your testing pleasure

Yes, but now it looks not so beautiful

Made it beautiful again

You are almost finished updating the application, and then you decided to add translations into other languages

Yes, I keep getting sidetracked. But I think this one was worth it. As you said, this is an app that is used internationally. It brings people together and brings a lot of joy to young and old. I am very happy about it.

 If you have a great idea or find an issue, please feel free and create a new issue for each idea or problem. I obviously can't keep up but there are others looking at this app who would like to tackle the one or other issue.

you can always ask me anytime in telegram

I am not on social media besides GitHub and YouTube at the moment. You can also contact me via email.

Ok.
Notes for v2.10

After clean install, app starts in english. (2.9 was starts in my device language)

Not enough space for few letters in rusiian translation. Too long word can be replaced with shorter:
Политика конфиденциальности -> Политика приватности Some sources also marks second variant as more correct about Privacy Policy.
Screenshot_20240522-160228_Robot36

Language list not sorted, problem it or not, idk.

English
Deutsch
Português brasileiro
Русский
语言

app starts in English ..

Good catch. Did not think about that too much.

Not enough space for few letters ..

Just made commit 6e8a5244161b1f1d24f52d52ba92e4599a95a8d1 with your suggestion

Language list not sorted ..

It is sorted by order of first contribution

Made another testing release: v2.11 is out. Please test and report back.

In Night mode popups have light backgground. Idk how it must be correctly..
I no more found any problems at user level experience in v2.11
Just from my head (bathroom exactly):
Shredpix = Assempix = Rattlegram
SSTV Ecoder = Robot36 = ? - Fancygram (text on spectrogram)
Limiteg width, unlimited length. haha

Hello!
I am very much enjoying exploring sound-to-image with Robot36; I am also not a ham radio person, but an artist with interests in space race/cold-war era media.
I have a strange request: Would you be willing to add the ability to hide the top menu area (leaving only the waterfall, amplitude and decoded areas visible)?
Why? Because I would like to use your software running on an SBC (like an ODROID N2+) in an art installation. Robot36 in auto mode creates really lovely visual patterns when intentional errors are introduced, audio from different images mixed, etc., so it is pretty ideal for the aesthetic I am working on, but I find the menu text and icons (in this context) too distracting.
While I could construct a custom bezel for a monitor in order to hide the "overscan" (like in the old days of CRT!), a software solution would certainly be more elegant.
I have no expectations and sincerely hope it is not offensive for me to ask.
Best Futures!
-c

Can you please create a new issue for that? This issue here is only meant for adding translations to Robot36. I wanted to fire up Android Studio for fixing another potential problem in Robot36 soon, so I could create you a small patch you could use to disable the menu while at it. See you in another new issue. ;)

Hello. I'm just a Robot36 user and I'm going to translate it into Polish.
I guess I have to download "The original English strings" and translate it into my language.
Am I right?

@xdsopl @chadmeby @ropucyka @fuyukihidekii
I've just finished it.
I translated "strings.xml" into Polish language and I added one line:
	<string name="polish" translatable="false">Polski</string>
It's my first day here so I don't even know how to post it. ;]
I hope it's the correct way... https://github.com/SP1IMJ/robot36/blob/8819c7f0d1b785ac570fdd9fdd64236542f3fa87/app/src/main/res/values-pl/strings.xml

@SP1IMJ Thank you! I just merged and integrated your translation file. The translations will be available with the next update.


Add ParseMultiplication to hp condition

Introduces multiplication in the hp condition to aid with checking what an ability hits for after modifiers.
For example with a Mechanical Yeti's Ion Cannon being cast during Lightning Storm on a boss with the 50% reduced damage aura a script like below would ensure Ion Cannon is only cast when it kills.
use(Call Lightning:204)
use(Ion Cannon:209) [ enemy.hp <= 732 * 1.25 * 0.5 ]
use(Metal Fist:384)

Beautiful idea, but I suggest doing it more versatile:
test(hp < 122.4) [self.hp < 2.4*floor(103/2)]
test(hp >= 122.4) [self.hp >= 2.4*floor(103/2)]

would also be neat, wouldn't it?
I propose

all math intrinsics Lua has (+*/-%())
ceil
floor
abs
min
max
cond(c, a, b): if c, then a, else b
clamp(v, mi, ma) if v < mi then mi, else if v > ma then ma, else v

This set is all math that Blizzard uses for ability tooltips, so it should be enough for us. cond and clamp are likely useless in our current format, so I'm happy to drop them.

I have added an alternative implementation which provides the suggested operations in #13.

I have added an alternative implementation which provides the suggested operations in #13.

Thanks! What you've added to #13 is a lot better. I thought about doing all operations but don't know enough about Lua to quickly figure out how that's done.


Cellular & (non-cellular) metabolic processes

Hello,
I am creating a fresh ticket for the work started in https://github.com/geneontology/go-ontology/issues/17904
We have decided that all the chemical metabolic processes are cellular processes, so the following terms need to be fixed.

if there is a corresponding 'non-cellular' term, the term should be obsoleted and replaced by that 'non-cellular' process term.
if there is no corresponding 'non-cellular' term, the term label, definition and logical definiton should be fixed to the non-cellular forms.

Also, if there are asserted classes, these should generally be removed, unless they provide information that is not being inferred. Usually the ChEBI hierarchy should infer all parents that are needed.
Metabolic process

[ ] GO:0044237  cellular metabolic process
[ ] GO:0044255  cellular lipid metabolic process
[ ] GO:0043446  cellular alkane metabolic process
[ ] GO:0043449  cellular alkene metabolic process
[ ] GO:0043452  cellular alkyne metabolic process
[ ] GO:0042180  cellular ketone metabolic process
[ ] GO:0006081  cellular aldehyde metabolic process
[ ] GO:0046950  cellular ketone body metabolic process
[ ] GO:0090345  cellular organohalogen metabolic process
[ ] GO:0090346  cellular organofluorine metabolic process
[ ] GO:0052701  cellular modified histidine metabolic process
[ ] GO:0006575  cellular modified amino acid metabolic process
[ ] GO:0046379  extracellular polysaccharide metabolic process
[ ] GO:0031323  regulation of cellular metabolic process
[ ] GO:0010565  regulation of cellular ketone metabolic process
[ ] GO:0006521  regulation of cellular amino acid metabolic process
[ ] GO:0090347  regulation of cellular organohalogen metabolic process
[ ] GO:0090348  regulation of cellular organofluorine metabolic process
[ ] GO:0031324  negative regulation of cellular metabolic process
[ ] GO:0031325  positive regulation of cellular metabolic process
[ ] GO:0045763  negative regulation of cellular amino acid metabolic process
[ ] GO:0010675  obsolete regulation of cellular carbohydrate metabolic process
[ ] GO:0090349  negative regulation of cellular organohalogen metabolic process
[ ] GO:0090350  negative regulation of cellular organofluorine metabolic process
[ ] GO:0043094 cellular metabolic compound salvage

Biosynthetic process

[ ] GO:0044249  cellular biosynthetic process
[ ] GO:0097384  cellular lipid biosynthetic process
[ ] GO:0052703  cellular modified histidine biosynthetic process
[ ] GO:0042398  cellular modified amino acid biosynthetic process
[ ] GO:0045226  extracellular polysaccharide biosynthetic process
[ ] GO:0031326  regulation of cellular biosynthetic process
[ ] GO:2000282  regulation of cellular amino acid biosynthetic process
[ ] GO:0031327  negative regulation of cellular biosynthetic process
[ ] GO:0031328  positive regulation of cellular biosynthetic process

Catabolic process

[ ] GO:0044242  cellular lipid catabolic process
[ ] GO:0042402  cellular biogenic amine catabolic process
[ ] GO:0052702  cellular modified histidine catabolic process
[ ] GO:0042219  cellular modified amino acid catabolic process
[ ] GO:0071999  extracellular polysaccharide catabolic process
[ ] GO:0031329  regulation of cellular catabolic process
[ ] GO:1900419  regulation of cellular alcohol catabolic process
[ ] GO:0031330  negative regulation of cellular catabolic process
[ ] GO:0031331  positive regulation of cellular catabolic process
[ ] GO:1900420  negative regulation of cellular alcohol catabolic process
[ ] GO:1900421  positive regulation of cellular alcohol catabolic process
[ ] GO:0150094  amyloid-beta clearance by cellular catabolic process

Obsolete: precomposed:

[ ] GO:0072000  extracellular polysaccharide catabolic process involved in ascospore release from ascus
[ ] GO:2000777  positive regulation of proteasomal ubiquitin-dependent protein catabolic process involved in cellular response to hypoxia

Note that this would result in many terms that are clearly cellular moving out of the cellular hierarchy.
In 2019 I proposed a simple solution of placing metabolism under CP.
https://github.com/geneontology/go-ontology/issues/17904#issuecomment-549545694
The alternative is to get rid of CP altogether. Having a grouping class that is highly incomplete is confusing.

Sounds good. I dont think we want to get rid of cellular process - that's very central to @thomaspd 's BP reorganization.
I moved 'metabolic process' under 'cellular process', see https://github.com/geneontology/go-ontology/issues/28932
Thanks, Pascale

GO:0044237 cellular metabolic process child terms have been moved
GO:0044255 cellular lipid metabolic process child terms have been moved
GO:0044242 cellular lipid catabolic process child terms have been moved
GO:0097284 cellular lipid biosynthetic process child terms have been moved


Outdated information implies functionality only for ASP.NET Core 3.1

This page states:

Referencing ASP.NET Core in this manner is only supported for projects targeting .NET Core 3.x

and in general is very .NET 3.1 oriented. It refers to a GitHub issue for later version of ASP.NET Core.
However in the referenced GitHub issue @davidfowl confirmed that this method applies to .NET 5 and presumable .NET 6.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98629146-7d64-9f48-6e45-51bafe8c7116
Version Independent ID: cdb2b89f-bf1c-f313-0062-7f6b7ef8b611
Content: Use ASP.NET Core APIs in a class library
Content Source: aspnetcore/fundamentals/target-aspnetcore.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: scaddie

#21725 tracks .NET 6


Add SIGN_KEY environment variable to choose GPG signing key

Fixes #17

Thanks! When is the new version going to be bundled in with linuxdeploy? I know the docs says the plugins are likely to be outdated. I'm using it automatically from CI, so ideally I wouldn't want to separately download the plugin as well, would prefer to have just one file to work with.

You can always download this plugin next to linuxdeploy and make it executable, it will take precedence over the bundled one.
I'll rebuild linuxdeploy on Travis to update the binaries.

Thanks, that would be helpful!

The binaries have been built and published, by the way.


ImportError: cannot import name 'LangSmithParams' from 'langchain_core.language_models.chat_models'(import langchain_google_genai) in collab environment

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
import langchain_google_genai raise ImportError
Error Message and Stack Trace (if applicable)
ImportError                               Traceback (most recent call last)
 in <cell line: 6>()
4 # !pip install --upgrade langchain
5 # from langchain_google_genai import GoogleGenerativeAI
----> 6 import langchain_google_genai# import GoogleGenerativeAI
7
8 # llm = ChatGoogleGenerativeAI(model="gemini-pro")
1 frames
/usr/local/lib/python3.10/dist-packages/langchain_google_genai/init.py in
57
58 from langchain_google_genai._enums import HarmBlockThreshold, HarmCategory
---> 59 from langchain_google_genai.chat_models import ChatGoogleGenerativeAI
60 from langchain_google_genai.embeddings import GoogleGenerativeAIEmbeddings
61 from langchain_google_genai.genai_aqa import (
/usr/local/lib/python3.10/dist-packages/langchain_google_genai/chat_models.py in
54 )
55 from langchain_core.language_models import LanguageModelInput
---> 56 from langchain_core.language_models.chat_models import BaseChatModel, LangSmithParams
57 from langchain_core.messages import (
58     AIMessage,
ImportError: cannot import name 'LangSmithParams' from 'langchain_core.language_models.chat_models' (/usr/local/lib/python3.10/dist-packages/langchain_core/language_models/chat_models.py)
Description
I am am trying to use the GoogleGenerativeAI wrapper for a project of mine.
System Info
System Information

OS:  Linux
OS Version:  #1 SMP PREEMPT_DYNAMIC Thu Jun 27 21:05:47 UTC 2024
Python Version:  3.10.12 (main, Mar 22 2024, 16:50:05) [GCC 11.4.0]

Package Information

langchain_core: 0.2.22
langchain: 0.2.10
langchain_community: 0.0.38
langsmith: 0.1.93
langchain_google_genai: 1.0.8
langchain_openai: 0.1.7
langchain_text_splitters: 0.2.2

cc @ccurme

Can you confirm the kernel that is raising the error has langchain-core==0.2.22, as you specify in your package information?
I cannot reproduce this error in a fresh environment:
pip install --upgrade langchain_google_genai -i https://pypi.org/simple
pip freeze | grep langchain

langchain-core==0.2.22
langchain-google-genai==1.0.8

restart kernel

The issue was due to version conflicts within environments. Thanks for your responces

The issue was due to version conflicts within environments. Thanks for your responses

Can you specify what was the conflict?

ImportError: cannot import name 'LangSmithParams' from 'langchain_core.language_models.chat_models' (/usr/local/lib/python3.10/dist-packages/langchain_core/language_models/chat_models.py)

This happened to me when I tried:
pip install ragatouille
Then fixed it with:
pip install --upgrade langchain langchain-community langchain-core

Go to my Mongodb >> Clusters >> Connect >> Drivers >> Then choose : "python.3.12" and update your Atlas_connection_string with the new one (same old username and password)


Can't detect EddyStone URL advertisement with 5.0 kernel

aioblescan can't detect EddyStone URL advertisement with 5.0 kernel.
We could see "Bluetooth: hci0: advertising data len corrected" is received in dmesg, however, aioblescan can't detect the advertisement.
See the code below:
  class HCI_LE_Meta_Event(Packet):
    def decode(self,data):
      ...
      if code.val==b"\x02":
          ev=RepeatedField("Adv Report", HCI_LEM_Adv_Report)
         data=ev.decode(data)
          self.payload.append(ev)
      else:
          ...
`
aioblescan supports only the "legacy" LE Advertising report(0x2).
Need to implement corresponding handling code based on BLUETOOTH CORE SPECIFICATION Version 5.1, section <IP_ADDRESS> LE Extended Advertising Report event (code 0xd).

Sorry, I am currently vacationing in France. Will have a look at it when I am back home, mid Aug.

Thanks for the reply (I'll do the same next week)
Enjoy your holidays.
Sylvain PINEAU

Hi, have you been able to reproduce the issue? I can help providing more data from the system where it happens.

Sorry, I have not had time yet. I am about to move to a new house and it is taking more of my time than I expected. But please send me the setup you use to reproduce the problem.
Cheers
François

Proposed #27 to fix this issue.

@frawau will we have a new release for this? I've tried this against EddyStone beacon I got, but maybe you have also other hw to test against as well.

I will check with my Ruuvi devices first. Not sure when but soon I hope


Ensure the header payload is capped

When a header frame is not final, continuation frames are expected to follow.
In this case, the decoder simply buffers the payload until all continuation frames are received. This buffering should have an upper bound to avoid buffering forever.

In fact, there is even a setting for this: SETTINGS_MAX_HEADER_LIST_SIZE (0x6).


snowflake: enable multi-line comments

Snowflake supports /* */ comments, so lets enable them on the usql driver side.

Thanks Ken!


Kirk Hill Wind Speed - MPH or m/s

Looking at the reported values in the integration, the wind speed looks incorrect. The API is reporting ~13 which is showing as 13MPH in HA, but on the Ripple dashboard its reporting 30MPH. This would equate to ~13m/s, so do we think the units on the API are actually m/s?
I've put a Tweet up to Ripple to see if they know for sure. - https://x.com/ChrisIngram_UK/status/1814337288337514898

The documentation states it’s in mph but what you are saying makes sense. Will see what they say

So it was an issue on Ripples side, they've now corrected it, confirmed the API value matches what the dashboard is showing.

Just means history until the fix will be incorrect.

Thanks for confirming


Using nuxt-icon in a custom module

module.ts
installModule('nuxt-icon', {
  size: '24px',
})

But inlineOptions doesn't work, when i'm enabling this module inside a custom module.

You can use nuxt.options.icon.size = '24px @avxkim

@Atinux then i have to use useRuntimeConfig() in a component?

i did this way:
module.ts
    nuxt.options.runtimeConfig.public.iconSize =
      options.iconSize

then in a component
const config = useRuntimeConfig()

const iconSize = computed(
  () => props.size || config.public.iconSize
)

is that ok?

Oh my bad I just saw that we are using the app.config.ts for the configuration.
Could you try with nuxt.options.appConfig.icon.size = '24px' ?

@Atinux is doing this
nuxt.options.runtimeConfig.public.iconSize =
      options.iconSize

considerd as a bad practice?


Cannot compile on Debian: UnsupportedVersion: Unknown version None

Godot version
4.0-alpha12 (2c11e6d9efc42370a8d7537eaff8b1ea78a283e5)
System information
Debian 11 (5.10.0-15-amd64)
Issue description
Trying to generate the solution (https://docs.godotengine.org/en/latest/development/cpp/configuring_an_ide/visual_studio.html)  on Debian 11, but got UnsupportedVersion: Unknown version None

I also referred to the following information: https://docs.godotengine.org/en/latest/development/compiling/compiling_for_windows.html#development-in-visual-studio-or-other-ides
and some issues, but in vain.
Any help is appreciated.
Version
scons: v4.3.0 (also tried in v4.0.1)
mingw-w64: 8.0.0-1

Steps to reproduce
scons -j32 platform=windows vsproj=yes use_mingw=yes
Minimal reproduction project
No response

There's no Visual Studio on Linux, so you wouldn't be able to use this.

It is recommended to state this in the documentation to avoid more people getting stuck like me.  Thanks for your help!

It is recommended to state this in the documentation to avoid more people getting stuck like me.

You might have missed it but I think it's explicit enough in the intro?

We should still fix the fact that it throws a Python error though, we can prevent using this option when we know it can't work.

Maybe I thought mingw should do the job because of platform=windows, but I was wrong, it only uses  VS

To clarify, to cross compile for Windows on Linux, you will indeed use MinGW. That's the only option available, MSVC (Visual Studio compiler) is only available on Windows.
The relevant documentation for you is https://docs.godotengine.org/en/latest/development/compiling/compiling_for_windows.html#cross-compiling-for-windows-from-other-operating-systems (cross-compilation). Though it might be partially outdated, I don't think you need to setup those PREFIX env variables anymore, it should Just Work™ with mingw-gcc installed.


Can we sent a message as a template?

Can facebook-chat-api sent a template question as the picture below?

Are you chatting with a bot on messenger?

@thaspoom this api can only do things that users can do. Afaik, users can't send a template message. You probably want to use something like this: https://developers.facebook.com/docs/messenger-platform

While the templates are always sent from the "other side", that is the chatbot code through the messenger-platform, it would be cool if we could simulate pressing on one of the buttons from the template - a postback occurs there, and I don't know how to simulate this.

I believe that functionality is only available to pages and their users and not available to one-to-one and group messages.

I think the original question is answered. Not sure about interacting with chatbot templates, but that can probably be it's own thing if people really want it.


Tap interface numbering

We need to fix the tap interface numbering. Because of this problem we cannot have large topologies now.

Resolved in cca0a2e1a0c895a5c2c6456fd47f772a31625308


⚠ ClamAV has degraded performance

In a78e5d7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: ClamAV performance has improved in 91587fa after 12 minutes.


[proposal] [triage] create new "p: third party"

Hi all,
I feel that could be useful to add a label that helps
to better identify and catalogs,
regardless the issue being destined to be closed or not,
issues related to 3rd party plugins.
Doing so could be also useful
for possible future analysis of the ecosystem.
In first instance I propose to add the label:
p: third party which is quite self explanatory.
Secondarily,
if doesn't make the label list too crowded
might make sense to create also:

p: community for plugins that belongs to fluttercommunity
p: favorites for plugins that belongs to the Flutter Favorite program

Thank you for reading

Plugin p: third party created
I leave the issue open for future references, changes and implementation

Labels are cheap, just make them when we need them :)
Going to close this - I don't think there's any further action to take here.


Support switching chains in active WalletConnect session

Refer to https://github.com/AlphaWallet/alpha-wallet-ios/issues/3383 for button. This is for sessions which already active (connected).
Look for wc_sessionUpdate in the SDK.

@hboon This is the 'switch network' button? So you can issue a wc_sessionUpdate on an active session to change chains and it works correctly?
That's a really handy feature if it works I'll get it in for the next release.

Correct.

@JamesSmartCell bump

@JamesSmartCell, @seabornlee or @justindg would you help re-assign among yourself and close this?


Update installLiberty to use Maven Central

Update installLiberty to either use Maven Central by default or provide a simple mechanism for specifying that you want to install an image from Maven Central. Currently can be configured by setting the runtimeUrl to the specific location of the file on Maven Central but instead it would be better to be able to specify some configuration options, similar to ci.maven.

The 2.0 release of the gradle plugin supports installLiberty maven central installation.  Specify the dependency using
dependencies {
    libertyRuntime group: 'com.ibm.websphere.appserver.runtime', name: 'wlp-webProfile7', version: '<IP_ADDRESS>'
}

https://github.com/WASdev/ci.gradle/blob/master/docs/installLiberty.md#installliberty-task


Added changes to fix ArithmeticIntegrationTest failure on ppc64le

Summary of the changes / Why this improves CrateDB
This PR will resolve this issue - https://github.com/crate/crate/issues/7585
Checklist

[ ] User relevant changes are recorded in CHANGES.txt - Not required
[ ] Touched code is covered by tests - Done
[ ] Documentation has been updated if necessary - - Not required
[ ] CLA is signed - Done.

Can you please check this PR - @seut  ?

Can one of the admins verify this patch?

ok to test

Thanks for your contribution, I've merged the change.


mod: update btcutil dependency

Depends on https://github.com/btcsuite/btcutil/pull/198.
Fixes https://github.com/lightningnetwork/lnd/issues/5337.
Bumps the btcutil dependency to the latest version that fixes a bug in
parsing addresses.

Needs a rebase!

Rebased.


index: Include link to offline release docs

Readiness

[ ] Merge (pending reviews)
[ ] Merge after date or event
[ * ] Draft

Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[ ] Run spelling and grammar check, preferably with linter.
[ ] Avoid changing any header associated with a link/reference.
[ ] Step through instructions (or ask someone to do so).
[ ] Review for wordiness
[ ] Match tone and style of page/section.
[ ] Run make linkcheck.
[ ] View HTML in a browser to check rendering.
[ ] Use semantic newlines.
[ ] follow best practices for commits.

[ ] Descriptive title written in the imperative.
[ ] Include brief overview of QA steps taken.
[ ] Mention any related issues numbers.
[ ] End message with sign off/DCO line (-s, --signoff).
[ ] Sign commit with your gpg key (-S, --gpg-sign).
[ ] Squash commits if needed.

[ ] Request PR review by a technical writer and at least one peer.

Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@kprosise - just an idea how we could link. i'm not advocating for it and I'm guessing link-check will fail.

Docs for 6355f570d31a8b4490674a7869a5bb92bb7b0afd are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2080/docs/artifacts/html/index.html

closing for now, we can reevaluate this solution later if we don't migrate away from Sphinx.


What happens when exclusion dates that go past Patch Tuesday?

If an exclusion window were to take devices past the next patch tuesday, what would happen?
For example, using June 2023, if I had a 4 wave rollout with 5 days in between, the default wave would have started on July 3rd.
If a group of machines were targeted with an exclusion date range of July 1st to July 13th, would they get the June updates or the July updates?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7d3986ef-1183-c725-1510-c30f415a535c
Version Independent ID: 7d3986ef-1183-c725-1510-c30f415a535c
Content: Overview of servicing profile in the Microsoft 365 Apps admin center - Deploy Office
Content Source: DeployOffice/admincenter/servicing-profile.md
Service: o365-proplus-itpro
GitHub Login: @nicholasswhite
Microsoft Alias: nwhite

In above scenario the devices would not get any updates at all during the time specified. An Exclusion Window prevents any update commands to be sent to devices covered by the exclusion.
Technically, if an exclusion window is spanning across a Patch Tuesday, the Servicing Profile has the commands ready to update devices to version A (before Patch Tuesday) and version B (after Patch Tuesday), but does not send those commands down to devices as long as they are covered by the Exclusion window.

Thank you, I should have clarified that I was looking for what happens right after the exclusion window ends. Which version would they try to patch to on July 14th? If others in their wave (4th wave +20 from Patch Tuesday) would not get patched until July 31st, would they get version A from July 14th to 31st or would they get Version B? If they would get version B in that time frame, would we then need to just apply a rollback to version A?

At any given time, Servicing Profiles will move devices to the latest release of Monthly Enterprise (Rollback scenarios aside). So, any in-scope device which checks in before Patch Tuesday gets version A, any device checking in after Patch Tuesday gets version B.
Same applies to devices which were subject to an exclusion window: Once they get online and sync with the service after the Exclusion Window has expired, those devices will go directly to then then-latest version, regardless of which version the device is currently on or has skipped in the mean time.

Thank you!

@manoth-msft   Thanks for helping with this.


feat: add stealth address validator

Add stealth address plugin to preserve privacy of smart acount owner.
Two modes to validate signature

0: signed by private key of stealth address
1: signed by owner's private key and secret used to generate stealth address.

Ref: https://hackmd.io/xgpI7DB_SPSyDOLsYGI1tA

Can you share the link of repository you referenced for eliptic curve library?

here's the repo: https://github.com/witnet/elliptic-curve-solidity

Any other way to perform the validation of the signature aggregation? Since, based on the witnet estimation, it would be at least 250k gas per validation
And btw, not a huge fan of the ownership changes event (triple indexed params, old one can easily be retrieved via the index on the kernel account), if we don't take in account the sload needing to perform

I'll take care about the sload in separate PR for gas saving
@jstinhw

Any other way to perform the validation of the signature aggregation? Since, based on the witnet estimation, it would be at least 250k gas per validation

can you confirm there aren't any other way for signature aggregation?

@KONFeature @leekt Thanks for the suggestion. I found another way to do verification which can reduce the gas to 1/6 compared to the aggregated signature. The tradeoff is that it relies on zk proof verification on-chain. Here's more information about the scheme


Rearranging of side nav

Rearrange side nav to this list:
-Dashboard
-Manage Class (admin)
-Manage Schedule (admin)
-View Data
-Register Student
-Enroll Student

Task done.


Fix: NoteOff event may not triggered

The 0x90 event could not be received on my AHK, instead it triggered the 0x80 event with no velocity.
My keyboard is M-Audio KeyStation MINI32.

This was indeed the case for me as well with a Yamaha PSR-620.


[BUG] Chinese parenthesis can't auto replace.

I create a rule to replace the Chinese parenthesis in the code line.
{trigger: "`(.*)（）", replacement: "`[[0]]()", options: "rt"},

The options are "rt", and it works when I press the Tab.
But if I set options to "rtA", it doesn't work.
The test code: abc（）

Works for me

Works for me

I'm now using a global way of handling Chinese and English symbols, like AHK.
So I didn't try this again.

👍 Then I think this issue is stale. Maybe you can close it for the convenience of maintenance.


knock knock !!

down ?? ;)

From #google-home on Slack:

It looks like there are a few users pushing status/sensor updates when nothing has changed too quickly again which is causing excessive load on the back end of the NR-GAB system. I am away at the moment so don't have time to do the log analysis to work out exactly who and ask them to stop. If the service is still impacted Sunday night when I get back I will chase them down.

we perhaps need a "small fee" registering annual account to get ride of some of them ?? ;=)

I've managed to find a quiet 20mins to disable a few accounts and the load levels look better.
So I'm going to close this for now.

I've managed to find a quiet 20mins to disable a few accounts and the load levels look better.
So I'm going to close this for now.

we love you ;) <3


Translate challenge 61 into p5.js

A literal translation of challenge 61 (Fractal Spirograph) into p5.js

Amazing, thank you!


Galaxy DemoCoin Testnet v0.0.4-alpha-demo UX enhancements

Galaxy DemoCoin Testnet v0.0.4-alpha-demo UX enhancements
The following are the list of enhancements to be made to Galaxy DemoCoin Testnet Alpha Demo for Sprint 3

[ ] #18 Improve UX and brand feeling in install script
[ ] #22 Ensure timeouts do not happen during Galaxy DemoCoin Demo sync
[x] #23 Install instructions

Will improve the install instructions tomorrow, and coordinate with Vsund on implementing his new script for TN4.

Closed this issue in favor of #50


Update prott to 1.0.4

After making all changes to the cask:

[x] `brew cask audit --download {{cask_file}}` is error-free.
[x] `brew cask style --fix {{cask_file}}` left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as dae876ae5f5396d8394dae52733759666667412f. Your contribution is still credited to you.


AWS -LambdaInvoke task

this might be a good starting point

Maybe naive question, but couln't be possible to call the Lambda function via a HTTP call thanks with the corresponding Kestra task https://kestra.io/plugins/plugin-fs/tasks/http/io.kestra.plugin.fs.http.request 🤔 ?
Like, I believe AWS Lambda can send a response only when the process is finished isn't ?

Though I agree with a broader vision: you might want to trigger a Kestra flow as soon as an async AWS Lambda run finish for example.

I know that @loicmathieu recommends using the officially supported Java SDK, such as the one provided by AWS, when possible, so this is why I suggested it. Up to the development team to figure out the right solution

Done via #238

man I was editing the issue :D


revert preview build

Deploy preview for stackoverflow-clone-frontend ready!
✅ Preview
https://stackoverflow-clone-frontend-dovbauj28-mayank2aggarwal-gmailcom.vercel.app
Built with commit 81751112d51bb554a6e6c2330669024dbe0fcb4c.
This pull request is being automatically deployed with vercel-action


Cannot run commands on Windows + WSL

Hi,
Not sure if I've set something up wrong or if it's an issue with running in this way.
I have a tauri project that works fine when running the tauri cli via npm in the way that the template tool creates it (eg npm run tauri dev) but when in a workspace with just that project, running the command "Tauri: Dev" from the command pallet gives the following error dialog:

A similar dialog shows for all the other commands too.
I have tried installing @tauri-apps/cli globally in case this was needed, but this doesn't seem to affect anything.
Setup:
Windows 11 with WSL running Ubuntu 20.04
npm: 8.11.0
node: v16.16.0
cargo: cargo 1.62.1 (a748cf5a3 2022-06-08)
rustc: rustc 1.62.1 (e092d0b6b 2022-07-16)
VSCode: 1.70.2
tauri-vscode: v0.1.6 Extension is enabled on 'WSL: Ubuntu-20.04'

could you try this suggestion https://stackoverflow.com/a/56129225 and see if you can get more info about the error?


changeValidationEmail

Hi,
could you please add this feature: Change validation email
it has been added on the new gogetssl api lib
thanks !

i will update, thanks

i was trying to do it my self but i couldn't
thanks !


RFC: projen init FOO

$ mkdir my-first-jsii-library
$ cd my-first-jsii-library
$ npx projen init jsii
.projenrc.js generated from the "jsii" template.
go edit it, nothing there is what you want (until someone adds interactive mode (#552))
$ edit ...
$ npx projen // or "pj" for the die hard
$ ls
<all of it, ready to rock>

@andrestone if you are looking for something to bit on next :-) --- it hurts me to need to copy & paste from the README every time I want to start a new project.

copy: @pahud

Done.


brew update Failure for update openssh

➜  ~ uname -a
Darwin Higkoos-MacBook-Pro.local 16.1.0 Darwin Kernel Version 16.1.0: Thu Oct 13 21:26:57 PDT 2016; root:xnu-3789.21.3~60/RELEASE_X86_64 x86_64
➜  ~ brew update
warning: unable to unlink .yardopts: Permission denied
warning: unable to unlink CONTRIBUTING.md: Permission denied
warning: unable to unlink SUPPORTERS.md: Permission denied
fatal: cannot create directory at '.github': Permission denied
Error: Failure while executing: git pull -q origin refs/heads/master:refs/remotes/origin/master
➜  ~ brew update
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require': cannot load such file -- mach (LoadError) 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require'
from /usr/local/Library/Homebrew/extend/pathname.rb:2:in <top (required)>' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require' 	from /usr/local/Library/Homebrew/global.rb:3:in <top (required)>'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require'
from /usr/local/Library/brew.rb:15:in `'
➜  ~ brew update
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require': cannot load such file -- mach (LoadError) 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require'
from /usr/local/Library/Homebrew/extend/pathname.rb:2:in <top (required)>' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require' 	from /usr/local/Library/Homebrew/global.rb:3:in <top (required)>'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in require'
from /usr/local/Library/brew.rb:15:in `'
➜  ~ brew install openssh
Error: undefined method desc' for Formulary::Formulae::Openssh:Class Please report this bug:     https://git.io/brew-troubleshooting /usr/local/Library/Taps/homebrew/homebrew-dupes/openssh.rb:2:in class:Openssh'
/usr/local/Library/Taps/homebrew/homebrew-dupes/openssh.rb:1:in load_file' /usr/local/Library/Homebrew/formulary.rb:92:in module_eval'
/usr/local/Library/Homebrew/formulary.rb:92:in load_file' /usr/local/Library/Homebrew/formulary.rb:82:in klass'
/usr/local/Library/Homebrew/formulary.rb:71:in get_formula' /usr/local/Library/Homebrew/formulary.rb:200:in factory'
/usr/local/Library/Homebrew/extend/ARGV.rb:16:in block in formulae' /usr/local/Library/Homebrew/extend/ARGV.rb:16:in map'
/usr/local/Library/Homebrew/extend/ARGV.rb:16:in formulae' /usr/local/Library/Homebrew/cmd/install.rb:41:in install'
/usr/local/Library/brew.rb:135:in `'

What does brew config and brew doctor output?

You need to sudo chown -R $USER /usr/local. Also, you need to follow our issue template in future so we can help you.


Default to public interface for os-capacity

Bump

@assumptionsandg is this PR still relevant? Please either update it or close it


Unable to filter certain strings and decimal values

I've pulled down the sample code to test out the filtering for a monitor resolution api. The only change I've made to the provided sample code in examples/app.js is the qs variable
app.js
...
var qs = new MongoQS({
  custom: {
    //bbox: 'geojson',
    //near: 'geojson',
    exists: 'hdmi',
    equal: 'resolution'
  }
});
...

Database:
[
  {
    "series": "meh-monitor",
    "hdmi": false,
    "hdmi_version": "",
    "vga": true,
    "resolution": "1366x768"
  },
  {
    "series": "ok-monitor",
    "hdmi": true,
    "hdmi_version": "1.0",
    "vga": true,
    "resolution": "1920x1080"
   },
  {
    "series": "good-monitor",
    "hdmi": true,
    "hdmi_version": "1.2",
    "vga": false,
    "resolution": "2560x1440"
  }
]

Working Sample URLs:

localhost:3000/api/places works returns all objects
localhost:3000/api/places?hdmi=true, works returns objects with hdmi being true
localhost:3000/api/places?series=ok-monitor, works and returns only the status "ok-monitor"

Non working sample URLs:

localhost:3000/api/places?resolution=2560x1440
localhost:3000/api/places?hdmi_version=1.2, do want to note running this the qs variable had equal: 'hdmi_version'

@wsfuller and thank you for reporting this in such detail!
Put this configuration in your app.js and both of these non-working URLs should start working:
...
var qs = new MongoQS({
  custom: {
    //bbox: 'geojson',
    //near: 'geojson',
    exists: 'hdmi',
    equal: 'resolution'
  },
  string: {
    toNumber: false
  }
});
...

@Starefossen thanks for the response, unfortunately this isn't working as expected with the suggested change.
app.js
var qs = new MongoQS({
  custom: {
    exists: 'hdmi',
    equal: 'resolution'
  },
  string: {
    toNumber: false
  }
});

url
localhost:3000/api/places?resolution=2560x1440
data
 {
    "series": "good-monitor",
    "hdmi": true,
    "hdmi_version": "1.2",
    "vga": false,
    "resolution": "2560x1440"
  }

I am running a console.log on the query:
app.js
...
  // Parse the request query parameters
  var query = qs.parse(req.query);
  console.log(query);
...

returns { resolution: 2560 }
So for some reason at the "x" the req.query stops. As well still not able to query ...?hdmi_version: 1.2

Could you try updating to at least v2.0.0 as the toNumber option was introduced in that version.

Apologies, didn't see the pull request until right after I posted the comment

No worries, I hope this solves your problems 😄

So I pulled down v3.0.0 and added in string:{ toNumber: false}. After trying localhost:3000/api/places?resolution=2560x1440 was still not returning expected results. So looking at the pull request made 4 days ago I just manually added in your fix on line 192
fix line #192
...
} else if (this.string.toNumber && !isNaN(parseInt(string, 10)) &&
(+string - +string + 1) >= 0) {
...

That solves the resolution issue and localhost:3000/api/places?resolution=2560x1440 is working as expected.
After removing the string property of hdmi_version: 1.2 and making it an integer that is working as expected now as well.
New to databases and JSON and didn't realize that having a decimal integer was acceptable, my thought was having a dot would make it invalid for some reason.
Thanks for your help :+1:

That patch from #24 has landed in v3.1.0


Dspv2 merge

Final pull-in PR
Testing instructions
Standard Sanity tests
Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/535/head
git checkout -b pullrequest ae3f49b1b2f91c91b23234b154f5ec4fcc14f953
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-535"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535

/lgtm

/approve


implemented passing of anonymous user when authentication fails when …

implemented passing of anonymous user when authentication fails or there is no token when configuration allows such behavior;

I'm assuming this won't be merged until it passes testing?
I'm currently experimenting with the plugin and believe this functionality of being able to logically 'or' (chain multiple oidc plugins) will be supported with this change.
Per kong documentation Multiple Auth


Update bower.json

Add paper-dialog-behavior to dependencies, as it is required by app-datepicker-dialog component

LGTM 👍 Thank you.


Setup and Use

Not sure if we are using cacher correctly, I just manually run the script everyday. Should I be using launchd or some other process?

You could definitely use LaunchD. I use a cronjob.
https://onemoreadmin.wordpress.com/2015/05/19/re-introducing-cacher/


Enable TCP Keep-Alives

As referenced in https://github.com/contribsys/faktory/issues/273#issuecomment-576463404, TCP Keep-Alives are used to keep a connection marked as active. While neither the worker nor heartbeat threads have a moment in which the connection goes quiet, we've seen behaviour matching the original issue.
This changes enables TCP Keep-Alives as a precaution.

@TurtleSRE thanks, I will cut a release in minutes


CT: Improve formulation of user need

Currently says: 'As someone who is eligible to travel for free [...] So that I am able to travel for free'

@petegale

Should say "As someone who is old enough for a bus pass, I need a bus pass so that I can prove I'm eligible to ride for free on a bus."

As someone who is old enough for a bus pass
I need to apply for a concessionary travel permit
So that I am able to travel for free


Move bias_gelu_unary to eltwise/binary with overload

Modify this implementation https://github.com/tenstorrent/tt-metal/pull/10663 to bring bias_gelu_unary under one api
Modify bias_gelu in eltwise/binary with a separate struct to handle this overload

Merged #10840


chore(storage-image-labeling): rename extension

This PR renames the extension to "Image Labeling from Storage"

Closing as not needed


Failed to build on MacOS

/code/s/sfspeechrecognizer-example master = ❯ ssc build -r
• cleaned: /Users/peter/code/socketsupply/sfspeechrecognizer-example/build/mac +12ms
• preparing build for mac +12ms
• package prepared +9ms
• Building extension: SFSpeechRecognizer ((mac) desktop-arm64) +12ms
• Unable to build extension (SFSpeechRecognizer) +790ms
• Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)
Target: arm64-apple-darwin22.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
clang: error: no such file or directory: '/Users/peter/code/socketsupply/sfspeechrecognizer-example/build/mac/socket-runtime-sfspeechrecognizer-example-dev.app/Contents/Resources/socket/extensions/SFSpeechRecognizer/extension'
 +0ms

ls build/mac/socket-runtime-sfspeechrecognizer-example-dev.app/Contents/Resources/socket/extensions/SFSpeechRecognizer
.rw-r--r--@ 555Ki peter 28 Sep 11:22 -I  init.o

/code/s/sfspeechrecognizer-example master = ❯ uname -a
Darwin mac 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun  8 22:29:26 PDT 2023; root:xnu-8796.121.3~8/RELEASE_ARM64_T8112 arm64 arm Darwin

/code/s/sfspeechrecognizer-example master = ❯ clang++ --version
Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)
Target: arm64-apple-darwin22.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Are you using the latest SSC from master?

@jwerle I'm also unable to build with the latest SSC from master(I'm on macOS as well)

@jwerle I'm also unable to build with the latest SSC from master(I'm on macOS as well)

Do you have the same error?

Do you have the same error?
No:
• Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)
Target: arm64-apple-darwin22.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
clang: error: no such file or directory: './src/extension.mm'
clang: warning: -lsocket-runtime: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework UniformTypeIdentifiers: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework CoreBluetooth: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework Network: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework UserNotifications: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework WebKit: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework Cocoa: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -framework OSLog: 'linker' input unused [-Wunused-command-line-argument]
 +0ms

@missinglink @lamiazar can you share the output of ssc --version? I have:
0.4.0 (7f236cc8)
Installation path: /Users/werle/repos/socketsupply/socket-stable/build/npm/darwin/packages/@socketsupply/socket-darwin-arm64/

ssc -v
0.4.0 (62e26b02)
Installation path: /Users/lamia/socket/build/npm/darwin/packages/@socketsupply/socket-darwin-arm64/

@lamiazar Can you try building with the latest master branch from https://github.com/socketsupply/socket ?

@lamiazar Can you try building with the latest master branch from https://github.com/socketsupply/socket ?
yes, I'm on it

Your commit 62e26b02 seen when you do ssc --version is not the latest build from master. It refers to this moment in time: https://github.com/socketsupply/socket/commit/62e26b02

@jwerle I'm using this : ./bin/clean.sh && VERBOSE=1 ./bin/install.sh to build, but I'm still getting a different version
ssc -v
0.4.0 (8ddca54c)

I still have this issue after I updated ssc, Joe is working on it.

@jwerle I don't get any errors now but the window opens without any output

@lamiazar no worries, we'll get to this when we can. More pressing issues currently!

@lamiazar no worries, we'll get to this when we can. More pressing issues currently!

Sounds good, I'm doing some cleanup for the project board and I tried to reproduce this issue.


tweets.reply()

When doing tweets.reply() on an event emitter, I get this error:

Please either fix this or let me know how to fix this myself^^
Thank you

Will take a look tmr, since its midnight here, is that  okay? If  possible minimal code example to get this error
thanks

stream.on("tweet", (tweet) => {
tweet.reply("text").then(tweet2 => {
console.log(tweet2.url)
}.catch((err) => {
console.log(err)
}
}

Seems like nothing wrong there, ill check tmr on my code samples


Update static build image reference

We're using 0.7-ppc4le as the Docker-in-Docker image for dynamic builds. Use the same for static builds.

LGTM


Plugin doesn't seem to be working for me at all, at least, based on my expectations from the description.

Plugin appears to not be working at all
Based on the description in the email received and the freeinternetplugin.com website, as well as the article on HackerNoon, the plugin doesn't appear to be working as described... at all really.
Browser  |  Search Engine
Vivaldi (latest)   |    StartPage.com
Brave (latest)     |   DuckDuckGo
To Reproduce
Steps to reproduce the behavior:

install either Vivaldi or Brave Browser
Configure either StartPage or DuckDuckGo as the search engine of choice.
Use Search Term: " about"
i.e., new york times about or wall street journal about

Expected behavior

Expected behavior is that the user will not see links to the paywalled sites in the SERPs.

Desktop (please complete the following information):

OS: Win10/64, Slackware -current, Debian Bulseye, Arch Linux
Browser: Vivaldi 4.0.2312.27 (Stable channel) (64-bit)
Browser: Brave Version 1.25.73 Chromium: 91.0.4472.106 (Official Build) (64-bit)

Actual Behavior

Search returns show multiple links to the actual sites that have blocking enabled in the plugin's config. i.e., NYT/WSJ, etc.
Paywalled sites, if visited via the links returned in search results will, as intended by those website publishers, throw up a paywall after a few seconds or after attempting to scroll the article in order to read.
It is as if the plugin does not work at all, and indeed, seems as if it does not.

Smartphone (please complete the following information):

Device: Have yet to test (Might be pointless)
OS: Android and CalyxOS
Browser: Vivaldi and Brave
Version: Will be the latest if plugin is installed and tested.

Additional Details
I wanted to leave a glowing review for the plugin in the chrome store. both browsers are compatible with Chrome plugins and there are currently only seven reviews. After an initial check to make sure that the plugin works it seems to absolutely not work at all, browser restarts, system reboot on windows, etc., fail to affect the behavior of search returns from DDG and StartPage. The same behavior is exhibited when using the Gigablast search engine.
I have not, nor will, test with Google as the search engine, so if this plugin only works with results from Google.com as the search provider then I would think that should be stated and then people who will never use Google will know this plugin is not for them.
I didn't want to just leave a review stating that the plugin doesn't work for me at all considering that the existing 6 reviewers awarded five stars each, so I figure there must be something in the configs (I changed/altered nothing) that needs to be set in order for this plugin to work as advertised.

Hi Bradley, thank you for getting in contact!
Currently, the users browser should not inhibit the plugin, but the plugin only works for Google search results, as they hold 92% of users and each search engine would require a custom script to work effectively.
Thank you for writing, I'm sorry that we can't meet your needs at this time.

Hi @Torbet , Okay I checked using Google.com and indeed, I can atest that I did not see any "nytimes.com" or similar for wsj, etc. - basically anything on the block list. nytco.com did come up, but that's not actually a paywalled site so it doesn't count ;)
Then I disabled the plugin, hit refresh, and voila! lotsa paywall crapolla down the page!
So.... I find it rather unfortunate that, as you state, that the plugin only works for results from searching via Google.com proper, as that's not a site that I typically will frequent, and sadly, they're going to get those paywalled results to me anyway via StartPage, since it's an aggregation of Google data.
Good news is... the plugin works as stated, quite well, and  without any noticeable degradation in time to retrieve results, but due to a myriad of reasons why I and others will not use Google.com for search results, the plugin isn't going to benefit me much, or at least very often, at this time.
Given some time, contributory PRs, and perhaps a bit of funding from folks, perhaps you'll be able to expand upon the list of actual search engines that this plugin serves, since it does indeed to do what it sets out to do so well. For that, I am quite elated!
I'm not going to close this issue however, since I would imagine that many others who remove Google as their search provider from their browsers will come across the same confusion, but please do feel free to close the issue if you feel it best :)
If you're open to it, I made two clarifications in the text and issued a PR for you to consider. With that, #16 , this issue probably won't serve a purpose any longer :)
Thanks for this fantastic plugin - a sorely needed takeback for privacy concsious individuals!

Thank you for the feedback, will look over your PR and update the readme to make everything more transparent!
It is still early days and we wanted to get a MVP out the door, which I think you can agree targeting Google results is the best option to start with. With time, we will definitely look into supporting more search engines and then can hopefully cater to the more privacy-oriented folks!


Inference in Colab fails

Follow message (added some print statements to debug and removed clear_output) - Please advise
chosen_model: https://www.dropbox.com/s/8mmgnromwoilpfm/16L_64HD_8H_512I_128T_cc12m_cc3m_3E.pt?dl=1 folder_ /content/outputs/Cucumber_on_a_brown_wooden_chair/ Traceback (most recent call last):   File "/content/dalle-pytorch-pretrained/DALLE-pytorch/generate.py", line 18, in <module>     from dalle_pytorch import DiscreteVAE, OpenAIDiscreteVAE, VQGanVAE, DALLE   File "/content/dalle-pytorch-pretrained/DALLE-pytorch/dalle_pytorch/__init__.py", line 1, in <module>     from dalle_pytorch.dalle_pytorch import DALLE, CLIP, DiscreteVAE   File "/content/dalle-pytorch-pretrained/DALLE-pytorch/dalle_pytorch/dalle_pytorch.py", line 11, in <module>     from dalle_pytorch.vae import OpenAIDiscreteVAE, VQGanVAE   File "/content/dalle-pytorch-pretrained/DALLE-pytorch/dalle_pytorch/vae.py", line 14, in <module>     **from taming.models.vqgan import VQModel, GumbelVQ** ImportError: cannot import name 'GumbelVQ' from 'taming.models.vqgan' (/usr/local/lib/python3.7/dist-packages/taming/models/vqgan.py)

Fixed-- retry.

Now I getting a different issue file/image not found. Under '/content/dalle-pytorch-pretrained/' there is no folder by the name DALLE-pytorch

Now I getting a different issue file/image not found. Under '/content/dalle-pytorch-pretrained/' there is no folder by the name DALLE-pytorch

The issue is in the !wget command in 2nd code block line 36, the /content/ at end is a directory, change it to /content/0.14.3.zip. It solves the above issue.

Now I getting a different issue file/image not found. Under '/content/dalle-pytorch-pretrained/' there is no folder by the name DALLE-pytorch

@johnpaulbin  Sorry not trying to  be a pest, please advice on this issue

Follow the message (added some print statements to debug and removed clear_output) - Please advise
chosen_model: https://www.dropbox.com/s/8mmgnromwoilpfm/16L_64HD_8H_512I_128T_cc12m_cc3m_3E.pt?dl=1 folder_ /content/outputs/Cucumber_on_a_brown_wooden_chair/ Traceback (most recent call last): File "/content/dalle-pytorch-pretrained/DALLE-pytorch/generate.py", line 18, in <module> from dalle_pytorch import DiscreteVAE, OpenAIDiscreteVAE, VQGanVAE, DALLE File "/content/dalle-pytorch-pretrained/DALLE-pytorch/dalle_pytorch/__init__.py", line 1, in <module> from dalle_pytorch.dalle_pytorch import DALLE, CLIP, DiscreteVAE File "/content/dalle-pytorch-pretrained/DALLE-pytorch/dalle_pytorch/dalle_pytorch.py", line 11, in <module> from dalle_pytorch.vae import OpenAIDiscreteVAE, VQGanVAE File "/content/dalle-pytorch-pretrained/DALLE-pytorch/dalle_pytorch/vae.py", line 14, in <module> **from taming.models.vqgan import VQModel, GumbelVQ** ImportError: cannot import name 'GumbelVQ' from 'taming.models.vqgan' (/usr/local/lib/python3.7/dist-packages/taming/models/vqgan.py)

@johnpaulbin @PrithivirajDamodaran can you please share how this issue was resolved? I'm facing on my GPU

On the DeepSpeed Sparse Attention doc page, there's this:

Note: Currently, DeepSpeed Sparse Attention can be used only on NVIDIA V100 or A100 GPUs using Torch >= 1.6 and CUDA 10.1, 10.2, 11.0, or 11.1.

I have access to a v100 and ran the notebook on it (after adding the fixes) but I encountered the same issue. I ran it on CUDA 11.4 rather than 11.1 so that may be an issue. Colab is on 11.1.
Is is possible to run the notebook on an older version of DeepSpeed?


Error on build: neovim-node-client doesn't exist

Due to how new neovim-node-client is on nixpkgs, it simply does not exist for a large chunk of systems. I would personally not use it, or add a failsafe, until at minimum the package is in a stable release.
Full error:
lib.customisation.callPackageWith: Function called without required argument "neovim-node-client" at /nix/store/niaq0axr15cm1dh6w4h8hwr1nplir1as-source/wrapper.nix:4

it was renamed https://github.com/NixOS/nixpkgs/commit/159c8401016a50fcbd6aece36eeb3e6a8948b039
either set useNodeJS to false,
use a older mnw rev like 5fe5c41975ed0af55f55dc37cd28ba906a5d015e,
or use a nixpkgs commit after the above linked nixpkgs commit

attempting to fix in 24.11 with this backport https://github.com/NixOS/nixpkgs/pull/361286.
otherwise i'll have to fix it with a check

backport merged, i'm gonna make a tag for pre-24.11 usage