Js warning in Chrome: AudioContext is not allowed to start

thank you very much !

Anyone who is monitoring this, the solution to this is pretty easy, in the example there is a line like this:
const audioContext =  new (window.AudioContext || window.webkitAudioContext)();
Really what you want to do is create the audioContext in your click handler, not as a const. E.g.

var audioContext = null;
$(".record").click(function() {
  if (audioContext == null) {
      audioContext =  new (window.AudioContext || window.webkitAudioContext)();
  }
  // rest of example will work now
});

@cain06 @ijsnow
from line 37 in example
I created new audioContext like this:
start = () => {
      this.audioContext =  new (window.AudioContext || window.webkitAudioContext)();
      this.recorder.start()
        .then(() => this.setState({isRecording: true}));
    }

but It still warning and I can not record anything.

Here is my code to solve this problem in React.
class App extends Component {
constructor(...args) {
super(...args);
this.state = {
  blob: null,
  isRecording: false,
  stream: null,
  analyserData: {data: [], lineTo: 0},
  nowRecord:null,
};

this.start = this.start.bind(this);
this.stop = this.stop.bind(this);
this.download = this.download.bind(this);

this.audioContext = null;
if (this.audioContext == null) {
  this.audioContext =  new (window.AudioContext || window.webkitAudioContext)();

  this.recorder = new Recorder(this.audioContext, {
    onAnalysed: data => this.setState({analyserData: data}),
  });

}
navigator.mediaDevices.getUserMedia({audio: true})
.then((stream) => {
this.recorder.init(stream);
})
.catch(this.dontGotStream);
}
start() {
this.recorder.start()
...................


Add recipe advancements

adds advancements to unlock the various recipes of the mod so that the recipes can be viewed without the use of a recipe list mod
Worth noting both scooters due to their custom recipe handler show up as Air in the vanilla recipe book but the recipes themselves still work fine

lgtm!
will triage the bug later, ty for the report.


make the LogCollector fields public

Problem
I need to use Refcell::replace on the collected logs instead of .take(), because I want to control the bytes_limit. This requires being able to construct a plain LogCollector instead of using new_ref_with_limit() which returns an Rc<RefCell<LogCollector>>.
I'd also like to be able to use a preallocated Vec for the messages field. At this point it seems simplest to just make all four fields public.
Summary of Changes
Makes the LogCollector fields pub

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.1%. Comparing base (d9d52be) to head (2db28fb).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1075     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%
=========================================
  Files         868      868
  Lines      234074   234126     +52
=========================================
+ Hits       192373   192408     +35
- Misses      41701    41718     +17


PSCore6 - Get-Service -Parameters Help information is missing.

Using Get-Help Get-Service -Parameters it giving an error.  Works file when using -Full parameter.
Get-Help Get-Service -full and Get-Help Get-Service -detailed - Works
FYI - this also fail in Windows PowerShell! I will create an incident in UserVoice!
Steps to reproduce
The following command error out!
Get-Help Get-Service -Parameter

Expected behavior
To display the help for Get-Service for parameters only.
No errors!

Actual behavior
PS C:\Program Files\PowerShell\6-preview> Get-Help Get-Service -Parameter
Get-Help : Missing an argument for parameter 'Parameter'. Specify a parameter of type 'System.String' and try again.
At line:1 char:22
+ Get-Help Get-Service -Parameter
+                      ~~~~~~~~~~
+ CategoryInfo          : InvalidArgument: (:) [Get-Help], ParameterBindingException
+ FullyQualifiedErrorId : MissingArgument,Microsoft.PowerShell.Commands.GetHelpCommand

Environment data

PS C:\Program Files\PowerShell\6-preview> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.1.0-preview.2
PSEdition                      Core
GitCommitId                    v6.1.0-preview.2
OS                             Microsoft Windows 10.0.17677
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

PS C:\Program Files\PowerShell\6-preview>

@MaximoTrinidad There is no -Parameters parameter to Get -Help, only -Parameter which takes as an argument the name of the parameter to get help on.
Get-Help [[-Name] <string>] -Parameter <string> [-Path <string>] [-Category <string[]>] [-Component <string[]>] [-Functionality <string[]>] [-Role <string[]>]

If you specify a valid parameter name, you'll get output on that parameter:
PSCore (1:35) >  get-help get-service -parameter RequiredServices

-RequiredServices [<SwitchParameter>]
    Indicates that this cmdlet gets only the services that this service requires.

    This parameter gets the value of the ServicesDependedOn property of the service. By default, this cmdlet gets all services.

    Required?                    false
    Position?                    named
    Default value                False
    Accept pipeline input?       False
    Accept wildcard characters?  false

I have tripped on this myself a few times. it does take wild cards so this works:
get-help Get-Service -Parameter *

I have tripped on this myself a few times. it does take wild cards so this works:
get-help Get-Service -Parameter *

@BrucePay  @markekraus   I think this is a kind of feature request to have a parameter which can list Help for a cmdlet by detailing only the Parameters in it.
@MaximoTrinidad  (Get-Help Get-Service).Parameters can be used here.

@kvprasoon you can already do that with Get-Help Get-Service -Parameter *. though.. to find that out you do have to run Get-Help Get-Help -Parameter Parameter... 🤣

OK!!  I got it know.
So, it needs a string value.  Sorry!
I thought a default "All" value was already set for it.  Dah!!
Thanks Everyone!
I will close the issue.
:)


Fix large number of active session history rows

What does this PR do?
Fix limit when selecting active session history samples.
Motivation
The limit didn't work properly so the whole session history was selected.
The feature was introduced in 7.58.0.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


validate_actions raises errors on (some) invalid actions

I am running a 'random' agent.
luxai_s2 random_player/main.py random_player/main.py

but i am see ungraceful handling of invalid actions.
agent.py
from lux.kit import obs_to_game_state, GameState, EnvConfig, to_json
from lux.utils import direction_to, my_turn_to_place_factory
import numpy as np
import sys

class Agent():
    def __init__(self, player: str, env_cfg: EnvConfig) -> None:
        self.player = player
        self.opp_player = "player_1" if self.player == "player_0" else "player_0"
        self.env_cfg: EnvConfig = env_cfg

    def early_setup(self, step: int, obs, remainingOverageTime: int = 60):

        action = dict()
        if step == 0:
            # bid 0 to not waste resources bidding and declare as the default faction
            action = dict(faction="AlphaStrike", bid=0)
        else:
            game_state = obs_to_game_state(step, self.env_cfg, obs)
            # factory placement period

            # how much water and metal you have in your starting pool to give to new factories
            water_left = game_state.teams[self.player].water
            metal_left = game_state.teams[self.player].metal

            # how many factories you have left to place
            factories_to_place = game_state.teams[self.player].factories_to_place
            # whether it is your turn to place a factory
            my_turn_to_place = my_turn_to_place_factory(game_state.teams[self.player].place_first, step)
            if factories_to_place > 0 and my_turn_to_place:
                action = self.random_factory_spawn(obs)

        return action

    def random_factory_spawn(self, obs):
        # we will spawn our factory in a random location with 150 metal and water
        potential_spawns = np.array(list(zip(*np.where(obs["board"]["valid_spawns_mask"] == 1))))
        spawn_loc = potential_spawns[np.random.randint(0, len(potential_spawns))]
        return dict(spawn=spawn_loc, metal=150, water=150)

    def act(self, step: int, obs, remainingOverageTime: int = 60):
        actions = dict()
        state = obs_to_game_state(step, self.env_cfg, obs)

        factories = state.factories[self.player]
        units = state.units[self.player]

        for factory_id, factory in factories.items():
            a = np.random.randint(3)
            actions[factory_id] = a

        for unit_id, unit in units.items():
            a = [
                np.random.randint(6),
                np.random.randint(5),
                np.random.randint(5),
                np.random.standard_normal(),
                1
                ]
            actions[unit_id] = [a]

        return actions

and this gives
Traceback (most recent call last):
  File "/home/act65/miniconda3/bin/luxai_s2", line 33, in <module>
    sys.exit(load_entry_point('luxai-s2', 'console_scripts', 'luxai_s2')())
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_runner/cli.py", line 96, in main
    asyncio.run(eps.run())
  File "/home/act65/miniconda3/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/home/act65/miniconda3/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
    return future.result()
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_runner/episode.py", line 123, in run
    new_state_obs, rewards, dones, infos = self.env.step(actions)
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_s2/env.py", line 627, in step
    actions_by_type = validate_actions(self.env_cfg, self.state, actions_by_type, verbose=self.env_cfg.verbose, weather_cfg=weather_cfg)
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_s2/actions.py", line 304, in validate_actions
    water_cost = factory.water_cost(env_cfg)
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_s2/factory.py", line 126, in water_cost
    return int(np.ceil(len(self.grow_lichen_positions) / config.LICHEN_WATERING_COST_FACTOR))
TypeError: object of type 'NoneType' has no len()

if i change the random factory actions to not allow watering (ie change to a = np.random.randint(2) )(which seems to be the casue of the issue above). i get more gracefully handled invalid actions. eg
1: [Player 0] Inappropriate action given. invalid action [[ 4.          3.          3.         -1.26433067  1.        ]] for unit_6
1: [Player 1] Inappropriate action given. invalid action [[ 1.          0.          3.         -1.13325413  1.        ]] for unit_11
0.18390464782714844

but i also get a new error
1: [Player 1] Inappropriate action given. invalid action [[ 1.          0.          2.         -1.14128725  1.        ]] for unit_9
Traceback (most recent call last):
  File "/home/act65/miniconda3/bin/luxai_s2", line 33, in <module>
    sys.exit(load_entry_point('luxai-s2', 'console_scripts', 'luxai_s2')())
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_runner/cli.py", line 96, in main
    asyncio.run(eps.run())
  File "/home/act65/miniconda3/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/home/act65/miniconda3/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
    return future.result()
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_runner/episode.py", line 123, in run
    new_state_obs, rewards, dones, infos = self.env.step(actions)
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_s2/env.py", line 627, in step
    actions_by_type = validate_actions(self.env_cfg, self.state, actions_by_type, verbose=self.env_cfg.verbose, weather_cfg=weather_cfg)
  File "/home/act65/Documents/repos/rl-games/lux/Lux-Design-S2/luxai_s2/luxai_s2/actions.py", line 176, in validate_actions
    transfer_pos: Position = unit.pos + move_deltas[transfer_action.transfer_dir]
IndexError: only integers, slices (`:`), ellipsis (`...`), numpy.newaxis (`None`) and integer or boolean arrays are valid indices

ahh. when i change the transfer_amount to be an int it fixes the latter problem. i think. my bad...

this issue appears to be fixed now.


Sorting of "Filter by repository"

Currently the sidebar sorting is not really obvious. Seems neither alphabetically nor by number of issues.
Github itself sorts it by number of issues, that's what we should do too.

Current sorting is by date of notification, repo with most recent notification is at top.

Ok, that's not obvious. As I said abobe we should probably adopt the Github way of sorting, by number of issues.

I agree this sorting is not obvious, but it doesn't mean it is wrong ;-)
I used this sorting as github groups notifications by repositories in its https://github.com/Daskiworks/ghwatch/notifications page main area, and repository with most recent notification is on top (at least I think it is this order).
I don't think sorting by number of notifications (which is used in the github's page left sidebar) is better in any way.
If I think about sidebar as navigation point then alphabetical sorting may give a bit more sense maybe, as user can simply find what he is looking for if there is lots of items.
But at the end, for smaller number of items there, each of these  three types of sorting is nearly equal I think, so I'm not sure if change will bring any improvement.

Well, I’m also not sure which sorting makes more sense. Sorting a whole repo by the time of the last notification seems off though.
So when in doubt it’s best to align with the system we’re designing for, which in this case is https://github.com/notifications – and they sort the repos by number of notifications/issues.

OK, I did it this way. But order of repos with same number of notifications is not exactly same, I have no idea how they  sort them on github


tracing: kafka-broker-dispatcher: add trigger's name and uuid to kafka-broker-dispatcher's trace tags

Problem
A short explanation of the problem, including relevant restrictions.

The 'post' operation trace generated by kafka-broker-dispatcher currently only includes the 'http.url' in its tags.
Distinguishing between traces becomes challenging when multiple triggers with different filters share the same subscriber URL.
To address this issue, I propose adding the trigger's name and UUID to the trace tags.
I believe this is achievable since RecordDispatcherImpl class has access to the trigger's name and UUID through consumerVerticleContext.getEgress().getReference().
This information can be added to the span during creation or when invoking span.finish() or .fail().
However, I acknowledge that this is a speculative suggestion.
Persona:
Which persona is this feature for?
Event consumer (developer)
Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.
trace tags contains trigger uuid and trigger name tags.
Time Estimate (optional):
How many developer-days do you think this may take to resolve?
Additional context (optional)
Add any other context about the feature request here.

/triage accepted
@eddy-oum would you be interested in contributing a fix for this? I would be happy to help you get started

@Cali0707
sure, i will be glad to contribute.

@Cali0707
I looked in to the code and think I can include egress ref's to the tags by using a diffrent tag extractor for the reciever.
But this means I have to add egressName and egressUuid to the TraceContext(https://github.com/knative-extensions/eventing-kafka-broker/blob/main/data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/tracing/kafka/TraceContext.java)
I was wondering if introducing egress related fields to the TraceContext is optimal since

the TraceContext class is shared by both producer and the consumer
its fields are related to kafka only

// https://github.com/knative-extensions/eventing-kafka-broker/blob/main/data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/tracing/kafka/ConsumerTracer.java
    public class StartedSpan {
        private final S span;

        private StartedSpan(S span) {
            this.span = span;
        }

        public void finish(Context context) {
            // We don't add any new tag to the span here, just stop span timer
            // tracer.sendResponse(context, null, span, null, TagExtractor.empty());

            // use a new tag extractor that add egress.name and egress.uuid from trace context.
            tracer.sendResponse(context, null, span, null, EgressTraceTags.TAG_EXTRACTOR);
        }

        public void fail(Context context, Throwable failure) {
            tracer.sendResponse(context, null, span, failure, EgressTraceTags.TAG_EXTRACTOR);
        }
    }

/assign

@Cali0707
I've submitted a pr.
It appears that we can include tags from various classes, such as StartedSpan::finish / :: fail and TracingSpan::decorateCurrentWithXYZ, etc.
For simplicity, I added decorateCurrentWithEgress to the TracingSpan class. If there are more effective approaches to handle this, feel free to share your thoughts and suggestions. Thanks!


BoneDetecter did compile and run, but the generated output same as the input

First, your sharing and effort are great!
I am not sure where goes wrong, leading my generated app following your shared code "BoneDetecter", and run on iPhone 8 Plus, does not generate a video that having points and vectors of the Pose, the output video simple the same video I capture or selected from iPhone's album.
Pre-condition:
#1 iPhone 8 Plus with Xcode 10;
#2 Download pod install, and download MobileOpenPose.mlmodel
#3 Run on Phone, the UI allow select or capture video for processing
#4 The Processing taking longer time than your "Stickman Animator" as apple-to-apple compare
#5 The App said video generated, and i go and check the video, it is simply the same as input
Questions:
Q1: Does the shared source code very different to your "Stickman Animator" on AppStore?
Q2: Where I miss, leading the generated video does not contains the recognised vectors?
Many thanks for your sharing again.

Thank you for trying.
Pre-condition:
"Bone Detecter" is confirmed to work with Xcode 9.
Xcode 10 is Beta, it is not a priority task.

Questions:
Q1: Does the shared source code very different to your "Stickman Animator" on AppStore?
It is different from "Stickman Animator" code.
"BoneDetecter" is a suggestion, a minimal implementation.

Q2: Where I miss, leading the generated video does not contains the recognised vectors?
In conclusion I do not know what is the cause.
This is the terminal at hand.
iPhoneX, iPhone 7, iPhone 6, iPad 5 th, iPad Pro
If it is caused by iPhone 8 Plus, it is very difficult for me to solve the problem.

Thank.


envoy: Bump envoy version to v1.24.10

This is for the below CVEs from the upstream.
CVEs:
https://github.com/envoyproxy/envoy/security/advisories/GHSA-pvgm-7jpg-pw5g https://github.com/envoyproxy/envoy/security/advisories/GHSA-69vr-g55c-v2v4 https://github.com/envoyproxy/envoy/security/advisories/GHSA-mc6h-6j9x-v3gq https://github.com/envoyproxy/envoy/security/advisories/GHSA-7mhv-gr67-hq55
Build: The build is coming from https://github.com/cilium/proxy/actions/runs/5661705068/job/15340176601
Release: https://github.com/envoyproxy/envoy/releases/tag/v1.24.10

/test-backport-1.13


Fix local shutdown

The assert and the _rx suffix on the function are wrong, it is perfectly
fine to call from either rx or tx thread.
In principle it would be possible to have an optimised tx-thread-only version
which could skip the CLOSING_TX state and go right to CLOSING_RX, the current
state prior to this commit is a botched/incomplete attempt at such an
optimisation (but the wrong way round and broken).
Signed-off-by: Ian Campbell<EMAIL_ADDRESS>

I tested this with the tests where it failed before and now the tests pass. LGTM


Android Studio 3.2 发生异常

Could not determine artifacts for com.blankj:rxbus:1.4: Skipped due to earlier error.

https://stackoverflow.com/questions/38260311/gradle-sync-failed-could-not-determine-artifacts-for-com-android-supportrecycl
看看是不是这个问题


Fix for handling multiple site connections in a node spec.

@ashutosh-mishra @mageshgv-oc @Vikash082

@mageshgv-oc @ashutosh-mishra


SymbolStack: Use hash map instead of array for scopes

Benchmark 1 (16 runs): /home/ehaas/source/arocc/zig-out/bin/arocc -I. -fsyntax-only sqlite3.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time           332ms ± 1.00ms     331ms …  335ms          1 ( 6%)        0%
  peak_rss           62.1MB ± 44.2KB    62.1MB … 62.2MB          0 ( 0%)        0%
  cpu_cycles         1.27G  ± 2.18M     1.27G  … 1.27G           0 ( 0%)        0%
  instructions       3.35G  ± 1.91      3.35G  … 3.35G           1 ( 6%)        0%
  cache_references   2.05M  ± 23.7K     2.02M  … 2.08M           0 ( 0%)        0%
  cache_misses        562K  ± 11.1K      541K  …  596K           2 (13%)        0%
  branch_misses      11.4M  ± 19.8K     11.4M  … 11.4M           2 (13%)        0%
Benchmark 2 (24 runs): /home/ehaas/source/hashmap-symbols/zig-out/bin/arocc -I. -fsyntax-only sqlite3.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time           210ms ±  559us     209ms …  211ms          1 ( 4%)        ⚡- 36.7% ±  0.2%
  peak_rss           62.3MB ± 57.2KB    62.3MB … 62.4MB          0 ( 0%)        +  0.3% ±  0.1%
  cpu_cycles          775M  ± 2.36M      771M  …  780M           2 ( 8%)        ⚡- 39.0% ±  0.1%
  instructions       1.66G  ± 5.47      1.66G  … 1.66G           2 ( 8%)        ⚡- 50.3% ±  0.0%
  cache_references   2.03M  ± 29.4K     2.00M  … 2.08M           0 ( 0%)        -  0.8% ±  0.9%
  cache_misses        545K  ± 7.67K      530K  …  561K           1 ( 4%)        ⚡-  3.1% ±  1.1%
  branch_misses      7.62M  ± 8.28K     7.60M  … 7.63M           0 ( 0%)        ⚡- 33.1% ±  0.1%

On a preprocessed zig2.c (with https://github.com/Vexu/arocc/commit/1cdf4d5380d72cd71d2a4c8dd552cd7eae4018c3 reverted to prevent a parse error) I get the following:
GCC 13.2
time gcc -fsyntax-only -Wfatal-errors -undef -std=c99 preprocessed.c

real	1m4.331s
user	1m3.934s
sys	0m0.390s

With this branch I get
time arocc -fsyntax-only -Wfatal-errors -undef -std=c99 preprocessed.c

real	0m6.572s
user	0m6.043s
sys	0m0.521s

We have a lot of spurious "non-void function does not return a value" warnings and some incorrect integer overflows but I don't think fixing those will make arocc 10x slower :)
As a future enhancement we could look at reusing scope hash maps instead of allocating and freeing them all the time.
Closes #321

Did this just to test it out, I might want to clean up the API a bit but the results look promising

As a future enhancement we could look at reusing scope hash maps instead of allocating and freeing them all the time.

With ArrayHashMap.shrinkRetainingCapacity you should be able to use the same scoping system as was used previously.

ArrayHashMap preserves insertion order.

Unless I'm misunderstanding your suggestion, does that matter? We don't need to iterate over the keys/values, we only ever do lookups. I thought you were suggesting that in popScope we should just call shrinkRetainingCapacity (or clearRetainingCapacity) instead of deinit on the popped scope. And then deinit them all when we're finished. I think we'd just need to track the maximum number of scopes that were added, so we know how many to deinit at the end.

I meant that the current syms MultiArrayList would be replaced by the ArrayHashMaps and scopes would remain indexes into them.

Thinking about this some more - given that C allows variable shadowing, how would this work? e.g. if the code being parsed is:
int x = 5;
void foo(void) {
    float x = 1.0f;
}

We encounter the first x and insert it into the ArrayHashMap let's say at index 10. foo gets inserted at index 11, then we push a new scope and say that it starts at index 12. We encounter the second x and look that up, see that it's at index 10, so it's not in the current scope and we need to insert x again (at index 12). But since it's the same name as before we can't do that, right?

Hmm, I think it would probably be possible with a custom context that accounts for the scope index but that can be a future improvement.

Sounds good. When I get a chance I'm going to update it to use a multiarray of hashmaps and use clearRetainingCapacity when popping since that seems like an easy win.

Using clearRetainingCapacity made no difference in my benchmarks (sqlite3.c and zig2.c) in ReleaseFast, which was surprising to me.

Ok I ran the benchmarks again:
First is the baseline original hashmap implementation.
Second is with retaining the allocations
Third is with the .both update
Top set is zig2.c, bottom is sqlite3.c
Benchmark 1 (3 runs): /home/ehaas/source/arocc/zig-out/bin/arocc-baseline -fsyntax-only -Wfatal-errors -undef -std=c99 processed.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time          6.56s  ± 4.31ms    6.55s  … 6.56s           0 ( 0%)        0%
  peak_rss           1.23GB ± 53.3KB    1.23GB … 1.23GB          0 ( 0%)        0%
  cpu_cycles         25.0G  ± 8.71M     25.0G  … 25.0G           0 ( 0%)        0%
  instructions       53.1G  ± 19.5      53.1G  … 53.1G           0 ( 0%)        0%
  cache_references   59.8M  ±  763K     59.3M  … 60.6M           0 ( 0%)        0%
  cache_misses       26.7M  ±  149K     26.6M  … 26.9M           0 ( 0%)        0%
  branch_misses       249M  ±  153K      249M  …  250M           0 ( 0%)        0%
Benchmark 2 (3 runs): /home/ehaas/source/arocc/zig-out/bin/arocc-clear-retaining -fsyntax-only -Wfatal-errors -undef -std=c99 processed.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time          6.42s  ± 6.88ms    6.41s  … 6.43s           0 ( 0%)        ⚡-  2.1% ±  0.2%
  peak_rss           1.23GB ± 12.5KB    1.23GB … 1.23GB          0 ( 0%)          -  0.0% ±  0.0%
  cpu_cycles         24.4G  ± 30.0M     24.4G  … 24.4G           0 ( 0%)        ⚡-  2.2% ±  0.2%
  instructions       52.8G  ± 21.3      52.8G  … 52.8G           0 ( 0%)          -  0.4% ±  0.0%
  cache_references   59.7M  ±  811K     59.2M  … 60.6M           0 ( 0%)          -  0.1% ±  3.0%
  cache_misses       26.5M  ±  106K     26.4M  … 26.6M           0 ( 0%)          -  1.0% ±  1.1%
  branch_misses       246M  ± 64.3K      246M  …  246M           0 ( 0%)        ⚡-  1.5% ±  0.1%
Benchmark 3 (3 runs): /home/ehaas/source/arocc/zig-out/bin/arocc-small-opt -fsyntax-only -Wfatal-errors -undef -std=c99 processed.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time          6.50s  ± 11.4ms    6.49s  … 6.51s           0 ( 0%)          -  0.9% ±  0.3%
  peak_rss           1.23GB ± 36.9KB    1.23GB … 1.23GB          0 ( 0%)          -  0.0% ±  0.0%
  cpu_cycles         24.7G  ± 40.7M     24.7G  … 24.8G           0 ( 0%)          -  0.9% ±  0.3%
  instructions       53.1G  ± 32.2      53.1G  … 53.1G           0 ( 0%)          +  0.0% ±  0.0%
  cache_references   60.2M  ± 1.32M     58.9M  … 61.5M           0 ( 0%)          +  0.6% ±  4.1%
  cache_misses       26.7M  ±  131K     26.5M  … 26.8M           0 ( 0%)          -  0.1% ±  1.2%

Benchmark 1 (24 runs): /home/ehaas/source/arocc/zig-out/bin/arocc-baseline -I. -fsyntax-only sqlite3.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time           215ms ±  531us     214ms …  216ms          0 ( 0%)        0%
  peak_rss           62.3MB ± 48.9KB    62.2MB … 62.3MB          0 ( 0%)        0%
  cpu_cycles          794M  ± 1.77M      792M  …  798M           0 ( 0%)        0%
  instructions       1.67G  ± 9.35      1.67G  … 1.67G           1 ( 4%)        0%
  cache_references   2.06M  ± 22.9K     2.03M  … 2.11M           5 (21%)        0%
  cache_misses        544K  ± 7.78K      530K  …  558K           0 ( 0%)        0%
  branch_misses      7.76M  ± 9.45K     7.74M  … 7.78M           0 ( 0%)        0%
Benchmark 2 (24 runs): /home/ehaas/source/arocc/zig-out/bin/arocc-clear-retaining -I. -fsyntax-only sqlite3.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time           212ms ±  548us     211ms …  213ms          0 ( 0%)        ⚡-  1.7% ±  0.1%
  peak_rss           62.3MB ± 59.3KB    62.2MB … 62.4MB          0 ( 0%)          +  0.0% ±  0.1%
  cpu_cycles          779M  ± 2.05M      775M  …  784M           1 ( 4%)        ⚡-  1.9% ±  0.1%
  instructions       1.67G  ± 2.32      1.67G  … 1.67G           0 ( 0%)          -  0.2% ±  0.0%
  cache_references   2.06M  ± 24.6K     2.02M  … 2.10M           0 ( 0%)          +  0.3% ±  0.7%
  cache_misses        546K  ± 7.24K      536K  …  570K           1 ( 4%)          +  0.5% ±  0.8%
  branch_misses      7.72M  ± 7.19K     7.71M  … 7.74M           0 ( 0%)          -  0.4% ±  0.1%
Benchmark 3 (24 runs): /home/ehaas/source/arocc/zig-out/bin/arocc-small-opt -I. -fsyntax-only sqlite3.c
  measurement          mean ± σ            min … max           outliers         delta
  wall_time           213ms ±  604us     212ms …  214ms          0 ( 0%)          -  1.0% ±  0.2%
  peak_rss           62.3MB ± 54.7KB    62.2MB … 62.4MB          0 ( 0%)          +  0.0% ±  0.0%
  cpu_cycles          785M  ± 1.60M      782M  …  788M           0 ( 0%)        ⚡-  1.1% ±  0.1%
  instructions       1.67G  ± 7.53      1.67G  … 1.67G           1 ( 4%)          -  0.0% ±  0.0%
  cache_references   2.05M  ± 22.1K     2.03M  … 2.09M           0 ( 0%)          -  0.1% ±  0.6%
  cache_misses        549K  ± 7.08K      537K  …  562K           0 ( 0%)          +  1.0% ±  0.8%
  branch_misses      7.83M  ± 7.56K     7.82M  … 7.85M           0 ( 0%)          +  1.0% ±  0.1%


refactor(protocol-designer): account for multiples of a module in FormModules

closes AUTH-14
Overview
Preliminary work for adding multiples of a module support. This PR refactors FormModulesByType to FormModules and instead of being limited to one module of the same type, you can technically add as many modules as you want (though that functionality isn't added yet).
Additionally, this refactored type led to a refactor of the OT-2 select modules page (I got Felix's approval on this change)
Test Plan
Create a new protocol for flex and ot-2 and make sure selecting the modules and gripper/trash/waste chute works as it normally did
Changelog

refactor the type and the components that use the type
fix the tests
refactor ModuleFields

Review requests
see test plan
Risk assessment
low

question
Is this an expected behavior? (Mostly I create a Flex protocol and don't remember OT-2)

question
Is this an expected behavior? (Mostly I create a Flex protocol and don't remember OT-2)

@koji yup! its the collision warning stuff for only the h-s and ot-2. I'll leave design to decide if i need to reorganize it in the modal or not


What do you think of generational ZGC?

I heard it brings great performance improvements over regular ZGC so why isn't it mentioned? It seems to run fine for me (in fact it runs significantly better than g1gc on the client for me) and the next major version of Minecraft requires Java 21 anyways.

Okay, I never heard about this, it seems fine so I'll add it soon

Seems like ZGC is self-tuning, quickly wrote up a section about it.

Seems like ZGC is self-tuning, quickly wrote up a section about it.
Yeah but how does ZGenerational (generational ZGC) perform compared to the other GCs on the client and serverside? Could you add some benchmarks to the readme if possible? thank you very much!


CodeQL textobjects.scm

I was not able to define textobjects for class.inner and some functions inner. It seems a common problem for other languages, such as lua. Wondering if there is anything that can be done to help treesitter find the inner given an outer

I was not able to define textobjects for class.inner and some functions inner. It seems a common problem for other languages, such as lua. Wondering if there is anything that can be done to help treesitter find the inner given an outer

I think the best way is to have the language define a public node like block or for treesitter to allow access some anonymous nodes (those that start with _)

Yep, but normally you cannot change the parser and it would be nice to be able to access those inner textobjects. Like Lua's function_definition, I cant see any nodes for the body and I cant probably ask for it, but I know functions body starts after parameter parentheses and finishes before the end keyword so maybe we can mix regexps and treesitter to define Textobjects when they are not available in the tree

We eventually need either function.inner.end in addition to function.inner.end then we could define such objects by the first and last node.

Thats a brilliant idea. should I open an issue?

You can. there's already the code for function.inner.start. it's not the most elegant solution but you can already append extra nodes at the start of a node (c++ appends template declarations to function,outer).
We would need to have textobjects with start and end only or change the code that you don't need to have your cursor in the range of the end  node to append nodes at the start . probably the latter is better.


Update defaults: Stop adding the context menus!

Its incredibly annoying if I remove the all Shell context menus manually, and then on each minor update, it keeps re-creating them. I had to write a scavenging script to overcome this.
And if the propagation of Electron app is expected, then its make no sense to clutter with a ton of context menus, for each of them. And now even worse, its incredibly annoying to keep recreating, even if one removes it manually.
Please make the shell context menu creation optional on updates, as default with an option to over-ride. With default options to auto-create, its leading up to a disastrous end-user experience with cluttered menus. Let the developers do a little extra work, and opt-in, if it is absolutely required. Do not auto-create them, by default.
PS: Is this more appropriate to be filed under Squirrel? But since this is the packaged app framework, I thought it'd be appropriate to file it here, regardless of Squirrel.

Are you possibly talking about https://github.com/atom/atom/issues/5901?

Yes. I believe it is the issue. Thanks for noting that. I'll close this.


maistra-1.1: Add POD_NAMESPACE env variable to mixer policy deployment

Same as https://github.com/Maistra/istio/pull/56 but for maistra-1.1

Closing this in favor of https://github.com/Maistra/istio/pull/60


isNewRecord and afterSave()

$this->isNewRecord is false even we add a new record.
We need to use scenarios or something else to check if record is new in Yii 2, or this is a bug ?
public function afterSave($insert)
{
    if ($this->isNewRecord) { // === false even we insert a new record
        // code here ...
    }
    parent::afterSave($insert);
}

@vova07 I'm using 1.1.16, It act like isNewRecord is set to false after calling save().


Extension preserving compatibility

Is there any support for extension of serializable data structures that preserves compatibility?
Let's say I have a class that looks like this:

class Data implements CatalystSerializable {

  private String data;

  public void writeObject(BufferOutput<?> buffer, Serializer serializer) {
    buffer.writeString(data);
  }

  public void readObject(BufferInput<?> buffer, Serializer serializer) {
    data = buffer.readString();
  }

...and I work with lists of them (e.g. ArrayList<Data>). Now I want to add another field, let's say boolean anotherField.
The problem I ran into is, how to migrate the data to the newer type. First, I wanted to do something like this:
  public void readObject(BufferInput<?> buffer, Serializer serializer) {
    data = buffer.readString();
    anotherField = buffer.hasRemaining() ? buffer.readBoolean() : false;
  }

...to preserve compatibility, but then I found out that Catalyst doesn't guarantee that hasRemaining() works as expected. And indeed, it didn't work when deserializing ArrayList<Data>. hasRemaining() was returning true also for the Data without anotherField, because there were probably another elements from the same array in the buffer. What's worse, it caused ArrayListSerializer to be misaligned (not on the borders of the elements in the list) and when it tried to deserialize another element, it blew up :)
Is there any way for me to find out whether I have the old Data structure (without anotherField) or not, and act accordingly?
I'd expect that the Catalyst could do the work for me and wrap the elements so that I receive just the one I'm trying to deserialize or at least provide me a way to determine whether there are any data left from the current element in the buffer.
Thanks.

I ended up registering my own default serializer that provides a way to check whether there are more bytes available for reading.

Is there any other option or is this use-case not supported by Catalyst per se?


Specialization Constant as array size causes validation error

On drawing, the following error is triggered: Descriptor in binding #0 at global descriptor index 1 is being used in draw but has not been updated
The error appears regardless of the actual value of the constant. No error is triggered when using a "normal" constant variable with identical value instead. This behaviour appears at least for sampler, texture and buffer arrays.

This issue can be closed. I now realized that it was caused by an incorrect automated building of the DescriptorSets in my application.

You may have had another issue with your code, but we're still doing the wrong thing in validation with specialization. This is still on my plate.


MRC 183 - Remove link functionality

Removed HREF for the three links not needed for private beta testing.

I've changed it now, is this okay?


[RFC] Define a directory for CIAO packaging for major distributions.

Add Debian packaging files for CIAO
Dependencies already exists in Debian official repositories.

A directory called packaging were added. This directory should contain all the necessary files in order to construct a proper CIAO package for each major distribution(Fedora, Debian?). This PR add the files for Debian distribution.

Coverage decreased (-0.03%) to 64.721% when pulling 35cdac607f5233ad0673b1b3557f2c065ccd501e on erick0z:deb_packaging into 756be395b1340f0d85fb4c141791cd1ca7d32ecd on 01org:master.

I'd prefer to see that one under the already existing data/ directory.

While I get that "data/" is a go specific catch all for "stuff golang shouldn't try to compile" and would be the golang idiomatic location, I think "packaging" is a more descriptive top level for consumers of the project.  I wouldn't naturally go into a directory named "data/" in order to find deb or rpm specs, docker composition stuff or ansible scripts when an admin or distro builder is trying to figure out how to ship this ciao thing to their end users.

Turns out "data/" is not special.  Rather "testdata/" is special in the language.  And these are definitely not test data files.
'.' and "_" prefixed file and directory names are not processed by the golang tools.
In that case, I suggest calling the directory "_DeploymentAndDirectoryPackaging/" and creating subdirectories "debian", "rpm", "ansible", "docker", etc.

@tpepper, agree with the subdirectories part.
But that "_DeploymentAndDirectoryPackaging" looks too long. Could we use something shorter? maybe "_deployment", "_packaging". data looks more like configuration files dir (I saw the systemd bytes).

I can't type.  I meant "_DeploymentAndDistroPackaging/"
That's descriptive and not horribly long, imho.  Looks ok in the github UI to me:
https://github.com/tpepper/ciao/tree/scratch

Coverage decreased (-0.03%) to 64.721% when pulling 8a6aa066625d36b95b5ed51d82997c6e102e70fe on erick0z:deb_packaging into 756be395b1340f0d85fb4c141791cd1ca7d32ecd on 01org:master.

Coverage decreased (-0.03%) to 64.701% when pulling 7a41a869e58d597bcb5650168e82c9e154b8ae1e on erick0z:deb_packaging into 913912855b51b5f6244894ac1bcffc712b027bfd on 01org:master.

@tpepper Does that look fine to you now ?
@erick0z I think we can remove the [RFC] prefix now, can't we ?

Yep lgtm

@sameo, @tpepper, @obedmr. Done, thanks!


py.typed

My static type checkers complain about quax. It would be great to type annotate and add a py.typed to this repo!
Happy to contribute. It looks like there are a fair amount of type annotation present already 👍

Happy to take a PR on this! I think we should already be compatible, and we just need the marker file.


Incorrect error response for /users/register when tenantId doesn't exist

I'm submitting a ...

[X] bug report
[ ] new feature / enhancement request
[ ] improvement request (usability, performance, tech debt, etc.)
[ ] other

Traffic Control components affected ...

[ ] CDN in a Box
[ ] Documentation
[ ] Grove
[ ] Traffic Control Client
[ ] Traffic Monitor
[X] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] unknown

Current behavior:

When making a POST request to users/register with a tenantId value, that doesn't exist, in the body. The response returned is:
HTTP/1.1 400 Bad Request
{
    "alerts": [
        {
            "text": "not authorized on this tenant",
            "level": "error"
        }
    ]
}

Expected / new behavior:

Should Return:
HTTP/1.1 404 Not Found
{
    "alerts": [
        {
            "text": "No such tenant: 87129",
            "level": "error"
        }
    ]
}

Minimal reproduction of the problem with instructions:

Anything else:

I wrestled a lot with how to label this. Since there's no authoritative source on what behavior should be exhibited in a specific error scenario, and the message portrayed isn't strictly wrong - since it's true that nobody really has permissions to modify a tenant that doesn't exist - I settled on "improvement".


Server Error when trying to delete only feed

When only having one feed and trying to delete it, a Server Error is shown.

Solved in #19.


Documenting our Metadata Application Profiles (MAPS)

Documenting our Metadata Application Profiles (MAPS) Before MigrationAs the Samvera Community prepares for migration, can we get a handle on the metadata we have and what we share with the community? Let's sit down together to document what we're saying about our objects, how we're expressing it and learn from others' ideas. Bring your weird and wild worst practices, build together toward better practices.Session goals would be: to provide a place to sit down and do the work together, talk about similarities or differences, and provide some context for what we do or don't want our MAPS to look like as we migrate to a new system.
Suggested by: Ruth K Tillman & Julie Hardesty
Presenter: Ruth K Tillman & Julie HardestyMetadata community
Format: Breakout working session, maybe 2 hours?
Audience: Metadataists/members of the Samvera Metadata IG (not the official IG meeting though)

consider 30 min presentation to introduce and present examples


Upgrade to rustc 1.4.0-nightly (f3f23bf9c 2015-08-30)

r? @Manishearth

@bors-servo r+

:hourglass: Testing commit 54776a1 with merge 78c901d...

:pushpin: Commit 54776a1 has been approved by Manishearth

:sunny: Test successful - travis


storage: Fix mockChunkQuerier type name

Rename storage.mockChunkQurier to storage.mockChunkQuerier. Avoids some confusion when working on the code :)

Meant to open this PR against upstream :/ Sorry.


[TESTING] Bugfix deadlock

@xrdavies Can you try it ?
I have no deadlock before or after these changes, so only you have this issue, try and tell us.

@sgaragagghu
Please find a draft test tool for deadlock in utils.c. It's quite simple, but can be used to detect deadlock.
You can add sleep when the thread holds a lock in that code. Then it will be easy to simulate some unexpected case.
I will try to test this PR after work.

let me know if you still have deadlocks issues


Kotlin dist downloading failed

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Upgrade to Android Studio Flamingo | 2022.2.1 Patch 1.
Open a Flutter project.

Expected results
I expect the project to open with no exceptions.
Actual results
I get this exception, twice, in the notifications:

Failed to download Kotlin Compiler Maven artifact (org.jetbrains.kotlin:kotlin-dist-for-jps-meta:1.8.0-release). The search was performed in the following repos: https://repo1.maven.org/maven2 https://repository.jboss.org/nexus/content/repositories/public/ You can use Kotlin compiler which is bundled into your IDE. Select 'Bundled' version in 'File | Settings | Build, Execution, Deployment | Compiler | Kotlin Compiler | Kotlin Compiler version'

(By the way, there is no Kotlin Compiler submenu in File | Settings | Build, Execution, Deployment | Compiler…)
Code sample
My code is likely not involved, this happens at project opening, and with all my Flutter projects.
Screenshots or Video

Screenshot

Flutter Doctor output
Doctor output
[✓] Flutter (Channel beta, 3.10.0-1.5.pre, on Ubuntu 22.04.2 LTS 5.15.0-71-generic, locale it_IT.UTF-8)
    • Flutter version 3.10.0-1.5.pre on channel beta at /home/mauro/Codice/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b1c77b7ed3 (5 giorni fa), 2023-05-02 21:11:36 -0600
    • Engine revision 50e509c2bd
    • Dart version 3.0.0 (build 3.0.0-417.4.beta)
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /home/mauro/Android/Sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /opt/android-studio-2022.2.1/android-studio/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 14.0.0-1ubuntu1
    • cmake version 3.22.1
    • ninja version 1.10.1
    • pkg-config version 0.29.2

[✓] Android Studio (version 2022.2)
    • Android Studio at /opt/android-studio-2022.2.1/android-studio
    • Flutter plugin version 73.0.2
    • Dart plugin version 222.4560
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] Android Studio
    • Android Studio at /opt/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.77.3)
    • VS Code at /usr/share/code
    • Flutter extension version 3.62.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 22.04.2 LTS 5.15.0-71-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 112.0.5615.165

[✓] Network resources
    • All expected network resources are available.

• No issues found!

After upgrading to that Android Studio version, I also see the same notification, but the Flutter project still can run normally.
Also, this issue is only happening on some old Flutter projects (not all). When opening the newly created Flutter project (stable/beta/master), the issue doesn't happen.
When searching this, I see it's mentioned on Failed to download Maven artifact.
And then after comparing .idea/kotlinc.xml between affected old Flutter project and new one, there is no kotlinc.xml file on new Flutter project (I have no idea why it's there, maybe by adding some plugin?).

Affected project (has issue):

<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
  <component name="KotlinJpsPluginSettings">
    <option name="version" value="1.8.0-release" />
  </component>
</project>

New project (has no issue): no such file

Okay, now I copy kotlinc.xml file from affected project to new project, the issue appears!
Next, I also check intellij-community/blob/master/.idea/kotlinc.xml, I guess 1.8.0-release is not available. So after changing the version to 1.8.0, the issue doesn't happen anymore.
So I think it's an intellij issue rather than Flutter issue. I would suggest following up on above linked issue for further updates. Closing the issue from here. Meanwhile, you can try using 1.8.0 as workaround for this. Thanks!

Thanks, this post helped me a lot.  I had the same issue.

Yep, that works great.


xamarin lambda function issue

Am using AWS lambda function in Xamarin to get the places data but unable to get data in res
Please help me as am new to xamarin and AWS services
AmazonLambdaClient client = new AmazonLambdaClient("xxx", "yyy", RegionEndpoint.USEast1);
InvokeRequest ir = new InvokeRequest
{
    FunctionName = "fn_SS_GetPlaces",
    InvocationType = InvocationType.RequestResponse
};
InvokeResponse response = client.Invoke(ir);///////[invoke getting error as AmazonLambdaClient.Invoke(InvokeRequest) is inaccessible due to its protection level]

System.Threading.Tasks.Task<Amazon.Lambda.Model.InvokeResponse> res = client.InvokeAsync(ir);

Hi Shraddha,
Thanks for the posting the guidance question. Since you are using Xamarin, you would be targeting .NET Core framework. As per API documentation for AmazonLambdaClient.Invoke, there is a Note that "For .NET Core, PCL and Unity this operation is only available in asynchronous form.". So the only option is to use InvokeAsync.
Please let me know if this answers your question.
Thanks,
Ashish


gdi hook not working anymore on Win10 (Build 10565)

Hi,
the issue was on my end. Issue can be closed.
Regards,
Stefan

@StefanKoell anything worth sharing so others don't repeat?

Well, it wasn't related to EasyHook at all. The GDI hook actually didn't work anymore because the rendering changed from GDI to hardware accelerated rendering (OpenGL). So no issue with EasyHook ;)
I really appreciate your work and want to thank you for providing EasyHook. Also kudos for taking care of the community here!
cheers,
Stefan

Ah, thanks Stefan.


error with multiprocessing and Pytorch

Hi, if I try to run PPO - train.py - with n_env != 1, I get the following error
with the CPU:
"Trial 0 failed because of the following error: RuntimeError('Cowardly refusing to serialize non-leaf tensor which requires_grad, since autograd does not support crossing process boundaries.  If you just want to transfer the data, call detach() on the tensor before serializing (e.g., putting it on the queue).')"
with GPU:
trial 0 failed because of the following error: RuntimeError('cuda runtime error (801) : operation not supported at /pytorch/torch/csrc/generic/StorageSharing.cpp:245')
I'm switching between the two configuration with export CUDA_VISIBLE_DEVICES="0" before launching the train.py
In order to parallelize the environments, I added in the code in the init of ExperimentManager:
vec_env_type = "subproc"
System Info

Stable Baselines3 installed by pip
Nvidia 2070 in WSL (windows linux subsystem), but it seems that the problem is not related to the GPU
Python 3.8.2
PyTorch version 1.4.0

Hmm this is a new type of error. I would try running other codes that use PyTorch to ensure your installation is correct. It sounds like something is wrong on that level, possibly due to the WSL2 (but doubtful). Can you also try running things without WSL2 (on Windows)?

Yes, on my linux machine everything works fine. I will try to understand if it is a problem with wsl2 or not. Thank you!

after a new download of the stable baselines/rl baselines zoo everything works fine on WSL. I did not identified the problem, but it is solved.


expose to terraform apex_function_NAME_name (Closes #654)

add variable apex_function_NAME_name to the exported variable to terraform (Closes #654)

the phrase should be in the body to close the related issue I think https://github.com/blog/1506-closing-issues-via-pull-requests

thanks!


Made Composable compatible with fragment

Is your feature request related to a problem? Please describe.
We can't render the previews with the latest version (1.9.0 Compose compatible) in Fragments, only in Activities
Describe the solution you'd like
Be compatible with fragments
Describe alternatives you've considered
We tried several workarounds but no luck
Additional context
Attached problem log
preview_error.txt

Thank you for informing us about this issue.
We will have a look at this.

Hi @NachoAstro, which theme do you use for your app or activity which contains fragment?

MaterialTheme

@NachoAstro Can you reproduce same issue on our demo project?

Yes. in you demo project you only use Activity

@NachoAstro We added a demo with Fragment, check please here https://github.com/verygoodsecurity/vgs-collect-android/pull/634/files. Also, please make sure that the theme of your application or activity that holds fragment is Material in AndroidManifest.xml

Nice, let me know when you merge this code

@NachoAstro PR merged into develop.


apoc.meta.data() fails when there is a relationship-type RELATIONSHIP breaks GenAI integrations

When you have a graph with a RELATIONSHIP the current apoc.meta.data() implementation breaks with this exception.
Failed to invoke procedure apoc.meta.data: Caused by: java.lang.IllegalArgumentException: duplicate element: RELATIONSHIP
As we use this in the schema generation for our genai-integrations, this breaks them and the applications using them.

same issue I have faced today while calling apoc.meta.data()

this was marked completed and closed, but its not clear why? where is the fix? I'm having this same issue.

is there an earlier release that doesn't have this bug?

The linked PR request fixes it, but the fix itself will be released in 5.18 :)

The linked PR request fixes it, but the fix itself will be released in 5.18 :)

What is the release cadence for neo4j?


Bottom Buttons breaking for Tutorials with Hashlinks

e.g. /v3/kitties/pt1 should point to part2 at the end.  not the next hashlink.

@sacha-l
Just a reminder to let me know how you'd like this to behave.
You can always use the frontmatter flag to remove the buttons from the pages we don't necessarily need them.
but in case of Kitties, if we want the next section to be linked, i'll need to quickly revisit the script.

@jimmychu0807 While addressing this I came across a weird problem with Kitties tutorials.
When I get to the bottom of the tutorial, the button also read Introduction.  Which is the title for the next document in progression of Kitties Tutorial.
I would suggest changing the name in DevNavMenu for both Part 1 and Part 2 to perhaps 'Part I - Introduction' & 'Part II - Introduction' ?

I've addressed this on your #191 branch, just changed the names.

@imadarai I was the one having the PR of changing the devMenu link from just the hash to having the whole page link + hash.
It is because refer to the following scenario. I was at Kitty Tutorial Part I. If I open the Kitty tutorial part II, all the links in Part II section will still point to Part I page + hash. So I figure we need the actual page link, not just the hash.

@jimmychu0807
I see what you mean.
I'll review it  today and add a patch or update the links accordingly.
This does beg a question.  With all the tutorials being a one-page (except kitties), should we perhaps rethink the Tutorial template all together and come up with a better navigation than typicall doc nav?  This is something I can bring up with Marcin and Patrick, but wanted to check with you guys first.  Happy to leave it as is for now, but it might be worth looking into it further down the line.

I've reverted back to previous code and addressed the intended behavior.
I believe, we'll have a very clear idea of how we'd like to move forward with the next iteration when it comes to navs, or even Tutorial Template as a whole.  This can also use optimization based on #205 during next feature launch.


Fix healthchecker

Add service error status in openlabcmd
Remove built-in libiary logging
Refacor to fit new zk API.
Fix some issues in healthchecker scripts.

Tested locally, works well. Thanks.


GTK3 Widgets Need Consistent Look and Feel

Expected Behavior
As a user, I want the GUI widgets to have the same look and feel so that I am not distracted by the GUI and can focus on my work.
As a RAMSTK developer, I want GUI widgets to have a boilerplate so that I don't have to rewrite or copy/paste the same code to obtain the same look and feel for the widgets.
Actual Behavior (NOT required for Enhancement type issues.)
Steps to Reproduce the Problem (NOT required for Enhancement type issues.)
Operating Environment (NOT required for QA type issues.)

RAMSTK Version: All
Operating System: ALl
OS Distribution (if Linux):
OS Version: All
Hardware: All
Python == All

REQUIREMENT: RAMSTK shall provide a graphical user interface (GUI) utilizing one or more GUI toolkits.
REQUIREMENT: The GUI toolkit shall be cross-platform with support on Linux, OSX, and Windows at minimum.
REQUIREMENT: RAMSTK GUI widgets shall maintain a consistent look and feel.
CODINGSTD: Subclass GUI widgets and provide a method to set widget properties with appropriate default values.  This ensures a consistent look and feel to the widgets.

Fixed in commit e0e46bea8c9950503b3c4acbf8636fa2046a64c7


Update screenshots.

I think a previous PR left some screenshots out of date.

These still pass for me locally. I think because of that JavaScript that used to run to attempt to auto-size the result. I think screenshots in general will break when we update to the latest SnapshotTesting since we removed that stuff.


Slab Frame crash when using a block in it

Crash report: https://pastebin.com/i4fYGCgV
Forge version: 36.2.0
Minecraft version: 1.16.5
Mod version: 0.3.8
Thank you!

Thanks for reporting. Seems like I didn't test the "double slab" feature enough...
Regards, Manu

Should be fixed with 0.3.9...

This is not fixed in 0.3.11.
Since it doesn't seem the repo is up to date, I looked at the decompiled jar of 0.3.11 and I still see the checkVisibility method that references a method func_200122_a that is marked as client side only using @OnlyIn(Dist.CLIENT) for both SixWaySlabFrameBlock and FrameBlock.

[22Aug2021 13:18:21.665] [Server thread/ERROR] [net.minecraft.server.MinecraftServer/]: Encountered an unexpected exception
java.lang.NoSuchMethodError: 'boolean mod.pianomanu.blockcarpentry.block.SixWaySlabFrameBlock.func_200122_a(net.minecraft.block.BlockState, net.minecraft.block.BlockState, net.minecraft.util.Direction)'
	at mod.pianomanu.blockcarpentry.block.SixWaySlabFrameBlock.checkForVisibility(SixWaySlabFrameBlock.java:298) ~[blockcarpentry:1.16-0.3.11]
	at mod.pianomanu.blockcarpentry.block.SixWaySlabFrameBlock.func_225533_a_(SixWaySlabFrameBlock.java:180) ~[blockcarpentry:1.16-0.3.11]
	at net.minecraft.block.AbstractBlock$AbstractBlockState.func_227031_a_(AbstractBlock.java:640) ~[?:?]
	at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:338) ~[?:?]
	at net.minecraft.network.play.ServerPlayNetHandler.func_184337_a(ServerPlayNetHandler.java:958) ~[?:?]
	at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:36) ~[?:?]
	at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:10) ~[?:?]
	at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?]
	at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?]
	at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:734) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:159) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:717) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:711) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:696) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:646) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:232) ~[?:?]
	at java.lang.Thread.run(Thread.java:829) [?:?]

```[22Aug2021 13:18:21.665] [Server thread/ERROR] [net.minecraft.server.MinecraftServer/]: Encountered an unexpected exception
java.lang.NoSuchMethodError: 'boolean mod.pianomanu.blockcarpentry.block.SixWaySlabFrameBlock.func_200122_a(net.minecraft.block.BlockState, net.minecraft.block.BlockState, net.minecraft.util.Direction)'
	at mod.pianomanu.blockcarpentry.block.SixWaySlabFrameBlock.checkForVisibility(SixWaySlabFrameBlock.java:298) ~[blockcarpentry:1.16-0.3.11]
	at mod.pianomanu.blockcarpentry.block.SixWaySlabFrameBlock.func_225533_a_(SixWaySlabFrameBlock.java:180) ~[blockcarpentry:1.16-0.3.11]
	at net.minecraft.block.AbstractBlock$AbstractBlockState.func_227031_a_(AbstractBlock.java:640) ~[?:?]
	at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:338) ~[?:?]
	at net.minecraft.network.play.ServerPlayNetHandler.func_184337_a(ServerPlayNetHandler.java:958) ~[?:?]
	at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:36) ~[?:?]
	at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:10) ~[?:?]
	at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?]
	at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?]
	at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:734) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:159) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:717) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:711) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:696) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:646) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:232) ~[?:?]
	at java.lang.Thread.run(Thread.java:829) [?:?]

 I was in a hurry when I first tried to fix this issue and somehow got the client and dedicated server confused, and I didn't test it afterwards (because I thought I fixed it properly). So I ended up rendering the slab only on the server side... Welp...
Now I tested it completely on my test server and it works. It'll be fixed in the next update. Thanks for reporting!
Regards, Manu


Workaround Qt bug on Windows with fullscreen mode in some screen resolutions/scaling configurations

Description

Fixes #3441
Preview
Before
https://user-images.githubusercontent.com/16781833/207097529-5aa1495a-284f-48c7-8870-563f110bf147.mp4
After
https://user-images.githubusercontent.com/16781833/207092320-8c3c46c9-f5bd-425a-b0d8-2996f3003739.mp4
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

References

How has this been tested?

[x] all tests pass with my change
[x] I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas

Thanks @dalthviz! Anyone with access to a windows machine who could double check? @andy-sweet

Thanks @dalthviz! Anyone with access to a windows machine who could double check? @andy-sweet

Happy to! I just tried reproducing the original bug on main, but could not (Windows 10, Qt 5.15.2, PyQt 5.15.4). Is there some precondition I missed (e.g. Window size in settings/preferences)?

Checked locally with the latest main ( b5696770d31cbaa6dc02068b8b8b0a95bdd8a107) and resetted Napari preferences just in case (using napari --reset) and I'm able to still reproduce the issue but checking more in detail I'm able to reproduce this only for one of my screens (the one with resolution 1366x768, scale 1.0). My setup info:
napari: 0.4.17rc4.dev123+gb5696770
Platform: Windows-10-10.0.19045-SP0
Python: 3.10.6 | packaged by conda-forge | (main, Aug 22 2022, 20:29:51) [MSC v.1929 64 bit (AMD64)]
Qt: 5.15.2
PyQt5: 5.15.7
NumPy: 1.23.4
SciPy: 1.9.3
Dask: 2022.10.2
VisPy: 0.12.1
magicgui: 0.6.0
superqt: 0.3.8
in-n-out: 0.1.5
app-model: 0.1.0
npe2: 0.6.1

OpenGL:
- GL version: 4.5.0 - Build <IP_ADDRESS>44
- MAX_TEXTURE_SIZE: 16384

Screens:
- screen 1: resolution 1366x768, scale 1.0
- screen 2: resolution 1920x1080, scale 1.0

Settings path:
- C:\Users\dalth\AppData\Local\napari\napari-dev_4454fdbf170edefe23827a4bf512389a6806af69\settings.yaml

Do you have a 1080p screen or one with higher resolution perhaps @andy-sweet ? For the moment I will investigate if something else could be done to enable the fullscreen on low resolution screens (since it seems like it works without changing anything for screens with at least 1080p resolution).

Thanks for the extra info @dalthviz ! I was testing at a higher resolution than 1080p, so I'll retry it again after setting it be lower.

Actually, I can only reproduce the original error at high resolution (2880x1800) (with 2x magnification) whereas 1920x1200 (with 1.25 magnification) works fine. I can confirm that this branch fixes the issues at high resolution though!

I'll merge this after 24 hours unless anyone objects.

This is still a problem in the wild -- see image.sc post above -- so I'm going to mark this Bugfix and switch o 0.4.19 milestone.


Search using regex only searches open documents

VSCode Version: Version 1.17.0-insider (Commit 67a8479bdcb95b3e21959342663b828d97f2098f)
OS Version: Linux 4.12.13-1-ARCH #1 SMP PREEMPT Fri Sep 15 06:36:43 UTC 2017 x86_64 GNU/Linux

Steps to Reproduce:

Open a folder and ensure all editors are closed.
Open search, enable regex search and search for "\n" - You should get 0 results.
Open a few files in editors and search again, populated results will consist of only the open documents.

Note: sometimes it populates with just a single file, cannot consistently reproduce this.
Reproduces without extensions: Yes

This is expected - search doesn't normally support multiline search. But if the file is open, then search is done by the editor, which does support multiline search.

Good to know, I thought this was expected behavior but was confused when it did provide a result for the  tsconfig.json file in the directory and thought something might have changed/was broken.

Is this intended functionality? or is the single result due to tsconfig.json being open in a hidden editor?

That's interesting, I actually don't know why it would do that. It may be a bug in the search tool we use, but not a critical one.

Yeah, definitely not a critical bug, that being said managed to reproduce consistently on MacOS.

Open a folder that has both a .ts file and a tsconfig.json file
Open the .ts file
Close .ts file
Search for "\n" with regex.

Ah, I can reproduce it now too. Apparently the tsconfig is open in the background, didn't realize it did that.


Add issue templates

Added new issue templates, one for Bug report and another for a Feature request.

Hey @loqusion, here are the templates! Please review and see if everything seems right.

Hey @loqusion, The Templates!

Oops, didn't know you had to click a button to finish a review

Oh! No worries.


Pass superkey to virtual machine on Hyprland/Wayland

Hyprland Version
v0.28.0-75-g63b2189c
Bug or Regression?
Bug
Description
On Hyprland, I'm running virtual machines on KVM/QEMU and virt-manager with different window managers to test my dotfiles. The issue is that the SUPER-Key is not passing through to the VM. So if I want to open a terminal in the VM with SUPER+RETURN it's not opening in the VM but on the host where I have defined the same keybinding.
It's working on Xorg but not on Wayland.
Do you have a workaround or Hyprland configuration that I have missed in my research to make this running?
How to reproduce
So if I want to open a terminal in the VM with SUPER+RETURN it's not opening in the VM but on the host where I have defined the same keybinding.
Crash reports, logs, images, videos
No response

Great. Thank you. Will test it.


keycloak-gatekeeper - /oauth/logout - back channel logout does not work if refresh tokens are disabled

What:
keycloak-gatekeeper provides a logout endpoint that should send an onward response to the Keycloak end_session endpoint with either a refresh token or id token.  When refresh tokens are not enabled, Keycloak responds with a 400 error because the request to the end_session endpoint holds an ID token but uses the URL query parameter refresh_token instead of id_token_hint.
Please see https://github.com/keycloak/keycloak-gatekeeper/pull/437
Reference:

KEYCLOAK-8990 - keycloak-gatekeeper - /oauth/logout - back channel logout does not work if refresh tokens are disabled

How can we propagate logout to all the clients when one of the client(application) performs a logout by hitting application/oauth/logout?
Right now the other application which has also logged in as SSO in the same browser previously is not logged out and token still persist(checked via application2/oauth/token), both clients(applications) are from the same realm. Is this expected behavior?
Also, when I try to logout the sessions from Keycloak and requests are sent to proxy but even those requests are not authenticated and fail, so how can we whitelist the keycloak server.

@shubhamc183 I believe you already asked on the mailing list correct? If yes, you will get your answer as soon as we have the chance to reply, but please, do not use GH issue for asking questions.

Ok, got it. Thanks. Since I didn't get any acknowledge there so I asked here.


ShipReady report showing incorrect areas

The ShipReady report is showing some JS pipelines in their own area due to the way that JS live test pipelines are configured. This just needs to be cleaned up in the report to accommodate that data shape (will be a whack-a-mole exercise).

This has been addressed and published.


Backport: Guard execution of on-chain firewall calls with a mutex

Backport of https://github.com/keep-network/keep-ecdsa/pull/740
This change is effectively reducing firewall on-chain concurrency to one
call but this is exactly what we need. The loop going through keeps is
always executing checks in a sequence. When two on-chain calls were
executed at the same time, they were always a duplicate of the same
call. Mutex should not slow anything down and should in fact speed up
the loop. Instead of executing the same check from 8 concurrent threads
and being rate-limited, we will execute 8 different checks in more or
less the same time.

@pdyraga aren't we missing debug loggers from the commit https://github.com/keep-network/keep-ecdsa/pull/740/commits/2e8910d41e0465fd49a71c9b125b97b247be506f?

@pdyraga aren't we missing debug loggers from the commit 2e8910d?

Please see https://github.com/keep-network/keep-ecdsa/pull/739/commits/9236894e3d47b215b2271c5c37a24c2eeb69f2d3 from https://github.com/keep-network/keep-ecdsa/pull/739.
They are here:
https://github.com/keep-network/keep-ecdsa/blob/24555b81812cc3638157207bc0c8c59a923e0ce6/pkg/firewall/firewall.go#L78
https://github.com/keep-network/keep-ecdsa/blob/24555b81812cc3638157207bc0c8c59a923e0ce6/pkg/firewall/firewall.go#L105-L108
https://github.com/keep-network/keep-ecdsa/blob/24555b81812cc3638157207bc0c8c59a923e0ce6/pkg/firewall/firewall.go#L150-L153
https://github.com/keep-network/keep-ecdsa/blob/24555b81812cc3638157207bc0c8c59a923e0ce6/pkg/firewall/firewall.go#L314-L317
https://github.com/keep-network/keep-ecdsa/blob/24555b81812cc3638157207bc0c8c59a923e0ce6/pkg/firewall/firewall.go#L355-L358


Added Date-class

This fixes #109
It's also a minimalistic implementation, so no big helper methods.
Quickly created this, if you find any mistakes, just shout it out.

I would rather make this a value class ...

If you're going to include dates and times, Surely it makes more sense to call the class DateTime

Done @crosire
Renamed it to GTADateTime so there are no conflicts with the normal DateTime (Which is also used a lot in scripts)

Wouldn't it be better to just qualify it like GTA.DateTime?

@SeijiSuenaga
IMO we should not interfere with the names of the .NET standard names. But thats just my favorite naming-style.

@JohnnyCrazy About not interfering with .NET standard names, The GTA::Menu class interferes with the System::Windows::Forms::Menu class, but that has gone un-noticed

Yes, I would prefer GTA.DateTime too. Namespaces are there for a reason =).

Done, sorry for the late push @crosire

Can't merge that yet though, since it will break existing scripts using the World::CurrentDate property. So this has to be merged close to 2.0.

How about a 2.0 branch?

How about to add some checks to properties of year (2010-2013) and month (0-11)?

IMO we should only provide proper getters and setters. We also don't check the inputs in other native functions, so why should we start here?

To avoid a bunch of questions like "i'm trying to set date in 30.12.2200 and nothing happens".
Or, at least, add information (in xml comments/wiki) about correct values.

Merged in c58176d056e6541f65c244cd609ed8e484189cb9

@crosire Anything missing since it's in a feature branch?

While the dev branch is for development, it could very well be that we want to release some 1.1 before 2.0, which wouldn't be possible when I merge this now.


[KommunetvIE] Add extractor for kommunetv.no

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
Adds support for kommunetv.no
Fixes:
https://github.com/ytdl-org/youtube-dl/issues/30801

This extractor only downloads the first camera. I don't know a proper way to handle multiple cams.

sorry, wrong commit msg, should be:
[KommunetvIE] revert base_url to regex

sorry, wrong commit msg, should be: [KommunetvIE] revert base_url to regex

We'll squash the commits in the merge anyway, but feel free to rebase and push again.


Feature - Autoprefixer Support

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
feature

What is the current behavior?
Both global and component stylesheets do not have vendor prefixes to CSS

What is the expected behavior?
Both global and component stylesheets should have vendor prefixes to CSS

What is the motivation / use case for changing the behavior?
It can often become a bit tedious to include all the vendor prefixes for the CSS you use. Use an auto-prefixer to automatically add the prefixes you need to include.

Other information
autoprefixer is a PostCSS plugin to parse CSS and add vendor prefixes to CSS rules using values from Can I Use. It is recommended by Google and used in Twitter and Taobao.

Refer #1345 for discussion on this.


Support local spans in BraveExecutorService, BraveCallable BraveRunnable

This adds new wrap() factory methods to BraveExecutorService,
BraveCallable and BraveRunnable. Notably these support attaching
local spans, needed for any async client span that isn't a direct child
of a server span. This also manages the stack properly so that you can
create a new span inside a callable or runnable without tainting the
prior state.
Fixes #289

cc @schlosna @cschneider


How to read JSON files with FileBasedExampleGen

Please add code for reading json files.

Hi @albertnanda,
You can reuse the same code as stated in the example and customize the following lines:
            for image_filename in images:
                image_path = os.path.join(input_base_uri, image_filename)
                example = get_image_data(image_path)
                writer.write(example.SerializeToString())

with your custom code. For example, if you load one file and you would want to convert to TFRecords, the code could look like this (code is not tested):
import json

with open('data.json') as f:
     data = json.load(f)

for record in data:
     example = your_function_to_map_json_data_to_example(record)
     writer.write(example.SerializeToString())


CSV target doesn't escape double quotes

in Episode 320, I played Nuthin' but a "G" Thang and the CSV output did not escape the quotes, causing Chapters to fail.

No idea why I didn't originally use python's built in CSV module.  As of aa4f952 I've switched to it, and now I don't need to worry about escaping.  This is almost certainly fixing several other issues I was unaware of. :)


provide tool to apply default functions settings (i.e. locomotives, wagon)

Extra tool to connect to the proxy to send commands to apply the initial function states for locomotives (light, ABV, sound) and wagons (e.g. lights).

removed -- will not be implemented, it is already provided by Rocrail


Local notification

Add local notifications as reminders to use the app.
https://link.medium.com/R9zujIHyjX

Use for sending vibrations to each other.
Activating vibration on another's phone.


The "+" button on Your Gists suggests the name [object Object]

Describe the bug
The "+" button on Your Gists suggests the name [object Object].
To Reproduce
In the GistPad sidebar, under Gists, find Your Gists and click the "+" at the right side of the row.
Expected behavior
No text initially, or if there is an initial suggestion, having it disappear on the first keypress.
Screenshots

Desktop (please complete the following information):

VS Code Version: 1.91.1
GistPad Version: 0.6.0

Hmm, I think this might be related to trying to populate this field with the contents of your clipboard. Let me take a look!


Unlocker not working.

when i open the unlocker it says:
Searching for pattern...
outdated pattern

if you have even taken a look at closed issues or release section


rosserial_leonardo_cmake: 0.1.4-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository rosserial_leonardo_cmake to 0.1.4-1:

upstream repository: https://github.com/clearpathrobotics/rosserial_leonardo_cmake.git
release repository: https://github.com/clearpath-gbp/rosserial_leonardo_cmake-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.1
previous version for package: null

rosserial_leonardo_cmake
* Updated arduino link from google code
* Contributors: Dave Niewinski

Noted.  I've added the file, but I'm not sure it's worth re-blooming for that single change; the existing Kinetic release is also missing that file.

Releasing tags that have a LICENSE file would be best :)

Given that this is the exact same tag that was previously released for Kinetic, and the Kinetic version is also lacking that file, is the lack of the license file actively going to cause problems for this PR?

@civerachb-cpr friendly ping, could you address the previous review feedback? thanks!

Sorry, I've been busy with other tasks.  I've talked to the maintainer of the package in questions and let them know about your request.

I think things should be ok now; the license data has been updated & included in the 0.5.1 release.  I've bumped the version in this PR accordingly.

Holding for Melodic sync.

I'm sorry to make a mistake in the link.


Time

Figure S15 shows the abundance of each state across time for all conditions.

Is this good to go for supplements?

Neat! Yes, let's put this in the supplement.
Why is it flat in the beginning and drops off at the end? Are you counting censored cells (you should be, if not)?

Ah.. you are right, I will edit it and update you. Thanks.


Small spelling error.

Changed word "moongose" to "mongoose".

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Closes #XXXXX

Congrats @adam-weiler on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


fix(quic): use Provider::send_to for UDP datagram

Description

Links to any relevant issues
Addresses https://github.com/libp2p/rust-libp2p/pull/3454#discussion_r1236859831.

Open Questions

Change checklist

[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] A changelog entry has been made in the appropriate crates

Appreciate the reviews @kpp and @thomaseizinger.
Latest commit applies the above suggestions and hides the Tokio and async-std types.
Mind taking another look?


Documenting Spans and Transactions

Added some docstrings and also did some minor cleanup for better readability of the code.

Thanks for the fixes! Yes, at some point our lib will be a really well documented thing!


Add PayVector integration

Adding PayVector (formerly Iridium Corporation) Integration

Completed the suggested changes, let me know if there's anything else that isn't idiomatic

I'll close this since it has been more than a year without activity


'Parser' only refers to a type, but is being used as a namespace here.

Describe the bug
I tried to run the repository code using yarn start and I receive the error TS2702
To Reproduce

I'd cloned the repository and enter on cloned folder
I had run yarn to install dependencies
I put yarn start to build and run tsc

Expected behavior
I just expect to run without errors
Screenshots/Additional information

I'm unable to recreate this issue, with both yarn and npm are you able to provide more details on the system/environment you're on.


929 message on empty page if there is no datasets

This is a draft pull request. I don't think it looks very good visually, but it adds a message and a button to register or login on the public page if there are no public datasets.

I think the login and register button are not needed. We laready have them on top right of the page. Just a message for now is good, I think.

I think the login and register button are not needed. We already have them on top right of the page. Just a message for now is good, I think.

I removed them.
It might be a good idea to maybe have a place where, for each instance, an admin can set a default message. But that would probably be another issue. There was something like this in clowder v1 I recall.

I think this is good for now. We may want to go for a landing page in future. That can be a separate issue.

For some reason i got 404 error access public_dataset endpoint

Please make it against beta.2


Review of simpoints work

There's a couple small comments from Bobby. Otherwise, we just need to partition this into the commits you suggested, Zhantong, and then submit to gerrit!


refactoring .py file is adding new lines everywhere!

Does this issue occur when all extensions are disabled?: Yes, i have confirmed

VS Code Version: 1.81.1
OS Version: win10

DEMO:

Steps to Reproduce:

ooopen python filem select any variable
press f2
preview changes shift+enter

Hints:

i think there must be some regex issue
there could be issue with CRLF or LF \r \n , maybe.....

Please help, as refactoring can be done by bulk replace, but i believe thats not ideal solution

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

/extPython

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


cmd/search/grep: Change '--color never' -> '--color=never'

My RHEL 7.5 CSB has:
$ grep --version | head -n1
grep (GNU grep) 2.20

which treats --color never as "regexp never and also the --color option", not "the --color option with the value never".  For example:
$ echo 'well I never' >test
$ grep --color never well test
grep: well: No such file or directory
test:well I never
$ grep --color=never well test
well I never

Even the current 3.3 docs talk about --color=WHEN, so going with the single-argv form should be forward compatible (at least across a broad range of GNU releases; these options aren't in POSIX).

/lgtm


Search Configuration Apply Error

When I am trying to apply search configuration I am getting an error. When I am using the same template with the powershell it is working fine.

ServerException was caught
The server was unable to process the request due to an internal error.
For more information about the error, either turn on IncludeExceptionDetailInFaults
(either from ServiceBehaviorAttribute or from the  configuration behavior)
on the server in order to send the exception information back to the client, or turn on
tracing as per the Microsoft .NET Framework SDK documentation and inspect the server
trace logs.

Hi, can you share something more? Are working with a root site collection template or with a sub-site template? What kind of site template is at the basis of your target site? Thanks.

It is an Root Level Template with the Schema http://schemas.dev.office.com/PnP/2015/12/ProvisioningSchema and the Template is the STS#0 (Default of this Schema). I have the Standard pnp:SearchSettings and only under ResultTypes I have a Definition.

Can you try the provisioning of your template using the provisioning engine within Visual Studio (using the CSOM package of SharePointPnP) just to be able to debug and see the issue? Moreover, in the upcoming August release of PnP there will be some changes in the search settings handler, together with support for the new 201605 schema. I would suggest to wait for the new release. From a PnP Partner Pack perspective, the new engine and schema will follow shortly (most likely in early September).

@twimon FYI to apply the search schema you need to have a user context. App only context will not work.

Hi,
Thanks for sharing I realized the issue and I updated the PnP Partern Pack v2 (which will be released pretty soon) accordingly. I will close this one.


fix: allow for a year lock when its Thursday

Description
It should be possible to lock for 365 when its a Thursday. This PR checks this condition and will allow to have a year lock.
Also - I've changed the date to UTC.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other

How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.

[ ] Might be useful to wait for a Thursday to try this out (not really easily tested - I put on "hold" for now)

Visual context
Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have requested at least 2 reviews (If the PR is significant enough, use best judgement here)
[ ] I have commented my code where relevant, particularly in hard-to-understand areas
[ ] If package-lock.json has changes, it was intentional.
[ ] The base of this PR is master if hotfix, develop if not

It should be possible to lock for 365 when its a Thursday. This PR checks this condition and will allow to have a year lock.

Minor correction: it should be possible to lock for 365 days when it's a Wednesday - so we should be able to test this today. I tried to increase a lock but the UI won't let me select Apr 13 2023

Impersonating 0x41414141.eth today, Apr 20 2022
Production:

b7c0bb8

Simulated transaction on Tenderly seems to indicate correctness:

0x64408080 =<PHONE_NUMBER> = Apr 20 2023

Tested this today (Thursday) and it allows me to select Thursday April 20th 2023 as the end date.

To clarify, the app's current version will also let you do this. To test this PR you must change your system date to Apr 20 2022 and then check that you can lock until Apr 20 2023.

@evgenyboxer What's the latest with this PR? Can it be merged?

Yep! just need another approval here.

Today is a good day to test this - PR preview should allow you to lock until Apr 27, while production app only lets you lock until Apr 20.


Feature/eproms patient home page new ui changes

address stories:
https://www.pivotaltracker.com/story/show/144303371
https://www.pivotaltracker.com/story/show/144304907

change text/styling in eproms patient's home page
NOTE, this does contain a temporary questionnaire due date function that needs to be replaced later on (i.e. as an available property from the assessment_status object).  It is there for this upcoming demo.

closing this for now, working on incorporating Paul's changes


How to short the file path before the command ?The command line prefix or the file path is too long.

As you can see, the file path before my command is too long. So I can't put any of my commands on a line in my little window. Can someone help me solve this problem?

Imho, the best way is write your own prompt function in $profile. Something like:
function prompt
{
   "$([char]27)[38;5;31m$($PWD.Path)`n$([char]27)[0m PS $([char]27)[38;5;41m> $([char]27)[0m"
}

This is a very simple example


Model Builder Error - A delimiter cannot be Nothing or an empty String

When trying to add data as part of the model builder, selecting SQL as my source - as soon as I select the table name I receive the error A delimiter cannot be Nothing or an empty String.
I'm using Visual Studio 2019 and I installed ML.net via the vsix installer on the website. I've also added Microsoft.ML from Nuget as previously I had problems when working through the samples and this was the fix.

In addition to my issue, when I actually click the drop down on the table name, all my tables are listed as a single item.

I believe this issue is related to the content of the SQL table text containing new lines, I will do further testing to confirm

Thanks for the reporting
@beccamc  Can you take a look at this?

@beccamc I can confirm this problem is due to new lines being within the content. I've just created a new table with the same structure and put in some basic data which worked without issue. I added a 2nd row of data but with a new line and this generates the same error.

@pete-oconnell Thanks for the detailed repo! I will try on my end. We just released a new version of Model Builder yesterday that includes some changes in SQL processing. It may fix the problem, I will try to reproduce on the new code.

@pete-oconnell Thanks for the detailed repo! I will try on my end. We just released a new version of Model Builder yesterday that includes some changes in SQL processing. It may fix the problem, I will try to reproduce on the new code.

just tested the latest build and it appears to be fixed! :)

Awesome! So happy to hear that. Let me know if you run into any other problems.


Origin of textures are tied to the window origin and not the level origin

This causes the walls to appear to move, while the floor stays in place.

Issue can be resolved via texturing the walls, so it reduces the apparent illusion


fix(app-router): await navigation result

Navigation command (eg. redirect) in child route navigation strategy was not working, when parent route was also using a navigation strategy
Fixes https://github.com/aurelia/router/issues/588

Sending the PR to history-browser shortly

Corresponding PR: https://github.com/aurelia/history-browser/pull/38

Thanks 😄 What are the plans regarding the release? I didn't find any roadmap

Any comments regarding the release? I'd like to use this fix, is it worth waiting or should I use my own version? The last release, 1.5.0 was made in January.

@balazsmeszegeto Thanks for being patient. I'm way behind here. I'll set aside some time on the weekend to begin preparing a release. I expect it'll take at least two weekends. Sounds fair?

Sure and thanks for the update!

Any progress on the release? Do you need my help maybe?

@davismj Can I help with the release? I'd really need this fix 😄

@balazsmeszegeto sorry for the lack of communication, last I heard @EisenbergEffect was releasing it last weekend or this weekend or soon. Did I get that right?

We've got a lot of releases to push out. We started pushing some out last week. The rest should go out this week.

Thanks for the update!


Merge remote-tracking branch 'upstream/stable' into merge_stable

Can we do sth. about stable->master merges not getting pulled?

I never paid them any attention to these because I thought you just pulled them after there were no conflicts.

I never paid them any attention to these because I thought you just pulled them after there were no conflicts.

I usually do after some time because noone else does ;). Let's say I'd prefer reviews for merges with conflicts (as indicated by the conflicts sections in the PR description, e.g. https://github.com/dlang/phobos/pull/5320).


Make Connection impl for PooledConnection more generic

Instead of hardcoding the ConnectionManager type, allow it to be anything which implements ManageConnection. This allows other crates to accept a generic ManageConnection as well.
For example, I want to create a TestConnectionManager, use it with r2d2::Pool, and pass the resulting PooledConnection to a function which accepts impl Connection<Backend=Pg>. With this change that's possible.
use std::env;
use diesel::{
    Connection, PgConnection, pg::Pg,
    r2d2::{self, ManageConnection, ConnectionManager}
};

fn main() {
    let database_uri = env::var("DATABASE_URL").expect("DATABASE_URL must be set");
    let pool = r2d2::Pool::builder()
            .max_size(10)
            .build(TestConnectionManager::new(database_uri)).unwrap();

    task(pool.get().unwrap());
}

fn task(conn: impl Connection<Backend=Pg>) { }

#[derive(Debug, Clone)]
pub struct TestConnectionManager<T>(ConnectionManager<T>);

impl TestConnectionManager<PgConnection> {
    fn new(database_uri: String) -> Self {
        Self(ConnectionManager::new(database_uri))
    }
}

impl<T> ManageConnection for TestConnectionManager<T>
where T: Connection + Send + 'static {
    type Connection = T;
    type Error = r2d2::Error;

    fn connect(&self) -> Result<T, r2d2::Error> {
        let conn = self.0.connect()?;
        conn.begin_test_transaction().map_err(r2d2::Error::QueryError)?;
        Ok(conn)
    }

    fn is_valid(&self, conn: &mut T) -> Result<(), r2d2::Error> {
        self.0.is_valid(conn)
    }

    fn has_broken(&self, conn: &mut T) -> bool {
        self.0.has_broken(conn)
    }
}

We general do not accept PR's targeting the 1.4.x branch which adds new features. Only critical bug fixes and semver compatible dependency bumps are accepted. That written I think we would accept this as PR to the master branch.

@pksunkara I don't think this would be a breaking change as the existing implementation is also covered by the generic bounds + this does not change something on the function signature. That written: At least I don't want to add new features or anything to the 1.4.x series anymore. I do not plan to do another release there. Hopefully we are able to release 2.0 instead "soon".

Looks like this change was already made on master a while ago - 4e0b403, I didn't realize how long the feature freeze on 1.4.x was. Since you're not interested in backporting the change, I'll close the PR


Handle non-utc DTSTART/DTEND entries

E.g. DTSTART;TZID=Europe/Vienna:20180711T130000, which is allowed by the standard.
If you accept help with my issues, let me know!

Hello, I'm sorry for my late answer. Of course i would like yours help please write me.Thanks


Report resource constraints when scheduling fails

We previously implemented a change to include resource constains in the
error message presented to users when the external scheduler could not
find any matching hosts. However, we missed a case where the external
scheduler found an inactive host that was later filtered out by cattle
due to the fact that it was inactive.
This fix addresses that change by moving the logic for including the
resource constraint up a level and always including the constaints if
they are present.
adresses https://github.com/rancher/rancher/issues/9554

LGTM, thanks for the fix!