Components required as part offront end for smart contract includes b…

Description
No changes made to the existing directories of the main project.
All files modified or added are within the NFT-Minting folder.
I will be updating it more tomorrow
All these files are related to the front-end part.
Trello
[

Link: (https://trello.com/c/axeoGvZL)

Extra Info
The files updated in the NFT minting folder are not entirely completed, I am still working on them. feel free to review and provide feedback.
I have commited them for backup purpose.

Please restore all changes from package.json and package-lock.json file.

I've manually fixed all conflicts and moved package to the sub directory. This PR can be merged now, despite it doesn't add value to the final product!


warning if model accidentally contains some empty params and it calls to_gpu

I want chainer to warn when it calls to_gpu for a empty ndarray in debug mode.
Suppose some neural network model.
If model accidentally contains some empty params and I try to train model with Adam or AdaDelta,
it raise the error Exception in main training loop: object __array__ method not producing an array.
This error is raised because whole model except for empty params is sent to GPU but empty params is not.
([cuda.get_device_from_array(param.data)] returns -1 for param.data which is empty,
then optimizer calls update_core_cpu in CPU mode. In this way, numpy and cupy are mixed)
(in update_core)
Here is the example to get cupy ndarray where int(cuda.get_device_from_array) returns -1.
import chainer
import numpy

x = chainer.cuda.to_gpu(numpy.empty(0, dtype='f'))
print(int(chainer.cuda.get_device_from_array(x)))
print(chainer.cuda.get_device_from_array(x))
print(x)

I think it is natural to return -1 for empty params because there is no allocation in GPU memory.
But I want to tell me if chainer.cuda.to_gpu is called for empty params.
I want to know what dev-teams think about it...:bow:

According to @okuta, cupy/cupy#946 would fix this issue.

Awesome!! Thanks very much for telling me :pray:
I close this issue..:bow:


Add missing test cases for the Join class

Hello,
This PR adds a few missing tests cases for the Join class. It brings the coverage up to 100%.
Regards,
Rob

@robertboloc thanks for your contribution!


Use $::serverversion instead of $::puppetversion.

If the puppet master version is older than 3.5.0, but the client version
is newer than 3.5.0, then this will fail since the defined function does not
operate on variables prior to 3.5.0. This leads to the error
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Unable to determine lsbdistid, please install lsb-release first at /etc/puppet/environments/production/modules/apt/manifests/params.pp:137

Using the $::serverversion fact will ensure that the puppet version that evaluates the defined function succeeds.

Ran into the same problem, came to the same solution.

Thanks for the PR, apt has moved a long way since then. The module supports puppet 4.7.0 and greater. I am closing this pr. If you still feel this is valid, please feel free to create another pr.


Cursor is hard to find

The cursor being text is often hard to find with the black background. I think setting it to the default would enhance the usability a bit

Closing due to lack of activity and also that can be tweak with plugins 👌


use_contract!

fixes #38

also implemented decode for constant functions and contract constructors

Looks good but, the PR is quite huge. Is it possible to split it into two PRs?

@tomusdrw not really. I've also updated many ethabi interfaces and they are used by ethabi_derive crate.

Can't we review ethabi_derive crate separately then?

Major version bump required, because it touches a lot of public methods.

yes! I will bump the version after derive is merged ;)


Fixes #362 add a focus ring to content area

I'm not quite ready to submit but would like someone to review my approach to fixing this before I test on all platforms.  Seems simple enough but there may be subtleties that I missed.
thanks,
-becky

Hello Becky, I produced a new PR using your code (now merges fine in refactored develop branch):
https://github.com/readium/readium-js-viewer/pull/371/files


Confusing warning on FTP transfers

Issue in help/using/integration/sending-audience-data/batch-data-transfer-explained/inbound-ftp-filenames.md
The warning regarding the FTP inbound not being supported is somewhat confusing / concerning to clients. Currently we still process files if they are sent to our inbound FTP endpoint (unless this changed recently??).
Could this be updated to reflect that existing FTP configurations will still continue to work for the time being?

Thanks for pointing this out, Shane. We've reworded the section to make things clearer.


low wifi signal strength shows N/A instead of weak status

wifi strength added in #715 has a bug, status should be "weak" for < -70 dBm instead of "N/A", this issue may not be specific to blink.
querying select data for all zones:
Did not receive valid response from server.
zone: 0, name: 0, temp: -123456789.0, wifi strength: -123456789.0 dBm (N/A), battery voltage: -123456789.00 volts (ok)
Did not receive valid response from server.
zone: 1, name: 1, temp: 28.0, wifi strength: -64.0 dBm (ok), battery voltage: 1.66 volts (ok)
Did not receive valid response from server.
zone: 2, name: 2, temp: 28.0, wifi strength: -66.0 dBm (ok), battery voltage: 1.70 volts (ok)
Did not receive valid response from server.
zone: 3, name: 3, temp: 28.0, wifi strength: -62.0 dBm (ok), battery voltage: 1.68 volts (ok)
Did not receive valid response from server.
zone: 4, name: 4, temp: 30.0, wifi strength: -49.0 dBm (ok), battery voltage: 1.69 volts (ok)
Did not receive valid response from server.
zone: 5, name: 5, temp: 33.0, wifi strength: -70.0 dBm (ok), battery voltage: 1.46 volts (ok)
Did not receive valid response from server.
zone: 6, name: 6, temp: 28.0, wifi strength: -77.0 dBm (N/A), battery voltage: 1.65 volts (ok)
Did not receive valid response from server.

root cause is that BOGUS_BOOL is set to False, so function can't distinguish between BOGUS_BOOL and False results.  Fix is to define BOGUS_BOOL as None instead, need to do full testing to understand if this change impacts other functions.


Fix for state-flow plugin

Also adding the alexaEvent to the Reply object, this just makes it
easier to test assertions

Coverage increased (+0.04%) to 92.941% when pulling 2d1d49ebe41fc3fd399ffb218405068a983b9470 on armonge:task/state-flow into 1fb2d52d345d1ac094129965e441d6779a9f6c79 on mediarain:master.

This addresses #17

Coverage increased (+1.2%) to 94.055% when pulling e16688550bd59addfb70bea12e19a76510da8630 on armonge:task/state-flow into 1fb2d52d345d1ac094129965e441d6779a9f6c79 on mediarain:master.

Coverage increased (+1.2%) to 94.055% when pulling 1c54314376c31942902ebce9d592e99a1b607991 on armonge:task/state-flow into 1fb2d52d345d1ac094129965e441d6779a9f6c79 on mediarain:master.


Print shows empty page after every page

Im using a little customized viewer.js and viewer.html. When printing i get an empty extra page after every page. Do you have any thoughts what could cause this?
It works within original viewer example. beforePrint() is untouched. I also don't see any additional styles attached to #printContainer except for original viewer styles. HTML-output looks good, too:

Look for an issue in CSS -- something tells (e.g. padding or height) that canvas or div bigger than a page. We cannot help without complete example. Also provide more details. Closing as incomplete.

I got it working. What i did:
I commented out afterPrint function content in viewer.js so the printContainer gets not deleted. Then i pressed print (cmd + p) and clicked cancel. In developer tools i rendered media print css. Now i was able to see the print output and inspect the css. I did the same with the pdf.js-example and compared both.
What needed to be done for me: body and container of printContainer needs to have height:100% and overflow:visible.

See also https://github.com/mozilla/pdf.js/pull/7677


Q: How show 2 different toolboxes when editing 2 different regions?

Hello, how show 2 different toolboxes when editing 2 different regions without init 2 different ContentTools on them?
For example, when I edit div with attr data-name="article-content", I see default toolbox with all tools.
And when I edit div with attr data-name="article-annotate", I see toolbox with 'italic' and 'link' tools only.
Thanks.

Hi @Folo4ka thanks for your question, this is the topic of some debate and development currently and you can find more information against the following post https://github.com/GetmeUK/ContentTools/issues/79.
Currently it's not possible to do this without modifying the library a little bit however support for this feature is planned in the near future.


feat: database branching

Changes

CreateBranch and DeleteBranch operations on Database

Other changes

Generated api (docstrings for most part)

Codecov Report
Base: 79.47% // Head: 79.62% // Increases project coverage by +0.14% :tada:

Coverage data is based on head (6a7b754) compared to base (cf3ae63).
Patch coverage: 80.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   79.47%   79.62%   +0.14%
==========================================
  Files          29       29
  Lines        2612     2675      +63
==========================================
+ Hits         2076     2130      +54
- Misses        426      432       +6
- Partials      110      113       +3

Impacted Files
Coverage Δ

driver/internal.go
93.75% <ø> (+6.25%)
:arrow_up:

driver/types.go
0.00% <ø> (ø)

driver/driver.go
82.81% <40.00%> (-1.75%)
:arrow_down:

driver/http.go
70.64% <78.57%> (+0.34%)
:arrow_up:

driver/grpc.go
81.23% <100.00%> (+0.87%)
:arrow_up:

tigris/client.go
83.72% <100.00%> (+3.16%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore: make cosim quicker on default build

I realized that I was never really running cosim locally because it took too long --- in an effort to remedy the situation, I set make (the default make all) rule to run quick-cosim, which sets --num-tests=3. While this is still a tad too long for my taste, it is, at the very least, tolerable, so I actually run cosim locally now rather than relying on CI (:
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

Instead of adding a new target, I recommend simply setting the default NUM_TESTS to 3. Anyway in CI, we run make cosim NUM_TESTS=100 which does the heavyweight conformance testing.

@shigoel updated PR to set default_numTests to 3.


Migrate missing eslint rules during migration from eslint

Problem description
Based on the discussion https://github.com/ChainSafe/lodestar/pull/7108#issuecomment-2386606996 there are few eslint rules which don't have alternative biome rules yet. We keep this issue as tracker to migrate those when available, or decide which rules are not useful anymore.

[ ] await-thenable
[ ] ban-ts-comment
[ ] explicit-function-return-type
[ ] func-call-spacing
[ ] no-duplicate-enum-values
[ ] no-floating-promises
[ ] no-non-null-asserted-optional-chain
[ ] no-unnecessary-type-assertion
[ ] no-unsafe-assignment
[ ] no-unsafe-call
[ ] no-unsafe-member-access
[ ] no-unsafe-return
[ ] no-unused-expressions
[ ] no-var-requires
[ ] restrict-template-expressions
[ ] return-await
[ ] semi
[ ] strict-boolean-expressions
[ ] triple-slash-reference
[ ] type-annotation-spacing
[ ] vitest/consistent-test-it
[ ] vitest/prefer-called-with
[ ] vitest/prefer-spy-on
[ ] expect-expect
[ ] no-identical-title
[ ] no-commented-out-tests
[ ] valid-title
[ ] valid-expect
[ ] valid-describe-callback
[ ] require-local-test-context-for-concurrent-snapshots
[ ] no-import-node-test
[ ] func-names
[ ] new-parens
[ ] no-caller
[ ] no-delete-var
[ ] no-extra-semi
[ ] no-mixed-spaces-and-tabs
[ ] no-restricted-syntax
[ ] no-unexpected-multiline
[ ] no-useless-backreference
[ ] object-curly-spacing

Solution description
There should be no useful rule left out.
Additional context
No response

The semi rule is actually a formatting configuration in biomejs, not the lint rule.
https://github.com/ChainSafe/lodestar/blob/a570048187f1e729c0be3939239fcfa3aa0a008e/biome.jsonc#L266

to fix your trouble check this solution click
maybe this will solve your problem.


Use the more adequate GoToRegion API method in Region Playlist + other improvements

Fixes  #1512
My goal was to make the Region Playlist more robust and reliable. In my opinion, in its current state it's just not good enough for any serious tasks. I really wanted to use it with my band for live gigs and rehearsals, but the issue with markers and the regular sync losses were unacceptable.
Through experiments I found that proper bound checking was needed to avoid the occasional sync loss/skipped regions due to numeric error. Even though reaper says a region starts at t1 and ends at t2 (EnumProjectMarkers), the reported play position (from GetPlayPosition) can be slightly less than t1 or slightly greater than t2. I chose an epsilon of 10ms as this value was already used in a couple of places.
A much more common bug was the sync loss after the very first region, where it just kept playing past the end of the region. This was due to a timing issue. I could reproduce it with both the smooth seek method and the GoToRegion method. My measurements clearly indicated a correlation between the occurrence of this bug and the time between the PlaylistPlay function call and the first PlaylistRun callback. If this measured time was less than about 5ms, the bug almost always happened. It seems like if not enough time has passed between the OnPlayButton call and the 'scheduling' of the second region via smooth seek/GoToRegion, then Reaper ignored the schedule 'request'. After I delayed the scheduling by 5 callbacks (160-200 ms), I couldn't reproduce this bug anymore. I added this small delay to all GoToRegion calls, just to be safe (and also it was easier this way).
Sadly the ending of the playlist must be done with a smooth seek, which of course also considers regular markers. I timed this after any markers that are within a region, but to be safe, there should be at least 0.5 seconds between the end of the region and any markers within.
I added two checks with warning dialogs due to these changes.
Also I stopped the SYNC LOSS text from flashing when the playlist finished, to make it look more professional.
I tried to keep the sync loss and end-of-playlist behavior the same as before. In my manual testing it was OK.
I tested my changes with looped/missing/touching regions as well as some loop corner cases I found in the c++ code comments. I ran a quite complex playlist with all these different scenarios on infinite loop, with a very elegant abort() call on sync loss or skipped regions, and it ran for about 250 loops without failure before I shut it down.

Have these changes been added to the official build?

Nah. I just proposed these changes, but the original authors still need to review and accept it.
I don't know when this will happen.

OK

Oh. Okay. Sorry, Git and Github is still new to me, I only have experience with centralized VCS's. Thanks for the infos.

:white_check_mark: Build sws 966-master completed (commit https://github.com/reaper-oss/sws/commit/eb35660f86 by @Szapi)

Windows 64-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-f84a41c1.exe

Windows 32-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-f84a41c1.exe

macOS x86 64-bit

build/sws-<IP_ADDRESS>-Darwin-x86_64-f84a41c1.dmg

macOS x86 32-bit

build/sws-<IP_ADDRESS>-Darwin-i386-f84a41c1.dmg

macOS ARM 64-bit

build/sws-<IP_ADDRESS>-Darwin-arm64-f84a41c1.dmg

Linux x86 64-bit

build/sws-<IP_ADDRESS>-Linux-x86_64-eb35660f.tar.xz

Linux x86 32-bit

build/sws-<IP_ADDRESS>-Linux-i686-eb35660f.tar.xz

Linux ARM 64-bit

build/sws-<IP_ADDRESS>-Linux-aarch64-eb35660f.tar.xz

Linux ARM 32-bit

build/sws-<IP_ADDRESS>-Linux-armv7l-eb35660f.tar.xz

:white_check_mark: Build sws 967-master completed (commit https://github.com/reaper-oss/sws/commit/22c9e8a548 by @Szapi)

Windows 64-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-22c9e8a5.exe

Windows 32-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-22c9e8a5.exe

macOS x86 64-bit

build/sws-<IP_ADDRESS>-Darwin-x86_64-22c9e8a5.dmg

macOS x86 32-bit

build/sws-<IP_ADDRESS>-Darwin-i386-22c9e8a5.dmg

macOS ARM 64-bit

build/sws-<IP_ADDRESS>-Darwin-arm64-22c9e8a5.dmg

Linux x86 64-bit

build/sws-<IP_ADDRESS>-Linux-x86_64-22c9e8a5.tar.xz

Linux x86 32-bit

build/sws-<IP_ADDRESS>-Linux-i686-22c9e8a5.tar.xz

Linux ARM 64-bit

build/sws-<IP_ADDRESS>-Linux-aarch64-22c9e8a5.tar.xz

Linux ARM 32-bit

build/sws-<IP_ADDRESS>-Linux-armv7l-22c9e8a5.tar.xz

I'll close this PR and create a new one with squashed commits.


Set head/stash reference after pop/drop stash

Fixes the issue  "Dropping multiple stashs in a row segfaults #637". The cause of the crash was that the commit list was not properly updated after pop/drop stash actions.  With this change the commit list is updated or when the stash gets empty (after last pop/drop)  then the head is selected as current reference.

Tested.  I can confirm this works.  Nice bug fix!
One suggestion:  If I do Stash->Pop Stash with 2 or more stashes, my view is set to the stash list.  Instead, wouldn't it make more sense to always set the view to show Uncommitted Changes after a stash pop?  I'm not sure if there is a clean way to do this currently, so maybe this would be a future enhancement to not hold up this PR.

Thanks for testing and the input regarding Stash->Pop Stash. I totally agree with you and did that change. I put the setReference in the refresh function.
An additional benefit of this is that fixes the following problem which I just noticed:
Initial state - stash selected and commit list contains stashes:

Press Refresh
=> The head revision ist selected but the commit list contains stashes:

In your last commit #4cb4410, when I refresh, it automatically selects the top item in the CommitList.  In my opinion, this is disorienting.  When a certain commit selected, I like that commit to stay selected unless the user specifically moves to another one by clicking or using arrow keys.
I think your mCommits->setReference(mRepo.head()); is excellent in the case where the selected commit no longer exists (e.g. a popped stash, or any commit that was deleted/rebased).  But doing upon every refresh event seems a bit heavy-handed.
Thoughts?

I agree that a refresh should only have an effect if there was actually a change (e.g. in the background by a command line action).  Thus the last commit is no improvement. The simple solution would be that I put mCommits->setReference(mRepo.head()); in the popStash function. Though I will think a bit more about modifying the void RepoView::refresh(bool restoreSelection) function because somehow it feels right to handle it there.

Tested. I can confirm this works. Nice bug fix!
One suggestion: If I do Stash->Pop Stash with 2 or more stashes, my view is set to the stash list. Instead, wouldn't it make more sense to always set the view to show Uncommitted Changes after a stash pop? I'm not sure if there is a clean way to do this currently, so maybe this would be a future enhancement to not hold up this PR.

I was able to change it that the the view shows Uncommitted Changes after a stash pop.


Not able to read excel files with cell styles

Sheetjs is unable to read files close to 30mb or above with multiple sheets with cellStyles property "true".
{
cellDates: true,
cellStyles: true
}
It does not throw any error,the process run for infinite time.
Without cellStyles there is no issue in reading file.
Node 12.18 is runtime environment

If you can share the file, we can take a closer look.  It's probably too large to share directly, so post to a file sharing service and share a link.

const XLSX = require("@sheet/core");
const workbook = XLSX.readFile("sample.xlsx", {
cellDates: true,
cellStyles: true,
type: "buffer",
});
const report = XLSX.writeFile(workbook, "resultWithStyles.xlsx", {
cellStyles: true,
type: "buffer",
compression: true,
});
Above is read and write code which i am using.
https://test-bk-5.s3.amazonaws.com/sample.xlsx
Link for sample file

If this is relating to Pro builds, send an email to<EMAIL_ADDRESS>


Expose record notification settings

Expose the user preferences for record notifications defined within https://github.com/impactasaurus/server/issues/305. This should be within the user's profile, rather than the settings menu, given that it is user specific.

 New Record Notifications


read_hipscat(search_filter) is confusing

Bug report
It is not clear from the API docs (and there are no RTD docs) that read_hipscat(search_filter=...) would not filter the data, but only the partitions. It is also confusing that Catalog._search is private, so user is not supposed to reuse the same search object: lsdb.read_hipscat(search_filter=search).search(search).
Before submitting
Please check the following:

[x] I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
[ ] I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
[ ] If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.

I agree. I believe we did this ``coarse'' so that it is faster, but it is very unclear and misleading.

Sandro - can you write up some alternatives for discussion?

We decided to change the current behavior of read_hipscat(search_filter) to meet the users' expectations, performing the fine search in addition to the partition coarse search. We should try to add fine as a property of the search object and make the internal _search method public so users can reuse their search objects if desired.


create a little README.md file to describe what this project does...

... no idea, sounds like fun :) something about an Elasticsearch plugin for OpenShift?

Will do soon. It's an experiment to sync up openshift auth policies with search guard ACLs so we can restrict who can see what data in elasticsearch based on openshift authentication.

ah cool! that sentence sounds a good enough first cut of a README.md :)

Done!


Nginx as caching proxy

Quote from: krists/refile-postgres#3
Serving the content directly through the Rails-App is expensive. So I configured my
asset host (nginx) as an caching proxy. Maybe someone can use it too, so I like to share it.
I don't know where to put it. Maybe as an example would it be good.
http {
 ...
proxy_cache_path /.../shared/public/uploads levels=1:2 keys_zone=my_app_production:250m inactive=6000m;

server {
  server_name assets.my-app.example.com
   proxy_cache my_app_production;
   location  ^~ /attachments/ {

gzip_static on;
    expires max;
    add_header Cache-Control public;
    add_header X-Proxy-Cache $upstream_cache_status;

    proxy_ignore_headers Set-Cookie Cache-Control Expires;
    proxy_cache_key $host$uri$is_args$args;
    proxy_hide_header Set-Cookie;
    proxy_hide_header Cache-Control;
    proxy_hide_header Expires;
    proxy_cache_valid 200 600m;

    proxy_store_access user:rw group:rw all:r;
    proxy_store        on;

    proxy_cache_bypass        $http_secret_header;

    proxy_pass http://www.my-app.example.com ;

   }

Nice :) I'm not a huge fan of wikis (they tend to rot), so I'm not sure where this should go. I think it would be nice to have different setups documented somewhere for different caching proxies, as this comes up a lot in issues. Options we have are:

rack/cache
Varnish
Front end server like nginx or apache
CDN

Currently we push very hard for the CDN option, but I think it's not the best choice for a lot of people. Performance for "long-tail" requests can be pretty bad it seems (see #180 for example). It would be very nice to have comprehensive setup guides for all these options, but who has time to write those? :'(

I haven't used S3 until now. But with my nginx caching config I had have some issues too, to get it up and running. nginx respects Cache-Control, Expires and some other headers. Like you see I had have to trick some things with the headers. Also when a Cookie is send from the app server nginx wouldn't cache the response. I think this can be an issue too with S3 and some body should have a look at
 expires Refile.content_max_age, :public, :must_revalidate

within the Refile:App. I think 'must_revalidate' is an issue for caches. Posts about must_revalidate are ambiguous. Is a Cookie with this response? This can fail caches to cache.

@dspaeth-faber I haven't investigated this much at all. :must_revalidate could well be the wrong choice.

So I would suggest a little change within send_file to get better caching capabilities

  ...
  expires *Refile.content_expiration  #   Refile.content_expiration = [Refile.content_max_age, :public]
  last_modified file.mtime
  etag Digest::MD5.hexdigest(file.read)
  set :sessions, false

For what it's worth, I'm seeing issues similar to what's described in #180 using both CloudFront and CloudFlare (infrequently-requested assets tend to get evicted after a day or two on both). I spent a good amount of time today on calls/emails with people at CloudFlare, Fastly, and Heroku, and none of them have a great solution for this.
Fastly seems to come closest with a ~40 day long-tail eviction policy (though nothing guaranteed, of course), but this gets really complex really quickly when running on Heroku or a similar PaaS.
I'd love to help with these problems, but right now there doesn't seem to be a clear solution.

(This might not really be relevant to #209, but I felt weird commenting on #180 because it's closed. Sorry, everyone!)

@paulstraw I've opened #229 to discuss this issue further.


Make tableslurp able to restore recursively

Hello!
This commit makes tableslurp able to restore recursively based on the origin provided. I've tried to make it backwards compatible so it keeps it's original behaviour in case there are others using it. I'm not good with Python and I don't know Pythonic ways of doing things so comments are welcome.
Basically, it introduces a --recursive flag, and for every found table it will create a DownloadHandler, let that run to completion, then move on to the next table. An example:
tableslurp -n <IP_ADDRESS> --recursive --aws-region ap-northeast-2 lerhtest /cassandra/data backuptest/
tableslurp [2017-10-17 02:04:20,356] INFO Building fileset
tableslurp [2017-10-17 02:04:20,481] INFO Found restoretest/ledger-c2e4a3a0b21911e789d4671ea19485f1 with 25 files
tableslurp [2017-10-17 02:04:20,516] INFO Found restoretest/perks-c375e720b21911e789d4671ea19485f1 with 25 files
tableslurp [2017-10-17 02:04:20,616] INFO Found system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca with 17 files
tableslurp [2017-10-17 02:04:20,654] INFO Found system/local-7ad54392bcdd35a684174e047860b377 with 17 files
tableslurp [2017-10-17 02:04:20,691] INFO Found system/paxos-b7b7f0c2fd0a34108c053ef614bb7c2d with 9 files
tableslurp [2017-10-17 02:04:20,740] INFO Found system/peers-37f71aca7dc2383ba70672528af04d4f with 35 files
tableslurp [2017-10-17 02:04:20,807] INFO Found system/size_estimates-618f817b005f3678b8a453f3930b8e86 with 17 files
tableslurp [2017-10-17 02:04:20,863] INFO Found system/sstable_activity-5a1ff267ace03f128563cfae6103c65e with 9 files
tableslurp [2017-10-17 02:04:20,907] INFO Found system_schema/aggregates-924c55872e3a345bb10c12f37c1ba895 with 9 files
tableslurp [2017-10-17 02:04:20,953] INFO Found system_schema/columns-24101c25a2ae3af787c1b40ee1aca33f with 25 files
tableslurp [2017-10-17 02:04:20,985] INFO Found system_schema/dropped_columns-5e7583b5f3f43af19a39b7e1d6f5f11f with 9 files
tableslurp [2017-10-17 02:04:21,029] INFO Found system_schema/functions-96489b7980be3e14a70166a0b9159450 with 9 files
tableslurp [2017-10-17 02:04:21,059] INFO Found system_schema/indexes-0feb57ac311f382fba6d9024d305702f with 9 files
tableslurp [2017-10-17 02:04:21,106] INFO Found system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6 with 25 files
tableslurp [2017-10-17 02:04:21,162] INFO Found system_schema/tables-afddfb9dbc1e30688056eed6c302ba09 with 25 files
tableslurp [2017-10-17 02:04:21,196] INFO Found system_schema/triggers-4df70b666b05325195a132b54005fd48 with 9 files
tableslurp [2017-10-17 02:04:21,238] INFO Found system_schema/types-5a8b1ca866023f77a0459273d308917a with 9 files
tableslurp [2017-10-17 02:04:21,280] INFO Found system_schema/views-9786ac1cdd583201a7cdad556410c985 with 9 files
tableslurp [2017-10-17 02:04:21,349] INFO Will now try to test writing to the target dir backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48
tableslurp [2017-10-17 02:04:21,349] INFO Will write to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48
tableslurp [2017-10-17 02:04:21,349] INFO Running
tableslurp [2017-10-17 02:04:21,349] INFO Pushing file mc-5-big-Digest.crc32 onto queue
tableslurp [2017-10-17 02:04:21,349] INFO Pushing file mc-5-big-Data.db onto queue
tableslurp [2017-10-17 02:04:21,349] INFO Pushing file mc-5-big-TOC.txt onto queue
tableslurp [2017-10-17 02:04:21,349] INFO Pushing file mc-5-big-Summary.db onto queue
tableslurp [2017-10-17 02:04:21,349] INFO Pushing file mc-5-big-Filter.db onto queue
tableslurp [2017-10-17 02:04:21,349] INFO Pushing file mc-5-big-Statistics.db onto queue
tableslurp [2017-10-17 02:04:21,350] INFO Pushing file mc-5-big-CompressionInfo.db onto queue
tableslurp [2017-10-17 02:04:21,350] INFO Pushing file mc-5-big-Index.db onto queue
tableslurp [2017-10-17 02:04:21,350] INFO Pushing file backups onto queue
tableslurp [2017-10-17 02:04:21,350] INFO Thread #0 processing items
tableslurp [2017-10-17 02:04:21,351] INFO Thread #1 processing items
tableslurp [2017-10-17 02:04:21,351] INFO Thread #2 processing items
tableslurp [2017-10-17 02:04:21,353] INFO Thread #3 processing items
tableslurp [2017-10-17 02:04:21,393] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Digest.crc32 from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Digest.crc32
tableslurp [2017-10-17 02:04:21,406] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-TOC.txt from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-TOC.txt
tableslurp [2017-10-17 02:04:21,418] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Summary.db from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Summary.db
tableslurp [2017-10-17 02:04:21,420] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Data.db from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Data.db
tableslurp [2017-10-17 02:04:21,456] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Filter.db from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Filter.db
tableslurp [2017-10-17 02:04:21,464] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Statistics.db from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Statistics.db
tableslurp [2017-10-17 02:04:21,468] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-CompressionInfo.db from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-CompressionInfo.db
tableslurp [2017-10-17 02:04:21,478] INFO Downloading <IP_ADDRESS>:/cassandra/data/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Index.db from lerhconsultest to backuptest/system_schema/triggers-4df70b666b05325195a132b54005fd48/mc-5-big-Index.db
tableslurp [2017-10-17 02:04:21,485] INFO Thread #0 finished processing
tableslurp [2017-10-17 02:04:21,502] INFO Thread #3 finished processing
tableslurp [2017-10-17 02:04:21,503] INFO Thread #2 finished processing
tableslurp [2017-10-17 02:04:21,503] INFO Thread #1 finished processing
tableslurp [2017-10-17 02:04:21,503] INFO My job is done.
tableslurp [2017-10-17 02:04:21,552] INFO Will now try to test writing to the target dir backuptest/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6
tableslurp [2017-10-17 02:04:21,553] INFO Will write to backuptest/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6
tableslurp [2017-10-17 02:04:21,553] INFO Running
tableslurp [2017-10-17 02:04:21,553] INFO Pushing file mc-9-big-TOC.txt onto queue
tableslurp [2017-10-17 02:04:21,553] INFO Pushing file mc-10-big-TOC.txt onto queue
tableslurp [2017-10-17 02:04:21,553] INFO Pushing file mc-11-big-Data.db onto queue
tableslurp [2017-10-17 02:04:21,553] INFO Pushing file mc-10-big-Index.db onto queue
....and so on.

The end result is:
ubuntu@ip-172-31-9-86:~$ ls backuptest/
restoretest/   system/        system_schema/
ubuntu@ip-172-31-9-86:~$ ls backuptest/restoretest/
ledger-c2e4a3a0b21911e789d4671ea19485f1/ perks-c375e720b21911e789d4671ea19485f1/
ubuntu@ip-172-31-9-86:~$ ls backuptest/restoretest/ledger-c2e4a3a0b21911e789d4671ea19485f1/mc-
mc-1-big-CompressionInfo.db  mc-1-big-Index.db            mc-2-big-CompressionInfo.db  mc-2-big-Index.db            mc-3-big-CompressionInfo.db  mc-3-big-Index.db
mc-1-big-Data.db             mc-1-big-Statistics.db       mc-2-big-Data.db             mc-2-big-Statistics.db       mc-3-big-Data.db             mc-3-big-Statistics.db
mc-1-big-Digest.crc32        mc-1-big-Summary.db          mc-2-big-Digest.crc32        mc-2-big-Summary.db          mc-3-big-Digest.crc32        mc-3-big-Summary.db
mc-1-big-Filter.db           mc-1-big-TOC.txt             mc-2-big-Filter.db           mc-2-big-TOC.txt             mc-3-big-Filter.db           mc-3-big-TOC.txt

The current way of doing it is still preserved:
ubuntu@ip-172-31-9-86:~$ tableslurp -n <IP_ADDRESS> --aws-region ap-northeast-2 lerhconsultest /cassandra/data/restoretest/perks-c375e720b21911e789d4671ea19485f1 backuptest/
tableslurp [2017-10-17 02:10:16,819] INFO Building fileset
tableslurp [2017-10-17 02:10:16,861] INFO Fileset contains 25 files to download
tableslurp [2017-10-17 02:10:16,914] INFO Will now try to test writing to the target dir backuptest/
tableslurp [2017-10-17 02:10:16,914] INFO Will write to backuptest/
tableslurp [2017-10-17 02:10:16,915] INFO Running
tableslurp [2017-10-17 02:10:16,915] INFO Pushing file mc-1-big-Summary.db onto queue
tableslurp [2017-10-17 02:10:16,915] INFO Pushing file mc-2-big-Data.db onto queue
tableslurp [2017-10-17 02:10:16,915] INFO Pushing file mc-3-big-Filter.db onto queue
tableslurp [2017-10-17 02:10:16,915] INFO Pushing file mc-2-big-Digest.crc32 onto queue
tableslurp [2017-10-17 02:10:16,915] INFO Pushing file mc-3-big-Summary.db onto queue
tableslurp [2017-10-17 02:10:16,915] INFO Pushing file mc-1-big-CompressionInfo.db onto queue
tableslurp [2017-10-17 02:10:16,915] INFO Pushing file mc-2-big-Index.db onto queue...
.....
tableslurp [2017-10-17 02:10:17,267] INFO Downloading <IP_ADDRESS>:/cassandra/data/restoretest/perks-c375e720b21911e789d4671ea19485f1/mc-1-big-Index.db from lerhconsultest to backuptest/mc-1-big-Index.db
tableslurp [2017-10-17 02:10:17,278] INFO Thread #2 finished processing
tableslurp [2017-10-17 02:10:17,282] INFO Downloading <IP_ADDRESS>:/cassandra/data/restoretest/perks-c375e720b21911e789d4671ea19485f1/mc-3-big-Data.db from lerhconsultest to backuptest/mc-3-big-Data.db
tableslurp [2017-10-17 02:10:17,288] INFO Downloading <IP_ADDRESS>:/cassandra/data/restoretest/perks-c375e720b21911e789d4671ea19485f1/mc-3-big-TOC.txt from lerhconsultest to backuptest/mc-3-big-TOC.txt
tableslurp [2017-10-17 02:10:17,295] INFO Thread #3 finished processing
tableslurp [2017-10-17 02:10:17,305] INFO Thread #1 finished processing
tableslurp [2017-10-17 02:10:17,322] INFO Thread #0 finished processing
tableslurp [2017-10-17 02:10:17,322] INFO My job is done.

Giving:
backuptest/
mc-1-big-CompressionInfo.db  mc-1-big-Statistics.db       mc-2-big-Digest.crc32        mc-2-big-TOC.txt             mc-3-big-Index.db
mc-1-big-Data.db             mc-1-big-Summary.db          mc-2-big-Filter.db           mc-3-big-CompressionInfo.db  mc-3-big-Statistics.db
mc-1-big-Digest.crc32        mc-1-big-TOC.txt             mc-2-big-Index.db            mc-3-big-Data.db             mc-3-big-Summary.db
mc-1-big-Filter.db           mc-2-big-CompressionInfo.db  mc-2-big-Statistics.db       mc-3-big-Digest.crc32        mc-3-big-TOC.txt
mc-1-big-Index.db            mc-2-big-Data.db             mc-2-big-Summary.db          mc-3-big-Filter.db

The current way of doing it is a little bit finicky as mentioned in  https://github.com/JeremyGrosser/tablesnap/issues/57. I've also added a check to make --recursive and -file mutually exclusive.
Thanks!

I've retested and updated the PR based on your comments, let me know if there are any more changes you think would be good :)

This feature has been needed for a long time, thanks for contributing it! I also appreciate the approach of leaving the default behavior the same and enabling recursive via a simple flag.

Hi,
I've done a little bit of changes to also make it able to restore CLogs as referenced in https://github.com/JeremyGrosser/tablesnap/issues/88.
Hopefully it's much cleaner now. Also please let me know if you would like to split out the branches. I've tested these on my test EC2 instances, so should be good.


Clusters

Add a view of clusters - calculated by the BackEnd

Also - check out clusters given by Leaflet - what are the differences?


feat: useInlineTrace plugin for federated tracing

Closes #1607
Only one question: since the federated tracing thing is Apollo specific, should the plugin be named useApolloInlineTrace instead?

I agree with changing the name. As you said, it is Apollo specific.

Waiting for https://github.com/n1ru4l/envelop/pull/1490.


integration with new instance ID

Overview

@rcohencyberarmor One this PR is merged, you will be using the interfaces.


How use alpine/bombardier via vpn?

For example how use ?
docker run -ti --rm alpine/bombardier -c 1000 -d 3600s -l https://mil.ru
like in https://github.com/Arriven/db1000n/blob/main/run.sh

@goodandrewsoft could you please expand your question? Basically, all you need is to turn on VPN and run docker run ghcr.io/arriven/db1000n or just run binaries.
You don't need alpine/bombardier in this implementation

I know that. I'm already use db1000n via run.sh
But, sometimes, i want use alpine/bombardier manually and i want automate my process like in run.sh

I'll assign this to @bitshape as he's the author of that implementation and knows about it more than me.

It's not detailed instruction, but you asked a question in the wrong repo. It's a different project from bombardier.
So I have no knowledge about db1000n or bombardier, I'm just like you - a user, but I can give you some idea of what to do:

add openvpn for your version of alpine/bombardier image (Add means install)
you will definitely need --cap-add=NET_ADMIN for your docker run command (as in run.sh)
mount your openvpn.config as in this example or just copy all configs you have to the running container.
Make OpenVPN as a service to make it autostart. Or just run it as a next command after a run of your alpine/bombardier container:
"docker exec ....... OpenVPN --config ... -auth ...."

you will probably need to restart your VPN very frequently, so just add a script like this in your image and run it through docker exec whenever you need it:
killall -TERM openvpn
cp -r vpn/newconfig.ovpn vpn/config.ovpn
openvpn --config vpn/config.ovpn --auth-user-pass vpn/pvpnauth --verb 6 > openvpn_log

Not sure which VPN you are using, but they are not very reliable, so having a log is not a bad idea.


Disable button to disable the extension

Possible solution here - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/management/setEnabled

Possible solution here - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/management/setEnabled


Cannot use @react-email/components with Cloudflare

Describe the Bug
I keep getting error with Publish to Cloudflare Pages with Github Actions when using the @react-email/components.
Which package is affected (leave empty if unsure)
@react-email/components
Link to the code that reproduces this issue
no link
To Reproduce
Run cloudflare/pages-action@v1
npm warn exec The following package was not found and will be installed<EMAIL_ADDRESS>npm warn deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm warn deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
Delegating to locally-installed<EMAIL_ADDRESS>over global<EMAIL_ADDRESS>Run `npx wrangler pages publish ./build/client --project-name=web-starter-cloudflare --branch=main` to use the local version directly.
▲ [WARNING] `wrangler pages publish` is deprecated and will be removed in the next major version.
  Please use `wrangler pages deploy` instead, which accepts exactly the same arguments.
✨ Compiled Worker successfully
Uploading... (9/9)
✨ Success! Uploaded 0 files (9 already uploaded) (0.30 sec)
✨ Uploading _headers
✨ Uploading Functions bundle
✨ Uploading _routes.json
🌎 Deploying...
✘ [ERROR] Deployment failed!
  Failed to publish your Function. Got error: Error: Script startup exceeded CPU time limit.
🪵  Logs were written to "/home/runner/.config/.wrangler/logs/wrangler-2024-06-16_03-00-22_546.log"
npm notice
npm notice New minor version of npm available! [10](https://github.com/colesanderson/web-starter-cloudflare/actions/runs/9532835999/job/26275393016#step:6:11).7.0 -> 10.8.1
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
npm notice To update run: npm install -g<EMAIL_ADDRESS>npm notice
EXIT WHEN NOT EXPECTED
SHELLAC COMMAND FAILED!
Executing: npx wrangler@2 pages publish "./build/client" --project-name="web-starter-cloudflare" --branch="main" in /home/runner/work/web-starter-cloudflare/web-starter-cloudflare
STDOUT:
Delegating to locally-installed<EMAIL_ADDRESS>over global<EMAIL_ADDRESS>Run `npx wrangler pages publish ./build/client --project-name=web-starter-cloudflare --branch=main` to use the local version directly.
✨ Compiled Worker successfully
Uploading... (9/9)
✨ Success! Uploaded 0 files (9 already uploaded) (0.30 sec)
✨ Uploading _headers
✨ Uploading Functions bundle
✨ Uploading _routes.json
🌎 Deploying...
STDERR:
npm warn exec The following package was not found and will be installed<EMAIL_ADDRESS>npm warn deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm warn deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
▲ [WARNING] `wrangler pages publish` is deprecated and will be removed in the next major version.
  Please use `wrangler pages deploy` instead, which accepts exactly the same arguments.
✘ [ERROR] Deployment failed!
  Failed to publish your Function. Got error: Error: Script startup exceeded CPU time limit.
🪵  Logs were written to "/home/runner/.config/.wrangler/logs/wrangler-2024-06-[16](https://github.com/colesanderson/web-starter-cloudflare/actions/runs/9532835999/job/26275393016#step:6:17)_03-00-22_546.log"
npm notice
npm notice New minor version of npm available! 10.7.0 -> 10.8.1
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
npm notice To update run: npm install -g<EMAIL_ADDRESS>npm notice
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "#<Object>".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Code
import { json } from "@remix-run/cloudflare";
import { Resend } from "resend";
import { render } from "@react-email/render";
import { Button } from "@react-email/components";

export async function action(args: ActionFunctionArgs) {
  const { request, context } = args;
  const { env } = context.cloudflare;

  const resend = new Resend(env.RESEND_EMAIL);

  const Foo = () => (
    <Button href="https://example.com" style={{ color: "#61dafb" }}>
      Click me
    </Button>
  );

  const emailHtml = render(<Foo />);

  try {
    // Sending an email using the Resend API
    const { error } = await resend.emails.send({
      from: `Person <${defaultEmail}>`,
      reply_to: email,
      to: [defaultEmail],
      subject: "Form Submission",
      html: emailHtml,
      // render: <Foo /> // tried this too
    });

    if (error) {
      throw new Error("Failed to send email");
    }

    return json({ success: true, message: "Email sent successfully!" });
  } catch (error) {
    return json({ error: (error as Error).message }, 400);
  }
}

export default function Contact() {
  return <Contact />;
}

Expected Behavior
Expecting for deploy to work or output more helpful error?
What's your node version? (if relevant)
v20.10.0

Please, make a proper minimal reproduction here. This might be caused by various things and to properly narrow down what is wrong, I wanted something that I could quickly use to reproduce your issue.

Hey @gabrielmfern

npm create cloudflare@latest my-remix-app -- --framework=remix
Install resend, @react-email/render, @react-email/components
Create a simple component using @react-email/components, can copy from https://demo.react.email/preview/notifications/vercel-invite-user?view=source
Deploy to cloudflare
Getting deploy error

What version of render are you on?

Got a reproduction going, and it seems like installing the individual packages makes the error go away. Not sure exactly what might be causing this, if it's the exports that components does, or if it's because of Tailwind itself being so large at the moment.
Does not seem related to resend at all, though, as I could reproduce with just an action that renders the email template.

This seems to be caused by Tailwind by trying to import the components individually until it errors on deploy. Pretty sure this is equivalent to #1101 and should be fixed by #1383.

Any ETA for #1383 to complete? I'm also facing the same issue with Cloudflare pages, it is related to the Tailwind package too large. The size of the script already exceeded 3 MB and can't deploy it to Cloudflare pages.

Having the same problem here when deploying to Cloudflare Pages:
Error: Script startup exceeded CPU time limit.

I believe some work is being done in the global scope and I'm not sure what justifies that.

For those looking for a fix, I'd suggest lazy importing every component.
const Body = lazy(async () => {
  return { default: (await import("@react-email/components")).Body };
});

This way, they won't bloat the global scope, resulting in faster startup, which makes sense anyway.

Importing components individually instead of via @react-email/components (including Tailwind) fixed the issue for me

import { Section } from '@react-email/section'
import { Body } from '@react-email/body'
import { Container } from '@react-email/container'
import { Img } from '@react-email/img'
import { Head } from '@react-email/head'
import { Preview } from '@react-email/preview'
import { Tailwind } from '@react-email/tailwind'
import { Html } from '@react-email/html'
import { Text } from '@react-email/text'
import { Link } from '@react-email/link'

We just merged #1383 and released it under canary<EMAIL_ADDRESS>should fix it


Generate all preferred APIs by default

This commit removes support for the id flag from the generate-api
script. Additional Discovery documents are still supported via the url
flag.
The new behavior is to generate clients for all APIs marked as preferred
by the Discovery index if the from_discovery flag is true.

Coverage remained the same at 96.137% when pulling a2e5548c1a5f6065f5333ce470b6aa9e2a649f7b on saicheems:pref_only into b87af01703c26be161bdee35acd6efca3e7e3a36 on google:master.

Will roll with this for now, let me know if you want any changes.

There are some actively developed APIs that are not marked as preferred. Specifically, need to make sure all the admin:* APIs are generated as well as drive:v2.


Selection moving outside visible region results in a crash

If you generate some scrollback, select some stuff, and the scroll away from the selection, alacritty will crash. This is because the selection is not being clipped when visible or ignored when completely off-screen.

resolved in #1172


Bugfix: MultiNodeChainList should not assume float32

This PR improves float16 support for model parallelization.  The bug was found in #6575.

pfnci, test this please

Jenkins CI test (for commit 38b4cb5756b0ae8257b040e950b8488eb62b91c1, target branch master) failed with status FAILURE.

pfnci, test this please.

Jenkins CI test (for commit 38b4cb5756b0ae8257b040e950b8488eb62b91c1, target branch master) failed with status FAILURE.

The Jenkins failure
test_Power_param_584_{in_dtypes=('float16', 'float16'), out_dtype='float16', in_shapes=((2, 3), (2, 3)), input_lhs=3, input_rhs=3.0, is_module=False}[native:0]

seems unrelated to the PR.

We are now having issues with tests. Once we get all the tests passed, I will merge it.


[Bug]: Fire in Projectile

Is there an existing issue for this?

[X] I have searched the existing issues

Have you tried to reproduce this without OP?

[x] I have tested without OP

Current Behavior
When using Fire mechanics in Projectile, enemies do not light up. If Fire in this case is a Target Area child, targets in the area will catch fire. But if you hit a mob, it will not light up, only the mobs in the area. It follows that Fire does not work with Projectile targets.
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Server Software:Paper version git-Paper-205 (MC: 1.18.1)
- ProSkillAPI Version: proskillapi-<IP_ADDRESS>-1330244
- ProMCCore Version: promccore-<IP_ADDRESS>-1150257
- Plugins: LibsDisguises, LuckPerms, ProMCCore, ProRPGItems, ProSkillAPI, ProtocolLib

latest.log
No errors
Anything else?

So if I'm understanding correctly, when using the 'Projectile' mechanic and using that to get the given target, the fire mechanic does not work? But the 'Damage' and 'Item Remove' mechanics do what they are supposed to do as well? Could you possibly send the skill files you're using?

I don't remember exactly anymore, but as I am now convinced, only Damage works. This skill
Fire Arrow.txt


[SPARK-32643][CORE][K8s] Consolidate state decommissioning in the TaskSchedulerImpl realm

What changes were proposed in this pull request?
The decommissioning state is a bit fragment across two places in the TaskSchedulerImpl:
https://github.com/apache/spark/pull/29014/ stored the incoming decommission info messages in TaskSchedulerImpl.executorsPendingDecommission.
While https://github.com/apache/spark/pull/28619/ was storing just the executor end time in the map TaskSetManager.tidToExecutorKillTimeMapping (which in turn is contained in TaskSchedulerImpl).
While the two states are not really overlapping, it's a bit of a code hygiene concern to save this state in two places.
With https://github.com/apache/spark/pull/29422, TaskSchedulerImpl is emerging as the place where all decommissioning book keeping is kept within the driver. So consolidate the information in tidToExecutorKillTimeMapping into executorsPendingDecommission.
However, in order to do so, we need to walk away from keeping the raw ExecutorDecommissionInfo messages and instead keep another class ExecutorDecommissionState. This decoupling will allow the RPC message class ExecutorDecommissionInfo to evolve independently from the book keeping ExecutorDecommissionState.
Why are the changes needed?
This is just a code cleanup. These two features were added independently and its time to consolidate their state for good hygiene.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.

Test build #127518 has started for PR 29452 at commit 61ac7b8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32141/
Test PASSed.

cc: @holdenk and @prakharjain09 ... This PR simply does some state cleanup/consolidation without making any semantic changes. I would be grateful for your review. I have also created a Jira associated with this. Thanks !

Test build #127518 has finished for PR 29452 at commit 61ac7b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ExecutorDecommissionState(message: String,

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127518/
Test PASSed.

Test build #127522 has started for PR 29452 at commit 97ad7fe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32145/
Test PASSed.

@agrawaldevesh Could you please add the [CORE] tag in the PR title like other PRs?

Test build #127522 has finished for PR 29452 at commit 97ad7fe.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ExecutorDecommissionState(message: String,

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127522/
Test PASSed.

Test build #127590 has started for PR 29452 at commit 7449fa2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32213/
Test PASSed.

Test build #127590 has finished for PR 29452 at commit 7449fa2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ExecutorDecommissionState(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127590/
Test PASSed.

Test build #127625 has started for PR 29452 at commit 6a5be83.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32249/
Test PASSed.

Test build #127625 has finished for PR 29452 at commit 6a5be83.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127625/
Test FAILed.

Test build #127627 has started for PR 29452 at commit 9222f05.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32251/
Test PASSed.

Test build #127627 has finished for PR 29452 at commit 9222f05.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127627/
Test FAILed.

retest this please

Test build #127629 has started for PR 29452 at commit 9222f05.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32253/
Test PASSed.

Test build #127629 has finished for PR 29452 at commit 9222f05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127629/
Test PASSed.

Test build #127654 has started for PR 29452 at commit ebd8408.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32277/
Test PASSed.

Test build #127654 has finished for PR 29452 at commit ebd8408.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Can we tag this PR with Kubernetes (add [K8S] to the title) so it runs the K8s integration tests?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127654/
Test PASSed.

Test build #127664 has started for PR 29452 at commit 3541ba9.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32287/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32287/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32287/
Test FAILed.

Apparently  #29466 broke the K8s integration test:
[ERROR] [Error] /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DecommissionSuite.scala:29: value WORKER_DECOMMISSION_ENABLED is not a member of object org.apache.spark.internal.config.Worker

:-P. @holdenk, your email for running K8s integration tests by default was quite apropos.

retest this please

Test build #127666 has started for PR 29452 at commit 3541ba9.

Test build #127664 has finished for PR 29452 at commit 3541ba9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127664/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32290/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32290/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32290/
Test FAILed.

Test build #127668 has started for PR 29452 at commit de7a08c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32292/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32292/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32292/
Test FAILed.

Test build #127666 has finished for PR 29452 at commit 3541ba9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127666/
Test PASSed.

Test build #127668 has finished for PR 29452 at commit de7a08c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127668/
Test PASSed.

@holdenk can you help me diagnose whether the failure in https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32292/console looks legit or flaky ?
I am also not sure about how to repro it locally on my macbook ? Any instructions for this ?
Sorry, n00b to K8s here.

Test build #127699 has started for PR 29452 at commit f73271a.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32323/
Test FAILed.

Test build #127699 has finished for PR 29452 at commit f73271a.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FakeTaskScheduler(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127699/
Test FAILed.

Test build #127701 has started for PR 29452 at commit 3beb1ba.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32325/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32325/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32325/
Test PASSed.

Can't locally repro ExecutorAllocationManagerSuite failure

retest this please

Test build #127703 has started for PR 29452 at commit 3beb1ba.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32327/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32327/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32327/
Test FAILed.

Test build #127701 has finished for PR 29452 at commit 3beb1ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

I think the K8s integration test, particularly "Run SparkPi with no resources" is flaky. This PR passes the main K8s decom test. Indeed it does not really change any semantic behavior there.
So I think it should be safe to be merged in now pending approval.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127701/
Test PASSed.

cc: @holdenk, @cloud-fan and @Ngone51 for another pass of review please. Thank you.

Test build #127703 has finished for PR 29452 at commit 3beb1ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127703/
Test PASSed.

It seems to be failing GHA? I'll set aside my non-meeting time tomorrow for reviews :)

It seems to be failing GHA? I'll set aside my non-meeting time tomorrow for reviews :)

Thanks !. I can't locally repro ExecutorAllocationManagerSuite failure. Unfortunately, mere contributors like me cannot rerun GHA tests. Only committers can do the GHA rerun.

Just close and reopen the PR should trigger the github action test again. @agrawaldevesh
cc @tgravescs  for the flaky ExecutorAllocationManagerSuite : https://github.com/apache/spark/pull/29452/checks?check_run_id=1008962797

Test build #127852 has started for PR 29452 at commit de73e18.

Test build #127853 has started for PR 29452 at commit 86f7732.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32478/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32478/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32478/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32479/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32479/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32479/
Test PASSed.

@holdenk, the PR is ready for your review again. I will close and re-open it shortly to get a clean GHA run. The current failure in Kafka stress tests is unrelated.

Sounds good I’ll take some time today to review this:

Test build #127852 has finished for PR 29452 at commit de73e18.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127852/
Test FAILed.

Test build #127853 has finished for PR 29452 at commit 86f7732.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127853/
Test PASSed.

Test build #127858 has started for PR 29452 at commit 3181412.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32484/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32484/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32484/
Test PASSed.

Test build #127858 has finished for PR 29452 at commit 3181412.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127858/
Test PASSed.

Test build #127895 has started for PR 29452 at commit 9389ed5.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32521/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32521/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32521/
Test FAILed.

@holdenk, I think we should disable or mark flaky this K8s integration test: I have seen it fail many a times now:
- Run SparkPi with no resources *** FAILED ***
  The code passed to eventually never returned normally. Attempted 190 times over 3.0025253718499996 minutes. Last failure message: false was not true. (KubernetesSuite.scala:383)

(in https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32521/console). I can create a ticket for this.

Test build #127895 has finished for PR 29452 at commit 9389ed5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127895/
Test PASSed.

Test build #127905 has started for PR 29452 at commit 6b9ded4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32531/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32531/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32531/
Test PASSed.

Test build #127905 has finished for PR 29452 at commit 6b9ded4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127905/
Test FAILed.

retest this please

jenkins retest this please

Test build #127913 has started for PR 29452 at commit 6b9ded4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32539/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32539/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32539/
Test PASSed.

Test build #127913 has finished for PR 29452 at commit 6b9ded4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127913/
Test FAILed.

Test build #127917 has started for PR 29452 at commit 29fe131.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32542/
Test FAILed.

Test build #127917 has finished for PR 29452 at commit 29fe131.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127917/
Test PASSed.

Hi @holdenk, This PR is back in your court to review again. @Ngone51 is fine with the new set of changes. If it looks good, please feel free to merge it in. Thank you !

Jenkins retest this please

Test build #127933 has started for PR 29452 at commit 29fe131.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32559/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32559/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32559/
Test PASSed.

This looks good to me I'm going to go ahead and merge this.

Test build #127933 has finished for PR 29452 at commit 29fe131.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127933/
Test PASSed.

Thank you @holdenk for shepherding this all the way through !

Thanks for working on this so much! I’m really excited to launch this feature in 3.1 👍


Added support for Cardboard V2.0 style touch-triggers

Also deprecated - (void)magneticTriggerPressed and added - (void)triggerPressed to be more generic.

Hey @iburinoc, thanks a lot for your contribution, this is a worthwhile change.
Some comments:

Replacing -(void)magneticTriggerPressed by -(void)triggerPressed is fine. But I'd rather directly rename the methods instead of deprecating the old one. The change is very minor, so I think it's ok to break previous code on this instance.
I'd add directly add the touch-as-trigger functionality to CBDViewController.mm/h, since this part is iOS specific rather than more generic as the rest of the C++ SDK. Also, I'd add a (on by default if you want) useTouchTrigger property to CBDViewController to optionally disable this feature.

If you do these changes I'll merge the pull request. :)

That sounds reasonable, I implemented the changes :)

Done, thanks a lot for your contribution!


Implement a code freeze prior to release

In the last couple of days prior to releasing 1.28.0 we landed various PRs that created (mostly test) issues
I think we should consider a code freeze - perhaps something short like 3 days in which only release-critical fixes get landed

Would it make sense or be viable to cut a branch something like v1.28.proposed or proposed1.28 three days

that sounds like a great plan tbh
i think it would allow dev to continue and would mean things that are proposed for inclusion can get run on main first
probably we could figure some strategy that made release a bit less painful - ie by running versioned ci beforehand

Yes, "freeze" doesn't send the right signal, branching early and letting it bake a little works fine in Istio, for example.

yeah I like this better as it doesn't negatively impact developer velocity the way a freeze does.


fix: user details add password expiration info

这个 PR 实现什么功能/修复什么问题:
修正：在用户属性显示密码过期信息，系统账户不检查密码过期
是否需要 backport 到之前的 release 分支:

release/2.12

/area keystone
/cc @yousong @zexi

Codecov Report

Merging #3432 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3432      +/-   ##
=========================================
+ Coverage    7.03%   7.04%   +<.01%
=========================================
  Files         496     496
  Lines       82391   82406      +15
=========================================
+ Hits         5797    5806       +9
- Misses      76108   76112       +4
- Partials      486     488       +2

Flag
Coverage Δ

#aFlag
7.04% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/keystone/models/passwords.go
12.32% <0%> (ø)
:arrow_up:

pkg/keystone/models/users.go
1.75% <0%> (-0.04%)
:arrow_down:

pkg/keystone/models/localusers.go
12.16% <0%> (-0.7%)
:arrow_down:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

pkg/cloudcommon/cronman/cronman.go
54.85% <0%> (+5.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9156be...6ed1247. Read the comment docs.

/approve
/lgtm


update roi_average_align_2d doc to refer roi_average_pooling_2d

update roi_average_align_2d doc to refer roi_average_pooling_2d

Jenkins, test this please.

Jenkins CI test (for commit 102031d6029cc276e6162773fdceb87e9bab2a28, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@toslunar This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?


[Feature][Non core] Create visual guides for better tuning/debugging

Current control that we use over debugging OMRChecker for new images is by setting show_image_level to 1 through 6. It is still sometimes not very effective for large number of images. We need a non-intrusive visual guide that helps tune our config for each type of images.
Experienced in data visualizations/analytics?

Contact the developer for a dataset.

Note: this issue is marked with the hacktoberfest label. Follow #hacktoberfest-discussions on Discord for further details .

Adding support for colored bar graphs when solving this issue:
https://github.com/Udayraj123/OMRChecker/issues/39#issuecomment-1949807430


Fixed the positioning of line graph

Overview: What does this pull request change?

Removed a part of code that caused the line_graph to be positioned behind the Axes / NumberPlane. Fixes the issue #1464.

Motivation and Explanation: Why and how do your changes improve the library?

There was a line of code in the coordinate_systems.py that pushed line_graph behind the Axes / NumberPlane. This caused it to have an incorrect color and also obscurred parts of the line_graph, as seen in the image below.

As proposed by @abhi3019 in #1464, removing a single line that changed the z_index of the graph fixed this issue.

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Fixes #1464

I added the test, though I'm not exactly sure whether the test should have been placed into test_coordinates_systems.py or test_axes.py.

That's fine. Thanks for the contribution !


Either your documentation is misleading or your public build is bad

https://unpkg.com/<EMAIL_ADDRESS>Appears to be missing a lot of stuff including everything from https://erebos.js.org/docs/wallet-hd
Did you remove these features and not update the docs or did you recently add the features and not update the build?  Or am I using the wrong version?
I would really like an HDWallet without the need to use webpack and import half the internet into my project.  Erebos looked promising.

The swarm-browser package is documented here: https://erebos.js.org/docs/swarm-client
As documented, it exposes the bzz and pss APIs, not all the libraries part of the Erebos project.

In general if it's in the API docs it should be part of the build.  What is the reason for excluding it but going through the trouble of documenting it?

Also what is the correct method for getting something like the timeline api into a browser, or is this supposed to be node only?  Sorry if this sounds like a silly question, but I don't see a clear path if I want to use the timeline API in the browser.

The docs cover the different packages part of Erebos.
Some of these packages are used in the @erebos/swarm-browser or @erebos/swarm-node packages, that expose the SwarmClient class for the browser or Node. These packages (and the universal @erebos/swarm) are meant as a simple way to get started using Swarm APIs.
Other packages such as the Timeline, HD Wallet, etc. are for more advanced use cases and should be imported individually. They may work in the browser (@erebos/timeline is tested for browser) but only Node is fully supported.


feat: rename tsconfig option to configFile for consistency

As ts-loader and tsconfig-paths-webpack-plugin uses configFile option,
the plugin should use the same for consistency.
BREAKING CHANGE: 🧨 typescript.tsconfig option renamed to the tsconfig.configFile

:tada: This PR is included in version 5.0.0-alpha.16 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Detect if ncurses' backend is terminfo or termcap.

Detect if ncurses' backend is terminfo or termcap. fixes #2662
Borrowed from @mattn's code at:
https://github.com/mruby/mruby/issues/2662#issuecomment-65535705
Signed-off-by: Huei-Horng Yo<EMAIL_ADDRESS>

(Just to make sure.)
I think there isn't has_library method for linker class.
And @mattn says

Hmm, we should add search_library_path. Or has_libraray

In #2662.

has_library is pseudo name for explain.

My fault, I forget to implement has_library method.


[BUG] secret keys in public repos

This is a non-incident from the perspective of blast radius. Should be fixed: Caught as part of adding key scanning controls, and wanting to get to point of disallowing pushes that have secrets to public+private repos.
https://github.com/graphistry/graphistry-helm/blob/05b67109b7dfe8108bb2e9f9e31272c3dde47c45/charts/graphistry-helm/values.yaml#L347
cc @aucahuasi @webcoderz for visibility

I'm not sure of the preferred architectural pattern for solving here

Already rotated & fixed


Selecting heading cell and all children

Now that notebooks support copy and past of a set of cells, it would be very useful to be able to select the heading cell and all its children with a single command. This would then the heading and all its children to be easily move. Indeed, I suspect this is more common that wanting to select just the heading.
A few options:

Change the default so that selecting a heading select all the heading and all children.
Make shift-select of a heading select all children.
Single click of a heading bracket, anywhere, selects the heading and all children.

Yep, seems like a good plan. As for options:

I think making it default might be a bit confusing/frustrating. But it would, I think, make sense to do this for collapsed headings, as it seems a little more intuitive. This can be done probably quite easily, but it will mean that having a heading as the current cell will also highlight it as part of a multi-selection. I think I'd prefer new bindings
Shift-select is already bound, extending selection, so I don't think we ought to repurpose it. Maybe shift-left and shift right could be added as extra key bindings, to select/unselect all cells in the section?
Yep, brackets are an easy, intuitive option, so I can add that in addition to anything else

Thoughts?

Also, note that in Mathematica if you select all cells via bracket, shift-Enter will execute all those cells. This is quite useful - I always have some sort of initialization section in my notebooks.

@kkumer yep, once all the cells are selected, the usual ctrl-enter shortcut will queue all of them for execution.

So, a preliminary solution is available at my branch https://github.com/jcb91/IPython-notebook-extensions/compare/master...usability/collapsible-headings. So far, this includes work to:

Add an extra keyboard shortcut (default shift-right) to select the heading's whole section.
Make the Mathematica-style brackets single-clickable to select the whole section
Decide whether selecting a whole section also reveals it (which was the default, and a bit annoying, so I made it configurable)
fixes an off-by-1 bug in reveal_cell_by_index
fixes the right-alignment of the Mathematica brackets, which I'd accidentally broken somewhere along the line
fixes toggle icon margins inside buttons, which I'd broken (insufficient testing, again, d'oh!)

As always, any thoughts welcome.

So, a few more commits pushed to my branch, which should (hopefully):

Fix persistence and icon-showing issues seen by @kkumer in #482
Fix the config page setting mentioned by @Kevin-McIsaac in jcb91/IPython-notebook-extensions#1
Add a hover state, suggested by @Kevin-McIsaac, so brackets darken when hovered over
Make the bracket width configurable
Slightly alter bracket appearance, giving mitred corners (at least in Chrome, FF & Safari)

Just wondering, would it be worth making toggling a heading set the notebook as dirty (so that it will look unsaved, given metadata has changed)? I haven't bothered as yet, but it's not difficult, so I suppose it might as well be less surprising by not being autosaved, etc...

Should now be fixed by #506


add sqlite3 to be able to backup db from a docker container

How can it run DB without sqlite3 though? Does it mean that there are 2 versions of sqlite in that image now? Or is it just the CLI package? Just wondering.

@rth I'm not positive but it may be the CLI package only, and the python install uses libsqlite3.
(at least running which sqlite3 from within the container yields no result)

Do we want to force a specific version here?  Will it be able to dump upserted files?

Yes, you are right, it's only the CLI,
root@267d7ff5b9cd:/# apt show sqlite3
Package: sqlite3
Version: 3.27.2-3
[...]
APT-Sources: http://deb.debian.org/debian buster/main amd64 Packages
Description: Command line interface for SQLite 3

the version is OK as well (3.24).

@dulacarnold I think we base our image on debian buster, right?
https://packages.debian.org/stable/sqlite3
So a system install gets us sqlite 3.27 which is good for our needs I think?


:mem Update-mirage-block-partition

These improvements include adding comments that explain the purpose of each module and section of code; removing duplicate code by moving the connect_and_partition function into the start function; and using let* rather than let%bind in order to maintain consistency with the rest of the codebase.

Another question: is this for Outreachy?

Another question: is this for Outreachy?

Yes this is for outreachy Internship

Typically, the phrase "most likely defined elsewhere" refers to a function or variable that is not defined in the current scope but is anticipated to be defined in another area of the program or module. This comment in the sample code is unrelated to the integer value used in the code. The function in the code uses the Partitioned.connect function from the Partitioned module to divide a block device into three smaller blocks. The first sub-block (b1) is made up of the first 20 sectors of the block device, followed by the next 8k sectors (4 MiB), and the final space is made up of the third sub-block (b3). The rest sub-block is then further sub-partitioned into b2 and b3 using the subpartition function from the same partitioned module. Following partitioning, the code establishes connections to each sub-block using various modules, such as Tar.connect for b1 as a tar KV store and Chamelon.connect for b2 as a Chamelon filesystem. The code's goal is to get the block device and its subdivisions ready for use by various storage systems.

The observation that the connect_and_partition function, as defined in the provided code snippet, remains unused within the given code is accurate. It is probable that this particular function has been designed for utilization in other sections of the program, or alternatively, it may represent an unfinished code.
Concerning the second point, it is accurate to state that let%bind is a syntactic construct utilized for the purpose of binding Lwt.t operations within Lwt code, rather than for the definition of functions. Nonetheless, it should be noted that the code snippet presented lacks the definition of connect_and_partition as a function utilizing let%bind. Rather than its common usage, it is presently being characterized as a numerical quantity that coincidentally represents a Lwt operation, which is conjoined by let%bind to b1, b2, and b3. In order to utilize this value, it must be combined with additional Lwt operations through the use of either the >>= operator or the let%bind construct. Alternatively, it can be supplied as a parameter to a Lwt function that anticipates a Lwt operation.

@neyjay12 https://github.com/mirage/mirage/issues/1402#generative-ai

hello,
i am not using chat gpt to contribute to this project
On Wed, 29 Mar 2023 at 17:11, Reynir Björnsson @.***>
wrote:

@neyjay12 https://github.com/neyjay12 mirage/mirage#1402 (comment)
https://github.com/mirage/mirage/issues/1402#generative-ai
—
Reply to this email directly, view it on GitHub
https://github.com/reynir/mirage-block-partition/pull/10#issuecomment-1488817604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5NPLK32MSM3KK2DIR6BYXDW6RGK5ANCNFSM6AAAAAAWGS6UQE
.
You are receiving this because you were mentioned.Message ID:
@.***>

You are welcome to an honest attempt at a contribution. However, I don't appreciate the responses you give. The code is incoherent with what you describe it does, and your answer is to double down without providing any references.
My advice is to learn some OCaml and not trust these tools that output nonsense that might look convincing if you don't know much about the domain.

Hello ,
I just had a contribution on GitHub please can you check it and let me know
On 2023. Mar 30., Thu at 10:37, Reynir Björnsson @.***>
wrote:

Closed #10 https://github.com/reynir/mirage-block-partition/pull/10.
—
Reply to this email directly, view it on GitHub
https://github.com/reynir/mirage-block-partition/pull/10#event-8884734136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5NPLK6O2VCMZ535YL25V6TW6VA37ANCNFSM6AAAAAAWGS6UQE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Extending Isofit to handle multisurface classifications

This is includes changes to the code base to handle an external classification file that is mapped to specific configurations of surface models and executions varying per-pixel or per-superpixel.
The goals of the changes:

Utilize the external classification of surface configurations via apply_oe, directly in a manually configured config, and able to run both in per-pixel mode and in superpixel mode.

Remain efficient both in terms of computation time and memory requirements.

How the code does this:

The isofit config file now carries information for all surface types present within the image.

When a classification file is present, isofit.init now indexes the image by surface classification

The n-number of state-pixel-groups are run in serial, which includes steps to persist forward model, set up workers and run_per_spectra.

The statevector is still saved on a per-spectra basis, but is matched against a "full_statevector" to collapse variable spectra-statevectors to a shared image-wide statevector.

@evan-greenbrg Thanks for getting this fresh version of the multisurface classification up! This is really awesome and pushes ISOFIT to the next level. However, I'm currently testing the compatibility of your updates with existing frameworks and encounter one issue/question. For inspecting single pixels/inversions, I used to run the following code block:
from isofit.configs import configs
from isofit.core import isofit
from isofit.core.forward import ForwardModel
from isofit.inversion.inverse import Inversion

config = configs.create_new_config(
    config_file="path_to_ISOFIT_main_config")
fm = ForwardModel(config)
inv = Inversion(config, fm)
workers = isofit.Worker(config, fm, loglevel="INFO", logfile=None)
input_data = workers.io.get_components_at_index(row, col)
res = workers.iv.invert(input_data.meas, input_data.geom)

With your updates, the Worker class now requires two more positional arguments: full_statevector and total_samples. Is there an easy way to provide these? Or does it basically mean that the above code snippet is not executable anymore?

Thanks so much @unbohn for taking a look at this so quickly. Per your above comment, as currently written you are correct that the snippet is not currently executable. The Worker class requires the two missing arguments, which doesn't raise an issue when running the Worker via Isofit.run.
I don't think it would be hard at all to make the missing positional arguments optional keyed arguments. total_samples is just used for logging and can be default to 1. full_statevector we can pull from the fm class if it's not provided. Would that be a useful edit?

Yes, thanks @evan-greenbrg. That sounds like a reasonable edit. I'll test and report back if I run into other issues.


archive: support parallel decompression (pigz)

ref: https://github.com/moby/moby/pull/35697
Note that we should not parallelize compression, as it breaks determinism

@AkihiroSuda What's wrong with non-deterministic compression?

https://github.com/moby/moby/pull/30852#issuecomment-307913663

I'd prefer we track Go's implementation rather than fork.
Because compression is mostly done on the client-side, you can use whatever compression you want.


100% CPU load

Sometimes after heavy loads; one of child processes continues 100% loading and does not come back to normal load! (even if i'm not using it).

I confirm this issue. What could be workaround for this unpleasant behavior of such abnormal tasks?

My temporary dirty solution is to add next 2 lines in systemd unit:
Restart=always
RuntimeMaxSec=600

Could you get some backtraces to figure out what's going on?  This might help:
https://stackoverflow.com/a/27398062
I also have seen high CPU usage but in my case it was external clients who discovered my open proxy and were routing through it.  This is why I added HTTP BASIC authentication in #20.

@gaul, absolutely only I use my proxy: access to it is available only for local addresses.
I can reproduce a case of this bad behavior:

open a large image in a separate browser tab (3-5 MB);
close this tab without waiting for a full download.
After that, the cpu is loaded 100% until you kill the process.


just a test, ignore

just a test, ignore
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [RHDM-XYZ] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted
[ ] You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
[ ] Every commit contains Signed-off-by: Your Name<EMAIL_ADDRESS>- use git commit -s

Template tests fail

Build finished. No test results found.
Template tests fail


Multiple users

Can a single user login on multiple devices with one cert?

You should use one certificate per device.
If you insist: add the duplicate-cn directive to /etc/openvpn/server.conf.


DNS Resolution Issues

Seems like the iPXE environment is having issues resolving DNS.  Trying to chain load off of and external server, and the DNS is failing to resolve 9/10 times.  Don't see any issues outside of that environment:

I just worked around it by changing the DNS server:
iPXE> set dns <IP_ADDRESS>

Definitely seems like one of the caching nameservers in that environment is dead tho.

@derks Were you having issues in the Cloud Servers environment in a particular region?  We can go trace that down if needed.  If your testing in your own environment, DNS is just populated by whatever is in DHCP.

ORD
Sent from my iPhone

On Jan 27, 2015, at 3:33 AM, Antony Messerli<EMAIL_ADDRESS>wrote:
@derks Were you having issues in the Cloud Servers environment in a particular region? We can go trace that down if needed. If your testing in your own environment, DNS is just populated by whatever is in DHCP.
—
Reply to this email directly or view it on GitHub.

Was not able to reproduce issue, so assuming caching nameserver is working.  If not, might be a good idea to open up a support ticket.


Incorrect emit for module M with import M inside it

Two different modules with the same last name. One imports the other with an alias of that same name. The variable M in the emitted code corresponding to A.M needs to be _M.
module Z.M {
    export function bar() {
        console.log(1);
    }
}
module A.M {
    import M = Z.M;
    export function bar() {
        console.log(2);
    }
    M.bar(); // Calls the wrong function at runtime, works if you change the above import to a var
}

This is a severe breaking change because it leads to subtle behavioral bugs at runtime.

Oh sorry, I thought github closed it via analysis of the phrase "Fix issue #1503"

@JsonFreeman, apparently the issue number should immediate follow the "Fix" keyword.

Aha, thanks. That's what I was missing


#4  - Added Unit and Requisite classes.

Class to store an unit's information including its requisites using the Requisite subclass.
The class is assuming uniqueness of an unit's code (I think we're not going to deal with unit in different offering semesters/years?)
Added some printing helpers for quality of life.

This is what I had in mind! As far as different offerings are concerned, it is a bit more tricky, but I think it should be a list of items e.g [S2-Clayton,S1-Clayton].

This is what I had in mind! As far as different offerings are concerned, it is a bit more tricky, but I think it should be a list of items e.g [S2-Clayton,S1-Clayton].

@saikumarmk Hey there, I've chosen to model the Offerings as a class similar to Requisites but obviously simpler. I thought by doing so we have more flexibility with adding fetcher and helper functions if we were ever to need to do filtering on offerings :D

Thanks Len!


Detekt - More fixes

Detekt - More fixes
more fixes
Fix composable param order

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#240  👈
#239
#238
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


doc: More certificate config file path options

Can you update the public docs as well (If needed)?