Flatten md parallel ndary

Hello,
I noticed the "FIXME" in the code. I think you're right, the parallel omp for probably does not operate in the nested way. I think it will probably only parallelize the first loop.
In this code I just scan over the parallel dimensions and create a wide iteration space to run in the parallel loop. Then recover the original indices in the iter_i array using modulo arithmetic and use these to update the moving_ptr.
This improves performance for our particular problem by about 13% overall on 22 cores. The only testing I did was to run "make utest".

Thank you, this is what I had in mind. But there is 'omp_set_nested'. I also learned about this only later. Can you compare?
Other things:

Because you process all parallel dims, you can then remove the recursion and directly call md_nary
When computing dimc, just use md_select_dims(..., ~flags, ...);   (before you  cleared the flags)

Hi Martin,
Thank you for the help. I didn't know about omp_set_nested. I reverted back to the original code and set the environment variable "OMP_NESTED=TRUE" and my runtime went from 7.3 seconds on 22 cores to 68 seconds. Similar result if I do omp_set_nested(1) in the code. Also same result if I do omp_set_nested(1) before the parallel loop and omp_set_nested(0) after the parallel loop.
I made the other changes as well. I noticed also tuning the "CHUNK" varibale in optimize.c gives some speedup but it doesn't make sense to commit this.
Thank you,
Mike

We could make the chunk size configurable. But there are many other intersting possibilities for improving num/optimize.c . Are you interested in a specific application? You can send me a PM if you want to discuss this.


Two alignments from the same subread to the CCS read

Hello,
I was exploring the test dataset and the alignment before applying deepConsensus on my dataset. I noticed that m64014_181209_091052/3146438/0_11098 subread was aligned both in the forward and reverse direction to the m64014_181209_091052/3146438/ccs.
I would assume that both alignments will be used for the consensus calling by deepconsenus, which I believe should not be the case. Or does deepconsensus have an internal filter to account for double counting of the subreads for the target CCS read?
Regards,
Sangjin

m64014_181209_091052/3146438/0_11098    16
m64014_181209_091052/3146438/0_11098    2064

Actually it looks like the second alignment is a supplementary alignment (explain flags).
Due to the way we perform alignments, it is possible for subreads to align multiple times to the same CCS read (a primary alignment + supplementary alignments). We take the first alignment and discard the rest.
https://github.com/google/deepconsensus/blob/a497d555d7514f42819470e9cd28a4ea3f7b9486/deepconsensus/preprocess/merge_datasets_transforms.py#L156-L170

I find instances where the supplementary alignment occurs before the primary alignment and the deepconsensus internal filter subsequently would used the supplementary alignment instead of the primary alignment for the consensus calling.
The attached image shows that the supplementary alignment for subread m64089_200122_110840/198615/5556_21349 before the primary alignment.

Simple python script to only select primary alignments with matching ZMW before deepConsensus.

```python
import sys
import pysam
import natsort
import argparse

class BAM:
    def __init__(self, line):
        # target
        self.tname = line.reference_name
        self.tzmw = self.tname.split("/")[1]
        # query
        self.qname = line.query_name
        self.qzmw = self.qname.split("/")[1]

def parse_args(args):
    parser = argparse.ArgumentParser(
        description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter
    )
    parser.add_argument(
        "-i",
        "--input",
        type=str,
        required=True,
        help="path to input BAM file"
    )
    parser.add_argument(
        "-o",
        "--output",
        type=str,
        required=True,
        help="path to output BAM file"
    )
    args = args[1:]
    return parser.parse_args(args)

def bamfilter(infile, outfile):
    insam = pysam.AlignmentFile(infile, "rb", check_sq=False)
    outsam = pysam.AlignmentFile(outfile, "wb", template=insam)
    for line in insam:
        read = BAM(line)
        flag = line.to_string().strip().split()[1]
        if (flag == "0" or flag == "16") and read.tzmw == read.qzmw:
            outsam.write(line)
    outsam.close()
    insam.close()
    pysam.index(outfile)

def main():
    options = parse_args(sys.argv)
    bamfilter(options.input, options.output)
    sys.exit(0)

if __name__ == "__main__":
    main()

We were just looking into this, and it looks like supplying --best-n 1 to the pbmm2 align command makes it output only the primary alignment. The most important thing though is that we keep the alignment to the correct ZMW, so we are still investigating the downstream effects of changes to the alignment and filtering process.


Possibly use libssh instead of shelling out

@jeroen may be able to hook us up with an R libssh client so we don't have to shell out with system/etc., using one of https://www.libssh2.org/ or https://www.libssh.org/
We do a variety of operations in analogsea, all funneling into this https://github.com/sckott/analogsea/blob/db3c0ec407ea0c7a7cf1112d58de3fdbaa19b2e1/R/droplet-ssh.R#L164 system() call.
For all system calls, we first do two things:

check if users have ssh and scp installed with this https://github.com/sckott/analogsea/blob/db3c0ec407ea0c7a7cf1112d58de3fdbaa19b2e1/R/zzz.R#L25-L31 (essentially Sys.which)
check if port 22 is open or not with https://github.com/sckott/analogsea/blob/db3c0ec407ea0c7a7cf1112d58de3fdbaa19b2e1/R/droplet-ssh.R#L160-L162 (if not stop with message)

The different use cases include (all sent to the remote droplet):

update the remote droplet e.g, sending apt-get update
remove libs e.g., sending apt-get autoremove -y
install R itself, e.g.  apt-get install r-base-core r-base-dev --yes --force-yes
upload files with scp, see  https://github.com/sckott/analogsea/blob/db3c0ec407ea0c7a7cf1112d58de3fdbaa19b2e1/R/droplet-ssh.R#L70-L77
download files with scp, see https://github.com/sckott/analogsea/blob/db3c0ec407ea0c7a7cf1112d58de3fdbaa19b2e1/R/droplet-ssh.R#L84-L137
running docker commands - if a user has docker installed on their remote droplet, there's a suite of functions in analogsea for running docker commands, see https://github.com/sckott/analogsea/blob/db3c0ec407ea0c7a7cf1112d58de3fdbaa19b2e1/R/docklet.R

How do users typically authenticate? Do you assume they have their key in the right place and all?

We strongly recommend that users use ssh keys - and assume they have them in the right place. i guess it'd be nice to fail well with useful message if key not in right place

The problem is that because ssh is not native to windows, there is no right place. So we'll have to make something in R to let the user provide a keyfile or password.

okay, makes sense

@jeroen a question for you on scp_download  - to try, insall devtools::install_github("sckott/analogsea@ssh")
library(analogsea)
d <- droplet_create() %>% droplet_wait()

uploading works great
tmp <- tempfile()
saveRDS(mtcars, tmp)
d %>% droplet_upload(tmp, "mtcars2.rds")
#> [100%] /private/var/folders/fc/n7g_vrvn0sx_st0p8lxb3ts40000gn/T/Rtmpg8C0Ru/file10cda7b26f4c3
#> mtcars2.rds

But when I download, the behavior isn't what I would expect, where mtcars2.rds ends up being a directory, under which the file actual file exists as file10cda7b26f4c3
(tmp2 <- tempdir())
#> [1] "/var/folders/fc/n7g_vrvn0sx_st0p8lxb3ts40000gn/T//Rtmpg8C0Ru"
d %>% droplet_download("mtcars2.rds", tmp2)
#>          0 /var/folders/fc/n7g_vrvn0sx_st0p8lxb3ts40000gn/T//Rtmpg8C0Ru/mtcars2.rds
#>       1218 /var/folders/fc/n7g_vrvn0sx_st0p8lxb3ts40000gn/T//Rtmpg8C0Ru/mtcars2.rds/file107b067ff446c
#>       1218 /var/folders/fc/n7g_vrvn0sx_st0p8lxb3ts40000gn/T//Rtmpg8C0Ru/mtcars2.rds/file10cda7b26f4c3

Then reading fails
mtcars2 <- readRDS(tmp2)
#> Error in readRDS(tmp2) : error reading from connection
#> In addition: Warning message:
#> In readRDS(tmp2) : error reading the file

Hmm that's a bug.

I think you are passing "mtcars2.rds" to the to parameter, which indicates a directory on the server where you want to download into. The directory will be created if it does not exist.
Just upload to "." to copy the file to the working directory.

okay, i think it makes sense now

@amoeba @thercast @trestletech @studerus @nicksmithr @berkorbay
Thanks to @jeroen pkg ssh we have a new and better way to ssh to droplets. If you have time can you try out a dev version with
devtools::install_github("sckott/analogsea@ssh")
or switch to that branch, etc.
changes so far in droplet_ssh, see examples there.
see changes here (master vs. ssh branches): https://github.com/sckott/analogsea/compare/master...ssh?w=1
Let me know of any problems encountered

Cool! Just tested it out and it works great!

great, thanks @amoeba

@sckott Thank you very much for implementing this!   I ran a quick test and found a minor problem.  I always use ssh keys from my local machines to connect to my droplets, but it appears that the droplet_ssh() does not allow for extra parameters to be supplied and passed on to the ssh::ssh_connect()(see line 110) .  Here's a minimal example:
d <- droplet_create(region = "nyc3")
droplet_ssh(d, "ls")
#Error: libssh failure at 'connect': Failed to resolve hostname droplet likely not up yet (Temporary failure in name resolution)
#In addition: Warning message:
#In x$network : partial match of 'network' to 'networks'

# suppose IP is 555.555.5.555
library(ssh)

# this works
ssh_connect(host =<EMAIL_ADDRESS>keyfile = "~/.ssh/id_rsa_digitalocean")

It seems the easiest approach would be to add a keyfile parameter (with default NULL) to the droplet_ssh() arguments and simply pass that along to ssh_connect().  I'll give that a go and if it works without hassle I'll send a PR.

thanks @thercast looking at the PR


clean up the zuul files

See: https://github.com/ansible/ansible-zuul-jobs/pull/1398

recheck

recheck


Create search_orders.py

Thank you for contributing to the Cohere Toolkit!

[ ] PR title: "area: description"

Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..."  for CI changes.
Example: "deployment: add Azure model option"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change

[ ] Add tests and docs: Please include testing and documentation for your changes

[ ] Lint and test: Run make lint and make run-tests

AI Description

This PR introduces a new class, SearchPendingOrders, which extends the BaseTool class. The purpose of this class is to search the order management database for customers with pending verification.
The SearchPendingOrders class includes the following key components:

A class attribute, NAME, set to "search_pending_orders".
A class method, is_available, which returns a boolean value indicating whether the tool is available.
An asynchronous method, call, which takes in parameters, context, and keyword arguments. This method performs the following steps:

Retrieves the 'status' parameter from the request.
Creates a mock database containing customer information, including customer name, email, and status.
Filters the mock database to include only orders with the specified status.
Iterates through the filtered orders, extracting customer and email information.
Constructs a result dictionary with a key, "customers_with_pending_verification", containing a list of customer information dictionaries.
Returns a list containing the result dictionary.

Please ignore/delete this, I did this by mistake

Codecov Report
Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (ca5ab66) to head (fce5678).

Files with missing lines
Patch %
Lines

src/backend/tools/search_orders.py
0.00%
18 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
- Coverage   75.23%   75.11%   -0.12%
==========================================
  Files         265      266       +1
  Lines       11862    11880      +18
==========================================
  Hits         8924     8924
- Misses       2938     2956      +18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error: Actions may not have an undefined "type" property. When using @ngrx/effects.

Hi, I am getting the following error when I dispatch an action that triggers an effect via @ngrx/effects
Actions may not have an undefined "type" property. Have you misspelled a constant?

The issue can be reproduced by cloning this repo. It happens only when the Chrome extension is installed.
Browser: Google Chrome v57.0.2987.133 (64-bit)
OS: Linux Mint 17.2 Rafaela (64-bit)
NPM: v4.1.2
NodeJs: v7.4.0

This effect is causing you dispatch items that are not actions: https://github.com/damnko/angular2-ngrx-store/blob/master/src/app/effects/index.ts#L10
Update your effect decorator to prevent dispatching if the effect's intention is not to cause new actions to enter the stream:
@Effect({ dispatch: false })

Wow thanks a lot for your help. That was fast and super helpful.


Missing Security Group Rule

Description
Ran into an issue over the last few days where a security group rule was removed and caused intermittent connectivity issues depending on where the pods existed. Just wondering why this didn't trigger anything when running terraform. I don't see any audit trails at the moment of the group/rule being deleted or modified. This is more of a general question than an ongoing bug. If it happens again or if i can reproduce it I'll capture and document what i can.
⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Terraform:

Provider(s):

Module:

Reproduction
Unable to reproduce and all our other clusters seem to be working appropriately
Code Snippet to Reproduce
N/A
Expected behavior
On security rule change/deletion/modification should trigger terraform to add/change the group
Actual behavior
Completes without incident and makes it appear as it's in a healthy state
Terminal Output Screenshot(s)
Additional context

please provide details to this issue

Wait, the issue is that one of our clusters that takes advantage of spot instances are joining different security groups not just the primary one that's configured.


Callback function of tokenizeCard it's not called

I been integrating Braintree with my application and I found a problem. I need to use the method tokenizeCard but it seems the callback it's not called and I don't understand why.
function buyNow() {
	var token = getSessionVarFromView('client_token_braintree');
	console.error(token);
    var client = new braintree.api.Client({clientToken: token});
    client.tokenizeCard({number: "4111111111111111", expirationDate: "10/20"}, function (err, nonce) {
	    console.error("On tokenize card");
	});
}

The method buyNow it's called after the user presses buy. The method to generate my client token in the server is:
Braintree_Configuration::environment('sandbox');
Braintree_Configuration::merchantId('merchantId');
Braintree_Configuration::publicKey('publicKey');
Braintree_Configuration::privateKey('privateKey');

$clientToken = Braintree_ClientToken::generate();
return $clientToken;

After this, the callback function of tokenizeCard never gets called.
I hope you can help me
Thank you

@OscarRPR it looks like you got an answer on StackOverflow from a Braintree developer. I am going to close this, but let me know if you run into anything else.


run full validation when github workflows change

To make sure that changes to the validation task really run all tests.

Merging so we can test #113 properly.


Alamofire 5 URLError

I'm using Alamofire 5.0.0-rc.3.
In 5.0.0-beta.6 it was ok.
Example:
Before Alamofire returned the Error that i could cast to URLError. And then check if it URLError.Code.notConnectedToInternet or not.
Now Alamofire returns an Error as NSError. That looks like "Error Domain=Alamofire.AFError Code=13 "URLSessionTask failed with error: Not Connected to the internet.""
Why and how to cast it as URLError?

Now Alamofire handle any error and wrap it. Found URLError in:
if let afError = error.asAFError {
            switch afError {
            case .sessionTaskFailed(let sessionError):
                if let urlError = sessionError as? URLError {

This is not a good change, given our architecture. We have a domain layer that does not know anything about AF, where we check for raw error characteristics, much like the disconnect you mention above. The new AF structure means that we can't have this logic in domain, since it must also take AF errors into consideration.

It is ridiculous :(

In version 5.6.1 you can actually do it using:
error.asAFError?.underlyingError
and of course you can cast it to NSError if you need:
error.asAFError?.underlyingError as? NSError


Adding note about function based constrained types.

I have added this note as a stop-gap until #2953  #2875 #2473 are resolved.

Change Summary
updated docs to address current issues with hypothesis plugin

I added 6-10 lines of text to the hypothesis plugin page.  These lines of text describe what users should expect when
using the hypothesis plugin with function-based contstrained value types.
Related issue number
#2953  #2875 #2473

Negative
Checklist

[ x ] Unit tests for the changes exist
[x ] Tests pass on CI and coverage remains at 100%
[X ] Documentation reflects the changes where applicable
[X ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[X ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

I can't commit to this and needed to make some edits, so replaced by #4323.


Buttons, Links, Form elements should have accessible names

Describe your problem(s)

Buttons, Links, Form elements should have accessible names
Describe your solution
G211 - Labels for inputs should have for attribute
Helper text for inputs should be linked through aria-describedby attribute
@@ If an icon has no accompanying text, consider using its hover text as its accessible name

Currently on-hold. we consider this once theres any requirement.


Change of the color of navbar's element on hover

Describe the bug
Want to change the color of the navbar because on directing to sign in/sign up page it is not clear
Screenshort

I would like to work on this issue please assign this to under gssoc'23

Want to change the color of the navbar because on directing to sign in/sign up page it is not clear
Also I would like to solve this Assign me under GSSoC'23

Would like to work on this issue , Can simply change write a CSS to change the color of navbar on hover

Yes

@Kapileswar-Moharana Can you please provide me the link of this web page or the link in github from where I can change the code.

I don't understand actually should I contribute or give the code to you. I think you are not the PA of this project, As you can see I messaged here for you to assign me under this issue I will solve this.

Okay I thought You raised this issue  ;)

Heyy @lakshmiprasannakusumanchi can you change the background of sign up page to make it changeable according to the theme just like in sign in page?


Add blender to base image to enable seamless FBX import from .blend project files

Changes

Adds blender to gameci image, to enable auto FBX import from .blend files (unity docs).

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)

Hey @aallbrig,
Thanks for your contribution. We have discussed making this change before and decided against it.
Why?
We need to make our images suitable for everyone. Adding 250 MB on top of the already large image size would not be preferable for teams that do not use blender.
Now of course you could argue that most people use Blender, which is a fair point to make. However the same point applies for the other file formats that Unity Editor supports.
Different teams would need different combinations of tools installed, and the amount of tools really isn't limited to file types. SonarQube and other quality tools come to mind.
Solutions
Therefor we've decided to offer the user 3 different options:

Extending our image by adding blender on top of it. (especially recommended for teams that are large enough to be able to maintain a docker image for their project)
A plugin system inside unity-builder (not yet available) - a system where a combination of different tools can be installed during CI time.
Forking unity-builder and editing the entrypoint.sh to (partially) simulate what the plugin system would do: install the tools you need during CI time.

Conclusion
Contributions are always welcomed - as long as they work for everyone.
In this case unfortunately it would not, so this PR unfortunately will not be merged.
I hope the above solutions will help you move forward.

Since this has only been discussed in a few issues (I rememeber some older discussions on gitlab) or discord, it could be useful to add a section in the documentation on how to precisely customize images for different file support.
We had an idea of adding some overhead during the pipeline runs to inject (install) blender on each build, providing some kind of supported plugins but until we have support for this (if we accept to go that way), I think including an easy to follow guide in the documentation could be helpful for many.
Right now, all we have is this:
https://game.ci/docs/docker/customize-docker-images
It is helpful, but I think it can be improved. Just another idea on top of this, we could use the power of mdx (react in markdown files) to allow people to pick their unity version, the tool they want and generate some ready to use scripts to publish what they need.
Example: A react component that generates a script from a form

dropdown: unity version
checkboxes: the tools (file formats) you need (blender, etc)
dropdown: GameCI version (feeding from docker releases list, auto picking the latest
input text: docker username

result: a shell script that eases building and publishing customized docker images to docker hub.
Now this should be discussed and accepted in an issue before it gets developed to avoid wasting precious developer time 🙏

Nice idea. Added it to https://github.com/game-ci/documentation/issues/286

I've added this to the Roadmap for v3.0.0

The plugin part will be solved as part of https://github.com/game-ci/unity-builder/issues/407

I appreciate it!!!

I solved this in my "virtual arcade bar" micro project. Here are the commits

Customize game-ci Dockerfile with blender 5939206bf123a1bf790f5b09570e017385c19ca1 (thanks NY times!)
Add in a .blend file to my project 7985db80b2d88e81c0732fd213e596d912e21941
Update my game-ci Github Actions yaml 269d368198c82b60d2df130fd99061f89b568a04

My build succeeded!

Great! Thank you very much for sharing your solution with the community.
I'm curious, did this somehow end up solving your shader/lighting difference between local and CI?

@webbertakken Unfortunately, no not yet.


[docsy] Work around inline-style CSP restriction

Originally posted by @chalin in https://github.com/theupdateframework/theupdateframework.io/issues/68#issuecomment-2330339880

Is there a reasonable workaround? Why do we need this? It's a bad look for a security project to disable security controls, even if they don't matter in this case.

Ok, I'll propose a workaround in a followup PR. Thanks for the feedback @JustinCappos.

Fixed by #75


Update crossterm to v0.10

Looks like some changes in crossterm 0.10 broke the trick to open both /dev/tty and /dev/stdin. I filed a bug (https://github.com/TimonPost/crossterm/issues/188), but this is probably pretty far from being supported behavior. I'll need to find some time to dig into this further.
Will hold off on merging until I can figure out a workaround. As is this breaks a big chunk of functionality.

supposedly this is fixed in recent versions of crossterm, so I'll try to revisit it soon


Get Rules, just not as get rule, but rather as function to styles

With this function you can retrieve the styles that have been set by set rules. Would resolve #763
#set page(margin: 5mm)

A: #style(x=>x.get(page).width))

B: #style(x=>x.get(page).columns))

C: #style(x=>x.get(page).margin))

D: #style(x=>x.get(page).margin.top))

Without analyzing the implementation at first, I wonder if some syntax like
#styles.get(page).margin
would be more appropriate than .get(page, "margin")?
(.get would thus return some sort of "proxy object" whose only function would be to return, through fields, the currently set values for each field.)

I would like this, but as far as i see, there are no proxy objects like this to the time? Right now, all methods are resolved in methods.rs using match statements.
But I'll have a look

@PgBiel What do you think of that?

I actually had an idea for this which goes in a bit different direction syntactically, which I wanted to explore in a blog post together with some other things. I think it makes more sense to explain it in context with the other things, so I will post a link here once it's published.

I hope we do not have to wait too long for this feature ... and the blog post...

I hope we do not have to wait too long for this feature ... and the blog post...

In my opinion, it is better to make slow and steady progress instead of getting things out quickly at the cost of having to change them later. Even if we end up going with the exact design in this PR instead of what I'm thinking of, it will be good to have explored the design space further.

I don't want to push my Design by force, please don't misunderstand me; I just like to put some priority on this problem...

I actually had an idea for this which goes in a bit different direction, which I wanted to explore in a blog post together with some other things. I think it makes more sense to explain it in context with the other things, so I will post a link here once it's published.

We'll be on the wait!

In my opinion, it is better to make slow and steady progress instead of getting things out quickly at the cost of having to change them later. Even if we end up going with the exact design in this PR instead of what I'm thinking of, it will be good to have explored the design space further.

Fully agree. This is a pretty fundamental matter in terms of the overall language's functioning, so let's tread carefully here.

I posted my ideas here: https://laurmaedje.github.io/posts/types-and-context/

I will happily step back from my get rule implementation when you realize what you proposed in the blog. I've just read it once; but i like it.

While the context work is still some ways out, I think it's best to close this. Although the feature is desired, merging this as a stop-gap will likely lead to much breakage down the road.

no objections... cannot wait to test context + types when getting ready...


[NSE-955] Support md5/sha1/sha2 functions

This patch depends on https://github.com/oap-project/arrow/pull/135.

By manually running the modified run_ut.sh, it shows there is no new UT failure.

Tests total: 7537, Succeed Total: 7428, Known Fails: 119, Actual Fails: 109.
No newly failed tests found!
Unit tests succeeded!


Update Client::try_default documentation

For #823

Codecov Report

Merging #825 (8dc58ed) into master (8b5cb03) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   69.94%   69.94%
=======================================
  Files          58       58
  Lines        3983     3983
=======================================
  Hits         2786     2786
  Misses       1197     1197

Impacted Files
Coverage Δ

kube-client/src/client/mod.rs
70.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5cb03...8dc58ed. Read the comment docs.


Allow user to rename any address

A screenshot of the addressbook entry after renaming it would help visualize as well.
I would ask @MicahZoltu for opinion on this as to the implication he might see on security standpoint before merging

A screenshot of the addressbook entry after renaming it would help visualize as well. I would ask @MicahZoltu for opinion on this as to the implication he might see on security standpoint before merging

there's no addressbook entries for them at the moment visible anymore, so no screenshots available :). That's still work to be done


Additional canonicalization added for AddNode

The PR has 2 issue fix:
1: 2 + x was always operated as x + 2. It hides certain match condition.
2: Canonicalize (c1 - y) + x --> (x - y) + c1
cc @yzhliu , @zhiics , @tqchen

thanks @ANSHUMAN87


(not merging) JSX "failed" breadcrumb resize exploration

I wasn't successful in my explorations with JSX, mainly how could I, during the rendering loop, known that there is too many element or alternatively, if there would be enough space for an additional element. We basically have to render everything every time:

the breadcrumbs change from headless
the element is resized
Then we have to adapt once the elements are rendered, which will often cause a re-render, showing a warning in the console and we visually get a glitch every time we resize along with lagging because of the bad performance.

Merged the previous PR instead

how could I, during the rendering loop, known that there is too many element

I see, that's a good point! I guess we need to render everything for the browser to calculate the widths and heights for us.

Good to know!


Don't try to compile examples if they have #![ cfg(not( target_arch = "wasm32" )) ]

🐛 Bug description
When supporting both wasm and other targets in a crate, I found it not obvious how to deal with tests and examples. It turned out that adding #![ cfg(not( target_arch = "wasm32" )) ] to files for integration tests that aren't wasm keeps wasm-pack test from trying to run them.
However, when you have an example in the examples folder that isn't wasm, wasm-pack test will still try to compile it, and even when putting a target based gate at the top. The result is that #![ cfg(not( target_arch = "wasm32" )) ] on top of the file will break tests because:
error[E0601]: `main` function not found in crate `localpool`

I haven't found a reasonable workaround...
🤔 Expected Behavior
Have a convenient way of supporting both wasm and non wasm targets in the same crate.
Document how to deal with tests and examples in this regard (in the book)
👟 Steps to reproduce
Create an example in examples folder that isn't meant for wasm target. Run unit tests with wasm-pack test
🌍 Your environment
linux
wasm-pack version: wasm-pack 0.7.0
rustc version: rustc 1.37.0-nightly (02564de47 2019-06-10)

Ok, the workaround I found is to put a gate on every single command that is toplevel and to add a dummy main at the bottom:
#[ cfg( target_arch = "wasm32" ) ]
//
fn main(){}

It's pretty ugly, especially for examples which are a form of documentation.

I have since filed an issue with cargo, as I think cargo test should not consider these examples on the wrong target. https://github.com/rust-lang/cargo/issues/7233


More assetions for tx history and decoded tx in e2e tests

[x] fix stopping node task (4dd5a1ec6fe64e6d04a51eba90e905fe0206f2ab)
[x] add more assertions for e2e tests in construct->sign->submit flow (63fe47af3461b1be4b89e9ada7efb51c956bb3de)

Comments

Issue Number
relates to ADP-2254

Looks good to me, thanks! 😊


[5.5] Add the queue:once command

I find myself answering a common question on StackOverflow, Slack etc around the difference between queue commands for people new to Laravel.
Currently we have 3 options:
queue:work - process queue jobs as a daemon
queue:work --once - process a single job on the queue
queue:listen - process queue jobs as a loop (i.e. boot the framework each time)
I think it makes more sense to alias out the once to its own command - that way you can say:
queue:work - process queue jobs as a daemon
queue:listen - process queue jobs as a loop (i.e. boot the framework each time)
queue:once - process a single job on the queue
This PR leaves the --once flag on the work command for those that want it. It is just adding an alias.

I don't see the problem with just queue:work --once

TIL queue:once. Nice


Hello

Hello.
Nice to meet you
I saw your post in Discord channel.
I just tell you I have experience with crawler, scrapy and Selenium and join your team.


Using element(by.xpath) and js scrollIntoView-> is causing FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory

Using element(by.xpath) and js scrollIntoView-> is causing FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory
E.g:-
var el=element(by.xpath("//tcc-banner//div[@class='banner-right']//div[text()='NEW QORDERI2 CASE']"));

this.scrollAndClick = function(element) {
		browser.executeScript(arguments[0].scrollIntoView(), element);
		element.click();
	};

so calling:-
**scrollAndClick(el);**
If I use browser.findElement(by.xpath()); it works.
Exceptions:-
Started
<--- Last few GCs --->
113789 ms: Mark-sweep 1325.3 (1456.9) -> 1329.5 (1456.9) MB, 3702.4 / 0 ms [allocation failure] [GC in old space requested].
117537 ms: Mark-sweep 1329.5 (1456.9) -> 1329.5 (1456.9) MB, 3747.9 / 0 ms [allocation failure] [GC in old space requested].
121527 ms: Mark-sweep 1329.5 (1456.9) -> 1325.3 (1456.9) MB, 3988.4 / 0 ms [last resort gc].
125012 ms: Mark-sweep 1325.3 (1456.9) -> 1325.3 (1456.9) MB, 3484.2 / 0 ms [last resort gc].
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 000001E8ABBB4639
3: addCallback_ [C:\Users\pkajale\AppData\Roaming\npm\node_modules\protractor\node_modules\selenium-webdriver\lib\promise.js:~1278] [pc=000000293803D99B] (this=0000008E6D24F199 <a Promise with map 0000003BDF2C5CF1>,callback=0000031C0CEF2CE1 <JS Function toWireValue (SharedFunctionInfo 00000235E9E55919)>,errback=000001E8ABB041B9 ,name=000001E8ABB671F9 <String[4]: then>,fn=000002...
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory.
This was working till last week. Not sure what changed causing this to fail.

This seems like it is probably related to https://github.com/angular/protractor/issues/3442. I'm going to go ahead and close this. If you feel that it is a distinct issue, please create a new issue that follows the  Issue Template and gives us enough information to differentiate it. Thanks! 😄


utf-8 on windows

Hi,
Jekyll on windows breaks. This has been tracked to pygments > 0.5.0 breaking, see here https://github.com/mojombo/jekyll/pull/1487#issuecomment-27040718
Any ideas or updates to this, since building github pages on windows is probably something many people want to do, and utf-8 (at least for me) has pretty much become standard as far as generating internationalized files go (actually i just utf-8 EVERYTHING ..html, js, txt, css).
Thanks,
Robert

Unfortunately, Jekyll dropped pygments.rb support: https://github.com/jekyll/jekyll/issues/6823

Unfortunately, Jekyll dropped pygments.rb support: https://github.com/jekyll/jekyll/issues/6823


[toolbox] Make "toolbox" lowercase

11:40 AM <creesch> Wait is it upper or lowercase toolbox?
11:40 AM <agentlame> It's lowercaes. Just like reddit.  I'm calling it.
11:40 AM <creesch> FINE
11:41 AM <agentlame> Last one is upper. Thd rest are fine.
11:41 AM <creesch> but in our logo (which we are not allowed to use anymore) it is T
11:41 AM <creesch> I should 'design' a new logo
11:41 AM <agentlame> Well... two birds.
11:41 AM <creesch> ok lowercase
11:41 AM <psdtwk> .8ball is it "toolbox"?
11:41 AM — gonzobot shakes the magic 8 ball... Reply hazy, try again
11:41 AM <agentlame> Exactly!
11:41 AM <psdtwk> Gah!
11:41 AM <creesch> .8ball is it "Toolbox"?
11:41 AM — gonzobot shakes the magic 8 ball... My sources say no
11:41 AM <creesch> ok
11:41 AM <creesch> clear
11:41 AM <psdtwk> There we have it.

Note: please do not close this issue until /r/toolbox and all wiki documentation is also corrected.

I updated /r/toolbox/wiki and subreddit settings to lower case instead of random case. /livedocs is not updated.


HPUAccelerator: remove support in set_visible_devices_envs

The way deepspeed sets it is not correct with all HPU instances and may lead to incorrect behavior.

Hi @nelyahu in the link https://docs.habana.ai/en/latest/PyTorch/Reference/PT_Multiple_Tenants_on_HPU/Multiple_Workloads_Single_Docker.html specificed in the code.  It mentioned HABANA_VISIBLE_MODULES is used for multi-tenant on HPU, how does this usage conflict with set_visible_devices_envs() in DeepSpeed?  Thanks!

@delock on Intel Gaudi accelerator (HPU), the visible module ids are determines by the hl-smi -L  command, it does not always 0,1,2,3,4,5,6,7 and specially when running multiple VMs on the same server each VM can get different module
For example, the case of 2 VMs
VM#1 can get module ids 1,4,5,2
VM#2 can get 7,0,3,6

Hi @nelyahu From the title and description this PR intends to avoid set_visible_devices_envs on this line: https://github.com/microsoft/DeepSpeed/blob/ffe0af23575c4f03a07408eacfc50b1a58781429/deepspeed/launcher/launch.py#L166
This PR also nullify this line which does not set_visible_devices_envs, is it also intended?
https://github.com/microsoft/DeepSpeed/blob/ffe0af23575c4f03a07408eacfc50b1a58781429/deepspeed/launcher/runner.py#L408

@delock on Intel Gaudi accelerator (HPU), the visible module ids are determines by the hl-smi -L  command, it does not always 0,1,2,3,4,5,6,7 and specially when running multiple VMs on the same server each VM can get different module For example, the case of 2 VMs VM#1 can get module ids 1,4,5,2 VM#2 can get 7,0,3,6

Hi @nelyahu, the latest push added cosmetic change from other 8 files which is unrelated.

Hi @nelyahu, the latest push added cosmetic change from other 8 files which is unrelated.

Yes, formatter version issue. fixed


I want to be able number my rows in the dataTable, not using my table id column as the numbering row.

as Seen here My numbering is coming from the database which some deleted Id is not showing, I want to make the rows numbering from my datatable class or a better approach

@wuwx @ligne13 @donnykurnia @yajra

@toyintheisaac like this? https://datatables.net/examples/api/counter_columns.html

You can also use addIndexColumn API for the server-side counter.


Enable/disable vdc

What this PR resolves:
#86: enable/disable vdc + tests/docs

Requires Jumpscale/lib9#46


cant get it to work

I downloaded your mod on thunderstore and dispite many attempts to get it working i have had no luck. With the setting "vanilla only" true or false it still only shows base game green screen backgrounds. Here is an image of how i have the backgrounds txt file maybe im doing something wrong but i cant get any custom image to appear in game.

Can + to this; launched the game and it didn't make the backgrounds config so I had to make one myself. I have a png and a jpg and it doesn't seem to be showing either. Using r2modman. Not even the fallback png I can find anywhere else

Is there any errors in logs?

is it something we can fix or something you have to update to fix

Send me your logs, because I really don't know what went wrong. My previous post is just a theory

sure i can do that here in a min what logs would you need ill also send any images of errors in the console if there is any

The main BepInEx log file is BepInEx/LogOutput.txt

The main BepInEx log file is BepInEx/LogOutput.txt

i have LogOutput.log but its a day old. I did just launch the game and there was a few errors related to your mod i will send the pictures of the errors in console.

nice what about the first any luck?

Seems to be fixed in 1.0.4

sure i can right now

Is Keep vanilla enabled?

no i will enable it and test that

one question tho any way you could get a .gif to work?

Seems to be fixed in 1.0.4 Upd: please, check is it works for you

Works now, thanks!


Cleaned up phrasing.

Changed "You are able to have customers to own"
to
"You allow customers to own"

@jdvcDev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks.


MOBILE-1489 resource: Download progress indication

MOBILE-1489 resource: Download progress indication
This solves issue MOBILE-1489.

Hello,
thanks for working on this, I've submitted it for peer-review via the https://tracker.moodle.org/browse/MOBILE-1489 issue.
You should subscribe (watch) this issue in the tracker to get further notifications


CarlaUE4 crashed when import .fbx with RoadRunner Plugin enabled

1, I followed documentation and export Carla format by RoadRunner.

2，Installed RoadRunner Plugin and enable it

3，Imported .fbx file, and it is auto detected by plugin.

4, Checked every combo box carefully with the guide and clicked import, waiting a minute, then it CRASHED:

I doubt it attributes to the data, and tried another one (Town01.xodr under carla folder itself). It crashed again in the same way.
I used Unreal Engine without any plugins to import .fbx, it appears normal.
Could anyone tell me what's wrong with it? Thanks.

I think RoadRunner Plugin is not necessary for import map, you can directly import the fbx file.

I think RoadRunner Plugin is not necessary for import map, you can directly import the fbx file.

Thank you for reply.
I have figured out this problem is not concerned with RoadRunner plugin. It occurred when click 'generate road network' check box on 'OpenDrive Actor' detail tab on the right side.
So, RR plugin is just automatically clicked it when import fbx file and crashed. Have you ever met with this? Is this situation caused by invalid built or data?

Solved..
The xodr file should not have any spiral geometries inside, or crash above might occur.

Hi,
I am facing the same issue. The UE editor shows import process when I select .fbx file and then it got crashed. I don't understand how did you resolve this.
and what do you mean by this-" It occurred when click 'generate routes' check box on 'OpenDrive Actor' detail tab on the right side."
Thanks in advance.


Redo documentation

Entire revamp of the documentation as explained in the linked issue.
Rendered
Closes #45

Updated, hope I didn't miss anything


Error 101: The database does not exist in the collection or the user does not have administrator rights to access it

Describe the problem
Error 101: The database does not exist in the collection or the user does not have administrator rights to access it.
5e92b217-e327-45bf-9c1a-00e558e5988d
Bravo version
1.0.2-internal-20230426.1-1.0.8516.20116-main-62dd8548b76b863b9a28e0fee61032c11d89d921 (1.0.8516.20116)
Tabular model
Power BI Dataset
Power BI
Power BI Online PPU
Steps to reproduce the behavior
No response
Additional context
No response
Screenshots
No response
Anything else ?
Trace Id: 00-495209d76b91bde84288461e025a2569-b74920e59f9318b0-00

Hi @Infrecon, the error message indicates that your account does not have administrator rights to access the dataset.
What is the role assigned to your user account for this workspace? Admin/Contributor/Member/Viewer ?
https://learn.microsoft.com/en-us/power-bi/collaborate-share/service-roles-new-workspaces

Admin

Von: Alberto Spelta @.***>
Gesendet: Freitag, 5. Mai 2023 11:42
An: sql-bi/Bravo
Cc: Infrecon; Mention
Betreff: Re: [sql-bi/Bravo] Error 101: The database does not exist in the collection or the user does not have administrator rights to access it (Issue #646)
Hi @Infrecon, the error message indicates that your account does not have administrator rights to access the dataset.
What is the role assigned to your user account for this workspace? Admin/Contributor/Member/Viewer ?
https://learn.microsoft.com/en-us/power-bi/collaborate-share/service-roles-new-workspaces
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@Infrecon Is the dataset configured in import mode or is it connected to an external data source such as Azure AS or an on-prem SSAS instance through a PBI Gateway connection?
We have released a new internal version (1.0.8526.37347) that adds more diagnostic information for this error. After enabling the verbose diagnostics in Bravo settings, the message [HOST] TabularConnectionWrapper.ctor should be visible in the log panel. This message displays the list of datasets with their ID and name.
Would you mind letting me know if your dataset ID (which from the error message should be 5e92b217-e327-45bf-9c1a-00e558e5988d) is in this list?


Collection view in repos do not respect safe area

Bug Report Dump (Auto-generated)

Version 1.27.1<PHONE_NUMBER>)
Device: iPhone X (iOS 12.1.2)
TestFlight: true

I can take a look at this.

is this still an issue? i could help :)

is this still an issue? i could help :)

Only managed to get time to look at this now and looking at it now. I'll let you know if I have any issues. Thanks!

@BasThomas - How did you get the UITabBar to disappear?
I've gone to the exact repo from the screenshot - via search and from bookmarks. The UITabBar remains in place; even whilst scrolling.
With the UITabBar on screen; this issue isn't reproducible.

If you open it from Notifications, the tab bar is not present.

If you open it from Notifications, the tab bar is not present.

Thanks, will check it out

And from the navigation bar in an issue 😊
Sent with GitHawk

Ah yeah, only from the navbar in an issue. I wonder — should this just be worked around by always showing the tab bar?

And from the navigation bar in an issue 😊
Sent with GitHawk

Thanks, able top reproduce it easily enough now. I'll have a fix soon when I get home this evening.

Ah yeah, only from the navbar in an issue. I wonder — should this just be worked around by always showing the tab bar?

@j-f1 not sure, but I feel that should / can be tackled separately.
Sent with GitHawk

⏩ #2666

Just taking a quick look at this one in the RepositoryViewController, seems like is an issue with the XLPagerTabStrip dependency. Here https://github.com/xmartlabs/XLPagerTabStrip/issues/722


✨[feature Request]: Adding a review / testimonial section or page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
we can create on section or page for reviews
Use Case
It could let other user know about the website more and how others are enjoying it
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@1ShahidBashir give preview imag eof ur feature,.

@Anjaliavv51 would take a day but sure I can give a preview


Unable to find katari package

Describe the bug
When running build-app flag traceback appears
To Reproduce
Steps to reproduce the behavior:
katari --build-app Test
Expected behavior
expected to build app
Screenshots

fixed indentation


Commands: fix ;time and ;purchase

Alright, time is finally refactored! No more if statement hell, and I'd like to think it looks cleaner. It outputs the same thing, though, don't worry.
I also fixed a goofup with ;purchase. In the shop, it says ;buy public greeting, but 'publicgreeting' couldn't actually be purchased because I left it as 'privategreeting'. That should be fixed too.

By the way, ;time now uses GMT over UTC since it's a little more accurate for users living in other parts of the world (should they choose to fork this). If you want this changed back, I can fix it.

Oh my lord, I'm so sorry for all of these commits. ._.

Thankies. c: Time has needed a patch for a while now.


mount with the subdirectory as the name of the secret, not the cluster

part of: https://github.com/kiali/kiali/issues/5767

We want the subdirectory name to be the name of the secret (that's how kiali will know what secret the cluster info came from - useful when logging/debugging - the user will want to know what secret a particular cluster data came from).
So if you do this as a test, you should see the mount path to have the name of the secret in it, not the name of the cluster:
$ istioctl x create-remote-secret --name mazz-cluster --context ci --namespace istio-system | kubectl apply -f -
$ istioctl x create-remote-secret --name mazz2-cluster --context ci --namespace istio-system | kubectl apply -f -
$ make build-helm-charts
$ helm install --debug --namespace istio-system --set kiali_feature_flags.clustering.clusters[0].name=foo --set kiali_feature_flags.clustering.clusters[0].secret_name=foosecret  kiali-server _output/charts/kiali-server*.tgz

should result in volume mounts as:
        - name: mazz-cluster
          mountPath: "/kiali-remote-cluster-secrets/istio-remote-secret-mazz-cluster"
        - name: mazz2-cluster
          mountPath: "/kiali-remote-cluster-secrets/istio-remote-secret-mazz2-cluster"
        - name: foo
          mountPath: "/kiali-remote-cluster-secrets/foosecret"

this is backwards compat and won't break anything if in master - so I'm going to merge it now. It will only be useful once https://github.com/kiali/kiali/pull/5778 is merged


UI changes for V2

Is your feature request related to a problem? Please describe.

The link icons next to samples are too close to the scrollbar on the right.

Use a darker color for the sidebar component to create a contrast with docs since this is a tool. Suggestion is to use the background color in the sidebar component for this page: https://outlook.office365.com

Show status  for the http code returned on success and on fail  as well with the right background color and the right Icon as in the screenshots below:

Add a tile for the request options with  the right background color according to REST API color code, as the screenshot below:

Use 3 dots icon for the drop down in History tab instead of the arrow down.

Add background color on the Request Options tab next to the Query tab like in the screenshot below:

@bettirosengugi  cc @jobala
Moved this to separate issues:

#225
#226
#227
#228
#229
#230


Support class method stream discovery for all stream types

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/313
Originally created by @NiallRees on 2022-01-27 13:04:54

The Athena tap uses a stream class method to discover streams: https://github.com/MeltanoLabs/tap-athena/blob/master/tap_athena/tap.py#L29, the SDK doesn't currently make this easy for any other type of stream.
I'm currently writing a tap for a REST API, where one of the resources is a 'reports' endpoint (see https://developer.niceincontact.com/API/ReportingAPI#/Reporting/Generate a datadownload report file). Users create these reports in the UI, but they can be retrieved through the API. The API provides an endpoint to retrieve the report data given the report ID, and also an endpoint to list available reports.
It would be really great to incorporate the thinking from https://gitlab.com/meltano/sdk/-/merge_requests/44 into all stream types, allowing tap developers to more easily incorporate 'dynamic' stream discovery.
Right now, for me to call the list reports endpoint and instantiate a stream for each to return in tap.py is quite awkward when using the RESTStream. I'd like to be able to implement a method like NiceInContactReportStream.discover_reports(), but the self.http_headers and self.authenticator.auth_headers I need to authenticate with are attributes of an instantiated class, so I can't make discover_reports() a class method. As a workaround, I have to instantiate an instance of the NiceInContactReportStream with some fake values to then be able to call discover_reports().
My example discover_report_ids()
class NiceInContactStream(RESTStream):
    name = "base" # has to have a name to be able to instantiate
    schema = { # has to have a schema to be able to instantiate
        "stub": {
            "type": "number",
        }
    }
    ...

    def discover_reports(self):
        """Used in discovery."""
        headers = self.http_headers
        headers.update(self.authenticator.auth_headers)

        resp = requests.get(
            url="https://api-c44.nice-incontact.com/incontactapi/services/v23.0/reports",
            headers=headers,
        ).json()

        datadownload_reports = [report for report in resp["reports"] if report["reportType"] == "DataDownload"]
        return datadownload_reports

And its use in tap.py
    def discover_streams(self) -> List[Stream]:
        """Return a list of discovered streams."""
        nice_in_contact_stream = NiceInContactStream(self)
        reports = nice_in_contact_stream.discover_reports()

        return [ReportStream(self, report)
            for report in reports
        ]

Hope this makes sense but happy to elaborate more!

View 7 previous comments from the original issue on GitLab

This is better addressed by a centralized connector object


Fix transform changes in _integrate_forces being overwritten

Fixes #83412.
This adds a force_update_transform after every _integrate_forces call, in order to flush any pending NOTIFICATION_TRANSFORM_CHANGED that might be needed and thereby push those transform changes to the physics server before we request it back from the physics server again at the next _sync_body_state that happens right after.
Note that this results in a new NOTIFICATION_TRANSFORM_CHANGED notification that wasn't being emitted before, even when the user was explicitly modifying the transform. I would perhaps argue that the lack of this notification was also a bug and something that should have been emitted, seeing as how transform changes in any other method would emit that notification.

There is an alternative implementation to this as well, which is to not use force_update_transform and instead just push the new transform to the physics server explicitly through PhysicsServer*D::body_set_state.
This has the benefit of not emitting NOTIFICATION_TRANSFORM_CHANGED right away, as it would instead be queued up and flushed by the SceneTree like normal. It would then also not be emitted as part of the physics tick, which could potentially happen multiple times per drawn frame.
The drawback of this is that it would likely need to look something like this:
Transform3D old_transform = get_global_transform();
GDVIRTUAL_CALL(_integrate_forces, p_state);
Transform3D new_transform = get_global_transform();

if (new_transform != old_transform) {
	PhysicsServer3D::get_singleton()->body_set_state(get_rid(), PhysicsServer3D::BODY_STATE_TRANSFORM, new_transform);
}

... meaning every single RigidBody3D that implements _integrate_forces would now be paying the cost for an update to global_transform regardless of whether or not the transform is modified within _integrate_forces.
force_update_transform on the other hand is just a nullptr check in the case where no changes to the node transform has been made. Unfortunately the SelfList that Node3D uses for this check is not public, and strikes me as an implementation detail anyway, otherwise it could've potentially been used by the physics bodies to quickly check whether the transform was dirtied or not.

It seems like this PR has unearthed another bug related to CanvasItem::set_block_transform_notify, that manifests in ways where if you set the transform to be a constant value in _integrate_forces, like this:
func _integrate_forces(_state):
	rotation_degrees = 45

... you will never actually see that transformation happen until something changes the transform somewhere else. But if you do something like this instead:
func _integrate_forces(state):
	rotation_degrees = 45 * state.step

... then everything is fine.
Interestingly this last snippet doesn't seem to have worked even before #79977, so there's been some kind of give and take here at least.
I'll see about making a separate PR to fix this new issue with CanvasItem::set_block_transform_notify.

Thanks!


Feat(android): implement asset folder playback

Summary
Feature: implement playback ability from app asset folder
Motivation
Fix: https://github.com/react-native-video/react-native-video/issues/2825
Changes

remove some used functions
Implement playback with DataSource.Factory from asset

Test plan

sample video asset added in the sample app

And thank you @evoactivity for the link !


anki: switch to using qt5

Description of changes
Fixes https://github.com/NixOS/nixpkgs/issues/248357
I'm unsure if the issue is with nixpkgs pyqt6 packaging, or if the issue is an upstream one.
Either way, we're able to get working preferences by switching back to qt5, and upstream supports both qt5 and qt6 still, so this seems like a reasonable path to take.
We can tackle getting qt6 working if it's still broken whenever upstream or nixpkgs drops qt5 support.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

cc @mohe2015, thanks for reporting the issue here over in https://github.com/NixOS/nixpkgs/pull/229480
if you want to check if this fixes it for you, you can try running this PR locally with:
nix --extra-experimental-features 'nix-command flakes' run 'github:NixOS/nixpkgs/refs/pull/248367/head#anki'

Be warned, it'll take a bit to compile, rust is slow

I'm not sure this is a good idea. I'm not aware of issues with the preferences screen in the official Qt6 Anki bundle - can you reproduce it with that? Some deck authors and add-on authors already depend on newer Chromium functionality that is only available in Qt6, so switching to Qt5 (only) may break some installs.

The interesting thing seems to be that my local from source qt6 build that is broken outputs:
Running with temporary Qt5 compatibility shims.
Run with DISABLE_QT5_COMPAT=1 to confirm compatibility with Qt6.
Preparing to run...
Qt warning: QGuiApplication::setDesktopFileName: the specified desktop file name ends with .desktop. For compatibility reasons, the .desktop suffix will be removed. Please specify a desktop file name without .desktop suffix
Starting main loop...

and the anki-bin build outputs:
Anki starting...
Initial setup...
Running with temporary Qt5 compatibility shims.
Run with DISABLE_QT5_COMPAT=1 to confirm compatibility with Qt6.
Preparing to run...
Wayland support is disabled by default due to bugs:
https://github.com/ankitects/anki/issues/1767
You can force it on with an env var: ANKI_WAYLAND=1
Qt warning: In /nix/store/0iz805kz4qxnxapfd7wxms53gl2c8bbz-qtwayland-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqwayland-xcomposite-egl.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/0iz805kz4qxnxapfd7wxms53gl2c8bbz-qtwayland-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqwayland-egl.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/0iz805kz4qxnxapfd7wxms53gl2c8bbz-qtwayland-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqwayland-generic.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/0iz805kz4qxnxapfd7wxms53gl2c8bbz-qtwayland-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqwayland-xcomposite-glx.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqoffscreen.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqminimalegl.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqlinuxfb.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqvnc.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqminimal.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqeglfs.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforms/libqxcb.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platformthemes/libqgtk3.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platformthemes/libqxdgdesktopportal.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforminputcontexts/libibusplatforminputcontextplugin.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/platforminputcontexts/libcomposeplatforminputcontextplugin.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/qplssa4qbxpy8l5r34l4lr0ikrrh9fh3-qtvirtualkeyboard-5.15.9/lib/qt-5.15.9/plugins/platforminputcontexts/libqtvirtualkeyboardplugin.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/xcbglintegrations/libqxcb-glx-integration.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/xcbglintegrations/libqxcb-egl-integration.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/clz57sw7rjyvisyaf3sspikbmws1k5br-breeze-qt5-5.27.7-bin/lib/qt-5.15.9/plugins/styles/breeze.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/jbvqyq4sji8did4gxbs8canbdh89crkh-kiconthemes-5.108.0-bin/lib/qt-5.15.9/plugins/iconengines/KIconEnginePlugin.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/7smr5dlpzciipv32aayyrs1pn2li2qhn-qtsvg-5.15.9-bin/lib/qt-5.15.9/plugins/iconengines/libqsvgicon.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/7smr5dlpzciipv32aayyrs1pn2li2qhn-qtsvg-5.15.9-bin/lib/qt-5.15.9/plugins/imageformats/libqsvg.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/imageformats/libqgif.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/imageformats/libqjpeg.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/kqghllpfj5kcfyns1aldl7lmcszvz8nz-qtbase-5.15.9-bin/lib/qt-5.15.9/plugins/imageformats/libqico.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/5jlgc8r81sxfcfk1amjaw5gw3l27lv65-qtwebengine-5.15.13-bin/lib/qt-5.15.9/plugins/imageformats/libqpdf.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Starting main loop...
mpv not found, reverting to mplayer

So maybe there is something upstream that didn't fully switch to qt6 yet and that may be the reason our version is broken.

These warnings are mostly safe to ignore, as both qt5 and qt6 use the same search path for plugins (QT_PLUGIN_PATH), there's little we can do to suppress them.

Thanks for the info @dae, appreciated!
Thinking about it a little more, I think the right thing to do is:

Update the nixpkgs anki package into 'anki_qt5' and 'anki_qt6', with anki = anki_qt6 as the default. This matches the upstream linux anki download page.
Figure out what the real qt6 issue is here. I'm still suspicious that it's somewhere in nixpkgs's packaging of python-qt packages, not in the anki codebase itself, but debugging it properly is the right thing to do here it sounds like

I can update this PR to do 1 if other people think it's worth having two packages, which also has the benefit of giving people a workaround for the preferences bug.
I'll do more investigation into the underlying bug in the associated issue (#248357) when I have time.

This workaround is no longer needed, because #248357 was fixed by adding the missing qt6 dependency.

Indeed! Thanks for closing this out, I totally forgot to :sweat_smile:


Add hydrology endpoint

This PR adds the basic /hydrology/point/<lat>/<lon> endpoint, which includes a point data query with optional ?format=csv and ?summarize=mmm arguments.
(You will notice that I did not use a WCPS request to get the min, mean, max values - instead I just summarized these from the regular WCS results. I could not seem to write a WCPS query that would return the correct data in this structure without resorting to a bunch of iteration wrapping the WCPS query, sending lots of round trip requests to rasdaman. This method seemed much simpler / more transparent to me, but of course I am open to suggestions!)
To test, run the flask application as described in README.md, then review the documentation at /hydrology.html. Then try:
Standard endpoint:
/hydrology/point/62/-145

Endpoints with ?summarize=mmm argument, ?format=csv argument, and combined ?summarize=mmm&format=csv arguments:
/hydrology/point/62/-145?summarize=mmm
/hydrology/point/62/-145?format=csv
/hydrology/point/62/-145?summarize=mmm&format=csv

Bad arguments to make sure no data is returned:
/hydrology/point/62/-145?summarize=mean
/hydrology/point/62/-145?format=xlsx
/hydrology/point/62/-145?summarize=mean&format=csv
/hydrology/point/62/-145?summarize=mmm&format=xlsx

There actually four citations / links I think we'll want here:
The original source dataset: this is the link that is currently in the doc page!
The paper about the original source dataset: which is this one https://doi.org/10.1016/j.cliser.2022.100312
The paper Jeremy is writing about this data as we are serving it (decadal monthly summaries): we can see if he has a title and add an  (in prep) or (in review) or whatever.
The link to the dataset on on our own GeoNetwork Data Portal once it is live.

This endpoint and documentation are looking great overall!
I noticed the same repeated mmm-summary values issue that @charparr already mentioned, but besides that, the only (minor) issue I found is that a bad format parameter returns an unformatted (non-template version) "Internal Server Error" page:
http://localhost:5000/hydrology/point/61.5/-147?format=badvalue
Compare this with the HTTP 400 "Bad Request" error page that is returned when a bad value is passed into the summarize parameter:
http://localhost:5000/hydrology/point/61.5/-147?summarize=badvalue
Expected behavior is that the bad value passed into the format parameter returns the same HTTP 400 "Bad Request" error page.

Bad format args behavior fixed with https://github.com/ua-snap/data-api/pull/358/commits/c55666f2a22745ea32ca9a1987c91d642a9901e7

As part of the revisions in https://github.com/ua-snap/data-api/pull/358/commits/82e4b3ba34b49aeb88bc009af7332e32065e82a2, I also incorporated a check for NaN in the min/mean/max values. This was because my JSONView add-on was now telling me that {"max":NaN} was not valid JSON. So I just changed it to the string "nan", but I realize this creates mixed data types in the mmm values. Is this OK? Do you have any suggestions that don't end up mixing floats and strings like this?

There actually four citations / links I think we'll want here:
The original source dataset: this is the link that is currently in the doc page!
The paper about the original source dataset: which is this one https://doi.org/10.1016/j.cliser.2022.100312
The paper Jeremy is writing about this data as we are serving it (decadal monthly summaries): we can see if he has a title and add an (in prep) or (in review) or whatever.
The link to the dataset on on our own GeoNetwork Data Portal once it is live.

The first two have been incorporated into the documentation, and the last two have been punted into issue #363 since we cannot yet link to them


Audit cosign output

Let's make sure output is accurate and informative for GA

Checked output for the following scenarios:

cosign sign with a keypair

cosign sign -key cosign.key gcr.io/priya-chainguard/test
WARNING: the flag -key is deprecated and will be removed in a future release. Please use the flag --key.
Enter password for private key:
Pushing signature to: gcr.io/priya-chainguard/test

cosign sign experimental

COSIGN_EXPERIMENTAL=1 cosign sign  gcr.io/priya-chainguard/test
Generating ephemeral keys...
Retrieving signed certificate...
Your browser will now be opened to:
https://oauth2.sigstore.dev/auth/auth?access_type=online&client_id=sigstore&code_challenge=KCkO3LFfxff4nb9hSC5slWDTlmVanVP3L6BIEYyd-wQ&code_challenge_method=S256&nonce=26kyNRIp0rhUJyakmgepuscKxca&redirect_uri=http%3A%2F%2Flocalhost%3A57649%2Fauth%2Fcallback&response_type=code&scope=openid+email&state=26kyNOFM1ZhHFy6hnuuMsIGGH43
Successfully verified SCT...
tlog entry created with index: 1764717
Pushing signature to: gcr.io/priya-chainguard/test

cosign verify

 cosign verify --key cosign.pub gcr.io/priya-chainguard/test

Verification for gcr.io/priya-chainguard/test:latest --
The following checks were performed on each of these signatures:
  - The cosign claims were validated
  - The signatures were verified against the specified public key

[{"critical":{"identity":{"docker-reference":"gcr.io/priya-chainguard/test"},"image":{"docker-manifest-digest":"sha256:21a3deaa0d32a8057914f36584b5288d2e5ecc984380bc0118285c70fa8c9300"},"type":"cosign container image signature"},"optional":null}]

cosign verify - experimental

COSIGN_EXPERIMENTAL=1 cosign verify  gcr.io/priya-chainguard/test

Verification for gcr.io/priya-chainguard/test:latest --
The following checks were performed on each of these signatures:
  - The cosign claims were validated
  - Existence of the claims in the transparency log was verified offline
  - Any certificates were verified against the Fulcio roots.

...

cosign sign-blob

cosign sign-blob --key cosign.key README.md
Using payload from: README.md
Enter password for private key:
MEUCIBnaaXp6U50mtmu1NS80D/taqOXShonXhNmRKUx9GzwHAiEAxZ9KTcv9HS54vMYnz1TooeXkmoZ6H5XCPTN3ZNlzKG8=

cosign verify-blob

 cosign verify-blob --key cosign.pub --signature=MEUCIBnaaXp6U50mtmu1NS80D/taqOXShonXhNmRKUx9GzwHAiEAxZ9KTcv9HS54vMYnz1TooeXkmoZ6H5XCPTN3ZNlzKG8= README.md
Verified OK

TODOs:

[ ] cosign clean should probably prompt the user before deleting everything


Upgrade with latest AWS 3.9.0 + Terraform 0.13

This combination does not seem to work. Are there issues to support it? How much work it is?

Can you be more specific? What configuration do you try to use? What version of the module you are using?
PS: This module supports AWS provider 3 and Terraform 0.13 already.

I am using 2.57.0. I tried upgrading to official AWS provider 3.9.0 and Terraform 0.13.4, but here is the error I am getting:
$ terraform init
Initializing modules...

Initializing the backend...

Initializing provider plugins...
- Using previously-installed hashicorp/template v2.1.2
- Using previously-installed hashicorp/null v2.1.2
- Using previously-installed cloudflare/cloudflare v2.11.0
- Using previously-installed hashicorp/random v2.3.0
- Finding hashicorp/aws versions matching "~> 3.9.0, ~> 2.57"...

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider hashicorp/aws:
no available releases match the given constraints ~> 3.9.0, ~> 2.57

$ terraform providers

Providers required by configuration:
.
├── provider[registry.terraform.io/hashicorp/aws] ~> 3.9.0
├── provider[registry.terraform.io/hashicorp/random] ~> 2.3.0
├── provider[registry.terraform.io/hashicorp/template] ~> 2.1.2
├── provider[registry.terraform.io/hashicorp/null] ~> 2.1.2
├── provider[registry.terraform.io/cloudflare/cloudflare] ~> 2.11.0
├── module.kong
│   ├── provider[registry.terraform.io/hashicorp/template]
│   ├── provider[registry.terraform.io/hashicorp/aws]
│   ├── provider[registry.terraform.io/hashicorp/random]
│   ├── module.kong_internal_lb_cw
│   │   └── provider[registry.terraform.io/hashicorp/aws]
│   └── module.kong_external_lb_cw
│       └── provider[registry.terraform.io/hashicorp/aws]
└── module.vpc
    └── provider[registry.terraform.io/hashicorp/aws] ~> 2.57

What module.vpc version you are using? Update module version and remove .terraform directory.
It looks you are using a version older than v2.45.0 (see this diff)

I was using vpc 2.44.0 and upgraded to 2.57.0. Removing .terraform and rerunning terraform init worked. Thank you!


PythonEnvironment assumes venv

The implemementation of inmanta.env.PythonEnvironment assumes it's running in a virtual environment. The location of the site-packages dir in particular is venv-specific and wouldn't be compatible with a system Python. Attempting to run inmanta like /usr/bin/python -m inmanta.app would add /usr/site-packages to the sites dir. This likely breaks inmanta project install in this scenario, and might have a whole range of other undefined behaviors.

Figure out the impact (what is affected)
Figure out if we can work around
requeue or make a new ticket

Looking at this ticket again now I'm wondering if this is just a reasoning error. As far as I can see right now the structure of the python binaries and site packages for system Python is actually very similar to the venv ones (the example above does not seem correct). I assume it's even more the other way around that venv models the system structure. I think we can just close this one.

Is it a problem that the bin directory of the venv is in a different location?

I think you are right.

It was verified that the above-mentioned use case works fine with the current implementation.


Tag and release new version?

Can we tag and release a new version. So we can bum to that version on main project and use the latest patches?

->  #277


Fix swagger response code

Closes #2118

backport as we deliver the swagger docks build in too

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@fa747aa). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2119   +/-   ##
=======================================
  Coverage        ?   39.38%
=======================================
  Files           ?      181
  Lines           ?    10810
  Branches        ?        0
=======================================
  Hits            ?     4258
  Misses          ?     6245
  Partials        ?      307

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

already done -> https://github.com/woodpecker-ci/woodpecker/pull/2121


Add max_inputs_per_id as argument for ReversibleId#initialize

Summary

max_inputs_per_id to check length of array provided as input for encode and encode_hex
set default max_inputs_per_id to 32

Related issue
#5
Checklist:

[x] Updated the documentation accordingly.
[x] Added tests to cover changes.
[x] All new and existing tests passed.

Can you please also update the RBS?


[Doc Improvement][SEO meta title improvisation][3860121]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/authentication/authentication.md
82
11
link
:white_check_mark:

msteams-platform/concepts/build-and-test/adaptive-card-previewer.md
98
2
link
:white_check_mark:

msteams-platform/concepts/build-and-test/apps-localization.md
88
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
92
6
link
:white_check_mark:

msteams-platform/concepts/authentication/authentication.md
82
11
link
:white_check_mark:

msteams-platform/concepts/build-and-test/adaptive-card-previewer.md
98
2
link
:white_check_mark:

msteams-platform/concepts/build-and-test/analyze-your-apps-usage-in-developer-portal.md
92
18
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
92
6
link
:white_check_mark:

msteams-platform/concepts/authentication/authentication.md
82
11
link
:white_check_mark:

msteams-platform/concepts/build-and-test/adaptive-card-previewer.md
98
2
link
:white_check_mark:

msteams-platform/concepts/build-and-test/analyze-your-apps-usage-in-developer-portal.md
92
18
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
92
6
link
:white_check_mark:

msteams-platform/concepts/authentication/authentication.md
82
11
link
:white_check_mark:

msteams-platform/concepts/build-and-test/adaptive-card-previewer.md
98
2
link
:white_check_mark:

msteams-platform/concepts/build-and-test/analyze-your-apps-usage-in-developer-portal.md
92
18
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
92
6
link
:white_check_mark:

msteams-platform/concepts/authentication/authentication.md
82
11
link
:white_check_mark:

msteams-platform/concepts/build-and-test/adaptive-card-previewer-vs.md
96
2
link
:white_check_mark:

msteams-platform/concepts/build-and-test/adaptive-card-previewer.md
98
2
link
:white_check_mark:

msteams-platform/concepts/build-and-test/analyze-your-apps-usage-in-developer-portal.md
92
18
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Initial models

This PR adds the initial models.

This is a rough first pass at making a viewer model that is completely serializable. I am merging now, but there are some issues:

DataStream objects are serialized deeper in the hierarchy (e.g., in the visuals). while a reference in memory, they are written to disk, which is not correct. should use a UID for them. (#6)
Slicing is not being done (#7)
no communication from the view to the model (e.g., if the camera is moved in the GUI, the camera model is not updated). (#8)
no incremental state update (#9)


listStatus should update files' lastSyncTime under the directory for HDFS

Is your feature request related to a problem? Please describe.
When ufs is hdfs, listStatus a directory

syncs and updates meta data of files under it
does not updates lastSyncTime of files under it

These causes accessing a file under the directory just after listStatus needs to sync meta once more.
Below is an example with alluxio.user.file.metadata.sync.interval=5m
// 1. the meta data of the file is outdated
$ bin/alluxio fs ls -Dalluxio.user.file.metadata.sync.interval=-1 /nginx/master.log
-rw-rw-r--  alluxio   alluxio   2036694       PERSISTED 04-29-2022 12:18:00:414 100% /nginx/master.log

// 2. listStatus on the directory
$ bin/alluxio fs ls /nginx
-rw-rw-r--  alluxio   alluxio   2037635       PERSISTED 04-29-2022 12:22:22:016   0% /nginx/master.log

// 3. check audit log at hdfs side
$ tail hdfs-audit.log|grep nginx
2022-04-29 12:26:50,818 INFO FSNamesystem.audit: allowed=true   ugi=... ip=... cmd=getfileinfo src=.../nginx
2022-04-29 12:26:50,821 INFO FSNamesystem.audit: allowed=true   ugi=... ip=... cmd=listStatus  src=.../nginx

// 4. check meta data of the file at alluxio side, it is updated
$ bin/alluxio fs ls -Dalluxio.user.file.metadata.sync.interval=-1 /nginx/master.log
-rw-rw-r--  alluxio   alluxio   2037635       PERSISTED 04-29-2022 12:22:22:016   0% /nginx/master.log

// 5. access the file with normal style
$ bin/alluxio fs ls /nginx/master.log
-rw-rw-r--  alluxio  alluxio    2037635       PERSISTED 04-29-2022 12:22:22:016   0% /nginx/master.log

// 6. check audit log at hdfs side, find the meta data of the file synced once more
$ tail hdfs-audit.log|grep nginx
2022-04-29 12:27:06,947 INFO FSNamesystem.audit: allowed=true   ugi=... ip=..  cmd=getfileinfo src=.../nginx/master.log

Describe the solution you'd like
listStatus should also update lastSyncTime of files under the directory.
Describe alternatives you've considered
No
Urgency
This can improve the performance of AlluxioMaster.
Additional context
Testing based on alluxio-2.7.1

@jiacheliu3 @tcrain  can you help assess if this is needed? Thank you.

When a child is checked, UfsSyncPathCache.shouldSyncPath() checks parents of this child. So if the user performs a full sync on /dir, then checks /dir/file, the latter sync will be skipped correctly.

It seems that this is not implemented yet, it needs this feature #15486

This is in ... but that can just be a bug in UfsSyncPathCache

Thanks for your help. I will verify it.

(from: https://github.com/Alluxio/alluxio/pull/15277#issuecomment-1119316301)
Checked the code and did a test, this only works if the "ls" operation for the directory has the "recursive" option. @jiacheliu3

@jiacheliu3 May I know

Why I know why SyncTime.mLastRecursiveSyncMs is needed besides SyncTime.mLastSyncMs?
Is it ok to update mLastRecursiveSyncMs of the first level children after listStatus the directory without "recursive" option?

@jiacheliu3 May I know

Why is SyncTime.mLastRecursiveSyncMs needed besides SyncTime.mLastSyncMs?
Is it ok to update mLastRecursiveSyncMs of the first level children after listStatus the directory without "recursive" option?

Checked the code and learned that I had misunderstanding about updating mLastRecursiveSyncMs. Setting mLastRecursiveSyncMs of the directory is faster than updating all its offsprings, so it is needed.
Please ignore the above two questions here.  Sorry for the inconvenience.

Thanks for the question. Seems the mLastRecursiveSyncMs is updated when DescendantType.ALL. So DescendantType.ONE is actually quite ambiguous here.
From a Unix/Linux FS perspective, the direct children list is part of the directory metadata. So updating the directory metadata and the direct children both count as updating the directory (not recursive). That sounds fine, just a bit counter-intuitive at the first sight.
WDYT? @yuzhu @tcrain @secfree

Thanks for the question. Seems the mLastRecursiveSyncMs is updated when DescendantType.ALL. So DescendantType.ONE is actually quite ambiguous here.
From a Unix/Linux FS perspective, the direct children list is part of the directory metadata. So updating the directory metadata and the direct children both count as updating the directory (not recursive). That sounds fine, just a bit counter-intuitive at the first sight.
WDYT? @yuzhu @tcrain @secfree

If the directory has a lot of children, updating all of them may be expensive. Is it ok to add another field like mLastChildrenSyncMs to UfsSyncPathCache.SyncTime?

If the directory has a lot of children, updating all of them may be expensive. Is it ok to add another field like mLastChildrenSyncMs to UfsSyncPathCache.SyncTime?

@secfree Good question. If we are updating all the children's SyncTime.mLastSyncTimeMs, then yes adding the field mLastChildrenSyncMs will definitely make sense. However I don't find where we are doing that, I only see here we update the parent's sync time.
https://github.com/Alluxio/alluxio/blob/e26e635d50419879cdf2c48d0ad84f12fe0aa12d/core/server/master/src/main/java/alluxio/master/file/InodeSyncStream.java#L441
Please correct me if I'm wrong :)

Yes, you are right. The current implementation of listStatus only update the directory's sync time, but not its children.
However, if we want to avoid accessing ufs for the file (just under the directory) once again just after listStatus, we may need to do one of the following options

Update children's sync time
Add mLastChildrenSyncMs field
Other options ...

#16081 updates the metadata of children if listStatus the directory prefetched the metadata, so I will close this issue.


Update websub BBEs

Purpose

$Title

Fixes #19681
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19700 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19700   +/-   ##
================================================
  Coverage            20.51%   20.51%
================================================
  Files                   52       52
  Lines                 1394     1394
  Branches               216      216
================================================
  Hits                   286      286
  Misses                1095     1095
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb205d...1503203. Read the comment docs.


Typo in _rbac_group_detail.html.haml

Configuration -> Access Control -> Groups -> Any group
Generated this Error caught: [ActionView::Template::Error] undefined method -@' for "View this Tenant":String` because of typo in haml.
@himdel please have a look, thanks :)
@miq-bot add_label ui, bug

Introduced by https://github.com/ManageIQ/manageiq/pull/11056


[MODEL REQUEST] Bark - text to singing & sound effects - from suno.ai / suno.com

Is your feature request related to a problem? Please describe.
I would love to generate singing voices and sound effects from text.
Details of model being requested

Model name: Bark
Source repo link: https://github.com/suno-ai/bark
Research paper link [If applicable]:
Model use case: text to speech, lyrics to singing, text to creating sound effects

Additional context for requested model
https://ismir2024.ismir.net/ is next week, Suno will be there. It would be cool, if this model works on the X Elite.

Added to our list of requested models. We won't be able to look into this by next week however we encourage you to try it on AI Hub via BYOM (bring your own model) and let us know on our Slack Channel if you hit any issues


feat: add useAxios hook  and tests

Issue

Write useAxios hook and  tests for it.

Files  to change

jest.config.js  for test setup
package.json

Update react and react-testing-library version
Add msw and axios
Inside scripts add test-coverage command.

src/custom-hooks/useFetch.js  change URL methods of passing change with props.

Files to add

setupTests.ts  add teardown
mocks/server.ts add server
mocks/handler.ts add handler
hooks/useAxios.ts feat: useFetch hook.
__tests__/useAxios.ts test for useFetch hook.

UseAxios hook

The useAxios hook is a custom React hook for making HTTP requests with the axios library. It returns an object with three properties: data, loading, and error. The data property contains the response data, the loading property is a boolean that indicates whether the request is in progress, and the error property contains any error that occurred during the request.
The hook accepts a URL, an HTTP method (defaults to GET), and a configuration object that can be used to pass additional options to axios

UseAxios hook test

The tests for the useAxios hook use the msw library to mock HTTP requests and verify that the hook returns the expected values for different scenarios, such as successful requests and failed requests.
get , patch and reject request during testing.

First, get #7 PR merge and then add this PR, both have the same code just one file is changed.
Get the first PR merged first and then raise a PR for ueAxios feature 🙂


Add --prod flag to all npm build steps to fix SRI

This PR modifies package.json to add the --prod flag to the build step
for the staging stage (not just for the prod stage).
This is necessary because without the --prod flag, the staging site
adds a  tag block that contains <link> tags
in it that do not have an 'integrity' attribute.
In other words, if we do not build our site with the --prod flag, it
disables SRI for resources in the  tags, which
leaves users with Javascript off vulnerable to CSS-based cross-site
scripting attacks.
See SEAB-3225.

CircleCI is failing on unit tests at the build step, but it doesn't seem to be related to the new flag, it's a problem with an unreachable (CircleCI) URL:
+ java -jar openapi-generator-cli.jar generate -i https://11390-33383826-gh.circle-artifacts.com/0/tmp/artifacts/swagger.yaml -g typescript-angular -o src/app/shared/swagger -c swagger-config.json --skip-validate-spec
[main] ERROR io.swagger.v3.parser.util.RemoteUrl - unable to read

CircleCI is failing on unit tests at the build step, but it doesn't seem to be related to the new flag, it's a problem with an unreachable (CircleCI) URL:
+ java -jar openapi-generator-cli.jar generate -i https://11390-33383826-gh.circle-artifacts.com/0/tmp/artifacts/swagger.yaml -g typescript-angular -o src/app/shared/swagger -c swagger-config.json --skip-validate-spec
[main] ERROR io.swagger.v3.parser.util.RemoteUrl - unable to read

...

[main] ERROR io.swagger.v3.parser.util.RemoteUrl - unable to read
java.io.FileNotFoundException: https://11390-33383826-gh.circle-artifacts.com/0/tmp/artifacts/swagger.yaml

...

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>prebuild: `ts-node -O '{"module":"commonjs"}' git.version.ts && ./scripts/generate-openapi-script.sh`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prebuild.prod script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2021-08-10T17_17_03_442Z-debug.log

Exited with code exit status 1

Looks like your base branch is probably from a very long time ago

Indeed I had created the branch from an old commit on develop.

dev.dockstore.net and and the develop branch have a new major version of Angular; is it possible Angular fixed something in this area?

Or broke something. On a closer look at prod and dev, I noticed that prod does not have the  block that's missing the SRI, but dev does. (The missing SRI attribute was reported by Netsparker and is what prompted this pull request.) Staging also does not have the  block, which is consistent with it being on the same version of Angular as prod.
This all seems consistent with the hypothesis that the new version of Angular is adding in the  block, but that that block leaves out subresource integrity attributes in the resources it puts in there. Which would mean this pull request is not fixing the right thing.

(And that we've uncovered a possible bug in Angular!)

@garyluu, it seems like we should still take this, right, to update usage of the deprecated --prod, right?

my other PR includes this change so it probably doesn't matter either way

Seems to be "fixed" with:
gluu@DESKTOP-TB9EL7G:~/dockstore-ui2$ git diff angular.json
diff --git a/angular.json b/angular.json
index 369d142c..af899e07 100644
--- a/angular.json
+++ b/angular.json
@@ -63,7 +63,12 @@
                   "replace": "src/environments/environment.ts",
                   "with": "src/environments/environment.prod.ts"
                 }
-              ]
+              ],
+             "optimization": {
+                "styles": {
+                  "inlineCritical": false
+                }
+              }
             },

not entirely sure why

Seems to be "fixed" with:

Thanks for figuring that out, Gary. When you say "fixed", what do you mean (and why the quotes)? Is the above change included in a different PR? If not, will you open a PR with that change?

Seems to be "fixed" with:

Thanks for figuring that out, Gary. When you say "fixed", what do you mean (and why the quotes)? Is the above change included in a different PR? If not, will you open a PR with that change?

I say "fixed" because I'm not entirely sure why it fixes it and where the problem lies (did Angular screw up the inline css feature?).  The above change isn't in any of my current PRs. Since it's your issue, I was thinking you may want to go in more depth to figure out why the fix works.

Sounds good, just wanted to clarify. Will open a separate PR that implements that fix.


Fixes apt module deprecation warnings

This also closes pr #444 and some minor puppet-lint warnings.

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

Looks like this is also a duplicate for #359

Looks good to me.

bump. rebased it.