Added checkbox, inline input text, "modalwindow" and popup.picker to template library

We recently added two additional components people may find useful: a checkbox widget and an inline-text widget.  The inline-text is a personal favorite.  It basically provides an input box with a placeholder text AND an Icon.  For validations, if there is a failure, the icon changes to the alert icon AND, if clicked, the validation error is displayed in the input box!  I think many will find this both stylish and useful.


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
168e2ace7a8783f54ed36dd116bb4fbf6d84f5d7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
168e2ace7a8783f54ed36dd116bb4fbf6d84f5d7
link
/test istio-unit-tests

prow/istio-presubmit.sh
168e2ace7a8783f54ed36dd116bb4fbf6d84f5d7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Added shutdown player alert

It add player shutdown alert

Looks good, I will look into solving without having to use a timeout!

Looks good, I will look into solving without having to use a timeout!

Thanks! The reason for setTimeout is: the disconnect packets are not sent, maybe it's concurrency problem


Add annotations to services defined in Charts

add annotations to services defined in Charts
make use service type from values.yaml for tracing services

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: etiennetremel
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @etiennetremel. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@etiennetremel: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Jaeger is getting reverted - so you'll likely get some conflicts.
Let's move it to master if possible, I don't think it's release blocking.

That's unfortunate, I rebased the branch. This is definitely not a blocker but nice to have. Currently I have a workaround to patch some of the services because of the missing annotations field.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6507604b6ca19bfaf2876d88164708e49d1a0839
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Fixed conflicts since Jaeger is back again (https://github.com/istio/istio/pull/5840)

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
e79c3ad2042e858cbc92260b13f628f493a92f6d
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
d3c1b43da8d2ddd17b58743f7c3ec85a7317d914
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
b2482f9d349912a251cd1697f58d136f5a593ed1
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: etiennetremel
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
Assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
ce356348b77cc3fd04967241b72cfcdb72bacde2
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@etiennetremel: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
1110c7c0d0b87bba65f14b9b63c09c27d6f73e63
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
ce356348b77cc3fd04967241b72cfcdb72bacde2
link
/test istio-unit-tests

prow/istio-presubmit.sh
ce356348b77cc3fd04967241b72cfcdb72bacde2
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add to Space Wizard: only options are Import and New Quickstart right now?

when clicking the Add to space button the only 2 options we have right now are import git repo and new quickstart right now?
we've 4 buttons today; wonder if we should hide 2 for now to make it easier to grok?

duplicates #1487 #1417

I'm not sure they are quite the same thing. There's the Create space wizard and the Add to space wizard - today they are the same but I'm not sure they should be.
When creating a space we probably need 3 options; Plan, Import, Quickstart
Once we have a space, the Add to Space should only show Import & Quickstart - since the Forge wizard doesn't help Plan anything, you use the Plan tab for that

I agree, let's remove them for now. Then add them back in when they work.


cannot install qbrt

Hello! I am using manjaroand NodeJS (from snap) 12.
When I I get this error:
[~]$ sudo npm install -g qbrt                                          14:46:50
/usr/local/bin/qbrt -> /usr/local/lib/node_modules/qbrt/bin/cli.js
npm WARN lifecycle The node binary used for scripts is /var/lib/snapd/snap/bin/node but npm is using /var/lib/snapd/snap/node/3292/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/qbrt
> node ./bin/postinstall.js

2020/11/27 14:47:03.810172 cmd_run.go:994: WARNING: cannot create user data directory: cannot create "/snap/node/common": mkdir /snap/node/common: permission denied
cannot create user data directory: /snap/node/3292: Not a directory
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `node ./bin/postinstall.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!
Edit: After trying node 15 from the official repos I got:
[~]$ sudo npm install -g qbrt                                          14:50:45
/usr/bin/qbrt -> /usr/lib/node_modules/qbrt/bin/cli.js

><EMAIL_ADDRESS>postinstall /usr/lib/node_modules/qbrt
> node ./bin/postinstall.js

✗ Installing runtime … failed!
AssertionError [ERR_ASSERTION]: rimraf: missing path
    at rimraf (/usr/lib/node_modules/qbrt/node_modules/fs-extra/lib/remove/rimraf.js:35:3)
    at rimraf (/usr/lib/node_modules/qbrt/node_modules/universalify/index.js:5:67)
    at /usr/lib/node_modules/qbrt/node_modules/pify/index.js:29:7
    at new Promise (<anonymous>)
    at /usr/lib/node_modules/qbrt/node_modules/pify/index.js:12:10
    at ret (/usr/lib/node_modules/qbrt/node_modules/pify/index.js:56:34)
    at /usr/lib/node_modules/qbrt/bin/install-runtime.js:262:27
    at <anonymous> {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: true,
  operator: '=='
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `node ./bin/postinstall.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!


Use of valueLabel

Hi Luis,
First of all, great component!
My question; for our project we need to display either a static text in the center of the ring or a two liner; both a static text and the percentage. How would I do this?
Regards, Raoul.

This isn’t currently possible, the percentage is always shown. But feel free to subclass the ring and do whatever you need.


Disable Taskbar thumbnail preview on mouse hover

Is your feature request related to a problem? Please describe.
Taskbar thumbnail preview on mouse hover interupts my workflow. For example, when an accidentally trigger thumbnail preview opens near start menu, I have to wait a few seconds before I can hit start. The feature is not disabled when disabling aero peek.
Describe the solution you'd like
This registry change postpones the thumbnail popup. A crude, but effective, means to disable the pop-up.
[HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced]
"ExtendedUIHoverTime"=dword:00030000

Describe alternatives you've considered
n/a
Additional context
n/a

You can change this by switching the UI to performance mode that disable the UI look while also picking up a bit of speed. I'm against changing the default hover time.


JointGraphResources.get(...) is undefined

Hey,
I basically used example you provided for this library and copied it into my project. The error 'JointGraphResources.get(...) is undefined' at 857:35 (angular-jointjs-graph.js) appears when I try to add a new node by drag and drop.
I have no back-end connection yet but i see there is no request send so I assume that is not a problem here.

Please be so kind to provide the full trace.
However, I believe your assumption is wrong - the exception you see is most likely caused by the fact that there is no object provided by the backend on which a request can be initiated. The JointGraphResources factory is a simple store for the Resource objects captured by the main Graph directive, and if there aren't any resources stored there, no requests can be made to the backend.

Alright, thanks for explanation! Indeed it was caused by lack of back-end connection.

No problem, thank you for your feedback.


[NodeSync] Add a sleep before trying to get and execute parents

In private testnet , nodes in a region with higher quorum latency see a much higher rate of hitting the cert execution failed due to missing parents code path.

And high rate of hitting this code path correlates with high CPU usages on these nodes, causing CPU starvations for other operations, e.g. processing and executing certificates in the normal path.

Avoiding this high CPU usage is critical for private testnet to run smoothly. This is a proposed solution to dampen the rate of entering missing parents code path. In practice it limits handle_certificate() requests to at most ~120/s, which may be enough for now?
This is definitely not the solution to the root cause. We still see CPU usage going up then drop drastically in ~10hr cycles, although the highest handle_certificate() request rate is much lower. This will also limit throughput when the missing parents code path is expected. But I hope to drop this hack soon with a more fundamental solution. LMK what you think.

Closing in favor of https://github.com/MystenLabs/sui/pull/5340


particularly confusing exercises

starting a list:

[ ] onDestroy
[ ] congratulations (#212)

closing in favour of #293


Added Animated Progressive Form

Closes #485
Description👨💻
I have added a progression form which will be filled step by step and it will grew bigger as it proceeds
https://github.com/Rakesh9100/Beautiify/assets/140608790/9b62f2d2-14ac-4da6-b1c7-87d2cc5db3d4
Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅
Tested Locally and it worked as expected
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Why extra file changes are showing @JiyaGupta-cs

@Rakesh9100 to implement scss

This is fine but extra unnecessary changes are made, check this out pls File Changes!!
And one more thing, why we need scss for just a simple progressive form as it can be done without that as well @JiyaGupta-cs


Code generator

We need a way to generate source code from the data.
This should include:

Services
Service fields
Field assertions respectively constraints
Relational connections

Since we have a good first solution, we can close this issue for now.


Re-rendering GlobalTarget when the wrapperComponent prop changes

We need to move the wrapperComponent prop to the GlobalTarget component so it updates every time the wrapperComponent changes.

After taking another look, this PR is not fixing the issue we had.
Here we are only moving the wrapper up one level but it has no effect on fixing the issue when we update the design version without refreshing the page.
Also, we were able to fix the issue on our codebase.


Statistical significance of results on ContraPro

Dear authors, what kind of test would you suggest to evaluate the statistical significance of system results on ContraPro ?

Hi, I think that a t test would be the correct sigtest to use in this case, since the results are accuracy values.
More information on choosing an appropriate test:
https://www.aclweb.org/anthology/P18-1128.pdf
https://arxiv.org/pdf/1809.01448.pdf

Hi, I think that a t test would be the correct sigtest to use in this case, since the results are accuracy values.
More information on choosing an appropriate test:
https://www.aclweb.org/anthology/P18-1128.pdf
https://arxiv.org/pdf/1809.01448.pdf

@lorelupo I am assuming that this issue can be closed. If not, feel free to reopen / add a comment.

@lorelupo I am assuming that this issue can be closed. If not, feel free to reopen / add a comment.

Yes, thank you for the answer !

Yes, thank you for the answer !


[WIP] Toeplitz speed-up

@tachukao @KrisJensen  I'm confused what's happening here -- when I run the test I added with pytest locally,
pytest test_jasmine_fast_epgp.py
it passes, but it's failing in CI with
  (obs): Svgp(
    (kernel): Linear()
    (likelihood): Gaussian()
    (z): InducingPoints()
  )
  (svgp): Sv...l): Linear()
    (likelihood): Gaussian()
    (z): InducingPoints()
  )
  (lat_dist): fast_EP_GP()
  (lprior): Null()
)
name = 'kernel'

    def __getattr__(self, name: str) -> Union[Tensor, 'Module']:
        if '_parameters' in self.__dict__:
            _parameters = self.__dict__['_parameters']
            if name in _parameters:
                return _parameters[name]
        if '_buffers' in self.__dict__:
            _buffers = self.__dict__['_buffers']
            if name in _buffers:
                return _buffers[name]
        if '_modules' in self.__dict__:
            modules = self.__dict__['_modules']
            if name in modules:
                return modules[name]
        raise ModuleAttributeError("'{}' object has no attribute '{}'".format(
>           type(self).__name__, name))
E       torch.nn.modules.module.ModuleAttributeError: 'SvgpLvm' object has no attribute 'kernel'

do you know what could be going on here / have you seen any errors like this before?

This looks great! I think once we're happy this is running smoothly we should just make it the default GP prior and also get rid of the silly TxT self.dts_sq matrix I stored in the original implementation -- but perhaps that's for a separate PR.

Ready for review, will save the TxT memory saving for the next PR.

this looks awesome! thanks @syncrostone !


Upgrade ZooKeeper to 3.5.5 (stable)

Is your feature request related to a problem? Please describe.
This is just a nice to have. The new version of ZooKeeper has many features such as dynamic membership reconfiguration. Hopefully this can also take out the need for some workarounds to maintain ZK version compatibility with BK as well.
Additional context
Release 3.5.5 is now stable https://zookeeper.apache.org/releases.html

We already did the exercise of upgrading to 3.5.4-beta (and then rolled back because of the perceived instability of -beta...).
There are few breaking things in the on-disk format for zk 3.5, though we are already handling these (though AspectJ) in order to allow a rollback to 3.4.


Detect Extensions if loaded

Fixes #14

[x] Detect Extension Submodules
[ ] Add some Tests
[x] Add a note in documentation

I am not too sure how to simulate the loading of a package extension for testing

I setup a test package to use for testing package extensions, though some other tests are failing

Codecov Report
Attention: Patch coverage is 97.14286% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.68%. Comparing base (bd466a1) to head (a7a71ea).
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/ExplicitImports.jl
97.14%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   96.23%   95.68%   -0.55%
==========================================
  Files           5        5
  Lines         478      510      +32
==========================================
+ Hits          460      488      +28
- Misses         18       22       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Authorization handling

Read and validate provided JWT
Forward JWT to model-storage service in order to get access to models
Enforce access control for cached proprietary models (simulating a model requires read access to its related project)

Codecov Report

Merging #116 into caffeine will decrease coverage by 1.32%.
The diff coverage is 60.31%.

@@             Coverage Diff              @@
##           caffeine     #116      +/-   ##
============================================
- Coverage     73.65%   72.33%   -1.33%
============================================
  Files            19       20       +1
  Lines           634      694      +60
============================================
+ Hits            467      502      +35
- Misses          167      192      +25

Impacted Files
Coverage Δ

src/model/app.py
90% <100%> (+0.71%)
:arrow_up:

src/model/settings.py
100% <100%> (ø)
:arrow_up:

src/model/jwt.py
50% <50%> (ø)

src/model/storage.py
83.67% <84.61%> (-0.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08c9fd...655ba4b. Read the comment docs.


When editing markdown in Jupiter, you cannot insert pictures.

Originally posted here by @MuRongKanKan https://github.com/microsoft/vscode-jupyter/discussions/9426

Needs an upstream issue. VS code has an issue around this.

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/5321


Request:USB support for PC transfers

sorry bout the first request (I wrote it before testing) anyways I have an RG353M and well SSH works fine but i feel that a custom mtp kernel driver to allow file transfers (not just usb C thumb drives) from a PC like the android partition on the system it would be less wear and tear r than removing/reinserting the TF and maybe faster than SSH *or for someone with slow/no internet connection

Not something I will incorporate at this time.  If you don't want to pop out the sd card to transfer roms, you can also use arkbrowser to manage your roms via your web browser or transfer your roms via a usb stick.  Check FAQ for the RG353M for more info on these options.


Memory leak with requires_grad

I have the following code:
using System;
using TorchSharp;

namespace MemoryLeak
{
    class Program
    {
        static void Main(string[] args)
        {
            var device = torch.CUDA;

            while(true) {
	        using (var _ = torch.NewDisposeScope()) {
                    var data = torch.randn(32,1,32,32).to(device).requires_grad_(true);
	        }
	    }
        }
    }
}

This crashes quite quickly with:
Unhandled exception. System.Runtime.InteropServices.ExternalException (0x80004005): CUDA out of memory. Tried to allocate 2.00 MiB (GPU 0; 9.77 GiB total capacity; 9.46 GiB already allocated; 3.31 MiB free; 9.46 GiB reserved in total by PyTorch)

The equivalent code in pytorch doesn't crash:
import torch

device = torch.device("cuda")

while(True):
    data = torch.randn(32,1,32,32).to(device).requires_grad_(True);

Also if I change the requires_grad line to the following:
var data = torch.randn(32,1,32,32).requires_grad_(true).to(device);

It doesn't seem to crash, but maybe it leaks CPU memory instead?

output of nvtop command:

(The large drop in memory is at the moment of crash)

I wonder if it's as easy as checking (in Tensor.Dispose()) whether the associated grad Tensor is non-null and disposing it, too...

Where does the 'grad' property exist?
In python I do:
>>> import torch
>>> a = torch.tensor(1.0, requires_grad=True)
>>> a.backward()
>>> a.grad
tensor(1.)

I have verified that it's not that easy... :-( The grad property is on Tensor, but it's not filled in until you to back-prop, so it's not the problem here.

.requires_grad_(True); should be an in-place operation, so it shouldn't allocate, but maybe the way you CATCH the allocation assumes it allocates?

No, catch doesn't assume allocation:
#define CATCH(x) \
  try { \
    torch_last_err = 0; \
    x \
  } catch (const c10::Error e) { \
      torch_last_err = strdup(e.what()); \
  } catch (const std::runtime_error e) { \
      torch_last_err = strdup(e.what()); \
  }

Even if it allocated, the 'Dispose()' call should take care of it. There's something else going on... Feel free to debug in parallel! If you do, I suggest setting the batch size to something much larger than 32. With N=30000 and three channels, it takes 21 iteration for it to fail with 8GB of GPU memory (my machine).

BTW:
torch.randn(3, 1, 32, 32, requires_grad: true, device:device)

is much faster than what your repro has, and it does not leak memory.

BTW:
torch.randn(3, 1, 32, 32, requires_grad: true, device:device)

is much faster than what your repro has, and it does not leak memory.

And I mean much faster... :-)

@NiklasGustafsson Sorry I meant CATCH_TENSOR
#define CATCH_TENSOR(expr) \
    at::Tensor res = at::Tensor(); \
    CATCH(  \
        res = expr;  \
    );  \
    return ResultTensor(res);

Does it default initialise res, then move assign it to expr?
expr is expanded to tensor->set_requires_grad(requires_grad) which returns a Tensor& to its *this.

Good point. Let me debug...

torch.randn(3, 1, 32, 32, requires_grad: true, device:device)

Ok, good workaround. The original code I used was:
real_img_tmp = real_img.detach().requires_grad_(do_Dr1)

Which was from: https://github.com/NVlabs/stylegan2-ada-pytorch/blob/6f160b3d22b8b178ebe533a50d4d5e63aedba21d/training/loss.py#L111

Yup, I believe that was it -- the C++ implementation of 'set_requires_grad()' essentially created a native alias for the tensor, which was never recognized in the managed code that keeps track of disposables. Therefore, the native reference count is kept up, never reaches 0, so the memory is not freed. I'm sure the rewrite you had wastes CPU memory, instead. Anyway, it should work after the next release.

Yup, I believe that was it -- the C++ implementation of 'set_requires_grad()' essentially created a native alias for the tensor, which was never recognized in the managed code that keeps track of disposables. Therefore, the native reference count is kept up, never reaches 0, so the memory is not freed. I'm sure the rewrite you had wastes CPU memory, instead. Anyway, it should work after the next release, but it will still be far slower than setting requires_grad and device when creating the tensor, when possible.

Is the fix something like this?
#define CATCH_TENSOR(expr) \
    const at::Tensor& res = [&]() -> const at::Tensor& { \
       CATCH(  \
        return expr;  \
    }(); \
    return ResultTensor(res);

@NiklasGustafsson Oh of course, you have control over that method. I thought it was implemented in at::

@NiklasGustafsson Oh of course, you have control over that method. I thought it was implemented in at::

Yeah... no, it's the culprit is the return ResultTensor(res); and the fact that the managed-code caller ignores the returned handle except to check for errors.


Please add a Jar file

JAR is a package file format typically used to aggregate many Java class files and associated metadata and resources into one file for distribution.

Thanks


Recent changes to MonsterModel breaks SQL CE provider test

https://github.com/aspnet/EntityFramework/commit/e6f0e1921216e46de774d8b55785223617982d3d
introduced use of IAuditInfo and other new Interface that contain DateTime properties. Since no value is supplied, these values default to DateTime.MinValue, which breaks INSERTs with SQL CE, as it only supports SqlDateTime.MinValue - I have helped fix this earlier, but unsure of the best way to fix now, since IAuditInfo is an owned entity. @AndriySvyryd

@ErikEJ - The AuditInfo DIET is newly added in tests which is causing the issue. The simplest way to do this to set the value of the date in the ctor of AuditInfo entity since we are not assigning any values to it during seed methods (SeedUsingFks, SeedUsingNavigations etc). Can you submit a PR for this? I think DateTime.Now would also work as value.
Ref line:
https://github.com/aspnet/EntityFramework/blob/dev/src/EFCore.Specification.Tests/TestModels/SnapshotMonsterContext.cs#L445
And other 2 variations of MonsterContext in same folder.


The "truck" icon does nothing

Checklist

[x] I've searched the issue queue to verify this is not a duplicate bug report.
[x] I've included steps to reproduce the bug.
[x] I've pasted the output of kargo version.
[x] I've pasted logs, if applicable.

Description
The "truck" icon (that's supposed to promote subscribers) doesn't work in v0.2.0. When you press the button, the "yes/no" promotion dialog doesn't appear.
Screenshots

Steps to Reproduce

Install v0.2.0
Create a warehouse with some stages
Try and use the "Truck" icon to promote

Version
Client Version: v0.2.0
Server Version: v0.2.0

This was fixed in v0.2.x by #1126 and in main by #1127


[core] Ignore unrelated folders from github actions

Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths.
The ci.yml github action is all about packages check which is not related to docs and examples folders. This PR will speed up the CI check.
How to test?
I think we have to merge this one and open a fake PR that contains changes in docs/examples to test if the ignore works.

[x] I have followed (at least) the PR section of the contributing guide.

I think this could cause a problem because CI / test-dev is a required check and, according to GitHub docs, when skipped, it'll stay in a Pending state forever (see the note under https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths).
There is a workaround described in https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

I think this could cause a problem because CI / test-dev is a required check and, according to GitHub docs, when skipped, it'll stay in a Pending state forever (see the note under https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths).
There is a workaround described in https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

Oh, nice. Forgot about the check.

@michaldudak please review again.

🎉 It works! https://github.com/mui/material-ui/pull/35062

@siriwatknp There's a problem with running checks in PRs that change just the docs. See https://github.com/mui/material-ui/pull/35076
I think the source of the issue is the name of the job - it should be named the same as the required check (test-dev) in this case.
However, I wonder if specifying it for:
pull_request:
    paths:
      - 'docs/**'
      - 'examples/**'

won't trigger the "fake" action also for PRs that change both the docs and other code. We'll have two jobs with the same name running - I don't know if this can cause any problems.

@siriwatknp what do you think about moving these tests to CircleCI? The value could be about having a single tool to run the CI. This means a single place to gather analytics about it, a single learning curve, billing.
Regarding only running based on the file changed, we could copy
https://github.com/mui/material-ui/blob/9d94f27e2839fd30eb793e3667373f882c40a009/.circleci/config.yml#L167-L168

@siriwatknp what do you think about moving these tests to CircleCI? The value could be about having a single tool to run the CI. This means a single place to gather analytics about it, a single learning curve, or billing. For example, we could allocate larger machines.
Regarding only running based on the file changed, we could copy
https://github.com/mui/material-ui/blob/9d94f27e2839fd30eb793e3667373f882c40a009/.circleci/config.yml#L167-L168

Hey, I think that's another topic. My first intention is to skip the tests for non-related changes, not moving them to another provider.

@siriwatknp My thought was that the day-to-day problem is that the CI is too slow. On CircleCI, we could give the environment that runs these tasks more CPUs. But skipping would also be great 👍


Add node 6

Verify if tests pass on Node 6

Can you actually update this to be:
- "0.10"
- "0.12"
- "4"
- "5"
- "stable"

I believe stable has been deprecated. See:

https://nodejs.org/en/blog/release/v6.0.0/#current-what-happened-to-stable
https://github.com/travis-ci/docs-travis-ci-com/pull/534

Yeah, @jonschlinkert is correct.
Can this be updated to:
- "0.10"
- "0.12"
- "4"
- "5"
- "6"

instead?

This was completed by #77


[Details Nerdlet] See installation docs button is too small

Issue
the see installation docs button on quickstart with no installPath is too small.
Steps to reproduce

go to any quickstart that is a documentation only QS
View the button

Expected
this button is the same size as the button for install a quick start.

will be closed by GHE pull 36


[functionapp] Remove deprecated devops-build command

The az functionapp devops-build has been deprecated for more than 2 weeks and suppose to be removed in version 2.0.68 (Sprint 64).
This PR removed the command and suppose to be out in Sprint 64.

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

@ahmedelnably

Howdy @Hazhzeng, I've gone ahead and merged your changes with the most recent version of dev to fix some conflicts for you. Other than having your local repository need a pull there should be no further action needed by you.

Much appreciated @marstr

@yugangw-msft Thanks for reminding. The HISTORY.rst is up to date now.


Unable to build virtual environment

Description
When building a Server 2022 environment following these instructions https://github.com/actions/virtual-environments/blob/main/docs/create-image-and-azure-resources.md, I get an error
==> vhd: Resize-Partition : Size Not Supported
==> vhd:
==> vhd: Extended information:
==> vhd: The partition is already the requested size.
==> vhd:
==> vhd: Activity ID: {a0fdd1f6-989d-4623-922f-18e6b90c58b5}
==> vhd: At C:\Windows\Temp\script-62adac62-5b69-c32d-bedc-bc1c4b2dcb9a.ps1:75 char:1
==> vhd: + Resize-Partition -DriveLetter $driveLetter -Size $size.SizeMax
==> vhd: + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==> vhd:     + CategoryInfo          : NotSpecified: (StorageWMI:ROOT/Microsoft/.../MSFT_Partition) [Resize-Partition], CimExce
==> vhd:    ption
==> vhd:     + FullyQualifiedErrorId : StorageWMI 4097,Resize-Partition
==> vhd:
==> vhd: Script exited with non-zero exit status: 1.Allowed exit codes are: [0]
==> vhd: Step "StepProvision" failed
==> vhd: [c] Clean up and exit, [a] abort without cleanup, or [r] retry step (build may fail even if retry succeeds)?

Retry does not succeed.
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions

Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
n/a
Is it regression?
n/a
Expected behavior
Environment builds successfully
Actual behavior
Environment fails to build
Repro steps
https://github.com/actions/virtual-environments/blob/main/docs/create-image-and-azure-resources.md

Check the thread - https://github.com/actions/virtual-environments/discussions/5432

Why is this issue closed? It is still happening in main. The discussion referred to does not find the root cause, and the workaround is to choose a different region - IMO that is not ideal.


[ADT] Projecting Points into Images

Hi!
First of all, I really appreciate the effort you put in the [ADT] dataset. I'm interested in using the 3D sparse-point clouds in the ADT dataset. Unlike the ASE dataset, the ADT dataset does not include the sparse point clouds information for each vrs file. I've been checking the documentation and I found a projection tutorial in the ASE dataset. However, I have a few questions:

I generated the point-cloud information for each vrs file in the ADT dataset through MPS in the Aria Desktop app. However, how can I map the trajectories from MPS to the information in the Aria Devices? Instead of loading the "aria_trajectory.csv" file, should I load the closed_loop_trajectory.csv that the MPS return in the AriaDataProvider? are the "tracking_timestamp_us" comparable between these two trajectory files? It seems as if the coordinate frames defers between these files. At the end of the day what I need is to project the 3D sparse points into the RGB images stored in the vis files and for that I need to be able to query the RGB images given the time_stamp in the closed_loop_trajectory.csv

I understand that the trajectories you provide in ADT are all in the same world coordinate frame. Is it possible for you to release the 3D sparse point cloud that shares the same coordinate frame with all the trajectories provided in the ADT dataset?

Thank you so much for your help.

Hi @cdforigua05, thanks for your question and for the positive feedback!

We haven't tested loading an MPS trajectory into the AriaDigitalTwinDataProvider. I believe this could work. A few things you'd have to be careful for: (a) don't load the object poses since those will be in the ADT Scene frame. (b) other GT data such as object 2D bounding boxes won't have the same time range since MPS start and end times will be different from that of ADT GT. However, I do not think you need to use ADT tools. You should be able to load your VRS file directly with the VrsDataProvider and load the trajectory with the TrajectoryReader, then you can query the VRS using the trajectory to get the images that correspond to trajectory measurements.

It would be possible for us to generate the sparse 3D point clouds for ADT data in ADT's Scene frame, however, it would take some work so we would like to understand your need a little more to decide on the priority of this request vs others. Can you please tell us a little more about why you would like this data? Note that we do have full depth maps already as part of the ADT data. Would this work for you instead of the semi-dense depth maps?

Hi @nickcharron, thanks for your response

I'll try what you mention. At the end of the day, I need to have the full depth map, the RGB image and the sparse reprojection of the 3D point clouds all synchronized. But I think the depth maps would not be affected by the time ranges.
Sure! I'm interested in estimating the full depth maps using the information provided by the aria devices. Under that configuration, the full depth maps are our annotations. We want to use the reprojected points as an additional sparse input to help estimate the full depth maps.

@cdforigua05 Do you need more feedback, or can we close the issue?

@SeaOtocinclus and @nickcharron I don't need more feedback at this time. Thank you so much for all your help. I'm closing the issue.

Hi @cdforigua05, I'm not sure if you've been following our releases, but I just wanted to inform you that we have  recently released MPS results for ADT sequences, inlcuding semidense pointclouds aligned to the ADT Scene frame. Please see the release notes for v1.3.3. You can download this data using the standard ADT dataset downloader


ActivePerl build broken for 5.18 and 5.20

The build is broken on ActivePerl as shown here: http://code.activestate.com/ppm/App-Sqitch/
I don't really know what the problem is since I am not a Perl hacker. But this is a blocking issue since I do not have access to the last working version of ActivePerl (5.16).
Thank you!

Thanks. I believe I've fixed these issues in 1c6faad4dd6f43fb482915ab732e1415a2b1d9cd and 69614cc54865b8b1efc6ba22fbb9f99f26721cf8. I'll try to get v0.9992 out this week.

Thanks! Looking forward to it!


how use it

hi
i glad to meet this project.
i before use ex3ndr work and this project https://github.com/yarneo/telegram-trivia-bot
now i want use your project but your sample don't work for me i build 0.0.4 with gradle  and success build this library jar file tl - mtproto - api but when use your sample code new apistorage have a problem plz provide clean sample code
sorry for bad english
best regard.

Updated README with a working sample, to sendCode to phoneNumber, send signIn, and get recent conversations.
You'll need to create your 'C' class to supply all the necessary fields (such as phone number, api id, api hash, ...)
Please use
compile 'com.github.badoualy.kotlogram:api:cbeb0b8caf' for now, I'll release 0.0.5 soon.


Use absolute path to fix use in no_std crate

In a no_std crate enabling std with extern crate std, the std prelude is not available, only the core one. This change makes the derive works in those situations.

Thanks!


CLI Wrapper leads to confusion for inexperienced programmers

https://github.com/Leibniz-HBI/smormlpy/blob/fdf5624f16abf19f6ba459ce0df89ca112f0c1ac/{{ cookiecutter.project_slug }}/{{ cookiecutter.project_slug }}/main.py#L6
Can we find a different solution for this? If pdoc3 is not compatible with click, maybe we should use something else?

Actually IMHO we should enforce a decoupling between our tools' implementation and the UI (click in this case) even more:

decorated functions are per se click.Command or click.Group and can e.g. only be used in testing in conjunction with the click.CliRunner but not as normal python function.
additionally we may want and IMHO should expose functionality in our packages as a python API and again this is not possible if we implement our business logic in the UI.

May be we should further expand on these issues in the documentation?

We arrive at best practices from project to project, I'd say. IMO this cannot be predicted, conceptualized in advance.
From my understanding, smormlpy was meant for CLIs only. Our best practice is click there, so rather then decoupling I'd rather start a new template for other UIs.

To answer the questions: Yes, we might want to discuss this from time to time in the MRML meeting, but the best place to discuss best practices is here in the issues, I think.

Regarding usability, if we want to further down this road, it has to be better documented for newbies. Also, the problem with the implemented function is right now, that parameters have to be updated in the internal click function if any are added to the implementation function. This might be solvable by a generated internal function, but that starts to feel like overkill.

We arrive at best practices from project to project, I'd say. IMO this cannot be predicted or conceptualized in advance and will change over time anyway.
From my understanding, smormlpy was meant for CLIs only. Our best practice is click there, so rather then decoupling I'd rather start a new template for other UIs. Or do you mean decoupling within a project? That would make sense. (Edit: I think that's what you meant, so yeah, go ahead, if so.)

Yup, I was speaking of internal decoupling and speaking of the command line interface as a user interface... not a graphical interface. Decoupling in this context IMHO is paramount, as it actually makes testing and maintaining the implementations easier.

This might be solvable by a generated internal function, but that starts to feel like overkill.

Agreed, although the click-wrapped function and the actual implementation do not need to be 100% mirrors of one another. E.g. in dabapush all of the internal logic is encapsulated in a class and the CLI calls the appropriate methods of the invoked command. tegracli on the other hand does the internal logic in async functions which are run inside the click command (which coming to think about it, may be not within our best practice).

After looking at it: docstrings and implementation is not in sync. Will clarify and fix it.


TypeError: ngtools.PathsPLugin is not a constructor

OS
Linux
Versions
angular-cli: 1.0.0-beta.22
node: 7.2.0
os: linux x64
Repro steps
I was able to reproduce the issue using a completely new project, using 1.0.0-beta.22
ng new testproj
cd testproj
npm test

The log given by the failure
$ ng test
ngtools.PathsPlugin is not a constructor
TypeError: ngtools.PathsPlugin is not a constructor
    at getWebpackTestConfig (/home/maistho/prog/testproj/node_modules/angular-cli/models/webpack-build-test.js:63:9)
    at init (/home/maistho/prog/testproj/node_modules/angular-cli/plugins/karma.js:21:25)
    at Array.invoke (/home/maistho/prog/testproj/node_modules/di/lib/injector.js:75:15)
    at Injector.get (/home/maistho/prog/testproj/node_modules/di/lib/injector.js:48:43)
    at /home/maistho/prog/testproj/node_modules/karma/lib/server.js:143:20
    at Array.forEach (native)
    at Server._start (/home/maistho/prog/testproj/node_modules/karma/lib/server.js:142:21)
    at Injector.invoke (/home/maistho/prog/testproj/node_modules/di/lib/injector.js:75:15)
    at Server.start (/home/maistho/prog/testproj/node_modules/karma/lib/server.js:103:18)
    at /home/maistho/prog/testproj/node_modules/angular-cli/tasks/test.js:33:25
    at Class.run (/home/maistho/prog/testproj/node_modules/angular-cli/tasks/test.js:15:16)
    at Class.run (/home/maistho/prog/testproj/node_modules/angular-cli/commands/test.js:31:25)
    at Class.<anonymous> (/home/maistho/prog/testproj/node_modules/angular-cli/angular-cli/lib/models/command.js:152:17)
    at process._tickCallback (internal/process/next_tick.js:103:7)

Other details that might be useful
It seems that my @ngtools/webpack is at version 1.1.6, and not 1.1.8, which is the newest version.
cat<EMAIL_ADDRESS>Running npm view @ngtools/webpack shows me that 1.1.8 is tagged as 'experimental'. I'm assuming that 1.1.7 or 1.1.8 introduced the PathsPlugin, which seems likely since it was introduced only 9 days ago.
Also, if angular-cli is now depending on the version of @ngtools/webpack to be at least 1.1.8, maybe that should be updated here?

Workaround:
Updating package.json and running npm update solves it.
Added to devDependencies of package.json:
"@ngtools/webpack": "^1.1.8",

Experimental releases are to use at your own risk. Right now Beta 22 is experimental.

Uh.. aren't they all experimental - they're all beta. So how are we expected to use it??


Slovakia - 02 16xxx 041 16xxx

Hello, numbers
02 16xxx
041 16xxx
are valid, but libphonenumber return false.
Validation Results
Result from isPossibleNumber()	true
Result from isValidNumber()	false
Phone Number region	SK
Result from getNumberType()	UNKNOWN
Formatting Results
E164 format	invalid
Original format	0216100
National format	0216100
International format	invalid
Out-of-country format from US	invalid
Out-of-country format from CH	invalid

@pmacko
Thank you for taking the time to improve libphonenumber!
The number 2 16xxx is very short. Is it short code?
What is the type of number 41 16xxx ?
We are unable to find any sample numbers or official evidences for these ranges.
We need more information to fix this. Help us help you! Use our contribution guidelines when reporting issues.

Hello, there are short numbers,
041 16 xxx
41 means Zilinsky kraj (as 41 433 2785 in long numbers)
16 is prefix, they means the short number
xxx is number
This numbers uses z.b. taxis.
02 16 158 - z.b. taxi in Bratislava (02 means Bratislava district)
041 16 111 - number in Zilina district (041)

@pmacko
We need more information to fix this. We can't connect to +4214116111 (from Switzerland 041 16 111). Please see our contribution guidelines for acceptable evidence to allow us to support 041 16xxx.

@penmetsaa means that we tried dialling "+4214116111" from Switzerland, not "041 16 111".

041 16 111 was only an example. Call to 02 16 158 was successful?

@pmacko
That makes sense, I thought you gave 041 16 111 as an example of a working phone number.
I think this looks reasonable and explains the "16" service code at the official documentation: https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000BD0002PDFE.pdf
We'll update the library to support your use case. Thanks for reporting!

@pmacko
Fixed in release 7.2.5: https://libphonenumber.appspot.com/phonenumberparser?number=02+16+158&country=SK


Cocoapod unable to install version 8.4.0

CocoaPods could not find compatible versions for pod "Flurry-iOS-SDK/FlurrySDK":
In Podfile:
Flurry-iOS-SDK/FlurrySDK (= 8.4.0)
None of your spec sources contain a spec satisfying the dependency: Flurry-iOS-SDK/FlurrySDK (= 8.4.0).

I too am having this issue, did you ever resolve it?

I have the same issue


[BUG REPORT] Cannot run bark voice generation with cloning

Describe the bug
When I click on the generate button after setting up cloning, an exception is reported in the console which stops the generation
To Reproduce
Steps to reproduce the behavior:

Setup the bark model
Setup voice cloning
Click generate

Expected behavior
I expect a tts generation
Additional context
I've copied the stack trace below, I updated and then tried to run this fresh 10 minutes ago, it was working previously but that version was a couple of weeks old
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/hydra/experimental/initialize.py:43: UserWarning: hydra.experimental.initialize() is no longer experimental. Use hydra.initialize()
  deprecation_warning(message=message)
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/hydra/experimental/initialize.py:45: UserWarning:
The version_base parameter is not specified.
Please specify a compatability version level, or None.
Will assume defaults for version 1.1
  self.delegate = real_initialize(
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/hydra/experimental/compose.py:25: UserWarning: hydra.experimental.compose() is no longer experimental. Use hydra.compose()
  deprecation_warning(message=message)
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/hydra/core/default_element.py:124: UserWarning: In 'config': Usage of deprecated keyword in package header '# @package _group_'.
See https://hydra.cc/docs/1.2/upgrades/1.0_to_1.1/changes_to_package_header for more information
  deprecation_warning(
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/fairseq/checkpoint_utils.py:425: UserWarning:
'config' is validated against ConfigStore schema with the same name.
This behavior is deprecated in Hydra 1.1 and will be removed in Hydra 1.2.
See https://hydra.cc/docs/1.2/upgrades/1.0_to_1.1/automatic_schema_matching for migration instructions.
  state = load_checkpoint_to_cpu(filename, arg_overrides)
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/hydra/compose.py:56: UserWarning:
The strict flag in the compose API is deprecated.
See https://hydra.cc/docs/1.2/upgrades/0.11_to_1.0/strict_mode_flag_deprecated for more info.

  deprecation_warning(
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/hydra/experimental/initialize.py:43: UserWarning: hydra.experimental.initialize() is no longer experimental. Use hydra.initialize()
  deprecation_warning(message=message)
/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/hydra/experimental/initialize.py:45: UserWarning:
The version_base parameter is not specified.
Please specify a compatability version level, or None.
Will assume defaults for version 1.1
  self.delegate = real_initialize(
/home/[USER]/dev/audio-webui/webui/modules/implementations/patches/bark_custom_voices.py:35: UserWarning:
'config' is validated against ConfigStore schema with the same name.
This behavior is deprecated in Hydra 1.1 and will be removed in Hydra 1.2.
See https://hydra.cc/docs/1.2/upgrades/1.0_to_1.1/automatic_schema_matching for migration instructions.
  huberts['hubert'] = CustomHubert(hubert_path)
Loading Custom Tokenizer
Extracting semantics
Tokenizing semantics
Traceback (most recent call last):
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/gradio/routes.py", line 437, in run_predict
    output = await app.get_blocks().process_api(
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/gradio/blocks.py", line 1352, in process_api
    result = await self.call_function(
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/gradio/blocks.py", line 1077, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/anyio/to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/gradio/helpers.py", line 602, in tracked_fn
    response = fn(*args)
  File "/home/[USER]/dev/audio-webui/webui/ui/tabs/text_to_speech.py", line 81, in _generate
    response, file = loader.get_response(*inputs, progress=progress)
  File "/home/[USER]/dev/audio-webui/webui/modules/implementations/ttsmodels.py", line 210, in get_response
    _speaker = self.create_voice(temp_file.name, clone_model)
  File "/home/[USER]/dev/audio-webui/webui/modules/implementations/ttsmodels.py", line 42, in create_voice
    fine_prompt = generate_fine_from_wav(file)
  File "/home/[USER]/dev/audio-webui/webui/modules/implementations/patches/bark_custom_voices.py", line 88, in generate_fine_from_wav
    encoded_frames = model.encode(wav)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/encodec/model.py", line 144, in encode
    encoded_frames.append(self._encode_frame(frame))
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/encodec/model.py", line 161, in _encode_frame
    emb = self.encoder(x)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/encodec/modules/seanet.py", line 144, in forward
    return self.model(x)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/container.py", line 217, in forward
    input = module(input)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/encodec/modules/conv.py", line 210, in forward
    return self.conv(x)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/encodec/modules/conv.py", line 120, in forward
    x = self.conv(x)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1538, in _call_impl
    result = forward_call(*args, **kwargs)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 313, in forward
    return self._conv_forward(input, self.weight, self.bias)
  File "/home/[USER]/dev/audio-webui/venv/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 309, in _conv_forward
    return F.conv1d(input, weight, bias, self.stride,
RuntimeError: Input type (torch.FloatTensor) and weight type (torch.cuda.FloatTensor) should be the same or input should be a MKLDNN tensor and weight is a dense tensor

oh nvm i see, it's got the audio on cpu, but the encodec model is on gpu.

I just made the wrong assumption to assume that encodec wouldn't be on gpu during offloading. But i guess encodec doesn't get offloaded because it's so small?


Add hash command and update mods betaupdate

This pull request adds a new command called "hash" to the mods.js file. The "hash" command allows users to get the hash and other information of a mod by providing the link to the mod file. Additionally, the pull request includes updates to the mods betaupdate command to fix the issue of the new version not being shown in the chat message.

auto genned pr description /hj


Added dependencies call for macOS build instructions

Added retrieve dependencies command for macOS build.  No open issues found for this commit.
Required for all PRs:

[ ] CHANGELOG.md updated - Instructions updated for building Transporter on macOS
[ ] README.md updated (if needed)

Closing this in favour of https://github.com/compose/transporter/pull/512 (go mod instructions). Thanks!


[Jenkins 21880] weblogic deployer plugin support

New rebased/updated version of PR https://github.com/jenkinsci/job-dsl-plugin/pull/158:
This pull request adds support for the weblogic-deployer-plugin:
publishers {
	deployToWeblogic {
		// these are the default values used for optional fields, when not overridden by closure
		mustExitOnFailure false
		forceStopOnFirstFailure false
		deployingOnlyWhenUpdates false

		deployedProjectsDependencies ''

		deploymentPolicies {
			// multiple policies allowed
			// policy WeblogicDeploymentPolicies.SCM_CHANGE
			// policy WeblogicDeploymentPolicies.USER

			// default: no policies set
		}

		// required one
		task {
			// required
			weblogicEnvironmentTargetedName 'dev_environment'
			// required
			deploymentName 'myApplicationName'

			deploymentTargets 'AdminServer'

			// required
			builtResourceRegexToDeploy 'myApp\\.ear'
			// required
			baseResourcesGeneratedDirectory ''
			// required
			taskName 'Deploy myApp to DEV Server'

			jdkName ''
			jdkHome ''
			jdkProperties ''

			// one of: WeblogicDeploymentStageModes
			stageMode WeblogicDeploymentStageModes.BY_DEFAULT
			commandLine ''
			deploymentPlan ''
		}

		// multiple tasks allowed
		// NOTE: artifacts get deployed in order of definition!
		task {
			//...
		}
	}
}

Ready for review and merge.

I'll do more work on your review comments tomorrow. thx for the fast feedback!

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

it took me some time, but now i'll try again


Missing nested fields sometimes return "NA" for the content

Missing fields should be null or missing from the response object in JSON form. However, sometimes with nested expansions, they are the string "NA".
This is the smallest statement I can find to create the "NA" response. It seems to have something to do with an exact index in replyTo[0] and the expansion index in comments[*].text. (This uses the usual user_comments test collection in mongo.)
💪 $ SELECT comments[*].text, comments[*].replyTo[0] from `user_comments`;
 text       | 1          |
------------|------------|
 I concur.  |  9817361.0 |
         NA |  9654726.0 |

Tracked here


Add Mock Data files

We should aim to provide our own mock data files, as we do in the customer-admin-fe repo, and utilize them properly inside our test coverage files.
Test data should be written to instantiate classes and use proper types where applicable.
Examples of mock data we will need:

mock Business data

will be used to improve tests for BusinessForm components and BusinessDetails component

mock Payment data

will be used to improve tests for payments-list and payment-details

mock Payout data

will be used to improve tests for payouts-list and payout-details

Marking this issue as closed.
We've landed on a different approach - as covered in #334 and #331 by @TiagoFuelber
We are implementing mock data via mockResponse.json files.
We will follow the same pattern to mock business data when refactoring those components.


Deposit form: Inconsistent CKEditor features available in description field

Describe the bug
The CKEditor fields are not consistent for description/additional description fields. See screenshot.
Expected behavior
Same CKEditor buttons are available in both editor windows.
Screenshots (if applicable)

Related to https://github.com/inveniosoftware/invenio-app-rdm/issues/1942, this should be fixed since the related PRs have been merged.


while reading tf record

this error
Feature: target (data type: string) is required but could not be found.
[[{{node ParseSingleExample/ParseExample/ParseExampleV2}}]]

Hi, thanks for opening the issue.
This error is a result of removing the previous data source. TFRecords were stored in a privately owned GCS Bucket and currently, that bucket is disabled. I would  suggest you to

generate new data  and tfrecord with this notebook
keep them in kaggle public/private dataset a good discussion can be found here
use that dataset as GCS path  in this old training script

Cell No:6 Markdown -Section: FIXED PARAMETERS


Storage: (Refactor) Separate ingest impl out

Signed-off-by: Wish<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: ref #5831
What is changed and how it works?
Move ingest related impl into a standalone file.
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/merge


Game introduction

Proper introduction when starting a new save file, something like "Welcome to the world of ROMphonix". Currently there is only a dialog box asking for the player name.

The old Game Maker version has an introduction where it also asks for the player's appearance from 8 different options. The code for this is partially implemented. The sprites from the old game will have to be converted to the new spritesheet.

Intro is done to the point where I can now focus on other things.
The cutscene where the "Champion" dreams of getting the Samsung D307 is incomplete, but it's not a top priority for now.


feat: Inject a context object to validators

ValidationContext is a read-only object that describes the feed as
a whole and also some system properties relevant for validation.
Any validator may request to inject ValidationContext using the usual
@Inject annotation. We chose that instead of modifying the signature of
validate() method because most validators do not need this context and
we want to avoid a huge refactoring.

This addresses the issue first mentioned at https://github.com/MobilityData/gtfs-validator/pull/694#issuecomment-768625303 for a failed compilation at Google due to not passing an explicit timezone.

Thank you, Sean! I resolved the conflicts and uploaded the fresh code.

👍

Thanks a lot!


Rendertron was working perfectly but now i am getting error

503 Over Quota

Error

Over Quota
This application is temporarily over its serving quota. Please try again later.

While fetching this as a bot agent
This application is temporarily over its serving quota. Please try again later.
Any solution?

That's a problem with the application you're rendering. You'd have to ask the administrator of that application what to do about the quota.


eyError: 'asr-inference is not in the pipelines registry group auto-speech-recognition. Please make sure the correct version of ModelScope library is used.'

inference_16k_pipline = pipeline(
task=Tasks.auto_speech_recognition,
model='iic/speech_UniASR_asr_2pass-cantonese-CHS-16k-common-vocab1468-tensorflow1-offline'
)
# waveform, sample_rate = soundfile.read("/data/linry/FunASR/asr_example_粤语.wav")
rec_result = inference_16k_pipline(audio_in="/data/linry/FunASR/asr_example_粤语.wav")
print(rec_result)

2024-02-26 18:49:21,770 - modelscope - WARNING - ('PIPELINES', 'auto-speech-recognition', 'asr-inference') not found in ast index file
Traceback (most recent call last):
File "/data/linry/FunASR/1-my/UniASR.py", line 24, in
offline()
File "/data/linry/FunASR/1-my/UniASR.py", line 6, in offline
inference_16k_pipline = pipeline(
File "/data/linry/anaconda3/envs/funasr/lib/python3.10/site-packages/modelscope/pipelines/builder.py", line 170, in pipeline
return build_pipeline(cfg, task_name=task)
File "/data/linry/anaconda3/envs/funasr/lib/python3.10/site-packages/modelscope/pipelines/builder.py", line 65, in build_pipeline
return build_from_cfg(
File "/data/linry/anaconda3/envs/funasr/lib/python3.10/site-packages/modelscope/utils/registry.py", line 198, in build_from_cfg
raise KeyError(
KeyError: 'asr-inference is not in the pipelines registry group auto-speech-recognition. Please make sure the correct version of ModelScope library is used.'

modelscope version is 1.12.0
funasr Version: 1.0.10


Weekly maintainer meeting

Links look good to me!
Can be merged.

Links look good to me!
Can be merged.


xframe_options_exempt not honored once view is cached

I've been having a problem with Mezzanine not honoring xframe_options_exempt after a view has been cached.

Please include more details:

Mezzanine, Django, and server versions
Steps to reproduce the bug
What you expect to happen
What actually happens

Feel free to re-open with the additional info.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/104913

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/105172

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/105192

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/105206


[MM-22937] Fix Edge case by using includes instead of contains

Summary

Fixes an issue where dragging and dropping a file on pre-chromium edge would result in console errors and the overlay not appearing
Edge does not support .contains so replacing it with .includes fixes the drag and drop issue
This issue is only reproducible on pre-chromium edge.

Ticket Link
https://mattermost.atlassian.net/browse/MM-22937

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-5077.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed

@fm2munsh can you fix the tests before we can merge?

@Willyfrog Its the build step failing with some mattermost-redux issue (also seems to be happening on master) not sure whats causing it... but its definitely not related to this PR

Looks like the issue is highlighted here https://mattermost.atlassian.net/browse/MM-23538

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.


pin_compatible boost

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Cf. discussion in #20.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Many thanks, this made it work!


Feature/controllers tests

@edif2008 Context, Describe, When is the same suite wrappers (they call them node containers in ginkgo world). And they exist for the same purpose - to organize the different aspects of code that we are testing hierarchically.
There is no restriction on how you should use them (for example it's ok to use Context inside Describe, or By inside Context, or Describe inside Context.)
The one general rule here is that It (subject node) should be inside Context/Describe (node containers).
That article might help to understand what ginkgo does under the hood.


MAF-24 Update logo and name for application in Android Studios.

Hey i updated the name because this is not a functional requirement, thats where the MAF/ MA numbering comes from (the SRS).   I dont think we will need to number this.


What difference between AddIdentityServerAuthentication and AddJwtBearer #777

hi , raw issues address is https://github.com/DuendeSoftware/IdentityServer/issues/777  ,can you help me.

Looks like Dom & Brock have responded with some useful links! Let me know if you had any further questions 🙂


Define and Expose a CDS-Based Travel Data Model

Tutorial URL: https://developers.sap.com/tutorials/abap-environment-data-model.html
Everything works fine as described in the tutorial.
I have one additional question:
How can I translate the labels of the CDS - UI annotations with the ADT (without SAP GUI & SE63)?
Maybe you can add it to the tutorial.
I don't find any information on it. I not sure if there is an option.
But at the ABAP Cloud Environment is no SAP GUI access. I have only the ADT to do it.
Thanks a lot!
Regards
Jan

Hi @JanRohde80 ,
labels, for e.g. column labels, field Labels, etc. can be specified while creating CDS Views. The column and fields can pick up labels from their corresponding data elements. This ensures that the translations for the data element labels are available to the fields and thus no separate translation needs to be done.
However, it is also possible to add fields in field lisst as literals that do not refer to any data element in particular. In such cases, the field labels can still be specified using the Annotation “@EndUserText.label:”
I hope, I could help you.
Best regards,
Merve

Hi Merve,
sorry, that doesn't help. I know how to define labels and how to create
data elements. But I find no way to translate the texts in ATD (ABAP in
Eclipse). As I described, in the ABAP Cloud Environment i have no SAP GUI
access. So my question stay: How can I add different languages to my own
appliaction in the ABAP Cloud Environment incl. CDS View Labels, UI Labels,
Data Elements, Messages etc.? (without SAP GUI, only with ADT)
Otherwise I can't write a custom application on the SCP - ABAP Cloud
Environment in my company context, because german and english are mandatory
languages for each application.
Thank you!
Regards
Jan
Am Fr., 21. Feb. 2020 um 10:37 Uhr schrieb Merve Temel <
<EMAIL_ADDRESS>
Hi @JanRohde80 https://github.com/JanRohde80 ,
labels, for e.g. column labels, field Labels, etc. can be specified while
creating CDS Views. The column and fields can pick up labels from their
corresponding data elements. This ensures that the translations for the
data element labels are available to the fields and thus no separate
translation needs to be done.
However, it is also possible to add fields in field lisst as literals that
do not refer to any data element in particular. In such cases, the field
labels can still be specified using the Annotation “@EndUserText.label:”
I hope, I could help you.
Best regards,
Merve
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SAPDocuments/Tutorials/issues/4644?email_source=notifications&email_token=AOP6XOOPLIRLNF7BJQ37BHLRD6OFNA5CNFSM4KWEJHR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMSDLNA#issuecomment-589575604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOP6XOOKU6CLA4NS5PW5GBLRD6OFNANCNFSM4KWEJHRQ
.

Hi @JanRohde80 ,
sorry for the misunderstanding. For translations, we also have this mission: https://developers.sap.com/mission.abap-dev-factory-calendar.html. This mission describes how to add translations for public holidays in a factory calendar. In tutorial: https://developers.sap.com/tutorials/abap-environment-text-table.html in step 4.9 you learn how to add a translation for a public holiday.
Is this what you are looking for?
I hope, I can help you.
Thank you.
Best regards,
Merve

@JanRohde80 Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.

@mervey45 Can you provide a link to a tutorial solving the problem described here? In the first I can not the creation of texts for labels and the link to the second is dead.


"Imperial Red": Mono-specific changes for HttpClient

This PR brings a few Mono-specific changes that are required to adopt the HttpClient from CoreFX.

MCS compilation in HttpConnectionPool.
BTLS does not support certificate revocation checks.
AppleTls does not support the X509Chain.
We do not allow Ssl2 and Ssl3.

TODO:

[ ] SocketsHttpHandler_ConnectionUpgrade_Test
[ ] SocketsHttpHandler_ExternalConfiguration_Test
[ ] HttpEnvironmentProxyTest /HttpProxy_Uri_Parsing

@marek-safar Should we upstream the HttpClientHandler_ServerCertificates_Test and GetAsync_NoSpecifiedProtocol_DefaultsToTls12 changes (doing so would require us to also do PlatformDetection).

@baulig no, it's not necessary


ImportError: cannot import name Celery

Symptom
  File "/home/user/env/project/local/lib/python2.7/site-packages/django/apps/config.py", line 116, in create
    mod = import_module(mod_path)
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/user/workspace/project/project/taskapp/celery.py", line 4, in <module>
    from celery import Celery
ImportError: cannot import name Celery

Cause
invoking  from celery import Celery  from within taskapp/celery.py
A solution
rename taskapp/celery.py to something that does not clash such as taskapp/celery_settings.py
and update settings/base.py

@thanos we don't support Python 2.x anymore.

Thanks - I missed that minor point - but despite this small issue all running well... ... I'll upgrade though.

Thank you for sharing this @thanos - I would not have known how to fix if not for your solution.  Also, I am using Python 3 so I'm not sure how that is related?  This problem happened for me too.


disk-smart: redundant Info in Output

In GitLab by @markuslf on Mar 27, 2020, 08:30
  - Attributes: The temperature of drive is higher than 50 degrees Celsius. This may shorten its lifespan and cause damage under severe load. Please install a cooling solution.
  - Statistics: The temperature of the drive is higher than 50 degrees Celsius. This may shorten its lifespan and cause damage under severe load. Please install a cooling solution.```

Get's clearer when disk-smart will be divided into more specialized checks.


Removed unused DEFAULT_ERROR constant

As stated by @lewart in the #393 DEFAULT_ERROR constant is no longer used.

Thank you

Thank You again for lighting-fast reaction :rocket: