[CP Staging] Add freezeScreenWithLazyLoading function

Details

This PR fixes the issue with flickering central pane screens.
Fixed Issues

$ https://github.com/Expensify/App/issues/44419
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Launch New Expensify app.
Go to any chat with a submitted expense.
Click on the expense preview.
Click on the back button.
Verify if the page is rendered without flickering.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/47774969/0cf61ff9-71c1-4f60-90d0-ae4507f9e3da

Android: mWeb Chrome

https://github.com/Expensify/App/assets/47774969/3b15e65c-729f-4465-a926-41a70ba99178

iOS: Native

https://github.com/Expensify/App/assets/47774969/83b585ef-ce78-41a9-ac10-82285a3f0b76

iOS: mWeb Safari

https://github.com/Expensify/App/assets/47774969/bc8d0d93-e724-4a1c-ba80-10bdebc0402f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/47774969/3784e99b-153a-4f37-b868-5a69fbacc6dc

MacOS: Desktop

https://github.com/Expensify/App/assets/47774969/90e5911c-67b7-4fa9-93d5-37fd3ff2c67f

https://github.com/Expensify/App/assets/36083550/f4e34fe4-3212-4698-8416-bb648e963073
tested and ios worked

The issue with the popover is also fixed https://github.com/Expensify/App/assets/36083550/e59ebbb1-0338-458b-a4d6-335915c83e01

Thanks! I am going to CP this to staging as its really annoying bug :D
@ZhenjaHorbach what exactly is wrong in the video/ which second?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Yeah I think we are tracking the orientation of the animations elsewhere. Its a bit tricky

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.2-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Wait event: Hide text box setting doesn't save

This seems to be a bigger issue with settings not saved as shortcode parameters if they are "false". This is because the default saving implementation of shortcode makes a check for the value before saving it.

So the problem here is that the shortcode saver should try to not save the setting when it's at it's default value. However I have not yet found a good way to modularly get the default value of a variable from a script.

What about a setget? (no idea, just thought it might help 😅 )

I will try again later with Script.get_property_default_value()


getting error when i try to bootstrap firebase

i get the following error when i try to bootstrap firebase
Error loading http://localhost:4200/angular2/core as "angular2/core" from http://localhost:4200/vendor/angularfire2/angularfire2.js
this is my code in main.ts
import {FIREBASE_PROVIDERS, defaultFirebase, AngularFire} from 'angularfire2/angularfire2';
bootstrap(App,[
ROUTER_PROVIDERS,
FIREBASE_PROVIDERS,
defaultFirebase('FIREBASE_URL')
]);

What version of AngularFire2 and Angular2 are you using?

i am using
"angularfire2": "^2.0.0-alpha.17",

Can you try the latest in beta0? And make sure to upgrade to "@angular/core":  "2.0.0-rc.1".


CloudWatch log blocked with AWSSDKHandler.RegisterXRayForAllServices();

We've integrated this NuGet into a NetCore API, 3.1 app. We have followed the guides in the docs.  And we have experienced the following behaviours
We are unable to call AWSSDKHandler.RegisterXRayForAllServices(); as we see no logs emitted to CloudWatch. We believe there is a bug here.
Calling register for each AWS service, blocks cloud watch logs
AWSSDKHandler.RegisterXRay<>();
AWSSDKHandler.RegisterXRay<>();
AWSSDKHandler.RegisterXRay<>();
AWSSDKHandler.RegisterXRay<>();
AWSSDKHandler.RegisterXRay<>();
Calling register for one AWS service, logs to cloud watch
AWSSDKHandler.RegisterXRay();
Calling register manifest, logs to cloud watch
AWSSDKHandler.RegisterXRayManifest(Path.Join(AppDomain.CurrentDomain.BaseDirectory, "DefaultAWSWhitelist.json"));
We are using all the latest versions for relevant packages, 2.7.3.  Are there any know issue with AWSSDKHandler.RegisterXRayForAllServices().

We are facing the same issue as well.


Tidy up into Cargo workspace & refactor for easier testing (WIP)

Cargo workspace
I decided to create a cargo workspace out of this repo and split up the examples from the radix-event-stream crate. Cargo allows examples to live inside of crates so you can run them using cargo run --example <name>, but it is a bit limited when it comes to including a bit more library code as supplement to the examples (like some event declarations). Also, dependencies need to be added to dev-dependencies. Some of the examples are a bit more complex, so I decided it might be better to split that up into its own crate, with binary targets. I did just that.
Refactoring for easier testing
I refactored most of the transaction processing code out of the TransactionStreamProcessor into a new TransactionProcessor struct. It handles processing single transactions, and also uses that to process a vec or slice of transactions. It pretty much does most of what TransactionStreamProcessor used to do, but without a TransactionStream, allowing you to just pass in the transactions. Then, TransactionStreamProcessor uses an instance of TransactionProcessor with a TransactionStream to process transactions from a stream
Before:
Responsibilty of TransactionStreamProcessor:

used by the user
ties everything together
gets transactions from a stream and calls transaction handlers on them
inspects return values and handles retries
calls logging hooks

After:
Responsibilty of TransactionStreamProcessor:

used by the user
ties everything together
gets transactions from a stream and gives them to TransactionProcessor for processing

Responsibilty of TransactionProcessor:

calls transaction handlers on passed in transactions
inspects return values and handles retries
calls logging hooks

This allows you to skip using a TransactionStream and use the TransactionProcessor directly, passing in transactions, having it give back control when it's done.
At first, I implemented functions called process_n and process_until_empty on TransactionStreamProcessor, but I found that the experience for testing could be improved by refactoring the processing logic out and bypassing the channel stream. I also suspect it will become easier to test the processing logic down the line.
See https://github.com/ociswap/radix-event-stream/blob/workspace/crates/examples/src/bin/batching.rs for an example of a test using TransactionProcessor directly.

@Krulknul looks good now thx 👍
One last thing, I think I would use underscores for crate names instead of hyphens. Is probably more consistent. Read somewhere that it is also kind of recommended.

@Krulknul looks good now thx 👍
One last thing, I think I would use underscores for crate names instead of hyphens. Is probably more consistent. Read somewhere that it is also kind of recommended.

I think I would be against that for now, since the name of the create was already radix-event-stream, and also the fact that the repo is named that way. Looked around online and couldn't really find a clear consensus on which is better.

@Krulknul yes the repo is named that way and would keep that. However, Rust automatically converts hyphens to underscore in crate names if you are importing them. So that’s why I think it makes more sense to use underscore in the crate name

@Krulknul yes the repo is named that way and would keep that. However, Rust automatically converts hyphens to underscore in crate names if you are importing them. So that’s why I think it makes more sense to use underscore in the crate name

Alright, I don't really have a strong opinion about it but I changed it now

@fpieper Thanks!


Textbox.js in 5.24.0 throw Error

version: 5.24.0
the Textbox.js in package.json not an executable javascript file.
Just see the last line.

'use strict';

Object.defineProperty(exports, "__esModule", {
  value: true
});

var _createIcon = require('./util/createIcon');

var _createIcon2 = _interopRequireDefault(_createIcon);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

exports.default = (0, _createIcon2.default)('M14,17H7V15H14M17,13H7V11H17M17,9H7V7H17M19,3H5C3.89,3 3,3.89 3,5V19A2,2 0 0,0 5,21H19A2,2 0 0,0 21,19V5C21,3.89 20.1,3 19,3Z');0,0 14,4H12V2H14.5C15.05,2 16,2.45 16,3C16,2.45 16.95,2 17.5,2H20V4H18A1,1 0 0,0 17,5V7M2,7H13V9H4V15H13V17H2V7M20,15V9H17V15H20Z');

Fixed in v5.24.1

@leMaik i think v5.24.1 has some breaking changes. importing the icons are returning undefined for me.

sorry i mean 6.13.1 on npm

I have a similiar issue:
[ warn ]  ./node_modules/mdi-material-ui/TextBox.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:

Happens with most recent 6.13.1 and  @mdi/svg": "^5.0.45

@ArcadeRenegade Indeed, there were breaking changes in Material Design Icons 5.x, just use the older version of mdi-material-ui if you need older icons.
@dohomi That issue is not related.


clock_configure() doesn't remember the real frequency

just the input frequency is stored in configured_freq.
Therefore please change to:
    // Store the configured frequency
    configured_freq[clk_index] = (uint32_t)(((uint64_t) src_freq << 8) / div);

Your message is lacking context, so I assume you're talking about this function?
Is the concern here the "real frequency" differing from the "requested frequency" because of the 24.8 fractional divider?
Rather than change the line where the configured_freq is updated, perhaps it makes sense to add:
// Calculate the actual frequency that will be used
freq = (uint32_t) (((uint64_t) src_freq << 8) / div);

immediately after https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_clocks/clocks.c#L51 ? :man_shrugging:

Of course of course, I thought when I write "clock_configure()" as title and there is just one function with this name in the complete SDK, the context is clear? :)
Yes fixing it this way would make it more readable. The result will be the same, namely that clock_get_hz() returns a the frequency which is set


[BUG] sending batch every minute but still gets error intermittently "The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'"

Describe the bug
I am sending a message batch to eventhub via EventHubProducerClient every Minute. But still intermittently the link tracker closes the link stating no activity since 30 minutes (Send or receive)
The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'
Exception or Stack Trace
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SessionHandler - onSessionRemoteClose connectionId[ehub_dev], entityName[MM_9999990000007], condition[Error{condition=null, description='null', info=null}]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SessionHandler - onSessionRemoteClose closing a local session for connectionId[MM_9999990000007], entityName[ehub_dev], condition[null], description[null]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.ReactorConnection - connectionId[MM_9999990000007] sessionName[ehub_dev]: Error occurred. Removing and disposing session.
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.ReactorSession - connectionId[MM_9999990000007], sessionId[ehub_dev], errorCondition[n/a]: Disposing of session.
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SendLinkHandler - onLinkRemoteClose connectionId[MM_9999990000007], linkName[cbs:sender], errorCondition[amqp:connection:forced], errorDescription[The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SendLinkHandler - processOnClose connectionId[MM_9999990000007], linkName[cbs:sender], errorCondition[amqp:connection:forced], errorDescription[The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26]
2021-01-13 18:25:26 [single-1       ] WARN  c.a.c.a.i.RequestResponseChannel - Retry #1. Transient error occurred. Retrying after 60000 ms.
The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26, errorContext[NAMESPACE: ehub_nspace.servicebus.windows.net, PATH: $cbs, REFERENCE_ID: cbs:sender, LINK_CREDIT: 98]
2021-01-13 18:25:26 [single-1       ] ERROR c.a.c.a.i.RequestResponseChannel - cbs - Exception in RequestResponse links. Disposing and clearing unconfirmed sends.
The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26, errorContext[NAMESPACE: ehub_nspace.servicebus.windows.net, PATH: $cbs, REFERENCE_ID: cbs:sender, LINK_CREDIT: 98]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ReceiveLinkHandler - onLinkRemoteClose connectionId[MM_9999990000007], linkName[cbs:receiver], errorCondition[amqp:connection:forced], errorDescription[The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ReceiveLinkHandler - processOnClose connectionId[MM_9999990000007], linkName[cbs:receiver], errorCondition[amqp:connection:forced], errorDescription[The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SessionHandler - onSessionRemoteClose connectionId[cbs-session], entityName[MM_9999990000007], condition[Error{condition=null, description='null', info=null}]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SessionHandler - onSessionRemoteClose closing a local session for connectionId[MM_9999990000007], entityName[cbs-session], condition[null], description[null]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.ReactorConnection - connectionId[MM_9999990000007] sessionName[cbs-session]: Error occurred. Removing and disposing session.
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.ReactorSession - connectionId[MM_9999990000007], sessionId[cbs-session], errorCondition[n/a]: Disposing of session.
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ConnectionHandler - onConnectionRemoteClose hostname[dummy.servicebus.windows.net:443], connectionId[MM_9999990000007], errorCondition[amqp:connection:forced], errorDescription[The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SendLinkHandler - onLinkLocalClose connectionId[MM_9999990000007], linkName[cbs:sender], errorCondition[amqp:connection:forced], errorDescription[The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:9999b13b12345f12a12d, SystemTracker:gateway5, Timestamp:2021-01-13T12:55:26]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ReceiveLinkHandler - onLinkLocalClose connectionId[MM_9999990000007], linkName[cbs:receiver], errorCondition[null], errorDescription[null]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ConnectionHandler - onConnectionLocalClose hostname[dummy.servicebus.windows.net:443], connectionId[MM_9999990000007], errorCondition[null], errorDescription[null]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ConnectionHandler - onConnectionUnbound hostname[dummy.servicebus.windows.net:443], connectionId[MM_9999990000007], state[CLOSED], remoteState[CLOSED]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SendLinkHandler - onLinkFinal connectionId[MM_9999990000007], linkName[ehub_dev]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SessionHandler - onSessionFinal connectionId[MM_9999990000007], entityName[ehub_dev], condition[null], description[null]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SendLinkHandler - onLinkFinal connectionId[MM_9999990000007], linkName[cbs:sender]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ReceiveLinkHandler - onLinkFinal connectionId[MM_9999990000007], linkName[cbs:receiver]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.SessionHandler - onSessionFinal connectionId[MM_9999990000007], entityName[cbs-session], condition[null], description[null]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.handler.ConnectionHandler - onConnectionFinal hostname[dummy.servicebus.windows.net:443], connectionId[MM_9999990000007], errorCondition[null], errorDescription[null]
2021-01-13 18:25:26 [single-1       ] INFO  c.a.m.e.i.EventHubConnectionProcessor - namespace[ehub_nspace.servicebus.windows.net] entityPath[ehub_dev]: Channel is closed.
2021-01-13 18:25:26 [single-1       ] INFO  c.a.m.e.i.EventHubReactorAmqpConnection - connectionId[MM_9999990000007]: Disposing of connection.
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.ReactorConnection - connectionId[MM_9999990000007], errorCondition[n/a]: Disposing of ReactorConnection.
2021-01-13 18:25:26 [single-1       ] INFO  c.a.c.a.i.AmqpExceptionHandler - Shutdown received: ReactorExecutor.close() was called., isTransient[false], initiatedByClient[true]

Repro Steps
Start a code which keeps sending a batch with dummy message to eventhub every minute.
Expected behavior
It should not close the connection by itself if a continuous sending of batch is being done by the process i.e. every 1 minute.
Setup (please complete the following information):

OS: MAC
IDE : IntelliJ
Version of the Library used : azure-messaging-eventhub 5.3.1 and azure-eventhub 3.2.2

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[X] Bug Description Added
[X] Repro Steps Added
[X] Setup information Added

@srnagar can you please take a look?

@srnagar can you please take a look?

@ankygupta9999 I am taking a look at this issue. When you see the error message, can you confirm that the message you tried to send failed or did the message get sent successfully but there were some timeout errors in the logs?

@ankygupta9999 I am taking a look at this issue. When you see the error message, can you confirm that the message you tried to send failed or did the message get sent successfully but there were some timeout errors in the logs?

Most of the times, it connects and sends the message fine but at times, it tries few times based on amqpretry options and not able to connect again.

Most of the times, it connects and sends the message fine but at times, it tries few times based on amqpretry options and not able to connect again.

Hey @ankygupta9999
We will be closing this issue as we have not heard back from you regarding the logs that were asked.
Like @conniey said, we believe the issue should be resolved in the recent versions of the package.
Please feel free to open a new issue if you are still seeing problems


Custom ParameterBindingAttribute: More than one body parameter

I have a very simple T4 in which I just want to write the swagger output in a file using the NSwag.AssemblyLoader (see attached file).
In my WebApi I created a custom ParameterBindingAttribute (the reason is not of interest here).
NSwag seems to have a problem with this scenario because of the way it is implemented:
It searches for Query-Bindings and assumes that every other binding has to be a body parameter binding. And because there can only be one body parameter it refuses work correct when bindings of other types were found.
My proposal is to specifically search for body/query parameters and ignore all parameters that are not of the Type FromBodyAttribute or FromQueryAttribute.
nswag.txt

With the referenced commit, you can now add SwaggerIgnoreAttribute to the parameter so that is ignored, you can also inherit from SwaggerIgnoreAttribute in your custom attribute so that it is always ignored (just create a class SwaggerIgnoreAttribute in your project and inherit from it).

Is this fine for you?

Thanks! This works for me as well. As long as I can run NSwag without throwing Exceptions I'm fine with it.

Will there be a preview build available in nuget that enables me to use this improvement?

The CI feed is here: https://www.myget.org/gallery/nswag-ci

perfect, thanks!

Can you close the issue when it's working for you?


[Python] Timex migration – Base classes for datatypes-timex

Timex migration – Base classes for datatypes-timex
Description
Based on Microsoft.Recognizers.Text.DataTypes.TimexExpression, we migrated
the base classes.
Changes made
The following classes were added into datatypes_timex_expression folder:

date_range
resolution
time
time_range
timex
timex_creator
timex _convert
timex _constants
timex _constraints_helper
timex _date_helpers
timex _format
timex _helpers
timex _inference
timex _parsing
timex _range
timex _range_resolver
timex _regex
timex _relative_convert
timex _resolver
timex _set
timex _value

Based on the changes made, the files and folder structure will be as seen below:

I would add that the implementation is up to date with the one on C#
Differences with C#
The class TimexProperties of C# is Timex here (as in JS) for more clarity
Technology
There are some methods with local imports, to avoid circular importing

@GasparAcevedoZainSouthworks @ceciliaavila , recognizers does not have the copyright headers


Profiler advice is outdated and potentially just wrong

SQL Profile is deprecated and not supported on Azure SQL at all. This content should be revised with advice on extended events or point to extended event documentation, preferably a location with detailed explanations for Azure SQL.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 683b70c5-16bc-6d10-0433-a39a6be16995
Version Independent ID: 9d664ac7-b484-3b5f-f215-613f95fe60ec
Content: Monitor report performance in Power BI - Power BI
Content Source: powerbi-docs/guidance/monitor-report-performance.md
Service: powerbi
Sub-service: powerbi-resource
GitHub Login: @peter-myers
Microsoft Alias: kfollis

Hi @chandleya - this article is about using SQL Server Profiler to trace SQL Server and Analysis Services workloads. It's not about tracing Azure SQL Database workloads.


Cannot use Inception3 model created in previous version in PyTorch 1.6+ (Vision 0.7+)

🐛 Bug
I am completely new to PyTorch and currently familiarizing myself with a project someone else created (and which unfortunately is not open source so I cannot share any code or exported model). With this background, I hope my report is concise enough for you to reproduce my problem.
As far as I understand, model loading in PyTorch should be backwards compatible, i.e. I can use models created in earlier versions of PyTorch in later versions. However, for me this does not seem to be the case for an InceptionV3 network created somewhere around PyTorch 0.4 when I try to run inference with it in PyTorch 1.6 and 1.7 (Torch Vision 0.7.0 and 0.8.0, respectively).
To Reproduce
Steps to reproduce the behavior:

Load Inceptionv3 model created in earlier PyTorch version (e.g. PyTorch 0.4) in PyTorch 1.6 or higher using torch.load().
Switch to evaluation mode using model.eval().
Run inference: output = model(input).

Result: A ModuleAttributeError is thrown saying 'Inception3' object has no attribute 'maxpool1'. Stack trace:
Traceback (most recent call last):
  *** project-specific call hierarchy cut out ***
    output = model(input)
  File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/torchvision/models/inception.py", line 199, in forward
    x, aux = self._forward(x)
  File "/opt/conda/lib/python3.8/site-packages/torchvision/models/inception.py", line 143, in _forward
    x = self.maxpool1(x)
  File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 778, in __getattr__
    raise ModuleAttributeError("'{}' object has no attribute '{}'".format(
torch.nn.modules.module.ModuleAttributeError: 'Inception3' object has no attribute 'maxpool1'

Expected behavior
Inference runs without errors.

Environment
I'm using the docker image pytorch/pytorch:1.7.0-cuda11.0-cudnn8-runtime.
Output from the environment collection script:
Collecting environment information...
/opt/conda/lib/python3.8/site-packages/torch/cuda/__init__.py:52: UserWarning: CUDA initialization: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx (Triggered internally at  /opt/conda/conda-bld/pytorch_1603729096996/work/c10/cuda/CUDAFunctions.cpp:100.)
  return torch._C._cuda_getDeviceCount() > 0
PyTorch version: 1.7.0
Is debug build: True
CUDA used to build PyTorch: 11.0
ROCM used to build PyTorch: N/A

OS: Ubuntu 18.04.5 LTS (x86_64)
GCC version: Could not collect
Clang version: Could not collect
CMake version: Could not collect

Python version: 3.8 (64-bit runtime)
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip] numpy==1.19.2
[pip] torch==1.7.0
[pip] torchelastic==0.2.1
[pip] torchvision==0.8.0
[conda] blas                      1.0                         mkl
[conda] cudatoolkit               11.0.221             h6bb024c_0
[conda] mkl                       2020.2                      256
[conda] mkl-service               2.3.0            py38he904b0f_0
[conda] mkl_fft                   1.2.0            py38h23d657b_0
[conda] mkl_random                1.1.1            py38h0573a6f_0
[conda] numpy                     1.19.2           py38h54aff64_0
[conda] numpy-base                1.19.2           py38hfa32c7d_0
[conda] pytorch                   1.7.0           py3.8_cuda11.0.221_cudnn8.0.3_0    pytorch
[conda] torchelastic              0.2.1                    pypi_0    pypi
[conda] torchvision               0.8.0                py38_cu110    pytorch

Additional context
Judging from the functions in the stack trace, the presumed backwards incompatibility was probably introduced in the refactoring of the InceptionV3 module in #2287 as there was no self.maxpool1 before.
In PyTorch 1.5.1 (Vision 0.6.1) and earlier, everything works fine.
Thank you in advance!

@Stehsegler what do you load with torch.load, complete model and not its state_dict, right ?
As maxpool does not contain any parameters, so the change introduced in #2287 should not impact stored weights.

Thank you very much for your quick response! Yes, I was loading the complete model. Indeed, I got it up and running by exporting the state_dict from PyTorch 1.5.1 and importing that into PyTorch 1.7.0.
So does that mean backwards compatibility for model loading is only given for state_dicts, but not for complete models? Is that documented somewhere?
Comparing the print()ed models, it becomes obvious that four new layers have been added in between 1.5.1 and 1.7:
...
  (maxpool1): MaxPool2d(kernel_size=3, stride=2, padding=0, dilation=1, ceil_mode=False)
...
  (maxpool2): MaxPool2d(kernel_size=3, stride=2, padding=0, dilation=1, ceil_mode=False)
...
  (avgpool): AdaptiveAvgPool2d(output_size=(1, 1))
  (dropout): Dropout(p=0.5, inplace=False)
...

This brings up a follow-up question: Do the added layers influence the behaviour of the NN in any way? Or more precisely, will models trained with the old behaviour yield reliable inference results in the new version?

So does that mean backwards compatibility for model loading is only given for state_dicts, but not for complete models? Is that documented somewhere?

@Stehsegler please see here : https://pytorch.org/docs/stable/notes/serialization.html

This brings up a follow-up question: Do the added layers influence the behaviour of the NN in any way? Or more precisely, will models trained with the old behaviour yield reliable inference results in the new version, despite the additional layers?

Those added layers should not influence the behaviour in any way between versions. They are NOT additional as corresponding operations were present in previous version:
https://github.com/pytorch/vision/pull/2287/files#diff-092b74a41e40a59ea3e31d8341e753664c7edf3b45b2c75b7de3772b4ebd0157L139

Thank you once again for your helpful support!

@Stehsegler please see here : https://pytorch.org/docs/stable/notes/serialization.html

Well, that just says using state_dict is recommended for compatibility reasons, which is a rather general statement. Maybe the docs could be improved by adding something more specific with regard to inter-version/backwards compatibility.

Those added layers should not influence the behaviour in any way between versions. They are NOT additional as corresponding operations were present in previous version:
https://github.com/pytorch/vision/pull/2287/files#diff-092b74a41e40a59ea3e31d8341e753664c7edf3b45b2c75b7de3772b4ebd0157L139
More info about reproducibility : https://pytorch.org/docs/stable/notes/randomness.html

Thank you for the clarification. I was already aware of the restrictions with regard to reproducibility and just wanted to rule out the possibility of a systematic error.
I think this issue can be closed.

@vfdev-5 I think it would be useful to add a note in the models documentation pointing to https://pytorch.org/docs/stable/notes/serialization.html and saying that we guarantee compatibility with serialized state-dict, but not if the model is entirely serialized.


feat(AspectRatio): implement component

🔗 Linked issue

None
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

https://www.radix-vue.com/components/aspect-ratio
📝 Checklist

[ ] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

@benjamincanac I decided to move the mini-component. I think it won't hurt. If there are no comments, it can be merged 😊

Why implement this where you can just use a Tailwind CSS aspect ratio class? 🤔 https://tailwindcss.com/docs/aspect-ratio

@benjamincanac Yes, of course, you can use TW, but as I understand it, there are issues with its support in Safari 15, which is still quite popular.

Radix Vue has this because it's not locked into Tailwind, since Nuxt UI has it, I don't think its necessary honestly

Well, okay, luckily I only spent 10 minutes on it. 😊

Maybe I'm wrong, we'll be able to reopen this if so :)


ngResource: Do not update internal data when HTTP status >= 400 on $save.

I don't see documentations on server-side implementations, especially on error handling.
The API I currently working on, upon errors, returns a JSON object {"error": "...", "code": 13362} with HTTP status >= 400, but $resource updates internal data with the error context.
If the server is meant to be implemented in a way it returns the original resource data even upon errors, users would then have no obvious way to handle error message and/or codes.
Can we skip the data update when server returns an error status code?

@vicary, $resource will not update the instance with the response data upon save error. (Demo pen)
It is something else on your end that is causing the weird behaviour (in similar cases it's been usually some interceptor that does not preperly propagate the error).
If you still think there something wrong with Angular itself, please provide a live reproduction (using CodePen, Plnkr etc), so we can investigate further.

Turns out it's one of my global error handlers missed the $q.reject() statement, closing this and thanks for the hint.


Ledger implementation

This might be a great example project to build. Create an implementation of the ledger standard (ICP/SNS/probably most fungible tokens going forward on the IC).
Here's the source code: https://github.com/dfinity/ic/tree/master/rs/rosetta-api/ledger_canister
Here's the did: https://github.com/dfinity/ic/blob/master/rs/rosetta-api/ledger_canister/ledger.did

Implemented ICRC-1 instead here: https://github.com/demergent-labs/ICRC-1


SentinelReplication: Any reason for $retryLimit = 20?

Predis\Connection\Aggregate\SentinelReplication.php

/**
* Max number of automatic retries of commands upon server failure.
*
* -1 = unlimited retry attempts
*  0 = no retry attempts (fails immediatly)
*  n = fail only after n retry attempts
*
* @var int
*/
protected $retryLimit = 20;

Seems too many retries here if getconnection fail. Any reason for this?

A server that failed right away may not be evicted immediatly by sentinels, which means there's a window of a few seconds when you might still get a dead node when asking for the master or a slave. The default retry limit here is kind of arbitrary based on some tests but you can customize it by using the public method SentinelReplication::setRetryWait(). Do you have suggestion, based on tests, of a a more appropriate default value?

Closing due to lack of feedback, but feel free to reopen if needed.

@nrk
"but you can customize it by using the public method SentinelReplication::setRetryWait() "
Shouldn't I able to pass this as connection property ?


fixed: opening source file in non-Western language OS causes source file corruption

I changed it to a unicode literal, \u0192.
Thanks!


[Feature]: User should be able to use readonly GSheet without authentication

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
User should be able to use readonly GSheet without authentication
Why should this be worked on?
Currently inorder to use gsheet user has to authenticate via google. If a google sheet is accessbile publicly he/she should be able to use this sheet without authentication.

will be addressed in #18337


Remove obsolete migration code from the monitoring component

How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
This PR removes the following migration code from the monitoring component:

Migration code from appending the cluster type suffix to kube-state-metrics. Commit https://github.com/gardener/gardener/commit/1e3de9d9b7dcc39fb880a39f00286be38218f571 /cc @chrkl
Migration code for the kube-state-metrics version upgrade. Commit https://github.com/gardener/gardener/commit/bebad977201009a83129b6b3bb679d4be2e437a5
Mitigation for extension dashboards. Commit https://github.com/gardener/gardener/commit/b85e48c364a7f375923c5b7e7132643e748b5fd8 /cc @istvanballok

Release note:
Clean up migration code from the monitoring component

/cc @chrkl @istvanballok

/retest-required

/lgtm


An error related to Pydantic has occurred.

The code that was previously functioning correctly has stopped working. The error code is as follows, and it seems to be related to semantic-kernel:
ImportError: cannot import name 'Url' from 'pydantic.networks' (/home/site/wwwroot/.python_packages/lib/site-packages/pydantic/networks.py)
For the time being, I was able to avoid the error by explicitly specifying "pydantic == 2.9.2" in the "requirements.txt" file, but if there are any better solutions, I would appreciate your guidance.
https://github.com/microsoft/semantic-kernel/issues/9777

I had the same issue and also temporarily fixed it with "pydantic == 2.9.2".
Any updates would be great.
thanks

Thank you for the recent fix to requirements.txt in this repository and in gpt-rag-ingestion.
Separately, I encountered an issue where indexer creation in gpt-rag-ingestion suddenly started failing, and I was unable to determine the root cause. However, your fix seems to have resolved the issue and everything is working as expected now. I'll go ahead and close this issue.
Additional Note:
While I haven't fully identified all contributing factors, it seems that openai==1.55.3 is a requirement for proper functionality.
https://community.openai.com/t/client-openai-returns-error-client-init-got-an-unexpected-keyword-argument-proxies/1035249/5


Improve Brooklyn-management of OSGi-already-managed bundles

Previously could claim it was already installed but not brooklyn-manage it.
Now it is much smarter about checking whether what is being supplied now (by reference or by contents) is an exact match and if so, don't uninstall and reinstall it.
Some annoying issues fixing tests due to how karaf/java deals with target/classes/ bundles in dev, but tests are all working too now.
NB this requires #810 due to conflicts in osgi bundle removal semantics

all addressed -- thx @geomacy, merging


Black Patches in RGB Rendering

While rendering the RGB images, I am encountering black patches in the output. However, the segmentation and depth images appear to be fine.

What GPU are you using? We've observed certain virtualized GPU systems cannot support some rendering processes correctly.


internal error with set crates menu

Spark link
No response
Plugin Version
V2.0
Server Version
1.20.4
Server Platform
Paper
Describe the bug
Hello,
When I try to associate a chest to be the menu, I get this error message. Maybe I made a mistake in the config.yml?
thank you
https://haste.zendrique.fr/hucebiyoya.sql

Crate Type
None
Steps to reproduce

Crazycrate set menu
An internal error occurred while attempting to perform this command
view error message

my config.yml if you need maybe i got wrong edit here  https://haste.zendrique.fr/hucebiyoya.sql

Additional context
No response
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[ ] I ticked all the boxes without actually reading them
[X] My version of Minecraft is supported by CrazyCrew.

Quick update: Plugin installed on a server test with default configuration, the same error message persists.

Fixed in commit

https://modrinth.com/plugin/crazycrates/version/2.0.1 @Draghonir


help(COMPONENT): google-maps

What are you trying to do?
I am trying to resize the map with css. but for some reason no matter what selector combo i use it will not resize past the default.
What troubleshooting steps have you tried?
setting height & width with an ngbind and passing null
`

`
`
//map-component.component.scss
.my-google-map{
    .map-container{
      width: 800px;
      height: 600px;
    }
  }
`
Reproduction
Steps to reproduce:
1.
2.
https://stackblitz.com/edit/components-issue-gvqfbg?file=src/app/google-map/map-component.component.scss
Environment

Angular:
13.3.1
CDK/Material:

Browser(s):
all
Operating System (e.g. Windows, macOS, Ubuntu):
windows

Is that what you are looking for? See StackBlitz.
.my-google-map ::ng-deep .map-container {
  width: 100%;
  height: 500px;
}

Is that what you are looking for? See StackBlitz.
.my-google-map ::ng-deep .map-container {
  width: 100%;
  height: 500px;
}

That worked thank you!!!
I wish that the documentation had that in there. it kinda gives false hope that it should work by just passing null to the width and height values


Support prefix/suffix elements

paper-typeahead-input version: 1.3.15
Polymer version: 1.8.1
paper-typeahead-input does not include <content></content> anywhere, so it is impossible to include prefix/suffix elements. For example:
<paper-typeahead-input>
  <paper-icon-button suffix on-tap="clearSearchbox" icon="clear"></paper-icon-button>
</paper-typeahead-input>

Expected: An "X" icon button on the right side of the search box, which calls clearSearchbox(event) when tapped.
Actual: No button exists
Replacing paper-typeahead-input in the above snippet with paper-input behaves as expected, although of course it's no longer a typeahead!

@Lithl
is the snippet

See http://jsfiddle.net/hr4h65cf/ comparing paper-typeahead-input with paper-input, each with a single paper-icon-button child.


Use TLD other than .dev

Chrome is now preloading HSTS for all .dev domains (details). It would be good to be able to configure a different TLD such as .localhost to avoid HSTS. Pow provides a POW_DOMAINS configuration for this. Is there an equivalent for Prax?

After reading the source, I found the following should work. Would be good to document if it's not already - I couldn't find it.
echo 'export PRAX_DOMAINS=localhost' > ~/.praxconfig


fix(versions): update Activiti/activiti-cloud-infrastructure-chart versions

UpdateBot pushed helm dependency: activiti-cloud-gateway to: 1.0.8

/test this
/approve

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-gateway 1.0.8


feat(connlib): introduce Session::reconnect

I ended up calling it reconnect because that is really what we are doing:

We reconnect to the portal.
We "reconnect" to all relays, i.e. refresh the allocations.

I decided not to use an ICE restart. An ICE restart clears the local as well as the remote credentials, meaning we would need to run another instance of the signalling protocol. The current control plane does not support this and it is also unnecessary in our situation. In the case of an actual network change (e.g. WiFI to cellular), refreshing of the allocations will turn up new candidates as that is how we discovered our original ones in the first place. Because we constantly operate in ICE trickle mode, those will be sent to the remote via the control plane and we start testing them.
As those new paths become available, str0m will automatically nominate them in case the current one runs into an ICE timeout. Here is a screen-recording of the Linux CLI client where Session::refresh is triggered via the SIGHUP signal:
Screencast from 2024-03-14 11-16-47.webm
Provides the infrastructure for: #4028.

Will this be okay if it's called multiple times quickly? The network change detection on Windows is "bouncy". I could probably de-bounce it with a timer if needed, e.g. when we get an event, wait until 1 full second of no events, then tell connlib to refresh / reconnect

It should be okay, see the screen-recording above. We will reconnect to the portal each time it is called but that does not affect the data plane.

Will this be okay if it's called multiple times quickly? The network change detection on Windows is "bouncy". I could probably de-bounce it with a timer if needed, e.g. when we get an event, wait until 1 full second of no events, then tell connlib to refresh / reconnect

It should be okay, see the screen-recording above. We will reconnect to the portal each time it is called but that does not affect the data plane.

I would like it to be okay, i.e. if anything, connlib should de-bounce and not the apps.

LGTM. Should I also call this when the DNS servers change? And after that next DNS refactor is ready, that will be replaced with some more specific "Update DNS only" command?

We will have a dedicated function to update DNS servers.

Merging for now, we can always act upon https://github.com/firezone/firezone/pull/4116#discussion_r1525331398 in a follow-up.


Add GH action to automate running the experiments

Requires composite actions from:

https://github.com/gradle/gradle-enterprise-build-validation-scripts/pull/45/files

Back to draft to incorporate exp 5 before review

PR is ready for review 👍
The objective is to be able to automatically run experiments 1, 2 and 3 on OSS projects.
There are 2 triggers:

scheduled to run all experiments on all project once a week
manual to run one or all experiments on a selected project

@jprinet Would it be useful to use the gradle-build-action to save/restore the Gradle User Home state for these jobs? This could speed up the jobs by avoiding things like recreating generated-gradle-jars, recompiling build scrips, etc.
Note that it's now recommended to separate the "Setup Gradle" and "Run Gradle" steps in your workflow.
If necessary, it's easy to exclude ~/.gradle/caches/build-cache-1 from this process.

@jprinet Would it be useful to use the gradle-build-action to save/restore the Gradle User Home state for these jobs? This could speed up the jobs by avoiding things like recreating generated-gradle-jars, recompiling build scrips, etc.
Note that it's now recommended to separate the "Setup Gradle" and "Run Gradle" steps in your workflow.
If necessary, it's easy to exclude ~/.gradle/caches/build-cache-1 from this process.

To be honest, I'm divided on this one. Most experiments trying to fully build the project from scratch without sharing any data. It's a true point that we could save some time on all Gradle internals, but those jobs are long running anyway.

Most experiments trying to fully build the project from scratch without sharing any data.

Yes, but we don't ask users to delete their Gradle User Home before each experiment. This is effectively what you automation is doing. So all dependencies, Gradle wrappers, JDKs etc are re-downloaded, and local state is re-generated.

Most experiments trying to fully build the project from scratch without sharing any data.

Yes, but we don't ask users to delete their Gradle User Home before each experiment. This is effectively what you automation is doing. So all dependencies, Gradle wrappers, JDKs etc are re-downloaded, and local state is re-generated.

Makes sense, let's reduce data transfer with your suggestion 👍
Will do excluding cache as you mentioned!

Thanks, @jprinet . I'll close the PR given we will go with separate workflows for each OSS project.


Create missing transforms option

Story
As a VRChat avatar creator I want to be able to copy all of my accessories from one avatar to another because otherwise I would have to do it by hand.
Changes
Added a new checkbox to automatically create any missing transforms in the target avatar. It is off by default.
Testing
Works for my Canis Woof avatar which has a bandana accessory and several toggled game objects missing on the target.
Nothing copied:

Checkbox OFF:

Checkbox ON (note bandana is there):

Hey, thanks for the pull request.
I'll merge it next update.


feat/frontend/register

Implemented the following:

register page with graphic (non-responsive to screen size yet)
register form UI (currently non-functional)
button component

To-do:

make it responsive to screen size
best practice using tailwind and flowbite
button animations and micro interactions

Renamed the id's :D @bbcarrots


Refactoring and bug fixes on top of unnest. The allowList now is not passed …

…inside the unnest cursors. Added tests for scenarios such as

filter on unnested column which involves a left filter rewrite
filter on unnested virtual column which pushes the filter to the right only and involves no rewrite
not filters
SQL functions applied on top of unnested column
null present in first row of the column to be unnested

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

Removed a set of tests that involved the allowSet and we now have the ability to pass a filter on the unnested column. Added extra tests in CalciteArraysQueryTest

@gianm I have rolled back and have made the code simpler. The only change is to remove the allowList. Please review when you have time

Something I don't understand with this structuring of the code.  When we look at the actions taken in planning and running these queries we get

SQL is parsed into parse tree and converted to logical DAG
Logical DAG is optimized such that filters are applied to each side of the UNNEST correlate (i.e. Calcite figures out which filters apply to the unnested column (rhs of the LogicalCorrelate with the Uncollect) and which filters apply to the base query (lhs of the LogicalCorrelate with the Uncollect)
We have rules that push all of the filters that Calcite already figured out for us such that they are above theLogicalCorrelate.
We build a native query with the filters all meshed together
The native query then has code that figures out, once again, whether some of the filters can be rewritten to be running against the underlying columns

It seems weird to me that we would explicitly undo the thing that Calcite figured out for us so that we can attempt to re-do it in the native query.
I'd propose that we take a Filter object on the UnnestDatasource.  The UnnestCursor can pretty easily attempt the re-write and pushdown of that RHS filter and also attach it as a ValueMatcher on the read.  This is also seems like a much more natural way to plan the query, no?
Is there some reason that we have to throw away the work that Calcite already did for us only to redo it?

A query like SELECT d3 FROM druid.numfoo, UNNEST(MV_TO_ARRAY(dim3)) as unnested (d3) where d3='b' as Calcite was adding an additional level of project before the filter causing our filter transpose rules to not fire. The calcite plan was
126:LogicalProject(d3=[$17])
  124:LogicalCorrelate(subset=[rel#125:Subset#6.NONE.[]], correlation=[$cor0], joinType=[inner], requiredColumns=[{3}])
    8:LogicalTableScan(subset=[rel#114:Subset#0.NONE.[]], table=[[druid, numfoo]])
    122:LogicalProject(subset=[rel#123:Subset#5.NONE.[]], d3=[CAST('d':VARCHAR):VARCHAR])
      120:LogicalFilter(subset=[rel#121:Subset#4.NONE.[]], condition=[=($0, 'd')])
        118:Uncollect(subset=[rel#119:Subset#3.NONE.[]])
          116:LogicalProject(subset=[rel#117:Subset#2.NONE.[]], EXPR$0=[MV_TO_ARRAY($cor0.dim3)])
            9:LogicalValues(subset=[rel#115:Subset#1.NONE.[0]], tuples=[[{ 0 }]])

Added an additional plan that removes this Project step (which does a CAST). Additional tests introduced for selector filters on STRING and NUMERIC values after unnest

@gianm @cheddar this PR already contains Gian's changes where the filter after rewrite is added to both pre and post filters. Lack of that change is causing queries to give incorrect results. While I work on the changes as suggested by ERic can we get that part merged, if not through this PR but a separate PR


Elements not showing in search bar in ALgebra section

Mathematrcal Reasoning, Operations on sets, Euclid Geometry and Sets,Relations and functions  of the tags arent being shown up in the search bar recommendations

Go ahead
Deadline 9 April,2021 11:59 PM IST


MINOR: Build with Scala 2.12 by default

Scala 2.12 has useful compiler warnings
that are helpful during development. Jenkins
will continue to build all supported Scala
versions (including Scala 2.11) so the PR
builder will fail if people accidentally
use methods introduced in Scala 2.12.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ewencp @hachikuji What do you think?

Thanks for the feedback @ewencp. The reason why I changed kafka-run-class is so that the scripts work during development.

the natural thing to do to upgrade versions is to just provide new 2.11 artifacts and roll, but this would break any deployment where SCALA_VERSION is not explicitly specified

Actually it will not have any impact on binary releases since SCALA_VERSION only matters running code built from source. So, I don't think there's compatibility impact here and hence why I didn't think an upgrade note or KIP was needed. Am I missing anything?

@ewencp I added one commit after your review, does it look OK?

JDK 11 failure is unrelated. Merged to trunk.


Cursor position reset everytime from starting

whenever i try to insert content and emoji it's working properly but issue is when I move to another textarea and return to the textarea where and and emoji was there and when inserting the emoji the cursor position was reset to starting and it cannot recognise the content in the textarea

im having a similar problem


External link to /images removed, was empty.

No touch folder in /images
bad link.

I signed it!

@aranajhonny Thank you for the PR!
@addyosmani @santokii I am torn. Should we

remove the reference to homescreen icon since adding the template itself to the homescreen is a rather pointless usecase
keep it so people think about this when they use the template for something else

I am leaning towards 2 because “leading by example” etc.

I'm for option 2 where possible, but here... I think option 1 is best.
Lead by example will have us putting quite a few things in that aren't needed for the template/library simply because they are encouraged. Developers should be competent and understand what they need without blindly copying and pasting template examples. If we aren't including this with the example, it shouldn't be there. Developers that need it can add it in.

I'm for option 2.

Thinking about this a little more, is it worth us adding in an MDL favicon that we use for the template pages so that this doesn't show up as empty? Something generic.

We do have

favicon.png
ios-desktop.png
android-desktop.png

We could re-use these for simplicity’s sake.

+1 for reusing them then.

Thanks for the PR, @aranajhonny. But as you can tell, we will actually add assets for these icons to be a good example :)


How to disable CoPilot suggestions in COMMIT_EDITMSG?

Hi, great extension, thanks!
I like to write my own commit messages and use vsc as the editor to do so.
My workflow looks like:

git add ... # on command-line
git commit # opens COMMIT_EDITMSG in vsc
write commit msg in vsc, save, close buffer --> commit completes

I would like CoPilot to never make any suggestions when I'm editing a file named COMMIT_EDITMSG. How can I do that?

Hello there, I have just implemented this feature in the fresh-off-the-press 2.0.0 release. The feature is implemented as glob pattern matcher rules, which you can read more about here.
To instruct this Extension to silence Copilot suggestions inside of files named COMMIT_EDITMSG as you so described, the following configuration could be applied:
{
  "disable-copilot-comment-completions.globPatternRules": [
    "**/COMMIT_EDITMSG"
  ]
}

This would instruct the Extension to silence inline suggestions whenever it is discovered that the active selection is contained within a document whose filename is exactly COMMIT_EDITMSG, in any folder.
Thanks for the suggestion, and if you have the time, give the new release of the Extension a try and see if the new feature works for you. And hey, if it does, I would be oh-so-flattered if you were to leave a review, but that's neither here nor there.
Have a good one!

Thanks!

Is it possible that you could publish this extension for vsc 1.73? I'm stuck on 1.73.1 because 1.74 broke Customize UI.


Allow ledger sync disable

i decided I want to add ledger sync disable as a config to next CLM patch since it can have multiple use cases

You can do this in addon code right? Since comms are proxied

This code already exists in the Addon - just needs exposing publicly
through config:
function LedgerManager:Cutoff()     self.activeLedger.disableSending()     Comms:Suspend(LEDGER_SYNC_COMM_PREFIX)     Comms:Suspend(LEDGER_DATA_COMM_PREFIX) end
pt., 8 kwi 2022 o 09:32 Sam @.***> napisał(a):

You can do this in addon code right? Since comms are proxied
—
Reply to this email directly, view it on GitHub
https://github.com/ClassicLootManager/ClassicLootManager/issues/276#issuecomment-1092543679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKIXVTJTAKOB4XFDA5CRY63VD7OHTANCNFSM5S3UUDMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Z wyrazami szacunku
Dolecki Szymon


GPv1 storage account details

Hello,
I thought it would be good to link to https://docs.microsoft.com/en-us/azure/site-recovery/azure-to-azure-support-matrix#cache-storage where GPv1 uses are listed. Microsoft still recommends using GPv1 for site recovery cache accounts because of the lower transactional costs.
Thank you.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06288d35-3c83-c29d-95d8-a56823d910a3
Version Independent ID: 002fb5f5-5e4a-a95a-4564-2c399bcb5e06
Content: Storage account overview - Azure Storage
Content Source: articles/storage/common/storage-account-overview.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

#reassign: @tamram

@jgross1031 Thank you for your feedback . This is being worked on by the content team and they will update the thread soon .

This change is now live. Thanks for the suggestion!
#please-close


modified slot.js to allow for collection drag and drop

modified slot.js to allow for collection drag and drop that then moves user to manifest list view.
Should resolve issue: #941

Coverage decreased (-0.07%) to 41.235% when pulling 8f1dc2e4ac58b5cd5148074adef7f8a61873f091 on jeffreycwitt:feature/collection-drag-and-drop into e8a57399f1b9b72fefaefdbe87fdde7f8e697010 on IIIF:release2.1.

This seems like a good way forward using existing patterns. Although the coverage has decreased, I'm adding going ahead with it since the slot.js d-n-d code needs some serious refactoring to be testable. The different branches seriously need to be broken out into functions.

Hooray!!!
On Wed, Jun 15, 2016 at 3:19 PM, aeschylus<EMAIL_ADDRESS>wrote:

Merged #956 https://github.com/IIIF/mirador/pull/956.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IIIF/mirador/pull/956#event-693716687, or mute the
thread
https://github.com/notifications/unsubscribe/ABF_PVg8AjgCJ0cC_dJEKogS0zyE5Fy0ks5qMFAxgaJpZM4I0t0K
.

--
Dr. Jeffrey C. Witt
Philosophy Department
Loyola University Maryland
4501 N. Charles St.
Baltimore, MD 21210
www.jeffreycwitt.com


Skip output check if output not defined on formatter

If a custom formatter doesn't subclass the BaseTextFormatter it doesn't have the output method, then the duplicate formatter check throws a "undefined method output" error, just PR just skips that part of the check if the output method isn't defined.
Also I've noticed in the documentation for custom formatters that the text recommends subclassing from BaseTextFormatter but the example doesn't show that? I totally just read the code and skimmed the text 😛

Can you add a spec for this?

Heyo just a bump on this, I added a commit but didn't add a comment so perhaps you didn't see it!! I have no idea what the etiquette is here 🙈

Uhhhhh so I see there's a failing spec on JRuby 1.7....unclear whether this is related to my changes or not? The failing test seems unrelated but it is also inspecting the output so I guess it might be related to my changes 🤷♀
Anyways I attempted to install JRuby 1.7.0 to run the cuces locally and got this fun message:
WARNING: jruby-1.7.0 is past its end of life and is now unsupported.
It no longer receives bug fixes or critical security updates.

And also installation didn't succeed because my version of openjdk (17.0.1) is also too new... At which point I gave up! Not sure how to proceed here? There also doesn't seem to be error message for why the test is failing? Perhaps there is no output string outputted? 🤷♀

No worries on the JRuby 1.7 build, it's known to periodically fail on the bisect scenario, e.g https://github.com/rspec/rspec-core/actions/runs/1416457643

Ok... so does this PR need anything else?

Merging despite build failure as its unrelated, thanks @niceking and sorry it took so long to finalise this.


No implicit any check fails for this file in electron-main

Check the following code:
https://github.com/Microsoft/vscode/blob/39012b24631928b528c0e1fb83d28a06d9e6e491/src/vs/platform/history/electron-main/historyMainService.ts#L285
You can hover and see the type is found to be "any", but no error is reported.
It looks like the type can only ever be string, but then the hover should show that too?

Thanks. Opened https://github.com/Microsoft/TypeScript/issues/30899 to track this upstream


ImportError: No module named 'fused'

(MoDi) jijiahui@ubuntu:~/MoDi$ python generate.py --type sample --motions 18 --ckpt ./data/ckpt.pt --out_path ./output --path ./data/edge_rot_data.npy
Traceback (most recent call last):
File "generate.py", line 13, in
from utils.pre_run import GenerateOptions, load_all_form_checkpoint
File "/data/home/jijiahui/MoDi/utils/pre_run.py", line 5, in
from models.gan import Generator, Discriminator
File "/data/home/jijiahui/MoDi/models/gan.py", line 16, in
from op import FusedLeakyReLU, fused_leaky_relu, upfirdn2d
File "/data/home/jijiahui/MoDi/op/init.py", line 1, in
from .fused_act import FusedLeakyReLU, fused_leaky_relu
File "/data/home/jijiahui/MoDi/op/fused_act.py", line 18, in
build_directory=os.path.join(os.path.expanduser('~'),'tmp', 'stylegan_lock'),
File "/data/home/jijiahui/miniconda3/envs/MoDi/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 898, in load
is_python_module)
File "/data/home/jijiahui/miniconda3/envs/MoDi/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 1097, in _jit_compile
return _import_module_from_library(name, build_directory, is_python_module)
File "/data/home/jijiahui/miniconda3/envs/MoDi/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 1418, in _import_module_from_library
file, path, description = imp.find_module(module_name, [path])
File "/data/home/jijiahui/miniconda3/envs/MoDi/lib/python3.6/imp.py", line 297, in find_module
raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named 'fused'

@kfcvme666, there may be several reasons for this issue, all related to package versions.
In this link, the solution was to set Cuda to 11.3 and Pytorch to 1.9.
In this link the solution was to set the GCC version to either 7.5.0 or 5.2.0.
This link offers more solution directions.
Note that the MoDi's equivalent to the folder ~/.cache/torch_extensions/fused (mentioned in the aforementioned solutions), is $Home/mp/stylegan_lock.
Let me know if this helped.

Thank you very much for your help, but then I encountered a new problem：

(MoDi) jijiahui@ubuntu:~/MoDi$ python generate.py --type sample --motions 18 --ckpt ./data/ckpt.pt --out_path ./output --path ./data/edge_rot_data.npy
Traceback (most recent call last):
File "generate.py", line 13, in
from utils.pre_run import GenerateOptions, load_all_form_checkpoint
File "/data/home/jijiahui/MoDi/utils/pre_run.py", line 5, in
from models.gan import Generator, Discriminator
File "/data/home/jijiahui/MoDi/models/gan.py", line 16, in
from op import FusedLeakyReLU, fused_leaky_relu, upfirdn2d
File "/data/home/jijiahui/MoDi/op/init.py", line 1, in
from .fused_act import FusedLeakyReLU, fused_leaky_relu
File "/data/home/jijiahui/MoDi/op/fused_act.py", line 18, in
build_directory=os.path.join(os.path.expanduser('~'),'tmp', 'stylegan_lock'),
File "/data/home/jijiahui/miniconda3/envs/MoDi/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 1092, in load
keep_intermediates=keep_intermediates)
File "/data/home/jijiahui/miniconda3/envs/MoDi/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 1318, in _jit_compile
return _import_module_from_library(name, build_directory, is_python_module)
File "/data/home/jijiahui/miniconda3/envs/MoDi/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 1701, in _import_module_from_library
module = importlib.util.module_from_spec(spec)
ImportError: /data/home/jijiahui/tmp/stylegan_lock/fused.so: cannot open shared object file: No such file or directory
so where's 'fused.so'?

Sadly, this is a problem we 'inherited' from the stylegan code, and requires trial and error with package versions.
The solutions are different for each machine.
Here is what worked for us on Cuda 11.5, after some trials and errors. I hope it will work for you if you are using Cuda 11.5 or similar. If you are using a different Cuda version, it may hint at a direction.
Let me know if you succeeded.
Python 3.7.16
torch 1.7.1
conda install pytorch==1.7.1 torchvision==0.8.2 torchaudio==0.7.2 cudatoolkit=11.0 -c pytorch
cuda_11.3.r11.3
conda install -c "nvidia/label/cuda-11.3.1" cuda-toolkit
gcc (GCC) 6.1.0 - לא בטוח שזה קריטי
conda install -c omgarcia gcc-6
Ninja
conda install -c conda-forge ninja
ו

I am closing the issue. Feel free to reopen it if needed.


React Native throws Soft Exception when dispatching TouchEvents for custom native Android components

Description
A custom native Android component can be made up of multiple native Views. For example, a custom TabBar renders a BottomNavigationView which internally renders many native views for the images and text that make up each tab. These native views aren't created by React Native, they're created by Android. So React Native isn’t in charge of what ids get assigned to these internal views.
The ReactRootView dispatches TouchEvents using hit-testing to work out which View triggered the touch. When the ReactEventEmitter tries to find the default event emitter it uses the id of this target View to decide whether to use the new or old architecture emitter. An even number is the new arch and an odd number is the old. But if the target is one of these internal Views created by Android then it could be either even or odd and React Native will throw if it finds the wrong one.
This breaks on both the old and the new architecture. But I've labelled this as a new architecture bug because that's when this odd/even architecture indicator idea came in.
I could workaround this problem by setting all the descendants to have the same ids as the container. But this isn’t ideal and I'm hoping there's a React Native fix for this.
Steps to reproduce

Download the new architecture sample
Set the theme to be "Theme.Material3.DayNight.NoActionBar"
Run the sample from Android Studio
Click the tabs around the edge of the ripple
Notice the soft exception logged

React Native Version
0.75.2
Affected Platforms
Runtime - Android
Areas
Fabric - The New Renderer
Output of npx react-native info
System:
  OS: macOS 14.6.1
  CPU: (8) arm64 Apple M1 Pro
  Memory: 108.84 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.9.0
    path: /opt/homebrew/bin/node
  Yarn:
    version: 3.6.4
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.8.3
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.0
      - iOS 18.0
      - macOS 15.0
      - tvOS 18.0
      - visionOS 2.0
      - watchOS 11.0
  Android SDK:
    API Levels:
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
      - "34"
      - "35"
    Build Tools:
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 32.0.0
      - 32.1.0
      - 33.0.0
      - 34.0.0
      - 35.0.0
    System Images:
      - android-30 | Intel x86 Atom_64
      - android-30 | Google APIs ARM 64 v8a
      - android-30 | Google Play ARM 64 v8a
      - android-32 | Google APIs ARM 64 v8a
      - android-33 | Google APIs ARM 64 v8a
      - android-33 | Google Play ARM 64 v8a
      - android-34 | Google APIs ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
      - android-35 | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.2 AI-242.21829.142.2421.12409432
  Xcode:
    version: 16.0/16A242d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.9
    path: /usr/bin/javac
  Ruby:
    version: 3.3.5
    path: /opt/homebrew/opt/ruby/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.75.2
    wanted: 0.75.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs
Unhandled SoftException
com.facebook.react.bridge.ReactNoCrashSoftException: Cannot find EventEmitter for receivedTouches: ReactTag[2131231014] UIManagerType[2] EventName[topTouchEnd]
	at com.facebook.react.uimanager.events.ReactEventEmitter.receiveTouches(ReactEventEmitter.java:102)
	at com.facebook.react.uimanager.events.TouchEvent.dispatchModern(TouchEvent.kt:124)
	at com.facebook.react.uimanager.events.EventDispatcherImpl$DispatchEventsRunnable.run(EventDispatcherImpl.java:376)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
	at android.os.Looper.loopOnce(Looper.java:205)
	at android.os.Looper.loop(Looper.java:294)
	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:235)
	at java.lang.Thread.run(Thread.java:1012)

Reproducer
https://github.com/grahammendick/navigation/tree/master/NavigationReactNative/sample/fabric
Screenshots and Videos
https://github.com/user-attachments/assets/a7d3608d-c23a-4830-99ae-665e4a2d6c56

React Native is failing to raise TouchStart and TouchEnd events. I'm not sure if that's a problem. Maybe not for this BottomNavigationView example, but this will happen for any native Android component that's made up of multiple native Views. Also it's a SoftException now, but I'm concerned that React Native will change this to throw a hard exception in the future.

Hey @cortinico, is it something that should be supported by React Native? I mean managing nodes that React Native does not know about (they are not In shadow tree)? I am just thinking about the proper solution to this and where it should be located.

@coado The problem is that if a user taps a View that wasn't created by React Native then 50% of the time React Native won't be able to locate the EventEmitter. In these cases React Native fails to send TouchStart/End events and raises SoftExceptions.
React Native uses the tag of a View to decide which architecture it's on. This works for Views it creates because it uses odd numbers for one architecture and even numbers for the other. But it doesn't work for Views that it didn't create because then Android decides on the tag number.
The suggested fix is to remove this dependence on the View's tag number for determining the architecture.

Hey @grahammendick, just to clarify, is it an issue with old architecture only? The exception seems to not be visible on Fabric. You can see that in getUIManagerType, the uiManagerType is mainly determined by surfaceId, which should technically be always presented. I can see that Fabric wasn't enabled previously in the repro here.

@coado Oh, my bad, that's a great spot! I forgot to retest after I realised Fabric wasn't enabled. I've retested now and it doesn't happen on Fabric. I'm happy to close. Thank you 🙏


Numerous examples and charts can't be used with Kubernetes 1.16

A extensions/v1betax and apps/v1betax for Deployment objects are now obsolete:
 kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:36:53Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:27:17Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

If you use one of the files used for testing, and try a simple kubectl apply, it is rejected
cd ~/src/github.com/replicatedhq/ship/integration$
kubectl apply -f init/jaeger/expected/base/Deployment-jaeger-collector.yaml

error: unable to recognize "init/jaeger/expected/base/Deployment-jaeger-collector.yaml": no matches for kind "Deployment" in version "extensions/v1beta1"

The Deployment/StatefulSet/DaemonSet apps/v1 are supposed to be used since Kubernetes 1.9. Ingress extensions/v1beta1 was rendered obsolete in kubernetes 1.14.
There is quite a lot of work/tasks associated with that fix:

Find fixed versions of the upstream charts.
Change all the extensions/v1betaX in the apiVersion, the roles.yaml, the kustomization.yaml (variable declarations..)
Add selectors in the deployment, statefulset and daemonset.

Since one of the primary feature of ship is to maintain the charts and the "k8s/kustomize" files in sync, only task 1 is supposed to be necessary. Ship will be able to update the corresponding k8s/kustomize files automatically.

This is the list of files which are impacted in the integration folder alone:
unfork/grafana/expected/rendered.yaml
unfork/istio-k8s/expected/.ship/state.json
unfork/istio-k8s/expected/rendered.yaml
unfork/istio-k8s/expected/overlays/ship/Deployment-istio-galley.yaml
unfork/istio-k8s/expected/base/charts/galley/templates/deployment.yaml
unfork/istio-k8s/expected/base/charts/gateways/templates/Deployment-istio-ingressgateway.yaml
unfork/istio-k8s/expected/base/charts/gateways/templates/Deployment-istio-egressgateway.yaml
unfork/istio-k8s/expected/base/charts/security/templates/deployment.yaml
unfork/istio-k8s/expected/base/charts/mixer/templates/Deployment-istio-telemetry.yaml
unfork/istio-k8s/expected/base/charts/mixer/templates/Deployment-istio-policy.yaml
unfork/istio-k8s/expected/base/charts/pilot/templates/deployment.yaml
unfork/istio-k8s/expected/base/charts/sidecarInjectorWebhook/templates/deployment.yaml
unfork/istio-k8s/expected/base/charts/prometheus/templates/deployment.yaml
unfork/redis-k8s/expected/.ship/state.json
unfork/redis-k8s/expected/rendered.yaml
unfork/redis-k8s/expected/overlays/ship/Deployment-redis-slave.yaml
unfork/redis-k8s/expected/base/redis-slave-deployment.yaml
unfork/jaeger-k8s-local/input/rendered.yaml
unfork/jaeger-k8s-local/expected/.ship/state.json
unfork/jaeger-k8s-local/expected/rendered.yaml
unfork/jaeger-k8s-local/expected/overlays/ship/Deployment-jaeger-collector.yaml
unfork/jaeger-k8s-local/expected/overlays/ship/Deployment-jaeger-query.yaml
unfork/jaeger-k8s-local/expected/base/Deployment-jaeger-collector.yaml
unfork/jaeger-k8s-local/expected/base/Deployment-jaeger-query.yaml
failing/base/helm-with-sub-charts/expected/installer/charts/rendered/charts/kube-state-metrics/templates/deployment.yaml
init/grafana-preserve-state/expected/rendered.yaml
init/jaeger-helm/expected/.ship/upstream/templates/query-deploy.yaml
init/jaeger-helm/expected/.ship/upstream/templates/collector-deploy.yaml
init/jaeger-helm/expected/.ship/upstream/templates/hotrod-deploy.yaml
init/jaeger-helm/expected/rendered.yaml
init/jaeger-helm/expected/base/query-deploy.yaml
init/jaeger-helm/expected/base/collector-deploy.yaml
init/factorio/expected/.ship/upstream/templates/deployment.yaml
init/factorio/expected/rendered.yaml
init/factorio/expected/base/deployment.yaml
init/istio-gogetter/expected/rendered.yaml
init/istio-gogetter/expected/base/charts/galley/templates/deployment.yaml
init/istio-gogetter/expected/base/charts/gateways/templates/Deployment-istio-ingressgateway.yaml
init/istio-gogetter/expected/base/charts/gateways/templates/Deployment-istio-egressgateway.yaml
init/istio-gogetter/expected/base/charts/security/templates/deployment.yaml
init/istio-gogetter/expected/base/charts/mixer/templates/Deployment-istio-telemetry.yaml
init/istio-gogetter/expected/base/charts/mixer/templates/Deployment-istio-policy.yaml
init/istio-gogetter/expected/base/charts/pilot/templates/deployment.yaml
init/istio-gogetter/expected/base/charts/sidecarInjectorWebhook/templates/deployment.yaml
init/istio-gogetter/expected/base/charts/prometheus/templates/deployment.yaml
init/grafana-with-values/expected/rendered.yaml
init/jaeger-cassandra/expected/rendered.yaml
init/jaeger-cassandra/expected/base/Deployment-jaeger-collector.yaml
init/jaeger-cassandra/expected/base/Deployment-jaeger-query.yaml
init/jaeger/expected/.ship/upstream/jaeger-production-template.yml
init/jaeger/expected/rendered.yaml
init/jaeger/expected/base/Deployment-jaeger-collector.yaml
init/jaeger/expected/base/Deployment-jaeger-query.yaml
init/concourse/expected/.ship/upstream/templates/web-deployment.yaml
init/concourse/expected/rendered.yaml
init/concourse/expected/base/web-deployment.yaml
init/concourse/expected/base/charts/postgresql/templates/deployment.yaml
init/istio/expected/rendered.yaml
init/istio/expected/base/charts/galley/templates/deployment.yaml
init/istio/expected/base/charts/gateways/templates/Deployment-istio-ingressgateway.yaml
init/istio/expected/base/charts/gateways/templates/Deployment-istio-egressgateway.yaml
init/istio/expected/base/charts/security/templates/deployment.yaml
init/istio/expected/base/charts/mixer/templates/Deployment-istio-telemetry.yaml
init/istio/expected/base/charts/mixer/templates/Deployment-istio-policy.yaml
init/istio/expected/base/charts/pilot/templates/deployment.yaml
init/istio/expected/base/charts/sidecarInjectorWebhook/templates/deployment.yaml
init/istio/expected/base/charts/prometheus/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/tracing/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/galley/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/gateways/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/security/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/mixer/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/grafana/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/servicegraph/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/ingress/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/kiali/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/pilot/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/sidecarInjectorWebhook/templates/deployment.yaml
init/istio-1.0.3/expected/.ship/upstream/charts/prometheus/templates/deployment.yaml
init/istio-1.0.3/expected/rendered.yaml
init/istio-1.0.3/expected/base/charts/galley/templates/deployment.yaml
init/istio-1.0.3/expected/base/charts/gateways/templates/Deployment-istio-ingressgateway.yaml
init/istio-1.0.3/expected/base/charts/gateways/templates/Deployment-istio-egressgateway.yaml
init/istio-1.0.3/expected/base/charts/security/templates/deployment.yaml
init/istio-1.0.3/expected/base/charts/mixer/templates/Deployment-istio-telemetry.yaml
init/istio-1.0.3/expected/base/charts/mixer/templates/Deployment-istio-policy.yaml
init/istio-1.0.3/expected/base/charts/pilot/templates/deployment.yaml
init/istio-1.0.3/expected/base/charts/sidecarInjectorWebhook/templates/deployment.yaml
init/istio-1.0.3/expected/base/charts/prometheus/templates/deployment.yaml
update/namespace/expected/rendered.yaml
base/helm-nginx/input/.ship/ship.yml
base/helm-nginx/expected/.ship/release.yml
base/helm-nginx/expected/installer/charts/rendered/deployment.yaml
base/helm-nginx/expected/installer/charts/src/nginx/templates/deployment.yaml
base/helm-fetch/expected/installer/charts/rendered/deployment.yaml