Issue ID: CVE-2022-33113

Description: Jfinal CMS v5.1.0 allows attackers to execute arbitrary web scripts or HTML via a crafted payload injected into the keyword text field under the publish blog module.
Fixed in any other branch? : Fix doesn't exist in any of the existing branches.
Rootcause:
This vulnerability affects an unknown part of the Jfinal CMS component Publish Blog Module. The manipulation of the argument "keyword" with an unknown input leads to a cross site scripting vulnerability. The CWE definition for the vulnerability is CWE-79. The software does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users. As an impact it is known to affect integrity. An attacker might be able to inject arbitrary html and script code into the web site. This would alter the appearance and would make it possible to initiate further attacks against site visitors.
Steps to reproduce:

There is a stored XSS vulnerability in JFinal_cms 's publish blog module.
An attacker can insert malicious XSS code into the "Keyword" field. When the user views the content of the article in the foreground, the malicious XSS code is triggered successfully.
payload: " onmouseover="alert(document.cookie)

Additional Findings:

As per the CVE-2022-33113, XSS vulnerability is seen in the "Keyword" field. But, the same vulnerability is applicable to "Topic" field as well.

Fix:

The fix here is to ensure that the input strings from the portal is sanitized properly to get rid of the html strings/tags.
Here, we are making use of Apache common-lang's StringEscapeUtils APIs - escapeHtml() and unescapeHtml().
escapeHtml(): Escapes the characters in a String using HTML entities. For example: "bread" & "butter" becomes: "bread" & "butter".
unescapeHtml(): Unescapes a string containing entity escapes to a string containing the actual Unicode characters corresponding to the escapes. For example, the string "<Français>" will become "<Français>".
The fix is added in "AlertController" and "PersonController" classes in "com.jflyfox.modules.front.controller" packages. Also, "HtmlUtils" class will now expose two utility methods - escapeHtml() and unescapeHtml(), which can be used if required else where.
The changes are added here to make use of the escapeHtml() and unescapeHtml() in "HtmlUtils" class for strings specified in "Topic" and "Keyword" fields.

Unit Testing:

Verified that the XSS vulnerability is no more applicable for "Topic" and "Keyword" fields.
Verified the fix in Chrome, Mozilla and Firefox browsers.

This PR #44 fixes issue #39 and issue #42

您好，您的来信我已收到！谢谢！
Best  Wishes!
                                ——孔祥亮


update fastparse to 1.0.0

this is a fix for #26

thanks @mfirry please shot a release :-)

Should we step on 0.2.0?


Move this repo over to Eclipse

Once we have completed the step of publishing the pom for MicroProfile 1.0 (Issue #3 ), then we should move this repo over to the Eclipse github project to be consistent with the rest of our code deliverable repos.

@ivannov Have you signed the Eclipse Contributor Agreement? If not, would please do so?
It's needed to transfer your contributions to the Eclipse.
You would need to create an Eclipse account and press the sign button in the left sidebar on this page: https://www.eclipse.org/legal/CLA.php
@kwsutter or I would assist you if you have any issues.

Yes, I have an Eclipse account:
https://accounts.eclipse.org/users/iivanovu1r
:)

OK, thanks :)
I'll ask Eclipse to move the current repo then instead of creating a new repo, since all the contributors should have an agreement with Eclipse.


proposal: testing/iotest: add ErrWriter

Add an iotest.ErrWriter io.Writer implementation that accepts up to n bytes and then fails with the provided error.
This would be useful for quickly testing implementations that receive an io.Writer and deals with some of the possible errors.
This proposal is similar to #38781, but for io.Writer instead of io.Reader. But the API here would take the specified number of bytes to discard before failing.
There seems to be multiple cases where a writer is implemented just for this, as seen here (even more than the reader, which was surprising to me)
package iotest

// ErrWriter returns an io.Writer that accepts the first n bytes and then fails with err for all Write calls.
func ErrWriter(n int, err error) io.Writer

Rationale behind the API
The API difference from ErrReader is that the reader don't receive the bytes it should return, but that can be achieved with this composition:
io.MultiReader(
	bytes.NewReader([]byte("content")),
	iotest.ErrReader(io.ErrClosedPipe),
)

There is no implementation on the standard library (that I could find) that allows writing n bytes to a writer and then the remaining to the next writer. io.MultiWriter writes everything to all the given writers.
iotest.TruncateWriter would be my guess on what to use to make these tests, but it fails silently after n bytes.
Another API I considered was ErrWriter(writer io.Writer, n int, err error) io.Writer to allow testing what was written until the error, but when needed that can be achieved with:
buf := new(bytes.Buffer)
io.MultiWriter(
	buf,
	iotest.ErrWriter(1024, io.ErrClosedPipe),
)

Of course, the opposite would also work by using io.Discard when the data is not wanted, I'd be ok with either.

To clarify, you wrote "Add an iotest.ErrWriter io.Reader implementation" but I think you meant to say io.Writer, right?  Similarly in the function declaration.

Yeah, sorry. Fixed

This sounds a little like io.LimitWriter.
Most of our APIs use Readers, but any that return Writers might be helped by having a composable limit.

There was #46465 for a LimitedWriter

That seems to me like a specific use case for limiting the writing in the actual code, returning an io.EOF after a set amount of bytes.
This proposal is for testing, which allows defining any error to be returned.

Moving this over from #54548, which was closed as a dupe:
package io

func LimitWriter(w io.Writer, limit int64, err error) Writer {
	return &limitedWriter{w, limit, err}
}

type limitedWriter struct {
	w Writer
	n int64
	e error
}

func (lw *limitedWriter) Write(p []byte) (int, error) {
	if lw.n < 1 {
		return 0, lw.e
	}
	if lw.n < int64(len(p)) {
		p = p[:lw.n]
	}
	n, err := lw.w.Write(p)
	lw.n -= int64(n)
	return n, err
}

Cf. #51115

I think there are cases where one ends up using a limit reader, but conceptually what you really want is a limit writer. You don't really care if the request you're copying is consumed some kind of streaming processor, but you don't want to copy more than N bytes into memory or onto disk. LimitWriter would be useful for those cases.

I have also run into a variation on this theme, where something like this seemed very clean:
var b bytes.Buffer
for _, job := range jobs {
    run( job.cmd, LimitWriter(&b, job.limit))
}

because a Write error implied the job had gone haywire, and the run function could kill the process. I tried LimitReader, io.Pipe things first but the elaborations to get kill-on-Write were tricky and indirect, I felt like LimitWriter really was the right abstraction.

I agree that an io.LimitWriter would be useful, but I don't think  one that yields custom errors should be part of io.
Having io.LimitWriter(w io.Writer, limit int64, err error) io.Writer as proposed by @carlmjohnson would fit both use cases (production and tests) but would also require all the call sites for production code to pass the expected error, which I don't see any case where it wouldn't be io.EOF as it seems weird to me that a LimitWriter would return a different error.
Another option is to have the type public like LimitedReader:
package io

func LimitWriter(w Writer, limit int64) Writer {
	return &LimitedWriter{W: w, N: limit, Err: EOF}
}

type LimitedWriter struct {
	W Writer  // underlying writer
	N int64   // max bytes remaining
	Err error // error to be returned once limit is reached
}

func (lw *LimitedWriter) Write(p []byte) (int, error) {
	if lw.N < 1 {
		return 0, lw.Err
	}
	if lw.N < int64(len(p)) {
		p = p[:lw.N]
	}
	n, err := lw.W.Write(p)
	lw.N -= int64(n)
	return n, err
}

This would allow the same pattern as io.LimitReader and also allow tests, like the use case I proposed originally, to instantiate the structure directly:
&io.LimitedWriter{W: originalWriter, N: 100, Err: io.ErrClosedPipe}

I'd be ok with either, but IMHO it would be better to have ioutil.ErrWriter and io.LimitWriter as two separate things mirroring ioutil.ErrReader and io.LimitReader. In this case the io.LimitWriter would probably be a separate proposal.

I don't think io.EOF makes sense in the context of a writer. Maybe io.ErrShortWrite could be the default.


Temporarily disable journals

Due to write contention on the AWS RDS instance temporarily disable the journals for constituency and country whilst we deal with the extreme load from https://petition.parliament.uk/petitions/114003

Code change looks fine. Just waiting for Travis to assure the tests

I note from the JSON data feed for this petition that the individual country counts are not increasing.  Will these counts be available at some point or is the source data unavailable?
How does the lack of journaling affect the ability to detect and remove fraudulent signatures?
Thanks in advance. Apologies if not following etiquette.

Ignore.
Just seen the other PR to reinstate.


[BUG] "defaultOption" and "searchable" Select not displaying the preselected option

Describe the bug
When having a Select component with both defaultOption and searchable props, the Select is rendered with the placeholder text instead of the defaultOption label.
<Select options={DATA} defaultOption={{ label: 'Option 3', value: 'option3'}} searchable />
To Reproduce
Check this Snack to see the current behavior: Snack Demo
Expected behavior
The Select component should render the defaultOption label instead of the placeholder text.
Screenshots
The select when first rendered, it is not showing the default option, but the empty search field with the placeholder text:

When opening the select for the first time, it shows the default option selected in the option list:

Environment (please complete the following information):

OS: iOS/Android
OS Version: iOS 17
iPhone 14 and iPhone 15 simulator (not tested in other devices)

Additional context
Looks like the searchfield is not pre-populating the defaultOption's label when both options are enabled.
Thanks,
Germán

@grmnlxndr fix has been merged: https://github.com/MobileReality/react-native-select-pro/pull/245/files

Thanks Dawid!


Udevrules example

This adds steps explaining how to set up udev rules in order to run fauxcon as a normal user with 'uinput' group membership.

Wonderful! I've learned quite a bit about udev and its rules since
tinkering with fauxcon.  I'll add your pull tonight.
Loni
On Mar 19, 2017 3:01 PM, "Christian Bryn"<EMAIL_ADDRESS>wrote:

This adds steps explaining how to set up udev rules in order to run
fauxcon as a normal user with 'uinput' group membership.
You can view, comment on, or merge this pull request online at:
https://github.com/lornix/fauxcon/pull/2
Commit Summary

add steps to setup udev rules
add uinput udex rule file to examples/

File Changes

M README.md https://github.com/lornix/fauxcon/pull/2/files#diff-0
(18)
A examples/udev/rules.d/99-uinput.rules
https://github.com/lornix/fauxcon/pull/2/files#diff-1 (1)

Patch Links:

https://github.com/lornix/fauxcon/pull/2.patch
https://github.com/lornix/fauxcon/pull/2.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lornix/fauxcon/pull/2, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAc0H8Q3m9lacu0AhrT74f8n0st9fM45ks5rnaWQgaJpZM4Mh5BO
.


[Minor: Text dialog for "Limited Enchantability" broke & Deepshelf missing lootable

hmmm
ya know I might be able to fix this

and I just found that deepshelf dosent drop anything when you break it

Worth noting it's not just text, I can't enchant it even though I have the 60 levels

That message usually means that you don't have the right set up to do certain things
For example: if you're trying to make a infused to hell shelf, then you need to have certain minimum stats. Otherwise it's not going to work.

Closing repo; there are still a few things broken though that I have missed; just to make note.


[Crash Report] Vertical / Horizontal lines cause a crash when dragged

Steps To Reproduce

Open the Graphite Editor at https://editor.graphite.rs.
Switch to line tool.
Draw a vertical line, snapped to vertical by using shift.
Switch to select tool.
Try to drag the line.
Crash.

Browser and OS
Chrome, Windows 10
Stack Trace
panicked at 'tried to transform point to non finite position', graphene/src/layers/vector/manipulator_point.rs:53:9
Error
at https://editor.graphite.rs/js/app.6a8dfb0c.js:9:995
at Object.n [as handleJsMessage] (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:8158)
at https://editor.graphite.rs/js/app.6a8dfb0c.js:1:8656
at https://editor.graphite.rs/js/123.8b98810b.js:1:13830
at N (https://editor.graphite.rs/js/123.8b98810b.js:1:5550)
at Cn (https://editor.graphite.rs/js/123.8b98810b.js:1:13796)
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[2325]:0x1c8578
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[913]:0x174630
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[700]:0x1588a5
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1889]:0x1bbdd3
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1766]:0x1b6787
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1976]:0x1bf240
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[2532]:0x1cc402
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[2540]:0x1cc5d9
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1302]:0x1999c4
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[748]:0x15f80d
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1940]:0x1bdd14
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[95]:0x75758
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[442]:0x1273d7
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[54]:0x19197
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[58]:0x28114
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[131]:0x9d3b6
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[772]:0x162de6
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[899]:0x172bd7
at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1446]:0x1a4127
at Proxy.onMouseMove (https://editor.graphite.rs/js/123.8b98810b.js:1:8258)
at Proxy. (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:532)
at m (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:25571)
at action (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:23818)
panicked at 'tried to transform point to non finite position', graphene/src/layers/vector/manipulator_point.rs:53:9

Error
    at https://editor.graphite.rs/js/app.6a8dfb0c.js:9:995
    at Object.n [as handleJsMessage] (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:8158)
    at https://editor.graphite.rs/js/app.6a8dfb0c.js:1:8656
    at https://editor.graphite.rs/js/123.8b98810b.js:1:13830
    at N (https://editor.graphite.rs/js/123.8b98810b.js:1:5550)
    at Cn (https://editor.graphite.rs/js/123.8b98810b.js:1:13796)
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[2325]:0x1c8578
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[913]:0x174630
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[700]:0x1588a5
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1889]:0x1bbdd3
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1766]:0x1b6787
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1976]:0x1bf240
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[2532]:0x1cc402
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[2540]:0x1cc5d9
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1302]:0x1999c4
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[748]:0x15f80d
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1940]:0x1bdd14
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[95]:0x75758
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[442]:0x1273d7
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[54]:0x19197
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[58]:0x28114
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[131]:0x9d3b6
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[772]:0x162de6
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[899]:0x172bd7
    at https://editor.graphite.rs/bf67697c3f7dd460.module.wasm:wasm-function[1446]:0x1a4127
    at Proxy.onMouseMove (https://editor.graphite.rs/js/123.8b98810b.js:1:8258)
    at Proxy.<anonymous> (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:532)
    at m (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:25571)
    at action (https://editor.graphite.rs/js/app.6a8dfb0c.js:1:23818)

This is due to the fact that in order to resize the edge of the transform bounds, we are trying to multiply the line by a matrix with a scale of new_dimensions_of_bounding_box / old_dimensions_of_bounding_box (which would here result in infinity as old_dimensions_of_bounding_box = 0)

Unassigned myself as it looks like a newer contributor wants to give this a go.


UCO Issue 543: Bump UCO to current state of develop-2.0.0

This PR does not require committee processing for merging. It should pass CI and receive an approving review, though.
This PR is part of delivering UCO Issue 543 via the CASE website.

This PR is ready for merge.


WIP: CLDC-1133: Some organisations only use specific rent periods

[ ]  Import Organisation rent period data from exports
[ ] Display Organisation rent period data in Org Details page
[ ] Add validation that selected rent period must be one of the Organisation's periods if they have any

@kosiakkatrina no you're just far too quick, I haven't finished yet :joy:

@kosiakkatrina no you're just far too quick, I haven't finished yet 😂

@baarkerlounger Oh lol, okay, I shall not bother you further 😂


Handle case of site being down for home page.

If AWS website is down there will be a bad experience on the mobile app because the HomePage template is hosted on AWS.  We could handle this by having a backup home page on device and use it on failure.

Homepage is now being served out of the app.  Closing


Manjaro: reporting a bug from Ray sometimes results in a error dialog box

Describe the bug
When reporting a bug from Ray, after a few seconds an alert box pops saying Firefox is already running and it should be first closed.
Versions
Ray version (you can see this in "About Ray"): 1.14.7
To Reproduce
Steps to reproduce the behavior:

Go to Help menu
Click on 'Report a Bug...'
After a few seconds, see error (also see screenshot)

It doesn't not always reproduce, but closing Firefox while Ray is running seems to be the most straight-forward method to trigger the issue.
Expected behavior
No error, open up the browser.
Screenshots

Desktop (please complete the following information):

OS: Manjaro Gnome
Version: latest rolling, Gnome 40, Firefox 87

I can't seem to reproduce this, it seems like a very isolated issue. Let me know if it is still bothering you and I'll take a closer look at it.


🐛 Set timezone to Europe/London (successfully, this time)

What does this pull request do?
This PR fixes a 🐛 about setting the timezone to Europe/London in the Docker build.
As part of a set of conversations with @mahalrmoj we've discovered that the UI app is currently running on UTC:
$ k exec -ti hmpps-interventions-ui-5fc67cffcd-z4kgx --namespace=hmpps-interventions-dev -- date
Thu Apr  8 14:48:13 UTC 2021

How?

b6dc7cb adds a "build-time test" -- verifies that the timezone file in fact exists
774f922 then installs the package that provides that timezone file

Result:
$ docker build --tag=ui .
...<snip>...

$ docker run --rm -ti ui date
Thu Apr  8 15:47:44 BST 2021

What is the intent behind these changes?
To make sure the service is running in Europe/London timezone. It has no material impact on our APIs, but it's the least surprising default :) -- At least it doesn't look like we're setting the timezone when we aren't.

What impact does this have on the application? Do you have an example of how the container's time zone is affecting its behaviour?

without properly understanding the context - it doesn't seem appropriate to rely on the TZ of the container for anything at all. we have libraries already in use in this repo that allow formatting in whatever TZ you like. e.g.
    const ukDate = getZonedTime(date, findTimeZone('Europe/London'))

Apologies, I skimmed over a few important points

The most important bit is fixing the false promise of the Dockerfile: it sets TZ to London, so if it does that, that should work.
The second is that the service inherited this setting from the Kotlin template and it bothers my sense of consistency. It does have a suggestion open to switch to UTC by default. (https://github.com/ministryofjustice/hmpps-template-kotlin/issues/29)
Distant third (I'm not precious about this) is what we get back from the "now" instant. We're deployed in the London region, not having to work in other countries, so it can be the same time we see on the clock. This is really minor though.


AttributeError: 'float' object has no attribute 'upper'

From reviewer: attribute errors for harmonize_all(df, errors='ignore'): AttributeError: 'float' object has no attribute 'upper' (these attribute errors happened a few times in the other demos, too.)

Possible repeat of #64, which leads me to believe dependencies aren't being resolved properly. Bringing pinned versions up to date (#26 ) may help resolve. Updated pyproject.toml to sync with requirements (b125f65631d2395dcf3c15a3b3444afdaafd7389). Sounds like it could be a numpy.nan for a text field (trying to uppercase an NAN), this was seen in domains.re_case() and is the reason for the try/except there.


GUI Does not show service changes

Describe the bug
Tool at least is not detecting service changes.
To Reproduce
Steps to reproduce the behavior:
Run ASA 2.1.30-Beta and scan for just services
Run the command to add a service i.e. sc create asademo99 binpath=c:\temp\asademo.exe
Run ASA again for a second snapshot
Run the results and filter for services
Expected behavior
Should detect the service added
Screenshots
see screenshot
System Configuration (please complete the following information):

OS: Windows

OS Version: [e.g. Windows 10 1803]

Application Version: [e.g. 2.1.30-BETA

CLI or GUI: GUI

Additional Context
Add any other context about the problem here.

Please be clear about what interface you're referring to.  This is a GUI bug, not a data collection bug.  You can test the data collection itself in the commandline interface.

Note the GUI reference in the bug details.


Developer Tool on Lilico Wallet

Developer Tool in Lilico Wallet
Grant category

[x] Developer tools / services

Description
One of the main goals for lilico is developer friendly. To achieve this, we would like to provide more tools for developers to test their dApp while they are in development.
Problem statement

When a developer creates their custom FT or NFT, they can't get it to display on the wallet when it's in testing.
Because they have to go through the whole progress to submit PR or form to let wallet to display.
It's not easy for them to test their NFT or FT.

I heard from some of the dApp team ( The fabricant ) are struggling with automation testing since they need to collaborate with the wallet to provide the automation ability. So Lilico would like to step further to provide this ability to all developer on flow.

Target audience
Developer

Evidence for the need
Emmm.... other ecosystem have a similar tool, we believe it will be needed by developers.

Proposed solution

Once the developer mode is on, Lilico will have a custom FT or NFT input field inside of the wallet, the developer can enter their project key info like  contract_name, address, storage_path and etc. Then Lilico will store it locally and will fetch and display those FT or NFT in the wallet. So developers can test their project for displaying or sending all kind of stuff before submit to alchemy or wallet to make it public.

Lilico will create an auto-approve ability in the developer setting, which will sign the coming transaction and message automatically. So the dapp can resume their testing without waiting for approval.

Impact

In what ways does this benefit the broader Flow developer ecosystem?

Yes, it will benefit all flow developers if they need this kind of ability.
Milestones and funding

Note: You can leave the USD proposal empty / "TBD". Please consider adoption and/or maintenance milestones at the end of your project.

Milestone
Deliverables
Timeline
Risks
USD proposal

1 - Custom FT support
Developer can test their FT token during development
2 weeks
-
4000

2 - Custom NFT support
Allow developer to display and test their NFT in the wallet during development
4 weeks
Take time to build own NFT API
8000

3 - Automation testing tool
Unblock some team for automation testing
2 weeks
-
2000

4 - Documentation
Giving a doc instruction about how to add custom token and NFT into wallet and display it locally
2 weeks
-
2000

5 - Adoption
Add analytics on how many dev has been using this function and generate a report by a period of time
2 weeks
-
2000

5 - Maintenance
Keep updating and maintaining those features by listening to the developer's feedback
6 months
-
6000

Team

Name
Role
Bio
Contact

Hao
Full-Stack Engineer
Founder of outblock, the core developer of lilico wallet. Built flow-swift, fcl-swift SDK.
<EMAIL_ADDRESS>

Han
Full-Stack Engineer
CTO of outblock, educated in NYU, USYD, ANU. Double Master's degree in CS. Worked on mozilla foundation, tumblr, Alibaba before.
<EMAIL_ADDRESS>

hey @lmcmz, we've reviewed this application would like to accept it if you could:

Add a documentation milestone
Add an adoption milestone before maintenance (eg 100 developers used the feature in dev mode)

Please let me know if that is ok and we can move forward.

Hi @alxflw
Sure, got it.  We will work on it and update here.

great, could you update the milestones, deliverables, timelines, and costs in your issue based on the feedback?

hi @lmcmz, can you please update the description based on the above?

hey @lmcmz, please update the application above. we cannot review this before and will mark this as stale due to inactivity

Hey @alxflw
Sorry for the late reply, some distraction on our end.
I have update the milestone base on your comments, please have a look.

thanks, we'll do a final review on this and get back soon

Yeah, the adoption was planning to track and generate a usage report to flow developer experience team.
If it's no need, we can simply remove it. :)

Sorry @lmcmz  - wasn't saying it wasn't needed, but instead was looking for you to propose a specific level of adoption that would trigger the milestone being completed.  For instance, the milestone could be marked as complete when X developers have used the feature on dev mode.  Does that work?

Hi @lmcmz, we're closing this proposal out based on our conversation around current resourcing.  We'll revisit at a later point when there is resourcing ready to take this one forward.  Thanks!

We appreciate your proposal and taking the time to fill it out. Given the time since this has been submitted I'm closing this down, please reach out to me if you'd like to share what you're working on now and explore potential opportunities<EMAIL_ADDRESS>


Facebook Mobile link download

Downloading this kind of **Mobile **Facebook links do not work:
https://m.facebook.com/story.php?story_fbid=368678973302573&id=101604320010041

Normal Facebook links are downloading fine. please have a look.
Output:
My prompt>./youtube-dl --version
2016.02.22
My prompt>./youtube-dl https://m.facebook.com/story.php?story_fbid=1035862816472149&id=116132035111903
[1] 8731
My prompt>[generic] story: Requesting header
WARNING: Falling back on generic information extractor.
[generic] story: Downloading webpage
[generic] story: Extracting information
ERROR: Unsupported URL: https://m.facebook.com/story.php?story_fbid=1035862816472149
[1]+  Exit 1                  ./youtube-dl https://m.facebook.com/story.php?story_fbid=1035862816472149

Thanks for the report. Such URLs will be supported in the next version. Note that you need to enclose URLs in single or double quotes. See this FAQ entry for more information.


Advantages of Variant B

I want to understand better the advantages being ascribed to variant B. I understand the general idea that more parallelism is good, and that Promise.alling async dependencies is generally preferred in async programming, but at the same time it's clear that there are some uncomfortable tradeoffs implied by variant B.
I'm having trouble thinking of realistic examples in this space; most of the top-level-await use case that I personally see are for simple node scripts or app-root modules, for which variant A works just as well.
Can someone think of a good concrete use case that can be used as a basis for discussion?
Thanks!

Here is a pretty simple example:
// app.mjs
import "./custom-element-1.mjs";
import "./custom-element-2.mjs";

// custom-element-1.mjs
const template = await (await fetch(new URL("./template-1.html", import.meta.url))).text();

customElements.define("custom-element-1", class extends HTMLElement {
  constructor() {
    super();
    this.attachShadow({ mode: 'open' }).innerHTML = tempate;
  }
});

// custom-element-2.mjs
const template = await (await fetch(new URL("./template-2.html", import.meta.url))).text();

customElements.define("custom-element-2", class extends HTMLElement {
  constructor() {
    super();
    this.attachShadow({ mode: 'open' }).innerHTML = tempate;
  }
});

In variant A, template-1 must be fully fetched before template-2 is fetched. In variant B, they can be fetched in parallel.

You may remember @Rich-Harris wrote a widely-read gist a couple years ago arguing against top-level await.
Just this morning he clarified that variant B resolves all(?) of his concerns, which were based on the assumption of variant A semantics.
Though it may not be exactly what you're asking, I think it's reasonable to include [disadvantages of variant A not shared by variant B] in the bucket of advantages we can ascribe to variant B.

@domenic Ah, that makes sense. In this case, it's not so much parallel evaluation that we're interested in, it's parallel network fetching, yes?
@benjamn Twitter does what twitter will do. : )

I mean, parallel anything-awaitable. Network fetching is a prevalent example of such a proccess, but it's general, e.g. any web crypto operations or async parsing/decoding APIs or similar.

I think I got it: web application initialization will, in general, invoke various async APIs (e.g. fetching, crypto, or decoding APIs) which may be spread out across various modules. In order to minimize application startup time, the user would like execute all of those async operations in parallel.
Is that fair?

Yeah, that's the idea!

OK, I agree that variant A would be an "attractive nuisance" in those scenarios.


[Request] Add Pivot Animator

This is a request to add Pivot Animator to the Extras bucket.
Pivot animator is a stick-figure animation program.
Website: https://pivotanimator.net
Thanks!

The file is detected as a virus by Avira. I am sending a form to Avira to see if it is a false positive.

Probably need more information / tests to see if it contains anything suspecious.


Jupyter notebook examples for InteractionKernel

Create a good, illustrative example Jupyter notebook (in collaboration with @fedeguerr @pdnooteboom and @mikaelk ) demonstrating the interaction kernel usage, as well as including the following things:

execution order matters: regular kernel + manipulate -> regular kernel + manipulate -> ... -> [interaction kernel -> check execution -> apply interaction changes] -> [interaction kernel -> check execution -> apply interaction changes] ...
performance benchmarks and conclusions
limitations of particle-particle interaction

(subtasks still to-be-done)

I think this is fixed (for now) with the https://docs.oceanparcels.org/en/latest/examples/tutorial_interaction.html tutorial, which most users seem to be able to work with well


Fixes #14181, validate model output shape for ObjectDetector.

Description
Fixes #14181
Make sure model passed to ObjectDetector supports object detection and output bounding box.
Testing:
Executed attached testing code, InvalidArgumentException with proper message is thrown.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[X] Changes are complete (i.e. I finished coding on this PR)
[X] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[X] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-label-bot add[Scala, pr-awaiting-review]

@frankfliu Please do a pull-rebase on master to avoid Windows CI


Add Consent page to Experian flow

Related Issue or Background Info

Resolves #2278

Changes Proposed

Adds Consent component with required consent language from Experian
Flow starts with this new component, requires checking "I AGREE" checkbox before continuing

Additional Information

this is a quick pass, open to design changes

Screenshots / Demos

Checklist for Author and Reviewer
UI

[ ] Any changes to the UI/UX are approved by design
[ ] Any new or updated content (e.g. error messages) are approved by design

Testing

[ ] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

[ ] Database changes are submitted as a separate PR

[ ] Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
[ ] Any changes to tables that have custom no-PHI views are accompanied by changes to those views
(including re-granting permission to the no-PHI user if need be)
[ ] Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback

[ ] GraphQL schema changes are backward compatible with older version of the front-end

Security

[ ] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[ ] Any dependencies introduced have been vetted and discussed

Cloud

[ ] DevOps team has been notified if PR requires ops support
[ ] If there are changes that cannot be tested locally, this has been deployed to our Azure test environment for verification

@nickclyde not sure what we can change here from a legal standpoint but here are my thoughts below and requested changes.

Change title to "Identity verification consent"
First paragraph add "your" so it reads ..."access your identify verification details"...
Last sentence: lowercase "privacy policy" (can we link to it here too? it's https://www.cdc.gov/other/privacy.html)
Do we need the I AGREE and the Submit button? I would prefer we do the same pattern as our terms of service. If this is possible then we'd need to:  Change "I AGREE" to "Submit" in the second paragraph (I'd prefer we have this in bold, not all caps). OR we could just get rid of the Submit button and have "I agree" as the button copy. Again, I prefer lowercase so we're not yelling :)

I'd be happy to make the content changes but I'm not sure about Experian's requirements for us either. @emmastephenson are we allowed to change the language?
As for the "I agree", I believe they want us to make agreeing to the terms an explicit step before you are allowed to continue, which is why I moved it into a checkbox.

Reading the email again, I don't think we need a checkbox. Here's the contract language from Experian:

A.                                FCRA Compliance--Written Instructions. Client shall substantially comply with the following web site requirements:
(1)             Client will prominently display a message specifically informing the consumer that his or her credit profile will be consulted
for the purpose for which it is to be used and no other purpose, and that clicking on the “I AGREE” button following such notice
constitutes written instructions to the Client under the FCRA. Client agrees that the notice provided by Client will be substantially as
follows:
“You understand that by clicking on the I AGREE button immediately following this notice, you are providing ‘written instructions’
to (Client) under the Fair Credit Reporting Act authorizing (Client) to obtain information from your personal credit profile or other
information from Experian. You authorize (Client) to obtain such information solely to _____________________________
(insert purpose e.g. to confirm your identity to avoid fraudulent transactions in your name.)
(2)             The “I AGREE” button must immediately follow the notice provided for above. The notice and “I AGREE” button must be
separate from any other notice or message contained on the web site.
(3)             The consumer must have the ability to fully review any of the terms to which he or she is agreeing immediately preceding
the consensual click.
(4)             The consumer must not be able to proceed in the process without affirmatively agreeing to the terms in the notice.
(5)             The consumer must have the ability (should they choose) to print out the terms to which he or she is agreeing, including their
consent.
(6)             The record of the consumer’s ‘written instruction’ by clicking “I AGREE” must be retained by Client in a form that is capable of
being accurately reproduced for later reference by the Parties.

My read on this is that we don't need the checkbox, and that we can just make the button say "I agree". We also have to send a screenshot of this page to Experian, so if they really want the checkbox for some reason we can always add it back in later.
I think the other copy changes Rebecca suggested are perfectly fine, Experian shouldn't have an issue with those.
Thank you both for the quick feedback here!

Great, I'll go ahead and make those changes then!

Updated the screenshot with the new language!

Oxford comma ftw!


Unable to indicate misa register not implemented

Table 3.2 of the privileged architecture (both the ratified version and the 2020/01/25 draft) states a value of 0 can be returned to indicate misa register is not implemented. The way to represent this would be to set both “default” and “bitmask” fields to 0, along with the “implemented” field to “false”. The SchemaValidator doesn’t allow for this and errors out based on the three way XOR of default, bitmask and ISA string.

FWIW, it currently seems impossible to indicate misa is unimplemented in the most recent commit without running afoul of a later check.
At the very least, I can't get past the "reset value does not match with extensions enabled" check with the following:
  misa:
   reset-val: 0
   rv32:
     accessible: true
     mxl:
      implemented: false
     extensions:
      implemented: false


Bidi RTL

Hi,
I changed full site rtl to bidi rtl.
for this write a simple program with c#,
1- read bootstrap.css and bootstrap.rtl.css and compare them.
2- Removed same tag and attributes.
3- Add .rtl class before changed and saved.
4- Some tags need some modifications so, create a file that's name is bootstrap_rtl_helper.css
5- Append bootstrap_rtl_helper.css to level 3 and save all to bootstrap_rtl.css
6- for looking at result create a sample. name is full-control-rtl2
Now we have Bidi rtl, means you can see controls in LTR and RTL same time.
we have 2 choose ,
1- Convert c# to javascript and used with rtlcss and this javascript.
2- Change bootstrap_rtl.css to scss file and compile with bootstrap project.
Please let see the change and say me witch way is best for you 1 or 2?
best reagrds
Omid Moridi

i don't know why after add this script dropdown menus do not work!
It's comment on code
<!-- Why add this script disabled dropdown menus? -->
<!--<script src="/docs/5.0/dist/js/bootstrap.bundle.js"></script>-->
If you want to see popover you must uncomented.

i don't know why after add this script dropdown menus do not work!
It's comment on code
<!-- Why add this script disabled dropdown menus? -->
<!--<script src="/docs/5.0/dist/js/bootstrap.bundle.js"></script>-->
If you want to see popover you must uncomented.

Closing this out as I don't believe we plan to make any changes to our RTL implementation and this is quite a massive PR. I'd suggest having a conversation about something like this next time before jumping in on it :).

Closing this out as I don't believe we plan to make any changes to our RTL implementation and this is quite a massive PR. I'd suggest having a conversation about something like this next time before jumping in on it :).

Agreed. @omoridi As I said, we won't land a bidi stylesheet: I tackled this by mentionning how to it using a custom build (through Sass and RTLCSS) but there's no point to this. As mentionned in many disscussions and issues around RTL, if we wanted to make our CSS bi-directionnal, this is not how we'd do it.
Feel free to open an issue if you encounter a bug, or maybe open a new discussion if you want to talk about our approach—but we won't change our approach for v5 now since it would break things.

Agreed. @omoridi As I said, we won't land a bidi stylesheet: I tackled this by mentionning how to it using a custom build (through Sass and RTLCSS) but there's no point to this. As mentionned in many disscussions and issues around RTL, if we wanted to make our CSS bi-directionnal, this is not how we'd do it.
Feel free to open an issue if you encounter a bug, or maybe open a new discussion if you want to talk about our approach—but we won't change our approach for v5 now since it would break things.


feat(infra): add a dashboard to monitor loki

Loki exposes these metrics via a prometheus format /metrics endpoint.
We can scrape these metrics and add a dashboard to monitor the status of loki

Can I start working on this issue ?


fix: add missing github email action

This email action was missing from PR #148.

@malandis i think we can close this


Updated Travis CI Build badge

It was showing the previous main primer name, changed it by primer-css

Thank you!


Interlude video ideas

Complement to #369.
Here are ideas of additional videos that are not tied into a particular topic of the mooc but would help provide with side information that is not necessarily meant to be evaluated in the quiz.

[ ] #390
[ ] #391
[ ] #392

I think we could sprinkle those videos into various modules of the mooc as "Interlude" videos to take a break from the main machine learning oriented topics of the mooc.

Why not, I guess I am not sure where to put the interludes so that they do not turn into a distraction from the main topic, maybe the end of a lesson (lesson == sequence but it is a bit less jargonish).
Also it may well be that there already exists some good references for this kind of topics. For example, on reading Python tracebacks I found Real Python do a reasonably good job (video and written article). This is not exactly what we want because it is not in a Jupyter notebook though, so some details are slightly different ...


Support drop down component in toolbar

The toolbar allows various Carbon components to be displayed as tools. The different variations of Carbon Dropdown components should also be supported.

A drop down menu can be achieved in the toolbar by using the carbon OverflowMenu component so a change is not needed for the common-canvas code for this.


Updating docs with length-based question filtering updates

Recently in a (github issue)[https://github.com/Kipok/NeMo-Skills/issues/214], a discussion about length-based filtering for questions came up. We had originally not done any such filtering for OpenMathInstruct-2, but found that doing such filtering doesn't affect the performance, and allows for a higher micro batch size. This PR updates the docs with this finding.

Looks good to me.


"restartBrowserBetweenEachTest: true" with jasmine 2 restart browser extra one more time

When i am using "restartBrowserBetweenEachTest: true" in conf with jasmine 2, having two "it" in spec then it restart the browser 3 times but i want 2 time only as their are 2 "it". how to resolve that problem.??

Hi there,
Please follow the Issue Template when opening new issues. Otherwise it's unclear what the issue is and how we can actually help.
I'm going to close this issue, please re-open a new one following the issue template linked above. Thanks! 😄


Allow owners to be removed from datasets and transforms

Add filter-horizontal interface to django admin for datasets and transforms which makes it easier
to add multiple owners, clearer which owners are selected and also possible to remove owners once
added.

Good PR! :+1:

@carolinegreen I realised that we should probably extend this to dashboards too, I've raised a PR https://github.com/alphagov/stagecraft/pull/391 if you wouldn't mind taking a peek?

:+1: This is so much better!


Trying to access "manage unit IDs list" for elements crashes the game

Describe the bug
All elements that have a list to open up for units crashes the game, for example moveunit and unitsequence
The associated crash (this one happened with unitsequence)
crash.txt
Steps to reproduce the issue
Place down an element that uses a unit list (moveunit, unitsequence, unitsequencetrigger etc)
Try to open the unit list
Crash
Log file
No response
Minimal reproduction
No response

Fixed with f081560dcf784504725044aff9808f86b948332e


Added support for RELAX NG schema validation

@polotek you good with this? I am.

lgtm
On Fri, Jan 16, 2015, 10:06 PM Roman Shtylman<EMAIL_ADDRESS>wrote:

@polotek https://github.com/polotek you good with this? I am.
—
Reply to this email directly or view it on GitHub
https://github.com/polotek/libxmljs/pull/273#issuecomment-70352121.


Locking and Trimming

Hello,
as I understand it, the Trimming is triggered by the Lottery and default there is a 1 in 1000 chance of triggering the Trim.
This can be quite detrimental for the Performance of the App. In our Case we have about 3M Entries in the Pulse Table, if we delete the data based on a timestamp, the delete query will take some time. In Between some new Entries want to be added to the Table, but it's still locked because of the delete Query.
If there's a lot of traffic this can escalate quite alot and cause DB Clusters to crash.
Is there a way to disable the Auto Trimming and maybe execute it at another time?
I would be open to create MR for this but I first wanted to get an idea if this Feature would be accepted.

Hi, @JulianMar, if performance is a concern in your application or you have amount of data in Pulse we recommend using the Redis ingest instead of writing directly to the database.
This means that the database trimming will happen in the pulse:work command and not during a request. It also means that inserts and deletes against the Pulse database are never happening at the same time.
Pulse will still trim the Redis stream within a request when the lottery triggers, but all if your pulse:work command is running the Redis stream is going to be empty and it will be unnoticeable to your application performance.
See: https://laravel.com/docs/11.x/pulse#performance
If you would like to keep writing directly to the database you could set the Lottery configuration to [0, 1]. This will stop the database trimming.
You could then call Pulse::trim() in a scheduled command, but this doesn't necessarily fix the problem as it sounds like your tables are locking up when the trim is running and requests are writing to the DB.
I would recommend migrating to a Redis ingest, which should solve things and make your application performance even better. Hope that helps.

Thanks for the amazing comment! I will check it out :)


Incorrect GitHub profile link is being generated

Thank you for all your work on laravel.io
The GitHub profile generated on my laravel.io profile page is incorrect as it contains my 2 year old username resulting in a 404 response.
I did test that is the GitHub API returning old/cached data but that's not the case as it returns the correct value for the "login" key in their response.

Ah yeah, I think we just need a way for users to update their Github username. I'll create an issue for it.

I made an issue for this: #275. I think it might be better if the system automatically updated your username instead of you manually having to edit it through a setting.


The mod needs more damage feed back

Is your feature request related to a problem? Please describe.
I love the mod, but when you hit the fastest slice of all time, there's no real feed back, like the critical hit has the crunch sound, and the kb hit has it's whack sound
Describe the solution you'd like
Use kb hit sounds for upper cuts and critical hit sounds for very fast hits

That's a great idea and I was thinking the same thing myself, unfortunately I am quite thin on time these days to work on the mod, and I am going to put this on hold for a good while. Thanks for the feedback though, I really appreciate it!


npm i curl-request errors

curl-request not installing, errors occur.
NPM Debug Log File https://ufile.io/b4sg3
Thanks in advanced!

Log file not found.


Suspicious AAD Joined Device Update {{OldDeviceName}} renamed to {{NewDeviceName}} and {{UpdatedPropertiesCount}} properties changed

Describe the bug
I have an analytic rule in my Senitnel Enviroment with the following name "Suspicious AAD Joined Device Update {{OldDeviceName}} renamed to {{NewDeviceName}} and {{UpdatedPropertiesCount}} properties changed" - The above name is what I expect to see in Sentinel however when this alert triggers the alert shows in the incident tab as "Suspicious AAD Joined Device Update {{NewDeviceName}} renamed to {{OldDeviceName}} and {{UpdatedPropertiesCount}} " having the names the wrong way around, in itself not a big deal but can cause a level of confuison.
To Reproduce
Steps to reproduce the behavior:
Run this analytic rule and check the output in the Incident tab.
Expected behavior
To receive the alert as it the name is written e.g " "Suspicious AAD Joined Device Update {{OldDeviceName}} renamed to {{NewDeviceName}} and {{UpdatedPropertiesCount}} properties changed"
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows
Browser Chrome

Additional context
Add any other context about the problem here.
Not sure if this is limited to my instance or wider instance, additionally I am aware I can swap the OldDeviceName and NewDeviceName variable in the alert logic itself to display differently, I am just wondering if there is a deeper issue maybe in the alert logic itself?

Hi @Kharn9201, Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 18-12-2023. Thanks!

Hi @Kharn9201 ,Could you please share more details about the issue you're facing with Problem statement and screen shot with issue details as I am unable to get the query and am going through the below analytic rule,Thanks.
(https://github.com/Azure/Azure-Sentinel/blob/bdeb8adf97c39a6ec87267410a91bb72976748a7/Solutions/Microsoft Entra ID/Analytic Rules/SuspiciousAADJoinedDeviceUpdate.yaml#L2)

Hi @Kharn9201 ,Gentle Reminder, ,Could you please share more details about the issue you're facing with Problem statement and screen shot with issue details as I am unable to get the query and am going through the below analytic rule,Thanks.
(
Azure-Sentinel/Solutions/Microsoft Entra ID/Analytic Rules/SuspiciousAADJoinedDeviceUpdate.yaml
Line 2 in bdeb8ad
name: Suspicious Entra ID Joined Device Update
)


[wip - do not merge] Testing pyflyte run + fully qualified package names

This is a PR on top of https://github.com/flyteorg/flytekit/pull/902/ just for the purpose of testing out the module sanitizer.
In order to run pyflyte run run:
FLYTE_AWS_ENDPOINT='http://localhost:30084/' FLYTE_AWS_ACCESS_KEY_ID=minio FLYTE_AWS_SECRET_ACCESS_KEY=miniostorage pyflyte run <module.example>:wf --image "baseimage:latest"

where <module.example> refers to a specific module and wf is a workflow found in the example module. Note the use of --image.
These env vars are used to write the tar file to an specific localtion in s3 via minio. In the real command we're going to get the s3 from the data proxy call.

Superseded by https://github.com/flyteorg/flytekit/pull/914.


Port Reconnection service change for redis disconnection

Goal
In order to properly support container orchestration systems like kubernetes, a service should exit if it cannot fully execute its functions.
If a redis connection is not available the account-service should exit.
Discussion
account-service uses an architecture similar to the reconnection-service and therefore can directly port the work done to support redis disconnection from this PR: AmplicaLabs/reconnection-service#114
Acceptance Criteria

[ ] redis connection error causes app to exit

Success cases:

when redis is running, then is stopped or an error is thrown

Failure cases:

when redis is not initially running


Fixes installation instructions & broken links, and improves readability of README

It started with a broken link and turned into more.

Great. Thank you for your contribution. 🍻


[Logseq] Can't search for pages

Extension
https://www.raycast.com/futantan/logseq
Description
I can't find any pages using the plugin. My pages are stored in my root folder as well as in some subfolders inside the root folder. I'm not using the default setup though where pages are stored in the /pages folder inside the root folder.
Is there any chance to make the plugin search the root- and other subfolders as well?
Steps To Reproduce
c.f. above.
Current Behaviour
No response
Expected Behaviour
No response

Hi @ituri, I don't think it's possible right now with the current version, the /pages part is hardcoded: https://github.com/raycast/extensions/blob/635c928ffc59351ca66067543dc81f9424ff85f1/extensions/logseq/src/logsearch.tsx#L107C2-L107C82
What you may experiment with is to go through these steps: https://developers.raycast.com/basics/contribute-to-an-extension and then just drop the  + "/pages" part or replace it with whatever you have in there instead. I'm not sure this is going to yield expected results or any results whatsoever for that matter.


Clicking "Reset" counts as a modification on a debugging challenge

Fixed this while looking into other modification issue


Refactored deactivate to use restx

Codecov Report

Merging #132 (8620178) into master (5a7ce91) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   97.88%   97.91%   +0.02%
==========================================
  Files           8        8
  Lines         331      335       +4
==========================================
+ Hits          324      328       +4
  Misses          7        7

Impacted Files
Coverage Δ

service/routes.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM!


Are the data types of FP16 programmatically defined?

Hi @lingweiyang
Could you please add more context to your question?
FP16 kernels require compiling for armv8.2-a. At runtime if the CPU does not support FP16, the validate() method of the function you're using will return an error.
Hope this helps.


DataFusion benchmarks should show executed plan with metrics after query completes

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I would like to be able to see metrics for a query plan after it is executed in the benchmarks. This is a convenient way to see where performance bottlenecks are in a query.
The following example shows metrics for SortExec but this is the only operator that we have implemented metrics for so far.
SortExec: [revenue DESC] metrics=[sortTime=56686,outputRows=5]
  MergeExec metrics=[]
    ProjectionExec: expr=[n_name, SUM(l_extendedprice Multiply Int64(1) Minus l_discount) as revenue] metrics=[]

Describe the solution you'd like
To produce the above example, I simply hacked the existing IndentVisitor as shown below, but this is not a good solution. It wasn't immediately clear to me how I could implement this to fit with the current design. Should there be a MetricsVisitor that we can somehow combine with the IndentVisitor? I also looked at adding a new variant to the DisplayFormatType variant but that required code changes in specific operators, so that didn't seem ideal.
fn pre_visit(
    &mut self,
    plan: &dyn ExecutionPlan,
) -> std::result::Result<bool, Self::Error> {
    write!(self.f, "{:indent$}", "", indent = self.indent * 2)?;
    plan.fmt_as(self.t, self.f)?;
    // BEGIN METRICS HACK
    let metrics_str = plan.metrics().iter()
        .map(|(k, v)| format!("{}={}", k, v.value()))
        .collect::<Vec<String>>();
    write!(self.f, " metrics=[{}]", metrics_str.join(","))?;
    // END METRICS HACK
    writeln!(self.f)?;
    self.indent += 1;
    Ok(true)
}

Describe alternatives you've considered
None
Additional context
None

@alamb Do you have any design advice for this?

I think adding a flag on the IndentVisitor like show_metrics is a reasonable idea, to be honest. We could also make a special purpose visitor too, but that might be overkill

@NGA-TRAN  has also been working on similar functionality for IOx so may also have some feedback here

Regarding metrics, I think the following items will be useful:

Sort algorithm (quick sort, ...)
If possible, how many partitions (input streams) get sorted.
Depends on sort algorithm, we may be able to know what kind of input encoding (e.g. RLE) and number of distinct values. I think these metrics will also help us to evaluate the effectiveness of the sort algorithm we choose.

@NGA-TRAN  -- 👍  -- see also #679


Additional NDES Certificate Troubleshooting Tips

I learned some additional lessons about maintaining NDES certificates used with SCEP/InTune that I think would be beneficial to others maintaining this integration long term.
I tried to locate the linked TechNet blog article archive in the new MS Tech Community but it doesn't appear to have survived.

@nbuuck : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Article has been updated, close this PR.


Compile failed when building kafka-protocol

I want to bump kafka-protocol to 0.10 in kafkas , but compiled failed on MacOS M1.
error message as follows:
   Compiling flate2 v1.0.28
   Compiling snap v1.1.1
   Compiling url v2.5.0
error[E0658]: use of unstable library feature 'stdsimd'
  --> /Users/xxx/.cargo/registry/src/rsproxy.cn-8f6827c7555bfaf8/crc32c-0.6.5/src/hw_aarch64.rs:50:33
   |
50 |         .fold(crc, |crc, &next| simd::__crc32cb(crc, next))
   |                                 ^^^^^^^^^^^^^^^
   |
   = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information
   = help: add `#![feature(stdsimd)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'stdsimd'
  --> /Users/xxx/.cargo/registry/src/rsproxy.cn-8f6827c7555bfaf8/crc32c-0.6.5/src/hw_aarch64.rs:62:5
   |
62 |     simd::__crc32cd(crc, next)
   |     ^^^^^^^^^^^^^^^
   |
   = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information
   = help: add `#![feature(stdsimd)]` to the crate attributes to enable

error[E0635]: unknown feature `stdarch_arm_crc32`
  --> /Users/xxx/.cargo/registry/src/rsproxy.cn-8f6827c7555bfaf8/crc32c-0.6.5/src/lib.rs:23:60
   |
23 | #![cfg_attr(all(target_arch = "aarch64", nightly), feature(stdarch_arm_crc32))]
   |                                                            ^^^^^^^^^^^^^^^^^

Some errors have detailed explanations: E0635, E0658.
For more information about an error, try `rustc --explain E0635`.
error: could not compile `crc32c` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...

How to fix this error?
Thanks!

The problem is solved by switching toolchain to stable


Replace iteritmes() with items()

Coverage remained the same at 100.0% when pulling 6d910ea91b550864f445fe33d0a29ef11a82f762 on method_items into 9b57f6f5698b2738ec8ac1ead954c950c3872d45 on master.


Clang format unit test

Codecov Report

Merging #135 into master will increase coverage by 1.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   82.66%   83.85%   +1.19%
==========================================
  Files          44       44
  Lines        2152     2156       +4
==========================================
+ Hits         1779     1808      +29
+ Misses        373      348      -25

Impacted Files
Coverage Δ

...tick_tool/plugins/tool/clang_format_tool_plugin.py
92.85% <100%> (+31.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c6829...5e31a2a. Read the comment docs.


Changelog/versioning: investigate changelog and versioning alternatives

Details
Currently we use the commit history as the changelog, but we should probably switch to proper versioning and changelog generation. The changelog could be used both to show users what has been changed, but also for us to parse the history in case we need to see recent changes.
I'm suggesting we use semver as version standard, it seems to be the most common used versioning semantic.
For the changelog generation we should probably utilize the fact we already have conventional commit standard in place. Many tools exist to utilize this for changelog generation. A big one I found recently is Google's release please. An alternative I've used previously is this one, but that might be less optimal since we have access to Github actions.
The point of this ticket is to investigate, find alternatives and discuss with other Sleep API authors. Then create follow-up tickets for the implementations.

To continue a bit of the discussion from discord:
If there's some bonkers bug that means charizard's ings completely out of whack, you could end up with a commit history like:
fix: Workaround issue 2 with production calculator
fix: Correct incorrect database entry
docs: Write documentation to avoid issue 1 in future```

All of which are distinct changes that need be separated - but from a user perspective, the only thing they care about is:
```fix: Charizard now has correct ingredient calculations```

Essentially we should probably decide what audience the changelog is actually intended for before anyone goes and implements anything

Essentially we should probably decide what audience the changelog is actually intended for before anyone goes and implements anything

Absolutely, this ticket exists only to investigate, discuss, decide and create follow-up tickets. It would be nice if we could generate one end-user changelog for the site and one technical for developers. If not, then we should look at striking a balance by configuring the generation to only trigger on certain commits.


Rotate secrets

Corresponding Firebase PR: https://github.com/firebase/firebase-ios-sdk/pull/8632 (cl/395792083)

Going to merge this as is. There are likely some UI test related flakes.


Revert "Swap chmod/chown to fix wildcard expansion error"

This  was supposed to be submitted and merged to the develop branch.
The original PR will need to be re-submitted to the develop branch.
Reverts daos-stack/google-cloud-daos#57

Just a heads-up that with this patch reverted neither the main nor the develop branch is

functional (in at least my test environment)
correct

The reason being that if
"sudo chmod +x /var/daos/cert_gen/*.sh"
is executed after
"sudo chown -R root:root /var/daos/cert_gen"
then there is no guarantee that the /var/daos/cert_gen/.sh part is properly expanded. This is because expansion is performed by the shell invoking sudo and not by the command which is run under sudo. If the invoking shell does not have x permission on /var/daos/cert_gen then chmod will be passed the literal string "/var/daos/cert_gen/.sh" which it will assume to be a valid path, which it is not.
Please let me know if there are any additional actions you expect me to take to get this patch submitted.


fix fix bug for using full name in show_full_columns stmt

Issue:

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run pipelinex_p0

run pipelinex_p0

run buildall

Could you please add test cases?
done

LGTM


0.6.0

Current dependencies on/for this PR:

main

PR #66   👈

This comment was auto-generated by Graphite.


On some pages when using a mobile device a black bar appears on the bottom

Context information
application version: pr-244
device: Samsung Galaxy S22
browser: Chrome 113.0.5672.163, Firefox
operating system: Android
Steps to reproduce
1.Go to the terms of services page
2.Scroll down the page
What is expected?
Nothinng should show up
What is actually happening?
A black bar appears while scrolling sometimes. It disappears when the scrolling is stopped
It also happens on other pages like the token page. But the bar only appears at the edges.
https://github.com/aeternity/aescan/assets/42606212/a4710d3b-74f3-4872-b16a-e4cd3c59c933

Suddenly it stopped being an issue. Let's keep it open for a while. If it does not appear, we can close it

@CharisSiarampalis Could you help us to check this? I think the issue is not present at any stage now.

@janmichek I just checked dev and production and i cannot reproduce it. Maybe it was fixed with a pr.

@CharisSiarampalis Thank you, closing this


[Issue 1522] Afford disable preboot for production

References

Fixes #1522

Description
Remove universal config from default app config. Add build config interface to extend environment. Update main browser to support production disabled preboot. Document.
Instructions for Reviewers
To test change preboot in src/environments/environment.production.ts to false and start production mode.
yarn start:prod

This should result in the application serving as CSR only.
The node server logs should contain
Universal off, serving for direct CSR

and the browser network traffic show all xhr requests.

Then confirm production mode with preboot enabled. Change preboot in src/environments/environment.production.ts back to true and start production mode.
The node server logs should contain
Environment extended with app config
Environment: Production

meaning the server prebooted the client.
The browser network traffic should now show less xhr requests as the preboot fulfilled those within the NgZone and transferred through state during rehydrate.

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@atarix83 I can add a .gitignore entry for environment.(dev or develpment).yml but if environment.(prod or production).yml is removed yarn build:prod will fail out of the box as it requires environment.(prod or production).yml

I think we should provide the ideal default production environment out of the box. It can always be change but does present some nuance with remembering to not commit if used for development.
If we really require it be excluded via .gitignore, I suggest an additional issue as it is not trivial when we are not generating environment.ts file any longer.

@atarix83: I'm confused by your request, as there is no environment.prod.yml.... We just have a config.prod.yml (which has a .gitignore entry already).  We do have an environment.production.ts file, but it cannot be ignored, as it is required to exist in src/environments, see https://github.com/DSpace/dspace-angular/tree/main/src/environments
That said, it looks like @wwelling has added a commit to ignore any non-required files in src/environments.  But, that's the only option available here based on the new runtime configuration process.

https://angular.io/guide/build#configure-target-specific-file-replacements

@wwelling @tdonohue

Maybe i'm wrong but for what i've understood from this PR now the build time configuration can be changed by creating
environment.(dev or develpment).yml for dev and environment.(prod or production).yml for production.
So if those two files are the correspective of the config.dev.yml and config.prod.yml in this case they should add to .gitignore too. Am i assuming something wrong?

I have updated the slight incorrectness in the README update. However, environment.production.ts is required to be managed because it is referenced in angular.json for file replacement during production build.

@atarix83 : Now I understand why we were misunderstanding each other! Thanks for pointing out that change in the README.  That was definitely a typo, as there are no environment.*.yml configs at all...there's only the config/config.*.yml configs (for runtime configs) and then the /src/environment/environment.*.ts files for buildtime configs (like preboot).
@wwelling : It looks like, even with your recent change, you still have the src/environment/environment.* files listed as YAML, but they are TypeScript.  So, I think another change to the README is needed to avoid the confusion here...there's no such thing as an environment.*.yml config.
I would also recommend we restructure this README slightly, as the most important configs here (and the ones most users will only use) are those in config/.  I'll add a comment shortly to recommend an easier to understand structure.

@tdonohue I think I have made the appropriate changes to the README.


Setup automated deployment

Is your feature request related to a problem? Please describe.
It's too much of an effort to deploy 8vim. Also, since it requires effort, I try to release when a lot of changes have piled on. The deployments should be seamless and frequent so the changes get to the end user as soon as possible.
Describe the solution you'd like
Setup fastlane as a deployment solution and use github actions to deploy on every merge to master.

@flide Could you please also deploy to GitHub, so we can fetch and install your keyboard using https://github.com/ImranR98/Obtainium?


[Network] Add more commands and examples for vwan connections

All the following changes will be in CLI extension virtual-wan:

Add a new command az network vhub connection command for hub vnet connection, so we can update the routing configuration properties such as change associated route table to any route table belonging to hub and propagated route tables to any route table belonging to any of the hubs in wan. We can also add/remove labels from propagated. Also we need add examples for it.
Add a new command az network vpn-gateway connection update for S2S Vpn connection, so that we can update the routing configuration properties. Also we need add example updating propagated route table or labels.
Add examples for commands az network p2s-vpn-gateway create/update.

Network


Additional dates field for candidates who select ‘I did not complete pupillage’

Is your feature request related to a problem? Please describe.
As an admin user, I’m frustrated when a candidate selects the box under the question ‘I did not complete pupillage’, because there is no option for them to then add any details about how they became a barrister.
I then have to go back to them at a later stage to request this information.
Describe the solution you'd like
When a candidate selects ‘I did not complete pupillage’ under the ‘Qualifications’ section on apply there needs to be a following supplementary question with a date box underneath:
‘If you did not complete pupillage, when were you called to the Bar?’
[DATE FIELDS]
Additional context
Please see the picture below for more details:

Whoever pics this up, if there is work on Admin associated with this ticket, please create the ticket and complete the work :)

@Kate @joy-ade  I guess this ticket came up because the Qualifications page was broken before which was fixed in ticket 729.

@Brookes, @.***>I guess this ticket can be close now.
From: Maria Brookes @.>
Sent: 22 April 2021 12:34
To: jac-uk/apply @.>
Cc: Adeagbo, Joy @.>; Mention @.>
Subject: Re: [jac-uk/apply] Additional dates field for candidates who select ‘I did not complete pupillage’ (#747)
@katehttps://github.com/kate @joy-adehttps://github.com/joy-ade I guess this ticket came about because the Qualifications page was broken before which was fixed in ticket 729https://app.zenhub.com/workspaces/platform-development-5ea838cd2aec471eb6d14139/issues/jac-uk/apply/729.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jac-uk/apply/issues/747#issuecomment-824761350, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARHK42WPJQHHBJQU6HTP3QDTKACSLANCNFSM423T42DA.

This e-mail and any attachments is intended only for the attention of the addressee(s). Its unauthorised use, disclosure, storage or copying is not permitted. If you are not the intended recipient, please destroy all copies and inform the sender by return e-mail. Internet e-mail is not a secure medium. Any reply to this message could be intercepted and read by someone else. Please bear that in mind when deciding whether to send material in response to this message by e-mail. This e-mail (whether you are the sender or the recipient) may be monitored, recorded and retained by the Ministry of Justice. Monitoring / blocking software may be used, and e-mail content may be read at any time. You have a responsibility to ensure laws are not broken when composing or forwarding e-mails and their contents.

@KateMJAC  @joy-ade I think the work in #729 needs to be reviewed in preview url and see how/whether this ticket is needed or if it is how it should be changed.

Gone out to UTG, update to follow.

@tomlovesgithub we currently have two legal exercises open for applications. Releasing this ticket will impact those exercises.
Please provide advice on what the next best steps are. Can we code around this or do we have to wait for a window where there are no legal exercises open?
For your info @joy-ade

This has been sent to UTG on 30/06/21 after final changes made by Tom. Will await feedback before final approval.
Also before this ticket is released consideration needs to be given to how it may/may not impact open exercises.

All required changes at this point made by Tom.
Sent to the UTG w/c 2th June with no feedback due to sign-in issues.
Sent to w/c 5 July testers

Can't merge at present due to conflicts.


Change Config.Default to Config.Global in ArkNetApi.cs

This will ensure developers using this library are able to override the default config settings with a settings.conf file in the root dir.

ok


Feature Request: Revoke superseded certificate

It would be a nice idea that if the hook runs and cert gets renewed, that the old certificate that was replaced is revoked.
This would mean if you do the renewal with 30 days left, the previously active cert would be revoked once replaced.
I guess this would be best implemented as either a config option or a --revoke type option.

This would result in more load on the Let's Encrypt servers and I don't think it would really do anything good for you. Your certificates and keys should be stored in a secure location anyway, so it wouldn't make much of a difference.
If you really want this you could easily create a hook-script that revokes old certificate files, but I don't think it would be a good idea as a main feature of dehydrated.
Closing this for now, if there are more people out there who want this feel free to comment here, and I may reconsider it.


feat: add model columns and fix controlnet script models names not find

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.


detection service: update to package  folder

Update to detection testing service code to grab package from a new directory

We also need to add the parameter --product which you added into generate as required input.

@P4T12ICK 👍 done!! good eye there

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Malicious Powershell Executed As A Service :white_check_mark:

diskUsage: 135168
runDuration: 0.754s
scanCount: 21


Clean up Loading extension CustomPathManager

There is some untidy code in loading extension that looks like legacy code which no one has bothered to clean up. The code for Custom Path manger has the following problems:

The value assigned to CustomPathManager in OnCreated() is never used. Its overwritten in loading extension. CustomPathManager is unlike other managers and cannot be instantiated in OnCreated(). This line is redundant and should be deleted:
https://github.com/CitiesSkylinesMods/TMPE/blob/06eda8d0f006ae7ab603bd0f878af9521fe4b8e1/TLM/TLM/LoadingExtension.cs#L282
CustomPathManager = new CustomPathManager();

Considering that we Loading extension has holds a reference to Instance of CustomPathManager accessing the static _Instance field is unnecessary:
https://github.com/CitiesSkylinesMods/TMPE/blob/06eda8d0f006ae7ab603bd0f878af9521fe4b8e1/TLM/TLM/LoadingExtension.cs#L330
Use This property instead:
https://github.com/CitiesSkylinesMods/TMPE/blob/06eda8d0f006ae7ab603bd0f878af9521fe4b8e1/TLM/TLM/LoadingExtension.cs#L63

CustomPathManager needs OnLevelLoaded() and OnLevelUnLoading(). The following code in loading extension needs to go into these new functions:

https://github.com/CitiesSkylinesMods/TMPE/blob/06eda8d0f006ae7ab603bd0f878af9521fe4b8e1/TLM/TLM/LoadingExtension.cs#L356
https://github.com/CitiesSkylinesMods/TMPE/blob/06eda8d0f006ae7ab603bd0f878af9521fe4b8e1/TLM/TLM/LoadingExtension.cs#L497

Also This line should throw an exception for consistency reasons (don't worry ... its in a try..,catch block):
https://github.com/CitiesSkylinesMods/TMPE/blob/06eda8d0f006ae7ab603bd0f878af9521fe4b8e1/TLM/TLM/LoadingExtension.cs#L501
The code for CustomPathManager OnLevelLoaded() and OnLevelUnLoading() could be like this:
       static private FastList<ISimulationManager> GetSimManager =>
            typeof(SimulationManager).GetField("m_managers", BindingFlags.Static | BindingFlags.NonPublic)
                ?.GetValue(null) as FastList<ISimulationManager>;

        public void OnLevelUnloading() {
            Log.Info("CustomPathManager.OnLevelUnloading()");
            // TODO [issue does not exit] uncomment for more clean code and to support ingame unload
            // Custom path manger is destroyed when reloading. That is why the following code is commented out.
            //GetSimManager?.Remove(this);
            //Object.Destroy(this);
            _instance = null;
        }

        static public CustomPathManager OnLevelLoaded() {
            Log.Info("CustomPathManager.OnLevelLoaded() called. Setting up CustomPathManager and SimManager.");
            FieldInfo pathManagerInstance = typeof(Singleton<PathManager>).GetField(
                "sInstance",
                BindingFlags.Static | BindingFlags.NonPublic);
            if (pathManagerInstance == null) {
                throw new Exception("pathManagerInstance is null");
            }

            PathManager stockPathManager = PathManager.instance;
            if (stockPathManager == null) {
                throw new Exception("stockPathManager is null");
            }

            Log._Debug($"Got stock PathManager instance {stockPathManager?.GetName()}");
            // TODO [issue does not exist] restore vanila custom path manager for cleaner code and to support in-game unload
            _instance = stockPathManager.gameObject.AddComponent<CustomPathManager>();
            Log._Debug("Added CustomPathManager to gameObject List");

            if (_instance == null) {
                throw new Exception("CustomPathManager is null. Error creating it.");
            }

            _instance.UpdateWithPathManagerValues(stockPathManager);
            Log._Debug("UpdateWithPathManagerValues success");

            pathManagerInstance.SetValue(null, _instance);

            Log._Debug("Getting Current SimulationManager");
            var simManager = GetSimManager;
            if (simManager == null) {
                throw new Exception("simManager is null");
            }

            Log._Debug("Removing Stock PathManager");
            simManager.Remove(stockPathManager);

            Log._Debug("Adding Custom PathManager");
            simManager.Add(_instance);

            UnityEngine.Object.Destroy(stockPathManager, 10f);

            Log._Debug("Should be custom: " + Singleton<PathManager>.instance.GetType());

            return _instance;
        }

Then in the loading extension OnLevelLoading():
            try {
                // CustomPathManager must be created while teh level is loading.
                CustomPathManager = CustomPathManager.OnLevelLoaded();
            }
            catch (Exception ex) {
                string error = "Traffic Manager: President Edition failed to load. You can continue " +
                               "playing but it's NOT recommended. Traffic Manager will not work as expected.";
                Log.Error(error);
                Log.Error($"Path manager replacement error: {ex}");

                Singleton<SimulationManager>.instance.m_ThreadingWrapper.QueueMainThread(
                    () => {
                        UIView.library
                              .ShowModal<ExceptionPanel>("ExceptionPanel")
                              .SetMessage(
                            "TM:PE failed to load",
                            error,
                            true);
                    });
            }

Please send in a PR for this and #731 so we can test; it's always good to get the code cleaned up and improved.

@kian.zarrin Pathfinding object is leaking... I did maybe 4-6 hot-reloads of my second mod while

TM:PE was just enabled
Debug 1,999.0765170: Waking up CustomPathManager.
Debug 1,999.0863329: Creating 256 custom PathFind objects.
Info 1,999.0955972: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1054987: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1156799: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1258537: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1390482: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1506545: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1607004: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1709649: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1814978: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.1920980: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.2021296: Pathfinder logic: Using CustomPathFind_Current
Info 1,999.2125589: Pathfinder logic: Using CustomPathFind_Current

@krzychu124 are you using debug build?

kian.zarrinToday at 13:02
@krzychu124 are you using debug build? is it latest master branch?
this might explain the game crashed due too many threads problem
krzychu124Today at 13:07
Full debug, but I am not hot-reloading tm:pe, that's the weirdest thing :)
kian.zarrinToday at 13:12
oh I see!
where is your second mod by the way?
if you have output.log it helps me to see if TMPE was reloaded.
krzychu124Today at 13:21
I think it doesn't matter what other mod you'll try hot-reload
kian.zarrinToday at 13:52
while TM:PE was just enabled
Ambiguine statement. does it mean TM:PE was simply enabled all along or TMPE was enabled at that moment?
krzychu124Today at 13:58
TMPE was enabled all the time, I haven't use it at that time.

I do not observe double hot reload of TrafficManager.dll when I hot reload my HideCrossings.dll
output_log.txt
That said, the traffic manager did load again (maybe after hot reload the serialize data extension is called again?)
Debug<PHONE_NUMBER>: HOT RELOAD ...

TMPE.log

we need something like this:
            if (TrafficManagerMod.Instance.InGameHotReload && !LoadingExtension.IsGameLoaded) {


Regarding to the network architecture

Thanks for sharing a good job!
I have a question about network architecture. As I understanding, given an input image I, you first feed it to the appearance network to change the intensity. Then feed the result of the appearance network to the registration network to register it with atlas.
Do you try to investigate another direction likes, first you feed the network to registration network, then the moved image feeds to the appearance network? Which one is better?

Sorry. I was wrong. You learn it separately.
However, it has one problem when you learn two network independently. As shown in block 4 figure 2, you feed the atlas image throws the appearance network and the output feed to the registration network. But the registration network is learned using an original atlas and target subjects (without adding appearance), so how it can work if we feed the output of appearance network to the registration network?

Hi John! Fig. 2 block 4 depicts the synthesis process, where we are no longer doing any learning. At this stage, we sample an appearance transformation (which is just a per-voxel additive volume) and a spatial transformation (a 3D flow field). We add the appearance transformation volume to the atlas, and then warp that volume with a flow field. Hope that clears things up.

So the flow likes
(input, atlas)-->reg_net-->flow
(input, atlas)-->appearance net-->output
output-->warp(flow)-->output_moved
label-->warp(flow)-->label_moved

Am I right?

That's correct! You can find the code that does this in src/segmenter_model.py: https://github.com/xamyzhao/brainstorm/blob/ac3489c1152d01e345c80741d1626741c124011e/src/segmenter_model.py#L577-L593


Add option to use sample/control as input

Feature
KS would like to add controls(positive and negative) in the future.
What needs to be done
The samplesheet.csv needs to be updated. Right now it looks like:
sample,run_accession,instrument_platform,fastq_1,fastq_2,fasta
2611,ERR5766174,ILLUMINA,,,../../../jfy133/nf-core-test-datasets/data/ERX5474930_ERR5766174_1.fa.gz
2612,ERR5766176,ILLUMINA,../../../jfy133/nf-core-test-datasets/data/ERX5474932_ERR5766176_1.fastq.gz,../../../jfy133/nf-core-test-datasets/data/ERX5474932_ERR5766176_2.fastq.gz,
2612,ERR5766174,ILLUMINA,../../../jfy133/nf-core-test-datasets/data/ERX5474936_ERR5766180_1.fastq.gz,,
2613,ERR5766181,ILLUMINA,../../../jfy133/nf-core-test-datasets/data/ERX5474937_ERR5766181_1.fastq.gz,../../../jfy133/nf-core-test-datasets/data/ERX5474937_ERR5766181_2.fastq.gz,

After the update then samplesheet.csv should have the following columns:
sample,run_accession,instrument_platform,metagenome_fastq_1,metagenome_fastq_2,negative_control_fastq_1,negative_control_fastq_2,fasta

This can be closed when:

[ ] The columns in the samplesheet have been defined to include controls - this should be discussed with taxprofiler(slack)
[ ] The controls can be used as input from the command line- this should be discussed with taxprofiler(slack)
[ ] If controls are used, both sample/control are going through preprocessing and classification.
[ ] Make sure that sample/controls are working for both Nanopore and Illumina

This will be discussed at a later stage with taxprofiler


[SUPPORT] Transaction and spark job final state inconsistency in batch  processing

code in:
https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java#L215-L272
In this picture, we have submit instance commit success. But in two, when we trigger mayBeCleanAndArchive, it throw Exception, and make this job failed, it will retry in job level. But this commit has commit.
So the final result is: instance commit success -> job failed and retry, and the success instance will not rollback.

Including other places, I think will cause this problem. I think we need catch all exception after we commit instance success or extend the scope of a transaction.
I prefer first catch all exception
To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version : 0.13.1

Spark version : 3.2.0

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

may be it work well in streaming processing, but In batch processing, may be some problem

@nsivabalan Can you help see this problem

In our case, we open occ for every job, and it throw exception when call CleanerUtils.rollbackFailedWrites in clean after commit instance success, the job failed and will retry. Our job is merge into spark sql  which is not idempotent.

when we trigger mayBeCleanAndArchive, it throw Exception, and make this job failed, it will retry in job level. But this commit has commit.
So the final result is: instance commit success -> job failed and retry, and the success instance will not rollback.

It should be okay the successful commit does not rollback, you mean the retry of spark job would result in another commit on the table? Did you have some clue why the job fails when cleaning?

@danny0405 yes, it will recompute again, there will be multiple commit instances in a offline task cycle like daily cycle, in this day, there should be one commit instance in theory, but has two commit instance.

Did you have some clue why the job fails when cleaning?
first cycle:
we meet #7837, so it should be rollback in next batch etl (we open occ),
second cycle:
After instance commit, it will rollback failed instance if open occ, and there is something bug in our Rss(Remote shuffle service), so rollback will failed, and the job failed and spark will retry again, in this daily cycle will recompute again and create new commit instance based before instance which job is failed

Is there anyway the cleaning and archive does not trigger recomputation of the whole job?

Is there anyway the cleaning and archive does not trigger recomputation of the whole job?

timeline:
00000.commit
00001.commit
I think it is possible. The question is the table service or other processing logical is not in the scope of transaction. At the end of transaction, it mean hudi commit status is successful (00002.commit), but the engine job status is still running, and if it failed by other processing logical, the engine job will retry to make it success, so hudi will use the latest instance (00002.commit) snapshot to upsert, and commit again (00003.commit).

inline archiving and cleaning may have this issue, do you try the async cleaning instead? Is there any spark param to control the failover behavior, seems not very easy to fix from Hudi side.

Simplify catch exception makes sense to me if it can solve the problem, the data quality should take higher priority.

inline archiving and cleaning may have this issue, do you try the async cleaning instead? Is there any spark param to control the failover behavior, seems not very easy to fix from Hudi side.

in offlien batch processing, this way is not user friendly, they need to maintain multiple tasks for the table serviece, unless we have good operation and maintenance services for monitoring and management

Simplify catching exception makes sense to me if it can solve the problem, the data quality should take higher priority.

yes, but it has a problem, we will not be able to perceive the abnormal exception.

Okay, let's keep this issue open to enlighten with more ideas.

@KnightChess MERGE INTO should be idempotent(if using upsert as operation type), Can you please enlighten me under which scenario it can create data inconsistency issues? Only thing I can see that it may show records as false updates for the incremental or point-in-time queries.
OR Are you not using upsert(or no preCombineField provided)?

@ad1happy2go merge into will use DefaultPayload logical to judge the record update or not. If the preCombineFiled value is the same, it still can update target record.

and in some scenario, user will use current_time as preCombineFiled value

@KnightChess We had a discussion on this. For any process if the job being run twice it can create data inconsistencies for non-idempotent if it contains multiple actions/writes.
We may want to come up with solution for optimising which will help us to avoid running whole write/upsert again in case of table services failure. (May be a flag which may control )
Created Tracking JIRA - https://issues.apache.org/jira/browse/HUDI-6554
Downgrading the priority to Major as this may not be blocker for 0.14.0.

@ad1happy2go @danny0405 thank you answer


Correction for raw affiliation Evolucare; Modélisation, Information et Systèmes - UR UPJV 4290

Correction needed for raw affiliation Evolucare; Modélisation, Information et Systèmes - UR UPJV 4290
raw_affiliation_name: Evolucare; Modélisation, Information et Systèmes - UR UPJV 4290
new_rors: 01gyxrk03
previous_rors:
works_examples: W4287200477;W4283737512
contact: 65a99c0de3d9868bd958315b519d17ea:fe293f01e33771eb990cddcc7d78e6f4 @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Error When Building SDK.  "[21%] Linking CXX executable AlertSchedulerTest"

I have connected to the pi via ssh.
I have done all the steps correctly 3 times and still keep getting the same error.
/usr/bin/ld: ../../../../AVSCommon/libAVSCommon.so: undefined reference to __at                                                                                omic_fetch_add_8' /usr/bin/ld: ../../../../AVSCommon/libAVSCommon.so: undefined reference to __at                                                                                omic_store_8'
/usr/bin/ld: ../../../../AVSCommon/libAVSCommon.so: undefined reference to `__at                                                                                omic_load_8'
collect2: error: ld returned 1 exit status
make[2]: *** [EXTENSION/Alerts/acsdkAlerts/test/CMakeFiles/AlertSchedulerTest.di                                                                                r/build.make:114: EXTENSION/Alerts/acsdkAlerts/test/AlertSchedulerTest] Error 1
make[1]: *** [CMakeFiles/Makefile2:7531: EXTENSION/Alerts/acsdkAlerts/test/CMake                                                                                Files/AlertSchedulerTest.dir/all] Error 2
make: *** [Makefile:160: all] Error 2

Same problem, in the #1404 they says to add set(CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -latomic") in the CMakeLists.txt but it doesnt work


Text on programs pages made visible

Description
This PR makes the text visible on the programs pages.
This PR fixes #994
Signed commits

[x] Yes, I signed my commits.

@UtkarshMishra12 can you please provide a review here

We will need to decide which colors to switch to in dark mode as current colors are making text invisible do you have any specific colors in mind?

Or should I try different colors?


bumpversion rewrites setup.cfg file

bumpversion rewrites setup.cfg file. It would be great if it just changed the version without doing that.

It doesn't due to a technical limitation with the parser it uses. You can use .bumpversion.cfg as an alternative.

I believe only version is changed, so why not simply use regexp like with other files (which I believe is being done).