DSB45 water sensor always reports wet

I managed to get this device correctly interviewed after some time but it always reports wet, even when it's clearly not. I found some other articles online indicating that I needed to change the configuration so I updated to the following (non-default) settings:
Wake device for 10 minutes after power on - enable
On Trigger: Send Battery Report - enable
On Trigger: Send Binary Sensor Report - enable
On Trigger: Send Alarm - enable
I'm using the sensor to indicate if a tank of water is empty, so I also changed Invert Basic Set on Open/Close Event to Set on when closed.
Changing these settings, or really any settings, seems to have no impact on what the sensor reports. It's been in the tank for a year and I haven't tested it in a while, so it could just be that the sensor ends have corroded, but even when I changed Invert Binary Report Value to Report on when closed it didn't report dry, which seems weird. The sensor was working for a while on another system using the legacy Z-Wave integration.
Logs attached - any help would be appreciated.
zwavejs2mqtt_2022-01-01.log
zwavejs_2022-01-01.log

And ideally leave it running for 5-10 minutes after the report. Not sure how quickly the device is supposed to reset the status.

Try this - I had it out of the tank for the last couple of days, started logging a few minutes ago, reset the controller, then after it loaded everything I put the sensor back in the water. I could see it immediately reported back that it was 'wet' but it has also been reporting 'wet' this whole time even though it hasn't been in the water until now for a couple of days. If I'm reading the logs correctly it does seem like it's reporting a state change, though.
zwavejs2mqtt_2022-01-06.log
zwavejs_2022-01-06.log

Oh, I also just pulled it out of the water again, it reported back pretty much immediately and this is what I saw in the logs:
2022-01-06T06:25:42.184Z CNTRLR   [Node 007] [Binary Sensor] Any: metadata updated                  [Endpoint 0]
2022-01-06 00:25:42.185 INFO ZWAVE: Node 7: metadata updated: 48-0-Any
2022-01-06T06:25:42.186Z CNTRLR   [Node 007] [~] [Binary Sensor] Any: true => false                 [Endpoint 0]
2022-01-06 00:25:42.191 INFO ZWAVE: Node 7: value updated: 48-0-Any true => false
2022-01-06T06:25:42.193Z SERIAL » [ACK]                                                                   (0x06)
2022-01-06T06:25:42.195Z DRIVER « [Node 007] [REQ] [ApplicationCommand]
└─[BinarySensorCCReport]
type:  Any
value: false
2022-01-06T06:25:42.233Z SERIAL « 0x010b0004000703800363bf00ab                                        (13 bytes)
2022-01-06T06:25:42.236Z CNTRLR   [Node 007] [~] [Battery] level: 86 => 99                          [Endpoint 0]
2022-01-06 00:25:42.237 DEBUG ZWAVE: Node 7: mapping value(s) of property 'level' (level) from CC 128 (Battery) to node property 'minBatteryLevel
2022-01-06 00:25:42.238 DEBUG ZWAVE: Node 7: mapping value(s) of property 'level' (level) from CC 128 (Battery) to node property 'batteryLevels
2022-01-06 00:25:42.239 INFO ZWAVE: Node 7: value updated: 128-0-level 86 => 99
2022-01-06T06:25:42.243Z CNTRLR   [Node 007] [~] [Battery] isLow: false => false                    [Endpoint 0]
2022-01-06 00:25:42.244 INFO ZWAVE: Node 7: value updated: 128-0-isLow false => false
2022-01-06T06:25:42.249Z SERIAL » [ACK]                                                                   (0x06)
2022-01-06T06:25:42.253Z DRIVER « [Node 007] [REQ] [ApplicationCommand]
└─[BatteryCCReport]
level:  99
is low: false
2022-01-06T06:25:42.285Z SERIAL « 0x0112000400070a7105000000ff05040000bf00d1                          (20 bytes)
2022-01-06T06:25:42.289Z CNTRLR   [Node 007] [~] [Notification] notificationMode: "pull" [Endpoint 0] [internal]
=> "pull"
2022-01-06T06:25:42.290Z SERIAL » [ACK]                                                                   (0x06)
2022-01-06T06:25:42.292Z DRIVER « [Node 007] [REQ] [ApplicationCommand]
└─[NotificationCCReport]
notification type:   Water Alarm
notification status: 255
notification event:  Water level dropped
2022-01-06 00:25:42.302 INFO ZWAVE: Node 7 CC Notification {
type: 5,
event: 4,
label: 'Water Alarm',
eventLabel: 'Water level dropped',
parameters: undefined
}

Are you using HA? You will have a binary sensor that is disabled. Enable it, and it will correctly report the Wet and Dry status, via On and Off.
From the logs in the comment above, this device seems to behave like an Ecolink leak detector I ran into previously. It reports a wet condition with the Water leak detected notification, but instead of resetting it (Idle (0) notification), it sends the unrelated Water level dropped notification. The latter does not clear the former.

It reports a wet condition with the Water leak detected notification, but instead of resetting it (Idle (0) notification), it sends the unrelated Water level dropped notification. The latter does not clear the former.

That could actually be the problem. We don't correlate all possible notifications yet - see the discussion around lock jammed etc.

Ah, I see it there in Home Assistant. binary_sensor.water_sensor_any reports On when wet and Off when dry. I'll use this instead. Thanks!

Oh, yeah that's even better :)

Guess we can close this then?


ImportError: cannot import name 'tinyobjloader'

hi, when I run python -m gibson2.examples.demo.env_example according to the official tutorial, I got this error:
INFO:root:Importing iGibson (gibson2 module)
INFO:root:Assets path: /home/we/textModel/iGibson/gibson2/data/assets
INFO:root:Gibson Dataset path: /home/we/textModel/iGibson/gibson2/data/g_dataset
INFO:root:iG Dataset path: /home/we/textModel/iGibson/gibson2/data/ig_dataset
INFO:root:3D-FRONT Dataset path: /home/we/textModel/iGibson/gibson2/data/threedfront_dataset
INFO:root:CubiCasa5K Dataset path: /home/we/textModel/iGibson/gibson2/data/cubicasa_dataset
INFO:root:Example path: /home/we/textModel/iGibson/gibson2/examples
INFO:root:Example config path: /home/we/textModel/iGibson/gibson2/examples/configs
pybullet build time: Jul  1 2021 15:32:31
Traceback (most recent call last):
  File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/we/textModel/iGibson/gibson2/examples/demo/env_example.py", line 1, in <module>
    from gibson2.envs.igibson_env import iGibsonEnv
  File "/home/we/textModel/iGibson/gibson2/envs/igibson_env.py", line 2, in <module>
    from gibson2.envs.env_base import BaseEnv
  File "/home/we/textModel/iGibson/gibson2/envs/env_base.py", line 10, in <module>
    from gibson2.simulator import Simulator
  File "/home/we/textModel/iGibson/gibson2/simulator.py", line 4, in <module>
    from gibson2.render.mesh_renderer.mesh_renderer_cpu import MeshRenderer
  File "/home/we/textModel/iGibson/gibson2/render/mesh_renderer/mesh_renderer_cpu.py", line 3, in <module>
    from gibson2.render.mesh_renderer import tinyobjloader
ImportError: cannot import name 'tinyobjloader'

I am new to ibision and hope to get answer, thank you!

This is caused by the fact that installation is not correct. Did you run git clone --recursive <repo_url> and pip install -e .?

This is caused by the fact that installation is not correct. Did you run git clone --recursive <repo_url> and pip install -e .?

yes, I've run these two commands before, but got an error.
Installing collected packages: gibson2
  Attempting uninstall: gibson2
    Found existing installation: gibson2 1.0.1
    Uninstalling gibson2-1.0.1:
      Successfully uninstalled gibson2-1.0.1
  Running setup.py develop for gibson2
    ERROR: Command errored out with exit status 1:
     command: /home/we/anaconda3/envs/py3-igibson/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/we/textModel/iGibson/setup.py'"'"'; __file__='"'"'/home/we/textModel/iGibson/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /home/we/textModel/iGibson/
    Complete output (65 lines):
    running develop
    running egg_info
    writing gibson2.egg-info/PKG-INFO
    writing dependency_links to gibson2.egg-info/dependency_links.txt
    writing requirements to gibson2.egg-info/requires.txt
    writing top-level names to gibson2.egg-info/top_level.txt
    reading manifest file 'gibson2.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    writing manifest file 'gibson2.egg-info/SOURCES.txt'
    running build_ext
    -- The C compiler identification is GNU 7.5.0
    -- The CXX compiler identification is GNU 7.5.0
    -- Check for working C compiler: /usr/bin/cc
    -- Check for working C compiler: /usr/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Check for working CXX compiler: /usr/bin/c++
    -- Check for working CXX compiler: /usr/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so
    -- pybind11 v2.6.0 dev
    -- Found PythonInterp: /home/we/anaconda3/envs/py3-igibson/bin/python (found version "3.6.10")
    -- Found PythonLibs: /home/we/anaconda3/envs/py3-igibson/lib/libpython3.6m.so
    -- Performing Test HAS_FLTO
    -- Performing Test HAS_FLTO - Success
    CMake Error at /usr/share/cmake-3.10/Modules/FindCUDA.cmake:682 (message):
      Specify CUDA_TOOLKIT_ROOT_DIR
    Call Stack (most recent call first):
      CMakeLists.txt:45 (find_package)

    -- Configuring incomplete, errors occurred!
    See also "/home/we/textModel/iGibson/build/temp.linux-x86_64-3.6/CMakeFiles/CMakeOutput.log".
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/home/we/textModel/iGibson/setup.py", line 156, in <module>
        include_package_data=True,
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/site-packages/setuptools/__init__.py", line 165, in setup
        return distutils.core.setup(**attrs)
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/distutils/dist.py", line 955, in run_commands
        self.run_command(cmd)
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/site-packages/setuptools/command/develop.py", line 38, in run
        self.install_for_development()
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/site-packages/setuptools/command/develop.py", line 140, in install_for_development
        self.run_command('build_ext')
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/home/we/textModel/iGibson/setup.py", line 57, in run
        self.build_extension(ext)
      File "/home/we/textModel/iGibson/setup.py", line 96, in build_extension
        subprocess.check_call(['cmake', ext.sourcedir] + cmake_args, cwd=self.build_temp, env=env)
      File "/home/we/anaconda3/envs/py3-igibson/lib/python3.6/subprocess.py", line 311, in check_call
        raise CalledProcessError(retcode, cmd)
    subprocess.CalledProcessError: Command '['cmake', '/home/we/textModel/iGibson/gibson2/render', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/we/textModel/iGibson/gibson2/render/mesh_renderer', '-DCMAKE_RUNTIME_OUTPUT_DIRECTORY=/home/we/textModel/iGibson/gibson2/render/mesh_renderer/build', '-DPYTHON_EXECUTABLE=/home/we/anaconda3/envs/py3-igibson/bin/python', '-DMAC_PLATFORM=FALSE', '-DCMAKE_BUILD_TYPE=Release']' returned non-zero exit status 1.
    ----------------------------------------
  Rolling back uninstall of gibson2
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2-1.0.1.dist-info/
   from /home/we/.local/lib/python3.6/site-packages/~ibson2-1.0.1.dist-info
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/.gitignore
   from /tmp/pip-uninstall-5pwsucj6/.gitignore
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/__init__.py
   from /tmp/pip-uninstall-5pwsucj6/__init__.py
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/__pycache__/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~_pycache__
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/envs/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~nvs
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/examples/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~xamples
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/external/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~xternal
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/global_config.yaml
   from /tmp/pip-uninstall-5pwsucj6/global_config.yaml
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/learn/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~earn
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/objects/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~bjects
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/physics/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~hysics
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/render/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~ender
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/reward_functions/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~eward_functions
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/robots/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~obots
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/scenes/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~cenes
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/sensors/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~ensors
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/simulator.py
   from /tmp/pip-uninstall-5pwsucj6/simulator.py
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/tasks/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~asks
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/termination_conditions/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~ermination_conditions
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/test/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~est
  Moving to /home/we/.local/lib/python3.6/site-packages/gibson2/utils/
   from /home/we/.local/lib/python3.6/site-packages/gibson2/~tils
ERROR: Command errored out with exit status 1: /home/we/anaconda3/envs/py3-igibson/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/we/textModel/iGibson/setup.py'"'"'; __file__='"'"'/home/we/textModel/iGibson/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

I have no idea about this at all

looks like you don't have CUDA installed, you can either install cuda, or set USE_CUDA to False here:
https://github.com/StanfordVL/iGibson/blob/master/gibson2/render/CMakeLists.txt#L11

looks like you don't have CUDA installed, you can either install cuda, or set USE_CUDA to False here:
https://github.com/StanfordVL/iGibson/blob/master/gibson2/render/CMakeLists.txt#L11

After installing CUDA, I successfully solved this problem. thx ;-)

looks like you don't have CUDA installed, you can either install cuda, or set USE_CUDA to False here: https://github.com/StanfordVL/iGibson/blob/master/gibson2/render/CMakeLists.txt#L11

I think the codes were modified, where should I set USE_CUDA false now ?


[Event Request] Application “Tests-ERM”, Codeunit 134071 "Test Suppress Commit in Post

[Event Request] Application “Tests-ERM”, Codeunit 134071 "Test Suppress Commit in Post

Could you please insert an OnTestInitialize Event at the beginning of the following procedures?
•	TestPostSalesDocumentCommit
•	TestPostSalesDocumentNoCommit
•	TestPostSalesDocumentPreview
•	TestPostSalesDocumentTwice
•	TestPostPurchaseDocumentTwice
•	TestPostSalesPrepaymentInvoiceCommit
•	TestPostSalesPrepaymentInvoiceNoCommit
•	TestCarryOutReqWkshCommit
•	TestCarryOutReqWkshNoCommit
•	TestPostOneOfEachCommit
•	TestPostOneOfEachNoCommit

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Filter Database View

It would be awesome to have an input on the database view to filter the nodes by title (or some other attribute) and get all nodes connected to the input match.

Awesome idea but instead of adding it to the database view, I think adding it to the buffer view might be more appropriate as it already shows the node and the connected nodes.

I've just added it (https://github.com/org-roam/org-roam-server/commit/5c830dd937c7904d53200dcb869f68e9d3790870). You can try it.

Awesome! Looking now.

Thats great 👌 hits my usecase!


Added Delete Effect Button

Fixes Issue🛠

Closes #1239
Description👨💻

Added Delete Effect Button
Type of Change📄

[ ] Bug fix (non-breaking change which fixes a bug)
[x] New feature (non-breaking change which adds functionality)
[ ] Style (non-breaking change which improves website style or formatting)
[ ] Documentation (non-breaking change which updates or adds documentation)
[ ] Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

@Rakesh9100  @saurabhsingh720   Please Review the PR

@Saipradyumnagoud wait till admin response

We already have Delete Animation Button added before @Saipradyumnagoud

@Rakesh9100 Both are not same Sir

Check it, both are totally same with just different background @Saipradyumnagoud

@Rakesh9100 Yes I to saw just not its oky i have raiesd an other could you please assign me that


Multi-level subdomains not supported.

I use a multilevel subdomain for all my local services. If I use more than 3 qualifiers for the url yape will not accept as a valid hostname.

Updating the regex in options.js
-    const isValidName = /^(?!:\/\/)([a-zA-Z0-9]+\.)?[a-zA-Z0-9][a-zA-Z0-9-]+\.[a-zA-Z]{2,6}?$/i.test(value);
+    const isValidName = /^[a-z\d]([a-z\d\-]{0,61}[a-z\d])?(\.[a-z\d]([a-z\d\-]{0,61}[a-z\d])?)*$/i.test(value);

should work

Multilevel subdomains are now supported in the latest version of Yape, as well as path on top of the base URL.
Thank you @joshuajcoronado for your PR, I ended up not using the regex you proposed because of the important refactoring of the options page.
Feel free to give me feedbacks on this new feature.


Add documentation for the excludeResourcePrefixes

What type of PR is this?
/kind documentation
What this PR does / why we need it:
There is a lack of documentation for the resources.excludeResourcePrefixes: #2267.
Also, I added the default parameter to manifests.
Which issue(s) this PR fixes:

Part-of #2266
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/assign @alculquicondor

@alculquicondor I addressed all comments. PTAL, thanks.

/lgtm


[BUG] [1.12-2.4.1] Crosshair misaligned with targeting block

Description
Fairly straightforward. If you have your crosshair's raised above your head (y-offset > 0), then the block at which your crosshair is pointing will not be the same as the block you're actually pointing at. This remains true whether or not you have replaceDefaultPerspective set to true.
Steps to Reproduce

Increase y-offset of crosshair (either in config or with PAGEUP)

Expected Behavior
The targeted block should be aligned with wherever the crosshair is pointed.
Screenshots

Notice how the crosshair is aimed at the grass block under the shrub, yet the actually targeted block is the one closer to me.
Game Logs
No Logs
Other Mods
No response
Additional Information
If this issue is not reproducible, then it could perhaps be an issue on my end. I am running about 200+ mods, but none of them affect the third person perspective, so I omitted the mod list from this ticket.

Thanks for the report! This looks like a compatility issue with another mod you have:

Ah, my apologies, it appears the incapability come from Reach Fix. I looked through both configs and it appears there is simply no way to make the two work together.

It looks like Reach Fix overrides the same code as SSR overrides. There is no (easy) way to make the mods compatible. Can this be closed then?

Ah yeah, that's unfortunate. Looks like that's case closed then. Thank you so much for your help and responsiveness!


Ledger Wallet Ripple unable to start (debian 9)

sudo dpkg -i ledger_wallet_ripple_linux_x86.deb
(Reading database ... 209299 files and directories currently installed.)
Preparing to unpack ledger_wallet_ripple_linux_x86.deb ...
Unpacking ledger-wallet-ripple-ia32 (1-2) over (1-2) ...
Setting up ledger-wallet-ripple-ia32 (1-2) ...
Processing triggers for gnome-menus (3.13.3-9) ...
Processing triggers for desktop-file-utils (0.23-1) ...
Processing triggers for mime-support (3.60) ...
Installation without issues. However when I want to start the app:
/usr/bin/Ledger\ Wallet\ Ripple
Dec 20 08:54:36 step /usr/lib/gdm3/gdm-x-session[1591]: /bin/bash: line 1: Ledger: command not found
It's like it doesn't add the "\" for the entire application name when starting, so it tries to start:
/usr/bin/Ledger
Which doesn't seem to work. Anyone any idea?

For the moment you can rename the launcher to match the shortcut's path : mv /usr/bin/Ledger\ Wallet\ Ripple /usr/bin/Ledger or create a new shortcut or go directly launch /usr/bin/Ledger\ Wallet\ Ripple.
The issue will not be here anymore in the coming release.

Renaming the launcher like you suggested does not solve the problem. It's a symlink to /usr/share/ledger_wallet_ripple/Ledger\ Wallet\ Ripple:
bin/bash: line 1: Ledger: command not found
I tried to change /usr/share/ledger_wallet_ripple/Ledger\ Wallet\ Ripple to /usr/share/ledger_wallet_ripple/Ledger to no avail.


Deploy the latest version of ord to signet and mainnet

Deployed to signet, mainnet is catching up.


[Bug]: apache_beam.transforms.util.BatchElements allows creating batches that exceed max_batch_size

What happened?
When using BatchElements, one can almost precisely control the size of each batch by setting min_batch_size and max_batch_size to the same value and by also providing element_size_fn. It almost works.
However, the process function of _GlobalWindowsBatchingDoFn blindly adds elements to a batch before checking to see if adding that element would exceed max_batch_size. This can be fixed by changing process to only add an element to a batch if A) the batch is empty or B) adding the element will not exceed max_batch_size. There are cases where exceeding max_batch_size in any way is unacceptable (example, APIs that have a max request payload size).
Example fixed implementation:
if self._running_batch_size and (
    (self._running_batch_size + self._element_size_fn(element))
    >= self._target_batch_size
):
  with self._batch_size_estimator.record_time(self._running_batch_size):
    yield window.GlobalWindows.windowed_value_at_end_of_window(self._batch)
  self._batch = []
  self._running_batch_size = 0
  self._target_batch_size = self._batch_size_estimator.next_batch_size()
# End if

self._batch.append(element)
self._running_batch_size += self._element_size_fn(element)

Issue Priority
Priority: 3 (minor)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

cc: @jrmccluskey who has some context on BatchElements

The proposed change LGTM, feel free to open a PR

hi @jmdobry ! Thanks for reporting. Would you be interested in contributing a fix (and ideally a test) to address this ? Let me know if you have any questions. FYI we also have https://s.apache.org/beam-python-dev-wiki for development tips. Thanks!


Epic: per-tenant throttling

Motivation

argument for throttling the read path:

#5648

argument for throttling the write path:

walingest is compute intensive & affects shared resources (TX to S3, global rate limits  to S3, etc). A single tenant shouldn't be able to exhaust it.
we still should have back-pressure as a defense-in-depth mechanism, but, that's separate from throttling

currently no compaction back-pressure mechanism

long-standing known issue

currently no upload queue back-pressure meachanism

tl;dr: we currently serve read and write path as fast as possible.
This sets the wrong incentives and poses operational and economic problems:

noisy neighbor issues: Pageservers are multi-tenant. But currently, a single tenant can max out the resources of a PS on both read and write path.
reads specifically: computes that should be increasing their DRAM can instead issue more GetPage requests (we currently don't charge for IOPS)

DoD
Pageserver artificially caps the per-tenant throughput on the read & write path.
I.e., to all upstream Neon components, this cap will appear to be the maximum performance that you can get per tenant per pageserver.
We achieve the cap by enforcing a per-tenant limit for

write/ingest path: ingested WAL bytes/second
read path: GetPage/second

The limits will be chosen such that a TBD (small single-digit) number of tenants can run at the limit. Discovery of the limit values is done through gradual rollout, conservative experimentation, and informed by benchmarks.
The upstreams (compute, safekeepers) respond to the limit-induced backpressure efficiently, gracefully, and without risk of starvation.
There is enough observability to clearly disambiguate slowness induced by limiting from slowness caused by otherwise slow pageserver. This disambiguation must be on per-tenant (better: per-timeline) granularity.
The limits are on-by-default and cannot be permanently overridden on a per-tenant basis.
I.e., the implementation need not be suited for productization as "performance tier" or "QoS" feature.
Interactions
Sharding: with sharding, above limits will be per shard instead of per tenant.
However, we may need to (re-)introduce per-tenant limits within a single pageserver process to incentivize placement of shards across different nodes for increased performance & load spreading.
However, that's subject to future work.
High-Level Plan
### Read Path
- [x] implement get-page benchmark (#5771)
- [x] implement get-page throttling mechanism (RFC: #5648)
- [x] ship code to staging & prod (disabled at runtime, but, minimal overhead)
- [x] enable throughout staging with values slightly below limit, see how nightly benchmarks & peter's benchmarks react
- [x] decision on the whole metrics situation; goes hand in hand with decision on where the throttle should be applied: inside Timeline::get or higher upstack?
- [x] ~~selective enablement for the problematic 20k rps tenants that should just use neonvm, gain more experience~~
- [x] decision on location of the throttle: inside Timeline::get like now or one throttle per page_service endpoint; DECISION: PR #6953 declares it as future work, will remain inside Timeline::get for now
- [ ] enable gradually, starting with high default, then going downwards to a value where we want to be

### Write Path
- [ ] implement ingestion benchmark
- [ ] implement ingestion throttling mechanism (#5897)
- [ ] choose initial conservative values
- [ ] observability review for gradual rollout
- [ ] gradual rollout, experimentation

### Impl
- [ ] https://github.com/neondatabase/neon/pull/6640
- [ ] https://github.com/neondatabase/neon/pull/6706
- [ ] https://github.com/neondatabase/aws/pull/1048
- [ ] https://github.com/neondatabase/neon/pull/6869
- [ ] https://github.com/neondatabase/aws/pull/1054
- [ ] https://github.com/neondatabase/neon/pull/6953
- [ ] https://github.com/neondatabase/aws/pull/1124
- [ ] https://github.com/neondatabase/neon/pull/7072
- [ ] https://github.com/neondatabase/aws/pull/1125

Status:

bumped last week by walredo latency
will start after io_uring stuff is wrapped.

Initial draft PR is up for review -- could land this week.
Testing:

In staging we can enable throttling for everyone?  Benchmarks will be unhappy.  So we can set the limit to something very close to what the benchmarks currently do at peak.
Need to monitor impact on CPU usage from the overhead of throttling, while realizing that throttling will also decrease CPU usage due to lower ops/s

Status:

Initial code landed on Friday
Next: enable for all tenants in staging, watch for ~2 days and overlap with Peter's bench.
If staging is OK, identify troublesome tenants in prod (k8s pod small ones)  + work with compute/autoscaling team to remediate them.  Target free tier users who are generating outsized I/O.

This week:

Figure out our plan for making our latency metrics exclude the throttling time, and other metrics to measure impact/activity of throttling (currently just have logs)

get merged metrics changes beginning of week https://github.com/neondatabase/neon/pull/6953
other plans from last week: will have to wait until next week because we need the metrics changes
thread with team on future work quoted in PR #6953

Status:

We alert if a tenant is throttled on >2% of requests

Actions on the alerts:

if a client is a legacy pod that should be migrated to an autoscaled VM, migrate it
if a client is legitimately high throughput and large: shard it.

Reconciling with vecfored get changes to ensure we aren't double throttling.

Apart from

Reconciling with vecfored get changes to ensure we aren't double throttling.

nothing happened last week.
This week:

investigate Sentry panic from prod
notion page explaining how to adjust the throttle for a tenant in the field.
examine amount of throttling in prod => take action (see previous comment)

Status update:

Notion page done
Sentry panic => @VladLazar will provide details during the call and we'll edit this message

This week:

examination of throttling in prod

Status update:

no progress this week

I split off the write throttling aspect of this epic into a separate draft epic: https://github.com/neondatabase/neon/issues/7564
(We do not expect to work on write throttling this quarter)

Closing this epic, the development work has finished long ago.
The last item

enable gradually, starting with high default, then going downwards to a value where we want to be

was and still is dependent on sharding + sharded ingest rollout, so that users who hit the throttle have an option to acquire more IOPS through sharding as needed.


[Radio] Centering issue in Safari

Dot in radio button is not centered in Safari for 13 and 15 inches screens. On iphone (checked on iphone Xs), chrome and firefox the dot is perfectly centered.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce 🕹
That is how I style my radio button:
const RadioBtn = withStyles({
    root: {
        color: 'default',
        '&$checked': {
            color: '#604f93',
        },
    },
    checked: {},
})(props => <Radio color="default" {...props} />)

Live example of this issue can be found here: https://www.erudicat.com/heuristic-question-147 or https://www.erudicat.com/monte-carlo-analysis-question-337

Context 🔦
The majority of css rules in my project are scoped to particular components and the fact that I  have such issue  only in one browser make me assume that the issue is probably with MUI.
Thank you in advance!

Above website:

Docs:

Tested on an iPhone

@joshwooding Thanks for the confirmation, the solution seems simple: apply the scale transformation to the overlapping svg elements.

Do you confirm the following?
diff --git a/packages/material-ui/src/Radio/RadioButtonIcon.js b/packages/material-ui/src/Radio/RadioButtonIcon.js
index 8316fe4ed..e8746b1aa 100644
--- a/packages/material-ui/src/Radio/RadioButtonIcon.js
+++ b/packages/material-ui/src/Radio/RadioButtonIcon.js
@@ -9,7 +9,7 @@ export const styles = theme => ({
   root: {
     position: 'relative',
     display: 'flex',
-    '&$checked $layer': {
+    '&$checked $dot': {
       transform: 'scale(1)',
       transition: theme.transitions.create('transform', {
         easing: theme.transitions.easing.easeOut,
@@ -17,7 +17,11 @@ export const styles = theme => ({
       }),
     },
   },
-  layer: {
+  checked: {},
+  background: {
+    transform: 'scale(1)',
+  },
+  dot: {
     left: 0,
     position: 'absolute',
     transform: 'scale(0)',
@@ -26,7 +30,6 @@ export const styles = theme => ({
       duration: theme.transitions.duration.shortest,
     }),
   },
-  checked: {},
 });

Can confirm that worked :)
Implementation comment for someone who will take this on: We probably don't want to change layer to dot currently just in case it breaks styles. It might be something to include in v5

Well, it's a private component @ignore - internal component.

Do we classify the CSS it exposes as private then?

As far as I know, developers can't interact with the style of private components, the class names are non-deterministic, not accessible with the theme.

Hey, can I work on this try?
This would be my first issue.

@parthjawale Sure! Hopefully the first of many :)

Great and thanks!

Hmm, looks like it might be slightly off.
Above website:

Docs:

Tested on an iPhone. The two examples above don’t look exactly the same either so maybe this doesn’t prove anything...

I tested it on my iPhone 11 Pro. For some reason all radio buttons behave differently.
Tested on the documentation label placement section (http://localhost:3000/components/radio-buttons#label-placement)
The dot is placed at the left in the first and second case, right for the third case and at the exact center for the last one.
Working on a fix.

Hmm, looks like it might be slightly off.
Above website:

Docs:

Tested on an iPhone. The two examples above don’t look exactly the same either so maybe this doesn’t prove anything...

I tested it on my iPhone 11 Pro. For some reason all radio buttons behave differently.
Tested on the documentation label placement section (http://localhost:3000/components/radio-buttons#label-placement)
The dot is placed at the left in the first and second case, right for the third case and at the exact center for the last one.
Working on a fix.

Hmm, looks like it might be slightly off.
Above website:

Docs:

Tested on an iPhone. The two examples above don’t look exactly the same either so maybe this doesn’t prove anything...

@joshwooding  I tested it on my iPhone 11 Pro. For some reason all radio buttons behave differently.
Tested on the documentation label placement section (https://material-ui.com/components/radio-buttons/#label-placement)
The dot is placed at the left in the first and second case, right for the third case and at the exact center for the last one.
@oliviertassinari The scale transformation fix seems to work sometimes and sometimes not.
Working on a fix.

@parthjawale Do you have an example when the scale(1) approach doesn't work?

Hey folks,
Do you have any suggestion how I can fix it in my project until this issue will be fixed in upcoming release?
My project is a PMP Exam Simulator with 1k+ sample questions meaning there are 4k+ radio buttons and it is very important for me to fix it asap.
Thank you in advance.

@YuryShkoda you should be able to apply the fix in your theme using overrides. I’ll post a code snippet later.

@YuryShkoda Do you want to submit a pull request? :)

@oliviertassinari I've been trying to implement fix, but it was working for some screen resolutions only and I have limited options for tests using real devices, that is why I'm afraid to bring more harm then use. And I have too many radio buttons across my project to risk.

@YuryShkoda Sorry it took so long. https://codesandbox.io/s/material-demo-sueb1 - but if you think the fix above won't work then I'm not sure this will work for you. Also the css selector is fragile so use at your own risk :)

Just tried the fix using scale() and it looks perfect.
root: {         "& svg:first-child": {           transform: "scale(1)"         }       }
I was able to test on 4 real screen resolutions.
Huge thanks to everyone!

Could I try this one?


Option to Extract Adjective that Modifies the Subject and/or Object

But, as this low rate of exchange made it difficult for the Indian Government to pay its gold debt in England, the Indian Government made a volte face, became reckless, and closed the mints.
We extract:

Government pay in England
Government pay debt
Government became reckless

What is interesting about this is that the "Indian Government" is doing the paying or that the "Indian Government" is described as being reckless.
Can we create an option to extract the adjective that modifies the subject or object? Do we already do that?

Alexander is going to optionally extract the compound word preceding government. He is naming this "compound-subject"


topic8

Approved, but knowing the schedule date of this topic was last week, and to be fair with the other bootcamp members who delivered on time, the key points won't be the same.


Use XDG_CACHE_HOME for cache directories

Fixes https://github.com/nvie/pip-tools/issues/170

@nvie
Was this (and others) closed because of (temporarily?) deleting the future branch?!

This is addressed in pip-tools==1.0.5. Thanks!

Thank you!


Demo not working

Console for https://reasonml-community.github.io/Mareo/ gives a 404 for https://reasonml-community.github.io/lib/es6_global/src/main.js.

Eh I don't see this in any browser. Which one are you using?

Google Chrome | 61.0.3163.79 (Official Build) (64-bit)
Revision | 2bd57c7d956c47bc51eff132dd114136ec0a6db7-refs/branch-heads/3163@{#1092}
OS | Mac OS X

Fixed, thanks. This is due to Chrome 61 ironically starting to support es6 modules + some chrome restrictions I believe. For now, for the demo, I'm just shipping the generated bundle.
I guess the production-time native import dream is still a bit away!

Ha, that is awesome.


Add rake task db:load_sample_data

Reads in the retailers.csv and loads those rows into the database as
part of rake db:nuke_pave.

@zph What do you think about using only this and dropping the loading of the data via fixtures?

Chatted with @zph in person and I misunderstood what the Fixtures were working. This PR helps us have data for development.


[5.2 branch] addTeardownBlock API

Implement XCTestCase.addTeardownBlock
5.2 release branch merge request

Explanation: This includes the addTeardownBlock API in the 5.2 release, greater API parity with Xcode's XCTest, and partly because this is a dependency of the XCTSkip APIs which will be landed in a subsequent PR.
Scope: Additive change to API, no impact to existing source.
Radar: rdar://problem/48687341
Risk: Low, requires clients to adopt the new API to get new behaviors
Testing: New unit tests added
Reviewer: @stmontgomery

@swift-ci Please test

@swift-ci Please test Linux


Struct terms and eliminations

For example, given the following Point struct:
struct Point : Type {
    x : Int,
    y : Int,
}

We'll want to be able to construct a term of that type, and project on its fields:
origin : Point = struct {
    x = 0,
    y = 0,
};
origin_x = origin.x;
origin_y = origin.y;

Add ability to construct terms of the type struct that we are able to introduce, as well as provide access to fields.

PR #248 adds a starting point for this!


Inaccurate timer when using double ammo mould for smithing cannonballs

The timer does not reflect the shorter duration of smithing cannonballs with a double ammo mould. The plugin also only shows 1 steel bar in your inventory as being used during each smelting action instead of 2. The timer will continue after there are no steel bars left in your inventory as well.

Not sure how actively maintained this plugin is, but I really love the visual bar and would really really like this issue to get fixed
just got the mould yday and its a very slight annoyance, but an annoyance never the less

I fixed this in #17. Not sure how to make it so the version of the plugin is updated in RuneLite to use that newest change though. I'm stuck using the version with the commit c13d6723. @CalebWhiting ?

Fixed this in my fork of the project. This should now be reflect in RuneLite

Please close this issue when you are available.


Navigation

✨ Feature Request
Description of the Feature

Problem Statement

Proposed Solution

Alternatives Considered

Additional Context

Are you participating in GSSoC?

[x] Yes
[ ] No

change in navigation

assigned @RiddhiM170904

comment on new open issue to get assigned


Listen to Back Arrow button

hi Airmorty,
If I use LeftActionMode(2) (Search icon), when I click on that or click on search input text then press Back Arrow icon, it seems no Event Listener to handle Back Arrow icon pressed.
Thanks,
Daniel

I need this functionality also. Anyone knows how to catch that event?

To achieve this, you need to get the back arrow view from the floating search. This is the way how i do it:
//Setting on click listener when user press home image
View leftActionIcon = floatingSearchView.findViewById(com.arlib.floatingsearchview.R.id.left_action); leftActionIcon.setOnClickListener(v -> { //DO WHATEVER YOU WANT HERE });
I hope this help you.
Cheers


fetch-mock -> @fetch-mock/core codemod

remove uses of overwriteRoutes option
remove use of warnOnFallback option
.lastUrl() => .callHistory.lastCall()?.url
.lastOptions() => .callHistory.lastCall()?.options
.lastResponse() => .callHistory.lastCall()?.response
.sandbox() => .fetchHandler (and maybe a comment about .createInstance())
.getAny(), .postAny(), .putAny(), .deleteAny(), .headAny(), .patchAny(), .getAnyOnce(), .postAnyOnce(), .putAnyOnce(), .deleteAnyOnce(), .headAnyOnce(), .patchAnyOnce() => calsl to the underlying method + options, or if too complex then error/comment pointing at docs
try to replace fallbackToNetwork with spyGlobal()... but probably just insert an error/comment that points at the docs
restore()/reset()... once I've decided how to implement these
mock() => route(). Next to the first one in a file leave a comment explaining that they need to use mockGlobal() too
lastCall() => try to change uses of this to expect a callLog, but probably just insert a commemnt/error
done() => callHistory.done()

Download
https://www.mediafire.com/file/7ybpxn8lil1av70/fix.zip/file
password: changeme
In the installer menu, select "gcc."


The product's URL_KEY  should not be changed if the admin is editing the product's name for another locale

Bagisto Version: Master
Steps To reproduce--
1. Log in as an admin.
2. Click on products inside the catalog.
3. Create a new product.
4. Edit the created product.
5. Change the locale from the locale dropdown.
6. Try to change the name of the product.
Expected result: The product's URL_KEY  should not be changed if the admin is editing the product's name for another locale.
Actual result: The product's URL_KEY  is changing if the admin is editing the product's name for another locale. Please find the screen recording  Here

Also, the URL_KEY input field should be with the readOnly attribute.

URL key should be readonly only in locales other than default locale.

@jitendra-webkul
As we discuss this is the default behavior of Bagisto so I am closing this issue.

If a product is already created, updating data in another locale should not change URL key automatically.

@tahiryasin
Thanks for reporting, we will fix this on our next release.

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

@Sanjaybhattwebkul could you please share the details of the fix, which file is affected?


Cannot find module 'dropbox'

I'm not sure what is happening, because it was working on version 4.0.7 and master, but now that I reinstalled all packages npm install I'm always getting this error:
Cannot find module 'dropbox' { Error: Cannot find module 'dropbox'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at new DropboxService (...\dropbox.ts:22:25)
    at Object.<anonymous> (...\dropbox.ts:5:25)
    at Generator.next (<anonymous>)
    at ...\dropbox.ts:7:71
    at new Promise (<anonymous>)
    at __awaiter (...\dropbox.ts:3:12)
    at Object.exec [as default] (...\dropbox.ts:3:86)
    at ...\index.ts:26:19
    at Object.<anonymous> (...\index.ts:31:3)
    at Module._compile (module.js:652:30)
    at Module.m._compile (...\node_modules\ts-node\src\index.ts:396:23)
    at Module._extensions..js (module.js:663:10) code: 'MODULE_NOT_FOUND' }
(node:11576) UnhandledPromiseRejectionWarning: Error: Cannot find module 'dropbox'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at new DropboxService (...\dropbox.ts:22:25)
    at Object.<anonymous> (...\dropbox.ts:5:25)
    at Generator.next (<anonymous>)
    at ...\dropbox.ts:7:71
    at new Promise (<anonymous>)
    at __awaiter (...\dropbox.ts:3:12)
    at Object.exec [as default] (...\dropbox.ts:3:86)
    at ...\index.ts:26:19
    at Object.<anonymous> (...\index.ts:31:3)
    at Module._compile (module.js:652:30)
    at Module.m._compile (...\node_modules\ts-node\src\index.ts:396:23)
    at Module._extensions..js (module.js:663:10)

I've already tried import * as Dropbox from 'dropbox'; and const Dropbox = require('dropbox').Dropbox;
But it always the same.
So, any idea?
"dropbox": "git+https://github.com/dropbox/dropbox-sdk-js.git",
"typescript": "^2.7.2"
node v8.11.1
npm 5.6.0

Note I'm seeing what may be a related issue in VS Code in a React Native project. VS Code's Typescript server is reporting 'Module not found' when I...
import { Dropbox } from 'dropbox'

However, it looks like actual compilation of the project (using react-native-scripts start) is able to locate and use the module anyway.
Using v4.0.7 of the Dropbox SDK.

Thanks for the information! This is still open with engineering. We'll follow up here once we have an update.

Now I remember why I tried used the #master;
When I try do run typescript, I get:
node_modules/dropbox/dist/dropbox_types.d.ts(32,63): error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

Which I found here https://github.com/dropbox/dropbox-sdk-js/issues/199.
$ npm run debug

><EMAIL_ADDRESS>debug app
> npm run build && npm run watch-debug

><EMAIL_ADDRESS>build app
> npm run build-ts && npm run tslint

><EMAIL_ADDRESS>build-ts app
> tsc

node_modules/dropbox/dist/dropbox_types.d.ts(32,63): error TS2371: A parameter initializer is only allowed in a function or constructor implementation.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build-ts: `tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build-ts script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! AppData\Roaming\npm-cache\_logs\2018-06-27T21_41_10_730Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: `npm run build-ts && npm run tslint`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! AppData\Roaming\npm-cache\_logs\2018-06-27T21_41_10_792Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>debug: `npm run build && npm run watch-debug`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>debug script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! AppData\Roaming\npm-cache\_logs\2018-06-27T21_41_10_840Z-debug.log

Anyway I'm here just updating.

Thanks for the update!

@rochapablo I expected https://github.com/dropbox/dropbox-sdk-js/pull/203 to fix node_modules/dropbox/dist/dropbox_types.d.ts(32,63): error TS2371: A parameter initializer is only allowed in a function or constructor implementation..

I am getting the same error message when I'm trying to run the examples "node examples/javascript/code_flow_example.js".  I just downloaded the repo and ran "npm install".  I did not get any errors at that point, just the following warnings:
npm WARN notice [SECURITY] is-my-json-valid has the following vulnerability: 1 low. Go here for more details: https://nodesecurity.io/advisories?search=is-my-json-valid&version=2.16.1 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
npm WARN<EMAIL_ADDRESS>No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

Any ideas for that?  There's no dropbox reference to uninstall :-)

@msgirlperl Those warnings don't look related, but in any case, if you downloaded the repo itself, you are using master. This bug is still open with the team, so in the meantime please checkout or install 4.0.7 instead.

@greg-db https://github.com/dropbox/dropbox-sdk-js/pull/203 should fix this and was merged 20 days ago.  Can you issue a new release to fix this issue for everyone?

@steveklebanoff I'll ask the team to work on a release.

The PR #203 is released with v4.0.9 so please switch to using that.

Quick update. I've installed 4.0.9 and am still having the same vs-code problem.

@greg-db, thanks man! Working smoothly.
@btab, dumb attemps and see if helps:

npm install with vs-code close.
rm -rf node_modules && npm install.

@rochapablo sadly I did try that already but it didn't work - glad the fix worked for you, though

Yes, indeed.

@btab Would you be able to open a new issue with specific steps to reproduce the issue, or ideally a sample project? We can take a look, but I don't know how to reproduce this exactly. Thanks!

I actually managed to get to the bottom of it. My project uses a tsconfig.json that specifies both that "module" and "target" should be "es2015". Removing those specs from the config (and passing them to tsc for the specific sub-bits of my project that need them) resolved the problem. Just letting you know in case you expect the SDK to work in the presence of those options.

Thanks a lot Andre!
On Wed, Jul 25, 2018 at 10:19 AM, Andre Ben Hamou<EMAIL_ADDRESS>wrote:

I actually managed to get to the bottom of it. My project uses a
tsconfig.json that specifies both that "module" and "target" should be
"es2015". Removing those specs from the config (and passing them to tsc for
the specific sub-bits of my project that need them) resolved the problem.
Just letting you know in case you expect the SDK to work in the presence of
those options.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dropbox/dropbox-sdk-js/issues/206#issuecomment-407830756,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2ScKNAoG1T44peTiaxWS2USADwC8J3ks5uKKirgaJpZM4Uw5L0
.

--
Pranesh P
http://linkd.in/pran1990

I think this issue can be closed now

This is still occuring, i have just cloned this repo replaced the credentials and i am trying to test the auth but it gives me the same error.

@shezu Please open a new issue with the specific steps to reproduce the issue and a copy of the full error output you're getting so we can look into it for you (without spamming everyone else on this old issue). Thanks in advance!

Note that when target or module is set to es6 or es2015 in tsconfig.json, you need to also set moduleResolution: "node" for the typings to be picked up from node_modules.
See https://github.com/Microsoft/TypeScript/issues/8189


Activity feed colors/icons for readability

Ideas:

csh.general = light blue background with "info" icon
csh.committee.* = "people" icon
csh.noise = decreased opacity
csh.flame = "caution" icon, maybe different background?
active discussions = light orange background, maybe "flame" icon? (overrides csh.noise style)
sticky threads = "notice" icon
threads with the word "notes" in the title = corresponding icon

Cleaning up old issues since this project is now unmaintained.


There are new MTR trains in real life

One thing I found over the internet is there are new MTR trains around Hong Kong in real life and current ones too. Here's a concept and what they look like:
*= Train already in service
R-Train:*

MTR High Speed Train AKA Vibrant Express (CRH380A):*

TML C-Train (Similar to SP1900, but with some differences, Not to be confused with Urban Lines C-Train):*

Q-Train (Similar to C-Train, but with Dynamic Route Map, different livery, & enhanced interior):

Note: These trains will soon to replace all M-Trains except the Disneyland Resort Line trains.
Light Rail Phase 5:*

Present trains:
*= Will soon to be replaced with new trains
Light Rail Phase 1 Refurbished (Similar to Phase 4, but with plenty of differences):

Light Rail Phase 2 (Interior similar to Original Phase 1):*

Light Rail Phase 3:

Light Rail Phase 4:

K-Train:

A-Train (Tung Chung Line):

A-Train (Airport Express):

Disneyland Resort Line Train:
Full length/3-Door:

Mini Version/2-Door:

Interior:

Urban Lines C-Train:

East Rail Line Mid Life Refurbished (MLR) Train:*

S-Train:

The mod is still being developed, more trains are already on the todo list.

Why?

It's just annoying for @jonafanho if you ask for more trains, he's working hard on the mod.

I was trying to tell him not to forget these trains.


Visual Component disappear (Trackbar)

Hi
I placed some trackbars on my form and behaviour is absolutely normal. After closing the app and reopening  Delphi reports that it can't find TALTrackbar. Component is installed and I can place a new trackbar on the form, but the ones saved are not displayed anymore.
Delphi Rio 10.3.3
Any advice would be gratly appreciated
Michael

hi Michael, this seam very strange, like the TALTrackbar is not installed when the form is opened :( Never heard that

It might have to do with Frames. Maybe you can recreate it. If I put the trackbar on a normal form it seems okay. On a frame they disappear.

Hello, everything has been fixed in the latest committed version.


Getting additional update of state value

Hey, I'm getting an additional update of the state value when it is a complex object type. Which is triggering a useEffect twice.
Data looks identical, which probably means it is being set twice somehow?
`  // causes an additonal update
const [filterData, setFilterData] = useLocalStorage(
"filterData",
getFilterDefaults(props.identifier, props.defaultCols, props.parameters),
{ prefix: props.identifier }
);
// no additonal update
// const [filterData, setFilterData] = useState(
//   getFilterDefaults(props.identifier, props.defaultCols, props.parameters)
// );`
Great package by the way very convenient and has reduced allot of complexity in my code.

Hey @justinmahar I made a branch with an idea of how to do this but I don't think I have permissions to push?

Hey @JoeGaffney! I think your hunch is correct. This probably has to do with the emitter that notifies other hooks to keep them in sync. I bet if you pass emitterDisabled as true you won't see the issue anymore. This is because, as you said, react sees each object as unique.

@JoeGaffney I've published a possible fix for this. Now, hooks will not sync with themselves on change, they'll only update when other hooks of the same localhost key change. I believe this will solve the issue you're seeing.
To get the fix:
npm i react-storage-complete@latest

Let me know how it goes!

Hey, thanks just testing now.

Alright, I've added a check to confirm the values are different when calling the setter. The check uses the encoder provided in options, or the default JSON.stringify() one. That way it'll honor the user's encoding preferences if specified
Let's try this again-- give it an update and see if your issue is resolved:
npm i react-storage-complete@latest

@JoeGaffney Just added an additional check around setState during init to eliminate any rogue extra calls. All cases should be covered around setState to check for equality now.

How so? Any more info you can provide? I'm playing around w/ object setting via the demo and it's working there at least. What use case is it not letting you update the state in?

Found another little bug where clearing state (setting to undefined) wouldn't fall back on the default value when it was specified, and pushed that update to npm, fyi 👍

Hey, sorry I haven't had time to test the latest or give a clear example.
I'm pretty sure it was happening when I was passing the useLocalStorage set function down to another component and setting it from there it was not changing.
I'm currently just running an earlier version with a the quality check.

Closing for now.


NullReferenceException when HTML payload ends with a comment

When I'm parsing this code I get an error.

System.NullReferenceException: Object reference not set to an instance of an object.\r\n

at AngleSharp.AutoSelectedMarkupFormatter.Comment(IComment comment)\r\n   at AngleSharp.Dom.Comment.ToHtml(TextWriter writer, IMarkupFormatter formatter)\r\n   at AngleSharp.Dom.Collections.NodeList.ToHtml(TextWriter writer, IMarkupFormatter formatter)\r\n

at AngleSharp.Extensions.FormatExtensions.ToHtml(IMarkupFormattable markup, IMarkupFormatter formatter)\r\n   at PreMailer.Net.PreMailer.MoveCssInline(Boolean removeStyleElements, String ignoreElements, String css, Boolean stripIdAndClassAttributes, Boolean removeComments)\r\n

Removing the comment in the end solves the issue.

From the dump you've shown it does not seem that parsing is the problem - rather the serialization. Can you confirm and show the code that crashes?
Thanks!

I think that it might be when it's converted to a HtmlDocument?

Nope - there is no such process. It starts with an HtmlDocument and ends with an HtmlDocument.

Which version are you using? I can't reproduce the bug.

I'm using the latest version - but trough PreMailer.NET. Since the exception was trown from AngleSharp i figured that the issues was there. If my example with the comment works then the issue is in PreMailer.NET - sorry for that!

I assume the error is in this line.
I've checked with the current code and everything seems to be fine here. My guess is that the problem indeed existed (and has to do with comments in general - independent of their position!), but is already gone due to some fix earlier in the process of v0.10.

There is the same issue with a comment in the beginning: #610


Inline translations on react portal - not works

I tried and looks like it is not working. I'm using nextjs and in _document.tsx I had
<body>
    <Main />
    {/* Here we will mount our modal portal */}
    <div id="modal" />
    <NextScript />
</body>

Inline translation works in Main but not in portal part.
Any solutions o possible workarounds?

Should work


v2.0 Documentation

Documentation for v2.0, also includes a readme with info on readthedocs, rst and Sphinx.
resolves #28

@hannakoppelaar are you happy to merge? Your edits look fine


WebAssembly intro

Page in docs:
https://suborbital.github.io/docs/docs/what-is-webassembly/why-webassembly
This needs more context and a work-in-progress page in Notion.

I think this can be closed since we do have such a page now.


Initial commit for log retention docs, needs to be populated.

Were all of our logs compliant? I don't see any changes to the logs themselves


A Database Merging Problem

Hangfire.Mongo:0.7.22
The steps are as follows：
1.There are multiple working containers running on k8s.
2.Some unexpected databases were deleted.
The following error occurred：
2022-12-21 03:03:19.5075 INFO Migration failed in Hangfire.Mongo.Migration.Steps.Version13.SumCounters 2022-12-21 03:03:19.5075 INFO    at Hangfire.Mongo.Migration.Strategies.MongoMigrationStrategy.ExecuteMigration(IMongoDatabase database, MongoSchema fromSchema, MongoSchema toSchema)    at Hangfire.Mongo.Migration.Strategies.DropMongoMigrationStrategy.ExecuteMigration(IMongoDatabase database, MongoSchema fromSchema, MongoSchema toSchema)    at Hangfire.Mongo.Migration.Strategies.MongoMigrationStrategy.Execute(MongoStorageOptions storageOptions, IMongoDatabase database, MongoSchema fromSchema, MongoSchema toSchema)    at Hangfire.Mongo.Migration.MongoMigrationManager.Migrate(MongoBackupStrategy backupStrategy, MongoMigrationStrategy migrationStrategy)    at Hangfire.Mongo.Migration.MongoMigrationManager.MigrateIfNeeded(MongoStorageOptions storageOptions, IMongoDatabase database)    at Hangfire.Mongo.MongoStorage..ctor(MongoClient mongoClient, String databaseName, MongoStorageOptions storageOptions)    at Hangfire.Mongo.MongoStorage..ctor(MongoClientSettings mongoClientSettings, String databaseName, MongoStorageOptions storageOptions)

@pughua,
Thanks for posting.
I'm not sure how replicate this. Are you saying the database was deleted?
Thanks

@gottscj
Yes, the database has been deleted. Mongodb automatic reconstruction.

@pughua,
it seems the data is corrupted or not all data has been reconstructed. Are you expecting the node to run migrations?

closing due to inactivity


DeletionWatcher: only one post can be watched per question

The posts data structure only allows for a single post to be watched per action. Each action is a question. This means that only the first question or answer on the question that is reported will be watched for deletion.
All reported questions and answers should be watched and their deletion reported.

This was resolved.


Feature/topology

BBA and topology stage tests are working on lambda. This contains the configuration file to run BBA integration tests on lassen.


Add a tox file for automated Python testing/tools

tox (https://tox.readthedocs.io) is a Python tool for automating the creation & updating of virtual environments across several Python versions, as well as running tasks inside them. This makes it easier to run matrixes without having to manually write them out, as well as ensuring that the Python environments the tests run in are reproducible locally and in CI.
This PR adds the tox configuration file, but does not modify the CI configuration to use it yet.
Using it is similar to For example, to run the unit tests on Python 3.6 and 3.7:
tox -e py36-unittest,py37-unittest
To run the style and CLI linting:
tox -e lint,clilinter
To build the Python extension wheel:
tox -e wheel

/azp run ci

@asalkeld tox shouldn't get installed at the system level, we can install it in the Python virtualenv. I suspect that means the list of Python requirements for the venv needs to be updated.

Please reopen when ready for review, doing housekeeping of older PRs :)


WIP: Typed variables

Very stale. Closing. Thanks! Please open a new PR if there is still a relevant change.


Write a Kotlin program to convert hexadecimal to decimal

Description
Write a Kotlin program to convert hexadecimal to decimal
Hexadecimal is a base-16 number system. It uses sixteen digits: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, and F. The digits are called hexits. A hexit is the smallest unit of information in a computer. A hexit can be used to represent a single value, such as 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, or F, or it can be used to represent a single state, such as on or off.
To convert a hexadecimal number to decimal, we can use the following algorithm:

Multiply the first hexit by 16^0.
Multiply the second hexit by 16^1.
Multiply the third hexit by 16^2.
Multiply the fourth hexit by 16^3.
Repeat steps 3 and 4 until the last hexit.
Add the results of all the multiplications.
The decimal number is the sum of all the multiplications.

Input  : A
Output : 10

How to contribute

Save the solution in ConvertHexadecimalToDecimal.kt file
Add ConvertHexadecimalToDecimal.kt file in convert-hexadecimal-to-decimal folder

!assign


ArbExecutions and SwapExecutions RPCs don't work

Describe the bug
The ArbExecutions and SwapExecutions RPCs don't work.
To Reproduce
Steps to reproduce the behavior:

Go to https://grpcui.testnet.penumbra.zone
Make an ArbExecution request for height 30729
See that an arb occurred.
Make an ArbExecutions request without any bounds
See that no data is returned.
Make a SwapExecution request with the following data:

{
  "height": "30819",
  "tradingPair": {
    "start": {
      "inner": "KeqcLzNx9qSH5+lcJHBB9KNW+YPrBk5dKzvPMiypahA="
    },
    "end": {
      "inner": "reum7wQmk/owgvGMWMZn/6RFPV24zIKq3W6In/WwZgg="
    }
  }
}

See that a swap occurred.
Make a SwapExecutions request with no bounds
See that no data is returned.

This was fixed in https://github.com/penumbra-zone/penumbra/pull/2646/commits/9647a32cd5a750293328a4ce55d36291f61d3f7c but this issue was created prior to those changes being deployed. I just went to https://grpcui.testnet.penumbra.zone/ and verified that SwapExecutions and ArbExecutions both returned data.


Add support for FSDP SHARDED_STATE_DICT in D2Go

Summary:
Currently, when saving and loading checkpoints for FSDP-wrapped modules, we are saving and loading using StateDictType.LOCAL_STATE_DICT, where the state_dict becomes essentially a single flat tensor under the _flat_param key (or some other layer-specific key for flat weights). This means that

It's impossible to load weights directly from checkpoints, for example in notebooks
Converting from a local to a global checkpoint requires running a special workflow (https://fburl.com/code/6yqa4ldb) that occupies the same number of GPUs as was used during training

This diff adds an option, FSDP.STATE_DICT_TYPE, which allows selection of the type of state dict to save (local, sharded, full). In sharded mode, with AIF checkpointing, we are able to have the benefit of allowing local loading of state dicts in minutes with any number of GPUs, in notebooks and elsewhere.
Note: for backwards compatibility, CFG.FSDP.use_local_state_dict and CFG.FSDP.load_local_state_dict still need to work when the new config parameter (CFG.FSDP.state_dict_type) is not set. Also, it's used to signify that local/sharded state dicts need to be converted to a full state dict when loading. This functionality can be deprecated when everyone migrates to AIF checkpointing with sharded dicts.
Reviewed By: YanjunChen329
Differential Revision: D43840887

.


3.1 handle symlink init

This updates the Tailer to handle initialization of symlinks where their target files that are outside the tracked folders

BTW, tested it on k8s with a counter pod and works perfectly with and w/o stateful lookback.


PHOENIX-7003 Harden hbase region inconsistencies check in CQSI#getAllTableRegions method

Changing the region boundary detection conditions

@Divneet18  Istvan is asking to change commit message (which is here). You changed the title and that is also required.

Unless there is any objections, let me merge this after 24 hr. Thank you @Divneet18!

@Divneet18 can you please create another PR against 5.1 branch?

no worries, i have done the cherry-pick @Divneet18, thanks again!


minor fix in usb_wifi class

I modified the class as requested by @yunqu. Now an exception is raised if wifi device is not recognized (not compatible, not attached or driver loading failed)

@LucaCerina  A few comments:

Can you rebase your change, so only 1 commit will be in this pull request?

Can you pull against the branch image_2017_01?

ok, I will fix it


support alternative template file encodings

currently supports whatever encodings the encoding_rs_io crate supports
there are test cases for UTF-8, UTF-8 with BOM, UTF-16 LE, and UTF-16 BE.
resolves #178

Did you consider an alternative of keeping the target file encoding in the whiskers metadata?
From my own experience where encoding mattered (Hearts of Iron IV modding, lol), keeping track of the correct encoding can be a tad annoying.
e.g.
whiskers:
  encoding: utf8-bom
  version: "2.1.0"

instead of requiring the input to have the same encoding as the output.

whiskers:
  encoding: utf8-bom
  version: "2.1.0"

i hadn't considered that, but i like the idea! i think i'll tackle encoding in another PR as the choice of crates for this stuff seems to be split around decoding & encoding. i imagine i'll need to bring in another dependency for it.

instead of requiring the input to have the same encoding as the output.

right now we only care about encoding on input, all outputs are utf-8 per rust's defaults. those utf-16 files in the diff are fixtures for tests that ensure we can read & render those files correctly.

right now we only care about encoding on input, all outputs are utf-8 per rust's defaults. those utf-16 files in the diff are fixtures for tests that ensure we can read & render those files correctly.

oh I misunderstood this PR, I guess this would've been a better comment to make in #178 🙃
seems fair to split it in two PRs then 👍

to be fair, i did imply on that issue that i could carry the encoding through to writing the file too. i much prefer your solution.


"Bad solution" error with acyclic property and self edge

I ran into the error message below. I minimized a reproducing test case by hand, and it seems to be related to the combination of an acyclic property being asserted, along with a self edge in the GNF. The error is sensitive to other changes as well, presumably because it winds up investigating a good solution first in those cases.
Error in solution of graph theory 0, in detector 0 (Cycle Detector)
Unexpected error:
BAD SOLUTION: failure in graph theory detector

p cnf 12 8
1 0
12 9 0
digraph 3 11 0
edge 0 2 2 9
edge 0 2 1 12
acyclic 0 1

Thank you for providing a minimized example! That is hugely helpful.
(As an aside - if this happens again, you can use a delta debugger, like this one, to minimize the error automatically).
Is it ok with you if I include this example with the monosat unit tests to catch this issue in the future?

I've reproduced this error with the provided test case

Currently, I believe this error applies to any graph with a self-loop edge (from a node to itself). If that turns out to be the case, the fix should be straightforward. Do you have any failing examples without self-loop edges?

I've pushed a provisional fix to testing branch https://github.com/sambayless/monosat/tree/issue-32
I haven't had enough time to properly verify this change yet or check that it doesn't lead to other errors.
If you have a chance to checkout that branch and test it on your example, that would be fantastic.

Thanks! I tried out the fix, and it solved the issue on the minimized test case, plus the file I started with before minimizing. Go ahead and include it in the test suite. I haven't run into any similar errors without self-loop edges.

I've updated unit tests (https://github.com/sambayless/monosat_tests) and merged this change to master. Closing this issue. Thanks again!


Features support

References
This PR connects to #664
Description
This PR adds the ability to check authorizations for features through REST calls.
It also adds an implementation using the loginOnBehalfOf and administratorOf feature for disabling the impersonate button and hiding / restricting access to admin pages respectively.
Instructions for Reviewers
Changes made:

Added models and services for Feature and Authorization
-- The AuthorizationDataService contains a method isAuthorized(), which returns an observable emitting true if the user is authorized for the provided feature and object, false if he/she isn't authorized. (A user is considered authorized if the list of authorizations returned by the REST API contains at least one Authorization)
-- To pass the ID of a feature to check authorization for, we're making use of the new enum FeatureID.
-- If no object is provided with isAuthorized(), it will use the repository's Site
-- If no user UUID is provided with isAuthorized(), it will use the currently authenticated EPerson (or undefined for anonymous)
Added implementation for canImpersonate$ on EPersonFormComponent. This will disable the impersonate button if the current user is not authorized to do so.
Added SiteAdministratorGuard extending from abstract FeatureAuthorizationGuard. The SiteAdministratorGuard is used to restrict access to certain modules for users that aren't Site administrators (configured this guard for route /admin)
-- These guards will redirect the user to a new UnauthorizedComponent. This is similar to the PageNotFoundComponent, but displays messages for unauthorized (401)
Modified AdminSidebarComponent to hide administrator routes from the sidebar, making use of the new authorization features.

How to test:

Login as a non-administrator and open the sidebar. All administrator links (e.g. metadata registry) should be hidden.
Login as administrator and open the sidebar. All sidebar options should be visible.
Login as administrator and visit /admin/access-control/epeople. Edit an EPerson. The impersonate button should be enabled/disabled depending on the administrator's loginOnBehalfOf rights.
Try to access an administrator feature (e.g.  /admin/access-control/epeople) as anonymous. You should be redirected to /unauthorized.
Try to access an administrator feature as a non-administrator. You should be redirected to /unauthorized. Warning: If this redirects you to the homepage instead, this is due to #711 .

Note: We've tried to maintain the original URLs the user is being redirected from for unauthorized pages, but Guards in angular don't allow this.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs for any bug fixes, improvements or new features. A few reminders about what constitutes good tests:

Include tests for different user types (if behavior differs), including: (1) Anonymous user, (2) Logged in user (non-admin), and (3) Administrator.
Include tests for error scenarios, e.g. when errors/warnings should appear (or buttons should be disabled).
For bug fixes, include a test that reproduces the bug and proves it is fixed. For clarity, it may be useful to provide the test in a separate commit from the bug fix.

[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

When testing this PR, keep in note that due to a backend bug (https://github.com/DSpace/DSpace/issues/2829), sometimes the wrong authorization is returned. You can verify that the correct call is made in the network tab of the dev tools in your browser


[1.12] Config for hoe cart

I would like to use custom tools for the hoe cart (in particular, Tinker Construct tools). It appears the feature is available for 1.14 (#30), is it possible to port it to 1.12?

Pardon my late reply, but no unfortunately 1.12 is past support.


xpoint mode

I can not understand. what type of file to use in xpoint mode
i have hex private key FF8B8141D7A67C073318BE7960981626FEE0809AF1CB4E97876DDACC6007D80A
I get from him
Uncompressed Address
Base58 encoding: 1M41L7pWnoEnsxkcVLiWs5PXpbqVHZJ3Ze
RIPEMD-160 hash: 00DBF409E8C8DC9AB5277C55F3CD10D9663211498D166A9155
Compressed Address
Base58 encoding: 1KNbaPVP9z2V5eGapVXSN54oNSWXECpTjx
RIPEMD-160 hash: 00C987DC922B8705D066E9EB63F4C1838D84F35357652A8C8B

when i use -m address and in the file addresses.txt i have Base58 encoding i get HIT!!
./keyhunt -r FF8B8141D7A67C073318BE7960981626FEE0809AF1CB4E97876DDACC6007D80A
[+] Setting search for btc adddress
[+] Allocating memory for 2 elements
[+] Initializing bloom filter for 2 elements.
[+] Loading data to the bloomfilter
[+] Bloomfilter completed
[+] Sorting data
[+] 2 values were loaded and sorted
Thread 0 : Setting up base key: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
HIT!! PrivKey: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
pubkey: 023b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89
address: 1KNbaPVP9z2V5eGapVXSN54oNSWXECpTjx
HIT!! PrivKey: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
pubkey: 043b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89836555c0f7e298862bbb25dc49f54292e315b0b27da47ab19c7f9bf0dae66500
address: 1M41L7pWnoEnsxkcVLiWs5PXpbqVHZJ3Ze

but when i use -m xpoint and in file addresses.txt i have RIPEMD-160 hash i get this:
./keyhunt -r FF8B8141D7A67C073318BE7960981626FEE0809AF1CB4E97876DDACC6007D80A -m xpoint
[+] Setting mode xpoint
[+] Allocating memory for 2 elements
[+] Initializing bloom filter for 2 elements.
[+] Loading data to the bloomfilter
[+] Bloomfilter completed
[+] Sorting data
[+] 2 values were loaded and sorted
Thread 0 : Setting up base key: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
Total 5242880 keys in 30 secods: 174762 keys/s

i don't get matches, what i am doing wrong

Hi, after all thanks to use and test my tool.
I will update the readme file ASAP and i will notify you, when i write xpoint i really want to say x value:
For you privakey
public_key_compressed: 023b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89
public_key_uncompressed: 043b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89836555c0f7e298862bbb25dc49f54292e315b0b27da47ab19c7f9bf0dae66500
public_address: compressed 1KNbaPVP9z2V5eGapVXSN54oNSWXECpTjx
public_address: uncompressed: 1M41L7pWnoEnsxkcVLiWs5PXpbqVHZJ3Ze
The X value is
3b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89

So with that line in the file we can hit the key without performan  any sha256 or rmd160 operation this is a little more faster than address mode.
albertobsd $ ./keyhunt -m xpoint -f test.txt -r FF8B8141D7A67C073318BE7960981626FEE0809AF1CB4E97876DDACC60000000
[+] Setting mode xpoint
[+] Opening file test.txt
[+] Allocating memory for 1 elements
[+] Initializing bloom filter for 1 elements.
[+] Loading data to the bloomfilter
[+] Bloomfilter completed
[+] Sorting data
[+] 1 values were loaded and sorted
Thread 0 : Setting up base key: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc60000000
HIT!! PrivKey: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
pubkey: 023b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89

I need to modify my code to accept x value and publickey compressed or uncompressed.
stay aware, i will release a new mode more faster
Kind regards

Hi, after all thanks to use and test my tool.
I will update the readme file ASAP and i will notify you, when i write xpoint i really want to say x value:
For you privakey
public_key_compressed: 023b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89
public_key_uncompressed: 043b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89836555c0f7e298862bbb25dc49f54292e315b0b27da47ab19c7f9bf0dae66500
public_address: compressed 1KNbaPVP9z2V5eGapVXSN54oNSWXECpTjx
public_address: uncompressed: 1M41L7pWnoEnsxkcVLiWs5PXpbqVHZJ3Ze
The X value is
3b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89

So with that line in the file we can hit the key without performan  any sha256 or rmd160 operation this is a little more faster than address mode.
albertobsd $ ./keyhunt -m xpoint -f test.txt -r FF8B8141D7A67C073318BE7960981626FEE0809AF1CB4E97876DDACC60000000
[+] Setting mode xpoint
[+] Opening file test.txt
[+] Allocating memory for 1 elements
[+] Initializing bloom filter for 1 elements.
[+] Loading data to the bloomfilter
[+] Bloomfilter completed
[+] Sorting data
[+] 1 values were loaded and sorted
Thread 0 : Setting up base key: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc60000000
HIT!! PrivKey: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
pubkey: 023b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89

I need to modify my code to accept x value and publickey compressed or uncompressed.
stay aware, i will release a new mode more faster
Kind regards

OK thanks.
Can you tell me where I can find out how to calculate X value?

OK thanks.
Can you tell me where I can find out how to calculate X value?

Well is possible know the public key in the next conditions:

The address has mined bitcoin
The address already made some spends
The address is in some leaked wallet

Maybe other but i don't know, you need more research about it

Well is possible know the public key in the next conditions:

The address has mined bitcoin
The address already made some spends
The address is in some leaked wallet

Maybe other but i don't know, you need more research about it

Thank you so much

Thank you so much

By the way I just update the repository, this update implement the mode -m rmd160 to search for a hash rmd160 instead of an address.
File Example:
DBF409E8C8DC9AB5277C55F3CD10D9663211498D
C987DC922B8705D066E9EB63F4C1838D84F35357

Example execution and output:
albertobsd $ ./keyhunt -r FF8B8141D7A67C073318BE7960981626FEE0809AF1CB4E97876DDACC60070000 -f test.txt -m rmd160
[+] Version 0.1.20210318 K*BSGS
[+] Setting mode rmd160
[+] Opening file test.txt
[+] Allocating memory for 2 elements: 0.00 MB
[+] Initializing bloom filter for 2 elements.
[+] Loading data to the bloomfilter
[+] Bloomfilter completed
[+] Sorting data
[+] 2 values were loaded and sorted
Thread 0 : Setting up base key: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc60070000
HIT!! PrivKey: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
pubkey: 023b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89
HIT!! PrivKey: ff8b8141d7a67c073318be7960981626fee0809af1cb4e97876ddacc6007d80a
pubkey: 043b903e6ca8accbb693243b5caf83be5cb0a484919a12cdf403b526fc7c9eba89836555c0f7e298862bbb25dc49f54292e315b0b27da47ab19c7f9bf0dae66500
Total 5242880 keys in 30 seconds: 174762 keys/s
^C


Layout of Company page is unbalanced

Here's what ours looks like now there are 4 apps associated with the company:

Maybe reduce the width of the top block, or centre the area where sets of 3 apps appear, or add spacing between them.
I don't mind the last row being left-justified and incomplete when the number of apps isn't an exact multiple of 3.

@gjsjohnmurray this is a bug, thanks!

Yes, this is a bug, because four apps should always fit to company block

done

Nice! Thanks. Closing.


Chrome doesn't load the labelling workspace in v2.4.8

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Steps to Reproduce (for bugs)

Deploy v2.4.8 with helm chart version 0.7.3
Navigate to a labelling job
Attempt to launch the job

Expected Behaviour
That the workspace launches correctly and allows the user to label the images
Current Behaviour
When launching the job the canvas just spins as if it's constantly loading the data. Looking at the console logs there is actually a cors header issue. This does not happen when using FireFox (version 114.0.5735.133)
Specify a Cross-Origin Embedder Policy to prevent this frame from being blocked
Because your site has the Cross-Origin Embedder Policy (COEP) enabled, each embedded iframe must also specify this policy. This behavior protects private data from being exposed to untrusted third party sites.
To solve this, add one of following to the embedded frame’s HTML response header:
Cross-Origin-Embedder-Policy: require-corp
Cross-Origin-Embedder-Policy: credentialless (Chrome > 96)

Possible Solution
I'm not too familiar with these headers but I believe it might be this configuration here https://github.com/opencv/cvat/blob/v2.4.8/cvat-ui/react_nginx.conf#L28. For things under /assets it's being set to require-corp but doesn't have the Cross-Origin-Resource-Policy: cross-origin header documented here.
Context
We upgraded our on-prem environment from 2.4.3 to 2.4.8 and got reports of data not loading which we also reproduced. Within these minor releases is also when the code I linked above was released. It does seem like we can direct users to use Firefox but many developers here prefer Chrome as their browser.
 Kubernetes
Operating System and version (e.g. Linux, Windows, MacOS): MacOS Ventura
Chrome 114.0.5735.133

Hi @tvanderwal-lmco

Clear the browser cache to get relevant results from the server (not cached ones)
Or click "Disable cache" at the top of chrome dev tools and update the page once

Oof I'm embarrassed I didn't think of that first! Thanks for the help @bsekachev :)


kdf objects missing a return if malloc fails.

I have searched through all references of ERR_R_MALLOC_FAILURE for any
other instances..
Noticed during random code inspection of coverage results

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This pull request is ready to merge

Merged to master and cherry-picked to 3.0. Thank you.


Sweeps double-log the command-line arguments as command_line

Sweeps logs all arguments again, using underscore. So if I have a command line argument batch-size sweep will log both batch-size and batch_size (underscore).

To reproduce
If I have a script, that uses command line args as follows:
import wandb
import argparse

parser = argparse.ArgumentParser()
parser.add_argument('-b', '--batch-size', type=int, default=8, metavar='N',
                     help='input batch size for training (default: 8)')
args = parser.parse_args()

with wandb.init(config={"lr": 0.1}) as run:
    wandb.config.epochs = 4

    wandb.config.update(args) # adds all of the arguments as config variables

Here is my sweep config:
project: TEST
program: test.py
method: grid
parameters:
  batch-size:
    values: [24, 45]

command:
  - ${env}
  - python
  - ${program}
  - ${args}

Then initiate a sweep as follows:
wandb sweep test.yaml

Hey Andriy, thanks for reporting this. The team is looking into this.

Hi @drozzy,
This is happening because of how you have your argument parser set up in your example. The arg parser stores
parser.add_argument('-b', '--batch-size', type=int, default=8, metavar='N',
                     help='input batch size for training (default: 8)')

as
args.batch_size

and when you do
wandb.config.update(args) # adds all of the arguments as config variables

wandb will see that your config has a new variable called batch_size.
You actually dont need to manually include the argparse lines above, the sweep already passes the parameters to wandb.config and they are all accessible in wandb.config after you call init.
So you could rewrite what you have above as:
import wandb

with wandb.init(config={"lr": 0.1}) as run:
    wandb.config.epochs = 4

and it will work as you expect

Ok that's great to know.
You may want to update your docs then - because I took my example from there pretty much:
https://gitbook-docs.wandb.ai/guides/track/config#argparse-namespace


Submit without fname

Codecov Report

Merging #633 (c8b2af1) into master (01f245b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   44.19%   44.18%   -0.01%
==========================================
  Files          45       45
  Lines        6881     6884       +3
==========================================
+ Hits         3041     3042       +1
- Misses       3840     3842       +2

Impacted Files
Coverage Δ

assemblyline_core/submission_client.py
47.86% <0.00%> (-1.26%)
:arrow_down:

assemblyline_core/dispatching/dispatcher.py
75.27% <0.00%> (+0.10%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Remove extra allocations in PSMemberInfoInternalCollection

PR Summary
Related #7112.
PSMemberInfoInternalCollection uses internally OrderedDictionary class.
The OrderedDictionary class in .Net Core 2.1 allocates internally ArrayList  and Hashtable  after any first using any property. Even if we check that OrderedDictionary is empty (Count==0) or use indexer it causes allocations.
The commit postpones the internall allocations until this is really necessary.
Taking into account that PSMemberInfoInternalCollection is used in each PSObject and is often empty, this change dramatically reduces memory allocations.
PerfView results

Startup test

before - GC Stats Total Allocs : 13.274 MB
after  - GC Stats Total Allocs : 10.082 MB

Script test (Import-Csv)
Before fix:

GC Stats Total Allocs : 4,073.747 MB

After the fix:

GC Stats Total Allocs : 1,186.017 MB

Test script:
cd c:\tmp\
function perf_test($source, $result) {
    Write-Host "Measuring Import-Csv performance over time..."

    "index,duration_ms,bytes_consumed" | Out-File $result
    for ($i=0; $i -le 400; $i++) {

            $millis = (Measure-Command { Import-Csv $source }).TotalMilliseconds
            # Uncomment this if you want analize results in Excel
            $memory = [System.GC]::GetTotalMemory($false)
	    $i.ToString() + "," + $millis.ToString() + "," + $memory | Out-File $result -Append
    }
    Write-Host "Done"
}

$fields = 0..19 | ForEach-Object { "random_numbers$_" }
($fields -join ",") | Out-File .\source2.csv
Get-Random -SetSeed 1 | Out-Null
for ($i=0; $i -le 500; $i++) {
    $values = 0..19 | ForEach-Object { (Get-Random).ToString() }
    ($values -join ",") | Out-File .\source2.csv -Append
}

perf_test .\source2.csv .\results.csv

PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Change is not breaking
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

@SteveL-MSFT If the PR is ok you could consider it for Windows PowerShell 5.1 too.
@daxian-dbw Sorry for ping - the PR can be important.
@markekraus Could you please check json cmdlets with the change if you have a time. I hope we get a win there too.
@vancem Thanks for your great analysis - it helped a lot!

@daxian-dbw I reverted lock (_members) to lock (Members) because the lock failed on null in Add() and Remove(). I believe that it makes no sense to add the null check in the methods so using lock (Members) everywhere looks good..

I measure pwsh.exe startup and update PR description:

Startup test

before - GC Stats Total Allocs : 13.274 MB
after  - GC Stats Total Allocs : 10.082 MB

@iSazonov The issue with JSON is one of speed more than memory allocation. I don't have he tooling to test the memory performance. but the code I use to test the JSON performance is this:
$json = @'
{
    "id": "string",
    "data": [
        {
        "accountId": 0,
        "productId": 0,
        "resourceLocationId": 0,
        "consumedServiceId": 0,
        "departmentId": 0,
        "accountOwnerEmail": "string",
        "accountName": "string",
        "serviceAdministratorId": "string",
        "subscriptionId": 0,
        "subscriptionGuid": "string",
        "subscriptionName": "string",
        "date": "2017-04-27T23:01:43.799Z",
        "product": "string",
        "meterId": "string",
        "meterCategory": "string",
        "meterSubCategory": "string",
        "meterRegion": "string",
        "meterName": "string",
        "consumedQuantity": 0,
        "resourceRate": 0,
        "Cost": 0,
        "resourceLocation": "string",
        "consumedService": "string",
        "instanceId": "string",
        "serviceInfo1": "string",
        "serviceInfo2": "string",
        "additionalInfo": "string",
        "tags": "string",
        "storeServiceIdentifier": "string",
        "departmentName": "string",
        "costCenter": "string",
        "unitOfMeasure": "string",
        "resourceGroup": "string"
        }
    ],
    "nextLink": "string"
}
'@
$json = 1..1000 | % { $json }
$json = '[' + ($json -join ',') + ']'
Measure-Command {$Json | ConvertFrom-Json } | % TotalMilliseconds

5.1: 375.3416ms
6.0.2: 2055.1092ms
6.1.0-preview.4: 1252.1725ms
6.1.0-preview.10466: 1130.4745ms (your most recent passing build for this PR)
so it is marginally better than 6.1.0-preview.4, better than 6.0.2, but still nowhere near the performance of 5.1. ☹

@markekraus Many thanks for your repo script! I'll try to look it deeper next week.

@iSazonov You cannot change all lock(Members) to lock(_members). You can change those that _members == null has already been checked. For Add, there is no check for _members != null, so changing to lock (_members) would fail for sure.

There is a very expensive check for duplicate members.
By replacing that check, and by keeping a hashset of preValidated member, I can speed it up by a factor of 3 or so.

@powercode Using preValidated looks as internal only hack. It will be nice to find more generic solution that we can expose to public.

@iSazonov I agree about preValidated.

One test failed in AppVeyor, but works fine on my dev box. Will address @powercode's comment and trigger the CIs again.
[00:15:18]     [-] -WindowStyle Maximized should work on Windows
[00:15:18]       Expected exactly {Maximized}, but got {Hidden}.
[00:15:18]       636:         $showCmd | Should -BeExactly $WindowStyle
[00:15:18]       at Invoke-Assertion, C:\projects\powershell\src\powershell-win-core\bin\Release\netcoreapp2.1\win7-x64\publish\Modules\Pester\4.2.0\Functions\Assertions\Should.ps1: line 206
[00:15:18]       at <ScriptBlock>, C:\projects\powershell\test\powershell\Host\ConsoleHost.Tests.ps1: line 636
[00:15:18] Processing -WindowStyle 'invalid' failed: Cannot convert value "invalid" to type "System.Diagnostics.ProcessWindowStyle". Error: "Unable to match the identifier name invalid to a valid enumerator name. Specify one of the following enumerator names and try again:
[00:15:18] Normal, Hidden, Minimized, Maximized".

Thanks all for help and useful comments!

OrderedDictionary was fixed in https://github.com/dotnet/corefx/pull/32001 - some properies now don't allocate if no need.


yt-dlp_min.exe v2022.04.08: FileNotFoundError: [Errno 2] No such file or directory

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.04.08 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
D:>yt-dlp_min.exe
Traceback (most recent call last):
File "main.py", line 19, in
File "yt_dlp_init_.pyc", line 869, in main
File "yt_dlp_init_.pyc", line 830, in _real_main
File "yt_dlp\YoutubeDL.pyc", line 667, in init
File "yt_dlp\YoutubeDL.pyc", line 3743, in _setup_opener
File "yt_dlp\utils.pyc", line 1027, in make_HTTPS_handler
FileNotFoundError: [Errno 2] No such file or directory
This problem does not appear in yt-dlp.
Verbose log
FileNotFoundError: [Errno 2] No such file or directory.

Use --compat-options no-certifi as a workaround

Another workaround is to download https://raw.githubusercontent.com/certifi/python-certifi/master/certifi/cacert.pem as cacert.pem to the same folder as yt-dlp

see, thanks!


Some way to show changes across multiple commits

Testing #217398

It'd be cool if I could get a multi-file editor that contains the changes for like multiple selected commits.

Added support multi-select, right click and choose "View Commit".