[WIP] Fixes #7078: Change prefix of MemorySlot channel in Qasm Instructions

Summary
Fixes #7078.

In qiskit/pulse/channels.py, changes prefix of MemorySlot from "m" to "s" to distinguish from the prefix for MeasureChannel.
In qiskit/qobj/converters/pulse_instruction.py, uses the new prefix to create a MemorySlot.
Adds new test in test/python/qobj/test_pulse_converter.py to test the conversion to MemorySlot from PulseQobjInstruction, using a Delay, as that was the example in the issue.

Details and comments
This fixes a bug whereby MeasureSlots and MemorySlots are indistinguishable after being serialized into Qobj instructions because they both use the same prefix. No documentation changes are needed because this is a bug, and the various supported channels are not listed explicitly, so it's not necessary to add MemorySlots to them.
I did not add a unit test directly for get_channel, but instead added the unit test in the place where it seemed there were tests which were most closely analogous.
Comment: Regarding the discussion of the alternative way of fixing this issue I did not ignore the Delay on a MemorySlot channel, as retaining it seemed most conservative. It does seem to me that it may not make sense to have a Delay when emulating the classical part of a noisy system, as the classical part may perhaps be regarded as relatively perfect and instantaneous. I would be interested in reading about the pros and cons mentioned if there's an existing discussion on it saved somewhere.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I can look into the backend implementation to see if there is a problem, but @taalexander might know how to do that more quickly. Has this change been tested on an IBM backend to see if anything breaks?

@wshanks No, I haven't run it on an IBM backend - I'm not set up with it. The only tests I've run are:

the tests run in make
the tests that happen in CI (possibly not a wider set than make)
a casual running of the script quoted in the issue, to make sure that the output changed to what was expected.

@nkanazawa1989 Maybe we can lean on the fact that the prefix of MemorySlot clashes with MeasureChannel to conclude that it isn't in widespread usage after serialisation with Qobj? It's not impossible that it would be, though: if a client never used MeasureChannels and used something other than pulse_instruction.get_channel() to deserialize then they could be using the serialization of MemorySlot as it is. As a newcomer I don't know how likely it is that a client would use this library in this way.
If we do have to be very cautious then I would be happy to implement the new class for MemorySlot - should it be called MemorySlot2 for example?

I'm not familiar with how backend compiler works, but I guess they (at least IBM one) don't use qiskit qobj disassembler. I think they can distinguish memory slots from measure channels because memory slots only appear in the operands of acquire instruction, i.e. there is no instruction directly taking memory slots. So I think the prefix of memory slots is less important (but maybe the backend parser does text based matching including the prefix). I agree it would be great if we can give different prefix to the memory slots.

@pollyshaw Thanks for the contribution. Can you please add "fixes #7078" in the description / body of the PR instead of the title so that the issue can be linked with the PR? Thank you.

Thanks @taalexander for confirmation. Then this PR should be good to go with some cleanup.

Thanks for your feedback @nkanazawa1989! I will try implementing the ClassicalIOChannel which I agree is better than bolting on another property, especially as is_schedulable is used elsewhere in the library to mean something different, and also may be misnamed.

@nkanazawa1989

* Can you add the same channel type check to other instructions too? Specifically, `Play`, `SetFrequency`, `ShiftFrequency`, `SetPhase` and `ShiftPhase`.

Play already throws an exception if the type is not PulseChannel - so I think this is covered
SetFrequency, SetPhase and `ShiftPhase specify PulseChannel as a type for the channel constructor parameter, but don't check the type. Should I add a check but check that it's PulseChannel, rather than specifically checking that it's not ClassicalIOChannel?

Thanks. This looks good to me now. Could you please fix linter error so that I can approve?

@nkanazawa1989 Have done - hope I get a green build this time.
Just to make sure, I ran the test that was in the issue again to see if sched2 and sched were the same in the following:
from qiskit.pulse import Schedule, Play, Acquire, MemorySlot, AcquireChannel, DriveChannel
from qiskit.pulse.library.parametric_pulses import Constant
from qiskit.pulse.transforms import pad
from qiskit.qobj.converters.pulse_instruction import QobjToInstructionConverter
from qiskit import assemble

sched=Schedule()
sched+=Play(Constant(4, 0.1), DriveChannel(0))
sched+=Acquire(3, AcquireChannel(0), MemorySlot(0))
sched=pad(sched, inplace=False)

qobj=assemble(sched, qubit_lo_freq=[4.5e9], meas_lo_freq=[5e9], parametric_pulses=['constant'])

converter = QobjToInstructionConverter([])
sched2=Schedule(*[converter(inst) for inst in qobj.experiments[0].instructions])

However, I now get an error on the last line:
Traceback (most recent call last):
  File "/*****/qiskit-terra/qiskit/qobj/converters/pulse_instruction.py", line 78, in get_bound_method
    return self._bound_instructions[bound]
KeyError: '1192ae7dadef42e8e4ff9b67ccad8016bec78136bb36dcda2b2d5d9835435108'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/*****/qiskit-terra/venv/lib/python3.9/site-packages/IPython/core/interactiveshell.py", line 3437, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-12-56b1883ee859>", line 1, in <module>
    sched2=Schedule(*[converter(inst) for inst in qobj.experiments[0].instructions])
  File "<ipython-input-12-56b1883ee859>", line 1, in <listcomp>
    sched2=Schedule(*[converter(inst) for inst in qobj.experiments[0].instructions])
  File "/*****/qiskit-terra/qiskit/qobj/converters/pulse_instruction.py", line 442, in __call__
    method = self.bind_name.get_bound_method(instruction.name)
  File "/*****qiskit-terra/qiskit/qobj/converters/pulse_instruction.py", line 80, in get_bound_method
    raise QiskitError(f"Bound method for {bound} is not found.") from ex
qiskit.exceptions.QiskitError: 'Bound method for 1192ae7dadef42e8e4ff9b67ccad8016bec78136bb36dcda2b2d5d9835435108 is not found.'

I got this on main as well as far as I can tell. Not to worry if the change is still good, but I can't tell 100% if it would have fixed the issue, and anyway we are slightly reinterpreting the issue as I'm not sure whether we really would be expecting sched2 to equal sched.

Thanks for reporting. This is kind of a bug which is caused by the recent upgrade for pulse library #7821 . This replaces ParametricPulse with SymbolicPulse (and thus we implicitly assume user doesn't intentionally use old ParametricPulse), but current qobj converter is only aware of SymbolicPulse.
https://github.com/Qiskit/qiskit-terra/blob/f2c2fe263eedc0dd4cc2f954921bc57e2e89d076/qiskit/qobj/converters/pulse_instruction.py#L36-L46
So if you intentionally use old class with full import path from qiskit.pulse.library.parametric_pulses import *, the converter converts the parametric pulse instance into waveform samples by calling the get_waveform and create a pulse library dictionary in qobj, and thus you cannot disassemble instructions without the pulse library.
I think this will be fixed with https://github.com/Qiskit/qiskit-terra/pull/8278 because new logic can handle both ParametricPulse and SymbolicPulse. Meanwhile you can update the import path in your code, i.e. from qiskit.pulse.library import Constant.

from qiskit.pulse.library import Constant

Thanks @nkanazawa1989: this did fix the error. Comparing sched and sched2 I now get
Schedule((0, Acquire(3, AcquireChannel(0), MemorySlot(0))), (0, Play(Constant(duration=4, amp=(0.1+0j)), DriveChannel(0))), (3, Delay(1, AcquireChannel(0))), name="sched0")
Schedule((0, Acquire(3, AcquireChannel(0), MemorySlot(0))), (0, Play(Constant(duration=4, amp=(0.1+0j), name='constant_e3a2'), DriveChannel(0), name='constant_e3a2')), name="sched3")

so the delay has been lost. Is this as expected?

fyi
https://github.com/Qiskit/qiskit-terra/blob/f2c2fe263eedc0dd4cc2f954921bc57e2e89d076/qiskit/pulse/transforms/canonicalization.py#L214-L223
This transform can be disabled by calling this function with remove_directives=False.
https://github.com/Qiskit/qiskit-terra/blob/f2c2fe263eedc0dd4cc2f954921bc57e2e89d076/qiskit/assembler/assemble_schedules.py#L182

Thanks @wshanks ! New design is based on this comment from Thomas.

A delay on a memory slot is semantically not supported and is an abuse of the pulse object model as far as I can tell as described in https://github.com/Qiskit/qiskit-terra/issues/7078.

Actually there is no reason to call the pad function with Schedule. This was a main UX of pulse programming before the builder syntax/ScheduleBlock. When we coded with its syntactic sugar, sometime padding was useful to prevent injection of instructions with .append (i.e. implicit asap). However, I think we are no longer using this programming model. The problem is we are still calling the pad function when the assembler dumps a pulse qobj. This is due to convention, but we can cleanup these transforms when we have a chance of refactoring. In principle, padding is not needed as long as we code with the builder syntax, because the Schedule is absolute time model and appending ScheduleBlock to another block doesn't schedule instructions across blocks.
This prevents the "m" channel prefix from confusing a qobj to disassemble, since no memory slots will appear because of the padding.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 18 (100.0%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.0001%) to 83.991%

Files with Coverage Reduction
New Missed Lines
%

qiskit/extensions/quantum_initializer/squ.py
2
80.9%

Totals

Change from base Build<PHONE_NUMBER>:
0.0001%

Covered Lines:
55896

Relevant Lines:
66550

💛  - Coveralls


Amend query parser "null handling" to also catch NaN

Presently, NaN query values are slipping through the cracks of the parser. This commit amends the null handle expression to also catch NaN values

@rodneyrehm Is anything else needed for this?

Project is abandoned


24.5.0 release

Released on pypi and doc updated. Waiting on conda-forge merge...

Merged conda-forge release


Allow to colorize links

Ref: https://github.com/buildkite/terminal/issues/29
So I tried to use the new links, but unfortunately my plan was to use it to improve our test failure backtraces with links to GitHub. Ultimately it would work, but I'm not willing to lose the backtrace colorization I put in place:

Not sure what the best syntax would be to chose the link color. Ideally I could use regular ANSI color code in it:
echo -e '\033]1339;url=https://google.com/;content=\033[33mHello World\033[0m\a'

But here's what it gives me right now

@keithpitt @toolmantim @mipearson do you guys think it makes sense or am I pushing it?

I reckon we could make this happen! I think if we tweaked the URL colour to use: color: currentColor instead of a new URL colour, then I think it would work?

hmmm. This feels more like a stylesheet change outside of terminal - remove the colour override on links within the rendered terminal section.

@byroot could you DM me a link to a build with a link in it so I can tweak da css?

Indeed. I just tested and all it needs is color: inherit; on these links.


chore(package.json): update elysia to 0.6.10 (fixes #4)

This fixes https://github.com/elysiajs/elysia-html/issues/4
While on it I also update the dev dependencies

Update elysia version in peerDependencies to 0.6.10 for better compatibility
Update versions of @types/node, bun-types, elysia, eslint, rimraf, typescript in devDependencies for bug fixes and new features

no buddy. i tried updating Elysia to 0.6.10 it doesn't help

@t0mri sorry, there might be a misunderstanding of how to get this issue fixed. Just in case, let me please rephrase: the fix is not about updating the elysia dependency of your application, but to use a version of elysia-html which is itself depending on an updated version. My proposal is to use lokal linking in order to check this fix:

clone my repo, and checkout this branch which includes the fix
bun build
bun link
change over to you app, and instead of using an upstream release of elysia-html use the local version you just build: bun link @elysiajs/html

See https://bun.sh/docs/cli/install#local-packages-bun-link for more information
hope this helps

fyi, this currently prevents using elysia 0.6.11 since the resolved elysia types conflict

thats fixed with most recent changes to elysia and elysia-html, kust make sure to use
import { Elysia } from 'elysia'
import { html } from '@elysiajs/html'
(instead of the previously documented import Elysia from 'elysia' ...
closing the PR


Installation issue

Hello ESM team:
I am trying setup ESM on our HPC cluster, OS RHEL7.9. I tied the following:
1)create a conda environment esm2-1.0.3
conda create -n esm2-1.0.3 python=3.7.3
2)conda activate esm2-1.0.3
3)(esm2-1.0.3) [ryao@tdragon4 esm]$ pip install fair-esm
4)(esm2-1.0.3) [ryao@tdragon4 esm]$ pip install torch
Installing collected packages: typing-extensions, nvidia-cuda-runtime-cu11, nvidia-cuda-nvrtc-cu11, nvidia-cublas-cu11, nvidia-cudnn-cu11, torch
Successfully installed nvidia-cublas-cu11-<IP_ADDRESS> nvidia-cuda-nvrtc-cu11-11.7.99 nvidia-cuda-runtime-cu11-11.7.99 nvidia-cudnn-cu11-<IP_ADDRESS> torch-1.13.0 typing-extensions-4.4.0
5)(esm2-1.0.3) [ryao@tdragon4 esm]$ module load cuda11.2/toolkit/11.2.0
(esm2-1.0.3) [ryao@tdragon4 esm]$ which nvcc
/cm/shared/apps/cuda11.2/toolkit/11.2.0/bin/nvcc
(esm2-1.0.3) [ryao@tdragon4 esm]$ pip install fair-esm[esmfold]
......
Collecting deepspeed==0.5.9
Downloading deepspeed-0.5.9.tar.gz (510 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 510.3/510.3 kB 3.6 MB/s eta 0:00:00
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
......
OSError: /rsrch3/home/itops/ryao/.conda/envs/esm2-1.0.3/lib/python3.7/site-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.11: symbol cublasLtGetStatusString, version libcublasLt.so.11 not defined in file libcublasLt.so.11 with link time reference
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
May you please advise, what could be the problem? Please let me know if you need more information.
Thank you,
Rong Yao

Hmm this looks like a version mismatch between cuda and cublas? Maybe cublas is not installed properly.. could be via cuda-toolkit. Is this all loaded via module load?
As an alternative, would huggingface transformers be an option? This simplified the difficult dependencies.

@tomsercu :  Thank you for your reply.
I follow the instruction to create a conda environment by:
conda env create -f environment.yml
seems to work.
I believe the previous error was from package version mismatch, as you suggested.
Thank you again! I am closing this report.


wrong paypal address shows connected in the host dashboard

Describe the bug
the open source collective dashboard shows the foundation's paypal connected.
I refreshed the connection to ensure we connected the c6 but the c3 is still showing.
Also dates is wrong

Fixed in the production database.
That was because we linked the wrong paypal account in the past and when we fetch the list of payment methods we were ordering them by the oldest first.
I just removed it from the db for now which fixes it. PR coming for long term solution.


any use of beforeModel on route with ApplicationRouteMixin breaks auth?

Full disclosure: I'm new to Ember and trying to get a simple app setup with Auth0 as my authentication and a Rails backend that will serialize up a User record... so maybe this is just my learning curve biting me...
I've gotten Auth0 logins to work, for the most part, but when trying to follow the ESA 'managing current user' guide, it seems that their suggested beforeModel messes everything up and the authenticated session won't stick. Removing the suggested beforeModel makes authentication work, but now my currentUser is undefined.
With this addon, how should I load the current user in a beforeModel properly without breaking the addon functionality? What am I missing?

@mepatterson This is probably because of a lack of using super() in your beforeModel method.
If you could post a little code, it would be helpful!

yeah. i dug deeply into this and it got real weird.
THIS DOES NOT WORK
  beforeModel() {
    this._super;
    return this._loadCurrentUser();
  }

DOING IT LIKE THIS WORKS:
  beforeModel() {
    this._setupFutureEvents();
    const _super = this._super;
    let promise = RSVP.resolve(_super.call(this, ...arguments));

    promise = promise
      .then(this._getUrlHashData.bind(this))
      .then(this._authenticateWithUrlHash.bind(this))
      .then(this._loadCurrentUser.bind(this));

    return promise;
  }

This seems to work ok.
currentUser: service(),

async sessionAuthenticated() {
    await this._loadCurrentUser();
},

beforeModel() {
    this._super(...arguments);
    return this._loadCurrentUser();
},

async _loadCurrentUser() {
    try {
      await this.currentUser.load();
    }
    catch {
      await this.session.invalidate();
    }
}


Font Atlas Not Built! - Assertion Failed in ImGui::ErrorCheckNewFrameSanityChecks

Describe the bug
I faced an assertion failure in ImGui::ErrorCheckNewFrameSanityChecks while incorporating imgui-rs to my current project. The full error message is as follows:
test: ./third-party/imgui-master/imgui/imgui.cpp:8882: void ImGui::ErrorCheckNewFrameSanityChecks(): Assertion `g.IO.Fonts->IsBuilt() && "Font Atlas not built! Make sure you called ImGui_ImplXXXX_NewFrame() function for renderer backend, which should call io.Fonts->GetTexDataAsRGBA32() / GetTexDataAsAlpha8()"' failed.

FontAtlas seems to be not building, which causes the failure when the .frame() method is called. imgui.fonts()is_built() also returns false, and the bool doesn't change throughout the app lifecycle. I also tried to build the textures manually by calling the build_alpha8_texture() and build_rgba32_texture() methods, but it was no help.
To Reproduce
This should explain it well:

let mut imgui = imgui::Context::create();
let mut platform = imgui_winit_support::WinitPlatform::init(&mut imgui);

if let Some(event_loop) = self.event_loop.take() {
    let _ = event_loop.run(move |event, event_loop| {
        if let Some(ref surface_state) = self.surface_state {
            platform.attach_window(
                imgui.io_mut(),
                &surface_state.window,
                imgui_winit_support::HiDpiMode::Default,
            );

            // .....

            match event {
                Event::WindowEvent { event, .. } => match event {
                    WindowEvent::RedrawRequested => {
                        let ui = imgui.frame();

                        ui.window("Hello world")
                            .size([300.0, 100.0], imgui::Condition::FirstUseEver)
                            .build(|| {
                                ui.text("Hello world!");
                                ui.text("こんにちは世界！");
                                ui.text("This...is...imgui-rs!");
                                ui.separator();
                                let mouse_pos = ui.io().mouse_pos;
                                ui.text(format!(
                                    "Mouse Position: ({:.1},{:.1})",
                                    mouse_pos[0], mouse_pos[1]
                                ));
                            });

                        imgui.render();

                        // etc..

Expected behavior
The font atlas should be properly built, and no assertion errors should occur.
Screenshots
None, since my program crashes.
Please describe your environment

imgui-rs version: 0.12
Operating system: Arch Linux, Kernel 6.10.3-zen1-2-zen
imgui-winit-support version: Using a custom fork => https://github.com/julcst/imgui-winit-support

Other information
Is there maybe a way to initialize and build the atlas font, just like how it is done for imgui in C++? I couldn't find any information about that in the docs. This thread might be useful: https://github.com/ocornut/imgui/issues/3630

Have you tried something like:
let font_atlas = imgui.fonts();

font_atlas.add_font(&[
    imgui::FontSource::DefaultFontData {
        config: Some(imgui::FontConfig::default()),
    },
]);

let _ = font_atlas.build_rgba32_texture();

?

Yeah, as @mororo18 states, you need to build the font that gets rendered. That tends to happen in one of the support crates, such as imgui-glow-renderer, but also is trivial to implement yourself.


Add Wiki for internal documentation

It would be great to utilize the Wiki functionality in GitHub repo or do it elsewhere (look for alternatives). It can be informal (to store links and information related before they are forgotten) and can have a defined structure (a styleguide how wiki entries should look like).

As discussed, we should do this only for concepts instead of code parts. We can use the project wiki for it. :) we could think of it as architecture documentation. We could use something like arc42 as format


fix selectStatement contained tableReferences for other db

ref #4885 .
Changes proposed in this pull request:

fix selectStatement contained tableReferences for other db

Test of binder module use tables of selectStatement, cannot remove  tables.  @tristaZero

@jingshanglu You means tables will be removed in the future, not now?

@jingshanglu You mean tables will be removed in the future, not now?

The premise is that the binder module needs to be modified. @tristaZero

Codecov Report

Merging #4961 into master will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d53d22...a437951. Read the comment docs.

Pull Request Test Coverage Report for Build 10639

0 of 192 (0.0%)  changed or added relevant lines in 4 files are covered.
109 unchanged lines in 11 files lost coverage.
Overall coverage decreased (-0.1%) to 57.714%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/impl/SQL92DMLVisitor.java
0
45
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/impl/OracleDMLVisitor.java
0
49
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java
0
49
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDMLVisitor.java
0
49
0.0%

Files with Coverage Reduction
New Missed Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/impl/SQL92DMLVisitor.java
2
0%

shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/database/type/DatabaseTypes.java
2
83.33%

sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java
3
91.67%

sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java
3
76.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/impl/OracleDMLVisitor.java
3
0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java
3
0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDMLVisitor.java
3
0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java
4
70.16%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java
6
79.61%

shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/SQLRewriteEntry.java
12
0%

Totals

Change from base Build 1177:
-0.1%

Covered Lines:
11866

Relevant Lines:
20560

💛  - Coveralls

Modify the binder module test in the next subtask, how do you think? @tristaZero

Good job, and it is time to review the SQL cases below whether it could cover all the databases except for MySQL(They are updated  in your last PR).

select_inner_join_related_with_name

select_sharding_route_with_broadcast_table


TST: remove checking is python >= 3.4

[ ] Closes #xxxx
[ ] Tests added
[ ] Fully documented, including history.rst for all changes and api/*.rst for new API

This check is no longer needed.

If you remove import sys and run pre-commit I believe this should work. Thanks :+1:

Thanks @kloczek 👍


[PE-D][Tester A] Bug on slots command

slots d/2 p/10-6 o/mon, tue, fri
The above command is an example provided for the slots command, in the user guide. However, the command is not executable, i.e. the app reacts to nothing.

Labels: severity.High type.FunctionalityBug
original: AndrewOng2066/ped#9

10-6 is an invalid period, show error

PR #251 resolves this issue.


single select support

I add a method ：justSingle
feature ：select a Media without preview，Matisse Activity finish immediately when click a media item。

First of all , run ./gradlew checkstyle.

This PR is closed due to no further conclusions.

ok


Change Definition struct 'Type' field to support multiple data types …

Describe the change
This PR modifies the Definition struct by updating the Type field to support multiple data types. This change is intended to facilitate the use of union types for parameters, allowing schemas to accommodate a broader range of data types as specified by the OpenAI documentation.
Provide OpenAI documentation link
https://platform.openai.com/docs/guides/structured-outputs/supported-schemas
Describe your solution
To address the need for supporting union types in schema definitions, the Type field in the Definition struct has been updated to allow for multiple data types. This change enables developers to define schemas that can handle a variety of data types, offering more flexibility in schema design.
Tests
Tested manually for both types (existing single type format and new multiple format)
Issue: #832

Hey @vish0l, we've just merged #819 with Schema improvements — please let me know if it works for you!

@sashabaranov works, thanks.


Fix docs requirements

Previously we ran tests and implicitly assumed deps were installed before
Then we made this better (in some ways) so that we would install these.
But installing these clashes with how we produce the built docs.
So this PR makes the split more explicit.

One non-blocking suggestion (use Python to read the requirements in the makefile), otherwise looks good.
I'm not clear on why the oso-sqlalchemy-roles-guide is being updated, though. I don't think it's blocking since it seems purely additive, but maybe it should have a seperate PR?

Thanks Alex! That's way better.
I updated the roles guide earlier this week or last week because it was missing dependencies. I noticed it was out of date because docs tests update the submodules, so figured I would include it here.

Also checked the docs publish job works by deploying to docs-preview.


[FEATURE] Set index-management plugin 3.0.0 baseline JDK version to JDK-21

Is your feature request related to a problem? Please describe
Set index-management plugin 3.0.0 baseline JDK version to JDK-21
Describe the solution you'd like
See please https://github.com/opensearch-project/OpenSearch/issues/10745
Related component
Build
Describe alternatives you've considered
N/A
Additional context
See please https://github.com/opensearch-project/OpenSearch/issues/14011

done with https://github.com/opensearch-project/index-management/pull/1276


Skip part of slice array analysis if any part is not analyzable.

Resolves #5601
Some variables are not present in array analysis.  One common case of that is, like this issue, where a variable is multiply defined.  If such a variable occurs in a slice then likewise the slice becomes not analyzable.  This PR implements this propagation of a slice part being unanalyzable to the whole of the slice.

Thanks very much for the PR, I've queued it for review.

Just had another report of an issue related to this that is making me think my solution is too restrictive.      I'm going to try to enable later array associations to be built on this slice even though we can't relate this slice to anything that has come before.

Just had another report of an issue related to this that is making me think my solution is too restrictive. I'm going to try to enable later array associations to be built on this slice even though we can't relate this slice to anything that has come before.

Does your commit 53589c9 make this PR ready for review, or is there more to add to address this?

Just had another report of an issue related to this that is making me think my solution is too restrictive. I'm going to try to enable later array associations to be built on this slice even though we can't relate this slice to anything that has come before.

Does your commit 53589c9 make this PR ready for review, or is there more to add to address this?

Thanks for the reminder.  I forgot to take off the in progress label.  It should be ready for review now.


Wrong position of context menu in certain cases

Context menu opens at wrong position and view scrolls away from selected cell in certain cases (e.g. scroll height very big).

Support Case: https://app.camunda.com/jira/servicedesk/agent/SUPPORT/queues/7/SUPPORT-4303

Closed via https://github.com/camunda/camunda-modeler/commit/8e25a3b4199f439fbda9b66b326a97733a2be430.


Issue 42

https://github.com/3MFConsortium/spec_volumetric/issues/42

@bubnikv : can you look over this PR?


CI is failing with Qiskit 1.3

https://github.com/Qiskit/qiskit-ibm-runtime/actions/runs/12115854747/job/33775055243?pr=2043
Warning, treated as error:
Cell printed to stderr:
/tmp/ipykernel_2341/2609998103.py:2: DeprecationWarning: The method ``qiskit.circuit.instructionset.InstructionSet.c_if()`` is deprecated as of qiskit 1.3.0. It will be removed in 2.0.0.
  qc_c_if.x(0).c_if(0, 1)

docs: exit 2 (19.97 seconds) /home/runner/work/qiskit-ibm-runtime/qiskit-ibm-runtime> sphinx-build -j auto -W -b html /home/runner/work/qiskit-ibm-runtime/qiskit-ibm-runtime/docs /home/runner/work/qiskit-ibm-runtime/qiskit-ibm-runtime/docs/_build/html pid=2276
  docs: FAIL code 2 (76.91=setup[[56](https://github.com/Qiskit/qiskit-ibm-runtime/actions/runs/12115854747/job/33775055243?pr=2043#step:6:57).89]+cmd[0.04,19.97] seconds)

Looks like the PR didn't have the latest changes from main that handled the Qiskit 1.3 updates - CI passing now https://github.com/Qiskit/qiskit-ibm-runtime/actions/runs/12124329832/job/33801815251?pr=2043


add tx cmd to wasm client

Description

The 7.3 release didn't export the tx command. This PR adds that.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Note for myself: add changelog.

Ah, false alarm: we had already fixed this but hadn't released it yet. 😓 I will make the release this week.
Thank you anyways, @nicolaslara!


The Hotkey "upgrade note to event" is no longer available in 0.10.6

Describe the bug
The key shorcut "upgrade note to event" is no longer available in 0.10.6 (MacOS version)
To Reproduce
Look for it in the hotkeys.
Expected behavior
Still having this hotkey and related feature available.
Screenshots

Device info (please complete the following information):

OS: MacOS 13.3
Plugin Version [e.g. 0.10.6]

Additional context
Not sure it's a bug. Could be a development choice...

Hi @JISL1, yes, this was a development choice. The feature was removed in 0.10.0.


Add handlers for MapViews zoom/scroll/rotate/pitchEnabled props (v10, iOS)

Description
Setting the MapView's zoomEnabled, scrollEnabled, rotateEnabled and pitchEnabled props was not handled by the swift side of things yet.
Reminder here: as soon as rnmapbox will migrate to the 10.4 sdk, additional GestureOptions can be set (as prepared in the code)
Checklist

[X] I have tested this on a device/simulator for each compatible OS
[ ] I mentioned this change in CHANGELOG.md

Code example
<MapView
  rotateEnabled={false}
  pitchEnabled={false}
  zoomEnabled={false}
  scrollEnabled={false}
/>

Description
Setting the MapView's zoomEnabled, scrollEnabled, rotateEnabled and pitchEnabled props was not handled by the swift side of things yet.
Reminder here: as soon as rnmapbox will migrate to the 10.4 sdk, additional GestureOptions can be set (as prepared in the code)

FWIW we should be already on 10.4.0, which we should change to 10.4.3
https://github.com/rnmapbox/maps/blob/7a38dfa4d2d6682b26a1374d6ceb3b3f12aafca8/rnmapbox-maps.podspec#L23

@mfazekas thanks for letting me know, missed that change and had my test env still on 10.3 - adapted the commit, cheers!


weather chatterbot not respond

Hello,
I have implemented example given with code. But bot respond nothing.give me suggestion how to implement it?
`from chatterbot import ChatBot
chatbot = ChatBot(
'Weather Bot',
input_adapter='chatterbot.input.TerminalAdapter',
output_adapter='chatterbot.output.TerminalAdapter',
logic_adapters=[
'chatterbot_weather.weather_adapter.WeatherLogicAdapter'
]
)
response = chatbot.get_response('What is the weather like today?')
`
Best Regards,
Piyush

Hi @piyushgohel It looks like you have this implemented correctly. I believe you will need to include an additional parameter called forecastio_api_key.
Based on the information on the PyPi page for forcastio (https://pypi.python.org/pypi/python-forecastio/) you may be able to get an API key to use from https://darksky.net/dev/
(It appears that Forcastio was renamed to Dark Sky at some point this past year.)


New Feature - *nix std input pipe logic support

It would be convenient to be able to use *nix pipe support for the chatgpt binary to perform things like:

cat filename.txt | chatgpt "Summarize the text"
chatgpt "Summarize the text" < cat ${filename.txt}
chatgpt read file ./filename.txt and Markdown
chatgpt identify redundant information in the file ./filename.txt

Constraint:

Limit of tokens per request. ChatGPT 4 will have a support for 32K
Split the prompt by iteration max_token per prompt interaction

Controls:

Need to return an error if the size of text input is bigger than prompt max_token_size

Asking ChatGPT to help with this:
What code would be required for chatgpt-wrapper to support input pipe like this command ?
$ chatgpt "Summarize this text" < ./Draft.txt
$ cat ./Draft.txt | chatgpt "Summarize this text"

To support input pipe like the command above (cat file.txt | chatgpt "Summarize this text"), you can modify the chat() method in the ChatGPT class of your chatgpt-wrapper code as follows:
def chat(prompt):
    try:
        # Check if prompt is being passed via STDIN input pipe
        if not prompt:
            prompt = sys.stdin.read().rstrip()  # Read input from pipe
    except Exception as e:
        print(f"Error while reading from input pipe: {e}")
        return ""

    # Convert prompt to GPT-3 API format
    gpt3_prompt = format_prompt(prompt)

    # Send prompt to GPT-3 API and get response
    response = send_request(gpt3_prompt)

    # Extract text from response
    try:
        text = extract_text(response)
    except Exception as e:
        print(f"Error while extracting text from response: {e}")
        return ""

    # Return response text
    return text

This modification checks if the prompt argument is empty, which indicates that the input is being passed via STDIN input pipe. If it's empty, the function reads the input from the pipe using sys.stdin.read().rstrip().
Note that this modification assumes that your chatgpt-wrapper code already handles the prompt argument passed to the chat() method when it's called directly (i.e. without the input pipe).

Please do not paste long responses generated by ChatGPT in this issue queue, it makes reading the issue more difficult, and any user can easily perform this themselves.
Can you please explain why you cannot use the existing /file command, or write your own simple wrapper around the Python module to perform this function?

In addition to @1core2life 's comments, I'm not sure if pipes are a good fit with this particular tool.
Don't get me wrong, I love the flexibility of the Unix pipe philosophy, but something feels off about it here, although I'm not able to articulate my concern yet.

Implemented with https://github.com/mmabrouk/chatgpt-wrapper/commit/f7e3cf54934ee22345578f9ca0528471181312d0 and https://github.com/mmabrouk/chatgpt-wrapper/commit/3b2915b231e07c6ec28cab2c8c48bf9e812914d5
chatgpt -i ~/Desktop/something.txt summarize this


I think Code.Identifier.classify is deleted in elixir 1.14-dev

warning: Code.Identifier.classify/1 is undefined or private
  lib/sourceror/code/normalizer.ex:257: Sourceror.Code.Normalizer.normalize_literal/3

warning: Code.Identifier.classify/1 is undefined or private
Invalid call found at 4 locations:
  lib/sourceror/code/formatter.ex:551: Sourceror.Code.Formatter.quoted_to_algebra/3
  lib/sourceror/code/formatter.ex:929: Sourceror.Code.Formatter.module_attribute_to_algebra/4
  lib/sourceror/code/formatter.ex:1543: Sourceror.Code.Formatter.atom_to_algebra/1
  lib/sourceror/code/formatter.ex:2082: Sourceror.Code.Formatter.module_attribute_read?/1

warning: Code.Identifier.inspect_as_function/1 is undefined or private
Invalid call found at 2 locations:
  lib/sourceror/code/formatter.ex:974: Sourceror.Code.Formatter.capture_target_to_algebra/3
  lib/sourceror/code/formatter.ex:1019: Sourceror.Code.Formatter.remote_to_algebra/3

It was remove with the PR https://github.com/elixir-lang/elixir/pull/11446

Yes, because this I put it here, if you have a time to select or another function instead of this.
Thank you for all your efforts.

I think the best thing to do is to vendor the removed module, ie to copy the last version of that module and paste it under the Sourceror.Code namespace, like I did with the formatter and normalizer.
A PR is welcome, I don't have the mental bandwidth to do it myself right now due to a lot of personal issues


Can not play videos

Describe the bug
Recently, after I updated webkit2gtk version to 2.42.4, my tauri app can not play videos. A video player is rendered, but the video is not rendered.

And the tauri app says an error (Please see stack trace section).
The previous webkit2gtk version was 2.42.2, and it was working at that time.
Reproduction

Create an empty tauri app$ pnpm create tauri-app
✔ Project name · test
✔ Choose which language to use for your frontend · TypeScript / JavaScript - (pnpm, yarn, npm, bun)
✔ Choose your package manager · pnpm
✔ Choose your UI template · Vanilla
✔ Choose your UI flavor · TypeScript

Edit index.html and add video element  <video id="video1" style="width:600px;max-width:100%;" controls="">
    <source src="https://www.w3schools.com/html/mov_bbb.mp4" type="video/mp4">
    Your browser does not support HTML5 video.
  </video>

Execute pnpm tauri dev and play the video. The video is started, but it is not rendered.

Expected behavior
The video is rendered with the player.
Full tauri info output
[✔] Environment
    - OS: Manjaro 23.1.2 X64
    ✔ webkit2gtk-4.0: 2.42.4
    ✔ rsvg2: 2.57.1
    ✔ rustc: 1.74.1 (a28077b28 2023-12-04)
    ✔ cargo: 1.74.1 (ecb9851af 2023-10-18)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: 1.74.1-x86_64-unknown-linux-gnu (default)
    - node: 20.10.0
    - pnpm: 8.13.1
    - yarn: 1.22.19
    - npm: 10.2.3

[-] Packages
    - tauri [RUST]: 1.5.3
    - tauri-build [RUST]: 1.5.1
    - wry [RUST]: 0.24.7
    - tao [RUST]: 0.16.1
    - @tauri-apps/api [NPM]: 1.5.3
    - @tauri-apps/cli [NPM]: 1.5.9

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../out
    - devPath: http://localhost:1420/
    - framework: React (Next.js)
    - bundler: Webpack

Stack trace
KMS: DRM_IOCTL_MODE_CREATE_DUMB failed: Permission denied
Failed to get GBM buffer from swap chain: error creating plane 0 of size 818x374 and format 538982482: Permission denied
KMS: DRM_IOCTL_MODE_CREATE_DUMB failed: Permission denied
Failed to get GBM buffer from swap chain: error creating plane 0 of size 818x374 and format 538982482: Permission denied
KMS: DRM_IOCTL_MODE_CREATE_DUMB failed: Permission denied

Additional context
This issue is similar to https://github.com/tauri-apps/tauri/issues/8462, but I've already used WEBKIT_DISABLE_DMABUF_RENDERER=1 env var. Regardless of this environment variable, the video will not be rendered.

I can reproduce this bug. Thanks a lot for reporting.
Will have a look into it!

The same thing!
But it only runs in dev, not in build :(
✔ Choose which language to use for your frontend · Rust - (cargo)   (p.s. on npm, the story is the same)
✔ Choose your UI template · Vanilla
[✔] Environment
- OS: Fedora 39.0.0 X64  (p.s. KDE version)
✔ webkit2gtk-4.0: 2.42.3
✔ rsvg2: 2.57.1
✔ rustc: 1.75.0 (82e1608df 2023-12-21)
✔ cargo: 1.75.0 (1d8b05cdd 2023-11-20)
✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
✔ Rust toolchain: stable-x86_64-unknown-linux-gnu (environment override by RUSTUP_TOOLCHAIN)
- node: 20.10.0
- npm: 10.2.3
[-] Packages
- tauri [RUST]: 1.5.4
- tauri-build [RUST]: 1.5.1
- wry [RUST]: 0.24.7
- tao [RUST]: 0.16.7
- tauri-cli [RUST]: 1.5.9
- @tauri-apps/api : not installed!
- @tauri-apps/cli [NPM]: 1.5.9
[-] App
- build-type: bundle
- CSP: unset
- distDir: ../src
- devPath: ../src

@smir-ant Are you trying to run a local file instead of a remote one? if it works in dev and not in build it sounds like https://github.com/tauri-apps/tauri/issues/3725 to me. If it's a remote video and you're trying the appimage it could also be this setting: https://tauri.app/v1/api/config/#appimageconfig.bundlemediaframework (only works when building on ubuntu)

@smir-ant Are you trying to run a local file instead of a remote one? if it works in dev and not in build it sounds like #3725 to me. If it's a remote video and you're trying the appimage it could also be this setting: https://tauri.app/v1/api/config/#appimageconfig.bundlemediaframework (only works when building on ubuntu)

It was about remote video, appimage, right
Sorry, I'm weak, I understand what I need
Bundle Resources > App Image Config > bundle Media Framework . I understand that true is needed, however, no matter how I try to edit tauri.conf.json . I get something like this:
$ cargo tauri build
Error tauri.conf.json error on tour > bundle: Additional properties are not allowed ('bundleMediaFramework' was unexpected)
Can you tell me exactly where to place the "bundle Media Framework": true? 🙏

tauri > bundle > appimage > bundleMediaFramework
example: https://github.com/openai-translator/openai-translator/blob/5ce92204bbe81388b2c8fe597e2270f33975f88d/src-tauri/tauri.conf.json#L42

like i said above, this config sadly only works when you run tauri build on ubuntu.

@mihawk90
One thing that isn't clear to me, does this work fine in dev mode and in the .deb therefore being an appimage specific problem?
If it's only the appimage, does setting this env var help? GSTREAMER_INCLUDE_BAD_PLUGINS="1" (for when you run tauri build).
For reference, the tauri config enables/disables this linuxdeploy plugin https://github.com/linuxdeploy/linuxdeploy-plugin-gstreamer

.. or if it's actually a change/regression in webkit2gtk, altough I can hardly imagine that in the span of 2 bugfix releases... nothing about it in the release notes for 2.42.3 or 2.42.4 either.

Wouldn't be the first time a patch breaks something. Not trying to exeggerate but it feels like that really happens in every webkitgtk version/patch.

One thing that isn't clear to me, does this work fine in dev mode and in the .deb therefore being an appimage specific problem?

I don't know unfortunately :( I'm on Fedora so I can't build Tauri with this. The only builds I have available are the GitHub actions on that repo :(

does setting this env var help? GSTREAMER_INCLUDE_BAD_PLUGINS="1"

Can that be done via a config file? :sweat_smile:

I don't know unfortunately :( I'm on Fedora so I can't build Tauri with this. The only builds I have available are the GitHub actions on that repo :(

Well, you can still run tauri dev then with that repo cloned, no? That should generally work fine on Fedora unless the repo does something Ubuntu specific (not talking about gstreamer).
The appimage bundler should also work on Fedora just the gstreamer plugin could potentially require ubuntu, idk if i ever tested it when i added the config.

Can that be done via a config file? 😅

Nope, only as an env var and only at build time, so for you probably irrelevant.

OK... a couple hours later, with a lot of trial and error and help on the Discord, we figured it out.
Turns out the GSTREAMER_INCLUDE_BAD_PLUGINS variable actually does nothing. It's kind of hidden in some comments on some issues on their repo, but essentially the linuxdeploy script only copies every gstreamer file it can find on the build host into the app.AppDir - which is then used to build the actual AppImage.
That means that the root cause of this issue is likely that the gstreamer1.0-plugins-ugly was not installed on the host, which means the x264 plugin wasn't available to be copied during build time.
I managed to build this on Fedora and was able to play an H.264 encoded video completely fine. So neither Tauri nor webkit2gtk are to blame here - they will use what is available, but this means that the correct codecs need to be installed on the build system first.
PS: Building on Fedora requires setting GSTREAMER_PLUGINS_DIR="/usr/lib64/gstreamer-1.0" and GSTREAMER_HELPERS_DIR="/usr/libexec/gstreamer-1.0" because the script expects Debian paths.


[Question] perms functionality for hiding/showing buttons submissionGrid?

Is it possible to get the perms functionality from formGrid for hiding/showing submissionGrid?

I don't think this was ever fully finished. The idea was that each submission could have different permissions based on the user so there is a function that is passed in to evaluate what the permissions are for that user for that submission. I don't think we have fully finished code for that but it should be straightforward to write.

I am closing the issue as it was created too long ago and there are no new comments here. I hope it was resolved. If not, please reopen it. Thanks!


Remove legacy code related to questions and activity/investigation structure

[#184536435]
@scytacki, this one one big PR, sorry, but I couldn't really do it incrementally.
I haven't added DB migrations yet, it'll be a subsequent PR.
I'd probably check mostly my changes related to search and publications, as I've removed quite a bit routes related to publishing. But I think they're all the legacy ones.

@scytacki, I've addressed both comments. You can double-check the first one, as I'm not sure if I understood it correctly. But I hope my manual tests kinda resolves doubts about learner object being created or not.


A small refactoring to the file whitelist.py

I don't see what you win here. Care to explain what makes this better? I believe readability counts.


'learningRate' is declared but its value is never used

https://github.com/BrainJS/brain.js/blob/349009fd5d5c3a1eb007c18e6f799296b6bbf39b/src/praxis/arthur-deviation-biases.ts#L40
It can be removed, in tests I try to pass only layer but compiler expect to pass learningRate.

Nice find! Willing to send a pull request?

Yes, sure

https://github.com/BrainJS/brain.js/pull/649


Allow text attribute changes

Allow the following text attributes to be passed into the signing paramaters dictionary:
-wraptext
-fontsize
-textalign
-linespacing
These are commonly used attributes and there isn't currently a way to change them from their defaults.
Allowing them to be passed into sign() would provide for much needed customization.

Thanks


Leaving the load balancing to k8s

The service discovery approach in the spring cloud project is driven by the client side. However k8s is already capable of the service discovery done on the server side.
This seems to result in a tries to catch up with all the possible kubernetes service discovery setups, like istio one: https://github.com/spring-cloud/spring-cloud-kubernetes/issues/233.
Why is there even a need to implemement all the behaviours on the client side? Shouldn't it be rather:

spring cloud responsibility: circuit breaker + fallback (as the specific client should decide about the behaviour)
k8s/istio/whatever k8s magic: service discovery (as the routing might be very specific to the networking/infrastructure level)

Or do I see it just wrong? As to me it seems, more stuff is comming in the future, like: https://www.telepresence.io/ (which might make the spring cloud kubernetes catch up race a crazy one).
Inspired by the: https://github.com/IBM/spring-cloud-kubernetes-with-istio#discovery-client-and-istio
sounds like we should simply leave the service discovery to kubernetes.
This might be an appropriate to be discussed in the stackoverflow, just wanted to get attention of the core devs here.
My understanding is that we can achieve, what I'd expect, simply via:

using @HystrixCommand(fallbackMethod and
@EnableCircuitBreaker

Would it be possibly worth documenting?

@typekpb The need the discovery module fills is to support the standard Spring Cloud client side load balancing through things like Ribbon.

However the client is blissfully unaware of such load balancing.
There are cases were client side load balancing is preferable and the discovery module provides the plumbing to get that working

@geoand OK, agree.
Shouldn't it be however documented as an option? With some best practices in the: https://github.com/spring-cloud/spring-cloud-kubernetes/blob/master/README.adoc ?
I might be even motivated to raise pull request for that (just to get it reviewed :) )

@typekpb A PR with what you think could/should be added would be great :)

One thing to note @typekpb is that the docs have been moved to the docs module

@geoand OK


Create new repo moose-team/enrich-message for rich-message.js

It feels like /lib/rich-message.js could be a nice little separate module that could be useful outside of friends too.
Any thoughts around separating it into another module at this time? Maybe moose-team/enrich-message? Or is this still premature?

i think this is a good idea

i like this too!

+1 rich-message module

OK, going to set up a new repo rich-message


[Table] Fix "more than" translation in es-ES

[x] I have followed (at least) the PR section of the contributing guide.

The change was left with "más de" as there is a difference between "más" and "mas".
"más" is an adverb of quantity, while "mas" is used to express an idea
solve part of bug #24300
Preview

@oliviertassinari It seems good to me if it is to close the topic, but do we comment on all of them including those with the correct translations or only those with "more than" repeated? 🤔

@oliviertassinari It seems good to me if it is to close the topic, but do we comment on all of them including those with the correct translations or only those with "more than" repeated? 🤔

The motivation is to remove any corrupted translation, to create an incentive for the community to go fix it (to make it more visible)

The motivation is to remove any corrupted translation, to create an incentive for the community to go fix it (to make it more visible)

I will update the PR

I will update the PR

What do you think about commenting out all the wrong labelDisplayedRows translations?

Ready!

What do you think about commenting out all the wrong labelDisplayedRows translations?

Ready!

@vicasas Great

@vicasas Great


Clickable area of text path is giant in Chromium/Chrome

Hi there,
I noticed that in Chromium/Chrome browsers, the clickable area of the text path of a linestring is the entire bounding box of the linestring.  Yikes! You can see that on the Leaflet.TextPath demo page (and for more detail, highlight the bounding box using the Chromium/Chrome "Inspect element" feature).  Consequently, when one has several clickable linestrings on a page, it's difficult to click the one one wants :-(
This problem does not occur with Firefox, wherein the clickable area is just the text path, thank goodness.

Through a long and annoying path, I have figured out one workaround. If you pass "pointer-events": "none" in the attributes, this seems to help.

That does the trick.  Thanks!

Thanks guyz for the feedback !
Anything you could contribute as a pull-request to fix the problem for everybody ?


slack does not work with kernelPackages set to linuxPackages_latest_hardened

Describe the bug
If boot.kernelPackages is set to pkgs.linuxPackages_latest_hardened, slack will refuse to launch due to the following error:
[4669:0701/213102.789623:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /nix/store/4hjwhz43wmbwywc8iqb47v3mpdaiapnd-slack-4.4.3/lib/slack/chrome-sandbox is owned by root and has mode 4755.
fish: “slack” terminated by signal SIGTRAP (Trace or breakpoint trap)

To Reproduce
Steps to reproduce the behavior:

Configure NixOS with boot.kernelPackages = pkgs.linuxPackages_latest_hardened
Configure NixOS with `environment.systemPackages = [ pkgs.slack ];
Run slack

Expected behavior
Slack should launch successfully.
Additional context
Add any other context about the problem here.
Notify maintainers
@NeQuissimus
Metadata

system: "x86_64-linux"
host os: Linux 5.6.19-hardened, NixOS, 20.09.20200630.b3251e0 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.4pre20200622_334e26b
channels(root): "nixos-20.03.1950.48723f48ab9"
channels(terje.larsen): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
attribute:
- slack

Are you using the hardened profile as well as the hardened kernel?
This looks related to my issue https://github.com/NixOS/nixpkgs/issues/89599.

What is hardened profile? I don't know about that one, but I am using the hardened kernel. I also see the same issue with Google Chrome, I think you are correct that it is the same kind of issue.

Ah, just happened to read the documentation and found what you mean with the profile, so my answer is no, I do not.
For those curious:
https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/profiles/hardened.nix

Of note, this also happens on a Debian OS using nix for package management to install Slack.

If this also occurs on a Debian host it seems to me the problem is not related to the hardened kernel provided by NixPkgs.  I suggest closing the issue or at least renaming it.

Closing this for now.
Nix strips setuid bits from any binary installed to the Store, so you need to patch the software to use a suid stub installed outside the Store (setuid wrappers in NixOS, for example).
I believe chromium will make use of unprivileged user namespaces instead of setuid stubs, if possible.  It may be that your host disables unprivileged user namespaces and that the software falls back to suid stub, which then fails because it is located in the Store (and hence lacks the requisite bits).

My fix for #89599 might help Slack too, though I don't use that or any other Electron application.

@8573 indeed, this looks like https://github.com/NixOS/nixpkgs/issues/89599 and https://github.com/NixOS/nixpkgs/issues/97682.


AmazonMQ: RabbitMQ integration

Note: If you have a feature request, you should contact support so the request can be properly tracked.
I've reached out to support.
Output of the info page
There is no agent in this case.
Additional environment details (Operating System, Cloud provider, etc):
Steps to reproduce the issue:

Enable the AmazonMQ integration
Create an AmazonMQ cluster that uses RabbitMQ
See no metrics coming in

Describe the results you received:
I would like DataDog to support monitoring RabbitMQ on AmazonMQ.
Describe the results you expected:
Expected to have support for this Amazon service.
Additional information you deem important (e.g. issue happens only occasionally):
I opened a support case, how can I be sure it reaches the right team?

Hello @rarecrumb, since you've created a support ticket, someone will help you debug this issue. I'll close this issue for now.


[NOMRG] Use cpuinfo

Dummy PR just to see what breaks if we were to use stuff from pytorch/cpuinfo

https://github.com/pytorch/vision/pull/7539


Change the dashboard layout, remove Navbar and Footer

So the dashboard now doesn't look anything like Duolingo, the layout needs to change where the Navbar on the left stays in place and the right side can be scrolled. Also disable the top navbar and the footer when the user logs in.

I removed the footer and the navbar bro, just to let you know.


DPR-99

DPR Phase-1 platform IaC

For Glue Related Roles, this will be refactored once the POC is complete - we are limited with Data Ingestion side of things hence the roles are bit broad for Glue.
KMS - I shall review them, Thanks


internalLoadAll: can not set the parent environment of a namespace

R version: v4.2.1
System: win10
vscDebugger:::internalLoadAll(".")

i Loading vscDebugger
Error in `parent.env<-`(`*tmp*`, value = <environment>) :
  can not set the parent environment of a namespace
2: `parent.env<-`(`*tmp*`, value = <environment>) at overwrites.R#281

https://github.com/ManuelHentschel/vscDebugger/blob/master/R/overwrites.R#L273-L280

Must be related to https://stat.ethz.ch/pipermail/r-devel/2014-October/069931.html ? I also confirm that debugging of packages doesn't work on r 4.2.1 in win10.


bug for REINSTALL

the benchbot have somthing wrong so i try to reinstall the banchbot. i have the bug which i have never met before.
here the details:
Step 8/36 : RUN sudo rosdep init && rosdep update &&     mkdir -p ros_ws/src && source /opt/ros/melodic/setup.bash &&     pushd ros_ws && catkin_make && source devel/setup.bash && popd
---> Running in 633b142b6ebb
ERROR: cannot download default sources list from:
https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/sources.list.d/20-default.list
Website may be down.
The command '/bin/bash -c sudo rosdep init && rosdep update &&     mkdir -p ros_ws/src && source /opt/ros/melodic/setup.bash &&     pushd ros_ws && catkin_make && source devel/setup.bash && popd' returned a non-zero code: 4
i guess it is because the internet, but i have tried too many ways but just cannot fix it.

Given the link definitely resolves, this seems to be caused by local network issues (either the proxy issues you were describing in another issue, or general network issues).
I would recommend testing any failed links manually @rex131  to ensure that the issue is in fact with BenchBot (e.g. if the link works on your machine, but not within BenchBot install scripts).


lib: Fix #30902

Motivation for this change
See the "lib, stdenv: Check..." commit for details.
Work in progress because I need to overhaul release-lib.nix, and maybe other uses of meta.platforms.
Fixes #30902
Things done
Need to ensure release-lib.nix packages still eval fine.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

CC @bgamari @dtzWill

@GrahamcOfBorg eval

@dtzWill lets land this first. Frankly, I'm not sure how you made it so far without it.

Haha, not sure! Will take a look shortly.

I can eval everything locally, but it kills @GrahamcOfBorg so not sure what that's about. I hope its not just me making everything more expensive.

The message is from Boehm GC, to be clear.

I could be wrong but I think evaluating all of nixpkgs is beyond our Borg friend's limits currently.
Large hydra evaluations specifically strip out a bunch of stuff to reduce memory, so it's not without precedent to find evaluating all the things a large task :).
That said, it may be worth quickly testing time/memory of a large evaluation before and after this change -- regressing too badly on this will negatively impact almost everyone and probably summon an angry mob.  But just be sure this doesn't 2x evaluation time or something :P.
Borg may want to use a larger heap, which I think is the usual way to workaround that error. I forget the environment variable name O:).
Not sure where previous discussion of this ended up, for example: https://github.com/NixOS/nixpkgs/pull/33747#issuecomment-357058857
Ideally of course we'd be constantly making evaluation faster using less memory :D.

I think evaluating all of nixpkgs is beyond our Borg friend's limits currently.

OfBorg's evaluators have 16G of RAM.

it may be worth quickly testing time/memory of a large evaluation before and after this change -- regressing too badly on this will negatively impact almost everyone and probably summon an angry mob.

Agreed :)
Especially on:

just be sure this doesn't 2x evaluation time or something :P

Borg may want to use a larger heap, which I think is the usual way to workaround that error. I forget the environment variable name O:).

I think we want GC_MAXIMUM_HEAP_SIZE but I'm not sure what to set it to. I think this eval error is reproducible outside of borg using the outpaths.nix https://github.com/NixOS/ofborg/blob/released/ofborg/src/outpaths.nix Basically:
cp ../ofborg/ofborg/src/outpaths.nix .; nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true > outs

Can someone do a bit of trial and error on that? I can set the variable on the evaluators.

@GrahamcOfBorg eval
also this ^ I'll keep tabs on the eval in my monitoring.

I forget if it helped but I'll just note that we do use a boehmgc that is /not/ tuned for "large" heaps where IIRC "large" is definitely smaller than what we use on most evals.
https://github.com/ivmai/bdwgc/blob/b5cab5aacd263577af3502ecf068612591d27704/configure.ac#L840
https://github.com/ivmai/bdwgc/blob/master/doc/README.macros
Err nevermind this, until I look into it more (or someone else does), just wanted to mention while on the subject.

This PR doesn't seem to have a substantial impact ...  but I only looked at four evals in some fairly lousy data.

@dtzWill before pinging Eelco, can you try it and see if it makes an improvement? :)

@dtzWill before pinging Eelco, can you try it and see if it makes an improvement?

Sure.  But since he introduced the enableLargeConfig option it seemed likely he had existing knowledge/experience/opinions/insights on the subject before investigating myself.  Anyway, point taken I'll drop it until I have evidence it helps :).

It seems master went over the line, so we must have been mighty close:

https://github.com/NixOS/ofborg/commit/03a2d8427a83fdc893a965cc3b5c5a59b5c0509d
https://github.com/NixOS/ofborg/commit/70b55fba42ead4ac21a43c9c9f917ed9ecdd4641

@GrahamcOfBorg eval

Success on aarch64-linux (full log)
Partial log (click to expand)
/nix/store/bwl4ml2xvfjhfm2f0fr1yy4pllclpd2j-stdenv

Success on x86_64-linux (full log)
Partial log (click to expand)

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  6824  100  6824    0     0  37701      0 --:--:-- --:--:-- --:--:-- 37701

fetching path ‘/nix/store/78sxg2kvl2klplqfx22s6b42lds7qq23-stdenv’...

*** Downloading ‘https://cache.nixos.org/nar/0jkwyzl1mcmfr2w682v84hnkrpxh40b5w0wbgr74iskvi5a3qzjl.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/78sxg2kvl2klplqfx22s6b42lds7qq23-stdenv’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 10696  100 10696    0     0  60772      0 --:--:-- --:--:-- --:--:-- 60772

/nix/store/78sxg2kvl2klplqfx22s6b42lds7qq23-stdenv

Success on x86_64-darwin (full log)
Partial log (click to expand)
/nix/store/pa9mggxfc2965vqf15nwjk58x687m0jl-stdenv-darwin

Woah, surprised this is considered a rebuild, but glad it evals!

@vcunat have time to luck at this? I'll track down the rebuilds cause, but I think the basic concept isn't going to change to much from this.

I've known about this PR from the beginning, but even this weekend got filled by issues that felt more urgent (like retpoline for our kernels).
The approach sounds OK in general, though I'd be careful about impact on overall evaluation performance.

@vcunat I'd like to add some cross jobs to nixpkgs-unstable for 18.03, and this is more or less a prereq to doing that properly.

e.g. https://hydra.nixos.org/jobset/nixpkgs/cross-trunk/evals?page=1 somebody just destroyed it, and I have no idea how.

@Ericson2314 can you reproduce any of those failures? Generally (most/all?) are due to building the cross-cc, but that seems to build fine for me in various configurations.
This job includes cross-cc and is marked as failing but builds for me on master:
$ nix build -f pkgs/top-level/release-cross.nix rpi.busybox

Maybe builders were having a bad day? Or did you do something to fix things since those evals?

Someone restarted them and they seem mostly OK again.

@dtzWill I restarted hydra. Spurious or not, though, I want us to be held to (some of) the builds succeeding.

How's this looking?

I should rebase, and fix the rebuilds. Will try tonight!

This is still waiting for some fixes, right?

Yeah sorry. Didn't do it that last weekend or this one. I'll try now.

I suppose we can cherry-pick such stuff to 18.03, during March at least.

#36232 has a bunch of other changes for U-Boot, so I included the removeAttrs fix there.

Only checked linux, but just need to fix pharo eval on that platform.

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘dvdisaster-0.79.5’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/tools/cd-dvd/dvdisaster/default.nix:77 is not supported on ‘x86_64-apple-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)

*** Downloading ‘https://cache.nixos.org/nar/1975z8dwpzf8yxk11183x6prghz8knq22h7hrlyvdg3sifkcm9nq.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/xpv4zfmfkcc2q72clh25v7j0plnvxqcc-ceph-12.2.2-dev’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 52132  100 52132    0     0  52132      0  0:00:01 --:--:--  0:00:01 79348

/nix/store/xpv4zfmfkcc2q72clh25v7j0plnvxqcc-ceph-12.2.2-dev
/nix/store/m8zp5j6k9528675rq6mxg7lpks3q8qhw-dvdisaster-0.79.5
/nix/store/v237i597wfqd7ga9696202xzdrzyrgrs-nethack-3.6.0
/nix/store/l3nz0167a4xhb78ldcjns5p4dwvlm1cw-stdenv

Failure on aarch64-linux (full log)
Partial log (click to expand)
make: *** [Makefile:1835: db/transaction_log_impl.o] Error 1
make: *** [Makefile:1835: db/builder.o] Error 1
make: *** [Makefile:1835: db/managed_iterator.o] Error 1
make: *** [Makefile:1835: db/internal_stats.o] Error 1
make: *** [Makefile:1835: db/db_impl_experimental.o] Error 1
make: *** [Makefile:1835: db/column_family.o] Error 1
make: *** [Makefile:1835: db/version_set.o] Error 1
builder for '/nix/store/68kj37l301pdx9v93c9mlw4bb01g6zyb-rocksdb-5.10.3.drv' failed with exit code 2
cannot build derivation '/nix/store/bihrjm6z62cn009hh3gn7c0z2x72svnn-ceph-12.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bihrjm6z62cn009hh3gn7c0z2x72svnn-ceph-12.2.2.drv' failed

Success on x86_64-darwin (full log)
Attempted: nethack, stdenv
The following builds were skipped because they don't evaluate on x86_64-darwin: ceph, dvdisaster, robo3t
Partial log (click to expand)
these paths will be fetched (1.33 MiB download, 3.83 MiB unpacked):
  /nix/store/3yy6nwdm130491ns086ivz7nd1k62c0d-less-530
  /nix/store/z1v51i8zviwij91nfgrn86103nbs8ik2-nethack-3.6.0
copying path '/nix/store/3yy6nwdm130491ns086ivz7nd1k62c0d-less-530' from 'https://cache.nixos.org'...
copying path '/nix/store/z1v51i8zviwij91nfgrn86103nbs8ik2-nethack-3.6.0' from 'https://cache.nixos.org'...
/nix/store/z1v51i8zviwij91nfgrn86103nbs8ik2-nethack-3.6.0
/nix/store/0igxxngigjgfkgg3cw547n92b8bpg6b1-stdenv-darwin

Success on x86_64-darwin (full log)
Attempted: nethack, stdenv
The following builds were skipped because they don't evaluate on x86_64-darwin: ceph, dvdisaster, pharo, pond, robo3t
Partial log (click to expand)
these paths will be fetched (1.23 MiB download, 3.61 MiB unpacked):
  /nix/store/z1v51i8zviwij91nfgrn86103nbs8ik2-nethack-3.6.0
copying path '/nix/store/z1v51i8zviwij91nfgrn86103nbs8ik2-nethack-3.6.0' from 'https://cache.nixos.org'...
/nix/store/z1v51i8zviwij91nfgrn86103nbs8ik2-nethack-3.6.0
/nix/store/0igxxngigjgfkgg3cw547n92b8bpg6b1-stdenv-darwin

Success on x86_64-linux (full log)
Attempted: ceph, dvdisaster, nethack, robo3t, stdenv
Partial log (click to expand)
copying path '/nix/store/2wchrlj3xllzp042nqs29y3n3rhc01y2-python2.7-pecan-1.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/3fjykff0lvi4sh4247kkqax7891rhqx2-python2.7-Sphinx-1.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/wbiy5590xc3cmlyflbjmp0izfx8v43iw-python-2.7.14-env' from 'https://cache.nixos.org'...
copying path '/nix/store/j7sfxzkrbwj66r2j7mh4gc6zcyf5g0yx-ceph-12.2.2' from 'https://cache.nixos.org'...
copying path '/nix/store/rr6qrrkiplwgaa996mwb50kayvnrq82w-ceph-12.2.2-dev' from 'https://cache.nixos.org'...
/nix/store/rr6qrrkiplwgaa996mwb50kayvnrq82w-ceph-12.2.2-dev
/nix/store/m8zp5j6k9528675rq6mxg7lpks3q8qhw-dvdisaster-0.79.5
/nix/store/v237i597wfqd7ga9696202xzdrzyrgrs-nethack-3.6.0
/nix/store/6p5ihq04y5j86lzrgz9smkvwkphmxxy3-robo3t-1.1.1
/nix/store/l3nz0167a4xhb78ldcjns5p4dwvlm1cw-stdenv

Success on x86_64-linux (full log)
Attempted: ceph, dvdisaster, nethack, pharo, pond, robo3t, stdenv
Partial log (click to expand)
patching script interpreter paths in /nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo
/nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo/bin/pharo: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-pharo.drv-0 in /nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo...
/nix/store/rr6qrrkiplwgaa996mwb50kayvnrq82w-ceph-12.2.2-dev
/nix/store/m8zp5j6k9528675rq6mxg7lpks3q8qhw-dvdisaster-0.79.5
/nix/store/v237i597wfqd7ga9696202xzdrzyrgrs-nethack-3.6.0
/nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo
/nix/store/d5788dwp38zmlb3i2v5551ihc20wgmy6-pond-20150830-bce6e0d-bin
/nix/store/6p5ihq04y5j86lzrgz9smkvwkphmxxy3-robo3t-1.1.1
/nix/store/l3nz0167a4xhb78ldcjns5p4dwvlm1cw-stdenv

Failure on aarch64-linux (full log)
Attempted: ceph, dvdisaster, nethack, stdenv
The following builds were skipped because they don't evaluate on aarch64-linux: robo3t
Partial log (click to expand)
 }
 ^
make: *** [Makefile:1835: db/db_iter.o] Error 1
make: *** [Makefile:1835: db/managed_iterator.o] Error 1
make: *** [Makefile:1835: db/compaction_job.o] Error 1
make: *** [Makefile:1835: db/db_impl_files.o] Error 1
make: *** [Makefile:1835: db/version_set.o] Error 1
builder for '/nix/store/qqphgaxm3gc4lks6bkgjkf6p8gdlzmkw-rocksdb-5.10.3.drv' failed with exit code 2
cannot build derivation '/nix/store/jxwh06fj57fk9g1xy32b2882q5i1mwib-ceph-12.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jxwh06fj57fk9g1xy32b2882q5i1mwib-ceph-12.2.2.drv' failed

Failure on aarch64-linux (full log)
Attempted: ceph, dvdisaster, nethack, pond, stdenv
The following builds were skipped because they don't evaluate on aarch64-linux: pharo, robo3t
Partial log (click to expand)
make: *** [Makefile:1835: db/write_batch.o] Error 1
make: *** [Makefile:1835: db/forward_iterator.o] Error 1
make: *** [Makefile:1835: db/db_impl_readonly.o] Error 1
make: *** [Makefile:1835: db/managed_iterator.o] Error 1
make: *** [Makefile:1835: db/compaction_job.o] Error 1
make: *** [Makefile:1835: db/db_impl_open.o] Error 1
make: *** [Makefile:1835: db/db_impl.o] Error 1
builder for '/nix/store/qqphgaxm3gc4lks6bkgjkf6p8gdlzmkw-rocksdb-5.10.3.drv' failed with exit code 2
cannot build derivation '/nix/store/jxwh06fj57fk9g1xy32b2882q5i1mwib-ceph-12.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jxwh06fj57fk9g1xy32b2882q5i1mwib-ceph-12.2.2.drv', '/nix/store/sxlr85fvkvir3jkx6j1ycnrh8d75ga2a-pond-20150830-bce6e0d.drv' failed

Success on x86_64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/l3nz0167a4xhb78ldcjns5p4dwvlm1cw-stdenv

Success on aarch64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/rvpmm1jmqi7j1w3a073511plvlbl4fw7-stdenv

Ok, pre-fixed all the misbehaving packages so this is ready for final review! No more rebuilds anymore.

Success on x86_64-darwin (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/0igxxngigjgfkgg3cw547n92b8bpg6b1-stdenv-darwin

I need to do a PR on top of this, so I'm going to merge it. Feel free to revert if eval time problems arise, but this should be good in all other respects.

Success on x86_64-darwin (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/w3k60lgxbkj1sj1zpyh50671qpky0v1w-stdenv-darwin

Success on aarch64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/yq16vcdl95kfqjzq23lxhin38i3whlyj-stdenv-linux

Success on x86_64-linux (full log)
Attempted: stdenv
Partial log (click to expand)
/nix/store/6kz2vbh98s2r1pfshidkzhiy2s2qdw0a-stdenv-linux

@Ericson2314 Could you help updating this platforms line in boost: https://github.com/NixOS/nixpkgs/blob/18.03/pkgs/development/libraries/boost/generic.nix#L92? Currently Hydra attempts to build boost155 for Aarch64 and fails.

One can fall back on the legacy stuff by using https://github.com/NixOS/nixpkgs/blob/master/lib/systems/doubles.nix#L45 . I think that's easiest for now.

Thank you! We can replace platforms.unix with systems.doubles.unix on that line to fix it. However, may we express it in a non-legacy way?

Yeah. The new ones are https://github.com/NixOS/nixpkgs/blob/master/lib/systems/for-meta.nix made from https://github.com/NixOS/nixpkgs/blob/master/lib/systems/inspect.nix . There's still no negation but if you combine the x86 pattern with all the unix ones, you can get isx86 && isUnix.


Cursor jumps to end of the line when typing before a # in the command palette

Trying to type before the # in the command palette causes the cursor to jump to the end of the line.

Weird, only seems to be happening for the first character, not subsequent ones. Haven't fully looked into this but might be a bug.

Weird, only seems to be happening for the first character, not subsequent ones. Haven't fully looked into this but might be a bug.

After some investigation, the cause of this seems to be due to the quickAccesProvider changing here - https://github.com/microsoft/vscode/blob/master/src/vs/platform/quickinput/browser/quickAccess.ts#L146
In this scenario, it is switching from GotoSymbolQuickAccessProvider to AnythingQuickAccessProvider which updates the value selection and jumps the cursor to the end of the line.
It's also replicable when using any other PREFIX such as > or @

After some investigation, the cause of this seems to be due to the quickAccesProvider changing here - https://github.com/microsoft/vscode/blob/master/src/vs/platform/quickinput/browser/quickAccess.ts#L146
In this scenario, it is switching from GotoSymbolQuickAccessProvider to AnythingQuickAccessProvider which updates the value selection and jumps the cursor to the end of the line.
It's also replicable when using any other PREFIX such as > or @

Yeah thanks for finding, that code is there for a reason, specifically to allow to cycle through different quick access providers and always having the cursor at the end. Changing it there would probably break other features, so I am inclined to keep this as is.

Yeah thanks for finding, that code is there for a reason, specifically to allow to cycle through different quick access providers and always having the cursor at the end. Changing it there would probably break other features, so I am inclined to keep this as is.

How do you "cycle through" the providers? The experience here is not good, especially if you are trying to switch between >, @, #, etc

How do you "cycle through" the providers? The experience here is not good, especially if you are trying to switch between >, @, #, etc

@eamodio via commands, it is possible to configure commands that fill in text to the picker and if the picker is opened, this will just replace the text inside the picker and move the cursor to the end. We currently do not distinguish between the user typing and this happening through a command.


feat add grafana

@k8s-bot test this

There is no service that exposes grafana. I would add a ClusterIp service. It can then be used via kubectl proxy.
This chart also needs a README.md

@viglesiasce LGTM, we missing anything?

Thanks @tmc!!!


D365 Project Operations

I see there is D365 PSA, but P&O doesn't run on dataverse (dumb) like PSA does. So it will need to be listed separately

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4e27d0b1-56f9-2eb7-8fee-0c47cfbafeac
Version Independent ID: 12556227-6adc-52c1-ac60-f341ae247e51
Content: Azure and other Microsoft cloud services compliance scope - Azure Government
Content Source: articles/azure-government/compliance/azure-services-in-fedramp-auditscope.md
Service: azure-government
GitHub Login: @stevevi
Microsoft Alias: stevevi

@Gauntlet-KI
Thanks for your feedback! We will investigate and update as appropriate.

@Gauntlet-KI Thanks for your feedback! We will investigate and update as appropriate.

Thank you

Only cloud services that have been authorized can be listed.  If P&O = Dynamics 365 Project Operations, that service isn't listed in the FedRAMP Marketplace or DISA PA letters, which is why it doesn't appear in this article.

If D365 PSA is being "evolved" to D365 PO, then something needs to be done to highlight this change, to a service that is not supported.


Add option to keep all table descriptor leases active on all nodes

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw8IfZMg9Up8SP33/recmeOiJ81qstDJ6A
Eng partners: @vivekmenezes

I'm creating a mechanism for this which is automatic so this will not need docs support. We might add some configuration options in for 2.2.

OK, thanks, @vivekmenezes. I heard "option" as something users can control. But even if there's no user action involved, we'll probably want to revise/improve this part of our architecture docs: https://www.cockroachlabs.com/docs/v2.0/architecture/replication-layer.html#expiration-based-leases-meta-system-ranges.

Actually, I'm not sure that part (or any part) of the architecture docs cover table descriptors...

PR: https://github.com/cockroachdb/cockroach/pull/28725
From release notes:

CockroachDB now periodically refreshes table leases to avoid initial latency on tables that have not been accessed recently. [#28725][#28725] {% comment %}doc{% endcomment %}

There's also a cluster setting for changing the refresh limit:
sql.tablecache.lease.refresh_limit                   | 50        | i            | maximum number of tables to periodically refresh leases for

@vivekmenezes, I assume we should not call out that setting in the docs? In that case, do you agree that we should add a sentence/paragraph about table leases in the architecture docs?

I don't think we want to document this because this is a temporary fix for a problem. In release 2.2 we plan to implement epoch based leases which will get rid of this entire refresh mechanism. IMHO it's best the user not know about table leases at all.

and we could mention them in the architecture docs for 2.2

OK, makes sense to me. Moving to 2.2.


README.md 'Training New Models' steps are not working

Rasa NLU version (e.g. 0.7.3):
0.10.0 w/ PIP
Used backend / pipeline (mitie, spacy_sklearn, ...):
None
Operating system (windows, osx, ...):
Linux
Issue:
After trying to train a new model (json or MD), I got:
{"error": "Missing project name to train"}
On the code, it indeed expects for a query parameter called "project".
I tried to send it, and it looks going a step further, but w/o lucky.
Content of configuration file (if used & relevant):

Thanks for noting that. the curl request wasn't quite right. I updated that. Let me know if there are still issues.

@tmbo , tks. I got over this training step for json. Unfortunately, things are not working yet.

You fixed the line for json, but not sure if for MD, is actually "train?name" or needs to be "train?project" like you just did for json? They are different.

I used JSON. It worked. But I simply cannot make it to work from here. I keep getting:
WARNING:rasa_nlu.project:Invalid model requested. Using default
even with this status:
{"available_projects": {"default": {"status": "ready", "available_models": ["fallback"]}, "test_model": {"status": "ready", "available_models": ["model_20171006-142730", "fallback"]}}}

Best,

@lovato thanks - corrected the md instructions as well, they just got lost in the process of working on multiple issues in parallel. Can you please create a new issue for your second point with instructions on how to reproduce that?

Tks. #627 was opened now.


Feature request - Collapse button - Searched strings in object explorer

After searching for something in Explorer, the searched folders remain open even when search cleared. When the results return items with lots of hits across many folders it makes a mess and difficult to navigate.
Can we have a clear / reset feature so that users don't have to perform an invasive page reload (or close folders individually).

Now auto closes after search term removed


1534| Count Good Triplets | C++

Title - Count Good Triplets
What will change - Add Code For Question 1534 in C++.
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign this to me.

Please assign to me I am a third year undergraduate in Electrical Engineering IIT Kharagpur with good background in competitive programming

Please I would like to add this code. Assign this to me.


Dropshadows on Content header on App layout component

Describe the feature
My team is building an application using Cloudscape for a customer who requires multi-tenancy, so we need to supply color-themed designs. We are using the new variables tool in Figma, but have run into a hurdle with one particular Cloudscape component on Figma.
We are able to correctly attach a Figma variable to the Content header component itself and theme that piece, and our developers are able to apply the color change using the colorBackgroundHomeHeader token.
However, on Figma, the way that card overlap is achieved on the App layout component is through the use of a drop shadow added to the bottom of the Content header. Drop shadows are not currently able to be attached to variables on Figma, though, so the result is a Content header that is 2/3 the correct color for our particular theme, and 1/3 the original Cloudscape grey-900. This is distracting and confusing to both our developers and the stakeholders we share our designs with.
We can of course manually change the color of the drop shadow, and indeed have to do so currently to satisfy our design requirements. However, this rather defeats the purpose and goal of using a design system.
We've noticed that it is possible to achieve the same type of overlay using a -36 space between on the App layer's auto layout. Would it be possible to update the Content header component to use this method to achieve the overlap, instead of the drop shadow? This would mean that the entire Content header could be colored using a variable, which would allow us to more easily apply color themes.
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate requests

Hey, thanks for reaching out and sorry for replying late. Could you share which Figma library and the version that you are using?

Hello, we're using the 1.1 version of Cloudscape Figma that was last updated 7 months ago.
See attached screenshots for current method vs proposed method

Hi there, thanks for your request, and sorry for the delay in responding. Our new Figma library (launching in Q2 of this year) will use a different mechanism for the header, which I think will address your issue. I'm closing this for now, but feel free to ping us again if the new library doesn't meet your needs.


Invalid "Use an interface instead of a type literal" warning?

TypeScript Version:  2.2.1
Code
interfaces.ts
interface IKeyValue {
  [key: string]: string;
}

interface IParent {
  foo?: IKeyValue;
  goo?: string;
}

// works

export interface ITestA extends IParent {
  foo?: {
    bar: string,
  };
}

// warning

type TFoo = {
  bar: string,
};

export interface ITestB extends IParent {
  foo?: TFoo;
}

// error
/*
interface IFoo {
    bar: string;
};

interface ITestC extends IParent {
  foo: IFoo;
}
*/

export class TestInline {
  public testA: ITestA;
  public testB: ITestB;
  // public testC: ITestC;

  public foo() {
    return 'foo';
  }
}

anywhere else
import {TestInline} from 'interfaces';

const ti = new TestInline();

Expected behavior:
If the warning "Use an interface instead of a type literal" is thrown, I should be able to replace the type literal by an interface without causing an error. If type and interface are not equivalent such a warning should not be thrown.
Actual behavior:
When I'm replacing the type literal at interface.ts line 19 with an interface definition (see commented out code), the compiler throws an error: [33:11] Interface 'ITestC' incorrectly extends interface IParent [...] Index signature is missing in type 'IFoo'.

Are you sure this warning comes from typescript? I'd guess that's coming from the tslint rule interface-over-type-literal https://palantir.github.io/tslint/rules/interface-over-type-literal/

Indeed this is from TSLint.

Oh, sorry for the hassle...

Just for reference: The TSLint guys consider the behaviour a bug in TypeScript. They refer to the issue "Index signature is missing in type (only on interfaces, not on type alias)".


07/09/2018 00:53 : Create Pull Request for branch prTesting_2018070900 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Replace gradle-all with gradle-bin

This reduces CI waste and avoids too many Gradle distributions on developers' machines.

Verified locally, looks good, and thank you. I've pushed an update on a separate branch for Gradle 6.9-bin.

Closing, as I merged the other PR.


errname: Modified the description of the error message

What problem does this PR solve?
The error message for "ErrTooBigPrecision" in TIDB is different from MYSQL.
What is changed and how it works?
Modified the description of the error message for "ErrTooBigPrecision".
Check List
Tests

Unit test

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Building Flash Attention from source:  Fatal error: cusolverDn.h: No such file or directory

I think this is related to https://discuss.pytorch.org/t/not-able-to-include-cusolverdn-h/169122, https://github.com/microsoft/DeepSpeed/issues/2684
Im trying the install flash attention following this: https://github.com/Rappsilber-Laboratory/AlphaLink2
I also tried also to install flash-attention from this repo, always get the same error. Using pip i get the subprocess error mentioned: 279
I made sure that the nivida and pytorch version match. I tested on a HPC, Local Computer and on the Cloud with a gpu and I get the same error. I tried to export the path as suggested in the link mentioned above, but it does not work.
../condaenvs/alphalink/lib/python3.10/site-packages/torch/include/ATen/cuda/CUDAContext.h:10:10: fatal error: cusolverDn.h: No such file or directory
   10 | #include <cusolverDn.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
error: command '/apps/opt/spack/linux-ubuntu20.04-x86_64/gcc-9.3.0/gcc-9.3.0-snvoz3owsjqmblhxyznvhfd75e4uvi6h/bin/gcc' failed with exit code 1

Yeah idk what's wrong, I've never run into such error. We recommend the Pytorch container from Nvidia, which has all the required tools to install FlashAttention.
Or if you're on torch 2.0+, FlashAttention is available as part of torch.nn.functional.scaled_dot_product_attention.