/entry.sh: 41: exec: develop: not found

I use exactly the same config, but it doesn't work.
docker build was ok
but docker run failed : /entry.sh: 41: exec: develop: not found

How are you going about using the image?
docker run -it --rm -v $(pwd)/site:/gatsby -p 8000:8000 aripalo/gatsby-docker develop
Should work just fine? Or are you building it locally?


Update to Unicode v9

Ref. #7.

Thank you @mathiasbynens! I wish I understood more about text encoding.


"Dev hourly" option is broken; fetches an invalid URL.

Just thought I'd let you know that the "dev hourly" function seems to be broken. It attempts to download the payload from an incorrect URL. It seems to use the logic for stable builds, i.e.
std::string url = std::string("https://astronautlevel2.github.io/Luma3DS/builds/Luma-") + hourlyName + ".zip";
instead of
std::string url = std::string("https://astronautlevel2.github.io/Luma3DSDev/builds/Luma-") + hourlyName + ".zip";
So, for example, it asks for https://astronautlevel2.github.io/Luma3DS/builds/Luma-ca587692.zip instead of https://astronautlevel2.github.io/Luma3DSDev/builds/Luma-ca587692.zip. Here is a screenshot of the issue.

Oops! Thanks for the report, I'll fix it ASAP!

Tested with latest changes (043318e) and working. Closing.


Multiplayer Desync Issue

I love SatisfiedStorage in solo play, but I tested it for my multiplayer modpack Happy Accidents and it causes a desync when the pawn goes to re-fill the stack.
To recreate:

Install Multiplayer Mod (or use above modpack and config) and SatisfiedStorage
Host a game w/ the Arbiter enabled (so you can detect desyncs alone w/o bothering your friends to test)
Setup a 1x1 stockpile for just simple meals for example
Let your pawns fill up the stockpile
Set the restock percentage to 80%
When the stack drops below the threshold and a pawn gets the job to restock it, the game desyncs.

My guess is that the restock percentage isn't being synchronized. No idea if looking at this patch that adds multiplayer api hooks is useful in this situation recent example of syncing information for multiplayer mod in allow tool
The last entry in the player.log before the desync is as follows:
Invoked Boolean TryTakeOrderedJob(Verse.AI.Job, Verse.AI.JobTag) on Verse.AI.Pawn_JobTracker with 2 params TakeInventory (Job_-1) A=Thing_MealSimple374451, 0

It doesn't look like anyone at Multiplayer Compatibility Mod is patching it as of yet.
Cheers!

I found two more possibly useful references, LWM Deep Storage mod is currently getting a patch to multiplayer sync their "Eject" button and had some discussion in the Multiplayer Compat Mod discord channel #dev-chat here: https://discord.gg/8ttTft5
Here is the wiki to their multiplayer API which from what I understand allows you to trigger it to sync the gui updates:
https://github.com/rwmt/MultiplayerAPI/wiki
No pressure to look into it, just gathering all the info in once place! Take care!

I'm working on a solution over here, haven't opened a PR yet as this is my first MP patch. Hoping to get some input from the multiplayer discord first before submitting to ya!

I tried everything I could think of, but still get a multiplayer desync for the corner case where a pawn is currently hauling to the stockpile when someone slides the hysteresis fill percent down lower thus canceling the job.
From my testing and forcing all pawns to stop jobs when the slider is touched, it seems like somehow the AI is giving pawns different new jobs on different machines causing the desync, but tbh i don't really know and this was my first attempt at MP patching...
I'm gonna punt on this patch for now, maybe later someone will figure it out.. lol cheers!

Well, after a lot of work and testing it seems like using a complex object like StorageSettings as the key in a dictionary doesn't sync deterministically for mutiplayer. I don't fully understand it, but seems like the key is using either a local memory ref or some per process startup randomized GetHashCode()..
So I combined aspects of your mod with aspects of Variety Stockpile Matters and created a new mod KanbanStockpile. I put you and other folks in credits, thanks much and cheers!

yeah i spent like 5-6 hours trying to sync settings for multiplayer as well with no luck. it would probably require to rewrite how it holds values. Inital aim of this mod was to port it to 1.2 and i dont have much time playing/modding rimworld due to real life right now. sorry about replying late,  also your mod looks great.

Yeah, I tried a lot of ways to sync those stockpile settings too, and got it kind of working.
But once I realized it may need a different data structure to hold the values, I decided to try a rewrite incorporating the best of both your Satisfied Storage and a little of Variety Matters Stockpile.
Thanks so much for putting your stuff up on github and sharing! It's been a fun project for me while I'm hiding out in my apartment not working right now, haha...
Take care and hope you get some time to play whatever you're into these days.
Cheers!


Replacing an ASG with a network interface ID fails with interface in use error

Description
According to the AWS docs, you can configure an ASG with a network interface ID for device zero. In this case, the ASG can only create a single EC2 instance, and any instance created by the ASG will always be attached to the given ENI. I.e. if the instance gets terminated, the replacement instance will still attach to the same ENI.
This works fine with this module, except for one thing. If for any reason the aws_autoscaling_group created by this module needs to be replaced, the following error occurs:
Error: waiting for Auto Scaling Group (ASG1-1234567890) capacity satisfied: 1 error occurred:
│       * Scaling activity<PHONE_NUMBER>): Failed: Interface: [eni-1234567890] in use. Launching EC2 instance failed.

I'm fairly certain this is caused by the fact that the aws_autoscaling_group resource created by the module has create_before_destroy enabled. With that setting in place, when the ASG gets replaced, the new ASG is created before the old one gets deleted. When that happens, the new ASG tries to create an instance, which tries to attach to the ENI, which is still attached to the old instance from the original ASG, thus producing the error above.
So the fix for this might involve adding an option to control the create_before_destroy setting on the aws_autoscaling_group resource. Or use the presence of a network_interface_id in the network_interfaces to determine how to set the create_before_destroy.

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 6.9.0

Terraform version: 1.3.7

Provider version(s):

Reproduction Code [Required]
terraform {
  required_version = "= 1.3.7"
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "= 4.58.0"
    }
  }
}

provider "aws" {
  region = "us-east-1"
}

locals {
  private_subnet_cidr_block = "<IP_ADDRESS>/23"
  availability_zone = "us-east-1a"
}

resource "aws_vpc" "vpc" {
  cidr_block = "<IP_ADDRESS>/20"

  instance_tenancy     = "default"
  enable_dns_support   = true
  enable_dns_hostnames = true
}

resource "aws_subnet" "private_subnet" {
  vpc_id                  = aws_vpc.vpc.id
  cidr_block              = local.private_subnet_cidr_block
  availability_zone       = local.availability_zone
  map_public_ip_on_launch = false
}

resource "aws_network_interface" "eni" {
  subnet_id       = aws_subnet.private_subnet.id
}

data "aws_ssm_parameter" "latest_ubuntu_ami" {
   name = "/aws/service/canonical/ubuntu/server/jammy/stable/current/amd64/hvm/ebs-gp2/ami-id"
}

module "autoscaling" {
  source  = "terraform-aws-modules/autoscaling/aws"
  version = "6.9.0"

  name = "ASG"

  instance_type = "t3.medium"
  image_id = data.aws_ssm_parameter.latest_ubuntu_ami.value

  min_size = 1
  max_size = 1
  desired_capacity = 1

  availability_zones = [local.availability_zone]

  network_interfaces = [
    {
      device_index          = 0
      network_interface_id  = aws_network_interface.eni.id
    }
  ]

}

Steps to reproduce the behavior:

Apply the terraform above to an AWS account.
Make sure the ASG creates the instance and that the instance starts up completely.
Add the following to the 'autoscaling' module:

  initial_lifecycle_hooks = [
    {
      name                  = "StartupLifeCycleHook"
      default_result        = "CONTINUE"
      heartbeat_timeout     = 60
      lifecycle_transition  = "autoscaling:EC2_INSTANCE_LAUNCHING"
    }
  ]

Apply the terraform again. The code added in step 2 above triggers a replacement of the ASG created in step 1.
You get the error about the ENI being in use and the instance failing to create.

Are you using workspaces? NO
Have you cleared the local cache (see Notice section above)? YES

Expected behavior
Replacing the ASG should not result in the error above. Setting create_before_destroy to false may address the issue.

This is still an issue.


addSlider2D: TypeError: DestroyTimer argument 1: an integer is required (got type NoneType)

Hi @marcomusy,
Here is another error that I could not figure out by myself. I am still trying to play with the same data as I used in Issue #504, and this time I am playing with the slider.
Here is the code I used:
#!/usr/bin/env python3

import numpy as np
from vedo import TetMesh, show, screenshot, settings, Picture, buildLUT, Box, \
    Plotter, Axes
from vedo.applications import Animation

import time as tm

def slider(widget, event):
    region = widget.GetRepresentation().GetValue()
    plot_mesh(region)

def plot_mesh(max_reg):

    """Plots the mesh based on the maximum region index"""

    # This will get rid of the background Earth unit and air unit in the model
    # which leaves us with the central part of the model
    tet_tmp = tet.clone().threshold(name='cell_scalars', above=0, below=max_reg)

    # So, we now cut the TetMesh object with a mesh (that Box object)
    tet_tmp.cutWithMesh(box, wholeCells=True)

    # And we need to convert it to a mesh object for later plotting
    msh = tet_tmp.tomesh().lineWidth(1).lineColor('w')

    # We need to build a look up table for our color bar, and now it supports
    # using category names as labels instead of the numerical values
    # This was implemented upon my request
    lut_table = [
        # Value, color, alpha, category
        (12.2, 'dodgerblue', 1, 'C1'),
        (15.2, 'skyblue', 1, 'C1-North'),
        (16.2, 'lightgray', 1, 'Overburden'),
        (18.2, 'yellow', 1, 'MFc'),
        (19.2, 'gold', 1, 'MFb'),
        (21.2, 'red', 1, 'PW'),
        (23.2, 'palegreen', 1, 'BSMT1'),
        (25.2, 'green', 1, 'BSMT2'),
    ]
    lut = buildLUT(lut_table)

    msh.cmap(lut, 'cell_scalars', on='cells')
    # msh.cmap("coolwarm", 'cell_scalars', on='cells')
    msh.addScalarBar3D(
        categories=lut_table,
        pos=(508000, 6416500, -1830),
        title='Units',
        titleSize=1.5,
        sx=100,
        sy=4000,
        titleXOffset=-2,
    )

    zlabels = [(500, '500'), (0, '0'), (-500, '-500'), (-1000, '-1000'),
            (-1500, '-1500')]
    axes = Axes(msh,
                xtitle='Easting (m)',
                ytitle='Northing (m)',
                ztitle='Elevation (m)',
                xLabelSize=0.015,
                xTitlePosition=0.65,
                yTitlePosition=0.65,
                yTitleOffset=-1.18,
                yLabelRotation=90,
                yLabelOffset=-1.6,
                # yShiftAlongX=1,
                zTitlePosition=0.85,
                # zTitleOffset=0.04,
                zLabelRotation=90,
                zValuesAndLabels=zlabels,
                # zShiftAlongX=-1,
                axesLineWidth=3,
                yrange=msh.ybounds(),
                xTitleOffset=0.02,
                # yzShift=1,
                tipSize=0.,
                yzGrid=True,
                xyGrid=True,
                gridLineWidth=5,
                )

    plt.show(msh, size=size)
    # screenshot('model_mesh_vedo.png')

    # from wand import image

    # with image.Image(filename='model_mesh_vedo.png') as imag:
    #     imag.trim(color=None, fuzz=0)
    #     imag.save(filename='model_mesh_vedo.png')

# Do some settings
settings.useDepthPeeling=False  # Useful to show the axes grid
font_name = 'Theemim'
settings.defaultFont = font_name
settings.multiSamples=8
# settings.useParallelProjection = True # avoid perspective parallax

# Create a TetMesh object form the vtk file
tet = TetMesh('final_mesh.vtk')

# This will get rid of the background Earth unit and air unit in the model
# which leaves us with the central part of the model
tet_tmp = tet.clone().threshold(name='cell_scalars', above=0, below=25)
msh = tet_tmp.tomesh().lineWidth(1).lineColor('w')

# Set the camera position
plt = Plotter()
plt.camera.SetPosition( [513381.314, 6406469.652, 6374.748] )
plt.camera.SetFocalPoint( [505099.133, 6415752.321, -907.462] )
plt.camera.SetViewUp( [-0.4, 0.318, 0.86] )
plt.camera.SetDistance( 14415.028 )
plt.camera.SetClippingRange( [7259.637, 23679.065] )

# Crop the entire mesh using a Box object (which is considered to be a mesh
# object in vedo)
# First build a Box object with its centers and dimensions
cent = [504700, 6416500, -615]
box = Box(pos=cent, size=(3000, 5000, 2430))

size = [3940, 2160]

# Add a slider to control the maximum region number in the mesh that we want
# to show
plt.addSlider2D(slider,
                2, 25,
                value=2,
                pos=([0.1,0.1],
                    [0.4,0.1]),
                title="Maximum region number",)

plt.show(interactive=1).close()

While dragging the slider, I get this error: "TypeError: DestroyTimer argument 1: an integer is required (got type NoneType)".
Any idea? Thanks again!
Xushan

You are trying to do too many things in the callback function. Especially the show() is problematic because it needs to initialize a few things. Better use render() if needed. Also the mesh doesn't need to be "filled" if it's opaque. Consider this:
#!/usr/bin/env python3
#
import numpy as np
from vedo import TetMesh, show, screenshot, settings, buildLUT, Box
from vedo import Plotter, Axes
from vedo.applications import Animation
import time as tm

def slider(widget, event):
    global acts
    region = widget.GetRepresentation().GetValue()
    plt.remove(acts)
    acts = [gen_mesh(region), sb]
    plt.add(acts)

def gen_mesh(max_reg):
    """Generate the mesh based on the maximum region index"""
    # This will get rid of the background Earth unit and air unit in the model
    # which leaves us with the central part of the model
    tet_tmp = tet.clone().threshold(name='cell_scalars', above=0, below=max_reg)

    # So, we now cut the TetMesh object with a mesh (that Box object)
    tet_tmp.cutWithMesh(box, wholeCells=True)

    # And we need to convert it to a mesh object for later plotting
    msh = tet_tmp.tomesh(fill=False).lineWidth(1).lineColor('w')
    msh.cmap(lut, 'cell_scalars', on='cells')
    return msh

# Do some settings
settings.multiSamples = 8
settings.defaultFont = 'Theemim'

# Load a TetMesh object form the vtk file
tet = TetMesh('final_mesh.vtk')

# This will get rid of the background Earth unit and air unit in the model
# which leaves us with the central part of the model
tet_tmp = tet.clone().threshold(name='cell_scalars', above=0, below=25)
msh = tet_tmp.tomesh().lineWidth(1).lineColor('w')

plt = Plotter(size=[2000, 1500])
# Set the camera position
plt.camera.SetPosition( [513381.314, 6406469.652, 6374.748] )
plt.camera.SetFocalPoint( [505099.133, 6415752.321, -907.462] )
plt.camera.SetViewUp( [-0.4, 0.318, 0.86] )
plt.camera.SetDistance( 14415.028 )
plt.camera.SetClippingRange( [7259.637, 23679.065] )

# We need to build a look up table for our color bar, and now it supports
# using category names as labels instead of the numerical values
# This was implemented upon my request
lut_table = [
    # Value, color, alpha, category
    (12.2, 'dodgerblue', 1, 'C1'),
    (15.2, 'skyblue', 1, 'C1-North'),
    (16.2, 'lightgray', 1, 'Overburden'),
    (18.2, 'yellow', 1, 'MFc'),
    (19.2, 'gold', 1, 'MFb'),
    (21.2, 'red', 1, 'PW'),
    (23.2, 'palegreen', 1, 'BSMT1'),
    (25.2, 'green', 1, 'BSMT2'),
]
lut = buildLUT(lut_table)

# Crop the entire mesh using a Box object
# (which is considered to be a mesh object in vedo)
# First build a Box object with its centers and dimensions
cent = [504700, 6416500, -615]
box = Box(pos=cent, size=(3000, 5000, 2430))

# Add a slider to control the maximum region number
plt.addSlider2D(slider,
                2, 25,
                value=25,
                pos=([0.1,0.1],[0.4,0.1]),
                title="Maximum region number",
                delayed=True,
)

msh = gen_mesh(25)
acts = [msh]

msh.addScalarBar3D(
    categories=lut_table,
    pos=(508000, 6416500, -1830),
    title='Units',
    titleSize=1.5,
    sx=100,
    sy=4000,
    titleXOffset=-2,
)
sb = msh.scalarbar # otherwise will be automatically removed

axes = Axes(msh,
            xtitle='Easting (m)',
            ytitle='Northing (m)',
            ztitle='Elevation (m)',
            xLabelSize=0.015,
            xTitlePosition=0.65,
            yTitlePosition=0.65,
            yTitleOffset=-.18,
            yShiftAlongX=1,
            yLabelRotation=90,
            yLabelOffset=-1.6,
            zTitlePosition=0.85,
            zLabelRotation=90,
            axesLineWidth=3,
            xTitleOffset=0.02,
            tipSize=0.,
            xyGrid=True,
            gridLineWidth=5,
)

plt.show(msh, axes).close()

Worked like a charm! It is not very responsive on my laptop but that is probably because of the large mesh size! Thank you very much for your super quick reply!


Make fuel-core && fuel-gql-client optional deps

The abi-gen-macro crate transitively includes fuel-core and fuel-gql-client even though those deps aren't used at all in the codegen process. This was causing circular dependencies when testing abi gen in the fuel-core indexer service.
Ideally, codegen is refactored to live in fuels-core without requiring fuel-core or fuel-gql-client. I attempted this, but it was going to be too much of a major change, and resorted to feature flagging for now (basically the only thing left in fuels-rs after my refactor was the script module and some contract deployment and call functions).

We can talk about where to move the example, but that will affect the infra team's progress so that should be coordinated with @tjsharp1.
The abi gen macros are in a standalone crate used only for codegen of abi types, and these types have no integration or need to depend on fuel-core and fuel-gql-client. It's a lot of overhead to make everyone who wants to be able to codegen their abi types compile a lot of unrelated dependencies like graphql libraries etc.

If it's too ugly I can close the PR and investigate a cleaner refactor. Moving the code-gen to fuels-core might be a pretty significant gutting of fuels-rs though.

Marking as a draft, for now, to allow @digorithm time to investigate other options and prevent someone from accidentally slapping the merge button.

@Voxelot Do you mind closing this one since https://github.com/FuelLabs/fuels-rs/pull/66 was merged?

Gladly, thank you!


Add weight and distance units to LHS and 16A: 163331256

Description
Add weight(lb) and distance(mi) units to Linehaul Transportation(LHS) and Fuel Surcharge-LHS(16A) in the invoice table. This change affects both the TSP and the Office.
Setup
make db_dev_e2e_populate
make server_run
make office_client_run
make tsp_client_run
Check invoice panel for LHS and 16A code and ensure they show weight and milage in the Base quantity column.
Code Review Verification Steps

[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change
The TSP side came along for free
Pivotal story for this change

Screenshots
Office

TSP

Beautiful!


Allow to generate more informative profile file name

The aim of this pull request is to generate a more informative profile file name. This would allow us to identify the endpoint that generates a profile file without the need to open it.
To avoid breaking any existent use case I set this behavior behind the setting SILKY_PYTHON_PROFILER_EXTENDED_FILE_NAME that by default is disabled.
If you think we can change the generated filename without worry we can simply apply this change always without the need to introduce the new settings.

@k4rl85 can you try rebasing this pull request to get the tests to pass?

@albertyw rebased the pr


Make VensStylePPTextures KSP_version "any"

Its functionality is far more dependant on Procedural Parts versions, all of which it will work for currently.

LGTM, merging


Python 2 float/integer compatibility fix

This fixes se_resnext models where math.floor is used to compute layer width. In Python 3 this outputs an integer, but in 2.7 this outputs a float. This fix makes sure an int is always supplied.

Travis: The job exceeded the maximum time limit for jobs, and has been terminated.

How do I run it with more time? It seems stuck downloading pertained weights

@Cadene Thanks ^


Disabler SMG is patheticly bad and needs a buff

Description
It takes too many shots, and too long to stun, since it's way too easy to dodge, and it's best use case is point blank because of the terrible laser spread, where you may as well use an actual disabler where you can quickly and precisely disable someone, or just throw 3 stun batons, it would be more reliable. Sec need more power when dealing with shitters without having to rely on lethals, and the SMG is should fill that gap, but it doesn't.
Screenshots

Additional context
I think that it would be better if, rather then being used to actually stun someone, it could be used to get someone to slow down and maybe drop things they are holding. Or maybe the energy beams should just travel much faster through the air but become thinner?

I think that it would be better if, rather then being used to actually stun someone, it could be used to get someone to slow down and maybe drop things they are holding. Or maybe the energy beams should just travel much faster through the air but become thinner?

Forced drops, especially ranged, are not healthy for the game.
Disabler SMG was made to be inaccurate and not stun easily because otherwise it'd just be a direct upgrade to the disabler, and extremely easy to stun people at a range.

I thought point of science was unlocking direct upgrades or at least upgrades with drawbacks? Though normal disabler can't be crafted I guess... But you are giving up 5 extra grid for sidegrade at best, instead of buying more disablers sec is going to just buy swat crate instead if they get option to.
Then there is of course whole part where DEDICATED stun weaponry like disablers are weaker than rubber/beanbag/tranqs.

I think that it would be better if, rather then being used to actually stun someone, it could be used to get someone to slow down and maybe drop things they are holding. Or maybe the energy beams should just travel much faster through the air but become thinner?

Forced drops, especially ranged, are not healthy for the game.
Disabler SMG was made to be inaccurate and not stun easily because otherwise it'd just be a direct upgrade to the disabler, and extremely easy to stun people at a range.

The disabler SMG should be a direct upgrade, you have to research and fabricate them, where as disablers you get normally more than enough round start. Disabler SMG is a 2x4 (if I recall) and is at most on par with the standard disabler

I like the current state of the disabler SMG. It's extremely funny


scss css url path not updated on minification to reflect nesting

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When the scss is minified, relative paths to images are not updated to reflect the new build path. For example if one of the css files is in /pages/login and the background-image: is "../../assets/img/picture-name.jpg", when it minifies it will still have that same path even though the minified file is one level more shallow.
Expected behavior:
The minified css file should update that relative path depending on how nested the css file is. For example: "../assets/img/picture-name.jpg"
Steps to reproduce:
We are able to replicate with ionic upload

Related code:
background-image: "../../assets/img/picture-name.jpg";

Other information:

We can get around this bug by assigning the image path to a variable in the theme/variables.scss file which is one level more shallow:
$img-bkg: url("../img/background.jpg");
then calling it on the file associated with the page /pages/login/login.scss:
background-image: $img-bkg;
Maybe we're not following best practices for css (not sure what they are really) but either way I think we won't be the only ones to organize our css files this way. (a main one, one for each page, and styles that will always be associated with each component on the component level)
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.0.0
Ionic Framework Version: 2.0.0-rc.3
Ionic CLI Version: 2.1.12
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.45
ios-deploy version: 1.9.0
ios-sim version: 5.0.10
OS: macOS Sierra
Node Version: v6.1.0
Xcode version: Xcode 8.2.1 Build version 8C1002

In this case, paths should take the final build location in to consideration.
I'm open for adding some to app-scripts that would correct this,  possibly some post-css processor. Would you mind opening an issue on the app-scripts repo and link to this?

https://github.com/driftyco/ionic-app-scripts/issues/674


Change time on authentic-theme from AM/PM to 24 hour clock?

Before posting an issue, please search through README.md and closed/opened issues to make sure that the answer to your questions hasn't been answered/discussed already.
Please make sure that you have latest theme (18.49-8) and Webmin (1.850) versions installed.
Provide the following information:

What is your server-side OS and its version? Debian Linux 9
What is your client-side OS, browser and its versions? Chrome or Opera
What are the steps to reproduce the issue. I would like to have your authentic-theme on a 24 hour clock. I have tried to find an answer but no luck. Can you please help?

Kind regards
Budda

Yes, sure, check the theme's settings. It's there.

You could set Full date/time format to value:
MMMM DD, YYYY, H:mm:ss

Yes, that did the trick! Thank you for your help

Hi, Sorry Guys n Dolls, I can find the time setting any more. It seems in the new theme update there is no setting for this. I have looked everywhere in Webmin. How do I change my servers to 24hr clock in the Webmin?
webmin: 1.881 | Ubuntu 18.04 | Authentic Theme 19.09.2
Regards
Budda

Found it DOH!! :/

New release of Webmin will bring the latest theme version that will have much better support for locale. It will be controlled from Webmin/Change Language and Theme.

Yes, I have just seen this is Webmin/Change Language and Theme in a thread you replied to about the same time issue a few days back. I have now changed my clock to 24 hr :)


DBC generation

I was trying out the CAN .dbc generation functionality with the Tinymovr repo, and noticed (as you are probably aware) that it doesn't work - I'm guessing it's unfinished. I started fixing it in the fixDbcGeneration branch in my fork by changing the device.dbc.jinja file so the syntax errors are now gone, but there is still more work needed to get it working it seems. I'm testing it with a simple candump can0 | cantools decode tinymovr.dbc.
It still needs to deal with heartbeat messages, and the all the warnings that cantools spits out with all the getters and setters that have the same endpoint id
WARNING:cantools.database.can.database:Overwriting message 'controller_get_state' with 'controller_set_state' in the frame id to message dictionary because they have identical masked frame ids 0xe.

Thanks for the detailed description. As you mentioned, DBC is still a work in progress, and we plan to add testing for this as well. The main issue I see, which may be worth a protocol revision is that currently we use a single endpoint id for reading and writing (differentiating by the RTR bit). To be fully compliant, this may warrant a revision

I merged your fix (thanks!) and also added tests for generated DBC files using cantons dump. I'll accept the warnings for now, but it needs to be addressed.

Great, looking forward to seeing how it goes in future!


ng test -sm false seems to generate sourcemaps

OS
Mac  OSX Sierra 10.12.3
Versions
@angular/cli: 1.0.0
node: 6.9.1
os: darwin x64
@angular/common: 4.0.0
@angular/compiler: 4.0.0
@angular/core: 4.0.0
@angular/forms: 4.0.0
@angular/http: 4.0.0
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 4.0.0
@angular/platform-browser-dynamic: 4.0.0
@angular/router: 4.0.0
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.0
Repro steps.
ng test -sm false
This should run tests without the source maps. However, we can still debug into source maps.
// As noted by @wardbell, also

This is not intended, it is a bug. Sourcemaps are not being correctly turned off.
@johnpapa this explains why disabling sourcemaps didn't improve test rebuilds anymore.

Good to know I'm not nuts :)

@filipesilva any idea when a minor bump will be released with this? Seems like all the development is going on in 1.1.x while 1.0.0 is left with several bugs that have been fixed a while back.


add units to absolute tolerance

closes #94

Hello @mattldawson! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file interactive/mechanism/species.py:

Line 73:80: E501 line too long (84 > 79 characters)
Line 74:1: E302 expected 2 blank lines, found 1
Line 76:80: E501 line too long (118 > 79 characters)
Line 76:100: E261 at least two spaces before inline comment
Line 79:80: E501 line too long (84 > 79 characters)
Line 80:1: E302 expected 2 blank lines, found 1
Line 82:80: E501 line too long (119 > 79 characters)
Line 82:101: E261 at least two spaces before inline comment


Preparation or improvement of the guide for constitutive equation of the orthotropic layer in the arrangement long fibers and in the rotated arrangement (issue #1031 related)

The goal is to prepare or improve a guide or report that is generated by the following code:
from dynpy.utilities.documents.guides import ResearchProjectGuidelines
ResearchProjectGuidelines()

Minor changes introduced. The code was checked with the following call:
from dynpy.utilities.documents.guides import ResearchProjectGuidelines
ResearchProjectGuidelines()


Improve performance and memory efficiency of agency restart

Scope & Purpose
Make agency restart from persistence more efficient in terms of performance and memory usage, by skipping over irrelevant log entries in the log collection, and using slightly more efficient code.
In addition, this PR removes some other small inefficiencies.

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[x] :fire: Performance improvement
[x] :hammer: Refactoring/simplification
[x] :book: CHANGELOG entry made

Backports:

[x] No backports required

Testing & Verification

[x] This change is a trivial rework / code cleanup without any test coverage.
[x] The behavior in this PR was manually tested
[x] This change is already covered by existing tests, such as agency, mini chaos.

Link to Jenkins PR run:
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13153/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13155/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13160/

Tests blue


Parsing AWS config is  broken in v.0.145.0 for chained assume role sessions (when used via steampipe-postgres-fdw >= v.1.11.5)

Describe the bug
Using steampipe-plugin-aws version 0.145 with an steampipe-postgres-fdw version 1.11.6 breaks the AWS assumeRole session.
Using steampipe-plugin-aws version 0.145.0 with steampipe-postgres-fdw versoin 1.11.4 works as expected.
Be aware: I am talking about the release version 0.145.0 and the git-tag version 0.145.0 (as they are different depending on which steampipe-postgres-fdw release was used to build the steampipe-postgres-aws standalone plugins.
Something between a working steampipe-plugin-aws  release 0.144.0 (as you have published it with steampipe-postgres-fdw 1.11.4) and the version 0.145.0 version (which was published with steamppe-postgres-fdw 1.11.6)  has changed regarding parsing the AWS config file.
Bisecting:
release 0.144 works release 0.145 does not work
continuing....
I am testing this explicitly with:
steampipe_postgres_aws.pg15.linux_amd64 Version v0.145.0
Steampipe version (steampipe -v)
Example: v0.145.0
To reproduce
Use steampipe-plugin-aws 0.144.0 with a working  AWS config file and a steampipe config file
and a Kubernetes Cluster where 2 ENV vars are set:
export AWS_ROLE_ARN=arn:aws:iam::11111111111:role/my_service_account_role
export AWS_WEB_IDENTITY_TOKEN_FILE= /var/run/secrets/eks.amazonaws.com/serviceaccount/token

~/.aws/config
[profile default]
web_identity_token_file = /var/run/secrets/eks.amazonaws.com/serviceaccount/token
role_arn=arn:aws:iam::11111111111:role/my_service_account_role

[profile account_b]
source_profile = default
role_arn=arn:aws:iam::999999999999:role/jump_role

~/.steampipe/aws.spc
connection "aws_account_b" {
  profile = "account_b"
  plugin = "aws"
  regions = [
    "eu-central-1",
  ]
  ignore_error_codes = ["AccessDenied", "AccessDeniedException", "NotAuthorized", "UnauthorizedOperation", "UnrecognizedClientException", "AuthorizationError"]
}

Expected behavior
Querying steampipe should work as in Version 0.144.0  but fails in version 0.145.0
Additional context
My guess is that the aws-go-sdk-v2  was updated in the meantime.
Another guess is that, if the two exported ENV-vars mentioned above are unset, that it could work.
The ENV vars are automatically injected by AWS EKS IRSA.
A sample Go program to simulate the STS assume role behaviour regarind exporting env-vars or not:
main.go
package main

import (
	"context"
	"fmt"
	"log"

	"github.com/aws/aws-sdk-go-v2/aws"
	"github.com/aws/aws-sdk-go-v2/config"
	"github.com/aws/aws-sdk-go-v2/service/sts"
)

func main() {
	cfg, err := config.LoadDefaultConfig(context.TODO())
	if err != nil {
		log.Fatalf("failed to load configuration, %v", err)
	}
	ststCliet := sts.NewFromConfig(cfg)

	id, err := ststCliet.GetCallerIdentity(context.TODO(), nil)
	if err != nil {
		log.Fatalf("failed to get caller GetCallerIdentity, %v", err)
	}
	fmt.Println(aws.ToString(id.Arn))
	fmt.Println(aws.ToString(id.UserId))
	fmt.Println(aws.ToString(id.Account))
}

go.mod
module gitlab.dev.codefactory.sh/it_security/revisor/tokentest

go 1.23.0

require (
	github.com/aws/aws-sdk-go-v2 v1.30.4 // indirect
	github.com/aws/aws-sdk-go-v2/config v1.27.28 // indirect
	github.com/aws/aws-sdk-go-v2/credentials v1.17.28 // indirect
	github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.12 // indirect
	github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.16 // indirect
	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.16 // indirect
	github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
	github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.4 // indirect
	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.18 // indirect
	github.com/aws/aws-sdk-go-v2/service/sso v1.22.5 // indirect
	github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.5 // indirect
	github.com/aws/aws-sdk-go-v2/service/sts v1.30.4 // indirect
	github.com/aws/smithy-go v1.20.4 // indirect
)

References:

https://turbot-community.slack.com/archives/C01UECB59A7/p1724154022124189
https://turbot-community.slack.com/archives/C06MZTFN90E/p1717592237425569?thread_ts=1716801621.122249&cid=C06MZTFN90E

I am still investigating, whether the underlying OS had a change.

The bug is gone if  I use an older postgres-fdw wrapper and use the newest steampipe aws plugin, e.g.do the following:
git clone https://github.com/turbot/steampipe-postgres-fdw.git
cd steampipe-postgres-fdw.git
make standalone plugin="aws"
# this downloads the latest tag, here 0.145.0

Final test revealed:
Using the git tag 1.11.5 of steampipe-postgres-fdw with the steampipe-plugin-aws git:tag 0.145.0 will trigger this bug.
Using git tag 1.11.4 of steampipe-postgres-fdw with the steampipe-plugin-aws git tag: 0.145.0 will NOT trigger this bug.

Example SQL statement, which creates an aws schema with a partiion key by the aws account_id given an aws profile:
# ~/.aws/config
[profile default]
web_identity_token_file = /var/run/secrets/eks.amazonaws.com/serviceaccount/token
role_arn=arn:aws:iam::11111111111:role/my_service_account_role

[profile myaccount_01234567890]
source_profile = default
role_arn=arn:aws:iam::0123467890:role/jump_role

-- create users and roles
CREATE ROLE steampipe_users;
GRANT CONNECT ON DATABASE postgres TO steampipe_users;
GRANT TEMPORARY ON DATABASE postgres TO steampipe_users;

CREATE USER steampipe_user WITH PASSWORD 'steampipe_password';
GRANT steampipe_users TO steampipe_user;

-- load steampipe extension
DROP EXTENSION IF EXISTS steampipe_postgres_aws CASCADE;
CREATE EXTENSION IF NOT EXISTS "steampipe_postgres_aws";

-- create foreign data server and attach to awsprofile as mentioned abovee
DROP SERVER IF EXISTS steampipe_aws_myaccount_01234567890;
CREATE SERVER steampipe_aws_myaccount_01234567890 FOREIGN DATA WRAPPER steampipe_postgres_aws OPTIONS (config 'profile = "myaccount_01234567890"
  regions = [
    "eu-central-1",
    "eu-west-1",
  ]
  ignore_error_codes = ["AccessDenied", "AccessDeniedException", "NotAuthorized", "UnauthorizedOperation", "UnrecognizedClientException", "AuthorizationError"]
');

DROP SCHEMA IF EXISTS aws_myaccount_01234567890 CASCADE;
CREATE SCHEMA aws_myaccount_01234567890;
COMMENT ON SCHEMA aws_myaccount_01234567890 IS 'steampipe aws fdw';
GRANT USAGE ON SCHEMA aws_myaccount_01234567890 TO steampipe_users;
ALTER DEFAULT PRIVILEGES IN SCHEMA aws_myaccount_01234567890 GRANT SELECT ON TABLES TO steampipe_users;
GRANT SELECT ON ALL TABLES IN SCHEMA aws_myaccount_01234567890 TO steampipe_users;
IMPORT FOREIGN SCHEMA aws_myaccount_01234567890 FROM SERVER steampipe_aws_myaccount_01234567890 INTO aws_myaccount_01234567890;

ALTER USER steampipe_user SET search_path = public,aws,aws_myaccount_01234567890;
ALTER USER postgres SET search_path = public,aws,aws_myaccount_01234567890;

DROP SCHEMA IF EXISTS internal_aws CASCADE;
CREATE SCHEMA internal_aws;
COMMENT ON SCHEMA internal_aws IS 'internal_aws steampipe partition';
GRANT USAGE ON SCHEMA internal_aws TO steampipe_users;
ALTER DEFAULT PRIVILEGES IN SCHEMA internal_aws GRANT SELECT ON TABLES TO steampipe_users;
GRANT SELECT ON ALL TABLES IN SCHEMA internal_aws TO steampipe_users;

DROP SCHEMA IF EXISTS aws CASCADE;
CREATE SCHEMA aws;
COMMENT ON SCHEMA aws IS 'aws steampipe partition';
GRANT USAGE ON SCHEMA aws TO steampipe_users;
ALTER DEFAULT PRIVILEGES IN SCHEMA aws GRANT SELECT ON TABLES TO steampipe_users;
GRANT SELECT ON ALL TABLES IN SCHEMA aws TO steampipe_users;

-- cluster partition the aws schema based on each aws account_id
-- import each table schema of the steampipe information_schema
CREATE OR REPLACE FUNCTION create_aws_partition() RETURNS void AS
$$
DECLARE
    aggregate_table_name TEXT;
BEGIN

    FOR aggregate_table_name IN SELECT distinct(foreign_table_name)
                                FROM information_schema.foreign_tables
                                WHERE left(foreign_table_name, 4) = 'aws_'
                                ORDER BY foreign_table_name ASC
        LOOP
            EXECUTE format('DROP VIEW IF EXISTS aws.%I', aggregate_table_name);
            EXECUTE format('DROP TABLE IF EXISTS internal_aws.%I', aggregate_table_name);
            EXECUTE format(
                    'CREATE TABLE internal_aws.%I (LIKE %I.%I) PARTITION BY LIST (sp_connection_name)',
                    aggregate_table_name,
                    'aws_myaccount_01234567890', aggregate_table_name
                    );
            EXECUTE format('CREATE VIEW aws.%I AS SELECT * FROM internal_aws.%I', aggregate_table_name, aggregate_table_name);
        END LOOP;
END
$$ LANGUAGE plpgsql;

-- attach partition to aws schema
CREATE OR REPLACE FUNCTION attach_aws_account(schema_current_name text) RETURNS void AS
$$
DECLARE
    table_name          TEXT;
BEGIN
        FOR table_name IN EXECUTE format(
                'SELECT foreign_table_name FROM information_schema.foreign_tables WHERE foreign_table_schema = ''%I'' ORDER BY foreign_table_name ASC',
                schema_current_name
                                  )
            LOOP
                EXECUTE format(
                        'ALTER TABLE internal_aws.%I ATTACH PARTITION %I.%I FOR VALUES IN (''%I'')',
                        table_name,
                        schema_current_name, table_name, schema_current_name
                        );
            END LOOP;
END
$$ LANGUAGE plpgsql;

-- create an aws schema where the partition key is the aws account_id. This way
-- we can attach multiple AWS accounts with their own AWS config to the general
-- AWS schema and mimic the internal steampipe behaviour to have an aws search path
SELECT create_aws_partition();
-- which searches accross all accounts.

SELECT attach_aws_account('aws_myaccount_01234567890');

To clarify:
only the Postgres standalone AWS fdw fails

@weitzj Could you try building the steampipe-postgres-fdw with the latest released tag(v1.11.8) and the latest plugin version? Let us know if you still see this issue.

I will try.

The issue is fixed and caching seems to work. Thank you!

Version v1.11.8 with the latest steampipe-aws plugin (should be v.0.146.0 I guess)

Fixed in https://github.com/turbot/steampipe-plugin-aws/releases/tag/v0.147.0


Update README for Kong 1.0.x~ user

Thank you for your offering this plugin.
I'm using Kong 1.2.x.
At this version, /apis endpoint has replaced, so I couldn't add plugin.
I examined Kong Admin's API document and notice this change happened at vesion 1.0.x boundary.

Pull Request Test Coverage Report for Build 137

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.296%

Totals

Change from base Build 134:
0.0%

Covered Lines:
130

Relevant Lines:
135

💛  - Coveralls


CSS Issues in Admin

There appears to be some CSS issues for the admin in rc2 (that were also present in at least b2). I'm attaching a screenshot, so you can see what I mean.

I'm sure I've seen this before and it turned out to be due to a misconfigured site setup or similar. @gasman does this ring a bell? ISTR you identified it last time.

@davecranwell We've had similar layout glitches when updating the CSS and failing to run npm run build - is that what you're thinking of? (That wouldn't affect a release package with the CSS prebuilt, of course.)

hmm, no that wasn't it. There's some oddness going on in this screenshot, I think. For example why does the Root have a page status of "LIVE"? The status indicator should be hidden completely if the parent page is root.

@joshourisman Have you altered the Page table in some way to force "Root" to be a true page?
You'll note that in this template we've deliberately hidden the page status tag - shown in your screenshot - for pages which are the Root (is_root) but somehow your Root page is not identified as the actual root.
https://github.com/torchbox/wagtail/blob/master/wagtail/wagtailadmin/templates/wagtailadmin/pages/listing/_list.html#L29
While Root must technically be a page for internal reasons, it should never be a true page with a URL, accessible on the front end. It looks like your Root page might be, which I think is having knock-on effects with other parts of the UI.

I just dropped my Postgres database, and ran migrate to recreate everything from scratch. I still see exactly the same thing. Page.objects.get(id=1).is_root() returns True, as well.

This may be relevant: the template linked to above (wagtailadmin/pages/listing/_list.html) does not exist in the version of Wagtail that I installed (pip install wagtail==1.0rc2), which is not consistent with what's on github for the v1.0rc2 tag.

Yeah, just checked the tarball on PyPI, and the packaged 1.0rc2 is not the same as what's tagged as 1.0rc2 on GitHub.

Ugh, nevermind, my mistake; Octotree had switched me back over to the master branch…

Glad you found the problem :) Does this mean the state of your tree is a result of Octotree? Could we close this issue?

No, sorry; Octotree is a Chrome extension for browsing GitHub repos. Generally awesome, but unreliably supports branches, leading me to unintentionally switch to the master branch when viewing the wagtail code on GitHub, which is why I thought the distributed tarball was different. I'll delete the comments about that stuff, to avoid confusion.
The problem persists with my wagtail install. Running 1.0rc2 with a completely fresh database. Since dropping the database I've done nothing other than ./manage.py migrate and ./manage.py createsuperuser.

It looks to me like the template is just incorrect: https://github.com/torchbox/wagtail/blob/v1.0rc2/wagtail/wagtailadmin/templates/wagtailadmin/pages/list.html#L46-50
That will display the 'live' tag regardless of whether or not the parent page is_root. All that changes is whether or not it's a link.

Ah yes you're right. I thought a recent refactor of the listing template had already addressed this, but that work hasn't made it into rc2. The fixes will be in 1.1 at this rate, currently speculated for release at the end of August.

Hi @joshourisman I believe this has now been fixed with https://github.com/torchbox/wagtail/pull/1611 Please could you have another look?

I was also experiencing this issue and am no longer seeing it on the current master branch.

Thanks for the confirmation @alexgleason!

A little late to the party, but confirming that this fixes the problem for me as well.


Papal integration on Ionic 1 App fails

Description
My paypal integration fails when I click on paypal button from my ionic mobile app. I'm can transact using paypal when I test from laptop. Please see the attached screenshot.

We don't officially support ionic, but if you can figure out the issue this entire module and its dependencies are open source, so please feel free to PR in a fix. Sorry I can't offer you more than that -- my recommendation for now would be to go with the Braintree SDK


Drop ethernet frames not destined for us or broadcast

Closes #150

Tested locally and working, thanks!


Split Frontend and Python Unit tests

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
The split isn't quite necessary but it's a quality of life improvement. Just makes following the different workflows easier.
The real change is: Always run all unit tests. This is a minimum test that should always be run, especially on main (This was being skipped on main pushes that only had the paths-ignore changes.)

Give a summary of what the PR does, explaining any non-trivial design decisions

Other references

I've asked Robert to help me with the required tests. Since I changed the name, it will need to be readjusted before and after this merges


Added the 'spo set' command solving #1070

Added the 'spo set' command solving #1070

Coverage remained the same at 100.0% when pulling c554bedf9a2567cac6a35e4e2d561ed2b7be1b2d on waldekmastykarz:spo-set into 654f2e62750a144cf3556f69577a15c4197b78aa on pnp:dev.

So this is interesting, because this is the code we've been using for auth since the beginning, so it would mean that you can't persist the URL at all. Have you checked in the credential store if the URL was updated (or using the spo get command now that we have it ;) )?

When I added a console log to the store get method, I received the spourl that was automatically resolved when you do o365 login so I assume that the spo set was not able store it at all.

Hmm, but if this logic didn't work, then auth in non-immersive mode wouldn't work, because it would require you to login every time. 🤔

I found the issue and it was isolated to the new spo set command. The command would exit before the exe to reset/set the password could finish which is why you noticed the issue.

Merged manually. Thanks!


[Bug Report] When I use v-if to switch column, the custom header  becomes confused

Element UI version
2.4.11
OS/Browsers version
windows 10 / chrome 70.0.3538.110
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/z1900/bq20a4nm/17/
Steps to reproduce
点击 toggle 按钮
What is Expected?
根据 showAddress 切换 table-column
What is actually happening?
自定义表头渲染出错

添加一个 key https://jsfiddle.net/gxk89f4u/

可以了  非常感谢 @ziyoung


chore: Refactor consumer group code

Signed-off-by: hemahg<EMAIL_ADDRESS>What this PR does / why we need it:

Refactor consumer group code

Which issue(s) this PR fixes

Replace this comment with references to related issues.
e.g. fixes #<issue number>

Verification steps

Attach a screenshot of the output.
guidance on how to go the particular story.
e.g. point to the story with a text breadcrumb, something like "components > <component name> > <story name>”

Is there any work left / what's next :

Replace this comment with pending items that need to be covered in this PR or some pending items you are planning to do in the future PR.

Special notes for your reviewer:

Closing this PR in favor of [69]https://github.com/redhat-developer/rhosak-ui/pull/69


Test alignment to hg38

Alignment succeeded on HG38 (as expected).   Going to open a new ticket to try and test-run the exome variant pipeline with hg38 inputs trying several different combinations in preparation for Adam Ewing's validation bams.


cyclonedxxml predicate type

Summary

This adds to ability to unmarshal xml-formatted CycloneDX SBOMs and add them as attestation payloads.  Previous it was a little ambiguous as to which file format was expected for cyclonedx predicate types, and this removes that ambiguity.
Closes #2230
Release Note
Updates available cosign attest --type options to include cyclonedxxml.  --type cyclonedx is unaffected and still expect a JSON formatted CycloneDX SBOM.

Documentation

Overall it is LGTM, thx @chaospuppy, could you please rebase from main?

Looks like I forgot to sign off on the last commit, I can go ahead and sign off and repush if that's preferable.

@hectorj2f somewhere in here make sense?

Yep, the e2e tests would be a good place, or adding unit tests.

Codecov Report

Merging #2231 (3eb9652) into main (c1322bc) will increase coverage by 0.44%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
+ Coverage   28.57%   29.02%   +0.44%
==========================================
  Files         131      131
  Lines        7852     7872      +20
==========================================
+ Hits         2244     2285      +41
+ Misses       5302     5275      -27
- Partials      306      312       +6

Impacted Files
Coverage Δ

cmd/cosign/cli/options/predicate.go
0.00% <0.00%> (ø)

pkg/cosign/tlog.go
37.75% <0.00%> (-0.80%)
:arrow_down:

cmd/cosign/cli/verify/verify_blob.go
45.09% <0.00%> (-0.17%)
:arrow_down:

...ernal/pkg/cosign/fulcio/fulcioroots/fulcioroots.go
57.77% <0.00%> (+3.01%)
:arrow_up:

cmd/cosign/cli/verify/verify.go
19.34% <0.00%> (+13.37%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chaospuppy  lgtm, but you need to update the cli docs.

Yep, the e2e tests would be a good place, or adding unit tests.

I'd be happy to add some unit tests to some commands going forward, when I have some more time!

It looks like the docsign failed because of some whitespace I removed after --replace in the cli docs, and then the "Test attest" check failed for dubious reasons.


AEC Filter

Maybe for the next project as opensource AI would really benefit from some new low load SoC based filter methods :)

Interesting; I'd mainly been thinking of mobile, tablet and desktop ecosystems when I wrote this, but I can see how filters will play an increasingly interesting role on embedded devices... (Particularly now that machine learning techniques are starting to be accessible for SOCs!)
Thanks for the suggestion; I'll mull it over.

Yeah if you ever fancy a visit take a look at https://rhasspy.readthedocs.io/en/latest/ :)
I have been wondering for a while how optimised are the 2 main AEC routines for SoC and can they be improved but it takes some real lean code and far too much math for the likes of me.
Opensource is sort of locked out on various levels due to the better algs being harware or licence based.
Thanks for the reply.
Stuart


Fix order of ":" operator

Currently the : operator seems to evaluate expressions from right to left, rather than left to right as expected.

The order was fine. Issue was with the nodes being executed multiple times


appliance/postgresql: Don’t log transaction errors

The default log level is ERROR which logs transaction errors to the pg log. These errors are also provided to the client, which can log them if they are relevant. Log messages that admins care about will have level of LOG or higher.
Closes #2739

LGTM

LGTM


Add missing env variables from adapter

While writing developer docs I noticed that the Hubot Adapter implements a few environment variables that aren't used in the SDK. Namely:

ROCKETCHAT_USER
ROCKETCHAT_PASSWORD
ROCKETCHAT_ROOM
ROCKETCHAT_USESSL

These should all be carried over to the SDK so bots in other frameworks can set them in a consistent way. Ideally, the only additional environment variables required in the adapter should be for behaviour specific to that framework.

In dist/utils/config.js:
// The Bot user, will attempt to login and run methods in tests
exports.botUser = {
email: 'bot@localhost',
name: 'Bot',
password: process.env.ROCKETCHAT_PASSWORD || 'pass',
username: process.env.ROCKETCHAT_USER || 'bot',
active: true,
roles: ['bot'],
joinDefaultChannels: true,
requirePasswordChange: false,
sendWelcomeEmail: false,
verified: true
};
This code solve this issue about ROCKETCHAT_USER and ROCKETCHAT_PASSWORD?

No the utils methods are only used in tests. Don't worry about it though, I've actually got a fix I'm about to push.


How to check when a job last ran from within the job funciton?

We want to run a function periodically, that checks for recent changes from a remote host. The function should only request changes since the last time it ran, so that we don't get back unnecessary data.
How can a SyncedCron job look for the last time it ran (e.g. create a lastRanAt variable)?
Example
One possible example would resemble a collection helper:
SyncedCron.add({
  name: 'Do something',
  schedule: function(parser) {
    // parser is a later.parse object
    return parser.text('every 2 hours');
  },
  job: function() {
   // Get reference to current cron job
   const cronJob = this;

  // Get date cron job last ran
  const lastRun = cronJob.lastRun();
  }
});

Possible solution
SyncedCron.add({
  name: 'Do something',
  schedule: function(parser) {
    // parser is a later.parse object
    return parser.text('every 2 hours');
  },
  job: function() {
    // Get the log item for the last time this job was run
    const lastRun = cronHistory.find({
      name: "Do something"
    },
    {
      sort: {
        finishedAt: -1
      },
      limit: 1
    }).fetch();

    console.log(lastRun);
  }
});

Use Session to create a last run at, or like you suggest use a collection as a reacrtive object and insert / find to keep track.


Arrow3d should support batches

The python API almost supports batches but still does a reshape that assumes a single arrow:
instanced["rerun.arrow3d"] = Arrow3DArray.from_numpy(origin.reshape(1, 3), vector.reshape(1, 3))

Additionally after fixing that problem the renderer only renders the first arrow in the batch.

Is this fixed?

It is fixed in the new api where batches work for everything. Closing off since we don't have an ask for this on the old api.


Unable to download

Unable to download WPN-XM
from: http://wpn-xm.org/downloads.php
Version:  WPNXM-0.8.6-Full-Setup-php56-w64.exe
it fail everytime

Version: WPNXM-0.8.6-Full-Setup-php56-w64.exe it fail everytime
Please try the direct download link:
https://github.com/WPN-XM/WPN-XM/releases/download/v0.8.6/WPNXM-0.8.6-Full-Setup-php56-w64.exe

thank you

You are welcome


error TS2724: no exported member named 'ConstArgumentNode'

Describe the bug

Create a new node/typescript project.
npm install @amplitude/ampli v1.35.0.

note that ampli depends on graphql ^v15.4.0. Actual version in my lock file was v15.9.0.

npm install @urql/core v5.0.8, which depends on @0no-co/graphql.web (my lock file showed v1.0.11).
create an index.ts that imports anything from @urql/core

Result: Typescript compilation errors in the form:
./../node_modules/@0no-co/graphql.web/dist/graphql.web.d.ts:456:11 - error TS2724: '"/home/user/app/node_modules/graphql/index"' has no exported member named 'ConstArgumentNode'. Did you mean 'ArgumentNode'?

456   GraphQL.ConstArgumentNode,
              ~~~~~~~~~~~~~~~~~

I actually get 6 errors, for ConstArgumentNode, ConstValueNode, ConstListValueNode, ConstObjectValueNode, ConstObjectFieldNode, and ConstDirectiveNode.
I suspect this is due to the 0no-co/graphql.web peerDependency for versions 14 - 16. It seems v15.9.0, at least, is missing some types that 0no-co/graphql.web depends on.
Workaround: explicitly install latest graphql (v16.9.0).
Reproduction
https://github.com/danbrakeley/0no-co-graphql.web-peer-dep-bug
Package version

@urql/core: v5.0.8
@0no-co/graphql.web: v1.0.11

Validations

[X] I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
[X] Follow our Code of Conduct

This is expected, a ConstArgumentNode is not part of the execution language, it's part of the SchemaDefinition language. This is an implementation for the web which makes it so that we focus on the execution language. Why do you need parts of the Schema Definition language? If you need them you can alias to graphql or graphql-web-lite

seconding the above. We need to keep peer dependencies somewhat open for many dependency chains where GraphQL 15 still occurs.
However, in application code and code bases directly depending on our dependency, there shouldn't be any reason to still depend on GraphQL 15.
I don't know what Amplitude is but please report this to them. It doesn't seem like they've upgraded their CLI's dependencies then in 3+(?) years?
Another solution is to install this CLI globally or separately instead,
or to make sure that your root dependency of graphql is set to ^16, to prevent your package manager of finding the smaller range. This should definitely resolve this ✌


Nothing happens

Although I have a tailwind.config.js in my project, Tailwind config viewer is just empty. I also do not get any error message. Is it because I am having the code in Windows WSL?

Me too, any updates?

same on MacOS 13.2.1 and latest version of VSC

It was a build error. It should be fixed now. Please update to version 0.0.3.

Thanks a lot! It works again for me.

Great. Please rate the extension on marketplace if you liked it.


[BEAM-14396] Bump httplib2 upper bound.

Seeing nothing concerning in changelog:   https://github.com/httplib2/httplib2/pull/200

R: @kennknowles

LGTM


Reimplement recovery and congestion control

This change replaces the CC and pacing algorithms using the C++ google/quiche implementations rewritten in Rust.
In addition it improves on the general recovery as well.
This is essentially the same as #1490 only split into more incremental commits for easier review.

needs a rebase

needs a rebase

rebased, and fixed a few issues in the process


[dev] goreleaser deployment failing on tag

Reference here: https://travis-ci.org/intel/multus-cni/jobs/611917037#L5077
This causes subsequent deployments to fail

As of following message, goreleaser failed to upload due to 'already exist', I guess.
   ⨯ release failed after 178.29s error=GitHub/GitLab/Gitea Releases: failed to publish artifacts: failed to upload multus-cni_3.4_linux_386.tar.gz after 10 retries: POST https://uploads.github.com/repos/intel/multus-cni/releases/21477410/assets?name=multus-cni_3.4_linux_386.tar.gz: 422 Validation Failed [{Resource:ReleaseAsset Field:name Code:already_exists Message:}]

I found that travis tries to add artifacts twice (one is TARGET=ppc and another is TARGET=amd64). #421 proposes to fix the issue (suppress ppc's gorelease invocation).


Local Pool (manager) with Remote Workers + Configurable Worker collection

This PR should really be 2 as the title suggest. However, it was easier for me the to create it as single one. - Apologies! - I just wanted to get your thoughts on the changes first and find out whether you see these extensions useful. - I'm happy to take this further, e.g.: split the PR, etc.
Remote Workers
I use poolboy at work and needed to create a pool of processes similar to the rpc module implementation in Erlang/OTP. - rpc (or rex) is a single process, I needed a pool of them. - This led me to extend poolboy, so that (local) workers could be started by a supervisor on a remote node.
Worker Collection
In situations, where the worker is non-blocking, the pool performs better if the checkout, checkin mechanism is not used. However, it's still a good idea to distribute the work-load between workers, e.g.: simply relying on random distribution. - This led me to consider random-access data-structures, like array and tuple for the collection of workers. - I've added a module: poolboy_collection that encapsulates the data-structure, in which the workers are stored.

There's a lot of changes here and I'm not sure when I'll have time to review this :/ I will try to find some time though.

Hi @Vagabond, you are right this has become a mess. Sorry about that. I would be happy to rework these changes into manageable chunks (PRs). Please let me know if that would actually work for you ;)

Hi again @Vagabond, I've started on spitting this PR into manageable pieces.
Here's the first chunk: https://github.com/devinus/poolboy/pull/140 - Still somewhat large but I think it's manageable.
Thanks!


Q: Is it possible to use redux-style state management?

I'm curious is it possible with Laminar to have whole app state in one big immutable object, like in Redux or ClojureScript's re-frame?
For example, I have something like:
case class Todo(...)
case class User(...)
case class AppState(user: User, todos: Seq[Todo])

As far as I can understand to build view layer for this app-state we need something like (sorry, don't know well Laminar API, so I use pseudo-code):
def appView(state: ReactiveStream[State]): ReactiveNode[Div] = {
  // .. here we call child components userView(user: ReactiveStream[User])
  //    and todoView(todo: ReactiveStream[Todo]) ...
}

Does it have any sense? If not, what's the recommended way to manage state with event-stream based frameworks?
Btw, thanks for your great work! No doubts we need Scala-"native" solutions to cope with UI issues and I found Laminar and Outwatch very promising! :+1:

Hi,
First of all, Laminar docs in master are currently out of date. I will update them in the coming days. The code is v0.3-SNAPSHOT, whereas the docs are for v0.2. Lots of changes since then, but most notably we now use Airstream instead of XStream.js
Airstream has first class support not only for streams, but also for State and Signal-s. You should read Airstream docs (that are in fact up to date) about important differences between State and Signal.
You can imitate redux by having an instance of Var (State) while passing down things like centralVar.map(_.user).toSignal for reading and centralVar.writer.map(newUser => centralVar.now().copy(user = newUser)) for updating. I might be off with the writer.map syntax a bit – see Airstream docs if this doesn't work.
However, I'm not sure if I would recommend that. If you have a global user variable that you need to read / write, you can just define it somewhere as a separate Var and pass its signal to components that need it. And if you have some state that is local to your component, just define it inside of your component. For example, while user might need to be global because it's used from multiple unrelated components, you might want to contain todos to the one component that uses that data instead of making it global, assuming you don't need to share between multiple unrelated components.
The big idea in Laminar is to use simple language-level (and general FRP) solutions instead of frameworks.
But do take all this with a grain of salt as I myself didn't have a chance to write a lot of Laminar code yet, and it's pretty flexible so multiple approaches are possible. You might want to check out https://github.com/raquo/laminar-examples, it is currently the only public Laminar code. It uses v0.3-SNAPSHOT so you can use it as a (lame) reference.

Thank you for the explanation, I'll check laminar-examples.
Regarding centralVar, does it mean that every update of a nested object inside centralVar will follow to re-rendering the whole DOM tree? For example, if I update user name, will todo list be re-rendered?

No, normally extraneous re-renders are not needed at all. In your code you will have code like something <-- someSignal. That means that when someSignal emits a new value, something will be updated in the DOM, nothing more.
In your user component you will probably have something like div(child.text <-- usernameSignal) where usernameSignal is derived from centralVar.  So when usernameSignal updates, a new DOM text node will be created and inserted into that div instead of the previous text node.
I assume nothing in the todo list depends on the username, so its DOM will not be touched at all when it updates.
The thing to avoid in Laminar is this pattern: div(child <-- usernameSignal.map(username => span(username))). In that case, a new span element will be created every time usernameSignal updates. That is not a big deal in my contrived example because username updates are probably very rare, and this span is just one element, but if it was a bigger component and/or the updates were coming in more often that would be really inefficient.

Importantly, Airstream's State does not emit a new value if it is equal to its previous value. So you should make your components depend on individual chunks of centralVar (e.g. centralVar.user) rather than on the centralVar itself, because the value of centralVar itself will change with every update to any of centralVar's contents because of immutability, but the individual chunks will only change when they themselves (or their children) change.
Note that Signal-s don't have the same de-duplication behaviour built-in. I wasn't sure about that, and I might add it later. For now you'll need to .map centralVar first to narrow it down, and only then convert it to a Signal, otherwise you'll get more DOM updates than needed.

Importantly, Airstream's State does not emit a new value if it is equal to its previous value.

Cool, it's clear now! And what about sequences: if I add one more todo to the rather big list of todos, does it exist some way to effectively re-render DOM nodes for the list? If I understand correctly, in such cases we need virtual DOM as an optimisation technique, doesn't we?

Just released v0.3 together with documentation explaining the children stuff.
I'll keep this issue open because I want to document the centralized state management pattern eventually.

Similar question and answer about Diode: https://gitter.im/Laminar_/Lobby?at=5c54ea70f04ef00644c52a21

I am curious if it is practical to use Laminar with Diode? I have an app with an existing (largish) diode model that I would love to try to implement with Laminar instead of one of the many React.js wrappers out there.

State management is now sufficiently documented under Var in Airstream docs I think.


Feature request: live inject SCSS

It would be really nice if that was implemented in this package, instead of having to use a third party task runner like gulp to compile scss externally from meteor, and then inject styles.
If you ever worked with browser-sync, everything else than style injection feels just wrong.
And I'd love to start everything with just meteor.
Thanks for considering (or teach me better, if it's already possible?)

That would be a task for the meteor build tool instead of this package. We only compile scss to css for the files meteor tool requests. How this ends up in the application is out of our control.


UAI: Data Changes

Task Description
This involves modifying the existing data structures to accommodate changes regarding the new UAI (indicators and modals).

[ ] Modify Data Structures (DS) to add Visual Indicator Flag
[ ] UAI configuration Based Changes

ETA
1 DAY

Verified this issue on keeper app v 1.1.12(309)


multigtfs df attribute row sort

          Also applies to summarise_trips, row and column sort should be consistent with that of GtfsInstance:

row sort on day is: ['friday', 'friday', 'monday', 'monday', 'saturday', 'saturday', 'sunday', 'sunday', 'thursday', 'thursday', 'tuesday', 'tuesday', 'wednesday', 'wednesday']
column sort is: ['day', 'route_type', 'route_count_max', 'route_count_mean', 'route_count_median', 'route_count_min']
GtfsInstance column sort is ['day', 'route_count_max', 'route_count_mean', 'route_count_median', 'route_count_min', 'route_type']
Originally posted by @r-leyshon in https://github.com/datasciencecampus/transport-network-performance/pull/207#discussion_r1410359868

weekday row sort has been updated. Sort on route_type and column sort requires implementing:
GTFS.summarise_routes()

GTFS.summarise_trips()

Column sort is inconsistent.


Documentation very unclear: which MAC to add? How to add multiple?

Just got 4 switchbot curtains and a hub mini. How do I add this properly? The MAC-addresses of the curtains themselves are BLE (Bluetooth) devices and my HA-setup doesn't have BLE. The hub however has a WiFi MAC-address.
How to properly set this up? The documentation is very very sparse and unclear about this.

I had the same issues. But I've discovered that the integration communicates directly to the curtains without the hub over BLE. I have sold my hub because I didn't need it after all...
I've bought a Bluetooth dongle for my setup (I am using a Odroid N2+). With this integrations and the following configuration I was able to get everything to work (I have 3 curtains):
cover:
  - platform: switchbot-curtain
    mac: "AA:BB:CC:DD:EE:FF" # For example
    name: "Curtain 1"
  - platform: switchbot-curtain
    mac: "AA:BB:CC:DD:EE:FF"
    name: "Curtain 2"
  - platform: switchbot-curtain
    mac: "AA:BB:CC:DD:EE:FF"
    name: "Curtain 3"

You need the BLE MAC address from curtain, found in SB app >  Device > Settings > '...' > BLE MAC.

I see. That's a pity really, I would rather use the hub than add an extra USB-device to my Raspberry Pi setup. It's already using a powered USB-hub but that's reaching it's limit since I have a SSD, Z-Wave-stick and Zigbee-stick attached to it.
It would be great, IMHO, if the integration could use the hub instead and query that for the connected curtains and add those automatically to HA....

I see. That's a pity really, I would rather use the hub than add an extra USB-device to my Raspberry Pi setup. It's already using a powered USB-hub but that's reaching it's limit since I have a SSD, Z-Wave-stick and Zigbee-stick attached to it.
It would be great, IMHO, if the integration could use the hub instead and query that for the connected curtains and add those automatically to HA....

HA's philosophy is to control the device locally (where it's possible) and use cloud if there's no other option. The reason is simple: being controlled locally, you have the power and you aren't depend on a cloud based solution (for instance: no internet, no control :) ).

Ok, I got a simple BLE dongle and managed to scan for devices using this in my configuration.yaml since hcitool is not available through Hass.io setup on a Raspberry pi:
`device_tracker:

platform: bluetooth_le_tracker
track_new_devices: true`

The the new devices pop up in /config/known_devices.yaml, or you can look the MAC-address up in the SwitchBot App on your phone, which I did. Then add them like stated above to the configuration.yaml like this:
`cover:

platform: switchbot-curtain
mac: EA:0E:56:C9:A5:2B
name: "Gordijn Woonkamer Zijkant"
platform: switchbot-curtain
mac: FD:D4:98:02:53:4A
name: "Gordijn Woonkamer Voor"`

It works now, sweet!

I'm running HA in a virtual machine inside a server far away from the curtains.  I do have the Switchbot Hub Mini though. I am able to control the curtains through the app via the hub mini without being on WiFi/Bluetooth.  Is there any way to get the Hub working with this integration?

Integration with hub is not possible ...


@conda-forge-admin please rerender

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/multiprocessing-logging-feedstock#6.


Show file on navigation

When navigating in the file tree only / arrows are recognised.
I'd suggest / should also be recognised

: go up to parent directory
 go down into children of current directory, either to first item in that dir, or to previous item in that dir (if user was there before)

Also - nodes are highlighted in directory tree when using /, but the file viewer is not updated. When I hit  to (e.g.) move to the file fred.py in directory tree, then I should also see text of fred.py on the right hand side

I like the navigating through the directory tree ideas - I'd have to find a way to further customize the Textual Directory Tree Widget to handle something like that.
For the code block to render a new code file, the Textual app sends a message, FileSelected. However there isn't a message sent on hover or when selecting with the arrow keys, that's possible but might be difficult to ratelimit for fast movement of a mouse. Instead you can use the ENTER key to "select" the file when hovered over it, would that work for you?

ENTER key works fine for me, especially given fast navigation with arrow keys


Fixing Tests

The tests are not running, there many errors, happening in Pharo 6 and 7.

I'm working on it.
The main problem I have is that I have some functional tests based on Seaside dependencies modelization. It takes too much time to update regarding Cargo model changes. I decided to drop this example and use PharoLauncher instead (less dependencies, better for testing). To achieve that, I need to finish metacello support also


[Feature]: Fire Texture Should indicate remaining burn time

Describe the Feature
So basically this mod is already huge on what it does for campfires. But in my opinion there's just one thing missing, which's having different textures for each certain "level"/burn time thats remaining. For example, you can divide the total burn time by 4 and on each 1/4 thats increased/lessened it'll update the textures to a lower ammount of fire yk, simmilarly to the different fire levels in this game called Don't Starve:

Thanks for your idea! It was already mentioned in #29 :) I will look into that, when I have time. :)

Thanks for your idea! It was already mentioned in #29 :) I will look into that, when I have time. :)

Sorry for the duplicate XD


Npe2 update

Updating our plugin to use npe2 from npe1

looks like python 3.7 is no longer supported with npe2 + the newer versions of napari- fixing


accessibility: Model messages as a list with items, each representing a single message.

Previously, messages were a string of disconnected regions. Modeling them as a list brings several benefits:

Quickly jump to the message list by using a screen reader's list navigation hotkey.
Quickly jump between messages by using a screen reader's list item navigation hotkey.
Quickly jump to the beginning or end of message lists in screen readers that support it.

@ndarilek just so I understand how this works, is the idea that you can:
(1) Just between recipient regions using the screen reader navigation
(2) Iterate between individual messages in using some other approach?
The context here that a message_group (and in particular the recipient_row block) is not a single message, it's a block of potentially dozens of messages all with the same recipient, so if you're really intending to jump between individual messages, you want to either (1) use the .selected_row stuff I mentioned (which already is super-well integrated with pageup/pagedown/up/down/home/end/etc.) or maybe have e.g. both the recipient header and the individual messages be list items.

@timabbott Thanks, such explanations are really helpful when coming up with a way to represent this.
@ndarilek As far as I can judge this right now, it seems OK to group those messages. However, without really using this, it's hard to decide. Given the explanation of Tim, will we end up with 1 list item for a whole PM conversation? That seems not wat we want?

Thanks, I think all this sounds reasonable. I'll look into moving the
ARIA roles around a bit and will push an update soon.

@ndarilek just checking -- does the push you did recently cover those changes?
(A note on GitHub: It doesn't send any sort of notification when someone pushes a new version of a commit, so one should always post a comment when you have new changes ready for someone to look at)

Got it, thanks for the explanation, I don't often accept PRs from folks
that need lots of revisions so I didn't want to be spammy.
Yeah, I think the change should address your comments. I found each
message_row instance and added a listitem role.
In my screen reader, I can now use i and I to jump forward and
backward through individual messages. I can also use < to jump to the
beginning of the message list, and I think . to jump to the end. Much
nicer navigation experience IMO.

Merged, thanks @ndarilek!
We may find that once we integrate the selected_row feature for accessibility (aka our existing keyboard navigation) we end up wanting to change this to have a different setup (those are Up, Down, Home, End, in the normal worlld).  We just need to make the selected message relate to the accessibility data in some fashion (I don't know enough about accessibility to figure out what the right way to do that is).
But I think this will help a lot with our ability to iterate on other aspects of the markup, so definitely progress.  Thanks again for the contribution!

(I expect to have this on chat.zulip.org sometime in the next few hours)


fix: CI Artifact Download Timeout

Fixes #12452
Motivation
The V4 actions seem to have a high tendency to timeout when downloading artifacts.
https://github.com/actions/download-artifact/issues/249
Modifications

Downgrade actions/download-artifact and actions/upload-artifact from v4 to v3 to fix artifact download timeout issues. Add both download-artifact and upload-artifact to dependabot ignore dependency.

Verification

Submit a few empty commits to verify frequency of failures is reduced.

Seems to have the reduced frequency of error behavior as expected. Good to go if tests succeed.


Add better support for ETH / Solidity contracts

Added https://github.com/loomnetwork/vue-block-explorer/pull/20


How to get im_h_y from im_h?

I want to calculate PSNR on Y channel.
I have got im_gt_y and im_b_y through the mat format files.
im_gt_y = sio.loadmat("output/" + opt.image + ".mat")['im_gt']
im_b_y = sio.loadmat("output/" + opt.image + ".mat")['im_b']

im_gt_y = im_gt_y.astype(float)
im_b_y = im_b_y.astype(float)

psnr_bicubic = PSNR(im_gt_y, im_b_y, shave_border=opt.scale)

But I have some trouble in getting im_h_y from im_h
im_h_y = im_h[:,:,0].astype(float)
psnr_predicted = PSNR(im_gt_y, im_h_y, shave_border=opt.scale)

The result was not right.
I tried to transform the im_h to YCbCr by Image
im_h_ycbcr = np.array(Image.fromarray(im_h, "RGB").convert("YCbCr"))
im_h_y = im_h_ycbcr[0,:,:]
psnr_predicted = PSNR(im_gt_y, im_h_y, shave_border=opt.scale)

It still doesn't work.
Can you give me some advice here.

@yuanshuai220 please also load im_h_y from mat file after converting rgb images into ycbcr images in matlab. PIL library cannot give you the best performance in calculating PSNR.

@yuanshuai220 ，Hi，I don't know why it needs so much memory when test and the train is normal. Have you ever had this problem?
::
RuntimeError: cuda runtime error (2) : out of memory at /opt/conda/conda-bld/pytorch_1501969512886/work/pytorch-0.1.12/torch/lib/THC/generic/THCStorage.cu:66


Fix behavior of PM list with deactivated users

Fixes #13766
Follow-up PR #13795
Rebase the PR and tested properly.

Allowing deactivated users pill in the compose box. thus prevents pm-list from collapsing.
Showing the deactivated user pill in red.
Showing compose error with deactivated user detail.

Testing plan:
Tested properly with node tests. Also tested manually as mentioned in the issue.
GIFs or screenshots:
When you try to send a message to a deactivated user.

@timabbott I have updated the PR with the changes as suggested. Check this now.

@timabbott I have updated the PR as suggested by you. Moved the logic in user_pills.js. Also, updated the tests in the 2nd commit for feature.
This is now ready for review.

@timabbott Updated and commented above.

@timabbott I have update the PR and added the commit where title attribute is added to input_pill.hbs.

I ended up dropping the last/title commit when merging, after moving the message "You can't send to deactivated users" to be what happens when you try to send a message; I think with that, the situation is pretty clear (as the red highlighting suggests having that user as a recipient is an error).
Merged, thanks @Signior-X and @m-e-l-u-h-a-n!  I like the way the deactivated tag is implemented here a lot.


Bump dependencies

Fixes #2499.
Changelog Entry

Bumping dependencies, by @compulim, in PR #2500

*<EMAIL_ADDRESS>bundle<EMAIL_ADDRESS>component<EMAIL_ADDRESS>

Description
Bump dependencies for the following packages:

<EMAIL_ADDRESS>
https://github.com/microsoft/BotFramework-DirectLineJS/pull/240

<EMAIL_ADDRESS>
https://github.com/spyip/react-film/pull/27
https://github.com/spyip/react-film/pull/30

<EMAIL_ADDRESS>
https://github.com/compulim/web-speech-cognitive-services/pull/71
https://github.com/compulim/web-speech-cognitive-services/pull/72
https://github.com/compulim/web-speech-cognitive-services/pull/74
https://github.com/compulim/web-speech-cognitive-services/pull/75
https://github.com/compulim/web-speech-cognitive-services/pull/76

Specific Changes
(As above)

[ ] Testing Added

Coverage remained the same at 65.299% when pulling deb2a4637d1535c1467f96ec189efeac3b574885 on bump-deps into 86714de52ef3399ccbac635463d45a25d1f211ed on master.


Warn about duplicated devices after overriding their types

For noobs like me to HomeBridge this can help.

Sorry for the delay, thank you for this.


feat: add not found app screen

@michaelfurutin Also, let's make an apps selector in the Layout possible to open, so users can choose from the existing apps in the list.


Dynamic imports throws an exception

Exception message:

Invoke() takes exactly 4 arguments (1 given)

Code for reproducing the error
from importlib import import_module
globals()['defaultdict'] = getattr(import_module('collections'), 'defaultdict')
print defaultdict
# Ausgabe: <type '_collections.defaultdict'>

I observed similar issue when importing unittest .
Exception is thrown in IronPythonLanguage.ResolveImport delegate when calling object builtin = IronPython.Modules.Builtin.__import__(context, moduleName, globals, locals, fromlist, -1);
Wen commented out scope.SetVariable("__import__", new ImportDelegate(ResolveImport)); in 'IronPythonLanguage.CreateEngine` it works without exception and IronPython resolver is able to resolve imports properly

I'll take a look at it today

I used project added in this branch https://github.com/AnritsuSolutionsSK/simplic-dlr/tree/Python_StdLib_example
When issue solved this could be added as next example how to incorporate python stdlib.

Good point. Would you like to add it with a PR?

I expected to add it as PR when issue resolved but I can add it, it is easy to close without merging.


How to verify signatures in public Rekor

Question
Hi team:  I want to verify the signature for the alpine image shown @ https://hub.docker.com/layers/library/alpine/latest/images/sha256-c5c5fda71656f28e49ac9c5416b3643eaa6a108a8093151d6d1afc9463be8e33?context=explore.  I am able to curl to public rekor and find uuids.  I am able to 'cosign verify' my companies' registry images.  I've tried many cosign verify parameter combinations for the public rekor but no luck.  The command always returns:
**Warning** Missing fallback target fulcio.crt.pem, skipping **Warning** Missing fallback target fulcio_intermediate_v1.crt.pem, skipping Error: no matching signatures main.go:69: error during command execution: no matching signatures
Pls provide, or point me to doc'n with, a working 'cosign verify' command for the alpine image.  If it helps, the docker pull command is 'docker pull alpine'.  If, by chance, the result above is correct, please choose an alternate image so I can see a working 'cosign verify' example using the public rekor.
Thanks.
Michael

Take a look at https://docs.sigstore.dev/verifying/verify/. If you have more questions, please post on Sigstore's cosign slack channel.
I would also double check that Alpine has a Sigstore signature attached. https://docs.sigstore.dev/signing/signing_with_containers/ has documentation for signing containers.


Abhinav

I have made changes to gitpub/gitpub.py using graphql4 instead of rest api to get data of the user.
I'm using by personal acces token as an environment variable by using: export "OAUTH_KEY"="Basic <your_oauth_key>" in the terminal before executing my code.
One problem is that that I could not find a way to get all the repositories of the user ,as far as I know we cannot access more than 100 repositories at a time, so if a user has less then 100 repos ,all of them will be loaded otherwise only first 100.

@abhinavsirohi - Nice work! I will go through it tonight and add my reviews there.
Also, make necessary changes in the tests too or else travis tests won't pass.
It would be good if you can make a list of TODOs something like:

[x] Task1
[ ] Task2

Regarding the 100 repo thing, so yes the results are paginated by the API and for good. Just imagine if someone has 10,000 repos, the entire server will go nuts. So we have to handle it from our end. A quick check could be to check if the results from first batch are <100 we stop, or else, we fetch again.

I have made some changes in the code to handle the case if no. of repositories is more than 100, please have a look.

@abhinavsirohi - Please fix the conflicts so that travis can be triggered.

@abhinavsirohi - Overall LGTM though I am unsure about some places. Anyways, please fix the conflicts and see what travis says.

Please have a look at the conflicts, I'm unsure what to do to resolve!

@abhinav - As far as the conflicts are considered, you should keep the chunks from your branch. regarding the repos_url actually you don't need it to get the repo links. The repo name and username is enough to generate it.

I have completed everything , you can merge it if it looks good to you!

@abhinavsirohi  - please resolve the conflicts too.

Done! (I did that earlier too,but maybe i left something, pardon for being a little clumsy!)

What to be done now?

@abhinavsirohi - First of all, remove all your changes from build directory. See if the error in tarvis is related to the changes you've made in Profile.
As far as the oauth issue with graphql is concerned, I was actually thinking of restructuring GitPub to support both the REST API as well as GraphQL untill the REST API becomes completely obsolete (and it won't until some time) and GraphQL is "full-fletched".
This will be a lot of work though. So, will take it up after Kwoc. Until then, we can at least implement the methods that don't require an OAUTH_TOKEN in GraphQL.

For immediate testing purposes, I will see if it is viable to create a testing account of do we have any other work-around. I will let you know whatever I do.

Error in travis is because we are not able to fetch any data due to lack of key, and hence both the methods are returning None instead of expected value.
Can you tell me what should I work on now, concerning other GraphQL methods.

@abhinavsirohi - You can try other generalized graphQL end-points like searching etc.
Also, make a seperate PR for them as this one will need some work from my side too.

Can you be a little more specific I can't figure out what to do!

@abhinavsirohi - Sorry for the soooo delayed response, I was actually "eye-struck" (literally :sweat_smile: ) for some days. Got bed-ridden today.
Well, leaving all this aside, there are ways to make simple HTTP requests such as here. There are other ways too, you can go through them.

Fair enough,even i won't be able to work for a few days now(returning to kgp,so I'll be in train)
Get well soon :smile: !
I'll try make more changes to it after reaching the campus.


BETA15 crash on server start

Minecraft 1.12.2
Forge <IP_ADDRESS>75
Thaumcraft 6 BETA 15
I updated Thaumcraft from BETA13 to BETA15 and this crash keeps happening. The only mod that was changed was Thaumcraft.
https://pastebin.com/qKgBR9d0

Based on the stack trace, it looks like this is the same issue as #897
I'd suggest just staying at 13 until 16 comes out - there are bugs in 14 and 15 that make them pretty much unplayable.

I couldn't give more info about what caused the crash because I already have a lot of TC content in my server, and it crashed almost immediately after loading the world.


Pathfinding is not working with theripper93's Wall Height 6.1.0

In Wall Height 6.1.0 (created by theripper93, required for Levels module) was removed Vaulting setting (AFAIU, is is enabled by default now).
It leads to error on walls intersection during token dragging when pathfinding is enabled, because in WallTracer.js:386 your code tries to access the setting, which no longer exists.
Please consider to update your code to support the latest version of Wall Height or make this module integration optional.

Fixed in v0.10.15. Pathfinding will assume vaulting is enabled if Wall Height is active.


Supported Multiplatform unit tests

Now, SQLlin just supports macOS X64 unit tests and Android instrumentation tests. Next step, I will make the MinGW X64 and Linux X64 unit tests available. When I finished that, I will research if run other Apple(iOS, watchOS, tvOS) unit tests on simulator is available.

The #11 was merged. Windows platform still has environment problem, It will be fixed, and Linux unit tests on CI/CD will be supported in the future.

The #13 and #14  was merged. I fixed the link problem in Windows. Finally, I used the local sqlite.a file to be linked and give up use MSYS2. I also created a Linux environment job that use for build Linux artifact and run unit tests. And I added a lower version(Android 8) Android instrumented tests step in job of Linux environment.
I think I can close this issue now, but maybe I will do more optimization about CI/CD.


API Product create UI issues

The error message should be more user-friendly (without a regex preferably)
"value" should be fixed
Checkbox color is hardly visible and does not match the rest of the UI.

Checkbox color is hardly visible and does not match the rest of the UI.

@HiranyaKavishani , Please note that out of above 3 issues, except 3rd issue , 1 & 2 are still exist


Super class constructor calling an extended method can result in weird behaviour

Explanation:

Class A has constructor that calls empty init method
Class B extends from Class A, adds public property and overrides init function that changes that public property
Public property is not changed by init function

How to reproduce:
http://www.typescriptlang.org/Playground#src=class First {
	public constructor() {
		this.init()%3B
	}

	public init() {
	}
}

class Test extends First {
	public testVar %3D 1%3B

	public init() {
		this.testVar %3D 2%3B
	}
}

var t %3D new Test()%3B
alert(t.testVar)%3B
If the code is ran you can see it will alert 1, rather than the intended 2.
To be honest, I don't know if this is intended behaviour or a bug. I can say is that this particular code rewritten into CoffeeScript seems to work just fine:
http://coffeescript.org/#try:class First
  constructor%3A ->
    %40init()

  init%3A ->

class Test extends First
  testVar%3A 1

  init%3A ->
    %40testVar %3D 2

t %3D new Test()
alert(t.testVar)
I didn't quite know how to formulate this into 1 sentence, hence the weird title.

@RyanCavanaugh an example with [] is just plain bogus.
Sure, if you put an Array onto a prototype and then modify it's contents, the change would affect all objects inheriting that prototype (although, on some rare occasions that might actually be desirable).
But that's simply because [] is a mutable property, unlike 1 and 2 in the @michaelowens example.
"This is also the ES6 class behavior."

 ES6 classes do put their properties on the instance rather than the prototype.
Your blog post is confusing in context because Traceur's compiler also emits code that prints "Hello world".

@RyanCavanaugh, here's a line from the ECMAScript standard:
If a constructor function needs to perform superclass initialization, it must do so by explicitly calling super(/*arguments*/) at some point within the constructor body.

thus, if I don't want to call super - I don't have to; if want to have the super call at the end of the overriding method body - neither JavaScript not Traceur sure ant gonna stop me from doing that
The difference also, is that ES6 does not make it look like it is possible to define a class property (unlike TypeScript) by listing it in the class body, outside of the methods.
You either assign values to this or to prototype, the language does not hide that away from you.
I have worked with Traceur for a considerable amount of time and I never have to look into the compiled code to figure out what's going on, unfortunately this isn't always the case with TypeScript.
Types are no doubt cool and the tooling is awesome, but the resulting code is very Microsoft-ish and does not stand a chance when compared to Traceur.


Naming of traits could be more descriptive

For example, rename Broker to BridgeIn. Especially since the trait only covers a subset of the Broker module's behavior.
See review comments:

https://github.com/Snowfork/polkadot-ethereum/pull/5#discussion_r453719793
https://github.com/Snowfork/polkadot-ethereum/pull/5#discussion_r453720140

Obsoleted by #79


Shorten link is not returning complete long URL

Describing environment

Android device: Any
Android OS version: 6+
Google Play Services version: 16.0.1
Firebase/Play Services SDK version: 16.0.1

Describing Problem
I am passing below example long link for shorten and it's shorten successfully but while i am clicking that shorten link. It's returning only below result long link.
##NOTE: All below links are just dummy example link for understanding purpose.
Original Long Link:  "https://play.google.com/store/apps/details?id=com.example&referrer=referral_medium%3DAndroid_App%26referral_id%3D12345"
Shorten Link:  "https://example.page.link/8EdwL6vuiG7SkbC57"
Result long link after clicking shorten link: ""https://play.google.com/store/apps/details?id=com.example.app"
Sample Code
I am using below code for convert long link into short link.
    final String shortLink ;
    final String longUrl = "https://play.google.com/store/apps/details?id=com.example&"+
                           "referrer=referral_medium%3DAndroid_App%26referral_id%3D12345"

    FirebaseDynamicLinks.getInstance().createDynamicLink()
            .setLongLink(Uri.parse("https://example.page.link/?link=" +longUrl))
            .buildShortDynamicLink()
            .addOnCompleteListener(this, new OnCompleteListener<ShortDynamicLink>() {
                @Override
                public void onComplete(@NonNull Task<ShortDynamicLink> task) {
                    if (task.isSuccessful()) {
                        // Short link created
                        shortLink = task.getResult().getShortLink());
                    } else {
                    }
                }
            });

@Yugalmodi thanks for reporting this!  I will ask the Dynamic Links team and see what the possible explanation could be.

@Yugalmodi here's the response I got, hope it helps:

https://firebase.google.com/docs/dynamic-links/create-manually
I think that longUrl needs to be URL encoded.
setLongLink(Uri.parse("https://example.page.link/?link=" + URLEncoder.encode(longUrl, "UTF-8")))
Or use an Uri.Builder and appendQueryParameter(), which URL encodes automatically.

Thanks for the response. It is working fabulous.


Dielectric and Enthalpy of Mixing reweighting

Description
Implementing workflows for reweighting both dielectric constants and enthalpy of mixing.
Todos
Notable points that this PR has either accomplished or will accomplish.

[x] Implement workflow for dielectric constant
[x] Implement workflow for enthalpy of mixing

Status

[x] Ready to go

This pull request introduces 3 alerts when merging ea7db6ffb7babb7e8b4b5f79e1b631cd89b9bde0 into c212104656f06bf0106815770c240c0dc2b2943a - view on LGTM.com
new alerts:

3 for Unused import

Comment posted by LGTM.com


Analytics Connector a separate repo/library

Summary
Hello! I am running into some build issues with Analytics Connector being a dependency. Is there a reason why it isn't embed?
I'm using SPM with Bazel and run into the issue noted here.
I have a fork with it embed and it's working great.
Thank you!

We do not want to maintain a dependency between this library and experiment, the current configuration with analytics-connector as a common dependency allows us to do this.