Improperly worded sentence regarding Azure AD

Hi Team, just wanted to highlight that the following sentence in quotes doesn't seem to read well in the EA and AAD tenants design area
"Organizations already using on-premises Azure AD can integrate it with their current infrastructure and extend cloud authentication"
Probably could be reworded as below
"Organizations already using on-premises AD can integrate it with their Azure AD and extend cloud authentication"
https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/enterprise-scale/enterprise-enrollment-and-azure-ad-tenants#define-azure-ad-tenants

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0075e68e-d22e-f35d-d7d4-b936dcb3e6ad
Version Independent ID: 11caebc2-6caf-0095-3eb5-564e18a15488
Content: Enterprise Agreement enrollment and Azure Active Directory tenants - Cloud Adoption Framework
Content Source: docs/ready/enterprise-scale/enterprise-enrollment-and-azure-ad-tenants.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @jtracey93
Microsoft Alias: jatracey

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 514466

Team also wanted to report that it seems to be showing correctly in the md file but for some reason the same is not showing in the public website, please see below

cc: @dominicallen FYI

@mbilalamjad @dominicallen
Fixed in private repo: https://github.com/MicrosoftDocs/cloud-adoption-framework-pr/pull/2740


CPUStress Updates

There appears to be multiple ways that CPU Stress is noted through the product and this article.  Although the product name is CPU Stress, it seemed to be most referred to be "CpuStress" through this doc, so I ensured they were all capitalized that way (except in links).
Changed title from old "TestLimit" to "CpuStres" to match TOCTitle and product name.
Removed broken link to Pavel's blog - I tried to find its new home first but was unable to.

Fixes #270

Docs Build status updates of commit 6c50ab3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/cpustres.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ChrisKibble Thanks for this contribution. Looks good, if you resolve the conflict we are good to take it.

Docs Build status updates of commit e90b04d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/cpustres.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks, all resolved now..


How to run the project

Hi,
I'm a researcher and I'm doing research on early prediction of eclampsia; I want to collect data for research, and I found this app helpful but I've no idea how to run this code. I will be very thankful if you guide me in regard.

Hi,
Kindly give me a few days to update the read me file. Ill notify you here.
Kind regards,
Brayton Anderson.
Innovator, Embedded Systems Engineer & Full Stack Developer
I offer a comprehensive range of services as an Innovator, Researcher, Embedded Systems Engineer, and Full Stack Developer. From designing PCBs to researching and solving problems, I can develop websites, mobile apps, and cloud-based solutions. With expertise in Docker, Kubernetes, CI/CD, and GIT, I ensure seamless integration and efficient development processes. Trust me to deliver innovative and reliable solutions that meet your specific needs.
Fluent Languages:
Python, Php, JavaScript, C#, C++, Rust, Laravel, Flutter, Flask, CodeIgniter,Next Js, React Js, Nuxt Js, Go.
PCB Electronic Design
Altium Designer, KiCad.
3D Computer Graphics:
Blender, Solid Works.
Phone: +254 706 852 923 / 7 50 515 222,
@.*** @.***
"Design is not just what it looks like and feels like. Design is how it works." ―Steve Jobs
Sent with Proton Mail secure email.
On Saturday, April 20th, 2024 at 10:33 PM, Zaynab Bukhari @.***> wrote:

Hi,
I'm a researcher and I'm doing research on early prediction of eclampsia; I want to collect data for research, and I found this app helpful but I've no idea how to run this code. I will be very thankful if you guide me in regard.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Thank you.
I'm waiting for the update.

any update?

Hi Zaynab,
Is there a way i can have you on a call to explain my solution.
Kind regards,
Brayton Anderson.
Innovator, Embedded Systems Engineer & Full Stack Developer
I offer a comprehensive range of services as an Innovator, Researcher, Embedded Systems Engineer, and Full Stack Developer. From designing PCBs to researching and solving problems, I can develop websites, mobile apps, and cloud-based solutions. With expertise in Docker, Kubernetes, CI/CD, and GIT, I ensure seamless integration and efficient development processes. Trust me to deliver innovative and reliable solutions that meet your specific needs.
Fluent Languages:
Python, Php, JavaScript, C#, C++, Rust, Laravel, Flutter, Flask, CodeIgniter,Next Js, React Js, Nuxt Js, Go.
PCB Electronic Design
Altium Designer, KiCad.
3D Computer Graphics:
Blender, Solid Works.
Phone: +254 706 852 923 / 7 50 515 222,
@.*** @.***
"Design is not just what it looks like and feels like. Design is how it works." ―Steve Jobs
Sent with Proton Mail secure email.
On Monday, May 13th, 2024 at 8:49 PM, Zaynab Bukhari @.***> wrote:

any update?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

yes you can tell me your availability we can arrange  zoom call.
On Tue, 14 May 2024 at 14:49, Brayton @.***> wrote:

Hi Zaynab,
Is there a way i can have you on a call to explain my solution.
Kind regards,
Brayton Anderson.
Innovator, Embedded Systems Engineer & Full Stack Developer
I offer a comprehensive range of services as an Innovator, Researcher,
Embedded Systems Engineer, and Full Stack Developer. From designing PCBs to
researching and solving problems, I can develop websites, mobile apps, and
cloud-based solutions. With expertise in Docker, Kubernetes, CI/CD, and
GIT, I ensure seamless integration and efficient development processes.
Trust me to deliver innovative and reliable solutions that meet your
specific needs.
Fluent Languages:
Python, Php, JavaScript, C#, C++, Rust, Laravel, Flutter, Flask,
CodeIgniter,Next Js, React Js, Nuxt Js, Go.
PCB Electronic Design
Altium Designer, KiCad.
3D Computer Graphics:
Blender, Solid Works.
Phone: +254 706 852 923 / 7 50 515 222,
@.*** @.***
"Design is not just what it looks like and feels like. Design is how it
works." ―Steve Jobs
Sent with Proton Mail secure email.
On Monday, May 13th, 2024 at 8:49 PM, Zaynab Bukhari @.***> wrote:

any update?
—
Reply to this email directly, view it on GitHub,
or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/brayton-anderson/preeclampsia-flutter-app/issues/1#issuecomment-2109763836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANTTTQX6LUFYAAEH6XBGCHDZCHMY3AVCNFSM6AAAAABGQXEXN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG43DGOBTGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

But i would be more helpful if you can update read me file as it will be
useful for me to work in future
On Tue, 14 May 2024 at 18:42, zainab Bukhari @.***> wrote:

yes you can tell me your availability we can arrange  zoom call.
On Tue, 14 May 2024 at 14:49, Brayton @.***> wrote:

Hi Zaynab,
Is there a way i can have you on a call to explain my solution.
Kind regards,
Brayton Anderson.
Innovator, Embedded Systems Engineer & Full Stack Developer
I offer a comprehensive range of services as an Innovator, Researcher,
Embedded Systems Engineer, and Full Stack Developer. From designing PCBs to
researching and solving problems, I can develop websites, mobile apps, and
cloud-based solutions. With expertise in Docker, Kubernetes, CI/CD, and
GIT, I ensure seamless integration and efficient development processes.
Trust me to deliver innovative and reliable solutions that meet your
specific needs.
Fluent Languages:
Python, Php, JavaScript, C#, C++, Rust, Laravel, Flutter, Flask,
CodeIgniter,Next Js, React Js, Nuxt Js, Go.
PCB Electronic Design
Altium Designer, KiCad.
3D Computer Graphics:
Blender, Solid Works.
Phone: +254 706 852 923 / 7 50 515 222,
@.*** @.***
"Design is not just what it looks like and feels like. Design is how it
works." ―Steve Jobs
Sent with Proton Mail secure email.
On Monday, May 13th, 2024 at 8:49 PM, Zaynab Bukhari @.***> wrote:

any update?
—
Reply to this email directly, view it on GitHub,
or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/brayton-anderson/preeclampsia-flutter-app/issues/1#issuecomment-2109763836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANTTTQX6LUFYAAEH6XBGCHDZCHMY3AVCNFSM6AAAAABGQXEXN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG43DGOBTGY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

The app doesn't host pre-eclampsia data, i wanted to explain how our solution works. How we intend to fetch the data.
Kind regards,
Brayton Anderson.
Innovator, Embedded Systems Engineer & Full Stack Developer
I offer a comprehensive range of services as an Innovator, Researcher, Embedded Systems Engineer, and Full Stack Developer. From designing PCBs to researching and solving problems, I can develop websites, mobile apps, and cloud-based solutions. With expertise in Docker, Kubernetes, CI/CD, and GIT, I ensure seamless integration and efficient development processes. Trust me to deliver innovative and reliable solutions that meet your specific needs.
Fluent Languages:
Python, Php, JavaScript, C#, C++, Rust, Laravel, Flutter, Flask, CodeIgniter,Next Js, React Js, Nuxt Js, Go.
PCB Electronic Design
Altium Designer, KiCad.
3D Computer Graphics:
Blender, Solid Works.
Phone: +254 706 852 923 / 7 50 515 222,
@.*** @.***
"Design is not just what it looks like and feels like. Design is how it works." ―Steve Jobs
Sent with Proton Mail secure email.
On Tuesday, May 14th, 2024 at 4:46 PM, Zaynab Bukhari @.***> wrote:

But i would be more helpful if you can update read me file as it will be
useful for me to work in future
On Tue, 14 May 2024 at 18:42, zainab Bukhari @.***> wrote:

yes you can tell me your availability we can arrange zoom call.
On Tue, 14 May 2024 at 14:49, Brayton @.***> wrote:

Hi Zaynab,
Is there a way i can have you on a call to explain my solution.
Kind regards,
Brayton Anderson.
Innovator, Embedded Systems Engineer & Full Stack Developer
I offer a comprehensive range of services as an Innovator, Researcher,
Embedded Systems Engineer, and Full Stack Developer. From designing PCBs to
researching and solving problems, I can develop websites, mobile apps, and
cloud-based solutions. With expertise in Docker, Kubernetes, CI/CD, and
GIT, I ensure seamless integration and efficient development processes.
Trust me to deliver innovative and reliable solutions that meet your
specific needs.
Fluent Languages:
Python, Php, JavaScript, C#, C++, Rust, Laravel, Flutter, Flask,
CodeIgniter,Next Js, React Js, Nuxt Js, Go.
PCB Electronic Design
Altium Designer, KiCad.
3D Computer Graphics:
Blender, Solid Works.
Phone: +254 706 852 923 / 7 50 515 222,
@.*** @.***
"Design is not just what it looks like and feels like. Design is how it
works." ―Steve Jobs
Sent with Proton Mail secure email.
On Monday, May 13th, 2024 at 8:49 PM, Zaynab Bukhari @.***> wrote:

any update?
—
Reply to this email directly, view it on GitHub,
or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/brayton-anderson/preeclampsia-flutter-app/issues/1#issuecomment-2109763836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANTTTQX6LUFYAAEH6XBGCHDZCHMY3AVCNFSM6AAAAABGQXEXN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG43DGOBTGY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


Latest flutter stable version is breaking with this plugin use. Urgently need fix!

Execution failed for task ':flutter_contacts:compileDebugKotlin'.

'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.19.6, on macOS 14.4.1 23E224 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.88.1)
[✓] VS Code (version 1.79.0-insider)
[✓] Connected device (4 available)
! Error: Browsing on the local area network for Hridoy’s iPhone. Ensure the device is unlocked
and attached with a cable or associated with the same local area network as this Mac.
The device must be opted into Developer Mode to connect wirelessly. (code -27)
[✓] Network resources
• No issues found!

Hey, any solution ?
We are waiting this to be fixed ASAP!!

Hello, any news about this ??

Is the package developer still active ?

Same error here

Unfortunately, the only solution for now is to fallback to Gradle version 7.x.x.

@arabnology @rignaneseleo @zuhabul can you try version 1.1.8?

still happens in latest version @joachim-quis

@arabnology @rignaneseleo @zuhabul can you try version 1.1.8?

still happens in latest version :(, please do something

I found a workaround @arabnology @joachim-quis
https://github.com/acoutts/flutter_libphonenumber/issues/70
project(':flutter_contacts').afterEvaluate {
project(':flutter_contacts').android {
compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
        kotlinOptions {
            jvmTarget = '17'
        }
    }
}

I found a workaround @arabnology @joachim-quis
acoutts/flutter_libphonenumber#70
project(':flutter_contacts').afterEvaluate { project(':flutter_contacts').android { compileOptions { sourceCompatibility JavaVersion.VERSION_17 targetCompatibility JavaVersion.VERSION_17 } kotlinOptions { jvmTarget = '17' } } }

This workaround solution works but is this a permanent solution for production apps?

Any update about it?

Try to use this: flutter_contacts_plus: ^1.3.0  with min sdk 23

Hi all - thanks for your patience and the recommended solutions.
This should be fixed in version 1.1.9. If it is not, please let me know, and reopen this conversation.


chebi:58557, please update 2D structure

Dear ChEBI curators,
Please would you update the 2D structure of CHEBI:58557 with the attached molfile.
It is correct, but it's just to be consistent in the way we draw molecules.
Thanks for your time,
Cheers, Anne
ChEBI_58557_updated.txt

Hi Anne,
We are having problems adding new structures at the moment (hopefully this will be fixed shortly). But the structure in the attached molfile is actually the enantiomer of CHEBI:58557.
ACD-Name names the current (Fischer projection) structure as
2-acetamido-2-deoxy-6-O-phosphonato-D-mannose
but it names the structure in your molfile as
2-acetamido-2-deoxy-6-O-phosphonato-L-mannose.
Can you confirm whether you want the D- or the L- version?
Thanks,
Gareth

Hi Gareth,
Strange...
I need N-acetyl-D-mannosamine 6-phosphate
The Rhea reaction is:
http://www.rhea-db.org/reaction?id=25253
I've just added a phopshate to CHEBI:17122 (N-acetyl-D-mannosamine). It should not change the stereochemistry???

Hi Anne,
No - adding the phosphate won't change the D- or L- assignment.
Unfortunately, the problem is that the 'zig-zag' structure for CHEBI:17122 is also wrong, but nobody has spotted the error in the 7 years since the (correct) Fischer projection structure was replaced as the default structure by the (incorrect) zig-zag structure!
I will sort the structures out as soon as the structure-editing problem has been fixed (hopefully later today). In the meanwhile, I will have a look and see if I can find any other problems arising from incorrect Fischer --> zig-zag conversions.
I will let you know when the structures are corrected (and also if I come across any more errors of this type.
Sorry for the inconvenience caused.
Gareth

Hi Anne,
Now sorted. I didn't come across any other errors of this type, but I can't guarantee that there aren't any!
Sorry again for the problems caused.
Kind regards,
Gareth


dmctl(dm): add more warnings and update help message

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/5220
What is changed and how it works?
add more warnings.
also update help message
Check List
Tests

Integration test

Related changes

Need to update the documentation

Release note
`None`.

/merge

/run-dm-integration-test


Support other MTG systems

Description
Adds support for mtgo and arena.
Checklist

[x] Add tests for these changes
[ ] Test coverage is not decreased
[ ] Entire test suite passes

Codecov Report

Merging #77 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   97.16%   97.23%   +0.06%
==========================================
  Files          19       20       +1
  Lines        1024     1047      +23
  Branches      164      168       +4
==========================================
+ Hits          995     1018      +23
  Misses         17       17
  Partials       12       12

Impacted Files
Coverage Δ

src/spellbot/__init__.py
95.53% <100.00%> (+0.03%)
:arrow_up:

src/spellbot/data.py
100.00% <100.00%> (ø)

...versions/d42e90e48b68_support_other_mtg_systems.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f147cb4...05a4aea. Read the comment docs.


🐛 Bug Report: Upgrading PostgreSql RDS minor version is causing timeout issues

📜 Description
Hi there,
I am using node 16 and backstage 1.9.1 facing below error after my RDS Postgresql is upgraded minor version
Backend failed to start up Error: Failed to connect to the database to make sure that 'backstage_plugin_catalog' exists, KnexTimeoutError: Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call?
at /opt/app-root/src/node_modules/@backstage/backend-common/dist/index.cjs.js:1024:17
at async CatalogBuilder.build (/opt/app-root/src/node_modules/@backstage/plugin-catalog-backend/dist/index.cjs.js:4344:22)
at async createPlugin$h (/opt/app-root/src/packages/backend/dist/index.cjs.js:1050:40)
at async main (/opt/app-root/src/packages/backend/dist/index.cjs.js:4626:29)

Even though I revert RDS to old version it is not working still.
👍 Expected behavior
It should start the Backstage normally and successfully connect to postgres
👎 Actual Behavior with Screenshots
Backstage fails to start with the stacktrace mentioned in the Description section
👟 Reproduction steps
#this is pulling image from internal cloud
FROM node16:2022-07-25-BUILD-16
WORKDIR /opt/app-root/src
RUN chmod -R 777 /opt/app-root/src
COPY yarn.lock package.json .npmrc packages/backend/dist/skeleton.tar.gz ./
RUN tar xzf skeleton.tar.gz && rm skeleton.tar.gz
RUN yarn install --frozen-lockfile --production --network-timeout 600000 && rm -rf "$(yarn cache dir)"
COPY packages/backend/dist/bundle.tar.gz app-config.yaml ./
RUN tar xzf bundle.tar.gz && rm bundle.tar.gz
RUN chmod -R 775 /opt/app-root/src
EXPOSE 7000
CMD ["node", "packages/backend", "--config", "app-config.yaml"]
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now
### Tasks

Hi! Release 1.9.1 is very old, please update to a more recent version as there have been many changes in this area. I'll close this issue for now, but please report again if the issue persists in the latest version.


[CCI] BaseConnectionPool missing implementation of markAlive and markDead methods

Description
Implement BaseConnectionPool markDead and markAlive methods
Fix unit test
Issues Resolved
Closes #429
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] Linter check was successfull - yarn run lint doesn't show any errors
[x] Commits are signed per the DCO using --signoff
[x] Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@timursaurus do you wanna rebase this one so we can get it merged? Thank you :)

Too stale


Render .md files to serve as blog posts

The goal is to list .md files that will serve as posts to be rendered with react-markdown on a blog route. Storing the file names in an array is the first step towards parsing and rendering the contents.

[ ] Markdown text is not rendering via ReactMarkdown

[ ] Clean up and document

[ ] Improve card titling and margin

[ ] change card size

[ ] Clean up and document


Irmin and modular backend support

PR to track Irmin support and support for new vm backends (xapi + libxl).

The patches look great! I haven't looked at all the details, but I like the general shape :-)

Thanks! It's still work in progress though... but hopefully I'll have something that we can merge in a few days :-)

This PR should now be more or less complete. The new backends (xapi, libxl) still need more testing.


Weird CSS issue with drop-down

            <Form>
                <Dropdown customLabel="HTTPS Method" width="5rem">
                    GET
                    POST
                    PUT
                </Dropdown>
                <Button type="submit"/>
            </Form>

Also
When I use width="3rem" the drop down is not wide enough to display my values.

Reproducible in docsite and about the width currently you have to set a width that works with your text.


#523 User should be notified if not enough GD to pay transaction fee of 1%

This PR closes #523

Get installed fee percentage from GoodDollarReserve Contract
Calculate fee while user trying to send some G$s and check if he has amount + fee G$ on his account.

@yaroslav-fedyshyn-nordwhale
in Amount.js we need to change the message to
setError(Sorry, you don't have enough G$ (add ${txFee}% transaction fee))
where $txFee should be read from the smart contract. add in goodWallet getTxFee helper method


Set up clang-format to run automatically on Jenkins on this repo

Summary:
It is very hard to download precisely the correct version of clang-format such that cpplint passes on my local machine. Currently, I have to spend so much time formatting my code manually. I think that if we insist on a specific formatting style, it would be helpful to do the formatting automatically for the developers.
Description:
This already works on stan-math and it's great. I'd love to see something similar on this repo.
Reproducible Steps:
On ubuntu, download clang-format-5.0. Format your cpp code using it, submit a PR to stan-dev/stan and see your build fail on Jenkins because of cpplint.
Additional Information:
One consideration for this issue is whether we'd like to do it before or after we switch to a monorepo.
Current Version:
v2.18.0

I believe this isnt an issue anymore. clang-format 6.0.0 is used across the board.


Add userEvent library to test with advanced simulation interactions

What is the purpose of this pull request? (put an "X" next to item)
Add userEvent library to test with advanced simulation interactions
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
What changes did you make? (Give an overview)
Add userEvent library
Which issue (if any) does this pull request address?
Test with advanced simulation interactions
Is there anything you'd like reviewers to focus on?

@all-contributors please add @danielart for infrastructure


Update khronos api and remove gl_common.

Proposing this again after some more thought and testing.
First, the khronos_api version update is self explanatory; the new version 1.0.0 exists.
Next, regarding the removal of gl_common, the initial motivation was to prevent the gfx crate from compiling both libc 0.2.x and libc 0.1.x.
It was observed that gfx depended on gfx_gl which depended on gl_common.
The idea that gl_common might be unnecessary came when reading this: [https://github.com/bjz/gl-rs/pull/359 "Remove the gl_common crate #359"] (https://github.com/bjz/gl-rs/pull/359).
The gfx crate depends on gfx_gl so to test these changes the following actions were performed on gfx:
cargo build
cargo run --example triangle
cargo run --example cube
cargo run --example deferred
All of the above built successfully and the examples ran successfully.

Looks nice! @bjz ?

:+1:
Next update to gl_generator will also remove the need to depend on khronos_api as well!


Dependencies in composer.json not compatible with Symfony 3.0

Because of the specific dependencies on symfony/config in version 2.5.x and symfony/dependency-injection in version 2.5.x the library cannot be installed/used with Symfony 3.
Maybe the library still works with Symfony 3, if no deprecated features are being used, so in the best case scenario only the version constraints would need to be changed.

I was reviewing the Symfony changelog for the 3.0 release last month. There are a few hints in there that some previously deprecated (in < 3.0) features were removed. This might be one source of some trouble. I also reviewed the listed security fixes. I don't think any of those fixes affect this library, but I will keep my eyes peeled for this. Apart from critical security flaws in symfony* 2.5, is there a good reason to update Symfony 3?

I do not know your internals on how you use symfony/config and symfony/dependency-injection, but I doubt there are that many changes in these components which affect your library, or which would mean a lot of changes. Symfony 3.0 is basically Symfony 2.8 without backwards compatability layer, and Symfony makes it easy to detect deprecated usages.
You do not need to update to Symfony 3 - you just need to support it, by allowing symfony/config and symfony/dependency-injection to be used in the 3.0.x versions aswell as in the 2.5 versions.  The new Symfony version was just released, so I guess I am the first one to request it, but you will need to be compatible at some point anyway, because all new projects will probably start using Symfony 3.0 soon.

By the way, I also noticed that you changed the version restrictions from v2.2.3 to v2.2.4 from
symfony/config: ~2.3
symfony/dependency-injection: ~2.3

to
symfony/config: 2.5.*
symfony/dependency-injection: 2.5.*

Which is a really bad idea - you restrict the usage of these newer library versions to ONLY Symfony 2.5, which is not supported anymore (ended in July 2015), so nobody will be using that specific Symfony version, and therefore nobody can upgrade to newer versions of your library. With ~2.3 at least you supported versions >=2.3 <3.0 .
So my basic suggestion would be for you to test the library with Symfony 3.0 and if it works, then change the version restrictions to
symfony/config: ^2.3 || ^3.0
symfony/dependency-injection: ^2.3 || ^3.0

This would enable usage of your library for the Symfony versions 2.3-2.8 and 3.x .

I am running Symfony 2.7.7 and I am stuck on v2.2.3 of this library as well. Can you at least change the dependency to "~2.5" and do another release?

I am looking into this issue. I put a small bit of time before Christmas to see how much work this would be and decided I should engage others on the team about it. I do think it needs to be done, if possible.

I don't think this is a big change, just update the composer file and run the tests. Would a pull request help?

i have one in already #176


Updated network scanner and main readme

Thank you for your contribution!!

Thank you for your contribution!!

Welcome, Looking for more contribution!!


Fix link reference to TDS latest version

Description / Motivation

Update TDS latest version link reference to 6.0.4
How Has This Been Tested?

Local
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation update (non-breaking change; modified files are limited to the /data directory or other markdown files)

Checklist:

[x] I have read the Contributing guide.
[x] My code/comments/docs fully adhere to the Code of Conduct.
[ ] My change is a code change.
[x] My change is a documentation change and there are NO other updates required.
[ ] My change has new or updated images which are stored in the /public/images folder that need to be migrated to Sitecore DAM

Nice catch!


[KOGITO-5319] KogitoReferenceId handling

As a quick fix to allow process chaining through messages, if
kogitoReferenceId does not point to an existing process instance, create
a new one.
This is a temporary solution till we migrate jBPM conversation approach
implemented with https://issues.redhat.com/browse/JBPM-9735

The (build) Optaplanner check is successful.

The (build) Apps check is successful.

The (build) Runtimes check is successful.

The (build) Examples check is successful.

@tiagodolphine this should be trivial, please take a look

@kiegroup/gatekeepers please merge


Warning about ssl-strict may be inconsistent with default cli.js opts

When building using cli.js I am always seeing the warning The strict-ssl parameter is deprecated, use download.strictSSL instead. I wanted to get rid of it so I checked where and why it was generated. So it seems that in common.js we check if there is a strict-ssl option and warn if there is, but in cli.js we intentionally add that option with a default value.
I am probably missing something, but also this might be an inconsistency. I would be happy to open a PR if it is.

Which version of electron-packager are you using?

7.0.0

What CLI arguments are you passing? Alternatively, if you are using the API, what parameters are
you passing to the packager() function?

	electron-packager client application-name --platform=darwin \
		--arch=x64 --out=bin --icon=client/icon.icns \
		--ignore="node_modules/electron-*" \
		--overwrite

What version of Electron are you building with?

0.37.7

What is the host platform are you running electron-packager on?

darwin

What target platform(s)/architecture(s) are you building for?

darwin & win32

Is there a stack trace in the error message you're seeing?

No.

Please provide either a failing testcase or detailed steps to reproduce your problem.

Running electron-packager with the provided arguments shows the warning.

Thanks for filing an issue. The problem you describe has been fixed in version 7.0.1, released on 2016-04-21.

@malept Thank you for your quick response. I just updated electron-packager to version 7.0.1 but the warning is still there. I'm printing out the value of args in cli.js after arguments are processed by the common.parseCLIArgs function and this is what I get:
{ _: [ 'client', 'wall-monitor-kiosk' ],
  prune: false,
  asar: false,
  all: false,
  overwrite: true,
  download: { strictSSL: true },
  'strict-ssl': true,
  platform: 'win32',
  arch: 'x64',
  out: 'bin',
  icon: 'client/icon.icns',
  ignore: 'node_modules/electron-*',
  dir: 'client',
  name: 'wall-monitor-kiosk',
  protocols: [] }

As you can see the strict-ssl option is still there and so is the warning.

I can reproduce this.

I can reproduce this.

For any future commenters: yes, we know it's reproducible, we're just waiting on a fix now.

Having the same issue, and the download seems to be very slow as well and even stalls.


Create directory for core package WIP

🚨  This is a WIP!
Beginning the process of splitting into multiple packages for https://github.com/styled-components/styled-components/issues/588

I think im ok so far. As long as im moving in the right direction! Will work on it more today or tomorrow and start adding tests.

Awesome

Just to update here I haven't disappeared, just got busy, will get back to this later this week 🙏

@makeupsomething I am happy to help if you need anything

Sorry, closing this since it's quite our t of date and has been inactive for a while 😟 I suppose we'll coordinate adding a core package when the need arises


hyper 1.0 (attempt 2)

Problem
Summary of changes
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

storage_broker's dependency on tonic is currently blocking this. That's the last roadblock as far as I can see. Tracking issue: https://github.com/hyperium/tonic/issues/1579


Fixes #753 - travis configs are incorrect -- master

@pjbreaux @szakeri
What issues does this address?
Fixes #753
What's this change do?
Corrects the allowed branch for docs deployment to clouddocs.f5.com.
Where should the reviewer start?
Any background context?

Can one of the admins verify this patch?


Bug in GUI_main.py

Cloned github repo, installed miniconda and all other install instructions on System MacOSX-10.15.7. Got the following error:

File "GUI_main.py", line 986
selis f.reader.SaveMask(self.Tindex, self.FOVindex, self.m.plotmask)

recognized this as a typo.
Changed the offending line to

self.reader.SaveMask(self.Tindex, self.FOVindex, self.m.plotmask)

The GUI runs fine now.
Would set it up as a pull request, but seemed easier to leave a comment

Folks, thank you so much. Apparently, one of our collaborators made a bug fix on Mar 28, in which they introduced this typo ("selis f" for "self"). Many thanks for finding and fixing it.

Hi @lpbsscientist I think this issue is safe to close now a fix has been merged, one less issue!


rebuild question

I have a tab page called 'me'. And on this page, I have an avatar generated through Image.memory().
code snippet like:
container(
 child : imguint8list != null ? Image.memory(imguint8list) : Image.assets("default_avatar.png")
)

There are also some routes directing to others pages which are put in a listview on 'me' page, for example 'change password'
after I push 'change password' into route stack, do some stuffs and then pop it. The 'me' page is rebuilt thus causing 'avatar' to be flashed in a short period of time. I am wondering how to solve this flashing issue.
Thanks.

Is your avatar going to change frequently?
If not, I suggest storing it as a file after getting it instead of using Image.memory.
And use the Image.file(path) which I believe would not be built again.
These might help flutter cookbook, a plugin

thanks for your reply. I'll try it

Hi @jiangyh1024
This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


Need prompt message when login attempt w/ incorrect credentials

Is your feature request related to a problem? Please describe.
this way we can avoid accidental lite account creation
Describe the solution you'd like
do not automatically create lite account
Describe alternatives you've considered
No response
Additional context
typo: Light -  Lite from front

yes something like this will be required, will be added.


drivers: pwm: fix the bug of frequency in pwm_nrf5_sw

正确的分频值
函数 pwm_nrf5_sw_get_cycles_per_sec 获取正确的周期数
The following is a machine translation
The correct prescaler value
The function pwm_nrf5_sw_get_cycles_per_sec gets the correct number of cycles

Codecov Report

Merging #7474 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7474      +/-   ##
==========================================
- Coverage   55.25%   55.25%   -0.01%
==========================================
  Files         467      467
  Lines       51656    51656
  Branches     9889     9889
==========================================
- Hits        28541    28540       -1
- Misses      19205    19206       +1
  Partials     3910     3910

Impacted Files
Coverage Δ

lib/posix/pthread.c
69.34% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be0c56...83cb726. Read the comment docs.

Please elaborate on the bug, and how to reproduce the bug.

只是计算上的问题
首先软件pwm依赖timer
配置pwm都是在配置timer
nrf的timer时钟固定为MHZ(16)(16 * 1000 * 1000)而不是 16 * 1024 * 1024
这里使用了一个nrf16位的timer,支持 0-9 次二分频,所以这是一个最大定是周期是 25位分辨率为16位的timer
原来的函数将32位的周期值调整成16位进行配置
但进行了很奇怪的计算
将周期数右移了周期数高16位的值，注意这里使用了值而不是位数
而且没有配置二分频次数
我的改动就是，将16位以下的值直接进行配置(这里和原来函数的表现相似)
16位到25位之间，计算出应该使用正确的二分频次数值，和二分频后对应的周期数
超过25位返回错误
使用 pwm_nrf5_sw 驱动时，设置cycles值超过 0xffff 就会出现错误
From Google Translate
It's just a computational problem
First software pwm depends on timer
Configure pwm are in the configuration timer
Nrf's timer clock is fixed at MHZ(16)(16 * 1000 * 1000) instead of 16 * 1024 * 1024
An nrf 16-bit timer is used here, which supports 0-9 times divide-by-two, so this is a timer with a maximum resolution of 25 bits and a resolution of 16 bits.
The original function adjusts the 32-bit period value to 16 bits for configuration
It turned out that there was a very strange calculation here
The number of cycles is shifted right by the number of cycles higher by 16 bits. Note that values are used instead of the number of bits
And there is no configuration for the number of divide-by-2
My change is to configure the following 16-bit value directly (here and the original function is similar to the performance)
Between 16 and 25 bits, calculate that the correct value of divide-by-2 should be used, and the number of cycles after the divide-by-two
More than 25 bits return error
When using the pwm_nrf5_sw driver, setting the cycles value to exceed 0xffff results in an error

http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.1.pdf
page 99
18.1

@cvinayak

@findlayfeng could you please review https://github.com/zephyrproject-rtos/zephyr/pull/8068 to check if it meets your concerns.

@findlayfeng I have seen you comments in #8068. You can fix the frequency bug (for over 16-bit period values), rebased over #8068. I assume would be based on updating the Kconfig supplied prescaler value when the period cycles value is over the 16-bit max.

stale PR, reopen if becomes relevant again.


What would be the best way to do forward warping in the eval gui?

Given two frames Img1 and Img2 and a flow F,  eval_gui.py uses image_warp.py to do a backward warp on Img2 with F, so that the user can compare the result to Img1.
How can I achieve the opposite, i.e. forward warp Img1 with F and compare the result to Img2? Conceptually, is forward warping with F equivalent to backward warping with -F? Or should I rather use the custom ops defined for the network?

It's not equivalent - if you want to use backward warping to warp Img1 towards Img2 then you need the actual backward flow, not -F. If a pixel that is visible in Img1 becomes occluded in Img2, then the backward flow at the target pixel won't be -F of the original pixel, as a different object now determines the motion at the pixel. Unfortunately, I never finished the forward warping code. However, you can take a look at https://arxiv.org/abs/1711.05890v1, where they also use forward warping (for occlusion detection) and it seems to work very well.

I've seen the other paper, too. Unfortunately, their code doesn't seem to be publicly available. So I'm trying to implement forward warping myself. I've got some conceptual questions:

Assuming, the OF is integer-valued, what happens to pixels that are moving, but have no source pointing to them? As a very simple 1-dimensional example, if Im1 = [1, 2], and F = [1, 0], am I correct that that the warped image should just be [1, 1], basically copying the left pixel?
In the float-valued case, let's say Im1 = [1, 2] again and F = [0.5, 0], should the result look like [0.5, 2.5], or would the values have to be added somehow in the bilinear interpolation?
In both papers, for the calculation of the photometric loss, backward-warping is preferred over forward-warping. Is there any particular reason for this?

Thanks a lot for your help!

With backward warping, it is very easy to account for the error introduced by each specific flow vector prediction by using simple bilinear sampling. Forward warping is not so straightforward to achieve, and I am not sure if there is a definitive way to apply it to RGB images. I guess the other answers depend on what you want to achieve with forward warping. If you want to use it for occlusion detection, it would make more sense for the warped image to be [0,1] in your example, as in this case forward warping should identify pixels at which nothing is mapped. In the realistic float case, conceptually, you have a target density image defined as zero everywhere as a baseline first. Then, for each flow, you go to the pixels near the flow target position and add some density to each of them, e.g. by sampling from a 2D Gaussian centered at the actual flow target.


Incorrect value of bool.fromEnvironment('dart.vm.product') in release mode

We've been stripping the debug/verbose logs out from the release build with the following code:
  const bool isReleaseMode = const bool.fromEnvironment('dart.vm.product');
  if (isReleaseMode) {
    debugPrint = (String message, {int wrapWidth}) {};
  }

It was working fine, but got broken since we upgraded Flutter to v0.5.1.
If isReleaseMode is set to true by hand, then the logs are stripped out as expected.
The following is the output of running `flutter doctor -v':
[✓] Flutter (Channel beta, v0.5.1, on Mac OS X 10.13.5 17F77, locale en-CN)
    • Flutter version 0.5.1 at /Users/woody/apps/flutter
    • Framework revision c7ea3ca377 (4 weeks ago), 2018-05-29 21:07:33 +0200
    • Engine revision 1ed25ca7b7
    • Dart version 2.0.0-dev.58.0.flutter-f981f09760

[!] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/woody/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = /Users/woody/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    ✗ Android license status unknown.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 25.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

This is because we moved constant evaluation into a Kernel-to-Kernel transformation: this transformation does not correctly set dart.vm.product in release Flutter builds. This needs to be wired specially (we have a CL in the pipeline but landing of it got delayed for non-technical reasons).
As a workaround you should be able to do this:
$ flutter build aot --release --extra-front-end-options=-Ddart.vm.product=true

/cc @sjindel

Thanks for the information and the workaround, which we'll use while waiting for the issue to be resolved.

@sjindel could you land a change to pass -Ddart.vm.product=true to CFE when building release builds? That should be one liner.

I'm addressing this in https://github.com/flutter/flutter/pull/18876.

This should be fixed now on the master branch.


New package: RadioDJ.RadioDJ version <IP_ADDRESS>

Pull request has been created with Komac v1.11.0 :rocket:

Resolve: #132409

Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please recheck these Pull Request carefully before merging. If it is a incorrect-removing Pull Request and the URLs don't have any issue while manual checking, please close this Pull Request directly(It's best to let Exorcism0666 know).

良い一日をお過ごしください！

Needs InstallerSwitches added for a silent install -

This is unchanged.

It does however stay stuck on "Starting package install.." until you close the app..

What we're seeing is the Database Setup utility. Running the attended installer gives a checkbox:

Is there an installer switch to skip this step?
Alternatively, is there a switch to automate setting it up? Closing it without setting up a database, and opening the application, gives this message:

What is the recommended way to set up this application?


fix namespace

The research_graph namespace issue should be fixed now (we updated the copybara script to rename the namespace). Can you please see if it's fixed on your end after pulling?

it's fixed now, thanks!


Error: Header must provide a Content-Length property

Hello, thank you for this great extension.
I began to receive error (in DevTools of vscode):
Error: Header must provide a Content-Length property.: Error: Header must provide a Content-Length property.
    at MessageReader.onData (C:\Users\elfer\.vscode\extensions\dbaeumer.vscode-eslint\node_modules\vscode-languageclient\node_modules\vscode-jsonrpc\lib\messageReader.js:105:27)
    at Socket.<anonymous> (C:\Users\elfer\.vscode\extensions\dbaeumer.vscode-eslint\node_modules\vscode-languageclient\node_modules\vscode-jsonrpc\lib\messageReader.js:92:19)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
    at Pipe.onread (net.js:523:20)

First it works perfectly on my codebase. But at some moment (I didn't change eslint version or vscode version or extension (explicitly)) that error just appear and it is stable. I'm playing with eslint rules in .eslintrc.
If you need any additional info - let me know.
PS: sorry for my English

@ALF-er  this should not happen :-). Any steps to reproduce would be highly appreciated

Sorry for delay. Here is settings and code (just 2 lines of code) that lead to subj issue https://github.com/ALF-er/vscode-eslint-test But it's obvious that it's not eslint-settings-issue. I want to reinstall vscode from scratch. But maybe I can provide some extended issue report for you before that?

I have the same error:
Error: Header must provide a Content-Length property.
    at MessageReader.onData (/Users/sitapati/.vscode/extensions/dbaeumer.vscode-eslint/node_modules/vscode-languageclient/node_modules/vscode-jsonrpc/lib/messageReader.js:105:27)
    at Socket.<anonymous> (/Users/sitapati/.vscode/extensions/dbaeumer.vscode-eslint/node_modules/vscode-languageclient/node_modules/vscode-jsonrpc/lib/messageReader.js:92:19)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
    at Pipe.onread (net.js:523:20)

So full reinstall of VSCode, vscode-eslint,local eslint doesn't fix problem =| Any ideas, someone?

@ALF-er the problem comes from the fact the something interferes with the protocol socket we use. It will not go away by installing fresh

@dbaeumer Good to know that the source of problem defined (approximately =)). If you need any additional information - let me know, I'll be glad to help.

I fixed it by allowing both stdio and node ipc as a transport. For eslint I change now to ipc transport which makes it impossible that a console.log interferes with the protocol. I publish a new version of eslint as well.

Great!


erlang: 18.3 -> 18.3.4

Motivation for this change
Minor OTP releases (and their manpages) are not available for dowload at
http://erlang.org/download
But e.g.:

18.3.1 contains an important fix for mnesia
18.3.1-18.3.4 has a lot of SSL/TLS fixes

So we have to fetch from GitHub and build everything ourselves.
Also replace explicit path patching with upstream patches:

https://github.com/erlang/otp/pull/1023
https://github.com/erlang/otp/pull/1103 - with this patch it's now
possible to build erlang in sandboxed mode

Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Looks like CI is broken, other builds are failing with the same error: adding reference to database: database or disk is full.

Don't bother updating ejabberd hash, it's unfortunately nondeterministic now (working on fixing that). LGTM, I'll try building ejabberd and merge if it's OK.

Hm, one thing would be nice to change after all -- we try to avoid putting patches directly into Nixpkgs unless there's no stable URL for them at all. Try using fetchpatch and e.g. https://github.com/erlang/otp/pull/1023/commits/98b8650d22e94a5ff839170833f691294f6276d0.patch (append .patch to the commit link).

@abbradar Removed ejabberd fix and patches.

I can confirm this is working on macOS 10.11.5 as well.

Build ejabberd successfully with this change. Will merge soon if nobody objects.


fixes to slurm snap upgrader

I had to make some changes to allow upgrading the slurm snap when it is provided as a snap file as a resource.

👍


npm run dev and npm start both fail on TypeError: MongoStore.create is not a function

app.js:76
    store: MongoStore.create({ mongoUrl: process.env.mongoURI }),
                      ^

TypeError: MongoStore.create is not a function

Steps to reproduce
git clone git@github.com:bradtraversy/storybooks.git .
fill in config.env details
npm install
npm run dev # or `npm start` hits the same issue

"connect-mongo": "^3.2.0", is in package.json. So it's not a versioning difference from the known good repo issue.

It looks like it should be MONGO_URI for one thing. But it still doesn't fix the .create is not a function issue. Weird because this looks like the example code using MongoStore.create on their docs. I'm a web noobie so trying to wrestle through this. Great tutorial btw. I commented out the entire store line and have the piece working I'm interested in though (the oauth).

@adilshaik Your recent change a few days ago is what broke it for me: https://github.com/bradtraversy/storybooks/commit/f5fd0136d9a6f076fc3bbbd8a6bb0c0160f04a1c
If I use the version of the code before this change, the blocking error goes away and everything seems to work.

I see, you just need to update the packages lock. @adilshaik

@maxwellmckinnon As you said to revert the code, I suggest you rather than changing the connect-mongo version of @bradtraversy 's 'package.json', change the code accordingly. @bradtraversy code of connect-mongo doesn't work for the version greater than 4.0.0. I suggest @bradtraversy to merge the #22

To be clear, the merge of #22 is what caused the break. It's a good change, it just needs to include the necessary package updates it needs, test it all out with a fresh git clone and npm install, then make a PR if it works.

//in app.js
//add this :
const MongoStore = require('connect-mongo')(session)
//remove this :
const MongoStore = require('connect-mongo')
//remove this :
store: MongoStore.create({ mongoUrl: process.env.mongoURI }),
//add this :
store: new MongoStore({ mongooseConnection: mongoose.connection }),


Add new_session, write_permission args

Add two kwargs to login:

new_session - if True, forces the user to login, even if a token is cached in HfFolder
write_permission - required a write access token, raises Exception if not provided

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Provide something like len() for GzEncoder and GzDecoder

Hi,
would be nice to know the size of the extracted data, although there is an overflow after 4GB.
Or is it available and have not found it?!
Thanks

Thanks for the report! I don't think this is something that can be implemented though? Deflate streams don't know how big they're going to become, such information would have to be sent through a different channel alongside the stream to learn that

If you mean the amount of bytes extracted so far, the underlying encoder does know. The counter may be 32-bit though. It's used when decompressing gzip-wrapped streams as they have a 32-bit length check value at the end. It's not available from the read/write structs though.
Knowing the extracted length before extracting everything is not really possible though.

Yes think of the last 4 bytes. I've implemented this for me to get the value and do some proof. I thought it would be nice to have this in-build in flate2.
For sure this is not possible if the input is a stream and you have not get the last 4 bytes. So there would be the requirement of some error handling.
But this should be possible:
extern crate flate2;

use std::io::prelude::*;
use flate2::read::GzDecoder;

fn main() {
    let mut d = GzDecoder::new("...".as_bytes());
    let mut s = String::new();
    d.read_to_string(&mut s).unwrap();
    let sizefooter: usize = d.get_size_of_footer().unwrap();  // <=====
    println!("{}", s);
}


Requires node and npm to be installed

Title, basically. Just downloaded the complete example and tried to run it. You will get an error from Vaadin (which is a bug in Vaadin; it should be installing it itself, but doesn't). This can be solved by manually installing node and npm, but should be mentioned in the guide.

@wlfbck Did you file a bug to Vaadin repository? Because auto-installation of node should work. The version used but the tutorial was bit outdated, but it shouldn't matter in this case.

Yeah i reported it to them: https://github.com/vaadin/flow/issues/11056#issuecomment-967177115
That issue has been there for a while. I'm surprised not more people have run into it.

👍 The best thing about the latest version is that Node/npm isn't needed at all anymore, not even as autoinstalled 😎


SQL IAAS RP Default manual installation not correct

In this article, the section for the different Management Modes indicates that "FULL" is the default installation type when installing Manually, however if you install manually using the AZ CLI (in the portal), it installs in Lightweight mode by default (not Full).
Please clarify:

What is the correct behaviour/expected outcome.
If the expected default behaviour is different between types of installations, please provide a matrix to clarify what to expect, and when.

Specific link to paragraph:
https://docs.microsoft.com/en-us/azure/azure-sql/virtual-machines/windows/sql-vm-resource-provider-register?tabs=azure-cli%2Cbash#:~:text=This is the option that's installed by default when installing the SQL IaaS extension manually.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f2e47a4-1781-8c55-c269-1946adbb46db
Version Independent ID: ed091689-e342-2661-8b3a-5be2ad164b3a
Content: Register with the SQL VM resource provider - SQL Server on Azure VM
Content Source: articles/azure-sql/virtual-machines/windows/sql-vm-resource-provider-register.md
Service: virtual-machines-sql
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@NWiddup
Thanks for your Question! We are currently investigating and will get back on this.

Hi @NWiddup, thanks for contacting Microsoft and I apologize for the delay. Would you please mind providing a screenshot of how you're using the Az CLI in the portal to install the SQL IaaS extension?
Thanks!
Masha from the SQL Docs team

Hi @MashaMSFT, the commands I'm using are below:
az sql vm list --resource-group NWPS4SQL20200329_LAB1
az sql vm create --name SQL01 --resource-group NWPS4SQL20200329_LAB1 --license-type PAYG
az sql vm list --resource-group NWPS4SQL20200329_LAB1
Here is a screenshot (with Subscription & ResourceID's removed). According to the docs, I believe the highlighted lines should have installed in FULL, instead of Lightweight:

Hi @NWiddup , thanks for reaching out once more and clarifying! So there may be some confusion between the SQL IaaS extension, and registering with the SQL VM resource provider. The SQL IaaS extension is installed when you register with the SQL VM resource provider, but it can also be installed manually.
The az cli command you're executing (az sql vm create) is creating the SQL VM resource, which is registering with the SQL VM resource provider in lightweight mode. This is intentional because we do not want to restart the SQL Server service when registering with the resource provider.
This is different than manually installing the SQL IaaS extension, which can only be done via PowerShell:
  Set-AzVMSqlServerExtension -VMName "sql2017" `
  -ResourceGroupName "LabsqlIAASagent" -Name "SQLIaasExtension" `
  -Version "2.0" -Location "Central US";

This is the equivalent of upgrading the SQL VM resource provider to full mode. Either action (registering with the SQL VM resource provider, or installing the SQL IaaS extension manually) restarts the SQL Server service. So to prevent unexpected restarts, the recommended approach is to register in lightweight mode as soon as possible after the VM is created, and then upgrade to full during a maintenance window, rather than installing the IaaS extension manually.
I hope that helps and please let me know if you have any further questions?
Thanks!
Masha from the SQL Docs team

Thanks @MashaMSFT, that answers the question :)


Upgrade to Crystal 0.8.0

Small changes for Crystal 0.8.0 support. Installation instructions also updated to use shards (a separate PR should add a shard.yml file here, with a version, etc.; I'll do that next).

Build in Jenkins failed but I don't really understand why. I'd say it's not related to these changes but I'd like to find out and fix it :)

:+1:

I closed and reopened to trigger a new build because it seemed to be a hiccup (apt failing to update, probably because of network issues).
It's green now ^_^

Thanks!


How to add a custom pipeline into yaml config?

I have MyPipeline class.
How to add the pipeline?
Can we use this syntax?
my_pipeline:
  __import__: app.MyPipeline

The syntax would be this:
app.MyPipeline:

Thanks 👍


Add pre-defined problem list in feedback control

I would be able to just choose which kind of problem I met with this new problem list.

Since we are migrating to docs.ms.com. We will leverage its feedback control on it.


[SQL Editor] "Bind Parameters" Window appears after every fetched page

Win10
DBeaver 7.0.0
Describe the problem you're observing:
"Bind Parameters" Window appears after every fetched page if SQL Statement is with a bind parameter.
Steps to reproduce, if exist:

Execute an SQL Statement with bind parameter for a table in order to 2 or more its pages will be shown in Resultset
Scroll the table to the next fetched page in Resultset

Actual result:
"Bind Parameters" Window appears.

Fixed.
This problem happened with anonymous parameters only.

verified


OAUTH_CALLBACK_ERROR Unexpected token < in JSON

I'm receiving an issue when using in Next 13.4 with Next-Auth 4.22.1  and latest next-auth-steam
[next-auth][error][OAUTH_CALLBACK_ERROR]
https://next-auth.js.org/errors#oauth_callback_error Unexpected token < in JSON at position 0 {
  error: SyntaxError: Unexpected token < in JSON at position 0
      at JSON.parse (<anonymous>)
      at parseJSONFromBytes (node:internal/deps/undici/undici:6498:19)
      at successSteps (node:internal/deps/undici/undici:6472:27)
      at node:internal/deps/undici/undici:1145:60
      at node:internal/process/task_queues:140:7
      at AsyncResource.runInAsyncScope (node:async_hooks:204:9)
      at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
    name: 'OAuthCallbackError',
    code: undefined
  },
  providerId: 'steam',
  message: 'Unexpected token < in JSON at position 0'
}

entire config looks like
export default function handler (req: NextApiRequest, res: NextApiResponse) {
    return NextAuth(req, res, {
        providers: [
            TwitchProvider({
                clientId: process.env.TWITCH_CLIENT_ID ?? '',
                clientSecret: process.env.TWITCH_CLIENT_SECRET ?? '',
            }),
            SteamProvider(req, {
                clientSecret: process.env.STEAM_SECRET!,
                callbackUrl: `${process.env.NEXTAUTH_URL}/api/auth/callback`,
            }),
            // ...Add more providers here
        ],
        callbacks: {
            async jwt({ token, account, profile }) {
                // Persist the Twitch User Id and pass to session callback
                if (profile) {
                    token.id = profile.sub;
                    try {
                        const response = await axios.post(PlayFabAPIURL + 'GetPlayFabIDsFromTwitchIDs', {
                            TwitchIds: [profile.sub as string],
                        }, {
                            headers: {
                                'Content-Type': 'application/json',
                                'X-SecretKey': process.env.PLAYFAB_API_KEY ?? '',
                            },
                        });

                        const playfabResponse = response.data as PlayFabTwitchIDResponse;
                        token.playFabData = playfabResponse;
                    } catch (e) {
                        console.error(e);
                    }
                }

                if (account?.provider === PROVIDER_ID) {
                    token.steam = profile;
                }

                return token;
            },
            async session({session, token, user}) {
                // Add twitch user Id and playfabId from JWT flow to session
                if (session) {
                    // Only set session info (Twitch and PlayFab) if we have a valid PlayFab ID. Else just return the session without the new data
                    if ((token.playFabData as PlayFabTwitchIDResponse).data.Data[0].PlayFabId) {
                        //@ts-ignore
                        session.user.id = token.id;
                        //@ts-ignore
                        session.user.playFabId = token.playFabData.data.Data[0].PlayFabId ?? null;
                    }
                    if ('steam' in token) {
                        // @ts-expect-error
                        session.user.steam = token.steam;
                    }
                }
                return session;
            },
        },
    } as NextAuthOptions);
};

the nextauth url is just http://localhost:3000 so that wont be an issue

@Nekonyx have any insight into this?

Anyone having this issue: you need to set STEAM_SECRET in the environment variables with this information https://steamcommunity.com/dev/apikey create an APIKey there and use that.
The docs for some reason dont mention this. Didn't know this wasn't a public API call..

Hey @chukwumaokere.
I apologize for the long response. Glad the problem is resolved.
Yes, maybe I really should specify in documentation that STEAM_SECRET should be taken from https://steamcommunity.com/dev/apikey


Method chain formatting produces long long first line

I was going to title this issue "long expression has weird formatting", but then I realized that 99% of rustfmt issues could probably be described thusly :P
I got the following from rustfmt today:
  let matches = App::new(env!("CARGO_PKG_NAME")).version(concat!("v", env!("CARGO_PKG_VERSION")))
    .author(env!("CARGO_PKG_AUTHORS"))
    .about(concat!(env!("CARGO_PKG_DESCRIPTION"),
                   " - ",
                   env!("CARGO_PKG_HOMEPAGE")))
    .setting(AppSettings::ColoredHelp)
    .get_matches_from_safe(args)?;

This strikes me as fine except for the first line, which seems weird, even though it's under my ideal width of 100 characters.
I would have expected and preferred:
  let matches = App::new(env!("CARGO_PKG_NAME"))
    .version(concat!("v", env!("CARGO_PKG_VERSION")))
    .author(env!("CARGO_PKG_AUTHORS"))
    .about(concat!(env!("CARGO_PKG_DESCRIPTION"),
                   " - ",
                   env!("CARGO_PKG_HOMEPAGE")))
    .setting(AppSettings::ColoredHelp)
    .get_matches_from_safe(args)?;

This seems like a bug to me.

This is somewhat intentional, though is likely to change with the new fmt RFCs.

Closing since it is not really a bug, and is only actionable as part of larger, already tracked work

Ah, I see.
Can you link to the RFC (or RFC PR) in question?

Discussion of how to format should be discussed here: https://github.com/rust-lang-nursery/fmt-rfcs/issues/66
I'm doing a lot of refactoring in this area which is not really tracked anywhere.


Blog post for the vscode

Why you need this feature:
[Is your feature request related to a problem? Please describe in details]
Blog post for the vscode
Describe the solution you'd like:
[A clear and concise description of what you want to happen.]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

This is completed async.
Closing this issue


Refactor lists of hardware instances to hashed structures

Proof of concept for #609

Is this PR still in progress @dyf @bruno-f-cruz

Feel free to close.


add connection support for wdm subscription

--After binding from connection has been created and running SendSubscribeResponse, it needs to check HasPeerRequestedAck() to send message.

Closing.  This has been superseded by https://github.com/openweave/openweave-core/pull/456


[FEATURE] clean up bitselect

bitselect does not make sense on avx512 and we should hide it for where it's needed.

In fact, only the logical cases make no sense AND the type-based ones are needed to optimize if_else on AMD.
So I propose we just remove the logical cases.


Jest-dom like assertions

For component testing, would be great to have jest-dom like assertions, e.g. toHaveAttribute()

I think you can just create a setup file and add it to your config
// peeky.setup.ts
import { expect } from '@peeky/test'
import matchers from '@testing-library/jest-dom/matchers'

expect.extend(matchers)

// peeky.config.ts
import { defineConfig } from '@peeky/test'

export default defineConfig({
  runtimeEnv: 'dom',
  setupFiles: ['./peeky.setup.ts']
})


Casting support?

Apologies if I've missed this. Is there support for casting in cases where methods return interfaces, but you know there is definitely a specific implementor in the property?
I'm trying to get a MediaPlaybackList, which implements IMediaPlaybackSource from a MediaPlayer. I've tried:
let source: MediaPlaybackList = sender.source()?;
let source: MediaPlaybackList = sender.source()?.into();

Is this at all possible, even unsafely?
Thanks.

You can use the winrt::ComInterface trait's try_query method. I am planning on cleaning this up so that it's a little less confusing.

Hmm, looking at the try_query tests and am a bit confused. Currently doing:

player.media_ended(TypedEventHandler::new(|sender: &MediaPlayer, _args| {
println!("ended");
letsource=sender.source()?;
letsource: MediaPlaybackList=source.try_query()?;

Getting:
66 | let source: MediaPlaybackList = source.try_query()?; | ^^^^^^^^^
method not found in
`tts_winrt_bindings::windows::media::playback::IMediaPlaybackSource` ```
I have:

usewinrt::ComInterface;
in my code. What am I missing?
Thanks.

Sorry, don't want to add noise, but I still need help with this. Is there additional boilerplate needed in build.rs to use try_query? I thought that was defined in ComInterface, which I've definitely imported to get is_null. I've looked at the test cases, and nothing jumps out at me. Should I be able to cast from a returned interface to a specific class? The tests cast to IStringable which is not what I want (I.e. I'm going from an interface, not to one.)
Thanks.

Hi Nolan, I'm not familiar with this particular API, but if you can share a complete and minimal repro that I can quickly compile I should be able to take a look and see if I can spot what's tripping you up.

OK, just realized that try_query isn't in 0.7.2, which is why it wasn't
working for me. Or, at least, assuming the "v0.7" tag is 0.7.2, it isn't
there.
So I suppose that begs 2 questions. 1. Is casting supported in 0.7.2? 2.
If not, will there be a release that supports it soon? I have a library
on crates.io, so depending on Git isn't an option.
Thanks.

Here's a casting example that works with 0.7.2:
use winrt::*;

import!(
    dependencies
        os
    types
        windows::foundation::Uri
);

fn main() -> Result<()> {
    use windows::foundation::*;

    let uri = Uri::create_uri("http://kennykerr.ca")?;

    let s: IStringable = uri.try_into()?;
    println!("{}", s.to_string()?);

    let u: Uri = s.try_into()?;
    println!("{}", u.domain()?);

    Ok(())
}

OK, figured it out. The call to try_into suggested the standard Rust
TryInto type be imported, which doesn't seem compatible in this context.
use winrt::*; got me what I needed and the cast worked. Guessing
there's some local trait that provides this, but for some reason my
loadOutDirsFromCheck setting still doesn't work so it wasn't suggested.
Thanks again for all the help.

No worries, thanks for being an early adopter! A lot work is going into the next version to remove a lot of the oddities and make it more idiomatic in Rust.


coverity: Add model for g_error to deal with false positives.

All coverity models should go into this new file. All of our Coverity
false positives come from g_error though so this is all that's in here
for now.
Signed-off-by: Philip Tricca<EMAIL_ADDRESS>

This resolves #72


vcv-rack: 1.1.5 -> 1.1.6

Motivation for this change
It looks like upstream is about to release version 1.1.6 soon. I have updated the derivation for the latest master branch commit, trying out if we can drop one of our patches for 1.1.6.
To avoid duplicated effort I post it here already.
1.1.6 has been released.
I added a few more explanatory comments. Please let me know if they are helpful or they can be improved.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

cc @nathyong

If I remember correctly, I created an account and chose the plugins interactively.

The way @Lassulus described is the way to go. At the moment there is no method to install plugins via Nix.


Issue with k8s.io/docs/tasks/administer-cluster/dns-debugging-resolution/

This is a

[ ] Feature Request
[x] Bug Report

Problem:
Because the busybox's "nslookup" issue in the lastest version issue. Can't use "nslookup" in busybox pod to find the service by dns service.
Proposed Solution:
Use the busybox version  1.28 will solve the problem.
Change the "busybox.yaml" as:
apiVersion: v1
kind: Pod
metadata:
  name: busybox
  namespace: default
spec:
  containers:
  - name: busybox
    image: busybox:1.28
    command:
      - sleep
      - "3600"
    imagePullPolicy: IfNotPresent
  restartPolicy: Always

I see the link has already been updated but I don't know why this link is not.
Page to Update:
https://k8smeetup.github.io/docs/tasks/administer-cluster/dns-debugging-resolution/

kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T10:39:04Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}

Hi @daohu527
https://k8smeetup.github.io/docs/tasks/administer-cluster/dns-debugging-resolution/ looks like an outdated copy of the Kubernetes documentation. The current, official documentation is at http://kubernetes.io/docs/ (and there is ongoing localization work).

/close


tiny fix

Signed-off-by: Xianglin Gao<EMAIL_ADDRESS>

@xlgao-zju this change must be done in https://github.com/opencontainers/runc - we don't modify vendored code here.

Sorry, will do it in https://github.com/opencontainers/runc

@xlgao-zju thanks!


Support installing qt5 and qt6 versions in parallel

I tried to make old find_package(QXlsx) still work as before, but this looks pretty ugly...

Do you really wanna break existing users cmakelists with this changes? Looks like if i use find_package(QXlsx) cmakelist will be broken with this changes

This is why first I added the fallback option with QXlsx without specifying Qt... But @dantti didn't like that

Sure, CMake support was just recently added and such change makes it future prof for Qt7 as well, this project has no API/ABI guarantees so if one is to update it's version it should be aware of breakages.

Sure, CMake support was just recently added and such change makes it future prof for Qt7 as well, this project has no API/ABI guarantees so if one is to update it's version it should be aware of breakages.

Maybe it will be better to add target without version specified? Current naming has been working for more than 1.5 years and i don't see really necessary to break it. Of course there is no api guarantees but it's not a reason to break api.

Changing find_package has nothing to do with API

It's part of API. Existing software relied on find_package(QXlsx), but this won't work anymore

@Jihadist I don't like breaking things, but currently this is already broken for me too now, as I need both installed, also relying on QXlsx::QXlsx-qt6 target won't help if both are installed but find_package finds the qt5 first, this is even the case for Qt it self that if you have both from distro QtCreator doesn't set the proper CMAKE_PREFIX_PATH
@DarthGandalf there is also another issue that I noticed while testing cpack that the headers are both installing to the same place...

Yes, headers are installed to the same place, but why is it a problem? Is there something in the headers themselves which is different between qt5 vs qt6?

looking again at current changes, please don't append QtX to it, only at the target files, this way the only needed change is find_package( +QtX)

If there's something different, I can make it easily install to different places, no big deal

looking again at current changes, please don't append QtX to it, only at the target files, this way the only needed change is find_package( +QtX)

So you want the target name to stay QXlsx::QXlsx, right? Sure, can do. The downside is that it will be impossible to use the qt5 version and qt6 version in the same cmake project for different executables. But probably that's not a big problem

I believe that's probably already impossible or if possible not something I would care :) same binary can't use both anyway

relying on QXlsx::QXlsx-qt6 target won't help if both are installed but find_package finds the qt5 first, this is even the case for Qt it self that if you have both from distro QtCreator doesn't set the proper CMAKE_PREFIX_PATH

If it's the only one problem it can be fixed like this without breaking api:
if(USE_QT6)
    find_package(QT NAMES Qt6)
else()
    find_package(QT NAMES Qt5)
endif(USE_QT6)

That's the same thing just making more ugly cmake files, I have lots of stuff on Qt6 already, but due "new" Qt5 projects they are now broken.. it's not like users would need to rewrite their entire software

Renamed the imported target back to QXlsx::QXlsx
Left headers as is, because I see no need to install them in different dirs

if you don't change the headers dirs then you can't install Qt5 and Qt6 deb packages for example.

I think debian package would have headers in something like qxlsx-common package, and both qxlsx-qt5-dev and qxlsx-qt6-dev would depend on that package

debian will likely never package qxlsx, but I only use qxlsx with deb packages thanks to cpack.

I think it soon will. Debian packages Stellarium, and QXlsx is a dependency of Stellarium since the latest release. In fact the reason for this my PR is because I'm trying to package it for Gentoo.
QXlsx was a dependency of Stellarium even before, but it was done by including a copy of it in directly in sources (with small modifications), which is against policies of linux distros:

https://fedoraproject.org/wiki/Bundled_Libraries
https://www.debian.org/doc/debian-policy/ch-source.html#embedded-code-copies
https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies

Fedora packaged it already, because of Stellarium
https://repology.org/project/qxlsx/history

Downstream can patch and fix that there if they want, but likely it shouldn't be available as -dev packages, but if we are fixing it here it should be a proper fix, fixing a find_package is a nobrainer fix

Downstream can patch and fix that there if they want

Sure, I can. But it's easier to not have any patches, because they may need to be updated whenever upstream releases new version. That's why I opened this PR, to figure out with you how do you want it to look like, so that I can: 1. apply a patch only for this version of qxlsx, 2. drop it for the next version, 3. not forced to update the patch to stellarium when you release the next version of qxlsx.
This is mostly to decide on these details like which string is passed to find_package, and how the imported target will look like, etc, which is part of API, believe it or not :) This already changed several times during this PR review, but it's fine - it's better now than changing the package after it's packaged already

I only use qxlsx with deb packages thanks to cpack.

I have no idea how cpack works, and I don't know whether Debian packagers will be able to use it or how. On Gentoo we run make install to a prefix, and if the library has several variants which can be installed at the same time (like, qt 5 and qt 6), these variants all run make install to the same prefix, then the whole dir is packaged as a single package which is then installed on the system; and depending on user settings the package would contain only qt5 lib, or only qt6 lib, or both.

but likely it shouldn't be available as -dev packages

AFAIK, they still split headers and other development-only files to a separate -dev package, to avoid need to install useless headers for user who only needs binaries

@DarthGandalf i looked through your changes and have a question. Can i use find_package(QXlsx5) or find_package(QXlsx6) and link against target QXlsx::QXlsx or not?
I think this should be mentioned somewhere in docs, it would be nice (here for example https://github.com/QtExcel/QXlsx/blob/master/HowToSetProject-cmake.md).

@Jihadist in the current version of the PR you use find_package(QXlsxQt5) (or 6), then link to QXlsx::QXlsx.
In the previous versions it varied, from linking to QXlsxQt5::QXlsxQt5 to having find_package(QXlsxQt5) finding Qt5 version specifically and find_package(QXlsx) finding any installed which would kinda preserve back compatibility but will randomly break if the wrong one is found.
Re docs: done. And updated HelloWorld

@DarthGandalf thank you! It looks great. Can you add something more to docs for cmake? I mean cmake provide to use library without direct instaling https://cmake.org/cmake/help/latest/module/FetchContent.html
How it was mentioned there https://github.com/QtExcel/QXlsx/issues/49#issuecomment-907870633

In Stellarium I used CPM to find the system version (via find_package), with fallback to downloading it (via FetchContent).
https://github.com/Stellarium/stellarium/blob/5da735d219dc957eb89c0d3353c645fa239f19eb/CMakeLists.txt#L805-L824
If not for #134, that code could look much simpler:
     CPMFindPackage(NAME QXlsx
	 URL https://github.com/QtExcel/QXlsx/archive/refs/tags/v1.4.4.zip
	 URL_HASH SHA256=3efbd6f63a1ffd521c535dce7b5a5a7e9ebd23db51e6ae8e3e2eb89796e57675
	 EXCLUDE_FROM_ALL ON
	 SOURCE_SUBDIR QXlsx)
     target_link_libraries(myapp QXlsx::QXlsx)

I could put that to docs, but I don't think it would be appropriate there yet, considering #134
PS. of course, I'll need to update Stellarium to use the correct name after this PR is merged.

...though that issue affects plain add_subdirectory too...

@DarthGandalf I don't understand what's the relation with #134.
Now this patch is 99% good, cpack will pack the files that make install would copy to /usr, this means that if we don't fix the headers location it will not work, this doesn't break API because cmake will export the base path, but will fix cpack.
If in 2 years we drop Qt5 support and distros want to keep it, then their -dev will not be the same as header files won't match.
If you prefer we can fix on another PR, but should be a simple fix.

This PR isn't related to #134 directly. I meant it in context of the update to docs.

If in 2 years we drop Qt5 support and distros want to keep it

That's essentially maintaining a fork, which is not very trivial

then their -dev will not be the same as header files won't match

But if they really decide to do that, I'm sure they'll figure out how to deal with headers.

ok, so why don't you want to fix the headers location? I can do that if you like
also looks like my fix to not export GuiPrivate (which causes users to have it installed), still need to find time to include gzip and drop GuiPrivate...

also looks like my fix to not export GuiPrivate (which causes users to have it installed) conflicted, still need to find time to include gzip and drop GuiPrivate...
forgot a word....

why don't you want to fix the headers location?

Because it works already... Can cpack put different directories (include/) to separate packages?

I can do that if you like

ok

ok, can you please fix the conflict, I did this within the web interface but it still doesn't work :/

Yeah, headers can be installed to separate package via cpack
https://cmake.org/cmake/help/book/mastering-cmake/chapter/Packaging With CPack.html#cpack-component-install-support

This is not because of bad merge, but just because of a45571842aaf9839b418a2653fa199b87a631bc9 - CI still uses Qt 5.9

QStringView::split was added only in 5.15

The easiest way to fix it is to revert a45571842aaf9839b418a2653fa199b87a631bc9
Why did you merge it despite CI failures?

Because I can't change CI argh.... I thought I removed the split changes tho

ok, can you please fix the conflict

well, except for android which fails always, it now passes with the revert

Still says This branch cannot be rebased due to conflicts

Weird. Refresh the page maybe? I did several force pushes, maybe your browser didn't realize that

Or you can merge without rebasing

I did the merge manually


Shift clicking recipes with NEI causes a CTD

Log: http://puu.sh/jWXa7/2bbcd3b9f0.txt
lolwat

1.7 support has been dropped an NEI does not exist in the 1.8+ world.


Partially Implement get tx info syscall

The reponse is not implemented yet.

Please resolve the conflicts

Done

Codecov Report

Merging #16 (b7be0f7) into main (76509dd) will decrease coverage by 3.98%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   76.09%   72.10%   -3.99%
==========================================
  Files          10       11       +1
  Lines         548      631      +83
==========================================
+ Hits          417      455      +38
- Misses        131      176      +45

Impacted Files
Coverage Δ

...rc/core/syscalls/business_logic_syscall_handler.rs
48.18% <20.68%> (-16.46%)
:arrow_down:

src/definitions/general_config.rs
28.57% <28.57%> (ø)

src/business_logic/execution/objects.rs
100.00% <100.00%> (ø)

src/core/syscalls/syscall_handler.rs
59.64% <100.00%> (+3.04%)
:arrow_up:

src/core/syscalls/syscall_info.rs
100.00% <100.00%> (ø)

src/core/syscalls/syscall_request.rs
56.92% <100.00%> (-10.43%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


vast ads wont show

hei, i was woundering if you guys could help me??. I have use a lot of cods but still my vast file wont work. do you guys have one that work with the new fluid player with auto player, banner html and vast link/vast fil??

All the working demo code is available in /test/ folder of this repository. This is the same code we use in development to test the features of the player.
Try see the console output in your browser for any hints and errors.


Bump version to 3.0.4-3.0.0

Update DCGM to 3.0.4
Update headers to 3.0.4

@glowkey is there any documentation related to the DCGM 3.0.4 release? I can't see this referenced anywhere in the Nvidia docs?

The release notes have the major changes: https://docs.nvidia.com/datacenter/dcgm/latest/release-notes/changelog.html

thanks!, I'm sure that page didn't have v3 a minute ago;