encoding/csv: stop preserving \r in multiline quoted strings

In #21201, @alexhultman filed a fairly blunt bug report that “I want the verbatim data as in the CSV file, not some made up corrupt data.” because the CSV reader changes \r\n to \n inside multiline quoted strings.
@nussjustin said on the issue that this behavior was unexpected, and @pborman seemed to agree that it was wrong, but I cannot figure out why. Later in the issue @pborman says “You have pointed out a situation in which the CSV package is not following the RFC.” but I can't see anything in the RFC that says \r must be preserved in this case.
About carriage returns the RFC says (in total!):
“Each record is located on a separate line, delimited by a line break (CRLF).”
“The last record in the file may or may not have an ending line break.”
“Fields containing line breaks (CRLF), double quotes, and commas should be enclosed in double-quotes.”
“As per section 4.1.1. of RFC 2046 [3], this media type uses CRLF to denote line breaks.  However, implementors should be aware that some implementations may use other values.”
The entire ABNF grammar is:
file = [header CRLF] record *(CRLF record) [CRLF]
header = name *(COMMA name)
record = field *(COMMA field)
name = field
field = (escaped / non-escaped)
escaped = DQUOTE *(TEXTDATA / COMMA / CR / LF / 2DQUOTE) DQUOTE
non-escaped = *TEXTDATA
COMMA = %x2C
CR = %x0D ;as per section 6.1 of RFC 2234 [2]
DQUOTE =  %x22 ;as per section 6.1 of RFC 2234 [2]
LF = %x0A ;as per section 6.1 of RFC 2234 [2]
CRLF = CR LF ;as per section 6.1 of RFC 2234 [2]
TEXTDATA =  %x20-21 / %x23-2B / %x2D-7E

Nothing in the RFC text or the grammar says that CRLF inside a quoted string must not be shortened to LF. What the RFC does say is that CRLF is the way line breaks are denoted and that some implementations use other ones.
Everything else in Go uses \n as the line separator. It makes sense to treat inputs here using \r\n as the line separator as an external encoding to be converted and to apply the \r\n → \n conversion to all lines, including quoted strings. CSV files are a special format text file. If you "convert" a CSV file from Unix line endings to Windows line endings, a convenient property would be that reading the CSV data produces the same result for both versions of the file. Go 1.9 and earlier provided that. We do the same processing for \r inside multiline backquote strings in Go source code, for the same reason.
I believe that if we keep the change in CL 52810, this will surprise users who have CSV data from some generator that uses \r\n line endings and now have unexpected \r characters in their multiline values that they will need to postprocess away.
I think we should revert this CL.

 This behavior makes the Go CSV parser MODIFY data that are in the middle of a string! The standard probably does not say anything about preservibg Swedish character Ö either so why not shorten it to O following this ridiculous nonsense. For me however I'm now using libcsv which is about 7x more performant and does not corrupt data so I don't care personally anymore. Golang is dead for me.

It appears the text and the BNF differ.  The text says:
Fields containing line breaks (CRLF), double quotes, and commas
should be enclosed in double-quotes.  For example:

       "aaa","b CRLF
       bb","ccc" CRLF
       zzz,yyy,xxx

This example seems to imply that a line break is CRLF.
The BNF states:
   escaped = DQUOTE *(TEXTDATA / COMMA / CR / LF / 2DQUOTE) DQUOTE
   TEXTDATA =  %x20-21 / %x23-2B / %x2D-7E
   COMMA = %x2C
   CR = %x0D ;as per section 6.1 of RFC 2234 [2]
   LF = %x0A ;as per section 6.1 of RFC 2234 [2]
   DQUOTE =  %x22 ;as per section 6.1 of RFC 2234 [2]

Expanded, TEXTDATA includes CR, LF, and all printable characters (0x20-0x73) excluding " unless it is doubled.  TEXTDATA may contain a lone CR or a lone LF.
The RFC does not cover two types of data: binary and UNICODE.  A strict reading of the RFC limits a string to all printable ASCII characters plus a space, linefeed, and carriage return.  The csv package is a superset of the RFC (and I think it needs to be, e.g., it should allow UNICODE).
I do not believe either interpretation is wrong and it ends up being a choice of convention.
I agree with Russ that man programs/operating systems feel quite free to convert CRLF to LF and a lone LF to CRLF.  If an operating system or program does this then it is quite possible the text seen by the CSV parser is not exactly the original text.
The main problem as I see it is aside from RFC 4180 there is no real CSV standard.  Many common use cases do not follow RFC 4180.  The csv package tries hard to both honor 4180 as well as accept many common use cases (is the space after a comma part of the field or part of the separator, can a quote exist in an unquoted field, must the number of fields be the same for every record).  I seem to recall that Excel's CSV format was one of the variants beyond RFC 4180.
The existing package does documentation does describe the default behavior.
It is unfortunate there is more than one "standard" end of line sequence for text files (LF, CRLF, and I believe I have seen CR as well).  Some programs/operating systems distinguish between text and binary files (FTP does, for example).
In my previous comment I was erring on the side of the BNF.  Russ errs on the side of principle of least surprise to most people.  I believe both are reasonable positions to take, but perhaps the principle of least surprise in this case, due to the ambiguity of end of line sequences, is a better choice than a pedantic reading of the BNF.

Alex, can you point to the CSV format description that your files are adhering to?  I am honestly interested since back when I wrote the package I looked for every definition I could find and tried to address as many of them as possible (hence the options).
Some text editors on Windows/MS-DOS will "corrupt customer data" simply by reading in and writing out a text file (they change \n to \r\n).  Can you provide more detail on what type of data this is (is it even ASCII/Unicode?) and why equating \r\n with \n corrupts the meaning of the data?
If there is a different package that satisfies your requirements then that is the right one to use.  I do not doubt it is more performant.  The standard csv package is quite old and predates Go 1.0.  I would likely write it differently today.

 I would never intentionally corrupt customer data like this and blame some paragraph jerkfest as the reason. This kind of reasonging is the reasoning of someone with pants up their armpits and star wars socks. A besserwisser. You can either do the obvious or you can argue current behavior is better, for me I don't care anymore I will never use such broken low quality garbage ever again. Corrupt customer data! Pfft!!

 I understand if you disagree. This issue would benefit more from a civil discussion on what the right behavior is. Please see https://golang.org/conduct
The idea to strip "\r" is not unprecedented. For example, in Javascript template literals, "\r\n" is always converted to "\n".
As for the behavior of csv.Reader. I don't have a strong opinion of what the "right" interpretation is. I recently re-wrote the implementation of Reader to be significantly faster. In terms of performance, it is faster to not fold "\r" into "\n" since you don't have to check for it. The new implementation does not parse CSV files on a rune-by-rune basis.

For what it's worth, as a user this seems like a strange change. CSV is usually used as a format for passing around data and it seems weird to start messing around with the data itself. I don't think it matters that "Everything else in Go uses \n as the line separator." This is just data passing through Go programs, not some aspect of Go itself.

@bourbonspecial, suppose we read this file with two records:
a,b,c<CR><LF>
a,"b1<CR><LF>
b2",c<CR><LF>

Everyone seems to agree with (at least no one is making an argument against) reporting the third field in both records as "c" not "c\r". Why then should we report the middle field of the second record as "b1\r\nb2" instead of "b1\nb2"? The quotes are there to allow the field to span multiple lines, not to say "all of a sudden s are important right here but nowhere else in the file".
I am genuinely interested to hear of a setting where stripping the  on lines 1 and 3 of that file is correct and appropriate and desirable but stripping the  on line 2 is incorrect, inappropriate, and undesirable. As I said above, I can't think of any.
There is also much weight to be given to preserving existing behavior. Inevitably every behavioral change, even when everyone agrees the old behavior was a mistake, breaks some users. If we can help them see that the old behavior was wrong, that goes a long way to making clear that we're not just breaking things without considering the consequences. Here I think many users will be broken who actually do not want this new behavior and will not agree that the new behavior is desirable. Hence my interest in hearing about concrete instances when a user would want the new behavior.
But I think I'm beating a dead horse at this point. Without a compelling example of why preserving this one  in that file is important, the scales clearly tip in favor of preserving existing behavior and therefore not breaking existing uses. I will send a CL.

CL sent. I also noticed while working on the CL that the earlier change made Reader incompatible with Writer. If you are writing with a Writer with UseCRLF set to true, it encodes "a\nb" as "a\r\nb", so that UseCRLF means every line ending in the output is CRLF. Reader correctly undid that in Go 1.9 so that data round-tripped. Reverting the earlier change preserves that property.

@rsc suppose you're processing some data that includes the following within a field "hello\r\nfriend", how would I preserve that sequence of characters if I have to read it through and write it out of the CSV package?
In your example, the difference  is that lines 1 and 3 \r\n denotes the end of a record whereas in line 2 \r\n is data in an escaped field.

@pborman fair enough.
My as-a-humble-user point of view is that there's some thought involved in "foo\r\nbar" == "foo\nbar", and if there's an opportunity to distance yourself from worrying about how other people might interpret those characters then it seems safer to not get involved. Totally accept that the risk of breaking existing programs is ever present so it's a trade off.

Assertions
When one uses escaping one expects the escaped data to survive parsing.
The original bug complains purely about escaped data being changed.
My 2p
If my shell decided to ignore escaping and altered data I had explicitly escaped I would consider it broken irrespective of the default line ending in use on my system.
The RFC detail for implementors about CRLF for line breaks being open to different line breaks is about line breaks delimiting records, it is not about escaped data.
So I would expect:
file = [header BR] record *(BR record) [BR]
header = name *(COMMA name)
record = field *(COMMA field)
name = field
field = (escaped / non-escaped)
escaped = DQUOTE *(TEXTDATA / COMMA / CR / LF / 2DQUOTE) DQUOTE
non-escaped = *TEXTDATA
COMMA = %x2C
CR = %x0D ;as per section 6.1 of RFC 2234 [2]
DQUOTE =  %x22 ;as per section 6.1 of RFC 2234 [2]
LF = %x0A ;as per section 6.1 of RFC 2234 [2]
BR = [CR] LF ;as per section 6.1 of RFC 2234 [2] and as per section 4.1.1. of RFC 2046 [3]
TEXTDATA =  %x20-21 / %x23-2B / %x2D-7E

I think a parser so generated would leave an escaped field containing \r\n unmodified.
When dealing with end users the de-facto standard for CSV is not the IETF RFC it is 'whatever Excel does'. I think (hope) most developers who have a need to use CSV wish to do so because their end users are using it in Excel or they are doing some database ETL process (in which case you still want the escaped \r\n preserved).

I trying to use Go for my csv processing tool.
go version go1.10.2 windows/amd64
My tool must merge some data change from one CSV file to one or more CSV files.
My tool first requirement is: if source file is not changed output CSV must look like it not changed too.
When I using standard module from encoding/csv, it breaks many new line characters everywhere!
So current solution is create own CSV reader and writer which will keep new line characters.
I'm new to Go, but I wonder why standard modules should have such limitations? If it's difficult to decide keep new line inside quotes or not, please give us an option or create separate function, please support both cases.
In real world there are a lot of CSV files in mixed format: someone uses UTF-8, someone prefers Shift-JIS, someone uses Mac OS and saves a file with \n, another guy saves his file from Windows with \r\n. I know  it's not easy but universal module which will support all these cases smartly will be super helpful. For this what we have now - it looks like incomplete toy...

@noangel This issue is closed.  We don't use issues for discussion.  Please see https://golang.org/wiki/Questions .  Thanks.
The short answer to your question is that it turns out that there are hundreds of variants of CSV and there are hundreds of different ways that they are used.  Supporting them all in the standard library would mean a package that is very difficult to understand and use correctly.  So we've decided going forward to restrict the package only to the format described in RFC 4180.  We understand that this means that the package can't work for everyone.  The code is there and available for modification for your specific use case.


Bugfix - assertValid null reference

This PR makes sure to check that the errors property isn't null before using it.
Whoops.

:+1:

:+1:


First insert takes a long time

I'm using moor^3.0.2. The first entry to the database in a table that has about 10k entries takes a long time, whereas it does not happen for the tables that have about 1k entries.
I'm facing this issue when trying to sync with the database on the backend. The calls are paginated to get at most 1000 entries on a single page. I'm batch inserting these entries, I'd also tried single entires. Both cases cause the same issue.
But once when the first insert is done everything works fine as it should.
Please let me know what can be done. Hope you reply soon!

Are you using moor_ffi or moor_flutter? Are you using batches to insert?

I'm using moor_ffi. I'm using batch insert as of now.
As I'm also writing the same entry to an FTS table, through a trigger and it does not update if I use the replace mode on the insert, I'm deleting the entry first and then inserting it. As in the code below.
Future<void> batchInsertProducts(List<Product> entries) async {
    return await batch((batch) {
      entries.forEach((entry) {
        batch.delete(db.products, entry);
        batch.insert(db.products, entry);
    });
});

Product is a class Product extends DataClass implements Insertable<Product>.
This is the method that I use to insert.
Thanks for the quick reply!

Sounds like some memory problem, I am afraid I can't help you.
Try updating moor and moor_ffi, not sure if that makes a difference.

The package version that I am using currently is moor: ^3.0.2 and moor_ffi: ^0.5.0. I'll upgrade them to the latest and try it again.
Yes, the behaviour varies on the simulator and the real device. Tested it just now.  Thanks for the advice!
I faced the issue on real devices. On the simulator (both Android and iOS), the wait time is pretty low, something that I wouldn't mind. This should mean that there is a memory problem, right? Is there something that I can do about this? Please let me know.

It seems like some memory problem but like I said, I have no idea. Just asking questions that might help solving this.
I learned today that sqlite can use some sort of temp file: https://github.com/simolus3/moor/issues/621#issuecomment-641318713
Maybe this can help on Android?

I updated the packages, it wasn't of much use.
So, I went ahead and implemented the suggested solution i.e., as mentioned in issue #621 and it was not of much help either. It stayed the same. Also, I think giving a temporary path is useful in a situation where the query to a database results in a large number of rows (I was able to test this as I had a table with 200k products and queried to get about 14k products in the result. This was not possible before without temp file). I'm not sure though.
Do you have any other suggestions? I'm unsure of what else could be done.

No, you probably have to wait for @simolus3's input.

Thanks for the suggestion! I'll test it out and let you know if it helps.

Hey, I split the work into multiple batches wrapped in a transaction but there is no improvement. Could this be due to something else? Is there any other thing that I could try?

Nothing obvious comes to mind, sorry. I would have to do some research to find out why this is happening. It might be that fts5 tokenization and indexing is just taking a long time on slow devices, but that's just speculation.
If this is causing frame drops for you, you could try running the operation in a background isolate. That won't make it any faster, but at least it doesn't block the main thread.

I'm running it on background isolate already, there is no frame drop issue, its the speed that's bothering. I'll see if I can change the way I'm entering the data. I'll add it here if I find some workaround.
Anyways, thank you for the suggestions!

Yeah I noticed also that first Insert in table takes around 10x times more than next inserts individually. Not sure why this is the case.


Update README.md

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I have described about Open Source and Open source Contribution in few lines in the repository. Hope it is useful.

👋  Hi, @SimranAnand1! Thanks for this contribution. Unfortunately, we're not currently looking for this kind of contribution right now. Please take a look at this section of the contributing guide for the types of contributions we are looking for.


Error fetching new dataset

I keep getting this error. Does anyone know what I am doing wrong?

Does the directory /tmp/serenata-data/ (used in your input lines 5 and 7) exists?

I followed this instructions: https://github.com/datasciencebr/serenata-toolbox#example-3-generating-datasets

Hum… got it where we got it wrong. What you called instructions are merely simple examples to show the package API — not a complete user guide. I'm sorry about that. Two possible (and non-exclusive) next steps here:

To fetch data either create this directory (mkdir /tmp/serenata-data) before running these snippets or replace /tmp/serenata-data in the code the your local directory in which you want the data to be downloaded to
Open a PR editing our text to let this clearer to other users ; )

Does that make sense?

I did use data/ and it worked. And data/ is the folder we get when we run setup. So I guess the simplest correction is to edit the text, changing /tmp/serenata-data for data/.
I will do that. Thanx, man.


Revert "Fix: package.json module field"

Reverts layer5io/sistent#634

@captain-Akshay  can you share the error here

@aabidsofi19


refactor: gh workflow

Main improvements in this PR:
This PR aims to refactor the GitHub workflow by using the native support for Docker rather than using a separate action.
I hereby confirm that I have:

[ ] Tested my code on my own computer for running the model
[x] Selected develop as a target branch
[ ] Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

It looks like this is more tricky to figure out than I imagined, so I'm going to abort.

Is this native Docker support a new feature?

Not anymore, but it was news at some point.

There has been some progress on this so the PR should be reopened.


Internal error is ignored

When return an echo.HTTPError, the Internal error should be logged but only the Message field sent to the client is actually getting logged

Hey, just an enthusiast here, not a maintainer. I found something strange when I was testing it. When I write echo returns like:
return &echo.HTTPError{
    Code: http.StatusInternalServerError,
    Message: err,
    Internal: err,
}

It just logs everything. Message has type interface{}, so it handles string and error differently. So, I don't know if it really helps, but doing something like:
return &echo.HTTPError{
    Code: http.StatusInternalServerError,
    Message: errors.New("public message"),
    Internal: fmt.Errorf("more private details: %w", err),
}

Could help your use case too.
It can also be done like this:
return echo.NewHTTPError(http.StatusInternalServerError, err).SetInternal(internalErr)


Clean up temporary clone paths by default

Description
Fixes #98 .
These changes allow git-xargs to clean up the temporary file paths where it clones repositories. By default, git-xargs will now delete the paths after processing the repo. If you wish to preserve your local clones, pass the new --keep-cloned-repositories flag.

TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

By default, git-xargs will now delete the temporary file paths where it clones your repositories in order to run commands on them. This should help prevent git-xargs from taking up too much space. If you wish to preserve local clone paths going forward, pass the new --keep-cloned-repositories flag.
Migration Guide

LGTM! (but not sure if my approval will count) edit: it did not

Thank you @Etiene! :raised_hands:

Hey @zackproser, thanks for taking the time and writing the PR. Looks good, thanks!

Thanks for reviews! Going to merge this in now.


feat: Update signup flow for global identity stack

Previously the list of available regions that user could sign up in was hardcoded in the code, with each region pointing to a specific url for the cell in that region that handled the sign up logic.
We have moved instead to a model with one global cell handling these requests, which then reaches out to the provided region to get the token.
This PR updates the code to contact that global cell and to pass the region as part of the signup request body.
It also adds the ability to override the signup url with a SIGNUP_ENDPOINT env var for testing purposes. Originally I had this as an additional cli flag, but then realized we may not want it to be viewable in the help docs to all users. I couldn't figure out how to not prevent flags from showing up in the help, so instead made this an env var.
TODO: Before merging update the commit to have BREAKING CHANGE at the end (see https://www.conventionalcommits.org/en/v1.0.0/#summary) so that it is obvious in the release history and bumps the version accordingly. Also add a note to the README that if you encounter an error update to the latest version.

I think this is ready to go, but I won't actually merge (and release) until I've confirmed the new signup stack is deployed and working.


Hacking Brainhack!

Project title:
Hacking Brainhack!
Project leader:
Maximilien Chaumon
Email:
<EMAIL_ADDRESS>Collaborators:
Yu-Fang Yang @ufangYang; Manuela Ruzzoli @MRuzzoli; Adrien Schramm; Alexandra Corneyllie; Svetlana Pinet
Brainhack Global 2022 Event:
BrainHack Donostia
Topic:
Diversity, inclusivity, equality, knowledge base and website design
What is the purpose of the project:
We're preparing a global MEG/EEG meeting next year in October with our non-profit conference organisation CuttingEEG. We call it CuttingGardens. It is made of "Gardens" that host their own local event, and connect together and with the global community via live sessions. We would like to create a platform similar to https://brainhack.org/global2022/ on which we could:    offer resources for applying Gardens, similar to what Brainhack has here.    collect Garden candidates via a submission form similar to what Brainhack has here for local events.    Display the catalog of tutorial, lectures, and other local events in a dynamic way, perhaps in a similar way as what Brainhack has here for projectsWe have a team of a handful places across the Americas, Europe, and Asia, willing to be a Garden. We'd like to facilitate more joining and think Brainhack is a great model!
Where can participants find key resources to work on this project:
Original BHG submission: https://github.com/brainhackorg/global2022/issues/52
What stage is the project on:
1
Required programming skills for the project:
Tasks for all levels
Background knowledge needed  on the topic:
No knowledge needed
Data to use:
Link to project repository:
https://github.com/CuttingGardens
Goals for Brainhack Donostia 2022:
We'd like to get a first draft or the website up and running. With key features (submission, visualization, roadmap for documents etc.) set up.    sort out and/or adapt applicable resources from here.    set up a submission form similar to what Brainhack has here for local events    Find a way to dynamically display search results like here for projects perhaps even showing this in a calendar, on a world map...
What will participants learn:
Okay, it's mostly soft skills:    Community    collaborative documentation    Git/GitHub    Jekll (https://jekyllrb.com/)    Hugo (https://gohugo.io/)
Number of collaborators:
3
Credit to collaborators:
You'll be credited on the webpage.
Type of project:
Documentation
Programming languages:
Web
Necessary git skills level for the project:
Basic (commit & push)
Modality:
documentation/event organisation
Software suites:

yes, sorry, it had a tiny difference in the title(!) so I did not recognize it as a duplicate.

no worries
will close this one then


gha: Add more flags for Ingress Conformance test

Relates: https://github.com/cilium/cilium/issues/31857

/ci-ingress

/test


Spurious report of 'test with the same name' in solutions with multiple projects

If I have two test projects both with the dotnet-test-nunit package installed, test discovery goes wrong - I get reports of "A test with the same name '..' already exists" even though the test name is in fact unique.
This only affects discovery - I can run all tests without problem, although when one of the affects tests fails, Test Explorer misattributes the failure to a different test. I can work around the problem by unloading projects so that only the one I'm working in right now is loaded, but this is not ideal.
I encountered this problem using .xproj projects compiling for the full .NET Framework. (I'm writing an ASP.NET Core 1.0 application, so I need to use .xproj projects, but I'm not targeting .NET Core.) I don't know if the same problem applies to projects that target .NET Core, but full framework .xproj projects are critically important for me since we use ASP.NET Core but require full .NET Framework features.
Steps to reproduce in VS 2015 with ASP.NET Core 1.0 preview2 tooling:

Create a new ASP.NET Core Web Application (.NET Framework) called WebApp

Add a .NET Class Library (.NET Core) called TestWebApp

In TestWebApp Modify frameworks section of project.json to use .NET Framework 4.61:
"frameworks": {
"net461": { }
}

In TestWebApp remove "NETStandard.Library": "1.6.0" from dependencies section of `project.json.

Add reference from TestWebApp to WebApp

Add NuGet packages NUnit (3.4.1) and dotnet-test-nunit (3.4.0-beta-2) to TestWebApp

In TestWebApp add "testRunner": "nunit" to `project.json

Add a test method to a class in TestWebApp

Build solution. Verify that the test appears in the Test Explorer. (Might need to quit and restart Visual Studio at this point.) So far so good.

Add a .NET Class Library (.NET Core) called Test2.

Make the same modifications to project.json as with TestWebApp to make this use the full .NET Framework.

Install the same NUnit and dotnet-test-nunit packages you installed in TestWebApp in Test2.

In Test2 add "testRunner": "nunit" to `project.json

Write a class with one test in Test2 with different class and method names than the one in TestWebApp

Rebuild. At this stage, I found that it was only looking for tests in TestWebApp and I had to quit and restart Visual Studio to get it to look for tests in both test libraries.

Note that only one of the tests shows up in Test Explorer. (For me, it's the one from the Test2 project). There's a surprising error in the Tests section of the Output panel:

------ Discover test started ------
========== Discover test finished: 0 found (0:00:00.095533) ==========
------ Discover test started ------
Discovering tests in 'C:\Users\Ian\Documents\Visual Studio 2015\Projects\WebApp\src\Test2\project.json' ["C:\Program Files\dotnet\dotnet.exe" test "C:\Users\Ian\Documents\Visual Studio 2015\Projects\WebApp\src\Test2\project.json" --output "C:\Users\Ian\Documents\Visual Studio 2015\Projects\WebApp\src\Test2\bin\Debug\net461\win7-x64" --port 12258 --parentProcessId 21036 --no-build]
Discovering tests in 'C:\Users\Ian\Documents\Visual Studio 2015\Projects\WebApp\src\TestWebApp\project.json' ["C:\Program Files\dotnet\dotnet.exe" test "C:\Users\Ian\Documents\Visual Studio 2015\Projects\WebApp\src\TestWebApp\project.json" --output "C:\Users\Ian\Documents\Visual Studio 2015\Projects\WebApp\src\TestWebApp\bin\Debug\net461\win7-x64" --port 12263 --parentProcessId 21036 --no-build]
A test with the same name 'TestWebApp.Class1.Test' already exists. This test is not added to the test window.
========== Discover test finished: 2 found (0:00:02.1412771) ==========

Notice the spurious report of a test with the same name as another that already exists.
I've attached a solution that exhibits this problem: WebApp.zip

I've put a repro at https://github.com/idg10/nunit-repro1

Thanks, I will take a look when I get a chance. If any other team members have time to triage this, I would appreciate it.

If we search google with quoted string "already exists. This test is not added to the test window.", this seems like issue with nunit exclusively.
This issue has been reported in VS adapter repo in different forms: e.g. https://github.com/nunit/nunit-vs-adapter/issues/82.

The problem is well understood wrt the nunit VS adapter, but may not be one we want to fix.
The issue is that VS and NUnit itemize tests differently. The problem is well described by the authors of Fixie wrt their own adapter: https://github.com/fixie/fixie/blob/master/src/Fixie.VisualStudio.TestAdapter/README.md  When I get a chance, I'll write something about this for our own docs.
In general, the problem only comes up with overloads of a test method or use of parameterized tests. In the case of parameterized tests, NUnit considers each set of arguments as a unique test while Visual Studio considers each of them as producing a new result for a single test. When I first wrote the adapter, the TestWindow guys at Microsoft suggested we change how NUnit looks at tests. We didn't. :-)
I haven't commented on this issue before because I don't have a clue whether any of this applies to the dotnet-test-nunit package. One of these days, I'm going to get familiar with it. :-)
It doesn't appear that this issue relates to either overloads or parameterized tests. OTOH, if the same test name is being returned to VS from two different assemblies, that could easily cause the problem. Another major difference between NUnit and VS is that VS expects test names to be unique. NUnit doesn't care. As an experiment, I once forced all my tests to have the same name. Everything ran perfectly in the console, except for the  fact that the output didn't make much sense to me. :-)
Question: Is the dotnet-test-nunit package also an adapter? Or is it simply called by a microsoft-provided adapter?

@CharliePoole it is hard to define the boundary between an adapter and something called by an adapter. There is no VSIX possible, but it is discovered if installed as a NuGet package and treated like an adapter. My understanding is that it is similar to the desktop framework NUnit Adapter in that VS runs a test process which communicates to our adapter. The difference is that dotnet-test-nunit is an executable in it's own right and communicates back to the test process via TCP, much like our agent and engine. It is further confused by the fact that this project can also run standalone as a console runner. The mode is determined by the command line arguments.
All that said, I have found that this adapter suffers from all the same issues as other adapters plus a few news ones because of the new interface/protocol.

Well, from a certain perspective it's not hard at all. :-)
Of course the generic term "adapter" has a broader meaning, but a VS test adapter has always been an assembly that is loaded by the TestExplorer and which implements ITestDiscoverer and ITestExecutor at a minimum.
Is the interface you use documented by MS somewhere? Eventually I want to spend some time getting familiar with it. If similar problems are  coming up, it leads me to suspect that we are doing the same things in different code, where maybe we don't have to.

The interface is documented, but not well, I think I sent you the links when I started the project, but don't have them handy. I will need to dig them up again.

Don't bother digging. If you sent it I'm sure I can fix it.

To be clear, there are no name collisions in the tests here. (Not in the repro I've produced, nor in the real project in which I originally encountered this.) Nor am I using parameterized tests.
The problem in this case is that when I have two different projects I get errors reporting that two tests have the same name when in fact they don't. So I'm not sure this is just another instance of the other problem you're describing.

Yes, there are two test projects in that solution with different names, different class names and different method names -- and yet this error occurs as if there is a name collision.

I was having the same problem and believe pull request #82 will fix it.


chore(release) 2.8.1 post-release

Steps required after the release of 2.8.1:

Bumping Rockspec and Meta versions
Changing rockspec protocol from git to http (see sister PR #8672 which modifies the release/2.8.x rockspec)
Manual update of the changelog to include 2.8.1 changes.

Another solution is to upgrade lualocks to version 3.8.0


Integration with Openshift Logging

Make sure that Janus is integrated with OpenShift logging.
User Story

As an administrator of a Janus instance
I want to be able to integrate with OpenShift logging or with Loki
So that I can easily debug Janus instance when something goes wrong.

parent epic: https://github.com/janus-idp/backstage-showcase/issues/229
Acceptance Criteria

[ ] When this feature is enabled (env variable/config option) logs are collected by OpenShift Logging or other Loki instance

Openshift Logging is naturally integrated with Janus IDP. Users just need to correctly filter the Kibana report and they will be able to monitor Backstage Backend logs.
Two possible filter are the namespace used by the Janus IDP installation or by image name.


JSX attribute types

I have a universal renderer where I can do something like:
<Tile width={35} height={26} x={475} y={78} radius={62}/>

And that works great and all the attributes are numbers.
However if a user does this:
<Tile width="35" height="26" x="475" y="78" radius="62" />

It's valid but all the types come in as strings.
Question: Can I specify certain attributes to be treated as Numbers during compilation?

Hmm.. we don't have the option right now as it is pretty specific. In the DOM we are used to everything being strings so we get away with it and JSX passes it straight through like that so we don't need any sort of special processing. It would also need to be handled on the spread side at runtime since we don't see all the attributes coming in that way. I could see how an option like this could be made/work just unsure about edge cases and it making sense.


Implement optional instance startup & upload progress reporting

with an initial implementation for the GCE backend

This is not a review of the code because no-one would trust me with that these days anyway, but the result looks :100:!

Example job with folded terminal output: https://staging.travis-ci.org/meatballhat/yolo-octo-adventure/jobs/723888


Have this project been abandoned?

Have this project been abandoned?
Hasn't been updated for a long time, and the major bug #319 has not been fixed yet.

same question

I just maintain a fork  of this at https://github.com/ian4hu/Clipy/releases , and released with fixed #319

@ian4hu thanks

Fingers crossed, @ian4hu, really happy to see things like search on your roadmap.

@ian4hu Have you tried messaging the maintainers of Clipy to see if they can add you to the project? @Econa77 @econa @jcw- @ericyahhh  @andrew-codechimp @thii @piamancini
Any help here?


Bump Dependencies

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3955221499

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3955221499
Status: failure


URGENT! fix broken build-image command due to incorrect mairadb path

Issue #, if available:
Description of changes:
./mwaa-local-env build-image command from the README instructions is broken because of incorrect mariadb path in the bootstrap.sh script. This fix updates the path with the correct processor architecture name as per mariadb path index.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I confirm running into the same issue and the fix working, thank you!

Closing as this is fixed in: https://github.com/aws/aws-mwaa-local-runner/pull/328


Request persistent storage

Related to #411

Does this only do this if/when notifications are enabled? I don't want it prompting people potentially for no reason. Best to scope it to where we need it.

Does this only do this if/when notifications are enabled? I don't want it prompting people potentially for no reason. Best to scope it to where we need it.

It didn't prompt me but I guess I missed the Firefox part:

Firefox requests permission from the user to use persistent storage. Chromium-based browsers give or deny persistence based on a heuristic to determine the importance of the content for the user. One criteria for Google Chrome is, for example, PWA installation.

So good catch, the prompt (and other browsers) wasn't on my mind.


function vm_is_running is not working

function vm_is_running is not working
i fix it:
def vm_is_running(self: "PyMemuc", vm_index: int = 0) -> bool:
    """Check if a VM is running

    :param vm_index: VM index. Defaults to 0.
    :type vm_index: int, optional
    :return: True if the VM is running, False otherwise
    :rtype: bool
    """
    _, output = self.memuc_run(["-i", str(vm_index), "isvmrunning"])
    if 'Not Running' in output: return False
    else: return True

You are welcome to make a pull request! Let me know if you need help.

Released as v0.6.0


Move button for adding extra invitees.

Should be next to the red removal button on first line and remain there with each new row added.

This was addressed in #29


rdf4j-workbench does not search repository templets in $RDF4J_DATA/templates

It would be helpful if rdf4j-workbench  webapp search new custom templates in  $RDF4J_DATA/templates/ and add to the list of possible types into the drop down  Type: field in the /create page.
Particularly I have config file for native and memory repositories with the Lucene index which I   'instantiate' by sending the .ttl file into System repository.

Unfortunately the way this is currently set up makes it difficult to do this - workbench requires not just a template file, but also an xsl file for each template - so it's hard to make this dynamic in the current design.
I agree though that it would a great enhancement if we could make this properly dynamic so people can just 'drop in' templates.


Unable to remove "luckperms" and related commands from default group.

Description
Luck Perms Version: v5.4.102
Minecraft Version: 1.20
Other conditions: I am using a Paper server and using EssentialsX 2.20.0 (no other plugins are used for this test)
Hello, I would like to ask something that has been causing me grief for the past few days.
My goal is to make it so that the default group has no commands what's so ever.
This is what I did in an attempt to do so:

Made myself OP
Execute /lp editor
Within the web editor, I have set * to FALSE
Made sure that I am in the default group
Applied the changes using the webapp's instructions
de-OP myself
Check my access (I couldn't see any bukkit/essentialsX commands, which is desirable, however I still see "lp", luckperms:*, and perm-like commands)

In case you are curious, I have also tried the following:

Log out and log back in
Restart the server
Specifically set luckperms (I have used the auto-complete from the webapp) to false
Used wildcards like luckperms.* and also made sure that wildcards are enabled in the config.yml file
Made sure that I have deopped myself (executed the deop command multiple times)
Personally inspected the DB file's tables that it was correct (I was using the Sqlite3 format, and yes, I have forced it to instantiate the sqlite db file before the test)
I tried executing /lp group default permission set * false directly on Minecraft's chat while at OP status
Set the weight of the group: weight.10

There is one bit of good news out of this issue though. Despite the lp commands still being visible, the auto-complete doesn't work, and executing commands like lp editor doesn't work if they are not on OP status. So thankfully this isn't an issue where anyone can change permissions.
Let me know if you have any questions.
Reproduction Steps

Made myself OP
Execute /lp editor
Within the web editor, I have set * to FALSE
Made sure that I am in the default group
Applied the changes using the webapp's instructions
de-OP myself
Check my access (I couldn't see any bukkit/essentialsX commands, which is desirable, however I still see "lp", luckperms:*, and perm-like commands)

Expected Behaviour
When * is set to false on the default user.
The correct behavior should be that no commands are visible/accessible (unless there are additional permissions in that group, but this wasn't added for my tests).
Server Details
Paper version git-Paper-17 (MC: 1.20) (Implementing API version 1.20-R0.1-SNAPSHOT) (Git: c287e92)
LuckPerms Version
v5.4.102
Logs and Configs
No response
Extra Details
No response

The root /lp command (and it's various aliases) have no permission associated with it, and will always be runnable. However, unless the player has permissions for a subcommand, it simply returns the LP version.
It's worth noting that (with a few, plugin-defined exceptions), all permissions default to false anyways. Setting * to false on default usually causes more problems than it solves, and we generally discourage it. Plugins can explicitly declare a permission to default to everyone (which LP respects), but this is rare, and is much better handled by setting that specific permission to false.

Okay, if I'm interpreting this correctly, its not best practice to be excluding * from default, and /lp can't be excluded normally from LuckPerms.
However, that raises another question. If /lp is not allowed to be hidden, how does the LuckPerms tool handle the use-case of a regular user only seeing the commands assigned to them (e.g. A user only has access to /sethome, /home, and /delhome).
I've tried looking at the Wiki and guides online to do so. The only leads are some variation of explicitly excluding all commands' permissions, and include commands that the admin wants on default (or some other group that a regular user is assigned to). Do we just accept that luckperms commands can be visible for regular players?
I would like to hear your thoughts on this.

(correctly written) plugins will hide their commands if users do not have permission to use them. luckperms itself does not control this. luckperms does hide its subcommands if you dont have permission to use them, but since there is no permission for just /lp, luckperms does not hide it as the player is allowed to run that command.

Dang, that's unfortunate. I was kinda hoping to make a clean command interface on my MC server.
I guess this may or may not be an issue from certain people's perspectives.
As a little suggestion for the dev team, would it be possible to make an option in the config.yml where only OP-ed users in a server can see and use /lp?
That way it gets around the issue of having Admins try to outright disable luckperms.* or * on their permission settings for default, and allowing Admins to have an easy way to hide luckperms from regular users.
Just something for you guys to consider.


fixes #1522 upgrade 1.6.x server TLS version to 1.2

@stevehu will this affect backwards compatibility?

No. It should be backward compatible. All clients are supporting TLSv1.2 and TLSv1.3.


ABE Automation MVP

Automation Logic

When submission is in Submitted status

If record is found in IDADATA

If there is existing classification in IDADATA

Update submission to Existing classification status

Else

Update SPOT_CHECK_PERCENT of submission to Spot check status
Otherwise if submission has IDA_CATEGORY_ID_LOOKUP_id

Update submission to Recorded

When submission is in Recorded status

If record is found in IDADATA

If record has have IDA_CATEGORY_ID

If record IDA_CATEGORY_ID does not match submission IDA_CATEGORY_ID_LOOKUP_id

Update submission to Existing classification status

Else

Update IDA_CATEGORY_ID, LAST_MODIFIED_BY, LAST_MODIFIED_DATE in IDADATA for record
Generate a new IDA_APP_NUM if it does not have one.

@hshaosf can you review these updates? can't add you as a reviewer - probably because you create the pr?

@josh-chou  LGTM! 👍

@hshaosf can you review these updates? can't add you as a reviewer - probably because you create the pr?

@josh-chou  LGTM! 👍


Apply noexcept to appropiate std::move constructors

I did some brief static analysis with clang-tidy and found some code improvements (a reason I suggested adding basic clang-tidy checks). Mainly it adds noexcepts which can make certain STL constructs able to use their move constructors. It also removed a useless std::move in the move constructor for src/error.cp since the base class std::exception apparently does not have a move constructor.

Wow, the first PR 🎉  -- thanks Aaron!

(I'm going to play with this clang-tidy thing soon, no worries.)


Move schema generation up from HCatalog

Moved schema generation to be generally available for all input and output tables for HDINSIGHT activities inside ADF

Can one of the admins verify this patch?

Hi @oburlacu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

jenkins, test this please

@azuresdkci add to whitelist


fix(infrastructure): point all tests to es6 files for accurate test coverage

Test coverage was inaccurate (and very low), since the coverage framework was looking at the package.json main files.
This PR changes the test files to only import from ES6 files. It also performs an npm run clean before running the unit tests. This will force istanbul to use the index.js ES6 files instead.
Before and after pics attached:

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   98.78%   98.78%
=======================================
  Files          18       18
  Lines         661      661
  Branches       62       62
=======================================
  Hits          653      653
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10157f8...8d9a912. Read the comment docs.


HCX-2 Notify HOMS about task events

I think it's better to move logic of getting task id and event name from HOMS class to to TaskNotifier.
Like
    String taskId    = task.getId()
    String eventName = task.getEventName()

    homs.sendTaskEvent(taskId, eventName)


Fix for BatchReadOnlyTransaction check

I have a weird case of using BatchReadOnlyTransaction, please check f7 testcase.
I guess the reason is BatchReadOnlyTransaction.Close and ReadOnlyTransaction.Close are different.
https://github.com/googleapis/google-cloud-go/blob/main/spanner/batch.go#L246-L251
So, I added BatchReadOnlyTransaction.Close to close method list.
(I don't have confidence on my changes.)

@tenntenn @sinmetal
(I'm not sure the actual owner. I refered to the latest PR https://github.com/gcpug/zagane/pull/45)
Please review this PR.

Let me close this PR. Feel free to pick my commit. 🙏


Qs regarding the sampling timestamps?

Hi @chensong1995, thanks for your excellent work. If I understand correctly, the entire DeblurSR pipeline involves first predicting the values of keypoints, followed by using a spiking representation for regression. Is that right?
Regarding the training of DeblurSR and E-CIR, I have a question: do you impose any additional constraints on the prediction of the keypoints? From my perspective, the ground truth (GT) for training E-CIR/DeblurSR is not the keypoints' values, but rather the additional timestamps after regression.  For example, the GT timestamps are [0,3,6,9,12] but the predicted keypoints timestamps are [0,2,4,6,8,10,12].
This makes me wonder, "Can the network effectively learn to predict the keypoints accurately?"
I would greatly appreciate your insights on this. Thank you!

Hi chenkang455,
Thanks for your interest in our work and sorry for my late reply! I somehow missed this message.

If I understand correctly, the entire DeblurSR pipeline involves first predicting the values of keypoints, followed by using a spiking representation for regression. Is that right?

Your understanding is accurate.

Regarding the training of DeblurSR and E-CIR, I have a question: do you impose any additional constraints on the prediction of the keypoints?

The only constraint is that the keypoints should be an increasing sequence within the exposure interval.

From my perspective, the ground truth (GT) for training E-CIR/DeblurSR is not the keypoints' values, but rather the additional timestamps after regression. For example, the GT timestamps are [0,3,6,9,12] but the predicted keypoints timestamps are [0,2,4,6,8,10,12]. This makes me wonder, "Can the network effectively learn to predict the keypoints accurately?"

This is a very good comment with a lot of insights! Thanks for raising the question. I would like to clarify that the keypoints do not have "ground truth" per se. As such, we cannot judge the keypoint predictions by "accuracy". In both E-CIR and DeblurSR, the deblurring metrics are used as indirect measurements of the keypoint prediction quality.
I hope this helps! Let me know if you have additional concerns.

Thank you for your detailed response! I have figured it out.😀😀


WIP: Add LDAPIdentityProvider.spec.groupSearch.userAttributeForFilter

Addresses #1533.
Release note:
TBD

I manually tested the code committed so far on this WIP PR and it works.
Next, need to write some integration tests, which:

Needs to work when run locally after using prepare-for-integration-tests.sh.
Needs to work in CI on Kind clusters with the openldap server running in the same cluster.
Needs to work in CI when run against JumpCloud's LDAP, or needs to be skipped in that case.

Integration tests added!


New Process: Create INI file

The INI file should be created by the NF pipeline automatically and then used to infer the actual pipeline.

Doesnt make that much sense actually.


BPM180 SeaLevel Pressure

Hi,
would it be possible to add the Altimate corrected Pressure value called SeaPressure
here is the RAW log Data:
`
stateChange sonoff.0.TH16_Wohnzimmer.BMP180_Pressure: {"val":963.4,"ack":true,"ts":1521291321999,"q":0,"from":"system.adapter.sonoff.0","lc":1521291321999}
sonoff.0 | 2018-03-17 13:55:22.007 | debug | stateChange sonoff.0.TH16_Wohnzimmer.BMP180_Temperature: {"val":32.3,"ack":true,"ts":1521291321998,"q":0,"from":"system.adapter.sonoff.0","lc":1521291321998}
sonoff.0 | 2018-03-17 13:55:21.999 | debug | stateChange sonoff.0.TH16_Wohnzimmer.AM2301_Humidity: {"val":37.6,"ack":true,"ts":1521291321996,"q":0,"from":"system.adapter.sonoff.0","lc":1521291200850}
sonoff.0 | 2018-03-17 13:55:21.998 | debug | stateChange sonoff.0.TH16_Wohnzimmer.AM2301_Temperature: {"val":23.1,"ack":true,"ts":1521291321993,"q":0,"from":"system.adapter.sonoff.0","lc":1521291321993}
sonoff.0 | 2018-03-17 13:55:21.993 | debug | [TH16_Wohnzimmer] Received: tele/sonoff/SENSOR = {"Time":"2018.03.17 13:55:17","AM2301":{"Temperature":23.1,"Humidity":37.6},"BMP180":{"Temperature":32.3,"Pressure":963.4,"SeaPressure":1004.4},"TempUn
sonoff.0 | 2018-03-17 13:55:21.934 | debug | stateChange sonoff.0.TH16_Wohnzimmer.Wifi_RSSI: {"val":54,"ack":true,"ts":1521291321927,"q":0,"from":"system.adapter.sonoff.0","lc":1521291200779}
sonoff.0 | 2018-03-17 13:55:21.934 | debug | stateChange sonoff.0.TH16_Wohnzimmer.POWER: {"val":true,"ack":true,"ts":1521291321927,"q":0,"from":"system.adapter.sonoff.0","lc":1521290594538}
sonoff.0 | 2018-03-17 13:55:21.928 | debug | stateChange sonoff.0.TH16_Wohnzimmer.Vcc: {"val":3.418,"ack":true,"ts":1521291321925,"q":0,"from":"system.adapter.sonoff.0","lc":1521291200776}
sonoff.0 | 2018-03-17 13:55:21.924 | debug | [TH16_Wohnzimmer] Received: tele/sonoff/STATE = {"Time":"2018.03.17 13:55:17","Uptime":"0 00:20:15","Vcc":3.418,"POWER":"ON","Wifi":{"AP":1,"SSId":"CM","RSSI":54,"APMac":"60:45:CB:68:E8:00"}}
`
greets
downset

Please test https://github.com/ioBroker/ioBroker.sonoff/commit/f0b6cdc674f1f1449ed9d5486813422086bb64f4
2.0.2

It`s working,
Thank you very much.
feel free to contact me if you need any Log data or something else.
Greets
downset


Parsed Lists Errors (Missing)

It seems to happen frequently that the parsed lists are being removed.
Not sure if this is on purposes but it's hard to know whether the list has been removed permanently or temporarily.

I recently changed a great deal of the way the parser processes, and I gave the parsed directory a "clean slate" so that the ALLPARSEDLIST doesn't end up with bad entries,
I also changed it so that the parsed file will not be deleted if there is no update to it.

That's great to hear, have those changes been made currently or will be soon implemented?

already made,,,
I've been making changes directly on the live branch,,,
the way my script works, I was having trouble testing it with a dev branch,,, and I even tried having a test repo.
Most of the kinks are worked out now,, but it has a small way to go to be perfect


matlab package: autogenerate docs from Octave texinfo

@catch22 Here's a utility from Symbolic that I use to generate proper matlab-style docs from texinfo.

In this PR, I hack the two-blank-lines rule into the texinfo: this does effect how help doctest looks in Octave: it adds two blank lines instead of one after each example...

Alternatively, I could just use sed in the Makefile to do this on a temporary copy file during conversion, which would leave the Octave version untouched...

What do you think?  HTML output is unaffected by either approach.

Many thanks for the work. I think I'd prefer option 2, to avoid us confusing users into thinking that the
%% @ifinfo
%% @*
%% @end ifinfo

syntax is required to make doctest work. What do you think?

very good point: I had completely forgotten about people reading the .m source to learn how to do tests in texinfo (and was thinking only about people reading "help doctest").
I will try the other approach.

ok I reverted the doc changes and instead add the extra lines while converting.

thanks!

@catch22, I'll merge this unless you have objections?  It may not be the nicest code (and its sort of duplicated here and in Symbolic pkg) but its not core stuff, just used for packaging so my standards are lower :)

absolutely, please go ahead!
On Thu, Oct 29, 2015 at 19:46 Colin Macdonald<EMAIL_ADDRESS>wrote:

@catch22 https://github.com/catch22, I'll merge this unless you have
objections? It may not be the nicest code (and its sort of duplicated here
and in Symbolic pkg) but its not core stuff, just used for packaging so my
standards are lower :)
—
Reply to this email directly or view it on GitHub
https://github.com/catch22/octave-doctest/pull/114#issuecomment-152358769
.


Wrap local search and intensify at each iteration

This PR:

[x] Closes #98.
[x] Partially addresses #107 by wrapping the LocalSearch object and prepending all extension module names with an underscore.

@leonlan let us know when you want this to be reviewed again!

I'm going to make a new issue about the "overlap degrees" thing. Instead of a degree in [0, 360], I think it makes much more sense to use a percentage [0, 1.0]. We can translate that back to a degree/CircleSector integer internally, but then users don't have to understand that there's a circle sector thing around at all. It's just "how much should routes overlap before we consider them in the intensification routine".


Installation problem

Describe the bug
When I try to install discordLevelingSystem, a error message appear, and I don't know what cause this, I laready tried to change python version, and nothing changed, tried --upgrade (still nothing), so I don't know what to do. (yes discord is installed on my computer ( I used pip install discord --upgrade), but it still say ModuleNotFoundError: No module named 'discord' ).
To Reproduce
pip install discordLevelingSystem
Traceback if any
Collecting discordLevelingSystem (from -r .\requirements.txt (line 7))
  Using cached discordLevelingSystem-1.2.0.tar.gz (58 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [21 lines of output]
      Traceback (most recent call last):
        File "C:\Users\ender\AppData\Local\Programs\Python\Python310\lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "C:\Users\ender\AppData\Local\Programs\Python\Python310\lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "C:\Users\ender\AppData\Local\Programs\Python\Python310\lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "C:\Users\ender\AppData\Local\Temp\pip-build-env-_ab12cde\overlay\Lib\site-packages\setuptools\build_meta.py", line 341, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "C:\Users\ender\AppData\Local\Temp\pip-build-env-_ab12cde\overlay\Lib\site-packages\setuptools\build_meta.py", line 323, in _get_build_requires
          self.run_setup()
        File "C:\Users\ender\AppData\Local\Temp\pip-build-env-_ab12cde\overlay\Lib\site-packages\setuptools\build_meta.py", line 487, in run_setup
          super(_BuildMetaLegacyBackend,
        File "C:\Users\ender\AppData\Local\Temp\pip-build-env-_ab12cde\overlay\Lib\site-packages\setuptools\build_meta.py", line 338, in run_setup
          exec(code, locals())
        File "<string>", line 2, in <module>
        File "C:\Users\ender\AppData\Local\Temp\pip-install-fghi23jk\discordlevelingsystem_8e83c0b019e441568f860ceb21d4a8fd\discordLevelingSystem\__init__.py", line 12, in <module>
          from .announcement import LevelUpAnnouncement
        File "C:\Users\ender\AppData\Local\Temp\pip-install-fghi23jk\discordlevelingsystem_8e83c0b019e441568f860ceb21d4a8fd\discordLevelingSystem\announcement.py", line 28, in <module>
          from discord import AllowedMentions, Embed, Member as DMember
      ModuleNotFoundError: No module named 'discord'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Required Checklist

[x] I am using discord.py 2.0 or higher
(N/A) I am using discordLevelingSystem 1.2.0 or higher
(N/A) I have the required intents enabled

Version Info
What's the exact version of discordLevelingSystem/discord.py are you using?

discord.py: pip show discord.py Name: discord.py Version: 2.2.3 Summary: A Python wrapper for the Discord API Home-page: https://github.com/Rapptz/discord.py
discordLevelingSystem: N/A

This has been fixed as of v1.2.1. Thanks for reporting the issue! 🙂


Can't use cert-manager with istio in Multi Cluster deployment

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hello guys, I have successfully deployed a multi-cluster in different networks. In the next guides, I have successfully issued certificates and configured HTTPS connections with Istio and cert-manager(using this link). So, this configuration is working:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
spec:
  profile: "default"
  hub: gcr.io/istio-release
  meshConfig:
    # Change the following line to configure the trust domain of the Istio cluster.
    trustDomain: cluster.local
  values:
    global:
      # Change certificate provider to cert-manager Istio agent for Istio agent
      caAddress: cert-manager-istio-csr.cert-manager.svc:443
  components:
    pilot:
      k8s:
        env:
          # Disable istiod CA Server functionality
        - name: ENABLE_CA_SERVER
          value: "false"
        overlays:
        - apiVersion: apps/v1
          kind: Deployment
          name: istiod
          patches:
            # Mount istiod serving and webhook certificate from Secret mount
          - path: spec.template.spec.containers.[name:discovery].args[-1]
            value: "--tlsCertFile=/etc/cert-manager/tls/tls.crt"
          - path: spec.template.spec.containers.[name:discovery].args[-1]
            value: "--tlsKeyFile=/etc/cert-manager/tls/tls.key"
          - path: spec.template.spec.containers.[name:discovery].args[-1]
            value: "--caCertFile=/etc/cert-manager/ca/root-cert.pem"
          - path: spec.template.spec.containers.[name:discovery].volumeMounts[-1]
            value:
              name: cert-manager
              mountPath: "/etc/cert-manager/tls"
              readOnly: true
          - path: spec.template.spec.containers.[name:discovery].volumeMounts[-1]
            value:
              name: ca-root-cert
              mountPath: "/etc/cert-manager/ca"
              readOnly: true
          - path: spec.template.spec.volumes[-1]
            value:
              name: cert-manager
              secret:
                secretName: istiod-tls
          - path: spec.template.spec.volumes[-1]
            value:
              name: ca-root-cert
              configMap:
                defaultMode: 420
                name: istio-ca-root-cert

But when I try to add multi-cluster configuration here (change values.global to this):
  values:
    global:
      # Change certificate provider to cert-manager Istio agent for Istio agent
      caAddress: cert-manager-istio-csr.cert-manager.svc:443
      meshID: mesh
      network: do-sfo3-main-dev
      multiCluster:
        clusterName: do-sfo3-main-dev

I have these errors:
istioctl install -f /tmp/do-sfo3-main-dev_operator.yaml
This will install the Istio 1.20.0 "default" profile (with components: Istio core, Istiod, and Ingress gateways) into the cluster. Proceed? (y/N) y
✔ Istio core installed
✔ Istiod installed
✘ Ingress gateways encountered an error: failed to wait for resource: resources not ready after 5m0s: context deadline exceeded
  Deployment/istio-system/istio-ingressgateway (containers with unready status: [istio-proxy])
- Pruning removed resources                                                                                Error: failed to install manifests: errors occurred during operation

And:
kubectl logs istio-ingressgateway-bbdbfd6bf-ncqv2 -c istio-proxy -n istio-system
...
2023-12-21T14:24:19.226601Z	info	ads	ADS: new connection for node:istio-ingressgateway-bbdbfd6bf-ncqv2.istio-system-107
2023-12-21T14:24:19.869816Z	info	ads	ADS: "@" istio-ingressgateway-bbdbfd6bf-ncqv2.istio-system-107 terminated
2023-12-21T14:24:19.870105Z	warning	envoy config external/envoy/source/extensions/config_subscription/grpc/grpc_stream.h:152	StreamSecrets gRPC config stream to sds-grpc closed: 2, failed to generate secret for default: failed to generate workload certificate: create certificate: rpc error: code = Unauthenticated desc = request authenticate failure	thread=15
2023-12-21T14:24:24.740590Z	info	ads	ADS: new connection for node:istio-ingressgateway-bbdbfd6bf-ncqv2.istio-system-108
2023-12-21T14:24:24.901789Z	info	ads	ADS: new connection for node:istio-ingressgateway-bbdbfd6bf-ncqv2.istio-system-109
2023-12-21T14:24:25.112634Z	warning	envoy config external/envoy/source/extensions/config_subscription/grpc/grpc_stream.h:152	StreamSecrets gRPC config stream to sds-grpc closed: 2, failed to generate secret for default: failed to generate workload certificate: create certificate: rpc error: code = Unauthenticated desc = request authenticate failure	thread=15
2023-12-21T14:24:25.113049Z	info	ads	ADS: "@" istio-ingressgateway-bbdbfd6bf-ncqv2.istio-system-108 terminated
2023-12-21T14:24:25.239934Z	info	ads	ADS: "@" istio-ingressgateway-bbdbfd6bf-ncqv2.istio-system-109 terminated
2023-12-21T14:24:25.240182Z	warning	envoy config external/envoy/source/extensions/config_subscription/grpc/grpc_stream.h:152	StreamSecrets gRPC config stream to sds-grpc closed: 2, failed to generate secret for ROOTCA: failed to generate workload certificate: create certificate: rpc error: code = Unauthenticated desc = request authenticate failure	thread=15

It's a bug or i'm doing something wrong?
Version
istioctl version
client version: 1.20.0
control plane version: 1.20.0
data plane version: 1.20.0 (1 proxies)

kubectl version
Client Version: v1.28.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.2

helm version --short
v3.13.1+g3547a4b

Additional Information
I'm not sure it's safe request.

It can be interesting. From this command kubectl logs cert-manager-istio-csr-7b598bf787-t8kp4 -n cert-manager i have this logs:
2023-12-21T15:09:01.072739Z	error	klog	grpc-server "msg"="failed to authenticate request" "error"="could not get cluster do-sfo3-main-dev's kube client" "serving-addr"="<IP_ADDRESS>:6443"

The issue was solved in this answer


Update upload-artifact version

Upload artifact v3 is deprecating on November 30th so we are upgrading to V4
Related: https://github.com/actions/upload-artifact

The workflow works as expected:
https://github.com/ClickHouse/clickhouse-tableau-connector-jdbc/actions/runs/11723419401


DSD-333: Style Guide Forms

Fixes JIRA ticket DSD-333
This PR does the following:

Add Forms page to Style Guide

How has this been tested?

local build of DS Storybook

Checklist:

[x] I have updated the Storybook documentation accordingly.
[x] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

@EdwinGuzman This PR is reaedy for review, but the Tugboat build keeps failing.  Not sure why.  Like Netlify, is there a way to re-trigger the build on Tugboat?

Tugboat has finished building the preview for this pull request!
Link:

https://pr662-wyvngr5l4nfihilijyq2tle3rwp2rz88.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/612e685e08cf475e6f598074


use chi

use chi
fix logging of a message

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#31  👈 (View in Graphite)
#30
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Casper Wallet announcement

What is the feature?
A dialog announcing Casper Wallet. The text in the dialog:
Header: "Move to Casper Wallet"
Body: "Signer will be going away soon and it’s time to move. Make the switch to Casper Wallet in minutes.”
Button: Get Started
An X button in the top corner to close the notification (this should already be part of the pop up component)
Why is it an improvement?
Encourages Signer users to migrate to Casper Wallet to enjoy a more secure, intuitive wallet experience.
Any further details?
The dialog will display every time the user unlocks Signer.

@adammake After my analysis I have extended the scope of this task to add support for another flow.

When the User created a new vault and tries to create a new account it will also show the deprecation message. The reason for this is to prevent the user to start using the Signer account before knowing that Casper Wallet is available.

@adammake I have already implemented that here are recordings of the initial scenario of the OP, and also the second scenario from my proposal above.
Scenario 1
https://user-images.githubusercontent.com/739075/235126943-141515c2-af8f-4e2f-8b22-235a5e55bbb1.mov
Scenario 2
https://user-images.githubusercontent.com/739075/235126957-ead02b5e-8a7f-40ed-ba67-eee7d91afe5c.mov
I'm also attaching the build for QA to start testing
signer-453-casper-wallet-announcement.zip


ImportWarning: sys.meta_path is empty

When executing a runipy -v I get a weird looking print-out with an ImportWarning:
$ runipy -v
0.1.5-py3.4.egg
sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/dev/null' mode='w' encoding='UTF-8'>
/Users/klay6683/miniconda3/envs/py34/lib/python3.4/importlib/_bootstrap.py:2150: ImportWarning: sys.meta_path is empty

Environment: runipy master, installed from github, with python setup.py install into a python 3.4 conda environment.

That is weird. Thanks for sharing. I'll take a look at it.

Seems this only happens in Python 3.

The ImportWarning appears to be due to a bug in Python 3.4.3. I can only reproduce it by installing the package with python setup.py install (can't reproduce by pip installation). This has been corrected in Python 3.5. See more details here. ( https://bugs.python.org/issue21049 )

The ResourceWarning will require more looking into, but occurs with a variety of possible installs in Python 3.

Confirmed that pip install on py34 does not show the ImportWarning, thanks.

Glad that helps. I think the best that can be hoped for is that these warnings are suppressed entirely. I'll look into something to help this tomorrow.

I agree with suppressing the /dev/null FH warning, would be cool to get that in.

After doing a little investigation, I suspect this line ( https://github.com/ipython/ipython/blob/a33a0632c00b604683aab8454983716823550407/IPython/utils/io.py#L75 ) is causing us trouble. I don't have an obvious fix, at present.

So, I have come up with a patch for ipython, which will fix the ResourceWarning. See here ( https://github.com/ipython/ipython/pull/8929 ). I have applied this patch myself and verified that it fixes the problem.

I am going to close this as I feel I have done all I can to resolve this at present. Feel free to give the patch a shot if you wish ( https://github.com/ipython/ipython/pull/8929 ). I'll try my best to get it merged in mainline. I have also added a backport of that patch to the iPython 3.x line ( https://github.com/ipython/ipython/pull/8930 ). Bug fixes are no longer being accepted to iPython 2.x so there is nothing we can do there.

This aforementioned patch has been merged into iPython's 4.x. It should be available in the next release.

Nice, thanks!

Also, the 3.x patch was accepted and appears in the release 3.2.3. There is no release for the 4.x fit at present.


Build updates

Build updates:

Migrate gradle build scripts to Kotlin
Update JUnit to JUnit Jupiter
Target Java8

Updated build jdk from oraclejdk to openjdk as it couldn't be installed


Add vesting accounts to hard fork test

Add vesting accounts to hard fork integration test.

timed1 fully vests before the hard fork
timed2 has cliff before the hard fork
timed3 has cliff at hard fork

Check that total, locked, liquid balances all comport with the vesting schedule.
The hard fork test is not part of PR CI, it's in the nightly CI. Here's a successful run from an earlier draft PR: https://buildkite.com/o-1-labs-2/mina-o-1-labs/builds/30221#018a6660-58c9-440c-9638-6b89876c96ce
Closes #13811.

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!approved-for-mainnet


Add support for templating Node.Hostname in docker executor

At the moment we can only use NodeID as a template variable. The hostname is better for some kind of application and it's also more flexible and human readable. See #1951 or moby/moby#32561 for related proposals.
This PR is built on the previous work done by @gianarb

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "feature/template-node-hostname" git@github.com:mion00/swarmkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353841144
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

LGTM
Please squash the commits before merging

LGTM


Change Test.Cardano.Ledger.Generic.Proof so that there is no more Crypto Evidence.

Proof no longer takes an Evidence parameter (choosing which crypto, either Standard or Mock). Everything now runs in Standard Crypto. This simplifies many things, because we no longer need to pattern match against (Alonzo _) but just Alonzo (for example).
Description

Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[ ] Self-reviewed the diff

So I ran a bunch of commands like
sd "(Shelley)" "Shelley" $(git ls-files . -- *.hs)
which turned out to be no-ops since "(" and ")" have special meaning in regular expressions.
I think it s fixed now.


Meteor Demo CollectionFS

https://github.com/comerc/meteor-demo-cfs

.. using coffeescript, jade and less

.. using coffeescript, jade and less

Yes! It is true way. 😎


SyntaxError: Failed to execute 'querySelector' on 'Element': '#react-aria9261322746-:r5:' is not a valid selector.

Hi, I got the error SyntaxError: Failed to execute 'querySelector' on 'Element': '#react-aria9261322746-:r5:' is not a valid selector.
I'm following the steps on Next.JS Integration with new NextJS Project
This happens after clicking on singleton content type, ex: http://<IP_ADDRESS>:2700/keystatic/singleton/blog

Nvm, i didnt put inside /pages/api


Guarantee order of creators on mappers and in factory method parameters

This will require a 0.4.3 once its merged

You mean 0.4.2?

im in the future
(yea 0.4.2)


Handle unpadded protected header in PackWireFormat::get_recipient_keys

I believe this only affects connection establishment when using an Askar wallet together with multi-tenant wallets.
Fixes #1323

Codecov Report

Merging #1324 (b22dd18) into main (89324e2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1324   +/-   ##
=======================================
  Coverage   95.43%   95.43%
=======================================
  Files         476      476
  Lines       28949    28949
=======================================
  Hits        27628    27628
  Misses       1321     1321

@andrewwhitehead  It work well with regards to https://github.com/hyperledger/aries-cloudagent-python/issues/1323. Thanks!

@TimoGlastra I think Indy-SDK must be padding the base64-encoded protected header, which seems to be counter to the JWE spec but is generally accepted.


UUID service

same problem as described in
https://bitbucket.org/gregorwolf/dockernwabap750/issues/3/start-service-uuidd

Can be solved by adding this line, eg. as line 3 in DockerFile:
RUN mkdir /run/uuidd && chown uuidd /var/run/uuidd && /usr/sbin/uuidd
Check: https://github.com/nzamani/sap-nw-abap-trial-docker
Best Regards, Søren Hansen


Too large factor for unrolling error when auto tuning model for android arm cpu

I am tuning a model following the Tutorials of Auto-tuning a convolutional network for ARM CPU.
Too large factor for unrolling error happened when tuning.

Please open a new thread on https://discuss.tvm.ai/


DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead at VisualizerPlugin.apply

i am doing SPFx upgrade to 1.9.1 and also i am doing Webpack upgrade to 4. Please help me to resolve the warning for mentioned error.
DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead

Same issue after updating to webpack 4:
DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead     at VisualizerPlugin.apply (/Users/mgold/workspace/codon/node_modules/webpack-visualizer-plugin/lib/plugin.js:44:22)     at webpack (/Users/mgold/workspace/codon/node_modules/webpack/lib/webpack.js:51:13)     at processOptions (/Users/mgold/workspace/codon/node_modules/webpack-cli/bin/cli.js:272:16)     at /Users/mgold/workspace/codon/node_modules/webpack-cli/bin/cli.js:364:3     at Object.parse (/Users/mgold/workspace/codon/node_modules/webpack-cli/node_modules/yargs/yargs.js:567:18)     at /Users/mgold/workspace/codon/node_modules/webpack-cli/bin/cli.js:49:8     at Object.<anonymous> (/Users/mgold/workspace/codon/node_modules/webpack-cli/bin/cli.js:366:3)     at Module._compile (internal/modules/cjs/loader.js:959:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)     at Module.load (internal/modules/cjs/loader.js:815:32)     at Function.Module._load (internal/modules/cjs/loader.js:727:14)     at Module.require (internal/modules/cjs/loader.js:852:19)     at require (internal/modules/cjs/helpers.js:74:18)     at Object.<anonymous> (/Users/mgold/workspace/codon/node_modules/webpack/bin/webpack.js:156:2)     at Module._compile (internal/modules/cjs/loader.js:959:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)     at Module.load (internal/modules/cjs/loader.js:815:32)     at Function.Module._load (internal/modules/cjs/loader.js:727:14)     at Function.Module.runMain (internal/modules/cjs/loader.js:1047:10)     at internal/main/run_main_module.js:17:11
Using:
"webpack": "4.41.2",
"webpack-cli": "3.3.10",
"webpack-dev-server": "3.9.0",
"webpack-merge": "4.2.2",
"webpack-notifier": "1.8.0",
"webpack-visualizer-plugin": "0.1.11",
"workbox-webpack-plugin": "4.3.1",
"write-file-webpack-plugin": "4.5.1",

This package is no longer maintained. If you need it I forked this package to use it with webpack 4 and 5 hooks.
Use npm i -D webpack-visualizer-plugin2


chore: adapt to renamed fields in Subarray

https://github.com/leanprover/lean4/pull/3851 renames three of the fields in Subarray to more closely match Lean naming conventions.

This is a draft because it needs the right toolchain prior to merge

Looks like @kmill got ahead of me in #741!


New version: Peppy.Osu! version 2023.1130.0

Pull request has been created with WinGet Automation :pear:
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-No-Executables


Redirection after a deployment launch

After having launched a new deploy, it would be nice to be redirected directly to the page of the deployment log : /deploy/logs/{log_id}.
The {log_id} could be caught from le result of the deploy command.

I coded the redirection, and there are 2 issues :

I met the case that res.id wad undefined
when you are redirected, you call the endpoint /deploy/{log_id} with the OPTIONS method ; this call is hanging until the execution is done ; then you call the endpoint /deploy/{log_id} with the GET method.


Web Protection Profile steps are not valid

The page directs the creation of a new "Web protection profile" in MEM; but this profile type is not available
"
Go to the Microsoft Endpoint Manager admin center (https://endpoint.microsoft.com/), and sign in.
Choose Endpoint security > Attack surface reduction, and then choose + Create policy.
Select a platform, such as Windows 10 and later, select the Web protection profile, and then choose Create.
"
Please advise on the proper way to create a web protection profile, and update documentation.
See attached image:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25e228a0-6a2c-2ae2-655b-ada8b6f313bc
Version Independent ID: fe0dcf35-c7f7-8dce-f829-9bc03827a40a
Content: Onboarding using Microsoft Endpoint Manager
Content Source: microsoft-365/security/defender-endpoint/onboarding-endpoint-manager.md
Product: m365-security
Technology: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@aaronnavratil Thank you for your feedback. I tested this in a couple of tenants and was not able to reproduce the issue as I see the options mentioned in the document.

I'd recommend you to contact Microsoft support via the need help option on the admin center to file a bug or fix the problem with your M365 tenant.
Hope this helps!
Thanks
Sri

Yes - it appears my tenant was lagged behind the documentation, the options are there now. I was not aware there were variability between tenants.....

@msbemba Thank you very much for the contribution and sharing this explanation. @aaronnavratil Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Couple simple changes to start, including working operator with > 2 operands

some debug output added to Operator.pm and prd.pl, de-duplication of code in Parser.pm, actually print in Print.pm

Yo, these changes still look like they apply...  though there is some merge work to be done perhaps?


Unable to reach HA hdfs nameservice with the elasticsearch-repository-hdfs-2.3.0 plugin

We have installed a elasticsearch hdfs plug-in on the elasticSearch V 2.3.1 node and are trying to create a hdfs repo with the following command.
PUT _snapshot/my_hdfs_repository
{
"type": "hdfs",
"settings": {
"uri": "hdfs://namenode:8020/",
"path": "elasticsearch/respositories/my_hdfs_repository",
"conf.dfs.client.read.shortcircuit": "true"
}
}
This command works well while using nodename:port. Our env has the High Availabillity turned on with hdfs nameservice.
When we try creating hdfs repository using the nameservice ("uri": "hdfs://nameservice/")
, we get UnknownHostException - Cannot create Hdfs file-system for uri [hdfs://SA20HDPA] nested: IllegalArgumentException[java.net.UnknownHostException: SA20HDPA]; nested: UnknownHostException[SA20HDPA].
Any help is appreciated.

The same question. Any possibility to use nameservice instead namenode in snap configuration?

Same question

We use python to connect to the hadoop cluster. Python have brilliant
statement try-except-else which suit our needs in this particular case...
С уважением,
Калиниченко Виталий!
2018-06-04 15:41 GMT+03:00 Proskurin Kirill<EMAIL_ADDRESS>
Same question
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elastic/elasticsearch-hdfs/issues/8#issuecomment-394340659,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOuKPadOqPxuvRJ1BA2L8MIRIBDcc0Zgks5t5SrugaJpZM4MWBle
.


z3.z3types.Z3Exception: ast is null

When I ran this command:
./synet.py -i examples/simple.logic -r examples/simple-req.logic -m bgp
it comes the error:

The version of z3 is <IP_ADDRESS>
I want to know how to solve this problem.
thanks for your reply!

This code base is really old and unmaintained really.
But try again with Z3 version 4.7.1. I just ran it on a fresh install and it worked there with no problem.

Thank you so much for the reply! I will try it with version 4.7.1.


OCPVE-347: chore: unify controller naming

Unififes all controllers to have the same structure for their go file naming. Renames all reconcilers Reconciler and differentiates them by go convention depending on the package.

Codecov Report

Merging #441 (9f97b53) into main (6c37220) will not change coverage.
The diff coverage is 75.55%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   57.65%   57.65%
=======================================
  Files          20       20
  Lines        1547     1547
=======================================
  Hits          892      892
  Misses        539      539
  Partials      116      116

Files
Coverage Δ

...ernal/controllers/lvmcluster/controller_watches.go
64.93% <100.00%> (ø)

internal/controllers/vgmanager/devices.go
80.17% <100.00%> (ø)

internal/controllers/vgmanager/wipe_devices.go
71.15% <100.00%> (ø)

internal/controllers/lvmcluster/controller.go
62.62% <86.66%> (ø)

internal/controllers/vgmanager/status.go
39.47% <71.42%> (ø)

.../controllers/persistent-volume-claim/controller.go
60.29% <25.00%> (ø)

internal/controllers/vgmanager/controller.go
34.21% <60.00%> (ø)

/test precommit-check

/test lvm-operator-e2e-aws

/test lvm-operator-e2e-aws

/lgtm
/approve


[BUG] Space key doesn't work when holding down shift

I've come across a weird bug that seems to be from this plugin which is that the spacebar doesn’t add a space when holding down shift.
I run into this quite often when creating headings e.g.

Press and hold shift
Press #
Press spacebar
Press first letter of heading.

With this plugin enabled pressing space doesn’t work? 🤔

Hi, @sinewave :)
Please see https://github.com/tadashi-aikawa/obsidian-various-complements-plugin/issues/88#issuecomment-1038853234

That was it, thx!


Unite app.nit metadata annotations common to Android and iOS

Rename the annotation java_package to app_namespace.
Move up app_name, app_version and app_namespace and their default values from the Android platform.
Apply these annotations in iOS too.
Use the annotations in Hello iOS.

+1. nice

In doubt, do not read it anyway. See you tomorrow.

Don't worry, it was posted on march 31!

+1

Rerolled to fix errors in doc.

ok to test


Windows Arrow Keys Broken

So I am trying to use your theme but in Windows 10, with your theme it breaks the arrow keys. If I remove your theme, restart Hyper, then the arrow keys work.
Windows 10: 1709
HyperJS: 2.0.0 Stable

This theme doesn't really affect anything related to arrow keys. Sounds more like a Hyper issue. Having similar issues with other themes? ✌


New regression: rtve

Test rtvealacarta is a new fail (ping @jaimeMF ) since maybe c39b2ed9901 or 233b58dec7362.
See this build:
https://travis-ci.org/anisse/youtube-dl/jobs/145224376

It's more likely to be introduced by c39b2ed990105e640456f126321ef3d771884405.

I have reverted the change, thanks for the report.


README should briefly describe strategies for updating the codebase

I think a few people might be getting confused, thinking that this script upgrades their code as well as their database.
We should have something in the README that mentions updating the codebase first, and then outlines a few strategies.  Namely:
Option A: Set up the main repo as an upstream of their project, and then use git merge to merge their code with the new codebase.  This requires understanding how to resolve merge conflicts.  I'm not sure how many conflicts it would generate for 0.3.0 -> 0.3.1, but it'd be worth one of us checking out.
Option B: Fresh install, then manually merge in their custom code.  This might be easier for certain projects and certain versions of UF.

I wouldn't think UserFrosting should generate any merge conflicts since it's a fast-forward, not a separate branch. The only merge conflicts should be users' own edits to core UF files (I'd imagine mostly in the routes).


API Key menu doen't open when clicked on sidebar

Steps to reproduce

Launch app
Enter API key and submit (if not already done)
attempt to open the API key frame via the sidebar

This makes the only way to change your API key via editing the text file, which I assume isn't indented.

This is not the intended behavior. This happened due to me removing api_key_frame from the App class with commit
https://github.com/WillofSteel-Devs/app/commit/7e77ccad06b783d9afd23efbd441e09091abd321#diff-d252bc93f4be132397c96d9eb762d27a52aba9457d1c99d3cb0bc7f4ac18473aL27 (codeblocks required so GitHub doesn't format the commit, please copy & paste)


Option to not try to apply case to non icelandic names

Hi! 👋
Would it be possible to add an option to applyCase to control whether or not beygla tries to apply case to foreign names?
Example
Current functionality: applyCase('þgf', "Carlos") => Carlosi
Wanted functionality: applyCase('þgf', "Carlos", {applyToForeignNames: false}) => Carlos
Maybe we could do a lookup in /data/icelandic-names.csv if applyToForeignNames is set to false 🤷

Hey,
I'd love to hear more about the use case. Beygla declines Carlos as (nf Carlos, þf Carlos, þgf Carlosi, ef Carlosar) which seems right to me. Is that not correct? If so, why not?
I'm not implying that this feature is not valuable or that I don't want to support it, I'm just curious as to why disabling declension for foreign names is desirable.

Implementation wise, the main challenge is being able to determine whether a name is an Icelandic name or not. This requires encoding the set of Icelandic names and including it in the bundle.
Encoding the set of names will take up some kilobytes, so I would be hesitant to include it in the default beygla export (I imagine it would at least double/triple the size of the library). However, we could add a "strict" version of the module:
import { applyCase } from "beygla/strict";

Where the beygla/strict module contains the encoded set of names and does something like so:
import { applyCase as originalApplyCase } from "./beygla";

function isIcelandicName(name: string): boolean {
  // ...
}

export function applyCase(...) {
  // Some conditional behavior based on 'isIcelandicName'
}

Anyway, I'll explore how significantly we can compress the list of Icelandic names. It seems like a fun problem to solve.

Quick update: a naive trie encoding of the Icelandic name set list yields a size of ~10kB gzipped:
Created file 'names-ser.txt'
        Size:           46.02 kB
        Gzip size:      10.61 kB (23.05%)

Hey @oddsson,
I've created a PR that implements beygla/strict (see #15). Would this implementation work for your use case?
PS: Feel free to review the PR if you've got the time!

Hey @alexharri, sorry for the radio silence 🤐
Thanks so much for acting on this. You are absolutely correct, beygla declines Carlos correctly. However, our use case is that we are using beygla in a project within the public sector. Our users care a lot about using grammatically correct Icelandic. They do not want to decline foreign names and since there is no way for us to determine the nationality behind a name, we decline everything. This means that our users manually "correct" foreign names after the fact and foreign names are really common within our system.
I'll try beygla strict within our project today or tomorrow and report back 🤝  Thanks again..

This would definitely work for our use case. If you are happy, I'd really like to see this merged so we can start using it 💯

@oddsson<EMAIL_ADDRESS>has been released to npm, let me know if you run into any issues!


feat: react 18

Depends on

#329

TODO

[ ] Use zustand 4 release candidate

Any update on this?

Any update on this?

Closing in favor of #412


Delete the Peddie Hub

Summary
I'm pretty sure that the Peddie Academy hub isn't being used anymore - it hasn't had activity that I've seen, and I emailed the instructor that was going to be testing it out, and he didn't respond. I think that we can delete the hub.
This is the hub: https://github.com/2i2c-org/pilot-hubs/blob/master/hubs.yaml#L311
For reference: Here are the instructions to delete a hub

@yuvipanda if you've got a "spring cleaning" issue open or something feel free to just delete this and add a to-do item in there :-)

@choldgraf looking at the pilot docs I noticed you are backing up user's data before deleting the Hub.
That makes sense but also has implications about dealing with user's data. Thinking around FERPA like stuff and the general question about what info we do maintain/keep, how long we keep it, when we destroy it, etc. Is there any discussion on that matter? Because I presume you already thought about this before. Thanks!

@damianavila I don't think we have any useful policy around this right now, and we should before we delete this I think.

@choldgraf although, maybe we can just delete the home dirs too this time? I do see some notebooks nbgitpull-ed in there...

I think that if the hub hasn't been used in several months, we should just delete this one. It was a pro bono that we set up just so they could experiment, and they haven't responded to my emails since

I am totally OK with the decision you are going to take on this particular case, my question was essentially a general one about the policy for the upcoming deletions :wink:

I'm closing this because we don't actually want to delete this! It turns out that they actually are using this infrastructure, and I had missed their activity from before.


avro-c build failure

OS:Linux
Compiler: GCC 9.2
Steps to reproduce the behavior:
./vcpkg install avro-c

Failure logs
By not providing "FindJANSSON.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "JANSSON", but
CMake did not find one.
Could not find a package configuration file provided by "JANSSON" with any
of the following names:
JANSSONConfig.cmake
jansson-config.cmake

Add the installation prefix of "JANSSON" to CMAKE_PREFIX_PATH or set
"JANSSON_DIR" to a directory containing one of the above files.  If
"JANSSON" provides a separate development package or SDK, be sure it has
been installed.

The port avro-c has been updated to version 1.9.2 in PR #10380, and it doesn't support triplet uwp Linux OSX. So closed this PR.


Idea:  Add a travis pipeline to publish tagged templates to S3, add a "Launch" button

I thought this was a super neat idea from: https://www.weave.works/docs/tutorials/kubernetes/launch-aws-cloudformation/

How would we do this:

Create a versioned s3 bucket as $s3-bucket
Publish all master builds to $s3-bucket/current/
Publish all tagged builds to $s3-bucket/tagname/ and also $s3-bucket/stable/
Add a Launch Stack button to the README

ref: https://docs.travis-ci.com/user/deployment/s3/
cc: @itmustbejj @nsdavidson

More info here:  https://aws.amazon.com/blogs/devops/construct-your-own-launch-stack-url/

except for the tagging bit this is done.


Use raf instead of requestAnimationFrame

This helps maintain browser compatibility.

Coverage remained the same at 85.095% when pulling 416b808be12bf5bee4228d83b3be0cfb03989f6a on raf into d549f416b0274b8274ee847752ad70fdbac00f1c on master.


TypeScript RLC multipart documentation

Document existing support for multipart in TypeScript RLC generation

No changes needing a change description found.


Add "Like" button to smartphone and tablet view

Overview

The "Like" button is not shown in smartphone and tablet view.

I would like to "Like" using smartphone.

No effect in PC view.

Screenshot
Smartphone

PC

The "Like" button is not shown in title line.

Thanks!!
I want to consider more about the UI if I could, however, the button appears is better than nothing. 👍


Fix OSX build on Travis.

Hi @cesarbs, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


How to target an Azure cloud PC / Windows365 that I have access to

How to target an Azure cloud PC / Windows365 that I have access to via Remote Desktop app.
I don't see ways to target the machine, as I have no clue what would be the public name, as it seems to be behind a RDP gateway. Is there ways to proxy the connection via that?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 90ec9455-ef64-8854-94bc-9be28887a6a4
Version Independent ID: 9adeea5e-7ba1-065f-5de0-aae9147f9c85
Content: Remote Testing in Visual Studio - Visual Studio (Windows)
Content Source: docs/test/remote-testing.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@AbhitejJohn Abhitej, is remote testing supported for Azure scenarios? Are there any details we can add?

Yikes, I'm sorry this fell through the cracks. We do not have a way of connecting to environments where a machine name/ip address cannot be specified in the testenvironments.json file here.

Closing, as I don't think there is a doc issue here.


Make UTC default Timezone for Stream Load

Enhancement
Default TZ for Stream Load is +8 Shanghai which is unexpected as a convention-over-configuration. I suggest to have UTC as default.

Still relevant, please do not archive.