fix: icon/iconbutton outline spacing

Fixes #172

Should we keep icons inline/inline-block/inline-flex to easily insert them in any text?

Should we keep icons inline/inline-block/inline-flex to easily insert them in any text?

Should we keep icons inline/inline-block/inline-flex to easily insert them in any text?

That's a great point. Addressed.
@danad02, could you please run the visual tests for this PR? 🙏

Should we keep icons inline/inline-block/inline-flex to easily insert them in any text?

That's a great point. Addressed.
@danad02, could you please run the visual tests for this PR? 🙏

@jankoritak There's a small regression caused by the Icon's  element addition:

The icons in TextField do not change color when in hovered/focused/error state.

@jankoritak There's a small regression caused by the Icon's  element addition:

The icons in TextField do not change color when in hovered/focused/error state.

Wow, that's a great catch! Will look into it, thanks!

Wow, that's a great catch! Will look into it, thanks!


Slot manager should be cluster-aware

This plugin hands out a 'slot' to a user that expresses intent to upload a file. This slot holds details on how to update.
When an upload is performed, the attempt is checked against the list of slots that have been handed out. When no match is found, the upload is rejected.
In a cluster, each Openfire node maintains its own list of slots. They have no knowledge of slots available on other cluster nodes.
In a cluster, a load balancer is frequently used. For XMPP data, all requests from a session need to end up with the same cluster node. For XMPP TCP connections, this will mostly be the default case (as all traffic is transmitted over the same, long-lived TCP connection). For BOSH, the load balancer is configured to be 'sticky'.
HTTP file upload introduces data interaction 'outside' of the XMPP channel: regular HTTP requests (PUT and GET) are used. Even if load balancers are configured to be 'sticky', making them 'sticky' in the sense that HTTP requests end up on the same cluster node as where the XMPP session is connected to.
To facilitate scenarios where a load balancer is used, all Openfire cluster nodes should be aware of all slots managed on every cluster node.

I wonder if it is necessary to encode the full endpoint URLs in the implementation of Slot, server-sided. Currently, only their unique identifier is encoded. With this unique identifiers, a server-local endpoint is (re)constructed when the Slot is being sent to a client.
I don't think that encoding the full URL in the Slot that is maintained on the server side is needed, as the Slot is issued just once. The URLs that are contained in that issuance will be used by both the uploader as well as the downloaders (who receive the URLs over XMPP from the uploader).


titleLabel Font

how could i change the floating label font to my custom font

textfield.placeholderFont = UIFont(name: 'YourFont', size: 16)

See this SO answer for instructions around how to add custom fonts to your app. https://stackoverflow.com/questions/24708401/how-do-you-stylize-a-font-in-swift


[modify] reverse order of prev and next buttons

Coverage decreased (-0.7%) to 84.403% when pulling 3bc5424503257f1a15c406ae7f37dce6453dc371 on pr-prev-next-nav into b05a8f1c42792f10163cd8951de9d1b23929b8c6 on master.


docs: mark what classes implement Command abcs

Summary

missing from when these classes were implemented.
Checklist

[ ] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[ ] I have formatted the code properly by running task lint
[ ] I have type-checked the code by running task pyright

[ ] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[x] This PR is not a code change (e.g. documentation, README, ...)

Minor nitpick, I think it would be better wording if it were "The following classes implement this ABC:" rather than just "The following implement this ABC:"

Minor nitpick, I think it would be better wording if it were "The following classes implement this ABC:" rather than just "The following implement this ABC:"

https://github.com/DisnakeDev/disnake/pull/506/commits/6c0c107602ef3caf1c543e57b100ba4e554e1489


Added Python shebang line

Using launchd to automate running the script returns namespace error without shebang line.

I say we go with the shebang line with a comment.
It will make it helpful if you do happen to chmod it.

SGTM
On Sun, Jan 10, 2016 at 8:27 PM Harper Reed<EMAIL_ADDRESS>wrote:

I say we go with the shebang line with a comment.
It will make it helpful if you do happen to chmod it.
—
Reply to this email directly or view it on GitHub
https://github.com/harperreed/eo-python/pull/13#issuecomment-170428015.

SGTM. Also, we'll need it when we make this a daemon... :)


Add limit to top occurences

Closes https://github.com/weaviate/weaviate-python-client/issues/898

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.17%. Comparing base (310bd06) to head (fe9602a).
Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   95.49%   95.17%   -0.32%
==========================================
  Files         167      173       +6
  Lines       17198    17688     +490
==========================================
+ Hits        16423    16835     +412
- Misses        775      853      +78

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Closing Tabs after printToPdf

Apologies, I've nearly got this working but can't seem to figure out how to close a tab that was opened.

Component
Version

Operating system
CentOS7

Node.js
8.2.1

Chrome
60.0.3112.66

chrome-remote-interface
0.24.2

Everything seems to work except for one part which is closing the tabs I've opened. I expose this code via https get/post requests. For each request I open a new tab and either fetch the html or load the html directly. Once loaded, output a pdf and return the filename they can request to get the printed pdf (or directly return it). This works pretty good. Using ab I can do many concurrent requests and everything seems to work. There is one small issue is that it doesn't seem to close the tab. Since I'm running headless I'm seeing a new process for each request open. For example, when I first start Chrome, I have a total of 5 processes. For every request I make, I get another chrome process. It doesn't seem to go away.  I'm fairly certain its because I'm calling client.close(); but not closing the tab first. You can see in the function getPdf included below that I've commented where I think I should be closing the tab but have so far been unable to do so. Full project source is here
async function load(html) {
    console.log('Load(html) called');

    const tab = await CDP.New({port: options.port});
    const client = await CDP({tab});
    const {Network, Page} = client;
    await Promise.all([Network.enable(), Page.enable()]);

    return new Promise((resolve, reject) => {
        let failed = false;

        Network.loadingFailed(() => {
            failed = true;
            console.log('Load(html) Network.loadingFailed');
            reject(new Error('Load(html) unable to load remote URL: ' + html));
        });

        const url = /^(https?|file|data):/i.test(html) ? html : `data:text/html,${html}`;
        Page.navigate({url});
        Page.loadEventFired(() => {
            if (!failed) {
                console.log('Load(html) resolved');
                resolve({client: client, tab: tab});
            }
        });
    });
}

async function getPdf(html) {
    const {client, tab} = await load(html);
    const {Page} = client;

    console.log("tabID: "+tab.id);
    // https://chromedevtools.github.io/debugger-protocol-viewer/tot/Page/#method-printToPDF
    const pdf = await Page.printToPDF(options.printOptions);

    // how do I close the tab here???
    client.close();

    return pdf;
}

you can use CDP.Close method
e.g.
async function getPdf(html) {
    const {client, tab} = await load(html);
    const {Page} = client;

    console.log("tabID: "+tab.id);
    // https://chromedevtools.github.io/debugger-protocol-viewer/tot/Page/#method-printToPDF
    const pdf = await Page.printToPDF(options.printOptions);

    await CDP.Close({port: options.port, id: tab.id}); // here's you need to pass tab id

    return pdf;
}

@gnat42 yes you can do as @hbakhtiyor says (thanks!); as you can see there should be no need to also close the client.
Just make sure to proper handle errors in your code so you don't leave dangling tabs around.

Ah, that's how it works, I had tried CDP.Close({tab.id}); client.target.closeTarget() and a variety of others. This works perfectly. @hbakhtiyor Much appreciated!
One question @cyrus-and being quite new to Node/JS and this api. I don't really know all the places/errors I could experience. I'm thinking that I need to close the tab in
Page.loadEventFired(() => {
            if (!failed) {
                console.log('Load(html) resolved');
                resolve({client: client, tab: tab});
                return;
            }
            CDP.Close({port: options.port,id: tab.id});
        });

Are there other places in that code that you see have potential for errors I'm not catching? If so are there docs someplace that detail what exceptions/errors a function can throw?

@gnat42 every method that returns a Promise could in principle fail, if you use the async/await pattern this means that each await f(); could throw an exception. Make sure to properly use try/catch/finally to handle your errors and perform cleanup code. For example:
try {
    await f();
} catch (err) {
    // notify the user
} finally {
    // cleanup code
}


What are the required fields for inbound batch data transfer?

Issue in ./help/using/integration/sending-audience-data/batch-data-transfer-explained/inbound-s3-filenames.md

Describes the required fields, syntax, naming conventions and file sizes you need to follow when sending data to Audience Manager.

There is nothing on this page about required fields

i think the gist is there are no headers, it's simply UUID  segmentID, segmentID, etc.


Issues/#759 maximising concurrency should not redistribute technologies over end points

I might be misunderstanding, but the concurrency settings don't seem to work correctly with this PR.

I added 3 units of "Electric Vehicle" to an endpoint.
Changed EV concurrency to "Min".
Clicked "Apply".
All three units of EVs are still grouped together.

I thought this should split the EVs into three separate technologies (attached to the same endpoint as before) with randomly-assigned profiles? On master this does split the EV into three separate parts, but distributes them across all the endpoints.
Correct me if I'm wrong please!

Correct me if I'm wrong please!

Hmm.. good question. I'll write an extra spec for this to validate the outcome. I'm still wondering what the intention should be when you do that to be honoust.

Was a little tiny bug in the Javascript though. And you're right. I think it should be workig now.

I'm still wondering what the intention should be when you do that to be honest.

Can you please explain what is unclear to you @grdw? Perhaps we need to write up our expectations somewhere very clearly (also as part of the user documentation) and make all appropriate specs to settle this (recurring) issue once and for all.

Perhaps we need to write up our expectations somewhere very clearly

Yes, we should. However, the problem described was already clear but I had to rethink it again. Maybe we should still write it in the user documentation though.

Perhaps we need to write up our expectations somewhere very clearly (also as part of the user documentation) and make all appropriate specs to settle this (recurring) issue once and for all.

I think this would be good, because it's not clear to me what the correct behaviour is. Here's what I just tried locally:

Topology with three endpoints (Households 1, Households 2, and Households 3).
Households 1 has a base load technology with 1 unit.
Households 2 has a single EV technology with 3 units.
Households 3 has no technologies attached.

If I choose to minimise EV concurrency, I find that:

Households 1 now has a base load and two separate EV technologies with 1 unit each.
Households 2 has a single EV technology with 1 unit.
Households 3 has nothing (correct)

Two units of EV have moved from Households 2 to Households 1. This may be intentional; it doesn't feel right to me, but if it's intentional then so be it.
If I now choose to maximise EV concurrency I find:

Households 1 has a base load and a single EV with 3 units
Households 2 has nothing
Households 3 has nothing (correct)

I think some documentation would be good, so that we can describe exactly how technologies should be distributed when changing the concurrency settings.

Following @antw example I would expect the following behaviour:
If I choose to minimise EV concurrency, I find that:

Households 1 still only has a base load
Households 2 has three individual EVs with 1 unit each
Households 3 has nothing (correct)

If I now choose to maximise EV concurrency I find:

Households 1 has a base load (still)
Households 2 a single EV technology with 3 units
Households 3 has nothing (correct)

I wrote a spec for this situation and I can confirm this behavior. :+1: Also fixed it though.. because it was only adding two characters in the existing code to actually fix it.

Maybe abuse the Wiki for a good tough article about concurrency: https://github.com/quintel/etmoses/wiki/Concurrency ?

Maybe abuse the Wiki for a good tough article about concurrency:

I'll write up something!

Works nicely, thanks again @grdw! :cake:


Feature/#4 decouple preprocessor from base configuration

Decoupled preprocessor from base configuration
There are packages for 3 different syntaxes now, use the package for the syntax that you use in your project.

@mediamonks/stylelint-config-css
@mediamonks/stylelint-config-scss
@mediamonks/stylelint-config-css-in-js

Added 3 new rules to the base configuration:

'csstools/use-logical'
'order/order'
'order/properties-order' (I'd like to replaced this with https://github.com/csstools/stylelint-devtool-prop-order when it's published)

Added packages to test stylelint configuration
Added github workflow action to publish packages
Added eslint, prettier and pre-commit hook

I don't agree with having to order the CSS properties Alphabetical, don't see any reason as to why we would do this and we had discussions about this but never got one proper answer.
Without ordering anything I can approve this PR

@ReneDrie I've removed the property order rule, we'll add the stylelint-devtool-prop-order rule when it's published on npm.


Exception when injecting styles on Chrome 64.

It appears that Chrome 64 now throws an exception when you try to access CSS rules on an empty stylesheet.
https://github.com/odoo/odoo/issues/22517
https://bugs.dojotoolkit.org/ticket/19100

Looks like it's a consequence of fixing this bug in Chrome:
https://bugs.chromium.org/p/chromium/issues/detail?id=775525


Folder restructure

Big restructure.
More code reuse in benches/examples, removed sandbox.

screw it i think it's fine


Dashboard Artifact collapse button should have label

The Dashboard's Artifact expand button has a label explaining the action and the contents, but the collapse button - which is displayed after the Artifact visualization, and away from the Artifact name and type - does not.

In a panel displaying multiple imbricated Artifacts, this can lead to confusion regarding which Artifact each collapse button collapses:

The collapse button should have a label, just like the expand button does.

A pseudo-related matter than does not warrant its own issue: The Figure Artifact visualization should be auto-expanded for blingyness and usability. Users most likely want to view the figures.

On

this can lead to confusion regarding which Artifact each collapse button collapses:

I don't think adding the label helps mitigate this issue. However, when hovering on the collapse button, we will high-lighten the section the collapsing button will fold. That might be more useful than the labels.
Personally I don't feel the need to add the label to collapsing buttons, because it is somewhat obvious what they are going to do. In case they are added, multiple "collapse this section" will be displayed in a column which renders the UI clustered / overly chatty.

I don't think that's necessary. Thank you.


IOError: stream closed in another thread

Recently, we've updated the Nexmo gem to 6.1.0. Since then we're experiencing a lot of the following two errors when sending SMS:

IOError: stream closed in another thread
EOFError: end of file reached

The messages are actually being sent, but the send_message call then raises the error. The stack traces for both errors are basically looking the same:
IOError: stream closed in another thread
  from net/protocol.rb:217:in `wait_readable'
  from net/protocol.rb:217:in `rbuf_fill'
  from net/protocol.rb:191:in `readuntil'
  from net/protocol.rb:201:in `readline'
  from net/http/response.rb:40:in `read_status_line'
  from net/http/response.rb:29:in `read_new'
  from net/http.rb:1509:in `block in transport_request'
  from net/http.rb:1506:in `catch'
  from net/http.rb:1506:in `transport_request'
  from net/http.rb:1479:in `request'
  ...
  from net/http.rb:1472:in `block in request'
  from net/http.rb:920:in `start'
  from net/http.rb:1470:in `request'
  ...
  from nexmo/namespace.rb:91:in `request'
  from nexmo/sms.rb:106:in `send'
  ...
  from app/workers/sms_worker.rb:xx:in `perform'
  from sidekiq/processor.rb:196:in `execute_job'
  from sidekiq/processor.rb:164:in `block (2 levels) in process'
  from sidekiq/middleware/chain.rb:138:in `block in invoke'
  ...
  from sidekiq/middleware/chain.rb:140:in `block in invoke'
  ...
  from sidekiq/middleware/chain.rb:140:in `block in invoke'
  from sidekiq/batch/middleware.rb:54:in `call'
  from sidekiq/middleware/chain.rb:140:in `block in invoke'
  from sidekiq/middleware/chain.rb:143:in `invoke'
  from sidekiq/processor.rb:163:in `block in process'
  from sidekiq/processor.rb:136:in `block (6 levels) in dispatch'
  from sidekiq/job_retry.rb:111:in `local'
  from sidekiq/processor.rb:135:in `block (5 levels) in dispatch'
  from sidekiq/rails.rb:43:in `block in call'
  from active_support/execution_wrapper.rb:87:in `wrap'
  from active_support/reloader.rb:73:in `block in wrap'
  from active_support/execution_wrapper.rb:87:in `wrap'
  from active_support/reloader.rb:72:in `wrap'
  from sidekiq/rails.rb:42:in `call'
  from sidekiq/processor.rb:131:in `block (4 levels) in dispatch'
  from sidekiq/processor.rb:257:in `stats'
  from sidekiq/processor.rb:126:in `block (3 levels) in dispatch'
  from sidekiq/job_logger.rb:13:in `call'
  from sidekiq/processor.rb:125:in `block (2 levels) in dispatch'
  from sidekiq/job_retry.rb:78:in `global'
  from sidekiq/processor.rb:124:in `block in dispatch'
  from sidekiq/logger.rb:10:in `with'
  from sidekiq/job_logger.rb:33:in `prepare'
  from sidekiq/processor.rb:123:in `dispatch'
  from sidekiq/processor.rb:162:in `process'
  from sidekiq/processor.rb:78:in `process_one'
  from sidekiq/processor.rb:68:in `run'
  from sidekiq/util.rb:15:in `watchdog'
  from sidekiq/util.rb:24:in `block in safe_thread'

No obvious what the issue is there, but I don't think it's related to the 6.1.0 changes.
What version of the gem were you using before?
Can you reproduce the error outside of background jobs?
How fast are you sending messages? Have you tried throttling?

We've upgraded to 6.1.0 from 6.0.1, and after downgrading, the issue seemed to be resolved, so I opened the issue. However, after running for a couple of hours, I see new issues coming in now. Since it seems to not be related to the new Gem version right now, I'm closing the issue.


Future request: setting current video position

Thanks for the great component.
Would it be possible to have the possibility to set the current video position/time from code?
Just like you can now control 'pause', 'start' etc, that I could control the current position of the video?
I'm asking because in my use-case I have another component from where I want to select the position, and I want to feed that into the video player to show the correct part of the video.
Thanks!,
Jelle

This feature would be amazing!


"File" paramType causes validation to fail

Looks like fixing form validation exposed a bug with parameters of type File. This is what happens when I run a test that uses webtest's upload_files arg (http://webtest.readthedocs.org/en/latest/testapp.html#making-requests) with a File type argument in swagger.
Swagger:
        {
            "path": "/business/{business_id}/media/photo/v1",
            "operations": [
                {
                    "summary": "Upload a business photo",
                    "notes": "Example response",
                    "method": "POST",
                    "nickname": "createPhoto",
                    "parameters": [
                        {
                            "name": "business_id",
                            "type": "string",
                            "description": "Business identifier",
                            "required": true,
                            "paramType": "path"
                        },
                        {
                            "name": "photo",
                            "type": "File",
                            "description": "Binary photo data",
                            "required": true,
                            "paramType": "form"
                        },
                        {
                            "name": "caption",
                            "type": "string",
                            "description": "Photo caption",
                            "required": false,
                            "paramType": "form"
                        }
                    ],
                    "type": "BusinessPhotoResponse",
                    "consumes": ["multipart/form-data"]
                }
            ]
        },

Failure:
tests/integration_tests/api/business/media_integration_test.py ...Traceback (most recent call last):
  File "/nail/home/jschultz/pg/biz_app/.tox/py/local/lib/python2.7/site-packages/pyramid/tweens.py", line 21, in excview_tween
    response = handler(request)
  File "/nail/home/jschultz/pg/biz_app/.tox/py/local/lib/python2.7/site-packages/pyramid_swagger/tween.py", line 114, in validator_tween
    validator_map)
  File "/nail/home/jschultz/pg/biz_app/.tox/py/local/lib/python2.7/site-packages/pyramid_swagger/tween.py", line 204, in handle_request
    validate_request(validation_pairs)
  File "/nail/home/jschultz/pg/biz_app/.tox/py/local/lib/python2.7/site-packages/pyramid_swagger/tween.py", line 286, in _validate
    raise exc_class(str(exc))
RequestValidationError: 'photo' is a required property

Failed validating 'required' in schema[u'properties']['photo']:
    {u'additionalProperties': False,
     u'properties': {'caption': {'description': 'Photo caption',
                                 'name': 'caption',
                                 'paramType': 'form',
                                 'required': False,
                                 'type': 'string'},
                     'photo': {'description': 'Binary photo data',
                               'name': 'photo',
                               'paramType': 'form',
                               'required': True,
                               'type': 'File'}},
     u'type': u'object'}

On instance['photo']:
    {}

By exposed, you mean introduced, right?  I'm pretty sure this is the new validation failing on the service call because it can't find the field photo in the form data, because it's not in the form data. It's available from a different request field.
We just have to account for that, probably by adding the field in the return value of SwaggerPyramidRequest.form, I think.

Actually, I think I'm a bit off. It's not that the data is on a different field, it's that jsonschema expects a dict at that value, but the param is an object of some type.

Looks like you'll want to extend all Validators that could ever encounter a File object to actually support validation on them. I'm under the impression that both the HTTP and Swagger1.2 specs only support them in form-encoded bodies. If that's the case, you can just change the form validator to some extended version of the Swagger12ParamValidator it currently uses and make that extended validator support File objects.
That said, once we get 2.0 support and delegate all validation to bravado-core, this feature needs to be supported there not in pyramid_swagger. Up to you whether doing this work is worth it, and I'd suggest making sure bravado-core supports the same feature too.

I think this is the same as #113. I'll get to the bottom of it tomorrow.


Returning from multi column table view button disappears when clicking 'Show multi-column table view'

@marklunn @MalcolmShazell I've assigned this to the after-launch milestone, since I'm not sure it's crucial to get it fixed today. Please feel free to bump the priority if you think it's more urgent than that.

@ijdickinson @marklunn I think we leave this - better to keep the code stable than risk adding a different bug

Fix deployed

switching table view button functions properly and doesn't disappear. Happy to close


Radzen.DataGridSettings gets set twice when restoring Saved Settings with Groups

When restoring Radzen.DataGridSettings from database table that has Groups, the @bind-Settings gets set twice:
Once with the restored values and once with the default values. This happens every time when the saved settings have groups.
It never happens if there are no groups set.

If I change a column by sizing it or moving it @bind-Settings gets set properly.


Tournament claims allow multiple claims for the same tournament and rank

Nut sure if this is correct here, or should be an issue with ABR.
For this tournament the winner is shown twice:
https://netrunnerdb.com/en/decklist/43969/1st-place-regional-g-ttingen-violet-moon-

Hum right, this table is missing a unique constraint. Thanks for the report.

This looks like it happened because of multiple claims calls:
mysql> SELECT * FROM claim WHERE decklist_id = 43969;
+------+-------------+-----------+---------------------+-----------------------------------------------------------------+------+---------+--------------+
| id   | decklist_id | client_id | name                | url                                                             | rank | user_id | participants |
+------+-------------+-----------+---------------------+-----------------------------------------------------------------+------+---------+--------------+
| 1470 |       43969 |        13 | Regional Spieleburg | https://alwaysberunning.net/tournaments/485/regional-spieleburg |    1 |    5521 |           31 |
| 1484 |       43969 |        13 | Regional Spieleburg | https://alwaysberunning.net/tournaments/485/regional-spieleburg |    2 |    5837 |           31 |
| 1523 |       43969 |        13 | Regional Spieleburg | https://alwaysberunning.net/tournaments/485/regional-spieleburg |    1 |    5521 |           31 |
| 1822 |       43969 |        13 | Montly GNK in Rudis | https://alwaysberunning.net/tournaments/730/montly-gnk-in-rudis |    3 |    5521 |            8 |
+------+-------------+-----------+---------------------+-----------------------------------------------------------------+------+---------+--------------+
4 rows in set (0.00 sec)

The database doesn't have a unique index on the decklist_id, client_id, name, rank fields.
There are ~50 violations in the database right now.  These would have to be taken care of before we could apply the new index, but that isn't a huge deal.

Inelegant SQL to remove unnecessary duplicates before implementing new index/constraint:
delete from claim where id in (     select          newer.id      from claim newer     where exists     (         select *         from claim older         where older.decklist_id = newer.decklist_id         and older.client_id = newer.client_id         and older.name = newer.name         and older.rank = newer.rank         and older.id < newer.id     ) );

index deployed.


Enhanced usage of List and Map in cassandra trigger

Codecov Report

Merging #579 into cassandra-triggers will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             cassandra-triggers     #579   +/-   ##
=====================================================
  Coverage                 31.99%   31.99%
  Complexity                 1210     1210
=====================================================
  Files                       172      172
  Lines                     15116    15116
  Branches                   2396     2396
=====================================================
  Hits                       4836     4836
  Misses                     9557     9557
  Partials                    723      723

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ba841...f36dedf. Read the comment docs.


Bot crash after 1min

Hello,
I have this error whatever I do with the bot :

/home/ubuntu/DiscordRoleManager-master/start.js:109
bot.createMessage(config.mainChannelID, "⚠ " + rows[rowNumber].temporaryRole + " for user " + member.user.username + " does not exist! Please check your role assignment").catch((err) => { console.log(err) });
^
TypeError: Cannot read property 'user' of undefined
at Statement. (/home/ubuntu/DiscordRoleManager-master/start.js:109:107)

And it stops the bot.

Can you check that you added the serverID in config.json?
"serverID": "7290611111111111"

Yes serverID is added

I setup a new branch with a migration from sqlite to mysql I try to catch such issues as well.
In your case member is undefined. Did you enable SERVER MEMBERS INTENT and PRESENCE INTENT for the bot on discordapp.com?

I setup a new branch with a migration from sqlite to mysql I try to catch such issues as well.

So I need to try again with this new branch ?
Yup, SERVER MEMBERS INTENT & PRESENCE INTENT are enabled

The new branch is wip and not finished yet.
But it will migrate your sqlite data to mysql.
Von: Vincent Duchêne @.>
Gesendet: Mittwoch, 2. Juni 2021 14:11
An: acocalypso/DiscordRoleManager @.>
Cc: acocalypso @.>; Comment @.>
Betreff: Re: [acocalypso/DiscordRoleManager] Bot crash after 1min (#6)
I setup a new branch with a migration from sqlite to mysql I try to catch such issues as well.
So I need to try again with this new branch ?
Yup, SERVER MEMBERS INTENT & PRESENCE INTENT are enabled
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/acocalypso/DiscordRoleManager/issues/6#issuecomment-852973959, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAVW7JIE433XVHXZ5XU4WGDTQYNU7ANCNFSM456KHUQQ.

Ok thanks !

You could try the new mysql branch. If you already have a sqlite3 Database the Data will automatically bei converted.
You only need to create a new mysql database.

Ok super thank you !

It works thank you !


README.md fix snippets

Remove invalid ';' on snippets with chaining.

Coverage remained the same at 84.061% when pulling b06b5d2b24117b1f43cc463dfd486cd7936e4c1c on agebhar1:feature/README.md into b1e784aa265c7af30314b5ca5399d37a3f375545 on jhalterman:master.

Thanks for this!

My pleasure!


add per tenant & per timeline breakdowns for 'old' metrics (e.g. get page requests count & histograms)

What should be done in this issue? Have we done this already in #1234? Probably it's better to close this issue and write down all per-tenant pageserver metrics that we want to have in the near future.

@kelvich , could you double check? is there anything remaining here?


ISO 8601 format

I want to parse a ISO 8601 date:
<moment-js date="[[post.created_at]]" from-now="true"></moment-js>

I get a warning in the console from moment.js that parsing without format string is deprecated.
moment.js has support for special format constants, like moment.ISO_8601:
https://momentjs.com/docs/#/parsing/special-formats/
But when parsing a date with the moment element, date-format has to be string.
How can I pass moment.ISO_8601 to the moment element?

moment.ISO_8601 is a constant. You can't pass it.

However, you could pass same ISO format like YYYY-MM-DDTHH:mm:ss.sssZ.


Client Allocation Request for: Hangzhou Xun Ku technology Co., LTD

Client Allocation Questions
Core Information

Name: Hangzhou Xun Ku technology Co., LTD
Website / Social Media: www.xunkukeji.com
DataCap Requested: 5TiB
Addresses to be Notarized: f1fpa54bz6hfang5j3nlmk6ieqcv4kda2zcqv3r5i
Notary Requested: philippbanhardt

Hey @mikejunqq2020 - thanks for your request. Can you kindly add more information / context here on:

yourself , e.g. include links to social media / news mentions etc
your history working on IPFS / Filecoin, e.g. notable contributions to the community, type of engagement shown over time etc
type, size, source and your relationship with the data you (and by extension other Discover participants) are looking to store on Filecoin, e.g. public data vs private data etc
how you intend to store the data on Filecoin, e.g. redundancy, location / miner preferences, etc

Thanks

Hangzhou XunKu Technology Co., Ltd. is a data enabling and digital asset operation company. The company connects IOT equipment, collects and stores data through independent research and development of hardware, system platform and independent architecture cloud storage room. Through AI algorithm analysis and business auxiliary operation platform, it provides business system solutions for b-end customers. The company is committed to "enabling data, making business smarter.".
our company website is  www.xunkukeji.com .
From 2018, our whole operational scheme consist of traceability technology, education and incentive mechanism during  prophase, metaphase and anaphase  for garbage classification solution with blockchain and IPFS technology stack. the garbage classification solution has already classified 5000 + residential areas
We have much IoT data and CCTV surveillance video for garbage classification, The blockchain technology is used to trace the source of garbage. every day we have to save more than 1TB data for garbage classification and traceability. All of data and media will be desensitization and opened to the public. We are looking for more cheaper the storage solution for our data and media .
We intend to store our data and media on Filecoin for cheaper price ,redundancy and miner preferences.
Best Regards

Hey @mikejunqq2020 thanks for clarifying, however the Filecoin Foundation (acting as the initial notary that you applied to for receiving datacap) is at this time not covering your use case. There will be more notaries in the very near future (you can also ask on the Filecoin Slack in the filecoin-plus channel) that may have different policies. Thanks for putting your trust into the Filecoin project!


Low S Cozejs

Cozejs needs to support low-S: https://github.com/Cyphrme/Coze/blob/master/docs/proposals/implemented/malleability_low_s.md

Fixed by 4bdb917


Implement Boolean Data Structure

Create the Boolean data structure for handling true/false values in Kisumu.
Tasks:

Implement the Boolean data structure.
Add methods for logical operations (AND, OR, NOT).
Write tests to validate the functionality.

Noted


Update index.d.ts

change the module name to react-native-safearea-height as same as the package name

@devym-37 could you merge this?

@mk0116 thanks, @Dylan0916 yes merge and release


Drop support for Python 3.6, 3.7, add for 3.10, 3.11

Python 3.6, 3.7 have reached their end-of-life of their release cycles.
Current tests workflow will fail because actions/setup-python does not  provide 3.6 on ubuntu-latest:
So I propose to update the Python versions and happy to make a PR if you think it reasonable.

Hi @xzmeng , thanks for pointing this out. If you can open a PR with all the changes, that would be great. Thanks!


EntityTableRepository verifying entity type in constructor

In EntityTableRepository constructor is check whether the entity type is derived from EntityTableData or ETagEntityTableData. It would be better to check whether the entity type is implementing ITableData interface only, like this:
if (!typeof(ITableData).IsAssignableFrom(typeInfo)) {     throw new InvalidCastException($"Entity type {typeof(TEntity).Name} is not a valid entity type."); }
The problem in our case is that we have data model defined in separated project library and we would like to have it as light as possible. That is why we are referencing 'Microsoft.AspNetCore.Datasync.Abstractions' package in our data model library project and there is defined only the ITableData interface.
Our quick fix was to implement whole EntityTableRepository on our own with the only change as you can see in mentioned code snippet. But for the future it may be hard to maintain with the new versions of the azure mobile apps packages for us.

This is a deliberate design decision.  The EntityTableData class provides specific EF related attributes on the various components that are required for the proper running of the service.  One of these is [RowVersion] which is required and available only in the EF Core packages.  So you have to bring in EF Core anyhow.
This is not something we are going to fix as it is "by design".


fix: SmoothListTileCard: onTap callback passed twice

What

The SmoothListTileCard Widget pass twice the callback to handle click events
This will fix the visual issue (the ripple don't having rounded corners)

Codecov Report

Merging #2949 (80ebb4f) into develop (54eae2b) will increase coverage by 0.00%.
The diff coverage is n/a.

 Learn more


Fredy's First Upload of UofT, DSI, Cohort3, Deep Learning, Assignment 1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Uploading completed assignment 1
What did you learn from the changes you have made?
That I need a better computer ;)
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Reducing adjusting the number of epochs
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Computer speed. It was taking too long to run.
How were these changes tested?
Epochs, trains and test sets.
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[X] I can confirm that my changes are working as intended

Thank you @jarlathbr for your feedback :)


chore: prefer atomic.Pointer to atomic.Value

This improves the situation by closing down the api and enforcing the required type.
It also slightly reduces allocations and memory use and - at least on my system - improves benchmarking time for the whole system from 35.788s to 32.588s (but only one run each and 2 days apart...).

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (6fb7cd4) to head (e8ba530).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   96.56%   96.56%
=======================================
  Files          18       18
  Lines        1864     1864
=======================================
  Hits         1800     1800
  Misses         36       36
  Partials       28       28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BTW @arnehormann unless you object I will add you as contributor so you can run CI etc.

I don't object, but I don't know how often or how much I'll contribute after these PRs. Not that I won't, just that I don't know yet.

I don't object, but I don't know how often or how much I'll contribute after these PRs. Not that I won't, just that I don't know yet. Thanks for your trust!

Well, as long as you have a couple of PRs in flight, you should be able to trigger the CI/CD without waiting for me to wake up in West Coast time and press the "Run CI" button.

I don't object, but I don't know how often or how much I'll contribute after these PRs. Not that I won't, just that I don't know yet. Thanks for your trust!

Well, as long as you have a couple of PRs in flight, you should be able to trigger the CI/CD without waiting for me to wake up in West Coast time and press the "Run CI" button.

That... is indeed quite nice.

That... is indeed quite nice.

Our CI/CD setup is due to @embano1 and is quite effective, although as you'll see if you watch the ignore-case PR, it's got one problem that I'm having trouble working around.

Looks good to me. I wonder how I managed to not notice atomic.Pointer.

They were introduced somewhat "recently" in Go 1.19, and atomic.Value has been around for longer (and during the time you created Quamina) - so there's no-one to blame here ;)
+1 on using atomic.Pointer

Hey @arnehormann I have an overall performance test script and the change to atomic.Pointer led to an 0.52% improvement overall and 1.37% in the most common case.

That sounds wonderful! Is have hoped for more, but it's a lot for such a small change. Also, live by a thousand paper-mends or somesuch


Improve the 6x6 solver.

Implement:

Make the solver responsive.
The input data is shown as Black digits in the solution.
The answer data(solved by the solver) is shown as blue coloured digits in the solution.
Currently the reset function is not working correctly in terms of resetting the colours(it makes everything black). Fix it such that points 2 and 3 are maintained.
Add the solve animation of 9x9 solver.

assign me under JWOC 2024

@bera474 Go for it!


NuGet task should log a message saying no files matched the pattern

When providing a pattern to the NuGet task and no files were found, the task should inform the user that no matches were found and possibly partially succeeding the task so it's apparent to the user that something didn't really go entirely right.

Closing this as WF. In the upcoming quarter, we'll be moving away from the full-featured Artifacts-related tasks (which have many issues like this because they mask the underlying tool's output) and recommending calling NuGet directly. See the design here for more details.


Changes for devnet deployment

Allow config dir to be overridden with SUI_CONFIG_DIR env var.
validator binary assumes that genesis is already complete, and reads network.conf

The approach I had built would mean you only need to specify the genesis config and multiple validators can derive their states form there

Few fmt nits but we're gtg!


bug: visual mode remains after canceling vscode search

Check the following:

[X] I have tried setting vscode-neovim.neovimClean in VSCode settings and restarting VSCode.
[X] I have read the vscode-neovim docs.
[X] I have searched existing (closed!) issues.

Neovim version (nvim -v)
0.10.2
Operating system/version
macOS 15
Problem (including log messages)
In normal mode, useactions.find to search, then press esc, neovim visual mode remains which it shouldn't.
Steps To Reproduce
https://github.com/user-attachments/assets/23045650-1a0d-4439-b4b0-6e327acf86ff
Expected Behavior
After canceling vscode search, neovim enters normal mode.

Hello, I've fixed this issue!
This is what I've done:
I have updated the handleModeChanged method in the ModeManager class to properly handle the transition from visual mode to normal mode when the VSCode search is canceled. This change ensures that the Neovim visual mode is correctly exited when the user cancels the VSCode search.
I also created pull request: https://github.com/vscode-neovim/vscode-neovim/pull/2308

[!CAUTION]
Disclaimer: This fix was created by Latta AI and you should never merge before you check the correctness of generated code!

This bug was fixed for free by Latta AI - https://latta.ai/ourmission

@xiyaowong Actually, not a dup of #2299, this is the expected behavior, since in insert mode, the selection also stays after using esc, I solved it using:
{
  "key": "escape",
  "command": "runCommands",
  "args": {
    "commands": ["closeFindWidget", "vscode-neovim.escape"]
  },
  "when": "findWidgetVisible"
}


Can't navigate UpgradeMenu with the arrow keys

The upgrade menu doesn't work when using the dpad

Hi! I would like to contribute, but this is my first time doing this, so I don't know much. I read the contributing guidelines.
I couldn't choose the upgrade with the arrows, nor with A and D.
I found that the UpgradeButton's focus_neighbour*-s weren't empty, and removing them fixed the issue.
The question is that should the rightmost button be activated when pressing left from the leftmost button and vica-versa?
Do I need to make a fork to make a pull request?

Hi! Thanks for offering your help.

Do I need to make a fork to make a pull request?

Yes. I also recommend creating a git branch when you do so, as it's easy to mess the pull request with a forked master branch.
Regarding the issue, removing the focus neighbors would likely work, as long as there are no other menus opened at the same time.


Callable: add callv method

Analogous to the existing callv method on Object, this new method on Callable takes a single array of arguments.
This method has the advantage that it can be called from GDExtension without vararg template shenanigans. For example, the automatically generated bindings in godot-cpp will work out of the box. This is important as it provides the first way to actually call a Callable using godot-cpp. (Better ways may be implemented later.)
Together with https://github.com/godotengine/godot/pull/65828, this will unblock ongoing work on custom physics servers.

Thanks!


Fix rejected scite4autohotkey package

https://chocolatey.org/packages/scite4autohotkey/<IP_ADDRESS>51010

Duplicate of https://github.com/chocolatey/chocolatey-coreteampackages/issues/290


[FR]: Integration Orillusion with react

Hi
I think seamless integration Orillusion with react may be good idea.
like three.js+react or babylon.js+react.

Thanks a lot for this consideration!
To be honest, this topic has been discussed in our Team for many times. We have following concerns and hope we could have a further talk:

Vue and React, which one we should choose at the beginning?
We consider to propose a project like A-frame, it is a pure web native syntax.
It really takes time for us. If some more developers could join and discuss. It must be very helpful.

We will leave this issue open for some time and looking forward to more comments here.

From what I know about reactive front-end frameworks, the rendering performance of these frameworks is not as good as that of game engines because they are not optimized for dedicated game scenes.
If users incorrectly use the front-end framework to drive game engine behavior, it may cause serious performance problems.

I can offer a simple solution.

Create a vanilla js project
Place the orillusion code in
Using react's portal technology
Bridge orillusion and react's store for data exchange

Remember not to handle orillusion in react effect


HA restart breaks iCloud authorisation

Almost every (but not all) restart of HA results in having to reauthorise the iCloud account connection. Even after one day of requesting an Apple ID verification code, entering it, it being accepted and services working normally.
This has been happening for several weeks now.
The log shows:
Stage 4 > Setup iCloud & iOSApp Data Source

ALERT > Some devices could not be verified. iCloud Location Services will be reinitialized
• Unverified Devices > jay_iphone_icloud3, jay_watch_icloud3, masami_iphone_icloud3,
aska_iphone_icloud3, zoe_iphone_icloud3

iOS App Devices > 3 of 5 iCloud3 Devices Configured
HJM iPhone (iphone) → jay_iphone_icloud3 (iPhone13,3)
Masami's iPhone 7 (masami_s_iphone_7) → masami_iphone_icloud3 (iPhone9,1)
Zoe's iPhone (zoes_iphone) → zoe_iphone_icloud3 (iPhone14,7)
• Masami's iPhone 6S (masami_s_iphone_6s) → Not Monitored,
Masami's iPhone 6S (iPhone8, 1)
• Kitchen iPad (kitchen_ipad) → Not Monitored,
Kitchen iPad (iPad4,1)
• HJM MacBook Air (hjm_macbook_air) → Not Monitored,
HJM MacBook Air (MacBookAir10,1)
• HJM iPad (hjm_ipad) → Not Monitored,
HJM iPad (iPad13,1)

Find-My-Friends Devices > Not used as a data source

ICLOUD FAMILY SHARING DEVICES ERROR >
• No devices were returned from iCloud Account Family
Sharing List, Retry #11

iCloud Account Used ><EMAIL_ADDRESS>
iCloud Location Services interface > Verified (stage4)

iCLOUD ALERT > Family Sharing Data Source is not available.
The web url providing location data returned a Service Not Available error (stage4)

iCloud Location Svcs Interface > Started during initialization
• Completed: Setup
• Inprocess: Authenticate
• Needed: FamShr, FmF

iCloud Account Used ><EMAIL_ADDRESS>
iCloud Location Services interface > Verified (stage4)

iCloud3 Error > An error occurred logging into the iCloud Account. Error-cannot access local variable 'response where it is not associated with a value

iCloud Location Services interface > Verified (init)

iCloud3 Error > An error occurred logging into the iCloud Account. Error-cannot access local variable 'response where it is not associated with a value

iCloud Location Svcs Interface > Started during initialization
• Completed: Setup
• Inprocess: Authenticate
• Needed: FamShr, FmF

iCloud Account Used > jo…@mu…

It looks like you are having communication issues with Apple. Any other HA errors? Network? Internet?
Check Configure Settings > iCloud Account and iOS App screen and make sure username/ password are ok and China it’s not enabled.
Reset the iCloud account and get a new code Configure Settings > Enter/Request Verification Code screen
Are you running a regular HA setup or in a container? Proxies? Virtual environmental? If so, that is probably the problem.

I think I may have narrowed this down to a DNS setting referencing a local container dns server that wasn't ready in time for iCloud3. Adding a secondary server such as <IP_ADDRESS> seems to have resolved the matter. TBH the secondary should have already been there and I'm not sure why I didn't add it following a system recovery from backups.
That said, if the dns was the cause perhaps iCloud3 could be more resilient to network issues at startup and try again at periodic intervals without breaking the authorisation??


Added Questions in python-quiz.ts and general-cs-quiz.ts

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Made requested changes.


Fix unaligned memory access in Interp on ARM32

Walrus Interp uses reinterpret_cast for data movement in load and store instructions. On ARM32, if the size of the data to be moved is 8 bytes, then compiler generates LDRD and STRD instructions. Address for these instructions has to be word-aligned, whilst Walrus has to support non-aligned data movement.
To achieve this, Walrus now uses memcpyEndianAware function for moving 8 byte-long data (int64, uint64 and double) in Interp on ARM32. This function generates two LDR and two STR instructions that can cope with non-aligned addresses.
Moreover, memory.wast test has been improved in order to check unaligned memory access.
Unfortunately Qemu-arm doesn't care about memory alignment, therefor it won't cause BUS ERROR (but it does occure on arm hardware).

Don't merge!
I've found some errors.

Nevermind. Problem solved. (It was a local problem.)


feat: TypeScript support

See: ENG-32

Unrelated, the master branch doesn't seem to be protected in this repo. Do you want to do that? (I don't have access to those settings)


[error] unsupported data type: &[] ([]string)

GORM Playground Link
https://github.com/go-gorm/playground/pull/20
Description
I'm attempting to use a data structure that contains a []string, however I get the following error instead:
[error] unsupported data type: &[]

Yes, it is known as not supported.
Models are normal structs with basic Go types, pointers/alias of them or custom types implementing Scanner and Valuer interfaces

[]string is not a basic golang type.

(as database/sql doesn't support that)

Any suggestions on how to get around that?


Update README.md

A year ago, I upgraded our Python bioinformatics package from C++ to Rust/PyO3. It worked great! I suggest adding links to the project and a (free) article about lessons learned from the process. I'm especially happy with the ability to use Rayon and Rust generics.
Thank you for contributing to pyo3!
Please consider adding the following to your pull request:

an entry in CHANGELOG.md
docs to all new functions and / or detail in the guide
tests for all new or changed functions

Be aware the CI pipeline will check your pull request for the following:

Rust tests (Just cargo test or make test if you need to test examples)
Rust lints (make clippy)
Rust formatting (cargo fmt)
Python formatting (black . --check. You can install black with pip install black)
Compatibility with all supported Python versions for all examples. This uses tox; you can do run it using cargo xtask test-py.

You can run a similar set of checks as the CI pipeline using make test.

Excellent! (And I’ve removed the unneeded _py: Python’s from the article and the code.)

Carl

From: David Hewitt @.>
Sent: Sunday, January 02, 2022 3:21 PM
To: PyO3/pyo3 @.>
Cc: Carl Kadie @.>; Author @.>
Subject: Re: [PyO3/pyo3] Update README.md (PR #2086)
@davidhewitt approved this pull request.
Thanks very much for the article and adding to the README! I'm glad you're having a good experience with PyO3 😄
As a side note, I notice in your article your Python functions always have _py: Python as the first argument. This isn't necessary; you can just omit those arguments and things should work just the same.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPyO3%2Fpyo3%2Fpull%2F2086%23pullrequestreview-842450730&data=04|01||aed65f3b301442d3372f08d9ce46936b|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637767624779277012|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Wq1B6dJFa1mCIYNlofi1750QlZFsrTb%2BAOwCwybG3hk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABR65P6XI7EOZVAWQNW3J4TUUDMWZANCNFSM5LC2IHNA&data=04|01||aed65f3b301442d3372f08d9ce46936b|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637767624779277012|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Lrxs5p4fCTul%2Bmj%2FxlHnIz2XEo4DvKDO6jcm9P6SSng%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||aed65f3b301442d3372f08d9ce46936b|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637767624779277012|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=z3OF2eKV%2BnEpapNVFuYtORZjIb5QnZ0Qe%2BGtLP23Rw0%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||aed65f3b301442d3372f08d9ce46936b|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637767624779277012|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Niu1gYgRD1C64nS6VpfkK7ULyQR3c0lonTPcBbmdcNo%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


feat(expect/unstable): support expect.hasAssertions()

This pr is one of part to solve https://github.com/denoland/std/issues/3964, which is to support expect.hasAssertion api.

This seems only works for the first use of hasAssertions as we don't create a new assertionState for each it call.
The below script doesn't throw with the 2nd case, which misses assertions:
import { expect } from "@std/expect";
import { test } from "@std/testing/bdd";

test("1", () => {
  expect.hasAssertions();
  expect(1).toBe(1);
});
test("2", () => {
  expect.hasAssertions();
});

This seems only works for the first use of hasAssertions as we don't create a new assertionState for each it call.
The below script doesn't throw with the 2nd case, which misses assertions:
import { expect } from "@std/expect";
import { test } from "@std/testing/bdd";

test("1", () => {
  expect.hasAssertions();
  expect(1).toBe(1);
});
test("2", () => {
  expect.hasAssertions();
});

Yes, the above code had some bugs. and I've updated.
Thanks.

This API has been documented as 'still not available'. I think we can consider this addition as 'fix' as this is already expected to be added.


Update to Spring Boot 1.3.1

Thank you for your work. Can you please add an entry to the changelog?

For what? I refrained to add the update of Spring Boot to the list of updated dependencies, because this entry will change to 1.3.2 or 1.3.3 anyways until we release 3.0.

Fair enough. Thank you.


gopass show still affected by the MIME effect

I tried the example from https://github.com/gopasspw/gopass/issues/1594
somepasswd
---
Test / test.com
user:myuser
url: test.com/

I've seen that since release 1.11.0 the file is no longer modified every time I edit, but if I dump the file to screen with gopass show I still get the same modifications
somepasswd
url: test.com/
user: myuser
---
Test / test.com

Expected behavior
Show should just dump the file as stored (no modifications)
Environment

OS:Ubuntu 20.04
OS version: Linux yoga 5.8.0-38-generic #43~20.04.1-Ubuntu SMP Tue Jan 12 16:39:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
gopass Version: 1.11.0
Installation method: binary from github release page

I am not sure about how gopass interprets this file
somepasswd
---
user: myuser
foo:
  - bar
  - delta
url: test.com
---
some random note

Should I assume that the first line is always the password and the rest behaves just like markdown frontmatter??

I am not sure about how gopass interprets this file
somepasswd
---
user: myuser
foo:
  - bar
  - delta
url: test.com
---
some random note

Should I assume that the first line is always the password and the rest behaves just like markdown frontmatter??

This file would be parsed as YAML with an additional non-YAML body.

This file would be parsed as YAML with an additional non-YAML body.

If you want to disable all formatting and not benefit from key-values and YAML parsing, you need to set the option parsing to false in gopass config.
Your first example is probably parsed as a key-value entry because of the third line which is not valid YAML.
Your second example is probably as YAML since you used the --- separator, but the second --- separator is causing the YAML parsing to stop there and the random note is not displayed. (plus it's not valid YAML).
You can use also show -n to disable the parsing on a specific show operation.

If you want to disable all formatting and not benefit from key-values and YAML parsing, you need to set the option parsing to false in gopass config.
Your first example is probably parsed as a key-value entry because of the third line which is not valid YAML.
Your second example is probably as YAML since you used the --- separator, but the second --- separator is causing the YAML parsing to stop there and the random note is not displayed. (plus it's not valid YAML).
You can use also show -n to disable the parsing on a specific show operation.

So it would look like this:
somepasswd
---
foo:
    - bar
    - delta
url: test.com
user: myuser

We don't really support having multiple YAML separators at the moment. Not sure if we want the extra hassle, since YAML might not be the most used of the formats for secrets anyway.

So it would look like this:
somepasswd
---
foo:
    - bar
    - delta
url: test.com
user: myuser

We don't really support having multiple YAML separators at the moment. Not sure if we want the extra hassle, since YAML might not be the most used of the formats for secrets anyway.

Notice the expected behaviour of show and how it is doing the parsing when parsing is set to true is detailed here:
https://github.com/gopasspw/gopass/blob/master/docs/commands/show.md#parsing-and-secrets

Notice the expected behaviour of show and how it is doing the parsing when parsing is set to true is detailed here:
https://github.com/gopasspw/gopass/blob/master/docs/commands/show.md#parsing-and-secrets

Ops! my bad. I was confused with the formatting (parsing) being the default. Probably I am very spoiled since Yekyll / Ruby got me used to think that all note/text files are just markdowns files with front matter in YAML.
I've just disabled parsing because I always want show to match as close as possible my formatting. However that disables the feature to read key/values. Technically I want the parsing to extract key/values and just disable the formatting
Since I do not use key/value reading often parsing: false solves my issue
Please feel free to close this issue after considering these UX concerns. I am leaving those up to the maintainers.

In my example the line some random note is lost/gone from the show output. Was that expected?

Not sure if there is a standard for closing YAML separators, but users from static bloggers (at least Hugo and Jekyll ) might expect that to be the most natural way to type secrets. At least it was for me.

Ops! my bad. I was confused with the formatting (parsing) being the default. Probably I am very spoiled since Yekyll / Ruby got me used to think that all note/text files are just markdowns files with front matter in YAML.
I've just disabled parsing because I always want show to match as close as possible my formatting. However that disables the feature to read key/values. Technically I want the parsing to extract key/values and just disable the formatting
Since I do not use key/value reading often parsing: false solves my issue
Please feel free to close this issue after considering these UX concerns. I am leaving those up to the maintainers.

In my example the line some random note is lost/gone from the show output. Was that expected?

Not sure if there is a standard for closing YAML separators, but users from static bloggers (at least Hugo and Jekyll ) might expect that to be the most natural way to type secrets. At least it was for me.

I guess you could work around that using a alias to alias gopass show -n with gshow or some other command that you could then use to show you secrets but still use gopass name key when you want to get the value of a key.
Otherwise just run gopass -n entry whenever you want to display the content of an entry.
@dominikschulz  Not sure if we want yet another config option to disable parsing upon show but still have parsing enabled when a key is set?
Or do we change the behaviour and ignore the parsing option when a key is specified?
Yeah, the YAML not rendering what is under it is a bug IMO and it should get added to the body instead of being hidden.

I guess you could work around that using a alias to alias gopass show -n with gshow or some other command that you could then use to show you secrets but still use gopass name key when you want to get the value of a key.
Otherwise just run gopass -n entry whenever you want to display the content of an entry.
@dominikschulz  Not sure if we want yet another config option to disable parsing upon show but still have parsing enabled when a key is set?
Or do we change the behaviour and ignore the parsing option when a key is specified?
Yeah, the YAML not rendering what is under it is a bug IMO and it should get added to the body instead of being hidden.

Maintaining config options is very painful. Please let's try to avoid that whenever possible.
Enabling parsing whenever a key is specified sounds good. Possibly with a warning.
The content below YAML should go into the body of the YAML secret. If it doesn't it's likely a bug.

Maintaining config options is very painful. Please let's try to avoid that whenever possible.
Enabling parsing whenever a key is specified sounds good. Possibly with a warning.
The content below YAML should go into the body of the YAML secret. If it doesn't it's likely a bug.

Yeah, we are only taking the data above the --- as part of the body.
https://github.com/gopasspw/gopass/blob/99b396f16899f13c119deefc377378214e239069/pkg/gopass/secrets/yaml.go#L123-L147

Yeah, we are only taking the data above the --- as part of the body.
https://github.com/gopasspw/gopass/blob/99b396f16899f13c119deefc377378214e239069/pkg/gopass/secrets/yaml.go#L123-L147

@dominikschulz Is this "fixed" by the additional documentation around our YAML support not supporting the body below and only supporting one YAML block in #2244 ?
Currently we do support:
somepasswd
some random note
---
user: myuser
foo:
  - bar
  - delta
url: test.com

but NOT:
somepasswd
---
user: myuser
foo:
  - bar
  - delta
url: test.com
---
some random note

nor multiple documents/nodes in one entry:
somepasswd
---
user: myuser
foo:
  - bar
  - delta
url: test.com
...
---
extra: yaml block
with: more key-values
...

I think we can consider it fixed, yes.


test: add tests for client credentials token generator

Codecov Report

Merging #46 (c9fa456) into develop (3c54c6e) will increase coverage by 3.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop     #46      +/-   ##
==========================================
+ Coverage     5.02%   8.88%   +3.85%
==========================================
  Files          143     143
  Lines         2566    2566
==========================================
+ Hits           129     228      +99
+ Misses        2437    2338      -99

Flag
Coverage Δ

unittests
8.88% <ø> (+3.85%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Etimo.Id.Entities/Db/User.cs
38.46% <0.00%> (+7.69%)
:arrow_up:

src/Etimo.Id.Entities/Db/Application.cs
20.75% <0.00%> (+13.20%)
:arrow_up:

src/Etimo.Id.Entities/Db/RefreshToken.cs
25.00% <0.00%> (+18.75%)
:arrow_up:

...rc/Etimo.Id.Entities/TokenRequests/TokenRequest.cs
40.00% <0.00%> (+40.00%)
:arrow_up:

src/Etimo.Id.Entities/JwtToken.cs
61.53% <0.00%> (+61.53%)
:arrow_up:

src/Etimo.Id.Entities/JwtTokenRequest.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

...imo.Id.Service/Exceptions/UnauthorizedException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

...mo.Id.Service/Exceptions/InvalidClientException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

....Service/Exceptions/UnauthorizedClientException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

...ervice/Exceptions/UnsupportedGrantTypeException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c54c6e...c9fa456. Read the comment docs.

Codecov Report

Merging #46 (c9fa456) into develop (3c54c6e) will increase coverage by 3.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop     #46      +/-   ##
==========================================
+ Coverage     5.02%   8.88%   +3.85%
==========================================
  Files          143     143
  Lines         2566    2566
==========================================
+ Hits           129     228      +99
+ Misses        2437    2338      -99

Flag
Coverage Δ

unittests
8.88% <ø> (+3.85%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Etimo.Id.Entities/Db/User.cs
38.46% <0.00%> (+7.69%)
:arrow_up:

src/Etimo.Id.Entities/Db/Application.cs
20.75% <0.00%> (+13.20%)
:arrow_up:

src/Etimo.Id.Entities/Db/RefreshToken.cs
25.00% <0.00%> (+18.75%)
:arrow_up:

...rc/Etimo.Id.Entities/TokenRequests/TokenRequest.cs
40.00% <0.00%> (+40.00%)
:arrow_up:

src/Etimo.Id.Entities/JwtToken.cs
61.53% <0.00%> (+61.53%)
:arrow_up:

src/Etimo.Id.Entities/JwtTokenRequest.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

...imo.Id.Service/Exceptions/UnauthorizedException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

...mo.Id.Service/Exceptions/InvalidClientException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

....Service/Exceptions/UnauthorizedClientException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

...ervice/Exceptions/UnsupportedGrantTypeException.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c54c6e...c9fa456. Read the comment docs.


Refactor Fluid CSI Plugin

Ⅰ. Describe what this PR does
Refactor Fluid CSI Plugin.

Move package pkg/csi/mountinfo to pkg/utils/mountinfo
Move package pkg/csi/fuse to pkg/csi/plugin
Add registration functions to add the following components: "CSI Plugin" and "Fuse Recover"

For any contributions who attempts to add  new feature to Fluid CSI Plugin in the future, he/she should:

Define needed parameters in pkg/csi/config/Config
Create a new package in pkg/csi and declare an exported function like Register()
Add the Register() func to pkg/csi/register.go

Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
@cheyang @zwwhdls

@TrafalgarZZZ Please take care of the code coverage. Thanks.

Did you test fuse recover by manual after these modify? LGTM except test coverage.

Did you test fuse recover by manual after these modify? LGTM except test coverage.

@zwwhdls  Yes. Already tested it and it works well. This is my test case for fuse recover.
As to test coverage, I think it may be unnecessary to add unit tests for newly added functions like func Register and func Enabled, since they show little business-related and trivial logic for now.


Question: Creating many streams from a single stream

Hi, I'm stuggling a bit getting my head around how to do something
I have a stream of data like [1,2,3,4,5,6,7,8,9]
I want to split the stream into many streams of length 4 so [1,2,3,4], [2,3,4,5], [3,4,5,6], [3,4,5,6] ... etc.  I'm then looking to do an operation on each separate stream.
I've read through the docs twice and I think i'm lacking in experience on how to compose the stream operators to do this :(.
Can anyone help please?
Thanks
Neil

Not 100% sure what you mean but do you want to split stream into say batches of 4 and then apply the same operation on those batches?

@svozza - exactly right, so take the first batch 1-4 then the next batch 2-5 etc.  Each batch will then have an operation applied against it to give a total or a product for instance.  Finally then return the maximum value.
I'm working on this problem in project euler at the moment https://projecteuler.net/problem=8 - I've been working through them with highland to try and sharpen up my knowledge of streams and functional programming.

A custom consumer to do the batching is probably the easiest way here. Highland has batch methods, but they just do splitting instead of duplication/shifting. You could make it work with a goofy forking scheme where you make 4 forks (or 13 for the problem), but that'd be a bit silly.
var _ = require('highland');
var xs = "123456789".split('').map(function (i) { return parseInt(i) });

function makeBatcher(size) {
  var batch = [];
  return function (err, x, push, next) {
    if (err) {
      push(err);
      next();
    } else if (x === _.nil) {
      push(null, x);
    } else {
      batch.push(x);
      if (batch.length === size) {
        push(null, _(batch));
        batch.shift(1);
      }
      next();
    }
  }
}

// note: this is the same as .each(_.each(_.log)), but this way is more clear
_(xs).consume(makeBatcher(4)).each(function (stream) {
  stream.each(_.log);
});

Of course, for this problem, it's a lot easier to just keep streams out of the picture:
var xs = "123456789".split('').map(function (i) { return parseInt(i) });
var max = 0;

function multiply(a, b) {
    return a * b;
}

for (var i = 0; i < xs.length - 4; i++) {
    max = Math.max(max, xs.slice(i, i + 4).reduce(multiply, 1))
}
console.log(max);

@LewisJEllis thanks for the help, much appreciated


New PR for Read receipt changes

Executed Build Pipeline
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/6295051288

Executed Build Pipeline:
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/6321446697


Signed vs Unsigned APK in LIVE Citrus Environment

The payment gateway works fine in the un-signed Live environment of Citrus. However in signed apk, the Citrus loader keeps on loading on the screen and does not take the user to the Merchant site in all the 3 cases, i.e Credit,Debit and Netbanking. Any changes to be made in proguard file? I am trying to update the SDK.

I hope that this issue is resolved already, if isn't please refer to the proguard changes at
https://github.com/citruspay/citrus-android-sdk/blob/master/docs/Progaurd changes.md


Fixed update of the meme list (needs to be executed in the main thread)

retrieve meme was updating the UI out of the main thread, causing IllegalStateException error

ping @wtrocki @danielpassos

@ziccardi We have changed the SDK to do this by default to avoid people needs to add it in all query/mutation/subscription. See: https://github.com/aerogear/aerogear-android-sdk/blob/master/sync/src/main/java/org/aerogear/mobile/sync/SyncClient.java#L144

Problem was related with unreleased version. Passos is working on fixing this now


dreamview: fix bug at sim control

InitStartPoint() can handle  using localization point and using dummy point.if localization is not empty, program will jump here.

@lj0919 Please help review this PR. Thank you.

@qwetqwe https://github.com/ApolloAuto/apollo/blob/f02eda58ca1abf939c567fc8db3a461fcbcbc95a/modules/dreamview/backend/sim_control/sim_control.cc#L255 when localization reader has no data, set_start_point is passed in true, we will init start point

Hi, @lj0919
In SimControl::InitStartPoint ,the function seems that if localization not empty, sim control will use lastest localization message.
https://github.com/ApolloAuto/apollo/blob/f02eda58ca1abf939c567fc8db3a461fcbcbc95a/modules/dreamview/backend/sim_control/sim_control.cc#L140-L164
The function explaination :
https://github.com/ApolloAuto/apollo/blob/f02eda58ca1abf939c567fc8db3a461fcbcbc95a/modules/dreamview/backend/sim_control/sim_control.cc#L120-L121
But program can not get into this branch, and set start point  when localization not empty, and will output localization 0 0 0 as default.

@qwetqwe  Hi, Sorry for the late reply, I misunderstood what you meant at first, the else branch looks really redundant.


VM: Implement on-stack replacement in bytecode interpreter

Currently, we switch from interpreting a method to executing compiled code only when entering a method. If method has long-running loops it may take significant time to interpret it.
In order to improve performance in such cases, we need to implement

unoptimized compilation with OSR entry point
OSR of interpreted frames with unoptimized compiled frames

This is one of the reasons why NavierStokes and NavierStokesTyped benchmarks are slower with interpreter compared to bytecode JIT (which is on par with default mode). These benchmarks don't have a proper warm-up outside of measurements and they have a method with long-running loops (FluidField.lin_solve).
/cc @rmacnak-google @crelier @a-siva

Bytecode mode is removed from Dart VM.


Added functionality for PT order creation from UI in Payment step

Issue: https://linear.app/nebulab-retainers/issue/ABU-7/create-a-template-controller-to-create-paytomorrow-order

[x] Added controller that calls OrderCreationService
[x] Request specs for this^
[ ] Make it a template controller
[x] Added partial to show PT on the payment step with 'pay' button (_pay_tomorrow.html.erb)

TODO -

The HTML looks ugly right now, so make it beautiful
Handle redirects - when user completes checkout or in case of failure of OrderCreationService

I think there was some miscommunication during the last call.
As far as I remember we decided to add a JS code to inquiry the API responsible for creating the order in PayTomorrow and then to redirect the user to the given URL.
This means I would expect the following:
1. API controller (under SolidusPayTomorrow::Api namespace) that call CreateOrderService and return back the URL in JSON

2. A js code that handles the Click of the user on the `Pay` button, calls the above Controller and redirects the user to the given URL

I think you can get some inspiration from reading https://github.com/solidusio-contrib/solidus_klarna_payments/blob/master/app/controllers/solidus_klarna_payments/api/callbacks_controller.rb

@DanielePalombo  what I understood from our call, I tried to confirm here on Linear . I am re-posting the same
We decided to use JS request to create the PT order instead of using a rails controller.
Now that I think about this - what will be the use of OrderCreationService if we'll create order from JS?
Also, we'll have to ensure that the access_token is valid here in JS request as well. Basically, whatever OrderCreationService and BaseService handle for us, we'll have to replicate in JS

Now ->
From the quoted/requested comment, I feel what you are trying to say is -

Put CreateOrderController under API namespace hence it should be SolidusPayTomorrow::Api::CreateOrderController and it should return the URL and token in json
When user clicks Pay, instead of calling this controller directly, we need a JS function that calls this controller, get the above^ json, redirects the user to the url

Is my understanding correct? If so, what else the JS is supposed to do apart from this^

The user should be redirected by pay tomorrow after the application is created

The user should be redirected by pay tomorrow after the application is created

Right. To the returnURL.
And we'd have a new controller to handle that?

And we'd have a new controller to handle that?

Yes, but this won't be part of this PR.

I think there was some miscommunication during the last call.
As far as I remember we decided to add a JS code to inquiry the API responsible for creating the order in PayTomorrow and then to redirect the user to the given URL.
This means I would expect the following:
1. API controller (under SolidusPayTomorrow::Api namespace) that call CreateOrderService and return back the URL in JSON

2. A js code that handles the Click of the user on the `Pay` button, calls the above Controller and redirects the user to the given URL

I think you can get some inspiration from reading https://github.com/solidusio-contrib/solidus_klarna_payments/blob/master/app/controllers/solidus_klarna_payments/api/callbacks_controller.rb

Fixed all of this in https://github.com/nebulab/solidus_pay_tomorrow/pull/9/commits/588020bf4ae3b46ecc697ead0d662b656f41ddae

@abhishekgupta5 as discussed IRL, I added some commits to fix some problems with the sandbox and make the dev process more smooth. If the PR looks good to you, please merge it.


[Bug] Logs showing greater than 24hr usage for a day

Watcher is running in my laptop for last 3 months. I happened to run the following cmd:

watcher -ws -ps

Results are attached in form of png:

Hey could you please let me know which version are you using? And also can you share the SS of that day stats ?

Hey, I am using a forked version of repo but the HEAD is same as main, which is at  42b578c
SS of stat:

I see that the data is wrong in the .csv as well.

Still, we need to find how this bug is reproducible so that we can debug.

@AnilMandliya I never able to reproduce this bug, if you still faced this issue, can you give me details how can I reproduce this.

I had the same issue. I'm on linux mint 21.1
I just installed Watcher (branch v2.0), and I wanted to test its behavior when the screen was locked (but not sleeping). I left the screen locked for about 15 min (i didn't time the exact time) and when I came back, it showed "24h" of usage of the app that I had left open before locking the screen.
The app in question was Thunderbird
I tried it again with other apps (terminal, firefox) as the active window instead, and it didn't happen again


Guides - Managing Built Files

aka "intro to why you should use html-webpack-plugin"

Based on feedback from twitter:

the new docs. Main confusion for me was i included generated files in wrong order and got not helpful error msg

Few brainstorming options but I think that we should essentially recommend heavily the use of html-webpack-plugin and why. (Explain the whole managing new build files that are hashed every time, ensuring they are output in correct order, etc)

@TheLarkInn I agree completely, the html-webpack-plugin and things like copy-webpack-plugin both help in not having any manually managed files in your /dist or /build folder. Definitely makes managing and including auto-generated files easier, a simpler .gitignore, and I also think it's much easier to explain a project when you can just say:

All work is done in this or these /src directory, you never have to touch anything in /dist.

When I first started using webpack I definitely saw a lot of examples using manually-managed index.html (and other) files within the build directory which is the initial approach I took as well. Only within the last few months did I stumble upon the html-webpack-plugin and html-webpack-template projects which have definitely made things much easier, and, when it comes to using hashes in the filenames, you pretty much have to use some automated solution.

@TheLarkInn mind if I take a stab at this? I've used the html-webpack-plugin and html-webpack-template a fair amount at this point. I might need someone to help explain the manifest and give some examples but I could probably get something started.

This would be great! Feel free and take it!

Ah cool, wasn't aware of that plugin.


WARN: Mixin mixins.magicultureintegrations.tconstruct.json:TileHeatingStructureMixin from mod magicultureintegrations-1.12.2-2.0.0.jar has multiple constructors, (Ljava/lang/String;I)V was selected

This is not crash and I didn't found any issues with mod yet, but I found this warning in debug.log file:
[14:36:21] [Client thread/WARN] [mixin]: Mixin mixins.magicultureintegrations.tconstruct.json:TileHeatingStructureMixin from mod magicultureintegrations-1.12.2-2.0.0.jar has multiple constructors, <init>(Ljava/lang/String;I)V was selected

I know that "warnings" from mixins are usually not so "warnings" but errors so i though you need to know 😅
debug.log

It's a minor error. I forgot to remove the second constructor on the Tinker's Construct mixin here.
Fixed in dev.


Update align-content handling of overflow

Summary:
Gentest tests started failing because Chrome changed behavior of overflowed align-content container. Spec says should fallback to "safe center", which is really just "start", instead of previous "center" behavior. This changes behavior accordingly.
There is one bit where I think we are doing the wrong thing wrt alignment of flex start vs start (which we don't support yet), but couldn't repro a failing chrome test.
Differential Revision: D55617689

There is one bit where I think we are doing the wrong thing wrt alignment of flex start vs start (which we don't support yet), but couldn't repro a failing chrome test.

I believe Chrome is also falling back to flex-start currently (see: https://github.com/servo/servo/pull/31724). I agree with you that this seems to violate the spec, but the spec is currently somewhat inconsistent as it does specify flex-start as the fallback for some alignment modes.

CSSWG issue https://github.com/w3c/csswg-drafts/issues/10154


Docker build fails undefined symbol: initialize_Lean_Replay

Hello,
I am just doing the docker build to avoi dall sort of environment problems:
docker build -t leancopilot:latest -f Dockerfile .
However it fails:

296.3 info: stderr:
296.3 /.elan/toolchains/leanprover--lean4---v4.13.0-rc3/bin/lean: symbol lookup error: ././.lake/packages/aesop/.lake/build/lib/libAesop-Tree-ExtractProof-1.so: undefined symbol: initialize_Lean_Replay
296.3 error: Lean exited with code 127
296.3 Some required builds logged failures:
296.3 - LeanCopilot.LlmAesop
296.3 error: build failed
------
Dockerfile:17
--------------------
  15 |
  16 |     # Build the Lean project.
  17 | >>> RUN lake build
  18 |     RUN lake exe LeanCopilot/download
  19 |     RUN lake build LeanCopilotTests
--------------------
ERROR: failed to solve: process "/bin/sh -c lake build" did not complete successfully: exit code: 1

Please refer to #128

Actually there is no normal way to build this and fixes that were discussed in #128 are not actually working

It does work on my Ubuntu but yes I had to make a few changes.
…
On Mon, 28 Oct 2024, 11:24 Mark, @.> wrote: Actually there is no normal way to build this and fixes that were discussed in #128 <#128> are not actually working — Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACNEPG3KA7KGR7WYKFVQ2TZ5YNFJAVCNFSM6AAAAABQHPROUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRGMYTGMZYGE . You are receiving this because you authored the thread.Message ID: @.>

I reverted till 880f820 the situation is better, but build fails with:
Some required builds logged failures:
- LeanCopilotTests.PremiseSelection
- LeanCopilotTests.ModelAPIs

I just updated LeanCopilot to support recent versions of Lean/mathlib. Could you please try again and see if the issue still persists.
This is what I got:

Great thanks, will attempt tomorrow.
Cheers.
On Tue, 24 Dec 2024, 21:26 Kaiyu Yang, @.***> wrote:

I just updated LeanCopilot to support recent versions of Lean/mathlib.
Could you please try again and see if the issue still persists.
This is what I got:
image.png (view on web)
https://github.com/user-attachments/assets/961b0047-af28-42c2-a3e9-cb34a7833322
—
Reply to this email directly, view it on GitHub
https://github.com/lean-dojo/LeanCopilot/issues/127#issuecomment-2561458989,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACNEPFOQGVXDPSNLP4ZCCT2HHGO5AVCNFSM6AAAAABQHPROUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRRGQ2TQOJYHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


[read: connection reset by peer] Network issue between bosh CPI and google API

Hello team,
We have network issue during some bosh operations on GCP landscapes.
Also the call to google API is successfully, because during snapshot creation, the snapshot is successfully created, but the response is invalid and you can see the errors below:
Details of any failed request(s) (e.g. URL or API method, date and time, input parameters, response code, error message, screenshots) : [RetryTransport] 2022/08/11 09:27:38 INFO - net.Error was not retryable: read tcp <IP_ADDRESS>:49892-><IP_ADDRESS>:443: read: connection reset by peer [GoogleOperationService] 2022/08/11 09:27:38 DEBUG - Google Operation 'operation-1660210032949-5e5f3c5443814-c0fa8562-e1427761' finished with an error: &url.Error {Op:"Get", [URL:"https://compute.googleapis.com/compute/v1/projects/gcp/zones/asia-south1-a/operations/operation-1660210032949-5e5f3c5443814-c0fa8562-e1427761?alt=json&prettyPrint=false|url:"https://compute.googleapis.com/compute/v1/projects/gcp/zones/asia-south1-a/operations/operation-1660210032949-5e5f3c5443814-c0fa8562-e1427761?alt=json&prettyPrint=false]", Err:(*net.OpError)(0xc0000a60a0)}
What was the observed behavior? - disk snapshot creation failed
Any other relevant details about your implementation or issue? - We are using bosh cpi https://bosh.io/d/github.com/cloudfoundry/bosh-google-cpi-release?v=42.0.0
The ticket with details above was created to GCP and the answer is:
“Said that, it seems that the snapshot is getting created successfully, but it seems that the bosh CPI is failing to get the operation information due to some network problems. Moreover, I see different snapshot creations for the same disk and they all were successful.
As an example, there was another creation for a snapshot from the same disk at [2022-08-11 11:32:17 UTC] and the operation was successful as well.
The snapshot is created by bosh CPI as well and is still there under the snapshot page list.
I would suggest to check the connectivity between the source machine that is making the requests and the google API platform, as this seems to be an issue out of the scope of Google Cloud since the snapshots are being created as expected.”
GCP Timeout Errors:
Task 2243498 | 11:53:39 | Updating instance audit_broker: audit_broker/4f6bd68d-ec89-4183-ac9f-6980f32c7c5e (1) (00:04:00)
L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Deleting vm 'vm-5195cbb9-d0fa-4686-72e6-b5742e2bb156': Failed to remove Google Instance "vm-5195cbb9-d0fa-4686-72e6-b5742e2bb156" from Target Pool: Failed to remove Google Instance 'vm-5195cbb9-d0fa-4686-72e6-b5742e2bb156' from Target Pool 'broker-gcp-eu30-pool': Google Operation 'operation-1656590145313-5e2a8f32659a1-5e78ca25-dacfd856' finished with an error: Get "https://compute.googleapis.com/compute/v1/projects/gcp/regions/europe-west3/operations/operation-1656590145313-5e2a8f32659a1-5e78ca25-dacfd856?alt=json&prettyPrint=false": read tcp <IP_ADDRESS>:35042-><IP_ADDRESS>:443: read: connection reset by peer' in 'delete_vm' CPI method (CPI request ID: 'cpi-855603')
Task 2243498 | 11:57:39 | Error: CPI error 'Bosh::Clouds::CloudError' with message 'Deleting vm 'vm-5195cbb9-d0fa-4686-72e6-b5742e2bb156': Failed to remove Google Instance "vm-5195cbb9-d0fa-4686-72e6-b5742e2bb156" from Target Pool: Failed to remove Google Instance 'vm-5195cbb9-d0fa-4686-72e6-b5742e2bb156' from Target Pool 'broker-gcp-eu30-pool': Google Operation 'operation-1656590145313-5e2a8f32659a1-5e78ca25-dacfd856' finished with an error: Get "https://compute.googleapis.com/compute/v1/projects/gcp/regions/europe-west3/operations/operation-1656590145313-5e2a8f32659a1-5e78ca25-dacfd856?alt=json&prettyPrint=false": read tcp <IP_ADDRESS>:35042-><IP_ADDRESS>:443: read: connection reset by peer' in 'delete_vm' CPI method (CPI request ID: 'cpi-855603')
=================================================
L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Attaching disk 'disk-e56f3e21-8eb3-45a8-54f9-c84c51021507' to vm 'vm-8e717d9e-febd-47e3-4bbc-52d622fb486a': Failed to find Google Disk 'disk-e56f3e21-8eb3-45a8-54f9-c84c51021507': Get "https://compute.googleapis.com/compute/v1/projects/gcp/aggregated/disks?alt=json&filter=name+eq+.*disk-e56f3e21-8eb3-45a8-54f9-c84c51021507&prettyPrint=false": oauth2: cannot fetch token: Post "https://oauth2.googleapis.com/token": dial tcp <IP_ADDRESS>:443: i/o timeout' in 'attach_disk' CPI method (CPI request ID: 'cpi-117739')
Task 2341495 | 13:53:52 | Error: CPI error 'Bosh::Clouds::CloudError' with message 'Attaching disk 'disk-e56f3e21-8eb3-45a8-54f9-c84c51021507' to vm 'vm-8e717d9e-febd-47e3-4bbc-52d622fb486a': Failed to find Google Disk 'disk-e56f3e21-8eb3-45a8-54f9-c84c51021507': Get "https://compute.googleapis.com/compute/v1/projects/gcp/aggregated/disks?alt=json&filter=name+eq+.*disk-e56f3e21-8eb3-45a8-54f9-c84c51021507&prettyPrint=false": oauth2: cannot fetch token: Post "https://oauth2.googleapis.com/token": dial tcp <IP_ADDRESS>:443: i/o timeout' in 'attach_disk' CPI method (CPI request ID: 'cpi-117739')
Is there a way to extend the timeout period or retry mechanism, so even if the update will take longer, it will eventually complete without failing or if you have other suggestions for workaround this kind of network issue.
Best Regards,
Deyan

Hi @dejanangelov86,
I don't think that an extended timeout will help here because the connection is reseted. Regarding the retries, the error can happen with all bosh operations and actions like create_vm or create_disk can't be retried because you don't know whether a VM was created successfully or not. Like the disk snapshots  in your case which get created successfully. Retrying will produce orphaned resources. I would suggest you to analyse the connectivity between the source machine to the google API as already suggested in the GCP support ticket. Analysing network issues is not easy but it should be possible to find out where the connection gets reseted. Is the source machine where the BOSH CPI is running also running in GCP? If yes, you could use GCP tools to analyse the network traffic when the error happens.

there has been no activity on this issue for more than 2 weeks.
if you still experience this please reopen this issue