Application crash after updating modules: get of get_set_descripter

This happened after updating various modules of an existing application. The error in question only occurs in the frozen application package, not from source code. As nothing in the application itself has changed, the error is almost certainly in one of the modules mentioned in this log. Since it ends on six I posted it here.
We don't use six ourselves, only modules we use do. As we target Python 3.6.x exclusively.
  File "C:\Program Files\Python36\lib\site-packages\cx_Freeze\initscripts\__startup__.py", line 14, in run
    module.run()
  File "C:\Program Files\Python36\lib\site-packages\cx_Freeze\initscripts\Console.py", line 26, in run
    exec(code, m.__dict__)
  File "main.py", line 16, in <module>
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "D:\Projects\HonorarPlus\conlib.py", line 9, in <module>
    import shared
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "D:\Projects\HonorarPlus\shared.py", line 19, in <module>
    pwd_context = CryptContext(schemes=["argon2"])
  File "C:\Program Files\Python36\lib\site-packages\passlib\context.py", line 1401, in __init__
    self.load(kwds)
  File "C:\Program Files\Python36\lib\site-packages\passlib\context.py", line 1592, in load
    config = _CryptConfig(source)
  File "C:\Program Files\Python36\lib\site-packages\passlib\context.py", line 634, in __init__
    self._init_scheme_list(source.get((None,None,"schemes")))
  File "C:\Program Files\Python36\lib\site-packages\passlib\context.py", line 652, in _init_scheme_list
    handler = get_crypt_handler(elem)
  File "C:\Program Files\Python36\lib\site-packages\passlib\registry.py", line 350, in get_crypt_handler
    mod = __import__(modname, fromlist=[modattr], level=0)
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "C:\Program Files\Python36\lib\site-packages\passlib\handlers\argon2.py", line 46, in <module>
    import argon2 as _argon2_cffi
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "C:\Program Files\Python36\lib\site-packages\argon2\__init__.py", line 5, in <module>
    from . import exceptions, low_level
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "C:\Program Files\Python36\lib\site-packages\argon2\low_level.py", line 15, in <module>
    from six import PY3
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "C:\Program Files\Python36\lib\site-packages\six.py", line 318, in <module>
    moves = _MovedItems(__name__ + ".moves")
  File "C:\Program Files\Python36\lib\site-packages\six.py", line 128, in __init__
    self.__doc__ = self.__class__.__doc__
SystemError: <method-wrapper '__get__' of getset_descriptor object at 0x0000027A45803BD0> returned a result with an error set

Same issue with PySide2 5.12.1, as reported also here: https://github.com/pyinstaller/pyinstaller/issues/4040
Any idea on what upstream change could have caused this issue?

FYI, I reported the issue on the PySide2 tracker:
https://bugreports.qt.io/browse/PYSIDE-942

It looks like this was resolved on the PySide side.


docs: Add info on resolving merge conflicts to git-guide.md.

Fixes #5586.

Automated message from Dropbox CLA bot
@vaidap, it looks like you've already signed the Dropbox CLA. Thanks!

Codecov Report

Merging #5618 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5618   +/-   ##
=======================================
  Coverage   87.62%   87.62%
=======================================
  Files         437      437
  Lines       54555    54555
  Branches     2109     2109
=======================================
  Hits        47805    47805
  Misses       6750     6750

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5046...c14f70f. Read the comment docs.

@vaidap a quick comment: when you have a new version ready for review, please post a comment saying so on the GitHub PR thread.  GitHub does not do a good job of notifying maintainers if you don't do that.

Merged, thanks @vaidap!, after editing the commit message to specify it should close #5586 (it looks like you only had that in the PR description, not the commit message).

thanks for the advice, i'll make sure to do those things from now on. :)


ajax posts loading taking too much time

in this library, it is conflicted with ajax posts, ajax requests taking too much time to complete with it.
it takes to load the same time as the loop takes to complete whatever you set the loop time.
I have set the $exec_limit = 3; $sleep_time = 1; and $client_reconnect = 2;
so why it is conflicting with ajax requests?
please fix this issue.

Do you use sessions with your AJAX calls or SSE loops? If yes, you need to do a session_write_close() to release the PHP session lock that caused the issue.

what is the example of it?
I have separate php file where I send ajax requests.

thanks for giving me problems solution :smile:  hats off :smiley:

Where do I put the session_write_close()
The problem still persists and is slowing down the whole network.
All the network calls have a high TTFB (Time To First Byte)


No humidity?

Hi there, thanks for the package. I've used it for BME280 sensor. This works great for temp and pressure, but always displays 0% for humidity. Any ideas why? Maybe its the sensor itself, but I previously had it set up through SignalK with the Venus Large OS and it worked there.

It should work, check the log for any errors.


Cursor animation in insert mode

Hi! I just want to ask if there is a way to increase the speed of the cursor animation when inside insert mode? Because whenever I'm typing anything, it feels like theres a delay because the | cursor lags behind with the animation.
Like this

See how the w is already there but the cursor is still in the middle of q and w?
I tried using the  neovide_cursor_animate_in_insert_mode setting but I kinda missed the fluidity of the default setting.
Thank you in advance!

Did you try changing the value of g:neovide_cursor_animation_length?


Errors with angular

Hi,
Thank you for this library, it looks really convenient, but I cannot seem to make it work with angular.
I made a minimal example to reproduce the problem I'm having:
https://github.com/xbauquet/angular-easy-web-worker
Just run ng serve after your npm install and you should see the errors.
I'm not sure to understand what's happening but to me it looks like a conflict between the lib worker and the lib dom.
Here is a little part of the errors (there's to many to past here):
Error: node_modules/typescript/lib/lib.webworker.d.ts:6051:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'onunhandledrejection' must be of type '((this: Window, ev: PromiseRejectionEvent) => any) | null', but here has type '((this: DedicatedWorkerGlobalScope, ev: PromiseRejectionEvent) => any) | null'.

6051 declare var onunhandledrejection: ((this: DedicatedWorkerGlobalScope, ev: PromiseRejectionEvent) => any) | null;
                 ~~~~~~~~~~~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:18264:13
    18264 declare var onunhandledrejection: ((this: Window, ev: PromiseRejectionEvent) => any) | null;
                      ~~~~~~~~~~~~~~~~~~~~
    'onunhandledrejection' was also declared here.

Error: node_modules/typescript/lib/lib.webworker.d.ts:6053:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'self' must be of type 'Window & typeof globalThis', but here has type 'WorkerGlobalScope & typeof globalThis'.

6053 declare var self: WorkerGlobalScope & typeof globalThis;
                 ~~~~

  node_modules/typescript/lib/lib.dom.d.ts:17912:13
    17912 declare var self: Window & typeof globalThis;
                      ~~~~
    'self' was also declared here.

I would really appreciate any help you can give me.

It looks like adding "skipLibCheck": true to the tsconfig.json remove these errors, but it's a little bit annoying to loose lib check. Any other solution / idea ?

Hi @xbauquet ,
I added the dependency webworker to typescript that should solve the issue, please let me know if it works for you.
Regards


Tooltips on imports are useless

VSCode Version: 1.12.0-insider (0bec1157)
OS Version: Windows 10

If you have an ES6 import like so:
import { someFunction } from './myfile.js';

I get the JSDoc for someFunction when I use it, but if I simply hover over the import, the tooltip reads import someFunction.  There is opportunity to show the JSDoc which would be far more relevant. For reference, I'm using TypeScript.

I agree the current behavior is pretty useless. https://github.com/Microsoft/TypeScript/issues/5515 tracks this upstream on the TypeScript side. I'll see if we can get this prioritized
Closing as upstream


Question about usage

From the docs

You’re welcome to use the template even if your service isn’t considered part of GOV.UK, but your site or service must not:

identify itself as being part of GOV.UK
use the crown or GOV.UK logotype in the header
use the GDS Transport typeface
suggest that it’s an official UK government website if it’s not

Does this mean a different font must be used when using this template?

Hello Sean - yes that's correct (if you're using the template for something that's not on GOV.UK). However Tech Docs Template pages should automatically use Arial if they can't find the GDS Transport typeface.
Hope that helps - feel free to reopen this issue if you have any more questions.


Update eventDataFilter to call out that the entire event can be accessed

Signed-off-by: Jorgen Johnson<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please specify parts this PR updates:

[ ✅  ] Specification
[ ✅  ] Schema
[ ✅  ] Examples
[ ] Extensions
[ ] Roadmap
[ ] Use Cases
[ ] Community
[ ] TCK
[ ] Other

What this PR does / why we need it:
Add some clarity on what eventDataFilter can access from the event.
Special notes for reviewers:
If you look at the examples that were updated, there were several that were already assuming that the whole event was being added to stateData, hence why there are several examples where I added data: ${ . }.
It seems that a good number of the examples were already acting as if this was the case that the whole event would be filtered (not just the payload).  I think, given the number of examples that were assuming this, that we should reconsider whether the default 'data' value should be ${.data} or just ${ . }.
Additional information (if needed):

Related to #248

As discussed in the community meeting, I'll update this to say that the default is the whole event (rather than just the payload).

@jorgenj i cant think of a better name for it :) we can ask in meet if anyone has a good one

I am still kinda weird about this change.
In our correlation rules we limit the expressions to context attributes only (no data). there you can specify that
for example you only want events with the starting id of like "abc-*" for example. (or should at least we can add if not possible" as well as define the source and the specversion etc.
Now let's say that you run the workflow on 2 different runtimes , which support 2 different release versions of cloudEvents.
It is MUCH easier to just have to then modify the reusable event definitions, than having to update all your workflow control flow logic expressions.
The fact is is that if we do allow CE context attributes to be used inside control flow logic, people will use it and that to me lowers the portability.
I still don't have a single concrete example workflow where you would care about the CE context attributes and not just the payload. All the non-domain-specific things should be defined in your event definition, and the control-flow logic which executes your business logic should only care about the data part.
@mswiderski wdyt about this ?

@tsurdilo I totally agree with you, and too fail to see the added value of the proposed changed. In addition, Cloud Event is to my understanding a simple enveloppe, something that is related to the transfer/routing/correlation aspect of the data, just like an HTTP request. As the spec does not allow explicitly accessing the context of any kind of other application protocols (HTTP, GRPC, ...), IMHO the context attributes should not be made available for data-related operation.

I also agree that data passed to the workflow instance (to its state) should only contain payload of the event. Event itself should be available for processing of the event like matching on attributes etc. regardless of the protocol used then can be accessed and used but should not be part of the state of workflow instance. With that it should not be required to prefix access to state data with data

@tsurdilo I totally agree with you, and I too fail to see the added value of the proposed changed. In addition, Cloud Event is to my understanding a simple enveloppe, something that is related to the transfer/routing/correlation aspect of the data, just like an HTTP request. As the spec does not allow explicitly accessing the context of any kind of other application protocols (HTTP, GRPC, ...), IMHO the context attributes should not be made available for data-related operation.

This was discussed in the meeting, it's not as simple as viewing the envelope as a 'transport protocol', for example the ID is a unique identifier of the event from the source system, which is extremely useful for workflows that may be themselves distributing events (for example the SAGA pattern) as that can be used as an idempotency token in the downstream services.   The counter-argument is that workflow users should just add their own arbitrary idempotency token to the event payload instead, which completely ignores the case where the user doesn't have control over what the event source adds to the payload of the event.

@mswiderski @Neuroglia -- @jorgenj  made good points about being able to in some cases add the entire event.  We talked in meet and will add a flag to allow users a choice if they want to include context attributes + payload info or not.
@jorgenj and i promise won't change mind again :)

Are these points described somewhere? Sorry couldn’t make it to the meeting

having this extra parameter that will control if entire event or just payload should be given to the workflow sounds bit weird to me. Especially that when you then get data out of the workflow instance you get the entire event which will certainly not be desired in most of the cases.
At the same time I do see the value in having access to some of that data but I am not convinced the workflow definition should be concerned with that. We should keep in mind that cloud events have different bindings and these bindings control how the metadata are given. Sometimes they are in protocol specific headers (http) or some message specific header (kafka) and so on   So it won’t be always as single json object and constructing that from various bindings might not be optimal to say the least.
maybe instead we should define some kind of execution context that would provide access to that kind of data that are sort of request scoped. That way workflow can have access to that data at the time event is being consumed but won’t store it in the instance state.
Very rough idea but what’s your thoughts on this approach?

We should keep in mind that cloud events have different bindings and these bindings control how the metadata are given. Sometimes they are in protocol specific headers (http) or some message specific header (kafka) and so on So it won’t be always as single json object and constructing that from various bindings might not be optimal to say the least.

This doesn't seem to have much bearing on how the event is exposed by the runtime to the workflow definition, if you look back at the original issue (#248), I believe @tsurdilo consulted with a cloud-events expert to confirm that in fact any cloud-event should be capable of being expressed as a JSON object regardless of what protocol it was transmitted via.
"Not optimal" from what perspective?  The runtime will already be dealing with the potentially large payload, optionally making the relatively smaller envelope available as well seems like a trivial concern.

maybe instead we should define some kind of execution context that would provide access to that kind of data that are sort of request scoped. That way workflow can have access to that data at the time event is being consumed but won’t store it in the instance state.

Isn't this exactly what this PR is proposing, that the whole event be made available at the time of event consumption (and that it's the workflow users prerogative which parts of the entire event be saved, as they see fit for their use-case)?

Isn't this exactly what this PR is proposing, that the whole event be made available at the time of event consumption (and that it's the workflow users prerogative which parts of the entire event be saved, as they see fit for their use-case)?

yeah but it comes at a price which i think can be avoided:

yes ce can be transformed to json but now we have to enforce it
we are enforcing for every runtime to make both the envelope and the payload available.

I am not saying to avoid this by not having this functionality but to think about how this can be solved while not enforcing 1) and 2) via the DSL
one thing that comes to mind is to force eventfilter definitions to use let's say an "envelope" and "payload" prefix to access each. That way a runtime could during parse time know that:

envelope info is needed
transform CE to json

if that runtime is not capable of doing this it would be able to enforce the users during design/compile time of this error rather than at runtime.

What can we do to move this forward? Really would like to get this resolved soon if possible.

What can we do to move this forward? Really would like to get this resolved soon if possible.

@tsurdilo I posted an update with what was requested in the last community meeting but it's not clear to me if the goal-posts have been moved again since then or not.

@jorgenj ok relax :)
updated some text and fixed the readme
and by the way, typically you dont turn off something in boolean flags, its not natural.
i think it would be better to do like "includeEventContext" or something and force users to set it to true to enable it, than but I will open a new PR on this don't worry :)


change resource docs from 3-col to 2-col layout

overview
changing the docs to present data in a 2-col layout instead of 3-col layout which should make the content a bit easier for folks to consume
part of #234
you wont be able to use the link to view the pages, but I've included a few screenshots
screenshots
before

after

The two preview links above seem to be missing all API reference docs - is that expected?

@lukehoban yah we wont be able to preview it until it gets to the docs repo


finger-printing assets in production builds

I noticed that when I do a production build my web-workers/*.js get fingerprinted...however the worker service isn't aware that the worker filenames are changed so we get a 404.  I fixed it by adding a fingerprint: { exclude: ['web-workers']} to my ember-cli-build.js, but I think it might be good to support fingerprinting of the worker js files.  Any ideas?

so this seems to work:
    //leave this for fingerprinting - the string gets replaced with the fingerprinted filename
    let workerFilename =  "assets/web-workers/sha.js"
      .replace('assets/web-workers/','')
      .replace('.js','');

    try {
      file.hash = yield this.worker.postMessage(workerFilename, file.blob)
    } catch(err) {...}```

because broc-asset-rev searches your files and automajically updates filename strings with the fingerprinted filenames

Hi @mattmarcum,
Nice to know! Maybe we can add this solution to our README. Thanks for pointing it out!


Issue with /docs/tutorials/kubernetes-basics/cluster-interactive/

This is a...

[ ] Feature Request
[X ] Bug Report

Problem:
I don't think it's really a bug, just an observation.  The build date for the server showed up as Linux epoch (BuildDate:"1970-01-01T00:00:00Z").  Thought I would pass it along.
Proposed Solution:
Page to Update:
http://kubernetes.io/...

Thanks!


resources/perf: Upgrade perf to v6.7

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have updated the relevant documentation.
[ ] I have added tests for new logic.

Closes: https://github.com/Granulate/gprofiler/issues/820


SOF-752 add support for multiple Viz shows

Removes Show ID as the option of the VizMSE TSR device.
Show ID is now a property of each Internal Element and its Expected Playout Items.
Show lifecycle is no longer dependent on makeReady and standDown, instead cleanup and initialization are triggered by the new CLEANUP_SHOWS and INITIALIZE_SHOWS timeline objects.
Depends on https://github.com/tv2/v-connection/pull/34

Maybe I am missing something, but isn't this supposed to use the new changes from V-connection? I don't see anything that indicates that is going to use a new version of V-connection?


[Fix](multi catalog, nereids)Fix text file required slot bug.

<--Describe your changes.-->
required_slots in TFileScanRangeParams params for external hive table may be updated after FileQueryScanNode finalize. For text file, we need to use the origin required_slots in params so that the list could be updated later. Otherwise, query text file may get the following error:
[INTERNAL_ERROR]Unknown source slot descriptor, slot_id=3
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Fix/multiple to single select

Fix multiple to single select vc
small fix
redesign select vc(small fix)

Implemented PIN functionality
https://github.com/did-developer-community/custom-identity-wallet/issues/1


[FLINK-22889] Add debug statements to JdbcExactlyOnceSinkE2eTest

What is the purpose of the change
Log for JdbcExactlyOnceSinkE2eTest: db type, progress, errors, task transitions, wait times.
Using hardcoded string to prevent log parsing scripts from failing CI (on expected exceptions).
Sample size: 200Kb
Sample output:
2021-07-06 22:31:29,074 INFO test insert for postgres:9.6.12, parallelism=4 [main JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,698 DEBUG Mapper will fail after 3 records [Source: Custom Source -> Map -> Sink: Unnamed (3/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,698 DEBUG Mapper will fail after 6 records [Source: Custom Source -> Map -> Sink: Unnamed (4/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,698 DEBUG Mapper will fail after 14 records [Source: Custom Source -> Map -> Sink: Unnamed (2/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,698 DEBUG Mapper will fail after 10 records [Source: Custom Source -> Map -> Sink: Unnamed (1/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,699 DEBUG Source initialized with ranges: [100..150] [Source: Custom Source -> Map -> Sink: Unnamed (3/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,700 DEBUG Source initialized with ranges: [0..50] [Source: Custom Source -> Map -> Sink: Unnamed (1/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,700 DEBUG Source initialized with ranges: [150..200] [Source: Custom Source -> Map -> Sink: Unnamed (4/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,701 DEBUG Source initialized with ranges: [50..100] [Source: Custom Source -> Map -> Sink: Unnamed (2/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,952 DEBUG Mapper failing intentionally [Legacy Source Thread - Source: Custom Source -> Map -> Sink: Unnamed (3/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:29,956 DEBUG Mapper failing intentionally [Legacy Source Thread - Source: Custom Source -> Map -> Sink: Unnamed (4/4)#0 JdbcExactlyOnceSinkE2eTest]
2021-07-06 22:31:30,018 WARN Source: Custom Source -> Map -> Sink: Unnamed (4/4)#0 (8571da132faab99391432bab1182eeed) switched from RUNNING to FAILED with failure cause: org.apache.flink.connector.jdbc.xa.JdbcExactlyOnceSinkE2eTest$TestException: java.lang.Exception: Artificial failure
 [Source: Custom Source -> Map -> Sink: Unnamed (4/4)#0 Task]
2021-07-06 22:31:30,018 WARN Source: Custom Source -> Map -> Sink: Unnamed (3/4)#0 (e96da42632e92d517950d5aed126d87f) switched from RUNNING to FAILED with failure cause: org.apache.flink.connector.jdbc.xa.JdbcExactlyOnceSinkE2eTest$TestException: java.lang.Exception: Artificial failure
 [Source: Custom Source -> Map -> Sink: Unnamed (3/4)#0 Task]

Thanks for the review @AHeise.
I've addressed your comments, PTAL.

Merged as 7b9aac3d00c9ebf2bf35d7d14e5ebc36280ceea2


Do not hide section of size < 20

Hi again,
since we have to total control over what to draw or not using hide-xxxx, is this code still needed ?
https://github.com/raulgotor/linkerscope/blob/d74f20fb71916d6c4cacc912cbeeb96606379c3c/map_render.py#L498
I recently used hide-name: true and  hide-size: true only to show the end address of a memory section:
sectionA starts at 0xFFF8 but is only 8 bytes
sectionB starts at 0x2000 and so ends when sectionA starts
my goal was to draw something like
sectionA ------- |.             | 0xFFF8
                 |.             |
...
                 |. secA        |
...
                 |.             |  0x2000
                 ---------

(using link for sectionA)
It took me 2hours to understand why my 0xFFF8 wasn't printed :(
I do understand address's text could overlap and section name won't fit on a less than 20 pixels section, but it locks an interesting use case
....unless there is another way to do it I missed again!

Quickly implemented it: PR, please check it out.
Now, hidde-xxxx can be yes, no or auto with auto as default. true and false are kept for backwards compatibility.


[Release 1.25] Update flannel version to 0.22.2

Backport: https://github.com/k3s-io/k3s/issues/8218

Validated on release-1.25 branch with commit 80e1c74a6ef5a6ca26b6320d67a7adbc5bc759c1
Environment Details

Infrastructure

[x] Cloud
[ ] Hosted

Node(s) CPU architecture, OS, and Version:

$ cat /etc/os-release | grep PRETTY
PRETTY_NAME="Ubuntu 22.04.2 LTS"

Cluster Configuration:

HA: 3 server/1 agent

Config.yaml:

token: blah
cluster-init: true
write-kubeconfig-mode: "0644"
node-label:
- k3s-upgrade=server

Additional files

Testing Steps

Copy config.yaml

$ sudo mkdir -p /etc/rancher/k3s && sudo cp config.yaml /etc/rancher/k3s

Install k3s

$ curl -sfL https://get.k3s.io | sudo INSTALL_K3S_COMMIT='80e1c74a6ef5a6ca26b6320d67a7adbc5bc759c1' sh -s - server

Get Flannel Version using:

/var/lib/rancher/k3s/data/current/bin/flannel -v

Apply a test workload - clusterip.yaml
Sample yaml:

apiVersion: v1
kind: Pod
metadata:
  name: clusterip-pod-demo
  labels:
    app1: clusterip-demo
    app.kubernetes.io/name: clusterip1
    app.kubernetes.io/kind: pod
    common: app
spec:
  initContainers:
  - name: init-myservice
    image: busybox:1.28
    command: ['sh', '-c', "sleep 5"]
  containers:
  - name: nginx-container
    image: nginx

Validation Results:

k3s version used for validation:

$ k3s -v
k3s version v1.25.12+k3s-80e1c74a (80e1c74a)
go version go1.20.6

/var/lib/rancher/k3s/data/current/bin/flannel -v
CNI Plugin flannel version v0.22.2 (linux/amd64) commit HEAD built on 2023-08-18T09:49:26Z
CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0

As we can see, the flannel version has been updated to v0.22.2 as expected. Marking Verified/Closed.
Server/Agent node/pod status:
$ kubectl get pods -A
NAMESPACE     NAME                                      READY   STATUS      RESTARTS   AGE
default       clusterip-pod-demo                        1/1     Running     0          73s
default       clusterip-pod-demo-2                      1/1     Running     0          73s
default       clusterip-pod-demo-3                      1/1     Running     0          73s
kube-system   coredns-8b9777675-hcdzw                   1/1     Running     0          5m21s
kube-system   helm-install-traefik-4gvh2                0/1     Completed   1          5m21s
kube-system   helm-install-traefik-crd-x7qx2            0/1     Completed   0          5m21s
kube-system   local-path-provisioner-69dff9496c-8tkh6   1/1     Running     0          5m21s
kube-system   metrics-server-854c559bd-gdwjz            1/1     Running     0          5m21s
kube-system   svclb-traefik-5f8ffcf8-2rzm6              2/2     Running     0          5m1s
kube-system   svclb-traefik-5f8ffcf8-4f2pw              2/2     Running     0          4m6s
kube-system   svclb-traefik-5f8ffcf8-8tm49              2/2     Running     0          5m1s
kube-system   svclb-traefik-5f8ffcf8-wtl2l              2/2     Running     0          3m26s
kube-system   traefik-66fd46ccd-6njz7                   1/1     Running     0          5m1s
$ kubectl get nodes
NAME               STATUS   ROLES                       AGE     VERSION
ip-172-31-17-55    Ready    control-plane,etcd,master   6m29s   v1.25.12+k3s-80e1c74a
ip-172-31-18-55    Ready    control-plane,etcd,master   5m18s   v1.25.12+k3s-80e1c74a
ip-172-31-23-124   Ready    control-plane,etcd,master   4m20s   v1.25.12+k3s-80e1c74a
ip-172-31-25-20    Ready    <none>                      3m45s   v1.25.12+k3s-80e1c74a


The demo site will go down for months

We haven't paid for servers because the demo site serves turms v0.9.0 but we don't want to pay for v0.9.0 further.
And we will set up the demo site again once we release v0.10.0 (preflight for the official release) and it may take several months.

Closed. We just published the cluster for the demo site again.


make resource concurrent sync configurable

Make resource concurrent sync configurable for kube-controller-manager as there are cases where you need to change sync task count.

ci check this

/lgtm

/assign @mattymo


Azure env variables are ignored

Issue
I have installed aider ( version aider 0.59.1)  in Ubuntu.
CPython 3.10.12
I followed the installation manual and exported the following variables:
export AZURE_API_KEY=mykey
export AZURE_API_VERSION=2024-08-01-preview
export AZURE_API_BASE=https://mybase.openai.azure.com/
aider still looks for an OPENAI key and I get this error message as soon as I try to do anything:
"Unexpected error: litellm.AuthenticationError: AuthenticationError: OpenAIException - The api_key client option must be
set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable"
Version and model info
No response

In the documentation: https://aider.chat/docs/llms/other.html there is mention that "other models" including Azure OpenAI are supported via LiteLLM and for Azure, there is AZURE_AI_API_KEY environmental variable expected. Not sure abut the rest (version, base).

Thanks for trying aider and filing this issue. This doc may be helpful:
https://aider.chat/docs/llms/azure.html

I'm labeling this issue as stale because it has been open for 2 weeks with no activity. If there are no additional comments, it will be closed in 7 days.

I have tried both AZURE_API_KEY and AZURE_AI_API_KEY and it still doesn't work.
I do not know what further update I should provide. I clearly stated what are the variable exports I have used.
One thing that I have noticed is that the versions available on Azure don't match the versions displayed by Aider in the informational message.
So for example on Azure I can distribute gpt4-o version 2024-08-01 and that doesn't match gpt-4o-2024-08-06 .
The azure versions is also reflected in the Azure endpoints; this is the full endpoint for the gpt-4o model I distributed:
https:/mybaseurl/openai/deployments/gpt-4o/chat/completions?api-version=2024-08-01-preview
and I do not see how the various enviornment variables can be used to build this url.
Is the integration with azure models tested before each aider release?

This works for me with a deployment like:
AZURE_API_BASE=https://foo-bar-baz.openai.azure.com/openai/deployments/gpt-4o-foo/chat/completions?api-version=2024-08-01-preview

and starting aider like so:
aider --model azure/gpt-4o-2024-08-06


Text Tool

Hello,
currently the text tool add a new text in the center of the working view.
How i can set added text to the top left?
Thank for your answers
Kevin

You cannot control text position currently. You should modify CLTextTool.

and how i can do this?
Kevin


Cc based on master

Description
Transfer the selective build feature from onednn v2.4 to v2.6 (Similar but adapt to some code's change in v2.6).
Fixes # (github issue)
Checklist
General

[ ] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
[ ] Have you formatted the code using clang-format?

Performance improvements

[ ] Have you submitted performance data that demonstrates performance improvements?

New features

[ ] Have you published an RFC for the new feature?
[ ] Was the RFC approved?
[ ] Have you added relevant tests?

Bug fixes

[ ] Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
[ ] Have you added relevant regression tests?

RFC PR

[ ] Does RFC document follow the template?
[ ] Have you added a link to the rendered document?

OpenVINO selective PR: https://github.com/openvinotoolkit/openvino/pull/12058


Unable to work on android

Is there anything which we missed. It's not swiping at all.

Could you provide any more info? Did you follow the documentation? Did you try the sample?
As far as I know everything still works as documented.

yes we followed the documentation and implemented the same. It works like a charm in iOS but in Android the drag is very hard and it happened when dragged on the right & left bottom corner. we have used the swiping commands for left and right. we are unable to drag from the center of the image.

If you download the sample app from this repo and try it on your Android device, does it behave the same?
Maybe the pictures you use on Android are too big, so Xamarin/Android is not able to render them fast enough?

For big pictures we already used FFMPEGCached image library. Inside the DataTemplate we are using Frame for giving shadow and radius. Can you please advice how can we do it just like a demo

My advice is to start from the sample project, which works fine, and then gradually start updating the template with your elements and test incrementally. That way you will figure out what is putting too much weight on the rendering.

If we swipe items too fast sometimes we get black image.
I tried using FFImage but we are using SkiaSharp ImageSourceHandler and generating ImageSource at runtime. So couldnt use FFImageLoading as it says invalid value for ImageSource.
I also tried making SwipeCommand bound to async method.
@markolazic88 Any suggestions?

@pmahend1 I missed your comment. I hope you fixed your issue by now. If not, feel free to open a new issue with as much details as possible. Closing this one.


Remove all default properties related to external services and/or RHDH

Closes FLPATH-1719
Remove all default properties related to external services and/or RHDH
The default values for other properties, such as retries, log level,... have been kept

PR looks good but should we be documenting somewhere the information were erasing? I guess the default suggestion values were supposed to be helpful at some point?

@gabriel-farache pls merge on your own, once the konflux errors are checked.


Update topic descriptions

@W-12339145@
Test update

@iowillhoit , fyi that i closed this PR because the changes to package.json are in another PR that also updates the *md files.


Postbuild command for Hazel project modified

this will ensure that XCOPY command will know that argument number 2  is folder not a file

Done!!

Just to make it clear ... Premake for some reason is removing the last slash from the destination argument (argument number 2) which windows will consider it a file not a folder ... so what i did is just making sure that Premake don't remove that slash by adding quotation marks bracing the destination

Would doing this make sure that VS will create a folder if it doesn't exist, and thus solving the issue of first build failure?


Need enhancement/improvement in signIn and signUp page

Needs improvement in frontend part of  singIn and signup page.
please assigned me under the gssoc'24
@VaibhavArora314
screenshot

sample
after improvement it would look like something this

the screenshot you provided can have a little more width and padding as they are feeling clustered

got it i will add more width and remove the remember option
@VaibhavArora314

@VaibhavArora314.
I raised PR pls review it.


Vulnerabilites in V 0.5.0 of community kubernetes provider

Vulnerabilities in the kubernetes provider image that possibly should be patched for the next release.
screenshot from docker-desktop below.

This is affecting our usage of this provider with customers even if not exploitable. Will shortly open a PR that patches these!


docbook-utils 0.6.14

New formula should be submitted to Homebrew/Homebrew. Please see https://github.com/Homebrew/linuxbrew/blob/master/CONTRIBUTING.md


Update pin-puk-mgmt-key.md

Updated the Default Management key Algorithm for 5.7 firmware release.
Description
The Default PIV 9B Management key algorithm was changed from T-DES to AES-192 in firmware 5.7. This needs to be reflected in the documentation.
Fixes # N/A -
Type of change

[x] This change requires a documentation update

How has this been tested?
N/A
Checklist:

Thanks @Yubi-David
Note that this documentation change doesn't go live automatically. Please reach out to me privately to dicsuss.

Thanks @Yubi-David
Note that this documentation change doesn't go live automatically. Please reach out to me privately to dicsuss.


github: added badges support

closes https://github.com/inveniosoftware/invenio-github/issues/101

For now, the PR was open on top of https://github.com/alejandromumo/invenio-rdm-records/tree/add_invenio_github since there is an open PR for that code (https://github.com/inveniosoftware/invenio-rdm-records/pull/1337)
Either:

Merge https://github.com/inveniosoftware/invenio-rdm-records/pull/1337 first and then we point this one to master
Merge this one on top of https://github.com/inveniosoftware/invenio-rdm-records/pull/1337 and then merge to master


Backport DHIS2 component changes from main branch

Description

Update to latest version of dhis2-java-sdk
Minor API endpoint signature changes to support lists
Support PAT authentication; add async param to resourceTables/analytics
Update examples to use DHIS2 v40; provide better descriptions in Dhis2Configuration

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

For the dhis2-java-sdk? The breaking changes in the SDK are hidden from the Camel developer.

We dont do this kind of big upgrades and changes on patch branches. Closing this PR


Spacebar hotkey for play/pause

Would like to add a test for this, but they don't run at all for me at the moment.

Well. Cypress doesn't know how to send "space" key presses (https://docs.cypress.io/api/commands/type.html#Arguments), so can't test it with cypress.


Use BSD tar on windows

Resolves https://github.com/actions/cache/issues/91
On the Windows Hosted Runners, GNU tar is prepended to the path from the installation of minGW (http://www.mingw.org/). This version of tar doesn't work out of the box with Windows file paths, and required using --force-local and \ file manipulation to work correctly.
On self-hosted runners, there's no guarantee that tar on the PATH will be GNU tar, and BSD tar will fail when encountering the extra --force-local option.
This change enforces using the BSD Tar on Windows, allowing for self-hosted runners to use this action. Self-hosted runners without the system tar will fail, but this is better than the current situation where no self-hosted runners work.
Most of the changes in this PR are just moving the tar code into its own module to isolate testing and reduce repeated code.
The only behavior change is in getTarPath
I verified these changes with a new cache as well as using a cache created by the current v1 to verify compatibility: https://github.com/joshmgross/cache-canary/runs/346337525

Do you know if bsd tar will be available on all windows versions?  Including windows servers?

Do you know if bsd tar will be available on all windows versions? Including windows servers?

Based on https://docs.microsoft.com/en-us/virtualization/community/team-blog/2017/20171219-tar-and-curl-come-to-windows, it was only added in Build 17063, so older versions of Windows won't have it.
I'm not sure if the Windows server will have it. From speaking with @ericsciple, the various npm packages for tar can sometimes be problematic.
The current behavior is that no self-hosted runners will work with actions/cache since it's expecting a GNU tar prepended to the Path, which is unique to our hosted runner images. This at least allows all self-hosted runners using newer versions of Windows to use this action.

Would it be possible to do a 1.0.4 release with this in it? I am trying to set up self-hosted windows runners for a project, but it always fails to cache anything because of the --force-local option not being available on bsdtar and cache ignores the mingw-w64 tar I have first in PATH. I tried to do uses: actions/cache@master but it did not get the dist folder even though it got everything else.

@1480c1 There will be a release soon with this change. In the meantime, if you fork the repository and run npm run release, you should be able to build and commit the dist folder and use that fork of the action.

Okay, thank you. Don't know much about npm yet so I wasn't sure how to solve the issue on my own.


Hide print link component from print version

It does not make sense for the print link to be visible in the printed document.
This adds a design system override class to hide it on the printed version of the page.
Fixes https://github.com/alphagov/govuk_publishing_components/issues/1770

@alex-ju that's a good question – I think the advantage is explained quite well in the commit that introduces this class to govuk-frontend :

This is explicit and preferable to listing all the selectors for things that shouldn't be printed. These lists grow unwieldy over time

Using the class instead of explicit display: none rules can help us reduce the size of our print stylesheet.
This reminds me around a year ago I set out to remove display: none rules from component print stylesheets in favour of using the govuk-!-display-none-print class  https://github.com/alphagov/govuk_publishing_components/pull/1561/.
Can't quite remember why I never came to finish that task, but I digress 😅

@alex-ju that's a good question – I think the advantage is explained quite well in the commit that introduces this class to govuk-frontend :

This is explicit and preferable to listing all the selectors for things that shouldn't be printed. These lists grow unwieldy over time

Using the class instead of explicit display: none rules can help us reduce the size of our print stylesheet.
This reminds me around a year ago I set out to remove display: none rules from component print stylesheets in favour of using the govuk-!-display-none-print class #1561.
Can't quite remember why I never came to finish that task, but I digress 😅

This change is certainly welcomed and it seems to be aligned with the work you've done in #1561.
This is very much related to a wider conversation about class composition but also about the way we use override classes from govuk-frontend, but since we're currently using override classes widely and we embraced class composition for styling links and headings, I assume the community is fine with the approach.
Do you think you'd have the time to rebase #1561 (add cherry-pick this commit) so we have a consistent way of doing this at the library level?

Do you think you'd have the time to rebase #1561 (add cherry-pick this commit) so we have a consistent way of doing this at the library level?

Your suggestion sounds sensible @alex-ju. I'll try to do that today.
I just have a nagging feeling that there was some good reason that I abandoned that PR, and it's evading me right now. 😄  It will probably come back when I go to rebase that branch.


Navigate to post on quotes.

The idea here is to have the "quote popup" close and scroll back to the post in question, when you click only. Without it you have to close the whole chain of quotes and find it manually.
Somewhat similar behavior with the clover app.

It's already done in https://github.com/Mishiranu/Dashchan/commit/33ba4213202a1c5432f7fc32d05055e994db9633, will be available in next release.

Wow, that was quick, thanks mate!


[BUG] USER INPUT HANDLING IN generate_predictions FUNCTION

The conversion of user input assumes all values can be converted to float. But if the dataset includes categorical features, we need to handle those differently. I have corrected the particular block of code.
Also I have attached the before and after codes.
Please look into this and assign me this problem @ombhojane Sir
Before :

After :

okayy go ahead!

Can i contribute to this?


Feedback - 8.05.2022

[x] Remove IsComplete check for ReInspection, DQ, FTQ, Ret
[x] Check Ranking for Kids category
[x] Check Athlete/Participant/Horse removal

Implemented.


Added a cache version variable to the service worker

With this enhancement, you now have access to variable called CACHE_VERSION which you can use to version your cache.
The version is pulled from your package.json
const CACHE_VERSION = "1.1.0";

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   91.42%   91.42%
=======================================
  Files           9        9
  Lines         105      105
  Branches       13       13
=======================================
  Hits           96       96
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6186c3...a033593. Read the comment docs.


parse aliases in addresses for eth_sendTransaction

PR description
First step to take care of #148
Out of scope changes

I fixed the wrong behavior of the API which would return a string containing a JSON array of key string. Now it returns the JSON array directly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Normally I fixed everything and made the file/folder structure mirror of that from store


how to modify tridennet ? which .py files need to modify?

In README.md
config
What does out of resource in config mean in README.md?
For example, I am going to modify the tridentnet, so which .py files might I need to modify?
thanks everyone!
happy new year!

That means we recommend to make a copy of config file and modify. You can try any one of the configs starting with config/trident*.


Index based API

Cleanroom implementation of https://github.com/vislyhq/stretch/issues/17#issuecomment-488333064
Interface is identical as the one showed in the issue
Review Notes

Easiest to review commit by commit
Prepare algo for transition towards index based API  should be reviewed in whitespace-ignore mode as it's mostly formatting
The generated tests all pass, even though I'm not 100% confident about my changes in the algo module. This is mostly due to 'deadcode' appearing after moving away from assembling the layout tree in the compute result.

TODOs

[x] Implement missing functions
[x] Port benchmarks, examples and handwritten tests

test result: ok. 238 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
yay!

Thanks for doing this! As to how to move forward I would really like to wait for a comment from @anp as his design is quite similar to this in many ways (with addition of salsa usage).

I think this API looks great! It’s pretty similar to what salsa generates in terms of storage, so I think it’s pretty compatible if we want to implement this api on top of salsa.

I think this API looks great! It’s pretty similar to what salsa generates in terms of storage, so I think it’s pretty compatible if we want to implement this api on top of salsa.

Fantastic! Then I think this is probably a good first step and then potentially we do salsa after as an internal optimization.

I think this looks good enough to start implementing. The only concern I have is of safety. Currently node.set_style(style) or similar cannot fail in any way. However with this change stretch.set_style(node, style) can fail (possibly silently) because you could pass it a Node (just an id) which actually belongs to another stretch instance. Is there any good way to could fix that? Maybe only allow one stretch instance at one time? Or maybe in some way tie the node id to a specific stretch instance?

That's a good point. I would suggest using an ID w/ generation for both stretch instances and nodes.
The allocator for the stretch instance ID would be global, and the Id allocator for nodes per instance.
Both IDs would be encoded in the NodeId. This should prevent any sort of aliasing or collisions up to several million (billion?) alloc/delete cycles.

@msiglreith Sounds like plan! Look forward to seeing it. Also unless you want to try it yourself i'm happy to fix all the language bindings once the main API has been ported so don't worry about that. Also here to help in any way!

Maybe only allow one stretch instance at one time?

Actually, such an approach would be appealing for building APIs on top of the currently discussed ECS/database-y APIs in general. It would allow to rebuild for example the current master API.

Also unless you want to try it yourself i'm happy to fix all the language bindings once the main API has been ported so don't worry about that. Also here to help in any way!

Awesome, thanks! I will definitely give it a shot and otherwise come back to your offer :D

First iteration done with all API changes. Feedback on the current state would be good if we are steering in the right direction.
Next steps:

Add missing utilities for removing nodes
Optimize storage (currently bare-bone hashmap which can be quite slow) but need to understand the domain a bit better

@anp

The language bindings should always have catch_unwind around the rust code because it’s UB to unwind from rust into an FFI function. Maybe I should open an issue to discuss this rather than commenting on a random diff?

Yes please do!

@msiglreith I think it looks good! How are benchmarks doing at this point compared to current implementation?

@msiglreith Anything I can help with to get this merged?

@emilsjolander sry, I didn't find much time working on this PR in the last days.

How are benchmarks doing at this point compared to current implementation?

That's point I'm currently looking into it as it's currently a regression of up to 70% in the benchmarks. A significant part of this are construction times of the layout tree. hashbrown and compacter indices helps to bring it down to ~40% on my machine. I'm still not happy with that part. Will try to look into datalayouts a bit more in the future.

Anything I can help with to get this merged?

If you could help with language bindings that would be awesome! As they don't seem to be covered by CI yet I guess it would involve some setup time for me here to get enviroments up and running.

@msiglreith Happy to do all the language bindings once we are happy with the core! Will hold off until we get performance in a good place, agree that a 40% regression is not good, I feel like this model should actually be able to improve performance as we don't need to do any runtime borrow checking with Rc.

With a bit of profiling and refactor (adjust data layout, prealloc and datastructure) I'm currently ending up within the same ballpark performance wise as the master branch (slightly faster but there is some variance in the benchmarks in general). I'm looking into finishing it up within the next few days to unblock this PR.

quick status update: open API points for now are clearing and removing nodes from the Stretch tree, I'm aiming on finishing it up til the end of the week to avoid blocking stuff for too long.

@msiglreith Awesome! I'll give this WIP another quick review tomorrow but doubt there would be any major issues. Once you have the last things implemented we can merge and I'll fix the language bindings :)

Sorry for the delay! This looks fantastic. Running some local tests but expect to merge later today and I'll start work on porting over the language bindings :) HUGE thanks for all your hard work, I know the community will appreciate it 😃


lower_bound for clio ETL

High Level Overview of Change
clio keeps a table of object successors, which given an object, allows one to look up the next object in a given ledger. clio computes this using an in memory cache, but on startup, the cache is empty. So on startup, clio needs to ask rippled for this information, until clio is able to fill its cache and use the cache. To achieve this, a new function was added to SHAMap, called lower_bound, which returns the first object prior to a given object ID. To implement this function, a new function was added to SHAMap called lastBelow, which returns the last item at or below a given node.

@seelabs this is ready for another look when you get a chance

Can we get an explanation of why clio keeps the table of successors, and how it uses this response to construct that table?

Clio keeps a table of successors to implement book_offers and ledger_data. Both of these RPCs use the upper_bound function of SHAMap, so clio needs to be able to do this as well. Since clio's data model is flattened, and not a tree, doing upper_bound without the successor table would require a table scan, which is quite slow, and becomes slower as history grows.


Issue/styled switch

Added styled switch along with a comprehensive launcher activity that lists all the demo's available.

Good job man!


folder structure

todo item/ testing out this feature.
follow folder structure
| project
|-assets
|--- css
|--- images
|--- js
|-index.html
|-README.md
|-LICENSE

completed by commit - efd4a5d56c3ee5fe7599412cf97bd269c1c249a4


Implement TDD

[x] Setup Test Driven Development, with Rspec and Capybara
[ ]  Add unit tests for models associations and validations (use Rspec hint)
[ ] Add integrations tests for authentication and events management (use Rspec and Capybara hint)

Can I work on Add unit tests for models associations and validations ?

Can I work on Add unit tests for models associations and validations ?

I think @raheebwa already made some but if you want you can contribute making a PR. Also please wait a little until @raheebwa push his changes. But besides that thanks for contribute!

Ok, thanks 😄


Tie point creator does not function correctly with multiple images

 Issue by andyneff
Thursday Feb 04, 2016 at 14:36 GMT
Originally opened as https://github.com/ngageoint/voxel-globe/issues/35

When assigning tie points to a control point, if Images Per page > 1, a ton of bugs start occurring, including but not limited to

You can only click + on one of the images
It will say you must have an active control point selected, when you already do
Eventually Next and Previous Page buttons do not work, and neither will the Page y of x dropdown

Many errors show up on the console, including
TypeError: this.editorState[cp.id] is undefined imageView.js:393:3
TypeError: feature.controlPoint is undefined  imageView.js:130:0
TypeError: controlPoint is null mapView.js:401:7

I think this was introduced back in October 2015 when the API changed, and the tiepoint editor was patched to fix the changes, however multiple images per pages was not tested enough.
Everything seems to function well with one page per image.

Fix merged in with #36


Remove #![feature(or_patterns)]

Fix a warning on CI: https://github.com/rust-lang/miri/runs/2173037929#step:8:59

Great, thanks a lot. :)
@bors r+

:pushpin: Commit 08aef5a8aa889a11e5ce36f795182082d9ba742e has been approved by RalfJung

:hourglass: Testing commit 08aef5a8aa889a11e5ce36f795182082d9ba742e with merge b3f81fc61008a9e997cb49a74ee9681e107e01ed...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing b3f81fc61008a9e997cb49a74ee9681e107e01ed to master...


[cxx-interop] Do not try to import _StringProcessing implicitly

_StringProcessing build might be explicitly disabled, which will break the Cxx and CxxStdlib build.
rdar://106326062

@swift-ci please smoke test

@swift-ci please test Windows

I have a patch over here that resolves this issue: https://github.com/apple/swift/pull/64187

Thanks @Azoy!


Can we support other LLM mode?

I recently published a package llm-client that can be very helpful in enabling the support to run other LLM models, including OpenAI, Google, AI21, HuggingfaceHub, Aleph Alpha, Anthropic, Local models with transformers.

We have support for multiple LLM models at this point.


Tab titles now show cwd (#2907)

Closes #2907 #2886 #1188
This PR is ready to be merged, ran dist build and it works all the same on my Mac.
However, I don't have a PC, or a VM of a PC to test the windows pathing on. Theoretically... It should work as I have kindly borrowed the same code that gets CWD from hyper-statusline

This is not the right approach.
Performances will be heavily impacted.
BTW I'm using oh-my-zsh and my tab title shows my cwd.
But by default, I would have preferred to have current running command. I think that it was the case in hyper 1.X
But feel free to make a plugin with your work 🙏

If I had it read the enter key press to display the current running command would the PR have a chance of being accepted?

@chabou @albinekb Can I get a re-review, I had it watch on enter key presses only.  Or at the very least a hint on what would be acceptable features for a PR? Trying to get something merged for my final project assignment in my OSS class.

@El-Dringo-Brannde willing to pick this up again?


Improve wrong usage of case compile errors

TypeScript Version:  2.6.0-dev.201xxxxx
Code
// This works
for (const cs of [1,2,3]) console.log(cs);

// This doesn't, but the compile error is cryptic
// Variable declaration expected.
// '=' expected.
for (const case of [1, 2, 3]) console.log(case);

Expected behavior:
Emit an error like "case" clauses can only appear in a switch statement
Actual behavior:
Emits these errors:
Variable declaration expected.
'=' expected.

I had this same error message just now and spent like 10 minutes trying to decipher it. It's not a very good error message at all.
It is also printed out for a simple line of code like this:
const case = "123";

Would be cool if it could say something like cannot use reserved keyword as variable name.

Thanks @JoshuaKGoldberg!


WiP: Moving static colors over to Less vars

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[x] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Making it easier to change colors around in the future, and catching a few inconsistencies at the same time. Part of a general effort to move "themable" bits into vars for global re-use.

Codecov Report

Merging #8563 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #8563      +/-   ##
=========================================
+ Coverage   66.66%   66.8%   +0.14%
=========================================
  Files         450     450
  Lines       22734   22734
  Branches     2366    2366
=========================================
+ Hits        15155   15187      +32
+ Misses       7441    7409      -32
  Partials      138     138

Impacted Files
Coverage Δ

superset/utils/core.py
88.81% <0%> (+0.16%)
:arrow_up:

superset/db_engine_specs/base.py
80.33% <0%> (+0.33%)
:arrow_up:

superset/connectors/sqla/models.py
84.81% <0%> (+0.64%)
:arrow_up:

superset/db_engine_specs/sqlite.py
66.66% <0%> (+9.99%)
:arrow_up:

superset/dataframe.py
94.48% <0%> (+10.23%)
:arrow_up:

superset/db_engine_specs/postgres.py
83.33% <0%> (+27.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59bc220...3d86c81. Read the comment docs.

I think that's enough for one PR... I'll make additional PRs soon to tackle the following:
• Moving other files from .css to .less (might as well conform things!)
• Consolidating typographic styles
• Cleaning out dead CSS selectors/files

Looks awesome, let's merge it!

Just for posterity, here are the color mappings from this PR

@almost-black

#263238

@danger

red

@darkest

black,rgba(0, 0, 0)

@error

red

@gray

#949494, #9e9e9e, #808e95,#666666,grey,#888888

@gray-bg

#efefef,#e8e8e8,#f2f2f2,f4f4f4,#eeeeee,#f8f8f8

@gray-dark

#555555, rgb(72, 72, 72),#484848,#667177

@gray-heading

#aaaaaa

@gray-light

b3b3b3 , bababa, #dddddd,rgb(187,187,187),#bbbbbb,#ccc,rgb(219, 219, 219)

@indicator-color

#e32464,#2c2261,rgb(68, 192, 255)

@lightest

#fff,white,rgb(255, 255, 255)

@success

lime, #4ac15f

@shadow-highlight

rgb(0, 166, 153)

@warning

orange,#fe4a49


Fix issue with duplicate resources - backwards compatibility

Feature or Bugfix

Bugfix

Detail

In v1.5.0 SageMaker Studio base infra is moved out in a nested stack. As a consequence sometimes there are conflicts with already existing AWS resources that the nested stack is trying to re-create. But the issue is bigger than that, the new nested stack would create a new Sagemaker domain and delete the previous one. If there are existing Sagemaker studio users this results in errors because it cannot delete a domain with existing users. We have 2 alternatives: 1) migrate existing users to the new profile 2) revert the changes and put the Sagemaker resources inside the environment stack, this will keep the previous resources.

Alternative 1 is quite complex (and I am not sure it is even possible). The benefit that it brings, which is "logical separation of environment-module resources" is not worth the effort.
Relates
#409
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I think I am going to start clean in another branch with your ideas, with no rush. Thanks @nikpodsh


use "a in (b,c)" instead of "a == b or a == c"

it's more obvious to understand what the code does

Not a clear win


Feature: shareable test suites

Summary
Be able to share a test suite across multiple projects, with some overrides
Motivation
Many Helm configurations are standardized across most charts. For example, Deployments typically have replicas, an optional PDB, an optional HPA, etc.
Having to copy and paste tests for common configurations like that gets very tedious very quickly, as well as hard to maintain.
Subcharts provide one way of re-using such configurations (and those subcharts would have their own test suites), but shareable test suites could perhaps open up more possibilities. Particularly as subcharts are not used that often.
Implementation Challenges
Most test suites would likely not be exactly 1-to-1, as they may be on different sub-paths or names of values. So this may require re-mapping of names, for instance, myDeployment1.replicas -> myDeployment2.replicas

Hello @agilgur5,
Although is is not planned, you request should already be possible.
when using the following commandline it should be possible to reuse tests in a different folder and use different values files (as the test files is stored in the helmchart itself.
helm unittest -f '../generic-tests/**/*.yaml' -v 'tests/override-value.yaml' .

short explanation on the command:
-f search for helm unittests in a folder outside the base helmchart folder
-v insert a override-value.yaml
. the current directory which contain the helmchart to test
Please let me know if it can help.
Greetings,
@quintush


Extend legend with unloaded line colour picker

The picker for the "unloaded" lines should be visible in the legend at the bottom of the canvas.
To make room for it, the quick switch for "visualization type" should be removed.
Additionally, change the default colours to something like blue - orange?

LGTM, works for light and dark mode


List of imperfections

I've found some issues that I consider worthy to address in it's source. I provide a list of issues and solutions to them that I used in the consumer's code.
No timeouts on API calls from Client
The calls do not time out.
Solution: wrap in timeouts. I'm using tokio::timeout. But I don't know how a problem would be solved for a blocking client more or less gracefully, without modifying the library's source code.
Client does not try to reconnect if the initial connection is lost
Solution: put timeouts on API calls - on timeout try to connect to the database; drop the old client on success. Code for connection also needs timeouts, because it's used for authentication and assuming identity, which are API calls.
When Client is idle for a long time it becomes unresponsive
A "long time" is vaguely specified, but experimentally 2 or more hours would likely do. 10 minutes is too little.
Solution: ping the server from time to time, experimentally 5 minutes works impeccably, but there's a room for an even larger delay.
Server started via CustomServer::listen_on offered with invalid Certificate returns the error:
Error: error from core a transport error occurred: 'Error completing connection with peer: aborted by peer: the application or application protocol caused the connection to be closed during the handshake'

Caused by:
    a transport error occurred: 'Error completing connection with peer: aborted by peer: the application or application protocol caused the connection to be closed during the handshake'

The documentation for listen_to:
/// Listens for incoming client connections. Does not return until the
/// server shuts down.
pub async fn listen_on(&self, port: u16) -> Result<(), Error> {}

Seems strange that a possibly malicious client can crash a server so easily.

Solution: do not server.listen(port).await? as shown in the examples, but handle or ignore the Error::Transport and loop { server.listen(port).await  }
Conclusion
After solving these problems the client becomes responsive and self-healing, and database does not crash so easily.

Thank you for all of this feedback. I'm going to split these issues into their own issues to track them independently. Can you verify what version you were evaluating? I believe "Client does not try to reconnect if the initial connection is lost" is fixed on the main branch as of about a month ago.

Sure, split these into the separate issues, I just did not want to flood the issues, doubting if they are all viable.
I'm currently using v0.4.1. Good that will be done in the next release.
I wish to contribute myself, just after I ship the project I'm working on.

No timeouts on API calls from Client

This is a very good observation. I think we can offer a configuration on the
Client builder to allow setting timeout options, which can be respected by the
blocking and non-blocking code under the hood.
We can probably persist these timeout settings on a per-client basis, so that each clone of the Client could be customized with its own timeout settings.

Client does not try to reconnect if the initial connection is lost

As I mentioned in a previous reply, I suspect that if you tried this on the main branch, this should be resolved. I did some significant refactors after running into this issue as well. There is actually even a unit test to ensure the client successfully reconnects.
However, this is only partially solved in that it will only reconnect on timeout
once the underlying protocol has noticed a timeout. Once we implement the
timeout system, this particular issue should be completely resolved.

When Client is idle for a long time it becomes unresponsive

This request should be covered by #116, which isn't currently attached to a milestone,
but it's important to projects I'm working on, so it will be tackled soon.

Server started via CustomServer::listen_on offered with invalid Certificate returns the error

Thank you for reporting this! This was simply an overlooked ? that
bubbled up an error that should have been logged instead. I've fixed this for the next release.
I'm going to write up my thoughts on timeouts in a new issue today/tomorrow. I would be thrilled if you find the time to contribute someday!

I've created #297 to track addressing the timeout issues. Thank you again for reporting all of these!


Failed to execute with default given commands

I followed the steps mentioned on readme. I got  the following :
./runme ../SLIDE/Config_amz.csv
new Network
new Layer
new Node array
[1]    2402 segmentation fault (core dumped)  ./runme ../SLIDE/Config_amz.csv
I did adjust the config file as well and removed -mavx512f from Makefile

dupe of issue 27... there is a default NULL initiation of saved_weights file str that will cause CNPY to barf.   That should be a check in main.cpp aka:
    if(savedWeights=="") {
            std::cout << "Will not save weights as configuration file does not specify savedWeight file..." << std::endl;
    } else {
    _mynet->saveWeights(savedWeights);
    }

But otherwise, just put a line in your config file to give it a non-NULL value.

Actually I managed to overcome this from one of your forked repos
https://github.com/hieuhoang/HashingDeepLearning
This fork ran with no issues


fix esp32-c3 usb connect pin number (IDFGH-5629)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

According to datasheet (page 11):
https://www.espressif.com/sites/default/files/documentation/esp32-c3_datasheet_en.pdf

Aside from the fact that the pinout matches the datasheet, my devboard also would not work if that table was indeed wrong:

Closing this, if you really feel this is in error I'd love to hear why you think this.

i bought esp32 dev board from ai-thinker.
But IO19 and IO18 on this development board are marked opposite.
sorry for that.
我是被安信可的ESP32-C3-12F-Kit开发板给坑了，他们把IO18、IO19标反了。所以才导致我提交这个MR。如果有人买的时候注意一下。我是2021年7月29号买的。
另外再补充一下，他家的ESP32-12H-Kit开发板也不靠谱，好多引脚都标错了。谨慎购买。

Aside from the fact that the pinout matches the datasheet, my devboard also would not work if that table was indeed wrong:

Closing this, if you really feel this is in error I'd love to hear why you think this.

cause the board i bought marked IO18 as IO19, IO19 as IO18. 😂😂😂😭😭😭

@acevest The problem is with the AIThinker board (AIThinker is a third party), not with the C3 chip. @Spritetm and me have both verified that these pins work according to the datasheet.


Output of subset is lists of lists

With split method implemented, the output of subset is a list of lists. Is this correct?

@ellesmith88 , no, I think the output of clisops.subset should be a list of either Xarray objects or a list of output paths.


LS: Proc macro server failed notification

Stack:

#6706
#6705 ⬅
#6704
#6638
#6703
#6702
#6637
#6701

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is


Prevent RequiredIf firing validation

Hi,
I've found issues similar to this, but none that seem to match my requirements exactly. I have a drop-down list (TypeId), and when a particular option is selected another text box (TypeOther) is made required.
[Required]
public int TypeId { get; set; }
[RequiredIf("TypeId = 9")
public string TypeOther { get; set; }

The RequiredIf unobtrusive js works perfectly well, if anything a bit too well. As soon as the user selects the option from the drop down list, the validation message appears immediately on the text box. As the text box is after the drop down selection, the user is being warned to fill in a field that they haven't got to yet.
Is it possible to change this behaviour so that when RequiredIf equates to true, it doesn't automatically try and validate the field? And instead waits for the user to perhaps exit the text box?
Cheers,
Dan

Hi,
The short answer is that you can achieve it with the following setting:
<script>
    ea.settings.dependencyTriggers = undefined;

(do not forget to refresh your browser cache after this change)
See section regarding frequency of dependent fields validation for a more complete explanation.
Regards


Create patchset type for patching operations

What this PR does
Before this PR:
Several ways how to perform patch operations with a mixture of hardcoded strings and types.
After this PR:
Gradually introduce the patch package to replace hardcoded patch operations. This package and the PatchSet type tries to follow the same style as libvmi.
The https://github.com/kubevirt/kubevirt/pull/11211 can be used as reference to see which files and operations we can replace with this new type.
This PR only modifies a couple of files to give an example how the package can be used. More refactoring PRs will follow.
Release note

NONE

@0xFelix @EdDev right now I have only touched the instancestypes to give an example, but if you like the current option, I'll replace the other parts in the code. If we can get rid of all GeneratePatchPayload then we can avoid to export the patchOperation types

I'm a bit stuck in one parsing issue we have with the PatchOperation. This struct isn't actually parsed correctly for the remove patch operation.
Currently this translate in:
[{"op":"remove","path":"/abcd","value": null}]

but it should be :
[{"op":"remove","path":"/abcd"}]

Adding the omitempty tag to Value solves the problem. However, now, the null values isn't correct anymore for the test operation that should translate in this way:
[{"op":"test","path":"/abcd","value": null}]

A part from implementing a custom Json parsing for the type, I'm not quite sure if there is more elegant way. Any ideas?

A part from implementing a custom Json parsing for the type, I'm not quite sure if there is more elegant way. Any ideas?

Ok the custom parser is probably the best idea. I'll fix the last comments and then push a new version

/test pull-kubevirt-unit-test

@EdDev I updated the code with your suggestion. When you have a bit of time, can you please give a second look

@EdDev @fossedihelm @0xFelix I have updated the code with the last comment, please have a look when you have a bit of time. Thx!

Thank you @alicefr!
/lgtm

Could you also please use EscapeJSONPointer on the paths that are being passed to the PatchSet? It is especially important for labels/annotations, as the path for a label that looks like kubevirt.io/something would be /metadata/labels/kubevirt.io/something which will cause a failure without an escape character. I suggest you use this function on addOp to avoid code duplication. Please also insert test cases for this scenario as well.

This makes sense. But I think this can be added later on, it does not have to block the current PR.

I think it's pretty important. Someone that would try to patch a label/annotation might lose a lot of working time over debugging this.
If you strongly insist I won't block the PR on it and push a follow-up right after it's merged, but I strongly think it's a good idea to add this.

Could you also please use EscapeJSONPointer on the paths that are being passed to the PatchSet? It is especially important for labels/annotations, as the path for a label that looks like kubevirt.io/something would be /metadata/labels/kubevirt.io/something which will cause a failure without an escape character. I suggest you use this function on addOp to avoid code duplication. Please also insert test cases for this scenario as well.

This makes sense. But I think this can be added later on, it does not have to block the current PR.

I think it's pretty important. Someone that would try to patch a label/annotation might lose a lot of working time over debugging this.
If you strongly insist I won't block the PR on it and push a follow-up right after it's merged, but I strongly think it's a good idea to add this.

I can add it if this is an issue. It isn't a big deal

Thanks very much @alicefr.
This is truly great and valuable stuff! Great work!
None of my comments are worth blocking your awesome work.
I'll add a hold just to give you an opportunity to consider my suggested changes, however feel free to remove the hold when you feel the PR is ready in your perspective. If I'd feel the need, I'll post a follow-up PR and we can discuss everything there.
/approve
/hold

@iholder101 let's merge this and do the rest in a follow up PR. We can always add the check in a second one. We can control the path and right now the one that uses this PR are hardcoded (without any fmt.Sprintf) and we can verify them.
I'm insisting on merging this PR, because I'd like to base another large PR on this new library
/unhold

@iholder101 let's merge this and do the rest in a follow up PR. We can always add the check in a second one. We can control the path and right now the ones that use this PR are hardcoded (without any fmt.Sprintf) and we can verify them.
I'm insisting on merging this PR, because I'd like to base another large PR on this new library
/unhold

Again, thanks so much @alicefr. Great work.
I would gladly open the follow-up PR :+1:

Again, thanks so much @alicefr. Great work. I would gladly open the follow-up PR 👍

Thanks! Let me know and I can review it!

/retest

/test pull-kubevirt-e2e-kind-sriov

/test pull-kubevirt-e2e-kind-1.27-vgpu


Update README.md

Hey!  I'm the co-founder of Spurwing and we'd love to sponsor your repository. Please reach out to me at<EMAIL_ADDRESS>for a chat or call :)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix lockfile update issue

Revert "Bump renovate from 34.160.0 to 35.98.4"
Add an example bisection file.

This is the result of a bisection that discovered a commit that resulted in any change to the pnpm lockfile to break the build. See also https://github.com/Zemnmez/monorepo/pull/3155
The offending commit was<PHONE_NUMBER>0c2860239197289c2f1c1b60e6e70d


Fix BSS PUT command and promote script EOF indentation issue

Summary and Scope
Fix a couple of issues with the rebuild doc when promoting new master
Issues and Related PRs

Resolves CASMINST-3678

Testing
List the environments in which these changes were tested.
Tested on:
N/A
Test description:

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
Were continuous integration tests run? If not, why?
Was upgrade tested? If not, why?
Was downgrade tested? If not, why?
Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
Low risk, already broken
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

/backport main

/backport release/1.2


Breaking changes with arrow 1.0.0

Problem Description
I installed td-watson in a fresh environment and received an error when running:
$ docker run -it --rm python:latest /bin/bash
root@4156557dc8cf:/# pip install td-watson
...
root@4156557dc8cf:/# watson status
Traceback (most recent call last):
  File "/usr/local/bin/watson", line 5, in <module>
    from watson.__main__ import cli
  File "/usr/local/lib/python3.9/site-packages/watson/__main__.py", line 2, in <module>
    from watson import cli
  File "/usr/local/lib/python3.9/site-packages/watson/cli.py", line 441, in <module>
    _SHORTCUT_OPTIONS_VALUES = {
  File "/usr/local/lib/python3.9/site-packages/watson/cli.py", line 442, in <dictcomp>
    k: get_start_time_for_period(k) for k in _SHORTCUT_OPTIONS
  File "/usr/local/lib/python3.9/site-packages/watson/utils.py", line 193, in get_start_time_for_period
    start_time = get_last_full_moon(now)
  File "/usr/local/lib/python3.9/site-packages/watson/fullmoon.py", line 226, in get_last_full_moon
    idx = bisect.bisect_right(fullmoons, now)
TypeError: '<' not supported between instances of 'method' and 'int'

The arrow library was updated on Feb 24, 2021 and there are breaking changes.
The default td-watson installation uses the new version,  arrow 1.0.0:
root@4156557dc8cf:/# pip freeze
arrow==1.0.0
certifi==2020.12.5
chardet==4.0.0
click==7.1.2
click-didyoumean==0.0.3
idna==2.10
python-dateutil==2.8.1
requests==2.25.1
six==1.15.0
td-watson==1.10.0
urllib3==1.26.3

Workaround
Downgrade to arrow 0.17.0:
root@4156557dc8cf:/# pip uninstall arrow
Found existing installation: arrow 1.0.0
Uninstalling arrow-1.0.0:
  Would remove:
    /usr/local/lib/python3.9/site-packages/arrow-1.0.0.dist-info/*
    /usr/local/lib/python3.9/site-packages/arrow/*
Proceed (y/n)? y
  Successfully uninstalled arrow-1.0.0
root@4156557dc8cf:/# pip install arrow==0.17.0

And td-watson works again:
root@4156557dc8cf:/# watson status
No project started.
root@4156557dc8cf:/# watson start testing123
Starting project testing123 at 15:25
root@4156557dc8cf:/# watson stop
Stopping project testing123, started just now and stopped just now. (id: d056c4c)

Quick fix
Update requirements.txt changing the line:
arrow>=0.15.6

To specify the exact version:
arrow==0.17.0

Long-term solution
According to the arrow 1.0.0 migration guide:

The .timestamp property has been removed to improve compatibility with datetime. Use .int_timestamp for the same results.

arrow.utcnow().int_timestamp
1608640233

I tried this and it appears to work.
The changes are:
diff watson/frames.py /usr/local/lib/python3.9/site-packages/watson/frames.py
38,40c38,40
<         start = self.start.to('utc').timestamp
<         stop = self.stop.to('utc').timestamp
<         updated_at = self.updated_at.timestamp
---
>         start = self.start.to('utc').int_timestamp
>         stop = self.stop.to('utc').int_timestamp
>         updated_at = self.updated_at.int_timestamp
diff watson/fullmoon.py /usr/local/lib/python3.9/site-packages/watson/fullmoon.py
225c225,226
<     now = d.timestamp
---
>     now = d.int_timestamp
diff watson/watson.py /usr/local/lib/python3.9/site-packages/watson/watson.py
104c104
<         return date.timestamp
---
>         return date.int_timestamp

Also need to update the tzinfo calls.
According to the arrow 1.0.0 migration guide.

It's no longer possible to set the tzinfo property directly, instead use replace().

dt=arrow.utcnow()
dt.tzinfo=tz.gettz("US/Pacific")
Traceback (most recent call last):
File "", line 1, in
AttributeError: can't set attribute
dt.replace(tzinfo=tz.gettz("US/Pacific"))
<Arrow [2020-12-22T16:03:29.630250-08:00]>

The following seems to address this:
# diff watson/cli.py /usr/local/lib/python3.9/site-packages/watson/cli.py
84c84
<             date.tzinfo = tz.tzlocal()
---
>             date.replace(tzinfo=tz.tzlocal())

Looks wonderful. Can you submit a PR with your fix?

Thank you.  PR submitted.

:loudspeaker: The new 2.0.0 release including this fix is out! https://pypi.org/project/td-watson/2.0.0/ :fire:


Rectangle detections on live camera

is it possible to insert a rectangle during the barcode detection phase in live mode?  if there is already can you tell me how to implement it?  Thanks

There's no implemented method that already draws the rectangle for you.

There's no implemented method that already draws the rectangle for you.

I'm trying to implement it, but I can't, I also tried to follow this:
https://github.com/zxing-js/library/issues/39
can you help me?

Not on this project, sorry. I only offer support on my fork as it demands so much of my spare time.


Installing Live Sass Compiler

Hi Glenn
I have a MacBook Air and have a local development environment with Homebrew, Apache, MariaDB, PHP7.4 and PHP8.0, it works perfectly. Do I now have to install brew install sass/sass/sass so that I can use the Live Sass compiler.

Hey @dp-designpilot,
The extension actually comes packaged with the sass/sass JavaScript API (npm package), this means that nothing extra should need to be installed Why do you ask, are you having issues?

No, I have no problems (it's only because 1.42.1 is stated as the most recent on the https://sass-lang.com/install page).  And I've set up a development environment with homebrew

Sorry for the delay, been a crazy few days (started my next uni module).
I would suggest that you add the JSON file in this zip to your .vscode folder. The contents of this file are: (for reference)
{
    "liveSassCompile.settings.formats":[
       {
           "extensionName": ".css",
           "format": "compressed",
           "savePath": "~/../css"
       }
   ]
}

This tells the compiler to save the file up one directory and then in the CSS folder. Alternatively, you can use /[SCSS-CSS]/css as your savePath setting if the [SCSS-CSS] folder is at the first level in your project.
I have the below example you can refer to as well.
Issue 124.zip

I will close this issue now but please feel free to continue to ask any questions


Artboards generate empty styles

When I select an artboard and run styles generator, it creates an empty style named after the artboard. Would it be more sensible to skip artboards when generating styles, since artboards can't have layer styles applied to them?

@avkvirtru I just pushed a couple of fixes, and implemented a few new features. Thanks for the patience! 🙏

@lucaorio thanks for your hard work!


Fix the social links nav (header)

fix: Fixes the broken social links navigation under 1200px device width. The nav element was wider than the parent li element.

Thank you!


feat(validation): #217 handle multi model validation (not delimited)

Description
#217
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[ ] Test, docs, adr added or updated as needed
[ ] Contributor Guide Steps followed

@CloudBeard Should be enough there to see what changes or additional functionality you might want.
@defenseunicorns/lula-dev Not sure about the validate command integration yet would like some feedback prior to implementing, current thoughts:

for go-oscal validate single model should be the default? (since oneOf is the expected schema state)

flag? for multi
agnostic, handle based on file contents (assumes user intent)

Closing as it is no longer relevant.


missing unlist event at history

What happened?

unlist event is incorrect in history tab

emoji disappear on unlist event

Please reproduce in steps
test case:
https://beta.kodadot.xyz/rmrk/collection/160a6f4320f11acb25-LCKWV?tab=history&event=all&page=13
https://beta.kodadot.xyz/rmrk/collection/160a6f4320f11acb25-LCKWV?tab=history&event=all&page=7
Expected Behavior
I've expected it to display this correct 'unlist' result at history tab and to show emoji on 'unlist' item.
What browsers are you seeing the problem on?
Chrome
Are you logged in?
No
At which address did you encounter bug?
beta.kodadot.xyz, kodadot.xyz
Screenshots

unlist event is incorrect

emoji disappear on unlist event

Relevant log output
No response
Payment link for reward
https://kodadot.xyz/transfer/?target=Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
Code of Conduct

[X] I agree to follow this project's Code of Conduct

i will take this


Design methods to allow project name as query param

Currently, the connector requires a projectId and that id is somewhat difficult to find. It's used in the Toggl URLs. The project name is easy to see in the Toggl html pages. Add methods in the APIHandler to return the integer id using a string argument.

Revised: TogglDataAPIHandler and TogglAPIConnector . This was tested and now closing ticket.


build: fix Start-PSBuild -Output

PR Summary
Make Start-PSBuild -Output $OutDir output the build to the directory properly.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[x] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

Restarted Travis-CI.


Add AbstractEnum::all()

Coverage remained the same at 100.0% when pulling 276cbe71955b5713a67759ec8275b345d0fa2765 on fea/toArray into a9571d3be10dc0cb12a7a7c08eb1fb246f370947 on master.


tickets/DM-20431: Implement Nate Lust's symmetry algorithm

Implement symmetry in kspace and fractional pixel shifts
calculated by using the morphology centroid weighted by
the frame psf.

Remy and I just had a debrief of Nate on the details of the algorithm. Two things came up.

Nate uses a mask, which predetermines the source vs background footprints, and reapplies that mask after the symmetry operation to null the small artifacts that arise from the FFTs. Please make sure that this mask isn't called before the FFTs because it would generate unnecessary ringing. The FFT artifact may also make it harder for our histogram-based l0 sparsity to determine a threshold.

The shift for the symmetry is only for fractional pixel offsets. The same approach should be able to do several pixel shifts, which should allow us to prevent to centering/passing operation that is currently implemented.

zero masking is indeed applied before FFTs. As for the l0, there is also the option to set the threshold according to noise levels.

The shift for the symmetry is only for fractional pixel offsets. The same approach should be able to do several pixel shifts, which should allow us to prevent to centering/passing operation that is currently implemented.

The current implementation of the centering algorithm does calculate a shift over multiple pixels and updates pixel_center (see https://github.com/fred3m/scarlet/blob/tickets/DM-20431/scarlet/update.py#L294). The problem is that to use the PSF for weighting, the algorithm needs a pixel center to start with. We could use the pixel_center calculated from the previous iteration but I think that using the pixel with the maximum flux in the current iteration is a better choice, since it is calculated after the gradient step.

That's not the point. I'm proposing that we don't go through the uncentered_operator method at all:
https://github.com/fred3m/scarlet/blob/tickets/DM-20431/scarlet/operator.py#L172
Instead, we can chose the shifting operator in Fourier space to do arbitrary translations directly in the original model frame.

I understand that after our telecon. I think that you're right, and we should probably create an issue to do just that.


Storyteller for PF2e in v10 causes canvas to not load.

I have all modules deactivated, but for some reason Storyteller causes a blank canvas and is throwing a million errors. I am on the latest version of PF2e and am on the latest version of V10.
The big error I get at the top is "Canvas Drawing Failed; This is not a registered game setting."

Hello. Can you please send a screenshot of the error?

Storyteller Error Console Log.txt

Very strange, because there are no errors from the storyteller side. If you turn it off, do the errors disappear?

Disabling all modules does not not throw any errors.

I guess the mistake was in the foundry itself. I could not replicate it, if it suddenly appears again, please reopen the issue.


Fix port overwrite received from "HTTP_HOST"

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

👍