Compiling on Solaris with dynamically linked perl broken

Steps to reproduce
Try to compile recent (fresh from git) vim with --enable-perlinterp=dynamic
It ends up with
  /usr/gcc/12/bin/gcc -L/usr/lib/amd64  -Wl,--as-needed         -o gvim [...]
Undefined                       first referenced
 symbol                             in file
__stack_chk_fail                    objects/option.o
__stack_chk_guard                   objects/option.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
link.sh: Linking failed

This is caused by https://github.com/vim/vim/commit/55460da26c2756ec057c03c7d8641eda861bfcd2 even though the intentions were good :)
The change clears PERL_LIBS when linking dynamically. The problem is that the variable might contain vital options too in addition to -lperl
On Solaris the perl is compiled with -fstack-protector-strong which means that the resulting binary has to be linked with -fstack-protector too.
During the configure processing I can see
            perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' ...
which expands to
perllibs='  -R /usr/perl5/5.36/lib/i86pc-solaris-thread-multi-64/CORE  -m64 -fstack-protector-strong -L/usr/gnu/lib   -L/usr/perl5/5.36/lib/i86pc-solaris-thread-multi-64/CORE -lperl -lpthread -lsocket -lnsl - +ldl -lm -lc'
Later
PERL_LIBS=$perllibs
but a bit further
PERL_LIBS=""
I'm not sure how to best approach this. Perl itself says:
$ perl -V | grep fstack
    ccflags ='-D_REENTRANT -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -D_LARGEFILE64_SOURCE -D_FORTIFY_SOURCE=2 -DPERL_USE_SAFE_PUTENV'
    cppflags='-D_REENTRANT -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong'
    ldflags =' -m64 -fstack-protector-strong -L/usr/gnu/lib '
    lddlflags=' -shared -m64 -L/usr/gnu/lib -fstack-protector-strong'

We might be using lddlflags value instead of plainly erasing PERL_LIBS.
https://perldoc.perl.org/Config says:
lddlflags

    From dlsrc.U:

    This variable contains any special flags that might need to be passed to $ld to create a shared library suitable for dynamic loading. It is up to the makefile to use it. For hpux, it should be -b. For sunos 4.1, it is empty.

But god knows what else this breaks. I'm happy to create a fix with this change if there is interest.
Expected behaviour
Vim compilation should succeed.
Version of Vim
vim-9.0.1894
Environment
OS: Solaris 11.4
Logs and stack traces
No response

For the time being my workaround is to just use LDFLAGS += "-fstack-protector" in https://github.com/oracle/solaris-userland/blob/master/components/vim/Makefile

Hmm, wait a second here. From your build failures, it seems that it is actually objects/option.o that is referring to symbols like __stack_chk_fail, and then the linker failed to find it because we are no longer passing -fstack-protector-strong to the linker? option.o is unrelated to the Perl bindings but it seems like the CFLAGS for compiling it is using -fstack-protector-strong but not the LDFLAGS, and it just so happened that the Perl linking flags contained it before causing your build to succeed.
I guess another way to put it is I'm suspecting that the way the compiler flags + linker flags in your (or Vim's) configuration is not set up properly and previously it worked by coincidence.
Other than that I don't see how Perl's own linking flags (lddlflags) should affect how Vim is built since we would be loading it dynamically anyway. I think from the docs, those flags are for building Perl itself.

Would it be possible to see the compilation flags for object/object.o in the build logs? I'm curious to see what the CFLAGS were. And also, how are you configuring Vim to be built (as in what are the options you are passing to ./configure along the env vars)?

Thank you for looking into this issue. I am attaching compilation log and config.log file.
build.log
config.log
You are correct that it is objects/option.o which does require __stack_chk_fail and linking fails because of missing -fstack-protector-strong while linking. option.o is relevant because
src/Makefile:
ALL_IF_CFLAGS = ... $(PERL_CFLAGS) ...

objects/option.o: option.c optiondefs.h
        $(CCC_NF) $(ALL_IF_CFLAGS) $(ALL_CFLAGS) $(ALL_IF_CFLAGS_EXTRA) -o $@ option.c

I can find three .o files in my workspace, which require __stack_chk_fail during linking.

src/objects/optionstr.o
src/objects/if_perl.o
src/objects/option.o

All three are compiled with PERL_CFLAGS and do have functions which allocate stack. There are also two files which are compiled with PERL_CFLAGS but they do not have a function which allocates stack so there is no __stack_chk_fail in the *.o file.

objects/gui_gtk_gresources.o
objects/if_perlsfio.o

No other file does use -fstack-protector-strong during compilation. Looking at src/auto/config.log I can see the only place where -fstack-protector-strong is defined
PERL_CFLAGS='-DDYNAMIC_PERL_DLL=\"libperl.so\"  -D_REENTRANT -m64 -fwrapv  -fstack-protector-strong -D_LARGEFILE64_SOURCE  -DPERL_USE_SAFE_PUTENV  -I/usr/perl5/5.36/lib/i86pc-solaris-thread-multi-64/CORE '

Which corresponds with the output of $ perl -MExtUtils::Embed -e ccflags

Ah ok, right. I still wonder if the -fstack-protector-strong etc are really necessary for even the PERL_CFLAGS (since we are dynamically loading the lib anyway), but given that it has always worked probably the easiest fix would be just to get that back to the PERL_LIBS and make sure we only remove -lperl and keep the others.


marker onlongclick listener

Hi, I'm trying to add OnLongClickListener to marker view like bellow:
pinpointView.setOnLongClickListener {
                val dragData = ClipData.newPlainText("pinpoint_id", pinpoint.id)
                val shadow = PinpointShadowBuilder(it)
                if (Build.VERSION.SDK_INT < Build.VERSION_CODES.N) {
                    it.startDrag(dragData, shadow, pinpoint, 0)
                } else {
                    it.startDragAndDrop(dragData, shadow, pinpoint, 0)
                }
                return@setOnLongClickListener false
            }
            addMarker(pinpointView, x, y)

but then the TileView's MarkerTapListener was overwrite. How can i resolve this problem ? Thank you.

use normal click listeners instead of MarkerTapListener


The Spyder "custom IPython" dosn't work correctly

The thing is that no-one uses the old "Python 3.8" anymore(its the default btw) and plus, when i changed it to Python 3.11.5
it won't work; in VSCode I tried the EXACT same code and it worked unlike it wouldn't in Spyder
Here's my code
import sys
import platform
import time
import ExecutableBuilder
from PyQt5.QtWidgets import QApplication as qapp, QMainWindow as qmain, QLabel as qlab, QVBoxLayout as qvbox, QWidget, QPushButton, QInputDialog
from PyQt5.QtGui import QIcon
from PyQt5.QtCore import QEvent as qeve
import subprocess as sp

app = qapp(sys.argv)

class Install(qmain):
    def __init__(self):
        super().__init__()
        self.setWindowIcon(QIcon(r"K:\Dont_Bother\Icon-Taskbar-window.png"))

        if platform.system() != "Windows":
            # If your OS isn't Windows it will execute this code:
            self.setWindowTitle('--NotWindowsError')
            self.setGeometry(100, 100, 800, 600)  # Adjusted size

            # Create a central widget to hold the layout
            central_widget = QWidget(self)

            layout = qvbox()
            label = qlab(f"OS must be Windows 10, 8.1 or 11, this OS is using {platform.system()}")
            layout.addWidget(label)

            # Set the layout for the central widget
            central_widget.setLayout(layout)

            # Set the central widget for the main window
            self.setCentralWidget(central_widget)
        else:
            # If your OS is Windows it will execute this code:
            self.setWindowTitle('Dont_Bother')
            self.setGeometry(100, 100, 800, 600)  # Adjusted size

            central_widget = QWidget(self)

            layout = qvbox()
            label = qlab("OS is windows... Do you wish to continue?")
            layout.addWidget(label)

            # Create a function to handle the user's input
            def handle_input():
                user_input, ok = QInputDialog.getText(self, 'Input', 'Do you wish to continue? (yes/no)')
                if ok and user_input.lower() == "yes":
                    sp.run(ExecutableBuilder)
                else:
                    sys.exit()

            # if the user wants to continue.
            button = QPushButton("Continue to Dont_Bother?")
            button.clicked.connect(handle_input)

            layout.addWidget(button)

            central_widget.setLayout(layout)

            self.setCentralWidget(central_widget)

# Create an instance of the Install class
install_window = Install()

# Show the window
install_window.show()

# Start the application's event loop
sys.exit(app.exec_())

Hey @GitKia1392, thanks for reporting. Why does your code not work? What problem are you seeing in Spyder?

Wassup @ccordoba12. My code works flawlessly in VS Code.
The problem is the performance; Its very laggy in comparison to VS Code
The main problem is probably becuz of How big spyder is.

The main problem is probably becuz of How big spyder is.

That has nothing to do with it.

The problem is the performance; Its very laggy in comparison to VS Code

Please follow the instructions posted in this page to see if that helps:
https://github.com/spyder-ide/spyder/wiki/How-to-run-PyQt-applications-within-Spyder

Did fix the problem a little but when with the new code:
`from sys import exit, argv
import platform
import time
from PyQt5.QtWidgets import QApplication as qapp, QMainWindow as qmain, QLabel as qlab, QVBoxLayout as qvbox, QWidget, QPushButton, QInputDialog
from PyQt5.QtGui import QIcon
from PyQt5.QtCore import QEvent as qeve
import subprocess as sp
app = qapp(argv)
class Install(qmain):
def init(self):
super().init()
self.setWindowIcon(QIcon(r"K:\Dont_Bother\Icon-Taskbar-window.png"))
    if platform.system() != "Windows":
        # If your OS isn't Windows it will execute this code:
        self.setWindowTitle('--NotWindowsError')
        self.setGeometry(100, 100, 800, 600)  # Adjusted size

        # Create a central widget to hold the layout
        central_widget = QWidget(self)

        layout = qvbox()
        label = qlab(f"OS must be Windows 10, 8.1 or 11, this OS is using {platform.system()}")
        layout.addWidget(label)

        # Set the layout for the central widget
        central_widget.setLayout(layout)

        # Set the central widget for the main window
        self.setCentralWidget(central_widget)
    else:
        # If your OS is Windows it will execute this code:
        self.setWindowTitle('Dont_Bother')
        self.setGeometry(100, 100, 800, 600)  # Adjusted size

        central_widget = QWidget(self)

        layout = qvbox()
        label = qlab("OS is windows... Do you wish to continue?")
        layout.addWidget(label)

        # Create a function to handle the user's input
        def handle_input():
            user_input, ok = QInputDialog.getText(self, 'Input', 'Do you wish to continue? (yes/no)')
            if ok and user_input.lower() == "yes":
                exit()
            else:
                exit()

        # if the user wants to continue.
        button = QPushButton("Continue to Dont_Bother?")
        button.clicked.connect(handle_input)

        layout.addWidget(button)

        central_widget.setLayout(layout)

        self.setCentralWidget(central_widget)

Create an instance of the Install class
install_window = Install()
Show the window
install_window.show()
Start the application's event loop
exit(app.exec_())
`
When i try to exit the app it doesn't let me and it says oh 'PyThOn IsN't ReSpOnDiNg!'

That has nothing to do with it.
I'm still pretty sure it has got SOMETHING to do with it at lest.

Thanks
Me

Please the last line of your code
exit(app.exec_())

to be
app.exec_()

That should fix your problem.


Bot Framework v4, Luis returning Null for Entities

I am using Bot Framework v4, when I query with the endpoint URL I am getting this response
{
  "query": "add event with<EMAIL_ADDRESS>  "topScoringIntent": {
    "intent": "Calendar.Add",
    "score": 0.264734924
  },
  "entities": [],
  "sentimentAnalysis": {
    "label": "positive",
    "score": 0.965832
  }
}

I have given entity "email" for my Intent, When I test the same utterance on LUIS web, It shows me my Entity.

@Adityagrao you mention v4, but which SDK specifically are you using?
LMK, and I'd be happy to investigate further

Ok, looks like we will need more of your bot code @Adityagrao to repro what you're encountering.
Using the C# sample 51.CafeBot, was able to successfully get the entity extracted from the LUIS results

Note: did you make sure to publish your changes to your LUIS model to make them reachable to your bot?

Fixed, All I had to do was publish in Luis

Awesome!
(I've done that before myself)


WebSharper Suave: System.Web.Security.FormsAuthentication.GetAuthCookie raises a NullReferenceException in mono

As a consequence, ctx.UserSession.LoginUser and ctx.UserSession.Logout both raise the same exception.
Here's a stacktrace on calling GetAuthCookie directly:
System.NullReferenceException: Object reference not set to an instance of an object
  at System.Web.Util.UrlUtils.Combine (System.String basePath, System.String relPath) [0x00145] in <d3ba84a338d241e2ab5397407351c9cd>:0
  at System.Web.Security.FormsAuthentication.MapUrl (System.String url) [0x00010] in <d3ba84a338d241e2ab5397407351c9cd>:0
  at System.Web.Security.FormsAuthentication.Initialize () [0x000dd] in <d3ba84a338d241e2ab5397407351c9cd>:0
  at System.Web.Security.FormsAuthentication.GetAuthCookie (System.String userName, System.Boolean createPersistentCookie, System.String strCookiePath) [0x00000] in <d3ba84a338d241e2ab5397407351c9cd>:0
  at System.Web.Security.FormsAuthentication.GetAuthCookie (System.String userName, System.Boolean createPersistentCookie) [0x00000] in <d3ba84a338d241e2ab5397407351c9cd>:0
  at<EMAIL_ADDRESS>(Microsoft.FSharp.Core.Unit unitVar) [0x00010] in <589225ecb48a15f9a7450383ec259258>:0
  at Microsoft.FSharp.Control.AsyncBuilderImpl+callA@850[b,a].Invoke (Microsoft.FSharp.Control.AsyncParams`1[T] args) [0x00047] in <5829c3e7dff9fae1a7450383e7c32958>:0

Maybe this has some relation to the lack of a Web.config?

Yeah it is probably related one way or another to the fact that it's a Suave application and not ASP.NET-based.

Any workaround I can use while ctx.UserSession.LoginUser doesn't work?

If you need to use System.Web.*, then you can't use OWIN unless you use the Microsoft.Owin.Host.SystemWeb, as best I recall. I think the FormsAuthentication module is tied deeply to System.Web.dll, which OWIN avoids. If you want to use an OWIN-compatible forms auth implementation, check out https://www.nuget.org/packages/Microsoft.Owin.Security.Cookies/ or another option available here: https://www.nuget.org/packages?q=Microsoft.Owin.Security

Here are some potentially useful links:

https://www.codeproject.com/tips/849113/four-easy-steps-to-set-up-owin-for-form-authentica (uses Microsoft.Owin.Security.Cookies)
https://blogs.msdn.microsoft.com/webdev/2013/07/03/understanding-owin-forms-authentication-in-mvc-5/ (points to an unreleased Microsoft.Owin.Security.Forms package)

@panesofglass That is one possible solution indeed. It kind of goes contrary to your efforts to build a Katana-less WebSharper.Owin though, no?


⚠ 366.ru has degraded performance

In 6a05ee3, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 1292 ms

Resolved: 366.ru performance has improved in b0576fe.


Use correct package name

Use the "CorePluginPackage" name instead of the "ExamplesPluginPackage" name.

Hi!
I decided to set the plugin type to Miscellaneous because it seems to be the most suitable.
Commit: https://github.com/Nalen98/AngryGhidra/commit/afec0c8828c6c41f6f0fb2dda4471bea84c3d390
Also, README file was updated in order to help users to activate the plugin


(init.py:960 MainThread) ERROR - TeleBot: "Infinity polling exception: 'messages'"

2023-03-20 16:02:48,690 (init.py:960 MainThread) ERROR - TeleBot: "Infinity polling exception: 'messages'"
2023-03-20 16:02:48,691 (init.py:962 MainThread) ERROR - TeleBot: "Exception traceback:
Traceback (most recent call last):
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/telebot/init.py", line 955, in infinity_polling
self.polling(non_stop=True, timeout=timeout, long_polling_timeout=long_polling_timeout,
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/telebot/init.py", line 1043, in polling
self.__threaded_polling(non_stop=non_stop, interval=interval, timeout=timeout, long_polling_timeout=long_polling_timeout,
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/telebot/init.py", line 1118, in __threaded_polling
raise e
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/telebot/init.py", line 1074, in __threaded_polling
self.worker_pool.raise_exceptions()
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/telebot/util.py", line 148, in raise_exceptions
raise self.exception_info
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/telebot/util.py", line 91, in run
task(*args, **kwargs)
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/telebot/init.py", line 6428, in _run_middlewares_and_handler
result = handler'function'
File "/home/runner/BingChatBot/bing.py", line 49, in response_all
responseList = asyncio.run(bingChat(message.text))
File "/nix/store/hd4cc9rh83j291r5539hkf6qd8lgiikb-python3-3.10.8/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/nix/store/hd4cc9rh83j291r5539hkf6qd8lgiikb-python3-3.10.8/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/home/runner/BingChatBot/bing.py", line 65, in bingChat
response_dict = await gbot.ask(prompt=messageText, conversation_style=ConversationStyle.creative)
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/EdgeGPT.py", line 279, in ask
async for final, response in self.chat_hub.ask_stream(
File "/home/runner/BingChatBot/venv/lib/python3.10/site-packages/EdgeGPT.py", line 242, in ask_stream
yield False, response["arguments"][0]["messages"][0][
KeyError: 'messages'
"

This is a problem with EdgeGPT, you can solve it by upgrading EdgeGPT.Please use this command: pip install -U EdgeGPT


Make a request to one endpoint from another controller

Hello,
How do i make a request to one resource endpoint without using an http client?
Here is my problem I have create a controller to update the current user informations. I have a users ressource configured. When i try to create a request like this and pass it to the app()->handle() functions the request fails with a 500 error :
$request = Request::create(
'/api/v1/users/1',
'POST',
$data,
);
$response = app()->handle($request);
is there a way to call a ressource controller action without using an $httpClient?

Hi! I wouldn't ever recommend creating a new request within an existing Laravel request, as Laravel assumes it is only handling one request at once.
Why don't you just update the user model yourself? Why do you have to pass it off as a JSON:API process?

Okay, thanks for your reply.
I want to reuse the api endpoints. And i want also to benefit of the already implemented validations and rules in place in this api endpoint.

I'm going to leave this open as a reminder that I need to make it easier for developers to manually trigger a JSON:API operation.


Allow --resume=?? without other parameters.

What does this PR do?

Fixes #44
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[x] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[x] pytest tests/test_experiments.py::test_resume

Before submitting

[x] The title is self-explanatory and the description concisely explains the PR
[x] My PR does only one thing, instead of bundling different changes together
[ ] I list all the breaking changes introduced by this pull request
[x] I have commented my code
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?
Make sure you had fun coding 🙃

Can you write tests to capture these conditions? I'm forgetting now whether this solves the problem.

@dxoigmn I added a test case and it passes. However, the new test won't capture the error in the previous code, because it exits gracefully without running an experiment.

@dxoigmn
The test is added, and the resume logic is fixed.

I'm separating fixes from this PR:

#59


Bigint time zone offset

I have a view
part of it:

SELECT
l2.date_from
FROM (SELECT DISTINCT to_unixtime(date_trunc('week' :: text,
to_timestamp(((draft_stage_load_x.date_from / 1000)) :: double precision))) AS date_from
FROM draft_stage_load_x) l2

function to_unixtime

create function to_unixtime(x timestamp with time zone)
returns bigint
language sql
as $$
SELECT (extract(epoch FROM x)*1000)::bigint AS result;
$$;

I'm reading data from a view in a code using DbDataReader

while (await dr.ReadAsync(cancellationToken))
{
var c = new Dictionary<string, object>();
for (int i = 0; i < dr.DbDataReader.VisibleFieldCount; i++)
{
var name = dr.DbDataReader.GetName(i);
c.Add(name, dr.DbDataReader.GetValue(i));
}
res.Add(c);
}

And in a code I've got 'date_from' value less for a value equals to time zone offset.
Npgsql.EntityFrameworkCore.PostgreSQL version <IP_ADDRESS>
PostgreSQL db 10.0
What is wrong?

@akusmin I'm closing this for now, but we can reopen pending some discussion in https://github.com/npgsql/npgsql/issues/2138.


Allow warnings in test and lint commands

Warnings are warnings, they should not make CI runs fail. A few notes:

External tooling might use console.warn that's out of our control.
ESLint warnings from rule violations that we consider errors should be configured as such.
We shouldn't need to work around this by piping stuff (stdout/stderr), etc.

I wonder for what reason exactly we need this, and how we might mitigate that issue in a different way?

Agree about all your points. Especially stderr during testing has surfaced a few separate times recently.
Regarding eslint I am not sure when we would intentionally choose to use warnings vs errors, but if we do, then we can configure it to exit non-zero for any warning. (which would make them... errors?)
Another question: do we want non-build-failing WARNs in our eslint config?

Our current WARN rules:
import/no-duplicates
@typescript-eslint/strict-boolean-expressions
@kadena-dev/typedef-var
          'warn',
          {
            arrayDestructuring: false,
            arrowParameter: false,
            memberVariableDeclaration: true,
            objectDestructuring: false,
            parameter: false,
            propertyDeclaration: true,
            variableDeclaration: false,
            variableDeclarationIgnoreFunction: true,
          },
        ],

Making warnings fail the build is two fold:

we want to allow things to be non-blocking during (local) development, but they should go wrong in the build
having accumulated warnings will lead to no one looking seriously at warnings anymore. That one important warning is drowned in clutter

Some more reasoning (from https://rushjs.io/pages/maintainer/add_to_repo/): If the command writes anything to the stderr stream, Rush will interpret this to mean that at least one error or warning was reported. This will break the build. (This is by design -- if you allow people to merge PRs that "cry wolf", pretty soon you will find that so many warnings have accumulated that nobody even reads them any more.) Some tooling libraries (e.g. Jest) write to stderr as part of their normal operation; you will need to redirect their output.
I'd say all warnings should be able to be suppressed properly, individually and consciously, however, some sources of warnings do not have the ability to suppress a warning in that manner.
Let's

find a way that the things will be blocking when they should be (in the ci) and are allowed in local development, and
have a process that allows to reflect on warnings that should be addressed

Regarding eslint I am not sure when we would intentionally choose to use warnings vs errors, but if we do, then we can configure it to exit non-zero for any warning. (which would make them... errors?)

Warnings should not result in non-zero exits. And it shouldn't be configuration magic people don't immediately grasp: as we can see people are confused as to why CI runs unnecessarily fail now, just from warnings.

Another question: do we want non-build-failing WARNs in our eslint config?

Personally I think it's normal for e.g. the naming convention stuff to be warnings, definitely not errors that must be "fixed" or suppressed. Developers see the warning during development and decide how to act on it (and there's still PR reviews, and that's that). So there are some rules we don't need to be so vigorous about, imho.
By the way, ESLint has an option to suppress warnings. We could use that in CI.

Making warnings fail the build is two fold:

we want to allow things to be non-blocking during (local) development, but they should go wrong in the build

Not sure I agree with this. I think things should behave the same as much as possible in dev vs production (and also in CI). Fail early, fail fast. Short feedback loop. I also like to refer to this old-school but still relevant https://12factor.net/dev-prod-parity. Or did you mean something else?

having accumulated warnings will lead to no one looking seriously at warnings anymore. That one important warning is drowned in clutter

If it's important enough to be an error, it should be an error.

Some more reasoning (from https://rushjs.io/pages/maintainer/add_to_repo/): If the command writes anything to the stderr stream, Rush will interpret this to mean that at least one error or warning was reported. This will break the build. (This is by design -- if you allow people to merge PRs that "cry wolf", pretty soon you will find that so many warnings have accumulated that nobody even reads them any more.) Some tooling libraries (e.g. Jest) write to stderr as part of their normal operation; you will need to redirect their output.

Then I'd say we should be looking into fixing or working around that Jest issue, not let everything else suffer from this.

I'd say all warnings should be able to be suppressed properly, individually and consciously, however, some sources of warnings do not have the ability to suppress a warning in that manner.
Let's

find a way that the things will be blocking when they should be (in the ci) and are allowed in local development, and

Make them behave the same as much as possible.

have a process that allows to reflect on warnings that should be addressed

Development + pull requests. Like you said, we don't want to drown in warnings, so they should imho always be addressed right away. But do we really have that issue? Let's see how "bad" it actually is first?

What baffles me is that Rush marks stderr output from scripts that exit with code zero (0) as warnings (and only then). And with the default "allowWarningsInSuccessfulBuild": false setting we are using it then proceeds to exit with a non-zero code itself.
This is... unexpected. First you need to understand what errors and warnings are to Rush, and then you need to understand that only in CI this results in failing jobs (and not during local development).
I think what Rush is missing is that scripts don't know upfront that they will eventually exit with zero or not. So they log to stderr as they see fit. Error logs, status information, diagnostics are written to stderr since it would interfere with output. We can't and don't want to control that. The only thing that matters is the final exit code, simple as that. I will die on this hill :)
Also, just checked and other tools like Nx and Turborepo don't even have/need this option.
Last but not least, this fragment from the Rush code docs strikes me as pedantic. Any project has its own responsibility to take care of this (not to be decided by a tool that sits in front of everything else):

In an active monorepo, we've found that if you allow any warnings in your main branch, it inadvertently
teaches developers to ignore warnings, which quickly leads to a situation where so many "expected" warnings
have accumulated that warnings no longer serve any useful purpose.

/rant

Glad to see this is sorted. For anyone reading this and using Rush: do not rely on allowWarningsInSuccessfulBuild: true, it's better to configure warning, errors and http exit codes properly.


InvocationTargetException on search

https://pastebin.com/YCwV5xMj - here's an error. It only happens for some nicknames, not all of them, most of the time check works just fine.
executing /altfinder search YouHaveTrouble gave me "I'm sorry, but there was an error performing this command"

Should be fixed with the latest update!


Add accordion section in index.html

I added a Frequently Asked Questions section in index.html and ensured the content aligned with your project guidelines.

Thanks for your contribution to the project during Hacktoberfest. Your efforts are highly appreciated and this will make a positive impact. Keep up the great work, and happy hacking! 💻✨


Simplify using GtkDrawingArea as a canvas

The features of GtkCanvas from the Gtk.jl package are inaccessible because GtkCanvas is not a GObject and there is no straightforward way to use a GtkDrawingArea created by a GtkBuilder as a GtkCanvas.

The current state of the Cairo.jl wrapper library makes working with GtkDrawingArea, even the hard way, essentially impossible. I'm waiting for a response on an issue and a pull request trying to fix the CairoContext form Ptr{Void} constructor. When that works, the second example in this repository demonstrates use of GtkDrawingArea as a canvas.

gtk_widget_queue_draw is supported with reveal in the Gtk wrapper. gtk_widget_queue_draw_area is useful and used in the drawing area example but not supported by the Gtk wrapper.

gdk_window_create_similar_surface is also necessary for creating Cairo surfaces.

gtk_widget_queue_draw_area is wrapped as reveal_area, gdk_window_create_similar_surface is wrapped as create_similar_surface, and use of gtk_widget_get_window is wrapped in window but not exported being used mainly internally to create_similar_surface on the convenience branch.

Merged in enhancements


HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure

Description of PR
TestDFSUtil.testIsValidName runs failed when  assertFalse(DFSUtil.isValidName("/foo/:/bar")) , fixed it.
HDFS-17249.
How was this patch tested?
Add test case in TestDFSUtil.testIsValidName.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 51s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
21m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 31s

the patch passed

+1 :green_heart:
shadedclient
21m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 54s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

92m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6249

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1647ddffbe6c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9f7aac66b9792b14e10c376f1ab5d259af75a7aa

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/1/testReport/

Max. process+thread count
726 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@GauthamBanasandra , hello sir，do you have time to review it，Thanks

@LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to HDFS-17248?

Sure.  I can.   But what's the difference between them that I need to notice？ Thanks

@LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to HDFS-17248?

Sure. I can. But what's the difference between them that I need to notice？ Thanks

@LiuGuH in the Hadoop community we normally follow the convention where the bug title in JIRA matches that of the Github PR.
In this case, HDFS-17248 in JIRA has the title Fix shaded client for building Hadoop on Windows. So, it can't have the title that you have put currently (Fix isValidName error).
Thus, you'll need to create a new JIRA for this.

@GauthamBanasandra  I create a new JIRA for this.  If the title is not matches, please give me a suggestion .Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 49s

trunk passed

+1 :green_heart:
compile
3m 13s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m  5s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 53s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
21m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
3m  7s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m  7s

the patch passed

+1 :green_heart:
compile
2m 58s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
2m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 42s

the patch passed

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
1m  8s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 27s

the patch passed

+1 :green_heart:
shadedclient
23m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  3s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
199m 52s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

315m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6249

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c6e98e525e7d 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5a5ede8be1dcfc73bf4f55c1e012f547f33b1c86

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/2/testReport/

Max. process+thread count
3744 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to HDFS-17248?

Sure. I can. But what's the difference between them that I need to notice？ Thanks

@LiuGuH in the Hadoop community we normally follow the convention where the bug title in JIRA matches that of the Github PR.
In this case, HDFS-17248 in JIRA has the title Fix shaded client for building Hadoop on Windows. So, it can't have the title that you have put currently (Fix isValidName error).
Thus, you'll need to create a new JIRA for this.

@LiuGuH I apologize for the confusion. The JIRA that you had created originally (HDFS-17248) had no issues. I overlooked the number and thought it was the same as HDFS-17246.
Anyway, we can go ahead with what you've tagged currently.

Seems like the run was aborted due to a restart -
15:18:17  Elapsed:   8m 13s
15:25:25  cd /c/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
15:25:25  mvn --batch-mode -Ptest-patch -Pdist -Dtar -Pnative-win -Dhttps.protocols=TLSv1.2 -Drequire.openssl -Drequire.test.libhadoop -Dshell-executable=/c/Git/bin/bash.exe -Dopenssl.prefix=/c/vcpkg/installed/x64-windows -Dcmake.prefix.path=/c/vcpkg/installed/x64-windows -Dwindows.cmake.toolchain.file=/c/vcpkg/scripts/buildsystems/vcpkg.cmake -Dwindows.cmake.build.type=RelWithDebInfo -Dwindows.build.hdfspp.dll=off -Dwindows.no.sasl=on -Duse.platformToolsetVersion=v142 -Dsurefire.rerunFailingTestsCount=2 -Pparallel-tests -Pshelltest -Drequire.test.libhadoop -Drequire.snappy -Pdist -Dtar -Pnative-win -Dhttps.protocols=TLSv1.2 -Drequire.openssl -Drequire.test.libhadoop -Dshell-executable=/c/Git/bin/bash.exe -Dopenssl.prefix=/c/vcpkg/installed/x64-windows -Dcmake.prefix.path=/c/vcpkg/installed/x64-windows -Dwindows.cmake.toolchain.file=/c/vcpkg/scripts/buildsystems/vcpkg.cmake -Dwindows.cmake.build.type=RelWithDebInfo -Dwindows.build.hdfspp.dll=off -Dwindows.no.sasl=on -Duse.platformToolsetVersion=v142 clean test -fae > /c/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt 2>&1
Resuming build at Sun Nov 05 14:23:08 UTC 2023 after Jenkins restart
Waiting to resume part of Apache Hadoop Nightly Build on Windows 10 #306: Finished waiting
Waiting to resume part of Apache Hadoop Nightly Build on Windows 10 #306: Finished waiting
Waiting to resume part of Apache Hadoop Nightly Build on Windows 10 #306: Jenkins is about to shut down

I've started a new run - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/310/console

having hit this myself, I'm going to say "this PR needss to include the name passed in rather than just assert true/false"
proposed,
assertValidName(String name) {
 assertFalse("Should have been rejected '" + name + "'", isValidName(name);
}

...and all asserts in the test case switched over to this. think how much easier it will be debugging yetus falures the next time there's a regressoin.

I've started a new run - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/310/console

When this run finished ， I will add  all asserts in the test case switched over to this @steveloughran  Thanks
assertValidName(String name) {
assertFalse("Should have been rejected '" + name + "'", isValidName(name);
}

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
9m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 12s

trunk passed

+1 :green_heart:
compile
3m 11s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m  4s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 53s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
25m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
3m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 50s

the patch passed

+1 :green_heart:
compile
3m 21s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
3m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 45s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 81 unchanged - 0 fixed = 83 total (was 81)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 31s

the patch passed

+1 :green_heart:
shadedclient
21m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 59s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
199m  6s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

326m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6249

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 77c4ea86da58 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8eec4d1ef52ce1d3368cd97ea5081590681089b5

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/3/testReport/

Max. process+thread count
3576 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
15m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 48s

trunk passed

+1 :green_heart:
compile
6m  8s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
6m 37s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 33s

trunk passed

+1 :green_heart:
mvnsite
2m 26s

trunk passed

+1 :green_heart:
javadoc
1m 55s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
5m 57s

trunk passed

+1 :green_heart:
shadedclient
35m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 56s

the patch passed

+1 :green_heart:
compile
5m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
5m 50s

the patch passed

+1 :green_heart:
compile
5m 57s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
5m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 18s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 82 unchanged - 0 fixed = 84 total (was 82)

+1 :green_heart:
mvnsite
2m 32s

the patch passed

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 11s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m  5s

the patch passed

+1 :green_heart:
shadedclient
37m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 28s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
272m 47s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

466m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6249

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ac59176a1fd1 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8eec4d1ef52ce1d3368cd97ea5081590681089b5

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/5/testReport/

Max. process+thread count
2992 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
33m  2s

trunk passed

+1 :green_heart:
compile
6m 30s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
6m 18s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 27s

trunk passed

+1 :green_heart:
mvnsite
2m 31s

trunk passed

+1 :green_heart:
javadoc
2m  2s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 23s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
5m 59s

trunk passed

+1 :green_heart:
shadedclient
36m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s

the patch passed

+1 :green_heart:
compile
6m 32s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
6m 32s

the patch passed

+1 :green_heart:
compile
5m 53s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
5m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 16s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 82 unchanged - 0 fixed = 84 total (was 82)

+1 :green_heart:
mvnsite
2m 13s

the patch passed

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  6s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
5m 57s

the patch passed

+1 :green_heart:
shadedclient
35m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 28s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
272m  4s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

469m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6249

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ca870b294a07 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8eec4d1ef52ce1d3368cd97ea5081590681089b5

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/4/testReport/

Max. process+thread count
3465 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran could you please review this PR?


Incorrect LICENSE_proj filename in setup.cfg

I copied this line from setup.cfg when updating the conda-forge recipe:
https://github.com/pyproj4/pyproj/blob/main/setup.cfg#L12
But the actual filename is LICENSE_proj4.  These should be made consistent.

Thanks for the report. Probably best to rename the license file the LICENSE_proj.


add more unit test to check the getDeviceforImage function

Signed-off-by: mgold1234<EMAIL_ADDRESS>Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 38.12% // Head: 38.08% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (7032773) compared to base (d6a1aab).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   38.12%   38.08%   -0.04%
==========================================
  Files          68       68
  Lines        9509     9511       +2
==========================================
- Hits         3625     3622       -3
- Misses       5446     5450       +4
- Partials      438      439       +1

Impacted Files
Coverage Δ

pkg/routes/images.go
28.08% <0.00%> (-0.11%)
:arrow_down:

pkg/services/devices.go
50.10% <0.00%> (-0.33%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/retest


fix(install): change install link to the new webpage

the install button was leading to the old install site
Did you sign your commit? Instructions yes
Have you read Contributing guidelines? yes

xrel https://github.com/kumahq/kuma-website/issues/1921


Migrate github runners to newer imags

In nightly today #1431 I see that
" ⚠ nightly
This workflow ran on a hosted runner that uses the "Base Image for Ubuntu Server 22.04". This image will be deprecated in September 2024. Please setup a new runner to use the "Ubuntu 22.04 by Arm Limited" or "Ubuntu 24.04 by Arm Limited" image. This will help reduce workflow run times as there are pre-installed tools. To view the list of installed software on new images, check out https://github.com/actions/partner-runner-images repository."
Please upgrade the runners to newer supported base image before the deadline.

duplicate of https://github.com/gardenlinux/gardenlinux/issues/2244

Runners with labels ubuntu-latest-64core, ubuntu-latest-arm, ubuntu-latest-arm-64core updated to ubuntu 24.04 and dropped the 16core variants as they were not used anyways.

[!WARNING]
This may break actions anywhere across our org if they rely on some behaviour specific to the old image. We'll need to see in the coming days what breaks

Thanks @nkraetzschmar
Dev workflow is green, are we aware of any other issues yet?


Limit the number of simultaneously open sockets per getter

Currently, there is no limit to the number of sockets that a single getter may keep open simultaneously.  If a malfunctioning or malicious client opened a very large number of sockets, they could create two classes of problems.

Generic memory overload.  Each open socket carries some memory cost in javascript, in the browser, and in the rest of the system.

Port space exhaustion.  If a single user opens ~65535 sockets to a single remote port (e.g. google.com:443), no other user will be able to open a socket to that remote port because all local ports will be exhausted, and the resource will effectively be blocked.

If a user has reached the limit, RtcToNet should reply to subsequent requests with a Socks.Reply.FAILURE or NOT_ALLOWED code (https://github.com/uProxy/uproxy-lib/blob/dev/src/socks-common/socks-headers.ts#L40).
Notes:
In uProxy, each open port corresponds to an open DataChannel.  The WebRTC standard allows for one peer to open up to 32768 DataChannels on each RTCPeerConnection.  However, there is nothing to prevent a single getter from establishing many proxy sessions through the same sharer, so a per-PeerConnection limit does not limit the number of ports that a single user can open.  Therefore, this limit should ideally be enforced per-user, not per-client, which will require coordination between the networking and core.  However, this is not crucial for an initial implementation.
If port space exhaustion, not general memory overhead, is the primary concern, then arguably the limit should be enforced on a per-remote-port basis.  One might also argue that the limit should depend on the number of currently active getters, or even the number of getters trying to access a particular remote port.  However, in principle this could create a privacy concern.

I presume this is an vulnerability that could only be exploited by someone
who is a "uproxy friend?" Still seems important to fix in the context of
uProxy for Cloud, where we may more peering with less-trusted or untrusted
friends.
On Wed, May 20, 2015 at 2:18 PM Benjamin M. Schwartz <
<EMAIL_ADDRESS>wrote:

Currently, there is no limit to the number of sockets that a single getter
may keep open simultaneously. If a malfunctioning or malicious client
opened a very large number of sockets, they could create two classes of
problems.

Generic memory overload. Each open socket carries some memory cost in
javascript, in the browser, and in the rest of the system.
2.
Port space exhaustion. If a single user opens ~65535 sockets to a
single remote port (e.g. google.com:443), no other user will be able
to open a socket to that remote port because all local ports will be
exhausted, and the resource will effectively be blocked.
If a user has reached the limit, RtcToNet should reply to subsequent
requests with a Socks.Reply.FAILURE or NOT_ALLOWED code (
https://github.com/uProxy/uproxy-lib/blob/dev/src/socks-common/socks-headers.ts#L40
).
Notes:
In uProxy, each open port corresponds to an open DataChannel. The WebRTC
standard allows for one peer to open up to 32768 DataChannels on each
RTCPeerConnection. However, there is nothing to prevent a single getter
from establishing many proxy sessions through the same sharer, so a
per-PeerConnection limit does not limit the number of ports that a single
user can open. Therefore, this limit should ideally be enforced per-user,
not per-client, which will require coordination between the networking and
core. However, this is not crucial for an initial implementation.
If port space exhaustion, not general memory overhead, is the primary
concern, then arguably the limit should be enforced on a per-remote-port
basis. One might also argue that the limit should depend on the number of
currently active getters, or even the number of getters trying to access a
particular remote port. However, in principle this could create a privacy
concern.
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/1568.

Yes, the "attacker" would have to be an approved friend.  I'm more concerned about this happening accidentally (due to misbehaving clients) than maliciously, but I think it's technically a DoS security issue.

More generally, this is resource limits for various dimensions of the proxy. I can imagine:

max. number sockets, peerconnections, and datachannels

Alternatively, capping the number of SOCKS sessions has the effect of capping the number of sockets and datachannels.
We may want per-user and global limits, too.

@bemasc, would you call this done?:
https://github.com/uProxy/uproxy-lib/pull/200

Nope.  Now uProxy needs to pass the userId to the RtcToNet constructor.


Board Review: Register namespace for .Net mgmt plane

We're owner of .net mgmt sdk, need to register namespaces for the following services:
compute
Azure.Management.Compute
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/compute/resource-manager
eventhub
Azure.Management.EventHub
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/eventhub/resource-manager
keyvault
Azure.Management.KeyVault
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/keyvault/resource-manager
monitor
Azure.Management.Monitor
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/monitor/resource-manager
network
Azure.Management.Network
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/network/resource-manager
resources
Azure.Management.Resources
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/resources/resource-manager
storage
Azure.Management.Storage
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/storage/resource-manager
app configuration
Azure.Management.AppConfiguration
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/appconfiguration/resource-manager
cc @allenjzhang

Scheduled a review for 5/20.

There is an ongoing, relevant conversation in #1245
Notes from the meetings are included there, but link to the recording will be copied here (MSFT INTERNAL): https://msit.microsoftstream.com/video/553aa1ff-0400-96d0-3325-f1ea9aeda3a2

Arch review board agreed to use Azure.ResourceManager.* as namespace for .net track 2 mgmt sdk:
compute
Azure.ResourceManager.Compute
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/compute/resource-manager
eventhub
Azure.ResourceManager.EventHubs
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/eventhub/resource-manager
keyvault
Azure.ResourceManager.KeyVault
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/keyvault/resource-manager
monitor
Azure.ResourceManager.Monitor
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/monitor/resource-manager
network
Azure.ResourceManager.Network
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/network/resource-manager
resources
Azure.ResourceManager.Resources
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/resources/resource-manager
storage
Azure.ResourceManager.Storage
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/storage/resource-manager
app configuration
Azure.ResourceManager.AppConfiguration
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/appconfiguration/resource-manager


GKE enhancement of some complex options

Problem:
We should expose some extra parameters for options, because some customers need them.
Solved:
GKE enhancement to add more complex options
ISSUE:
#14634
#14298
#13980
https://github.com/rancher/rancher/issues/16411
Related PR:
https://github.com/rancher/kontainer-engine/pull/106

LGTM

Is there a UI isue for this? I do not see one

Added related UI issues

Close in favor of https://github.com/rancher/rancher/pull/18006


Do a discovery UI project for course editing.

Look at how other platforms allow people to build and edit a course sequence and wireframe up some ideas for how we can solve for this.

This demo of the student experience of working through a code exercise on Codecademy might be neat to pick apart:
https://www.youtube.com/watch?v=2hpXfDRFHq0


TypeError: (0, _reactNativePermissions.checkMultiple) is not a function

I'm getting the following error.
I've deleted my DerivedData folder, node_modules, re-installed pods, deleted the app and rebuilt it but still get this error.  I have the following version installed:
"react-native-permissions": "^2.1.2"
I'm importing checkMultiple like this:
import {openSettings, PERMISSIONS, checkMultiple} from "react-native-permissions";
What am I doing wrong?
TypeError: (0, _reactNativePermissions.checkMultiple) is not a function. (In '(0, _reactNativePermissions.checkMultiple)([_reactNativePermissions.PERMISSIONS.IOS.CAMERA, _reactNativePermissions.PERMISSIONS.IOS.PHOTO_LIBRARY])', '(0, _reactNativePermissions.checkMultiple)' is undefined)

onload
    Viewer.js:183:39
tryCatch
    runtime.js:45:36
invoke
    runtime.js:274:29
tryCatch
    runtime.js:45:36
invoke
    runtime.js:135:27
PromiseImpl$argument_0
    runtime.js:170:16
tryCallTwo
    core.js:45:6
doResolve
    core.js:200:22
Promise
    core.js:66:11
callInvokeWithMethodAndArg
    runtime.js:169:15
enqueue
    runtime.js:192:38
exports.async
    runtime.js:219:8
onload
    Viewer.js:177:8
useEffect$argument_0
    Viewer.js:197:14
commitHookEffectList
    ReactNativeRenderer-dev.js:18008:31
commitPassiveHookEffects
    ReactNativeRenderer-dev.js:18061:28
invokeGuardedCallbackImpl
    ReactNativeRenderer-dev.js:286:4
invokeGuardedCallback
    ReactNativeRenderer-dev.js:497:2
flushPassiveEffectsImpl
    ReactNativeRenderer-dev.js:21577:27
unstable_runWithPriority
    scheduler.development.js:818:23
scheduleCallback$argument_1
    ReactNativeRenderer-dev.js:21431:29
workLoop
    scheduler.development.js:762:41
flushWork
    scheduler.development.js:717:23
_flushCallback
    scheduler.development.js:56:17
_callTimer
    JSTimers.js:135:14
callTimers
    JSTimers.js:387:16
__callFunction
    MessageQueue.js:425:19
__guard$argument_0
    MessageQueue.js:112:6
__guard
    MessageQueue.js:373:10
callFunctionReturnFlushedQueue
    MessageQueue.js:111:4
callFunctionReturnFlushedQueue
    [native code]:0

@wootwoot1234 Please respect the issue template. I need to know on which platform.

I’m sorry. I didn’t see a template. I’m using iOS.
On Thu, Apr 16, 2020 at 4:12 PM Mathieu Acthernoene <
<EMAIL_ADDRESS>wrote:

@wootwoot1234 https://github.com/wootwoot1234 Please respect the issue
template. I need to know on which platform.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/react-native-community/react-native-permissions/issues/447#issuecomment-614898894,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADGOGJ7T7GH2DBXTYE7X7DRM5YEHANCNFSM4MKCXEXQ
.

The template is the comment written inside the textarea when you create an issue.
Try cleaning your bundler cache. Run metro with react-native start --reset-cache

I don’t use the react-native command-line script. I use npx react-native run-ios to run the app but watchman watch-del-all fixed the issue.  Sorry for the trouble and thanks for the help.  I'll use the template next time.  :)

@wootwoot1234 RN apps have multiples caches layers (metro, watchman, Xcode, Gradle, etc.). I recommend setting up react-native-clean-project in your project, it will avoid you a lot of headaches in the future 🙂

Installing it now.  Thanks for the tip.  I took a 3-year break from developing apps so I really appreciate the advice.  Let me know if you have any other tips.


continue button should auto-scroll page to reveal new content

When I hit a continue button at the bottom of a page the new content appears however it doesn't scroll into view.

One related note: I think that we should include some bottom padding so that when the user is working they don't tend to be close the bottom of the page (feels more natural to work closer to the center and have some blank space below).


check if component is mounted before setting state

Fix for: 'Uncaught Error: Invariant Violation: replaceState(...): Can only update a mounted or mounting component.'

Thanks @vmakhaev


Fix crash in CheckAndRemove

This part specifically:
...erase(it3++)...
...erase((*it3)...

is simply incorrect but in rare cases it also leads to crash.
Also added more log output (for debug mode only).
PS. worth backporting to master imo https://github.com/dashpay/dash/blob/master/src/masternodeman.cpp#L331-L332

Merged, thanks!


bench_read_write

#83  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @apfitzge and the rest of your teammates on  Graphite


NameError: name '_httpx_client' is not defined

System Info
Hello All,
I have just installed the helm chart with some small additions to the basic values.yaml and the "langchain-langsmith-backend" contain keeps breaking with the following error, Has anyone had this before?
INFO: Started server process [1]
Fri, Nov 10 2023 2:41:24 pm | INFO: Waiting for application startup.
Fri, Nov 10 2023 2:41:24 pm | INFO: Application startup complete.
Fri, Nov 10 2023 2:41:24 pm | INFO: Uvicorn running on http://<IP_ADDRESS>:1984 (Press CTRL+C to quit)
Fri, Nov 10 2023 2:42:18 pm | INFO: Shutting down
Fri, Nov 10 2023 2:42:18 pm | INFO: Waiting for application shutdown.
Fri, Nov 10 2023 2:42:19 pm | ERROR:root:Error closing httpx client for clickhouse name '_httpx_client' is not defined
Fri, Nov 10 2023 2:42:19 pm | Traceback (most recent call last):
Fri, Nov 10 2023 2:42:19 pm | File "/code/smith-backend/app/main.py", line 140, in shutdown_event
Fri, Nov 10 2023 2:42:19 pm | File "/code/lc_database/lc_database/clickhouse.py", line 36, in close_clickhouse_client
Fri, Nov 10 2023 2:42:19 pm | await _httpx_client.aclose()
Fri, Nov 10 2023 2:42:19 pm | ^^^^^^^^^^^^^
Fri, Nov 10 2023 2:42:19 pm | NameError: name '_httpx_client' is not defined
Fri, Nov 10 2023 2:42:19 pm | INFO: Application shutdown complete.
Fri, Nov 10 2023 2:42:19 pm | INFO: Finished server process [1]
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
helm repo add langchain https://langchain-ai.github.io/helm/
helm install langchain/langsmith . --values values.yaml --namespace it-dev-langchain
Running this on an on prem Rancher cluster.
Expected behavior
The contain runs normally.

helm list - langsmith-0.1.3 0.1.0
NAME            NAMESPACE               REVISION        UPDATED                                 STATUS          CHART           APP VERSION
langchain       it-dev-langchain        1               2023-11-10 14:42:59.4745717 +0000 UTC   deployed        langsmith-0.1.3 0.1.0
lines changed in value
ingress: hostname: "langchain-langsmith-frontend.domain.com" config: langsmithLicenseKey: "langsmith_partner_2023"


Don't generate keys for root

In createkeys.{sh.csh} keys should not be generated for root. As /root is local to each node, there's not much point in generating a key and putting it in the authorized_keys.

Agreed. Changed in a206fd51bc0755daec1839d92706c1299da320da and cd0432cc33ecfd4eabad77237c5347bbc30aaf20


⚠ Fortnite has degraded performance

In 55b5709, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1608 ms

Resolved: Fortnite performance has improved in 697a6fb.


Replication Errors

Hi,
I am using the transport plugin 2.0 to index documents from  a couchbase (2.5.1)  3 Nodes cluster to an ES cluster 1.1.0 (3 Nodes).
The number of docs is  relatively small (5000)
Shortly after starting the XDCR replicator I am getting errors such as :
[xdcr:error,2015-01-07T11:14:20.640,ns_1@<IP_ADDRESS>:<0.2404.2153>:xdc_vbucket_rep:terminate:381]Replication (CAPI mode) 330487fb31ae3633bd19f43d4580cd2e/stage1/stage1 (stage1/332 -> http://*****@<IP_ADDRESS>:9091/stage1%2f332%3bd49b4d193469491f86f04463be174c08) failed: {http_request_failed,"POST",                 "http://Administrator:*****@<IP_ADDRESS>:9091/stage1%2F332%3Bd49b4d193469491f86f04463be174c08/_revs_diff",{error,{code,500}}}
and on the ES side I can see  :
[2015-01-07 11:22:54,693][ERROR][transport.couchbase.capi ] [elastic_node1] Unable to parse decoded base64 data as JSON, indexing stub for id: _sync:seq
[2015-01-07 11:22:54,693][ERROR][transport.couchbase.capi ] [elastic_node1] Body was: 6027 Parse error was: org.codehaus.jackson.map.JsonMappingException: Can not deserialize instance of java.util.LinkedHashMap out of VALUE_NUMBER_INT token
When I run queries on ES I am missing half of the results ..
Do you have any idea on how to troubleshoot this ?  I cannot figure out what's wrong with the documents . These are being updated by a CB Sync Gateway , could it be that they require a special field mapping ?
In the elastic config I tried index.mapping.ignore_malformed: true but that doesn't help
Thanks a lot for any help / suggestion
christian

The error you see on the Couchbase side is fatal, and we need to know what is causing it on the ES side.
The message you pasted from the ES side is more information in nature, and not really an error.  It looks like there is a document in the bucket that is not JSON.  This is not related the error you see on the Couchbase side.
Are there any other errors in the ES log?

Thanks for you help,
On the ES side, I am just getting that  same error I pasted , approx 1 every minute and ongoing .. and no other different errors.
You are saying there could be a doc that is no JSON in the bucket, in other words that some sort of corruption has occurred ? Should I try to restore a new empty bucket and start XDCR on it ?

No, but sync gateway stores additional documents, beyond just your data.  I believe that not all of these documents are JSON.  I seem to recall that there is a sequence number document, that is just a single numerical value, and the Couchbase INCR operation is used to manipulate it.  Because that document is not JSON it cannot be indexed.
The reason you keep seeing it is that every time the value is incremented, XDCR will try to send the document again.  There is really no way to avoid this.
That said, this is not related to the problem you are seeing.  The failed _revs_diff means that replication for at least one vbucket has stopped.  This will result in missing data in the search index.
Can you post the entire log ES log somewhere?

No problems about posting the ES log
I have restarted ES in DEBUG mode , can I send it to your email ?

Please send it to<EMAIL_ADDRESS> Thanks

Sorry for the delays, apparently the message you sent did not get through the corporate email.  Can you send it again this time to my gmail address?

I reviewed the log you sent, and it doesn't appear to be from the node that reported the _revs_diff error (<IP_ADDRESS>).
Can you send me the ES log from that node?

OK, I got the new log.  Unfortunately it looks like maybe the log rotated, as the log does not contain anything around the 2015-01-07T11:14:20.640 time period (where the original error on the Couchbase side was reported)
I do see some errors associated with _revs_diff though, so we can assume for now they are the same:
[2015-01-12 09:43:41,170][WARN ][org.eclipse.jetty.servlet.ServletHandler] /prod1%2f236%3b2ab66030488348f9ba03607828e02da0/_revs_diff
org.codehaus.jackson.JsonParseException: Invalid UTF-8 middle byte 0x2d61e972
at [Source: [B@747dbe01; line: 1, column: 56]
at org.codehaus.jackson.JsonParser._constructError(JsonParser.java:1433)
at org.codehaus.jackson.impl.JsonParserMinimalBase._reportError(JsonParserMinimalBase.java:521)
at org.codehaus.jackson.impl.Utf8StreamParser._reportInvalidOther(Utf8StreamParser.java:2830)
at org.codehaus.jackson.impl.Utf8StreamParser.addName(Utf8StreamParser.java:1821)
at org.codehaus.jackson.impl.Utf8StreamParser.findName(Utf8StreamParser.java:1749)
at org.codehaus.jackson.impl.Utf8StreamParser.parseLongFieldName(Utf8StreamParser.java:1373)
at org.codehaus.jackson.impl.Utf8StreamParser.parseMediumFieldName(Utf8StreamParser.java:1323)
at org.codehaus.jackson.impl.Utf8StreamParser._parseFieldName(Utf8StreamParser.java:1258)
at org.codehaus.jackson.impl.Utf8StreamParser.nextToken(Utf8StreamParser.java:495)
at org.codehaus.jackson.map.deser.std.MapDeserializer._readAndBind(MapDeserializer.java:299)
at org.codehaus.jackson.map.deser.std.MapDeserializer.deserialize(MapDeserializer.java:249)
at org.codehaus.jackson.map.deser.std.MapDeserializer.deserialize(MapDeserializer.java:33)
at org.codehaus.jackson.map.ObjectMapper._readMapAndClose(ObjectMapper.java:2732)
at org.codehaus.jackson.map.ObjectMapper.readValue(ObjectMapper.java:1935)
at com.couchbase.capi.servlet.CAPIServlet.handleRevsDiff(CAPIServlet.java:334)
at com.couchbase.capi.servlet.CAPIServlet.service(CAPIServlet.java:91)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:594)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:485)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:119)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:486)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1065)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:412)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:192)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:999)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:111)
at org.eclipse.jetty.server.Server.handle(Server.java:347)
at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:451)
at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:931)
at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:857)
at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:76)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:609)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:45)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:599)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:534)
at java.lang.Thread.run(Thread.java:745)
I've never encountered this one before.  But it does help narrow things down a bit.  The _revs_diff response is mostly made up of your document IDs and Couchbase revision numbers.  So the most likely cause is that you have a document id that is not utf-8 encoded.  Strictly speaking Couchbase does not require utf-8 encoded keys, but many of the newer features likes Views and XDCR expect it.
There are 2 things to do:

Review for any usual keys (possibly containing the byte sequence 0x2d61e972)
Please add the lines:
transport.couchbase: TRACE
com.couchbase: TRACE

To the "logger" section of your logging.yml config file.  Then restart the node.
At the trace level I think we log the entire _revs_diff request and response, which should help us find the problematic ID.

Fixed in v2.1.1


MySQL commands get messed up

Hello, I was trying to get r2d2-diesel working with MySQL and I got this error:

Commands out of sync; you can't run this command now

Searching for it, it seems that it's a known issue, and seems it could be fixed. Is this expected to be fixed anytime soon?

Duplicate of https://github.com/diesel-rs/diesel/issues/728


app and library are using different version of butterknife

we have a main app that uses version 7.0.1
and another small app uses 8.x.x
when we are trying to make the small one a library of the main app, butterknife version difference becomes the main roadblock.

This isn't supported. You should be using the same version across all modules of the same build so you'll need to update the older app.


[Bug]:  when ever I start a song up no arrows will appear and I cant play the song/chart

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
<EMAIL_ADDRESS>Version Info
Latest available release
What operating system are you seeing the problem on?
Linux (any distro)
Bug Behavior
the arrows for the song wont appear but I can still use my keys its just the songs wont work
Expected Behavior
it should have worked like normal and let me play it
Reproduction Steps
1.open the game 2.press a song ya wanna play and you will see it wont work
Anything else?
here's the commands I used to install etterna on Linux:sudo apt update
sudo apt install kmenuedit libglu1*
wget https://security.debian.org/debian-security/pool/updates/main/o/openssl/libssl1.1_1.1.1n-0+deb10u6_amd64.deb
sudo dpkg -i libssl1.1_1.1.1n-0+deb10u6_amd64.deb
wget https://github.com/etternagame/etterna/releases/download/v0.72.3/Etterna-0.72.3-Linux.tar.gz
tar -xf Etterna-0.72.3-Linux.tar.gz
./Etterna-0.72.3-Linux/Etterna/Etterna
kmenuedit

does the music play

no the music doesnt play
On Sun, Jul 28, 2024 at 5:34 PM poco0317 @.***> wrote:

does the music play
—
Reply to this email directly, view it on GitHub
https://github.com/etternagame/etterna/issues/1313#issuecomment-2254656176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEN5LVB3LP7XO2HP27HCPYTZOVPUVAVCNFSM6AAAAABLTECJAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGY2TMMJXGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

yo
you gonna replie

no, i dont maintain linux. the problem is linux audio related. someone else can try to figure it out

I would simply just say try reducing the amount of apps that you have open that uses audio, as that has helped me a lot of times when I have had audio issues in Linux.

i only install etterna
On Mon, Jul 29, 2024 at 9:02 PM sonicjoplus @.***>
wrote:

I would simply just say try reducing the amount of apps that you have open
that uses audio, as that has helped me a lot of times when I have had audio
issues in Linux.
—
Reply to this email directly, view it on GitHub
https://github.com/etternagame/etterna/issues/1313#issuecomment-2257265943,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEN5LVHPVGQUSLZNS5ITEZDZO3QYXAVCNFSM6AAAAABLTECJAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXGI3DKOJUGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

will we get a flatpak version soon
On Tue, Jul 30, 2024 at 4:14 AM solomon gibbs @.***>
wrote:

i only install etterna
On Mon, Jul 29, 2024 at 9:02 PM sonicjoplus @.***>
wrote:

I would simply just say try reducing the amount of apps that you have
open that uses audio, as that has helped me a lot of times when I have had
audio issues in Linux.
—
Reply to this email directly, view it on GitHub
https://github.com/etternagame/etterna/issues/1313#issuecomment-2257265943,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEN5LVHPVGQUSLZNS5ITEZDZO3QYXAVCNFSM6AAAAABLTECJAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXGI3DKOJUGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Not thread-safe implementation of WordRoomDatabase singleton

Despite of used synchronization primitives the example
public abstract class WordRoomDatabase : RoomDatabase() {

   abstract fun wordDao(): WordDao

   companion object {
        // Singleton prevents multiple instances of database opening at the
        // same time.
        @Volatile
        private var INSTANCE: WordRoomDatabase? = null

        fun getDatabase(context: Context): WordRoomDatabase {
            // if the INSTANCE is not null, then return it,
            // if it is, then create the database
            return INSTANCE ?: synchronized(this) {
                val instance = Room.databaseBuilder(
                        context.applicationContext,
                        WordRoomDatabase::class.java,
                        "word_database"
                    ).build()
                INSTANCE = instance
                // return instance
                instance
            }
        }
   }
}

is not thread safe as it allows creation of multiple instances of WordRoomDatabase. Double-Checked Locking needs to be used to make it working.

The code you have provided utilizes the Singleton pattern and synchronized to ensure Thread-safety when creating an instance of the Room database (WordRoomDatabase). In general, this code is Thread-safe. The reason for this assurance of Thread-safety is due to the use of @Volatile for the INSTANCE variable and the use of a synchronized block.
In this code:
The INSTANCE variable is declared using @Volatile. This ensures that changes made to this variable by one thread are seen by other threads in a non-disjointed manner.
In the getDatabase function, a synchronized block is used before creating a new instance of the database. This synchronized block ensures that only one thread can attempt to create a new instance of the database at any given time. Other threads have to wait until the instance is created, and this access is exclusive.
Therefore, this code correctly employs Thread-safe techniques for creating a Singleton instance of the database and prevents simultaneous creation of multiple instances, making it Thread-safe.

Thread-safe


Introduce project uploads information and statistics in DatasetService

Coverage increased (+0.3%) to 81.609% when pulling e06f3b045a67e48340fdde33eb2d7f821d34de3d on peter-plochan:data-service-2 into 021101f6a710995540df43a3a9ff340aec352d71 on martiner:master.


Machine win-10 went dead from network monitoring website.

Machine win-10 went dead from network monitoring website.

Windows OS is prompting for Windows upgrade, clicked on "Cancel" dialog to reboot machine.


Question: What is the reason behind the compositite ID key

Congratulations with this repo. Very useful and insightful. Thanks a lot.
Just one question for my understanding and learning, if you don't mind.
I Noticed that the ID field is a composition of the partition key and a Guid.
I would think the Guid with be sufficient?
Just trying to understand.
Thanks in advance
paul.

Hi Paul,
Thank you for you kind note!
In SQL world, you read a record by its id in most cases when the id is the primary key. In Cosmos DB, you read an item by its id and also partition key. If you look at the .NET SDK documentation, two params are required in the container method signature:
ToDoActivity toDoActivity = await this.container.ReadItemAsync<ToDoActivity>("id", new PartitionKey("partitionKey"));
In our application, the ID field is a composition in order to make a get item by ID request a point-read request, which is faster and cheaper. Particularly, in the IRepository.cs class:
Task<T> GetItemAsync(string id);
Instead of having two params in the signature, id and partition key, we use a composition so that it can be resolved into two params. The first part is the partition key value, and the second part (guid) is a unique identifier.
Your question does motivate me to write a quick article to explain this sector in more details. I hope update the project readme.md file with an article link soon.
Hope you find this helpful!
Many thanks,
Shawn

hi Shawn,
Thanks a lot for your prompt reply and detailed explanation.
warm regards
paul

@paulvanbladel you are very welcome! Take care!

For anyone who has similar questions or are just curious in partition key design best practices when working with Cosmos DB, I am in the process of writing a short article discussing my personal thoughts. Will post in the project page soon.
Cheers!

For anyone who is interested, I have written a short article sharing my personal thoughts on this topic. Please feel free to provide any feedback. Thanks!
Partitioning Best Practice in Partitioned Repository Pattern with Cosmos DB
Promise delivered, @paulvanbladel!


Firefox extension?

Somewhat related (app packaging):
https://github.com/readium/readium-js-viewer/issues/80
https://github.com/readium/readium-js-viewer/issues/57

Firefox is already accepted WebExtension technology, and they dicided to give up legacy technology in next month.

Firefox received WebExtension only since 57.0.

Some resources available at Developer Hub.
https://addons.mozilla.org/developers/


NPSP Localization - Spring '21

Critical Changes
Translated labels for Spring '21
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

Thank you for the updates on these @dmkud.

@force2b
I pushed the Adoption drop 2 files from the closed PR (https://github.com/SalesforceFoundation/NPSP/pull/6218) here.
cc: @bdvorachek

@force2b Mike, I pushed two commits with fixes for metadeploy and plural forms.
cc: @bdvorachek

@bdvorachek Thanks for the info on the 3 failing tests:

CRLP_RollupCMT_TEST: I think I've seen this one before. Though, what's really odd is that I just spun up a scratch org, changed the language to Spanish and ran this test. No failure. Strange.
ERR_ExceptionData_TEST: What is the error here? The method doesn't look like it has anything hardcoded in English other than the field Api Name, which wouldn't change anyway. Also, same result as above here. No error when I ran the test in my scratch org.
PS_GatewayManagement_TEST. This was I was able to reproduce.

🤷


Demo page does not play anything

When trying the demo page (https://jordaneldredge.com/projects/winamp2-js/) in Chrome (Version 64.0.3282.140 (Official Build) (64-bit)) there is no sound.
Checking the console I get the following messages:
index.js:116 [Deprecation] BiquadFilterNode.frequency.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
(anonymous) @ index.js:116
index.js:116 [Deprecation] AudioParam value setter will become equivalent to AudioParam.setValueAtTime() in M65, around March 2018  See https://webaudio.github.io/web-audio-api/#dom-audioparam-value for more details.
(anonymous) @ index.js:116
index.js:117 [Deprecation] BiquadFilterNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
(anonymous) @ index.js:117
index.js:185 [Deprecation] GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
value @ index.js:185
jordaneldredge.com/:1 MediaElementAudioSource outputs zeroes due to CORS access restrictions for https://d38dnrh1liu4f5.cloudfront.net/projects/winamp2-js/built/mp3/llama-2.91-deed9f60e1c2a04e753d90c72d57bea1.mp3
The last one is probably why it does not play.

Very interesting. I'm not able to reproduce this. I concur that it's the CORs issue that would be causing this.
Would you be able to look at the headers being returned for the requests for that file? (there will be a few).
Anything unique about your network setup?

General:
Request URL:https://d38dnrh1liu4f5.cloudfront.net/projects/winamp2-js/built/mp3/llama-2.91-deed9f60e1c2a04e753d90c72d57bea1.mp3
Request Method:GET
Status Code:206 Partial Content
Remote Address:<IP_ADDRESS>:443
Referrer Policy:no-referrer-when-downgrade
Request:
Accept:/
Accept-Encoding:gzip, deflate, br
Accept-Language:en-US,en;q=0.9
Cache-Control:max-age=0
Connection:keep-alive
Host:d38dnrh1liu4f5.cloudfront.net
If-Modified-Since:Sat, 01 Jan 1970 00:00:00 GMT
Origin:https://jordaneldredge.com
Range:bytes=0-1024
Referer:https://jordaneldredge.com/projects/winamp2-js/
User-Agent:Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36
Response:
Accept-Ranges:bytes
Access-Control-Allow-Headers:if-modified-since, range
Access-Control-Allow-Origin:*
Age:67940
Connection:keep-alive
Content-Length:1025
Content-Range:bytes 0-1024/38789
Content-Type:audio/mpeg
Date:Fri, 09 Feb 2018 05:42:58 GMT
ETag:"9785-564c0685520a5"
Last-Modified:Fri, 09 Feb 2018 05:00:30 GMT
Server:Apache/2.4.18 (Ubuntu)
Via:1.1 7431a433bf0337f3e6f22d8100c3dc23.cloudfront.net (CloudFront)
X-Amz-Cf-Id:eWp2xcc6KdZZC3Hoq6W5iMUtBy5V-0KKNi61IHxS0lZ29VUYxOvAPQ==
X-Cache:Hit from cloudfront

Do you have any browser extensions installed? Does this happen in other browsers? Does it happen in privacy mode?

It was an extension to Disable the HTML5 video autoplay (https://github.com/Eloston/disable-html5-autoplay).
After disabling the extension everything works. Sorry for your trouble.

This may be resolved in https://github.com/captbaritone/winamp2-js/commit/95221727d73eb5a75db6535594eefa4156308448.


Simplify normalizeSlashes

It turns out that replace totally ignores lastIndex. It's faster to not set the property, and then a little faster still to use a conditional.

@typescript-bot perf test this

Uh hmm, I guess it's slower? Am I misreading the results?

Uh hmm, I guess it's slower? Am I misreading the results?

Looks like noise to me - I'd run it again.

@typescript-bot perf test this

I'd call that a wash.  The change still has hygiene value, but I might wait until 4.9.

Ideally you'll see no change because the perf tests all run on Linux and theoretically should have no \ characters in paths.

You're right. I guess I don't know what to do about that one.

Ideally you'll see no change because the perf tests all run on Linux and theoretically should have no \ characters in paths. 😅😩

I think we actually have a bug about that: Linux paths can contain \ so normalizeSlashes could break them.

Yep, #44174. Though I'm a little apprehensive about that one just because of cross-platform configuration.

I'll wait for us to cut 4.8 before merging this, just in case.


Why is our footer so freakin' huge on every page? Let's shrink that down.

Remove some of the footer so that it doesn't take up so much real estate.

Catch All Triage - 1 2 3 4 5 6

Solved by #3157


--reload doesn't monitor include-files

When using the flag --reload if a file has been included with include-file and edited the bar will not be updated with the new settings.

This seems to have been forgotten when the include-file option was introduced, I'll take a look at it


MicroRos agent installation failed

Hi,
I am trying to install microros agent in my ubuntu 20.04 machine and ros2 foxy version is installed.
While installing am getting below error.
vasu@vasu:~/Micro_Ros/agentws$ ros2 run micro_ros_setup build_agent.sh
Building micro-ROS Agent
Starting >>> micro_ros_msgs
--- stderr: micro_ros_msgs
make[1]: *** No rule to make target 'micro_ros_msgs__py/CMakeFiles/micro_ros_msgs__py.dir/all', needed by 'CMakeFiles/micro_ros_msgs__python.dir/all'.  Stop.
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:146: all] Error 2
---
Failed   <<< micro_ros_msgs [1.36s, exited with code 2]

Summary: 0 packages finished [1.55s]
1 package failed: micro_ros_msgs
1 package had stderr output: micro_ros_msgs
1 package not processed
Please help me to resolve this issue.

Make sure that you run rosdep update && rosdep install --from-paths src --ignore-src -y to install micro_ros_msgs dependency. It should be done automatically by the build process.
If this does not work just clone micro_ros_msgs repo in your src folder before building the agent.


Win32 Unable to find an entry point named 'WSASetService' in DLL 'ws2_32.dll'

Hi Peter,
I have updated to v4.0.17 and it appears the changes made between v4.0.15 have broken the BluetoothListener code for Win32. The DoStart() method is failing with a "System.EntryPointNotFoundException".
Unable to find an entry point named 'WSASetService' in DLL 'ws2_32.dll'.
I'm wondering whether the changes to NativeMethods.cs may be the culprit.
Phil

Looks like combination of applying ExactSpelling=true to WSASetService and the actual entry point being WSASetServiceW. Will rebuild and release a new version.

I can confirm that this is now fixed.