Restructure libraries folder + MLMD Client first commit

project/libraries moves to tfx_addons folder for easier distribution of library with single package.
In addition, I added pre-commit checks to run pylint, yapf and isort for the new library. Excluded projects folders to allow individual teams to set up their own CI there.
Also adds GitHub actions to run pre-commit checks and pytest for all files.
Test run of GitHub CI: https://github.com/casassg/tfx-addons/pull/1/checks
Discussion for library structure can be found here: https://groups.google.com/a/tensorflow.org/g/tfx-addons-core/c/FVstcFUAgb4

It's titled "first commit", which makes me think that you're planning on more?

For MLMD Client yes. The idea is to add a simple client class for now and build upon it until we are ready to release it. Since we have several folks on this project, this is just a small simple bootstrapping for the client

Go ahead and merge when you're ready.  I'm waiting for your new folder hierarchy to create project folders.

I cant merge since Im creating files in folders I have no permissions to write under


Endianness

Currently the parsing is done only in big endian (network byte order). It should also be possible to specify host byte order (or more explicitly little endian).
Work items:

[x] Extend subprograms to extract/insert bits #894
[x] Adapt parser to support "with Byte_Order" aspect Pull request
[ ] Code to select correct extract/insert subprograms based on message endianness #900
[ ] Language documentation #901
[ ] Adapt pyrflx

You may find it useful: https://gitlab.com/KOLANICH/Endianness.py
Usage examples:
https://gitlab.com/KOLANICH/synalysis2kaitai/blob/master/Synalysis2Kaitai/__init__.py#L115
https://gitlab.com/KOLANICH/synalysis2kaitai/blob/master/Synalysis2Kaitai/__init__.py#L124

@KOLANICH Thanks for the pointers! This is quite a lengthy discussion and a lot of information to digest. As our DSL is influenced heavily by Ada (and the SPARK subset of Ada is also our target language), we will probably try to stay syntactically close to what the Ada community is doing. Here is a discussion on how they handle the endianness issue.

Here is a first design.
Language design
A type definition can have an aspect with Scalar_Storage_Order =>  with two possible values:

High_Order_First (default)
Low_Order_First

This corresponds to the Ada/GNAT aspect/attribute.
Implementation changes

I would add a generic parameter Endianness (or Byte_Order?) to RFLX.Generic_Types.Extract and Insert, which specifies the endianness.
Clients of the generic interface would provide the endianness of the type  at instantiation time
This info would be passed on to the internal Extract_U64 and Insert_U64 via a non-generic parameter
The code of these two subprograms needs to be adapted.

This last part looks quite hard as the code is already intricate. But the change is very local and can be easily unit-tested.

P.S. In our discussion with @senier I was surprised that we wanted to support little endian even if the field is not byte-aligned. But having looked at the code now I understand things better. It's not obvious how we would benefit from such a restriction even if we introduced it.

It's not obvious how we would benefit from such a restriction even if we introduced it.

I agree, we should not introduce any restriction if there is no benefit.

Here is a first design.
Language design
A scalar type definition can have an aspect with Scalar_Storage_Order =>  with two possible values:

I think the aspect should be called Byte_Order and the aspect should be associated with a message. The aspect will affect the interpretation of all scalar fields of a message. In the future, we could consider adding a Byte_Order aspect for message fields, so that the behavior can be overwritten for single fields, but we do not need that for now.

Implementation changes

I would add a generic parameter Endianness (or Byte_Order?) to RFLX.Generic_Types.Extract and Insert, which specifies the endianness.
Clients of the generic interface would provide the endianness of the type  at instantiation time
This info would be passed on to the internal Extract_U64 and Insert_U64 via a non-generic parameter
The code of these two subprograms needs to be adapted.

I think the parameter should be called Byte_Order (to be consistent and differentiate it from the bit ordering). What is the advantage of using a generic parameter instead of a non-generic parameter for the generic Insert/Extract?

This last part looks quite hard as the code is already intricate. But the change is very local and can be easily unit-tested.

I agree. It would make sense to get some samples from real-world messages to validate the implementation. SPDM would be a sensible option.

What is the advantage of using a generic parameter instead of a non-generic parameter for the generic Insert/Extract?

The advantage would be that the Byte_Order is specified by the client at one point only, so we can avoid the mistake where different byte orderings would be used throughout the application.

The advantage would be that the Byte_Order is specified by the client at one point only, so we can avoid the mistake where different byte orderings would be used throughout the application.

Extract/Insert is only used in generated code. For messages, their use is limited to Get_Field_Value or Set_Field_Value. So I'm not really convinced that a generic parameter is beneficial. For just supporting byte ordering for a complete message, both variants would be simple to generate correctly (setting the same byte ordering for all instantiations or all calls makes not much difference). But when we will add support for different endianness for different message fields in the future, a non-generic parameter would simplify the code generation (as each field is represented by a call).

I'm OK with a non-generic parameter. I'm updating the design.

Summary from our live discussion. The Extract / Insert functions are quite intricate and a large change/rewrite should be avoided if possible. So if small tweaks are enough to support endianness, that would be preferable. Alex suggested as a first step to implement a separate function to support little endian. This could suggest the necessary modifications to the original functions. If the functions turn out to be very different, the final design could even consist of using separate functions for little and big endianness.

Coming back to this point. Is it really worthwhile to have a single Extract function which does both little and big endian? Same question for Insert obviously. I think both for proof and execution it will be simpler/faster to have separate versions for little and big endian.

Checking in here before I go any further to avoid losing time working in a wrong direction. I have written a version of Extract for little endian, called Extract_Little, copy-pasted below.
   function U64_Extract_Little
      (Data       : Bytes;
       Off        : Offset;
       Value_Size : Positive) return U64 with
     Pre =>
       (Value_Size in 1 .. U64'Size
        and then Long_Integer ((Natural (Off) + Value_Size - 1) / Byte'Size) < Data'Length
        and then (Natural (Off) + Value_Size - 1) / Byte'Size <= Natural'Size
        and then (Byte'Size - Natural (Off) mod Byte'Size) < Long_Integer'Size - 1),
     Post =>
       (if Value_Size < U64'Size then U64_Extract_Little'Result < 2**Value_Size)
   is
      LSE_Index : constant Index := Index (Natural (Data'Last) - Natural (Off) / Byte'Size);
      MSE_Index : constant Index := Index (Natural (Data'Last) - (Natural (Off) + Value_Size - 1) / Byte'Size);

      LSE_Offset : constant Natural := Natural (Natural (Off) mod Byte'Size);
      LSE_Size   : constant Natural := Byte'Size - LSE_Offset;

      MSE_Size   : constant Natural := (LSE_Offset + Value_Size + Byte'Size - 1) mod Byte'Size + 1;
      Result : U64 := 0;
      Bits : Natural with Ghost;

      --  Data is assumed to contain Amount bits of information. We append
      --  those bits to the current value of Result. We also update the Bits
      --  ghost variable.
      procedure Shift_Add (Data : U64; Amount : Natural)
      with Pre  => Bits < U64'Size and then Amount < U64'Size and then Result < 2 ** Bits and then U64'Size - Amount >= Bits and then Data < 2 ** Amount,
           Post => (if Bits < U64'Size then Result < 2 ** Bits) and then Bits = Bits'Old + Amount;

      procedure Shift_Add (Data : U64; Amount : Natural) is
      begin
         Result := Shift_Left (Result, Amount) + Data;
         Bits := Bits + Amount;
      end Shift_Add;

      pragma Warnings (Off, "postcondition does not check the outcome of calling ""Lemma_Bound_And""");
      procedure Lemma_Bound_And (X : U64; Bound : Natural)
        with Pre => Bound < U64'Size,
             Post => (X and (2 ** Bound - 1)) < 2 ** Bound
      is
      begin
         null;
      end Lemma_Bound_And;
      pragma Warnings (On, "postcondition does not check the outcome of calling ""Lemma_Bound_And""");

   begin
      --  This function simply iterates over all data bytes that contain
      --  relevant data, from most significant to least significant, and adds
      --  them up in Result, shifting the Result before the addition as needed
      --  (see helper function Shift_Add).

      --  The ghost variable Bits stores the number of bits that are contained
      --  in Result. This is useful to bound the --  current value of Result by
      --  2 ** Bits. At the end of the function, Bits = Value_Size.

      --  We start with the most significant byte, which is LSE_Index in little
      --  endian. We need to take into account the case where this is the
      --  last/only byte.
      declare
         Tmp : U64 := Byte'Pos (Data (LSE_Index));
      begin
         if LSE_Index = MSE_Index then
            Tmp := Tmp and (2 ** MSE_Size - 1);
         end if;
         Tmp := Shift_Right (Tmp, LSE_Offset);
         Result := Result + Tmp;
      end;

      --  If it was the only byte, we are done.

      if LSE_Index = MSE_Index then
         return Result;
      end if;

      --  The Bits variable is not needed for the previous early return, so we
      --  update it only here. Also, setting it to LSE_Size is only correct if
      --  we did not return early, so this is the best place to update it.
      Bits := LSE_Size;

      --  We now iterate over the "inner bytes" excluding the two extreme bytes.
      for I in reverse MSE_Index + 1  .. LSE_Index  - 1 loop
         pragma Loop_Invariant
           (Bits = Natural (LSE_Index - I) * Byte'Size - LSE_Offset
            and then Result < 2 ** Bits);
         Shift_Add (Byte'Pos (Data (I)), Byte'Size);
      end loop;

      --  We now add the relevant bits from the last byte (MSE_Index in little
      --  endian). Some helper assertions and a lemma are needed.
      pragma Assert (MSE_Size < U64'Size);
      Lemma_Bound_And (Byte'Pos (Data (MSE_Index)), MSE_Size);
      Shift_Add (Byte'Pos (Data (MSE_Index)) and (2 ** MSE_Size - 1), MSE_Size);
      pragma Assert (Bits = Value_Size);
      pragma Assert (if Bits < U64'Size then Result < 2 ** Bits);
      return Result;
   end U64_Extract_Little;

Some comments:

The structure of Extract_Little is different from Extract, as I was unable to sufficiently understand Extract to adapt it to Little endian. The structure is now similar to Insert, that is it just proceeds byte per byte in the input data.
I think it would be easy to make a big endian version of it (that is, rewrite Extract in the style of my Extract_Little). However it would be cumbersome to write a single function that does both.
The code above is fully proved, however colibri is needed for one check (the postcondition).
The code doesn't use the various helper functions of RFLX.Arithmetic, in particular it uses regular Shift_Left and Shift_Right.
Going more into detail, the function defines the local variables LSE_Index, MSE_Index according to the picture in the comments, while the existing Extract and Insert use another definition and then use translation functions to map the indices back to their original meaning.

Going forward, my next steps would be:

Proceed to the Insert function. I think here I can adapt the existing Insert as the structure is quite simple. Again I would write a second Insert_Little function instead of a single function with an extra parameter as in the initial design.
(Optional) rewrite Extract in the style of Extract_Little for conformity
(Optional) adapt existing code to avoid dependency on RFLX.Arithmetic and remove that unit.

Any opinions on this before I go any further?

Is it really worthwhile to have a single Extract function which does both little and big endian? Same question for Insert obviously. I think both for proof and execution it will be simpler/faster to have separate versions for little and big endian.

I think it is fine to have separate functions for LE and BE. Nevertheless, both functions should not be completely different, but use the same approach.

The code above is fully proved, however colibri is needed for one check (the postcondition).

I suppose that will not be a viable solution at the moment, as our CI pipeline uses Community 2021 which does not include Colibri. I don't think we can easily switch to another version. Not testing it in the CI pipeline is also not an option.

The code doesn't use the various helper functions of RFLX.Arithmetic, in particular it uses regular Shift_Left and Shift_Right.

As far as I remember, we did not use the built-in shift functions, because they did not have the necessary contracts to prove anything about their results. Isn't this the case in Community 2021 anymore?

Going forward, my next steps would be:

Proceed to the Insert function. I think here I can adapt the existing Insert as the structure is quite simple. Again I would write a second Insert_Little function instead of a single function with an extra parameter as in the initial design.
(Optional) rewrite Extract in the style of Extract_Little for conformity
(Optional) adapt existing code to avoid dependency on RFLX.Arithmetic and remove that unit.

That makes sense. Ideally, all the Insert and Extract functions use a similar approach, so we should rewrite exiting functions if necessary. Getting rid of RFLX.Arithmetic by using built-in functions would definitely an advantage. If it is possible, we should do it.

I suppose that will not be a viable solution at the moment, as our CI pipeline uses Community 2021 which does not include Colibri. I don't think we can easily switch to another version. Not testing it in the CI pipeline is also not an option.

I was using the Community 2021 for my experiments. It contains Colibri, but was not advertised as it was still experimental. But I don't think there were any known unsoundnesses. If not acceptable I can also try to eliminate colibri from the required provers.

As far as I remember, we did not use the built-in shift functions, because they did not have the necessary contracts to prove anything about their results. Isn't this the case in Community 2021 anymore?

The built-in Shift functions have had the relevant contracts for quite a while I think, and definitely in CE 2021.

I was using the Community 2021 for my experiments. It contains Colibri, but was not advertised as it was still experimental. But I don't think there were any known unsoundnesses. If not acceptable I can also try to eliminate colibri from the required provers.

I see. If you don't see an increased probability of soundness issues by enabling Colibri, I think it is fine to use it.

Here are some tests for the changes on PyRFLX:
diff --git a/tests/data/fixtures/pyrflx.py b/tests/data/fixtures/pyrflx.py
index 840cbee23..b80b68bd0 100644
--- a/tests/data/fixtures/pyrflx.py
+++ b/tests/data/fixtures/pyrflx.py
@@ -27,6 +27,7 @@ def fixture_pyrflx() -> pyrflx.PyRFLX:
             f"{SPEC_DIR}/message_type_size_condition.rflx",
             f"{SPEC_DIR}/always_valid_aspect.rflx",
             f"{SPEC_DIR}/parameterized.rflx",
+            f"{SPEC_DIR}/endianness.rflx",
         ],
         skip_model_verification=True,
     )
@@ -225,3 +226,8 @@ def fixture_always_valid_aspect_value(
 @pytest.fixture(name="parameterized_package", scope="session")
 def fixture_parameterized_package(pyrflx_: pyrflx.PyRFLX) -> pyrflx.Package:
     return pyrflx_.package("Parameterized")
+
+
+@pytest.fixture(name="endianness_package", scope="session")
+def fixture_endianness_package(pyrflx_: pyrflx.PyRFLX) -> pyrflx.Package:
+    return pyrflx_.package("Endianness")
diff --git a/tests/data/specs/endianness.rflx b/tests/data/specs/endianness.rflx
new file mode 100644
index 000000000..1ad326d0c
--- /dev/null
+++ b/tests/data/specs/endianness.rflx
@@ -0,0 +1,31 @@
+package Endianness is
+
+   type Tag is (None => 1, Data => 2) with Size => 16;
+   type Length is range 0 .. 2 ** 14 - 1 with Size => 16;
+
+   type Message is
+      message
+         Tag : Tag
+            then null
+               if Tag = None
+            then Length
+               if Tag = Data;
+         Length : Length;
+         Payload : Opaque
+            with Size => Length * 8;
+      end message;
+
+   type Message_LE is
+      message
+         Tag : Tag
+            then null
+               if Tag = None
+            then Length
+               if Tag = Data;
+         Length : Length;
+         Payload : Opaque
+            with Size => Length * 8;
+      end message
+         with Byte_Order => Low_Order_First;
+
+end Endianness;
diff --git a/tests/unit/pyrflx_test.py b/tests/unit/pyrflx_test.py
index 3d6575f8a..efdd12917 100644
--- a/tests/unit/pyrflx_test.py
+++ b/tests/unit/pyrflx_test.py
@@ -1439,3 +1439,67 @@ def test_json_serialization() -> None:
     opaque_value = OpaqueValue(Opaque())
     opaque_value.assign(b"RecordFlux")
     assert opaque_value.as_json() == b"RecordFlux"
+
+
+def test_message_endianness_parse_be(endianness_package: Package) -> None:
+    message = endianness_package.new_message("Message")
+
+    message.parse(b"\x00\x01")
+
+    assert message.valid_message
+    assert message.get("Tag") == "None"
+
+    message.parse(b"\x00\x02\x00\x04\x01\x02\x03\x04")
+
+    assert message.valid_message
+    assert message.get("Tag") == "Data"
+    assert message.get("Length") == 4
+    assert message.get("Payload") == b"\x01\x02\x03\x04"
+
+
+def test_message_endianness_parse_le(endianness_package: Package) -> None:
+    message_le = endianness_package.new_message("Message_LE")
+
+    message_le.parse(b"\x01\x00")
+
+    assert message_le.valid_message
+    assert message_le.get("Tag") == "None"
+
+    message_le.parse(b"\x02\x00\x04\x00\x01\x02\x03\x04")
+
+    assert message_le.valid_message
+    assert message_le.get("Tag") == "Data"
+    assert message_le.get("Length") == 4
+    assert message_le.get("Payload") == b"\x01\x02\x03\x04"
+
+
+def test_message_endianness_set_be(endianness_package: Package) -> None:
+    message = endianness_package.new_message("Message")
+
+    message.set("Tag", "None")
+
+    assert message.valid_message
+    assert message.bytestring == b"\x00\x01"
+
+    message.set("Tag", "Data")
+    message.set("Length", 4)
+    message.set("Payload", b"\x01\x02\x03\x04")
+
+    assert message.valid_message
+    assert message.bytestring == b"\x00\x02\x00\x04\x01\x02\x03\x04"
+
+
+def test_message_endianness_set_le(endianness_package: Package) -> None:
+    message_le = endianness_package.new_message("Message_LE")
+
+    message_le.set("Tag", "None")
+
+    assert message_le.valid_message
+    assert message_le.bytestring == b"\x01\x00"
+
+    message_le.set("Tag", "Data")
+    message_le.set("Length", 4)
+    message_le.set("Payload", b"\x01\x02\x03\x04")
+
+    assert message_le.valid_message
+    assert message_le.bytestring == b"\x02\x00\x04\x00\x01\x02\x03\x04"

Thanks, that helps a lot. I was able to modify pyrflx to pass your tests, though I'm not confident in my patch ... I will put it on review when the other patches are through.


RUM-5553: Implement MetricHttpClient and RequestBodyBuilder

What does this PR do?
Implement MetricHttpClient and RequestBodyBuilder,
The request corresponds to the spec:
https://docs.datadoghq.com/api/latest/metrics/#submit-metrics
Motivation
RUM-5553
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.00%. Comparing base (2f10387) to head (ec54594).
Report is 1 commits behind head on feature/metric-benchmark.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/metric-benchmark    #2142      +/-   ##
============================================================
+ Coverage                     69.96%   70.00%   +0.04%
============================================================
  Files                           726      726
  Lines                         26976    26976
  Branches                       4520     4520
============================================================
+ Hits                          18873    18883      +10
+ Misses                         6829     6826       -3
+ Partials                       1274     1267       -7

see 23 files with indirect coverage changes


Horizontal Layout Updates

Updates to ensure 24 hours shown in horizontal layout. Also further updates to ensure headers and time supplementary views are fixed to the top/side of the scroll view rather than bouncing when you reach the elastic regions. This also ensure the gird lines do not end abruptly at the bounds of the scroll view.

+1 for these improvements

Thanks. I have more on the way.

@khendry I believe you should start another project with a new name, give the credits to Eric and keep improving this awesome control.

I'd been thinking that as well. Thanks for the suggestion.  I probably will do that in the near future.

and add parse so you can remotely add events in the cloud

Checkout my fork https://github.com/BadChoice/RVCalendarWeekView
It is updated and with some new features 👯


feat(now): merge watermark of multiple ready barriers

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously, in our now executor, we generate a new watermark for every new barrier. However, when barriers pile up, we will repeatedly generate a new watermark and then overwrite it, which may increase the barrier latency of downstream and cause the barrier pile up more and more.
In this PR, we will try to fetch all barriers that are already received but not handled (which are the piled barriers) in with a recv_multiple method, and then handle all barriers together and in the end only emit a single watermark.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Per slack discussion, my concern of this PR is that it can potentially make the data emit by one epoch via dynamic filter larger than before. For example, assume user has a table with 1-day temporal filter and assume the table's data is evenly distributed by time. Let's say the source throughput for this table is 10k/s at T. Before this PR, with barrier_interval_ms=1000, we expect the dynamic filter output throughput to be 10k/s. However, with this PR, the dynamic filter output throughput can become 64*10=640K/s.
Another alternative to optimize it without the above issue is to create the storage iter only once and use it across multiple barriers if barriers are piled up. Not sure whether this can be an overkill though.

May I ask whether this is getting merged? 👀

May I ask whether this is getting merged? 👀

I am not sure about it. As pointed out by @hzxa21 , with this PR we may have more data in an epoch than before when barrier gets piled up, which may cause OOM. But with mem table spill, I think this problem can be mitigated.
What do you think? @hzxa21 @BugenZhao


Incorrect Emulator list parsing

There's a erroneous entry in the android emulator list

For reference:
$ANDROID_HOME/cmdline-tools/latest/bin/avdmanager list avd
Available Android Virtual Devices:
    Name: Pixel_7_Pro_API_34
  Device: pixel_7_pro (Google)
    Path: /Users/rigor789/.android/avd/Pixel_7_Pro_API_34.avd
  Target: Google Play (Google Inc.)
          Based on: Android 14.0 ("UpsideDownCake") Tag/ABI: google_apis_playstore/arm64-v8a
    Skin: 1440x3120
  Sdcard: 512M
---------
    Name: ZTelevision_API_34
  Device: tv_1080p (Google)
    Path: /Users/rigor789/.android/avd/ZTelevision_720p_API_34.avd
  Target: Android TV
          Based on: Android 14.0 ("UpsideDownCake") Tag/ABI: android-tv/arm64-v8a
    Skin: 1920x1080
  Sdcard: 512 MB

$ANDROID_HOME/emulator/emulator -list-avds
INFO    | Storing crashdata in: /tmp/android-rigor789/emu-crash-34.1.20.db, detection is enabled for process: 58515
Pixel_7_Pro_API_34
ZTelevision_API_34

$ANDROID_HOME/emulator/emulator -version
INFO    | Storing crashdata in: /tmp/android-rigor789/emu-crash-34.1.20.db, detection is enabled for process: 58580
INFO    | Android emulator version <IP_ADDRESS> (build_id 11610631) (CL:N/A)
INFO    | Storing crashdata in: /tmp/android-rigor789/emu-crash-34.1.20.db, detection is enabled for process: 58580
INFO    | Duplicate loglines will be removed, if you wish to see each individual line launch with the -log-nofilter flag.
Android emulator version <IP_ADDRESS> (build_id 11610631) (CL:N/A)
Copyright (C) 2006-2017 The Android Open Source Project and many others.
This program is a derivative of the QEMU CPU emulator (www.qemu.org).

  This software is licensed under the terms of the GNU General Public
  License version 2, as published by the Free Software Foundation, and
  may be copied, distributed, and modified under those terms.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

This likely needs to be filtered here:
https://github.com/okwasniewski/MiniSim/blob/0dffe44bce54dd321983bd79c56d78ccd5fa856c/MiniSim/Service/DeviceService.swift#L379-L391
Perhaps a simple && !$0.contains(" |") in the filter would be sufficient, as I don't think emulator names could/would contain  | in their name.

Confirm
Unable to Delete it

Hey, this is a bug in ADB that happens after upgrading Android Studio. Try to update to the latest version and remove this simulator using Android Studio. You can check if ADB works properly using:
emulator -list-avds

It is a bug of emulator. This StackOverflow answer worked for me: https://stackoverflow.com/a/78111618.
It might be worth filtering emulator names started by INFO    | Storing crashdata in.

I've added filtering out emulator names in 0.8.4


Error message when install in ZSH

when onboard fordje and running the install command we got a parse error complaining about /n

https://hyphen.ai/cli


Translate Readme into English

Translating your repository will give much more exposure

In fact, there is already a link to the English version in the upper right corner of the readme. Is it not conspicuous enough? Or do you think it needs to be improved?


[Snyk] Security upgrade golang from 1.13 to 1.21.7

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

src/vendor/github.com/gabemarshall/pty/Dockerfile.riscv

We recommend upgrading to golang:1.21.7, as this image has only 84 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

433
Link Following SNYK-DEBIAN10-GIT-1083853
No Known Exploit

433
Link Following SNYK-DEBIAN10-GIT-1083853
No Known Exploit

561
Resource Exhaustion SNYK-DEBIAN10-NGHTTP2-5953390
Mature

375
CVE-2023-26604 SNYK-DEBIAN10-SYSTEMD-3339153
Mature

375
CVE-2023-26604 SNYK-DEBIAN10-SYSTEMD-3339153
Mature

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

No, this is a vendor dependency file.


updated to Flink v0.10.1

updated to Flink v0.10.1 and tested if the web front-end comes up

Do you have JIRA ticket filed for this? As part of ASF contribution please do file JIRA [1] and associate with the PR [2]. Thanks!
[1] https://issues.apache.org/jira/browse/FLINK/
[2] https://flink.apache.org/contribute-code.html

Thanks @hsaputra for the reminder. I've filed a JIRA: https://issues.apache.org/jira/browse/FLINK-3155
Looks good to merge otherwise.


Can we launch accelerate from a Python script instead of CLI?

I am trying to do hyperparameter optimization using Ray Tune and want to use accelerate to handle multi-gpu training.
I am fairly new to accelerate and could only find the CLI method (accelerate launch) to launch the script. Do we have something like accelerate.launch or something similar to notebook_launcher that can launch the training from the script?
I am looking to see if I can pass a function that takes a config as an argument - something like this: accelerate.launch(my_train_func, ags=[config], ...)
Thanks in advance.

This would require to run independent subprocesses, not too sure how Ray Tune is going to like that since it won't be able to inspect how training is going.

I have a similar issue: I have a server that is taking requests from outside to then launch training. I want to make the training distributed but of course only have the server process run on a single process. Since the message reading is running in a
while True:
    process_message(message)

I can't wrap that in a if accelerator.is_local_main_process: because then the whole training loop would only run on one GPU. Did you ever find a solution to what you were trying to do @ayulockin ?

I didn't find any solution with accelerate. In my case, I would have used Ray Train for distributed training.

Does Ray Train allow for distributed functions?

This is my reference: https://docs.ray.io/en/latest/tune/tutorials/tune-resources.html#how-to-run-distributed-training-with-tune

Hello @samiede and @ayulockin, have you looked at this test: https://github.com/huggingface/accelerate/blob/main/tests/deepspeed/test_deepspeed.py#L657-L699 wherein accelerate is launched from a python script instead of cli? Let us know if that solves the issue.

Reopening.

We implemented a Huggingface Accelerate integration for Ray - https://github.com/ray-project/ray/pull/33269


Change default bucket name to something other than "default"

InfluxDB originally used the name default for the default retention policy. This ended up being very confusing for users and hard to succinctly document. Here is the original discussion on the topic. InfluxDB v2 has started using default as the default bucket name again. This should be switched to something else.
The earlier we can change this the better.
InfluxDB v1.x uses autogen as the retention policy name for the default auto-generated retention policy for new databases. Not sure if autogen makes sense in InfluxDB v2.0. @mark-rushakoff suggested using my_bucket as the default bucket name until there's a better suggestion.

Predefined dashboards could be changed to use the first bucket that is returned for a user. We still need template variables eventually, but this way we would not use 'default'.

Is it a problem that scraping is set up to write to a new bucket called 'default'?

@ebb-tide yes! it should be set up to write to the bucket the user created.

@ebb-tide also, the creation of the pre-defined dashboard needs to use the same bucket name as the user has for the telegraf config.

@russorat I can make precanned dashboards to work with just the first bucket that is returned for user, this would provide a quick hack that would work until we get macros and we can do what you suggest:

the creation of the pre-defined dashboard needs to use the same bucket name as the user has for the telegraf config.

closed by #12533. Dashboards added to accompany telegraf plugins are now created by templates which can accept variables, rather than protoboards which could not. However, templates are initialized at onboarding, and will not exist for users who have previously gone through onboarding.


Send and Receive NRPN messages?

Is there any plans to send / receive NRPN messages?
I can see sending NRPN messages is implemented on WebMidi and for parsing NRPN messages i have this prototype in javascript ( for max/msp mainly borrowed from Chris Hector's article on Max/MSP NRPN messages ) that parses NRPN messages, so i'm wondering how easy would be to port NRPN messages to GIBBERWOCKY so we could leverage goodies such as lfo with high precision NRPN messages?
If i'm not mistaken MIDI over USB / virtual midi have higher bandwidth than a regular MIDI cable so an option to trottle messages on a channel might be something to consider?

@charlieroberts i believe the API would be the same as modulating a CC, the only difference is that the parameter address has 2 values, instead of one.
For instance MSB 18 LSB 0, so instead of
channel.cc0( value )

we would need something like:
channel.nrpn( MSB, LSB, value )

The difference here is that value is not from 0 to 127, as a CC could be.
One the NRPN synth i have here i can send values from 0 until 4096 for the filter.
So i believe the LFO would have to scale to that value, the problem is some NRPN parameters might have different values, so we could have a default "min" and "max" value for NRPN "range" but offer extra parameters for range. something like
channel.nrpn( MSB, LSB, value, 100, 2500 ) // scale amp from 100 to 2500

does that make sense?


Opton to disable selection of terms in TermPicker

Category

[x] Enhancement
[ ] Bug
[ ] Question

Version
Please specify what version of the library you are using: [ 2.0.0 ]
Expected / Desired Behavior / Question
Currently, PropertyFieldTermPicker allows you to choose if selecting term sets is possible, but there is no way to choose, if terms should be selectable or not. And in some cases, user needs to specify just the term set, not term.
I propose adding isTermSelectable property that would specify, whether individual terms could be selected.
If you find this enchancement useful, I'll be happy to work on this.

Hi @wilecoyotegenius,
Could you please describe your use-case a bit more? Do you actually want to see the terms but be unable to select them? Or you just want to see term sets, without terms?

@AJIXuMuK I was thinking about the latter - just seeing and being able to select term sets

@AJIXuMuK If you like the idea, I'd be happy to submit a PR for this.

Hi @wilecoyotegenius,
Feel free to submit a PR! I would probably implement two separate flags: one to disable terms selection and another to hide terms.


hdbscan on UMAP subspace

As the doc said "With a little care (documentation on how to be careful is coming) it partners well with the hdbscan clustering library"  I wonder is there  any updates about the little care  or quick answers how to use hdbscan to perform clustering on the UMAP subspace ?
Thanks in advance !

Docs are still a work in progress - -I've been diverted by a number of other things. You can look at issue #25 which has some discussion of what works and some of the potential pitfalls. Right now that's the best documentation there is.

Another follow-up question.
I had problems using hdbscan on my UMAP embedding, but I may be interpreting things wrong.
I colored all my clusters with a random color or red if hdbscan returned -1 (aka uncategorized). Here's an example output.

Once colored I was surprised to see:

the location of the uncategorized clusters
the mixed colors in number of locations

But, my understanding of UMAP is that the 2d representation that we see (if we asked for 2d), is the representation, and that clusters we see with our eyes are the clusters.
If that's true, and that's the big if, that I would really appreciate your input on.
If that's true, then I found that for my data, I needed to not use hdbscan to get clusters labeled in the way that I visually expect. I'm more than happy to share what I did, but would appreciate clarification on whether I'm understanding correctly.

That an intriguing result! I admit I don't entirely understand what has happened here. Are you clustering in high dimensional space and then coloring the embedding accordingly? If that's the case then something is astray indeed -- there is quite a cloud of points that were assigned to clusters but have been cast out by UMAP. I would love to have more details about what you did, and the data involved, because I feel like there is a failure case in the making here that I might need to investigate.
As to how to interpret things... UMAP isn't really a clustering algorithm, its more for dimension reduction, and it handles noise differently than something like HDBSCAN. In particular it will tend to pull noise in toward whatever is nearest. That means that if your data is not very noisy it can be effective, but for very noisy data it may not do entirely as one might expect. In contrast HDBSCAN is very conservative about noise, which can be problematic for high dimensional data where density is scarce and everything starts to look like noise.
Looking at your pictures here my feeling is that you have some number of clusters which UMAP clumped into tight little blobs, and a fair amount of noise which UMAP didn't really know what to do with and is generally just getting pushed away from (and squished between) the blobs.
I feel like I am not really answering your question well, but I feel like I am not understanding what is happening here either. If you can be patient with me and let me know if I'm on the right track I would appreciate it.

Thanks @lmcinnes for pointing me in the right direction offline. A datashaded view of my data shows the areas of density:

Here's the results colored by cluster label with HDBScan (default params) results (red is no cluster):

and here's scikit-learn's DBSCAN (default params):

In playing with this a lot more, I realized that HDBSCAN, for my data, is very sensitive to the parameters that you pass it. I need to figure out the right params for my use case, and decide whether excluding data, in the way that hdbscan is inclined to do by default is helpful for my needs.


Add UWP gamepad input polling

Add a basic UWP gamepad poll function with zero changes to code outside of App.cpp

Thank you very much for the update @SamNChiet! I'll review it carefully before integration on develop branch.


How to integrate plugin with Angular 9 Capacitor 2.0 project ?

I try to import the module into my typescript code however, typescript compiler is unable to find the module.

My team did manage to integrate this plugin with Angular9, Ionic and Capacitor. However the process is extremely manual and gets "broken" each time an npm install is executed (for example, in a CI/CD scenario).
The process is as follows:

instead of "ionic cordova plugin add cordova-plugin-msal....", justo do plain old "npm install --save cordova-plugin-msal"
open plugin.xml file in "./node_modules/cordova-plugin-msal"
replace $TENANTID, $CLIEND_ID and $KEY_HASH with the actual values (both for android and ios)
for Android, manually add the following activity inside

for iOS, add the following inside CFBundleURLTypes in info.plist

CFBundleTypeRole
Editor
CFBundleURLSchemes

msauth.io.ionic.starter

for iOS add the following and the following lines just before the closing  tags in info.plist
LSApplicationQueriesSchemes

msauthv2
msauthv3

As I said, this method works and we are able to signing to AAD. The downside is that for every "new" npm install, you need to repeat the process again.
If anyone has a better solution....
Regards, Ariel

Hey! Is there any update on that? Ariel, could you send me a picture of your plugin.xml file? Thanks!!


WebView state (cookies and etc.) always clear after reopen flutter page.

[x] I have read the README
[x] I have already searched for the same problem
[x] I have read and done the setup for Android: IMPORTANT Note for Android and iOS and IMPORTANT Note for Android
[x] I have read and done the setup for iOS: IMPORTANT Note for Android and iOS and IMPORTANT Note for iOS
[x] I have ran the sample app and it does not work there

Environment

Technology
Version

Flutter version

Plugin version

Android version

iOS version

Xcode version

Device information:
Description
Expected behavior:
Current behavior:
Steps to reproduce

This
Than that
Then

Images
Stacktrace/Logcat

Have you tried latest version? Unfortunately, without a sample code, I can’t help you.
You need to provide useful data e more context, otherwise it is impossible to me to help you


Module not found error

Rasa Core version: 12.2.2
Rasa NLU version: 0.13.8
Python version: 3.6
Operating system: Windows 10
Issue:
Please, I am trying to train the model in weatherbot tutorial and I am getting this error on CMD:
Traceback (most recent call last): File “nlu_model.py”, line 1, in from rasa_nlu.converters import load_data ModuleNotFoundError: No module named ‘rasa_nlu.converters’
Anything else I should inform here?
Content of domain file (if used & relevant):

Please ask usage questions in our forum https://forum.rasa.com.
I guess you need to install the right version of Rasa NLU for it since the tutorial uses an older version (0.11.4, https://github.com/JustinaPetr/Weatherbot_Tutorial/blob/master/Full Code/requirements.txt)


Glue implementation

Issue #, if available:
Description of changes:
Replaced spark support by AWS Glue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updated dependencies, replaced Spark by AWS Glue


skip http request on server

Describe the feature
while using await Store.fetch({ event }) on +page.server.ts, does this make a http request to server. If yes, then is there any way to bypass http request on server as this is not required when loading data from +page.server.ts load or actions (for mutations)
for reference: apollo's schema link
Criticality
None

If you pass the event it will use the same fetch as what you are given in load which should avoid performing an actual network request when fetching on the server

But isn't this still a http request? 🤔


mark 0.10.x releases as pre-release??

👋 according to this post, 0.10.x should be development releases, right? If that is the case, maybe you should consider marking all the 0.10.x releases as pre-release. Thanks!
also relates to https://github.com/Homebrew/homebrew-core/pull/128555

Maybe, but it's our decision. Thanks for your suggestion.


Accept ...core#resource as mixin's implies

Mixin 'applies' attributes should allow ...core#resource and ...core#link

This bug is not urgent to resolve.
Currently Cloud Designer already deals with it.

Should be fixed in https://github.com/erocci/erocci/commit/ccdcf95dddf53e4d437193adffc0dfbb38969e68
Can you check ?


Metric data is being altered

If you are reporting bug/issue, please provide detailed Repro instructions.
Repro Steps

Submit a metric with a metric property which is DateTime formatted like this "yyyy-MM-dd HH:mm:ss"

Actual Behavior
Value of metric property in AppInsights is "2017-11-24T18:35:01.0000000Z"
Expected Behavior
Metric property should be in this format "yyyy-MM-dd HH:mm:ss"
Version Info
SDK Version : 2.4
.NET Version :	 4.6.2
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) :
OS : VisualStudio
Hosting Info (IIS/Azure WebApps/ etc) : Azure

Need to investigate this with a small test app.
Need to confirm that custom formatting is transmitted in telemetryitem (Fiddler).
We suspect that our backend is parsing this string and storing as a datetime.
If confirmed, we would need to look into changing that.
Work-around is to format your datetime at query time.

@MS-TimothyMothra were you able to repro this?


Call toString() on user objects to help with debugging

This is a feature request, based on an idea from Visual Studio.
In the image below I've shown the same set of objects in VS and FD. As you can see the VS debugging view is very friendly and makes complex object hierarchies easy to understand.

So how does it work? The VS debugger calls ToString() on objects to show developer-provided text in the debug panels, like [Image 64x128]. Only if the object does not support this, then it uses a default rendering like [Image].
The image above uses the following C# code:
internal class TestImage {

	public int Height;
	public int Width;

	public override string ToString() {
		return "[Image " + Width + "x" + Height + " in RGB]";
	}
}

Can we have a similar feature in FlashDevelop?
What I propose : FD debugger should try to call "toString()" on the class object if the method exists. If the method does not exist, then it should fallback to the default rendering.

How it should work for that code?
class Foo {
	public function new() {}

	var i:Int = 0;

	public function toString():String {
		return "[Foo, i: " + (i++) + "]";
	}
}

Obviously it will execute the function many more times than required. It would appear wrong but at least in genuine use cases it would work properly!

Flash debugger is not the nicest thing out there... I think this would bring extreme performance problems for some cases. There is for example issue #181 and this would make things even worse.
This is fully possible, of course, and could be enabled with a setting.


Support for Java 21

I know it's just been a week since java 21 released, but I would like to ask if there is already a rough ETA on support for graalvm21 native image?
Thanks in advance.

Looking forward eagerly.


Needed an icon for CO2 Emission

Describe the requested icon(s)

References

Additional context

Please fill out the required fields in the issue template.


Coco caption pertained model output results are not good

Hello,
    Thank you for your great works!

    I used your pertained model for coco image captioning. Here is the command I used.

   python oscar/run_captioning.py \
--do_test \
--do_eval \
--test_yaml test.yaml \
--per_gpu_eval_batch_size 64 \
--num_beams 5 \
--max_gen_length 20 \
--eval_model_dir image_caption/Oscarrepo/Oscar/checkpoint-29-132780/

where checkpoint-29-132780 is uncompressed pertained coco model folder. But the outputs are not good.
 Thank you for your help!
Also, where is the test.yaml. Thanks

Also, where is the test.yaml. Thanks

test.yaml is from the dataset coco_caption folder. We have it in the DOWNLOAD page.
How do you generate the caption if you do not have our dataset? If you use your extracted features and labels, the results might be undesirable because of the feature/label mismatch.

Currently, I change the path to text.yaml. But the results are still the
same, I use the dataset downloaded from your github. Do I missed some
important steps? Thank you!
Xi Yin<EMAIL_ADDRESS>于2020年7月15日周三 上午12:49写道：

test.yaml is from the dataset coco_caption folder. We have it in the
DOWNLOAD page.
How do you generate the caption if you do not have our dataset? If you use
your extracted features and labels, the results might be undesirable
because of the feature/label mismatch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/Oscar/issues/21#issuecomment-658543716, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AO52GU2UZWRWCXPGK5BOA23R3UYOTANCNFSM4OZ2T6HQ
.

Hi, I just checked it again on my side and I am able to get good results. I think you probably have used the wrong checkpoint. For image captioning model, after you unzip it, the model path is "checkpoint-29-66420".
In your command, you write "checkpoint-29-132780", looks liked you have used the model trained from a different task for image captioning task. So the results are random.

Great, thank you!
Xi Yin<EMAIL_ADDRESS>于2020年7月15日周三 下午6:05写道：

Hi, I just checked it again on my side and I am able to get good results.
I think you probably have used the wrong checkpoint. For image captioning
model, after you unzip it, the model path is "checkpoint-29-66420".
In your command, you write "checkpoint-29-132780", looks liked you have
used the model trained from a different task for image captioning task. So
the results are random.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/Oscar/issues/21#issuecomment-659038801, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AO52GU5ZDMWLTPBIU2QO2A3R3YRZ7ANCNFSM4OZ2T6HQ
.

@xiyinmsu Hi, I meet the same problem, the result is like:
marcia marcia発発発発発発発発発発 haitian haitian haitian corruptionyo southend
traps factual mosque བ བ བ བyo pat hypotheticalyo trapsyo traps hyper चyo southend
corruption marian marian བ བ བ བ marian marian lionsyo parryyo parry hyper wilburyo原
mechanisms mechanisms mechanisms wilkes mechanisms declares declares declares declares declares declares declares declaresfrey horriblyyo patク
blond marcia marcia challenged marcia marcia marcia marcia marcia marcia marcia marciachus marcia vishnuyo patク
marcia marcia pietro ri parry pat noiseco faust develops พ พ พ melee melee melee marian daggers
faust faust発発 lax lax accountant hardly dripped lax traps – lax hyper hardly travelyo pat
rendezvous marcia pietro pietro ri parry patク ara pat hypotheticalfreyyo parry detail daggers epilogue epilogue
But I do use the "checkpoint-29-66420".

@xiyinmsu  I also use "checkpoint-29-66420" for my own images. I extracted the feature using bottom-up-attention. But the result is somewhat weird. Is there anything I can do to get a better result. I also tested the same images with other models trained on coco and I got a decent captions but for Oscar the result looks like this:
konstantin konstantin konstantin konstantin konstantin ymca ymca ymca ymca ymca ymca konstantin konstantin konstantin konstantincha konstantin konstantin
ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymcaunds ymca ymca
complexion brad complexion complexion complexion complexion brad complexion complexion complexion complexion complexion complexion brad brad antenna antenna recently
bringing ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca ymca departmental ymca ymca
brad brad brad brad brad brad brad brad brad brad brad brad complexion brad brad\u10d1 brad brad
comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise\u10d1 comprise\u10d1
comprise comprise comprise comprise comprise planetary comprise comprise comprise comprise comprise comprise comprise comprise comprise winters comprise comprise
comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise comprise compriselogists comprise comprise
Is there anything that I can do to get a good caption(atleast a reasonable sentence)?

got bad result when predicting #140

Have you solved it?

Have you solved it?

@xiyinmsu Hi, I meet the same problem, the result is like:
marcia marcia発発発発発発発発発発 haitian haitian haitian corruptionyo southend traps factual mosque བ བ བ བyo pat hypotheticalyo trapsyo traps hyper चyo southend corruption marian marian བ བ བ བ marian marian lionsyo parryyo parry hyper wilburyo原 mechanisms mechanisms mechanisms wilkes mechanisms declares declares declares declares declares declares declares declaresfrey horriblyyo patク blond marcia marcia challenged marcia marcia marcia marcia marcia marcia marcia marciachus marcia vishnuyo patク marcia marcia pietro ri parry pat noiseco faust develops พ พ พ melee melee melee marian daggers faust faust発発 lax lax accountant hardly dripped lax traps – lax hyper hardly travelyo pat rendezvous marcia pietro pietro ri parry patク ara pat hypotheticalfreyyo parry detail daggers epilogue epilogue
But I do use the "checkpoint-29-66420".

Have you solved it?


[WIP] Meta devices support

Support for meta devices for deployment with little RAM.

Memory efficient dispatch
To normally create and dispatch a tensor_parallel model one need whole model in memory. This can be troublesome6 but there is another way.
It's possible to create a tensor_parallel on a machine with enought RAM, save it preserving distributed state and then reuse the save files to dispach model shards straight to GPUs on any other machine.
The code to save distributed state should look like this:
import transformers
import tensor_parallel as tp
RAM_LIMIT = "6GB" # we want to deploy the model on machines with as little as 6GB of RAM
model = tp.TensorParallelPreTrainedModel(
    transformers.AutoModelForCausalLM.from_pretrained("facebook/opt-13b"),
    device_ids=["cpu", "cpu"] # split model but load into RAM
)
model.set_preserve_shards_when_saving(True)
model.save_pretrained("opt-13b-tensor-parallel", max_shard_size=RAM_USAGE_LIMIT) # save model's distributed state

It normally produces many files containing model weights as well as model index. Those files then can be put on a machine for training/inference and loaded as follows:
import transformers
import tensor_parallel as tp
from accelerate import init_empty_weights
# Initialize a weightless model
with init_empty_weights():
    model = tp.TensorParallelPreTrainedModel(
        transformers.AutoModelForCausalLM.from_config(
            AutoConfig.from_pretrained("facebook/opt-13b")
        ),
        device_ids=["meta", "meta"] # and prepare it to be put on two devices
    )
# Incrementally load the distributed
tp.load_and_dispatch_separate_shards(  state
  model,
  checkpoint="opt-13b-tensor-parallel/pytorch_model.bin.index.json",
  device_ids=[0, 1] # and put it on GPUs 0 and 1
)

Max RAM consumption of such loading is max_shard_size which in this example was set to 6GB.


completion.py consumes a lot of CPU (95-100%). Find References also not working

Hi
The vscode 1.43.1, the "Find all Reference" does not work and I can see that the completion.py consumes a lot of CPU and "Find All Reference" window remains empty.
Also when I hover on any symbol, instead of highlighting information, it shows a popup with "Loading" constantly.

VSCode Version: 1.43.1
OS Version: Ubuntu 18.04 64Bit

Version: 1.43.1
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:17:38.324Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.3.0-42-generic
Steps to Reproduce:

Open code and "Find All References" for any symbol

Does this issue occur when all extensions are disabled?: Yes/No
This Reference feature in Right Click does not appear with all extensions disabled

/causedByExtension

Is "Find Reference", Symbols Peeking not an VScode implementation?
How can I find the extension which is doing this?

Language features (like go to definition, find all references, etc) are provided by the language extensions. In this case likely the Python extension.


Upgrade NetInfo for iOS

Description
I'm using an iPhone 5S and i have a problem.
Everytime I want to know the network if it's connected to internet or not.
NetInfo returns me "unknown", the same happens when i'm not connected, connected, not connected with SIM card and connected with SIM card.
There is no problem on Android.
Reproduction
Use NetInfo on an iPhone 5S at least.
Maybe there is the same problem on others.
Solution
Upgrade NetInfo or add something to Xcode to know the network?
Additional Information

React Native version: 0.42
Platform: iOS 5S
Operating System: MacOS

Getting false on iOS simulator & iPhone 6 10.3, when isConnected should return true.

@MattyK14 I assume your issue is the same as https://github.com/facebook/react-native/issues/8615, not clear if @yolosaucisson's issue is the same or different becuase it's returning unknown instead of false.

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


Fixing tau issue

Closes #563

I think some additional documentation in both ACSModeledSegment and ACSModeledSegmentUtils on the definition of tau would prevent future confusion.

some minor comments, back to you @LeeTL1220

Oh, also, are we sure that everything is kosher with sigmaTau?

I confirmed a long time ago that sigmaTau is okay.  This was an issue with forgetting to specify the value in log2 space.

OK, good to squash and merge!

Answered issues.  Back to you @samuelklee


Add tracing throughout the toolchain

Tracing is useful for debugging problems both "in the wild" and during development time. Adding detailed tracing in the compiler, language service, and associated tools will improve Draco's debuggability as components become more complex and are used outside the debugger more often.

[ ] Select a tracing library and come up with a pattern to follow in code
[ ] Add tracing to important components in the toolchain (binding, emit, LSP, etc.)
[ ] Wire up traces to output sinks & provide ways to filter output (debug output, IDE logs)

Do we want to do a distinction between tracing and logging ?
I never used it, but Serilog looks like the most used library for logging.


Valid Sudoku

Determine if a 9 x 9 Sudoku board is valid. Only the filled cells need to be validated according to the following rules:
Each row must contain the digits 1-9 without repetition.
Each column must contain the digits 1-9 without repetition.
Each of the nine 3 x 3 sub-boxes of the grid must contain the digits 1-9 without repetition.
Note:
A Sudoku board (partially filled) could be valid but is not necessarily solvable.
Only the filled cells need to be validated according to the mentioned rules.
Example 1:

Input: board =
[["5","3",".",".","7",".",".",".","."]
,["6",".",".","1","9","5",".",".","."]
,[".","9","8",".",".",".",".","6","."]
,["8",".",".",".","6",".",".",".","3"]
,["4",".",".","8",".","3",".",".","1"]
,["7",".",".",".","2",".",".",".","6"]
,[".","6",".",".",".",".","2","8","."]
,[".",".",".","4","1","9",".",".","5"]
,[".",".",".",".","8",".",".","7","9"]]
Output: true
Example 2:
Input: board =
[["8","3",".",".","7",".",".",".","."]
,["6",".",".","1","9","5",".",".","."]
,[".","9","8",".",".",".",".","6","."]
,["8",".",".",".","6",".",".",".","3"]
,["4",".",".","8",".","3",".",".","1"]
,["7",".",".",".","2",".",".",".","6"]
,[".","6",".",".",".",".","2","8","."]
,[".",".",".","4","1","9",".",".","5"]
,[".",".",".",".","8",".",".","7","9"]]
Output: false
Explanation: Same as Example 1, except with the 5 in the top left corner being modified to 8. Since there are two 8's in the top left 3x3 sub-box, it is invalid.
Constraints:
board.length == 9
board[i].length == 9
board[i][j] is a digit 1-9 or '.'.

Yes you can. Upload your solution in the "Solutions" folder. Deadline is 22 March'23, 11:59pm

Di I have completed the solution but I have difficulty in uploading it on
github.
On Mon, 20 Mar 2023 at 22:00, Krushna @.***> wrote:

Assigned #57
https://github.com/Mozilla-Campus-Club-Cummins/Spring-of-Code/issues/57
to @PiyushaGhodake https://github.com/PiyushaGhodake.
—
Reply to this email directly, view it on GitHub
https://github.com/Mozilla-Campus-Club-Cummins/Spring-of-Code/issues/57#event-8796813745,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZFFKIU7LJXKJNATI2M25UTW5CAZ3ANCNFSM6AAAAAAV7M3U5E
.
You are receiving this because you were assigned.Message ID:
<Mozilla-Campus-Club-Cummins/Spring-of-Code/issue/57/issue_event/8796813745
@github.com>

@Krush2311 I have uploaded my solution. Can u check it and merge?


DOC: Improve circular stats doc

[skip azp] [skip actions]
What does this implement/fix?
Adds explanatory plots to circvar and circstd functions to make their meaning more clear.
Additionally, a missing space in the References section of circvar is fixed:
Current docs:

Thank you @dschmitz89 this really makes it clearer!
Putting this here as I see it. Other improvements for follow ups we could do: add some more text, a general description of all these methods and more seealso now and there later.

Would be happy to help writing this. Where would it go? New section in the general stats tutorial?

Great thanks. I am not sure about tutorials because we are having some talks about the possibility to move these to notebooks and another repo etc. @melissawm what would be your suggestion here?


Database v2

I added the listing, but individual details dont work right. Wanted to push this here now so that we don't code into different directions.

Description
Several features to UI:

new molecule can be added
new algorithm:type can be added
new algorithm can be added
public algorithms are listed in main page
algorithm details can be viewed by clicking algorithm name in listing

How to test:

add few molecylues
add few algorithm types
add few algorithms
view details of public algorithms
view details of users algorithms

Description
Several features to UI:

new molecule can be added
new algorithm:type can be added
new algorithm can be added
public algorithms are listed in main page
algorithm details can be viewed by clicking algorithm name in listing

How to test:

add few molecylues
add few algorithm types
add few algorithms
view details of public algorithms
view details of users algorithms

Huge error message when fired from Docker, after signup and login.
Pasting the html-error file to Slack

These work:

add few molecylues
add few algorithm types
add few algorithms
view details of public algorithms
view details of users algorithms

merging.


Use cartopy_offlinedata

Use cartopy_offlinedata to fix bug where Tropical Cyclone images don't show up. Resolves #520.

[ ] After this merges, follow the steps at https://e3sm-project.github.io/e3sm_diags/_build/html/master/dev_guide/testing.html#complete-run-test to update the expected images for the complete_runtest

Thank you for the PR. I tagged @xylar for reviewing as well.
I haven't had to use --no-verify issue when committing. Not sure if it is LCRC specific ...

@forsyth2 @chengzhuzhang
The zppy and zstash dev envs (both Python 3.7.10) run pre-commit fine on LCRC.
The error below that is outputted through pre-commit seems to be specific to LCRC servers and Python 3.9 in thee3sm_dev environment. I reinstalled the latest version of the e3sm_diags dev env on LCRC, but it outputs the same error.
BlockingIOError: [Errno 11] Resource temporarily unavailable: '/gpfs/fs1/home/ac.tvo/.local/share/virtualenv/wheel/3.9/image/1/CopyPipInstall/pip-21.1.2-py3-none-any/pip/_vendor/distlib/w32.exe' -> '/gpfs/fs1/home/ac.tvo/.cache/pre-commit/repo7v9o5q3a/py_env-python3.9/lib/python3.9/site-packages/pip/_vendor/distlib/w32.exe'

Also, I tested the latest dev environment on my local machine and it works fine.
What I suggest for now:

Open an issue to further investigate this error and/or open up an issue directly on https://github.com/pre-commit/pre-commit
Perform dev locally to pre-commit run, then pull those changes to test on LCRC, or use no-verify and fix the pre-commit errors that appear in the GH Actions build.

Opened up an issue to address the LCRC + pre-commit issue here: https://github.com/E3SM-Project/e3sm_diags/issues/526

@tomvothecoder, I believe I've seen issues like that frequently on Chrysalis.  It seems to have to do with recent versions of python and that file system.  We ended up having to use slow file copying as a fallback on Chrysalis in MPAS-Analysis because of this.


always "got away while using ItemPokeBall"

[11:46:06] This bot is absolutely free and open-source!
[11:46:06] If you've paid for it. Request a chargeback immediately!
[11:46:06] Starting Execute on login server: Google
[11:46:06] Altidude was 0, resolved that. New Altidude is now: 10,221896104894
[11:46:11] Export Player Infos and all Pokemon to "\Config\PokemonList.csv"
[11:46:13] -----------------------[PLAYER STATS UPDATE]-----------------------
[11:46:13] Level/EXP: 24 | 83.750/150.000 (55,83%) | EXP to Level up: 66250
[11:46:13] PokeStops visited: 2092 | KM Walked: 116,54
[11:46:13] Pokemon: 80 + 9 Eggs /250 (28 Evolvable)
[11:46:13] Pokedex Completion: 69/150 [46%]
[11:46:14] Items: 229/350 | Stardust: 159.306
[11:46:17] Egg (5km) need to walk 4,63 km.
[11:46:19] Recycled 10x ItemPokeBall
[11:46:20] Recycled 2x ItemHyperPotion
[11:46:20] Recycled 1x ItemRevive
[11:46:21] We found 19 usable PokeStops near your current location.
[11:46:22] Next Pokestop: Kraaiennest Kijkduin  in 8,41m distance.
[11:46:22] Distance to target location: 8,41 meters. Will take 1,78 seconds!
[11:46:23] We are within 40 meters of the target. Slowing down to ~10 km/h to not pass the target.
[11:46:25] Farmed XP: 50, Items: 1 x ItemGreatBall, 2 x ItemPokeBall
[11:46:27] Next Pokestop: Kijkduin Carousel in 29,55m distance.
[11:46:27] Distance to target location: 29,55 meters. Will take 15,2 seconds!
[11:46:28] Found 3 catchable Pokemon(s).
[11:46:29] Encountered Abra CP 346  IV 58,86% Probability 31%
[11:46:33] Thrown ItemRazzBerry. Remaining: 62.
[11:46:34] Abra CP 346 IV 58,86% got away while using ItemPokeBall..
[11:46:36] Encountered Rattata CP 178  IV 40,49% Probability 42%
[11:46:37] Rattata CP 178 IV 40,49% got away while using ItemPokeBall..
[11:46:41] Encountered Voltorb CP 203  IV 38,01% Probability 47%
[11:46:42] Voltorb CP 203 IV 38,01% got away while using ItemPokeBall..
[11:46:45] Farmed XP: 50, Items: 3 x ItemPokeBall
[11:46:48] -----------------------[PLAYER STATS UPDATE]-----------------------
[11:46:48] Level/EXP: 24 | 83.925/150.000 (55,95%) | EXP to Level up: 66075
[11:46:48] PokeStops visited: 2094 | KM Walked: 116,54
[11:46:49] Pokemon: 80 + 9 Eggs /250 (28 Evolvable)
[11:46:49] Pokedex Completion: 69/150 [46%]
[11:46:49] Items: 229/350 | Stardust: 159.306
[11:46:52] Egg (5km) need to walk 4,63 km.
[11:46:53] Next Pokestop: Kijkduin Vuurtoren in 43,72m distance.
[11:46:53] Distance to target location: 43,72 meters. Will take 12,11 seconds!
[11:46:56] We are within 40 meters of the target. Slowing down to ~10 km/h to not pass the target.
[11:47:02] Farmed XP: 50, Items: 1 x ItemGreatBall, 2 x ItemPokeBall, 1 x ItemRazzBerry
[11:47:02] Found 1 catchable Pokemon(s).
[11:47:04] Encountered Magnemite CP 308  IV 73,76% Probability 42%
[11:47:04] Magnemite CP 308 IV 73,76% got away while using ItemPokeBall..
[11:47:07] Next Pokestop: Vakantieganger in 36,98m distance.
[11:47:07] Distance to target location: 36,98 meters. Will take 7,4 seconds!
[11:47:07] We are within 40 meters of the target. Slowing down to ~10 km/h to not pass the target.
[11:47:08] Found 1 catchable Pokemon(s).
[11:47:10] Encountered Voltorb CP 416  IV 64,36% Probability 34%
[11:47:14] Thrown ItemRazzBerry. Remaining: 62.
[11:47:15] Voltorb CP 416 IV 64,36% got away while using ItemPokeBall..
[11:47:20] Farmed XP: 100, Items: 1 x ItemUltraBall, 3 x ItemPokeBall, 1 x ItemRazzBerry, 1 x ItemHyperPotion
[11:47:24] -----------------------[PLAYER STATS UPDATE]-----------------------
[11:47:24] Level/EXP: 24 | 84.125/150.000 (56,08%) | EXP to Level up: 65875
[11:47:24] PokeStops visited: 2096 | KM Walked: 116,58
[11:47:24] Pokemon: 80 + 9 Eggs /250 (28 Evolvable)
[11:47:24] Pokedex Completion: 69/150 [46%]
[11:47:25] Items: 229/350 | Stardust: 159.306
[11:47:27] Egg (5km) need to walk 4,59 km.
[11:47:29] Next Pokestop: Glowing Sun on a Wall in 64,18m distance.
[11:47:29] Distance to target location: 64,18 meters. Will take 19,25 seconds!
[11:47:36] Found 1 catchable Pokemon(s).
[11:47:37] Encountered Rattata CP 114  IV 55,18% Probability 53%
[11:47:38] Rattata CP 114 IV 55,18% got away while using ItemPokeBall..
[11:47:42] We are within 40 meters of the target. Slowing down to ~10 km/h to not pass the target.
[11:47:43] Farmed XP: 50, Items: 1 x ItemPotion, 1 x ItemPokeBall, 1 x ItemRazzBerry
[11:47:44] Next Pokestop: Widerstandsnest 67 HL in 94,7m distance.
[11:47:44] Distance to target location: 94,7 meters. Will take 30,99 seconds!

[11:46:06] This bot is absolutely free and open-source!
[11:46:06] If you've paid for it. Request a chargeback immediately!

Wrong bot


Fix IncludeWorkflow sources copy

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is 60%.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   82.57%   82.57%
=======================================
  Files          23       23
  Lines        1750     1750
=======================================
  Hits         1445     1445
  Misses        225      225
  Partials       80       80

Impacted Files
Coverage Δ

daisy/workflow/step_includeworkflow.go
80.39% <60%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a5071...bb407a0. Read the comment docs.


FABRIC Examples: hello_fabric.ipynb: broken link

I believe the "Hello FABRIC!" example has a broken link to the "Configure Environment" notebook.
When viewed here:
https://github.com/fabric-testbed/jupyter-examples/blob/master/fabric_examples/fablib_api/hello_fabric/hello_fabric.ipynb
In Step 1, the anchor text "Configure Environment" links to:
https://github.com/fabric-testbed/jupyter-examples/blob/073e88a61906782d838a81d2e0a64d7fef010f56/fabric_examples/fablib_api/hello_fabric/configure_environment.ipynb
But that destination is 404. (At least when I click the link when viewing the notebook at GitHub, via Firefox. I did not try actually running the notebook.)

Related: The link to the "Configure Environment" Jupyter notebook on this page:
https://learn.fabric-testbed.net/knowledge-base/tutorials/
...is broken. It points to:
https://github.com/fabric-testbed/jupyter-examples/blob/master/fabric_examples/fablib_api/configure_environment/configure_environment.ipynb
...which is 404.


Assign multiple testers to single test case?

What about where you want to assign multiple testers to a single test case ? The only way I can see to do this is assigning users to the entire suite and then deleting test points as they're not needed - very manual process - there has to be a better solution?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cf72265-156c-de8c-d729-ba7b3b90193d
Version Independent ID: 1a0c7272-6d36-6036-06cf-5801b55e2f70
Content: Create manual tests - Azure Test Plans
Content Source: docs/test/create-test-cases.md
Product: devops
Technology: devops-test
GitHub Login: @steved0x
Microsoft Alias: sdanie

@barrydurcan - Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Please consider these resources:

Azure DevOps Services
Azure DevOps Support Bot
Azure DevOps on Stack Overflow

You might want to make a feature request - the product teams aren’t always watching this repository, so to make sure it gets in front of them for triage, please submit your idea here.
If there are documentation fixes for us to make, we can re-open this item.


Setup codebase

Detail
setup basic codebase for rust alternative aria-query
I made aria_query workspace with rust, license, README, GHA workflow to check rust's codebase as I refered https://github.com/oxc-project/oxc

By the way, What should I deal with this aria-qeury's code review? I have some plans.

I will make a pull request and merge it into main without review, and only if I want a review from the team I will send a review request

for example, when I need some discussion about library's I/O, license and code architecture

I will make a pull request and merge it into develop branch without review, and I will make a pull request from develop to main when I finish implementing aria-query
I will make a pull request and send a review request each time

Perhaps, if there is someone compatible for reviewer, please tell me 🙇

I will make a pull request and merge it into main without review, and only if I want a review from the team I will send a review request
for example, when I need some discussion about library's I/O, license and code architecture

Let's start with this work flow, let's iterate fast and ship fast.
Rules and policies are documented here https://oxc-project.github.io/docs/contribute/rules.html for reference.

ok sure, thank vou!


⚠ Bofrost.at has degraded performance

In c0ac514, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3881 ms

Resolved: Bofrost.at performance has improved in abea06a.


refactor tag_languages

still todo:

[ ] make tag_filter_spec.rb:71 passing
[x] undo migration that dropped tag_languages
[ ] create fake languages
[ ] write rake task to migrate data from tag_languages to locale_languages
[ ] push to staging
[ ] push to production

done \o/


routes now work to create prof and login. need to edit js filels

finished fixing routes, need to edit js files


Changes around context expiration naming and types

This would unblock #2010.
Closes #2032.
Closes #1880.
I know this comes out of the blue, but it seems to me the right change to do. This is a proposal, let me know what you think.
First, I started with the fact that we need to make CancelWhen() public.
Then, I realized that I don't like the CancelWhen() naming. CancelAt() is better?
But CancelAt() sounds like an order to do something, not as getter.
So, it should be named Get.... GetCancelWhen()? GetCancelAt()? Sounds strage.
GetDeadline() - not bad, bit it is not that clear, what the deadline is.
And I looked at the WithDeadline() method. And in comment, the first line is @brief Create a context with expiration..
"Expiration" sounds better explanation for the essense of the "deadline".
So, I went with GetExpiration(). I think "Expiration" is also a better name, because should we want to add the method called "bool IsExpired()", it comes naturally using the existing terminology, sounds better than "IsPastDeadline()".
Next thing - if we have "GetExpiration()", it is strange to have a method called Get(). So, we have WithExpiration() and WithValue(). So, it sounds like the getter should be called GetValue(). I did that rename as well.
Then, I looked at "With..." method naming. It is a factory method. If for getters we have Get, then for factory methods we should have Create. So, I renamed WithExpiration() and WithValue() to CreateWithExpiration() and CreateWithValue().
Then I looked at Context::time_point typedef. First, in general, if we can avoid public typedefs, it is better, because we don't need to document them and worry if we broke client code when we change them.
Second, it is strange that we use Azure::DateTime everywhere, but not in context.
So, I replaced it with Azure::DateTime. It is good because it allows us to drop to/from epoch conversions (#1880), and really all that extra dance we do to cast to representation and back to datetime is the ways to stay within legal type casting limits of compiler type declaration, while in reality there isn't much that is happening in the code: DateTime is essentially an int64, and with all these conversions to epoch time, then to representation and back, compiler does not generate real code, it still operates with that only int64.
Why we cast to DateTime::rep and back at all? Context stores it as atomic, and I am not questioning that. You can't get std::atomic<DateTime> today explicitly, so we "extract" representation (int64) and store it as std::atomic<DateTime::rep>, which is the same thing as std::atomic_int64.
-- Update: --

"Expiration" => "Deadline" (Jeffrey's request)
Added Context::HasExpiration() (response to Jinming) // plus, we do have HasValue() so why not have HasDeadline().
WithDeadline(), WithValue => Two overloads of CreateChildContext() (my own initiative).

Do we have an reliable way to check if expiration is set/unset?
Before this PR, we use timepoint::max() and convert it to milliseconds. There's a problem with this method. Sub-milliseconds are discarded.

@JeffreyRichter , I'll rename Expiration to Deadline as you are suggesting.
What do you think if instead of two methods CreateWithDeadline() and CreateWithValue(), we create two overloads (taking timestamp or key-value) named CreateChildContext()?

@Jinming-Hu, in response to your question, see HasExpiration(). Would it help you?
@JeffreyRichter, I renamed "Expiration" to "Deadline", and put a comment explaining walking the tree / DateTime::max() as you suggested.
Plus, I renamed WithDeadline() and WithValue to tow overloads of CreateChildContext().

The benefit of having named factory methods, especially using Deadline is that it ties the scenario of cancellation to context and makes it clearer that Context can be used for that. We even observed this in the usability studies, where the API became self-documenting, and the person, just by method names could infer what they could do with the type.
The WithDeadLine and WithValue methods also match with golang's prior art:
https://golang.org/pkg/context/#example_WithDeadline
Therefore, we should leave the API name as is, in this case, rather than overloading it with a generic name.

I agree, please leave the method names as they were.


Mobile Safari latest bug

As reported by @cmdv.
ios 9.2

I can reproduce this in my iOS emulator, from looking through the flex bugs repo it seems like I might just need to put a flex-basis on everything.

Ah sweet totally forgot to look into this!! Apple are becoming the new Microsoft!


Add Integration Tests

Coverage: 85.2% (+0.3%) from 84.865% when pulling 2251a545f6c8cae21711fc3606d0f8515106f1f6 on integration into 9ef3191defad38974791a39dcd2cb6e7b9199f9b on main.


On the interaction of data

Can the generated page generate the corresponding data format at the same time, such as Ajax or JSON format。
I am now trying to write a front-end code generation system. The problem I am facing now is how to make the generated front-end page automatically generate the corresponding interactive data format
生成的页面能否同时生成相应的数据格式，如Ajax或JSON格式
我现在在尝试编写一个前端代码生成系统，我现在面临的问题就是如何让生成的前端页面自动生成相对应的交互数据格式

such as Ajax or JSON format

I suggest you to use fetch as it's a better alternative.

This seems unrelated to Bootstrap.


Python: Milvus memory connector

This change brings in Milvus to the semantic kernel connectors.

@fzliu

@microsoft-github-policy-service agree company="Zilliz"

@filip-halt Following up on your offline note. Looks like it's already assigned for review.
@alexchaomander for visibility.

Hi @filip-halt the code looks good, but I'm hitting errors with the integration tests where the default server is refusing to start due to communication timeouts. I'm seeing the issue standalone as well. I'm not sure if it's just a me problem, or if there's a bug with the default server - this wasn't an issue for me last week. Are you able to run these locally today?

I would also like to know what kind of error is being seen? I just tested locally and everything seems to be running fine. Did the error happen on a first runthrough or after a few?

I would also like to know what kind of error is being seen? I just tested locally and everything seems to be running fine. Did the error happen on a first runthrough or after a few?

Hmmm my machine might be in a bad state. I'll have someone else test locally.
I don't believe I had the errors on the first runthrough, but definitely every run after that.

all from the default_server.start() call.

@awharrison-28  I put the call to preclean the service before running. This might help with your errors.


Why the -rg in the end of the RG name?

We're having a hard time convincing customers that they shouldnt name their RG's "-rg".
We think it is not needed, as you can always see it is an RG, and we don't want to have in on each as it just wastes space and looks "weird"
We think that it should be removed from these guidelines, if not, we would love to know why it is recommended, as, from our point of view, it does not make sense.
best regards
Jakob

OPS Build status updates of commit f10be94:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/best-practices/naming-conventions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

The general recommendation in that article is for resource names to indicate the "what" (VM, storage, etc), so that you can tell from the name what type of resource it is. RGs are a type of resource, hence "-rg". That said, the higher-level point is just to have a consistent naming convention.

@MikeWasson  - ah yes you are right. I dont understand that though. It gives a very incosistant naming, unless you have a list of shortnames/abriviations for each type of resource.
example:
a Web App
myLittleSite-WebApp-prd
myLittlesite-AppService-prd
MyLittleSite-Web-prd
also some resources like storage account doesnt support dash, so it make it more inconsistant.
mylittlesitesstorageaccountprd
something like that :)
then add to that, the maximum length of names too.
I opened this PR to start a disucssion as we are having a hard time getting the customers to follow our guidelines, because of this article.
I just want to know why we should use the resource type in the name, as I dont see any situations where it is an advantage :)

@JakobGSvendsen : Thanks for your contribution! The author, @telmosampaio, has been notified to review your proposed change.

@MikeWasson - I've assigned this PR to you, mainly because I am unable to assign the listed article author @telmosampaio . This is most likely because @telmosampaio hasn't joined this repo. Can you reassign it or provide specific guidance for this PR.

#sign-off if it's ready to merge
#hold-off if it requires changes before it's ready for sign off
#please-close - if these changes aren't going to be merged

Thanks!

We want to keep the current guidance. As mentioned, these guidelines are suggestions.
#please-close


Add asomers as author

Is this ok? If yes, which email should I put there?

You can use<EMAIL_ADDRESS>for me.


refactor(components): modularize BoardName from Board

Codecov Report

Merging #565 (3c109c1) into master (800a41e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #565   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           73        74    +1
  Lines          782       784    +2
  Branches       119       118    -1
=========================================
+ Hits           782       784    +2

Impacted Files
Coverage Δ

src/components/Board/Board.tsx
100.00% <ø> (ø)

src/components/Board/BoardName.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800a41e...3c109c1. Read the comment docs.


As a client I want my customers to be able to change their address on the account page

Describe the bug
When the MyParcel plugin is activated the customers are not able to change their address on the account page. When the MyParcel plugin is deactivated this issue does not occur.
Steps to reproduce this behaviour

Go to 'My Account'
Click on 'Address'
Edit the country of an address
Nothing happens

Expected behaviour
The country should be selected
Screenshots

@TimBlom This problem is related to the MyParcel address fields. Once this setting is on, it is not possible to change the country. As soon as the MyParcel address fields are turned off, it will work

This issue also occurs by changing the region.


[type: refactor] refactor password logic.

With pull requests:

Open your pull request against main
Your pull request should have no more than two commits, if not you should squash them.
You should pass all tests by go test -v ./... at the project root path in local.
It should pass all tests in the available continuous integration systems such as GitHub Actions.
You should add/modify tests to cover your proposed code changes.
If your pull request contains a new feature, please document it on the README.

Codecov Report

Merging #90 (0998875) into main (d9a3b30) will decrease coverage by 34.56%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #90       +/-   ##
===========================================
- Coverage   68.78%   34.21%   -34.57%
===========================================
  Files           9       13        +4
  Lines         205      415      +210
===========================================
+ Hits          141      142        +1
- Misses         48      257      +209
  Partials       16       16

Impacted Files
Coverage Δ

internal/core/openapi/password.go
100.00% <100.00%> (ø)

internal/core/openapi/openapi.go
0.00% <0.00%> (ø)

internal/core/openapi/auth.go
0.00% <0.00%> (ø)

internal/core/openapi/context.go
0.00% <0.00%> (ø)

internal/core/openapi/dictionary.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a3b30...0998875. Read the comment docs.


Porting app folder to TypeScript

[x] I have searched the issues of this repo and believe that this is not a duplicate

Issue
Now that #3816 is merged. Files in lib folder (renderer) can be ported to TypeScript.
I want some suggestions and help on porting the app folder. I have explored two approaches

Transpile files and copy assets from app to a new folder compiled_app and use that to run and build hyper - #3837
Transpile TS files in the app folder itself  - #3838

(tsc on file change in approach 2 not working at the moment, despite similar configuration to approach 1)
(need to configure eslint to ignore the generated files in both branches)
Please suggest any other approach that might be useful and any improvements on the above two.

If option 2 doesn't introduce breaking change. I would go with migrating file as they are. no need for duplication.

Could reuse the dist folder for 1)?

I commented on your 1 PR. instead of compiled_app/ rename it target/

Could reuse the dist folder for 1)?

There would already be some things in there on building, so decided against using it.

Which approach do similar apps like Terminus or FluentTerminal use?

Terminus is using awesome-ts-loader with webpack to convert the ts files to js in a dist folder.
Fluent Terminal is using ts-loader with webpack to bundle ts files to bundle.js in a dist folder.

In your personal opinion, are those superior solutions?

I tried out building and running Terminus, it also seems to be bundling the files.
Personally I think those are equivalent to approach 1 which I consider better than approach 2.
We can also choose to bundle the files if we want.

Sounds good to me!

Should we bundle?

I think so, I don't see any downsides to it? Might be a bit slower maybe?

I tried to setup bundling but getting errors with json modules.
Module parse failed: Unexpected token m in JSON at position 0 while parsing near 'module.exports = {"n...'
File was processed with these loaders:
 * ./node_modules/json-loader/index.js
You may need an additional loader to handle the result of these loaders.```
Tried to fix but no luck there.


Refactor workflow hydration process

Hydrating a workflow is the process of replacing referenced workflow variables by the input values. We already have a method that hydrates the workflow. It does the job but it is currently written to both validate the variables and get the values while doing the hydration. These are technically 3 different tasks.

The formatting for variables should be validated when the value is assigned to the object.
Retrieving the values for each argument should be implemented in the object.
Replacing the workflow variables with their respective value which should be done during the hydration.

Basically the workflow and variables should be validated well before the hydration happens. This will save us from validation issues during the translation of queenbee workflows to other platforms.

Righto, as discussed today with @mostaphaRoudsari I will tackle this issue this week. Good way to get back into the flow of things.

@AntoineDao, items 1 and 2 are already implemented. We still need item 3.


fix: fix regression in getCurrentSlotAround

Motivation

See discussion here: https://discord.com/channels/593655374469660673/1197575814494035968/1204813241155326042

Description

Reverts code change from #6398

:tada: This PR is included in v1.16.0 :tada:


Give an option to set start date as empty as well

We should have option so that we can set start date as null/empty as well and pass only end date as first like:
onDatesChange([null, new Date()]) // gives error now
to set both date empty we use
onDatesChange([])
@Feshchenko

@ayushcs hey, thanks for reaching.
Please provide more context and use case.

Explained in https://github.com/rehookify/datepicker/pull/48


Add test cases for HC4 Regressions and Fix broken Link in Readme

Codecov Report

Merging #1911 (5d2882b) into master (68a89fc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1911      +/-   ##
============================================
+ Coverage     58.52%   58.56%   +0.03%
  Complexity     1079     1079
============================================
  Files           180      180
  Lines         10382    10391       +9
  Branches       1429     1429
============================================
+ Hits           6076     6085       +9
  Misses         3786     3786
  Partials        520      520

Impacted Files
Coverage Δ

src/main/java/io/anserini/eval/Qrels.java
100.00% <100.00%> (ø)

...in/java/io/anserini/search/topicreader/Topics.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a89fc...5d2882b. Read the comment docs.


Feature Request: Accept globs in files option

I wanted to target all deploy.yaml files inside my src folder. It would be very useful to use:
- name: deploy.yaml validation
  uses<EMAIL_ADDRESS>  with:
    yaml_as_json: "true"
    json_schema: ./infra/deploy.yaml.schema.json
    base_dir: ./src
    files: "src/**/deploy.yaml"
    comment: "true"

@rhuanbarreto I published a pre-release -> v2.5.0. This release should properly allow for you to use glob pattern matches for the files input. Give it a go and let me know how it works for you!
PS I would love to visit Odda one day 😄 🇳🇴


Adding support for glossarist model V2

Added support for glossarist model V2
closes #20

Thank you @HassanAkbar , please help release.

@ronaldtse released version 0.1.8.


Fix invalid message in OpenAPI gen client

Purpose
This will fix the openapi gen client message issue in OpenAPI tooling.
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/20384
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20387 into release-stage will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-stage   #20387   +/-   ##
==============================================
  Coverage          15.21%   15.21%
==============================================
  Files                 50       50
  Lines               1341     1341
  Branches             208      208
==============================================
  Hits                 204      204
  Misses              1121     1121
  Partials              16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02d6ed...f4a1a86. Read the comment docs.


CASSANDRA-19180: Support reloading keystore in cassandra-java-driver

Jira: https://issues.apache.org/jira/browse/CASSANDRA-19180
This PR includes keystore reloading for DefautlSslEngineFactory, implemented by checking the contents of the keystore file at a periodic interval. This is intended to be useful in environments where mTLS is enabled, application instances restart infrequently, and certificates are short-lived. The existing default behavior (no reloading at all) would cause application re-connections to fail after the client certificate in the original keystore has expired, requiring an application restart to establish a new session to pick up the updated contents of the keystore file.
This PR does not include a mechanism for updating the contents of a keystore file in different environments. In some environments where client certificates are automatically renewed, an application may have to load those certificates into their keystore with a tool like fsnotify or a cronjob to keep identity certificates and the client-referenced keystore file in sync.

I ran the entire integration suite this PR and seemed to run pretty good;
Since i'm on a M1 mac and need your CASSANDRA-19292 patch to run against 4.1 I ran against a local C* with a newer JNA patched in and the entire suite ran clean, with exception to DefaultReactiveResultSetIT (think that may be somewhat flaky, taking a look that).

FTR these changes got a clean run on DataStax Jenkins

With two +1's from committers (mine + one from driftx on the JIRA ticket) this ticket was considered eligible to merge.


Remove promise/future in lieu of a different approach

Apparently, using futures is not the most efficient approach so we should investigate whether we can have a dedicated scheduler which collects all tasks and then offloads them to workers. Each worker could have its own queue. Once a task's parents have all finished a task is marked as ready and given to any worker. The worker will assign the result once finished.

Not needed.