Bug: ssr hydrate unmatch problem

Describe the bug

Reproduction
$ cd examples/ssr
$ pnpm build
$ node ./server

Logs
No response
Severity
blocking all usage of TNF
Additional Information
No response

close with #59


change travis config for pep8 to run on only sqlite

#652
sorry @henn I forgot to do this on the other PR
I also separated it out into another script to make it conform

Looks good to me.
+1

+1


[iOS] UI issue. The borders flickering with the shadow during transition.

Hello. First of all thanks for such a cool library!
I've just installed and checked the animation and everything works fine, but I noticed weird behavior. When an element has a border style, it flickers with a strange shadow around it.
Steps to reproduce:

Add any view with a border style on the screen
Stay on this screen and try to switch theme with animation

https://github.com/WadhahEssam/react-native-theme-switch-animation/assets/23724142/1ddaf7d4-bf70-4004-a05d-4fadfb53672e

Hello @tr3v3r can you post your code for this section please, I tried to reproduce it but I couldn't.
here is what I tried

https://github.com/WadhahEssam/react-native-theme-switch-animation/assets/24798045/fd861bca-3c33-4272-85d3-9e273866b689
also tried adding shadow view

and still couldn't get this effect

I've noticed this behaviour as well, but on the stock react-navigation bottom bar.  You can see a shadow the pops in and then pop out again during the animation.
https://github.com/WadhahEssam/react-native-theme-switch-animation/assets/19569469/c3bd43f8-8a3a-4327-b4f5-44bab4216a5f

I've been able to isolate it to the borderTopWidth of the stock bottom tab bar of react-navigation.  Here it is with a borderWidth of 1 and color red, which makes it easier to see!
   <Tabs
      screenOptions={{
        tabBarStyle: {
          borderTopColor: "red",
          borderTopWidth: 1,
        },
      }}

Setting borderTopWidth: 0 makes the issue go away.
https://github.com/WadhahEssam/react-native-theme-switch-animation/assets/19569469/1ac8e070-78cb-459a-9310-5c68f14535b7

Sorry for the barrage of updates, but weirdly enough, if you set a border width on anything, this issue happens, but if you set a borderRadius, it goes away.
https://github.com/WadhahEssam/react-native-theme-switch-animation/assets/19569469/99145861-84d6-4bf5-a190-4e11b2ee4a6b

Wow this is really interesting, as you might know the package is just taking a snapshot, it might be worth it to investigate why this artifact is taking place with these scenarios, Thank you guys

Added a section to the docs on how to solve it, thank you guys


feat: pass sbom_type and report_format as an optional argument

Thanks! This will also close #1 and #17


Dice Game using react

Dice Game added

add proper readme

Hey @Kritika30032002  I have added the readme file to the project can you go through it.

Thanks for your valuable contribution.
Don't forget to star the repo.

Thanks @Kritika30032002


Update kafka-avro-serializer to 5.3.4

Updates io.confluent:kafka-avro-serializer from 5.3.2 to 5.3.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.confluent", artifactId = "kafka-avro-serializer" } ]

labels: library-update, semver-patch

Superseded by #161.


Update groups-dynamic-membership.md

Fixes for proper device.devicePhysicalIDs formula

@barclayn
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Documentation is not available - 404 error

The link of the documentation from the README.md https://smiley22.github.com/S22.Imap/Documentation/ is not working.

https://smiley22.github.io/S22.Imap/Documentation/ works, please update the links in github https://github.com/smiley22/S22.Imap

You guys should seriously consider switching over to MailKit. It seems like ever since MailKit came onto the scene 8+ years ago, all of the other open source IMAP libraries died off. MailSystem.NET, ImapX, S22.IMAP, and AE.Net.Mail.
Check the commit history for this project and you will see for yourself. It's as dead as a door nail.
You are wasting your time continuing to use this library.


Fix broken texture coordinates in PathDrawNode/CircularProgressDrawNode

Fix broken texture coordinates in PathDrawNode/CircularProgressDrawNode
This wound up being a recursive spiral of fail. The pattern 1 / Texture.{Width,Height} is broken because those properties are integers, and  everything rounds to zero. Except for 1x1 textures where it doesn't round. But this whole code was broken for texture atlases because it was computing coordinates without taking the atlas into account, assuming it was a single texture. But it happened to work for WhitePixel because 1 - 1 = 0 and so the bottom right coord moved (by what the code thought was one pixel, but in reality was the whole atlas) to the top left corner, which is where the white pixel is.
Blergh.

closes (potentially) ppy/osu#3215

original PR

The pattern 1 / Texture.{Width,Height} is broken because those
properties are integers, and thus the division truncates to zero.

closes (potentially) ppy/osu#3215

Note: this makes the code do what it was intended to do, but that doesn't mean it's actually correct (maybe the version without this adjustment was right), so whoever wrote the original code should probably chip in.

Nice find. It's really weird resharper doesn't pick up on this.
It can identify most incorrect usages:

As the person who wrote the code: yes, that's definitely a bug, nice find. :)

So it turned out to be more broken than expected; see updated PR/commit message. Hopefully the new code makes sense and is more readable.

Also while I'm here I simplified the CircularProgressDrawNode logic a bit. There was a bunch of needless complexity there.

Oh derp, I totally forgot about that feature. I need to think about how the texture map interacts with that. You're right, this change would obviously break that use case. I'll look at it when I get home.

Can you test without the second commit? If that works as intended then I have a good reference to go by, and might just drop the second commit if I can't find a better way to simplify the code.

Looks good without the second commit. 👍

Dropped the second commit from this PR. I'll give it a rethink and maybe add another test case to make the texture mapping more obvious. I think I might want to subtly change the behavior but that's a story for another PR.

If you plan to change the behaviour of circular progress you might want to look into what currently happens when activating both "Horizontal Gradient Texture" and "Transition Focus [2]" at the same time in its visual test. The boundary behaviour as currently implemented seems buggy to me there.
I'll get this PR merged for now.

Thanks for the fix!


[BACKLOG-11642] Fixing dependency issue causing ClassDefNotFound erro…

…rs.  Also discovered that pound sign comments are no longer supported in the new version of Drools so the sample was updated as well.
@hudak / @mkambol / @kcruzada

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-drools5-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/kettle-drools5-plugin/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  assembly/package-res/samples/transformations/Rules Accumulator - Solve Golfer Rule.ktr
  plugins/kettle-drools5-plugin/ivy.xml

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-drools5-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/kettle-drools5-plugin/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  assembly/package-res/samples/transformations/Rules Accumulator - Solve Golfer Rule.ktr
  plugins/kettle-drools5-plugin/ivy.xml


Fix error when printing WindowsRegistryKey

Caused by WindowsRegistryKey having a 'values' property. Fixes #236.

Codecov Report

Merging #237 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   98.58%   98.58%   +<.01%
==========================================
  Files         117      117
  Lines       12460    12474      +14
==========================================
+ Hits        12284    12298      +14
  Misses        176      176

Impacted Files
Coverage Δ

stix2/v20/observables.py
100% <100%> (ø)
:arrow_up:

stix2/v21/observables.py
96.49% <100%> (+0.12%)
:arrow_up:

stix2/test/v21/test_observed_data.py
100% <100%> (ø)
:arrow_up:

stix2/test/v20/test_observed_data.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e23b0...34002c4. Read the comment docs.


Add e2e test for the CLI

fix #489

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2878/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2878/

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@typespec/compiler


Wrong argument handling when specifying 'ignore_unknown_options' in combination with options

I am having trouble with argument handling when specifying the 'ignore_unknown_options' in combination with options.
In this specific case, I need to use the 'ignore_unknown_options' flag in order to pass a unknown amount of arguments AND options to an underlying process. (And prevent click from interpreting words beginning with a dash '-' as options).
At the same time, whenever you have an option specified with a letter, click will still steal this single letter from the argument.
Consider this minimal example:
import click

@click.command(context_settings=dict(ignore_unknown_options=True, ))
@click.option('-y', '--default_yes')
@click.argument('compiler_args', nargs=-1)
def cli(  default_yes, compiler_args):
        print(compiler_args)

When called with
cli -DCMAKE_CXX_FLAGS=-Wreturn-type
it will print
(u'-DCMAKE_CXX_FLAGS=-Wreturn-t',)
and cut the rest off.

Use -- to turn off subsequent option parsing. All tokens after the -- are treated as arguments.
cli -- -DCMAKE_CXX_FLAGS=-Wreturn-type

The specific behavior reported is a weird ambiguity with how a few different features of the parser. Since short options can be combined, and unknown options were ignored, the short option parsing scans each character in the token to see if it's individually a valid option, and collects all unknown options, recombining them at the end as an extra argument. Since -y is a valid option, and none of the other characters are, -y gets collected and removed from the rest.


[Emails] Template context variables documentation links

This fixes #2482 by providing links to documentation for every variable used in email template context (e.g. person, event, award, etc.).
It builds on top of #2481.
WIP. Needs testing and perhaps some code improvements / refactoring.

@elichad ready for your review! Thanks.

@elichad Please take a look again and consider my responses to your questions. Thanks!


fix when reset items selectedIndex beyond the labels

when before update items  seletedIndex is 4, after update  the items count less than 4, so beyond the array count .

Thanks for your PR. Havn't found the time to check this yet. But why did you close this?


Client connect timeout not being used

Client.connect accepts a timeout parameter which is stored so Client.reconnect will use that, however within Client.connect at line 175, tcp.connect uses a hard-coded timeout value of 5000 where the timeout parameter should be used.

@m6246 have you tried changing it to the timeout value and seeing if it works? You could submit a PR.

As #connect is just calling Socket#connect this should most definitely work.
Strangely, the timeout is used for reconnecting, see here.

Indeed, that is strange.


distributed cuckoo - IOError: No such file or directory [machine 2]

I setup distributed cuckoo (3 machines), i followed everything that has been written in the guide here: http://cuckoo.readthedocs.org/en/latest/usage/dist/#quick-usage
dist machine - host the mySQL server (cuckoo db) and runs dist.py,
machine 1 - only a cuckoo node (runs api.py, cuckoo.py and process.py)
machine 2 - only a cuckoo node (runs api.py, cuckoo.py and process.py)
machines 1 and 2 both have one guest machine each.
for both cuckoo.conf, the DB connections are pointed to the mySQL server (cuckoo db), which is the ip of dist machine. I also turned off the processing in the cuckoo.conf.
-------RESULT after submitting 2 samples to analyze------
machine 1:
cuckoo.py - <task=2> has been processed properly
machine 2:
[lib.cuckoo.core.scheduler] INFO: Starting analysis of FILE "/tmp/cuckoo-tmp/upload_Wn0Iyy/tmpw05od4" (task=1) 2015-02-21 15:18:53,784 [lib.cuckoo.core.scheduler] ERROR: Failure in AnalysisManager.run
.....
.....
IOError: [Errno 2] No such file or directory: '/tmp/cuckoo-tmp/upload_hOUzJ2/tmp86uvmd'

Each machine should have its own database. So either use "cuckoo1" and "cuckoo2" databases for the respective machines or have a localhost database on each machine.
Let me know if that works for you.

hi jbremer, it works :100:  thanks so much for the help.


Error: unsupported type for static module: VariableDeclarator

Getting this error both in brfs 1.1.0 and 1.1.1. I'm on Windows 7, 64-bit.
I'm building my browserify bundle from the command line, using the -t brfs flag. I don't even have any require('fs') statements in my code yet; this error is thrown regardless, due to the transform.
The error is not thrown on 1.0.2 and older versions.

Could this issue have regressed? I can repro the error on versions 1.4.2 and 1.4.3 but not on 1.0.2 as indicated above.

+1 on regression


FluxCD CRD's not found | paas-hosted | cluster: kind

Kind config:
kind: Cluster
name: kind
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
  kubeadmConfigPatches:
  - |
    kind: InitConfiguration
    nodeRegistration:
      kubeletExtraArgs:
        node-labels: "ingress-ready=true"
  extraPortMappings:
  - containerPort: 80
    hostPort: 8080
    protocol: TCP
  - containerPort: 443
    hostPort: 4443
    protocol: TCP
containerdConfigPatches:
  - |-
    [plugins."io.containerd.grpc.v1.cri".registry]
      config_path = "/etc/containerd/certs.d"

hosts.tml
tee /etc/containerd/certs.d/ghcr.io/hosts.toml > /dev/null <<EOF
server = "https://ghcr.io"

[host."https://ghcr.io"]
  skip_verify = true

~ ❯ k get po -n cozy-system
NAME                         READY   STATUS    RESTARTS      AGE
cozystack-85c98969bd-jl95x   2/2     Running   3 (84s ago)   4m46s
~ ❯ k get po -n cozy-fluxcd
NAME                             READY   STATUS    RESTARTS   AGE
flux-operator-5975cd5785-jgf8l   1/1     Running   0          4m53s
~ ❯ k get ns
NAME                             STATUS   AGE
cozy-cert-manager                Active   4m59s
cozy-clickhouse-operator         Active   4m59s
cozy-dashboard                   Active   4m59s
cozy-etcd-operator               Active   4m59s
cozy-fluxcd                      Active   4m59s
cozy-grafana-operator            Active   4m59s
cozy-kafka-operator              Active   4m59s
cozy-linstor                     Active   4m59s
cozy-mariadb-operator            Active   4m59s
cozy-monitoring                  Active   4m58s
cozy-postgres-operator           Active   4m58s
cozy-public                      Active   4m58s
cozy-rabbitmq-operator           Active   4m58s
cozy-redis-operator              Active   4m58s
cozy-system                      Active   5m1s
cozy-telepresence                Active   4m58s
cozy-victoria-metrics-operator   Active   4m58s
default                          Active   8m15s
kube-node-lease                  Active   8m15s
kube-public                      Active   8m15s
kube-system                      Active   8m15s
local-path-storage               Active   8m12s

Logs:
https://paste.openstack.org/show/bUUOqafS7FF3zcLVqGyo/
If containerdConfigPatches are not configured, ErrImagePullBackoff appears.

Do you have someone intercepting ghcr.io or are you air-gapped - I see this error which explains why the manifests did not load:
{"level":"error","ts":"2024-10-15T11:20:10.492Z","msg":"Reconciler error","controller":"fluxinstance","controllerGroup":"fluxcd.controlplane.io","controllerKind":"FluxInstance","FluxInstance":{"name":"flux","namespace":"cozy-fluxcd"},"namespace":"cozy-fluxcd","name":"flux","reconcileID":"baf22973-b379-46cd-bc68-c045ede01252","error":"pulling artifact oci://ghcr.io/controlplaneio-fluxcd/flux-operator-manifests:latest failed: Get \"https://ghcr.io/v2/\": tls: failed to verify certificate: x509: certificate signed by unknown authority"}

There is a configuration variable that you can use if you crane lift copied controlplaneio-fluxcd/flux-operator-manifests:latest into your local ghcr mirror, which might be the next step if you tell me that you are air-gapped
(I haven't tested this configuration in an air-gap)
Note this section in the cozy-fluxcd namespace FluxInstance named flux:
spec:
  cluster:
    # ...
  components:
    # ...
  distribution:
    artifact: oci://ghcr.io/controlplaneio-fluxcd/flux-operator-manifests:latest
    registry: ghcr.io/fluxcd
    version: 2.3.x

These are the defaults. To install Flux, this needs to point at an OCI registry with the latest artifact, or some specific version of the packaged Flux manifests that you find at:
https://github.com/controlplaneio-fluxcd/flux-operator/pkgs/container/flux-operator-manifests

Do you have someone intercepting ghcr.io or are you air-gapped - I see this error which explains why the manifests did not load:
{"level":"error","ts":"2024-10-15T11:20:10.492Z","msg":"Reconciler error","controller":"fluxinstance","controllerGroup":"fluxcd.controlplane.io","controllerKind":"FluxInstance","FluxInstance":{"name":"flux","namespace":"cozy-fluxcd"},"namespace":"cozy-fluxcd","name":"flux","reconcileID":"baf22973-b379-46cd-bc68-c045ede01252","error":"pulling artifact oci://ghcr.io/controlplaneio-fluxcd/flux-operator-manifests:latest failed: Get \"https://ghcr.io/v2/\": tls: failed to verify certificate: x509: certificate signed by unknown authority"}

There is a configuration variable that you can use if you crane lift copied controlplaneio-fluxcd/flux-operator-manifests:latest into your local ghcr mirror, which might be the next step if you tell me that you are air-gapped
(I haven't tested this configuration in an air-gap)
Note this section in the cozy-fluxcd namespace FluxInstance named flux:
spec:
  cluster:
    # ...
  components:
    # ...
  distribution:
    artifact: oci://ghcr.io/controlplaneio-fluxcd/flux-operator-manifests:latest
    registry: ghcr.io/fluxcd
    version: 2.3.x

These are the defaults. To install Flux, this needs to point at an OCI registry with the latest artifact, or some specific version of the packaged Flux manifests that you find at:
https://github.com/controlplaneio-fluxcd/flux-operator/pkgs/container/flux-operator-manifests

Yes, environment related problem. Would need to work more on air-gap installation. Thanks for response though.


Feature Request - Obtaining Configuration Remotely

tldr Possibly modify .AddBlazoredOpenIdConnect to allow not setting options and obtain them via the dependency injection system.
Issue
Currently to configure OpenIdConnect for the Blazor Client one needs to know the settings at compile time, i.e.
 builder.Services.AddOptions()
            .AddAuthorizationCore()
            .AddBlazoredOpenIdConnect(options =>
            {
                options.Authority = "http://localhost:5000/";

                options.ClientId = "Client.Code";
                options.ResponseType = "code";

                options.Scope.Add("openid");
                options.Scope.Add("profile");
                options.Scope.Add("api");
            })

Setting the options.Authority to http://localhost:5000 is fine for development, however for deployment I need to 'do something else' to set options.Authority to a 'real url' for my application, i.e. not localhost.
In past SPA applications I'll obtain my open id configuration from the server the SPA was served from by making a fetch call back to my server to obtain my open id configuration information.  i.e. in Blazor Program.cs I can do:
 SpaSystemConfiguration spaSystemConfiguration = new SpaSystemConfiguration();
            using (HttpClient client = new HttpClient())
            {
                //this needs a full url...can't get a handle on the window
                HttpResponseMessage response = await client.GetAsync("https://localhost:5000/api/utilities/SpaConfiguration");
                response.EnsureSuccessStatusCode();
                string responseBody = await response.Content.ReadAsStringAsync();
                (_, spaSystemConfiguration) = responseBody.TryParseJson<SpaSystemConfiguration>();

                Console.WriteLine(spaSystemConfiguration);

            }

I can then feed in my spaSystemConfiguration that was obtained from my server into .AddBlazoredOpenIdConnenct.
This solution doesn't fix the issue, httpClient still needs a full url, so I'm back to hard coding http://localhost:5000 into my Blazor client.
Possible Solution
I'd love to be able to do something like:
builder.Services.AddSingleton(async p =>
            {

                var httpClient = p.GetRequiredService<HttpClient>();
                HttpResponseMessage response = await httpClient.GetAsync("api/utilities/SpaConfiguration");
                response.EnsureSuccessStatusCode();
                string responseBody = await response.Content.ReadAsStringAsync();
                (_, spaSystemConfiguration) = responseBody.TryParseJson<SpaSystemConfiguration>();

                var options = new OpenIdConnectOptions();
                //fill options in with results from spaSystemConfiguration

                return options;
            });

And have .AddBlazoredOpenIdConnect pick up those options from the dependency injection system.

Thanks for the updated version!  I was able to use the newly released Blazor WebAssembly 3.2.0 Preview 3 and added a appsettings.json instead of using the httpClient.  i.e.
builder.Services.AddAuthorizationCore(options => { })
               .AddBlazoredOpenIdConnect(async (provider) =>
               {
                   var options = new OpenIdConnectOptions();
                   var configuration = provider.GetRequiredService<IConfiguration>();
                   options.Authority = configuration["SpaOptions:Authority"].ToString();
                   options.ClientId = configuration["SpaOptions:SpaClientId"].ToString();
                   options.ResponseType = "token id_token";
                   options.Scopes.Add("openid");
                   options.Scopes.Add("profile");
                   options.Scopes.Add("email");
                   options.Scopes.Add(configuration["SpaOptions:Scope"].ToString());
                   return options;
               })

I didn't have any luck using the httpClient...I was able to make the initial request to the IdServer, however the return response was "lost" and I was never able to fully authenticate.


docs: remove module-metadata.json and commitlint.config.js

/run pipeline

/run pipeline

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


vmag == null

null / None is being inserted into the found database for vmag.  Instead, these comets should be ignored.

Currently just three comets.  The problem is that HORIZONS does not have a brightness model for them.  Only one, 323P, was too faint to check.  The other two were OK.


Idea - switch from Rxjs to kefirjs

Hi there, I find the idea of this project very intriguing and I think you did a great job.
This is just my 0.02$ but would it be possible to switch from Rx to kefirjs? Or you could just port it to kefirjs in another branch of the project.
I know the cyclejs core depends on Rx heavily, but I think it shouldn't be a problem as kefirjs provides the same functionality as Rx does and this step would massively reduce the size of the cyclejs framework. This would help anyone who creates small applications (like me) where the size matters the most and ~200k minified is quite a lot.

It's easier to just make a separate library using Kefir, than to migrate Cycle.js to Kefir. For instance Cycle Core is just about 100 lines of code, it should be simple to make a clone of it with Kefir. Cycle DOM without the custom elements is also rather small.
I'm planning on switching to ReactiveX/RxJS once it's ready, it should be a faster RxJS implementation than the current one.

Thank you for the reply @staltz. I think switching to faster RxJS will not solve the problem with the size of the library unless the newer RxJS would be also modular. Another thing is that RxJS has Apache 2.0 license where kefirjs has MIT license which is more open source I think.
I would like to make a clone of cyclejs with kefirjs, but my programming skills aren't on that level yet, I started with programming a year ago and I'm still learning. So for now I can only hope someone will find this idea interesting and make such a clone one day. Meantime I can play with cyclejs with RxJS.
Anyway thank you for your effort in creating this library.

I think switching to faster RxJS will not solve the problem with the size of the library unless the newer RxJS would be also modular.

AFAIK modularity was one of the goals of the rewrite.

Thank you for the information @gaearon , that would be great.

Is there any value in perhaps "initializing" Cycle by passing it a reference to the core Rx namespace? That way Cycle could be completely decoupled from its RxJS dependency and work with any library that correctly implements the core set of operators.

peerDependencies?

Let's say my dev folder structure is:
A: /dev/node_modules/my_npm_module
B: /dev/projects/amazingness/node_modules
My amazingness project requires 'my_npm_module' and because of the folder structure, I can simultaneously develop that module and amazingness will find it. If, however, my_npm_module requires  Rx, just as my amazingness does, and it's declared as a peerDependency of my_npm_module, will, does that mean that my my_npm_module will still compile and just assume that, at runtime, it will be able to find it once all is said and done?
If so, then :+1: from me :)


Can we include CT for all urls by specifying .

Why we have to give each domain as +.domain.com.
Is there any restriction for enabling for all domains by default and restricting whichever does not have CT by adding -.domain.com

I've added support for this which will go out in the next release. To use, you'll have to configure as follows:
        certificateTransparencyInterceptor {
            +"*.*"
            -"exclude.example.com
        }


Automated Package Upgrade

:tada: This PR is included in version 20.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


On a single 4090, it takes less than 1 day to train on NOCS (60 epochs).

          On a single 4090, it takes less than 1 day to train on NOCS (60 epochs).

Originally posted by @shangbuhuan13 in https://github.com/NOrangeeroli/SecondPose/issues/4#issuecomment-2041474987

Hi, thank you for your great work.  When I run train_geodino.py on my 4090, I find that the training time for one epoch is 73 minutes. I choose REAL275 dataset. Do you mean CAMERA25 when you say less than one day?

Hi, we used a mixture of REAL275 and CAMERA25 as mentioned in the paper. The data loading pipeline is not very well optimized and larged runs on cpus, so your cpu's capacity also influences the running time.
Best,
Yamei

Hi, we used a mixture of REAL275 and CAMERA25 as mentioned in the paper. The data loading pipeline is not very well optimized and larged runs on cpus, so your cpu's capacity also influences the running time. Best, Yamei

Thank you very much for your answer. I have just started this field, so I am not familiar with the dataset. I just executed "python train_geodino.py --gpus 0 --mod r" as stated in "readme.md". I noticed that the default dataset in the code is REAL275. I would like to ask if the public code provides a method to train on a mixed dataset of REAL275 and CAMERA25.
My hardware cpu is "Intel(R) Xeon(R) Platinum 8352V CPU @ 2.10GHz, 512 GB RAM". Maybe I should process the data in advance to avoid repeated calculations for each epoch of training.
Maybe it's because I'm a beginner, so I haven't noticed some details. I would be very grateful if you can give me some advice.


Attachment file is uploading infinite times

Project Details are :
https://paste.apache.org/cpo8y
Test case is available on VDI.
Go to Inventory from Select in Menu
Go to Carriage/Freight from Setups in Menu
File : com/dbz/modules/Common/dbzDriverMasterSetup.mxml
Click on New Button and then attachment icon and then attach a file
If you tick Pause on Exception then system will upload file one time but if you didn't tick on Pause on Exception system will upload attachment infinite times

Is it uploading a file infinite times or is it adding the same item to the list over and over again?  Are there any exceptions if you pause on exceptions?

Its adding same item over and over again,and if i tick on pause on
exception i will give exception uncaught TypeError: Cannot read property
'at_Name' of undefined
On Sat, Jun 13, 2020, 10:40 AM aharui<EMAIL_ADDRESS>wrote:

Is it uploading a file infinite times or is it adding the same item to the
list over and over again? Are there any exceptions if you pause on
exceptions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/royale-asjs/issues/853#issuecomment-643573813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKB67E3QMJ3WA3NNWJKMOQDRWMGMVANCNFSM4N2GLILQ
.

What is the call stack of the exception?

I have logged into application and opened Driver Setup,Please check

I logged out of VDI,Please login VDI,application is running and Driver Setup is opened

When you select a file to upload, the fn_FileSelect_EH is called in dbzAttachmentPopUp.
It calls strFileRef.load() after setting up a COMPLETE event handler that should call fn_FileUpload_EH.  But fn_FileUpload_EH also calls strFileRef.load() which should generate another load and COMPLETE event which seems like an infinite loop to me.
I think when you stop at the exception, the COMPLETE event is delayed.  It doesn't make sense to upload in the upload-is-complete handler.  It might have worked in Flex because the upload may not start immediately, but I think it might have different timing in Royale.  I recommend removing strFileRef.load in fn_FileUpload_EH.  I don't understand why it is there.

@aharui Thank u so much issue resolved by removing strFileRef.load in fn_FileUpload_EH.


Responsive design for mobile devices (mainPage) and responsive design for mobile devices and tab devices (gptArena ) .

Responsive design for mobile devices (mainPage) and responsive design  for  mobile devices and tab devices (gptArena ) .

@anushkaDev9
I absolutely love what you've done, but you need to fix a few things:
mainPage:

reduce the text (Welcome to the GPT arena);
fix the image size(height).

gptArena:

container size(height);
size of the submit button;
reduce the size of the text (GPT Arena);

!! Important !!
The GPT-Arena website design presents all content in one window, avoiding the need for scrolling.

I have added the required changes please let me know if you can see it and any further changes let me know .Thank you

Wow, looks like a design, I really like your work.
And the last thing you need to change:

align the text and elements on the mainPage to the left edge (Welcome to the GPT arena and button)

Thank you.
I have again changed and updated .Let me know if this is good?


Changing Duration/Reason Using Quick Mutes

Describe the bug
When a quick mute is handled and executed. The Moderator that used the Quick Mute reaction can not change the duration or reason of the mute.
To Reproduce
Steps to reproduce the behavior:
1: Mute a user using quick mutes.
2: Try changing the duration or reason.
Expected behavior
The Moderator that handed out the quick mute should be able to change the duration or reason.
Current behavior
The Moderator can't change the duration or reason.

Quick mutes are not designed in the same way that regular mutes are. You are not supposed to be able to change quick mute duration. If you believe the mute should be different from the predetermined values, you shouldn't be using quick mutes.


recipientName

@wrygiel :
I assume recipientName will not be used, since this is Erasmus Without Paper :-)

Why? We are, after all, discussing postal addresses. Sure, ultimately we want people to stop using those, but until we achieve that, I think we need that field?

I was being flippant. What I meant was that there is already a contact-name - do we need the recipientName as well?

What I meant was that there is already a contact-name

We don't have a "contact-name" in the address data type. We have one in AbstractContact though, so probably this is what you mean?
When the address is being embedded inside an AbstractContact, then we will indeed have some redundant information, but I'm not really sure if this is bad. We have seen this recipientName field in a some XML address formats we have reviewed when working on this. In fact, I also wondered if it's not too redundant, but in the end I concluded that it should be there, just for completeness.
Note, that Address type is sometimes used outside of the AbstractContact type, and we also allow developers to reuse this format in other projects (even outside EWP). You could probably deduce the value of recipientName in most contexts, but - in cases you could not (which is possible, I think) - this field might be useful. Also we don't force anyone to fill this out, so it shouldn't hurt.

One more argument (though, I adming, a bit far-fetched): It seems possible that some entities might want to be addressed a bit differently when their names are printed on envelopes.

We don't have a "contact-name" in the address data type. We have one in AbstractContact though, so probably this is what you mean?

Yes.

[...] In fact, I also wondered if it's not too redundant, but in the end I concluded that it should be there, just for completeness.
Note, that Address type is sometimes used outside of the AbstractContact type, and we also allow developers to reuse this format in other projects (even outside EWP). You could probably deduce the value of recipientName in most contexts, but - in cases you could not (which is possible, I think) - this field might be useful. Also we don't force anyone to fill this out, so it shouldn't hurt.

Ok.


Add _pipelines_per_batch as a private parameter for AutoML Search

Per this comment, we should put _pipelines_per_batch as a private automl search parameter.

Thanks @christopherbunn . Yep, this would be helpful to have exposed for perf testing, but we don't wanna commit to making it public and keeping it around until we've had more time to bake on it.


Fix unit tests

This fixes skipped unit tests with a hack to avoid a dangerouslyReplaceNodeWithMarkup react error.

Coverage increased (+11.2%) to 99.347% when pulling 0cd9275c67e4612241353edaa23e6425e3d0d944 on next-fix-unit-tests into 5858e7bc5c4b471ea4ab66f217c59a1ed043b3c6 on next.

Merged it. npm test is passing, but individually npm run test:plugin:react is failing.
I am taking a look in next.

Opened a PR here to overcome this issue: #97


[Sept Sprint] Gross Store improvements

Fixes https://github.com/exercism/go/issues/1621

@MiroslavGatsanoga Here is how you can fix the CI error for now: Instead of strings use string-formatting. We will correct this later once the strings exercise is in place. multiple-return-values does not exist, so you need to delete it. Instead leave a comment in this issue https://github.com/exercism/go/issues/1619 that it needs to be added back to the config for gross store once the concept was created.


For walkingleg, the stopsequence will always be null, therefore it should not fileter the valid legs.

#261  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


Line endings for scaffolded files are not correct

On Windows the scaffolded files have LF instead of CRLF.
Staging these files on git causes these warnings:
warning: LF will be replaced by CRLF in Root/Views/Cars2/Create.cshtml.
The file will have its original line endings in your working directory.

cc @Tratcher

I've been noticing this as well on v2.0 with Visual Studio 2017 15.3.2
Workaround is to do a Save As and change the encoding on the file, but this is tedious for every file.


beta-20161215 release note updates

This PR add doc links and updates and updates the version, built time, and start time strings. No need to regenerate sql diagrams or functions for this release.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/14987be43e91246375df498b8a235204e766612b/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9c8158181be42948c1443c18f2f03234e75883cc/


REDASH - Applicant Type Not Populating

Describe the bug in current situation
Report received from a user that the extracted requests report does not always show the applicant type on every request. It is unclear what is driving this behaviour.
Similar observations have been made with the Ministry of Education's dashboard upon closer inspection.
Applicant type/category can be seen in the application itself, so it appears it could be an issue with the data warehouse or ETL.
Link bug to the User Story
Impact of this bug
Will impact reporting by applicant type, could skew numbers.
Chance of Occurring (high/medium/low/very low)
High - Issue can be observed across all dashboards, even on non-pilot requests (ie: performance/received dashboard)
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:

Go to Production Redash, and go to the ECON Combined dashboard, or any dashboard of current data
Scroll down to excel sheet extract
Scroll through excel sheet, you will periodically see requests that are missing the applicant type

Actual/ observed behaviour/ results
Expected behaviour
GIVEN a requests details are in the data warehouse
WHEN the details are extracted in a report
THEN the details should also include the applicant type
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

Investigated and there is a problem with ETL, applicant type, category and applicant name are not being saved from AXIS for certain requests. Needs further investigation

@m-prodan : ready for testing, Could you please check!

Applicant Type field is populating on ECON combined dashboard (along with several other dashboards tested). No NULL 'Applicant Type' values appear, so this appears fixed.
Closing ticket.


Containerz

Description of changes:

Build the docker image during deploy and push it to ECR

See inline comments for more details
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I actually think there is something broken with the cloudformation stack delete...I'll keep working on it


Fixed typo in RAG with Gemma+ES+HF cookbook

What does this PR do?

Fixes #127
Who can review?
@merveenoyan and @stevhliu.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Reduces log clutter

Closes #907
This PR downgrades some Info logs that are relevant to developers but shouldn't matter to validators to Debug logs.
Most of these logs are on the consensus package.
On the positive side, there is less information overhead to operators and less storage is needed for saving logs during normal operation.
On the negative side, if debugging is needed, the log level must be changed after the need is detected, which may be too late to capture rare occurrences of bugs.
During your reviews, please let me know if any of the demoted logs have been useful in previous debug sessions and if you think they should not be demoted.

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

Relates to tendermint/tendermint#6987

Thanks, @sergio-mena
I should resume working on this PR soon.

@lasarojc any plans to resume this?

Let's revisit this PR when we have them then.


[Mention The Feature]: i want to add a tutorial in project page website.

Is your feature request related to a problem? Please describe.
i have waste mangaement optimization project , and i would like to add it here.
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@T-Rahul-prabhu-38 assigning this issue to you.
Make sure to complete it
make sure to create these tutorials without disturbing any other elements.
Since there html contains different divs and tags the css is conflicting and causing these issues.
so do it carefully.

@vivekvardhan2810 im sorry im not able to find my files for this , can you please assign this to someone else


Fix consolidation for TP

What does this PR do?
Consolidation was happening on the XLA device if the checkpoint was saved with xser. This could lead to OOM if the checkpoint data was bigger than the device memory, which is often the case. This PR fixes that.
cc @philschmid

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


KAFKA-6640; Improve efficiency of KafkaAdminClient.describeTopics()

Currently in KafkaAdminClient.describeTopics(), for each topic in the request, a complete map of cluster and errors will be constructed for every topic and partition. This unnecessarily increases the complexity of describeTopics() to O(n^2). This patch improves the complexity to O(n).
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

cc @cmccabe

Looks like a good find, if this looks good to Colin, I can merge.

@cmccabe Do you have time to review this patch? Thanks

LGTM

@hachikuji @cmccabe Thanks for the review!


[WIP] integrate nuxt-i18n

Currenty we have an issue with nuxt-i18n as they do not support routing without prefixes. Therefore we are currently blocked by my pull-request there https://github.com/nuxt-community/nuxt-i18n/pull/165

@appinteractive told me in a video-conference, we can drop this PR. Just avoid nuxt-i18n.


Jenkins has been hosed since the middle of last week

Jenkins has been seriously hosed since the middle of last week.  It is failing to run tests on PRs.
@nicolasnoble looked at this on Friday and indicated that it was due to the recent code-owners changes, which were triggering a huge number of github notifications to Jenkins, thus overloading it.  @jtattermusch looked at this morning and believed that it was a quota problem of some sort.
I don't know exactly what's going on, but I do know that we cannot merge PRs until this is fixed, so it's effectively blocking our development.  We need this fixed ASAP.
Some example PRs where tests are not running:
#11454
#11733 (although this one seems to be moving forward now that we manually asked Jenkins to test it)
We need to get back to a state where pushing commits to a PR always causes all tests to run.  Thanks!

If this is a quota issue and we can catalogue which jobs are consuming quota, I'm happy to look through said list (with anyone else that's interested) and prioritize things so that we can disable some stuff temporarily.

I am looking at Jenkins log https://grpc-testing.appspot.com/log/all
and it says:
Jul 17, 2017 10:17:10 AM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #11,454 was updated/initialized on grpc/grpc at 7/17/17 10:11 AM by Mark D. Roth (PR update)

so it seems to at least know about the PR change.

Every few minutes, Jenkins logs show that all open pull requests are processed and non-test triggering changes are found. E.g.
Jul 17, 2017 12:51:09 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR
Pull request #7,588 was updated on repo grpc/grpc but there aren't any new comments nor commits; that may mean that commit status was updated.

These updates that are being sent to Jenkins from a GitHub webhook, and these irrelevant webhook events are blocking GitHub from sending relevant events. I'm investing the irrelevant events, which I suspect might be related to use recently adapting GitHub owners.
I've temporarily switched from Jenkins watching GitHub webhook events to polling for changes. This looks like it's improving response time, but there is now a long queue of jobs that have not been triggered since this issue started last week.

The culprit was likely found. Switching back to using webhooks to trigger tests and will continue to monitor logs for webhook spam.

Switched back to polling; webhook events are still slow to process. It looks like the state of Jenkins is much better and responsive to PR creations/updates.


Implement surface field selection sync.

Example: https://www.figurl.org/f?v=http://localhost:3000&d=84a084a615ee9dfa0781a09b028ad5438b9ebb83&channel=flatiron1&label=miniwasp_surface_example2
This PR:

Adds a surface-selection synchronization value to the WorkspaceViewSelection state object
Adds reducer methods to handle this
Modifies reducer methods for modifying field selection state so that they can apply to multiple surfaces simultaneously
Adds a slider control to the SurfaceSelectionControls to toggle synchronization state
Adds display logic to SurfaceSelectionControls to position the surface field selection controls appropriately when state is synced
Adds a local css file for the WorkspaceView controls to hold custom styling (currently only used to position the slider)

There are a few subtleties about the behavior that are worth noting in this implementation.

This submission modifies the selected field for all surfaces--regardless of whether the surface is visible, or even whether it has a field by that name defined. (For display, this has the same effect for that surface as having no selected field, since none of its fields match the selected one.)
The selection state is not aware of the existence of surfaces which aren't displayed, so the SurfaceSelectionControls need to read the universe of surfaces from the data and pass the surfaces to modify into the reducer.
When toggling sync state, currently turning off sync all surfaces' selected field set to the last field selected in the synchronized state. (i.e. if you sync, select field 'r', and then desync, every surface will continue to have 'r' selected, which you can subsequently modify). When activating synchronization, if all surfaces have the same field selected, it remains selected; otherwise, all selections are cleared. I expect this is the most natural behavior. (The main motivation for clearing selection state when selections are heterogeneous is that if you turn on sync, then select a field that one of the surfaces had selected, it'll toggle off for that surface while toggling on for all the others.)

Open questions:

As currently implemented, every surface's selected field is reset to match the global state. An alternative implementation would keep a separate globally-selected-field state, and use display logic to determine which one to show. This would allow toggling while preserving selections on individual surfaces, but would disallow using this feature to easily toggle all of the surfaces' selected fields and then explore different options on one of them (since turning off sync would revert all the others). Which is a more desirable feature for our users?
Should we separate selection-synchronization for vector and scalar fields?

Open questions:

As currently implemented, every surface's selected field is reset to match the global state. An alternative implementation would keep a separate globally-selected-field state, and use display logic to determine which one to show. This would allow toggling while preserving selections on individual surfaces, but would disallow using this feature to easily toggle all of the surfaces' selected fields and then explore different options on one of them (since turning off sync would revert all the others). Which is a more desirable feature for our users?

I think the current behavior is the preferred.

Should we separate selection-synchronization for vector and scalar fields?

I think it's best to keep it simple -- as is.


Added flag and code to forcestyleliteral

Added flag to force style literal when calling yaml.safeDump.
Invoke code with forceStyleLiteral: true to force style literal to be kept.
yaml.safeDump(res,{lorceStyleLiteral: true});
Referenced in issiue #464.
This pull request will hopefully solve it.

Is this going to be merged eventually?


Example how to add headers in 1.0.0+

Adding headers in interceptors differs from < 1.0.0

I  think this should be merged :wink:


Scrcpy mobile data

Good evening,
I use scrcpy and it works fine. But if I disconnect from WiFi and connect to mobile data, there is no way for me to access the phone.
Is there a way to keep the connection available ?

Your device IP (more precisely the adb server running on the device, typically on port 5555) must be reachable from your computer. This is unlikely to be possible on a mobile data network (and you don't want to access adb remotely over internet without ssh tunnel or vpn anyway, since it's unencrypted).

you can turn on your phone hotspot and connect your computer to the hotspot
then set scrcpy connect ip address to the gateway ip

Your device IP (more precisely the adb server running on the device, typically on port 5555) must be reachable from your computer. This is unlikely to be possible on a mobile data network (and you don't want to access adb remotely over internet without ssh tunnel or vpn anyway, since it's unencrypted).

no matter how I access the internet. Is there a way to keep the connection initialized with wifi when switching to 4g?

Good morning,
I found this : https://github.com/ncdejito/scrcpy-ngrok/blob/main/run.sh
Can you help me to make it work ?


Setting loop=false to tween, results into infinite repeat

While this is correct:
var tween = game.add.tween(item).to({width:100}, duration, Phaser.Easing.Linear.None, true, 0, 0);
When writing it like this:
var tween = game.add.tween(item).to(obj, duration, Phaser.Easing.Linear.None, true, 0, false);
results in infinite looping.

Hi @photonstorm, what's the difference between loop and repeat params? They behave same way except different callbacks fired.

var tween = game.add.tween(item).to(obj, duration, Phaser.Easing.Linear.None, true, 0, true, true);


Fixed get_anchors() Return Type Inconsistency

Overview: What does this pull request change?
Closes #3185
For VMobject and OpenGLVMobject, all of get_start_anchors(),get_end_anchors(),get_anchors_and_handles() are effectively returning references to the points instance attribute (slicing a numpy array creates a view). The behavior of get_anchors() should be consistent with the above three, to return references of the anchor points rather than copies.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

VMobject
Further Information and Comments

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Hello! I would like to merge this soon as well. First lemme tell you my thoughts about this.

Initially I was very hesitant of this change, because although it solves one inconsistency (now get_anchors() will also return references), it creates another one: get_anchors() returns a list instead of a NumPy array, which looked like a worse inconsistency for me, which could negatively affect users of these methods.
However, after discussing with Benjamin Hackl about this, no other function or method in Manim which calls (OpenGL)VMobject.get_anchors() requires it to be a NumPy array or really benefits from it being that: all of them iterate over the anchors with for loops.
Plus, although technically people can use get(_start/_end)_anchors(), it's not very usual for them to do that (except maybe printing info on the screen). It's rarer to modify them... but even rarer would be to modify them in a vectorized way which requires them to be NumPy arrays.

So, I'd say I'm OK with the changes! Maybe add some clarification somewhere explaining that this returns a list instead of a NumPy array, unlike the other methods?
I would like to know what you think. Otherwise I plan to merge this soon, maybe next week :+1:

Fixed one typo in the return variable of get_anchors via b7d0b8b. Will merge this in a few hours if there are no further concerns. 👍

Seems there's a doctest that utilizes the vector nature of get_anchors: here


Invalid QR-Code

This repo sounded promising but unfortunately the QR-code to scan is not valid and it's not a road warrior type installation.
I expect a road warrior to be able to ping local resources and browse the internet.
Using From: iPhone
WireGuard Client version: 1.0.15 (26)
Server: Raspberry Pi 4
Server OS: BullsEye

Does your public endpoint IP/host name has "http://" prefixed?
I had the same invalid QR/file error on iOS because I was using full "http://www..duckdns.org".
Removing "http://" and just keeping endpoint as "www..duckdns.org" during script install generated valid QR.

Please, provide a screenshot of the invalid QR code (and remove the client before publishing the screenshot).
There are some terminal apps where potentially the QR could be messed up, but this is rare.


Lines of text change line spacing between OSes

Problem Summary/Recreation

Chrome 83.0.4103.116 on macOS 10.15.5 Catalina
Chrome 83.0.4103.116 on Windows 10 v1909

I've been working on a project for a little while, and I switch between the two above computers to do work. One is a Windows OS and the other is macOS. I use a lot of new lines for multi-line text in my diagrams (Shift+Enter).
When I finish and push my changes on Windows, then pull changes and open the same Excalidraw file on the browser on my mac, the line spacing changes.
You can recreate this by opening one of the *.excalidraw roadmap files in this repository on a macOS machine and double-clicking one of the bodies of text:
https://github.com/Static-Void-Academy/complete-software-roadmap
I know that Windows / DOS uses both CR-LF vs. *nix which uses just LF. Might that be the issue here?
Edits: Add clarity to reproduce

We're normalizing CRLF → LF on render, so EOL shouldn't be it. I'm checking your source files, and there aren't even any \r line endings in the texts.
I'm not on Mac so can't check. Are you using Firefox in one of the cases? I can reproduce spacing issues, but not vertical, but horizontal, when editing the indented text on Firefox.
The above specific issue is fixed in my latest PR: https://github.com/excalidraw/excalidraw/pull/1783
You can check the preview if you can reproduce the other issues: https://excalidraw-37phjuqal.vercel.app/

Are you using Firefox in one of the cases?

No, but I was able to reproduce the issues both on Firefox and on Chrome at that preview deployment. It could potentially be Mac. Does the line spacing depend on screen resolution at all? That's the only other difference I can think of between my computers. See the GIFs below:
On Chrome, Preview (https://excalidraw-37phjuqal.vercel.app)

Same thing on Firefox, Preview (https://excalidraw-37phjuqal.vercel.app)

Great work on the diagrams btw.

Thank you!

Does the line spacing depend on screen resolution at all? That's the only other difference I can think of between my computers. See the GIFs below:

Maybe... but it should reproduce right on the higher-res system during edit if the editor doesn't account for that :thinking:.  I'll try to investigate.

It seems like a line height issue. I've tried to fix it in https://excalidraw-my3vj8whu.vercel.app/, but I've been told it's still affected.
It supposedly happens only on initial edit, and goes away after you start typing. Also, do I understand that the preview (the one I posted in this comment) is "more" buggier (as in affects more browsers) than what's deployed on excalidraw.com right now?

On Firefox, double-clicking the multi-line textboxes both changes the line spacing and removes leading white spaces, which is probably what you were seeing re:horizontal spacing issues

That's a new one. Are we talking about stable or also the preview?
Last I checked, those leading spaces were actual spaces, not tabs, so can't explain the behavior either way.

That's a new one. Are we talking about stable or also the preview?

Hm. I'm not sure what changed here, but it looks like on Firefox I no longer see horizontal spacing issues for both preview and stable deployments. So it looks like for both Chrome and Firefox, and for preview and stable deployments, it's only a line spacing issue now.
Incidentally, I tried testing the opposite direction: creating an Excalidrawing on macOS and then opening it on Windows. The line-spacing changes the opposite direction. 🤣

So there might be some hard-coded values somewhere. I tried again by changing the resolution on my Windows screen to mirror the Mac (1440 x 900) and the line spacing changes still happened. So it looks like it's depending on something other than screen resolution.

Could you please share in any way two files with the same text, once created on the mac, and one created on mac? I could try to figure out what's the issue from the JSON data.

Here you go:
Created on Mac:
{
  "type": "excalidraw",
  "version": 2,
  "source": "https://excalidraw.com",
  "elements": [
    {
      "id": "LcRYq_et1YXpVKNagM8Iu",
      "type": "text",
      "x": 668.5,
      "y": 160,
      "width": 411,
      "height": 100,
      "angle": 0,
      "strokeColor": "#000000",
      "backgroundColor": "transparent",
      "fillStyle": "hachure",
      "strokeWidth": 1,
      "strokeStyle": "solid",
      "roughness": 1,
      "opacity": 100,
      "groupIds": [],
      "seed": 901411379,
      "version": 148,
      "versionNonce": 887525853,
      "isDeleted": false,
      "text": "Testing testing 123\n   Hello this is a new line indented inward\n   Another line indented (with 3 spaces)\n      Now 6 spaces indented",
      "fontSize": 20,
      "fontFamily": 1,
      "textAlign": "left",
      "baseline": 93
    }
  ],
  "appState": {
    "viewBackgroundColor": "#ffffff",
    "gridSize": null
  }
}

Created on Windows:
{
  "type": "excalidraw",
  "version": 2,
  "source": "https://excalidraw.com",
  "elements": [
    {
      "id": "rgERhLKoTLBXiUQurg771",
      "type": "text",
      "x": 885,
      "y": 356.5,
      "width": 411,
      "height": 128,
      "angle": 0,
      "strokeColor": "#000000",
      "backgroundColor": "transparent",
      "fillStyle": "hachure",
      "strokeWidth": 1,
      "strokeStyle": "solid",
      "roughness": 1,
      "opacity": 100,
      "groupIds": [],
      "seed":<PHONE_NUMBER>,
      "version": 147,
      "versionNonce": 580464128,
      "isDeleted": false,
      "text": "Testing testing 123\n   Hello this is a new line indented inward\n   Another line indented (with 3 spaces)\n      Now 6 spaces indented",
      "fontSize": 20,
      "fontFamily": 1,
      "textAlign": "left",
      "verticalAlign": "top",
      "baseline": 119
    }
  ],
  "appState": {
    "viewBackgroundColor": "#ffffff",
    "gridSize": null
  }
}

When I diffed the two files I noticed that the two differences of interest were the "height" and "baseline" parameters. I tried manually modifying them in Vim and saw that these two parameters were what affect the appearance.
It looks like we can narrow down into checking what sets those default "height" and "baseline" parameters


Ubuntu 24.04 Login Window unavailable (red box)

After installing fusion with the provided install script, and clicking on the log in button, a red box appears with no ability to interact with it.
Expected behavior
A browser should open, so that I can log in.

Desktop (please complete the following information):
Latest Autodesk fusion (downloaded by the install script)
Thinkpad T440p Intel HD 4600 graphics
Ubuntu 24.04

Same issue on Ubuntu 22.04

same issue, fresh clean install of fusion and Ubuntu 24.04

same issue, clean install of fusion, ubuntu 24.0, intel integrated graphics. adsk identity manager crashes immediately with a wine log. after signing in using the solution in #460. nothing happens, and fusion seems to freeze, not reacting to any mouse inputs (stays on "welcome to fusion", "check your browser to sign in" page) but curiously does react to window resize events?

It seems this is related to using the Snap version of your browser, I was able to get past this by installing the version of Firefox from apt instead of the snap and then completely removing fusion and reinstalling.

It seems this is related to using the Snap version of your browser, I was able to get past this by installing the version of Firefox from apt instead of the snap and then completely removing fusion and reinstalling. I also had to restart after installing Firefox since without the restart fusion360 could get the browser to open but the browser couldn't perform the authentication. I dont know what the underlying cause of that was.

I'm not even on Ubuntu, not using the Snap version of Firefox, and I'm still getting this issue. I don't think it's the Snap version of Firefox.


Code with an example

Hi,
I found this code and it is what I'm looking for but I don't know how to use in my code.
I start a process with
var jobId = BackgroundJob.Enqueue(() => _process.Start(User.Identity.Name, filename));

and then I have a generic class to run the process
public class ImportExcelProcessBase<T> where T : class
{
    protected readonly IImportExcel _excel;

    public ImportExcelProcessBase(IImportExcel excel)
    {
        _email = email;
    }

    public void TaskMethod(PerformContext context)
    {
        context.WriteLine("Hello, world!");
    }

    public async Task Start(string username, string filename)
    {
        _log.LogDebug($"User {username} started the import for {filename}");
    }
}

How can I write a log in Hangfire? Where is PerformContext injected?

You should take that parameter to the method which you want to execute. In your case it is the Start method. HangFire simply inject that method.
And your code should be like:
var jobId = BackgroundJob.Enqueue(() => _process.Start(User.Identity.Name, filename,null));

Thank you so much!


why some PR features not merge to master branch?

eg:  #168 #200

Thank you for asking this. I am curious as well


[SPARK-19677][SS] Renaming a file atop an existing one should not fail on HDFS

What changes were proposed in this pull request?
HDFSBackedStateStoreProvider fails to rename files on HDFS but not on the local filesystem. According to the implementation notes of rename(), the behavior of the local filesystem and HDFS varies:

Destination exists and is a file
Renaming a file atop an existing file is specified as failing, raising an exception.

Local FileSystem : the rename succeeds; the destination file is replaced by the source file.
HDFS : The rename fails, no exception is raised. Instead the method call simply returns false.

This patch ensures that the destination of rename() is overwritten also in HDFS.
How was this patch tested?
This patch was tested by running StateStoreSuite.

Can one of the admins verify this patch?

@tdas

The fix looks good to me. But the test doesn't test anything. Right?

@zsxwing The test is there just to make sure the new code path is executed during tests; should I remove it?

@zsxwing I have rewritten the test code.

@zsxwing Is it possible for you to give some approximate timeframe for when this might be accepted? A week or month? Since we are blocked in our spark streaming adoption (this HDFS error happens not only in restart but also in first run of our more complex aggregating drivers), I don't know if I should wait for this fix to make it into the nightly build soon or build a custom dist ourselves and update our automation.  Any input as to the fix timeline would be greatly appreciated!
Also this fix handles the same issue as SPARK-19645 which has a different solution. Is this simple solution sufficient or the more complex fix in https://github.com/apache/spark/pull/16980 required?

Just some feedback that I did some initial regression testing with this pull request on a full YARN (v2.7.3) 4 node cluster on GCP and it appears to have fixed the two issues we had- our structured streaming drivers now restart normally and our complex aggregation driver runs for the first time.

What is the proposed semantics from this PR now ?

If file exists, ignore.
If file does not exist, try to rename - if fails, throw exception.

Is this right ? If yes, the PR title/description should be changed.

ok to test

Is this right ? If yes, the PR title/description should be changed.

+1

Test build #73548 has started for PR 17012 at commit 530c027.

Test build #73548 has finished for PR 17012 at commit 530c027.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73548/
Test FAILed.

Just two minor comments. Otherwise, LGTM.

Test build #73589 has started for PR 17012 at commit de228a4.

Test build #73589 has finished for PR 17012 at commit de228a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73589/
Test PASSed.

LGTM. Thanks! Merging to master, 2.1 and 2.0.


typo in bash script

Script instructions for creating a service principal in this document, and similar documents (Set up MLOps with Azure DevOps, Set up LLMOps with Prompt Flow and GitHub), contain a typo in line:
echo "Using subscription ID $subscriptionID"
should be:
echo "Using subscription ID $subscriptionId"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 96b9eaba-0b2a-5a9f-0188-46e280446e1c
Version Independent ID: 30ec1aee-0ba1-41d5-2228-9ac9327d01a8
Content: Set up MLOps with GitHub - Azure Machine Learning
Content Source: articles/machine-learning/how-to-setup-mlops-github-azure-ml.md
Service: machine-learning
Sub-service: mlops
GitHub Login: @AbeOmor
Microsoft Alias: osomorog

@riprawira Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@riprawira The above PR has been filed and it is currently under review.


Specify Required Options, showMessageBox

Porting https://github.com/atom/electron.atom.io/issues/38 over here and assigning myself. I'll look for things like this as I go through the content in my next phase of documentation-ing.
Original issue content from @cfjedimaster:

The dialog doc (http://electron.atom.io/docs/v0.27.0/api/dialog/) for showMessageBox doesn't state what options are required. I ran into this trying to open a box w/o specifying buttons.

I'm merging this to more generic #2088.

Electron: 1.4.12
OS: macOS Sierra 10.12.1
Not sure if something got changed since last year, but the docs currently show that buttons is an optional option yet it fails without an array.
electron.dialog.showMessageBox({
  // buttons: ['Dismiss'],
  message: data
})

Thanks @SimulatedGREG, reopening this.


Wow!

Wow, I knew you could quickly reproduce it preliminarily. You are amazing! :+1::+1::+1:

It's because I have been doing similar experiments before, but failed to make it work and gave up hhh.
Thanks for the inspiring paper and looking forward to the official repo!


Update s3, sso, ssooidc to 2.25.69

About this PR
📦 Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sso
software.amazon.awssdk:ssooidc

from 2.25.68 to 2.25.69
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #62.


Agent notes / additional information

I'm having a hard time understanding the intent behind the rules concerning agents' notes elements.
As a starting point METS allows an unbounded number of note elements on an agent which I initially expected to remain the case for any agent further defined in the specs here. But CSIP15 is defined as MUST with cardinality 1..1 and not 1..n, I assume what this really wants to express is that there MUST be one note with the @csip:NOTETYPE attribute to record the SOFTWARE VERSION as specified in CSIP16 and not actually prohibiting further note elements?
SIP13, SIP19 and SIP30 then are defined as MAY with cardinality 0..1 and not 0..n for the archival creator, submitting and preservation agents respectively to allow for the addition of a note to record an identification code, again I believe not with the intent to actually prohibit more notes? SIP25 for the contact person agent then does not  specify the possibility of recording an identification code and lists the cardinality as 1..*.
I'm thinking that allowing a note element for an optional identification code could ultimately make sense for any agent, including the creating software. And the cardinalities are only meant to apply to notes with the additional attribute defined after, not note elements generally, but the written specification reads as restricting that, which reflects in how the test cases are currently written and how commons-ip currently validates.
I'd be happy for any clarifications.

Yes, whats stated are the mandatory and optional agents to use when following CSIP. If you want to add more agents you need to write your own extension to CSIP+SIP.
I'll look into the wording.

Yes, thats why I say I need to look into the wording since the stated notes elements are the ones we say that should be used not that you according to METS can have unlimited amount of note elements. If you want more note elements to be used that is something that you say and that's when you need to state it in an extension.

The suggestion is:

Update of wording with this PR suggestion #718

Board members acknowledgment of the issue:
Tick the box in front of you name to indicate that you have looked at the suggestion.

[ ] Karin Bredenberg (Kommunalförbundet Sydarkivera, chair)
[ ] Anders Bo Nielsen (National Archives of Denmark)
[ ] Anja Paulič (National Archives of Slovenia)
[ ] Arne-Kristian Groven (National Archives of Norway)
[ ] Gregor Zavrsnik (Geoarh)
[ ] Janet Anderson (Highbury Research & Development Ltd.)
[ ] Maya Bangerter (Swiss Federal Archives)
[ ] Miguel Ferreira (KEEP Solutions)
[ ] Stephen Mackey (Penwern Limited)
[ ] Sven Schlarb (Austrian Institute of Technology)

Voting
(Decision making will be carried out on the basis of majority voting by all eligible members of the Board. In the case of a tied vote, decisions will be made at the discretion of the Chair)
Tick the box in front of you name to say yes to the suggestion.

[ ] Karin Bredenberg (Kommunalförbundet Sydarkivera, chair)
[ ] Anders Bo Nielsen (National Archives of Denmark)
[ ] Anja Paulič (National Archives of Slovenia)
[ ] Arne-Kristian Groven (National Archives of Norway)
[ ] Gregor Zavrsnik (Geoarh)
[ ] Janet Anderson (Highbury Research & Development Ltd.)
[ ] Maya Bangerter (Swiss Federal Archives)
[ ] Miguel Ferreira (KEEP Solutions)
[ ] Stephen Mackey (Penwern Limited)
[ ] Sven Schlarb (Austrian Institute of Technology)

After reading the suggestion up for voting, I'm not sure it fully addresses the reported issue.

7 DILCIS Board members have acknowledge the issue
6 DILCIS Board members agree with the solution
The PR will be part of the next release of the specifications


n_views error

I have four cameras. When using a 5-cam-AVG-pre-trained weight file,
1. if I set n_views=4 doing dannce-train, there is a very common error:
`Could not load weights for finetune (likely because you are finetuning a previously finetuned network). Attempting to finetune from a full finetune model file.
Traceback (most recent call last):
File "f:\testdannce120\dannce\dannce\interface.py", line 1125, in dannce_train
*fargs
File "f:\testdannce120\dannce\dannce\engine\nets.py", line 1177, in finetune_AVG
model = renameLayers(model, weightspath)
File "f:\testdannce120\dannce\dannce\engine\nets.py", line 1405, in renameLayers
model.load_weights(weightspath, by_name=True)
File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\engine\training.py", line 2324, in load_weights
f, self.layers, skip_mismatch=skip_mismatch)
File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\saving\hdf5_format.py", line 768, in load_weights_from_hdf5_group_by_name
layer, weight_values, original_keras_version, original_backend)
File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\saving\hdf5_format.py", line 404, in preprocess_weights_for_loading
weights[0] = np.transpose(weights[0], (3, 2, 0, 1))
File "<array_function internals>", line 6, in transpose
File "E:\anaconda\envs\tfnew_25\lib\site-packages\numpy\core\fromnumeric.py", line 660, in transpose
return _wrapfunc(a, 'transpose', axes)
File "E:\anaconda\envs\tfnew_25\lib\site-packages\numpy\core\fromnumeric.py", line 57, in _wrapfunc
return bound(*args, **kwds)
ValueError: axes don't match array
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "E:\anaconda\envs\tfnew_25\Scripts\dannce-train-script.py", line 33, in
sys.exit(load_entry_point('dannce', 'console_scripts', 'dannce-train')())
File "f:\testdannce120\dannce\dannce\cli.py", line 66, in dannce_train_cli
dannce_train(params)
File "f:\testdannce120\dannce\dannce\interface.py", line 1131, in dannce_train
*fargs
File "f:\testdannce120\dannce\dannce\engine\nets.py", line 1255, in finetune_fullmodel_AVG
for layer in model.layers[1].layers:
AttributeError: 'Conv3D' object has no attribute 'layers'
`
#######################################################
2. if I set n_views=5, after duplicate Camera1, the dannce-train processing runs successfully; however, dannce-predict processing does not work, an error like:
Initializing Network... Loading model from .\DANNCE\train_results\AVG\weights.17-67.87837.hdf5 Traceback (most recent call last):   File "E:\anaconda\envs\tfnew_25\Scripts\dannce-predict-script.py", line 33, in <module>     sys.exit(load_entry_point('dannce', 'console_scripts', 'dannce-predict')())   File "f:\testdannce120\dannce\dannce\cli.py", line 54, in dannce_predict_cli     dannce_predict(params)   File "f:\testdannce120\dannce\dannce\interface.py", line 1543, in dannce_predict     "centered_euclidean_distance_3D": losses.centered_euclidean_distance_3D,   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\saving\save.py", line 202, in load_model     compile)   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\saving\hdf5_format.py", line 199, in load_model_from_hdf5     training_config, custom_objects), from_serialized=True)   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\training\tracking\base.py", line 522, in _method_wrapper     result = method(self, *args, **kwargs)   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\engine\training_v1.py", line 454, in compile     masks=self._prepare_output_masks())   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\engine\training_v1.py", line 1976, in _handle_metrics     target, output, output_mask))   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\engine\training_v1.py", line 1925, in _handle_per_output_metrics     with backend.name_scope(metric_name):   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\keras\backend.py", line 1039, in name_scope     return ops.name_scope_v2(name)   File "E:\anaconda\envs\tfnew_25\lib\site-packages\tensorflow\python\framework\ops.py", line 6647, in __init__     raise ValueError("name for name_scope must be a string.") ValueError: name for name_scope must be a string.
Have anyone met the errors before? Many thanks if give me some suggestions to fix them.

This looks like the same as #147 -- for the more recent errors, are you also trying to use a duplicate view? Please continue discussion in #147.


Update the action

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This should be resolved by changing:
https://github.com/sekwah41/upload-release-assets/blob/d1d5ea498ef078355322ed884029df152ba36389/package.json#L24
to
@actions.core 1.10.0
or?

Will do :) didnt realise anyone else was using my action :P

@v1.1.0 or its full hash still produces deprication warnings.
sekwah41/upload-release-assets@d33b61be358467363a2fd6532baabd54722875ed (version v1.1.1 of this fork) is working


Quadro to support http to https redirect

Brief issue description
Allow enabling of redirecting from http to https

@rudovjan Can we use https://www.npmjs.com/package/koa-sslify? Or we need to change quadro to use it?

We can. We will. :)
Do we want to make it turn on/off option for quadro? If yes I can make a PR for that.


Changed order of xml validating vs. opening SLD file path to stop crashes on windows due to file path length

Fixes issue identified in https://github.com/gicait/geoserver-rest/issues/147
I only ever tested in a Linux environment where the path length for a file is effectively unlimited, but it will fail in a Windows environment due to a length limit of 254 characters.

Thanks @iboates for submitting this PR. Since this is just a very minor change, I am accepting this without testing.


PB-for-desktop won't connect in Fedora 25

🤷🏽♂ Current Behaviour
After installing pb-for-desktop with the rpm package, running pb-for-desktop will show the PB desktop window and the tray icon, and try to connect without success (the window shows "Pushbullet connecting" and stay there).
I can see this in the log file :
[08:12:14 2017-03-16] [BROWSER] [main.html] [reachable] false
My first thoughts was that my firewalld config was interfering, but the problem persists even after stopping it.
🏡 Environmental Context
App Version
v3.9.99
Installation Type
RPM
Operating System
Fedora 25 x64
Note : I was waiting for an app like this that could work in any distrib, so a big thank you for this ! Keep up the good work !

@didli
Thanks for the accurate report. Please retry with the new v4.0.2 and report your findings.

Works perfectly fine now. The window showed up and asked for my credentials as expected. There's not even a warning in the log file ^^
That was fast. Thank you for your work !

@didli
Thanks for the status. Closing.


[Bug] Adding the same product multiple time and removing once causes removing all.

Adding the same product multiple time and removing once causes removing all.
Recoding:
https://github.com/vignesh-gupta/digibee-marketplace/assets/52371759/3911c7e2-9614-4327-9700-85bb1d2d2716
Potential Fixes:

Remove the first occurrence of the product
Allow user to add only 1 quantity product
On adding the same product twice increase the quantity

The issue is fixed. Going with approach-2


:zap: check vec obj_function detach

check the vectorized TNCO objective function.

In TNCO_L2O.py, the following codes check the env and switch between Sycamore and TensorTrain.
NodesList = NodesSycamoreN53M12
NumBanEdge = 0
# NodesList = get_nodes_list_of_tensor_train(len_list=100)
# NumBanEdge = 100


Fix having runnings in conversion

Hi, as @terehov mentioned in #9 ... Can you also update the docs @pejuam ?
If you do I will merge and update npm.


Add guppy to requirements.txt

src/geocode_addresses.py needs the geopy package which is not yet in the requirements.txt and needs to be there.
geopy==1.11.0

No need for that: it's already in conda_requirements.txt ; )
Maybe try a conda install --yes --file conda_requirements.txt…


feishin: 0.11.1 -> 0.12.1

Diff: https://github.com/jeffvli/feishin/compare/v0.11.1...v0.12.1
Changelog:

https://github.com/jeffvli/feishin/releases/tag/v0.12.0
https://github.com/jeffvli/feishin/releases/tag/v0.12.1

Maintainers: @onny and @jlbribeiro (me)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review pr 359962 output:
--------- Report for 'x86_64-linux' ---------
1 package built:
feishin

resulting binary works for me.


gh-40 Enable debug for TravisCI

Coverage increased (+0.9%) to 90.379% when pulling 94af83029ecf7162e614ac324a91918dd5a45eca on enable-debug-travis into 6d273a221f9b75830b70a6fcd5158d784b782b65 on master.


Plan pending confirmation even after all AH has signed

Plan id 1029
RAN076282

This issue seems to be already fixed. The plan that had this issue was signed by the AH around 4 months ago. Could not reproduce it.


Format awsconfig sample config correctly

Reflow change in commit 195f3a3 removed newlines in the config format.
This change reverts the sample config to the original formatting, which
matches the actual config format of a awsconfig file.
Signed-off-by: Katie McLaughlin<EMAIL_ADDRESS>

LGTM

LGTM


3.2.1 Fix for add_child() -> call_deferred

Working through your 1-bit course with the current version of Godot. For any github'ers, this should fix the errors:
E 0:00:03.478   add_child: Parent node is busy setting up children, add_node() failed. Consider using call_deferred("add_child", child) instead.
  <C++ Error>   Condition "data.blocked > 0" is true.
  <C++ Source>  scene/main/node.cpp:1177 @ add_child()
  <Stack Trace> {file_name}.gd:{line#} @ _exit_tree()

Just finished this project and see you covered these updates.