Maintenance Release: PhET-iO Hydrogen API updates

@samreid @kathy-phet @brent-phet @pixelzoom @AgustinVallejo @arouinfar
Hello! And welcome to a horrible MR testing issue. This is for testing https://github.com/phetsims/phet-io/issues/1974 and
supplemental info about things to test can be found in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110.
Please do reach out to me for any questions you may have. Please do the spot check you are used to, and then I have supplied any additional work to spot check below. Thank you!
Please note there is one usage of launchSimulationulation in the API documentation home page, but it will be fixed (just not in this batch of RCs.
acid-base-solutions 1.3 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] acid-base-solutions 1.3.2-rc.1
[ ] acid-base-solutions 1.3.2-rc.1 phet-io
[ ] acid-base-solutions 1.3.2-rc.1 phet-io Studio
[ ] acid-base-solutions 1.3.2-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

beers-law-lab 1.7 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] beers-law-lab 1.7.8-rc.1
[ ] beers-law-lab 1.7.8-rc.1 phet-io
[ ] beers-law-lab 1.7.8-rc.1 phet-io Studio
[ ] beers-law-lab 1.7.8-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

calculus-grapher 1.0 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] calculus-grapher 1.0.6-rc.1
[ ] calculus-grapher 1.0.6-rc.1 phet-io
[ ] calculus-grapher 1.0.6-rc.1 phet-io Studio
[ ] calculus-grapher 1.0.6-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

center-and-variability 1.1 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/scenery/issues/1550, https://github.com/phetsims/sun/issues/864, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] center-and-variability 1.1.2-rc.1
[ ] center-and-variability 1.1.2-rc.1 phet-io
[ ] center-and-variability 1.1.2-rc.1 phet-io Studio
[ ] center-and-variability 1.1.2-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

Combo Box patches (to be checked by QA):

[ ] patch 16: Keyboard traversal is broken when ComboBoxListBox contains invisible items or the order of items is changed.
[ ] patch 17: KeyboardListener bug is likely when listening to 'tab'.
[ ] patch 18: focusable bug fix for list box.
[ ] patch 19: Incorrect default sounds for selecting combo box items
[ ] patch 20: Default sound for ComboBoxListBox does not supports dynamic order and visibility of items.

circuit-construction-kit-dc 1.3 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] circuit-construction-kit-dc 1.3.9-rc.1
[ ] circuit-construction-kit-dc 1.3.9-rc.1 phet-io
[ ] circuit-construction-kit-dc 1.3.9-rc.1 phet-io Studio
[ ] circuit-construction-kit-dc 1.3.9-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

circuit-construction-kit-dc-virtual-lab 1.3 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] circuit-construction-kit-dc-virtual-lab 1.3.7-rc.1
[ ] circuit-construction-kit-dc-virtual-lab 1.3.7-rc.1 phet-io
[ ] circuit-construction-kit-dc-virtual-lab 1.3.7-rc.1 phet-io Studio
[ ] circuit-construction-kit-dc-virtual-lab 1.3.7-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

concentration 1.7 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] concentration 1.7.8-rc.1
[ ] concentration 1.7.8-rc.1 phet-io
[ ] concentration 1.7.8-rc.1 phet-io Studio
[ ] concentration 1.7.8-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

density 1.1 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/scenery/issues/1550, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] density 1.1.5-rc.1
[ ] density 1.1.5-rc.1 phet-io
[ ] density 1.1.5-rc.1 phet-io Studio
[ ] density 1.1.5-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

friction 1.6 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] friction 1.6.9-rc.1
[ ] friction 1.6.9-rc.1 phet-io
[ ] friction 1.6.9-rc.1 phet-io Studio
[ ] friction 1.6.9-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

geometric-optics 1.3 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/scenery/issues/1550, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] geometric-optics 1.3.4-rc.1
[ ] geometric-optics 1.3.4-rc.1 phet-io
[ ] geometric-optics 1.3.4-rc.1 phet-io Studio
[ ] geometric-optics 1.3.4-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

Combo Box patches (to be checked by QA):

[ ] patch 16: Keyboard traversal is broken when ComboBoxListBox contains invisible items or the order of items is changed.
[ ] patch 17: KeyboardListener bug is likely when listening to 'tab'.
[ ] patch 18: focusable bug fix for list box.
[ ] patch 19: Incorrect default sounds for selecting combo box items
[ ] patch 20: Default sound for ComboBoxListBox does not supports dynamic order and visibility of items.

geometric-optics-basics 1.3 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/scenery/issues/1550, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] geometric-optics-basics 1.3.4-rc.1
[ ] geometric-optics-basics 1.3.4-rc.1 phet-io
[ ] geometric-optics-basics 1.3.4-rc.1 phet-io Studio
[ ] geometric-optics-basics 1.3.4-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

Combo Box patches (to be checked by QA):

[ ] patch 16: Keyboard traversal is broken when ComboBoxListBox contains invisible items or the order of items is changed.
[ ] patch 17: KeyboardListener bug is likely when listening to 'tab'.
[ ] patch 18: focusable bug fix for list box.
[ ] patch 19: Incorrect default sounds for selecting combo box items
[ ] patch 20: Default sound for ComboBoxListBox does not supports dynamic order and visibility of items.

graphing-quadratics 1.3 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] graphing-quadratics 1.3.4-rc.1
[ ] graphing-quadratics 1.3.4-rc.1 phet-io
[ ] graphing-quadratics 1.3.4-rc.1 phet-io Studio
[ ] graphing-quadratics 1.3.4-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

gravity-and-orbits 1.6 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974, getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper: phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974, phetmarks-perennial-url: phetsims/phet-io#1974, add readonly for GAO1.6: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] gravity-and-orbits 1.6.16-rc.2
[ ] gravity-and-orbits 1.6.16-rc.2 phet-io
[ ] gravity-and-orbits 1.6.16-rc.2 phet-io Studio
[ ] gravity-and-orbits 1.6.16-rc.2 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

greenhouse-effect 1.2 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/scenery/issues/1550, https://github.com/phetsims/sun/issues/864, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] greenhouse-effect 1.2.4-rc.1
[ ] greenhouse-effect 1.2.4-rc.1 phet-io
[ ] greenhouse-effect 1.2.4-rc.1 phet-io Studio
[ ] greenhouse-effect 1.2.4-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

Combo Box patches (to be checked by QA):

[ ] patch 16: Keyboard traversal is broken when ComboBoxListBox contains invisible items or the order of items is changed.
[ ] patch 17: KeyboardListener bug is likely when listening to 'tab'.
[ ] patch 18: focusable bug fix for list box.
[ ] patch 19: Incorrect default sounds for selecting combo box items
[ ] patch 20: Default sound for ComboBoxListBox does not supports dynamic order and visibility of items.

molecule-polarity 1.3 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/scenery/issues/1550, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] molecule-polarity 1.3.4-rc.1
[ ] molecule-polarity 1.3.4-rc.1 phet-io
[ ] molecule-polarity 1.3.4-rc.1 phet-io Studio
[ ] molecule-polarity 1.3.4-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

molecule-shapes 1.6 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] molecule-shapes 1.6.7-rc.1
[ ] molecule-shapes 1.6.7-rc.1 phet-io
[ ] molecule-shapes 1.6.7-rc.1 phet-io Studio
[ ] molecule-shapes 1.6.7-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

molecule-shapes-basics 1.6 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] molecule-shapes-basics 1.6.7-rc.1
[ ] molecule-shapes-basics 1.6.7-rc.1 phet-io
[ ] molecule-shapes-basics 1.6.7-rc.1 phet-io Studio
[ ] molecule-shapes-basics 1.6.7-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

my-solar-system 1.2 (https://github.com/phetsims/scenery/issues/1550)
No phet-io changes, just a separate small bug, please spot check

[ ] my-solar-system 1.2.5-rc.1

my-solar-system 1.3 (https://github.com/phetsims/sun/issues/864, https://github.com/phetsims/scenery/issues/1550,
https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862, phetioClientRename: phetsims/phet-io#1965)

[ ] my-solar-system 1.3.0-rc.2
[ ] my-solar-system 1.3.0-rc.2 phet-io
[ ] my-solar-system 1.3.0-rc.2 phet-io Studio
[ ] my-solar-system 1.3.0-rc.2 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

Combo Box patches (to be checked by QA):

[ ] patch 16: Keyboard traversal is broken when ComboBoxListBox contains invisible items or the order of items is changed.
[ ] patch 17: KeyboardListener bug is likely when listening to 'tab'.
[ ] patch 18: focusable bug fix for list box.
[ ] patch 19: Incorrect default sounds for selecting combo box items
[ ] patch 20: Default sound for ComboBoxListBox does not supports dynamic order and visibility of items.

natural-selection 1.5 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974, unlinkIndex: phetsims/phet-io#1974, getSimulationURL:
phetsims/phet-io#1974, addSimulationInitializedListener: phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974,
displaySimulation: phetsims/phet-io#1974, setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide:
phetsims/phet-io#1974, getPhetioElementState: phetsims/phet-io#1974, phetioClientRename: phetsims/phet-io#1965)

[ ] natural-selection 1.5.3-rc.1
[ ] natural-selection 1.5.3-rc.1 phet-io
[ ] natural-selection 1.5.3-rc.1 phet-io Studio
[ ] natural-selection 1.5.3-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

ph-scale 1.6 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] ph-scale 1.6.10-rc.1
[ ] ph-scale 1.6.10-rc.1 phet-io
[ ] ph-scale 1.6.10-rc.1 phet-io Studio
[ ] ph-scale 1.6.10-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

ph-scale-basics 1.6 (getBasePhetioTypeName, https://github.com/phetsims/phet-io/issues/1974,
getPhetioOverridesFile, https://github.com/phetsims/phet-io/issues/1974, createFromStandardPhetioWrapper:
phetsims/phet-io#1974, getDOMElementID: phetsims/phet-io#1974, SIMULATION_VERSION_STRING: phetsims/phet-io#1974,
phetmarks-perennial-url: phetsims/phet-io#1974, SIMULATION_VERSION_MAJOR_MINOR_STRING1: phetsims/phet-io#1974,
unlinkIndex: phetsims/phet-io#1974, getSimulationURL: phetsims/phet-io#1974, addSimulationInitializedListener:
phetsims/phet-io#1974, launchSimulation: phetsims/phet-io#1974, displaySimulation: phetsims/phet-io#1974,
setSimulationStartedMetadata: phetsims/phet-io#1974, clientGuide: phetsims/phet-io#1974, getPhetioElementState:
phetsims/phet-io#1974, keyboardTraversal:
phetsims/sun#859, https://github.com/phetsims/sun/issues/861, https://github.com/phetsims/sun/issues/862,
phetioClientRename: phetsims/phet-io#1965)

[ ] ph-scale-basics 1.6.9-rc.1
[ ] ph-scale-basics 1.6.9-rc.1 phet-io
[ ] ph-scale-basics 1.6.9-rc.1 phet-io Studio
[ ] ph-scale-basics 1.6.9-rc.1 phet-io Wrapper Index

To be checked by @brent-phet: See https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110 for details for below checkboxes. Wrapper Index.

[ ] Studio: Run script in console from https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110
[ ] Studio: Confirm PhetioEngineIO method doc
[ ] Studio: Confirm IndexedNodeIO method doc (only for sims with an instrumented combo box)
[ ] Wrapper Index: Confirm Client->PhetioClient rename
[ ] API Documentation: Confirm Client->PhetioClient rename on the home page. Please note that many methods for PhetioClient will still refer to Client (that is ok)
[ ] API Documentation: Client class is there, but says it is deprecated (and to use PhetioClient)
[ ] API Documentation: PhetioClient class is there, and has methods renamed + deprecated old method (see list in https://github.com/phetsims/phet-io/issues/1974#issuecomment-1863762110)
[ ] PhET-iO Guide: Confirm Client->PhetioClient rename

After discussing with @brent-phet, he and I are going to take on the phet-io specific checks. This means QA only needs to do the combobox checkboxes and the general spot checking checkboxes (I added a spot check for the wrapper index, to briefly click through a few wrappers and make sure they are working well).

OK. Thanks

@zepumph Should we change LaunchSimOptions to LaunchSimulationOptions for consistency?

@zepumph I can't confirm patches 16 and 20 for CaV. The comboboxes are in the simulation and localization tabs of the preferences menu. I don't see any way to hide or reorder items.

@zepumph I do not see IndexedNodeIO in CaV:
https://phet-dev.colorado.edu/html/center-and-variability/1.1.2-rc.1/phet-io/wrappers/studio/

That is expected. Its ComboBox isn't instrumented. Same reason why https://github.com/phetsims/qa/issues/1017#issuecomment-1868038876 is ok.

@zepumph I just noticed this one too, so same question? loadUnbuiltSimVersion to loadUnbuiltSimulationVersion?

FYI - I spot-checked this API JSON, too.
https://phet-dev.colorado.edu/html/geometric-optics/1.3.4-rc.1/phet-io/geometric-optics-phet-io-api.json

Please make a new issue, loadUnbuiltSimVersion shouldn't be in the doc.

@zepumph  MSS https://phet-dev.colorado.edu/html/my-solar-system/1.3.0-rc.2/phet-io/wrappers/studio/
PhetioEngineIO:
setSimStartedMetadata is NOT marked as deprecated.

@zepumph just wanted to confirm that the spot check I am performing for MSS version 1.2 is to see if shift + tab closes the combobox and moves focus to the item before the combobox? Should the FF warnings be gone from 1.2 or only from 1.3?

QA is done here. Just waiting for a response to https://github.com/phetsims/qa/issues/1017#issuecomment-1874489305.

I don't see checks for NS 1.5. Is that ready? Also I'm assuming unchecked combobox checks are because there isn't a needed feature (like keyboard nav).

. . . for MSS version 1.2 is to see if shift + tab closes the combobox and moves focus to the item before the combobox?

Correct. That was the only patch made

Should the FF warnings be gone from 1.2 or only from 1.3?

I don't understand what an FF warning is. Is there a paper trail? Also happy to talk.

I spoke with @brent-phet and his checks have been completed and problems fixed in branches.

Should the FF warnings be gone from 1.2 or only from 1.3?

you had written something earlier in the issue about firefox: https://github.com/phetsims/scenery/issues/1550#issuecomment-1538667990
I still see all those warnings in 1.2 but not in 1.3.

Sorry! Missed NS! I will do it now.

you had written something earlier in the issue about firefox: https://github.com/phetsims/scenery/issues/1550#issuecomment-1538667990

Ahh thanks. Yes, that is totally fine, no need to worry about that.

OK done!

Excellent. I'll proceed with deploying. Thanks so much to all testers!


xfce.xfce4-screensaver: 4.18.3 -> 4.18.4

https://gitlab.xfce.org/apps/xfce4-screensaver/-/compare/xfce4-screensaver-4.18.3...xfce4-screensaver-4.18.4

This now exits early on Wayland sessions.
xfdesktop no longer does xfce_workspace_migrate_backdrop_image so we need to take care missing last-image.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

nixpkgs-reviewd workflow started

Extra args: ``
Free space: true
Who asked: lucasew

TARGETS

x86_64-linux: true
x86_64-darwin: false
aarch64-darwin: false

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12448016968

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367048

x86_64-linux

:white_check_mark: 2 packages built:

xfce.xfce4-screensaver
xfce.xfce4-screensaver.dev

nixpkgs-reviewd workflow started

Extra args: -p nixosTests.xfce-wayland
Free space: true
Who asked: lucasew

TARGETS

x86_64-linux: true
x86_64-darwin: false
aarch64-darwin: false

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12448110739

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367048

x86_64-linux

:white_check_mark: 1 test built:

nixosTests.xfce-wayland


Power Full DuktapeJava On Android

hi， i have a simllar project。 https://github.com/gubaojian/DuktapeJava
we can develop together.

Interesting that I didn't find it while I checked if something like this for Java already exists. My Java binding is pretty much finished, it just needs some test cases and needs to be published to maven central.


[WIP] Upgrade Cypress to 5

Description
Explain a little about the changes at a high level.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
echo "Code goes here"

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 9189ec15d8de08e72b459e48d84b8fe3c60bfa13

here is a story if you want one :) https://dp3.atlassian.net/browse/MB-3683

here is a story if you want one :) https://dp3.atlassian.net/browse/MB-3683

ooh thanks!

lol if we wait long enough cypress may fix enough memory leak issues to fix the flaky tests on their own. ;p
look only 7 failed with 5.1.0:
https://app.circleci.com/pipelines/github/transcom/mymove/20566/workflows/5d5e4d1c-b1a0-4e44-9476-0fa46df637a3/jobs/318204

Closing since Cypress was upgraded in https://github.com/transcom/mymove/pull/4825


IPv6 MISRA checks and changes.

Description
When checking the labs/ipv6_multi branch with Coverity for MISRA appliance, it couldn't find any violations against mandatory rules.
In this patch I solved a couple of violation against "required" rules, such as 2.2: "There shall be no dead code", code that isn't ever used. I did that by adding the proper #ifdef's.
In the FreeRTOS+TCP library, heavy use was made of "static inline functions". MISRA complains about them. I'm afraid that the quality of the library would become less when they are all removed, both in safety ( type checking ! ), and performance. ( in-lining code that is often used ).
The alternative would be using global functions ( slow ) , the used or function-like macro's ( risky ).
Also there are macro's that were used to allow certain casts from uint_8* to a struct pointer. Coverity thinks that these are functions that are never used: dead code.
Beside MISRA changes, I copied a few changes to the logging.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It gets a build error because the enum ePingReplyStatus_t is unknown in:
void vApplicationPingReplyHook( ePingReplyStatus_t eStatus, uint16_t usIdentifier )

This can be solved by making the declaration dependent on the macro ipconfigSUPPORT_OUTGOING_PINGS. Could you do that Aniruddha?

A summary of what I did since commit "Removed dead code and solved all required MISRA violations" :
The struct NetworkAddressingParameters_t was a left-over from the IPv4 release. It is not used in the /multi release.
The structs IGMPHeader_t and PseudoHeader_t were prepared but not yet in use, thus dropped.
One field name coincided with a struct name: ICMPHeader_IPv6_t::xIPv6_Address with struct xICMPHeader_IPv6. I changed the name of the field to xICMPHeaderIPv6.
The field name ICMPPacket_IPv6_t::x'ICMPHeader_IPv6 coincided with struct xICMPHeader_IPv6. I changed the field name to xICMPHeaderIPv6.
Much the same for ProtocolHeaders_t::xICMPHeader_IPv6 and struct xICMPHeader_IPv6, I renamed the field.
The field name NetworkBufferDescriptor_t::xIPv6_Address also changed its name to xIPv6Address.
These and many other inline function became global function:
	uint32_t ulChar2u32( const uint8_t * pucPtr );
	uint16_t usChar2u16( const uint8_t * pucPtr );
	BaseType_t xSocketValid( Socket_t xSocket );

Also the min/max and round functions became global in stead of static inline.
Added dependencies on config macros, for instance here:
#if ( ipconfigUSE_RA != 0 )
    void vReceiveNA( NetworkBufferDescriptor_t * const pxNetworkBuffer );
#endif

Removed several functions because they were never used (dead code), for instance 'CONFIRM_EP_v4' and 'CONFIRM_EP_v6'.
Added some macro's to 'FreeRTOSIPConfigDefaults.h' to make sure they are defined when tested.

It gets a build error because the enum ePingReplyStatus_t is unknown in:
void vApplicationPingReplyHook( ePingReplyStatus_t eStatus, uint16_t usIdentifier )

This can be solved by making the declaration dependent on the macro ipconfigSUPPORT_OUTGOING_PINGS. Could you do that Aniruddha?
The declaration of vApplicationPingReplyHook is in main.c.

Done

I pushed some formatting changes ( which removes tabs in comments ).
And then I applied Uncrustify again.
Now I see many more formatting problems, however those files are not part of this PR:
/test/unit-test/ConfigFiles/FreeRTOSConfig.h
/portable/BufferManagement/BufferAllocation_1.c
/portable/NetworkInterface/pic32mzef/NetworkInterface_wifi.c
/portable/NetworkInterface/STM32Hxx/stm32hxx_hal_eth.h
/portable/NetworkInterface/ATSAM4E/ethernet_phy.c
/portable/NetworkInterface/ATSAM4E/gmac.c
/portable/NetworkInterface/ksz8851snl/ksz8851snl.c
/portable/NetworkInterface/DriverSAM/gmac_SAM.c
/tools/tcp_utilities/plus_tcp_demo_cli.c

PS. The function FreeRTOS_inet_ntop6() still contains a call to snprintf(), in order to print a hex number in an IPv6 address.
Will will keep it and submit that after this PR.


Add normalize=True parameter

Add normalize=True parameter that normalizes data (optional to user) to both classes so that check_estimator can be applied in tests.

Are there any plans to do this? I assume you'd use l2 norm on the input data? I assumed spherecluster already did this and got bit. Will be implementing this soon myself.

Until this is implemented, you should be able to use sklearn's built-in
normalize() to normalize your vectors (or the equivalent class version
which can be included easily in an sklearn pipeline)
Cheers
Jason
On Thu, Jun 29, 2017 at 5:35 PM B Roberts<EMAIL_ADDRESS>wrote:

Are there any plans to do this? I assume you'd use l2 norm on the input
data? I assumed spherecluster already did this and got bit. Will be
implementing this soon myself.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/clara-labs/spherecluster/issues/1#issuecomment-312115431,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABk3vIjwmUwH99FZS_DhqLHW6k88VoG4ks5sJBi8gaJpZM4Jhs3G
.

--
Sent from Gmail Mobile

Cool. Thanks, that's what I'll do then.

Addressed by #5, pull version 0.1.5 or higher for this feature.


New cameras and fixes.

Fixed the pinhole camera to match the rasterization perspective camera. Added an ortho and spherical cameras.
Minor: Modified the cmake so I can have the headers included in MSVC, and also made rvpt the start up project.

Changes look good.
Is there a reason to keep displacement in the camera class? Seems like it was made superfluous.


Return key is extremely slow in large files

Given a 4,000-line file (sorry), in this case PHP (even more sorry), the return key causes long hanging. It seems to be caused by:
'atom-pane atom-text-editor[data-grammar~="html"]:not([mini]):not(.autocomplete-active), atom-pane atom-text-editor[data-grammar~="xml"]:not([mini]):not(.autocomplete-active)':
  'enter': 'emmet:insert-formatted-line-break-only'

Unsetting the binding resolves the issue for me.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

+1. I've been having this issue since I started using Atom a couple weeks ago. Assumed Atom was the cause, but you're right, it's emmet.
Can you let us know how you unset the keybinding? I tried copying that keybinding to keymap.cson, but a blank string still causes it to hang, and unset! prevents the enter key from working at all. Quite a bit of Googling and Atom keybindings seem far from trivial.

My bad. I fixed it by changing it to:
'enter': 'editor:newline'
You might need to restart Atom for it to work.

Ah, nice. I feel like I tried everything except that. Cheers mate!

+1, and can't make the enter editor:newline work either.

I was almost changed to vscode due to this issue and returned back looking for a solution.
Atom must scan file size and if somebody open a large file, ask them if they want to keep emmet keymap or not.


failed compile on aarch64 with openfst=1.8.2 and pynini=2.1.5

hi, I tried to compile openfst and pynini on a aarch64 machine. Although the version of openfst and pynini match, I still met with some troubles after a successful installation of openfst. BTW, I want to install pynini under a virtual environment/home/ma-user/anaconda3/envs/PyTorch-2.1.0. Here is the commands:
## compile openfst
openfst_version=openfst-1.8.2
tar -zxvf $openfst_version.tar.gz
chmod 755 -R $PWD/$openfst_version/
cd $PWD/$openfst_version/
./configure --enable-grm --prefix=/home/ma-user/anaconda3/envs/PyTorch-2.1.0 # venv path
make -j8
make install
cd ../

## compile pynini
pynini_version=pynini-2.1.5
tar -zxvf $pynini_version.tar.gz
cd ./$pynini_version/
python setup.py install
cd ../

The error is posed by the pynini building:
  2065	copying pywrapfst/py.typed -> build/lib.linux-aarch64-cpython-39/pywrapfst
  2066	copying pynini/examples/py.typed -> build/lib.linux-aarch64-cpython-39/pynini/examples
  2067	copying pynini/lib/py.typed -> build/lib.linux-aarch64-cpython-39/pynini/lib
  2068	copying pynini/export/py.typed -> build/lib.linux-aarch64-cpython-39/pynini/export
  2069	running build_ext
  2070	building '_pywrapfst' extension
  2071	creating build/temp.linux-aarch64-cpython-39
  2072	creating build/temp.linux-aarch64-cpython-39/extensions
  2073	gcc -pthread -B /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O3 -Wall -fPIC -O3 -isystem /home/ma-user/anaconda3/envs/PyTorch-2.1.0/include -fPIC -O3 -isystem /home/ma-user/anaconda3/envs/PyTorch-2.1.0/include -fPIC -I/home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9 -c extensions/_pywrapfst.cpp -o build/temp.linux-aarch64-cpython-39/extensions/_pywrapfst.o -std=c++17 -Wno-register -Wno-deprecated-declarations -Wno-unused-function -Wno-unused-local-typedefs -funsigned-char
  2074	extensions/_pywrapfst.cpp: In function ‘PyObject* __pyx_pf_10_pywrapfst_6Weight_4__float__(__pyx_obj_10_pywrapfst_Weight*)’:
  2075	extensions/_pywrapfst.cpp:11659:40: error: invalid cast from type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to type ‘PyObject*’ {aka ‘_object*’}
  2076	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2077	      |                                        ^~~~~~~~~~~~~~~~~~~~~
  2078	extensions/_pywrapfst.cpp:1470:43: note: in definition of macro ‘likely’
  2079	 1470 |   #define likely(x)   __builtin_expect(!!(x), 1)
  2080	      |                                           ^
  2081	/home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9/object.h:130:42: note: in expansion of macro ‘_PyObject_CAST_CONST’
  2082	  130 | #define Py_IS_TYPE(ob, type) _Py_IS_TYPE(_PyObject_CAST_CONST(ob), type)
  2083	      |                                          ^~~~~~~~~~~~~~~~~~~~
  2084	/home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9/floatobject.h:24:32: note: in expansion of macro ‘Py_IS_TYPE’
  2085	   24 | #define PyFloat_CheckExact(op) Py_IS_TYPE(op, &PyFloat_Type)
  2086	      |                                ^~~~~~~~~~
  2087	extensions/_pywrapfst.cpp:3283:10: note: in expansion of macro ‘PyFloat_CheckExact’
  2088	 3283 | ((likely(PyFloat_CheckExact(obj))) ?  PyFloat_AS_DOUBLE(obj) :\
  2089	      |          ^~~~~~~~~~~~~~~~~~
  2090	extensions/_pywrapfst.cpp:11659:15: note: in expansion of macro ‘__Pyx_PyObject_AsDouble’
  2091	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2092	      |               ^~~~~~~~~~~~~~~~~~~~~~~
  2093	In file included from /home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9/Python.h:97,
  2094	                 from extensions/_pywrapfst.cpp:46:
  2095	extensions/_pywrapfst.cpp:11659:40: error: invalid cast from type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to type ‘PyObject*’ {aka ‘_object*’}
  2096	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2097	      |                                        ^~~~~~~~~~~~~~~~~~~~~
  2098	/home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9/floatobject.h:51:51: note: in definition of macro ‘PyFloat_AS_DOUBLE’
  2099	   51 | #define PyFloat_AS_DOUBLE(op) (((PyFloatObject *)(op))->ob_fval)
  2100	      |                                                   ^~
  2101	extensions/_pywrapfst.cpp:11659:15: note: in expansion of macro ‘__Pyx_PyObject_AsDouble’
  2102	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2103	      |               ^~~~~~~~~~~~~~~~~~~~~~~
  2104	extensions/_pywrapfst.cpp:11659:40: error: invalid cast from type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to type ‘PyObject*’ {aka ‘_object*’}
  2105	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2106	      |                                        ^~~~~~~~~~~~~~~~~~~~~
  2107	extensions/_pywrapfst.cpp:1470:43: note: in definition of macro ‘likely’
  2108	 1470 |   #define likely(x)   __builtin_expect(!!(x), 1)
  2109	      |                                           ^
  2110	/home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9/object.h:130:42: note: in expansion of macro ‘_PyObject_CAST_CONST’
  2111	  130 | #define Py_IS_TYPE(ob, type) _Py_IS_TYPE(_PyObject_CAST_CONST(ob), type)
  2112	      |                                          ^~~~~~~~~~~~~~~~~~~~
  2113	/home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9/longobject.h:16:31: note: in expansion of macro ‘Py_IS_TYPE’
  2114	   16 | #define PyLong_CheckExact(op) Py_IS_TYPE(op, &PyLong_Type)
  2115	      |                               ^~~~~~~~~~
  2116	extensions/_pywrapfst.cpp:3284:9: note: in expansion of macro ‘PyLong_CheckExact’
  2117	 3284 |  likely(PyLong_CheckExact(obj)) ?\
  2118	      |         ^~~~~~~~~~~~~~~~~
  2119	extensions/_pywrapfst.cpp:11659:15: note: in expansion of macro ‘__Pyx_PyObject_AsDouble’
  2120	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2121	      |               ^~~~~~~~~~~~~~~~~~~~~~~
  2122	extensions/_pywrapfst.cpp:11659:40: error: invalid cast from type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to type ‘PyObject*’ {aka ‘_object*’}
  2123	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2124	      |                                        ^~~~~~~~~~~~~~~~~~~~~
  2125	extensions/_pywrapfst.cpp:3285:18: note: in definition of macro ‘__Pyx_PyObject_AsDouble’
  2126	 3285 |  PyLong_AsDouble(obj) : __Pyx__PyObject_AsDouble(obj))
  2127	      |                  ^~~
  2128	extensions/_pywrapfst.cpp:11659:40: error: invalid cast from type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to type ‘PyObject*’ {aka ‘_object*’}
  2129	11659 |   __pyx_t_2 = __Pyx_PyObject_AsDouble(((PyObject *)__pyx_t_1)); if (unlikely(__pyx_t_2 == ((double)((double)-1)) && PyErr_Occurred())) __PYX_ERR(0, 497, __pyx_L1_error)
  2130	      |                                        ^~~~~~~~~~~~~~~~~~~~~
  2131	extensions/_pywrapfst.cpp:3285:50: note: in definition of macro ‘__Pyx_PyObject_AsDouble’
  2132	 3285 |  PyLong_AsDouble(obj) : __Pyx__PyObject_AsDouble(obj))
  2133	      |                                                  ^~~
  2134	error: command '/usr/bin/gcc' failed with exit code 1

Why don't you try this with OpenFst 1.8.3. and Pynini 2.1.6.post1 instead? Those are the most recent versions and I believe everything is working as expected for them.

hi, thanks a lot for your timely response. I just tried as you suggested but met with new problems.
# install openfst
openfst_version=openfst-1.8.3
tar -zxvf $openfst_version.tar.gz
chmod 755 -R $PWD/$openfst_version/
cd $PWD/$openfst_version/
./configure --enable-grm --prefix=/home/ma-user/anaconda3/envs/PyTorch-2.1.0 # install openfst to venv
make -j8
make install
cd ../

# upgrade pip
python -m pip install --upgrade pip

pip install \
	--config-settings="--build-option=build_ext" \
	--upgrade \
	--verbose \
	pynini==2.1.6.post1

The error report is as follows:
  1958	  copying pynini/export/py.typed -> build/lib.linux-aarch64-cpython-39/pynini/export
  1959	  copying pynini/lib/BUILD.bazel -> build/lib.linux-aarch64-cpython-39/pynini/lib
  1960	  copying pynini/lib/py.typed -> build/lib.linux-aarch64-cpython-39/pynini/lib
  1961	  copying pynini/examples/BUILD.bazel -> build/lib.linux-aarch64-cpython-39/pynini/examples
  1962	  copying pynini/examples/py.typed -> build/lib.linux-aarch64-cpython-39/pynini/examples
  1963	  running build_ext
  1964	  building '_pywrapfst' extension
  1965	  creating build/temp.linux-aarch64-cpython-39
  1966	  creating build/temp.linux-aarch64-cpython-39/extensions
  1967	  g++ -pthread -B /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O3 -Wall -fPIC -O3 -isystem /home/ma-user/anaconda3/envs/PyTorch-2.1.0/include -fPIC -O3 -isystem /home/ma-user/anaconda3/envs/PyTorch-2.1.0/include -fPIC -I/home/ma-user/anaconda3/envs/PyTorch-2.1.0/include/python3.9 -c extensions/_pywrapfst.cpp -o build/temp.linux-aarch64-cpython-39/extensions/_pywrapfst.o -std=c++17 -Wno-register -Wno-deprecated-declarations -Wno-unused-function -Wno-unused-local-typedefs -funsigned-char
  1968	  g++ -pthread -B /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O3 -Wall -fPIC -O3 -isystem /home/ma-user/anaconda3/envs/PyTorch-2.1.0/include -fPIC -O3 -isystem /home/ma-user/anaconda3/envs/PyTorch-2.1.0/include -pthread -B /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat -shared build/temp.linux-aarch64-cpython-39/extensions/_pywrapfst.o -lfstfarscript -lfstfar -lfstscript -lfst -lm -ldl -o build/lib.linux-aarch64-cpython-39/_pywrapfst.cpython-39-aarch64-linux-gnu.so
  1969	  /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat/ld: cannot find -lfstfarscript: No such file or directory
  1970	  /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat/ld: cannot find -lfstfar: No such file or directory
  1971	  /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat/ld: cannot find -lfstscript: No such file or directory
  1972	  /home/ma-user/anaconda3/envs/PyTorch-2.1.0/compiler_compat/ld: cannot find -lfst: No such file or directory
  1973	  collect2: error: ld returned 1 exit status
  1974	  error: command '/usr/bin/g++' failed with exit code 1
  1975	  error: subprocess-exited-with-error
  1976
  1977	  × Building wheel for pynini (pyproject.toml) did not run successfully.
  1978	  │ exit code: 1
  1979	  ╰─> See above for output.
  1980
  1981	  note: This error originates from a subprocess, and is likely not a problem with pip.
  1982	  full command: /home/ma-user/anaconda3/envs/PyTorch-2.1.0/bin/python /home/ma-user/anaconda3/envs/PyTorch-2.1.0/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py build_wheel /tmp/tmpnv6es0mi
  1983	  cwd: /tmp/pip-install-2yg9gi81/pynini_ecd777a06d244c2fb737cba81eafb1c0
  1984	  Building wheel for pynini (pyproject.toml): finished with status 'error'

This is a good sign; I think you're close. It's failing at linking because it doesn't know that you put the OpenFst libraries in a non-standard prefix. There are three things you can try:

Try passing environmental variables for LD_LIBRARY_PATH. I think it would look like LD_LIBRARY_PATH=/home/ma-user/anaconda3/envs/PyTorch-2.1.0/lib python setup.py. I am not sure if this will work but it's the first thing I'd try.
Add these flags to extra_link_args argument to the two calls to Extension here and here
Alternatively, don't use a prefix when you install OpenFst; it'll install to /usr/local/lib and it'll "just work".

This is not a problem per se with Pynini's build system; this is a same issue with linking compiled software against libraries in non-standard locations that strikes basically every compiled UNIX library.

This is a good sign; I think you're close. It's failing at linking because it doesn't know that you put the OpenFst libraries in a non-standard prefix. There are three things you can try:

Try passing environmental variables for LD_LIBRARY_PATH. I think it would look like LD_LIBRARY_PATH=/home/ma-user/anaconda3/envs/PyTorch-2.1.0/lib python setup.py. I am not sure if this will work but it's the first thing I'd try.
Add these flags to extra_link_args argument to the two calls to Extension here and here.
Alternatively, don't use a prefix when you install OpenFst; it'll install to /usr/local/lib and it'll "just work".

This is not a problem per se with Pynini's build system; this is a same issue with linking compiled software against libraries in non-standard locations that strikes basically every compiled UNIX library.

Thanks. Ok, I will have a try as you suggested.

Any luck @huskyachao ?

Any luck @huskyachao ?

Hi, kylebgorman. Thanks for your attention. It seems that there are still some problems about the installation. I will give a feedback later.

Any luck @huskyachao ?

Hi, kylebgorman. Thanks for your attention. It seems that there are still some problems about the installation. I will give a feedback later.

IS Successful now, How to do?

@kylebgorman  @huskyachao  @xiucuiZhu Hello there!
I encountered the same error ("cannot find -lfstfarscript") when installing pynini 2.16 on aarch64. I managed to resolve this by reinstalling OpenFST with some additional features enabled. Here's the command I used:
./configure --enable-far --enable-pdt --enable-mpdt --enable-const-fsts --enable-compact-fsts --enable-compress --enable-linear-fsts --enable-lookahead-fsts --enable-ngram-fsts
make && make install

After running this configuration, the "cannot find -lfstfarscript" problem was solved.
If you encounter another error like "could not find fst/someheader.h", you might try adding the OpenFST library path to your LD_LIBRARY_PATH. For example:
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/path/to/openfst-1.8.3/src/include

Also, make sure to include the appropriate header files in your include path.
I hope this helps :D


[Attestation] Fix broken link

Description
I'm unsure if the aka.ms link being used was deleted for some reason, but nightly pipelines started failing because the README's PyPI link was broken. This PR replaces the aka.ms link with a regular pypi.org one to fix the issue.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/check-enforcer override

CI failures are unrelated to this PR.


Getting an error: sh: 1: ts-node: not found

When doing the "npm run start" part of the tutorial, it tries starting and then gives me this error:
sh: 1: ts-node: not found
Not sure what that means. Any help would be greatly appreciated!

Disclosure: I am not associated with this project. I was simply trying to run it as well and got the same error.
I was able to fix though by running the following commands:
npm install tslib
In my case, I also had to install tslib:
npm install tslib
Once those two were installed, I could run the program by typing:
npm run start
Hope that helps!

@tracer-tick , ts-lib will be installed when you use npm install command.
https://github.com/phamleduy04/texas-dps-scheduler/blob/main/package.json#L43C1-L43C23

Awesome - thank you

If using terminal under VSCode, just do npm update to install all the dependency packages for this project.

I also got the error but followed the steps on this forum and it resolved! thanks all

Was getting the error, then typed npm install tslib   -    after that, works fine.


Use model tflite

Hello, how can I use the model on android with tflite? I have to translate all function from Python to Java? So I need I library like Numpy for java?

https://medium.com/@estebanuri/real-time-face-mask-recognition-in-android-with-tensorflow-lite-215df6327265


fix eslint errors

Fixes all ESLint Errors

babelHelpers.ts: added an ignore statement for@typescript-eslint/ban-ts-comment because this is auto-generated js
Don't use '{}' as a type.: fixed this by changing the {} type to unknown in all cases except for:

any ... extends React.Component<T, {}>, which just removed the {} as that is the default value.
some places where a Record is appropriate (e.g. path and pathOr from utils.ts

removed expression-utility-functions.ts as it was used nowhere
fixed a : Function by creating a generic function type (...args: Array<any>) => any. This feels right but please correct me. (javascript-cache.ts is where to look)
fixed memoize type kludges
fixed {} types in bundler-bridge.ts to their correct StateSchema type
added some eslint types for eslint4b in eslint-config.ts and linter.ts
changed the type of handleStringLiteral's value parameter to unknown and added a typeof check. 🚨before approving, lmk what you think about this one please 🚨
fixed an incorrect interface reference in css-tree.d.ts

Notes:

new rule explicit-module-boundary-types has generated hundreds of Missing return type on function warnings for public class functions. we should either make this an error or turn off.
we have hundreds of no-unused-vars warnings, and many that aren't on because they are exported and no longer used. would love to see this be an error.
that ContextMenuType<T>, is evil. particularly the fact that data is assumed. it doesn't seem to be used in new context menu implementations. we can at least make this slightly better by defaulting it to unknown?

Approved with the proviso that you undelete the function mentioned by Balazs!

i'm giving up on this pr for now, i've not been able to diagnose why i am getting errors on the tests, it seems to work fine in production, but eslint4b is erroring-out when linting in jest. could use a pairup on monday.

This appears to be caused by a break in the babel step of parsing, brought on by babel-eslint becoming @babel/eslint-parser, which also introduced a breaking change in the configuration, namely the introduction of requireConfigFile, but even after fixing that the linting step fails...

merge!
BTW, an approach we took earlier with these tasks when you switch a rule and suddenly thousands of things break – you can do a staggered update, where you make a branch, switch the rules, fix a part of the problems, turn the rule back off, and create the PR. This way you can gradually work down the problems and eventually you fixed everything, and then you can make a PR that changes the eslint rule / ts configuration etc itself.

merge!
BTW, an approach we took earlier with these tasks when you switch a rule and suddenly thousands of things break – you can do a staggered update, where you make a branch, switch the rules, fix a part of the problems, turn the rule back off, and create the PR. This way you can gradually work down the problems and eventually you fixed everything, and then you can make a PR that changes the eslint rule / ts configuration etc itself.

I think the issue here was more that everything around eslint (and our use of it in the running editor) had been updated, which introduced breaking changes as well as the improved rules. So a lot of time was spent fixing up code to fit the improved rules, but then time was lost trying to figure out why the updates had actually broken the editor.


Grammarly joins two paragraphs when the quick fix is used

I just noticed something which doesn't happen before. Sometimes, when Grammarly shows an error and I use the quick fix provided (by clicking on it), the error gets removed but the paragraph is also combined with the previous paragraph, removing the empty line between them. This doesn't happen all the time, but it makes me do the same thing over and over again.

Adding another issue related to this - if you  have a markdown code snippet in between lines, and quick fix the 2nd line, it will remove the code snippet along with the new line.

I'm adding in here with my sample as well. Here's my current source (well part of it):
The next two steps handle uploading our asset. This is done by first creating an asset and then actually uploading it. Here are
the calls:

```js
/*
Step two - get an upload URL/asset id
*/
let uploadData = await getUploadData(mediaType, CLIENT_ID, accessToken);
console.log(`Upload URI and asset ID  received.`);

/*
Step 3 - upload our file to the cloud storage provider.
*/
console.log(`Sending ${inputFile} to cloud provider.`);
await uploadFile(uploadData.uploadUri, inputFile, mediaType);
console.log('File uploaded to cloud provider.');
```

And here's their supporting functions:

I have a suggestion for "here'", and when I quick fix it, it changes it to:
The next two steps handle uploading our asset. This is done by first creating an asset and then actually uploading it. Here are
the calls:And here are their supporting functions:


Indented, collapsible tree with +/- boxes, icons, labels next to icon and labels on links

Hi,
I want to build a D3 collapsible indented tree that looks like old-school type file explorer tree, with:

plus/minus marks in boxes to indicate collapsible/expandable
gridlines marking the indents
icons/images at the end of each line
labels to the right of each icon/image
labels on the links if possible

Can i do this using your package? If so, how?

Hi,
I want to build a D3 collapsible indented tree that looks like old-school type file explorer tree, with:
plus/minus marks in boxes to indicate collapsible/expandable
In general, each node can consist of one icon and one label next to it. The default node icon is a box with a plus sign if expandable and empty if it is a leaf.
See e.g. https://blocks.roadtolarissa.com/EE2dev/423d4e8c040bed8d96e9b72e65ae8999

You substitute the default node icon with a custom vector or raster graphic icon. So you can reference to two folder icons (one when expanded, one when it is a leaf. But then you don't have the nox with the plus sign.
The only way to achieve both is create an icon which contains both the box and the little image.

gridlines marking the indents

yes, that is the default

icons/images at the end of each line

as mentioned above, one icon is at the beginning of each line.

labels to the right of each icon/image

yes that is the default

labels on the links if possible

yes, you can label the links based on your data
Here I added two examples to roughly display what you described:

https://blocks.roadtolarissa.com/EE2dev/71d6d17bc016e4037350158c2875893f
(and with labeled links): https://blocks.roadtolarissa.com/EE2dev/d6ad615b0197c2813fc231d2784fd6c9


Error during setup of component netatmo

Home Assistant release with the issue:
0.66.1

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

hass.io
Component/platform:

https://www.home-assistant.io/components/netatmo/
Description of problem:
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

netatmo:
  api_key: xxxx
  secret_key: xxxx
  username: xxxx
  password: xxxx

  - platform: netatmo
    modules:
      Stue:
        - temperature
        - co2
        - pressure
        - noise
        - humidity
      Ute:
        - temperature
        - humidity
        - min_temp
        - max_temp
      Regn:
        - sum_rain_1
        - sum_rain_24

Traceback (if applicable):
2018-04-03 20:37:01 ERROR (MainThread) [homeassistant.setup] Error during setup of component netatmo
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/setup.py", line 145, in _async_setup_component
    component.setup, hass, processed_config)
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/netatmo.py", line 55, in setup
    'read_station read_camera access_camera '
  File "/usr/lib/python3.6/site-packages/lnetatmo.py", line 74, in __init__
    self._accessToken = resp['access_token']
TypeError: 'NoneType' object is not subscriptable
2018-04-03 20:37:01 ERROR (MainThread) [homeassistant.setup] Unable to setup dependencies of sensor.netatmo. Setup failed for dependencies: netatmo
2018-04-03 20:37:01 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform sensor.netatmo: Could not setup all dependencies.

Additional information:

Having the same issue.
Identical errors in the logs

I managed to fix the issue in hassbian (not sure if you can under hass.io).
In Netatmo.py there are the following lines:
REQUIREMENTS = [     'https://github.com/jabesq/netatmo-api-python/archive/'     'v<IP_ADDRESS>.zip#lnetatmo==<IP_ADDRESS>']
Which returns a 404 when you browse to that URL. I changed the file to be:
REQUIREMENTS = [     'https://github.com/jabesq/netatmo-api-python/'     'v<IP_ADDRESS>.zip#lnetatmo==<IP_ADDRESS>']
And everything worked fine after restarting home-assistant

Having this issue once again on 0.67.0
2018-04-16 23:39:52 WARNING (MainThread) [homeassistant.setup] Setup of netatmo is taking over 10 seconds.
2018-04-16 23:39:54 ERROR (MainThread) [homeassistant.setup] Error during setup of component netatmo
File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/homeassistant/components/netatmo.py", line 55, in setup
File "/Users/mediacenter/.homeassistant/deps/lib/python/site-packages/lnetatmo.py", line 74, in init
2018-04-16 23:39:55 ERROR (MainThread) [homeassistant.setup] Unable to setup dependencies of sensor.netatmo. Setup failed for dependencies: netatmo
2018-04-16 23:39:55 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform sensor.netatmo: Could not setup all dependencies.

Having the same issue on 0.69.1
2018-05-13 12:11:06 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform netatmo
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 129, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 84, in setup_platform
    for module_name in data.get_module_names():
  File "/usr/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 292, in get_module_names
    self.update()
  File "/usr/lib/python3.6/site-packages/homeassistant/util/__init__.py", line 319, in wrapper
    result = method(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 299, in update
    self.station_data = lnetatmo.WeatherStationData(self.auth)
  File "/usr/lib/python3.6/site-packages/smart_home/WeatherStation.py", line 29, in __init__
    for m in self.rawData[i]['modules']:
KeyError: 'modules'

I have the same error as @hwikene:
Error
2018-06-04 00:16:15 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform netatmo
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_platform.py", line 129, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/sensor/netatmo.py", line 84, in setup_platform
    for module_name in data.get_module_names():
  File "/usr/src/app/homeassistant/components/sensor/netatmo.py", line 292, in get_module_names
    self.update()
  File "/usr/src/app/homeassistant/util/__init__.py", line 319, in wrapper
    result = method(*args, **kwargs)
  File "/usr/src/app/homeassistant/components/sensor/netatmo.py", line 299, in update
    self.station_data = lnetatmo.WeatherStationData(self.auth)
  File "/usr/local/lib/python3.6/site-packages/smart_home/WeatherStation.py", line 29, in __init__
    for m in self.rawData[i]['modules']:
KeyError: 'modules'

Configuration
netatmo:
  api_key: !secret netatmo_api_key
  secret_key: !secret netatmo_secret_key
  username: !secret netatmo_username
  password: !secret netatmo_password
  discovery: false

sensor:
  - platform: netatmo
    station: Nikolaevskaya
    modules:
      Bedroom:
        - temperature
        - co2
        - pressure
        - noise
        - humidity

I've tried to set discovery to false/true, but result is the same - error.

0.71.0
Error while setting up platform netatmo
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 129, in _async_setup_platform
SLOW_SETUP_MAX_WAIT, loop=hass.loop)
File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
return fut.result()
File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 87, in setup_platform
for module_name in data.get_module_names():
File "/usr/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 302, in get_module_names
self.update()
File "/usr/lib/python3.6/site-packages/homeassistant/util/init.py", line 319, in wrapper
result = method(*args, **kwargs)
File "/usr/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 315, in update
self.data = self.station_data.lastData(exclude=3600)
File "/usr/lib/python3.6/site-packages/smart_home/WeatherStation.py", line 111, in lastData
lastD[module['module_name']] = ds.copy()
KeyError: 'module_name'

I have the same error :c

I've fixed error I described here: https://github.com/jabesq/netatmo-api-python/pull/14
The reason of the issue - there is only one main indoor module configured/registered in Netatmo (i.e. no outdoor or other modules configured)

@Kwull great job. I only have one indoor module. My outdoor module got damage in a rain storm.


⚠ Bofrost.be has degraded performance

In 786a7e8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1899 ms

Resolved: Bofrost.be performance has improved in 78a7095 after 35 minutes.


Crystal Ameba linter

An Ameba linter for Crystal.

Thanks!
Please add it to the wiki: https://github.com/neomake/neomake/wiki/Makers


Using bootstrap mode causes exception related to bookmarks manager

As per the readme I am using bootstrap mode on the component so that the PowerBI embed loading spinner is shown while I am fetching an access token in the background.
This causes the bookmarks manager to throw an exception when I call report.bookmarksManager.getBookmarks();
The exception relates to the bookmark manager accessing a property on its internal config object which seems to be a cut down version of of the embed config passed to the react component.
It seems that when the props of the react component are updated to contain the full embed config object that configuration is not updated on the bookmark manager.
If I comment out the bootstrap code and only load the react component when I have the full config then the problem does not occur.

Unable to repro the issue, If the issue is still relevant, please open a new issue with reproduction steps.


xilem_masonry: Robust generational indexing for ViewSequence

Alternative to #218
The version of viewsequence added in #205 is robust for all properties supported in that version. However, it would be incompatible with future expansions to the Xilem model, in particular async wiring.
In this PR, I propose a system to resolve this, which uses generational indexes in the view id path (for the items where this is relevant).
Some other historical record: #9
This brings back the View::State associated type (renamed to ViewState and SeqState depending on the trait), in order to perform this wiring.

Merging to avoid merge conflicts over the weekend. I'm pretty happy with this now, and I think the main infrastructure work on xilem_masonry is done.
One remaining task is AnyViewSequence, which is extremely analogous to AnyView, but otherwise it's improvements to the set of widgets and to Masonry.
(Also on the agenda is working out how to handle flex items - the idiomatic way is a specific View/ViewSequence trait, but that requires a huge amount of boilerplate)


Way to reduce duplicated documents is required

Although I'm working on prototype, but as project goes on, some of documents are now duplicated.
Is there any way to figure it out?

Prototype will be removed in the future.

and the Mediawiki will handle duplicated documents.