Overheating/CPU on Firefox

NFC, but it appears to be an issue.

hmm, yeah I'll keep looking into this. On a fresh version of the latest FF I only have about a 5-8% cpu increase.  And Chrome seems pretty much negligible.  I have a few potential optimizations in mind, but they may cause the crypto-detector to miss a few edge cases.

Similar issue on Firefox 35.0.1. Opening a conversation results in ~4-5 sec page freeze.

We should probably compare the code base for Mailvelope/WebPG, as they either have the same problem, have solved it or cheated.

Yeah I totally agree - I also have a few new optimizations in mind that I'll play around with and report back here on.

Looks like at they're using openpgp.js, https://github.com/openpgpjs/openpgpjs, or something similar in the case of webPG

If we move to a local database and place nonces with all messages, would it decrease lag due to decryption as it is now a constant time look-up, not a full decrypt operation?

Potentially. Issues with that are: knowing everyone in the group, implementing the secondary channel (though you could also just cache things), and memory. Right now I'm limited to 5mb on Firefox and Chrome. There's a way for me to get more on Chrome that I'll eventually implement, but I still need to figure out Firefox

can you write things to disk, or are you limited to 5mb total? also, how much text is a 5mb sqlite database?

I think I can create files and so I could read/write things that way (assuming that's true)... Not sure how much text that is. The bigger concern is the secondary channel

Exactly what are you doing for decryption? I ask this because it ties up the main UI thread, which is something we don't want. I'm going to try using DOMWorkers to background the decryption task.

^ yep that was one thought I had

So #16 has been implemented. I'm now only seeing a 3-10% cpu increase, but hardly any difference in responsiveness (web worker is keeping decryption from blocking page rendering). Are you  both still seeing performance issues?

will check tomorrow, busy tonight; sounds awesome though!
On 5 February 2015 02:05:37 GMT+00:00, Winston Howes<EMAIL_ADDRESS>wrote:

So #16 has been implemented. I'm now only seeing a 3-10% cpu increase,
but hardly any difference in responsiveness (web worker is keeping
decryption from blocking page rendering). Are you  both still seeing
performance issues?

Reply to this email directly or view it on GitHub:
https://github.com/winhowes/grd.me/issues/9#issuecomment-72981308

This issue is far from solved on Firefox 35.0, but is much better on firefox-nightly with e10s enabled

Can you see if this is any better on the latest version? It is on my machine, and I think we may be able to close this issue

This issue was moved to GrdMe/GrdMe#14

This issue was moved to GrdMe/GrdMe#14


Set font color

Using the style-parameter, we can define a custom style for each node, but how can I set the font color? I already tried to use "color: red", "font-color: red" and "text-color: red" but nothing worked :(

color: #fafafa works for me


HiveStore Async Usage Example / Simplification

Describe the issue
If I use HiveStore.open() as my GraphQLCache, i have to await it first. So I have to do that in an async context. But GraphQLProvider does not want a Future. So how can I do that.

You can use a FutureBuilder for now –this is definitely an oversight caused by me not using the recommended Store in any of the examples 🤦

@lazylazyllama am going to have to rethink the current api, but for now you can do something like:
void main() async {
  await Hive.initFlutter(); // or await initHiveForFlutter();
  await Hive.openBox(HiveStore.defaultBoxName);
  runApp(MyApp());
}

/// then, at your cache declaration
cache = GraphQLCache(
  store: HiveStore(
      Hive.box(HiveStore.defaultBoxName),
    ),
  ),
);

This initializes ("opens") the box in main, for eager resolution later.
Will probably end up implementing an api like the following:
Future<void> initHiveForFlutter(Iterable<String> withBoxes = [ HiveStore.defaultBoxName ])
...
/// default constructor
HiveStore([ Box box ]): this.box = box ?? Hive.box(defaultBoxName);

https://pub.dev/packages/graphql/versions/4.0.0-alpha.2 includes a revamped api for HiveStore, closing this:
/// Only necessary on flutter
void main() async {
  await initHiveForFlutter();
  runApp(MyApp());
}

GraphQLCache(
  // The default store is the InMemoryStore, which does NOT persist to disk
  store: GraphQLCache(store: HiveStore()),
)

I have gotten an error on hot reload with the latest beta graphql_flutter: 4.0.0-beta.3.
The following HiveError was thrown building ClientProvider(dirty):
Box not found. Did you forget to call Hive.openBox()?

The relevant error-causing widget was
ClientProvider
lib/main.dart:29
When the exception was thrown, this was the stack
#0      HiveImpl._getBoxInternal
package:hive/src/hive_impl.dart:170
#1      HiveImpl.box
package:hive/src/hive_impl.dart:181
#2      new HiveStore
package:graphql/…/cache/hive_store.dart:40
#3      ClientProvider.build.clientFor
package:epics/graphql_provider.dart:56
#4      ClientProvider.build

I am using the main() like
void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  setupLocator();
  await initHiveForFlutter();

  runApp(App());
}

Also
return ValueNotifier<GraphQLClient>(
        GraphQLClient(
          cache: GraphQLCache(
            store: HiveStore(),
          ),
          link: link,
        ),
 );

How do I fix this issue?

@subhendukundu I think it might have something to do with get_it usage (based on setupLocator), or maybe something isn't being disposed properly? Our initHiveForFlutter is a fairly direct rip from Hive.initFlutter, and I can't find any related issues for hive itself.
If you want to try pasting your ClientProvider I could take a closer look, or look around for issues with get_it and flutter hot reload

Umm could be an issue of rerendering the ClientProvider when the firebase auth token is back?
import 'package:graphql_flutter/graphql_flutter.dart';
import 'package:flutter/material.dart';

String uuidFromObject(Object object) {
  if (object is Map<String, Object>) {
    final String typeName = object['__typename'] as String;
    final String id = object['id'].toString();
    if (typeName != null && id != null) {
      return <String>[typeName, id].join('/');
    }
  }
  return null;
}

class ClientProvider extends StatelessWidget {
  final Widget child;
  final String uri;
  final String subscriptionUri;
  final String token;

  ClientProvider({
    @required this.child,
    @required this.uri,
    this.subscriptionUri,
    this.token,
  });

  @override
  Widget build(BuildContext context) {
    ValueNotifier<GraphQLClient> clientFor({
      @required String uri,
      String subscriptionUri,
    }) {
      Link httpLink = HttpLink(uri);
      if (subscriptionUri != null) {
        final WebSocketLink websocketLink = WebSocketLink(
          subscriptionUri,
        );

        httpLink = Link.split(
            (request) => request.isSubscription, websocketLink, httpLink);
      }

      final authLink = AuthLink(
        getToken: () async => 'Bearer $token',
      );

      var link = authLink.concat(httpLink);

      return ValueNotifier<GraphQLClient>(
        GraphQLClient(
          cache: GraphQLCache(
            store: HiveStore(),
          ),
          link: link,
        ),
      );
    }

    final ValueNotifier<GraphQLClient> client = clientFor(
      uri: uri,
      subscriptionUri: subscriptionUri,
    );

    return GraphQLProvider(
      client: client,
      child: child,
    );
  }
}

And using it in main.dart like
void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  setupLocator();
  await initHiveForFlutter();

  runApp(App());
}

class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return ViewModelBuilder.reactive(
      viewModelBuilder: () => AppViewModel(),
      onModelReady: (model) => model.getIdToken(),
      builder: (context, model, child) => ClientProvider(
        uri: '$GRAPHQL_BASE_API/v1/graphql',
        subscriptionUri: '$GRAPHQL_WSS_API/v1/graphql',
        token: model.token,
        child: MaterialApp(
          debugShowCheckedModeBanner: false,
          title: 'App',
          themeMode: model.themeMode,
          theme: model.themeData,
          navigatorKey: locator<NavigationService>().navigatorKey,
          onGenerateRoute: MainRouter().onGenerateRoute,
          initialRoute: Routes.splashView,
        ),
      ),
    );
  }
}

class AppViewModel extends ReactiveViewModel {
  final _authService = locator<AuthService>();
  final _themeService = locator<ThemeService>();

  ThemeMode get themeMode => _themeService.theme;
  ThemeData get themeData => _themeService.isLight
      ? _themeService.lightTheme
      : _themeService.darkTheme;

  String _token = '';

  String get token => _token;

  getIdToken() async {
    final idToken = await _authService.getIdToken();
    _token = idToken;
    notifyListeners();
  }

  @override
  List<ReactiveServiceMixin> get reactiveServices => [_themeService];
}

@subhendukundu could be – I'm not that confident that it is, but try:
void main() async {
  await initHiveForFlutter(); // calls WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  setupLocator();

  runApp(App());
}

And maybe then see if hot reload works without using the ViewModelBuilder.reactive. If not, then there could be an issue with how we're doing things


Allow LN overlap for cc >=9 instead of ==9

This PR allows overlapping layernorm with communication for cc>=9 instead of cc==9.

@thomasdhc pls review

@thomasdhc could you sign off ci for this PR


Plots update

plots with plotly express
tvl/token value in post-processing
action types plot

#45 @randomshinichi :

pls review code in utils.py, my extensions amend the resulting post-processed df, could also amend the dicts/lists prior to create the df
have added comments, hope all is clear

Closed pull request because outdated


Minor issue with Readme if changing the org

If Step 3 in the Readme is followed "(Optional) Replace org.pqrs with your domain." you also need to modify ExtensionManager/ContentView.swift to have the correct driverIdentifier loaded.

Thank you for feedback!
I updated README.


Binding questions

Why not support constant bindings?
These bindings effectively behave like let bindings. Constant bindings would provide utility if there were a means to mutate them, but that currently isn't possible in this spec approach.

I'd suggest both the question and answer here need elaboration.
Question
I interpret the question as asking:  "Why not snapshot the value of the dynamic module's bindings post-execution and then mark them as non-writable thereafter?"
Was this the intention?
Answer
This answer raises a bunch of questions:

Are the bindings live?   The wording kinda implies there is no means to mutate them.

If the CJS export property changes value post-execution, is this observed via the ESM consumers of named imports?
Is the value changed observed for the namespace object?

Can ESM importers mutate the shared binding's values?  The wording is ambiguous on the user's point of view.
Can other dynamic require()-ers of a dynamic module mutate the shared binding's values observed by ESM? e.g.

// b.js
const other = require("a.js");
other.existingProp = "new value";

What happens if a dynamic module calls Object.defineProperty(exports, "existingProp", ...) post-execution?  Is this observable to ES importers?

The question was kind of eluding to the fact that in the original dynamic modules proposal, the goal was to capture all the ES module semantics programatically - https://gist.github.com/dherman/fbf3077a2781df74b6d8, including "const".
The question does effectively translate into exactly what you have written though!

Are the bindings live?

Yes, the current goal is for the dynamic modules API to support mutating bindings at any time.

Can ESM importers mutate the shared binding's values?

This would only be exposed through the C++ API side, so no. Other than that it behaves like any other ES module. Updates can only happen internally just like you can only update ES module bindings within the module itself.

Can other dynamic require()-ers of a dynamic module mutate the shared binding's values observed by ESM? e.g.

This is host-defined from this spec perspective. Tricks could be done, yes, but I'm not advocating them personally. When it comes to the actual CommonJS integration my opinion is that snapshotting should be all that is done and that that makes sense to users. Anything more seems like it could introduce observable issues breaking backwards compat or cause performance issues.

What happens if a dynamic module calls Object.defineProperty(exports, "existingProp", ...) post-execution? Is this observable to ES importers?

Again, this is a question for the CommonJS integration over this spec. I'd be strongly against turning all CommonJS modules into proxies though.

@robpalme and thanks for putting some thought to this :)

Cool. So to confirm my understanding:  bindings introduced by dynamic modules are capable of the same live value updates that source text modules support, but the probable/advocated implementation of this in Node.js will not make use of that ability; instead the binding names and values will be one-time copied into the namespace object post-evaluation.
This creates a model where the CJS module. exports value is distinct from the corresponding namespace object. And there is some well-defined snapshotting process that runs post-evaluation. Probably it has conditional behaviour based on whether module.exports is a function or not.

bindings introduced by dynamic modules are capable of the same live value updates that source text modules support, but the probable/advocated implementation of this in Node.js will not make use of that ability; instead the binding names and values will be one-time copied into the namespace object post-evaluation.

Yes, exactly!

This creates a model where the CJS module. exports value is distinct from the corresponding namespace object. And there is some well-defined snapshotting process that runs post-evaluation. Probably it has conditional behaviour based on whether module.exports is a function or not.

We have set this up in Node core already for core modules and it is basically - { ...exports, ...{ default: exports } }. Function conditional behaviours haven't been discussed deeply.


All template functions should use the base type instead of various other types

Instead of FInterpCurveFloat it should just be float for example. Simplify the interface with some more template magic ✨

Fixed in fade88a964dd687b60fd0263a3391038857002a8


Throw A Clear Exception Error When A Scanner Doesn't Exist

#2096
Thanks for opening a Pull Request!
Here's a handy checklist to ensure your PR goes smoothly.

[x] I signed Google's Contributor License Agreement
[x] My code conforms to Google's python style.
[x] My PR at a minimum doesn't decrease unit-test coverage (if applicable).
[x] My PR has been functionally tested.
[x] All of the unit-tests still pass.
[x] Running pylint --rcfile=pylintrc passes.

These guidelines and more can be found in our contributing guidelines.

Hey @blueandgold , a brand new revision is done! XD
Angel

awesome. Thanks Henry!
On Mon, Nov 5, 2018 at 3:00 PM Henry Chang<EMAIL_ADDRESS>wrote:

@blueandgold approved this pull request.
This is super clear now!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/forseti-security/pull/2160#pullrequestreview-171801232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqILV_ZtQUo7HUtsiEAVHbYHuaCKU6zPks5usMMNgaJpZM4YEdmd
.


Second sidebar can't be splitted.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.94.2
OS Version: Arch Linux (x86_64) Wayland 6.6.57-1-lts

Steps to Reproduce:

Run code --disable-extensions
Open secondary sidebar
Move one of activity bar icons to secondary
Try again with an other icon
https://github.com/user-attachments/assets/43a499f9-e3c5-48e2-adff-1b7408aa07d2
Downgrade to 1.87.2 and it's work
(Sorry if my english is bad)

Are you using one of the supported distributions from https://code.visualstudio.com/download or something else?

Are you using one of the supported distributions from https://code.visualstudio.com/download or something else?

I'm using from AUR

Please report your issue on the appropriate channel then.

Please report your issue on the appropriate channel then.

I'm just clone from github repo, running it and still not working.

I have found a workaround. Somehow, /usr/bin/code doesn't work, but /opt/visual-studio-code/bin/code works just fine. Quite strange.

closing as stale- please comment with the response to the above question if you are still seeing this and I can reopen. Thanks!


Fix write::XzDecoder handling of incomplete input

This PR fixes an issue with incomplete input and write::XzDecoder. Previously, calling finish
after not supplying enough input would cause an infinite loop, which is now fixed.
I also added tests that demonstrate the broken behavior.

Thanks!


“Clear” button for bolus and carb entries does not work as expected

Describe the bug
Observation:
Enter a value in the Enact Bolus: Bolus - Amount field
Tap Clear and see the entry being cleared out
Tap Doneto escape the keypad (there is no other way, except swiping down)
Watch how the previous bolus entry reappears.
The same observation has been made for carb entries.
Some recent PR introduced a button to close the keypad, not sure if any of that could be used here.
Expected behavior
Clear should mean clear
Trio Version:

Repo: nightscout/trio
current dev 14c7643275e3f351448d7623432f0d1778b65af4

This was fixed with the merged of #337


Unable to start redis with --loadmodule or redis.conf file

I am getting this exception when I am trying to set password to my redis instance as stated in docs.
but I am getting below exception while running docker container.
1:C 29 Oct 2021 20:57:14.130 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo 1:C 29 Oct 2021 20:57:14.130 # Redis version=6.2.3, bits=64, commit=00000000, modified=0, pid=1, just started 1:C 29 Oct 2021 20:57:14.130 # Configuration loaded 1:M 29 Oct 2021 20:57:14.130 * monotonic clock: POSIX clock_gettime 1:M 29 Oct 2021 20:57:14.130 # Warning: Could not create server TCP listening socket ::1:6379: bind: Cannot assign requested address 1:M 29 Oct 2021 20:57:14.131 * Running mode=standalone, port=6379. 1:M 29 Oct 2021 20:57:14.131 # Server initialized 1:M 29 Oct 2021 20:57:14.131 # WARNING overcommit_memory is set to 0! Background save may fail under low memory condition. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect. 1:M 29 Oct 2021 20:57:14.131 # Module /usr/lib/redis/modules/rebloom.so failed to load: /usr/lib/redis/modules/rebloom.so: cannot open shared object file: No such file or directory

I am also getting error when trying to use --requirepass or a redis.conf file.
When run with redislabs/redismod /home/user/redis.conf:

Fatal error, can't open config file '/data/redislabs/redismod': No such file or directory

When run with custom redis.conf in /home/user/redis.conf , the redis.conf file doesn't seem to be loaded at all.


Include directly from repository via npm/package.json

If one adds "karma-rollup-plugin": "Kflash/karma-rollup-plugin" to dependencies or devDependencies of package.json and runs npm install then node will fail with a "Cannot find plugin".
This is because package.json has   "main": "dist/rollup-plugin-karma.js", but that is not present when npm install gets the package from Github.
There are a few options to resolve this e.g.

keep a dist/ directory on master.
add git tags  releases/branches (and then package.json can reference that tagged version)
include rollup.config.js in files of package.json (so it can be at least compiled without having to explicitly fetch it)

There may be other/better ways to resolve this, but I just thought I'd give a heads up since npm supports installation from repository, and it's probably the easiest way to try out and debug the latest.
Cheers.

@brianmhunt I had identical issues yesterday. Could you push a PR?
I'm in the middle of developing a new Karma + Rollup testrunner from scratch.
@TrySound Could you look into it?

@Kflash I thought you can't fetch dist from npm. I don't beleive this is necessary repo uglifying. For dev process you are always able to copy paste dist. Or at least run npm install by hands in node_modules

The dist/ directory is included or excluded depending on the files in package.json or inclusion in .npmignore, respectively.  IIRC there are no special rules for dist/.
It is usual and useful to include either the latest tagged distribution or compiled HEAD in the npm's dist/, but npm install should not be a huge bother for folks who are going through the trouble of referencing the repo directly from package.json.

What the people will reference the repo directly? It doesn't make sense except dev process.

One can only speculate on all reasons, but the npm folks thought it worthwhile to provide as an option.  I have used it to get the HEAD version and modify it to try out new things as a dependency of an existing project.
It basically makes it unnecessary to clone the project from Github and then symlink it from the node_modules/.  Which can be handy, I have to admit, particularly for fast moving projects that are relied upon by multiple dependant projects and one wants to try them all out.

@brianmhunt @TrySound seems like I'm late to the discussion here, but did you two come to a conclusion?

Would it make sense to just include the rollup.conf.js in the package.json files section?

@brianmhunt Maybe. I will give it a try, and you test it and report back. Ok?

Ok

I guess this one is fixed. So closing


Removes quick run in favor of main for compression recipes.

Cleanup PR. See issue #433

Sure thing. Do you want the entire StripError stuff hidden or just the impls?

Let's go with all of it.  It is really easy to find it, and it makes reasoning the recipe easier as an entry point.

In my code I've usually just used Box<std::error::Error>, for functions with multiple possible error types. I'm wondering which method is considered more 'idiomatic'?

@JamesHinshelwood I saw this approach mentioned but wasn't sure which way was more idiomatic as well. This seemed most explicit but also a bit clunky. Could be a good idea for a recipe..

I've been doing a poor job of reviewing.  We use error chain when there are multiple error variants.

I will update the PR this morning


[examples/bert/build.py]: Load weights for BertModel and RobertaModel if --model_dir is provided

Currently the example TensorRT LLM engine builder for Bert models simply ignores model weights if those are present in the model directory, it only reads the config.json file, making it essentially impossible to generate a working engine from a pretrained model. This change fixes that.

Created a bug: #2197

@symphonylyh Could you please take a look at this PR? Thanks~

Hi @tkhanipov , thanks for the PR! We're currently doing a refinement of the BERT workflow, will address this problem and merge your PR 👍

Hi @symphonylyh! Thank you for the response.
Just curious: isn't this refinement to the BERT workflow you are talking about related to supporting BERT in Executor API? So far, AFAIU (please correct me if I am wrong), encoder only models are not supported there.


[go_router] When using pageBuilder, route.settings.name==null in the callback of RouteObserver

Steps to reproduce
context.push('/test/detail');
Expected results
print:
22-previousRoute: /test/home
22-route: /test/modal
Actual results
print:
22-previousRoute: /test/home
22-route: null
Code sample
Code sample
void main() {
  WidgetsFlutterBinding.ensureInitialized();
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return ScreenUtilInit(
      designSize: const Size(750, 690),
      builder: (context, widget) => MaterialApp.router(
        routerConfig: GoRouter(
          observers: [BaseObserver()],
          debugLogDiagnostics: true,
          initialLocation: '/test/home',
          routes: [
              GoRoute(
                path: '/test/home',
                builder: (BuildContext context, GoRouterState state){
                  return const HomeView();
                },
              ),
              GoRoute(
                  path: '/test/detail',
                  builder: (BuildContext context, GoRouterState state){
                    return const DetailView();
                  },
              ),
              GoRoute(
                path: '/test/modal',
                pageBuilder: (BuildContext context, GoRouterState state) {
                  return CustomTransitionPage<void>(
                    key: state.pageKey,
                    child: const ModalView(),
                    transitionDuration: const Duration(milliseconds: 150),
                    transitionsBuilder: (BuildContext context,
                        Animation<double> animation,
                        Animation<double> secondaryAnimation,
                        Widget child) {
                      return FadeTransition(
                        opacity:
                        CurveTween(curve: Curves.easeInOut).animate(animation),
                        child: child,
                      );
                    },
                  );
                },
              ),
            ],
        ),
        theme: ThemeData(
          primarySwatch: Colors.amber,
        ),
      ),
    );
  }
}

class BaseObserver extends RouteObserver<PageRoute> {
  @override
  void didPop(Route route, Route? previousRoute) {
    print('11-previousRoute: ${previousRoute?.settings.name}');
    print('11-route: ${route.settings.name} ');
    super.didPop(route, previousRoute);
  }

  @override
  void didPush(Route route, Route? previousRoute) {
    print('22-previousRoute: ${previousRoute?.settings.name}');
    print('22-route: ${route.settings.name} ');
    super.didPush(route, previousRoute);
  }
}

Screenshots or Video
No response
Logs
No response
Flutter Doctor output
jiaoyaxindeMacBook-Pro-2:~ jiaoyaxin$ flutter doctor -v
┌─────────────────────────────────────────────────────────┐
│ A new version of Flutter is available!                  │
│                                                         │
│ To update to the latest version, run "flutter upgrade". │
└─────────────────────────────────────────────────────────┘
[✓] Flutter (Channel stable, 3.19.1, on macOS 14.3.1 23D60 darwin-arm64, locale
    zh-Hans-CN)
    • Flutter version 3.19.1 on channel stable at /Users/jiaoyaxin/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision abb292a07e (9 weeks ago), 2024-02-20 14:35:05 -0800
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/jiaoyaxin/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (4 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        • android-arm64  • Android 14 (API 34)
      (emulator)
    • iPhone 15 Pro Max (mobile)  • 70ABDEC6-A2D9-4F24-B309-B90D1A5523A9 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-17-4 (simulator)
    • macOS (desktop)             • macos                                • darwin-arm64   • macOS 14.3.1 23D60
      darwin-arm64
    • Chrome (web)                • chrome                               • web-javascript • Google Chrome
      124.0.6367.79

[✓] Network resources
    • All expected network resources are available.

• No issues found!
jiaoyaxindeMacBook-Pro-2:~ jiaoyaxin$

@jiao1187875445 Thanks for the report.
The code sample you shared seems to have third party implementation like ScreenUtil and other custom implementation. In order to properly address the issue, please provide us minimal but complete runnable reproducible code sample without third party implementation that shows the reported behavior.


Do not add closing parenthesis when it has already been added

When typeing a left parenthesis in text editor, the right parenthesis is automatically added and the cursor is placed between them. If user types an extra end parenthesis it should be ignored and the cursor should be moved to after the closing parenthesis.

Code looks OK, but why do we want this behavior?
I think I recognize it from some other software, but I cant remember which one.
If I press ) I would expect a ) to be added. I can see the use if the code would count the number of ( and figure out if the ) is needed or not, but that will become complicated.

This is the default behaviour in both Qt Creator and Visual Studio.
Say for example that I want to type "y=f(x)". I would naturally press y+=+ f+(+x+). But since the end parenthesis was already added automatically this would give "y=f(x))". If I forget to press backspace I get a compilation error later. The problem is that we don't normally look at the screen when we type, we use the muscle memory.
I have also compared the Hopsan behaviour to Qt Creator and I have not found any difference in behaviour.


Replace proc-macro-error with proc-macro2-diagnostics

proc-macro-error is not maintained any more and depends on an old version of syn (Other packages too, therefore it's not removed yet).
I still need to test this (and probably clean it up a bti).

Thanks for contributing!
Looks promising. I haven't realized that proc-macro-error hasn't been updated since 3 years.
Just a small hint for the future. It's usually better to create an issue first then maybe discuss things a little bit if necessary, so no efforts are wasted :)


difficulty getting two-way audio to work on Dahua clone

I have a IPC-T5241H-AS-PV camera from Andy over at EmpireTech. I got the video and audio working in go2rtc (as an add-on in Home Assistant OS), but I am having trouble getting go2rtc to stream an audio file to the camera's speaker. I'm running go2rtc v1.4.0.
Here is my go2rtc.yaml file:
streams:
  my_camera:
  - rtsp://username:password@ip_address:554/cam/realmonitor?channel=1&subtype=0&unicast=true&proto=Onvif
  - ffmpeg:my_camera#audio=aac

I can get camera's audio feed to play using MSE, but not WebRTC. Otherwise, everything seems to fine.
To stream an audio file to the camera, I've tried issuing the following command in my Home Assistant's terminal (command line).
curl -X POST http://localhost:1984/api/streams\?dst=my_camera\&src\=ffmpeg:/media/local/audio_file.wav\#audio\=pcma/48000

But this yields the following message:  exec: exit status 1
When I listen to the camera's speaker when I run this command, it sounds like the camera is trying to play something, but it is static (white noise).
I am a newbie with linux and figure something is wrong with how I am calling POST.
Any thoughts?

I can get camera's audio feed to play using MSE, but not WebRTC. Otherwise, everything seems to fine.

What audio codec is the cameras audio set to in the settings?

curl -X POST http://localhost:1984/api/streams?dst=my_camera&src=ffmpeg:/media/local/audio_file.wav#audio=pcma/48000

where are you trying to play this? Does go2rtc have access to the file? You also haven't applied the #input=file which should be necessary

Hi @NickM-27
I'm trying to play the audio file on the camera's speaker from my RPi4 that runs Home Assistant with the go2rtc add-on. The audio file is in the local media folder on the RPi4 and can be seen in Home Assistant so I assume go2rtc has access to it.
Inside the camera, I have the audio encoding set to AAC with a sampling frequency of 8000. I think the wav file has a sampling frequency of 48000. I've also just changed the encoding inside the camera to AAC with a sampling frequency of 48000 and it makes no difference.
I've tried it with and without #input=file and there's no difference.
Everytime I try it, I get static on the camera's speaker for the duration of the wav file and the same exec: exit status 1 message.
Any suggestions?
I've tried it with

You should enable trace logs for exec so you can see the reason for failure

Also I think you're mixing up the cameras output and input. You should check the go2rtc info page for what the camera expects from recvonly, it's probably PCMA 8000

You should enable trace logs for exec so you can see the reason for failure

Thank you for your guidance. Being a newbie, I am not sure how to turn on the logging. Can you please direct me on how to do that?

Also I think you're mixing up the cameras output and input. You should check the go2rtc info page for what the camera expects from recvonly, it's probably PCMA 8000

I don't think there is a limitation for go2rtc. Instead, I think it is limited by the camera's ability. Also, if I'm reading the go2rtc info page correctly, I think the encoding is determined by the call to ffmpeg in the go2rtc config. But I could be mistaken. Again, I'm really new to all this.
Many thanks for your help.

 The path to my wav file was wrong. It was just /media/audio_file.wav. Now I'm getting a "can't find consumer' error.

Also I think you're mixing up the cameras output and input. You should check the go2rtc info page for what the camera expects from recvonly, it's probably PCMA 8000

I don't think there is a limitation for go2rtc. Instead, I think it is limited by the camera's ability. Also, if I'm reading the go2rtc info page correctly, I think the encoding is determined by the call to ffmpeg in the go2rtc config. But I could be mistaken. Again, I'm really new to all this.
Many thanks for your help.

That is incorrect. The camera only has specific codecs / sampling frequencies that it can play. You must use ffmpeg to convert the audio file to one of those for the camera to play.

Also I think you're mixing up the cameras output and input. You should check the go2rtc info page for what the camera expects from recvonly, it's probably PCMA 8000

I don't think there is a limitation for go2rtc. Instead, I think it is limited by the camera's ability. Also, if I'm reading the go2rtc info page correctly, I think the encoding is determined by the call to ffmpeg in the go2rtc config. But I could be mistaken. Again, I'm really new to all this.
Many thanks for your help.

That is incorrect. The camera only has specific codecs / sampling frequencies that it can play. You must use ffmpeg to convert the audio file to one of those for the camera to play.

I think we're saying the same thing.

paste the camera info

These are the audio compression encodings according to the Dahau website ():
PCM G.711a G.711Mu G.726 G.723
When I look at my audio encoding options in the camera's GUI, I have: PCM G.711a G.711Mu G.726 AAC G.773
Here's what the info page says:
Device TypeIPC-T5241H-AS-PV-3.6mm
System VersionV2.800.0000000.19.R, Build Date: 2020-07-09
WEB VersionV<IP_ADDRESS>9770
ONVIF Version19.06(V<IP_ADDRESS>7698)
S/N **************************
Algorithm Version1.0.1
Security Baseline VersionV2.1

We need the info from go2rtc info page

Sorry. I misunderstood.
  "producers": [
    {
      "url": "rtsp://username:password@ip_address:554/cam/realmonitor?channel=1\u0026subtype=0\u0026unicast=true\u0026proto=Onvif"
    },
    {
      "url": "ffmpeg:my_camera#audio=mycodec"
    }
  ],
  "consumers": []
}

I defined mycodec in the go2rtc config file to match the encoding in the camera.
ffmpeg:
  mycodec: "-c:a aac -ar:a 64000 -ac:a 1"

I'm wondering why the "consumer" section of my camera's info is blank. Could that be part of the issue?
Also, when I try to play an m4a file, the camera chirps and I no longer get any "can't find consumer" message in the terminal display. Instead, it outputs a bunch of stuff that looks like the camera info, with stuff like "producers" "receivers" "consumers" etc.

Also, when I try to play an m4a file, the camera chirps and I no longer get any "can't find consumer" message in the terminal display. Instead, it outputs a bunch of stuff that looks like the camera info, with stuff like "producers" "receivers" "consumers" etc.

that's what we need to see

Here's what the terminal spits out... I'm having difficulty copying-and-pasting it out of terminal. So this is from OCR on my smart phone:
"producers": [("ur]":"rtsp://username:password@ip_address:554/cam/realmonitor?channel-1\u0026subtype-0\u0026unicast-truelu0026proto-Onvif"), ("url":"ffmpeg:my_camera#audio=mycodec"),{"type":"RTSP passive producer", "url":"rtsp://localhost: 8554/d42b52586ed927de1d302fdf9313941b","remote_addr":"[::1]:50456", "user_agent":"ffmpeg/go2rtc", "medias": ["audio, recvonly, MPEG4-GENERIC/48000/2"], "receivers": ["96 MPEG4-GENERIC/48000/2, bytes-0, senders=1"], "recv": 28}], "consumers": [{"type":"RTSP active producer", "url":"rtsp: //ip_address:554/cam/realmonitor?channel-1\u0026subtype0\u0026unicast-true\u0026proto-Onvif/", "remote_addr":"ip_address:554", "user _agent"; "go2rtc/1.4.0", "medias": ["video, recvonly, H.264 Main 4.2", "audio, recvonly, MPEG4-GENERIC/64000", "application, revonly, VND.ONVIF METADATA"," audio, sendonly, L16/8000, L16/16000, L16/32000, L16/48000, L16/64000, PCM/8000, PCMA/16000, PCMA/32000, PCM/48000, POMA/64000, PCMJ/8000, PCM/16000, PCMU/32000 , POMU/48000, PCMU/64000, G726-40/8000, G726-40/16000, G726-40/32000, G726-40/48000, G726-40/64000, MPEG4-GENERIC/8000, MPEG4-GENERIC/16000, MPEG4-GENERIC/32000, M PEGA-GENERIC/48000, MPEGA-GENERIC/64000, 122, 123, 124, 125, 126"], "senders": ("120 MPEGA-GENERIC/48000, bytes=0, receivers=1"]}]}

This is probably a better version. I grabbed it while the curl -X POST command was being issued:
{
  "producers": [
    {
      "url": "rtsp://username:password@ip_address:554/cam/realmonitor?channel=1\u0026subtype=0\u0026unicast=true\u0026proto=Onvif"
    },
    {
      "url": "ffmpeg:my_camera#audio=mycodec"
    },
    {
      "type": "RTSP passive producer",
      "url": "rtsp://localhost:8554/d42b52586ed927de1d302fdf9313941b",
      "remote_addr": "[::1]:48528",
      "user_agent": "ffmpeg/go2rtc",
      "medias": [
        "audio, recvonly, MPEG4-GENERIC/48000/2"
      ],
      "receivers": [
        "96 MPEG4-GENERIC/48000/2, bytes=104347, senders=1"
      ],
      "recv": 105587
    }
  ],
  "consumers": [
    {
      "type": "RTSP active producer",
      "url": "rtsp://ip_address:554/cam/realmonitor?channel=1\u0026subtype=0\u0026unicast=true\u0026proto=Onvif/",
      "remote_addr": "ip_address:554",
      "user_agent": "go2rtc/1.4.0",
      "medias": [
        "video, recvonly, H.264 Main 4.2",
        "audio, recvonly, MPEG4-GENERIC/64000",
        "application, recvonly, VND.ONVIF.METADATA",
        "audio, sendonly, L16/8000, L16/16000, L16/32000, L16/48000, L16/64000, PCMA/8000, PCMA/16000, PCMA/32000, PCMA/48000, PCMA/64000, PCMU/8000, PCMU/16000, PCMU/32000, PCMU/48000, PCMU/64000, G726-40/8000, G726-40/16000, G726-40/32000, G726-40/48000, G726-40/64000, MPEG4-GENERIC/8000, MPEG4-GENERIC/16000, MPEG4-GENERIC/32000, MPEG4-GENERIC/48000, MPEG4-GENERIC/64000, 122, 123, 124, 125, 126"
      ],
      "senders": [
        "120 MPEG4-GENERIC/48000, bytes=104347, receivers=1"
      ],
      "send": 105963
    }
  ]
}

I've re-encoded the audio file using Audacity with a sampling frequency of 64000 so the "senders" matches the recvonly. But it doesn't change anything. The camera just makes a weird chirping sound a couple of times.

That's incorrect, you're using the producer which is just the ffmpeg command. You simply need to start watching a stream and get the info from there, that will show what we need to see.

Thank you for the clarification. I've grabbed the camera info with a stream from it open on go2rtc. Here it is:
{
  "producers": [
    {
      "type": "RTSP active producer",
      "url": "rtsp://camera_ip_address:554/cam/realmonitor?channel=1\u0026subtype=0\u0026unicast=true\u0026proto=Onvif/",
      "remote_addr": "camera_ip_address:554",
      "user_agent": "go2rtc/1.4.0",
      "medias": [
        "video, recvonly, H.264 Main 4.2",
        "audio, recvonly, MPEG4-GENERIC/64000",
        "application, recvonly, VND.ONVIF.METADATA",
        "audio, sendonly, L16/8000, L16/16000, L16/32000, L16/48000, L16/64000, PCMA/8000, PCMA/16000, PCMA/32000, PCMA/48000, PCMA/64000, PCMU/8000, PCMU/16000, PCMU/32000, PCMU/48000, PCMU/64000, G726-40/8000, G726-40/16000, G726-40/32000, G726-40/48000, G726-40/64000, MPEG4-GENERIC/8000, MPEG4-GENERIC/16000, MPEG4-GENERIC/32000, MPEG4-GENERIC/48000, MPEG4-GENERIC/64000, 122, 123, 124, 125, 126"
      ],
      "receivers": [
        "96 H264, bytes=1880656, senders=2",
        "97 MPEG4-GENERIC/64000, bytes=86295, senders=1"
      ],
      "recv": 1987591
    },
    {
      "url": "ffmpeg:my_camera#audio=mycodec"
    }
  ],
  "consumers": [
    {
      "type": "MP4 passive consumer",
      "remote_addr": "laptop_ip_address:60904",
      "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/112.0.1722.64",
      "medias": [
        "video, sendonly, H264, H265",
        "audio, sendonly, MPEG4-GENERIC, PCMA, PCMU, L16, OPUS"
      ],
      "senders": [
        "96 H264, bytes=1880656, receivers=1",
        "97 MPEG4-GENERIC/64000, bytes=86295, receivers=1"
      ],
      "send": 2010483
    },
    {
      "type": "WebRTC/WebSocket async passive consumer",
      "remote_addr": "udp4 prflx laptop_ip_address:63426 related :0",
      "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/112.0.1722.64",
      "medias": [
        "video, sendonly, VP8, RTX, VP9, H264, AV1, RED, ULPFEC, FLEXFEC-03",
        "audio, sendonly, OPUS/48000/2, RED/48000/2, G722/8000, PCMU/8000, PCMA/8000, CN/8000, TELEPHONE-EVENT/48000, TELEPHONE-EVENT/8000, L16"
      ],
      "senders": [
        "102 H264, bytes=1880656, receivers=1"
      ],
      "send": 1900927
    }
  ]
}

Looks like the camera supports lots of audio types. I'd suggest doing pcma/8000 since it's simpler and a good starting point, but the camera may have issues playing some audio types so have to experiment.

Thank you @NickM-27 How do I specify that pcma/8000? Do I need to create an ffmpeg: section in my config file? Or do I just do it in the curl -X POST command in terminal?

#audio=pcmu in the curl command.

So I ran the following command in terminal and the camera just chirps a couple of times. Nothing else.
curl -X POST http://localhost:1984/api/streams\?dst=my_camera\&src\=ffmpeg:/medial/audio_file.m4a\#audio\=pcmu\#input\=file

Same thing if I try #audio\=pcma

The camera doesn't like something, hard to say what

Is the syntax of my curl -X POST command correct?

I think so but I've not tried it with curl. I'd suggest just using the go2rtc webUI to send it

@NickM-27 That works with pcma! So it must be an issue with my curl command.

@AlexxIT How do you recommend making the POST request from the command line in Home Assistant to stream an audio file to the camera?

@NickM-27 I got it to work from the command line!
curl does not like the hash in the url. So it needs to be replaced with %23. In case others run into the same problem, here is the generic curl command that I issued in the Home Assistant terminal that worked for me using pcma/48000 encoding. This assumes your audio file is located in the /media folder.
curl -X POST http://localhost:1984/api/streams\?dst\=my_camera\&src\=ffmpeg:/media/audio_file.m4a%23audio\=pcma/48000%23input\=file

Yes. Hash symbol is not valid symbol for URLs. Thats why I'm using it for FFmpeg source. So go2rtc can always know where URL ends and where FFmpeg params starts.
I think I need to make some easier API for playing URLs with autodetection supported codecs and autouse of ffmpeg source with right arguments :)


matrix-synapse: 1.14.0 -> 1.15.1

Motivation for this change
https://github.com/matrix-org/synapse/releases/tag/v1.15.0
https://github.com/matrix-org/synapse/releases/tag/v1.15.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

LGTM

Pinging @bachp, @corngood, @ralith, @roblabla, @worldofpeace who are being removed from the modules and packages maintainer lists but not added to the newly created team.

As suggested by @pacien, the maintainer-team change is in its own PR in #90646 now.

Ported to stable as 73d7516c257120df2067250e21ce60edd19d6d78.


Concept of documentation

Currently the documentation is made using Markdown only, while functional, it is not that nice to look at and it is somewhat limited in the long run.
This is a small concept implementation of an alternative documentation with the following benefits:

Output HTML to ./docs/  which can be served with GitHub pages
HTML and layout is code, plenty of room for abstractions and components
HTML be tested, with Intent of course =)

Why a homemade generator you ask?

Default GitHub pages lacks uniqueness
Site generator (e.g.. hugo) requires an additional toolchain
Plain Markdown is boring

Future improvements:

While ugly, Markdown is pretty handy for minor text markup,  so maybe add a custom markdown tag?
Implement a macro that reads example code from src/test/scala and transform to a code block in documentation (this way examples are guaranteed to compile).
The rest of the documentation, obviously

Regretting myself, turn out to be too cumbersome to not use Markdown.
I'll make a new PR using hugo as a site generator.


Please add hand rays voice commands to documentation

Please add two missing voice commands in documentation: "show hand rays" and "hide hand rays". They are very useful when working with keyboard/laptop to prevent accidental hand interactions. Near interactions are still available.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3659d52-b481-f97b-9824-58874adc0763
Version Independent ID: b5f1e3d5-cb2d-445b-a737-38498f7863e5
Content: Voice input - Mixed Reality
Content Source: mixed-reality-docs/voice-input.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @Hak0n
Microsoft Alias: hakons

@hferrone Some starting hand ray info here.
https://docs.microsoft.com/hololens/hololens-cortana#built-in-voice-commands


Reflect correct publisher approval flow

Docs updated reflect correct publisher approval flow.
Proposed changes
Update CTA for publishers to go to https://goto.docker.com/partners vs https://store.docker.com/publish. This reflects the expected mechanism that partners are expected to go through to publish content.

cc @gbarr01 @KickingTheTV


Added multi-part file upload to files.upload

Slight refactor of lib/Slack_web_api.js to include the ability to post data to Slack API as a multi-part upload to allow binary files to be updated.
The use is as follows:
    bot.api.files.upload({
        file: fs.createReadStream('/tmp/dramacat.gif'),
        channels: 'C024BE91L,#general'
    }, function (error, done) {
        console.log(JSON.stringify(error));
        console.log(JSON.stringify(done));
    });

Is the same as (from slack web api examples)
curl -F<EMAIL_ADDRESS>-F channels=C024BE91L,#general -F token=xxxx-xxxxxxxxx-xxxx https://slack.com/api/files.upload

This fixes issue #29.

We need to make sure this doesn't disrupt any of the internal API calls being made before we merge this.

Sure thing @benbrown. Let me know if you need any support from me.
Just as an FYI, we have been using this branch since then and have had no issues. Although we don't use all the API calls available.

@olirogers cool! good to know.

Closing because this is now too old to merge.


ContainerBasedHandlerLocator: unspecified second argument fix

Looks like services registration misses second parameter: https://github.com/thephpleague/tactician-bundle/blob/4e17ae5def48d5e5fae8697a6a75129d286ea56a/Resources/config/services/services.yml#L7
I got missing type error for the second argument. So correctly it should be empty array for default (this PR) or specified in the config.

This is actually not 100% correct.
The service does not define the second argument, because it is auto populated by the compiler pass.
https://github.com/thephpleague/tactician-bundle/blob/4e17ae5def48d5e5fae8697a6a75129d286ea56a/DependencyInjection/CommandHandlerCompilerPass.php#L40
So I would be more worried about why you did not get a blank array injected there as would be expected.
But given the fact that if no handlers are defined a blank array is the "default" I am not against adding this as a safe guard.

Thanks for pointing this out! I missed it.
I'm actually making bridge to another DI and forgot to add this CompilerPass. This settles it then.


移除抓取失败和正文内容为空的文件

Thanks!

This is mannually merged in https://github.com/project-polymorph/news-website/commit/f757639a437dfdf4d7e36ec44838ff008d54ba83


⚠ ClamAV has degraded performance

In b106589, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 220 ms

Resolved: ClamAV performance has improved in 10b44bc.


fix example in readme

Fixes warning:
Unexpected input(s) 'transform-for-static-hosting', valid inputs are ['target', 'output', 'hosting-base-path', 'disable-indexing', 'transform-static-hosting']

Thanks for the contribution, I think this is a typo in action.yml though and should be transform-for-static-hosting there.

I thought you might want to avoid the breaking API change that changing the action.yml causes.

The transform-static-hosting key never worked in the first place (as can be seen in the action's TypeScript implementation), so I think the break is fine here.


Function: partialExists

We have fileExists at this time to find out if a file exists. https://gohugo.io/functions/fileexists/
Based on this I think it would be a useful feature, to have a function partialExists that works in a similar form, but leaves out the task of "knowing" which themes are used. The function could check in all theme (or even all module?) directories and the root layout/partials folder for a certain partial.
The use of this (example): I have a theme component that creates Netlify header files. If a certain partial (for instance css-netlify.css) is found it will be preloaded in the _headers file. This function would take away the need for a boolean config variable to enable the inclusion.

We have templates.Exists.

perfect and enough.


Rename ModelState (the type) -> ModelStateEntry

See: https://github.com/aspnet/Mvc/issues/3315
ModelState (the type) rarely appears in user-code. Users will generally interact with the MSD directly using AddModelError or something similar. Seeing ModelState (the type) in user-code is usually a mistake. We should rename it raise our sanity level and prevent mistake-making by future generations of humans and cyborgs alike.

A cyborg would never make this mistake.

Done? :smile:

A cyborg would never make this mistake.


job completes successfully but shown as failed

“[INFO] USER COMMAND END
[DEBUG] EXIT signal received in docker container, exiting ...
/bin/bash: line 1:    72 Terminated              /bin/bash bootstrap.sh”

fixed in 0.9.y. feel free to reopen it when you run into this issue.


Use template, or something else to make sure that slides are not rendered until needed.

Could load templates programmatically. Only keep 3 in dom at a time (current, previous, and next)

So I have something working here, but this will actually be a more complicated issue than not. Essentially the big issue is that if the structural directive prevents the slide from being created then the slide will not get registered in the PresentationComponent. So I'm having the directive register the slide (and watch the index) of the PresentationComponent but so far I have a few small issues I need to figure out... (like the progress bar is kind of broken).
So yes it can work, it also requires a lot of work to get it to work.

This has been merged


Ensure the timestamps that are returned correspond to the requested range

Also, only request GAUGE, COUNTER and TIMER types for PromQL requests.

@apoydence Thanks for catching the issue in #89!
I think the envelope type issue was resolved in 926fa3c654caf1c9f8257029d67653b48f78a873.
Regarding the timestamp change, I think there was desire to preserve the envelope's original timestamp, so modifying it directly is something we'd like to avoid if possible. We'll take a look at the walk algorithm to see if there's a way we can avoid getting it stuck in the request loop.

@toddboom I don't think the problem is in the Walk algorithm. I think it is exposing it. If the request asks for a time range, it seems invalid to give anything outside of that range.

@apoydence Fair point. Seems like it mike the most make sense to drop those points from the response then. We'll take a look at that now and try to get the fix in for 1.4.5.

@toddboom If you don't include those points, then does that remove the need to "fudge" the timstamps. Essentially that is removing the need for the hash collision resolution and going back to just taking the last envelope with the given timestamp.

@apoydence I think we've come up with a solution that will solve this in the Store. We'll push it up to master before the end of the day, so I'm going to close this out.


Theming update

Theming Update
Finally have something to show for the hours of research and work I spent trying to get the theme's to function. It's not entirely completed, there is only one piece to go. Right now the Theme stays on the about page, but each time the Home page is loaded it is re-rendered and set back to light theme each time.
Summary of changes

Added a Theme's folder
Removed unnecessary call to MudThemeProvider in App.razor (this is what was causing Theme's to not work)
Re-built the code behind file in MainLayout.razor
Made light theme Orange/White/Black
Made dark theme Orange/Black/White
Removed Navbar
Added some icons to the upload and clear buttons
updated the About page and made the Title button a link back to the "/" route.

Recreating with proper commit history


Need a better way to push releases

Currently I am pushing releases by copying the build folder into a new folder in the releases folder. This makes for pretty bloated commits on main/master, it would be good to either serve these through a cdn and have them pulled on install or first run. I'm not really sure what the standard is for this sort of thing.

This is specifically for the releases of new react stuff? Is there a way to setup a CDN through github that could hold the latest build?


[EVM] Support REVERT opcode

See: https://github.com/ethereum/EIPs/pull/206

revert opcode merged, see https://github.com/hyperledger/burrow/pull/778


Internationalized Harcoded String

Contains
Internationalized some hardcode strings in:

onlinePlayersOverlay.ui
inspectionScreen.ui
behaviorEditorScreen.ui

How to test

Translate to another language.
Verify whether or not the string changes.

Can one of the admins please verify this patch?


Evaluate the Generation of Go Types from Metaschema

A recommended approach to mature implementations of OSCAL ingestion is through the generation of types from OSCAL's metaschema: seen here
gocomply/metaschema is one such implementation that has done this historically - although it looks unmaintained and out of date.
Would like to evaluate understanding the gocomply implementation and possibly contributing to bringing it up to date. Otherwise looking to write new logic that could be folded into this project to support golang oscal support in a maintained fashion.

Review https://github.com/Credentive-Sec/metaschema-python/tree/main
Intent: Possible collaboration on the generation front to have a separate project own the code-generation while go-oscal positions itself as the exported library. Greater adoption on a multi-language code generator may mean for project resiliency and ability to adapt to changes in OSCAL in the long-term.


loader.js not included in ember-cli's vendor.js

I am not 100% sure why but since broccoli-concat got released my app refuses to boot.

Any suggestion on how to pin point what's going on?

had the same issue and locking our version to 2.2.1 fixed it

https://github.com/ember-cli/broccoli-caching-writer/commit/9217adb369020a1fd0bd52b68445612c2fc1f62c

Thank You!!


.NET object does not support null for optional fields

We are using the GTFS Realtime bindings package for .NET to convert vehicle and trip update data in our database to the GTFS-RT ProtoBuf format. We do not have values for some of the optional elements such as vehicle bearing, occupancy, speed and vehicle stop status. But the C# object uses non-nullable properties for these and hence defaults values such as 0 for bearing, EMPTY for occupancy, 0 for speed, IN_TRANSIT_TO for vehicle stop status etc. The serialized ProtoBuf output also has these default values (instead of null). Would it be possible to update the code so that nulls are allowed for optional fields?

@dmani Which version of the .NET bindings are you using?
It sounds like this is the inverse problem of https://github.com/MobilityData/gtfs-realtime-bindings/issues/32, in which default values aren't serialized to the protobuf message.
I believe this should be controllable via the RuntimeTypeModel.UseImplicitZeroDefaults setting.
Could you try setting this to true in code and see if this fixes the problem?
For an example see https://stackoverflow.com/a/12296458/937715.

Thank you for the quick response. We are using v0.0.4 of GtfsRealtimeBindings and v2.4.0 of protobuf-net for serialization.

The correction you have suggested is on the protobuf serialization side. But issue we are having is in the GtfsRealtime.cs class. Optional elements (properties in the class) such as bearing, speed, occupancy, etc. do not allow for null. Null should be a valid value (which should imply that we do not have a value for the element). For example, setting a default of bearing=0 when we do not have a value for bearing is incorrect as bearing=0 implies that the vehicle is pointing north.
We notice in GtfsRealtime.cs that the private variables are nullable while the corresponding public properties are not. As a result, it does not allow us to set any of the optional properties to null when we do not have a value for it.
For instance, below is a snippet from GtfsRealtime.cs
private OccupancyStatus? __pbn__occupancy_status;
public OccupancyStatus occupancy_status
{
get { return __pbn__occupancy_status ?? OccupancyStatus.EMPTY; }
set { __pbn__occupancy_status = value; }
}
Can it be changed to code below, so that the public property is nullable?
private OccupancyStatus? __pbn__occupancy_status;
public OccupancyStatus? occupancy_status // make the property nullable
{
get { return __pbn__occupancy_status; } //return null when there is no value, not OccupancyStatus.EMPTY
set { __pbn__occupancy_status = value; }
}
The same should be done for all optional properties. Please let us know if you can implement this change.

@dmani We use an automated tool to generate the bindings, so I'm not sure this is an option at the code generation stage.
To make sure I understand your use case - you're trying to use this class as an internal data model and need to read and write values to this class (without serializing it to a protocol buffer representation)?

From a quick search, the author of the library says in this SO post, answer the question of "why no nulls":

Simply, because the underlying protocol specification ("protobuf") has no concept of null and no way of expressing it. If I can't express it in the protocol, the best that can be supported is some kind of implicit "the absence of something means leave it alone which means it will probably be null".

And he's right, the protocol buffer format uses default values instead of null values, as described here:
https://developers.google.com/protocol-buffers/docs/proto#optional
Given this library is intended primarily as a (de)serialization library, you may need to create your own wrapper or data model classes if you want a more sophisticated data model internally for your application.
If you're worried about these values being serialized, which is the focus of this library, then I believe my original suggestion of setting RuntimeTypeModel.UseImplicitZeroDefaults to true may resolve this specific problem.  Please give this a try and please re-open if it doesn't work as expected.


Fix url.indexOf is Not a Function Error

The sidebar toogler isn't working with newer jquery versions

Thank you!


Fix web datepicker text field illegal input crash

Update kotlinx.datetime to 0.6.0
Migrate locale-invariant web formatting/parsing to kotlinx.datetime
Catch parsing exceptions

Fixes https://github.com/JetBrains/compose-multiplatform/issues/4856
Testing
KotlinxDatetimeCalendarModelTest.illegalDateParsingDoesNotThrowException

This should be tested by QA
Release Notes
Fixes - Web

Fixed crash when date picker text field receives illegal input

Do you known why iOS CI runs here instead of web?

Do you known why iOS CI runs here instead of web?

it seems that iOS tests run for all changes, regardless of the where the change was added.
web tests should run eventually too (they run on teamcity).

it seems that iOS tests run for all changes, regardless of the where the change was added.

Expensive macos runners aren't happy about that 😆


Error: ENOTDIR: not a directory, scandir

I am not sure where the issue lies, but I am using watch to watch for file changes on my js file, and when a change happens it should minifiy the js file. This works on my Ubuntu machine, but on my Windows machine, I get the error below.
> watch.cmd --interval=1 uglifyjs.cmd -c -m -o ./public/assets/js/prefab.min.js -- ./public/assets/js/prefab.js
> Watching ./public/assets/js/prefab.js
C:\Users\rnaddy\AppData\Roaming\npm\node_modules\watch\main.js:73
    if (err) throw err;
             ^

Error: ENOTDIR: not a directory, scandir 'C:\Users\rnaddy\Documents\vscode\projects\prefab\public\assets\js\prefab.js'

I think this comes from the fact that you're trying to watch a file and that this tool can only watch directories. I ran into the same problem 😝
That being said, I was able to get around it by building a custom filter and then just checking for the file I want. It was relatively painless https://github.com/mikeal/watch#watchcreatemonitorroot-options-callback

@mikeal I wonder how difficult it would be difficult to allow watching a file? I'm willing to help with this 👍

@JuanCaicedo Please could you share your custom filter code?
Thanks

I think my issue was that on one machine the file existed which is why it worked and the other machine it didn't exist.
What would be nice would be to watch a file for creation as well.


Add support for more CLI options

Support all options.

@Lukas-Kullmann have you also considered these: https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md ?
Especially the --tags options is really awesome, this way you can run subsets of tests any time you would like.
For example:

@smoke for quick developer tests (pre-push, very short run time)
@ci for an extended set of tests (in ci pipeline, medium run time)
@qa for the ultimate set of tests (before deploying to production, long run time)

Will investigate if and how we could leverage this

Hey @DennisJaamann,
no, I have not concidered these. But I think you are right. It would be worth adding some support for these options. Especially, as you said, the --tags one!

--reporter is needed.

Hey @skullz03,
sorry, that I did not answer your other question sooner. I was quite busy.
The problem there seems to be, that you want to run gherkin-testcafe from the command line from the package itself. This is only possible, if you installed it as a dependency of your project.
To run the examples, please execute
node main.js --steps examples/*.js --specs examples/*.feature -b firefox

Do not clone the repo and put test files into it. Start your own project and install gherkin-testcafe (and testcafe as a dependency: npm i -D gherkin-testcafe testcafe). From there, you can use gherkin-testcafe via the command line.

Beginning from version 2, all CLI options are inherited from testcafe.


VMware: add support for 8.0b (<IP_ADDRESS>) and 8.0c (<IP_ADDRESS>)

Description
This PR adds

The support (hypervisor capabilities) for VMware 8.0b (<IP_ADDRESS>) and 8.0c (<IP_ADDRESS>)

Refer to
https://docs.vmware.com/en/VMware-vSphere/8.0/rn/vsphere-esxi-80b-release-notes/index.html
https://docs.vmware.com/en/VMware-vSphere/8.0/rn/vsphere-esxi-80c-release-notes/index.html

The new guest os mappings introduced in VMware 8.0 (also supported by 8.0a and 8.0b/8.0c)

Refer to https://vdc-repo.vmware.com/vmwb-repository/dcr-public/c476b64b-c93c-4b21-9d76-be14da0148f9/04ca12ad-59b9-4e1c-8232-fd3d4276e52c/SDK/vsphere-ws/docs/ReferenceGuide/vim.vm.GuestOsDescriptor.GuestOsIdentifier.html

An extra step to determine the guest os mappings for a hypervisor version

Since VMware 8, each minor update has a newer patch version. For example ESXi host of VMware 8.0b has hypervisor version <IP_ADDRESS>. It is different from previous versions, for example, ESXi host of VMware 7.0 update 3a/3b/3c have the same hypervisor version <IP_ADDRESS> (not <IP_ADDRESS>/<IP_ADDRESS>/<IP_ADDRESS>).
This PR adds an extra step to determine the guest os mappings for a hypervisor version: If guest os mapping does not exist, then search for the guest os mapping of parent version. For example
X if guest os mapping of <IP_ADDRESS> does not exist, then search for guest os mapping for 8.0
X if guest os mapping of <IP_ADDRESS> does not exist, then search for guest os mapping for 8.0.3
Based on this, we do not need to add guest os mappings for 8.0b (<IP_ADDRESS>) and 8.0c (<IP_ADDRESS>), the guest os mappings for VMware 8.0 will be used.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5805

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5825

Trillian test result (tid-6381)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42108 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6381-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Trillian test result (tid-6414)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 43090 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6414-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-6415)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 41770 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6415-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan alma8 vmware-80

@blueorangutan alma8 vmware-80

@blueorangutan test alma8 vmware-80

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5972

@weizhouapache a Trillian-Jenkins test job (rocky8 mgmt + vmware-80u1) has been kicked to run smoke tests

@blueorangutan test rocky8 vmware-80

@blueorangutan test alma8 vmware-80

@weizhouapache a Trillian-Jenkins test job (alma8 mgmt + vmware-80) has been kicked to run smoke tests

Trillian test result (tid-6457)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server a8
Total time taken: 44355 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6457-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-6458)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44965 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6458-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_arping_in_ssvm
Failure
5.24
test_diagnostics.py

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

 It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5989

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5990

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5991

Trillian test result (tid-6478)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42158 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6478-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-6480)
Environment: vmware-80u1 (x2), Advanced Networking with Mgmt server r8
Total time taken: 64489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6480-vmware-80u1.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_invalid_upgrade_kubernetes_cluster
Failure
3618.39
test_kubernetes_clusters.py

test_02_upgrade_kubernetes_cluster
Failure
3621.45
test_kubernetes_clusters.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
0.12
test_kubernetes_clusters.py

test_04_autoscale_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_05_basic_lifecycle_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_06_delete_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
49.32
test_kubernetes_clusters.py

test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
Failure
628.09
test_internal_lb.py

test_04_rvpc_internallb_haproxy_stats_on_all_interfaces
Failure
261.48
test_internal_lb.py

Trillian test result (tid-6479)
Environment: vmware-80u1 (x2), Advanced Networking with Mgmt server r8
Total time taken: 65966 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6479-vmware-80u1.zip
Smoke tests completed. 104 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_volume_usage
Error
94.51
test_usage.py

test_01_invalid_upgrade_kubernetes_cluster
Failure
3610.24
test_kubernetes_clusters.py

test_02_upgrade_kubernetes_cluster
Failure
3618.36
test_kubernetes_clusters.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
0.06
test_kubernetes_clusters.py

test_04_autoscale_kubernetes_cluster
Failure
0.06
test_kubernetes_clusters.py

test_05_basic_lifecycle_kubernetes_cluster
Failure
0.06
test_kubernetes_clusters.py

test_06_delete_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.06
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
45.92
test_kubernetes_clusters.py

test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
Failure
626.64
test_internal_lb.py

test_03_vpc_internallb_haproxy_stats_on_all_interfaces
Failure
180.50
test_internal_lb.py

test_04_rvpc_internallb_haproxy_stats_on_all_interfaces
Failure
269.08
test_internal_lb.py

test_01_isolate_network_FW_PF_default_routes_egress_true
Failure
156.95
test_routers_network_ops.py

test_02_isolate_network_FW_PF_default_routes_egress_false
Failure
179.48
test_routers_network_ops.py

test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
Failure
191.81
test_routers_network_ops.py

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
Failure
220.36
test_routers_network_ops.py

Trillian Build Failed (tid-6498)

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan SFpackage

@blueorangutan package

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6179

@blueorangutan LLtest rocky8 vmware-80

@weizhouapache a [LL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

[LL] Trillian Build Failed (tid-6561)

@blueorangutan test rocky8 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

[SF] Trillian test result (tid-6625)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 43154 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6625-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6187

@blueorangutan test ubuntu22 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

@blueorangutan test rocky8 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

[SF] Trillian test result (tid-6660)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45069 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6660-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan test matrix

[SF] Trillian test result (tid-6674)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39053 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6674-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-6676)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40290 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6676-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan package

@borisstoyanov a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6288

@blueorangutan test vmware

[SF] Trillian test result (tid-6813)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56644 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6813-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_deploy_vm_on_specific_host
Error
17.58
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
3601.95
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
1.21
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
2.24
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
2.22
test_vm_deployment_planner.py

@blueorangutan test vmware keepEnv

@blueorangutan help

@borisstoyanov [SF] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv]
Mgmt OS options: ['centos7', 'centos6', 'suse15', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'rocky8', 'alma9']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.
Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'kishankavala', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'mlsorensen', 'oscaralvaro']

[SF] Trillian test result (tid-6822)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48103 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6822-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Thanks @weizhouapache could you merge latest main

thanks @rohityadavcloud
done merged latest 4.18

@blueorangutan package

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6545

[SF] Trillian Build Failed (tid-7151)

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6552

[SF] Trillian Build Failed (tid-7153)

[SF] Trillian test result (tid-7157)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 45927 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7157-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan package

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6577

@blueorangutan package

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6584

@blueorangutan test rocky8 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

@blueorangutan package

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6590

@blueorangutan test u22 vmware-80

@weizhouapache [SF] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

@blueorangutan test ubuntu22 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

[SF] Trillian test result (tid-7191)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 54531 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7191-vmware-80.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_deploy_vm_on_specific_host
Error
12.57
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
3603.32
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
4.40
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
2.37
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
2.30
test_vm_deployment_planner.py

test_09_expunge_vm
Failure
424.64
test_vm_life_cycle.py

[SF] Trillian test result (tid-7194)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 43299 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7194-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

cc @weizhouapache @borisstoyanov @DaanHoogland @NuxRo I've started a discussion thread on VMware forum - https://communities.vmware.com/t5/ESXi-Discussions/VMware-disk-errors-when-booting-on-ESXi-8-0u1a/m-p/2980935#M289426
I tried to setup a mbx template and I can consistently reproduce issues with VMware 8.0u1a esxi (I think vcenter isn't an issue), I tried both NFS and local/datastore on ESXi 8.0u1 (using latest build/iso VMware-VMvisor-Installer-8.0U1a-21813344.x86_64.iso).

is this ready for review/merging @weizhouapache @DaanHoogland @NuxRo ?

is this ready for review/merging @weizhouapache @DaanHoogland @NuxRo ?

@rohityadavcloud
Andrija is doing final review/testing

cc @weizhouapache @borisstoyanov @DaanHoogland @NuxRo I've started a discussion thread on VMware forum - https://communities.vmware.com/t5/ESXi-Discussions/VMware-disk-errors-when-booting-on-ESXi-8-0u1a/m-p/2980935#M289426
I tried to setup a mbx template and I can consistently reproduce issues with VMware 8.0u1a esxi (I think vcenter isn't an issue), I tried both NFS and local/datastore on ESXi 8.0u1 (using latest build/iso VMware-VMvisor-Installer-8.0U1a-21813344.x86_64.iso).

thanks @rohityadavcloud
I have created a github issue #7572 for follow-up

@blueorangutan package

@blueorangutan LLpackage

@andrijapanicsb a [LL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@andrijapanicsb a [LL] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

@blueorangutan test rocky8 vmware-80

@blueorangutan LLtest rocky8 vmware-80

[LL] Trillian Build Failed (tid-6691)

[LL] Trillian Build Failed (tid-6692)

@blueorangutan LLtest ubuntu22 vmware-80

@andrijapanicsb a [LL] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6771

@blueorangutan test ubuntu22 vmware-80

@blueorangutan test rocky8 vmware-80

@andrijapanicsb a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

@blueorangutan test ubuntu22 vmware-80

@andrijapanicsb a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

[LL]Trillian test result (tid-6693)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 45726 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6693-vmware-80.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_04_rvpc_internallb_haproxy_stats_on_all_interfaces
Error
193.87
test_internal_lb.py

test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
Error
131.06
test_routers_network_ops.py

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
Error
160.30
test_routers_network_ops.py

[SF] Trillian test result (tid-7407)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46606 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7407-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_create_pvlan_network
Error
0.09
test_pvlan.py

[LL]Trillian test result (tid-6694)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50983 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6694-vmware-80.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_port_fwd_on_non_src_nat
Error
13.52
test_network.py

test_01_deploy_vm_on_specific_host
Error
18.57
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
3602.66
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
1.23
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
2.23
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
2.24
test_vm_deployment_planner.py

[SF] Trillian test result (tid-7408)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 52410 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7408-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_router_dhcphosts
Failure
146.75
test_router_dhcphosts.py

@blueorangutan test rocky8 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

@blueorangutan test rocky8 vmware-67u3

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan test ubuntu22 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

[SF] Trillian test result (tid-7428)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 51176 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7428-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_list_cpvm_vm
Failure
0.06
test_ssvm.py

test_04_cpvm_internals
Failure
0.05
test_ssvm.py

test_12_destroy_cpvm
Error
6.31
test_ssvm.py

[SF] Trillian test result (tid-7427)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 52790 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7427-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_deploy_vm_on_specific_host
Error
26.95
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
3605.14
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
1.39
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
4.46
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
1.33
test_vm_deployment_planner.py

[SF] Trillian test result (tid-7426)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53187 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7426-vmware-80.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
378.91
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.09
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
4052.65
test_kubernetes_clusters.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
486.80
test_vpc_redundant.py

@blueorangutan test ubuntu22 vmware-80

@blueorangutan test rocky8 vmware-67u3

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan test ubuntu22 vmware-80

@weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

[SF] Trillian test result (tid-7448)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42970 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7448-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


api_client can not finish whole words, because the stream is end too early

Self Checks

[X] This template is only for bug reports. For questions, please visit Discussions.
[X] I have thoroughly reviewed the project documentation (installation, training, inference) but couldn't find information to solve my problem. English 中文 日本語 Portuguese (Brazil)
[X] I have searched for existing issues, including closed ones. Search issues
[X] I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
[X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
[X] Please do not modify this template and fill in all required fields.

Cloud or Self Hosted
Self Hosted (Source)
Environment Details
macOS python 3.12
            stream_stopped_flag = False

            try:
                for chunk in response.iter_content(chunk_size=1024):
                    if chunk:
                        stream.write(chunk)
                        wf.writeframesraw(chunk)
                    else:
                        if not stream_stopped_flag:
                            stream.stop_stream()
                            stream_stopped_flag = True
            finally:
                stream.close()
                p.terminate()
                wf.close()

Steps to Reproduce
python -m tools.api_client -t '.......'
✔ Expected Behavior
check stream status before close
❌ Actual Behavior
can not streaming all wav, close before end

just wait for stream finishing:
                    finally:
                        while stream.is_active() or stream.get_output_latency() > 0.1:
                            time.sleep(0.1)  # Wait for the stream to finish playing
                        stream.close()
                        p.terminate()
                        wf.close()

just wait for stream finishing:
                    finally:
                        while stream.is_active() or stream.get_output_latency() > 0.1:
                            time.sleep(0.1)  # Wait for the stream to finish playing
                        stream.close()
                        p.terminate()
                        wf.close()

Does this fix the problem?

just wait for stream finishing:
                    finally:
                        while stream.is_active() or stream.get_output_latency() > 0.1:
                            time.sleep(0.1)  # Wait for the stream to finish playing
                        stream.close()
                        p.terminate()
                        wf.close()

Does this fix the problem?

Yes

You can open a pull request to fix this :)

done


Create 2017.7 Python 2.7 install rpm for Amazon and Redhat 7 & 6

[x] Redhat 7
[x] Redhat 6
[x] Amazon

Had wrong extension for platform for Amazon, had el7, corrected not to amzn1, that is http://repo.saltstack.com/yum/amazon/salt-amzn-repo-2017.7-1.amzn1.noarch.rpm