Empty space between item and header.

Hey there,
First of all, thanks for the great library! Onto the issue...
There's an empty space between one of the items and the pull to refresh item.
Here's the demostration.

Btw, I would love to donate to keep the library ongoing, so if you create a paypal account or similar let me know! I'll be happy to invite you some coffees :-)

If I remove the CupertinoNavigationBar, the problem is gone.

For anyone experiencing this, I just moved to the https://pub.dartlang.org/packages/loadmore library.

I've just tested that without using my library, this problem still occurs.

Oh,This is not a Bug.Using SafeArea that the problem is solved.
   new SafeArea(
      child: new SmartRefresher(.....)
  )


Add interactive mode for unit testing

What I did
Add the --interactive flag to open a console during testing.  Closes #443.
How I did it

Use the pytest_exception_interact plugin hook to enter a brownie Console on a failed test, if the --interactive flag is active.
Add a variant of _sitebuiltins.Quitter to handle quit and exit commands without closing stdin.
Tests and docs

How to verify it
Run tests.

Codecov Report

Merging #456 into master will decrease coverage by 2.92%.
The diff coverage is 43.33%.

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   88.22%   85.30%   -2.93%
==========================================
  Files          56       56
  Lines        5911     5939      +28
  Branches     1300     1304       +4
==========================================
- Hits         5215     5066     -149
- Misses        484      638     +154
- Partials      212      235      +23

Impacted Files
Coverage Δ

brownie/_cli/test.py
85.00% <ø> (ø)

brownie/test/managers/runner.py
52.97% <17.64%> (-36.32%)
:arrow_down:

brownie/test/plugin.py
65.62% <33.33%> (-20.59%)
:arrow_down:

brownie/_cli/console.py
56.93% <90.00%> (+1.21%)
:arrow_up:

brownie/test/managers/master.py
32.25% <0.00%> (-61.30%)
:arrow_down:

brownie/test/__init__.py
42.10% <0.00%> (-57.90%)
:arrow_down:

brownie/test/fixtures.py
59.45% <0.00%> (-33.79%)
:arrow_down:

brownie/test/managers/base.py
61.70% <0.00%> (-18.09%)
:arrow_down:

brownie/test/coverage.py
86.66% <0.00%> (-13.34%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1576f9...bf66dec. Read the comment docs.


Create namespace while installing helm chart by default

addresses #87
also I have made RollingUpdate as default Deployment Strategy to avoid any downtime while deploying Pyroscope.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I wanted to ask, Why we didn't set the deploymentStrategy as RollingUpdate ?
Was it the multi-attach error of PVC?

I'm afraid some of the formatting changes broke helm-doc – @k4kratik could you check the CI job log please?

Thank you @k4kratik, nice job!

Thanks! @kolesnikovae


What is the "AS" variable in the bilateralfilter.cpp

Thanks for sharing this code. Great job.
Would you kindly tell me what the "AS" variable means in your bilateralfilter.cpp
https://github.com/meng-tang/rloss/blob/d9b16fb9f433badec844ebdf93353e470a92883f/pytorch/pytorch-deeplab_v3_plus/DenseCRFLoss.py#L32

AS means the affinity matrix A (HW x HW) times the segmentation S (HW x C) with C classes.
So AS is of dimension HW x C. It is essentially bilateral filtering if A is a matrix with Gaussian kernel.
This computation is accelerated by fast bilateral filtering for dense Gaussian.

Thanks! I get what you mean. And in the code, I think the AS should be vectorized one.


chore: migrate from tslint to eslint

This PR is meant to address https://github.com/aws-observability/aws-rum-web/issues/9.
Changes:

Replacing tslint with eslint using tslint-to-eslint-config
Running autofix across the codebase
Updating package.json commands related to linting
Addressing detected issues by fixing them/marking as warn/turning them off (since I don't work for AWS I don't want to impose my opinions on the codebase)

Due to number of detected issues, the following rules were disabled/marked as warn by me:
        '@typescript-eslint/no-unsafe-call': 'warn',
        '@typescript-eslint/no-unsafe-argument': 'warn',
        '@typescript-eslint/no-unsafe-return': 'warn',
        '@typescript-eslint/ban-ts-comment': 'warn',
        '@typescript-eslint/no-misused-promises': 'warn',
        'prefer-rest-params': 'warn',
        '@typescript-eslint/no-floating-promises': 'warn',
        '@typescript-eslint/no-namespace': 'warn',
        '@typescript-eslint/restrict-template-expressions': 'off',
        '@typescript-eslint/no-unsafe-assignment': 'warn',
        '@typescript-eslint/require-await': 'warn',
        '@typescript-eslint/no-unsafe-member-access': 'warn',
        '@typescript-eslint/no-this-alias': 'warn',

Running npm run lint outputs the following:
✖ 1398 problems (0 errors, 1398 warnings)

Running npm run lint:errors (which only fails on lint errors) does not return any errors.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is awesome, thanks! I noticed this after working on #237 .

Addressing detected issues by fixing them/marking as warn/turning them off

Thank you; for the sake of this CR I appreciate that the change is minimal. We can work towards migrating these from warnings to errors.


Ignore ActiveJob::DeserializationError by default

See #642. Activejob deserialization errors are pretty common, usually raised when we deleted the record we were going to process in a background job:
class PopulateDocsJob < ApplicationJob
  def perform(repo)
    repo.populate_docs!
  end
end

However, if you have an async config that looks like:
class SentryJob < ApplicationJob
  queue_as :default

  def perform(event)
    Raven.send_event(event)
  end
end

and repo isn't found, you'll raise ActiveJob::DeserializationError and blow up your Sidekiq instance as we run into an infinite loop.
Since ActiveJob::DeserializationError is basically a NotFound error, we should ignore it by default, just like all the other NotFound errors we ignore by default.

Hmm,  we do not ignore ActiveRecord::RecordNotFound in our application. The same goes for ActiveJob::DeserializationError. I want to be informed when it happens so I can check what is wrong.

@mrhead What do you have excluded_exceptions set to in your config, then?
I opened this issue after realizing 99% of the ActiveJob::DeserializationErrors that I see are just from records being deleted between the job being enqueued and the job executing. They're just noise.

To this:
config.excluded_exceptions = ["ActionController::RoutingError", "ActionController::BadRequest"]

ActiveJob::DeserializationErrors happen also when you schedule a job from a DB transaction and the job is executed before the transaction is committed. While, this is usually harmless because Sidekiq just restarts the job and then it finish successfully, it can be an issue if for whatever reason you set number of retries to 0.
On the other hand I agree that this is just a noise and probably nothing bad happens if these errors get ignored.

I've just received an ActiveJob::DeserializationError and I realized that one reason why I care about these errors is that I know when they happen and I can manually clear the Sidekiq queue and/or make sure that these errors don't happen anymore.


Added support for dark mode

This fixes #456.
The HTML this plugin generates is a little more complex now. We generate 3 variants of each graph now:

One dark theme variant.
One light theme variant.
One code block variant.

The code block is a fallback in case the mermaid library failed to load or JavaScript is disabled by the user.
CSS is used to only ever show one of the 3 variants.
Some implementation details

I used body.light, :root[data-theme="light"] to support 0.22.x (see TypeStrong/typedoc#1764) and the upcoming 0.23 (see TypeStrong/typedoc#1706).
The whole code around requestAnimationFrame is necessary because mermaid.js adds the data-processed="true" attribute before the SVG is inserted. This causes problems because we can only hide the wrong dark/light theme variant after its SVG has been inserted.

Screenshots

Dark mode:

Light mode:

No JS:

@RunDevelopment
Sorry for the late review time.
LGTM, merged.


All day event does not work when timezone is different in client environment

Current GMT + 9 only. Need to find the way to save data and read data properly

Need to fix #41 first. Then, we can think about the specifications for user with different time zone.

https://social.technet.microsoft.com/Forums/lync/en-US/2a0e022b-b216-49d9-a421-f32ab74238ae/all-day-calendar-events-and-different-time-zones?forum=outlook

Go with Google's design that timezone does not have any effect on all-day events.


Give a flag in space-cli to disable installation of dbevents. By default dbevents will be installed

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Done in v0.21.0


Generating complete schematic out of VHDL files

Hello, do you think one day symbolator could be used to parse one or more VHDL files to generate a schematic of the instanced components/wires?

You may be looking to use something like netlistsvg. I wrote a blog post on how to generate blog diagrams from VHDL using the open source FPGA toolchain here.

If you are using Sphinx, you might also want to consider https://sphinxcontrib-hdl-diagrams.readthedocs.io/en/latest/


[CGP-296] Support Void# and void#

These are the uninhabited type and an inhabitant for that type (to use
in unreachable cases).
In Plutus we can represent Void# as (all a (type) a), which is
uninhabited, and then fortunately we can actually create a value to put
there, namely (abs a (type) (error a)).

I don't think you can use (abs a (type) (error a)).  The spec currently only allows (abs a K V) where V is a value, and (error a) is a term, not a value.  Chad has been having some trouble with this.  It appears that the restriction to V is deliberate, but I don't know what the rationale for that is (before my time).

Ah yes, this did come up before. I think that's just wrong, IMO. I'll open an issue for discussing it.

(I posted to the list)
I'm going to leave this open because I'm pretty sure this is the right thing to do.

In fact this is no more broken than the current setup, which already does this for error things, so I'm going to merge this and consider the abstraction issue as a future problem.


Drop use of new keyword after migration to Dart 2.0

Since the package depends on Dart 2.0 now and has analysis lints warning of the use of new keyword, I went ahead and dropped the use of new keyword.

Since the build failed for #8 , I merged the commit from this PR into the other PR so the build would pass. @pulyaevskiy Please add an invalid tag to this PR so Digital Ocean does not count it towards my Hacktoberfest PRs


Create a "momentum" trading agent

Create a trading agent that follows a momentum trading strategy (which can be configured based on various parameters).
Step 1 of solving this issue would be finding some basic literature on what momentum strategies look like

TA-Lib could be useful for this


Update cdap-hbase-compat requirements

Support for HBase 0.98 was added in CDAP 2.6
Support for HBase 0.94 was dropped in CDAP 3.1
Remove support for 2.5.9xxx CDAP pre-releases

rubocop not happy, otherwise :+1: on the logic

Yeah, fixed Rubocop in second commit. Will wait for it to pass and merge.


Implement Stochastic reconfiguration and Linear method optimization

https://arxiv.org/pdf/1108.0900.pdf


Cannot send funds from my phone without VPN

When I try to send funds back to the faucet from my phone, I run into problems. The wallet prompts me for the password, and after entering it just hangs on the "Processing..." screen as displayed in the screenshot. After closing and restarting the wallet, the logs don't show any activity of the tx.
What's even more strange: when I use my phone with VPN, the transaction does sometimes get through (not always). If successful, the tx processing is quick and shows up in the logs.
EDIT: my phone (Moto G5) is running Android 7.0

Could it be that some Android settings are disabling outgoing traffic? Maybe the app needs special permissions in order to bypass these standard restrictions?

It seems that the app simply freezes when I click to confirm the transaction, because even when I enter a wrong password the wallet gets stuck on the "Processing..." screen (as shown above).

My guess is it is not related to VPN, but is rather a bug that occurs during sending which only occurs intermittently. After getting back into the app, you can check the wallet log from the settings menu and see if there are any other clues left over from the previous session. Many of the other freezes are caused by db writes and this has a good chance of being the same.

New release fixed my bug. Indeed it wasn't related to my network. Glad to see it fixed!


[SPARK-32879][SQL] Refactor SparkSession initial options

What changes were proposed in this pull request?
This PR refactors the way we propagate the options from the SparkSession.Builder to the SessionState. This currently done via a mutable map inside the SparkSession. These setting settings are then applied after the Session. This is a bit confusing when you expect something to be set when constructing the SessionState. This PR passes the options as a constructor parameter to the SessionStateBuilder and this will set the options when the configuration is created.
Why are the changes needed?
It makes it easier to reason about the configurations set in a SessionState than before. We recently had an incident where someone was using SparkSessionExtensions to create a planner rule that relied on a conf to be set. While this is in itself probably incorrect usage, it still illustrated this somewhat funky behavior.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33291/
Test PASSed.

Test build #128668 has started for PR 29752 at commit 73400ed.

Test build #128668 has finished for PR 29752 at commit 73400ed.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveSessionStateBuilder(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128668/
Test FAILed.

Test build #128671 has started for PR 29752 at commit 1543aaf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33294/
Test PASSed.

+1 I like this idea.

Test build #128671 has finished for PR 29752 at commit 1543aaf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128671/
Test PASSed.

thanks, merging to master!


[SPARK-20456][Docs] Add examples for functions collection for pyspark

What changes were proposed in this pull request?
This adds documentation to many functions in pyspark.sql.functions.py:
upper, lower, reverse, unix_timestamp, from_unixtime, rand, randn, collect_list, collect_set, lit
Add units to the trigonometry functions.
Renames columns in datetime examples to be more informative.
Adds links between some functions.
How was this patch tested?
./dev/lint-python
python python/pyspark/sql/functions.py
./python/run-tests.py --module pyspark-sql

@HyukjinKwon I ended up not making examples for the aggregate functions, as I didn't make a good dataframe to demonstrate them. I could add more examples for the string functions if you think that is a good idea. There are dozens of functions that could be documented, I'm not sure how far we want to go, or which ones need it.

Can one of the admins verify this patch?

ok to test

Test build #76477 has started for PR 17865 at commit 91515c6.

Test build #76477 has finished for PR 17865 at commit 91515c6.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76477/
Test FAILed.

Merged build finished. Test FAILed.

(Thank you @gatorsmile for triggering the test)

Could you please check the documents we did in Scala APIs? It sounds like we forgot to update the Python function descriptions when we did the change in the Scala APIs.

@gatorsmile I checked four functions, approx_count_distinct, coalesce, covar_samp, and countDistinct, comparing the python and Scala documentation. None of them are the same. My guess is that the python docs differ for most functions.

Test build #76625 has started for PR 17865 at commit ca8b5f7.

Test build #76625 has finished for PR 17865 at commit ca8b5f7.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76625/
Test FAILed.

@map222 Unfortunately, our PySpark did not follow what we did in Scala. Will review it more carefully in the future. Thanks!

Most recent commit reverts the "if" to "iff", changes all the backticks for column names to single backtick, and tried new :param: option for angle columns.

Test build #76763 has started for PR 17865 at commit dd7a397.

Test build #76763 has finished for PR 17865 at commit dd7a397.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76763/
Test PASSed.

Could I get a review for this? I think the only remaining questions is whether (and how) to note the units for the trigonometry functions, like here:
https://github.com/map222/spark/blob/dd7a3971275aae97f9adfd82166df23b038eb950/python/pyspark/sql/functions.py#L100-L105

@HyukjinKwon @gatorsmile bump

Also cc @ueshin

Will take a look to help too soon. Sorry for the delay.

Test build #78029 has started for PR 17865 at commit a61173f.

Test build #78029 has finished for PR 17865 at commit a61173f.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78029/
Test FAILed.

Test build #78031 has started for PR 17865 at commit 8c34c8b.

Test build #78031 has finished for PR 17865 at commit 8c34c8b.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78031/
Test FAILed.

Thanks for working on this :) More complete documentation is certainly useful. Looking at the "How was this patch tested?" section you might also want to build the docs (there are instructions in docs/README.md) to see how stuff is formatted.

Test build #78158 has started for PR 17865 at commit 29bcb67.

Test build #78159 has started for PR 17865 at commit b4c04e7.

Ok, I removed the ignore_unicode_prefix, and it didn't have any test problems. Also removed the date column renames where the original name was ok. Finally, removed the string function documentation.

Test build #78158 has finished for PR 17865 at commit 29bcb67.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78158/
Test FAILed.

Merged build finished. Test FAILed.

Test build #78159 has finished for PR 17865 at commit b4c04e7.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78159/
Test FAILed.

Test build #78183 has started for PR 17865 at commit 89138ea.

Test build #78183 has finished for PR 17865 at commit 89138ea.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78183/
Test FAILed.

Test build #78188 has started for PR 17865 at commit e1bb723.

Test build #78189 has started for PR 17865 at commit e6cb8a1.

Test build #78188 has finished for PR 17865 at commit e1bb723.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78188/
Test PASSed.

@HyukjinKwon I could not get it to pass the tests without the unicode and ignore_unicode_prefix

Test build #78189 has finished for PR 17865 at commit e6cb8a1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78189/
Test PASSed.

Merged build finished. Test PASSed.

@HyukjinKwon I think I addressed all of your comments. Thank you for your detailed review!

Test build #78586 has started for PR 17865 at commit 9e1e9e1.

Test build #78586 has finished for PR 17865 at commit 9e1e9e1.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78586/
Test FAILed.

Test build #79118 has started for PR 17865 at commit f17f332.

I think I addressed everything.

Looks like there is a merge conflict. Can you fix it?

Do I just have to git rebase on master?

Yes, or you can merge master and fix the conflict.

Test build #79118 has finished for PR 17865 at commit f17f332.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79118/
Test PASSed.

Build finished. Test PASSed.

Test build #79162 has started for PR 17865 at commit f5d0d0f.

Test build #79162 has finished for PR 17865 at commit f5d0d0f.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79162/
Test FAILed.

Test build #79163 has started for PR 17865 at commit e7935d1.

Test build #79163 has finished for PR 17865 at commit e7935d1.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79163/
Test FAILed.

Test build #79164 has started for PR 17865 at commit 2c9898b.

Test build #79164 has finished for PR 17865 at commit 2c9898b.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79164/
Test FAILed.

Test build #79165 has started for PR 17865 at commit 60af595.

Test build #79165 has finished for PR 17865 at commit 60af595.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79165/
Test PASSed.

Test build #79189 has started for PR 17865 at commit 9cc34c8.

Test build #79189 has finished for PR 17865 at commit 9cc34c8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79189/
Test FAILed.

Jenkins, retest this please.

Test build #79207 has started for PR 17865 at commit 9cc34c8.

Test build #79207 has finished for PR 17865 at commit 9cc34c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79207/
Test PASSed.

I switched the examples to numeric examples so that we could avoid using ignore_unicode_prefix, as requested by @HyukjinKwon in this commit

How about https://github.com/apache/spark/pull/17865/files#r123964695 ?

Yea. For https://github.com/apache/spark/pull/17865#issuecomment-313303801, just to explain the context (as it is a bit confusing even to me), it was suggested to use ignore_unicode_prefix for single instance when the example has an unicode in the doctest or to remove the unicode in the doctest if possible (either should be fine).
I also suggested to not use it for unrelated docstrings - https://github.com/apache/spark/pull/17865#discussion_r121539034.

Test build #79343 has started for PR 17865 at commit 7dbf35f.

Test build #79343 has finished for PR 17865 at commit 7dbf35f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79343/
Test PASSed.

Merged build finished. Test PASSed.

LGTM.

LGTM too.

merged to master. thanks!


Updated node engine version on package.json

This PR updates node engine version on package.json config file.
The versions accepted are all from v8.0.0 until v9 (last one not included). Version 8 is the current Long Term Support (LTS) version of node.
Feel free to use this PR thread to discuss further about this change.

I think this is sensible as well. I was using 8.9.2 locally, and without this change I had to instal another version of node.

Maybe when we upgrade to node 9 (no idea what that would imply) we could be a bit more strict. In the rails side we use a specific version of ruby, but as most people use RVM or RBENV and these respect the .ruby-version file, this is easier to manage. with node I do use nvm, if everyone uses it then it would be simpler to use a more specific version.


2 Factor Authentication

At some point we should consider adding 2FA to the guardian UI in particular

Note that this would require a fundamental change (huge improvement) of our API auth scheme: We wouldn't just send a static secret with every request but rather acquire a session token on login which can then be used for a limited time to authenticate API requests. So this is also a Fedimint issue.


PDF does not display when hosted on IIS

I downloaded PDF.js and double clicked on viewer.html file. It displayed the default PDF without any issues. I am using FF 35.
Then I uploaded whole folder on Windows 2003 machine and double clicked on viewer.html but it didn't display PDF. It only displayed the container like buttons, page number etc.
Then I hosted it on IIS on same machine (Windows 2003) and tried to view it in browser as follows but it didn't display the PDF. It only displayed the container like buttons, page number etc.
http://myserver/viewer.html?file=http://myserver/test.pdf
On this machine I am using Chrome 32.0.1700.76.
How to fix this issue?
EDIT
I tested it on another machine on IE10 and same issue.

Please provide error messages, etc. See https://github.com/mozilla/pdf.js/blob/master/CONTRIBUTING.md.

There is not error. Please see attached screenshot. This is how it looks like. It doesn't load default PDF document. Even if I provide "file" parameter it doesn't display anything.

Open the JavaScript console (Ctrl + Shift + J) and look for error messages over there.

I am getting error in viewer.js on line 5925.
Uncaught TypeError: Object # has no method 'shadow'

Your PDF.js build is incorrectly set up. Which instructions did you follow to set up PDF.js?

I am using generic build of PDF.js from this page.
https://mozilla.github.io/pdf.js/getting_started/#download

Ok this is fixed now. I was using some other PDF.js not the generic one. Replacing it with generic PDF.js fixed the problem.


Chunk Store docs for Bigtable

Hey Tom,
We'll trying out Cortex as our long-term Prometheus storage. However, we probably will consider moving it to GCE's Bigtable.
A couple of questions from the chunk_store implementation, before we start the spike:
Chunk storage:
What's the size of the ChunkData - we're considering storing Chunks inside Bigtable along with the index. What's the latency impact of reading from blob storage (S3, GCS) of Chunks? Why did you chose to store them in S3? Because of DynamoDB write sizes?
Schemas:
I see that compositeSchema switches between different versions. Is v4 the one currently used? Any particular tips on why you chose v4 layout? We're thinking about a tall-but-narrow scheme for bigtable that is a concatenation of your v3 hash key and range key.
I expect the only real thing that would need implementing is the chunk.Store interface? Is there anything else we're missing?
Thanks,
Michal

Hi Michal!  Great news.  I have a local branch which makes the underlying storage interface much more abstract (I was playing with putting this on Cassandra).  I'll tidy this up and push this.

What's the size of the ChunkData?

Chunks are all 1Kb.   This can be changes, but increasing it can make compression less effective, so theres a tradeoff to be had here.

What's the latency impact of reading from blob storage (S3, GCS) of Chunks?

S3 is sloooow for small random reads.  There is a memcache layer, and we ensure its sized big enough to have virtually 100% hit rate.  Only queries for very old data will hit S3, and we deem it acceptable for these queries acceptable to be slightly slower. S3 is massively parallelisable (and the chunk store does indeed fetch in parallel) so the net effect is queries that hit s3 take ~1s at 99%-ile.

Why did you chose to store them in S3?

DynamoDB is expensive.  If we put the chunks in there, it would make the system cost too much to run (for us to sell).  So its a trade off.  They would have fit in DynamoDB easily...
I'm planning on introducing the idea of "super chunks", where 10 or so chunks worth of data is written to S3 in a single object.  I need to experiment with sub-object get first, but this should reduce the cost of running the system further without any perceptible performance impact.

I see that compositeSchema switches between different versions. Is v4 the one currently used?

This was literally merged yesterday!  We're not running v4 in prod yet - its in dev, and it seems to have held up for ~9:45hrs...

Any particular tips on why you chose v4 layout?

Yes - v3 and all the priors hot spotted DynamoDB too much.  See #254.
Initial results are promising with v4.  You should use this, I expect you'll have similar hotspotting issues with BigTable.

We're thinking about a tall-but-narrow scheme for bigtable that is a concatenation of your v3 hash key and range key.

I'll have to read up on this, and how Cloud BigTable differs from internal BigTable, but if it doesn't differ, you'll need to be careful with the row (range) keys as it'll hotspot the tabletservers.  Let me get back to you on this.

I expect the only real thing that would need implementing is the chunk.Store interface?

I wouldn't cut it at this interface - there is a whole lot of encoded knowledge in the chunk store about how to match selectors (for instance, see #220 for an instance).  I would pick the interface below the chunk store, between it and dynamo/s3 - this is the branch I was referring to above.  This way you can reuse all the chunk store logic (and monitoring) without too much reimplementation.
Let me tidy up and push this branch today and then get back to you - do you want to come over to the weaveworks office for a coffee and chat at some point?

Is there anything else we're missing?

Are you planning on running this on k8s?  Cortex has turned into a bit of a proliferation of jobs, so running it "manually" is a bit of a pain.  I'll grab a copy of our k8s yamls and put them in the repo too, so you've got something to get started with.

UI: cortex doesn't include any UI components right now, its just an API.  I removed the upstream UI code as we have a custom (tab completion etc etc) UI in a separate component.  You'll want to resurrect this as a separate job probably, until we get round to open sourcing the cortex-ui.  Take a peek:

https://drive.google.com/file/d/0BwqTw528sZRINXlRZmNQN2M2RnM/view?usp=sharing

Hi Michal - here the PR I was referring to: #275
This is the interface I'd start with: https://github.com/weaveworks/cortex/pull/275/files#diff-1f696bedb83075f4980d18328df839a7R8
Its not 100% finished yet, and still need to abstract out the chunk storage, but its a start.  I'll probably have it mostly done today.

Thanks for responding quickly and doing the interfaces. Apologies for the slow response, we're a wee-bit snowed under :)
The Cloud Bigtable is very similar to the internal one. Thanks for sharing the knowledge about hot spotting, it will definitely be interesting to see how it plays out.
We'd be deploying to K8S, and we're try it on our AWS clusters first. It'd be great to have som YAMLs, if you got them :) Later, if we find that it fits our existing multi-tenant, multi-stage monitoring pipeline, we'll do the Bigtable port for the primary clusters we use on GCE.

The Cloud Bigtable is very similar to the internal one. Thanks for sharing the knowledge about hot spotting, it will definitely be interesting to see how it plays out.

If thats the case you'll definitely want to use the v4 schema.  Experiments show its pretty good for load balancing, we're getting good results.  I'd hash the hashKey on the client side, stick that in the row key, and use the rangeKey as the columnKey.  Cell contents should be empty.
Doesn't appear you can do prefix matching on the row key, so you might want to do that client side.  Shame the index doesn't make it more efficient.

We'd be deploying to K8S, and we're try it on our AWS clusters first. It'd be great to have some YAMLs, if you got them :)

Here you go, with some instructions: https://github.com/weaveworks/cortex/pull/284

A Bigtable back-end was added in #468


bug(material/tooltip): tooltip inside sidenav hides after text update

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
When the tooltip component overflows a parent sidenav and its text content is updated dynamically, it hides.
We have debugged the code, and this happens because the sidenav component extends the cdk-scrollable.
The piece of code that calls the tooltip hide function is the following:
https://github.com/angular/components/blob/bae953999407fd385b1d571e04350bf0f28abf05/src/material/tooltip/tooltip.ts#L510-L520
Reproduction
Stackblitz url:
https://stackblitz.com/edit/stackblitz-starters-wbd1hh?file=src%2Ftooltip-sidenav%2Ftooltip-sidenav.component.html
As you can see on the stackBlitz example, we have two tooltips:

The tooltip inside the sidenav, which overflows the sidenav component. That if we update the tooltip text, the tooltip disappears. (BUG)
On the other hand, we have the tooltip inside the mat-sidenav-content which works properly, and it doesn't hide after updating it. (WORKS WELL because doesn't overflow the parent)

Expected Behavior
The tooltip inside the sidenav should not hide when the text is updated.
Actual Behavior
The tooltip placed inside the sidnav that overflows is hidden suddenly when the text is updated.
Environment

Angular: v16.2.4
CDK/Material: v16.2.3
Browser(s): Google chrome Versión 116.0.5845.187, Firefox 117.0
Operating System (e.g. Windows, macOS, Ubuntu): Windows

Having a tooltip within a sidenav doesn't seem like a common use case for most apps, it's unlikely this will be priortized in the near future. This issue can be reopened if that changes later.

I don't believe we should close this issue so quickly, @amysorto. We put a lot of effort into providing this report. It includes a detailed description of the issue, a StackBlitz reproduction, and a link to the code that is causing the tooltip to hide.
If it won't be fixed, perhaps we could label it as 'wontfix' or something similar, rather than closing it. Closing the issue might give the impression that it's resolved, which it isn't. Providing a workaround would be enough. I'm sure that one of our core members familiar with the overlay/tooltip codebase can provide one.
Keeping the repository with less issues is good, I agree, but in this case it does not feel right. Tagging the issue with both 'bug' and 'wontfix' would be better IMO.

Thank you for the follow up and for sharing your thoughts! We appreciate the work you put in the issue and the reproduction. As we mentioned above, this is not a common use case, but we’ll reopen and add the “help wanted” label in case anyone from the community has the bandwidth to fix it.

Funny enough, we do use matToolTip in our nav as well, and I found this issue while trying to figure out why tool tips aren't working at all for us in Ng 15. We had some scss to temporarily fix the issue that existed in Ng 14, but it appears that tooltips are broken again. For what it's worth, I figured to just mention that yes, we also use tooltips in our navigation.

After 2 hour debug, I found the problem. Most of all, let's dive into it.

Before I start explain, Let's see when  scrollableViewProperties.isOverlayClipped is true, follow spec:

https://github.com/angular/components/blob/7cb6f3152d627a2e63636da8ed6d405a5bc92092/src/cdk/overlay/position/connected-position.ts#L59-L76
Steps:

Everything start from this function

https://github.com/angular/components/blob/bae953999407fd385b1d571e04350bf0f28abf05/src/material/tooltip/tooltip.ts#L668

After that, it will come to this block and get new value for scrollableViewProperties is true.

https://github.com/angular/components/blob/df60e733c60e572ba538f6ad0ceff3e63e527b53/src/cdk/overlay/position/flexible-connected-position-strategy.ts#L719-L723

Finally, it will emit positionChanges event and hide tooltip

https://github.com/angular/components/blob/bae953999407fd385b1d571e04350bf0f28abf05/src/material/tooltip/tooltip.ts#L510-L520
Solutions:

Solution 1: you need to make Scrollable content larger than tooltip.

https://stackblitz.com/edit/stackblitz-starters-7zrzcu?file=src%2Ftooltip-sidenav%2Ftooltip-sidenav.component.ts,src%2Ftooltip-sidenav%2Ftooltip-sidenav.component.html,src%2Ftooltip-sidenav%2Ftooltip-sidenav.component.css

Solution 2: use runOutsideAngular

https://stackblitz.com/edit/stackblitz-starters-zqpb3p?file=src%2Ftooltip-sidenav%2Ftooltip-sidenav.component.ts

Hi @amysorto , would it be possible to add a property named autoHideOnClip of type boolean to determine whether the tooltip can be hidden when it is clipped ?

Hi team,
I noticed that a solution for this issue was provided on July 27,by @czhang0405. It seems like a solid solution and would be great to see it merged.
Is there anything else needed to move this forward? Let me know if I can assist in any way.
Thanks,
Abd-ur-Rahman


Return Long2 and Long3 hairstyles

About the PR
Return long2 and long3 hairstyles as classic.
Once upon a time, these hairstyles were resprited and completely lost their concept. I think it is necessary to return the old versions as classic ones.
Why / Balance
Just for more customization.
Media
Classic Long 2

Classic Long 3

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl: Just_Art

add: Added Classic Long 2 and Classic Long 3 hairstyles!

please update the copyright information for this hair

How exactly? These hairstyles were originally from https://github.com/tgstation/tgstation/blob/05ec94e46349c35e29ca91e5e97d0c88ae26ad44/icons/mob/species/human/human_face.dmi


What is LightGBMXT(bag LightGBM and XTModel? ) and  LightGBMLarge means?

Describe the issue linked to the documentation
What is the specific implications of these two models: LightGBMXT and  LightGBMLarge?
Suggest a potential alternative/fix
No response

I'm interested to contribute.

王相麾已经收到，谢谢你的来信~

For LightGBMXT, it is simply enabling the extra_trees=True LightGBM hyperparameter. https://github.com/awslabs/autogluon/blob/master/tabular/src/autogluon/tabular/configs/hyperparameter_configs.py#L10
For LightGBMLarge, it is using this hyperparameter config: https://github.com/awslabs/autogluon/blob/master/tabular/src/autogluon/tabular/models/lgb/hyperparameters/parameters.py#L43-L51

Thank you for your answer. I also want to ask is the difference between NeuralNetFastAI and NeuralNetTorch just different platforms? Are there any specific parameter Settings?

For LightGBMXT, it is simply enabling the extra_trees=True LightGBM hyperparameter. https://github.com/awslabs/autogluon/blob/master/tabular/src/autogluon/tabular/configs/hyperparameter_configs.py#L10
For LightGBMLarge, it is using this hyperparameter config: https://github.com/awslabs/autogluon/blob/master/tabular/src/autogluon/tabular/models/lgb/hyperparameters/parameters.py#L43-L51

Thank you for your answer. I also want to ask is the difference between NeuralNetFastAI and NeuralNetTorch just different platforms? Are there any specific parameter Settings?


feat(linter/jsdoc): Implement check-tag-names rule

Part of #1170

https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/rules/check-tag-names.md#user-content-check-tag-names-options-definedtags

(This time, I'm less confident that I have implemented correctly. 😓 )

(This time, I'm less confident that I have implemented correctly. 😓 )

Don't worry too much about it, your domain knowledge increases as you explore more.


Documentation lacking minimal example

Hello and thanks for the library.
The original ESP8266 WifiManager library can be used with default settings using 3 lines of code: 1 include and 2 lines in setup(). (See example: https://github.com/tzapu/WiFiManager/tree/master/examples/AutoConnect). The example with same name in ESPAsync_WiFiManager has whooping 500 lines of code, and it's not immediately clear what it does and what to pull in my code to have default functionality, e.g. start captive portal and connect the board to WiFi without having to hardcode the ESSID/password.
Please, provide a minimal example of this typical usecase, if one is possible.

I just hope anybody using this library spending some time to look at the examples, understand and test them to have much better knowledge that will definitely benefit in the long run.
I really don't expect any user uses as fast food, without spending any time with it. The versatility and functionality are what I like to provide to the library's users, not just simplicity without any long term benefit.
Anyway, I've just  created several dead-simple examples which I just hope anybody could do, simply by deleting the unwanted portions of code

Simplest Possible

Async_AutoConnect_ESP32_minimal
Async_AutoConnect_ESP8266_minimal
Async_ConfigOnDRD_ESP32_minimal
Async_ConfigOnDRD_ESP8266_minimal

Amazing, thank you!


There are no non-deprecated 1-channel texture formats for desktop

The formats GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA and GL_INTENSITY have been deprecated in OpenGL (non-ES), long ago. There are still one and two channel formats — GL_RED and GL_RG.
But Gdx2DPixmap doesn't know about these non-deprecated formats as can be seen from this code:
	public static int toGlFormat (int format) {
		switch (format) {
		case GDX2D_FORMAT_ALPHA:
			return GL20.GL_ALPHA;
		case GDX2D_FORMAT_LUMINANCE_ALPHA:
			return GL20.GL_LUMINANCE_ALPHA;
		case GDX2D_FORMAT_RGB888:
		case GDX2D_FORMAT_RGB565:
			return GL20.GL_RGB;
		case GDX2D_FORMAT_RGBA8888:
		case GDX2D_FORMAT_RGBA4444:
			return GL20.GL_RGBA;
		default:
			throw new GdxRuntimeException("unknown format: " + format);
		}
	}

I think it should be possible to use 1 and 2 channel textures with libgdx on newest hardware (which might drop support for deprecated OpenGL features)

Possible duplicate of #4029

@xoppa oh yeah, that's pretty much what I wanted to say.


Wrong Reset_Reason Set (IDFGH-4816)

Hey,
I'm currently facing the problem that I can't seem to get a proper reset reason. From the get reset reason function.
It always shows SW_CPU_RESET regardless if its a panic or a watchdog. The POWER_ON_RESET is displayed properly.
I'm testing some startup functionality in my code by forcing a Watchdog ISR to occur by simply not resetting the timer.
I'm basically using the code from the task_watchdog example.
The Logoutput is:

...
E (16293) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (16293) task_wdt:  - cb_evt_task (CPU 1)
E (16293) task_wdt: Tasks currently running:
E (16293) task_wdt: CPU 0: IDLE
E (16293) task_wdt: CPU 1: IDLE
E (16293) task_wdt: Aborting.
ets Jun  8 2016 00:22:57
rst:0xc (SW_CPU_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
....

The corresponding code in task_wdt.c from the system-component is.

static void task_wdt_isr(void *arg)
{
    portENTER_CRITICAL_ISR(&twdt_spinlock);
    twdt_task_t *twdttask;
    const char *cpu;
    //Reset hardware timer so that 2nd stage timeout is not reached (will trigger system reset)
    wdt_hal_write_protect_disable(&twdt_context);
    wdt_hal_handle_intr(&twdt_context);     //Feeds WDT and clears acknowledges interrupt
    wdt_hal_write_protect_enable(&twdt_context);

    //We are taking a spinlock while doing I/O (ESP_EARLY_LOGE) here. Normally, that is a pretty
    //bad thing, possibly (temporarily) hanging up the 2nd core and stopping FreeRTOS. In this case,
    //something bad already happened and reporting this is considered more important
    //than the badness caused by a spinlock here.

    //Return immediately if no tasks have been added to task list
    ASSERT_EXIT_CRIT_RETURN((twdt_config->list != NULL), VOID_RETURN);

    //Watchdog got triggered because at least one task did not reset in time.
    ESP_EARLY_LOGE(TAG, "Task watchdog got triggered. The following tasks did not reset the watchdog in time:");
    for (twdttask=twdt_config->list; twdttask!=NULL; twdttask=twdttask->next) {
        if (!twdttask->has_reset) {
            cpu=xTaskGetAffinity(twdttask->task_handle)==0?DRAM_STR("CPU 0"):DRAM_STR("CPU 1");
            if (xTaskGetAffinity(twdttask->task_handle)==tskNO_AFFINITY) cpu=DRAM_STR("CPU 0/1");
            ESP_EARLY_LOGE(TAG, " - %s (%s)", pcTaskGetTaskName(twdttask->task_handle), cpu);
        }
    }
    ESP_EARLY_LOGE(TAG, "%s", DRAM_STR("Tasks currently running:"));
    for (int x=0; x<portNUM_PROCESSORS; x++) {
        ESP_EARLY_LOGE(TAG, "CPU %d: %s", x, pcTaskGetTaskName(xTaskGetCurrentTaskHandleForCPU(x)));
    }

    esp_task_wdt_isr_user_handler();

    if (twdt_config->panic){     //Trigger Panic if configured to do so
        ESP_EARLY_LOGE(TAG, "Aborting.");
        portEXIT_CRITICAL_ISR(&twdt_spinlock);
        esp_reset_reason_set_hint(ESP_RST_TASK_WDT);
        abort();
    } else {
...

I have no custom esp_task_wdt_isr_user_handler function
I updatet esp idf, erased flash and did a clean build
The esp_reset_reason_set_hint(ESP_RST_TASK_WDT); should set the proper reset reason.
I dont know if someone else is facing similar issues or I'm just stupid.
But I have not found a solution to this and think that it could belong here.
Cheers,
Freddy

Hi @FredoTorpedo, esp_reset_reason_set_hint does not affect the hardware reset reason printed by the ROM bootloader. It only affects the return value of esp_reset_reason function (https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/system/system.html#reset-reason). From hardware perspective, IDF task watchdog reset is CPU reset triggered by software, hence SW_CPU_RESET in the ROM sign-on message.

I run some startup code on every reset which uses esp_reset_reason. After 5 seconds the Watchdog restarts the programm but I regardlessly get the SW_RESET_REASON from esp_reset_reason.
This is a simplified version of the code I use:
void function(esp_reset_reason_t Reset_Reason)
{
FILE* fL;
switch(Reset_Reason)
{
case ESP_RST_POWERON:
{
fL = fopen(MOUNT_POINT"/filelog.csv" ,"a+");
fprintf(fL, "ResetReason:%s \n","Power_On");
fclose(fL);
break;
}
case ESP_RST_SW:
{
fL = fopen(MOUNT_POINT"/filelog.csv" ,"a+");
fprintf(fL, "ResetReason:%s \n","Software_Reset");
fclose(fL);
break;
}
case ESP_RST_WDT:
{
fL = fopen(MOUNT_POINT"/filelog.csv" ,"a+");
fprintf(fL, "ResetReason:%s \n","Watchdog Reset");
fclose(fL);
break;
}
case ESP_RST_PANIC:
{
fL = fopen(MOUNT_POINT"/filelog.csv" ,"a+");
fprintf(fL, "ResetReason:%s \n","Panic Reset");
fclose(fL);
break;
}
default:
{
...
}
break;
}
}

@FredoTorpedo I see, then it must be something else then. Please provide the information requested in the template you were presented when opening the issue (IDF commit ID, build system, sdkconfig file, etc). This will help us reproduce this behavior. If you can trim your code down to the version you can share that still reproduces the issue, that would be ideal.

Closing due to lack of response, please feel free to re-open and provide more information if the issue still exists.


Iter8 proposal

Proposal for bringing the Iter8 open source project into ODH.

@anishasthana Absolutely. I requested access to the MLOps sig meeting docs.
My understanding based on conversations with @taneem-ibrahim is that we are presenting/demoing today 12PM Eastern... ?

Ah, yeah I see it's on the agenda for today. Perfect!

Thank you for the iter8 proposal.
/lgtm

@LaVLaS fyi


Home Button in Navbar Returns 404 Error

Description
In some subpages, the Home button in the navigation bar is not functioning correctly and redirects to a 404 error page.
Steps to Reproduce

Navigate to specific subpages (e.g., Food, Culture, History, or Spiritual).
Click on the Home button in the navigation bar.
Observe that a 404 error is displayed.

Expected Behavior
The Home button should redirect users to the main homepage without any errors.
Current Behavior
The Home button leads to a 404 error on some subpages.
Severity
High
This issue affects navigation and disrupts the user experience.
Suggested Fix

Check the href or route associated with the Home button in the subpages.
Update the link to correctly point to the homepage route (e.g., / or the appropriate path).
Ensure consistency in the navbar links across all subpages.

Interested to work on this @SaranDharshanSP

I'm interested in working on this issue... I have a pretty good idea to fix the issue @SaranDharshanSP

Count me in, I'm interested to work on this @SaranDharshanSP

I'm interested in solving this issue @SaranDharshanSP

I'm interested in solving this issue @SaranDharshanSP

Hey @Raamprathap ! Under Amrita Winter of Code, only one issue can be assigned per person per repository. Please complete your currently assigned issue and raise a PR before requesting another. Looking forward to your contributions!

Hey @karthik-saiharsh @rev-sin @Raamprathap ! AMWOC Started from 10 am today, if you guys still want to do it please ask again.

I am interested in the issue @SaranDharshanSP

Hey @Raamprathap  ! Under Amrita Winter of Code, only one issue can be assigned per person per repository. Please complete your currently assigned issue and raise a PR before requesting another. Looking forward to your contributions!

I am interested in the issue @SaranDharshanSP

I'm interested in working on this issue and resolving it without affecting the actual structure and functionality of the program.
I am eagerly waiting for your approval!!
@SaranDharshanSP

On me @SaranDharshanSP anna

anusanth26

Hey @anusanth26  , you've been assigned this issue under Amrita Winter of Code! Please ensure to raise a PR by 28/12/2024, or it will be reassigned to someone else. Best of luck! 🫡

yes i am interested

Hey @karthik-saiharsh @rev-sin @Raamprathap ! AMWOC Started from 10 am today, if you guys still want to do it please ask again.

I am done with the PR @rev-sin , but dont have access to it

@anusanth26 is being assigned first in First come First serve basiss.
If he/she fails to do it then you will be given the next pritioty

I am done with the PR @rev-sin , but dont have access to it

I'm not the maintainer @Kavinesh11

Hey @SaranDharshanSP, I would like to solve this issue if there is no progress.


Convert Plaid to use AndroidX

What's missing to remove the [WIP] label?
Looks like things are failing due to CI issues with instrumented tests but the code seems to be all good.
@tiembo - any idea what's up with the tests? I think this is quite a big (and important change) so, if the CI issue can't be fixed, I'd be happy to have this merged soon (depending on what's keeping this a WIP, of course)

@florina-muntenescu fixed the instrumentation tests and removed [WIP] from the title.  Ready for final review; feel free to merge if everything looks ok.


[bazel] Fix or mark broken tests

Ensure every verilator test gets tagged with "cpu:4" This was getting overwritten by tests that passed in their own tags and they were likely to timeout/cause timeouts
Mark triaged test as broken
Increase timeout on tests that time out during batch testing.

Signed-off-by: Drew Macrae<EMAIL_ADDRESS>

Tested: bazel test //... --test_tag_filters=-broken

How did you find the test that was marked broken but actually works?

Oh yeah, I'm glad you asked: @jrvanwhy found that one and told me about it. Test tag filters work both ways so there's utility in playing around with
bazel test --test_tag_filters=broken
but timing out tests can make it a slow process.

Sorry for the delay, but LGTM.


Resolve kotlin plugin dependencies order

This is now fixed by fixGradleFile.js but should be  resolved in the proper manner

Done in plugin/hooks/support-kotlin.js


Crash from internal files from Library

Crash in CountryPickerViewController
Crashed: com.apple.main-thread SIGABRT ABORT 0x00000001f1a51fbc

Fatal error: Attempted to read an unowned reference but the object was already deallocated
Any updates?

Just remove unowned keyword from CountryPickerViewController file while declaring variable view: CountryPickerView. It will fix the issue.

If you have some time, Can you create PR @ArunTanejaSM?


Update acyclic to 0.3.9

About this PR
📦 Updates com.lihaoyi:acyclic from 0.3.8 to 0.3.9
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (0.3.8).
You might want to review and update them manually.
upickleReadme/Readme.scalatex

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "acyclic" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi", artifactId = "acyclic" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #559.


Fix mg setup guide errors

See inline comments for reasons.

looks like someone already fixed my mistake! https://handbook.sourcegraph.com/departments/cloud/technical-docs/operations/


Add a package.json

Npm can install directly from github, but only if there is a package.json file. Since you closed the issue on durandal-bower, and durandal-bower doesn't have the recent fixes, can you just add a package.json file here? And if not, then can you update the durandal-bower repo?

I'm not clear why there are separate repos but this

If you PR the package.json file, I will merge it in.

PR #703 should do it

Merged.


Not a BUG, just a nobb question on transforms

I use a middleware to get Userinfo from another API call (based on email claim received via Jwt).
I m tringing to design a route like this
When a user call /api/v1/usrmgt/me
The user needs to be sent to /api/v1/usrmgt/users/{user_id}, on my cluster1
I have the user_id in a service filled with my middleware. But cannot find a way to use a transform and fill the {user_id}.
At the end, I think I doesnt really know the perimeter of what is possible.
I will need this kind of transformation to manage tenant routing and other stuff (maybe)
If someone can point me in the right direction...

Will implement something differently


3rd coordinate

3rd coordinate for wells #2
Need for #3 and #6 too.

Wellhead now have 3 dimension coordinates

Too many dots (X,Y,Z) in use. Refactor it!

[ ] Fold all dot's definitions

Done


Add a section about spacing to reference page

Made some progress on here: https://github.com/codeforamerica/cfa-styleguide-gem/issues/114


http://magnolia.work is blocked by Watch Guard

Just for your information:

This means:
"Elevated Exposure contains sites that camouflage their true nature or identity, or that include elements suggesting latent malign intent."

I changed the job - so I cannot test that. No problems here;).

Ok, I'm going to close the issue, and hopefully nobody else has the same problem. :)


Lack of notification after image download

I think it would be useful to get user to know if downloading of gif/image is ended (for example cloud with text on the bottom of the screen, i don't know exact name of it).

I made a pull request with this improvement
https://github.com/mateusz-bak/hejtter/pull/14

Done, will be release in 0.0.15.


Pulling the latest version still returns old version

The latest version should be 1.1.11.
But I get this:
--start-server-load-latest
0.000 2021-01-14 20:09:55; Factorio 1.1.10 (build 57667, linux64, headless)

The 1.1.11 build is failing.

The 1.1.11 build is failing.

Having same issue.

Having same issue.

Same issue here. The travis log indicates dockerhub is ratelimiting the build.

Same issue here. The travis log indicates dockerhub is ratelimiting the build.

Duplicate of #354

Duplicate of #354


[WIP] Add path prefix to support transparent mirrors

When using following host configuration,  the request from critctl pull hello-world is not the right one on Harbor.
server = "https://docker.io"
[host."https://registry.example.com/dockerhub-proxy"]
  capabilities = ["pull", "resolve"]
  skip_verify = true

GET /dockerhub-proxy/v2/library/hello-world/manifests/latest?ns=docker.io HTTP/1.1

To get the right one below
GET /v2/dockerhub-proxy/library/hello-world/manifests/latest HTTP/1.1

I suggest this PR to add path parameter in hostFileConfig.
As a result, the configuration would be
server = "https://docker.io"
[host."https://registry.example.com"]
  capabilities = ["pull", "resolve"]
  path = "/dockerhub-proxy"
  skip_verify = true

We can't allow this method as appending to the prefix in this manner goes against the distribution API specification. I added an alternative here which just allows overriding the prefix altogether and would work for your case #5676. Should be noted that the method Harbor is using here is non-standard behavior and we do not support rewriting of the namespace in containerd's resolvers (names must be rewritten before just as is done in short name normalization).
We do have our own method to support actual transparent mirroring (see #4413), but it is not yet in the specification.


XYPlot fails on IE11 - endsWith is not supported

First and foremost, thank you all for open sourcing such an awesome library :)
One thing I just noticed - using an XYPlot fails on IE11 due to the _getOptionalScaleProps method:
  _getOptionalScaleProps(props) {
    return Object.keys(props)
      .filter(prop => OPTIONAL_SCALE_PROPS.map(option => prop.endsWith(option)).every(x => x))
      .reduce((obj, key) => {
        obj[key] = props[key];
        return obj;
      }, {});
  }

prop.endsWith fails since String.endsWith isn't supported in IE.

Should be fixed since Andrew's fix. Also, not every library is going refrain using newest methods for browser compatibility, especially IE. You should add polyfills on your side if that's the case 🙂

Published in 1.8.0

Yep you're totally right - will most likely have to add polyfills sooner or later :O
Thanks a million however 🎉 🎉 🎉


Optional npm run build Step

In my use case, I just want release-script to bump / commit / push package.json, author a GitHub release, and run npm publish.
If package.json is missing a build script, release-script fails with an error, so I had to manually add a dummy script.
"scripts": {
  "build": "echo 0"
}

This script was designed exactly for projects that needs build step. That is the cause why it runs npm run build.
But I don't see any hindrance to allow it just skip build step if there is no such in package.json.
I'll make patch and we can discuss it there :wink:


Add free orbit camera

The existing orbit camera preserves up direction. While in many cases that is useful in keeping a sense of direction, there are some cases where there is no up direction. This adds another camera control set similar to the existing orbit, but free to have any direction be up.

The second commit of this PR could be omitted, which would leave implementing the control set up to the application using this library.

Nice, thanks for the contribution 🙏


Design: JUnit 5 Extensions should lazily initialize TestClassModel

This would make TestClassAnalysisExtension unnecessary and allow us to work towards better decoupling of the other Extensions.

Implemented in #22 ...


Clicking on an event notification confuses app, brings the app back to 'Add server' screen with Connection error

Clicking on any event notification (camera disabled / motion / etc) results in the app going back to the 'Add server' screen even though the connection very much exists and displays:
Connection Error
Network request failed
Tested on iOS

Recommended workflow is:
Motion -> Show camera in full screen mode
Device Offline -> Show event of camera (in case is cutting the network cable or something 'bad')


Save storage improvements

Currently the loadgen runner can be configured to take a chain storage snapshot for each stage, which can get pretty slow.
Here are a few ideas of improvements:

Make a copy of the storage folder and compress it async while starting the next stage. Would be even better if this was on a copy-on-write fs
Compress with a less expensive algo (currently xz) or not at all
Automatically snapshot the storage if a stage fails, even if no-storage.

Also:

Save client / solo storage
Save ag-solo Slog


No support for RGBW?

I'm updating my old project from the python wrapper at https://github.com/rpi-ws281x. I got an error because Color only takes 3 values as input. After looking through the code, it seems like there is no mention at all of 32 bit color.
Are there any plans to fix this? It was supported before, that was one of the reasons I ended up using this library.

Same here. I'm very interested to this issue.

Confirmed that the python wrapper currently doesn't support RGBW. Please fix this.
rpi_ws281x version: 4.1.0
pi@raspberrypi:~/Documents/Projects/ws281x_examples $ sudo python3 SK6812_strandtest.py  Press Ctrl-C to quit. Traceback (most recent call last):   File "SK6812_strandtest.py", line 94, in <module>     colorWipe(strip, Color(0, 0, 0, 255))  # White wipe TypeError: Color() takes 3 positional arguments but 4 were given


instrument the "jetty:run" task

Currently the jetty:run maven task is not instrumented
Please add instrumentation for it as well as the gradle version

@doppleware when you say instrument, you mean to catch it in the run config(s)?

Yes to add the environment variables/vm options etc.


Use max-age=31536000 and immutable in Cache-Control (#177)

It sets max-age and immutable options in express.static: http://expressjs.com/en/5x/api.html#express.static
The max-age value is recommended by CRA docs.
Closes #177

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   96.05%   96.05%
=======================================
  Files           6        6
  Lines          76       76
  Branches       15       15
=======================================
  Hits           73       73
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55cc2cb...aa0a4da. Read the comment docs.

Hi @mlshv , thanks for your PR! LGTM


Toolbar css

For #492

Hard to argue with this, thanks.  If we need to make it more configurable somehow, etc. we can cross that bridge when we come to it, but as a first pass I was looking for some general sizing constraint, so - thanks!


Same predicted probabilities for googlenet using mxnetR

I'm using googlenet in mxnetR but the predicted probabilities are the same for all images. I tried to change

the activation function,
the batch size and
the initializer
I normalized the input to [-1,1] but most of the times I'm running the model the predicted probabilities remain the same.

The code is the following:
num_classes <- 2
ConvFactory <- function(data, num_filter, kernel, stride = c(1, 1), pad = c(0, 0),
name = '', suffix = '') {
conv <- mx.symbol.Convolution(data = data, num_filter = num_filter, kernel = kernel, stride = stride,
pad = pad, name = paste('conv_', name, suffix, sep = ""))
act <- mx.symbol.Activation(data = conv, act_type = 'relu', name = paste('relu_', name, suffix, sep = ''))
return(act)
}
InceptionFactory <- function(data, num_1x1, num_3x3red, num_3x3,
num_d5x5red, num_d5x5, pool, proj, name) {
# 1x1
c1x1 <- ConvFactory(data = data, num_filter = num_1x1, kernel = c(1, 1),
name = paste(name, '_1x1', sep = ''))
# 3x3 reduce + 3x3
c3x3r = ConvFactory(data = data, num_filter = num_3x3red, kernel = c(1, 1),
name = paste(name, '_3x3', sep = ''), suffix = '_reduce')
c3x3 = ConvFactory(data = c3x3r, num_filter = num_3x3, kernel = c(3, 3),
pad = c(1, 1), name = paste(name, '_3x3', sep = ''))
# double 3x3 reduce + double 3x3
cd5x5r = ConvFactory(data = data, num_filter = num_d5x5red, kernel = c(1, 1),
name = paste(name, '_5x5', sep = ''), suffix = '_reduce')
cd5x5 = ConvFactory(data = cd5x5r, num_filter = num_d5x5, kernel = c(5, 5), pad = c(2, 2),
name = paste(name, '_5x5', sep = ''))
# pool + proj
pooling = mx.symbol.Pooling(data = data, kernel = c(3, 3), stride = c(1, 1),
pad = c(1, 1), pool_type = pool,
name = paste(pool, 'pool', name, '_pool', sep = ''))
cproj = ConvFactory(data = pooling, num_filter = proj, kernel = c(1, 1),
					name = paste(name, '_proj', sep = ''))
# concat
concat_lst <- list()
concat_lst <- c(c1x1, c3x3, cd5x5, cproj)
concat_lst$num.args = 4
concat_lst$name = paste('ch_concat_', name, '_chconcat', sep = '')
concat = mxnet:::mx.varg.symbol.Concat(concat_lst)
return(concat)

}
data <- mx.symbol.Variable("data")
conv1 <- ConvFactory(data, 64, kernel = c(7, 7), stride = c(2, 2), pad = c(3, 3), name = "conv1")
pool1 <- mx.symbol.Pooling(conv1, kernel = c(3, 3), stride = c(2, 2), pool_type = "max", pooling_convention='full')
conv2 <- ConvFactory(pool1, 64, kernel = c(1, 1), stride = c(1, 1), name = "conv2")
conv3 <- ConvFactory(conv2, 192, kernel = c(3, 3), stride = c(1, 1), pad = c(1, 1), name = "conv3")
pool3 <- mx.symbol.Pooling(conv3, kernel = c(3, 3), stride = c(2, 2), pool_type = "max", pooling_convention='full')
in3a <- InceptionFactory(pool3, 64, 96, 128, 16, 32, "max", 32, name = "in3a")
in3b <- InceptionFactory(in3a, 128, 128, 192, 32, 96, "max", 64, name = "in3b")
pool4 <- mx.symbol.Pooling(in3b, kernel = c(3, 3), stride = c(2, 2), pool_type = "max", pooling_convention='full')
in4a <- InceptionFactory(pool4, 192, 96, 208, 16, 48, "max", 64, name = "in4a")
in4b <- InceptionFactory(in4a, 160, 112, 224, 24, 64, "max", 64, name = "in4b")
in4c <- InceptionFactory(in4b, 128, 128, 256, 24, 64, "max", 64, name = "in4c")
in4d <- InceptionFactory(in4c, 112, 144, 288, 32, 64, "max", 64, name = "in4d")
in4e <- InceptionFactory(in4d, 256, 160, 320, 32, 128, "max", 128, name = "in4e")
pool5 <- mx.symbol.Pooling(in4e, kernel = c(3, 3), stride = c(2, 2), pool_type = "max", pooling_convention='full')
in5a <- InceptionFactory(pool5, 256, 160, 320, 32, 128, "max", 128, name = "in5a")
in5b <- InceptionFactory(in5a, 384, 192, 384, 48, 128, "max", 128, name = "in5b")
pool6 <- mx.symbol.Pooling(in5b, kernel = c(7, 7), stride = c(1, 1), pool_type = "avg" )
flatten <- mx.symbol.Flatten(data = pool6)
fc1 <- mx.symbol.FullyConnected(data = flatten, num_hidden = num_classes)
googlenet <- mx.symbol.SoftmaxOutput(data = fc1, name = 'softmax')
model <- mx.model.FeedForward.create(googlenet, X = train_array, y = train_y,
ctx = device.cpu,
num.round = 20,
array.batch.size = 32,
learning.rate = 0.05,
momentum = 0.9,
wd = 0.00001,
eval.metric = mx.metric.accuracy, initializer=mx.init.uniform(0.07),
epoch.end.callback = mx.callback.save.checkpoint("checkpoint"))
predict_probs <- predict(model, test_array)
I am doing somehthing wrong?

Hi @kmarlen1988 - You might get a quick answer on usability at - https://discuss.mxnet.io/
Closing the issue here. Please reopen if you find a bug in MXNet R package.


Disappearing AG_Menu expansions in single-window drivers

Under single-window drivers such as SDL, there seems to be a race condition which can cause the visibility state of Menu expansions to become inconsistent. This is likely a bug in Menu or MenuView.

Fixed a while back.


async_await test is flaky on travis

From @vsmenon on August 31, 2016 16:34
Haven't noticed a local failure, but I'm often seeing this on the bots:

[Chrome 55.0.2846 (Linux 0.0.0)  async_await_test_03_multi FAILED
    Not allowed when tests are running.

E.g: https://s3.amazonaws.com/archive.travis-ci.org/jobs/156371116/log.txt
Copied from original issue: dart-lang/dev_compiler#634

I think this is obsolete


OCI containers output in systemd journal

Describe the bug
The log output for OCI containers is no longer linked to the systemd service in the systemd journal. So it is no longer possible to use journalctl -u <service_name> to filter out the log output of a specific container.
This change is due to the introduction of lines 233 and 234 here.
To Reproduce
Steps to reproduce the behavior:

Define a container outputting logs to stdout and start it
Run journalctl -u <service_name>
The logs are not being shown as they were before

Expected behavior
In 20.03 the logs could easily be filtered by using the above-mentioned command.
Notify maintainers
@adisbladis

Issue is still present, #102769 is approved and ready to be merged.


feat: wrapper action state

Codecov Report

Merging #4 (2a2729d) into main (6889244) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines           55        60    +5
=========================================
+ Hits            55        60    +5

Impacted Files
Coverage Δ

lib/src/core/core.dart
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6889244...2a2729d. Read the comment docs.


Equalizer style .preset select

Good Evening
With the following settings

the result is this

After disabling the following

the result is this

The hover text still looks different but I dont know how to fix it.

Browser, OS and version? Please read the issue template carefully.

Opera and Chrome on Windows and I have the latest commits.
Mozilla looks good except for the black and orange arrow.

Sorry for this. Will look at it.

Tested and its fixed.


Update readme or remove examples

The examples are incorrect. I didn't check all of them, but at least Document.create() is incorrect:
'''
TypeError: Document.create() missing 1 required positional argument: 'document_type
'''
It is possible I am completely mistaken ;)

hi @smwltr thanks for trying out Pylero and raising github issues.

I can confirm that document_type is a required field and Readme should reflect that
However document_type are more like custom config that's created by admin and need to look into whether validating that dynamically is possible or not
When I provided a document_type this op should work and at the same time I could see an error, will re-look and get back

>>> doc=Document.create(project_id='pylarion',space='Testing', document_name='issue67', document_title='issue67', allowed_wi_types=["testcase"], document_type="testspecification")
<?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ns1="http://ws.polarion.com/session" xmlns:ns0="http:
//schemas.xmlsoap.org/soap/envelope/">
   <SOAP-ENV:Header>
      <ns1:sessionID>6084181439037407361</ns1:sessionID>
   </SOAP-ENV:Header>
   <ns0:Body xmlns:ns1="http://ws.polarion.com/SessionWebService-impl">
      <ns1:endTransaction>
         <ns1:rollback>false</ns1:rollback>
      </ns1:endTransaction>
   </ns0:Body>
</SOAP-ENV:Envelope>
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    doc=Document.create(project_id='pylarion',space='Testing', document_name='issue67', document_title='issue67', allowed_wi_types=["testcase"], document_type="testspecification")
  File "/root/toolbox/pylero/src/pylero/base_polarion.py", line 183, in inner
    self.session.tx_commit()
  File "/root/toolbox/pylero/src/pylero/session.py", line 131, in tx_commit
    self._session_client.service.endTransaction(False)
  File "/root/toolbox/venv/pylero/lib/python3.10/site-packages/suds/client.py", line 559, in __call__
    return client.invoke(args, kwargs)
  File "/root/toolbox/venv/pylero/lib/python3.10/site-packages/suds/client.py", line 618, in invoke
    result = self.send(soapenv)
  File "/root/toolbox/venv/pylero/lib/python3.10/site-packages/suds/client.py", line 664, in send
    result = self.failed(binding, e)
  File "/root/toolbox/venv/pylero/lib/python3.10/site-packages/suds/client.py", line 720, in failed
    r, p = binding.get_fault(reply)
  File "/root/toolbox/venv/pylero/lib/python3.10/site-packages/suds/bindings/binding.py", line 267, in get_fault
    raise WebFault(p, faultroot)
suds.WebFault: b"Server raised fault: 'java.lang.NullPointerException'"

The doc indeed need update with the required field document_type
my test with document_type also failed with error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/waynesun/.local/share/virtualenvs/pylero-xZ4TB2uX/lib/python3.10/site-packages/pylero/base_polarion.py", line 228, in inner
    res = func(*args, **kwargs)
  File "/home/waynesun/.local/share/virtualenvs/pylero-xZ4TB2uX/lib/python3.10/site-packages/pylero/document.py", line 204, in create
    doc.create_work_item(None, wi_head)
  File "/home/waynesun/.local/share/virtualenvs/pylero-xZ4TB2uX/lib/python3.10/site-packages/pylero/base_polarion.py", line 228, in inner
    res = func(*args, **kwargs)
  File "/home/waynesun/.local/share/virtualenvs/pylero-xZ4TB2uX/lib/python3.10/site-packages/pylero/document.py", line 402, in create_work_item
    doc_wis = self.get_work_items(None, False, None)
  File "/home/waynesun/.local/share/virtualenvs/pylero-xZ4TB2uX/lib/python3.10/site-packages/pylero/document.py", line 460, in get_work_items
    filtered_fields = [f for f in fields if f in wi_type._cls_suds_map.keys()]
TypeError: 'NoneType' object is not iterable

The error is due to:
https://github.com/RedHatQE/pylero/blob/main/src/pylero/document.py#L402
with specified fields value as None


FATAL unexpected EOF

I have been getting a lot of these error with 1.12.3   I have to delete the AOF and reload my webhooks.  What would cause this ?

I'd like to reproduce the error. Would it be possible to get the output in the terminal and copy of your AOF file?

tille38_error.zip

I think this maybe more due to a corrupt SD card I noticed some other weird things going on.  I started with  a fresh SD and will let you know if it happens again


Dialtone V6 Component Inputs Implementation

Dialtone V6 Component Inputs Implementation

:hammer_and_wrench: Type Of Change

[ ] Fix
[x] Feature
[x] Refactoring
[ ] Documentation

:book: Description

Updated Input, Textarea css components
Updated Input, Textarea docs
Light updates to the select menu docs
Refactored select menu into it's own component file
Refactored validation messages, labels, descriptions and fieldsets into the forms component file
Init forms documentation (to be updated later)
:bulb: Context

Closes #219
Pull Request Checklist

[x] Ask the contributors if a similar effort is already in process or has been solved.
[x] Review the contribution guidelines.
[x] Ensure all gulp scripts successfully compile.
[x] Update, remove, or extend all affected documentation.
[x] Provide a description what is being changed, extended, or removed.
[x] Link to any issue(s) this request is resolving.
[x] Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] Request a review from Drew Chandler, Joshua Hynes, or Ted Goas.

:camera: Screenshots / GIFs

FYI: left icon is missing from Textarea, and left and right icons are missing from Text Input.
Also, I mentioned it in an inline comment by d-stack4, but I think we should consider baking some of the core spacing (space above input, space below input) into the CSS. It's going to be the same for Select, Text Input, and Textarea and a couple of CSS lines would reduce dozens of lines of HTML.
What do you think?

I tried experimenting a bit with creating some inner icon styles. For the left position, it would rely absolute positioning which would change depending on the size of the input. For the right side things get a little trickier. We would probably need an additional wrapper class to wrap the icons together with the input so that the right side can be positioned correctly.
How we currently achieve this in Handset is dynamically adding classes and html elements to the input / text area depending on whether or not an icon is provided.
Did we want to spend the time to add these classes? It would create additional complexity which might go against our goal of keeping everything as simple as possible to start with.
Example Usage:

      Full name
      This is something you can change later.

{% iconSystem "group" %}

      <input class="d-input" id="Dialtone--InputExample1a" type="text" placeholder="e.g. John Doe, Jane Doe" />

{% iconSystem "group" %}

FYI: left icon is missing from Textarea, and left and right icons are missing from Text Input.
Also, I mentioned it in an inline comment by d-stack4, but I think we should consider baking some of the core spacing (space above input, space below input) into the CSS. It's going to be the same for Select, Text Input, and Textarea and a couple of CSS lines would reduce dozens of lines of HTML.
What do you think?

I tried experimenting a bit with creating some inner icon styles. For the left position, it would rely absolute positioning which would change depending on the size of the input. For the right side things get a little trickier. We would probably need an additional wrapper class to wrap the icons together with the input so that the right side can be positioned correctly.
How we currently achieve this in Handset is dynamically adding classes and html elements to the input / text area depending on whether or not an icon is provided.
Did we want to spend the time to add these classes? It would create additional complexity which might go against our goal of keeping everything as simple as possible to start with.
Example Usage:

      Full name
      This is something you can change later.

{% iconSystem "group" %}

      <input class="d-input" id="Dialtone--InputExample1a" type="text" placeholder="e.g. John Doe, Jane Doe" />

{% iconSystem "group" %}

Working on a better solution currently

@dialpad-drew Did you want to have a look at the updated input examples and classes. We will need some styles that are applied if an icon is present in order to adjust the position of the placeholder and input text within the input.

Text input and textarea's XS font-size should be 12px (line-height: 16px) instead of 14px.

Good catch, I was assuming the mixins being used in the variants were correct. I have updated the xs, sm and xl variants to correctly match the design

Approved with one comment:
I didn't account for something with the earlier top and bottom padding values I gave you. Those are the values in Figma, but Figma doesn't count those border in the element height. Because of border-box, the 1px border is being counted in the element height and consequently each input size is 2px too tall. If we reduce each size's top and bottom padding by 1px, we should be there.

Updated, feel free to have a final look


remove modules length

closes #19
The modules length is always larger than 1, so by default, it is just to use modules[0].commandId.

Unfortunately this won’t work for when we have a menu or multiple relaunchButtons defined in our figma-plugins config


Schedule's text fix

Schedule's text must contain not modified by parse-word-to-number lib words.

Relevant issue in date-parser.

Relevant issue in parse-word-to-number.

Done here.


I'd like also the possibility to select only month and year.

I'd like also the possibility to select only month and year.
It's a common use case to select just the month and the year.
Originally posted by @francesco-clementi-92 in https://github.com/web-ridge/react-native-paper-dates/issues/80#issuecomment-869005131

I don't have this use-case myself so I won't built it myself. There's als not written something about this picker in the Material Design specification, maybe we can lookup some example of a Google app who does this and screenshot te layout for inspiration if there is a good looking someone can pick it up to create a PR but I think we first need to decide on a layout.

Hi @RichardLindhout, I think we can refer to this guidelines:
https://material-ui-pickers.dev/demo/datepicker#different-views.
The site is a little bit outdated, but even the new version https://next.material-ui.com/components/date-picker/ is pretty much the same (can't find an example)

Looking good! I'll accept a PR which adds this component

Uses Intl for the month names
Uses FlatList for year
Uses Flatlist for month grid

How to use this feature?
thanks you so much.


Full field and plot level viewer and API

Description
Users would like to have a way to review full field images and easily extract plot level data. Two use cases exist 1) user reviews full field/plot image as a map service for display within a browser and/or 2) an API provides easy access to full field/plot images for UIs, extractors, desktop tools, etc.
Discussion Issues

Deploy map service, API, or both?
Full field image can be large and require special file formats.
Use of compression will reduce image quality. Is that acceptable?
Move to netCDF and Thredds server might make the API unnecessary.
Consistent naming of level 1 files

API (discussion only)
/sites/:site/sensors/:sensor/:date
/sites/:site/sensors/:sensor/:date/plots/:range/:column
Completion Criteria

[ ] Discuss and determine most useful services if any. Create new issues to reflect the decision.

key search parameters / endpoints:

cultivar_id + optional date
sitename
filetype: (netcdf &or geotiff), jpg?

Should extractors call API or directly query BETYdb and clip files on disk

The current service takes the sensor name and date and returns a geotiff clipped to the boundary of the sitename. The current clipping service requires site, sensor, and date. Using those three parameters we can navigate the filesystem to locate the full field stitched image.
We can either assume that users will first query betydb to get a list of sitenames (ie based on cultivar_id and date) or we could provide a wrapper that handles the betydb query internally.

Two pull requests are open:

Nick made BETYdb api
Jeff's student hooked into GDAL

Extractors via terrautils don't need API, API is mainly aimed at end users and search interface.
Next steps (by end of July)

terrautils merged
API draft

flask app w/ API + web interface
need to know - where is it going to live and how will it be integrated into the search interface that @craig-willis is working on

@jterstriep and @max-zilla please close this, create an epic that links associated tasks.

@jterstriep reminder

Current implementation is here: http://<IP_ADDRESS>:8000/api/v1/sites/ua-mac/sensors/stereoTop/2017-04-27?sitename=MAC
Where will this be deployed? What are next steps?

update to use terrautils library
most important is the API full field clipper

has a form and a map interface

@jterstriep please close this, create an epic that links associated tasks.

This is a stale issue with no comments in last 2 months. Please create new issues if work remains or put this content in the documentation.


Allow deleting related objects in Django Admin from another ModelAdmin

Task linked: QF-3349 Alllow deleting related objects in django admin from another ModelAdmin

After deploying on on-prem I can confirm this solves the issue, thanks!


fix: copy/paste not possible

fix: copy/paste wasn't possible due to context menu builder being passed as null

As a workaround, until this is merged and released, you can simply add the following prop to your PhoneFormField widget:
PhoneFormField(
   validator: PhoneValidator.required(),
+  contextMenuBuilder: (BuildContext context, EditableTextState editableTextState) {
+    return AdaptiveTextSelectionToolbar.editableText(
+      editableTextState: editableTextState,
+    );
+  },

Very nice job tbh

Let's get this merged

This is truly amazing work I have to admit

This is truly amazing work I have to admit

Wow thanks, that means a lot. It means a lot coming from a guy lost in flutter

this code is actually nuts. impeccable job.

Can we add test for this ?

Can we add test for this ?

Which test do you imagine?

Note that the tests can be written by someone else, not necessarily you, as there seems to be other people interested in this PR, I'd nudge them on giving it a go.
Same for https://github.com/cedvdb/phone_form_field/pull/163 and https://github.com/cedvdb/phone_form_field/pull/162
which are really nice additions.
Some unit tests are harder to write because flutter unit testing cannot access the native platform outside flutter. This may or may not be one of those cases. All in all this addition is supposed to add copy pasting support so a test that demonstrate that the default contextMenuBuilder provided indeed adds that support.


Built in web browser

Added built in web browser and additional button which points to a website.
Thanks to 0x0c who provided a basic web view controller.

Basically a good idea,but I really don't like adding the whole browser class (especially not by adding it to the project; much better to make it a requirement in the Podspec). Too much can break over the course of iOS releases. It may also be preferable to open the URLs in an already existing in-app browser. I'd say it would be better to let the developer decide which browser to use, and add a delegate to RFAboutView to open URLs.

Indeed, I added a new property called: BOOL webBuiltIn and a reference to the web controller. I used an already working web class so that made all quicker.
How do you recommend to edit the Podspec?

You're referencing M2DWebViewController, so anyone adding this will be forced to use this specific class. That's why I'm saying it would be better to add a delegate with a method openURL:, and the delegate can choose what to do with it. If the delegate is nil, open it always with UIApplication. That would have the advantage that the dev implementing can choose how they show that URL and we don't have the additional third-party dependency.

Implemented delegate.
Let me know if you can merge now.

Great! Thanks for your work! :)


pull

Please describe the changes this pull request makes and why it should be merged:
Status:

[ ] Code changes have been tested
[ ] Code changes work without errors

Content of the pull request:

[ ] This pull request changes the Website

[ ] This pull request includes breaking changes for the Dashboard
[ ] This pull request includes new page(s) for the website

[ ] This pull request only includes non-code changes, like changes to templates, README.md, etc.

@maltesermailo What is with this pull request? Should I merge?


not a bug, just a few feature requests...

This is an incredible project! It's so seamless and easy to use; it's really great. I'm a Cloudflare employee and talk about this (for personal use) regularly as a great example of building real-world useful applications in workers and R2.
I currently use it to organize photos for personal use. I'd love to see a few things incorporated:

thumbnail viewer for images with the ability to resize the thumbnails on the fly
The ability to sort files by metadata; creation date, user supplied tags, etc.

This is so great!! Can't wait to see what the next update brings.

Hey @grstnhbr thanks 😃
besides the creation date, what kind of metadata are you looking to sort?
can you share some examples of user supplied tags that you have in mind?


Unfortunately, I did not find the BIOS update for the MSI b360 Mortar version 7B23v16.

Unfortunately, I did not find the BIOS update for the MSI b360 Mortar version 7B23v16 on the official website:
https://www.msi.com/Motherboard/B360M-MORTAR/support
Does it work on version 7B23v17 without any problems?
These are my device specifications :
MSI B360 Mortar
CPU i5-8400
GPU MSI RX 580 8g OC
RAM Adata 2x8 2666 MHz
SSD Adata Ligends 710 500GB NVMe
Does this EFI file work without any problems, or does it require a modification other than a modification to the serial number?

After testing, versions 7B23v16 to 7B23v19 can be used, and 7B23v17 can be used naturally. If you use both integrated graphics and discrete graphics, after setting the BIOS, you can directly fill in the serial number and other information to use it.


Translate types

This PR allows cast block to be translated, see issue #67
Had quite some issues making this work compressed. My solution at the moment is using a function. So you will see eg:
typeName: function() {return Blockly.Msg.ARD_TYPE_CHAR;},

This because Blockly.Msg is only available on init, so when the types are created, this is still undefined. Using a function means translation is deferred till later.
Perhaps there is a better solution? Eg adding typeName after translation is loaded?

Thanks for the prompt submission!
I've been giving the typeName implementation some though, and it looks like there might not be a very clean way of doing it. Assignment of the Blockly.Msg is not really a good idea even if the instantiated object was already present on init. This is because a "dynamic" language change without page refresh would bypass this translation completely. So retrieval of the current string on each access of typeName, as you have implemente here, is required.
I've briefly played with the idea of adding an accessor instead of using typeName as a function:
https://github.com/carlosperate/ardublockly/commit/7dec25ed5d8d00c3b7f40a42cd7dc213d1d53737 (in a branch)
The only problem is that I am not quire sure if the typeNameMsgId argument for the constructor is very clear, any thoughts?

Number of Types will be a limited thing for any language, so although typeNameMsgId is not very clear, having to pass a function is also awkward. The only drawback is that only in types.js this construct is used, but in the future that might change (same for the function) ...
So for me both work, depends on what you find most clean.
As a side, would it not be cleaner to have also in core a subdir arduinotypes? It seems to me we are adding types specific to arduino  in the core lib, while a different language might reuse the construct of types, but would need other (or different compatibility). What I mean is some way that the arduino specific typing (short number, long number) is not present when doing dart/python/...(this is not something I have the js skills for to pull off)

I think I will merge the accessor for typeName, with the difference that instead of typeNameMsgId I'll rename the argument to typeMsgName. As long as it is documented properly it should be fine.

As a side, would it not be cleaner to have also in core a subdir arduinotypes?

I did consider this when I was first looking into adding "non-standard" types with compatibilities, but the problem is that the blocks have to be independent to the generators. If we look at the default "blockly code" example, the same blockly workspace is used to generate all the different languages, and there is no way to select which "language" rules the workspace wold follow for block connections. Because of this, the fact that the codebase will inevitably diverge more and more with time, and the almost non-existent need for Ardublockly to support (and maintain) more languages, I though that doing it this simpler way is an acceptable trade off.

Added on https://github.com/carlosperate/ardublockly/commit/a819427300c67581ac5462dc91fddb50f6a5c069.
Also notice that I corrected the "short positive number" string to "short postive", as the type is char, a signed byte.

Ok, I follow your reasoning.
On my suggested solution to using variables for digitalwrite in #70 you see I use types to drive this mechanism. Those types are even further from what other languages might need. However, there is the addType function, though it is nowhere used and it had a bug. So a possible way forward is perhaps a part in core like coreArduino.js, with specific Arduino use of the type system, using this addType function? If somebody wants to use types for a language other than Arduino, they will have an easier time splitting out the Arduino stuff.

Oh, I see what you mean. Yeah, that sounds like a great idea, since most of the "arduino specific" types would only be used by the arduino blocks. This keeps the generic blockly working, but we would still have the same problem if somebody wanted to use the Arduino blocks to generate other languages.
As far as I can remember, the only blocks that need a type not defined in the original Blockly would be the number blocks, which right now differentiate between integers and floats. There might be others, so we'll have to have a careful look.
Sorry I missed #70, I'll have a look tonight.


User login

Users are now able to register and login with google and with email and password
Tests are implemented for the UI and unit tests for the corresponding view models
To do before merging:

Verify that you can login with google and with email and password
Verify that input field validation works properly

Everything works correctly on my end