fixes #2055

in caret settings, if you want do 10*10 cross validation, you need to set repeats=10, number=10 and method=repeatedcv, if you set method=cv, actually just one 10-fold cross validation will be run; fixes #2055

Codecov Report

Merging #2061 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2061   +/-   ##
=======================================
  Coverage   30.72%   30.72%
=======================================
  Files          72       72
  Lines        5823     5823
  Branches      580      580
=======================================
  Hits         1789     1789
  Misses       3957     3957
  Partials       77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d97d3...ca06109. Read the comment docs.


Please upload files in the directory of drive,otherwise I cant

Please upload files in the directory of drive,otherwise I cant run the project

Look for the answer here.


Support body with req.write()

Not sure if this is something you are interested in, but I needed to be able to pass through JSON from a request. It doesn't seem that you guys use the write method at all. So this uses that if body is specified on the option.
For example:
proxy({
  ...
  body: JSON.stringify(req.body),
});

closing due to inactivity, and I no longer need this.


feat: 🎸 save customClaimType as entity

Description

saves CustomClaimType as an Entity
if Claim has customClaimTypeId -> but that is not yet synced to SQ -> it will be created
allows querying for all the created CustomClaimType(s)

JIRA Link
https://polymesh.atlassian.net/browse/DA-909
Checklist

[x] Updated the Readme.md (if required) ?

:tada: This PR is included in version 10.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix(backup) Clear the error message when backup target is available

https://github.com/longhorn/longhorn/issues/2944
image: wangsiye/longhorn-ui:eb498e0
Signed-off-by: Siye Wang<EMAIL_ADDRESS>

@smallteeths Please backport to 1.2.x.


createsymlink are not in BIDS format

createsymlink.py is a script to help prepare the input files for RTP pipeline.
However, when defining it, we use hardcoded code and the filenames are not in BIDS format.
We want to move that to BIDS format so that using pybids, we can get the T1w file, if pybids didn't find result, return error and stop the program.
We hope in this way, more and more people will move to using BIDS.

changed by tiger


Extension shows in fullscreen, bug/feature?

Describe the bug
With the new twitch player the chat is not removed when you go into fullscreen, then again i can see this as a feature also! I really like being able to have the chat on the side while in fullscreen
To Reproduce
New twitch player -> fullscreen
Expected behavior
Depends if you want is as a feature or not, but it used to remove the chat when you go into fullscreen.
Chatterino version
Chatterino Nightly 2.1.5 (commit 367b1970f, 22.09.2019)
Extension 1.2
Feature
If it was to be added as a feature it would be nice to be able to move/resize the window :)

Can confirm this bug. Windows 10 Nightly 2.1.7 (commit 6d5ba0c44, 24.05.2020)

https://github.com/Chatterino/chatterino-browser-ext/issues/33


[C++][Parquet] Fix MetaData children object lifetime issues

FileMetaData::RowGroup(int i) and RowGroupMetaData::ColumnChunk(i)  returns both a unique_ptr which gives the impression that the object are self-contained and safe to own without any lifetime issue.
The reality is that the caller must hold the lifetime of the parent object. We should change the signature to a const-ref instead.
Reporter: Francois Saint-Jacques / @fsaintjacques
Note: This issue was originally created as PARQUET-1867. Please see the migration documentation for further details.

Gang Wu / @wgtmac:
This is by design and a warning has been added long ago: arrow/cpp/src/parquet/metadata.h at 37bd413c8322e0d9527c14420468b99f8abd1715 · apache/arrow (github.com)


Slow autocomplete

https://github.com/vuejs/language-tools/assets/51825926/3c26dd66-cab8-41d4-83b8-23a08e83e29d
Autocomplete used to appear instantly. Now it take 2~3 seconds sometimes more. I haven't changed anything or did any customizations.
Happens on all versions from the lates v2.0.12 to 1.8.27
Mostly happens with template only, script is fine, css is a bit slow but normal I guess.

try to disable prettier extension, it worked for me.

This was resolved with v2.0.14 update in my machine.

Is this one still an issue with the latest 2.x?

Is this one still an issue with the latest 2.x?
Yes! And it is a big problem..
We have a large project (with nuxt, ~4k components), autocomplete is terrible everywhere, both script and template

https://github.com/user-attachments/assets/5f55ee2f-0d16-43e2-b613-8340b3dce6e8
macOS m1 Sonoma 14.1, VSC Version: 1.92.0.
list of extensions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Seems to be resolved. Closing.


Feat - save api keys securely to backend

Description
This PR address the functionality of users' saving API keys securely in the backend.
Tasks

[x] Created bash script to generate key
[x] Implemented AES encryption
[x] Implemented service functions to handle API key creation, update, and retrieve
[x] Implemented Frontend API business logic to create, update and retrieve API Key
[x] Implemented and registered API Key routers to the backend
[x] Removed unused imports in frontend utils

Related Issue
Closes #296.
#414 is a dependency.
Kindly review and provide feedback, if any!

I am going to close this for now, let's reopen it next week.


Broken Access Control Vulnerability in AddReview Method (CVE-2024-50945)

Description
The AddReview method in ReviewController.cs is vulnerable to broken access control. This issue allows unauthorized users to post reviews for products they have not purchased by manipulating the EntityId in the POST request.

The current implementation only enforces purchase verification on the frontend, leaving the backend unprotected and susceptible to exploitation.
Steps to Reproduce (PoC)
An attacker can exploit this vulnerability by sending a request to the review submission endpoint and changing the EntityId to the ID of a product they have not purchased.
Suggested Fix
Vulnerable code:

To mitigate this vulnerability, implement backend validation to ensure that only users who have actually purchased the specific product they are reviewing can post a review for that product. This involves verifying the user's purchase history against the EntityId before allowing the review to be posted.
Also, make this endpoint for authenticated users only because it's not.
Useful Links
https://cwe.mitre.org/data/definitions/284.html
https://github.com/AbdullahAlmutawa/CVE-2024-50945

Thanks for reporting this @AbdullahAlmutawa, do you plan to create a PR or should I do it so quick

That fix works fine.


WQExecutor: Test fixed cctools

Description
This PR downloads the hotfix cctools tarball to see if the problem in issue #2914 goes away..
Choose which options apply, and delete the ones which do not apply.

Bug fix (non-breaking change that fixes an issue)

FYI cctools 7.7.1 just released includes the bug fix.

the local test problem happens again here I think. Otherwise this should fix issue #2914. @benclifford


⚠ Bofrost.de has degraded performance

In be6698d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1592 ms

Resolved: Bofrost.de performance has improved in 7a0b148 after 6 minutes.


chore: fix some typos

Just walking through and fixing some typos, still a couple left

Codecov Report

Merging #402 (c66743b) into main (aeca7dd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   74.00%   74.00%   -0.01%
==========================================
  Files         234      234
  Lines       22130    22130
==========================================
- Hits        16378    16377       -1
- Misses       5752     5753       +1

Impacted Files
Coverage Δ

crates/executor/src/executor.rs
85.64% <ø> (ø)

crates/storage/db/src/abstraction/cursor.rs
100.00% <ø> (ø)

crates/net/eth-wire/src/types/version.rs
75.55% <0.00%> (-2.23%)
:arrow_down:

crates/net/eth-wire/src/capability.rs
60.67% <0.00%> (-1.13%)
:arrow_down:

crates/net/network/src/listener.rs
84.09% <0.00%> (+2.27%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


created vm scale set but could not RDP to the NAT generated VM (ie. publicIPAdress:50000)

created vm scale set but could not RDP to the NAT generated VM (ie. publicIPAdress:50000)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0ac55b8-8be8-1f86-e3b1-3fe3f6c340c1
Version Independent ID: c26d3fc8-b62c-4895-3687-2fc7364c6383
Content: Quickstart - Create a virtual machine scale set in the Azure portal
Content Source: articles/virtual-machine-scale-sets/quick-create-portal.md
Service: virtual-machine-scale-sets
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for the feedback! We are currently investigating and will update you shortly.

@skepick depending on how many instances you put in your scaleset the first node may not actually be associated with NAT rule 50000.
For example, I created a scaleset with 2 instances. You can see this by going to the scale set and selecting instances

and if you go to the NAT rules created on the load balancer you will see that my 2 instances are actually associated with 50002 and 50003

Do the above steps and make sure you are connecting using the correct port number. If that is not the case and you still cannot connect let me know and we can reopen and investigate further.

I have the same problem above and as you stated, noticed my NAT rules show my two instances using ports 50002 and 50003 yet I cannot connect using those ports either.

Dear,  I had issues connecting from office network, however I have tested RDP to scale set public IP it worked perfectly. I have 3 instances in scalsets with each associated with port 50000,50001, and 50004 these are Windows 10 machines able to RDP.


Add CSS linting

We try to keep CSS out of this project as much as we can, but sometimes we have to use it--even if just temporarily.
Implement https://github.com/salesforce-ux/stylelint-config-slds within this project.

Moving to internal housekeeping list.


update dependencies

Checklist

[x] I have signed the CLA
[x] I have updated/added any relevant documentation

Description
What's the goal of this PR?
updates

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


A developer wants a card component with elevation

TODO: Add requirements.

Common questions with card components:

Is padding included in the card, and if so how do child components override that padding (e.g. negative margins) and how is that communicated to devs.
How are elevation shadows defined externally to match rest of design system?
Do we provide card header/footer slots with styling or is that up to implementer and passed in child elements?


Add support for RSDP tags

This adds support for tags for reading the address of the RSDP, a structure used in ACPI. There are two different structs, one for ACPI Version 1.0, the other for subsequent versions. It also adds tests to the grub2 test.

I think it looks good but i would like some insight from another maintainer aswell before merging. Could anyone of you take a look? @phil-opp and @le-jzr

Yeah I think there should

Ready to merge Isaac

Awesome, but I don't have write access, so could someone who does do the actual merge?

@phil-opp Could you give Isaac write access? I'll be doing this merge.

Merged

Could you give Isaac write access? I'll be doing this merge.

Done!


fix: always rebase e2e-tests and infra-deployments

Description

refer to original remote of e2e-tests and infra-deployment repos as "upstream" (see explanation)
add a logic to always rebase with main before running tests, to make sure the branch is always up-to-date
tested with https://github.com/openshift/release/pull/52146
follow-up item: delete lines below TODO comments introduced in this PR

Issue ticket number and link
https://issues.redhat.com/browse/KFLUXBUGS-1185
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
https://github.com/openshift/release/pull/52146/files
Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/test redhat-appstudio-e2e


feat(apps): add api

Overview

Fixes #(issue)
Notes for reviewer

Sorry to continue the naming discussions, but Marketplace makes sense for me. However, I think that we are enabling (not installing) integrations (and not apps).

Closing in favor of: https://github.com/openmeterio/openmeter/pull/1637


How to enable slick-loading class...

Hello,
I'm not seeing the slick-loading class pop up anywhere on my sliders so I've been unable to get a loading icon working.  I've seen this line in the js which is what would cause it to work but I don't really understand what it does so I can't really work back from it.
$('img[data-lazy]', _.$slider).not('[src]').addClass('slick-loading');
Which bit of the slider should I expect to see the slick-loading class appear on?
What's it dependant on?  For example, I'm using a background-image rather than an  as it was the only way I could think of to get the cropping behaviour that the client wanted.  Would that be an issue?
Many thanks.
http://www.form.uk.com

Hi,
$('img[data-lazy]', _.$slider).not('[src]').addClass('slick-loading'); says:

Search for images in <img> tag, which have data-lazy attribute set and have no src attribute set (aren't loaded yet by LazyLoad) and if statements met, add class slick-loading

So it will work only for LazyLoading <img> tag, no background-image.
Check demo "Lazy Loading" on Slick website.


Completely remove ratings system

Describe the feature you'd like

This is the rating menu that appears when a judge finishes judging a project. However, this isn't used in the ranking system considering and is rly for the judge to see. I am of the opinion that this feature shouldn't be default and should be an option to enable.
Big changes we would need to make:

Add option to the settings page enabling/disabling the ratings
Conditionally show the rating inputs when judge finishes judging a project -- still have the popup but just say "Are you sure you are done" or smth
Remove ratings from the judge ranking cards (see additional context below)
Show avg ratings for each category on the admin table (this wasn't there before and is actually still an open issue) -- don't have to do (#127)

Pre-existing Issue or Justification
No response
Additional context

Removed by #218


Python LeetCode 0705-Design-Hashset

File(s) Modified: 0001-two-sum.py, 0002-add-two-numbers.py, etc...
Language(s) Used: python, javascript, etc...
Submission URL: _https://leetcode.com/problems/[problem-name]/submissions/xxxxxxxxx/_

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

Hello,
Your code looks good, just one more thing, can you edit your pull request message to include a link to your submission on Leetcode ( as well as file name and language used). I ran your solution on Leetcode myself and passed just fine, but I need your link to the solution submission to merge your pull request.
Thank you.

Hi Felipe,How do I get the link to my submission?-HuanOn Aug 3, 2023, at 6:40 PM, Felipe Valencia @.***> wrote:
Hello,
Your code looks good, just one more thing, can you edit your pull request message to include a link to your submission on Leetcode ( as well as file name and language used). I ran your solution on Leetcode myself and passed just fine, but I need your link to the solution submission to merge your pull request.
Thank you.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Hi Felipe,I got the submission link and added it to the comments, I’m not sure how to edit the previous pull request since I’m somewhat new to GitHub. I tried doing a pull request, but it says everything is updated to the main branch.-HuanOn Aug 3, 2023, at 11:02 PM, Huan Le @.> wrote:Hi Felipe,How do I get the link to my submission?-HuanOn Aug 3, 2023, at 6:40 PM, Felipe Valencia @.> wrote:
Hello,
Your code looks good, just one more thing, can you edit your pull request message to include a link to your submission on Leetcode ( as well as file name and language used). I ran your solution on Leetcode myself and passed just fine, but I need your link to the solution submission to merge your pull request.
Thank you.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


fix:(documentation) Add remark about svg

Closes #133

If this is a requirement shouldn't we check for it and force the default?

I nevermind, I read deeper into the referenced issue. Documenting it should be fine.


x/tools/gopls: consider sorting completion candidates by length

Currently completion candidates are sorted by score, and then secondarily sorted lexicographically to provide a predictable order. I propose we instead do a secondary sort by candidate length, preferring shorter candidates. My intuition is that shorter names are used more frequently than longer names, so it is a somewhat better heuristic to put shorter items first, all else being equal.
Contrived example:
package main

type myStr struct {
	s string
}

func (m myStr) Get() string {
	return m.s
}

type foo struct {
	ID         myStr
	AardvarkID myStr
}

func main() {
	var f foo
	var _ string = f      // want "f.ID.s" but got "f.AardvarkID.s"
	var _ string = fidget // want "f.ID.Get()" but got "f.AardvarkID.Get()"
}

/cc @heschik because you had an opinion in slack

(Based on my limited understanding of how this all works) I think we first need to look at whether fuzzy matching (and therefore scoring) matches people's intuition: https://github.com/golang/go/issues/38380. Because my gut feeling is that, ignoring for one second whether the fuzzy matching does/doesn't match one's intuition, sorting by length/lexicographically on top of the fuzzy scoring further skews the results from an intuitive order.

My first example
var _ string = f      // want "f.ID.s" but got "f.AardvarkID.s"

doesn't involve fuzzy matching. I think that, in the absence of more information, defaulting to the shortest one makes more sense than sorting them lexicographically, at least for fields/methods.
For my second example that does involve fuzzy matching, you are probably right that the issue is better fixed via the fuzzy matcher's ranking.

I use completion to save keystrokes. Putting shorter candidates first counteracts that.

I use completion to save keystrokes. Putting shorter candidates first counteracts that.

Can you provide an example where my proposal would make candidate ranking worse?
Please note that my proposed change only impacts candidates that already have identical scores, which is not that common. The existing tie-break sorting is alphabetical, which is effectively random from a ranking perspective.

Thinking about it more, for same-score completions that already have some portion filled – which was what I was thinking about in my previous comment – shortlex order is probably rarely different from the current lexicographic order. On the other hand, both seem ultimately arbitrary. Your intuition was that shorter names are used more frequently than longer ones, but I think the only place that is a convention in Go is for local variable names.

@muirdm

Please note that my proposed change only impacts candidates that already have identical scores

If we "fix" the fuzzy completion algorithm this problem of same-score might go away?

Your intuition was that shorter names are used more frequently than longer ones, but I think the only place that is a convention in Go is for local variable names.

I would guess shorter names are used more frequently for functions, methods and struct fields as well. It is easy enough to write a program to analyze code and collect some numbers, so maybe I will do that.

If we "fix" the fuzzy completion algorithm this problem of same-score might go away?

My first example var _ string = f      // want "f.ID.s" but got "f.AardvarkID.s" would not be fixed because it is not related to fuzzy matcher scoring. "f" is an exact prefix of both candidates, and there are no other "f"s later in the candidates.


improve comments for better doc.

Things that are not clear based on the current doc and figured out from asking questions.
Hoping to create a better doc little by little.

👍


An idea to fix the Str::between method not being avail to versions before 7.6.2

This is good. Thanks!


Refine the words of the proposal.

What this PR does / why we need it:
Correct some miss spell or format errors.

/lgtm
/approve


Figure out why CI builds of Docker fail sporadically

The Docker Image CI workflow fails sporadically, e.g., https://github.com/praetorian-inc/noseyparker/actions/runs/3943453279.
Every time I have seen this workflow fail, it is with an exit code 132 when trying to run the Docker image. Re-running the workflow once or twice has always fixed it.
Why is this happening, and how do we fix it?

One hypothesis: the Docker image gets built with the vectorscan library compiled with support for certain vector instructions that some runner CPUs don't actually have, resulting in an exit code 132 (illegal instruction?) at runtime. When rerunning the workflow, eventually a runner that has the needed CPU support is selected, and the workflow succeeds.
Cf. https://stackoverflow.com/questions/60930359/docker-containers-exit-code-132

I'm pretty sure I know what is happening with the sporadic exit code 132 (Illegal instruction) issue with the Docker container:

The Docker image builds Nosey Parker against vectorscan, rather than hyperscan.
vectorscan, like hyperscan, has code that is microarchitecture-specific, using vector instructions that are not available on all CPUs.
The Docker image was previously building vectorscan with -DFAT_RUNTIME=OFF. That option causes the library to be built with support only for the current CPU microarchitecture, and not all available variations that could be loaded at runtime.
In GitHub Actions, the Docker image would be built on one machine in the cloud, and the stages cached.
Later on, when Nosey Parker's code is updated, the Docker image gets rebuilt, but using the cached stages that include vectorscan built for one microarchitecture. When finishing the build on another cloud machine with different microarchitecture, the required vector instructions are unsupported, giving the Illegal instruction error.

I believe I have fixed this now in 8146fdb7a976ad46e246a3213390741c79a67c0f, which changes the Docker image to build vectorscan with -DFAT_RUNTIME=ON.
Caveat: -DFAT_RUNTIME is only supported on x86 and Linux. If we ever wanted to build native binaries or Docker images for Windows, we would have to figure out another way to deal with the problem of microarchitecture-specific code.


Update the Contact Page UI

The current ui for the contact page is not very good...
I can make it better and modern

could assign this to me


Error: Unknown command: cask

Hi this is a very cool idea I really want to try it out. Unfortunately, it does not work with the newest version of homebrew since they deprecated the cask argument.
Error: Unknown command: cask

Probably a fix would be as easy as changing
`exec "brew", "cask", *args`

to
`exec "brew", *args, "--cask"`

@tbrodbeck Should work now… please test. Thanks!

Works. Merci!


Can't get "multipage" (Poll) sample(s) to work

Hey, I'm trying to get the hang of this multipage sample (https://github.com/SharePoint/sp-dev-fx-webparts/tree/master/samples/react-multipage), but the readme is telling me to copy a renamed workbench.html to workbench.aspx to a document library in my site?! SharePoint Online doesn't allow me to just do this and then view the aspx page as far as I know - or can someone tell me how?
I have the workbench available at /_layouts/workbench.aspx under all sites in SPO don't I? This is shown in the getting started tutorials if I recall correctly.
So anyway when I try to use the workbench.aspx in my SPO site I find the web part to add it, but then it fails. I am seeing an Uncaught Error: Sys.InvalidOperationException in dev tools console as soon as I open the workbench (unrelated to the sample, I get it). I am still able to use the workbench to add the "Poll" webpart, but then as soon as I do there's another error "Minified React" error 130.
All suggestions appreciated, thanks in advance.

This sample has been built using an older version of the SharePoint Framework which could be the reason why it's not working in SPO.

Workbench: correct, you don't have to upload workbench anymore. In the past there was no hosted version, which is why you had to do it, but now there is, so this step is obsolete.
This error is likely related to the sample using an older version of SPFx. Ideally, you would update the sample to the latest version of SPFx (either on-prem on online) and try running it then, which should work as expected.

Thanks for the quick reply. I just realised you're the author of the sample!
I tried, optimistically, to just changing the versions of the dependencies in package.json, but now getting overrun with errors. I'm not overly comfortable with the various parts in this solution - TypeScript, React and the tooling is pretty new to me.
I guess I could just start with a brand new web part project using the yeoman generator and see if I'm able to build it from scratch.

You could indeed try to create a new React web part and then move the existing web part piece by piece.


1.21 Update and Bug Fixes

Updated to 1.21.
Fixed bug where walls wouldn't connect.
Fixed bug where loot tables wouldn't drop loot.
Fixed bug where slabs would only drop one slab even if it was a double slab placement.

Hi!
Thank you so much for this, I really appreciate it!
Sorry I've been so busy this past week but once I've got some time I'll make sure to give this a review :D


Replace hypervisor mstatus.MTL, hstatus.STL with separate exception codes

The current hypervisor draft defines a dedicated bit in mstatus, called MTL, to indicate to M mode whether a page fault or access fault was due to second-level address translation or due to some other cause.  For traps delivered to HS mode, hstatus bit STL provides the same information.
It is proposed to eliminate bits MTL and STL and instead define new "guest-page fault" exceptions with these codes:
20 = instruction guest-page fault
21 = load guest-page fault
23 = store/AMO guest-page fault

Page faults due to second-level address translation would be indicated by one of these new "guest-page fault" codes in mcause or scause.  Other page faults would continue to use existing codes 12, 13, and 15.
This issue is related to #426.
With this change, it would no longer be possible to distinguish access faults due to second-level address translation from other access faults.  Hypervisors that misconfigured guest physical page tables would cause a guest virtual machine to see access faults for what should have been valid memory accesses.  However, this might be no worse than the consequences of many other potential hypervisor mistakes.
The principal (and perhaps only significant) advantage of this change would be to improve ISA consistency by using an existing mechanism (different codes in *cause) to distinguish second-level page faults from other traps.

Looks good to me.

Me too
On Thu, Aug 1, 2019 at 8:25 PM Anup Patel<EMAIL_ADDRESS>wrote:

Looks good to me.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/428?email_source=notifications&email_token=AAH3XQTH2GFWUXAISUQP6O3QCOSI7A5CNFSM4IIZ2AOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MO4JY#issuecomment-517533223,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH3XQXJ3SLFUZI3VJUAOM3QCOSI7ANCNFSM4IIZ2AOA
.

Could you elaborate the sentence below a bit?
" Hypervisors that misconfigured guest physical page tables would cause a guest virtual machine to see access faults for what should have been valid memory accesses."
I wonder why a guest VM would see an access fault caused by mis-configured second-stage translation. Should not the second-stage translation faults be handled by a hypervisor or VMM? My understand is the guest VM should not be able to observe stage-2 faults. Maybe I misunderstood something?
Thank you!

I'm guessing it means the hypervisor setting up a PTE to a physical
address which it does not have access to per PMP entries setup by M-mode.
It seemed unusual to delegate access faults.  Usually M-mode gets a
first look, then delegates in software, to the next mode, and so on.  So
I suspect the hypervisor will see it before the guest does.
-M
yyshen wrote on 2019-08-07 17:51:

Could you elaborate the sentence below a bit?
" Hypervisors that misconfigured guest physical page tables would
cause a guest virtual machine to see access faults for what should
have been valid memory accesses."
I wonder why a guest VM would see an access fault caused by
mis-configured second-stage translation. Should not the second-stage
translation faults be handled by a hypervisor or VMM? My understand is
the guest VM should not be able to observe stage-2 faults. Maybe I
misunderstood something?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/428?email_source=notifications&email_token=AAQHPINV4BE55IMLUTGHL5LQDM7WRA5CNFSM4IIZ2AOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZZ56I#issuecomment-519282425,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQHPIJEZB5N4FKOXDSYD7DQDM7WRANCNFSM4IIZ2AOA.

I wrote:

Hypervisors that misconfigured guest physical page tables would cause a guest virtual machine to see access faults for what should have been valid memory accesses.

That's assuming all access faults are delegated straight through to VS mode, which need not be the case.  Marc Gauthier may be right:

It seemed unusual to delegate access faults.  Usually M-mode gets a first look, then delegates in software, to the next mode, and so on.  So I suspect the hypervisor will see it before the guest does.

Any updates on this ?
Can we have a PR for this ?

Adopted with commit 899457caf7a9cdcb59a7d57421d249512b00de94.


Add total works dynamically

Type
✨ Feature

[ ] Demoed to @

Value
Gives the total works value as reported by the API (updated once a day).
Screenshot

Checklist
All

[x] PR labelled and assigned
[x] Any introduced code complexity has been flagged

Suggestion: rather than the exact number, round down to the nearest nice boundary?
“more than 50000 images”?

round down to the nearest nice boundary?

I dunno – I quite like the ridiculous specificity of 51795.

What is the point of this number AKA what user need is it trying to satisfy?
If the user is a researcher I can think of two uses:

I know that this is a large / small (depending on perspective) collection, which gives me an indication of how specific I should make my search
I am returning and the collection size has hanged, this allows me to see by how much

@alexwlchan given the latter point, what size change expectation should we have?
If the user is us, I can think of 1 use case: It's a brand exercise i.e. Look how big our collection is.
I know this doesn't get us closer to an answer - but at least if we have a question, we can at least then have a common though process - it might also surface that perhaps this actually creates confusion, which could be a negative.

Look how big our collection is

That's what I would think of as our initial reason for displaying this information – a bit of a brag.
But it also addresses the other two points re. search granularity and how much it's changed by since last visit (although the latter demands quite a bit from the user).
In any event, I can't see how this might cause confusion.
Does it have to answer a question about user-need at all if it's a bit of self-aggrandising?

My hunch is that there is a case for showing the size of the collection and/or number of discrete things:

Researchers want to feel that they've done a comprehensive search and that they've left no stone unturned. Putting a number to the collection lets them know that this isn't a 100 item collection that you can browse all in one go, but that it's a very large (and growing) corpus of materials.

Undoubtedly there are other ways we can do that.
From a marketing point of view,

yes, we want to tell people how much stuff we have
yes, we want to demonstrate that we're adding new stuff every week
we want to set expectations that at present we haven't got all of Wellcome Images in new search, so hold your :horse:.

HOWEVER (said in the Cooking Competition Judge Voice):

as soon as we start adding in L, M, F, A etc other images, we're no longer just 'artworks and photographs'. Everything here is technically a photograph anyway.
no one knows our target number - how many things are in our image search? Only time will tell.

BUT, I don't believe this work is wasted.
At some point I'd like to investigate how we can provide a 'Just added' feature to the digitised collections, to show the breadth of content we're making available online. So being able to tell how many things (and by extension, what things) have been added day by day, would give us something to work with.
My suggestion is that @Heesoomoon and I talk about rephrasing the text so it can accommodate new images from other WI categories. This is something we can test @hthair .

Just realised the word "explore" is there 😕 ... making me think if I click explore, that's where I would go.
Could we just use "Search", and remove the placeholder text in the text field?

If we can create a meaningful test around this, brilliant, else could we close this?

@jamesgorrie The goal of displaying the number was to set the expectation with the users. It doesn't have to be an exact number, but a rough estimate will be good enough. As for the 'Explore', I do like the idea of people browsing our full collection. I'm going to explore and make recommendations.
We can close this one for now.

this will be examined in Q1 alongside collections, possibly within the usability testing. Perhaps we do close it and open another nearer the time? Let's check with @jennpb

I don't know at the moment whether we'll have the context to test this in Q1, but I don't want to throw away the work, so can we be sure that the branch doesn't get deleted? @davidpmccormick @jamesgorrie

Can we close this in the name of neatness?

Can we close this in the name of neatness?

Absolutely.


usm: Include PathId in debug traced program list

What does this PR do?
Currently it's possible to see things like the below where the same paths are displayed as part of separate entries in the traced programs list with no hint as to why this is the case.  Include the PathId to the traced programs list to make it clear exactly which file (dev/inode) is being traced.
Before:
 {
   "FilePath": "/usr/lib64/libssl.so.1.0.2k",
   "PIDs": [
     4275,
     1111324,
     3971,
     4240,
     4416,
     1110985
   ],
   "ProgramType": "shared_libraries"
 },
 {
   "FilePath": "/usr/lib64/libssl.so.1.0.2k",
   "PIDs": [
     7562
   ],
   "ProgramType": "shared_libraries"
 },

After:
 {
   "FilePath": "/usr/lib64/libssl.so.1.0.2k",
    "PathID": {
      "Dev": 64516,
      "Inode": 655961,
    },
   "PIDs": [
     4275,
     1111324,
     3971,
     4240,
     4416,
     1110985
   ],
   "ProgramType": "shared_libraries"
 },
 {
   "FilePath": "/usr/lib64/libssl.so.1.0.2k",
    "PathID": {
      "Dev": 130,
      "Inode": 4421665,
    },
   "PIDs": [
     7562
   ],
   "ProgramType": "shared_libraries"
 },

Motivation
Improve debugging.
Describe how you validated your changes
Manually verified by checking the output of sudo curl --unix /opt/datadog-agent/run/sysprobe.sock http://unix/network_tracer/debug/usm/traced_programs | jq .

Possible Drawbacks / Trade-offs
Additional Notes

/merge


FetchPolicy.serializer being included but not generated

Hi! 👋
I was trying out the latest dev version(s) to get the __generated__ directories and I'm having problems when running tests (the app itself runs fine), due to this FetchPolicy.serializer in serializer.gql.g.dart being generated, but not actually existing.
dependencies:
  (...)
  ferry: ^0.10.5-dev.2
  gql_http_link: ^0.4.0

dev_dependencies:
  (...)
  build_runner: ^2.1.2
  ferry_generator: ^0.5.0-dev.9

@valentinmarq Hey, It seems I can not install gql_build 0.4.0 with ferry_generator.. what versions do you use for
ferry
ferry_generator?
ffa -d ferry_generator
Because ferry_generator >=0.5.0-dev.0 depends on gql_code_builder ^0.3.0-alpha.0 which depends on analyzer ^1.2.0, ferry_generator >=0.5.0-dev.0 requires analyzer ^1.2.0.
And because gql_build >=0.4.0 depends on analyzer ^2.3.0 and ferry_generator >=0.4.3 <0.5.0-dev.0 depends on gql_build ^0.2.0, gql_build >=0.4.0 is incompatible with ferry_generator >=0.4.3.
And because ferry_generator >=0.4.1-0.1.nullsafety.1 <0.4.3 depends on gql_build ^0.2.0-nullsafety.1 and ferry_generator <0.4.0-1.0.nullsafety.0 depends on code_builder ^3.2.1, if gql_build >=0.4.0 and ferry_generator <0.4.0-1.0.nullsafety.0 or >=0.4.1-0.1.nullsafety.1 then code_builder ^3.2.1.
And because ferry_generator >=0.4.0-1.0.nullsafety.0 <0.4.1-0.1.nullsafety.1 depends on gql_build ^0.2.0-nullsafety.0 and gql_build >=0.2.0-nullsafety.1 depends on code_builder ^4.0.0, gql_build >=0.4.0 is incompatible with ferry_generator.
So, because ferry_codegen_test depends on both gql_build ^0.4.0 and ferry_generator any, version solving failed.
pub finished with exit code 65

Oh yeah sorry, you must try with gql_build: ^0.2.0 to avoid versions conflicts
There is a PR https://github.com/gql-dart/ferry/pull/333 which will solve that in a future version

What goes in the generate_for option? Which files in particular is this supposed to reference?

Yeah, it didn't work for me either...
Since we already had a few scripts setup for dealing with generated files, we just added a simple find and delete FetchPolicy.serializer line.

This has been fixed in a previous release


Running Molecule against an IP address instead of created platform for converge / verify / lint?

Issue Type

Feature request / question

Molecule installation method:

pip

Ansible installation method:

pip

Use case / environment
I'm currently running Windows 10 Pro and make heavy usage of WSL (Bash on Windows, Ubuntu 16). This is where I have Ansible and Molecule installed to. I also have Docker installed with Docker for Windows and configured WSL to remotely connect to that Docker host.
In addition to that I have Vagrant installed in Windows (outside of WSL, since it doesn't work there). I use Hyper-V as a Vagrant provider to manually provision a VM which is where I run my Ansible playbooks against. All I do is supply the IP address of the VM in my Ansible inventory.
The problem: Molecule is slow with this environment
I'm new to Molecule but set things up to use the Docker "instance" platform, however running Molecule against that is painfully slow, but it's worth pointing out I have been using Docker since 2014 and I have a bunch of Rails, Flask, Phoenix and Node apps Dockerized and Docker is not slow at all for me in those situations.
Running Molecule while it's pip installed, or using the official Docker image is roughly the same speed, both are equally slow within +/- 5%.
Slowness, measured
With the above set up I took one of my roles and ran molecule converge against it, and then I ran converge again to do a 0 change Ansible run. This entire process took 58 seconds. This is with no tests too, just time spent going through the role's tasks.
Then I used Vagrant (which I ran from Windows to provision an Ubuntu 18 box backed by Hyper-V) and ran Ansible against it without Molecule. I ran the same role and then ran it again to do an identical 0 change Ansible run. This time it took 18 seconds.
The "action: create" step of Molecule finishes in like 1 second, so 57 of those seconds are spent running the role in Docker vs 18 seconds with the VM approach. That's 70% slower, and truth be told, that's too slow to use for day to day usage.
Technical limitations?
Since Vagrant can't be launched from WSL and Molecule is installed in WSL, I don't think having Molecule provision the VM is ever going to work, especially since I have Vagrant installed in Windows (outside of Molecule's environment) and configured to use Hyper-V and not Virtualbox which as far as I know isn't supported by Molecule anyways. This is also a mandatory requirement because you can't have Hyper-V and Virtualbox installed at the same time on Windows and Docker for Windows uses Hyper-V.
Feature request
For quickly converging, verifying or linting a role I think there's a huge win to be able to just provide a direct IP address to connect to and skip the create step. This way I can use Molecule to test roles through a Hyper-V backed VM that I provisioned myself with Vagrant.
Then when it comes to CI, I can use the Docker instance platform and it's all good.
Is doing that possible today? If so, please include a fully working config, since I only have like 1 hour of experience with Molecule.

After extensive searching I think the delegated driver will allow this but I'm not sure how to set it up because the docs don't include this use case.
Let's say I can ssh into a server by running ssh<EMAIL_ADDRESS>and all I want Molecule to do is convert, verify and lint a role against that server while skipping the create/destroy actions. What would my molecule.yml look like to do that?

Molecule Vagrant driver was moved to https://github.com/pycontribs/molecule-vagrant/issues and if this issue is still valid, please raise a ticket there. Thanks.


Present options for Lyme data to the program

Plan and deliver presentation on data options to Lyme program.

duplication of another issue

@lmcnabb

duplication of another issue
FFR: Which issue? #23?

Yes on duplicate and closing.


Add closed ceiling collision for space station

Part of https://github.com/PickNikRobotics/moveit_studio/issues/5754
Adds a box collision to the space station ceiling so that the robot does not try to plan through the ceiling openings.
Here's how the ceiling looks:

Here's the collision to account for this (ignore the robot on rail and its collisions; this was just the environment I was testing in :slightly_smiling_face:):

Thanks @MarqRazz! Let's wait to test on hardware one last time before merging


Fixed genDisplayName method to use reg-ex that works on iOS Safari …

…16 (used by BB Access)
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[ ] Caught up with develop branch as of last change.
[ ] Added CHANGELOG entry, or determined not required.
[ ] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[ ] Updated doc comments / prop-types, or determined not required.
[ ] Reviewed and tested on Mobile, or determined not required.
[ ] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

After more digging, I think that the regex that I changed is probably not the cause of the error on the clients device.
There is probably an offending regex in some library code.  We are going to ask the client to make sure he is on ios18 before digging further.

Source of issue was found in new markdown support, brought in to framework in v66.1.0.
offending reg ex is in this lib:
https://github.com/syntax-tree/mdast-util-gfm-autolink-literal
see their issue: https://github.com/syntax-tree/mdast-util-gfm-autolink-literal/issues/10
Closing PR without merging - @amcclain already put the fontawesome fix into develop.


Update all policies with new spec.backgroundAudit as needed

The default value is spec.backgroundAudit is true, hence, we can to set it to false for the policies targeting *. Right now we don't have policies using user/group information. Add the severity and category annotations per policy.
Acceptance criteria:
All the relevant policies are updated and a new release is done for each one of them

@kubewarden/kubewarden-developers, as far as I can see, I've updated and bumped the version of all the policies. I'm moving this to "Pending review" to double check if I'm missing something. If all the PR opened covered all the policies (and they are merged) we can close this issue.

merged, and tagged the last batch. Also went through all of them to recheck if the tags I pushed were correct or we missed any, and all have the correct releases.
Closing as done! Thanks José!


REI Integration error causes reloads to break

I'm using newly? released forge version of the mod and upon loading into a world, an error (marked as fatal by minecraft's game output console) appears. It's the same in both log files (noreload, line: 1719; reload, line: 1721). This error seems to change nothing until you reload the server. For a while it seems like the reload is going on (probably as seen in logs) but the KubeJS green loading message doesn't appear. It looks like the reload got stuck somewhere, you can't break some blocks, can't pick up items, upon quiting to main menu the saving world message stays on seemingly indefinetly (waited around 10 minutes each time, then I just killed javaw task). I'm pretty sure the issue is only caused by this mod because I tested with turning this mod off and it worked. I provided two log files because I killed the minecraft task after reloading and quitting, so some info might have been lost there.
noreload_latest.log
reload_latest.log

Fixed in the next 1.5.2 update for Forge (going on CurseForge in a second). Thanks for the report!

Thanks for the fix, but this error wasn't the thing causing reloads to break, it still doesn't work for me, the same thing is happening, although this time with no errors. The issue is something diffrent but my skills are limited and that's why I assumed the cause was the REI plugin. Should I open a new issue?

i installed gamephases with my kubejs and now i can /reload
just never finishes

same problem


Dashboard reload causes breaks namespace filtering

Setup

Rancher version: 2.6.2
Browser type & version: chrome 97.0.4692.36

Describe the bug
If a namespace is selected in the top drop down menu and whole page is reloaded (ctrl-r), namespace is visualy still selected, but dashboard displays all namespaces, see attached screenshot.
To Reproduce
Select any namespace, reload the webpage in browser (ctrl-r or reload icon)
Result
Namespace is still indicated as being selected, but dashboard displays whole cluster.
Expected Result
Namespace is either still selected (preferred) or clear indication of selected namespace.
Screenshots

after webpage reload:

This has been covered by https://github.com/rancher/dashboard/issues/4647 and https://github.com/rancher/dashboard/issues/4659. A fix has been implemented and will be included in 2.6.3


trigger setSize on refresh event

setSize needs to be executed in order to reflect new size when the options have been populated programmatically (eg. via ajax). This issue happens when listening for show.bs.select and populate the options within that function.
Test case:
$('.selectpicker').on('show.bs.select', function (e) {
        // do ajax request and when done,
        $('.selectpicker').selectpicker('refresh'); // needs to trigger setSize
});

Currently, when the options has been populated via ajax, the dropdown has been already opened and it shows all items (because rendered all li's), and once closed and opened again it shows the correct size. This is because setSize is set only when
this.$button.on('click', function () {
        that.setSize();
});

which the event happens before show.bs.select.

Available in v1.13.0-alpha.


optimize some code of ReferenceConfigBase

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9864 (f39999e) into 3.0 (feb1792) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                3.0    #9864      +/-   ##
============================================
- Coverage     65.78%   65.73%   -0.06%
+ Complexity      319      296      -23
============================================
  Files          1212     1212
  Lines         52819    52826       +7
  Branches       8008     8007       -1
============================================
- Hits          34747    34724      -23
- Misses        14283    14319      +36
+ Partials       3789     3783       -6

Impacted Files
Coverage Δ

...a/org/apache/dubbo/config/ReferenceConfigBase.java
64.23% <50.00%> (ø)

...org/apache/dubbo/rpc/filter/TokenHeaderFilter.java
0.00% <0.00%> (-27.28%)
:arrow_down:

.../apache/dubbo/rpc/filter/ProfilerServerFilter.java
62.85% <0.00%> (-20.00%)
:arrow_down:

...bbo/remoting/api/PortUnificationServerHandler.java
53.65% <0.00%> (-11.97%)
:arrow_down:

...ian2/dubbo/AbstractHessian2FactoryInitializer.java
50.00% <0.00%> (-11.12%)
:arrow_down:

.../remoting/transport/netty4/NettyServerHandler.java
58.13% <0.00%> (-9.31%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-6.90%)
:arrow_down:

...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java
69.44% <0.00%> (-6.49%)
:arrow_down:

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0.00%> (-5.27%)
:arrow_down:

...he/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
87.50% <0.00%> (-5.23%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb1792...f39999e. Read the comment docs.


Update ProjectZomboid AppID, fix server file

Attempt to fix issue #485. I've tested this on a VM, but if anyone else is able to test, it'd be appreciated.
The Project Zomboid AppID has changed as well as the structure of its
server files. This commit should point the scripts to the appropriate
files.

Awesome work!!

Thank you!


Removing "Preview" from Data Validation

This feature GAed

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-data-validation.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bug: repo activity event issue comment field missing issue_url

Kinda strange error occur when I'm trying to get events for repository. It happens in code like:
auth = TokenAuthStrategy(GITHUB_TOKEN)
gh = GitHub(auth=auth)
 async for event in gh.paginate(
        gh.rest.activity.async_list_repo_events,
        owner=owner,
        repo=repository_name,
):
    print(event.repo.name)

Error looks like:
unexpected value; permitted: <UNSET> (type=value_error.const; given={'url': 'https://api.github.com/repos/{owner}/{repo}/pulls/comments/{id}', 'pull_request_review_id': {}, 'id': {}, 'node_id': 'PRRC_', 'diff_hunk': "@@ -1154,14 +1162,14 @@ {bunch of code from pr}', 'commit_id': '', 'original_commit_id': '', 'user': {'login': '', 'id': , 'node_id': '', 'avatar_url': 'https://avatars.githubusercontent.com/u/', 'gravatar_id': '', 'url': 'https://api.github.com/users/', 'html_url': 'https://github.com/', 'followers_url': 'https://api.github.com/users/followers', 'following_url': 'https://api.github.com/users/following{/other_user}', 'gists_url': 'https://api.github.com/users/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/subscriptions', 'organizations_url': 'https://api.github.com/users/orgs', 'repos_url': 'https://api.github.com/users/repos', 'events_url': 'https://api.github.com/users/events{/privacy}', 'received_events_url': 'https://api.github.com/users/received_events', 'type': 'User', 'site_admin': False}, 'body': "", 'created_at': '2023-12-19T21:52:26Z', 'updated_at': '2023-12-19T21:52:27Z', 'html_url': 'https://github.com/owner/repo/pull/513#discussion_r', 'pull_request_url': 'https://api.github.com/repos/owner/repo/pulls/51', 'author_association': 'CONTRIBUTOR', '_links': {'self': {'href': 'https://api.github.com/repos/owner/repo/pulls/comments/143'}, 'html': {'href': 'https://github.com/owner/repo/pull/512#discussion_r14'}, 'pull_request': {'href': 'https://api.github.com/repos/owner/repo/pulls/53'}}, 'reactions': {'url': 'https://api.github.com/repos/owner/repo/pulls/comments/123/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}, 'start_line': None, 'original_start_line': None, 'start_side': None, 'line': 1167, 'original_line': 1167, 'side': 'RIGHT', 'in_reply_to_id':<PHONE_NUMBER>, 'original_position': 97, 'position': 97, 'subject_type': 'line'}; permitted=(<UNSET>,)) __root__ -> 98 -> payload -> comment -> issue_url field required (type=value_error.missing)
I have no idea what it means. I've found some issues with similar error. You said it has been fixed in #68 .
But as you can see, I still getting it.
Is it any way to fix it?

It seems this is a new schema error. could you please provide the example repo info?
As described in the schema provided by github, the issue_url field is required in the payload->comment. You may fire an issue to the https://github.com/github/rest-api-description repo.
Due to the schema issue-comment is used in many fields, the required field issue_url may be hard to change. Currently, you can use the raw json result from response.

could you please provide the example repo info?

Yes, I tried to get events from some repositories, one of it is node.js repository.

You may fire an issue to the https://github.com/github/rest-api-description repo.

I'll do it. Thanks.

Currently, you can use the raw json result from response.

Sorry, but could you give a details how can I do it in correct way? Is it smth like
gh.paginate(gh.request. ...)?

you could provide a custom map_func to the paginator like this:
async for event_dict in gh.paginate(
    gh.rest.activity.async_list_repo_events,
    owner=owner,
    repo=repo,
    map_func=lambda resp: resp.json()
):
    ...

the default map_func is to use the resp.parsed_data to provide data validation and type hints. you can use the response.json() to get the raw json data instead.

Thanks a lot

async for event_dict in gh.paginate(
    gh.rest.activity.async_list_repo_events,
    owner=owner,
    repo=repo,
    map_func=lambda resp: resp.json()
):
    .

So, this code raises HTTP exception 422. If I remove map function it return to the beginning. Should I open new issue? Is it error with your lib at all?
Full traceback can be found here: https://pasty.lus.pm/ngCEz5

I could not repreduce the error with http 422. but according to the github docs, http 422 indicates "Validation failed, or the endpoint has been spammed."


[CS2103T-W10-3] SoConnect

SoConnect is for computer science university students who prefer to use CLI over GUI, and want to keep track of the large amounts of friends and staff they have encountered in university.
Through an address book, this product aims to store information, such as faculty, course, frequency of meeting, phone numbers, etc, of friends or staff, so that the student will be able to remember and refer when needed.

Codecov Report

Merging #107 (2a79683) into master (ba53b8c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba53b8c...2a79683. Read the comment docs.


Update flyway-core to 8.5.0

Updates org.flywaydb:flyway-core from 8.3.0 to 8.5.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #262.


[BUGFIX] tags were not stored.  Now they are.

When retrieving triggers using st2 trigger get, no tags where shown even though they were define in the sensor yaml file.  With these changes tags for triggers are properly stored when registering sensors.

@tdeckers The change itself is right but the branch you would like to merge on is not. Here is my suggestion -

Open the PR against master instead of 0.13.
The next 0.13 patch is slated for 0.13.3. I will cherry pick your change from master to 0.13.3 so that it is available with the next patch. You can do this too and will result in 2 PRs.

[Our patch release workflow is somewhat opaque, we stage all changes on a patch-branch, 0.13.3 in this case, and when ready we merge 0.13.3 to 0.13. This kicks off our opaque StackStorm based released infra and we build and publish packages. For now changes need to be on master as well as the patch branch to show up everywhere.]


[INLONG-2562] [Manager] Supporting data flow to Kafka

Title Name: [INLONG-2562][Feature][Manager] Supporting data flow to Kafka
Fixes #2562
Motivation

Manager Support data flow to Kafka

Modifications

Add code files to support data flow to Kafka .*

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

willing to be  recommit


Issue with processFulltextDocument API: Frequent "503 Service Unavailable" Responses

Operating System and architecture (arm64, amd64, x86, etc.)
x64/wsl
What is your Java version
OpenJDK Runtime Environment (build 11.0.24+8-post-Ubuntu-1ubuntu324.04.1)
I’m encountering an issue where my script for batch-processing PDFs using GROBID’s processFulltextDocument API frequently generates output files containing the following error message:
html
Copy code

<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 503 Service Unavailable</title>

HTTP ERROR 503 Service Unavailable

URI:	/api/processFulltextDocument

STATUS:	503

MESSAGE:	Service Unavailable

SERVLET:	jersey

Script Setup: I'm running a script that uses requests with ThreadPoolExecutor to submit multiple PDFs to the API in parallel. Here is a sample of my code:
python
Copy code
import os
import requests
from tqdm.auto import tqdm
import concurrent.futures
import logging

# Define the target directory and subdirectories based on your provided structure
target_directory = '/mnt/g/My Drive/RuBase/Corpora/Russian-Ukrainian war'
raw_pdfs_path = os.path.join(target_directory, 'full_text')
processed_pdfs_path = os.path.join(target_directory, 'grobid_processed_pdfs')
logs_dir = os.path.join(target_directory, 'logs')

# Ensure the processed PDFs and logs directories exist
os.makedirs(processed_pdfs_path, exist_ok=True)
os.makedirs(logs_dir, exist_ok=True)

# Set up logging to file
log_file_path = os.path.join(logs_dir, 'pdf_processing_log.log')
logging.basicConfig(filename=log_file_path, level=logging.INFO,
                    format='%(asctime)s - %(levelname)s - %(message)s')

# Print directory setup information
print("Directory set for raw PDFs:", os.path.abspath(raw_pdfs_path))
print("Directory set for processed PDFs:", os.path.abspath(processed_pdfs_path))
print("Logs will be saved to:", os.path.abspath(log_file_path))

# Count the number of PDF files in the raw_pdfs directory (excluding subdirectories)
pdf_files = [
    f for f in os.listdir(raw_pdfs_path)
    if os.path.isfile(os.path.join(raw_pdfs_path, f)) and f.endswith('.pdf')
]
num_pdfs = len(pdf_files)
print(f"Number of PDF files to process: {num_pdfs}")

# URL for the GROBID service
url = 'http://localhost:8070/api/processFulltextDocument'

# Function to process a single PDF file
def process_pdf(pdf_file):
    pdf_file_path = os.path.join(raw_pdfs_path, pdf_file)
    json_file_path = os.path.join(processed_pdfs_path, pdf_file.replace('.pdf', '.json'))

    # Skip if the JSON file already exists
    if os.path.exists(json_file_path):
        message = f"Skipped {pdf_file} (already processed)"
        logging.info(message)
        return message

    try:
        with open(pdf_file_path, 'rb') as file:
            files = {'input': file}
            response = requests.post(url, files=files)

        # Write the response to the processed PDFs path
        with open(json_file_path, 'w', encoding='utf-8') as output_file:
            output_file.write(response.text)

        message = f"Processed {pdf_file} and saved output to {json_file_path}"
        logging.info(message)
        return message
    except Exception as e:
        message = f"Failed to process {pdf_file}: {str(e)}"
        logging.error(message)
        return message

# Process PDFs using concurrent futures
batch_size = 10  # Adjust the batch size as needed

with concurrent.futures.ThreadPoolExecutor() as executor:
    futures = {executor.submit(process_pdf, pdf): pdf for pdf in pdf_files}
    for future in tqdm(concurrent.futures.as_completed(futures), total=num_pdfs, desc="Processing PDFs"):
        pdf = futures[future]
        try:
            result = future.result()
            tqdm.write(result)
        except Exception as e:
            error_message = f"Error processing {pdf}: {str(e)}"
            tqdm.write(error_message)
            logging.error(error_message)

print("All files have been processed.")
print(f"Check the log file for details: {os.path.abspath(log_file_path)}")

Frequency of 503 Errors: This "503 Service Unavailable" error occurs frequently, causing the script to create many output files that only contain the HTML error response instead of the JSON output.
Error in GROBID Logs: The GROBID logs show recurring entries indicating high load, but the server’s capacity or rate limits are unclear.
Questions:
Rate Limits: Are there any known rate limits or maximum concurrent request limits for the GROBID processFulltextDocument endpoint?
Server Tuning: Are there specific server or configuration adjustments (e.g., thread limits, queue sizes) recommended for handling large-scale batch requests?
Best Practices for Batch Processing: Any tips on structuring requests (e.g., delays or reduced concurrency) to minimize the risk of overloading GROBID?
Any guidance on configuring GROBID or adjusting my script to avoid this 503 error would be greatly appreciated. Thank you!

Hello @sdspieg
Sending 503 error is a normal behavior of GROBID and it means that the pool of threads is entirely used (max parallel requests). As documented, it means that the client has to wait a bit before sending new requests, the time that a new thread is available.
For a reference implementation on how to use the service in parallel, please look at the Grobid clients, in particular the Python client, other languages are available.
The documentation also indicates how to modify the size of the pool of threads, to adapt it to the server running the service.

I'm closing this, @sdspieg if you need further assistance, just reopen it.


[BugFix] Give a default value to eliminate the DCHECK error in debug mode

Signed-off-by: zombee0<EMAIL_ADDRESS>What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Build-in function will use column_type_to_type_desc to create context, but for map type and map functions the type is not useful so we can just give a default type value.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

run starrocks_admit_test


[vcpkg] Add MAKE_OPTIONS and MAKE_INSTALL_OPTIONS

This pull request allows for adding options for make and make install. This is especially useful for projects that don't have a configure file and only have a Makefile. Example usage:
vcpkg_configure_make(
    SOURCE_PATH ${SOURCE_PATH}
    SKIP_CONFIGURE
)

vcpkg_install_make(
    MAKE_INSTALL_OPTIONS_DEBUG
        "PREFIX=${CURRENT_PACKAGES_DIR}/debug"
        "BINDIR=${CURRENT_PACKAGES_DIR}/debug/tools/${PORT}"
    MAKE_INSTALL_OPTIONS_RELEASE
        "PREFIX=${CURRENT_PACKAGES_DIR}"
        "BINDIR=${CURRENT_PACKAGES_DIR}/tools/${PORT}"
)

When I developed this set of functions, I didn't consider the scenario where I need to pass parameters when executing make.
But for the installation path, it is already set by default[1]. You can also disable the default setting[2].
[1]. https://github.com/microsoft/vcpkg/blob/1bdb6bfec1929b0d30cb5a4c3353c1e62905f10f/scripts/cmake/vcpkg_configure_make.cmake#L157
[2]. https://github.com/microsoft/vcpkg/blob/c0d22c88ea7638d1b74339f9e9adfd37b0f525ed/docs/maintainers/vcpkg_configure_make.md#disable_auto_dst

Hm... This would still require configure (or configure.in if using Autoconfig), right?

@SeekingMeaning I know what you mean. And my suggestion is to rename INSTALL_OPTIONS to MAKE_INSTALL_OPTIONS to avoid misunderstandings as settings during configuration.

Could you please add some example to check it?

Like a port? I have a local version of #9558 that uses this, is that okay?

Yes please.

Oh whoops, I forgot to update for the INSTALL_OPTIONS name change.

/azp run

Quick question: should the port be removed before merge?

@SeekingMeaning Hmm... I think you can combine two PRs into one and close #9558.

Another question: I have this working with LuaJIT; should I wait to open a new pull request or add the changes to this one?

If your changes are related to this PR, please submit to this PR.
Thanks.

Anything else?

@SeekingMeaning No, we are waiting for fix osx PR test. See #9600.

Somehow we lost track of this PR. @SeekingMeaning can you fix the conflict?

Sure, I'll have to open a new pull request though since the original fork was deleted


non-ascii filenames cause error listing files

Hi there,
I was testing out running a server (MacOS, build from source) and I noticed an issue. Any unicode won't list and produces this log:
2024-06-08T20:28:52.886+0700	debug	Received Transaction	{"remoteAddr": "<IP_ADDRESS>:49556", "login": "guest", "name": "guest", "RequestType": "TranGetFileNameList"}
2024-06-08T20:28:52.886+0700	error	Error handling transaction	{"remoteAddr": "<IP_ADDRESS>:49556", "login": "guest", "name": "guest", "err": "encoding: rune not supported by encoding."}

my test file names were ベスト.txt and helló.txt. Client was https://github.com/mierau/hotline.
Not sure if this is a bug in the server or client or even an issue in the protocol itself? Either way, thought I'd report it. Thanks for the cool project.

Hi there.  Thanks for raising this.
The Mobius project targets compatibility with the original Macintosh Hotline clients, which limits the characters that it can use to those in the Mac OS Roman encoding.
Mobius supports encoding translation for a small subset of unicode characters that have equivalents in the Mac OS Roman character set.  For example, ∞ or ƒ.  Not sure why ó doesn't work -- seems like it should!  The Japanese characters would definitely not work though.
I'll fix the file listing transaction to log a better error and skip files with incompatible names instead of totally failing.

Historically, Japanese servers used the Shift JIS encoding. Over the years I've seen servers use Mac OS Roman, Latin 1, Shift JIS and UTF-8. But as far as I know, other than the user selecting what encoding they want to use, or the clients trying to autodetect it, the protocol never took into consideration how to handle it.

I would love to see a way to start the server with the encoding of your choice, or add auto detection logic. It can still default to Mac OS Roman, but giving more flexibility is a good thing. Most people use UTF-8 these days, and it would be nice for server operators to opt into a more widely used character set.


neurodataviz render not showing last section in stack

The calculated z bounds of a stack appear to have an off by one error making it impossible to view the last section (the one with the largest z values) of a stack.

Fixed!


Fix the password prompting in the user create command

This throws an error on a missing method. Do it the same way we do in the user create plugin in knife itself.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Specs pass fine locally


[App] Coinbase Wallet Connection Bug

Related to #698
I connected once using CoinbaseWallet, and then disconnected. After that, every time I try to reconnect, I get immediately disconnected automatically. This behavior is reproducible at least across Chrome, Firefox, and Brave.
Screen-capture video is attached.
Uploading Screencast from 09-14-2022 07:37:14 PM.webm…
Note: when I connect through the browser on the CoinbaseWallet app on mobile, the connection persists correctly.

cc @Atmosfearful

Something to test for with the new connect modal @angusfretwell


Error playing media on tablet

Fire Tablet 8
Fully Kiosk Version: 1.46-fire
Home Assistant Version: 2022.3.3
I am attempting to play a wav file via the FK integration's media player. I am using the following script:
  arming_alarm_zones_closed:
    alias: Arming Alarm Zone Open
    sequence:
    - service: tts.google_translate_say
      data:
        entity_id: media_player.porte_cochere_control_panel
        message: "Arming Alarm"
    - delay:
        seconds: 3
    - service: media_player.play_media
      data_template:
        entity_id: media_player.porte_cochere_control_panel
        media_content_id: /local/media/alarm-activating1.wav
        media_content_type: 'music'

The TTS service call that points to the media player works with no issue. Trying to pass in the media to play does not give an error in the HA logs however does give the following error displayed on the tablet screen:
Failed loading sound: Wrong URL or unsupported format?

If I change the media player entity to another one in my house with no other changes, that script works just fine.
Is there a different way that I am supposed to be playing media? Is there a specific format that is supported other than wav? I have tried converting the audio to mp3 and changed the type to audio/mp3 and although it works on the other media player, that also fails the same way on the tablet.
Any assistance would be appreciated.

+1 on this issue.

+1 on this issue.

+1 on this issue.

Same issue. +1 on this

+1 on this issue.

Please try again with the new integration update (1.0.2) and let me know if this is still an issue.

Closing as the original issue was resolved (Related to an HA update)
@ronaldvdmeer if you're still having trouble please open a new issue with additional details. Thanks!


How to make centos-sclo-rh-source and centos-sclo-sclo repos available on ppc64le ?

I could able to build s2i base centos based container on x86. However, while building it on ppc64le , 2 repositories (centos-sclo-rh-source and centos-sclo-sclo) are getting enabled after "centos-release-scl" dependency installation. Due to these repos, we are not able to install any other dependencies.
Getting error - http://mirror.centos.org/centos/7/sclo/ppc64le/rh/repodata/repomd.xml: [Errno 14] HTTP Error 404 - Not Found
Looks like these repos are not available on ppc64le , as I was getting 404 error while accessing http://mirror.centos.org/centos/7/sclo/ppc64le/rh/repodata/repomd.xml  and for x86 its accessible http://mirror.centos.org/centos/7/sclo/x86_64/rh/repodata/repomd.xml
Please can you help us on how to make above mentioned repositories available on ppc64le ?
Thanks in advance !

Are there source rpms available for above mentioned repositories ,if yes then can you please share the location , so that will try building it manually on ppc64le ?
Thanks!

@sandipmgiri, @pkubatrh is correct, we do not have other-than-x86_64 builds for most of the SCL, therefore we do not have repos either. However, if you want to build it yourself, the source RPMs should be the same, as the same SRPM are used for all builds in upstream (RHSCL). You can get the SRPMs from CBS, e.g.: https://cbs.centos.org/koji/buildinfo?buildID=24130
Let me also mention that ppc64le, s390x and aarch64 builds are available in the RHSCL repositories, for RHEL users (might not be your case, but worth mentioning).

The process of building SCL packages from src rpms in CentOS7 is made a bit painful due to the extras ppc64le repo not being fully functional, so one can't easily do a yum-builddep on the src rpm to grab the packages necessary to build.  Works fine in RHEL7.  The alternative is to extract the SPEC file and grep out the build dependencies for each src rpm; can be scripted, but could take a while to run.
While plenty of docker containers exist for running pre-built SCL programs, didn't see any for building them, which would be handy, especially if it had tooling to automatically deploy build dependencies.

I'm gonna close this stale issue. If you still have something related to the base containers to discuss, feel free to reopen it.


[staging-20.09] mesa bugfix releases

Motivation for this change
A game (Trine 4) has recently been crashing on me. Using a newer mesa bugfix release seems to solve this.
The last commit isn't a cherry-pick, because 20.1.10 was never on master, as it went to 20.2.x after 20.1.9.
Release notes:

https://docs.mesa3d.org/relnotes/20.1.8.html
https://docs.mesa3d.org/relnotes/20.1.9.html
https://docs.mesa3d.org/relnotes/20.1.10.html

cc @vcunat @primeos
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

OK in principle, but I'd feel safer if a few people (with different GPUs) tried this on their 20.09 system before we merge it into release-20.09.  We had an unpleasant regression like this once.
It should be sufficient to test without a large rebuild.  In past I've been using config like this (adapted to current version):
{
  imports = [
    (let mkDrivers = pkgs: (pkgs.mesa.overrideAttrs (a_: rec {
          branch = "20.1";
          version = "${branch}.10";
          src = pkgs.fetchurl {
            urls = [
              "ftp://ftp.freedesktop.org/pub/mesa/mesa-${version}.tar.xz"
              "ftp://ftp.freedesktop.org/pub/mesa/${version}/mesa-${version}.tar.xz"
              "ftp://ftp.freedesktop.org/pub/mesa/older-versions/${branch}.x/${version}/mesa-${version}.tar.xz"
              "https://mesa.freedesktop.org/archive/mesa-${version}.tar.xz"
            ];
            sha256 = "17zfqvc3q2pxy2bjwg8zp5sqqjlsv4rpizdx9k5rzb5d22csdnxi";
          };
        })).drivers;
      #pkgs = import (builtins.fetchTarball https://github.com/nixos/nixpkgs/archive/nixos-20.03.tar.gz) {};
      in { /*pkgs,*/... }: {
        hardware.opengl = {
          package = mkDrivers pkgs;
          package32 = mkDrivers pkgs.pkgsi686Linux;
        };
      }
    )
  ];
}

I'm on a Radeon RX 5600 (Navi 10) with amdgpu on 20.09 and I have the same issue with Trine 4 (what a coincidence!).
I'll play a few hours to test this (but the problem usually happens after about 1 min).
One thing to note, while @ajs124 is on X11 with KDE, I'm on Wayland with Sway, so I'm indirectly testing the patch on Wayland as well ;)

Well so… I wanted to say it all runs fine… until I chose to pick up a collectible letter I didn't have yet:

So you're probably fine unless you pick up letters (?)

For anyone trying to reproduce this:
It was in Act II, The Thorny Hedge Maze at checkpoint 15 the first letter you find there.

Spoiler
Start at checkpoint 15, place a plank in the spikes to your right. Dash onto the plank with the knight, discover the secret area.
Place a box inside the contraption, jump onto the contraption, jump to the left, and dash to the right with the knight. Pick up the letter, see the game crashing.

Well, I'm mainly concerned about big regressions making desktop unusable, etc.  If nothing like that happens, maintenance updates sound a good idea.

@dasJ can reproduce :'(
I'm on a RX580. This should still be merged IMHO, but more testing can't hurt.
The only other relevant GPU I have is an Intel iGPU, though.

How long do we want to wait for testers? Guess we only had amdgpu testers up to now. Unfortunately I'm on unstable with amdgpu as well.

I could also try an Intel, within a few days.

⬆  I tried: desktop stuff, glxgears + glxinfo.  I don't normally use this notebook, so no big testing.


cs operator should laways deploy certmanager cr if crd exist

for ticket: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/58575

@qpdpQ
Could we also open an PR against branch release-323 for CS 3.23.x?


Create an event system to support GBA, DOS and other baremental environments

There is libevent to provide portable event loop support to applications on modern operating systems like Linux, macOS, and Windows. Unfortunately this library does not support ancient environments where even a libc may be absent or sparsely available, and porting it over would be a messy undertaking.
To solve this problem, it is proposed that unilib offer a simple event API that is well-scoped as to work nicely in all environments including old ones, which under the hood either implements event polling using system-specific BIOS calls and interrupts, or wraps libevent where it is already available.
A properly-written event loop is important to virtually every sort of graphical application, as it allows programs to let the CPU idle where possible, providing better responsiveness and power consumption along with the concurrency benefits of the implied async programming.

The meat of current work to bring this feature to fruition is the porting of mt19937lib to C, so that it can run on baremetal. It will find entropy sources on its own for all the hosted platforms, but further work will be needed to source entropy on the GBA. No plan yet on how entropy will be sourced on DOS.


[KeyVault] Make sure the tests folder is called "test"

The template project and all the other projects in this repository use "test" as the name for the tests folder.

It will happen as part of the new record and playback tool: https://github.com/HarshaNalluru/azure-sdk-for-js/pull/12/


Bangkok Christain College

@baipoonnn I am sorry for a delay with processing your request.
Pull request merged. Thank you!


P0092R1 Polishing <chrono>

https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/p0092r1.html
__cpp_lib_chrono : 201510L

完了


Feature install

Lots of minor changes:

files re-organisation
setup.py
Makefile
use "pipelines" as package name

I funked up some of the rebase .. funky !


Remove version: hrzlgnm.mdns-browser version 0.7.14

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/hrzlgnm/mdns-browser/releases/download/mdns-browser-v0.7.14/mdns-browser_0.7.14_x64-setup.exe
Status Code: 200
(Automated message - build 899)

URL: https://github.com/hrzlgnm/mdns-browser/releases/download/mdns-browser-v0.7.14/mdns-browser_0.7.14_x64-setup.exe
OK
(Automated message - build 923)


flatten: compile error with copy assignment

First of all, I know this library is not supposed to be ready for public usage. But I really love the concept, so I had to try it
Of course, I will understand if you do not want to provide support
I am encountering a compile error that I haven't been able to solve. It is easily reproducible. Godbolt link

Actually, the best solution is probably to avoid operator= altogether.
std::optional has emplace. If we add emplace to maybe, we can then use it in place of operator=, and this should fix the issue

No problem filing bug reports! :) Just no promises that I'll be able to fix them...
This is a known (to me) issue that I've run into myself from time to time. If I recall correctly, the reason I used assignment rather than emplace() is that emplace() is non-constexpr in C++17, and cannot be made constexpr  because it involves changing the active member of a union (which wasn't allowed until C++20).
At the time I decided that being able to use flatten at compile-time was more important than occasional compile errors when using lambdas, but in hindsight that was probably the wrong trade-off.

constexpr support is nice too. So it's either constexpr with a heap allocation, or no constexpr and no heap.
I think we should use std::unique_ptr, as a single heap allocation will probably have no significant impact.
If you tell me what you prefer, I can implement it for you

I'll need to think about this one -- I don't think allocation should be necessary if we're willing to forego constexpr flatten in C++17 mode, but it would mean adding emplace() to flow::maybe, which it currently doesn't have. There may be other complications as well, I looked it at once before but it's a long time ago and my memory is failing me :).
Leave it with me and I'll see what I can come up with.


Check miner if not staked (don't submit failed txns)

Best to check if miner status equals 1, because being in dispute (3) and in the middle of withdrawal (2) process are not valid states for mining either.

or check if they are in dispute (good comment banteg)

See line 69 of disputeStatus.go.


Refine runners/reference/java dependencies and fix minor static analysis issues

R: @robertwb

Is the reference job server going to stay there, or are there plans to move it to other module?

The code changes look fine to me.
I think it would make sense to move this to a runners/portable module. (Open to other ideas though.)

I think @angoenka said he was looking at this. I was just not sure if it was finally happening or it was just going to state in reference.


Tolerate new udev actions "bind" and "unbind"

Recent kernel and udev versions have added new actions that are triggered on top of the usual add and remove actions. This causes the script to exit 1 every time, which appears as a warning in udev logs. Why not a big deal, this is ugly, this patch fixes that and protects us against future new events as well.

@navaati I'm new to udev scripts. Is the bind action in addition to the add action, or does it replace it? I had to modify the script like #7 for it to work as expected on Ubuntu 20.04.4 LTS.

It’s in addition, which means that your change in #7 will try to attach twice, which is probably harmless but still not great.

@navaati I tried the navaati:patch-1 branch, and the USB device did not attach to the VM as expected. The virsh attach-device command failed with unable to execute QEMU command 'device_add': failed to find host USB device

When I use my branch Geekdude:master, it does indeed run the script twice; on the add action it fails with the same error, then on the bind action, it succeeds.

Oh ok that’s much curious, thanks for the testing. Let me see my current file… Ahah ! Interesting, I have an additionnal "sleep 1" at the end (see other comment I’ll add). So maybe the "add" action is too early and the "bind" action is the right one, and we can kind of combine both our patches to arrive at the right result…
We need to check the udev doc regarding the lifecycle and timing of events.

Most extensive documentation seems to be this LWN article (bless jcorbet): https://lwn.net/Articles/837033/.

Ok so reading that, definitely "bind" is the later event and the one we want to use. I’ll rework my branch later today to use it (and ignore other events, in particular add) and remove the sleep, then I’ll test-drive that for a week. It makes the change more impactful, though, because it makes the script not work on systemd versions older than 247 (I think CentOS7 uses systemd 219), that’ll be a decision to be taken by the maintainers.

I was thinking along the same lines as well. If bind is the event we want, is it better to break backward capability by only responding to bind events or to maintain backward capability, but to have the add action fail? The proper approach is probably to have conditionals that check the version systemd/kernel and respond according.
Also, according to this line, "For drivers that support the new mechanism, a BIND event for a device will follow the ADD event once the device is ready to operate." We might still want to respond to both event types since, depending on the drivers, there might only be an ADD event. I don't think there is any issue with trying to attach a USB device twice with virsh, but that might be something we should test. So we really want bind events, but if there will not be a bind event, then the script should respond to the add event.


Add fuel units to consumed_fuel into a store

Is there a way to add some fuel units to the consumed fuel?
I would like "to charge" the calls to my host functions.
And why a function that uses an host function to store a Vec consumes about 10-20 times fuel that a function that uses another host function to load the same data
Thanks a lot for your work!

By units, do you mean a meaning to the number used to inject fuel? If so that doesn't really have any units per-se and the exact calculation of what fuel is is somewhat fuzzy. It somewhat corresponds to wasm instructions, but not always precisely so.
Fuel is not consumed by host functions, though, other than the call instruction used to enter host code. Different host code should always look like it consumes the same amount of fuel. Can you describe the situation in which you're seeing two host functions consume different  amounts of fuel?

I think @willygroup wants different host functions to consume specific amounts of fuel determined by said host function.

@alexcrichton yes, I was thinking just such a thing.

And why a function that uses an host function to store a Vec consumes about 10-20 times fuel that a function that uses another host function to load the same data

Any hints for this?
To test it, I've written a small wasm with 3 methods:

store(data_addr: i32, data_size: i32)

the data is stored on the memory from the host before the store call

load() -> i64

return an i64 as combination of i32 address ant i32 size of the return data slice

that use 2 host function:

store_data(key: &str, data: Vec)
load_data(key: &str) -> Vec
Vec are passed as memory address and memory size

The fuel consumed by these methods is the following:

store 	data: 100bytes  ### FUEL CONSUMED: 6_995
load	data: 100bytes  ### FUEL CONSUMED: 18_971
store 	data: 50KB		### FUEL CONSUMED: 855_692
load 	data: 50KB      ### FUEL CONSUMED: 6_589_590
store	data: 100KB     ### FUEL CONSUMED: 1_705_726
load	data: 100KB     ### FUEL CONSUMED: 13_726_190

Thanks a lot!


Customize Wrap Panel?

Hello, how would one customize the Wrap Panel of Tabalonia? Normally you would be able to change it's color with:
<Style Selector="WrapPanel">
        <Setter Property="Background" Value="Blue" />
</Style>

Thanks in advance!

Behind the + for example

Behind the + for example. Screenshot is from the Demo Gif.

What about the rest of the background? Behind the + and behind the tab?

You can create your own style. Tabalonia.Demo has an example of hosting your own theme (Styles/MyTheme.axaml)


Missing command

Enable-Mailbox command is not imported. Only Enable-RemoteMailbox.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36b57b66-2364-0e9d-e627-5eeb77238675
Version Independent ID: 78fd7932-06f9-37c7-8928-250b3884d89e
Content: Connect to Exchange servers using remote PowerShell
Content Source: exchange/docs-conceptual/connect-to-exchange-servers-using-remote-powershell.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@badsector-82, the topic that's referenced in this issue doesn't mention either cmdlet.
The Enable-Mailbox topic describes the cmdlet as available in Exchange 2010 to Exchange 2019 and Exchange Online.
The Enable-RemoteMailbox topic describes the cmdlet as available in Exchange 2010 to Exchange 2019 (on-premises only).
I tried both cmdlets in remote PowerShell  (not Exchange Management Shell) connections to Exchange 2010 SP3 RU30, Exchange 2013 CU23, Exchange 2016 CU19, and Exchange 2019 CU8, and they were both available.
In a connection to Exchange Online PowerShell, Enable-Mailbox was available, but Enable-RemoteMailbox was not, just like the documentation says.
So what's the issue?

@badsector-82, the topic that's referenced in this issue doesn't mention either cmdlet.
The Enable-Mailbox topic describes the cmdlet as available in Exchange 2010 to Exchange 2019 and Exchange Online.
The Enable-RemoteMailbox topic describes the cmdlet as available in Exchange 2010 to Exchange 2019 (on-premises only).
I tried both cmdlets in remote PowerShell  (not Exchange Management Shell) connections to Exchange 2010 SP3 RU30, Exchange 2013 CU23, Exchange 2016 CU19, and Exchange 2019 CU8, and they were both available.
In a connection to Exchange Online PowerShell, Enable-Mailbox was available, but Enable-RemoteMailbox was not, just like the documentation says.
So what's the issue?

So what's the issue?

The issue was that not all exchange commands were being imported. It turned out that are imported only commands that the account used for the connection has rights for. Which is logical and awesome but I found it the hard way. Also this could be used to test what commands each exchange role enables. In conjunction with Get-ManagementRole I was able to find the solution which requires least privilege rights for my needs. So sorry for bothering you, but it could probably be useful to mention that account dependency somewhere in the article.

So what's the issue?

The issue was that not all exchange commands were being imported. It turned out that are imported only commands that the account used for the connection has rights for. Which is logical and awesome but I found it the hard way. Also this could be used to test what commands each exchange role enables. In conjunction with Get-ManagementRole I was able to find the solution which requires least privilege rights for my needs. So sorry for bothering you, but it could probably be useful to mention that account dependency somewhere in the article.

@badsector-82, interesting suggestion. I'm surprised that hasn't come up in all this time. I added a similar bullet to the What do you need to know before you begin? section of all Exchange-related PowerShell connection topics:

After you connect, the cmdlets and parameters that you have or don't have access to is controlled by role-based access control (RBAC). For more information, see Exchange Server permissions.

@badsector-82, interesting suggestion. I'm surprised that hasn't come up in all this time. I added a similar bullet to the What do you need to know before you begin? section of all Exchange-related PowerShell connection topics:

After you connect, the cmdlets and parameters that you have or don't have access to is controlled by role-based access control (RBAC). For more information, see Exchange Server permissions.

Thank you and again sorry for the trouble!


Custom data and Markdown support. Fix #132

Allow MarkupContent in custom data JSON
Build up hover instead of returning early when a Node has hover content (otherwise all hovers over selector show the specificity instead of the more granular hover)

Also I suggest to add a test that shows a hover with both markdown text and specificity.


[Bug]: Android 14 usb support

Impacted Library name
@ledgerhq/react-native-hid
Impacted Library version
all
Describe the bug
After upgrading Android project to sdk 34 (which is now required to publish to play store), the following error occurs:
One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts

Expected behavior
App should not crash when using the library.
Additional context
https://stackoverflow.com/a/77276774
Lines:
https://github.com/LedgerHQ/ledger-live/blob/8649ebf286d15c2cd97426ae03009d4ef2d28f4e/libs/ledgerjs/packages/react-native-hid/android/src/main/java/com/ledgerwallet/hid/ReactHIDModule.java#L61
and
https://github.com/LedgerHQ/ledger-live/blob/8649ebf286d15c2cd97426ae03009d4ef2d28f4e/libs/ledgerjs/packages/react-native-hid/android/src/main/java/com/ledgerwallet/hid/ReactHIDModule.java#L216
Need to be updated to include RECEIVER_NOT_EXPORTED like
getReactApplicationContext().registerReceiver(receiver, intFilter, RECEIVER_NOT_EXPORTED);

Or rather this for retrocompatibility
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
            getReactApplicationContext().registerReceiver(receiver, intFilter, Context.RECEIVER_NOT_EXPORTED);
        } else {
            getReactApplicationContext().registerReceiver(receiver, intFilter);
        }

I create this PR that fix the error: https://github.com/LedgerHQ/ledger-live/pull/7880

Still an issue, the PR is just stuck it seems.


format amount pay modal

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3686   👈

PR #3687

This comment was auto-generated by Graphite.

@wraeth-eth started a stack merge that includes this pull request via Graphite.

@wraeth-eth merged this pull request with Graphite.