Trino Superset CSV Upload Error 'Cursor' object has no attribute 'lastrowid'

Hello,
I've connected trino to superset and am able to load data into superset from trino. I have tried to enable CSV upload to my trino cluster from superset, but am receiving an error:
Unable to upload CSV file "sqllab_query_sf_population_polygons_20210315T102218.csv" to table "sample" in database "LAKE". Error message: 'Cursor' object has no attribute 'lastrowid'

I'm assuming this is a sqlalchemy-trino issue as that is the driver I am using. CSV upload to other databases, sich as Postgres, works fine.
Here is an example of my dataset.
> cat sqllab_query_sf_population_polygons_20210315T102218.csv | column -t -s ","
zipcode  population  area
94107    26599       6.11
94105    5846        1.23
94129    3183        6.11
94121    41203       5.69
94118    38319       4.07
94123    23088       2.74
94133    26237       1.91
94109    55984       2.74
94111    3713        0.9
94104    406         0.18

I appreciate that there are a lot of moving parts here, and that the error could be in superset, or pandas, or trino-sqlalchemy, or trino, or my minio-based backing store.
Any suggestions on how I might go about eliminating trino-sqlalchemy as the root cause?

Let's me check it out :)


Implement "allOf" of object types as single class

This is a stop-gap measure before we have subtypes or interfaces.

If all elements in an allOf are object types that allow additional properties, we can make a single class out of them.

If a property is required in any one of the elements then it's non-optional.

Properties that are object types need to be allOf-ified recursively if they occur in more than one element.

The same goes for the item types of arrays and maps.

Integers and numbers become integers.

Enums and strings become the intersection of all the enums.

Here's where we are after #574:
Intersections types, i.e. allOf, are now resolved to more basic types.  To do that it was necessary to change how we process unions from JSON Schema as well, since unions and intersections can be nested.  The way we do this is that we have two passes, one for flattening unions, the other for resolving intersections, which run alternating, until there is nothing left to do.
There is at least one problem left to fix.  Consider this type:
AllOf(
    {"foo": string},
    Union(
        {"bar": string},
        Map<string>
    )
)

Flattening the union results in Map<string>, i.e., we lose any information on the bar property. Resolving the intersection then gives just {"foo": string}, but what we actually want is {"foo": string, "bar": string}.
I’ll have to combine the class and map types into one, like JSON Schema does, where one can specify individual properties, and then a type for additional properties.  That combined type will live until all the unions and intersections are done, then it'll be change into either a pure class or map type, so the renderers won't be affected.
We might at some later point want to support that kind of type in the renderers, too.

Implemented in #696


Drop old version from dockerhub on release

Do we actually want to do this? Keeping the earlier versions around shouldn't be a huge issue and if we get people who feel like they are "stuck" on an earlier version because of backwards-incompatible changes, this gives them an escape valve and we can figure out how we're going to handle that.

if we get people who feel like they are "stuck" on an earlier version because of backwards-incompatible changes

I don't think this will happen for some time, but I'm sure it will eventually.
This is minor, but the reasoning behind this task is that we drop old doc versions so if they are on an old version they have no documentation for it. I think the dockerhub and docs versions should match for now until we revisit a different version support range / lts / etc which seems out of scope for now.

I was imagining the opposite. There's no real reason why we can't bake the docs into the dashboard when being used locally, so anyone using locally would have the correct docs and anyone using the SaaS would have the correct docs, and they don't have to be kept in lockstep with a convoluted deploy or LTS process.

hmm that is a larger architectural change, but possible and could make sense. the friction point there is exposing static doc pages and keeping them optimized for SEO as docusaurus does versus the dynamic nature of the dashboard, but perhaps we can duplicate it. not sure

Depending on how we intend to duplicate it, it could be something more baked into dashboard itself, like a side panel that slides out and shows you the docs, covering part of the UI but leaving the editor visible, so you can read the reference while working on the SQL at the same time.


Fix stt docs for running in docker mode

Thank you for contributing to the sauce-docs project!
A well described pull request helps maintainers quickly review and merge your change
Before submitting your PR, please check our contributing
guidelines, applied for this repository. Avoid large PRs, help reviewers by making them as simple
and short as possible.

Description

Fix incorrect docs about running test in docker mode. It's not necessary to add a docker image in config file. saucectl will fetch a docker image thru test-composer. If the customer need to run some test on specific docker image, that can be set in the config file.
Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation fix (typos, incorrect content, missing content, etc.)

Checklist

[x] I have read the contributing document.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Hi @sweeneyskirt-sl , this PR is fixing docker image part. It's not related to any CLI flag. Since you're going to rewrite this part. I've closed this PR.


Unable to build images that are not based on Fedora 39

Hey folks!
I have attempted to build some images using this tool for the Universal Blue team and we are unable to build images that are not based on Fedora 39.
The 2 images I have tried:
ghcr.io/ublue-os/bluefin:gts (Based on Fedora 38)
ghcr.io/ublue-os/ucore:latest (Based on Fedora CoreOS 37)
I was talking with @achilleas-k and it might be related to using the Fedora 39 tools for building the images and them not being backwards compatible to build older versions of Fedora.
Happy to help test where I can!
Thanks,
Noel

This will also be fixed by https://github.com/osbuild/bootc-image-builder/issues/18

This is basically #20, let's close this one to deduplicate a bit. We are working on it. :)


WIP: holonix release handling

PR summary
Review checklist

[ ] The story has unit or integration tests
[ ] No new bugs, and any tech-debt is identified and justified
[ ] There is enough API documentation (how to use)
[ ] There is enough code documentation (how the code works)

@thedavidmeister What is status of this WIP?

@struktured i think we can close it, i was hoping to see some speedups but i don't think the things that i needed were cached


weasyprint/README.md is out of date

make test.weasyprint currently returns an error
make: *** No rule to make target 'test.weasyprint'.  Stop.
Indeed, there is no test.weasyprint in the current Makefile.
There is an old reference at https://github.com/kotify/cloud-print-utils/commit/e4bdd9552e8988278c55f957a664e5b97c0d1578
Seems like the README needs to be updated to incorporate the tests that replaced this, like test.start.container and test.print.report.
Also, it would be helpful to list dependencies in the getting started documentation. Docker is obvious enough, but not everyone has unzip, zip, jq, etc. - and it's not fun tripping over these while trying to figure out these undocumented tests.
Once these are installed, make test.start.container does start a container, but leaves the user hanging in terms of testing.  I can also run the 2nd test which is able to generate a document using the first test's container.
$ sudo docker ps
CONTAINER ID   IMAGE                               COMMAND                  CREATED          STATUS          PORTS                                       NAMES
4c0487f47ec7   public.ecr.aws/lambda/python:3.12   "/lambda-entrypoint.…"   13 minutes ago   Up 13 minutes   <IP_ADDRESS>:9000->8080/tcp, :::9000->8080/tcp   keen_villani
$ make test.print.report
which jq
/usr/sbin/jq
curl --fail -s -S -XPOST "http://localhost:9000/2015-03-31/functions/function/invocations" \
        -d '{"return": "base64", "filename": "report.pdf", "url": "https://kotify.github.io/cloud-print-utils/samples/report/"}' \
        | tail -1 | jq .body | tr -d '"' | base64 -d > report.pdf
Check ./report.pdf, eg.: xdg-open report.pdf

So, clearly the tests work, just need to update the README to indicate these steps for native testing, especially since the root README says "for details and docker lambda example see related readme.", so I'm expecting to find the details to build the image on this document and prepare to upload to ECR. It could also be nice for the first test to print a message to std out letting the user know what to do next.

Seems like you've done a great job investigating all the problems. If you can transform your suggestions into a PR, I'll gladly accept it.

Sure thing.
I tried to match the existing formatting, language, and kept the instructions brief. I'm looking forward to your feedback.

Thank you!


simple language switch

Here is my very simple solution for a language switch.
The language is stored in a separate key in localStorage. I didn't want the language in the state object.
Maybe there are better ways to pass the language (state) to the cards. I only have basic React knowledge, and the state handling in React is a big black box for me at the moment.
Fell free to change it if necessary.

The dropdown for language selection is not visible during a game
All languages from turingmachine.info are implemented, with the flaw that Español isn't working there. I have no idea how to fall back to English in this case.
There are more languages available than visible in the UI.
https://turingmachine.info/images/criteriacards/

Is this currently working?
I have tried the URL https://alexander-zibert.github.io/turing-machine-board-game-solver/ and do not see this new option.

The pull request has not yet been merged. This is a upcoming feature that is not yet available online. Please be patient.

I thought it should be already working
No problem, no hurry. Thank you very much.

I've slightly updated the state handling for the language based on this article:
https://thomasderleth.de/keeping-react-state-and-local-storage-in-sync/

Please do not merge for the moment, I'll make some significant changes this evening.

Just a preview, the language switch will be beside the icons later, and you will be able to switch the language anytime during playing.

That's the final solution, just decided to use an other source for the flag icons. On the first one the flags have all slightly different sizes and they just doesn't look good in the menu and I thought round icons will be more pleasing.

![revamped_lang_switch]On the first one the flags have all slightly different sizes and they just don't look good in the menu and I thought round icons will be more pleasing.

Beautiful!! ❤

I don't know why, in Firefox the text is misaligned.
Here is in Edge:
And here is in Firefox:

And here is in Edge/chrome:

@cpasoft
That's the pain with web development. Different browsers -> different rendering engines -> different results and to make it worse there could be differences on different OSes like Windows, MacOS and Linux.
I can't reproduce it in my environment, therefore I need your help.
I think the problem is the scrollbar.
Please, open up src/components/LanguageSelect.tsx goto line 148 and change min-width  to 160px.

If the text is still wrapped, increase the value for min-width.

I can't reproduce it in my environment, therefore I need your help. I think the problem is the scrollbar. Please, open up src/components/LanguageSelect.tsx goto line 148 and change min-width to 160px. Let me know the result.

Modified and works fine in both Firefox and Edge on Windows 10 and 11.

@frudolph77 This looks really good! Thank you!

@frudolph77 This looks really good! Thank you!

Yes, it does.
I have tested your deployment and it fits perfectly, tested on Firefox, edge and chrome, and also on Android.
GREAT!!! :-)


Page single select and page mutli select support for grouping options

This enhanced the single select and multi select to support grouping options.

This works great with my recent Activity Stream work 👍 . Styled components won't work properly unless you pass along the className prop to the custom Scrollable component that you have. See screenshot of the select overflow:

My code suggestions should hook this up properly.


Zetta alive?

Hi,
is this project still alive?
Thank you.

Yes. There's work by me and others to improve Zetta. Ill have a new release out soon that will work with the latest versions of Node.js.

Closing this unless you have any other specific questions. Thank you for your interest.


Linux support

Hi, is there a way to make this work on linux based distro like Ubuntu?

No. This is a native macOS app and there currently isn't anything like Wine to run macOS apps on other OSes.
However, there's a cross-platform Flutter app inspired by mine and it does support Linux.

Thank you for your response.
I will check it out
On Mon, 28 Aug 2023, 6:28 pm Gregory K, @.***> wrote:

Closed #67 https://github.com/grishka/NearDrop/issues/67 as not planned.
—
Reply to this email directly, view it on GitHub
https://github.com/grishka/NearDrop/issues/67#event-10211764662, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKBGJOACH3SU66VQORGBDFTXXTIKPANCNFSM6AAAAAA4BXMGHU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you. I'll check it out


Added SignIn and SignUp Components.

Issue Number
ISSUE #13

Describe the changes you've made
Made Sign Up and Sign In Components.
Both components are responsive.
Added validation in both components.
Describe if there is any unusual behavior of your code(Write NA if there isn't)
NA
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.
[x] Participating in SWOC2021.
[x] Participating in DWOC.

You can see my work at the below link,
https://sanjay270899.github.io/Realate/

You can see my work at the below link,
https://sanjay270899.github.io/Realate/

@07souravkunda Please review it, and let me know if any changes needed.

@07souravkunda Please review it, and let me know if any changes needed.

You can place utils folder on app.js level

You can place utils folder on app.js level

You can place utils folder on app.js level

Oh Yes! I didn't notice that. Changing that quickly.

You can place utils folder on app.js level

Oh Yes! I didn't notice that. Changing that quickly.


The Problem with Distributed inference on multi-GPUs with tf.distribute.MirroredStrategy() strategy

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock
example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g.,
Linux Ubuntu 16.04): Linux Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if
the issue happens on mobile device:
TensorFlow installed from (source or
binary): binary (install from pip)
TensorFlow version (use command below): 2.1.0
Python version: 3.6.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from
source):
CUDA/cuDNN version: Cuda Toolkit 10.1 / cuDNN 7.6.4
GPU model and memory: 2 Titan V

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
I have tried to custom distributed inference on multi-GPUs (i.e 2 GPUs) follow the tutorial on page https://www.tensorflow.org/tutorials/distribute/save_and_load by using my model and tf.distribute.MirroredStrategy() strategy. In particular when I ran my bellow code
# Here is my code

DEFAULT_FUNCTION_KEY = "serving_default"
data = tf.data.Dataset.from_tensor_slices(np.random.rand(32*100, 416, 416, 3).astype('float32')).batch(32)

# load model and do inference on 1 GPU
loaded = tf.saved_model.load('./model')
inference_func = loaded.signatures[DEFAULT_FUNCTION_KEY]

total_time = 0.0
for batch in data:
    begin = time.time()
    inference_func(batch)
    total_time += time.time() - begin
print('Total time on 1 GPU: ', total_time)

# load model and do inference in a distributed manner
mirrored_strategy = tf.distribute.MirroredStrategy()
with mirrored_strategy.scope():
    model = tf.saved_model.load('./model')
    inference_func = model.signatures[DEFAULT_FUNCTION_KEY]

    dist_predict_dataset = mirrored_strategy.experimental_distribute_dataset(data)

    total_time = 0.0
    for batch in dist_predict_dataset:
        begin = time.time()
        mirrored_strategy.run(inference_func, args=(batch,))
        total_time += time.time() - begin
    print('Total time on 2 GPUs: ', total_time)

*Note: The above code is customed from your bellow sample code in the tutorial
# Here is your sample code in the tutorial

DEFAULT_FUNCTION_KEY = "serving_default"
loaded = tf.saved_model.load(saved_model_path)
inference_func = loaded.signatures[DEFAULT_FUNCTION_KEY]

predict_dataset = eval_dataset.map(lambda image, label: image)
for batch in predict_dataset.take(1):
  print(inference_func(batch))

another_strategy = tf.distribute.MirroredStrategy()
with another_strategy.scope():
  loaded = tf.saved_model.load(saved_model_path)
  inference_func = loaded.signatures[DEFAULT_FUNCTION_KEY]

  dist_predict_dataset = another_strategy.experimental_distribute_dataset(
      predict_dataset)

  # Calling the function in a distributed manner
  for batch in dist_predict_dataset:
    another_strategy.run(inference_func,args=(batch,))

and compared the total inference time of the model between 1 GPU and 2 GPUs with the same inputs. Unfortunately, I realized that the performance on 2 GPUs is not faster than on 1 GPU (about total time as well as the time of an iterator). It seems that the inference process executed on 2 GPUs sequentially (not parallel as I expected).
Describe the expected behavior
Please let me know if there are any problems here and show me how to modify the code in order to run distributed inference on multi-GPUs parallel with the best performance. Thanks so much for your help
Standalone code to reproduce the issue
Files to reproduce the test case in example.zip
Other info / logs

@ymodak  I've read your code at https://github.com/tensorflow/tensorflow/blob/e5bf8de410005de06a7ff5393fafdf832ef1d4ad/tensorflow/python/distribute/mirrored_strategy.py#L92 and see run_concurrently = False (It means threads is running sequentially)

It is true that the inference_func is running on each GPU sequentially in eager mode, and you should be able to see a warning like this.
To get things running in parallel, you can put the strategy.run() method inside a tf.function, so that graph building is sequential, but execution is parallel. See this tutorial for an example.

@ckkuang I tried following your tutorial and came to the following rough recipe:
# https://github.com/tensorflow/tensorflow/issues/37686
# https://www.tensorflow.org/tutorials/distribute/custom_training
def compute_and_write_ious_multi_gpu(path: str, filename_csv: str, include_sampled: bool):
    strategy = tf.distribute.MirroredStrategy()
    util.log('Number of devices: {}'.format(strategy.num_replicas_in_sync))
    (ds, s, n) = dataset(path, shuffle=False, repeat=False, mask_as_input=True)
    dist_ds = strategy.experimental_distribute_dataset(ds)

    def predict_step(inputs):
        images, labels = inputs
        return model(images, training=False)

    @tf.function
    def distributed_predict_step(dataset_inputs):
        per_replica_losses = strategy.run(predict_step, args=(dataset_inputs,))
        return per_replica_losses  # unwrap!?

    # https://stackoverflow.com/questions/57549448/how-to-convert-perreplica-to-tensor
    def unwrap(per_replica):  # -> list of numpy arrays
        if strategy.num_replicas_in_sync > 1:
            out = per_replica.values
        else:
            out = (per_replica,)
        return list(map(lambda x: x.numpy(), out))

    with strategy.scope():
        model = wrap_model()

    util.log(f'Starting distributed prediction for {filename_csv}')
    ious = [unwrap(distributed_predict_step(x)) for x in dist_ds]
    t = ious
    ious = [item for sublist in t for item in
            sublist]  # https://stackoverflow.com/questions/952914/how-to-make-a-flat-list-out-of-list-of-lists
    util.log(f'Distributed prediction done for {filename_csv}')
    ious = np.concatenate(ious).ravel().tolist()
    ious = round_ious(ious)
    ious = list(zip(ious, ds.all_image_paths))
    ious.sort()
    write_ious(ious, filename_csv, include_sampled)

This does distribute the load across the GPUs, but unfortunately makes very poor use of them - in my particular case the corresponding single-GPU code runs in ~12 hours, and this runs in 7.7 hours, so not even a 2x speedup despite have 8x the number of GPUs.
nvidia-smi confirms that multi-GPU load bobs between 0 and 100%, whereas single-GPU load is almost pegged at 100%.
I think it's mostly a data feeding issue due to the code structure. Any suggestions for how to speed it up?
The underlying dataset is created in the same way for both scenarios, and also for training where it's able to peg 8 GPUs at 100%, so it shouldn't be the dataset creation itself.
(Ubuntu 16.04, tf 2.3.1, tf.keras 2.4.0, python 3.7.6, AWS p4d.24xlarge running on AWS Deep Learning AMI (Ubuntu 16.04) v38.0)


loading a slave node per connection

with a single node and multiple connections we are observing slave node getting into a unresponsive state and erlang distribution disconnecting the node. With a single connection on a slave node this behavior is not observed.
Fixes #42

Closing in favor of #47


Add configuration to prevent host updating via zabbix api

Description of PR
This PR adds a new configuration option zabbix_update_host to control if the host should be updated when it already exists in zabbix server. The default value is yes (current behaviour). If you set it to no, the host will not be updated in your zabbix server if it already exist.
Type of change
Feature Pull Request

Thanks! 👍


Remove CHANGELOG.md

Because someone's gotta do it.
This PR deprecates CHANGELOG.md as the place for tracking changes from release to release in favor of pull request titles.
Removals

CHANGELOG.md.

Changes

Pull request template now reminds people to give their PRs informative and human-readable titles.

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Assignee tool :arrow_right:

:ship: it

👍  💯  :1st_place_medal: 🔢

Ohhhh, oh, oh, oh, ohhh.
It must have been cold there in my shadow,
To never have sunlight on your face.
You were content to let me shine, that's your way.
You always walked a step behind.
So I was the one with all the glory,
While you were the one with all the strength.
A beautiful face without a name for so long.
A beautiful smile to hide the pain.
Did you ever know that you're my hero,
And everything I would like to be?
I can fly higher than an eagle,
For you are the wind beneath my wings.
It might have appeared to go unnoticed,
But I've got it all here in my heart.
I want you to know I know the truth, of course I know it.
I would be nothing without you.
Did you ever know that you're my hero?
You're everything I wish I could be.
I could fly higher than an eagle,
For you are the wind beneath my wings.
Did I ever tell you you're my hero?
You're everything, everything I wish I could be.
Oh, and I, I could fly higher than an eagle,
For you are the wind beneath my wings,
'cause you are the wind beneath my wings.
Oh, the wind beneath my wings.

Fly, fly, fly away. You let me fly so high.

Fly, fly, fly high against the sky,
So high I almost touch the sky.
Thank you, thank you,
Thank God for you, the wind beneath my wings.

:-1:
Pull request titles don't tell you when something was released, so this change will make it harder to figure out what is/isn't released (or when something was released) until we get to a more CD state.

@Scotchester would using the script in this PR satisfy those concerns, as long as release notes contain the list of changes contained within them? I believe @willbarton created the last few release notes this way.

@chosak Yes, if that script is run, has useful PR titles to draw from, and is consistently posted to the GitHub release notes, that's good enough. For extra credit, you could put the list in the Git tag's annotations, which would ensure we're not dependent on GitHub to have access to that info in the future. I'm fairly sure that a tag annotation will show up in the GitHub release description when the tag is pushed.
I might also suggest that the existing CHANGELOG file be retained in the repo (possibly renamed) with a note that all future changes are noted in the tag/release.

I might also suggest that the existing CHANGELOG file be retained in the repo (possibly renamed) with a note that all future changes are noted in the tag/release.

It's in the git history.
Murder it.

@Scotchester I like the annotated tag idea. How would you and @willbarton feel about archiving a copy of the CHANGELOG in the docs folder? Leaving it around in the main repo root directory seems prone to confusion.

@chosak I'd prefer that over straight deletion, but I think simply renaming to something like CHANGELOG_archive.md would be more obvious to people who default to looking for the standard CHANGELOG.md.

@Scotchester How would that help though? I'd be open to having a CHANGELOG.md that simply explained where to find the latest changes, and perhaps included the URL of the last commit before this one for historical changes. Wouldn't that suit someone who defaults to looking for a file named something like CHANGELOG better? Why do we need to preserve the full contents for posterity in the tree when it will be in the git history?

OK, if you include a link to the last commit that had the change log content, so someone can easily get back to it, I'm cool with that. Leaving it named CHANGELOG.md is even better.
My main concern was with deleting the file entirely with no guidance on how to get back to that information. Then, to find it in the history, one has to (a) know that the file used to exist, and (b) have to dig back through however many commits have occurred since to find the last version of it.
I fully support your latest proposal, @willbarton.

@Scotchester how do you feel about something like this as the new placeholder CHANGELOG.md? Note that I've had to hardcode a version there so we'll have to keep updating that if we keep this PR open for a long time.

Also, at your suggestion I looked into annotated tags. It seems like we can choose to use either GitHub releases or git annotated tags.
If we use GitHub releases, then (as now), you won't be able to see the full release description from the command line, only the first few lines:
$ git tag -n99 -l 4.6.7
4.6.7           Merge pull request #2724 from cfpb/build-fix

    Fix npm dependencies and shrinkwrap for production deploys

If we use annotated git tags, then from the command line we can do something like
$ git tag -a 100.0.2 # opens editor where multi-line annotation can be entered
$ git push origin 100.0.2

The full content can then be viewed on the repo tags page:

Note the "Add release notes" prompt. If you enter release notes, then they get added as additional content and can be viewed on the releases page, while the tag content can still be viewed on the tags page.
Based on this, I'd be open to using annotated git tags over GitHub releases going forward. The ability to view tag descriptions from command line is nice, and it'd likely be easier to integrate with an automated tag-and-deploy process (no need to use the GH API).

Looking good, Andy. I'll make a few trivial style suggestions on the CHANGELOG.md file in a sec.
On annotations: If you click that "Add release notes" link, does it do what I hope and prepopulate the release notes field with the content of the tag annotation?

@Scotchester thanks for the feedback.
Regarding release notes, unfortunately, no, these do not prepopulate from tag annotations.
I've addressed your comments in 6515cb6. If you think these look good, I'll merge this PR.

:shipit:
Also, if we're going to be building the notes from PR titles, you'll want to update the title of this PR to reflect what it actually changes now :)


Move window when flyout is open

When a flyout was open you weren't able to move the window where the flyout was over the title bar. This was particularly anoying if you wished to move the window while a flyout was opened as a modal flyout or covered the entire area of the window.
I've implemented a change that enables the window to be moved when a flyout is opened and the mouse cursor is within the windows title bar area.
If the default behaviour was intended by design perhaps this feature could be optional with a property.
I hope this is ok.

@hercmaroudas looks good, i'll be add this to 1.2.0

Thanks @punker76 :+1:

Looks ok, though I don't like that Flyout accesses MetroWindow directly, but I have no better idea.
However, I would suggest some changes to your Flyout.xaml: In your PR you move the flyout's content down by the height of the titlebar. I'd prefer to keep the content where it is but overlay it with the PART_WindowTitle. So I'd remove the RowDefinitions again, add the Rectangle after the AdornerDecorator, and set its VerticalAlignment to Top:
    <AdornerDecorator>
        <!-- -->
    </AdornerDecorator>
    <Rectangle x:Name="PART_WindowTitle"
               Height="{Binding TitlebarHeight, Mode=OneWay, RelativeSource={RelativeSource FindAncestor, AncestorLevel=1, AncestorType={x:Type Controls:MetroWindow}}}"
               HorizontalAlignment="Stretch" VerticalAlignment="Top"
               StrokeThickness="0"
               Fill="Transparent"/>


POSIX shell scripts improvements (Backport 6.x)

See #17716 as the starting point
If 6.9.2 happens, part of the work will be collecting all relevant change sets on this topic to be backported.

Done through #19364


How is memory token initialized/trained? Will the training code be available?

Thanks for the great work! I'm wondering how is the memory token initialized?
Concretely, for the x_1^{m}, x_2^{m},...x_k^{m} below, how is it initialized? Also, are x_1^{m}, x_2^{m},...x_k^{m} trainable parameters?  For different contexts, do you need to retrain to get different x_1^{m}, x_2^{m},...x_k^{m} or are different contexts share the same memory tokens?

Lastly, will the training script be available? Thanks.

Thank you for your question. We will be releasing the training code soon. In the meantime, for details on memory token initialization, please refer to the .py scripts in the model directory.

are x_1^{m}, x_2^{m},...x_k^{m} trainable parameters?

Just want to get some quick answer here:

Are memory tokens trainable?
For different contexts, do you need to retrain to get different x_1^{m}, x_2^{m},...x_k^{m} or are different contexts share the same memory tokens?
Thanks!

yes, the memory tokens are trainable
the memory tokens x_1^{m}, x_2^{m},...x_k^{m} are summarized from recent normal tokens, so they are context-dependent.


Test the Cupcake app: Android Basics in Compose

Issue 1
The third snippet is kinda misleading
@Test
fun cupcakeNavHost_verifyStartDestination() {assertEquals(Cupcake.Start.name, currentBackStackEntry?.destination?.route)
}

Cupcake.Start.name should be CupcakeScreen.Start.name. Additionally currentBackStackEntry cannot be resolved - it should read navController.currentBackStackEntry?.destination?.route.
To sum it up:
@Test
fun cupcakeNavHost_verifyStartDestination() {
    assertEquals(CupcakeScreen.Start.name, navController.currentBackStackEntry?.destination?.route)
}

Issue 2
Following the Verify navigation to the Flavor screen section the code snippet reads
@Test
fun cupcakeNavHost_clickOneCupcake_navigatesToSelectFlavorScreen() {
   composeTestRule.onNodeWithStringId(R.string.one_cupcake)
       .performClick()
}

However there is no #onNodeWithStringId in androidx.compose.ui.test - see docs
By looking at the solution it becomes clear that this is an extension method that was added however it is not mentioned on the Codelab.

Oh, i see you got ahead of me reporting this one and that be cool

Hi @mikef-dk @kofi-k
Thank you for reporting these issues.
The corrections have been made and the updated lesson republished.
Hope you are enjoying the course!
Regards.


fix more typos in partner workflows

it was my fault for assuming these were already in working order. gce_image_publish is strict about json, so final elements must not end in a comma.

/cc bkatyl


Post process: Add support for uniform buffers

See https://forum.babylonjs.com/t/how-to-use-glsl-uniform-struct-with-webgpu/46071

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.


Rename ReleaseGold to CeloReleaser

Consider whether this is still necessary, if it causes any problems (with scripting, etc.)


React Native latest version (current 0.56) support

Hi guys,
I have just a quick question about the plan to support latest RN version (current is 0.56).
I can see in the Readme file. there is the limit in the React Native version for Detox support. I am wondering why the support for both iOS and Android is not the same? So to develop and test for both platforms should the project stay under 0.51?
And I am asking for the future plan of updating the project to React Native 0.56 for Firebase issue with the versioning. And when it goes up, it would lose the support from Detox.
Thanks for your support. Best wishes.

@heuism Detox works on RN 0.56 on iOS. No clue about Android though...

@todorone what'd you do to make it work?
I'm getting an error related to babel (after I upgraded babel-preset-react-native to : v5,:
TypeError: Cannot read property 'throwIfClosureRequired' of undefined (While processing preset: "../node_modules/babel-preset-react-native/index.js")
  at _default (../node_modules/babel-preset-react-native/node_modules/@babel/plugin-transform-block-scoping/lib/index.js:19:36)
  at Function.memoisePluginContainer (../node_modules/babel-core/lib/transformation/file/options/option-manager.js:113:13)
  at Function.normalisePlugin (../node_modules/babel-core/lib/transformation/file/options/option-manager.js:146:32)
  at ../node_modules/babel-core/lib/transformation/file/options/option-manager.js:184:30
      at Array.map (<anonymous>)
  at Function.normalisePlugins (../node_modules/babel-core/lib/transformation/file/options/option-manager.js:158:20)
  at OptionManager.mergeOptions (../node_modules/babel-core/lib/transformation/file/options/option-manager.js:234:36)
  at ../node_modules/babel-core/lib/transformation/file/options/option-manager.js:265:14
  at ../node_modules/babel-core/lib/transformation/file/options/option-manager.js:323:22
      at Array.map (<anonymous>)

one user reported that they have detox working on android with RN 0.55.4 https://github.com/wix/detox/pull/773#issuecomment-404250381

https://stackoverflow.com/questions/51305555/could-not-find-method-missingdimensionstrategy-for-arguments-minreactnative

Internally, Wix uses 0.51 currently. So we have to support that as the baseline. Is there something in particular that is not supported with 0.56? iOS or Android? Or is it just the docs not updated to state that it is supported?

Ah, I see Android is trailing behind.
@rotemmiz @noomorph Isn't it time to start looking into supporting modern RN? Wix will soon be looking to upgrade the RN and Detox shouldn't be the one to bottleneck them.

Hi guys,
I've trying to get detox to work with RN 0.56 with android in Linux, with no luck.
detox test fails with RN 0.56 in Linux with this message:

Plugin 0 specified in "/.../node_modules/babel-preset-react-native/index.js" provided an invalid property of "default" (While processing preset: "/.../node_modules/babel-preset-react-native/index.js")

You can check this issue that I think is related.
Here's a fork of the solution proposed in that issue, but with detox already configured.
yarn test works but detox test throws the Plugin 0 specified in... message.
Is this setup supposed to work?

I'm experiencing the same issue as @merunga on RN 0.56 with iOS simulator and babel-jest on macOS. My detox builds succeed but I am unable to run tests.
After reading through these two related issues:
https://github.com/facebook/react-native/issues/19859
https://github.com/facebook/react-native/issues/18962
I think the reason for the issue is that react native 0.56 requires Babel 7 (meaning it also requires babel-preset-react-native of version 5.0.1 or later), but detox still uses Babel 6 (and therefore babel-preset-react-native v4.0.0). I've tried using peer dependencies but those were also unsuccessful.

@avigoldstein I'm running my unit test with jest, but ended up using mocha to run e2e tests with detox.

@merunga thanks for the report and the fork. I cannot promise I'll look really soon, there's another important thing on the agenda (https://github.com/wix/detox/issues/831). As soon as I release a fix for it, I'll try to look at it.

@avigoldstein Running Detox on iOS with jest and RN 0.56.0 works for me after :
Adding "^.+\\.js$": "<rootDir>/node_modules/react-native/jest/preprocessor.js" in the jest config file for running detox.
And making sure that the project "react-test-render" version is the same as the one used by react-native  ( for RN 0.56.0 -> 16.4.1).

@avigoldstein thanks for your hint!
@noomorph I managed to get detox with jest running using this e2e/config.json file:
{
  "rootDir": "../",
  "setupTestFrameworkScriptFile": "./e2e/init.js",
  "preset": "react-native",
  "transform": {
    "^.+\\.js$": "<rootDir>/node_modules/react-native/jest/preprocessor.js"
  }
}

and this conf in package.json
{
  ...
  "detox": {
    "test-runner": "jest",
    "runner-config": "e2e/config.json",
    "configurations": {
      "android.emu.debug": {
       ...
      }
    }
  }
  ...
}

It's updated in the fork.

@lapto @merunga Thanks you, it works with yours solutions !
The problem is fixed for me with all this configuration :
react-native init project
cd project
npm install detox --save-dev
detox init -r jest

And follow the next changes in :
in package.json
"jest": {
    "preset": "react-native",
    "^.+\\.js$": "<rootDir>/node_modules/react-native/jest/preprocessor.js"
  },

and
"detox": {
    "test-runner": "jest",
    "runner-config": "e2e/config.json",
    "configurations": {
      "ios.sim.debug": ...
    }
  }

in e2e/config.json
{
    "rootDir": "../",
    "setupTestFrameworkScriptFile": "./e2e/init.js",
    "preset": "react-native",
    "transform": {
      "^.+\\.js$": "<rootDir>/node_modules/react-native/jest/preprocessor.js"
    }
}

Don't forget to add you own simulator with the official doc.
I hope it will help some of you 🛠😇
I will follow the fork.

With RN 0.56 on Android it is stuck at the empty screen before RN renders anything. Seems like there some infinite loop going on because I can't even properly kill it (it seems to stay running, unkillable)

Hi, I am not able to run the test on iOS, with RN 56 and jest, it hangs and gets timed out every time, below is the configuration I am using -
In pacjage.json
"detox": {     "test-runner": "jest",     "runner-config": "e2e/config.json",     "specs": "e2e",     "configurations": {       "ios.sim.debug": {         "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/ExampleApp.app",         "build": "xcodebuild -workspace ios/ExampleApp.xcworkspace -scheme ExampleApp -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build",         "type": "ios.simulator",         "name": "iPhone 7"       }     }   }
and In config.json
{     "rootDir": "../",     "setupTestFrameworkScriptFile": "./e2e/init.js",     "testEnvironment": "node",     "preset": "react-native",     "transform": {         "^.+\\.js$": "<rootDir>/node_modules/react-native/jest/preprocessor.js"     } }
I am not able to find out the actual cause behind this, can someone please help ?
Thanks

@MJ0826 I am seeing something similar, can you provide logs with detox test --debug-synchronization 1000. This way we can look and see if we are having a similar issue. Mine is particular to when Detox runs with Jest, and an individual file such as Filename.spec.js has more than 1 describe or it block. Try running a test with just 1 describe that contains an it. Maybe we are seeing the same thing.

Please update the version of Detox to 9 to continue this discussion being relevant. The 9 officially supports RN 0.56 on Android, so the bug reports must be specific to the latest version. Thanks in advance.

Any news on 0.57.3 support?

@tannera Android or iOS? Are you seeing something specific which doesn't work?

@LeoNatan No, I just read the Docs that specify support up to <=0.56

Please test your project, and open a new issue if there is a problem.


Doesn't build with gutenberg-0.4.2

I'm getting a macro error when rendering with gutenberg serve:
$ gutenberg serve
Building site...
-> Creating 2 pages (0 orphan), 0 sections, and processing 0 images
Error: Failed to render pager 1
Reason: Failed to render 'index.html': error while rendering macro `post_macros::page_in_list`
Reason: Macro namespace `self` was not found in template `index.html`. Have you maybe forgotten to import it, or misspelled it?

Has something changed in this new release that would cause this, or have I done something wrong with the theme?

Gutenberg 0.4.2 has some issues with macros that are already fixed for the next version. For now use 0.4.1 or build the next branch of the repo manually.


Editing notes in raindrop causes duplicates

If I edit notes saved on a raindrop logseq ends up with an article with the old raindrop notes and a second one with the edits.

Duplicate of #52 (and a very reasonable request)


Upgrade hive

https://github.com/open-cluster-management/backlog/issues/8971
https://github.com/open-cluster-management/backlog/issues/9850

/lgtm

/lgtm


Bump HAL to get MonoTimer back

This struct was accidentially dropped and got re-added with the latest release. See https://github.com/stm32-rs/stm32f3xx-hal/pull/247 for details. The breaking changes in stm32f3xx-hal 0.8.0 require a small adaption at the examples.
I'm including a runner template for probe-run because I'm struggling with https://github.com/rust-lang/vscode-rust/issues/729 and did not manage to get around it with the default Rust extension (only with rust-analyzer).

Thanks for this. My apologies it took so long to respond.
I'll review the state of things this weekend to see if I can cut a release.
There's some work around board rev E in flight that I need to revisit to make sure we're good to go.


Created PROFILE.md add my first file

Created a new branch, submitting a pull request

Just merged this. yay


Change roman into a python package.

This PR refactor roman repo to be an python package compatible repo.

Rebasing the PR.


Handle integer conversion errors

When converting a double larger or equal to math.MaxInt64 to an integer, it previously overflowed silently. It now returns an explicit error.
This fixes along the way, the math.abs(-9223372036854775808) issue.

Codecov Report

Merging #425 (bd29ce8) into main (daf4f79) will decrease coverage by 0.09%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   68.88%   68.79%   -0.10%
==========================================
  Files          93       93
  Lines        9633     9648      +15
==========================================
+ Hits         6636     6637       +1
- Misses       2281     2289       +8
- Partials      716      722       +6

Impacted Files
Coverage Δ

document/cast.go
84.29% <22.22%> (-9.10%)
:arrow_down:

driver/driver.go
66.27% <0.00%> (-1.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf4f79...bd29ce8. Read the comment docs.


Dropdown v2

### Checklist
- [ ] Density (HD, MD, LD, TD)
- [ ] Mode (Light, Dark)
- [ ] Fill (Primary, Secondary, Tertiary)
- [ ] State (Default, Hover, Selected/Active, Disabled, Read-only, Other)
- [ ] Controlled API
- [ ] UITK accessibility parity (screen reader + keyboard interactions)

### Deliverables
- [ ] Characteristics spec
- [ ] Interactions spec, where necessary
- [ ] In Code & Figma (Component + Guide)
- [ ] Supporting site documentation

### Features
- [ ] Validation states replaced by #2357
- [ ] Custom Button Support (partnership feature requirement) replaced by #2358
- [ ] Form Field support replaced by #2359
- [ ] truncation support in List (v3) and Dropdown replaced by #2360
- [ ] add placeholder for Dropdown replaced by #2361
- [ ] customisable list height replaced by #2362

Replaced with per feature issues


..

What version of dep are you using (dep version)?

What dep command did you run?

What did you expect to see?
What did you see instead?

¯_(ツ)_/¯


Optimize string decoding (among other things)

Most string write functions (with the exception of hexWrite) were allocating arrays before copying them onto the buffer. This resulted in significant performance overhead.
This PR modifies said functions to write directly to the buffer. In addition, it drops the dependency on base64-js and adds support for the base64url encoding.
The numbers are as follows:
$ node perf/write-base64.js
OldBuffer.byteLength(8192, "base64") x 24,009 ops/sec ±0.55% (93 runs sampled)
NewBuffer.byteLength(8192, "base64") x 9,548,372 ops/sec ±0.18% (95 runs sampled)

OldBuffer#write(8192, "base64") x 19,789 ops/sec ±0.49% (95 runs sampled)
NewBuffer#write(8192, "base64") x 22,646 ops/sec ±0.04% (95 runs sampled)

OldBuffer#toString(8192, "base64") x 6,686 ops/sec ±0.39% (87 runs sampled)
NewBuffer#toString(8192, "base64") x 10,735 ops/sec ±0.35% (90 runs sampled)

$ node perf/write-binary.js
OldBuffer#write(8192, "binary") x 13,662 ops/sec ±1.37% (84 runs sampled)
NewBuffer#write(8192, "binary") x 46,397 ops/sec ±0.64% (91 runs sampled)

$ node perf/write-ucs2.js
OldBuffer#write(8192, "ucs2") x 3,537 ops/sec ±0.70% (86 runs sampled)
NewBuffer#write(8192, "ucs2") x 40,422 ops/sec ±1.14% (93 runs sampled)

$ node perf/write-utf8.js
OldBuffer.byteLength(2898, "utf8") x 15,304 ops/sec ±0.87% (85 runs sampled)
NewBuffer.byteLength(2898, "utf8") x 58,197 ops/sec ±0.05% (86 runs sampled)

OldBuffer#write(2898, "utf8") x 13,565 ops/sec ±0.82% (85 runs sampled)
NewBuffer#write(2898, "utf8") x 32,716 ops/sec ±0.25% (93 runs sampled)

There are some massive speedups here, particularly with asciiWrite, ucs2Write, and utf8Write.
I was disappointed to see base64 only has a marginal speedup, however, there is a significant speedup for base64Slice and byteLength('base64'). Likewise, byteLength('utf8') also received a significant speedup.

Added a new commit to further optimize base64Write. This logic is basically how the node.js c++ code works internally. It requires no string preprocessing (str.replace, str.split, str.indexOf, etc) which gives it an extra perf boost.
New Numbers:
OldBuffer#write(8192, "base64") x 19,789 ops/sec ±0.49% (95 runs sampled)
NewBuffer#write(8192, "base64") x 24,542 ops/sec ±0.02% (97 runs sampled)

@chjj can you break this into two pull requests?
The addition of all the new benchmarks (easy merge), and then an isolated pull request for the actual behavioural changes?

Done.

New base64 implementation using atob/btoa pushed.

After thinking about it, all of this atob/btoa inconsistency is really bugging me. I'm considering switching back to the custom base64 impl. Although harder to review, it provides consistent behavior that we know will work in everything and has predictable performance.

@dcousens, I think I will switch this PR back to my custom base64 implementation.
The more I think about it, the more I don't like atob/btoa for the following reasons:

It's hard to benchmark due to the node.js issue. The numbers may vary significantly in different browsers as well.
It screws up the tests if we want to shim in atob/btoa for node.js.
The node.js shim also causes issues because node.js has a history of breaking their base64 parser.
With regards to number 3, same could be true of atob in any javascript environment: we don't know whether that environment has some kind of bug/inconsistency with their base64 parser. We also don't know the performance properties of that environment's base64 decoder.
With atob, buf.write('base64') is basically guaranteed to be slower on a lot of base64url strings or a string with invalid characters because it has to run base64clean and retry parsing.
Using btoa is just straight up slower than our custom implementation in any environment (probably).
There are environments you could bundle for that do not have atob/btoa. An example of this is quickjs. If I want to write some javascript code and compile it to a binary that runs everywhere quickjs combined with cosmopolitan is the answer. By using atob/btoa, we break Buffer in that environment.
It goes against the whole spirit of this PR which is to write bytes directly to the buffer during decoding.

Number 7 is one I recently thought of. I really really like the idea of compiling bundles for quickjs (I'm thinking of adding a quickjs target to my bundler to convert the quickjs api to the node.js api, but that's a different story).
The benefits of a custom implementation are as follows:

Predictable performance.
Predictable behavior.
Faster toString.
Supports any javascript environment, including things like quickjs and the d8 shell.
Less fussing over all of the stuff above.

The downsides:

Slower buf.write(str, 'base64') in environments like chrome (but again, chrome would only be significantly faster if the string is well-formed enough such that atob can parse it).
Larger code size, harder to review.

I understand your plight for each of the points, but I don't know if this library should be a reference for this kind of functionality.
This library should be using whatever underlying native functions exist, as that is what users expect.
The primary reason this library exists is to support cross-compatibility of the high-level API's, not to be an improved implementation of their shared functionality.

With atob, buf.write('base64') is basically guaranteed to be slower on a lot of base64url strings or a string with invalid characters because it has to run base64clean and retry parsing.

I don't understand this, we should know that the input string is base64url no?
This pull request is difficult to quickly review in the limited time I have, when you have touched and moved the utf8Write and hexWrite and ucs2Write code... can we reduce that diff?

This library should be using whatever underlying native functions exist, as that is what users expect.

Fair enough.

I don't understand this, we should know that the input string is base64url no?

We can use that as a hint, but the Buffer.from('base64') in node has supported the base64url character set for a long time. It's not always guaranteed that a user would pass in base64 versus base64url.

This pull request is difficult to quickly review in the limited time I have, when you have touched and moved the utf8Write and hexWrite and ucs2Write and... can we reduce that diff?

Yeah, I know I've been bugging you a lot lately. Sorry about that. Thank you for your attentiveness this past week.
I find it's best to look at the diff of each individual commit, but I see your point. I'll try to get it looking better.


[EXTENSIONS] Make getActions return type generic

getActions extension point should have a generic return type.
Currently getActions have a return type of Map<String, Class<? extends TransportAction<ActionRequest, ActionResponse>>> which is not generic for ActionRequest and ActionResponse.
The return type should be Map<String, Class<? extends TransportAction<? extends ActionRequest, ? extends ActionResponse>>>
Problem :
The return type which we have currently does not allow us to pass classes for specific purpose use case.
Solution:
If we change the return type to  Map<String, Class<? extends TransportAction<? extends ActionRequest, ? extends ActionResponse>>>  Then any class which extends ActionRequest and ActionResponse can be passed as parameters.

PR merged


Adding Realdolmen to the adopters file

Codecov Report

Merging #2556 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2556      +/-   ##
==========================================
- Coverage   33.20%   33.12%   -0.08%
==========================================
  Files         160      160
  Lines        8879     8879
  Branches      185      185
==========================================
- Hits         2948     2941       -7
- Misses       5433     5438       +5
- Partials      498      500       +2

Flag
Coverage Δ

#moduleA
23.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

api/ws/hub.go
60.78% <0.00%> (-13.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861b72d...6cfba3d. Read the comment docs.


Adding tests for standardizing output

@mahmudhera when you get around to it, can you address the QualityGate issues?


Move snake_case outside of ends_with

Defining the snake_case function should not happen within the check if ends_with exists
As discussed in #54

Thanks!


[bugfix] [Zeta] Fix the problem of class loader not releasing when using REST API to submit jobs

Purpose of this pull request

close #4915
Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

#6481 i also meet an issue when use rest api submit job. i check this pr's code, looks this can also solve my issue. Will test it and update.


No license for this project

Without a license, this code is all rights reserved [0].
I recommend BSD/MIT or Apache 2.0. For example gdash is under Apache 2.0 [1].
[0] http://stackoverflow.com/a/13669816/1429452
[1] https://github.com/ripienaar/gdash/blob/master/COPYING

@PrFalken - good to know, and thank you.
This is still a good project because it's simple and easy to modify to your needs 👍


Work with not trusted HTTPS certificates

Good afternoon
Small observations regarding the application.
I use my own server for NTFY. I have no opportunity and desire to make the application public. I prefer even to use HTTPS on the local network.
As part of its network, all services I issue domains and certificates.
In such a scenario there are some difficulties, Android security policy on my phone does not allow working with impervious CA. Your application is no exception.
This problem can be bypass using the corresponding Magisk module. After adding your own CA in the certificate store. But this method is possible only on root devices.
https://github.com/NVISOsecurity/MagiskTrustUserCerts
For example, in the DAVX5-OSE application, this problem is solved elegant. When the connection is first, the application gives a dialog box that allows you to trust / do not trust this HTTPS certificate.
https://github.com/bitfireAT/davx5-ose
Dear developers, I propose to write about it in Wiki or within the application, implement a mechanism for permission to work with not trusted certificates.
P.S. Let's leave it here who can come in handy)

Preferably, you should be able to provide a custom CA and/or certificate to the application itself,  preventing it accepting anything else.

This would be a great feature! At the very least something like curl -k to skip the verification step.

So, I am a little bit torn on this one. With Let's Encrypt certs being freely available and the DNS challenge making it possible to issue certs for internal servers, why would I go through the trouble of supporting custom certs. Because if I do that, I have to support ways to manage these certs to (create/update/delete), which is a whole new set of UIs.
Right now I don't see any reason to implement this, because it can be solved differently. I'll leave it open for comment.

I think for starters you just need to add a checkmark "Use untrusted certificates". That is, let the program not check the authenticity of the certificate.

Android security policy on my phone does not allow working with impervious CA. Your application is no exception.

@MuratovAS  Are you sure about that? What do you mean by "impervius CA"? Which Android version?

@MuratovAS I was so confused why I couldn't find this ticket anymore. This feature is requested a lot, so I do want to keep it open if you don't mind.

I'm interested in this as well. I use https with ntfy in the browser. On Android, however, I point it at http and have another server entry in nginx config for port 80. I'd say this is good enough of a solution for self hosting except for the fact that file attachments can't be downloaded over http. My workaround is to copy the url and paste it into my mobile browser (which doesn't have the https CA restriction).

Can't you just import your own CA certificate into the Android user certificate store? The required setting in the app to utilize user certificates seems to be set: https://github.com/binwiederhier/ntfy-android/blob/main/app/src/main/res/xml/network_security_config.xml. Also make sure that the certificate is valid for your host, see https://github.com/home-assistant/companion.home-assistant/pull/1011/files.
(not an ntfy user, but I stumbled upon a similar issue, but I spent some time on a similar issue in Android)

Can't you just import your own CA certificate into the Android user certificate store?

I don't exactly remember this one anymore, but I believe that yes, you can install a user cert as long as that user cert is legitimate. Meaning something from Let's Encrypt or any authority with a matching root cert to your phone's system root certs.
If memory serves, what you cannot do is install a self-signed cert, which is a reasonable thing to do for self-hosted LAN services that will never be exposed to the internet.
That said, this is becoming such a problem across all applications these days that I caved and now use a Let's Encrypt cert for my LAN-only services and do what you mention--install it into my Android system's User certs. It's just annoying to need real SSL certs in a LAN-only context. The more complicated the self-hosted setup gets the harder it is to maintain. I'll add that acme.sh has made this process MUCH better than with certbot.

I just installed a self-signed certificate on Android. You just need to make sure you set the correct certificate properties during creation - take a look the the second link from my previous post if you are interested.

Interesting thanks for testing. Out of curiosity, to which IP does YOUR_HA_STATIC_IP_HERE refer? In my case, neither ntfy nor my reverse proxy pointing to it (through ntfy.mydomain.com) are public.  Or are you setting it to a public static IP? (Please forgive me if this is a dumb question)

I am using the local IP address of the server which I connect to via LAN, 192.168.x.x.

Already have my cert.  Found this nice, but unfortunate summary, which may mean the dev would still need to add more to support this:
https://stackoverflow.com/a/56295643

Update:
There is no way to add self signed server certificates at device level in Android. However you can trust such a self signed certificate in your application by creating your own Trust manager.
Check out this android doc link:
https://developer.android.com/training/articles/security-ssl#SelfSigned
I also found a tutorial which shows how add self signed certificates to a browser in android (Chrome and Firefox), however it is still not applicable device wide and just that those applications enable you trust your certificates in them.
https://coderwall.com/p/wv6fpq/add-self-signed-ssl-certificate-to-android-for-browsing


IDVA6-1103: Replace List with InvitationsList

Short description outlining key changes/additions
Replaced List<Invitation> with InvitationsList in the UserCompanyAssociations controller and AssociationsService service. Updated the pom.xml file to use the latest version of private-api-sdk-java.
JIRA Ticket Number
IDVA6-1103
Type of change

[ ] Bug fix
[x] New feature
[ ] Breaking change
[ ] Infrastructure change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[x] I have added/updated functional tests where appropriate
[x] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: No security warnings found


pre-commit error

Thanks for helping out, @jandockx!
One other workaround might be to install GNU grep using homebrew (a package manager for macOS).
brew install grep

This installs GNU grep as a binary called ggrep (note the extra leading g character). So, just change the references to grep to ggrep and you should be good :)


⚠ Bofrost.com has degraded performance

In 1a31845, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 845 ms

Resolved: Bofrost.com performance has improved in ee369a1 after 10 hours, 53 minutes.


Unable to Fetch Metadata from Stash to Jellyfin

I have installed these plugin on jellyfin (Ver 10.8.13). I have added Stash API Key and Endpoint .But unable to get any metadata.

But for some reason it is not working for me. Maybe I am doing something wrong. Is it possible to post guide on how to install and setup these plugin properly.

what you put to Stash Endpoint and did you set this plugin as library provider?

I tried using https://stashdb.org" and "https://stashdb.org/graphql" for endpoint which did not work. I tried using it in a similar way as ThePornDB plugin for metadata.

this plugin for local stash instance, I've didn't test it with stashdb

this stash I mean, https://github.com/stashapp/stash/

I have installed it, But how do pull metadata from it.

Stash Endpoint by default was htttp://localhost:9999, that's a;; you need

ok i changed endpoint to http://localhost:9999, but how do connect shash and jellyfin

that's all, fill stash then scan in jelly

do i have to setup common folder for stash and jellyfin then scan or their is any different way to setup, am not expert it this field.

I have no idea what's you about, just match files in stash and scan same files in jelly

sorry i already did that but not getting metadata from stash. Is it possible to provide guide that can I follow.

It's not much helpful
1.Install plugin as any other plugins
2. Set up url to your stash
3. Set apikey if needed
4. Use as any others metadata plugin

So if you've installed stash, you have to have scanned, imported, and tagged the files IN STASH before pulling them into JF.  If that's done, then you put in the ip of the stash install in, that's what he was saying.  So if jellyfin and stash are on the same box then local host would work.  For me, JF is on a different box, so I would need to use http://<IP_ADDRESS>:9999.  One that's configured, the plugin will look at a file and request the data from Stash based on the filename.  Path isn't a big deal, it's the filename that's important.  If the filename is found, stay hands back the data.  But it has to be matched in stash before JF can pull it

Works for me. Will the ability to add performer pics from stash ever be added? Thanks.

Wdym, it get images
Ahh, disable auth, remove apikey, it will help


Classic Controllers

Using the information provided by the interface (#17 ), classical controllers should be implemented to enable typical power grid application/simulation.
Therefore, the different sources should be controlled by:

Voltage forming inverter based on

Droop
VSG

dq0?

Current sourcing inverter
"Resonant-controllers" per phase to simulate non-symmetric loads and grid behavior

All tasks done


Two File Missing

CustomQuotedView.swift, UIString.swift file missing to commited project

Thanks for letting me know! I'll push the updated content soon if you still found these file missing let me know!


Authentication Error using PAT

Extension version: v0.0.11
VSCode Version: 1.53.0
OS: Windows

Steps to Reproduce:

Create a PAT token in Azure Devops with scopes: Code: Read & Write, Pull Request Threads: Read & Write
Try signing in to Azure Devops using the PAT.
Error:

Can you share the logs from this extension along with any configuration you may have specified for this extension.

Fixed in 0.0.12.


Expand test coverage for Feature List dialog

https://github.com/ngageoint/opensphere/pull/567
Expand coverage to fill in the gaps for Layer Features testing. This also appears to be the first table version of slick-grid and will serve as a good full test.
Dialog UI:

Show Selected Only checkbox
Row height slider

Context Menu:

Sort Selected
Export
Go To

Mouse/Keyboard Interactions:

Ctrl+click selections
Shift+click selections
Sort via clicking on header
Moving columns via drag

Additional:

Multiple instances of the dialog with different layers
Smoke tests for additional types of data (e.g. csv)

Ctrl / shift selections, sort selected, export, go to done here: https://github.com/justin-bits/opensphere/tree/test/refactor-selectors


use same overview size calculation as in GDAL

closes #116
This PR do:

use _div_round_up to make use we use the same overview size as in GDAL
add resampling_method in raster_get_stats

output values for raster_get_stats might change slightly because of the change in the resampling method


Updated index.md with grammar errors

Updated index.md reviewing grammar errors and general syntax errors.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @XGiurob94 on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


modules: hal_nxp: migrate module glue code to NXP HAL repo

Move module glue code for NXP HAL to the HAL repo. This aligns better with the general structure of NXP's HAL, since the majority of the CMake infrastructure is already present there. Additionally, this will enable Kconfigs to be defined within the NXP HAL without sourcing them from the hal_nxp/Kconfig file.

You make a good point about the Kconfig dependency being introduced here. The reasoning for this change is that NXP is planning to integrate some of the middleware used with our GPUs into the NXP HAL, as this will be required to enable them upstream. The current version of the integration contains Kconfigs that might not make sense to place in the Zephyr tree.
However, given that the GPU middleware integration can't really be finalized until there is some type of 2D GPU driver class (whatever that ends up being), I'll close this PR for the time being, and we can revisit it if the change is needed in the future.

This goes against the current guidelines

While this makes sense (given the Kconfig issue you highlighted) I could not see where in the documentation for modules we state this- is there somewhere I'm missing?


⚠ T:Riza Api has degraded performance

In f239a91, T:Riza Api (https://infra.triza.dev/api) experienced degraded performance:

HTTP code: 200
Response time: 1960 ms

Resolved: T:Riza Api performance has improved in 63d68a5.


Spinner hangs infinitely

See: TODO_30_69_19_14.

Based on the latest status update, the issue was fixed by #118.


[Bug] Crash with Charm + Supplementaries

Describe the bug
If Recipe Book is Pain installed together with Charm and Supplementaries, and creative tabs option in Supplmenetaries is turned on, the game crashes on startup.
To Reproduce

Install RBIP, Charm and Supplementaries
Launch the game once to generate configs, it will not crash
Now set "creative_tab": true in supplementaries-common.json
Launch the game again and crash

Expected behavior
No crash.
Logs
https://gist.github.com/SplendidAlakey/aa0ff0dd7dc1e9b7434afdf4c26ce264
Environment:

Minecraft Version 1.19.2
Mod Version 0.8.1-1.18

Additional context
The crash doesn't happen on Quilt.

Wow, that's impressive, a three-way.
Right now, it looks like Charm initialized the CharmClientHacks class. Which calls the RecipeBookGroup enum, during enum's initialization, RBIP runs through all the ItemGroups trying to get the icon, with the config option on, Supplmenetaries tries to supply an icon for the group, but for some reason GLOBE_ITEM.get().getDefaultInstance() returns null and the game crashes.
I assume that this doesn't happen on the cracker-util version, since its initialization depends on a different class.
I'll try to replicate cracker's way of extending enums here.

This version should work. https://github.com/melontini/recipe_book_is_pain/actions/runs/4675835219
I'll publish it on MR and CF once you confirm that it works.


How to send a forced photo command with python in O3D300？

What instructions can be sent in python to force the camera to take an image, the current camera mode is the process, the camera model is O3D300, who knows the trouble to tell me, thank you!

In order to trigger the camera in run mode (I hope this is what you mean), the trigger mode of the active application needs to be set to "Process Interface", i.e. the application parameter TriggerMode must be 2.
If you open a PCIC connection to the camera with
import o3d3xx
pcic = o3d3xx.PCICV3Client("<IP_ADDRESS>", 50010)

you can issue a trigger either asynchronously by
pcic.sendCommand("t")

or synchronously by
pcic.sendCommand("T?")

In the latter case sendCommand() returns the result of the trigger as defined in the application parameter PcicTcpResultSchema.


Claim Front End Certificate with dead links and error message

The steps to reproduce the problem:

All the Bonfires and Ziplines (basic and intermediate) are done (not all waypoints);
Click link 'Waypoint: Claim Your Front End Development Certificate' from 'Map' page;
Click 'go to next step';
On second screen (plagiarism), click on 'Open link in a new tab' and no tab gets opened. Although no tab opens, the link 'go to my next step' gets clickable;
On screen 3, 'front end dev certificate requirements', where it suppose to check if basic and intermediate Bonfires and Ziplines are completed, click 'open link in a new tab';
No tab opens and return error message;

Just came here to submit the same issue.

What browser are you using and what is the error message?

Challenge Map renders on the samer page and a message is displayed : "Oops! Something went wrong. Please try again later"

I'm looking into it.

Looks like there was corrupted db seed attempt. Should be fixed now.

Hi. It now renders the certificate, but the links are still dead (the 'open in a new tab' links) and the certificate has no name/username on it.

@pwdd There are no links. They hit api endpoints.
Your name is pulled from Github. Please update you're Github (we recommend adding an actual picture of yourself as well). Then sign out and sign in again on FCC.
Happy Coding!

@BerkeleyTrue Thanks, but I changed my name on my Github profile, tried the 'claim' process again, and the 'name' field on the certificate is still blank. And the 'open link in a new tab' as text of the button is a little misleading if nothing will open ;-)

I have the same problem! Tried in Chrome, Firefox and also in Explorer!

When I tried to claim my front end development certificate I got a message showing 'Oops! something went wrong. Please try again later' .The error in chrome console is Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience.


bug-fix-and-improvement

Field config synchronization
Dashboard embeding synchronization
Delete dashboards and cards that exists in the given collection before import
Select db automatically if name is matching
Enviroment added for username, password and url

Hi @emreyavuz369!
I'll review this soon, thank you!


Bumped version to 2.4.0-SNAPSHOT

Motivation
Bump maven version for next release

run java8 tests


Add a Kafka source Extractor

Build a Kafka Extractor to extract data from Kafka source.

We are building a metadata push model leveraging Kafka. And we would like to build a Kafka extractor to extract metadata info from a Kafka topic and sink to a Neo4j sink.


Width and Height of Asset model are missing

Motivation
Why is this feature required? What problems does it solve?
Proposed solution
An ideal solution for the above problems.
Additional context
Add any other context, screenshots, or reference links about the feature request here.

@huluvu21 ?

@petrsvihlik This fix is also contained in this PR: https://github.com/Kentico/kontent-management-sdk-net/pull/59
I added the ImageHeight / ImageWidth attributes from the V2 API...

Thanks @xantari !


fix(links) fix hydration overriding wrong elements of the ssr html

Closes #3287
hydration with index based keys maps wrong data to ssred html elements, wrong indexes come from printable.md being in the content during ssg config run.

Please try to keep formatting changes out of normal PRs.
Also, I don't get issue error at all right now in production. Did you reproduce it?

Issue still in production and also after this PR:

@ejez i cannot reproduce on netlife preview nor locally on this branch :O

Delete browser cache/history related to the site, then open guides main url, reload it once or twice, then hover over a sub topic below "asset management".
Issue is not present when already on a sub topic url.
Try different devices/browsers

(do not click on the subtopic links, just hover. clicking will take you to the correct suptopic, but hovering on or inspecting the sidebar item shows incorrect link)

@ejez i cannot reproduce with cache disabled, in incognito, etc. @montogeek its your call now

firefox 69.0 / ubuntu 18.04

Also when in a subtopic page and after refreshing the page, the subtree will show a different subtopic open:

@EugeneHlushko you can reproduce here:
https://www.browserling.com/browse/win/7/firefox/68/https%3A%2F%2Fwebpack.js.org%2Fguides%2F
and here:
https://www.browserling.com/browse/win/7/firefox/68/https%3A%2F%2Fdeploy-preview-3288--webpackjsorg-netlify.netlify.com%2Fguides%2F

Yup its reproducible in that firefox, will take a look into it again, ty @ejez

Interestingly i cannot reproduce it in latest firefox either ( 69.0.2 (64-bit) )

I just installed a new Firefox channel, which is basically a fresh installation and it is reproducible.

It is also reproducible in this PR Netflix preview deploy. As you can see in above image, "Output management" is missing from the server rendering, it is hydrated by React client side. That gives us 2 ideas:

Why is "Output management" not rendering in the server side like the rest of the links? This would be the correct fix.
What are we missing when building the app that is creating this mismatch which is confusing React hydration?

made a local test:
the issue disappears if we set mode: 'none', or mode: 'development', in webpack.prod.js
The issue might be narrowed down by checking individually the plugins enabled by mode: 'production', or setting process.env.NODE_ENV to development
will try to check later

The issue disappears if we set process.env.NODE_ENV to development (while keeping mode: 'production')

While waiting to identify the issue, we can get the site working properly by disabling ssr for the sidebar,
I am not familiar with "react" but I tested the following and it is working:
https://deploy-preview-3314--webpackjsorg-netlify.netlify.com/guides/development/
PR #3314
src/components/Site/Site.jsx :
 class Site extends React.Component {
   state = {
+    hasMounted: false,
     mobileSidebarOpen: false
   };

+  componentDidMount() {
+    this.setState({ hasMounted: true });
+  }
+
   render() {
     let { location } = this.props;
     let { mobileSidebarOpen } = this.state;

...

                         return (
                           <React.Fragment>
                             <Sponsors />
+                            { this.state.hasMounted ? (
                            <Sidebar
                              className="site__sidebar"
                              currentPage={location.pathname}
                              pages={this._strip(
                                section
                                  ? section.children
                                  : Content.children.filter(item => item.type !== 'directory' && item.url !== '/')
                              )}
                            />
+                            ) : '' }
                             <Page {...page} content={content} />
                             <Gitter />
                           </React.Fragment>

Disabling SSR for the sidebar will remove the links, this will mess up Google ranking of the pages and established internal websites linking.
I will look into what you guys found

@montogeek it looks like Output management is in SSR's HTML, trying to understand why its not visible, maybe HTML is invalid?

It is now fixed (writing this before preview lands so 🤞 )
I found that sort: 0 was causing a weird issue:

When we had sort: 0 item sort was behaving strange...
After i changed it to -1:

For details i suggest you see last commit

Yup its fixed: https://www.browserling.com/browse/win/7/firefox/68/https%3A%2F%2Fdeploy-preview-3288--webpackjsorg-netlify.netlify.com%2Fguides%2F
@montogeek or @ejez please confirm

Working! thanks @EugeneHlushko

When we had sort: 0 item sort was behaving strange...

Why exactly? Something related with 0 array indexes?
Also from your screenshots, 21 is missing before but present in the second screenshot. Maybe another fix will be to guarantee the consecutive order of the sort property?

Also wonder if this is the same in other sections of the website.

Yeah so i've tested all sections as well which had 0 on sort, checking if its working is quite easy just hovering over links like we did to reproduce this one

Why sort failed, i am not sure, we have interesting sort function which is pretty straightforward, but for some reason it only worked (without my fix) if i did .sort(sort) twice in a row here... After fix 1 sort is enough.

Thanks!

🎉 finally

i think this was third tracked attempt to track down the issue, although the culprit is react's hydration that fails when sort order changes (there is an issue in react repo about this linked in previous pr)


Zero exit code when include file does not exist

Hi.  When shins terminates due to an include markdown file not existing, shins seems to return with a zero exit code.  Expected behaviour would be a non-zero exit code to indicate that something has gone wrong.

I've created an example of the issue in
Here's an example of the shins output when an include file does not exist, including a printout of shins's exit code:
$ node_modules/.bin/shins index.md -o index.html --inline --attr --customcss
{ Error: widdershins-issues/exit-code/node_modules/shins/source/layouts/layout.ejs:18
    16| <% var language_tabs = current_page.data.language_tabs || []; %>
    17| <% if (current_page.data.includes) { for (var include in current_page.data.includes) { %>
 >> 18|   <% page_content += partial(current_page.data.includes[include]) %>
    19| <% } %>
    20| <!doctype html>
    21| <html lang="en">

ENOENT: no such file or directory, open 'widdershins-issues/exit-code/node_modules/shins/source/includes/_does-not-exist.md'
    at Object.fs.openSync (fs.js:667:18)
    at Object.fs.readFileSync (fs.js:572:33)
    at Object.partial (widdershins-issues/exit-code/node_modules/shins/index.js:69:25)
    at eval (eval at compile (widdershins-issues/exit-code/node_modules/ejs/lib/ejs.js:584:12), <anonymous>:18:24)
    at returnedFn (widdershins-issues/exit-code/node_modules/ejs/lib/ejs.js:615:17)
    at tryHandleCache (widdershins-issues/exit-code/node_modules/ejs/lib/ejs.js:251:36)
    at Object.exports.renderFile (widdershins-issues/exit-code/node_modules/ejs/lib/ejs.js:472:10)
    at widdershins-issues/exit-code/node_modules/shins/index.js:313:13
    at new Promise (<anonymous>)
    at Object.render (widdershins-issues/exit-code/node_modules/shins/index.js:201:28)
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'widdershins-issues/exit-code/node_modules/shins/source/layouts/layout.ejs' }
$ echo $?
0

Thanks for the report, will take a look.

Should be fixed in v2.2.1-6. If options.cli is true then shins will exit with error-code 1 on any non-existing include, script, image etc. If options.cli is not truthy then a warning is logged to stderr but rendering will continue.
Thanks again for the prompt.


Simplify sync protocol and update to calculate optimistic heads

Simplify valid_updates to best_valid_update so the LightClientStore only needs to store O(1) data
Track an optimistic head, by looking for the highest-slot header which passes a safety threshold

I will make one big picture comment that is slightly out of scope for this PR. It is relevant because this PR attempts to fix the sync logic when there is a client timeout. It is even more relevant if a light client has to get updates that skips a period.
As it stand right now, the spec does not provide a mechanism to skip-sync for a light-client that has an outdated view of the sync-committees. Without an explicit skip-sync mechanism, it is hard to address the cold start problem.

Here is a spec that writes out skip-sync data objects on the portal network: https://github.com/ethereum/portal-network-specs/blob/master/beacon-chain/skip-sync-network.md
Here is a light-client POC that implements a skip-sync mechanism: https://github.com/jinfwhuang/prysm/pull/5


YouTube footer links

Hi @rdunk —
We'd like to create a link to our YouTube channel in the Stories footer.
We have two channels for YouTube:
TC: https://www.youtube.com/channel/UCLsE-cTgFvwXaZ8H0DsfOIQ
Eng: https://www.youtube.com/channel/UCA1jc0-yS4eFrF9WEAoa7Qg
Can we get the logo to link to the appropriate language channel based on the language the visitor is viewing the page in?

Just implemented this locally, requires an extra field for the social media platforms for a TC link. The migration file will prepopulate the new field with the value from the current field, so no action required for the existing platforms. I'll add a new one for YouTube with the correct logo etc and this can use two different links. This will also give you the ability to add social media platforms for one language only if you so choose by leaving the relevant field blank.
Small point of clarification... the social media icons/links currently appear in three places: the footer, the "connect"/ 👋panel, and the "follow us on social media" sections on the homepage. For consistency these are all drawn from the same list, did you want YouTube to appear exclusively in the footer or can it also appear in these other locations too? Let me know and I'll push ASAP.

Thanks, Rupert. Let's have it appear in these other locations too.

Great, deployed.


GH-3935: Remove SmartTransactionObject from TransactionObject

GitHub issue resolved: #3935
Briefly describe the changes proposed in this PR:
CherryPick to fix #3935 for a 4.0.4 Release

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Will add missing @Experimental tags based on the classes and interfaces used in rdf4j-spring-demo


add chatbot fixed

#64 issue fixed Added mini chatbot which access to any question and give quike response
Addgssoc-ext,hactoberfast accepted and level 3 label to this pr @yatulearn fixed this issue
screenrecording
https://github.com/user-attachments/assets/fff46b6f-febe-483e-8dfb-dea3987f2856

add the chatbot on every page rest you did a good job

I am updated the Add mini chatbot @yatulearn

your pr has conflicts kindly resolve them

your pr has conflicts kindly resolve them


More nightly bugz

-Your updated utils get file size code will crash if you supply an invalid path.
-Picking a sample from the combo box results in an error
Error: Spider Monkey Panel v1.3.2-beta+01dd8c13 ({358BE023-493E-49E3-AC72-995AC89466D4})
Path does not point to a valid file: Z:\foobar2000 - Copy - Copy\profile\user-components\foo_spider_monkey_panel\samples\..\complete\playback buttons.js

Note the \..\ in the full path.
-Just saw your post on HA about the html parsing bug affect WilB's bio - it also affects thumbs and allmusic from the samples.

-Picking a sample from the combo box results in an error
Yup, I've noticed that as well, already fixed =)

-Your updated utils get file size code will crash if you supply an invalid path.
Thanks, didn't have time to test them yesterday >_<

-Just saw your post on HA about the html parsing bug affect WilB's bio - it also affects thumbs and allmusic from the samples.
That's really weird, AFAIK your samples did work in SMP. This ActiveX API is such a major PITA...

That's really weird, AFAIK your samples did work in SMP. This ActiveX API is such a major PITA

And they do work on the release version... Ugh...

Everything should be fixed now (once nightly is built).
Thanks again for testing and reporting!


[Bug]: Translations do not seem to be working on confirmation

Current Behavior

The text is not rendering in Chinese when we have that language set and have provided the i18 configuration
Expected Behavior
We expect the connect text be in Chinese.
Steps To Reproduce
Here is our i18 configuration. The issue can be recreated by going to Umbra scrolling down and switching the language to Chinese and then attempting to login using the connect button
What package is effected by this issue?
@web3-onboard/core
Is this a build or a runtime issue?
Runtime
Package Version
2.11.1
Node Version
No response
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

Relevant issue https://github.com/ScopeLift/umbra-protocol/issues/449

@alexkeating oh wow! Thanks for pointing this out, I'll try and repro and see what's going on.

@alexkeating I wasn't able to reproduce 🤔 where in your code do you call onboard.state.actions.setLocale?

We don't use setLocale directly on onboard. We have been setting the locale below. I will add setting the locale on onboard and let you know if we are still running into issues.
https://github.com/ScopeLift/umbra-protocol/blob/cff346c2125af2097eece678f3cc625ea3310e6d/frontend/src/store/settings.ts#L72

@alexkeating is there a reason why you're using this method for setting the locale?

I think it is to set the locale for the whole app based on the Vue docs, added a link below. Also, added the onboard method and it seems to be working.
https://vue-i18n.intlify.dev/guide/essentials/scope.html#global-scope-1


Stage 4 viewers sometimes don't appear on reload

I'm not sure if this is a thing that could happen to a student (or if this is only happening to me because I randomly jump around), but I frequently end up with no viewer in Stage 4. Going back to the intro stage, refreshing the page, and then coming back to Stage 4 does not help - sometimes when I've tried, this the title bar for the viewer goes away too. The only way I've found to bring the viewers back is to reset the stage state, which would be problematic if it's possible for this to happen to students going through sequentially.

Do you see any errors in the browser console when this happens? Since the graph isn't appearing, my guess would be that there's an issue with loading Plotly.

    at VueComponent.mounted (eval at <anonymous> (VueTemplateRenderer.js:351:21), <anonymous>:30:5)
mounted @ VM7451:30Understand this error

So something is causing Plotly to not be loaded, which should happen in the layout via the PlotlySupport component (inside of the layout). This component adds a plotlyPromise to the window which we then await in the line draw viewer.
Is there any particular sequence of events that causes this to happen?

Not that I've noticed. Usually I'm on a guideline where the viewer is visible, but when I refresh the page, the viewer is not there. If I notice any particular patterns going forward, I will note them here.

Recap for posterity of a dev meeting discussion:
This can be partially resolved by moving the PlotlySupport component in the HubbleDS layout outside of the use_memo call. Doing this reveals another issue where the entire component won't load. This is due to (at least) one of the student_plot_data and class_plot_data being an empty array, causing the if condition that displays the component to evaluate false.

I haven't seen this issue since the above update was merged, so I am closing this.


Default .gitignore for the counter app should include platform specific generated files.

For example: /macos//ephemeral/**

Hi @polina-c, the various platform folders contain their own .gitignore files which include the generated files.
Do they not suffice? Or is there a specific issue that you're running into?

Thanks. It seems it did not work, but now I cannot repro it. Will watch.


Project 1 - Peer Review :

Hello CloudElves team,
I ran your application in my local and I was able to run all the containers. The application works well and I was able to sign in and view the plots. Overall great work. I just have a couple of pointers :

You'll can implement continuous Integration for pushing docker images to docker hub and then using them to start your containers. It makes the setup easy andless time-consuming.
UI can be enhanced a little more.

Wish you all the best in your upcoming projects.
Team Scapsulators : https://github.com/airavata-courses/scapsulators

Hello Team Scapsulators,
Thank you for the feedback :)

Yes, we shall do the needful for the upcoming milestone, really liked the part where you guys only had to run 1 docker file that had a lot of other containers set up sequentially.
Yes, we didn't pay much heed to the UI since foundation needed to be strong. In the upcoming, milestones, we definitely plan to improve UI and add more frontend features.

--Team CloudElves.


Integration with react-hook-form

Hi,
This is not a bug but I couldnt get this work with React Hook Form. Here's the code sandbox, anybody has an idea about this? Thanks in advance.
https://codesandbox.io/p/devbox/92m9nt?file=%2Fsrc%2FApp.jsx%3A211%2C31-211%2C42

@KayahanKahriman what issues are you facing? Also please update to the latest version (6.10.2) in case you haven't.


Make ChartHighlighter a protocol, publicly accessible

Relates to #357

Pretty sweet stuff man :+1:. Could this be used from any graph type and not just BarLineChartViewBase?

Yes, it can. Although I had some difficulty figuring out how to get a downcast version of the renderer into some of the classes. See the TODO here: https://github.com/danielgindi/ios-charts/pull/567/files#diff-ac32fb888c389b4e17eca7e5ac42579dR20

Something like this could possibly work
public protocol ChartHighlighter {
    public typealias ChartViewType
    weak var chart: ChartViewType? { get set }
}

I'm going to hold this a bit, as Phil and I are working on some changes that make the library more interface-oriented, mainly to allow querying for data (instead of pushing an array of entries).
We're trying to keep it 100% backwards compatible, but things could happen.
Anyway, I'll try to add this into the mix before we merge to master!

No worries. Good luck with your work. I'm excited to see what you've got in store.

Don't you think that the use of an extension in this case is a little bit problematic?
I mean if we want to have an interface with some base functionality implemented, we should probably have an "abstract" base class...
What will happen if an implementation has a function with the same name as one implemented in the extension?

@iheart2code  Actually I don't get why not make the original class' properties public..?

defining a protocol and then defining an extension of that protocol is the same as an abstract base class. Like can be seen below.
protocol CoolType {
    func superFunction() -> String
}

extension CoolType {
    func superFunction() -> String {
        return "blue"
    }
}

struct AType: CoolType {

}

struct BType: CoolType {

    func superFunction() -> String {
        return "red"
    }
}

let a = AType().superFunction()
let b = BType().superFunction()

The output looks like so:

@petester42 thanks for explaining!
Is there an advantage of having this as an abstract class and not just making those properties public?
Because as I see it, if the class conforms to a protocol, then its methods are public anyway as those are protocol methods. Which means that just making the properties public in the first place will achieve the same desired effect.

I just want to be finished with this one correctly on the iOS and Android side, before merging in dynamic-preparations branch which introduces interfaces between current dataset classes and their implementations, and easy Realm.io integration.

The advantage is that you have a flatter hierarchy instead of more nested one with subclass of a subclass etc.
You can also set the access control to protocol methods like so:
public struct BType: CoolType {

    internal func superFunction() -> String {
        return "red"
    }
}

that function would only be public inside the library which for what this is trying to accomplish probably doesn't make sense but you can do it.

Remember that the library is also used from ObjC, so if anyone tries to call a protocol method from ObjC, it will let him...
Also that protocol should actually be exposed to ObjC, which is not the case right now.
Anyway, I still don't see why we need the additional hierarchy if we just want to make things public!

The point would be that a user would not have to subclass something from the library in order set their own chart highlighter. Subclassing add a level of complexity since you never know if you need to call super or not (unless the function is properly annotated). Having it be a protocol makes it more flexible for a user since it is more straight forward. Implement these methods and it will work.

Well in such a case we would have to rename the protocol methods to specify the highlighter context, as one can (and often do) implement multiple protocols in one class.
@PhilJay what do you say about this? Basically this means making ChartHighlighter an interface, moving the implementation to DefaultChartHighlighter.
The thing that I mostly don't like about this is that this would mean a major inconsistency API with the Android side.
As an "extension" is something that only iOS allows, and so all current Highlighters would have to subclass DefaultChartHighlighter, while on the iOS side they just implement the base interface and get the functionality by default.
The iOS implementation is like a combination of an interface and an abstract class...
@petester42 I now get why these changes were implemented in the PR, but as you probably know the biggest strength of the framework is being cross-platform :-) We just need to carefully consider this before implementing.

For sure, from the issues I know a bunch of people use this with objc and of course the API consistency with android is a priority.
Without having actually gone through it I would say that this should probably be rejected based on the things you mentioned. I don't know about protocol extensions in objc but I would assume they don't work.

@petester42 Oh no, I haven't event thought about protocol extensions in ObjC... No they don't work. That's an issue on iOS even before considering Android.
So sadly this PR is going to be rejected... @iheart2code do you want to modify the PR to just make things public, make another PR, or just leave that to us?