Service Bus Adapter > Custom Properties > Extending internal class according documentation raises an error

Hi,
we send Business Events to Azure Service Bus and want to add a custom filter property for source system. We have implemented as described on this docs article in section "Extending filters so that they have custom fields (if the middleware supports this extension)". https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/business-events/business-events-dev-doc#extending-filters-so-that-they-have-custom-fields-if-the-middleware-supports-this-extension
It worked with previous version, but now in D365 we get compile error with 10.0.23. PU47:
'BusinessEventsServiceBusAdapter' is internal in model 'ApplicationFoundation' and cannot be extended by class 'BusinessEventsServiceBusAdapter_ABC_Extension' in model 'ABC'.
There was already the same issue #2990 created a year ago, but it was closed without any actions - neither documentation is updated, nor extension is allowed.
Please add a sample how to implement the additional property in a safe way since current suggestion cannot be compiled with actual version.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11811157-3f2d-56d5-07d4-0f44ab2c9370
Version Independent ID: 5bc47a47-4d27-aaf5-750f-72b47bb39fe1
Content: Business events developer documentation - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/business-events/business-events-dev-doc.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @Sunil-Garg
Microsoft Alias: sunilg

@@.> and @@.> can you pls help here?
Thanks

From: sfikh @.>
Sent: Wednesday, November 24, 2021 6:43:19 AM
To: MicrosoftDocs/dynamics-365-unified-operations-public @.>
Cc: Sunil Garg @.>; Mention @.>
Subject: [MicrosoftDocs/dynamics-365-unified-operations-public] Service Bus Adapter > Custom Properties > Extending internal class according documentation raises an error (Issue #3686)
Hi,
we send Business Events to Azure Service Bus and want to add a custom filter property for source system. We have implemented as described on this docs article in section "Extending filters so that they have custom fields (if the middleware supports this extension)". https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/business-events/business-events-dev-doc#extending-filters-so-that-they-have-custom-fields-if-the-middleware-supports-this-extensionhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fdynamics365%2Ffin-ops-core%2Fdev-itpro%2Fbusiness-events%2Fbusiness-events-dev-doc%23extending-filters-so-that-they-have-custom-fields-if-the-middleware-supports-this-extension&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029853510|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=T2LcJoCPilVdDZc9zsqqq1QlYHnKWStX5WUcCwsyjec%3D&reserved=0
It worked with previous version, but now in D365 we get compile error with 10.0.23. PU47:
'BusinessEventsServiceBusAdapter' is internal in model 'ApplicationFoundation' and cannot be extended by class 'BusinessEventsServiceBusAdapter_ABC_Extension' in model 'ABC'.
There was already the same issue #2990https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-unified-operations-public%2Fissues%2F2990&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029863464|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Hx4%2B6bhh0pf73MRHxJOC3ECMMnDPeGnGRGh1AHzoSo8%3D&reserved=0 created a year ago, but it was closed without any actions - neither documentation is updated, nor extension is allowed.
Please add a sample how to implement the additional property in a safe way since current suggestion cannot be compiled with actual version.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11811157-3f2d-56d5-07d4-0f44ab2c9370
Version Independent ID: 5bc47a47-4d27-aaf5-750f-72b47bb39fe1
Content: Business events developer documentation - Finance & Operations | Dynamics 365https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fdynamics365%2Ffin-ops-core%2Fdev-itpro%2Fbusiness-events%2Fbusiness-events-dev-doc&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029863464|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=f5p0YvMpQKk3PlbOdIatLVHgOjEEZXPplVRsGAHeXpU%3D&reserved=0
Content Source: articles/fin-ops-core/dev-itpro/business-events/business-events-dev-doc.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FDynamics-365-Unified-Operations-Public%2Fblob%2Fmain%2Farticles%2Ffin-ops-core%2Fdev-itpro%2Fbusiness-events%2Fbusiness-events-dev-doc.md&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029863464|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Xp3QnxKcZagmWsT7Pd4ZRh%2BGtg1ONzV9T4kbuBDGa0o%3D&reserved=0
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @Sunil-Garghttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSunil-Garg&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029873421|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=X5Kkjk8PGllZEp%2B9l1%2BVdU6g0ui2rVg%2B1Mjr2t2x3U8%3D&reserved=0
Microsoft Alias: sunilg

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-unified-operations-public%2Fissues%2F3686&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029873421|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=LAYaqnVatfQn8KlWPBQIC%2B8ron%2BJXwMlEY2PH%2FUjXSE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHNKDW2N4ZZ6325WXB6YYX3UNT2YPANCNFSM5IWH2W2Q&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029883378|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=8uAPXZYR%2Br7rE1uPsbXP9SliAG4MDdrnMk9pzahTYuw%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029883378|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=9BULeWotmtLrbJZVMUlCFUQDzz8y84H5WvfCQjSQMIs%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|sunilg%40microsoft.com|5eb5b29be8334923880c08d9af58c271|72f988bf86f141af91ab2d7cd011db47|1|0|637733618029893332|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=6M5zZcweftpgqOHNFRYyUHNy%2BlA7s0FsWcxY5fqfV4Y%3D&reserved=0.

It looks like we need to make that type public if we want extensions to be made on it.
I've reactivated the bug that was logged for the issue one year ago and assigned to myself to investigate.
https://msdyneng.visualstudio.com/FinOps/_workitems/edit/534663
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Sunil Garg @.>
Sent: Wednesday, November 24, 2021 6:44:10 AM
To: MicrosoftDocs/dynamics-365-unified-operations-public @.>; MicrosoftDocs/dynamics-365-unified-operations-public @.>; Jared Hall @.>; Leckie Gunter @.>
Cc: Mention @.>
Subject: Re: [MicrosoftDocs/dynamics-365-unified-operations-public] Service Bus Adapter > Custom Properties > Extending internal class according documentation raises an error (Issue #3686)
@@.> and @@.> can you pls help here?
Thanks

From: sfikh @.>
Sent: Wednesday, November 24, 2021 6:43:19 AM
To: MicrosoftDocs/dynamics-365-unified-operations-public @.>
Cc: Sunil Garg @.>; Mention @.>
Subject: [MicrosoftDocs/dynamics-365-unified-operations-public] Service Bus Adapter > Custom Properties > Extending internal class according documentation raises an error (Issue #3686)
Hi,
we send Business Events to Azure Service Bus and want to add a custom filter property for source system. We have implemented as described on this docs article in section "Extending filters so that they have custom fields (if the middleware supports this extension)". https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/business-events/business-events-dev-doc#extending-filters-so-that-they-have-custom-fields-if-the-middleware-supports-this-extensionhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fdynamics365%2Ffin-ops-core%2Fdev-itpro%2Fbusiness-events%2Fbusiness-events-dev-doc%23extending-filters-so-that-they-have-custom-fields-if-the-middleware-supports-this-extension&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618528970083|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=tM8cG7ccBkutPvZrWhyCeo7TgpgWbo5hBtCeVHL1Ur0%3D&reserved=0
It worked with previous version, but now in D365 we get compile error with 10.0.23. PU47:
'BusinessEventsServiceBusAdapter' is internal in model 'ApplicationFoundation' and cannot be extended by class 'BusinessEventsServiceBusAdapter_ABC_Extension' in model 'ABC'.
There was already the same issue #2990https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-unified-operations-public%2Fissues%2F2990&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618528970083|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=q%2BwQf0jiQ22eSs7C5kx1t9dhTTreXp10YYbV4qr5qbQ%3D&reserved=0 created a year ago, but it was closed without any actions - neither documentation is updated, nor extension is allowed.
Please add a sample how to implement the additional property in a safe way since current suggestion cannot be compiled with actual version.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11811157-3f2d-56d5-07d4-0f44ab2c9370
Version Independent ID: 5bc47a47-4d27-aaf5-750f-72b47bb39fe1
Content: Business events developer documentation - Finance & Operations | Dynamics 365https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fdynamics365%2Ffin-ops-core%2Fdev-itpro%2Fbusiness-events%2Fbusiness-events-dev-doc&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618528970083|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=BfjUXSoW9a1Fv9Tl3u%2BBeL7iiR0bK4UNZeSCU7b63E8%3D&reserved=0
Content Source: articles/fin-ops-core/dev-itpro/business-events/business-events-dev-doc.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FDynamics-365-Unified-Operations-Public%2Fblob%2Fmain%2Farticles%2Ffin-ops-core%2Fdev-itpro%2Fbusiness-events%2Fbusiness-events-dev-doc.md&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618528970083|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=vKi6PMuQqcKoeHegBbQJop9vU5s227sBHSr1tAzn47A%3D&reserved=0
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @Sunil-Garghttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSunil-Garg&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618528970083|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=UjxQMXa9nDITfqRowH2bdRoOzB%2FiQ7ILYkCbyAVVkpM%3D&reserved=0
Microsoft Alias: sunilg

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-unified-operations-public%2Fissues%2F3686&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618528970083|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=rJ4DpZ5sYReg%2B3F4jMrEgaVhaZY7wBHZ64AdaGRyuAs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHNKDW2N4ZZ6325WXB6YYX3UNT2YPANCNFSM5IWH2W2Q&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618529020059|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=p2Jd%2FfmBHsiVE1PPQZVYauuh%2Fg%2BudtlrVJN2%2B9REOcY%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618529020059|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=3nMblN%2BYu%2BLatnMh0j0y3jHBx8F2RrAKjkDEEEt6etk%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|legunter%40microsoft.com|6ea261486c7a48fb120608d9af58e0ab|72f988bf86f141af91ab2d7cd011db47|1|0|637733618529020059|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=2oYUXgQj9rlAXWaolrCBxLbyzRmxsVGltnaqQ91v1VI%3D&reserved=0.

This would be the perfect solution, thanks!

@.*** @.***>
@@.> can you pls update the PM ownership for this to @@.>?
Thanks.
From: josaw1 @.>
Sent: Monday, November 29, 2021 10:18 AM
To: MicrosoftDocs/dynamics-365-unified-operations-public @.>
Cc: Sunil Garg @.>; Assign @.>
Subject: Re: [MicrosoftDocs/dynamics-365-unified-operations-public] Service Bus Adapter > Custom Properties > Extending internal class according documentation raises an error (Issue #3686)
Assigned #3686https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-unified-operations-public%2Fissues%2F3686&data=04|01|sunilg%40microsoft.com|bec3a62ca7504f568abb08d9b3648d6d|72f988bf86f141af91ab2d7cd011db47|1|0|637738066731381525|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pW7UGz3JlX8CzNsAXcWhFBZO9LOIs3w9x%2Fjq9r%2FovMU%3D&reserved=0 to @Sunil-Garghttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSunil-Garg&data=04|01|sunilg%40microsoft.com|bec3a62ca7504f568abb08d9b3648d6d|72f988bf86f141af91ab2d7cd011db47|1|0|637738066731381525|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=RwHsElTYEc5cchFCsz9rKFIpbS5HSvK3cP2U7sOb%2BWA%3D&reserved=0.

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-unified-operations-public%2Fissues%2F3686%23event-5686830651&data=04|01|sunilg%40microsoft.com|bec3a62ca7504f568abb08d9b3648d6d|72f988bf86f141af91ab2d7cd011db47|1|0|637738066731391479|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=jv1gC3BTngDndaRlYy4YCu5MuH%2BIBODZUS67YUR0Jwk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHNKDW6O5AE7EDLG7CR2TLTUOO7U3ANCNFSM5IWH2W2Q&data=04|01|sunilg%40microsoft.com|bec3a62ca7504f568abb08d9b3648d6d|72f988bf86f141af91ab2d7cd011db47|1|0|637738066731391479|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=dMrVV8A61%2BPWHg1H6LiWbc7Q%2Fz5uX%2Bb3TYnhMGjZoBE%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|sunilg%40microsoft.com|bec3a62ca7504f568abb08d9b3648d6d|72f988bf86f141af91ab2d7cd011db47|1|0|637738066731401439|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Opp1iVvOZi%2BRbL1swy5%2FkbsDH0ZWk2%2BFPERjJV%2Bm7TI%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|sunilg%40microsoft.com|bec3a62ca7504f568abb08d9b3648d6d|72f988bf86f141af91ab2d7cd011db47|1|0|637738066731401439|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=BVHPUDkD6U3Jerei2t068gX8MBE8Y2yv0W6nQCefQkM%3D&reserved=0.

I've assigned this issue, and the topic itself, to @jaredha.

BUG 641736 created to track this issue.

This issue has been fixed in PU49. The classes are public and available to extend, and the related documentation is updated.

Is there any plan to provide a backport of this to 10.0.23 / 24? We want to move to 10.0.24 but are currently blocked by this bug.


Add e2e testing

This PR added e2e testing using puppeteer, mocha and chai.
remember to yarn. This will download chromium (~70MB mac)
scripts:
test: runs both unit and e2e test
unit: runs unit test
e2e: runs e2e tests
PS: make sure that server is running for e2e tests to work

Thanks @pantharshit00 !


High-energy break of thick_fn should not be 150 keV

Describe the bug
See here
The high-energy break (?) of the thick target single power law emission function is locked to 150 keV. for RHESSI flares where the emission extends beyond 150 keV the break should be variable.
Proposed fix: make it so the break energy takes the max of the given energy array and multiplies it by 10, or something like that.
To Reproduce
No response
Screenshots
No response
System Details
No response
Installation method
No response

Does the thick target function thick_fn have a test associated with it?
I am gonna link a PR. Seems like there aren't any official tests associated with thick_fn, unless I'm missing something.


tap: added generic body matcher

Description:
Added GenericBodyMatcher to tap filter to parse HTTP requests and responses. The matcher may be configured to look for text string or hex bytes.
Risk Level:
Low for tap filter.
Med - modified buffer::search method to limit search to specified number of bytes. This method is used in other parts of the code. Added unit test cases to make sure that there are no side effects.
Testing:
Added unit tests.
Docs Changes:
Yes - updated section with example configs.
Release Notes:
Yes.
Fixes #6107

Could you also add some integration tests, please?

Looks good. Thanks. I would still like to see if the HttpGenericBodyMatcher::onBody function can be broken down into smaller chunks, to make it more readable.

I will take another look at HttpGenericBodyMatcher::onBody to make it more readable. Thanks for reviewing my changes.

@yanavlasov I refactored HttpGenericBodyMatcher::onBody as you suggested.

/lgtm api

@alyssawilk @mattklein123 @yanavlasov I addressed all the comments in this PR and IMHO it is ready for the final review.

Since the last review the following changed:

patterns to be located in http body are stored in shared pointer and individual, per request matchers do not copy the patterns but use list of integers to track which patterns has been found
when searching for patterns which may be spread across two body chunks, shorter patterns start at some offset.
matcher buffers only as many bytes as is the longest pattern not found yet  - 1. When the current longest pattern has been found, the code checks what is the length of the longest pattern still not found yet and starts buffering just that amount of bytes.
added attention section to docs to explain that search for patterns traverses entire http body and may be cpu-intensive.

@envoyproxy/api-shepherds API did not change since the previous approval. I just added a comment to be included in generated docs.


Add 'Option` class to support type check and value check in options

This PR takes over https://github.com/databricks/koalas/pull/738, and this fix was inspired by the PR. So the commit credits to, and is authored by @charlesdong1991.
This PR adds Option class to allow various cases such as type checking, value checking, etc.
See the usage below as a example
Option(
    key='compute.default_index_type',
    doc=(
        "This sets the default index type: sequence, distributed and distributed-sequence."),
    default='sequence',
    types=str,
    check_func=(
        lambda v: v in ('sequence', 'distributed', 'distributed-sequence'),
        "Index type should be one of 'sequence', 'distributed', 'distributed-sequence'."))

cc @charlesdong1991 and @itholic too

is something like: option-name: (default_value, allowed_type, restricted_values) more readable and easier for maintenance? so it practically looks like: display.max_columns: (1000, (None, int), None), if there are some restrictions on values like default_index_type has, so default_index_type : ('sequence', (str), ('str1', 'str2', 'str3'))? and then adjust the check function a bit?

That sounds fine except that restricted_values might has to be a function in that case as well. For instance, value > 0.  As a reference, Spark is doing in a builder pattern like way to cover those possibilities.
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L301-L303
I don't want to make it that complicated here for now .. though.

@HyukjinKwon ahh, i see...
yeah, i prefer to keep things quite simple here as well...

How do you like the current way @charlesdong1991 and @ueshin?

Oops, I am going to squash the commits into one so that it credits to @charlesdong1991

looks really good at first glance!!! @HyukjinKwon i will take a deeper look once i have time, but looks very nice!!
pls don't need to force-push to give credit to me, appreciate a lot, but it's all your work, should be yours!! ^^

Codecov Report

Merging #739 into master will decrease coverage by 2.36%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   94.03%   91.66%   -2.37%
==========================================
  Files          32       32
  Lines        5645     5650       +5
==========================================
- Hits         5308     5179     -129
- Misses        337      471     +134

Impacted Files
Coverage Δ

databricks/koalas/plot.py
93.82% <100%> (-1.18%)
:arrow_down:

databricks/koalas/config.py
100% <100%> (ø)
:arrow_up:

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
77.5% <0%> (-7.5%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/frame.py
94.52% <0%> (-1.71%)
:arrow_down:

databricks/koalas/namespace.py
79.66% <0%> (-1.34%)
:arrow_down:

databricks/koalas/utils.py
97.24% <0%> (-0.69%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2c9ad...76a5480. Read the comment docs.

I am merging this since the release date is tomorrow.


Fix typos

This PR fixes a few typos throughout the repository. I noticed a few typos that were either part of public APIs, or that I didn't know what they should be corrected to:

SimplicationQueueSceneComponent: should be SimplificationQueueSceneComponent, but it looks public
recordChunckSize: should be recordChunkSize, but it looks public
volumetricLightMergePostProces: should be volumetricLightMergePostProcess, but it looks public
supressXRSelectEvents: should be suppressXRSelectEvents, but it looks public
disableSpecatatorMode: should be disableSpectatorMode, but it looks public
dipose: should be dispose, but it looks public
diffuseTexturY: should be diffuseTextureY. This is from the following code:

    @serializeAsTexture("diffuseTexturY")
    private _diffuseTextureY: BaseTexture;

The typo is only in the decorator, so I don't know if changing it would be breaking.

locatRect: located here. I don't know if this spelling is correct, or if it should be localRect, or maybe locateRect?
surexposed: located here, not sure if it's a typo
rewrited: located here. I don't really understand the intent of the sentence due to some grammar issues, so I'm not sure the best way to fix it.
Wwves: located here. Should this be "Waves"?
onFullcreenRequiredObservable: should be onFullscreenRequiredObservable, but it looks public
onEditorFullcreenRequiredObservable: onEditorFullscreenRequiredObservable, but it looks public
shadown: located in a few places, is this a typo? Maybe for shadow or shadows?
shadowSpotlLightConfiguration: I think it should be shadowSpotlightConfiguration, but it looks public
SphericalPolynomalCoefficients: should be SphericalPolynomialCoefficients, but it looks public
rotatquatRotationY: is this a typo?

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

There is no need to update the "what's new.md" file. A changelog will be generated using the PR and its tags.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

There is no need to update the "what's new.md" file. A changelog will be generated using the PR and its tags.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13571/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13571/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13571/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13571/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13571/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13571/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13571/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13571/merge#BCU1XR#0

This PR fixes a few typos throughout the repository. I noticed a few typos that were either part of public APIs, or that I didn't know what they should be corrected to:

SimplicationQueueSceneComponent: should be SimplificationQueueSceneComponent, but it looks public

Public, I would rather not change it. But you are right :-)

recordChunckSize: should be recordChunkSize, but it looks public

Same. As for all public APIs - either we define a deprecated getter for them (in case of members or getters), or sadly leave them as they are

dipose: should be dispose, but it looks public

we have a dipose function somewhere? this would feel like a bug.

diffuseTexturY: should be diffuseTextureY. This is from the following code:

    @serializeAsTexture("diffuseTexturY")
    private _diffuseTextureY: BaseTexture;

The typo is only in the decorator, so I don't know if changing it would be breaking.

I would consider that a bug - we should change that.

locatRect: located here. I don't know if this spelling is correct, or if it should be localRect, or maybe locateRect?

should be local

surexposed: located here, not sure if it's a typo
rewrited: located here. I don't really understand the intent of the sentence due to some grammar issues, so I'm not sure the best way to fix it.

is rewritten, instead of be rewrited. But I think the 2nd half of the sentence is not really needed TBH. Keep it as is for now.

Wwves: located here. Should this be "Waves"?

Waves for sure :-)

shadown: located in a few places, is this a typo? Maybe for shadow or shadows?

Shadows, probably. depending on the context.

rotatquatRotationY: is this a typo?

is this public? yes - this must be a typo

we have a dipose function somewhere? this would feel like a bug.

https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/dev/gui/src/2D/controls/inputTextArea.ts#L1224

Shadows, probably. depending on the context.

https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/configuration/interfaces/lightConfiguration.ts#L13
https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/managers/sceneManager.ts#L1386

is this public? yes - this must be a typo

No, it's a variable name.
https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/labs/viewerLabs.ts#L129
https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/managers/sceneManager.ts#L874

we have a dipose function somewhere? this would feel like a bug.

https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/dev/gui/src/2D/controls/inputTextArea.ts#L1224

Shadows, probably. depending on the context.

https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/configuration/interfaces/lightConfiguration.ts#L13
https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/managers/sceneManager.ts#L1386

is this public? yes - this must be a typo

No, it's a local variable name.
https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/labs/viewerLabs.ts#L129
https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/managers/sceneManager.ts#L874

oh, all of these can be changed :-)
dispose (a bug), shadowsEnabled (a bug), shadowsMap, quaternionRotationY

And once again, thank you so much for all the time invested in this!

No problem! A bit busy atm, but I'll try to make the new changes within the next few days.

Moving this to draft for the time being, will move it back when you have the time :-)

@Lioness100 were you able to check the perf impact of the PR ?

@Lioness100 do you have any updates on this PR ?

Closing for now and let s reopen if it gets updated.


Add setting to disable the git apply step in test patch

For a long time Gitea has tested PR patches using a git apply --check method, and in fact prior to the introduction of a read-tree assisted three-way merge in #18004, this was the only way of checking patches.
Since #18004, the git apply --check method has been a fallback method, only used when the read-tree three-way merge method has detected a conflict. The read-tree assisted three-way merge method is much faster and less resource intensive method of detecting conflicts. #18004 kept the git apply method around because it was thought possible that this fallback might be able to rectify conflicts that the read-tree three-way merge detected. I am not certain if this could ever be the case.
Given the uncertainty here and the now relative stability of the read-tree method - this PR makes using this fallback optional and disables it by default. The hope is that users will not notice any significant difference in conflict detection and we will be able to remove the git apply fallback in future, and/or improve the read-tree three-way merge method to catch any conflicts that git apply method might have been able to fix.
An additional benefit is that patch checking should be significantly less resource intensive and much quicker.
(See https://github.com/go-gitea/gitea/issues/22083#issuecomment-1347961737)
Ref #22083
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

yup

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a89b399). Click here to learn what that means.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main   #22130   +/-   ##
=======================================
  Coverage        ?   48.14%
=======================================
  Files           ?     1043
  Lines           ?   142190
  Branches        ?        0
=======================================
  Hits            ?    68458
  Misses          ?    65555
  Partials        ?     8177

Impacted Files
Coverage Δ

modules/setting/repository.go
55.71% <ø> (ø)

services/pull/patch.go
33.56% <90.90%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Please send backport

Please send backport

I guess the question here is how should we backport?

I think we could backport the whole PR as is - but it's potentially breaking as whilst I'm fairly sure that the git apply backend isn't able to deconflict patches that the read-tree patch checker has found are conflicted, I don't really know.
Another option is to backport but with the default setting the other way round - so that people who want to test can do so.
An additional thing we could do is add some explicit logging/metric counter to the patch checker so that if the git apply route was able to deconflict things we got some warning?

How about just disable it with no option?

Patch checking is a critical part of Gitea we really should be cautious with changes here.


Replace infiltrate with sonalyzed

Following up on a remark in #434 and as part of #379 we should abandon the infiltrate daemon (as we are getting rid of exfiltrate) and instead add commands to sonalyze, and then let sonalyzed handle ingestion.  There are only two commands in infiltrate we care about, sonar-freecsv and sysinfo.  These should become sonalyze commands store-events and store-sysinfo.  The win here would be that there is a single interface to the data store, and it can hide the implementation of the store, perform proper locking and optimization, and so on.

The API is a little tricky because sonalyze does not deal with 'cluster', so the authentication and authorization logic for ingestion must be lifted up to sonalyzed, which will acquire roughly the -auth-file and -match-user-and-cluster arguments from infiltrate, with appropriate names.  Maybe.  The cluster is not in the data so there's no reason to parse those.  Observe that in the current infiltrate code, the test for cluster in the body of sonarFreeCsv can be hoisted, which I think is what we're looking for.
With that taken care of we should simply have
sonalyze store-events --data-path dirname

which will read data from stdin and distribute them into files in the same way they are distributed by infiltrate now.


No wallet options when selecting wallet

Describe the bug
The wallet options are nowhere to be found where pressing select wallet button. Moreover, if we pressed Get Started the error which will be posted below will occur.
To Reproduce
Steps to reproduce the behavior:

Go to 'http://localhost:4000/#/home'

Click on 'Select Wallet'

See error

Uncaught TypeError: Cannot read properties of undefined (reading 'adapter')
    at onClick (WalletModal.mjs?8e84:122:61)
    at HTMLUnknownElement.callCallback (react-dom.development.js?ac89:3945:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js?ac89:3994:1)
    at invokeGuardedCallback (react-dom.development.js?ac89:4056:1)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js?ac89:4070:1)
    at executeDispatch (react-dom.development.js?ac89:8243:1)
    at processDispatchQueueItemsInOrder (react-dom.development.js?ac89:8275:1)
    at processDispatchQueue (react-dom.development.js?ac89:8288:1)
    at dispatchEventsForPlugins (react-dom.development.js?ac89:8299:1)
    at eval (react-dom.development.js?ac89:8508:1)
    at batchedEventUpdates$1 (react-dom.development.js?ac89:22396:1)
    at batchedEventUpdates (react-dom.development.js?ac89:3745:1)
    at dispatchEventForPluginEventSystem (react-dom.development.js?ac89:8507:1)
    at attemptToDispatchEvent (react-dom.development.js?ac89:6005:1)
    at dispatchEvent (react-dom.development.js?ac89:5924:1)
    at unstable_runWithPriority (scheduler.development.js?bcd2:468:1)
    at runWithPriority$1 (react-dom.development.js?ac89:11276:1)
    at discreteUpdates$1 (react-dom.development.js?ac89:22413:1)
    at discreteUpdates (react-dom.development.js?ac89:3756:1)
    at dispatchDiscreteEvent (react-dom.development.js?ac89:5889:1)
next-dev.js?3515:25 You have tried to  read "wallets" on a WalletContext without providing one. Make sure to render a WalletProvider as an ancestor of the component that uses WalletContext
    at WalletModal (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModal.mjs:21:24)
    at WalletModalProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModalProvider.mjs:11:32)
    at WalletProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/WalletProvider.mjs:21:27)
    at ConnectionProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/ConnectionProvider.mjs:11:31)
    at Wallet (webpack-internal:///./components/Wallet.tsx:28:66)
    at div
    at header
    at div
    at PostLoginHeader (webpack-internal:///./components/PostLogin/PostLoginHeader.tsx:18:27)
    at div
    at TrackVisibility (webpack-internal:///./node_modules/react-on-screen/lib/TrackVisibility.js:30:28)
    at div
    at Home (webpack-internal:///./components/PostLogin/Home.tsx:24:62)
    at Routes (webpack-internal:///./node_modules/react-router/index.js:920:5)
    at div
    at Router (webpack-internal:///./node_modules/react-router/index.js:854:15)
    at HashRouter (webpack-internal:///./node_modules/react-router-dom/index.js:152:5)
    at StartingPage
    at div
    at MyApp (webpack-internal:///./pages/_app.tsx:42:27)
    at ErrorBoundary (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:20746)
    at ReactDevOverlay (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:23395)
    at Container (webpack-internal:///./node_modules/next/dist/client/index.js:323:9)
    at AppContainer (webpack-internal:///./node_modules/next/dist/client/index.js:820:26)
    at Root (webpack-internal:///./node_modules/next/dist/client/index.js:944:27)
window.console.error @ next-dev.js?3515:25
next-dev.js?3515:25 You have tried to  read "publicKey" on a WalletContext without providing one. Make sure to render a WalletProvider as an ancestor of the component that uses WalletContext
    at WalletMultiButton (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletMultiButton.mjs:19:30)
    at div
    at WalletModalProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModalProvider.mjs:11:32)
    at WalletProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/WalletProvider.mjs:21:27)
    at ConnectionProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/ConnectionProvider.mjs:11:31)
    at Wallet (webpack-internal:///./components/Wallet.tsx:28:66)
    at div
    at header
    at div
    at PostLoginHeader (webpack-internal:///./components/PostLogin/PostLoginHeader.tsx:18:27)
    at div
    at TrackVisibility (webpack-internal:///./node_modules/react-on-screen/lib/TrackVisibility.js:30:28)
    at div
    at Home (webpack-internal:///./components/PostLogin/Home.tsx:24:62)
    at Routes (webpack-internal:///./node_modules/react-router/index.js:920:5)
    at div
    at Router (webpack-internal:///./node_modules/react-router/index.js:854:15)
    at HashRouter (webpack-internal:///./node_modules/react-router-dom/index.js:152:5)
    at StartingPage
    at div
    at MyApp (webpack-internal:///./pages/_app.tsx:42:27)
    at ErrorBoundary (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:20746)
    at ReactDevOverlay (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:23395)
    at Container (webpack-internal:///./node_modules/next/dist/client/index.js:323:9)
    at AppContainer (webpack-internal:///./node_modules/next/dist/client/index.js:820:26)
    at Root (webpack-internal:///./node_modules/next/dist/client/index.js:944:27)
window.console.error @ next-dev.js?3515:25
next-dev.js?3515:25 You have tried to  read "wallet" on a WalletContext without providing one. Make sure to render a WalletProvider as an ancestor of the component that uses WalletContext
    at WalletMultiButton (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletMultiButton.mjs:19:30)
    at div
    at WalletModalProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModalProvider.mjs:11:32)
    at WalletProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/WalletProvider.mjs:21:27)
    at ConnectionProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/ConnectionProvider.mjs:11:31)
    at Wallet (webpack-internal:///./components/Wallet.tsx:28:66)
    at div
    at header
    at div
    at PostLoginHeader (webpack-internal:///./components/PostLogin/PostLoginHeader.tsx:18:27)
    at div
    at TrackVisibility (webpack-internal:///./node_modules/react-on-screen/lib/TrackVisibility.js:30:28)
    at div
    at Home (webpack-internal:///./components/PostLogin/Home.tsx:24:62)
    at Routes (webpack-internal:///./node_modules/react-router/index.js:920:5)
    at div
    at Router (webpack-internal:///./node_modules/react-router/index.js:854:15)
    at HashRouter (webpack-internal:///./node_modules/react-router-dom/index.js:152:5)
    at StartingPage
    at div
    at MyApp (webpack-internal:///./pages/_app.tsx:42:27)
    at ErrorBoundary (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:20746)
    at ReactDevOverlay (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:23395)
    at Container (webpack-internal:///./node_modules/next/dist/client/index.js:323:9)
    at AppContainer (webpack-internal:///./node_modules/next/dist/client/index.js:820:26)
    at Root (webpack-internal:///./node_modules/next/dist/client/index.js:944:27)

Desktop (please complete the following information):

OS: Windows
Browser  chrome
Version:100.0.4896.127 (Official Build) (64-bit)

Additional context
The code to the repo is as followed => https://github.com/DitJee/Roblox-Marketplace-Clone/blob/main/Frontend/frontend-react-app/components/Wallet.tsx

Describe the bug The wallet options are nowhere to be found where pressing select wallet button. Moreover, if we pressed Get Started the error which will be posted below will occur.
To Reproduce Steps to reproduce the behavior:

Go to 'http://localhost:4000/#/home'

Click on 'Select Wallet'

See error

Uncaught TypeError: Cannot read properties of undefined (reading 'adapter')
    at onClick (WalletModal.mjs?8e84:122:61)
    at HTMLUnknownElement.callCallback (react-dom.development.js?ac89:3945:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js?ac89:3994:1)
    at invokeGuardedCallback (react-dom.development.js?ac89:4056:1)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js?ac89:4070:1)
    at executeDispatch (react-dom.development.js?ac89:8243:1)
    at processDispatchQueueItemsInOrder (react-dom.development.js?ac89:8275:1)
    at processDispatchQueue (react-dom.development.js?ac89:8288:1)
    at dispatchEventsForPlugins (react-dom.development.js?ac89:8299:1)
    at eval (react-dom.development.js?ac89:8508:1)
    at batchedEventUpdates$1 (react-dom.development.js?ac89:22396:1)
    at batchedEventUpdates (react-dom.development.js?ac89:3745:1)
    at dispatchEventForPluginEventSystem (react-dom.development.js?ac89:8507:1)
    at attemptToDispatchEvent (react-dom.development.js?ac89:6005:1)
    at dispatchEvent (react-dom.development.js?ac89:5924:1)
    at unstable_runWithPriority (scheduler.development.js?bcd2:468:1)
    at runWithPriority$1 (react-dom.development.js?ac89:11276:1)
    at discreteUpdates$1 (react-dom.development.js?ac89:22413:1)
    at discreteUpdates (react-dom.development.js?ac89:3756:1)
    at dispatchDiscreteEvent (react-dom.development.js?ac89:5889:1)
next-dev.js?3515:25 You have tried to  read "wallets" on a WalletContext without providing one. Make sure to render a WalletProvider as an ancestor of the component that uses WalletContext
    at WalletModal (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModal.mjs:21:24)
    at WalletModalProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModalProvider.mjs:11:32)
    at WalletProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/WalletProvider.mjs:21:27)
    at ConnectionProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/ConnectionProvider.mjs:11:31)
    at Wallet (webpack-internal:///./components/Wallet.tsx:28:66)
    at div
    at header
    at div
    at PostLoginHeader (webpack-internal:///./components/PostLogin/PostLoginHeader.tsx:18:27)
    at div
    at TrackVisibility (webpack-internal:///./node_modules/react-on-screen/lib/TrackVisibility.js:30:28)
    at div
    at Home (webpack-internal:///./components/PostLogin/Home.tsx:24:62)
    at Routes (webpack-internal:///./node_modules/react-router/index.js:920:5)
    at div
    at Router (webpack-internal:///./node_modules/react-router/index.js:854:15)
    at HashRouter (webpack-internal:///./node_modules/react-router-dom/index.js:152:5)
    at StartingPage
    at div
    at MyApp (webpack-internal:///./pages/_app.tsx:42:27)
    at ErrorBoundary (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:20746)
    at ReactDevOverlay (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:23395)
    at Container (webpack-internal:///./node_modules/next/dist/client/index.js:323:9)
    at AppContainer (webpack-internal:///./node_modules/next/dist/client/index.js:820:26)
    at Root (webpack-internal:///./node_modules/next/dist/client/index.js:944:27)
window.console.error @ next-dev.js?3515:25
next-dev.js?3515:25 You have tried to  read "publicKey" on a WalletContext without providing one. Make sure to render a WalletProvider as an ancestor of the component that uses WalletContext
    at WalletMultiButton (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletMultiButton.mjs:19:30)
    at div
    at WalletModalProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModalProvider.mjs:11:32)
    at WalletProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/WalletProvider.mjs:21:27)
    at ConnectionProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/ConnectionProvider.mjs:11:31)
    at Wallet (webpack-internal:///./components/Wallet.tsx:28:66)
    at div
    at header
    at div
    at PostLoginHeader (webpack-internal:///./components/PostLogin/PostLoginHeader.tsx:18:27)
    at div
    at TrackVisibility (webpack-internal:///./node_modules/react-on-screen/lib/TrackVisibility.js:30:28)
    at div
    at Home (webpack-internal:///./components/PostLogin/Home.tsx:24:62)
    at Routes (webpack-internal:///./node_modules/react-router/index.js:920:5)
    at div
    at Router (webpack-internal:///./node_modules/react-router/index.js:854:15)
    at HashRouter (webpack-internal:///./node_modules/react-router-dom/index.js:152:5)
    at StartingPage
    at div
    at MyApp (webpack-internal:///./pages/_app.tsx:42:27)
    at ErrorBoundary (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:20746)
    at ReactDevOverlay (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:23395)
    at Container (webpack-internal:///./node_modules/next/dist/client/index.js:323:9)
    at AppContainer (webpack-internal:///./node_modules/next/dist/client/index.js:820:26)
    at Root (webpack-internal:///./node_modules/next/dist/client/index.js:944:27)
window.console.error @ next-dev.js?3515:25
next-dev.js?3515:25 You have tried to  read "wallet" on a WalletContext without providing one. Make sure to render a WalletProvider as an ancestor of the component that uses WalletContext
    at WalletMultiButton (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletMultiButton.mjs:19:30)
    at div
    at WalletModalProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react-ui/lib/esm/WalletModalProvider.mjs:11:32)
    at WalletProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/WalletProvider.mjs:21:27)
    at ConnectionProvider (webpack-internal:///./node_modules/@solana/wallet-adapter-react/lib/esm/ConnectionProvider.mjs:11:31)
    at Wallet (webpack-internal:///./components/Wallet.tsx:28:66)
    at div
    at header
    at div
    at PostLoginHeader (webpack-internal:///./components/PostLogin/PostLoginHeader.tsx:18:27)
    at div
    at TrackVisibility (webpack-internal:///./node_modules/react-on-screen/lib/TrackVisibility.js:30:28)
    at div
    at Home (webpack-internal:///./components/PostLogin/Home.tsx:24:62)
    at Routes (webpack-internal:///./node_modules/react-router/index.js:920:5)
    at div
    at Router (webpack-internal:///./node_modules/react-router/index.js:854:15)
    at HashRouter (webpack-internal:///./node_modules/react-router-dom/index.js:152:5)
    at StartingPage
    at div
    at MyApp (webpack-internal:///./pages/_app.tsx:42:27)
    at ErrorBoundary (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:20746)
    at ReactDevOverlay (webpack-internal:///./node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:23395)
    at Container (webpack-internal:///./node_modules/next/dist/client/index.js:323:9)
    at AppContainer (webpack-internal:///./node_modules/next/dist/client/index.js:820:26)
    at Root (webpack-internal:///./node_modules/next/dist/client/index.js:944:27)

Desktop (please complete the following information):

OS: Windows
Browser  chrome
Version:100.0.4896.127 (Official Build) (64-bit)

Additional context The code to the repo is as followed => https://github.com/DitJee/Roblox-Marketplace-Clone/blob/main/Frontend/frontend-react-app/components/Wallet.tsx

Ran into this same problem. Curious if @DitJee found a solution?

@DitJee  did you ever figure out the solution to this problem?

@ElasticBottle Hi there!
I did find the solution which is to update the react project to the latest version.
Hope this will work for you too!

Sweet, will try that thanks! I'm assuming you're on react ^18?

Sweet, will try that thanks! I'm assuming you're on react ^18?

Yes, I'm on react: 18.1.0

i tried updating to latest react and still no luck. did you do anything else after updating?

@kevinz420 try starting from an empty project and see if it work or not. Cus in my case, updating the react version alone did not work. I had to start a new project and move all files from the old to the new one.

I know this is already closed, however I want to contribute to this as I found a similar problem and managed to solve it. I noticed that in my setup I was getting the error: "You have tried to ## on a WalletContext without providing one...", turns out it was because the useWallet context was duplicated, libraries have two separate build folders, 'esm' and 'cjs', the library was importing from cjs while my app was importing from esm, creating two instances.
To fix it I had to import the library with the suffix /lib/cjs.
Hope this helps some people out.

All packages have been updated: https://twitter.com/jordaaash/status/1541927694786600961
The library now supports React 17 and 18, and there's a Create React App 5 starter project. Please try again!

I know this is already closed, however I want to contribute to this as I found a similar problem and managed to solve it. I noticed that in my setup I was getting the error: "You have tried to ## on a WalletContext without providing one...", turns out it was because the useWallet context was duplicated, libraries have two separate build folders, 'esm' and 'cjs', the library was importing from cjs while my app was importing from esm, creating two instances.
To fix it I had to import the library with the suffix /lib/cjs.
Hope this helps some people out.

thanks for sharing! i'm getting the same issue too. could you explain how you debugged the duplicate context?

@sunlee-newyork what versions of the packages are you running?

@sunlee-newyork what versions of the packages are you running?

"@solana/wallet-adapter-base": "^0.9.18",
"@solana/wallet-adapter-material-ui": "^0.16.16",
"@solana/wallet-adapter-react": "^0.15.21-rc.0",
"@solana/wallet-adapter-react-ui": "^0.9.18",
"@solana/wallet-adapter-wallets": "^0.19.2",
<EMAIL_ADDRESS>"^1.31.0",

Ah, do this: https://twitter.com/jordaaash/status/1581804816979808258
The RC of the wallet-adapter-react package is conflicting with the version of the same package that wallet-adapter-material-ui and wallet-adapter-react-ui are using. Overriding it will fix them.
Also, you probably don't want both the React UI and Material UI packages?

Ah, do this: https://twitter.com/jordaaash/status/1581804816979808258
The RC of the wallet-adapter-react package is conflicting with the version of the same package that wallet-adapter-material-ui and wallet-adapter-react-ui are using. Overriding it will fix them.
Also, you probably don't want both the React UI and Material UI packages?

ah that was it, thanks. and yes i was migrating from wallet-adapter-react-ui to wallet-adapter-material-ui thanks for the reminder

I ran into the same issue just copy & pasting the example code into a fresh create-react-app skeleton with react-app-rewired installed for the polyfills, then attempting to import useWallet into a child element of the provider.
For me, the issue was resolved by replacing the line const { useWallet } = require("@solana/wallet-adapter-react"); with import { useWallet } from '@solana/wallet-adapter-react';.
I'd already replaced the require statements with import statements elsewhere in my app. Will only work if you're using ES6+.

I had the same problem. Adding the following line to my VITE configuration fixed it. I followed the official integration guide, only difference is I'm using yarn.
  {resolve: {
    alias: {
      '@solana/wallet-adapter-react': path.resolve('./node_modules/@solana/wallet-adapter-react/lib/esm')
    }
  }}


Template generics and final keyword problem in Long Method Extraction

Project : crawler4j (https://github.com/yasserg/crawler4j)
package : edu.uci.ics.crawler4j.crawler
Class name : CrawlController
method name : start
variable criterion : monitorThread
When I refactor this method, the generics from the original method is not added to the refactored method and the final keyword to the parameters is added in the extracted method.
Original method signature : protected <T extends WebCrawler> void start(final WebCrawlerFactory<T> crawlerFactory, final int numberOfCrawlers, boolean isBlocking)
After refactoring : private Thread monitorThread(CrawlController.WebCrawlerFactory<T> crawlerFactory, List<Thread> threads, List<T> crawlers) throws java.lang.Exception, com.sleepycat.je.DatabaseException

The bug has been replicated.
Type parameter <T extends WebCrawler> needs to be added in the extracted method signature.
All parameters of the extracted method should be declared final.


[Feature request]Recording with OpenAL?

More and more games nowadays want to be able to communicate by voice, so is there a more convenient way to exchange voice streams?
Of course, we can use various sdk's, but it would be best if the engine itself provides a recording method (the transfer method we have now with yasio).
For example:
-- send
local recorder = AudioEngine.startRecord(function(stream)
   yasio.send(stream)-- Call back the function at a certain frequency and send the audio stream.
end);
...
...
if when_i_want_stop then
    AudioEngine.stopRecord(recorder);
end

-- recv
local audioStream = AudioEngine.createAudioStream()
local audio = AudioEngine.play2d(audioStream);
...
...
yasio.recv(function(stream)
    audioStream.append(stream)-- When a new audio stream is appended, it will be played automatically.
end);
...
...
if when_i_want_stop then
    AudioEngine.stop(audio);
end

This is an immature idea, but I think it should be possible.

Should be a long story


feat(core): support direction in notification

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?
Part of #414
What is the new behavior?
https://user-images.githubusercontent.com/12021443/157451516-303d77cc-4fbc-4f0b-ba2b-aa172fde56f0.mov
Does this PR introduce a breaking change?

[ ] Yes
[x] No

useless


feat: support fastify

path-to-regexp deprecated the usage of * for a wildcard route:

No wildcard asterisk (*) - use parameters instead ((.*) or :splat*)

Closes: https://github.com/mikro-orm/nestjs/issues/3

This will break nest with express, I already tried.

Perhaps we can pass in the path as a config option, forRoutesPath (or equivalent)?
const forRoutesPath = this.options.forRoutesPath || '*';

consumer
       .apply(MikroOrmMiddleware) // register request context automatically
       .forRoutes({ path: forRoutesPath, method: RequestMethod.ALL });

It's also be possible to detect Fastify by the consumer.httpAdapter which is of type FastifyAdapter. That way, we can automatically apply the suggested forRoutesPath with Fastify users. I am unaware if there's a generic approach for detecting the underlying path-to-regexp version, but having Express and Fastify seems like a solid start!
const isFastify = consumer.httpAdapter?.instance?.hasReplyDecorator === 'function' ?? false;
const forRoutesPath = this.options.forRoutesPath || (isFastify ? '(.*)' : '*')
consumer
        .apply(MikroOrmMiddleware) // register request context automatically
        .forRoutes({ path: forRoutesPath, method: RequestMethod.ALL });

I chose hasReplyDecorator because there are no references to that function anywhere on Express. hasReplyDecorator was introduced in May 2018. For reference, here is my console.log of consumer.httpAdapter.instance.
httpAdapter: FastifyAdapter {
    instance: <ref *1> {
      delete: [Function: _delete],
      get: [Function: _get],
      head: [Function: _head],
      patch: [Function: _patch],
      post: [Function: _post],
      put: [Function: _put],
      options: [Function: _options],
      all: [Function: _all],
      route: [Function: _route],
      log: [Pino],
      addHook: [Function: addHook],
      addSchema: [Function: addSchema],
      getSchema: [Function: bound ],
      getSchemas: [Function: bound ],
      setValidatorCompiler: [Function: setValidatorCompiler],
      setSerializerCompiler: [Function: setSerializerCompiler],
      setReplySerializer: [Function: setReplySerializer],
      addContentTypeParser: [Function: addContentTypeParser],
      hasContentTypeParser: [Function: hasContentTypeParser],
      register: [Function (anonymous)],
      after: [Function (anonymous)],
      ready: [Function: ready],
      onClose: [Function (anonymous)],
      close: [Function (anonymous)],
      listen: [Function: listen],
      server: [Server],
      decorate: [Function: decorateFastify],
      hasDecorator: [Function: checkExistence],
      decorateReply: [Function: decorateReply],
      decorateRequest: [Function: decorateRequest],
      hasRequestDecorator: [Function: checkRequestExistence],
      hasReplyDecorator: [Function: checkReplyExistence],
      inject: [Function: inject],
      printRoutes: [Function: bound ],
      setNotFoundHandler: [Function: setNotFoundHandler],
      setErrorHandler: [Function: setErrorHandler],
      initialConfig: [Object],
      use: [Function: use],
      jwt: [Object],
      [Symbol(fastify.state)]: [Object],
      [Symbol(fastify.options)]: [Object],
      [Symbol(fastify.children)]: [Array],
      [Symbol(fastify.bodyLimit)]: 1048576,
      [Symbol(fastify.routePrefix)]: '',
      [Symbol(fastify.logLevel)]: '',
      [Symbol(fastify.logSerializers)]: null,
      [Symbol(fastify.hooks)]: [Hooks],
      [Symbol(fastify.schemas)]: [Schemas],
      [Symbol(fastify.validatorCompiler)]: null,
      [Symbol(fastify.serializerCompiler)]: null,
      [Symbol(fastify.replySerializerDefault)]: null,
      [Symbol(fastify.contentTypeParser)]: [ContentTypeParser],
      [Symbol(fastify.Reply)]: [Function: _Reply],
      [Symbol(fastify.Request)]: [Function: _Request],
      [Symbol(fastify.404)]: [Object],
      [Symbol(registered-plugin)]: [Array],
      [Symbol(fastify.pluginNameChain)]: [Array],
      [Symbol(fastify.avvioBoot)]: [Function (anonymous)],
      [Symbol(kAvvio)]: true,
      [Symbol(fastify.canSetNotFoundHandler)]: true,
      [Symbol(fastify.404ContextKey)]: [Context],
      [Symbol(fastify.404LogLevelInstance)]: [Circular *1],
      [Symbol(fastify-middie-middlewares)]: [],
      [Symbol(fastify-middie-instance)]: [Object]
    },

I'd say we should combine both of those approaches, having path configurable as well as picking the right default value based on the adapter.
I would rather check the adapter class name, something like this:
const isFastify = consumer.httpAdapter?.constructor.name.toLowerCase().includes('fastify') ?? false;

WDYT?

Can confirm on Fastify v3 that this works:
const isFastify = consumer.httpAdapter?.constructor.name.toLowerCase().startsWith('fastify') ?? false;

I like this approach! I wasn't sure on a clean detection of Fastify. I can't conveniently confirm with tests, but I strongly believe that all versions of Fastify support the (.*) syntax. It looks like the (.*) was introduced in path-to-regexp in v1.2.0 in 2015. The only update to path-to-regexp I can see in the Fastify project is to fastify-middie from path-to-regexp v2 -> v3, which landed in Fastify v2. Prior to that, it probably was always on path-to-regexp v2, but I haven't looked deeper.
I will write up a PR shortly.

I added generics to fix my local typings in my micro-orm.config.ts.
With the new generic typings, I can type my mikro-orm.config.ts like this:
const config: MikroOrmModuleOptions<PostgreSqlDriver> = {
  // ...
  forRoutesPath: '*',
  // PostgreSqlDriver-specific options...
}

Not sure I follow, there are no postgres specific options (everything is part of the Options interface).

While that is true that there currently are no PostgreSQL-specific driver options, there could be other drivers that have specific options (idk if that's the case currently).
The main reason I did this is that the forRoutesPath is not relevant to the base Options since it's NestJS/Express/Fastify-specific.
Prior to this PR, I had typed my config like this:
const config: Options<PostgreSqlDriver> = {
 // ...
}

While there are currently no driver-specific options, the typing on Options lead me to believe that it was useful to include the extra generic parameter for type-safety in the future.
Since Options doesn't need forRoutesPath and MikroOrmModuleOptions extending Options, it seems appropriate to add the additional type-safety by introducing the generic typing to the MikroOrmModuleOptions and forwarding that type to Options. Now, we can introduce forRoutesPath at the MikroOrmModuleOptions level and not pollute Options.

Right, now I understand it, I totally forget that the Options type is generic. The reason is not to support additional driver options, nothing users should care about, but as long as there is correct default value, I am fine with that.

Ready for review

4.0.0-alpha.3 is out with this change


Some GIFs from supported hosts not converted

Use this issue to track failures.

Images from Imgur is (this post)[
https://www.resetera.com/threads/sell-a-game-using-gifs.104494/post-18700661] showing up as broken.


Getting the error "expression did not evaluate to a constant" in VS 2015.

Hello.
I am following the compilation procedure that has been posted on the dlib website.
I created an empty project called "bayes". I right-clicked on "Source Files", went to "Existing Item...", then added "source.cpp" to the "Source Files". I saw another question on the forum which stated the same error:
https://github.com/davisking/dlib/issues/194
I went to github and copied and pasted the code for source.cpp and matrix_utilities.h (The error is in this file) from github in my project. Despite that, I have been getting the same error when I run my code.
I right-clicked on the name of the project (bayes), clicked on "Properties", then went to "VC++ Directories" and then in "Include Directories" I added the path of the dlib-19.1 folder.
I even disabled the "Precompiled Headers" option under the "C/C++" heading. I don't understand why I am not able to run my code.
I compiled all the examples using CMake. I am able to open the examples.sln file and run most of the project files present there.
Why can't I run the code when I create an empty project, include all directories and copy and paste the same code in that project?
Waiting eagerly for your response.

Do not spam questions to every possible dlib forum.  It does not increase the probability of getting a useful response.
For your case, you are asking about how to setup a basic C++ project in visual studio, not about dlib.  Since this question has nothing to do with dlib you should ask it elsewhere.  I would suggest finding some forum about visual studio.

Hello Mr.King.
I will be mindful of that in the future. Excuse me for any inconvenience this may have caused you.
My question is very similar to one of the questions in your forum. I had posted the link for that question in my query. I followed your answer to that question but my error wasn't resolved.
The question I am referring to is in the following link:
https://github.com/davisking/dlib/issues/194
I'll greatly appreciate it if you reconsider my question and help me resolve my problem.
Regards,
Abdullah.
Sent from Yahoo Mail on Android


Added PrivateType support.

PrivateObject cannot run static methods but the new PrivateType can.
This corresponds to the PrivateType class of MsTest.
Are you interested in adding this?

Thank you! Awesome contribution!


Bug located in ...Specified version 2022.2 is not known

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
I've downloaded Ansys 2022 R2,when running pyedt, throwing below error
assert specified_version in self.version_keys, "Specified version {} is not known".format(specified_version)
AssertionError: Specified version 2022.2 is not known
Steps To Reproduce
Run below code
import os
from matplotlib import pyplot as plt
import numpy as np
import pyaedt
###############################################################################
Set non-graphical mode
~~~~~~~~~~~~~~~~~~~~~~
Set non-graphical mode, "PYAEDT_NON_GRAPHICAL" is needed to generate
documentation only.
You can set non_graphical either to True or False.
non_graphical = os.getenv("PYAEDT_NON_GRAPHICAL", "False").lower() in ("true", "1", "t")
###############################################################################
Launch AEDT with Circuit
~~~~~~~~~~~~~~~~~~~~~~~~
Launch AEDT 2022 R2 in graphical mode with Circuit.
cir = pyaedt.Circuit(projectname=pyaedt.generate_unique_project_name(),
specified_version="2022.2",
new_desktop_session=True,
non_graphical=non_graphical
)
Which Operating System are you using?
Windows
Which Python version are you using?
3.9
Installed packages
raceback (most recent call last):
File C:\PyAnsys\MAPDL\Circuit_Transient_issue.py:27 in
cir = pyaedt.Circuit(projectname=pyaedt.generate_unique_project_name(),
File ~\anaconda3\lib\site-packages\pyaedt\circuit.py:125 in init
FieldAnalysisCircuit.init(
File ~\anaconda3\lib\site-packages\pyaedt\application\AnalysisNexxim.py:41 in init
Analysis.init(
File ~\anaconda3\lib\site-packages\pyaedt\application\Analysis.py:100 in init
Design.init(
File ~\anaconda3\lib\site-packages\pyaedt\application\Design.py:170 in init
desktop = Desktop(
File ~\anaconda3\lib\site-packages\pyaedt\desktop.py:400 in init
self._main.student_version, version_key, version = self._set_version(specified_version, student_version)
File ~\anaconda3\lib\site-packages\pyaedt\desktop.py:528 in _set_version
assert specified_version in self.version_keys, "Specified version {} is not known".format(specified_version)
AssertionError: Specified version 2022.2 is not known

Hi @kunal-3196 ,
Do you have installed Ansys Electronics Desktop (AEDT) 2022R2? If you install the Ansys package, it is only installing Mechanical and Workbench, AEDT is not included.
If you have it, please try to create a clean virtual environment, do again pip install pyaedt, and try again. Let us know which pyaedt version is using:
import pyaedt
pyaedt.version
And which OS you are using.
Before running an example, just try:
import pyaedt
app = pyaedt.Hfss()
app.release_desktop()

Hi @kunal-3196 ,
was this suggestion helpful?
In case it was, could you please let us know so we can close the issue?
Thanks!
Giulia

Thanks resolved


Request: official Docker image

Could you consider uploading the official image to a registry?
I think you can use this Dockerfile which I'm using for CBI, although it results in very huge image (387MB, uncompressed): https://github.com/containerbuilding/cbi/blob/e488b2e8ea63980b355a7f51f2e170a4b7f0184b/Dockerfile.buildah

@AkihiroSuda sounds cool.
@rhatdan @TomSweeneyRedHat I would like to work on this on my spare time.
Do you mind? :smiley:

Go for it @ripcurld.  I think @ipbabble has played with this a bit,  Might want to touch base with him.

Cool :confetti_ball:

I have one I use for testing, just pushed it to my personal repo:
https://gitlab.com/pixdrift/buildah-scripts/blob/master/el7.buildah.minimal.sh
Built using buildah, wouldn't take much to switch it to a Dockerfile. Resulting image is 234MB due to RPM deps.

@pixdrift this is what I wanted to do... :+1:
I guess what's left to do is to write a build pipeline that:
(a) is triggered every release
(b) executes this script
(c) commits it to DockerHub.

@ripcurld, sounds similar to what i'm cobbling together at the moment.
This container will take a buildah commit and produce an el7 x86_64 rpm. Depending on how you wanted to install buildah in the container, you could always use the resulting RPM from this process.
https://gitlab.com/pixdrift/buildah-scripts/blob/master/el7.buildah.rpmbuild.sh

SGTM

Have you looked at this?
https://www.projectatomic.io/blog/2018/03/building-buildah-container-image-for-kubernetes/
Please reach out to me at wheny @ redhat.com or check for me in the podman channel on IRC freenode

$ more ~/buildah.sh
#! /bin/bash
rel=27
containerid=$(buildah from scratch)
scratchmnt=$(buildah mount $containerid)
dnf install --installroot $scratchmnt --release $rel buildah --setopt install_weak_deps=false -y
dnf clean all --installroot $scratchmnt --release $rel
buildah config --cmd "--help" $containerid
buildah config --entrypoint /usr/bin/buildah $containerid
buildah config --author "wgh @ redhat.com" --created-by "ipbabble" --label name=buildah $containerid
buildah commit $containerid buildah

thank @ipbabble I will contact you soon. :computer:

Any news? ^^

@AkihiroSuda as an FYI, @ipbabble has been doing some serious travelling as of late, but I think he is back soon.

Hi all I'm back. @ripcurld how far did you get?  I will push a new one up to quay.io today.
-ipbabble

I've pushed a new fedora based Buildah image:
podman pull quay.io/ipbabble/buildah
Based on fedora release 28.

I used dnf install with following options:
 --setopt install_weak_deps=false --nodocs

Then did a clean all and a autoremove
dnf clean all --installroot $scratchmnt --release $rel
dnf autoremove --installroot $scratchmnt --release $rel

@AkihiroSuda I think @ipbabble has setup an image for you.  I'm going to close this issue.  Please reopen this issue or a create a new one if you've concerns.


Property ScannedAt

Introduce ScannedAt set to timestamp of insertion. Should be also shown in UI and kann be queried via MQTT topic product/barcode/get_ScannedAt

added in https://github.com/Isotop7/isgood/commit/28952160aea17d1ca77253802c149ec097ebbe2c


Code Assistance - Quick Popup , last instruction is not working.

I'm using IntelliJ IDEA 2016.2 for mac.
The last instruction that says "see the definition of the symbol at the caret"  is not functional. I have to skip this Lesson in order to navigate to next lesson.

Sorry, it should work in the last versions.


Add documentation and examples on ZIO microsite for Queue

I'll work on this one.

Here is a good example @ghostdogpr - Elevator System


Fallback to ticker prices per currency pair

Currently the price-feeder will only fallback to using ticker prices if no candle prices exist (https://github.com/ojo-network/price-feeder/blob/main/oracle/oracle.go#L310). It should fallback to using ticker prices on a per currency pair - or at least a per provider basis.

This is closed :^)


How to add more blur to "blur transformation"?

the blur effect is not blurry enough, how can i  adjust the amount of blur?

You have to increase the radius of the blur to more than 25 but, it's crashes my app if I do that. I also have the same issue. Need to add more blur and I know that it can be done by increasing the radius. Just don't know how to increase it in the code. Finding, if someone can help here.


add carthage support and use promises

[x] Carthage support
[x] handle errors using promises
[x] write tests where possible

Very cool, one question - is the readme up to date?

forgot

I can't find the new API with future in the readme: https://github.com/exchangegroup/load-facebook-profile-ios-swift/blob/feature/carthage-and-future/README.md
Do we need to add it there for other people?

you are looking at the wrong branch (master)

:rocket:


fails to access with the same user

when reconnecting with the same username and the others it still appears as disconnected, but I can send messages without any problem but others can not answer

Did u solve it?

this bug  still comes out in CS project, pls have to check and advice.
thanks

@SaddamBInSyed


Create isefac.txt

French school, Website is http://isefac.org

@DemisBand Pull request merged. Thank you!


HADOOP-16637. Fix findbugs warnings in hadoop-cos.

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

Most of the changes look good; that input stream cleanup looks like it will break the code as a closed stream will always get passed along to the next method. The findbugs file probably just needs changing.
Which endpoint did you run the tests against?

Most of the changes look good; that input stream cleanup looks like it will break the code as a closed stream will always get passed along to the next method. The findbugs file probably just needs changing.
Which endpoint did you run the tests against?

We just ran the findbugs for the file.

ok. You need to run the full test suite against a live service and declare which location/endpoint you tested with
that's the policy for all object store patches I'm afraid -Yetus can't be given the credentials and yet we need to stop regressions creeping in. Sorry

Thanks @steveloughran for the comment.
I'm going to run the related tests.

Hi @cxorm, how is this issue going?

Thanks @aajisaka for the review.
And we test the patch with our cluster for at least 30 days without any error.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
24m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 26s
trunk passed

+1 :green_heart:
compile
0m 24s
trunk passed

+1 :green_heart:
checkstyle
0m 21s
trunk passed

+1 :green_heart:
mvnsite
0m 26s
trunk passed

+1 :green_heart:
shadedclient
14m 53s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
trunk passed

+0 :ok:
spotbugs
0m 38s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
0m 36s
hadoop-cloud-storage-project/hadoop-cos in trunk has 5 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s
the patch passed

+1 :green_heart:
compile
0m 16s
the patch passed

+1 :green_heart:
javac
0m 16s
the patch passed

-0 :warning:
checkstyle
0m 13s
hadoop-cloud-storage-project/hadoop-cos: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
mvnsite
0m 18s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 40s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 21s
the patch passed

+1 :green_heart:
findbugs
0m 40s
hadoop-cloud-storage-project/hadoop-cos generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5)

_ Other Tests _

+1 :green_heart:
unit
0m 19s
hadoop-cos in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

79m 16s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1640/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1640

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 35751b260277 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3d5ade1

Default Java
1.8.0_242

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1640/2/artifact/out/branch-findbugs-hadoop-cloud-storage-project_hadoop-cos-warnings.html

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1640/2/artifact/out/diff-checkstyle-hadoop-cloud-storage-project_hadoop-cos.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1640/2/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-cloud-storage-project/hadoop-cos U: hadoop-cloud-storage-project/hadoop-cos

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1640/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Hi @cxorm there is still 1 findbugs warning, would you check this?
https://builds.apache.org/job/hadoop-multibranch/job/PR-1640/2/artifact/out/patch-findbugs-hadoop-cloud-storage-project_hadoop-cos-warnings.html
In addition, would you fix the following checkstyle issues?
https://builds.apache.org/job/hadoop-multibranch/job/PR-1640/2/artifact/out/diff-checkstyle-hadoop-cloud-storage-project_hadoop-cos.txt
Sorry for the late response.


Add  Postgres environment resolve 'Waiting for DB'

Thanks, but we're gonna fix the app so it properly auths.

Thanks, but we're gonna fix the app so it properly auths.

When will this be fixed?


Can I construct my own request for testing?

My Hubot (Gifbot) is working all right. Is there a way for me to send a self constructed request (via postman or some cURL request) to the coffee script? If yes, please can someone guide me?

It's not clear what the purpose and content of your request would be, if you want to send something to the bot for it to process and act upon by sending a message or something similar that's known as a webhook.  You can find more details here.
There's a limit to what you can easily do in response to a message, hopefully the necessary functionality is either available via hubot itself e.g. sending a simple message, otherwise you can any of the methods exposed in the Adaptor such as sendDirectMessageToEmail as shown here.


bring back p2p logger

it got dropped accidentally, but it is very useful for debugging connectivity problems

bors merge


[5.9🍒] temporarily prevent Copyable types from using consuming and borrowing

• Description: Copyable types with borrowing and consuming ownership specifiers are expected to have implicit copying behaviors disabled in the future, but today they permit implicit copies. This PR makes it an error to use those ownership specifiers for now, until we have the intended behavior in-place. The goal is to prevent future source breaks.
• Risk: Early adopters will not be able to compile and receive errors. They will need to know to use the unofficial __owned and __shared as alternatives to not break ABI, as simply removing the ownership annotation can lead to ABI breaks.
• Original PR: https://github.com/apple/swift/pull/65570
• Reviewed By: pending
• Testing: regression tests included.
• Resolves: rdar://108538971

@swift-ci please test


Add "go-prompt" on README

Hi @jonathanslenders !
First of all, thanks for this awesome library.
I develop an interactive prompt library in Go which is inspired by python-prompt-tolkit.
https://github.com/c-bata/go-prompt
I know this doesn't match a project using python-prompt-toolkit, but I'd like to ask for your consideration.
Thanks.

Hi @c-bata, this looks really nice!
Added here: https://github.com/jonathanslenders/python-prompt-toolkit/commit/6805c0756b6285969a0dc55226025d32688e5109

I'm honored that go-prompt is on python-prompt-toolkit's README.
Thanks!


Failed to Connect to CRM 365 via XRM Toolkit

RESOLVED
Sharing the issue here per request WaelHamze via tweet as the issue was originally raised on codeplex, which is the repository for 2013, and our issue is related to CRM 365 Online. Screen Cap
KhanPinewood wrote Mon at 3:24 AM
First of all thanks for sharing this really wonderful tool. Since our team has started using SDK 8.x ,i was trying to use your new 8.1 based XRM framework scripts . But i am continuosly getting this error even with Ping command
Select-WhoAmI : Object reference not set to an instance of an object.
At C:\XXX\xRMCIFramework_8.0.17\Ping.ps1:26 char:18
... utingUser = Select-WhoAmI -ConnectionString $CrmConnectionString -Ver ...
CategoryInfo : NotSpecified: (:) [Select-WhoAmI], NullReferenceException
FullyQualifiedErrorId : System.NullReferenceException,Xrm.Framework.CI.PowerShell.Cmdlets.SelectXrmWhoAmICommand
Is there anything i am missing . I have tried different options but no change in output
.\Ping.ps1 "ServiceUri=https://XXXX.crm.dynamics.com; Username=XXXX; Password=XXX"
KhanPinewood wrote Mon at 10:54 PM

Able to fix it .Seems it was looking for OAuthType=Office365 parameter in my connection string
wrote Tue at 3:56 PM

josersm wrote Tue at 3:56 PM

@KhanPinewood, can you share a more full example? I'm running into the same issue.
KhanPinewood wrote Tue at 11:21 PM

My bad i made myself shared typo in the fix :( . For latest 8.1 dll solution provided by wael It should be
"AuthType=Office365;ServiceUri=https://xxx.api.crm.dynamics.com<EMAIL_ADDRESS>Password=xxxx"
KhanPinewood wrote Tue at 11:43 PM

https://msdn.microsoft.com/en-in/library/mt608573.aspx
josersm wrote Today at 8:10 AM

thanks KhanPinewood, that worked for me for both ping and export!

Thanks for sharing.
Here is the format of the connection string I use for CRM Online by the way<EMAIL_ADDRESS>Password=ZZZ;Url=https://YYY.crm4.dynamics.com


named parameters at function call site

For some functions it makes sense to include the name of one or more parameters at the call site.  This is common if it's a flag type parameter, if the parameter is a "unit type" like "seconds"/"meters", or if the function takes multiple parameters of the same type whose order is important but not clear.  It is proposed that a function definition can annotate certain parameters to be named in which case the caller is REQUIRED to write the name of those parameters at the call site.  With this annotation the name at the call site should be REQUIRED instead of optional to maintain the "one way to do things" philosophy.
fn sleep(named seconds : u32) {...}
sleep(seconds = 100);
sleep(100); // Error: parameter 1 requires the name "seconds"

fn doSomething(named makeItCool : bool) { ... }
doSomething(makeItCool = true);

fn add(a : i32, b : i32, named checkOverflow : bool) { ... }
add(2, 3, checkOverflow = true);

A couple of notes:

A possible alternative if you have a bool parameter is to use an enum instead.

const Overflow = enum {
    Checked,
    Unchecked,
};

add(2, 3, Overflow.Checked);

It might make sense to have named parameters to prevent logic bugs if you have multiple parameters with the same type with different meanings. This way they are not mixed up with the wrong parameter order, if for example one re-arranges the order at the function definition but not the callsite.
Another use case for named parameters is if you have a lot of parameters. But this can be accomplished by passing a struct.

Tricks to simulate named parameters in C++ make situation much worse (e.g. in Boost http://www.boost.org/doc/libs/1_33_1/libs/graph/doc/bgl_named_params.html). In language D people bend themselves backward trying tricks (one of several attempts<EMAIL_ADDRESS>) instead of doing the proper thing. Even using good old enums or structs is needless complication.
I support this feature.
Things to consider:

Order of parameters will be strictly required or can named parameter appear at any place? (I'd recommend keeping original order, even when it results in more work when original function is changed).
How about function pointers? Can I use assign it with a function having different parameter names or no named parameters? Requiring the same name everywhere may not be the best idea, functions do different things and may want to reflect it in the names.
If optional parameter values will be implemented: how could one specify "I want the default here"? One possible solution:
foo(param1_with_default = _, param2 = 42, param3 = 0);
Function pointers & optional parameters combined together.
Since parameter names are local they tend to be generic words (count). Using them may result in funny situations like:
foo(count = count);

Using word named as for what will be (I guess) very common would take lot of screen space. Imagine function with 5 - 10 parameters, that is 30 - 60 characters plus. How about putting "!" in front of the required parameter name?

A couple relevant pieces of information:

Optional parameters and function overloading has been rejected.
we get a lot of criticism for sigils. Probably a bad idea to add more when it's not strictly necessary.

Function overloading based on number of parameters was also rejected? This one is without surprises.

Function overloading based on number of parameters was also rejected?

Correct.

We talked a little about why function overloading was rejected, but I failed to find any "Issues" that talked about why optional parameters were rejected.  Is there a discussion on that you could point me to, I'm curious what the arguments for/against were.  Specifically on optional parameters with default values, not with function overloading.

Sigils (what I understand under the term) may not be necessary. Function may look like:
fn foo(named par x : i32) -> i32 { ... }
fn foo(par ::: i32) -> i32 { ... }

That's still 4 character shorter.

I think using named over a special character has a couple advantages.  The first is that it's easier for a newcomer to immediately understand what's going on, it's more intuitive to decipher what "named" means rather than some symbol like ! or :::.  This fits the "zen rule" of "Favor reading code over writing code" better I think.  I think using a symbol makes sense when the meaning of that symbol is used in multiple context or very often that the extra time it takes to learn the symbol is worth the brevity.
Note that using words over symbols in general makes a language simpler to learn/remember because it's easier to remember a word like "named" than to remember a special character.  If I gave you a list of semantics to learn like the following, would it be easier to remember the word version of the symbol version?
const, out, shared, in, named

!, #, @, $, *

The disadvantage I can see is that it's a few more characters.
In my opinion the extra characters are worth the benefits listed above, and adding a new special character for this one use case isn't justified.

I think you are right.

Just a few questions:
What happens with named varargs parameters? What would the following mean? How would you call them? Below are my thoughts.
// Functions
const anon_last = fn(first: u8, many: ..., last: u8);
const named_last = fn(first: u8, many: ..., named last: u8);
const named_varargs = fn(first: u8, named many: ...);
const named_and_varargs = fn(named first: u8, named many: ...);
const interleaved_varargs = fn(first: u8, args_first: ..., second: u8, args_second: ...);
const interleaved_named_varargs = fn(named first: u8, args_first: ..., named second: u8, args_second: ...);

// Calls, these are fairly unambiguous
anon_last(42, "These", "are", "the", "varargs", 99);
named_last(42, "These", "are", "the", "varargs", .last = 99);

// Here it might get unintuitive
named_varargs(42, .many = "first", .many = "second"); // Explicit naming of parameters, but double 'assignment'?
named_varargs(42, .many = "first", "these", "are", "part", "of", "many"); // Implicit named vararg parameters?
named_and_varargs(.many = "these", "are", "part", "of", "many", .first = 42) // Can implicitly named vararg handle out of order?

// These have to be defined/restricted
interleaved_varargs(42, "args_first1", "args_first2", 66, "args_second1", "args_second2") // Can the compiler work this out?

interleaved_varargs(.second = 66, "args_second1", "args_second2", .first = 42, "args_first1", "args_first2") // Is the position of the positional arguments relative to the start of the function or the previously named param?

Syntax
In the calls, I have prefixed the name with a . to make it clear it's not a regular assignment - I think it is analogous to initializing a struct with a positional vs parametric initializer list.
fn sleep(named seconds : u32) {...}
sleep(.seconds = 100);

Though I'm usually a strong proponent/supporter of sigils, in this case I agree that the named keyword is better.

Is there a discussion on that you could point me to, I'm curious what the arguments for/against were. Specifically on optional parameters with default values, not with function overloading.

I think there is not a documented discussion. Feel free to start one.

I like the idea of optionally naming parameters at call sites to disambiguate, with the condition that:

The order must be preserved
The name must match exactly the parameter name at definition site

Point (1) is to prevent confusion and remove ambiguity about overloading and to make it clear that this feature is not meant to allow overloading or jumbling up of parameter order.
Point (2) has potential to be problematic since it makes the parameter names a part of the function's interface, in that if a library provider changes a parameter name, it would affect all users of the library.
It's how Swift does it, except in Swift naming the parameters is mandatory, not optional.
So, using enums keeps things simpler IMO and does not require any new features.
Although, another neat feature from Swift is implicit enum namespace when passing parameters.
const Overflow = enum {
    Checked,
    Unchecked,
};

pub fn add(i64, i64, Overflow) -> i64 { .... }

add(2, 3, .Checked);

But that can also be very confusing to read.

With this annotation the name at the call site should be REQUIRED instead of optional to maintain the "one way to do things" philosophy.

If you introduce named parameters like this, haven't you already violated "one way to do things"? You now have two ways of taking function parameters, and it's not always obvious which one you should use.
Here's a half-serious proposal: any function taking more than 2 non-enum parameters must be called with all named parameters, and otherwise they must be called without names. Then there would always be one way to do things, and when you have a function with lots of parameters, you know you'll be able to tell which one is which when reading code without an IDE.

Although, another neat feature from Swift is implicit enum namespace when passing parameters.

I think this should be a feature. I don't see how it can be all that confusing. I think using enums and types to explicitly annotate function parameters is a very good practice, and anything that encourages this is positive.

Solved with https://github.com/ziglang/zig/issues/485#issuecomment-440489525


Create: 179-Largest-Number.ts

File(s) Modified: 179-Largest-Number.ts
Language(s) Used: typescript
Submission URL: https://leetcode.com/submissions/detail/833600597/

Thanks for contributing @loczek!


Dropping API v3 support

This issue is opened to discuss the support for API v3 in this library. Support for API v3 was removed in GitLab 11.0.
See, https://docs.gitlab.com/ee/api/v3_to_v4.html

There are many still using GitLab < 11.0, and since library defaults to API v4, and the consumer must explicitly specify API v3, there is no compelling reason to drop support for v3 just yet.

@shuklaalok7
I am going to close this issue.  That being said, I have put something on my calendar to remove support for v3 the first part of 2019.  I added info to the README.md file alerting people of this pending change.  This will give a warning and some time to anyone using the V3 to make the change.


Possible singular append update function?

Will there ever be a function where the user can dynamically update the data set in C3.js? I was just wondering since I'm working on a part of code right now where I am allowing a user to input data in a form and I want those values to then be appended to the end  of the data showing in the chart. Right now the only way I can find to do this is through the server-side operations.

Why can we not simply append new data rows? Why do I have to keep the existing data in memory just to append new data to it? It does not make sense. Can someone add support for this?


dom container has no id -> TypeError: el.className is undefined

Hi,
if I call "new L.map()" on a div container which has no id set, then I get the following error message (Firefox 25, Windows):
TypeError: el.className is undefined
I tracked the error down and this happens in
_initLayout -> addClass -> classList.add
Something goes wrong in addClass(). This function starts with:
if (el.classList !== undefined) {
...
el.classList.add(...)
With FireBug I can point onto classList and it is undefined. Nevertheless processing continues in the if-statement. Thus the check if el.classList is undefined somehow fails!
If I define an id for the div-container everthing is ok.
I hope this helps to find the error.
Knut

when i m using data-emojiable  after that onpresskey submit not working


Traversal with Callback Output and Global Domain

Takes care of the breaking changes in #504 , closes #481 , and provides custom outputs as requested in #225 .

It seems like callback is in MSVC a preprocessor keyword to allow to be backward compatible with alternative calling conventions.