Log voice channel events

Abstract
Start logging whenever a user changes their voice state to a new channel called #voice-log. Depends on issue: #161 being actioned.
Specification
Relevant d.py event here

Ignore Staff voice channel
Ignore Admins voice channel

The format of this log has not yet been discussed, and thus is largely up to the person who implements this feature. I suggest taking the format of the logs in #user-log as inspiration.
Motivation
We think it could be useful information to have. The issue #644 was discussed at the same time as this one.

Please provide the ID of the admin voice channel.

Need opinions on an icon:

I prefer the second one. I'm open to trying to make other too if these aren't cutting it.

I don't mind the mic icon, however I'd suggest instead picking the same icon type as the voice channels already use: the volume icon.

<svg xmlns="http://www.w3.org/2000/svg" width="200" height="100" viewBox="0 0 24 24">
<path fill="currentColor" fill-rule="evenodd" clip-rule="evenodd" d="M11.383 3.07904C11.009 2.92504 10.579 3.01004 10.293 3.29604L6 8.00204H3C2.45 8.00204 2 8.45304 2 9.00204V15.002C2 15.552 2.45 16.002 3 16.002H6L10.293 20.71C10.579 20.996 11.009 21.082 11.383 20.927C11.757 20.772 12 20.407 12 20.002V4.00204C12 3.59904 11.757 3.23204 11.383 3.07904ZM14 5.00195V7.00195C16.757 7.00195 19 9.24595 19 12.002C19 14.759 16.757 17.002 14 17.002V19.002C17.86 19.002 21 15.863 21 12.002C21 8.14295 17.86 5.00195 14 5.00195ZM14 9.00195C15.654 9.00195 17 10.349 17 12.002C17 13.657 15.654 15.002 14 15.002V13.002C14.551 13.002 15 12.553 15 12.002C15 11.451 14.551 11.002 14 11.002V9.00195Z"></path>
</svg>

Here it is

Looks good. Others will need to obviously give feedback too, but I like that one.
As a note, the final image will need to be 128x128px.
Should we use a red one for when they leave, a green one for when they join and a blue one for other information?

As a note, the final image will need to be 128x128px.

No problem; I make them as SVGs anyway. I just export to 24x24 because that is it's actual display size.

Should we use a red one for when they leave, a green one for when they join and a blue one for other information?

I don't mind implementing that but it does honestly feel like too minute of a detail. That doesn't mean it's a bad thing though, I suppose. Maybe yellow for switching channels.

I think having a blue icon for all is fine enough.  If it becomes needed later, we can do it later.

I like the speaker. We've color coded everything else, so I kind of think @scragly's suggestion to use red and green for suitable events is a good one.
Historically we've used red for anything negatory (leaving, getting banned, removing), green for anything affirmative (joining, being unbanned, adding), and blue for anything that falls inbetween (edits, information, etcetera). We've never used yellow because white on yellow has poor legibility.

I'll take that thumbs up as 3 votes for a speaker, so that is what I'll go with. I will create the red and green icons too. Thanks.


Added missing class

Coverage remained the same at 100.0% when pulling cbd53dcd8245ca8731839e92da1b6fbf0a2dcd09 on 27-Superclass-of-PersistenceCommandFailed-does-not-exist into dd6ecbfca7f97cd4b761b917072175912e5043ae on master.


Compress built docs before upload

Summary
Right now the compiled docs upload to the artifact store is a bottleneck
for a CI throughput. In an attempt to speed it up this commit sets the
parallel option on the task [1]. This will hopefully reduce the amount
of time spent uploading files to the artifact store.
Details and comments
[1] https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/utility/publish-build-artifacts?view=azure-devops

Things are a bit backed up in CI right now and there was a new aer release that the windows wheel jobs are queued in azure pipelines for. Which is why the windows jobs are failing here. I'm going to merge this despite this since it will relieve the pressure on CI slightly.


Mono lacks support for ExtendedProtectionSelector

This lack of support leads to such problems as these, recently logged on StackOverflow:
Running Grapevine REST server in Mono Docker container
Error: System.TypeLoadException: Could not load type 'Grapevine.Interfaces.Server.HttpListener' from assembly 'Grapevine, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'.
  at Boerse.BoersenApplication.Main (System.String[] args) [0x0002f] in <407ced228a394aa7b9fc2fa883a239a9>:0
TypeRef ResolutionScope not yet handled (57) for .ExtendedProtectionSelector in image /boerse/Grapevine.dll
Could not load signature of Grapevine.Interfaces.Server.HttpListener:get_ExtendedProtectionSelectorDelegate due to: Could not resolve type with token 0100003a assembly: type:ExtendedProtectionSelector member:<none>
TypeRef ResolutionScope not yet handled (57) for .ExtendedProtectionSelector in image /boerse/Grapevine.dll
Could not load signature of Grapevine.Interfaces.Server.IHttpListener:get_ExtendedProtectionSelectorDelegate due to: Could not resolve type with token 0100003a assembly: type:ExtendedProtectionSelector member:<none>

Cannot load type HttpListener in simple Grapevine server example
System.TypeLoadException: Could not load type 'Grapevine.Interfaces.Server.HttpListener' from assembly 'Grapevine, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. at Grapevine.Server.RestServer..ctor () [0x00006] in <5da3c1fcf3364795b3df98bfc8b714aa>:0 at TestServer.MainClass.Main (System.String[] args) [0x0000b] in /Users/blah/Projects/Test/TestServer/Program.cs:12

Both of which might be resolved once there is a Grapevine version that targets .NET 4.5 or 4.6.

Scott, have you had a chance to make any progress on this issue? (fingers crossed)  The issue isn't closed, but a comment on StackOverflow suggests that sometime in January was the hope for resolving it.

Fixed in 4.1.0-alpha.0

Since I haven't heard anyone tell me otherwise, I'm going to assume this resolves the issue.
I'm going to stray from semver here. Because I am removing part of the API and therefore introducing a breaking change, I do a major version changes (from 4 to 5). But I'm not going to do that for two reasons.

This API feature was actually making the library unusable for some people. And to the best of my knowledge, this isn't a feature anyone is using. I honestly don't get much feedback from my users base unless there is a problem, so it might just be a matter of not enough of the right kind of feedback, but if you really want to use the feature of the API, stay on version 4.0.

Version 5 is already underway, and it not only includes many, many other breaking changes, it also provides a spectacularly better way of managing these kinds of API/dependency feature implementation thingys (i.e., exposing features of the underlying http implementation to the user). In fact, changes in version 5 will make it possible to provide future minor versions (e.g. 5.1, 5.2, etc.) that don't rely on the HttpListener class at all.  I may never do this, but at least if I don't it won't be because my library is too tightly coupled to the existing HttpListener implementation.

Okay, that's all for now, the rest will go in a blog post.


Contributing documentation

I recently forked this project and got it working locally.  The contributing documentation says:

Run npm install to install both node modules and bower components

Alas, this only installed node modules for me.  I had to run bower install separately before I could run npm run build.
Am I missing something, or should the documentation be updated?

Ah, the documentation needs to be updated. The post-install script that would run bower install was removed in this commit.
Thanks for the catching that!


feat(python): fastapi generator with pydantic v2

@amckinney adressed some comments, will address more as I continue to build out this generator.


Updated existing toast by passing id to options

I would like to create some kind of toast confirmation. My first attempt was to update the toast by passing an id
const id = toast("Are you sure...", {
      action: {
        label: "Save",
        onClick: () => {
          toast.promise(promise, {
            id,
            loading: "Loading...",
            success: "Saved",
            error: "Something went wrong"
          });
        }
      }

The first error with this is that when clicking on "Save" the toast is closed and there seems to be no way to disable this. The second error is the title Are you sure... has not been updated to Loading....
Suggested Solution
I think this can be handled in two ways:

Provide a toast.confirm API for these cases
Possibility to update an existing toast by passing an id to options.

I would say that the second option is preferable because it offers more flexibility. For example, if the second option is implemented, it would be nice if the toast promise options could return an object to update the toast
    const id = toast("Are you sure...", {
      action: {
        label: "Save",
        onClick: () => {
          toast.promise(promise, {
            id,
            loading: "Loading...",
            success: () => {
              return {
                title: 'Saved',
                action: {
                  label: "Undo",
                  onClick: () => { ... }
              }
            },
            error: "Something went wrong"
          });
        }
      }
    });

Maybe we could refactor it so that we can doe.preventDefault in the action onClick to not close the toast and then update the toast as described here?

Maybe we could refactor it so that we can do e.preventDefault in the action onClick to not close the toast

Yeah, it would be nice

then update the toast as described here?

I don't think so. When using the toast.promise the title is not updated. It might work if there was a toast.loading but I would like to use the toast.promise because it already handle the loading, success and error states. I would have to do all the .then().catch() stuff myself.
I think it's a specific problem in how the title of the promise toast is handled. Instead of using a local variable, it could update the title of the toast. What do you think?

That sounds good to me!

Okay, I'll update the title to describe more precisely what's the issue


Cropper doesn't render when loading .png file from sidebar in a different tab

Consider the following code snippet
from streamlit_cropper import st_cropper
import streamlit as st
from PIL import Image

tab_1, tab_2 = st.tabs(["TAB-1", "TAB-2"])

img_file = st.sidebar.file_uploader(
    label='Upload a file',
    type=['png', 'jpg'])

if img_file:
    img = Image.open(img_file)

with tab_1:
    st.write("This is TAB 1.")

with tab_2:
    if img_file:
        cropped_img = st_cropper(img, realtime_update=True,
            box_color='#0000FF', aspect_ratio=(1, 1))
    st.write("This is TAB 2.")

The cropper widget shows up when I'm in tab 2 when uploading the .png file, but it does not show up when I'm viewing tab 1, upload a .png file, and then switch to tab 2. Am I doing something wrong?

This one's honestly a headscratcher, st.image works in this same scenario, maybe it's something about how components are rendered. Do you know if this works with other components? I haven't had a chance to test. What's odd is the component is there in the HTML but height is set to 0 for some reason.


PackageId:CPython39.Exe.x64;PackageAction:DownloadPackage;ReturnCode:0x80070193;

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work]
Describe your issue here
===DO NOT EDIT BELOW THIS LINE===
PackageId:CPython39.Exe.x64; PackageAction:DownloadPackage; ReturnCode:0x80070193;

Original Comments
Feedback Bot on 5/10/2023, 01:34 AM:
(private comment, text removed)

Original Solutions
(no solutions)

It seems the problem occurs when installer tries to download python. This could be due to network timeouts, corporate firewall policy, VPN configuration, anti-virus, or other problems. See if a retry helps, and if not, see if you can download the Python runtime directly from https://python.org/ and install it manually.
If that doesn't solve your issue, we could use more detailed logs to see what's really going on. Can you please collect more logs by running http://aka.ms/vscollect.exe and uploading %temp%\vslogs.zip and reopen the ticket if it persists? Thank you!😊


Add file extension to require on index.js

The same as https://github.com/wooorm/remark/pull/264 , I got an error like as follow:
ERROR in ./~/hast-util-sanitize/lib/index.js
Module not found: Error: Can't resolve './github' in '/.../node_modules/hast-util-sanitize/lib'
 @ ./~/hast-util-sanitize/lib/index.js 14:15-34
 @ ./~/hast-util-sanitize/index.js

Some environment such as webpack don't work correctly without extension, so I change it.
Thanks!

This has been discussed before in GH-3, GH-1, and wooorm/remark#215!

I'm sorry! 🙇
Thank you for your reply!

No problem, thanks for helping, hope this works!


Release new spike sorting data on openalyx

We will split the good units and spikes and the full spike sorting output:

good units will figure within the current ALF format and architecture
we add a table containing the full output, preferably column based and compressed.

Completion metric:

the data can be loaded with spike sorting loader

Coordinate with int-brain-lab/ibllib#774, int-brain-lab/ibllib#775, int-brain-lab/ibllib#77

WIP: https://github.com/int-brain-lab/iblalyx/pull/68

Data request form: https://docs.google.com/document/d/15HssSL7LxKs35grijn6eUJq-hjgDiw7H-tHhg2syO3E/edit


Refactor Avalonia.Controls

I see a combination of organizational structures in the Avalonia.Controls directory.

Some controls have their own folder
Most controls are just in the top-level directory
Some controls are grouped: Selection, Primitives, etc.

This should all be cleaned up in my opinion following the WinUI repo which is more-or-less the standard now days.

Avalonia.Controls

Grid

Grid.cs
Grid.Properties.cs
Grid.Events.cs
ColumnDefinition.cs
RowDefinition.cs

ComboBox

...

...

Note the following:

Each control has its own directory
Each control is split apart into components using partial classes:

.Properties.cs contains all Direct/Styled properties as well as get/set accessors. Arrange alphabetically.
.Events.cs contains all events. Arrange alphabetically.
.cs contains all control logic

Separate data structures related to the control are also placed together. (ComboBoxItem, ColumnDefinition, etc.)

Open Questions:

Some controls share components. ~These, like primitives, should probably move to a "Common" directory.~ Edit: It might be best in this case to leave shared components in the Avalonia.Controls directory. Generally speaking directory organization should follow the namespace.
In other XAML frameworks .xaml is included in the directory as well. This is great and allows everything to be together. ~Avalonia seems to be doing the monolithic styling files like WPF did though. Would be great in my opinion to split these apart and just reference them from a monolithic generic.xaml file.~ Edit: I found the Themes directories which do already have files for each separate control. This totally makes sense to keep all themes together and then have different directories for different theme styles (Fluent, etc.). It's just a different way of organizing but no way is more correct here.

If there are no main objections, I'll do this myself over time control-by-control each getting their own PR making sure to rename the files to preserve history (at least if using git --follow).

@grokys

Looking at the controls themselves, it is some of the cleanest code I have ever seen within a public project/framework :) Cleaning up the directory structure will only encourage others to look at the code. It will also speed things up for maintainers as well.

Hi @robloo, thanks for the compliment ;)
However I'm not sure about your proposal (although things could definitely be better).

Each control has its own directory

This makes sense in WinUI where the controls are huge due to the overhead of C++/CX, for example in WinUI these are all the source files needed for ProgressBar: https://github.com/microsoft/microsoft-ui-xaml/tree/master/dev/ProgressBar. However in Avalonia, ProgressBar is a single class of 266 lines. Putting that into its own directory would just increase the amount of navigation to get to it IMO.

Each control is split apart into components using partial classes

Again, makes sense for WinUI where controls can be tens of thousands of lines long in some cases but in Avalonia would IMO just make navigation take more clicks. Another example:
WinUI ScrollPresenter
Avalonia ScollContentPresenter
You can see that the WinUI control is an order of magnitude bigger, partly because of the overhead of C++ and partly because it does a lot more. If/when we update our scrolling controls to do everything WinUI's do then we might want to place them in their own directory.

Separate data structures related to the control are also placed together.

This makes more sense, but mostly when arranged alphabetically they're placed next to each other anyway
--
Another reason not to do this is that git/github doesn't follow renames/moves on renamed files when doing a git blame and we do a lot of git blame. This happened when we did the rename from Perspex -> Avalonia and I end up hitting this every week and cursing ;) This would be a large practical annoyance for day-to-day maintenance of Avalonia.
I personally think the way we do it at the moment gives a good tradeoff between navigation and cleanliness:

Large controls get their own directory
Smaller controls sit by themselves

@grokys Thanks for the feedback!

Each control has its own directory
Separate data structures related to the control are also placed together.

I'm a big fan of consistency. Placing all controls in their own directory would help a lot for readability. I'm not so worried about navigation paths getting slightly longer :) But let's consider the Grid control as an example today:
This is ported from WPF and isn't a very clean code base. You also likely don't do much blame here as it was imported code. This is an ideal candidate to put inside it's own Grid directory. You could clean up a lot:
Grid
- Grid.cs
- Grid.Properties.cs : The Grid code base is quite ugly in comparison and finding properties is difficult.
- ColumnDefinition
- RowDefinition
- GridLength
- GridSplitter
This certainly must qualify as a "Large controls get their own directory" :) ColumnDefintion and RowDefinition also aren't alphabetically next to each other.

Each control is split apart into components using partial classes

A lot of controls have many properties. Separating out the properties in a partial class is quite useful as a separation of concerns. It significantly cleans up the code-behind file from boilerplate and improves readability of the logic. I promise if you try it out you will like it over time!
It also might help a little with importing code from other frameworks. Avalonia property differences are significant compared to WinUI/WPF. Therefore, breaking these apart right away would just help the migration story.

Another reason not to do this is that git/github doesn't follow renames/moves on renamed files when doing a git blame and we do a lot of git blame

Well, yes, it has been a never-ending request for GitHub to support --follow in History and in Blame. I know history is just a missing feature in GitHub. I don't know if Blame preserves the information in git itself but would assume it does. Regardless, its possible to browse the repo at a previous commit online and see the blame as before. Reorganizing directories is really a long-term improvement though and there would be a -- in my opinion very minor -- tradeoff in the beginning where blame/history wouldn't be as usable with GitHub (but should still work in command-line).

I think fundamentally, when projects are smaller, it makes sense to organize by type. You don't have that many classes and putting them in separate folders just adds more directory depth and clicks required to get a file. However, as projects grow and become larger in size, it makes sense to instead organize by logical feature/function. Most large-scale projects evolve to organize this way.


Defender / Towers integration

Healmap with negatives at defender location
Assignments for defenders
Defenders are ranged

TODO: towers should take defender's target into account when generating healmap. Defenders can put their firing targets in global, since the tower code is run after the defenders. A defender can also report that it will be using RMA rather than a ranged attack, and the towers can color the healmap accordingly


Issue with k8s.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/

This is a Bug Report
Problem:
failureThreshold: ... Giving up in case of liveness probe means restarting the **Pod**. ...

The Pod here is incorrect. I have the following livenessProbe
livenessProbe:
  httpGet:
    host: 'www.grugruuuu.com' # site does not exist
    scheme: HTTPS
    port: 80
  initialDelaySeconds: 5
  timeoutSeconds: 5
  periodSeconds: 5
  failureThreshold: 1

It failed to probe 1 time and restart the Container and not Pod
Proposed Solution:
failureThreshold: ...Giving up in case of liveness probe means restarting the Container. ...

Page to Update:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes

/language en
/triage bug

/kind bug


FreeCEN2 times out in a second or two

Searching Alcock, Nottinghamshire, 1841, windows 10/chrome, timed out in a second or two at 9.57-ish this morning.  Had this issue last week.

Hi @sharadd15 and welcome to Free UK Genealogy!  Someone will be in touch in the next few days to get you set up, but if you have a few minutes in the meantime, could you try and replicate this bug (not yet proven to be a bug)?  Thanks, Pat (Executive Director of Free UK Genealogy, the charity covering FreeREG, this and other projects)

Issue seems to be if you have used FreeCEN2 before, resolved with clearing cache.  Please could someone put a note to that effect on the homepage of FC2. Please still test, @Sharadd15 to check that new users do not have this issue.

Tested (Chrome, OS X) and got results within a few seconds based on the Alcock search above

@PatReynolds
As noted on slack on 29 Dec the issue was a result of an incorrect configuration file on colobus. The maximum search time had been set at 10ms instead of the normal 100s thus causing the fast time out. This was apparent by looking at the timeout being used which is displayed on the search form.

This configuration file had been in use on colobus since June 2017.   As a result any user assigned to colobus would have timed out.
An updated version of the configuration file with the normal max search time was installed.


Inaccurate performance tests

I'll assume we're testing in V8 here, as it's the default JavaScript engine for Node.js, however, your library claims to be faster than native V8's methods, I'm sorry to break you here, but they're faster only in cold load.
The V8 engine's runtime can be separated in two, the interpreted code (via Ignition), which is light, fast to process, but slower to run, all the code is by default in this part. Then, once this code is run many times, V8 runs Turbofan, turning said code into compiled, heavier, but much faster native code, this process is often called "warming up the code/Turbofan".
The performance tests as of now, they don't warm the functions, but instead run it from cold load. You may be aware that because V8's methods are spec compliant (needs to assert this as an object, check if the index exists...), they take a bit longer than code written in plan JavaScript, until the PACKED_SMI_ELEMENTS vs HOLEY_SMI_ELEMENTS is taken care by TurboFan and removes said assertions, making the final code somewhat similar to yours, that's when, it's either as fast as code written by any user (like optz), or faster. Callback inlining (implemented in V8 6.4, if I remember correctly) also helps optimizing this.
I modified the tests to warm the functions before benchmarking this, using 1,000,000 function calls to inline the benchmark function and warm its contents, the results are:
Completed native-forEach with 1000000 iterations in 3126ms
Completed optz-forEach with 1000000 iterations in 6201ms
Completed native-reduce with 1000000 iterations in 6977ms
Completed optz-reduce with 1000000 iterations in 9269ms
Completed native-reduceRight with 1000000 iterations in 7758ms
Completed optz-reduceRight with 1000000 iterations in 12434ms
Completed native-map with 1000000 iterations in 23636ms
Completed optz-map with 1000000 iterations in 12375ms
Completed native-filter with 1000000 iterations in 40144ms
Completed optz-filter with 1000000 iterations in 54065ms
As we see, V8's methods are from slightly to significantly faster than optz (I didn't expect this either, I expected it to equal) minus in the map test, where optz actually beats V8's implementation by a factor near 2.
This is the code used for the benchmark:
const optz = require('optz');
const noop = () => null;
const myArray = [];
for (let i = 0; i < 10000; i++) {
	myArray[i] = i;
}

function warm(cb) {
	for (let i = 0; i < 1000000; i++) cb();
}

function test(name, cb) {
	const times = [];
	const repeats = 10;
	const iterations = 100000;
	for (let i = 0; i < repeats; i++) {
		const now = Date.now();
		for (let j = 0; j < iterations; j++) {
			cb();
		}
		times.push(Date.now() - now);
	}
	console.log(`Completed ${name} with ${repeats * iterations} iterations in ${times.reduce((acc, val) => acc + val, 0)}ms`);
}
[
	['native-forEach', () => { myArray.forEach(noop); }],
	['optz-forEach', () => { optz.forEach(myArray, noop); }],
	['native-reduce', () => { myArray.reduce((accum, val) => accum + val); }],
	['optz-reduce', () => { optz.reduce(myArray, (accum, val) => accum + val); }],
	['native-reduceRight', () => { myArray.reduceRight((accum, val) => accum + val); }],
	['optz-reduceRight', () => { optz.reduceRight(myArray, (accum, val) => accum + val); }],
	['native-map', () => { myArray.map(x => x + 3); }],
	['optz-map', () => { optz.reduceRight(myArray, x => x + 3); }],
	['native-filter', () => { myArray.filter(x => x > 3); }],
	['optz-filter', () => { optz.filter(myArray, x => x > 3); }]
].forEach(([name, cb]) => {
	warm(cb);
	test(name, cb);
});

Note: An array with 10,000 elements was used as both V8's and optz's functions are O(n), plus 10k elements is more realistic in real world, which we're aiming for.

I'd also like to note somewhere, in the README, that this package might not work well for holey arrays, as tested in npm's runkit (which is what makes this function not spec compliant, nor a drop-off replacement for all cases):

External notes

Elements Kinds: https://v8.dev/blog/elements-kinds
Function inlining: https://benediktmeurer.de/2017/12/13/an-introduction-to-speculative-optimization-in-v8/
Effects of "warming up" V8: https://nodesource.com/blog/why-the-new-v8-is-so-damn-fast/

And more that I have read from conferences, notes, blogs... feel free to ask me any doubt.

@kyranet
Thank you so much for this!!!
Very insightful! I'll continue to work on this module thanks to your help. :)

I'm happy to help! I believe the most fair benchmark is to test it in real world https://v8.dev/blog/speedometer-2, but since this is a small project, I guess the best microbenchmark (running them take a lot of space, which in practise can make the last elements slower than the first tests), is to use children processes, sort of what V8 does here: https://github.com/v8/promise-performance-tests
Good luck with your project! By the way, I forgot to mention that the tests were ran with Node.js 11, where V8's new optimizations may equal or beat handwritten JS, but I have no doubt this is faster for Node.js <=9.x 😃


add BOOST_MATH_DISABLE_FLOAT128

Testing Lunar-Zesty build on prerelease test.

https://github.com/ros-planning/moveit/issues/505 is merged so this is no longer needed.


Add node's IP range cidr to NodeSpec

@bgrant0607 @fbalejko: This is something you guys already talked about I believe.
The idea here is to add a new method to cloudprovider.Instances interface to push the range setting from api.NodeSpec to the actual node in the cloud. The goal being to allow adding more instances to a running cluster.
Please review the API part for now.

cc @zmerlynn

Assigning this to @bgrant0607.
Please feel free to reassign appropriately.

LGTM

What's the expectation if the node doesn't have a CIDR?  I.e., you're using a custom network plugin?

Should be empty.


fix: Added new and more comprehensive CLI

Including documentation and tests

Yea I was thinking of adding it to a new PR.

Tests are failing, do we know why?

Fixing it. It is an odd case. where tests interact due to the registries.


FormatException: Unexpected extension byte (at offset 5)

I'm aware it's a duplicate, but why isn't this backported?
Switching to master branch is not an option.
What exactly was the change that fixed this flutter doctor error with idea?
If you didn't aggressively close issues and limit people talking and exchanging ways to solve this you can not expect other issues to be opened.

What exactly was the change that fixed this flutter doctor error with idea?

There was an issue with the archive, the package used to decode the jar files. See https://github.com/flutter/flutter/issues/96018.
You can fix this locally by following the instructions in https://github.com/flutter/flutter/issues/94060#issuecomment-1008040192.
Closing as this has already been fixed.
Thank you


Fix armor and goggles not having squad coloring

About the PR

Fixes https://github.com/RMC-14/RMC-14/issues/4266
Why / Balance

Technical details

Media

Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
:cl:

fix: Fix armor and squad goggles not having squad coloring.

I am glad I checked if there was a PR up already right before I published my own fix for this


[BEAM-9678] Introduction Kata | Go SDK Code Katas

Hello @lostluck
At BEAM-9678-intro-kata-golang I made a first attempt at BEAM-9678 patterned after the Java Katas but added a how to setup and a how to test katas.

Ah, ok, I almost missed this since it's a Github Issue in your own personal fork of apache/beam, rather than a PR against trunk's master branch.  A PR would let me comment on the the code.
(eg. there's the "create PR" button in the branch comparison page).
https://github.com/apache/beam/compare/master...damondouglas:BEAM-9678-intro-kata-golang
Conventionally, the Beam project receives PRs from users, rather than makes them on their behalf, which lets the discussion happen in the main repo, rather than off in the forks, where context could be lost.
However, I understand if you want more feedback separately rather than committing to master in an incremental fashion.

That said, some initial commentary: Overall, I like it!
Add the Apache 2.0 license header to all the files that can accept it without breaking function, there's a license check step. If the Java or Python equivalent don't have the licenses, then this is probably fine, but I'd be surprised if none of them do. This most likely effects the task*.go files. Be sure to have an empty line between the license and the package description/ package line to avoid the license becoming part of the package documentation.
Branding wise, the full name of the SDK is the Apache Beam Go SDK, shortened to the Beam Go SDK, or the Go SDK in beam contexts. We don't typically use "Golang" to refer to the language or the language for the SDK, as the official name is the Go Programming Language.
I recommend that somewhere in the initial pre-amble that the katas will not teach you Go, and that they assume some familiarity with the language. Pointing folks to https://golang.org/doc/#learning as a resource is sufficient.
Certainly since Go 1.13, (and probably 1.12) the main go tool supports Go Modules, so there shouldn't be any need to reference the vgo prototype tool at this juncture. The current release is Go 1.14 and modules are recommended. Yes, the SDK doesn't use them at this time, something something versioning...


sats10kclub collection

curled from Sats Names

I wrote a test that will verify .sats names individually with the sats names api. Problem is the server is swamped so checking individuals absolutely crawls and ultimately will fail with a bad request at some point if the collection is large:
def test_satsnames():
   """
   Test that all inscriptions are registered on satsnames

   Assumes ".sats" collections begin with the prefix "sats"
   """
   current_collections = os.listdir(COLLECTIONS)
   satsnames_collections = [
       c for c in current_collections if c.startswith("sats")
   ]
   for x in satsnames_collections:
       with open(
           "{}/{}/inscriptions.json".format(COLLECTIONS, x), "r"
       ) as file:
           inscriptions = json.load(file)
       # Check if the first inscription name ends with ".sats"
       if not inscriptions[0]["meta"]["name"].endswith(".sats"):
           print(
               f"Skipping collection {x} because first inscription name does not end with '.sats'"
           )
           continue
       for y in inscriptions:
           name = y["meta"]["name"]
           print(name)
           try:
               api_response = requests.get(
                   f"https://api.sats.id/names/{name}"
               ).json()
               try:
                   inscription_id = api_response["inscriptionId"]
                   assert inscription_id == y["id"]
               except KeyError as e:
                   print(e)
                   assert False, "Satsnames API is down"
           except requests.exceptions.RequestException as e:
               print(e)
               assert False, "Satsnames API is down"

It's WAY faster to use the batch https://api.sats.id/names endpoint to compile a local index and check against that instead (that is how I compiled and checked mine locally).
I didn't know how the team would feel about including a constantly growing index of sats names in the repo for tests. For these reasons I held off on a full blown pull request with sats names verification.
Happy to help contribute if thats something ya'll would like.

I tweaked the function above to search for ".sats" keywords within the collections' meta.json then validates those collections. Also I fixed it so it just keep retrying when the server is busy.
I wrote this within your test_collections.py file (not in the branch pull requested here). Let me know if you want me to pull request another with the function included @MillHaus33.
It still takes a minute to check larger collections. Whereas the version I have that builds a local index first would be able to verify enormous collections (10k+)  almost instantaneously.
def test_satsnames():
    """
    Test that all inscriptions are registered on satsnames

    Checks name and description fields of meta.json for specifed substrings
    If a match is found, the slug is added to the satsname_collections list

    """
    current_collections = os.listdir(COLLECTIONS)
    satsname_collections = []
    for x in current_collections:
        with open("{}/{}/meta.json".format(COLLECTIONS, x), "r") as file:
            meta = json.load(file)
        slug = meta["slug"]
        name = meta["name"]
        description = meta["description"]
        # Look for "sats ", ".sats", "sats name" or "satsname" in name
        if (
            re.search(
                r"sats\s|\.sats|sats\sname|satsname", name, re.IGNORECASE
            )
            is not None
        ):
            satsname_collections.append(slug)
        # Look for "sats ", ".sats", "sats name" or "satsname" in description
        elif (
            re.search(
                r"sats\s|\.sats|sats\sname|satsname",
                description,
                re.IGNORECASE,
            )
            is not None
        ):
            satsname_collections.append(slug)

    for x in satsname_collections:
        with open(
            "{}/{}/inscriptions.json".format(COLLECTIONS, x), "r"
        ) as file:
            inscriptions = json.load(file)
        # Check if the first inscription name ends with ".sats"
        if not inscriptions[0]["meta"]["name"].endswith(".sats"):
            print(
                f"Skipping collection {x} because first inscription name does not end with '.sats'"
            )
            continue
        for y in inscriptions:
            name = y["meta"]["name"]
            while True:
                try:
                    api_response = requests.get(
                        f"https://api.sats.id/names/{name}"
                    ).json()
                    inscription_id = api_response["inscriptionId"]
                    assert inscription_id == y["id"]
                    print(f"Success! {name} is verified on Satsnames!")
                    break  # break the loop if successful
                except KeyError as e:
                    print(
                        "Hold up! Satsnames API fussin' cuz its bussin'. Retrying..."
                    )
                except requests.exceptions.RequestException as e:
                    print(
                        "Hold up! Satsnames API fussin' cuz its bussin'. Retrying..."
                    )

Oh nice!
https://ordinalswallet.com/collection/sat-names
Guess ya'll already got it setup.


Run closure onload?

Summary
I try to run a closure onload of the body (or any other element), but the function is not called.
Minimal code snipplet
use wasm_bindgen::prelude::*;
use wasm_bindgen::JsCast;

#[wasm_bindgen(start)]
pub fn run() -> Result<(), JsValue> {
    let window = web_sys::window().expect("no global `window` exists");
    let document = window.document().expect("should have a document on window");
    let body = document.body().expect("document should have a body");

    web_sys::console::log_1(&"Run init".into());

    let c_body = Closure::wrap(Box::new(|| {
        web_sys::console::log_1(&"Run closure".into());
    }) as Box<dyn FnMut()>);

    //document.set_onclick(Some(c_body.as_ref().unchecked_ref()));
    document.set_onload(Some(c_body.as_ref().unchecked_ref()));

    c_body.forget();
    Ok(())
}

and the html file:
<!DOCTYPE html>
<html class="no-js" lang="en">
  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title></title>
    <script type="module">
      import init from './pkg/wasmtest.js';
      await init();
    </script>
  </head>
  <body>
  </body>
</html>

I would expect the console to print "Run closure" but it does not. It works as expected if I use the onclick method and click in the document... What am I missing? Is the document already loaded, when the closure is added?

Sorry I don't know enough about web apis and onload to answer your question. My guess is that if onclock works and onload doesn't then it's a web api issue rather than a wasm-bindgen issue.


Scope all processing to only module options and test callbacks.

This avoids leakage when expressions are not included within a test callback or a method in the moduleFor* options.
Fixes https://github.com/rwjblue/ember-qunit-codemod/issues/37
Fixes https://github.com/rwjblue/ember-qunit-codemod/issues/38
/cc @alexander-alvarez

@alexander-alvarez - This builds on the work you started in the branch linked in #37, which was a great idea!  I just changed the way the scoping worked to only run on test callbacks and module options functions. What do you think?


Create CLI for WSIMOD

For DAFNI, it will be convenient to have WSIMOD run as a CLI, with input files (or general location where to find them) passed as arguments and outputs produced as output files. This approach can be useful beyond DAFNI, simply to interact with the tool without having to code.
The exact nature of the input arguments and how to ingest them and passed to the current scripting approach to give maximum flexibility is to be investigated, but broadly speaking it should allow calling WSIMOD like:
python -m wsimod --settings settings.toml --inputs /data/inputs --outputs /data/outputs

Or something along these lines. If the inputs and outputs are defined in the settings.toml file, then things are even simpler.

Postponing for now. It is unclear if the current config file is actually a better choice.


Simple md

Convert tutorial simple  to markdown

@radumereuta looks pretty good to me, but some formatting nits.


[pure refactor] "namespace" flag parameters for linestrip & point cloud shader flags

Also, remove NO_COLOR_GRADIENT in favor of FLAG_COLOR_GRADIENT
(stuff that came up on #2008)
What
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct

PR Build Summary: https://build.rerun.io/pr/2033

uhoh. Thanks! I'll look through them again, don't want surprises!


docs: use the bundle dist file.

This is WIP because we probably need to go through the docs and make sure we list/suggest the bundle everywhere

IMO we did it to talk about our bundle file everywhere in our docs 🤔

Let's wait for one more approval then. :)


Blog post for end-to-end acknowledgments concept and design in Data Prepper

Describe the blog post your would like to write
The Data Prepper maintainers added end-to-end acknowledgments in Data Prepper 2.2 to help with data durability. We are proposing to write a blog post which describes the problem it is trying to solve, detail the internal solution, and discuss some future extensions.
What is the title of the blog post?
Improving Data Prepper data durability with end-to-end acknowledgments
Who are the authors?
@kkondaka
@dlvenable
What is the proposed posting date?
Jun 16, 2023

@kkondaka @dlvenable While @natebower is OOO, I'll be editing this blog. I'm available when it's ready for review. Thanks!


How to know who executed a command?

I want to have a logging mechanism in my application So I want to know who executed a command, for example suppose that I have following command to be sent:
bot.onText(/^\/test (.+)$/, (msg, match) => {
   // here I want to know who called this command, for example something like this:
  // console.log(user);
}

The TelegramBot#onText() method handles entities of type Message. Therefore, you can find the sender's User object, at msg.from.
Thus,
bot.onText(/^\/test (.+)$/, (msg, match) => {
    const user = msg.from;
    console.log(user);
}

See the accepted answer.


[#221] Add a label of minor version in backup.info

I added a MINOR_VERSION label to record the minor version of the Postgres server in "backup.info" generated after making a full backup.

Only change what your patch is about... and use the same pull request

Only change what your patch is about... and use the same pull request

Sorry about that, some codes were changed by Uncrustify. I have fixed it.

Seems that some code got in without formatting @jesperpedersen

@l32zhao What is your uncrustify version? We are using 0.77. Otherwise some code got in without formatting

@l32zhao What is your uncrustify version? We are using 0.77. Otherwise some code got in without formatting

It's 0.76.0-2.fc38, I will try to upgrade it.

@Jubilee101 I upgraded uncrustify to 0.77.1 (Fedora39), but the result is still as same as my last commit, except for some modified codes not in my patch (like workers.h, workers.c, and bzip2_compression.c). Could you help me to have a look?

Hi, that is ok. Could you revert the format changes that are not in your code? We'll submit a separate patch for formatting. Sorry for the trouble. Other than that, the code looks good to me~

Hi, that is ok. Could you revert the format changes that are not in your patch? We'll submit a separate patch for formatting. Sorry for the trouble. Other than that, the code looks good to me~

Thanks, man. The current commit doesn't involve any format change not for adding the minor_version label. Please feel free to review it and pull it~

Merged.
Welcome to the community !
Thanks for your contribution !


OpeChatwindow

Seems with the new upgrade the OpenChatWindow has been disregarded and unavailable with the package, this is a good feature that is required when child to main components on Angular. Can you please see this through for us.

Hello @mphojkgomo 👋
If I understand correctly your use case, you would like to open the Chat Widget programmatically from your application.
In such a case, you can simply provide appropriate visibility property for LiveChatWidget component with  maximized as value. The component will reactively respond to the property value change and make Chat Widget maximized.
You can read more about component properties in the package documentation here: packages/widget-angular#config-data


Restarting Steam corrupts its installation

The problem in the watcher that prevents Steam from patching files back.
I listens to delete file event and tries to write to the file, so does Steam. It leads to crash and corruption of the installation.
The correct way to handle it would be listening to changes and applying patches after Steam closed the file.

Fixed by 6c24a85


Select Date Range

Not much of an issue but a request. :)
Would be great if I can select a date range and get those selected dates.

Hello @maail,
The only thing coming to my mind is dealing with long pressure touches. As soon as CVCalendar detects a long pressure touch it immediately starts selecting day views in a chain.
I'll try to create a prototype in the near maintenance work this weekend.
Regards,
Eugene

Hi @Mozharovsky,
What I had in mind was to select one date (as it is now). Then while having this date selected, select another date. So then I can get the selected dates.

Hello @maail,
I'm currently preparing CVCalendar for a new release. So I would like to make sure I understand the feature you've suggested well enough. I think of how to invoke range day view selection. It can be presented statically or dynamically. What I mean is that you can either select day views range only or you can select both range and a single day view.
Let me know how you think would be better.
Thank you in advance.
Regards,
Eugene

Hi Eugene,
I'm currently looking for date range. Select one date and then select another date. So from Start Date to End Date the dates will be highlighted to show the user that these date range has been selected.
I think you can give the option for both range and one day when initializing the function.
Thanks,
Maail
—
Regards,
Mohamed Maail Rasheed
Application Developer
Portfolio: http://thirdgene.com
On Wed, Feb 25, 2015 at 12:01 AM, Eugene Mozharovsky
<EMAIL_ADDRESS>wrote:

Hello @maail,
I'm currently preparing CVCalendar for a new release. So I would like to make sure I understand the feature you've suggested well enough. I think of how to invoke range day view selection. It can be presented statically or dynamically. What I mean is that you can either select day views range only or you can select both range and a single day view.
Let me know how you think would be better.
Thank you in advance.
Regards,
Eugene
Reply to this email directly or view it on GitHub:
https://github.com/Mozharovsky/CVCalendar/issues/12#issuecomment-75821966

Also, in this notion, can you please add a way to select multiple dates , but not a range. For example, these 3 dates will be selected and blue circle around them:
27/03/2015
02/07/2015
11/04/2014
It will be a great feature and will help a lot (:

Hey @Eugene, was wondering if you had implemented the call back based on a range.  I see that I'm getting message in the log of:
Received start of range selection.
Received end of range selection.
Received start of range selection.
Received change of range selection.
Received change of range selection.
Received end of range selection.

and didn't know if that information was then sent back to us?

How to get the range of the selected dates.?

Fixed in https://github.com/Mozharovsky/CVCalendar/commit/89b1e42486a4bfea938211397aee902512981cd1

@elsesiy Is there any release planned soon that will make this feature available?

@zocario I'll see if I can release a new version by the end of this week.


explore show nothing after hard fork

https://explore.sia.tech/
show nothing

Devs are aware of the issue, It has been discussed in the Sia Discord.  Should be fixed soon.

To clear up any confusion, this is not an issue caused by the hardfork. You can enter any block in the search bar and it will display normally. It's a separate issue that affects only the front page.
Closing this since it's not relevant to this repo.


Methods annotated with [ModStartup] do not get executed

ModLoader.StartupMod(Mod) currently uses BindingFlags.NonPublic | BindingFlags.Public when searching for methods annotated with [ModStartup]. However, for any methods to actually be returned, the flags must include either BindingFlags.Static or BindingFlags.Instance.
This means that no methods annotated with [ModStartup] will actually be found - but no exception will be thrown either, making it silently fail.
This could be fixed by including BindingFlags.Static, which will find all static methods - instance methods annotated with it will not be executed.

Fixed by https://github.com/Carnagion/Modot/commit/544997918a82a678d3bb7367b235d191c2b76c53.


Fix root subnetwork weights normalization

Weights are upscaled to u16 for storage.
Therefore, weight normalization is required after weights extraction from storage.

superseded by https://github.com/opentensor/subtensor/pull/412


Validate data-required?

What is the best way to validate only required fields?

Validate.js has nothing to do with HTML forms, you just create the constraints based on what you want to validate. You cannot generate constraints based on form validations.


Active cases delta

Is your feature request related to a problem? Please describe.
No, Just a nice to have.
Describe the solution you'd like
It would be nice to have Active case changes delta. Ex. If 5 nos decreased in active we can show it in green. If 5 nos increased in active we can show it in red with count.
Describe alternatives you've considered
Additional context

Refer to https://github.com/covid19india/covid19india-react/issues/2105#issuecomment-641833409


Add a winui xaml sample

This PR adds an example of a WinUI application with an XAML file.

Thank you.


Remove Rdd obsolete properties

:shipit: Can you also take a look t this one: https://github.com/Microsoft/ApplicationInsights-dotnet/pull/186


FG for Text-To-Text Transfer Transformer

PR types

New features
PR changes

Models
Description

FG for Text-To-Text Transfer Transformer.

因格式导致冲突，将待 review 完成后处理。


[SMALLFIX] Refactor netty UnderFileSystemFile reader and writer.

To make code structure consistent with RemoteBlockReader and RemoteBlockWriter.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11370/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11371/
Test PASSed.

@calvinjia  I've added the docs. PTAL

@apc999  thanks for your comments. PTAL

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11372/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11373/
Test PASSed.

@apc999 the PR is updated, PTAL.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11374/
Test PASSed.


Fixed regex in tryMaximumBuy and tryMaximumSell methods

Changed regex from '-' to '' in method tryMaximumBuy and
tryMaximumSell. Splitter '-' was deprecated according to code in
PublicBaseClass: public synchronized void addPair(String pair) {
this.paramsBuf.append(pair.replace('-', '').toLowerCase()).append("-");
}

Thank you for attention!
btc_usd is a valid API format. BTC-USD is human readable. Method addPair() converts BTC-USD to btc_usd. Method CommonClass.convertPairName () converts pair name to human readable format. In the end, method tryMaximumBuy() uses spliter '-' after method CommonClass.convertPairName (). There is no error in this place.

Ok, thanks for describing ! If its okay with you, how can i contact you ? Im developing bot, but your API is a little bit complicated to understand.

You can email me to<EMAIL_ADDRESS>


Remove errors occuring when sidebar feature isn't enabled

The types Sidebar and SidebarWithContent didn't have cfg attributes.

thanks for catching that one. miss adding the required cfg attributes


highfive should not assign someone to their own PR

In https://github.com/rust-lang/rust/pull/84257 , rust-highfive assigned me to review my own PR.

@m-ou-se Ah, interesting. Ideally the bot should match ignoring case the same way GitHub does, but in the meantime, it sounds like the easiest fix would be to change my username in the configuration to all-lowercase.


Extend the stain matrices caching to normalizer.

That should vastly improve the efficiency of Vahadane algorithm when on-the-fly normalization is necessary for multiple iterations, e.g., for multiple epochs of downstream deep learning model training.

Done.


is it possible to lossless a jpg file ?

I need to upload pictures but first i'm going to resize them, and want to know if I can remove the exif info and to make it lossless.
Like this program does: imageoptim.com

This is one of those "read the docs" moments. :wink:
http://imageprocessor.org/imageprocessor/imagefactory/
http://imageprocessor.org/assets/docs/ImageProcessor.chm
The ImageFactory constructor contains a parameter preserveExifData which defaults to false. Any further optimization would have to be performed by the programs wrapped by the program you have mentioned.
https://github.com/JimBobSquarePants/ImageProcessor/blob/c5472548129828ee6095ffd36bd7aa19d56a2ff2/src/ImageProcessor/ImageFactory.cs#L68
Note: By default, ImageProcessor.Web does not preserve EXIF data. Post processing optimisation can be performed on processed files using the ImageProcessor.Web.PostProcessor plugin.

Sorry, my question was more about the lossless possibility.
With that I mean this:
http://stackoverflow.com/questions/5451597/how-does-googles-page-speed-lossless-image-compression-work
Maybe its a cool feature for in the future ;)

Got virus warning on ImageProcessor.chm

Thank you @precary but I am going to raise a few points here.

You've provided absolutely no useful information whatsoever in order for me to perform any analysis on your issue. (Antivirus platform etc)
You've hijacked a totally unrelated thread to do so.
Windows Defender (if it was that) reports a false positive. It's prudent to check other scanners before reporting. As you can see here 68 tests return a negative virus result. https://www.virustotal.com/en/url/afd26b55100cb2a2f572e2ac30b872b1a7aa498c7b6f66a972014ab07c2b9a7c/analysis/1469085503/

This is altogether considered bad etiquette in the open source community. Please read the provided contribution guidelines so that we may help each other more effectively in the future.
https://github.com/JimBobSquarePants/ImageProcessor/blob/Core/contributing.md

I'm sorry, you're right, got Spursint.A!cl on Windows Defender looked real


add validations

the same stat should not exist on an item or modifier multiple times
the same stat value combinations (eg, str=100,dex=100 on multiple attributes) should not be able to exist per file
invalid attributes should be logged
invalid values should be logged
invalid parsings should be logged (lines with # can be skipped)

base item score should be above 0


Bad message in ExternalXML parsing message

When reading an input XML with ExternalXML nodes, if there is a fundamental XML error (such as mismatched tags), the reported line number for the problem is with respect to the reconstructed XML, not the original, so it's quite difficult to locate what file the error is in.
This could be cleaned up by catching the error and raising it with more useful information when we attempt to read the external XML files.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or improvement?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
[x] 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?

with the fix in #1864, the error for single input file looks like:

and the error for external xml file looks like:

Changes to the error message do not constitute an operational change and don't requite a specific email. Approved to close via #1864.


fix: Use different mechanism to get WHEN clause in trigger definitions to avoid postgres internal error.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on dc/trigger-internal-error at 90.782%

Totals

Change from base Build<PHONE_NUMBER>2:
90.8%

Covered Lines:
3132

Relevant Lines:
3408

💛  - Coveralls


v2.0.1 throws MissingPluginException and crashes on Android

MissingPluginException is thrown and crashes my app when I use v2.0.1 on Android.
v2.0.0 on Android does not have this issue.
v2.0.1 on iOS does not have this issue.
Is there something I need to update to use v2.0.1 on Android?
Exception has occurred.
MissingPluginException (MissingPluginException(No implementation found for method getPage on channel flutter_plugin_pdf_viewer))

Thrown from:
/Users/user/fvm/versions/stable/packages/flutter/lib/src/services/platform_channel.dart

  @optionalTypeArgs
  Future<T?> _invokeMethod<T>(String method, { required bool missingOk, dynamic arguments }) async {
    assert(method != null);
    final ByteData? result = await binaryMessenger.send(
      name,
      codec.encodeMethodCall(MethodCall(method, arguments)),
    );
    if (result == null) {
      if (missingOk) {
        return null;
      }
      throw MissingPluginException('No implementation found for method $method on channel $name');
    }
    return codec.decodeEnvelope(result) as T?;
  }

Call stack:
MethodChannel._invokeMethod (/Users/user/fvm/versions/stable/packages/flutter/lib/src/services/platform_channel.dart:165)
<asynchronous gap> (Unknown Source:0)
PDFDocument.get (/Users/user/.pub-cache/hosted/pub.dartlang.org/advance_pdf_viewer-2.0.1/lib/src/document.dart:97)
<asynchronous gap> (Unknown Source:0)
_PDFViewerState._loadPage (/Users/user/.pub-cache/hosted/pub.dartlang.org/advance_pdf_viewer-2.0.1/lib/src/viewer.dart:151)
<asynchronous gap> (Unknown Source:0)

flutter doctor -v:
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-x64, locale en-US)
    • Flutter version 2.8.1 at /Users/user/Documents/Projects/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (3 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/user/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (2 available)
    • Nexus 5X (mobile) • 0256574f4c681f87 • android-arm64  • Android 8.1.0 (API 27)
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 96.0.4664.110

I am also receiving this exception on version 2.0.1 of advance_pdf_viewer using my Android device.
E/flutter ( 8502): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: MissingPluginException(No implementation found for method getPage on channel flutter_plugin_pdf_viewer)
E/flutter ( 8502): #0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:165:7)
E/flutter ( 8502):
E/flutter ( 8502): #1      PDFDocument.get (package:advance_pdf_viewer/src/document.dart:97:18)
E/flutter ( 8502):
E/flutter ( 8502): #2      _PDFViewerState._loadPage (package:advance_pdf_viewer/src/viewer.dart:151:18)
E/flutter ( 8502):
flutter doctor -v:
[✓] Flutter (Channel stable, 2.8.0, on macOS 11.6 20G165 darwin-x64, locale en-US)
• Flutter version 2.8.0 at /Users/emilyrainer/Developer/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision cf44000065 (4 weeks ago), 2021-12-08 14:06:50 -0800
• Engine revision 40a99c5951
• Dart version 2.15.0
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc5)
• Android SDK at /Users/emilyrainer/Library/Android/sdk
• Platform android-31, build-tools 31.0.0-rc5
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] IntelliJ IDEA Community Edition (version 2018.1.6)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.63.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.29.0
[✓] Connected device (2 available)
• SM G991U1 (mobile) • R5CR50YYD5T • android-arm64  • Android 11 (API 30)
• Chrome (web)       • chrome      • web-javascript • Google Chrome 96.0.4664.110

same here

same here
I downgraded back to 2.0.0 and it works ok, just throws the Android Deprecated old error

i had the same issue, but for me even downgrade to 2.0.0 won't work.
Wen I tap the button to open PDF the screen just close and the app close, with the same message.

After I change    advance_pdf_viewer: ^2.0.0 to   advance_pdf_viewer: 2.0.0 works.

same here
I downgraded back to 2.0.0 and it works ok, just throws the Android Deprecated old error

same here.

Having the same issue on android when I upgraded to 2.0.1.

same issue here
I/System.out( 9379): Already closed
W/System.err( 9379): java.lang.IllegalStateException: Already closed
W/System.err( 9379): 	at android.graphics.pdf.PdfRenderer.throwIfClosed(PdfRenderer.java:267)
W/System.err( 9379): 	at android.graphics.pdf.PdfRenderer.close(PdfRenderer.java:185)
W/System.err( 9379): 	at pt.tribeiro.flutter_plugin_pdf_viewer.FlutterPluginPdfViewerPlugin.getPage(FlutterPluginPdfViewerPlugin.java:206)
W/System.err( 9379): 	at pt.tribeiro.flutter_plugin_pdf_viewer.FlutterPluginPdfViewerPlugin.access$100(FlutterPluginPdfViewerPlugin.java:31)
W/System.err( 9379): 	at pt.tribeiro.flutter_plugin_pdf_viewer.FlutterPluginPdfViewerPlugin$1.run(FlutterPluginPdfViewerPlugin.java:84)
W/System.err( 9379): 	at android.os.Handler.handleCallback(Handler.java:873)
W/System.err( 9379): 	at android.os.Handler.dispatchMessage(Handler.java:99)
W/System.err( 9379): 	at android.os.Looper.loop(Looper.java:193)
W/System.err( 9379): 	at android.os.HandlerThread.run(HandlerThread.java:65)
D/PdfViewerPlugin( 9379): Retrieving page failed.
E/AndroidRuntime( 9379): FATAL EXCEPTION: flutterPdfViewer
E/AndroidRuntime( 9379): Process: io.rokt.com.otsuka.mobileapp, PID: 9379
E/AndroidRuntime( 9379): java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: flutterPdfViewer
E/AndroidRuntime( 9379): 	at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:1280)
E/AndroidRuntime( 9379): 	at io.flutter.embedding.engine.FlutterJNI.invokePlatformMessageEmptyResponseCallback(FlutterJNI.java:933)
E/AndroidRuntime( 9379): 	at io.flutter.embedding.engine.dart.DartMessenger$Reply.reply(DartMessenger.java:167)
E/AndroidRuntime( 9379): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler$1.notImplemented(MethodChannel.java:248)
E/AndroidRuntime( 9379): 	at pt.tribeiro.flutter_plugin_pdf_viewer.FlutterPluginPdfViewerPlugin$1.run(FlutterPluginPdfViewerPlugin.java:87)
E/AndroidRuntime( 9379): 	at android.os.Handler.handleCallback(Handler.java:873)
E/AndroidRuntime( 9379): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 9379): 	at android.os.Looper.loop(Looper.java:193)
E/AndroidRuntime( 9379): 	at android.os.HandlerThread.run(HandlerThread.java:65)
D/TransportRuntime.SQLiteEventStore( 9379): Storing event with priority=HIGHEST, name=FIREBASE_CRASHLYTICS_REPORT for destination cct
D/TransportRuntime.JobInfoScheduler( 9379): Scheduling upload for context TransportContext(cct, HIGHEST, MSRodHRwczovL2NyYXNobHl0aWNzcmVwb3J0cy1wYS5nb29nbGVhcGlzLmNvbS92MS9maXJlbG9nL2xlZ2FjeS9iYXRjaGxvZ1xBSXphU3lCcnBTWVQ0RkZMMDlyZUhKaTZIOUZZZGVpU25VVE92Mk0=) with jobId=-1646578455 in 9803ms(Backend next call timestamp<PHONE_NUMBER>115). Attempt 1

Facing same issue, Any solution for this?

I do have this issue on v.2.1.0
here the log from sentry
java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: flutterPdfViewer
    at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:3)
    at io.flutter.embedding.engine.FlutterJNI.invokePlatformMessageEmptyResponseCallback(FlutterJNI.java:1)
    at io.flutter.embedding.engine.f.b$a.a(DartMessenger.java:2)
    at f.a.d.a.k$a$a.c(MethodChannel.java:1)
    at i.a.a.a$a.run(FlutterPluginPdfViewerPlugin.java:8)
    at android.os.Handler.handleCallback(Handler.java:938)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:255)
    at android.os.HandlerThread.run(HandlerThread.java:67)

I think it is fine on 2.0.0 before

This package is working, trying to use it.
https://pub.dev/packages/advance_pdf_viewer_fork

https://github.com/lohanidamodar/pdf_viewer/blob/43ae962390ac51cd79b418f592073b14a871ece1/android/src/main/java/pt/tribeiro/flutter_plugin_pdf_viewer/FlutterPluginPdfViewerPlugin.java#L177
This line here cause exception on https://github.com/lohanidamodar/pdf_viewer/blob/43ae962390ac51cd79b418f592073b14a871ece1/android/src/main/java/pt/tribeiro/flutter_plugin_pdf_viewer/FlutterPluginPdfViewerPlugin.java#L203 before return. which result in null being return.
Can we get a fix on the official pub?

https://github.com/lohanidamodar/pdf_viewer/blob/43ae962390ac51cd79b418f592073b14a871ece1/android/src/main/java/pt/tribeiro/flutter_plugin_pdf_viewer/FlutterPluginPdfViewerPlugin.java#L177
This line here cause exception on
https://github.com/lohanidamodar/pdf_viewer/blob/43ae962390ac51cd79b418f592073b14a871ece1/android/src/main/java/pt/tribeiro/flutter_plugin_pdf_viewer/FlutterPluginPdfViewerPlugin.java#L203
before return. which result in null being return.
Can we get a fix on the official pub?

There is the error you mention, and also there should be a else block after the if here:
if (pageResult == null) {                                     Log.d(TAG, "Retrieving page failed.");                                     result.notImplemented();                                 }                                 mainThreadHandler.post(new Runnable() {                                     @Override                                     public void run() {                                         result.success(pageResult);                                     }                                 });
I created a pull request https://github.com/lohanidamodar/pdf_viewer/pull/101

Hi, when will be a new release with fix available?
Thanks!


Client Encryption: Adds fix to allow partition key path and id to be part of client encryption policy.

Description

Added support to include partition key path and id during encryption policy creation (only deterministic encryption type) and bumped up the format version.
Added support to encrypt the partition key and id during encryption.
Updated the encryption SDK version to 2.0.0

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
.Net PRs:

https://github.com/Azure/azure-cosmos-dotnet-v3/pull/3211
https://github.com/Azure/azure-cosmos-dotnet-v3/pull/3241

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes, or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-cosmos

/azp run java - cosmos - tests


loading images

Currently AssetKit uses stb_image to load images but maybe creating a separate library for images would be better and give more control for loading images.

Images are now passed to loader callback, AssetKit itself will no longer load images. In the future things may be changed.


Architecture: Strip all Javascript from static html archives by default

Type

[ ] General Question or Disussion
[x] Propose a brand new feature
[ ] Request modification of existing behavior or design

What is the problem that your feature request solves
Some websites use javascript to redirect any saved pages to the original site, thereby beaking archiving of pages on the site in question.
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Ideally, the option to scan the javascript in each downloaded file to prevent setting window.location in any form.
Since JS can be obfuscated in all sorts of forms, perphaps an option to simply strip out javascript from downloaded files could also be useful slash more reasonable to implement.
What hacks or alternative solutions have you tried to solve the problem?
Currently, the only real solution is to open up the offending HTML files myself and remove the javascript causing the redirects from the <script> tags.
How badly do you want this new feature?

[ ] It's an urgent deal-breaker, I cant live without it
[x] It's important to add it in the near-mid term future
[ ] It would be nice to have eventually

[ ] I'm willing to contribute to development / fixing this issue
[x] I like ArchiveBox so far / would recommend it to a friend

Yeah we're definitely adding this soon, it's a huge security issue currently to allow archived pages to run JS in a shared context, especially when opened via the filesystem.

Our new solution moving forward is likely going to involve serving untrusted JS from a different port + adding csp/cors/etc. headers, as JS sanitizing /stripping is inherently fraught with security risk and doesn't provide the best user experience.
Follow here for updates: https://github.com/ArchiveBox/ArchiveBox/issues/239


No saved events list screen: scrollable

Pre-flight check-list
Helps with https://github.com/redbadger/pride-london-app/issues/217 and https://github.com/redbadger/pride-london-app/issues/212
Before raising a pull request

[ ] Documentation
[x] Unit tests

Pre-merge check-list

[ ] Link to Trello ticket/GitHub issue (If applicable) https://github.com/redbadger/pride-london-app/issues/217 and https://github.com/redbadger/pride-london-app/issues/212
[ ] Any risky areas identified
[ ] Test plan provided
[ ] Tester approved

Tester check-list

[ ] Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):

[x] Galaxy S8 (Android 7.0/8.0)
[ ] Galaxy S7 (Android 6.0)
[ ] iPhone X (iOS 11.x)
[ ] iPhone 8 (11.x)
[ ] iPhone 7 (iOS 10.x)

Optional:

[ ] Google Pixel 2
[ ] Galaxy S8 Plus
[ ] Galaxy S7 Edge
[ ] Galaxy S6
[x] iPhone 7+
[x] iPhone 6

Accessibility Testing (If applicable)

[ ] Text-to-Voice (Android: Voice Assistant / iOS: Speak Selection)
[x] Large Text (=<200%)
[x] Landscape Screen orientation

Weak connection testing (If applicable)

[ ] Airplane mode
[ ] 2G/3G Network Settings

Looks good!


[PAPI-313] Index status rewind status fix

Couple minor comments but for the most part lgtm. Will need client fixes when deployed. I'll test it out locally early next week too prior to merging. Nice work 👍 the added benefit of knowing that we're indexing because we're actually rewinding will be nice to know.


add karmada operator roadmap

Hi, before the develoment of the project, we came up with a roadmap, it include core feature about karmada operator. if the roadmap is be determined, we will start follow the roadmap.

@lonelyCZ @RainbowMango PTAL

@Poor12 On today‘s community meeting, we had discussion on it. There's not a lot of discussion about whether we need to put community governance jobs on the roadmap, do you have any other opinions?

@Poor12 On today‘s community meeting, we had discussion on it. There's not a lot of discussion about whether we need to put community governance jobs on the roadmap, do you have any other opinions?

I'm ok. cc @RainbowMango for opinions.

There's not a lot of discussion about whether we need to put community governance jobs on the roadmap, do you have any other opinions?

I'm ok with it.

@RainbowMango thanks, updated

I'm really sorry that I didn't say it at the last review. Please update the file name to ROADMAP.md with the upper case.
No special reason, just keep consistent with the karmada repo.


Unit tests for rhtap

This pr adds the unit tests to fulcio for the new ws

/retest

/retest

This will fail until the updated images are in main

/approve

/retest


Allow for Oh My Zsh integration.

Start replacing $ZSH variable with $DOTFILES in a backward-compatible
way, so that existing users have a chance to migrate.
This implements the core idea of #246 in a more compatible way.
Fixes #70.

This is wonderful! Thank you so much!

Hi, I am starting to use these dotfiles just now. I am going through the opened Issues and PRs to see what I should integrate to my fork.
I definitly want to use Oh My Zsh, so thank you very much for this PR! :rocket:

🤦🏻 I just opend a very similar PullRequest: #377
Interesting approach here with the changes in the zshrc as well.
@holman What is your opinion in general to this change?


question

i do not know how to reach for help.
i have made my own reposetory "inventree-rexel-import".
i want to easly import products from rexel to inventree.
i have working code witch gives json data about the product.
this is demo.py in the inventree-rexel folder.
the plugin adds a button in the parts page, but when i press it it gives breefly the order history page and dissapeart. i cannot get this fixed. mostly the code is from this project. but i woud like to modify it to make it work for this plugin.
i only need a textfield and search button so i can execute the code (witch i still need to modifie for the plugin)
can you help me ?

Are you using this plugin as a starting point? First step would be to link to your project repository, and some screenshots of the behaviour that you are seeing

yes i do use it as a starting point.
the repository: https://github.com/Philipboy881/inventree-rexel-plugin
after a good nicht of sleep and making this post on a diffent pc, when i was trying to make this picture below
it just works,.....
did not change anything.

this is what i got right now. but i woud like to only get textfield for poduct number and a textfield for part PN number with a button import from rexel.
witch runs the code to create the json witch automaticly adds the data into the system
what files are important for doing this ?
(this is the first time is use python and the first time i use django. this is a new world for me.)

when i change in core.py
    return [
        path('history/', RexelView.as_view(), name='inventree-rexel'),
    ]

to
    return [
        path('rexel/', RexelView.as_view(), name='inventree-rexel'),
    ]

and in RexelPanel.tsx
const ORDER_HISTORY_URL = "plugin/inventree_rexel/history/";
to
const ORDER_HISTORY_URL = "plugin/inventree_rexel/rexel/";
after this change the site is still trying to call to history. am i missing somthing
browser cache, cookie,..

After you change the code in the .tsx file are you re-compiling the frontend code? The process should be:

Rebuild the front-end code with npm run build --emptyOutDir
Uninstall the plugin e.g. pip uninstall inventree-rexel-plugin
Reinstall the plugin e.g. pip install .

If you are running a local development InvenTree server, the plugin code should be auto reloaded (although you may have to restart the server).

Every time I do push the changes to GitHub, github recompiles the code an pushes it to pypi.
After this I go to the Inventree server
Here I stop the plugin then delete the plugin then in the console I restart inventree. After this I install the plugin and start the plugin. And again I do restart inventree. (Sudo systemctl restart inventree)
Then I test it.

@Philipboy881 that's a very convulted approach! You can short circuit that process significantly! When I am developing I install the plugin locally into the devcontainer setup and the InvenTree server auto-reloads the plugin code. It means that the time to have new UI code on the screen is ~20 seconds

I understand but I am not smart enough to set this up
I need a guide to do this. I never done this
If you can provide some information,..
And I am using visual Studio Code at this moment on Windows 10 pro


Ability to make SBT-generated warnings fatal

Sometimes, SBT itself logs a warning, e.g.:
[warn] Could not determine source for class org.foo.bar.BlortClass
In our project, the absence of the source for some classes leads to the compiled bytecode not correctly implementing the Java interfaces it should, which results in a confusing error further down the line.
It would be nice if there were an SBT option to make any warnings fatal, i.e. make them abort the build immediately.

I am closing this due to inactivity.


fix(37431): Formatter no longer normalizes spaces in method signature

Fixes #37431

Cool, yep! Looks good to me 👍

Congrats on 200 commits on the TypeScript repo! 🏆


delta-spark installation issues

I am installing Apache SPARK for the first time. I was able to install the docker container.
I ran the following command:
docker pull apache/spark and then started the container using
docker run -it apache/spark /bin/sh
Now I am trying to install the delta spark package.
Used the following command
pip install delta-spark
However I am getting the following error: ERROR: Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/home/spark' Check the permissions.

I'm not from delta.
This error hasnothing to do with spark/delta itself, so you'll not get much help here.
(At the same time you provided very little info to get any actual help)
Probably you should get to know a bit unix permission management (maybe first without docker's added complexity) via pages like: https://www.redhat.com/sysadmin/linux-file-permissions-explained
One you understand all that you should have to knowledge and tools to fix problems like this without any help ;)
Cheers, V


Release 1.7.1

links on release page , checked ✅

releases/download page

news

release note:

The news picture in PR description is broken

The news picture in PR description is broken

Updated.

Would you please keep the style we use for release notes?


[TEST] Unable to download support bundle: parse error

What's the test to develop? Please describe
Recently (likely has last more than 2 months) we are constantly encounter errors in daily regression all branches master, v1.5.x, v1.4.x when trying to download support bundle after test completed with the following error message:
parse error: Invalid numeric literal at line 1, column 7

Like in:
https://ci.longhorn.io/job/public/job/v1.5.x/job/v1.5.x-longhorn-tests-sles-arm64/25/
https://ci.longhorn.io/job/public/job/v1.5.x/job/v1.5.x-longhorn-tests-sles-arm64/24/
https://ci.longhorn.io/job/public/job/v1.5.x/job/v1.5.x-longhorn-tests-sles-amd64/13/
https://ci.longhorn.io/job/public/job/master/job/sles/job/amd64/job/longhorn-tests-sles-amd64/505/
https://ci.longhorn.io/job/public/job/master/job/sles/job/amd64/job/longhorn-upgrade-tests-sles-amd64/509/
https://ci.longhorn.io/job/public/job/master/job/sles/job/arm64/job/longhorn-upgrade-tests-sles-arm64/494/
https://ci.longhorn.io/job/public/job/master/job/sles/job/arm64/job/longhorn-2-stage-upgrade-tests-sles-arm64/181/
What causes this happening is still unknown.
Describe the items of the test development (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

[ ] item 1

Additional context
Add any other context or screenshots about the test request here.

It's highly possible that our regression test build encounters this issue and fails, and rerun is needed to get a normal completed build. cc @longhorn/qa @innobead

Is it possible that the timeout issue is causing the problem?

Not sure. Since it randomly happens and unable to reproduce in local, I'm still trying to figure out a way to insert logs in daily regression to collect useful information.

++ kubectl get svc -n longhorn-system longhorn-frontend -o json
++ jq -r '.spec.clusterIP + ":" + (.spec.ports[0].port|tostring)'
+ LH_FRONTEND_ADDR=<IP_ADDRESS>:80
+ echo <IP_ADDRESS>:80
<IP_ADDRESS>:80
+ JSON_PAYLOAD='{"issueURL": "Auto-generated support buundle", "description": "Auto-generated support buundle"}'
+ CURL_CMD='curl -s -XPOST [http://<IP_ADDRESS>:80/v1/supportbundles](http://<IP_ADDRESS>/v1/supportbundles) -H '\''Accept: application/json'\'' -H '\''Accept-Encoding: gzip, deflate'\'' -d '\''{"issueURL": "Auto-generated support buundle", "description": "Auto-generated support buundle"}'\'''
+ echo curl -s -XPOST [http://<IP_ADDRESS>:80/v1/supportbundles](http://<IP_ADDRESS>/v1/supportbundles) -H ''\''Accept:' 'application/json'\''' -H ''\''Accept-Encoding:' gzip, 'deflate'\''' -d ''\''{"issueURL":' '"Auto-generated' support 'buundle",' '"description":' '"Auto-generated' support 'buundle"}'\'''
curl -s -XPOST [http://<IP_ADDRESS>:80/v1/supportbundles](http://<IP_ADDRESS>/v1/supportbundles) -H 'Accept: application/json' -H 'Accept-Encoding: gzip, deflate' -d '{"issueURL": "Auto-generated support buundle", "description": "Auto-generated support buundle"}'
++ kubectl exec -n longhorn-system svc/longhorn-frontend -- bash -c 'curl -s -XPOST [http://<IP_ADDRESS>:80/v1/supportbundles](http://<IP_ADDRESS>/v1/supportbundles) -H '\''Accept: application/json'\'' -H '\''Accept-Encoding: gzip, deflate'\'' -d '\''{"issueURL": "Auto-generated support buundle", "description": "Auto-generated support buundle"}'\'''
+ SUPPORT_BUNDLE_RESP='
<title>502 Bad Gateway</title>

502 Bad Gateway

nginx/1.21.5

'
+ echo '
' '<title>502' Bad 'Gateway</title>
' '
' '
502' Bad 'Gateway

' '
nginx/1.21.5
' '
' '
'

 <title>502 Bad Gateway</title>

502 Bad Gateway

nginx/1.21.5

++ echo '
' '<title>502' Bad 'Gateway</title>
' '
' '
502' Bad 'Gateway

' '
nginx/1.21.5
' '
' '
'
++ jq -r '.links.self + "/" + .name'
parse error: Invalid numeric literal at line 1, column 7
+ SUPPORT_BUNDLE_URL=

Fixed in https://github.com/longhorn/longhorn-tests/pull/1521.


Validate IDREF's refer to something

All IDREF elements need to have a referent.
Pivotal story: 113393813

LGTM


[Feat] Caption for images; embed X; better UX for tooltip

Hello! I happened to come across your open-source project on daily.dev. Coincidentally, I’m also applying the Tiptap library with a few tweaks in my personal project. Taking a look at your project, I found it quite interesting, and it even has some cool features (Vietnamese language support, Excalidraw, Mermaid). However, there are still some limitations, and I hope you’ll continue to develop it in the future:

Add captions for images:

Embed X (Twitter)

(UX Bug) Tooltip should disappear when the cursor moves away from the tool.
When hovering over a tool, the tooltip overlaps with the tool above it, causing inconvenience when moving fast from a lower tool to an upper one.

[ ] Caption image
[ ] Embed Twitter
[x] Fix hide tooltip


Text of Out. notification panel not correctly shown (<IP_ADDRESS>)

The text of the item is not correctly show in the outgoing notification panel.
The "leave party button" on the outgoing notification panel does not work. (msg. in PoE: The target of this operation was not a party member)
Suggestion: is there a way to leave the party and go to your hideout with one button?
Edit: The bugged text does not happen with every item. So far I only had the problem with the Remnant of Corruption. Maybe a bug with case sensitive?

another example https://image.prntscr.com/image/ASM8yUg5THyMNRoEbskkWw.png

just no icon and a NP writes the name of currency
set your nickname in settings for leave button

Same bug with all new currencies from the league, you should add their icons to fix that.

ye i know, in next update


FSC NOR Flash AccessTime

I have an  issue with the access time of the 70ns NOR flash
if I calculate the the access time with the two relevant times (AdressSetupTime + DataSetupTime) * HCLK
(4+7)*5.95ns  = 65.4ns (@168MHz).
The result is less than the needed 70ns.
The used M29W128Gx might function, but this is not 100% assured.
/* excerpt from stm324x9i_eval_nor.c */
/* NOR device configuration */
Timing.AddressSetupTime      = 4;
Timing.AddressHoldTime       = 3;
Timing.DataSetupTime         = 7;
Timing.BusTurnAroundDuration = 1;
Timing.CLKDivision           = 2;
Timing.DataLatency           = 2;
Timing.AccessMode            = FMC_ACCESS_MODE_A;

Hi @UlfPGerlach,
Thank you for this report. We will get back to you as soon as we analyze it further. This may take some time. Thank you for your comprehension.
With regards,

ST Internal Reference: 185672


Error 'InvalidResourceType' when running the sample

Walking through the sample step by step fails for me at the Deploy the template step.
When running the following command:
az mesh deployment create --resource-group Demo --template-uri https://sfmeshsamples.blob.core.windows.net/templates/counter/counter.azurefilesvolume.linux.json --parameters "{\"location\": {\"value\": \"westeurope\"}, \"fileShareName\": {\"value\": \"demo\"}, \"storageAccountName\": {\"value\": \"rothiemeshdemostorage\"}, \"storageAccountKey\": {\"value\": \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\"}}"

I get the following error message:
Deploying . . .
Deployment failed
deployment correlation ID: c93a046e-d0a7-479b-b1a2-feca2b8d841c
There was an error when getting application resource counterApp.
To recieve additional information run the following to get the status of the application deployment.
az mesh app show --resource-group Demo --name counterApp
Deployment Errors:
{
    "code": "InvalidResourceType",
    "message": "The resource type could not be found in the namespace 'Microsoft.ServiceFabricMesh' for api version '2018-09-01-preview'."
}
{
    "code": "NoRegisteredProviderFound",
    "message": "No registered resource provider found for location 'westeurope' and API version '2018-09-01-preview' for type 'networks'. The supported api-versions are '2018-07-01-preview'. The supported locations are 'eastus, westus, westeurope, eastasia'."
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb141910-2325-da04-e131-e58487fb6a43
Version Independent ID: 8e4e14c0-b1ff-eb7f-0241-f781060862d0
Content: Store state in an Azure Service Fabric Mesh application by mounting an Azure Files based volume inside the container
Content Source: articles/service-fabric-mesh/service-fabric-mesh-howto-deploy-app-azurefiles-volume.md
Service: service-fabric-mesh
GitHub Login: @rwike77
Microsoft Alias: ryanwi

Thanks for the feedback! We are currently investigating and will update you shortly.

@robinmanuelthiel did you first setup the Service Fabric Mesh preview commands?
https://docs.microsoft.com/en-us/azure/service-fabric-mesh/service-fabric-mesh-howto-setup-cli

Yes, I did.

@robinmanuelthiel thanks for that. I tested this as well and it seems no matter what I do I get the same error as you do
@rwike77 can you take a look so we can get this doc updated to work correctly?

Thank you for taking the time to share your product and documentation feedback with us. Your input is valued because it helps us create the right documentation for our customers.
Due to the volume of issues in our queue, our policy is to close issues that have been inactive for the last 90 days. We hope to continue hearing from you.
Thank you.
#please-close


delete timelines from s3

Problem
Delete data from s3 when timeline deletion is requested.
Summary of changes
UploadQueue is not altered to support scheduling of delete operation in stopped state. This looks weird, and I'm thinking whether there are better options/refactorings for upload client to make it look better.
There is rather small change that can be separated: Changes to timeline broken state. I'll finish with the tests first and then I'll separate it into separate PR.
It is implemented directly in existing endpoint because changes are not that significant. If we want more safety we can separate those or create feature flag for new behavior.
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

resolves #4193

Remaining test failures appear to be just flakiness. One of them is in walreceiver logging, this is being worked on separately, and another one is a timeout in real_s3 test. I see a lot of simulated s3 failures in logs so decided to just increase the timeout.

I think its ready for another review round. I think we can merge it without feature flag and I'll cook it in a follow up (until that time we'll extensively exercise deletion on staging). I'd like to do it this way because current PR is already grown enough to avoid adding more changes (already needed to resolve conflicts several times).
In the original logic only review comments were applied. Aside from that rather big changes are: extended python tests https://github.com/neondatabase/neon/pull/4384/commits/b8f138257794084025cbcd0ed814c43fed298a2d and rust integration tests for deletion https://github.com/neondatabase/neon/pull/4384/commits/8f90c2830d18e14309f9ff2ac05331ab73709c2e
Planned follow ups (I'll add them to the project board if there are no objections):

mark file
feature flag

Now e2e tests failed for real :) Working on https://github.com/neondatabase/cloud/pull/5350


md-input needs "readonly" attribute binding

md-input needs "readonly" attribute binding which doesn't exist in alpha.4

duplicate of #343

Already covered in #343


test: Add support and unit tests for handling of multiple files passed as a pattern in data_config

Description of the change
Added unit test for testing handling of multiple files passed as a pattern in data_config yaml file.
List of supported/not supported examples for the feature of passing files via pattern:
Not supported: Passing all files of the directory with /* without mentioning the type of extension
For example: /path/to/directory/*
Supported: Passing all files of the directory with /* along with mentioning the type of extension
For example: /path/to/directory/*.json OR /path/to/directory/*.arrow OR /path/to/directory/*.parquet
Not supported: Passing files of the directory which matches any pattern for example*input_output* without mentioning the type of extension. For example: /path/to/folder/*input_output*
Supported: Passing files of the directory which matches any pattern for example *input_output* along with mentioning the type of extension.
For example: /path/to/folder/*input_output*.json OR /path/to/folder/*input_output*.parquet OR /path/to/folder/*input_output*.arrow
Related issue number
https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/1487
How to verify the PR
Verify unit test additions.
Was the PR tested

[x] I have added >=1 unit test(s) for every new method I have added.
[x] I have ensured all unit tests pass

Moved to PR: https://github.com/foundation-model-stack/fms-hf-tuning/pull/424


No resource found that matches the given name (at 'src' with value '@drawable/ic_menu')

Hi, I'm new here, so please forgive me and help with my naive problem. I've "installed" this implementation with gradlew.bat file. After setting some environment variables installation finished with success. Now, when I start blank activity in Android Studio and paste your this code:
<com.github.clans.fab.FloatingActionButton
android:id="@+id/fab"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="bottom|right"
android:layout_marginBottom="8dp"
android:layout_marginRight="8dp"
android:src="@drawable/ic_menu"
fab:fab_colorNormal="@color/app_primary"
fab:fab_colorPressed="@color/app_primary_pressed"
fab:fab_colorRipple="@color/app_ripple"/>
I receive Error:(20, 22) No resource found that matches the given name (at 'src' with value '@drawable/ic_menu').
Please help. If you need more information, ask me what you need.
Thanks.

I've built whole project directly in Android Studio, and it works now :D
Great


Auto Suggestions not coming no suggestions for general functions and local variables

Here are the screenshots

This is because you don't have the right dependencies of Jedi and Parso. So I'm going to close this issue as a duplicate of the one you just opened (#16679).


Azure Metrics Advisor Readme Issue

Section link

Reason:
Doc error.
Suggestion:
Update to Metrics Advisor
@jongio for notification.

Thanks for reporting @zzhxiaofeng
Can you send a PR to fix the same?

@ramya-rao-a Ok, I will fix this.

PR merged.


Correction for raw affiliation Centre Atlantique de Philosophie, 7463, EA, Nantes, France

Correction needed for raw affiliation Centre Atlantique de Philosophie, 7463, EA, Nantes, France
raw_affiliation_name: Centre Atlantique de Philosophie, 7463, EA, Nantes, France
new_rors: 059ynac98
previous_rors:
works_examples: W4306181632
contact: 93ff1c74f6da8e9bd0173bde5b902192:8c33fdefd9ac02e12d79a9e6202624 @ univ-nantes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.