Look into removing material ui packages

Users running in hosted environments with slower network latencies are experiencing Elyra startup delays that may be due to the lack of material ui packaging optimization.  We should understand where these costs are occurring and only packaging what is absolutely necessary for the proper functioning of Elyra.

We currently still use Material UI in three places:

Toast notifications in pipeline-editor
Theme Provider in ui-components
The Metadata Header UI in metadata-common

As for removing these:

Toast notifications are being added to core in 4.0, we can either wait or directly use the library they are merging into core (I believe it's not new code)
We already wanted to remove StyleProvider, so we can see how much we leverage ThemeProvider vs just generically wrap it ourselves
This will be the hardest since all the header functionality uses material ui and we will need to rewrite it

We currently still use Material UI in three places:

Toast notifications in pipeline-editor
Theme Provider in ui-components
The Metadata Header UI in metadata-common

We've discussed this in today's dev meeting:

Item 1 does not contribute to the reported performance issue. Thus there is no urgent need to address this right away and work can be held until JupyterLab 4.0 becomes available.
Work for item 2 will be tracked in https://github.com/elyra-ai/elyra/issues/2951
Work for item 3 will be tracked in https://github.com/elyra-ai/elyra/issues/2952

@jschaeck please subscribe to those issues


Expose Fl:event_key(int key)

Fl::event_key() is overloaded with a version that takes a key and returns true if the given key was held down (or pressed) during the last event. This makes it easier for games to check the current state of the key without waiting for a repeat event.

Thanks again


seccomp: fix mount emulation

Signed-off-by: Christian Brauner<EMAIL_ADDRESS>

Testsuite passed


Fix tests and adds support for custom schema

feat(api): adds support for custom schema

Adds support for custom schema i.e.:type (
    Config struct {
  	  Path string `schema:"{'required': true, 'starts_with': '/'}"`
    }
)

fix(test): typo and coroutine deadlock

Fixes #163

I like the annotations usage to describe richer schemas. Thanks for opening this. We will look into this feature as soon as we can. I am downgrading this one to "draft" until we can approach this -- also taking requests like https://github.com/Kong/go-pdk/issues/93 into consideration.


Update install-ssh-key.md

We got a user in the support team saying he struggled to figure out how to configure this.

@arammaliachi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@arammaliachi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@vijayma Would you review this pull request? Thank you.

@vijayma @steved0x - Could you review this community contribution pipelines pull request? Thanks.

@ktoliver I'll take a look, thank you.

#reassign steved0x

#sign-off

@steved0x: I'm sorry - only the author of this article, @vijayma, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@steved0x - Thanks for reviewing the pull request. It looks like the first part of the article has been substantially updated since the PR was opened. I resolved the merge conflict, and thus added the section that's new in this PR to what's current in master. Is the end result still good to go (merge)? Thanks.


python312Packages.adafruit-platformdetect: 3.72.0 -> 3.72.1

Changelog: https://github.com/adafruit/Adafruit_Python_PlatformDetect/releases/tag/3.72.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 328992 run on x86_64-linux 1

4 packages built:

python311Packages.adafruit-platformdetect
python311Packages.adafruit-platformdetect.dist
python312Packages.adafruit-platformdetect
python312Packages.adafruit-platformdetect.dist


Setting the value of reactive property in SSR overwrites the reactive property with the plain JS value

Version
2.7.2
Reproduction link
stackblitz.com
Steps to reproduce
I'm using the following Pinia store. All that's happening here is the state is being set to a value. According to Pinia's docs, this should work just fine. And indeed it does in the browser.
import serialize from 'serialize-javascript'

export const useSiteStore = defineStore('site', {
  state: () => ({
    domain: null
  }),
  actions: {
    async setSite(domain) {
      console.log(serialize(this.domain)) // { "value": null }
      this.domain = domain
      console.log(serialize(this.slug)) // "example.com"
    }
  }
})

What is expected?
The console.log outputs should match in structure with just the value having changed. I'm unsure whether it should be an object returned or strictly just the value, but it should be the same for both. this.domain should be updated reactively.
What is actually happening?
When this.domain = domain is executed, the reactive reference or whatever you'd call it is overwritten and replaced by a plain JS string. The result is that this.domain is no longer reactive.

I initially filed this issue with the Pinia team, but they don't seem convinced that this is a Pinia issue. https://github.com/vuejs/pinia/discussions/1425
I tried to setup the stackblitz but I'm getting an error I don't understand.

Possibly related to this? Or is a similar bug.

Your repro has a few issues, here is a fixed version: https://stackblitz.com/edit/vitejs-vite-dahva7?file=src/App.vue
But this is still missing the important part: the SSR

Surely someone on the Vue team has a way to test SSR functionality without me having to bootstrap an entire SSR project.

Repro: https://stackblitz.com/edit/vite-vue2-xcr4jb?file=src/store/site.js

Thank you @yyx990803


pilot/pkg/serviceregistry/kube tests are flaky

Example: https://gubernator.k8s.io/build/istio-prow/logs/istio-postsubmit/4173
Failures:
pilot/pkg/serviceregistry/kube.TestController_GetIstioServiceAccounts
pilot/pkg/serviceregistry/kube.TestController_getPodAZ
pilot/pkg/serviceregistry/kube.TestServices
/assign @irisdingbj who closed https://github.com/istio/istio/issues/10312

@linsun will find someone to cover for Iris

@ericvn is this still an issue?

This seems to be stable in post submits.
https://testgrid.k8s.io/istio-postsubmits-master#unit-tests&include-filter-by-regex=pilot%2Fpkg%2Fserviceregistry


Pass access token via headers

Closes #39
Implementation adds passing headers to HttpClient interface. kw::token param is explicitly excluded from the query on every request and passed as X-Consul-Token header instead.

Token overloading is a bit confusing for me too, not sure if there's a case where it would be useful.
Although ACLs is one of the features we don't use, at least for now (actually picked this one because of the issue), so can't really say anything about it.

I think I’d like to remove the ACL token overloading but this is a separate issue. Your change is not much related to it.

Thank you for the fix!


Feature request - Printing output only if passwords are found

A feature to work with the file option, where the script prints an output only if passwords are found for an email. It'll be really helpful while going through large list of email addresses.

a better option would be to output results into a file, what do you think?

I thought of that, but a simultaneous output on screen will be good and we can easily write it to a file using >
But if it can be printed (optionally) and also written to a file, then it'll be really good.

a better option would be to output results into a file, what do you think?

Currently I manually edit each update (of pwnedOrNot.sh) to remove the colour definitions in order to output a simple text file.   I also need to edit the sleep time, a variable or command line option would be nice.


docs.rs -> limit targets to windows-targets

While @Nemo157 was tracking down a performance regression with the windows-sys crate we saw that the docs are built for every default target, including linux and mac targets. Does the crate officially support these?
When not, setting the targets option in the docs.rs metadata could improve the build-time for the docs vastly. For example: the windows-sys crate docs contain around 2 million files over 5 targets. And when these are duplicates or for actually unsupported platforms we don't have to build these.

Something like this? https://github.com/microsoft/windows-rs/pull/1508

yep, that's it, thanks!
Are other pure windows crates missing this too?

I've applied the same to the remaining lib crates: https://github.com/microsoft/windows-rs/pull/1508/commits/b1c134801c63c7f8e64699176d9a8a85bba6516a


What are the requirements for a datestamp on Activity objects?

Currently, in every Activity example (e.g. "EXAMPLE Entity Change Notification for Create" in https://ld4.github.io/entity_metadata_management/api/0.1/recommendations.html#new-entity) we use the updated property to indicate the datestamp of the underlying change. However, we do not require this nor describe its use. The use of updated is not required by Activity Streams.

I think we need some consistent notion of datestamp to make sure that Activity objects are processed in the correct order and so that a harvester can restart from some point in the stream of updates. I think mandating updated would make sense.

FIXED with https://github.com/LD4/entity_metadata_management/pull/61


No cookies available

Could you please implement an opportunity to set Cookies for SRWebSocket? Like through MDWampTransportWebSocket or something.

Can you explain better what do you mean?

fixed in latest release 2.2.2


ros_image_to_qimage: 0.0.1-1 in 'galactic/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros_image_to_qimage to 0.0.1-1:

upstream repository: https://github.com/ros-sports/ros_image_to_qimage.git
release repository: https://github.com/ros-sports/ros_image_to_qimage-release.git
distro file: galactic/distribution.yaml
bloom version: 0.10.7
previous version for package: null

ros_image_to_qimage
* implemented ros_image_to_qimage package
* Contributors: Kenji Brameld, ijnek

@ijnek your package's package.xml is missing a description and valid license identifier. https://github.com/ros-sports/ros_image_to_qimage/blob/rolling/package.xml#L6-L8 could you please update those before release.

Don't know how I missed that, thank you for picking it up.
Closing this PR as superseded by https://github.com/ros/rosdistro/pull/31704.
I'd be interested in knowing if there is an easy way of appending changes to a release without increasing the package version number..?

I'd be interested in knowing if there is an easy way of appending changes to a release without increasing the package version number..?

Releases absolutely should not change without also updating the version number. Most tooling from Git all the way up to the package building tools assume that once a tag is created it is immutable and every release engineer who has ever had to review an unusual change in a dependency will be grateful if package contents never change without a corresponding change in version number.
Changes that affect the repository source should always include a version bump. Updates to package metadata are perfectly valid patch release changes.


Safely throw the InstagramAuthException

I was getting this error:
"PHP message: PHP Catchable fatal error:  Object of class stdClass could not be converted to string in vendor/raiym/instagram-php-scraper/src/InstagramScraper/Instagram.php on line 528"

@sebbekarlsson Thanks.
When you get this exception?
When user, password is wrong?

I believe I got it when I got request rate-limited. It only happened sometimes.


Fix an Incorrect Code Example for App::subcommand_required

Also seems like Atom automatically removed trailing whitespaces when I saved the file. Shouldn't be a problem though, quickly ran cargo build + cargo test and nothing seemed to be broken.
You should probably set your editor to automatically remove trailing whitespaces, it will stop the above because there will be no trailing whitespaces :smile:

Awesome, thanks! :+1:
Could you change the git commit message to docs: fixFix incorrect code example for App::subcommand_required so that clog will pick up this commit and place it in the chnagelog once I make a new release? Then I can merge into master :)

Actually I can just re-base it, so no worries :D


Recent tracking data not showing on Profile

Describe the bug
The last several days of tracking data don't show up on my profile. This affects the day summaries on my profile. The number of undefined increases by one each day that is not tracked correctly
To Reproduce
Steps to reproduce the behavior:

Go to https://mtgarena.pro/u/Gorno/ and look at the data above May 31 (I played on both 6/1 and 6/2)

Screenshots
https://i.imgur.com/omWffSc.png

We are investigating the issue

Bug with social page is fixed. But we miss your data from June 1st and 2nd. You should use "Full Reset" button in your tracker to resume normal data uploads.


Export generated 3D Scenes Studio schema types

Summary of changes 🔍
Creates @microsoft/iot-cardboard-js/SchemaTypes entry point for consumers to import the generated 3DScenesConfiguration-v1.0.0.d.ts types.
These types are exposed on their own SchemaTypes entry point because the types are present as auto-generated .d.ts files.  The build wasn't working when these were barrel exported from the root index file because rollup does two passes in the build process.  First, it generates the actual ESM module chunks, then it uses the rollup-plugin-dts plugin to rollup up the associated types for each entry point.  There's likely  a way to get the generated types to show up on the root @microsoft/iot-cardboard-js, but if we're ok with having them live at the SchemaTypes entry point -- it's an easier change.
Testing 🧪
If you want to test, build the library, then import the .tgz generated in BuildArtifacts into a consuming application (such as the hosted app).  You should be able to import 3DScenesConfiguration-v1.0.0.d.ts types from the @microsoft/iot-cardboard-js/SchemaTypes path.

Checklist ✔

[ ] Linked associated issue (if present)
[ ] Added relevant labels
[ ] Requested developer reviews
[ ] Request UI review from design / PM
[ ] Verify all code checks are passing

Tested in 3D Scenes Client - export is working. Thanks for doing this.


⚠ Bofrost.es has degraded performance

In 95c8b79, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1548 ms

Resolved: Bofrost.es performance has improved in 923b723 after 8 minutes.


Remove glepnir/prodoc.nvim

The plugin is archived.
Checklist:

[ ] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[ ] The lines end with a .. This is to conform to awesome-list linting and requirements.
[ ] It's not already on the list.
[x] The title of the pull request is Add/Update/Remove `username/repo`  when adding a new plugin.
[ ] The description doesn't start with A Neovim plugin for.., or A plugin for...
[ ] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document.
[ ] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized).

Thanks for the PR!


Fix typo

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update; merging.
@Youssef1313 Thank you for making this fix.


Whitening for real input

Summary
Implement whitening for real input.
Input shape is (n_channels, n_samples).
This implementation may help us to use time-domain ICA.
close #65

Codecov Report

Merging #66 (bce7cb9) into develop (7ed0b43) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #66      +/-   ##
===========================================
+ Coverage    90.88%   90.95%   +0.06%
===========================================
  Files           18       18
  Lines         1536     1547      +11
===========================================
+ Hits          1396     1407      +11
  Misses         140      140

Impacted Files
Coverage Δ

ssspy/transform/whiten.py
96.15% <100.00%> (+2.82%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35213d1...bce7cb9. Read the comment docs.


[Refactor] Refactor the interface of major compaction

Why I'm doing:
PK index major compaction has not been supported in cloud native table. In current implementation, Tablet in local table and cloud native table is different., Status major_compaction(Tablet* tablet) should be refactored.
What I'm doing:
Refactor Status major_compaction(Tablet* tablet) to Status major_compaction(DataDir* data_dir, int64_t tablet_id, std::timed_mutex* mutex)
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/Mergifyio backport branch-3.1

https://github.com/Mergifyio backport branch-3.2


[OKTA] Create custom Okta workflow to send users an email upon reactivation

Background
When Okta users are re-activated after being suspended for inactivity, it's a silent process - they aren't notified that their status has changed. They'll be deactivated again at midnight EST unless they sign in the same day, so it's important to ask them to sign in promptly.
Action requested
There isn't a default Okta email for this status change, so we'll need to use an Okta Workflow instead. These workflows are created through a drag-and-drop editor in the Okta UI, and allow a finer degree of control over different events that happen within our Okta space. In particular, there's an Okta Workflow integration with SendGrid, which we already use to send non-Okta emails such as test result notifications to patients.
Acceptance Criteria
End users are emailed upon reactivation. This email language should also include a link to our instructions on password reset, as users frequently request a password reset after they've been reactivated. Other than that, we should be able to repurpose the text of the email that the support staff sends out manually today:

Thank you for contacting SimpleReport Support.
I just reactivated your account. You can use the email associated with your account and the password to login on simplereport.gov. Please do so before 6AM EST tomorrow to avoid the account being deactivated again. If that happens, just shoot us another email and we will reactivate again for you.
If you have any questions or further issues, please reach back out to our team.

Additional context
The support team will need to be notified once this is finished.

See #2833 for more details on the SendGrid integration.


Changing settings has no effect

Installed product versions

Visual Studio: 2019 Enterprise 16.9.4
This extension: 2.3.5

Description
I changed some settings in Tools -> Options -> Unit Test Boilerplate Generator, e. g.:
Custom mock field declaration format: private $CustomMockClass$ _mock$InterfaceMockName$; but the changed settings have no effect on the created boilerplate code.
Steps to recreate
Install Unit Test Boilerplate Generator extension
Move to Tools -> Options -> Unit Test Boilerplate Generator
Change settings,  e. g.:
Custom mock field declaration format: private $CustomMockClass$ _mock$InterfaceMockName$;
Create new test class using the extension
Current behavior
The extension settings are ignored
Expected behavior
The extension settings should be used

That's the format for custom mock implementations. Try editing the Test File Contents page.

@RandomEngy Yes I also changed settings on the "Test File Contents" page but without effect:

It looks like you are altering the settings for a different test framework. Pick the NUnit test framework at the top.

Hmpf ... oh yes you are right. I completely overlooked that. I apologize for the inconvenience.


fix: wrong extension for non-index .md files

Detailed description
The initial rules file contains an example for handling .md files but doesn’t set the correct extension for the resulting .html file. This change strips the .md extension and adds a .html extension.
To do

Tests

Excellent catch!


error in the logic in python os module output.

C:\Users\username\Desktop>rspy ./hello.py
.
C:\Users\username\Desktop>python ./hello.py
C:\Users\username\Desktop
C:\Users\username\Desktop>
C:\Users\username\Desktop>rspy "C:\Users\username\Desktop\hello.py"
C:\Users\username\Desktop
C:\Users\username\Desktop>

hello.py:
import os
print(os.path.dirname(file))

What version of Python were you testing this with?
Depending on your version of Python, the __file__ attribute may be an absolute path or a relative path.
$ cat 5038.py
print(__file__)

$ docker run --network host -it --rm -v $(pwd)/5038.py:/tmp/5038.py python:3.8-slim /bin/bash -c "cd /tmp; python3 5038.py"
5038.py

$ docker run --network host -it --rm -v $(pwd)/5038.py:/tmp/5038.py python:3.9-slim /bin/bash -c "cd /tmp; python3 5038.py"
/tmp/5038.py

$ docker run --network host -it --rm -v $(pwd)/5038.py:/tmp/5038.py python:3.10-slim /bin/bash -c "cd /tmp; python3 5038.py"
/tmp/5038.py

$ docker run --network host -it --rm -v $(pwd)/5038.py:/tmp/5038.py python:3.11-slim /bin/bash -c "cd /tmp; python3 5038.py"
/tmp/5038.py

The behavior changed in Python 3.9 as documented here.
$ rustpython --version
RustPython 0.3.0

$ cp 5038.py /tmp/5038.py
$ cd /tmp
$ rustpython 5038.py
5038.py

It appears that the current RustPython version matches the Python 3.8 behavior.
A possible solution is to modify run_script to call run_code_string with an absolute path.
$ rustpython 5038.py
/tmp/5038.py

This would also cause the traceback to contain the absolute path.
Before:
$ pwd
/tmp
$ cat 5038-traceback.py
raise Exception("5038")

$ rustpython 5038-traceback.py
Traceback (most recent call last):
  File "5038-traceback.py", line 1, in <module>
    raise Exception("5038")
Exception: 5038

After:
$ rustpython 5038-traceback.py
Traceback (most recent call last):
  File "/tmp/5038-traceback.py", line 1, in <module>
    raise Exception("5038")
Exception: 5038

$ python3 --version
Python 3.10.12
$ python3 5038-traceback.py
Traceback (most recent call last):
  File "/tmp/5038-traceback.py", line 1, in <module>
    raise Exception("5038")
Exception: 5038

I'm sure this solution will require more thought and testings.

hi hwoithe,
The python version is python 3.11 and the rustpython is RustPython 0.2.0.
Kindly help,
 Thank you.

Regards ,
ANVLISTENER


v6.2.0

Coverage increased (+0.1%) to 100.0% when pulling 674947f36ddaa1f004f5c79d42285548cb9a556b on release_candidate into a09598c8891b365a30ca79690416189ca5a8a510 on v6.


Experimental: Github Actions

This is an experimental pull request to explore using github actions. This is not intended to commit to anything, but to better understand if this is a good fit for this project.
Going to use this pull request to show my working for each step in the process. If this has legs this will form part of a proposal and we can apply these changes fresh with some more documentation and clean things up.
My general goals with this are to get a pipeline which:

Runs significantly faster than the current Jenkins pipeline for the same steps (5-7 minutes for a pull request build ideally)
Has minimal or no dependencies on custom images in docker/, runs using common actions steps

OK, so far so good. We can run the node tests pretty simply as expected.

Can we run ruby lint in a separate job? Yes we can. And fast!

Nice to see the checks tab populated, bonus.

Also noticed that it runs two builds. One for the commit and one for the PR.

Probably good, but I wonder if we can limit that later on?

OK, the docs build step runs too. Unsurprisingly this takes a little while the storybook build is slow, but still decent enough.

Also just noting here that this is not reporting "billable minutes" as it would for private repos, as public build minutes are free. We knew that going in, but good to confirm.

Hey pa11y runs

Going to try running selenium tests too. The ubuntu actions agents have a recent version of chrome pre-installed so I wonder if we can just test against that?

Hey! It ran!

Not running against grid as that’s for running against whole flock of testing nodes and we only really want one in CI, but it turns out we can just run it using the chrome image that’s pre installed on actions runners. Nice!

Got artefacts uploading. We probably only want to run this on failure, and watch out for the retention period as I've set it pretty short but otherwise all good.

Wondering about running server-dependent tests in parallel.
It looks like https://docs.github.com/en/actions/learn-github-actions/essential-features-of-github-actions#sharing-data-between-jobs might be the way to go combined with https://docs.github.com/en/actions/learn-github-actions/managing-complex-workflows#creating-dependent-jobs

OK, so this is basically working now.

This is running all the key steps we need in a pull request. A little clean up to do and then on to the harder stuff: running in browserstack and reporting to Slack. That needs secrets configuring first though.

Initial browserstack test ran OK

Need to fake the DOCKER_TAG for the time-being, but otherwise promising.

Closing this as the experiment did what it needed, starting to pull out mergeable changes from this PR.


Introducing a brief exp of Image License

Introducing a brief explanation of Image License
Fixes #1316
Description (required)
Added a (?) link at the right of spinner, that opens https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection in the user's language
Tests performed (required)
Tested on ProdDebug with languages English and Hindi.
Screenshots showing what changed (optional)

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

The PR is ready for riview @misaochan @maskaravivek !
I am facing this error in Travis :

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@tanvidadu I have restarted the build. Let's hope that it doesn't get stalled this time.

Codecov Report

Merging #1596 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1596      +/-   ##
=========================================
- Coverage    3.87%   3.84%   -0.04%
=========================================
  Files         150     151       +1
  Lines        7560    7623      +63
  Branches      708     708
=========================================
  Hits          293     293
- Misses       7250    7313      +63
  Partials       17      17

Impacted Files
Coverage Δ

.../free/nrw/commons/upload/SingleUploadFragment.java
0% <0%> (ø)
:arrow_up:

...in/java/fr/free/nrw/commons/upload/UrlLicense.java
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f47d39...a934d24. Read the comment docs.

The screenshot looks good to me. :) Should we make a new branch for the tutorial task, though, instead of merging to master? Admittedly this one could be standalone, but if we merge to master we will need to test it first.

I submitted this pr as a standalone as it is not directly related to quiz and tutorial, But we can surely direct it to new branch :)

Great job @tanvidadu , works for me. Sorry for long review time, we were busy with IEG tasks. Thanks for your contribution and patience:)

This is a nice little feature addition. :)


Create an action for validating knative boilerplate headers.

I wrote a little tool to facilitate checking file header boilerplate using some fairly simple fuzzy-matching heuristics.  This let's be drop yet another knobot check.
To see this in action, I ran this here with a number of boilerplate errors: https://github.com/knative/serving/pull/9486/files
I originally had this as part of knative-style.yaml, but pulled it out when I made it a matrix job, but I can fold it back together, just LMK folks preferences.

/hold

/lgtm

/lgtm

Going to try to get the latest round of actions merged everywhere, then I'll /unhold this.

@vagababov I updated this to Go 1.15.x, so this needs another look.

/lgtm

/unhold


Do not reach out to subprojects directly for test results aggregation in snippet

@jjohannes @rieske I'm OK with merging this version or the one from https://github.com/gradle/gradle/pull/14358 if you think those APIs are going to stick around for 6.7.

I'd propose to merge this for 6.8 once we have branched. Then we can continue the discussion (e.g. how would this look for non-java projects) and se if this leads use to some slight adjustments of the API. Which we can then do since this will stay undocumented in 6.7 for now.
I am fine to merge #14358 though for 6.7 in the meantime.

I agree with this suggestion. #14358 is also similar to what's required for Swift snippet https://github.com/gradle/gradle/pull/14381 at the moment.


lce_converter build from source error: /tmp/lce_android

Hi all
I was trying to build the Larq Compute engine in a virtual environment using Python3.7/TensorFlow2.4.1.
Given the instructions https://docs.larq.dev/compute-engine/build/converter/ and after executing
bazel clean --expunge
bazel build :build_pip_pkg
I get the following error:

(tf2.4) ➜  compute-engine git:(bazel3.7.0) ✗ bazel build :build_pip_pkg
Starting local Bazel server and connecting to it...
ERROR: Analysis of target '//:build_pip_pkg' failed; build aborted: The repository's path is "/tmp/lce_android" (absolute: "/tmp/lce_android") but a symlink could not be created for it, because: /tmp/lce_android (No such file or directory)
INFO: Elapsed time: 13,699s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (13 packages loaded, 27 targets configured)
currently loading: larq_compute_engine/mlir ... (3 packages)
Fetching @local_config_cuda; fetching
Fetching @local_execution_config_python; fetching
Fetching @local_config_sh; fetching
Fetching @local_config_cc_toolchains; Restarting.
Fetching @rules_java; fetching

Trying to solve using the script described here: https://docs.larq.dev/compute-engine/build/android/ worked out, just asking myself why this would be needed as the compilation for the converter is native for the host platform (macOS, Intel i5-8259U in this case) ?
Running the install script in a docker container makes sense, for a build on a host machine is there an alternative other than changing the install path in the script to something else than /tmp/lce_android ?

Hi @AdamHillier
I really have to say it is great work y'all did and I'm using it for research purposes.
Already talked to @lgeiger via mail about some specific questions, but I'm working on posting these as different issues ;)
Regarding your feedback:

building from latest master branch https://github.com/larq/compute-engine/commit/579c8fb02f69d6f08e1581206c7b9b00b5394028
did that yes. specifying Python install paths (in virtual environment) and optimization flags
yes, it went through building it (still compiling in this moment). just wondering why this step is needed as I'm only building the converter not the inference engine for Android for example

Hmm, that is very weird. I just did the following, also on MacOS, with a completely fresh LCE repo and Python environment:
git clone git@github.com:larq/compute-engine.git tmp-lce
cd tmp-lce
python3 -m venv env
source env/bin/activate.fish
pip install tensorflow
python configure.py
bazel build :build_pip_pkg

and after downloading the dependencies the Bazel analysis succeeded, and it started compiling files.

ERROR: Analysis of target '//:build_pip_pkg' failed; build aborted: The repository's path is "/tmp/lce_android" (absolute: "/tmp/lce_android") but a symlink could not be created for it, because: /tmp/lce_android (No such file or directory)

I really don't have any idea what could have caused this for you; that Bazel build target shouldn't be triggering anything Android related.
Any thoughts @lgeiger?

thanks for trying to reproduce. it really is weird.
just as additional hint, not sure if this is the cause though : I'm using bazel 3.7.0-homebrew and modified the .bazelversion to 3.7.0 (was 3.1.0 before)

thanks for trying to reproduce. it really is weird.
just as additional hint, not sure if this is the cause though : I'm using bazel 3.7.0-homebrew and had to modify the .bazelversion to 3.7.0 (was 3.1.0 before)

Oh that could well be it. If you don't need any new features from Bazel, could you possibly try reverting the Bazel version file to 3.1.0 and installing Bazelisk and using that instead (as in bazelisk build :build_pip_pkg). It should then detect the version file and automatically download and use the correct Bazel binary for doing the build.

so the build has finished.
did bazel-bin/build_pip_pkg artifacts and output is:

echo Tue Feb 2 18:15:41 CET 2021 : '=== Building wheel'
Tue Feb 2 18:15:41 CET 2021 : === Building wheel

python setup.py bdist_wheel
File "setup.py", line 24
raise ValueError(f"Invalid version: {version}")
^
SyntaxError: invalid syntax

Will try as you suggested.

so the build has finished.
did bazel-bin/build_pip_pkg artifacts and output is:

echo Tue Feb 2 18:15:41 CET 2021 : '=== Building wheel'
Tue Feb 2 18:15:41 CET 2021 : === Building wheel
python setup.py bdist_wheel
File "setup.py", line 24
raise ValueError(f"Invalid version: {version}")
SyntaxError: invalid syntax

I think the syntax error might be coming from the f-string usage, which suggests python configure.py might have configured a < 3.6 version of Python? You could try adding which python as a line above here to check that the correct version is being used.

within the virtual environment the which python command states :

Python 3.7.7
so that should be correct when executing python configure.py

so the compilation went fine this time. used bazelisk with bazel version 3.1.0, the initial error related to /tmp/android did not appear. good so far.
bazel-bin/build_pip_pkg artifacts also went through too, however when trying to install the generated pip wheel using:
pip install larq_compute_engine-0.5.0-cp37-cp37m-macosx_10_14_x86_64.whl:

ERROR: larq_compute_engine-0.5.0-cp37-cp37m-macosx_10_14_x86_64.whl is not a supported wheel on this platform.

am I right to assume that the build commands for larq_compute_engine do not need a minimum OS version and should build automatically on the host ?
(I'm on 10.13.6 High Sierra and weirdly the pip wheel looks like it was built for 10.14)

rerun to log output:

Tue Feb 2 21:56:18 CET 2021 : === Building wheel

python setup.py bdist_wheel
warning: no files found matching '*.pyd' under directory 'larq_compute_engine'
[WARNING] This wheel needs a higher macOS version than the version your Python interpreter is compiled against.  To silence this warning, set MACOSX_DEPLOYMENT_TARGET to at least 10_14 or recreate these files with lower MACOSX_DEPLOYMENT_TARGET:
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/tflite/python/interpreter_wrapper_lite.so
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/mlir/_graphdef_tfl_flatbuffer.so[WARNING] This wheel needs a higher macOS version than the version your Python interpreter is compiled against.  To silence this warning, set MACOSX_DEPLOYMENT_TARGET to at least 10_14 or recreate these files with lower MACOSX_DEPLOYMENT_TARGET:
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/tflite/python/interpreter_wrapper_lite.so
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/mlir/_graphdef_tfl_flatbuffer.so+ cp dist/larq_compute_engine-0.5.0-cp37-cp37m-macosx_10_14_x86_64.whl /Volumes/MacData/similuke/dev/larq/larq_compute_engine/artifacts

rerun to log output:

Tue Feb 2 21:56:18 CET 2021 : === Building wheel

python setup.py bdist_wheel
warning: no files found matching '*.pyd' under directory 'larq_compute_engine'
[WARNING] This wheel needs a higher macOS version than the version your Python interpreter is compiled against.  To silence this warning, set MACOSX_DEPLOYMENT_TARGET to at least 10_14 or recreate these files with lower MACOSX_DEPLOYMENT_TARGET:
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/tflite/python/interpreter_wrapper_lite.so
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/mlir/_graphdef_tfl_flatbuffer.so[WARNING] This wheel needs a higher macOS version than the version your Python interpreter is compiled against.  To silence this warning, set MACOSX_DEPLOYMENT_TARGET to at least 10_14 or recreate these files with lower MACOSX_DEPLOYMENT_TARGET:
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/tflite/python/interpreter_wrapper_lite.so
build/bdist.macosx-10.13-x86_64/wheel/larq_compute_engine-0.5.0.data/purelib/larq_compute_engine/mlir/_graphdef_tfl_flatbuffer.so+ cp dist/larq_compute_engine-0.5.0-cp37-cp37m-macosx_10_14_x86_64.whl ~/dev/larq/larq_compute_engine/artifacts

Hmm, that is weird. I don't know why it would default to a higher value than your native OS version :/
That said, we successfully build release wheels for MacOS 10.13, you can see the command flags we pass in order to do that here: https://github.com/larq/compute-engine/blob/579c8fb02f69d6f08e1581206c7b9b00b5394028/.github/workflows/release.yml#L134-L135

will compile again with these optimization flags

so built again with exactly the aforementioned flags

Hmm, that is weird. I don't know why it would default to a higher value than your native OS version :/
That said, we successfully build release wheels for MacOS 10.13, you can see the command flags we pass in order to do that here:
https://github.com/larq/compute-engine/blob/579c8fb02f69d6f08e1581206c7b9b00b5394028/.github/workflows/release.yml#L134-L135

this time the compilation resulted in a correctlarq_compute_engine-0.5.0-cp37-cp37m-macosx_10_13_x86_64.whl, installing it via pip in the virtual environment was successful.
importing larq_compute_engine in the python interpreter works as expected.
the only thing I noticed is when I'm directly in the root folder of the larq_compute_engine repo and starting the python interpreter. importing larq_compute_engine results in:

ModuleNotFoundError: No module named 'larq_compute_engine.mlir._graphdef_tfl_flatbuffer'

one thing I noticed is when I'm directly in the root folder of the larq_compute_engine repo. launching the python interpreter and importing larq_compute_engine results in:

import larq_compute_engine as lce
Traceback (most recent call last):
File "", line 1, in
File ".../larq_compute_engine/larq_compute_engine/init.py", line 1, in
from larq_compute_engine.mlir.python.converter import convert_keras_model
File ".../larq_compute_engine/mlir/python/converter.py", line 6, in
from larq_compute_engine.mlir._graphdef_tfl_flatbuffer import (
ModuleNotFoundError: No module named 'larq_compute_engine.mlir._graphdef_tfl_flatbuffer'

is that expected behavior?

This is expected. When in the root folder, the python import statement gives the larq_compute_engine folder higher priority than the package, and the _graphdef_tfl_flatbuffer.so (compiled library) file is not present there, it is only present in the compiled package.

@Tombana perfect.
thank you all for the support. still wonder why such an error during compilation is thrown by newer versions than bazel 3.1.0 but I consider this issue resolved

perfect.
@Tombana, @AdamHillier thank you all for the support. still wonder why such an error during compilation is thrown by newer versions than bazel 3.1.0 but I consider this issue resolved

digged a bit deeper into that error.
it definitely is related to the following lines in the WORKSPACE file:
https://github.com/larq/compute-engine/blob/7b08c3005bfe651f57955d0e45a3c326ce5d1edd/WORKSPACE#L97-L103
starting with bazel version 3.5.0 the error as follows is thrown:

Analysis of target '//larq_compute_engine/tflite/benchmark:lce_benchmark_model' failed; build aborted: The repository's path is "/tmp/lce_android" (absolute: "/tmp/lce_android") but a symlink could not be created for it, because: /tmp/lce_android (No such file or directory)

every other version until bazel 3.4.1 does not throw this error.
the Java function responsible for this is here:
https://github.com/bazelbuild/bazel/blob/7cfe416c5b702967b63cb2d9e2a2a2aefb8d2cac/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryFunction.java#L488-L492
checked the changelog of bazel 3.5.0, according to the docs it should be backward-compatible
when removing the cmd android_workspace in WORSKPACE even with bazel versions post 3.4.1

Hi @simonmaurer, sorry for the delay in getting back to you. Thanks for investigating the Bazel errors further :)
My gut instinct, without any evidence, is that this is a bug in Bazel that has been introduced, since as you say that release is meant to be backwards-compatible. Unfortunately, it's hard to have any insight in how to get this working with newer Bazel versions without actually trying to do upgrade. Since TensorFlow master is currently on Bazel 3.7.2, we will certainly have to address this when we update our TF dependency (which we probably do when/soon after the TF 2.5 release branch gets cut).
It's true that our approach of hard-coding this link to /tmp/lce_android is not the approach TF takes (perhaps it once was); they have dynamic configuration of paths to Android SDK/NDK environments as part of their configure.py, so likely the easiest thing for us to do would be to copy these functions into our own configure.py and delete the hard-coded lines. Of course, that's actually a much nicer solution anyway since it's much less brittle and allows interactive configuration.


use same method to clone/pull as parent repo

forcing ssh clone is annoying when working on many machines.
public keys have to be registered with github...
this will use the same method for fetching the submodules as
the parent repo.

okay, whatever i'll open a new pr, switching to spec-bioimage-io as well as changing default access method.


Implemented throttling + demo in jupyter notebook

KNTK-147

@mateuszmidor @lukaa12 @Fenthick
kentik_api_library/kentik_api/throttling/cmd.py
Design pattern?
class Cmd:
""" Command desing pattern - wrap method call into an object for easy queuing and retrying """

@mateuszmidor @lukaa12 @Fenthick
kentik_api_library/kentik_api/throttling/cmd.py
Design pattern?
class Cmd:
""" Command desing pattern - wrap method call into an object for easy queuing and retrying """


🔧 Correct DeprecationWarning config and comment in pytest settings

Nice, thank you @graingert! :rocket: :heavy_check_mark:


Return usk bytes directly from DerivationTool.deriveSpendingKey

This moves construction of the Kotlin UnifiedSpendingKey type from Rust to Kotlin.
Author

[ ] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Manual tests: Did you update the manual tests as appropriate? While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down.
[ ] Documentation: Did you update documentation as appropriate? (e.g README.md, etc.)
[ ] Run the app: Did you run the demo app and try the changes?
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage before and after changes and when possible, leave it in a better place.
[ ] Documentation: Did you review Docs, README.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the demo app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

Um
     FATAL EXCEPTION: main
Process: cash.z.ecc.android.sdk.demoapp.mainnet, PID: 6106
java.lang.UnsatisfiedLinkError: No implementation found for byte[] cash.z.ecc.android.sdk.tool.DerivationTool.deriveSpendingKey(byte[], int, int) (tried Java_cash_z_ecc_android_sdk_tool_DerivationTool_deriveSpendingKey and Java_cash_z_ecc_android_sdk_tool_DerivationTool_deriveSpendingKey___3BII)
	at cash.z.ecc.android.sdk.tool.DerivationTool.deriveSpendingKey(Native Method)
	at cash.z.ecc.android.sdk.tool.DerivationTool.a(SourceFile)
	at q2.h.d(SourceFile:13)
	at cash.z.ecc.android.sdk.tool.DerivationTool.g(SourceFile:71)
	at cash.z.ecc.android.sdk.tool.DerivationTool$b.m(SourceFile)
	at u4.a.n(SourceFile)
	at i5.i0.run(SourceFile)
	at androidx.lifecycle.e.a(SourceFile:45)
	at androidx.lifecycle.d.run(SourceFile:13)

Did some quick searching, and turned up two possibly-related issues:

https://stackoverflow.com/questions/57671093/java-lang-unsatisfiedlinkerror-no-implementation-found-for-byte-dji-midware-n

i.e. maybe a difference in how the NDK is set up in CI?

https://stackoverflow.com/questions/53934063/java-lang-unsatisfiedlinkerror-no-implementation-found-ndk-kotlin-fixed

i.e. maybe a race condition or some CI-specific difference in how the Rust library is loaded (given that it is loaded by RustBackend rather than DerivationTool)?

Closing because we found the solution to the JNI issues


merge from arlac77/template-github,arlac77/template-kronos-module

package.json

chore(package): add ^3.6.0 remove ^3.5.2 (devDependencies.ava)

:tada: This PR is included in version 10.0.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error: ENOENT: no such file or directory, open 'c:\Users\PSC.vscode\extensions\lvboda.vscode-img-fast-1.0.3\out\records.json'

help

Thanks for reporting this. This issue is a duplicate of #13. Please follow the original issue for updates.


What to do with Supabase auth OAuth state is invalid: signature is invalid

slug: supabase-auth-problems
category: note
I am still working on my same supasbase project from yesterday. This is what happens when I run my nextjs app with supabase locally and try to log in:

OAuth state is invalid: signature is invalid

The URL is : https://REDACTED.supabase.co/auth/v1/callback?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdocs.github.com%2Fapps%2Fmanaging-oauth-apps%2Ftroubleshooting-authorization-request-errors%2F%23redirect-uri-mismatch&state=REDACTED
Googling these errors is of course not helpful. However the error URI mentions URI registration: https://docs.github.com/en/apps/oauth-apps/maintaining-oauth-apps/troubleshooting-authorization-request-errors#redirect-uri-mismatch
I suspect this is the callback mentioned here:

I have to switch from:

https://lvjaeuxmhuiwhxwrejqa.supabase.co/auth/v1/callback
to: http://localhost:3000/talk/api/auth/callback - doesnt work

http://localhost:3000/auth/v1/callback redirects to smol.ai/talk/sign-in
http://localhost:3000/talk/auth/v1/callback doesnt work

i ended up solving it by switching the callback URL to the staging url... its been too long i cant remember what i did sorry. will double back if i run into this problem again.


Analytics rust_version is meaningless

We currently include a rust_version in our analytics. This comes from CARGO_PKG_RUST_VERSION which is:

The Rust version from the manifest of your package. Note that this is the minimum Rust version supported by the package, not the current Rust version.

(https://doc.rust-lang.org/cargo/reference/environment-variables.html)
This means it is pretty useless for out analytics. I think we should just remove it.

That's annoying. I'll just add the actual Rust version when I get a minute.


#11 added and updated models

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root

Version 62.0.3195.0 (Official Build) canary (64-bit)
ASUS C200M
System has been working fine, but after freeze & reboot: WiP #3025
/tmp/Xorg.crouton.1.log
Xorg_crouton_1.txt
$ sudo enter-chroot -n xenial
Entering /mnt/stateful_partition/crouton/chroots/xenial...
$ sudo apt remove xserver-xorg-legacy  // #3310 #2875
....
Package 'xserver-xorg-legacy' is not installed,
$ sudo startkde -n xenial
...
_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root
...
Error org.freedesktop.DBus.Error.UnknownMethod: Method "ReleaseDisplayOwnership
" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist
xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)
(EE)
Fatal server error:
(EE) no screens found(EE)
(EE)
Please consult the The X.Org Foundation support
at http://wiki.x.org
for help.
(EE) Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
(EE)
Error org.freedesktop.DBus.Error.UnknownMethod: Method "TakeDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist
(EE) Server terminated with error (1). Closing log file.
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: Connection refused
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...
$ sudo edit-chroot -all
name: xenial
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/xenial...
crouton: version 1-20170619181610~master:980f090f
release: xenial
architecture: amd64
xmethod: xorg
targets: kde
host: version 9874.0.0 (Official Build) canary-channel squawks
kernel: Linux localhost 4.4.79-11523-g797702bdfae8 #1 SMP PREEMPT Thu Aug 24 03:05:42 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...

maybe related to #2926
tried:
sudo sh ~/Downloads/crouton -u -n xenial
result unchanged.

i'm having this problem now! it's not related because... well...

probably to do with the following:
Error org.freedesktop.DBus.Error.UnknownMethod: Method "ReleaseDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist

also have this problem after I update chromeOS.
chronos@localhost / $ sudo startunity
.........
X.Org X Server 1.18.4
Release Date: 2016-07-19
X Protocol Version 11, Revision 0
Build Operating System: Linux 4.4.0-83-generic x86_64 Ubuntu
Current Operating System: Linux localhost 3.18.0-15976-g75b344ab7870 #1 SMP PREEMPT Mon Aug 28 11:13:29 PDT 2017 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 3584000 verity payload=PARTUUID=af91e370-fefe-c440-aa5f-aa0c75384420/PARTNROFF=1 hashtree=PARTUUID=af91e370-fefe-c440-aa5f-aa0c75384420/PARTNROFF=1 hashstart=3584000 alg=sha1 root_hexdigest=b35c22516e2ce65efbbff8a62889d6e94a7fbeea salt=1d5fdcf5c8d59d29f792976bffe990dec263f91ff22271458f48f5d10b3e7570" noinitrd vt.global_cursor_default=0 kern_guid=af91e370-fefe-c440-aa5f-aa0c75384420 add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic
Build Date: 17 July 2017  05:05:12PM
xorg-server 2:1.18.4-0ubuntu0.3 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.33.6
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Thu Aug 31 10:44:25 2017
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Error org.freedesktop.DBus.Error.UnknownMethod: Method "ReleaseDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist
xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)
(EE)
Fatal server error:
(EE) no screens found(EE)
(EE)
Please consult the The X.Org Foundation support
at http://wiki.x.org
for help.
(EE) Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
(EE)
Error org.freedesktop.DBus.Error.UnknownMethod: Method "TakeDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist
(EE) Server terminated with error (1). Closing log file.
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: Connection refused
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...
chronos@localhost / $ sudo enter-chroot -n xenial croutonversion
crouton: version 1-20170830174419~master:0b3ec2c2
release: xenial
architecture: amd64
xmethod: xorg
targets: unity
host: version 9887.0.0 (Official Build) dev-channel edgar
kernel: Linux localhost 3.18.0-15976-g75b344ab7870 #1 SMP PREEMPT Mon Aug 28 11:13:29 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...

Also getting this now.
Entering /mnt/stateful_partition/crouton/chroots/xfce...
/usr/bin/startxfce4: Starting X server

_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root

X.Org X Server 1.18.4
Release Date: 2016-07-19
X Protocol Version 11, Revision 0
Build Operating System: Linux 4.4.0-83-generic x86_64 Ubuntu
Current Operating System: Linux localhost 3.14.0 #1 SMP PREEMPT Tue Sep 5 03:03:41 PDT 2017 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 3584000 verity payload=PARTUUID=c40e2bed-36a9-154b-ac0a-42a5db64df9b/PARTNROFF=1 hashtree=PARTUUID=c40e2bed-36a9-154b-ac0a-42a5db64df9b/PARTNROFF=1 hashstart=3584000 alg=sha1 root_hexdigest=3cbdb8286f0d9acdf6a33f11d52170a375984826 salt=dbfc84a5ff629ffeb8fd54e70b51ea7979a2bfe810af661bfc6f34811df86d45" noinitrd vt.global_cursor_default=0 kern_guid=c40e2bed-36a9-154b-ac0a-42a5db64df9b add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic i915.enable_psr=1
Build Date: 17 July 2017  05:05:12PM
xorg-server 2:1.18.4-0ubuntu0.3 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.33.6
        Before reporting problems, check http://wiki.x.org
        to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
        (++) from command line, (!!) notice, (II) informational,
        (WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Sat Sep  9 02:27:45 2017
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Error org.freedesktop.DBus.Error.UnknownMethod: Method "ReleaseDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist

xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)
Error org.freedesktop.DBus.Error.UnknownMethod: Method "ReleaseDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist

xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)
(EE)
Fatal server error:
(EE) AddScreen/ScreenInit failed for driver 0
(EE)
(EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
(EE) Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
(EE)
Error org.freedesktop.DBus.Error.UnknownMethod: Method "TakeDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist

(EE) Server terminated with error (1). Closing log file.
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: Connection refused
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/xfce...

@c-dante try updating the chroot now with the newest version of crouton.

@dwaindibbly Yep -- thanks! solve'd

@peepo,
Maybe see if a crouton update might resolve your issue too.
Hope this helps,
-DennisL

Updating crouton then the release worked like a charm. Thanks!


add some SB and TB tests

Also I realized the direct_mut_to_const_raw test can be enabled in TB, so let's do that.

@bors r+

:pushpin: Commit 5d071eba9e73d6587fd651fd875d116458c4e1cf has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 5d071eba9e73d6587fd651fd875d116458c4e1cf with merge 69358d0643a11fba3811eabe77149d9d88b3c72c...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 69358d0643a11fba3811eabe77149d9d88b3c72c to master...


[Rogue] T13/Phase 4 additions, APL tuning, Combat reforging defaults

Dagger implementation mirrors that of SimC/Shadowcraft. Likely more APL adjustments that can be made, but ATM I'm being very conservative about additions that could impact T12 sims.
Default gearset selections remain on P3, plan to remain that way until P4 is imminent.

Still working on this. Caught something last week so I've been in and out of sleep and haven't been able to focus on this

Alright pretty sure I've figured out everything I need to for Combat, everything should be good to go here.


Add setup.py and python3 support

Add setup.py based on https://github.com/kennethreitz/setup.py.
Run python-modernize and add a couple fixes for Python3 support.
Simplify installation instructions.

Why such concern about it being available on PyPI?  I think of PyPI more as being for libraries and frameworks rather than general tools, so it feels a little wrong to be distributing it on PyPI.  I don't believe it's so much simpler to setup than simply copying a file, but I guess I'm in the minority here given the 2 other pull requests for this.  I'm also disappointed that you just went ahead and put it up on PyPI without really discussing it with me--it's a bit presumptuous. :-(  I would have done it myself if I was eager to have it up there.
I'm not too keen on taking Kenneth's work and calling it mine either--it's closer to a wholesale copy rather than just being modeled after his code.  It's also under a different license than my code and that hasn't been documented anywhere.
Don't get me wrong, I appreciate the updates but these little things are important.  Also, it would've been nice to separate out what were fixes from modernize vs. fixes to support python3 vs. adding a setup.py and updating the installation instructions, IMHO.

PyPI is great as a reliable, versioned store. Editable or otherwise bespoke installations of packages give me... shudders (thought I certainly do them at times) 😄
Apologies for the publication. Curious what the main hesitations are? Are there attribution changes you would like?
Modernize added the __future__ imports and updated the print statement. The non-modernize changes were to read the file as a string instead of as bytes, and the __lt__ was added for comparisons.

PyPI is great as a reliable, versioned store. Editable or otherwise bespoke installations of packages give me... shudders (thought I certainly do them at times) 😄

That's all great, but it's not really a Python library. :-)

Apologies for the publication. Curious what the main hesitations are? Are there attribution changes you would like?

Several reasons:

I didn't feel like it was ready
It wasn't Python 3 compatible
I'm not sure Python-based utilities should be published via PyPI, which I consider mainly a store for libraries and frameworks
Publishing on PyPI doesn't really feel like an easier install step, IMHO

Modernize added the future imports and updated the print statement. The non-modernize changes were to read the file as a string instead of as bytes, and the lt was added for comparisons.

According to the docs, we really have to implement the full complement of rich comparison operators instead.
Also, simply dropping binary off the file isn't really acceptable.  What encoding is it using?  (Hint: it's platform dependent and may run amok of other issues, and you can't really assume it's UTF-8 either as there are many systems that default to different encodings).  This doesn't really solve that problem.  I think a better answer is required on the encoding front rather than hoping it's going to workout okay, IMHO.  In fact, I think keeping everything as bytes is really the best answer.

Can you please take down markdown2ctags from PyPI.  I'm pretty sure it's broken for some encodings in Python 3.  Thanks.

Can you try my update-for-python-3 branch?  I don't love the encoding solution, but I think it'll work for more international environments.

Taken down.
The branch works for me functionally, +1. Thanks for helping out.

Taken down.
Couple nits on your branch: there is a python2 print statement in the sad path on L285, and version is defined twice. The code works for me functionally, +1.
Thanks for helping out.
I would still push for pypi publication mainly because it is the standard way to distribute Python code, and people are used to pip install-ing from pypi. Requiring a local checkout at a well-known path adds friction to the distribution process.

Taken down.

Thank you, I appreciate it.

Couple nits on your branch: there is a python2 print statement in the sad path on L285, and version is defined twice. The code works for me functionally, +1.

Good catch!  Fixed.

Thanks for helping out.
I would still push for pypi publication mainly because it is the standard way to distribute Python code, and people are used to pip install-ing from pypi. Requiring a local checkout at a well-known path adds friction to the distribution process.

Again, that's where I see things differently.  I don't really see PyPI as a place to distribute utilities, but I hear you.  OTOH, being on PyPI still doesn't help those who know nothing of pip and installing Python packages.  Also, people are free to package it and include it as part of a distro... pip isn't the only way to get there.  Of course, you don't really need to checkout anything, simply grab the raw file and put it on your file system,  But you aren't the first person to ask for this, so I'll do it.  I just want to run with this for a while before publishing.

I merged my python3 support branch into master.  Closing this, and thank you for testing.

@zackhsi Unfortunately, the fact that you registered markdown2ctags is creating a problem with publishing.  Can you add me as an Owner to the project so that I can fix this?  Also, I'll want to take over ownership and remove you from it.  I hope that's okay, but it helps ensure that only what I publish is available.

@zackhsi BTW, my pypi id is: jszakmeister

Done!

@zackhsi Sweet.  Thank you!  And we're published now: https://pypi.python.org/pypi/markdown2ctags

What a bright future we live in :)


⚒Update Behaviour on Receive

Description
UV mapping plays a very important role on visualization workflows. Currently when a new commit is received in Blender, our connector deletes the existing geometry and creates new ones (if im not mistaken). However, the shortcoming of this method is that if users have made a change in the UV mapping of an object, than change will get lost on new receive. This can get frustrating pretty fast.
For this reason, an Update mode (like in Revit, Rhino connectors) is needed. With this, the objects whose geometry has not changed will not be touched, only the objects with changes in geometry will be recreated.
Thanks [rorototo](https://speckle.community/u/rorototo/preferences/account) for this suggestion.
Suggested Solution
A dropdown menu with options:

Create - will create everything from scratch
Update - preserves unchanged objects and recreates only modified/deleted stuff

Streams
https://latest.speckle.dev/streams/dc855a2afe

Closing this ticket as we are moving to Jira to reduce noise. You can access it there.


Question: Writing to multiple masters

Can Onecache be configured to write to two or more masters? May be using pipepine to replicate on 2nd master.

Why not do it based on the current redis replication feature?

@anysql my understanding is that current Redis replication doesn't support master/master replication.

1, How heavy is the write traffic?
2, We have another project named "OneValue", which support master<->master replication and a timestamp based confilict solution. It's persistent KV storage with Redis protocol compatible, and has mutliple work threads for better single instance performance.
Thanks.

Expected peak TPS is ~10k
I have looked at it. Redis is approved product for cache usage so we may not be able to use onevalue.


Inappropriate pipelines implementation

Insertion operation in pipelines is being done in an inappropriate manner! Pipelines are supposed to process. filter, store, drop items within themselves or using external functions. The current implementation gives this complete job to database class, thereby taking away most essential features of pipelines viz. DropItem(), closeSpider(), etc.
Making a single pipeline do all the tasks isn't preferred because Scrapy queues many requests for pipelines. If one pipeline takes too much time doing things, other items need to wait a lot. While handling different functions in different pipelines makes data processing more reliable, faster and flexible!
Quoting Lines:
def insertIntoNewsTable(self, item):
        # Insert item into NEWS_TABLE after all the processing.
        try:
            if (self.connection.status != 1):
                self.openConnection(self.spider)
            postgresQuery = "INSERT INTO " + os.environ['NEWS_TABLE'] + " (title, content, image, link, newsDate, site_id, datescraped) VALUES (%s, %s, %s, %s, %s, %s, NOW())"
            processedDate = str(parser.parse(item.get('newsDate'), ignoretz=False))
            self.cursor.execute(postgresQuery,
                (item.get('title'),
                item.get('content'),
                item.get('image'),
                item.get('link'),
                processedDate,
                item.get('source')))
            self.spider.urls_stored += 1
        except psycopg2.IntegrityError as Error:
            # If the link already exists, this exception will be invoked
            if (Error.pgcode == '23505'):
                pass
            else:
                loggerError.error(str(Error) + " occured at " + str(item.get('link')))
        except Exception as Error:
            loggerError.error(str(Error) + " occured at " + str(item.get('link')))
        finally:
            return item

If any error occurs during insertion, or during date processing, or due to invalid data (checks for which are either invisible or not implemented), tracing back what caused the error is difficult! Also, the database shouldn't be queried if data is invalid or an error occurs! The connection can be used to process only valid entries!

Consider usage of the following class:
class ScrapenewsPipeline(object):
    # This class serves the purpose of cleaning the items received from spider,
    # Calling the instance of spider's postgresSQL class and calling functions
    # to create and destroy connection as and when needed.

    def open_spider(self, spider):
        # Called when a spider starts
        spider.postgres = postgresSQL()
        spider.postgres.openConnection(spider)

    def close_spider(self, spider):
        # Called when a spider closes it can't be used with logging enabled
        # because it is called just before the spider is closed and logging
        # table needs close reason, generated at close
        pass

    def process_item(self, item, spider):
        spider.postgres.insertIntoNewsTable(item)

Send data to the spider.postgres.insertIntoNewsTable(item) only after you are sure that the data is processed, currently it nothing is implemented because i do not see the need of any of the functions. :)
Note: spider.postgres.insertIntoNewsTable(item) is ideally suppose to enter data in PostgreSQL only.
Any processing shall take place in process_item(self, item, spider); Hence, non of the features are sabotaged. :)
Cheers.

Any processing shall take place in process_item(self, item, spider)

I don't see any such processing happening in process_item, but yeah I can see it happening in processedDate = str(parser.parse(item.get('newsDate'), ignoretz=False)) in Database Class.

because i do not see the need of any of the functions. :)

No offense, but that's too much assumption! This is highly unreliable!

Any processing shall take place in process_item(self, item, spider)

I don't see any such processing happening in process_item, but yeah I can see it happening in processedDate = str(parser.parse(item.get('newsDate'), ignoretz=False)) in Database Class.
because i do not see the need of any of the functions. :)

You are correct about the incorrect implantation in this case.

because i do not see the need of any of the functions. :)

No offense, but that's too much assumption! This is highly unreliable!

There are no assumptions here, do consider reading the code before posting questions.
Cheers.

There are no assumptions here, do consider reading the code before posting questions.
Cheers.

The extract posted in the question is a part of code. So, I read the complete code before creating the issue. -.-

There are no assumptions here, do consider reading the code before posting questions.

The extract posted in the question is a part of code. So, I read the complete code before creating the issue. "-.-"

Excuse me, i have failed to understand the "assumptions" part in that case.
Do through some light on it. :)

Excuse me, i have failed to understand the "assumptions" part in that case.
Do through some light on it. :)

The assumption that spiders will only send the correct and complete data. :)

Excuse me, i have failed to understand the "assumptions" part in that case.
Do through some light on it. :)

The assumption that spiders will only send the correct and complete data. :)

I think you've not read the code properly, please consider reading the spiders; specifically,
 if item['title'] is not 'Error' and item['content'] is not 'Error' and item['newsDate'] is not 'Error':
this line is used to make sure incorrect data format is not send to the pipelines file!
If an incorrect date format is send to the pipelines; pipelines[167]: except Exception as Error: is suppose to cache the error! :)

if item['title'] is not 'Error' and item['content'] is not 'Error' and item['newsDate'] is not 'Error':

Implementing this in every spider just reduced the chances of errors from that spider(s). Pipelines must be ready to make sure no unwanted info is stored in database due to any single faulty spider or logic implementation. P.S. There are many developers Designing their spiders. All using their methods to minimise errors. You can't guarantee no errors. :) Or if you can, write and give me, I'm good with it.

If an incorrect date format is send to the pipelines; pipelines[167]: except Exception as Error: is suppose to cache the error! :)

And tell me a way how will I know it was date and not database which caused error. Oh wait, I just though of implementing more complex date extraction and data processing before dumping into Database. So bad, I'll have to modify the function and add so many lines of code to it that it'll not live to it's name.

if item['title'] is not 'Error' and item['content'] is not 'Error' and item['newsDate'] is not 'Error':

Implementing this in every spider just reduced the chances of errors from that spider(s). Pipelines must be ready to make sure no unwanted info is stored in database due to any single faulty spider or logic implementation. P.S. There are many developers Designing their spiders. All using their methods to minimise errors. You can't guarantee no errors. :) Or if you can, write and give me, I'm good with it.

Feel free to make a change to implement the the re-check in the main pipelines class.

If an incorrect date format is send to the pipelines; pipelines[167]: except Exception as Error: is suppose to cache the error! :)

And tell me a way how will I know it was date and not database which caused error.

You can know that by reading the log file as the error would be present in it! :)
Oh wait, I just though of implementing more complex date extraction and data processing before
dumping into Database. So bad, I'll have to modify the function and add so many lines of code to it
that it'll not live to it's name.
However, while i don't see how this string related in the ongoing discussion but the issue is a possibility, feel free to make a function in the main pipeline class to read the date format and check it in before passing it to the postgreSQL class. :)


AzureCLI task does not cancel when build is canceled

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: AzureCLI
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number: https://msazure.visualstudio.com/Cognitive Services/_build/results?buildId=23889987

Agent - Hosted or Private: Hosted

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
[Include task name(s), screenshots and any other relevant details]

Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[Insert error from the logs here for a quick overview]

Hey @mhamilton723
Thanks for reporting the issue you are facing.
Are you facing this issue consistently ? If yes, will you be able to share a repro.
Is the task otherwise completing successfully if the pipeline is not cancelled ?
From first look it looks like the task/agent process hung and thus the task kept running.

Hey @hiyadav
i followed up on teams for ease of chat but heres a link to a build
https://msazure.visualstudio.com/Cognitive Services/_build/results?buildId=23900042
this is reliably reproable

Hi, @mhamilton723 this is not an error in Azure CLI task. This looks like an error in Azure CLI  'E2E' condition which comes out to be true even if you cancel your build and as a result, it isn't canceled. If you want to cancel this task on build cancel add "succeeded" condition.

Hi @mhamilton723, is the above solution working for you?

Hi @mhamilton723, I am closing this issue. If you any other questions feel free to ask.


fix: Import "gogoproto/gogo.proto" was not found

Closes #70
For Ignite to generate all proto files correctly, all modules should be registered in the app.go:
https://github.com/ignite/cli/blob/030bcd4a357f408c63d73b755625e0417f7545b7/ignite/pkg/cosmosanalysis/app/app.go#L86-L87

This is maybe a limitation CLI side for proto generation feature. So maybe we can create an issue CLI side.
Although I would not consider it very big as not having IBC in a chain is very very niche


Invalid date error on overlay

Bug Report
Describe the Bug
When loading a new image I get an Invalid date Invalid date overlay instead of the patient data. I'm using v2.

What steps can we follow to reproduce the bug?

Load study using JSON from url param
Example JSON:

{
  "studies": [
    {
      "StudyInstanceUID": "1.2.392.200036.9107.500.111704218022204451",
      "StudyDescription": "DEMO",
      "StudyDate": "20180223",
      "StudyTime": "020423.000000",
      "PatientName": "DEMO  DEMO",
      "PatientId": "DEMO",
      "series": [
        {
          "SeriesDescription": "DEMO",
          "SeriesInstanceUID": "1.2.392.200036.9107.500.220.17042.2018022220070409.122",
          "SeriesDate": "20180223",
          "SeriesTime": "020423.000000",
          "Modality": "CR",
          "instances": [
            {
              "metadata": {
                "Columns": 1430,
                "Rows": 1722,
                "InstanceNumber": 1,
                "AcquisitionNumber": 1,
                "PhotometricInterpretation": "MONOCHROME1",
                "BitsAllocated": 16,
                "BitsStored": 12,
                "PixelRepresentation": 0,
                "SamplesPerPixel": 1,
                "PixelSpacing": [
                  "0.17500000000000",
                  "0.17500000000000 "
                ],
                "HighBit": 11,
                "ImageOrientationPatient": null,
                "ImagePositionPatient": null,
                "FrameOfReferenceUID": null,
                "ImageType": [
                  "ORIGINAL",
                  "PRIMARY"
                ],
                "Modality": "CR",
                "SOPInstanceUID": "1.2.392.200036.9107.500.220.17042.20180222.200704.13701.1",
                "SeriesInstanceUID": "1.2.392.200036.9107.500.220.17042.2018022220070409.122",
                "StudyInstanceUID": "1.2.392.200036.9107.500.111704218022204451"
              },
              "url": "dicomweb://demourl"
            }
          ]
        }
      ]
    }
  ]
}

I'm also experiencing this, did you find a workaround Arturo?

I'm also experiencing this, did you find a workaround Arturo?

Not yet.

Commenting out
  cornerstone.metaData.addProvider(
    metadataProvider.get.bind(metadataProvider),
    9999

in extensions/cornertsone/src/init.js resolved this for me.

After I commented out this code, my mpr can't work properly. What about this?
cornerstone.metaData.addProvider(
metadataProvider.get.bind(metadataProvider),
9999

由基石的一般研究模块元数据提供程序未能返回任何提供的研究标题。
注释掉
cornerstone . metadata . add provider(metadata provider . get . bind(metadata provider)，9999

在extensions/cornertsone/src/init . js中为我解决了这个问题。(进一步详情这里)

After I commented out this code, my mpr can't work properly. What about this?
cornerstone.metaData.addProvider(
metadataProvider.get.bind(metadataProvider),
9999

@huangji123
You might also be able to change the priority of the cornerstone provider (e.g. '9999' -> '-9999') to allow the other providers to be responsible for the date fields, while still keeping mpr.
my mpr can't work properly what is wrong with it? MPR still works for me with this provider disabled.

Caused by cornerstone's generalStudyModule metaData provider failing to return any of the provided study headers.
Commenting out
  cornerstone.metaData.addProvider(
    metadataProvider.get.bind(metadataProvider),
    9999

in extensions/cornertsone/src/init.js resolved this for me. (further details here)

Solved the issue.

Caused by cornerstone's generalStudyModule metaData provider failing to return any of the provided study headers.
Commenting out
  cornerstone.metaData.addProvider(
    metadataProvider.get.bind(metadataProvider),
    9999

in extensions/cornertsone/src/init.js resolved this for me. (further details here)

Solved the issue.

Hello, could you tell me the reason why OHIF displays the garbled Chinese names?

Caused by cornerstone's generalStudyModule metaData provider failing to return any of the provided study headers.
Commenting out
  cornerstone.metaData.addProvider(
    metadataProvider.get.bind(metadataProvider),
    9999

in extensions/cornertsone/src/init.js resolved this for me. (further details here)

Solved the issue.

Hello, could you tell me the reason why OHIF displays the garbled Chinese names?

@huangji123 You might also be able to change the priority of the cornerstone provider (e.g. '9999' -> '-9999') to allow the other providers to be responsible for the date fields, while still keeping mpr.
my mpr can't work properly what is wrong with it? MPR still works for me with this provider disabled.

Hello, could you tell me the reason why OHIF displays the garbled Chinese names?

Caused by cornerstone's generalStudyModule metaData provider failing to return any of the provided study headers.
Commenting out
  cornerstone.metaData.addProvider(
    metadataProvider.get.bind(metadataProvider),
    9999

in extensions/cornertsone/src/init.js resolved this for me. (further details here)

Solved the issue.

Hello, could you tell me the reason why OHIF displays the garbled Chinese names?

@huangji123 You might also be able to change the priority of the cornerstone provider (e.g. '9999' -> '-9999') to allow the other providers to be responsible for the date fields, while still keeping mpr.
my mpr can't work properly what is wrong with it? MPR still works for me with this provider disabled.

Hello, could you tell me the reason why OHIF displays the garbled Chinese names?

Bug Report
Describe the Bug
When loading a new image I get an Invalid date Invalid date overlay instead of the patient data. I'm using v2.

What steps can we follow to reproduce the bug?

Load study using JSON from url param
Example JSON:

{
  "studies": [
    {
      "StudyInstanceUID": "1.2.392.200036.9107.500.111704218022204451",
      "StudyDescription": "DEMO",
      "StudyDate": "20180223",
      "StudyTime": "020423.000000",
      "PatientName": "DEMO  DEMO",
      "PatientId": "DEMO",
      "series": [
        {
          "SeriesDescription": "DEMO",
          "SeriesInstanceUID": "1.2.392.200036.9107.500.220.17042.2018022220070409.122",
          "SeriesDate": "20180223",
          "SeriesTime": "020423.000000",
          "Modality": "CR",
          "instances": [
            {
              "metadata": {
                "Columns": 1430,
                "Rows": 1722,
                "InstanceNumber": 1,
                "AcquisitionNumber": 1,
                "PhotometricInterpretation": "MONOCHROME1",
                "BitsAllocated": 16,
                "BitsStored": 12,
                "PixelRepresentation": 0,
                "SamplesPerPixel": 1,
                "PixelSpacing": [
                  "0.17500000000000",
                  "0.17500000000000 "
                ],
                "HighBit": 11,
                "ImageOrientationPatient": null,
                "ImagePositionPatient": null,
                "FrameOfReferenceUID": null,
                "ImageType": [
                  "ORIGINAL",
                  "PRIMARY"
                ],
                "Modality": "CR",
                "SOPInstanceUID": "1.2.392.200036.9107.500.220.17042.20180222.200704.13701.1",
                "SeriesInstanceUID": "1.2.392.200036.9107.500.220.17042.2018022220070409.122",
                "StudyInstanceUID": "1.2.392.200036.9107.500.111704218022204451"
              },
              "url": "dicomweb://demourl"
            }
          ]
        }
      ]
    }
  ]
}

Hello, could you tell me the reason why OHIF displays the garbled Chinese names?


Doesnt work after installing

Hello !
I install your plugin, but he goes to list "Incompatible Plugins", what i should to do?

Did you install it via Github clone command, like mentioned in the README?
Also: you might want to check out another plugin I basically moved this plugin into yesterday:
https://github.com/Tagirijus/TagiAutoActions

Feel free to provide further information. In the meantime I will close this issue. I will re-open it (or I think you might be able to), if I can reproduce your issue. Thanks!

Sorry, my kanboard was old, thank you for this plugin, i already install newest version :)

Nice! I am glad it works for you now. Still you might want to check out the other plugin, since I won't update this plugin anymore.
The difference in the other plugin so far: you have to set it up as an automatic action per project (thus you do not have to have this feature in every project) and you can also define your own colors in the configs with the new plugin.