Superset ingest: option to exclude drafts

Is your feature request related to a problem? Please describe.
We are using OpenMetadata to ingest Superset dashboards, and we have many dashboards that are in draft stage, and currently, they pollute the catalog and it is hard to find the real published dashboards.
Describe the solution you'd like
At the ingest sourceConfig, an includeDrafts option. When set to False drafts are not ingested.
Describe alternatives you've considered
An alternate solution might be to include "draft" vs "published" as a new metadata field, and allow filtering on that field during search. That could be a nice addition, but seems like simple than not ingesting. Drafts are inherently cruft for our use case.

Thanks for adding to the release! Taking a look at OM 1.2 (nice work!), and thinking:
Now that dashboard data models are first class in the UI, it would be ideal if this option could be applied to data models as well. For ex, an option to only ingest data models if they are part of a published dashboard

I will work on this issue


(PUP-8090) Load module translations from modulepath and vardir

These commits change the way module translations are loaded. Previously, module translations were only loaded from the module's directory when a new module object was created. This didn't work agent-side, where module files are loaded from $vardir instead of from the modulepath, and it also caused some unnecessary loading of translations.
The first commit causes all available module translations to be loaded from both the module path and $vardir when a puppet subcommand is run from the command line.
The second commit causes module translations to be loaded from $vardir on the agent whenever pluginsync occurs, before facts are loaded, to ensure that any messages in facts get translated.

CLA signed by all contributors.

Still need to add loading translations mater-side for compilation. Third commit incoming.

Updated.

I did some manual tests to verify that translations show up at the command line (including in faces from modules), on the agent (facts, types, providers), and during compilation on the server. I also verified that when you've installed the same module in two different environments with different translations, the correct translations will be displayed based on the requested environment.

Updated to delete text domains when environments are cleared.

Aaannd that broke unit tests. Lovely. Looks like I'll have to do some more aggressive stubbing.

Due to issues with test stubbing, I ended up moving the checks for whether gettext has been disabled into the GettextConfig module itself, instead of referencing puppet settings each time. This also provides more consistent behavior, as now the module itself controls avoiding all work once gettext has been disabled.
I filed https://tickets.puppetlabs.com/browse/PUP-8191 to investigate the issue around FastGettext repeatedly loading an empty.mo file every request. Unless this gets merged shortly, I'll be adding that work onto this PR.

@MikaelSmith did you want to review before I merge?

Already did, I'm good with it.


Create docker-image.yml

ci workflow added with GitHub action

Ci failed with Error "The input device is not a TTY"


doc: Add FreeBSD installation instructions

I've recently submitted port to FreeBSD's ports tree and my PR was merged today. That means from now on this application can be installed from binaries on FreeBSD.
On the side note: I can setup CI for FreeBSD if you wan. Let me know and i will submit a PR.

Codecov Report

Merging #371 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   66.01%   65.88%   -0.14%
==========================================
  Files          19       19
  Lines        1795     1794       -1
==========================================
- Hits         1185     1182       -3
- Misses        610      612       +2

Impacted Files
Coverage Δ

src/flags.rs
64.16% <0.00%> (-1.16%)
:arrow_down:

src/meta/mod.rs
17.11% <0.00%> (-0.91%)
:arrow_down:

src/display.rs
26.66% <0.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb931b5...df604dd. Read the comment docs.

Thanks a lot.
Yeah, CI would be nice. If you could submit that as another PR, I would be happy to merge that in.

Codecov Report

Merging #371 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   66.05%   65.88%   -0.18%
==========================================
  Files          19       19
  Lines        1803     1794       -9
==========================================
- Hits         1191     1182       -9
  Misses        612      612

Impacted Files
Coverage Δ

src/icon.rs
96.41% <0.00%> (-0.10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2107785...cec0e34. Read the comment docs.


Issue: Exposing code-server localhost URL to Internet, through secure tunneling using ngrok

Hello,
How can I expose the local code-server URL to the Public Internet using ngrok secure tunnels?
I tried multiple ways, but unable to achieve the desired outcome.
Let's say I expose the local URL using ngrok as follows:
ngrok http 8443
I get the following error in the browser when I use the public URL generated by ngrok that maps to my internal URL for code-server:

When I Inspect the requests through ngrok public URl using the ngrok Inspector, I get the following info:

I searched extensively across the web to see if anyone else encountered such issues, but could not find anything anywhere.
Kindly help with your thoughts/suggestions.

using --alow-http to start code-server

Thanks!

Is it safe to close this one @bahreex ?

Is it safe to close this one @bahreex ?

Yes. Definitely :-)


Project structure and file system layout

Proposal and brainstorm kickoff for the general project structure. This shouldn't be too technical but rather serve as a way to capture the components involved.
external-dns/
  cmd/external-dns/        <= place for external-dns binary
  pkg/producers/           <= place for producer implementations (kubernetes, fake, ...)
  pkg/consumers/           <= place for consumer implementations (route53, googledns, ...)
  pkg/controller/          <= place for orchestrator that connects producers and consumers
  pkg/util/                <= place for commonly shared code
  vendor/                  <= place for vendored libraries (maybe wrong with bazel)

Questions

Different naming for producers and consumers? e.g. sources and targets?

I would prefer to be slightly more concrete here.
Consumers and targets do not really reveal the purpose of the package. They are normally dns-providers, but for running external dns locally we would need to provide a local-implementation of dns-provider. I would go with something more explicit (e.g. dnsprovider) and create a fake dns-provider implementation inside the package.
For producers, if we go with the approach of creating separate implementations for services/ingress/fake endpoints/etc. (separate files and structs) I am okay with the sources. If we go with single kubernetes implementation, then the name should probably indicate "kubernetes endpoints" in some way and probably we would only need fake-kubernetes and kubernetes  for running in cluster or producing fake endpoints and local testing.

Plus, @justinsb I remember you mentioned that we can use https://github.com/kubernetes/kubernetes/tree/master/federation/pkg/dnsprovider

:+1: on being more concrete, dnsprovider sounds good.
For the sources, I like the idea of separate implementation for services/ingress/fake endpoints. And, if we plan on using the package @justinsb mentioned, then we could easily satisfy the ResourceRecordSet interface it provides.

one more thing, in my mind dnsprovider should be extremely simple layer with barely any logic and simple API calls to Route53/Google DNS/Azura DNS etc. Therefore, we will supply it the list of records (single struct type to be converted in each dns provider to right type, e.g. AWS RRS etc) to be created/updated/deleted and dns will do the simple job.

Just for reference, an (important) comment on having pkg as directory structure:https://rakyll.org/style-packages/ .
I know it's widely used in Kubernetes but I don't see the point here.

@Raffo agree with not using pkg as package :P let's keep it as flat as possible :)

I dropped the pkg prefix and added the place for the Plan object (https://github.com/kubernetes-incubator/external-dns/issues/13).
I admit, this issue is a little pedantic. But it's better to talk about stuff in our heads early on in the open.

https://github.com/kubernetes-incubator/external-dns/pull/23

https://github.com/kubernetes-incubator/external-dns/pull/25

is there still anything missing ?

good to be closed from my side


Synchronize documentation

This PR syncs the improved documentation from adieyal/sd-dynamic-prompts#701 back into this repository.
It's somewhat duplicating README.md, so that should probably be taken care of too...

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff47441) 97.43% compared to head (08a53c5) 97.43%.
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files          77       77
  Lines        3352     3358    +6
=======================================
+ Hits         3266     3272    +6
  Misses         86       86

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


No available engine for Illuminate\Database\Query\Expression

Summary of problem or feature request
No available engine for Illuminate\Database\Query\Expression apeared when i acces the db

Code snippet of problem
\DB::raw('SELECT * FROM v_transaksi');

DB::raw('SELECT * FROM v_transaksi')? Use query builder or collection.
DB::select('SELECT * FROM v_transaksi')
DB::table('v_transaksi')

i wanna select data from a view


analyse memory usage

https://embeddedartistry.com/blog/2020/08/17/three-gcc-flags-for-analyzing-memory-usage/

print mem usage in percentages

done


Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This solved the problem. The issue was the py-sort-imports extension.
From: VSCode Triage Bot @.>
Date: Tuesday, 19 December 2023 at 18:28
To: microsoft/vscode @.>
Cc: Dickreuter, Nicolas @.>, Mention @.>
Subject: Re: [microsoft/vscode] Jupyter notebook has no syntax highlithging (Issue #201095)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelineshttps://aka.ms/vscodeissuereporting. Please take the time to review these and update the issue.
Happy Coding!
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/201095#issuecomment-1863281433, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEAGM6S3IGE3A3BRLW22F5LYKHMGHAVCNFSM6AAAAABAYWMNRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGI4DCNBTGM.
You are receiving this because you were mentioned.Message ID: @.***>

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Use client assertion credential within AzurePipelinesCredential and WorkloadIdentityCredential

Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/4905
Follow-up to https://github.com/Azure/azure-sdk-for-cpp/pull/5789

/azp run cpp - identity

/azp run cpp - identity

/azp run cpp - identity

Any other feedback or thoughts before I merge this?


Update NPM to 0.0.5

https://www.npmjs.com/package/grunt-json-to-sass states "0.0.4 is the latest of 4 releases".
This prevents the installation of the latest (working) version via NPM.

+1

+1

Sorry about that, I published 0.0.5 to NPM.


Add an "export chat history" button to Terminal Chat

Summary of the Pull Request
Adds a button that, when clicked, copies the current chat history to the clipboard.
Validation Steps Performed
Chat history gets copied to the clipboard
PR Checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[ ] Schema updated (if necessary)

Screenshot of the button (it is placed next to the 'clear chat history' button)

Surprised we're exporting the chat history to the clipboard and not a file. I'd expect "export" to target a file.

Good point! Reworked the button to export to file instead

Separately, it'd also be cool if there was a "copy to clipboard" button on each message bubble (if there isn't one already).

Any "code" messages are already clickable to send the block directly to the current shell, I think copying for each message bubble is likely a little extraneous? Mostly because I could see the UI getting a little too busy with it

/azp run


Bounce overscroll does not occur when using RefreshIndicator

Steps to Reproduce
Run the flutter gallery on the iOS simulator and attempt to scroll past the bottom of the list in the "Over-scroll" demo. Notice that you do not get any overscroll indication when in "Refresh Indicator" mode.
[✓] Flutter (on Mac OS, channel master)
    • Flutter at /Users/drewwarren/flutter
    • Framework revision 5e2f04173a (16 minutes ago), engine revision 67a42cd19d

[x] Android toolchain - develop for Android devices
    x Android Studio / Android SDK not found. Download from https://developer.android.com/sdk/
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).

[✓] iOS toolchain - develop for iOS devices (Xcode 7.3.1)
    • XCode at /Applications/Xcode.app/Contents/Developer
    • Xcode 7.3.1, Build version 7D1014

[✓] Atom - a lightweight development environment for Flutter
    • flutter plugin version 0.2.3
    • dartlang plugin version 0.6.27

/cc @HansMuller

This is not high-priority for customer: fast, but would be nice to fix before their next release EOQ Q3.

EOQ3 is coming up fast. :)

@HansMuller posted https://github.com/flutter/flutter/pull/5836 this evening which might be a fix for this?

Yes, #5836 is intended to be a fix. Will mark it so.


sessions: Clear doesn't return potential error

Clear function in sessions.go doesn't handle the return value of the clear function.
https://github.com/abraithwaite/jeff/blob/a6a878dbd405856816ca5bd5b0899346b8ff8f5a/sessions.go#L225

Great point!  Do you think the preference would be to simply add an error return value to the signature of the function?
Technically I think that should backwards compatible, but it might throw a few vet errors for some users.

@abraithwaite I believe that changing the signature of an exported function breaks compatibility.
Thanks for catching that!
I see two possible solutions:

Break compatibility and bump the major version.
Introduce another function, with the correct functionality.

I don't think breaking compatibility is completely out of the question here.  It's certainly not a major breaking change and would likely not result in builds failing for most users.  Furthermore, I haven't tagged this as 1.0.0 yet, so minor breaking changes are definitely not outside the realm of possibility. :-)

Fixed in #25


x/pkgsite: copy button and view source code link in code snippet

This feature was originally mentioned in https://github.com/golang/go/issues/41587, and is now being tracked as a separate issue:
We'd like to add these features to the documentation section to improve usability:

Copy
Next to each code block, we will be adding a copy button, so that users can easily copy and paste the code in that block.
View Source Code
We also want to make jumping to the source identifier a more discoverable feature. To do so, if a block of code corresponds to a function, type or method, we will also include a source code widget. Clicking on that link will take users to the source code.

Updated mock for this issue:


update dependencies

PR-Codex overview
This PR focuses on updating dependencies across various packages, including improvements in version numbers and handling of token styles in the RenderCode function.
Detailed summary

Updated dependency versions in package.json files for various packages.
Increased size limit in .size-limit.json for thirdweb.
Enhanced RenderCode function in apps/portal/src/components/Document/Code.tsx to handle undefined htmlStyle for ThemedToken.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5029  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on  Graphite

Merge activity

Oct 14, 7:06 PM EDT: A user  merged this pull request with the Graphite merge queue.


Validation type

Validation is an applicative Either that accumulates errors as a semigroup!

Closing in favor of https://github.com/pointfreeco/swift-validation-semigroup and https://github.com/pointfreeco/swift-validation-near-semiring


Parents track not available

This PR fixes the issue https://github.com/iobio/gene.iobio.vue/issues/653 and #609
To test:
Launch gene.iobio from quarantest.
(You will get a warning: Unable to access OMIM, click OK)
Select Load your data
Select trio and GRcH38
Use the following URL's
https://iobio.s3.amazonaws.com/samples/bam/NA12878.GRCh38.bam
https://iobio.s3.amazonaws.com/samples/bam/NA12891.GRCh38.bam
https://iobio.s3.amazonaws.com/samples/bam/NA12892.GRCh38.bam
https://iobio.s3.amazonaws.com/samples/vcf/platinum-exome.GRCh38.vcf.gz
Add gene F5
Check if all tracks are visible

Refresh the link, so gene.iobio is now launched with URL. Check if all tracks are available.
Also the hyperlink on the title gene.iobio should be removed.

quarantest build successful. Demo link at
http://904d17e1.quarantest.iobio.io

quarantest build successful. Demo link at
http://bc691dc7.quarantest.iobio.io

Something still a little bit funky with the parent tracks - father track not showing up on refresh. To reproduce:

Do your instructions for loading that trio and choose gene F5.
Before refresh step, select gene APC.
Then refresh, and select Mother and Father tracks.
Father track is not displaying upon selection (just the label)

Good find. It looks like another bug..

Hi @stefinfection It looks like actually there are no variants found for the "father" track for gene APC and hence it is not displaying.
To test: Enter the data, select the gene "APC" and load. You can see the father label in optional track but the track is not displayed.

Now before the refresh, add the gene F5 or something else like PRX..
Refresh, both "Father" and "Mother" tracks should be displayed

For PRX gene after refresh:

URL: http://bc691dc7.quarantest.iobio.io/?gene=PRX&genes=APC,F5,PRX&species=Human&build=GRCh38&affectedSibs=&unaffectedSibs=&rel0=proband&vcf0=https%3A%2F%2Fiobio.s3.amazonaws.com%2Fsamples%2Fvcf%2Fplatinum-exome.GRCh38.vcf.gz&tbi0=&bam0=https%3A%2F%2Fiobio.s3.amazonaws.com%2Fsamples%2Fbam%2FNA12878.GRCh38.bam&bai0=&sample0=NA12878&affectedStatus0=affected&rel1=mother&vcf1=https%3A%2F%2Fiobio.s3.amazonaws.com%2Fsamples%2Fvcf%2Fplatinum-exome.GRCh38.vcf.gz&tbi1=&bam1=https%3A%2F%2Fiobio.s3.amazonaws.com%2Fsamples%2Fbam%2FNA12891.GRCh38.bam&bai1=&sample1=NA12891&affectedStatus1=unaffected&rel2=father&vcf2=https%3A%2F%2Fiobio.s3.amazonaws.com%2Fsamples%2Fvcf%2Fplatinum-exome.GRCh38.vcf.gz&tbi2=&bam2=https%3A%2F%2Fiobio.s3.amazonaws.com%2Fsamples%2Fbam%2FNA12892.GRCh38.bam&bai2=&sample2=NA12892&affectedStatus2=unaffected

Oh I see - but the coverage tracks should still be displayed for mother and father, right?

I am not entirely sure if it was changed or updated recently, but I think the coverage tracks for Mother and Father are shown when a Gene is clicked from the "Genes" tab..  We can create a separate issue for it.

Ok cool - everything else in this PR looks good to my eyes!

Couple of things:

Is it clear to a user that if the track isn't showing, there are no variants? I'm personally an advocate of being explicit with the user. Nothing showing could mean there are no variants, or there was a glitch and they didn't load. If there are no variants, could we explain state that is the case?

I followed the link above, and the gene model now appears in the top Gene card. On prod gene, the gene model is only included in the variant cards for each individual. This should be removed from the Gene card.


Refactor CA Cert secret names

Companion PR: https://github.com/SubstraFoundation/substra-backend/pull/55/files
Tested with populate / e2e :+1:
This PR removes duplicate secrets all pointing to the same certificate.

I don't know if we should follow this refacto.
In the past we came from this way (using ca-cert everywhere) to specify one variable for each (even if it's the same file here)
What do you think @GuillaumeCisco  ?

@AurelienGasser @GuillaumeCisco Can we sync to finish this PR. I think https://github.com/SubstraFoundation/substra-backend/pull/56 depends on it too since Aurelien merge the refacto in it

Yes that'd be great, unfortunately I'm extremely busy right now with priority development.

Closed in favor of https://github.com/SubstraFoundation/hlf-k8s/pull/20 and https://github.com/SubstraFoundation/hlf-k8s/pull/21


Enable CORS

It is a problem for JavaScript based clients, that they cannot use CWS directly, as there is currently no CORS headers set.

Although CORS is not enabled on a per-request basis, using the OPTIONS method, it should still work. If needed, then it would be better to do so using a wrapper for CWS, to avoid adding too much seldomly needed functionality into the core CWS.
Closing issue now.


new change in git-lab branch

pull request to merge to master

Approve pull request

Approve pull request


bug: even and odd in virtualscroll

Bug Report
Ionic version:
[x] 4.x
Current behavior:
odd and even is not working as expected in the *virtualItem directive.
for example:
<ion-virtual-scroll [items]="orden.itemslist" approxItemHeight="320px">
    <ion-item-sliding *virtualItem="let item; let odd = odd; let even=even;">
      <ion-item [color]="even ? 'next' : 'light'" >
....

should render a band color
Expected behavior:
Expected to draw band color equal to be using *ngFor directive.

Thanks for the issue. Can you provide a repo with the code required to reproduce this issue?

I made it work just using the index variable; It seems like only the index var is accesible in the *virtualItem of the ion-virtual-scroll. The odd or even is missing in the component.
Here is some code that works as expected:
  <ion-virtual-scroll [items]='filteredItems' lines="none">
    <ion-item *virtualItem="let item; let i = index;" [color]="i % 2 != 0 ? 'next' : 'light'"
     (click)="add(item)">
	{{item.value}}
    </ion-item>
  </ion-virtual-scroll>

let i = index;
[color]="i % 2 != 0 ? 'next' : 'light'"
this work as expected.
I just check the code and found this interface responsible for the variables:
https://github.com/ionic-team/ionic/blob/master/angular/src/directives/virtual-scroll/virtual-utils.ts

Thanks for the follow up. That is correct, we do not currently expose even or odd variables like the CDK Virtual Scroll component does. I am going to close this as this is not a bug in Ionic Framework. Thanks!


FR: Divide "messaging/registration-token-not-registered" error into more specific parts.

I'm not sure if this is the correct repo for this pr, but it is the codebase I'm working in.
I'm currently running into the error messaging/registration-token-not-registered, and found the documentation on it:

The provided registration token is not registered. A previously valid registration token can be unregistered for a variety of reasons, including:

The client app unregistered itself from FCM.
The client app was automatically unregistered. This can happen if the user uninstalls the application or, on iOS, if the APNS Feedback Service reported the APNS token as invalid.
The registration token expired. For example, Google might decide to refresh registration tokens or the APNS token may have expired for iOS devices.
The client app was updated, but the new version is not configured to receive messages.
For all these cases, remove this registration token and stop using it to send messages.

Given the documentation above, it would seem this error is quite broad, requiring an in-depth understanding of "app registration to FCM," "APNS tokens," "Expiration," and mis-configured apps.  I'm pretty uncertain where to start in terms of approaching it.
As a Feature Request, I think it would be really, really helpful if this one mega error was instead a few small ones, for instance:

messaging/registration-token-not-registered/apns-invalid
messaging/registration-token-not-registered/app-not-configured
messaging/registration-token-not-registered/expired
messaging/registration-token-not-registered/app-unregistered

SDK error codes aren't really hierarchical. They just look that way because they have the general form <service prefix>/<error code>. Plus I don't think the FCM service currently sends enough details in the error to distinguish between above 4 cases. So perhaps what we need a set of new error codes.

messaging/apns-invalid
messaging/app-not-configured
messaging/registration-token-expired
messaging/app-unregistered

But we'll want the FCM backend service to support these first.

Is there anywhere I should re-post this issue?  It's has become a huge blocker for me.

I'll have to try this out.  I'm currently using nativescript, so it'll end up being a bit different, but I should still be able to apply a lot of this logic.  Thank you very much!

@SephReed, where you found that registration token can expire? I can't find it in the documentation.

Whatever it was that was wrong, fixed itself.  Didn't change anything, just started working.  My guess is that it was the messaging/registration-token-not-registered/apns-invalid error.

@sgrigorev https://firebase.google.com/docs/cloud-messaging/send-message#admin_sdk_error_reference
ctrl+f messaging/registration-token-not-registered

I don't know the exact contents of the raw API response, but implementing https://github.com/firebase/firebase-admin-node/issues/756 might be helpful here.


Windows support testing

Codecov Report

Merging #1 (dc8b988) into master (b9804c9) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   67.21%   66.97%   -0.25%
==========================================
  Files          39       39
  Lines        7056     7082      +26
==========================================
  Hits         4743     4743
- Misses       1892     1917      +25
- Partials      421      422       +1

Impacted Files
Coverage Δ

...hub.com/google/pprof/internal/binutils/binutils.go
43.77% <0.00%> (-4.67%)
:arrow_down:

.../github.com/google/pprof/internal/report/source.go
80.76% <0.00%> (-0.65%)
:arrow_down:

...b.com/google/pprof/internal/binutils/addr2liner.go
65.43% <0.00%> (ø)

.../google/pprof/internal/binutils/addr2liner_llvm.go
70.96% <0.00%> (ø)

...ithub.com/google/pprof/internal/binutils/disasm.go
88.57% <0.00%> (+0.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9804c9...dc8b988. Read the comment docs.

Codecov Report

Merging #1 (dc8b988) into master (b9804c9) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   67.21%   66.97%   -0.25%
==========================================
  Files          39       39
  Lines        7056     7082      +26
==========================================
  Hits         4743     4743
- Misses       1892     1917      +25
- Partials      421      422       +1

Impacted Files
Coverage Δ

...hub.com/google/pprof/internal/binutils/binutils.go
43.77% <0.00%> (-4.67%)
:arrow_down:

.../github.com/google/pprof/internal/report/source.go
80.76% <0.00%> (-0.65%)
:arrow_down:

...b.com/google/pprof/internal/binutils/addr2liner.go
65.43% <0.00%> (ø)

.../google/pprof/internal/binutils/addr2liner_llvm.go
70.96% <0.00%> (ø)

...ithub.com/google/pprof/internal/binutils/disasm.go
88.57% <0.00%> (+0.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9804c9...dc8b988. Read the comment docs.


localization second part: Localization ffg strings

Corrected multilang string generation with commas and quotes.
Translating all text at the begining of the scenario lasts too long. And after language change everything needed to be refreshed. I changed the system not to translate keys until screen displaying. Load time is much shorter and after language change nothing need to be refreshed.
DictionaryI18n items loads the localization file raw data and create dictionary entrys as soon as they are needed. (unused keys wont become dict entrys).
split IniRead class into IniRead and LocalizationRead in order to separate in:

IniRead: Converts a ini file into dictionary with entrys without translations (keys remains the same)
LocalizationRead: Loads dictionaries (ffg for now) and defines static methods to translate keys,

Created the StringKey class to represent translatable key items (ffg ones for now). Changed string attributes of game components witch need to be translated.
Slightly changed hero selection in order to avoid name conflicts.
Created a ValkyrieDebug class to intercept log traces and disable all if needed in order to create individual unit tests.
Renamed StringI18n to EntryI18n.
Changed all strings that has an existing key in localization.txt file (hero names, monster names, expansion names).
Corrected tiles related issues descripted in #79 and #80
Fixed MoM character problem: There were 2 gloria goldbergs and no rita young.
Merged development branch including puzzle adds

I have finished changes for release 0.7.0 and am starting testing.  It would be great if you could help and report any issues you find.  I have cherry picked the tile name issues.  It is up to you if you want to get this pull request through now or wait for the next release, let me know.

I have just fixed Rita now.  Yes the test branch is development.

I stated testing. I found that when you click "Start Scenario" or "Scenario edit" it lasts few seconds because its reading all localization.txt entries and processing it. In my pull request i fixed it by not processing all entries in localization file. Instead it gets the localization file into rawdata and gets localized text as soon as it need to be translated. It makes the app faster.
The problem is that if we pull the request, someone who selects a non english language will get ffg texts in foreign language and valkyrie and quest texts in english. T_T.

I do like that change.  I can do something similar, but it would make your merge harder.  We could disable language selection for now.  If we are merging this there are a few other things to clean up.

ok, i will disable the options screen and then the language wont be selectable.

Ok. I merged all, fixed some problems, and removed the options menu. Now language cant be selected
i think it can be pulled correctly
I saw the House Linch adventure. Its amazing but, don't you think that converting a non public non free adventure (its included with mom1e) can carry problems with ffg?

This is part of why I removed the included quests, if it does get taken down Valkyrie should be safe.  I figured I could do that easier than come up with a completely new scenario that showed off what can be done, plus it forced me to expand/fix Valkyrie rather than work with it's limitations.

I have merged this to an 'integration' branch and fixed some of the issues there (not great fixes, but will do for now).
Will test a bit then merge from there to dev.


[BUG]  Spanish translation not working in some fields in "Glalie" template

I have Spanish translation working properly, but when I choose Glalie template, it does not translate the fields Phone Number and Email Address, which appear in English. All other templates get properly translated automatically.
BTW, will you add other templates? It will be really appreciated.
Kind regards,
fruizaviles

Yes, I try to generate and download PDF with spanish version and on the page the field of date when it's (actually) but when I download PDF shows "Present" in English.
I think it's a bug and I don't know how to solve. Thank you for help!


ToggleValue Type from connectToggleRefinement no longer exists

🐛 Bug description
I switched from the experimental Typescript version back to the mainstream version after typings were released in the main version and now I am no long able to import type { ToggleValue } from 'instantsearch.js/es/connectors/toggle-refinement/connectToggleRefinement'; because it doesn't exist as seen in the screenshot below showing connectToggleRefinement.d.ts.
🖥 Screenshot

Environment
"instantsearch.js": "4.28.0",

I haven't yet checked what the exact type ToggleValue used to be, but I assume it's meant to be ToggleRefinementValue


_pressed doesn't work with fab component

Description
_pressed doesn't work with fab component
CodeSandbox/Snack link
https://codesandbox.io
Steps to reproduce
No response
NativeBase Version
3.4.5
Platform

[X] Android
[X] CRA
[X] Expo
[X] iOS
[X] Next

Other Platform
No response
Additional Information
No response

This issue has been fixed in NativeBase v3.4.7


Feature/allow manipulating shared group's activities and updating all group instances

Feature Implemented !

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 11

Complexity increasing per file
==============================
- Ginger/GingerCoreCommon/Repository/BusinessFlowLib/ActivitiesGroup.cs  9

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 4

Complexity increasing per file
==============================
- Ginger/GingerCoreCommon/Repository/BusinessFlowLib/ActivitiesGroup.cs  9

See the complete overview on Codacy

merged, please update relevant ticket.


Safety and modularity

The namesake trait, CheckBytes, has an unsafe function:
pub trait CheckBytes<C: ?Sized> {
    /// The error that may result from checking the type.
    type Error: Error + 'static;

    /// Checks whether the given pointer points to a valid value within the
    /// given context.
    ///
    /// # Safety
    ///
    /// The passed pointer must be aligned and point to enough bytes to
    /// represent the type.
    unsafe fn check_bytes<'a>(value: *const Self, context: &mut C) -> Result<&'a Self, Self::Error>;
}

I don't see why it can't be safe.  Why not do
pub trait SafeCheckBytes<const N: unsigned> {
    /// The error that may result from checking the type.
    type Error: Error + 'static;

    fn check_bytes(bytes: [u8; N]) -> Result<(), Self::Error>;

    fn get_alignment() -> usize;
}

Also, it would be nice to decouple bit validation from alignment validation.  By decoupling these operations, the trait becomes more versatile and allows for interesting eager vs lazy validation of untrusted data.  Above, I suggested a simple function that returns the required alignment of the data.

The primary reason for using aligned pointers rather than checking byte slices is for better performance. A good example of this for builtin types is the nonzero integer checks, which load the underlying integer type and check that it's not 0. If the byte slices weren't aligned, an unaligned read would be required which could add up to a big performance hit for large arrays. Since the attitude should be performance-by-default, I think that requiring alignment is a good default to have.
Depending on how far you're willing to go, you can write CheckBytes implementations that don't require alignment:
#[repr(transparent)]
pub struct UnalignedNonZeroU32 {
    bytes: [u8; 4],
}

impl<C: ?Sized> CheckBytes<C> for UnalignedNonZeroU32
where
    NonZeroU32: CheckBytes<C>,
{
    type Error = <NonZeroU32 as CheckBytes<C>>::Error;

    unsafe fn check_bytes<'a>(value: *const Self, context: &mut C) -> Result<&'a Self, Self::Error> {
        let value = &*value;
        let aligned = u32::from_ne_bytes(value.bytes);
        let as_aligned = (&aligned as *const [u8; 4]).cast::<NonZeroU32>();
        NonZeroU32::check_bytes(as_aligned, context)?;
        Ok(value)
    }
}

What cases were you interested in where you would want to validate unaligned memory?

Thanks for the reply!
For nonzero integers, it would be useful to see data that forcing alignment enhances performance.  Two counter-hypotheses: (1) we could simply check that the bytes themselves are zero without casting to the integer type, or (2) perhaps unaligned reads are not actually inefficient in certain situations (e.g., perhaps for types that fit in registers); I have some early data from experiments I've been doing to suggest this.

What cases were you interested in where you would want to validate unaligned memory?

I've been working on a prototype in https://github.com/unicode-org/icu4x/pull/630 where I back an array of u32s with &[u8], using lazy unaligned reads when accessing elements from it.  I would like to generalize to types that require byte validation.

Closing for now since the referenced PR was closed, feel free to reopen or file a new issue if this is something you want.


Add a desc

This is Support

### Tasks
- [ ] https://github.com/kubernetes/website/issues/48034
- [ ] https://github.com/kubernetes/website/pull/48032
- [ ] https://github.com/kubernetes/website/pull/46326
- [ ] https://github.com/kubernetes/website/pull/47383

Closing as this is missing any kind of description or information. Looks like maybe an accidental submission? Please file an issue with more details if there is something you are trying to report.
/close


[Docs] Fix missing Object.assign on docs site

@mbrookes Could you maybe gpr this when you get a chance and see if it fixes it for you?
I'm a little confused why we're specifying the following configuration in both root/.babelrc and docs/src/.babelrc (and an empty object in docs/.babelrc). It'd be nice to clean this up but this at least fixed the docs site on my Safari 8.
"env": {
    "docs-production": {
      "plugins": [
        ["transform-replace-object-assign", "simple-assign"],
        "transform-react-remove-prop-types",
        "transform-react-constant-elements",
        "transform-react-inline-elements"
      ]
    }
  }

The other option would be to use https://babeljs.io/docs/usage/polyfill/.

That fixed it, thanks @newoga! :+1:

I'm still getting:
Failed to load resource: unsupported URL  webpack:///~/intl/lib/exp.js.map
Failed to load resource: unsupported URL  webpack:///~/intl/lib/cldr.js.map

etc, but it doesn't prevent the site from loading.

This looks good :+1:

Let's merge :tada:.


Update<EMAIL_ADDRESS>fix bns lookupProfile

Try out this version of the Hiro Wallet - download extension builds.

Pushing @pradel's https://github.com/hirosystems/stacks-wallet-web/pull/2087 PR again so our CI/test builds run.
This PR will fixs the bns lookupProfile functionality. @pradel will write up steps we need to follow to QA this. cc/ @andresgalante can you plan when we'll include this in release?

There is a bug in 3.1.0 https://github.com/blockstack/stacks.js/pull/1152

Thanks @friedger, yes this one is def not to merge yet. Converted to draft.

@kyranjamie would it be possible to get a new build with 3.1.1 please 🙏 ?

@pradel done, building now

Amazing thanks!

Hey there, any update to merge this one? :)

The changes introduced in this pr are mostly related to how the profile is signed, so I think you need to login to an app using the publish_data scope. You could probably use the TODO app on this branch https://github.com/hirosystems/todos/pull/104.
You would have to log in using an account owning a .btc name and you can try to call the lookupProfile function that would fail with the current Hiro wallet version and work with the one built on this branch.

@kyranjamie I'd like to include this on our next release if possible.
I'll move it to "QA" so @Eshwari007 or @timstackblock can pick it up while it's being reviewed.

@kyranjamie any input on how to test the ticket is much appreciated.Thx in ad

@Eshwari007 this is how to test it https://github.com/hirosystems/stacks-wallet-web/pull/2089#issuecomment-1024048391

@kyranjamie Want to run by you if am missing something here.

I created a todos' using a test btc name under :  https://todos-lovat.vercel.app/todos/
I tried looking up for my btc name todos https://todos-lovat.vercel.app/todos/hiromaintest.btc
Receiving the below:

Used the link from https://github.com/hirosystems/todos/issues/103

Hi @pradel, would you be able to help Esh test this PR? if async on the ticket is too slow, we can try on Discord

@andresgalante happy to help, do you have a channel for this?

I uploaded a build from the Todo app pending pr to netlify for you to test more easily https://blissful-agnesi-f97d5f.netlify.app/.
Now we just need https://github.com/hirosystems/stacks-wallet-web/pull/2194 to be merged into this branch and get a new build for the wallet in order to finish the testing part :)

Testing flow
Demo link: https://sigle-9i6eqj7dj-sigle.vercel.app/login
These are the tests cases with the new Hiro wallet version:

legacy account migration: use an old account 12 word key with a *.id.blockstack attached to it and login. You should be able to see your existing drafts, published posts, visiting my blog as a public visitor should work too.
legacy account migration: use an old account 12 word key with a *.id.stx attached to it and login. You should be able to see your existing drafts, published posts, visiting my blog as a public visitor should work too.
account with *.btc domain: login with an account owning a .btc domain. You should see the .btc username in the left side menu (back part). Create a draft, publish it and then visit your public blog should work.
registering new account: create a new account without username linked to it and register a new username. You should see the .btc username in the left side menu (back part). Create a draft, publish it and then visit your public blog should work.

To view your public blog, on the top right corner of the dashboard click on this button 👇

https://sigle-9i6eqj7dj-sigle.vercel.app/login

@leopradel Great news, I was able to login in with .btc address, create a blog ,save and publish it. I tried selecting 'view my blog but received 'token issuer error 'https://sigle-9i6eqj7dj-sigle.vercel.app/hiromaintest.btc.  However, in the sigle app itself, I was able to view my test blog under the 'Published' section. Do let me know if you want me to test any other use case(s) as well

Thanks for trying it out!
For case 3: the fact that you are seeing the "token issuer error" means that the profile is not signed properly, also meaning that the test failed.
Calling the API https://stacks-node-api.mainnet.stacks.co/v1/names/hiromaintest.btc show that your username is linked to the address SP17YZQB1228EK9MPHQXA8GC4G3HVWZ66X7VRPMAX. However your profile public key is 0217ecac7614a7a724f0addfc4241f756129171cc460eef430e895f04a08ff5658, and getting the address is actually not matching the one owned by the name.
const { getAddressFromPublicKey } = require('@stacks/transactions');
console.log(getAddressFromPublicKey('0217ecac7614a7a724f0addfc4241f756129171cc460eef430e895f04a08ff5658'));
// => SP2FB4MP6QZ1JV8JJZTCBYP7P9T6GXB0842YHYVX3

This is the result you would get by logging in with the current Hiro wallet version (without the fix from this pull request). Can I ask you to triple check that the extension you tried does have the changes made in this pull request? https://github.com/hirosystems/stacks-wallet-web/pull/2196
For case 4: it's fine as it's not related to this pull request and the Hiro wallet in general but rather the subdomain registrar (I created an issue in the repo already).

@pradel Spoke too soon.
I logged out and retested the entire scenario (this time with both .stx and .btc)with #2196
Findings:
Use case 3: the irony is that this partially worked bfr the token error was produced but now with the fix branch am not able to see any actions on the app upon selecting the account with btc on it
https://user-images.githubusercontent.com/38872890/152385562-a3be0fa9-9aab-49fe-83d3-ac4ce185f43e.mov
Use case 4:I was able to sign in with an account that doesn't have a bns attached to it and it created name.stx for me in the app

When QA approved, I'll make these changes #2172 (rather than merging this PR), as it'll be a real pain to rebase on.

@Eshwari007  I did the testing on multiple devices and it worked all the time. Would you mind trying one more time with a clean cache? 🙏

@Eshwari007 I did the testing on multiple devices and it worked all the time. Would you mind trying one more time with a clean cache? 🙏

@pradel Yay-good news. Test passed -used #2172
All the use cases passed.

Thanks a lot @Eshwari007 for testing this PR. Lets get it into the next release after 3.1


Proper instance and class methods

Is your feature request related to a problem? Please describe.
Currently classes in OpShin do not support methods. It would be nice to support methods. Especially magic methods (__add__) would improve the situation of i.e. Fractions etc.
Describe the solution you'd like
Users should be able to declare methods on PlutusData classes which will be dispatched to when called from OpShin code.
Describe alternatives you've considered
None
Additional context
Note that this might be more complex than it seems. In particular, the functions should be (C-Style) compiled and mapped somewhere global-statically, then called instead of the attribute accessed (one option). Note also that OpShin does currently not permit inheritance (and does not plan to) which should improve the situation.

Bug bounty: 2000 ADA

#389 Is starting on this. Please let me know if this is what you are looking for. Also if there are any particular unit tests you want me to make sure it passes on.


1.0.0 release CHANGELOG update

Includes all the changes from v1.0.0rc1, and then new work up to 80cb51a6 (https://github.com/stellargraph/stellargraph/compare/v1.0.0rc1...80cb51a6).
New work that has landed since then: https://github.com/stellargraph/stellargraph/compare/80cb51a6...develop
This would benefit from #1483 as a performance summary.

Don't wanna push on top of anyone, so here's the summary of performance improvements of develop vs 0.11:

HinSAGENodeGenerator is 2.9x faster (tested on MovieLens)
Attri2VecNodeGenerator is 4.3x faster (tested on CiteSeer)
Biased weighted random walk is 2.6x faster (benchmark)
Metapath random walk is 6.6x faster (benchmark)
Directed adjacency matrix construction is 1.6x faster (benchmark)
Base stellargraph is upto 4.2 x times smaller (tested on FB15K)
Base stellargraph construction is 2x times faster (tested on FB15K)
Undirected stellargraph is upto 2.2x times smaller (tested on FB15K)
Directed stellargraph is upto 1.8x times smaller (tested on FB15K)

FYI I'm going to be pushing updates here

I've done up to what's landed in develop so far so feel free to review the new changes. I'll update again with the links per (https://github.com/stellargraph/stellargraph/pull/1481#discussion_r419832834) once #1471 lands?

Wow, this is impressive! LGTM 🚀


Bug fix @DruidSecondaryModule plus unit test

This PR has a fix and unit test to catch the bug.
The bug will raise when a module use the JsonConfigurator while the Guice built in .asEagerSingleton() start for ObjectMapper did not initialize it yet.
Caused by: java.lang.IllegalStateException: No 'injectableValues' configured, can not inject value with id [java.lang.String]
	at com.fasterxml.jackson.databind.DeserializationContext.findInjectableValue(DeserializationContext.java:291)
	at com.fasterxml.jackson.databind.deser.impl.ValueInjector.findValue(ValueInjector.java:46)
	at com.fasterxml.jackson.databind.deser.impl.ValueInjector.inject(ValueInjector.java:52)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.injectValues(BeanDeserializerBase.java:1237)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserializeFromObject(BeanDeserializer.java:290)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:124)
	at com.fasterxml.jackson.databind.ObjectMapper._convert(ObjectMapper.java:2769)
	at com.fasterxml.jackson.databind.ObjectMapper.convertValue(ObjectMapper.java:2700)
	at io.druid.guice.JsonConfigurator.configurate(JsonConfigurator.java:81)
	at io.druid.guice.JsonConfigProvider.get(JsonConfigProvider.java:181)
	at io.druid.guice.JsonConfigProvider.get(JsonConfigProvider.java:60)
	at com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:86)
	at com.google.inject.internal.InternalFactoryToInitializableAdapter.provision(InternalFactoryToInitializableAdapter.java:55)
	at com.google.inject.internal.ProviderInternalFactory.circularGet(ProviderInternalFactory.java:66)
	at com.google.inject.internal.InternalFactoryToInitializableAdapter.get(InternalFactoryToInitializableAdapter.java:47)
	at

Hi @b-slim , thanks for the PR.
Which of the test fails in master?

The injector creation workflow usually goes through cusotom Druid Guice handlings rather than making a Guice injector using Guice directly.
io.druid.initialization.Initialization.makeInjectorWithModules for example.
These are setup during the CLI launching workflow.
Did this come about during actually running a service? (the CLI command workflow should have injected stuff properly) or during a unit test?
Guice injection in a unit test is a PITA right now.

@drcrallen It is come when running any service.  The reason i used the class name emitter because it did happen when i did used my own custom emitter module.

@drcrallen If you look at how Guice is setup, the unit test is replicating exactly how Guice works inside of Druid.  This is a real problem in the current code as evidenced by the unit test that now passes.

@cheddar Unless you're actually calling the methods in io.druid.cli.Main you cannot say you are replicating exactly what happens with initial Guice injection. You can say that you are close, or that you capture the intended workflow, but you are not using the same workflow.
I don't fully understand why "make objectMapper eager to ensure jackson gets setup with guice injection for JsonConfigurator" is no longer a relevant concern. But the PR is in so there's not much use in dwelling on it.

@drcrallen I trust @cheddar on this one, since he initially wrote the Guice injection bootstrapping and it hasn't changed much since. I assume this has been tested standalone and we'll have to make sure it doesn't break any of the examples or extensions being able to register jackson types.
@b-slim @cheddar since you are working on making things more pluggable, it would be really cool if you could write some documentation on pluggable things, e.g. showing how you can build your own emitter module. Maybe we can add a section for that to the documentation revamp.

@xvrl That sounds a good idea, will try to write some doc about it.

@b-slim Just an FYI, if you've been following the Druid proposals, I am currently making gigantic changes to docs right now. It may be a good idea to wait until my changes are in before making any doc changes on your side.


Distributed

Initial implementation and related tests for https://github.com/carlomazzaferro/scikit-hts/issues/7

This largely follows the work done by @blue-yonder at https://github.com/blue-yonder/tsfresh/


fix "dest" configuration

@dend could you please help to merge this request?

@EdisonDa Please don't commit to master in the future. Always follow the standard pull request procedure.

@sptramer thank you Stephen. Yes, for the big change I did it in my personal branch, and create PR to master. For this one line fix I did it in master directly. I will take care next time, and always create PR to master, and add you as a reviewer.


Add the prettier linter workflow

Description
Add the prettier linter to ensure proper and uniform linting of the codebase. As a project with multiple users contributing to it, it is essential to maintain a proper linting style to ensure better code readability by users. An excellent way to do this is by automatic linting checks using the prettier linter in GitHub actions.
I would like to work on this as a part of GSSoC 23.
Screenshots
No response
Additional information
No response

Description
Add the prettier linter to ensure proper and uniform linting of the codebase. As a project with multiple users contributing to it, it is essential to maintain a proper linting style to ensure better code readability by users. An excellent way to do this is by automatic linting checks using the prettier linter in GitHub actions.
I would like to work on this as a part of GSSoC 23.
Screenshots
No response
Additional information
No response

Hi, there's already prettier action for this project, but it's not fixing contributors code. It's working if owner commits or something's off in the main repo. Can you try to fix that?

@narayan954 The prettier that you are talking about is implemented using deepsource which cannot perform autofix if the base branch of the PR and the current repo state dont match. So, a better way would be to implement prettier using GitHub actions as it would run on every push, commit and pull request.

@narayan954 The prettier that you are talking about is implemented using deepsource which cannot perform autofix if the base branch of the PR and the current repo state dont match. So, a better way would be to implement prettier using GitHub actions as it would run on every push, commit and pull request.

You're correct! you can work on this!

@narayan954 The prettier that you are talking about is implemented using deepsource which cannot perform autofix if the base branch of the PR and the current repo state dont match. So, a better way would be to implement prettier using GitHub actions as it would run on every push, commit and pull request.

You're correct! you can work on this!

ensure/test for working as well.


fix(tekton): fix #947: Reset pagination when changing any filter

Update the tekton plugin to fix #947 aka :

Reset page to page 0 when the cluster, state filter or text-field changed
Calculate and set filteredPipelineRuns in a useMemo when some of the user states change, instead of having two states that are set when the search field changes.
Removed the native prop from the dropdowns so that the dropdowns are rendered with Material UI.

Before:
https://github.com/janus-idp/backstage-plugins/assets/139310/d1d717dd-7b52-49ee-8e2d-3439c8c97ba1
After:
https://github.com/janus-idp/backstage-plugins/assets/139310/31a6900e-5a0c-41a1-98ea-320d3e971308

/uncc tumido
/cc @gashcrumb @invincibleJai

/cc @karthikjeeyar

/lgtm


HA Cluster stuck and unable to start after enabling secrets encryption

Environmental Info:
K3s Version:

k3s version v1.22.5+k3s1 (405bf79d)
go version go1.16.10
Node(s) CPU architecture, OS, and Version:

Linux 5.10.0-10-amd64 #1 SMP Debian 5.10.84-1 (2021-12-08) x86_64 GNU/Linux
Cluster Configuration:

3 servers (referred to here as S1, S2, and S3) and 3 agents
Describe the bug:

Server was already running with HA configuration and no issues. I followed https://rancher.com/docs/k3s/latest/en/security/secrets_encryption/ to attempt to enable secrets configuration on the cluster. Upon restarting them, S2 and S3 failed to start k3s and showed the following log:
time="2021-12-23T23:20:37-08:00" level=fatal msg="/var/lib/rancher/k3s/server/cred/encryption-state.json newer than datastore and could cause cluster outage. Remove the file from disk and restart to be recreated from datastore."

So I followed the recommendation to remove /var/lib/rancher/k3s/server/cred/encryption-state.json, and now S2 and S3 fail to start with:
time="2021-12-24T00:07:44-08:00" level=fatal msg="stat /var/lib/rancher/k3s/server/cred/encryption-state.json: no such file or directory"

Meanwhile, on S1, systemctl status k3s.service shows activating as it waits for the other master nodes to restart.
Steps To Reproduce:

Initial configuration
Before making any changes, ExecStart of /etc/systemd/system/k3s.service on S1 (local IP: <IP_ADDRESS>) looked like:
ExecStart=/usr/local/bin/k3s \
    server \
        '--server' \
        'https://<IP_ADDRESS>:6443' \
        '--disable' \
        'servicelb,traefik'

On S2 (local IP: <IP_ADDRESS>), it looked like:
ExecStart=/usr/local/bin/k3s \
    server \
        '--cluster-init' \
        '--disable' \
        'servicelb,traefik'

On S3 (local IP: <IP_ADDRESS>), it looked like:
ExecStart=/usr/local/bin/k3s \
    server \
        '--server' \
        'https://<IP_ADDRESS>:6443' \
        '--disable' \
        'servicelb,traefik'

Steps:

On S1: Update /etc/systemd/system/k3s.service to add '--secrets-encryption' to args
On S1: systemctl restart k3s.service
On S1:

Encryption Status: Enabled
Current Rotation Stage: start
Server Encryption Hashes: All hashes match

Active  Key Type  Name
------  --------  ----
 *      AES-CBC   aescbckey

On S2 and S3:  Update /etc/systemd/system/k3s.service to add '--secrets-encryption' to args
On S2 and S3: systemctl restart k3s.service

Expected behavior:

S2 and S3 come back up cleanly, secret encryption is enabled on the cluster
Actual behavior:

S2 and S3 fail to start with
time="2021-12-23T23:20:37-08:00" level=fatal msg="/var/lib/rancher/k3s/server/cred/encryption-state.json newer than datastore and could cause cluster outage. Remove the file from disk and restart to be recreated from datastore."

After deleting /var/lib/rancher/k3s/server/cred/encryption-state.json, S2 and S3 fail to start with
time="2021-12-24T00:07:44-08:00" level=fatal msg="stat /var/lib/rancher/k3s/server/cred/encryption-state.json: no such file or directory"

S1 is stuck in activating state.
Additional context / logs:

Backporting

[ ] Needs backporting to older releases

I was able to get the nodes to start back up again successfully by manually copying  /var/lib/rancher/k3s/server/cred/encryption-state.json from S1 to S2 and S3

I'm not sure that we've tested adding that flag to an existing cluster after the fact.
cc @dereknola

We have not tested that, and it isn't supported AFAIK. Something for next month's release :)

I was able to get my cluster back up and running, thankfully. Currently I see the following:
k3s secrets-encrypt status
Encryption Status: Enabled
Current Rotation Stage: reencrypt_active
Server Encryption Hashes: hash does not match between S1 and S2

Active  Key Type  Name
------  --------  ----
 *      AES-CBC   aescbckey

Given that you've said this is not supported, can you please advise on a way to safely turn secrets encryption back off without breaking the cluster again?

There is already a line about not using it on existing clusters in a bolded NOTE box:

To disable encryption you can follow the instructions here:
https://rancher.com/docs/k3s/latest/en/security/secrets_encryption/#single-server-secrets-encryption-disable-enable

I have posted a Docs PR to add the same note in the HA section, not just the Single Node section.
https://github.com/rancher/docs/pull/3768


Using kafka.internal.topic.prefixes config in regular java props file fails after change to use lightbend

Lightbend was recently introduced in KTB. I have found two problems:

Config kafka.internal.topic.prefixes is now working with Java properties file format
It seems that the default value of "_" for kafka.internal.topic.prefixes have been removed. This might have been intended?? But there is no mention in the changelog or docs of the commit.

Before this change the config for kafka.internal.topic.prefixes could be:
kafka.internal.topic.prefixes=_, topicA, topicB
But after the change to lightbend this config will fail even though lightbend should support java properties files as well. Getting this exception when running KTB:
Exception in thread "main" com.typesafe.config.ConfigException$WrongType: ./ktb.properties: kafka.internal.topic.prefixes has type STRING rather than LIST
	at com.typesafe.config.impl.SimpleConfig.findKeyOrNull(SimpleConfig.java:163)
	at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:174)
	at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:180)
	at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:180)
	at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:180)
	at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:188)
	at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:193)
	at com.typesafe.config.impl.SimpleConfig.getList(SimpleConfig.java:262)
	at com.typesafe.config.impl.SimpleConfig.getHomogeneousUnwrappedList(SimpleConfig.java:348)
	at com.typesafe.config.impl.SimpleConfig.getStringList(SimpleConfig.java:406)
	at com.purbon.kafka.topology.TopologyBuilderConfig.getKafkaInternalTopicPrefixes(TopologyBuilderConfig.java:216)

Changing the file name to ktb.conf and using HOCON config format works though:
kafka.internal.topic.prefixes=["_", "topicA", "topicB"]
So basically it seems that java properties file configuration is broken. Probably caused by the lightbend api usage (see stack trae above) SimpleConfig.getStringList().
Or is the idea that java props file format is no longer supported for the config?

Hi @akselh thanks for reporting this. I am adding this as a blocker for 1.0. Happy like a little kid if you can help with a fix, otherwise I will work on this as soon as I can.

I like the java props to still be good supported and I think the lightbend should do it.

Hi @akselh thanks for reporting this, I took sometime today to test this report here and I added #115 to add a few more test on the topic. To answer your question here.

It seems that the default value of "_" for kafka.internal.topic.prefixes have been removed. This might have been intended?? But there is no mention in the changelog or docs of the commit.

Not it has not been removed, since the intro of lighbend as a config library, the defaults are managed with a sample reference.conf file that is located in the resources https://github.com/kafka-ops/kafka-topology-builder/blob/master/src/main/resources/reference.conf

So basically it seems that java properties file configuration is broken. Probably caused by the lightbend api usage (see stack trae above) SimpleConfig.getStringList().

As described in #115 passing the properties like
kafka.internal.topic.prefixes.0=_
kafka.internal.topic.prefixes.1=topicA
kafka.internal.topic.prefixes.2=topicB

is understood by the library and as well for the properties file properly.
What do you think?

Yes @purbon I think I will have time to contribute code to the project now. But have a lot of other tasks ongoing as well besides working with testing/introducing KTB in our organization. So wasn't able to pick this up yesterday. Now I it is already In Progress, so I guess you have already started on it? Thanks for picking this up so swiftly!

take a look please to the previous message and let me know how it looks for you. That would be a good contribution.

Hehe, almost a little race condition here :-)
I think that solution is fine, I didn't know the usage of the reference.conf file. If someone wants to have a properties-like file but have this property as a one liner they can just add
kafka.internal.topic.prefixes=["_", "topicA", "topicB"]
and rename the file to .conf

I have some other comments, can put those on the PR.

yes, with the addition of lightbend config lib, HACON, JSON and properties file syntax is now supported.


Issue with Terraform builtin providers

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
Terraform
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
terraform {
  required_version = ">= 1.9.0"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 5.80.0"
    }
    github = {
      source  = "integrations/github"
      version = ">= 6.3.1"
    }
    google = {
      source  = "hashicorp/google"
      version = ">= 6.12.0"
    }
    google-beta = {
      source  = "hashicorp/google-beta"
      version = ">= 6.12.0"
    }
    local = {
      source  = "hashicorp/local"
      version = ">= 2.5.2"
    }
    terraform = {
      source = "terraform.io/builtin/terraform"
    }
  }
}

dependabot.yml content
---
version: 2
updates:
  # Maintain dependencies for GitHub Actions
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "weekly"
    target-branch: dev
  # Maintain dependencies for Terraform providers
  - package-ecosystem: "terraform"
    directory: "/terraform"
    schedule:
      interval: "weekly"
    target-branch: dev

Updated dependency
No response
What you expected to see, versus what you actually saw
I would expect Dependabot to be able to run through without any issues. What happens though is that it fails when trying the check for builtin/terraform provider. With this one I do not have a specified version, since it depends on installed version of Terraform anyway (I am using this provider for provider::terraform::decode_tfvars functionality).
I also have some Terraform modules in private repositories and there is no problem there, only issue is with this builtin/terraform. Toward the end of logs I get Host does not support required Terraform-native service, so I wonder if maybe this is simply not supported?
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
updater | 2024/12/13 19:58:04 INFO <job_932535510> Checking if builtin/terraform  needs updating
  proxy | 2024/12/13 19:58:04 [069] GET [https://terraform.io:443/.well-known/terraform.json](https://terraform.io/.well-known/terraform.json)
  proxy | 2024/12/13 19:58:04 [069] 308 [https://terraform.io:443/.well-known/terraform.json](https://terraform.io/.well-known/terraform.json)
  proxy | 2024/12/13 19:58:04 [072] GET [https://www.terraform.io:443/.well-known/terraform.json](https://www.terraform.io/.well-known/terraform.json)
  proxy | 2024/12/13 19:58:04 [072] 404 [https://www.terraform.io:443/.well-known/terraform.json](https://www.terraform.io/.well-known/terraform.json)
  proxy | 2024/12/13 19:58:04 [074] POST /update_jobs/932535510/record_update_job_error
  proxy | 2024/12/13 19:58:04 [074] 204 /update_jobs/932535510/record_update_job_error
updater | 2024/12/13 19:58:04 INFO <job_932535510> Handled error whilst updating builtin/terraform: private_source_authentication_failure {:source=>"Host does not support required Terraform-native service"}
  proxy | 2024/12/13 19:58:04 [076] POST /update_jobs/932535510/record_ecosystem_meta
  proxy | 2024/12/13 19:58:04 [076] 204 /update_jobs/932535510/record_ecosystem_meta
  proxy | 2024/12/13 19:58:04 [078] PATCH /update_jobs/932535510/mark_as_processed
  proxy | 2024/12/13 19:58:05 [078] 204 /update_jobs/932535510/mark_as_processed
updater | 2024/12/13 19:58:05 INFO <job_932535510> Finished job processing
updater | 2024/12/13 19:58:05 INFO Results:
Dependabot encountered '1' error(s) during execution, please check the logs for more details.
+-----------------------------------------------------------+
|               Dependencies failed to update               |
+-------------------+---------------------------------------+
| builtin/terraform | private_source_authentication_failure |
+-------------------+---------------------------------------+

Smallest manifest that reproduces the issue
No response

In case it's useful context for Dependabot maintainers who might not be familiar with all of the fine details of Terraform:
The provider source address namespace terraform.io/builtin/* is reserved for providers that are built in to the Terraform CLI executable and so cannot be upgraded independently of Terraform CLI. Terraform's provider installer has a special case for that namespace where the terraform init command will just report that the provider is built in to Terraform and not actually try to install it from anywhere. There is no discoverable provider registry running at terraform.io because Terraform does not try to resolve these providers through a registry.
Therefore I think it should be reasonable for Dependabot to entirely ignore any providers belonging to that namespace.


Sending image to user

Hey aravind can we send image to user ? if yes then how?

Hey Vishnu, I'm currently working on sending an analysis report of the Xray sent by the user, will let you know once its done.
Please share the repository if you like it 😄.


Remove revalidate

Remove revalidate as there is currently no cache support for the Edge runtime.

Will be kept here since edge is removed https://github.com/vercel/commerce/pull/1236


I want to list recent posts alongside archieve sidebar

Would appreciate if you could guide me on how-to add that. As of now , on homepage I see only tags - and archives page is empty - recently added docs are not showing over there.
I did add code to show list of posts to archive - but then when I open a post - the content is open in main page as well as in the sidebar - whereas sidebar should only list the pages.

I added a widget to list the last 5 posts : 0a88ef0a1f8453288f2497074308de1c9b56d524


LO no longer connected to qw5q_gold platform

I'm using qw5q_gold_qblox in #65 and since 5 minutes ago I am getting the following error:
RuntimeError: Cannot establish connection to <qibolab.instruments.rohde_schwarz.
SGS100A object at 0x7f08bbed3610> instruments. Error captured: '[Errno 113] No r
oute to host'

Which lets me believe that probably the LO disconnected.
@aorgazf @PiergiorgioButtarini @DavidSarlle could you please check if the LO is properly connected?

@andrea-pasquale try now. Alvaro disconnected for a whhile because there was a problem with a ddifferent LO in order to access to it. Sorry

Indeed, now it is working. Thanks.


Installing scala inside jdk image

Creating draft pull request while waiting on the reply about scala version to be installed from Oleksandr

We got go ahead from Oleksandr on using 2.12.12 version for scala. In the nearest future it will be upgraded to 2.13.x versionm thus we will bump the version up for base images as well.


New crash in version 78

I noticed a spike in our crashes since version 78 was pushed to production. Most of those crashes were associated with this particular log, 11 reports to be precise. Unfortunately I can't seem to figure out what is going wrong since our app isn't even mentioned in the stack trace.
All of the crashes were in Android 7.0 and caused by a Galaxy J7(2016) - so probably by a single person.
java.lang.RuntimeException:
  at android.app.LoadedApk.makeApplication (LoadedApk.java:846)
  at android.app.ActivityThread.handleBindApplication (ActivityThread.java:5944)
  at android.app.ActivityThread.-wrap3 (ActivityThread.java)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1710)
  at android.os.Handler.dispatchMessage (Handler.java:102)
  at android.os.Looper.loop (Looper.java:154)
  at android.app.ActivityThread.main (ActivityThread.java:6776)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1518)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1408)
Caused by: java.lang.ClassNotFoundException:
  at dalvik.system.BaseDexClassLoader.findClass (BaseDexClassLoader.java:56)
  at java.lang.ClassLoader.loadClass (ClassLoader.java:380)
  at java.lang.ClassLoader.loadClass (ClassLoader.java:312)
  at android.app.Instrumentation.newApplication (Instrumentation.java:1000)
  at android.app.LoadedApk.makeApplication (LoadedApk.java:835)

Never encountered this in production but one of our testers at work ran into this issue when installing a debug build after sharing it via ShareIt on a Samsung device. Installing the same build via adb would work fine however, so we left it at that. That said this SO question provides what I think is a reasonable answer.

Thanks @Bluesir9 . Seems like there isn't that much that can be done in this case.

I had encountered a similar problem while working on a different project. This happened while working with Build Tools 26 and SDK 7.1.1 itself. The problem was solved by including
defaultConfig{ ...... multiDexEnabled true } dependencies {   compile 'com.android.support:multidex:1.0.0' }
this in my gradle.build
I can try this out to see if it solves the problem.

No more similar logs have come through, assuming this no longer happens. Sounds like it might have been something in ShareIt. Can reopen if see similar logs.


mbias

Hi,
I would like to ask you what can cause mbias in data. Could you indicate of possible reasons?
Thank you.
Regards,
Jarek

I wish I knew. My only guess would be something to do with accessibility of or damage near fragment ends. Perhaps there's a paper on that somewhere.


Adds Dockerfile and basic compose

Type:

[x] Bugfix
[x] Enhancement
[ ] New feature

Description of the changes:

Adds a multi stage docker file based on python:3.9-slim and a working compose file to go along with it.
Changes the text of the error confighandler raises to better describe what's actually occurring. (if the config file isn't present, it errors before that point when it attempts to read it)
removes duplicate from requirements.txt

Seems good to me, I’ll merge after I run the bot in docker today.

Hold off on merging till he commits the docs.


K4ABT_SENSOR_ORIENTATION_FLIP180 is not taken into account in k4abt_tracker_create

Hi,
We are facing a bug in the body tracker when we are flipping the camera :
We have set the sensor_orientation property with K4ABT_SENSOR_ORIENTATION_FLIP180 value but it does not enable body tracking when the camera is 180° flipped.
We are running 1.1.0 version.
I did not find but is there already an opened issue for that ?
Thanks.

Also https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/1606


Update major tag

If you use dependabot in your actions. Checkov is the most annoying of all bumping patch versions almost everyday. Lets have a major tag update as well.
Bump major to facilitate
      - name: checkov
        uses: bridgecrewio/checkov-action@v12

as well of
      - name: checkov
        uses<EMAIL_ADDRESS>

@nimrodkor can I get some feedback?
We can alternativelly use the native tag action but it does not automacilly find out the latest major
    - name: Bump version and push tag
      uses<EMAIL_ADDRESS>      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        CUSTOM_TAG: v12

^ don't like that
https://github.com/anothrNick/github-tag-action/pull/157

@schosterbarak anyone around?

Thanks @gruebel for the feedback


move away from nodejs v4.3 and use nodejs v6.10 as default

:white_check_mark: coverage increased from 0% to 57.01%


Polymer in 10 Minutes - Reusing other elements

I'm walking through the Tutorial and I am at the beginning of this walk through. When I get to the Reusing other elements and it asks to install the core-ajax:
bower install Polymer/core-ajax
should we not be using:
bower install Polymer/core-ajax --save
so it will update our bower.json file?

This issue was moved to Polymer/docs#990


Allow including or excluding entire opsets from generation, remove Opset 19, 20 stubs

Add argument parsing for the opgen command. Adds the following options:
usage: opgen [-h] [-x OPSET] [-i OPSET] [--min-opset-version MIN_OPSET_VERSION]

options:
  -h, --help            show this help message and exit
  -x OPSET, --exclude OPSET
                        exclude an opset from generation; example: -x 19 -x
                        ai.onnx.ml/3
  -i OPSET, --include-only OPSET
                        include only these opsets; example: -i 19
  --min-opset-version MIN_OPSET_VERSION
                        the minimum supported ONNX opset version

If any --include-only opsets are specified, only those opsets will be included
--exclude opsets are then excluded

Add OpsetsBuilder.Result to hold state and summary information produced by the generation, and move the write method to this class.

Produce a nicer summary of the generation.

Drop Opsets 19 and 20 for now, since supporting these will require support for the new types across various other components (ONNX reference evaluator/numpy, ONNX Runtime):
$ python -m opgen -x 19 -x 20

🎉 Generated Ops: 467
   Minimum Opset Version: 14

🟢 Included Opsets:
   1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18,
   ai.onnx.ml/1, ai.onnx.ml/2, ai.onnx.ml/3,
   ai.onnx.preview.training/1

🔴 Excluded Opsets:
   19, 20

🟠 Unsupported Ops:
   reason: deprecated:
     - Upsample(10)
       https://onnx.ai/onnx/operators/onnx__Upsample.html#upsample-10
     - Scatter(11)
       https://onnx.ai/onnx/operators/onnx__Scatter.html#scatter-11

This should unblock #728 (to be rebased when this merges).

It seems the failures are happening against PyTorch nightly builds, indicating maybe torch.dtype API has maybe changed?
onnxscript/tests/function_libs/torch_lib/ops_test.py::TestOutputConsistencyEagerCPU::test_output_match_opinfo__log_softmax_cpu_float32 - TypeError: argument of type 'torch.dtype' is not iterable

In any case, this should not be related to this PR.

It seems the failures are happening against PyTorch nightly builds, indicating maybe torch.dtype API has maybe changed?
onnxscript/tests/function_libs/torch_lib/ops_test.py::TestOutputConsistencyEagerCPU::test_output_match_opinfo__log_softmax_cpu_float32 - TypeError: argument of type 'torch.dtype' is not iterable

In any case, this should not be related to this PR.

I guess that a single type is being specified where a list/tuple of types is expected. Eg., this line looks like it is missing a comma to turn that into a tuple.
Not sure how this error creeped in originally.

@abock please feel free to merge it in, I wasn't sure if you were planning to make any changes.

Looks like the failures are from this merged PR: https://github.com/microsoft/onnxscript/pull/727


fixed typo in code sample

Description
Just a small typo fix for the documentation (missing comma).
Visual changes
No
Functional changes

[ ] Code style has been fixed by running the composer cs command. n/a
[ ] Changes have been tested to not break existing functionality. n/a
[x] Documentation is up-to-date.

Thanks


GH-1444: Listener Observability Initial Commit

expand scope to include error handler: https://github.com/spring-projects/spring-amqp/pull/1287
tracing can't be used with a batch listener (multiple messages in listener call)

It feels a bit involved with all those extra layers of enums and conventions, but I'm still learning this stuff and cannot be treated as a genuine source of opinion. smile_cat

Enums here are like @Configuration for Spring. They separate what you want to have as observations, how they should be named and tagged from their actual usage. An additional advantage is that due to using enums you can automatically generate documentation of  your observations https://micrometer.io/docs/tracing#_documentation_building
A convention is the way to actually apply the naming and tagging. The way we designed things allow you to easily locally or globally alter that behaviour.

In your case, that makes sense because this.observationConvention can be null.
I don't allow it to be null; I think that makes for a cleaner API.

I left a comment here https://github.com/spring-projects/spring-amqp/pull/1500/files#r965219710 about testing against Zipkin to see how the whole trace looks like there

Also we should double check that if we have 2 separate processes then the trace gets continued. It means that on the SenderContext you would need to set the remoteServiceName to be the name of the broker (e.g. rabbitmq). Then on the recipient side on the ReceiverContext you would need to se the remoteServiceName to be rabbitmq too. That way you will see in Zipkin in the dependency graph that application A is talking to a rabbitmq service that then talks to service B.

@marcingrzejszczak I don't see a remoteServiceName on the ReceiverContext, only on the SenderContext.
Also, should the service name just be rabbitmq or should it include, for example, the ip address of the actual broker?

Forget the second comment in my last post - it wouldn't work because, with a cluster, they might be connected to different nodes.

@marcingrzejszczak I don't see a remoteServiceName on the ReceiverContext, only on the SenderContext.

That must be our mistake - I'll fix it


how to generate balanced batches for multilingual translation?

I want to use the basic transformer architecture to do multilingual translation, that is, instead of having separate encoders and decoders for each language pair, I want one encoder and decoder for all language pairs, thus the batches should be balanced for all language pairs according to the corpus size, in order to prevent overfitting one language pair. But I find it hard to implement, since the base transformer only reads in one dataset and generates batches according to sequence length. If I have a dataset that contains all languages pairs, the batch generator still cannot guarantee to generate balanced batches. Is there a way to do this? Thanks

One easy way is to keep current way to load the dataset, and we re-weigh the loss of batches from each language pair as the ratio of original data. At train_step of MultilingualTranslationTask, we multiply the loss by the weight of the language pair.
The weight can be passed in some parameter, or we can compute it on the fly in load_dataset.

Closing due to inactivity.


Can not install this plugin in Hyper 3.0.0-canary.8 (canary)

There is no additional information in devtool.
Remove hyper-statusline from plugin list, this error will gone.

Can you expand the notification by dragging down on the bottom of it to reveal the rest of the message? It could also be in the devtools.


Add new-parens rule

resolve #1177

Thanks @YuichiNukiyama! Just a few small changes to make if you can

@JKillian I did it.

Looks good! @adidahiya are you happy with mirroring the eslint terminology and calling this rule new-parens? Or should we go with something else?

new-parens sounds good to me


context manager for loopcontrol

classes inheriting from AbstractLoopThread run the function running() repeatedly, waiting a set interval between runs. FOr measuring devices this can mean to request a high number of different values from an instrument, which might take a rather long amount of time.
Therefore, the function running is only invoked if a parameter self.loop = True is set. As soon as this parameter is changed to False, the function is not invoked anymore, until it is set to True again.
Also, after setting it to False, one should wait for a small amount of time, to ensure that all recent communication is over, to have a "clear field of operations".
This setting and unsetting for all/a specific device, should best be handled in a context manager. This context manager should accept two arguments, one mandatory and one optional:

whether all or only a set of specific threads should thus be "put to sleep" (mandatory)
in case only a specific set should be affected, that set (optional)

currently this is solved in a bare function, which needs to be called for setting and unsetting.

done


fix(portal): 交互式应用配置文件proxyType移动到web配置子项

Codecov Report
Base: 64.81% // Head: 64.83% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (a568a5c) compared to base (a17c062).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   64.81%   64.83%   +0.02%
==========================================
  Files          95       94       -1
  Lines        2572     2571       -1
  Branches      326      325       -1
==========================================
  Hits         1667     1667
+ Misses        865      864       -1
  Partials       40       40

Impacted Files
Coverage Δ

...pps/mis-server/src/clusterops/slurm/utils/slurm.ts
40.00% <ø> (ø)

libs/libconfig/src/envConfig.ts
92.85% <ø> (ø)

libs/libconfig/src/fileConfig.ts
53.84% <ø> (ø)

libs/libconfig/src/parse.ts
91.66% <ø> (ø)

libs/libconfig/src/validation.ts
100.00% <ø> (ø)

apps/portal-server/src/services/app.ts
20.45% <66.66%> (-0.48%)
:arrow_down:

apps/auth/src/auth/ldap/index.ts
55.69% <100.00%> (ø)

apps/auth/src/config/auth.ts
63.63% <100.00%> (+1.73%)
:arrow_up:

apps/auth/src/config/ui.ts
100.00% <100.00%> (ø)

apps/mis-server/src/config/mis.ts
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Improvement Request] Screen share needs token, but it's not clear to how set it.

Problem:
Agora App is Certificate enabled and joins a channel with token.
Screen share not working:
out.framework.js:3 JoinChannel 8UrstKmaioPqo9RXSlX7kyMB80M2 Success: uid = 1001

clientmanager.js:506 EnableLocalVideo (clientManager):0
clientmanager.js:506 EnableLocalVideo (clientManager):1
out.framework.js:3 SDK startNewScreenCaptureForWeb
agorartcenginev2.js:333 agora engine startNewScreenCaptureForWeb
clientmanager.js:821 Screen Share Track track-scrcb68dc95
AgoraRTC_N.js:14 Uncaught (in promise) AgoraRTCException: AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: flag: 4096, message: AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: dynamic use static key
    at gJ (https://dreamspace-internal.web.app/AgoraRTC_N.js:14:15743)
    at e.gatewayInfo.wV.joinChooseServer.lts (https://dreamspace-internal.web.app/AgoraRTC_N.js:14:13141)
    at async https://dreamspace-internal.web.app/AgoraRTC_N.js:13:38265

Reason:
https://docs.agora.io/en/Agora Platform/faq/token_error
Request:
In the demo, the only token-related code is mRtcEngine.JoinChannel. It's not easy to find out how to set token for other features like screen sharing. We need a method to start screen share with token.
My walkaround:
Change IRtcEngine.GetEngine(appId) to IRtcEngine.GetEngine(token) solved my problem.

If it need token, it's mean it need to direct to an exist channel.
If you create project on agora.io with not secure option, you only get app id. (with out token and channel)
put that app id into these  demo. it's work.
ortherwise, replace Join() by JoinByKey() if you still wanna access by token

@liyaozhong  this is common Agora knowledge of using tokens.  Our WebGL demo gets straight to the point using test mode AppIDs to avoid complications.  To further understand how to use Certificate enabled AppIDs, it is recommended to read this tutorial.


Gantt View broken with advanced roadmap v2 enabled

Hi
the gantt view gives a 500 error
Processing by GanttsController#show as HTML
  Parameters: {"project_id"=>"test-mbu"}
  Current user: admin (id=1)
  Rendered queries/_filters.html.erb (236.4ms)
  Rendered gantts/show.html.erb within layouts/base (501.5ms)
Completed 500 Internal Server Error in 819ms

ActionView::Template::Error (undefined method `abort?' for #<Redmine::Helpers::Gantt:0x00000005665440>):
    102:
    103:   # Width of the entire chart
    104:   g_width = ((@gantt.date_to - @gantt.date_from + 1) * zoom).to_i
    105:   @gantt.render(:top => headers_height + 8,
    106:                 :zoom => zoom,
    107:                 :g_width => g_width,
    108:                 :subject_width => subject_width)
  lib/redmine/helpers/gantt.rb:225:in `block (2 levels) in render_project'
  lib/redmine/helpers/gantt.rb:224:in `each'
  lib/redmine/helpers/gantt.rb:224:in `block in render_project'
  lib/redmine/helpers/gantt.rb:276:in `increment_indent'
  lib/redmine/helpers/gantt.rb:217:in `render_project'
  lib/redmine/helpers/gantt.rb:205:in `block in render'
  app/models/project.rb:756:in `block in project_tree'
  app/models/project.rb:752:in `each'
  app/models/project.rb:752:in `project_tree'
  lib/redmine/helpers/gantt.rb:203:in `render'
  app/views/gantts/show.html.erb:105:in `_app_views_gantts_show_html_erb__66866357230285753_36965880'
  app/controllers/gantts_controller.rb:43:in `block (2 levels) in show'
  app/controllers/gantts_controller.rb:42:in `show'

Here a screenshot without "advanced roadmap v2":

Environment:
Redmine version                3.0.0.stable.14045
Ruby version                   2.2.0-p0 (2014-12-25) [x86_64-linux]
Rails version                  4.2.0
Environment                    production
Database adapter               Mysql2
SCM:
Subversion                     1.8.8
Git                            1.9.1
Filesystem
Redmine plugins:
advanced_roadmap_v2            2.3.2

fixed, thx!


[Event Request] page 6510 "Item Tracking Lines" - Event for procedure RegisterChange

Can we get the following event for the "Item Tracking Lines" page: OnRegisterChangeOnChangeTypeModify
    local procedure RegisterChange(var OldTrackingSpecification: Record "Tracking Specification"; var NewTrackingSpecification: Record "Tracking Specification"; ChangeType: Option Insert,Modify,FullDelete,PartDelete,ModifyAll; ModifySharedFields: Boolean) OK: Boolean
    var
        ReservEntry1: Record "Reservation Entry";
        ReservEntry2: Record "Reservation Entry";
        CreateReservEntry: Codeunit "Create Reserv. Entry";
        ReservationMgt: Codeunit "Reservation Management";
        QtyToAdd: Decimal;
        LostReservQty: Decimal;
        IdenticalArray: array[2] of Boolean;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeRegisterChange(OldTrackingSpecification, NewTrackingSpecification, CurrentSignFactor, FormRunMode, IsHandled);
        if IsHandled then
            exit;
       […]
            ChangeType::Modify:
                begin
                    ReservEntry1.TransferFields(OldTrackingSpecification);
                    ReservEntry2.TransferFields(NewTrackingSpecification);

                    ReservEntry1."Entry No." := ReservEntry2."Entry No."; // If only entry no. has changed it should not trigger

                    //New Start
                    OnRegisterChangeOnChangeTypeModify(ReservEntry1, ReservEntry2, OldTrackingSpecification, NewTrackingSpecification, IdenticalArray);
                    //New End

                    if EntriesAreIdentical(ReservEntry1, ReservEntry2, IdenticalArray) then
                        exit(QtyToHandleAndInvoiceChanged(ReservEntry1, ReservEntry2));

                    if Abs(OldTrackingSpecification."Quantity (Base)") < Abs(NewTrackingSpecification."Quantity (Base)") then begin
                        // Item Tracking is added to any blank reservation entries:
                        TempReservEntry.SetTrackingFilterBlank;
       […]
    end;

    [IntegrationEvent(true, false)]
    local procedure OnRegisterChangeOnChangeTypeModify(var ReservEntry1: Record "Reservation Entry"; var ReservEntry2: Record "Reservation Entry"; var OldTrackingSpecification: Record "Tracking Specification"; var NewTrackingSpecification: Record "Tracking Specification"; var IdenticalArray: array[2] of Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.