IMouse.MouseMove Vector2 vector parameter is useless

Summary
Equals(mouse.Position, vector) == true
Let's say you want to handle input i.e. click detection (release doesn't fire when not moused over component), mouse down, mouse up between multiple components. If you want to have a function which handles all components uniformly then you will fall back to the IMouse parameter as shown in the code below.
	private static Component? lastComponentMouseDown = null;

	private static (int, int, Component?) HitTestForComponent(IMouse mouse)
	{
		int mouseX = (int) mouse.Position.X;
		int mouseY = window.Size.Y - (int) mouse.Position.Y;
		return (mouseX, mouseY, Container.GetTopMostComponentFor(EditorWindow.Instance.Root.DoHitTest(mouseX, mouseY)));
	}

	private static void OnMouseDown(IMouse mouse, MouseButton button)
	{
		(int mouseX, int mouseY, Component? topMostComponent) = HitTestForComponent(mouse);
		topMostComponent?.Rendered.OnMouseDown(mouseX, mouseY, (int) button, topMostComponent);
		lastComponentMouseDown = topMostComponent;
	}

	private static void OnMouseUp(IMouse mouse, MouseButton button)
	{
		(int mouseX, int mouseY, Component? topMostComponent) = HitTestForComponent(mouse);
		topMostComponent?.Rendered.OnMouseUp(mouseX, mouseY, (int) button, topMostComponent);
		if (ReferenceEquals(topMostComponent, lastComponentMouseDown))
			topMostComponent?.Rendered.OnClick(mouseX, mouseY, (int) button, topMostComponent);
		lastComponentMouseDown = null;
	}

	private static void OnMouseMove(IMouse mouse, Vector2 vector)
	{
		(int mouseX, int mouseY, Component? topMostComponent) = HitTestForComponent(mouse);
		topMostComponent?.Rendered.OnHover(mouseX, mouseY, topMostComponent);
	}

	private static void OnMouseScroll(IMouse mouse, ScrollWheel wheel)
	{
		(int mouseX, int mouseY, Component? topMostComponent) = HitTestForComponent(mouse);
		topMostComponent?.Rendered.OnScroll(mouseX, mouseY, (int) wheel.Y, topMostComponent);
	}

Having a vector readily available doesn't make much sense. A new vector will be created which at worst case could be 60-240hertz (or even worse at uncapped framerates) struct instances copied as a value type via the stack per bound callback (nCallbacks * 480 to nCallbacks * 1920 bytes). However, I find this vector to be very useful if its normalized to the current window dimensions. i.e. new Vector2(mouse.Position.X / window.Width, mouse.Position.Y / window.Height); I don't think any reason can really justify having this vector parameter around, and as a 'shortcut' is just lazy. Unless it differs in OSes other than Windows.
Breaking change? Yes. Most compatible would be to just delete the param. "Well we will have all the other events require accessing the IMouse.Position except this one MouseMove event".

Breaking changes are no bueno for 2.x, sorry!

Thats fine. I just wanted this for my own documentation later! Lol


How does this operator relate to the 'official' one?

Hi all.
I'm trying to integrate Cluster API into my project and I'm a bit confused about this operator compared to the one created by the Kubernetes Cluster API SIG group. That one is based on this proposal and can be found at https://github.com/kubernetes-sigs/cluster-api-operator/. I also noted that https://github.com/openshift/cluster-api-operator is fork of said operator. This is what makes me confused 🤔
The end goal of my project is to let users automatically provision a Kubernetes cluster of their choice on hardware I own (so basically, cluster as a service). I'd like OKD to be one of the choices available. Technically I want to exclusively use Cluster API for the povisioning process, so without Machine API or any other specific tooling. In my search I stumbled upon https://github.com/openshift/enhancements/blob/master/enhancements/machine-api/cluster-api-integration.md, which describes exactly what I need for the OKD part. But that is only the proposal and I'm trying to find if someone already started on the actual implementation.
Any suggestions on repositories I should watch / follow? Or perhaps I'm just looking in totally the wrong place?

Hi,
This operator is made to deploy Clust API components on an openshift cluster, it leverages upstream operator API and performs some openshift specific stuff for configuring CAPI, like creating repositories for reading manifests, etc.
You might want to look at https://github.com/openshift/hive for cluster management because the state of CAPI integration at the moment is far from being production ready.

Thanks for the explanation. Hive looks like the thing I was looking for, a big thank you for the link 🥳


Not all log entries are formated as expected

Do you want to request a feature or report a bug?

Bug

What did you do?
I enabled debug logging with json log format on.

What did you expect to see?
All log entries to be in json format.
What did you see instead?
The first "Configuration loaded from flags." info log entry is in "common" format.
Output of traefik version: (What version of Traefik are you using?)

Runs in a docker container with cli configuration:
--log.format=json --log.level=DEBUG"

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
traefik    | time="2021-01-05T15:15:23Z" level=info msg="Configuration loaded from flags."
traefik    | {"level":"info","msg":"Traefik version 2.3.6 built on 2020-12-17T16:34:27Z","time":"2021-01-05T15:15:23Z"}

Traefik version 2.6.0, still same issue

Hello,
While coming across this issue, I wondered why the linked PR didn't succeed to address it.
The answer is not obvious but quite simple.
While there are solutions to apply the correct format for this type of log (Configuration loaded ...), because configuring the logger as soon as the static configuration is parsed seems achievable. But there is no solution to take into account the log configuration when an error occurs during the static configuration loading.
So, having the first log printed in the correct format is not solvable in every situation.
In addition, from a pure design perspective, the configuration loaders, which are producing this log, should not apply the static configuration (such as configuring the log format).
Because there is no solution to address the issue completely, and also because this issue has never had a lot of traction, I close it.
Nonetheless, anyone is welcome to ask to reopen it, if it feels wrong.


Only permanently redirect known domains

Currently any unrecognised domain gets a 301 to studentrobotics.org. This was an easy thing to get started with, but means that any DNS or nginx misconfiguration could easily have long lasting impacts.
Likely we should have a block for known domains that we do want a permanent redirect for and a separate block for the fallback which gets a temporary redirect. Having the exact list of these being configurable would be nice, even it only as a space separated string which is dropped in (like the secondary_hostnames key is).

Having had another look at this it turns out that we're already emitting 302s by default. I think we probably do want to have the ability to permanently redirect to our canonical domains, but that's a different issue than I thought it was.


Ensembl sequence

@jfreidin I bumping to 0.0.10-dev, I don't want to be doing a release on every merge. We can plan to do new releases every so often.

Closing, will merge into develop instead.


Add "Privacy and Policy" Page Link in Footer Section

Description
The footer section currently lacks a link to the "Privacy and Policy" page, which is crucial for legal compliance and user trust. Adding this page will ensure that users have easy access to the site's privacy policy, enhancing transparency.
Current Behavior:

The footer section does not include a "Privacy and Policy" link.

Expected Behavior:

A link to the "Privacy and Policy" page should be added in the footer section to provide users with important information about data protection and privacy practices.

Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@ansiace you are assigned.


[OPENLDAP-CONTAINER] Run IT tests on Docker

Uncomment and fill this section if your PR is not trivial

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md

Thanks for the contribution! I'll be checking this soon.


Timeout running queries on AWS Athena

System information:

WIndows 6.1.7601
DBeaver 6.2.2 also reproduced on 6.3
Java version 1.8.0_231
JRE 1.8.0_231-b11

Connection specification:

AWS athena database
com.simba.athena.jdbc.Driver
AthenaJDBC42_2.0.7

Describe the problem you're observing:
Connecting to Athena database on AWS using the above system described. Raised a case with AWS and the iam permissions do not seem to be the issue. Connection can be established with the database however when trying to execute a query, the query times out and returns the following error
SQL Error [100122] [HY000]: [Simba]AthenaJDBC An error has occurred. Details: Exception during column initialization: com.simba.athena.support.exceptions.GeneralException: AWS_CLIENT_ERR.
Caused by: java.sql.SQLException: [Simba]AthenaJDBC An error has occurred. Details: Exception during column initialization: com.simba.athena.support.exceptions.GeneralException: AWS_CLIENT_ERR.
at com.simba.athena.athena.dataengine.AJStreamResultSet.(Unknown Source)
at com.simba.athena.athena.dataengine.AJQueryExecutor.execute(Unknown Source)
at com.simba.athena.jdbc.common.SStatement.executeNoParams(Unknown Source)
at com.simba.athena.jdbc.common.SStatement.execute(Unknown Source)
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.execute(JDBCStatementImpl.java:338)
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:131)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeStatement(SQLQueryJob.java:475)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.lambda$0(SQLQueryJob.java:414)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:152)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:406)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.extractData(SQLQueryJob.java:765)
at org.jkiss.dbeaver.ui.editors.sql.SQLEditor$QueryResultsContainer.readData(SQLEditor.java:2848)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.lambda$0(ResultSetJobDataRead.java:99)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:152)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.run(ResultSetJobDataRead.java:97)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetViewer$17.run(ResultSetViewer.java:3429)
at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:103)
Caused by: com.simba.athena.support.exceptions.GeneralException: [Simba]AthenaJDBC An error has occurred. Details: Exception during column initialization: com.simba.athena.support.exceptions.GeneralException: AWS_CLIENT_ERR.
... 17 more
AWS provided the following information and suggestions
These queries were successful in Athena side, although it seems DBeaver never made GetQueryResults API to Athena to fetch the results of these queries. In fact, Dbeaver seemed to be continually polling Athena query status using GetQueryExecution API in order to verify the completion of query. Repetition of these requests can be observed in the CloudTrail events. And since these polling requests were repeated too fast, some of them even got throttled by Athena. This could be the reason why Dbeaver error'ed out with mentioned exception before getting the results.
Here's the expected workflow for Athena query:

Client starts Athena query using StartQueryExecution API, which returns the query ID
Client polls Athena to get the status of above query by using GetQueryExecution API [2] with query ID
If the query status in GetQueryExecution response is successful, client executes GetQueryResults [3] to get the results of query. Else, it continues polling by retrying GetQueryExecution API. If these retries are too fast, it could cause throttling and cause issues in client-side if error isn't handled properly.
Client displays the results or error of query to user

To reproduce this, I also tested my query in DBeaver (community edition and version <IP_ADDRESS>912221734) and SQL Workbench (Build 125). Even though my query took multiple minutes, both clients seem to get and display the query results successfully. So, could you also confirm your DBeaver version and upgrade it if it isn't the latest one? Running the same query with same IAM user from other clients like SQL Workbench or AWS CLI or Console could also help to narrow this down. For DBeaver specific issue, you could also try increasing timeout and retry wait period in client application to backoff when Athena throttles GetQueryExecution requests [1]. Additionally, consulting DBeaver support or forum can be another helpful option.
I cannot figure out how to increase the retry wait period. This may be a quick fix
My colleagues can execute queries without fail using similar config to mine
Any other suggestions would be much appreciated
Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs
from dbeaver-debug folder
2019-12-24 09:43:27.944 - Connect with 'Athena - ouput' (aws_athena_jdbc_simba-16f30ba2b04-2cbcba8ba22ef623)
2019-12-24 09:43:29.331 - Connected (aws_athena_jdbc_simba-16f30ba2b04-2cbcba8ba22ef623, Simba Athena JDBC Driver [<IP_ADDRESS>2])
2019-12-24 09:45:30.230 - Error executing query
org.jkiss.dbeaver.model.sql.DBSQLException: SQL Error [100122] [HY000]: [Simba]AthenaJDBC An error has occurred. Details: Exception during column initialization: com.simba.athena.support.exceptions.GeneralException: AWS_CLIENT_ERR.
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:134)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeStatement(SQLQueryJob.java:463)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.lambda$0(SQLQueryJob.java:402)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:148)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:394)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.extractData(SQLQueryJob.java:764)
at org.jkiss.dbeaver.ui.editors.sql.SQLEditor$QueryResultsContainer.readData(SQLEditor.java:2928)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.lambda$0(ResultSetJobDataRead.java:98)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:148)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.run(ResultSetJobDataRead.java:96)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetViewer$17.run(ResultSetViewer.java:3427)
at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:103)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: java.sql.SQLException: [Simba]AthenaJDBC An error has occurred. Details: Exception during column initialization: com.simba.athena.support.exceptions.GeneralException: AWS_CLIENT_ERR.
at com.simba.athena.athena.dataengine.AJStreamResultSet.(Unknown Source)
at com.simba.athena.athena.dataengine.AJQueryExecutor.execute(Unknown Source)
at com.simba.athena.jdbc.common.SStatement.executeNoParams(Unknown Source)
at com.simba.athena.jdbc.common.SStatement.execute(Unknown Source)
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.execute(JDBCStatementImpl.java:338)
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:131)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeStatement(SQLQueryJob.java:463)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.lambda$0(SQLQueryJob.java:402)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:148)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:394)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.extractData(SQLQueryJob.java:764)
at org.jkiss.dbeaver.ui.editors.sql.SQLEditor$QueryResultsContainer.readData(SQLEditor.java:2928)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.lambda$0(ResultSetJobDataRead.java:98)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:148)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.run(ResultSetJobDataRead.java:96)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetViewer$17.run(ResultSetViewer.java:3427)
at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:103)
Caused by: com.simba.athena.support.exceptions.GeneralException: [Simba]AthenaJDBC An error has occurred. Details: Exception during column initialization: com.simba.athena.support.exceptions.GeneralException: AWS_CLIENT_ERR.
... 17 more

Please try latest dbeaver version, Athena driver was upgraded there.
If it won't help you could try to downgrade, e.g. to https://s3.amazonaws.com/athena-downloads/drivers/JDBC/SimbaAthenaJDBC_2.0.2/AthenaJDBC41_2.0.2.jar

I'm having basically the same problem. I can authenticate and execute a query, but the results are never returned. If I look in Athena's history, I see that my query returned very quickly with the proper results.
DBeaver continues to spin, as if it's waiting for results, until it finally times out.
Is there some JDBC or DBeaver setting that I'm missing?

Okay, I fixed my problem: I needed to add the following directly into the jdbc url:
S3OutputLocation=s3://aws-athena-query-results-[your_aws_account_number]-[your_aws_region]
Adding this info into the DBeaver "S3 location" dialog box for my connection didn't work, but manually adding it to the URL did.
I hope someone else finds this useful.

I was not able to edit the URL, I tried modifying the URL Template but it was not picked up for the actual URL.


Deleting with foreign key constraints

Ok so I just ran into an issue in which I was trying to delete a row with a foreign key, but it's throwing an error saying "update or delete on table xxx violates foreign key constraint on table yyy". This is entirely reasonable and I understand why the error was thrown. My question is more what is the best way to deal with this? I know sometimes people want to delete the related item as well, but in my case I'd just like to just zero out the relation. So basically take any relations, remove the foreign keys from them, then delete the original row.
So my questions are: Is there any sort of shortcut to do an operation like this, or do I need to do it manually? If there is currently no shortcut, do you have a recommendation on the most efficient way to do it, and would you be interested in me trying to contribute this type of thing back to the library?

No shortcut at the moment. This type of thing will be difficult to get right with the various relation types so it's best you implement this yourself for the time being with a save and destroy.

Hey Ben,
Thanks for the quick response. I've put a number of hours into this, and it's actually been really difficult and incredibly frustrating. I'm sure a part of this is because I'm not as familiar with bookshelf as you guys are, but nonetheless I would love to get even a slight bit of guidance on the best way to approach this.
My initial thought was to use the destroying event to find the relations, then zero them out. I tried something like this to do so (the before_destroy event is correctly linked and firing, and assuming this is in a "destination" model that has many "tips").
before_destroy: function(){
  When.map(this.related('tips'), function(m){ m.save(destination_id: null); });
}

This seemed legit to me -- before deleting the model, it zeroes out the relation so that there's no conflict when it's deleted. However, I'm still getting the same foreign key constraint. Are there any more properties I need to clear out before it can successfully be deleted? Do I need to clear out this.related('tips') somehow? Do I need to re-fetch the dependencies somehow before deleting as well?

Ah thanks, this is super helpful, really appreciate it. I'll try switching it over to that way and see if that improves things. And yeah I assumed that the null fetch probably had something to do with the fact that properties had changed, so that seems like it probably is correct. It doesn't look like that issue has been resolved though -- does fetch run a select including every property on the model? I do agree with the author that this does seem silly when you could just use the id...

That would be a breaking change and I'd like to get it into the next minor version

Makes sense. I assume you mean major? But yeah this is entirely fine, just wanted to make sure I wasn't doing something else wrong with the fetch thing. Replacing it with a fresh find by id for now is not an issue :grinning:
Thanks again for your great work on this library and your time helping out with this question. Really appreciate it Ben :grinning:

Minor versions are breaking pre 1.0

Oh of course hah, sounded funny when you said it that way for some reason.


Can remove endpoints of a spline in behavior_designer.html

You can add new points to the spline which lay "outside" the line though, but this shouldn't happen.
Firefox, 47, Ubuntu 14.04

Fixed in latest commit.


Add missing search input back into Bootstrap output (v4.0.0-preview.1)

Related #7

Added in https://github.com/docsbydoxdox/doxdox/releases/tag/v4.0.0-preview.7


vue3-carousel.js:328 Uncaught TypeError: 'set' on proxy: trap returned falsish for property 'itemsToShow'

all set up working ok but just breakpoints display 'Uncaught TypeError: 'set' on proxy: trap returned falsish for property 'itemsToShow''.  Anyone got the same issue ?
Vue3/Nuxt3

Is this issue still happening on the latest version?


when use ragas0.2,  unable to apply transformation: Connection error

when I try to use ragas0.2, I have encountered a problem：unable to apply transformation: Connection error，what shoud I do to deal with it?
enviroment: ragas=0.2,python=3.9
code:
from langchain.document_loaders import PyPDFLoader
from dotenv import load_dotenv
from langchain.embeddings import HuggingFaceEmbeddings
load_dotenv('.env')
loader = PyPDFLoader("xx.pdf")
docs = loader.load_and_split()
from ragas.llms import LangchainLLMWrapper
from langchain_openai import ChatOpenAI
chat = ChatOpenAI(
model="Qwen2",
temperature=0.3,
openai_api_key="xxx",
openai_api_base='xxx',
stop=['<|im_end|>']
)
evaluator_llm = LangchainLLMWrapper(chat)
generator_llm = LangchainLLMWrapper(chat)
from ragas.testset import TestsetGenerator
generator = TestsetGenerator(llm=generator_llm)
dataset = generator.generate_with_langchain_docs(docs, testset_size=1)
dataset.to_pandas()
error:
Applying [SummaryExtractor, HeadlinesExtractor]:   0%|          | 0/2 [00:00<?, ?it/s]unable to apply transformation: Connection error.
unable to apply transformation: Connection error.
Applying EmbeddingExtractor:   0%|          | 0/1 [00:00<?, ?it/s]unable to apply transformation: node.property('summary') must be a string, found '<class 'NoneType'>'
Applying HeadlineSplitter:   0%|          | 0/1 [00:00<?, ?it/s]unable to apply transformation: 'headlines' property not found in this node
Applying [EmbeddingExtractor, KeyphrasesExtractor, TitleExtractor]:   0%|          | 0/3 [00:00<?, ?it/s]unable to apply transformation: Connection error.
Applying [EmbeddingExtractor, KeyphrasesExtractor, TitleExtractor]:  33%|███▎      | 1/3 [00:01<00:02,  1.43s/it]unable to apply transformation: Connection error.
unable to apply transformation: Connection error.
Applying CosineSimilarityBuilder:   0%|          | 0/1 [00:00<?, ?it/s]unable to apply transformation: Node 03722fc8-bc34-470b-8b5d-bcdebc192a37 has no embedding
Traceback (most recent call last):
File "D:\RA_LLM\pythonProject\generate_test_data.py", line 129, in
dataset = generator.generate_with_langchain_docs(docs, testset_size=1)
File "D:\anaconda\envs\ragas\lib\site-packages\ragas\testset\synthesizers\generate.py", line 89, in generate_with_langchain_docs
apply_transforms(kg, transforms)
File "D:\anaconda\envs\ragas\lib\site-packages\ragas\testset\transforms\engine.py", line 102, in apply_transforms
transform.generate_execution_plan(kg),
File "D:\anaconda\envs\ragas\lib\site-packages\ragas\testset\transforms\base.py", line 325, in generate_execution_plan
filtered_kg = self.filter(kg)
File "D:\anaconda\envs\ragas\lib\site-packages\ragas\testset\transforms\relationship_builders\cosine.py", line 122, in filter
raise ValueError(f"Node {node.id} has no {self.property_name}")
ValueError: Node 03722fc8-bc34-470b-8b5d-bcdebc192a37 has no summary_embedding

@Z-oo883 = I was dealing with the same problem. It seems like in the 0.2.0 version, they did some refactoring and got rid of the embedding functionality that used to be part of the TestsetGenerator class in previous versions. I am not seeing the ability to pass an embedding model to the TestsetGenerator in the 0.2.0 version. I had to downgrade to use the 0.1.21 version instead to get it to work. With the new 0.2.0 version, I am not sure how you are supposed to create a testset with TestsetGenerator, if you cant either actively embed your text, or pass in embeddings somewhere earlier in the pipeline.

@Z-oo883 I have the same issue.
ERROR:ragas.testset.transforms.engine:unable to apply transformation: Connection error.
Also facing other errors in the process:
ERROR:ragas.prompt.pydantic_prompt:Prompt fix_output_format failed to parse output: The output parser failed to parse the output after 0 retries. ERROR:ragas.prompt.pydantic_prompt:Prompt headlines_extractor_prompt failed to parse output: The output parser failed to parse the output after 0 retries. ERROR:ragas.testset.transforms.engine:unable to apply transformation: The output parser failed to parse the output after 0 retries. ERROR:ragas.prompt.pydantic_prompt:Prompt fix_output_format failed to parse output: The output parser failed to parse the output after 0 retries. ERROR:ragas.prompt.pydantic_prompt:Prompt headlines_extractor_prompt failed to parse output: The output parser failed to parse the output after 0 retries. ERROR:ragas.testset.transforms.engine:unable to apply transformation: The output parser failed to parse the output after 0 retries. ERROR:ragas.testset.transforms.engine:unable to apply transformation: 'headlines' property not found in this node ERROR:ragas.testset.transforms.engine:unable to apply transformation: 'headlines' property not found in this node
I am following the updated how-to tutorial for test set generation without luck. I will try downgrading as @hunter-walden2113 suggested


Support #[cfg(..)]

Will fix #1920 and #1073

From the reference, the attribute syntax is defined as:
InnerAttribute :
   # ! [ Attr ]

OuterAttribute :
   # [ Attr ]

Attr :
   SimplePath AttrInput?

AttrInput :
     DelimTokenTree
   | = LiteralExpression_without_suffix

Currently we parse the whole attribute as bracket delimited token tree.
I think the SimplePath and = Literal syntax should be handled in ra_syntax.

Wow, thanks for that link @uHOOCCOOHu, I didn't realize that this was the case. I assumed that we've moved from meta items to unrestricted token trees, and completely missed this simple_path = Attr layer!
Yeah, we definitely should add that bit to the Ast. It can be done in a separate PR I think as it would have to modify tests files. So, we need to add
enum AttrInput {
     Literal(ast::Literal)
     TokenTree(ast::TokenTree)
}

impl ast::Attr {
     fn path() -> Option<ast::Path>;
     fn input() -> Option<ast::AttrInput>;
}

@matklad I created a new PR #1934 to fix Attr syntax. And this PR will be rebased after that getting merged.

I found inner attributes of mod and impl item are inside ItemList rather than direct children of item node. Thus inner attributes of items are totally ignored currently.
This example is weird but should work:
mod m {
    #![macro_use]
    macro_rules! foo { () => { struct S; }; }
}
foo!();

Maybe this should be another PR. But I'm not sure if we need to parse inner attributes as the direct children of item node, or extract them from ItemList when used.

We can't make them direct children of the item node: the syntax tree we use reflects concrete syntax exactly, and, in the concrete syntax, they are inside {}. So, we need another layer on top of AST which brings outer and inner attrs together

ping? @matklad

Fixed.

bors r+
Thanks!


Bug: time elapsed is not a function

Problem:
Run vuurwerk in debug mode and go back in time to a point where a firework is gliding in the air.  Then remove the future and try to continue running the program. Scratch will give the following error:
Uncaught TypeError TypeError: util.stackFrame.timer.timeElapsed is not a function
    at glide (/Users/.../C002309-thesis/ugent-Scratch/blink/scratch-vm/src/blocks/scratch3_motion.js:146:1)
    at execute (/Users/.../C002309-thesis/ugent-Scratch/blink/scratch-vm/src/engine/execute.js:518:1)
    at stepThread (/Users/.../C002309-thesis/ugent-Scratch/blink/scratch-vm/src/engine/sequencer.js:245:1)
    at stepThreads (/Users/.../C002309-thesis/ugent-Scratch/blink/scratch-vm/src/engine/sequencer.js:134:1)
    at _step (/Users/.../C002309-thesis/ugent-Scratch/blink/scratch-vm/src/engine/runtime.js:2149:1)
    at vm.runtime._step (/Users/.../C002309-thesis/ugent-Scratch/blink/itch/packages/core/src/context.ts:135:25)
    at <anonymous> (/Users/.../C002309-thesis/ugent-Scratch/blink/scratch-vm/src/engine/runtime.js:2753:1)

It seems like the logger is not properly logging the stackframe timer.

Logger was logging the stackframe correctly, timer object just need to be recreated when threads get deserialized in order for the error to go away.
How Blink should handle blocks that use timer object and js promises is a difficult question. For now, working this out will be postponed until the new execution model is completely finished.


Update a readme with information about old dash1.0 and storefront1.0

We're dropping the old views and old storefront. For some users, it can be confusing so we should create an additional section in the readme file with links like - https://github.com/mirumee/legacy-views and maybe GH issue with related technical discussion.

Fixed


IndexInfoBuilder interface extended

getActionMetadata
getSource
getIndexUri
getCommand

NetflixOSS » suro » suro-pull-requests #56 SUCCESS
This pull request looks good

suro-pull-requests #224 SUCCESS
This pull request looks good


Bug 24332139 - WEBSERVICE CALL CAN FAIL IF PAYLOAD INCLUDES WSSE:SECU…

…RITY HEADER

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=24332139

Bug 24332139 - WEBSERVICE CALL CAN FAIL IF PAYLOAD INCLUDES WSSE:SECURITY HEADER

rebased and going to be merged within #94


[KYUUBI #3865] Arrow-based result compression support

Why are the changes needed?

Local Test
Input dataset
spark.sql(
  """
    |select * from tpcds.sf10.catalog_sales limit 2000000
    |""".stripMargin)
  .write
  .mode("overwrite")
  .save("/tmp/parquet/tpcds/sf10/catalog_sales_2000000")

Query
cat /tmp/b.sql
select * from parquet.`/tmp/parquet/tpcds/sf10/catalog_sales_2000000`;

Beeline command
bin/beeline -u 'jdbc:hive2://${remote-ip}:10009/;' --hiveconf kyuubi.operation.result.codec=arrow --hiveconf kyuubi.operation.incremental.collect=true --hiveconf kyuubi.operation.result.compression.codec=gzip/lz4/zstd/snappy  -f /tmp/b.sql > /dev/null

Result

kyuubi.operation.result.compression.codec
time spent (round 1)
time spent (round 2)

lz4
116.563 seconds
114.017 seconds

snappy
117.992 seconds
122.061 seconds

zstd
107.774 seconds
108.832 seconds

gzip
143.361 seconds
141.129 seconds

none
183.002 seconds
169.164 seconds

I suggest remove the snappy support, comparing to other format, I don't see advantage of snappy.

gzip: high compression ratio, used widely and many languages and platforms have the built-in support.
lz4: the fastest one, also has pure java implementation.
zstd: the future-proof one, excellence in both speed and compression ratio.

Codecov Report

Merging #3877 (713d529) into master (599fb3c) will decrease coverage by 0.03%.
The diff coverage is 40.44%.

@@             Coverage Diff              @@
##             master    #3877      +/-   ##
============================================
- Coverage     51.70%   51.66%   -0.04%
  Complexity       13       13
============================================
  Files           504      506       +2
  Lines         28857    28943      +86
  Branches       3975     3982       +7
============================================
+ Hits          14920    14953      +33
- Misses        12521    12572      +51
- Partials       1416     1418       +2

Impacted Files
Coverage Δ

...he/kyuubi/jdbc/hive/KyuubiArrowQueryResultSet.java
0.00% <0.00%> (ø)

.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
3.85% <0.00%> (-0.06%)
:arrow_down:

...a/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java
26.18% <0.00%> (-0.17%)
:arrow_down:

...pache/kyuubi/jdbc/hive/arrow/CompressionCodec.java
0.00% <0.00%> (ø)

...yuubi/jdbc/hive/arrow/CompressionCodecFactory.java
0.00% <0.00%> (ø)

...uubi/engine/spark/operation/ExecuteStatement.scala
76.36% <33.33%> (-1.21%)
:arrow_down:

...g/apache/spark/sql/kyuubi/SparkDatasetHelper.scala
83.67% <92.30%> (+7.67%)
:arrow_up:

...kyuubi/engine/spark/operation/SparkOperation.scala
84.53% <100.00%> (+0.49%)
:arrow_up:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.44% <100.00%> (-0.06%)
:arrow_down:

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (-3.23%)
:arrow_down:

... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I suggest removing the snappy support, comparing to other formats, I don't see advantage of snappy.

gzip: high compression ratio, used widely, many languages and platforms have the built-in support.
lz4: the fastest one, also has pure java implementation.
zstd: the future-proof one, excellence in both speed and compression ratio.

SGTM, and removed snappy from the build-in support. End users can easily add snappy support as needed.

I suggest removing the snappy support, comparing to other formats, I don't see advantage of snappy.

gzip: high compression ratio, used widely, many languages and platforms have the built-in support.
lz4: the fastest one, also has pure java implementation.
zstd: the future-proof one, excellence in both speed and compression ratio.

+1 for these 3 supported compression list, and lz4 is the best to be the default compression type.

Forwarding informations from the offline discussion:

we plan to defer this feature after Spark Connect implemented arrow compression, because there are some different ways(e.g. arrow native, stream compression, block compression) to implement compression, we'd better to keep consistent w/ upstream.
aircompressor is good option for client side, the roughly testing shows it has same decompression performance as lz4-java and zstd-jni, but there are some memory allocation issue on lz4 stream decompression.


Debugging Grunt/Gulp/etc

I haven't done much testing with Gulp/Grunt inside devtool, first is to figure out how the commands should look (i.e. handling process.argv nicely) and then any additional problems that might crop up, e.g. native addons.
Also see #10.

Ok, just gave gulp and gulp-sass a quick run and things seem to be working nicely with<EMAIL_ADDRESS>The -- option should be used to clear devtool options and ensure they don't conflict with gulp.
# same as running "gulp"
devtool node_modules/gulp/bin/gulp.js -c --

# same as running "gulp watch"
devtool node_modules/gulp/bin/gulp.js -c -- wach

Here a breakpoint is hit after changing a local SASS file with gulp watch.

Will add to readme eventually.


Fix thread-safety issues with frozen Results

Results being lazily evaluated makes reading from it from multiple threads without any locking unsafe even when it's backed by a frozen Realm. To fix this we need to introduce some locking around the members which can be mutated on read. Benchmarking indicated a measurable slowdown from always doing the locking (~10% time increase for iterating over query results from obj-c), so it uses an "optional" mutex which is a no-op for non-frozen realms and only actually locks when the realm is frozen.
The complicated control flow inside Results made figuring out where exactly locks were needed (and needed to not be present to avoid deadlocks), so I introduced the use of clang's Thread Safety Analysis annotations which perform static checks at compile time to verify that mutexes are held or not held at the appropriate times. Applying these to RealmCoordinator and CollectionNotifier also revealed a few missing locks in RealmCoordinator.
List and Results also have a lazily populated pointer to the associated object schema, which merely needs to be atomic.
As part of auditing each of the types applicable to frozen Realms for things which might be thread-unsafe I also went ahead and marked a bunch of things as const and/or noexcept to cut down on the number of things which could be unsafe.

By the way, I'm getting the following with Apple LLVM version 10.0.1 (clang-1<IP_ADDRESS>)
[22/42] Building CXX object src/CMakeFiles/realm-object-store.dir/impl/realm_coordinator.cpp.o
../src/impl/realm_coordinator.cpp:966:14: warning: acquiring mutex 'lock' that is already held [-Wthread-safety-analysis]
        lock.lock();
             ^
../src/impl/realm_coordinator.cpp:969:14: warning: releasing mutex 'm_notifier_mutex' that was not held [-Wthread-safety-analysis]
        lock.unlock();
             ^
../src/impl/realm_coordinator.cpp:994:10: warning: acquiring mutex 'lock' that is already held [-Wthread-safety-analysis]
    lock.lock();
         ^
../src/impl/realm_coordinator.cpp:1001:5: warning: calling function 'clean_up_dead_notifiers' requires holding mutex 'm_notifier_mutex' exclusively [-Wthread-safety-analysis]
    clean_up_dead_notifiers();
    ^
4 warnings generated.

Is this expected, or do I need to upgrade clang?

Looks like that's a bug in the version of clang shipped with Xcode 10.x, but working around it turned out to be easy and maybe made the code better anyway.


GD25 mtd issues

Summary
Added a 256Mbit GD25 device to the list of supported devices.
Discovered that the 4 byte status is in bit 0 not bit 3 for all the GD25Q devices I checked, so code added to check the correct bit depending on the discovered DEVICE ID.
See Issue #7670
Impact
None
Testing
Custom SAMA5D27 board fitted with GD25Q256ERIRR device which is now correctly identified and operating as required.

@TimJTi please squash your patches into one:
git rebase --interactive HEAD~10
and change all pick to squash except the first one
it's very bad to have the intermediate change in the history.

Still struggle with Githib, sorry.

I thought I had squashed, it now won't let me as there is a merge mixed in with it all. I will close this PR, check the PR linked by @xiaoxiang781216 and submit a new PR if appropriate once I've sorted it all out.


Cluster component gives error

Codepen support
Unfortunately, I'm not able to make the code work on Codepen.
Describe what you're reporting
I suppose that a recent update of the VueJs is conflicting with the component code. The library was correctly grouping the markers in clusters until a couple of weeks ago. Now, the markers are no more shown on the map due to the following error:
bindProps.js?2403:32 Uncaught (in promise) Error: setMaxZoom is not a method of (the Maps object corresponding to) undefined
    at bindProps (bindProps.js?2403:32:1)
    at eval (build-component.js?b97c:108:20)

Note that if you try to make the markers be rendered directly on the map (i.e., removing the Cluster component and using the Marker component directly), the problem is not showing up.
How can we reproduce it?
You should reproduce it using the example code that is in the README file in the Cluster component section.
What were your expecting to happen?
The marker should be grouped correctly in clusters and shown on the map without the above error.
Device or environment

Windows 11
Chrome
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I also have this issue when using the Cluster.

Hello! Thanks for reporting this problem, sorry for the delay, its holiday where I live today.

I suppose that a recent update of the VueJs is conflicting with the component code

Can you remember the last version you were using before?
I'll check if something changed in Vue that could affect us and see if something in setMaxZoom could be broken as soon as I can.

Hi @NathanAP!

Hello! Thanks for reporting this problem, sorry for the delay, its holiday where I live today.

Never mind. It's not an emergency, and you've responded quickly to the issue ticket.
I've temporarily solved removing the Cluster component.

Can you remember the last version you were using before?

Tomorrow, I've tried to downgrade to<EMAIL_ADDRESS>but the problem is continuing to present. So, apparently, I was wrong about the VueJs conflict.
Hoping it will be more helpful, however here it is my dependencies:
 "devDependencies": {
    "@inertiajs/inertia": "^0.11.0",
    "@inertiajs/inertia-vue3": "^0.6.0",
    "@inertiajs/progress": "^0.2.7",
    "@tailwindcss/forms": "^0.5.0",
    "@tailwindcss/typography": "^0.5.2",
    "@vue/compiler-sfc": "^3.2.31",
    "axios": "^0.21.1",
    "browser-sync": "^2.26.13",
    "browser-sync-webpack-plugin": "^2.3.0",
    "cross-env": "^7.0",
    "eslint": "^7.18.0",
    "eslint-config-standard": "^16.0.2",
    "eslint-plugin-import": "^2.22.1",
    "eslint-plugin-node": "^11.1.0",
    "eslint-plugin-promise": "^4.2.1",
    "laravel-mix": "^6.0.18",
    "laravel-vapor": "^0.6.0",
    "lodash": "^4.17.19",
    "postcss-import": "^14.0.2",
    "resolve-url-loader": "^5.0.0",
    "sass": "^1.32.5",
    "sass-loader": "^8.0.2",
    "tailwindcss": "^3.0.0",
    "vue-loader": "^17.0.0",
    "vue-template-compiler": "^2.6.12",
    "webpack-cli": "^4.5.0",
    "webpack-node-externals": "^3.0.0"
},
"dependencies": {
    "@vue/reactivity": "^3.2.20",
    "@vue/runtime-core": "^3.2.20",
    "@vuepic/vue-datepicker": "^3.1.0",
    "crypto-js": "^4.1.1",
    "js-cookie": "^2.2.1",
    "laravel-vue-i18n": "^1.4.3",
    "luxon": "^2.2.0",
    "suggestags": "^1.25.0",
    "tiny-emitter": "^2.1.0",
    "vee-validate": "^4.5.11",
    "vue": "v3.2.31",
    "vue-google-maps-community-fork": "^0.1.4",
    "vue-multiselect": "^3.0.0-alpha.2",
    "vue-router": "^4.0.12",
    "vue-simple-addthis-share": "^0.1.5",
    "vue3-loading-overlay": "^0.0.0",
    "vue3-touch-events": "^4.1.0",
    "vuedraggable": "^4.1.0",
    "vuex": "^4.0.0",
    "webpack-s3-plugin": "^1.2.0-rc.0",
    "yup": "^0.32.11"
}

OK, I found out some information about this issue:

I am reproducing it here, you can see in browser it is occuring (I will make Playcode our main playground instead of Codepen. Next version it will be showing up).

this was already occurring in Fawmi's version, as you can see here.

its is related to two files:

The bindProps 169:15 is about this
While this.$clusterObject.repaint is not a function is about this

people were talking here and here about this problem, but Fawmi never answered them.

@tahaipek , @lugrinder , @YassineChe sorry to ping you guys directly. Did you find something about this problem?

@NathanAP,
Since i posted the issue i tried many solutions but none of 'em worked,
Hopefully i'm using this library for admin side, until the owner wake up and fix it 😉
Keep me up to date.
Thanks.

@YassineChe I recommend you read this. Fawmi never answered any of us since July. We forked to keep this library alive, many bugs are fixed in our fork.

Some more research:

The history behind this bug seems to be related to changing the googlemaps/markerclusterer dependency. Fawmi used another called markerclustererplus but it is deprecated now. Fawmi changed to what they recommended.
In this part of code, it checks if the funcion googleMapsInst[setMethodName] exists. It is working as intended for others cases, here are some prints:

Working case:

Not working case (when we get the error):

There is a lot of cases it is using correctly, so I guess that setMaxZoom is not used anymore or was changed for something else.

The history behind this bug seems to be related to changing the googlemaps/markerclusterer dependency. Fawmi used another called markerclustererplus but it is deprecated now. Fawmi changed to what they recommended.

You're totally right @NathanAP!
I've also debugged the code, and as you pointed out it obviously couldn't work due to the change of the new class used for rendering the clusters on the map. The bindProps method (that you mention here), that is called from here, tries to bind the Cluster component properties to the relative googlemaps/markerclusterer getters and setters methods raising the error.
As you can see from here, this is due to the lack of the setters and getters for the Cluster component props in the new class googlemaps/markerclusterer.
So, the bindProps function can't work for the Cluster component. Maybe, isn't anymore necessary for this component?

If thats the case, in
// src / components / cluster.vue
maxZoom: {
    type: Number,
    twoWay: false,
  },

we could just add noBind: true, because in
src / utils / bindProps.js

line 24: if (noBind) continue

... Right? 🤔🤔🤔🤔🤔
I will test it tomorrow!

we could just add noBind: true, because in

Then it should be added to all the Cluster props because none of these props hasn't a setter/getter method in that class. However, I tried brutally removing all the props from the component, and this only solves the error rising but the clusters aren't rendered.

I will test it tomorrow!

Of course, it's too late to continue thinking about it 😅

However, I tried brutally removing all the props from the component, and this only solves the error rising but the clusters aren't rendered.

Yeah, I don't think it will resolve because we need to reference the map that we wanna show the clusters...
Anyway, I'm investigating the code again. It seems that when we are using the MarkerCluster, that googleMapsInst variable is not what it should be, so I guess Fawmi didn't adapt the code or they changed later.
For example, if we only use a simple Marker and keep track of googleMapsInst, all of his getters and setters are there correctly, but not for MarkerClusters. Those variables are being set in this part of the code. These are the actual getters and setters when we use MarkerCluster:

Most of these getters and setters seems related to Map component. I guess there is something wrong with googleMapsInst then?

Anyway, I'm investigating the code again. It seems that when we are using the MarkerCluster, that googleMapsInst variable is not what it should be, so I guess Fawmi didn't adapt the code or they changed later.

You get the point! In particular, there is no bind between the buildComponent function argument ctrArgs of the cluster component and the constructor of the new class MarkerCluster. In fact, the latter is using destructured parameters so the ctrArgs (as it has been defined in the cluster.vue) will pass to this constructor the wrong parameters.

These are the actual getters and setters when we use MarkerCluster:

Yes, as you can see from your screenshot, there're no setters or getters. That is the problem that leads to the setMaxZoom error.
However, I'm currently working on the fix to work with the new class constructor. Also, the fix will permit to define a custom render function (default DefaultRenderer) and choose the clustering algorithm (default SuperClusterAlgorithm).
Within today, I will make a PR.

Yeah, I start to make some console.log in the entire build-component.js and notice that the bindProps arguments were almost in the wrong format / class.

However, I'm currently working on the fix to work with the new class constructor. Also, the fix will permit to define a custom render function (default DefaultRenderer) and choose the clustering algorithm (default SuperClusterAlgorithm).

Thanks you so much and good luck with the PR! If you need something please let us know.

@NathanAP
Hello again, any news about Clustering ?

As promised, I made the PR that ends the porting started by Fawmi to the new MarkerClusterer class and should fix the setMaxZoom error!

@NathanAP
Hello again, any news about Clustering ?

Almost sure that today is the last day of this problem!

@NathanAP
Great, let's up to date, thanks
Happy coding!

Fixed by #19 and its up in 0.1.5. You can download the new version :)
If you need help or find some bug, please feel free to open another issue!

@NathanAP
Still getting
Uncaught (in promise) Error: setMaxZoom is not a method of (the Maps object corresponding to) undefined
    at bindProps (bindProps.js?v=e9f5f753:32:13)
    at build-component.js?v=e9f5f753:108:11

Even i added :maxZoom="10" in the latest version ^0.1.5
Any suggestions ?

Sorry guys, I made a mistake when I publish the 0.1.5 into npm. My mistake.
I'm fixing it right now, will update this comment when everything is ok.

@NathanAP ,
You did a great job! Its working now!
Just a quick question is there is any way to customize cluster Color ?
Thanks.

@YassineChe of course you can. And not only the color.
Note that the component properties have been changed since version 0.1.5.
Please, have a look at PR #19. In particular, I suggest having a deep look at the @googlemaps/markerclusterer documentation linked at the end of the PR. Here you can find more examples of the render function you could implement to change marker cluster color.

I think we could add a color change example later in the docs!

@NathanAP
Yes, Please

Still having this issue in
 "vue-google-maps-community-fork": "^0.3.1",
 ```


Flake8 configuration and variable substitution

Using variables in args yields error. This is contradictory to for example the pylint extension which handles variable fine.
"flake8.args": ["--config","${workspaceFolder}/setup.cfg"],

Output:
There was a critical error during execution of Flake8:
The specified config file does not exist: ${workspaceFolder}/setup.cfg

Hello! I wanted to update to say we have received this issue and will be looking into it!


Make 'group' field in config.status.resources omitempty

We have the 'group' field in the config.spec.resources omitempty for K8s
core resources. This PR makes the field in status matches what in the
spec. For K8s core resources, the group will be omitted.
Tested manually by configuring 'secrets', which is a K8s core resource
with empty group and the group field is omitted in both spec and status.
The issue was:
spec:
  resources:
  - mode: Propagate
    resource: secrets
status:
  resources:
  - group: ""                       <<<<<<<<< not  omit empty
    mode: Propagate
    numPropagatedObjects: 1
    numSourceObjects: 5
    resource: secrets
    version: v1
  - group: rbac.authorization.k8s.io
    mode: Propagate
    numPropagatedObjects: 1
    numSourceObjects: 1
    resource: rolebindings
    version: v1
  - group: rbac.authorization.k8s.io
    mode: Propagate
    numPropagatedObjects: 1
    numSourceObjects: 1
    resource: roles
    version: v1

Part of #868

/assign @adrianludwin
/assign @GinnyJI
/assign @rjbez17

Discussed offline and the group field in the status was kept deliberately to give more info (empty string for K8s core resources).


Checklist of shallow water implementation

This issue serves to collect what features / mesh types are available for the shallow water system:

[ ] TreeMesh1D
[ ] TreeMesh2D
[x] StructuredMesh2D
[x] UnstructuredMesh2D
[ ] P4estMesh2D
[x] Flux differencing form
[ ] AMR (for this feature the issue of well-balancedness becomes interesting)
[ ] Shock capturing (related to #736)

Reducing the 2D implementations to 1D would be a nice student/first project.

Is this issue still up-to-date/relevant?


Modify Houdini SEpolicy according to integration doc

Upgrade android from 12 to 14, still use the old Houdini environment, Change the SEpolicy according to Houdini integration doc.
Tracked-On: OAM-120355

LGTM

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web  for more details.

This pull request cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

This pull request cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.


doamin

DKIM record is not supported?

Hello oliik. Can you please share exactly what do you need the subdomain for, so I can help you better?

I trying to use the domain for custom E-mail address

Our service does not support DKIM records.
But you don't need one to set up the necessary records for email. You will need a TXT and an MX record. You will add those records to the original JSON you submitted alongside your CNAME record.
I will close this PR and feel free to edit your original JSON to add the necessary MX and TXT records provided by your email host.


Is DiNAT code is runnable?

Hi, thanks for contribution, I'm very appreciate on your work.
I try to use the DiNAT_s code, and in below forward function, there seems some problem.
def forward(self, x):
        x = self.patch_embed(x)
        x = self.pos_drop(x)
        outs = []
        for i in range(self.num_layers):
            layer = self.layers[i]
            x_out, x = layer(x) ###### x_out is 4D tensor, x is 3D tensor
            if i in self.out_indices:
                norm_layer = getattr(self, f"norm{i}")
                x_out = norm_layer(x_out)

                out = x_out.permute(0, 3, 1, 2).contiguous()
                outs.append(out)

        return tuple(outs)

All weights are loaded properly with given 'dinat_s.pth' to designed (+some revision) model, but the tensor shape is odd. After tensor pass the first layer(i=0), x becomes 3D tensor. But it should be 4D tensor, so that it can be used on next layer(I=1). I debug this and on the End of the layer#0, it contains PatchMerging which makes output tensor shape [B, H/2W/2, 4C].
Think I'm in stuck and need help. Is model design is somehow change, or am I doing something wrong?

Hello and thank you for your interest.
Thank you for bringing this to our attention.
The issue
The reason for this issue is that DiNAT_s's implementation is slightly different than that of DiNAT and NAT because it was intended to be exactly like Swin Transformer in architecture, and only have its attention modules replaced.
Swin's original implementation  used the 3D shape ([B, HW, C]), and reshaped back into 4D ([B, H, W, C]) when required. We avoid this in NAT/DiNAT, since every operation and layer in the model either expects that format, or can handle it without needing to be reshaped, with the exception of convolutions, but those are very rare compared to everything else (3 convs need the reshape and permute + initial layer.)
Apparently the PatchMerge implementation in classification was correct in reshaping back to 4D, but not in detection and segmentation, which is what you're referencing since the snippet has out_indices.
Solution
We're working on a solution that should be tested and merged soon.

The PR was merged. Please let us know the issue persists.


Move runtime from Artifact to InferenceService

As noted by during Scrum 2023-10-07, there is a need to move the runtime from currently Artifact entity:
https://github.com/opendatahub-io/model-registry/blob/958630a33cac0c5686eb16df5731ab3abcd270e9/api/openapi/model-registry.yaml#L1321-L1334
to the InferenceService entity.

lgtm

@isinyaaa is there a complimentary commit to add the property to InferenceService?

@dhirajsb I can fix that too, but this commit belongs to PR #132 .

Ok, just making sure we don't forget about moving it to the right place.


Missing guides section?

Hi all, I've clicked on the README.md file's link suggesting I check out guides, but it gives a 404 not found error.

Oh, perhaps this has been moved to the docker folder?


Cannot compile due to not found errors

Hi there, this seems to be a subdependency of a project I'm working on and I'm unable to compile it.
Some errors have detailed explanations: E0405, E0412, E0425, E0432, E0463.
error: could not compile `ppv-lite86` (lib) due to 747 previous errors

I seem to be getting errors like this
error[E0425]: cannot find function `_mm256_setr_m128i` in this scope
    --> /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ppv-lite86-0.2.17/src/x86_64/sse2.rs:1698:39
     |
1698 |                     u32x4x2_avx2::new(_mm256_setr_m128i(x.0[2].x, x.0[3].x)),
     |                                       ^^^^^^^^^^^^^^^^^ not found in this scope

My hunch is that it's something to do with the targets I have installed. I've tried checking I have x86_64-unknown-linux-gnu setup on my Linux machine so I'm not sure if there's something I'm missing?

Seemed to be something with the channel. It's working after updating from 1.76.0 in rust-toolchain.toml
I'll leave to you to decide whether to close this


[Bug] Query parameters are lost in the URL when redirected by assigning the URL to window.location.

Demo
https://codesandbox.io/p/sandbox/vite-plugin-html-redirect-demo-jhjqtn?file=%2Fvite.config.js
Reproduce steps

Set server.proxy rules and use vite-plugin-html

import { defineConfig } from "vite";
import vue from "@vitejs/plugin-vue";
import { createHtmlPlugin } from "vite-plugin-html";

export default defineConfig({
  plugins: [
    vue(),
    createHtmlPlugin({
      entry: "/src/main.js",
      template: "index.html",
    }),
  ],
  server: {
    cors: true,
    proxy: {
      "/api": {
        target: "https://www.baidu.com",
        changeOrigin: true,
        configure: (proxy, _options) => {
          proxy.on("proxyReq", function (proxyReq, req, res, options) {
            if (req.url.includes("/api")) {
              console.log("req.url", req.url);
              console.log("req.originalUrl", req.originalUrl);
              console.log("req._parsedUrl", req._parsedUrl);
            }
          });
        },
      },
    },
  },
});

Assign a URL (/api/login?redirect=mockUrl) to window.location.href when clicking the Redirect button

<template>

      <button type="button" @click="onFetch">Fetch</button>
      <button type="button" @click="onRedirect">Redirect</button>

</template>

Losing the query params in request

On the console, we can see the originalUrl that was requested is /api/login?redirect=mockUrl , but it becomes /api/login after being handled by the proxy middleware.
And the URL is correct when we click the Fetch button to trigger a xhr request.

Reason
code
// https://github.com/vbenjs/vite-plugin-html/blob/main/packages/core/src/htmlPlugin.ts#L87-L93
server.middlewares.use(
    history({
      disableDotRule: undefined,
      htmlAcceptHeaders: ['text/html', 'application/xhtml+xml'],
      rewrites: rewrites,
    }),
)

// https://github.com/vbenjs/vite-plugin-html/blob/main/packages/core/src/htmlPlugin.ts#L331
function createRewire(
  reg: string,
  page: any,
  baseUrl: string,
  proxyUrlKeys: string[],
) {
  return {
    from: new RegExp(`^/${reg}*`),
    to({ parsedUrl }: any) {
      const pathname: string = parsedUrl.pathname

      const excludeBaseUrl = pathname.replace(baseUrl, '/')

      const template = path.resolve(baseUrl, page.template)

      if (excludeBaseUrl === '/') {
        return template
      }
      const isApiUrl = proxyUrlKeys.some((item) =>
        pathname.startsWith(path.resolve(baseUrl, item)),
      )
      return isApiUrl ? excludeBaseUrl : template
    },
  }
}

The vite-plugin-html adds a proxy handling rule for text/html type request, and uses parsedUrl.pathname which doesn't contain query params (pic below) as the path to redirect. So the problem occurs when starts a document request but the xhr requests is good.

up up up

Actually, when createHtmlPlugin is enabled, any route is ignored and only the root path is rendered.
This happens even with the public folder.
As a quick test:

place favicon.png in public folder
In the browser navigate to http:localhost:8080/favicon.png
The application is loaded in the browser instead of the image.

Try https://www.npmjs.com/package/vite-plugin-simple-html
It has fewer features, but as a result, far less magic required. I developed it specifically to cover my needs while not be affected by this bug, which was a blocker for me migrating to Vite.


SpecifyingEnvPortInEndpointFlowsToEnv fails due to incorrect suffix assumption

This test fails consistently for me. Debugging it, the issue appears to be a bad suffix assumption:
        var serviceA = await KubernetesHelper.GetResourceByNameAsync<Executable>(kubernetes, $"servicea-{suffix}", r => r.Status?.EffectiveEnv is not null, token);

So if the suffix is 2688b7d4, KubernetesHelper.GetResourceByNameAsync expects a name that starts with servicea-2688b7d4.
            if ((name == resourceName || name.StartsWith(resourceName + "-", StringComparison.Ordinal)) && ready(r))

The problem is that there is an extra token between the two in the actual name, e.g. servicea-rbyrdkwr-2688b7d4. So it never finds it, and the test ends up timing out.

This is a regression from a5b3bcfddb3478ab34f207251929d531322d1a85, which I guess changed the naming pattern. We just need to adapt the test accordingly.

Sent PR. /cc @JamesNK @davidfowl


How can I hide the tabBar when I pull the drawer out by gesture

and of course,show the tabBar again when I push the drawer in.

You can use setGestureCompletionBlock if you just want to hide/show or use setDrawerVisualStateBlock if you want to hide/show the tab bar gradually depending on the drawer visibility.

thanks a lot

@mmahkamov @marshallYin I am using this cool Controller in my tab bar project. In my rightSideController, i have a chatViewController which of course has a UITextView at the bottom. I dont want it to be above the Tabbar since the keyboard appears with it. I didnt exactly understand the solution with setGestureCompletionBlock. I have tried to use hidesBottomBarWhenPushed for the sideViewController but no luck. more explanation would be great

@aytunch
func BtnPressed(sender: UIButton)
{
self.mm_drawerController.toggleDrawerSide(.Left, animated: true, completion: nil)
tabBarController?.tabBar.hidden = !(tabBarController?.tabBar.hidden == true)
}
This is how I did it ,maybe it can help you :)


[LiveComponent] How to pass form data to the test helper

The test helper docs show how you can call a LiveAction from the test - e.g.
// call live actions
$testComponent
    ->call('increase')
    ->call('increase', ['amount' => 2]) // call a live action with arguments
;

Can this also be used to supply form data?
For many of my LiveActions, I grab the form data and then perform one or more actions.
But the above seems to be for passing actual method params whereas I'd want to mock the form data obtained via $this->getForm()->getData(); etc.
Thanks

@kbond Has a solution to this recently been released? I think I saw something related in some recent release notes?


Handling non formatted Error on traceException

Currently if we have any non formatted error message such as without having exception.name , exception.message , exception.stack. We are not tracking the error message instead we end up throwing exception for the track message.
So, changed the code in a way that if any unhandled error message ( un-formatted ) we are handling in a app inshights code block.

@Karthikvenkat86 thanks a lot.


Move Screenshots to Bottom

The 'above the fold' space is very important, it seems possibly wasted with screenshots which aren't legible without enlarging. Proposing to move them down with this PR.
Let's capitalize on this MS traffic!

Codecov Report

Merging #4128 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4128   +/-   ##
=======================================
  Coverage   19.97%   19.97%
=======================================
  Files         153      153
  Lines       30494    30494
=======================================
  Hits         6091     6091
  Misses      23489    23489
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aee261...1cd15ed. Read the comment docs.

New to this community here - is there anything else I need to do to get this merged, or will it be handled from here on out?

No, owners do that


Can't use decimal numbers

Bicep version
0.4.63
Describe the bug
It currently doesn't seem possible to use a number type. All interges are treated as such. This causes a problem in app insights deployments for example where you want to put a data cap as 0.5 gb for example.
Not sure if this is a linter problem or language issue.

Many RPs allow using strings containing a floating point number as a workaround for this problem. Can you try to see if it'll unblock you?

There's similar issue to enable floats #1386

Closing as dup of #1386

Can confirm changing to string works

Can confirm changing to string works


openssl issues: build on windows mingw

$ ./config shared no-tests
$ make
a@A-PC /f/api/library/openssl-1.1.1d
$ make

it returns:
/bin/sh: d:perl-5.24.0binperl.exe: command not found
maybe it handles the perl env with wrong "", I manually changed the Makefile to
PERL=/d/perl-5.24.0/bin/perl.exe

$ make
it returns:
apps/apps.c:2136:47: error: 'ERROR_FILE_EXISTS' undeclared
I add the winerror.h to files needing the header
#include <winerror.h>

4 $ make
it returns:
crypto/bio/b_addr.o:b_addr.c:(.text+0xa9): undefined reference to getnameinfo'     crypto/bio/b_addr.o:b_addr.c:(.text+0xbac): undefined reference to getaddrinfo'
crypto/bio/b_addr.o:b_addr.c:(.text+0xd44): undefined reference to `getaddrinfo'

crypto/bio/b_addr.o:b_addr.c:(.text+0x869): undefined reference to `freeaddrinfo

'
crypto/init.o:init.c:(.text+0x1b3): undefined reference to GetModuleHandleEx'     crypto/init.o:init.c:(.text+0xb64): undefined reference to GetModuleHandleEx'
collect2.exe: error: ld returned 1 exit status
I changed Makefile from
CNF_EX_LIBS=-lws2_32 -lgdi32 -lcrypt32
to
CNF_EX_LIBS=-lgdi32 -lcrypt32 -lws2_32

$ make
finally it succeeded,I can find libcrypto.a  libssl.a  libssl-1_1.dll but WITHOUT libcrypto-1_1.dll,
and the compiled openssl.exe can not run without  libcrypto-1_1.dll, where is it, how can I build the libcrypto-1_1.dll

What perl version are you using, i.e. what does perl --version return?

Edit crypto/bio/b_addr.c and insert, after the includes, a line containing #undef AI_PASSIVE.

Marking as inactive, to be closed at the end of 3.4  dev, barring further input


Move focus styles from .btn-link to base .btn

This moves some resets from .btn-link to the base .btn to conform to the previous v5.1 .btn behaviour.
In 5.1:

In 5.2:

After this PR:

.btn has always required a modifier class, and this adds a few properties that aren't strictly necessary. I think we can skip this and keep the current behavior. Thoughts @twbs/css-review?

Closing per @mdo's comment above.


Merge https://github.com/k8snetworkplumbingwg/ovs-cni:main into main

/lgtm
/approve

I believe we need merge automation for this:

https://github.com/openshift/release/pull/56506


fix: improve thread-safety of request handling for high load

@aramalipoor is this mutex handling logic correct ?
https://github.com/erpc/erpc/pull/65/files#diff-9312b7975e3419b1d373974839f59deffed6ba93c18a8551e078450450e0b6dbL44
looks like you added unnecessary lock/unlock in that function?

The main use of mutex in here was due to 'potential' concurrent result parsing e.g. when reading the result when setting the cache + reading the result when returning back to client.
I think the RLock/RUnlock part probably is redundant 🤔
In the new PR I'm working on the approach is changed so this part of code is updated: https://github.com/erpc/erpc/pull/66/files#diff-9312b7975e3419b1d373974839f59deffed6ba93c18a8551e078450450e0b6dbR101
Your comment here is a good reminder for me to double check thread-safety there too. It would be amazing if you can look at that and let me know your thoughts :)

I just re-read the change and saw you're using read lock and only then a read+write lock, didn't spot it first. 🤦 Might be the correct way after all.
BTW perhaps you could think of setting up CI with race detector? https://go.dev/doc/articles/race_detector


Repeated villages in villages_corr.csv

Hi,
I have found 10 villages with two entries each in the file villages_corr.csv. In most of cases, each entry has a different value for lang (e.g. village = Akka, lang = Chechen and lang = Tabasaran), which might suggest the duplication is intentional for depicting multilingualism, but in all cases repeated villages have also different values for lat and long coordinates. If instead of using the English name village, we use the russian name rus_village, we obtain 11 villages instead (not exactly overlapping). See code and image.
villages_new <- read_tsv("data/villages_corr.csv")
which(table(villages_new$village) >1)
repeated <- subset(villages_new, village %in% c("Akka", "Beretbinə","Druzhba","Guni", "Kakamakhi", "Komsomol'skoe",       "Sadovoe", "Simsir ","Siukh","Vinogradnoe", "Yuzhnoe"))
repeated

It is possible to have repetitions I guess. @sverhees?

Thanks for this issue!
I will look into each case individually. Some villages indeed have the same name even though their location (and the language spoken there) is different, as in the case of Siukh or Yuzhnoe, but some of them seem to be legitimate errors in the data.

There were some duplicate villages because there are villages with the same name in different republics or in different districts. I added the name of the republic or district in brackets in order to disambiguate them. E.g. Sadovoe is now either "Sadovoe (Chechnya)" or "Sadovoe (Daghestan)".


fix(timeouts): return the right socket timeout error

@sgulseth: I think your

Pushed an alternate approach that doens't require to set the response on the request object here: https://github.com/sanity-io/get-it/compare/socket-timeout-fixes...alt-socket-timeout-fixes?expand=1
also improved some typings. WDYT?

Agreed! Merged it as-it since the tests passed. However, I also discovered that your change actually make us return multiple/duplicate errors on the channel (which I don't believe is what we want). I've improved the tests and pushed a fix as well.


chore: split generate.go file

@AlbertoBarba is this still a draft or is it good to go?

@omissis I’ll rebase it and ask for a review

@omissis now it should be good to go


Java9 Compatibility

There are currently 2 issues preventing to update to Java 9:

The current building on TAJS inspector relies on the plugin cz.habarta.typescript-generator that doesn't work properly on Java 9.
Current version of gradle (3.5) doesn't even recognise version 9 as a valid version.

Just FYI, as there isn't any development on TAJS inspector at the moment, the cz.habarta.typescript-generator doesn't really need to be invoked at every build. It only needs to be run if there are any API changes on the Java-side.

Yeah, but still needs to be disabled https://github.com/cs-au-dk/TAJS-Inspector/blob/java-9-compat/build.gradle


Remember focus on navigate back

Is your feature request related to a problem? Please describe.
First of all, thank you for this library, it helped us a lot. The last thing that we struggle now with is state persistence when navigating back. Eg, you're in 3rd row on 5th card, you select a movie, check its description, go back (via navigate(-1)). And suddenly your focus is back on 1,1 instead of 3, 5
Describe the solution you'd like
I was thinking that I would save on each page the focuskey before navigating elsewhere and then restore focus when the page is opened again. But that requires to save the focusKey manually and the restore it manually.
Describe alternatives you've considered
I am sure you must have came across this and resolved it somehow, do you please have some suggested solution how to tackle this?

Hey, thank you for reaching out.
This is a tricky one, cause it relies heavily on the navigation / route library you use and how you manage data loading.
Some of these libraries, like react-router unmount the components when you move to another screen, and others like react-navigation keep some routes mounted to allow fast transitions.
If you have a suggestion we can implement in this library that could work with different stacks feel free to share it here or open a PR.

Thanks, I wasnt aware of react-navigation (we used react-router till now). I will test it out, it sounds promising (although I am bit scared of how it will perform on those shitty TVs).
I will post a feedback once I have it.
Thanks a lot :+1:

react-navigation is for react native
Should it be work with react?

react-navigation is for react native. Should it be work with react?

React native has web support by using React Native Web.
Therefore, it will work with any react project. Nevertheless, installing react-native-web will increase your bundle size significantly compared to only installing react.

The consensus is that it's not this library responsibility to handle this and as such I am closing this.
Thanks everyone.


Allow vargs and kwargs

This allows us to pass positional arguments and not just keyword ones.

Thanks for your contribution.
While this fits a common API pattern for ActiveRecord I would rather not promote this usage. The reason is that using named/keyword arguments actually makes the query have improved clarity, especially with larger queries.
One advantage of adding this is that this would feel just that much more to a plain Rails dev attempting to use it without looking at any docs.
However I suppose that the ? syntax is most useful for very short queries. Given the non-chained style of sql execution this gem is supporting, I dont think that very "small" queries and quick dev time are really on the radar.


Update WithChunkReadingTest.php

AfterImport being triggered twice after every successful import with ChunkReading
Applicable Issues
https://github.com/Maatwebsite/Laravel-Excel/issues/2673#issue-620370007

According to this test the AfterImport event doesn't get triggered twice?

@dvmsk any update on this?


Include option trades

Yes this will be a nice to have with options becoming mainstream now on Robinhood.

Now available thanks to @vignesh57
python csv-options-export.py


preserve declarations if @internal is mentioned in unrelated comment

Fixes #57352

Merged main for you.
As far as I'm concerned, this PR is correct; I tested dtsBundler with it and it still correctly strips internal declarations via isInternalDeclaration.
But I know we're pretty iffy on whether or not @internal is even supported or not. Only recently did I make the function to check the tag public, and this PR formalizes it into our API.
I'm personally still for it, regardless, but I'll bring this one up in a design meeting just to double check.

Close/reopening to rerun CI and show the failure.

Took the liberty to apply the described change.

Just checking:
@typescript-bot test it

The DT errors should have been fixed.

@typescript-bot test it

@typescript-bot test it

Perf is unfortunately still greatly affected and needs to be looked into.

Perf problem is likely caused by the regex change.
const jsDocNeededInTypeScriptFile = /@(?:see|link|internal)/i; is 6% slower than the original one.
perf.link

Funnily I clicked that link and reran it, and it told me that the new one was 6% faster; I think this particular result is just noisy. Given the benchmark is consistent with so few samples, a profile may provide more insight (which I plan to test).

LOL. After I executed it many times, I also found that the output result is somewhat random.

Do the random perf results mean this is safe to merge? I'd guess not, unless it's a problem with the perf infrastructure.

No, there's nothing wrong with the perf infra, there really is a slowdown here that needs to be profiled.

@typescript-bot perf test this faster
I can't seem to get the slowdown locally...


Service name

I notice in the release notes:

You may now specify a service name rather than port when connecting with a TcpSocketClient. Thanks @SparkStream

Does this mean that the library does a DNS SVC record lookup and connects to the proper port?  If so, that is fantastic!

Howdy, I think it's 'sort of' that good - but we might be able to make it work the way you say. Currently:

on WinRT: it uses the native ConnectAsync(string hostName, string serviceName) method, which presumably does what you say.
on .NET: it looks up the service name using this method, which is basically me taking the names defined in the hosts file, because I wasn't clued up on DNS SVC lookup. It sounds like that might be a better approach, but I'll need to read up on it!

Ah, I see.  No, this is not SVC Record related.  Its simply a named port e.g "ftp" = port 21.   Guess I need to keep looking for a PCL DNS library that can lookup SVC records.  Thanks!


Use ubercadence/web 3.1.2

Version 3.2.1 does not exist:
$ docker-compose up
Pulling cadence-web (ubercadence/web:3.2.1)...
ERROR: manifest for ubercadence/web:3.2.1 not found

Change to 3.1.2, which is the latest ubercadence/web version.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.