Consolidate the general report structure

Consolidate the proposed structural approach preserving the duality of FHIR document and diagnosticReport

The proposed approach tries to balance on one hand the expectation to have all the different types of documents (summaries, diagnostic reports, other reports,... ) represented by using the same approach, to facilitate also the mapping from the existing CDA documents. On the other side the fact that HL7 FHIR introduced a specific resource for diagnostic reports the DiagnosticReport (and only for this kind of documents) that is expected to be used by several FHIR based systems for managing diagnostic reports' information.
The solution proposed has been that of using a signable document bundle (a FHIR Document) including include also the DiagnosticReport resource.
Advantage:

preserve the FHIR document and diagnosticReport duality

Disavantage:

potential duplication of information in Composition and DiagnosticReport (a little more work for creators)

To be discussed:

[ ] Should or shall include a diagnosticReport ?
[ ] Should we rely on the information that are in the composition or to have them duplicated in the diagnostciReport ?
[ ] The diagnosticReport is included in the  bundle by using a reverse relationship DiagnosticReport  Composition; done with a R5 extension (I,e the composition element added in R5) . This mean that we are pre-adopting a R5 rule, while R4 requests that data in the bundle has to be referenced from the composition down (with the exception of Provenance). Do you agree with this approach that can bring to warnings when the Bundle is validated ?

I agree we need to discuss and resolve those items - ideally before going too much farther.  I have some additional comments/questions on the particular items:

Should or shall include a diagnosticReport ?
Yes, we need to decide if the DiagnosticReport in the Bundle should be 0..1 or 1..1.

Should we rely on the information that are in the composition or to have them duplicated in the diagnostciReport ?
Have we figured out the list of which elements are actually duplicated between DiagnosticReport and Composition (I haven't actually tried to do that yet)?  The elements that are resource references don't matter, as the content isn't actually duplicated.

The diagnosticReport is included in the bundle by using a reverse relationship DiagnosticReport  Composition; done with
a R5 extension (I,e the composition element added in R5) . This mean that we are pre-adopting a R5 rule, while R4
requests that data in the bundle has to be referenced from the composition down (with the exception of Provenance). Do
you agree with this approach that can bring to warnings when the Bundle is validated ?
I think the R5 "rule" is actually mostly a clarification, rather than an actual change.  From the conversations that we had, I think it mainly comes down to Grahame Grieve agreeing to modify his interpretation so that it least more closely is aligned with what Lloyd McKenzie had been thinking was allowed all along (references between the included resource and the Bundle that could be made in either direction).  So, in my opinion at this point, we should be on pretty safe ground to adopt in R4(B) the R5 extension that references Bundle from Composition.  I agree that there may still (at least for a while) be some IG Publisher warnings about this.  But I expect that this would be rather readily explainable and shouldn't cause any significant problems with approval of the IG for publication (and I'm not sure of all of the details of the process for European FHIR IG publications).

Should we create a single generic Bundle profile or have also specialized profiles for different kinds of lab reports ?
There may be some potential usefulness for doing this, but I'm not sure if or how much it would be needed.  It would depend on the specific specializations being considered (e.g., something like microbiology, genomics), I think.

Have you any other comment on the current Bundle profile ?
I don't have any further comments at the moment.

Have we figured out the list of which elements are actually duplicated between DiagnosticReport and Composition? I haven't actually tried to do that yet. The elements that are resource references don't matter in this case, as the content isn't actually being duplicated (multiple references to the same resource are fine).

good catch... created a new issue #11

Regarding the question if we shall include the DiagnosticReport as 0..1 or 1..1 we have to discuss the use cases this FHIR IG is supposed support.
Furthermore, I'm raising the question about the FHIR version that this IG is based on. Why is it R4?

Furthermore, I'm raising the question about the FHIR version that this IG is based on. Why is it R4?

Because several current implementations are based on R4, I'm aware about R4b/R5 only in the Pharma regulatory space.
We should consider R5 if there are reasons for moving in this direction.
Nothing however prevent us - when the work on R4 is done - to make also a R5 version of this guide.

I think it may be useful to consider whether we should work on R4B and R5 versions simultaneously.  As I expect we probably all are aware, R5 (5.0.0) is now the default FHIR version - although it is likely that many specifications and implementations will remain on R4/R4B for a considerable period of time (potentially until after R6 is released).  But I think it is a relatively small amount of additional work to do prepare and provide both the R4B and R5 versions simultaneously - and that probably would end up being considerably less additional work overall than doing them sequentially.

even though I think we could do R5 after R4B, the dual approach seems better at the moment since it could help us track (potentially breaking) changes between versions that we might overlook unless we actually do the work

even though I think we could do R5 after R4B, the dual approach seems better at the moment since it could help us track (potentially breaking) changes between versions that we might overlook unless we actually do the work

Distinct issue created for this topic #12

General opinion in Belgium is now at the moment to stick with R4 ( R5 might be considered in the future )

2023-04-13: keep the Diagnostic Report reference to the Composition

2023-04-13: let's start with the generic profiles and then let's see if we need specialized profiles. There may be in fact some potential usefulness for doing this. It would depend on the specific specializations being considered (e.g., something like microbiology, genomics).


Feature Request: Multilanguage

Is there any integration of languagefiles on the Roadmap?
Some users should be confused, if the plugin is not available in there native language.
thanks and greetz

Issue similar to #27

closing as duplicate


Issue with react-hooks/exhaustive-deps and custom hooks

Describe the bug
I've created a custom hook which returns an object with details such as loading (userCurrent.loading) and a method which can be used to fetch the data (userCurrent.fetch()).
But I am receiving the following error:
React Hook React.useEffect has a missing dependency: 'userCurrent'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
This warning is limiting my ability to make intricate custom hooks... Following the recommend fix results in an infinite loop. See the code bellow.
export const UsersSettings: React.FC<IUsersSettingsProps> = () => {
  // define custom hook > must be in function
  const userCurrent = useQueryUserCurrent();
  React.useEffect(() => {
    // want to call method on mount
    userCurrent.fetch();
  }, []); // changing to [userCurrent] causes infinite loop
  return (
    <ScreenUsersSettings
      loading={userCurrent.loading}
      initial={userCurrent.data.user}
    />
  );
};

Did you try recovering your dependencies?
Yes.

(Write your answer here.)
Which terms did you search for in User Guide?
There are many comments about this rule but I couldn't find one similar to this.

(Write your answer here if relevant.)
Environment
Dev.

fetch should likely be decoupled from userCurrent.  Something like fetch(userCurrent) should do the trick.
In any case, this isn't directly related to create-react-app.  You can file an issue in facebook/react about this, and please provide a minimal working codesandbox demo.

It seems that useQueryUserCurrent always returns a new object so you have infinte loop. Use React.useMemo to memoize a result.

So I should make my code more difficult to use because I should conform to a eslint rule?... That seems a little counterintuitive. I wouldn't care about it but I can't turn off the rule and it's throwing warning all over my screen.
React hooks has been the best thing in tech, you've all done a seriously game changing job. But this eslint rule hinders innovate a little bit.
I wouldn't care if I could just turn it off in my settings or something but i cant change the eslint settings, the compiler won't let me.

...This has actually made my code much faster 😅thanks a lot ❤
const useQueryUserCurrent = () => {
    // code...
    const state = useMemo(
      () => ({
        data: data || ({} as Partial<T>),
        loading,
        error,
        fetch,
        refresh,
      }),
      [data, loading, error, fetch, refresh]
    );
    return state;
}

The useMemo function helped improve the speed of my app but I still can't get the linter to work and  have methods that require access to the state changers inside a custom hook.

@jackrobertscott please provide a fully working demo illustrating this issue in a codesandbox.

@jackrobertscott  wouldn't be wrapping userCurrent.fetch() inside if(userCurrent.loading) statement by adding userCurrent as useEffect dependency inside help you here. And that is how useEffect should be used to avoid infinite loop here. Like this:
React.useEffect(() => {
   if(userCurrent.loading) userCurrent.fetch();
}, [userCurrent]);


suggested fix to use latest red4ext.sdk version, fixes crash on "pres…

updated to use latest red4sdk
fixes issue with "press [none] to start", in-game testing shows that it's working.

Thanks - I had some uncommitted changes locally, but it's updated now.


No cast warning when 0 spell points

No warning is issued in chat when a character has 0 spell points. The warning works fine when low on spell points, but not when at 0. Additionally, the gritty version does not appear to be working as no health is removed from the character sheet when casting a spell at 0 spell points.

Hello, sorry for the late answer, I cannot reproduce the issue on a clean world.

Module version is: 1.4.0
Foundry Version is: 10 Build 288
DnD 5e System Version is: 2.0.3

I'm currently out of town, but when K get home I'll do some investigating
and get back to you.
On Sat, Oct 29, 2022, 12:36 Luca T. @.***> wrote:

[image: immagine]
https://user-images.githubusercontent.com/3662610/198842796-49b9a43a-5fba-4049-97b7-995da2162210.png
Module version is: 1.4.0
Foundry Version is: 10 Build 288
DnD 5e System Version is: 2.0.3
—
Reply to this email directly, view it on GitHub
https://github.com/misthero/dnd5e-spellpoints/issues/34#issuecomment-1295894435,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZBNPVUOT55FRFZEIGKHLTWFVG7HANCNFSM6AAAAAARP6R4CA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Dockerfile: change install order of reana-commons

Signed-off-by: Dinos Kousidis<EMAIL_ADDRESS>

@diegodelemos this should install properly reana-commons, it's possible that COPY . /code passes outdated .eggs


Make metrics and tracing optional

This tool is cool because it generates simple code in a single file. :+1:
I would like to avoid carrying a dependency on prometheus and yaeger/opentracing stuff, however.
Would it be possible to implement a flag that generates http clients exclusively without those features? For now I'm just going to remove it by hand.

That sounds good to me, what do you think @artsmolin ?

Btw, as far as I know, the OpenTelemetry standard doesn't require direct dependencies (cause it's done via tricky monkey patching). Maybe we should remove those dependencies at all, and bump major version?

@dontlaugh
Done. By default, the client is generated without metrics. To add metrics to the client, you must specify the --metrics flag.


quadsort.c now passes -Wall -Wextra -std=c99 -pedantic

Thanks, made some adjustments upstreams. Not going to get rid of \e as it's universally supported.


fixing #37. calling chartObj.resize() to render chart properly on data changes

thanks, looks good and test passing :+1:


Performance issues when evaluating innerText

The bug is fully described with a testcase on Mozilla bugzilla.
https://bugzilla.mozilla.org/show_bug.cgi?id=1260025
An explanation has been given by Mats Palmgren in Comment 3
https://bugzilla.mozilla.org/show_bug.cgi?id=1260025#c3
Here's the problematic script:

function tf_GetNodeText(n)
/*====================================================
	- returns text + text of child nodes of a node
=====================================================*/
{
	var s = n.textContent || n.innerText || n.innerHTML.replace(/\<[^<>]+>/g, '');
	s = s.replace(/^\s+/, '').replace(/\s+$/, '')/*.tf_Trim()*/;
	return s.tf_Trim();
}

So when n.textContent returns "" we will evaluate n.innerText which in this case
also returns "" so we will evaluate n.innerHTML too.  This function is called
once for each <td> it seems, about half of which are empty.

Apart from that, n.innerText flushes layout(*) so if there are DOM / style changes
between the calls to tf_GetNodeText this will be very costly.  And this is what
causes the performance problem in this case.

(*) this is documented here:
https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent

So, I think this bug is invalid.  The workaround to the .innerText flush
problem is to set display:none on the subtree while it's being modified.
In this case I'm guessing it's the <table> element. Like so:
tableElement.style.display="none"
// sort the table, i.e. all the tf_GetNodeText calls happens here
tableElement.style.display=""

Hi @karlcow,
Please note your excerpt refers to an old version of the HTML Table Filter Generator (HTFG) plugin, this is the TableFilter which now replaces HTFG.
Please use this plugin instead as HTFG is no longer maintained. Let me know if you experience the same performance issue.
Cheers

@koalyptus I am experience the same performance issue. The exact behavior as described in my bug report to mozilla. On large tables the script hangs.
My problem is that i only found the minified version of TableFilter, so i cannot tell you the exact point where to fix it. I'm not really into javascript development, could you tell me please if there is something like a unminified version for debugging?

@rimace,
You can find the source files in the src folder of your downloaded zip or cloned repository. You can also browse the repository files online on GitHub and this is what you are looking for:
https://github.com/koalyptus/TableFilter/blob/master/src/dom.js#L12
As you can see the exact same code was ported over in this plugin :( and as you point out there is room for improvement... always :) !
I could reproduce the issue and I will have a look into it. I don't think hiding the table element is the way to go though.  As textContent is now supported by all browsers, it will be most probably just a question of handling better the empty string case.
If you still want to setup a dev environment locally on your machine, please follow the README instructions:
https://github.com/koalyptus/TableFilter#development
Cheers

@koalyptus
Thanks.
Yeah, my testcase included ~ 2.000 empty td-Tags. So when getText is called, then node.textContent, node.innerText and the regex is executed, as javascript interprets an empty string as false.
I'll try to setup a test case for the new TableFilter (tomorrow), so that it gets reproducible.

Thanks @rimace, I am already using your test case pointing to TableFilter instead. I will try to spend some time on this today or next days depending on workload.
Cheers

@rimace,
I just published v0.2.5, give it  a try.
Cheers

@koalyptus
Wow, just tested the new version and it's way faster now.
Thank you very much for updating it this fast!

No worries, closing this issue.
Cheers


Remove usage of global registry from Go examples

Signed-off-by: Kemal Akkoyun<EMAIL_ADDRESS>
cc @jessicalins @bwplotka

Just some website errors

Just some website errors

How can I fix them?


Market Data Subscription: command does not reach MT4 Server, Order does

I'm on Windows 10, connecting via
_zmq = DWX_ZeroMQ_Connector(_verbose=True)
_zmq.DWX_MTX_SUBSCRIBE_MARKETDATA(_symbol='EURUSD')
then waiting via a timer in a thread for print(_zmq._Market_Data_DB) to update, but I get no data.
In the class and method
DWX_ZeroMQ_Connector
def DWX_MTX_SUBSCRIBE_MARKETDATA(self, _symbol, _string_delimiter=';'):
this code never gets called when I subscribe to market data:
self._MarketData_Thread = Thread(target=self._DWX_ZMQ_Poll_Data, args=(_string_delimiter))
self._MarketData_Thread.start()
Also the MT4 server only receives messages (in void InterpretZmqMessage(...)) when I order (which it executes fine), but not when I subscribe to market data, or request all open trades.
I installed a couple different versions and libraries I thought were related, but weren't. So maybe it's .dlls?

I have the same problem.
I see MT4 server is publishing in experts terminal. But I am left with an empty dictionary on the python side.  Also the:
self._MarketData_Thread = Thread(target=self._DWX_ZMQ_Poll_Data, args=(_string_delimiter))
self._MarketData_Thread.start()
is not getting called.

I'm on Windows 10, connecting via
_zmq = DWX_ZeroMQ_Connector(_verbose=True)
_zmq.DWX_MTX_SUBSCRIBE_MARKETDATA(_symbol='EURUSD')
then waiting via a timer in a thread for print(_zmq._Market_Data_DB) to update, but I get no data.
In the class and method
DWX_ZeroMQ_Connector
def DWX_MTX_SUBSCRIBE_MARKETDATA(self, _symbol, _string_delimiter=';'):
this code never gets called when I subscribe to market data:
self._MarketData_Thread = Thread(target=self._DWX_ZMQ_Poll_Data, args=(_string_delimiter))
self._MarketData_Thread.start()
Also the MT4 server only receives messages (in void InterpretZmqMessage(...)) when I order (which it executes fine), but not when I subscribe to market data, or request all open trades.
I installed a couple different versions and libraries I thought were related, but weren't. So maybe it's .dlls?

Hi @aquaandi ,

Could you confirm that the EA is configured to publish market data? -> Publish_MarketData = True in Inputs?

As shown in the code you've pasted, the function DWX_MTX_SUBSCRIBE_MARKETDATA only calls the Thread creation code, if self._MarketData_Thread is None at the present time.

This thread is already initialized by the init() function when you create an instance of DWX_ZeroMQ_Connector, so you don't have to create it again, nor will the code.

The instructions exactly as detailed in README.md should get your environment working, therefore please only install the libraries stated in the README.

We recommend that users install the Anaconda distribution that ships with everything you need to simply download the Python script and get up and running.

I have the same problem.
I see MT4 server is publishing in experts terminal. But I am left with an empty dictionary on the python side. Also the:
self._MarketData_Thread = Thread(target=self._DWX_ZMQ_Poll_Data, args=(_string_delimiter))
self._MarketData_Thread.start()
is not getting called.

Hi @hartungalex24 ,
Please see https://github.com/darwinex/dwx-zeromq-connector/issues/9#issuecomment-492965260 as it relates to your query.

Also @aquaandi and @hartungalex24 ,
Thank you so much for your feedback here 😃
Every issue / bug / report helps us help you, and that helps everyone else who reads these too!
We are going to be recording a Video Tutorial soon on common issues and fixes that we've compiled from GitHub Issues - so stay tuned!

Further to the last message here, we've updated the MQL Expert Advisor to fix a small bug in the code publishing functionality.
Kindly update your forks accordingly - thanks!

@integracore2 Thank you so much for your reply. I have pulled the new source code for MQL4 EA and have made the modifications to the setup and call of the constructor as you mentioned. Please see my netstat report below:

Still not receiving any data on the python side.

Thank you for the reply, for me the updated MT4 EA works. I'm now getting live data in python. I did however also do a reboot, which might have loaded newer .dlls
I don't currently have grep installed, but can if that helps.

I got it working. After a restart on the machine and switching to PyCharm on an anaconda 3.7 ide I was able to get the ports properly setup and listening.

Thank you for all your help and for creating such an amazing tool!

Thank you for the reply, for me the updated MT4 EA works. I'm now getting live data in python. I did however also do a reboot, which might have loaded newer .dlls
I don't currently have grep installed, but can if that helps.

hey dude I have the same problem
may you share your solution?

@hartungalex24 hi, may you share your solution cause my ports are on "stablished" yet


Fixes #2723: Do not fail build if merge is only on trigger phrase & trigger phrase is not specified

This means that the PR build will run & will show success on the github PR page showing the build was successful but not even try to merge. A user should then come along & run the build again by adding a comment with the merge trigger phrase to run the build & merge.

Closing - fixed at jenkins-ci/ghprb.


GPU version train error

Please search your question on previous issues, stackoverflow or other search engines before you open a new one.
For bugs and unexpected issues, please provide following information, so that we could reproduce on our system.
Environment info
Operating System:linux
CPU:
C++/Python/R version:
Error Message:
~/DMTK/LightGBM$ ./lightgbm config=lightgbm_gpu.conf data=higgs.train valid=higgs.test objective=binary metric=auc
[LightGBM] [Info] Finished loading parameters
[LightGBM] [Info] Finished loading data in 12.825387 seconds
[LightGBM] [Info] Number of positive: 5564616, number of negative: 4935384
[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 1535
[LightGBM] [Info] Number of data: 10500000, number of used features: 28
Met Exceptions:
No OpenCL device found
Reproducible examples
Steps to reproduce

export LIBRARY_PATH=/usr/local/cuda/lib64:$LIBRARY_PATH

@caohaox do you have a GPU?
If yes:

Which one?
Do you have the same issue with other datasets?


fix(frontend): support m4a file type

:tada: This PR is included in version 4.1.0-alpha.20 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.5-alpha.2 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:


bump live-common / libcore. internal transactions. import accounts from desktop to dedup/migrate

Rework the import from accounts logic in order to also migrate and dedup the accounts when LIBCORE_EXPERIMENTAL is on and when old ethereumjs account are on mobile.
What is expected here?

Exporting from desktop works with libcore accounts too but if mobile don't enable yet the experimental, it will make the experimental ethereum libcore appearing under unsupported. It should also properly migrate old eth accounts.
there will no longer be dup cases. (fixes LL-1716 LL-1657)
internal transactions

Bug found
Accounts are not migrated but duplicated.
How to reproduce

Disable Experimental Core and Node
Import ETH accountsResults: ETH accounts from ledger.js are present (without related ERC20)
Enable Experimental Core and Node
Import ETH AccountsResults: ETH accounts are present twice (without related ERC20 and with related ERC20 (from libcore))

@Arnaud97234 are you testing with LL that is also on the latest live-common?

dedup support for import accounts with device => https://ledgerhq.atlassian.net/browse/LL-1726
support for seeing the internal ops in operation detail => done

we'll have to fix LL-1726 before going to prod. good for merge for now.


Changes to adapt for horizontal scale...

Hi Jonathan,
Im doing some modifications in the code and in the servers to put loadbalancer, redis and sc-redis to make the sharing between the servers... Do you have some example ready? Im lost about what to do first and how do all...
in my readings I arrived at the conclusion that :
1 - Adapt the broker.js and server.js on my socketcluster chat to connect the brokers on the Redis server...
2 - When the client create a channel the Redis is able to send publish to that channels, ok!
So, Redis have all the channels and i need to send a message from a client on server1 to a client on server2, so i have to change the socket.global.publish to broker.publish?

@waltergms No you shouldn't have to change any of your code.
You can fork/copy the code from this repo: https://github.com/SocketCluster/sc-redis and then modify it to suit your specific needs (if necessary). You can modify it to relay subscriptions/messages to any pub/sub or distributed message queue you like without having to chnge any of your code in SC.
Some people used sc-redis as-is, others used NSQ and ioredis with a Redis cluster.

Really? WOW!
So the only ajusts that i have to do is change the broker.js to attach sc-redis to broker and in server.js specify in the broker options the host and port for the redis?

Another thing i was forgetting...
Should i use more than 1 broker on each socketcluster instance? Today im using 4 workers and 3 brokers on 1 socketcluster instance with no horizontal scale.

@waltergms You can have as many brokers as you like and you shouldn't have to change any code.
SC shards channels evenly between your brokers so it should just work.

Good mornin Jonathan my good friend!
Great news, everything is working almost perfect... Now we have 2 servers running linux and a farm server making the balance between them.. The only issue that are preventing we reach perfectness is a latency on client connection... its getting around 1 minute after load all stuff and connect socket to receive data back from server... Do you have some clue what could be slowing things down?

Man you are the "MAN"
I change the load balance from the company that hold our servers and im using yours LoadBalancer now... the latency has gone, everything is fine now!

@waltergms Nice!! It sounds like there were some issues with your previous loadbalancing solution.
LoadBalancer,js is pretty lightweight (and easy to use), if you ever need something more advanced in the future, feel free to use nginx or HAProxy (just make sure you use a new version which supports WebSockets)... They should work as well.
Or feel free to contribute to LoadBalancer.js too if you want to add more features. That's good too :p

Sounds like this has been resolved.


Get all number strings for numbers tests

The current numbers tests don't get all the possible combinations of numbers out of the text being tested. This results in not detecting numbers which are placed right next to each other. You can test this with:
!!/test-q site=math.stackexchange.com
Some1-888-884-0111<PHONE_NUMBER> +1-972-534-5446<PHONE_NUMBER> 1-628-215-2166<PHONE_NUMBER> 1-844-802-7535<PHONE_NUMBER> body

which will, currently, produce the following output:

Would not be caught as a question on site math.stackexchange.com.
[Note: This example uses math.stackexchange.com, because there's another detection which runs everywhere except on mat.SE which detects any phone number, which would just make this example more complex.]

It should have the following result:

Bad phone number in body, potentially bad keyword in body
Bad phone number in body -<PHONE_NUMBER> found normalized;<PHONE_NUMBER> found normalized;<PHONE_NUMBER>6 found normalized;<PHONE_NUMBER> found normalized;<PHONE_NUMBER>6 found normalized;<PHONE_NUMBER>5 found normalized;<PHONE_NUMBER> found verbatim;<PHONE_NUMBER>1 found normalized
Potentially bad keyword in body -<PHONE_NUMBER> found normalized

This PR:

Changes how the list of potential numbers are generated such that all the combinations of numbers (i.e. all combinations containing sequences of numbers which are split at non-number characters).
Reduces the minimum number of digits to be tested from 9 to 7.
Prevents users from adding patterns to the numbers lists which are impossible to detect, and provides some feedback as to what's needed.
Informs the user that the pattern they are trying to add can not be detected verbatim when that's not possible. Users will need to append -force to add such patterns.
Adds CI testing in test_findspam.py to verify that the code is detecting text which wasn't previously detected.
Adds CI testing to verify the entries on the number watchlist and number blacklist can be detected.
I've previously pushed changes to the number watchlist and number blacklist which normalized the entries, so there isn't, currently, a need for this PR to make changes to those. This was done separately, because it's the area which is most likely to result in merge conflicts and the entries were undetectable, even with the code prior to this PR, as they were.

Testing for this change is around: https://chat.stackexchange.com/transcript/message/59727159#59727159

I'm going to go ahead and merge this based on the testing I performed, which included running it live for several hours and comparing against what SD was reporting/not reporting, seeing that running it live didn't take a noticeable amount of CPU (barely registered), and the facts that it A) fixes an issue preventing some detections, and B) prevents people from adding entries which can't be detected.


CASMCMS-7989 - Fix log rotation.

Summary and Scope
Log rotation was failing due to two problems.
The first is that log rotation needs the target file and the backup directory to be on the same device due to the way it handles the file rotations.  The log aggregation file was set to backup to a different device, so the log rotation call was failing.  When it failed it didn't rotate any of the files despite the error with only one entry in the config file.
The second problem is that with the change to user 'nobody' the process no longer had permission to modify the log rotation configuration file as the default location is owned by root.  I changed this to use a custom configuration file that is owned by the 'nobody' user.  This should be safer as this is the only process that will call logrotate using this configuration file.
Issues and Related PRs

Resolves CASMCMS-7989

Testing
Tested on:

Wasp

Test description:
I installed the new version on wasp using loftsman install and ran the CT tests.  I verified the log rotation is happening correctly - the files are rotated to backup copies and the logs roll through to the new files that are created. I then restored the original version of the service and re-ran the CT tests to verify all is well.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? Y
Were continuous integration tests run? If not, why? Y
Was upgrade tested? If not, why? Y
Was downgrade tested? If not, why? Y
Were new tests (or test issues/Jiras) created for this change? N

Risks and Mitigations
This is a low risk change - the only code changes were to the log rotation functionality and I tested that thoroughly.
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] Testing is appropriate and complete, if applicable

/backport master


Add Wikidata Q-ids and VIAF ids to Agent.csv

Create two new columns;
insert the corresponding value

ideally we would record wikiIDs in one place on the Agent.csv table, so please keep this in mind. It would however require some code changes in here. We can start with Person.csv


AjaxFileUpload won't upload once site is published to IIS7

I'm using VS2017 15.6.2 and AjaxControlToolkit 18.1.0
I've tried using the toolkit via both the NuGet package and via the installer.
I've added an Ajaxfileupload to my page. I've added the handler to system.webserver in my web.config, along with the appropriate config section settings for me to set the temp folder. I've tried this with temp folder overridden and without it set so it takes the default. I've also tried this with the UploadHandlerPath set in the asp and without. All the variants have the same result, which is...
When I run the website in VS2017 for IE11 the file uploader works just fine. When I publish it to our IIS server it wont upload any files, just returns the red error message. On our IIS server the website is running in an app pool under the network service account, and I've granted network service full control of the temp folder, but still the file upload fails on the server.
What am I doing wrong?
It's worth mentioning that I'm setting a list of AllowedFileTypes. When I try and upload a file not in this list the AjaxFileUploader reports that that file is not allowed because of the file type. This happens both when running the code in VS and on the server, so it seems as if the file uploader is at least processing the file in some way, just not uploading it (hence my mentioning the permissions on the temp folder).

Hi @ChrisWh71
Please specify the following:

The error message you see when trying to upload a file
An IIS application root path
A page path where AjaxFileUpload is placed
Screenshots of the Network tab in Chrome Developer tools when you try to upload a file, like this one:

The IIS application root is
http://gbvuts17/SalesReview/
The file upload control is on
http://gbvuts17/SalesReview/SalesDetails.aspx
This is what I see on screen...

This is what I see in the console tab in IE11 F12 developers tools

This is what I see in the network tab in IE11 F12 developers tools (sorry, don't have Chrome)

This is the asp code. As you can see the file upload control is hidden in a collapsible panel extender

And here's a screenshot of the relevant pasrts of my web.config

I don't get any ASP.NET warnings in the event viewer in this instance. Here's the IIS Logs though. You can see I'm getting an 500.21 (Module not recognized) error.
POST /SalesReview/SalesReview/AjaxFileUploadHandler.axd contextKey={DA8BEDC8-B952-4d5d-8CC2-59FE922E2923}&controlID=ctl00_Content_AjaxFileUpload&fileId=EE9AE02C-2074-887E-912B-8A5D817C4A6E&fileName=Beach.jpg&chunked=false&firstChunk=true 80 ... Mozilla/4.0+(compatible;+MSIE+7.0;+Windows+NT+10.0;+WOW64;+Trident/7.0;+.NET4.0C;+.NET4.0E;+.NET+CLR+2.0.50727;+.NET+CLR+3.0.30729;+.NET+CLR+3.5.30729) 500 21 13 2
Here's the response body from the XMLHttpRequest

500 - Internal server error.

Server Error

500 - Internal server error.
There is a problem with the resource you are looking for, and it cannot be displayed.

@ChrisWh71
Based on the error code you provided, I think your application runs in Classic application pool mode instead of Integrated mode.
Try switching it to the Integrated mode.
If it does not help, temporarily set a custom error mode to off in your application Web.config and check the server response again:
<configuration>
  <system.web>
    <customErrors mode="Off"/>
  </system.web>
</configuration>

Our application pool is in Classic mode. Why would that make a difference?

Managed handlers, which AjaxFileUploadHandler belongs to, can not be configured to run in IIS classic mode.
This article explains the difference between Classic and Integrated mode for modules and handlers: IIS 7.0, ASP.NET, pipelines, modules, handlers, and preconditions

@ChrisWh71

When I set IE to break on all errors in the debugger the code stops here...

Would you please provide a sample project that illustrates this issue? I cannot reproduce this behavior locally.

Okay, that's interesting, thanks. At least we know now why it's not working and what to do to get it working. It's up to us now to decide what to do next based on the implications of this information. Thanks for all your help.

I consider the issue resolved, so I'm closing it.
Don't hesitate to comment if you have any info.


[REQUEST] in tweak tool, add changing self timer

It is very annoying that the self timer is max 10sec in the rx100iii.
A setting in the tweak tool to change this would be great!
Either preset to 30, or even better: customizable.

I would apprechiate that, too (for all models)


installation

I installed everything per README and ran it, but met following issue, can you advise ?
Traceback (most recent call last):
  File "/USR/LOCAL/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 151, in _run_module_as_main
    mod_name, loader, code, fname = _get_module_details(mod_name)
  File "/USR/LOCAL/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 109, in _get_module_details
    return _get_module_details(pkg_main_name)
  File "/USR/LOCAL/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 101, in _get_module_details
    loader = get_loader(mod_name)
  File "/USR/LOCAL/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pkgutil.py", line 464, in get_loader
    return find_loader(fullname)
  File "/USR/LOCAL/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pkgutil.py", line 474, in find_loader
    for importer in iter_importers(fullname):
  File "/USR/LOCAL/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pkgutil.py", line 430, in iter_importers
    __import__(pkg)
  File "/USR/LOCAL/lib/python2.7/site-packages/klassify/__init__.py", line 1, in <module>
    from klassify import *
  File "/USR/LOCAL/lib/python2.7/site-packages/klassify/klassify.py", line 9, in <module>
    from backend.handlers import (
  File "/USR/LOCAL/lib/python2.7/site-packages/klassify/backend/handlers.py", line 9, in <module>
    from .tokenizer import tokenize
  File "/USR/LOCAL/lib/python2.7/site-packages/klassify/backend/tokenizer.py", line 4, in <module>
    stop = stopwords.words('english')
  File "/USR/LOCAL/lib/python2.7/site-packages/nltk/corpus/util.py", line 99, in __getattr__
    self.__load()
  File "/USR/LOCAL/lib/python2.7/site-packages/nltk/corpus/util.py", line 64, in __load
    except LookupError: raise e
LookupError:
**********************************************************************
  Resource u'corpora/stopwords' not found.  Please use the NLTK
  Downloader to obtain the resource:  >>> nltk.download()
  Searched in:
    - '/Users/ming/nltk_data'
    - '/usr/share/nltk_data'
    - '/usr/local/share/nltk_data'
    - '/usr/lib/nltk_data'
    - '/usr/local/lib/nltk_data'
**********************************************************************

@metrue you can solve this by running:
python -c 'import nltk; nltk.download("stopwords")'

@Salakar  thank you for your quick response.
I am not python guy, but I think it does not handle the dependencies well here.
I have no idea how should I take care everything like afterward.
➜  klassify git:(master) ✗ python -m klassify
/USR/LOCAL/opt/python/bin/python2.7: No module named http.client; 'klassify' is a package and cannot be directly executed
➜  klassify git:(master) ✗ python --version
Python 2.7.10

Neither am I hah, the above worked for me though, on OSX.
I installed via pip, then ran the stop words installer, after that it works here.
Not sure what the other issue is about to be honest. I tried hah :star:

While in the development directory, you can directly run the klassify instead of module loading method.
This would help to you:
python klassify/klassify.py

A bit offtopic to this issue but, one thing that I'd add to the installation instructions @fatiherikli would be to make sure/install redis, even thought its in the description that it uses redis, it could be more explicit for people that simply jump to the installation instructions :smiley:

@fatiherikli
I did install klassify via pip
 pip install klassify
but
 python -m klassify
met error as above.
@LuRsT
thanks for you information, someone come up with a detail instruction would be great, maybe it's pointless for someone, but useful for some kind of people like me.

I'll send a PR about redis installation :+1:

Same error while installing the following way:
# OS X 10.11.3
brew install python redis
pip install klassify
python -m klassify

/usr/local/opt/python/bin/python2.7: No module named http.client; 'klassify' is a package and cannot be directly executed

What is the output from your pip install klassify? You probably need a sudo pip install, or create a virtualenv like this:
# You may need to install virtual-env-wrapper, maybe brew install virtualenv-wrapper?
mkvirtualenv klassify
pip install klassify
python -m klassify

Can you try python -m klassify.__main__ @LuRsT

Here is the output with your command line :
/usr/local/opt/python/bin/python2.7: No module named http.client
@fatiherikli

This is really interesting. Probably this is an environment problem because We hadn't used any module that named http

@fatiherikli That command doesn't work on my environment (which is correctly configured).
@davidterranova I meant the output from the pip command, can you execute it again?

Did you activate your virtual environment? @davidterranova

I successfully installed virtualenv with pip
However mkvirtualenv is unknown.
Here is the pip output:
pip install klassify
Requirement already satisfied (use --upgrade to upgrade): klassify in /usr/local/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): nltk==3.1 in /usr/local/lib/python2.7/site-packages (from klassify)
Requirement already satisfied (use --upgrade to upgrade): tornado==4.3 in /usr/local/lib/python2.7/site-packages (from klassify)
Requirement already satisfied (use --upgrade to upgrade): tornado-redis==2.4.18 in /usr/local/lib/python2.7/site-packages (from klassify)
Requirement already satisfied (use --upgrade to upgrade): certifi in /usr/local/lib/python2.7/site-packages (from tornado==4.3->klassify)
Requirement already satisfied (use --upgrade to upgrade): backports-abc>=0.4 in /usr/local/lib/python2.7/site-packages (from tornado==4.3->klassify)
Requirement already satisfied (use --upgrade to upgrade): backports.ssl-match-hostname in /usr/local/lib/python2.7/site-packages (from tornado==4.3->klassify)
Requirement already satisfied (use --upgrade to upgrade): singledispatch in /usr/local/lib/python2.7/site-packages (from tornado==4.3->klassify)
Requirement already satisfied (use --upgrade to upgrade): six in /usr/local/lib/python2.7/site-packages (from singledispatch->tornado==4.3->classify)

To clarify: This is my personal computer (OSX) and I'm running this command.
sudo pip install klassify
python -m klassify

I did not get any error and It worked fine.
So you don't need a virtual environment.

Same here @fatiherikli

@davidterranova that pip output looks completely fine to me, you should definitely be able to do
python -m klassify

or
cd /usr/local/lib/python2.7/dist-packages
python -m klassify

@LuRsT From the directory /usr/local/lib/python2.7/site-packages cause dost-packages does not exists
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 151, in _run_module_as_main
    mod_name, loader, code, fname = _get_module_details(mod_name)
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 109, in _get_module_details
    return _get_module_details(pkg_main_name)
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 101, in _get_module_details
    loader = get_loader(mod_name)
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pkgutil.py", line 464, in get_loader
    return find_loader(fullname)
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pkgutil.py", line 474, in find_loader
    for importer in iter_importers(fullname):
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pkgutil.py", line 430, in iter_importers
    __import__(pkg)
  File "klassify/__init__.py", line 1, in <module>
    from klassify import *
  File "klassify/klassify.py", line 9, in <module>
    from backend.handlers import (
  File "klassify/backend/handlers.py", line 9, in <module>
    from .tokenizer import tokenize
  File "klassify/backend/tokenizer.py", line 4, in <module>
    stop = stopwords.words('english')
  File "nltk/corpus/util.py", line 99, in __getattr__
    self.__load()
  File "nltk/corpus/util.py", line 64, in __load
    except LookupError: raise e
LookupError:
**********************************************************************
  Resource u'corpora/stopwords' not found.  Please use the NLTK
  Downloader to obtain the resource:  >>> nltk.download()
  Searched in:
    - '/Users/davidterranova/nltk_data'
    - '/usr/share/nltk_data'
    - '/usr/local/share/nltk_data'
    - '/usr/lib/nltk_data'
    - '/usr/local/lib/nltk_data'
**********************************************************************

@davidterranova In that case, try running:
python -c 'import nltk; nltk.download("stopwords")'

@LuRsT Working ! Thanks!

All the pull requests about this issue have been merged. So I'm closing this issue now.
Thanks everyone!


[BUG] [Fabric Sync Example App] An error occurred during fabricsynchronization add-bridge command.

Reproduction steps
Reference Guide : https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/fabric_synchronization_guide.md

Fabric Sync Setup
Enable Fabric Auto Sync:
In Fabric-Sync console:
fabricsync enable-auto-sync 1
Pair the Fabric-Source bridge to Fabric-Sync with node ID 1:
fabricsync add-bridge 1 <fabric-sink-ip>

During the fabircsync add-bridge step, an error is occured as below.
******* run_fabric_sink_sh console *******
...
ERR  Failed to connect to <IP_ADDRESS>:33002: Connection refused
>>> fabricsync enable-auto-sync 1
>>> Auto Fabric Sync is enabled.
ERR  Failed to connect to <IP_ADDRESS>:33002: Connection refused
ERR  Failed to connect to <IP_ADDRESS>:33002: Connection refused
ERR  Failed to connect to <IP_ADDRESS>:33002: Connection refused
fabricsync add-bERR  Failed to connect to <IP_ADDRESS>:33002: Connection refused
ridge 1 192.168ERR  Failed to connect to <IP_ADDRESS>:33002: Connection refused
.1.41
>>> ./run_fabric_sink.sh: line 78: 30156 Aborted                 (core dumped) "$FABRIC_ADMIN_PATH" --log-file-path "$FABRIC_ADMIN_LOG"

******* /tmp/fabric_admin.log *******
[509967.000494] CHIP:DIS: mDNS service published: _matterd._udp
[509967.000528] CHIP:DL: Long dispatch time: 197 ms, for event type 2
[509967.000529] CHIP:-: Failed to connect to Fabric-Bridge, retry in 5 seconds....
[509972.000534] CHIP:-: Failed to connect to Fabric-Bridge, retry in 5 seconds....
[509977.000541] CHIP:-: Failed to connect to Fabric-Bridge, retry in 5 seconds....
[509982.000546] CHIP:-: Failed to connect to Fabric-Bridge, retry in 5 seconds....
[509987.000552] CHIP:-: Failed to connect to Fabric-Bridge, retry in 5 seconds....
[509989.000367] CHIP:-: Command: fabricsync add-bridge 1 <IP_ADDRESS>
[509989.000369] CHIP:-: PushCommand: pairing already-discovered 1 20202021 <IP_ADDRESS> 5540
[509990.000368] CHIP:-: Command: pairing already-discovered 1 20202021 <IP_ADDRESS> 5540
[509990.000370] CHIP:SPT: VerifyOrDie failure at src/lib/support/SetupDiscriminator.h:52: discriminator == (discriminator & kLongMask)

It seems that the error occurred because the "fabircsync add-bridge" command did not pass a "discriminator".
https://github.com/project-chip/connectedhomeip/blob/3bc5667b3a9f2cabcaec1aaf49d8c0aec0583d11/examples/fabric-admin/commands/pairing/PairingCommand.cpp#L224
If I remove ".SetDiscriminator(mDiscriminator)" from the code, the "fabircsync add-bridge" command runs successfully. However, I'm not sure if this fix matches the intent of the code as written.
Bug prevalence
Every Time
GitHub hash of the SDK that was being used
3bc5667b3a9f2cabcaec1aaf49d8c0aec0583d11
Platform
raspi
Platform Version(s)
ubuntu 22.04
Anything else?
No response

Not able to reproduce this issue, https://github.com/project-chip/connectedhomeip/pull/34882 might fix the problem

Add bridge from run_fabric_sink.sh (which only build fabri-admin at sink side, so need to disable RPC)
./scripts/examples/gn_build_example.sh examples/fabric-admin out/debug/standalone
./scripts/examples/gn_build_example.sh examples/fabric-bridge-app/linux out/debug/standalone chip_config_network_layer_ble=false 'import("//with_pw_rpc.gni")'
./examples/fabric-admin/scripts/run_fabric_sink.sh
./examples/fabric-admin/scripts/run_fabric_source.sh

>>> fabricsync add-bridge 1 <IP_ADDRESS>
New device with Node ID: 0x1 has been successfully added.

Add bridge from run_fabric_source.sh
./scripts/examples/gn_build_example.sh examples/fabric-admin out/debug/standalone 'import("//with_pw_rpc.gni")'
./scripts/examples/gn_build_example.sh examples/fabric-bridge-app/linux out/debug/standalone chip_config_network_layer_ble=false 'import("//with_pw_rpc.gni")'
./examples/fabric-admin/scripts/run_fabric_source.sh
./examples/fabric-admin/scripts/run_fabric_source.sh

>>> fabricsync add-bridge 1 <IP_ADDRESS>
New device with Node ID: 0x1 has been successfully added.

This setup only support add-bridge, if you try to sync device with this setup, it will cuase cyclical syncing


Updated language files and sound null safety

Contains updated language files by @passsy, sound null-safety, cleanup of pubspec as well as extended gitignore.

Are you going to publish it to pub.dev soon?
Trying to get rid of local code.


Removing KryoReflectionFactorySupport related code

Kryo version up to 3.0.2
remove kryo-serializers
use Kryo object pool.

This will be done by #25 .


Investigate means of checking whether file is recent or downloaded

PR #76 introduces Decorator, which checks to see whether a file a) exists and b) has been downloaded within a user-specified timeframe; if either condition is not met, the file is then downloaded.
It might be worth investigating NCBI's own version control system and augmenting Decorator's functionality with a means of checking to see whether a file's corresponding database entry has actually had its contents changed.
This would therefore mean a file is only re-downloaded if any changes have actually happened to it, ideally. A (perhaps extended) timeframe check could still remain just in case.

Okay, so I've made a bit of headway here via Biopython.
Let's say our accession number is NC_015138 - we can fetch the GB record for this with:
from Bio import Entrez

acc = 'NC_015138'

handle = Entrez.efetch(db = 'nucleotide', rettype = 'gb', retmode = 'xml', id = acc)
record = Entrez.read(handle)

After the GenBank entry has been saved to record, we can access the 'date updated' field with
record[0]['GBSeq_update-date']

which in this case returns '07-APR-2017'. (The indexing is needed because while the GB entry is converted to a dictionary this way, it's the first element of a single-element list for some reason)
This could be a starting point for instituting an internal check, which could examine whether a given database entry has been updated on NCBI's end and thereby determine whether it needs to be re-downloaded. Thoughts?


Question: Is this for Steem or Hive blockchain?

..because you have a hive category in frontmatter for posts, not steem.

This is for the Steem blockchain.


Elasticsearch mapping

First off thank you for building this. I use it daily for typescript, mst, react, sql... It's a huge time saver.
Now! It would be awesome if it also supported elasticsearch mappings, which I think can be done seeing as how they're quite simple generally.

It's more like converting a JSON to JSON schema. That's not going to be straightforward. I will see what's possible. Meanwhile, PR is welcome.

I don't know how the tool works but I assume that at the center of it there's something that extracts info from the json, and that the generators all interpret that differently, no? So wouldn't this be a matter of writing that back into json?
This is just me being curious by the way 😄

You can get an idea about that here


QR decomp for OLS

Super low prio, but we can use QR decomposition as a more numerically stable way to do regression and get SEs.
    Q, R = QR(X, 'reduced')
    Qty = Q.T @ y
    beta = jsp.linalg.solve_triangular(R, Qty)
    df = Q.shape[0] - Q.shape[1]
    residuals = y - Q @ Qty
    sigma = jnp.sqrt(jnp.sum(residuals ** 2, axis=0) / df)
    se = sigma * jnp.sqrt(jnp.diag(jsp.linalg.cho_solve((R, False), jnp.eye(R.shape[0])))

Finished! I tested the new way and it gave us the same results as the previous function


Allow using Prefetch objects instead of strings

Codecov Report
Patch coverage: 98.85% and project coverage change: -0.10 :warning:

Comparison is base (2979579) 99.39% compared to head (b9b0d26) 99.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   99.39%   99.29%   -0.10%
==========================================
  Files           9        9
  Lines         494      567      +73
==========================================
+ Hits          491      563      +72
- Misses          3        4       +1

Impacted Files
Coverage Δ

serializer_prefetch/base.py
97.87% <95.65%> (-0.41%)
:arrow_down:

tests/models.py
100.00% <100.00%> (ø)

tests/test_serializers.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Applying a command by default

I have to type in cmd scrcpy -m 1024 in order to access my phone but i want to open my phone wirelessly is there anyway to apply the "scrcpy -m 1024" by default instead of the "scrcpy" command?

Write your full command in a script myscrcpy.bat (on Windows I guess): https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#command-line-on-windows

Write your full command in a script myscrcpy.bat (on Windows I guess): https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#command-line-on-windows

wow that was easy thanks

Write your full command in a script myscrcpy.bat (on Windows I guess): https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#command-line-on-windows

also does the wireless thing will work this way? i already made the file and all the commands are complete and connected but when i tried to test it out its not working i wonder if i need to put some of the command more into the bat file i created? :/

What's the output in the console when it does not work?

What's the output in the console when it does not work?

when i plug it ou it now says Error: "adb push" returned with value 1.
Even if i already complete all the steps it still needs the usb debugging turned on :3

it still needs the usb debugging turned on

Yes, adb only works if USB debugging is enabled.

it still needs the usb debugging turned on

Yes, adb only works if USB debugging is enabled.

but i already done the processing to make it wireless tho

Once connected wirelessly, the device does not need to be plugged in via USB (but USB debugging must still be enabled).
What is the result of adb devices? https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#adb-issues


fix(app): copy QA from August 17

Overview

This PR contains a number of localization changes (and corresponding tests) found in a copy QA session done on Flex hardware on August 17. The goal is to have in-app copy match designs in Figma as exactly as possible (without significant refactoring for very small gains, like capitalization only).
The changes here are strings that I could easily find and was reasonably confident only applied to the screens we were looking at on-device. Some more complicated changes that may require refactoring will be ticketed separately.
Partially addresses RUXD-1061.
Test Plan

Check that these strings render properly in the touchscreen app.
We've already verified the new text against what's in Figma.
Changelog

string changes across about a dozen localization and organism files
copy-paste text to corresponding tests

Review requests

Verify the new text appears in the appropriate places in the touchscreen app.
Make sure we haven't polluted the desktop app with text that only applies to touchscreen use.
Make sure we haven't broken anything else across either app due to highly shared strings.

Risk assessment

Low. This barely touches code, but there's always the possibility of breaking an interface element or otherwise worsening the user experience.

@ecormany
Shlok told me that we decided to allow users to use more than 17 characters for a robot name.
Have you heard that?


The login credentials for 'apple id' seem to be wrong

Good day all,
I'm struggling with this issue it seems that the credentials manager has some issues because some passwords doesn't want to go through.
I've removed all of my deliver. passwords in the keychain and it's still giving me an issue with certain passwords.
It's almost as if certain characters in the password messes around with the credentials manager.
If someone has some information as to why some passwords keeps on failing through the use of fastlane that would be great.
I am able to login to the account manually through the browser with the same credentials that I provide fastlane with.
See stack trace below:
/Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.0/lib/spaceship/client.rb:63:in `login': [!] Invalid User Credentials (Spaceship::Client::InvalidUserCredentialsError)
	from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.0/lib/spaceship/portal/spaceship.rb:22:in `login'
	from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.0/lib/spaceship/portal/spaceship.rb:77:in `login'
	from /Library/Ruby/Gems/2.0.0/gems/cert-1.3.0/lib/cert/runner.rb:21:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/cert-1.3.0/lib/cert/runner.rb:6:in `launch'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/actions/cert.rb:19:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:143:in `block (2 levels) in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:129:in `block in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:128:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:128:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/fast_file.rb:149:in `method_missing'
	from Fastfile:23:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:110:in `try_switch_to_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/fast_file.rb:141:in `rescue in method_missing'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/fast_file.rb:136:in `method_missing'
	from Fastfile:93:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:52:in `block in execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:46:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/runner.rb:46:in `execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/lib/fastlane/command_line_handler.rb:30:in `handle'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/bin/fastlane:38:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.36.6/lib/fastlane_core/ui/fastlane_runner.rb:23:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/bin/fastlane:150:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.61.0/bin/fastlane:156:in `<top (required)>'
	from /usr/bin/fastlane:23:in `load'
	from /usr/bin/fastlane:23:in `<main>'

Regards

Can you give the latest version a whirl?

Hi @vpolouchkine,
Thanks will give v1.63 a go and let everyone know if the issue has been resolved. :smile:

@Darkreaper101 @vpolouchkine if your problem isn't fixed, note that the security gem has a known issue with non ASCII passwords. https://github.com/mattt/security/pull/3 Could it be that ?

@Darkreaper101 Are you still running into this?

@vpolouchkine @lacostej It seems the issue has been resolved as far as I can tell, haven't used the specified account in quite a while, but if this issue does come up again I'll open up the issue.

@Darkreaper101 Awesome! Glad to hear you are up and running. Please let us know if you see this issue again! Hope you have a great week :+1:


See Juicebox from any account

I'd like to be able to view Juicebox projects as any address

Can you clarify this issue, I'm not sure what you mean?  When I connect via different addresses in MM, I can see all projects on the juicebox.money site.

Yeah, I mean any other public address. Without having to connect. I can just punch in your address and see the project page from your perspective.

This would be really useful for TileDAO, @peripheralist's project, right now. The DAO has been investing in Juicebox, and gets JBX in return. Itd be great for anyone to view JuiceboxDAO from the perspective of the TileDAO contract to see their balance.

Can't a user achieve this with something like https://impersonator.xyz now?

@mejango close?

clothes


Why do authentication(r?) and baseSeverity have a '>' suffix in the json velocity template?

The fields/keys authenticationr and baseSeverity (also located at line 220 and line 238 in jsonReport.vsl ) end with a '>'.  At a glance it looks like a possible spelling and xml-copy-paste error. It also makes auto-json serialization for certain things like protobufs not doable. Are these fields intentionally named this way?

Thanks for letting us know!  Simple copy/paste error.


Wallet handling

From the RFP , looks like this relates to wallet higher level operations. But i am unsure if they were finally planed for this RFP.
What do you think @MeerKatDev ?


Compilation for Kotlin does not work if kotlinc is absent in PATH

Describe the bug
I cannot generate unit tests with LLM for Kotlin if I do not set kotlinc in PATH. The compiler fails with:
'bash: kotlinc: command not found'

This is because, unlike for Java, for Kotlin we do not search for compiler installation but rely on its presence in PATH:
// in KotlinTestCompiler.kt

val errorMsg = CommandLineRunner.run(
            arrayListOf(
                "kotlinc", // <- HERE! but in `JavaTestCompiler` we search for the javac
                "-cp",
                classPaths,
                path,
            ),
        )

The plugin does not notify that compiler was not found and misleadingly treat it as a compilation error:

To Reproduce
Steps to reproduce the behavior:

Remove the kotlinc from your PATH.
Try to generate tests with LLM.
See the compilation error being "kotlinc not found".

Expected behavior
TestSpark should search for kotlinc as it does for Java.

Plan to solve the issue:

Try to find a kotlin compiler on demand (org.jetbrains.kotlin.idea.compiler.configuration .KotlinPluginLayout#kotlinc may be handy); see this thread.
Implement an input field in settings that accepts a filepath to the kotlinc; use it if present, otherwise try to execute kotlinc -version (assuming that kotlinc is in PATH); if you receive a version then execute it, otherwise fail with a balloon error mentioning that no kotlin compiler found and user you download an official compiler and set it in PATH.

See this slack message.


[[DOCS]] Fix incorrect information about scopes in JavaScript

Comment stated that JavaScript has only two real scopes.
This is incorrect as identifiers declared with let and const do have
block scope.
Maybe a little nitpicky but I think that as long as the information is there, it should be correct. It's also wrong on http://jshint.com/docs/options/

Coverage remained the same at 98.744% when pulling c43c26f2f1e2be606a05496acea862b5795daeed on kpiotr:scope-docs into c7c5c42885aa618e384de3f6589793fd419de7c1 on jshint:master.

Not nitpicky at all; your change is correct and helpful.
I've removed the changes to the files in dist because we generate those files for each release.  And as for the website; that content is derived from the source code, so your new text will be pushed there when we release the next version of JSHint.
Merged to master at commit c4370d9ee8b5367cfc0bf391618e7029852c78b8. Thanks for taking the time to fix this!


Gh 1018: Refactor fishbowl to use jinja2

Related Issue

Resolve #1018

This diff shows a lot of changes to the generated files simply because they are unsorted each time they are generated (due to an issue with the api: https://github.com/gchq/Gaffer/issues/2775)
I have fixed this issue in this PR in fishbowl by sorting the results before generation:
https://github.com/gchq/gaffer-tools/blob/d3f6f7a3ac8b208a08a491bbc6017ecfe462cee4/python-shell/src/fishbowl/fishbowl.py#L113
For an actual diff of how they have changed, see https://github.com/gchq/gaffer-tools/pull/1034/commits/d3f6f7a3ac8b208a08a491bbc6017ecfe462cee4

Codecov Report

Merging #1034 (d3f6f7a) into v2-alpha (f640ae3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head d3f6f7a differs from pull request most recent head 4d4afb1. Consider uploading reports for the commit 4d4afb1 to get more accurate results

@@             Coverage Diff             @@
##             v2-alpha    #1034   +/-   ##
===========================================
  Coverage       45.15%   45.15%
  Complexity        101      101
===========================================
  Files              25       25
  Lines             897      897
  Branches           73       73
===========================================
  Hits              405      405
  Misses            462      462
  Partials           30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af6914...4d4afb1. Read the comment docs.

This diff shows a lot of changes to the generated files simply because they are unsorted each time they are generated (due to an issue with the api: gchq/Gaffer#2775) I have fixed this issue in this PR in fishbowl by sorting the results before generation

Does this mean that issue in Gaffer is no longer required because the issue can be resolved by sorting in the rest-api instead of in Gaffer? Looks like that issue can be closed once this PR is merged.

So it could be closed because, at least for this use case, that is solved. However, I still think it would be nice if the api itself was consistent and didn't need to be sorted client side every time


When the hive table storage type is orc, data sinks to the hive, and the task fails to be executed

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
When the hive table storage type is orc, data sinks to the hive and the FieldMapper transform is configured. If certain fields in the hive table are not mapped, tasks fail to be executed
SeaTunnel Version
2.3.4
SeaTunnel Config
{
    "env": {
        "parallelism": 3,
        "job.mode": "BATCH",
        "checkpoint.interval": 30000,
        "job.name": "seatunnel_1712823979630"
    },
    "source": [
        {
            "plugin_name": "Jdbc",
            "result_table_name": "table_source",
            "user": "postgres",
            "password": "C3kk4v5_b4f2Jr",
            "driver": "org.postgresql.Driver",
            "url": "jdbc:postgresql://<IP_ADDRESS>:5434/gis",
            "query": "select event_id,event_type,event_radius,event_source,start_time,end_time,priority,latitude,longitude,elevation,node_ids,create_time,update_time from ghcloud.gh_traffic_event_info"
        }
    ],
    "transform": [
        {
            "plugin_name": "FieldMapper",
            "source_table_name": "table_source",
            "result_table_name": "table_source_FieldMapper",
            "field_mapper": {
                "event_id": "event_id",
                "event_type": "event_type",
                "event_radius": "event_radius",
                "event_source": "event_source",
                "start_time": "start_time",
                "end_time": "end_time",
                "priority": "priority",
                "latitude": "latitude",
                "longitude": "longitude",
                "elevation": "elevation",
                "node_ids": "node_ids",
                "create_time": "create_time",
                "update_time": "update_time"
            }
        }
    ],
    "sink": [
        {
            "plugin_name": "Hive",
            "source_table_name": "table_source_FieldMapper",
            "table_name": "gh_cloud_data_model.dwd_pub_traffic_event",
            "metastore_uri": "thrift://cloudera-hadoop-61:9083"
        }
    ]
}

Running Command
Executed by dolphin scheduler

Error Exception
SHUTDOWN
	2024-04-12 11:31:30,246 INFO  [s.c.s.s.c.ClientExecuteCommand] [main] - Closed SeaTunnel client......
	2024-04-12 11:31:30,246 INFO  [s.c.s.s.c.ClientExecuteCommand] [main] - Closed metrics executor service ......
	2024-04-12 11:31:30,246 ERROR [o.a.s.c.s.SeaTunnel           ] [main] -

	===============================================================================

	2024-04-12 11:31:30,246 ERROR [o.a.s.c.s.SeaTunnel           ] [main] - Fatal Error,

	2024-04-12 11:31:30,246 ERROR [o.a.s.c.s.SeaTunnel           ] [main] - Please submit bug report in https://github.com/apache/seatunnel/issues

	2024-04-12 11:31:30,246 ERROR [o.a.s.c.s.SeaTunnel           ] [main] - Reason:SeaTunnel job executed failed

	2024-04-12 11:31:30,248 ERROR [o.a.s.c.s.SeaTunnel           ] [main] - Exception StackTrace:org.apache.seatunnel.core.starter.exception.CommandExecuteException: SeaTunnel job executed failed
		at org.apache.seatunnel.core.starter.seatunnel.command.ClientExecuteCommand.execute(ClientExecuteCommand.java:202)
		at org.apache.seatunnel.core.starter.SeaTunnel.run(SeaTunnel.java:40)
		at org.apache.seatunnel.core.starter.seatunnel.SeaTunnelClient.main(SeaTunnelClient.java:34)
	Caused by: org.apache.seatunnel.engine.common.exception.SeaTunnelEngineException: java.lang.RuntimeException: java.lang.NullPointerException
		at org.apache.seatunnel.engine.server.task.flow.SinkFlowLifeCycle.received(SinkFlowLifeCycle.java:257)
		at org.apache.seatunnel.engine.server.task.flow.SinkFlowLifeCycle.received(SinkFlowLifeCycle.java:66)
		at org.apache.seatunnel.engine.server.task.SeaTunnelTransformCollector.collect(SeaTunnelTransformCollector.java:39)
		at org.apache.seatunnel.engine.server.task.SeaTunnelTransformCollector.collect(SeaTunnelTransformCollector.java:27)
		at org.apache.seatunnel.engine.server.task.group.queue.IntermediateBlockingQueue.handleRecord(IntermediateBlockingQueue.java:75)
		at org.apache.seatunnel.engine.server.task.group.queue.IntermediateBlockingQueue.collect(IntermediateBlockingQueue.java:50)
		at org.apache.seatunnel.engine.server.task.flow.IntermediateQueueFlowLifeCycle.collect(IntermediateQueueFlowLifeCycle.java:51)
		at org.apache.seatunnel.engine.server.task.TransformSeaTunnelTask.collect(TransformSeaTunnelTask.java:73)
		at org.apache.seatunnel.engine.server.task.SeaTunnelTask.stateProcess(SeaTunnelTask.java:168)
		at org.apache.seatunnel.engine.server.task.TransformSeaTunnelTask.call(TransformSeaTunnelTask.java:78)
		at org.apache.seatunnel.engine.server.TaskExecutionService$BlockingWorker.run(TaskExecutionService.java:648)
		at org.apache.seatunnel.engine.server.TaskExecutionService$NamedTaskWrapper.run(TaskExecutionService.java:949)
		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
		at java.util.concurrent.FutureTask.run(FutureTask.java:266)
		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
		at java.lang.Thread.run(Thread.java:748)
	Caused by: java.lang.NullPointerException
		at org.apache.seatunnel.connectors.seatunnel.file.sink.writer.OrcWriteStrategy.buildSchemaWithRowType(OrcWriteStrategy.java:196)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.writer.OrcWriteStrategy.getOrCreateWriter(OrcWriteStrategy.java:116)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.writer.OrcWriteStrategy.write(OrcWriteStrategy.java:75)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.BaseFileSinkWriter.write(BaseFileSinkWriter.java:134)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.BaseFileSinkWriter.write(BaseFileSinkWriter.java:46)
		at org.apache.seatunnel.engine.server.task.flow.SinkFlowLifeCycle.received(SinkFlowLifeCycle.java:247)
		... 16 more

		at org.apache.seatunnel.core.starter.seatunnel.command.ClientExecuteCommand.execute(ClientExecuteCommand.java:194)
		... 2 more

	2024-04-12 11:31:30,248 ERROR [o.a.s.c.s.SeaTunnel           ] [main] -
	===============================================================================

	Exception in thread "main" org.apache.seatunnel.core.starter.exception.CommandExecuteException: SeaTunnel job executed failed
		at org.apache.seatunnel.core.starter.seatunnel.command.ClientExecuteCommand.execute(ClientExecuteCommand.java:202)
		at org.apache.seatunnel.core.starter.SeaTunnel.run(SeaTunnel.java:40)
		at org.apache.seatunnel.core.starter.seatunnel.SeaTunnelClient.main(SeaTunnelClient.java:34)
	Caused by: org.apache.seatunnel.engine.common.exception.SeaTunnelEngineException: java.lang.RuntimeException: java.lang.NullPointerException
		at org.apache.seatunnel.engine.server.task.flow.SinkFlowLifeCycle.received(SinkFlowLifeCycle.java:257)
		at org.apache.seatunnel.engine.server.task.flow.SinkFlowLifeCycle.received(SinkFlowLifeCycle.java:66)
		at org.apache.seatunnel.engine.server.task.SeaTunnelTransformCollector.collect(SeaTunnelTransformCollector.java:39)
		at org.apache.seatunnel.engine.server.task.SeaTunnelTransformCollector.collect(SeaTunnelTransformCollector.java:27)
		at org.apache.seatunnel.engine.server.task.group.queue.IntermediateBlockingQueue.handleRecord(IntermediateBlockingQueue.java:75)
		at org.apache.seatunnel.engine.server.task.group.queue.IntermediateBlockingQueue.collect(IntermediateBlockingQueue.java:50)
		at org.apache.seatunnel.engine.server.task.flow.IntermediateQueueFlowLifeCycle.collect(IntermediateQueueFlowLifeCycle.java:51)
		at org.apache.seatunnel.engine.server.task.TransformSeaTunnelTask.collect(TransformSeaTunnelTask.java:73)
		at org.apache.seatunnel.engine.server.task.SeaTunnelTask.stateProcess(SeaTunnelTask.java:168)
		at org.apache.seatunnel.engine.server.task.TransformSeaTunnelTask.call(TransformSeaTunnelTask.java:78)
		at org.apache.seatunnel.engine.server.TaskExecutionService$BlockingWorker.run(TaskExecutionService.java:648)
		at org.apache.seatunnel.engine.server.TaskExecutionService$NamedTaskWrapper.run(TaskExecutionService.java:949)
		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
		at java.util.concurrent.FutureTask.run(FutureTask.java:266)
		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
		at java.lang.Thread.run(Thread.java:748)
	Caused by: java.lang.NullPointerException
		at org.apache.seatunnel.connectors.seatunnel.file.sink.writer.OrcWriteStrategy.buildSchemaWithRowType(OrcWriteStrategy.java:196)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.writer.OrcWriteStrategy.getOrCreateWriter(OrcWriteStrategy.java:116)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.writer.OrcWriteStrategy.write(OrcWriteStrategy.java:75)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.BaseFileSinkWriter.write(BaseFileSinkWriter.java:134)
		at org.apache.seatunnel.connectors.seatunnel.file.sink.BaseFileSinkWriter.write(BaseFileSinkWriter.java:46)
		at org.apache.seatunnel.engine.server.task.flow.SinkFlowLifeCycle.received(SinkFlowLifeCycle.java:247)
		... 16 more

		at org.apache.seatunnel.core.starter.seatunnel.command.ClientExecuteCommand.execute(ClientExecuteCommand.java:194)
		... 2 more
	2024-04-12 11:31:30,249 INFO  [s.c.s.s.c.ClientExecuteCommand] [ForkJoinPool.commonPool-worker-2] - run shutdown hook because get close signal
[INFO] 2024-04-12 11:31:30.453 +0800 - FINALIZE_SESSION

Zeta or Flink or Spark Version
No response
Java or Scala Version
No response
Screenshots
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please paste in the ddl statement of the [gh_cloud_data_model.dwd_pub_traffic_event table]. It is suspected that the name of the mapped field is inconsistent with that of the destination table, which causes the null pointer problem

You should pay attention to two things: one is that all fields in the [hive] table should have corresponding fields from upstream. If there are no extra fields upstream, you can pass the empty string, that is, [''], as an empty field, but you cannot specify [null] as an empty field, and the field mapping name should be the same as the field name in the table.


ipam/metrics: mention interfaces instead of ENI

As suggested in https://github.com/cilium/cilium/pull/10089#discussion_r386328878

This change is

test-me-please

Coverage decreased (-0.02%) to 45.697% when pulling f15532d1ba817c1883b43c2c8962f24cff393b58 on pr/tklauser/ipam-no-eni-specific into b68af484d43ef536b292d0724043ad284ad2cbb5 on master.

the tests failed with known flake


Exceptions on sniffing error

After 2d82b1b1739ba92f4de6c3f2eb88bcac9563bc70 a next call to ElasticSearch server may raise an error if the last sniffing was failed.
As I see elasticsearch-py suppresses exceptions like ConnectionError but elasticsearch-py-async raises all errors (connections, timeouts, cancellations etc).
elasticsearch-py raises TransportError only as I see.
Another problem is when the library reports about problems: elasticsearch-py raises immediatelly but elasticsearch-py-async will report about problem in sniffing in the past.
I did not dig into the code too deep but maybe moving sniffing from synchronous get_connection into async perform_request makes sense?

Thanks for raising this issue. You are absolutely right that this is inconsistent.

elasticsearch-py raises immediatelly but elasticsearch-py-async will report about problem in sniffing in the past.

This feels ok to me since with async we gain the option of sniffing in the background (which I believe is better than what elasticsearch-py does now). Then we need to raise the error somewhere (unless we suppress it and just log it, also an option).
I think the proper solution is to change the sniffing logic wait for first successful request to return, ignoring the rest (just relying on the standard logging mechanism for discovery). Right now the _get_sniff_data method is waiting for first task to finish (via asyncio.wait(..., return_when=asyncio.FIRST_COMPLETED)) which will most likely be the failed request. That way the error will be very unlikely - essentially only when all the requests fail.
Another option would be to document the invoke_sniffing method and encourage people to run it on their own (using a timer for example) if they really care about how this is done (waiting for the future right away, letting it run on background, ...).
What do you think?

... moving sniffing from synchronous get_connection into async perform_request makes sense?

I am afraid I do not understand this, can you elaborate a little bit?

I changed a bunch of things here - in 3e0aa59 I made the behavior consistent with elasticsearch-py: trying all the connections, only ignoring known errors (Connection and Serialization).
In 568875e I also added an option to suppress sniffing raising any errors (for people who view it as an optional background process).
The only difference now is that elasticsearch-py raises issues with sniffing immediately while the async version will do it at next request. This I don't know how (or indeed if) can be fixed since the sniffing is running in the background essentially.
Hope this helps


New viral proteome nodes not normalizing

the following nodes are not normalizing and are found in the latest viral proteome data:
GO:0106310
GO:0106311
GO:0106306
GO:0106307
GO:0106274
GO:0106275

Is this still an issue?  I think it is fixed now.


COLP Housenums have invalid values

In version 23v2, per @croswell81:
"HNUM was normalized from "=-T" to "T" - Not sure if this should just be blank?"
An Example

UID
BBL
ObjectID

115cf001a411021a802468dab4924f3b
4161000175
1121

It's not urgent, and can be addressed prior to the next COLP release
cc @AmandaDoyle

More context from @AmandaDoyle in Teams Chat:
For the parcel names - the corrections process certainly got confusing when developing it so here is my recap
Based on this script, modifications happen and then corrections are applied
https://github.com/NYCPlanning/data-engineering/blob/2ec2f90818924b11111c3a004f1b5aedd3a0b70f/products/colp/bash/02_build.sh
This script makes the changes for the parcel names
https://github.com/NYCPlanning/data-engineering/blob/2ec2f90818924b11111c3a004f1b5aedd3a0b70f/products/colp/sql/clean_parcelname.sql#L61C35-L61C35
And in short it's just a replace statement, so for example if INDUST\sPARK, IND.\sPARK  or INDUST''L PARK are in a parcel name it's replaced with INDUSTRIAL PARK
In the spreadsheet ipis_modified_names_REVIEWED.xlsx I added some notes about the ones with a ? as to what the name should be or if the name should be left as is.  If anyone needs help adding to modification.csv give me a shout
[ipis_modified_names_REVIEWED.xlsx] (https://nyco365.sharepoint.com/sites/NYCPLANNING/itd/edm/Shared Documents/Metadata for review/ipis_modified_names_REVIEWED.xlsx)<https://teams.microsoft.com/l/message/19:a1830760d5ee4266a60820daa29886ec@thread.skype/1701971612347?tenantId=32f56fc7-5f81-4e22-a95b-15da66513bef&groupId=ce454ad8-a936-456b-8926-c9157c03db79&parentMessageId=1701903870207&teamName=NYC Department of City Planning&channelName=Data Engineering&createdTime=1701971612347&allowXTenantAccess=false>


merge from Kronos-Integration/service-uti

.gitignore

chore: add  ()

.npmignore

chore: add  ()

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   96.22%   96.22%
=======================================
  Files           2        2
  Lines          53       53
  Branches        2        2
=======================================
  Hits           51       51
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b1818...7ed0204. Read the comment docs.


i18n(ja): Update heroku.mdx

Description (required)

Update heroku.mdx.

diff

https://github.com/withastro/docs/pull/5904
https://github.com/withastro/docs/pull/5954

Related issues & labels (optional)

Closes #
Suggested label:

!coauthor


SA1513 Fired when old StyleCop did not complain

I like that in the old StyleCop (4.7) you could put //// comments anywhere in the code and no warning would be raised. With StyleCop.Analyzers rc3 I get a SA1513 with the following code
            public int Do(int i)
            {
                if (i > 2)
                {
                    return 1;
                }
                //// else if (i == 2)
                //// {
                ////     return 2;
                //// }

                return 0;
            }

whereas I did not get any warning from StyleCop 4.7. I preferred the old way.

I think it makes sense to update our code to work the same way as StyleCop Classic.

Grabbing this


#cg-supportstream (🗣) - stream of activity on Zendesk tickets

@wz-gsa I am having trouble finding this channel!

added you and joe


Recieving TimeoutExceptions when calling URLs with DNS names

Description

I have resurrected development on a personal project after a short hiatus. After bringing it back online, I've been facing strange timeout issues. Upon closer investigation I was able to narrow it down to Timeouts when calling for a web resource. To make sure it is not a fluke, I created a test console project and was able to reproduce the issue (see below).
Basically, when calling any URL that contains a domain name, it will fail with a timeout. When an IP address is provided in the URL, it works without issues. This only occurs on my Pop!_OS (Ubuntu) machine, on Windows I don't face this problem. Additionally, if I run this project inside a Docker container, it also seems to work just fine.
I've tried reinstalling the dotnet SDK several times, rebooted the machine multiple times as well. No success.
This issue seems to only affect dotnet, as any other process on the system works just fine when connecting to the internet.
Source Code:
// DoesItWork.cs
using System.Net;

namespace Playground;

public static class DoYouWork
{
    public static void Test(string url)
    {
        Console.Write($"Testing {url,-60}: ");
        try
        {
            CheckForInternetConnection(url: url);
            Console.WriteLine("PASS");
        }
        catch (Exception ex)
        {
            Console.WriteLine($"FAIL! {ex.GetType()}: {ex.Message}");
        }
    }

    public static bool CheckForInternetConnection(string url)
    {
        // Authors note: I've seen the same results with other dotnet methods of calling web resources (i.e. HttpClient, async methods, ...).
        var request = (HttpWebRequest)WebRequest.Create(url);
        request.KeepAlive = false;
        request.Timeout = 10000;
        using (var response = (HttpWebResponse)request.GetResponse())
            return true;
    }
}

// Program.cs
DoYouWork.Test(url: "http://<IP_ADDRESS>");
DoYouWork.Test(url: "https://<IP_ADDRESS>");
DoYouWork.Test(url: "http://google.com");
DoYouWork.Test(url: "https://google.com");
DoYouWork.Test(url: "http://www.gstatic.com/generate_204");
DoYouWork.Test(url: "https://www.gstatic.com/generate_204");

Dockerfile:
FROM mcr.microsoft.com/dotnet/sdk:7.0 AS build
COPY ./ /src/

RUN dotnet restore /src/Playground/Playground.csproj
RUN dotnet build /src/Playground/Playground.csproj
RUN dotnet publish -o /out /src/Playground/Playground.csproj

FROM mcr.microsoft.com/dotnet/runtime:7.0 AS runtime
COPY --from=build /out /app
WORKDIR /app
ENTRYPOINT [ "dotnet", "Playground.dll" ]

Output, when run locally:
$ dotnet run --project Playground/Playground.csproj
Testing http://<IP_ADDRESS>                                              : PASS
Testing https://<IP_ADDRESS>                                             : PASS
Testing http://google.com                                           : FAIL! System.Net.WebException: The operation has timed out.
Testing https://google.com                                          : FAIL! System.Net.WebException: The operation has timed out.
Testing http://www.gstatic.com/generate_204                         : FAIL! System.Net.WebException: The operation has timed out.
Testing https://www.gstatic.com/generate_204                        : FAIL! System.Net.WebException: The operation has timed out.

Configuration

$ dotnet --info
.NET SDK:
 Version:   7.0.102
 Commit:    4bbdd14480

Runtime Environment:
 OS Name:     pop
 OS Version:  22.04
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /usr/share/dotnet/sdk/7.0.102/

Host:
  Version:      7.0.2
  Architecture: x64
  Commit:       d037e070eb

.NET SDKs installed:
  6.0.405 [/usr/share/dotnet/sdk]
  7.0.102 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.13 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.2 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.13 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/usr/lib/dotnet]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

Regression?

don't know
Other information

Is dotnet resolving domain names differently than the rest of the OS? If so is there a way to influence name resolution from the outside?

@dotnet/ncl any ideas why this could be happening?

Looks like name resolution issue in the docker image. Does nslookup ... work inside the image? Does the error reproduces on other machines (e.g. outside of docker)?
BTW, WebRequest is not recommended to be used in .NET Core and newer (it's kept only for backward compatibility). Always use HttpClient and always prefer async methods.

Result of nslookup:
$ nslookup google.com
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Non-authoritative answer:
Name:	google.com
Address: <IP_ADDRESS>
Name:	google.com
Address: 2a00:1450:4001:830::200e

$ nslookup gstatic.com
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Non-authoritative answer:
Name:	gstatic.com
Address: <IP_ADDRESS>
Name:	gstatic.com
Address: 2a00:1450:4001:827::2003

I am well aware that WebRequest is deprecated but I've seen this issue first when setting up JWT Bearer authentication using .AddJwtBearer(). When initialized, it tries to contact a .well-known URL of the JWT Authority, which ultimately fails. The code above is just a sample I grabbed of StackOverflow for testing purposes and modified it a bit later.
Regardless, I replaced the implementation with HttpClient, just to be sure. But no real change:
namespace Playground;

public static class DoYouWork
{
    private static HttpClient Client = new();

    static DoYouWork()
    {
        Client.Timeout = TimeSpan.FromSeconds(10);
    }

    public static async Task Test(string url)
    {
        Console.Write($"Testing {url,-60}: ");
        try
        {
            await CheckForInternetConnection(url: url);
            Console.WriteLine("PASS");
        }
        catch (Exception ex)
        {
            Console.WriteLine($"FAIL! {ex.GetType()}: {ex.Message}");
        }
    }

    private static async Task CheckForInternetConnection(string url)
    {
        HttpResponseMessage response = await Client.GetAsync(url);
        response.EnsureSuccessStatusCode();
    }
}

Output:
Testing http://<IP_ADDRESS>                                              : PASS
Testing https://<IP_ADDRESS>                                             : PASS
Testing http://google.com                                           : FAIL! System.Threading.Tasks.TaskCanceledException: The request was canceled due to the configured HttpClient.Timeout of 10 seconds elapsing.
Testing https://google.com                                          : FAIL! System.Threading.Tasks.TaskCanceledException: The request was canceled due to the configured HttpClient.Timeout of 10 seconds elapsing.
Testing http://www.gstatic.com/generate_204                         : FAIL! System.Threading.Tasks.TaskCanceledException: The request was canceled due to the configured HttpClient.Timeout of 10 seconds elapsing.
Testing https://www.gstatic.com/generate_204                        : FAIL! System.Threading.Tasks.TaskCanceledException: The request was canceled due to the configured HttpClient.Timeout of 10 seconds elapsing.

I didn't mention it above, but it also seems to be SDK-agnostic. Doesn't mater if the project is net6.0 or net7.0, the output is the same. And again: It seems to be just this one machine, which would hint at some misconfiguration in the OS, but it seems quite curious that only dotnet is affected and any other application on the system is perfectly fine.

After a bit more experimentation, I have figured out the issue: IPv6
While going through other options, I remembered that I had some issues with IPv6 some time ago (thought it should be fixed now). I then followed it up by disabling IPv6 on my system by running this command:
sudo -- sh -c 'sysctl -w net.ipv6.conf.all.disable_ipv6=1 && sysctl -w net.ipv6.conf.default.disable_ipv6=1'

I then restarted my IDE, just to be sure and I got an instant PASS on all my test addresses. To confirm this, I looked for domains that only resolve in IPv4 and IPv6 respectively (ipv4.google.com and ipv6.google.com come to mind) and tested those with IPv6 enabled (using sudo -- sh -c 'sysctl -w net.ipv6.conf.all.disable_ipv6=0 && sysctl -w net.ipv6.conf.default.disable_ipv6=0'). Interestingly I don't get a timeout anymore after this exercise, I get a HttpRequestException: No route to host (ipv6.google.com:443) while all other addresses are just slow to resolve but PASS eventually.
I am not entierly sure why this issue doesn't pop up anymore, but it is IPv6 related. I was also able to confirm this by pinging an IPv6 address.
$ ping 2606:4700:4700::1111  # <= this is <IP_ADDRESS> for IPv6
PING 2606:4700:4700::1111(2606:4700:4700::1111) 56 data bytes
^C
--- 2606:4700:4700::1111 ping statistics ---
42 packets transmitted, 0 received, 100% packet loss, time 41964ms

Anyway, sorry for taking up your time with my misconfigured OS. I hope this helps anyone else experiencing a similar problem in the future.