Add v0.8.1 to changelog

v0.8.1 was released to fix the broken build on FreeBSD. It is v0.8.0
with a859ee3 cherry-picked.
refs #567

Bors r+

bors r-

Sorry adjusting the commit message!

Sorry...I'll let you handle this. Should be easy enough! ☺

bors r=Susurrus

bord retry

bors retry

bors r=Susurrus


Allow whitelisting/blacklisting for Finagle metrics

People may not wish to export all of them, so we should allow some degree of control over which metrics are exposed.

I'm going to close this. It makes sense for this library to export every possible metric. It's appears to be possible to selectively drop metrics using metric_relabel_configs.


Select All

This works for ctrl-A on ALL platforms, if we want it to work with cmd-A on MAC, I'll need to add some less-than-elegant logic.

This selects all images that have already been loaded in the current filtered view, which I think is the only practical way to implement this, but may not meet user expectations. #152 should hit some of the use case for this. I think it would be best if this particular feature would only select the images that are visible in the browser and we should implement #152 to support that other use case.

@joefutrelle Based on your last comment, does this one need further changes? There's a merge conflict, but its not much of a conflict and get be resolved easily


feat: port Algebra.MonoidAlgebra.Division

This is the second part of the forward port of leanprover-community/mathlib#15905.

[x] depends on: #3059

This PR/issue depends on:

leanprover-community/mathlib4#3059
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#3059
By Dependent Issues (🤖). Happy coding!

bors merge


allow timestamp to be passed from command line [skip ci]

Closing this for now, but I want to make a rebuild mypkg.tar.bz2 command instead that copies prefix-placeholder and timestamp from an existing package.


LOG_DEBUG/LOG_INFO/etc... preprocessor macros create collisions with project that use those already

Hi there,
We are hitting a compilation problem in our project because we have our own version of LOG_DEBUG and friends, and depending on whether we include the xgboost include first, or our logging include first, we get weird compilation problems. This manifest in trying to build our project with unity build. Btw we aren't the only ones to use those macro names, a search on github leads to tons of hits.
Did other folks ever ran into that ?
include/xgboost/logging.h
126:// Redefines LOG_INFO for controling verbosity
127:#if defined(LOG_INFO)
128:#undef  LOG_INFO
129:#endif  // defined(LOG_INFO)
130:#define LOG_INFO                                                               \

dmlc-core/include/dmlc/logging.h
262:#define LOG_INFO dmlc::CustomLogMessage(__FILE__, __LINE__)
264:#define LOG_INFO dmlc::LogMessage(__FILE__, __LINE__)
266:#define LOG_ERROR LOG_INFO
267:#define LOG_WARNING LOG_INFO
272:#define VLOG(x) LOG_INFO.stream()
275:#define LG LOG_INFO.stream()

I see those macros being rarely used in your own code base, so maybe could LOG_INFO be changed to XGBOOST_LOG_INFO (or another name) to 'privatize' them and run into less of a risk that they will clash ?

The actual use is something like LOG(INFO) ... with macro expand.  I think you can change the LOG_INFO in xgboost without touching other parts of codebase.  Feel free to open a PR.

Thanks for the tip. I actually noticed that LOG_INFO and friends are also used in dmlc, and I assume the code change should be the same.
Should we use XGBOOST_LOGINFO, and DMLC_LOG_INFO respectively as names in both repo ?

Should we use XGBOOST_LOGINFO, and DMLC_LOG_INFO respectively as names in both repo ?

I think we can define XGBOOST_LOG_INFO or other shorter name, I don't have a strong preference.  But I don't maintain dmlc-core so you might have to ask the friendly folks there. ;-)
In xgboost, I think this should work:
#define XGBOOST_LOG_INFO \
  if (::xgboost::ConsoleLogger::ShouldLog(                                     \
          ::xgboost::ConsoleLogger::LV::kInfo))                                \
  ::xgboost::ConsoleLogger(__FILE__, __LINE__,                                 \
                           ::xgboost::ConsoleLogger::LogVerbosity::kInfo)

#define LOG(severity) XGBOOST_LOG_##severity.stream()   \

and then macros in the rest of the codebase like
LOG(INFO) << "Here's a msg";

should continue to work without change.

Yes thanks, this is exactly what I’m trying now in our branch, for both projects. I’ll keep you posted.

On Feb 4, 2021, at 11:32 AM, Jiaming Yuan<EMAIL_ADDRESS>wrote:
Should we use XGBOOST_LOGINFO, and DMLC_LOG_INFO respectively as names in both repo ?
I think we can define XGBOOST_LOG_INFO or other shorter name, I don't have a strong preference. But I don't maintain dmlc-core so you might have to ask the friendly folks there. ;-)
In xgboost, I think this should work:
#define XGBOOST_LOG_INFO
if (::xgboost::ConsoleLogger::ShouldLog(
::xgboost::ConsoleLogger::LV::kInfo))
::xgboost::ConsoleLogger(FILE, LINE,
::xgboost::ConsoleLogger::LogVerbosity::kInfo)
#define LOG(severity) XGBOOST_LOG_##severity.stream()
and then macros in the rest of the codebase like
LOG(INFO) << "Here's a msg";
should continue to work without change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dmlc/xgboost/issues/6678#issuecomment-773552741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UII6VOFDPHYV3YMHWDS5LY6TANCNFSM4XDIALNQ.

Actually there's been work in dmlc around logging 2 weeks ago, almost in the same vein -> 21cc7de0dc9fd6acb796e1be6181fa8e6b6c8f41

So here is what I ended up doing, sorry if I'm too lazy to make a proper PR (I forgot how to rebase my fork, maybe I'll do it one day...).
Patch A
diff --git a/include/xgboost/logging.h b/include/xgboost/logging.h
index 86550cc1..46e25a1f 100644
--- a/include/xgboost/logging.h
+++ b/include/xgboost/logging.h
@@ -98,30 +98,30 @@ class LogCallbackRegistry {

 using LogCallbackRegistryStore = dmlc::ThreadLocalStore<LogCallbackRegistry>;

-// Redefines LOG_WARNING for controling verbosity
-#if defined(LOG_WARNING)
-#undef  LOG_WARNING
-#endif  // defined(LOG_WARNING)
-#define LOG_WARNING                                                            \
+// Redefines XGBOOST_LOG_WARNING for controling verbosity
+#if defined(XGBOOST_LOG_WARNING)
+#undef  XGBOOST_LOG_WARNING
+#endif  // defined(XGBOOST_LOG_WARNING)
+#define XGBOOST_LOG_WARNING                                                            \
   if (::xgboost::ConsoleLogger::ShouldLog(                                     \
           ::xgboost::ConsoleLogger::LV::kWarning))                             \
   ::xgboost::ConsoleLogger(__FILE__, __LINE__,                                 \
                            ::xgboost::ConsoleLogger::LogVerbosity::kWarning)

-// Redefines LOG_INFO for controling verbosity
-#if defined(LOG_INFO)
-#undef  LOG_INFO
-#endif  // defined(LOG_INFO)
-#define LOG_INFO                                                               \
+// Redefines XGBOOST_LOG_INFO for controling verbosity
+#if defined(XGBOOST_LOG_INFO)
+#undef  XGBOOST_LOG_INFO
+#endif  // defined(XGBOOST_LOG_INFO)
+#define XGBOOST_LOG_INFO                                                               \
   if (::xgboost::ConsoleLogger::ShouldLog(                                     \
           ::xgboost::ConsoleLogger::LV::kInfo))                                \
   ::xgboost::ConsoleLogger(__FILE__, __LINE__,                                 \
                            ::xgboost::ConsoleLogger::LogVerbosity::kInfo)

-#if defined(LOG_DEBUG)
-#undef LOG_DEBUG
-#endif  // defined(LOG_DEBUG)
-#define LOG_DEBUG                                                              \
+#if defined(XGBOOST_LOG_DEBUG)
+#undef XGBOOST_LOG_DEBUG
+#endif  // defined(XGBOOST_LOG_DEBUG)
+#define XGBOOST_LOG_DEBUG                                                              \
   if (::xgboost::ConsoleLogger::ShouldLog(                                     \

Patch B
diff --git a/include/xgboost/logging.h b/include/xgboost/logging.h
index 46e25a1f..21fc8830 100644
--- a/include/xgboost/logging.h
+++ b/include/xgboost/logging.h
@@ -43,7 +43,9 @@ class ConsoleLogger : public BaseLogger {
     kWarning = 1,
     kInfo = 2,   // information may interests users.
     kDebug = 3,  // information only interesting to developers.
-    kIgnore = 4  // ignore global setting
+    kIgnore = 4,  // ignore global setting
+    kError = 5,
+    kFatal = 6
   };
   using LV = LogVerbosity;

@@ -98,6 +100,26 @@ class LogCallbackRegistry {

 using LogCallbackRegistryStore = dmlc::ThreadLocalStore<LogCallbackRegistry>;

+// Redefines XGBOOST_LOG_FATAL for controling verbosity
+#if defined(XGBOOST_LOG_FATAL)
+#undef  XGBOOST_LOG_FATAL
+#endif  // defined(XGBOOST_LOG_FATAL)
+#define XGBOOST_LOG_FATAL                                                            \
+  if (::xgboost::ConsoleLogger::ShouldLog(                                     \
+          ::xgboost::ConsoleLogger::LV::kError))                             \
+  ::xgboost::ConsoleLogger(__FILE__, __LINE__,                                 \
+                           ::xgboost::ConsoleLogger::LogVerbosity::kError)
+
+// Redefines XGBOOST_LOG_ERROR for controling verbosity
+#if defined(XGBOOST_LOG_ERROR)
+#undef  XGBOOST_LOG_ERROR
+#endif  // defined(XGBOOST_LOG_ERROR)
+#define XGBOOST_LOG_ERROR                                                            \
+  if (::xgboost::ConsoleLogger::ShouldLog(                                     \
+          ::xgboost::ConsoleLogger::LV::kError))                             \
+  ::xgboost::ConsoleLogger(__FILE__, __LINE__,                                 \
+                           ::xgboost::ConsoleLogger::LogVerbosity::kError)
+
 // Redefines XGBOOST_LOG_WARNING for controling verbosity
 #if defined(XGBOOST_LOG_WARNING)
 #undef  XGBOOST_LOG_WARNING
@@ -129,14 +151,14 @@ using LogCallbackRegistryStore = dmlc::ThreadLocalStore<LogCallbackRegistry>;

 // redefines the logging macro if not existed
 #ifndef LOG
-#define LOG(severity) LOG_##severity.stream()
+#define LOG(severity) XGBOOST_LOG_##severity.stream()
 #endif  // LOG

 // Enable LOG(CONSOLE) for print messages to console.
-#define LOG_CONSOLE ::xgboost::ConsoleLogger(           \
+#define XGBOOST_LOG_CONSOLE ::xgboost::ConsoleLogger(           \
     ::xgboost::ConsoleLogger::LogVerbosity::kIgnore)
 // Enable LOG(TRACKER) for print messages to tracker
-#define LOG_TRACKER ::xgboost::TrackerLogger()
+#define XGBOOST_LOG_TRACKER ::xgboost::TrackerLogger()

 #if defined(CHECK)
 #undef CHECK
diff --git a/src/logging.cc b/src/logging.cc
index d689ae34..48844507 100644
--- a/src/logging.cc
+++ b/src/logging.cc
@@ -85,6 +85,14 @@ ConsoleLogger::ConsoleLogger(
     const std::string& file, int line, LogVerbosity cur_verb) {
   cur_verbosity_ = cur_verb;
   switch (cur_verbosity_) {
+    case LogVerbosity::kFatal:
+      BaseLogger::log_stream_ << "FATAL: "
+                              << file << ":" << line << ": ";
+      break;
+    case LogVerbosity::kError:
+      BaseLogger::log_stream_ << "ERROR: "
+                              << file << ":" << line << ": ";
+      break;
     case LogVerbosity::kWarning:
       BaseLogger::log_stream_ << "WARNING: "
                               << file << ":" << line << ": ";

No worries.  Thanks for your suggested patches.  I will cleanup the macros at some point.


Aoycocr X10S Bricked?

I have 4 smart plugs brand Aoycocr X10S
I was able to successfully flash and run tasmota on 2 of them, however I believe the other 2 may be bricked.
During the flashing process for the bricked ones the backup failed so I canceled & restarted the process. After this when I plug them in, the light slowly blinks (about 1 blink per second) and pressing the button does nothing. Holding the button also does nothing. The light will continue to flash for a few minutes and then stop. There is no wifi network created by the plug that I can see. From the logs it appears they are not connecting to the vtrust-flash network. I can not tell if the intermediate firmware is installed or not.
On the ones that flashed without issue, once the backup failed I just continued on and everything else went smooth. These plugs run tasmota with no issues.
I'm running everything in a docker container on my Ubuntu 20.04 machine with a Intel 9260 wifi card.
Any ideas?
smarthack-mqtt.log
smarthack-psk.log
smarthack-udp.log
smarthack-web.log
smarthack-wifi.log

See #682

Thanks, did not see that one. I will start there!

Just to follow up,
I followed the instructions in #682  using a 100 uF capacitor and an arduino uno for 3.3V and was able to flash both of the non-responsive plugs without issue.
Thanks everyone!


AEM React SPA not working in publisher mode

Hi, I am trying to implement react AEM spa in my project. It is working fine in author/preview and view as publish mode. But it is not working in publisher mode (4503). I can see json being fetched correctly. On debugging I noticed that on wrapper div of child components, attribute 'data-cq-data-path' is missing in publisher mode. Although it is available in author mode. Are we missing anything here.
Any help will be appreciated. Thanks.

This issue is resolved. There some conflict in older packages in aem.


DNN logo at the bottom of the install page animates in and out continually

Description of problem
This one is super low priority. On the install page, there is a DNN logo which fades in and out throughout the install. I believe on Evoq, several images are used here to highlight features. On Platform, it's just the same DNN logo animating over and over and over.
Description of solution
If there's only one image there, don't animate it. Either hide it completely or keep it static.
Description of alternatives considered
Go the Evoq route: Add several images and cycle throught them to show off features. But honestly I think it'd be better just to hide it. Keep the screen simple.
Screenshots

Affected version

[x] 9.2.2
[x] 9.2.1
[x] 9.2
[x] 9.1.1
[x] 9.1
[x] 9.0

maybe we should use the option to highlight newest features in DNN Platform during install :)

I was thinking of some banners with links to some info:

Whats new in this release
Extensions Catalog (collection of open source modules)
Dnn documentation
Where to get help (dnnsoftware.com Q&A)
Link to dnn store
Fork us on Github

Giving that the installation got a lot quicker in recent versions, this would have to continue animating after the steps are complete and the Visit Your Site button shows.
And I guess there should be some config file so it can be easy to customize for platform and evoq, that file could contain: image and url.
The url should open in a new tab obviously.
Maybe we could consider having a larger image if we make that into banners that contain text and redesign the position of it on the install page...

My vote is to remove it, the reason why it's not working is the website it's looking for doesn't exist. I've asked for it to be restored numerous times.
If we want to keep it, I can setup a new site on azure through the foundation and we can add banners at anytime. We will need to submit a pull request to update the URL the installer is using to fetch banners.

Why not use local images. We could have a InstallerBanners folder with images? But I don't really care if that is removed all together, the install is so quick now anyway. Time could be invested in putting the suggested items in the default site template instead of this. Users will see that more than the installer and can return to it as they evaluate the platform.

Looking at the code a bit:
Currently every 5 seconds it brings up the logo, with no link.
If the number of banners is set; then it pulls the banners from
http://cdn.dnnsoftware.com/installation/Banner1.aspx and clicking that links to
http://www.dnnsoftware.com/installation/Banner1.aspx
The CDN links currently fail for me.
At www:
Banner1.aspx redirects to http://www.dnnSoftware.com/evoq-free-trial
Banner2.aspx redirects to http://www.dnnSoftware.com/resource/webinars
Banner3.aspx redirects to http://store.dnnSoftware.com/
Banner4.aspx and 5 give me a 404 error.
Like Daniel has suggested, these could be redirected to something useful. I'd say:

Docs
GitHub catalog
Store

But this then becomes more of a thing for the Awareness committee and DnnSoftware.ORG, right?! Can we come up with a quick fix, recognizing the other may be months away?

I have a lot of experience working with that from our time with Hotcakes.  I think we should keep it, but move the banner location to DNNSoftware.org.  This would allow us as a community to do the same things it was originally intended for.  We can promote DNN events, news, and features.  Due to the amount of time most installs take, I don't think we should ever have more than 3 banners though.  We can of course provide access to the appropriate people so that the banners are maintainable.
The script is fairly simple, but it needs to be updated a bit to be more flexible.  It simply cycles through the given domain and folder for images that match the expected naming convention (mentioned earlier).  It has a default image and domain name as well.  If no images matching the pattern are found at the expected location, it simply cycles through the default image.  Otherwise, it cycles through the images that are found.  However, the last time I looked, it didn't have a way to specify different URLs/landing pages for each banner image.

I agree with a max of 3, on DNNSoftware.org we can then have some landing page, kinda getting started page with more things and links to stuff.

When implementing an improved solution, please don't forget that a number of servers (especially in companies) are not allowed to retrieve content form outside the company's network, please make sure it contains valuable information for those "offline" scenarios as well.

I agree with @sleupold having the installer make remote calls to load content should really be discouraged, or it needs to be disclosed for those that are working in sensitive environments

I think we should still retain the remote content, but those are great points by Mitch and Sebastian.  This should be updated to notify the viewer that the content is coming from DNNSoftware.org.
In addition, logic should be in place to let them know that the content was unable to be displayed if DNNSoftware.org is not accessible.
In this latter instance, should we have default content?  Perhaps promoting community areas/features such as the forums, documentation, etc.?

@hismightiness For certain government agencies, it would need to be stopped BEFORE it tries to actually go out.  This is part of the big deal with the Upgrade Service that requires some agencies to modify the default install template to turn it off by default.  Just my $0.02.


Release a Beta of the Twig-based Standard Edition

The Twig-based Development Edition is meant to be an unstable platform for developing and testing changes to Twig-related components. With more interest in Twig support in Pattern Lab it'd be good to push out a beta of the Twig-based Standard Edition. Along with creating the beta I need to address issues that have come up regarding workflow and StarterKits. A quick task list:

[x] update the Watch command to support watching Composer-installed StarterKits for easier StarterKit development
[x] update the Fetch command to support the download & install of StarterKits from GitHub to avoid dependency issues. still utilize a composer.json to determine install locations via InstallerUtil.
[x] add Init command to initialize a project and prompt for StarterKit install if one wasn't installed based on a dependency in composer.json
[x] add merge/replace option to install of StarterKits (affects Fetch and InstallerUtil)
[x] add support for macros to the Twig PatternEngine per issue #5
[x] add PatternEngine-specific configs per #11 (dump, date support)
[ ] add events to PatternEngines so they can be extended via plugins rather than baking everything in directly (probably going to have to deal with baking things in. lots of moving parts here)
[x] make the supported extension for a PatternEngine an array and add method to add to to it per issue pattern-lab/patternlab-php#211 (added a method to update PatternData rules, that was the proper solution in retrospect)
[x] make sure config directives for arrays merge rather than replace
[ ] make PL unicode friendly by use mb_* functions per phprightway.com (not a simple fix. would be good to do at some point)
[x] remove "header options" copy from Mustache and Twig StyleguideKits
[x] create base/thin StarterKits for Mustache and Twig
[x] make sure the custom styleguide CSS override exists in the StarterKits
[x] update copy for various components
[x] add v0.* tags to various components to create a true stable beta release
[x] create a Twig Standard Edition

Nothing listed above is breaking new ground so should be straightforward to accomplish. Expect delivery by the end of the weekend if not sooner.
Extra info:

Twig components
discussion on the parts that make up a Pattern Lab project
more in-depth discussion on Editions and StarterKits

This is available as the Standard Edition for Twig.


KERNEL_SECURITY_CHECK_FAILURE with PcMark8

Executing benchmark with PcMark8 leads a bug check on a physical device due to unconditional execution of RDMSR in a VM-exit handler causing #GP at DISPATCH_LEVEL in case unsupported MSR by the device is given. Crash analysis logs is attached.
issue.txt
In this log, unknown MSR 0x31 was given to UtilReadMsr() resulting in #GP.
Note that this does not reproduce in a VMware VM because VMware swallows unsupported MSR I/O by returning none instead of raising #GP.

Addressed with 8fc86ed.


New element type: Text

Just like panels (#6) we used to have text elements before the rewrite (see https://github.com/YuriSizov/ui-grovetender/tree/33e5dda850d731be7e7ec3ea287eb903669cb9f3), so a lot of it can be borrowed into the current version.
A text element is used for various labels, whether dedicated or a part of a composite widget. Text must have configurable fonts, sizes, paragraph alignment. Text values must be editable directly on the canvas via the gizmo system.
One important thing about texts is that we need font size that will scale to the given element size. That means that element size and font size are not related, and should be treated separately. It also means that the text can overflow the element area, but that's fine. The element area should be treated more like a reference for positioning and size of the text itself.
The aforementioned font scaling can be done based on the height, which seems to be the most natural limit for it, as fonts are defined in character height.

Can I work on this issue? Or is this issue just a matter of porting from your old version of UI Grovetender? (I'm not very confident about my progress but I'm willing to learn, I'm Chaak from Twitter)

@ArceusMaxis Porting the old version and hooking it into the new systems is definitely the place to start. This mainly involves recreating the data object for text elements and remaking the gizmos. Text elements also rely on a unique property editor for picking font files, but it's already ported (albeit not tested, obviously), since those didn't change much.
It is not a simple task, though, as data updates and text rendering need to be solved anew. So while it is about porting, it's not mindless work :)
I'm not going to be working on this for the next couple of weeks since I'm taking a break and then shifting focus to Bosca Ceoil for a bit, so if you want to give it a try, then by all means! It also doesn't have to be solved all at once either. Feel free to ask questions here or on Discord, if you need help understanding something or figuring out the approach.


[FEAT] KD-Tree

Feature Request
Not sure if this is a feature request or just a comment / question on how I'm using graaf or how should I use it.
I'm not a super expert on C++20, so the code it's not easy to read/understand for me...
I'd like to be able to navigate the Minimum Spanning Tree resulted from Prim's... I'm used to deal those kind of graphs by a "tree" data structure (KD-tree?) where i can start navigating from a leaf of the tree and then I can go to adjacent vertexs and navigate it in  a custom way. Maybe this is already possible with graaf, or maybe it's totally non-sense, again, i'm not an expert on graph theory.
I'm using graaf to make some experiments related to a laser+sound show that we're developping in my studio : https://www.playmodes.com/home/astres/ . We're pointing and mapping a laser scanner to the night stars and we draw on top of them.  As the sky is always moving, we have some methods to get the star coordinates inside the field of view of the laser, then i create a Delaunay triangulation and build an undirected graps from it, then I apply the EMST to get a "figure/graph" that contains all the stars and some edges, as this is a way that we create generative constellations.
Why is this important?
In my case it's important that the Resulting Minimum Spannig Tree it's easy to navigate in a custom way, accessing to leafs and then moving on to the tree structure. But, as said, maybe this is a very "personal" approach that doesn't apply to the scope of this library....
Describe the solution you'd like
that I can get as a result of the Prim's algoritm a Kd-Tree data structure.
Describe alternatives you've considered
As far as I can tell, the info I can get from a Prim's MST are a vector of the vertices and a vector a vector of the edges, without any morphologic information.
Additional context
Are you willing to contribute?
I'm not able to  code in such a way as you do in graaf, sorry.
Checklist
Please check the following before submitting the issue:

[ x] I have searched for similar feature requests in the issues.
[ x?] This feature is not already implemented in the library.
[ 1/2] I have provided a clear and concise description of the feature request.
[ x] I have explained why this feature is important and how it benefits the library and users.
[ ] I am willing to contribute to the development of this feature (if applicable).

Please note that feature requests are subject to review and may or may not be implemented in the library.

Hi @eloimaduell, thank you for sharing this feature request with us. I had a closer look at your project and it looks awesome! Really cool to hear about your experimentations with Graaf, we would love to work together on this feature as I think your project is the perfect use case for our library.

I'd like to be able to navigate the Minimum Spanning Tree resulted from Prim's... I'm used to deal those kind of graphs by a "tree" data structure (KD-tree?) where i can start navigating from a leaf of the tree and then I can go to adjacent vertexs and navigate it in a custom way.

In general any graaf::graph can be traversed in a "custom" way. For examplex, see the BFS and DFS implementations in algorithm/graph_traversal. However, this requires the return value of Prim's algorithm to be a graph class, which it currently is not. I think it should be possible (and desirable) to change the return type of this algorithm such that it can be more easily consumed.
I am not too familiar with KD-tree's myself, but I wonder if this is something which can be "implemented" on a normal tree data structure by assigning special node and edge values. Maybe by restricting a node to two child nodes (binary tree) and assigning Euclidian distances as edge values?
For your project, would it work if we implement a tree data structure (which is a specialization of a graaf::graph) and return that from Prim's algorithm? That would allow you to do a custom traversal starting at either the leaves or root of the tree.

Hi @bobluppes ! Thanks for taking in consideration our needs ! So glad !!
I'm not 100% sure what is the best way to implement such feature, but I'm quite sure that having a tree data structure as a result of applying algorithms would allow us to do custom traversal's or other ideas that we have in mind in the context of our project. I stated kd-tree, but I guess whatever data structure (not sure if kd-tree is limited to binary trees? so that each vertex can only have maximum 2 adjacent vertices, where we would like to be able whatever number of adjacencies given any vertex) that can host vertices, edges and methods to travel throught it should be enough. In our case we would need to choose where do we start to navigate / traverse the graph, and from there having adjacency list of each vertex should be fair enough. Could we help in something for this hack/feature ? Let us know if we can help in anyway ... Open to have a direct communication too through email or so ...

Hi again, so today playing with the result of Prim's, trying to understand what is the order that the edges are returned, i found no specific order...

As you might see on this screencapture, I'm painting the vertices of an EMST and also the edges in the order that I get them from the Prim's result.
I imagine that with those algorithms returning a tree structure (as a specialization of a graaf::graph as you mentioned), we might be able to apply traversal algorithms and develop new ones right ?

Thank you for the elaborate reply!
In terms of working on this, I would propose that I implement a (prototypical) tree class which we can return from Prim's algorithm. If you are available to collaborate I think it does make sense to take a closer look at your use case, as I want to make sure that this feature closely fits your needs (and hopefully future use cases as well 😄). You are more than welcome to join our discord and we can discuss your use case further if you are interested.
Logistic wise, introducing these changes means bumping a major version. So depending on how you include the Graaf dependency in your project I would provide a separate build artifact for you to try out. Once we are confident that the changed interfaces are mature enough I will include it in the next release of Graaf.

Hi again, so today playing with the result of Prim's, trying to understand what is the order that the edges are returned, i found no specific order...

Very cool to see your experimentations with the library! There is a specific order in which these edges are returned, but it is an implementation detail of the algorithm.

I imagine that with the new feature that you have proposed those algorithms returning a tree structure (as a specialization of a graaf::graph as you mentioned), we might be able to apply traversal algorithms (for example to a resulting EMST tree) and develop new traversing algorithms right ?

Indeed! What I am currently thinking of is to implement a tree class which derives from graph. Apart from the usual methods (most notably get_neighbors), it then also provides the means to access the root and leaf nodes of the tree. In general I think this should allow us to implement any traversal algorithm on the result.

Just joined the Discord channel :) Let's continue there maybe ? I'm ok on working in a protoype way ... whatever it's more convenient for you. I can collaborate trying to express what might work for our use case, trying, debugging etc ... I'm using XCode and my projects are usually build as Openframeworks (http://www.openframeworks.cc) does ... As Graaf is header only it was quite easy to include the sources and it just worked. You know much more about the proper way to develop this feature and how to make it match you repo ... I'm ok if you send files and I just try them ... or whatevert ... let me know what might be better or more convenient for you and I'll try it. Excited !!


Upgrade to Rust 1.80.0.

The release announcement is here:
https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html

Ok, the Linux arm64 failure is due to a docker hub update still in-progress: https://doi-janky.infosiftr.net/job/repo-info/job/remote/66145/

I actually have no clue how to track what goes on between when the docker hub splash page shows an image is available to when it actually is.


improvement/test-updates-and-game-header

Codecov Report

Merging #20 (5e2f929) into main (090b892) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   81.21%   81.58%   +0.37%
==========================================
  Files          51       52       +1
  Lines         708      717       +9
  Branches      115      115
==========================================
+ Hits          575      585      +10
+ Misses        133      132       -1

Flag
Coverage Δ

unittests
81.58% <100.00%> (+0.37%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/components/form/fields/set-players.tsx
100.00% <ø> (ø)

src/components/google/map.tsx
100.00% <ø> (ø)

src/components/play/play.tsx
92.85% <ø> (ø)

src/components/play/styles/styles.ts
100.00% <ø> (ø)

src/pages/wrappers/theme.tsx
100.00% <ø> (ø)

src/styles/containers.tsx
92.30% <ø> (ø)

src/components/google/marker.ts
100.00% <100.00%> (ø)

src/components/play/header/header.tsx
92.85% <100.00%> (ø)

src/styles/global.tsx
100.00% <100.00%> (ø)

src/styles/utils.ts
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090b892...5e2f929. Read the comment docs.


chore: update sample README after Uber migration

Hi,
Small change after the migration from golang to uber, so the users don't end up running the wrong tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Adrien Barreau seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: listen function

Description of change
Fix the listen function
Links to any relevant issues
closes: https://github.com/iotaledger/iota-sdk/issues/226
Type of change
Choose a type of change, and delete any options that are not relevant.

Bug fix (a non-breaking change which fixes an issue)

How the change has been tested
Ran FF with the linked package.
Ran example 7-events.js (still fails due to a change introduced while merging sendAmount() & sendMicroAmount())
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that new and existing unit tests pass locally with my changes

Is the wasm binding also working with this?

Is the wasm binding also working with this?

Not as far as I can see from this file:
https://github.com/iotaledger/iota-sdk/blob/6195e9a32edab969c0df858c507c1890b1f26320/sdk/src/wallet/bindings/wasm/lib/bindings.ts#L10

@Tuditi for the wasm binding the JS lib is copied over, apart from https://github.com/iotaledger/iota-sdk/blob/6195e9a32edab969c0df858c507c1890b1f26320/sdk/src/wallet/bindings/wasm/lib/bindings.ts
and there it still exports listen, so listenTo will not be found
So I think the way this PR currently is would just change it around, so it's found on the nodejs binding, but will fail on wasm

Maybe also enable the CI for wasm by adding - "sdk/src/client/bindings/nodejs/**" # Re-include nodejs bindings, because lib is copied from there here
https://github.com/iotaledger/iota-sdk/blob/d4c1d9a876cfc470d9ea6b290fc4f703f90178bf/.github/workflows/bindings-wasm.yml#L15-L28


add all other needed tables, as to reduce load on pokeapi.co during development

Current dependencies on/for this PR:

master

PR #9

PR #10

PR #11

PR #12   👈

This comment was auto-generated by Graphite.

Merge activity

Oct 12, 6:12 PM: @mazylol started a stack merge that includes this pull request via Graphite.


Stringified object representations don't preserve field order

Currently, stringified io.circe.Json doesn't appear to preserve field order. This doesn't matter for machines but it would greatly help human readability.
scala> import io.circe._, io.circe.generic.auto._, io.circe.jawn._, io.circe.syntax._
import io.circe._
import io.circe.generic.auto._
import io.circe.jawn._
import io.circe.syntax._

scala> case class MyClass(a: Int, b: String, c: List[String], d: Boolean)
defined class MyClass

scala> val m = MyClass(5, "asdf", List("zxcv", "qwer", "hjkl"), false)
m: MyClass = MyClass(5,asdf,List(zxcv, qwer, hjkl),false)

scala> m.asJson
res0: io.circe.Json =
{
  "d" : false,
  "c" : [
    "zxcv",
    "qwer",
    "hjkl"
  ],
  "b" : "asdf",
  "a" : 5
}

@longcao Order is preserved internally, it's just that the default printers don't preserve it in their output, see https://github.com/travisbrown/circe/blob/master/core/shared/src/main/scala/io/circe/Printer.scala#L215.
The following gives back the right order for me:
Printer.spaces2.copy(preserveOrder = true).pretty(m.asJson)

giving
res1: String = """
{
  "a" : 5,
  "b" : "asdf",
  "c" : [
    "zxcv",
    "qwer",
    "hjkl"
  ],
  "d" : false
}
"""

Fixed by #89—thanks @longcao, @alexarchambault!


Large perf improvement

I was working in Godots main branch, trying to improve load times and made a ton of changes to this file. I ultimately found that this one small change accounted for 90% or more of my total improvements. In godot, loading a ~34 MB glb file went from 18 seconds to 4.9 seconds.

This completely breaks the simplifier since you no longer rank collapses.

How so? I'm missing something about this function, then. Without my change:
We loop through the collapses array, setting Collapse c to be a reference to collapses[i].
Quadric Error calculations.
Then we set data to our referenced Collapse c.
Then c falls out of scope and is recreated again, in the next iteration, and set to the next Collapse.
If we declare c above the for loop and simply change which item in the array it is referencing every iteration, what breaks?

If we declare c above the for loop and simply change which item in the array it is referencing every iteration, what breaks?

That is not how your code works. Your code change always references element 0 in the loop body. The assignment overwrites collapse 0 with collapse on each iteration, but the error on any other collapses is never updated. You would note that this change breaks the tests (https://github.com/zeux/meshoptimizer/actions/runs/9704155260/job/26783830103).

I did see that test failing from the results of my pull request. Unfortunately I am failing on line 880 without any changes. I'll keep at it.

And sorry. I didn't say thank you for enlightening me. I really appreciate it. I still have a lot to learn.
Related, I commented out the tests that I couldn't pass (with an unchanged copy of the repo). Now I am able to break on line 955 with that change. Perfect.
So, out of curiosity I tried:
Collapse* c = &collapses[0];
for (size_t i = 0; i < collapse_count; ++i)
{
	c = &collapses[i];

	unsigned int i0 = c->v0;
	unsigned int i1 = c->v1;

	// most edges are bidirectional which means we need to evaluate errors for two collapses
	// to keep this code branchless we just use the same edge for unidirectional edges
	unsigned int j0 = c->bidi ? i1 : i0;
	unsigned int j1 = c->bidi ? i0 : i1;

	float ei = quadricError(vertex_quadrics[remap[i0]], vertex_positions[i1]);
	float ej = quadricError(vertex_quadrics[remap[j0]], vertex_positions[j1]);

	if (attribute_count)
	{
		ei += quadricError(attribute_quadrics[remap[i0]], &attribute_gradients[remap[i0] * attribute_count], attribute_count, vertex_positions[i1], &vertex_attributes[i1 * attribute_count]);
		ej += quadricError(attribute_quadrics[remap[j0]], &attribute_gradients[remap[j0] * attribute_count], attribute_count, vertex_positions[j1], &vertex_attributes[j1 * attribute_count]);
	}

	// pick edge direction with minimal error
	c->v0 = ei <= ej ? i0 : j0;
	c->v1 = ei <= ej ? i1 : j1;
	c->error = ei <= ej ? ei : ej;
}

This appears to pass. I didn't want to spam you with another potentially terrible pull request. Do you see any issues here?

This code looks correct but it should not be any faster.

I agree. Unfortunately I am seeing a load time in Godot for a ~34 MB glb file go from:
EditorFileSystem: "res://chess_set.glb" import took 18206 ms.
Down to:
EditorFileSystem: "res://chess_set.glb" import took 4813 ms.
And I also don't see how. But I have tested it about a dozen times on two copies of the repo.


RN-289 Sentry integration

Finally got this sorted out. The parts of this are:

The javascript error handler now logs errors to Sentry
I've upgraded react-native-exception-handler so we can add a native error handler which also logs errors to Sentry
There's middleware that creates breadcrumbs for Redux actions (thanks, Jarred, although I didn't use the redux-for-raven library)

Jarred, I didn't enable the logging on redux errors since that seemed to capture a lot of unnecessary events like invalid password errors, and it would double up events on actual errors.
To make sure everyone is on the same page about when we log to Sentry:

Sentry can be disabled in the build config, but it will be enabled on our app store builds
Sentry is disabled if the server we're connected to has EnableDiagnostics set to false
Sentry is enabled if we're not connected to a server (ie on the select server page)

@coreyhulen @enahum: The tentative list of data we capture is here. The only fields that I think could be considered personally identifiable are:

user/channel/team ID (useless without knowing what server they came from)
IP address (not sure how to stop capturing that) We're no longer storing the IP address
app.device

I looked into it further and this is a SHA-1 hash unique to a given device/application, so I don't think it'll be a problem to capture. It's not the same thing as the device ID used for push notifications as I thought before. This is the code that generates it: https://github.com/kstenerud/KSCrash/blob/438e27e73318d61043cdb4a80dcbb0cb563902c6/Source/KSCrash/Recording/Monitors/KSCrashMonitor_System.m#L373

Ticket Link
https://mattermost.atlassian.net/browse/RN-289
Device Information
This PR was tested on: iOS Simulator, Nexus 5 (Android 6.0.1)

One other thing, I went on about how you would need to use Fastlane to change some stuff to compile the app with the native code for Sentry. That's not the case any more. For iOS, you can just set some environment variables (SENTRY_ENABLED, SENTRY_ORG, etc) and the build process will set everything up. For Android, you might need to create android/sentry.properties, but I don't know if that's even necessary

Adding @jasonblais to double check the data that we capture. The only thing we're not 100% on is if we should find a way to obscure the IP address of the sender

@hmhealey this is going to need a rebase sorry


page "Item Availability by Timeline" missing in bc 16

page "Item Availability by Timeline" cannot be found at least in business central 15.
there is an idea on @ideas to vote for: https://experience.dynamics.com/ideas/idea/?ideaid=71c16061-8499-e911-80e8-0003ff68cb40

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7172099-61d3-f4f8-5a6c-f5e6880c800e
Version Independent ID: 631ec9b4-9487-2248-a030-5c3ebd9ab7b0
Content: How to Modify Planning Suggestions in a Graphical View - Business Central
Content Source: business-central/production-how-to-modify-planning-suggestions-in-a-graphical-view.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Hello,
Thank you for your feedback! The Item Availability by Timeline page is in fact available in Business Central online but only from the Planning Worksheet page. We'll get that clarified in the near future.

Hello @dfk-consult
I was to rash yesterday, so after a double-check I can confirm that the feature is indeed not working in the browser. The confusing content in this article has been removed in the English version today.
Sorry for the confusion!

hi,ok. i read that this feature is not available in the web client, because the main component is a. net library.there is a an entry in ideas for that feature. it seems, that its planned for a future release.regardsdipl. ing. franz kalchmair-------- Originalnachricht --------Betreff: Re: [MicrosoftDocs/dynamics365smb-docs] page "Item Availability by Timeline" missing in bc 16 (#350)Von: Eva Dupont An: MicrosoftDocs/dynamics365smb-docs Cc: "Franz Kalchmair, Dipl.Ing." ,Mention
Hello @dfk-consult
I was to rash yesterday, so after a double-check I can confirm that the feature is indeed not working in the browser. The confusing content in this article has been removed in the English version today.
Sorry for the confusion!
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/MicrosoftDocs/dynamics365smb-docs/issues/350#issuecomment-624661626",
"url": "https://github.com/MicrosoftDocs/dynamics365smb-docs/issues/350#issuecomment-624661626",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


Wrong tooltip position for childs element with absolute position

Example https://codesandbox.io/s/7j200nr5l1
Click on Bottom button

Yeah, that's a problem.
Do you have any idea how to fix this?
Because currently, I'm adding a ref and click/hover event handlers in a wrapper that isn't being repositioned when the children have a different position than the default...
I'm changing the requirements in 0.3 to accept a single children only.
And to fix the positioning the simpler option is to clone the children (if there's one) and set ref and handlers directly. The drawback is this could override some props of the children.
Any ideas?

I've found a way to fix this by changing the wrapper style. It worked well, I'll test a bit more and I'll commit soon.

fixex in 842cab6b05b0e06194b7da2e88a6dddcdd55b23e and published as 0.2.3
Thanks


A few minutes after logging into my tdlib, the account becomes Deleted Account

A few minutes after logging into my tdlib, the account becomes Deleted Account. May I ask why?
I didn't do anything after I logged in

A few minutes after logging into my tdlib, the account becomes Deleted Account. May I ask why? I didn't do anything after I logged in

Telegram has too many spammers so it's possible to be on guard against auto-deleting all accounts that use 3rd party APIs/apps,
I feel it too, even though I don't use fire for detrimental actions such as spam / spreading hoax links / phishing scams


ALSA lib pcm.c:8382:(snd_pcm_set_params) Sample format not available for PLAYBACK: Invalid argument

Hi,
I built librespot with alsa backend on Archlinuxarm:
https://aur.archlinux.org/packages/librespot-alsa-git/
When I try to start librespot with the following command:
librespot --cache /var/cache/librespot --name Test --bitrate 320 --username xxxxxx --password xxxxxx
I get the following error:

ALSA lib pcm.c:8382:(snd_pcm_set_params) Sample format not available for PLAYBACK: Invalid argument
thread '' panicked at 'called Option::unwrap() on a None value', src/libcore/option.rs:323
note: Run with RUST_BACKTRACE=1 for a backtrace.

Any help is highly appreciated.
Many thanks,
Michael

Looks like your ALSA device does not support the sample format S16_LE.

My device is:
ard 1, ID DAC', name S16 USB DAC'
Device 0, ID USB Audio', name USB Audio', 1 subdevices (1 available)
2 channels, sampling rate 44100..384000 Hz
Sample formats: S32_LE
Subdevice 0, name `subdevice #0'
and indeed does not support S16_LE.
So I assume there's no solution to this?
Many thanks for your immediate reply.

You can set the ALSA device with the --device option. Try --device=plughw:1.

Thank you very much, it works!
I am trying to find a more generic approach so that librespot uses the default alsa device. Is there any possibility to do this?

librespot does use the default device. Your default device does not support S16_LE. If you do not want to set the device with --device you have to make plughw:1 your default ALSA device. You can set this in ALSA config file. Google will help you :smile:

Many thanks for everything.
I have already created an asound.conf file with the following configuration:
pcm.!default {
type hw
card 1
}
As it seems I have to search more for this.

Try this:
pcm.!default {
type plughw
card 1
}

Thank you very much for everything Joerg.
Everything is up and running buy adding the device option on the systemd.service file.

You are welcome!

am getting this too, but with a FiiO USB DAC adding --device=plughw:1 doesn't fix it. See my report on pimusicbox through which I am using librespot https://github.com/pimusicbox/pimusicbox/issues/453

Try doing the following:
List all available devices: aplay -l
Locate your USB device. For my dragonfly it was: plughw:CARD=v10
Append it to your --device option.
Worked like a charm for me.


ML 1.6 : Maximum Likelihood Estimation (V)

Welcome to 'ML' Team, good to see you here
This issue will helps readers in acquiring all the knowledge that one needs to know about Maximum Likelihood Estimation.
To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
Domain : Machine Learning
Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the Machine Learning/Machine_Learning/Statistics_for_Machine_Learning Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Video

All the best. Enjoy your open source journey ahead. 😎

I want to take this issue.
Mandeep Kaur
ML-batch-3
https://github.com/mandeep168
Video

Issue assigned @mandeep168
Happy contributing!

i want to contribute
Mohit  Kumar
approch:
what is Maximum Likelihood Estimation
what is use of MLE
how to find the MLE

I want to take this issue.
Ahmed Tarek
ML-batch-1
https://github.com/ahmedtarek26
Video

@mandeep168 any update?

Yes, I am working on it.

@mandeep168  Create the PR asap.

I made a PR and I am sorry for the delay.

@mandeep168 Please create the PR in the machine learning branch!


docs: fix some typos and dead git addr

Signed-off-by: zhangyue<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Fix some typos in docs  and fix error git address of dragonfly.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
just change docs, not need.
Ⅳ. Describe how to verify it
None.
Ⅴ. Special notes for reviews
None.

We found this is your first time to contribute to Pouch, @ZYecho
We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking!

cc @allencloud ,seems need to change the desc of it, Pouch -> dragonfly

LGTM.
Thanks a lot ^-^!


Seeing an error ModuleNotFoundError: No module named 'langchain.globals'

System Info
LangChain version pinned to "^0.0.278" (using Poetry)
Python 3.11.5
Other modules from langchain (such as langchain.cache and langchain.chains) are imported within the same file in the application code and are able to be found. Only the langchain.globals module is not being recognized
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
Import langchain.globals
Error happens on application startup
Expected behavior
Expected to be able to find the module, as langchain's other module's are able to be found by the same application code

Did what the bot said and I got the following error:
ImportError: cannot import name 'globals' from partially initialized module 'langchain' (most likely due to a circular import) (SOMAEPATH\langchain.py)

https://github.com/langchain-ai/langchain/issues/2079#issuecomment-1487416187
Found the comment here and found that I'm not a smart man either.😅


Button: Make button visuals overridable by sx

As described in the issue, a regression introduced in https://github.com/primer/react/pull/3447 where the icon colors became not overridable by the sx prop in Button.
This issue originally goes back to introducing data-attributes selectors to Button (https://github.com/primer/react/pull/2792) and it came with some challenges with overriding styles with sx. At the time, we wrote a custom CSS selector to take data attributes into account while applying the sx styles. However, the new icon styles that are introduced in https://github.com/primer/react/pull/3447, are not included in the custom selectors.
Note: We won't have to use this css selectors when we move to css modules ✨ but for now, it seems to be doing what we want.
All that said, I am always open to any kinds of feedback 🙏🏻
Closes https://github.com/github/primer/issues/2576
Screenshots
Before

After

Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[ ] Changes are SSR compatible
[x] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Hey @joshblack that totally works for the color  🎉  I wasn't very happy how the generateCustomSxProp function got more complex and unreadable but couldn't think of a different way. I appreciate this so much 🙏🏻  I'll definetely update the implementation just a few things clarify around this:

I was thinking if we can apply the custom css prop solution you suggested to the rest of the styles that uses data attributes to simplify the custom sx prop function. However, as far as I understand, this might be a bit challenging for the rest of the styles that uses data attribute.

For example to make sure sx styles are applied properly to the size="small" button that uses data-attribute for setting styles, seems like we need to create css var for each attribute that we are overriding i.e. font-size, padding etc. Is this what you are reading as well or do I miss something here?

In terms of the jest tests, I was using toHaveStyle for expect but seems like that function has some issue with the css variables (some related open issues I found: issue1, issue2) - Do you have any recommendation to test these styles in jest? I am also happy to add test stories for each case for VRT. Let me know what you think!

Thanks again, I appreciate your input 🙏🏻

@joshblack All looking good! Checks are green and tested in review lab to see the button that is originally reported as an issue
https://github.com/github/github/pull/291667


doc: Soften and make clearer the language for no-class-state

@brion, continuing the conversation from #78, how's this?

LGTM, that should at least point folks in the right direction and leaves an out when it's necessary. :D

We could use similar language in https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/rules/no-global-selector.js for #109


SondeHub support?

Just wondering if you've considered adding sondehub.org upload support?
SondeHub has a simple API for submitting data to, and is usually fairly easy for RS41 data. DFM sondes have a few quirks around frame numbering but also not too hard.
https://github.com/projecthorus/sondehub-infra/wiki/SondeHub-Telemetry-Format
https://github.com/projecthorus/sondehub-infra/wiki/Specific-Notes#sonde-data-uploader-notes
https://github.com/projecthorus/sondehub-infra/wiki/API-(Beta)
Let me know if this interests you and if you need any help.

(it should be important to note that the time used in sondehub is uncorrected for any leapseconds)

I've thought about adding support for sites like radiosondy.info and sondehub.org, but I feel like those are more meant for constant tracking, while this plugin is more geared towards tracking on a whim (say, you're near the landing site and want to check where exactly the radiosonde is).
If you want to submit tracking data to those sites, there's better alternatives already available like radiosonde_auto_rx, which is more set-and-forget and doesn't require running a desktop SDR application. I'm open to adding support in the future if more people are interested though

As the author of auto_rx - I think that having something like this upload would still be extremely useful - especially for people newer to the hobby who might not have the skills to setup auto_rx.
Also... if you're the closest station, uploading the landing telemetry to sondehub is still extremely useful!
We would need to make sure the generated telemetry matches what's produced by auto_rx and the rdz_ttgo_sonde code though.

A lot of people ask if they can use things like AirSpys and LimeSDRs that autorx doesn't support. This would be a good project to direct those users to

Fair points, I'll see what I can do during the holidays then.
@darksidelemm Most of the equations for the PTU telemetry I'm using come from ra_firmware, at least for RS41 data. They are the same equations as rdz_ttgo_sonde, but they're different from the ones auto_rx uses. I can match either implementation, though rdz_ttgo_sonde looks more correct (fewer magic numbers, uses more data from the calibration superframe). Which one should I follow?

Use the calculations from the RA firmware or rdz_ttgo. The end result is within a tiny fraction of what auto_rx produces anyway.

Lol, I just came across your project on the RTL-SDR blog and was going to come here to ask the same thing :)

I love projects like this, follwing the KISS principle not implementing improper bloat interfaces.

... I'm not entirely sure how to interpret the above comment.

I saw that you implemented this in the net branch a few weeks ago and was wondering if you were planning to integrate it into the master version?

I started working on it, but then decided to prioritize getting Windows support working and using a different decoding backend. SondeHub uploading is next on the list though.

When you get to that point, we will need to make sure the uploaded telemetry values closely match what is produced by the RS and rdz_ttgo_sonde decoders.

Chiming in to add a big YES PLEASE to this feature. Thanks so much for your work.

Now that I have your decoder working on Android I really really would like to see sondehub support. @dbdexter-dev is this still on your list or have you moved on to other things? Thanks from New Zealand.


⚠ SkipTheCommericals has degraded performance

In 06ad4f3, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 4237 ms

Resolved: SkipTheCommericals performance has improved in 8ad7848.


added preventing the shade plugin from relocating org.slf4j.Logger to *.shaded.slf4j.Logger

… *.shaded.slf4j.Logger in error logging instrumentation

What does this PR do?

Checklist

[x] My code follows the style guidelines of this project
[ ] I have rebased my changes on top of the latest master branch

[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

[ ] I have updated CHANGELOG.asciidoc
[ ] I have updated supported-technologies.asciidoc
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] Added an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?

Author's Checklist

Related issues

Use cases

Screenshots
<!-- _(Optional)_
Add here screenshots about how the project will be changed after the PR is applied. They could be related to web pages, terminal, etc, or any other image you consider important to be shared with the team.

On a side note, this issue also means that we lack a proper test for this feature, as relocation is done at packaging, we could probably add an integration test to prevent any further regression.

@kananindzya Your commit was not pushed yet

@kananindzya Your commit was not pushed yet

pushed

On a side note, this issue also means that we lack a proper test for this feature, as relocation is done at packaging, we could probably add an integration test to prevent any further regression.

added logging-integration-tests

@kananindzya this PR is very close to an end, only need to take another look at the test and add to the CHANGELOG. Do you want to finish it?

@kananindzya this PR is very close to an end, only need to take another look at the test and add to the CHANGELOG. Do you want to finish it?

I deleted submodule, changed the scope. But i don't know how to check that test fails without this fix.

i don't know how to check that test fails without this fix

Your'e right, it's not a trivial thing, as in order to test shading effects you would need to test the built and packaged agent. One option is adding a test Servlet to the simple-webapp test app, that we use in the application-server-integration-tests. However, it is not required in order to merge this PR.
If you want to take a stab on it- go ahead.
Otherwise, since the added test doesn't test the fix and the basic functionality is already tested within the logging plugin, I suggest removing this test and module altogether and only verify in a manual test that it didn't work with an older agent and it works with an agent containing your fix.
Bottom line- it is an important fix we would like to merge, and manual test would be sufficient in this case. You would need to merge the latest master so that the CHANGELOG is up to date.
Thanks!


Many commands do not make use of subscription parsed from an ARM ID

Our cross-RG/cross-subscription "story" in CLI 2.0 has been that the user supply the ARM ID for these scenarios.  Depending on the specific implementation scenario, this may or may not work:
Works
The API accepts an ARM ID.  The implementation will pass the ARM ID along if it is valid, otherwise it will build an ID from what it assumes to be a name, using the current subscription.  This is the common case for supporting resources in commands.
Doesn't Work
The API accepts names. The implementation parses the ID into names and proceeds. This is the common case for primary resources in commands and this scenario does not support cross-subscription operation.
We need to ensure the cross-subscription scenario is properly enabled for all uses of --ids.
Related to #807.

Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)
azure-cli (2.0.27)

acr (2.0.21)
acs (2.0.26)
advisor (0.1.2)
appservice (0.1.26)
backup (1.0.6)
batch (3.1.10)
batchai (0.1.5)
billing (0.1.7)
cdn (0.0.13)
cloud (2.0.12)
cognitiveservices (0.1.10)
configure (2.0.14)
consumption (0.2.1)
container (0.1.18)
core (2.0.27)
cosmosdb (0.1.19)
dev-tools (0.1.1)
dla (0.0.18)
dls (0.0.19)
eventgrid (0.1.10)
extension (0.0.9)
feedback (2.1.0)
find (0.2.8)
interactive (0.3.16)
iot (0.1.17)
keyvault (2.0.18)
lab (0.0.17)
monitor (0.1.2)
network (2.0.23)
nspkg (3.0.1)
profile (2.0.19)
rdbms (0.0.12)
redis (0.2.11)
reservations (0.1.1)
resource (2.0.23)
role (2.0.19)
servicefabric (0.0.10)
sql (2.0.21)
storage (2.0.25)
testsdk (0.1.0)
vm (2.0.26)

Extensions:
subscription (0.1.0)

Python location 'C:\Users\trpresco\Documents\github\azure-cli\env\Scripts\python.exe'
Extensions directory 'C:\Users\trpresco\.azure\cliextensions'

Python (Windows) 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 17:54:52) [MSC v.1900 32 bit (Intel)]

Assigning to myself for Sprint 33 to gauge the level of effort needed to resolve this.


Add e2e test for ova provider

https://issues.redhat.com/browse/MTV-624

@bkhizgiy I've merged the PR for forkliftci, note that there's a new version of forkliftci, v9.0, that includes the OVA. need to bump the version we use here

Still missing two CI changes.

need to change the vm.ova file used, the current one don't have proper network config for the test.
need to understand how to use virt-v2v real image (and not stub) for ALL endpoint in the CI.

Need to merge PR https://github.com/kubev2v/forklift/pull/643 for the tests to pass.

Missing https://github.com/kubev2v/forkliftci/pull/114 for pulling images.


Lean Protobuffers

Issue #, if available: N/A
Description of changes:
Initial work on adding Protobuffer support to lean

Closing this draft PR in favor of several smaller PRs that together accomplish a similar goal to this PR:

#478
#482
#483
#485
#486
#488


UDP ports may remain open after calling RoundRobinDnsAddressResolverGroup#close()

In Netty 4.1.36 (and several versions prior), we've found that UDP ports can "leak" when using multiple RoundRobinDnsAddressResolverGroup instances. Please let me begin by acknowledging that I may be missing something important about how RoundRobinDnsAddressResolverGroup is supposed to be used, but I think this might be a bug.
Expected behavior
When calling RoundRobinDnsAddressResolverGroup#close(), any persistent resources (UDP ports, in this case) opened by the resolver group should be closed/released.
Actual behavior
Some UDP ports may remain open after calling RoundRobinDnsAddressResolverGroup#close().
Steps to reproduce
In a loop, create a new RoundRobinDnsAddressResolverGroup and use it to resolve an address. Close the resolver group at the end of each iteration. While running, observe the number of open UDP ports over time (I used netstat -ap udp | wc -l under macOS).
Minimal yet complete reproducer code (or URL to code)
final NioEventLoopGroup eventLoopGroup = new NioEventLoopGroup(1);

try {
    while (true) {
        final RoundRobinDnsAddressResolverGroup resolverGroup =
                new RoundRobinDnsAddressResolverGroup(NioDatagramChannel.class,
                        DefaultDnsServerAddressStreamProvider.INSTANCE);

        // UDP ports don't get opened unless we actually try to do something with
        // the resolver; in the real use case, this happens by way of
        // bootstrap.connect(), but I've opted to use this as a more concise example.
        // I definitely recognize the possibility that there may be nuanced
        // differences between the real use case and this minimal example, but hope
        // it gets the point across.
        resolverGroup.getResolver(eventLoopGroup.next()).resolve(
                InetSocketAddress.createUnresolved("example.com", 80)).get();

        // In a vacuum, I would expect any ports opened by the resolver to be closed
        // by this statement, but they appear to remain open even after the resolver
        // group is closed.
        resolverGroup.close();

        Thread.sleep(1000);
    }
} finally {
    eventLoopGroup.shutdownGracefully().await();
}

Netty version
4.1.36 (going back to at least 4.1.32, and probably earlier than that)
JVM version (e.g. java -version)
$ java -version
openjdk version "11.0.1" 2018-10-16
OpenJDK Runtime Environment 18.9 (build 11.0.1+13)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.1+13, mixed mode)

OS version (e.g. uname -a)
$ uname -a
Darwin laminar.local 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64

Simplifying further, it turns out we don't actually need to try to resolve anything to demonstrate this issue; just getting a resolver will do the trick:
while (true) {
    final RoundRobinDnsAddressResolverGroup resolverGroup =
            new RoundRobinDnsAddressResolverGroup(NioDatagramChannel.class,
                    DefaultDnsServerAddressStreamProvider.INSTANCE);

    // UDP ports don't get opened unless we actually try to get a resolver;
    // in the real use case, this happens by way of bootstrap.connect(), but
    // I've opted to use this as a more concise example. I definitely recognize
    // the possibility that there may be nuanced differences between the real
    // use case and this minimal example, but hope it gets the point across.
    resolverGroup.getResolver(eventLoopGroup.next());

    // In a vacuum, I would expect any ports opened by the resolver to be closed
    // by this statement, but they appear to remain open even after the resolver
    // group is closed.
    resolverGroup.close();

    Thread.sleep(1000);
}

I've opened #9214 as a potential fix for this issue.


Uncaught TypeError: message.format is not a function

Using Ember-CLI 0.2.6
Just installed and followed the tutorial for adding messages and locale.
app.js file is editied as suggested
import Ember from 'ember';
import Resolver from 'ember/resolver';
import loadInitializers from 'ember/load-initializers';
import config from './config/environment';

var App;

Ember.MODEL_FACTORY_INJECTIONS = true;

App = Ember.Application.extend({
  modulePrefix: config.modulePrefix,
  podModulePrefix: config.podModulePrefix,
  Resolver: Resolver,
  ready: function () {
    var language = navigator.language || navigator.browserLanguage;
    this.intl.set('locales', [language, 'en']);
  }
});

loadInitializers(App, config.modulePrefix);

export default App;

locales/en.js file is there,
import Locale from 'ember-intl/models/locale';
import Locale from 'ember-intl/models/locale';

export default Locale.extend({
  locale: 'en',
  messages: {
    product: {
      info: '{product} Name',
      html: {
        info: '<strong>{product}</strong> Name'
      }
    }
  }
});

in my template
{{format-message (intl-get "messages.product")
     product='Sample'
}}

When I load the page, it shows the page but nothing is printed for format-message and I get Uncaught TypeError: message.format is not a function message in the console.

@aalasolutions Shouldn't it be like below using the info property?
{{format-message (intl-get "messages.product.info")
     product='Sample'
}}

Ohh, my bad I totally overlooked it. Closing the issue

Glad it was something simple =]


DMM Cast

Addon Manifest URL
https://debridmediamanager.com/api/stremio/default/manifest.json
Addon Description

Choose a Movie or TV Show to watch in Debrid Media Manager
Select a Torrent > click "👀 Look Inside" > click "Cast✨" button
📝 it will also open Stremio if you want to watch on the same device
Open the same Movie or TV Show in Stremio
Choose "Stream🪄"
Enjoy!🍿

Language of Content
Multilingual (Default)
Choose Labels

[ ] anime
[ ] asian drama
[ ] bollywood
[ ] cartoons
[X] debrid support
[ ] http streams
[ ] live tv
[ ] metadata
[ ] misc
[X] movies
[ ] music
[ ] nsfw
[ ] podcasts
[ ] radios
[ ] subtitles
[X] torrents
[X] tv shows
[ ] video games

Why is it unreachable if it works


Pipelining and basic http2

Adds support for pipelining and basic http2.
Leaving this here for comments.

@seemethere are you waiting for @channelcat to address @Lukasa's concerns before merging this, or just still reviewing? Besides that it has some conflicts now...

We should merge this are remove it from the 0.5.0 milestone

Any progress on this?

I have started on a PR to uvicorn that will implement h2 support with flow control https://github.com/encode/uvicorn/pull/73 (work in progress).
It relies on ASGI for the request handling, but the protocol implementation is similar enough to Sanic that the flow control logic could be reused or serve as a guide for this PR once completed.

Sanic is a great framework and we will be using it in production in a couple of months, but we need HTTP/2 support, does anyone why this PR is stalled since last year ? @channelcat ? @seemethere ?

@r0fls , can http2 suppor be merged to master ?

Hey everyone.... sorry for the stall out in this one. We're gearing up for a more minor release with cleanups for December, and will certainly work to tackle this in 2019. I think it is reasonable to aim for the 19.3 release given that the code is mostly complete, just needs to be updated and fully tested.

Everyone following this, there is a discussion on the community forums regarding adopting ASGI support, which would handle this using a third party package instead of with the internal server. Please join the conversation and make your opinions known.

I am placing this PR on hold. The likely outcome is that we will just close this one altogether as we add these features into the code base for the 19.03 release in an alternative fashion.

This was an accidental close on my part, but I don't think I'm going to re-open it. There's a lot of work that would need to be done to bring it in line with the current codebase, and the branch is basically stale at this point.

And, we will be addressing this in a different manner going forward.


[5.3] Allow callable classes as route actions to support ADR out of the box

@taylorotwell recently made an example implementation for ADR to work with the Laravel router (https://gist.github.com/taylorotwell/68f614deb9538f2e30108c2698266fda)
It works well and is pretty easy to use, however it can probably have an easier syntax - supported completely out of the box - requiring less characters on each action definition (which would fit in with the pretty syntax philosophy of Laravel i.m.o).
Defining an action can be as easy as:
$router->get('/', 'WelcomeAction');
$router->get('/', [
    'uses' => 'WelcomeAction'
]);

class WelcomeAction
{
    /**
     * @var WelcomeResponder
     */
    private $responder;

    /**
     * @param WelcomeResponder $responder
     */
    public function __construct(WelcomeResponder $responder)
    {
        $this->responder = $responder;
    }

    /**
     * @param SomeFormRequest $request
     * @return \Illuminate\Http\Response
     */
    public function __invoke(SomeFormRequest $request)
    {
        return $this->responder->handle();
    }
}

The Action should be a callable class (by using __invoke) and will have both constructor as method injection. In the method you can e.g. inject the FormRequest/Request and in the constructor the responder and domain service.
In the past the Router would throw an exception if you pass a string without a method (@), this is still the case, but is now only thrown if the class is not callable.
This implementation runs the action as a closure, meaning the callable action class is a POPO and won't call any controller/middleware methods on the class.
I targeted this to 5.3, not sure where you're at with adding new features to that release. It should be a non-breaking change as the original behaviour is still in place. It only adds functionality when the given action class is callable.

Interesting idea. :heart:


Add discussing-pre-0-21-0-bitcoin-core-vulnerability-disclosures review to brink/the-bitcoin-development-podcast

This PR adds discussing-pre-0-21-0-bitcoin-core-vulnerability-disclosures transcript review to the brink/the-bitcoin-development-podcast directory.

Hey! @markon1-a Thank you for your sustained commitment to reviewing transcripts and continuously improving the quality of your work. Kudos!
I have made some corrections that you can review in the editor or here on github.

Thanks for the corrections.


fix: typo on sast-snyk-check-oci-ta

If statement to select the media type had a typo, so the condition would be always false. This change would fix potential wrong media types.

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

Thanks, this change needs to go to, ideally first, to https://github.com/konflux-ci/build-definitions/blob/aa56da2399f37c4466a882e02f1bf566dd567631/task/sast-snyk-check/0.3/sast-snyk-check.yaml#L251 as well. Then run hack/generate-ta-tasks.sh to generate this file as it is auto-generated from it.


Fix and re-enable disabled shell_tests testcases

I disabled the tests
shell_tests
              ShellTest.CacheSkSLWorks
              ShellTest.FrameRasterizedCallbackIsCalled
              ShellTest.ExternalEmbedderNoThreadMerger
              ShellTest.OnPlatformViewDestroyWithoutRasterThreadMerger
              ShellTest.ReportTimingsIsCalledImmediatelyAfterTheFirstFrame
              ShellTest.DisallowedDartVMFlag
              ShellTest.SetResourceCacheSize
              ShellTest.SetResourceCacheSizeEarly
              ShellTest.SetResourceCacheSizeNotifiesDart
              ShellTest.Screenshot
              ShellTest.RasterizerScreenshot
              ShellTest.DiscardLayerTreeOnResize

on Fuchsia Emulator. To see the test fail, you can remove the test filters at
https://flutter.googlesource.com/recipes/+/refs/heads/master/recipes/femu_test.py#190
Then run the femu builder
led get-builder 'luci.flutter.try:Linux Fuchsia' | led edit -r femu_test | led edit-recipe-bundle | led launch

\cc @zanderso who should be the right person to reassign this bug to?

/cc @arbreng

We are tracking this internally at https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=73013

Re-opening, since it looks like this was only closed due to being improperly labeled an infra issue.


Add analytical distance.

Codecov Report

Merging #545 into master will decrease coverage by 0.86%.
The diff coverage is 32.43%.

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   91.41%   90.55%   -0.87%
==========================================
  Files          22       22
  Lines        1596     1609      +13
==========================================
- Hits         1459     1457       -2
- Misses        137      152      +15

Flag
Coverage Δ

#unittests
90.55% <32.43%> (-0.87%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lineage/states/StateDistributionGaussian.py
71.11% <20.00%> (-6.39%)
:arrow_down:

lineage/Analyze.py
70.58% <24.00%> (-4.84%)
:arrow_down:

lineage/states/StateDistributionGaPhs.py
82.90% <33.33%> (-1.31%)
:arrow_down:

lineage/states/StateDistributionGamma.py
96.11% <100.00%> (-2.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce23f6...7c11c1a. Read the comment docs.


Xnor/note names

branched off xnor/const_fn branch then continued from where you left off, though i had to change the math a little..
added const note values
will move the PR over to main if xnor/const_fn gets merged

rebased on main and cherry picked


Downgrade a per-block log to debug level

Motivation
zebrad logs by default at info-level, and we don't want an info-level log line for each of a few hundred thousand blocks.
Solution
Downgrade the info-level log to debug.
Review
@yaahc wrote this code. It's urgent, because it hides warnings and errors in the logs.
Follow Up
It would be nice to log new blocks only after we've synced to the tip - but that's not urgent at all. People can use metrics, or watch the block locator heights.

The code @yaahc wrote did this at debug level; I changed it to info-level logging on purpose, because I wanted the behavior that this PR removed.


Avoiding shadowing python list keyword with method

Description
We shouldn't shadow list or any python keywords. This changes the list method from MoleculeSetAPI to list_available.
Resolves #156
Status

[x] Ready to go

Codecov Report

Merging #157 (9105a01) into main (05f85ff) will not change coverage.
The diff coverage is 50.00%.


STORM-2779 NPE on shutting down WindowedBoltExecutor (1.x)

waterMarkEventGenerator could be null when timestamp field is not specified

+1


#634: Set line endings for *.asciidoc files to LF to make the content…

… comparing tests pass on Windows

Seems to make a lot of sense, thanks!


Add Control lock from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of Diazo, to add Control lock to CKAN.
Please direct questions about this pull request to Diazo.

Please delete.
I missed the checkbox when i created this, ControlLock is already on the ckan


Allow to process sender/receiver address in Policy

Hi,
I met an issue with ApacheArtemis bundled with Fabric8 - fabric8io/fabric8-ipaas#465
Artemis forces to use jms.queue. prefix and you already have similar issue #48 with ActiveMQ.
For rather small projects this might be not an issue, but for bigger project it is, because it blocks cluster-wide queue/topic naming.
What do you think about applying some policy-based processing to linkPolicy or address in createSender?

@wingedfox The solution was actually to move parseAddress to the base Policy itself (see here). You can modify that in your Policy subclass now to handle whatever special cases you run into.
It does appear that maybe you're specifically asking about parsing link addresses in particular, in which case it might be a sane solution to move that to the Policy as well. Would that satisfy your use case here?

@mbroadst Solution works with an url, not queue/topic name referred as address in
createSender - https://github.com/noodlefrenzy/node-amqp10/blob/master/lib/amqp_client.js#L186
createReceiver - https://github.com/noodlefrenzy/node-amqp10/blob/master/lib/amqp_client.js#L253
I am looking for a way to process link address in order to have a policy with queue/topic name mangling for different MQ implementations. Today I have to do the same in the business logic.
AMQPClient.createSender(process.env.MQ_Q_PREFIX + 'queue.name');

@wingedfox right, and those are using this method. I'm proposing we move that method to Policy (similar to parseAddress), so that users can implement their own logic. Does that sound reasonable?

Sure it is.

@wingedfox okay I've pushed the fix in d1ae649, perhaps you can give it a try? The idea here would be that you have something like:
let policy = new Policy();
policy.parseLinkAddress = function(address) {
   let result = Policy.prototype.parseLinkAddress(address);
   result.name = 'something-else';
   return result;

   // alternatively you can completely bypass the default implementation of `Policy`
}

let client = new amqp.Client(policy);

Thanks, it works pretty well, but is there a good way to find out whether we're creating sender/receiver for queue or topic?
Also, it worth to rewrite Policies using classes and utilize parent methods from extended policies instead of binding to the prototypes. Guess, I'll make a PR with such changes.

@wingedfox the same method is called for both sender and receiver, can you explain the use case behind needing to know more context for address parsing?
Also, the policies are using classes (insofar as javascript supports them). The above example, extending parseLinkAddress is how you override methods in "subclasses" in javascript.

@mbroadst, the question was about the distinction between queues and topics from within the link parser.
About the classes, it's all about the syntax sugar.

@wingedfox I still don't understand the question about queues and topics, could you please elaborate.
I'm also not clear what you're getting at with classes? Do you mean using ES6 classes? There has been discussion of an ES6 port, however we still have a large legacy user base that require support for node 0.10 so the transition has not begun yet.

@mbroadst
From my point of view, it is a good idea to have single MQ connection in an application and this leads to a problem: how to find out whether sender (or publisher) is going to be connected to a queue or topic from within a policy.
This question comes from the initial requirement set by Apache Artemis to explicitly use topic and message prefixes during link set up.
There's a simple way: make 2 connections, one for queues and one for topics and assign different policies, e.g. ArtemisQueuePolicy and ArtemisTopicsPolicy and statically append corresponding prefixes, but it is not the 'best practice' at all.

@wingedfox I feel like we are caught in an XY problem here. I agree that having a single connection is the ideal path for an application (and this is indeed the intent put forth in the spec, for most cases). What I am still unclear of is what your actual problem is when parsing the link address, can you please provide some code to further explain your use case?
Specifically: why is it important to you from a policy/client perspective to know whether the user is going to be connected to a queue or a topic? Shouldn't this information be known from the user's side? IIRC the ActiveMQ/Artemis connection strings look like topic://some.topic, queue://some.queue, so you would have that information in parseLinkAddress. Furthermore, AMQP 1.0 doesn't care about topic vs queue, they are all just links.


cpuarch based cloud matching can go away

was a holdover from Nimbus
DEBUG - Cleanup - #1 network and cpuarch - No cluster fits job
condor.heprc.uvic.ca#3.2#1465425912 ignoring
Looks like it's still being used in some way

Or not, was just an old log message, was only matching based on network
Good chance to remove any remaining references to the now unused cpuarch and hypervisor options though


BUG#1242 - Cleanup login state, notifications fill full viewport

closes #1242
BEM was negating a great deal of patternfly styles we were missing here, pulled it!
what we look like now

cc @serenamarie125
(I know this doesn't look exactly pf login, but we can discuss, open other issues for those changes)

@AllenBW The major issue with the inline notification was the color ...

I wouldn't have thought the inline notification should span the whole width.  In the PF case, it is because there is more content on the screen.

So the notification style change you are requesting is better taken up with the patternfly-sass people, as styles from there are what is overriding the traditional notification alert (these lines specifically)
We can of course override locally until a time when the repo is updated

I suspect this issue likely plagues ops as well, so changing the patternfly-sass class would benefit both UIs  @chriskacerguis @serenamarie125 @ohadlevy thoughts?

Initial comment update to reflect requested changes ☝

ACK - this seems to be related to pf-sass - it was also fixed on foreman at
https://github.com/theforeman/foreman/pull/4947
On Thu, Nov 16, 2017 at 2:29 PM, Allen Wight<EMAIL_ADDRESS>wrote:

So the notification style change you are requesting is better taken up
with the patternfly-sass people, as styles from there are what is
overriding the traditional notification alert (these lines specifically)
https://github.com/patternfly/patternfly-sass/blob/master/assets/stylesheets/patternfly/_login.scss#L52-L55
We can of course override locally until a time when the repo is updated
[image: screen shot 2017-11-16 at 7 27 32 am]
https://user-images.githubusercontent.com/6640236/32891197-b39116a6-ca9f-11e7-8f4d-9c082eb92853.png
I suspect this issue likely plagues ops as well, so changing the
patternfly-sass class would benefit both UIs @chriskacerguis
https://github.com/chriskacerguis @serenamarie125
https://github.com/serenamarie125 @ohadlevy
https://github.com/ohadlevy thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq-ui-service/pull/1245#issuecomment-344908866,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABOxxvgnQ41Rz4RHUHV15yDpipWnCAJks5s3CqwgaJpZM4Qfdup
.

@ohadlevy yeah in my previous previous comment i point out the specific offending lines, foreman/us same approach to fix, temporary overrides

@chriskacerguis @serenamarie125 so is this goooood to get in?

@AllenBW I'm good with it.  I think @serenamarie125 is in a workshop all week; so we'll just wait.


Added Breast_cancer_detection.ipynb

#13 fixed
Added Breast cancer detection model.
Related Issue
Closes: #13
Describe the changes you've made
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots(optional)

Original
Updated

original screenshot
updated screenshot

Could you please add your files in

Projects folder

Prediction folder(create one)

your files

I added in machine-learning/Project folder...

I added in machine-learning/Project folder...

You need to create Problem name folder/your file


feat: Italian Transaltion

Is your feature request related to a problem? Please describe.
Generally the more docs languages you have, the more accesible it is to developers.
Describe the solution you'd like to see
Translating the docs to Italian
Describe alternate solutions
I don't know, maybe Google Translate? But that would cause some confusion and just be a hassle
Additional information
No response

Are you willing to contribute an Italian translation? None of the maintainers are Italian so we can't translate or review a translation. We depend on the community for that.

Yes! I'm going to start working on it.

Google Translate is great for quick translation, but you also need to read the Google Translate translation and correct any technical terms.

Google Translate is great for quick translation, but you also need to read the Google Translate translation and correct any technical terms.

I will se if this works

Julius Marminge gave me these instructions, they might be useful.
1. make a copy of pages/en to pages/it
2. File a draft PR to let others know you're working on it
3. One by one, translate the docs, add lang: it in the frontmatter of the translated pages

There'll be some other stuff required with the sidebar but that doesn't yet work so we'll have to get back to you on that one.

It is now merged. New link: https://github.com/t3-oss/create-t3-app/blob/next/www/TRANSLATIONS.md

Nice to see the Italian translation getting started!
I'm going to close this to help clean out our issues a bit, please continue discussions in the linked PR :)


Add bootstrap file handling

This PR is related to functionality mentioned in Issue #549 about executing a bootstrap file when any command is called.

:+1: this would be very handy

Any chance of this getting merged? Looks like the Scrutinizer build failed for no good reason...

You can use a config file as a bootstrap file.

Um, correct me if I'm wrong but the configuration files are yaml files, not PHP and those don't allow loading or calling out to external scripts.

@enygma, you can use a ".php" file for configuration, here you can do you "bootstrap" thing, please check the docs you can do what you want in this file and then "return" a Phinx configuration.

@enygma please refer to the docs. PHP-based configs are now documented and should work for you.

@robmorgan thanks for the update! I'll check into it.


JS: support relational indexof comparison sanitizers

This PR adds support for the relational variant of the whitelist.indexOf(x) !== -1-sanitizer.
Opinions are requested:

should this be merged with the ordinary IndexOfSanitizer?
should we start on a local range analysis rather than us this ad-hoc numeric reasoning?

(change notes are still missing)

For another WIP query I wrote the following helpers to deal with the symmetry problem:
class Comparison ... {
  predicate isIntComparison(Expr arg, string operator, int value) {
    arg = getLeftOperand() and
    operator = getOperator() and
    value = getRightOperand().getIntValue()
    or
    arg = getRightOperand() and
    operator = commute(getOperator()) and
    value = getLeftOperand().getIntValue()
  }
}
string commute(string operator) {
  if operator = "==" or operator = "===" or operator = "!=" or operator = "!==" then
    result = operator
  else if operator = "<" then
    result = ">"
  else if operator = "<=" then
    result = ">="
  else if operator = ">" then
    result = "<"
  else if operator = ">=" then
    result = "<="
  else
    none()
}

I was going to add them along with that query, but if you could make use of them now, feel free to include it in this PR.

The suggestions has been implemented.
This is covered in the change notes by: "The taint tracking library now recognizes additional sanitization patterns.".


feat(SinglePage): Publish updates for 1 page only

Publish the currently open page only. This will still create blank pages for any other pages not created yet to support Wikilinks but will not publish their content just an empty body saying "Page not published yet".

super - works great for my use case

Glad it helps. Thanks for testing everything 😀. If you have any other features that would help please log them as issues and I will see what I can do.
Released this as v1.4.0.


Undeclared dependency on setuptools

This package appears to have an undeclared dependency on setuptools. This may not affect most setups but it does affect someone loading this package via Nix.
Example:
$ nix run '(with import <nixpkgs> {}; python3.withPackages (pkgs: [ pkgs.ftfy ]))' -c python3
Python 3.7.6 (default, Mar 11 2020, 12:53:39)
[Clang 7.1.0 (tags/RELEASE_710/final)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ftfy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nix/store/yss5qkwzvh8cgiz5fawf5mhjvj6cmvn8-python3-3.7.6-env/lib/python3.7/site-packages/ftfy/__init__.py", line 11, in <module>
    from ftfy import fixes
  File "/nix/store/yss5qkwzvh8cgiz5fawf5mhjvj6cmvn8-python3-3.7.6-env/lib/python3.7/site-packages/ftfy/fixes.py", line 11, in <module>
    from ftfy.badness import text_cost
  File "/nix/store/yss5qkwzvh8cgiz5fawf5mhjvj6cmvn8-python3-3.7.6-env/lib/python3.7/site-packages/ftfy/badness.py", line 9, in <module>
    from ftfy.chardata import chars_to_classes
  File "/nix/store/yss5qkwzvh8cgiz5fawf5mhjvj6cmvn8-python3-3.7.6-env/lib/python3.7/site-packages/ftfy/chardata.py", line 12, in <module>
    from pkg_resources import resource_string
ModuleNotFoundError: No module named 'pkg_resources'

Using nix run '(with import <nixpkgs> {}; python3.withPackages (pkgs: [ pkgs.ftfy pkgs.setuptools ]))' -c python3 instead works.

Thanks Lily -- I hadn't previously known about how Nix manages Python packages, or that setuptools could install a package into an environment where setuptools itself is unavailable.
This made me think that it's as good a time as any to just remove the use of pkg_resources, so my proposed solution is in #152.

This is fixed by now.


Buttons not visible

Hi Andrey,
I switched to the latest version and noticed that the buttons are not visible any more. They are still there and function if I click on them, but they are not visible. Here you can find a screenshot.
If you have any idea, where the problem might be, I could also contribute on fixing.

Hi! You have to import "vue-pdf-app/dist/icons/main.css";
For breaking changes refer CHANGELOG.md

Thanks! You are doing a great work btw!

Thank you!