opennebula says the disk image is not in qcow2 format but it is.

Author Name: Gunwoo Gim (Gunwoo Gim)
Original Redmine Issue: 4835, https://dev.opennebula.org/issues/4835
Original Date: 2016-09-29

OpenNebula says the disk image is not in qcow2 format but it is. it is in qcow2 format; I had made it by issuing a 'qemu-img convert' command
oneadmin@0-h0:~$ oned --version

Copyright 2002-2016, OpenNebula Project, OpenNebula Systems
OpenNebula 5.0.2 is distributed and licensed for use under the terms of the
Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0).

/var/log/one/oned.log :
(After trying 'onetemplate instantiate win-2k8-r2-contextualized --name win2k8r2-qcow2')

Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: LOG I 60 Command execution fail: cat << EOT | /var/tmp/one/vmm/kvm/deploy '/var/lib/one//datastores/101/60/deployment.0' '<IP_ADDRESS>' 60 <IP_ADDRESS>
Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: LOG I 60 error: Failed to create domain from /var/lib/one//datastores/101/60/deployment.0
Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: LOG I 60 error: internal error: process exited while connecting to monitor: 2016-09-29T14:45:40.173804Z qemu-system-x86_64: -drive file=/var/lib/one//datastores/101/60/disk.0,if=none,id=drive-virtio-disk0,format=qcow2,cache=none: could not open disk image /var/lib/one//datastores/101/60/disk.0: Image is not in qcow2 format
Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: LOG I 60
Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: LOG E 60 Could not create domain from /var/lib/one//datastores/101/60/deployment.0
Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: LOG I 60 ExitCode: 255
Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: LOG I 60 Failed to execute virtualization driver operation: deploy.
Thu Sep 29 23:45:40 2016 [Z0][VMM][D]: Message received: DEPLOY FAILURE 60 Could not create domain from /var/lib/one//datastores/101/60/deployment.0

oneadmin@0-h0:~$ oneimage show win2k8r2-160926-qcow2

IMAGE 29 INFORMATION
ID             : 29
NAME           : win2k8r2-160926-qcow2
USER           : oneadmin
GROUP          : oneadmin
DATASTORE      : ids0000000000
TYPE           : OS
REGISTER TIME  : 09/29 13:12:46
PERSISTENT     : No
SOURCE         : /var/lib/one//datastores/100/43f1b10c584a14eed95a22290b2bd757
PATH           : /var/lib/one/safe/win2k8r2-20160927.qcow2
FSTYPE         : qcow2
SIZE           : 40G
STATE          : rdy
RUNNING_VMS    : 0
PERMISSIONS
OWNER          : um-
GROUP          : ---
OTHER          : ---
IMAGE TEMPLATE
DESCRIPTION="Windows Server 2008 R2 20160926-qcow2"
DEV_PREFIX="hd"
DRIVER="qcow2"
VIRTUAL MACHINES

oneadmin@0-h0:~$ qemu-img info /var/lib/one/datastores/100/43f1b10c584a14eed95a22290b2bd757

image: /var/lib/one/datastores/100/43f1b10c584a14eed95a22290b2bd757
file format: qcow2
virtual size: 40G<PHONE_NUMBER>0 bytes)
disk size: 27G
cluster_size: 65536
Format specific information:
compat: 1.1
lazy refcounts: false

oneadmin@0-h0:~$ onetemplate show win-2k8-r2-contextualized

TEMPLATE 15 INFORMATION
ID             : 15
NAME           : win-2k8-r2-contextualized
USER           : oneadmin
GROUP          : oneadmin
REGISTER TIME  : 07/15 17:36:03
PERMISSIONS
OWNER          : um-
GROUP          : ---
OTHER          : ---
TEMPLATE CONTENTS
CONTEXT=[
FILES_DS="$FILE[IMAGE_ID=13]",
FORGODSAKE=""nomnomnom"",
HELLO_WORLD="$HELLO_WORLD",
NETWORK="YES",
REPORT_READY="YES",
SSH_PUBLIC_KEY="$USER[SSH_PUBLIC_KEY]",
START_SCRIPT="#!/bin/sh
echo 'ss' > /ss.txt
export TESTASAKE='thanks'
",
TOKEN="YES" ]
CPU="0.5"
CPU_COST="0.05"
DISK=[
CACHE="none",
DEV_PREFIX="vd",
DRIVER="qcow2",
IMAGE="win2k8r2-160926-qcow2",
IMAGE_UNAME="oneadmin",
SIZE="40960" ]
DISK_COST="0.00000005"
FEATURES=[
ACPI="yes",
PAE="yes" ]
GRAPHICS=[
LISTEN="<IP_ADDRESS>",
RANDOM_PASSWD="YES",
TYPE="VNC" ]
HYPERVISOR="kvm"
INPUT=[
BUS="usb",
TYPE="tablet" ]
LOGO="images/logos/windowsxp.png"
MEMORY="512"
MEMORY_COST="0.0000075"
NAME="win-2k8-r2-contextualized"
NIC=[
MODEL="virtio",
NETWORK="private_net-0-0-1",
NETWORK_UNAME="oneadmin",
SECURITY_GROUPS="0" ]
NIC_DEFAULT=[
MODEL="virtio" ]
OS=[
BOOT="disk0" ]
RAW=[
DATA="

",
TYPE="kvm" ]
SCHED_DS_REQUIREMENTS="NAME="sds0000000000""
USER_INPUTS=[
CPU="M|range-float||0.1..4.0|0.5",
HELLO_WORLD="M|list|for testing purposes|hi,hey,how are you,what'sup,how do you do,how's it going|hi",
MEMORY="M|range||512..8192|2048",
VCPU="M|range||1..4|1" ]

I believe there was another instance of this bug happened in the past: http://dev.opennebula.org/issues/4624

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2016-10-10T16:56:03Z

The error message is from libvirt/qemu, it has nothing to do with opennebula. Maybe you need to restart the VM? You may even try to create the VM manually with the generated deployment file (i.e. login in the node and execute virsh create deployment.0)

Original Redmine Comment
Author Name: Gunwoo Gim (Gunwoo Gim)
Original Date: 2016-10-17T13:44:15Z

It seems like OpenNebula LVM datastore mounts images in raw format

oneadmin@0-h0:~$ onevm list
ID USER     GROUP    NAME            STAT UCPU    UMEM HOST             TIME
52 oneadmin oneadmin win2k8r2-160926 poff  0.0      0K 116.193.90  20d 06h39
64 oneadmin oneadmin win2k8r2-qcow2  fail    0      0K 116.193.90   0d 04h47
oneadmin@0-h0:~$ su - root
root@0-h0:~# less /var/lib/one//datastores/101/64/deployment.0

root@0-h0:~# ls -l /var/lib/one//datastores/101/64/disk.0
lrwxrwxrwx 1 oneadmin oneadmin 27 Oct 17 17:56 /var/lib/one//datastores/101/64/disk.0 -> /dev/vg-one-101/lv-one-64-0
root@0-h0:~# qemu-img info /dev/vg-one-101/lv-one-64-0
image: /dev/vg-one-101/lv-one-64-0
file format: raw
virtual size: 40G<PHONE_NUMBER>0 bytes)
disk size: 0

Best Wishes
From Korea

Original Redmine Comment
Author Name: Edouard Bourguignon (Edouard Bourguignon)
Original Date: 2016-10-20T12:55:35Z

Same bug here on OpenNebula 5.2. Add to convert the image to boot the VM again. This only happens on attached disks.

Original Redmine Comment
Author Name: Daejuan Jacobs (Daejuan Jacobs)
Original Date: 2017-04-10T02:14:34Z

This looks like it could be related #3705
I have the same issue on 5.2 regardless if the image is uploaded by me or from the marketplace to my ceph datastores.


Vertical overscroll glow in animation demo

Not sure if this is a thing from the framework, or a feature of the demo?
Notice that an overscroll glow blue bar appears on the right-hand side of the demo.
Here's a video: https://youtu.be/2zFcRW-qyqY
Screenshot:

@HansMuller would know.

It's a feature of the demo which is horizontally scrollable. That said, this might be a situation where the built in horizontal overscroll effects aren't desirable.

Looks like this isn't specific to the animation demo. I tried triggering the glow from the Colors tabs:

Here's what the Newstand app does. Notice their vertical glow is curved:

This likely is just https://github.com/flutter/flutter/issues/8523 ?

This is fixed.


feat: update with details for deploying to Netlify Functions

This is a small update to include Netlify in the section of the docs for the proper cert to run PlanetScale on Netlify Functions.

@jlengstorf thank you so much for adding this! I was actually trying to figure out the file path last week for Netlify, but didn't finish figuring it out.


Cannot Action groups and lights

Hello,
i just downloaded 1.3.4 and i have the same "SyntaxError: Unexpected token =" Problem like vBiggles.
I only can action scenes, but no lights and groups.
I updated NPM to Version 5.6.0, but doesn't help.
Can you or vBiggles please help me with the Problem and describe your solution? I'm not so firm with Linux, NPM and the details of Node-Red
thx

Same problem here. Also when I use the nodes for the lights I can't control them from the hue app anymore. When I remove the nodes from my flows everything works well. A solution would be great! I'm looking forward to using all the nodes!
TIA!

The same problem for me...

Can somebody share a sample flow?
I am trying to reproduce this error but for me everything is looking good?!

Problem with NodeRed in docker....hue magic don't work and zwave / harmony, etc don't install !
On RPI, it works !

So it seems that this bug is not HueMagic related? Is that correct?

Correct !

I'm running node red on a RPI. I installed Raspbian with the NOOBS install (https://www.raspberrypi.org/downloads/noobs/). As far as I'm aware I never installed Docker...

When I deploy I get this message: "
17-2-2018 22:00:24node: Wandlamp Woonkamer
msg : error
"SyntaxError: Unexpected token =""
This is a sample flow:
[{"id":"bfbbd15b.15837","type":"hue-light","z":"18365d53.db6a5b","name":"Wandlamp Woonkamer","bridge":"ca4308fc.cc49d8","lightid":"7","x":350,"y":160,"wires":[["615ee498.af99dc"]]},{"id":"615ee498.af99dc","type":"debug","z":"18365d53.db6a5b","name":"","active":true,"console":"false","complete":"payload","x":580,"y":160,"wires":[]},{"id":"61198a7.c9fc8f4","type":"inject","z":"18365d53.db6a5b","name":"","topic":"","payload":"true","payloadType":"bool","repeat":"","crontab":"","once":false,"x":130,"y":140,"wires":[["bfbbd15b.15837"]]},{"id":"b513d540.1d1348","type":"inject","z":"18365d53.db6a5b","name":"","topic":"","payload":"false","payloadType":"bool","repeat":"","crontab":"","once":false,"x":130,"y":180,"wires":[["bfbbd15b.15837"]]},{"id":"ca4308fc.cc49d8","type":"hue-bridge","z":0,"name":"Philips hue","bridge":"<IP_ADDRESS>","key":"TJ18GnK13njK2w-iz8fqI7yf9cqwnHhV4NJIPyqf","interval":"3000"}]

Hi I got the same issue. Would you please help? Since updated to 1.41 cannot control any light.
5 Mar 12:40:53 - [error] [hue-light:8353b695.130868] SyntaxError: Unexpected token =
I have tried to remove and install huemagic again but this did not help.
More info
Starting as a systemd service.
Started Node-RED graphical event wiring tool..
5 Mar 12:39:46 - [info]
Welcome to Node-RED
5 Mar 12:39:46 - [info] Node-RED version: v0.17.5
5 Mar 12:39:46 - [info] Node.js  version: v4.4.5
5 Mar 12:39:46 - [info] Linux 4.1.7-v7+ arm LE
5 Mar 12:39:49 - [info] Loading palette nodes
5 Mar 12:39:57 - [info]<EMAIL_ADDRESS>(/home/pi/.node-red/node_modules/node-red-contrib-pimatic/pimatic) started
5 Mar 12:39:59 - [info] Dashboard version 2.8.2 started at /ui
5 Mar 12:40:04 - [info] Settings file  : /home/pi/.node-red/settings.js
5 Mar 12:40:04 - [info] User directory : /home/pi/.node-red
5 Mar 12:40:04 - [info] Flows file     : /home/pi/.node-red/flows_raspberrypi.json
5 Mar 12:40:04 - [info] Server now running at http://<IP_ADDRESS>:1880/
5 Mar 12:40:04 - [info] Starting flows
5 Mar 12:40:05 - [info] Started flows
5 Mar 12:40:53 - [info] Stopping flows
5 Mar 12:40:53 - [info] Stopped flows
5 Mar 12:40:53 - [info] Starting flows
5 Mar 12:40:53 - [error] [hue-light:8353b695.130868] SyntaxError: Unexpected token =
5 Mar 12:40:53 - [info] Started flows

I have the same issue - both light and group have the same error message, "SyntaxError: Unexpected token =m ". I have also removed and re-installed hue magic but no change. Suggestions?

For me, it looks like you're using an older version of Node.js.
Unfortunately HueMagic is only optimized and well tested for Node.js 8.x and 9.x.
Can you consider upgrading your node.js version to 8+?


Ensure arguments for assert.Equal are always the right way around

I think we presently have an unholy mix of
assert.Equal(t, expected, got)
and
assert.Equal(t, got, expected)

It should always be assert.Equal(t, expected, got)


Alternative for non-ivy lib ngx-web-storage

Feature
We currently use ngx-web-storage which doesn't seem to be actively maintained, has only 1 github star, and could be problematic when angular removes ngcc with v16 as there's a warning which claims that it's a non-ivy lib (see also https://github.com/angular/angular-cli/issues/24797). Either use localstorage w/o 3rd party libs (seems to be easy enough, see refs), or use another lib
URL References

Manage local storage w/o additional libs
https://github.com/tim-kuteev/ngx-web-storage (current lib)
https://github.com/PillowPillow/ng2-webstorage ( potential alternative )

fixed with https://github.com/tillkuhn/angkor/pull/595 (last option)


Filter failed with error 11

Exception: Unable to parse xml from `https://www.looopings.nl/rss/` Input is not proper UTF-8, indicate encoding !
Bytes: 0xC3 0x2E 0x2E 0x2E
 in lib/FeedExpander.php line 122

index.php(7): RssBridge->main()
lib/RssBridge.php(18): RssBridge->run()
lib/RssBridge.php(102): DisplayAction->execute()
actions/DisplayAction.php(23): DisplayAction->createResponse()
actions/DisplayAction.php(134): FilterBridge->collectData()
bridges/FilterBridge.php(168): FeedExpander->collectExpandableDatas()
lib/FeedExpander.php(122)

Query string: action=display&bridge=FilterBridge&url=https%3A%2F%2Fwww.looopings.nl%2Frss%2F&filter=.*Efteling.*&filter_type=permit&case_insensitive=on&target_title=on&length_limit=-1&format=mrss
Version: dev.2023-07-11 (git.master.ce72503)
Os: Linux
PHP version: 8.0.27

It looks like rss-bridge is not able to parse the feed properly, but my feed reader is able to read it just fine. I am not sure why it is failing.

$ file index.html
index.html: XML 1.0 document, ISO-8859 text
$ head -n1 index.html
<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"><channel>

So... can I solve this or is it a problem with the feed?

yeah this can be solved with utf8_encode() but need to find a useful location for it

here is a temp fix
diff --git a/lib/FeedExpander.php b/lib/FeedExpander.php
index c91586d7..f9b57e06 100644
--- a/lib/FeedExpander.php
+++ b/lib/FeedExpander.php
@@ -109,7 +109,7 @@ abstract class FeedExpander extends BridgeAbstract
         libxml_use_internal_errors(true);
         // Consider replacing libxml with https://www.php.net/domdocument
         // Intentionally not using the silencing operator (@) because it has no effect here
-        $rssContent = simplexml_load_string(trim($content));
+        $rssContent = simplexml_load_string(trim(utf8_encode($content)));
         if ($rssContent === false) {
             $xmlErrors = libxml_get_errors();
             foreach ($xmlErrors as $xmlError) {

The feed was fixed after I sent them an email.
Might still be worth it to have this fix in place, though.

true. will make a not on that


Can't Remove an attached image after upgrade to 3.6

I have various models with file attachments using this module.  It's all been working for a while.
On updating the project with composer to the latest versions of cake & moudles, I can no longer delete file attachments.
Model Set up
public function initialize(array $config)
  {
   $this->hasMany('Levels', ['sort' => 'sort_order']);
   $this->addBehavior('Josegonzalez/Upload.Upload', [
    'proof' => [
        'path'  => 'webroot{DS}uploads{DS}media{DS}awardz',
        'fields' => [
          'size'  => 'proof_size',
          'dir'   => 'proof_dir',
          'type'  => 'proof_type'
        ]
    ],
    ]);
  }
public function validationDefault(Validator $validator)
  {
$validator->provider('upload', \Josegonzalez\Upload\Validation\UploadValidation::class);
    return $validator

     ->allowEmpty('proof')
     ->add('proof', 'fileBelowMaxSize', [
         'rule' => ['isBelowMaxSize', 4194305],
         'message' => 'Max file size is 4MB',
         'provider' => 'upload'
     ])
     ->add('proof', 'file', [
        'rule' => ['mimeType', ['image/jpeg', 'image/png']],
        'message' => 'File extension is not supported',
       ]
     );
]

Then in the controller, if the field to remove the attachment is set, I do this:

if (!empty($this->request->data['AttachmentStripproof'])){
				$award->proof = "";
				$award->proof_size = 0;
				$award->proof_dir = "";
				$award->proof_type = "";
				$file_path = WWW_ROOT . '/uploads/media/awardz/' . $this->request->data['AttachmentStripproof'];
				$file = new File($file_path);
				$file->delete();
			}
			if ($this->Awards->save($award)) {

I don't get any errors, the fields are set to the values above, except for the proof field, which keeps the filename value, which obviously I don't want.

if i comment out lines
https://github.com/josegonzalez/cakephp-upload/blob/master/src/Model/Behavior/UploadBehavior.php#L84-L87
then the plugin works for me, but obviously that's not the way to do it.  what do i need to add to my setup to be able to remove, as well as add, attachments?
Thanks.

so i set this:
  'restoreValueOnFailure' => false

And now the whole thing works.  But that feels a bit hacky.  How should I set things up so i can delete attachments properly?  Am I right that file deletion is now supported? so i should remove my deletion code and use that.  how?

Did you upgrade this plugin as well, or just the core?

Upgraded everything, including this plugin with composer update.
"version": "3.6.2",

I am having this issue as well.

Can you debug($this->data) for me?

Sorry for popping up here uninvited, but by looking at your code:
if (!empty($this->request->data['AttachmentStripproof'])){
    …
    $file_path = WWW_ROOT . '/uploads/media/awardz/' . $this->request->data['AttachmentStripproof'];

It looks to me like you have a severe security problem in your code. If I am not mistaken, an attacker could delete other files of their choice with a malformed request.

I just happened to stumble over a similar issue. In my case I am duplicating rows and the filename field would get lost during save. The reason is that when restoreValueOnFailure is set (the default), the field is set to not dirty. This leads the ORM to not persist/update the field in the database.

You could work around this by setting an extra field like attachment_deleted to 1 when you delete an attachment instead of emptying the fields (which i think is not the right way to do it).


chore: manual pr build script

Description of changes
Ability to kick off PR run manually.
yarn cloud-pr

Issue #, if available

Description of how you validated changes
$ yarn cloud-pr
What is your PR number ? 13070
Did you submit PR from fork (y/n)? y
PIN for sobkamil:
Press the button on your U2F token...
Successfully authenticated using u2f, session cookie saved in /Users/sobkamil/.midway/cookie
Successfully signed SSH public key /Users/sobkamil/.ssh/id_ecdsa.pub. The SSH certificate was saved in /Users/sobkamil/.ssh/id_ecdsa-cert.pub
2023/08/03 13:26:54 This profile appears to be ada managed, so there is no need to explicitly update.
2023/08/03 13:26:54 Your credentials will be pulled automatically, so you may continue on with your workflow.
https://us-east-1.console.aws.amazon.com/codesuite/codebuild/671107461633/projects/AmplifyCLI-PR-Testing/batch/AmplifyCLI-PR-Testing:732a33ba-6411-4937-93f7-2e6c2540b1de?region=us-east-1

Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #13070 (052e988) into dev (ec9a2ba) will increase coverage by 48.56%.
Report is 291 commits behind head on dev.
The diff coverage is 59.37%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##              dev   #13070       +/-   ##
===========================================
+ Coverage    0.00%   48.56%   +48.56%
===========================================
  Files        1296      848      -448
  Lines      149743    38131   -111612
  Branches     1296     7797     +6501
===========================================
+ Hits            0    18519    +18519
+ Misses     148447    18022   -130425
- Partials     1296     1590      +294

Files Changed
Coverage Δ

...rmation/auth-stack-builder/auth-stack-transform.ts
91.30% <0.00%> (+91.30%)
:arrow_up:

...tack-builder/auth-user-pool-group-stack-builder.ts
51.72% <ø> (+51.72%)
:arrow_up:

...h-stack-builder/user-pool-group-stack-transform.ts
94.59% <0.00%> (+94.59%)
:arrow_up:

.../src/provider-utils/awscloudformation/constants.ts
100.00% <ø> (+100.00%)
:arrow_up:

...e-walkthrough-types/awsCognito-user-input-types.ts
100.00% <ø> (+100.00%)
:arrow_up:

...vice-walkthrough-types/cognito-user-input-types.ts
100.00% <ø> (+100.00%)
:arrow_up:

...y-category-function/src/commands/function/build.ts
0.00% <0.00%> (ø)

...ify-category-function/src/events/prePushHandler.ts
33.33% <0.00%> (+33.33%)
:arrow_up:

...ider-utils/awscloudformation/utils/layerHelpers.ts
21.80% <0.00%> (+21.80%)
:arrow_up:

...er-utils/awscloudformation/utils/storeResources.ts
30.38% <ø> (+30.38%)
:arrow_up:

... and 57 more

... and 1244 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Failed to get extensions list

Steps to reproduce
Every time i try to install a new manga extension
I won't load the list
Expected behavior
The screen still empty and give me ( failed to get extensions list)
Actual behavior
It should show me the extension but it doesn't show up
Crash logs
No response
Aniyomi version
<IP_ADDRESS>
Android version
12
Device
Samsung galaxy m52
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

I have the same problem,
It started accruing after I updated all manga extensions in tachiyomi j2k.
They seem to show up fine in j2k but it refuses to in aniyomi.

Same issue after i updated extensions by tachiyomi

Same issue, but if you clean install the app all the new updated extensions disappear

yup

Same problem

Any updates

Same issue after Updating extensions in tachiyomi

Que hago para resolver el problema???

Updating my extensions using another tachiyomi client made all of them disappear.

For now you can use other Tachiyomi fork untill this one gets updated, is not the end of the world

I installed aniyomi beta and it works alright
The performance is kinda terrible and there's frequent crashes since it's an experimental version but the extentions work fine at least

I am also experiencing this issue on my Tachiyomi SY too. I wanted to install a new extension and it told me failed to get extensions list. What do I do?

Probably won't be the fix for all but I got this error when trying to update via data connection (which I'd forgotten I'd restricted Tachiyomi's access to). So basically I'm saying if you've googled this issue do a once over of your network connection because it could be that. Maybe worth looking at potentially giving a more specific error message for this case? Although I admit my situation was a pretty niche scenario.

نرجو حل المشكله

Duplicate of #844

i got the solution
add this repo to get all the extensions
https://raw.githubusercontent.com/keiyoushi/extensions/repo/index.min.json

@Dt7768181 Do not share third party extensions on github


improved readme by adding deps library statement

pretty much self-descriptive I guess

Coverage remained the same at 92.308% when pulling c2d53bb59f578b0b87971efde34819a152435f7a on philippneugebauer:master into 02a1e1aedf434c125e48a4556fe4686fa653e9a2 on victorolinasc:master.

Thanks!


Vertical white space is not configurable

There's a fixed 1 unit of white space added above and below bar codes. I'd love to be able to adjust this; seems like it would be great as a writer option.
Should be simple and quick to implement.

The extra space is added due to the 2.0 offset in line https://github.com/WhyNotHugo/python-barcode/blob/83a0b4e87755f8dcb22c9cf35c52f6f3ae7a6993/barcode/writer.py#L116
Because of the offset, there is a hardcoded half offset in https://github.com/WhyNotHugo/python-barcode/blob/83a0b4e87755f8dcb22c9cf35c52f6f3ae7a6993/barcode/writer.py#L205
I believe this could be a new Writer option (extra_vertical_space) so I don't break backward compatibility.


NSException details should be available in debugger

NSExceptions often contain valuable information that can help tracking down issue. However, when an NSException is raised in the Visual Studio debugger, we currently only a boilerplate exception message like the following:

Exception thrown at 0x743FDAE8 in MyApp.exe: Microsoft C++ exception: UNSException at memory location 0x02F5E944.
Unhandled exception at 0x69673472 (ucrtbase.dll) in MyApp.exe: An invalid parameter was passed to a function that considers invalid parameters fatal.

This can be reproduced e.g. with the following code:
[[NSMutableArray new] removeObjectAtIndex:0];

which emits a message like the following on the reference platform:

*** -[__NSArrayM removeObjectAtIndex:]: index 0 beyond bounds for empty array

This is now implemented


Support for OAuth token invalidation/rotation

Google is one case (that I'm aware of) where tokens are used. There's likely more out there.
The problem isn't fixed by changing the password alone.

I feel like this is out of scope for pass-rotate.


ExistentialDeposit when unbond

What does this PR do?
add existential deposit when unbond
Unit Tests
Manual Testing
Follow up
Extra details

Codecov Report
Base: 60.49% // Head: 60.49% // No change to project coverage :thumbsup:

Coverage data is based on head (55b125c) compared to base (795592e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   60.49%   60.49%
=======================================
  Files          70       70
  Lines       18566    18566
=======================================
  Hits        11232    11232
  Misses       7334     7334

Impacted Files
Coverage Δ

pallets/staking/src/lib.rs
68.64% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Full management of imported Kubernetes clusters

What kind of request is this (question/bug/enhancement/feature request):
feature request
It would be nice to have the same management capabilities on imported clusters as that of Rancher provisioned clusters.

This is not possible.  As an imported cluster we have only access through the k8s API.  We do not know what provider it's in, where the nodes come from, and have no access create or delete them, manage etcd or the control plane nodes (if they exist at all, which they don't in some providers) or manage or the configuration of the components running behind that API.


Surveys: Show Draft templates in templates list

Not required.. Draft templates are already visible to the template owner..


08/30/2018 06:11 : Create Pull Request for branch prTesting_2018083006 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Create shell scripts for Travis 'install' and 'script' steps

@SeanTAllen What do you think of the case statements here on the tuple of (os, llvm)?

I am, however, not ready yet.  Need to add some flags and fix an envvar thing.

I find the organization hard to follow.
I'd rather there were a script for master and one for release, each of which gets past the stage, like "install", "script", "deploy" etc
I'm interested in hearing why you think it should be organized like this...
Then I can open up a file and see what happens at each step.

Oh I've sliced the matrix the other way than you wanted?

I want to talk about this but i HAVE to go.  Later.

@killerswan GO! We'll always have Paris.

If we go this route, can we preface the travis_* scripts with a dot, so that they are hidden during normal development, just like .travis.yml.  We already have a lot of loose files cluttering the top level of the project directory as it is.

@jemc Good call.
@SeanTAllen ok, now this is worth talking about, I think.  If you look at each of these four steps you see the 12 -> 6 -> 6 -> 1 path:

12 initial configs : in YAML
6 dependency installations: in .travis_install.bash
6 main script: in .travis_script.bash (with one release, and exits for its inverse here and here), and
1 deployment: in YAML

I find the organization (and therefore probably goals of both set of changes confusing) that said I prefer this one.

😺

I understand your organizational principle for this.
So to pull in the Sean concern.
rather than having all the release tasks inline in a case statement. How about having "build for release" be another function gets called from within the case statement. My goal would be to separate out the release logic into a single unit that can be easily viewed and inspected and when changing LLVM etc versions, wouldn't need to copied around (potentially introducing errors).
Goals:

code to release should only be touched when the process changes
changing llvm dependency etc used as "release" should be easy to change without potentially breaking "actual release" code
when i open up the travis files, it should be very easy to know what the os and llvm combo is that is used to release and should be easy to change.

that said, all of this could be accomplished in another PR. this looks pretty good.
the one thing i would ask from this is to add the new .travis* files to skip list in .appveyor.yml so changes to any of these files don't trigger a windows build.

@SeanTAllen 🐰

@killerswan should this be squashed? I think it would be reasonable to squash. Thoughts?

Yeah, I can do that in a bit!

Squashed!

Love the image!

😸


CB-13865: (IOS-Ipad) Making popover Window Size configurable using popoverOptions - imagePicker

Platforms affected
IOS - Ipad only
What does this PR do?
Allow the user to set the popover Width and Height on Ipads
What testing has been done on this change?
Modified the automated test cases to accommodate for the change.
Tested the plugin on the Ipad with different popover height and width as well as not specifying any.
Checklist

[x ] Reported an issue in the JIRA database
[x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ x] Added automated test coverage as appropriate for this change.

Travis Build failed due to timeout on the server and not due to test cases failing. It failed only for android-6.0 and android-7.0 while passing for all other platforms including android-4.4 and android-5.1.
We have not made any changes in the Android code and it is clearly a build server timeout probably due to overload. Is there a way to retrigger the build or make those test cases pass? Please advise as you can see the logs below for the failed test case?
.......................................................................................................................................................................................................................    ✗ camera.ui.util determine camera availability
- Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
...................................................................................................................

I've restarted the failed jobs and they are green now.

i edited the plugin as you did but still cant access popoverwidth and popoverheight
it says

Type '{ x: number; y: number; width: number; height: number; arrowDir: number; popoverWidth: number; popoverHeight: number; }' is not assignable to type 'CameraPopoverOptions'.
Object literal may only specify known properties, and 'popoverWidth' does not exist in type 'CameraPopoverOptions'.ts(2322)

any help from the editor!


Update 1.3.6 release notes

Signed-off-by: Kavitha Conjeevaram Mohan<EMAIL_ADDRESS>Description
Update 1.3.6 release notes to include Jackson version update bug fix
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #481 (61c3549) into 1.x (d0c86aa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.x     #481   +/-   ##
=========================================
  Coverage     74.35%   74.35%
  Complexity      383      383
=========================================
  Files            94       94
  Lines          3969     3969
  Branches        612      612
=========================================
  Hits           2951     2951
  Misses          884      884
  Partials        134      134

Flag
Coverage Δ

dashboards-reports
77.06% <ø> (ø)

reports-scheduler
71.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Dirt 2 Demo Black screen at startup (DX11)

Dirt 2 Demo starts with a black screen in DX11 using the latest version of dxvk.
in wined3d, it works but it can crash or work just fine depending on the version of wine you use (although much worse performance than dxvk for me).
using dirt 2 demo with wined3d in Wine 7.10 stable or staging starts up and crashes at the intro unless i put wineesync=0 and winefsync=0 but it then crashes after the loading part in-game.
lutris-GE-Proton7-16-x86_64 works fine instead.
it works perfectly fine in DX9 with dxvk if you change the config files to force it in dx9.
dirt 2 starts up ok with no issues in dx11 with dxvk when you enable mangohud.
sometimes when i manage to somehow get dirt 2 running in dx11 with dxvk, deleting the glcache folder in ~/.cache/nvidia/ makes the game start up in black screen again.
i used lutris to run the game.
Software information
Dirt 2 Demo, DX11, default settings (nothing is changed)
lutris:
dxvk-async with DXVK_ASYNC=1
D3D Extras V2 Enabled
Esync and Fsync are enabled in lutris
System information

GPU: GTX 960 2GB
Driver: 515.48.07
Wine version: lutris-GE-Proton7-16-x86_64
DXVK version: dxvk-async 1.10.1 (and i have tried both the normal binary of dxvk and the master release, both of them have the same issue.)
Arch Linux, 5.18.3-zen1-1-zen x86_64

Apitrace file(s)
Windows 10 21H2 19044.1766:
https://www.dropbox.com/s/e7elnr7lwutwf75/APITRACE (WINDOWS).7z?dl=0
Log files (Linux)

d3d9.log:
dirt2_d3d9.log
d3d11.log:
dirt2_d3d11.log
dxgi.log:
dirt2_dxgi.log

also, i dont know if i was supposed to send an apitrace when the game is not working properly.
i sent the apitrace in windows where the game works completely fine, hopefully it gives an insight into why this isnt working.
also, dirt 2 demo is free and you can download it to see for yourself.
its only 1.8 gb when installed and 1.4 gb when downloaded.

That's fine. You've filled out the issue correctly 👍

also, i forgot to mention.
if you have any issues with starting dirt2, make sure you have wine-openal installed so dirt2 can launch.
and if it still doesnt launch, it might be something to do with esync and fsync, you can try disabling them.

@UsERDuMP4532 Does setting the dxgi.deferSurfaceCreation = True dxvk.conf option help? Whenever you're getting a black screen on startup that's usually the first thing to try and rule out.

no, it doesnt help.
still got the same old black screen.
and i can confirm the dxvk.conf is working because i tried setting a framelimit and it worked.
and like usual, running the game again with mangohud makes the game start up just fine in d3d11.
also, has anyone else seemed to reproduce this issue or is this sadly a dead-end?


Got a problem in autofilling model config

Here is the log of autofilling a tf-savedmodel model. And finally the server cannot be started because of this model. It is a non-batching model and the input shape is [].
I0417 10:05:20.585237 22393 autofill.cc:140] TensorFlow SavedModel autofill: OK:
I0417 10:05:20.585270 22393 model_config_utils.cc:307] autofilled config: name: "inception_flower"
platform: "tensorflow_savedmodel"
input {
name: "myInput"
data_type: TYPE_STRING
dims: 1
reshape {
}
}
output {
name: "myOutput"
data_type: TYPE_FP32
dims: -1
dims: 5
}
default_model_filename: "model.savedmodel"
E0417 10:05:20.596050 22393 model_repository_manager.cc:1570] model input cannot have empty reshape for non-batching model for inception_flower

What Triton version are you using? It seems like the max_batch_size field is not auto-filled...

r20.05.And here is my model.
https://bj-cmri.bj.bcebos.com/inception_v3.zip

Do you mean r20.03? r20.05 is not released yet and the README clearly states it is not useable.

both r20.03 and r19.12 occured this problem

Have you downloaded the model? The storage service costs money so I will remove it if you have downloaded it :) @deadeyegoodwin @GuanLuo

@rithd Sorry for not following up with the issue, I have downloaded the model and will look into it.

I tried to print out the model I/O of the model and it seems like the input has no shape. Is the input a scalar? If so, you will need to wrap it to a tensor as Triton doesn't support scalar input.
TF input: myInput; rank: 0; dims: []
TF output: myOutput; rank: 2; dims: [-1 5 ]

The input is a raw image with the shape of [], and it doesn't support batch inference. So the Triton's  feature reshape is inefficiency in this situation?

Correct, because Triton doesn't support scalar input. The reshape to [] only works for model that supports batching, as in that case the input is still a tensor (i.e. full shape is [batch_size]).

So if my model have a image input, either the image input have at least 3 dims ( hwc or chw) , or the model can support batching with the input of a raw image if I want to deploy it in Triton?

And i also have a question, whether the "format" field is necessary for Triton's model config? If the user already know the order of c,h,w?

You just need to modify your model to accept a tensor instead of a scalar as input, there is a custom backend for image preprocessing and its model config for input is similar to your model's.
the format is optional

Get it, thx


feat: expose named_struct in python

Ref #692
Which issue does this PR close?
Closes #692
Rationale for this change
This UDF has not been ported over and was requested.
What changes are included in this PR?
The UDF is wrapped and exposed to python.
Are there any user-facing changes?
No. Just a function added.

That was fast! Thank you!


ruby: use x86_64 binary on M1 macs

On M1 macs we can rely on rosetta. Right now architecture defaults to 32-bit for those machines, which doesn't work
Related to https://github.com/grpc/grpc/issues/25755
cc @jtattermusch

I think we just need an entry in the release notes to get the Mergable check to pass?

would love to get this patch in the pypi index because it's not possible to build grpcio-tools without this

I think we just need an entry in the release notes to get the Mergable check to pass?

not necessarily, no :-) You can actually set it to "No" and it'll make it happy too.

So I'm not against the change, but overall, the M1 situation feels janky and unstable. Without actual continuous integration testing, this isn't making me feel warm and fuzzy. I'd love if there was an actual note somewhere about how M1 is supported for now in "best effort" mode, and that there's strictly no guarantee whatsoever, given how we just can't test it.


[WIP] Manifest caching using llbuild

@ddunbar I tried applying some of your suggestions about making it more generic. Can you take a look again?

@swift-ci please smoke test


Need better "loading" icon on browse page

When you first go to the browse page after changing search criteria, you get a blank page number and a black page with no indication that data is loading. The page number should be filled in, and there should be a large spinny thing that says the page is loading.

This is no longer very important since the performance has improved so much,.

Fixed


Colons in /data/labels XML files prevents them from being checked out on Windows and Mac

The Windows and Mac file systems don't allow colons in filenames, which means that checking out the project generates multiple errors like the following:
error: unable to create file data/labels/2017-12-27 12:14:19.731720.xml: Invalid argument

Ever since iOSX Macs no longer have problems with colons in filenames.  I was able to clone the repo on both my Mac and iPad (using Working Copy) without issues.

Just seeing this now. I was not aware that Windows computers couldn't handle colons. I can take a look at renaming all the files.


fix: Rename ras-os-version header to ras-device-os

Description
This replaces the HeadersInterceptor with the RasSdkHeaders for the SDK Utils library
Links
SDKCF-1740
Checklist

[x] I have read the contributing guidelines.
[x] I wrote/updated tests for new/changed code
[x] I ran ./gradlew check without errors

Codecov Report

Merging #30 into master will decrease coverage by 11.08%.
The diff coverage is 18.18%.

@@             Coverage Diff             @@
##           master      #30       +/-   ##
===========================================
- Coverage   81.54%   70.45%   -11.09%
===========================================
  Files          13       13
  Lines         298      308       +10
  Branches       22       21        -1
===========================================
- Hits          243      217       -26
- Misses         49       85       +36
  Partials        6        6

Impacted Files
Coverage Δ

...en/tech/mobile/remoteconfig/api/ConfigApiClient.kt
68.96% <18.18%> (-31.04%)
:arrow_down:

...uten/tech/mobile/remoteconfig/api/ConfigFetcher.kt
84.61% <0%> (-7.7%)
:arrow_down:

...ch/mobile/remoteconfig/RemoteConfigInitProvider.kt
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcb201...3cab0c2. Read the comment docs.


'TypeError: importItems.importedAs.entries is not a function' error when using --cache, but not without the cache

Hi,
When I run Knip 5.17.0 (on Node 20.12.0) with the --cache option I get this error:
file:/// … /node_modules/knip/dist/index.js:186
        for (const [id, value] of importItems.importedAs.entries()) {
                                                         ^

TypeError: importItems.importedAs.entries is not a function or its return value is not iterable
    at updateImports (file:///Users/wolsph/Projects/shop-next/node_modules/knip/dist/index.js:186:58)
    at updateImported (file:///Users/wolsph/Projects/shop-next/node_modules/knip/dist/index.js:229:13)
    at setInternalImports (file:///Users/wolsph/Projects/shop-next/node_modules/knip/dist/index.js:238:13)
    at analyzeSourceFile (file:///Users/wolsph/Projects/shop-next/node_modules/knip/dist/index.js:266:13)
    at main (file:///Users/wolsph/Projects/shop-next/node_modules/knip/dist/index.js:301:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async run (file:///Users/wolsph/Projects/shop-next/node_modules/knip/dist/cli.js:23:73)
    at async file:///Users/wolsph/Projects/shop-next/node_modules/knip/dist/cli.js:90:1

If I rm -rf node_modules/.cache or remove the --cache option and re-run Knip then there is no error.
If I console.log importedModule.importedAs then it appears to be an empty object:
Analyzing source files...
{}

I had the same error when using Knip 5.16.0 so I don't think it is related to the release of 5.17.0.

Thanks for the report! I think it's not (de)serializing the map from/to an object (it does for sets/arrays), I can fix it later today.

:rocket: This issue has been resolved in v5.17.1. See Release 5.17.1 for release notes.
Using Knip in a commercial project? Please consider sponsoring me.


Insertion Deletion AUC metric

Added Insertion Deletion AUC metric that calculates the accuracy drop/increase during deletion/insertion of important pixels

Added parent BasicMetric

Thank you for your suggestions, Songki. I implemented __call__ for a single image and evaluate for a set of images. I also return Dict[str, float] for both of functions. It helps the generality but getting the score is no more elegant:
pointing_game_score = self.pointing_game.evaluate([explanation], self.gt_bboxes)["pointing_game"]
pointing_game_score = list(self.pointing_game.evaluate([explanation], self.gt_bboxes).values())[0]
Provably, evaluate can affect the internal state of Metric class and we can get scores as property function pointing_game.score. Let's leave the optimization until the next PR.


[19.03 backport] API: Set format of body parameter in operation PutContainerArchive to "binary"

backport of https://github.com/moby/moby/pull/39248 for 19.03

@kolyshkin @tiborvass ptal; not critical, but trying to fix more issues with the swagger in the release branch.

failure is unrelated; merging


Warning Message in Create_SAHA_Object.R wrong

Specifically for marker_free (AvgExp). Need to check for rownames or column = "X". Need to figure out the correct columns to check for.
When @lhoranportelance had preprocessed his avgexp, it shot a warning... but there was overlap between genes in query&db.

I have reviewed this issue and cannot seem to replicate the error with my data / code. Could either one of you send me a snippet of the code you ran + the files used?


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit dc6a538:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit dc6a538:
:clock10: Full build: the average full build time is 7 min(s) 52 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit dc6a538:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Fable compiler doesn't like space in path

Seems like the fable compiler doesn't like spaces in path name.
Here is the result when I try to compile my project using Fable.
Mangel Maxime@DESKTOP-1MR6L5C MINGW64 ~/Documents/Visual Studio 2015/Projects/Fa                                                                                bleTinyEngine/FableTinyEngine
$ fable -t watch --verbose
Fable F# to JS compiler version 0.3.26
npm install
ERROR: npm
ERROR:  WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>
PROJECT FILE: C:\Users\Mangel Maxime\Documents\Visual Studio 2015\Projects\FableTinyEngine\FableTinyEngine\Browser.fsproj

OUTPUT DIR: C:\Users\Mangel Maxime\Documents\Visual Studio 2015\Projects\FableTinyEngine\FableTinyEngine\temp

WORKING DIR: C:\Users\Mangel Maxime\Documents\Visual Studio 2015\Projects\FableTinyEngine\FableTinyEngine

FABLE COMMAND: cmd /C C:\Users\Mangel Maxime\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe --copyExt true --target watch --verbose true --module commonjs --sourceMaps true --projFile ./Browser.fsproj --outDir C:\Users\Mangel Maxime\Documents\Visual Studio 2015\Projects\FableTinyEngine\FableTinyEngine\temp --ecma es5

Start compilation...
FABLE ERROR: 'C:\Users\Mangel' is not recognized as an internal or external command,
operable program or batch file.
...

Damn, I thought node's child_process.spawn took care of quoting the arguments when need. This needs to be fixed, thanks for the report!

I need to test this on Windows.

Doing a quick test here. Spaces in project file path appears to be fine:
(Windows 8.1)
C:\Temp\Fable\samples\node>fable --projFile "console  with spaces\console.fsproj" --verbose
Fable F# to JS compiler version 0.4.0-alpha
npm install

PROJECT FILE: C:\Temp\Fable\samples\node\console  with spaces\console.fsproj
OUTPUT DIR: C:\Temp\Fable\samples\node\console  with spaces\out
WORKING DIR: C:\Temp\Fable\samples\node\console  with spaces

FABLE COMMAND: cmd /C C:\Users\User\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe --copyExt true --projFile console.fsproj --verbose true --module commonjs --sourceMaps true --outDir console  with spaces\out --ecma es5

Start compilation...
Compiled util.fs at 14:21:37
Compiled index.fs at 14:21:37
node out/index World
Hello dlroW!

However... I believe the problem may appear when the username contains spaces? (e.g. C:\Users\ User With Spaces \AppData...)
Also, I don't know how it worked, actually. Since that
--outDir console  with spaces\out
is surely in need of some quotes.

I tested it on Windows and seems to be working so I'm closing the issue :+1: Please feel free to reopen it if you still have problems.
@fdcastel, when you point to a dir where fableconfig.json is present, the paths will be resolved based on the directory where fableconfig.json is, and if the resolved path contains spaces, the argument will to. You can check it by creating a fableconfig.json like { "projFile": "Test.fsx", "outDir": "." } in a directory with spaces.

I just tested the alpha version of fable-compiler under Windows 10 and i still got the same problem.
Fable F# to JS compiler version 0.4.0-alpha
npm install
ERROR: npm
ERROR:  WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>

PROJECT FILE: c:\Users\Mangel Maxime\Documents\1-Dev\SquiibzSuave\Browser\src\Main.fsx
OUTPUT DIR: c:\Users\Mangel Maxime\Documents\1-Dev\SquiibzSuave\Browser\temp
WORKING DIR: c:\Users\Mangel Maxime\Documents\1-Dev\SquiibzSuave\Browser

FABLE COMMAND: cmd /C C:\Users\Mangel Maxime\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe --copyExt true --watch true --target watch --verbose true --module commonjs --sourceMaps true --projFile ./src/Main.fsx --outDir c:\Users\Mangel Maxime\Documents\1-Dev\SquiibzSuave\Browser\temp --ecma es5

Start compilation...
FABLE ERROR: 'C:\Users\Mangel' is not recognized as an internal or external command,
operable program or batch file.
...

I tried to execute manually the FABLE COMMAND by adding quotes to the path. And I got this error:
cmd /C "C:\Users\Mangel Maxime\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe" --copyExt true --watch true --target watch --verbose true --module commonjs --sourceMaps true --projFile ./src/Main.fsx --outDir C:\Users\Mangel Maxime\Documents\1-Dev\SquiibzSuave\Browser\temp --ecma es5

Unhandled Exception: System.InvalidOperationException: The input list was empty.
   at Microsoft.FSharp.Collections.FSharpList`1.get_Head()
   at Fable.Client.Node.Main.readOpts@38(FSharpMap`2 opts, FSharpList`1 _arg1)
   at Fable.Client.Node.Main.readOptions(String[] argv)
   at Fable.Client.Node.Main.main(String[] argv)

Strange thing is I really need to place the quotes on the first absolute path.
Not the one for --outDir as it say the FATAL ERROR.

Sorry, this fix didn't make it into alpha. I'll include it in the next release, hopefully in a few hours.

Oh sorry. I was thinking it was in. I will test it again later so.
Could be a good idea to add milestone or label to know the version in which the issue is ?

Yeah, I need to get serious about that. Issues seem to be calming down, so after this release I'll try to write proper release notes for each new version :+1:

@MangelMaxime, I just released 0.4.0 (not alpha) with the fix. Could you please give it a try? Thanks!

I still got an error.
And this time I am at a place where there was no error coming from the path. (see the first line having no space for the working directory).
c:\0-dev\SquiibzSuave\Browser>fable --verbose
Fable F# to JS compiler version 0.4.0
npm install
ERROR: npm
ERROR:  WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>

PROJECT FILE: c:\0-dev\SquiibzSuave\Browser\src\Main.fsx
OUTPUT DIR: c:\0-dev\SquiibzSuave\Browser\temp
WORKING DIR: c:\0-dev\SquiibzSuave\Browser

FABLE COMMAND: cmd /C "C:\Users\Mangel Maxime\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe" --copyExt true --verbose true --module commonjs --sourceMaps true --projFile ./src/Main.fsx --outDir c:\0-dev\SquiibzSuave\Browser\temp --ecma es5

Start compilation...
FABLE ERROR: '\"C:\Users\Mangel Maxime\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe\"' is not recognized as an internal or external command,
operable program or batch file.
...

If I execute this line:
cmd /C "C:\Users\Mangel Maxime\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe" --copyExt true --verbose true --module commonjs --sourceMaps true --projFile ./src/Main.fsx --outDir c:\0-dev\SquiibzSuave\Browser\temp --ecma es5

I got a bunch of text on the console: (just some extract)
c:\0-dev\SquiibzSuave\Browser>cmd /C "C:\Users\Mangel Maxime\AppData\Roaming\npm\node_modules\fable-compiler\bin\Fable.Client.Node.exe" --copyExt true --verbose true --module commonjs --sourceMaps true --projFile ./src/Main.fsx --outDir c:\0-dev\SquiibzSuave\Browser\temp --ecma es5
{"sourceType":"module","body":[{"specifiers":[{"imported":{"name":"List","type":"Identifier","loc":null},"local":{"name":"$import0","type":"Identifier","loc":null},"type":"ImportSpecifier","loc":null}],"source":{"value":"fable-core","type":"StringLiteral","loc":null},"type":"ImportDeclaration","loc":null},{"specifiers":[{"imported":{"name":"String","type":"Identifier","loc":null},"local":{"name":"$import1","type":"Identifier","loc":null},"type":"ImportSpecifier","loc":null}],"source":{"value":"fable-core","type":"StringLiteral","loc":null},"type":"ImportDeclaration","loc":null},{"specifiers":[{"imported":{"name":"Date","type":"Identifier","loc":null},"local":{"name":"$import2","type":"Identifier","loc":null},"type":"ImportSpecifier","loc":null}],"source":{"value":"fable-core","type":"StringLiteral","loc":null},"type":"ImportDeclaration","loc":null},{"specifiers":[{"imported":{"name":"Seq","type":"Identifier","loc":null},"local":{"name":"$import3","type":"Identifier","loc":null},"type":"ImportSpecifier","loc":null}],"source":{"value":"fable-core","type":"StringLiteral","loc":null},"type":"ImportDeclaration","loc":null},{"declaration":{"declarations":[{"id":{"name":"days","type":"Identifier","loc":null},"init":{"callee":{"object":{"name":"$import0","type":"Identifier","loc":null},"property":{"name":"ofArray","type":"Identifier","loc":null},"computed":false,"type":"MemberExpression","loc":null},"arguments":[{"elements":[{"elements":[{"value":"Sun","type":"StringLiteral","loc":null},{"value":"Dim","type":"StringLiteral","loc":null}],"type":"ArrayExpression","loc":null},{"elements":[{"value":"Mon","type":"StringLiteral","loc":null},{"value":"Lun","type":"StringLiteral","loc":null}],"type":"ArrayExpression","loc":null},{"elements":[{"value":"Tue","type":"StringLiteral","loc":null},{"value":"Mar","type":"StringLiteral","loc":null}],"type":"ArrayExpression","loc":null},{"elements":[{"value":"Web","type":"StringLiteral","loc":null},{"value":"Mer","type":"StringLiteral","loc":null}],"type":"ArrayExpression","loc":null},{"elements":[{"value":"Thu","type":"StringLiteral","loc":null},{"value":"Jeu","type"

It's better than yesterday where I was having FATAL ERROR when executing this command by hand. But still can't compile via fable.

Thanks for checking, seems the solution

Happy to help improve fable.
Cool if you have what you need to fix it :)
Ping me when you need another test ^^

@MangelMaxime, I've release<EMAIL_ADDRESS>Can you give it a shot please? (fingers crossed)

Hey hey
Everything is working on my personal computer.
With spaces. Without spaces.
I will test this new version on computer at work as it's was crashing todo with 0.4.0
Thanks a lot :)
PS: I just push convince my team at work to try fable for a "Proof of concept" project.

Fantastic, thanks a lot for your collaboration and your patience!
It would be awesome if you can convince your team to use Fable. You know you can count with my support :+1: Also we can put the logo of your company in Fable's website 😄

Hey hey will keep you in touch. :)


json format for corrections

hello,
i have some corrections which are parametrized bt eta anf pt bins i.e.
pt-bins 25-45    eta<1.2      0.9992±0.0288         eta>1.2      0.6476±0.0187

pt-bins 45-60     eta<1.2       0.629±0.0417         eta>1.2       0.7316±0.0678

pt-bins 60-infi     eta<1.2     0.6698±0.0608        eta>1.2     0.9944±0.129

i can use correctionlib for other corrections and sf taking help from https://gitlab.cern.ch/cms-nanoAOD/jsonpog-integration/-/tree/master/examples?ref_type=heads
but im not getting how to create a json file for above corrections, is there any specific script which help to create the json file?
Thanks

You will have to write a script to convert such cases.
Perhaps the tutorial will provide some guidance?

Was this helpful in the end? If so, I will close the issue

yes it was helpfull, sorry for delay


Use better SSL by default

Chrome gives me this warning:

The non-https assets is my problem, but I'm guessing the outdated cryptography can be fixed with stud config? SHA1 is deprecated:
https://www.chromium.org/Home/chromium-security/education/tls#TOC-Deprecation-of-TLS-Features-Algorithms-in-Chrome
Here is recommended config:
https://wiki.mozilla.org/Security/Server_Side_TLS#Modern_compatibility

We are moving into a bud soon instead of stud. Give me couple of more days.
On 2015 මාර්තු 28, සෙන at ප.ව. 2.35 Loren Sands-Ramshaw <
<EMAIL_ADDRESS>wrote:

Chrome gives me this warning:
[image: image]
https://cloud.githubusercontent.com/assets/251288/6880442/2db7b052-d4ee-11e4-8f1f-f9c536ed32ef.png
The non-https assets is my problem, but I'm guessing the outdated
cryptography can be fixed with stud config? SHA1 is deprecated:
https://www.chromium.org/Home/chromium-security/education/tls#TOC-Deprecation-of-TLS-Features-Algorithms-in-Chrome
Here is recommended config:
https://wiki.mozilla.org/Security/Server_Side_TLS#Modern_compatibility
—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/341.

Great, thanks!
On Sat, Mar 28, 2015 at 2:53 AM, Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

We are moving into a bud soon instead of stud. Give me couple of more days.
On 2015 මාර්තු 28, සෙන at ප.ව. 2.35 Loren Sands-Ramshaw <
<EMAIL_ADDRESS>wrote:

Chrome gives me this warning:
[image: image]
<
https://cloud.githubusercontent.com/assets/251288/6880442/2db7b052-d4ee-11e4-8f1f-f9c536ed32ef.png
The non-https assets is my problem, but I'm guessing the outdated
cryptography can be fixed with stud config? SHA1 is deprecated:

https://www.chromium.org/Home/chromium-security/education/tls#TOC-Deprecation-of-TLS-Features-Algorithms-in-Chrome

Here is recommended config:
https://wiki.mozilla.org/Security/Server_Side_TLS#Modern_compatibility
—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/341.

—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/341#issuecomment-87199104.

Please tell me how is progress going with bud. We definitely could use the correct tls 1.2 and no ssl3 configuration. We want to stick with mup so that we can migrate to cluster.

We are using nginx in the mupx. Our next version of mup.
See: https://github.com/arunoda/meteor-up/tree/mupx#
Check the migration guide as well: https://github.com/arunoda/meteor-up/tree/mupx#migrating-from-meteor-up-0x

+1, Great!


BeforeQuery hook, alternatively a plugin to format before query

Your Question
I am in need of some formatting before doing a query. Mainly converting shortuuid to uuid.
What I have in mind is having 2 fields in my custom gorm.Model.
e.g. ID which is a string (shortuuid, ignored in gorm) and UUID which is the primary key.
When doing a query, I am assigning the ID field (which again, is a shortuuid), before the query actually runs I decode this shortuuid and assign the uuid to it's UUID field, thus querying with this instead.
I looked into https://github.com/go-gorm/gorm/issues/1159, mainly the Before("gorm:query) part. Now, it does not seem like v2 exposes CallMethod anymore, so I was looking at the docs and found the part of writing plugins, but I am honestly at a loss.
Feels like I am doing something wrong, do you have any idea of how to do this correctly?
I'm looking into this as to not expose a squence in my database, so uuid looked good. But it's way too long to show in the api and my website, so found shortuuid which implements base57 (based my logic around this, with the possibility of decoding the string to uuid).
So the flow would be:

Query with shortuuid -> Convert to uuid
Return results with uuid -> Convert to shortuuid.

Any ideas?

refer https://github.com/go-gorm/gorm/blob/master/callbacks/create.go#L13-L28

Ah right, thank you!

I have implemented some copies of the code in gorm.
package callbacks

import (
	"gorm.io/gorm"
        "reflect"
)

type BeforeQueryInterface interface {
	BeforeQuery(db *gorm.DB) error
}

func BeforeQuery(db *gorm.DB) {
	if db.Error == nil {
		callMethod(db, func(value interface{}, tx *gorm.DB) (called bool) {
			if i, ok := value.(BeforeQueryInterface); ok {
				called = true
				db.AddError(i.BeforeQuery(tx))
			}
			return called
		})
	}
}

func callMethod(db *gorm.DB, fc func(value interface{}, tx *gorm.DB) bool) {
	tx := db.Session(&gorm.Session{})
	if called := fc(db.Statement.Dest, tx); !called {
		switch db.Statement.ReflectValue.Kind() {
		case reflect.Slice, reflect.Array:
			db.Statement.CurDestIndex = 0
			for i := 0; i < db.Statement.ReflectValue.Len(); i++ {
				fc(reflect.Indirect(db.Statement.ReflectValue.Index(i)).Addr().Interface(), tx)
				db.Statement.CurDestIndex++
			}
		case reflect.Struct:
			fc(db.Statement.ReflectValue.Addr().Interface(), tx)
		}
	}
}

Where I initialize my db I do:
db.Callback().Query().Before("gorm:query").Register("ltc:before_query", callbacks.BeforeQuery)

In the model struct, I have implemented:
func (m *SampleModel) BeforeQuery(db *gorm.DB) error {
	fmt.Println(m)
	return nil
}

This is called successfully prior to the query itself, like expected.
However, the struct is empty, nothing has been initialized.
Here's an example of how I query:
var res SampleModel
err := db.Where(SampleModel{...}).First(&res).Error

Having a print in BeforeCreate shows the data I am trying to add to the db.
Am I missing something?

@vincegio
I know I am late for the party but... the struct should be empty in your case for sure: https://github.com/go-gorm/gorm/issues/3935#issuecomment-758476305

Nice work @vincegio
@jinzhu why don't support it natively in gorm?


[Question] How works that kind of chaining?

Hi,
found your nodelist.js and really like it.
Looked into the code and would happy to understand how you created that kind of chaining?
$$('.child').id; // ['', '' ... x10]

$$('.child') is a list of nodes (nodelist object) and the chained call .id not exists in your code. So chained calls (properties / methods?) to nodelist mapped to each item of nodelist?
May you explain how that is done? 🥇

If I'm not mistaken that is done from line 153-157

Lol now you confused me, but good look with that let me know how it goes

Hi, I created a gist with my small jQuery like class which maps Nodelist to Node methods / attributes via JS proxy.
It included a simple router, event delegation  and tasks (pubsub with prio / sort).
Because I'm new with JS it needs some work to improve and cleanup... But simple tests works fine. Minimal demo index.html file included (without router or pubsub...)
https://gist.github.com/pwFoo/bdd1d0cc38b7575b6ec7121e19499914
I know it's not ready to use... but would like to know what you think about?


Donation/Buy me a coffe button is missing

Hi @szymmis, you should totally add a button for donattions!
Possible services to set it up:
Ko-Fi
Buy Me a Coffee](https://www.buymeacoffee.com/)
Hope this doesn't come as an insult or anything, if so please forgive me 🙏🏼

Hi @aldomeza-dev, that's very nice of you to propose that, but I don't think that donations are needed based on how small this library is. There are projects out there that need the funding much more!
Nontheless, it really means a lot to me that you think this project is donation-worthy, thanks!


refactor theme js files to allow toggling themes

To address an issue with theme toggling in Storybook that @TylerMartin5 and @markcaron discovered, I think we should refactor each theme's js files as follows.  Using cp-theme for an example.

instead of running immediately, cp-theme.js should export a function
when run, that function should remove any rhelements' theme-related elements from the head (to clear out any previously set themes)
that function will then activate cp-theme by injecting stuff into the head

This will enable toggling from one theme to another in Storybook, but also for any page that wants to have theme toggles, like a demo page or an app with light/dark themes.

Cool idea.  Would there be 2 methods for importing a theme then: 1 approach using the JS file, another for using the CSS file directly?

Yeah, that would be excellent.


Firefox extension in InPrivate doesn't have the config

Extension has been configured in regular Firefox.
Open an InPrivate session and extension wants to be set up again.
Run through the config again, it works for this session.
Close the session and open a new one, extension wants initial config again.

Can you tell which branch are you using currently, or the one from store?.
Does this happens when using a regular session?.

The most likely thing happening is that the nature of InPrivate which doesnt store data after is closed. unless you are saying that it needs to be configured again once the session in private is closed

@crkos
I am running the version from the Mozilla Store.
It doesn't happen in a regular session.
And yes, it wants to do the initial config everytime you open an InPrivate window, not just the first time.

I'm actually quite limited in this regard take a look at:
https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API
Since firefox implementation doesnt have chrome.storage like apis i can't do much.
This is by design, read specifically: Private Browsing / Incognito modes

I'm actually quite limited in this regard take a look at:
https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API
Since firefox implementation doesnt have chrome.storage like apis i can't do much.
This is by design, read specifically: Private Browsing / Incognito modes

If this is by design, how come EVERY other extension is able to have its settings saved across InPrivate and regular?
I just enable "Allow to run in InPrivate" and everything just works.
This (LinkWarden) is the first extension I have this problem with.

I've read a little bit more, it seems that browser.storage.local behaves like chrome.storage, It seems that indeed i'm using the window.localStorage incorrectly, it is advised on the doc for web extension to not use this api, but the browser api. So i will just change that,

Ok i solved on:  4ea36b8

Tested on private instance of firefox

@crkos
Thanks, when will the version in the store be updated?

I'm waiting on Daniel to push the next version of linkwarden because it will include api keys so authentication will be less of a hassle

@etec-masterofsynapse yep, it's my fault. The next release is something big, batch editing/deletion, api keys, PWA support, sub-collections and more...
It'll probably be ready by the end of this week or early next week.
Also @crkos sorry for the delay...

It's ok actually, even if it was ready by today, I can't work on it right now, Maybe in 2-3 weeks from now im a little bit more free

Fixed on last update.


V2 Release

This is the last release via the prerelease branch as...
JSCAD V2 HAS BEEN RELEASED AND PUBLISHED!!!!
Successfully published:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>lerna success published 23 packages

All 2.0.0 packages are now available via NPM.
All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Does your submission pass tests?

@SimonClark Thanks for the great assistance!
V2 JSCAD has been release!!!
It's time to do a little cleanup, so can you please review and merge this into V2 branch?
I will follow with a merge of V2 into master, then we are ready to start the normal development flows.


Error: There was an error sending your trade offer.  Please try again later. (26)

I keep getting this error on some items. Other go through well. I suppose this might be STEAM related issue, but I need to be sure.
Any info about this error?

Check your item object. I hope this will help you.

Base on my experience this happens either when you try to bet an item that is already gone or your account has 5 more pending trade offers

I know about this appearing with items which are not in the inventory. If you have reached limit, there is another error. But the problem is that, the item is in the inventory and even with 0 pending trade offers this error is given. I would understand that I made something wrong, but it works on some items, others simply do no not work :/

I've been getting the same error message for the last 24 hours. It works fine through Steam Community, but not through the Bot.

The bot has 0 pending trade offers.

I found the issue, why I kept receiving this one. STEAM uses  64-bit integers as item ids, and some of these exceed 32-bit integer boundaries. And for some reason I converted them all to 32-bit integers. Now changed it to be as String as it does work well.

Thank you mantux5. It works for me as well.

I have the same problem, I do not understand your statement as I have to convert to 32 bit integers,
32-bit and 64-bit the same number, but 32 have earlier boundaries


Log Batch Operation Exceptions

This PR adds logging of batch operation exceptions when they are added into the aggregate batch response. Previously, the batch operation exception would only be logged when iterating through the batch operation responses, so there is the possibility that the exception is never logged.

Should we maybe add a Changelog entry for this?


🐞 grpc connection closed when using podman + wsl2

What is the issue?
When using podman 5.1.2 + wsl2 and trying to do dagger init on an already existing codebase, Dagger fails with a grpc client connection closed error.
Discord thread: https://discord.com/channels/707636530424053791/1267572025791090759
Dagger version
v0.12.3
Steps to reproduce

Have a wsl2 + podman >= 5.1.2 setup
Perform a dagger init --sdk $sdk on an already existing project

Log output
! failed to export: rpc error: code = Canceled desc = grpc: the client connection is closing
Error: failed to generate code: input: blob.diff.export resolve: failed to export: rpc error: code = Canceled desc = grpc: the client connection is closing

Note: we should fix this, but also we should have provisioning tests for podman - currently this isn't tested :cry:
We should also have for windows, which I'm working on, but it's a pain :cry:

Before we implement tests for podman, we should decide whether we want to support podman at all. Podman on Linux seems to cause another set of issues: https://github.com/dagger/dagger/issues/8054


Move metadata server to separate service, create memdriver to test things with pubsub and introduce app discovery endpoint

Ouline

It carves out metadata server from zedrouter to separate service (not created by zedbox)
It creates and invokes metadata server within zedrouter and passes http.Handler to LinuxNIReconciler
It introduces memdriver for pubsub, which can be used for testing. I don't need to expose internal structures of services, I can just publish things I want. (See msrv_test.go for more)
It introduces App Discovery endpoint for metadata server, allowing to discover IP addresses of other App Instances

Reasoning
Refactoring
Metadata server is a server which is exposed to all AppInstances connected to local Network Instance. It has information about network, can expose cloud-init and also exposes information for PatchEnvelopes. It does relate to networking, however logically it is not exactly part of Zedrouter. In order to reduce number of pubsubs from zedrouter and clean up code I removed it to separate service, which is is a part of zedrouter by composition. Running it as a separate service doesn't make sense, because it'll create additional dependency: metadata server is part of LinuxNIReconciler, so it needs network to run, and since LinuxNIReconciler depends on metadata server to create network, there's kind of circular dependency, we can solve it by communicating via pubsub, but it'll create additional overhead. Also it's gonna be very tricky exposing single metadata server to multiple local network instances :) Also, having metadata server separate from zedrouter allows us to test it without creating network. In order to test metadata server I created memdriver for pubsub, so that I don't need to expose internal structures of services so that I can set them for tests. I just create publications that I know are consumed for specific logic (handler) and publish them :D
App Discovery endpoint
This way sidecar application can now IP address of consumer application(s) using this discovery endpoint :)
Important

need https://github.com/lf-edge/eve/pull/3933 to be merged before (cherry picked commit in this PR, will rebase if needed)

TODO

Composing this, I think it makes sense to make a flag persist for Msrv struct, so that for testing we enable those (because it's imperative for memdriver to use persist, because of pubsub logic) and for being part of zedrouter we won't use persist

cc: @deitch @milan-zededa @eriknordmark
@christoph-zededa  you might be interested in memdriver and msrv_test.go as another way to test EVE services :D
P.S.
Pheew it took me a week to discover this bug above with pubsub :art:

Rebased to latest master, solved merge conflicts

I wonder if it would make sense to split the PR, at least between pubsub changes and zedrouter changes.
(request from person infamous for large refactoring PRs :))

I really so much want this to be a completely standalone service. I don't think we have a service that starts itself and another "sub-service" anywhere else in eve. @uncleDecart explained to me privately that it would be quite difficult to do, so I have to accept it. I do think it is worth expanding on a bit here - not in the PR comments, but in comments right where we run it - why it is run as part of zedrouter and not as a separate service.
This is 9 commits, which probably need to be squashed.
The long list of subscriptions it needs to create further emphasizes the requirement to get pubsub usage simpler, if we can, but that is beyond scope of this PR.

I see you are also adding AllowToDiscover as part of this PR, but that isn't mentioned in the PR description. Please add.

@eriknordmark added section in PR description, will expand it later a bit

I wonder if it would make sense to split the PR, at least between pubsub changes and zedrouter changes.
(request from person infamous for large refactoring PRs :))

That was one of your PRs I remember reviewing

If you're saying that it's not enough refactoring in my PR, I agree @milan-zededa :D. Thing is that PubSub changes introduce memdriver, which is used in discovery service test. This work is separated into commits, so if you want to focus on particular changes, check things per commit. I think it might actually make sense to leave commits unsquashed. I'll spread comments, licensing and all where it all belongs (last commit as of now) and if we'll think that merging those commits isn't a good idea and squashing zedrouter and pubsub changes would make sense, we can do separate PRs (or I can squash them in this PR :D)

The long list of subscriptions it needs to create further emphasizes the requirement to get pubsub usage simpler, if we can, but that is beyond scope of this PR.

Oh well, there's always space for some refactoring :art: , but I agree @deitch. PubSub needs revision, first and foremost, we need to understand the requirements for pubsub 2.0. For instance, what we discussed privately: we want filtering, not different namespaces for subscriptions. I think it's time get this all in one list and see if there's something out there, which will fulfill our requirements or if there should be some more refactoring for PubSub involved.

I really so much want this to be a completely standalone service. I don't think we have a service that starts itself and another "sub-service" anywhere else in eve. @uncleDecart explained to me privately that it would be quite difficult to do, so I have to accept it. I do think it is worth expanding on a bit here - not in the PR comments, but in comments right where we run it - why it is run as part of zedrouter and not as a separate service.

Yep, makes sense to add comment explaining why it's running like this. Will do that.

Yetus is fixed, comments addressed :)

@eriknordmark I squashed the commits, it helped. Handlers are moved and also I repacked them to be functions instead of different structures which define ServeHTTP, this way handlers are methods of Msrv struct.

As part of this I see some changes burried in this PR which should be discussed as separate commits and/or PRs. One is having sendError() return json instead of text. Another is the patchenvelopes returning a 404 when there are no envelopes instead of a 200 with an empty response. (To be the latter is odd, because the client asked about the list of patch envelops and that resource does exist - the content is an empty list. Which is different than the API endpoint/URL/resource not existing.)

Agreed, removed it. Functions are same from zedrouter. There was also mixup in commits, cleaned it up.

As part of this I see some changes burried in this PR which should be discussed as separate commits and/or PRs. One is having sendError() return json instead of text. Another is the patchenvelopes returning a 404 when there are no envelopes instead of a 200 with an empty response. (To be the latter is odd, because the client asked about the list of patch envelops and that resource does exist - the content is an empty list. Which is different than the API endpoint/URL/resource not existing.)

Agreed, removed it. Functions are same from zedrouter. There was also mixup in commits, cleaned it up.

Did you check that there aren't any other fixes/changes burried in those two files? (It is too hard to eye-ball looking for things like that.)

As part of this I see some changes burried in this PR which should be discussed as separate commits and/or PRs. One is having sendError() return json instead of text. Another is the patchenvelopes returning a 404 when there are no envelopes instead of a 200 with an empty response. (To be the latter is odd, because the client asked about the list of patch envelops and that resource does exist - the content is an empty list. Which is different than the API endpoint/URL/resource not existing.)

Agreed, removed it. Functions are same from zedrouter. There was also mixup in commits, cleaned it up.

Did you check that there aren't any other fixes/changes burried in those two files? (It is too hard to eye-ball looking for things like that.)

Yes, compared handlers and they're the same.


[Server] Preferences: User preference setting change causing fault

Current Behavior
Meshery Server faults on change of user preferences. This fault occurs whether the user is signed into the Local or Remote Providers.
Expected Behavior
User preference should be updated without fault.
Screenshots/Logs
14:54:46 http: panic serving [::1]:57053: runtime error: invalid memory address or nil pointer dereference
goroutine 352 [running]:
net/http.(*conn).serve.func1(0xc000c2ce60)
	/Users/lee/sdk/go1.16.4/src/net/http/server.go:1824 +0x153
panic(0x64adf60, 0x7f915a0)
	/Users/lee/sdk/go1.16.4/src/runtime/panic.go:971 +0x499
github.com/layer5io/meshery/handlers.(*Handler).UserPrefsHandler(0xc000a90100, 0x6c77550, 0xc00056c620, 0xc001739900, 0xc0016eac60, 0xc000572ec0, 0x6cc0b10, 0xc000270640)
	/Users/lee/code/meshery/handlers/user_handler.go:67 +0x199
github.com/layer5io/meshery/handlers.(*Handler).SessionInjectorMiddleware.func1(0x6c77550, 0xc00056c620, 0xc001739500)
	/Users/lee/code/meshery/handlers/middlewares.go:168 +0x8d9
net/http.HandlerFunc.ServeHTTP(0xc0005d46a8, 0x6c77550, 0xc00056c620, 0xc001739500)
	/Users/lee/sdk/go1.16.4/src/net/http/server.go:2069 +0x44
github.com/layer5io/meshery/handlers.(*Handler).AuthMiddleware.func1(0x6c77550, 0xc00056c620, 0xc001739500)
	/Users/lee/code/meshery/handlers/middlewares.go:65 +0x129
net/http.HandlerFunc.ServeHTTP(0xc00069c920, 0x6c77550, 0xc00056c620, 0xc001739500)
	/Users/lee/sdk/go1.16.4/src/net/http/server.go:2069 +0x44
github.com/layer5io/meshery/handlers.(*Handler).ProviderMiddleware.func1(0x6c77550, 0xc00056c620, 0xc001739400)
	/Users/lee/code/meshery/handlers/middlewares.go:33 +0x1e7
net/http.HandlerFunc.ServeHTTP(0xc00069c940, 0x6c77550, 0xc00056c620, 0xc001739400)
	/Users/lee/sdk/go1.16.4/src/net/http/server.go:2069 +0x44
github.com/gorilla/mux.(*Router).ServeHTTP(0xc000b30180, 0x6c77550, 0xc00056c620, 0xc001738700)
	/Users/lee/code/go/pkg/mod/github.com/gorilla/mux@v1.8.0/mux.go:210 +0xd3
net/http.serverHandler.ServeHTTP(0xc0002f2a80, 0x6c77550, 0xc00056c620, 0xc001738700)
	/Users/lee/sdk/go1.16.4/src/net/http/server.go:2887 +0xa3
net/http.(*conn).serve(0xc000c2ce60, 0x6c7e888, 0xc000572000)
	/Users/lee/sdk/go1.16.4/src/net/http/server.go:1952 +0x8cd
created by net/http.(*Server).Serve
	/Users/lee/sdk/go1.16.4/src/net/http/server.go:3013 +0x39b

Environment

Host OS: Mac
Platform: Kubernetes
Meshery Server Version: stable-v0.6.0-rc-5b
Meshery Client Version: stable-v0.6.0-rc-5b

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

can I pick this issue ?

@sourikghosh thanks so much for asking. The fix for this issue will span multiple code bases. It's a relatively involved and moderately difficult issue. Let me help you find another golang-based issue in which it will offer an easier, and therefore more successful, ramp into the project.

@sourikghosh, I see you open PR now. That's great. Will you confirm that this fix works in the following scenarios:

When signed in under the Local "None" Provider, User preferences can be saved in our persisted for the lifetime of the Meshery Server deployment
When signed in under the Remote "Meshery" Provider, user preferences can be saved and are persisted in between user sessions and in between Meshery Server deployments.

I had a call with @theBeginner86  yesterday to review these different scenarios and the expected behavior, So he is a good individual with which to collaborate to the extent that help is needed.


Add Nextflow language server

feat: add nextflow-language-server
fix(nextflow): Try going in a different direction
chore(nextflow): Clean up version
fix(nextflow): use vsix instead of zip
chore(nextflow): Update to original repo

Describe your changes

Adds the Nextflow language server that's in the VS Code extension.
Let me know if there's a better way of doing this!
Issue ticket number and link

Checklist before requesting a review

[x] I have successfully tested installation of the package.
[x] I have successfully tested the package after installation.

Screenshots

@edmundmiller I know I closed my PR, but I think it would be a good idea to update this PR to use the language server directly rather than the VS Code extension since the repo has CI/CD setup now

@mehalter Done! Let me know if you know how to take care of the other steps like lsp-config, or how to get this set up minimally with neovim! I think we should add those instructions to the nextflow/language-server repo, or link out to the docs on it in the respective places.

Thanks @edmundmiller I left a few comments for things to fix in the spec here and I commented on the issue you opened on the language server itself with the Neovim installation instructions!

This language server has been added to nvim-lspconfig and is awaiting this PR for addition to mason-lspconfig: https://github.com/williamboman/mason-lspconfig.nvim/pull/486

@mehalter So this PR is blocked until the mason-lspconfig PR gets unblocked?

No, this PR needs to be merged before mason-lspconfig

No, this PR needs to be merged before mason-lspconfig

Gotcha! Anything we need to do here then? First time contributor here 😬


Re-Route Nodes

Hey @jerosoler, me again....
I was wondering how hard it would be to add reroute nodes like how Unreal does it so I can make my flowcharts neater especially when routing back to the beginning.

Thanks,
Joe

I study it!
It doesn't seem simple but I think it can be done.
have not worked with unreal, but it only allows a one reconnection?
I think I have an idea.

Double click in connection for create point.
Move point.
Store point in ouput connection.

"outputs": {
                         "output_1": {
                             "connections": [
                                 {
                                     "node": "17",
                                     "output": "input_1"
                                     "point": {
                                         pos_x: 100,
                                         pos_y: 50,
                                      }
                                 }
                             ]
                         }
                     },

How about?

Hey!
I like the idea of double clicking! The point you have shown would work well too!
In unreal you can have multiple points depending on the type of thing you are doing. Unreal has two types of routes, one for variables and one for that actual flow. The flow routes can only have one connection, however variable routes can have multiple connections.
See:

However I feel for this implementation a single connection would be sufficient.
Thanks!
Joe

Okey.
I look with calm.

Hey @jerosoler
Any updates on this?
Thanks,
Joe

Hello
Not yet.
I have not had time. And it is an advanced function.
Jero

Thanks for your time @jerosoler !

Working...

Hey @jerosoler!
This is perfect! Just what I was looking for. Thank you so much!!
Thanks,
Joe

I just uploaded a new version with the reroutes. https://github.com/jerosoler/Drawflow/commit/bbe7ae033f7c0c9d0b33505478383188623c1dc8
Active reroute connections. Use before start or import.
editor.reroute = true;

New events:

Event
Return
Description

addReroute
id
id of Node output

removeReroute
id
id of Node output

How to use
Create point with doble click on line connection. Doble click on point for remove.
The first and the last connection of reroute is curved. Others linear. Is possible change curvature others with:
editor.reroute_curvature = 0 // 0 default   | normal curve 0.5.
And change the with of rerouter point
editor.reroute_width = 6 // default 6
Please try! ;)
I just found a bug but I don't think it will affect you as it affects:
removeNodeInput
removeNodeOutput
Jero

Fix bug for removeNodeOutput and removeNodeInput on version 0.0.17 😉

Hey @jerosoler !
I have merged this into my own fork (with the weird addNode function) and when I double click to add reroute node it places it right in the bottom right corner of the grid.
Please see this video: https://i.gyazo.com/e32d8c5358fabd8b435a9628c3e8a922.mp4
Do you know what would be causing this?
Thanks,
Joe

The problem is the css.
Have you copied the css file?
The new css:
.drawflow .connection .point {
  cursor: move;
  stroke: black;
  stroke-width: 2;
  fill: white;
  transform: translate(-9999px, -9999px);
}

.drawflow .connection .point.selected, .drawflow .connection .point:hover {
  fill: #1266ab;
}

This is very cool! Though I think being able to reroute also means that you can direct a connection to a reroute point instead of the port that line is being connected to. You can see what I mean by this in one of the above images where it's labeled "merge execution".
This doesn't seem to be the case in the demo.

Hey @jerosoler !
I made the CSS change and that fixed the weird issue! So thanks for that. 😄
The reroute nodes don't seem to work very well when the connection is coming from in front of the current node, for example:

Also what @Ataraxy is saying is very valid. Being able to connect multiple connections into the reroute node would be very useful! I think for the first release of reroutes this was not planned (see comments above)
Thanks,
Joe

Hi @icabbi-joegarlick
If I realized that.
So the central connections are linear.
Example:

The solution is to add more points. (It is not the best solution)
I will look to add a function to be able to create your own custom curvature.
I'll take a look at the topic of @Ataraxy

New system of connections for reroute.
Examples:
Before

After

Before

After

Method curved default

New function for suscribe the curvature:
editor.createCurvature = function(start_pos_x, start_pos_y, end_pos_x, end_pos_y, curvature_value, type) {
      var center_x = ((end_pos_x - start_pos_x)/2)+start_pos_x;
      return ' M ' + start_pos_x + ' ' + start_pos_y + ' L '+ center_x +' ' +  start_pos_y  + ' L ' + center_x + ' ' +  end_pos_y  + ' L ' + end_pos_x + ' ' + end_pos_y;
    }

Is possible change the curve with three parameters:
    editor.curvature = 0.5; // Default no reroute
    editor.reroute_curvature_start_end = 0.5; (Firs and end reroute connection)
    editor.reroute_curvature = 0.5; // (Other reroutes)

Commit: https://github.com/jerosoler/Drawflow/commit/094b182f14486e0823e4977635dab24a604e53d9
Update in version 0.0.18

Hey!
This is now working a lot better and is a lot easier to make look right however I am having a weird issue when I add a reroute node after a few have already been added. See video:
https://i.gyazo.com/b343b7f03f493dcddc294d22405be5c6.mp4
Thanks,
Joe

Hello
Do you follow an order when adding the points?
This happens to you when a point is added before a previous point?
The points follow an order.
Jero

Hey,
Ah this will be the issue then, No I did not follow an order. However, I think adding reroute nodes shouldn't have to be in order as this could easily cause issues and confuse the end user.
Thanks,
Joe

Hey!!
I just updated: https://github.com/jerosoler/Drawflow/commit/75fbb340b52644ed27f4a5bcdef9832321f6baf1
Try adding:
editor.reroute_fix_curvature = true;

Jero

Hey @jerosoler!
This is working much better now, thank you do much for all the hard work!
The only other slight issue I can see is making backward nodes curve, for example this:

If this can connection can be made curved then We can close this issue off!
Again I really appreciate all the time you spend on this!
Thanks,
Joe

Hello @icabbi-joegarlick
Could you draw the curve you are commenting on above the image?
Have you tried playing with the following values?
 editor.curvature = 0.5; // Default no reroute
    editor.reroute_curvature_start_end = 0.5; (First and end reroute connection)
    editor.reroute_curvature = 0.5; // (Other reroutes)

Or have you thought about overwriting the drawing function of the connections?
editor.createCurvature = function(start_pos_x, start_pos_y, end_pos_x, end_pos_y, curvature_value, type) {
...
}

Jero

Hey @jerosoler
I have added the two settings you suggested but the issue is still happening. See:
https://i.gyazo.com/5caef04fcf5e667e8db5e3df2f04a86a.mp4
I would like the curve like the following:
Before:

After:

Thanks,
Joe

Hello
The default curve includes two curves.
What you comment only includes a curve.
For that type of curve the function would have to be overwritten.
editor.createCurvature = function(start_pos_x, start_pos_y, end_pos_x, end_pos_y, curvature_value, type) {
...
}

With a curve similar to this:
return ' M '+ line_x +' '+ line_y + ' q ' + (x-line_x)/2 + ' ' + (y-line_y) + ' '   + (x-line_x) +' ' + (y-line_y);

We currently use Curveto, I suppose with a Quadratic Bézier curve. It could be done.
https://www.w3schools.com/graphics/svg_path.asp
I look at it calmly.
Jero

Hey @jerosoler!
Would it be possible to add a function to programmatically add reroute nodes?
Thanks,
Joe

Hello @icabbi-joegarlick
View: https://github.com/jerosoler/Drawflow/issues/46
Jero

Thanks @jerosoler,
I will take a look and see if I can get that working.
Thanks,
Joe

Would it be possible to make the "addReroute" event return more data that could be used to re-create it. Like what the mentioned function accepts.
I plan to save reroutes to a database once created then be able to load them back in once the page is reloaded
Thanks,
Joe

The information is saved in node.
You can get the information with the method getNodeFromId(id)


Remove flatten networks and refactor test

PR to remove flatten_networks(...) as it is not being used for anything meaningful anymore in the library.
The test where it was being used in test_contraction_sequence_to_graph now directly constructs a flatened network by just calling ITensorNetwork(g; link_space =2) avoiding any use of siteinds.
This should address Issue #164

Great, thanks! Always nice to see code get deleted.