3.1.3

Release Type
patch
For major/minor releases Create release/<MAJOR>.<MINOR>.x Branch

[ ] Create the release/<MAJOR>.<MINOR>.x branch at the place where you want to branch of off main

For all releases Create prepare-release/x.y.z Branch

[x] Ensure that you have up to date copy of main: git checkout main; git pull or a targeted release branch e.g. release/2.7.x: git checkout release/2.7.x; git pull
[x] Create the prepare-release branch for the version (e.g. prepare-release/2.7.1): git branch -m prepare-release/2.7.1
[x] Review carefully CHANGELOG.md. Manually reorder entries for relevance, common topic, adjust description, etc. - make it clear and easy to follow for users. Optionally headline notable changes (emojis are allowed). Double-check that dates are correct, that link anchors point to the correct header, and that you've included a link to the GitHub compare link at the end. If there were any RC releases before this version, fold their changes into the final release entry.
[x] Resolve all licensing issues that FOSSA has detected. Go to Issues tab in FOSSA's KIC project and resolve every issue, inspecting if it's a false positive or not. ignored.go script should be useful to look for issues that have been already resolved and reappeared due to version changes.
[ ] Update ignored.json following instructions in README.
[x] Retrieve the latest license report from FOSSA and save it to LICENSES (go to Reports tab in FOSSA's KIC project, select 'plain text' format, tick 'direct dependencies' and download it).
[x] Ensure base manifest versions use the new version (config/image/enterprise/kustomization.yaml and config/image/oss/kustomization.yaml) and update manifest files: make manifests
[ ] Push the branch up to the remote: git push --set-upstream origin prepare-release/x.y.z

For all releases Create a Release Pull Request

[ ] Check the latest E2E nightly test run to confirm that E2E tests are succeeding. If you are backporting features into a non-main branch, run a targeted E2E job against that branch or use ci/run-e2e label on the PR preparing the release.
[ ] Open a PR from your branch to main. Set a backport release/X.Y.Z label.
[ ] If this is a patch release, ensure that the release branch (e.g. release/2.9.x) compared against the latest patch for this minor release (e.g. v2.9.0) includes the expected changes that the release should include (e.g. by checking https://github.com/kong/kubernetes-ingress-controller/compare/v2.9.0..release/2.9.x).
[ ] Once the PR is merged (the prepare-release/x.y.z branch will get automatically removed), approve and merge the automatic backport PR and initiate a release job on the main branch for major or minor release, for patch use the release branch. Your tag must use vX.Y.Z format. Set latest to true if this is be the latest release. That should be the case if a new major.minor release is done or a patch release is done on the latest minor version.
[ ] CI will validate the requested version, build and push an image, and run tests against the image before finally creating a tag and publishing a release. If tests fail, CI will push the image but not the tag or release. Investigate the failure, correct it as needed, and start a new release job.
[ ] The release workflow (.github/workflows/release.yaml) will update the latest branch - if the released version was set to be latest - to the just released tag.

For major/minor releases only Update Release documents

[ ] Trigger release_docs workflow. Note that you will need to update the new version's navigation manifest (e.g. for 2.7 to use the new files (CRDs and CLI arguments references) after.
[ ] Ensure a draft PR is created in docs.konghq.com repository.
[ ] If you are adding a new CRD, add a new description file under app/_includes/md/kic/crd-ref/. This is a brief description injected into the CRD reference page.
[ ] Update articles in the new version as needed.
[ ] Update reference/version-compatibility.md to include the new versions (make sure you capture any new Kubernetes/Istio versions that have been tested)
[ ] Copy app/_data/docs_nav_kic_OLDVERSION.yml to app/_data/docs_nav_kic_NEWVERSION.yml and update the release field to NEWVERSION. Add entries for any new articles.
[ ] Make sure that app/_data/docs_nav_kic_NEWVERSION.yml links to the latest generated custom-resources-X.X.X.md.
[ ] Add a section to app/_data/kong_versions.yml for your version and move the latest field to version that's being released.
[ ] Add entries in support policy documents: app/_src/kubernetes-ingress-controller/support-policy.md and app/_includes/md/kic/support.md.
[ ] Mark the PR ready for review.
[ ] Inform and ping the @Kong/team-k8s via slack of impending release with a link to the release PR.
[ ] Ensure that KGO works with the released version of KIC. Update and release it if needed.

For major/minor releases only Bump charts' dependencies

[ ] Bump the KIC version in the kong/kong Helm chart and release a new version of the chart.
[ ] After kong/kong is released, bump the dependency on kong/kong chart in the kong/ingress Helm chart and release a new version of the chart.

Conformance tests report
Trigger for released version CI workflow Generate Kubernetes Gateway API conformance tests report, verify artifact and submit it to https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports. It's still in experimental phase. Update the KIC version in the README's Gateway API conformance badge.
Release Troubleshooting
The Release Troubleshooting guide covers strategies for dealing with a release that has failed.

My suggestions to get included in this release:

https://github.com/Kong/kubernetes-ingress-controller/pull/5764
https://github.com/Kong/kubernetes-ingress-controller/pull/5763

This release will include the following PRs:
Remove unnecessary tag support check that could incorrectly delete
configuration if the check did not execute properly.
#5658

Do not require rsa_public_key field in credential Secrets when working
with jwt HMAC credentials.
#5737
Set proper User-Agent for request made to Kong and Konnect.
#5753
Do not attempt to retrieve namespace information for errors involving
cluster-scoped resources.
#5764
Emit a log when recording events.
#5763
Do not forget to backport them to the release/3.1.x branch.

Release contents:
* 9af1396ad - (HEAD -> release/3.1.x, origin/release/3.1.x) [backport release/3.1.x] fix: add check for existence of HTTPRoute in KongUpstreamPolicy controller (#5806) (5 days ago) <Grzegorz Burzyński -<EMAIL_ADDRESS>* cb6e7aba9 - fix: do not require namespaces when parsing errors about cluster scoped resources (#5764) (#5789) (5 days ago) <Patryk Małek -<EMAIL_ADDRESS>* a69511fa7 - fix(webhook): do not require rsa_public_key field in credentials secrets when working with jwt HMAC algorigthms (#5737) (#5791) (6 days ago) <Patryk Małek -<EMAIL_ADDRESS>* a3d8c2b39 - fix(init) remove check for tag support (#5682) (#5795) (6 days ago) <Kong's Team k8s bot -<EMAIL_ADDRESS>* dc8425f38 - feat: log an error when configuration fails to get applied and KongConfigurationApplyFailed is emitted (#5763) (#5790) (6 days ago) <Kong's Team k8s bot -<EMAIL_ADDRESS>* 49c411695 - (tag: v3.1.2, origin/latest) prepare release 3.1.2: update CHANGELOG for kic 3.1.2 (#5694) (#5696) (4 weeks ago) <Kong's Team k8s bot -<EMAIL_ADDRESS>

Release is out: https://github.com/Kong/kubernetes-ingress-controller/releases/tag/v3.1.3
Docs PR: https://github.com/Kong/docs.konghq.com/pull/7190


What's the plan for the future of this plugin?

There have been no releases despite there having been active contributions.
We at @contra heavily rely on Relay and would want to have a functioning ESLint plugin.
Do you need help maintaining this package?
If you are not planning on maintaining this package, would you be open to handing over the namespace?
We are leaning towards publishing eslint-plugin-relay fork, but I wanted to discuss with the existing maintainers before taking any initiative here.

Hey @gajus thanks for the prompt. Our goal here is to ship tagged NPM releases from this repo off of the main branch, like we do with all the Relay packages to unblock folks who want to use more modern commits.
We also want to make shipping new NPM versions as easy as adding a commit with a new version. This should enable internal contributors, but also our newest external contributor @alloy to ship releases.
Unfortunately we are stuck on getting this automation working. It looks like you've seen our progress, and where I'm currently stuck here.
Any ideas/suggestions would be most welcome. This workflow works on the Relay repo, so I believe it should work here. We've tried with a number of NPM auth tokens from two accounts, and using both the new and legacy style tokens. No success.
Following up on this is on our list, but unless someone has ideas of something to try I suspect I won't get back to it until the new year. Any help would be great though!

Okay, we've managed to get publishing form CI figured out. Folks can grab the most recent versions of this plugin using the @main tag. The current (today) main branch of this repo is published here: https://www.npmjs.com/package/eslint-plugin-relay/v/0.0.0-main-f74143f31723425ccf83df61de3bb9cea20d8619

Cool to here you got something going :)
Hope this will enable new contributions and maintenance over this plugin


Did you call validation_step during training?

Hi, thanks for your great work! I plan to use your model to train on custom dataset. However, when I trained it on a subset of your specified dataset, I did not see a validation procedure. Will the function validation_step be called? Moreover, it seems that you did not have a separate valid_dataloader because only one dataloader was passed into trainer.fit.
https://github.com/ali-vilab/AnyDoor/blob/ddcfbafb8fa4f27a2da705a3bcf5bfd2de4fbf98/run_train_anydoor.py#L70
Then how do you save the best model parameters which gave the lowerest loss during validation? Yes, I asked this question because I wanted to save the best model on validation dataset but did not make it yet:( I am not so familiar with pytorch lightning and the way controlnet should be trained, so correct me if I said something wrong:)
Btw, why did you repeat some datasets in the ConcatDataset
https://github.com/ali-vilab/AnyDoor/blob/ddcfbafb8fa4f27a2da705a3bcf5bfd2de4fbf98/run_train_anydoor.py#L64C3-L64C3
, but did not repeat image_data?

Validation: No, we did not call validation, instead we infer several training samples to see the converging process.
Picking the best model by observing the lowest loss is not reliable, and neither is calculating some quantitative metrics. So we just save models with different steps.
You could repeat the image_data, it is just a simple way to adjust the ratio of different dataset, feel free to use your own implementation.

In the run_train_anydoor.py it seems the training process will not save any model. I'm confused if i should add pl.callbacks.ModelCheckpoint in the callbacks because i'm also not familiar with pytorch lightning..

Hi, have you solved it now?I Iran into the same problem and couldn't find where to save the model after training.


Chest shops can have items taken out by hoppers

title

my suggestion would be to have settings for both having hoppers putting items in and taking them out (for farm locking)

I decided not to do this at some point but I'm unsure why. I think the hopper owner is already stored in the hopper so it should be really easy.

it is in the latest curseforge release


Problems with pip installation of the new napari version

Trying to pip install napari in anaconda 3 on a Windows produces an error.
To Reproduce
Steps to reproduce the behavior:

From terminal, pip install napari gives me:

ERROR: Exception:
Traceback (most recent call last):
  File "C:\Users\lpetrucco\anaconda3\lib\site-packages\pip\_internal\cli\base_command.py", line 188, in main
    status = self.run(options, args)
  File "C:\Users\lpetrucco\anaconda3\lib\site-packages\pip\_internal\commands\install.py", line 407, in run
    use_user_site=options.use_user_site,
  File "C:\Users\lpetrucco\anaconda3\lib\site-packages\pip\_internal\req\__init__.py", line 58, in install_given_reqs
    **kwargs
  File "C:\Users\lpetrucco\anaconda3\lib\site-packages\pip\_internal\req\req_install.py", line 928, in install
    use_user_site=use_user_site, pycompile=pycompile,
  File "C:\Users\lpetrucco\anaconda3\lib\site-packages\pip\_internal\req\req_install.py", line 461, in move_wheel_files
    warn_script_location=warn_script_location,
  File "C:\Users\lpetrucco\anaconda3\lib\site-packages\pip\_internal\wheel.py", line 432, in move_wheel_files
    clobber(source, lib_dir, True)
  File "C:\Users\lpetrucco\anaconda3\lib\site-packages\pip\_internal\wheel.py", line 381, in clobber
    ', '.join(info_dir))
AssertionError: Multiple .dist-info directories: C:\Users\lpetrucco\anaconda3\Lib\site-packages\napari\plugins\_tests\fixtures\napari_working_plugin-0.1.0.dist-info, C:\Users\lpetrucco\anaconda3\Lib\site-packages\napari-0.2.12.dist-info

I have tried also in a completely new conda env and the same happens. I was able to install using conda-forge.

Thanks for reporting @vigji and sorry we let that windows issue through!
@jni @sofroniewn, i guess my distributing my plugin discovery testing strategy is problematic for pip on windows.  I tried to emulate the discovery as closely as possible with my dist-info fixtures, but I guess I'll need to rethink that strategy if we are distributing those fixtures with the releases.  I am giving an off campus seminar today so won't be able to attend to this until this evening.

FYI I just had exactly the same problem on MacOSX-10.13. Conda installation worked fine but pip produced the exact same error message as in the original post.

thanks @guiwitz ... we obviously need to change some things on our side.  but just out of curiosity, what version of pip are you running?  on 20.0.2 I'm not getting any errors.

This happened with 19.2.3 (I actually used the wrong environment with an old pip version). Installation works fine with pip 20.0.2 for me too.


feat: port AlgebraicTopology.DoldKan.Compatibility

@joelriou The corresponding file in mathlib seems to be actively worked on, and I have trouble building it, hence it is hard to fix the last two remaining proofs: equivalence₁CounitIso_eq and equivalence₁UnitIso_eq, please have a look.

bors d+

bors merge


Automate local testing for PowerShell Core - Windows version

Because this is specifically for testing Windows Core install, no need for it to run on all other OSes.
Look under $env:ProgramFiles \ PowerShell, get latest folder, get powershell.exe and run

Also, check if PowerShell Core version is out of date with online copy and alert user (don't auto download).

Completed this with local Invoke-Build tasks.


AST example

Here is the AST example, we were talking about. I still need to double-check the code and add a README but you can already go through it once and make your remarks.

Okay, this example should now be able to display the AST for any program that clingo understands.
There are actually two things we need to talk about:

This example has a custom function to escape characters for the HTML label that might as well go into clingraph directly as a new feature.
This example would profit a lot from support for some kind of fstring as we talked about. In case we implement that feature we should change this example once more.

This was added manually :)


FileHandle: _readDataOfLength: reduce fstat() calls

Cache the blocksize and a regular file flag to avoid
repeated calls to fstat().

@swift-ci test

In general, I am skeptical of optimizations without a target, especially when the source of truth is the filesystem. What is this reduction useful for?
Also: you have a time-of-check-time-fo-use race window between the _isFile… call on 333 and the mmap immediately below, which given how volatile mmap can be is concerning.

The file size is not cached and always read just before the mmap(). Im pretty sure once an FD has been opened its filetype and block size don't change unless Im mistaken?

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.
More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412


problem: use v.W.T.F+3117-f00849 versioning model for builds

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #389   +/-   ##
======================================
  Coverage    17.3%   17.3%
======================================
  Files         192     192
  Lines        2994    2994
  Branches      512     512
======================================
  Hits          518     518
  Misses       2080    2080
  Partials      396     396

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 447bb7d...a2c392b. Read the comment docs.


fix: handle localhost and port in asWebviewUri

This PR fixes #130151
We encountered this error in code-server (fix here: https://github.com/cdr/code-server/pull/3895) and noticed that resources weren't loading in webviews due to the wrong URI being returned from asWebviewUri.

Not sure how to fix these 😅
[build/lib/layersChecker.ts]: Reference to 'URL' from 'lib.dom.d.ts' violates layer '**/vs/**/common/**' (/home/runner/work/vscode/vscode/src/vs/workbench/api/common/shared/webview.ts (60,28)
[build/lib/layersChecker.ts]: Reference to 'hostname' from 'lib.dom.d.ts' violates layer '**/vs/**/common/**' (/home/runner/work/vscode/vscode/src/vs/workbench/api/common/shared/webview.ts (61,50)
[build/lib/layersChecker.ts]: Reference to 'port' from 'lib.dom.d.ts' violates layer '**/vs/**/common/**' (/home/runner/work/vscode/vscode/src/vs/workbench/api/common/shared/webview.ts (61,106)
[build/lib/layersChecker.ts]: Reference to 'port' from 'lib.dom.d.ts' violates layer '**/vs/**/common/**' (/home/runner/work/vscode/vscode/src/vs/workbench/api/common/shared/webview.ts (61,133)

@mjbvz is this patch/fix no longer needed thanks to https://github.com/microsoft/vscode/commit/649dd18019332e4dc9090abcf0b98bccf8d57b85?

Possibly? Although I didn't test ports specifically with that fix
Did you have a chance to test the issue from #130151?

I spoke to @code-asher who tested it and I believe it could fix it:
> encodeAuthority("localhost:8080")
"localhost-003a8080"

> decodeAuthority("localhost-003a8080")
"localhost:8080"

> new URL("http://localhost-003a8080")
URL { href: "http://localhost-003a8080/", origin: "http://localhost-003a8080", protocol: "http:", username: "", password: "", host: "localhost-003a8080", hostname: "localhost-003a8080", port: "", pathname: "/", search: "" }

I will have to double-check and follow-up. If it does, I could instead add new tests for URLs with ports

Closing in favor of https://github.com/microsoft/vscode/pull/131447


Add setting to show results in a new tab without split view

Currently when you run a query the editor splits horizontally and results are displayed in the right half of the editor window.
I would like to be able to disable the splitting so I can see more columns by default.

Was able to achieve this behavior in the current version by setting sqltools.results.location to current. 😅


Represent 1 as the length of a normalized vector

In GraphicsFuzz we have various ways of generating 1, and a new one could be as length(normalize(some-non-zero-vector)).

Fixed via #413.


⚠ ClamAV has degraded performance

In b64f3eb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 464 ms

Resolved: ClamAV performance has improved in 613484b.


Fix exception if number of tabs changes

Fixes this exception:
════════ Exception caught by widgets library ═══════════════════════════════════
The following UnsupportedError was thrown building MediaQuery(MediaQueryData(size: Size(448.0, 949.3), devicePixelRatio: 3.0, textScaler: no scaling, platformBrightness: Brightness.light, padding: EdgeInsets.zero, viewPadding: EdgeInsets.zero, viewInsets: EdgeInsets.zero, systemGestureInsets: EdgeInsets(0.0, 24.0, 0.0, 0.0), alwaysUse24HourFormat: false, accessibleNavigation: false, highContrast: false, onOffSwitchLabels: false, disableAnimations: false, invertColors: false, boldText: false, navigationMode: traditional, gestureSettings: DeviceGestureSettings(touchSlop: 8.0), displayFeatures: [])):
Unsupported operation: Cannot remove from a fixed-length list

The relevant error-causing widget was:
    PersistentTabView PersistentTabView:file:///home/luke/Work/click/click_flutter/lib/pages/screens/widgets/navigation_tabs.dart:191:14

When the exception was thrown, this was the stack:
#0      FixedLengthListMixin.removeRange (dart:_internal/list.dart:71:5)
#1      _TabSwitchingViewState.didUpdateWidget (package:persistent_bottom_nav_bar_v2/components/persistent_tab_view_scaffold.dart:546:22)
persistent_tab_view_scaffold.dart:546
#2      StatefulElement.update (package:flutter/src/widgets/framework.dart:5653:55)
framework.dart:5653

This is still subject to discussion. Feel free to take part at #156 :)


⚠ Bofrost.fr has degraded performance

In 8eea6df, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1020 ms

Resolved: Bofrost.fr performance has improved in e08c4a9.


Unit Test for CalendarV2 dialog

Purpose
What is the context of this pull request? Why is it being done?
Add unit test to calendarV2 dialog
https://github.com/microsoft/botframework-skills/projects/2#card-47455060
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Just added some examples to check the unit test flow.

@lauren-mills Could you please take a look at this PR?


Can I add additional filtering options?

@CTLocalGovTeam
I have a customer that wants to add more "additional filtering".
I've added a second array to the AdditionalFilterOptions section of the config. file.  Application loads without error but only the last filter loads in the application (AQUISITION).
AdditionalFilterOptions: {
                                Enabled: true,
                                FilterFieldName: "ZONEDESC",
                                FilterOptions: [
                                    {
                                        DisplayText: "Residential",
                                        FieldValue: "Residential"
                                    }, {
                                        DisplayText: "Industrial",
                                        FieldValue: "Industrial"
                                    }, {
                                        DisplayText: "Office",
                                        FieldValue: "Office"
                                    }, {
                                        DisplayText: "Retail",
                                        FieldValue: "Retail"
                                    }
                                ]
                            },
AdditionalFilterOptions: {
                                Enabled: true,
                                FilterFieldName: "ACQUISITION",
                                FilterOptions: [
                                    {
                                        DisplayText: "Lease",
                                        FieldValue: "Lease"
                                    }, {
                                        DisplayText: "Sale",
                                        FieldValue: "Sale"
                                    }
                                ]

@CTLocalGovTeam any ideas?

@ChrisBuscaglia
The 'AdditionalFilterOptions' in SiteSelector config can hold only one filed. It is designed to support only one additional filter per tab.
In above mentioned case same key('AdditionalFilterOptions') is added in the config with different values  which is syntactically wrong, However JavaScript is handling it and considering only last value for the same key in the config.

closing this issue, opened #228 for ENH


Create new device and localization packages

move some functions out of utils into new packages.
Utils should be simple functions we can reuse between web, mobile and graphql.
We could not use utils in grahpql now, since it depended on react-native
which does not run in nodejs.

I don't like the shared-utils vs FE-utils at least. Utils should be something that doesn't depend on platform in my ears.
Device definitely depends on platform. You might be right about GetDeviceLocale, it might belong to device 🤔


update changepassword to /api/users/:id/password

Changes an account password for Guests; old password required, and Guests can only change their own account.
PUT /api/users/:id/password
Passed on UI and API test.

LGTM, please don't forget to update document accordingly.


HDDS-4151. Skip the inputstream while offset larger than zero in s3g

What changes were proposed in this pull request?
Skip the inputstream while offset larger than zero in s3g.
What is the link to the Apache JIRA
HDDS-4151
How was this patch tested?
Download a big file like 10GB, and get the cost time, compare it than without this PR, this PR can get good performance back.

@elek Please take a look at this PR, it can solve the performance issue which involved by https://github.com/apache/hadoop-ozone/pull/1212

@bharatviswa504 Thanks for your review, I reply your comments inline. In fact the performance improvement comes from https://github.com/apache/hadoop-ozone/pull/843 , I just do some refactor and do some improvements by #1212 , and unfortunately, I forget to call seek or skip before the IOUtils.copyLarge, that's my bad, and I corrected it by this PR.

@maobaolong
Thanks for the detailed explanation.
I have one comment, rest LGTM.

@bharatviswa504 Thanks for your review and suggestion, I push a new commit to address your comment, PTAL.

@maobaolong , s3WrapperInputStream.copyLarge implements the skip and copy. You can just leverage this function.

I have discussed with @ChenSammi Offline, s3WrapperInputStream.copyLarge is a duplicated code which copy from IOUtils.copyLarge,  It has been improved by  #1212.

Thank You @maobaolong for the contribution and @ChenSammi for the review.

@bharatviswa504 Thanks for review and merge it for me.


Respecting id flag passed in that causes field value to be wrapped in ObjectID

There is a bug in your implementation - when joining on a single field, it should respect join.id and wrap the value in ObjectID.

Closing as it doesn't appear to be getting merged


remote-ssh: fix Node not patching automatically

Description of changes
I've updated the logic to use Node 16 instead of Node 12, then just attempts to use Node from Nix if possible which matters on NixOS hosts where the bundled Node is dynamically linked and won't run.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1357

@SuperSandro2000 thanks so much for reviewing it, I've updated the PR to take into consideration your suggestions, please review it again if you have another chance


Please support external text editor for shader

SHADERed dosen't seems to update correctly, while I edited the vs/ps shaders within external text editor, such as Sublime Text or VS Code. Will this feature be supported in the future?
BTW, excellent work !

Hello and thanks!
Can you please explain the "it doesn't update correctly" part more? I'll need more details.
But SHADERed pretty much fully supports external editors - there are two checkboxes in Options -> General. You can make SHADERed open shaders in your default text editor & there's the "Compile shaders on file change" option that'll compile shader every time you hit CTRL+S in your external text editor (every time you make changes to the file). Works both on Linux and Windows.

"it doesn't update correctly" means it dosen't update at all.
But It's my mistake that I didn't notice the "Compile shaders on file change" option.
Thanks a lot. It works great now.


Add new section "Conditional Types". Fixed #747

Add new section "Conditional Types". Fixed #747

thanks!
@DanielRosenwasser any reservations before we merge?

I made some changes, but thanks for starting this off!


Add additional manifest checks to detect missing CRDs & CRs

This PR has two parts:

Add additional PR checks to make sure that every CRD is listed in the CRD kustomize.yaml file and that every CRD also has a sample CR for each of its API versions and is similarly listed in the kustomize.yaml file for sample CR files.
Add missing sample CRs, CRDs and references.

Checklist

[X] I have verified that my change is according to the deprecations & breaking changes policy
[X] Tests have been added
[X] Changelog has been updated and is aligned with our changelog requirements
[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5920

The check seems to be working. For example: https://github.com/kedacore/keda/actions/runs/9708520106/job/26795477554?pr=5921
Run make verify-manifests
./hack/verify-manifests.sh
ERROR: CR config/samples/eventing_v1alpha1_cloudeventsource.yaml is not listed in the resources section of config/samples/kustomization.yaml
ERROR: CRD config/crd/bases/keda.sh_clustertriggerauthentications.yaml does not have a sample CR config/samples/keda_v1alpha1_clustertriggerauthentication.yaml
ERROR: CR config/samples/keda_v1alpha1_clustertriggerauthentication.yaml is not listed in the resources section of config/samples/kustomization.yaml
make[1]: Entering directory '/__w/keda/keda'
...
./hack/../config up to date.
Check failed due to previous errors. See output above
make: *** [Makefile:1[5](https://github.com/kedacore/keda/actions/runs/9708520106/job/26795477554?pr=5921#step:12:6)3: verify-manifests] Error 1
Error: Process completed with exit code 2.

So now I need to add another commit to add the missing manifests and references.

/skip-e2e

/run-e2e internal

Sorry for the last-minute change. I just noticed that the sample CR I copied (triggerauthentication) had an API group of keda.k8s.io instead of keda.sh so I fixed the new clustertriggerauthentication one and also fixed the existing triggerauthentication.


Support Debugging in Mono scripting

I wanted to start a recorded discussion here of what it might take to support debugging when running under Mono via mono's remote debugger.   The main use case I am interested in is being able to debug through VS-Code's Mono Debugger extension.
So far I think I have the pieces to make this happen from VS-Code, but we're obviously still missing support in Cake's implementation that uses the mono script host.
Here's the piece for VS-Code that I think should mostly make it work once Cake supports it:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "StartCake",
            "type": "mono",
            "request": "launch",
            "program": "${workspaceRoot}/tools/Cake/Cake.exe",
            "runtimeArgs": [
                "--debug",
                "--debugger-agent=transport=dt_socket,server=y,address=<IP_ADDRESS>:55556"
            ],
            "args": [
                "${workspaceRoot}/build.cake",
                "--verbosity=diagnostic",
                "--debug"
            ],
            "cwd": "${workspaceRoot}",
            "console":"internalConsole",
            "noDebug": true
        },
       {
            "name": "AttachCake",
            "type": "mono",
            "request": "attach",
            "address": "localhost",
            "port": 55556
        }
    ],
     "compounds": [
        {
            "name": "DebugCake",
            "configurations": ["StartCake", "AttachCake"]
        }
    ]
}

As for the Cake changes, I think first of all we need to take a look somewhere in here:
https://github.com/cake-build/cake/blob/develop/src/Cake/Scripting/Mono/MonoScriptSession.cs#L54
Basically, this SO answer shows how to enable generating debug symbols in mono's script host:
http://stackoverflow.com/questions/875723/how-to-debug-break-in-codedom-compiled-code
What I'm not exactly clear on is how do we go from having debug symbols generated for the generated script, to resolving breakpoints from the original script before it was transformed...
@mholo65  any ideas? I see you implemented the original debugging on the Roslyn side...

On the Roslyn side (https://github.com/cake-build/cake/blob/develop/src/Cake/Scripting/Roslyn/Stable/DebugRoslynScriptSession.cs#L41) we emit the compilation to memorystreams (one for dll, and one for the pdb). Then we load the dll (+pdb) into the appdomain, and invoke "script" via reflection.
Resolving breakpoints works because scriptgen adds #Line preprocessor directives to the generated script. The #Line directives links back to the original Cake file.

@patriksvensson may correct me if I'm wrong, but in v0.20.0 when Roslyn is updated (https://github.com/cake-build/cake/issues/1540) there will no longer be need to use separate mono scripting in Cake? We can finally use an unified scripting API?

@mholo65 0.20.0 will be updating Cake to VS2017 / new RTM .NET Core SDK, but correct for 0.21.0 that's the plan.

@devlead thanks! I see milestone have been updated..
@redth, this practically means that there's no use on spending time on Mono specific scripting bits in Cake, as they will be obsolete/removed in v0.21.0
@devlead or @patriksvensson can correct me if I'm wrong :smile:

@mholo65 hopefully upgrading Roslyn is smooth sailing and works well with mono, then all the mono scriptgen stuff can be yanked out.
Don't know exact status of 0.20.0 but believe @patriksvensson said it was mainly yak shaving like StyleCop, build script refactoring, etc.

@devlead @mholo65 Correct.

Niiiice. Hopefully then debugging with what I've attempted in vs code will just work at that point!

Yes, in v0.21.0 it should work out of the box.

@Redth Can we close this issue?

Yeah. I'll open one in the vs-code repo to track getting mono debugging working there.


Add Rainbowkit demo

Summary
Add Rainbow code sample to version control.
How did you test your changes?
Manual testing.
cd examples/<sample name>
npm install
npm start

merged into https://github.com/coinbase/coinbase-wallet-sdk/pull/796


libQt5QmlModels.so.5 missing on Ubuntu 20.04

Running on Ubuntu 20.04, Python 3.8.10, installed Nuitka via pip.
python3 -m nuitka --standalone --onefile --plugin-enable=qt-plugins application.py
It seems like everything compiles correctly, I receive an output of a .bin file in my directory, but when I run it via terminal I get the following issue:
Qt WebEngine resources not found at //resources. Trying parent directory...
Qt WebEngine resources not found at /. Trying application directory...
Installed Qt WebEngine locales directory not found at location /translations/qtwebengine_locales. Trying application directory...
Qt WebEngine locales directory not found at location /tmp/.mount_launchqSkew8/qtwebengine_locales. Trying fallback directory... Translations MAY NOT not be correct.
[1024/213158.907613:WARNING:resource_bundle_qt.cpp(115)] locale_file_path.empty() for locale
/tmp/.mount_launchqSkew8/QtWebEngineProcess: error while loading shared libraries: libQt5QmlModels.so.5: cannot open shared object file: No such file or directory
/tmp/.mount_launchqSkew8/QtWebEngineProcess: error while loading shared libraries: libQt5QmlModels.so.5: cannot open shared object file: No such file or directory
Trace/breakpoint trap (core dumped)

Not sure what to do, not seeing anything on google / this repo's issues about this.

You needd to include Qt plugins for qml and webengine this to work, try that.

You needd to include Qt plugins for qml and webengine this to work, try that.

Even when including --include-qt-plugins=all it does not work.
I also tried --include-qt-plugins=sensible,qml,webengine but it says that webengine is not found for pyqt5.

Ah, PyQt5 is not well supported, use PySide2 if you can. On factory branch I have improved the plugin operation with PyQt5, but at runtime it has bugs:  https://nuitka.net/doc/factory.html

The plugin change in on develop, I would appreciate feedback if it works better with pyqt5 for you now.

The plugin change in on develop, I would appreciate feedback if it works better with pyqt5 for you now.

No, it now crashes using developer (not factory).
Nuitka-Plugins:INFO: pyqt5: Copying QtWebEngine binaries. Traceback (most recent call last):   File "/home/server/.local/lib/python3.8/site-packages/nuitka/__main__.py", line 187, in <module>     main()   File "/home/server/.local/lib/python3.8/site-packages/nuitka/__main__.py", line 173, in main     MainControl.main()   File "/home/server/.local/lib/python3.8/site-packages/nuitka/MainControl.py", line 823, in main     addIncludedEntryPoints(Plugins.considerExtraDlls(dist_dir, module))   File "/home/server/.local/lib/python3.8/site-packages/nuitka/plugins/Plugins.py", line 372, in considerExtraDlls     for extra_dll in plugin.considerExtraDlls(dist_dir, module):   File "/home/server/.local/lib/python3.8/site-packages/nuitka/plugins/PluginBase.py", line 383, in considerExtraDlls     for included_entry_point in self.getExtraDlls(module):   File "/home/server/.local/lib/python3.8/site-packages/nuitka/plugins/standard/PySidePyQtPlugin.py", line 769, in getExtraDlls     for filename, filename_relative in listDir(qt_web_engine_dir):   File "/home/server/.local/lib/python3.8/site-packages/nuitka/utils/FileOperations.py", line 230, in listDir     [(os.path.join(path, filename), filename) for filename in os.listdir(real_path)] FileNotFoundError: [Errno 2] No such file or directory: '/home/server/.local/lib/python3.8/site-packages/PyQt5/Qt/libexec'

The plugin change in on develop, I would appreciate feedback if it works better with pyqt5 for you now.

No, it now crashes using developer (not factory).
Using the following command line arguments:
python3 -m nuitka --standalone --onefile --plugin-enable=qt-plugins --include-qt-plugins=sensible,qml,webengine application.py
Nuitka-Plugins:INFO: pyqt5: Copying QtWebEngine binaries. Traceback (most recent call last): File "/home/server/.local/lib/python3.8/site-packages/nuitka/__main__.py", line 187, in <module> main() File "/home/server/.local/lib/python3.8/site-packages/nuitka/__main__.py", line 173, in main MainControl.main() File "/home/server/.local/lib/python3.8/site-packages/nuitka/MainControl.py", line 823, in main addIncludedEntryPoints(Plugins.considerExtraDlls(dist_dir, module)) File "/home/server/.local/lib/python3.8/site-packages/nuitka/plugins/Plugins.py", line 372, in considerExtraDlls for extra_dll in plugin.considerExtraDlls(dist_dir, module): File "/home/server/.local/lib/python3.8/site-packages/nuitka/plugins/PluginBase.py", line 383, in considerExtraDlls for included_entry_point in self.getExtraDlls(module): File "/home/server/.local/lib/python3.8/site-packages/nuitka/plugins/standard/PySidePyQtPlugin.py", line 769, in getExtraDlls for filename, filename_relative in listDir(qt_web_engine_dir): File "/home/server/.local/lib/python3.8/site-packages/nuitka/utils/FileOperations.py", line 230, in listDir [(os.path.join(path, filename), filename) for filename in os.listdir(real_path)] FileNotFoundError: [Errno 2] No such file or directory: '/home/server/.local/lib/python3.8/site-packages/PyQt5/Qt/libexec'

This is likely because the libexec is stored in the Qt5 folder, not Qt folder. (At least on my machine).

Thanks for the feedback, going to look at it now.

Looking into this, turns out, there is a Qt function to ask where these binaries live, using that now. Also translations and resources, while taken from the directory, Qt needs a qt.conf to stop complaining about using defaults. In this case also many binding and platform differences go away.
Also added target paths for the standalone bundle, which the plugin probably needs to enforce as being used, not sure if macOS Qt can work without, I think it did in the past, but I might not want to make the different solutions.

Updated factory with the current state. I need to look into what Debian reacts like to this, maybe Qt from apt packages is not very relocatable at all.

More improvements on factory, should also work with PyQt6 now, added a plugin for it, and did the necessary tweaks to make up for their differences introduced.

More improvements on factory, should also work with PyQt6 now, added a plugin for it, and did the necessary tweaks to make up for their differences introduced.

Alright so - it is compiling into the .bin file with no errors now. The only error shows up when running the .bin file from terminal
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in "" This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Did you include Qt plugins or did you forget this time?

Did you include Qt plugins or did you forget this time?

Nope 100% including them in the command line ,and the binary file size is large enough where I would believe QT is in it.

The qt plugins live in a separate folder. I will try on the Linuxes tomorrow. For now PySide2, PySide6, PyQt5 and PyQt6 working for QtWebEngine was quite a feat. Potentially Qt plugins need to live under a non-standard folder for PyQt5 too, and doing what's right for PySide2 won't cut it. If you want to help, play around with this:
           target_plugin_dir = os.path.join(full_name.asPath(), "qt-plugins")
Adding Qt in the middle, or remove the ull_name.asPath() part or both (add Qt, remove binding name) ought to do the trick. For that, compile only standalone and modify the file nuitka/plugins/standard/PySidePyQtPlugin.py accordingly.

The code is now on develop, I didn't have the time yet to try it out on Linux, but it ought to work for the ones previouslyworking, i.e. the PySide2/6 packages.

I had change to complete this and make my way through it finally on an Ubuntu 20.04, which is normally too new to compile, but it gave some interesting points.
a) The Qt webengine process must be executable, which of course was never an issue with Windows. So added a special exe object to yield rather than dll, and make it set x bit.
b) The libnss3 was included and prevented things from working, that's a library that must not be included and was missing, I noticed that there is inconsistency with so subversion or not in checks, rectified that too.
c) The paths for PySide2, PySide6, PyQt5, PyQt6 should no clear patterns. I added a qt.conf to convince them to use application folder, but no key set there seemed to ever impact the loading. Mayweb that exe ignores things, not sure. On most bindings there are more or less complains about where it's not, but putting at complained application dirs never works. Full of bugs, I will need to check with upstreams what this is about. I seem unable to specify the folders myself unlike we do for QML files.
d) And finally, the webengineprocess binary is using libraries which then use library that will not load unless convinced with a rpath added. They don't have it, so we need to switch from chrpath to patchelf, and for consistency, Nuitka now will always change all of them to have it.
e) And "all" was broken in the plugin, which was annoying, it was ignored. I rebased develop with a fix for that.
f) Files were copied even if already copied in some cases, esp. libuuid was subject to that, no big deal, that's rare I guess.
g) And there were duplicate DLLs warnings, because we don't normpath the DLL names when detected. The generic logic doesn't think it would have to do that, the files being the same, the auto-pick worked fine, but not needed of course.
That's a huge chunk of my life not coming back ever. Hopefully the result is good. I will have to check on macOS still, what kinds of pain we have there now.

https://nuitka.net/doc/factory.html

This is now part of the current pre-release. macOS has still not been checked, but will before release.

This is part of the 0.6.18 release.


[Discussion]Aws ProvisionRequest auto_placement should use default vpc

fog did not return is_default argument when getting a VPC, until this merge (https://github.com/fog/fog-aws/pull/299)
So until now when we select auto_placement in a aws provision request, MIQ will take the first cloud_network(vpc) it found.
Shall we make it use the default vpc in the case of AWS when we use auto_placement at PR??

@zhitongLBN makes sense to me, to use the default by default :-) Will you send a PR with this change?


Replace ConcurrentLinkedQueue by Agrona bounded MPMC

Replace ConcurrentLinkedQueue by Agrona bounded Multiple Producer-Multiple Consumer.
The reasoning for this is GC, users using the default queue if sending/receiving many small messages will generate GC because of the linked data structure.
No dependency is needed because akka-remote depends on aeron which depends on agrona
Note: I have also updated few dependencies like Akka, Kryo, etc, also it fixes #117

@luben ping :D

@luben I see SBT deprecated warning and stuff, maybe it is a good time to update SBT stuff?
Combining non-blocking GC free queue with Unsafe should be the right combo for a great performance.

@guidomedina sbt and dependencies have been updated meanwhile

I have removed changes that don't apply anymore and re-pushed to do exactly what the branch states which is to replace the example queue with a non-blocking queue which depends on a dependency pulled by the current akka-remote

The gaining should be minimal in comparison to the serialization and I/O costs but still there is some gaining in that these queues are Lock/GC free, basically there is no allocation; they act as a circular buffer; similar to https://github.com/JCTools/JCTools/blob/master/jctools-core/src/main/java/org/jctools/queues/MpmcArrayQueue.java
They all follow the same algorithm from a lock-free producer consumer paper, they are guarantee to be much faster than the standard Java ConcurrentQueue, here is the source of all of them http://www.1024cores.net/home/lock-free-algorithms/queues

Also, there shouldn't be any impact because we use here for a pool, meaning that we never pick and getting null is fine, a new Kryo instance is then created and pushed back to the queue or discarded if the queue is full, all in a non-blocking manner.

Another aspect that might be of interest since I see you guys on the FinTech, what motivated this was that this has been part of a distributed semi low latency trading FX system I developed 3 years ago, we replaced all of our actor default queues for GC-free non-blocking implementations, full cycle of order execution never exceed 1ms or 2ms which includes the time of traveling between 3 Akka nodes using Artery/Aeron.

lgtm


Allow parsing of error object by given transform

request-promise doesn't seem to apply the given options.transform function to the response object attached to a StatusCodeError.
I'd expect that transform to be applied, given the relation implied by "Rejected promises and the simple option" example. In this case, the standard request library would have parsed the request body before it was filtered by status code. The response at this point is not an error with the request so I see no gain in not parsing the response.
I realise this would be a breaking change, so was wondering if it would be of interest to pass an additional option to enable this behaviour?
For example, something along the lines of
} else if (self._rp_options.simple && !(/^2/.test('' + response.statusCode))) {
    var statusCodeError;
    if (self._rp_options.transformError && isFunction(self._rp_options.transform)) {
        try {
            body = self._rp_options.transform(body, response, self._rp_options.resolveWithFullResponse);
        } catch (e) {
            return self._rp_reject(e);
        }
     }
     self._rp_reject(assign(new errors.StatusCodeError(response.statusCode, body), {
        error: body,
        options: self._rp_options,
        response: response
     });

Thanks

Hi @Limess good point. Thinking about that I have several APIs I call which usually return JSON but HTML for e.g. a 404. In this case the transform function would need to check the response.statusCode (second argument) and transform appropriately. So I wonder how useful this would actually be. Could you describe me your use cases for which you would like to use the new option?

@analog-nico
I was actually under the impression that request-promise didn't automatically parse the response body as JSON when raising this issue, I've since realised that isn't the case!
Problems do still arise however. We're dealing with APIs which always return JSON. There's a current case when they return non-400s and we use the simple flag:
The message set on StatusCodeError is Error: ${error.statusCode} - [Object object] as it is set without transform, and there is no option to do this transform with simple. It'd be easier if we could transform the body to a readable message and useful error response here.
Admittedly that could be done by catching the error and re-throwing appropriately, but it's caught us out that we get unintelligible error messages with non-200s by default, and it may be useful to have an optional transform in this specific case.
It'd be nice to have your thoughts on how to handle these scenarios from an error handling point of view!

I can't really tell what is better because I do not use the transform feature personally. But since transform was introduced for usability it now seems natural to me to also transform non-200 responses. The transform function reduced another .then(...) for 200 responses and would now also reduce the additional .catch(...) for non-200 responses. The only drawback is the breaking change. Anyway, I think I will include this in the next major release.

Hi @Limess quick question: What do you think about adding a responseTransformed parameter to the StatusCodeError. Then response will still be the untouched response and responseTransformed the transformed response if a transform function is provided.
I see the advantage that (1) it is backwards compatible and (2) if the API returns a weird response the transform function could crash without screwing up the response handling. (responseTransformed would hold the Error thrown by the transform.) The developer implementing the transform function doesn't have to think about all error cases upfront - which would likely be impossible to do anyway.
As a disadvantage I see the inconsistent API.
Alternatively, we could put the transformed response into response and the original into responseNotTransformed.

I just released<EMAIL_ADDRESS>which solves this issue.
StatusCodeError.response is the transformed response now. See the migration instructions at the top of the README for more info.


can anyone tell me what's the format of trips-data.txt

I want to use custom trips-data.txt file with my own lat and long . but the current file is encoded can you guys tell  how can i encode and decode that file .

I will appreciate your help

@gnavvy @Pessimistress any ideas?

@zohaib055 the file is compressed for faster loading. If you want to use the trips layer with your own data, checkout the readme file: https://github.com/uber/deck.gl/blob/master/examples/sample-layers/trips-layer/README.md

@Pessimistress  i have been using this example https://uber.github.io/deck.gl/#/examples/trip-routes .. want to put own lat long and timestamp  . can you give on short example showing one line on the map with custom lat long and timestamp

@Pessimistress  Looks like d.path  is path to the data object that provides lat long and timestamp but but how would i give path to the custom file or object

@Pessimistress  i can see the lat long segments in side the object this.props in trips-layer.js file
my questions how i pass my custom object having the same this or should i overide these segments ?

@Pessimistress  ^^

my questions how i pass my custom object having the same this or should i overide these segments ?

@zohaib055

All layers take a data prop. It should be an array of objects. The layer will query each object for some data and build a WebGL geometry to render it.
You may also need to provide accessors. In the case of trips-layer you need to define getPath and getColor. These should be functions that return the path and the color. Each path is an array of coordinates.  The defaults return object.path and object.color, so if you structure your objects that way you don't need to specify accessors..

<DeckGL ... layers={[
  new TripsLayer({
     data: [
        {path: [[lng, lat, z], [lng, lat, z], ...], color: [255, 0, 0, 255]},
        {path: [[lng, lat, z], [lng, lat, z], ...], color: [255, 0, 0, 255]},
        ...
     ]
  })
]}/>

@zohaib055  Correction. As specified in the README, it should be timestamp instead of z as third coordinate above.

Thanks @ibgreen


rnv new  implementation

add support for passing project name as an argument. Maybe even implement the current --ci flag as well, to go through the setup with the default settings

I think this can be closed now?  - https://github.com/renative-org/renative/pull/732


add: Fortran Playground Code links

This PR is to add The fortran playground links to every fortran code in the learn section. I have currently not added the links to intrinsics as feature is in testing phase.
Thanks and Regards,
Henil
CC @awvwgk

#build_preview

#build_preview

This is great, thank you for making it. A few suggestions:

Reword as "Run in the playground"
Remove the logo from the playground; I think it adds noise and at this point the reader knows it's Fortran
Link under the snipper instead of above; we want the reader to read the snippet first, and then run it in the playground if they want to.
Have the link open the playground in a new tab
Either provide the link only for snippets that will compile and run, or we need to update the snippets to be complete. It will be a lot of work to update the snippets to be complete, so I suggest for now to exclude the link if the snippet is not complete.

@milancurcic how should we detect incomplete snippets ?

Oh, are the links populated automatically for every snippet? I see. I thought you added them by hand and could be excluded by hand. In that case, I don't have a good idea at the moment. We could leave it as you have it now, and let the reader figure out that they need to fix an incomplete snippet for it to compile and run.

@milancurcic Will rebase it.

@milancurcic We won't be able to add it below as i have added a node with link in the caption using doc util nodes of sphinx.

#build_preview

#delete_preview


Revert "feature/k8s 125"

Reverts gruntwork-io/kubergrunt#185

hotfix branch fixes the failing test


support neverlink

Hi,
I've started to depend on maven_jars via their own BUILD files inthird_party and having a scala_library inside them. The reason I need scala_library and not java_library is because I need it to depend (runtime_deps) on some of my own targets AND because of https://github.com/bazelbuild/bazel/issues/3171 .
I need some of them to have a neverlink option and that isn't supported by rules_scala.
@ulfjack would appreciate any pointers you can spare.
cc @sdtwigg who touched this area if I'm not mistaken when working on the seams of java/scala

I'm pretty sure the implementation is just this: https://github.com/sdtwigg/rules_scala/commit/478ce28166c376d9540f2ce4a1008e652bbee46a
It models how the native rules handle neverlink: (roughly) add to compile jars but not runtime jars.
Sorry, I did that last week but ran out of time to test it so didn't send it out.

isn't this a duplicate of #213

it is


feat: pushsync sanctions closest node on push error

This change is

Hi Esad, thank you for the PR. Could you please update the PR description?


Any idea how to get a Note 9 to stop doing this while using keyboard and mouse?

This happens what seems to be every 60 seconds or so if I don't interact physically with the screen when using this app. I have my display set to turn off after 10 mins (since there does not appear to be a way to set it to "never" It's making things rather difficult for me. Any idea how to prevent this?

It seems to be the lock screen. Go to your Android display settings, and increase the delay.
Also see #631.

I have this option enabled, but it only seems to happen when I am running a game. Not when i'm doing anything else.

Does it still happen?


updated the lambda permission with the correct case

Issue #, if available:
The default policy action that get's added to the function permissions is in the incorrect case. It is being inserted as lambda:invokeFunction instead of lambda:InvokeFunction (note the i).
This means the permissions don't work as expected.
The correct case can be seen in the documentation here:
https://docs.aws.amazon.com/lambda/latest/dg/lambda-api-permissions-ref.html
When triggering the function via API gateway as a GET request the response returns as:

Unable to determine service/operation name to be authorized

This occurred when creating a CFN resource with Type: AWS::Serverless::Function
Description of changes:
I have updated the lambda action so that it is in the correct case: lambda:InvokeFunction
When creating the lambda the default policy is being added as:
"Principal": {
"Service": "apigateway.amazonaws.com"
},
"Action": "lambda:invokeFunction",
I have not updated the tests as of yet as there are a large number of files with the lowercase character. If you are happy with the change, please add a comment and I can go and update the remaining files before the change is merged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @ShreyaGangishetty ,
I have updated the rest of the tests to include the correct case. There are a few conflicts that need to be resolved, however I don't have the ability to update them myself.
Is there anything else that you need from my end? I will be happy to help where possible.
Cheers,
Tom

@tde908 I will check and resolve these merge conflicts. Thank you for submitting this PR

Codecov Report

Merging #1319 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1319      +/-   ##
===========================================
+ Coverage    94.41%   94.48%   +0.07%
===========================================
  Files           78       78
  Lines         4386     4388       +2
  Branches       870      871       +1
===========================================
+ Hits          4141     4146       +5
  Misses         116      116
+ Partials       129      126       -3

Impacted Files
Coverage Δ

samtranslator/plugins/globals/globals.py
99.05% <ø> (ø)
:arrow_up:

...lator/plugins/application/serverless_app_plugin.py
83.55% <ø> (ø)
:arrow_up:

samtranslator/model/eventsources/push.py
90.53% <100%> (ø)
:arrow_up:

samtranslator/model/api/api_generator.py
95.13% <100%> (ø)
:arrow_up:

samtranslator/model/sam_resources.py
95.12% <100%> (+0.02%)
:arrow_up:

samtranslator/model/iam.py
92.59% <0%> (+3.7%)
:arrow_up:

samtranslator/model/lambda_.py
92.3% <0%> (+3.84%)
:arrow_up:

samtranslator/model/events.py
100% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b791fe...edcf817. Read the comment docs.


Command "strapi build" does not work

In the README: the command strapi build returns strapi: command not found.  Replace it with npm run build or yarn build

To make strapi build work strapi should be installed globally in your environment. Wich I did not explain in the README.md.
By default, I think a strapi app has the npm run build command which uses the local Strapi.
Could you try this one out?

npm run build works perfectly fine


Shelley: serialisation roundtrip tests

We need to have serialisation roundtrip tests for the Shelley types we send across the wire and/or store on disk. At the moment we mostly use the From/ToCBOR instances from cardano-ledger-specs, which should already be tested in cardano-ledger-specs, but some of our types, e.g., LedgerState, augment the spec type with additional information that also needs to be encoded.
A skeleton for these tests already exists in Test.Consensus.Shelley.Ledger, only the generators still need to be written.

Addressed in #1695.


Content Type for RestInterface

My current project provides a REST API to be used by a front end written in Ember. They favour making the backend conform to the JSON API conventions. Part of which is to use the content type application/vnd.api+json.
So I've got the following where 'JsonApiImpl' is a class defining my endpoints:
auto router = new URLRouter;
auto apiSettings = new RestInterfaceSettings;
apiSettings.baseURL = URL("/api");
apiSettings.allowedOrigins = ["*"];
router.registerRestInterface(new JsonApiImpl, apiSettings);

The default seems to be to return the content type application/json but I can't seem to see a convenient way to set it to what I need.

Looks like it should be done in lines 214-240 of vibe.web.rest.

If I understand correctly, the custom content type would have to be injected here: https://github.com/rejectedsoftware/vibe.d/blob/2daaec4673bcb6806201c106bfac80e8972c305c/web/vibe/web/rest.d#L1125 (as well as for the two following calls).
This could be done using an @after annotation, but currently doesn't, because writeJsonBody always overwrites the content type header. My first fix would be to change that and only let it set it, if it hasn't been written already. Then the following could be used:
class MyService : IMyService {
@after!setContentType:

    void getSomething() {...}
    void getSomethingElse() {...}
}

void setContentType(HTTPServerRequest req, HTTPServerResponse res)
{
    res.headers["Content-Type"] = "application/vnd.api+json; charset=UTF-8";
}

A more integrated solution should be added later, once it is also clear how to support custom data  formats such as XML.

Okay, this has been implemented on master now.

thanks, I can confirm that this is sorted in 0.7.31-alpha.1
In the end, as I need that header on all responses I have used:
router.any("*", delegate(req, res) {
                res.headers["Content-Type"] = `application/vnd.api+json`;
            })

which was not possible before.


Conflicting implementations for trait serde::de::EnumSeqVisitor

Adding the following to test_de.rs causes error: conflicting implementations for trait serde::de::EnumSeqVisitor on compilation:
#[derive(Debug, PartialEq)]
#[derive_deserialize]
enum Cmd{
    Args(Vec<String>),
    Arg0(String)
}

Shucks! I was trying to be too clever. Should be pretty simple to fix though.


Disable Windows defender in CI

Testing, per:

https://github.com/actions/runner-images/issues/7320

See also:

#1830

No difference


Update scalafmt-core to 3.3.2

Updates org.scalameta:scalafmt-core from 2.7.5 to 3.3.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.7.5).
You might want to review and update them manually.
.github/workflows/format.yml

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-major, semver-spec-major, old-version-remains, commit-count:1

Coverage decreased (-0.5%) to 94.304% when pulling 06aa59909c0adecc0bd65ace1a53b3010c418485 on scala-steward:update/scalafmt-core-3.3.2 into ca10c64b98af9973d1b830d6a180d8b2c8898d98 on iheartradio:master.

Superseded by #199.


ISPN-9013 Partition Handling enabled toggle should set merge-policy=NONE

https://issues.jboss.org/browse/ISPN-9013
Added deprecation javadoc and fix log message.

Fixed @tristantarrant

I am fine with the changes, but thinking about this more. If we are doing this for backwards compatibility shouldn't the default be NONE no matter what? @tristantarrant what do you think?

I think we should have better defaults win over blind backwards compatibility. As long as a user can configure the old behaviour, I'm fine with it.


[Build][UI] Upgrade dependencies.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #10346 (003de18) into dev (e57c2d1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

:exclamation: Current head 003de18 differs from pull request most recent head e20f7d5. Consider uploading reports for the commit e20f7d5 to get more accurate results

@@             Coverage Diff              @@
##                dev   #10346      +/-   ##
============================================
- Coverage     40.45%   40.43%   -0.02%
+ Complexity     4784     4782       -2
============================================
  Files           868      868
  Lines         35369    35369
  Branches       3943     3943
============================================
- Hits          14309    14303       -6
- Misses        19624    19633       +9
+ Partials       1436     1433       -3

Impacted Files
Coverage Δ

.../org/apache/dolphinscheduler/common/Constants.java
80.95% <ø> (ø)

.../apache/dolphinscheduler/common/utils/S3Utils.java
0.00% <0.00%> (ø)

...olphinscheduler/rpc/remote/NettyServerHandler.java
69.04% <0.00%> (-7.15%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
37.77% <0.00%> (-2.23%)
:arrow_down:

...lphinscheduler/rpc/client/ConsumerInterceptor.java
89.13% <0.00%> (-2.18%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.11% <0.00%> (-1.41%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
83.60% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c47c9...e20f7d5. Read the comment docs.


fix /event response stop immediately

Swarm /events API may be will stop immediately at sometime.
After digging these codes I found that we should be carefully to stop a timer. A timer maybe has already expired, even the duration is zero.

Signed-off-by: realityone<EMAIL_ADDRESS>

LGTM

Ping @nishanttotla @allencloud

Thanks @realityone!


Mark ServerSideApply as beta in 1.16

Noticed that this line was missing from the feature-gates page in the docs

/cc @apelisse

Thanks Jenny!
/lgtm

Page preview:
https://deploy-preview-17152--kubernetes-io-master-staging.netlify.com/docs/reference/command-line-tools-reference/feature-gates/
/lgtm

/approve


Refactor Feature tests

Make sure feature tests are written in feature format, with descriptive scenarios. Also move any that don't make sense to request specs.

Added TODO notes.


Fix the last entry in CHANGELOG.md

Hey @jsdir
The last entry in the CHANGELOG is not exact.
Little PR to fix that. 🙂

Thanks


How to make attaching a document mandatory

Hi Daniel,
Im using Dropzone 2 plugin (version 2.2.1) with apex 18.2.0, and i want to know if is it possible to set the Dropzone2 plugin item to be required ?
Thank you for help.
NB:
APEX version (18.2.0)
Used web server / version and platform (ORDS 18.2.0 / Apache-Tomcat 9.0.10 / win x64)
Used web browser / version and platform (Chrome 48 Windows/ Windows Server 2016)

Hi @dpccrt87
sorry for the late response...:(
Hmm you could always use an APEX validation to query the Dropzone Collection, if no results are in there then no file had beed uploaded...

Hi Dani3lSun,
Thank you for reply, i will test it


intuitive way to convert to number only (without currency)

There is a more intuitive way to omit the currency from the result, but that involves removing EGP as the default currency.
// current
new Tafgeet('1').parse()        // واحد جنيه مصري فقط لا غير
new Tafgeet('1', '').parse()    // واحد فقط لا غير
new Tafgeet('1', 'EGP').parse() // واحد جنيه مصري فقط لا غير

// proposed
new Tafgeet('1').parse()        // واحد فقط لا غير
new Tafgeet('1', '').parse()    // واحد فقط لا غير
new Tafgeet('1', 'EGP').parse() // واحد جنيه مصري فقط لا غير

This would be a breaking change, so it might be worthwhile to increment the major version to (v2.0.0) to notify existing users.
Later, if this is implemented, we can look to validate the currency name passed in by the user and error if it is incorrect. This can also help tighten the types a bit when parsing by removing some of the typecasting.

P.S. I don't want to step on any toes. So if you intend to use this library mostly where EGP is needed, and would therefore like to keep EGP as default, that's perfectly fine. I guess what I'm asking is: would you like to see this repo become a maintained fork of https://github.com/mmahgoub/tafgeetjs, or would you prefer tailoring it to a more personal use case?
Since https://github.com/mmahgoub/tafgeetjs is currently unmaintained with 5 outstanding PR's, I personally think a community maintained fork needs to exist somewhere. Given that you've already done the legwork of adding typescript and tests, I think this is what your intention is here? Instead of assuming however, I thought it best to ask.

Actually, I like to Omit the currency and make it optional
My vision for the package is to enhance and make it more reliable
the enhancement includes grammars because it's not that good right now


Add Outer Kerbin from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of dxeh, to add Outer Kerbin to CKAN.
Mod details:
name = /mod/2066/Outer%20Kerbin
author = dxeh
abstract = An Expansion of the Kerbin SOI. Adding a new planet & moon beyond Minmus for you to explore!
license = MIT
Homepage = https://github.com/dxeh/Outer-Kerbin
description = Outer Kerbin
An expansion to the Kerbin System

Have you completely explored Kerbin?
Have you mined Minmus for fuel?
Have you found every anomaly at the surface of the Mun?
But is going to Eve or Duna not your kind of game?

Than Outer Kerbin might be what you are looking for!
By adding a new body with a small moon to the kerbin system just beyond Minmus, you get to explore more, close to home!
Have you found any issues with this pack. please notify me on Github!
Dependency
Latest Version of Kopernicus (NOT MY MOD)
https://github.com/Kopernicus/Kopernicus/releases/latest

Please direct questions about this pull request to dxeh.

This was added in #6985.


Set ttl parameter in the body of the request in the async Communication Relay Client

Set ttl parameter in the body of the request in the async Communication Relay Client.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check for com.azure:azure-communication-networktraversal
API changes are not detected in this pull request for com.azure:azure-communication-networktraversal

/azp run java - azure-communication-networktraversal - tests


Refactor ApplicationServer stack

Scope & Purpose
The goal of this PR is to refactor the ApplicationServer stack to improve maintainability and testability. Many of the methods operated on manually-entered string names rather than class types, which led to broken dependencies, etc. Many more methods and members of the ApplicationServer class were static, which made it very difficult to do testing. Additionally, this PR takes some steps to remove static instance variables from some ApplicationFeature descendants.
It is important to note that this PR does not completely destaticize ApplicationServer yet. There still exists one method server() which returns a reference initialized from the static instance pointer. Follow-up PRs will attempt to remove uses of this method, and eventually remove the method and the underlying static instance pointer altogether; however, since this PR is so large, it is best to merge it back first and then continue work in other branches so as to keep the potential conflicts minimized.
Enterprise component: https://github.com/arangodb/enterprise/pull/316

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/6381/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/6397/

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/6420/


Investigate on TCP-/HTTP/2-connections

The connections to the autoupdate server are still closed.

cannot reproduce any disconnections (also tested: laptop opens projector, goes into 'standby'/sleep mode, project new topic from other device, laptop wakes up -> new topic is shown on projector) -> looks good. So wait until new problem is reported.

cannot reproduce any disconnections (also tested: laptop opens projector, goes into 'standby'/sleep mode, project new topic from other device, laptop wakes up -> new topic is shown on projector) -> looks good. So wait until new problem is reported.

Due to this behavior, I close this issue. @emanuelschuetze, @alveolus or @rrenkert feel free to re-open this issue if any problems came up.


Fix RBAC for the APF controller

What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the RBAC for the APF controller, necessary for the apiserver-extensions.
Which issue(s) this PR fixes:

Part of investigation for #1372
Special notes for your reviewer:
I identified this problem while looking at the logs for the flaky E2E test.
This won't solve the flakiness, but will cleanup the log lines from one red-herring.
Does this PR introduce a user-facing change?

NONE

It looks like there was a weird race condition trying to delete all pods after the test case finished.
/retest

Let me see if I can catch a flake
/test pull-kueue-test-e2e-main-1-25
/test pull-kueue-test-e2e-main-1-26
/test pull-kueue-test-e2e-main-1-27
/test pull-kueue-test-e2e-main-1-28

Yeah, #1372 is still there
/retest

Due to #1484
/test pull-kueue-test-integration-main


Inquiry: New 3.0 Foundry 5e Character Sheet

Hi there! Wanted to update to the new character sheet but wanted to check if your module is compatible. I have a bunch of games coming up and your crafting mod is probably the players most favorite and important mod we use outside of normal dice rolls! Thanks again for all the hard work!

The bsa-dnd5e has already a 3.0 detection in it and when you run on 3.0 it should work with the ne charactersheet.


Tame wild white spaces

W3-inspired white space handling on paste
This PR attempts to resolve for once and for all the commonly repeated issues around spacing on paste. Turns out there's a well-defined spec (https://www.w3.org/TR/css-text-3/#white-space-processing) for what seemed to be wild-west across various editor implementations.
https://user-images.githubusercontent.com/193447/236697703-827d0e66-2a09-40ce-aaa7-f10cb8be1391.mov
https://user-images.githubusercontent.com/193447/236697707-512b8ee4-ca84-4322-88e6-2769f323a0e3.mov
W3 summary
https://www.w3.org/TR/css-text-3/#white-space-processing
When white-space is pre or similar variants, we don't do any special processing, we assume the incoming text reads as the rendered copy. This is the case for Apple Notes, Chrome, Safari and GDoc.
Otherwise, we transform the text according to collapsible rules. This applies to MS Word, Quip and Notion. Firefox fails W3 rules but it also falls under this bucket.
At a high level, collapsibles mean removing redundant spaces/LF/CRLF/tab:

At the start/end of the line
Redundant consequent
Transformation of LF, CRLF and tab into spaces

The current implementation respects the historical space transform listed in W3 (instead of removal).
BR rule
This PR also touches BR. The spec (https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-br-element) refers to a "single" element but I'm fairly confident this is after the collapsibles.
But this PR is not 100% compliant
There is quite a lot CSS to understand to make it 100% compliant (and some of these properties even go beyond what Lexical supports at this point) but the implemented should work in most cases.
For example, pre, pre-wrap and pre-line differences, understanding the tab-size to determine how it should render, display flex and table, or dropping Space Marks. I didn't prioritize any of the aforementioned because no other editor supports any these, they just handle them gracefully.
Performance
When these rules apply (bucket 2 above), Lexical obviously runs slower as it has to traverse backward and forward accordingly, slice and compute styles.
Pasting the Moby Dick test from Apple Notes results in a 10% regression, from 1.53 to 1.68s on a 2019 MBP.
Edit: dropped getComputedStyles as we don't expect clipboard users to make use of StyleSheets. And, fixed cache.
Pasting the Moby Dick test from Apple Notes results in a 0.7% regression, from 4.27s to 4.30s on a M1 with x6 slowdown.

Before
After

Bundle size
Arguably this increases the size of TextNode considerably, but eventually (as discussed with @acywatson) all HTML code will be decoupled from Core. Even without this PR, this would have a drastic bundle size decrease for our plain text users.
Implementation: why on TextNode vs a pre-cleanup?
I've discussed this one offline with @fantactuka but ultimately this one is very opinionated. The alternative to this PR would be a cleanup process before passing the DOM Nodes to the LexicalNode importDOM.
The pre-cleanup assumes that the incoming HTML is bad, but it's actually valid correct HTML, just not in the shape we like. We can add this one-off to handle spacing, but then there will be more, ultimately leading to allowing an array of cleanup steps into the plugin when there was no need to do this in the first place.
Instead, the Nodes themselves can take responsibility just like they are doing now. This might not be as optimal as the one-pass approach but the implementation is still fast considering we never look beyond inlines and that, in most cases, they won't be filled with fragmented white spaces, so average case will still be O(N).

Other relevant PRs:

https://github.com/facebook/lexical/pull/2969
https://github.com/facebook/lexical/pull/2276

Fixes https://github.com/facebook/lexical/issues/4466
Fixes https://github.com/facebook/lexical/issues/3677
Fixes https://github.com/facebook/lexical/issues/4370

@zurfyx I hope you don't mind me asking here before filing a new issue. v0.11.0 is breaking some of our copy-paste roundtrip tests where we're using \xA0 ( ) as a non-collapsible whitespace character when copying.
As far as I can tell, the spec you pointed to here doesn't allow collapsing non-breaking space characters. Specifically it has:

Except where specified otherwise, white space processing in CSS affects only the document white space characters: spaces (U+0020), tabs (U+0009), and segment breaks.

I couldn't find anywhere that allows collapsing (U+00A0).
Looking at the patch, we're using the \s character class in a number of places, e.g.
  textContent = textContent
    .replace(/\r?\n|\t/gm, ' ')
    .replace('\r', '')
    .replace(/\s+/g, ' ');

However, \s expands to [\f\n\r\t\v\u0020\u00a0\u1680\u2000-\u200a\u2028\u2029\u202f\u205f\u3000\ufeff]. Is that intended, or shall I file a bug for this?


ModuleNotFoundError: No module named 'mistralai.models.chat_completion'

Unmodified install of the code is throwing this error, on multiple systems with every requirement installed, after doing streamlit run main.py:
File "C:\Dev\stride-gpt-master\venv\Lib\site-packages\streamlit\runtime\scriptrunner\exec_code.py", line 85, in exec_func_with_error_handling     result = func()              ^^^^^^ File "C:\Dev\stride-gpt-master\venv\Lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 576, in code_to_exec     exec(code, module.__dict__) File "C:\Dev\stride-gpt-master\main.py", line 7, in <module>     from threat_model import create_threat_model_prompt, get_threat_model, get_threat_model_azure, get_threat_model_google, get_threat_model_mistral, json_to_markdown, get_image_analysis, create_image_analysis_prompt File "C:\Dev\stride-gpt-master\threat_model.py", line 7, in <module>     from mistralai.models.chat_completion import ChatMessage

Hi @AnahatM,
Are you installing the modules individually or running pip install -r requirements.txt?
I'd also recommend trying a fresh virtual environment.

Thanks for the response. I did both those things, pip install -r requirements.txt and new venv, and also re-installed python. It runs fine on docker, the local version also runs if you disable all the mistral features.

Looks like it's because Mistrail have made some breaking changes when introducing v1.x of their Python SDK (https://github.com/mistralai/client-python/blob/main/MIGRATION.md).
As a temporary fix you could pin the dependency to an earlier version. I'll look at the required updates this evening.


Adding tryFindViewElement to testing docs

fix #497
Hopefully I got everything right here....

tried to make the difference clearer.


[Analyzer] No quick fix for Unnecessary type check

I wish there were a quick fix for this:
final int a = 2;
if (a is int) { // Unnecessary type check; the result is always 'true'.
}

Suggestion:
In if/while/switch, remove the parameter. If there is nothing remaining, remove the whole expression (leave what is inside intact).

That sounds more like an argument for changing the unnecessary_type_check hint to not flag in cases where it might be necessary because of side-effects. @srawlins In case you're interested.
But as for the fix, we don't actually require that fixes be semantics preserving. We assume that developers will use discretion when editing their code.

I vote that we should cater checks like this to being useful in the typical case, and force users to write // ignore: unnecessary_type_check in the "getter with side effects" case.

https://dart-review.googlesource.com/c/sdk/+/279351


Fix #815

[x] There exists an issue discussing the need for this PR
[x] I added new tests for the issue I fixed or built
[x] I used make commit instead of git commit

There is a typescript error in the build:
/home/travis/build/cyclejs/cyclejs/node_modules/ts-node/src/index.ts:250
    return new TSError(diagnosticText, diagnosticCodes)
           ^
TSError: ⨯ Unable to compile TypeScript:
test/index.ts(87,7): error TS2345: Argument of type '{ str: Driver<Stream<string>, Stream<string>>; num: Driver<Stream<number>, void>; obj: Driver<voi...' is not assignable to parameter of type 'Drivers<Sources, { str: MemoryStream<string>; num: Stream<number>; }>'.
  Object literal may only specify known properties, and 'num' does not exist in type 'Drivers<Sources, { str: MemoryStream<string>; num: Stream<number>; }>'.
test/index.ts(127,7): error TS2345: Argument of type '{ str: Driver<Stream<string>, Stream<string>>; num: Driver<Stream<number>, void>; obj: Driver<voi...' is not assignable to parameter of type 'Drivers<Sources, Sinks>'.
  Object literal may only specify known properties, and 'num' does not exist in type 'Drivers<Sources, Sinks>'.

So, I intentionally ran it in CI because I wasn't trusting that my local installation was running the correct TypeScript version. Somehow VSCode doesn't show those two errors when I open test.ts and check those lines, but when I run tsc in the terminal I see those errors. Anyway it seems like the proposed solution in types.ts doesn't work.

Is this going to be resolved any time soon?


chore(pre-deploy): Display only merged pull requests in log

We're not supposed to commit without creating pull requests. So showing all the commits in pre-deploy logs is just creating noise and we miss the important information.
New logs (5 entries)

[2019-03-27 11:38:58 +0100] Benjamin Piouffle
Merge pull request #1828 from opencollective/chore/collective-slugs-blacklist-2
[2019-03-27 09:59:05 +0100] François Hodierne
Merge pull request #1830 from<EMAIL_ADDRESS>[2019-03-27 09:52:26 +0100] François Hodierne
Merge pull request #1829 from opencollective/greenkeeper/json2csv-4.4.1
[2019-03-26 11:05:20 +0100] François Hodierne
Merge pull request #1808 from opencollective/greenkeeper/monorepo.babel7-20190..
[2019-03-26 11:04:38 +0100] François Hodierne
Merge pull request #1824 from opencollective/check-balance

Previous logs (20 entries)

[2019-03-27 11:43:22 +0100] Benjamin Piouffle
2.0.330
[2019-03-27 11:38:58 +0100] Benjamin Piouffle
Merge pull request #1828 from opencollective/chore/collective-slugs-blacklist-2
[2019-03-27 09:59:05 +0100] François Hodierne
Merge pull request #1830 from<EMAIL_ADDRESS>[2019-03-27 09:52:26 +0100] François Hodierne
Merge pull request #1829 from opencollective/greenkeeper/json2csv-4.4.1
[2019-03-27 08:51:00 +0000] greenkeeper[bot]
chore(package): update lockfile package-lock.json
[2019-03-27 08:50:57 +0000] greenkeeper[bot]
fix(package): update @octokit/rest to version 16.21.0
[2019-03-27 07:52:31 +0000] greenkeeper[bot]
chore(package): update lockfile package-lock.json
[2019-03-27 07:52:27 +0000] greenkeeper[bot]
fix(package): update json2csv to version 4.4.1
[2019-03-26 23:31:00 +0100] Benjamin Piouffle
chore(Collective): Add event and events to blacklisted slugs
[2019-03-26 11:05:20 +0100] François Hodierne
Merge pull request #1808 from opencollective/greenkeeper/monorepo.babel7-20190..
[2019-03-26 11:04:38 +0100] François Hodierne
Merge pull request #1824 from opencollective/check-balance
[2019-03-26 08:29:42 +0100] François Hodierne
package: update @babel/preset-env to version 7.4.2
[2019-03-26 08:28:43 +0100] greenkeeper[bot]
chore(package): update lockfile package-lock.json
[2019-03-26 08:28:27 +0100] greenkeeper[bot]
chore(package): update @babel/register to version 7.4.0
[2019-03-26 08:28:26 +0100] greenkeeper[bot]
fix(package): update @babel/preset-env to version 7.4.0
[2019-03-26 08:26:19 +0100] greenkeeper[bot]
chore(package): update @babel/polyfill to version 7.4.0
[2019-03-26 08:26:19 +0100] greenkeeper[bot]
fix(package): update @babel/plugin-transform-async-to-generator to version 7.4.0
[2019-03-26 08:26:18 +0100] greenkeeper[bot]
fix(package): update @babel/plugin-proposal-class-properties to version 7.4.0
[2019-03-26 08:26:17 +0100] greenkeeper[bot]
fix(package): update @babel/core to version 7.4.0
[2019-03-25 15:54:04 +0100] flickz
feat(archiveCollective): check collective balance before archiving

Change should be applied on frontend if there's no blocker on it

I like having all commits. Noisy but precise.

Ok, that's not useful then. Closing it


Playground components show syntax error, but only when deployed to Netlify

Question
Description
All playgrounds for all of my components show the following error when deployed to Netlify:
SyntaxError: Unexpected token (1:7) 1 : (<React.Fragment><State ^
But when built and served locally, render as expected. I'm hoping someone that uses docz has come across this before, and can point me toward what's causing this particular issue. I realize it's likely not a problem with docz itself.
Give more information about your doubt

I'm using RC8 of docz

I'll close this. Related to an environment issue where I needed to set an explicit version of yarn to run, and to make sure YARN_FLAGS were properly set.

i meet the quesstion too,and when i use npm locally,it happend,how to solve?


Error: Cannot find module<EMAIL_ADDRESS>

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d1luczyjzxi40j
AWS Region
us-east-2
Amplify Hosting feature
Frontend builds
Describe the bug
Scenario 1:

Start to host a Nextjs 12 app (appID: d1luczyjzxi40j)
When the build is done, to do domain
Got 500 errors from CloudFront

Cloudwatch logged error

Error: Cannot find module<EMAIL_ADDRESS>

Ping @swc/helpers version to 0.4.14
Issue persists.

Scenario 2:
If I start with a Nextjs 11 app, the issue can be fixed.

Start to host a Nextjs 11 app  (appID: d3sci3ahfz8hus, appID: d2213k35dz5phy)
Migrate to Nextjs12
Same as Scenario 1, 2-4.
Ping @swc/helpers version to 0.4.14
The issue is resolved

Scenario 2 is not reproducable.
Expected behavior
Nextjs 12 app should should up without 5xx errors or Error: Cannot find module<EMAIL_ADDRESS>.
Reproduction steps
Nextjs 12 app got 5xx errors with the following error in CloudWatch...

Error: Cannot find module<EMAIL_ADDRESS>
Build Settings
No response
Log output

# Put your logs below this line

Additional information
No response

Are you using a monorepo? We've ran into this same issue when using a monorepo structure.
Found that following this guide helps. Specifically
// packages/web-app/next.config.js

module.exports = {
  experimental: {
     // this includes files from the monorepo base two directories up
      outputFileTracingRoot: path.join(__dirname, '../../'),
   },
 }

That will get past your current error and dump you in a new one 🤣
I've spoken to @michrome to try and get this fixed further.

Are you using a monorepo? We've ran into this same issue when using a monorepo structure.
Found that following this guide helps. Specifically
// packages/web-app/next.config.js

module.exports = {
  experimental: {
     // this includes files from the monorepo base two directories up
      outputFileTracingRoot: path.join(__dirname, '../../'),
   },
 }

That will get past your current error and dump you in a new one 🤣
I've spoken to @michrome to try and get this fixed further.

Yes, got the following error... 😂

ValidationError: Invalid configuration object. Webpack has been initialized using a configuration object that does not match the API schema.
- configuration.module.rules[5] has an unknown property 'experimental'. These properties are valid:

Hi @0618 👋🏽 apologies for the delay. We have reproduced this behavior and are investigating any possible workarounds. This appears to be a bug with hosting SSR apps that belong to a monorepo. Will update with next steps once we have more information.

User reported similar issue to Amplify UI https://github.com/aws-amplify/amplify-ui/issues/3136

We have another user reporting this same issue: https://github.com/aws-amplify/amplify-ui/issues/3136#issuecomment-1400537111

Now available as a beta, Amplify Hosting has improved support for monorepo frameworks including npm/yarn/pnpm workspaces, Turborepo and Nx. If you'd like to try it out, please let me know your AWS Account ID number so we can flag you in. My email is<EMAIL_ADDRESS>


Add me as developer

Hi,
@haesleinhuepf
would it be possible that I get added as developer for that repo so that I can contribute PRs more easily?
Best,
Thorsten

Absolutely! I just sent you an invite. You'll have write access. If you need more, let me know! :-)

Perfect :-) Thanks. Tomorrow I will open the PR for the zoom issue.


fix: ElectronicEnergy.fock should be one-body term

Summary
The ElectronicEnergy.fock method should return an object which only contains one-body terms.
This PR fixes and tests that.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.849%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
17199

Relevant Lines:
20034

💛  - Coveralls


Add logging for container failures in the kubernetes watch

Pull Request Test Coverage Report for Build 6236

31 of 34 (91.18%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.04%) to 44.857%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-common/src/main/java/azkaban/executor/container/watch/AzPodStatusExtractor.java
31
34
91.18%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
2
55.67%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
3
76.74%

Totals

Change from base Build 6235:
0.04%

Covered Lines:
17338

Relevant Lines:
38652

💛  - Coveralls


Not working: Setctty set but Ctty not valid in child

Installed warp with go install github.com/spolu/warp/client/cmd/warp@latest
Then ran warp open edewfefewfefjerf and got:
Opened warp: edewfefewfefjerf

[Error] Failed to create pty: fork/exec /bin/bash: Setctty set but Ctty not valid in child.

Seems like something might need to change in my setup?

Hi! The repo is not really maintained anymore. I'll welcome any pull request of course!


Cannot installed with Carthage

Hi, team.
I'm trying to integrate the xcframework of this project via Carthage but it fails on command line compilation.
Please help me with this issue.

“./carthage.sh update --platform iOS --no-use-binaries --use-netrc --use-xcframeworks” script is used.

Hi @tangzzz-fan I ll have a look after the holidays, but I can not guarantee you a resolution here. I was actually planning to discontinue supporting cathage as it has too many issues in general.

OK, Thanks for providing this excellent framework. According to your roadmap, I will integrate this framework in a manual way.

@tangzzz-fan Hi and happy new year. Can you please try carthage again with the latest version 1.2.15

@tangzzz-fan Hi and happy new year. Can you please try carthage again with the latest version 1.2.15

It's OK, with v1.2.15.
Thanks for your quick response.

Perfect, best of luck