Automatically create new folder when creating a 3D component

Description of the current limitations
If you try to create a 3D component in a folder that doesn't exist, the method
Hfss.modeler.create_3dcomponent(component_path, component_name) fails silently.
It would be more intuitive if a meaningful message were provided. And I also think it would streamline usage if the folder could be created automatically.
Code sample expected
Add the following code to modeler3d.py for the method create_3dcomponent prior to calling the native API:
if not os.path.isdir(os.path.dirname(component_file)) and create_folder:    # Folder doesn't exist.
  os.mkdir(os.path.dirname(component_file))
  self.logger.warning("Folder doesn't exist.")
  self.logger.warning("Created folder " + os.path.dirname(component_file))

where create_folder is a named argument whose default value is True.  This way the folder will be created if it doesn't exist.
Useful links and references
No response

Merged.


assimp/linking problems

there is a problem in ComponentMesh.h:
when i build i have this error: Error	5	error C1083: Cannot open include file: 'assimp\Importer.hpp': No such file or directory
when i replace #include <assimp\Importer.hpp>
#include <assimp\scene.h> with #include <../assimp-3.1.1/include/assimp/Importer.hpp>
#include <../assimp-3.1.1/include/assimp/scene.h> i get linking errors
...does anyone knows how to fix this?

link the assimp library
On Fri, May 8, 2015 at 3:52 PM, Ciobotariu Narcis<EMAIL_ADDRESS>wrote:

there is a problem in ComponentMesh.h:
when i build i have this error: Error 5 error C1083: Cannot open include
file: 'assimp\Importer.hpp': No such file or directory
when i replace #include
#include with #include <../assimp-3.1.1/include/assimp/Importer.hpp>
#include <../assimp-3.1.1/include/assimp/scene.h> i get linking errors
...does anyone knows how to fix this?
—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5.

also add
$(SolutionDir)/externals/assimp-3.1.1/include/Compiler
into the Library directions for the VC++ Directories in project properties
Also
$(SolutionDir)/externals/assimp-3.1.1/include
into the Include Directories, same place
On Fri, May 8, 2015 at 4:38 PM, Paul-Daniel Hidi<EMAIL_ADDRESS>wrote:

link the assimp library
On Fri, May 8, 2015 at 3:52 PM, Ciobotariu Narcis <
<EMAIL_ADDRESS>wrote:

there is a problem in ComponentMesh.h:
when i build i have this error: Error 5 error C1083: Cannot open include
file: 'assimp\Importer.hpp': No such file or directory
when i replace #include
#include with #include <../assimp-3.1.1/include/assimp/Importer.hpp>
#include <../assimp-3.1.1/include/assimp/scene.h> i get linking errors
...does anyone knows how to fix this?
—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5.

Also did u pull the assimp folder from the externals directory?
On Fri, May 8, 2015 at 4:42 PM, Paul-Daniel Hidi<EMAIL_ADDRESS>wrote:

also add
$(SolutionDir)/externals/assimp-3.1.1/include/Compiler
into the Library directions for the VC++ Directories in project properties
Also
$(SolutionDir)/externals/assimp-3.1.1/include
into the Include Directories, same place
On Fri, May 8, 2015 at 4:38 PM, Paul-Daniel Hidi<EMAIL_ADDRESS>wrote:

link the assimp library
On Fri, May 8, 2015 at 3:52 PM, Ciobotariu Narcis <
<EMAIL_ADDRESS>wrote:

there is a problem in ComponentMesh.h:
when i build i have this error: Error 5 error C1083: Cannot open include
file: 'assimp\Importer.hpp': No such file or directory
when i replace #include
#include with #include <../assimp-3.1.1/include/assimp/Importer.hpp>
#include <../assimp-3.1.1/include/assimp/scene.h> i get linking errors
...does anyone knows how to fix this?
—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5.

did that, got rid of the initial error and only got 3 linking errors, after
i put $(SolutionDir)/externals/assimp-3.1.1/lib32/assimp.lib in
linker/additional dependencies i got a lot more linking errors
and yes i have the assimp folder in the externals directory
i haven't liked it properly or there is other problem?
2015-05-08 17:44 GMT+03:00 HidiPaul<EMAIL_ADDRESS>
Also did u pull the assimp folder from the externals directory?
On Fri, May 8, 2015 at 4:42 PM, Paul-Daniel Hidi<EMAIL_ADDRESS>wrote:

also add
$(SolutionDir)/externals/assimp-3.1.1/include/Compiler
into the Library directions for the VC++ Directories in project
properties
Also
$(SolutionDir)/externals/assimp-3.1.1/include
into the Include Directories, same place
On Fri, May 8, 2015 at 4:38 PM, Paul-Daniel Hidi<EMAIL_ADDRESS>wrote:

link the assimp library
On Fri, May 8, 2015 at 3:52 PM, Ciobotariu Narcis <
<EMAIL_ADDRESS>wrote:

there is a problem in ComponentMesh.h:
when i build i have this error: Error 5 error C1083: Cannot open
include
file: 'assimp\Importer.hpp': No such file or directory
when i replace #include
#include with #include <../assimp-3.1.1/include/assimp/Importer.hpp>
#include <../assimp-3.1.1/include/assimp/scene.h> i get linking errors
...does anyone knows how to fix this?
—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5.

—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5#issuecomment-100255854.

Didn't the teacher say we have to rebuild assimp for Visual Studio 2013 ?

Dont worry, I nearly reinvented assimp to make it work.
Try adding
$(SolutionDir)/externals/assimp-3.1.1/include
in the C/C++->General->Additional Include Directories
Also, you should have
assimp.lib
in Linker->Input->Additional Dependencies
You also need to have assimpd.dll in the build/Debug folder if it says that
it cannot find assimp.exe
ALSO, try linking assimp.lib(the one in the lib folder), I think its
different from the one in the lib32/lib64 one, I had to rebuild the
library(several times...) to make it work.
On Fri, May 8, 2015 at 7:01 PM, Ciobotariu Narcis<EMAIL_ADDRESS>wrote:

did that, got rid of the initial error and only got 3 linking errors, after
i put $(SolutionDir)/externals/assimp-3.1.1/lib32/assimp.lib in
linker/additional dependencies i got a lot more linking errors
and yes i have the assimp folder in the externals directory
i haven't liked it properly or there is other problem?
2015-05-08 17:44 GMT+03:00 HidiPaul<EMAIL_ADDRESS>
Also did u pull the assimp folder from the externals directory?
On Fri, May 8, 2015 at 4:42 PM, Paul-Daniel Hidi<EMAIL_ADDRESS>wrote:

also add
$(SolutionDir)/externals/assimp-3.1.1/include/Compiler
into the Library directions for the VC++ Directories in project
properties
Also
$(SolutionDir)/externals/assimp-3.1.1/include
into the Include Directories, same place
On Fri, May 8, 2015 at 4:38 PM, Paul-Daniel Hidi<EMAIL_ADDRESS>wrote:

link the assimp library
On Fri, May 8, 2015 at 3:52 PM, Ciobotariu Narcis <
<EMAIL_ADDRESS>wrote:

there is a problem in ComponentMesh.h:
when i build i have this error: Error 5 error C1083: Cannot open
include
file: 'assimp\Importer.hpp': No such file or directory
when i replace #include
#include with #include <../assimp-3.1.1/include/assimp/Importer.hpp>
#include <../assimp-3.1.1/include/assimp/scene.h> i get linking
errors
...does anyone knows how to fix this?
—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5.

—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5#issuecomment-100255854.

—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5#issuecomment-100280933.

It works now...
But there are some errors with a null pointer in scene.h from assimp/

Impressive......an error even I didn't get.
On Sat, May 9, 2015 at 12:37 PM, Prodan Tudor<EMAIL_ADDRESS>wrote:

It works now...
But there are some errors with a null pointer in scene.h from assimp/
—
Reply to this email directly or view it on GitHub
https://github.com/azzogat/FiiPractic/issues/5#issuecomment-100455421.


Use hex literals in xxhash and ryu

Fix #433

Pull Request Test Coverage Report for Build 1456
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.481%

Totals

Change from base Build 1450:
0.0%

Covered Lines:
2956

Relevant Lines:
3499

💛  - Coveralls


feat: Replace old collection card on profile

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[x] Refactoring

Context

[x] Closes #5032
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

/bsx/u/bXjrHpyJzSczJuuqmtN6nqCnd5b7KFa5LK1rBtF1tUHDYzp8N?tab=collection

So please open issue in rubick / snek with the data you need.
I would rather dedicate ~1-2 and guide you how to do that then doing this on frontend.

@vikiival
Thanks. I would try to list all the tasks related.
indexer side:

snek: https://github.com/kodadot/snek/issues/142
rubick: https://github.com/kodadot/rubick/issues/184

frontend side:

update collectionListWithSearch.graphql for collection search
update collectionListByAccount.graphql for collection in the user profile page
refactor components/collection/CollectionCard.vue and components/collection/CollectionDetail.vue

Hey I am closing this issue, if you want to try to write the resolver I am happy to guide.
I do not have currently space to write it by myself.
https://www.youtube.com/watch?v=7eQu_KS1TJk&t=7s

Hey! can this be reopen?


QinCai's Blog

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] Your website is not hosting on the following due to SSL issues: Vercel, Netlify

Description

Thanks! I would like to use this domain to be hosted on InfinityFree. It will be my personal blog powered by WordPress; you can see the current one by clicking the link below.
Link to Website

old: https://qincai.lovestoblog.com
the one i want: qincai.is-cool.dev

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

I have read the CLA Document and I hereby sign the CLA

recheck


Plugins with IOS and Cordova

Hi
I cant seem to get plugins working on iOS and Cordova.
Using the ES2016 Start kit and for example the Aurelia-Dialog plugin (or i18n, or the validation plugin).
It works on Android with Cordova but on iOS I just get empty screen. Without loading any plugins (through main.js) the starter kit is working
What could be the problem?

Please direct questions to our gitter chat room: gitter.im/aurelia/discuss


release 1.1.0 - Schmuddlweddr

PR checklist

[x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/pangenome branch on the nf-core/test-datasets repository.
[x] Make sure your code lints (nf-core lint).
[x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[x] CHANGELOG.md is updated.
[x] README.md is updated (including new tool citations and authors/contributors).

Alright, I think I addressed everything @mashehu. Thanks for the detailed feedback :)

Thanks @heuermh! If you are happy now, please approve ;)

Very happy, thank you! 😁


Use availableProcessors() worker threads

Basic RPS benchmark results from Ryzen 5900X:
This branch:
Fs2Netty: 305456 request/sec, 305456 response/sec
main:
Fs2Netty: 149224 request/sec, 149224 response/sec
Fs2IO: 160947 request/sec, 160947 response/sec
RawNetty: 302905 request/sec, 302905 response/sec
Closes #4

With a similar change to RawNetty, it's about 10x faster than Fs2IO, and still 5x faster than Fs2Netty with this PR.
Using availableProcessors for workers in RawNetty, epoll if available:
RawNetty: 1520858 request/sec, 1520858 response/sec
(epoll didn't make much of a difference for this test, NIO gets about the same results)

I did a bunch of additional benchmarks with more recent versions of fs2 and cats-effect. Seems like there's a significant performance hit related to tracing in cats-effect, and possibly a smaller one in fs2. There's a decent amount of variance, so the first might not really be much slower than the second, but anyways... for future reference:
3.0.6 (tracing disabled, CE 3.3.3) Speed: 320236 request/sec, 320236 response/sec
3.2.4 (tracing disabled, CE 3.3.3) Speed: 264885 request/sec, 264885 response/sec
3.2-10-421c242 (main, tracing enabled, CE 3.3.3) Speed: 196105 request/sec, 196105 response/sec
3.2-10-421c242 (main, tracing disabled, CE 3.3.3) Speed: 285688 request/sec, 285688 response/sec
3.2-10-421c242 (main) Speed: 163657 request/sec, 163657 response/sec
3.2.4 Speed: 179674 request/sec, 179674 response/sec
3.2.3 Speed: 168397 request/sec, 168397 response/sec
3.2.2 Speed: 240868 request/sec, 240868 response/sec
3.2.1 Speed: 209951 request/sec, 209951 response/sec
3.1.6 Speed: 215442 request/sec, 215442 response/sec
3.1.0 Speed: 234656 request/sec, 234656 response/sec
3.0.6 Speed: 273681 request/sec, 273681 response/sec

@djspiewak Not sure if you missed this, or if it's just not interesting? I'll close the PR in January, I'm getting tired of seeing it open in my PR list. ;)
Especially with the io_uring and epoll stuff being worked on in CE3, maybe this fs2-netty isn't all that relevant anymore.


Determine which .NET Framework versions are installed miss info about .NET 4.8.1 registry keys

,NET Framework 4.8.1 was released 2 days ago.
But docs page for How to: Determine which .NET Framework versions are installed miss info about .NET 4.8.1 registry keys.

Also many people are curious how registry values look like (and how exactly runtime version distinction is working under the hood) when both .NET 4.8 SDK/Targeting pack and .NET 4.8.1 SDK/Targeting pack are installed (it is possible to check both checkboxes in VS Installer for latest VS 2022 17.3.0 REL – so one can choose between .NET 4.8 and .NET 4.8.1 in app creation dialog).

There's an open PR that adds the DWORD value for 4.8.1, which is 533325.
@TaraOverfield Can you answer the question about registry values when both the 4.8 and 4.8.1 developer packs are installed?


Testing, please ignore. (chjinl)

This is a bug bounty test.. Please DO NOT APPROVE THIS! (chjinl)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chjinl cqsyq seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Upgrade to clang 12.0.0

Upgrade us to clang-12.0.0 🎉
Motivation

Building sorbet on Big Sur is currently broken, and upgrading to clang-12 fixes the problems.
Test plan

[x] Manually run a mac build in CI
[x] Run on Stripe CI
[x] Disabled mac branch builds
[x] Upload the llvm binaries to our s3 bucket
[x] Make sure that sorbet.run still works

@froydnj there have been some changes since you last looked at this PR. I rebased the branch so that the only commits that really need to land together are the last two, f7aa8c3d58cc74dbb02968f39f67c0e47354ba29 and e07596009ff6a5e630584e3d9e5d8fa39853a021, the others could be landed separately if we'd prefer to go that direction. I think that it will probably be easiest to review this pr by commit.


Improve MathML for \middle

\middle is a delimiter, not an operator. So suppress the operator spacing.

Codecov Report

Merging #1906 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
+ Coverage   94.77%   94.77%   +<.01%
==========================================
  Files          79       79
  Lines        4668     4670       +2
  Branches      813      813
==========================================
+ Hits         4424     4426       +2
  Misses        220      220
  Partials       24       24

Flag
Coverage Δ

#screenshotter
88.95% <100%> (ø)
:arrow_up:

#test
86.76% <0%> (-0.04%)
:arrow_down:

Impacted Files
Coverage Δ

src/functions/delimsizing.js
97.7% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbcb8b...0712c01. Read the comment docs.

mfenced looks like a better choice for delimiters in general.

Near the bottom of this page, it is stated that the Chromium MathML project does not intend to support mfenced, at least not right away. So I thought it best to stick with <mo>.


Duplicate elements

In #32 I created the MoveElements command which is able to move-a-copy of elements by using "copy" optional parameter.
So I believe we can close this "Duplicate elements" issue.

Duplicate elements using MoveElements tapir command, set copy parameter True (and you can set moveVector to zero vector)


Fastify integration docs update

I think it is not working very well without Readable.from. We can try it by changing the example It has unit tests

@ardatan I followed the docs, and got an error (since response.body is returned as ReadableStream already)

That ReadableStream is different than NodeJS Readable. ReadableStream implementations in NodeJS are AsyncIterable so even the TS types look wrong, it is correct under the hood :)

Done.
Now it feels like one of Ivan's PRs :)


📑 Add more examples

Personally, I think that adding more examples will improve the ease of use of LESP by explaining how to use the project better and in more detail.
Hint:

GUI options could be a very nice addition
Simple examples are good, but we shouldn't overuse these
In total, at least 5 examples will be fine. Not more than 8 though.

I was wondering if I could work on this issue! Do you have any examples in mind you'd like to see?

I would like to work on this issue, could you please assign it to me?

I was wondering if I could work on this issue! Do you have any examples in mind you'd like to see?

Thank you for your interest in contributing! I think some examples that combine some of the features in a single app or have a GUI would look good. Currently there is already a tkinter sample, but something like Flask would not be useless.
You can simply put the source code into a file or two, it shouldn't be overcomplicated.

I would like to work on this issue, could you please assign it to me?

Hello! Since there are two people who would like to work on this issue, I'll assign both of you. Thank you for your interest in contributing to LESP!

Implemented by @Halzorg!


[Backport release-24.05] bookstack: 24.05.3 -> 24.05.4

(cherry picked from commit a8f5ef66e5d6e7f03a2c7af026d096372f651c74)
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.
https://github.com/NixOS/nixpkgs/pull/338990

Should the test fail?

Should the test fail?

Note this should not necessarily be treated as a hard fail, but a reviewer's attention should be drawn to it and github actions have no way of doing that but to raise a 'failure'

i've checked the changes and they match what the latest master should contain. i think this cherry-pick test fails as NixOS 24.04 had bookstack upgrade  v24.05.3 -> v24.05.4 and the unstable had v24.05.2 -> v24.05.4.
So when i cherry-picked it, i used --strategy-option theirs and merged the new changes. Should work fine as the final file is same as whats on master.
@SuperSandro2000

Note this should not necessarily be treated as a hard fail, but a reviewer's attention should be drawn to it and github actions have no way of doing that but to raise a 'failure'

I know, we are using github status' wrong.
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
   INFO  Discovering packages.
  laravel/socialite ..................................................... DONE
  laravel/tinker ........................................................ DONE
  nesbot/carbon ......................................................... DONE
  nunomaduro/termwind ................................................... DONE
  socialiteproviders/manager ............................................ DONE
Generated optimized autoload files containing 7344 classes
> @php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');"
Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Package operations: 3 installs, 0 updates, 0 removals
  - Downloading symfony/polyfill-php83 (v1.30.0)
  - Downloading intervention/gif (4.1.0)
  - Downloading firebase/php-jwt (v6.10.1)
 0/3 [>---------------------------]   0%    Failed to download symfony/polyfill-php83 from dist: curl error 6 while downloading https://api.github.com/repos/symfony/polyfill-php83/zipball/dbdcdf1a4dcc2743591f1079d0c35ab1e2dcbbc9: Could not resolve host: api.github.com
    Now trying to download from source
  - Syncing symfony/polyfill-php83 (v1.30.0) into cache
    Failed to download intervention/gif from dist: curl error 6 while downloading https://api.github.com/repos/Intervention/gif/zipball/3a2b5f8a8856e8877cdab5c47e51aab2d4cb23a3: Could not resolve host: api.github.com
    Now trying to download from source
  - Syncing intervention/gif (4.1.0) into cache
    Failed to download firebase/php-jwt from dist: curl error 6 while downloading https://api.github.com/repos/firebase/php-jwt/zipball/500501c2ce893c824c801da135d02661199f60c5: Could not resolve host: api.github.com
    Now trying to download from source
  - Syncing firebase/php-jwt (v6.10.1) into cache
 3/3 [============================] 100%
In Git.php line 473:

  Failed to clone https://github.com/symfony/polyfill-php83.git via https, ss
  h protocols, aborting.

  - https://github.com/symfony/polyfill-php83.git
    Cloning into bare repository '/build/.cache/composer/vcs/https---github.c
  om-symfony-polyfill-php83.git'...
    fatal: unable to access 'https://github.com/symfony/polyfill-php83.git/':
   Could not resolve host: github.com

  - git@github.com:symfony/polyfill-php83.git
    Cloning into bare repository '/build/.cache/composer/vcs/https---github.c
  om-symfony-polyfill-php83.git'...
    error: cannot run ssh: No such file or directory
    fatal: unable to fork

install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--download-only] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
error: builder for '/nix/store/hpscrkgif0dhzly12pnkmr119acgpmbr-bookstack.drv' failed with exit code 1;

The cherry-pick weirdness here is because somehow the stable branch ended up with 24.05.3 while master remained on 24.05.2. I would probably just remove the cherry-pick line from the commit message as it's just not closely related enough.


Enable edns0 for larger UDP responses

It looks like you need to specifically enable edns0 in the ResolverOpts since it's not set by default. Without it you can run into issues when querying fly.io for various TXT records since it's possible that the responses will be larger than 512 bytes. Without this set, you'll get obscure errors, ex. rdata length too large for remaining bytes.

@protochron 🙏🏻 thank you! My apologies for being slow to upstream this, but Flytrap 0.1.2 is now published with this fix.
I’ve also just published version 0.2.0, with new support for querying machines via the Fly.io Machines API. This requires an API token, but makes available full machine status (including health checks), and avoids any possible issues with DNS.


feat: add binaryType parameter to WebSocket class for Protobuf support on the web

Status
DONE
Description
Greetings,
I really like this project. It's just so simple to use and painless. That's why I'm thanking you for your time taken to maintain the project. Unfortunately it wasn't working on Flutter for the Web, as I was using Protobuf and consequently ran into issues with JavaScript Blob to List (bytearray) conversion. This fix adds another parameter to the class, which is ran by the dart:html WebSocket class and with the help of it, I'm able to set the binaryType to arraybuffer, per this source and it successfully works with Protobuf.
Before adding the flag/parameter

After adding the flag and setting it to arraybuffer

Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[x] 📝 Documentation
[ ] 🗑 Chore

@mytja thanks so much for the positive feedback and for contributing! Looks like ci is failing due to an analysis warning. Are you able to quickly resolve that? If not let me know and I’m happy to help 👍

Sure, I can do that.

This should pass the analysis.


added sample code for instance admin

"Administer Instances"  subtask of task #615 is addressed with the PR.

@coryan
this PR also fixes #744

Thanks!  @frankyn note that one of the bugs your found (#744) is getting fixed in this PR, no need for you to take action.

Thanks!

In the nodejs instance sample (https://github.com/googleapis/nodejs-bigtable/blob/master/samples/instances.js), there are comments like this:
// [START bigtable_create_prod_instance]
...
// [END bigtable_create_prod_instance]
These are used in our documentation generation process to grab parts of a file. It's important to add those same start/end tags in the appropriate samples.
Please copy the start/end tags from Node.js to the right place in the C++ equivalent code.

@sduskis
C++ currently uses marker tag like  //! [create cluster] to mark start and end,  These marker tags are used on other places as well, bigtable_hello_world.cc as an example...
is there a common documentation generation process for all languages?
Are you suggesting to change existing marker?

@coryan
Uploaded the generated doxygen to https://manish-qlogic.github.io/google-cloud-cpp/latest/
Thanks!

PTAL

@coryan
PTAL.

@sduskis
PTAL.

@sduskis
PTAL

@roopak-qlogic, I added some comments.  Also, it looks like there are conflicts that need to be resolved.

separated out instance admin examples for global documentation and test them locally.
couldn't find id() for cluster and instance.

PTAL

@sduskis, @coryan
PTAL


[Manual] - Only single post is displayed on "Home" screen by default

Commit number: 69c7f7816de44a20c5b096ec9199738882d5171f
Preconditions: Test user following two or more users with posts
Steps to reproduce:

Open "Home" screen
Scroll down the "Home" screen

Actual Result:
after step 1: Only one post is displayed on the screen

after step 2: All other posts are displayed on the screen

Expected Result: List of posts for users that are followed by the test user are displayed on the screen by default

Plz check server responses.
Currently path => /users/me/following/combined?limit=8
returns 0 posts
But in the same time/users/me/following/combined
returns 0 posts
I consider this as not client side bug.

Also it is unclear why we have not empty cursor for empty data

Please see issue #171. This behavior is a performance optimization on the server. The server fetches a list of items in a feed based on the limit, and then hydrates that list to include additional information that the client needs to display the feed. In that process, it may discover that some items are no longer valid (have been deleted, or banned due to abuse), so the list can shrink below the limit. If there are additional items in the feed, then it will return a valid cursor, which is an indication to the client that it can fetch more items starting from that cursor. So if the client gets back fewer items than it wants, and there is a non-null cursor, then it should issue another fetch and get more items until it gets enough items to display on the screen. If not specified, the default limit is 20.


break and continue statements

⭐ Proposed change
Adding ⏹ for breaking from a loop (maybe with a value like Rust does?) and ⏭ for continueing a loop. This may be even improved with labelled loops, tho its syntax would be harder to be agreed upon.
🤔 Rationale
A useful feature. I chose ⏭ because Unicode defines it as "next track", and ⏹ is "stop".
🕺Example
"Standard" break:
0 ➡ 🖍🆕a
🔁 👍 🍇
  a ⬅➕ 1
  ↪ a ▶ 5 🍇
    ⏹
  🍉
🍉

breaking with a value:
0 ➡ 🖍🆕a
🔁 👍 🍇
  a ⬅➕ 1
  ↪ a ▶ 5 🍇
    ⏹ a ❗
  🍉
🍉 ➡ thisVarIsSix

continue:
0 ➡ 🖍🆕sum
🔂 i 🆕⏩⏩ 0 10❗ 🍇
  ↪ i 🚮 2 🙌 1 🍇
    ⏭
  🍉
  🙅 🍇
    sum ⬅➕ i
    😀 🔡 sum 10 ❗❗
  🍉
🍉

I haven’t heard of "breaking with a value" before. The same behavior could be easily achieved with  a method, couldn’t it?

Yeah, it can be.

⏹ is nice. ⏭  conflicts with https://www.emojicode.org/docs/packages/s/23e9.html#i⏭ though.
I don’t think that "breaking with a value" is something that fits Emojicode particularly well.

And what about breaking out of/continuing nested loops? Some languages have labels for that purpose. Example from Rust:
#![allow(unreachable_code)]

fn main() {
    'outer: loop {
        println!("Entered the outer loop");

        'inner: loop {
            println!("Entered the inner loop");

            // This would break only the inner loop
            //break;

            // This breaks the outer loop
            break 'outer;
        }

        println!("This point will never be reached");
    }

    println!("Exited the outer loop");
}

Actually, I have rarely seen breaking to a specific loop being used in real production code, so I doubt it is something people will want to do in Emojicode. Moreover, it adds complexity to the reasoning the compiler does about flow control.
I’m not totally against this, but I don’t feel like implementing this myself.

what if it's not used because it's not in many languages sorry

JavaScript, Java and Go, implement exactly this feature, for instance. C++, C and C# have labels with goto which would cover this use case. I think that covers a lot of code being written today...

Thanks to the latest changes, ⏭ is no longer in use in the s package. We could use it for the 'continue' statement now.


Add missing documentation for remaining crates

Moved from PR #541.
Add documentation for all types and items in the crates that don't currently have #![deny(missing_docs)]. Modules and/or crates can be done one PR at a time.
Here's a list of crates that have yet to be completely documented:

[ ] cache/in-memory
[x] command-parser
[ ] http
[ ] model

This is a continuous effort so I'm going to give this a close.


Difficulty maintaining aligned crosshair

By moving the mouse, the algorithm that makes the camera drive mapping seems to have excessive acceleration when the camera is on the horizon height causing the mouse stick it in the zenith or nadir view.

I can't replicate this. Would you mind sharing some information about your system?
It sounds like the sort of issue I've had with WINE when it's not capturing the mouse properly. Try pressing escape to release your mouse, then clicking the window to re-capture it.

I reproduce it on VirtualBox and recorded the behaviour on a youtube video.
https://youtu.be/ZGcraBEuOiY

Hmm, does it happen outside of virtualbox? My suspicion is that it could be how VB captures the cursor.
Anyone else with that linux want to chime in?

Yes, It happened on my enviroment as well. I only used the VM to record the video. I check the mouse acceleration as well but it seems to not affect the problem so much.


Power meter does not fully working

Hi
I've tried on android 14 with CYCPLUS U1 ANT adapter. HR is OK, S&C is OK. PWR is reading power and Power Balance. Calibration does not work, reading cycling dynamics does not work. If required I can send logs. Testing with Garmin Rally RS200
Regards
Jan

Gone using compatible USB stick (Garmin).


[BEAM-10937] Add first introductory notebook

This is the first notebook of a new "Tour of Beam" section we want to create to help improve the onboarding experience for beginners.
The plan is to have the "Tour of Beam" section to include links to all the notebooks we currently have, as well as to offer a new set of introductory notebooks to explain concepts gradually in an interactive environment. The landing page will come up as following PR.
This notebook covers the following:

Basic concepts: pipeline, PCollection, PTransform
Explanation of the | and >> operators
Basic transforms: Map, FlatMap, Filter, Combine, GroupByKey

The "What's next?" section at the end of the notebook contains links to existing documentation, but will be updated once we have more notebooks for new topics.
R: @aaltay
R: @rosetn
Staged: https://colab.sandbox.google.com/github/apache/beam/blob/b321ab285d7034b2e1b3ab0cb5d4b5d786640a39/examples/notebooks/tour-of-beam/getting-started.ipynb

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@rosetn could you make the first review pass?

/cc @KevinGG

Where were we planning on hosting this? On the main landing page https://beam.apache.org/ or Documentation landing page https://beam.apache.org/documentation/ ?

I was thinking on the "Get Started" section, and probably replace the "Try Beam" button in the main landing page with the "Tour of Beam" page once it's done. The "Try Beam" notebook would also be referenced in the "Tour of Beam". What do you think?

SGTM. I'm in favor of placements that lets users know where they can find all of the interactive notebooks at try them out. Querying "apache beam notebooks" on the Google search engine or DuckDuckGo, the Try Beam page is in the top 10 results for me:  https://beam.apache.org/get-started/try-apache-beam/

I've updated the link to the staged version to the latest commit

@aaltay I'm done with my review

Could you update the staged version after your next commit?

Just updated it, forgot to update it yesterday.

I forgot to note this--can you add alt text to these images?

@aaltay -- comments addressed, and staged link updated. This should be ready for review


feat(#78): implement useShippingProvider composable

Description

Related Issue

#78
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@danhaj in CartPreview.vue there's a hardcoded getShippingMethodPrice method.
We should remove it and replace it's use with cartGetters.getShippingPrice(cart);


Cutting release 0.28.1 for Bigtable.

/cc @garye

Fingers crossed :grinning:: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/4084

@garye Huge fail by me here, this should probably have been 0.29.0 because #4256 actually added a "feature" in many ways.

Oops, yeah I didn't know that got in before this one.


build: include extension proto files into protoc-gen-nexus package

Pull Request Test Coverage Report for Build 441920671

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.837%

Totals

Change from base Build 441822237:
0.0%

Covered Lines:
419

Relevant Lines:
434

💛  - Coveralls


⚠ Bofrost.fr has degraded performance

In 40006a9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 843 ms

Resolved: Bofrost.fr performance has improved in b8e8b2e after 311 days, 22 hours, 5 minutes.


bumping to version 1.1.17

Coverage remained the same at 93.037% when pulling 4768c28443f49a600131dfe786af6a4ed2915b98 on JackDanger:master into 2a3fdf6b642d471391dff23ad06f9b1a74f5939d on spulec:master.


Update columns.dart to fix typo in doc comments

Not sure which word is meant to be used, but fixed up the phrasing to make it sound better.

Sounds good, thanks again!


Add the ability to configure a new Linux functionapp with ACR/Private registry

Describe the solution you'd like
an az functionapp xyz command that would configure the app at creation time and afterwards to work with ACR and Private registries
Describe alternatives you've considered
this currently can be done after creating a Linux function using az functionapp config container set commands
Additional context

@ahmedelnably / @ankitkumarr can you take a look at this since this looks function app related. Thank you.

This is related to https://github.com/Azure/azure-cli/issues/7261, reassigning 7970 to @Nking92

@ahmedelnably we are still trying to figure out the work for #7261& is still assigned to Yi. Also Note that webapp create & function app create don't share the same code anymore so even with basic work done for az webapp create some one from function will need to make the changes for functionapp https://github.com/Azure/azure-cli/blob/dev/src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/commands.py#L215 . Please don't assign issue to Nick directly, in the future please assign it to Yi or me & we will triage it. Thank you.


Better diff

@giacomocavalieri I saw that you replaced gap with another algorithm in this PR. Just got a bit curious about the reason just to understand if there is a use-case which gap currently doesn't support? (I'm the author of gap)

Hello!! Yes I switched to a custom implementation because I wanted to use the histogram diffing algorithm and I didn't know how to get gap to use that when comparing two strings

Thanks for the response 🙏
I'll have to look into the possibility of adding this algorithm at some point. My first implementation used a standard dynamic programming LCS algorithm, but then I switched to Myers as default in order to improve performance.

I had a quick look at your implementation just to see if I could understand
how the algorithm works and I saw that you had made some comments about
performance optimizations. Also I didn’t quite grasp how everything worked,
but that’s probably more on me to not have read up on the algorithm
properly.
Anyway if you want to adapt in and make a PR to gap you are of course more
than welcome to. Otherwise I might see if I can figure something out at
some point when I have some time.
tis 13 feb. 2024 kl. 20:51 skrev Giacomo Cavalieri @.***

:

Oh yeah I never made a PR to gap because the algorithm I wrote is hideous
and might have horrible performance!
I have some ideas on how it could be optimised but I'll probably only ever
get around to doing it if people start complaining about performance 😆
—
Reply to this email directly, view it on GitHub
https://github.com/giacomocavalieri/birdie/pull/1#issuecomment-1942303017,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANC6YECCCKRNRBB6GZEMFDYTO72VAVCNFSM6AAAAABCU5EZO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSGMYDGMBRG4
.
You are receiving this because you commented.Message ID:
@.***>

If you want to learn more you can have a read here, it's a great resource https://tiarkrompf.github.io/notes/?/diff-algorithm/
My implementation is a translation of that algorithm with some tweaks for a pure functional setting


[Bug]: Robots Entering Shared Docking Lane Simultaneously Despite Mutex Configuration

Before proceeding, is there an existing issue or discussion for this?

[X] I have done a search for similar issues and discussions.

OS and version
Ubuntu 22.04
Open-RMF installation type
Source build
Other Open-RMF installation methods
No response
Open-RMF version or commit hash
iron
ROS distribution
Iron
ROS installation type
Source build
Other ROS installation methods
No response
Package or library, if applicable
No response
Description of the bug
I am simulating a scenario where two robots need to pick up objects from a shared docking station. However, both robots are entering the docking lane simultaneously, causing them to collide with each other. I've already configured the lane and waypoint as mutually exclusive (mutex) in the traffic editor, but the collision still occurs. The attached video demonstrates the issue.
Screencast from 08-21-2024 05:33:36 PM.webm
Steps to reproduce the bug

Run simulation with turtlebots

Expected behavior
No response
Actual behavior
No response
Additional information or screenshots
No response

Hello @osama-z-salah ! May I understand your navigation graph better - which waypoints are assigned the mutex group? What is the mutex group called, and is the name consistent across the relevant waypoints and lanes? Lastly, may I check if you launched the mutex group supervisor node? If not, you may try adding these lines to your own common.launch.xml:
<group>
  <node pkg="rmf_fleet_adapter" exec="mutex_group_supervisor" output="both" />
</group>

Hello @xiyuoh, thanks for your response! My goal is to pick up an object from the ato_dock waypoint, which serves as a docking waypoint. I’m still trying to fully understand how to properly use mutexes. I've added a mutex property to both the lane leading to the docking waypoint and the waypoint itself. I named the mutex for the waypoint the same as the waypoint (ato_dock), while for the lane, I used a different name, docking_lane. Regarding the mutex_group_supervisor, I have added it to the common.

I see! For areas where you want only 1 robot to occupy, you'll have to assign a uniquely-named mutex group to all the waypoints and lanes within this area. In other words, each mutex "area" is defined by the mutex group name. Seems like the issue here is the waypoint and lane carrying different mutex group names, so both robots could access them at the same time.
Can you try making the mutex group name identical for both the docking waypoint and the lane leading to this waypoint? You might also want to assign the same mutex group name to the entry waypoint adjacent to the docking waypoint, to ease the deconfliction process. When you run this, you should be able to see something like "robot2 waiting for the mutex held by robot1" printed on the fleet adapter terminal.
Let me know if this works!

Thanks! Yes, it works now, but I'm facing another issue with override_schedule. After it finishes, it re-plans and makes my robot attempt to dock again, even though it’s already docked.
Also, one last question: is it necessary to apply override_schedule when performing actions at the docking waypoint, even if the robot isn't moving (e.g., jacking up the load), or is it sufficient to use it just for the docking itself?

You can try removing the override_schedule. But if the issues persists, feel free to provide some logs from the terminal, perhaps from the point where the robot has completed docking, and put them in a gist if the logs are too long.
And no, you don't have to apply override_schedule for every single step of your performable action, especially in your use case where the robot is stationary and the docking area is "protected" by a mutex group. You may use it to take into account any specific trajectory unknown to RMF during your action, and it is helpful to spot any potential traffic conflict. Here is the API for it as a reference.


Optimize Py::to_attributes() to reuse PyRefExact

PyAttributes only uses PyStrInterned as its key.
PyStrInterned is always compatible to PyRefExact<PyStr>
in Py<PyDict>::to_attributes() it creates interned string using vm.ctx.intern_str(key.as_str()) which always create a new PyObjectRef using &str(from key.as_str()).
If we downcast it to PyRefExact<PyStr> instead of PyStrRef and put it directly to vm.ctx.intern_str, it will reuse the given object unlike taking &str like now.
This is assigned to @xiaozhiyan

see also #4504


Library import<PHONE_NUMBER>

PR was created by rightlib sync workflow run

Check checks_integrated failed. All future check are suspended, please remove the rightlib-fail label to enable checks.

Unable to merge PR All future check are suspended, please remove the rightlib-fail label to enable checks.

The PR was successfully merged into main using workflow


Add EVMBridgedMetadata & URI to MetadataViews

Related: #129
Description
With EVM on Flow coming in the near future, we'll need to reconcile differences between EVM & Cadence NFT metadata handling expectations and standards.
Motivated by ongoing work while iterating on the VM bridge, this PR puts forth two metadata views for consideration.
The first, URI, is a generic struct intended to store a string pointer to some metadata. In many cases, this may just be a JSON blob at a URL or an IPFS pointer. In other cases, this may actually be NFT metadata as a JSON blob itself as in URL-encoded URIs. In the case of ERC721s bridged from EVM, we likely won't have enough context to determine the type of URI this is, thus the generic nature of this view.
Here is the URI interface:
pub struct URI: MetadataViews.File {
    /// The base URI prefix, if any. Not needed for all URIs, but helpful
    /// for some use cases For example, updating a whole NFT collection's
    /// image host easily
    pub let baseURI: String?
    /// The URI string value
    /// NOTE: this is set on init as a concatenation of the baseURI and the
    /// value if baseURI != nil
    access(self) let value: String

    pub view fun uri(): String

}

The second, EVMBridgedMetadata, contains three fields
pub struct EVMBridgedMetadata {
    pub let name: String
    pub let symbol: String

    pub let uri: {MetadataViews.File}
}

The fields name and symbol are included in several ERC standards, notably ERC721 and ERC20. The last field, uri, allows Cadence projects to define how they would like their token or contract's metadata to be transmitted to an EVM counterpart. In the case of Cadence-native projects, this field could be any File implementing struct, while in the case of bridged assets (e.g. ERC721) the uri value would likely just be a URI struct.
Without getting into the specifics of bridging assets which is out of scope for this PR, it would be very helpful to get feedback on the views as their presented, if we feel they're worth adding in the MetadataViews contract, and if the community feels anything is missing from these very barebones implementations.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

[ ] Update the version in package.json when there is a change in the smart contracts

Relevant discussion in discord

Updating to note I added a baseURI: String? field to URI based on feedback implementing the view in bridge contracts.
@joshuahannan I think deploying the update before Crescendo makes the most sense to allow projects to adopt the view as they see fit before bridging is enabled. There was constructive discussion in the linked discord thread, but I'd hoped for more community feedback before merging this view. I'll raise this PR again in discord to ask folks to share feedback.

Yeah, we'd want to include this before 1.0. I can follow up with a PR including an implementation.

oh yeah, and make sure you run make test to run the tests and generate the assets


Better IME support

Add better IME support (#41) to implement on-the-spot IME conversion. My code is based on #643.
I added the following functions:

glfwSetPreeditCallback() : callback function to notify preedit text
glfwSetPreeditCursorPos() : teach text cursor position for IME windows
glfwGetPreeditCursorPos() : get text cursor position for IME windows

They are not big changes. It keeps backward compatibility about API level.
To use IME feature, UI programmers should implement visualization code for preedit texts.
I implemented platform specific code for Windows/X11/Mac OS X (not Wayland and Mir).

I start implementing my text box, I need some features in addition to the above functions:

Set/Get current IME status (integer only text box and so on)
IME status change callback (commit text when turn off IME)
Reset preedit text (reset text when widget focus would changed)

I will add these functions to my branch.

My initial impression is that this looks great! I will review it more closely once it's time for the IME part of 3.2, which should hopefully give you time to land the additional features you mention.

I implemented all method I mentioned and I added one test application (ime.c, almost as same as event.c, but IME functions are assigned to mouse buttons).
Current status is:

Windows works almost perfectly except Google Japanese Input doesn't follow cursor position (MS IME works).
Mac OS X's NSTextInputContext doesn't work on my computer (10.9). So resetting preedit text feature doesn't work.
I tested on Ubuntu 15.10, but XIM (X Input Method) implementation is buggy. Test application can receive preedit text and commited text, but my real application can't. I am still debugging.

XIM is very old standard. I think adding Fcitx option (more modern protocol and most popular one now) is better solution (use Fcitx if it is installed, otherwise use XIM). And Fcitx supports Wayland too (I couldn't find Mir information). How about it?

There is quite a range of programming styles in this patch. Did you write this yourself or are parts of it copied from other sources? If so I need to know what licenses they come under.

The glfwGetIMEStatus and glfwSetIMEStatus functions should be folded into glfwGetInputMode and glfwSetInputMode.

The imm32 library should be dynamically loaded the same way as other non-default libraries.

Maybe 50% is my code and 50% is other's. I referred the following Japanese web sites:
Windows: http://www.kumei.ne.jp/c_lang/sdk3/sdk_278.htm
X11: http://homepage3.nifty.com/rio_i/lab/xlib/012xim.htm
I will ask them about sample code's license.
I couldn't find memo about Mac. Of course, I checked MSDN, Apple's document, X11R6 references.

I will merge glfw(Get|Set)IMEStatus into glfw(Get|Set)InputMode.
imm32 is provided as static library by Microsoft and it should be bundled with Windows like gdi32.dll. I thinks if(WIN32) is enough to detect imm32.

I rebased to fix conflict between current master.
I removed glfw(Get|Set)IMEStatus and added new options to glfw(Get|Set)InputMode
Ryo Ichinose (X11 guy) agreed using XIM related code as libpng/zlib license.

Now I am waiting reply from Yasutaka Kumei.

Yasutaka Kumei agreed using his code with glfw.

Awesome! Thank you!

About the imm32 thing, it's not for compatibility with older systems. As you rightly point out, the import library is available everywhere. Rather it's as a convenience for users, just like the current dynamic loading of winmm.

@elmindreda It appears that you wanted to close this PR with 779b562, but Github failed to realize that, so you probably have to close this PR manually

It appears that you wanted to close this PR with 779b562, but Github failed to realize that, so you probably have to close this PR manually

That commit is not yet merged into master branch. When it is, due to its commit message, this PR will be closed.

What @shurcooL said. Expect several more revisions to pop up here before it's ready to merge, as it's a big and multi-platform addition.

Can anyone comment what's needed to get this merged?

I merged the latest version and fix a bug based on shibukawa-san branch.
https://github.com/altseed/glfw/tree/feature/add-ime-support
When is this PR merged?
@elmindreda
What do I do to merge this PR (Add documentation, fix bugs, etc)?

Imm32 is problematic on Window10 as Microsoft has dropped support of it.
It's better to use Text Service Framework instead.
And there should be a way to get candidate list, as input method can't show its candidate list window when the game is in fullscreen mode

I would like to continue this fix with #2117.
I have already contacted Mr. @shibukawa .


Release 5.3.0

@jazzband/pip-tools please, help with the review!

@sfdye thank you!

Just curious, how is this change log generated? By hand? By running a script?
I see we are using Github Action, perhaps we could leverage this action to always generated change log as we merge PR.

Currently, this log generation requires human interaction. Would be nice to use some GitHub action or towncrier. However, It's enjoyable worries to prepare releases for me, I don't mind :)

@sfdye FYI https://github.com/jazzband/pip-tools/blob/master/CONTRIBUTING.md#project-release-process


Inline constants into instructions

Closes #35

This is currently failing on rich bc we can't use tuples as positional args! https://github.com/Textualize/rich/pull/2379