tests are not configured after reloading the window

Testing #22081
I was running tests, reloaded the window, tests are no longer discovered.

output:
python /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12691017/pythonFiles/unittestadapter/discovery.py --port 49541 --uuid cc45b0be-38c9-400e-a3ba-9772b4b8fe74 --udiscovery -v -s . -p *test*.py
python /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12691017/pythonFiles/unittestadapter/discovery.py --port 49541 --uuid b7dfe702-01c0-4972-a117-08c1a25612da --udiscovery -v -s . -p *test*.py
python /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12691017/pythonFiles/unittestadapter/discovery.py --port 49541 --uuid e2f17684-6abc-4e2c-9970-a6f07825ff5c --udiscovery -v -s . -p *test*.py

ined
2023-09-26 11:39:37.845 [debug] Cached data exists KeyPrefix=Cache_Method_Output_b._selectIfLaunchedViaActivatedEnv-Args=true
2023-09-26 11:39:37.846 [debug] Clearing context for python dependencies not installed: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite/blank_folder/test_none.py
2023-09-26 11:39:37.847 [debug] Found cached env for /usr/local/bin/python3.10
2023-09-26 11:39:37.847 [debug] Resolved /usr/local/bin/python3.10 from cache: {"name":"","location":"","kind":"global-other","executable":{"filename":"/usr/local/bin/python3.10","sysPrefix":"/usr/local/opt/python@3.10/Frameworks/Python.framework/Versions/3.10","ctime":1694448791180,"mtime":1694448791180},"display":"Python 3.10.13 64-bit","version":{"major":3,"minor":10,"micro":13,"release":{"level":"final","serial":0},"sysVersion":"3.10.13 (main, Aug 24 2023, 22:48:59) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]"},"arch":3,"distro":{"org":""},"source":["path env var"],"id":"/usr/local/bin/python3.10","detailedDisplayName":"Python 3.10.13 64-bit"}
2023-09-26 11:39:37.848 [debug] Cached data exists KeyPrefix=Cache_Method_Output_E.ensureEnvironmentContainsPython-Args="/usr/local/bin/python3.10"-Arg-Separator-{"uri":{"$mid":1,"fsPath":"/Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite","external":"file:///Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite","path":"/Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite","scheme":"file"},"name":"inc_dec_example_test_suite","index":0}
2023-09-26 11:39:37.894 [debug] Clearing context for python dependencies not installed: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite/blank_folder/test_none.py
2023-09-26 11:39:37.979 [debug] Cached data exists KeyPrefix=Cache_Method_Output_b._selectIfLaunchedViaActivatedEnv-Args=true
2023-09-26 11:39:37.979 [debug] Found cached env for /usr/local/bin/python3.10
2023-09-26 11:39:37.979 [debug] Resolved /usr/local/bin/python3.10 from cache: {"name":"","location":"","kind":"global-other","executable":{"filename":"/usr/local/bin/python3.10","sysPrefix":"/usr/local/opt/python@3.10/Frameworks/Python.framework/Versions/3.10","ctime":1694448791180,"mtime":1694448791180},"display":"Python 3.10.13 64-bit","version":{"major":3,"minor":10,"micro":13,"release":{"level":"final","serial":0},"sysVersion":"3.10.13 (main, Aug 24 2023, 22:48:59) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]"},"arch":3,"distro":{"org":""},"source":["path env var"],"id":"/usr/local/bin/python3.10","detailedDisplayName":"Python 3.10.13 64-bit"}
2023-09-26 11:39:38.031 [debug] Clearing context for python dependencies not installed: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite/blank_folder/test_none.py

question for @meganrogge or @bhavyaus, how long did you both wait to see if the tests would load? Usually what happens with mine is that I click on the test explorer icon then have to wait a few seconds for the screen that says "configure tests" to disappear and be replaced by the tests discovered. This load time is a problem I have noted and I am looking to make a change which I am discussing in this issue: https://github.com/microsoft/vscode-python/issues/22007. The issue also has videos demonstrating what I mean by it resolving after a little lag time. If one of you could test to see if this is the case for you and there is just a delay that would be super helpful. Additionally would love your feedback on what UI change should be made to signal that loading is occurring. I was thinking a load icon somewhere (not sure where) but also maybe making it so the "configure tests" button doesn't appear would also help.

I had waited more than a minute I would say.
It's still not discovering tests. here's the full output:
023-09-28 09:58:01.181 [info] Experiment 'pythonTestAdapter' is active
2023-09-28 09:58:01.181 [info] Experiment 'pythonPromptNewFormatterExt' is active
2023-09-28 09:58:01.181 [info] Experiment 'pythonPromptNewToolsExt' is active
2023-09-28 09:58:01.181 [info] Experiment 'pythonTerminalEnvVarActivation' is active
2023-09-28 09:58:01.182 [info] Test server listening.
2023-09-28 09:58:01.182 [info] Python interpreter path: /usr/local/bin/python3.10
2023-09-28 09:58:07.268 [info] Starting Pylance language server.
2023-09-28 10:57:41.193 [info] > conda info --json
2023-09-28 11:41:20.865 [info] Discover tests for workspace name: inc_dec_example_test_suite - uri: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite
2023-09-28 11:41:20.865 [info] Running discovery for unittest using the new test adapter.
2023-09-28 11:41:20.911 [info] Discovering unittest tests with arguments: /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py,--port,62694,--uuid,75a1a244-b07d-44b5-84d9-2ed9b85253af,--udiscovery,-v,-s,.,-p,*test.py

2023-09-28 11:41:20.911 [info] > /usr/local/bin/python3.10 /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py --port 62694 --uuid 75a1a244-b07d-44b5-84d9-2ed9b85253af --udiscovery -v -s . -p *test.py
2023-09-28 11:41:20.911 [info] cwd: .
2023-09-28 11:41:21.582 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV
2023-09-28 11:41:21.582 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV. Creating and sending error discovery payload
2023-09-28 11:41:21.582 [error] Unittest test discovery error

 The python test process was terminated before it could exit on its own, the process errored with: Code: null, Signal: SIGSEGV
2023-09-28 11:41:21.582 [info] ResultResolver EOT received for discovery.
2023-09-28 11:41:21.980 [info] Discover tests for workspace name: inc_dec_example_test_suite - uri: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite
2023-09-28 11:41:21.980 [info] Running discovery for unittest using the new test adapter.
2023-09-28 11:41:22.040 [info] Discovering unittest tests with arguments: /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py,--port,62694,--uuid,a62ce555-7b74-4f45-9489-32e556001f03,--udiscovery,-v,-s,.,-p,*test.py

2023-09-28 11:41:22.040 [info] > /usr/local/bin/python3.10 /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py --port 62694 --uuid a62ce555-7b74-4f45-9489-32e556001f03 --udiscovery -v -s . -p *test.py
2023-09-28 11:41:22.040 [info] cwd: .
2023-09-28 11:41:22.486 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV
2023-09-28 11:41:22.486 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV. Creating and sending error discovery payload
2023-09-28 11:41:22.486 [error] Unittest test discovery error

 The python test process was terminated before it could exit on its own, the process errored with: Code: null, Signal: SIGSEGV
2023-09-28 11:41:22.486 [info] ResultResolver EOT received for discovery.
2023-09-28 11:41:27.844 [info] Discover tests for workspace name: inc_dec_example_test_suite - uri: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite/.vscode/settings.json
2023-09-28 11:41:27.844 [info] Running discovery for unittest using the new test adapter.
2023-09-28 11:41:27.887 [info] Discovering unittest tests with arguments: /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py,--port,62694,--uuid,e3bf2785-1b5d-46d8-86be-0a3e9ee331ed,--udiscovery,-v,-s,.,-p,*test*.py

2023-09-28 11:41:27.887 [info] > /usr/local/bin/python3.10 /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py --port 62694 --uuid e3bf2785-1b5d-46d8-86be-0a3e9ee331ed --udiscovery -v -s . -p *test*.py
2023-09-28 11:41:27.887 [info] cwd: .
2023-09-28 11:41:28.076 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV
2023-09-28 11:41:28.076 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV. Creating and sending error discovery payload
2023-09-28 11:41:28.077 [error] Unittest test discovery error

 The python test process was terminated before it could exit on its own, the process errored with: Code: null, Signal: SIGSEGV
2023-09-28 11:41:28.077 [info] ResultResolver EOT received for discovery.
2023-09-28 11:41:28.256 [info] Discover tests for workspace name: inc_dec_example_test_suite - uri: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite
2023-09-28 11:41:28.256 [info] Running discovery for unittest using the new test adapter.
2023-09-28 11:41:28.272 [info] Discovering unittest tests with arguments: /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py,--port,62694,--uuid,b0ec9933-406c-4e50-ae84-e4e54caaacf9,--udiscovery,-v,-s,.,-p,*test*.py

2023-09-28 11:41:28.272 [info] > /usr/local/bin/python3.10 /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12711016/pythonFiles/unittestadapter/discovery.py --port 62694 --uuid b0ec9933-406c-4e50-ae84-e4e54caaacf9 --udiscovery -v -s . -p *test*.py
2023-09-28 11:41:28.272 [info] cwd: .
2023-09-28 11:41:28.512 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV
2023-09-28 11:41:28.512 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV. Creating and sending error discovery payload
2023-09-28 11:41:28.512 [error] Unittest test discovery error

 The python test process was terminated before it could exit on its own, the process errored with: Code: null, Signal: SIGSEGV
2023-09-28 11:41:28.512 [info] ResultResolver EOT received for discovery.

I see that "The python test process was terminated before it could exit on its own, the process errored with: Code: null, Signal: SIGSEGV". It seems the issue is it doesn't show an error node- will investigate this. Thanks!

reviewed this code and still not seeing how it could not produce an error node to display- could you send over the code you were testing it on? I will also add another logging item and see if that gives me more insight in insiders tomorrow.

we discussed and this happened because there was a segfault in one of my tests. commenting that out fixed it

I wonder if we could make this error more obvious

this was a discussion more generally since I am not sure the way it displays it as a node in the test explorer is best- will find that issue and tag it here as we do discuss more.

feel free to close this if you are tracking it somewhere

closing in favor of the mentioned issue


Error: The account aurora wouldn't have enough balance to cover storage

when i try to deploy contract on aurora testnet with remix,that the error appear like this.
errored: [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32603,"data":{"code":-32603,"message":"Internal Error - Error: The account aurora wouldn't have enough balance to cover storage, required to have<PHONE_NUMBER>60297968038883 yoctoNEAR more. Please report a bug at https://github.com/aurora-is-near/aurora-relayer/issues","data":{"host":"r001.westcoast.us.testnet.internal.aurora.dev","cf-ray":"6db9ea1fc4eb3d12-PDX"}}}}'

I have sent 200 NEAR to https://explorer.testnet.near.org/accounts/aurora, so the problem should be resolved.
However, it would be good that we send a significant amount of NEAR to aurora to ensure the Aurora testnet is working well.

I have sent 200 NEAR to https://explorer.testnet.near.org/accounts/aurora, so the problem should be resolved.
However, it would be good that we send a significant amount of NEAR to aurora to ensure the Aurora testnet is working well.

thanks alot,guy!

send a significant amount of NEAR to aurora to ensure the Aurora testnet is working well

I have sent 200 NEAR to https://explorer.testnet.near.org/accounts/aurora, so the problem should be resolved.
However, it would be good that we send a significant amount of NEAR to aurora to ensure the Aurora testnet is working well.

How did you sent Near to Aurora? I am getting the same error

Has been fixed.


support docker links

This aren't that neccessary, IMHO.
because; They(links) are not required to enable services to communicate - by default, any service can reach any other service at that service’s name. - https://docs.docker.com/compose/networking/#links

fixed by https://github.com/komuW/meli/pull/55


pFaTools

Description
Added command line usage for pFasta tools: Sample, Extract, ExtractBed.

Added comment about usage to AreEqual in fileio/fileio.go.

Testing
Tests exist for Sample, Extract and ExtractBed (using the same input and expected output as in fasta/pfasta/tools_test.go)
Checklist before requesting a review

[x] I performed a self-review of my code
[x] If it this a core feature, I added thorough tests
[x] The command go fmt or make clean was used on all files included

Thanks for the PR contribution! Can you provide a summary of the purpose of the tools in this PR so we know what they will do before we start reviewing and then bulk up the documentation? I wasn't sure what the function descriptions were saying, or what the usage statements for the subcommands meant.


xcode and usb iphone passthrough

How to add an iphone to use with xcode
Références:
https://stackoverflow.com/questions/67279997/connect-iphone-via-usb-to-sosumi-qemu
https://github.com/sickcodes/Docker-OSX/issues/133
Define usb port to be usb passthrough
it is easier to select a usb bus where your iphone is single but in case you can't follow the udev rules
plug your iphone to usb
$ lsusb
Bus 001 Device 004: ID 05ac:12a8 Apple, Inc. iPhone 5/5C/5S/6/SE

Since qemu runs as a regular user, it cannot connect to hot-plug USB devices unless you change permssions on the host. Being in group plugdev might be sufficient for standard USD block devices. For others, such as an iphone, you need to manually change the /dev/bus/usb/xxx/yyy to group users or create /etc/udev/rules.d/97-iphone.rules.
https://www.linuxquestions.org/questions/blog/kingbeowulf-74138/qemu-usb-passthrough-with-specifics-for-iphone-37830/
sudo vim /etc/udev/rules.d/97-iphone.rules
SUBSYSTEMS=="usb", ATTRS{idVendor}=="05ac", ATTRS{idProduct}=="*",GROUP="users", MODE="0660"

0x05ac vendor ID in this case is for an Apple iPhone 5C. For iphones specifically, it can help to disable usbmuxd with an empty /etc/udev/rules.d/39-usbmuxd.rules
Now, either reboot (ha! this ain't windows!) or run as root
sudo udevadm control -R

then edit yout lanch-mac-os.sh and add
-usb \
-device usb-ehci,id=ehci \
-device usb-host,bus=ehci.0,vendorid=0x05ac,productid=0x12a8,guest-reset=false,id=iphone \

Warning if you intend to code with xcode or upgrade your iphone with your mac , remove the productid . see comment below.
Pairing an iOS device with Xcode

Open Xcode and go to Window > Devices and Simulators.
Plug your iOS device into your Mac using a lightning cable. You may need to select to Trust This Computer on your device.
Select your device and then select the Connect via network checkbox to pair your device:

https://stackoverflow.com/questions/10087985/xcode-doesnt-see-my-ios-device-but-itunes-does
Do I need to be a Apple Developer Member to deploy apps on my iphone ?
https://developer.apple.com/forums/thread/81424
when you launch your mac os x you should get this :
tom@toms-iMac ~ % lsusb
Bus 004 Device 002: ID 0627:0001 0627 QEMU USB Mouse  Serial: 89126-0000:00:04.0-3
Bus 004 Device 003: ID 0627:0001 0627 QEMU USB Keyboard  Serial: 68284-0000:00:04.0-2
Bus 004 Device 001: ID 05ac:12a8 Apple Inc. iPhone  Serial: 650d4ab950e8ece4cd07b637044440618c9080b4
Bus 000 Device 001: ID 1d6b:IPCI Linux Foundation USB 2.0 Bus
Bus 000 Device 001: ID 1d6b:IPCI
IPCI
IPCI
IPCI Linux Foundation USB 2.0 Bus

NB: Big scare while updating iphone ios from mac os x finder. The phone remained unusable and blocked in restore mode.
After analysis it appears that the productid is different in restore mode.
So to be upgrade, backup and restore your iphone I strongly advise you to remove the mention of the productid in your startup script qemu.
-usb \
-device usb-ehci,id=ehci \
-device usb-host,bus=ehci.0,vendorid=0x05ac,guest-reset=false,id=iphone \

Thank you for posting your solution here. Linked it in the README

When I tried @rawlines command it gave me this output:
tee: /sys/bus/usb/drivers/usbfs/unbind: No such device

So, what I did to find the correct identifier for my connected iPhone was typing ls /sys/bus/usb/drivers/usbfs/ in the command line and my indentifier was 1-3:1.0.

Is anyone having trouble redirecting the USB port to communicate with the iPhone on Sonoma?
I tried everything but XCode and Finder don't the iPhone.

Is anyone having trouble redirecting the USB port to communicate with the iPhone on Sonoma? I tried everything but XCode and Finder don't find the iPhone.

I assume that you have read all the thread, to make it short.
You have to connect the iPhone to a USB device, and if possible avoid plugging it on a hub.
The reason is that, once you choose your USB plug, you have to make it passthrough QEMU to the VM.
As a result, this plug won't be available for your host or any other VM.
Once you have done that, you should be able to see it in your Sonoma.

No idea, personally, I'm stuck in Ventura and I didn't find a way to bypass the security disk to allow the Sonoma upgrade. Can I ask you, how did you do ? Can you share it with us ?

Hi @tombombadilom,
I just did the Software Update from macOS.
I'm using this package to virtualize macOS: https://oneclick-macos-simple-kvm.notaperson535.is-a.dev/

Is anyone having trouble redirecting the USB port to communicate with the iPhone on Sonoma? I tried everything but XCode and Finder don't find the iPhone.

I assume that you have read all the thread, to make it short. You have to connect the iPhone to a USB device, and if possible avoid plugging it on a hub. The reason is that, once you choose your USB plug, you have to make it passthrough QEMU to the VM. As a result, this plug won't be available for your host or any other VM. Once you have done that, you should be able to see it in your Sonoma.

The problem is that Sonoma requires qemu-xhci.
I downgraded to Ventura and reverted the configuration to usb-ehci, then I was able to communicate with the iPhone again.


#3 -feature/student-profile-section-saadia

Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
Create a profile section front-end, where the bio is editable and a profile picture can be changed
I used Material UI library for styling and creating components and for uploading images using  react-uploader
Related to
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
Fixes #3
Checklist:

[x] My code follows the style guidelines of this project
[x] I have carefully reviewed my own code
[ ] I have commented my code
[ ] I have updated any documentation

Good job on the student profile page


improving pickset performance while returning unique values

This improves the performance of pickset while continuing to provide a unique pick of elements from the array.
pickset in the console on the website (currently v1.0.13) would not return more items than the length of the array, so I created a test for that restriction to avoid errors with this implementation.
Fixes #335 #336

Thanks @Snoturky !


vdc Actor needs support to set the external network

Proposed schema addition:
externalNetwork = type:int list:1:1

PLease fix as PR on 8.1.1

this ticket is blocked by: https://github.com/0-complexity/openvcloud/issues/725

0-complexity/openvcloud#725 is on verification.

verified on 8.1.1


How to get Rennet ?

I can't get any rennet when I killing a cow or deer, maybe I got the wrong way. But how can I get the rennet, I can't find the way in wiki either. Is this function not completed yet?

it's a 1/3 chance

i will make it 100% chance next update

I've killed over 50 cows and still haven't dropped rennet.


Screen boundaries on built-for-Android binaries are different comparing a Linux and Windows compilation

I am using a Pixel 3 and a Moto x4 as test devices. Both devices feature on-screen buttons. The Moto x4 is running Android 10 and the pixel 3 is running Android 11.
In my application I am using a dark transparent status bar. This means that the foreground is black, and the background is up to my application to define. I use an off-white. When building for either device on Windows, my white is painted behind the status bar and is visible. When building for the pixel 3 on Linux, the white boundary stops short of the status bar. This means there is no painting behind the status bar, and so it is invisible (black on black).
Here is equivalent code for drawing my white rectangle:
local background = display.newRect(0, 0, display.contentWidth, display.safeActualContentHeight + display.topStatusBarContentHeight)
background:translate(background.width * 0.5, background.height * 0.5)
background:setFillColor(0.95, 0.95, 0.95, 1)

Other symptoms:

My content starts at the topStatusBarContentHeight. From a Windows build, this appears directly underneath the status bar. From a Linux build, there is a status-bar sized gap between the status bar and the content.
There is a large gap on the bottom part of the screen between the bottom buttons and the white background. This gap could actually be the size of the bottom buttons.
If I force the background to be very tall so it should go above and below the top and bottom of the screen, it will reach the bottom to just above the button bar where I expect it, but there is no change to the top.

I need to retract this. I don't know what happened but I see the same behavior in Windows.


Some protein sequences and other terms become "obsolete"

Please double check.

If the term are in fact obsoleted, then the owl:deprecated(annotation property) needs to be marked as true.

Added owl:deprecated as True for all obsolete terms


[Firebase 10] Bump versions for 10.0.0

Context

Bumped all Firebase products to 10.0.0
Bumped dependencies on GTMSessionFetcher to min 2.1
Bumped dependencies on GoogleUtilities to 7.8
Bumped dependencies on GoogleDataTransport to 9.2

@paulb777, three failures are blocking this PR. The functions / quickstart one is because the legacy functions quickstart uses FirebaseUI and FirebaseUI's latest version is not compatible with Firebase 10.
The other two, I'm not so sure about based on the logs.

zip / package-head
functions / quickstart
remoteconfig / sample-build-test

Any ideas?

auth / pod-lib-lint (tvos) had a failure from raising the minimum supported tvOS version. It looks due to a deprecation warning that was new in tvOS 12.

auth / pod-lib-lint (tvos) had a failure from raising the minimum supported tvOS version. It looks due to a deprecation warning that was new in tvOS 12.

Fixed in abaa752

FirebaseUI release in progress (https://github.com/firebase/FirebaseUI-iOS/pull/1100), might punt to Monday

There were some issues that arose from bumping tvOS to 12.

[ ] On green CI, squash the tvOS commits down to one in case we want to undo bumping to tvOS 12

Ok, as of 91c7dbe, all CI is passing except for expected FirebaseUI failure.
Going to send two more commits:

one to squash all of the tvOS 12 commits into one
one to revert Gemfile

Ok, as of 91c7dbe, all CI is passing except for expected FirebaseUI failure.
Going to send two more commits:

one to squash all of the tvOS 12 commits into one
one to revert Gemfile

I ultimately wanted one commit for all the tvOS changes in case we needed to revert in the future. Since all PR commits are squashed into master, I'm not sure if the squash tvOS commit could be singly reverted anyway... Anyhow, in messing with the commit history, 91c7dbe no longer exists. But the tests did pass at that point and there was no extra diff (apart from reverted Gemfile) when I submitted. So, should be good here.

FirebaseUI's been pushed, tests should pass now.

thank you @morganchen12!


vscode: remove unnecessary code

This cancel is unnecessary since we cancel the previous inlay hints requests in fetchHints() method itself. This is not a hard error, we just called cancel() 2 times.

bors r+

bors retry


Retrieving activity model on saving activity log

Method log() of ActivityLogger class creates instance of activity model and save data, but return ActivityLogger object instead of saved activity eloquent instance. I have no idea yet how can I use ActivityLogger object returning by log() method, so I'd suggest the log() should return saved activity model instance.
If for some reasons it's not possible, at least ActivityLogger class could have method with name like retrieveModel() to do such thing.

Why do you want to have the Activity-model being returned?

The package provides switching default Activity model to my custom model, which means that I'm able to extend fields and methods of Activity model, but ActivityLogger class doesn't know about my extendings, however it works with it, so it's my task to work with my extended Activity model after it was created. But I should use $activity = Activity::all()->last() instead of direct retrieving model instance. If you mention such method to retrieve activity model, so you keep in mind too that you could want to have the Activity-model being returned somewhen.
In opposite your question, I can ask you the same, why do I have the ActivityLogger object after method log() called? Ok, for example it could be a chain of ..->log()..->log()..->log() logging process, but saved activity instance could be returned explicitly by calling smth like retrieveModel() at least.

I've tagged a new version where the log() function returns the custom activity model.
https://github.com/spatie/laravel-activitylog/blob/1.10.2/tests/ActivityloggerTest.php#L206-L226


Rds snapshot restore

Adds support for issue #209. Adding the parameter creates the RDS instance using a DB snapshot.
restore_snapshot => 'some-snapshot-name'

+1, though there seems to be more in this PR than is in the is in the commit messages.

Sorry, I think that was from a bad rebase. I have corrected the PR

One question for my understanding, but still +1 on this change.

Can this get merged please?

I'm still +1 on this change.


[Mod]: KSP Mod Chinese Patches

Mod Name
KSP Mod Chinese Patches
Description
A collection of Module Manager patches for translating KSP Mods (Part mods mostly) to Chinese (Simplified Chinese Only).
Author(s)
tinygrox
License
CC BY 4.0
Homepage link
https://github.com/tinygrox/KSP_Chinese_Patches
Download link
https://github.com/tinygrox/KSP_Chinese_Patches/releases

Is there any problem with this? It's been a long time and still not uploaded to ckan yet.
I follow the Guide but no one has asked me about any questions. You guys just ignore this for 3 weeks and I don't know why.


Bug: SignUp for new user fails with User Model not found error

Issue Template
Description
SignUp for new user fails with User Model not found error
Steps to Reproduce
Please provide step-by-step instructions on how to reproduce the issue:

Go to home page
Click on sign up
Scroll down to submit
See error

Screenshots

Additional Context
Add any other context or information about the issue here.

@yashmandi : please assign it to me


Run time error during forward pass of SRU

I am running into this issue whenenver I do forward pass.
Have copied the error messages below.
I have tried many things to get over this issue without success.
I tried installing via pip install and also directly including source code, and still see the issue.
Please let me know if you need any more details from my side to debug.

output_states, c_states = rnn(x)      # forward pass

Traceback (most recent call last):
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1030, in _build_extension_module
check=True)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/subprocess.py", line 512, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/nn/modules/module.py", line 541, in call
result = self.forward(*input, **kwargs)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/sru/modules.py", line 607, in forward
h, c = rnn(prevx, c0_[i], mask_pad=mask_pad)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/nn/modules/module.py", line 541, in call
result = self.forward(*input, **kwargs)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/sru/modules.py", line 261, in forward
h, c = self.apply_recurrence(U, V, residual, c0, scale_val, mask_c, mask_pad)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/sru/modules.py", line 284, in apply_recurrence
self.amp_recurrence_fp16)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/sru/ops.py", line 97, in elementwise_recurrence_gpu
from .cuda_functional import SRU_Compute_GPU
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/sru/cuda_functional.py", line 14, in
verbose=False
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 661, in load
is_python_module)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 830, in jit_compile
with_cuda=with_cuda)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 883, in write_ninja_file_and_build
build_extension_module(name, build_directory, verbose)
File "/home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1043, in build_extension_module
raise RuntimeError(message)
RuntimeError: Error building extension 'sru_cuda_impl': [1/2] /usr/local/bin/nvcc -DTORCH_EXTENSION_NAME=sru_cuda_impl -DTORCH_API_INCLUDE_EXTENSION_H -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include/TH -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include/THC -isystem /usr/local/include -isystem /home/vesathya/anaconda3/envs/SRUTrial/include/python3.7m -D_GLIBCXX_USE_CXX11_ABI=1 -D__CUDA_NO_HALF_OPERATORS -D__CUDA_NO_HALF_CONVERSIONS -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -std=c++11 -c /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/sru/csrc/sru_cuda_kernel.cu -o sru_cuda_kernel.cuda.o
FAILED: sru_cuda_kernel.cuda.o
/usr/local/bin/nvcc -DTORCH_EXTENSION_NAME=sru_cuda_impl -DTORCH_API_INCLUDE_EXTENSION_H -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include/TH -isystem /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/torch/include/THC -isystem /usr/local/include -isystem /home/vesathya/anaconda3/envs/SRUTrial/include/python3.7m -D_GLIBCXX_USE_CXX11_ABI=1 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -std=c++11 -c /home/vesathya/anaconda3/envs/SRUTrial/lib/python3.7/site-packages/sru/csrc/sru_cuda_kernel.cu -o sru_cuda_kernel.cuda.o
sh: cicc: command not found
ninja: build stopped: subcommand failed.

hi @venkateshsathya ,
SRU uses a custom pytorch operator that has to be compiled just-in-time (JIT). ninja(https://github.com/ninja-build/ninja) is the build system used. See: https://pytorch.org/tutorials/advanced/cpp_extension.html
In your log, the error is "sh: cicc: command not found". and I could find some related posts via google:
https://forums.developer.nvidia.com/t/when-i-arch-option-error-sh-cicc-command-not-found-takes-place/31753
https://github.com/ShuangLI59/person_search/issues/56
Seems the issue is related to CUDA installation. Hope this would help.


assert len(gpus) > len(visible_gpu_idx)

Wed Apr  1 08:54:43 2020[0]:name: GeForce GTX 1070 major: 6 minor: 1 memoryClockRate(GHz): 1.759
Wed Apr  1 08:54:43 2020[0]:pciBusID: 0000:01:00.0
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.171558: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudart.so.10.0
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.173728: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcublas.so.10.0
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.175027: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcufft.so.10.0
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.175832: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcurand.so.10.0
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.178045: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcusolver.so.10.0
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.179579: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcusparse.so.10.0
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.183873: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudnn.so.7
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.183987: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:1006] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.184595: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:1006] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
Wed Apr  1 08:54:43 2020[0]:2020-04-01 08:54:43.185004: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1746] Adding visible gpu devices: 0
Wed Apr  1 08:54:43 2020[0]:Traceback (most recent call last):
Wed Apr  1 08:54:43 2020[0]:  File "athena/main.py", line 171, in
Wed Apr  1 08:54:43 2020[0]:    BaseSolver.initialize_devices(p.solver_gpu)
Wed Apr  1 08:54:43 2020[0]:  File "/mnt/3T/mygits/ASR-NLP/FrameWorks/athena/athena/solver.py", line 54, in initialize_devices
Wed Apr  1 08:54:43 2020[0]:    assert len(gpus) > len(visible_gpu_idx)
Wed Apr  1 08:54:43 2020[0]:AssertionError
Process 0 exit with status code 1.
Traceback (most recent call last):
File "/home/wcl/anaconda3/bin/horovodrun", line 21, in
run_commandline()
File "/home/wcl/anaconda3/lib/python3.7/site-packages/horovod/run/run.py", line 876, in run_commandline
_run(args)
File "/home/wcl/anaconda3/lib/python3.7/site-packages/horovod/run/run.py", line 844, in _run
_launch_job(args, remote_host_names, settings, common_intfs, command)
File "/home/wcl/anaconda3/lib/python3.7/site-packages/horovod/run/run.py", line 867, in _launch_job
gloo_run(settings, remote_host_names, common_intfs, env, driver_ip, command)
File "/home/wcl/anaconda3/lib/python3.7/site-packages/horovod/run/gloo_run.py", line 287, in gloo_run
_launch_jobs(settings, env, host_alloc_plan, remote_host_names, run_command)
File "/home/wcl/anaconda3/lib/python3.7/site-packages/horovod/run/gloo_run.py", line 259, in _launch_jobs
.format(name=name, code=exit_code))
RuntimeError: Gloo job detected that one or more processes exited with non-zero status, thus causing the job to be terminated. The first process to do so was:
I'm trying single GPU and close hvd。

If you're using single GPU, please comment out horovod part in run.sh and change commands to something like 'python athena/main.py examples/asr/aishell/configs/xxx.json'

If the server has 4 gpu, and I want to use only 1. Could I use command like "CUDA_VISIBLE_DEVICES=0 python athena/main.py "?
It seems athena/solver.py gives assert ?
    @staticmethod     def initialize_devices(visible_gpu_idx=None):         """ initialize hvd devices, should be called firstly """         gpus = tf.config.experimental.list_physical_devices("GPU")         for gpu in gpus:             tf.config.experimental.set_memory_growth(gpu, True)         if gpus is not None:             assert len(gpus) > len(visible_gpu_idx)


Added the Optimised approach of Optimizing Disaster Relief Supply Packing

📥 Pull Request
Description
I have added the optimised approach to do the 0/1 Knapsack Problem with a 1d array instead of a 2d array with time complexity of O(W) instead of O(nW).
Fixes # (issue number)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@ajay-dhangar


  This seems like a limitation of the routing primitives we're using, they were mainly designed for the route matching part of a request where duplicates would not make sense. I'll ask around to see if there is something else we can do here.
Workaround: You'd need to write a custom transform for this.

This is a limitation of the url generation engine we're using, I don't think we'll be able to change that.

what a pity
: (

what a pity
: (

Triage: This is ASP.NET limitation. Nothing we can do about it here. Closing.
If there is significant feedback in ASP.NET, they might change their mind there.


SyntheticMethod -> Method

Motivation

Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_QUynQnzidesy54
→ https://go/builds/bui_QUynd0dujMJ4Ls
→ https://go/builds/bui_QUynAxU4bM9YEN


SAMZA-2266: Introduce a backoff when there are repeated failures for host-affinity allocations

Motivation
For host-affinity enabled jobs, a bad physical host may not immediately be marked as invalid by the Resource Manager (RM). As a result, when the HostAwareContainerAllocator requests preferred hosts, the RM generates the onResourceCompleted callback even though the host can't be allocated. The status error in the onResourceCompleted is equivalent to an application error and the retry logic kicks in to restart the failed container. Adding delays in the retry logic will prevent the job from failing prematurely (after 8 retries) before the bad host is marked invalid.
Implementation notes
Added an exponential back-off with a max delay. Container allocation requests are put in a priority queue with the priority determined by type and request timestamp. For retries that have a delay, I set the request timestamp in the future by time X where X is the calculated back-off.
Testing
Unit tests and tested a Samza job on a YARN cluster. I simulated the scenario by forcing an uncaught exception in a few containers to force the containers to fail.
@rmatharu @abhishekshivanna and others please take a look

PR on hold due to a bug that @rmatharu and I discovered. Will work on a PR for that bug and merge that in here afterwards once that bug fix is in master. Details of the bug here SAMZA-2277

@rmatharu please take a look at PR #1108 for the fix with the retry window. I'll merge master here once that PR is committed to master. Thanks.

@rmatharu please take a look at the latest changes. I merged in master to pull in the changes from PR #1108 that has the fix for the retry window. The rest of the commits where to clean up some things and to address your comments.
I'll be testing on an actual job, so please hold off from merging until I'm done, but feel free to review the code in the meantime. Thanks!

@rmatharu I tested on an actual job and it seems to work well. Per our discussion, it's no longer doing an exponential backoff, but instead it adds a delay at the last retry for the container restart. The last delayed retry honors the cluster-manager.container.retry.window.ms by not including the delay as part of the window. Please take a look when you get a chance.

@rmatharu - I addressed your latest comments and the build is green. Please merge after your approve. Thanks for reviewing this PR.

thanks, will  merge

thanks, will merge

Great! Thanks again for reviewing.


mimxrt1060_evk tests/kernel/mem_pool/mem_pool_threadsafe meets Imprecise data bus error

Describe the bug
Imprecise data bus error
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=mimxrt1060_evk ..
make
See error

Expected behavior
Test pass
Impact
memory pool
Screenshots or console output
***** Booting Zephyr OS 1.14.0-rc1 *****

Running test suite mpool_threadsafe

===================================================================

starting test - test_mpool_threadsafe

***** BUS FAULT *****

  Imprecise data bus error

***** Hardware exception *****

Current thread ID = 0x800000d0

Faulting instruction address = 0x600056ae

Fatal fault in ISR! Spinning..

Environment (please complete the following information):

OS: (Linux)
Toolchain (Zephyr SDK)
Commit SHA or Version used: v1.14.0_rc1

Additional context
Add any other context about the problem here.

@MaureenHelm

This sounds a lot like a duplicate of #12559, which has a fix up in #13770.  Could you try with that applied and verify it works for you?

@andyross thanks it fixed


chore: release

Codecov Report

Merging #405 (bc52256) into main (ab52fe7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   90.41%   90.45%   +0.03%
==========================================
  Files         154      154
  Lines        3629     3644      +15
  Branches     1205     1210       +5
==========================================
+ Hits         3281     3296      +15
  Misses        190      190
  Partials      158      158

Impacted Files
Coverage Δ

...ckages/react-magma-dom/src/components/Tabs/Tab.tsx
92.40% <ø> (ø)

.../react-magma-dom/src/components/Textarea/index.tsx
100.00% <ø> (ø)

...eact-magma-dom/src/components/Typography/index.tsx
88.05% <ø> (ø)

packages/react-magma-dom/src/theme/magma.ts
100.00% <ø> (ø)

...react-magma-dom/src/components/AlertBase/index.tsx
97.29% <100.00%> (+0.03%)
:arrow_up:

...ges/react-magma-dom/src/components/Badge/index.tsx
100.00% <100.00%> (ø)

...es/react-magma-dom/src/components/Banner/index.tsx
100.00% <100.00%> (ø)

...magma-dom/src/components/Breadcrumb/Breadcrumb.tsx
100.00% <100.00%> (ø)

...ma-dom/src/components/DatePicker/CalendarMonth.tsx
100.00% <100.00%> (ø)

...om/src/components/DatePicker/HelperInformation.tsx
100.00% <100.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528c1ec...bc52256. Read the comment docs.


bug: v1 dev build failing due to missing packages

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.0.1
Current Behavior
When spinning up a dev server of a fresh app with only latest (as of today) wagmi, rainbowkit, and viem installed, I see an error that prevents my build from completing.
Expected Behavior
The build completes without error.
Steps To Reproduce

Create a fresh app using pnpm create @rainbow-me/rainbowkit@latest
Start the dev server with pnpm run dev
Observe that the build fails with an error

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
error - ./node_modules/.pnpm/node-gyp-build@4.6.0/node_modules/node-gyp-build/node-gyp-build.js:1:0
Module not found: Can't resolve 'fs'

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./node_modules/.pnpm/@walletconnect+legacy-client<EMAIL_ADDRESS>./node_modules/.pnpm/@walletconnect+legacy-client<EMAIL_ADDRESS>./node_modules/.pnpm/@walletconnect+legacy-client<EMAIL_ADDRESS>./node_modules/.pnpm/@walletconnect+legacy-provider<EMAIL_ADDRESS>./node_modules/.pnpm/@walletconnect+legacy-provider<EMAIL_ADDRESS>./node_modules/.pnpm/@wagmi+connectors@1.0.1_@wagmi+chains@0.2.22_react@18.2.0_typescript@5.0.4_viem<EMAIL_ADDRESS>./node_modules/.pnpm/@wagmi+core@1.0.1_react@18.2.0_typescript@5.0.4_viem<EMAIL_ADDRESS>./node_modules/.pnpm/wagmi@1.0.1_react-dom@18.2.0_react@18.2.0_typescript<EMAIL_ADDRESS>./node_modules/.pnpm/@rainbow-me+rainbowkit@1.0.0_@types+react@18.0.9_react-dom@18.2.0_react@18.2.0_viem@0.3.19_wagmi<EMAIL_ADDRESS>./pages/_app.tsx

https://nextjs.org/docs/messages/module-not-found

Seems that WalletConnect unneccessarily pulls in Node.js dependencies (previously, Ethers.js polyfilled these, but polyfilling as a side-effect is generally not good practice).
You can mitigate this by polyfilling fs, etc in your Next.js config:
module.exports = {
  webpack: (config) => {
    config.resolve.fallback = { fs: false, net: false, tls: false }
    return config
  },
}

comon walletconnect

With walletconnect legacy being unused by most apps since its deprecation, how can we go about removing it instead of polyfilling junk for it to build?
I'm trying to use the edge runtime for nextjs, and I can't figure out if there's something I can do in my project, or if I need to open up a PR in wagmi or connectkit. Thanks.


dracut: support initramfs network configuration via cmdline

I based the new hook on the upstream one for network configuration with normal tools.  This version really just added some bits for converting a netmask to CIDR notation (for networkd Address syntax), and it removed a lot of extra parts that are only relevant to the upstream module.

LGTM though I'm curious if IPv6 works actually works in ip_to_var or not.


Only first statefulset created when spinning up new cluster

Type of question
General Help
Question
What did you do?
Fresh install (via helm3) of casskop 2.1.13 in GKE (v1.22.15-gke.100) I see the following logged repeatedly:
time="2022-12-20T20:22:14Z" level=info msg="Error Waiting for sts change" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
1.6715677348775537e+09  INFO    controller_cassandracluster     Reconciling CassandraCluster    {"Request.Namespace": "development", "Request.Name": "sre-cassandra"}
time="2022-12-20T20:22:14Z" level=info msg="We will request : sre-cassandra-srecassandra100g-uscentral1a-0.sre-cassandra to catch hostIdMap" cluster=sre-cassandra err="<nil>"
time="2022-12-20T20:22:14Z" level=info msg="The Operator Waits 20 seconds for the action to start correctly" cluster=sre-cassandra rack=srecassandra100g-uscentral1a
time="2022-12-20T20:22:16Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-20T20:22:17Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-20T20:22:18Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-20T20:22:19Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-20T20:22:20Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-20T20:22:20Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-20T20:22:20Z" level=info msg="Error Waiting for sts change" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-20T20:22:20Z" level=error msg="Issue when updating CassandraCluster" cluster=sre-cassandra err="Operation cannot be fulfilled on cassandraclusters.db.orange.com \"sre-cassandra\": the object has been modified; please apply your changes to the latest version and try again"
1.6715677400486872e+09  INFO    controller_cassandracluster     Reconciling CassandraCluster    {"Request.Namespace": "development", "Request.Name": "sre-cassandra"}
time="2022-12-20T20:22:20Z" level=info msg="We will request : sre-cassandra-srecassandra100g-uscentral1a-0.sre-cassandra to catch hostIdMap" cluster=sre-cassandra err="<nil>"
time="2022-12-20T20:22:20Z" level=info msg="The Operator Waits 20 seconds for the action to start correctly" cluster=sre-cassandra rack=srecassandra100g-uscentral1a

This results in only the first statefulset being created, as the operator hangs indefinitely waiting for the sts change.
What did you expect to see?
I expected to see the cluster spin up completely with all "racks/statefulsets" coming online.
What did you see instead? Under which circumstances?
The operator hangs waiting for an unknown statefulset update to take place, causing only one rack to come online.
Environment

casskop version:

2.1.13

Kubernetes version information:

kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.12", GitCommit:"696a9fdd2a58340e61e0d815c5769d266fca0802", GitTreeState:"clean", BuildDate:"2022-04-13T19:07:00Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.15-gke.100", GitCommit:"4262ac74f84d8f8ec8f692ea2080483e932554f9", GitTreeState:"clean", BuildDate:"2022-09-22T09:24:03Z", GoVersion:"go1.16.15b7", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:

GKE

Cassandra version:

3.11.14

I tested this morning on 2.1.12 and got the same results. I wasn't able to test on 2.1.11 or 2.1.10 due to images not being found properly (a fresh install was looking for tag 1.0.0 on both?).
Testing on 2.1.9 currently and I'll report back.

@rocket357  Can you test with Cassandra 3.11.9 ? Our e2e tests run with this version with no issue https://github.com/cscetbon/casskop/blob/master/test/kuttl/sidecars/00-clusterWithTwoSidecars.yaml#L7. I'd like to see if it's because of the version of Cassandra for some reason

Certainly, testing now.

Same behavior observed with Cassandra 3.11.9 on fresh 2.1.13 helm install.
time="2022-12-23T18:50:19Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:20Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:21Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:22Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:23Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:23Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:23Z" level=info msg="Error Waiting for sts change" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
1.6718214236750228e+09  INFO    controller_cassandracluster     Reconciling CassandraCluster    {"Request.Namespace": "development", "Request.Name": "sre-cassandra"}
time="2022-12-23T18:50:23Z" level=info msg="We will request : sre-cassandra-srecassandra100g-uscentral1a-0.sre-cassandra to catch hostIdMap" cluster=sre-cassandra err="<nil>"
time="2022-12-23T18:50:23Z" level=info msg="[sre-cassandra][srecassandra100g-uscentral1a]: Update UpdateStatefulSet is Done"
time="2022-12-23T18:50:24Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:25Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:26Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:27Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:28Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:28Z" level=info msg="Waiting for new version of statefulset" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:28Z" level=info msg="Error Waiting for sts change" cluster=sre-cassandra statefulset=sre-cassandra-srecassandra100g-uscentral1a
time="2022-12-23T18:50:28Z" level=error msg="Issue when updating CassandraCluster" cluster=sre-cassandra err="Operation cannot be fulfilled on cassandraclusters.db.orange.com \"sre-cassandra\": the object has been modified; please apply your changes to the latest version and try again"

Interesting .... Our tests run with 1.20.15 see https://github.com/cscetbon/casskop/blob/master/.github/workflows/e2e-tests.yml#L101. If you can test with a similar version as well. There might something with the k8s version used :/

@rocket357 👆

I don't have the means to test on 1.20 currently due to some other projects that have come up.  I'll re-open (or re-create) in the future once I get a moment.

I encountered on the same problem when I tried to upgrade casskop from 2.1.10 to 2.1.16.
In operator I see the same logs like @rocket357 but I see also problems in cassandra pod:
WARN  [cassandra-exporter-harvester-defer-0] 2023-05-15 11:57:24,295 Harvester.java:188 - Failed to register collector for MBean org.apache.cassandra.metrics:type=Connection,scope=<IP_ADDRESS>,name=SmallMessageCompletedTasks
java.lang.IllegalStateException: Object NamedObject{name=org.apache.cassandra.metrics:type=Connection,scope=<IP_ADDRESS>,name=SmallMessageCompletedTasks, object=org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge@437eada4} and NamedObject{name=org.apache.cassandra.metrics:type=Connection,scope=<IP_ADDRESS>,name=SmallMessageCompletedTasks, object=org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge@e0d8bc6} cannot be merged, yet their labels are the same.
    at com.zegelin.cassandra.exporter.collector.dynamic.FunctionalMetricFamilyCollector.lambda$merge$0(FunctionalMetricFamilyCollector.java:73) ~[cassandra-exporter-agent.jar:na]
    at java.util.HashMap.merge(HashMap.java:1254) ~[na:1.8.0_282]
    at com.zegelin.cassandra.exporter.collector.dynamic.FunctionalMetricFamilyCollector.merge(FunctionalMetricFamilyCollector.java:73) ~[cassandra-exporter-agent.jar:na]
    at java.util.HashMap.merge(HashMap.java:1254) ~[na:1.8.0_282]
    at java.util.Collections$SynchronizedMap.merge(Collections.java:2689) ~[na:1.8.0_282]
    at com.zegelin.cassandra.exporter.Harvester.lambda$registerMBean$0(Harvester.java:184) ~[cassandra-exporter-agent.jar:na]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_282]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_282]
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) ~[na:1.8.0_282]
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) ~[na:1.8.0_282]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_282]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_282]

I see the same results for cassandra 3.11.9 and 3.11.14.

@cscetbon Can you reopen this issue?


401 Unauthorized pulling from private registry

Issue #16 is closed indicating that public/private registries are supported, but project-copacetic/copa-action@main fails to be able to pull from an ECR registry.  I've logged into the registry every way in the github action that I could think to do it.  As far as I understand, there are no parameters to the buildx container that runs, so I'm not sure how it's supposed to authenticate with the registry.
The documentation at https://github.com/project-copacetic/copa-action?tab=readme-ov-file#ways-to-connect-to-buildkit seems to indicate buildx (Option 1) is the only supported way to connect to private registries.

This is a private registry and private git repository, but the full contents of the github workflow is:
name: Docker Image Build

on:
  workflow_dispatch:
    inputs:
      keycloak_tag:
        description: "The keycloak tag to patch.  Assumes that ECR already has the ironbank tag with `-0` appended in to use as a base image."
        required: true

jobs:

  build:

    name: Build Image
    runs-on: ubuntu-latest

    steps:
    - name: Configure environment
      run: |
        echo "TAG=${{ github.event.inputs.keycloak_tag }}" >> $GITHUB_ENV
        echo "REGISTRY=***REDACTED***.dkr.ecr.us-east-1.amazonaws.com" >> $GITHUB_ENV
        echo "REPOSITORY=ironbank/opensource/keycloak/keycloak" >> $GITHUB_ENV
        mkdir -p ${HOME}/.aws
        echo "[default]" >> ${HOME}/.aws/credentials
        AWS_ACCESS_KEY_ID=${{ secrets.AWS_ACCESS_KEY_ID }}
        AWS_SECRET_ACCESS_KEY=${{ secrets.AWS_SECRET_ACCESS_KEY }}
        echo "aws_access_key_id = ${AWS_ACCESS_KEY_ID}" >> ${HOME}/.aws/credentials
        echo "aws_secret_access_key = ${AWS_SECRET_ACCESS_KEY}" >> ${HOME}/.aws/credentials
        aws ecr get-login-password --region us-east-1 | sudo docker login --username AWS --password-stdin ***REDACTED***.dkr.ecr.us-east-1.amazonaws.com

    - name: Configure AWS credentials us-east-1
      uses: aws-actions/configure-aws-credentials@v2
      with:
        aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
        aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        aws-region: us-east-1

    - name: Login to Amazon ECR us-east-1
      id: us-east-1-ecr
      uses: aws-actions/amazon-ecr-login@v1

    - name: Get the Docker image
      run: |
        sudo docker pull ${REGISTRY}/${REPOSITORY}:${TAG}-0

    - name: Generate Trivy Report
      uses: aquasecurity/trivy-action@d43c1f16c00cfd3978dde6c07f4bbcf9eb6993ca # 0.16.1
      with:
        scan-type: "image"
        format: "json"
        output: "report.json"
        ignore-unfixed: true
        vuln-type: "os"
        image-ref: ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ env.TAG }}-0

    - name: Check vulnerability count
      id: vuln_count
      run: |
        report_file="report.json"
        vuln_count=$(jq 'if .Results then [.Results[] | select(.Class=="os-pkgs" and .Vulnerabilities!=null) | .Vulnerabilities[]] | length else 0 end' "$report_file")
        echo "vuln_count=$vuln_count" >> $GITHUB_OUTPUT
        echo "vuln_count=$vuln_count"

    - name: Run Copa action
      if: steps.vuln_count.outputs.vuln_count != '0'
      id: copa
      # using main for testing purposes
      # use a tag (such as v1 or v1.0.1) at a bare minimum
      # recommendation is to pin to a digest for security and stability
      # and rely on dependabot for digest/version updates
      uses: project-copacetic/copa-action@main
      with:
        image: ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ env.TAG }}-0
        image-report: "report.json"
        patched-tag: "patched"
        timeout: "5m" # optional, default is 5m
        output: vex.json # optional
        format: "openvex" # optional, default is openvex

    - name: Tag Copa image for push
      if: steps.vuln_count.outputs.vuln_count != '0'
      id: tag_copa_img
      run:
          docker tag ${REGISTRY}/${REPOSITORY}:${TAG}-0-patched ${REGISTRY}/${REPOSITORY}:${TAG}

    - name: Tag and push the Docker image to us-east-1
      if: steps.vuln_count.outputs.vuln_count != '0'
      env:
        ECR_REGISTRY: ${{ steps.us-east-1-ecr.outputs.registry }}
      run: |
          docker tag ${REPOSITORY}:${TAG} $ECR_REGISTRY/${REPOSITORY}:${TAG}
          docker push $ECR_REGISTRY/$REPOSITORY:${TAG}

In my case, I have copied the original keycloak image from ironbank to our ECR with a tag of 25.0.1-0 and I'm attempting to patch the image and update the 25.0.1 tag for keycloak with the output from copa.  I don't think ironbank images have anything special about them, we could copy registry.access.redhat.com/ubi9/ubi-minimal:9.4-949 to our private ECR as registry.access.redhat.com/ubi9/ubi-minimal:9.4-949-0 and then attempt to run copa against it and have the same results.

Hi @anthony-zawacki sorry for the delayed response, are you able to patch this same image locally using copa or does it result in the same error? Also, since you are able to pull the image in the workflow, can you try the containerd image store approach for local images to see if that also results in the same error?

This is a touch painful.  :)
At the top of my workflow, I've added:
    steps:
    - name: Set up crazy-max's Docker server
      uses: crazy-max/ghaction-setup-docker@v3
      with:
        daemon-config: |
          {
            "debug": true,
            "experimental": true,
            "features": {
              "containerd-snapshotter": true
            }
          }
    - name: Get socket path
      run: |
        url=$(docker context inspect | jq -r .[0].Endpoints.docker.Host)
        socket_path=$(echo "$url" | awk -F// '{print $2}')
        echo "$socket_path"
        echo "SOCKET=$socket_path" >> $GITHUB_ENV
        echo "DOCKER_URL=$url" >> $GITHUB_ENV

However<EMAIL_ADDRESS>runs and builds a local image in docker before these steps run.  Trying to use the crazy-max docker server fails on the trivy step because the local image they built as part of the set up to the action doesn't exist in that docker server.  To work around this, in my environment configuration section, changed it to log into the ECR registry with both the "standard" docker server as well as the crazy-max docker server:
    - name: Configure environment
      run: |
        echo "TAG=${{ github.event.inputs.keycloak_tag }}" >> $GITHUB_ENV
        echo "REGISTRY=948564350653.dkr.ecr.us-east-1.amazonaws.com" >> $GITHUB_ENV
        echo "REPOSITORY=ironbank/opensource/keycloak/keycloak" >> $GITHUB_ENV
        mkdir -p ${HOME}/.aws
        echo "[default]" >> ${HOME}/.aws/credentials
        AWS_ACCESS_KEY_ID=${{ secrets.AWS_ACCESS_KEY_ID }}
        AWS_SECRET_ACCESS_KEY=${{ secrets.AWS_SECRET_ACCESS_KEY }}
        echo "aws_access_key_id = ${AWS_ACCESS_KEY_ID}" >> ${HOME}/.aws/credentials
        echo "aws_secret_access_key = ${AWS_SECRET_ACCESS_KEY}" >> ${HOME}/.aws/credentials
        ECR_PASSWORD="$(aws ecr get-login-password --region us-east-1)"
        echo $ECR_PASSWORD | sudo -s docker -H $DOCKER_URL login --username AWS --password-stdin<PHONE_NUMBER>53.dkr.ecr.us-east-1.amazonaws.com
        sudo -s docker -H $DOCKER_URL info
        echo $ECR_PASSWORD | sudo docker login --username AWS --password-stdin<PHONE_NUMBER>53.dkr.ecr.us-east-1.amazonaws.com
        sudo docker info

Using that, I can see both servers, the crazy-max one running 27.2.0 and the "standard" one running 26.1.3.
I updated my image pull section to pull the target image to both docker servers:
    - name: Get the Docker image
      run: |
        sudo -s docker -H $DOCKER_URL pull ${REGISTRY}/${REPOSITORY}:${TAG}-0
        sudo docker pull ${REGISTRY}/${REPOSITORY}:${TAG}-0

This allows trivy to run using the "standard" docker server and copa to run using the crazy-max docker server, both accessing different copies of the same image.
The copa step now looks like:
    - name: Run Copa action
      if: steps.vuln_count.outputs.vuln_count != '0'
      id: copa

      uses: project-copacetic/copa-action@main
      with:
        image: ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ env.TAG }}-0
        image-report: "report.json"
        patched-tag: "patched"
        timeout: "5m" # optional, default is 5m
        output: vex.json # optional
        format: "openvex" # optional, default is openvex
        custom-socket: $SOCKET

This appears to work, I now get to where copa times out trying to update the image:
#12 sh -c /usr/bin/microdnf update python-unversioned-command cups-libs krb5-libs libcurl-minimal orc curl-minimal python3 python3-libs python3-setuptools-wheel && /usr/bin/microdnf clean all
#12 0.243
#12 0.243 (microdnf:7): librhsm-WARNING **: 15:24:37.597: Found 0 entitlement certificates
#12 0.251
#12 0.251 (microdnf:7): librhsm-WARNING **: 15:24:37.605: Found 0 entitlement certificates
#12 0.335 Downloading metadata...
#12 0.569 Downloading metadata...
#12 1.081 Downloading metadata...
#12 1.335 Package                                                        Repository               Size
#12 1.335 Upgrading:
#12 1.335  cups-libs-1:2.3.3op2-27.el9_4.x86_64                          ubi-9-baseos-rpms    270.2 kB
#12 1.335   replacing cups-libs-1:2.3.3op2-24.el9.x86_64
#12 1.335  curl-minimal-7.76.1-29.el9_4.1.x86_64                         ubi-9-baseos-rpms    131.8 kB
#12 1.335   replacing curl-minimal-7.76.1-29.el9_4.x86_64
#12 1.335  krb5-libs-1.21.1-2.el9_4.x86_64                               ubi-9-baseos-rpms    788.3 kB
#12 1.335   replacing krb5-libs-1.21.1-1.el9.x86_64
#12 1.335  libcurl-minimal-7.76.1-29.el9_4.1.x86_64                      ubi-9-baseos-rpms    233.7 kB
#12 1.335   replacing libcurl-minimal-7.76.1-29.el9_4.x86_64
#12 1.335  orc-0.4.31-7.el9_4.x86_64                                     ubi-9-appstream-rpms 191.2 kB
#12 1.335   replacing orc-0.4.31-6.el9.x86_64
#12 1.335  python-unversioned-command-3.9.18-3.el9_4.5.noarch            ubi-9-appstream-rpms  10.3 kB
#12 1.335   replacing python-unversioned-command-3.9.18-3.el9_4.1.noarch
#12 1.335  python3-3.9.18-3.el9_4.5.x86_64                               ubi-9-baseos-rpms     30.3 kB
#12 1.335   replacing python3-3.9.18-3.el9_4.1.x86_64
#12 1.335  python3-libs-3.9.18-3.el9_4.5.x86_64                          ubi-9-baseos-rpms      8.2 MB
#12 1.335   replacing python3-libs-3.9.18-3.el9_4.1.x86_64
#12 1.335  python3-setuptools-wheel-53.0.0-12.el9_4.1.noarch             ubi-9-baseos-rpms    480.1 kB
#12 1.335    replacing python3-setuptools-wheel-53.0.0-12.el9.noarch
#12 1.335 Transaction Summary:
#12 1.335  Installing:        0 packages
#12 1.335  Reinstalling:      0 packages
#12 1.335  Upgrading:         9 packages
#12 1.335  Obsoleting:        0 packages
#12 1.335  Removing:          0 packages
#12 1.335  Downgrading:       0 packages
#12 1.335 Is this ok [y/N]: time="2024-09-05T15:29:04Z" level=error msg="patch exceeded timeout 5m0s"
Error: patch exceeded timeout 5m0s
+ echo Error patching image ***.dkr.ecr.us-east-1.amazonaws.com/ironbank/opensource/keycloak/keycloak:25.0.1-0 with copa
+ exit 1
Error patching image ***.dkr.ecr.us-east-1.amazonaws.com/ironbank/opensource/keycloak/keycloak:25.0.1-0 with copa
Error: Process completed with exit code 1.

This is https://github.com/project-copacetic/copacetic/issues/714 which has been fixed, but not yet released.  Is there any facility to run a nightly build of copa of some sort where I could test to see if it actually successfully makes it to the end of the patching, or do we need to wait for 0.7.1 release?  I have gotten past the step with a custom-built copa binary where I had fixed the missing -y in the command.  I used that in my jenkins pipeline where I ended up opening that issue and https://github.com/moby/buildkit/issues/5244 which is stalled because everyone says the problem is someone else's.  However, if the microdnf issue is fixed and copa-action works, I'll not worry about the buildkitd bug and just go this route.  :)

However<EMAIL_ADDRESS>runs and builds a local image in docker before these steps run. Trying to use the crazy-max docker server fails on the trivy step because the local image they built as part of the set up to the action doesn't exist in that docker server.

This issue seems to be related to https://github.com/project-copacetic/copa-action/issues/46 and using the  --docker-host flag within Trivy. We have also released a new version of copa with microdnf issue  resolved :)


Add contract expiry field to client

Description
Added the new field contractExpiryDate to client
Fixes #172, fixes #190
Testing
Ran the following commands:
client add n/test p/999<EMAIL_ADDRESS>a/testa c/SG tz/GMT+8 ce/1-2-20
client edit 1 ce/31-2-2020  This should give an error
client edit 1 ce/0-2-2020 This should give an error
client edit 1 ce/20-1-1 This should give an error
client edit 1 ce/20-1-10
Remarks
Not sure if we should make this contract expiry date optional? I would suggest we leave it as compulsory for now, then do further changes if we have time.

Is the testing for ContractExpiryField class supposed to be done in another PR?

Ah right I forgot lmao I'll add it in now


[Cart] Test for module Cart

Currently, module Cart doesn't have test. We should add tests to ensure the module quality.

done


java version of code

can you please upload the java version of your example code? thank you

Added Java Code to Readme


Launch clangd with nice -n 19

By default clangd consumes all cores which can make the editor drag after saving a widely-included header. Using a high niceness helps avoid this. For now, I have a trival wrapper script around clangd that just runs exec nice -n 19 clangd "$@" and point "clangd.path" to the script instead of the real clangd. But that feels like a bit of a hack and I'd hesitate to recommend that to everyone. Ideally coc-clangd would just do the right thing by default. Possibly by offering a "clangd.niceness" option that defaults to 19

cc @sam-mccall what's your thoughts on this?

you can pass -j=X to clangd to limit the amount of parallelism. clangd already performs background indexing with idle thread priority (on platforms that support it), hence it shouldn't take priority over other running threads. the rest of the CPU usage should probably be temporary, it's for updating currently open files (and diagnostics you might have on them).

In vim i usually have several hundred "open" files at any time, even though only 2 or 3 are currently visible. I'd rather not have clangd stealing CPU from my editor at any time, especially to update files that I'm not currently typing in. But I don't actually want to limit parallelism since I still want it to use any spare cycles on otherwise idle cores.
Ideally coc could tell clangd which files are visible vs just "open" but I don't think that is a part of the LSP spec. OTOH using nice solves this issue nicely without needing any cooperation from clangd. Is there any downside?


module.kube-hetzner.null_resource.kustomization (remote-exec): error: timed out waiting for the condition on deployments/system-upgrade-controller

After removing the taints from the agent nodes, it's still not working to deploy a cluster.
I already tried a fresh new project, fresh new project, and still getting problems with the kustomization.
It's getting really frustrating to have this thing "stable" working. Every change and update/release there is something that just doesn't want to work. It doesn't give me any trust to use this reliable in a production environment if things keep breaking that easy.
module.kube-hetzner.null_resource.kustomization (remote-exec): error: timed out waiting for the condition on deployments/system-upgrade-controller
╷
│ Error: remote-exec provisioner error
│
│   with module.kube-hetzner.null_resource.kustomization,
│   on .terraform/modules/kube-hetzner/init.tf line 232, in resource "null_resource" "kustomization":
│  232:   provisioner "remote-exec" {
│
│ error executing "/tmp/terraform_1920984306.sh": Process exited with status 1
╵
╷
│ Error: remote-exec provisioner error
│
│   with module.kube-hetzner.module.agents["1-0-A-CPX51-NBG1"].hcloud_server.server,
│   on .terraform/modules/kube-hetzner/modules/host/main.tf line 64, in resource "hcloud_server" "server":
│   64:   provisioner "remote-exec" {
│
│ timeout - last error: dial tcp <IP_ADDRESS>:22: connect: connection refused

locals {
  hcloud_token = "xxx"
}

module "kube-hetzner" {
  providers = {
    hcloud = hcloud
  }
  hcloud_token = local.hcloud_token

  # * For local dev, path to the git repo
  source = "kube-hetzner/kube-hetzner/hcloud"

  # version = "1.2.0"
  # ssh_port = 2222

  ssh_public_key = file("clusterkey.pub")
  ssh_private_key = file("clusterkey")
  # ssh_hcloud_key_label = "role=admin"
  # hcloud_ssh_key_id = ""
  network_region = "eu-central" # change to `us-east` if location is ash

  control_plane_nodepools = [
    {
      name        = "CP-FSN1",
      server_type = "cpx31",
      location    = "fsn1",
      labels      = [],
      taints      = [],
      count       = 1
    },
    {
      name        = "CP-NBG1",
      server_type = "cpx31",
      location    = "nbg1",
      labels      = [],
      taints      = [],
      count       = 1
    },
    {
      name        = "CP-HEL1",
      server_type = "cpx31",
      location    = "hel1",
      labels      = [],
      taints      = [],
      count       = 1
    }
  ]

  agent_nodepools = [
    {
      name        = "A-CPX51-FSN1",
      server_type = "cpx51",
      location    = "fsn1",
      labels      = [],
      taints = [],
      count       = 1
    },
        {
      name        = "A-CPX51-NBG1",
      server_type = "cpx51",
      location    = "nbg1",
      labels      = [],
      taints = [],
      count       = 1
    },
        {
      name        = "A-CPX51-HEL1",
      server_type = "cpx51",
      location    = "hel1",
      labels      = [],
      taints = [],
      count       = 1
    }
  ]

  # * LB location and type, the latter will depend on how much load you want it to handle, see https://www.hetzner.com/cloud/load-balancer
  load_balancer_type     = "lb31"
  load_balancer_location = "fsn1"

  base_domain = "cluster.xxx.xxx"

  autoscaler_nodepools = [
    {
      name        = "AS-CPX51-FSN1"
      server_type = "cpx51" # must be same or better than the control_plane server type (regarding disk size)!
      location    = "fsn1"
      min_nodes   = 0
      max_nodes   = 5
    },
    {
      name        = "AS-CPX51-NBG1"
      server_type = "cpx51" # must be same or better than the control_plane server type (regarding disk size)!
      location    = "nbg1"
      min_nodes   = 0
      max_nodes   = 5
    },
    {
      name        = "AS-CPX51-HEL1"
      server_type = "cpx51" # must be same or better than the control_plane server type (regarding disk size)!
      location    = "hel1"
      min_nodes   = 0
      max_nodes   = 5
    }
  ]

  etcd_s3_backup = {
    etcd-s3-endpoint        = "s3.eu-central-2.wasabisys.com"
    etcd-s3-access-key      = "xxx"
    etcd-s3-secret-key      = "xxx"
    etcd-s3-bucket          = "k3s-etcd-snapshots"
  }

  enable_longhorn = true
  # longhorn_fstype = "xfs"
  # longhorn_replica_count = 3

  # disable_hetzner_csi = true
  # hetzner_ccm_version = ""
  # hetzner_csi_version = ""
  # kured_version = ""

  # enable_nginx = true
  # If you want to disable the Traefik ingress controller, to use the Nginx ingress controller for instance, you can can set this to "false". Default is "true".
  # enable_traefik = false
  # enable_klipper_metal_lb = "true"
  # traefik_acme_tls = true
  # traefik_acme_email =<EMAIL_ADDRESS>  traefik_additional_options = ["--tracing=true"]
  enable_metrics_server = true
  # allow_scheduling_on_control_plane = true

  # automatically_upgrade_k3s = false
  # automatically_upgrade_os = false
  # The default is "v1.24".
  initial_k3s_channel = "v1.24"

  # The cluster name, by default "k3s"
  cluster_name = "xxx"
  use_cluster_name_in_node_name = false

  cni_plugin = "cilium"
  # disable_network_policy = true
  # placement_group_disable = true
  block_icmp_ping_in = true
  enable_cert_manager = true
  # dns_servers = []

  use_control_plane_lb = true

  enable_rancher = true
  rancher_hostname = "rancher.xxx.xxx"
  rancher_install_channel = "stable"
  # rancher_bootstrap_password = ""
  # rancher_registration_manifest_url = "https://rancher.xyz.dev/v3/import/xxxxxxxxxxxxxxxxxxYYYYYYYYYYYYYYYYYYYzzzzzzzzzzzzzzzzzzzzz.yaml"

  # extra_kustomize_parameters={}
  # create_kubeconfig = false
  # create_kustomization = false

}

provider "hcloud" {
  token = local.hcloud_token
}

terraform {
  required_version = ">= 1.3.3"
  required_providers {
    hcloud = {
      source  = "hetznercloud/hcloud"
      version = ">= 1.35.2"
    }
  }
}

output "kubeconfig" {
  value     = module.kube-hetzner.kubeconfig_file
  sensitive = true
}

@codeagencybe After all the time I spent helping you, this is what you have to say about this project?! We are a  best-effort initiative! We do this out of goodwill and most of our users are very happy.
I believe I explained to you in the past how to debug.  Please give it a try.
Here it is again:

Before anything, start by cleaning up your kube.tf of all comments, so you can see the full state clearly. And install the terraform extension in vscode or run terraform format to reformat it well.

Then:

Ssh into the failing node.

Execute the script that is failing, in your case /tmp/terraform_1920984306.sh.

Also have a look at the script with cat /tmp/terraform_1920984306.sh.

Try to understand where it's not working from the output of the execution.

If that does not give you anything, then have a look at the k3s logs, with journalctl, and see if the services are running with systemctl.

Above is the very least. Then you have to debug at the Kubernetes level, see the pods if they are all executing the way they should. If not, see the status of the node, in both cases the kubectl describe comes in very handy. And also kubectl logs for the pods. And last but not least kubectl svc for the LBs.
When you do find the issue, and it comes from us, please open another issue, but with all the details that you gathered in your debugging session, starting with a clear and well-formatted kube.tf, and information about the environment on which it executes, and where and why it fails according to your analysis. And if you want to help us even more, accompany it with a PR that fixes the issue if you know how to fix it. But signaling the issue is indeed the most important so that we know about it.

After debugging the above, if you still cannot corner the issue, try commenting out the cni_plugin option, as cilium, so that flannel is used. If that works, then help to find out what is wrong there would be greatly appreciated.
You have to understand that we do not have a testing env yet, even though one may be in the pipe. This is a highly dynamic environment with a lot of moving parts.
I do not know if you are familiar with Amazon EKS Blueprints, a terraform project like ours but for EKS by Amazon themselves. With millions of dollars, it works less well than ours in my experience. If you do not get the versions right, it breaks, and is really a trial-and-error process to make it work. So I believe that a small hobbyist project like ours is really doing a good enough job, and for free, out of goodwill.

@mysticaltech
@mysticaltech
I think you misunderstand the situation and my post.
My intention never is or was in any negative connotation or no apprecitiation towards this project. I understand and appreciate all help from you and the community just like others.
 That's what I was expressing in my post.
The frustrations that a new release is breaking my experience from the previous one. One version (1.6.3) finally got me started and was like a big achievement (at least for me). Moving to 1.6.5 felt like I got knocked down again and start all over.
Its just not a nice experience for a beginner.
Thats why I also offered that "video" experience which we discussed before. I still stand by that message and I still want to do this opportunity with you.
Your project is an amazing tool, no doubt at all, but I think it really needs better docs for beginners.
And as for most beginners, reading tons of docs is not a great start. Sometimes it's all about getting that base up and running with minimal bells and whistles in a very comprensive format, which for most beginners is a video.
A simple explainer video that shows all the basic steps to get a k3s cluster running, that's all it takes to get people triggered and move further from there.
If you can't get the basics working from the docs available, people get frustrated. Simple as that.
I know this is not like EKS or GKE that pour millions into maintaining their tools, but still it not a pleasant "beginner" experience if the basics just fail.
Not all community members are expert veterans in this stuff like you are and some others. There are many that are just starting to get their feet wet in this whole Kubernetes stuff just like my self.
I'm not running anything "special" or critical, I'm just learning like many others with all the pains and gains.
So I know troubleshooting is part of getting something running, but having that basics working all the time is so critical for any piece of software.
I'm not a terraform programmer, at least not yet. I recently signed up for a course and going to do that during christmas holidays, but the moment I have the bare minimum knowledge of Terraform, so that doesn't help met yet to understand problems in those files.
I'm not a Kubernetes expert, so understanding all the moving parts is why I'm here to learn this from this project.
So I'm not able to contribute (yet) on any of the above 2 parts. But I can do contribute based on writing documentation and giving you feedback about my beginner experience.
So far, as honest as I can be, it's been a bit frustrating because moving from version to version it feels like I'm "resetting" each time. I want to help to make that better but I don't know how yet. Except for doing a co-op with you and turn everything into a video format and slap it in your docs for beginners.
This is also my goodwill and free time I invest in your project. If I didn't believe in this, I would already given up way sooner.
But I don't want to. I was very close to my goals in v1.6.3.
So again, I'm reaching out. Let's make it better for everyone but also for beginners.

Ok, no worries, a video is most welcome. But something that is important to understand... Once a cluster is up and running, you do not need to "upgrade" the version, as the cluster itself if you leave the defaults, gets upgraded automatically, both nodes and Kubernetes.
If you think you are not running the latest and greatest if you do not upgrade the underlying Terraform project, you are mistaken. It's like using a tool that burns the windows ISO to a CD, once you install Windows, what do you care if the tool that burns the install CD gets a new version or not?! It's really exactly the same thing here. That's why always lock your module version (will update the docs to specify that).
So if you are trying to upgrade from one version of the module to the next, things have a high probability to break, as all the underlying versions change, from the CCM to Cilium, in your case, to Kubernetes or k3s. And no we cannot test it all every time a new dependency updates. But we do our best to have the basics running. And please do not consider Cilium as basics (I will update the docs to reflect that)! And today, our basics do work.
Now for advanced use cases, like yours, we try to help our best.

Last but not least, please remember that all the underlying dependencies fetch dynamically at deployment time, and we use the latest stable by default. But if the new version of rancher breaks, that is out of our control, and we expect users to help in the debugging. We simply cannot do it all.

@mysticaltech
in my test case, I wasn't upgrading an existing cluster. I just started a new one as I read in the 1.6.5 that things got improved on the autoscaler part and kustomization. Since I got the 1.6.3 one up and running just a few days ago, I didn't consider the "loss" the start over and just deploy a new one.
I know upgrading something that is running is a no-go, especially a beast like Kubernetes.
So the issue is then "confirmed" that it's coming from Cilium from some upgrade from CCM? I'm not that familiar with those components yet. But I read and understood that Cilium is the better one than Flannel default?
Also, somewhere in the docs, it states that Cilium need to be used for compatiblity with the LB? I don't see it in version 1.6.5 anymore but it was there in previous versions so that pulled me to Cilium as CNI as your docs said for one of the options it had to be Cilium.
About Rancher, I'm still using the "stable" version, there is nothing experimental or beta or anything used. My goal is to run a small production cluster with this at some point.
About the video, I will sent you an email to get in touch and schedule a meeting so we can do a 1:1 session for this on the format etc...

Here, do that please, get to the bottom of the issue, don't just assume that all is related to versions of Kube-Hetzner, it's not!
- Before anything, start by cleaning up your kube.tf of all comments, so you can see the full state clearly. And install the terraform extension in vscode or run terraform format to reformat it well.

Then:

- Ssh into the failing node.

- Execute the script that is failing, in your case /tmp/terraform_1920984306.sh.

- Also have a look at the script with cat /tmp/terraform_1920984306.sh.

- Try to understand where it's not working from the output of the execution.

- If that does not give you anything, then have a look at the k3s logs, with journalctl, and see if the services are running with systemctl.


Could you please release your codes?

Thank you for the interest in the library! We have just released the first commit of our code!


Merge tooltips to develop

Cleaning up of the tooltips code and adding the ability to create tooltips from code.
Replaces #178, which was created before the new layout.
Adds:
Tooltip prefab
Tooltip Manager prefab
Example/Test script for adding tooltips using code

Works as described in the ReadMe, but what's in the ReadMe should really be in it's own wiki page.

It has it's own wiki page, but it was never added to the sidebar before now.


[DMS-7] Initialize application logging

@CSR2017 One of the acceptance criteria says "The interface should include convenience properties IsDebugEnabled and IsInfoEnabled." I didn't see such a thing here.

@CSR2017 One of the acceptance criteria says "The interface should include convenience properties IsDebugEnabled and IsInfoEnabled." I didn't see such a thing here.

@simpat-adam I discussed with @bradbanister. The purpose is to customize the log levels according to the environment. Since, we are having different app-settings now, the development log level is always in "DEbug". The production one is customizable.

@CSR2017 One of the acceptance criteria says "The interface should include convenience properties IsDebugEnabled and IsInfoEnabled." I didn't see such a thing here.

@simpat-adam I discussed with @bradbanister. The purpose is to customize the log levels according to the environment. Since, we are having different app-settings now, the development log level is always in "DEbug". The production one is customizable.

Maybe I misunderstood. We do want to have those properties exposed.


feat: add flag to exclude directories from filtering

Currently if you apply filters to search it will ignore everything inside a directory that does not match a filter. So if you, for example. want to recursively find all files in the tree that have been modified today, it won't work. This is expect behavior of filter_entry(), see here.
This PR adds a flag to prevent applying filters to directories and only look at the files.

@dolsem I decided to try Tauri, found this repository to implement the necessary functionality. I was very upset when I found this non-intuitive behavior. I'm waiting for your correction to be added

I updated the PR renaming the flag to just dirs and removing directory entries from results when set to false. I think this makes more sense.

I'd love to get feedback on the PR, if there is interest in merging it, I can update document this feature in the README as well.

@dolsem There is a lot of interest. I am currently studying rust and tauri on my project using "Rust search" and your changes have helped me a lot in the project.
Now in my project, "rust search" is taken from your fork

@edwardgra4ev thank you, that's good to know. Hopefully there will be interest from maintainers as well, so that the PR can get merged.

Hey guys, I created this repository solely to work as a search library for Verve. I'm working on other stuff currently and don't get much time to work on my open-source projects.
I'll merge these changes. Thanks for the contribution @dolsem and sorry for the delay @edwardgra4ev .

Hey @dolsem , the builds are failing. Can you have a look?

@ParthJadhav Oh I didnt expect it to get merged so soon, I was going to update tests and docs after initial feedback. I'll update it today.

@ParthJadhav I fixed all the broken tests

@ParthJadhav any update?


[Question]: Can now work the TextVectorization method?

Description
I just used this method to creat words vector.
var text_dataset = tf.constant( "quz foo tak");
print(text_dataset);
var vectorizer = KerasApi.keras.preprocessing.TextVectorization(max_tokens: 1000, output_sequence_length: 4) ;
vectorizer.adapt(text_dataset);
print(vectorizer.Apply(tf.constant("quz" )));
The result is
tf.Tensor: shape=(), dtype=string, numpy='quz foo tak'
tf.Tensor: shape=(), dtype=string, numpy='quz'
It seems nothing hanppen. There is also no examples or test code in docs.
Please help me the right way to use this method, thanks.
I just checked the decompiled code, I found some things maybe the bugs that in CombinerPreprocessingLayer : Layer this class, the method adapt is virtual modifier. But this class inherits from the abstract class Layer. So the vectorizer.adapt(text_dataset) in my code executed the adapt method in the abstract class Layer, as a result this code vectorizer.adapt(text_dataset) didn't work or just did nothing. There is no connection between the adapt method in
TextVectorization class and ILayer class I guessed that.
I don't know. I'm not good at check the code. I had a headache. But I want to get help even just for learning code.
Alternatives
No response

Tensorflow.Keras.Text.Tokenizer tok = keras.preprocessing.text.Tokenizer(10000, filters: "!"); //创建一个实例
tok.fit_on_texts(allTextArr);//创建词典。全文编辑词典。allTextArr是全部数据数量，得用空格隔开。比如：{“您 好 啊”，“how are you”}
//-----------------
var sequencesX = tok.texts_to_sequences(oneTextArr);//一条句子进行one-hot编码
var x_train = keras.preprocessing.sequence.pad_sequences(sequencesX, maxlen: 100);//转为向量


Update discarded.json

Please add this NHD-import stuff. https://wiki.openstreetmap.org/wiki/National_Hydrography_Dataset
NHD:ComID, NHD:ReachCode and NHD:way_id have the same purpose as Tiger:tlid, NHD:Resolution is always "high", and FCode is duplicated by FType, which uses a human-readable value (NHD:FType=StreamRiver instead of NHD:FCode=46006) https://wiki.openstreetmap.org/wiki/National_Hydrography_Dataset#Attributes-to-OSM-tags
Short: All added tags are import cruft, are just in the way and provide no value to anyone.

Can you please point me to some discussion which confirms that there is consensus about the automatic discarding of these tags? At least https://wiki.openstreetmap.org/wiki/National_Hydrography_Dataset#Past_mistakes_and_NHD_fixup would indicate that there is still "use" for (some of) the NHD:FCodes:

[…] add intermittent=yes to streams with FCodes 46003 and 46007 on which the tag was left out for some reason.

See https://lists.openstreetmap.org/pipermail/tagging/2020-June/053408.html https://www.openstreetmap.org/changeset/3382975
Noone really protested about nhd:com_id but there was also no clear aupport.
I just asked again on the Slack.

nhd:fcode means "intermittent stream". On waterway=stream with intermittent=yes is a pointless duplication.
On waterway=stream without intermittent=yes - not sure is it trustworthy enough to replace with intermittent=yes
On everything else? No idea.

I just asked again on the US Slack.

https://osmus.slack.com/archives/C029HV951/p1639609335055400

There is definitely distinct lack of clear support for silent mass deletion (two people commented so far, neither supported this idea of silent mass deletion in general - it appears that @ZEE6de has not checked what relevant community prefers)

FCode is duplicated by FType, which uses a human-readable value (NHD:FType=StreamRiver instead of NHD:FCode=46006) https://wiki.openstreetmap.org/wiki/National_Hydrography_Dataset#Attributes-to-OSM-tags

This table shows that a single FType can correspond to many FCodes, so if anything, the FType can be deleted in favor of the FCode.
In a sense, the FCodes are duplicative of standard OSM tags. However, the mapping from FCodes to OSM tags isn’t straightforward and there are some nuances that got papered over in the original imports. These import-specific keys make it possible to trace the original intent and retag with more confidence. For example, nhd:fcode was the only way to understand why there were so many apparent bodies of saltwater in New Mexico and Wisconsin. salt had been added based on an FCode that has since been removed from newer versions of NHD, likely due to – ahem – upstream quality control issues, so the community felt much more confident in recommending that the salt tags be removed.

US mapper here.  I think in general, if an import tag is nonsense, duplicating other import tags, or always the same value, it's a good candidate for discarding.
If an import tag is "information about what an authoritative source (in this case, the US government) thinks a feature is", that is unique and distinct information that should be retained unless there's community agreement that there's a problem with that data that warrants its removal.


Bot Chat Python

Thanks for the report. Unfortunately, this is not enough information for us to investigate this issue.
If this continues to be a problem, would you please reopen the issue and add the information described in the troubleshooting guide?


Assess our Model transparency based on Stanford's framework

The Stanford's Center for Research in Foundational Models has released a framework to evaluate their transparency.
This is the full list of indicators.
This is an example of some of the questions:

Based on my quick assessment by would Top the ranking with a score of 92%

I've given us all scores that are either already being done, or reasonably done when we release Clay v.0 (e.g. documentation, licenses, disclosures, ...)
The scores we "failed"
mostly due to us not enforcing telemetry or tracking for downstream users. Enforcing is left to not break the license terms only:

For each distribution channel, is a monitoring mechanism for tracking model use disclosed?
Across all forms of downstream use, is the number of applications dependent on the foundation model disclosed?
Across all forms of downstream use, is the number of individuals affected by the foundation model disclosed?
Across all forms of downstream use, are statistics of model usage across geographies disclosed?

half point to these
since it's unclear we can do these within scope for Clav v0.
This mostly bc we depend on our cloud provider to send accurate numbers for energy and Carbon emitted, and I don't know yet to what degree these are informational or audited:

Is the amount of energy expended in building the model disclosed?
Is the amount of carbon emitted (associated with the energy used) in building the model disclosed?

AFAIK there are no rigorous evaluations available, hence we are creating a benchmark.

Are the models capabilities rigorously evaluated, with the results of these evaluations reported prior to or concurrent with the initial release of the model?

I don't know with whom to evaluate these. I don't think they apply:

Are the evaluations of the model's risks related to unintentional harm reproducible by external entities?
Are the evaluations of the mode's risks related to intentional harm reproducible by external entities?
Are any mechanisms for detecting content generated by this model disclosed?

Maving this to @yellowcap to prep documentation adding the needed info so that this benchmark can we done.