.net core 2.0, Ubuntu 16.04: AI doesn't collect telemetry (Live stream works fine)

Repro Steps
Environment: Ubuntu 16.04, .net core 2.0, nginx.
No requests, no traces collected by AI. If I open live sream - can see all events App send. If I run app locally - AI collects correctly. I checked AI telemetry IP adresses (https://docs.microsoft.com/en-us/azure/application-insights/app-insights-ip-addresses) by netcat - no any address blocked.
Configured once by  .UseApplicationInsights()
And uses loggerFactory.AddApplicationInsights(app.ApplicationServices);
Actual Behavior
Expected Behavior
Version Info
SDK Version : Microsoft.ApplicationInsights.AspNetCore 2.2.1
.NET Version : .net core 2.0
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) :
OS : Ubuntu 16.04
Hosting Info (IIS/Azure WebApps/ etc) :

How have you configured the ikey for the application? Is it via appsettings.json which is different for prod?
You mentioned that data is shown in live stream - what data do you see here? Do you see Requests/Request Duration etc? if yes, then data should be in other places as well - portal may have few mins delay before it can show data.
(If you can share the repro project for more investigation, that'l greatly help)

I have one appsettings.json for local/prod and ikey configured in there. Yes, I see live stream requests/request durations/traces in both local and prod, but local data are saving in the AppInsight (I can find by Search), prod data - not.
I tried to change DC zone (form Europe to USA) - no effects
Sorry, I can't share whole project, but configurations - yes.
Program.cs:
`public static void Main(string[] args)
{
// some linux network exceptions temp fix. Check in 2.1 .net core (developers should fix)
NetworkChange.NetworkAvailabilityChanged += delegate{  };
NetworkChange.NetworkAddressChanged      += delegate {};
        BuildWebHost(args).Run();
    }

    public static IWebHost BuildWebHost(string[] args)
    {
        var configuration = new ConfigurationBuilder()
                           .AddCommandLine(args)
                           .AddEnvironmentVariables()
                           .Build();

        var hostUrl = configuration["hosturl"];
        if (string.IsNullOrEmpty(hostUrl))
            hostUrl = "http://<IP_ADDRESS>:80";

        return WebHost.CreateDefaultBuilder(args)
                      .UseStartup<Startup>()
                      .UseKestrel(o => { })
                      .UseUrls(hostUrl)
                      .UseApplicationInsights()
                      .Build();
    }`

Startup.cs
`namespace UpDownApi
{
using System;
using System.Collections.Generic;
using System.Threading;
using Microsoft.ApplicationInsights;
using Microsoft.ApplicationInsights.DataContracts;
using Microsoft.ApplicationInsights.Extensibility;
using Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Http.Features;
using Microsoft.AspNetCore.Mvc.Filters;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.IdentityModel.Tokens;
using Newtonsoft.Json;
using Newtonsoft.Json.Serialization;
using Swashbuckle.AspNetCore.Swagger;
using Swashbuckle.AspNetCore.SwaggerGen;
x
public class GlobalExceptionFilter : Microsoft.AspNetCore.Mvc.Filters.IExceptionFilter
{
    public void OnException(ExceptionContext context)
    {
        var telemetry = new TelemetryClient(
        );

        telemetry.TrackException(context.Exception);
    }
}

public class Startup
{
    public Startup(IConfiguration configuration)
    {
        Configuration = configuration;
    }

    public                  IConfiguration      Configuration      { get; }
    public                  IHostingEnvironment HostingEnvironment { get; set; }
    private static readonly object              _sync = new object();

    public void ConfigureServices(IServiceCollection services)
    {
        services.AddCors();

        services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
                .AddJwtBearer(options =>
                 {
                     options.RequireHttpsMetadata = HostingEnvironment.IsProduction();
                     options.TokenValidationParameters = new TokenValidationParameters
                     {
                         ValidateIssuer = false,
                         ValidIssuer    = AuthOptions.ISSUER,

                         ValidateAudience         = false,
                         ValidAudience            = AuthOptions.AUDIENCE,
                         ValidateLifetime         = true,
                         IssuerSigningKey         = AuthOptions.GetSymmetricSecurityKey(),
                         ValidateIssuerSigningKey = true,
                     };
                 });

        services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>();
        services.AddLogging();

        services.AddMvc()
                .AddMvcOptions(options => { options.Filters.Add(new GlobalExceptionFilter()); })
                .AddJsonOptions(x =>
                 {
                     x.SerializerSettings.ContractResolver = new DefaultContractResolver
                     {
                         NamingStrategy = new SnakeCaseNamingStrategy()
                     };
                 });

        services.AddDbContext<EFContext>();

        services.AddSwaggerGen(c =>
        {

            c.SwaggerDoc("v1", new Info {Title = "UpDown API", Version = "v1"});
        });
    }

    public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
    {
        HostingEnvironment = env;
        if (env.IsDevelopment()) app.UseDeveloperExceptionPage();

        loggerFactory.AddApplicationInsights(app.ApplicationServices);

        app.UseCors(builder => builder
                              .AllowAnyOrigin()
                              .AllowAnyMethod()
                              .AllowAnyHeader()
                              .AllowCredentials());

        app.Use(async (context, next) =>
        {
            var telemery = new TelemetryClient() { };
            telemery.TrackEvent("Request: " + context.Request.Path.Value);

            await next.Invoke();
        });

        app.UseSwagger(options => { });
        app.UseSwaggerUI(c => { c.SwaggerEndpoint("/swagger/v1/swagger.json", "UpDown API V1"); });

        app.UseAuthentication();
        app.UseMvc();
    }
}

}`
appsettings.json:
`{
"Logging": {
"IncludeScopes": false,
"Debug": {
"LogLevel": {
"Default": "Warning"
}
},
"Console": {
"LogLevel": {
"Default": "Warning"
}
}
},
"ConnectionStrings": {
},
"ApplicationInsights": {
"InstrumentationKey": "844e5174-49ce-44ec-848f-xxxxxxxxx"
}
}`
P.S. There is little chance that Microsoft IP addresses are blocked (I'm from Russia, and here problems with goverment and internet), but I don't know how I can exactly make sure that it is

If you able to see LiveMetrics data for requests etc, then i dont think IP restrictions can be the cause here.
Can you try to create a simple HelloWorld kindof application, configure AI for it, and deploy and test if you can see data?
Also please send me your full ikey to<EMAIL_ADDRESS>- I can check if our backend is indeed receicing your data at all..

Received your email with ikey. Will check this and get back in a day

Thank you. Sorry, I can't find time to push empty project and test :(. I
will asap
On Tue, May 8, 2018 at 6:26 PM, Cijo Thomas<EMAIL_ADDRESS>wrote:

Received your email with ikey. Will check this and get back in a day
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/669#issuecomment-387441791,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AETwPiE31Y31EZTh3-qAyIGH6NMKnjXnks5twbkKgaJpZM4Tw7Fr
.

I've tested with new project, and: AI.AspNetCore from  2.2.0 (up to 2.3.0-beta2) doesn't work. Works correctly - 2.1.1.

Yes 2.1.1 did not have live streams.
From 2.1.1 to 2.2.0 (2.3), the default channel is changed to be ServerTelemetryChannel - it had a known bug (https://github.com/Microsoft/ApplicationInsights-dotnet/issues/654) which caused issues in Linux, but no known issues exist as of now.
Would you mind trying to use InMemoryChannel, and see if the issue exists with that channel as well?
You can change channel like this:
https://github.com/Microsoft/ApplicationInsights-aspnetcore/wiki/Custom-Configuration#configuring-telemetry-channel

Closing due to no activity. Please re-open if there are followups required.


Fixed #19210 -- Handling of leap years in django.utils.timesince

django.utils.timesince used to ignore leap years which lead to big
inaccuracies as soon as you used it on big time spans. This is the
most simple fix for this bug, as explained in the ticket.

merged in 6700c909358d2ff9ff96f28dbc549906d8d32206, thanks!


Please provide either 'type' or 'entity' attribute in Payment.id

Describe the bug
After updating to mikro-orm 4.0.0, I keep getting the following runtime error:
Please provide either 'type' or 'entity' attribute in Payment.id
Whenever I give that field a type, it will go onto the next field. It seems like this happens to every field of every object I have.
I'm not sure if this is a breaking change on 4.0.0 or an actual bug, but I cannot find any documentation on what to do to fix this issue.
Stack trace
    Please provide either 'type' or 'entity' attribute in Payment.id

      113 |     }
      114 |
    > 115 |     const orm = await MikroORM.init(config);
          |                 ^
      116 |
      117 |     DI.orm = orm;
      118 |     DI.em = DI.orm.em;

      at ReflectMetadataProvider.initPropertyType (node_modules/@mikro-orm/core/metadata/ReflectMetadataProvider.js:14:19)
      at node_modules/@mikro-orm/core/metadata/ReflectMetadataProvider.js:9:54
      at ReflectMetadataProvider.initProperties (node_modules/@mikro-orm/core/metadata/MetadataProvider.js:26:23)
      at ReflectMetadataProvider.loadEntityMetadata (node_modules/@mikro-orm/core/metadata/ReflectMetadataProvider.js:9:20)
      at MetadataDiscovery.discoverEntity (node_modules/@mikro-orm/core/metadata/MetadataDiscovery.js:165:41)
      at MetadataDiscovery.discoverReferences (node_modules/@mikro-orm/core/metadata/MetadataDiscovery.js:116:24)
      at MetadataDiscovery.findEntities (node_modules/@mikro-orm/core/metadata/MetadataDiscovery.js:67:20)
      at MetadataDiscovery.discover (node_modules/@mikro-orm/core/metadata/MetadataDiscovery.js:33:9)
      at Function.init (node_modules/@mikro-orm/core/MikroORM.js:40:24)
      at Object.configure (src/database.ts:115:14)
      at Object.<anonymous> (src/api/users.test.ts:90:2)

To Reproduce
See the build logs at https://github.com/pixelbar/pixelbank/pull/37/checks?check_run_id=1100262152
The source code is at:

https://github.com/pixelbar/pixelbank/blob/master/server/src/database.ts#L83
https://github.com/pixelbar/pixelbank/blob/master/server/src/models/payment.ts

Versions

Dependency
Version

node
v14.9.0

typescript
4.0.2, or whatever is installed on github actions

mikro-orm
4.0.0 through 4.0.3

your-driver
sqlite

Sounds like you are missing the reflect metadata import, but that will help only with scalars, not relations.
Or use ts-morph, default metadata provider changed in v4.

That was indeed what was wrong.
For anyone running into this issue, this is the relevant chapter in the documentation: https://mikro-orm.io/docs/installation/#entity-discovery-in-typescript
You need to install @mikro-orm/reflection and add this to your init:
import { TsMorphMetadataProvider } from '@mikro-orm/reflection';

const orm = await MikroORM.init({
  metadataProvider: TsMorphMetadataProvider,
  // ...
});

But I want to use ReflectMetadataProvider.
Though, it throws no error with TsMorphMetadataProvider .
Of course, I didn't forget to import reflect-metadata.


Bump eth-contract-metadata for the maker migration

Codecov Report

Merging #181 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop   #181   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files           23     23
  Lines         1515   1515
  Branches       210    210
======================================
  Hits          1515   1515

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a327ec...82dd775. Read the comment docs.


problem with re-include, excluded path

Because I still working on glob-fs idea :D lol
Actually it works on 80% of the common usage of gulp/glob-stream, fails only on complex fixtures, or no logical tests (look at you glob-stream, nah.. it have very very weird tests).
Btw, talking about that, can you answer me why is needed to ignore negate glob if it is first in given patterns?!
No logic for me... nor of matching libs (micromatch/minimatch/node-glob) have this behaving.. lol.
On topic
var micromatch = require('micromatch')
var multimatch = require('multimatch')

var paths = [
  'foo/',
  'foo/bar.js',
  'foo/bar.md',
  'foo/bar.txt',
  'foo/bar.hbs',
  'foo/bar.json',
  'foo/bar.coffee',
  'foo/bar/',
  'foo/bar/bar.js',
  'foo/bar/bar.md',
  'foo/bar/bar.txt',
  'foo/bar/bar.hbs',
  'foo/bar/bar.json',
  'foo/bar/bar.coffee',
];

var patterns = [
  'foo/**',
  '!foo/',
  '!foo/bar/',
  '!foo/bar/*.{j*,txt,hbs}',
  'foo/bar/*.json',
];

var res = micromatch(paths, patterns);

console.log(res, res.length);

micromatch, note there foo/bar/bar.json missing
[ 'foo/bar.js',
  'foo/bar.md',
  'foo/bar.txt',
  'foo/bar.hbs',
  'foo/bar.json',
  'foo/bar.coffee',
  'foo/bar/bar.md',
  'foo/bar/bar.coffee' ] 8

multimatch, all is okey
[ 'foo/bar.js',
  'foo/bar.md',
  'foo/bar.txt',
  'foo/bar.hbs',
  'foo/bar.json',
  'foo/bar.coffee',
  'foo/bar/bar.md',
  'foo/bar/bar.coffee',
  'foo/bar/bar.json' ] 9

or say we have this one
var patterns = [
  'foo/**',               // include all filepaths (files and folders)
  '!foo/',                // we dont want `foo/` in the list
  '!foo/bar/',            // and also dont want `foo/bar/`
  '!foo/bar/*',           // we dont want all files
  'foo/bar/*.j*',         // except that are .js and .json
];

note there foo/bar/bar.json missing

This is exactly what I was talking about with "re-inclusion" patterns. You said: https://github.com/jonschlinkert/glob-fs/issues/1#issuecomment-68498242.
Now you know what I mean? This isn't a bug, I did the PR to multimatch that allows it to re-include patterns like that, I can do the same here. IMO, this is the expected result since you are removing it from the set. But maybe it makes more sense to re-include.

talking about that, can you answer me why is needed to ignore negate glob if it is first in given patterns?!

I have no idea, I agree. it makes no sense

Initially I was thinking maybe we should change to what multimatch does, but I'm not sure that's correct.  You can get the exact result you want with foo/bar/*.j*, right? Why exclude everything first, then include that?

also I'm almost ready to push up a first pass at glob-fs. I focused 100% on the correctness of resolving paths, so it's all sync atm. It will be easy to do async, promises, streams whatever once the basic path logic is down

Hmm, right, clear. Yea, maybe make more sense to save this behaving and allow users to un-negate patterns in options, like not-documented ignore option.

You can get the exact result you want with foo/bar/.j, right?

Yep, but testing, complexity, possible use cases and etc.

also I'm almost ready to push up a first pass at glob-fs.

Great! From you sync, from me streams, haha. Almost pass all gulp/glob-stream tests. lol
Benchmarks shows x22,000 faster than glob-stream and its normal. :) glob-stream is slowest thing that I ever seen, srsly. And tools from this chain glob-stream -> vinyl-fs -> gulp, verb, template, assemble are very slow natively, because the glob-stream and glob + minimatch.
But yea, you know that - for this reason we work on micromatch/glob-fs :)

actually, I think the reason they did that is because they didn't have the correct logic to do inclusion/exclusion patterns, like what was implemented in multimatch and globby

mm, yea and for this reason we'll never pass 90-100% of gulp/glob-stream/vinyl-fs tests and they are very very weird and low quality. They not deserves 100%-coverage-badge LOL

@tunnckoCore was this resolved?

I'll look after 10-20mins

no prob, I don't know how long I'll last anyway, trying to keep my eyes open!

@jonschlinkert okey, we can close and wait your push.

k thx


Keep duplicates in a ManyAsync result?

The background and foreground colors of a guild emblem rely on index order in which they are applied on the guild emblem layers.
When I combine them into one list (keeping the order) for a single ManyAsync request ManyAsync will remove duplicates from the result.
Could this behaviour be changed so that ManyAsync will just keep duplicates in the result (add as many of one request result as was in the request parameter in order)? In the meantime I will have to make separate requests.

While Gw2Sharp does filter out duplicates in the request, the API itself also filters the duplicates in the results, even if you were to request multiple of the same id (see https://api.guildwars2.com/v2/colors?ids=1,2,3,4,4,3,2,1)
I'm not going to add any redundant logic to support this. You can easily apply your own logic to get all the colors that you want, and get the correct ones out of the list.

As I said I already did. Good to know though. :)


Modded Suits not showing up

Hello, my customs suits were working a while back but it stopped working & no suits are showing up in game.
Is this mod in conflict with any of my other mods?

I would love to know what causes the rack being empty myself, as it's a common issue I experience, but doesn't have anything to do with the API. Often times I can fix this by quitting to main menu and restarting that save.
Regarding the exceptions in console, do you have Too Many Emotes installed? That might indicate a new bug that is unrelated to the modded suits being missing.

I would love to know what causes the rack being empty myself, as it's a common issue I experience, but doesn't have anything to do with the API. Often times I can fix this by quitting to main menu and restarting that save.
Regarding the exceptions in console, do you have Too Many Emotes installed? That might indicate a new bug that is unrelated to the modded suits being missing.

I've traced the issue back to the "Too many emote" mod, disabling it makes the suits visible again

Good news, it's working again

I am skeptical that this is related to the issue. I don't install TooManyEmotes when doing my testing, but I get this issue frequently.
Regardless, I'll close the issue, as it seems to be resolved, and is unrelated to my API to begin with.


Cannot more than three connections to a block

Describe the bug
When adding a fourth connection to a block, the third switch from previous to other block
To Reproduce
Steps to reproduce the behavior:

Pick a block with 3 connections
Select a block not connected to the 3-connections one
Drag and drop a link from block to 3-connections block

Expected behavior
Add more than 3 connections
Screenshots

Desktop (please complete the following information):

OS: Debian GNU/Linux 12 (bookworm)
Browser Firefox
Version 0.9.43

Additional context
None

Seems that droping inside the box actually allow the fourth connection

@KyllianBeguin Yeah, the connecting line from a block should be placed on the block itself, rather than the port that appears when hovering over a block in the dependency graph. But this is still helpful to know so we can improve the UX for the dep graph.


Add graphQL example

App:

[x] I've read and followed the contributing guide on how to create great pull requests.
[x] I've updated the relevant documentation for any new or updated feature
[x] I've linked relevant GitHub issue with "Closes #"
[x] I've added a visual demonstration under the form of a screenshot or video

We should just call the example folder graphql I think, as it seems that the pattern is to use all lowercase letters and spacing with hyphens when necessary (as in npm-stats)

Looks good, just really minor comments/suggestions! Also, based on the screenshot, we could format the followers data so that we show only the totalCount in that column? Unless there's more data we might want to show sometimes.

Couldn't make this work, do I need to change the response array?

We should just call the example folder graphql I think, as it seems that the pattern is to use all lowercase letters and spacing with hyphens when necessary (as in npm-stats)

Did graphQL -> graphql. This change is visible in my local but isn't detected by GitHub desktop :/ https://github.com/desktop/desktop/issues/2672#issuecomment-1681471505

Did graphQL -> graphql. This change is visible in my local but isn't detected by GitHub desktop :/ desktop/desktop#2672 (comment)

I just added a commit with the change.
It's an issue on Mac/Linux with case sensitive file names it seems.
I ran git config core.ignorecase true in the terminal before renaming the folder, and then ran git config --unset core.ignoreCase to put it back to normal.

I just added a commit with the change.
It's an issue on Mac/Linux with case sensitive file names it seems.
I used an intermediary commit with graphqltemp as the folder name to make it work.

Thanks for this!


Group does not do anything in entity card

I added the group: true to a shutter row
I cannot see any difference. True or false there is still a frame around

  - type: custom:shutter-row
    entity: cover.cloud
    group: true
    invert_position_label: true
    state_color: true

Please check if you are on 0.3.0 or higher.

Call HA on desktop PC in Chrome
Press F12 and click on Console
There should be a yellow log entry with the loaded shutter row version.

This is really odd
I had already checked that the installed version inside HACS was 0.3.2
And then I went to the actual JS files and checked that the version was 0.3.2
But your posting using F12 and console revealed that the browser had a much older version.
I have done control F5 multiple times. And I have had the same symptom on multiple computers. They cache this JS file in a way that does not get refreshed.
What helped was to put http://192.168.1.X:8123/hacsfiles/lovelace-shutter-row/shutter-row.js?hacstag=524783308020 in the browser URL to force it to cache update.  I wonder how many old JS files people are fighting with and reporting bogus error reports from. You can normally trust a control F5 to refresh all JS used in a given browser URL
Once I did this it sort of works. I have no border
But the text is poorly alligned with the other entities and my icon is not shown (it is not a default shutter icon)

Can you post the attribute content from the developer tools?

I do not understand that question.

2 minutes later. Oh now I know what you mean. For the entity I show sure
It is an MQTT device called a Cloud. A small long narrow curtain that I can move so it covers the sun. So I call it the cloud
current_position: 100
icon: mdi:cloud
friendly_name: Cloud
supported_features: 15

Go to this url: https://homeassistant.local:8123/developer-tools/state
Search for your cover entity and copy the content from the 'Attributes' column and post it here.

Yes. Got it above. I was in the F12 content mode and could not find any attributes. And then I got the "DUH! - me idiot" moment a minute after I posted

Never mind this is another bug that happens on custom entity icon...
Will fix that this week!

Thanks for following up.

Fixed with v0.3.3.


[vcpkg_fixup_cmake_targets] Fix up OSX system development path

In OSX, some cmake configuration files contain the absolute path of the system development kits.
Fix this.
Fixes #16259.

@davidebeatrici  Can you please test this PR?
Thanks.

Sorry for the delay.
The issue was fixed for abslTargets.cmake, but not for unofficial-angle-config.cmake:
set_target_properties(unofficial::angle::angle_gpu_info_util PROPERTIES
  INTERFACE_LINK_LIBRARIES "/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/IOKit.framework;/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreFoundation.framework;/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreGraphics.framework;\$<LINK_ONLY:unofficial::angle::angle_common>"
)

@davidebeatrici Should be good now.

Need wait for #16837 merge first.

I confirm it's fixed.

/azp run

paraview:x64-osx:
CMake Error in Remoting/Views/CMakeLists.txt:
  Imported target "VTK::opengl" includes non-existent path

    "-framework OpenGL"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Depends on https://github.com/microsoft/vcpkg/pull/17341.

CMake Error at scripts/cmake/vcpkg_configure_cmake.cmake:72 (message):
  The tensorpipe port already depends on vcpkg-cmake; using both vcpkg-cmake
  and vcpkg_configure_cmake in the same port is unsupported.
Call Stack (most recent call first):
  scripts/cmake/vcpkg_internal_get_cmake_vars.cmake:49 (vcpkg_configure_cmake)
  /Users/vagrant/Data/installed/x64-osx/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake:245 (vcpkg_internal_get_cmake_vars)
  ports/tensorpipe/portfile.cmake:40 (vcpkg_cmake_config_fixup)
  scripts/ports.cmake:139 (include)

Should fix this first.

@strega-nil-ms Which rollup will contains this PR's changes?

@JackBoosY oops, it's gotta be marked or I'll miss; marking now.

Closed for rollup #19469.


Find anthyinput via pkg-config

See also https://github.com/mesonbuild/meson/issues/7746

thanks!


Add AuthN/Z to OHDSI Hades

As architect I would like users to be able to login via entra ID

@vvcb per our discussion previously I've investigated the issue and i don't think we can put this into the hades image without upgrading to a pro version of rstudio  which includes authentication/authorization. We talked about the potential of making a jupyter notebook with this and using jupyters security instead. I'll create a new item for this.

Linking to lsc-sde/lsc-sde#47


JIRA fixes

Some jira fixes for unreferences issues and:

#2460
Most of #2458 I guess, but this will be left as an exercise to @dayal18 ;-)
Eventually fixes issue where jira webhook would not work anymore (bc of recent github integration, which might have stepped on its toes).

FYI @mestrade: https://github.com/DefectDojo/django-DefectDojo/pull/2462/commits/f844036295a070151dd1157fbe42dd8dff0df1c0
Unsure how the github webhook (probably not used by anyone right now) is used further, but I think it may have broken the JIRA webhook. So, just FYIm the url's changed.

Thanks @madchap I'll try to change it locally on my machine and check this.

@madchap 2 issues:

When Product level - JIRA is enabled -- Using "Bulk Edit" is creating JIRA ticket, but the JIRA Age and JIRA Change is blank.

The Webhook didn't work.. :(  JIRA Webhook is critical functionality for our process, any other suggestions, please.

Rest all looks good, the bug icon, + other issues which I mentioned, those are fixed. only the above 2 are still open.

ok another issue.. I'm started getting those JIRA alerts again. something it didn't like..

I have Product level JIRA push + Push all Notes..

and it doesn't stop.. as I have only 1 note the speed is less.. unlike last time.. where I have 10 notes.. and 10 alerts were bumping every 10 sec

The alert thing is fixed by #2402 in 1.6.1. The alerts are there for a reason, to give the user feedback if something wrong. So they should stay as not every user has access to the server log files.
The reason there are so many alert now is because the JIRA integration is more less completely broken by the push all issues PR in 1.6.0. So if we fix thare, the alerts will be useful again.

The alert thing is fixed by #2402 in 1.6.1.

Will be fixed, when out ;-)

The alert thing is fixed by #2402 in 1.6.1. The alerts are there for a reason, to give the user feedback if something wrong. So they should stay as not every user has access to the server log files.
The reason there are so many alert now is because the JIRA integration is more less completely broken by the push all issues PR in 1.6.0. So if we fix thare, the alerts will be useful again.

Ant idea if this also fixes the JIRA WebHooks? which is not working now?

Any idea if this also fixes the JIRA WebHooks? which is not working now?

Best to read the PR description or the few lines changed to know. It is likely that a PR fixing the webhook will somehow mention it :-)


Threshold calculation

We need to handle thresholds one of three ways:

If without-project condition, calculate default threshold
If levee present, calculate default threshold
If with-project condition and no levee present, use without-project condition threshold

I think that (3) means that we'll need a way to force the user to decide if with- or without-project condition, and then act upon their logic route

Prevents user from getting critical information : YES
Saves to disk in a way that would be hard to support going forward if we release as is: MAYBE
Is difficult enough to use that it would be embarrassing to release: YES

we want a rigid workflow but we don't want to link scenarios. we might create a thresholds report to help the user enter the correct data

as part of this issue, lets address threshold types. interior stage does not make sense - where inside the floodplain should this be? lets drop this until we have a good use case. damage could make sense, we'd collect the same way as stage for assurance. however, we have no use cases or demand for this information, so I don't see a reason to finish out that capability at this time.

the user should only be able to add exterior stage threshold type so we should remove the option to select threshold types

we always have a system response in the model, so we need a way to identify whether the system response is a true system response or just the default so that we can assign the correct threshold type

https://github.com/HydrologicEngineeringCenter/HEC-FDA/blob/93794889c17f484de2ec5dcfaa5d1e5c9523fc7b/HEC.FDA.ViewModel/GeoTech/LateralStructureElement.cs#L80

40hrs

Notes from meeting with Richard:
Right click a scenario and menu item "View Thresholds...".
in the Scenario UI:
new checkbox  "Scenario reflects without project conditions"(default to true), default stage (textbox), thresholds
the text box is only enabled in the one condition(3)
if unchecked and no levee then default stage becomes enabled and is required to compute.

@rnugent3 I assume the thresholds table is not editable, it is just for the user to view?

Menu item added and UI:

This work was completed in branch scenario_threshold_820 as well as in branch scenario_workflow_818

I added live updates. So if you modify the thresholds in the IAS editor while the thresholds table is still open, it will automatically update to the new info.

This is terrific.
Is there a way that you can detect whether there is no default threshold calculated/identified, and if so, let the user know?
I think it is important that this is communicated.


Update README.md

Add information about enabling userChrome on recent versions of Firefox (copied from the ShadowFox wiki.)

I didn't have to do this on Firefox 92 on macOS


Handle small tx hash on localhost

When deploying to localhost, the transaction 'hash' is small (0x4) causing the regex to skip the value leading to an unpack error

thank you!


Different Data are display is Android and IOS

I am running both application in different device, but the problem is that data are display with missing parameter in IOS like Image and Name are not display. But both are display in Android.
Any one help me?
In Android look like this :

In IOS like this :

from above Image Profile parameter is missing in IOS

I also encountered the same problem. How can I solve it?

I also encountered the same problem. How can I solve it?


Add test for MethodNode::isDeclaration()

Type: bugfix
Issue: n/a
Breaking change: no (at least, not yet)
IIUC,  MethodNode::isDeclaration() is not working as expected, because methods overriding or implementing parent classes or interfaces are being interpreted as declarations.
The added test tries to expose the described issue.

Do you know if there is any init process or something else I might be missing?
I suspect that the related ASTs for the ClassNode containing the MethodNode (parent classes, interfaces) are not being built correctly, but I don't know if there is an explicit instruction or configuration for that.

i would try targeting 3.x instead, things are simpler, cleaner and you get full phpstan checks on your changes.

i would try targeting 3.x instead, things are simpler, cleaner and you get full phpstan checks on your changes.

I'll try to create a new PR against 3.x, thanks for pointing :+1:
Although I think this PR should be kept for 2.x, as the described problem is affecting this version.


Tell me

Hi, I'm looking at your code and would like to ask what it means to you

typedef struct {
union {
struct {
union {
uint8_t r;
uint8_t red;
};
        union {
            uint8_t g;
            uint8_t green;
        };

        union {
            uint8_t b;
            uint8_t blue;
        };
    };

    uint8_t raw[3];    // What does it mean?
    uint32_t num;    // What does it mean?
};

} CRGB;

@mironov1338 hi. Actually I copied the type from the lib I forked mine from: https://github.com/8-DK/ESP32_SPI_WS2812_idf
I can explain to you, what it means. It's union, so it's just another handy way to address the fields of the struct. You can call then my name of colors, .red or .r, or you can call them by index, of you want, for example, for some reason iterate over them in an array. uint32_t num could be handy for "serialization", when you want so save the pixel as one integer value. Unions in C give you a way to access bytes of data in a different way. It has no overhead, doesn't increase size of CRGB struct and it's there because I thought it might be handy sometimes in the feature.


Rough draft for Getting started guide

I'm proposing a starting point for the history part.
Shall we link it to the survivejs article from here?
After this I feel we need to link to how-to/install and concepts/ folder. Not sure how to do this without it appearing sparse. What do you  suggest @bebraw ?
If you are fine with the approach I'll polish this to link all the pieces mentioned.

It's maybe easier if we define context for this article as that will shape the content. I would suggest the following constraints:

The reader doesn't know what a bundler is -> explain concept and why bundlers are needed.
The reader wants to get webpack up and running -> show minimal setup + link to other articles for more info.
Expect the reader has 5-15 mins of time -> basic ideas only, cut through essentials so that we "upgrade" the reader and encourage the person to check out more articles.

We can link to other resources at the end. If I remember right, the idea was to have some sort of official comparison at the site with numbers and so on.

Okay, Now my understanding is to have

Why webpack, with more emphasis on bundlers and logic.
What constitutes minimum setup for webpack? Would steps for

have to install webpack
create an entry.js
connect it to a dependency file
run webpack from cli
be enough for this part?

About entry, output, existence of loaders, existence of plugins?
My approach would be to add a webpack.config.js file,

Add entry and output file config as first step
Add babel loader as second step
Add uglifyjsplugin as third step

Yeah, that's good. When discussing some specific concept, like a loader, you should link to the concept specific article.

Hey @bebraw , Rollup has this awesome interactive getting started on its homepage. Can we also do something like that?

@pksjce You could comment on that at #32.

Done. Also, I simplified module bundler definitions. What do you think?

Much like the intro, I also think the Getting Started page should be very simple and light on wording. As an example, when I first started using gulpjs, I was able to follow their getting started guide and actually get started in a couple minutes

Yeah, the gulp getting started guide is really clear. This piece is mostly
intended to be something of an intro to webpack and clear the confusion
around module bundlers. I feel gulpjs comes off the back of Gruntjs, so it
doesnt need much explanation of things. If you checkout Gruntjs docs
http://gruntjs.com/, they have an wordy explanation of what it does.
In my experience, people are not using webpack because they dont see its
difference from a task runner. Also, I was just inspired from how the rollupjs
doc http://rollupjs.org clearly showed what it does for my javascript
files.
Regards,
Pavithra.K
On Fri, Oct 7, 2016 at 6:46 PM, Chris Deacy<EMAIL_ADDRESS>wrote:

Much like the intro, I also think the Getting Started page should be very
simple and light on wording. As an example, when I first started using
gulpjs, I was able to follow their getting started
https://github.com/gulpjs/gulp/blob/master/docs/getting-started.md
guide and actually get started in a couple minutes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/webpack/webpack.js.org/pull/212#issuecomment-252249127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZd9NqCXcL7yeMLqOEr3VgL9Rozemzfks5qxkYzgaJpZM4KNrFz
.


Can let be redeclared with a var etc.

There are some tests that specifically check var's shadowing let (make sure var variables can shadow let variables)
but is that right? testing in chrome in strict mode, it seems redeclaring a let or a const with a let/const/var throws an error and reclaring a var with a let or const also throws an error - that seems to make sense (I have no idea what would happen otherwise?)
so is it strict mode only? is it a bug in chrome? is it a bad jshint test?
heres what I wrote before I realised I shouldn't add it to an existing pr...
exports.testLetRedeclaration = function (test) {

  // consts cannot be redeclared, but they can shadow
  var src = [
    "let a = 1;",
    "let a = 2;",
    "if (a) {",
    "  let a = 3;",
    "}",
    "for(let a in a) {",
    "  let a = 4;",
    "}"
  ];

  TestRun(test)
      .addError(2, "'a' has already been declared.")
      .test(src, {
        esnext: true
      });

  test.done();
};

exports.testLetAndConstRedeclarationOfVar = function (test) {

  // consts cannot be redeclared, but they can shadow
  var src = [
    "var a = 1;",
    "let a = 2;",
    "if (a) {",
    "  let a = 3;",
    "}",
    "var b = 1;",
    "const b = 2;",
    "if (b) {",
    "  const b = 3;",
    "}"
  ];

  TestRun(test)
      .addError(2, "'a' has already been declared.")
      .addError(7, "'b' has already been declared.")
      .test(src, {
        esnext: true
      });

  test.done();
};

then this has to change
            // only look in the latest scope because we can shadow
            if (funct["(blockscope)"].current.labeltype(t.id) === "const") {
              warning("E011", null, t.id);
            }

(and the equivalent for the var statement) to use .has, not just const.
As well as detecting in the block statement that there isn't an existing var.

@lukeapage see 13.1.1, <IP_ADDRESS>, 13.14.1, and 14.1.2 --- there are a lot of early errors for a name of LexicallyDeclaredNames appearing in VarDeclaredNames or BoundNames of formal parameters. Engines are not getting this 100% right all the time, but yeah the spec is pretty clear about this I think

Check let and const here: https://github.com/tc39/test262/tree/master/test/language/statements I think you may be right (I'm mobile, so I can't really read through atm)

So at the moment we have as this error message - "const 'a' has already been declared." - when I broaden it to apply to vars, functions shadowing blockscope and redeclaring let and const within the same scope, should it stay under E011 and what should the error message be?
I guess it should stay under E011 since it is a syntax error unlike shadowing which isn't.
I guess also it should stay the same but make the first part of the message say "let" or "const" depending on what it is you are re-declaring?


Rename script causes syntax errors in package.json?

Ok, that's a bug. Shouldn't modify detox items in package.json.
Thanks!

Fixed with #37174f5


Yet more conversions to the new api

And remove more parts of the old api.
In particular, remove the file read/write and serialisation functions, so we can be
sure that we cannot accidentally mix up the new and old formats.

bors r+


Adjust App to Reflect Reduxify Changes

These changes were made based on a recent update to the Zooniverse reduxify starter repo. It could easily be that I missed or overlooked something in the process of this addition. Also, some of the app structure changed a bit based on that commit, so I'm open to changing it back should we decide to do so.

Just saw some additions were also made to the reduxify repo concerning tree-shaking, so I can make those same changes in another commit here.

Thanks @wgranger ! I'm still reviewing these changes, and here are my current notes:

Running on a dev environment seems to work great; I have very little concern so I'm just going to cross-reference the changes to ensure nothing hidden was missed.
However, I have issues running npm run build - I'm still investigating what's happening here and trying to isolate whether it's just my machine.

Updates before the end of the UK day.

PR Review

This PR folds in the latest updates from our baseline, zooniverse/zoo-reduxify.
Of note:

Folder structure has been updated, particularly with the introduction of ducks [ref1] [ref2] to better organise our Redux logic.
The webpack dashboard has been enabled.
A new way of setting up tests (see About.jsx and About.spec.jsx) has been established.

The following commands have tested OK: npm start (webpage loads correctly at localhost:3000), npm run build (files are packaged in the /dist folder with no errors on compile), and npm test (all tests - mostly those from About.jsx - pass correctly)

There's a minor styling issue with the Login/Logout button, but that's separate from the primary code migration this PR is responsible for.
Status
LGTM, merging.

Just an update on the earlier problems with npm run build that I reported - looks like the issue was with my machine setup, so it was solved by dumping my local stuff and rebuilding from scratch. 👌


LV2 exporter should escape special character

Hi, falkTX!
Some presets names may have special characters like quotation mark ("). However, currently LV2 exporter does not escape them, so hosts like REAPER will fail to recognize LV2 plugins.
Here's the line which should be improved:
https://github.com/DISTRHO/DPF/blob/22413340a6d8ef2ffbf38ce841fb44c448a1a84a/distrho/src/DistrhoPluginLV2export.cpp#L326

Fixed in b238d8dc7e5d5a38c54b7a941a71d0fb3cb4be3d thanks!

My pleasure!


(fix) gate_io native token as fee

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
https://snapshot.org/#/hbot-prp.eth/proposal/QmR21ZyXJ7a4VqUC1SX3ensZ747UaymMn57mV59zQw4YEr
Providing a workaround to the issue:
https://github.com/hummingbot/hummingbot/issues/5129
Since GT is not on Binance, the fee GT-USDT price is not found and that generates a warning. The fee is thus not converted into USDT (not sure it would be though)
Tests performed by the developer:
Ran the updated bot and waited for a trade, then ran history ( no change to the conf_global.yml or conf_fee_override.yml)

Tips for QA testing:

PRP: https://snapshot.org/#/hbot-prp.eth/proposal/QmR21ZyXJ7a4VqUC1SX3ensZ747UaymMn57mV59zQw4YEr

I will try to update the test suite

Should this remain open open?

Actually, this seems obsolete


Changing button type in tools page

Hi, I was trying to change the button type on tools page in template with bootstrap icons but it was not displaying them correctly. Is there anything I am missing while trying to add bootstrap button in this template.

hey there, i didn't get it. Can you be little more specific? or add a screenshot or screen record. thanks

Hey @pshwetank
We are going to close this issue for this time being . If your problem is not solved please reopen here
Thanks


Point Clustering

please help me with a sample to perform a point clustering using esri-loader and angular4,
a sample plunkr  would be awesome as i read all theposts for couple of days and still having issues.

You'll need to send a link to your starter plunkr project and specific questions so we can troubleshoot it. I recommend stackblitz over plunkr.

i will try to create a stack-blitz, in the mean time , please point me to a document where i can use esri-loader and cluster because i think i am doing something fundamentally wrong when loading dojo and cluster-layer.js(extras). so that i wont waste your time with basic mistakes on my part.

please point me to a document where i can use esri-loader

Here you go for the esri-loader doc: https://github.com/Esri/esri-loader#table-of-contents. You can also find the basic steps outlined in this repositories README file.

cluster-layer.js(extras)

Are you referring to this repo? https://github.com/Esri/cluster-layer-js. Please note, that's an  old repository using an old version of the ArcGIS API for JavaScript. You'll need to update the code to using the latest version of Bootstrap and the ArcGIS API for JavaScript.
It would be much easier to create an initial prototype with the ArcGIS API for JavaScript's out-of-the-box clustering functionality. Here's a sample app: https://developers.arcgis.com/javascript/3/jssamples/fl_clustering_basic.html

sorry for the delay but i am still having the issue
here is the stackblitz
https://stackblitz.com/edit/esri-clus

Unfortunately, there seems to be a known issue in Stackblitz with loading external files and clusterLayer isn't loading. However, when I removed clusterLayer.js from the map service the app works just fine and the map displayed. To me that says the problem is with clusterLayer.js and not the code in this repository.
Refused to execute script from 'https://esri-clus.stackblitz.io/fcl/clusterLayer.js' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.

I have two suggestions:

First, create a working non-Angular, plain old HTML/JavaScript app that uses the cluster layer.

Once you have it working outside of Angular, check if clusterLayer.js is available on npm, if not you can upload your own copy, and then try adding it as a dependency to your Stackblitz project.

Hi , i was not able to create a point cluster, however i was able to achieve it with  esri leaflet,
i would like to know is it acceptable as my requirement is i have to do with  arcgis only.
thank you

It's sounds like you got your project working, so I'm going to close this issue. We are aiming to have clustering in the ArcGIS API for JavaScript 4.x some time this year.

hey @andygup, do we have option to use clustering using esri-loader? or can u pls suggest me some other way to use clustering in angular using esri map. Thanks!!

@itsme-cr here is a clustering sample: https://developers.arcgis.com/javascript/latest/sample-code/featurereduction-cluster/ Angular shouldn't affect the functionality.


I can't use it

Can you provide a default room file?No matter how I configure it, I can't join the game
[14:19:24.742] [Server thread/CRITICAL]: pocketmine\world\format\io\exception\UnsupportedWorldFormatException: "World "BB-GAME-0" is in an unsupported format and needs to be upgraded" (EXCEPTION) in "pmsrc/src/world/WorldManager" at line 238
--- Stack trace ---
#0 plugins/BuildBattle/src/cooldogedev/BuildBattle/game/Game(91): pocketmine\world\WorldManager->loadWorld(string[9] BB-GAME-0)
#1 plugins/BuildBattle/src/cooldogedev/BuildBattle/async/ClosureBackgroundTask(44): cooldogedev\BuildBattle\game\Game->cooldogedev\BuildBattle\game{closure}(object cooldogedev\BuildBattle\async\directory\AsyncDirectoryClone#160512)
#2 pmsrc/src/scheduler/AsyncPool(268): cooldogedev\BuildBattle\async\ClosureBackgroundTask->onCompletion()
#3 pmsrc/src/scheduler/AsyncPool(140): pocketmine\scheduler\AsyncPool->collectTasksFromWorker(int 0)
#4 pmsrc/vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\scheduler\AsyncPool->pocketmine\scheduler{closure}()
#5 pmsrc/src/TimeTrackingSleeperHandler(58): pocketmine\snooze\SleeperHandler->processNotifications()
#6 pmsrc/vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\TimeTrackingSleeperHandler->processNotifications()
#7 pmsrc/src/Server(1695): pocketmine\snooze\SleeperHandler->sleepUntil(float<PHONE_NUMBER>.7588)
#8 pmsrc/src/Server(1053): pocketmine\Server->tickProcessor()
#9 pmsrc/src/PocketMine(339): pocketmine\Server->__construct(object BaseClassLoader#5, object pocketmine\utils\MainLogger#4, string[40] C:\Users\MSI-PC\Desktop..............., string[48] C:\Users\MSI-PC\Desktop...............\plugins)
#10 pmsrc/src/PocketMine(362): pocketmine\server()
#11 pmsrc(11): require(string[84] phar://C:/Users/MSI-PC/Desktop/.............../PocketMine-MP.phar/src/PocketMine)
--- End of exception information ---
[14:19:24.744] [Server thread/EMERGENCY]: An unrecoverable error has occurred and the server has crashed. Creating a crash dump
[14:19:24.749] [Server thread/EMERGENCY]: Please upload the "C:/Users/MSI-PC/Desktop/新建筑大师/crashdumps/Mon_Feb_6-14.19.24-AWST_2023.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.
[14:19:24.750] [Server thread/EMERGENCY]: Forcing server shutdown

Looks like the world you're trying to use is unsupported by PocketMine, load it first via a world management utility to upgrade it.

OK


[executor] more concise model name getter for #987

Description
Suggested changes for #987. There's a full explanation in a review comment there here

Re-opening since I am un-merging it from #987 since it caused some errors.


refactor RPCBus to handle interfaces instead of bytes.Buffers

Fixes #277
Fixes #280

push CI is currently failing due to an intermittent failure in TestFetchDecoys. An issue has been opened for this and will be investigated.

I will close this PR, as it was merged into #286 to be able to progress on the migration to gRPC.


[Fix-14660] [Resource Center] Remove NONE storage type and set LOCAL type as default

Purpose of the pull request

close #14660

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #14661 (ae25d5f) into dev (d87a0d8) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Current head ae25d5f differs from pull request most recent head 5b079ac. Consider uploading reports for the commit 5b079ac to get more accurate results

@@             Coverage Diff              @@
##                dev   #14661      +/-   ##
============================================
- Coverage     38.65%   38.64%   -0.02%
+ Complexity     4621     4618       -3
============================================
  Files          1284     1284
  Lines         43877    43835      -42
  Branches       4844     4817      -27
============================================
- Hits          16962    16941      -21
+ Misses        25038    25018      -20
+ Partials       1877     1876       -1

Files Changed
Coverage Δ

...heduler/api/service/impl/ResourcesServiceImpl.java
44.32% <0.00%> (-0.16%)
:arrow_down:

... and 34 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

It's better to a a StoragePlugin with None rather than do some specific logic?

It's better to add a StoragePlugin type with None rather than do some specific logic?

Sounds good to me, I will finish it later today.

It's better to add a StoragePlugin type with None rather than do some specific logic?

Sounds good to me, I will finish it later today.

Remove the NONE type, use local storage is another choice.

Remove the NONE type, use local storage is another choice.

You're right, we can remove NONE type, but still to have to keep this check to avoid NPE, WDYT? Then, I only need to update doc.

Hi @ruanwenjun , I thought again, and suggest keep current fix in this PR and do not remove NONE type. We have the check in checkResourceUploadStartupState() for resources CURD and can return message STORAGE_NOT_STARTUP when setting NONE type. It's more user-friendly, in addition, use LOCAL type is kind of confused on my side.

Hi @ruanwenjun , I thought again, and suggest keep current fix in this PR and do not remove NONE type. We have the check in checkResourceUploadStartupState() for resources CURD and can return message STORAGE_NOT_STARTUP when setting NONE type. It's more user-friendly, in addition, use LOCAL type is kind of confused on my side.

One solution is we can throw STORAGE_NOT_STARTUP exception in NoneStorage.
Another solution is we use DEFAULT as default, and open storage is must, we don't support use NONE.

So we can use DEFAULT as default, and open storage is must, we don't support use NONE, then we can remove all check storage startup logic.

Do you mean we can add a default StoragePlugin, doing nothing when handling CURD requests of resources (behave like NONE type, after all, some users do not need storage)?

Sorry, we can use Local as default.

Hi @zhongjiajie , UT test always fail, I've checked error log and find this:
java.lang.IllegalArgumentException: java.net.UnknownHostException: mycluster

Init step of HDFSStorageOperator will fail because of this exception, would you like to help check the test environment?

I restart all the ci, let check what happened next

Would you like to help review this PR when you are free? @zhongjiajie


Add split pane

Hi folks.
Had implement a SplitPane component for you.
had start to implement it and you had create an issue (334) for it.
So here it is.

Tnx for review.
Possibly will fix most of commented issues in few days.

When dragging see following exception
Exception in thread "AWT-EventQueue-0" java.lang.IllegalStateException: Offset is unspecified
        at androidx.compose.ui.geometry.Offset.getX-impl(Offset.kt:68)
        at androidx.compose.ui.geometry.Offset.times-tuRUvjQ(Offset.kt:189)
        at androidx.compose.foundation.gestures.DragGestureDetectorKt.awaitTouchSlopOrCancellation-jO51t88(DragGestureDetector.kt:94)
        at androidx.compose.foundation.gestures.DragGestureDetectorKt$awaitTouchSlopOrCancellation$1.invokeSuspend(DragGestureDetector.kt)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:178)
        at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:166)
        at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:362)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:396)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:388)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:293)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:416)

There are also some issues that I don't know yet how can we avoid:

splitter with 1px is overlapping underlying content.
difficulties to implement custom splitter (we can't place it between panels, only above them).
how can we implement three columns?

If we had ConstraintLayout, we could only implement Splitter and attach it to some side of the custom layout and observe simple shared mutableOffset(100.dp).
Probably in the future we do this (implement ConstraintLayout, or some simple version of it, or just SplitLatout without splitter)
In the future I plan to mark all public methods as experimental, so we will be free to change API at any time.
For now, we can leave implementation as it is (but with little improvements).

splitter with 1px is overlapping underlying content.
True, it could be done by adding additional Box wrapper to contents with 1 or whatever px offset.
But that doesn't look like really good solution.
From the other side. users who implements custom splitters could do same during splitter parts implementation

how can we implement three columns?
Three columns could be implemented by putting additional split pane inside first one. same for four columns and other.

It doesn't compile now:
e: /Users/Nikolay.Igotti/compose/compose-jb/components/SplitPane/common/src/commonMain/kotlin/org/jetbrains/compose/splitpane/SplitPane.kt: (27, 5): 'public' function exposes its 'internal' parameter type SplitPaneStateImpl
e: /Users/Nikolay.Igotti/compose/compose-jb/components/SplitPane/common/src/commonMain/kotlin/org/jetbrains/compose/splitpane/SplitPane.kt: (27, 42): Type mismatch: inferred type is SplitPaneState but SplitPaneStateImpl was expected
e: /Users/Nikolay.Igotti/compose/compose-jb/components/SplitPane/common/src/commonMain/kotlin/org/jetbrains/compose/splitpane/SplitPane.kt: (35, 32): Unresolved reference: splitterState

Yep, I hadn't finish yet.
I work on different machines, so must commit changes to save progress.

SplitPane public API temporary broken

When dragging see following exception

Oh, well, i suppose that is in code that I can't control.
Well, I could not reproduce this exception, ether.

Still see exception on drag sometimes. @igordmn wdyt, shall we merge this PR and understand crash reason separately?

Hi. I had tried to watch the code from exception stack trace.
And this is possible if touchSlop is 0 and distance is equal
ffset += dragEvent.positionChange()             val distance = offset.getDistance()             var acceptedDrag = false             if (distance >= touchSlop) {                 val touchSlopOffset = offset / distance * touchSlop
in this case we have divide by 0 and NaN float as result
and offset is sets up its components parts as Unspecified
        /**          * Represents an unspecified [Offset] value, usually a replacement fornull          * when a primitive value is desired.          */         @Stable         val Unspecified = Offset(Float.NaN, Float.NaN)
It might happen cause of WA from 343 comment.
I had remove this WA and check, drag work fine. Could you please check if this exception is still present after removement?

Also @igordmn, what OS do you use to check for movement bug?
It seems that only way it could happen if in some moment when window changes it size size become equals to 0.

No longer crash for me now.

Also @igordmn, what OS do you use to check for movement bug?

On Windows. Doesn't happened anymore

There are some things we need to thing about:
https://github.com/JetBrains/compose-jb/issues/334#issuecomment-782748088
Also I pushed some commits. Please, take a look, if everything is OK:
https://github.com/JetBrains/compose-jb/pull/408/files


converting datetime with layout

Idid not find any property to instruct how to convert dates in my flat file to a property of time DateTime and when I tried to read the file, an exception was thrown converting 20170712 to type DateTime.
public class BDIHeader
    {
        public int Tipo { get; set; }
        public string NomeArquivo { get; set; }
        public string Origem { get; set; }
        public int Destino { get; set; }
        public DateTime DataGeracao { get; set; }
        public DateTime DataPregao { get; set; }
        public string HoraMinuto { get; set; }
    }

public sealed class BDIHeaderLayout : FixedLayout<BDIHeader>
    {
        public BDIHeaderLayout()
        {
            this.WithMember(x => x.Tipo, c => c.WithLength(2))
                .WithMember(x => x.NomeArquivo, c => c.WithLength(8))
                .WithMember(x => x.Origem, c => c.WithLength(8))
                .WithMember(x => x.Destino, c => c.WithLength(4))
                .WithMember(x => x.DataGeracao, c => c.WithLength(8))
                .WithMember(x => x.DataPregao, c => c.WithLength(8))
                .WithMember(x => x.HoraMinuto, c => c.WithLength(4));
        }
    }

public void Read()
        {
            //
            var factory = new FixedLengthFileEngineFactory();
            using (var stream = new FileInfo(enderecoArquivoBDI).Open(FileMode.Open, FileAccess.Read, FileShare.Read))
            {
                // If using attribute mapping, pass an array of record types
                // rather than layout instances
                var layouts = new ILayoutDescriptor<IFixedFieldSettingsContainer>[]
                {
                    new BDIHeaderLayout(),new BDIIndiceLayout()

                };

                var flatFile = factory.GetEngine(layouts,
                    line =>
                    {
                        // For each line, return the proper record type.
                        // The mapping for this line will be loaded based on that type.
                        // In this simple example, the first character determines the
                        // record type.
                        if (String.IsNullOrEmpty(line) || line.Length < 1) return null;
                        switch (line.Substring(0, 2))
                        {
                            case "00":
                                return typeof(BDIHeader);
                            //case "01":
                            //    return typeof(BDIIndice);
                                //case "02":
                                //    return typeof(BDINegociosPapelLayout);
                                //case "99":
                                //    return typeof(BDITrailerLayout);
                        }
                        return null;
                    });

                flatFile.Read(stream);

                var header = flatFile.GetRecords<BDIHeader>().FirstOrDefault();
                //var indices = flatFile.GetRecords<BDIIndice>().ToList();
                //var negocios = flatFile.GetRecords<BDINegociosPapelLayout>();
                //var trailer = flatFile.GetRecords<BDITrailer>().FirstOrDefault();
            }
        }

line being read
00BDIN9999BOVESPA<PHONE_NUMBER>13201707131807

solved my problem, see #42

#55

I really think we need something like WithStringNormalizer but it's an action where we can convert the raw value to the property type... This would allow us to do conversions for boolean values and dates much much easier.

I have submitted PR #78 that would help with this scenario.


Add searching for Lyrics feature

As title, it would be nice to have a general API to fetch lyrics.

Some info :
http://www.viewlyrics.com/lyrics/Maroon+5/Sugar/
http://www.oschina.net/code/snippet_60100_25076
https://gist.github.com/douo/4361991

Postpone to later release when we find a better API endpoint for this feature

Cleaning old issues, and there is no good way to implement this so close first.


Merge in latest master

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: JakeChampion:x: jgwmaxwell:x: dotbearYou have signed the CLA already but the status is still pending? Let us recheck it.

God damnit I always mess this up XD My bad!


Fix double escape of backslashes in history.

On Fish 2.4.0 I have noticed that if \ appears in a command line entry, then when I would use __fzf_reverse_isearch then for an entry that was,
scp remote:\* ./

then the entry would show, and insert as,
scp remote:\\*

So I added an additional sed command that seemed to fix the issue.

Is it a problem with that version? I assumed that the other file was
possibly a different format and didn't suffer the same problems.
Which version of fish used that file?
On Fri, Apr 14, 2017 at 07:09 Jethro Kuan<EMAIL_ADDRESS>wrote:

@jethrokuan commented on this pull request.
LGTM, but would need the same change to the above line as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fisherman/fzf/pull/36#pullrequestreview-32821184, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACUslXNOn7-BpmkZ46Hj27Ph--LguVKks5rv2HhgaJpZM4M8smf
.

According to this issue https://github.com/fish-shell/fish-shell/issues/862, fish 2.3.0 and earlier used that location. I don't think they changed the way fish stored history, so it probably suffers from the same issues.

Actually looking at the latest commit on history.fish (history --null), seems multiline prompts are possible using the history builtin, removing the need for this manual parsing.

Hi @milkypostman ,
I updated the plugin, and removed support for fish versions < 2.4.0. Let me know if it solves this issue.
P.S huge fan of your work in the Emacs area, thought your handle sounded familiar 😄

@jethrokuan thank you x2. the fix seems to be working great and glad to meet a MELPA user. i cannot take much credit now though because so many others are now maintaining what I started many years ago now :)


scaling Enterprise Runners

Hi Team,
I am trying to autoscale the runners deployed by using below :
apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
  name: example-runner-deployment-autoscaler
spec:
  enterprise: deutsche-bank
  scaleTargetRef:
    name: runnerdeploy
  minReplicas: 2
  maxReplicas: 25
  metrics:
  - type: PercentageRunnersBusy
    scaleUpThreshold: '0.75'
    scaleDownThreshold: '0.3'
    scaleUpFactor: '1.4'
    scaleDownFactor: '0.7'

while doing so, I am getting error to define enterprise, repo or org (I have set enterprise already) . below is the error
   /go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:88                                                           │
│ 2021-04-09T05:24:49.455Z    DEBUG    controller-runtime.manager.events    Normal    {"object": {"kind":"HorizontalRunnerAutoscaler","namespace":"default" │
│ ,"name":"example-runner-deployment-autoscaler","uid":"f9f64e76-d567-425b-8273-030f2d3a73c0","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersi │
│ on":"42750939"}, "reason": "RunnerAutoscalingFailure", "message": "enterprise, organization and repository are all empty"}                                │
│ 2021-04-09T05:24:49.455Z    ERROR    controller-runtime.controller    Reconciler error    {"controller": "horizontalrunnerautoscaler", "request": "defaul │
│ t/example-runner-deployment-autoscaler", "error": "enterprise, organization and repository are all empty"}                                                │
│ github.com/go-logr/zapr.(*zapLogger).Error

is it the correct way to scale enterprise runners:
my deployment details are here https://github.com/summerwind/actions-runner-controller/issues/440

@sandeepraj-chandrakant-bhandari-db Hey! I thought you had to define enterprise within your RunnerDeployment, not HorizontalRunnerAutoscaler.

@mumoshu yes I have it defined already. Still same error:
below is my deployment
kind: RunnerDeployment
metadata:
  name: runnerdeploy1
spec:
  replicas: 2
  template:
    spec:
      enterprise: deutsche-bank
      labels:
        - dind
      image: summerwind/actions-runner-dind:latest
      dockerdWithinRunnerContainer: true
      resources:
        limits:
          cpu: "4000m"
          memory: "2Gi"
        requests:
          cpu: "200m"
          memory: "200Mi"
      volumeMounts:
      - mountPath: /runner
        name: runner
      volumes:
      - name: runner
        emptyDir: {}

@sandeepraj-chandrakant-bhandari-db Perhaps you're using an older version of actions-runner-controller? I think it must be 0.18.0 or greateR(highly recommend 0.18.2) for https://github.com/summerwind/actions-runner-controller/commit/f1db6af1c5be66bac1cff02eafbcf894a2bac356 which seems to be needed for autoscaling to work with enterprise runners.

@mumoshu Hey I tried to use 0.18.1 and 0.18.2 versions.
But I was stuck in below issue

  2021-04-09T06:26:09.940Z    ERROR    controller-runtime.controller    Reconciler error    {"controller": "runner-controller", "request": "default/runnerd │
│ eploy-6ntnt-blssq", "error": "Pod \"runnerdeploy-6ntnt-blssq\" is invalid: [spec.volumes[1].name: Duplicate value: \"runner\", spec.containers[0].volumeM │
│ ounts[1].mountPath: Invalid value: \"/runner\": must be unique]"}

@sandeepraj-chandrakant-bhandari-db Hey! You must remove the below part from your RunnerDeployment, as those volume and volumeMount are already included in the pod spec generated by the controller
      volumeMounts:
      - mountPath: /runner
        name: runner
      volumes:
      - name: runner
        emptyDir: {}

@mumoshu the example in the https://github.com/summerwind/actions-runner-controller#github-enterprise-support section has the snippet:
      volumeMounts:
      - mountPath: /runner
        name: runner
      volumes:
      - name: runner
        emptyDir: {}

this needs removing if you can't overwrite them in the spec (even if you can this is probably the wrong place in the docs to first introduce them anyway).

@callum-tait-pbx Thanks! Ah, good catch! I have never realized that it was there. We should definitely fix it. Agree with the your guess on RunnerDeployment documentation, too.

@mumoshu @callum-tait-pbx Thank you. It works 👍


View engine parameters?

Is there a way to pass parameters to 'view engine'? I want to pass a function from node modules to pug. Earlier, when i used pug binary directly i had done it that way pug -O functions.js -o public. Now, i'm using express and app.set('view engine', 'pug');, don't know how to set up these two arguments

Hello, the command line pug arguments do not directly translate when using it through the Express integration. For example, the -o parameter is the output folder for the rendered template, but Express sends that direct to the client, so there is no need to specify a folder to store that information. The -O parameter is for the JSON/JavaScript options/object file. The options that are within that file need to be provided directly to pug, so instead of exports.doctype = 'html'; you would do app.locals.doctype = 'html'. I hope this helps! These things vary from engine to engine; you may want to contribute back to the Pug documentation at https://pugjs.org/api/express.html to help improve it for others in the future :)


Missing "read" dependency

Examples/setup.js requires the npm "read" package, but this isn't included in package.json.
$ node examples/setup.js
module.js:338
    throw err;
          ^
Error: Cannot find module 'read'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/dcassel/tmp/myproject/node_modules/marklogic/etc/test-setup-prompt.js:16:14)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/dcassel/tmp/myproject/node_modules/marklogic/examples/setup.js:21:22)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)

I see the package is included in the devDependencies list, so I guess the expectation is that someone using the node-client-api as part of some other project won't be running the examples. Someone tried running them while going through a tutorial and setup.js broke. Worth moving from devDependencies to dependencies?

I agree that the examples should be trivial to run. I'm not sure applications should have to install the Node.js API examples as their runtime dependency. Let's talk about alternatives.

If the examples weren't included when someone "npm installs" marklogic, then yeah, the ability to run them doesn't matter. If they're going to be included (as they are now), they should be runnable. Solution could go either direction.

I am also interested to see it working.  just trying marklogic for now and will need nodejs integration soon.
P.S. Is it possible to change the examples use cases from ".bind('sex'))" to a different domain use case altogether - i.e.without an innuendos?
Thank you!

From a quick look, the only obvious solution was spinning off the examples as a separate project.

@wooldridge, is this still an issue?

On balance, the best solution is to add a .npmignore file that keeps the examples directory in the GitHub repository but drops it from the npm installable distribution:
https://npm.github.io/publishing-pkgs-docs/publishing/the-npmignore-file.html

If it's too late for the client release supporting the 10.0-8 server release, this fix could be delayed to the 10.0-9 timeframe.


Optional properties with object shorthand syntax

Search Terms
object shorthand optional
Suggestion
Allow to specify optional properties in object shorthand syntax. If the variable is undefined, the property will not be added to the object (instead of being added with value undefined). Proposed syntax is to add a question mark to the property name, for example { prop1, prop2? }.
Use Cases
Goal is to create one object with a short clear (one-line) syntax.
On StackOverflow, this issue is discussed here: https://stackoverflow.com/questions/54909137/how-to-conditionally-set-optional-properties
The proposed solution uses object spread syntax. But this may have performance impact (temporary objects, property iteration) and is way too verbose.
Examples
interface Test {
  required: number;
  optional?: number
}
let required = 42;
let optional: number | undefined;

Current solution:
const object: Test = { required };
if (optional !== undefined) { object.optional = optional; }

Proposed solution:
const object: Test = { required, optional? };

The compiler would convert this to the solution above with if statements as needed.
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[ ] This feature would agree with the rest of TypeScript's Design Goals.

I have no idea about the last point though... :/ At least I did not find a comparable ES proposal.

Hmm, that's an interesting idea for a design proposal given the sorts of hacky object spread syntax.

There's always
const object: Test = { required, ...{optional && { optional } } };

I think this is out of scope for TS; it doesn't have anything to do with type checking

OK thanks, I'll try my luck with an ES proposal.

For the records. Just found an existing idea in the TC discuss groups: https://es.discourse.group/t/optional-property-shorthand-in-object-literal/196
Not much action since 2018 though...


Feature/scara

@bobnik
There are a few people in the forums that are trying to create polar sand table machines using scara type mechanisms. I think the ultimately correct choice would be to have the firmware be smart enough to handle this kind of geometry, but that has proven difficult enough that no one has been successful with that.
So I made a workaround:
https://forum.v1engineering.com/t/sandtrails-a-polar-sand-table/16844/61?u=jeffeb3
But even though I tried to make the converter simple enough to use, I know people would prefer to have this done in sandify.
Even though it isn't very hard, I am worried it will be a distraction. WDYT? I still need to make a long page of documentation for it in the wiki. It really is sort of like me making a brand new standard file type.

I guess I need to write up this wiki.

I want to add a parameter for the units/circle.
I want to write up at least some wiki information before we release this (it can be moved to master before that though).


error in loading pretrained weights

I trained a yolo3 model with backend.h5 for hours and get a new_weights.h5 (739MB), when I tried to continue training by loading new_weights.h5, there is error below, could someone kindly explain to me?
Loading pretrained weights.
Traceback (most recent call last):
File "train.py", line 252, in
main(args)
File "train.py", line 190, in main
saved_weights_name  = config['train']['saved_weights_name']
File "train.py", line 108, in create_model
template_model.load_weights(saved_weights_name)
File "/home/hemp/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 2656, in load_weights
f, self.layers, reshape=reshape)
File "/home/hemp/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 3354, in load_weights_from_hdf5_group
str(len(filtered_layers)) + ' layers.')
ValueError: You are trying to load a weight file containing 1 layers into a model with 147 layers.

Sorry, you cannot stop the training halfway at the moment.


Add provify transform

This transform will replace all instances of "tap" or "tape" require statements in a script with require('prova').  This closes #2.

The output of browserify works with node, adding browserify support for node scripts (this would also be useful for #57) whenever -t or -u is specified


Update rabbitmq doc

This updates the main RabbitMQ documentation. On improving this doc I've
moved the Nomenculture section from the README in
govuk_message_queue_consumer into source/manual/rabbitmq.html.md as i
felt it was more at home here. I've linked to it from the consumer gem
so the information is still accessible there.
The original discussion around the decisions made in this doc can be
found here.
Related PR:
govuk_message_queue_consumer
Trello:
https://trello.com/c/0OHZT3cq/458-investigate-rabbitmq-and-improve-the-documentation

Thanks for the review @benthorner.
I've addressed all your comments, should be ready for another peak! 👀


problem with configure prefix

Hi,
I found another issue. When I try to install singularity in another directory than the default one (/opt/singularity), I have issues with the command "/opt/singularity/bin/singularity build" once it is installed :
/opt/singularity/libexec/singularity/mods/install.smod: line 47: /usr/libexec/singularity/ftype: No such file or directory
... a lot of that kind of message ...

A little fix is to add a symbolic link from where singularity is searching :
mkdir -p /usr/libexec && cd $_
ln -s /opt/singularity/libexec/singularity

I think that this problem appears since the last update in the master branch.
Best,
Remy

Ooops, that was a copy paste mess up! I should have given the past h to ftype referencing $libexecddir! I'll fix as soon as I'm at a real keyboard. Thanks!

This should be fixed in master e7409ff. Thanks again!


Feature request for location of tests for vendor/edk2 specific protocols (Bugzilla Bug 1839)

This issue was created automatically with bugzilla2github
Bugzilla Bug 1839
Date: 2019-05-23T12:54:53+00:00
From: Jeff Brasen <>
To:   Edhay <<edhaya.chandran>>
CC:   ashishsingha, edhaya.chandran, eric.jin, gaojie, qiaonan.liu, stephano, supreeth.venkatesh, yonghong.zhu
Last updated: 2022-05-05T10:19:33+00:00

Comment 7875
Date: 2019-05-30 20:13:50 +0000
From: Yonghong Zhu <<yonghong.zhu>>
Jeff Brasen, could you help to send RFC to community for discussion ?

Comment 7767
Date: 2019-05-23 12:54:53 +0000
From: Jeff Brasen <>

Industry Specification: ---
Release Observed: edk2-stable202105
Releases to Fix: edk2-stable202105
Target OS: ---

Now that we have the edk2-test repo with the SCT infrastructure, has there been any thought for where tests that use this for non-standardized protocols should live? My initial thought is along with the protocols in edk2/edk2-platforms. For example if you had Silicon/NVIDIA/Include/Procotol/x.h you would have Silicon/NVIDIA/TestCase/x/ for this.
These could then be built and packaged in with the installed tests in the sct script. Not sure if it best to have something like IHV for these that pulls all the non-standard tests in (and then ones not for your target will be skipped as the protocol guid for that won't be present) or if vendors should construct a package with everything they are using.

Comment 8982
Date: 2019-08-13 15:28:18 +0000
From: Ashish Singhal <>
Stephano, Was this taken up in a design meeting?

Comment 18934
Date: 2022-05-05 10:19:33 +0000
From: Barton Gao <>
HI Edhay,
Will you update the README file ?

Comment 8115
Date: 2019-06-19 12:17:55 +0000
From: Stephano Cetola <>
Bug Triage: assign to me. I'll bring this up in the next design meeting.

Comment 18838
Date: 2022-04-19 10:49:43 +0000
From: Edhay <<edhaya.chandran>>
Outcome of discussion between Supreeth and Edhay:
We will document the guidelines as pescribed earlier in the edk2-test README:
1.If the tests are for non-standardized protocols but scheduled for standardization (inside UEFI Forum based specifications) in the future, in order to be compatible with the “code first” approach, we will help create edk2-test repo inside edk2-staging repo,
Which can be used for staging.
2.If the tests are based on standardized protocols but for a particular hardware device, we have no objections in accepting contributions that would go in IHV folder.
3.If the tests are for non-standardized protocols, it is better to host it elsewhere outside of the edk2-test as edk2-test repo is for tests against UEFI specification.
Specifically for (3) "non-standardized" architectural protocols, the build and run of UEFI-SCT shall me controlled through a compile-time and runtime flags respectively.
And the ticket shall be closed, after a discussion in the next edk2-test triage meeting and the README update.

Comment 8259
Date: 2019-06-27 20:43:51 +0000
From: Liu Qiaonan <<qiaonan.liu>>
Stephano, please work on it.

Comment 17458
Date: 2021-10-07 10:53:26 +0000
From: Edhay <<edhaya.chandran>>
Edhay to consult with Supreeth and close

Comment 9572
Date: 2019-09-10 10:27:52 +0000
From: supreeth.venkatesh
At UTWG, we agreed with the following general guidelines for doing this.
1.If the tests are for non-standardized protocols but scheduled for standardization (inside UEFI Forum based specifications) in the future, in order to be compatible with the “code first” approach, we will help create edk2-test repo inside edk2-staging repo,
Which can be used for staging.
2.If the tests are based on standardized protocols but for a particular hardware device, we have no objections in accepting contributions that would go in IHV folder.
3.If the tests are for non-standardized protocols, it is better to host it elsewhere outside of the edk2-test as edk2-test repo is for tests against UEFI specification.
Based on this, I guess we need details from Jeff (Nvidia),
1.What sort of tests does Nvidia have in mind for contributing?
2.Would the tests fall in any of the three categories mentioned above?


Crashes while building a graph

Hi there! I'm having trouble using Notion Graph View. When I run the program to generate a graph, it crashes, possibly when encountering a page with a database (in my workspace, it found several nodes before crashing).
File "/home/zboucek/.local/lib/python3.10/site-packages/notion_client/client.py", line 126, in _parse_response
    raise APIResponseError(response, body["message"], code)
notion_client.errors.APIResponseError: Could not find database with ID: **********************. Make sure the relevant pages and databases are shared with your integration.

Thanks, the project looks interesting. Just what I was looking for. Hopefully the bug will be resolved soon.

it seems like that your notion api is not available. please follow the readme section - "Notion api setup".

I mapped the databases successfully, but it crashes when the program reaches the view of the same database on the page. I cannot access the page from error message according to its ID even in browser. I think that problem is getting ID of database from view.

I tried again and did not encounter the issue you mentioned. The possible reason could be that your database did not grant integration permissions.

I gave access to all the pages just in case. Sometimes the graph for a certain page is created, but sometimes it ends up with an error that the database with the ID cannot be found. I have the pages very interlinked, it seems that this is what is causing the problem. There is no classic tree structure, but sometimes it will bounce to a page that is at a different level than the original one that the graph is built from.

Hi @zboucek  could you please provide me with an example (a sharing Notion page or a relationship graph) to demonstrate the error in your notes?


Update rehype-pretty-code

Due to new version<EMAIL_ADDRESS>have new ability to highlight multiple word atomiks/rehype-pretty-code#43, we should update to the latest, for maximum benefits

Hi @ttwrpz I tried to update, but found some unexpected error https://github.com/atomiks/rehype-pretty-code/issues/45

done by https://github.com/shuding/nextra/pull/1116, will be available in next release


Refactor CI container registry to allow remote test execution

This is mostly here for record-keeping. nebril may correct this ticket once it's clearer what is needed
We currently run the docker container registry for tests inside k8s1, one of the test VMs. The tests themselves can take an arbitrary image source, however, and this means we can run CI on managed k8s but reuse the current CI infrastructure. In particular, this allows us to reuse the jenkins node to build the various cilium images without having a separate, new, build cluster.

@nebril is this improvement still necessary or is it already implemented?


Schedule.filter should accept scalar values as well as iterables

What is the expected enhancement?
Schedule.filter currently expects its input arguments to be a list. This should be extended to also accept a scalar value.
schedule.filter(instruction_types=DelayInstruction)

Hi, I just started to get into Qiskit. I was wondering if you would give me a shot at this?

Welcome to Qiskit @NuoWenLei! This is an excellent issue to cut your teeth on. I have assigned it to you, feel free to ask for any pointers on how to go about this.

Ok thank you!

Hi, I noticed that inputs for schedule.filter() usually come in pairs, such as DriveChannel + AcquireChannel. Should it be better to change only the instruction_types or change all inputs to accept scalar values?

I would recommend letting all accept both a scalar and a list.

Ok that sounds good

Is this issue still open?

#3768 should fix this issue.

Fixed via #3646


no frequency causes thread to stop

not going to fix since -1 will signify that the input is disconnected


after successful import, no feedback and new flow is not selected

What are the steps to reproduce?
Import a flow, e.g., via clipboard.
What happens?
The flow is imported, but not selected.  No "success" messaging appears.
What do you expect to happen?

"Success" messaging, e.g., "Your flow was imported as "
The new flow tab is selected.

Please tell us about your environment:

[x] Node-RED version: d373105b32d7b04cca6115b891f042c2b21339c2
[x] node.js version: 10.9.0
[x] npm version: 6.4.0
[x] Platform/OS: macOS X
[x] Browser: Chrome

I realise give the exact commit sha is a precise way to share the version, but it would be handy if you gave a human readable version to save me looking it up. .. ie "latest in git master"
I don't think we've ever had a success message on import - so is this a regression you're reporting or a change in behaviour you'd like?
If you import some nodes they are attached to the mouse for you to place in the current flow.
If the imported nodes includes a tab node, then the tab will be added in the background - is that the behaviour you're talking about? If so, that isn't necessarily intentional behaviour, so yes, it could be improved.

I realise give the exact commit sha is a precise way to share the version, but it would be handy if you gave a human readable version to save me looking it up. .. ie "latest in git master"

Sorry, thought this would link to the changeset; it won't if you wrap the SHA in backticks, apparently...

I don't think we've ever had a success message on import - so is this a regression you're reporting or a change in behaviour you'd like?

If it never worked as such, then it's the latter.
The gist of it is: "I imported a flow and didn't immediately realize it worked."

Fixed in dev for 0.20


Feature issubscribed

Coverage decreased (-0.6%) to 57.073% when pulling e2f6d2d266801430f02baccc1da5df354236f800 on feature-issubscribed into 5861e7a53ab75cacea02cb2e8d1ffe81b87e7c6c on master.


Context menu slow when annotation cache is not initialized

On a large schema (with more than 40'000 PL/SQL packages) the query
SELECT o.object_owner, o.object_type, o.object_name, a.name, a.text, a.subobject_name
  FROM TABLE(UT3.ut_annotation_manager.get_annotated_objects(upper(?), 'PACKAGE')) o
 CROSS JOIN TABLE(o.annotations) a
 WHERE o.object_name = upper(?)

took 2 minutes to complete. The UI is blocked during this time. This is very bad.
When the cache is initialized the query takes about 700 milliseconds. Since this query is executed twice the context menu is delayed by 1.4 seconds, which is too much.
Since this statement might be expensive, it should be executed once.
Furthermore a mechanism should be defined to limit the wait time for the query response and to define a default behaviour.

The runtime performance is very much dependent on the schema the user is working, the user should have the option to decide how the behaviour should be. The "mechanism" to get always good performance of the context menu is to disable the check in the context menu. This is implemented via #17.


Render a list of files (ex: mp4 + jpg + srt)

I believe it would be useful to implement the rendering of a list of files together in an element. My use case is a torrent containing a mp4 video along with a poster and some srt files. We could render a nice video elem with sources, tracks...
I dont see another use case for now, do you think it would fit in this module?

Given how complicated this module already is, I'd rather see this implemented as another package that depends on render-media.


Add simple flow properties

Add simple flow properties where only viscosity and compressibility vary with pressure/pseudopressure.
$$ \frac{\partial \tilde m}{\partial \tilde t} = \frac{c_i\mu_i}{c\mu} \frac{\partial^2 \tilde m}{\partial \tilde x^2} $$

Completed with #15


improve namespace exports

#66  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bmschmidt and the rest of your teammates on  Graphite


Spider Origin Unable To Climb

When I choose the spider origin, it wont work for me. everything about the origin is fine except for the ability to climb.

Same here. For what I can see any origin with the ability to climb or other actions specified by the condition type: "origins:block_collision" just does not work in any way possible.

same i cant climb sometimes but sometimes i can

Please first check if your climbing power is active. If it isn't (the power doesn't work), you can press the Primary Active key (default: G) to re-enable it.


Fenix s6 Solar - global settings

Thank you for this app! I can’t seem to access global settings on my watch? The screen looks like it changes but just creates an identical new screen. Holding in menu button just starts the session. Thanks!

@BSShepherd i found how to access menu - hold up-menu (a left-side button in the middle)


ENH: Enabling the support of windows and AOI when loading bands

When loading bands, enable the support of:

[ ] Rasterio windows
[ ] AOI (any fiona driver, including KML)

Loading a window

use rioxarray isel_window ?

Loading an AOI

determine its extent
load only its window
then crop the windowed array by the AOI

:warning:

Pay attention to non orthorectified or non projected bands.
-> Ortho/project them entirely first ?
What file to write on disk, only the whole files ?
-> Always load, process nodata or clean pixels for the whole file at least one ?

Look at Salem

Salem is a small library to do geoscientific data processing and plotting. It extends xarray to add geolocalised subsetting, masking, and plotting operations to xarray’s DataArray and DataSet structures.

NB: this would be at first an improvement of the functions of sertit's rasters.read and rasters_rio.read

Done in sertit-utils 🚀


Can we provide an option to control whether to enable formatting?

I found that I can't use formatting in C/C++ plugin,although I choose Format Document With C/C++
instead of clangd

We recommend not to use vscode-clangd together with the microsoft C/C++ plugin.
That said, from your description this sounds like a problem with VSCode formatting with the wrong provider.


Sign Transaction stuck on Decoding transaction

When trying to sign a raw transaction, UI remains stuck on "Decoding transaction..."

Hey there @niftyboss1 ,
Thank you for reaching out! hi, We are sorry for any inconveniences you might have experienced, kindly refresh your wallet, if the issue persists, then your query would be best dealt with by Help center.

I’ll have to refer you to the official support Team with the ticket ID CLO7463
Please see the link below to our dedicated support line:

Help center Support Ticket Requests

Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent for immediate assistance.

ignore the "support" offered by the phishing account tonydev-lab... he is not associated with freewallet and is offering fake help in order to try and trick you into giving up wallet info.
I'll work on getting this issue fixed in the next release.
If you could try signing your transaction again and show me the contents of the debug window, that would be helpful.. perhaps a request is failing to get UTXOs

I think this will best be solved by adding a "Verify" button next to the "Sign" button.
I believe the issue is that the verify/decode tx logic happens BEFORE a sign is allowed, so if we are unable to decode the tx, then we never get a chance to sign. By separating the two, users can decode/verify what a transaction does and sign separately.

Verify and Sign processes separated with commit 32c24c326ef519127bcd3822f9e9c56aac8bef4c
Will be in next freewallet release in the next day or two


redis.srandmember returns one member when number = 0

The document says:

srandmember(name, number=None)[source]
If number is None, returns a random member of set name.
If number is supplied, returns a list of number random memebers of set name. Note this is only available when running Redis 2.6+.

But if I use redis.srandmember(key, 0), it returns one elememt.
I think there is a bug in redis/client.py:1647,
number and [number] or []

thanks! merged.