Move keytransparency_v1_proto to api/v1

Merge #878 first

Codecov Report

Merging #879 into master will not change coverage.
The diff coverage is 48.88%.

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   48.87%   48.87%
=======================================
  Files          34       34
  Lines        2351     2351
=======================================
  Hits         1149     1149
  Misses        998      998
  Partials      204      204

Impacted Files
Coverage Δ

impl/sql/mutationstorage/mutations.go
60% <ø> (ø)
:arrow_up:

core/mutator/entry/mutation.go
76.25% <ø> (ø)
:arrow_up:

core/sequencer/sequencer.go
8.18% <ø> (ø)
:arrow_up:

core/monitor/verify.go
0% <ø> (ø)
:arrow_up:

core/monitor/monitor.go
0% <ø> (ø)
:arrow_up:

core/monitor/sign.go
0% <0%> (ø)
:arrow_up:

core/keyserver/keyserver.go
0% <0%> (ø)
:arrow_up:

integration/testutil.go
71.11% <100%> (ø)
:arrow_up:

core/mutationserver/validate.go
45.45% <100%> (ø)
:arrow_up:

core/adminserver/admin_server.go
51.61% <100%> (ø)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04f993...04c9c1f. Read the comment docs.

Codecov Report

Merging #879 into master will not change coverage.
The diff coverage is 48.88%.

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   48.87%   48.87%
=======================================
  Files          34       34
  Lines        2351     2351
=======================================
  Hits         1149     1149
  Misses        998      998
  Partials      204      204

Impacted Files
Coverage Δ

core/mutator/entry/mutation.go
76.25% <ø> (ø)
:arrow_up:

core/monitor/verify.go
0% <ø> (ø)
:arrow_up:

core/sequencer/sequencer.go
8.18% <ø> (ø)
:arrow_up:

impl/sql/mutationstorage/mutations.go
60% <ø> (ø)
:arrow_up:

core/monitor/monitor.go
0% <ø> (ø)
:arrow_up:

core/keyserver/keyserver.go
0% <0%> (ø)
:arrow_up:

core/monitor/sign.go
0% <0%> (ø)
:arrow_up:

core/mutationserver/validate.go
45.45% <100%> (ø)
:arrow_up:

core/adminserver/admin_server.go
51.61% <100%> (ø)
:arrow_up:

integration/testutil.go
71.11% <100%> (ø)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04f993...2c6e5ea. Read the comment docs.


how to download slides

Hi, I try your method in issue 33, but I cannot download the slide for recurrent network.

"Tensorflow, deep learning and recurrent neural networks": https://goo.gl/UuN41S
Then delete /pub and everything that comers after it in the URL.
To print go to File > Print settings and preview > 1 slide with notes


Eslint errors are shown as warnings on console and webpack 2 build doesn't fail even with failOnError as true.

I have configured eslint loader to be used with webpack 2 with below options.
{
test: /.js$/,
enforce: 'pre',
loader: 'eslint-loader',
exclude: /node_modules|build|testApplication/,
include : [paths.source],
options: {
cache:true,
configFile: path.join(__dirname, 'eslintRules.json'),
"ignorePath":path.join(__dirname, 'eslintFolders.ignore'),
cwd:path.resolve(process.cwd(), '.'),
failOnError :true,
formatter: require('eslint/lib/formatters/table')
},
}
My npm react project structure is
module1/
component1
module2/
component2
module3/
component3
commonfile1
commonfile2
app/
appfile1
appfile2
Scenario 1: If there is some eslint error in appfile1 or appfile2 the webpack build fails with eslint printing the first file on which the error code was present.
Scenario 2: If I ignore the app folder in the ignore file and execute the build. The eslint build succedds with  printing the messages along with rule as error but the module failed message shown as WARNING in 'filepath' instead of ERROR in 'filepath'. If I have a lot of files with the similar rule failure the build fails with "WARNING in filepath" message for some and "ERROR in filepath" message for some files.
I expected this to be consistent so that build fails even if there is an error in code at any level of module component.
I also tried with emitError:true in options but still getting the same output.
Would you recommend some other options i could try or any version conflict of eslint/webpack causing this?
Below is the list of dependencies versions
"eslint": "^4.5.0",
"eslint-loader": "^1.9.0",
"eslint-plugin-import": "^2.7.0",
"eslint-plugin-react": "^7.2.1",
"webpack": "^3.5.5",

If errors as show as warnings, this cannot trigger a build fail.
You must succeed to have eslint errors as webpack errors.
This module is covered by tests to ensure this behavior is stable so you might try to double check your config or provide a failing test (which will help more than your explanation to provide a fix)

@AjayU, have you found a solution? I faced the same issue right now and don't know what to do.
I'm really sorry for writing in a closed issue, but this is the only relevant I found.

@MoOx, it looks that I found the reason of errors treated as warnings. Let's start with a test:
test/require-context.js
var test = require("ava")
var webpack = require("webpack")
var conf = require("./utils/conf")

test.cb("eslint-loader can return error if file is bad and required as context module", function(t) {
  t.plan(1)
  webpack(conf(
    {
      entry: "./test/fixtures/require-context.js",
    },
    {
      failOnError: true,
    }),
  function(err, stats) {
    if (err) {
      throw err
    }

    t.true(
      stats.hasErrors(),
      "a file that contains eslint errors should return error"
    )
    t.end()
  })
})

/test/fixtures/require-context.js
const context = require.context(".", false, /error\.js$/)
context.keys().forEach(function(key) {
  context(key)
})

test/fixtures/error.js
var foo = stuff

This test would fail.
If an error exists in error.js, it will be emited to compilation.modules['module-id'].errors collection, but on the compilation instance it would be located in compilations.warnings. So, stats.hasErrors() will return false.  As a result, we are in a bad situation when our assets failed syntax check, but we don't know about that.
This behavior is caused by context modules which are "optional" in webpack and errors occured in them treated as warnings. Here we can find an example.
I wrote a simple plugin which solves this issue. It moves the optional module errors from compilation.warnings to compilation.errors. But it seems a little tricky and I believe it can lead to unpredictable consequences.
class OptionalModulesErrorsPlugin {
  apply(compiler) {
    compiler.plugin("after-compile", (compilation, callback) => {
      compilation.modules
        .filter(module => module.optional && module.errors.length > 0)
        .forEach(module => {
          module.errors.forEach(err => {
            const warningId = compilation.warnings.indexOf(err)
            if (warningId !== -1) {
              compilation.warnings.splice(warningId, 1)
              compilation.errors.push(err)
            }
          })
        })

      callback()
    })
  }
}


Rename bevy_reflect Array to Sequence

Renamed bevy_reflect Array to Sequence and all associated types, traits and functions.
Fixed accompanying documentation, tests and examples.
Objective
Fixes #7059
Solution
Renamed Array to Sequence and made sure it is propagated where needed.

Changelog
Changed
bevy_reflect::Array to bevy_reflect::Sequence

I just left a comment on the original issue. I think another potential fix for the whole "fixed length" problem could be to just separate the two traits (and keeping the name Array).

I think I can try and bang the code for the new approach out in the next few days, depending on free time.
Should we close this PR then?

Should we close this PR then?

Maybe leave it open until the new PR is up so we can compare? Or at least until we get more feedback on the new issue?


msvcr110.dll is missing after Windows upgrade

Raising from user email

I have recently upgraded my windows to this ver:

I received a message that my msvcr110.dll is missing
I copied this file from my C:\Windows\System32 to C:\Windows\SysWOW64 directory and received the message “the application was unable to start correctly 0xc000007b”
I thought it was my Microsoft Visual C++ redistributable pack and installed the following:

I was wondering if you could help me in this, if you have encountered the error before. If not, it is alright, I can just use my laptop to work on the Tagui project.

Try installing from this link and choose vcredist_x86.exe to see if that helps -
https://www.microsoft.com/en-us/download/details.aspx?id=30679
This is because the PHP packaged with TagUI is a 32-bit one for compatibility reasons. I added this to read me homepage but probably people will only notice the error note and solution if they encounter it during initial setup.


Emutale kubectl apply error

Based on this link: https://github.com/kubernetes/client-go/issues/216
I ended up having the call as
var ctx context.Context
var c client.Client
var actionFn ForEachObjectInYAMLActionFunc

func main() {

	yamlFile, err := ioutil.ReadFile("crds.yaml")
	if err != nil {
		log.Printf("yamlFile.Get err   #%v ", err)
	}

	err = ForEachObjectInYAML(ctx, c, yamlFile, "default", actionFn)
	if err != nil {
		fmt.Println(err)
	}
}

but it is failing because of
if err := actionFn(ctx, c, obj); err != nil {
	return err
}

the errror is
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x10ac5cc]

goroutine 1 [running]:
main.ForEachObjectInYAML({0x0, 0x0}, {0x0, 0x0}, {0xc000880000?, 0xc0000021a0?, 0x200000003?}, {0x12bf20f, 0x7}, 0x0)
       apply.go:125 +0x12c
main.main()
       apply.go:34 +0xc5
exit status 2

any idea please where I'm missing/doing wrong?

You don't have an actual implementation of ForEachObjectInYAMLActionFunc, your actionFn is empty cq nil.


Misprint

In Tweaks, Disable Storage sense's better description has a small misprint. Not a big deal, yet it someone might be annoyed by it.

Bad spelling is my achilleas heel. My XAML program doesn't have spell check and this is going to pop up again lol.
I'm working on fixing this by coding everything in a custom neovim with a linter as I type. Probably next month I'll be able to cut down on these.
submitted commit 5bfab63f4f621fb5d21586da0e9c4224f7e3ce14 to test fixing this


Do you plan on releasing the code for the control experiments?

Hi, great stuff, and thanks for open sourcing this.
Do you plan on releasing the code for the value estimation or control aspects of this?

The code for value estimation is already in the repo. Check out the last cell in the notebooks with:
visualize_values(prob_fn, n_steps=20)

We don't have plans to release the control code in the short term.

The code for value estimation is already in the repo. Check out the last cell in the notebooks with:
visualize_values(prob_fn, n_steps=20)

We don't have plans to release the control code in the short term.


add: Kshitiz Rana

Description
[Include a brief description of the changes you've made]
Related Issues
[Include any related issues or pull requests that this PR addresses or is related to. Use GitHub's shorthand syntax to link to them, like #1234.]
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@KshitizRana You have not added bio. Add it and push changes into this branch only.

Done Please merge it
On Sat, May 6, 2023 at 9:30 PM Shyam Tawli @.***> wrote:

@.**** requested changes on this pull request.
@KshitizRana https://github.com/KshitizRana you have not added bio,
Make changes and push into same branch.
—
Reply to this email directly, view it on GitHub
https://github.com/shyamtawli/devFind/pull/101#pullrequestreview-1415792190,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWJA2472NA37FYJRAMDXQHDXEZYQZANCNFSM6AAAAAAXXOHUOQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@KshitizRana Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!
You can update your bio in future if you want.

You are welcome.
On Sat, May 6, 2023 at 10:13 PM Shyam Tawli @.***>
wrote:

@KshitizRana https://github.com/KshitizRana Thank you so much for your
contribution! Your efforts are greatly appreciated and will go a long way
in improving our project. Please feel free to share it with others and help
us grow even further!
You can update your bio in future if you want.
—
Reply to this email directly, view it on GitHub
https://github.com/shyamtawli/devFind/pull/101#issuecomment-1537179100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWJA24YBZR7FMUUSFDWOKP3XEZ5TVANCNFSM6AAAAAAXXOHUOQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update README.md

Description
Found a extra : while following the readme instructions.
Fixes (issue #)
Type of change

[X]  Patch: Bug (non-breaking change which fixes an issue)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

I just removed the demo app instruction in favor of shopify-app coming up. But thanks for helping out!


chore(main): release stowfiles 1.17.0

:robot: I have created a release beep boop
1.17.0 (2024-06-16)
Features

llf: set up llf config for latex formatting (ad7f568)

Bug Fixes

nvim: check has macunix value is 1 (036ef87)
nvim: forgot to both go to cmd mode and to cr the commands (f061153)
nvim: my bug fix of vim-angry-reviewer is merged (06ae4ca)
nvim: tex snippets should check math from utils, not ts_utils (ab29f7a)
nvim: use vimtex over treesitter for latex (36a7424)

Miscellaneous

mise,go: add lazydocker to default programs (9917229)
nvim: [plugin] add schemastore.nvim (98f12d2)
nvim: [plugin] add snap to do searching (b7307ed)
nvim: add just formatter and d2 is now available from source (9a86ae4)
nvim: add yaml and json schema store and set LSPs (c59dafd)
nvim: map all vimtex to local-l and use local-t for texlab keymaps (8aefca0)
nvim: move syntax file to after (1ef9f62)
nvim: remove autocmd for treesitter highlighting (9004756)
nvim: small changes to plugins (ea3378c)
nvim: update colorscheme (56abdee)
nvim: update plugin list (a52480f)
nvim: update some keymaps (d852c0e)
software: update installed (f95be25)
yazi: update deprecated config value (55cda96)

Styles

typo: fix English grammar (7c1d3be)

Code Refactoring

nvim: swap treesitter siblings with [8 and ]9, not [a and ]a (d1210d8)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

stowfiles-v1.17.0
:sunflower:


Hyundai CAN: allow fingerprinting without comma power

CAN FD platforms already support this. Turns out we get the eps on a lot of cars!
Progress
Marking cars with no OBD ECUs already in the database as "already done" (camera, radar)

[ ] HYUNDAI_ELANTRA
[ ] HYUNDAI_ELANTRA_GT_I30
[x] HYUNDAI_ELANTRA_2021
[x] HYUNDAI_ELANTRA_HEV_2021
[x] HYUNDAI_GENESIS - already done
[ ] HYUNDAI_IONIQ
[ ] HYUNDAI_IONIQ_HEV_2022
[ ] HYUNDAI_IONIQ_EV_LTD
[x] HYUNDAI_IONIQ_EV_2020 - already done
[ ] HYUNDAI_IONIQ_PHEV_2019
[x] HYUNDAI_IONIQ_PHEV
[ ] HYUNDAI_KONA
[ ] HYUNDAI_KONA_EV
[x] HYUNDAI_KONA_EV_2022
[ ] HYUNDAI_KONA_HEV
[x] HYUNDAI_SANTA_FE
[x] HYUNDAI_SANTA_FE_2022
[ ] HYUNDAI_SANTA_FE_HEV_2022
[ ] HYUNDAI_SANTA_FE_PHEV_2022
[x] HYUNDAI_SONATA_LF - already done
[ ] HYUNDAI_TUCSON
[ ] HYUNDAI_VELOSTER
[x] HYUNDAI_SONATA_HYBRID
[ ] HYUNDAI_CUSTIN_1ST_GEN
[x] KIA_FORTE
[x] KIA_K5_2021
[ ] KIA_K5_HEV_2020
[x] KIA_NIRO_EV - already done
[ ] KIA_NIRO_PHEV
[x] KIA_NIRO_PHEV_2022
[x] KIA_NIRO_HEV_2021
[ ] KIA_OPTIMA_G4
[x] KIA_OPTIMA_G4_FL - already done
[x] KIA_OPTIMA_H - already done
[x] KIA_OPTIMA_H_G4_FL
[ ] KIA_SELTOS
[ ] KIA_SORENTO
[x] KIA_STINGER
[x] KIA_STINGER_2022
[ ] KIA_CEED
[x] GENESIS_G70
[x] GENESIS_G70_2020
[ ] GENESIS_G80
[x] GENESIS_G90

This is all the data we have since the extra logging added recently on comma remotes (master): https://github.com/commaai/openpilot/pull/31334
The rest of the cars will require some manual review, which I'll do in a follow up PR.


Resolve: Extension FK COLUMN NAME cause error in case of column name without underscore #29

Fixes https://github.com/php-openapi/yii2-openapi/issues/29

Thank you!


test: Bump eg.recentZulipFeatureLevel and recentZulipVersion to 9.0

This keeps eg.account and eg.initialSnapshot using recent versions by default.

LGTM, thanks! Merged.


proposal: allow fatal panic handler

What version of Go are you using (go version)?

$ go version go1.11.5 darwin/amd64

Does this issue reproduce with the latest release?
Yuppers
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/usterch/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/usterch/src/GO"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jf/ggd1wkrj6wn4zlqgt10xh66c5sxxm7/T/go-build298064772=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Want to catch all panics in main() in order to perform a hook action before calling os.Exit(1). Unfortunately, by convention, go does not roll-up panics past certain boundaries.
What did you expect to see?
I was hoping the stack would continue to unwind until there was no stack left or that there would be a middleware I could register to intercept a panic globally.
What did you see instead?
The stack unwinds to the goroutine/package boundary. Since all of our code is running in go routines and separate packages, there is no seemingly D.R.Y. method of handling that graceful shutdown.
Detail:
I'm sure this is going to get slammed by the community (be gentle), but I figure it's worthwhile to ask.
When a panic() occurs, it's bad. The program should crash unless there's an explicit recover that's able to fix that specific issue. Just prior to the crash though, we would like the ability to call one function to handle a simple clean-up operation before the os.Exit(1). This is not a novel concept, Python/JAVA/Ruby all support it for example. This is easier to accomplish since they aren't pre-compiled languages.
The workarounds I see consistently used are to either:
a) copy+paste the same defer-recover statement into literally every function
b) Use panicwrapper which effectively re-launches your program into a subprocess and watches it for issues. If your program exits abnormally, panicwrapper is the parent process, thus it is able to handle that single clean-up operation. There are limitations to panicwrapper though - such as signal handling can get really garbled.
It seems like this should be something that's natively included in the language though as opposed to having to hack around it and fork() and redirect signals/stdout/stderr.
Some Usage Examples:

You are using a non-thread-safe 3rd party library, but you don't know it's not thread-safe. You call a function from that library in a gin router and everything blows up since gin is threaded automatically.
You have several packages that you develop, most of which don't have main() functions, and instead call individual functions. You forgot to protect a string map for concurrency and :boom:, panic(). You want to iterate an some sort of error counter in prometheus and log a message about the panic before exiting (e.g. a stackdump).

These are both fatal events where the program should crash, but having a global panic() hook/middleware would enable a small amount of clean-up/extra logging to enable easier debug/code fixes.
It seems like there was a very intentional decision made here to prevent the unroll all the way to main(). If you disagree with this proposal, could you help me understand a little more about why it's advantageous to maintain this boundary?

I don't understand how to implement this.  When you start a new goroutine, the old goroutine keeps running.  If the new goroutine panics, we can't panic in the old goroutine.  It may not even exist anymore.
Or perhaps you are looking for something like GODEBUG=tracebackancestors=100?  Search for tracebackancestors in https://golang.org/pkg/runtime/.

I think the real feature you're asking for is a way to set a handler that runs before the program exits, even when the program is aborting due to an unhandled panic.
FWIW, while support for atexit handlers has been intentionally omitted because they are so often misused, I found myself wanting one today for https://golang.org/cl/179599--it would be nice if the testing package had a chance to clean up and display output when a goroutine started by a test (as opposed to the test goroutine itself) triggers a panic.

@neild I think that's a fairly good description. I would love the ability to clean up the DB after a test panics, instead of having to go clean it manually when someone Fs* something up so that the defer doesn't run.
@ianlancetaylor I'm looking into tracebackancestors now and what kind of performance hit that brings.
My thought on implementation would be to add a PanicHandler somewhere around here: https://github.com/golang/go/blob/master/src/runtime/panic.go#L887 - it could no-op by default. Then I could call runtime.RegisterPanicHandler(someFunc) up in my main() function.

There is no reliable way to run a hook when the program exits.  And such a hook would run in a very limited environment, so it would be difficult to write a correct hook.
If you must do some sort of cleanup after a program exits, the only reliable mechanism is to execute the program as a child, and do the cleanup after it returns.

@ianlancetaylor Doesn't literally every unrecoverable panic call runtime.fatalpanic which is ultimately what writes the panic to stderr and exits 2? If so, it would be something like:
if runtime.HasRegisteredHandler() {
  handle := runtime.GetRegisteredHandler()
  handle()
}

If you are cleaning up a database, vs logging an error msg, you should do that on startup, as no exit code will run on OS crash or power-off.

We can reliably hook into when a panic is going to cause the program to exit, but that is not the same as reliably hooking into every case where a program exits.  There are many exit paths that do not go through runtime.fatalpanic.
And my other point still holds: by the time we reach runtime.fatalpanic the runtime has started shutting down.  Any hook called by fatalpanic can not run ordinary Go code.  It can only run a carefully written subset of Go code.

@networkimprov Yup - and that's what we do - we run a clean-up both in setup() and in a defer() block, just in-case tests panicked. It's not DRY, but it's robust.
@ianlancetaylor That may not have been clear, sorry - I only want it to run in the case of a panic, that's the only time, not on other exit paths. Other exit paths can all be easily handled normally.
I do kind of see what you're talking about now, where the stack isn't necessarily in a predictable state here. I figured that anything generic you could do in a recover() function, you could do here (e.g. forward the panic message to an external logging service). I don't know how much the stack unwinds before we get here - would something like a logger still be available as long as:

the logger itself didn't cause the panic and
was instantiated prior to the function that panicked?

Would you happen to feel any differently about this if the proposed destination for this handler's home was say...in the unsafe package?

You can write anything in a deferred function.  The deferred functions are invoked as the stack is unwound.
A fatal panic shuts down the whole runtime, including the scheduler and everything.
I'm not sure I see the purpose of only handling a panic.  You can write that yourself, with some care, using defer statements.  But why distinguish between a panic and a fatal runtime error?  A fatal runtime error is something like running out of memory; it doesn't panic, doesn't run defer statements, but just crashes the program with a stack trace.  I don't think it's a common case to want to handle a uncaught panic but not want to handle a fatal runtime error.
I personally would not feel differently if this were in the unsafe package.

The two things we personally do with a panic -
a) iterate a prometheus error counter
b) send the panic as a log message to Splunk
I'm able to accomplish b) by moving the logging responsibility out of Go and into another daemon but a) cannot be accomplished without copy+pasting the exact same code into literally thousands of functions, and even copy+pasting that code every where, I still can't run either a) or b) when there's a panic from a 3rd party library.
When there's a panic from a 3rd party library, we find an alternate library or submit a patch to address the panic, but it's very hard to get at that panic error message in general. That's why we (and other users) end up using https://github.com/mitchellh/panicwrap or https://github.com/bugsnag/panicwrap, so that we can iterate the counter and send the log message. I've seen others handle it with a post stop kubernetes hook and they go find/grep the log looking for a panic message.
I'm looking to imitate the behavior that panicwrapper provides.  I just think having a language native method of handling those unexpected failures from 3rd party libraries would be super helpful

In general Go has taken the position that error recovery should either be done locally (that is, by a parent frame expecting a certain kind of panic in the child) or else in a separate process entirely. This is why you can't recover from panic across goroutines and you also can't recover from throw (runtime-internal detection of very bad conditions like possible memory corruption).
We could have a kind of global defer to push something onto the top of every goroutine before it starts, but it's unclear that would help more than it complicates things. In the end you still need another process (one that can't be affected by memory corruption, stuck locks, or whatever other issues might have triggered the panic) watching the Go program if you want to be completely robust.

Marking as LanguageChange because this is about a fundamental language issue, even if the end result is mainly implemented in the runtime. The spec would need to explain that there is this "final step" during a panic.

Per comments above, we aren't going to add this to the language/runtime.  It would require defining a subset of Go that could be run in the panic handler to avoid effectively relaunching goroutines as the program was exiting.  For Go, as with many other languages, reliable error handling has to be done in a separate process.
I don't understand your comment about prometheus error counters; in particular I don't understand why the code has to be copied into thousands of functions.  Perhaps there is some way that can be addressed short of a fatal panic handler.  For example, perhaps the separate analyzer process could examine the stack trace.  But I don't really know.
-- iant for @golang/proposal-review


Link to https://moneroecosystem.org/

i would like to see a link to https://moneroecosystem.org/

found the link at https://web.getmonero.org/resources/developer-guides/


Remove reference to ITT

Brings in: https://github.com/alphagov/digitalmarketplace-ssp-content/pull/76
Changes: https://github.com/alphagov/digitalmarketplace-ssp-content/compare/92818a67caf476da2e8ff1cd53ead632c162e1dd…aa1b1c41b8c6872c852ed6d6f38c4e26fefc6ed1

👍


check usage of "threshold" in classifier chain models

Not all CC-based models need thresholds. CC for itself for example.

Left to check: ECC


npx bundlesize cannot find module

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
npx bundlesize throws the following message:
Cannot find module '$HOME\AppData\Roaming\npm\node_modules\bundlesize\index.js'
If the current behavior is a bug, please provide the steps to reproduce.
In the console enter npx bundlesize

My package.json contains this configuration:
...
  "bundlesize": [
    {
      "path": "./dist/*.*js",
      "maxSize": "40KB"
    }

What is the expected behavior?
Should generate a reported output to the console.
Please mention other relevant information.

node version: v10.14.2
npm version: v6.8.0
npx version: v6.8.0
Operating system: Windows 10
bundlesize version: 0.17.1
CI you are using None

Weird, can you verify this works:
npx cowsay hi

just to verify npx works correctly.


fix performance of very resource intensive test (#11204)

backport of https://github.com/arangodb/arangodb/pull/11204

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/8855/

Tests blue except false positive known failure on macOS.


Speed improvements and bug fixes for simplify-cfg.

Algorithmic changes

New worklist based algorithm for remove_dead_blocks
Cached predecessor counts for merge_blocks

Bugfix:

BlockContent::successors() was incorrect. It was returning successors for all blocks in the function.
Allow empty PHIs in to_block when merging blocks.

Performance
With this change, we now can compile the stdlib/vec test in about 35s (on my i7-7th-gen/32GB RAM laptop).
It was previously taking about 25m.
Testing
The stdlib/vec test's bytecode with this change is identical to the one without this change. The existing regression tests for simplify-cfg pass.
I've also enabled simplify-cfg optimization pass by default now.

Thanks for the quick review @otrho.


Create repo with notebook content to demonstrate nbgitpuller with base environment

Done: https://github.com/jsheunis/datalad-notebooks
And examples added to readme in 8162c29


multiple lines do not work in facebook.js

the large chat treats more than 2 consecutive line breaks the same and so the original number of breaks cannot be determined. The small chat comes out correctly but that means the line numbers do not match.
I do not see a way to tell how many linebreaks there should be without getting data from somewhere else.
If line numbers do not match then it might be confusing if they are used to talk about the code. I suggest making the small chat match with the large one.

At the moment I have updated facebook.js to treat multiple line breaks as a double line break so that the code will be rendered the same in both places.

So...done


Requirements.txt..?

Are you planning to somewhat push this to heroku? Not sure why you'd need requirements.txt.

I haven't intended for this project to be pushed to Heroku. Actually wasn't even totally sure what that is until I read this issue. The intention behind added requirements.txt was so that a user can have a list of dependencies and versions. For my own use, I create a Python Virtual Environment and then can use pip to install anything listed in requirements.txt. The benefit to this is a user does not need to install the dependencies system-wide or user-wide, where they may potentially conflict with others.
I may be wrong, but I think requirements.txt is also used by PyPi, which I may consider adding the project to in the future.
For example, in the current state of the project after cloning this repository, a user could run:
python3.6 -m venv .env
source .env/bin/activate
pip install -r requirements.txt

To create a virtual environment specific to this directory, activate it, then install all required packages into this directory. Everything self-contained without effecting the rest of the system. I suppose the requirements.txt could be used for Heroku or similar. It's original intent was for installing dependencies via pip.

No further responses back and no real discussion at this time. Closed.


[Compute] Fix #30009: az vm install-patches: Fix errors due to typos in install_patches function

Fix https://github.com/Azure/azure-cli/issues/30009
Related command
az vm install-patches
Description
Install_patches has paramerters with typos and throw the following error: Error given: kb_numbers_to_inclunde is not a known attribute of class <class 'azure.mgmt.compute.v2024_03_01.models._models_py3.WindowsParameters'> and will be ignored
exclude_kbs_requirig_reboot is not a known attribute of class <class 'azure.mgmt.compute.v2024_03_01.models._models_py3.WindowsParameters'> and will be ignored
Parameters should be kb_numbers_to_include and exclude_kbs_requiring_reboot respectively
Original pull request containing typos:
https://github.com/Azure/azure-cli/commit/3a5091e96092fa563e985df6b0339ba6ebc6ae66
Testing Guide
az vm install-patches --resource-group myResourceGroup --name myVM --maximum-duration PT4H --reboot-setting IfRequired
gives error:
kb_numbers_to_inclunde is not a known attribute of class <class 'azure.mgmt.compute.v2024_07_01.models._models_py3.WindowsParameters'> and will be ignored
exclude_kbs_requirig_reboot is not a known attribute of class <class 'azure.mgmt.compute.v2024_07_01.models._models_py3.WindowsParameters'> and will be ignored
History Notes
[Compute] Fix issue #30009 : az vm install-patches: fix errors

Compute

Updated title, team do we have any updates on this?

Please fix CI issues

Please fix CI issues

Hey Yonzhan, I went to rerun the pipelines but the build is expired, do I need to re-do my PR?

Please fix CI issues

Fixed

@Dxaz Could you please add some tests for these cases?

Please note that Azure CLI will have a code freeze at 10/29/2024 10:00 UTC for the upcoming release. Please resolve the comments ASAP if you want to catch the release train, otherwise the PR has to be postponed to next sprint (11-19).

@Dxaz Could you please resolve this CI issue?

Theres a specific issue with python 3.9.20. Let me investigate further.

unittest > case.py TestCase class has no assertNoLogs method in 3.9.20. So this testcase cannot be made for this scenario. Since the error in question for this PR is a log level warning thrown by azure.mgmt.compute._serialization.
I cannot make an assertion for this scenario in python 3.9.20. Any thoughts?

https://docs.python.org/3.9/library/unittest.html#unittest.TestCase.assertNotIsInstance

vs
https://docs.python.org/3.10/library/unittest.html#unittest.TestCase.assertNotIsInstance

Hello - We're keen to see this issue fixed. Since Azure Update Manager has been introduced we're using more of these CLI commands to manage patching operations. Our pipeline for Windows is on hold and using an older version is not a possibility as the typos have existed for too long.
Will this be released in November by chance???

@Dxaz Could you please resolve these comments and CI issues?

Hey Team, sorry for the delay, I will work on this asap

@zhoxing-ms updated the tests, now I'm just waiting for CI to run

@zhoxing-ms when you have an opportunity may you approve the changes, please?

/azp run


PF4 Select: Add the ability to  disable the component

The consumer should be able to disable the Select component similar to the Dropdown.

:tada: This issue has been resolved in version 2.26.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Code Refactor

I cleaned up the code a bit (mostly based on the ueberauth_github with some nuances, and in my opinion the code is more readable now.
Also I added the Ueberauth serializer by default if none were given and updated the Readme, which was what was broken in the first hand.
@markusherzog it would be nice if you bumped the version up, and updated it in the hex packet manager (and then change the Readme too heh).
Thanks a lot for building this, I hope this helps!

Perfect, thanks!


Update to 5.0?

As in the title. Is this setup safe to update to 5.0? Can I just change the pihole/pihole:v4.4-armel to 5.0? Or is their an incompatibility issue causing trouble with the newest version?

It's safe to upgrade, I tested it on my devices and updated this project to v5.0 last week.
Thanks for checking out the project!

Oh, guess I didn't see that. Thanks!


TypeError: 'NoneType' object is not iterable since v0.0.13

Hi,
Since version: [v0.0.13], I'm getting
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/app/app/deleterr.py", line 745, in <module>
    main()
  File "/app/app/deleterr.py", line 741, in main
    Deleterr(config)
  File "/app/app/deleterr.py", line 64, in __init__
    self.process_radarr()
  File "/app/app/deleterr.py", line 212, in process_radarr
    if not library_meets_disk_space_threshold(library, radarr):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/app/deleterr.py", line 697, in library_meets_disk_space_threshold
    for item in library.get("disk_size_threshold"):
TypeError: 'NoneType' object is not iterable
1

Seems to be related to the new disk_size_threshold function. I have not set this up in the config file.
Any other details needed; let me know.

Ouch. What an oversight, fixing this quickly

Done! Please point your image to v0.0.14!


bans not always pushing through

So if i ban someone it pushes through but if i ban someone else within like a hour or a bit more from the first ban the new  ban is not synced at all.  ive tried reinstalling the bot re setting it up making a new bot etc nothing changes and ive been wondering if you have any tips on how to fix it

ill try reinstalling it again

no it throws this error in the longs i normally have it running via cron so i never get to see these errors
[2023-08-01 23:06:26] ERROR: Invalid Form Body
delete_message_seconds[NUMBER_TYPE_MAX]: int value should be less than or equal to 604800.
err: {
"type": "DiscordAPIError",
"message": "Invalid Form Body\ndelete_message_seconds[NUMBER_TYPE_MAX]: int value should be less than or equal to 604800.",
"stack":
DiscordAPIError[50035]: Invalid Form Body
delete_message_seconds[NUMBER_TYPE_MAX]: int value should be less than or equal to 604800.
at handleErrors (/root/discord-ban-sync/node_modules/.pnpm/@discordjs+rest@1.7.1/node_modules/@discordjs/rest/src/lib/handlers/Shared.ts:152:10)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at SequentialHandler.runRequest (/root/discord-ban-sync/node_modules/.pnpm/@discordjs+rest@1.7.1/node_modules/@discordjs/rest/src/lib/handlers/SequentialHandler.ts:399:20)
at SequentialHandler.queueRequest (/root/discord-ban-sync/node_modules/.pnpm/@discordjs+rest@1.7.1/node_modules/@discordjs/rest/src/lib/handlers/SequentialHandler.ts:169:11)
at REST.request (/root/discord-ban-sync/node_modules/.pnpm/@discordjs+rest@1.7.1/node_modules/@discordjs/rest/src/lib/REST.ts:343:20)
at async GuildBanManager.create (/root/discord-ban-sync/node_modules/.pnpm/discord.js@14.11.0/node_modules/discord.js/src/managers/GuildBanManager.js:169:5)
at BanQueue.#banUser (/root/discord-ban-sync/src/structures/banQueue.ts:120:4)
at BanQueue.#processQueue (/root/discord-ban-sync/src/structures/banQueue.ts:76:22)
"requestBody": {
"json": {
"delete_message_seconds":<PHONE_NUMBER>
}
},
"rawError": {
"type": "Object",
"message": "Invalid Form Body",
"stack":
    "code": 50035,
    "errors": {
      "delete_message_seconds": {
        "_errors": [
          {
            "code": "NUMBER_TYPE_MAX",
            "message": "int value should be less than or equal to 604800."
          }
        ]
      }
    }
  },
  "code": 50035,
  "status": 400,
  "method": "PUT",
  "url": "https://discord.com/api/v10/guilds/1079879376558100490/bans/823631422514004028"
}

[2023-08-01 23:06:26] INFO: Processed 0 actions for<PHONE_NUMBER>14004028

NVM reinstall fixed it it did not like 1 as a delete ammount.  we are good


derive/impl Debug for a few data structures

I found this to be extremely useful while trying to write a wrapper on
top of cargo.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

The travis error looks bogus -- not sure how to restart the job though.

:pushpin: Commit 876af7c has been approved by alexcrichton

@bors: r+
Thanks!

:hourglass: Testing commit 876af7c1d66637caf0141446e746e73708e53fe7 with merge ffc3419bd1c8af9b5699e5170a1161612738d264...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ffc3419bd1c8af9b5699e5170a1161612738d264 to master...


add puclic src

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
0

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0

Metric
Value

alert_status
:x: ERROR

bugs
1

code_smells
0

reliability_rating
C (at least 1 Major Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


Add pointerEvents: none to left/right sides.

Without this change, if the zIndex of the waves is higher than the zIndex of the regions, the waves will stand out better but block the resize controls.
(Figured out how to do two files at once.)

Nice idea!

@agamemnus can you also add this to the documentation?

Ok, in a bit. By the way, what is the plan for merging changes into next?

On Jun 11, 2017 10:23 AM, "Thijs Triemstra"<EMAIL_ADDRESS>wrote:

Merged #1112 https://github.com/katspaugh/wavesurfer.js/pull/1112.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/katspaugh/wavesurfer.js/pull/1112#event-1118539755,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADFJWOSqDJKxQiJQ_57ciIJxpIfh9MEKks5sC_hVgaJpZM4NvNGS
.

I'm not sure where I'd add it since it's not an option.


Verification

I am a passionate bitcoiner from Colombia and I would love to attend for the first time the Bitcoin Conference!
I have recently contributed as a translator to the Damus app in Latin American Spanish. Terry Yiu from the Damus developer team can vouch for me. Please see his nostr note here (part of a conversation with Matt O'Dell):
note146hgj7568y9cda6rk2wdlxajsvwng2793lf7mrjlem099gcq73zq6g8g5t
https://brb.io/n/aeae897a9a390b86f743b29cdf9bb2831d342bc58fd3ed8e5fcede52a300f444
I am also part of the Bitcoin Core translation team currently working on the Colombian Spanish localization.
Thanks!

To whom it may concern,
I hereby confirm that BitByBit is a member of the Bitcoin.org translation team who is actively contributing to our Spanish translation/localization efforts.
George Glosson
Bitcoin.org Translation Team Coordinator


Remove use of "-T" for docker-compose exec interactive use

Purpose / why
I was doing some testing and noticed that line 27 in docker-maintain-drupal.md is using the -T flag for docker-compose exec which would not allow for interactive shell use as expected.
From the man page...
Usage:  docker compose exec [options] [-e KEY=VAL...] [--] SERVICE COMMAND [ARGS...]
...
  -T, --no-TTY docker compose exec   Disable pseudo-TTY allocation. By default docker compose exec allocates a TTY.
...

Seem that on the other examples of docker-compose exec -T... are fine on the rest of the page, since they are executing non-interactive/specific shell commands.
What changes were made?
In line 27 I removed use of the "-T" flag, and a few lines before suggested that this flag be removed for interactive use.
Verification
Run docker-compose exec drupal with-contenv bash and watch it trigger an interactive shell.
Then run docker-compose exec drupal with-contenv bash and watch the terminal hang waiting for bash to exit.
Interested Parties
@Islandora/documentation
@Islandora/committers
Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:

[ ] Does this PR link to related issues?
[ ] Does the proposed documentation align with the Islandora Documentation Style Guide?
[ ] Are the changes accurate, useful, free of typos, etc?

Person Merging
The person merging should ensure the following:

[ ] Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
[ ] If pages are renamed or removed, have all internal links to those pages been fixed?
[ ] If pages are added, have they been linked to or placed in the menu?
[ ] Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Looks good to me! :shipit:


Acknowledge Packet Proof

Recv Packet can be correctly verified, but there is some issue with proof for acknowledgePacket.

This was because of a line missing on the ICON smart contracts. This was fixed in the 808-investigate-commitment-prefix-usage-in-ibc-java branch, the branch to support hopchain,


Fix - crash for proxied receive

#8693djk9c
We dont need to use public key here

Task linked: CU-8693djk9c Android. Fix QR format for proxied accounts


define should not modify string

Describe the bug
The define configuration modifies the content of the string in the code
Reproduction
https://github.com/eightHundreds/vite-define-bug-demo
Steps to reproduce
// src/index.ts
const a = {
    'content/vite.config.ts': {
        type: 'Txt',
        data: "'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV)",
    },
};
console.log(a)

// vite.config.ts
import { defineConfig } from 'vite'

export default defineConfig({
    define: {
        'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
    },
})

Expected result: change nothing
Actual result:

System Info
System:
    OS: Linux 5.4 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (2) x64 Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
    Memory: 1.89 GB / 3.84 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 19.9.0 - ~/nvm/current/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 9.6.3 - ~/nvm/current/bin/npm
  npmPackages:
    vite: ^4.3.9 => 4.3.9

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I tried esbuild, it works fine


[Bug]: missing test job for DockerCopy job

Describe the bug
As part of the effort on META https://github.com/opensearch-project/opensearch-build/issues/1468 , we are adding missing test job for jenkinsfile(s).
Particularly, this issue is created to address missing test job for docker-copy.jenkinsfile
To reproduce
We currently do no have test job under /test/jenkins directory to test docker-copy.jenkinsfile
Expected behavior
Adding test job at /test/jenkins directory and its corresponding .txt regression file
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

this issue #2791 is closed now because PR #2792 is merged


5-Add-writing-to-and-reading-from-file-for-NgramModel

added functionality to save ngram model results to respective files

Writing to file works great. With reading from file, while you get a correctly represented ngram model, which you can inspect to see the same ngramCounts, historyCounts and vocabulary values as they were originally, you cannot however perform actions such as finding the probability of a particular ngram, because neither the order nor the smoothing technique are known. So this PR is still WIP and I would say the functionality to read and write order/smoothing should also be added in order to be able to properly use the ngram model one reads from file. cc: @olekscode

Another thing would be to figure out how to best set up testing writing and reading from file, as it would not be ideal to have greatly decreased test coverage after this PR.


[Embeddingapi] Modify xwalkview creation on embedding cases

-creation of XWalkView should be put in onCreate()
-Cover embeddingapi sync & async autocase
Impacted tests(approved): new 0, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 44, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-4451

@jennycao please help to review it.
Thanks.

LGTM


Add StarMade Module

This adds StarMade Windows and Linux support. Currently all settings are managed in a single file with 188 settings. Once AutoMap receives new features to specify partial settings this will be added to the module as well.

Test comment to check discord integration.

Instead of calling it "Maximum RAM" - please refer to it as the Java heap size. Otherwise it can be misleading.

Thanks for the recommendation. I've mirrored the other modules and submitted the change.


storage and loading of intermediate data test

get anchor transactions from different addresses test
more events

Coverage increased (+0.3%) to 94.97% when pulling dca38c6263e7b988ba9c5b450586efc0c2d51393 on just_checks into a49029908646fdf34ce7a11263bc02295ecf3627 on master.


Option for user to toggle off/on sound

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
A need to add a sound button to toggle off/on all sound. I have worked on it, and I am a SWOC contributor.
Screenshots

Code of Conduct

[X] I follow Contributing Guidelines of this project.

This issue already exist. Pls  work on other issues @cryptocat8


Warning messages about structure agreement

The dataset I tried formatted correctly on the first try, which was very exciting! I did get the following warning message:
About 76.82% of the wildtype residues in the data match the corresponding residues in the structure.
About 23.18% of the data sites are missing from the structure.

It seems like the wildtype residues that don't match are very likely to be the missing ones. I think it would be more informative to make two changes:

Don't count "missing in the structure" as a lack of agreement, since this implies that there's a mismatch between my experimental wildtype sequence and the structure sequence rather than no data.
Give numbers in parentheses in addition to the percentages. For example, it would have been nicer to see About 76.82% (123 of 456) of the wildtype residues...

This issue is part of https://github.com/openjournals/joss-reviews/issues/6129

Fixed!


Tweak servo duty cycles

duty cycle for steering center - 105
duty cycle for steering left - 70 or 140 (gotta test to figure out which)
duty cycle for steering left - 70 or 140 (gotta test to figure out which)

Fixed


Flexible encoding

When nodes establish communication, they should agree on what encoding they will use to pass messages. This can be done in a similar manner to the choice of signature algorithm.

This may introduce some vulnerability; it's possible that some encoding algorithms will be more susceptible to attack than others. The data is decoded before being passed to the state, so a broken encoder won't allow an attacker to break consensus too. But a particular algorithm might be more susceptible to, e.g., DOS attacks. As a simple example, encoders that use compression need some way to safeguard against zip bombs. This gets worrisome when you realize that every implementation that wants to support compression needs to implement this safeguard.
Another crazy thought: nodes could charge you just to communicate with them. The encoding algorithm would initiate each communication by requesting payment to a specific address. They could even bill proportionally to the message size...not unlike a lawyer.

I do think that the final destination for talking is going to be with micropayment channel charging. You'll pay nodes that relay you blocks, and miners will pay nodes that relay transactions with fees.
I forgot about problems like zip bombs in the encoding scheme. I would imagine though there are existing libraries to manage encrypted and compressed network communications which protect against all forms transfer-level attacks such as zip bombs.


Infection Bug Fixes

Changes

Prevent making a second Infected if a player joins mid-match and is selected to become the first Infected.
Change highlighting to use sonar status effect instead. This lets the last player know that they are visible through walls and the sonar will persist when they enter a Titan.

P.S.
Besides that, would anyone be interested in the rework suggested in R2Northstar/Northstar/discussions/161?  There's a server hosted by Bobbyperson called [US-East] awesome infection server | no out of bounds allowed
The rework is basically:

Make players spawn using FFA spawnpoints so they don't group up at the start of the match.
A dropship spawns near the end of the time limit (around 25%) which forces survivors to get out of hiding. (especially campy vertical/out of bounds spots).
Win/Loss is now decided by whether a survivor makes it to the evacuation ship (It's not considered epilogue).

Playing sonar effect on last survivor is good idea btw :D

Regarding the experimental changes and server running it I suggest dropping a ping in #playtesters-ping when there's a bunch of players online. I like them personally but I'd suggest some playtesting with feedback gathering afterwards to make sure others agree on it as well ^^

Didn't get to it anymore today. Will (hopefully) look at it tomorrow. If this PR is still without review in few days, please re-ping me cause there's a decent chance that means I forgo ^^"


[#3835] Fixed NoClassDefFoundError error

Fixed error when  headers method not exists.

Codecov Report

Merging #4547 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4547      +/-   ##
==========================================
- Coverage   40.45%   40.42%   -0.03%
==========================================
  Files        2509     2509
  Lines       76410    76437      +27
  Branches    10391    10395       +4
==========================================
- Hits        30912    30903       -9
- Misses      42663    42700      +37
+ Partials     2835     2834       -1

Impacted Files
Coverage Δ

...terceptor/ConsumerRecordEntryPointInterceptor.java
0% <0%> (ø)
:arrow_up:

...gin/kafka/interceptor/ProducerSendInterceptor.java
0% <0%> (ø)
:arrow_up:

...rp/pinpoint/rpc/packet/ControlHandshakePacket.java
51.51% <0%> (-24.25%)
:arrow_down:

...pinpoint/profiler/instrument/AccessorAnalyzer.java
57.14% <0%> (-8.58%)
:arrow_down:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
72.11% <0%> (ø)
:arrow_up:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.55% <0%> (+0.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a130df7...9d2fefc. Read the comment docs.


some centroids in untiled geojson are not being in small polygons

TO REPRODUCE THE ISSUE, FOLLOW THESE STEPS:
https://mapzen.com/tangram/play/?scene=https://mapzen.com/api/scenes/22/500/resources/scene.yaml#16.52087/37.81997/-122.36418
importing https://gist.githubusercontent.com/burritojustice/f38381ce0dba2ce1908a79b67f1acea9/raw/87bb631aaf286dbdf577512f98a23eb5306c5bde/TI_1939_all.geojson
RESULT:
some label centroids generated by generate_label_centroids: true are far outside their polygons, generally to the east
EXPECTED RESULT:
centroids should be in the center
ENVIRONMENT:
Chrome 57.0.2987.133, Safari Version 10.1 (126<IP_ADDRESS>.34), Tangram Play, Tangram View
OTHER:
Any additional notes, comments, tips, tricks, gifs, suggestions, poetry, recipes, jokes

Turns out this was a precision problem: some small polygons were exceeding the floating point precision because of very small intermediate values.
Fixed in 35d4982ca7af89c46cd50cae3492cd5bc13a15f4.
@matteblair should look at this in ES too?

Release in v0.12.2

Actually, I think tangram-es doesn't implement generate_label_centroids yet - I'll create an issue if there isn't one already.


[BN][Navi21] #undef __AMDGCN__ means UB

#undef __... should NOT be used in kernels.

This change leads to undefined behavior. We shouldn't undef macros predefined by the compiler.
Originally posted by @atamazov in https://github.com/ROCmSoftwarePlatform/MIOpen/pull/493#r671445106

Another place: https://github.com/ROCmSoftwarePlatform/MIOpen/blob/00d57548c25399186eb201eb2e0e6f7480915c48/src/kernels/batchnorm_functions.h#L134-L136

#undef __... should NOT be used in kernels.
This change leads to undefined behavior. We shouldn't undef macros predefined by compiler.
Originally posted by @atamazov in #493 (comment)

Do we have a ticket tracking this issue?

Another place:
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/00d57548c25399186eb201eb2e0e6f7480915c48/src/kernels/batchnorm_functions.h#L134-L136

Do push_macro and pop_macro work?
// file head
#pragma push_macro("__AMDGCN__")
#undef __AMDGCN__

// content

//file end
#pragma pop_macro("__AMDGCN__")

Yikes, it is already in a header file and doubled in many files mentioned above.
we need some clean up work on Batch Norm kernel code, suggestion:

If every batch norm kernels have batchnorm_functions.h included at the very top of file, and all of them need this macro from compiler to be undefined: then generate another restore_batchnorm_macros.h and include them at the bottom of all of the files. prone to errors, ugly, and some personal dislikes

Move it out of header file, I think it should not be there in the first place. Do the push and pop in individual files if you have to.

@muralinr could you help to check if the above may work? Or with Artem for a full blown solution? Thanks!

@junliume Sure Jun.  Let me work with Artem.

Do push_macro and pop_macro work?

It may work (and most likely will) but this is UB anyway, because there is #undef still.
Recommendation:
#ifdef __AMDGCN__
#define MIOPEN_USE_AMDGCN 1
#endif
...
if <something>
#undef MIOPEN_USE_AMDGCN
#define MIOPEN_USE_AMDGCN 0
#endif
...
// now use "#if MIOPEN_USE_AMDGCN" instead of "#ifdef __AMDGCN__".

via #1037


638 Breadth-First Search (BFS) algorithm

Closes #193

@anyzelman I would like a first review about the algorithms themselves

Depends on #211

TODOs:

[ ] remove utils functions
[ ] add dispatcher that uses the enum
[ ] use foldl instead of eWiseApply
[ ] resolve conflicts & review


Policy Reporter no longer working after kyverno 1.11.0 upgrade

kyverno app version: 1.12.0
policy reporter chart version: 2.21.2
Policy Reports are now created on a per-resource basis and using a UID as the name rather than the previous behavior of per-policy. This may be a breaking change if you relied upon either of these attributes in previous versions. This change has the benefit of putting less pressure on the Kubernetes API server and less storage cost on etcd.
Meanwhile, policy reporter cannot get new policy reports name but only fetch report UID in prometheus metrics, as below

We may need to fetch name in owner reference or scope.name

Hey, can you please try to upgrade to PolicyReporter >= v2.21.3
This version fixed an issue with resource mapping which leaded to empty resource values like name, kind, etc.
https://github.com/kyverno/policy-reporter/blob/main/CHANGELOG.md#2213

2.21.3 works, thanks!


[ADDED] RX671 projects and driver code

RX671 support
Description

Added RX671 demo, test project
RDP v129, WIFI_v1.11

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@VanNamDinh @xuan97z1 Thank you for developing. Let's keep discussing for we should use git-submodule for RX Driver Package referring
from: https://github.com/aws/amazon-freertos/tree/main/vendors/renesas/rx_driver_package
to: https://github.com/renesas/rx-driver-package
This is future request from me. Thank you.


Add Experimental attribute to all public APIs in the OpenAI.Assistants namespace

This PR adds the [Experimental("OPENAI001")] attribute to all public APIs in the OpenAI.Assistants namespace.
Check out the API View for all public APIs in OpenAI.Assistants here.

Could you add an update to the CHANGELOG? Under "Other changes" you can say something simple like:
"Added the ExperimentalAttribute to every public API in the OpenAI.Assistants namespace".


bump runtime version

Coverage remained the same at 34.746% when pulling 24f5728e5a2c4c24e9d8e563223338ad54bae533 on binyli/bump_version into 4417236c9f8b885038e7118676622fe6ea243cb1 on master.


[QUESTION]

Prerequisites

[ ] Have read and understood: https://github.com/Maatwebsite/Laravel-Excel/blob/3.1/.github/SUPPORT.md
[ ] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[ ] Checked that your question isn't already asked before.
[ ] Filled in the entire issue template

Versions

PHP version: 7.2
Laravel version:5.6
Package version: 3.1

Description

I can limit the reading of the file, I need to read only the first 10 lines, the file has more than 10,000. Is it possible to limit the reading of lines for the file to be faster?
I need to read only the first 10
Thank you

Can you show what you tried?

In Controller
$import = new EcadImportRow;
Excel::import($import,$filePath);
return  $import->allRows();
Imports
class EcadImportRow implements WithMappedCells, ToModel
{
private $data;
public function mapping(): array
{
return [
'data'  => 'A2',
];
}
public function model(array $row)
{
	$this->data=$row;

}

public function allRows()
{
	return $this->data;

}

}

shows the page load time
$start = microtime(TRUE);
$end = microtime(TRUE);
echo "The code took " . ($end - $start) . " seconds to complete.";

The code took 4.9688370227814 seconds to complete.{"data":"01/12/2019"}
Import must be slow all 9,566 lines

Is there a reason why you open a new issue for the same question? #2658

I'll finish # 2658

I think currently we don't have a readfilter to deal with only reading cells like PhpSpreadsheet docs show: https://phpspreadsheet.readthedocs.io/en/latest/topics/reading-files/  Reading Only Specific Columns and Rows from a File (Read Filters)
Feel free to PR that as addition to the mapped reader.

@patrickbrouwers  I cleaned the code, but I need to get some values from certain columns, as the file is large,I don't need to do all the reading of the file, in the application it gets very slow,
I will study the indicated documentation, thankful


Add diagrams to Notes section in DeveloperGuide.

Changes to the DeveloperGuide:

Added and integrated Note-related diagrams
Added View vs ViewRaw command implementation
Standardized use of 'Expected output:' in DeveloperGuide

Refactored:

getAddressBook() in LogicManager

Looks good!


Bump golang 1.16

Depends-on: #183

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.734%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
444

Relevant Lines:
1090

💛  - Coveralls


Icon order changed again in Patch 10.1.5 (Fractures In Time)

Hi there,
I hope you have recovered and you're well for now, Shushuda.
Just wanted to report that the latest minor patch 10.1.5 brought some new minimap icons and it scrambled the blip map once again. I see a new type of exclamation / question mark with pink background maybe that mixed up the order. Would you take a look if you have some time, please.
Thank you and good health to you!

Hello!
Sadly, I'm not recovered. I'm actually even worse than I was. I'm on a break from WoW because of that.
Thanks for the report! I will fix this soon, maybe this weekend. I won't test it, but it's just a texture, so it should be fine.
Thank you for the good wishes!

How could this be you're even worse, Weronika? Are you still in the hospital for a half year?
I thought medical treatment is above World average in Germany. You're in Germany afaik, or you live in Austria? Österreich is even better I heard of. If you'd live here in Hungary it would be normal to circulating in the health care system for years but ....
Anyway, I'm pretty glad you're looking into this new bug and I still wish you a speedy recovery!

After resizing the mini map, it makes the quest icons on the mini map really larhe, went into mappy options clicked on smaller nodes, and it reduced the size for quest icons down to a more normal size, but changes them to what voxxel reported, maybe add a option to changed icon sizes if possible when you are feeling better

I'm not at the hospital, but I'm practically home bound. I have occipital neuralgia and regular treatment such as steroid nerve blocks make it worse instead of better. Other treatments, such as physical therapy, stretching and exercise, started helping a bit only very recently. The stretching and exercise part I was unable to do for half a year due to worsening of symptoms, but now I can do like 3 kinds of stretches without becoming worse, so progress I guess. I'm in Poland and I do everything privately because queues are horrible for the public health care.
Thank you for good wishes. Thankfully I didn't cancel the sub so I can always log in and do some debugging for the addon.
As for the resizing, if I remember correctly, both Blizzard's native option and addons use the same function - SetScale(). This enlarges everything as once - border, minimap bg, icons. Changing the icon size in Mappy is done by manually creating a texture map with smaller icons in Photoshop and replacing the in-game texture map with this addon one. I think I remember researching if this can be done dynamically and didn't find an answer. I think the Mappy's scale option still works the same as the one baked into Edit Mode, but I will recheck.
I will fix the textures this weekend, it should make the icons look normal with all Mappy options, sizes, blinking and whatnot. Keep in mind those are for gathering nodes only. Other icons will stay the same size. I could reduce them all, but that'd require quite a bit of manual editing in Photoshop. It is something doable tho.

I read after the occipital neuralgia and they say it could be very painful and long lasting. There are quite a lot patients who were able to ease the pain with intelligent neck massager devices, such like this: https://youtu.be/Mpo7K3P0Vls . You probably already tried it but wanted to share it with you either way.
I'm looking forward for the new version with the fixed icon map so I can test it right off.

Hi there,
Any update on this?

Just adding that this is still, unfortunately, an issue. Any news on a forthcoming update would be very much appreciated - but i understand if it may not be coming soon.

Hey, sorry it took so long. I've uploaded the new release just now and will upload it to Curseforge in the next 30 minutes or so.

Hi Weronika! Thank you! I hope you're doing well.

I hope the next major patch 10.2 which is around the corner ( nov. 7) won't change the blip order once again. I'll try to test it on the PTR.

Oh it definitely will. Fixing the addon did make me want to set up WoW again and play, so I guess I will be fixing it a lot faster this time, hahah!
As for my health, I'll be honest - it's worse than it was. I don't know what to do, so might as well try to occupy myself with the new patch. Such is life.

I'll preface that i am by no means an experienced programmer, but if you'd like - at some point in the future if you walk me through your process for updating/fixing this issue, I could start submitting PRs to handle this for times when you're otherwise drowning in real life obligations.

Ah, the textures themselves are quite easy, it's purely Photoshop work. It's just time consuming and tedious. I really appreciate the offer! The 10.2 patch should be fine, I will be taking a 2 week PTO around the same time so I should be able to fix it much quicker this time.
Here's what I do to fix the textures, I use two programs for it + a graphic program to modify the textures (I have Photoshop so that's what I use):

Extract the current minimap blip texture with wow.export program. It's called ObjectIconsAtlas.blp.
Convert the texture from .blp to .png with BLPNG Converter program.
Modify the texture based on the ones that got outdated. There are a few texture files with very specific names (case sensitive) that are used by the addon, they all need to be replaced with updated ones - all based on that one single ObjectIconsAtlas. They're all possible option combinations for modifying those blip icons. I try to keep them pixel perfect, as in align them exactly the same.
After creating those new files, save them as .png into Artwork folder in the addon.
Use BLPNG Converter program to convert them all into .blp.
Put those .blp files into Textures folder in the addon.
Done.

The newest commit which replaces these textures should make this explanation a bit clearer.
As for Lua errors (so far so good but you never know), that's just Lua programming combined with traversing through Wowpedia to figure out Blizz-specific functions and whatnot.


Use @iptv/playlist to generate M3U files in a typesafe way

We recently converted our XMLTV generation over to use the @iptv/xmltv library which offers typesafe and fast xmltv generation. They also include a similar library for generating (and parsing) m3u files, https://github.com/ektotv/playlist. We can use this to build m3us without relying on the very gnarly string concatenation we are doing today.

Ended up forking this because I had to make quite a few changes: https://github.com/chrisbenincasa/playlist


How can I ignore specific API routes from being logged?

Hi! Awesome module, thanks!
I have a question though. I've got a Nest.js application and here's my main.ts file:
import { NestFactory } from '@nestjs/core';
import { AppModule } from './app.module';
import { Logger } from 'nestjs-pino/dist';

async function bootstrap() {
  process.env.NODE_ENV = process.env.NODE_ENV || 'DEV';
  const app = await NestFactory.create(AppModule, {logger: false});
  app.useLogger(app.get(Logger));
  await app.listen(process.env.PORT || 3000);
}
bootstrap();

After I set app.useLogger(...) I can see all the requests coming into the app in stdout. However I have a health check endpoint, which I'd like to prevent from being logged. How can I achieve it with this module?
Thanks in advance.

Hello, thanks!
The feature of logging req/res is working on top of pino-http, it pass options to this module, and it seems like there is no such option to exclude some routes 🤷♂
But, I just looked, and I think this can be done on this side. I'll keep this issue open, and will return to it in next few weeks.
By the way, any help is welcome. I think the best way to solve it is by providing optional parameters forRoutes and exclude, that could be used here

Hi! Done in v1.0.0
Use npm install nestjs-pino@latest and see migration details

Amazing, thanks! Will check it out ASAP.


cocoapods: add meta.mainProgram

Description of changes

Moved files from pkgs/development/mobile to pkgs/development/tools since cocoapods isn't just used for mobile development.

Added meta.mainProgram so that this package works with nix run.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

~/C/nixpkgs on cocoapods-mainProgram
❯ nix run .#cocoapods -- --version
[DEPRECATED] This Gemfile does not include an explicit global source. Not using an explicit global source may result in a different lockfile being generated depending on the gems you have installed locally before bundler is run. Instead, define a global source in your Gemfile like this: source "https://rubygems.org".
1.11.0


Add "generic" services to services dropdown.

Lights do not (any more) offer domain specific services to turn them on or off. They rely on generic services that are available for entities of all domains:
homeassistant.turn_on - Turns on an entity (that supports being turned on), for example an automation, switch, etc.
homeassistant.turn_off - Turns off an entity (that supports being turned off), for example an automation, switch, etc.
homeassistant.toggle - Turns off an entity that is on, or turns on an entity that is off (that supports being turned on and off)
homeassistant.update_entity - Request the update of an entity, rather than waiting for the next scheduled update, for example Google travel time sensor, a template sensor, or a light
Add those services to every entity.

Never mind.


Typed arrays should be classes.

Hi guys,
The following code is valid in JavaScript.
class Matrix extends Float32Array {
    constructor() {
        super(9);
    }
}

Unfortunately that isn't possible to do in TypeScript at the moment because all of the typed arrays appear to be interfaces, and there are also some weird interfaces such as Float32ArrayConstructor floating around which confuse matters.

Dup of #1168

In that case, consider this issue a friendly reminder that the seven month old bug still exists :)

It's on the roadmap for TypeScript 1.6.


unable to predict from load previous model

Hello, I train a data set and store it into other folder. (in index.js)
After that, I  create a file called predict.js, main code is like:
var persistedModel = JSON.parse(fs.readFileSync('./model/poker_sim_test.json'));
var clf = new svm.NuSVC({ model: persistedModel });
var prediction = clf.predict(guess);
when I run it I face a problem that:
assert.js:89
throw new assert.AssertionError({
^
AssertionError: false == true
at NuSVC.SVM.predict (/Users/ives/Downloads/SVM_PokerHand/node_modules/node-svm/lib/core/svm.js:147:5)
How can I fix problems.
Thanks!!

To restore an existing prediction model you should use  svm.restore function.
Example:
var svm = require('node-svm');
var persistedModel = JSON.parse(fs.readFileSync('./model/poker_sim_test.json'));
 var clf = svm.restore(persistedModel);

BR

Thank you but I still face this...
assert.js:89
throw new assert.AssertionError({
^
AssertionError: false == true
at NuSVC.SVM.predict (/Users/ives/Downloads/SVM_PokerHand/node_modules/node-svm/lib/core/svm.js:147:5)
Thanks!!

my test code is here, train and predict in a js file.

Try this instead:
nodesvm.read(pathToTrainingData).then(function (dataset) {
    var clf = new nodesvm.NU_SVC({
            kFold: 4,
            normalize: false,
            reduce: false,
            kernelType: 'RBF',
            gamma: [0.03125, 0.125, 0.5, 2, 8]
      });
      clf.train(dataset).spread(function (model, report) {
            fs.writeFileSync('./model/poker_sim_test.json', JSON.stringify(model));
      }).then(function(){
            var persistedModel = JSON.parse(fs.readFileSync('./model/poker_sim_test.json'));
            var restoredClf = nodesvm.restore(persistedModel);
            restoredClf.predictSync([4, 10, 4, 11, 4, 1, 4, 13, 4, 12]);
      });
});

It seems to appear another error
Assertion failed: (elt->IsNumber()), function setModel, file ../src/node-svm/node-svm.h, line 229.
Abort trap: 6
my dataset is like this:
9 1:1 2:10 3:1 4:11 5:1 6:13 7:1 8:12 9:1 10:1
.
.
.
sorry for bothering
Thanks!

seem this error comes from your dataset but I can't help you with that...

Hello I can use the model from external file latter.
I originally use this and it can generate a model but can't predict as above discussion.
Latter I create a model file by 'node-svm train [train file] [model path]'.
And I use the sane dataset and the same prediction code, then everything works.
FYI
thank you!!!

Thank you for your feedback!
BR


可以设置状态栏的Drawable颜色？

改变状态栏的颜色和drawable颜色有什么区别？
Sent from Mail Master
在2017年05月13日 11:57，52932 写道：
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/niorgai/StatusBarCompat","title":"niorgai/StatusBarCompat","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/niorgai/StatusBarCompat"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"可以设置状态栏的Drawable颜色？ (#23)"}],"action":{"name":"View Issue","url":"https://github.com/niorgai/StatusBarCompat/issues/23"}}}


Add jq for must-gather

Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-3640
What this PR does / why we need it:
Similar to #3037 but uses go-jq which is in the e2e tools instead of downloading from gh-actions.
Test plan for issue:
Will cause a run to fail to test
Is there any documentation that needs to be updated for this PR?
N/A

Failed run artifact: https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=76820965&view=artifacts&pathAsName=false&type=publishedArtifacts

Nice! In case there's a way to re-use this, I wanted to mention that we're also downloading jq in this pipeline: https://github.com/Azure/ARO-RP/blob/master/.pipelines/templates/template-clean-subscription.yml

@cadenmarchese I've added that there, now -- what do you think?


NetApp Solifire exporter

Added link to NetApp Solidfire exporter

Thanks for sharing. Your exporter has secrets on the command line which is insecure, please fix this.
In terms of general comments to help improve the exporter:
I'd suggest failing the scrape when there's an error rather than making the user have to check an additional metric.
Several of the types seem off. For example node_name is an info metric and should thus be a Gauge and be called node_info. node_total_memory_gb is a gauge, and should not duplicate all the labels that are on the info metric.
drives_status looks like it might be a enum - I presume the status can change over time? In which case have a series per potential status with a 1 for the current status and 0 for the rest. drives_capacity should not have a status label, as it'll break things every time the status changes.
cluster_node_stats_mbytes_in sounds like a counter rather than a gauge, and should thus also end in _total.
For cluster_node_stats_load_histogram there's no need to mention histogram in the metric name and it's not clear what the unit (if any) is.
For cluster_node_stats_count _count indicates part of a summary/histogram so should be avoided as a suffix for gauges.
For cluster_node_stats_cpu_total_seconds total and seconds should be the other way around.
For the various threshold metrics, threshold should be at the end of the metric name. The general idea is that if all the metrics were sorted, the related metrics would be together so the threshold would be near the thing it's a threshold for.

Bytes are also the base unit that should be used rather than a mix of megabytes (or is that millibits?) and gigabytes, microseconds&milliseconds should be seconds, and percentages to ratios (presuming that the raw data isn't available for PromQL to calculate the ratio itself - in which case don't expose the ratio). For cluster_node_stats_read_latency_usec_total the metric name and help disagree about what the unit is. cluster_node_stats_used_memory is missing a unit.
cluster_stats_utilization - it's not clear what this is the utilisation of.

Thanks Brian for the detailed review. Appreciate it.
ill review and make the necessary improvements.

@brian-brazil @beorn7 - we've implemented the recommended fixes and improvements over the past few months. Let us know if there are other changes required before solidfire-exporter can be added to this list.
Thanks

Bump @beorn7

I'm not a qualified reviewer for this.
@RichiH could you make a call here? Or delegate as you see fit.


[question] How lumberjack works when there is a shutdown ?

Hello,
For my application, I use "lumberjack.v2" with zerolog on Linux embedded system.
Sometime, my application needs to shutdown the system.
In this case, how can I ensure that my log files are not corrupted?
How does it work when the Linux stop command is executed?
In my application, how can I block writing and know when current writes are finished?
Also, how can I do when power supply stops?

Looks like you want some way to call Sync() on the file or open the file with O_SYNC.


Backport Poise's shell_out helper?

Opening this for discussion as to if this belongs in Chef or Mixlib-ShellOut.
In Poise I wrote a helper (https://github.com/poise/poise/blob/master/lib/poise/utils/shell_out.rb) for Chef's shell_out[!] which makes sure to populate the $HOME, $USER and $LOGNAME environment variables, as well as on Unix setting the group if a user if given (and a group isn't). All of these are overwhelmingly the expected behavior for execute and its subclasses, and I would say should be the standard behavior for Mixlib-ShellOut in general but that might be a bridge too far. What say we all?

I should also mention that shellout already has similar env var behavior when you pass login: true as a flag, except that also overwrites $PATH and some other misc stuff. Also to complicate this further is how to handle things when Chef is being used to change nsswitch.conf, which can cause Etc.getpw* to fail for the remainder of the current run.

Well we should definitely do something about it...   Since its the kind of behavior people expect by default, I'd like to see it on by default with a flag to turn it off ideally...
IDK what to do about Etc.getpw-stuff...  I don't think there's a convenient pure-ruby NSS library to monkeypatch on top of all that.

I don't know of one, and writing something that can support all the weird nsldap integrations sounds painful :-(

@coderanger Is the PATH munging the main issue you've run into with the login option?  The login option in ShellOut tries to match what su(1) would do [0], including things like setting the secondary/supplementary groups for the user.  I definitely think we should consider changing the default behavior to something that matches user expectations, but I worry about adding a helper that puts the behavior somewhere "in-between" su and simply setting the process EUID.
Re the nsswitch.conf stuff, would it be possible to do all username lookups via a helper process that could be restarted between calls? The last time I investigated this, I didn't find many solutions other than (1) restart, (2) use nscd.  Re (1) it would potentially be interesting to rework parts of Chef such that we cold serialize our state and restart; however, making that work for user-code seems like it would be very hard.
[0] Notably we tend to mean su(1) on Linux here, which is another sad complication.

We should also look to see what we can rob from https://github.com/berkshelf/buff-shell_out and replace all the uses everywhere with mixlib-shellout.

I think I'm going to wind up extracting a shell_out_internal() which injects the LC stuff and the PATH sanity stuff in prep for removing that from Chef 13.  That'll isolate the 'screw with the environment for internal reasons' use case.  We also still have shell_out_with_systems_locale() that mostly isolates the internal use case of removing the LC mangling stuff.
We probably need to figure out how these should behave:

shell_out used alone
bash/script/execute resources
not_if/only_if uses

Users probably want one API which touches nothing -- no PATH, no LC stuff, and is just purely a fancier system() call.
Then there's the API where we need to support touching everything -- USER, HOME, LOGNAME, all the su-similar stuff.
Should also probably consider the proliferation of shell_out_yadda_yadda functions and maybe use options instead of making so many different methods.

So i think we need APIs for:

mangle nothing
mangle PATH and LC for internal use
mangle USER, HOME, LOGNAME and behave like su to a user (does this also mangle PATH and LC?  or only optionally?  or only PATH and not LC?)

And I think I'm leaning towards these should be feature flags and we should fold shell_out_compact into shell_out and try to get back to one shell_out/shell_out! API.

i think the way it should probably work is:
# does no mangling at all -- no PATH, english, or any user stuff
shell_out!("foo")
# should do proper stuff with mixlib-shellout along with the group and environment stuff from poise_shell_out
shell_out!("foo", user: "testuser1")
# unsets all the mangling
shell_out!("foo", user: "testuser1", usermangling: false)
# does path and english locale mangling (alias for path_sanity: true, force_english: true)
shell_out!("foo", internal: true)
# does path sanity only
shell_out!("foo", path_sanity: true)
# does english forcing only
shell_out!("foo", force_english: true)

then also have the api support flatten/compact of *args while making sure to support single strings as well.
the user: flag on macosx should also un-fuck the TMPDIR by default.
i don't think there's any reason to have the user mangling stuff on for root, but shell_out!("foo", user: "root") or shell_out!("foo", usermangling: true) should turn on all the user mangling.
the major API break here would be dropping path sanity + english forcing from shell_out!() which i think is the thing that would need to be chef 13.
the user mangling changes being turned on when the user flag is given /might/ change behavior but i think its at least 95% fixing people rather than breaking them.

The $HOME setting for root can still matter as its possible to end up with a different homedir (usually the user that started chef-client). Also are you including setting the group automatically as part of user mangling? Other than that :+1: The only thing left downstream at that point would be my reparse and escape handling for Windows, not sure how we feel about upstreaming that. The goal there is twofold, to support array arguments (i.e. shell_out(['foo', '--bar', 'one two'])) on Windows and to try to make things written expecting Bash-ish parsing (such as the ShellWords library and things using it) to JFW. The former seems like a solid win because currently arrays just error on Windows, the latter is more opinionated.

yep, auto setting the group plus the env settings seem fine, i see all that stuff in cookbooks and it pains me.
probably have it turned off by default but setting the user flag should turn it all on, then it could be all turned off again with a flag in case someone doesn't want it.
i want to support array args in windows, i need to look closer at what you're doing there.

so as far as:

The $HOME setting for root can still matter as its possible to end up with a different homedir (usually the user that started chef-client).

is it good enough that if you care about that you should do shell_out!("foo", user: "root") instead of shell_out!("foo")?  and we could do the same thing with the execute/script/etc resources so that setting a user of "root" would be different than the nil default in that it would enable all the magic.

https://github.com/poise/poise/blob/master/lib/poise/utils/win32.rb#L59-L123 is the relevant Windows command parser and generator. Basically parse using Bash rules (if not already an array), run argv_quote on each item, and then if converting back to an array use ^ escaping for cmd.exe if needed to shut off its interpolations and whatnot. Technically the argv_quote port in there only works for programs that parse lpCmdStr using the CommandLineToArgvW rules which is technically optional but everything I found that I could check uses CommandLineToArgvW (Python, Ruby, Node, and Java all do).
I'm 👍 on requiring user: "root" since that handles my use cases 99% of the time (shell_out(cmd, user: new_resource.user)). We should just be vigilant for cases where it matters.
Also another thing to ponder that I've done in a few places in my ecosystem: auto-translating root to the localized Administrator name on Windows. That would allow leaving "root" hardcoded in a lot of places we currently have nil (otherwise would explode on Windows by default).

yeah there was that PR to add the admin user to ohai.  i'm not opposed to that in principle, mostly that PR didn't seem to handle all the use cases.  also not necessarily opposed to magic, although maybe we should use admin: true to translate to user: "root" or user: "Adminstrator" or the correct localized windows string.
i will have to digest the parser-generator, i haven't dug that deeply into windows yet...  wonder if that fixes outstanding bugs that we have tho...

Making it a separate option works for shell_out but makes it harder to piece in to a complex system like a bunch of nested custom resources where you want a single user property and to have it just work. Or at least that's why I went this way (specifically I translate property(:user, default: 'root') to default: admin_username on Windows rather than do it in shell_out itself).

Okay, I can see that, the only thing is that there'd still need to be another flag to disable the magic, even if its very unlikely to be needed...

Yeah, my solution was the somewhat roundabout of default: lazy { "root" } is not mucked with but that wouldn't work here. A possible workaround is user: 0 but that feels too arcane. Or we could just use usermangling: false for this too.

So 1/2 or 2/3rd of this has gotten done:

the shell_out API cleanup got done that had nothing to do directly with this PR
the *argv style of array passing into mixlib-shellout got done so quotes happen correctly in mixlib-shellout and so chef's shell_out now supports array passing on windows.

What remains is the additional default ENV mangling on windows similarly to how we mangle the environment on *nix for convenience.  I suspect we've got additional bugs somewhere that would be fixed by that.


Long lines become unreadable

When entering longer lines, the text wraps over itself and becomes unreadable.
The line i put in was:
"realmConfig = new RealmConfiguration.Builder(getActivity()).deleteRealmIfMigrationNeeded().build();"

There is a bug when line break on html2canvas-0.5.0-beta3. So I disabled the word break. Thanks~

I downgraded html2canvas from 0.5.0-alpha1 to v0.4.1 because of that a wide line without break-word will cause a very wide image that difficult to read on mobile phone.


Wide instruction support

Wide instruction support
When editing methods using the "Edit with Assembler" option, both the goto_w and wide bytecode mnemonics are listed as unknown bytecodes.
This would be a useful feature for generating tests using these bytecodes for JIT compiler developers working on VMs

ASM abstracts away the wide instructions into more general ones, so its not something I can really support without entirely re-writing the assembler. It should map to the appropriate version when it writes the bytecode back to the class.

To elaborate, if you were to take a method that was long enough but not too long ASM would automatically use goto_w to jump to the later labels. But anything before would use normal goto. It won't emit the wide variant unless its necessary.

To elaborate, if you were to take a method that was long enough but not too long ASM should automatically use goto_w to jump to the later labels AFAIK. But anything before would use normal goto. It won't emit the wide variant unless its necessary.
Though some actual compilers would just use the wide one.
I'd need to make a test case or so to validate things work how I think they do.

Ah, I miss-read the JVM spec, because I had thought that goto_w wouldn't get generated by a compiler due to the method size being limited to 2 byte representation, and goto using 2 byte offsets, but method size is unsigned so I can still get a goto_w out of Recaf with a lot of {iload_0,istore_0} pairs.
Thanks for the assistance!


Unit file for "bootserver"

Issue Description
Write unit file for the "bootserver" as part of L2 services.
Steps to Reproduce (if applicable):
Acceptance Criteria (how do we know when this is done?)
Related Tickets
Additional Info
Output of uname -a:
Environment (physical, VM, cloud provider, etc.):
Other Relevant Info:

Example config that worked.
the ipxe line should contain ${pkgs.ipxe}/undionly.kpxe
we'll need to find a way to obtain the dhcp_interface
{
  "service_name": "bootserver",
  "socket_dir": "/task-socket/l2-coordinator/",
  "coordinator_url": "unix:///task-socket/l2-coordinator/coordinator/l2-coord.sock",
  "ipxe": "/tmp/undionly.kpxe",
  "kernel": "/data/platform/current/bzImage",
  "initrd": "/data/platform/current/initrd",
  "dhcp-interface": "enp0s3"
}

I created the unit file and pushed to the 276 branch. This may need some tuning once the bootserver merges to master.


Use Dubbo's metadata to match routes

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Per we used dubbo for rpc calls, and expect to build gray deploy, and we may use different indicators for gray routing, such as version/userId ... now we can only add a spring starter to resolve this problem per Istio does not support TCP calls friendly
Describe the solution you'd like
A clear and concise description of what you want to happen.
If there any method to route by dubbo metadata（such as provider's version is 1.0.0, the consumer is also 1.0.0, it can select the 1.0.0 provider）

Do you mean Dubbo attachment when you talk about metadata? Yes, we can route traffic based on it. An example:
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: test-dubbo-route
  namespace: dubbo
spec:
  hosts:
  - org.apache.dubbo.samples.basic.api.demoservice
  http:
  - name: route-batchjob
    match:
    - headers:
        batchJob:
          exact: "true"
    route:
    - destination:
        host: org.apache.dubbo.samples.basic.api.demoservice
        subset: batchjob
  - name: route-user
    match:
    - headers:
        batchJob:
          exact: "false"
    route:
    - destination:
        host: org.apache.dubbo.samples.basic.api.demoservice
        subset: user

If you need more flexible routing policies, please take a look at MetaProtocol.  In theory, any attributes in the Dubbo package could be put into the metadata of  MetaProtocol, and they can be used for routing. MetProtocol also supports RDS, so no connection interruption when routes change, much better than the original Dubbo proxy.  I'm very interested in your Dubbo use case. Could you please send me an email or contact me vi weChat(zhao_huabing). I can see there's a good potential that we could cooperate on those use cases.

@zhaohuabing thanks for your kindly reply, and i'm really glad that you invited me to share that case, i'll contact you by weChat

@Marco-Zheng how is your trail testing going? Dubbo on MetaProtocol is ready now. With Dubbo on MetaProtocol, you can change the traffic rules on the fly without interrupting the existing client connections, a big improvement compared with the original Dubbo proxy. Check it out if you're using Dubbo. https://github.com/aeraki-framework/aeraki/tree/master/test/e2e/metaprotocol


"amd" missing from error message for error TS1323

TypeScript Version:  3.7.0-dev.20191002

Search Terms:
amd, dynamic import, error message
Code
import("./mymodule.js");

"module" set to "es2015" in tsconfig.json.
Expected behavior:
error TS1323: Dynamic import is only supported when '--module' flag is 'amd' or  'commonjs' or 'esNext' or 'umd'.
Actual behavior:
error TS1323: Dynamic import is only supported when '--module' flag is 'commonjs' or 'esNext'.
Playground Link:
Related Issues:

Updated expected text to include "umd" since it's supported as well.

Agreed - also, let's just fix the grammatical issues too.
Dynamic imports are only supported when the '--module' flag is set to 'esnext', 'commonjs'  'amd', 'system', or 'umd'.

Missing comma 😉
Dynamic imports are only supported when the '--module' flag is set to 'esnext', 'commonjs', 'amd', 'system', or 'umd'.

Fixed thanks!

Thanks @a-tarasyuk!