amplify init failed: ERR_INVALID_ARG_TYPE The 'request' argument must be string

$ amplify --version && node --version && npm --version
4.29.8
v12.18.4
6.14.6

im not a js developer but im attempting to follow through this tutorial: https://github.com/aws-samples/aws-serverless-webapp-workshop . please let me know what other info i can provide
$ amplify init
Note: It is recommended to run this command from the root of your app directory
? Enter a name for the environment prod
? Choose your default editor: Visual Studio Code
Using default provider  awscloudformation

For more information on AWS Profiles, see:
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-profiles.html

? Do you want to use an AWS profile? Yes
? Please choose the profile you want to use ampdm
Adding backend environment prod to AWS Amplify Console app: dtxspv9qxsix
⠋ Initializing project in the cloud...

CREATE_IN_PROGRESS AuthRole                      AWS::IAM::Role             Fri Oct 16 2020 11:53:24 GMT-0400 (GMT-04:00) Resource creation Initiated
CREATE_IN_PROGRESS UnauthRole                    AWS::IAM::Role             Fri Oct 16 2020 11:53:23 GMT-0400 (GMT-04:00) Resource creation Initiated
CREATE_IN_PROGRESS DeploymentBucket              AWS::S3::Bucket            Fri Oct 16 2020 11:53:23 GMT-0400 (GMT-04:00)
CREATE_IN_PROGRESS AuthRole                      AWS::IAM::Role             Fri Oct 16 2020 11:53:23 GMT-0400 (GMT-04:00)
CREATE_IN_PROGRESS UnauthRole                    AWS::IAM::Role             Fri Oct 16 2020 11:53:23 GMT-0400 (GMT-04:00)
CREATE_IN_PROGRESS amplify-wildrydes-prod-115317 AWS::CloudFormation::Stack Fri Oct 16 2020 11:53:18 GMT-0400 (GMT-04:00) User Initiated
⠸ Initializing project in the cloud...

CREATE_IN_PROGRESS DeploymentBucket AWS::S3::Bucket Fri Oct 16 2020 11:53:24 GMT-0400 (GMT-04:00) Resource creation Initiated
⠙ Initializing project in the cloud...

CREATE_COMPLETE AuthRole   AWS::IAM::Role Fri Oct 16 2020 11:53:37 GMT-0400 (GMT-04:00)
CREATE_COMPLETE UnauthRole AWS::IAM::Role Fri Oct 16 2020 11:53:36 GMT-0400 (GMT-04:00)
⠹ Initializing project in the cloud...

CREATE_COMPLETE amplify-wildrydes-prod-115317 AWS::CloudFormation::Stack Fri Oct 16 2020 11:53:47 GMT-0400 (GMT-04:00)
CREATE_COMPLETE DeploymentBucket              AWS::S3::Bucket            Fri Oct 16 2020 11:53:45 GMT-0400 (GMT-04:00)
✔ Successfully created initial AWS cloud resources for deployments.
init failed
TypeError [ERR_INVALID_ARG_TYPE]: The 'request' argument must be string. Received type undefined
    at Object.onSuccess (/Users/drmullen/git/training/WildRydesVue/node_modules/@aws-amplify/cli/src/init-steps/s9-onSuccess.ts:26:26)
    at Object.exports.run (/Users/drmullen/git/training/WildRydesVue/node_modules/@aws-amplify/cli/src/commands/init.ts:24:11)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at Object.executeAmplifyCommand (/Users/drmullen/git/training/WildRydesVue/node_modules/@aws-amplify/cli/src/index.ts:185:5)
    at executePluginModuleCommand (/Users/drmullen/git/training/WildRydesVue/node_modules/@aws-amplify/cli/src/execution-manager.ts:161:3)
    at Object.executeCommand (/Users/drmullen/git/training/WildRydesVue/node_modules/@aws-amplify/cli/src/execution-manager.ts:26:5)

id also like to note that it was a PITA getting the provider awscloudformation found. scan kept not finding it so i had to manually point to it with:
$ find ./ -name amplify-provider-awscloudformation -type d -exec realpath {} +
$ amplify plugin add awscloudformation
#provide absolute path when prompted

i can open a separate issue if that is interesting (?)

@drewmullen how did you install the Amplify CLI? Was it using NPX script or did you do an global install using npm install -g @aws-amplify/cli

npm install @aws-amplify/cli

Amplify CLI needs to be installed globally for it to work. You can install it globally by adding -g flag to install

@drewmullen Please let us know if you're stuck after installing the CLI globally. Closing the issue for now.


rtcp: Prevent double locking in generate_report

There was a bug where if an error occurs in the generate_report() function the lock would not unlock and the next call would double lock and cause an exception

Yes, you are right that at least in case of errors, the lock would not be released. Thanks!


Update ddvk-hacks to 37.01

Add support for <IP_ADDRESS>7
Fix hash for rM1 <IP_ADDRESS>6

I've tested this and it works on my rM1, I just need someone to test on a rM2.

Tested on rm2 <IP_ADDRESS>7 (stable toltec, ipk installed from GitHub Actions artifacts), seems to work just fine.


failed to compile: invalid register [nil]

Describe the bug
Wazero fails to compile a wasm module I've compiled from Rust, which is compiled and executed successfully with Wasmtime and Wasmer.
To Reproduce
wasm module: https://github.com/olivierlemasle/wasm-text2png/releases/download/v0.1.0/wasm-text2png.wasm
It is a WebAssembly+WASI module compiled from Rust; its source code is in https://github.com/olivierlemasle/wasm-text2png (it simply uses the pure-Rust crate text-to-png to format a text given as parameter to PNG.)
It is compiled with target wasm32-wasi using cargo-wasi.
I can compile and execute this wasm module successfully with Wasmtime and Wasmer.
My host code:
package main

import (
	"context"
	"fmt"
	"log"
	"os"

	"github.com/tetratelabs/wazero"
	"github.com/tetratelabs/wazero/wasi_snapshot_preview1"
)

func main() {
	if len(os.Args) < 2 {
		fmt.Println("Required arg: WASM file path")
		return
	}
	file := os.Args[1]

	ctx := context.Background()

	rConfig := wazero.NewRuntimeConfig().WithWasmCore2()
	r := wazero.NewRuntimeWithConfig(rConfig)
	defer r.Close(ctx)

	if _, err := wasi_snapshot_preview1.Instantiate(ctx, r); err != nil {
		log.Panicln(err)
	}

	wasm, err := os.ReadFile(file)
	if err != nil {
		log.Panicln(err)
	}

	_, err = r.CompileModule(ctx, wasm, wazero.NewCompileConfig())
	if err != nil {
		log.Panicln(err)
	}
	log.Println("Successfully compiled")
}

When executing with go run . wasm-text2png.wasm, it fails with:
panic: function[42/1870] failed to compile: invalid register [nil]

Expected behavior
I would expect this module to compile, as with Wasmtime or Wasmer, or fail with a more helpful message / debugging info.
Environment (please complete the relevant information):

Go version: 1.18.3
wazero Version: 2fa67b83bf6adca7b19905e5b0de7eea8e35f757
Host architecture: amd64
Runtime mode: compiler

ps if you want to make sure things work otherwise, switch to NewRuntimeConfigInterpreter() temporarily until the fix is in!

OK found the root cause (I had the wrong assumption on register allocation which are both applied on amd64 and arm64). Will raise an fix shortly!

Thank you @mathetake (for the fix and for the work on this project!)


Relay debugging.

I'm frequently running into a situation where my application is syntactically correct but it is only rendering a blank screen (due to a Relay error).
The problem is that there's no indication of where the exact is occurring so it's very difficult to debug.
What is the best way to solve this issue (aside from rebuilding my app piece by piece until I locate the error since it's very inefficent)?

My first approach would be to look at the log, whether it actually successfully built (scroll up). After that, in the graphqlhttp setup, add after schema a function for formatError, that can help you with those kinds of ill formatted queries. Further, don't forget to install React debugging tools, they will also show you relay/graphql queries.
Apart from that you can also add logging (a PR is always appreciated).
Could you give more insight into what kind of relay errors are omitted?
Also, typing this from my phone, so description might be slightly off.

@Neitsch Here is an example of exactly what I'm describing: https://github.com/Extra-lightwill/graphql-sequelize-repo-test - I'd be really grateful if you could take a look!
If you start the application (npm install, npm start) and then navigate to http://localhost:4444/db-test you will see the issue - the App is rendering the main landing page but as soon as you navigate to the route with the Relay logic it renders nothing, but doesn't crash - no errors are shown.
(I'm simply trying to implement a mutation using the graphql-sequelize package).

@Extra-lightwill haven't looked at your example atm.
Can you check the graphql requests in chrome dev tools these will show an error. If there are any errors on the initial route query your the page won't render.

@ncrmro ah i see, that seems to pinpoint the error which is what I was looking for - thanks!

@Extra-lightwill tried to run the code in your repo with commit db766e1504b3ab57a0d75ce0a28b642bbbb14ee7, since that was the latest commit at the time of writing. It fails on schema.js:144
Again, I'd recommend looking into formatError, found in the docs (https://github.com/graphql/express-graphql)

@Neitsch I've added this, it works great :)

Thanks for the invite. Right now I'm fairly busy, I'll try to get around to it this weekend.
A while back I've tried a MongoDB integration (https://github.com/Neitsch/relay-fullstack/tree/mongo), but it's not great.
I was planning to stay away from sequelize, because I don't like ORMs (If you're interested http://www.yegor256.com/2014/12/01/orm-offensive-anti-pattern.html), but I might reconsider it, since it would provide a good abstraction for different database integrations.

@Neitsch Yeah exactly, I think it provides a good abstraction, especially with so many moving parts.


Explore styling differences for tabs and nav items

Summary
Tabs and Nav Items look similar, which leads to the expectation that they must work in a similar way.
💬 Description
Possible issue in nav bar as items looks like tabs and therefore causing expectation of different mode of operation through keyboard. Make styling different between navs and tabs so that it is obvious which components is which and therefore how to interact. Changing tab styling can also enable better visual connection between the tab container that the tabs control. Research whether current nav bar styling is causing people to misunderstand how to interact with page header nav bar items.
💰 Use value
To remove confusion about each component's functionality and purpose.

Won't do for now


Heuristic water vapor first guess

NB I might not call this a "fix," since the former method was an intentional choice :) Nimrod, thanks for your work on this code, and for your contribution to the repository!
Have you double checked it does not change the behavior when running in forward simulation mode?

Hi David,
Sorry for the bad words selection.
Tracing the path of the forward simulation, I do not find that the changed function is called.
I was running the forward and inverse like this in the past few days without any problem, but let me double check again.

I double checked the forward simulation, and it seems to not be affected from this change.

No worries about wording, of course! Thanks again for your contribution.  Duly merging in your change!


Derive serde traits for protocol objects

It's generally recommended that objects derive serde traits. This PR adds the optional serde feature, which derives serde::Serialize and serde::Deserialize for all protocol objects that don't contain raw FDs.

This adds some code which ends up not being tested, which leads to lower coverage (although it seems by a negligible amount).

What would be a use for this?

Actually, I found one: The benchmarks done in #698 implemented a custom scheme for "save all X11 traffic and replay it latter". I guess that could have been simpler via serde.

Citation needed?

https://rust-lang.github.io/api-guidelines/interoperability.html#c-serde
Downstream users may include generated structures in their own structures, and they may have a need to serialize those structures. It's completely reasonable that someone may want to read xproto::Rectangle from a JSON file.


No status code for a go app

Describe the bug
I have installed Odigos v1.0.1 o a GKE Cluster and instrumented a Go app with it and although I can see the tracings, none of them have the status code on signoz.
The app handles internally all the status code in order for us to check our own SLOs, so I find it strange signoz is no showing them.
Screenshots
This a the go app sending data to victoria metricas

This is the same app talking to Pub/Sub

Just to add another Go app instrumented by signoz that is showing the status code.

Desktop (please complete the following information):

Google GKE

Are the missing status codes occurring for HTTP server or client application?

Hey @RonFed , client application. In this case is a Go app querying data from via victoria metrics through a Google LB.
Our API behind a nginx-ingress is returning status code 200 as it should and Odigos is showing it right.
Tks.

@dirtyren with the latest v1.0.10 release, this should be resolved.

@RonFed  I noticed that  open-telemetry merged the code and I just updated odigos to the latest version 1.0.10 and I am still not getting the status code for the tracings. Just to let you know.
Tks.

@dirtyren What Go version do you use ? There suppose to be another release to the OpenTelemetry go instrumentation supporting the newest Go versions (v1.20.12 v1.21.4 v1.21.5)

@RonFed we use Go 1.20 on the deploy I am orchestrating with Odigos.

@RonFed I also noticed this happening after upgrading to 1.0.10. New instrumented applications using the odigos-ui do not have the same annotations that previous instrumented apps and, because of that, are not catching tracings.
Anything you need just let me know.
kubectl get deploy komodo-api -o yaml | grep odigo
    instrumentation.odigos.io/ebpf: "true"
    odigos-instrumentation: enabled
            instrumentation.odigos.io/go: "1"

kubectl get deploy komodo-frontend -o yaml | grep odigo
    odigos-instrumentation: enabled

@RonFed I also noticed this happening after upgrading to 1.0.10. New instrumented applications using the odigos-ui do not have the same annotations that previous instrumented apps and, because of that, are not catching tracings.
Anything you need just let me know.
kubectl get deploy komodo-api -o yaml | grep odigo
    instrumentation.odigos.io/ebpf: "true"
    odigos-instrumentation: enabled
            instrumentation.odigos.io/go: "1"

kubectl get deploy komodo-frontend -o yaml | grep odigo
    odigos-instrumentation: enabled

Hi @dirtyren ,
Thanks for letting us know.
Can you please check to see if you have an instrumented application for this source?
kubectl get instrumentedapplications.odigos.io -A

and also please check the logs of theodigos-instrumentor pod in the odigos-system namespace to see if there is any clue about the issue?

Hello @RonFed ,
the app komodo-frontend is a react frontend, that I am not able to instrument using Odigos
kubectl get instrumentedapplications.odigos.io -A
NAMESPACE   NAME                       AGE
komodo      deployment-komodo-api      28d
komodo      deployment-slo-generator   28d

I could not find any messages on the odigos-instrumentor pod.
Also, I had to remove the label odigos-instrumentation: enabled from the komodo-frontend deploy so it would show on the web interface and I could redo the process to check for logs.
Anything else I can help you with?
Tks.

Hello @RonFed ,
the app komodo-frontend is a react frontend, that I am not able to instrument using Odigos
kubectl get instrumentedapplications.odigos.io -A
NAMESPACE   NAME                       AGE
komodo      deployment-komodo-api      28d
komodo      deployment-slo-generator   28d

I could not find any messages on the odigos-instrumentor pod. Also, I had to remove the label odigos-instrumentation: enabled from the komodo-frontend deploy so it would show on the web interface and I could redo the process to check for logs.
Anything else I can help you with?
Tks.

Thanks for the info.
I think I found the bug. I am working on a fix that should be ready soon 🙏

@dirtyren
I thought I found an issue but I am not sure.
Can you please try to upgrade to version v1.0.11 and check if you still encounter the issue?
I also wrote to you in odigos slack - if you are available we can jump on a quick call to help diagnose the issue on your setup. Please let me know if the new version fixes the issue and/or if you like to schedule a zoom call.
Thanks again 🙏

hey @blumamir , I just updated to v1.0.11 and the service names of my instrumented apps got weird like this:

The tracing information is also showing strange things, but, it seems to be showing the http codes

Anything I can help with?
Tks.

I am getting this errors on the odiglet logs
{"level":"error","ts":1703707677.1487029,"logger":"Instrumentation.Manager","caller":"instrumentation/manager.go:165","msg":"error while loading probes, cleaning up","name":"google.golang.org/grpc/server","error":"field UprobeHttp2ServerOperateHeader: program uprobe_http2Server_operateHeader: load program: permission denied: dereference of modified ctx ptr R1 off=40 disallowed (33 line(s) omitted)","stacktrace":"go.opentelemetry.io/auto/internal/pkg/instrumentation.(*Manager).load\n\t/root/go/pkg/mod/go.opentelemetry.io/auto@v0.9.0-alpha/internal/pkg/instrumentation/manager.go:165\ngo.opentelemetry.io/auto/internal/pkg/instrumentation.(*Manager).Run\n\t/root/go/pkg/mod/go.opentelemetry.io/auto@v0.9.0-alpha/internal/pkg/instrumentation/manager.go:120\ngo.opentelemetry.io/auto.(*Instrumentation).Run\n\t/root/go/pkg/mod/go.opentelemetry.io/auto@v0.9.0-alpha/instrumentation.go:152\ngithub.com/keyval-dev/odigos/odiglet/pkg/ebpf.(*GoOtelEbpfSdk).Run\n\t/go/src/github.com/keyval-dev/odigos/odiglet/pkg/ebpf/go.go:55\ngithub.com/keyval-dev/odigos/odiglet/pkg/ebpf.(*EbpfDirector[...]).Instrument.func1\n\t/go/src/github.com/keyval-dev/odigos/odiglet/pkg/ebpf/director.go:124"}
{"level":"info","ts":1703707677.2024436,"logger":"Instrumentation.Manager","caller":"instrumentation/manager.go:190","msg":"Cleaning bpffs"}
{"level":"error","ts":1703707677.2028763,"caller":"ebpf/director.go:125","msg":"instrumentation crashed after running","error":"field UprobeHttp2ServerOperateHeader: program uprobe_http2Server_operateHeader: load program: permission denied: dereference of modified ctx ptr R1 off=40 disallowed (33 line(s) omitted)","stacktrace":"github.com/keyval-dev/odigos/odiglet/pkg/ebpf.(*EbpfDirector[...]).Instrument.func1\n\t/go/src/github.com/keyval-dev/odigos/odiglet/pkg/ebpf/director.go:125"}
{"level":"info","ts":1703762962.9726727,"caller":"ebpf/director.go:145","msg":"Cleaning up ebpf go instrumentation for pod","pod":{"name":"komodo-api-658fdb84b-6zhjj","namespace":"komodo"}}
a

Hi @dirtyren do you still need help with this issue? Happy to help you debug this if needed

@dirtyren if the issue is still relevant, feel free to re-open


Add support for WeTek Media Player

What is says in the title. WeTek's version adds support for the amlogic hardware acceleration on their boxes.

Looks good to me. Thanks!


Dark Mode for Windows

Hello, I would really like to use poedit, but since I'm very used to dark mode and I haven't found a way to make poedit dark, I wanted to ask if it will be supported in the future. If necessary, I would also work on implementing it. I don't think it should be that hard

I don't think it should be that hard

Great, looking forward to your PR since it's "not that hard" for you! I sure am glad you showed up, because this project really could use somebody so super-competent that this daunting task is "not that hard" for them.
Closing in favor of your upcoming contribution.
(I just hope you wouldn't babble something like that with no competence or functional understanding of the code. But no, of course you wouldn't. I mean, what kind of person would do that? That would be like a whole new level of arrogance, wouldn't it?)


Use official OpenAI ChatGPT API

Instead of relying on an unofficial method to access ChatGPT, this PR uses the official API to avoid potential issues or errors that might arise from using an unsupported approach.
However, this also introduces a new challenge: setting a system message. This issue was not addressed in the original paper, so I decided to use one of the system prompts that were used in ChatGPT as a baseline.

@microsoft-github-policy-service agree

@yuan-alex Thanks a lot for adding this integration! We have also recently started testing the API internally.
I am adding a commit with a suggestion on how the 'system' context can be set - essentially, using the first part of the current prompt as the system message, informing ChatGPT how it should act. Feel free to propose any modifications.

@saihv Hey Sai! The multi-line string for the system prompt contains both blanks and newlines. To address this, I suggest adding a new folder specifically for system prompts, which we can read from.
Also, with the new system prompt, ChatGPT responds only with the code and no code-blocks. I've pasted one of the examples below.
# Command the drone to move up 10 units

aw.takeoff() # take off the drone
current_position = aw.get_drone_position() # get current position of the drone
destination = current_position + [0, 0, -10] # add 10 to the Z coordinate
aw.fly_to(destination) # fly the drone to the new position

The new response using your system prompt is cleaner (and saves on token costs!) but it does mean we get less of an explanation from the model. The code block extraction function can be removed but I'm curious on what your take is.

Just tested combining the existing system prompt and first user prompt into one big system prompt and it performs very well. It seems like using both the first user prompts and system prompt to set instructions for ChatGPT causes some confusion and degraded performance.

Might be worth taking a look at temperature and other parameters of the official API as well. Temperature 0.0 would be most likely very appropriate for robot tasks that include generating code to make the output more deterministic.

I've found adding a

Adding a simple response example is enough to remind ChatGPT isn't in a python shell and is supposed to respond with an explanation.
The following is an example of how you would respond:

Me: move 10 units up
You: ```python
aw.fly_to([aw.get_drone_position()[0], aw.get_drone_position()[1], aw.get_drone_position()[2]+10])
```

This code uses the `fly_to()` function to move the drone to a new position that is 10 units up from the current position. It does this by getting the current position of the drone using `get_drone_position()` and then creating a new list with the same X and Y coordinates, but with the Z coordinate increased by 10. The drone will then fly to this new position using `fly_to()`.

@yuan-alex Wouldn't it be better to package the query/response into separate user and assistant type messages with the official API?
e.g.
user:
move 10 units up

assistant:
"""python
aw.fly_to([aw.get_drone_position()[0], aw.get_drone_position()[1], aw.get_drone_position()[2]+10])
"""

This code uses the `fly_to()` function to move the drone to a new position that is 10 units up from the current position. It does this by getting the current position of the drone using `get_drone_position()` and then creating a new list with the same X and Y coordinates, but with the Z coordinate increased by 10. The drone will then fly to this new position using `fly_to()`.

@yuan-alex Thanks for developing this interface! Merged.

Hi @yuan-alex , thanks for your commit update; however, I still got a connection issue (WARNING:urllib3.connectionpool:Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x00000271F1C7E2B0>: Failed to establish a new connection: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond')': /v1/chat/completions), do you have any idea about this problem? thank you!


The MKT Analytics configuration path is outdated.

[Enter feedback here]
In the latest versions of MKT app this path is not valid
Settings > Advanced settings > Marketing settings > Marketing analytics configuration.
In the new versions (1.84.2011.0) the Marketing analytics configuration is found under  Data Management, please fix it

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06d56767-ae95-eb6b-353e-af2ccb415d00
Version Independent ID: 5100476a-5a38-b8b3-6ba7-b61869ba3383
Content: Prepare for analytic reporting with Power BI (Dynamics 365 Marketing)
Content Source: ce/marketing/custom-analytics.md
Service: dynamics-365-marketing
GitHub Login: @alfergus
Microsoft Alias: alfergus

Thanks for your comment, @switchbladesmile. This issue has been assigned to the doc author for review.

Great catch -- I've updated this. The fixed page should be live within a few hours.


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit a24a7fc:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add custom emote command responses

Due to the increase in bttv emote slots, I've added a requested feature that allows users to replace the default !bttv/ffz/subemotes command response with their own.
Pull request checklist:

[x] CHANGELOG.md was updated, if applicable
[x] Documentation in docs/ or install-docs/ was updated, if applicable

Fixes https://github.com/pajbot/pajbot/issues/910

Thanks to @pajlada for his help on this

for the suggested changes, you might need to reformat afterwards, I made these in the web editor
Additionally, I cant place review comments there, but you need to update the command examples as well: https://github.com/pajbot/pajbot/pull/940/files#diff-96ac7c3796efc215492133288ccc3c3eR161-R162 (three times).

I semi-fixed the variables in the command examples. Only thing I'm having issues with is importing the streamer_display variable.

I don't like the use of StreamHelper because it will be the streamer's login name and not display name. What exactly about the old approach did not work?

I don't like the use of StreamHelper because it will be the streamer's login name and not display name. What exactly about the old approach did not work?

AttributeError: 'NoneType' object has no attribute 'self.streamer' (I believe this was the error).
No matter what I did, this error seemed to have followed...

@pajlada Here's the error I get. The error occurs for the web interface and the page ends up erroring out: AttributeError: 'NoneType' object has no attribute 'streamer_display'

You can keep using StreamHelper for now (which will result in us using lowercase usernames, just like before). We should inject the streamers display name into StreamHelper so it can be used in situations like this where the modules command output and examples are generated in the same spot and we try to use the custom response in the example.
#945

You can keep using StreamHelper for now (which will result in us using lowercase usernames, just like before). We should inject the streamers display name into StreamHelper so it can be used in situations like this where the modules command output and examples are generated in the same spot and we try to use the custom response in the example.

Considering this was the only issue, this pr can be merged, no? Or is something else yet to be done on it?


Create a way of enabling pywb HTML rewriting for Via 3

In order to allow the pywb rewriter to be evaluated in an LMS context, we have to be able to enable it some how. Normally this would be through a feature flag, but this is difficult, as the feature flag would need to be enabled in LMS, but take effect in Via 3.
This should be done once there is something to enable in production: https://github.com/hypothesis/via3/issues/217
Implementation ideas
We could add an extra URL parameter to Via 3. Our new system for reading params does not need to be altered to accept this value and will already decode it. We would then need to check and respect this value.
We could add a checkbox to the landing page to enable this to make it easier for non technical people to use. As this is a form submission, it should be pretty easy.
We could then add a feature flag to LMS to pass through whatever mechanism causes this to be loaded.
Acceptance criteria

[x] Via 3 supports enabling pywb HTML rewriting
[ ] LMS has a feature flag for enabling this feature

A PR for the flag in Via 3: https://github.com/hypothesis/via3/pull/222

This is a bit more of a pain than I'd hoped for LMS. LMS skips routing to go directly to old via for known HTML documents.
There's an increasing amount of logic involved in crafting the URLs, parsing params etc, that is being re-used by Via, Via 3, Via 3 rewriter and LMS. It might be time to pull some of this out into a separate module.

The second part is being worked on here: https://github.com/hypothesis/lms/pull/1994

This is done and both parts are in QA. Ian is working on some firewall stuff that can't really be developed anywhere but in AWS, so this will have to wait a bit until that all shakes out.

This is out and seems to be working now


需要适配ipv6网络环境

https://github.com/openGemini/opengemini-client-go/blob/49423902a3ca16ac35fa57265f70914d470a964d/opengemini/client_impl.go#L86
应修改为
urls[i] = endpoint{url: protocol + net.JoinHostPort(addr.Host, strconv.Itoa(addr.Port))}

accept

Nice Catch! is this any possible we can find this by golangci-lint


glMemoryBarrier()'s  argument is shown as an integer value

The argument is a bitfield, which can be an OR of various enums. Right now, RenderDoc shows the API call as below:

A potential improvement here would be to change the existing behavior to show a set of barriers the call toggles, instead of a raw int.

This is partially because the API calls view is just a dump of the serialised form, and that value is serialised as a uint32. (See e.g. #271).
In this case though I can just co-erce it to an enum and get a nicer text display of the number at least so it's not too difficult to fix. Unfortunately GL doesn't have nice enums so I'll have to make one myself :/.

Try with that commit, it should now display the list of barriers correctly I think.

Works like a charm, thanks :)


adding program manager position and clean up jobs section

https://website.mlab-sandbox.measurementlab.net/
Pending:

Lai Yi title
Link to Greenhouse

This change is

LGTM pending the addition of the apply link!
@laiyi-ohlsen do you want to add an “Apply Now” link/button to the top and bottom of the post?


Is it me or is the page not updating

Hi,
I've been visiting your project almost daily and I've noticed that the entries that are shown are not up to date. It seems that it has never updated since the first time I've visited 🤔
e.g. compare it to https://vue-hn.now.sh/top or https://news.ycombinator.com/

Every project built with hnpwa.com's api behaves this way. This issue is not exclusive to the project.

Then I highly recommend using https://github.com/HackerNews/API as this is more real-time.
Else i don't really see the point in using this implementation of hacker news :( Happy to help tho :)

Yep @OGKevin, the API's update rate isn't nearly as frequent as the official one :)
A problem with the official API is that every story item only list's the IDs of each comment, and the same for each comment and their children. It makes it virtually unusable when just making REST requests because hundreds of requests are needed just to load a single story.
I would definitely be open to plugging in Firebase and using a websocket to make things real time. My only concern is that it doesn't bloat up our application. The Vue HN implementation mitigates this by SSR if I'm not mistaken. Definitely open to seeing how we can do something similar here :)


Replace [] tests with individual tests

We have several places where we use [TestCase] to create a single test with multiple input values. While efficient (no code duplication), this is not the best of user experiences as it makes it harder to run a single test and also doesn't really allow us to mark the various input values with a descriptive text. It also doesn't align with how canonical data for exercises is defined, which only works on single test cases.
Consider the isogram exercises's tests:
[<TestCase("duplicates", ExpectedResult = true)>]
[<TestCase("eleven", ExpectedResult = false, Ignore = "Remove to run test case")>]
[<TestCase("subdermatoglyphic", ExpectedResult = true, Ignore = "Remove to run test case")>]
[<TestCase("Alphabet", ExpectedResult = false, Ignore = "Remove to run test case")>]
[<TestCase("thumbscrew-japingly", ExpectedResult = true, Ignore = "Remove to run test case")>]
[<TestCase("Hjelmqvist-Gryb-Zock-Pfund-Wax", ExpectedResult = true, Ignore = "Remove to run test case")>]
[<TestCase("Heizölrückstoßabdämpfung", ExpectedResult = true, Ignore = "Remove to run test case")>]
[<TestCase("the quick brown fox", ExpectedResult = false, Ignore = "Remove to run test case")>]
[<TestCase("Emily Jung Schwartzkopf", ExpectedResult = true, Ignore = "Remove to run test case")>]
[<TestCase("éléphant", ExpectedResult = false, Ignore = "Remove to run test case")>]
let ``Isogram correctly detects isograms`` (actual: string) =
    isogram actual

What's the difference between test case one and two? It's not immediately obvious. The canonical-data of this exercise looks much nicer. I think we should convert the [] tests to individual tests.

This is also being discussed in the C# track https://github.com/exercism/xcsharp/issues/194

Here are the list of exercises using the TestCase attribute:

[ ] acronym
[ ] atbash-cipher
[ ] clock
[ ] diamond
[ ] grep
[ ] isogram
[ ] largest-series-product
[ ] luhn
[ ] matrix
[ ] meetup
[ ] nth-prime
[ ] perfect-numbers
[ ] pig-latin
[ ] protein-translation
[ ] pythagorean-triplet
[ ] raindrops
[ ] roman-numerals
[ ] series
[ ] simple-linked-list

Great work gathering this data @robkeim!

I can start working on these. I will always leave a comment here before starting to convert the tests for an exercise - this way you'll know which ones are still up for grabs :)

Sounds great, thanks @balazsbotond.

That would be brilliant @balazsbotond1

Starting to work on: acronym

@ErikSchierboom I'm closing this issue as this should now be obsolete with the move to using test generators.

@robkeim Good point.


Feature/update clojure test

This PR's main purpose is to update version of aws-sdk-java in client tests to latest 1.10.8.
As side effects...

Use proxy settings in upstream master https://github.com/weavejester/clj-aws-s3
instead of proxy support by forked one
Include s3.clj from clj-aws-s3 repository (at commit b01c0f1)
because it is single file thin wrapper, no test and to make updating easier.
Update other dependent library versions

Refactored code, added a little doc fix. Ready for review now.

So this updates aws-adk-java from 1.4.7 to 1.10.8.

@borshop merge

RCS-255


Consider string interning (pooling) as option for columns

For datasets having many rows but few distinct string column values, string interning could save time and space, at an extra cost of bookkeeping and complexity of code and storage. There are several places to consider: format and interface.
Format changes would obviously introduce version dependencies for clients. Compression essentially does string interning on disk so it might be that it offers no CPU or disk savings (did not implement and test).
An interface implementation might help languages that allocate strings, by reducing allocation and GC costs, and memory usage.

Thanks for the suggestion.  Could you describe how this is different then dictionary arrays ?

Indeed, @ericjster what you are describing sounds equivalent to dictionary encoding, which we have already


[SMALLFIX] Use static imports for standard test utilities

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3303/
Test PASSed.

alluxio-bot, merge this please.


Fix grammar error

Description of the change:
The sentence was not grammatically correct. I made it correct.
Reason for the change:
So as to become more readable and understandable
Link to original source: https://sendgrid.com/docs/ui/account-and-settings/how-to-set-up-domain-authentication/

Closes #

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @geekysrm,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Merge changes from LibXPUInfo

Cross-platform enhancements
Clean build with MSVC x64 /W4 /WX

Hi @elpalmer I made a change so I could compile on windows, can you verify that my change is ok before I merge?

Hi @elpalmer I made a change so I could compile on windows, can you verify that my change is ok before I merge?

HI @MarissaDuBois-Intel , that change defeats the purpose of my change to make it build with /WX /W4 as required by SDL.  I think I see the issue, though, and I will push another change for you to try.

@MarissaDuBois-Intel Please review latest change.


Add placeHolder image parameter to AnimatedImage.manager.loadImage method.

It would be great if there is an parameter for placeHolder image in AnimatedImage.
Something like this.
AnimatedImage.manager.loadImage(with: request, into: self, placeHolder: UIImage(named: "placeHolder"))

And is there anyway to know if FLAnimatedImage is already cached or not?

Hey @lubos08!

It would be great if there is an parameter for placeHolder image in AnimatedImage.

I'm not sure whether placeholder would be that worthy of an addition, since you can just set it yourself:
imageView.image = UIImage(named: "placeHolder")
Nuke.loadImage(with: url, into: imageView)

Or if you worry about performance:
Nuke.loadImage(with: url, into: imageView)
if imageView.image == nil {
    imageView.image = UIImage(named: "placeHolder")
}

You can also add your own extension method to Nuke.Manager that has a placeholder parameter.
I'd really prefer to keep Nuke's APIs as small and simple as possible. Maybe I'll later add a separate Nuke-Extensions repo with a bunch of extension methods like this.

And is there anyway to know if FLAnimatedImage is already cached or not?

For mem cache:
if Cache.shared[Request(url: imageURL)] != nil {
    // image is in mem cache
}

For disk cache it's not that trivial.

@kean Thanks for your update.


⚠ ClamAV has degraded performance

In ade65b7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 92 ms

Resolved: ClamAV performance has improved in 6e5ec6e after 6 minutes.


Add a tool that prints information on the sizes of the examples.

The tool prints the size of .bss, .data, and .text (which currently includes .rodata). I tried to adjust the linker script to separate out .rodata, but unfortunately that caused RISC-V apps to fault. I'll take care of that in a later PR, when I refactor the entry point and layout script.
I intend to develop a GitHub Action similar to tock/tock's that runs print-sizes on incoming PRs and displays the diff relative to the PR's target branch.

I think this is a good start to further investigate code sizes.
bors d+

bors r+


Error when trying to list sources

Describe the bug
After creating an external data source (a pdf document), the CLI command  memgpt list sources issues the error below (though the document can still be added later to the agent using /attach from within the agent session):
Traceback (most recent call last):
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/bin/memgpt", line 8, in <module>
    sys.exit(app())
             ^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/typer/main.py", line 328, in __call__
    raise e
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/typer/main.py", line 311, in __call__
    return get_command(self)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/typer/core.py", line 783, in main
    return _main(
           ^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/typer/core.py", line 225, in _main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/typer/main.py", line 683, in wrapper
    return callback(**use_params)  # type: ignore
           ^^^^^^^^^^^^^^^^^^^^^^
  File ".../.../work/MemGPT/memgpt/cli/cli_config.py", line 1150, in list
    source.embedding_model,
    ^^^^^^^^^^^^^^^^^^^^^^
  File ".../.local/share/virtualenvs/MemGPT-npmQTUT2/lib/python3.11/site-packages/pydantic/main.py", line 828, in __getattr__
    raise AttributeError(f'{type(self).__name__!r} object has no attribute {item!r}')
AttributeError: 'SourceModel' object has no attribute 'embedding_model'. Did you mean: 'embedding_config'?

Please describe your setup

[ ] How did you install memgpt?  git clone and then 'pip install -e .'
[ ] Describe your setup

What's your OS (Windows/MacOS/Linux)? MacOS Sonoma 14.5
How are you running memgpt? Terminal CLI
MemGPT v0.3.21 (latest)
Virtual env running Python 3.11.4

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I am using openai backend with API key. I originally added a pdf source following instructions similar to the tutorial:
# we're saving the file as "memgpt_research_paper.pdf"
curl -L -o memgpt_research_paper.pdf https://arxiv.org/pdf/2310.08560.pdf

memgpt load directory --name memgpt_research_paper --input-files=memgpt_research_paper.pdf

MemGPT Config

[defaults]
preset = memgpt_chat
persona = sam_pov
human = basic

[model]
model = gpt-4
model_endpoint = https://api.openai.com/v1
model_endpoint_type = openai
context_window = 8192

[embedding]
embedding_endpoint_type = openai
embedding_endpoint = https://api.openai.com/v1
embedding_model = text-embedding-ada-002
embedding_dim = 1536
embedding_chunk_size = 300

[archival_storage]
type = chroma
path = /Users/inigo/.memgpt/chroma

[recall_storage]
type = sqlite
path = /Users/inigo/.memgpt

[metadata_storage]
type = sqlite
path = /Users/inigo/.memgpt

[version]
memgpt_version = 0.3.21

[client]
anon_clientid = 00000000-0000-0000-0000-000000000000

Thanks for reporting this! We will try to fix ASAP.

@sarahwooders many thanks! As an update to this issue, the 'sources' functionality seems to work fine over the deployed Docker web interface for MemGPT. In there I can add and later list the documents (pdf's in my case) added. They appear in the web interface and no error is raised. I guess then it might be a particular issue with the CLI implementation of the same functionality (maybe a missing parameter in a function call?). Thanks again!

This should be fixed by #1596, but please re-open if you keep having the issue.
The CLI and server implementations are often different (we are in the process of migrating everything to interact through a common client), which is probably why it was working on the web interface but not the CLI. The CLI was the first thing we had with MemGPT, so tends to have the oldest/messiest code 😅


Add scalar multiplication to BigUint, BigInt

BigUint and BigInt can now be multiplied by a BigDigit, re-using the same buffer for the output, thereby reducing allocations and copying.
Points for comment:

These operations are only unidirectional. That is, I've only implemented Mul<BigDigit> for BigUint, and not Mul<BigUint> for BigDigit. It won't be any trouble to add the other direction if it's felt that it should exist.
I haven't implemented by-reference equivalents (such as impl<'a> Mul<BigDigit> for &'a BigUint). That's because you would not be able to reuse the same buffer for output, and that misses the point somewhat. Again, not a lot of trouble to add it in if it would be useful, but I'm less convinced of that.
Should there also be impl Mul<i32> for BigInt, or can users cope with multiplying by u32 and negating the result?

As an example of the benefit, I compared the speed of calculating 1000000! with and without scalar multiplication (cf issue #234), using the following two functions:
extern crate num;
use num::{BigUint, One};

fn factorial_fast(n: u32) -> BigUint {
    let mut f: BigUint = One::one();
    for i in 1..(n+1) {
        f = f * i;
    }
    f
}

fn factorial_slow(n: u32) -> BigUint {
    let mut f: BigUint = One::one();
    for i in 1..(n+1) {
        let bu: BigUint = From::from(i);
        f = f * bu;
    }
    f
}

The results were:
factorial_slow(1_000_000):

real    7m48.038s
user    6m20.716s
sys     1m27.170s

factorial_fast(1_000_000):

real    3m8.596s
user    3m8.497s
sys     0m0.052s

That speedup is great, especially in eliminating sys time!

These operations are only unidirectional. That is, I've only implemented Mul for BigUint, and not Mul for BigDigit. It won't be any trouble to add the other direction if it's felt that it should exist.

Yes please, we should have this both ways.  I don't think users should have to worry about order when it's so easy to make both work.

I haven't implemented by-reference equivalents (such as impl<'a> Mul for &'a BigUint). That's because you would not be able to reuse the same buffer for output, and that misses the point somewhat. Again, not a lot of trouble to add it in if it would be useful, but I'm less convinced of that.

Right, you don't get the buffer reuse, but the actual multiplication might still be faster.

Should there also be impl Mul for BigInt, or can users cope with multiplying by u32 and negating the result?

Hmm.  This opens a can of worms, that we might actually want Mul for all integer types, if only because I don't really like adding more BigDigit to the API surface.  I'd eventually like to break that into an internal implementation detail.  So, privileging u32 seems wrong from that perspective, but maybe it's a reasonable starting point.
For that matter, we probably should have scalars for all ops too.  There's a stronger performance reason to have Mul and maybe Div too, but implementing the rest is better for API consistency.  I don't want users to have to keep in mind, "what are the corner cases that num implemented?"  Rather, they can just know that bigint now implements ops with scalar operands, across the board.
That's a lot of scope creep, I realize.  If you're game, I'd love to see the full monty.  If you're not, we should at least plan for how much work it is to get there.  It might just be that we should fill out naive implementations everywhere first (convert to bigint and do a normal op), then optimize when we can.

I agree with you there, in terms of implementing the arithmetic operations for all integer types. I think the work breaks down into pieces quite nicely:

Implementing the operations for 32-bit scalars.
Getting the operations to work in both directions and with references.
Getting the operations to work with smaller integer types by promoting to 32-bit.
Implementing the operations for 64-bit scalars (which is a bit more fiddly). We can probably still get buffer-reuse here, but the associated costs are greater (at least for multiplication, it takes significantly more operations on primitive types). Maybe investigate whether the benefits outweigh the drawbacks, and if converting to BigInt / BigUint first is better.

The first and last bullets are where the real work is, the others can almost certainly be done with some useful macros, in the style of the rest of num-bigint.
Does that general approach sound like the right thing to do? I think I'm game - even though, as you say, it's a lot more than I originally set out to do with this PR.

Yes, I think your breakdown sounds great, and we can merge those incrementally over several PRs.
One note on the 64-bit part - even if we find it hard to do a fully-optimized scalar version, we can probably still avoid a full BigUint conversion with a heap allocation.  Just converting to a local [lo,hi] array can probably let it re-use the internals of the normal operators.

Closing in favor of #313


Settings "gear" icon is gone after 0.0.5 update

0.0.4
0.0.5

Wait, was this intentional?

Kinda weird but if I go to Messenger » Log out, it pops open the menu, without logging me out:

Messenger » Preferences prompts me to delete the conversation.
I think whatever scripting is being used to automate this is not reliable and should not be done.

Yeah, injecting JS is terrible. But it's what we are doing because apparently everyone seems to love that idea. About to land a diff that makes this better.

I think a reasonable thing to do is at least double check the name of the menu item before clicking on it. I've accidentally downloaded new stickers and deleted conversations by trying to get to preferences; please be safe rather than sorry.
Or at least bring the gear back, right now I have a problem that I can't even get to settings if I wanted to without potentially doing something bad.


Request list: Display a little messy at smaller browser sizes

The list of requests is truncating request names and the "submitted" label at smaller screen sizes. It would be good if this could be presented in a slightly neater way.

@NigelPalmer Does this issue become obsolete because of #168 ?

Yes, this task is now obsolete. Closing task.


Bug on android when starting app

Hello
I have a problem with start method. When i try to start application on android device
The method throw an exception ; "The app has been already started"
What is the problem, because on my desktop i don't have this error
i have a init.js file who load the app.js file
// init.js
if(!ApplicationDemaree) {       document.body.removeChild(document.querySelector('#app-loader'));              ApplicationDemaree = true;       alert('first loading');       window.M_APP.start();                 } else {         alert('retrying');   }
//app.js
`/* global phonon */
phonon.options({
navigator: {
defaultPage: 'home',
animatePages: true,
enableBrowserBackButton: true,
templateRootDirectory: './tpl'
},
i18n: null //we do not use internationalization
});
window.M_APP = phonon.navigator();
window.M_APP.on({page: 'home', preventClose: false, content: null});
window.M_APP.on({page: 'login', preventClose: true, content: null, readyDelay: 1});
window.M_APP.on({page: 'registration', preventClose: false, content: null, readyDelay: 1});
window.M_APP.on({page: 'settings', preventClose: false, content: null, readyDelay: 1});
window.M_APP.on({page: 'business-details', preventClose: true, content: null, readyDelay: 1});
window.M_APP.on({page: 'boutique', preventClose: false, content: null, readyDelay: 1});
window.M_APP.on({page: 'boutique/nouveau', preventClose: false, content: null, readyDelay: 1});
window.M_APP.on({page: 'chat', preventClose: false, content: null, readyDelay: 1});
`
please can you help me ?

Looks like you is calling phonon.start() twice, this need be called only one time.
Why you is using 'content: null'?

hi john
i've found the problem, it is not coming from phonon
i was include cordova plugin crypt on the project
for 'content': null is because i use riot on the project, not the ative templates provided by phonon


Incorrect PowerShell Syntax

At https://git-scm.com/book/en/v2/Git-Internals-Git-Objects there is a note stating that:

In PowerShell or CMD on Windows, the ^ character is used for escaping, so you have to double it to avoid this: git cat-file -p master^^{tree}.

This is (presumably? no idea honestly) correct for CMD but is incorrect for PowerShell. ^ is not an escape character in PowerShell, ` is. What happens (to the best of my understanding) is that { causes PowerShell to interpret everything following until the closing } as a script block. Passing that script block to a executable causes the script block to be evaluated. Instead of getting a single parameter "master^{tree}", the executable receives two parameters "master^" and "tree".
Consequently the proposed solution doesn't work:
> git cat-file -p master^{tree}
error: switch `e' : incompatible with -p
[...]
> git cat-file -p master^^{tree}
error: switch `e' : incompatible with -p
[...]

Two possible solutions to make the command work in PowerShell would be to pass the argument as a string (imo the preferred solution):
> git cat-file -p 'master^{tree}'
or to escape the {} characters:
> git cat-file -p 'master^`{tree`}'
My proposed fix for the documentation would be something along the lines:

In CMD on Windows, the ^ character is used for escaping, so you have to double it to avoid this: git cat-file -p master^^{tree}.
When using PowerShell parameters using {} characters have to be quoted to avoid the parameter being parsed incorrectly: git cat-file -p 'master^{tree}'

Hey @danstur,
Thanks for reporting this detail!
But as you can see in the issue template, this repository issue tracker should only be used to report problems found on the git-scm website (https://git-scm.com/).
book related issues (i.e. anything with a URL starting with https://git-scm.com/book or its PDF versions), which should be raised at progit/progit2.
Can you open the issue in the proper repository?  (https://github.com/progit/progit2/issues)
Thanks a lot!

My apologies for ignoring the template.. Issue in proper repo

thanks a lot! :D @danstur


Default LRU cache expires data in 5 seconds

Found at https://github.com/prismicio/ruby-kit/blob/master/lib/prismic/api.rb#L177
# Fetch the API information from the Prismic.io server
...
api_cache.get_or_set(cache_key, nil, 5) {
... # Calls the API here
}
...

If Prismic users use the default cache (Prismic::LruCache), this line will instruct that LRU cache to expire data in 5 seconds, which IMO doesn't make sense. The LRU cache should fill up until it's defined maximum (which is 100 keys by default) and when it's full just discard the LRU key. From what I understand, these 5 seconds are used to prevent stale content, as the cache key used doesn't include the latest master ref.
I don't have a full understanding of the codebase, but I think this cache could be much better if the cache key would only include the API ref and not expire data at all, especially lower-traffic sites like mine would benefit because as of now the default cache almost never gets any hits. I would be willing to work on a PR if you could hint me to the places in the code where the cache key is generated.

So after researching some more, it seems I was mistaken. The code I showed above only fetches the "/api" API call, thererfore it should expire in 5 seconds. All other data is cached properly and stays in the LRU. Closing.


Websocket Disconnecting on windows with ver 4.2.6

data transfer failed
Traceback (most recent call last):
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 945, in transfer_data
message = await self.read_message()
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 1015, in read_message
frame = await self.read_data_frame(max_size=self.max_size)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 1090, in read_data_frame
frame = await self.read_frame(max_size)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 1145, in read_frame
frame = await Frame.read(
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\framing.py", line 100, in read
data = await reader(length)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\asyncio\streams.py", line 716, in readexactly
self._maybe_resume_transport()
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\asyncio\streams.py", line 446, in _maybe_resume_transport
self._transport.resume_reading()
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\asyncio\sslproto.py", line 343, in resume_reading
self._ssl_protocol._transport.resume_reading()
AttributeError: 'NoneType' object has no attribute 'resume_reading'
Task exception was never retrieved
future: <Task finished name='Task-9' coro=<WebcastWebsocket.connection_loop() done, defined at C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\TikTokLive\client\websocket.py:88> exception=ConnectionClosedError(None, Close(code=1011, reason=''), None)>
Traceback (most recent call last):
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 945, in transfer_data
message = await self.read_message()
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 1015, in read_message
frame = await self.read_data_frame(max_size=self.max_size)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 1090, in read_data_frame
frame = await self.read_frame(max_size)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 1145, in read_frame
frame = await Frame.read(
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\framing.py", line 100, in read
data = await reader(length)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\asyncio\streams.py", line 716, in readexactly
self._maybe_resume_transport()
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\asyncio\streams.py", line 446, in _maybe_resume_transport
self._transport.resume_reading()
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\asyncio\sslproto.py", line 343, in resume_reading
self._ssl_protocol._transport.resume_reading()
AttributeError: 'NoneType' object has no attribute 'resume_reading'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\TikTokLive\client\websocket.py", line 114, in connection_loop
self.__client.emit("error", ex)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\pyee\base.py", line 179, in emit
self._emit_handle_potential_error(event, args[0] if args else None)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\pyee\base.py", line 139, in _emit_handle_potential_error
raise error
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\TikTokLive\client\websocket.py", line 104, in connection_loop
await self.send_ack(decoded["id"])
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\TikTokLive\client\websocket.py", line 130, in send_ack
await self._connection.send(message)
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 620, in send
await self.ensure_open()
File "C:\Users\GeneralKnow\AppData\Local\Programs\Python\Python310\lib\site-packages\websockets\legacy\protocol.py", line 930, in ensure_open
raise self.connection_closed_exc()
websockets.exceptions.ConnectionClosedError: sent 1011 (unexpected error); no close frame received
Desktop (please complete the following information):

OS: win10
Browser: windows powershell
Version 4.2.6

At this point I think I'll be redoing websockets. For now, disable them

how can i disable it i have the same problem it works fine for a while and then it fails

At this point I think I'll be redoing websockets. For now, disable them

how can i disable it i have the same problem it works fine for a while and then it fails

Hey Isaack what's your paypal?

Hey Isaack what's your paypal?

PayPal.Me/isaackogan

At this point I think I'll be redoing websockets. For now, disable them

how can i disable it i have the same problem it works fine for a while and then it fails

I'm not sure it helps anymore. I'm looking into a fix for all of this.
Isaac

Do you think this can still be fixed?

Do you think this can still be fixed?

I know for a fact it can. Am waiting until I get home.
Isaac

Do you think this can still be fixed?

I know for a fact it can. Am waiting until I get home.
Isaac

how to disable?

Fixed


Missing Contribute.md file

The repository currently lacks a CONTRIBUTING.md file, which is an important resource for guiding potential contributors on how to engage with the project effectively. A CONTRIBUTING.md file outlines the contribution guidelines, coding standards, and procedures for submitting pull requests, thus streamlining the contribution process and ensuring consistency across contributions.
Could you please assign this issue to me under GSSOC 24.

Hi Contribute.MD Is a crucial file that contains all the potential information on how to create your own pull request and for new beginners regarding this project and therefore with a knack of content writing
I would really love working on that and this includes all the contribution guidelines and all the standards of coding with the procedures of how to submit a pull request thus it is very important to have a contributing dot MD file and therefore,
I would be very very happy if you would assign this task to me I will create all the necessary informations with that contributing dot md file with all the git bash commands and other things so I would really request that can you please assign this task to me under the GSSOC 2024.

Duplicate issue. Already raised #35


how use defaultifempty

How can I use default to return a value when an item does not exist in an array in structurelinq?

Hi,
DefaultIfempty is not implemented (Issue #12)
Regards


asking for apt-utils

during build there is a warning about apt-utils
debconf: delaying package configuration, since apt-utils is not installed
can someone look into this what this means for us.

https://github.com/gardenlinux/gardenlinux/pull/161 should fix this.

I just rebuilt #161 but it does not remove the message.

Removed the closes from the #161 PR. The PR in itself still makes sense.

This seems to be a non issue, except for the annoying warning.
Some resources:
https://stackoverflow.com/questions/51023312/docker-having-issues-installing-apt-utils/51023393#51023393
https://github.com/phusion/baseimage-docker/issues/319
Since the apt-utils are not installed when installing apt-utils, you can't avoid the message through installing apt-utils, either. Since it does no harm I would just leave it.


can't use a different port for ios

Description
I want to be able to start 2 metro bundlers together, to do that I needed to configure metro to run on different ports other than 8081, I set one app to run on 7000 and the other one to run on 7001 with the following steps:

Replace all 8081 with the desired port -- 7000 and 7001 -- there was only one result in the search, which was in project.pbxproj
run react-native start --reset-cache --port 7000 --reset-cache

Then I run android by running cd android && ./gradlew clean && cd .. && react-native run-android --variant=devDebug --appIdSuffix=dev --port 7000 and it worked like a charm, on the other hand, I run ios through XCode and it seems that it can't connect to the desired port, I tried manually setting the port by shaking the device but even that doesn't work.
Version
0.67.4
Output of npx react-native info
System:
    OS: macOS 12.2.1
    CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
    Memory: 1.89 GB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.18 - ~/projects/samalapit/buyer/mobile-app/node_modules/.bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.2 - /Users/aprilmintacpineda/.rvm/gems/ruby-3.0.2/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8193401
    Xcode: 13.3/13E113 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.11 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.67.4 => 0.67.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
Included in the description above.
Snack, code example, screenshot, or link to a repository
No response

There's a solution state here but it did not work for me.
https://github.com/facebook/react-native/issues/30708#issuecomment-1007307841

I can confirm that it is still using 8081 as a port even after changing it to 7000 because when I closed the app, changed everything back to 8081, then start metro bundler (with 8081) and simply open the app (take note that I did not reinstall the app), it worked. So it's using 8081

This was fixed in #33726


DRAFT: add dispatch

This is a work-in-progress draft to add dispatch

I saw that CI failed on this much like I experienced myself. Seems like jakt somehow doesn't like zero in the first match or something.
Example:
                0x00 => .brk()
                0x01 => .ora(opcode)
                0x05 => .ora(opcode)

Would crash with a c++ error. But if you change the code to this:
            match opcode {
                0x00 => { .brk() }
                0x01 => .ora(opcode)
                0x05 => .ora(opcode)

Then somehow jakt output is valid c++. So not sure why it doesn't like the first match to be without brackets. I should probably add this as an issue at the jakt repo :P


remove extraneous _log operations (e.g., ccdf, cdf)

Right now, we can write
y ~ normal_ccdf(mu,sigma);

to be equivalent to
increment_log_prob(normal_ccdf_log(y, mu, sigma));

[ ] create an explicit list to store symbols for which ~ is disallowed
[ ] add the CDF and CCDF functions and other existing ones with _log suffixes

This has been fixed.


Install tensorflow-cpu package when building docs on Read the Docs

With tensorflow 2.1, the tensorflow package includes GPU support by default. This seems to be enough to exceed readthedocs's memory limits and cause the build to fail. tensorflow-cpu 2.1 does not hit this problem, and so we can fall back to that when building documentation.
We probably want to make this more generally configurable (#546), but that's a more intricate problem, and this gets us back to having working documentation.
This also switches to only using the dependencies in setup.py, as building documentation doesn't need any of the dev dependencies listed in requirements.txt.
See: #602

Also, it's not immediately obvious but this means we now build our documentation for every pull request, so it's easy to check that it looks good. E.g., for this PR:

The "Details" link goes to https://external-builds.readthedocs.io/html/stellargraph/631/index.html


fix(core/event-list): remove unwanted top margin

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (yarn build) was run locally and any changes were pushed
[ ] Unit tests (yarn test) were run locally and passed
[ ] Visual Regression Tests (yarn visual-regression) were run locally and passed
[ ] Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

[x] Bug fix
[ ] Feature
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

GitHub Issue Number: #994
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[x] No

Testing

Other information

Closes #994


Add SpatialQuery notebook 2

complements #107

@keller-mark can you look at the vitessce version?

The latest version of the vitessce python package 3.4.2 (PR) should resolve the workspaces/portal-visualization dependency conflicts

@NickAkhmetov are we bumping the workspace base version to 3.4.2?


Server-side Mod

Hi,
I understand that this is unlikely to happen, but please could you consider creating a server-side mod(Fabric 1.16.5) with all of the features that can be done server-side.
I really want to use this on my server, but the server is server-side only and this mod is needed on the client as well as the server.

I doubt I'll make a standalone mod, but I suppose I could try to add a config option of sorts that makes the mod able to only be run on the server side.

That would be great!
Thank you for considering it!

Feature added in upcoming release.


[UI] Namespaces top header filter not filtering applications and configurations

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Issue:
Top header filter for namespaces fail to filter apps and configurations. It hides them instead.
Example:
https://user-images.githubusercontent.com/37271841/191685581-d621f13f-3d2f-4489-906b-ff9db1397d3a.mov
Expected Behavior
Filter should be applied and display the apps / configuration associated to that namespace filtered.
Steps To Reproduce
Steps:

Create several namespaces
Create several apps and configurations associated to each namespace created
Filter by namespaces on Application or Configuration menu

Environment
- OS: Linux
- Architecture: amd64
- Epinio Version: v1.2.0-23-g11a2d241
- Cluster:
  - Provider:k3d
  - Options:
  - Kubernetes Version:v1.20.11+k3s2

Logs
No response
Anything else?
No response

We should re-test this after merging in rancher/master

Tested on epinio-dev and working:
https://user-images.githubusercontent.com/37271841/198076199-328d8a96-4d4d-4792-b1b6-c1c2b7da3ef9.mov


Struct inheritance

Found when doing bindgen for libuv
struct uv_stream_s {
  UV_HANDLE_FIELDS
  UV_STREAM_FIELDS
};

struct uv_tcp_s {
  UV_HANDLE_FIELDS
  UV_STREAM_FIELDS
  UV_TCP_PRIVATE_FIELDS
};

struct uv_pipe_s {
  UV_HANDLE_FIELDS
  UV_STREAM_FIELDS
  int ipc; /* non-zero if this pipe is used for passing handles */
  UV_PIPE_PRIVATE_FIELDS
};

Would it make sense to have an implicit cast operator as a pointer value for "subclass" structs?

This would probably require looking at macros which I'm not interested in.


DLL load failed while importing pyclariuscast

Previously was using Cast for Clarius App 9.4.0 on Windows 11 system. In order to add the system to the local domain the system needed to be wiped and moved to Windows 10. After adding the device to the domain we wanted to reinstall the cast software. Installed python v 3.8.10 using windows installer, updated pip to 22.2.2, updated Pillow to 9.2.0, installed PySide2 version <IP_ADDRESS>. We then made sure the code and corresponding cast libraries were in the same directory. (These are the same steps as what we did to have the code run when it was on Windows 11) After attempting to run both python examples we encountered the same error where importing the pyclariuscast library fails.
"ImportError: DLL load failed while importing pyclariuscast: The specified module could not be found."
Tried uninstalling and reinstalling and encountered the same issue.

looks like you already confirmed that you're on python 3.8, maybe double check, as this thread also pinpointed the same error message to the version: https://github.com/clariusdev/cast/issues/46

After a quick double check I can confirm the system is running python 3.8.10. I'm quite perplexed because I followed the exact same procedure as I had when setting it up previously (Thoroughly documented my process the first time through with no issues)

ok, thanks for checking, it's unlikely the python dependencies (pillow, etc) have any impact on finding the DLL, so perhaps check your path, and add an explicit environment variable to where to find the location of the DLL

Tried adding a system environment variable to the location of the DLL and produced the same error after a system restart to ensure the changes went into effect.
Also, separately, tried placing the DLL in the LIB\site-packages folder and ensured it appears in the Python PATH which continued to produce the same result.

you would want to make an exception for python.exe, which probably isn't the safest, but it's the only method sso far that has worked for users based on similar messages I've seen on the forum


:seedling: ignore the manifest uid

Summary
Ignore the manifest uid to avoid UID precondition failed error
Related issue(s)
Fixes #

/assign @qiujian16

/approve
/lgtm


Support loading HFP configuration from file (#1)

I think this doesn't need to be loaded in device? Passing a parameter to load in examples/run_hfp_handsfree.py is enough.

I think this doesn't need to be loaded in device? Passing a parameter to load in examples/run_hfp_handsfree.py is enough.

Since we would like to use the device directly in our application, passing parameters to examples might not fit our requirements.
Might I know how can we determine which functions can be added to the device? Thanks for the help.

I think this doesn't need to be loaded in device? Passing a parameter to load in examples/run_hfp_handsfree.py is enough.

Since we would like to use the device directly in our application, passing parameters to examples might not fit our requirements. Do you have any suggestion? Thanks. Might I know how can we determine which functions can be added to the device? Thanks for the help.

I agree with @zxzxwu here. This config is an HFP-specific config, which the Device object doesn't use at all. It's only needed to instantiate a HfProtocol object (as is done in the HFP example app). If you want to pass a config file to run_hfp_handsfree.py, that code should be enhanced to allow parsing a config file (as you have done in this PR). If you're writing a different application, you would parse the config file from there. It may be useful to offer the JSON config file parsing function as a reusable helper, so that different apps could use the same method without having to re-implement that code. That function could therefore be located in hfp.py.

I think this doesn't need to be loaded in device? Passing a parameter to load in examples/run_hfp_handsfree.py is enough.

Since we would like to use the device directly in our application, passing parameters to examples might not fit our requirements. Do you have any suggestion? Thanks. Might I know how can we determine which functions can be added to the device? Thanks for the help.

I agree with @zxzxwu here. This config is an HFP-specific config, which the Device object doesn't use at all. It's only needed to instantiate a HfProtocol object (as is done in the HFP example app). If you want to pass a config file to run_hfp_handsfree.py, that code should be enhanced to allow parsing a config file (as you have done in this PR). If you're writing a different application, you would parse the config file from there. It may be useful to offer the JSON config file parsing function as a reusable helper, so that different apps could use the same method without having to re-implement that code. That function could therefore be located in hfp.py.

Thanks for the clarification.
Could I keep the HFP configuration to the same device configuration, or do I need to use a separate HFP-specific config file to indicate the HFP feature?
For instance
def from_config_file(config): # in hfp.py
    ...

configuration = hfp.from_config_file(sys.argv[1]) # in our application

A question here is that, since HFP is not loaded by default, your application should have an entry for HFP, right?
If there is a customized entry point, could you modify there to take parameters?

A question here is that, since HFP is not loaded by default, your application should have an entry for HFP, right? If there is a customized entry point, could you modify there to take parameters?

Thanks for the clarification, will pass parameter from our entry point.


Let us add our Mastodon addresses

Can we add our Mastodon addresses to our profile so we may be tagged with a hyperlink in a similar way to what happens currently on T*****r
Currently the messages just have static text with something like "℅ MapSpot on github
CC BY-SA 4.0"

BTW I am https://mastodon.online/@back_ache

We currently us Auth0 for login. I've asked them for Mastodon support.  See https://community.auth0.com/t/mastodon-social-login/103400 for details.
It would help if you contacted Auth0 to let them know that this is a feature people want.
Or, alternatively, we need someone who can write a custom integration for Mastodon.

I've had to authenticate via facebook but I'd much rather have done it via my mastodon account ... Bit of a shame they still don't seem to have a solution for this yet :-(

I am working on this. The problem is that each Mastodon instance requires their own API key. So I either need several thousand integrations or I can just pick one or two popular instances.
If you know of any site which has a generic "Sign In With Mastodon" service - please let me know. Then I can try and work out how they've done it.

https://pixelfed.blog/p/2023/feature/introducing-sign-in-with-mastodon-streamlining-sign-up-and-login-on-pixelfed appears to offer generic 'sign in with Mastodon' for their app, if that helps.

The Mastodon Socialite plugin has code for doing the oAuth connection but expects you to have already registered as an app with the single Mastodon server to obtain the Client key and Client secret.
The way I have written this in the past is by having a table for storing client key, secret and instance url, if someone tried logging in via mastodon it asks for their instance url, if not already existing in that table the login request uses the Mastodon api to register with the instance as an app with limited scope, then continues with oAuth authentication as normal. This allows you to support all Mastodon instances (and others that implement the Mastodon API) without having to first preconfigure anything.

OK! You can preview logging in with Mastodon (and GoToSocial) at https://openbenches.org/mastodon_login
Please let me know if it works or breaks.
Once I'm happy with it, I'll add it to the list of Auth0 login providers.
Known bugs:

No way to retrieve profile image based on user's ID - so they just get a default icon on the leaderboard
Logging in from the Edit screen might return you to the Add page
More error checking if the supplied URl doesn't work
Let me know if you spot any more!

Ping to @backache @sxa @paulwakeford - Sign in with Mastodon is now an option. Let me know if you spot any bugs with it.

Was hoping to use this on my short trip to Malta but despite there being plenty of benches apparently none of the benches have plaques 😭 Disappointing!

Was hoping to use this on my short trip to Malta but despite there being plenty of benches apparently none of the benches have plaques 😭 Disappointing!

I know what you mean I went on a cruise earlier this year hoping to "bag some benches" as we stopped in Spain, Portugal, Gibraltar and Morroco but didn't find much if any!


Improve platform support

Pull Request Test Coverage Report for Build 231

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.819%

Totals

Change from base Build 230:
0.0%

Covered Lines:
644

Relevant Lines:
717

💛  - Coveralls

Thanks for the PR. That was a nasty bug with platform_is_linux not using a function call. Thanks again.


Update Piaware - Git Pager fix

Just a heads up the "version" variable is currently in two places both install.sh which you changed and bash/piaware.sh. I will be consolidating redundant variables as work progresses in the branch named cleanup.
I will test out the change tomorrow morning and merge afterwards.
Thanks for the contribution.

Actually got around to checking this out tonight.
Ran into a problem.
Cloning into 'piaware_builder'...
remote: Counting objects: 115, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 115 (delta 0), reused 0 (delta 0), pack-reused 112
Receiving objects: 100% (115/115), 27.03 KiB | 0 bytes/s, done.
Resolving deltas: 100% (65/65), done.
Checking connectivity... done.
error: pathspec 'tags/v5c77c4924' did not match any file(s) known to git.

piaware.sh is setup to pull tags not specific commits:
git checkout tags/v${CURRENTVERSION}

Things were done this way in order to make use of the CURRENTVERSION variable usable not only when cloning a specific tag but also to check if the current version is already installed as well as used to tell the script the correct name of the package to be installed after it has been built.
A way to check if or specify the "CURRENTVERSION" as a commit will need to be added before being able to pull a specific commit from that repository. I hate adding yet another variable and being forced to keep the temporary fix needed due to the fact the 2.1-5-jessie tag kept the same version number as the older 2.1-5 tag but it is looking like this might have to happen...
I am afraid to go back to pulling the master branch being there was issues with work being done there which lead to problems and the addition of the current system.

Well, the current problem that the fix solves seems to be kind of a corner case, and @mutability gave the tip of how to get around it without needing the fix committed. I don't know about future issues that arise in between tags though.

Why you did not run into any installation errors would be due to the fact the repository would have been cloned and set to the master branch. When trying to change to the nonexistent branch named 'tags/v5c77c4924' in this case git would have reported the error above but installation would have continued on using the master branch.
Honestly it is something that should be trapped somehow by the scripts.
Things such as this will come over time and things mature I'm sure...
Anyways while relocating variables into a single location I went ahead and made the fixes you outlined. as well as fixed the checkout issue. https://github.com/jprochazka/adsb-feeder/issues/48
Once again thanks for pointing out the newer branch containing a needed fix.


(PDB-3092) Create a partial index in resource_events for querying by corrective events

The main purpose of this index is to help resource_events queries with corrective_change = true - that is the case of PE Events queries.
It's expected that minority of events are corrective, so the partial index wouldn't consume a lot of disk space and improve performance.

@wkalt This index has already been discussed in #2078

CLA signed by all contributors.

@kbrezina has the index been tested?

@wkalt I've tested it locally with events queries from PE Events. The response times were several times faster when the query had corrective_change = true condition and this index was in place.

Test PASSed

Test PASSed

I left a comment on Ken's outdated diff. To summarize, I was wondering if we were missing an opportunity to benefit queries other than the console's by making this index on status instead of corrective_change. I did some testing on a table of 23,942,016 events with a random 5% set to corrective_change=true. Results are here: https://gist.github.com/b671019d324afd5556f1c33a7c59138b
Takeaways are:

The planner is smart enough to use this index in queries against corrective_change alone (status uninvolved)
Queries against corrective_change and corrective_change + status both execute faster with Karel's index than with a partial index on corrective_change alone. The second result is expected, the first doesn't make much sense to me but is enough to convince me we're not hurting queries against corrective_change only by making the index on status.

With that in mind I'm +1 on this change.

@wkalt @kbarber Thanks for your review. 👍
I'll try to provide more details next time.

@kbrezina no worries mate, thanks for the work, and thanks @wkalt for digging in for proof.


Not working in webGL

Superb SDK and great for building to windows and other platforms.
I cannot seem to get it working with a webGL build.
Any help would be greatly appreciated.
Steps to reproduce the problem
Build to web GL - upload to server, and test. Video doesn't load
Unity version
2019.3.0f6
Operating system
Windows 10

Yeah same here. Getting this issue as reported by Google Dev Tools:
The referenced script (Vimeo.Player.VimeoPlayer) on this Behaviour is missing!
(Filename:  Line: 199)
The referenced script on this Behaviour (Game Object '[VimeoPlayer]') is missing!
(Filename:  Line: 334)
A scripted object (probably Vimeo.Player.VimeoPlayer?) has a different serialization layout when loading. (Read 32 bytes but expected 904 bytes)
Did you #ifdef UNITY_EDITOR a section of your serialized properties in any of your scripts?
(Filename:  Line: 2269)
The script was certainly attached when I built it. Looks like something is stripped on compile.