How to add UNSAFE_IGNORE_CERTIFICATE_ERRORS=true Option?

I am using Home Assistent and added your repository. How can i add the UNSAFE_IGNORE_CERTIFICATE_ERRORS=true option? I am running into a ssl cert error because of using a self signed cert. You added the option, but where is it?
I added the line in the Addon "UNSAFE_IGNORE_CERTIFICATE_ERRORS: true" (edited as YAML) but without any changes.

Thanks for the report!
it seems like that option isn't exposed to the new Hassio container yet.
I'm not sure when I'll time for this, as there's currently a lot going on.
The changes shouldn't be huge - kind of similar to PR69, if you want to do it yourself.


Update to react v15.0

See https://facebook.github.io/react/index.html
After upgrading to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>npm starts complaining:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

1.3.1 now has the right peerDep. Thanks.


[Feature]: Allow upgrading using image catalogs

Is there an existing issue already for this feature request/idea?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new feature request to be evaluated.

What problem is this feature going to solve? Why should it be added?
We are normally able to change the operand image of a cluster to any version. Now we are looking at image catalogs from (#3711) to simplify and centralize version management, but they seems to be locked down when it comes to changing the major version.
Describe the solution you'd like
Either not enforcing this:
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Major is immutable"

or changing it so there is a way to say "I know what I am doing" and allow changing the major version.
Describe alternatives you've considered
Setting which image to use explicitly on each cluster:
spec:
  imageName: ghcr.io/cloudnative-pg/postgresql:15.7

Additional context
No response
Backport?
No
Are you willing to actively contribute to this feature?
No
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Changing the PostgreSQL major version is not as easy as changing the container image. You have several possibilities.
The default way of operating is to use the database import feature to import data onto a new cluster.
If you need a very low downtime, you can use the logical replication following Gabriele's blog How to migrate your PostgreSQL database in Kubernetes with ~0 downtime from anywhere.

I had assumed that the container image was "the way" to handle upgrading including major versions (we have not yet changed major versions).
Those resources for upgrading are sure to come in handy when we get there. It would have been an unwelcome surprise otherwise, when we had a failed upgrade.

Sorry to hijack this closed issue but when following this blog I get this webhook validation error:
one or more objects failed to apply, reason: failed to create typed patch object (vision-ai-hub/cluster2; postgresql.cnpg.io/v1, Kind=Cluster): .spec.bootstrap.initdb.import.schmaOnly: field not declared in schema. Retrying attempt #4 at 8:30AM.

Apparently that field does not exist in the schema? I'm using the latest cnpg operator release.
@mnencia  any idea?

Hey, sorry to hijack this issue, but I just tried it according to the blog.
Even though I specifically told cnpg to import "hasura" database
bootstrap:
    initdb:
      import:
        type: microservice
        schemaOnly: true
        databases:
          - hasura
        source:
          externalCluster: hasura

This database does not exist after bootstrapping. Only a database "app" and role "app" was created.
@mnencia Might this be a bug?


:sparkles: Introducing HEPL

:sparkles: Introducing HEPL

:sparkles: Introducing new features

:sparkles: Introducing HEPL


EXC_BAD_ACCESS

What did you do?
parse raw string into JSON
What did you expect to happen?
should be no error, and i can access parameter even it's empty
What actually happened instead?
i got an error, that make my app force closed
Environment
List the software versions you're using:

SwiftyJSON: 4.0.0
Xcode Version: 9.2 (9C40b)
Swift Version: 3.2

Please also mention which package manager you used and its version. Delete the
other package managers in this list:

Cocoapods: 1.3.1
Carthage: none
Swift Package Manager: none

Project that demonstrates the issue

Please help how to resolve this error
Thank you

@black-lotus Sorry for my late response. Could you send me an example project which can reproduce this issue?


Custom handling of push events

Currently on moose devel push events, we auto cancel any jobs on previous events. This can lead to the devel->master merge not happening until the end of the day.
The proposed alternative is to have a "current" event that will run to completion even if other push events happen after it. This ensures that we at least get some merges to the master branch throughout the day.
For example:

event E1 happens. All jobs on E1 will get run, no matter what
event E2 happens while E1 is running. Jobs on E2 won't start until all jobs on E1 are started. If all jobs on E1 are running/done then jobs on E2 can start.
event E3 happens while E1 and E2 are running. This cancels all jobs on E2. The cancelling logic would cancel any event back to the first event that is running. Jobs on E3 won't start until all jobs on E1 are running/done.
event E1 finishes. Now jobs on E3 become the "current" and will finish before any subsequent events.

@permcody and @aeslaughter Does this capture what you wanted?

One drawback of this method is the case where a bunch of stuff is merged in a short time frame. This seems to be a somewhat common occurrence in the morning for example.
We would get the first merge running to completion and then eventually the last merge. If they all happen in a short time frame, it might be better just to run the last one to completion.
We could combine the above strategy with a heuristic for doing the canceling of events. Maybe using total event job running time?
For example, if E2 above happens 5 minutes after E1, the total job running time of E1 will still be quite small even if all the jobs got picked up immediately. So we would cancel E1 and start on E2 (E2 would be the "current" event and would potentially be run to completion).
If E3 happens a hour after E2, the total job running time of E2 would get checked. If hardly any jobs have been picked up (due to there being a bunch of PRs using the build boxes) then the total job running time would be small and we would cancel E2 and start jobs on E3. If, however, E2 has been running a while, then E2 would remain the "current" event and finish to completion.
Basically we would setting a "point of no return" for an event. After a threshold of total job running time has been exceeded then that event would run to completion. If it hasn't been exceeded, then it can still be auto cancelled.
Thoughts?

I'm not a huge fan of any heuristic here or time-based strategy because it will constantly discourage devs to merge. We'll hear people say, "well, we merge it after lunch because CIVET has only been working on it for 30 mins and will cancel... or it's almost done so we need to let CIVET catch up".
I see your point that the first merge of the morning will just go through and the second through fifth ones won't even be tested for a few hours. I still think it's a better strategy because it won't discourage merges of any kind at any time.
One way we could get around the drawback you mentioned is allow a human to cancel any job in the list, or perhaps even a new button that just manually cancels the "current" merge event as we are calling it. If we had that, CIVET should recognize that it's not possible to complete that event and move to the next strategy (designate a new "current").


Add args on phpunit in makefile

In order to pass phpunit args like --filter

@tony-tran makefile updated


integration with wikimaps site or dynamic wikimaps/projects tab layout

Closing this as the plan now is for mapwarper to just act as an API.
The front end would be in another project


Update to latest LLVM and wasi-libc

Among other things, this pullls in https://github.com/llvm/llvm-project/commit/1d445a6e7679cc188fd051f7397b7d9ca8ce4f10, which is needed by https://github.com/bytecodealliance/wizer/pull/8 .

Don't we want to pin to specific llvm releases here?  (or is this the llvm 13 branch point?)

Ah, no, this isn't the LLVM 13 branch point. This is just pulling in a recent revision so that we get the above-mentioned patch to fix  bytecodealliance/wizer#8.
wask-sdk has previously used LLVM release revisions, but I don't know that we need to. If our own tests pass, and LLVM's buildbots are reasonably healthy, and we have a real-world use case that would benefit from a recent fix, it seems advantageous to pull in the new revision.

I think it would be nice to stick to released versions but I wont block this.   IIUC the workaround for bytecodealliance/wizer#8 is to just run wasm-opt which does the de-duplication so I'm surprised this is urgent for that use case.
lgtm though if you feel like it worth it.

This is superceded by #197.


silx.gui.plot.PlotWidget: Refactored item management

This PR is changing the way items are stored inside a PlotWidget. This aims at making it simpler and solves issues like #3896. On the down side, it might change the behaviour of item management when not using the PlotWidget.add* methods...
Still needs testing
closes #3896

As you said, maybe an extra test could be added? If it makes sens.

I added a test from the sample code in #3896


244 update release process and add release guide to developer documentation

@constantinpape
the workflow release_drafter.yaml creates a release plus informations specified in release_config.yaml
atm the workflow does not stop when the software version number has not changed. The workflow does not crash but reports errors trying to create a version number already existing.
I will post the message below...

update_release_draft
Validation Failed: {"resource":"Release","code":"already_exists","field":"tag_name"}
{
name: 'HttpError',
...

I tried this on my own fork now, and as far as I can see this works as expected!
But the PR here is a bit mixed up and I can't merge it on master (probably due to the force push we had to do earlier), so I will close this in favor of the clean PR #564.


Seq unused methods removed

both methods are overridden in LinearSeq and IndexedSeq

Current coverage is 92.14%

Merging #960 into master will increase coverage by +0.17% as of a11e8cc

@@            master    #960   diff @@
======================================
  Files           74      74
  Stmts         8888    8871    -17
  Branches      1712    1708     -4
  Methods          0       0
======================================
- Hit           8175    8174     -1
  Partial        175     175
+ Missed         538     522    -16

Review entire Coverage Diff as of a11e8cc

Powered by Codecov. Updated on successful CI builds.

Thx!


Create nextjs + nextauth dummy application

Use a deployed sandbox to test various OIDC integration + private key JWT flow
GC Forms soon to be libs versions:
Nextjs : 14.0.4
NextAuth: 4.24.5
repo: https://github.com/wmoussa-gc/next-auth-sandbox

try to leverage https://github.com/awslabs/aws-lambda-web-adapter

for ECAS: start investigating the proxy in - ip whitelist for SSC

will require a static IP that will need to be unblocked at SSC in order for your server to be able to reach our dev servers.

I have also implemented a sandbox to explore various OIDC integrations. Currently, it is using Okta. It was developed with NextJs, NextAuth, Terragrunt, Terraform, Docker, GH Workflow and Lambda Web Adapter. You can test it here: Sandbox OIDC


Using [url=...] breaks get_character_paragraph and get_character_line

Godot version
4.0.beta2
System information
Linux
Issue description
RichTextLabel fails to account for the characters taken up by the URL (I think) when [url=...] tags are used.  This causes get_character_paragraph and get_character_line to return incorrect values when several long URLs are used.
Steps to reproduce
Please see https://github.com/nerdbeard/RichTextLabel-offset/blob/main/anchor.gd for a minimal example.
Minimal reproduction project
https://github.com/nerdbeard/RichTextLabel-offset

A comment in RichTextLabel::get_total_character_count() says:

// Note: Do not use line buffer "char_count", it includes only visible characters.
This appears to be exactly what get_character_line() and get_character_paragraph() do, they use char_count and char_offset, which only include visible characters.  I think they need to be rewritten to use item->text.length() to calculate their own offsets.

I don't understand whether this would have other consequences but I'm going to try and code it and see what happens.

Maybe I need to teach RichTextLabel::append_text() to push some kind of null to represent the invisible characters

This is how it is supposed to work. get_character_line() and get_character_paragraph() count only text characters, tags are not counted (this is true for all tags, not just url).

I guess getting line/paragraph for the position in the BBCode source is useful to have, so we should add an option to do so (an extra argument for the get_character_* or a new set or functions).

Thanks, @bruvzg!  Is how it's supposed to work documented anywhere?
My use case is that I want to scroll to the position of a string in the text.  I only know the offset into the text I submitted to the control (which likely has BBCode in it) and I don't see that I have access to the offsets into the rendered text.  I'm not sure how scroll_to_line and scroll_to_paragraph are meant to be used in conjunction with the source text, but I think I'm doing things the most obvious way.
The Line private struct of RichTextLabel has members char_offset and char_count.  Could I add char_raw_offset and char_raw_count?

Calculating the required address in GDScript was a lot easier than changing the engine for me obviously but if there's any desire for this feature I'd be interested in working on it.


DocXML updates

State management classes
Twilio adapter classes
and others

@cleemullins you may want to add @gabog as I hit the Twilio adapter library.

Pull Request Test Coverage Report for Build 75600

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 80.409%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder/ActivityHandler.cs
1
8.57%

/libraries/Microsoft.Bot.Builder/BotState.cs
3
20.65%

Totals

Change from base Build 75596:
-0.04%

Covered Lines:
3423

Relevant Lines:
4257

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1


Cannot git clone https://github.com/timeplus-io/proton.git

Hi all,
I try to do a git clone of https://github.com/timeplus-io/proton.git with totroise git (windows 10) and git bash (cli in win 10).
In tortoise I get
git.exe clone --progress --recursive -v -- "https://github.com/timeplus-io/proton.git" "D:\temp\delme\sensors\proton"
Cloning into 'D:\temp\delme\sensors\proton'...
POST git-upload-pack (185 bytes)
POST git-upload-pack (gzip 7612 to 3840 bytes)
remote: Enumerating objects: 804164, done.
remote: Counting objects: 100% (3357/3357), done.
remote: Compressing objects: 100% (1434/1434), done.
remote: Total 804164 (delta 2184), reused 2740 (delta 1910), pack-reused 800807
Receiving objects: 100% (804164/804164), 472.72 MiB | 20.11 MiB/s, done.
Resolving deltas: 100% (639705/639705), done.
error: invalid path 'tests/integration/test_checking_s3_blobs_paranoid/configs/setting.xml '
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

git did not exit cleanly (exit code 128) (47937 ms @ 6/20/2024 12:11:48 PM)

and in cli I see:
$ git clone https://github.com/timeplus-io/proton.git
Cloning into 'proton'...
remote: Enumerating objects: 804164, done.
remote: Counting objects: 100% (3353/3353), done.
remote: Compressing objects: 100% (1424/1424), done.
remote: Total 804164 (delta 2182), reused 2752 (delta 1916), pack-reused 800811
Receiving objects: 100% (804164/804164), 472.73 MiB | 16.61 MiB/s, done.
Resolving deltas: 100% (639707/639707), done.
error: invalid path 'tests/integration/test_checking_s3_blobs_paranoid/configs/setting.xml '
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

I bot cases I get a directory proton with only .git inside it.
What should I do?
Lucian

Hi @lmsasu , thanks for reporting this.  I saw an extra space in

error: invalid path 'tests/integration/test_checking_s3_blobs_paranoid/configs/setting.xml '
Not sure whether it is related.

If you just want to run the awesome logger example, you may download the source code as a zip. Timeplus Proton correctly cannot be compiled on Windows, FYI.
In the meanwhile, let me find a Windows server to reproduce the issue you mentioned.

hi Lucian!
proton is not supported running in win10, but it work in wsl2 (ubuntu2004/ubuntu2204)
for the clone repo, I assume we can directly download the zip if you are not going to code change?
https://github.com/timeplus-io/proton/archive/refs/heads/develop.zip


[DOC]: Add react interview question to JSON file

We are collecting often asked interview questions for Web Developers. Before adding questions and answers, please make sure if the question is already added or not. Use the search option to search your questions Ctlr+F/ cmd+F
path src/json/interviewquestions.json
Topics:

How to add questions?
If you add HTML questions, then you have to use html tag, if CSS questions then use css, and so on.

Hey, I suppose we have to create src/json/javascriptinterview.json since I can't find it right ? The question and answer is copy pasted from online right ?

Im so sorry for the inconveniences. we changed the file name to
interviewquestions.json
On Sat, Mar 11, 2023, 3:55 AM Eslem @.***> wrote:

Hey, I suppose we have to create src/json/javascriptinterview.json since I
can't find it right ? The question and answer is copy pasted from online
right ?
—
Reply to this email directly, view it on GitHub
https://github.com/devvsakib/power-the-web/issues/242#issuecomment-1464520374,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVB7I4I2DLQ2Q3BYM2YCD7DW3OPMNANCNFSM6AAAAAAVW52MQY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you!

Hey, https://github.com/devvsakib/power-the-web/pull/251 is my pull request
please review and merge it
thankyou.

Merged #251
PR: @imlakshaychauhan

@devvsakib ,i have a bunch of questions for react,could you please assign it to me

sure @karthiknadar1204

Almost done,will merge pr by tomorrow night

Suree no problem, take your time @karthiknadar1204

Hi, can I work on it?

yes. everyone can add questions @

can we add more than one question. @devvsakib

@devvsakib ,have added two questions on react js,have committed the changes and initiated a pr
Thank you

Hello @devvsakib I have added one single react question, but I see that it wasn't merged yet. Shall I be assigned to the issue first ?

I reviewed your PR @EslemOuederni , so sorry for the late reply. please check my comment. Thanks

Merged #277
PR: @EslemOuederni


APT whitelist request for libproc-dev

EDIT: Corrected package name to match ubuntu precise name convention.

Requested package name is for newer version of ubuntu than precise.


Question: Does iOS 10 support MediaSource yet?

Hi,
Have anyone tried the iOS 10 Preview, and tested if it supports MediaSource yet?
Thanks :)

I had a colleague try our support test page on iOS 10 preview, and it appears that it still does not have MSE support.  We'll keep our fingers crossed for iOS 11.  :-)

Asked a developer at WWDC. Doesn't seem like it's in the top of their priorities.
Told me to file an enhancement request radar J.

Tested as at Feb 7th 2017.  IOS still can't use Shaka (Tried Safari and Chrome on iPad).

One question though, how does dashjs play on ios?

@Portmansa, does dashjs indeed play on iOS?  I haven't been able to make their demo page work on iOS at all.
caniuse.com reports that MediaSource is still not available on iOS 10.3: http://caniuse.com/#feat=mediasource
Just searching quickly through dashjs source, I see that MediaPlayer's initialize() method fails if MediaSource is not present.  Further, the MediaSource check allows for a prefixed version called WebKitMediaSource.
So it would seem that the only way iOS could be supported in dashjs directly is if WebKitMediaSource were available on iOS.  I just checked both Safari & Chrome on iOS 10.3, and WebKitMediaSource is not defined.

@joeyparrish Yeah, I got it working on iOS with HLS. Live streaming was working too

iOS has a native HLS implementation.  Essentially, when you use HLS with dashjs, you aren't using dashjs for playback at all.

@joeyparrish BTW, can shaka player play HLS on iOS?

Shaka Player only uses MediaSource.  If you want to bypass MediaSource, then you don't need Shaka Player.  Just do something like video.src = '/foo.m3u8';.  I'm not sure what value Shaka Player could add in that scenario.

Do we have any idea when Apple plans to support MSE API?

Sorry, we don't know anything.  Any authoritative answers about about future MSE support on iOS would have to come from Apple.
However, we will support a fallback to iOS's native HLS support in #997.


feat: Added python script to export MDFC recommendations for WAF alignment

Description
Added python script to export MDFC recommendations for WAF alignment. This is a helper script we use to align our modules to the MDFC security recommendations. The script exports all recommendations from this
Type of Change

[X] Update to CI Environment or utilities (Non-module affecting changes)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[X] I'm sure there are no other open Pull Requests for the same update/change
[X] I have run Set-AVMModule locally to generate the supporting module files.
[X] My corresponding pipelines / checks run clean and green without any errors or warnings

Hey @sebassem,
Thanks for this, but apologies I actually meant to this location https://github.com/Azure/Azure-Verified-Modules/tree/main/utilities 👍
Can you PR it into there?


Changing Year in Events to an Integer, setting up validations and testing

Converted the year attribute in Event model from string to integer.  Created validations to enforce numericality and integer, used should matchers to make sure it stuck.  All other tests pass (though since I don't know cucumber well I can't write a validation test to make sure it works on form submission - that's probably over thorough possibly?)

Thank you, John. I'll check this out tomorrow!

Hi John,
Thanks for this!
What happens with the records in the DB that already have years as strings in them? I think we may need to do a bit more here.

Right, production, that’s going to be an issue
The migration drops the column and then adds it again as an integer (the change column to integer is complex with postgres and this seemed easier) but I forget about production already being active.
Have you ever used PSQL Dump?  There’s ways to dump all the data from a postgres database into a form that you can use to reload it if you’re making changes - i use it for testing in an application because the data needed to test requires a lot of data, and specific data’, you could use PSQL dump on the Events database, run the migration, then load it back in.  Crap I did it the cleaner way for me but maybe I should have done it the harder way…sorry

On Mar 6, 2017, at 11:30 AM, Nadia Odunayo<EMAIL_ADDRESS>wrote:
Hi John,
Thanks for this!
What happens with the records in the DB that already have years as strings in them? I think we may need to do a bit more here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/nodunayo/speakerline/pull/18#issuecomment-284505373, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCtQ0wE1YsNEl12QuBzM77vlhRg9MT4ks5rjF7WgaJpZM4MTjKf.


Create indicators from JSON - is missing e.g. POST /incident/json

Describe the bug
I notice 'create indicators from JSON' endpoint is missing e.g. POST /incident/json
I now have a mix of demisto-py and REST API code. Hopefully some plans to add?
Expected behavior
demisto-py follows published REST API
Environment
Version 6.1.0

@gomesian sorry for the delayed response. The api is available via the method: create_incident_json
See: https://github.com/demisto/demisto-py/blob/master/demisto_client/demisto_api/api/default_api.py#L807

Very sorry.. I made a typo. I meant Indicators JSON is missing..
POST /indicators/feed/json - Not found here: https://github.com/demisto/demisto-py/blob/master/docs/README.md
But documented in XSOAR API docs 6.1_beta and I think 6.0.1
Describe the bug
I notice 'create indicators from JSON' endpoint is missing e.g.  POST /indicators/feed/json

Looks like I cant re-open..

@gomesian understood. We will add.


Add double fmap operator

Pros:

fmap f <$> whatever can now be written as f <$$> whatever.

Cons:

Do we really want to add another function/operator to P?
The name clashes with something in the wl-printpackage, but anyone using that package should be using qualified or explicit imports.

! @markhibberd @jystic @charleso

The name clashes with something in the wl-printpackage, but anyone using that package should be using qualified or explicit imports.

This would cause me minor churn (I do tend to import the wl operators if they don't clash with p) but don't let that stop you

Do we really want to add another function/operator to P?

If you end up closing the PR, let's make x-combinators or something. I wanna bring a few of Smullyan's birds back.

very weak -1 from me. it's not something I need to do often and so don't see much benefit from the operator, but I don't really care either

I tend to just fmap . fmap $

👍 for me, would use and is the natural operator, I am surprised it doesn't exist somewhere already.

🗺 with named version

:1st_place_medal:

/jury approve


Intellisense for consuming step outputs

When a prior step has an output, that output should be available as an completion item for values in subsequent steps (bundle.output.<stepname>.<outputname> I think).

Steps don't have unique names, just descriptions, but outputs do have unique names per bundle. So we can do bundle.output.outputname.
So it would look something like this (abbreviated for clarity):

install:
- helm:
     outputs:
     - name: output1
- exec:
     command: echo
     args:
     - "source: bundle.outputs.output1"


Regarding the usage for distributed API / job system

Thanks for providing this great library!
I have a question regarding the usage of this library. I have a set api servers that receive job requests and send them to a queue. A few workers then pick up the jobs from the queue and process them asynchronously.
Should I apply fair to the API servers or the workers? I believe it should be applied to the API servers.
Do we need to share the internal states of fair between the API services? Also, is there any concern if we apply auto-scaling to the API services as well?

Thanks for reaching out and for the great question. The question touches the core of the fairness problem and not just the FAIR library.
This is how I'd think about the problem based on the given details:

In most systems, it's a good idea to reject things as early as possible. Keeping the requests in a queue for a while and then rejecting them asynchronously seems like a bad experience so I agree that the API server is probably the way to go.
However, this assumes that you have a good signal about resource exhaustion at the API server side. For this, you have to figure out what resource you are trying to protect. For example, if the queue length or overflow is a signal, that's very easy to capture. On attempting to enqueue, if the queue rejects or is too long, you can report that as a failure to the library. If it's a deeper metric in your stack, you'll have to figure out how to expose it reliably to the API server.
Finally, you'd register every incoming request to check if it should be throttled using what you consider the "client ID" that you'd like to establish fairness between.

Your questions about distributed state management and auto-scaling are very interesting. Note that the library as it exists today does not support import or export state. That said, this is what I'd say about your question:

If your API server is behind a load balancer that randomly distributes the incoming requests to your API servers, you are most likely fine running this library locally on every server. It's always good to start simple and see how far you can get. In most cases, you'll see a degree of under-throttling as opposed to over-throttling which is usually better.
If you really want to try state sharing, running a throttling microservice with this library that your API service talks to could be one way to do it. Since running a Bloom filter is quite cheap, you'll need a much smaller fleet for this service than your API service fleet thus giving you better fidelity metrics. This does add bit of an overhead but if you can stand a per-AZ instance with a lightweight GRPC service, this could be manageable. I am actually considering adding that capability out of the box to this project at some point.
Auto scaling impact depends on how aggressively you are scaling. If it's a regular resource based auto scaling, I'd guess (again, without knowing too much about your traffic patterns) that you'll probably be fine with local throttling. You'll see a short period of under-throttling before things settle down as you get more data to your new instances.
The separate microservice approach will shine in case of auto scaling since you won't have to worry about the under-throttling period in that case.

Let me know if you have additional questions. Thank again!


Add docs for importing metadata from Amundsen

Add docs for importing metadata from Amundsen

Closing this issue as docs for Amundsen have been added here


[Bug] Malfunctions take an extra day to trigger

When checking how many days have passed, the mod seems to wait until the number of days ingame is more then the number of days in the config (this means setting a malfunction to wait one day will actually make it wait two, setting it to five will make it wait six and so on). I was using an empty profile in r2modman, so this was the only mod running aside from the dependencies needed. The console log doesn't really mention anything unexpected but I'll post part of it in case its helpful anyways:
[Debug  :Malfunctions] Penalty multiplier active. Checking for unrecovered players.
[Debug  :Malfunctions] Malfunction Navigation Roll: 95.5341744215852 < 7.5 (FAIL)
[Debug  :Malfunctions] Malfunction Teleporter Roll: 25.8742801499899 < 7.5 (FAIL)
[Debug  :Malfunctions] Malfunction Distortion Roll: 15.2330424241875 < 5 (FAIL)
[Debug  :Malfunctions] Malfunction Door Roll: 88.6193314979874 < 3 (FAIL)
[Debug  :Malfunctions] Malfunction Lever Roll: 15.2525002207852 < 100 (SUCCESS)
[Debug  :Malfunctions] Malfunction Power Roll: 94.7526518231037 < 1.5 (FAIL)
[Debug  :Malfunctions] Malfunction Power - Block Lever Roll : 39.8449369426095 < 50 (SUCCESS)
[Debug  :Malfunctions] Blocking navigation malfunction because elapsed days hasn't passed required threshold: 1 / 1
[Debug  :Malfunctions] Received network message for malfunction navigation roll result: False (levelId: 10)
[Debug  :Malfunctions] Blocking teleporter malfunction because elapsed days hasn't passed required threshold: 1 / 1
[Debug  :Malfunctions] Received network message for malfunction teleporter roll result: False (Delay: 9)
[Debug  :Malfunctions] Blocking distortion malfunction because elapsed days hasn't passed required threshold: 1 / 1
[Debug  :Malfunctions] Received network message for malfunction distortion roll result: False (Delay: 2)
[Debug  :Malfunctions] Blocking door malfunction because elapsed days hasn't passed required threshold: 1 / 1
[Debug  :Malfunctions] Received network message for malfunction door roll result: False (Delay: 11)
[Debug  :Malfunctions] Blocking lever malfunction because elapsed days hasn't passed required threshold: 1 / 1
[Debug  :Malfunctions] Received network message for malfunction lever roll result: False (Delay: 1)
[Debug  :Malfunctions] Blocking power malfunction because elapsed days hasn't passed required threshold: 1 / 1
[Debug  :Malfunctions] Received network message for malfunction power roll result: False (Block lever: True)

Overall not really a huge problem, but I spent hours on a fresh save file wondering why malfunctions wouldn't trigger before realizing the output log has way more details then the terminal does.

Ah! Good catch. The game tracks days elapsed after they are passed (so days +1) but I can see how this is confusing. I'll improve this in V2.


Add standard ResNet data augmentation for ImageRecordIter

Description
Add standard ResNet data augmentation for ImageRecordIter.
Specifically, this augmentation performs a "random resized crop", which crop the image with respect to a random aspect ratio, and a random area, and resize it to the desired size.

If random_resized_crop=True, existing max_random_scale and min_random_scale will be ignored.
If random_resized_crop=False, newly-added max_random_area and min_random_area will be ignored.

Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[X] Changes are complete (i.e. I finished coding on this PR)
[X] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
[X] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
[X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Needs to add jitter pca noise etc

We might want to add this option to the standard image classification example: image_classification/common/data.py

Although it is standard during training, it cannot be resized to 256*256 and center crop in validation.
@hetong007 @rahul003 @piiswrong

@TccccD What is the exact issue you have? FYI for training you can set up the pipeline like this: https://github.com/dmlc/gluon-cv/blob/master/scripts/classification/imagenet/train_imagenet.py#L183


Sorting should be case insensitive

Files starting with a capital letter are shown first and files starting with a small letter are shown after that.

I think it's difficult to determine what is desired regarding order of special characters..
Maybe we should just eliminate sorting by name sometimes :)

@sisco0 sorry for late response, I'm still working on my GitHub habits.. Thank you, your commit looks perfectly fine, don't hesitate to submit pull-request. Actually, I would notice PR quicker than mentioning :) Also don't hesitate to reach me in Telegram (@kirill_taran) or by e-mail<EMAIL_ADDRESS>for discussing paid tasks.


Release Note Parsing for Singular Announcements

For reliability we currently refuse to parse/include the contents of your RELEASES/CHANGELOG files if you're publishing a Singular Announcement (--tag=my-app-v1.0.0). We will only do it if you're publishing a Unified Announcement (--tag=v1.0.0). Singular announcements just get the auto-generated tables.
This is obviously suboptimal, but we need someone who wants this stuff to tell us how they want it!
Some options:

Look for a RELEASES in the my-app package's dir? (kinda wonky for non-virtual workspaces but that's always true)
Look for extra-special heading formats in the top-level RELEASES? (does parse-changelog support that?)

Note that this is also relevant to good UX for #130, although I think we can punt this one for 0.0.3.


PlaceSelectionListener is not triggerred

Tried to follow your demo to use PlaceSelectionListener in AutocompleteTestActivity; but both onPlacesSelected and onError were never fired...
I thought it may be related to this, but still no luck trying to do something like this.

  @Override
  protected void onActivityResult(int requestCode, int resultCode, @Nullable Intent intent) {

    super.onActivityResult(requestCode, resultCode, intent);
    autocompleteSupportFragment.onActivityResult(requestCode, resultCode, intent);

@wangela Can you take a look at this?


Loading plugins doesn't work

How to reproduce
This is how I installed the plugin:

I followed the build instructions from https://github.com/dfranx/PluginShadertoy

I put the plugin into the correct folder:
$ find /opt/shadered/plugins/
/opt/shadered/plugins/
/opt/shadered/plugins/ShadertoyImport
/opt/shadered/plugins/ShadertoyImport/plugin.so
/opt/shadered/plugins/README.txt

This is what I do:

Start Shadered
Project>Options>Plugins
The plugin "Shadertoy" is listed in the left column. Click on ">>"
Click ok to exit the dialog
File>Exit
Start Shadered
Project>Options>Plugins
Now the plugin "Shadertoy" is still in the left column. Furthermore the plugin is definitely not loaded because "File -> Import Shadertoy project" doesn't exist

Information

Shadered version: 1.3.5 (I also tried to check the master branch, but I can't compile it)
OS: Arch Linux

Works perfectly fine on my end. Can you please provide logs? Turn them on in Options -> General -> "Log" checkbox. Then click on ">>" button in the Options' "Plugins" section. Restart SHADERed and post logs here.

Since #111 was fixed, I built the master version, and plugins work fine for the master version. If you are interested in the log files for 1.3.5 anyway, I'll provide them. But from my side it's enough that the master version fixes this problem.

The log files are not necessary then. Glad it works.


Get the latest version of go-licenses

This will keep us automatically up to date with any improvements to this module, which hopefully should help us find more issues (if they exist)
Follow up from #21896

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Run Java PreCommit

R: @lostluck here's the follow up to my last one

Neither python or Java were failing for the affected task, so merging.


[UI] Replace logo with the dark mode version when the website in dark mode.

Current State of the Meshery.io site

The logo inside that yellow rectangle shown above does not resembles with the dark mode of the website.
link: https://meshery.io/service-mesh-interface
Desired State of the Meshery.io site
It should be replaced with the dark mode version of that logo when the website in dark mode.

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hi @ritiksaxena124 , I'm not sure if we have a alternate logo for kuma , I've checked at two other places and it still uses the same one for both modes, if that's not the case please let me know so I can try and work on this, thanks

Hi, @Avi-88 , @ritiksaxena124, I have found some different icons of Kuma on the CNCF official website, Can I be assigned this issue I would like to work on it.

Can I work on this

I would like to work on this!!

I have found alternative logo suitable for dark mode. I would like to work on this issue!

Go ahead @joshboye if you have any doubts feel free to ask in our slack channel or in our discussion forum so that other contributors can also help and guide to your way


 or DBeaver bug?

thank you for your attention. Corrected


Writing to Cursor<&mut Vec<u8>> doesn't grow the Vec

Hello!
I'm trying to use DekuContainerWrite::to_bytes() in no_std. That method uses Cursor<&mut Vec<u8>>::write() internally with an empty Vec:
https://github.com/sharksforarms/deku/blob/8b1f5af4dbe082007a6c807871f955e5993a54c6/src/lib.rs#L518-L525
This works fine when using std, as the impl will grow the Vec:
https://doc.rust-lang.org/stable/src/std/io/impls.rs.html#413-416
Using the no-std-io impl though, it will immediately error with WriteZero, since it can't write to a zero-length Vec:
https://github.com/wcampbell0x2a/no-std-io2/blob/61baa943b3f84c73c3d958be26c1cedf9838c8f3/src/io/cursor.rs#L275-L285

I added a commit that should fix this, lmk if you find anything else! https://github.com/wcampbell0x2a/no-std-io2/pull/2/commits/7050eef20191899cfdca9e2076e61d08aec0b8c1

Thanks for the quick fix! All my tests are passing now. :)


Could you please provide the detailed steps to make example running?

Hi,
I got the issues to set up it, and could not make it properly set up in my side. Could you please  give us more detailed steps since I am trying to use Sikulix for mobile automation testing. it is more urgent for me now.
I will really appreciate any feedback from you.
Thanks in advance,
Sincerely,
Jon

Hi Jon,
Could you please send me exactly the point that you are having issues?
I've only posted on Github some help from quick functions, none about
Sikuli's installation itself.
Regards,
Carol

Hi Carol,
I am very pleased to receive your fast response.  Basically I am trying to make your Sikuli example working on Android Mobile device, but i failed.
there were several issues I have now -
1.  importError with "andwalker" module
2.  three Java classes (AndroidRegion/AndroidRobot/AndroidScreen.java) set-up problems, such as constructor issue with "org.sikuli.script.Match"   and how to make their Java classes working with "andwalker' python module and your chrome sikulix example.
Since your example codes were three years ago with old sikuli version, current sikulix version is v1.1.1 or v1.1.0. is it okay with your sikuli example codes now?
I am getting puzzled with it now. If you can provide the specific set-up steps after the step of downloading this zip file, it will be great. By the way, I don't have problem with Sikulix since I did using it for Desktop app automation testing. Now I have mobile automation testing requirement by using Sikulix. it looks urgent to me. So please give me some helps as possibly as you can.
Thanks in advance.
Sincerely,
Jon

Hi Jon,
I've never used Sikuli on any device. All I used to do is run an emulator
on WIndows and get the screenshots of the parts that I wanted Sikuli
working on.
And the code is on Jython (Java+Phyton), so I don't really know the Java
classes that you pointed.
Do you really need to run Sikuli installed on a Android device? Using an
emulator does not attend what you need to do?
Feel free to ask me anything, I will help you on what I can!
2017-11-28 19:38 GMT-02:00 qxu2005<EMAIL_ADDRESS>
Hi Carol,
I am very pleased to receive your fast response. Basically I am trying to
make your Sikuli example working on Android Mobile device, but i failed.
there were several issues I have now -
1. importError with "andwalker" module
2. three Java classes (AndroidRegion/AndroidRobot/AndroidScreen.java)
set-up problems, such as constructor issue with
"org.sikuli.script.Match" and how to make their Java classes working with
"andwalker' python module and your chrome sikulix example.
Since your example codes were three years ago with old sikuli version,
current sikulix version is v1.1.1 or v1.1.0. is it okay with your sikuli
example codes now?
I am getting puzzled with it now. If you can provide the specific set-up
steps after the step of downloading this zip file, it will be great. By the
way, I don't have problem with Sikulix since I did using it for Desktop app
automation testing. Now I have mobile automation testing requirement by
using Sikulix. it looks urgent to me. So please give me some helps as
possibly as you can.
Thanks in advance.
Sincerely,
Jon
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/imsardine/sikuli-monkey/issues/3#issuecomment-347672033,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADS9a012-tHw_sg3RVFMxs-XRXJ0H634ks5s7H1MgaJpZM4QtYIq
.

--
Carol Ciola

Hi Carol,
Have you tried this sikuli-money example codes in your side? What I want now is to make this sikuli-money example working in my side. Based on a video attached with this example, looks working on Android real device.
the list of this example (https://github.com/imsardine/sikuli-monkey):

example/chrome_pocket_share.sikuli
lib/andwalker/device.py, exceptions.py, utils.py
sikuli-monkey/src/main/java/com/simplbug/sikulimonkey/AndroidRegion.java, AndroidRobot.java, AndroidScreen.java, MonkeyPlugin.java

if this example can work in my side, I will use its workflow to do my own works.
Please advise,
Thanks in advance.
Sincerely,
Jon

Hi Jon,
I didn't used this example, and nowadays I'm working with C#. Sorry
but I think I cannot help you this time...
Regards,

Hi Carol,
that's fine. Anyway, I still appreciated your messages.
Thank you!
Jon


compilation error when installing piqilib.0.6.6 via opam

Please, see BinaryAnalysisPlatform/bap#286 for more info.

Looks like the original issue has been closed. So closing this one.


Extend existing IndexRecoveryIT for remote indexes

Description
Add integration tests for recovery flow for remote enabled indexes by extending existing recovery indexing integ tests.
Related Issues
Resolves #8476
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

slowDownRecovery

Test Result (6 failures / -22)
org.opensearch.remotestore.RemoteIndexRecoveryIT.testRerouteRecovery
org.opensearch.remotestore.RemoteIndexRecoveryIT.testRerouteRecovery
org.opensearch.remotestore.RemoteIndexRecoveryIT.testRerouteRecovery
org.opensearch.remotestore.RemoteIndexRecoveryIT.testRerouteRecovery
org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
Flaky test - https://github.com/opensearch-project/OpenSearch/issues/7703.
For the testRerouteRecovery test, I have the fix, will be doing it now.

Since slowDownRecovery doesn't work for remote backed indices, we won't be getting much value from the tests at this point of time . can we please override this function in RemoteReindexRecovery and add a backlog item to control the recovery speed for remote backed indices ?

Created https://github.com/opensearch-project/OpenSearch/issues/8517. We will follow up on this. There would be some bigger changes required in repository related classes to give controls on controlling remote interaction speeds.

The ITs added as part of this PR have been run successfully for 200 iterations.


Update build, tools, and sdk to newer versions

The Solana SDK was split between program-specific parts and top-level tests, which (among other things) lets developers avoid the annoying cfg[target_arch... bits.  Additionally, there's now a build tool of cargo build-bpf and cargo test-bpf which avoids the necessity of a do.sh script and keeping the sdk in the repo.
Since you've added new functionality to do.sh, I updated the commands to the corresponding cargo commands and the deploy script.
The main changes here are to use the solana_program equivalents instead of solana_sdk and then removing the program feature.  On the testing side, instead of changing invoke_signed based on the architecture, we define a test environment syscall which looks just like the previous test version of invoke_signed.
This should help some of the build issues you've seen in the past when trying to compile the futures crate, so now you can use cargo build-bpf and cargo test straight up!
I also needed to update the docker compose file to get it to work on my system.
Let me know if you have any questions.

I'll take care of fixing the CI issues tomorrow.

I'll take care of fixing the CI issues tomorrow.

This is finally ready for review -- go for it!

This is finally ready for review -- go for it!

This is finally ready for review -- go for it!

Thank you so much! LGTM!

This is finally ready for review -- go for it!

Thank you so much! LGTM!


1.3 and 1.2 are both supported

Refers to #81

Can you push that commit into #105 and close that one?

I can try...
Sent from Outlook
On Fri, Jul 10, 2015 at 12:56 PM -0700, "Witold Szczerba"<EMAIL_ADDRESS>wrote:
Can you push that commit into #105 and close that one?
—
Reply to this email directly or view it on GitHub.

Moved to #106


[24.05] Revert "[24.05] Revert "nixos/steam: add option fontPackages"", backport #315149

Reverts NixOS/nixpkgs#315120
Backport #315149
In summary, add programs.steam.fontPackages option for 24.05 and fix the evaluation error in the previous backport. I would like to fix the CJK problem on 24.05.
The type should be stable this time.

For the second commit, please use git cherry-pick -x to reference the backported commit .  Here is the doc.

done


generate dts

Hi all, this is an enhancement request:
Since zephyr also uses device-tree, albeit during compile time. I think making this repo behave more like the linux repo in terms of generating dts will make it easier to add more peripheral configs and  board support.
Once make.py spits out both the bitstream and dts we can have the zephyr source use that to generate the firmware. Zephyr can then just have a generic vexriscv target instead of the arty specific one (It is pretty generic already, apart from the dts) .
This just makes adding more custom interfaces easy since that seems to be the main use-case, like adding 6 spi interface to tinyfpga_bx and sacrificing all i2c and all but one uart interface.

I think it is the case now (2.5 years later).
Can this be closed?


Use Cookie Cutter Data Science as a default template for nbdev_new?

Have you looked at Cookie Cutter Data Science? It's a quite popular open source project (https://drivendata.github.io/cookiecutter-data-science/) that just has a standard repo structure. I wonder, if it aligns, if you could use that as the default structure for nbdev_new.
That would allow github actions built against either to use similar repo assumptions - and may join forces with their community.
Just an open conversation :)

Hi @aronchick
I noted the cookie-cutter directory structure below.  While at first this seems compatible with nbdev out of the box where you just change settings.ini, you have to make some additional modifications to make sure nbdev and this project play nicely with eachother.  For example:

Delete the README.md b/c that is generated by index.ipynb
Delete the contents of docs/ as the sphinx docs will be replaced by nbdev's doc system
nbdev doesn't use requirements.txt and instead uses settings.ini

Once you take care or are aware of these things, you must make the following changes in settings.ini:
nbs_path = notebooks
lib_path = src

@aronchick are you asking for some automation to do this type of thing automatically?
@jph00 is this something that you want to support in nbdev?
├── LICENSE
├── Makefile           <- Makefile with commands like `make data` or `make train`
├── README.md          <- The top-level README for developers using this project.
├── data
│   ├── external       <- Data from third party sources.
│   ├── interim        <- Intermediate data that has been transformed.
│   ├── processed      <- The final, canonical data sets for modeling.
│   └── raw            <- The original, immutable data dump.
│
├── docs               <- A default Sphinx project; see sphinx-doc.org for details
│
├── models             <- Trained and serialized models, model predictions, or model summaries
│
├── notebooks          <- Jupyter notebooks. Naming convention is a number (for ordering),
│                         the creator's initials, and a short `-` delimited description, e.g.
│                         `1.0-jqp-initial-data-exploration`.
│
├── references         <- Data dictionaries, manuals, and all other explanatory materials.
│
├── reports            <- Generated analysis as HTML, PDF, LaTeX, etc.
│   └── figures        <- Generated graphics and figures to be used in reporting
│
├── requirements.txt   <- The requirements file for reproducing the analysis environment, e.g.
│                         generated with `pip freeze > requirements.txt`
│
├── setup.py           <- Make this project pip installable with `pip install -e`
├── src                <- Source code for use in this project.
│   ├── __init__.py    <- Makes src a Python module
│   │
│   ├── data           <- Scripts to download or generate data
│   │   └── make_dataset.py
│   │
│   ├── features       <- Scripts to turn raw data into features for modeling
│   │   └── build_features.py
│   │
│   ├── models         <- Scripts to train models and then use trained models to make
│   │   │                 predictions
│   │   ├── predict_model.py
│   │   └── train_model.py
│   │
│   └── visualization  <- Scripts to create exploratory and results oriented visualizations
│       └── visualize.py
│
└── tox.ini            <- tox file with settings for running tox; see tox.readthedocs.io

cookie cutter uses lots of tools, such as tox and sphinx, to cover the functionality that nbdev provides already out of the box. It doesn't make sense AFAICT to support both. I think it would be simpler for people to just use nbdev which handles everything needed to get started.

My proposal is less about using the tools to install a repo via CCDS, but a tacit agreement to use the same structure. Many (most?) folks won't be using nbdev to start, so they may set up their repo in an arbitrary way. I'm not saying CCDS is "the way" but it's certainly a popular alternative layout.
If you BOTH agreed on a similar format, then we could say "hey everyone, let's use the <STANDARD_NAME> format for a data science repo, both nbdev and CCDS agree that it's the best." (or similar language)
I'm not suggesting replacing one line of functionality of nbdev_new just the layout of the repo once installed. And the CCDS folks are also more than open to collaborating and aligning.
I'd propose re-opening this.

Can you be more specific about what folders you suggest creating, for what purposes? Maybe some examples?

My proposal is less about using the tools to install a repo via CCDS, but a tacit agreement to use the same structure. Many (most?) folks won't be using nbdev to start, so they may set up their repo in an arbitrary way. I'm not saying CCDS is "the way" but it's certainly a popular alternative layout.

I like your idea, but given the extra bits @hamelsmu added, i think a cookiecutter nbdev setup would be more useful as a separate repository, like https://github.com/fastai/nbdev_template (maybe this is what you had in mind all along?) In that case no changes are needed to nbdev itself, you can maintain a cookiecutter / github template repo with those extra adjustments.

Sure - basically everything in the structure above. By having a well defined docs/model/src/etc folder, that is the default (not required by any stretch!) then TWO very large projects share a common repo layout as the default. That starts to move mountains IMO - for example, you could imagine an nbdev action which looked for (by default) all notebooks in a folder named /notebooks, or autobuilt docs from any directory named docs. It did this because that's the standard place to look for notebooks in both default repo layouts.
Just a series of things like that.

After thinking about this very carefully (and giving extra deference to @aronchick because he is my friend and someone I respect, I still struggle to see how a marriage of CCDS and nbdev would be mutually beneficial.  I understand that the motivation (and really appreciate) the idea of boosting the visibility of nbdev by giving it a hook into a popular repository format.  That is very thoughtful and I can relate to the excitement of bringing different communities/projects together (which David is really good at doing by the way!).
However, the main issue is that nbdev isn't specific to data science at all!  We have been using it for a while to build software like api clients, cli-tools, web utilities for networking, and all kinds of other things.  The authors of nbdev certainly view nbdev as a very general software development framework, and this is also how I view it, too.  The presence of Jupyter Notebooks and the association with fastai sometimes (understandably) give an impression that this is a software development framework specifically for the data science community.  But its really just a tool for writing, distributing and documenting software not aimed at data scientists specifically.
I would even venture to say that many types of ad-hoc exploratory data science work are not a good fit for nbdev initially as nbdev is geared towards writing software, whereas data scientists may not be concerned with or need packaging, documentation, for many types of activities they do where CCDS would make more sense.
Because nbdev and CCDS are orthogonal in their core purposes (literate programming vs. data science), it feels unnatural to try to force a merger.  It would put a cognitive load on maintainers to try to figure out what to do with the conflicting parts (like docs), and how to unify certain goals when the goals are quite different.
I hope that helps, happy to continue the conversation, just thought I would clarify some commonly held misconceptions (to the point where I am considering if some of what I said above should be in the documentation re: not just for data science).

LOL @hamelsmu, I'm just a guy!
Ok, I hear where you are all coming from, but imagine the alternative world. I don't THINK you all care specifically about the layout of a repo, you just chose one that is logical to you all.
E.g. people DO need a repo for /docs, /notebooks, etc etc. There's nothing specific to data science (of course) to these concepts.
I guess my take is that EVERYONE needs some structure and, today, most data scientists spin up whatever makes sense to them, creating folders when it suits them. Which is, generally, FINE. But I think they generally DON'T have opinions either - as evidenced by the fact that they're using nbdev_template as their repo. They just want something logically laid out - that's it.
This now goes to @igorbrigadir's point - let's say there was an international "standard" for how a repo was laid out. I don't think nbdev or CCDS would have any reason to vary from that - they could offer it as an option, but the default would be the same layout. That's kind of what I'm trying to do from the bottom up. So, imagine the following conversation:
1: Hi, @jph00, you build notebooks and repos ALL THE TIME, do you have some recommendations for how I'd lay it out?
2: Yep, we think you should definitely have a dir for your docs
1: Cool, what should I name it and where should I put it?
2: Anywhere you like, but I use /docs
1: K, what's next?
2: Yep, we think you should definitely have a dir for your source.
1: K, what should I name that?
2: Anything you want, I like the directory name /src
goes on for some time
1: Woah, that's a lot of dirs, do you have anything that would lay that out for me?
2: Yep, just use nbdev_new and you're golden.
1: This is a really nice layout! Anyone else use this?
2: Yep! This is the standard layout agreed to when you publish papers (by Papers with Code), by Cookie Cutter Data Science, etc etc.
I truly don't think there are any conflicting goals around the layout of the repo. What you do AFTER that, I get it. And I also get that if you're using nbdev for things that AREN'T data science, folders like model may not make sense. But I think most do? I'm not sure what to do about the fact that some dirs will be quite useless - we'll have to figure something out there.
And, to be clear, I'm not thinking about merging the projects at all - sorry if it came off that way! I only thought you could both 'agree' (for some definition of 'agree') on the default layout of repos.

That makes sense to me and I like how you champion the cause of those users!
Nbdev doesn’t mandate a particular directory structure, we often change the
directory structure from the one that is there by default.  For example -
by default, there is no notebooks folder!   The only folder that exists
immediately is a docs folder.  Other folders are added by users as they
progress or on their own discretion.
I’m afraid nbdev doesn’t have much of an opinion of a directory structure
at all.  If you pressed me to identify where there might be agreement:

a docs folder
IF you want to make a python library or module then put that in a folder,
but name it whatever you want (perhaps not src).

However I would say that the docs and module folders are just artifacts of
the limited infrastructure we have today.  In an ideal world you wouldn’t
need all these separate artifacts if the tools were better (you would only
need a special IDE to view, navigate and render one thing).  I’m just
giving this background to share why we don’t have a strong opinion on
directory structure.
So I guess there is nothing to agree on, re: directory structure.  However
there is lots of substantive things to disagree on that are quite
fundamental like:

How docs are written
How tests are written

And docs and tests are a central concern of nbdev, so it’s hard to pretend
that elephant doesn’t exist.  If someone faithfully adheres to CCDS we
would be asking them to rewrite their docs and tests (which could be in
many cases the bulk of the work of a programmer)!
BTW I know that I can DM you to talk through this but I’m somewhat hoping
this thoughtful exchange might be useful for others
On Sun, Dec 27, 2020 at 1:23 PM David Aronchick<EMAIL_ADDRESS>wrote:

LOL @hamelsmu https://github.com/hamelsmu, I'm just a guy!
Ok, I hear where you are all coming from, but imagine the alternative
world. I don't THINK you all care specifically about the layout of a repo,
you just chose one that is logical to you all.
E.g. people DO need a repo for /docs, /notebooks, etc etc. There's nothing
specific to data science (of course) to these concepts.
I guess my take is that EVERYONE needs some structure and, today, most
data scientists spin up whatever makes sense to them, creating folders when
it suits them. Which is, generally, FINE. But I think they generally DON'T
have opinions either - as evidenced by the fact that they're using
nbdev_template as their repo. They just want something logically laid out

that's it.

This now goes to @igorbrigadir https://github.com/igorbrigadir's point

let's say there was an international "standard" for how a repo was laid
out. I don't think nbdev or CCDS would have any reason to vary from that -
they could offer it as an option, but the default would be the same layout.
That's kind of what I'm trying to do from the bottom up. So, imagine the
following conversation:

1: Hi, @jph00 https://github.com/jph00, you build notebooks and repos
ALL THE TIME, do you have some recommendations for how I'd lay it out?
2: Yep, we think you should definitely have a dir for your docs
1: Cool, what should I name it and where should I put it?
2: Anywhere you like, but I use /docs
1: K, what's next?
2: Yep, we think you should definitely have a dir for your source.
1: K, what should I name that?
2: Anything you want, I like the directory name /src
goes on for some time
1: Woah, that's a lot of dirs, do you have anything that would lay that
out for me?
2: Yep, just use nbdev_new and you're golden.
1: This is a really nice layout! Anyone else use this?
2: Yep! This is the standard layout agreed to when you publish papers (by
Papers with Code), by Cookie Cutter Data Science, etc etc.
I truly don't think there are any conflicting goals around the layout of
the repo. What you do AFTER that, I get it. And I also get that if you're
using nbdev for things that AREN'T data science, folders like model may
not make sense. But I think most do? I'm not sure what to do about the fact
that some dirs will be quite useless - we'll have to figure something out
there.
And, to be clear, I'm not thinking about merging the projects at all -
sorry if it came off that way! I only thought you could both 'agree' (for
some definition of 'agree') on the default layout of repos.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fastai/nbdev/issues/344#issuecomment-751517663, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALKJERLMHLORB34HRQWVJTSW6QWDANCNFSM4U6R4IVA
.

And docs and tests are a central concern of nbdev, so it’s hard to pretend that elephant doesn’t exist. If someone faithfully adheres to CCDS we would be asking them to rewrite their docs and tests (which could be in many cases the bulk of the work of a programmer)!

I guess this would be my ideal. Since you don't care about directory structure, but DO care about these things, what if you (or I) went to CCDS and said "hey, CCDS, we're happy to snap to your directory structure when someone does nbdev_init IFF you restructure in the following way?" That would be really compelling, I think!

And docs and tests are a central concern of nbdev, so it’s hard to pretend that elephant doesn’t exist. If someone faithfully adheres to CCDS we would be asking them to rewrite their docs and tests (which could be in many cases the bulk of the work of a programmer)!

I guess this would be my ideal. Since you don't care about directory structure, but DO care about these things, what if you (or I) went to CCDS and said "hey, CCDS, we're happy to snap to your directory structure when someone does nbdev_init IFF you restructure in the following way?" That would be really compelling, I think!

We don't have a directory structure because we only use notebooks in the repo root. The idea of a directory structure doesn't make sense for nbdev, since everything (tests, implementation, and docs) is done directly from notebooks. So there are no directories to structure.

We don't have a directory structure because we only use notebooks in the repo root. The idea of a directory structure doesn't make sense for nbdev, since everything (tests, implementation, and docs) is done directly from notebooks. So there are no directories to structure.

Hey Jeremy!
Sorry, I meant the directory structure used is provided by nbdev_new (https://nbdev.fast.ai/cli#nbdev_new) - this lays down an existing (seemingly compatible with nbdev defaults) repo structure
From: Jeremy Howard<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 12:05 PM
To: fastai/nbdev<EMAIL_ADDRESS>Cc: David Aronchick<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [fastai/nbdev] Use Cookie Cutter Data Science as a default template for nbdev_new? (#344)
We don't have a directory structure because we only use notebooks in the repo root. The idea of a directory structure doesn't make sense for nbdev, since everything (tests, implementation, and docs) is done directly from notebooks. So there are no directories to structure.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffastai%2Fnbdev%2Fissues%2F344%23issuecomment-754187713&data=04|01|david.aronchick%40microsoft.com|369f12954e674ce6b71908d8b0ebf9de|72f988bf86f141af91ab2d7cd011db47|1|0|637453874855448183|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=VkgALyQ7MVukd71ObuVkXwIG9vHV0qa%2FX4GfuWqcPTY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAAMQ5IZ6ZVTSFRAUG6RBALSYINNVANCNFSM4U6R4IVA&data=04|01|david.aronchick%40microsoft.com|369f12954e674ce6b71908d8b0ebf9de|72f988bf86f141af91ab2d7cd011db47|1|0|637453874855458175|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=8bw2lyzKMw6cntf5IPCvL1DOKH2Yz7AEq19HY3mdCqw%3D&reserved=0.

Hey Jeremy!
Sorry, I meant the directory structure used is provided by nbdev_new (https://nbdev.fast.ai/cli#nbdev_new) - this lays down an existing (seemingly compatible with nbdev defaults) repo structure
From: Jeremy Howard<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 12:05 PM
To: fastai/nbdev<EMAIL_ADDRESS>Cc: David Aronchick<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [fastai/nbdev] Use Cookie Cutter Data Science as a default template for nbdev_new? (#344)
We don't have a directory structure because we only use notebooks in the repo root. The idea of a directory structure doesn't make sense for nbdev, since everything (tests, implementation, and docs) is done directly from notebooks. So there are no directories to structure.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffastai%2Fnbdev%2Fissues%2F344%23issuecomment-754187713&data=04|01|david.aronchick%40microsoft.com|369f12954e674ce6b71908d8b0ebf9de|72f988bf86f141af91ab2d7cd011db47|1|0|637453874855448183|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=VkgALyQ7MVukd71ObuVkXwIG9vHV0qa%2FX4GfuWqcPTY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAAMQ5IZ6ZVTSFRAUG6RBALSYINNVANCNFSM4U6R4IVA&data=04|01|david.aronchick%40microsoft.com|369f12954e674ce6b71908d8b0ebf9de|72f988bf86f141af91ab2d7cd011db47|1|0|637453874855458175|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=8bw2lyzKMw6cntf5IPCvL1DOKH2Yz7AEq19HY3mdCqw%3D&reserved=0.

I understand you would like to have a tool that converts CCDS to nbdev somehow (it doesn't matter that I don't understand why).  It sounds like that may be important to your work.  If that is the case, I would recommend making a cli tool that does the things you want outside nbdev, that will be the best way to unblock you.
We don't think nbdev is the right place to set or bless directory structures, only because this doesn't have anything to do with nbdev.  nbdev_new is only one way to get started and is just a minimal set of files in a completely arbitrary format.  Because of this, we don't want to add any kind of extra maintenance burden either cognitively or in practice that has to do with keeping any specific structure in mind.
If you want to discuss how you might make this CLI feel free to ping me

I understand you would like to have a tool that converts CCDS to nbdev somehow (it doesn't matter that I don't understand why).  It sounds like that may be important to your work.  If that is the case, I would recommend making a cli tool that does the things you want outside nbdev, that will be the best way to unblock you.
We don't think nbdev is the right place to set or bless directory structures, only because this doesn't have anything to do with nbdev.  nbdev_new is only one way to get started and is just a minimal set of files in a completely arbitrary format.  Because of this, we don't want to add any kind of extra maintenance burden either cognitively or in practice that has to do with keeping any specific structure in mind.
If you want to discuss how you might make this CLI feel free to ping me

I'm happy to ping - I'm just saying for JUST the nbdev_new tool, the layout you choose for the structure to be compatible with CCDS. No conversion, no compatibility, no other commands need to support it. You already have chosen a structure, I'm just asking that That's all!
 Naming convention is a number (for ordering),
│                         the creator's initials, and a short `-` delimited description, e.g.
│                         `1.0-jqp-initial-data-exploration`.
│
│   └──  00_core.ipynb
├── references         <- Data dictionaries, manuals, and all other explanatory materials.
│
├── reports            <- Generated analysis as HTML, PDF, LaTeX, etc.
│   └── figures        <- Generated graphics and figures to be used in reporting
│
├── requirements.txt   <- The requirements file for reproducing the analysis environment, e.g.
│                         generated with `pip freeze > requirements.txt`
│
├── setup.py           <- Make this project pip installable with `pip install -e`
├── src                <- Source code for use in this project.
│   ├── __init__.py    <- Makes src a Python module
│   │
│   ├── data           <- Scripts to download or generate data
│   │   └── make_dataset.py
│   │
│   ├── features       <- Scripts to turn raw data into features for modeling
│   │   └── build_features.py
│   │
│   ├── models         <- Scripts to train models and then use trained models to make
│   │   │                 predictions
│   │   ├── predict_model.py
│   │   └── train_model.py
│   │
│   └── visualization  <- Scripts to create exploratory and results oriented visualizations
│       └── visualize.py
│
├── index.ipynb
├── settings.ini
├── setup.py
└── tox.ini            <- tox file with settings for running tox; see tox.readthedocs.io

I'm a total outsider to this project - if this feels weird or wrong, I'm sorry.

I'm happy to ping - I'm just saying for JUST the nbdev_new tool, the layout you choose for the structure to be compatible with CCDS. No conversion, no compatibility, no other commands need to support it. You already have chosen a structure, I'm just asking that That's all!
 Naming convention is a number (for ordering),
│                         the creator's initials, and a short `-` delimited description, e.g.
│                         `1.0-jqp-initial-data-exploration`.
│
│   └──  00_core.ipynb
├── references         <- Data dictionaries, manuals, and all other explanatory materials.
│
├── reports            <- Generated analysis as HTML, PDF, LaTeX, etc.
│   └── figures        <- Generated graphics and figures to be used in reporting
│
├── requirements.txt   <- The requirements file for reproducing the analysis environment, e.g.
│                         generated with `pip freeze > requirements.txt`
│
├── setup.py           <- Make this project pip installable with `pip install -e`
├── src                <- Source code for use in this project.
│   ├── __init__.py    <- Makes src a Python module
│   │
│   ├── data           <- Scripts to download or generate data
│   │   └── make_dataset.py
│   │
│   ├── features       <- Scripts to turn raw data into features for modeling
│   │   └── build_features.py
│   │
│   ├── models         <- Scripts to train models and then use trained models to make
│   │   │                 predictions
│   │   ├── predict_model.py
│   │   └── train_model.py
│   │
│   └── visualization  <- Scripts to create exploratory and results oriented visualizations
│       └── visualize.py
│
├── index.ipynb
├── settings.ini
├── setup.py
└── tox.ini            <- tox file with settings for running tox; see tox.readthedocs.io

I'm a total outsider to this project - if this feels weird or wrong, I'm sorry.


Update the binary version to 1.4.4

Update the binary version to 1.4.4

@elfinhe: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfinhe: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

mandiff_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mandiff_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

mandiff_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mandiff_operator

test_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

mandiff_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mandiff_operator

test_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test test_operator

gencheck_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

mandiff_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mandiff_operator

test_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test test_operator

gencheck_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test gencheck_operator

lint_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test lint_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

mandiff_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mandiff_operator

test_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test test_operator

gencheck_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test gencheck_operator

lint_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test lint_operator

mesh_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mesh_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

mandiff_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mandiff_operator

test_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test test_operator

gencheck_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test gencheck_operator

lint_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test lint_operator

mesh_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mesh_operator

e2e_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test e2e_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

mandiff_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mandiff_operator

test_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test test_operator

gencheck_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test gencheck_operator

lint_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test lint_operator

mesh_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test mesh_operator

e2e_operator
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test e2e_operator

test_operator_release-1.4
35229f8c20c946642561dcbd0f98e1f81c26a836
link
/test test_operator_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[ES 2] Jagged Fonts

After testing with various resolutions (CEA and DMT) and having the memory assigned at 256 and 384.The fonts appear to have a jagged look to them. This is sporadic as some do and some don't have this problem.
This seems to occur when there is no game list or images for the system.

Did this issue get fixed at all?


BUG: Fix import for new versions of ibis

The compiler is now at https://github.com/ibis-project/ibis/blob/master/ibis/backends/base_sql/compiler.py

@tswast any issues here?

cc @gerrymanoim https://github.com/ibis-project/ibis-bigquery/pull/59/checks?check_run_id=2630857440

I'd also like to make sure we maintain compatibility with ibis 1.4.0. At least until there are a few 2.x releases. I see there are some failing test in that build. https://github.com/ibis-project/ibis-bigquery/pull/59/checks?check_run_id=2630857546
e.g.
Run python -m pytest tests/unit
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /home/runner/work/ibis-bigquery/ibis-bigquery
collected 2 items / 4 errors

==================================== ERRORS ====================================
__________________ ERROR collecting tests/unit/test_client.py __________________
tests/unit/test_client.py:4: in <module>
    import ibis_bigquery.client
ibis_bigquery/__init__.py:11: in <module>
    from .client import (BigQueryClient, BigQueryDatabase, BigQueryQuery,
ibis_bigquery/client.py:28: in <module>
    from . import compiler as comp
ibis_bigquery/compiler.py:71: in <module>
    class BigQuerySelectBuilder(comp.SelectBuilder):
E   AttributeError: module 'ibis.backends.base_sql.compiler' has no attribute 'SelectBuilder'
_________________ ERROR collecting tests/unit/test_compiler.py _________________

Sorry about that - I added another try/except so that the CI now passes: https://github.com/gerrymanoim/ibis-bigquery/pull/1.
If I understand the github actions file, github should test against head of ibis master?

cc @tswast

agree this is not pretty. @gerrymanoim can you create an issue to remove this code once ibis-bigquery drops support for ibis < 2.0 (which we should release soon anyhow).

https://github.com/ibis-project/ibis-bigquery/issues/62


Interpolation API: switch interpolations to BSplineKit

Closes #76, Ref #75
To-dos

[x] Migrate from Interpolations.jl to BSplineKit
[x] Add cubic spline interpolation
[x] Expose bootstrapping choice to user
[x] Update documentation
[x] bump package version for breaking changes (API + default of cubic spline)

API Changes
For relevant boostrapped class of curves, there is a new kwarg interpolation which has two options currently: CubicSpline() and LinearSpline(). This should facilitate more advanced choices in the future such as #70. Example of change:
curve = Yields.CMT(cmt, mats) # now uses cubic spline by default, no change to signature
curve = Yields.CMT(cmt, mats; interpolation=LinearSpline()) # linear interp
curve = Yields.CMT(cmt, mats; interpolation=CubicSpline())  # cubic spline interp

Speed
This PR is almost as fast when discount, but about twice as slow to actually bootstrap.
The discount is probably used much more frequently so the comporable speed is good.
The bootstrapping shoud be able to be sped up using interpolate! from BSplineKit, and in general the implementation is a bit ad-hoc to add extrapolations to BSplineKit. The author of BSK thinks that it could be made more efficient.
Benchmark script:
using BenchmarkTools
cmt = [5.25, 5.5, 5.75, 6.0, 6.25, 6.5, 6.75, 6.8, 7.0, 7.1, 7.15, 7.2, 7.3, 7.35, 7.4, 7.5, 7.6, 7.6, 7.7, 7.8] ./ 100
mats = collect(0.5:0.5:10.0)
curve = Yields.CMT(cmt, mats)
@benchmark Yields.CMT(cmt, mats)

@benchmark discount(curve, 10)

master:
julia> @benchmark Yields.CMT(cmt, mats)
BenchmarkTools.Trial: 5985 samples with 1 evaluation.
 Range (min … max):  697.583 μs …   3.701 ms  ┊ GC (min … max):  0.00% … 76.07%
 Time  (median):     723.958 μs               ┊ GC (median):     0.00%
 Time  (mean ± σ):   833.731 μs ± 465.795 μs  ┊ GC (mean ± σ):  12.20% ± 15.63%

  █▆▃▂▁                                                    ▁▁▁  ▁
  █████▆▄▃▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▆███▇ █
  698 μs        Histogram: log(frequency) by time       2.94 ms <

 Memory estimate: 2.10 MiB, allocs estimate: 23748.

julia> @benchmark discount(curve, 10)
BenchmarkTools.Trial: 10000 samples with 996 evaluations.
 Range (min … max):  25.142 ns …  1.038 μs  ┊ GC (min … max): 0.00% … 96.22%
 Time  (median):     25.393 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   26.168 ns ± 17.602 ns  ┊ GC (mean ± σ):  1.14% ±  1.67%

  █▆▃▆▅▂▁▁▂▁                                                  ▂
  ███████████▇██▇▇▇▅▆▆▅▄▅▅▄▄▃▁▄▅▃▁▁▁▄▄▁▃▁▃▃▃▄▁▃▄▁▄▄▃▄▁▄▄▄▃▁▅▅ █
  25.1 ns      Histogram: log(frequency) by time      38.9 ns <

 Memory estimate: 16 bytes, allocs estimate: 1.

This PR (linear interpolation):
BenchmarkTools.Trial: 3029 samples with 1 evaluation.
 Range (min … max):  1.514 ms …   4.089 ms  ┊ GC (min … max): 0.00% … 55.51%
 Time  (median):     1.558 ms               ┊ GC (median):    0.00%
 Time  (mean ± σ):   1.649 ms ± 385.351 μs  ┊ GC (mean ± σ):  5.13% ± 11.17%

  ▇█▆▃                                                    ▁▁  ▁
  █████▇▅▅▅▅▄▁▁▁▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▅▅████ █
  1.51 ms      Histogram: log(frequency) by time      3.37 ms <

 Memory estimate: 2.14 MiB, allocs estimate: 21831.

julia> @benchmark discount(curve, 10)
BenchmarkTools.Trial: 10000 samples with 994 evaluations.
 Range (min … max):  31.187 ns …  1.080 μs  ┊ GC (min … max): 0.00% … 95.39%
 Time  (median):     32.067 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   32.865 ns ± 17.929 ns  ┊ GC (mean ± σ):  0.93% ±  1.65%

  ▄▆▁██▂▄▆▄▅▄▂▂▁▁▁▁▂▁                                         ▂
  ███████████████████▇▇█▇▅▇▆▅▆▄▄▅▄▄▃▃▁▄▃▄▄▃▃▃▁▃▄▁▃▄▃▃▄▄▅▅▅▅▅▆ █
  31.2 ns      Histogram: log(frequency) by time      43.6 ns <

 Memory estimate: 16 bytes, allocs estimate: 1.

And this PR, with cubic spline interpolation (not possible with non-evenly spaced points on Interpolations.jl):
julia> @benchmark Yields.CMT(cmt, mats)
BenchmarkTools.Trial: 2998 samples with 1 evaluation.
 Range (min … max):  1.506 ms …   6.555 ms  ┊ GC (min … max): 0.00% …  0.00%
 Time  (median):     1.561 ms               ┊ GC (median):    0.00%
 Time  (mean ± σ):   1.666 ms ± 417.329 μs  ┊ GC (mean ± σ):  5.26% ± 11.28%

  ▇█▆▅▃▁                                                ▁     ▁
  ████████▇▇▅▅▃▃▃▃▁▃▁▃▁▁▁▁▁▁▁▃▁▁▁▃▁▁▁▁▁▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▇███▇▇▇ █
  1.51 ms      Histogram: log(frequency) by time      3.48 ms <

 Memory estimate: 2.14 MiB, allocs estimate: 21831.

julia> @benchmark discount(curve, 10)
BenchmarkTools.Trial: 10000 samples with 994 evaluations.
 Range (min … max):  31.313 ns …  1.162 μs  ┊ GC (min … max): 0.00% … 95.63%
 Time  (median):     32.655 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   33.689 ns ± 19.736 ns  ┊ GC (mean ± σ):  0.96% ±  1.66%

  ▃▄ █▄▆▆▄▄▄▅▃▂▁▂▂▁                                           ▂
  ███████████████████▇█▇▆▇▆▇▆▆▆▆▆▆▅▆▇▆▅▅▅▅▄▅▆▅▅▄▅▅▅▅▅▄▅▅▄▄▅▃▅ █
  31.3 ns      Histogram: log(frequency) by time      45.6 ns <

 Memory estimate: 16 bytes, allocs estimate: 1.

Tests pass locally, needs in-progress compat release of ActuaryUtilities.jl


Participants did not understand the participation summary on proposal page

Description
This is a usability bug:

Generally this was a little difficult to understand but all but 1 participants (who work on the project) were left unsure what was being said in the participation section.

[ ] Sketch
[ ] Design
[ ] ...

Here is an old design for what the vote summary could like.
Whole page mock up

Quicker fixes?

if 0.0000000001% show "less than 0.01%"
Show unit on all absolute values
fix some of the spacing
show what the % are of i.e. "12% of all VEGA tokens have voted" instead of "12%"

See also https://github.com/vegaprotocol/frontend-monorepo/issues/801

Superseeded by many other tickets now


Nothing happens when clicking 'Sign in to Sync Settings'

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.73.1 (Universal)
OS Version: 13.0.1 (22A400)

I am trying to log in tosync my VSCode settings, but when I click the button on the bottom left (same thing happens from the sprocket menu and the avatar menu as well), nothing happens. No error shows up, just simply cannot log in. Tried resinstalling VSCode and deleting all user data, but didn't help.

@TylerLeonhardt could be auth related?

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Textfield fullwidth disables input, textarea has placeholder value undefined

What Angular MDC version are you using?
41.0
What browser(s) is this bug affecting?
Safari
What OS are you using?
MacOS
What are the steps to reproduce the bug?
Here is my code:
<form id="login-form" [formGroup]="createRezeptForm" (ngSubmit)="onSubmit(createRezeptForm)">
  <mdc-dialog>
    <mdc-dialog-container>
      <mdc-dialog-surface>
        <mdc-dialog-title>Neues Rezept anlegen</mdc-dialog-title>

        <mdc-dialog-content>
          <mdc-text-field label="Rezeptnummer" formControlName="id" outlined fullwidth></mdc-text-field>
          <mdc-text-field label="Rezeptname" formControlName="bezeichnung" outlined fullwidth required></mdc-text-field>
          <mdc-textarea label="Anweisungen" formControlName="anweisungen"  fullwidth></mdc-textarea>
        </mdc-dialog-content>
        <mdc-dialog-actions>
          <button mdcDialogButton mdcDialogAction="close">Abbrechen</button>
          <button type="submit" mdcDialogButton mdcDialogAction="accept" [disabled]="!createRezeptForm?.valid">Rezept
            anlegen
          </button>
        </mdc-dialog-actions>
      </mdc-dialog-surface>
    </mdc-dialog-container>
  </mdc-dialog>
</form>

or see samples:
What is the expected behavior?
Textfield spans the fullwidth of my dialog and is clickable.
Textarea has empty string as placeholder value.
What is the actual behavior?
See image:

Fullwidth textfields are disabled, Textarea has undefined as placeholder value

@jacobfederer Thanks for reporting this!
I noticed late last night the undefined, and will patch that today (quick workaround until v0.41.1 is value="".
The dialog and text-field behavior I'll re-test using the provided example. Can you try wrapping the mdc-text-field inside a mdc-form-field? Either way, I'll test and let ya know.

PR #1524 resolves the undefined problem.
As for the fullwidth question, I've not been able to duplicate this yet.
Here's an example I wrote and the code

<mdc-dialog>
  <mdc-dialog-container>
    <mdc-dialog-surface>
      <mdc-dialog-title>Create profile</mdc-dialog-title>
      <mdc-dialog-content>
        <form [formGroup]="profileForm" (ngSubmit)="submit()" autocomplete="off">
          <mdc-form-field>
            <mdc-text-field formControlName="first" label="First name" fullwidth required></mdc-text-field>

*Required

          </mdc-form-field>
          <mdc-form-field>
            <mdc-text-field formControlName="last" label="Last name" fullwidth required></mdc-text-field>

*Required

          </mdc-form-field>

            <mdc-form-field>
              <mdc-text-field formControlName="middle" label="Middle name" outlined></mdc-text-field>
            </mdc-form-field>
            <mdc-form-field>
              <mdc-text-field formControlName="dob" label="Birthdate" outlined type="date"
               required [helperText]="birthDateHelper"></mdc-text-field>

*Required

            </mdc-form-field>

          <mdc-form-field>
            <mdc-text-field type="email" formControlName="email" label="Email" maxlength="254" outlined></mdc-text-field>
          </mdc-form-field>
        </form>
      </mdc-dialog-content>
      <mdc-dialog-actions>
        <button mdcDialogButton mdcDialogAction="close">Cancel</button>
        <button mdcDialogButton type="submit" form="profileForm">Create</button>
      </mdc-dialog-actions>
    </mdc-dialog-surface>
  </mdc-dialog-container>
</mdc-dialog>

Nevermind, forgot you were using fullwidth, and fullwidth is not supported with outlined. This a great chance to test out the new mdc-form-field prototype.
Until I add a property to control flex from form-field. Apply class="ngx-mdc-form-field--flex" to the control, and it'll do exactly what you expect.
<mdc-form-field>
  <mdc-text-field class="ngx-mdc-form-field--flex" formControlName="first" label="First name" outlined required></mdc-text-field>

*Required

</mdc-form-field>

Closing per #1584


Friend Point on Minimap over Ingame Window

I think the Picture should explain it
but i can understand when its to much to fix, i mean when do you have a Ingame Window over the Minimap.

Thanks for the feedback! This is a limitation of drawing an overlay onto the game window unfortunately, there's no good way to fix this as far as I know. I am looking to possibly see if I can use the built in party markers to display people which should solve this, but at the moment its on the backburner and may come with its own limitations. I'm happy to either keep this issue open and I can update it if there's any progress, or we can close it, either is fine!


The new plugin shows unknown and n/a in the topology diagram

Based on the plug-ins of oracle and tomcat, I wrote the plug-in support of China's domestic database Jincang database and Dameng data, as well as the application servers Dongfangtong and Kingdee Tianyan. Data can be collected, but displayed as unknown and n/a in the topology diagram. How do I need to modify it to display the picture I provided?

Component id with namr and icon need to be added. Read plugin dev document.

Where can I add it? I did not find the relevant description in the plugin development documentation。
https://github.com/apache/skywalking/blob/v7.0.0/docs/en/guides/Java-Plugin-Development-Guide.md

Look like you missed the doc
Component IDs are defined and reserved by SkyWalking project. For component name/ID extension, please follow Component library definition and extension document.