CORS issues (with enhanced tracking protenction)

Viewing the production site https://reddit-image-viewer.now.sh/ with Firefox + Enhanced Tracking Protection on, I get CORS errors. When I disable tracking, the site loads fine.
This does not happen in Chrome or Safari.

I just added a message to the <NoResults /> component https://github.com/gregrickaby/reddit-image-viewer/commit/da8aba8a37b86ed03208aa60bb9d80d607c1e961
Need to add the same message under the spinner...and have it display after 3-4 seconds?

Message displays after 5 seconds and asks the user to disable both Tracking Protection and Ad Blocker. https://github.com/gregrickaby/reddit-image-viewer/commit/bfcf68ea738ae5be3f76bb165e0827c0b57541d3


CASMCMS-8623: Adding architecture field for IMS schema backport 1.5

Summary and Scope
Currently IUF needs more control over the IMS architecture type. In the current structure of Images/Recipes and ContentDirs allows explicit designation of architecture in Images/Recipes options.
Issues and Related PRs

Resolves CASMCMS-8623

Tested on:

Mug IUF deliver product stage with ims-upload-artifacts 2.6.0 with James Clough

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

@jesseviola-hpe Is the actual schema change missing from this PR?


☆(𝚉𝚆𝚊𝚝𝚌𝚑≦𝚅𝙸𝙳𝙴𝙾𝚂•FULL) Subhashree Sahu Viral ᴠɪᴅᴇᴏ ʟᴇᴀᴋᴇᴅ Now Trending On Social Media X Twitter #145

10 sec ago Subhashree Sahu ʟᴇᴀᴋᴇᴅ ᴠɪᴅᴇᴏ Viral On Social Media. ☆(𝚉𝚆𝚊𝚝𝚌𝚑≦𝚅𝙸𝙳𝙴𝙾𝚂•FULL) Subhashree Sahu Viral ᴠɪᴅᴇᴏ ʟᴇᴀᴋᴇᴅ Now Trending On Social Media X Twitter #145
𝖶𝖺𝗍𝖼𝗁 🟢 ➤ ➤ ➤ 🌐 𝖢𝗅𝗂𝖼𝗄 𝖧𝖾𝗋𝖾 𝖳𝗈 𝗅𝗂𝗇𝗄 (𝖥𝗎𝗅𝗅 𝖵𝗂𝗋𝖺𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇𝗄)
🔴 ➤►𝖣𝖮𝖶𝖭𝖫𝖮𝖠𝖣👉👉 (𝖥𝗎𝗅𝗅 𝖵𝗂𝗋𝖺𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇𝗄) 𝖶𝖺𝗍𝖼𝗁
🟢 ➤ ➤ ➤ 🌐 𝖢𝗅𝗂𝖼𝗄 𝖧𝖾𝗋𝖾 𝖳𝗈 𝗅𝗂𝗇𝗄 (𝖥𝗎𝗅𝗅 𝖵𝗂𝗋𝖺𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇𝗄)
🔴 ➤►𝖣𝖮𝖶𝖭𝖫𝖮𝖠𝖣👉👉 (𝖥𝗎𝗅𝗅 𝖵𝗂𝗋𝖺𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇𝗄)
Subhashree Sahu's latest video has taken the internet by storm, sparking lively discussions across various social media platforms. The rising digital influencer, known for her captivating content—particularly her recent Spiderman-themed video—has experienced a tremendous surge in popularity, with fans eagerly awaiting the full version. Audiences are flocking to Instagram, X (formerly Twitter), and Discord to join the conversation and engage with her latest creation.
As the excitement continues to build, fans are actively sharing their thoughts online, underscoring the pivotal role social media plays in propelling creators like Subhashree Sahu into the limelight. With her distinctive style and creative approach, Nila has made a significant impact on the digital scene, leaving her audience eager to see what she will do next.  The rising digital influencer, known for her captivating content—particularly her recent Spiderman-themed video—has experienced a tremendous surge in popularity, with fans eagerly awaiting the full version. Audiences are flocking to Instagram, X (formerly Twitter), and Discord to join the conversation and engage with her latest creation.
As the excitement continues to build, fans are actively sharing their thoughts online, underscoring the pivotal role social media plays in propelling creators like Subhashree Sahu into the limelight. With her distinctive style and creative approach, Nila has made a significant impact on the digital scene, leaving her audience eager to see what she will do next.


Add docs on pipectl encrypt command

What this PR does / why we need it:
This should get merged after the next release gets ship.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/lgtm

hold before 🚀
/approve

/lgtm


Update and rename test_commit_1 to test_commit_2

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

This looks good really!


ci: gevent 1.5.0, CPython 3.7, 3.8

Happy with GitHub actions. This is now much nicer than with Travis CI before.

Happy with GitHub actions. This is now much nicer than with Travis CI before.


Unable to craft glass panes - just shows glass wall now for that recipe

MC 1.15.2
Forge 31.2.41
Vanilla Extension 1.15.2-1.0.5
I am now unable to make glass panes. JEI will show the craft correctly, but in the table it shows Glass Wall as the output from six glass blocks.
What is the correct recipe for the glass wall? I can't think it would be the same as glass panes....so is forge changing it?
Thank you,

I created a new test world MC 1.15.2 with only Vanilla Extension and the recipe for glass panes is still not working.
I did try to roll back Forge to 31.2.36 and it did not fix the issue.

Ah, yeah, I forgot to make this change on the 1.15 version. It's just fixed in the 1.16.
For a temporary solution I suggest you tou use the mod polymorph

hey, the bug is fixed on the latest version (1.15.2-1.0.6)

Great!
Thank you


go.dev: ?tab=doc is added automatically

I've been using pkg.go.dev pretty much exclusively for the last few weeks for both stdlib packages and external ones; overall, it works well without major problems :+1:
There is one small annoyance I've noticed though: it automatically adds ?tab=doc
The way I generally use this is by typing pkg in my browser's URL bar; this autofills to https://pkg.go.dev/ and I can now type or paste the package name; great!
But the automatic adding of ?tab=doc means that typing, say, net means it'll be autofilled to https://pkg.go.dev/net?tab=doc. I need to remove the query string to go to, say, net/http, instead of just being able to type http.
I understand why this query string was added, and it's a minor annoyance, but for me at least, the experience would be improved by treating the lack of a query string as if ?tab=doc was added, instead of doing a 302 redirect to the ?tab=doc variant.

/cc @julieqiu

The ?tab=doc detracts from the readability of links where the URL is displayed.
The Gophers Slack is an example of where people are posting ?tab=doc URLs.  The godoc.org URLs are more readable in that context.

I tried pkg.go.dev for a few days. I found that I was used to editing the address bar directly to switch between packages. So this automatically added ?tab=doc does seem a bit annoying.
The doc is now the default value for the tab query. Maybe pkg.go.dev should go one step further and hide it when it's the default. Please consider it.
/cc @julieqiu one more time. 🍉

@aofei please don't /cc someone again if they're already on the issue (especially one that's only a week old). We take great care to look into every issue we receive and it all takes time to triage and respond. Thanks.

We're currently discussing this request with our UX team, along with other design feedback we've received for the site. We want to review design feedback we have received as part of a broader redesign, as opposed to make piecemeal decisions. I'll update this issue once we have decided on any changes.
/cc @fflewddur

I just noticed that if a package contains no documentation but subdirectories, it loads the that tab without changing the URL btw; for example: https://pkg.go.dev/text/
Not sure if this is an oversight or intentional?

I second all of the comments here on principally aesthetic grounds, but would also add that the Doc, Overview, Subdirectories, etc. of a module are clearly hierarchical resources of the path and as such shouldn't be specified as a query parameter.

@peterbourgon I don't agree that they are clearly hierarchical in the scope of this URL. Additionally, what would happen if a module included a doc, overview, or subdirectories nested module or sub-directory?

@toothrot

I don't agree that they are clearly hierarchical in the scope of this URL.

Doc doesn't make semantic sense outside of the context of a specific module, so it's hierarchical.

Additionally, what would happen if a module included a doc, overview, or subdirectories nested module or sub-directory?

GitHub, for example, reserves the first layer of the path after the repo identifier for its tokens. If you want to access the subdir e.g. /xyz it's necessarily underneath a /blob/master/xyz or /branch/abc/xyz etc. subtree. Perhaps other code hosting sites with clean URLs could be reviewed and suitable prior art unearthed.

@peterbourgon GitHub can do that because they control the structure of repos: it's always github.com/{{user}}/{{repo}}. For modules, that is not the case. There is no way by looking at a path to know whether you are at the root of a module. GitHub also sacrifices the ability to link into the repo without specifying a query of /blob/master. Other code hosting sites make a similar sacrifice, such as on Gerrit: with host.googlesource.com/repo/+/refs/heads/master/README. Again, this is only possible if you know the root of your tree.
We're open to suggestions, and believe me we have done the effort you suggested of considering patterns on other sites. This is the best we have come up with so far. If you have a reasonable suggestion that accounts for these constraints, we'd love to consider it.

@toothrot

There is no way by looking at a path to know whether you are at the root of a module.

By the path alone, no, but pkg.go.dev has enough additional information to know if a path represents the root of a module.
To be clear, what I'm after here are clean URLs. I'm happy with any approach that gets me there :)

@toothrot

There is no way by looking at a path to know whether you are at the root of a module.

By the path alone, no, but pkg.go.dev has enough additional information to know if a path represents the root of a module.

I would argue that the point of having a clean URL is that it is user predictable, not just predictable because we have a database of modules to query, or possibly fetch at runtime. The value is lost, to me, if a user has to think about it. Our current query parameter may not be aesthetically pleasing to everyone, but it is very predictable to omit and be redirected to.

GitHub also sacrifices the ability to link into the repo without specifying a query of /blob/master

I think I'd be OK with pkg.go.dev having a similar restriction and URL structure. For example:

pkg.go.dev/github.com/peterbourgon/ff  Overview of all major versions
pkg.go.dev/github.com/peterbourgon/ff/version/v{0,1,2,...}  Redirect to latest specific version of specified major version
pkg.go.dev/github.com/peterbourgon/ff/version/v3.0.0  Overview including docs of specific version
pkg.go.dev/github.com/peterbourgon/ff/version/v3.0.0/ffcli  Overview of subpackage at a specific version

Possibilities are many. To be clear, what I'm after here are clean URLs. I'm happy with any approach that gets me there :)

We want the same thing (clean, predictable URLs)! I appreciate the thought you're putting into this.
I have a couple other examples to throw in the mix:

golang.org/x/build/maintner/cmd/maintserve (a nested module of pkg.go.dev/golang.org/x/build)
rsc.io/quote
errors (standard library)
<EMAIL_ADDRESS>(using the module syntax for versions)

edit: if it would be useful, I could make a stab at defining complete clean URL structure for current pkg.go.dev resources — would that be worthwhile, or just annoying?

I think it is worthwhile, but again, the most important thing to me is user predictability, not just a hierarchy that we can enforce in software.
Funny story from this weekend that's very relevant to you: I was mentioning github.com/go-kit/log to someone in Slack, which turned it into a link. Even though that is the most precise way to refer to that package in Go, it is a 404 due to GitHub's URL structure. I like that this works in our current design on pkg.go.dev, and would love for our URL design to be compatible with Go's import paths.

@toothrot
I'll give it a shot, including your examples, and we'll see if something emerges 👍

Even though that is the most precise way to refer to that package in Go, it is a 404 due to GitHub's URL structure. I like that this works in our current design on pkg.go.dev, and would love for our URL design to be compatible with Go's import path

I would argue that this "working" on pkg.go.dev is actually a bug, or at least not desirable. Go modules' SIV dictates that the un-versioned github.com/go-kit/kit identifier resolves to latest of the v0 or v1 major versions, but — IMO here — that's a sort of convenience, or sugar. The truth of the matter is that all resources in a module necessarily exist at, or under, a specific version, and  therefore github.com/go-kit/kit/log should really 301 or whatever to the actual, explicit,  permanent resource github.com/go-kit/kit/version/v0.10.0/log.

As much as I dislike ?tab=doc, it's only an aesthetic concern. GitHub paths where I can't just paste a filesystem path regularly cause me friction, and I strongly value the ability of typing pkg.go.dev/IMPORT_PATH.
(I do think tab= leaks a presentation concern, so I would suggest ?overview, ?versions, etc. with the default omitted, so we get clean URLs for docs. I think it would be a great color for the bike shed.)

I strongly value the ability of typing pkg.go.dev/IMPORT_PATH

+1 — I just think it should 301 to the explicit version the path resolves to, if that would enable better clean URLs.

@peterbourgon Issue #38429 may be related.

As I mentioned in #40550, editing the address bar is much more painful to do a simple operation like go to a subpackage.
I think it's important to drop the ?tab=doc but also keep the pkg.go.dev/IMPORT for similar typability.

Thanks for all the feedback, everyone. We're going to drop the ?tab=doc query param.
Moving forward, requests to pkg.go.dev/<path>?tab=doc will redirect to pkg.go.dev/<path> and requests to pkg.go.dev/<path> will stay there.


Test isKind results in Execution Error

Hello,
My test suite starts with this block:
suite: HELM - deployment.yaml

templates:
  - deployment.yaml

tests:
  - isKind:
      of: Deployment

# .. more tests

Running the test suite throws the follow error:
 FAIL   tests/deployment_yaml_test.yaml
        - Execution Error:
                no asserts found

Versions:
$ helm version
version.BuildInfo{Version:"v3.12.3", GitCommit:"3a31588ad33fe3b89af5a2a54ee1d25bfe6eaa5e", GitTreeState:"clean", GoVersion:"go1.20.7"}

$ helm plugin list
NAME            VERSION DESCRIPTION
unittest        0.3.4   Unit test for helm chart in YAML with ease to keep your chart functional and robust.

Hi, I think you just missed to specify the asserts keyword ^^
tests:
  - it: should render a Deployment
    asserts:
      - isKind:
          of: Deployment

Well, thanks @tewfik-ghariani .
I wonder how this failure got there.


Send correct User-Agent header

Hello,
Using this plugin all requests comes with native iOS User-Agent header.
The header looks similar to this: "appName/3.0.10 CFNetwork/978.0.7 Darwin/18.7.0"
Expected value should be like this: "Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Mobile/15E148 Safari/604.1"
I see that all ajax calls send correct header, but in backend we get that iOS specific one. This is currently a problem to Authenticate with Microsoft Azure where conditional access policy enabled to check the device model. It simply can't recognize the device.
Could that be fixed?
Thank you!

I'm sorry but this makes no sense. Why would the header be different than the one you send ? Are you talking about changing the header in native iOS?

Expected value should be like this: "Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Mobile/15E148 Safari/604.1"
says who?

Sorry for not being precise.
The header values I mentioned is for reference only (examples). I'm not talking about changing the header. The problem is that when you execute an ajax call from the app it should send the User-Agent header as it set by default where we have information about browser and device. The plugin intercepts the request and make it as native request where the User-Agent header is overwritten by some native ids like this "appName/3.0.10 CFNetwork/978.0.7 Darwin/18.7.0". When backend receives the request this User-Agent string makes no sense at all. So the expected behavior is to send User-Agent header one to one as it set by default in Cordova webview.

Cordova has a preference "OverrideUserAgent".
So if I set something like this in config.xml:
<preference name="OverrideUserAgent" value="my_cool_browser" />
I would expect to receive "my_cool_browser" in User-Agent header on server side.

Ok gotcha, I'll look into it

Thank you! This will be a lifesaver for us.

I believe I need to add something like this, can't test right now.. If you want to clone add test these lines in CDVWKWebViewFileXhr.m after line 88 ? Otherwise this can take a few hours here
//custom user agent
value = [self.commandDelegate.settings cordovaSettingForKey:@"OverrideUserAgent"];
if (value != nil) {
    NSLog(@"INFO: Custom User-Agent");
    [wkWebView.configuration.preferences setValue:value forKey:@"customUserAgent"];
}

I'm getting the error:
.../Plugins/@globules-io/cordova-plugin-ios-xhr/CDVWKWebViewFileXhr.m:91:44: No visible @interface for 'NSDictionary' declares the selector 'cordovaSettingForKey:'
I'm not familiar with iOS native development so can't really help here.

Sorry, meant to be
value = [self.commandDelegate.settings cdvwkStringForKey:@"OverrideUserAgent"];
if (value != nil) {
    NSLog(@"INFO: Custom User-Agent");
    [wkWebView.configuration.preferences setValue:value forKey:@"customUserAgent"];
}

cdvwkStringForKey vs cordovaSettingForKey

Now it's building fine. But User-Agent header is still being overwritten. This code most likely set the header on webview level and not on iOS native level. We need to set it on native level.

Ok I'd have to spend some time on it, can't do it right now

I have made it working by adding following code in line 385:
dispatch_sync(dispatch_get_main_queue(), ^{
        [request setValue:weakWebView.customUserAgent forHTTPHeaderField:@"User-Agent"];
});

Not sure about weakWebView.customUserAgent  I wasn't able to get it from wkWebView.configuration.preferences or maybe it's same.
I'm also using plugin cordova-plugin-useragent to set the customUserAgent property of webview to make it working.
UserAgent.set(navigator.userAgent, function(){console.log("User Agent set to: " + navigator.userAgent)});
With that combination I get expected results.

It would be cool to avoid usage of cordova-plugin-useragent and combine the code to get navigator.userAgent and set it to User-Agent header of the request.

Please test 1.1.0 using CustomUserAgent flag (see updated readme)

It works fine with that flag. Thanks! But then the User-Agent is all the time same for all devices (hardcoded).
The perfect solution would be if CustomUserAgent flag is not set than use default value from webview (navigator.userAgent) otherwise server is not able to recognize device model and os version.

or event better to introduce one more boolean flag "UseDefaultUserAgent" or "UseWebViewUserAgent". If set to true than set the value from navigator.userAgent. This approach will keep existing behavior but introduce the option we are looking for. I strongly believe this could help others as well.

No can't do that because other plugins/objects can rely on the user agent to catch if it is running on iOS/Android etc. Also this is a XHR plugin so I will keep it related to XHR requests without tempering with the webview too much. This is as far as I will take it but feel free to fork and make your own modifications.

Ok, I understand.
Thank you anyways for quick responses and reaction!


Doubt regarding afterScenario and afterFeature

I have a doubt regarding the afterScenario and afterFeature in karate . In case my actual scenario fails and I have configured afterScenario and afterFeature , does they still execute???
In my case I have a Scenario and I have configured afterScenario to do some cleanup task but when my scenario fails the afterScenario is not executed .
I am assuming it should execute even if there is a failure in the actual scenario otherwise what is the use of afterScenario for clean up purpose.

Same doubt for afterFeature as well

please ask such questions on stack overflow, also see: https://stackoverflow.com/a/60944060/143475


bugfix: TransactionHook of different distributed transactions under the same thread will be removed

fixes #5150

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: slievrly:white_check_mark: zw201913:x: 邹伟邹伟 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #5152 (ccc30e2) into develop (bf99018) will increase coverage by 0.04%.
The diff coverage is 96.87%.

@@              Coverage Diff              @@
##             develop    #5152      +/-   ##
=============================================
+ Coverage      48.95%   48.99%   +0.04%
- Complexity      4168     4175       +7
=============================================
  Files            741      741
  Lines          26521    26537      +16
  Branches        3294     3298       +4
=============================================
+ Hits           12984    13003      +19
+ Misses         12129    12128       -1
+ Partials        1408     1406       -2

Impacted Files
Coverage Δ

...ata/tm/api/transaction/TransactionHookManager.java
96.55% <95.65%> (+10.83%)
:arrow_up:

...in/java/io/seata/tm/api/TransactionalTemplate.java
61.15% <100.00%> (+0.28%)
:arrow_up:

...erver/storage/file/session/FileSessionManager.java
53.50% <0.00%> (-0.64%)
:arrow_down:

...rage/redis/store/RedisTransactionStoreManager.java
74.41% <0.00%> (-0.27%)
:arrow_down:

...torage/file/store/FileTransactionStoreManager.java
56.91% <0.00%> (+1.28%)
:arrow_up:


Brollb patch 9

Repushed @brollb's PR: https://github.com/pachyderm/pachyderm/pull/1918
Since we now have secrets on travis CI / so only maintainers are allowed to run CI.
We need a better way to handle user submitted PRs. I've created an issue here for that.

LGTM


Android: make statfs64.f_fsid public

This has been the case since the initial commit
a36da11fb9cfcafcee6cb263bf1dc2c84371730a. But there is no reason to hide
this struct member specifically.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

But there is no reason to hide
this struct member specifically.

Hmm, I don't think so. The f_fsid has some security concerns according to the man page, and fsid_t also hides their value. Therefore I don't think it makes sense to expose it at all.

libc is not the right place to deal with this "security concern".  It'll limit what programs can do.  This specific syscall wrapper should be a transparent interface to fstatfs(2), like what's provided in other programming languages, other platforms (note this one is only not public for Android in this crate), or even other syscall struct (i.e. statvfs64 in the same file).
My understanding to this "security concern" is really about confidentiality. Using statfs/fstatfs against files on a remote filesystem would expose the server's backing filesystem types.

note this one is only not public for Android in this crate

This isn't right, other statfs64 exposes f_fsid but fsid_t doesn't actually.

Please take a look at the latest patch.  I fixed the type as well to be consistent with Android's libc.

This will be a breaking change, though.
Before considering accepting this, I'd also like to hear the initial thoughts from @alexcrichton as I'm not sure if my understanding is correct.

Ah unfortunately I don't remember the initial context around this, but I would agree with the point of view that libc isn't positioned to nudge towards best practices, but rather it's intended to give a faithful and accurate view of  the underlying system. In that senses I would agree that this shouldn't be hidden for confidentiality reasons, but I'm not sure if that was the only reason it was hidden.

This will be a breaking change, though.

Probably not, since this field wasn't public before?

... I'm not sure if that was the only reason it was hidden.

If I had to make a guess, maybe it was trying to be cautious about endian?  I saw some condition for mips in the original change.
But anyway, Android kernel nowadays is pretty much just Linux, so it's nice to keep the structs consistent.  In fact, I don't see any good reason to maintain duplicated definitions, but de-duplication would be a bigger change and is out of the current scope :)

@bors r+

:pushpin: Commit 53d7168806741fa585244004870319627a814644 has been approved by JohnTitor

:hourglass: Testing commit 53d7168806741fa585244004870319627a814644 with merge 80eb0cf2921ef0c6f0b612e79864104d21301d2f...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 80eb0cf2921ef0c6f0b612e79864104d21301d2f to master...

Thanks!


Feature: support k3s/k8s

Have you searched for this feature request?

[X] I searched but did not find similar requests

Problem Statement
we now use kind , can we use k3s or k8s??
idpbuild create --kubeconfigPath xxx
Possible Solution
k8s
Alternatives Considered
No response

It's very likely possible. We'll need to come up with a provisioner interface and handle any implementation specific things but we should be able to support core features relatively easily

@nabuskey  provisioner interface is good , like k8s cloudprovider , btw , I want to deploy on k3d ,  google cloud and other different type of k8s , I think the work is not that much , the interface can be simple .


impl proper_controller_dispose DartFix

Description
Dart Fix for proper_controller_dispose lint.
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactor
[ ] Documentation
[ ] Other

Checklist

[x] I have read the CONTRIBUTING.md document.
[x] I have performed a self-review of my code.
[ ] I have linked the issue ticket in the description.
[ ] I have made the necessary changes to the documentation.
[x] I have checked the formatting with dart format .
[x] I have analyzed my code with dart analyze .
[x] I have run dart run custom_lint example to check for any custom linting issues.

Your implementation adds multiple dispose statements and I am not sure if this is the behaviour we want. Typically, quick fixes correspond to its own lint warning so when we apply a quick fix to a particular warning, it should only add one dispose statement.
When custom_lint fix --apply is available, I believe each fix will be applied to its corresponding lint warning and therefore the current behaviour may conflict with the command.

Changes done. Please review it.

Changes done, please review the changes.


add command option --imgdir, process all images in directory.

add option to process all images in one directory and save predictions in sub-directory 'out'.
eg. python yolo_video.py --imgdir .\samples
predictions will be save in .\samples\out
predictions are images draw with bounding boxes.
its a command line option in darkflow

Hi, it seems that this repo is inactive for a while... (more than a year :worried:)
Would you consider to pass your changes to this fork https://github.com/Borda/keras-yolo3 ?


TEOC sign in error

Hi seems like I might have a misconfiguration in my current configuration somewhere but not sure what exactly was misconfigured.

Application manifest File
{
	"id": "5b56ed52-21c0-4ad3-9823-00c3db736d82",
	"acceptMappedClaims": null,
	"accessTokenAcceptedVersion": 2,
	"addIns": [],
	"allowPublicClient": null,
	"appId": "90cbf851-abf3-4c8a-8d42-8cecc45cbc5f",
	"appRoles": [],
	"oauth2AllowUrlPathMatching": false,
	"createdDateTime": "2024-01-23T14:25:08Z",
	"description": null,
	"certification": null,
	"disabledByMicrosoftStatus": null,
	"groupMembershipClaims": null,
	"identifierUris": [
		"api://teoc01p.azurewebsites.net/90cbf851-abf3-4c8a-8d42-8cecc45cbc5f"
	],
	"informationalUrls": {
		"termsOfService": null,
		"support": null,
		"privacy": null,
		"marketing": null
	},
	"keyCredentials": [],
	"knownClientApplications": [],
	"logoUrl": null,
	"logoutUrl": null,
	"name": "TEOC",
	"notes": null,
	"oauth2AllowIdTokenImplicitFlow": true,
	"oauth2AllowImplicitFlow": true,
	"oauth2Permissions": [
		{
			"adminConsentDescription": "Allows Teams to call the app’s web APIs as the current user.",
			"adminConsentDisplayName": "Teams can access app’s web APIs",
			"id": "2aa65e3f-e8f4-4e6f-960d-7345df0be882",
			"isEnabled": true,
			"lang": null,
			"origin": "Application",
			"type": "User",
			"userConsentDescription": "Allows Teams to call the app’s web APIs as the current user.",
			"userConsentDisplayName": "Teams can access app’s web APIs",
			"value": "access_as_user"
		}
	],
	"oauth2RequirePostResponse": false,
	"optionalClaims": {
		"idToken": [],
		"accessToken": [
			{
				"name": "idtyp",
				"source": null,
				"essential": false,
				"additionalProperties": []
			}
		],
		"saml2Token": []
	},
	"orgRestrictions": [],
	"parentalControlSettings": {
		"countriesBlockedForMinors": [],
		"legalAgeGroupRule": "Allow"
	},
	"passwordCredentials": [
		{
			"customKeyIdentifier": null,
			"endDate": "2025-01-22T14:28:02.121Z",
			"keyId": "dad2ef4e-97aa-4045-90a6-796be0309205",
			"startDate": "2024-01-23T14:28:02.121Z",
			"value": null,
			"createdOn": "2024-01-23T14:28:34.5487237Z",
			"hint": "dYx",
			"displayName": "TEOC Secret"
		}
	],
	"preAuthorizedApplications": [
		{
			"appId": "00000002-0000-0ff1-ce00-000000000000",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "d3590ed6-52b3-4102-aeff-aad2292ab01c",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "4765445b-32c6-49b0-83e6-1d93765276ca",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "4345a7b9-9a63-4910-a426-35363201d503",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "1fec8e78-bce4-4aaf-ab1b-5451cc387264",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "5e3ce6c0-2b1f-4285-8d4b-75ee78787346",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		}
	],
	"publisherDomain": "baltimorecountymd.gov",
	"replyUrlsWithType": [
		{
			"url": "https://teoc01p.azurewebsites.net/blank-auth-end.html",
			"type": "Spa"
		},
		{
			"url": "https://teoc01p.azurewebsites.net/auth-end.html?clientId=90cbf851-abf3-4c8a-8d42-8cecc45cbc5f",
			"type": "Spa"
		},
		{
			"url": "https://teoc01p.azurewebsites.net/auth-end.html",
			"type": "Web"
		}
	],
	"requiredResourceAccess": [
		{
			"resourceAppId": "00000003-0000-0000-c000-000000000000",
			"resourceAccess": [
				{
					"id": "0e263e50-5827-48a4-b97c-d940288653c7",
					"type": "Scope"
				},
				{
					"id": "5f8c59db-677d-491f-a6b8-5f174b11ec1d",
					"type": "Scope"
				},
				{
					"id": "4e46008b-f24c-477d-8fff-7bb4ec7aafe0",
					"type": "Scope"
				},
				{
					"id": "e383f46e-2787-4529-855e-0e479a3ffac0",
					"type": "Scope"
				},
				{
					"id": "a65f2972-a4f8-4f5e-afd7-69ccb046d5dc",
					"type": "Scope"
				},
				{
					"id": "ba47897c-39ec-4d83-8086-ee8256fa737d",
					"type": "Scope"
				},
				{
					"id": "65e50fdc-43b7-4915-933e-e8138f11f40a",
					"type": "Scope"
				},
				{
					"id": "f45671fb-e0fe-4b4b-be20-3d3ce43f1bcb",
					"type": "Scope"
				},
				{
					"id": "2219042f-cab5-40cc-b0d2-16b1540b4c5f",
					"type": "Scope"
				},
				{
					"id": "4a06efd2-f825-4e34-813e-82a57b03d1ee",
					"type": "Scope"
				},
				{
					"id": "0f4595f7-64b1-4e13-81bc-11a249df07a9",
					"type": "Scope"
				},
				{
					"id": "a9ff19c2-f369-4a95-9a25-ba9d460efc8e",
					"type": "Scope"
				},
				{
					"id": "539dabd7-b5b6-4117-b164-d60cd15a8671",
					"type": "Scope"
				},
				{
					"id": "e1fe6dd8-ba31-4d61-89e7-88639da4683d",
					"type": "Scope"
				},
				{
					"id": "b340eb25-3456-403f-be2f-af7a0d370277",
					"type": "Scope"
				}
			]
		}
	],
	"samlMetadataUrl": null,
	"signInUrl": null,
	"signInAudience": "AzureADMyOrg",
	"tags": [],
	"tokenEncryptionKeyId": null
}

Hi seems like I might have a misconfiguration in my current configuration somewhere but not sure what exactly was misconfigured.

Application manifest File
{
	"id": "5b56ed52-21c0-4ad3-9823-00c3db736d82",
	"acceptMappedClaims": null,
	"accessTokenAcceptedVersion": 2,
	"addIns": [],
	"allowPublicClient": null,
	"appId": "90cbf851-abf3-4c8a-8d42-8cecc45cbc5f",
	"appRoles": [],
	"oauth2AllowUrlPathMatching": false,
	"createdDateTime": "2024-01-23T14:25:08Z",
	"description": null,
	"certification": null,
	"disabledByMicrosoftStatus": null,
	"groupMembershipClaims": null,
	"identifierUris": [
		"api://teoc01p.azurewebsites.net/90cbf851-abf3-4c8a-8d42-8cecc45cbc5f"
	],
	"informationalUrls": {
		"termsOfService": null,
		"support": null,
		"privacy": null,
		"marketing": null
	},
	"keyCredentials": [],
	"knownClientApplications": [],
	"logoUrl": null,
	"logoutUrl": null,
	"name": "TEOC",
	"notes": null,
	"oauth2AllowIdTokenImplicitFlow": true,
	"oauth2AllowImplicitFlow": true,
	"oauth2Permissions": [
		{
			"adminConsentDescription": "Allows Teams to call the app’s web APIs as the current user.",
			"adminConsentDisplayName": "Teams can access app’s web APIs",
			"id": "2aa65e3f-e8f4-4e6f-960d-7345df0be882",
			"isEnabled": true,
			"lang": null,
			"origin": "Application",
			"type": "User",
			"userConsentDescription": "Allows Teams to call the app’s web APIs as the current user.",
			"userConsentDisplayName": "Teams can access app’s web APIs",
			"value": "access_as_user"
		}
	],
	"oauth2RequirePostResponse": false,
	"optionalClaims": {
		"idToken": [],
		"accessToken": [
			{
				"name": "idtyp",
				"source": null,
				"essential": false,
				"additionalProperties": []
			}
		],
		"saml2Token": []
	},
	"orgRestrictions": [],
	"parentalControlSettings": {
		"countriesBlockedForMinors": [],
		"legalAgeGroupRule": "Allow"
	},
	"passwordCredentials": [
		{
			"customKeyIdentifier": null,
			"endDate": "2025-01-22T14:28:02.121Z",
			"keyId": "dad2ef4e-97aa-4045-90a6-796be0309205",
			"startDate": "2024-01-23T14:28:02.121Z",
			"value": null,
			"createdOn": "2024-01-23T14:28:34.5487237Z",
			"hint": "dYx",
			"displayName": "TEOC Secret"
		}
	],
	"preAuthorizedApplications": [
		{
			"appId": "00000002-0000-0ff1-ce00-000000000000",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "d3590ed6-52b3-4102-aeff-aad2292ab01c",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "4765445b-32c6-49b0-83e6-1d93765276ca",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "4345a7b9-9a63-4910-a426-35363201d503",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "1fec8e78-bce4-4aaf-ab1b-5451cc387264",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		},
		{
			"appId": "5e3ce6c0-2b1f-4285-8d4b-75ee78787346",
			"permissionIds": [
				"2aa65e3f-e8f4-4e6f-960d-7345df0be882"
			]
		}
	],
	"publisherDomain": "baltimorecountymd.gov",
	"replyUrlsWithType": [
		{
			"url": "https://teoc01p.azurewebsites.net/blank-auth-end.html",
			"type": "Spa"
		},
		{
			"url": "https://teoc01p.azurewebsites.net/auth-end.html?clientId=90cbf851-abf3-4c8a-8d42-8cecc45cbc5f",
			"type": "Spa"
		},
		{
			"url": "https://teoc01p.azurewebsites.net/auth-end.html",
			"type": "Web"
		}
	],
	"requiredResourceAccess": [
		{
			"resourceAppId": "00000003-0000-0000-c000-000000000000",
			"resourceAccess": [
				{
					"id": "0e263e50-5827-48a4-b97c-d940288653c7",
					"type": "Scope"
				},
				{
					"id": "5f8c59db-677d-491f-a6b8-5f174b11ec1d",
					"type": "Scope"
				},
				{
					"id": "4e46008b-f24c-477d-8fff-7bb4ec7aafe0",
					"type": "Scope"
				},
				{
					"id": "e383f46e-2787-4529-855e-0e479a3ffac0",
					"type": "Scope"
				},
				{
					"id": "a65f2972-a4f8-4f5e-afd7-69ccb046d5dc",
					"type": "Scope"
				},
				{
					"id": "ba47897c-39ec-4d83-8086-ee8256fa737d",
					"type": "Scope"
				},
				{
					"id": "65e50fdc-43b7-4915-933e-e8138f11f40a",
					"type": "Scope"
				},
				{
					"id": "f45671fb-e0fe-4b4b-be20-3d3ce43f1bcb",
					"type": "Scope"
				},
				{
					"id": "2219042f-cab5-40cc-b0d2-16b1540b4c5f",
					"type": "Scope"
				},
				{
					"id": "4a06efd2-f825-4e34-813e-82a57b03d1ee",
					"type": "Scope"
				},
				{
					"id": "0f4595f7-64b1-4e13-81bc-11a249df07a9",
					"type": "Scope"
				},
				{
					"id": "a9ff19c2-f369-4a95-9a25-ba9d460efc8e",
					"type": "Scope"
				},
				{
					"id": "539dabd7-b5b6-4117-b164-d60cd15a8671",
					"type": "Scope"
				},
				{
					"id": "e1fe6dd8-ba31-4d61-89e7-88639da4683d",
					"type": "Scope"
				},
				{
					"id": "b340eb25-3456-403f-be2f-af7a0d370277",
					"type": "Scope"
				}
			]
		}
	],
	"samlMetadataUrl": null,
	"signInUrl": null,
	"signInAudience": "AzureADMyOrg",
	"tags": [],
	"tokenEncryptionKeyId": null
}

I think you need to check that the Manifest code is updated and correct as per the documentation

I have and I am not seeing anything that's misconfigured. Where should I check to see if it is misconfigured?

Issue literally just resolved itself. However I am having issues submitting the incidents :(

Here are some screenshots of the groups policy. However I do not want to remove the Naming Policy.

Issue literally just resolved itself. However I am having issues submitting the incidents :(

I am waiting for a response for the very same problem. I think there is an issue; Perhaps you can attach the console log and tracers for the admins to look and then you can take it from there.

Hi @BCG-cmori , @sanjaymittaluk
There is a known issue with one of the graph end points causing the incident creation to fail. We are working with the team and this is expected to be resolved ASAP. We will keep you posted. Thanks for your patience on this.
Thanks.

There is a known issue with one of the graph end points, causing the incident creation to fail. We are working with the team and this is expected to be resolved ASAP. We will keep you posted. Thanks for your patience on this.

thank you. much appreciated.

Hi @BCG-cmori,
It is expected to be resolved by Jan 31st. We will keep you posted.
Thanks.

Great thanks!

Hi just wanted to follow up on this to see if we have any good news?

@BCG-cmori,
Thank you for your patience on this.
We have released the hotfix for this issue. Request you to kindly sync the code by following steps mentioned in this link
If you are still getting the issue we suggest you to clear cache and try again.

Awesome thank you! I will work on this and follow up if we run into any issues.

@BCG-cmori, We will close this ticket now. In case of any issue, you can reopen this or create new ticket. Thank you.

Hi
I did the sync and cleared cache in my browser but doesn't seem to be working yet. Do I need do anything else besides those items?

@BCG-cmori, Can you please confirm if sync was successful. Please share the screenshot of deployment logs from App Service > Deployment Center > Logs
If sync is successful, can you please try to open teams in different browser, may be the one which you have not used or in Teams client.
If you are still facing the issue, request you to kindly share the console logs and network trace.

Yeah i have waited 24 hours now and tried different browsers and I am still getting an error when i try to submit a new incident. I also looked at the developer console logs and looks like its specific to the prefix we force on new groups. Do we need to disable that or is there a way for TEOC to follow the prefix we have set?

@BCG-cmori,
Thank you for sharing the details.
Group naming policy needs to be disabled for TEOC then only incident creation will succeed.
At present, TEOC application will not follow custom prefix.


Add support for secure etcd

This requires updating libcalico and calico repositories.

Closing.  There is a new PR for this.


Support for React/Typescript React

"inlineFold.supportedLanguages": [
  "html",
  "svelte",
  "react",
  "javascript react",
  "typescript react",
  "javascript",
  "js",
  "tsx",
  "jsx",
  "ts"
],,
"inlineFold.regex": "className=\".+?(?=\")",

These are settings I've tried to achieve className folding in .tsx files.
I'm not sure it is not supported yet or I haven't do it right.

Hey @ccccooooddddyyyy
This should work with reactjs
https://regex101.com/r/8Jj6Q9/1
Make sure you set "inlineFold.regexGroup": 2

Hey @ccccooooddddyyyy This should work with reactjs
https://regex101.com/r/8Jj6Q9/1
Make sure you set "inlineFold.regexGroup": 2

Thanks for replying.
Here's screenshot of my settings. It's still not work tho :D

When you open .tsx file what is the file language is displayed in the right side of the status bar?

When you open .tsx file what is the file language displayed in the right side of the status bar?

Also could you show me the code you trying to fold

It's Typescript React.

Add typescriptreact to the languages list.
The extension uses languageId as because a language could have more than one file extension & aliases
Here's a list of known languages
Known language identifiers

Add typescriptreact to the languages list.
The extension uses languageId as because a language could have more than one file extension & aliases
Here's a list of known languages Known language identifiers

Worked perfectly! I wished to find information like this in the docs even nicer if it comes with regex settings.

Worked perfectly! I wished to find information like this in the docs even nicer if it comes with regex settings.

Good to hear that :)
Sure I'll update the docs with some common regex examples also more descriptive settings.

One more question before this will be closed, how can i use regex to select ` (backtick) or { (open curly bracket) after className

That's why I asked for the code because the regex I gave worked only for double quotes className. Try this https://regex101.com/r/RkCWEk/1 and if you mean { and ` could come together? I'm not really familiar with reactjs, but if so then I guess it's also achievable https://regex101.com/r/NuDLoF/1
Both use the default group number: 2

For anyone wanting to get set up quickly with React.

Ctrl + Shift + P -> Open Settings (JSON)
Add the below

"inlineFold.regex": "(className)=[{`'\"]([^\\'`\"}]*)[\"'`}]",
"inlineFold.supportedLanguages": [
    "html",
    "svelte",
    "javascriptreact",
    "jsx",
    "typescriptreact",
    "javascript"
],
"inlineFold.regexGroup": "2"

@dougwithseismic
Thank you so much.
I'll push an update soon that has even better performance and eliminate the unnecessary events triggers.
Anyways I will mention you when I'm done so that if you cloud have free time you could help with docs 😊

Please update the extension and restart VS Code then reset the regex and regexGroup settings to the default values.


Forwarding express routes not working

Condition in lib/index.js on row 55 is not needed. All routes in app are parsed. IO route messages: {message: ...} already "messages:message" in this.router and requested route no need to split by :.

@Shold could you provide a small code sample? I've got some time now to look into this.

@Shold no worries, I have been able to reproduce this!

http://pix.toile-libre.org/upload/original/1430420146.png This construction is not working because tests is not a object with 2 params test1 and test2 in this.router. We have tests:test1 and tests:test2. Therefore we do not need to split requested route tests:test1. Sorry for my english. I hope you understand me

that's what I mean (lib/index.js): http://pix.toile-libre.org/upload/original/1430420720.png

I have published a new version to NPM - could you try it please?

Yeah! Forwarding now work! Thanks! I will continue testing


docs: 更新官网 S2 版本 & 优化文档

👀 PR includes
🔧 Chore

[ ] Test case
[x] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description

修复官网错误 md 格式
增加紧凑布局的 demo 和文档完善
更新官网的 S2 版本, 修复错误的 demo

🖼 Screenshot

Before
After

❌
✅

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-react-v1.44.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Are Sequentials with list comprehension handled incorrectly?

Because:
class TheModel(nn.Module):

    def __init__(self, n_token_embed, n_layers):
        super().__init__()
        n_heads = n_token_embed // 2
        n_key_size = n_token_embed
        self.token_embedding_table = nn.Embedding(len(all_symbols), n_token_embed)
        self.position_embedding_table = nn.Embedding(N_CONTEXT, n_token_embed)
        self.blocks = nn.Sequential(*[Block(n_token_embed, n_key_size, n_heads) for _ in range(n_layers)])
        self.ln_f = nn.LayerNorm(n_token_embed) # final layer norm
        self.lm_head = nn.Linear(n_token_embed, N_CATEGORIES * 2)

---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
[<ipython-input-21-944f2038ce18>](https://localhost:8080/#) in <cell line: 86>()
     84 delta_model = TheModel(4, N_LAYERS)
     85 model = TheModel(N_TOKEN_EMBED, N_LAYERS)
---> 86 set_base_shapes(model, base_model, delta=delta_model)
     87
     88 m = model.to(device)

1 frames
[/usr/local/lib/python3.9/dist-packages/mup/shape.py](https://localhost:8080/#) in _zip_infshape_dict(base_shapes, shapes)
     93     basenames = set(base_shapes.keys())
     94     names = set(shapes.keys())
---> 95     assert basenames == names, (
     96         f'`base_shapes` has extra names {basenames - names}. '
     97         f'`shapes` has extra names {names - basenames}.'

AssertionError: `base_shapes` has extra names set(). `shapes` has extra names {'blocks.0.sa.heads.1.value.weight', 'blocks.2.sa.heads.1.query.weight', 'blocks.2.sa.heads.1.value.weight', 'blocks.0.sa.heads.1.key.weight', 'blocks.1.sa.heads.1.value.weight', 'blocks.1.sa.heads.1.key.weight', 'blocks.2.sa.heads.1.key.weight', 'blocks.0.sa.heads.1.query.weight', 'blocks.1.sa.heads.1.query.weight'}.

Hi Robert,
Not sure I understand your problem exactly since I don’t see the rest of your code, but are you creating the base shapes for one depth value L1 but then applying it to a model with depth L2 != L1? This could cause something like the error you are seeing. The depth needs to be the same between them.
From: Robert Baruch @.>
Date: Monday, April 17, 2023 at 4:39 PM
To: microsoft/mup @.>
Cc: Subscribed @.***>
Subject: [microsoft/mup] Are Sequentials with list comprehension handled incorrectly? (Issue #43)
Because:
class TheModel(nn.Module):
def __init__(self, n_token_embed, n_layers):

    super().__init__()

    n_heads = n_token_embed // 2

    n_key_size = n_token_embed

    self.token_embedding_table = nn.Embedding(len(all_symbols), n_token_embed)

    self.position_embedding_table = nn.Embedding(N_CONTEXT, n_token_embed)

    self.blocks = nn.Sequential(*[Block(n_token_embed, n_key_size, n_heads) for _ in range(n_layers)])

    self.ln_f = nn.LayerNorm(n_token_embed) # final layer norm

    self.lm_head = nn.Linear(n_token_embed, N_CATEGORIES * 2)

AssertionError                            Traceback (most recent call last)
 in <cell line: 86>()
 84 delta_model = TheModel(4, N_LAYERS)

 85 model = TheModel(N_TOKEN_EMBED, N_LAYERS)

---> 86 set_base_shapes(model, base_model, delta=delta_model)
 87

 88 m = model.to(device)

1 frames
/usr/local/lib/python3.9/dist-packages/mup/shape.py in _zip_infshape_dict(base_shapes, shapes)
 93     basenames = set(base_shapes.keys())

 94     names = set(shapes.keys())

---> 95     assert basenames == names, (
 96         f'`base_shapes` has extra names {basenames - names}. '

 97         f'`shapes` has extra names {names - basenames}.'

AssertionError: base_shapes has extra names set(). shapes has extra names {'blocks.0.sa.heads.1.value.weight', 'blocks.2.sa.heads.1.query.weight', 'blocks.2.sa.heads.1.value.weight', 'blocks.0.sa.heads.1.key.weight', 'blocks.1.sa.heads.1.value.weight', 'blocks.1.sa.heads.1.key.weight', 'blocks.2.sa.heads.1.key.weight', 'blocks.0.sa.heads.1.query.weight', 'blocks.1.sa.heads.1.query.weight'}.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/mup/issues/43, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMWHHM53MTNGZQDYVUTOSQLXBXICZANCNFSM6AAAAAAXB3JN44.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

hi @thegregyang , I ran into the same issue and its also due to the depths not matching. In the paper you showed that this method also works for scaling the depth of the model. How can this be achieved? (specifically with the mutransformers submodule)


Fixed issue with opening on Windows Store

What is this PR about
This PR fixes the way a user is directed to the Microsoft Store to download the Sysinternals Suite.
Currently, the "Install Sysinternals Suite from the Microsoft Store" link is misbehaving.
The current behaviour of the link is as follows:

Sometimes, the link yeilds a 503

Sometimes, the link yields a missing page

Sometimes, it takes unreasonable amount of time to get redirected to apps.microsoft which techinically is a Microsoft Store but on the web as opposed to the user's local Microsoft Store which is more intuitive for user to install from.

Solution
According to UWP documentation, the recommended way to link to a specific product/software in the Windows Store / Microsoft Store is by using ms-windows-store://pdp/?ProductId=XXXXXXX and this PR does that.
Alternative Solution
Refer to apps.microsoft.com page for Sysinternals Suite directly.

I would personally vote for the alternative solution, so the link is still supported on non-windows platforms.
But any fix for the Service Unavailable error would be appreciated as I'm also experience this issue.
For me it's pretty consistent always returning af HTTP 503 error in multiple browsers and different networks.


ci: sync image tags to helm chart

⚠ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[x] I have read through the Contributing Documentation.
[x] I have added relevant tests.
[x] I have added relevant documentation.
[x] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary
Sync devlake helm chart(by creating a pull request) when a new tag is pushed.
Does this close any open issues?
None.
This PR is generated by the actions of my fork repo: https://github.com/apache/incubator-devlake-helm-chart/pull/83
Screenshots

Other Information
Note: The maintainer of devlake must do things below to set up the actions

Prepare a GitHub Account(such as a bot account, this account does not need to have any permissions for any Apache projects.) and fork incubator-devlake-helm-chart repo
Apply a GitHub Personal Access Token with repo scope of that account, and set it to GH_PAT in secrets of incubator-devlake.
Update env.FORK_REPO to <USER_OF_GH_PAT>/incubator-devlake-helm-chart in .github/workflows/sync-helm.yml

Update other configurations in .github/workflows/sync-helm.yml if you want.

Two more comments:

Suggest adding this stage as the last stage in build.yml, as we need to ensure the images are pushed success, then trigger the helm chart promote version.
Previously, only actions from verified creators are allowed in this repo.

Great Job.
Two more comments:

Suggest adding this stage as the last stage in build.yml, as we need to ensure the images are pushed success, then trigger the helm chart promote version.
Previously, only actions from verified creators are allowed in this repo.

Thank you for you careful review! @matrixji
For the second suggestion, I want to use the way above to sovle it:
Usinggit submodule to download actions to .workflows/actions in apache/incubator-devalke, like the solutions in helm chart:
https://github.com/apache/incubator-devlake-helm-chart/tree/main/.github/actions

Is it allowed?

Great Job.
Two more comments:

Suggest adding this stage as the last stage in build.yml, as we need to ensure the images are pushed success, then trigger the helm chart promote version.
Previously, only actions from verified creators are allowed in this repo.

Thank you for you careful review! @matrixji
For the second suggestion, I want to use the way above to sovle it:
Usinggit submodule to download actions to .workflows/actions in apache/incubator-devalke, like the solutions in helm chart:
https://github.com/apache/incubator-devlake-helm-chart/tree/main/.github/actions

Is it allowed?

IMO, this it's acceptable, @warren830 could also help comment on that?

From my perspective, creating a github bot to submit pr, and manually approving it by us is better?

Great Job.
Two more comments:

Suggest adding this stage as the last stage in build.yml, as we need to ensure the images are pushed success, then trigger the helm chart promote version.
Previously, only actions from verified creators are allowed in this repo.

Thank you for you careful review! @matrixji
For the second suggestion, I want to use the way above to sovle it:
Usinggit submodule to download actions to .workflows/actions in apache/incubator-devalke, like the solutions in helm chart:
https://github.com/apache/incubator-devlake-helm-chart/tree/main/.github/actions

Is it allowed?

IMO, this it's acceptable, @warren830 could also help comment on that?

I'm not quite sure about the workflow of the second suggestion. Will this also submit a pr or promote automatically?
From my perspective, creating a github bot to submit pr, and manually approving it by us is acceptable, but if the second proposal require less work, I think it'd be better.

@matrixji @aFlyBird0 I found some related information from https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
According to the document, the GITHUB_TOKEN is generated by the Github App and restricted to the installed repo only, in other words, it can't be used to fork and create pr for another repo.

Some new ideas about this solution, this action finally want's to create PR in repo ``

@matrixji @aFlyBird0 I found some related information from https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
According to the document, the GITHUB_TOKEN is generated by the Github App and restricted to the installed repo only, in other words, it can't be used to fork and create pr for another repo.

Maybe the simple way is just to create an action in incubator-devlake-helm-chart itself for creating PR promoting the image versions. And this action is triggered by an Issue raised in  incubator-devlake-helm-chart (we could add an issue template for changing image tags)

Some new ideas about this solution, this action finally want's to create PR in repo ``

@matrixji @aFlyBird0 I found some related information from https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
According to the document, the GITHUB_TOKEN is generated by the Github App and restricted to the installed repo only, in other words, it can't be used to fork and create pr for another repo.

Maybe the simple way is just to create an action in incubator-devlake-helm-chart itself for creating PR promoting the image versions. And this action is triggered by an Issue raised in incubator-devlake-helm-chart (we could add an issue template for changing image tags)
A PoC for this idea: The Issue create from the template form: matrixji/repo-merge-example-bar#1 The related PR is triggered by the above issue: matrixji/repo-merge-example-bar#2

I think it's a good idea!  🚀 @matrixji

Some new ideas about this solution, this action finally want's to create PR in repo ``

@matrixji @aFlyBird0 I found some related information from https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
According to the document, the GITHUB_TOKEN is generated by the Github App and restricted to the installed repo only, in other words, it can't be used to fork and create pr for another repo.

Maybe the simple way is just to create an action in incubator-devlake-helm-chart itself for creating PR promoting the image versions. And this action is triggered by an Issue raised in incubator-devlake-helm-chart (we could add an issue template for changing image tags)
A PoC for this idea: The Issue create from the template form: matrixji/repo-merge-example-bar#1 The related PR is triggered by the above issue: matrixji/repo-merge-example-bar#2

The issue have to be created manually, is that correct?

matrixji/repo-merge-example-bar#1

Yes, see https://github.com/matrixji/repo-merge-example-bar/issues/new/choose

Some new ideas about this solution, this action finally want's to create PR in repo ``

@matrixji @aFlyBird0 I found some related information from https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
According to the document, the GITHUB_TOKEN is generated by the Github App and restricted to the installed repo only, in other words, it can't be used to fork and create pr for another repo.

Maybe the simple way is just to create an action in incubator-devlake-helm-chart itself for creating PR promoting the image versions. And this action is triggered by an Issue raised in incubator-devlake-helm-chart (we could add an issue template for changing image tags)
A PoC for this idea: The Issue create from the template form: matrixji/repo-merge-example-bar#1 The related PR is triggered by the above issue: matrixji/repo-merge-example-bar#2

The issue have to be created manually, is that correct?

Yes, see https://github.com/matrixji/repo-merge-example-bar/issues/new/choose @klesh

@matrixji I think your solution is well established (even have set the form in the issue template) how about I just close this PR after others agree and you submit a new PR to the helm repository?
I've had a great time discussing with you the last few days and have learned a lot, thanks!

@matrixji I think your solution is well established (even have set the form in the issue template) how about I just close this PR after others agree and you submit a new PR to the helm repository?
I've had a great time discussing with you the last few days and have learned a lot, thanks!

I agree with closing this PR,  I'll try to raise a new PR to the helm repo.
Great thanks for your contribution, I've learned a lot from this topic also, like when worth 100% automation and how to deal with dependencies /independence between repos.


Coding guidelines for pythonic++

Are there any rules? Pythran has a nice PEP8 compliance rule but what about the C++ code?  I mean for instance you don't accept lines >78 char in Python but >160 is not a problem in C++ ?

This has been fixed in ccfb3fbea2baa1837c7cfb3cfc3393c97de9a67d
Using clang-format and its default style.


Check the last few days

As a user I want to be able to check the last days entered.
For example with the command: toggl-tracker check 30 (30 is the interval of days before today)
I would like to see a detailed list of last X days. Each day I would like to see each timeslot with related project I worked.

Feature released. You can run
toggl-tracker check

to show entries on the last N days, where N is equal to the look behind days (it is the same the tool uses in other modes)


core: Added Pagination for Repositories View

signed off by<EMAIL_ADDRESS>Changes that will come into effect by this PR

Pagination will work if the repo count exceeds 10
Eliminated re writing of same (repositories) component twice with common component code
Fix page reload after repo gets created
Added Redhat logo favicon by replacing patternfly one

/lgtm


Managed grafana behind application gateway doesn't work due to bad oauth redirect

We have Azure Managed Grafana with public access disabled. Our user access Grafana through Azure Application Gateway. However, Grafana redirects the users to an oauth2 endpoint, and after login the user is redirected not to the application gateway, but directly to Grafana. Since Grafana is not public, this fails.
To be a bit more precise and technical:

user goes to my-custom-grafana-domain.com, which goes to our application gateway
application gateway forwards the request to Grafana
Grafana responds with a redirect, pointing an url that looks like this: https://login.microsoftonline.com/organizations/oauth2/v2.0/authorize?client_id=[some-client-id]&redirect_uri=https%3A%2F%2Fsso.weu.grafana.azure.com%2Flogin%2Fazuread&state=[our-grafana-endpoint].weu.grafana.azure.com&[some-more-stuff]
User logs in
User gets redirected to [our-grafana-endpoint].weu.grafana.azure.com, which fails because that endpoint is not public

Azure Application Gateway sets the x-forwarded-host request header. This header should be taken into consideration when building the oauth2 redirect. the redirect should look something like this: https://login.microsoftonline.com/organizations/oauth2/v2.0/authorize?client_id=[some-client-id]&redirect_uri=https%3A%2F%2Fsso.weu.grafana.azure.com%2Flogin%2Fazuread&state=[my-custom-grafana-domain.com]&[some-more-stuff]

Hi @JoostLambregts , unfortunately this is what we call the "custom domain name" scenario where you want to use a different DNS name to access Grafana. This is currently not a supported scenario. Even without the redirection problem, the certificate used for TLS on the server side will also not match the custom domain.

That is unfortunate. Thank you for the response.

That's probably true. Supporting custom domain name is not a small feature, we can take it into consideration.

I've run into this issue as well trying to secure public access to the Azure managed instance of Grafana. @brahmnes is there currently any way to implement network access control to the public endpoint? The problem is the private endpoint isn't routable outside of Azure. I don't want full private access, but want to limit the public access to just our VPN network.

Hi @garretwyman , unfortunately I cannot think of a good solution. From a theoretical stand point, you can probably setup something where you put Grafana in private access mode, then you have a VNET that has a private endpoint to it. From that VNET, you setup the appropriate access control, or use Azure VPN Gateway if you want to access from outside of Azure. Having said that, I am not an expert in networking so this is theoretical. You may have to try it yourself.


Add ft for ilike function

What problem does this PR solve?
Issue Number: close #7373
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/merge

/merge


[WIP] Transition to proper headless support on linux.

Signed-off-by: Hal Gentz<EMAIL_ADDRESS>

Waiting on https://github.com/tomaka/winit/pull/829, and for me to write up some docs. Then we'll have a release candidate out!


Running telogator using zebrafish genome

I find this tools interesting and I would like to use it in my zebrafish assembly. How can I generate a telogator.fa for my zebrafish data? I see it is loading human telogator.fa and this could not work well with my data. I look forward to your advise on how to do this.

Greetings! I just added a make_telogator_ref.py script to the repository, which should allow you to make a subtelomere reference that Telogator2 can accept via the -t input option. Example usage:
python make_telogator_ref.py -i input-ref.fa -o output-telogator-ref.fa -s zebrafish
Note that if zebrafish has different telomere repeats (or variant repeats) than human, you might need to make an alternate kmers.tsv file.

Closing this for now, feel free to reopen if you have additional questions.


Maintenance banner: add page in superadmin panel to activate/deactivate banner

Description
See #2315 for details
Proposed solution
Add a page on the superadmin view that enables users to activate or deactivate the banner. This will call the endpoint detailed in #2452. It should allow users to input the severity level and user-facing message.
Additional context
To prevent this from being turned on accidentally, we may want to include a "Reason" section that links to a GH issue, Slack thread, etc.

taking a new direction on the banner, so closing this issue


Ensure that relative paths in edit preview work

Fix #10131
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Needs som linter fixes (semicolons, const).

So that linter has actually done the impossible: it's made dealing with js even more bloody annoying.

@zeripath you should try an editor plugin for eslint, it's very fast.


Delete tests/e2e directory

Description of changes:
The tests/e2e directory is an incorrectly named version of the test/e2e directory. It should be removed so as to not cause confusion for contributors who might not know where tests should be added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/LGTM


Stream

Hi,
it's possible to open image with Stream , because I want use framework in google function to load image in google storage with google api.
Best Regards

Hi,
Could you please provide more details on the issue? What do you mean by "open image with Stream"?
To load an image data coming from other APIs you can use the imaging.Decode function that takes an io.Reader as its first argument. If you're working with the Google Cloud Storage, you can use the NewReader method of the ObjectHandle to get the reader of the object data.
(https://pkg.go.dev/cloud.google.com/go/storage?tab=doc#ObjectHandle.NewReader)

Hi,
I'm looking for something similar. I would like to stream an image from one bucket, resize it and stream it into another bucket. This article explains exactly what I'm trying to achieve.

I'm not very familiar with Google Cloud Storage. Looking at the docs, you can do a similar processing in Go:

Create a new reader of the source image object (https://pkg.go.dev/cloud.google.com/go/storage?tab=doc#ObjectHandle.NewReader)
Create a new writer to the destination image object in another bucket (https://pkg.go.dev/cloud.google.com/go/storage?tab=doc#ObjectHandle.NewWriter)
Use imaging.Decode function to read the image from the reader.
Use imaging.Resize to resize the image.
Use imaging.Encode to write the resized image to the writer.

Closing the issue. Feel free to reopen if you have any further questions.


Little endian assumed

See file https://github.com/CopernicaMarketingSoftware/AMQP-CPP/blob/master/include/amqpcpp/endian.h
Row 66, #define htole16(x) (x)
htole means host to little endian. As this is defined as the identity function, does this mean we assume all systems are little endian..? I mean this is a fair assumption for most servers, but might not be true for things like embedded software.

I have no idea. This endian.h file does not come from us, nor do we use it or rely on it. Is this an issue for you?

Not currently. I'm pointing it out, because it might be an issue in the future.

@surgura  what about the line 63 ?
63: #if BYTE_ORDER == LITTLE_ENDIAN
...
66: #define htole16(x) (x)
...
80: #elif BYTE_ORDER == BIG_ENDIAN
...
84: #define htole16(x) __builtin_bswap16(x)
So, apparently the whole thing is a pre-processor's  if-else statement

Oh I see, I'm blind.


feat: 🎸 支持多版本能力：根据不同路由映射不同的Version版本。

Ⅰ. 支持多版本能力
场景是 在微前端的场景下一个主应用需要管理多个微应用， 实现根据不同路由映射不同的Version前端 版本

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.58%. Comparing base (ef31e09) to head (eeb51ff).
Report is 164 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
+ Coverage   35.91%   43.58%   +7.67%
==========================================
  Files          69       76       +7
  Lines       11576    12320     +744
==========================================
+ Hits         4157     5370    +1213
+ Misses       7104     6616     -488
- Partials      315      334      +19

see 69 files with indirect coverage changes


[Feature] Workflow error handling and sharing data between steps

#8 .. It is one of the many ways to do it.. a bit opinionated here.
It is without proper error logging now, do we want to log to a separate file, or log to the output file itself? (e.g. if pat01-01.txt failed, when I open pat01-01.txt in the output folder, it may contain "this file has failed anonymization" literally as content)?
@RichJackson we don't seem to need ExecutionContext for this?

I'm going to merge this in the name of keeping things moving. A couple of points:

@hkkenneth  - you're right, I don't see the use of an execution context at this stage

usage instructions:
"GATE home", "workspace/sample-input", "workspace/dev-text-output" and "workspace/dev-test-output-2"  needs to be in the same dir as where the application is launched from, other wise you get NPE's


Capture start_worker mechanics in a Proc so we can invoke it later.

Change MiqServer#sync_workers to accept an array of Procs representing added
workers for each worker class sync_workers call.
We can then invoke these "added workers" Procs later in batches with future
hooks before and afterwards:

before fork: preload, close db connections
after fork: reconnect db, etc.

Note, this was extracted from the forking workers PR as it will work as-is with Process.spawn.

cc @Fryguy @matthewd

cc @blomquisg (see per ems mixin change)

@miq-bot add_label wip


Implement how to manage keywords, members

Implement how to manage keywords, members.
Every set members and those informations must be showed at Side-nav.
Every queried keywords and those results must be showed at Side-nav.

#19
This issue closed.


Big schema rewrite

Long overdue schema.py refactor/rewrite. The schema started small, but is now enormous, calling for a more structured approach to parameter entry. A function is created that fills in some of the defaults and creates keys where missing. The use of an entry function ensure better consistency and avoids copy paste bugs that have crept in over time.  In addition, more emphasis is placed on creating common patterns can be used, with for loops working on lists.

I fixed dynamic docs gen in #938. The PR is using this branch as a base, so merging that PR will add the changes to this one.
I noticed that something isn't working right with RST being parsed in help strings, but I can address that in a future PR after this is merged.


[Feature] Add year selector

Inspired by this awesome library

Should be 3 columns (just like month selector)

Fixed in https://github.com/MohamadKh75/react-native-jalali-datepicker/commit/dcf6c3cf2b2641443b711f867b7c907ea46fc596
Added in v1.1.0


Don't re-enable disabled services

Is your feature request related to a problem? Please describe.
Whenever I disable some services using NTLite, this script (or windows itself, not sure) sets some services from Disabled to Manual which is not desired behaviour.
Describe the solution you'd like
An option to not touch disabled services
Describe alternatives you've considered
Additional context

So did this get fixed or not?


Bump chokidar version to allow use on node v4.0

Chokidar 0.x uses a version of fsevents that won't compile on node ^4.0.0. This bumps the version of chokidar used so as to get things up and running.

lgtm :tada:

Thanks @abacon!


why not delegated events?

When using Solid's native handlers such as onClick(), events are delegated. Handlers created in this library do not use delegated events and instead opts for native handlers. That means that if I were to call e.stopPropagation() inside a delegated event, it wold not perform as expected. The native listeners registered by this library would fire first even if they are watching a parent on the child who called e.stopPropagation(). I was able to solve this problem by creating my own makeDelegatedEventListener util.
import { addEventListener, delegateEvents } from "solid-js/web";

export const makeDelegatedEventListener = (
    node: Element,
    name: string,
    callback: (e: any) => void
) => {
    addEventListener(node, name, callback, true);
    delegateEvents([name]);
};

This makes bubbling work as expected. Why does this library not also delegate events or why does it not at least provide an option to? My quick implementation above may have flaws I'm unaware of since I made it by inspecting solid's source code, but at least on the surface it seems to work as I'd expect listeners to work, whereas all listeners created by this library do not.

If you are asking about the reason, then that is the purpose of the event-listener package. To give a reactive interface for adding event listeners to elements. Depending on what you assume the package is doing you might expect different things. If you are looking for a familiar element.addEventListener that gets removed automatically onCleanup then native bubbling is expected.
Nonetheless, having the option to opt into event delegation is an interesting idea.
I'm not sure about the implementation though.
Normally delegateEvents is called immediately so that the events can be captured before the hydration is complete. Calling it asynchronously seems odd, but it works so 🤷♂
Either way, I would probably match the implementation with what assignProp is doing - a function used for applying a dynamic prop at runtime when the compilation couldn't optimize. It's what the Dynamic component will use when assigning props to the HTML element. It means that an event should only be added as delegated if its name is included in the delegated set, otherwise a standard element.addEventListener is used.
If that's doable the question is: should this behavior be the default with an option to opt-out, or the opposite?

Yes I was asking to see if there was a specific reason you chose not to implement this. At least for my use cases, not delegating events makes the library practically unusable. I have components like <Draggable></Draggable> that have no element themselves, and only apply listeners to their children. When a developer uses stopPropagation() lower in the tree under the draggable component, they expect it stop that event from hitting the draggable, but it doesn't, because the draggable component's events aren't delegated. This confused me for quite some time until I learned about Solid's event delegation.
Even when not using wrapper components that assign events to children, I still run into problems where stopPropagation and/or preventDefault don't work as expected. I'm actually confused why lots of other people haven't run into this problem. I'm building a fairly sophisticated 2d editor with panning, dragging, drawing, etc with many things built in html so maybe I'm just the first push solid to it's limits like this? Or maybe I'm making bad decisions in terms of my implementation? I fairly new to the solid ecosystem.
Personally I think it might be wise for event delegation to be opt in for solid as a whole because it causes weird unexpected behavior. That said, even if delegation is opt in for solid, this library still seems like it should support delegation.
I'd be happy to implement this if we can agree on a solution and it's not too difficult for me to understand the solid primitives codebase.


external reader plugins do not work in browser with numOfWorkers > 0

Test runner in quagga2-reader-qr, when numOfWorkers > 0:

Something in regards to external readers is not getting passed onto workers properly.

closing in favor of all-encompassing issue


support dictproxy views Fixes #295

@benjaminp I think this fixes the issues with my previous attempt

@benjaminp any thoughts on this?

https://github.com/benjaminp/six/issues/295

@benjaminp any thoughts on this?

Thank you for the PR. As I said in https://github.com/benjaminp/six/pull/296#issuecomment-546179264, I don't want to complicate view* for this, especially since there's no way to view dict proxy's on Python 2.

Thank you for the PR. As I said in #296 (comment), I don't want to complicate view* for this, especially since there's no way to view dict proxy's on Python 2.

But it does work for dictproxy, you just use the collections.*View

Sorry, I meant a method on the type.

I'd like you to reconsider, because it makes it much easier to use six.viewitems everywhere it would also be supported in Py3 and much easier to produce safe automated transforms when upgrading a py2 codebase to py3

I'd like you to reconsider,

I've already considered it twice.

because it makes it much easier to use six.viewitems everywhere it would also be supported in Py3 (eg class Foo(object): ...; six.viewitems(vars(Foo)) and much easier to produce safe automated transforms when upgrading a py2 codebase to py3

What automated transform? If the Python 2 code is doing something.viewitems(), then it already doesn't work it dict proxies. If it's doing something.iteritems(), six.iteritems(something) will work fine.


Investigate 6.0 SDK diff: unnecessary runtime/ folders

Files like ./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/browser/lib/net6.0/System.Text.Encodings.Web.dll show up in the source-built SDK but not the Microsoft-built SDK. They are most likely not interfering with any functionality, but we should figure out why they're showing up, and ideally fix this diff.
https://github.com/dagood/source-build/pull/9#discussion_r734899321

I see the opposite in 8.0 SDK diff. The following files are only present in Microsoft-built SDK:
sdk/8.0.100-preview.6.23309.1/DotnetTools/dotnet-format/runtimes/unix/lib/net6.0/System.Drawing.Common.dll
sdk/8.0.100-preview.6.23309.1/DotnetTools/dotnet-format/runtimes/win/lib/net6.0/Microsoft.Win32.SystemEvents.dll
sdk/8.0.100-preview.6.23309.1/DotnetTools/dotnet-format/runtimes/win/lib/net6.0/System.Drawing.Common.dll
sdk/8.0.100-preview.6.23309.1/DotnetTools/dotnet-format/runtimes/win/lib/net6.0/System.Security.Cryptography.ProtectedData.dll
sdk/8.0.100-preview.6.23309.1/DotnetTools/dotnet-format/runtimes/win/lib/net6.0/System.Windows.Extensions.dll

@MichaelSimons I presume the fix is needed in 8.0 SDK only - or are we considering backporting all changes to older, still-supported source-built SDKs?

8.0 only, we are not backporting these changes.
The 8.0 diff is more logical - System.Drawing.Common.dll, Microsoft.Win32.SystemEvents.dll, and System.Windows.Extensions.dll are windows only assemblies.  System.Security.Cryptography.ProtectedData.dll is unknown though.  Is that a transitive dependency?

8.0 only, we are not backporting these changes.
The 8.0 diff is more logical - System.Drawing.Common.dll, Microsoft.Win32.SystemEvents.dll, and System.Windows.Extensions.dll are windows only assemblies. System.Security.Cryptography.ProtectedData.dll is unknown though. Is that a transitive dependency?

Yes, it is transitive, via System.Configuration.ConfigurationManager. But, also it seems to be used on Windows platforms only - here's the relevant part in deps.json file:
      "System.Security.Cryptography.ProtectedData/6.0.0": {
        "runtime": {
          "lib/net6.0/System.Security.Cryptography.ProtectedData.dll": {
            "assemblyVersion": "<IP_ADDRESS>",
            "fileVersion": "<IP_ADDRESS>210"
          }
        },
        "runtimeTargets": {
          "runtimes/win/lib/net6.0/System.Security.Cryptography.ProtectedData.dll": {
            "rid": "win",
            "assetType": "runtime",
            "assemblyVersion": "<IP_ADDRESS>",
            "fileVersion": "<IP_ADDRESS>210"
          }
        }
      },


Drawer

Do you have any sample with react-navigation-drawer?

@raphcadiz not yet, but good suggestion. I'll just put this in my backlog.

hi @codingki any updates for this feature. I'd really love to see how the drawer works on the app. thanks


Add LootableContainerBlockEntity#getInvStackList :)

I can't find the commit this mapping was removed, but it seemed to have been a thing in the past.
Either way this pr adds back mappings for the getter :)

The build failed, its conflicting with getHeldStacks, run the mapNamedJar task or see the build output.

Converted to draft as their is a conflict that first needs to be resolved.


Call to an undefined method withTrashed - SoftDeletes

$project = $task->project()->withTrashed()->first();

Produce:

Call to an undefined method Illuminate\Database\Eloquent\Relations\BelongsTo::withTrashed().

@antonkomarev Thanks for reporting this issue.
I need to think in a solution for this. Since those methods withTrashed, etc are local instance macros instead of global macros.
Give me some time to think.

Some news? Thanks

I am in holidays. I will be back on the 27 August.
On Tue 31 Jul 2018 at 10:26, Eric Lagarda<EMAIL_ADDRESS>wrote:

Some news? Thanks
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/nunomaduro/larastan/issues/40#issuecomment-409156377,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFNFVFA7kI9iWndLeqtTyHexj3ActBs_ks5uMCK6gaJpZM4VWcoy
.

@nunomaduro Hahaha enjoy then 👌🏽

@nunomaduro Could you investigate this one?

+1, we're also constantly running into this one

@nunomaduro Do you have a theoretical plan for this?

Any workaround?

Just added support to soft deletes v0.3.3. Can you folks run some tests?

Yes.
  - Updating nunomaduro/larastan (v0.2.12 => v0.3.3): Loading from cache

@szepeviktor Perform a composer clear and re-run composer update.

You should test with the version v0.3.4.

:) Gone!
Only onlyTrashed() remained "undefined".

@szepeviktor I don't understood your feedback about Only onlyTrashed() remained "undefined"..

namespace Illuminate\Database\Eloquent;

class SoftDeletingScope implements Scope
{
    /**
     * All of the extensions to be added to the builder.
     *
     * @var array
     */
    protected $extensions = ['Restore', 'WithTrashed', 'WithoutTrashed', 'OnlyTrashed'];

 ------ ---------------------------------------------------------------------------------
  Line   app/Models/Artwork.php
 ------ ---------------------------------------------------------------------------------
  94     Call to an undefined method Illuminate\Database\Eloquent\Model::translations().
 ------ ---------------------------------------------------------------------------------

@szepeviktor That's another issue. Should be the code that you have on the app/Http/Filters/OwnerFilter.php near the line 53.

The static call errors are gone. But I can't use withTrashed() on a Builder yet. Any workaround?
 ------ -------------------------------------------------------------------------------
  Line   app/Models/Lead.php
 ------ -------------------------------------------------------------------------------
  148    Call to an undefined method Illuminate\Database\Query\Builder::withTrashed().
 ------ -------------------------------------------------------------------------------

@gpressutto5 That's another issue. Should be the code that you have on the  app/Models/Lead.php near the line 148.

@nunomaduro whereNotNull returns Buider|static. That's the code:
/**
 * @param Builder $query
 *
 * @return Builder
 */
public function scopeLost(Builder $query): Builder
{
    return $query->whereNotNull('column')->withTrashed();
}

I've changed $query type to Lead, like this:
/**
 * @param Lead $query
 *
 * @return Builder
 */
public function scopeLost(Lead $query): Builder
{
    return $query->whereNotNull('column')->withTrashed();
}

Now PhpStorm knows this method does exists:

But I still get that error:
 ------ -------------------------------------------------------------------------------
  Line   app/Models/Lead.php
 ------ -------------------------------------------------------------------------------
  148    Call to an undefined method Illuminate\Database\Query\Builder::withTrashed().
 ------ -------------------------------------------------------------------------------

class OwnerFilter extends Filter

...

    /**
     * Filter only the trashed exhibitions.
     *
     * @param  bool|string  $value
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function trashed($value = false)
    {
        return  $value == 'true' ? $this->builder->onlyTrashed() : $this->builder;
    }

@nunomaduro Very nice job. Thank you.
Larastan knows almost 100% of Laravel.

@nunomaduro So $this->builder->onlyTrashed() in the above code should return \Illuminate\Database\Eloquent\Model ?

@nunomaduro As far I see the problem is that onlyTrashed is called on $this->builder which is a \Illuminate\Database\Eloquent\Builder - so changing the return type seems not to have anything to do with it.
Please advise.

I'm also having issues with withTrashed(), I'm getting the following error:
------ ----------------------------------------------------------------------------
  Line   app/Console/Commands/ImportRecipientsCommand.php
 ------ ----------------------------------------------------------------------------
  114    Call to an undefined method Illuminate\Database\Eloquent\Model::restore().
 ------ ----------------------------------------------------------------------------

Here's my code:
Recipient::withTrashed()->updateOrCreate([
    // Discriminating fields
], [
    // Fields to update
])->restore();

I'm using the latest Larastan v.0.3.4

Call to an undefined method Illuminate\Database\Eloquent\Model::restore().

This shows that updateOrCreate() is not saying what it returns!

I am getting the same error.
Call to an undefined method Illuminate\Database\Eloquent\Relations\BelongsTo::withTrashed().
/**
     * An event belongs to a venue.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function venue()
    {
        return $this->belongsTo(Venue::class)->withTrashed();
    }

I am seeing this error using larastan v0.3.13

@JeffreyDavidson @Turtle1363 Can you open a new issue with your snippets of code?

This issue seems be fixed since laravel/framework PR acceptd
https://github.com/laravel/framework/pull/28352

Yes.
I hope everyone agrees.

I am getting the same error.

Call to an undefined method Illuminate\Database\Eloquent\Relations\BelongsTo::withTrashed().

    /**
     * An event belongs to a venue.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function venue()
    {
        return $this->belongsTo(Venue::class)->withTrashed();
    }

Same here using default SoftDeletes trait on Laravel v5.8.34. Can these errors be resolved somehow?

same error herer

Laravel v5.8.35

  82     Call to an undefined method Illuminate\Database\Eloquent\Builder::onlyTrashed().

the code is
    public static function cleanUp(Builder $query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

same error here

Laravel v5.8.35

  82     Call to an undefined method Illuminate\Database\Eloquent\Builder::onlyTrashed().

the code is
    public static function cleanUp(Builder $query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

Is the Model you referenced by the cleanUp, used the SoftDeletes trait?

same error here

Laravel v5.8.35

  82     Call to an undefined method Illuminate\Database\Eloquent\Builder::onlyTrashed().

the code is
    public static function cleanUp(Builder $query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

Is the Model you referenced by the cleanUp, used the SoftDeletes trait?

yes

same error here

Laravel v5.8.35

  82     Call to an undefined method Illuminate\Database\Eloquent\Builder::onlyTrashed().

the code is
    public static function cleanUp(Builder $query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

Is the Model you referenced by the cleanUp, used the SoftDeletes trait?

yes

function cleanUp(Builder $query)

Typehint in your code caused this issue. please try this way instead:
    /**
     * @param Builder|\Illuminate\Database\Eloquent\SoftDeletes $query 查询对象
     */
    public static function cleanUp($query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

     * @param Builder|\Illuminate\Database\Eloquent\SoftDeletes $query 查询对象

thanks for response.
it occurred another error
  80     Parameter $query of method App\YouzanPush::cleanUp() has invalid typehint type Illuminate\Database\Eloquent\SoftDeletes.

     * @param Builder|\Illuminate\Database\Eloquent\SoftDeletes $query 查询对象
     */
    public static function cleanUp($query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

Trait cannot be a parameter typehint.
On Wed, 18 Sep 2019 at 03:05, Bole Chen<EMAIL_ADDRESS>wrote:

 * @param Builder|\Illuminate\Database\Eloquent\SoftDeletes $query 查询对象

thanks for response.
it occurred another error
80     Parameter $query of method App\YouzanPush::cleanUp() has invalid typehint type Illuminate\Database\Eloquent\SoftDeletes.
 * @param Builder|\Illuminate\Database\Eloquent\SoftDeletes $query 查询对象
 */
public static function cleanUp($query): Builder
{
    return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nunomaduro/larastan/issues/40?email_source=notifications&email_token=AAAZTOCOOYTXNN72WEWCH6LQKF5GVA5CNFSM4FKZZIZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66OXSA#issuecomment-532474824,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAZTOHFGFIMF4BQNTGP473QKF5GVANCNFSM4FKZZIZA
.

--
Ondřej Mirtes

@ondrejmirtes Okay. I see.
@bolechen Please try this instead
    /**
     * @param Builder|\App\YourModel $query 查询对象
     */
    public static function cleanUp($query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

Remember to place real model class for the \App\YourModel.

@ondrejmirtes Okay. I see.
@bolechen Please try this instead
    /**
     * @param Builder|\App\YourModel $query 查询对象
     */
    public static function cleanUp($query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

Remember to place real model class for the \App\YourModel.

     * @param Builder|\App\YouzanPush $query
     */
    public static function cleanUp($query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

the error is

82     Method App\YouzanPush::cleanUp() should return Illuminate\Database\Eloquent\Builder but returns App\YouzanPush.

@ondrejmirtes Okay. I see.
@bolechen Please try this instead
    /**
     * @param Builder|\App\YourModel $query 查询对象
     */
    public static function cleanUp($query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

Remember to place real model class for the \App\YourModel.

     * @param Builder|\App\YouzanPush $query
     */
    public static function cleanUp($query): Builder
    {
        return $query->onlyTrashed()->where('deleted_at', '<', Carbon::now()->subMonth());
    }

the error is

82     Method App\YouzanPush::cleanUp() should return Illuminate\Database\Eloquent\Builder but returns App\YouzanPush.

Now you need to update your codes which calling the App\YouzanPush::cleanUp(), their return annotations, to be type Builder|\App\YourModel

Guys I found the answer for me, I had the same issue because I changed __construct() method in my model, but forgot to put parent::__construct();


API: Add empty hints for SynSignalWithRegistry.

This makes BestEffortCallback work until LiveTable can be fixed.

Have been using
@property
def hints(self):
    if self._hints is None:
         return {'fields': []}
    return self._hints

@hints.setter
def hints(self, val):
    self._hints = dict(val)

on many of the objects that have a default hints.

I see. That approach makes it easier to revert to the default after making some change. Force-pushed.

Is there already a default value for self._hints in the init?

Oof! No. Fixed and force-pushed. Ran Tim's bug report script against this. Indeed it fails on my previous commit but now works.


Instmap with default values

Summary
This PR allows the instmap to take a parametrized schedule and schedule block with default parameter values. This means one can .get schedule as in the previous, but also override parameter values. This feature may eventually help fine tuning of the backend calibrated pulses, without ugly hack of pulse entries.
Details and comments
Currently:
sx_sched = instmap.get("sx", (0,))
play_sx = sx_sched.instructions[0][1]
pulse_params = play_sx.pulse.parameters

# fine tuning
pulse_params["amp"] = 0.25

new_sx = Schedule()
new_sx += pulse.Play(type(play_sx.pulse)(**pulse_params), pulse.DriveChannel(0))

With this PR:
sx_sched = instmap.get("sx", (0,), amp=0.25)

Note that we need to update below logic to enable above code, because currently backend calibrated schedules are added with the hard-coded parameter values. We need to create fully parametrized schedule, and add the schedule with arguments with default values. This will be a separate PR if needed, since we need to solve scope issue to distinguish parameters in a composite pulse schedule, i.e. CX schedule has multiple pulses.
https://github.com/Qiskit/qiskit-terra/blob/2d8fe45e811b124ac5a4f712c066ac63acc43eb8/qiskit/providers/models/pulsedefaults.py#L206-L208

This seems like a good simplification. I wonder if it would be worth adding the modification methods to Schedule since they may be generally useful.  This might also make it easier to address the issue of composite pulses you mention and, for instance, allow a get operation such that one could do something like,
sx_sched = instmap.get("sx", (0,)).set({amp: 0.25})

Thanks Eric, that is another possible extension to the schedule. However, this needs a major refactoring of program representation. Currently in the Schedule the parameters become expression once a value is assigned. This means we need to separately manage parameters and values, and one possible solution is what we have done in the Call instruction. However, this makes the logic complicated and perhaps we may want to upgrade Parameter rather than handling the logic in each program.
In the instmap, a program (i.e. Schedule) and signature (i.e. Parameter) are separately managed by using the inspect module. So the implementation is much easier.

This looks like it has fairly significant conflicts nowadays.  With the new pulse work in progress, should we close this PR as stale/obsolete?

Given no response, I'll close this PR as staled, but feel free to re-open if there's more to do.


Missing build in the CI workflow file

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal
I would like to see a build job that does only a production build: npm run build.
And I would rename the current "build" to "test": https://github.com/fastify/demo/blob/main/.github/workflows/ci.yml#L19
Motivation
Missing a CI/CD build.. And what you called build today, is actually a test.
Example
No response

PR created: https://github.com/fastify/demo/pull/41

Thanks @melroy89!


How can we measure exact AC current in Amps

Hi,
I went over your source code and readme, I am using ACS712 with AC50Hz, 15A , with ESP32,  how can I measure amount of current flowing in the circuit.
Also if there is no power, what should be the expected value from :mA_AC()

check - https://create.arduino.cc/projecthub/instrumentation-system/acs712-current-sensor-87b4a6
it is not with my library but explains how it is done,

Note, it is never exact, but the test results so far are pretty close to a professional Brymen multimeter.
PS, there is a bug fix pending, so either use the develop branch or the 0.3.0 version.
(will be merged later today)

If there is no current you should get 0 plus maybe some noise (see datasheet).
One way to test that is to disconnect the current wires, so the ADC should measure the midpoint (around 0).
You can calibrate then by calling autoMidPoint().
If that does not work, your sensor may be broken.
As I dont know your hardware setup I can only guess.
As this seems not a library issue you better ask help on the Arduino forum.

FYI,
I'm merging the bug fix within an hour or so into a new release 0.3.2

As this issue is not a library issue I close it. Feel free to reopen it if the problem is in the library.


Dashboard package structure

[x]  Code structure
[x] Component list
[x] API to read/write settings
[x]  Forms (autosave or submit button)
[ ] API to control UI

I think only "API to control UI" is left to close this, @luisherranz can you expand what that implies?

It's done so this can be closed