Persistent volume claim stays in Pending

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Install rancher 2.2.3.rc6 with rke and helm.
Create a new cluster by using a vSphere cloud provider**

cloud_provider:
  name: "vsphere"
  vsphereCloudProvider:
    global:
      insecure-flag: true
      soap-roundtrip-count: 0
    virtual_center:
      <vs_server_ip>:
        datacenters: "<our_datacenter>"
        soap-roundtrip-count: 0
        user: "<our_vs_user>"
    workspace:
      datacenter: "Jena"
      default-datastore: "<our_datastore>"
      folder: "<our_vs_folder>" (on cluster creation relative but afterwards full path because folder was not found for storageclass)
      server: "<vs_server_ip>"

Cluster is created fine
> kubectl get nodes
NAME       STATUS   ROLES                      AGE   VERSION
jengr2-1   Ready    controlplane,etcd,worker   28h   v1.13.5
jengr2-2   Ready    controlplane,etcd,worker   28h   v1.13.5
jengr2-3   Ready    controlplane,etcd,worker   28h   v1.13.5

Create a storage class for vSphere in the new cluster**

{
"allowVolumeExpansion": false,
"annotations": { },
"baseType": "storageClass",
"created": "2019-05-17T12:37:32Z",
"createdTS":<PHONE_NUMBER>000,
"creatorId": "user-7sbnp",
"id": "mystorage3",
"labels": {
"cattle.io/creator": "norman"
},
"links": {
"persistentVolumes": "…/v3/cluster/c-xzbqc/persistentVolumes?storageClassId=mystorage3",
"remove": "…/v3/cluster/c-xzbqc/storageClasses/mystorage3",
"self": "…/v3/cluster/c-xzbqc/storageClasses/mystorage3",
"update": "…/v3/cluster/c-xzbqc/storageClasses/mystorage3"
},
"name": "mystorage3",
"parameters": {
"diskformat": "thin"
},
"provisioner": "kubernetes.io/vsphere-volume",
"reclaimPolicy": "Delete",
"type": "storageClass",
"uuid": "8a6a43a5-78a0-11e9-906c-0050568a1d51",
"volumeBindingMode": "Immediate"
}

Create a workload with a persistent volume claim**

> kubectl describe pvc myvolume3
Name:          myvolume3
Namespace:     default
StorageClass:  mystorage3
Status:        Pending
Volume:
Labels:        cattle.io/creator=norman
Annotations:   field.cattle.io/creatorId: user-7sbnp
               volume.beta.kubernetes.io/storage-provisioner: kubernetes.io/vsphere-volume
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:
Access Modes:
VolumeMode:    Filesystem
Events:        <none>
Mounted By:    myapp-7547484c65-fh9vq

Result:
The volume claim stays "Pending" while the volume was created in vSphere. The storage claim doesn't show any event.
Environment information

rke v0.2.2
helm v2.13.1
rancher 2.2.3-rc6
HA
NodeTemplate-Iso_Url: https://releases.rancher.com/os/latest/rancheros-vmware.iso

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compil
er:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.5", GitCommit:"2166946f41b36dea2c4626f90a77706f426cdea2", GitTreeState:"clean", BuildDate:"2019-03-25T15:19:22Z", GoVersion:"go1.11.5", Compil
er:"gc", Platform:"linux/amd64"}

We run into this one: https://github.com/vmware/govmomi/issues/1391

I'm having this same behavior.
I created a new cluster with vSphere Cloud Provider configured in cluster YAML like so:
cloud_provider:
  name: "vsphere"
  vsphereCloudProvider:
    global:
      insecure-flag: true
      soap-roundtrip-count: 0
    virtual_center:
      <IP_ADDRESS>:
        datacenters: "Suassuna"
        password: "password"
        soap-roundtrip-count: 0
        user: "domain\\username"
    workspace:
      datacenter: "Suassuna"
      default-datastore: "/Suassuna/datastore/vDisk"
      folder: "/kubernetes"
      server: "<IP_ADDRESS>"

Then I created a StorageClass of provisioner type as VMWare vSphere Volume and Thin disk format.
When I try to create a Volume Claim, it's still in Pending state.
Here is the kube-controller-manager log:
I0730 20:02:19.181924       1 vsphere_volume.go:366] Provision with allowedTopologies : []
I0730 20:02:19.181977       1 vsphere.go:1165] Starting to create a vSphere volume with volumeOptions: &{CapacityKB:2097152 Tags:map[kubernetes.io/created-for/pv/name:pvc-f83ff13c-b300-11e9-9051-0050569e6828 kubernetes.io/created-for/pvc/name:test kubernetes.io/created-for/pvc/namespace:default] Name:kubernetes-dynamic-pvc-f83ff13c-b300-11e9-9051-0050569e6828 DiskFormat:thin Datastore: VSANStorageProfileData: StoragePolicyName: StoragePolicyID: SCSIControllerType: Zone:[]}
E0730 20:02:24.227896       1 connection.go:65] Failed to create govmomi client. err: ServerFaultCode: Cannot complete login due to an incorrect user name or password.
E0730 20:02:24.227954       1 nodemanager.go:390] Cannot connect to vCenter with err: ServerFaultCode: Cannot complete login due to an incorrect user name or password.
E0730 20:02:24.227981       1 vsphere.go:616] failed connecting to vcServer "<IP_ADDRESS>" with error ServerFaultCode: Cannot complete login due to an incorrect user name or password.
I0730 20:02:24.228058       1 pv_controller.go:1492] failed to provision volume for claim "default/test" with StorageClass "vsphere-volume-thin": ServerFaultCode: Cannot complete login due to an incorrect user name or password.
E0730 20:02:24.228261       1 goroutinemap.go:150] Operation for "provision-default/test[f83ff13c-b300-11e9-9051-0050569e6828]" failed. No retries permitted until 2019-07-30 20:04:26.228222073 +0000 UTC m=+2934.141549618 (durationBeforeRetry 2m2s). Error: "ServerFaultCode: Cannot complete login due to an incorrect user name or password."
I0730 20:02:24.228335       1 event.go:209] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"default", Name:"test", UID:"f83ff13c-b300-11e9-9051-0050569e6828", APIVersion:"v1", ResourceVersion:"3011", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' Failed to provision volume with StorageClass "vsphere-volume-thin": ServerFaultCode: Cannot complete login due to an incorrect user name or password.

I tried to change domain\username to domain\username and password with and without quotes, but without success...

Did you try to login directly to vsphere with your credentials? We had this too in the past and then notices that the username is an email.

Yes, I tried. This username in the format "domain\user" is working fine with govc cli.


Implement GetHashCode and Equals in terms of the type hierarchy

Extending some of the ideas from #271, calendar components should delegate to their parents the hashing and equality-checking for the properties that their parent types own, and simplify down to the properties that the child type owns.
For example, Event does its own thing, even though there is a type hierarchy above it that it completely ignores. It should probably use the type hierarchy instead. This way, bugfixes and feature enhancements will propagate to the other child types as well.
This may require spending some time understanding the relationship between UniqueComponent and RecurringComponent, and moving some of the hashing and equality logic to other places.

C.f. #393


How to run mongo command?

How to run mongo command?
I want create user in mongo command line.
THX!

mongo client was not included in the image. It has now been added.
To launch the client you can use docker exec -it mongodb mongo or link the container to a client container, docker run -it --rm --link mongodb:mongo sameersbn/mongodb mongo -h mongo


Different Serverless Transform engine

Evaluate if this would be a better way to translate transforms instead of doing it ourselves.
https://github.com/awslabs/serverless-application-model/tree/develop/samtranslator

Current custom transform is pretty complex and returning errors, using an external one that is really good at this might be a good idea (So we can focus on linting instead of transforming).

Just ran in this:
E3006 Resources ServerlessApi{'Ref': 'Environment'}Stage has invalid name.  Name has to be alphanumeric.

Released with v0.3.0


How to add xcassets directory?

Hey, how I can add xcassets to the project?

So it should be included for your target automatically if its in the folder named after your target but you can make sure its included by making sure it matches the pattern specified for include_files
Project.new do |c|
    c.application_for :ios, 8.0 do |t|
         t.name = "MyApp"
         t.include_files = "./myfiles/*.{c,swift,m,mm,xcassets}"
    end
end

I hope this makes sense :) If it fails to include it properly then let me know, I've done some tidying up in that area :) should be an easy fix if it doesn't.

It's adding xcassets, but in form of regular folder, so XCode can't recognise it.

Ah okay. I have a fix for this, I'll push it up tommorow.

Thanks!

@sergeyzenchenko  Just pushed up a fix into master, please give it a try :)

Works now! Thanks!


Linux and Macbuilds are broken

Until this PR got released into NPM Universe: https://github.com/electron/forge/pull/3592

Probably another bug is causing this :see_no_evil:
https://github.com/jprichardson/node-fs-extra/issues/1027

Quick workaround - patched

https://www.npmjs.com/package/@mistweaverco/electron-forge-plugin-vite to use a patched fs-extra
https://www.npmjs.com/package/@mistweaverco/fs-extra


Named parameters.

Fixes #52.

Add "fixes #52" to the description

Actually, this is wrong, let me take a second look.

PTAL. Gross hacks have been committed.

@vsavkin @vicb FYI.

LGTM


dropdown list widget: Add support for options to have special display logic when selected

In https://github.com/zulip/zulip/pull/25133, the compose box dropdown list widget has a "Direct Message" option is intended to be displayed as "DM" (with an icon) when selected for brevity, but "Direct Message" (with an icon) in the menu for clarity.
Right now, that's implemented as a hack that just replaces what's displayed in a hook that runs every time the value changes; we should add a native hook to the dropdown list widget API to support this.
This is probably not particularly accessible to new contributors, in that most of the work will be reading web/src/dropdown_list_widget.js and figuring out the right way to add such a hook that feels appropriate; I'm not sure at all what API makes sense here and the project is to think about that and make a good proposal.

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

Closing as the dropdown_list_widget component was replaced by a dropdown_widget component that supports this feature.


⚠ Bofrost.de has degraded performance

In 4c60539, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1491 ms

Resolved: Bofrost.de performance has improved in 8b427c7 after 6 minutes.


Lint PowerShell and bash scripts.

We can look into https://www.shellcheck.net and https://github.com/PowerShell/PSScriptAnalyzer.
These should be added to pre-commit and into the lint workflow.

PSScriptAnalyzer cannot be added into pre-commit until its rewritten https://github.com/PowerShell/PSScriptAnalyzer/issues/1528


Iss24 - accounts model with students relation

Screencast: http://www.screencast.com/t/wbV7trwGIy
Addresses #24

post, get, put, and validation tests in jasmine
configures mongodb "fullstack" database
removed parse in middleware.json to run test
configure model with name, account_type

It is looking pretty good so far. You'll want to have a test for delete and for requiring account_type.

It looks like you made a lot of changes to the gulp file.
How should I run the tests?
This didn't seem to return much output:
$ gulp test:api
[gulp] Using gulpfile /home/trey/repos/project/gulpfile.js
[gulp] Starting 'test:api'...
running api tests

And this failed (it looks like a bug in the gulp code:
[gulp] Using gulpfile /home/trey/repos/project/gulpfile.js
[gulp] Starting 'test:integration'...
running integration tests
[gulp] 'test:integration' errored after 3.79 ms casperJs is not defined

/home/trey/repos/project/node_modules/gulp/node_modules/orchestrator/index.js:153
                        throw err;
                              ^
ReferenceError: casperJs is not defined
    at Gulp.gulp.task.tests (/home/trey/repos/project/gulpfile.js:17:10)
    at module.exports (/home/trey/repos/project/node_modules/gulp/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/home/trey/repos/project/node_modules/gulp/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/home/trey/repos/project/node_modules/gulp/node_modules/orchestrator/index.js:214:10)
    at Gulp.Orchestrator.start (/home/trey/repos/project/node_modules/gulp/node_modules/orchestrator/index.js:134:8)
    at /usr/local/lib/node_modules/gulp/bin/gulp.js:77:20
    at process._tickCallback (node.js:442:13)
    at Function.Module.runMain (module.js:499:11)
    at startup (node.js:119:16)
    at node.js:929:3

It looks like you have a separate task for running integration tests just on Windows.  I think these should be made into the same task if possible.

@jeffreytu That win32 check does seem like an improvement at least.  The previous error is resolved and the test runner actually runs now.
Many tests are failing for me currently.  I haven't investigated what's going on here:
[13:05:54] gulp-casper-js: FAIL 34 tests executed in 3.861s, 25 passed, 9 failed, 1 dubious, 0 skipped.

I am able to get my casper test jeff-aboutus.spec.js to pass. I assume the other tests failing are everyone else's due to changing some of names of the html files from issue #33 .

Ready for code review.

Merges in master, #32 and #47
Integration tests pass
API test passes

Other than some lint errors, all tests passed. We need two students to review this pull request so we can merge it. Here's what you do:

Pull down the iss24 branch into your local repo.
Run npm install
Run gulp test:all
Review the results of the test.

For this round of pull requests, having lint errors is ok. In the future, all tests need to be need to be passing before we merge a pr.

Reviewed and except for the JShint errors, all the casper and api tests do pass. It also briefly opened up karma on the browser, but closed it immediately.

i had reviewed this previously as i used it as an example.  It is fine fore me

Does this pull request include the changes from #35 and #50 also?

let me check it may not

Yes. #35 and #50 pull requests refer to issue #32 and #47 respectively.

:+1:

Changes Unknown when pulling 02ec4b15330ca900c19ca1ee125ccb6ccfeee6f7 on iss24 into ** on master**.


Fix bug field index part handler

Fixes #8293
Add this check to correct NullReferenceExceptionin create new item

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ElenaRepository sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[SIL] Fix use-after-free in SILFunction::print.

Fix use-after-free in helper function printSILFunctionNameAndType.
The address of a DenseMap local variable was used after the function returned.
Resolves SR-12239.

@swift-ci Please smoke test

Could you briefly describe your debugging process/how you got the reduced test case? Did you use ASan [or run into any troubles using ASan]?

I followed reproducer instructions at SR-12239 and manually reduced the reproducer to a single file. I just used print debugging. The code was familiar to me since I wrote it - sorry for introducing the bug!
I actually haven't used ASan before.

I'm not sure how exactly to address https://github.com/apple/swift/pull/29949#discussion_r382200170: making the added test an ASAN test.
I'll merge this PR now to unblock progress, since I ran into SR-12239 independently. Happy to address feedback later.


small documentation fix in enumeration examples

Reference Issue

Small documentation fix
What does this implement/fix? Explain your changes.
The library enumeration had some example code available here https://www.rdkit.org/docs/source/rdkit.Chem.rdChemReactions.html which is wrong for this part :
for result in library:    for results_for_product_template in products:    for mol in results_for_product_template:    Chem.MolToSmiles(mol) # finally have a molecule!
result should be products
Any other comments?

@pschmidtke Thanks again!


[stdlib] fix prototype declaration in RuntimeShims.h

_swift_stdlib_getHardwareConcurrency's declaration isn't a proper prototype: it's missing void inside the brackets.
Found while compiling the stdlib to WebAssembly, which fails with:
Functions with 'no-prototype' attribute must take varargs: _swift_stdlib_getHardwareConcurrency
This shouldn't impact existing platforms.

Thanks!
@swift-ci please smoke test and merge


Add ColorTemperatureLightingCommand

Proposal: Extending LightingCommand to allow colour temperature to be set as well.
ColorTemperatureLightingCommand extends LightingCommand.
Units would generally be in Kelvin. Mirek/mired seems to be missing from qudt, but would be desirable as well.
Not sure if this change would necessitate adding BrightnessLightingCommand? Is it ok for the super class to have a specific meaning if there are sub classes? What's the norm in Brick?
Happy to follow up with a PR if this is reasonable?

Hey @nikosandronikos - I had a similar comment on the open pull request

Hi all,
Thanks for brining that up. I do have the need for color temperature as well and was about to file a PR for that. Lighting_Command presumed to change the light level not the temperature. It'd be nicer to be more explicit of course. I will create a separate PR including those two points.

@jbkoh just wanted to bump up this issue in your long queue of things to look at!

Thanks for the reminder. Will work on it tomorrow.

Closing this and continue discussing at https://github.com/BrickSchema/Brick/pull/459


Support Logger and Options for Custom Logger

Support default logger and options for custom logger.
FYI: https://github.com/apache/pulsar/pull/1827

hi!
I played out with the code to see if I can implement something for it.
and I am ready for making a PR.
I was thinking about something like the go client -
var client = new Pulsar.Client({
  log: function(level /* typescript enum */, file, line, message) {
    // do what you think
  }
})

What do you think?

Managed to figure the issues and this works.
Will make a PR soon.

Closed by https://github.com/apache/pulsar-client-node/pull/82


Add Issue Creation

This adds a method for creating a new issue based upon a template specified in the config argument. The first line of the template creates the issue title, and the subsequent content makes up the body of the issue.
Example:
Where the following line is added to probot.js:

on('issues.closed')
.create(contents("IssueTemplate.md"));

And where IssueTemplate.md is:

New Issue Title
Here is my test issue template

[ ] Issue Checklist

The resulting issue is created:

Todo:

[x] Add testing
[x] This may be better if refactored to take two arguments in configuration: one for the Title and one for the Body. I had originally tried to pass these in as a JSON object, but I was having trouble getting the body content to resolve properly with handlebars. Pending further conversation, I think I'd like to revisit this approach.

@migarjo this is looking good. Let me know when you're happy with it and I'll merge it.

@bkeepers, I just added support for passing in labels and assignees as arrays on the JSON object, as well as a test to ensure proper handling of it. I'm satisfied with it if you are at this point. Thanks!

Looks great!
One more ask…can you add createIssue to the docs?

✔  Add documentation
I also noticed that the contents method wasn't in the documentation, so I took the liberty to add that as well, especially since it's likely to be relevant in any use of createIssue.

This looks handy! Looking forward to trying this out.


Added paper: Scaling up search engine audits: Practical insights for algorithm auditing

I am currently contributing to a web browser extension that enables audits of search engines (Google, DuckDuckGo, Baidu, Yandex,…) using virtual agents to simulate browsing behavior. It would be great if you could add it to the list!
This pull request also fixes the link to #related-events in the content section of the readme.

Looks great, and thanks for the patch !


metrics: add some metrics for snapshot-v2

Signed-off-by: bufferflies<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: ref ##12842
What's Changed:

1. add snapshot size metrics
2. add snapshot send/recv count metrics

Related changes
Check List
Tests

Manual test (add detailed scripts or steps below)

Side effects
Release note

None

/cc @tonyxuqqi @BusyJay

/ping @BusyJay

/run-all-test

/rebuild

/merge


Enable pending update_checker_spec tests

Fixes #5

We'll need to fix the branching I think :)
Currently there's add-cococapods and add-cococapods-RP. The latter contains all changes & fixes and is quite far ahead of add-cococapods. Should we merge add-cocoapods-RP into add-cocoapods?

@RuudPuts I merged add-cocoapods (where #2 was merged) back into add-cocoapods-RP (where #4 was merged), and that compare link above looks better now, but I think you're right that it's more complicated than it needs to be!
My thinking here is that I was to use add-cocoapods as the main branch for https://github.com/dependabot/dependabot-core/pull/731, but that we use add-cocoapods-RP (or another branch - master perhaps?) as a sort of forked version add-cocoapods. It's not a big deal, but I'd like to do as few squashed merges to add-cocoapods as possible just so the maintainers of dependabot-core don't get bombarded by CI runs and notifications until we want them to see them ;)
Shall we agree going forward to raise PRs into add-cocoapods-RP, then a big PR into add-cocapods once we have fixed all the issues?

I think that's a good plan. Squashing all commits into some bigger updates for the main repo sounds good. I've double checked #4 and it went to add-cocoapods-RP so that all went well.
I'll probably get on the test tomorrow, hopefully we can get some nice results out of it!

I've had some troubles reproducing the issues, as on my local machine the tests still run fine, but I think when I'm running them in a Docker container I'm looking at the same issues as you and on CircleCI. At least the tests hang when it reaches the it statements enabled in this PR. After spending a few hours I still have no idea what's going on.
What I did find is the following. When the CocoaPods analyzer is set to verbose mode, you can replace analyzer.config.silent=true with analyzer.config.verbose = true the container gets stuck on
Finding Podfile changes
  - Alamofire
  - Nimble

Resolving dependencies of
  CDN: trunk Relative path: all_pods_versions_d_a_2.txt modified during this run! Returning local
  CDN: trunk Relative path: Specs/d/a/2/Alamofire/4.6.0/Alamofire.podspec.json exists! Returning
  local because checking is only perfomed in repo update
  CDN: trunk Relative path: all_pods_versions_d_c_d.txt modified during this run! Returning local

After hitting ctrl+c a bit more is logged:
RSpec is shutting down and will print the summary report... Interrupt again to force quit.
  CDN: trunk Relative path: Specs/d/c/d/Nimble/3.0.0/Nimble.podspec.json exists! Returning local
  because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/d/a/2/Alamofire/3.0.1/Alamofire.podspec.json exists! Returning

While on my local machine it continues
Finding Podfile changes
  - Alamofire
  - Nimble

Resolving dependencies of
  CDN: trunk Relative path: all_pods_versions_d_a_2.txt modified during this run! Returning local
  CDN: trunk Relative path: Specs/d/a/2/Alamofire/4.6.0/Alamofire.podspec.json exists! Returning local because checking is only
  perfomed in repo update
  CDN: trunk Relative path: all_pods_versions_d_c_d.txt modified during this run! Returning local
  CDN: trunk Relative path: Specs/d/c/d/Nimble/3.0.0/Nimble.podspec.json exists! Returning local because checking is only perfomed
  in repo update
  CDN: trunk Relative path: Specs/d/a/2/Alamofire/3.0.1/Alamofire.podspec.json exists! Returning local because checking is only
  perfomed in repo update
  CDN: trunk Relative path: Specs/d/c/d/Nimble/2.0.0/Nimble.podspec.json exists! Returning local because checking is only perfomed
  in repo update

Comparing resolved specification to the sandbox manifest
  A Alamofire
  A Nimble

I haven't checked out the cocoapods source yet to see what it's exactly doing at the time of the freeze, hoping to get a hint from that though.
What I had noticed is that the freeze is depending on the state of the trunk repo in ~/.cocoapods/repos/trunk. When I copy my local trunk to the container the tests run without hanging or failing. Deleting the folder on my local machine also makes the problem reproducible there. I've attached a ZIP file with the trunk which makes the tests succeed for me so you can try it and see if it makes the tests succeed on your machine as well. Download here
This all has given me an idea though. The test might become more reliable by reconstructing the trunk repo in ~/.cocoapods using the fixture files rather than stubbing all the requests, hoping it'll use the local files as cache. I'll give that a go tomorrow 🤞

@jspargo I've figured out why the tests are freezing. While observing the ~/.cocoapods/repos/trunk directory I noticed a directory for the Nimble 2.0.0 podspec was created, but not filled. Adding the stub for it in dd78fcf fixed that and with it made the tests on the Docker container succeed! The run on CircleCI confirms this 🚀
The rest of the PR is cleanup to reduce duplicated code in update_checker_spec.rb and file_updater_spec.rb.


Fga stuck on support (also doesn't work on battle)

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA
FGA build number
1908
Describe the bug
Works fine at first but keeps getting stuck on support with those 2 boxes. I'm still new to fga but I've been researching related problems about this.
Video
https://drive.google.com/file/d/1nHNtLz0gVjz7Ya_MvDyLbdu56Zq_Mo_U/view?usp=drivesdk

Device model
Huawei Y7 2019
Android version
8
Screen size
1520 x 720
RAM
4gb

Why do your settings say left=20 and right=5 when the bot told you to use left=52?

Even If I did use it, it wouldn't work like at the beginning of the vid when the fga clicks the node.

Even If I did use it, it wouldn't work like at the beginning of the vid when the fga clicks the node.

Also, you used an external recorder instead of FGA's recorder as instructed in the bug report form. (More Options -> Advanced)
So you'll have to restart the FGA service after applying the correct offsets.
If it still doesn't work after that, upload a video recorded by FGA.

https://drive.google.com/file/d/1nML0qhhZR2O9GGuWqtpfMt_fdV7v_cKX/view?usp=drivesdk
this is with the LEFT=20 and RIGHT=5
https://drive.google.com/file/d/1nYKJnxR1jojq4jWRrD6aFvc39SJVcPap/view?usp=drivesdk
this is with the LEFT=52

Ohh and the fine tunes are on default never touched it

FGA's recordings start after you press the play button, but here the recording is already running and you're unpausing the script.
Are you recording with Android again instead of using the record.mp4 file produced by FGA?


Use of --platform=chrome results in a timeout

From @chalin on June 6, 2017 13:24
As of version 59, chrome can run headless. It would be nice to be able to experiment with use of chrome rather than the content_shell.
At the moment, an attempt at using chrome results in a timeout (because it is waiting for the app to be compiled). Can the timeout be extended, or some other mechanism found that would allow us to use chrome?
quickstart > pub run angular_test --platform=chrome
The pub serve output is at file:///var/folders/xm/_v98y69x26v2fqdmr2wtxd3w0000gn/T/angular_test_pub_serve_output.log
Finished AoT compilation. Running tests...
00:00 +0: compiling test/app_test.dart
00:01 +0: compiling test/app_test.dart
00:01 +0: compiling test/app_test.dart
"pub serve" is compiling test/app_test.dart...
00:57 +0 -1: compiling test/app_test.dart [E]

Failed to load "test/app_test.dart":
  Timed out while loading the test suite.
  It's likely that there's a missing import or syntax error.
dart:async                  new Future.sync
  package:pool/pool.dart 127  Pool.withResource.<fn>
  ===== asynchronous gap ===========================
  dart:async                  _Future.then
  package:pool/pool.dart 126  Pool.withResource
00:57 +0 -1: Some tests failed.
Shutting down...
chalin@PAC-MBP2 Tue Jun 06 09:06:03 ~/git/sw/examples/ng/doc/quickstart

cc @matanlurey @kwalrath @kevmoo
Copied from original issue: dart-lang/angular_test#65

/cc @jakemac53 @grouma - What could I do on my end, if anything?

From @chalin on June 17, 2017 1:29
This is what I get in the console:
Uncaught Error: Load timeout for modules: test__hero_detail_test.dart.browser_test
http://requirejs.org/docs/errors.html#timeout
    at makeError (:63432/require.js:168)
    at checkLoaded (:63432/require.js:698)
    at Object.completeLoad (:63432/require.js:1615)
    at HTMLScriptElement.onScriptLoad (:63432/require.js:1717)
require.js:168 Uncaught Error: Load timeout for modules: test__app_test.dart.browser_test,dart_sdk
http://requirejs.org/docs/errors.html#timeout
    at makeError (require.js:168)
    at checkLoaded (require.js:698)
    at require.js:719
makeError @ require.js:168
checkLoaded @ require.js:698
(anonymous) @ require.js:719

To reproduce the error:

Get a local copy of the site-webdev.
(Note: you do not need to build the site in order to run tests over some of the examples.)
cd site-webdev/examples/ng/doc/toh-3 (or any other of the ng/doc/toh-* examples)
pub upgrade
pub run angular_test -v --test-arg=--platform=chrome

From @grouma on June 16, 2017 17:4
I don't think it is a timeout issue. This error usually surfaces when there is a syntax or missing dependency. What happens is the test runner can connect to the browser through a web socket but never receives any messages. Typically, the browser's console log will display something like, 'can't find package blah'. @chalin can you share what's in the console? Can you also provide steps to reproduce.

From @grouma on June 17, 2017 1:32
Hmmm. This doesn't seem to be test related. Looks like it can't find the resources. @jakemac53 any idea why these resources aren't available? I can help dig in on Monday.

From @jakemac53 on June 17, 2017 1:49
If you rerun the test it would likely work - this just means it took over 30 seconds to compile the modules. I think we probably will want to increase the timeout and/or make it configurable in the future.

I could modify to support a daemon mode without too much effort but I don't
know if it is totally worth it
On Mon, Jun 19, 2017, 6:49 AM Jacob MacDonald<EMAIL_ADDRESS>wrote:

I did not realize what this package actually is - a separate wrapper
around automatically running pub serve and pub run test it seems?
This unfortunately doesn't play nicely with dartdevc (at least the way it
appears to work today) - you really want a long-running pub serve process
not a new one each time you run. That is why re-rerunning it doesn't solve
the issue (its restarting pub serve each time, so you keep getting
timeouts).
You should be able to configure the timeout to sort of resolve this, but
you will still get a subpar experience overall if you always spin up a new
pub serve instance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/angular_test/issues/65#issuecomment-309445127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKQ7nmwnYMC51LGUaMXYXIYA7HumuFuks5sFnxMgaJpZM4NxVlZ
.

From @jakemac53 on June 19, 2017 13:49
I did not realize what this package actually is - a separate wrapper around automatically running pub serve and pub run test it seems?
This unfortunately doesn't play nicely with dartdevc (at least the way it appears to work today) - you really want a long-running pub serve process not a new one each time you run. That is why re-rerunning it doesn't solve the issue (its restarting pub serve each time, so you keep getting timeouts).
You should be able to configure the timeout to sort of resolve this, but you will still get a subpar experience overall if you always spin up a new pub serve instance.

From @chalin on June 17, 2017 11:16

If you rerun the test it would likely work

FYI, I reran the tests 3 times, each time with the same result.

Is this something I should be configuring differently?

That's a very sane idea :)

From @jakemac53 on June 19, 2017 16:27
What if you just supported a --pub-serve arg and if provided then you didn't start your own and just forwarded the arg to the test runner?

From @chalin on June 20, 2017 21:48
So, just to be sure that we're on the same page. Adding a timeout, doesn't seem to work. I.e., if I try
pub run angular_test -v --test-arg=--timeout=4x --test-arg=--platform=chrome --serve-arg=--web-compiler=dartdevc

I get the same "requirejw" timeout being reported in the Chrome console.
Once #74 is implemented will the strategy be to "prime" pub-serve/the app before running tests? If not, what strategy do you propose?

https://github.com/dart-lang/angular_test/issues/74

From @jakemac53 on June 20, 2017 21:52
The timeout issue is actually with require.js module loading timeouts which aren't currently configurable in the pub + dartdevc workflow, so changing the test timeout doesn't help.
Once https://github.com/dart-lang/angular_test/issues/74 is implemented you can run pub serve and then run pub run test two times. The 2nd time it should work (and all subsequent times). Obviously that isn't ideal but its the best workaround right now.

Blocked on https://github.com/dart-lang/angular/issues/469.


General Grievance: Watch mayermuskrecoveries.com

General Grievance requests the watch of the watch_keyword mayermuskrecoveries\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

mayermuskrecoveries\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Cody Gray in Charcoal HQ


Add more conditions to check when unique equals true

Add more conditions to check when unique equals true.
In my case, my "slug" column isnt "unique". But i can't have duplicate slugs for the same "company" (for example).
Example:
protected $sluggable = ['on_slugcheck' => 'addCheckCompanyCondition'];

public function addCheckCompanyCondition( $query )
{
   return $query->whereCompanyId( 1 );
}

This is pretty much the same feature that is being requested in MR #103 ... and I like this implementation better.  Although I'd go with the name scope instead of on_slugcheck I think.
Can you fix up your MR so that it works with the current master branch here (which is now Laravel 5), and resubmit?

Closed for lack of feedback.


Sushiswap (All: Arbitrum, Fuse, Polygon, Avalanche, BSC, Celo, Fantom, Gnosis, Mainnet, Moonriver, moonbeam) Schema Version 1.3.0 Subgraph Version  1.1.2 Methodology Version 1.0.0

Overall Comments: 1) All subgraphs have issues for Base Yield on pool overview page based on sanity check. 2) Avalanche, Celo and Gnosis have issues of totalvaluelockedUSD and dailyvolumeUSD when compared to Defilama and Sushi analytics dashboard. 3) Fantom, Celo, Avalanche and Fuse have issues with dailyvolumebytokenUSD charts showing zero inside the pool section. 4. Ethereum, BSC and Polygon are still indexing (blocks and percentage indicated in their section).
Excel file for all issues combined: https://docs.google.com/spreadsheets/d/1-z6Eyl0cKodxq7fmnhS7Pt_F56ci6qW-zBi-KkPvugw/edit#gid=0
Arbitrum

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/sushiswap-arbitrum&tab=protocol

Date Reviewed
July 15 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1CJzTV7LA2BsH1iMpY5x7Y3diTCbP9HbxvW-WJrdE7a0/edit#gid=617964580

Pool Overview
All Pools |   |   |
-- | -- | -- | --
All | Base Yield % | NOT OK | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Fuse

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/sushiswap-fuse&tab=protocol

Date Reviewed
July 15 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1lch_ID4FZMOQLGEtQf0fwju2RgB-yVXWCHr6WJwxAJQ/edit?usp=drive_web&ouid=111561086681119932380

Pool Overview
All Pools |   |   |
-- | -- | -- | --
All | Base Yield % | NOT OK | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Pool
wFuse/USDC

liquidityPoolHourlySnapshots
hourlyVolumeByTokenUSD - WFUSE
not ok
All zeroes, sanity check, should have some volume on the tokens

Avalanche

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/sushiswap-avalanche&tab=protocol

Date Reviewed
July 15 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1eHePJk_OuHpxbnsiQIInvRDe7b29An0VGtxtJhFQrR8/edit?usp=drive_web&ouid=111561086681119932380

Protocol

Section
Value
Status
Comments

financialsDailySnapshots
totalValueLockedUSD
Not ok
Appears 60% less, should be 15-20mil based on sushi dashboard at peak and defillama but showing 5-6 mil

financialsDailySnapshots
dailyVolumeUSD
not ok
Appears to be 60% less, should be 600K from sushi dashboard, but showing 200k

Pool Overview
All Pairs|   |   |
-- | -- | -- | --
all coins | Base Yield % | NOT OK | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Pool
SushiSwap USD Coin/wavax |   |   |
-- | -- | -- | --
liquidityPoolDailySnapshots | dailyVolumeByTokenUSD - WAVAX | Not ok | All zeroes, sanity check, should have some volume on the tokens
liquidityPoolHourlySnapshots | hourlyVolumeByTokenUSD - USDC | not ok | All zeroes, sanity check, should have some volume on the tokens
Celo

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/sushiswap-celo&tab=protocol

Date Reviewed
July 18 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1cL-_hAfSztiEaxKCtWdEDF5qiVF87NcEutwuI9f3QWE/edit#gid=617964580

Protocol

Section
Value
Status
Comments

financialsDailySnapshots
totalValueLockedUSD
Not ok
Appears 60% less, should be 1.4mil at peak based on sushi dashboard and defillama but showing 500k.

financialsDailySnapshots
dailyVolumeUSD
not ok
Appears 60% less, should be 100K from sushi dashboard, but showing 10000-30000

Pool Overview
All Pools|   |   |
-- | -- | -- | --
ALL | Base Yield % | NOT OK | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Pool
SushiSwap USD Coin/cUSD |   |   |
-- | -- | -- | --
liquidityPoolDailySnapshots | dailyVolumeByTokenUSD - cUSD | Not ok | All zeroes, sanity check, should have some volume on the tokens
liquidityPoolHourlySnapshots | hourlyVolumeByTokenUSD - cUSD | not ok | All zeroes, sanity check, should have some volume on the tokens
Fantom

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/sushiswap-fantom&tab=protocol

Date Reviewed
July 18 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1pvPgw9TJLL6R6Du3lvEDuiUETmJC392KNepNAOh0_Zs/edit#gid=617964580

Pool Overview
All Pools |   |   |
-- | -- | -- | --
All pools | Base Yield % | NOT OK | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Pool
SushiSwap USD Coin/wftm |   |   |
-- | -- | -- | --
liquidityPoolDailySnapshots | dailyVolumeByTokenUSD - wftm | not ok | All zeroes, sanity check, should have some volume on the tokens
liquidityPoolHourlySnapshots | hourlyVolumeByTokenUSD - wFTM | not ok | All zeroes, sanity check, should have some volume on the tokens
Gnosis

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/id/QmP2voZc7m5tKok56etPYcfefH2ubF4E7qx36Xa3uBcLYu&tab=protocol&version=pending&name=messari/sushiswap-gnosis

Date Reviewed
July 18 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1j2aDCimCBhrfsETxXQqD7TZaCJmuhk7dekwPaQ_Z0U4/edit#gid=617964580

Protocol

Section
Value
Status
Comments

financialsDailySnapshots
totalValueLockedUSD
not ok
Appears 30% less, should be 21 mil but at 14 mil when comparing sushi dashboard to subgraph.

Pool Overview
All pools |   |   |
-- | -- | -- | --
all | Base Yield % | not ok | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Comment: There are two versions of Gnosis on the front end.
Moonriver

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/sushiswap-moonriver&tab=poolOverview

Date Reviewed
July 18 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1vSliBYy_l8jB_5w7Zkar7wEg2CcIdiqvACFEmgFHFTo/edit#gid=617964580

Pool Overview
All pools |   |   |
-- | -- | -- | --
All pools | Base Yield % | NOT OK | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Moonbeam

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/sushiswap-moonbeam&tab=poolOverview

Date Reviewed
July 18 2022

Schema Version
1.3.0

Subgraph Version
1.1.2

Methodology Version
1.0.0

Evidence
https://docs.google.com/spreadsheets/d/1dpG4w7QUQYJ7t98xbItXT3lux7ssClvsJcKVKtePRbA/edit#gid=617964580

Pool Overview
All Pools |   |   |
-- | -- | -- | --
All | Base Yield % | NOT OK | Yield is showing APY in the 4 digits. This is excluding liquidity mining. Sanity check suggests something is wrong. Could it be pulling farm data?
Comment: Liquidity is very low on this network, probably very new
Awaiting indexing
Mainnet (Ethereum)
Cannot QA, needs to finish indexing before QA (currently 0%)
Latest block: 0
Current chain block: 15167045
there is an old subgraph version with errors previously reported, this is the new subgraph. both appear on front end.
 Thanks for the review. I requested access to the excel file you posted at the top since I do not yet have permission.

@steegecs already approved. let me know if you have any issues accessing it or if you have any questions or concerns. The issues seem largely consistent between deployments. Thank you for going through the subgraphs. :)

Thanks!

Is the hourlyVolumeByTokenAmount for fuse supposed to be hourlyVolumeByTokenUSD?

You are correct @steegecs, my mistake, the metric is accurate on the other chains. Some of these hourly issues I brought up are more sanity checks, as unusual outputs (ie: high variability and zeros would be more common).

Hey @ishraq8, the APR issue in the validation dashboard should've been fixed and the numbers should be accurate now. Do you mind giving this another pass?

All sushi subgraphs look good except the two following issues:

https://analytics-bsc.sushi.com/

TVL and daily volume is higher on the subgraph for BSC than on the sushi dashboard. unsure why that is. if you would like i can raise another issue on github,.

https://analytics-polygon.sushi.com/
Polygon tvl and volume looks higher on subgraph as well. schema is listed as 1.1.2 which is old. may just need to be updated.

once complete we can icebox all sushi subgraphs.

@this-username-is-taken Sushi is good on all chains. Polygon is a bit slow to complete indexing but the data is good. Please freeze


minor fixes

Due to the JOSS submission:
https://github.com/openjournals/joss-reviews/issues/7522

Looks good, thanks!


feature request: use source PR labels to pick branches to backport to

First off: awesome project! Thank you for your work.
I have a feature request, and would love to hear your thoughts. It would be really nice if it were possible to create some feature PR that will later need to be backported. Often you know beforehand where it should be backported to. One could use GitHub labels to mark that all PRs with label backport-v1 should later be backported to the v1 branch. If a label system like that is applied, running backport --pr 123 could read those labels and preselect all the right branches.
Being able to determine ahead of time where we backport to would really improve our workflow. I'm guessing we may not be alone in that.

Hey @ronkorving!
Sorry for the slow reply. I think is a great idea. I'm still not settled on a particular implementation but I'll sketch a rough idea of what I think. LMK if you have any suggestions to make.
To enable this feature the user must update .backportrc.json with versionLabelRegex:
{
  "upstream": "elastic/kibana",
  "branches": [{ "name": "7.x", "checked": true }, "7.7", "7.6"],
  "versionLabelRegex": "^backport-(v\d+)$"
}

versionLabelRegex is a regex that'll extract the target branch from labels. In this case the regex will match backport-v1 (v1), backport-v2 (v2) and so forth.
We can also make it an array if multiple matchers are necessary:
{
  "upstream": "elastic/kibana",
  "branches": [{ "name": "7.x", "checked": true }, "7.7", "7.6"],
  "versionLabelRegexes": ["^backport-(v\d+)$"]
}

This will work intuitively when backporting individual PRs like backport --pr 123: if an applicable label is found, the PR is backported without asking the user any additional questions.
But what should happen if the user runs something like backport --multiple? They will now be prompted to select one or more commits to backport, which might not all have version labels.
The user could select a commit which does have version labels, and a commit which doesn't.
In that case should the user then be prompted to select branches to backport to? And should that selection override the version labels or only apply to the commit that doesn't have version labels?
Is it possible that someone might want to override the label logic, and backport a commit to other branches?
LMK if it makes sense and whether you have any opinion on this matter.

Hey, thanks for the extensive response and proposals.
Configuration
About versionLabelRegex vs versionLabels, I think a hybrid might be superior. I'll give a real world example from a project I'm working on. My master branches are v1-master, v2-master, v2.1-master, etc. If I want a label v1, the regexp approach seems tricky, because I cannot append -master in the result. So I would have to label v1-master. This is not the end of the world of course, but now is the time to be nitpicky I guess, before things get built.
versionLabels are a solution, but they are not just verbose, they also require upkeep.
How about a hybrid (example adapted to my scenario):
{
  "versionLabels": {
    "some-special-branch": "some-special-label",
    "v([0-9]+)-master": "v$1"
  }
}

This allows both regular expression replacement, and simple mapping to co-exist.
The $1 syntax is based on how String.prototype.replace works. This does of course make the $ symbol a special character, but I imagine that's worth it. One could always allow $$ to mean a literal $ if we really need it.
Running backport
To be honest, I don't have strong opinions or ideas on this at this time, especially as I haven't yet really used --multiple yet. I think conflicts should prompt the user to act. If at that point, the labels can be displayed, and the choice can be made manually (incl. the choice to abort), I think it should be fine?

How about a hybrid (example adapted to my scenario):

I like it 👍

Running backport

Okay, in the beginning I'll enable this behaviour when running backport --pr and backport --sha and leave it out for backport --multiple until I have a better idea of how it should behave.
@spalger I think you had a suggestion similar to this a long time ago. Would the hybrid approach work for your usecase?

@ronkorving This has been released in v5.2.0. I ended up naming the option branchLabelMapping. You can find the documentation here.
LMK if it works like it should. If you have any other suggestions we can iterate on it.

@sqren Flippin' awesome! :) I will let you know if anything comes up (although tbh, it may take a while before I get my hands on it).


Send webhook when tag is removed via Web UI

Fixes #14000

Codecov Report

Merging #14015 (e1ccf3f) into master (66379ba) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #14015      +/-   ##
==========================================
- Coverage   42.20%   42.15%   -0.06%
==========================================
  Files         710      710
  Lines       77273    77282       +9
==========================================
- Hits        32612    32576      -36
- Misses      39288    39357      +69
+ Partials     5373     5349      -24

Impacted Files
Coverage Δ

services/release/release.go
49.07% <100.00%> (+4.62%)
:arrow_up:

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/indexer/stats/queue.go
64.70% <0.00%> (-11.77%)
:arrow_down:

modules/indexer/stats/db.go
43.47% <0.00%> (-8.70%)
:arrow_down:

modules/notification/ui/ui.go
84.72% <0.00%> (-8.34%)
:arrow_down:

models/issue_comment.go
45.46% <0.00%> (-7.26%)
:arrow_down:

modules/notification/mail/mail.go
33.33% <0.00%> (-5.75%)
:arrow_down:

modules/git/commit.go
49.67% <0.00%> (-3.95%)
:arrow_down:

modules/notification/base/null.go
74.28% <0.00%> (-2.86%)
:arrow_down:

modules/notification/notification.go
83.92% <0.00%> (-2.68%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66379ba...ffd3959. Read the comment docs.

@CirnoT Backport is a go. ✈


Update Color Scheme

This may be a Hero/Jumbotron update. We need to telegraph brand colours of Dex somewhere—at very least, on the home page.

As per feedback session w/ @celestehorgan & @zacharysarah


Persistence of User theme preference

ISSUE DETAILS
Currently, the user-selected theme preference (Dark / Light Mode) is not persisted and on reloading the application it resets to dark mode.
Visiting the application multiple times, the user would wish the application should handle and refer to the previously provided choice option from users.

Hey @avinashkranjan, @Utkarsh1999, @abhishek2x, I am a GSSOC 2021 participant. I would like to work on the issue.
Could you please update the issue with relevant tags and assign the same?

Sure, go ahead.

Hey @avinashkranjan, @Utkarsh1999, @abhishek2x, I am a GSSOC 2021 participant. I would like to work on the issue.As the issue has not been resolved I would like to work in this issue Can u assign it to me also


How to run this code

I am interested in your paper and want to be set up your code. But I do not how to run it. Please take time to write a clear guidance. Thanks so much.  I am looking your forward.

Hi @diemtran1005, I've added the dependencies for the scripts. The Norse library is only needed if you are interested in running the SNN script. After installing the requirements, the scripts should run as any other python script. The SNN might look stuck when ran but after the training, applying the attack to the model takes a bit of time, even if you are using a GPU. I'm leaving the issue open until you give me a feedback.

Hi @diemtran1005, I've added the dependencies for the scripts. The Norse library is only needed if you are interested in running the SNN script. After installing the requirements, the scripts should run as any other python script. The SNN might look stuck when ran but after the training, applying the attack to the model takes a bit of time, even if you are using a GPU. I'm leaving the issue open until you give me a feedback.

I can be running now. Thanks very much for your support.

I can be running now. Thanks very much for your support.

Great!

Great!


Problems with IE 11 in compatibility mode

Hi everyone first thanks a lot for the service.
I am currently facing an issue which I cannot resolve properly. I want to add the Intl. polyfill when a browser needs it for example IE 10. Since IE 11 doesn't need a polyfill its alright that it doesnt get send down the wire while using IE 11 but now I want to make sure that the polyfill will get send also when a user switches from IE 11 to IE 10 e.g. inside the devtools or is using IE 11 in compatability mod. .
So what I tried to do is to send down the polyfill always but only for IE 11 users ->
https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en-US|always&ua=Mozilla%2F5.0%20(Windows%20NT%206.1%3B%20Trident%2F7.0%3B%20rv%3A11.0)%20like%20Gecko

Is that possible I think I dont understand the API correctly.
Thanks a lot in advance. :)

Hi @Ixl123, IE11 compatability mode is recognised as IE/7. The Intl polyfill supports IE 9 - 10.
Regarding the polyfill URL you have mentioned, the ua parameter is used to tell the polyfill-service what browser to target the polyfills for. If you send us the IE/11 user-agent string, we will service polyfills for IE/11 to all your users, including those on Chrome, Safari etc. This is not recommended.
What you can do is force the Intl.~locale.en-US polyfill to always be downloaded but only use it if the feature is not detected as natively supported. The way to do this is to include |always|gated after the specific polyfill. E.G. https://cdn.polyfill.io/v2/polyfill.js?features=Intl.~locale.en-US|always|gated. This will mean that modern browser which support Intl will always download the polyfill but they wont ever use the polyfill.

This can not be solved by the polyfill-service until https://github.com/andyearnshaw/Intl.js/issues/189 is resolved upstream. Please follow that issue if you would like to know when a fix for this is released.

@JakeChampion thanks a lot for your response 👍


first pass at cleaning out bch related code

this PR addresses #1
It seems like there may be more things to do related to pulling out BCH related opcodes out of the script interpretation, however, iirc we may be moving the script interpreter out of the package altogether.

An easy loose end to fix is getting rid of SIGHASH_FORKID (and decendents) and renaming txSigHashForkId to txSigHashSegwitV0 or something.

An easy loose end to fix is getting rid of SIGHASH_FORKID (and decendents) and renaming txSigHashForkId to txSigHashSegwitV0 or something.

Good catch. I knew I was gonna miss something cause I didn't comb through all of the code scrutinizing things that don't exist in BTC. I'll remove that here.

all comments addressed


Provisioning Learning Pathways

Getting the following error when trying to provision learning pathways:
Sorry, Something went wrong.  There was an unexpected issue.
Cannot retrieve a valid access token for user

Hi,
Thanks for your feedback. Do you have the PnP Correlation ID of the request? Without the ID we cannot see what is happening. Thanks.

Everything seems to be working now.  Thanks!


Osx openssl test comment

Adds a comment regarding reason for tests failing

wrong base branch, wrong commit message format. Redoing


Strange memory error after ZAXREPLACE() and cancelling an ENSEMBLE aggregation

Create a tiny file containing a z-oriented variable named A.
   NOAA/PMEL TMAP
   FERRET v7.63 (optimized)
   Linux 3.10.0-1160.25.1.el7.x86_64 64-bit - 08/25/21
    4-Feb-22 14:30

yes? let a = zsequence({1,2,3})
yes? save/q/clob/file="a.nc" a
yes? can var a

Define pseudo-variable B, in which A's z-axis is simply replaced with itself, then list the start coordinate.  This works fine.
yes? use "a.nc"
yes? let b = zaxreplace(a,a,a)
yes? say "Value of B is: `b,r=zstart`"
 !-> MESSAGE/CONTINUE "Value of B is: 1"
Value of B is: 1

Save out this variable as "C".
yes? let c = b
yes? save/q/clob/file="c1.nc" c
yes? can var c

Duplicate the file.
yes? sp cp -f c1.nc c2.nc

Create an ensemble aggregation, then immediately cancel it. If we comment out either of these lines, then the crash below will disappear!
yes? ensemble ens_agg = {"c1.nc","c2.nc"}
yes? can dat/all

Try to list the start coordinate of pseudo-variable "B" as before. It now fails!
yes? use "a.nc"
yes? say "Value of B is: `b,r=zstart`"
 **ERROR: too many variables to store in memory

This does not fail in the v7.63 compiled on 1/4/21, only the version compiled on 8/25/21.  So there must have been some change in early 2021 that caused this.  This is causing many of our analysis scripts to fail, so I am marking this as urgent.

@josborne-noaa From the last sentence in Andrews message, can you please confirm if any changes have been committed to the PyFerret release since January 2021?

@AndrewWittenberg I wasn't able to replicate this with the current release. None of the changes made in the last year would impact the memory management portion of the code-base.


scikit_bring your own

hi,
i'am trying to deploy my decision tree algorithm with my own dataset so i followed the sickit_bring_your_own but i changed the train file. i wonder if i can use only the inference (pretrained model) but i don't understand this concept yet.
anyway this how i read my data
def read_label():
    label = {}
    for i in range(1, 7):
        hi = 'decision-tree/data/house_{}/labels.dat'.format(i)
        label[i] = {}
        with open(hi) as f:
            for line in f:
                splitted_line = line.split(' ')
                label[i][int(splitted_line[0])] = splitted_line[1].strip() + '_' + splitted_line[0]
    return label
labels = read_label()

def read_merge_data(house):
    path = 'decision-tree/data/house_{}/'.format(house)
    file = path + 'channel_1.dat'
    df = pd.read_table(file, sep = ' ', names = ['unix_time', labels[house][1]],
                                       dtype = {'unix_time': 'int64', labels[house][1]:'float64'})
    num_apps = len(glob.glob(path + 'channel*'))
    for i in range(2, num_apps + 1):
        file = path + 'channel_{}.dat'.format(i)
        data = pd.read_table(file, sep = ' ', names = ['unix_time', labels[house][i]],
                                       dtype = {'unix_time': 'int64', labels[house][i]:'float64'})
        df = pd.merge(df, data, how = 'inner', on = 'unix_time')
    df['timestamp'] = df['unix_time'].astype("datetime64[s]")
    df = df.set_index(df['timestamp'].values)
    df.drop(['unix_time','timestamp'], axis=1, inplace=True)
    return df
df = {}

df1_train = df[1].ix[:dates[1][10]]
df1_val = df[1].ix[dates[1][11]:dates[1][16]]
df1_test = df[1].ix[dates[1][17]:]
X_train1 = df1_train[['mains_1','mains_2']].values
y_train1 = df1_train['refrigerator_5'].values
X_val1 = df1_val[['mains_1','mains_2']].values
y_val1 = df1_val['refrigerator_5'].values
X_test1 = df1_test[['mains_1','mains_2']].values
y_test1 = df1_test['refrigerator_5'].values

the problem is how the get the path of data because it doesn't know the path that i put it in the code
ANY IDEA
Thank you

Hi @walidsliti

It is possible to train your model locally and just use SageMaker hosting for real-time predictions or batch transform for large-scale batch predictions.
When using File mode, SageMaker training brings data in from S3 to the container at /opt/ml/input/data/<channel_name>/, as documented here.  The BYO scikit example creates a training_data variable to do this.

Closing due to inactivity.  Feel free to re-open if needed.  Thanks.


Update installation

Multiple users have had errors with this. This adds verbosity so we don't need to merge necessarily if you want a very terse installation process but I think it might be helpful. Talon installation UX remains rather weak so I think its good to specify

Sorry to be...incredibly slow on this one 😅. Did you close this one because you gave up on it ever getting merged or because some change to Talon rendered it no longer necessary?

No worries I closed it since I thought you weren't interested.  Feel free to open it back up if desired.  I've seen a fair bit of people within the slack miss the fact they have to install a speech engine if they are installing Talon specifically for cursorless ( so I thought it might be useful to specify) (i.e.  people that see cursorless from a talk,  and want to try it out may miss the speech engine part of installing talon since they are more concerned with cursorless setup)
But this isn't a big deal either way and may not be necessary.

Yeah I think let's reopen; I do think it's potentially helpful so I'd prefer not to lose track of it. It just got lost in the backlog


Tests silently skipped in CI on Windows and macOS environment

Turns out the GitHub actions Windows and macOS environment does not have Vulkan installed. That make sense - macOS don't generally have MoltenVK installed.
https://github.com/vulkano-rs/vulkano/blob/741a5060c29d5e83f1964fa487b1bba9e5baa7fc/vulkano/src/tests.rs#L19
Right now during tests, if we fail to load the vulkan library, or if instance creation fails for any reason, it simply returns from the test and mark it as success.
We should probably figure out a way to install Vulkan environment on Windows & macOS.
https://github.com/vulkano-rs/vulkano/pull/1841#issuecomment-1051287676
https://github.com/vulkano-rs/vulkano/pull/1876#issuecomment-1099911005

Pinging @AustinJ235 who commented on the issue previously.


deposit_collateral exception

const { ScallopClient, ScallopAddress } = require('@scallop-io/sui-scallop-sdk');
require('dotenv').config({ path: '.env' });

const NETWORK = 'mainnet';

async function test() {

    const scallopAddress = new ScallopAddress({
        id: '649bdadbb946e3b1853f3d4d', // test addresses of new contract
        network: NETWORK,
    });
    await scallopAddress.read();
    const client = new ScallopClient(
        {
            secretKey: process.env.SUI_PRIVATE_KEY,
            networkType: NETWORK,
        },
        scallopAddress
    );

    const marketData = await client.queryMarket();
    console.info('marketData:', marketData);

    const openObligationResult = await client.openObligation();
    console.info('openObligationResult:', openObligationResult);

    const obligations = await client.getObligations();
    const depositCollateralResult = await client.depositCollateral(
        'sui',
        10 ** 1,
        true,
        obligations[0]?.id
    );
    console.info('depositCollateralResult:', depositCollateralResult);
    console.log(depositCollateralResult.effects.status.status)
}

test()

get this error  error: 'MoveAbort(MoveLocation { module: ModuleId { address: 3027af7d3bde467b61f5f1141c830fe191b22febc38f32405b601b41b5a8959b, name: Identifier("deposit_collateral") }, function: 0, instruction: 18, function_name: Some("deposit_collateral") }, 257) in command 1'
what does this mean ?

Thanks for your feedback, this error is caused by a whitelist problem on the contract side, you using the wrong addresses id (wrong contract) to interact, changing the id to ADDRESSES_ID from const { ScallopClient, ScallopAddress, ADDRESSES_ID } = require('@scallop-io/sui-scallop-sdk'); is what you want.
Anyway, we'll sort out the list of error codes in our document later let Devs easy to debug it.


fix(wallet): hide zero channel balance

Description:
If the total channel balance is zero, do not show the channel balance at the top of the network view as the zero doesn't convey any useful information and looks strange.
How Has This Been Tested?
Manually test app
Screenshots (if appropriate):
Before:

After:

Types of changes:
UX improvement
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

utACK ba361ee


Machine mac-23 lost external connection from iPhone device.

Machine mac-23 lost external connection from iPhone device.

The external connection has been restored by rebooting mac-23.


Fixes and extensions

While working with postgrest-ex I noticed a couple of issues, for example conditions passed to select were ignored.
This PR fixes this.
It also extends delete and insert so that it is possible to get the created/deleted item back if needed.

Thanks for the catch! Sorry for the delayed reply -- will take a look and respond accordingly within the next few hours.

No worries, take your time :)

Left some comments for my own understanding and it looks great to me. Thanks so much for doing this! Greatly appreciated :)


Shortened code

So the Travis failure is due to line length - which is yours to fix, I’m afraid. (I don’t think the logic needs to change but the line needs splitting.)
The other one is a misspelling of “attribute”. I don’t know if this is yours but I’d be grateful if you fixed it - if it’s in the part you improved.
Thanks, Martin

Hi @jbaenaxd! Thank you for your (first) contribution to the project.
This pull request generated problems with both checks. While I’m inclined to accept the PR, can you check why these failed - and maybe rework slightly to avoid the failures?
Also, while I’m all for elegant code, what was the purpose of one-lining these lines?
Anyhow, I hope you don’t feel discouraged - and welcome aboard!
Cheers, Martin

I'm about to start work on filterCSV again. So cleaned up.


Past contracts are not shown in award details screen

The list should be shown as designed in Figma:

The feature has been implemented now


SRS typos and other minor consistency errors

The following is a list of typos and other minor consistency issues with the current draft of the SRS:

In section 3, in the 2nd sentence, "moleule" should be "molecule"
In section 3, 3rd sentence, "abbreivated" should be "abbreviated"
In section 3, 4th sentence, "geometies" should be "geometries"
In section 3, 4th sentence, "procurring" should be "procuring"
In section 3.2, 3rd sentence, "diehdral" should be "dihedral"
In section 3.3, in the itemized list, "hamiltonian" should be capitalized
In section 3.4, 2nd sentence, there is a reference to section 1 but this should be a reference to section 2
In section 4.1, the first paragraph should not be indented (to be consistent with the rest of the document)
In section 4.1, 2nd sentence, "includes" should be "include"
In section 4.1, the 2nd item of the User Responsibilities list should not end in a period (for consistency)
In section 4.2, "first year" should be "first-year" (for consistency with rest of document)
In section 4.2, "3rd year" should be "third-year" (for consistency with rest of document)
In section 5.1.2, item PS1, first sentence, "molecule" should be capitalized
In section 5.1.2, Figure 3 appears without any corresponding reference in the text to give it context
In section 5.2.1, A5, the word "a" is missing before "linear combination"
In section 5.2.5, 2nd paragraph, 3rd sentence is written imperatively (should be rephrased with a clear subject of the sentence -- what is manipulating the dihedral angles to solve for Fit_G?)
In section 5.2.5, IM1 description, I do not think the words "water temperature" were intended to be there
In section 5.2.5, IM1 description, "1" should be "one" (for consistency)
In section 5.2.6, Table 2, an asterisk should appear next to the table entry for G_n (as it is referenced by the asterisk note below the table)
In section 6.1, R1, in the last entry in the table "to specify to connectivity" should be "to specify the connectivity"
In section 9, T2, "hamiltonian" should be capitalized

I fixed everything except the asterisk for table 2 (since it's in the column next to the pertinent variable). 93131d92a2bc7ef1029578ef5c1c8a4ea6d5aa9a


Fix typo in comment

Description
Fixes a typo in a comment in values.yaml
Issues Resolved
NA (too trivial to create an issue)
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hi @averykhoo
As part of migration of Helm charts to a different repo #53 . There is a PR in place for migration. It will be great if you can review the PR and comment in your changes. Thanks!

Sorry, I don't have write access to the opensearch official repo, so I can't help to review your PR. I've created a duplicate PR into your fork instead, so this edit can be included in your PR.

Sorry, I don't have write access to the opensearch official repo, so I can't help to review your PR. I've created a duplicate PR into your fork instead, so this edit can be included in your PR.

FYI , you can still review the PR even if you don't have write access and put your comments in.


How to specify a custom convertor in Riak 2.x client ? [JIRA: CLIENTS-880]

Hi,
-Sorry for posting on the issues wiki since I could not figure out the right forum for java riak client 2.x?
-While profiling with flight recorder, I see that about 20% of time is spent in Jackson from within Riak client (Fetch/Store). Our app is heavy on Riak, using about 40+ Riak calls per request in some specific complex apis that I was testing.
-Can you please let me know how can I try out alternate convertors and benchmark ? 1.x seemed to have a way as per docs, but not in 2.x.
Thanks
Preetam

Hi Preetam,
The 2.0 Converters work similar to the 1.0 converters.  You'll extend an abstract Converter<T> class, and then register it with the ConverterFactory, which tells Riak to use that converter for that type.
You can annotate fields in your POJOs with our available annotations, just the same as 1.0.
Let me know if you need more help.
Thanks,
Alex

Thanks Alex for the quick response. I will try it out.


[FLINK-27976][WebUi] Allow order jobs by name

What is the purpose of the change
Allow to order jobs in webui
Brief change log

add nzSortFn in job name column

Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@MartijnVisser could you forward to someone that can check this?

@yangjunhan Could you please review this PR?

@yangjunhan @MartijnVisser it's need anything from my side?

@Airblader Can you have a quick look instead of @yangjunhan ?

Makes sense to me. @MartijnVisser I assume you'll take care of merging?

Will do. Thanks!


ortho projection w/ limits crashes

Basemap documentation states that ortho projection can take ll/ur crnr limits. The following code seems like it should work (mpl 1.4.0), but does not:
from mpl_toolkits.basemap import Basemap
m = Basemap(projection='ortho',lon_0=0,lat_0=0,llcrnrlat=-10,llcrnrlon=-10,urcrnrlat=10,urcrnrlon=10)

Error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-5-98fbf042abb9> in <module>()
----> 1 m = Basemap(projection='ortho',lon_0=0,lat_0=0,llcrnrlat=-10,llcrnrlon=-10,urcrnrlat=10,urcrnrlon=10)

/Users/mankoff/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/mpl_toolkits/basemap/__init__.pyc in __init__(self, llcrnrlon, llcrnrlat, urcrnrlon, urcrnrlat, llcrnrx, llcrnry, urcrnrx, urcrnry, width, height, projection, resolution, area_thresh, rsphere, ellps, lat_ts, lat_1, lat_2, lat_0, lon_0, lon_1, lon_2, o_lon_p, o_lat_p, k_0, no_rot, suppress_ticks, satellite_height, boundinglat, fix_aspect, anchor, celestial, round, epsg, ax)
   1032         self.area_thresh = area_thresh
   1033         # define map boundary polygon (in lat/lon coordinates)
-> 1034         blons, blats, self._boundarypolyll, self._boundarypolyxy = self._getmapboundary()
   1035         self.boundarylats = blats
   1036         self.boundarylons = blons

/Users/mankoff/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/mpl_toolkits/basemap/__init__.pyc in _getmapboundary(self)
   1464             # circular region.
   1465             thetas = np.linspace(0.,2.*np.pi,2*nx*ny)[:-1]
-> 1466             rminor = self._height
   1467             rmajor = self._width
   1468             x = rmajor*np.cos(thetas) + rmajor

AttributeError: 'Basemap' object has no attribute '_height'
> /Users/mankoff/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/mpl_toolkits/basemap/__init__.py(1466)_getmapboundary()
   1465             thetas = np.linspace(0.,2.*np.pi,2*nx*ny)[:-1]
-> 1466             rminor = self._height
   1467             rmajor = self._width

ipdb>

Not sure to understand because indeed without lat_0 and lon_0
from mpl_toolkits.basemap import Basemap
m = Basemap(projection='ortho',llcrnrlat=-10,llcrnrlon=-10,urcrnrlat=10,urcrnrlon=10)

gives
 ValueError: must specify lat_0 and lon_0 for Orthographic basemap

The "but not lat/lon" from jswhit push me to try without lat_0 and lon_0.
Sorry for the missunderstanding and thank you for the clarification.

I would like to clean up any documentation bugs soon. Could someone please suggest a revised line? Even better, could someone put together a PR with the documentation correction?
Also, ideally, I would want to produce a better error message in this case, so a suggested error message would be useful, too.
full discloser, I don't work in ortho projections, so I have no clue what is/isn't allowed.

Can someone please comment on how to obtain
lcrnrx,llcrnry,urcrnrx,urcrnry given that I have llcrnrlat=-10,llcrnrlon=-10,urcrnrlat=10,urcrnrlon=10?
Usually you may get x,y as  x,y = m(lon,lat); however, if you need to know these already when instantiating the Basemap, you cannot use the Basemap to calculate the values to input in its initialisation method.


[BUG] Session Keep Disconected

Describe the bug
I have issue regarding session. I got mass session loggedOut 1 hour after device Scan. I have more than 10 session in my service but less than 30.
To Reproduce
Steps to reproduce the behavior:

Scan 5-10 devices.
wait for hours doing nothing (usually 1 hours)
most of devices shows need to rescan.
log showing session error code 401

Expected behavior

Scan 5-10 devices.
no need to rescan after 1 hour of idle.

Environment (please complete the following information):

My server are on DO using kubernates.
All IP is static in SG, my devices are Indonesian phone number.
these are my codes related:

public connectionHandler({
   sock,
   store,
   sessionId,
 }: {
   sock: WASocket;
   store: WAStore;
   sessionId: string;
 }): ConnectionFn {
   return async ({
     qr,
     connection,
     lastDisconnect,
   }: Partial<ConnectionState>): Promise<void> => {
     this.logger.info(
       {attrs: {sessionId, connection}},
       'new connection status',
     );

     if (qr) {
       try {
         const qrCode = await toDataURL(qr);

         const evPayload: WhatsappEventPayload = {
           sock,
           store,
           sessionId,
           qrCode,
         };

         this.ev.emit('wa::conn.qr', evPayload);

         return;
       } catch (error) {
         this.logger.error(
           {err: error, attrs: {sessionId}},
           'error generate qrCode',
         );

         // attempt logout when error
       }

       console.info('failed QR, attempt logout :', sessionId);
       try {
         await sock.logout();
       } catch (error) {
         this.logger.error(
           {err: error, attrs: {sessionId}},
           'error when logout',
         );
       }

       this.retries.delete(sessionId);

       const evPayload: WhatsappEventPayload = {
         sock,
         store,
         sessionId,
       };

       this.ev.emit('wa::conn.logout', evPayload);

       return;
     }

     if (connection === WAConnectionState.CONNECTING) {
       this.logger.info({attrs: {sessionId, connection}}, 'connecting socket');
     }

     if (connection === WAConnectionState.CLOSE) {
       const {statusCode} = new Boom(lastDisconnect?.error)?.output;
       const reason = statusCode as DisconnectReason;

       if (
         reason === DisconnectReason.loggedOut ||
         reason === DisconnectReason.badSession ||
         !this.shouldReconnect(sessionId)
       ) {
         this.retries.delete(sessionId);

         const evPayload: WhatsappEventPayload = {
           sock,
           store,
           sessionId,
           reason,
         };

         this.ev.emit('wa::conn.logout', evPayload);

         return;
       }

       const reconnectInterval =
         reason === DisconnectReason.restartRequired ||
         reason === DisconnectReason.timedOut
           ? 0
           : this.clientConf.reconnectInterval;

       const evPayload: WhatsappEventPayload = {
         sock,
         store,
         sessionId,
         reason,
       };

       const undoRetries = this.undoRetries.get(sessionId);
       if (undoRetries) {
         console.info(
           'connection unstable! will perform retries...',
           JSON.stringify({
             reason: DisconnectReason[reason],
             sessionId,
             stableWaitTime: this.clientConf.stableWaitTime,
           }),
         );
         clearTimeout(undoRetries);
       }

       setTimeout(() => {
         this.ev.emit('wa::conn.reconnecting', evPayload);
       }, reconnectInterval);

       this.ev.emit('wa::conn.attempt_reconnect', evPayload);
     }

     if (connection === WAConnectionState.OPEN) {
       // it's possible to reconnecting again after connected
       // so need to delay for deleting retries until it's stable
       this.undoRetries.set(
         sessionId,
         setTimeout(() => {
           console.info(
             'connection stable! undoing retries...',
             JSON.stringify({
               sessionId,
               stableWaitTime: this.clientConf.stableWaitTime,
             }),
           );
           this.retries.delete(sessionId);
         }, this.clientConf.stableWaitTime),
       );

       const evPayload: WhatsappEventPayload = {
         sock,
         store,
         sessionId,
       };

       this.ev.emit('wa::conn.connected', evPayload);
     }
   };
 }

Pls Let me know this disconecting session related to my bad infra or the codes. Thanks

https://github.com/WhiskeySockets/Baileys/issues/860 I think it would be the same problem, but there is no solution yet.


Add support for security context propagation

When a client successfully authenticated against a JavaEE endpoint (e.g. Servlet or EJB) it should be possible to call into a secured camel route without having to put authentication code in the JavaEE component.
Currently we have to do this
@Stateless
@DeclareRoles({ "Role1", "Role2", "Role3" })
@LocalBean
@SecurityDomain("other")
public class AnnotatedSLSB {

    @Resource(name = "java:jboss/camel/context/secured-context")
    CamelContext camelctx;

    @Resource EJBContext ejbctx;

    @RolesAllowed({ "Role1" })
    public String secureRouteAccess(String msg) {

        Subject subject = new Subject();
        String username = ejbctx.getCallerPrincipal().getName();
        Principal principal = new UsernamePasswordAuthentication(username, PASSWORD.toCharArray());
        subject.getPrincipals().add(principal);

        ProducerTemplate producer = camelctx.createProducerTemplate();
        return producer.requestBodyAndHeader("direct:start", msg, Exchange.AUTHENTICATION, subject, String.class);
    }
}

The existing WildFly APIs don't offer a mechanism to obtain the password, partly because this is a bad practice but also because depending on how authentication occurred we may not even have a password available to use.
For WildFly 10 we are working on the WildFly Elytron project to formally support both trusted invocations from server to server and delegated authentication where the remote user has provided us with a credential that can be delegated.
Any code built around an assumption that a plain text password is even likely to be available is unlikely to be supported in the future, at every opportunity we are trying to eliminate the use of plain text passwords anywhere.
Authentication schemes that support trusted delegation or schemes where invocations can be trusted to be executed on the behalf of another user are going to be the preferred option going forwards.

Yes, makes sense. In that case we'd could associate an authentication/authorization policy with route that verifies an existing trusted invocation. If this route also needs to be called directly, the policy probably needs to do both authentication/authorization and (if already available) verification of an already existing trusted invocation.
Is that about right?

That is the pattern we are taking for the invocations server to server, either we can make use of an already established identity or if none is available a new authentication can be performed.

What about within the same deployment? Does this pattern apply in that case too?

What we are working on within the application server is really around where the call crosses an authorization boundary - so same deployment that crossing should be unlikely as it should be using the same SecurityDomain so the same identity can be used.  Where the in-vm crossing is to a component with a different SecurityDomain then there is going to need to be a translation to the new domain.

Ok great. This will feature will have to wait for WildFly10, right?

For anything security related unless it is critical you have a solution now waiting for WildFly 10 would be advisable, we have something in the region of 8 engineers currently working to replace the security architecture of the server.

Hi @darranl, a year later I'd like to revisit this.
Is it now possible to obtain some sort of security context from within a EJB3 method and pass that on to a secured Camel route?
In our code examples, we still have to pass in the credentials explicitly when calling into Camel. This should IMHO not be necessary because we are authenticated/authorized already.
@Stateless
@DeclareRoles({ "Role1", "Role2", "Role3" })
@LocalBean
@SecurityDomain("user-domain")
public class AnnotatedSLSB {

    public static final String PASSWORD = "appl-pa$$wrd2";

    @Resource(name = "java:jboss/camel/context/secured-context")
    CamelContext camelctx;

    @Resource EJBContext ejbctx;

    @RolesAllowed({ "Role2" })
    public String secureRouteAccess(String msg) {

        // [TODO #725] Add support for security context propagation
        Subject subject = new Subject();
        String username = ejbctx.getCallerPrincipal().getName();
        subject.getPrincipals().add(new DomainPrincipal("user-domain"));
        subject.getPrincipals().add(new EncodedUsernamePasswordPrincipal(username, PASSWORD.toCharArray()));

        ProducerTemplate producer = camelctx.createProducerTemplate();
        return producer.requestBodyAndHeader("direct:start", msg, Exchange.AUTHENTICATION, subject, String.class);
    }
}

ok, merci.

Blocked by WildFly-11


Right-click should pick a colour

Yes

y e s

YES

I made right-click do this, but it currently works kinda jankily I think... Gonna try out some improvements


built-in plugin ImportTableReplace cannot be enabled with compile parameter '-DPlugin.ImportTableReplace=ON'

use '-DPlugin.ImportTableReplace=ON' parameter to compile, but there is no DobbyImportTableReplace function in the compiled dynamic library.

https://github.com/jmpews/Dobby/blob/b0176de574104726bb68dff3b77ee666300fc338/builtin-plugin/CMakeLists.txt#LL1C4-L1C4
It looks like this CMake option is prepared for DobbyHook for the Darwin system.


reduce vulnerability

The solution would be in package.json to increase:
  "opencollective": "~1.0.3",

and
  "version": "0.18.2",

That would make it ready for when opencollective fixes opencollective/opencollective-cli#17.
It is annoying when left as only vulnerability in an npm install.

Yes, I get a warning when users install my lib:
javascript-obfuscator > opencollective > babel-polyfill ><EMAIL_ADDRESS>is no longer maintained and not recommended due to issues. Upgrade your dependencies to the actual version of core-js@>=3
Can we please do a version bump and a release.

Fixed in
https://github.com/javascript-obfuscator/javascript-obfuscator/pull/467


Helm chart certs not generated

Have a question? Please use Our Forum
What happened:
Pod never gets created.
secrets "tls-web" not found

What you expected to happen:
Pod to be created.
How to reproduce it (as minimally and precisely as possible):
Run the helm install without pre-creating tls certs for proxy service.

Hi Steven,
Can you please provide a little more information about the version and setup to re-create your setup.  It's hard to tell if this is a gravity or teleport issue, it could be related to this issue. https://community.gravitational.com/t/teleport-web-tls-certificates-no-pem-data-found/46

@stobias123 You’ll need to provide a TLS keypair as a Kubernetes secret called tls-web:
kubectl create secret tls tls-web --cert=cert.pem --key=key.pem

We should make this a little clearer in the documentation and maybe also look at auto-generating the keypair somehow if one isn’t provided.

@stobias123 You’ll need to provide a TLS keypair as a Kubernetes secret called tls-web:
kubectl create secret tls tls-web --cert=cert.pem --key=key.pem

We should make this a little clearer in the documentation and maybe also look at auto-generating the keypair somehow if one isn’t provided.
This is a Teleport issue so I’m unsure why this is raised against Gravity...


Cosmos: Coalesce works on undefined values rather than nulls

c["Region"] ?? "ZZ" gives value of ZZ only if c does not contain key Region. If c["Region"] has value of null the expression returns null rather than ZZ

We can consider blocking the translation, or doing the same translation we use for ternary operator.


Made the code more readable

Made needlessly explicit returns implicit, put variables in the format string, removed an unnecessary check when handling user input, decreased indentation depth, replaced a return true with a return of the result of the comparison.

Added the following modifications:
Derived Eq where possible for more flexibility, replaced the name of structs with Self in their functions for readability, made functions which don't influence other code const to add flexibility and readability, removed a clone of a String caused by a call to .to_owned(), made the start_playing function shorter by splitting it into multiple smaller functions, removed a redundant closure, removed async from a function without await, replaced an Option match with a map_or_else


virt-api: Authorizer checks non-resource endpoints

What this PR does / why we need it:
The authorizer in virt-api checks RBAC permissions to access a non-resource endpoints.
It is needed for the /apis/subresources.kubevirt.io/v1/expand-spec endpoint added in #7549.
This PR also contains functional tests to check the expand-spec endpoint.
Release note:
Virt-api checks RBAC permisisons to non-resource endpoints.

/test pull-kubevirt-e2e-k8s-1.22-sig-compute

/area instancetype

Closing. There will be another PR that fixes permissions for the expand-spec endpoint.
/close


[2.0] Update transform test to include bad meta bug

🚀 🚀 Pull Request
Checklist:

[x]  My code follows the style guidelines of this project and the Contributing document
[x]  I have commented my code, particularly in hard-to-understand areas
[x]  I have kept the coverage-rate up
[x]  I have performed a self-review of my own code and resolved any problems
[ ]  I have checked to ensure there aren't any other open Pull Requests for the same change
[x]  I have described and made corresponding changes to the relevant documentation
[ ]  New and existing unit tests pass locally with my changes

Changes
Modifies the transform test to use dynamic shapes and test that the shape range is set correctly. It isn't.
I don't have a fix, so I'm adding the test and handing off the task.

Closing this, had merged this branch into https://github.com/activeloopai/Hub/pull/1000 and have addressed this bug.


Use Java stdlib instead of guava

Follow-up to #19154

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

OK, I've already triggered a build for you.


pkg-config: modules list contains only OpenCV modules (fixes #5852)

#5852

is opencv.pc generated only for shared libraries?

All is fine here, except global problem with uncareful and wrong dependencies processing.

:+1:


Suppress undefined to default diffs on aws.autoscaling.Group

Fix a regression in the import experience on aws.autoscaling.Group. Specifically the conflict between undefined and default values that pulumi import used to detect is no longer a conflict by automatically injecting DiffSuppressFunc for the relevant properties.
Fixes #4457

I was a little surprised but TransformOutputs hook works well. It is able to eliminate the default values from the printed imported program which is good, and it also fixes the issue. The ability to be certain about undefined vs null vs empty is much appreciated. I think it also bypasses the problem with hypothetical defaults change.

I've tested refresh and import_ option manually, seem to work as well for this with these changes.


eqx.filter_shard; test + update examples/parallelism.ipynb

Hi Patrick,
Please pardon the terrible git practice if I've made some mistakes. I tend to work alone in my daily projects :)
I've

added equinox/_sharding.py with eqx.filter_shard as per the issue thread from the other day,
added a test tests/test_sharding.py that tests the function on sharding an eqx.nn.MLP in and outside of eqx.filter_jit,
changed the examples/parallelism.ipynb example to have the same content as the same file in your PR you weren't sure about, with the corresponding changes made.

Let me know what you think, again, sorry if the git stuff is wrong!
Cheers,
Jed

Alright, this LGTM! That is, modulo David's concern back in #688. Let's double check with things over there before we merge this.

Okay, looks like the discussion has settled, so merging! Thank you for putting this together, and I'm excited to have this in the next release of Equinox! :)

Cheers Patrick! Hope to contribute again :)


Upstream main

Any reason you're doing this via PRs? As far as I know updating branches based on another branch doesn't require pull requests, especially if its updating from the main branch

Yes, but it's just 2 clicks to update a dev branch to latest main changes via PR. So, why not staying up-to-date?

Oh I totally agree to update the dev branch. I just mean, couldn't we just merge without the PR?

GitHub creates a PR by itself. BTW it's just a rough sketch https://dev.bootscore.me/shop/ but let me know what you think.


Fixed #32309 -- Added --exclude option to template management command.

ticket-32309.

@laymonage Do you have time to keep working on this?

Hey @felixxm,
Sure, but I'd like to know whether the proposed solution is acceptable or if there's a better alternative.

@carltongibson's and @rfleschenberg's reactions were positive, so IMO you have the green light :traffic_light:

@felixxm Okay, I'll try adding tests and docs this weekend.

@laymonage Thanks for this patch :+1:
I pushed small edits and moved extra test coverage to a separate commit.

Thanks! 🎉


Decorator for function based views

I'm not sure which file this decorator should have been included in. I also had to rename the folder (module) because Python doesn't allow you to import modules with a dash in the name. In any case, I will appreciate your feedback and will correct everything that is necessary.

@Leelith i'll check this out soon. Anyways thank you for helping me!

@Leelith , I'm just committed to updates that I consider essential.
I've put the decorator out from middleware.py
The @keycloak_roles I've kept simpler like this:
@keycloak_roles(['director', 'judge', 'employee']) -> I removed the request method because this decorator code was redundant.
The way you did it, you were going through the process_view method twice.
Look at README.md how to test this lib locally, including Keycloak docker-compose (if you want)

@keycloak_roles(['director', 'judge', 'employee']) -> I removed the request method because this decorator code was redundant.

what if we need function with api_view that allows two methods, for example GET and POST, but we need different accepted roles for them?
I also saw that the decorator code was similar to what was proposed in one of the issues, but there, as I understood, the task was to add a decorator for methods inside the APIView class, for example. and here I needed role checking for functions when we don't have a view class 🙂  https://www.django-rest-framework.org/api-guide/views/#api_view
if you decide to add the functionality described in that issue (that is, we must have a view class and cannot work with independent functions), then we need to fix the readme. I hope I understood everything correctly and was able to explain

@keycloak_roles(['director', 'judge', 'employee']) -> I removed the request method because this decorator code was redundant.

what if we need function with api_view that allows two methods, for example GET and POST, but we need different accepted roles for them? I also saw that the decorator code was similar to what was proposed in one of the issues, but there, as I understood, the task was to add a decorator for methods inside the APIView class, for example. but here I needed role checking for functions when we don't have a view class 🙂 https://www.django-rest-framework.org/api-guide/views/#api_view
if you decide to add the functionality described in that issue (that is, we must have a view class and cannot work with independent functions), then we need to fix the readme. I hope I understood everything correctly and was able to explain

So... I'd think it better to create another POST method (I think it would be more elegant code)
For example:
from django_keycloak_auth.decorators import keycloak_roles

@keycloak_roles(['director', 'judge', 'employee'])
@api_view(['GET'])
def loans_get(request):
    return JsonResponse({"message": request.roles})

@keycloak_roles(['director'])
@api_view(['POST'])
def loans_post(request):
    return JsonResponse({"message": request.roles})

or you can do this:
from django_keycloak_auth.decorators import keycloak_roles

@keycloak_roles(['director', 'judge', 'employee'])
@api_view(['GET','POST'])
def loans(request):
    if request.method == 'GET':
        if('judge' in request.roles):
             return JsonResponse({"message": "judge permission"})

    if request.method == 'POST':
        if('director' in request.roles):
             return JsonResponse({"message": "director permission"})

You don't need to describe the view class, according to this example in the README file. Behind the scenes, the Function Based Views already used implicit core.views.WrappedAPIView, in other words, you don't need to declare as class. This is an optional declaration.
What do you think about it?


temperatureFilePath Temperature Rounding incorrectly

cubilon has mentioned this already in #334 but I can't see an associated issue anywhere else. If there is one, let me know.
The issue is that when reading the current temperature from a file there isn't any rounding. The temperature is simply concatenated. For example, if the temperature is 18.9 it shows in the Home App as 18 when it should be rounding up to 19.
I've been able to get around this by adding 0.5 to the temperature when I'm outputting (awk '{print $1+0.5}') it but now I'm wanting to use the same value elsewhere so I'd prefer to have the correct value in the file.

It's not plugin's fault, it's just HomeKit taking the integer part of the value.
which is your source?

That integer rounding doesn’t match the explanation of Homekit’s rounding in the plugin documentation:

Bare in mind that while the Home app may say 22C, the temperature may actually be 22.4C and if the Home app says 23C then it may actually be 22.5C.

Also, I’m using the homebridge-temperature-file plugin which rounds correctly using the same file.

What I meant is that HomeKit doens't round the value.

Hi @cubilon . I thought I'd give you an update on this. I've been doing a bit of "tweaking" under @AlexanderBabel's fork here: https://github.com/AlexanderBabel/homebridge-broadlink-rm/pull/30. The two main changes I've made are: support for {mode}{temperature} hex codes in the configuration (so you can have a hexcode for cooling to 22, and another for heating to 22) and sorting out this issue. What I've done is update the Broadlink RM platform to pass the temperature to Homebridge with a decimal value so HomeKit can handle the rounding.
If you're interested, take a look at the fork (which includes TV support) and my Pull Request. You can install straight from my pull request using:
npm install -g git+https://github.com/AlexanderBabel/homebridge-broadlink-rm#pull/30/head
@AlexanderBabel has said that he'll merge my changes into his fork in the near future too.

Fixed in the latest release.


[BUG] CI - GenerateReleaseArtifacts job failing.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=331226&view=logs&jobId=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d
I think it does not block merging, but, still wondering why we are using that task for?  and if we really need it?

great! thank you!