IndexError: list index out of range

I have trained and saved a model and want to convert it to SNN by using SpKeras, but after running the code to convert I am facing the following issue:
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Input In [10], in <cell line: 7>()
      2 from spkeras.spkeras.models import cnn_to_snn
      4 #Current normalisation using cnn_to_snn
      5 ##Default: signed_bit=0, amp_factor=100, method=1, epsilon = 0.001
----> 7 snn_model = cnn_to_snn(signed_bit=0)(cnn_model,x_train)

File ~/Desktop/Toy network/spkeras/spkeras/models.py:29, in cnn_to_snn.__call__(self, mdl, x_train)
     27 self.use_bias = use_bias
     28 self.get_config()
---> 29 self.model = self.convert(mdl,x_train,
     30                           thresholding = self.thresholding,
     31                           scaling_factor = self.scaling_factor,
     32                           method = self.method,
     33                           timesteps=self.timesteps)
     35 return self

File ~/Desktop/Toy network/spkeras/spkeras/models.py:101, in cnn_to_snn.convert(self, mdl, x_train, thresholding, scaling_factor, method, timesteps)
     98     _weights[0] = _weights[0].astype(int)
     99     _weights[0] = _weights[0]/2**bit
--> 101 _bias = kappa*_weights[1]/lmax[num+1]
    102 _bias = _bias/norm
    103 bias.append(_bias.tolist())

IndexError: list index out of range

My model:
Model: "model"
_________________________________________________________________
 Layer (type)                Output Shape              Param #
=================================================================
 input_1 (InputLayer)        [(None, 32, 32, 3)]       0

 conv2d (Conv2D)             (None, 32, 32, 4)         16

 conv2d_1 (Conv2D)           (None, 16, 16, 64)        2368

 conv2d_2 (Conv2D)           (None, 16, 16, 72)        41544

 conv2d_3 (Conv2D)           (None, 8, 8, 256)         166144

 conv2d_4 (Conv2D)           (None, 8, 8, 256)         65792

 conv2d_5 (Conv2D)           (None, 8, 8, 64)          16448

 flatten (Flatten)           (None, 4096)              0

 dropout (Dropout)           (None, 4096)              0

 dense (Dense)               (None, 100)               409700

 dense_1 (Dense)             (None, 10)                1010

=================================================================
Total params: 703,022
Trainable params: 703,022
Non-trainable params: 0

Any solutions ?
I also tried solving it by referring to this, but I wasn't able to.

Try adding the Activation Layer after Conv2D and Dense, such as,
inputs = Input((32, 32, 3))
x = Conv2D()(inputs)
x = Activation("relu")(x)
The problem is due to that SpKeras counts Activation layer for conversion.

I did that, but still facing the same issue.
My code:
input_shape = (32, 32, 3)
input_layer = Input(input_shape)

layer = Conv2D(filters=4,
               kernel_size=(1, 1),
               strides=(1, 1),
               padding="same", use_bias=False)(input_layer)

layer = tf.keras.activations.relu(layer, alpha=0.0, max_value=None, threshold=0.0)

layer = Conv2D(filters=64,
               kernel_size=(3, 3),
               strides=(2, 2),
               padding="same", use_bias=False)(layer)

layer = Conv2D(filters=72,
               kernel_size=(3, 3),
               strides=(1, 1),
               padding="same", use_bias=False)(layer)

layer = tf.keras.activations.relu(layer, alpha=0.0, max_value=None, threshold=0.0)

layer = Conv2D(filters=256,
               kernel_size=(3, 3),
               strides=(2, 2),
               padding="same", use_bias=False)(layer)

layer = Conv2D(filters=256,
               kernel_size=(1, 1),
               strides=(1, 1),
               padding="same", use_bias=False)(layer)

layer = tf.keras.activations.relu(layer, alpha=0.0, max_value=None, threshold=0.0)

layer = Conv2D(filters=64,
               kernel_size=(1, 1),
               strides=(1, 1),
               padding="same", use_bias=False)(layer)

layer = Flatten()(layer)

layer = Dropout(0.5)(layer)

layer = Dense(units=100)(layer)

layer = tf.keras.activations.relu(layer, alpha=0.0, max_value=None, threshold=0.0)

layer = Dense(units=10)(layer)

layer = tf.keras.activations.softmax(layer, axis=-1)

model = Model(input_layer, layer)

My model summary:
Model: "model"
_________________________________________________________________
 Layer (type)                Output Shape              Param #
=================================================================
 input_1 (InputLayer)        [(None, 32, 32, 3)]       0

 conv2d (Conv2D)             (None, 32, 32, 4)         12

 tf.nn.relu (TFOpLambda)     (None, 32, 32, 4)         0

 conv2d_1 (Conv2D)           (None, 16, 16, 64)        2304

 conv2d_2 (Conv2D)           (None, 16, 16, 72)        41472

 tf.nn.relu_1 (TFOpLambda)   (None, 16, 16, 72)        0

 conv2d_3 (Conv2D)           (None, 8, 8, 256)         165888

 conv2d_4 (Conv2D)           (None, 8, 8, 256)         65536

 tf.nn.relu_2 (TFOpLambda)   (None, 8, 8, 256)         0

 conv2d_5 (Conv2D)           (None, 8, 8, 64)          16384

 flatten (Flatten)           (None, 4096)              0

 dropout (Dropout)           (None, 4096)              0

 dense (Dense)               (None, 100)               409700

 tf.nn.relu_3 (TFOpLambda)   (None, 100)               0

 dense_1 (Dense)             (None, 10)                1010

 tf.nn.softmax (TFOpLambda)  (None, 10)                0

=================================================================
Total params: 702,306
Trainable params: 702,306
Non-trainable params: 0
_____________________________

Can you change
layer = tf.keras.activations.relu(layer, alpha=0.0, max_value=None, threshold=0.0)
into
layer=Activation('relu')(layer)
and try again.

Have you changed
layer = tf.keras.activations.softmax(layer, axis=-1)
into
layer=Activation('softmax')(layer)
as well

Yes, below is my code for the architecture:
input_shape = (32, 32, 3)
input_layer = Input(input_shape)

layer = Conv2D(filters=4,
               kernel_size=(1, 1),
               strides=(1, 1),
               padding="same", use_bias=False)(input_layer)

layer=Activation('relu')(layer)

layer = Conv2D(filters=64,
               kernel_size=(3, 3),
               strides=(2, 2),
               padding="same", use_bias=False)(layer)

layer=Activation('relu')(layer)

layer = Conv2D(filters=72,
               kernel_size=(3, 3),
               strides=(1, 1),
               padding="same", use_bias=False)(layer)

layer=Activation('relu')(layer)

layer = Conv2D(filters=256,
               kernel_size=(3, 3),
               strides=(2, 2),
               padding="same", use_bias=False)(layer)

layer=Activation('relu')(layer)

layer = Conv2D(filters=256,
               kernel_size=(1, 1),
               strides=(1, 1),
               padding="same", use_bias=False)(layer)

layer=Activation('relu')(layer)

layer = Conv2D(filters=64,
               kernel_size=(1, 1),
               strides=(1, 1),
               padding="same", use_bias=False)(layer)

layer=Activation('relu')(layer)

layer = Flatten()(layer)

layer = Dropout(0.05)(layer)

layer = Dense(units=100)(layer)

layer=Activation('relu')(layer)

layer = Dense(units=10)(layer)

layer=Activation('softmax')(layer)

model = Model(input_layer, layer)

Did you normalise your input into [0,1]?

Hi, I did normalize the input into [0,1] but due to some reasons it didn't get normalized. But now after normalizing it properly I am getting a good accuracy (65.47 %) as compared to before but is not that good. Do you have any suggestions in order to improve my SNN accuracy ?

You can refer the our paper to include BatchNormalisation Layer and clipping methods to improve conversion efficiency.

Okay, I will read that. Thank you for the suggestion and your help!


Persist user profile edits to database

What's this PR do?

Connects profile editing to backend
A user can update their info and it will be saved to the database

Known issues

Profile photo not re-rendering after uploading (it will render correctly on subsequent logins)

User profile description not re-rendering (will NOT re-render on subsequent logins)

User shipping address information not re-rendering (and NOT on subsequent logins either)

Where should the reviewer start?
Anywhere!
How should this be manually tested?
Clone down the branch.
Before starting the backend in api, run npm run db:reset && npm run test:reset
Manually update profile data, while checking in Postico that information persists.
Any background context you want to provide?
This is our MVP --> that data can be written into the database.
There are some rendering bugs that we can work on after the code freeze (as it is not NEW feature code, it is BUGFIXES)
Two test suites have been skipped.
What are the relevant tickets?
closes #30
closes #31
closes #33
closes #34
closes #53
closes #38
Screenshots (if appropriate)

I'm so thankful we got this done. Thank you for driving and finishing up the code. It takes such a great deal of patience while driving. You rock AJ!


Move product special price to other table

is this a duplicate of "Create an history of discount data"?

Due to the simplicity and performance, we decided to keep those fields in the Product


Make it possible to have a nested form that uses composition.

For example, collection :invitations, form: InvitationForm, where InvitationForm uses composition.
Whenever I try this, I get this error: relationship delegated to invitation.relationship, but invitation is nil.
How do we get invitation to not be nil?

Ran into this today. This seems like a very common use of form reuse. The example in the docs puts a collection of songs in the module and then includes that, which seems odd… It seems like the intuitive behavior would be to create a form for Song then in an AlbumForm create a collection that reuses the SongForm.
(Maybe that works today, but I can't test that because I'm using composition and thus ran into this issue.)
Is there a way to use a modular form that uses Composition in a collection in another form yet?

@contentfree Can you make an example of how your data model and the form configuration would look like? How would the nested composition collection know how to find the contained elements?

Closing this as it's not been updated for rather a long time. Feel free to reopen if you need!


intro page on wiki needs to be updated for latest CSS frameworks

https://github.com/retlehs/roots/wiki/Introduction needs to be updated to include info on all the frameworks that are now in roots

blueprint css
960gs
1140 grid
adapt
less
foundation
bootstrap

Foundation and Boostrap info have been added

ty sir


@JsonCodec encodeOnly/decodeOnly support

We can now supply arguments to @JsonCodec to signal to only derive an Encoder or Decoder instance. This is useful in cases where we can derive one but can't derive the other but still would prefer to use the macro annotation to avoid boilerplate.
The macro annotation requires that if you supply an argument, you must explicitly specify encodeOnly or decodeOnly and they must be set to true.  Supporting anything else is a bit pointless.
I've added test cases which demonstrate this behavior.

Codecov Report

Merging #631 into master will decrease coverage by 77.59%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #631      +/-   ##
=========================================
- Coverage   83.75%   6.15%   -77.6%
=========================================
  Files          70      70
  Lines        2080    2081       +1
  Branches      151     149       -2
=========================================
- Hits         1742     128    -1614
- Misses        338    1953    +1615

Impacted Files
Coverage Δ

...ed/src/main/scala/io/circe/generic/JsonCodec.scala
100% <ø> (ø)
:arrow_up:

...io/circe/generic/util/macros/JsonCodecMacros.scala
100% <100%> (ø)
:arrow_up:

...ed/src/main/scala/io/circe/disjunctionCodecs.scala
0% <0%> (-100%)
:arrow_down:

.../circe/generic/encoding/DerivedObjectEncoder.scala
0% <0%> (-100%)
:arrow_down:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
0% <0%> (-100%)
:arrow_down:

...hared/src/main/scala/io/circe/syntax/package.scala
0% <0%> (-100%)
:arrow_down:

...scala/io/circe/generic/util/PatchWithOptions.scala
0% <0%> (-100%)
:arrow_down:

...e/generic/extras/decoding/EnumerationDecoder.scala
0% <0%> (-100%)
:arrow_down:

.../main/scala/io/circe/optics/JsonNumberOptics.scala
0% <0%> (-100%)
:arrow_down:

...ared/src/main/scala/io/circe/refined/package.scala
0% <0%> (-100%)
:arrow_down:

... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b573f9...69c50be. Read the comment docs.

@travisbrown - Ok, my latest push fixes the build.

Thanks @carymrobbins—sorry for the long delay on review, but I'm planning an early 0.9.0-M1 by the end of the weekend and will get this in.

Merged in #681.


[INLONG-3773][Sort-Standalone] Support configurable handler to transform data of Kafka

Title Name: [INLONG-3773][Sort-Standalone] Sort-Standalone support a configurable handler to transform data of Kafka Sort.
Fixes #3773
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)

[ ] This change is a trivial rework/code cleanup without any test coverage.

[ ] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Rebase error, add new PR:https://github.com/apache/incubator-inlong/pull/3902;
This PR will close.


feat(tuya): Quirk for tuya-based 1-channel switch

Quirk for Tuya-based 1-gang switches with neutral (e.g. Lerlink, Lonsonho).
https://zigbee.blakadder.com/Lerlink_X701A.html
Manufacturer cluster should support also 2, 3-gang versions so more devices can be easily added in future (by adding proper manufacture name)
Credits to zigbee-herdsman-converters (https://github.com/Koenkk/zigbee-herdsman-converters)

This looks good.
Can you update PR description?

Done.

Can we also add this model which is the same wireless
TS0041
{
"node_descriptor": "",
"endpoints": {
"1": {
"profile_id": 260,
"device_type": "0x0000",
"in_clusters": [
"0x0000",
"0x0001",
"0x0006"
],
"out_clusters": [
"0x000a",
"0x0019"
]
}
},
"manufacturer": "_TZ3400_keyjqthh",
"model": "TS0041",
"class": "zigpy.device.Device"
}

Signatures (input and output clusters) look to be different than TS0601.
Unfortunately I do not have such devices to test - so better create dedicated feature request for that.
For "_TZE200_8vxj8khv" it should be enough to add entry in MODELS_INFO for other deeper investigation is necessary.


Commits not kicking off TravisCI builds; showing up as failed requests?

Closed - I needed to merge commits to master in order to kick of Travis CI - thx.


Add the description of the --plugin-file

Describe your use-case which is not covered by existing documentation
In PR #86, we introduced a new feature that allows parsing an existing plugin file and applying recipes to the list of plugins contained within it. However, this functionality is not yet described in the current documentation.
Specifically, the documentation should cover:

How to use the new feature to parse an existing plugin file
The format requirements for the plugin file
How to apply recipes to the list of plugins extracted from the file
Any limitations or considerations when using this approach

This additional documentation would help users understand and utilize the new functionality effectively, especially those who manage multiple plugins and want to streamline the modernization process.
By updating the documentation to include this use-case, we can ensure that users are aware of all available options and can choose the most efficient method for their specific needs.
Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.
No response
Are you interested in contributing to the documentation?
No response

Will update the docs after adding --jenkins-uc option

Please add documentation for --jenkins-uc too.

sure


translate pipe doesn't work for dynamic translation files when we use 'use' function (change the current language)

Hello. Thank you for the amazing library!
Current behavior
Our project has dynamic translation files loading for lazy-loading modules. This fine-tuning is obtained by implementing custom AppMissingTranslationHandler, which requests missing translations from custom TranslateLoader implementation.
Problem is reproduced when we use the translate pipe in our templates and if we change the language => those template parts where we use translate pipe do not get a new translation (they obtain that ones which were for default language)
Important note:
If we use setDefaultLang instead of use problems do not reproduce
Steps to reproduce:

Language by default - for example ‘en';
Open a web page where there are several lazy-loading modules;
MissingTranslationHandler helps us load additional translations for the default language;
We have some translation string in template: 'SOME_TRANSLATION' | translate
Change the language through the menu - for example to 'es';
Inside the library a language change takes place and as a result: currentLang has a new value and is equal to the selected language ('es'), we have loaded the base translation file (not lazy-loading) and get the onLangChange event =>
Inside pipe: translate.pipe.ts
we got new event from onLangChange and call updateValue();

Issues:
First issue - getParsedResult returns default value, not new one for currentLang (for the complex case of retrieving a translation from the MissingTranslationHandler)
Second issue - in pipe:  onTranslation function executed twice
Third issue - in pipe - updateValue has invalid condition: isObservable(res.subscribe)
Expected behavior
When we switch translations using the use function from the TranslateService we get a new translations for our templates where we are using translate pipe, even if the translation is taken from lazy-loading files.
How do you think that we should fix this?
First issue - getParsedResult returns default value, not for currentLang (for the complex case of retrieving a translation from the MissingTranslationHandler)
translate.pipe.ts
 updateValue(key: string, interpolateParams?: Object, translations?: any): void {
    ...
    if (translations) {
      let res = this.translate.getParsedResult(translations, key, interpolateParams);
      if (isObservable(res.subscribe)) {
        res.subscribe(onTranslation);
      } else {
        onTranslation(res);
      }
    }
    this.translate.get(key, interpolateParams).subscribe(onTranslation);
  }

here we have translations equal the base file with translations (no lazy-loading files) so we go into the if(translations) block and get res by getParsedResult execution
translate.service.ts

  public getParsedResult(translations: any, key: any, interpolateParams?: Object): any {
    let res: string | Observable<string> | undefined;
    ...

    // until the translations for the new language are not loaded res variable equals 'undefined'
    if (translations) {
      res = this.parser.interpolate(this.parser.getValue(translations, key), interpolateParams);
    }

    // (!!!) main problem - all conditions are fulfilled and
    // res variable gets a value equal to the translation from the default language, although it should remain 'undefined' in order to load the needed translations by the missingTranslationHandler in the next step
    // useDefaultLang - has a place to use, but it should be possible to use it for the missingTranslationHandler if we do not get a correct translation there
    if (typeof res === "undefined" && this.defaultLang != null && this.defaultLang !== this.currentLang && this.useDefaultLang) {
      res = this.parser.interpolate(this.parser.getValue(this.translations[this.defaultLang], key), interpolateParams);
    }

    if (typeof res === "undefined") {
      let params: MissingTranslationHandlerParams = {key, translateService: this};
      if (typeof interpolateParams !== 'undefined') {
        params.interpolateParams = interpolateParams;
      }
      res = this.missingTranslationHandler.handle(params);
    }

    return typeof res !== "undefined" ? res : key;
  }

see comments above in snippet
Issue:
res variable gets an invalid value equal to the value from the default translations, although we already have a different current language
Possible solution: Perhaps We should be able to avoid useDefaultLang check before missingTranslationHandler execution here and add the ability to handle this case after missingTranslationHandler fails

Second issue
translate.pipe.ts
 updateValue(key: string, interpolateParams?: Object, translations?: any): void {
    ...
    if (translations) {
      let res = this.translate.getParsedResult(translations, key, interpolateParams);
      if (isObservable(res.subscribe)) {
        res.subscribe(onTranslation);
      } else {
        onTranslation(res);
      }
    }
    this.translate.get(key, interpolateParams).subscribe(onTranslation);
  }

Everything in the translation block has the same logic as in this.translate.get(key, interpolateParams).subscribe(onTranslation);
=> we have the onTranslation function executed twice (because translations === this.translations[this.currentLang] from get function)
Third issue
the same pipe and the same snippet as above:
 if (isObservable(res.subscribe)) {
I think there is a flaw here. Here should be not isObservable(res.subscribe), only isObservable(res) according to the same logic as in this.translate.get(...) function;
getParsedResult - should return Observable or string
Environment

ngx-translate version: 14.0.0
Angular version: 15.0.2

Browser:
- [ 112.0.5615.137 ] Chrome (desktop) version XX

I also have the same issue with even if I use setDefaultLang, I figure it out and I don't know if it's a good practice to do it, what I did was to use setDefaultLang but in the app.component and shared service with the app.component and use a var to set the Language. Any update on this issue please let me know.


Node configuration warning doesn't update immediatly on the scene dock

Godot version
v4.0.2.stable.official [7a0977ce2]
System information
Windows 11
Issue description
Warning doesn't show immediatly on scene dock when update_configuration_warnings() is called
Steps to reproduce
Copy-paste this script to any node and restart the editor (so the script become is active in the editor)
@tool
extends Node

func _get_configuration_warnings():
	#return ["first warning, second warning"]
	#return ["new warning"]
	return []

func _process(_delta):
	update_configuration_warnings()

Change the return value of _get_configuration_warnings() and save the script, the warning will update only after you do something in the scene dock.
If you already have a warning and change it, you will se the updated warnings when you click the warning icon, but when you hover the mouse over the warning icon, it will show the old warning.
Minimal reproduction project
N/A

This is not a correct way to update warnings 🙃
update_configuration_warnings() calls this method:
https://github.com/godotengine/godot/blob/da21cb7042b09de24964b9bd5a1a8e1d93ab4b8b/editor/gui/scene_tree_editor.cpp#L1353-L1356
The tree is refreshed after the timer finishes, but if you call it every frame, the method will keep restarting the timer.
This could be maybe documented, but calling this method every frame is obviously wasteful, so not sure if it's worth it 🤔

This is not a correct way to update warnings 🙃 update_configuration_warnings() calls this method:
https://github.com/godotengine/godot/blob/da21cb7042b09de24964b9bd5a1a8e1d93ab4b8b/editor/gui/scene_tree_editor.cpp#L1353-L1356
The tree is refreshed after the timer finishes, but if you call it every frame, the method will keep restarting the timer.
This could be maybe documented, but calling this method every frame is obviously wasteful, so not sure if it's worth it 🤔

Met the same problem: was using it in _process, and thanks to your comment I moved it in a setget and fixed the issue.
I think a simple "don't use this every frame because it uses a timer: we suggest to use it in setgets" or something along these lines would be good enough


Encountering Issue on Version 2024.4

I have no idea what it means, but I think it might be in relevance to the post above. Good Luck.

Sorry, meant earlier post that was on May 22nd by Hr-Ravn).

Fixed


Hard Coded single-transition in forms

When $input-include-glowing-effect is false, we've got a hard-code single-transition. I know i could just override the class, butIt would be nice if we could get some variables to customize it in settings.
@include single-transition(all, 0.15s, linear);
I could probably submit a PR for it, if there is interest.

@khanh Yes, please on the PR ;)

Closing for PR, thanks!


Update enable-authentication-angular-spa-app.md

fixed minor typo.

@CarolineChiari : Thanks for your contribution! The author(s) have been notified to review your proposed change. @msmimart


Dashboard v2

Migrates the Treasury Dashboard to Ottopia 🥳

@otterclamking I have moved the endpoints to the Backup graph, which needs to be synced to the latest version of the pull request https://github.com/OtterClam/otter-subgraph/pull/16
Also requires some translations please ♥

LGTM


Added link feedback

Updated version to 2.0.3.
Added some typographic hierarchy

Can you review again @thibmaek


feat(ingest/airflow): able to set platform_instance in Dataset

Dataset entity has platform_instance field, but until now, we are not able to set it in airflow plugin' Dataset model.
Checklist

[X] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[X] Links to related issues (if applicable)
[X] Tests for the changes have been added/updated (if applicable)
[X] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz @treff7es please help me run the CI


how to format timebased axis

When i use Date Histogram as X axis like below:

the heatmap only show limited characters of the time:

my full time example is:
 "@timestamp": "2016-09-14T21:34:51.424Z"
is there anyway i can format the time in x axis?
thanks!

This is a duplicate of #28. Its currently on my roadmap to get fixed.


Reference to old Azure Security Benchmark

this page references to the old Azure Security Benchmark that should be changed to the Microsoft Cloud Security Benchmark

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b9d7741b-cd5a-29b0-c360-e054f7686c87
Version Independent ID: f03434f5-504a-d87f-b9ce-3ed695db9227
Content: Secure score - Microsoft Defender for Cloud
Content Source: articles/defender-for-cloud/secure-score-security-controls.md
Service: defender-for-cloud
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

@mcteufelms
Thanks for your feedback! We will investigate and update as appropriate.

@mcteufelms
Already our Microsoft team as create pull request, once author is approved the changes will go alive soon for published.
Please refer Meta data for this document which reference the changes here.
https://github.com/MicrosoftDocs/azure-docs-pr/blob/main/articles/defender-for-cloud/secure-score-security-controls.md
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@mcteufelms
Thanks for reporting this! We have created a new PR for this issue and the changes should go live soon.


Test improvement

Codecov Report

Merging #4 (62c3036) into main (63924c5) will increase coverage by 10.75%.
The diff coverage is n/a.

:exclamation: Current head 62c3036 differs from pull request most recent head 36e82c7. Consider uploading reports for the commit 36e82c7 to get more accurate results

@@             Coverage Diff              @@
##             main        #4       +/-   ##
============================================
+ Coverage   89.24%   100.00%   +10.75%
============================================
  Files          20        20
  Lines          93        94        +1
  Branches       10         7        -3
============================================
+ Hits           83        94       +11
+ Partials       10         0       -10

Impacted Files
Coverage Δ

src/index.ts
100.00% <0.00%> (+12.50%)
:arrow_up:

src/components/person/first-name.ts
100.00% <0.00%> (+16.66%)
:arrow_up:

src/helpers/adjust-lang-code.ts
100.00% <0.00%> (+21.42%)
:arrow_up:

src/helpers/one-of.ts
100.00% <0.00%> (+25.00%)
:arrow_up:

src/components/person/full-name.ts
100.00% <0.00%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f5d1d...36e82c7. Read the comment docs.


Agent starts speaking earlier, in prejoin screen

Not sure if this is relevant to agents or components library, but let's say I have a command like await agent.say("") in entrypoint of agent, even then if someone joins the meet through prejoin screen, our agent speaks before they can join in the room
essentially what happen then, is when user joins the agent start speaking from middle of sentence (as it has already spoke first parts when user was in prejoin)
Any way to mitigate this?

on the prejoin screen, is your app connecting to a room?
the purpose of a prejoin screen is so that user could adjust settings before connecting to the room, so during that time no agent would be dispatched

essentially what happen then, is when user joins the agent start speaking from middle of sentence (as it has already spoke first parts when user was in prejoin)
Any way to mitigate this?

I believe the default scheduler activates whenever the first participant connects to the room. If you need a little more latency, you could always insert a sleep or wait for the client to send a message over a data channel before the agent.say call.


⚠ Samsung has degraded performance

In 0d8e01b, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2287 ms

Resolved: Samsung performance has improved in 0af7510.


Setup end-to-end smoke test for a release binary

Release binaries differ from debug ones in that they are trimmed. Trimming can cause certain methods to be removed and reflective calls can fail at runtime. This is related to #148. The recent example of a failure is this. The homebrew formula has a short script that runs the server, sends an init request and checks the response. Would be great to add something like this to Marksman's CI

Another case where an end-to-end test would be helpful is #191


truncate() raises IndexError on large timeseries

Hi,
I found a bug, tested on pandas 0.16 and 0.17.  On large time series, the truncate() method throws an IndexError.
These are converted to dates (but incorrectly).
want to do a pull-request to fix?

so for integer indexes, I should use .loc[start:end] ?
And check myself first if the start and end are contained in the index (raises an IndexError if not)?
I'll think about the pull-request.  I'm not a pandas developer yet, but maybe it's a good start and it will teach me a thing or two :-)

integer indexing is via iloc
docs are http://pandas.pydata.org/pandas-docs/stable/indexing.html

@jreback Could you describe the expected behaviour?
The description of def truncate(self, before=None, after=None, axis=None, copy=True) refers to dates, while the implementation (and the comment in truncate) uses slice on ax (only converting before/after if ax.is_all_dates)

if this is not a dateindex the this should raise

There are a number of tests failing after changing this (as per below), as they use truncate on non datetime indexes ...
https://travis-ci.org/gliptak/pandas/jobs/125287589
======================================================================

ERROR: test_truncate (pandas.tests.test_panel.TestLongPanel)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/gliptak/pandas/pandas/tests/test_panel.py", line 48, in wrapper

    return func(self, *args, **kwargs)

  File "/home/travis/build/gliptak/pandas/pandas/tests/test_panel.py", line 2409, in test_truncate

    trunced = self.panel.truncate(start, end).to_panel()

  File "/home/travis/build/gliptak/pandas/pandas/core/generic.py", line 4622, in truncate

    raise TypeError("not ax.is_all_dates")

TypeError: not ax.is_all_dates

======================================================================

ERROR: test_truncate_fillna_bug (pandas.tests.test_panel.TestPanel)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/gliptak/pandas/pandas/tests/test_panel.py", line 1558, in test_truncate_fillna_bug

    result = self.panel.truncate(before=None, after=None, axis='items')

  File "/home/travis/build/gliptak/pandas/pandas/core/generic.py", line 4622, in truncate

    raise TypeError("not ax.is_all_dates")

TypeError: not ax.is_all_dates

https://travis-ci.org/gliptak/pandas/jobs/125287587
======================================================================

ERROR: testOLSWithDatasets_copper (pandas.stats.tests.test_ols.TestOLS)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/gliptak/pandas/pandas/stats/tests/test_ols.py", line 92, in testOLSWithDatasets_copper

    self.checkDataSet(sm.datasets.copper.load())

  File "/home/travis/build/gliptak/pandas/pandas/stats/tests/test_ols.py", line 150, in checkDataSet

    self.checkMovingOLS('rolling', x, y)

  File "/home/travis/build/gliptak/pandas/pandas/stats/tests/test_ols.py", line 209, in checkMovingOLS

    x_iter[k] = v.truncate(before=prior_date, after=date)

  File "/home/travis/build/gliptak/pandas/pandas/core/generic.py", line 4622, in truncate

    raise TypeError("not ax.is_all_dates")

TypeError: not ax.is_all_dates

======================================================================

ERROR: testOLSWithDatasets_scotland (pandas.stats.tests.test_ols.TestOLS)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/gliptak/pandas/pandas/stats/tests/test_ols.py", line 96, in testOLSWithDatasets_scotland

    self.checkDataSet(sm.datasets.scotland.load())

  File "/home/travis/build/gliptak/pandas/pandas/stats/tests/test_ols.py", line 150, in checkDataSet

    self.checkMovingOLS('rolling', x, y)

  File "/home/travis/build/gliptak/pandas/pandas/stats/tests/test_ols.py", line 209, in checkMovingOLS

    x_iter[k] = v.truncate(before=prior_date, after=date)

  File "/home/travis/build/gliptak/pandas/pandas/core/generic.py", line 4622, in truncate

    raise TypeError("not ax.is_all_dates")

TypeError: not ax.is_all_dates

@jreback How do you see this moving forward? Thanks

@gliptak sorry this is not related to the timeseries. something in index.pyx is raising a IndexError when it should be a KeyError (on big index)

@jreback From what I understand this issue discusses datetime index vs,. other indices, and is reproducible with small indices.

@gliptak not sure what you mean. its a non-datetime large index.

@jreback OK, I read this again. I think https://github.com/pydata/pandas/pull/12921 will correct IndexError vs KeyError. But there is a second issue here, truncate documentation states it is only applicable for DateTimeIndex, and you stated earlier in this issue, that it should raise TypeError when non DateTimeIndex. I patched to raise, but testcases in pandas codebase use truncate for non DateTimeIndex.

@gliptak yeah, maybe just update the doc-string. its 'sort of legit' to do this with a non-datetimelike (a bit odd, but that's ok).

@gliptak you are right, we just need a validation test for this (and doc-update).

I wasn't correct, https://github.com/pydata/pandas/pull/12921 takes a different path ... So what do you see raised for these?
big = pd.Series(data=range(int(2e6)), index=range(int(2e6)))
big.truncate() # NOOP?
big.truncate(before=0, after=3e6) # what to raise?

@gliptak that example is correct. I think something fixed this issue. I would just write a confirming test for this (validating the existing behavior).

@jreback I modified docstring and added tests to highlight current behaviour. Please review.


configure finder code to be able to package and upload to pypi

Add configuration files and modify setup.py to package and upload to https://pypi.python.org so that package can be installed using pip install blueflood-graphite-finder.
See feedback/request @ https://feedback.rackspace.com/forums/345663-metrics-as-a-service/suggestions/12353130-get-the-blueflood-python-module-required-by-grap

@shintasmith @usnavi @ChandraAddala please review.

:+1: , ,generally, but a couple of minor points:

Keywords aren't super useful, since google searches can find words in your description.  However, trove classifiers have semantic, unambiguous meaning; you can find a list here: https://pypi.python.org/pypi?%3Aaction=list_classifiers
It's generally considered poor form to include multiple modules in a PyPI package; if the package is named blueflood-graphite-finder, then users will expect it to be importable as import blueflood_graphite_finder or perhaps import blueflood.graphite.finder; they definitely won't expect import auth to come from there.  So py_modules should be reorganized at some point to move into a single package.
Is there any particular reason the package is not zip_safe?  Just as a personal thing I like to see packages use the relevant packaging APIs to allow for zip safety; among other things this makes simplified (self-contained, single-executable) deployments easier.

@VinnyQ We were thinking of moving blueflood finder code to a separate repo. May be this is a good time to do that.

@glyph thanks for the feedback.  I discussed it with the team and we are all for moving these code into a standalone repo.  I'll coordinate with @ChandraAddala to do that since he currently has work in progress.  Will see what i can do about cleaning up the dependency also.

Looks good to me.


Deploy website on netlify or github pages on on the mean time.

Website is temporarily deployed on Netlify.


[Bug] json.worker.js doesn't export anything, so I can't create a custom JSON language worker

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[X] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
...

Actual Behavior
I am currently using monaco v0.32.1, I've found that the json.worker.js file doesn't export anything, so creating a custom worker solution isn't actually possible, in addition, after looking through the source code itself, I'm pretty sure that behavior is a bug rather than a feature, in the source code json.worker.ts actually uses exports.
Expected Behavior
Currently the typescript worker exports the create method, the source code for the json worker also export the create method, but it's not exported in the production version.
Additional Context
For the bundle.js.org (github.com/okikio/bundle) project, I'm using monaco with a SharedWorker for all of the workers Monaco spins up, but as that isn't natively supported I create custom workers for the language servers, but I can't create a SharedWorker version of the JSON language server as it doesn't export anything I can use to create it.

Hello @alexdima is there any progress on this?


Waiting sequence group should have only one prompt sequence.

I encountered the following error while using vllm to run baichuan, always after running for a while:
"Waiting sequence group should have only one prompt sequence."
Could you please tell me why this happens?
I use V100 32GB GPU and  set batch size as 4 like this:
prompt_ids = [[195, ..., 196], [195, ..., 196], [195, ..., 196], [195, ..., 196]]
sampling_params = SamplingParams(n=3, temperature=0.3, top_p=0.85, top_k=5, max_tokens=2048, presence_penalty=1.1)
output_list = llm.generate(None, sampling_params, prompt_id_list, use_tqdm=False)

Thank you !

I observe the same error with CodeLlama-7b as well.

CC: @WoosukKwon @zhuohan123

I found the same problem. It occurs when setting n (the number of sequences returned) greater than 1, and occurs frequently when there is less gpu memory.
A simple solution is to copy the prompt and set n to 1, but will lose some speed. There should be a better way.

I'm running into this as well—it seems to be more prevalent with larger models and also shows up when using best_of.

After some digging, the bug seems to be related to calling _preempt_by_recompute from _preempt, which inserts sequence groups at the front of the waiting queue. (But based on the TODO there, vLLM doesn't support recomputation for groups with multiple sequences?)
A quick fix is to force _preempt to only use PreemptionMode.SWAP, which fixes the error for me—but that's probably not ideal.

I encountered this with Mistral 7b on an A10 using AsyncLLMEngine when pending requests increased above 0. Removing n and best_of from the SamplingParams is a workaround.

Faced this issue with codellama 13B (bfloat16) on an A100 80GB GPU with 64GB of CPU swap when using n=1 and best_of=16 for generated length 512. Ultimately also had to set best_of to 1.

I experience that too also when running llama3 8b with SamplingParams(n=1, ...)
and call model in parallel..
in general, i think it relates to this issue
so it's something with the default_scheduler ..
would love to get some help here


Cannot play audio on dockerfiles

Command: aplay tts.wav
Error message is: ALSA lib pcm_dmix.c:1029: (snd_pcm_dmix_open) unable to open slave aplay: main:722: audio open error: No such file or directory

Can you add the command you were using?

Command: aplay tts.wav

Thanks. I tried to duplicate and was able to play the sound just fine. Can you check playing on your Ubuntu 20 system? Also, try sudo alsa force-reload

I realize that also in my machine was  not working.
It did not recognize my speaker as the default one (it takes the HDMI port instead), and so I set my default card device in the asound.conf file. I followed this instructions:

Check which the card device number you want to set as default
aplay -l
-Create a config file to set the default device

cd /etc/
nano asound.config

Copy and paste the following, changing the card number according to your default sound device

pcm.!default {
        type plug
        slave {
                pcm "hw:0,0"
        }
}

ctl.!default {
        type hw
        card 0
}

I made the same setup also in the docker container, and now it works

Excellent, I will close this issue then


ListTile leading width

I'm trying to reduce the gap between leading and title, the leading width that I need is only about 10, but there seems to be no way for me to change this.
Tracing to the code in list_tile.dart, I can see this line:
static const double _minLeadingWidth = 40.0;
which seems to be what I wanted to change, but how do I change it without modifying the material source code?

When ListTile doesn't do exactly what you want it's usually easiest just to create your own similar widget based on Row, etc.  Would that work in this case?

I've uploaded an image to demonstrate my problem:
https://i.ibb.co/zf86xPQ/IMG-20190307-011102.jpg
I'm having a thin container (width: 8) within leading to show colours indicating the status of the list item. (Pretty common design in to-do apps or email client etc.) But once I use leading, it forcefully pushed the title to the right,  leaving quite a large empty area between them as seen in the screenshot.
Maybe I can make do with Row widget like you suggested, but that's gonna change quite a bit of code here. Unfortunately I don't have the time to rework this part due to tight deadline.
If there's a way to fix the gap for ListTile I'd really appreciate it. Otherwise I will have to leave it as is and perhaps rework using Row widget in future when time allows. Cheers.

As @HansMuller has suggested, I think the best course of action is to create your own implementation using a Row widget or something similar. ListTile is meant to adhere to the material implemetation, and at a glance, your intended implementation differs from the intended use case for ListTile.
I'll close this issue for now, but feel free to reach out if you have any other concerns!


external-puts

Patch

the @scheduled was not going to the right place after we made it external.

:+1:

fixes #198


docs: document extension creation and events

No worries if you don't like these docs or don't want to merge this, the docs were largely written by copilot and I already had the function in my config.
I just thought it could be helpful to have some docs for people who want to start building extensions now :)

Other people have made better doc PRs


Show wrong, how do i use it correctly?

Before, I used png pictures to do animation, but not fluent. So, this time to use AI to draw and then use AE to make animation, export, they are all wrong, where is the way I made it wrong?
Youtebe：https://youtu.be/NMDJjhh2UkM
This is AEP&json:aepandjson.zip

Hi, bodymovin doesn't support Merge Paths.
I've tried to fix your animation but all layers are in chinese and I can't figure out how.
When converting AI layers to shapes, sometimes AE adds an unnecessary square path and a merge path property.
If you remove them it's probably going to work.
Let me know if I can help you further.

@bodymovin WOW, So, I need delete Merge Paths? But I do not know how to distinguish what is the merge path.


Escape tex characters in legend (fixes #538)

Apply _common_texification to legend entries, similar to Axes titles and labels.
Fix failing pre-commit config due to incompatible dependencies (https://github.com/psf/black/issues/2964)

Fixes #538

What is the holdup on merging this?


Add metadata file for ansible-galaxy

Hi,
I added a meta/main.yml so this role can be added to a requirements.yml and be installed via ansible-galaxy.
Cheers,
Pieter

Thanks a lot!

Hi @donat-b @pieterlexis , I still cannot find this role in Ansible Galaxy. Has it been pushed? I would like to try it. Maybe we can add how to find it in the readme.
Thanks!

Seems like I had to refresh my repositories at ansible galaxy.
Now it's published:
https://galaxy.ansible.com/donat-b/restic


[Snyk] Upgrade eslint-plugin-import from 2.28.0 to 2.28.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade eslint-plugin-import from 2.28.0 to 2.28.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-08-18.

Release notes

Package name: eslint-plugin-import

2.28.1 - 2023-08-18v2.28.1

2.28.0 - 2023-07-28v2.28.0

    from eslint-plugin-import GitHub release notes

Commit messages

Package name: eslint-plugin-import

cd95728 Bump to 2.28.1
0847443 Revert 1fa2971 (breaking group change in `order`)
e9de30a [resolvers/webpack] v0.13.6
cd1dff7 Revert "[resolvers/webpack] [refactor] replace `lodash/isEqual` usage with `deep-equal`"
da71746 [resolvers/webpack] v0.13.5
22a0802 [resolvers/webpack] [deps] update `resolve`
1e81734 [resolvers/webpack] [refactor] replace `lodash/isEqual` usage with `deep-equal`
2c18c29 [resolvers/webpack] [refactor] remove `lodash/get` usage
b9b9c86 [resolvers/webpack] [refactor] switch to a maintained array.prototype.find package
2e7612f [Dev Deps] pin `jackspeak` since 2.1.2+ depends on npm aliases, which kill the install process in npm < 6
26ea4f8 [Docs] Add markdownlint
c704253 [resolvers/node] v0.3.9
559480d [resolvers/webpack] v0.13.4
10913e7 [resolvers] [*] [fix] restore node 6 compatibility
69fce5c [Tests] actually test non-babel’d packages without babel
0501367 [Docs] remove duplicate fixable notices in docs
7f7a9a6 [resolvers/node] v0.3.8
6f6f414 [resolvers/webpack] v0.13.3
95f9f00 [resolvers/webpack] [deps] update `semver`
4a75aaf [Deps] remove unused root dep
5209a43 [resolvers] [*] [deps] update `is-core-module`, `resolve`
132a433 [Deps] update `is-core-module`, `resolve`

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

coverage: 98.209%. remained the same when pulling bf01e7cdf8da113c17f16afbe5bbc2712cfb4b54 on snyk-upgrade-3b2152cdf887939e67329e869bb91c30 into 7640be864c24a776866bd18a7dc185e78db5b709 on main.


[JENKINS-26321] Booleans for isReadOnly (Volume), isExtract and isExecutable (URI) are not handled properly

Please refer to https://issues.jenkins-ci.org/browse/JENKINS-26321 for details.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

This has been annoying me. Big +1!


bump rebuild

as per https://github.com/conda-forge/pyzmq-feedstock/pull/5#issuecomment-227260188, just try a new build against vs2015_runtime-14.0.25123-0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

The circle fail looks like #2:
======================================================================
FAIL: threaded auth - NULL
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/zmq/tests/test_auth.py", line 127, in test_null
    self.assertTrue(self.can_connect(server, client))
AssertionError: False is not true

Forcing again!

Hooray, the #2 condition did not occur again!


Merge a pull request

You can  now merge an open pull request. The button is disabled when the pull request is not mergeable.
Fixes #114

This seems to be always shown.

I get Failed to load resource: the server responded with a status of 404 (Not Found) on https://api.github.com/repos/preview-code/test-github-integration/pulls/42/merge?access_token=[mytoken]&per_page=10

I needed to clear my local storage in order to let this work.
Other then that LGTM.


Revert "Fix AdministratorAccess ARN"

Reverts ine-labs/AWSGoat#36

The pre-existing command allows for the attachment of the AWS policy ARN, representing a valid procedure. However, it’s important to note that removing the AWS scope from the command renders it ineffective in listing or attaching the policy for an unauthorized user.


Convert tagged objects to Taquito types in javascript

The expected input format is:
{ "MichelsonMap": {
  "key1": "value1",
  "key2": "value2",
  ...
  }
}

It's necessary to use this structure to encode map and big_map types.
Other conversions:

unit  <=> JsonUnit == { "__unit__": null }
enum  <==> { "__enum__": "EnumVariant" }
Numbers are deserialised as Strings (as they are unbounded)

The PR also include config for webpack and a build script to install npm dependencies and bundle the JS code.

Merging as discussed.


Angular 6 issue

Hi @smnbbrv
I encountered an problem with the latest version of the library and Angular 6, it works fine in versions <6. When I drag and drop the last item in the array an new undefined item is created and pushed into the array. Here is a video demonstrating the issue. Debugging suggests that the problem occurs inside the sortable directive in the function proxyEvent at this line (_a = this.optionsWithoutEvents)[eventName].apply(_a, params);
I didn't go further into, do you have any idea what could be the problem?
Thank you in advance.
Have a great day!

Hi there
Could you please reproduce the problem on stackblitz? I use it on angular 6 project and everything seems to be fine so far

Hi @smnbbrv ,
so in the first run I changed my sortable input items to array of strings and removed all of the custom options to try it out on an simplified example. Because that didn't work I thought that the problem must lay in the library somehow.
Turns out that the problem was an separated tiny icon wrapper inside the [sortablejs] declared div which was set to position absolute and carried an icon with position relative.
Thanks for the help. 😅
Have a great day!

I'm happy that everything works 👍


Helm Chart improvements

Add option to create ServiceAccount
Add option to reference existing service account
Add Option to reference existing secrets (often used for GitOps style deployments. eg. External or Sealed Secret)

I tried to apply the Helm Chart to the Helm Cluster and it works:
➜  dagger git:(main) ✗ helm package .
Successfully packaged chart and saved it to: /Users/tomchauveau/Documents/DAGGER/dagger/helm/dagger/dagger-helm-0.0.2.tgz
➜  dagger git:(main) ✗ helm install dagger ./dagger-helm-0.0.2.tgz
NAME: dagger
LAST DEPLOYED: Tue Nov 14 14:29:37 2023
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
➜  dagger git:(main) ✗ kubectl get pods
NAME                              READY   STATUS              RESTARTS   AGE
dagger-dagger-helm-engine-fksr4   0/1     ContainerCreating   0          24s
➜  dagger git:(main) ✗ kubectl get pods
NAME                              READY   STATUS    RESTARTS   AGE
dagger-dagger-helm-engine-fksr4   1/1     Running   0          26m

Unfortunately, we cannot use the kind for integration test (for now), there are some issue with the object state because he's not return when it should.
I think we can have a follow up of this PR with an actual integration test when the kind module is ready for code usage and not simply dagger call.

As soon as this looks good, happy to help tag a new helm chart version so that the new version becomes available.

How can I tag the new Helm version?

I was expecting ./dagger-helm-0.0.3.tgz to be created from the changes in this PR @TomChv.
I intend to make time tomorrow to try this out on a 1.28.2 DKS:

I just finished testing this on DO K8s 1.28 and all cases work as expected.
Do you agree with my changes @schlapzz? If yes, I am keen to get this merged and the new version published.
Thank you for sticking with us @schlapzz!

Re Node.js SDK failures: https://github.com/dagger/dagger/pull/6118#issuecomment-1824432538

Today is a great day to get this merged @schlapzz. WDYT?

@gerhard Indeed, go for it!

Now available as registry.dagger.io/dagger-helm:0.1.0
helm upgrade --create-namespace --install --namespace dagger dagger oci://registry.dagger.io/dagger-helm


feat(log): add system log page

The current appender supports attaching to the console and files

For console appender, The log of the rendering process will be synchronized to devtool, and the main process will be synchronized to the console
For file appender, the log rendering process will read the latest log file to the editor


Order of bonded BLE devices (IDFGH-11509)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
There is a maximum of 15 devices (or 8 depending on BTM_SEC_MAX_DEVICE_RECORDS) that can be stored in the database of bonded BLE devices. When the database gets full, the device that was added first is removed when a new device is added (pure FIFO). This is problematic as the first added device might very well be the device that is used the most. It would be much better if a device gets top priority (is moved first in the FIFO list or how to look at it) at every new connection. The device that hasn't been used for the longest time should be the one that is thrown away.

Thank you for your report and your suggestions. We will evaluate them.

@ztefanjo
This feature has been implemented. Please cherry-pick the following commit or update to the latest version:
Commit: fdc35e772baf9314d9ba1ef9983660eceffaba94
Commit: 061cd291689651f9688c139b7d3c1deb496104ce

@zhp0406 , great news, thank you!
Closing the issue.


[x] add ignore rule for documentation changes

Motivation
Ignore .md changes in lint.
Test Plan
CI

/land

does that need to be **/*.md?

(note that we have some exclusions in the default rules, for files like README.md and such)


Have you ever tried to deploy the model in TensorRT or some other inference framework?

Just as described in the title, thank you very much

Hi, not yet. We are validating the performance of GANet on our private datasets and will do some deployment work in the future.


Remove CodeFresh Registry

The CodeFresh Registry has been shut down effective July 15th.
https://codefresh.io/codefresh-news/deprecation-of-the-codefresh-private-registry/
This PR is to remove them from the CNCF Landscape.
Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[ ] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[ ] Have you picked the single best (existing) category for your project?
[ ] Does it follow the other guidelines from the new entries section?
[ ] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit 27c09ca9ca614378f5e28deefc924701e8deb58f
https://deploy-preview-1772--landscape.netlify.app

LGTM


How to add custom fields to users？

I hope to be able to add custom fields to users and add them to the accesstoken, just like keycloak. Is this supported?

@chung1912 use "JWT-Custom" and choose the fields for the token


[api-minor] Add an option, in PDFDocumentProxy.cleanup, to allow fonts to remain attached to the DOM

As mentioned in the JSDoc comment, this should not be used unless you know what you're doing, since it will lead to increased memory usage. However, in some situations (e.g. SVG-rendering), we still want to be able to run general clean-up on both the main/worker-thread while keeping loaded fonts attached to the DOM.[1]
As part of these changes, WorkerTransport.startCleanup is converted to an async method and we'll also skip clean-up when destruction has started (since it's redundant).

[1] The SVG-rendering mode is obviously not officially supported, since it's both rather incomplete and inherently slower. However with recent changes, whereby we cache repeated images on the document rather than the page level, memory usage can be a lot worse than before if we never attempt to release e.g. cached image-data when the viewer is in SVG-rendering mode.

/botio unittest

This is inspired by, and extends, the functionality implemented in https://github.com/mozilla/pdf.js/pull/13146/files#diff-082d6b37ad01db7ac97cc07c6ddb0dc52040484c5ef91b110b072f50144d9f39 since as outlined above this makes general sense to expose in the API.
Depending on how soon that PR will land, we should perhaps hold off on this one to avoid unnecessary merge conflicts!?

This is inspired by, and extends, the functionality implemented in https://github.com/mozilla/pdf.js/pull/13146/files#diff-082d6b37ad01db7ac97cc07c6ddb0dc52040484c5ef91b110b072f50144d9f39 since as outlined above this makes general sense to expose in the API.
Depending on how soon that PR will land, we should perhaps hold off on this one to avoid unnecessary merge conflicts!?

Looks good! Given that a new release with [api-minor] is coming up, I would like to have this included.


why is there no easy way to install

Describe the feature you'd like
i want to install but I don't understand this page https://www.bookstackapp.com/docs/admin/installation/ and why can't there just be an exe file?
Describe the benefits this would bring to existing BookStack users
it would make it so that actual people could use this as well
Can the goal of this request already be achieved via other means?
No
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
Not using yet, just scoping
Additional context
No response

Hi @stunlocked1,
BookStack is primarily built as web/server software. We don't build it for any specific platforms, although we do provide Ubuntu LTS scripts to help install since that's a common environment.
BookStack itself is not written in a language that generally is compiled to an exe, and relies on other seperate applications.
While it may be possible to somehow bundle these to a single exe and distribute, I'd worry that could introduce licensing considerations, and it would be a complex process (especially to maintain) which I don't see as worthwhile to spend our time since Windows is a less popular target for this kind of software.
I've going to close off this request as out of scope.


Add Black Boundary on White Button

Reason for changes
Inbound from Merchant LI-47312 asking for parity on appearance of white button having
black boundary on Android SDK vs none in iOS SDK (no black boundary on white button)
Summary of changes

Add black boundary if chosen color is white.

Before:

After:

Checklist

[x] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark

How does Android handle the boarder in dark mode? It seems like it'd have the same issue as a white button. Not sure if we want to consider triple checking with a designer on how/if the boarder on the white button should be handled for light vs dark mode.

I looked at Android code and they have logic in there where if color is white, black border with 2 points is made.
We tried to track original design docs but Nirvan made a decision to stay consistent with JS and Android and have black border. Merchant wanted parity between Android and iOS either way.
Let me check how it looks on dark mode, that's a good point.


[CI] Integrate lint

clang-tidy or cppcheck

cmake "-DCMAKE_CXX_CPPCHECK=/usr/bin/cppcheck;--std=c++17;--enable=warning"

Current status:
Some lint scripts exists, but they are not set up correctly, tools not installed, not integrated into the pipeline.
Scripts (in tools):

lint-all            check all using clang-tidy
lint                check diff using clang-tidy
lint-cppcheck-all   check all using cppcheck, but setup is not sufficient
lint-cppcheck       check diff using cppcheck

Script invocations in the pipeline:

in bootstrap.sh, lint is invoked, if clang-tidy is installed

Test and chose the more appropriate:  clang-tiny or cppcheck.
Setup exception list, fix major deviations, and include check in CI pipeline.
One comparison of C++ static code analyzers:
https://www.slant.co/topics/263/~best-open-source-c-static-analysis-tools

GitHub has https://securitylab.github.com/tools/codeql and action, maybe we can setup this one (security)


Refactor the Android font manager

Today, the engine needs expat solely for the purpose of parsing fonts.xml, which is an unstable file that is documented as something that you're not supposed to use. Unfortunately, Android does not provide us with a better API for this.
Then, it needs to open and scan every font listed in that file, sometimes multiple times over, to get specific information for each listing. On low end phones, this can take significant amounts of time (~750ms on an internally used low end Android phone). We work around this by early-initializing the font manager on a background thread and delaying the check for it until as late as possible, but as VM startup gets more efficient this can easily become the long pole again. It also generates a lot of bus contention on every single startup of the app.
Ideally, there would be an Android API that does better for us, e.g. providing a sytem-wide cache of font data that it knows how to keep up to date. Alternatively, there would be some kind of Freetype API that could more efficiently scan fonts a single time and get all the information, or there would be some good way for Flutter applications to persist and invalidate a cache for fonts data as needed. It also might be worth looking at lazily loading at least some font data, e.g. not loading CJK related fonts if the system locale is not CJK (those fonts tend to be larger and take longer to parse/process).
So the wins would be:

About 50kb of binary size from expat, as well as removing a dependnecy we have to roll.
Less contention around app startup on the IO bus and freeing up a thread for other work that has to get done
Chrome has to do the same thing as us and they would benefit from a solution for this

@bungeman tells me this is non-trivial to do and existing Android APIs are pretty lacking.
/cc @jason-simmons @zanderso @blasten

@dnfield Is there a similar problem on iOS? /cc @jmagman @gaaclarke
FYI @blasten Here are some API requests for Android.

I'm not sure how we manage fonts in flutter on iOS.  I know we won't need expat, that is needed specifically for parsing an android system file.  I see font handling code in skia and it's using Core Text to query information about fonts, so that's probably where and how it happens.  It sounds like that's the kind of API that Dan was hoping to have?  If Dan links to the code he is talking about it will be easier to see if we are needlessly caching Core Text queries, doesn't sound necessary though.

My understanding is that on iOS we have better system apis for this.
If you looked in SkFontMgr_android.cpp in the skis tree that's what I'm talking about.

@dnfield Android uses Skia to load the font on demand after parsing the XML (at runtime) See https://source.corp.google.com/android/frameworks/base/libs/hwui/jni/fonts/Font.cpp;l=104;rcl=HEAD?q=nBuild f:\.cpp&ss=piper%2FGoogle%2Fandroid:frameworks%2F
https://source.corp.google.com/android/frameworks/base/core/java/android/content/res/ResourcesImpl.java;l=935;rcl=HEAD
Do you have a specific change in mind given this architecture?

Skia is currently bound by lack of Android API to do something better. We're bound by Skia. That's why I tagged this as dependency: android and dependency: skia.
I think in an ideal world, we'd be able to query some kind of system service for font information, and the system service would know everything we need to know for fonts without us (Skia) needing to read fonts.xml and then also scanning each and every font file in there (sometimes multiple times). This service would also know when fonts are updated or changed, and make sure it can re-scan those fonts as neeed.

we'd be able to query some kind of system service for font information, and the system service would know everything we need to know for fonts without us (Skia) needing to read fonts.xml and then also scanning each and every font file in there (sometimes multiple times).

Android internally does this (it seems). Is the suggestion that this can be improved from a performance perspective, or that we would like to reuse their implementation, or both?

There's also https://developer.android.com/ndk/reference/group/font, which parses the XML of the system fonts.
However, it doesn't appear like it handles the app's resources.

I think we'd like both to improve performance as well as to remove our need to roll our own here.
I'm not sure about whether the NDK API is usable or not for us - @bungeman would know. My impression is that it's missing something but I may be wrong. It's also unfortunate that it's only available on API 29+, and a substanital amount is API 30+. We still have to support down to 16.

For removing XML parser dependency, I think it'd be a fair ask to expose
https://source.corp.google.com/android/frameworks/base/core/java/android/content/res/XmlBlock.java;l=45

Actually, that may not be necessary, if we can use https://developer.android.com/reference/android/content/res/Resources#getXml(int), available from API level 1

From feature request triage: @dnfield is hoping to put together a design doc.

The Skia side of this is tracked in https://bugs.chromium.org/p/skia/issues/detail?id=9575

From new feature request triage: @dnfield do we need to escalate this with the Skia team to get unblocked?

I went and wrote https://skia-review.googlesource.com/c/skia/+/585970 but there are huge issues with the actual implementation of the Android NDK Font API. We're still considering possible work arounds, but really Android needs to provide a useful API.

@bungeman is there a bug to track for the issue(s)?


Error after building the portal

INSERT SHORT DESCRIPTION EXPLAINING THE HIGH-LEVEL REASON FOR THE NEW ISSUE HERE.
Current behavior

When you follow the steps to build the career portal, you are unable to actually use it due to an error

Expected behavior

Career portal should work after being built

Steps to replicate behavior

Build the career portal in the steps in the README
Upload the Portal to your web host.
An error is produced in the console.

You can see this error at http://charlesabarnes.com/dev/ by pressing F12
Screenshots
Current

This is due to the most recent Angular updates.  To workaround this for now, before building, you want to downgrade your angular-cookies version by running the following command
bower i -S<EMAIL_ADDRESS>Please let me know if you need any assistance with this!


Plexon signal stream_ids are not cosistent across reads

The problem is here:
https://github.com/NeuralEnsemble/python-neo/blob/315f485eb24c8d17aaebc5d6b56a336840913b66/neo/rawio/plexonrawio.py#L269-L275
We use set to form unique users group, enumerate over them to determine stream_index and use str(stream_index) as a stream_id. But this does not work because iterating over sets and determining sets is not deterministic.

yep. set is dangerous for that. np.unique() could be a better choice.

Fixed with a dictionary strategy in #1524. Closing.


After abapGit updates, execution of program ZABAPGIT runs into errors

After abapGit updates, execution of program ZABAPGIT runs into errors.

Do you use the compiled (single source) abapgit or do you install abapgit from this git repository?

By the way, not reproducible on my ABAP Trial 752 with the single source abapgit nor development abapgit.
If you use compiled abapgit, please, try to reinstall.
If you use developement abapgit, please, consult tcode SMW0 -> Binary data forWebRFC applicaitons -> Object name = zabapgit_icon_font_css.

Just re-updated both dev and full versions of AG on 731 - also cannot reproduce. +1 for reinstall. Should work fine.

@NaveenKurmadas can you provide additional information?

reinstall fixed the issue. Thanks


⚠ jaswdr.dev has degraded performance

In 1456100, jaswdr.dev (https://jaswdr.dev/) experienced degraded performance:

HTTP code: 200
Response time: 498 ms

Resolved: jaswdr.dev performance has improved in ded88b1.


feat: add deprecation error rule

Resolves https://github.com/seek-oss/eslint-config-seek/issues/77

It takes hirer-graph on my local from 18s to lint to about 26s. It's not terrible, but I guess it's not great either.
I didn't notice any issues with autofix.


Create a map by gathering key/value pairs

A community zync user inquired:

Does Zed provide a way to collect() values into a map instead of an array?

It currently does not, but the Dev team recognizes this would be cool & useful. Two approaches come to mind:

An operator that could turn a table of aggregation results into a map, e.g., using this Zeek example:
count() by _path | map _path,count | ...

An aggregation function, e.g.:
summarize map(foo,bar) by other_val

Where the foo & bar become the key/value pairs, respectively, of the created map.

We expect both approaches are probably something we'd want to support.

When I opened this issue recently, I'd not noticed that we already had #3201 that overlaps with this one. Therefore I've copied the text from this issue to #3201 and am closing this one as a duplicate.

Verified in Zed commit b7d3f00a.
Here's the example from the initial issue text implemented with the new map aggregate function. This is run against the Zed sample data.
$ zq -version
Version: v1.2.0-116-gb7d3f00a

$ zq -Z 'count() by _path | map(|{_path:count}|)' *
{
    map: |{
        "pe": 21 (uint64),
        "dns": 53615 (uint64),
        "dpd": 25 (uint64),
        "ftp": 93 (uint64),
        "ntp": 904 (uint64),
        "rdp": 4122 (uint64),
        "rfb": 3 (uint64),
        "ssh": 22 (uint64),
        "ssl": 35493 (uint64),
        "conn": 1021952 (uint64),
        "http": 144034 (uint64),
        "ntlm": 422 (uint64),
        "smtp": 1188 (uint64),
        "snmp": 65 (uint64),
        "x509": 10013 (uint64),
        "files": 162986 (uint64),
        "stats": 5 (uint64),
        "weird": 24048 (uint64),
        "modbus": 129 (uint64),
        "notice": 64 (uint64),
        "syslog": 2378 (uint64),
        "dce_rpc": 78 (uint64),
        "kerberos": 11 (uint64),
        "smb_files": 12 (uint64),
        "smb_mapping": 393 (uint64),
        "capture_loss": 2 (uint64)
    }|
}

Thanks @mattnibs!


Added Dockerfile and docker-compose for kitty deployment

I just added some files to add compatibility to docker; the changes are:

Created  Dockerfile and docker-compose files to create the image and deploy it.
Edited db.py to add an env variable to support simple volume creation.
Edited README.md to list the commands to build and deploy kitty with docker compose.

like and subscribe for more


Move locale based date behind a flag

This makes sure the date behaviour is kept to previous default.
https://github.com/lsd-rs/lsd/issues/828

TODO

[x] Use cargo fmt
[x] Add necessary tests
[ ] ~Add changelog entry~
[ ] ~Update default config/theme in README (if applicable)~
[ ] ~Update man page at lsd/doc/lsd.md (if applicable)~

Codecov Report

Merging #840 (60597a7) into master (ff3e48e) will increase coverage by 0.02%.
The diff coverage is 91.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   87.42%   87.45%   +0.02%
==========================================
  Files          45       45
  Lines        4302     4320      +18
==========================================
+ Hits         3761     3778      +17
- Misses        541      542       +1

Impacted Files
Coverage Δ

src/app.rs
39.28% <50.00%> (ø)

src/meta/date.rs
94.28% <93.75%> (-0.25%)
:arrow_down:

src/flags/date.rs
95.77% <100.00%> (+0.18%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


null safety support

please upgrade package. add null safety . Thanks

Use simple_animations version 3.x+ to get nullsafety support. This is just a migration package for 1.x users, that migrate to 2.x.


Metadata facet behavior

This PR:

adds some configuration to the local app's CatalogController to support linking of metadata values in the item show view display. (#109)
adds facets for Place of publication, Publication title, and Article type (#87)
updates some properties to add the index.as: :facetable option to support above behavior

@ebenenglish I have been looking at the metadata-facet-behavior branch in a browser with a few test NewspaperArticle items, and seem able to get almost everything working in search results from the show page, with the exception of the genre field.  This appears as a faceted link in the show page, but no search results appear on click for any of genre_sim (or variations I have tried for dynamic solr field name in query string, including genre_tesim, etc).  I do not see anything really different in the model/indexing, but I suspect there's something subtle here my eyes are missing looking at the code (maybe related to work in PR #110)?

Nice catch, Sean! I wasn't setting the fields properly in the genre indexing.
Pushed up a new commit that fixes this.


Logo font is different

Describe the bug
The logo seems different from the design and the main site
To Reproduce
Steps to reproduce the behavior:

Go to 'govuk-react storybook example application'
Compare the logo to the 'Design Website' and 'gov.uk main site'
The govuk-react logo is more thicker and has 'nta' font. The Design and Main website both have "GDS Transport" font

Expected behavior
Expected the logo to be the same as the Design System and the Main gov.uk site.
Screenshots
Design System logo

gov.uk main site logo

govuk-react app logo

Desktop (please complete the following information):

Windows 10
Browser: Chrome

Hi there, have you read this? https://github.com/govuk-react/govuk-react/issues/272 it is linked from the readme.md; https://github.com/govuk-react/govuk-react#about-the-gds-font

@Loque-
Just saw it. Thanks for your comment!


Refactor to remove FvmStore

Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)

Closes #1648
Other information and links

@tyshko5 Try putting Clone as a super-trait of BlockStore. Then you don't need to repeat it so many times.

@tyshko5 Tests are failing. It's because the MemoryDB shouldn't be duplicated on clone. It should use a shallow copy.

@tyshko5 Tests are failing. It's because the MemoryDB shouldn't be duplicated on clone. It should use a shallow copy.

Fixed that


Linux install requiring pypiwin32

pip3.5 install setuptools_scm
Collecting setuptools_scm
/usr/local/lib/python3.5/site-packages/pip/vendor/requests/packages/urllib3/util/ssl.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning.
SNIMissingWarning
Downloading setuptools_scm-1.11.1-py2.py3-none-any.whl
Installing collected packages: setuptools-scm
Successfully installed setuptools-scm-1.11.1
<EMAIL_ADDRESS># pip3.5 install asciimatics
Collecting asciimatics
Using cached asciimatics-1.7.0-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): future in /usr/local/lib/python3.5/site-packages (from asciimatics)
Requirement already satisfied (use --upgrade to upgrade): pyfiglet>=0.7.2 in /usr/local/lib/python3.5/site-packages (from asciimatics)
Requirement already satisfied (use --upgrade to upgrade): Pillow>=2.7.0 in /usr/local/lib/python3.5/site-packages (from asciimatics)
Collecting pypiwin32 (from asciimatics)
Using cached pypiwin32-219.zip
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-3_afj4p1/pypiwin32/setup.py", line 121
print "Building pywin32", pywin32_version
^
SyntaxError: Missing parentheses in call to 'print'

Damnit!  Looks like building the package on Windows was a bad idea...  I'll try to fix that later today.
In the meantime, a temporary workaround is just to clone the repository, build the package (e.g. run python setup.py bdist_wheel --universal) and then install from that built package.

Should now be fixed with v1.7.1 package uploaded to pypi a few minutes ago.


Add manual merge instructions to eng/common workflow

The following pipelines have been queued for testing:java - templatejs - templatenet - templatepython - template You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

@chidozieononiwu to avoid this pain going forward can you please move the bulk of this documentation to somewhere directly in the tools repo? We should probably create a doc folder like all the other repos and add a MD file there with information and we can have the README in eng/common link to that readme. I filed https://github.com/Azure/azure-sdk-tools/issues/1155 to track that work.


update cosmJS

currently this repo is still referencing
"@cosmjs/stargate": "^0.24.0-alpha.17"
latest is
"@cosmjs/stargate": "^0.26.5"

Hey team! Please add your planning poker estimate with ZenHub @mhagel @victordelval

yarn link to test against regen-web

Please add your planning poker estimate with ZenHub @haveanicedavid

Once this is merged, I will create a regen-web PR to use the latest changes from regen-js


"Reduced" item stat check and hover over details needs to be implemented

Description
Currently the reduce amounts for KO items is not implemented. For the moment we are filling these reduce quantities with empty strings when the player hovers over an item (see PR #175).
Screenshots

Files

UIImageTooltipDlg.cpp

Tasks
We need to recreate the check they have here:
      ::_LoadStringFromResource(4538, &szStr);  // Required Dexterity : %d %s
      if ( CUIImageTooltipDlg::SetTooltipTextColor(
             v111[26],
             (unsigned __int8)spItem->pItemBasic->byNeedDexterity + spItem->pItemExt->siNeedDexterity) )
      {
        CN3UIString::SetColor((_DWORD *)this->m_pStr[iIndex], this->m_CWhite);
      }
      else
      {
        CN3UIString::SetColor((_DWORD *)this->m_pStr[iIndex], this->m_CRed);
      }
      v126 = spItem->pItemExt;
      v127 = v126->byMagicOrRare;
      if ( v127 == 4 || v127 == 5 )
      {
        if ( v126->siNeedStrength < 0
          || v126->siNeedStamina < 0
          || v126->siNeedDexterity < 0
          || SLOWORD(v126->siNeedInteli) < 0
          || v126->siNeedInteli < 0 )
        {
          std::string::ctor(v271, &v264);
          LOBYTE(v281) = 13;
          ::_LoadStringFromResource(4554, v271);// (Reduce)
          szReduce = exception::what((exception *)v271);
          iRequiredDex_1 = (unsigned __int8)spItem->pItemBasic->byNeedDexterity + spItem->pItemExt->siNeedDexterity;
          szFmtStr = exception::what((exception *)&szStr);
          sprintf(szBuff, szFmtStr, iRequiredDex_1, szReduce);
          LOBYTE(v281) = 1;
          v129 = v271;
        }
        else
        {
          str::string::equalOperator(v270, &EmptyString, &v264);
          LOBYTE(v281) = 14;
          szEmptyStr = exception::what((exception *)v270);
          iRequiredDex = (unsigned __int8)spItem->pItemBasic->byNeedDexterity + spItem->pItemExt->siNeedDexterity;
          szFmtStr_1 = exception::what((exception *)&szStr);
          sprintf(szBuff, szFmtStr_1, iRequiredDex, szEmptyStr);
          LOBYTE(v281) = 1;
          v129 = v270;
        }

Nice! Thanks for creating this one. It's also worth mentioning that this is somewhat related to Anvil and items upgrading in general. In the official client there is a scroll called Reduce something that one can use to upgrade in order to reduce the item level requirements.
Similarly with Unique Items, before one can upgrade a unique item, Elemental Scroll is required to be used to get it from no level to +1:

The checks there simply check if the siNeed* variables are less than zero, and if they do, if it's true, then append (Reudce) to item level require tooltip.


use environment variable HUGO_ASCIIDOCTOR_ARGS to override the default arguments

fixed #5842

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Superseded by https://github.com/gohugoio/hugo/pull/7281 ?


Job submission v2 with protocol using REST API

What would you like to be added:
Upgrade to job submission v2 based on protocol yaml.
Why is this needed:
To improve job submission user experience and job protocol sharing in marketplace in the near future.
Without this feature, how does the current module work:
Use v1 version json config file.
Components that may involve changes:
Rest server and webportal.
Work items

[ ] [Docs] Finalize protocol spec: #2260.
[ ] [Docs] Update existing yaml files to protocol: #2292.
[ ] [Rest Server] Protocol yaml parsing, rendering, and validation: #2274.
[ ] [Rest Server] Convert protocol to framework launcher description file: #2291.
[ ] [Rest Server] Refactor and update rest API v2
[ ] [Webportal] Update job submission v2 form

@yanli2017 - may you help to review the RP #2292 ? @fanyangCS


There is a vulnerability in OkHttp 3.9.0,upgrade recommended

https://github.com/alibaba/jvm-sandbox-repeater/blob/0a1b47b2aae295a5c4627e533e7da94b9ed2b14d/pom.xml#L24
CVE-2018-20200
Recommended upgrade version：3.12.1

upgraded


Nitro storage with FS driver is broken in Netlify functions

Environment
Im using clean nuxt 3.7.4 (or just 3.0+)
Building and running in Netlify functions
Reproduction
Make a clean latest Nuxt app (actually i have the same bug with all nuxt3 versions)
Add this to next.config.ts:
{
  // ...
  nitro: {

    storage: {
      precompiled: {
        driver: 'fs',
        base: 'public/precompiled/',
      }
    }
  },
  // ...
}

Add some .bin files to ~/public/precompiled/
And run "build:prod": "NITRO_PRESET=netlify nuxt build" in your netlify function
Now lets run this API endpoint
const storage = useStorage("precompiled");
const vertices = await storage.getItemRaw("vertices.bin.gz");
console.log(vertices); // returns null

Describe the bug
storage.getItemRaw() or even storage.getItem() returns null in netlify functions.
Additional context
In local environment (npm run dev) works good, but in netlify production simply does not work.
ALSO!
I noticed that the storage in Netlify logs is mounted to a different path than it has to.
Here is the mount object:
{
  "name": "fs",
  "options": {
    "driver": "fs",
    "base": "/opt/build/repo/public/precompiled",
    "ignore": [
      "**/node_modules/**",
      "**/.git/**"
    ]
  }
}

So it is mounted to /opt/build/repo/public/precompiled
But the cwd in Netlify runtime shows this /var/task.
So this is certainly a bug
Logs
No response

Can i help with something? Is it possible to fix it with just updating the src of netlify preset file?

@Hebilicious All good? How are you?

Hello! I recently encountered the same issue. While inspecting the code generated during the build, I noticed that the static path was set to my local environment. I manually adjusted the path and completed the deployment. However, I stumbled upon another challenge: Netlify doesn't allow the modification or addition of files at runtime, as discussed in detail in this article: Terminology Explained: Atomic and Immutable Deploys. The exception to this rule is the use of the tmp directory, but it's essential to note that files in this directory are temporary and get removed after some time, making them non-persistent.
Faced with this limitation, I chose to integrate Redis, a solution that has proven effective for my case.
I hope this helps! If you have further questions or need additional clarification, feel free to reach out.

Translated from Portuguese (Brazil) by ChatGPT.

@bytesbay Kindly please avoid mentioning people. This issue is on the track.
Unstorage paths are resolved to the current working directory (it might be different from when entrypoint of script starts from)
Have you tried also a path in /var/task/data? I'm not sure what paths would be actually allowed to be writable in netlify functions.

The path is /tmp/. Here's an example of how I did it:
In <directory>/.netlify/functions-internal/server/chunks/nitro/netlify.mjs, look for where your storage is being configured. In my case, it looked like this:
storage.mount('test', unstorage_47drivers_47fs_45lite({"driver":"fsLite","base":"<directory>/.data/test"}));
storage.mount('data', unstorage_47drivers_47fs_45lite({"driver":"fsLite","base":"<directory>/.data/kv"}));

I changed it to:
storage.mount('test', unstorage_47drivers_47fs_45lite({"driver":"fsLite","base":"/tmp/.data/test"}));
storage.mount('data', unstorage_47drivers_47fs_45lite({"driver":"fsLite","base":"/tmp/.data/kv"}));

For me, it worked, but the files only last for a limited time, I believe around 1 hour. That's why I opted for another alternative.

Translated from Portuguese (Brazil) by ChatGPT.

Thanks for confirming. I'm afraid we cannot do anything more as persistency and lifecycle of functions is entirely dependant on the netlify runtime.
PR welcome to document about /tmp in netlify deployment guide and estimated limitations for TTL 👍🏼

Thanks guys! Will move to digital ocean apps


Set 'everone'-group as default

As an item creating user, I want the process to be fast and secure. Therefore, the default permission is: 'everyone' 'can_borrow'. This ensures that an item is visible and lendable by everyone by default.

###Dependencies

#276
#153

Acceptance Criteria

[ ] The described permission is set when a new item is created.
[ ] It's possible to change or remove the permission.
[ ] The permission will not be set a second time by default (e.g., If I remove it, save it and edit it again)

Is already solved in #223


dump files still saved server which is comment at serverlist file

dump files still saved server which is comment at serverlist file.
when server list file is:
#server s1:8081 weight=50 max_fails=2 fail_timeout=3s;
server s2:8081 weight=50 max_fails=2 fail_timeout=3s;
server s3:8081 weight=50 max_fails=2 fail_timeout=3s;

I see dump in server which has nginx-upstream-serverlist moudle:
server s1:8081 weight=50 max_fails=2 fail_timeout=3s;
server s2:8081 weight=50 max_fails=2 fail_timeout=3s;
server s3:8081 weight=50 max_fails=2 fail_timeout=3s;
is this right ? all  server list file  must return some header?

The parser of serverlist in the module is not as strict as the nginx's conf parser.
So the comment symbol "#" is ignored by the parser. In other words, "#server s1:8081 weight=50 max_fails=2 fail_timeout=3s;" is equal "server s1:8081 weight=50 max_fails=2 fail_timeout=3s;".
It is ugly, but just work. I will polish this in the future.

thanks, expecting your update.


ci: manual UI tests

ci: manual UI tests
Setting up ability to run UI tests manually from repository actions. Editing the pull request workflow file to run them for a feature branch is becoming a bit tiresome.
Checklist
Before raising your pull request:

[x] Commit messages that conform to conventional commit messages
~- [] Ran the app locally ensuring it builds~
[x] Ran the tests locally ensuring they pass on Build
[x] Pull request has a clear title with a short description about the feature or update
[x] Created a draft pull request if it is not yet ready for review

Before your pull request can be reviewed:
~- [ ] Met all of the acceptance criteria specified in the user story on Jira~

[x] Reviewed your own code to ensure you are following the style guidelines
~- [ ] Ran the app and tested the feature on a range of device sizes
Please include iPod Touch, iPhone SE and iPhone 11 as a minimum.~
~- [ ] Written Unit and Integration tests if needed~

~- [ ] Met all accessibility requirements?
- [ ] Checked dynamic type sizes are applied
- [ ] Checked VoiceOver can navigate your new code
- [ ] Checked a user can navigate only using a keyboard around your new code~
Before merging your pull request:

[x] Ensure that the code coverage and SonarCloud checks have passed
[ ] Actioned and resolved all comments, reaching out to reviewers for clarifications if necessary.
[ ] Ran the app to ensure that no regressions have been caused by changes during code review.

Approved! :) But how come we don't just make the UI tests run when a PR is opened, like the other jobs? It feels a little impractical to run them manually and then run them again once merged..?


Manage trailing "/" in path issue (error message and trailing slash automatic add)

Is your feature request related to a problem? Please describe.
The model is not visualized if the path do not contain the trailing "/"
Describe the solution you'd like
When the model files are not found, a message should be displayed.
When no trailing slash in the path, it should be added automatically
Describe alternatives you've considered
Additional context

Released on v0.9.19


is this project dead?

no updates in 2 years, is it dead?

That's unfortunate

Bummer

I updated the dependencies & this worked for me. I have created pull request for those changes.
If anyone wants to refer or use.
https://github.com/pipefy/datadog-apm-rust/pull/6