Update for Angular

Currently, I use you project for an Material application. If you are interest, when I will finish all my required points, I would push to you all my modifications.
The points are:

[x] Material style
[x] Form binding : FormControl / Error
[x] Keyboard navigation (with tab)
[x] Unicode search (supports accents)
[x] Change the search pattern on fly
[x] Options styling
[x] Hint message
[ ] Position on top if no space on bottom (probably not necessary)

Example on Angular4:
<select2
    [(ngModel)]="value"
    [data]="data"
    formControlName="example"
    placeholder="Placeholder example"
    material
    [editPattern]="editPattern">
    <select2-hint>Message</select2-hint>
</select2>

Sorry, I test all my changes in my project, I can not compile your project on my computer.

The project works on my computer with Linux. I resolve my last problem with the demo and I think that is good.

for the last point you could depend on the native popper.js implementation:
import Popper from 'popper.js';

// this you can put when the view child is created
  @ViewChild('popperDropdown')
  set popperDropdown(popperDropdown: ElementRef) {
    if (!popperDropdown) {
      return;
    }
    this.popper = new Popper(this.popperBtn.nativeElement, popperDropdown.nativeElement, {
      placement: 'bottom-start',
      modifiers: {
        applyStyle: {
          fn: (data) => {
            this.setStyle(popperDropdown.nativeElement, data.styles);
            this.setAttributes(popperDropdown.nativeElement, (data as any).attributes);

            if (data.offsets.arrow) {
              this.setStyle(data.arrowElement, data.offsets.arrow);
            }

            return data;
          }
        }
      }
    });
    this.popper.scheduleUpdate();
  }

  private setStyle(element: any, styles: { [key: string]: any }) {
    Object
      .keys(styles)
      .forEach((key: keyof typeof styles) => {
        this.renderer.setStyle(
          element,
          key,
          ['width', 'height', 'top', 'right', 'bottom', 'left'].includes(key) && isNumeric(styles[key])
            ? styles[key] + 'px'
            : styles[key] + ''
        );
      });
  }

  private setAttributes(element: any, attributes: { [key: string]: any }) {
    Object
      .keys(attributes)
      .forEach((key: keyof typeof attributes) => {
        if (attributes[key] === false) {
          this.renderer.removeAttribute(element, key);
        } else {
          this.renderer.setAttribute(element, key, attributes[key]);
        }
      });
  }

this works for me in a lot of scenarios and depends on only a highly decorated and tested library
Anyway, I'm looking for a library like this and there are a lot of options but all have issues, this one has the least in my experience so, great work!

@ronzeidman I probably try this in a next point.
At the moment my problem is the demo. I have a problem with the webpack configuration (probably), because the Angular injection not work... In my project, the injections are ok. I don't understand why the same code not work in this project.
For my the webpack configuration is little mysterious.

@Zefling look into this: https://github.com/dherges/ng-packagr

@Zefling I just find out the angular injection not work, because "emitDecoratorMetadata": true not set in src/tsconfig.json and demo/tsconfig.json

Sorry, I don't pass all the lint points when I use  the angular style.

It's not only an angular project.
but don't worry, I will review and fix the lint in next few days.

I found a problem with click on scrollbar. I write a correction. I have a solution without timer.
I will propose a new pull request for this.

The features in your PRs should be available in v3.1.0 release now.

It's ok, except one point.
Why LESS change this:
calc(100% - 1.72917em) → calc(98.27083%);

It's ok with 3.1.2 on my project. Thanks. 🙂

I found a problem with mouseenter. This event create a lot of change in the DOM and block the clic event for a filter data in options of optgroups.


PFX Certificate gets replaced if key_password input changed or removed

In v2.1.0, If a key_password is provided during PFX certificate creation and subsequently removed or changed, the entire certificate gets recreated.
Should key_password require recreation of the certificate or if auto_password remains the same (i.e. key_password removed/set to null), the cert object would still be valid.
If key_password is updated, could the provider simply regenerate the private key without recreating the entire certificate?

This is not possible which is why it forces replacement. There's no API exposed to update the password needed to recover the private key, so a new enrollment be performed.

The data resource for a certificate does a recovery when you give it a password. Is that different from what the provider does here?
Also, when switching from an empty string to null for key_password, Terraform is rerolling the auto_password can causing the certificate to be recreated. Since we are switching between non-values, it would be nice if the provider equated null and empty string as the same value and didn't force the cert to be recreated.

@rmcolbert It seems my understanding of how Command handles passwords was incorrect. The password at recovery time can essentially be anything and Command does not store this. However it should be noted that at create time if the password isn't sufficiently complex, which depends on template config, then enrollment will fail with an ambiguous error stating to check the server logs. With this means that it triggering a force replace on password change no longer seems appropriate and v2.1.4 has removed that behavior.


Fix hyperlink to "kubectl drain"

Fix hyperlink from StatefulSet: Run and Scale Stateful Applications Easily in Kubernetes
to (new target) https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#drain
The blog article still seems relevant even if it's a few years old. With that in mind, I think it's worth fixing the link.

/lgtm
/assign @castrojo

/lgtm
/approve


Cannot use "self" when loaded in vRP context

For example, lets take this simple test client script (loaded correctly into vRP context by a client file):
local TPTest = class("TPTest", vRP.Extension)

function TPTest:__construct()
  vRP.Extension.__construct(self)

  self.open = false
  self.chestid = nil
end

function TPTest:open()
  self.open = true
end

function TPTest:toggleTest()
  if self.open then
    print("open is true")
    print("chestid: "..chestid)
  else
    print("open is false")
  end
end

vRP:registerExtension(TPTest)

When the TPTest's method "toggleTest" is called by another extension or vRP module, "self" is actually a nil value local variable so we can't access TPTest "open" variable.
Is this behavior intentional? Am I doing something wrong?

Issues are not for help.
https://github.com/ImagicTheCat/vRP/tree/master/doc#issues--features--help
Your problem is probably related to Lua and how "OOP" works.


chore: update nixpacks and add go 1.19/1.20 support

This PR updates the nixpacks commit hash and updates the Go provider with 1.19 and 1.20.
I followed https://github.com/railwayapp/nixpacks/pull/747 to update the commit hash. It seems like the bot is broken and hasn't updated in 6 months.
I updated the custom version in the custom go version example and confirmed that it built correctly.

@coffee-cup  is https://github.com/railwayapp/nixpacks/issues/826#issuecomment-1461288199 still the preferred way to handle this?

@coffee-cup is #826 (comment) still the preferred way to handle this?

Yes that is still preferred. The bot itself isn't broken, it is the tests that are broken. For example, updating the Nix archive updates the default Java/clojure versions, which break how Nixpacks is currently building clojure apps. This global nix archive version isn't scalable and we are thinking of ways of gracefully handling it.
For now, I would recommend to use a specific archive version for Go the newer Go versions (similar to https://github.com/railwayapp/nixpacks/blob/main/src/providers/swift.rs#L17).

Sounds good. I'm actually just going to use a Dockerfile then.


Can we get rid of metadata JSON?

Currently, this needs a little json file that looks like this:
{
  "source": "http://nomads.ncep.noaa.gov",
  "date": "2016-11-20T00:00Z",
  "width": 360,
  "height": 181,
  "uMin": -21.32,
  "uMax": 26.8,
  "vMin": -21.57,
  "vMax": 21.42,
  "tiles": ["wind/{z}.png"]
}

I wonder if we use not just the r and g channels in the image, but use some of the other channels if we can get the velocity encoded into the image without these values, in which case we could dispense with the need for this file.
@cleanasmud any ideas?

Fundamentally the information is already in the image, as the r and g values represent the u and v values just scaled to uint8, which actually raises interesting question from my point of view of how the vector direction is dealt with?

Well that's why we need the metadata file with the range, because that way we can recover the absolute value (see https://github.com/astrosat/windgl/blob/master/data/prepare.js#L23-L24). However, I wonder if we can just use an absolute range and potentially use two uint8 to increase the resolution. For example wikipedia says that the highest recorded wind speed was 408km/h. So if our absolute range went from -500 to 500, it should be pretty safe. 16 bits should give us 0.015km/h increments which seems precise enough for me. Of course we can adjust these values or even do something crazy like use a nonlinear scale.


Option to remove horizontal line at the top?

Hello there, I love the app, it's already replaced Neofetch on my production machine.
However, I use a tiling WM, and that means that often, my terminal windows are resized after opening, if I open additional windows in that workspace.  This breaks the task list, because the horizontal line at the top forces all text below to wrap when the terminal window shrinks horizontally.
It's not a huge deal, I have aliased 'clrpls' to clear the terminal and relaunch 'please', but it would be nice to be able to eliminate that top line so that resizing the terminal window is more forgiving.
Thank you for making such a great tool :)

Commit 70 adds an option to disable the horizontal line by adding "disable_line": true at the end of please's config.json :)

v0.2 is out!
https://github.com/NayamAmarshe/please#remove-horizontal-line-in-pleases-output


squid: S1213 The members of an interface declaration or class should appear in a pre-defined order

This pull request is focused on resolving occurrences of Sonar rule
squid:S1213 - “The members of an interface declaration or class should appear in a pre-defined order”.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1213
Please let me know if you have any questions.
Fevzi Ozgul

I wonder when you are going to merge this?
Thanks.


Add ReservationDao as dependency for the Usage Server

Description
The Quota processing occurs on the Management Server (via API) and Usage Server (via task). It uses the class PresetVariableHelper to retrieve data from the database and inject it into the Quota tariff's activation rules. To retrieve the data, some DAOs are mapped as dependencies for the Usage Server and injected in that class.
PR #8302 injected org.apache.cloudstack.reservation.dao.ReservationDao in com.cloud.storage.dao.VolumeDao (which is also injected in PresetVariableHelper); however, org.apache.cloudstack.reservation.dao.ReservationDao was not added as dependency for the Usage Server, causing errors to start the Usage Server:
Logs
04:51:35,224  INFO Transaction:1030 - Is Data Base High Availiability enabled? Ans : false
04:51:35,224  INFO Transaction:1158 - Using the following URI to connect to cloud database [jdbc:mysql://localhost:3306/cloud?autoReconnect=true&prepStmtCacheSize=517&cachePrepStmts=true&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'&serverTimezone=UTC&scrollTolerantForwardOnly=true].
04:51:35,245  INFO Transaction:1158 - Using the following URI to connect to usage database [jdbc:mysql://localhost:3306/cloud_usage?autoReconnect=true&serverTimezone=UTC&scrollTolerantForwardOnly=true].
04:51:37,470  INFO ComponentContext:61 - Setup Spring Application context
04:51:38,677 ERROR ComponentContext:81 - Could not load bean due to: [Error creating bean with name 'volumeDaoImpl': Unsatisfied dependency expressed through field 'reservationDao'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.cloudstack.reservation.dao.ReservationDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}]. The service will be stopped. Please investigate the cause of the error or contact your support team. org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'volumeDaoImpl': Unsatisfied dependency expressed through field 'reservationDao'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.cloudstack.reservation.dao.ReservationDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
  at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:660)
  at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:640)
  at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:119)
  at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:399)
  at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1431)
  at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.configureBean(AbstractAutowireCapableBeanFactory.java:364)
  at com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:79)
  at com.cloud.usage.UsageServer.start(UsageServer.java:55)
  at com.cloud.usage.UsageServer.main(UsageServer.java:42)
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.cloudstack.reservation.dao.ReservationDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
  at org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoMatchingBeanFound(DefaultListableBeanFactory.java:1801)
  at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1357)
  at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1311)
  at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:657)
  ... 8 more

This PR adds the org.apache.cloudstack.reservation.dao.ReservationDao as dependency for the Usage Server.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Bug Severity

[X] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
I applied the changes and tried to start the Usage Server:
Logs
04:53:02,726  INFO LogUtils:59 - log4j configuration found at /etc/cloudstack/usage/log4j-cloud.xml
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
04:53:03,333  INFO Transaction:1030 - Is Data Base High Availiability enabled? Ans : false
04:53:03,334  INFO Transaction:1158 - Using the following URI to connect to cloud database [jdbc:mysql://localhost:3306/cloud?autoReconnect=true&prepStmtCacheSize=517&cachePrepStmts=true&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'&serverTimezone=UTC&scrollTolerantForwardOnly=true].
04:53:03,346  INFO Transaction:1158 - Using the following URI to connect to usage database [jdbc:mysql://localhost:3306/cloud_usage?autoReconnect=true&serverTimezone=UTC&scrollTolerantForwardOnly=true].
04:53:04,288  INFO ComponentContext:61 - Setup Spring Application context
04:53:04,873  INFO ComponentContext:116 - Configuring org.apache.cloudstack.framework.config.dao.ConfigurationDaoImpl_EnhancerByCloudStack_2634113
04:53:04,875  INFO ComponentContext:116 - Configuring com.cloud.storage.dao.SnapshotDaoImpl_EnhancerByCloudStack_569da26d
04:53:04,875  INFO ComponentContext:116 - Configuring org.apache.cloudstack.quota.dao.QuotaEmailConfigurationDaoImpl_EnhancerByCloudStack_8006895b
04:53:04,875  INFO ComponentContext:116 - Configuring com.cloud.usage.dao.UsageVMSnapshotDaoImpl_EnhancerByCloudStack_c98c579
04:53:04,875  INFO ComponentContext:116 - Configuring com.cloud.storage.dao.VolumeDaoImpl_EnhancerByCloudStack_ace675e7

@blueorangutan package

@GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 9117

@blueorangutan test alma9 kvm-alma9

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[SF] Trillian Build Failed (tid-9671)

@blueorangutan test

[SF] Trillian test result (tid-9677)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59787 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8868-t9677-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


chore(newrelic-node-apollo-server-plugin): add New Relic Apollo Serve…

…r plugin to the site
Thanks for submitting a pull request to newrelic/opensource-website.
If possible, please help the maintainers by leveraging the following conventional commit standards in your pull request title and commit messages.
Use chore

for changes / additions / corrections to content in the src/data/project-main-content, src/data/projects directories
for changes / additions / corrections to images in the static/images directory
for functional changes / additions to code in the examples directory

Example
git add src/data/projects/newrelic-nr1-github.json
git add src/data/project-main-content/newrelic-nr1-github.mdx
git commit -m "chore(nr1-github): adjusting config and content"
git push

Use fix

for functional corrections to code in the src/components, src/templates, src/fragments, src/pages or directories
for corrections in the src/data/oss-category or src/data/project-tags directories
for functional corrections to code in the examples directory

Example
git add src/pages/code-of-conduct.mdx
git commit -m "fix: typo and prop error in the code of conduct"
git push

Use feat

for functional changes / additions to code in the src/components, src/templates, src/fragments, src/pages or directories
for changes / additions in the src/data/oss-category or src/data/project-tags directories

Example
git add src/pages/video.js
git commit -m "feat(media): creating a video landing page"
git push

We just released the first version of the plugin! 🎉


describe, it

Is it possible to use describe and it from jest?
Thank you!

Maybe you could elaborate more on what you're looking to accomplish?
The goal of jest-cucumber is to allow Gherkin integration tests to run on top of Jest, with Cucumber syntax as an alternative to describe and it blocks. If you have other unit and integration tests that you want to run in Jest along with your Gherkin tests, then using describe and it blocks for those is perfectly fine. You likely would want to put those tests in separate files, but there shouldn't be anything preventing you from also putting them inside of your step definition files (outside of the defineFeature block).
Something like this will technically also work (when running npm test, not with the VS Code plug-in), although YMMV:
defineFeature(feature, describe => {
    describe('Launching a SpaceX rocket', ({ defineStep  }) => {
        const it = defineStep;
        let rocket: Rocket;

        it('I am Elon Musk attempting to launch a rocket into space', () => {
            rocket = new Rocket();
        });

        it('I launch the rocket', () => {
            rocket.launch();
        });

        it('the rocket should end up in space', () => {
            expect(rocket.isInSpace).toBe(true);
        });

        it('the booster(s) should land back on the launch pad', () => {
            expect(rocket.boostersLanded).toBe(true);
        });

        it('nobody should doubt me ever again', () => {
            expect('people').not.toBe('');
        });
    });
});


Fix React build process (WIP)

Webpack now integrated with lerna workspaces

Sorry. This doesn't look like it's going anywhere. It won't build properly with this react project in our main monorepo approach. We'll have to take a different route.

Why is this request closed?


how to set appname

with my old (php) newrelic code, hhvm complains you need 3 parameters to setAppName
I checked the API, it does seem to require 3, but the code says it isnt completed.
What I want to do, is change appName per virtual host. I just need a php snippet , or even better, a way to use the old code (as that is in wordpress plugins everywhere)
Scott

If I wasn't wrong, setting app name via code doesn't supported in HHVM newrelic. I set the appname using server.ini configuration, with value: hhvm.env_variables[NEWRELIC_APP_NAME] = APP_NAME

thanks dieend - but that's global per hhvm server. I am trying to set it per virtual host, so inside a php script, folder, virtual host.

Per app naming is not available for sdk agents

thanks, so its not code this project can do, until newrelic update their sdk


Develop

optimzed docs

fix this!

idk yet how to access this margin-bottom.. since its not directly the codeblock.. its somewhere nested in docusaurus

I can swizzle the MDXComponent.. and remove it but than also the codeblocks in the docs have no margin-bottom


It cost a lot of memory when running on browser

It took over 4GB of RAM to run (might be a memory leak, as it uses 1.5GB at the start)

Now, I develop a gltf-plugin loader to load the .gltf/.glb models, the memory decreased a lot now!


Error: Callback was already called

In browser this error occurs.

I don't know if this is still relevant, but in the uglify config, pass this option:
compress: { unused: false }

Check https://github.com/ipfs/aegir/pull/214.

@fsdiogo Thanks! That seems to fix this issue. (ref https://github.com/mkg20001/libp2p-nodetrust/commit/455d66d08ec6c961c5c92151d939bfb399f3e2ad#diff-7350bfb3587433477c29566176c70a1dR10)


Viewport Texture doesn't work with output override (OpenXR)

Tested versions

Unreproducible in 3.5
Reproducible since 4.1.3 (maybe earlier)
Reproducible in 4.4 master (47bc374edf6d2e775a5e6b937dc3fd73cdc6f59b)

System information
Windows 11 - NVidia 4070ti - Quest 3 with SteamLink
Issue description
This issue seems to have been introduced early in Godot 4's development but as this is a bit of a niche use case it hasn't gotten much attention especially as it seems to specifically be broken for OpenXR.
I decided to look into this again after someone reported the issue on Discord since I wanted to create a demo project for the setup anyway. Also initially I thought this was a Vulkan issue but it happens on OpenGL as well.
Basically, when grabbing a ViewportTexture from the SubViewport that is rendering content to the HMD, Godot renders a black screen.
Using the MobileVRInterface to create a similar scenario, rendering HMD output to a SubViewport and using a ViewportTexture to show the left and right eye output works fine
Steps to reproduce

Create a SubViewport for XR output, add a standard XR rig and enable use_xr on this viewport
Create a ColorRect for the output to screen (so outside of the SubViewport) and add a ShaderMaterial like so:

shader_type canvas_item;

uniform sampler2DArray xr_texture : source_color;
uniform float layer;

void fragment() {
	COLOR.rgb = texture(xr_texture, vec3(UV, layer)).rgb;
	COLOR.a = 1.0;
}

In a script set the xr_texture shader parameter to SubViewport.get_texture()

Minimal reproduction project (MRP)
For reproducing this issue:
openxr_spectator_view_demo.zip
For a working example using the MobileVRInterface:
teststereo.zip

cc @dsnopek @DarioSamo


NodeJS 8 or higher

NodeJS 8 or higher, everything else is ancient history!
Pull Request check-list
Please make sure to review and check all of these items:

[ ] Does npm test pass with this change (including linting)?
[ ] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.

I've just published v3.0.0 to NPM; https://github.com/NodeRedis/node-redis/releases/tag/v3.0.0 - which drops support for everything below Node 6 so I don't think this change is required anymore. We'll revisit whether we should drop Node.js v6 in the next major release of Node Redis.
Thank you


failsafe password issue - overriding has no effects in 8.5.0

Hello,
The default login/password coming out of the box with admin/shield values.
From my understanding, it is possible to set a strong password (generated by credhub) with the failsafe property. The usage of this property has no effect on my side.
Is it a misunderstanding from my part ? How is it possible to configure that ?
Thanks and regards,
Jean-Christophe.

The failsafe account is only created when there are no other accounts on the system.  This means that once you have booted up SHIELD once, via BOSH, changing the failsafe credentials via the manifest will not have any real effect.  If you log in as the failsafe user, delete the failsafe account, and then reboot the SHIELD core process, you will see the new credentials take effect.
The failsafe user is intended to get you into a SHIELD instance.  If you then change the password of the failsafe account, or provision a new account and delete the failsafe account, we don't want a host reboot or process restart to undo those live changes.


Production ready?

Hi,
Cool project, thanks for making it open source! Do you think it's ready for production use?
Thanks.

Hi,
this is actually used in production ;)
But it does not implement the whole spec, yet.
This are the features that are not supported atm:

Last will
Raw UDP (Only DTLS atm ...)
Gateway discovery (You have to know its IPv6 address or hostname)
Client asleep state
Pre-defined topics
Aggregating gateway (It just supports transparent gateway)

The code is prepared for these things but they haven't been required by the project, yet. Thus, they are still on the list to be implemented.
Does this help? Is there something missing for your use case?

Sounds good, thanks @jue89.


Static 'Window' class

In the Microsoft Spark DotNet implementation, the 'Window' class provides static methods such as 'PartitionBy()'.
Could we also have these static methods to be compatible with Microsoft's solution and to use Spark Connect DotNet as a drop-in replacement?

The other thing I changed is Read/Write are properties like Pyspark  - I’m tempted to provide a couple of different SparkSession/DataFrame to allow drop in replacement for the old package

Fixed in: https://github.com/GoEddie/spark-connect-dotnet/releases/tag/v3.5.1-build.15 please reopen if this isn't what you meant!


What kind of basic analysis to use as a hands-on example

We need some kind of objective that has a measurable result that we can use as an example for things when we are talking about reproducibility.
Maybe use a refine.bio dataset to make a heatmap or do differential expression or something?
Or maybe we want something even more general.

It needs to be something where we download data and create a plot and exact results.


Provide Java 16 build for the PreInstalled type in JavaToolInstaller

Question, Bug, or Feature?
Feature
Enter Task Name:  JavaToolInstaller
Environment
Hosted
Issue Description
JavaToolInstaller provides JDK 8 and JDK 11 by default. However, Java 16 is the latest version, and should also be supported by default, especially given that there's an official Microsoft build of it. Currently, in order to use JDK 16 in the build pipeline, one must host the jdk in an azure blob store, but for most people that's probably just going to be a standard build, and using one of the AdoptOpenJDK or Microsoft builds would be sufficient. This would make #14915 an easy fix as well, since it's just about getting rid of the warnings.

Hi @LadyCailin this is related to JDK versions being pre-installed on hosted images and not related to the task itself - transferring this to https://github.com/actions/virtual-environments


New release

Mind if I release 1.4.1?

This is only code coverage and documentation changes?  Go ahead ... why ask?

Done


Add DirectxTK for windows

Please squash this disaster ^^

In order to avoid too long commit history affecting git pull time, please merge all commit to a single commit.

In order to avoid too long commit history affecting git pull time, please merge all commit to a single commit.

You can do a squash merge it will make a single commit

I have used git merge --squash directxtk; git commit -a -m "merge directxtk" to do this squash merge.
But it will lose contributor information。

Github itself gives you the option to squash merge, you don't need to do it yourself


Problem when ading new task in input CSV

I have added a new task to the input CSV (example provided) and after this I get an error that apparently does not make sense to me:
File "/home/antonio/Escritorio/criticalpy/criticalpy.py", line 108, in calculate_late_start
self.late_start = self.late_finish - self.duration + 1
TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'
The CSV is the following (notice task with id 50 added to the list)
id,name,duration,predecessors
10,A,7,
20,B,10,10
25,B2,3,10
30,C,5,10
40,D,5,"20,30, 25"
50,E,3,10
Any idea? Thanks in advance

@antserran wow haven't touched this code base in years. The error message is telling you that self.late_finish is None, you cannot subtract an integer from a null value. I have no plans to update this project, so please fork if you plan on making any changes. Good luck!

I know, it seems to be an error. I'm trying to figure it out.


chore: upgrade WebProxyPortlet from 2.3.4 to 2.3.7

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[ ] tests are included
[ ] documentation is changed or added
[ ] message properties have been updated with new phrases
[ ] view conforms with WCAG 2.0 AA

Description of change

Thanks for the approval!


Deka Satori and Koishi not in the Fumo table?

Been a while since they've both released, and yet they're not in the Fumo table while the plush straps (Which released at the same time.) are in said table.
Just thought I'd bring this up since it was bothering me.

Thanks for bringing it up! This was fixed in #10


Add support for OmniAuth 2.0

Hoping this helps the Devise team as they work on releasing an update to support OmniAuth 2.0.
See: https://github.com/heartcombo/devise/issues/5326#issuecomment-758819662

@BobbyMcWho would you be able to review this PR? Sorry I know you’ve been busy 😬

@BobbyMcWho would you be able to review this PR? Sorry I know you’ve been busy 😬

@jkowens sure, sorry I don't get notifications in this repo on activity. I'll take a look today as soon as I can, and I'll figure out who I need to herd to get this released on rubygems.

@jkowens sure, sorry I don't get notifications in this repo on activity. I'll take a look today as soon as I can, and I'll figure out who I need to herd to get this released on rubygems.

It looks like @mbleigh is the owner on rubygems

It looks like @mbleigh is the owner on rubygems

@jkowens Just need the version file update committed since it looks like the Gemfile.lock has this gem bumped to 2.0.0?

@jkowens Just need the version file update committed since it looks like the Gemfile.lock has this gem bumped to 2.0.0?

@BobbyMcWho I think the reason for the version change in Gemfile.lock is because the gem was released as 2.0, but I don't think the Gemfile.lock had been updated.

@BobbyMcWho I think the reason for the version change in Gemfile.lock is because the gem was released as 2.0, but I don't think the Gemfile.lock had been updated.

Ah you're correct, the main branch has v2.0.0 but it's never been released on rubygems.

Ah you're correct, the main branch has v2.0.0 but it's never been released on rubygems.

Thank you both for your work on this! :heart:

Thank you both for your work on this! :heart:

I'll release this as 2.0.0 later, I need to do some history digging and see what has been merged since the last rubygems release was cut.

I'll release this as 2.0.0 later, I need to do some history digging and see what has been merged since the last rubygems release was cut.

@carlosantoniodasilva @jkowens I released it as v2.0.1 just to be safe.

@carlosantoniodasilva @jkowens I released it as v2.0.1 just to be safe.

Perfect, thanks. I'll look into the devise updates next, hopefully this week still.

Perfect, thanks. I'll look into the devise updates next, hopefully this week still.


TypeError: Cannot read property 'prototype' of null

Having this issue when trying to run test samples or any pdf. Any thoughts?
/Users/xxxxxx/projects/pdf-extractor/lib/pdfjs-utils/domfacade.js:117
Object.defineProperty(Canvas.prototype, "getContext", {
                             ^

TypeError: Cannot read property 'prototype' of null
    at Object.<anonymous> (/Users/xxxxxxx/projects/pdf-extractor/lib/pdfjs-utils/domfacade.js:117:30)
    at Module._compile (module.js:660:30)
    at Object.Module._extensions..js (module.js:671:10)
    at Module.load (module.js:573:32)
    at tryModuleLoad (module.js:513:12)
    at Function.Module._load (module.js:505:3)
    at Module.require (module.js:604:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/xxxxxx/projects/pdf-extractor/lib/PdfExtractor.js:4:19)
    at Module._compile (module.js:660:30)

It looks like https://github.com/SyslogicNL/pdf-extractor/blob/master/lib/pdfjs-utils/domfacade.js#L13 does not exist.
What version of jsdom do you have installed?

Closing this in lack of a response.


[bug report] :Need feedback After Clearing item form favourite

Issue Description:
When a user removes their favorite item, the application currently does not provide any indication that there are no favorite items available.
Expected Behaviour:

After clearing an item, you will receive a message indicating that the item is now available.
You will be redirected to the home page or add a navigation button or link,  so that you can continue exploring the application.

@ronisarkarexe absolutely, would you like to work on it?

@ronisarkarexe absolutely, would you like to work on it?

assign me


fixes collection 23 03 2023

Codecov Report
Patch coverage: 85.24% and project coverage change: +0.50 :tada:

Comparison is base (6f1cad5) 90.03% compared to head (b5ae227) 90.53%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   90.03%   90.53%   +0.50%
==========================================
  Files          37       37
  Lines        8897     9307     +410
==========================================
+ Hits         8010     8426     +416
+ Misses        887      881       -6

Impacted Files
Coverage Δ

veritastool/model/modelwrapper.py
64.58% <0.00%> (ø)

veritastool/metrics/fairness_metrics.py
76.57% <52.17%> (+3.41%)
:arrow_up:

veritastool/metrics/performance_metrics.py
79.57% <70.79%> (-1.97%)
:arrow_down:

veritastool/util/utility.py
92.04% <75.00%> (-1.05%)
:arrow_down:

veritastool/principles/fairness.py
79.64% <78.04%> (-0.18%)
:arrow_down:

veritastool/usecases/base_classification.py
91.04% <89.47%> (+0.76%)
:arrow_up:

veritastool/model/model_container.py
89.14% <91.30%> (+0.68%)
:arrow_up:

veritastool/usecases/base_regression.py
93.18% <91.66%> (+2.37%)
:arrow_up:

veritastool/usecases/predictive_underwriting.py
93.87% <92.85%> (+0.12%)
:arrow_up:

veritastool/usecases/credit_scoring.py
91.83% <95.23%> (-0.44%)
:arrow_down:

... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Feature]: PowerApps Checker passing - equality optimisation

Contact Details
No response
Is your feature request related to a problem?
No
Describe the problem?
Does webpack optimisation cause the solution checker to fail?  I've had to avoid that previously when testing webpack., see here: https://github.com/scottdurow/building-power-apps-js-webresources/pull/4
Provide a solution or an idea you would like to see in the tool?
See PR here https://github.com/scottdurow/building-power-apps-js-webresources/pull/4 for a potential fix.
Relevant log output
No response

Released in v1.1.6. Thanks @filcole


how to training with fp16?

When training the large object detection model implemented using mmdetection, cannot set the batch size to more than 1 even use the A6000 (49GB). how to training with fp16?

Have you solved this problem？


Implement hello world in Shakespeare programming language

Update: Additionally, add a Readme file containing a brief description of the language.

I am contributing from hacktoberfest , May I take up this issue?

Sure @hrishik18 , go ahead please


Add socks5 proxy to plugin

Hello from Russia.
Found Issue https://github.com/appleboy/drone-telegram/issues/78 and not closed PR https://github.com/appleboy/drone-telegram/pull/80.
Add socks5 proxy env var to app and test to it usage.
Hope, you`ll merge it and I can use plugin in our CI/CD.

All tests pass if provide socks5 token on my machine

@appleboy Re add env variables for correct processing pull requests

@icecream78 Thanks.


Synthetic Event warning in console when tabbing through the slides

pure-react-carousel version:1.25.2
react version:16+
browser used:google chrome
node version:v12.14.1

What you did:

Carousel Slider in horizontal mode. Then using tab key start tabbing through the slides.
What happened:

When tabbing through the slides multiple instance of below warning was flashed in console.
“Warning: This synthetic event is reused for performance reasons” This warning is triggered when we try to access to a React synthetic event in an asynchronous way. Because of the reuse, after the event callback has been invoked the synthetic event object will no longer exist so we cannot access its properties.
Reproduction:

Suggested solution:

onFocus and onBlur are being passed synthetic events which are null, resulting in this error.
Can you help us fix this issue by submitting a pull request?

I would love to. But not able to take some time out.

I just tabbed through every single slide on every singe example in our demo app and didn't encounter a warning.  Can you share your code?

Yes I also tested by removing a material-ui component and there were no errors in console. Apologize for false alarm. This package is amazing and very useful. Thanks for all the efforts.


Render labels with Typst

For example:
#raw-render(
  ```
  digraph {
    rankdir=LR
    node[shape=circle]
    Hmm -> a_0
    Hmm -> big
    a_0 -> "a'" -> big [style="dashed"]
    big -> sum
  }
  ```,
  labels: (:
    big: [_some_#text(2em)[ big ]*text*],
    sum: $ sum_(i=0)^n 1/i $,
  ),
)

renders as

This is now safe to merge


Create CircleCI jobs for lint and unit-tests

Setup CircleCI config for jobs which trigger lint-ing and unit-tests.

Closed by #26


Add different downsampling methods to PatchGAN discriminator

Dear Monai Team,
I have been working on generating synthetic images using a SPADE GAN similar to this paper  using the monai library and I noticed that your implementation of the PatchGAN discriminator differs slightly from theirs and the official implementation. The main difference is that instead of using a pooling kernel to change the receptive field, you seem to use an increasing amount of layers. I have done some experiments and for my use case, it seems that having a pooling operation improves my results. So my question is the following:

Do you want me to create a PR to add the option for including a pooling operation or was there a reason for the current implementation?

Hi,
I think your proposed change would be good, as long as default behaviour doesn't change with the update, please go ahead with the PR :)
Tagging @virginiafdez in case she has any comments too

Hi! If I remember correctly, we changed the official implementation to make it compatible with other works that were part of the initial set of models that drove the start of this repo. These models used Patch-GAN, but not the pix2pixHD version, hence the difference. However, as long as the defaults don't change, it is great to have alternatives, especially if there's evidence that a certain combination of parameters leads to better results. Thanks!

Implemented in pull request #479 I was just unsure about whether to make the kernel size for the pooling operations another parameter or whether to stick with the same kernel size as the convolutions. For now I did the latter, let me know if you think another approach is better.


attempt to index a nil value (upvalue 'WPR')

WPR removed?

It has been deprecated and removed in the latest release. Use lnxLib.TF2.PlayerResource instead.


ENH: combine_evoked

Ready for review/merge from my end.
One issue is the weighting. @agramfort you had something much more complex:
https://github.com/mne-tools/mne-python/pull/461/files#diff-738430c6d6954d2d42b2632b6fd1a0bdR631
Is that because you wanted to be able to use weights like e.g. [1, -1] instead of [evoked1.nave, -evoked2.nave] for a simple subtraction?

Travis is unhappy, so I need to fix that. But in the meantime I'm curious what people think the preferred weighting and resulting nave should be.

I think the new grand average function should also be updated and use the new function + ecpose the options.

@dengemann based on how the grand average function is structured, I'm not sure it makes sense to expose the weighting options. Perhaps more importantly, if you don't do equal weighting, I don't think it's a grand average anymore...?

Right. Then don't expose it.
2015-01-19 17:22 GMT+01:00 Eric Larson<EMAIL_ADDRESS>
@dengemann https://github.com/dengemann based on how the grand average
function is structured, I'm not sure it makes sense to expose the weighting
options. Perhaps more importantly, if you don't do equal weighting, I don't
think it's a grand average anymore...?
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/pull/1747#issuecomment-70520347.

@Eric89GXL are you done here?

Yeah I was just waiting to make sure Travis and AppVeyor came back happy, feel free to review/merge.

LGTM
please update what's new

Done

thanks @Eric89GXL !


Border collapse not rendering correctly for chrome

Great work on the library!
Regarding html2canvas v1.0.0-alpha.12 -- I am attempting to convert html that contains a table with borders to a canvas, however, when I attempt to do so the borders will double in size. It appears that the borders are separated rather than collapsed. Is there a fix or work around regarding this?
Please see an example here: https://jsfiddle.net/meloera/91d7ujaq/1/
Specifications:

html2canvas version tested with: html2canvas v1.0.0-alpha.12
Browser & version: Chrome Version 72.0.3626.121
Operating system: Windows 10

I appreciate any guidance. Thanks,

Any update?

see #2194

Another testcase with different border colors for each side to demonstrate that border-spacing has no effect as expected but the actual rendering seems to be identical to border-spacing:0 combined with border-collapse:separate instead of true border-collapse:collapse:
https://jsfiddle.net/1ktbd0em/


[5.6] Add 'after' callback for model factories

This PR implements the ability to add an after callback for model factories. The callback allows the user to define an action to be run after the model is created or made. A common use case for this behavior is to associate a user who is the owner of a group or team with the group or team, or to create an associated profile record for a new user model.
# TeamFactory.php

use Faker\Generator as Faker;

$factory->define(\App\Team::class, function (Faker $faker) {
    return [
        'name' => $faker->company,
        'slug' => $faker->slug(2),
        'owner_id' => function () {
            return factory(\App\User::class)->create()->id;
        },
    ];
});

$factory->after(\App\Team::class, 'create', function(\App\Team $team, Faker $faker) {
   $team->users()->attach($team->owner, ['role' => 'owner']);
});

If the action is omitted from the after function call, 'create' is assumed. Simplified ussage documentation snippet below:
After Callbacks
After callbacks allow you to define additional required logic to run after a model is created by a model factory. For example, your User model might have a required profile model, or you have a group or team model that has an owner but also requires the user to be added to a pivot table.
$factory->after(\App\Team::class, function(\App\Team $team, Faker $faker) {
     $team->users()->attach($team->owner, ['role' => 'owner']);
});

By default after callbacks are run after a model is created; if you want to run a callback after a make() call you can define the action the callback is to be run after as a third argument.
$factory->after(\App\User::class, 'make', function(\App\User $user, Faker $faker) {
     $profile = factory(\App\Profile::class)->make(['user_id' => $user->id]);
     $user->setRelation('profile', $profile);
});

I really like this, but I think it would be more relevant if you could show an use-case that cannot be achieved by Eloquent Created Event.

Yah, part of me feels this would be more appropriate to do in your Seeder class. IMO, the Factory class should be responsible only for generating it's single class, and additional logic should be done either with event handlers, as @deleugpn suggested, or in the corresponding Seeder.

Hmm, maybe I'm just missing an existing opportunity here. I specifically ran into wanting to do this in testing where I needed to have a team, which has users and belongs to an owner. Existing functionality lets me define the owner of the team when I fake up a team; but that owner isn't a member of the team until they're also added to the pivot table. The team isn't valid without an owner_id. Similarly, the team isn't valid if the owner isn't also a member.
I don't think the Eloquent Created event applies to this situation, unless there is an intuitive way I'm missing to add this event listener during test setup?
I will concede that I can just attach the user to the team as the second line every time I create a new team. But I literally do it every test that has a team, they are directly coupled which is why I think this is appropriate.

+1
The way i'm doing it know is that i add methods to my test case like createUser(), createPaper(), create...
Which makes the test case feel gross.
I was thinking about making a PR that does the exact same thing :D hope it gets merged, this is really what i have been missing for my tests

I like this a lot. The case that is missing is applying it conditionally like with a state. If it is something that should always be done when that model is created use events. I have room into this car where I want to make records and children for tests. The test code ends up with a ton of boilerplate. An API that let you bind after callbacks to a specific state would be awesome. Something like factory(User::class)->states('withPosts')
Shouldn't the action be 'created' ?

I get the action names now. I would rather see methods named afterCreate afterMake

Made some changes to this. Methods are afterMaking and afterCreating... also allow you to register multiple callbacks per model.

I still want to see them per state :-\

Would you accept a priority that allowed you to set them by state?

This should be reflected in documentation.


error in paperclip copy method as it works only for windows

Hey @AshstarTempest! Could you provide more information about the issue, like the system you are using? I recently tested the program on macOS 14, and it worked perfectly fine.


Check if site is responsive

Ehh, a quick google search suggests this isn't really possible. We'd need to:

Use user agent spoofing to see if we're server-side detected and served a mobile site (or redirected)
Check for client-side detection
Check for media queries


Enable user defined display_name for ScalarUDF

Which issue does this PR close?

Closes #10376 .
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Do you mind adding display_name for get_field that shows what I expect in the example given in #10376?

Cool, will do that.

It's good now. @jayzhan211 You can review it when you are available. :)
In this example https://github.com/apache/datafusion/blob/96487ea0cbb7901a1e4aa18fdf6deb8961319fea/datafusion/core/tests/user_defined/user_defined_aggregates.rs#L165-L176, after apply_function_rewrites, the logical plan would not create an alias because the display_name of get_field is the same as sq.first[value]
In this PR:
"| initial_logical_plan                                       | Projection: (sq.first)[value], (sq.first)[time]                                                                                |",
"|                                                            |   SubqueryAlias: sq                                                                                |",
"|                                                            |     Projection: first(t.value,t.time) AS first                                                                                |",
"|                                                            |       Aggregate: groupBy=[[]], aggr=[[first(t.value, t.time)]]                                                                                |",
"|                                                            |         TableScan: t                                                                                |",
"| logical_plan after apply_function_rewrites                 | Projection: get_field(sq.first, Utf8("value")), get_field(sq.first, Utf8("time"))                                                                                |",
"|                                                            |   SubqueryAlias: sq                                                                                |",
"|                                                            |     Projection: first(t.value,t.time) AS first                                                                                |",
"|                                                            |       Aggregate: groupBy=[[]], aggr=[[first(t.value, t.time)]]                                                                                |",
"|                                                            |         TableScan: t                                                                                |",
Before this PR:
"| initial_logical_plan                                       | Projection: (sq.first)[value], (sq.first)[time]                                                                                |",
"|                                                            |   SubqueryAlias: sq                                                                                |",
"|                                                            |     Projection: first(t.value,t.time) AS first                                                                                |",
"|                                                            |       Aggregate: groupBy=[[]], aggr=[[first(t.value, t.time)]]                                                                                |",
"|                                                            |         TableScan: t                                                                                |",
"| logical_plan after apply_function_rewrites                 | Projection: get_field(sq.first, Utf8("value")) AS sq.first[value], get_field(sq.first, Utf8("time")) AS sq.first[time]                                                                                |",
"|                                                            |   SubqueryAlias: sq                                                                                |",
"|                                                            |     Projection: first(t.value,t.time) AS first                                                                                |",
"|                                                            |       Aggregate: groupBy=[[]], aggr=[[first(t.value, t.time)]]                                                                                |",
"|                                                            |         TableScan: t                                                                                |",
"| logical_plan after inline_table_scan                       | SAME TEXT AS ABOVE

Thanks @yyy1000  and @jayzhan211


Therefore I don't think is going to be a huge problem, as this packaged is more suitable for mobile apps (not PWA) where all files are locally and loading them all should not cause a considerable difference in performance.


Update

Codecov Report
Attention: Patch coverage is 97.29730% with 9 lines in your changes missing coverage. Please review.

Project coverage is 98.49%. Comparing base (4356411) to head (f8124e6).
Report is 2 commits behind head on main.

Files with missing lines
Patch %
Lines

pkg/dohdec/lib/dnsUtils.js
92.70%
7 Missing :warning:

pkg/dohdec/lib/doh.js
96.42%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   99.77%   98.49%   -1.28%
==========================================
  Files           6        6
  Lines        1337     1332       -5
==========================================
- Hits         1334     1312      -22
- Misses          3       20      +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Problem parsing list argument in LLaMA model

The problem boils down to the following. If LLaMA outputs a list as argument to a function
<function-thoughts>I can use the `send_email` function to send an email to the specified recipient with the given subject and body.</function-thoughts>
<EMAIL_ADDRESS>subject="Important message!", body="Hey, how is it going?")]</function-call>

this goes through the function parse_tool_calls_from_python_function and throws error:
agentdojo.ast_utils.ASTParsingError: The keyword values should be literals. Got: <ast.List object at 0x7f4e78077df0>

because it fails to parse the list correctly here.
A minimal reproducible example follows:
output =<EMAIL_ADDRESS>subject="Important message!", body="Hey, how is it going?")]"""
parsed_model_output = ast.parse(output)
if not isinstance(parsed_model_output.body[0], ast.Expr):
        raise ASTParsingError("Error parsing the model output.")
if not isinstance(parsed_model_output.body[0].value, ast.List):
    if not isinstance(parsed_model_output.body[0].value, ast.Call):
        raise ASTParsingError(f"The function calls should be given a list. Got {parsed_model_output.body[0].value}")
    calls_list = [parsed_model_output.body[0].value]
else:
    calls_list = parsed_model_output.body[0].value.elts

call = calls_list[0]

class ASTParsingError(Exception): ...

args = {}
for keyword in call.keywords:
    if not isinstance(keyword.arg, str):
        raise ASTParsingError(f"The keyword arguments should be strings. Got {keyword.arg}")
    if not isinstance(keyword.value, ast.Constant):
        raise ASTParsingError(f"The keyword values should be literals. Got: {keyword.value}")
    args[keyword.arg] = keyword.value.value

I am not sure if this is supposed to be the case but lists as arguments seem reasonable in this case. I implemented a workaround using:
def parse_tool_call_from_ast(call: ast.expr) -> FunctionCall:
    if not isinstance(call, ast.Call):
        raise ASTParsingError("The function calls should be in the form of a call.")
    if not isinstance(call.func, ast.Name):
        raise ASTParsingError("The function calls should be in the form of a function name.")
    function_name = call.func.id
    args = {}
    for keyword in call.keywords:
        if not isinstance(keyword.arg, str):
            raise ASTParsingError(f"The keyword arguments should be strings. Got {keyword.arg}")
        if not isinstance(keyword.value, ast.Constant) and not isinstance(keyword.value, ast.List):
            raise ASTParsingError(f"The keyword values should be literals. Got: {keyword.value}")
        if isinstance(keyword.value, ast.List):
            # TODO: workaround for lists. Get the value of each element in the list
            args[keyword.arg] = [element.value for element in keyword.value.elts]
        else:
            args[keyword.arg] = keyword.value.value

    random_string = "".join(random.choices(string.ascii_lowercase + string.digits, k=10))

    return FunctionCall(function=function_name, args=args, id=f"tool_call_{random_string}")

Not sure if this was intended or if there is a better way to handle this. I leave up to you to find the best solution! :)

Also seems to fail for nested function calls. I have not found a solution for this yet.
output = """<function-thoughts>I need to find a way to determine Emma's next yoga class. I don't have any information about her schedule, so I'll need to use the provided tools to find out. Let's start by searching for calendar events.</function-thoughts>
<function-call>[get_day_calendar_events(day=get_current_day())]</function-call>"""

Thanks! Should be fixed now

As per nested function calls, it would require more work. Should probably be fixed via prompting for now, as it would require expanding the FunctionRuntime's features


Append stdErr log to error message when a streamed console command fails.

Currently streamed commands only return the process exit code on error, which is rarely helpful for debugging. This change appends the accumulated stdErr log to the end of the message, similar to how we report console errors during jupyter server startup.

@chlafreniere That test failed again, should we move it to unstable?

@aaomidi yes we should

Seems like the failure only happens on my branch. Looking into it.

Running a new test here: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=42935&view=logs&j=d46bdafb-39a9-561e-f56f-8f45577d0334

Regardless, the test has been failing ~3% of the time recently, something like that. we'll need to investigate why data isn't getting propogated when expected through the extensibility APIs.


tried the 1.0 branch but no luck

Hello,
After checking the 0.5.1 version I noticed the branch 1.0.0. I've tried but i'm receiving this:

Perhaps is my lack of knowledge, if it's so, my excuses in advance
PS: I've compiled in a joomla vagrant box in a macosx (joomlatools vagrant box: https://www.joomlatools.com/developer/tools/vagrant/) but I've followed the installation step till last:
php -S localhost:8080 -t ./public/ (I've not used because I've the server going on the vagrant box. I've copied the ppma folder to my /var/www/ppma1 and I tried browsing http://joomla.box/ppma1/public/index.php with that result.
I'm doing something wrong?
Regards.

Hi,
the 1.0.0-branch is still under development and doesn't work atm.
Regards, Pierre

Oh, ok then. There is any place pointing the features of the 1.0 version?
I'm being hyped :dancer:
thanks for your efforts. Regards.


Allow HTML in footer like before

Hello there,
I would like to ask if you could allow again to add HTML code in the translation panel of your amazing AMP plugin. I used to add my own HTML code, but I see now that the code is being translated to the code corresponding to the special characters such as < becomes <. Could this be allowable again?
Also I want to ask you if the plugin is compatible with All in one SEO pack which I prefer over Yoast as it doesn't require a load of information which Yoast needs. (Should I desactivate Add Meta Tags from Yoast and Yoast Custom Description for AMP page with AIO SEO?)
Next I went to ask if it's possible to toggle the from and date on pages as I see it's on my page: https://www.brainobrainlyon.fr/quest-ce-que-brainobrain/amp/ .
And finally I would like to point towards a bug that I discovered on the Amp homepage (the older bug I mentioned a month before seems to be corrected by the way! Great work!): The image width is of 0, which generates an error in the Google Search Console.
Thank you for your wonderful plugin,
Cheers!
Wout Heijnen

Done :)


PRometheus on cluster to Managed Prometheus - what is the required inputs/filters to parse - important aws account(environment), kubernetes cluster, namespace, application pod name and route the monitoring information to central AWS Managed Prometheus? We noticed that the information collected from the bluenrpints prometheus exporter is not able to collect in PRometheus with required minimum information.

[ ] ✋ I have searched the open/closed issues and my issue is not listed.

Please describe your question here

Provide a link to the example/module related to the question

Additional context

Hey, please make sure to correct this issue by placing a correct title and putting the relevant details in the issue details and not in the title itself. Thanks.


AppCrash (local user)

Hello,
Windows 10 14393, x64
DependenciesGui.exe crash on start. Version 1.8 from latest Release section.
Local user account without administrative privileges - permanent crash on startup.
Running as admin (with elevation) everything work as expected.
Running as admin (without elevation) everything work as expected.
Related Event Log entries
Application Error

Faulting application name: DependenciesGui.exe, version: <IP_ADDRESS>, time stamp: 0x5b2ac677
Faulting module name: KERNELBASE.dll, version: 10.0.14393.2457, time stamp: 0x5b7e2a65
Exception code: 0xe0434352
Fault offset: 0x000dad12
Faulting process id: 0x17a0
Faulting application start time: 0x01d460a7e4531888

.NET Runtime

Application: DependenciesGui.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.OverflowException
at System.ClrPh.PE.InitProperties()
at System.ClrPh.PE.Load()
at Dependencies.BinaryCache.GetBinary(System.String)
at Dependencies.BinaryCache.Load()
at Dependencies.App.App_Startup(System.Object, System.Windows.StartupEventArgs)
at System.Windows.Application.OnStartup(System.Windows.StartupEventArgs)
at System.Windows.Application.<.ctor>b__1_0(System.Object)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.DispatcherOperation.InvokeImpl()
at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object)
at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(System.Object)
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object)
at System.Windows.Threading.DispatcherOperation.Invoke()
at System.Windows.Threading.Dispatcher.ProcessQueue()
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)
at MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)
at System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame)
at System.Windows.Threading.Dispatcher.PushFrame(System.Windows.Threading.DispatcherFrame)
at System.Windows.Application.RunDispatcher(System.Object)
at System.Windows.Application.RunInternal(System.Windows.Window)
at System.Windows.Application.Run(System.Windows.Window)
at Dependencies.App.Main()

Other executables such as  Dependencies.exe and Pview.exe run well.
p.s.
Forgot to add, exact faulting exe is from Dependencies_x86_Release.
Dependencies_x64_Release - problem not reproducible.

DependenciesGui.exe has a "binary cache" : at startup it loads up regularly used dlls like KnownDlls in order to speed up further loadings and to work around the fact that Windows locks loaded dlls. Except this binary cache lookup is quite tricky to implement and has some bugs in the past.
Any DLL loaded is copied into %LOCALAPPDATA%/Dependencies/BinaryCache/${Arch} (where ${Arch} is x64 or x86) and further loads are done from this folder. My guess is your cache is not "clean" anymore, there is probably a corrupted entry that choke Dependencies at startup. You can always clean up the folder and try to restart DependenciesGui.exe to solve the issue (the good ol' switching off and on !).
Alternatively, the current master build does not suffer from this issue : https://ci.appveyor.com/api/buildjobs/wj0o9hdahgu9oc6k/artifacts/output%2FDependencies_x86_Release.zip.  (I've fixed some bugs plaguing the x86 version in the meantime, it may also have fixed your crash)

Cleaning binary cache solved this crash, thanks.


[Bug] On Radar Chart Axis name Overflow property is not working

Version
5.2.2
Link to Minimal Reproduction
No response
Steps to Reproduce

option = {   title: {     text: 'Basic Radar Chart'   },   legend: {     data: ['Allocated Budget', 'Actual Spending']   },   radar: {     // shape: 'circle',     indicator: [       { name: 'Sales', max: 6500 },       { name: 'Administration', max: 16000 },       { name: 'Information Technology', max: 30000 },       { name: 'Customer Support', max: 38000 },       { name: 'Development', max: 52000 },       { name: 'Marketing', max: 25000 }     ],     axisName: {       color:'red',       overflow:'truncate',       ellipsis:'...',       width:10,     }   },   series: [     {       name: 'Budget vs spending',       type: 'radar',       data: [         {           value: [4200, 3000, 20000, 35000, 50000, 18000],           name: 'Allocated Budget'         },         {           value: [5000, 14000, 28000, 26000, 42000, 21000],           name: 'Actual Spending'         }       ]     }   ] };
I have used above options as mentioned on the echarts examples.
Current Behavior
As one can see the axis name or indicators are overflowing and not truncating.
Expected Behavior
Axis name/ indicators should truncate and end with ellipsis
Environment
Echart examples editor.
https://echarts.apache.org/examples/en/editor.html?c=radar

Any additional comments?
No response

Hello, it seems overflow on axisname still doesn't work for radar charts on echart 5.5.1
Any news about this issue or the linked PR https://github.com/apache/echarts/pull/17212?


Document how to dispatch packets to the correct connections

This isn’t currently documented anywhere that I could see.  Doing it based on the UDP 5-tuple breaks roaming.

Also, does this support roaming?  How are packets routed to the correct nginx process?


contains-regex: new macro for more general regex checks

The new assert_contains_regex macro makes it easy to check that the
current version number is mentioned in a given file.
Fixes #17.

Codecov Report

Merging #48 into master will decrease coverage by 0.27%.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##           master     #48      +/-   ##
=========================================
- Coverage   93.67%   93.4%   -0.28%
=========================================
  Files           2       2
  Lines         348     364      +16
=========================================
+ Hits          326     340      +14
- Misses         22      24       +2

Impacted Files
Coverage Δ

tests/version-numbers.rs
100% <100%> (ø)
:arrow_up:

src/lib.rs
93.29% <85.71%> (-0.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644441b...82d7dc7. Read the comment docs.


Sign both test and prod assemblies

The private key is checked in, as recommended in
https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/strong-name-signing.md
The public key can be derived from the private one, so there's no need to check it in here.
The test assembly needs to be signed as the prod assembly exposes its internals to the test assembly.

LGTM


fix: remove unused auctionsLotStandingConnection from profile

The type of this PR is: fix
This PR fixes a bug where an unused query may cause a user's profile to not load.

So if I'm understanding this correctly, these queries aren't used in the app but were when MyBids was in the profile tab? If so 👍


Python Pep Coding Standard

I love this project and it seems very promising. You might want to follow this coding standard: https://www.python.org/dev/peps/pep-0008/#code-lay-out
I was able to review the code and it would be nice if you could use 4 spaces per indentation level.

Good idea !

After thursday i will start new updates(hope so), thanks.

https://github.com/b3mb4m/shellsploit-framework/commit/b9c0a3b99ed5ba46e0f1491e7f4191938202043f
Done.


Update: Tooltip position behavior near edge

Description
If the tooltip gets too close to the right edge of the chart it will just stay snapped to the right side. This can be an issue because it will cover the data the user wants to look at
Proposed Changes

Mirror the tooltip over the vertical bar to the left side of the data instead of blocking the right side of the data

Screenshots
Before:

After:

License
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Can we also make this change in the c3 repo as well?

Can we also make this change in the c3 repo as well?

I made an issue for it https://github.com/c3js/c3/issues/2754 to see if they are interested

Pull requests are welcome, though please post an issue first to see whether such a change is desirable.
https://github.com/c3js/c3#pull-requests


cdk-dynamo-table-viewer incompatible with CDK 1.106.0

    aws-cdk-aws-sns 1.106.0 depends on jsii<2.0.0 and >=1.29.0
    aws-cdk-cx-api 1.106.0 depends on jsii<2.0.0 and >=1.29.0
    aws-cdk-region-info 1.106.0 depends on jsii<2.0.0 and >=1.29.0
    cdk-dynamo-table-viewer 3.1.2 depends on jsii~=0.21.1

Current master seem to have been updated https://github.com/cdklabs/cdk-dynamo-table-viewer/blob/master/package.json#L45
https://github.com/cdklabs/cdk-dynamo-table-viewer/issues/13

There are two packages on PyPi
https://pypi.org/project/cdk-dynamo-table-viewer/
https://pypi.org/project/cdk-dynamo-table-view/

Corrected this requiring "cdk-dynamo-table-view==0.1.19",

@gliptak Did the above mean #13 is fixed?

@GrahamLea yes HEAD / right PyPI package works with latest CDK 1.x
The documentation might want to capture the right PyPi package name


Switch gRPC sidecar-to-sidecar to create one connection per each pod

This a second attempt at fixing the issue started in #7328

Dependencies:

https://github.com/dapr/kit/pull/80
https://github.com/dapr/components-contrib/pull/3284

Users are reporting errors in service invocation that indicate that the gRPC connection between sidecar has failed. Logs (with #7327 merged) include something like:

{"app_id":"app-id","instance":"...","level":"warning","msg":"HTTP service invocation failed to complete with error: readfrom tcp <IP_ADDRESS>:3500-\u003e<IP_ADDRESS>:47102: error receiving message: rpc error: code = Unavailable desc = closing transport due to: connection error: desc = "error reading from server: unexpected EOF", received prior goaway: code: NO_ERROR, debug data: "max_age"","scope":"dapr.runtime.http","time":"2023-12-20T23:11:38.819884017Z","type":"log","ver":"edge"}

Upon further investigation over the last 2 days together with @yaron2 , we identified the issue to be related to load balancing of gRPC connections, which was interacting poorly with our use of MaxAge. You can read more details here: https://kubernetes.io/blog/2018/11/07/grpc-load-balancing-on-kubernetes-without-tears/
This PR attempts to fix the issue by following the recommendation in the blog post above, specifically about load balancing pools.

Dapr already had a load balancing pool, which was implemented a long time ago. However, in our pool we were putting connections created against a DNS name.
In environments like K8s, a DNS name can resolve with multiple A/AAAA records, so gRPC automatically creates connections to each of them.
We also set a MaxAge to allow the connection to be re-created after a delay. This was necessary because if the list of pods that resolve with a given DNS name change (e.g. when the app is scaled horizontally), gRPC doesn't automatically refresh them. It is required to close and re-create the connection.
The MaxAge was causing servers to send GOAWAY requests to clients, causing the bug shown above

The way this PR attempts to solve the issue is to:

Add a new, optional method to nameresolvers ResolveIDMulti, which returns a list of addresses.

In the K8s nameresolver, this performs actual DNS resolution and returns a list of IPs

If the nameresolver implements that method, when creating a gRPC connection to the target sidecar we pick a random address from the list of addresses returned

To avoid performing DNS resolution on every invocation, the result is cached. The value in the cache has a TTL of 30s and is automatically deleted after certain failures (such as connection errors).
This works because when Dapr creates Service resources, we make them headless, so we can get the list of A/AAAA records via a normal DNS lookup.
Note: all other nameresolvers already return a single IP in ResolveID (such as Consul, mDNS, SQLite). They already pick a random one from a pool.  By returning a different IP every time, they already cause gRPC to create individual connections, just like this PR does for K8s. Those don't need to be updated to use ResolveIDMulti, unless we want to use the cache (which may be useful for performance).

This way, we create a connection to one specific sidecar, and not a load-balanced IP.
Remove MaxAge from the gRPC server, since it's not needed anymore, and we can get load balancing (with automatic refresh of the addresses) without forcefully destroying connections. There's still a timeout on idle connections, both on the server and client.

Add a new E2E test to validate that if an app is deployed with > 1 replica, requests are load balanced across the 2 instances.

@ItalyPaleAle Please resolve conflicts

@ItalyPaleAle Please resolve conflicts

Done


[in_app_purchase_storekit] Native code returns wrong type for error code in SKReceiptManager.retrieveReceiptData

Steps to reproduce
Call SKReceiptManager.retrieveReceiptData on a device without receipt data available.
Expected results
A PlatformException is thrown.
Actual results
A type error is thrown:
type 'int' is not a subtype of type 'String' in type cast

#0      InAppPurchaseAPI.retrieveReceiptData (package:in_app_purchase_storekit/src/messages.g.dart:810:38)
<asynchronous suspension>
#1      SKReceiptManager.retrieveReceiptData (package:in_app_purchase_storekit/src/store_kit_wrappers/sk_receipt_manager.dart:22:13)
<asynchronous suspension>
#2      ShopClientImpl._dispatchPurchasedStoreKitTransactions (package:fourpics_native/shop/service/shop_client.dart:134:23)
<asynchronous suspension>

Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.16.9, on macOS 14.2.1 23C71 darwin-arm64, locale en-US)
    • Flutter version 3.16.9 on channel stable at /Users/terwesten/fvm/versions/3.16.9
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (6 weeks ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/terwesten/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/terwesten/Library/Android/sdk
    • Java binary at: /Users/terwesten/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Users/terwesten/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.3.4)
    • IntelliJ at /Users/terwesten/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2023.3.4)
    • IntelliJ at /Users/terwesten/Applications/IntelliJ IDEA Community Edition.app
    • Flutter plugin version 78.1.1
    • Dart plugin version 233.13763.5

[✓] VS Code (version 1.87.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (3 available)
    • iPhone von Gabriel (mobile) • 00008130-001C71EC36B8001C • ios            • iOS 17.3.1 21D61
    • macOS (desktop)             • macos                     • darwin-arm64   • macOS 14.2.1 23C71 darwin-arm64
    • Chrome (web)                • chrome                    • web-javascript • Google Chrome 122.0.6261.94

[✓] Network resources
    • All expected network resources are available.

• No issues found!

cc @LouiseHsu


A few questions regarding your setup

Hey Fabian,
I don't really experience troubles with your starter and I find it pretty awesome! 🎉 I have a few questions regarding the project and couldn't find a more appropriate place to ask 👍
Questions
❓/static/social.png - couldn't find any good usage. On the other hand I see /src/images/icon.png which seems to be used globally for the favicon and some other configs. Wouldn't it make more sense to replace social.png with icon.png or you have other plans?
❓ Regarding the available npm scripts I'm a bit confused. I assume the build command would be sufficient so we can deploy the generated /public folder and its contents? Is this correct assumption?
❓Can you please elaborate a bit on /scripts/lighthouse.test.js and its usage? I find it pretty interesting.
❓Can you please elaborate on the purpose and usage of the ssr script?
❓Why do you use your own site-config.js file instead of placing its contents directly in gatsby-config.js. It can later replace the two usages of site-config.js?
Feedback
I want to say thank you for this amazing template and I find it one of the best in terms of goals and ideas! There are a few notes I'd like to share as a developer. Feel free to neglect or ignore, but let me know if they make sense and you want to discuss them further.
🤔 The template gets a bit too opinionated making it hard to use out-of-the-box without "clearing" it first. I'd say that most of the code in /src can be omitted for simplicity. You can maybe clone this repo so you keep the demo site as is, but then simplify the template itself.
🤔 I'd really love to use this starter as base on top of I want to migrate 2 websites and 1 simple web app. However, given my previous note it would be hard to reuse it directly and most likely will end up "simplifying it" just a bit...
🤔 Consider adding Eslint it gets along with Prettier pretty well.
Thank you for the amazing work!
Let me know if my comments do or don't make sense. Cheers!

@SMerdzhanov, thanks for the feedback! I'm happy to address your questions.

❓/static/social.png - couldn't find any good usage.

This image is used as a fallback for the social images on Twitter cards, Facebook posts, etc. You can find it being referenced inside https://github.com/fabe/gatsby-universal/blob/master/src/components/head/head.js#L58.

❓ Regarding the available npm scripts I'm a bit confused. I assume the build command would be sufficient so we can deploy the generated /public folder and its contents? Is this correct assumption?

Yes, yarn build/npm run build generates the full static site into /public. From there you can upload or deploy it anywhere.

❓Can you please elaborate a bit on /scripts/lighthouse.test.js and its usage? I find it pretty interesting.

This isn't fully fleshed out, but it runs a Lighthouse audit programmatically and checks if all scores are above 90. Right now it uses the previously deployed version, but I'm working on testing the actual build. You can see it in action inside the CircleCI integration (yarn test).

❓Can you please elaborate on the purpose and usage of the ssr script?

yarn ssr runs the build script and serves the /public folder on a local server. You can then use this server to run Lighthouse (and other) audits and check how Gatsby builds your site. It's basically a shortcut of doing gatsby build && gatsby serve.

❓Why do you use your own site-config.js file instead of placing its contents directly in gatsby-config.js.

The only reason so far for this is that I need the same data inside scripts/favicons.js to generate the manifest. But you have a point there, I might put everything inside gatsby-config.js.

🤔 The template gets a bit too opinionated making it hard to use out-of-the-box without "clearing" it first.

True, I think I'll either add some hints (e.g. "first steps") in the readme or a codemod that gets rid of some of the example code.

it would be hard to reuse it directly and most likely will end up "simplifying it" just a bit...

I would definitely encourage it! This repo is more a collection of patterns, ideas and examples. Cherry picking the things you need and removing the stuff you don't is usually inevitable with any kind of boilerplate.

🤔 Consider adding Eslint it gets along with Prettier pretty well.

Gatsby v2 already comes with ESLint set up, so it should be just a matter of adding a .eslintrc file into the root of the project. I'll stick with the Gatsby default config for now!
Thanks again! Hope I could clear some stuff up, let me know if there's anything else that comes up.

Hey!
Thank you for the fast response, didn't expect it although you're actively developing!
I'm kind of new to Gatsby so this might be the reason for some of the uncertainties. All of your responses seem clear and meaningful to me.
The only remaining question on my end would be about your last point - ESLint.
I haven't encountered any comments about it so far, but will check. If there's truly a reusable configuration that can be used while developing, there's no need to overthink it, right.
Thank you for the help! 🎉
Cheers!

Yep, the ESLint integration is not documented anywhere yet, there's only a stub. And I'm just now noticing that you actually need to add a plugin for ESLint to work: mongkuen/gatsby-plugin-eslint.

Hmm, I don't see the benefits of using the gatsby-plugin-eslint vs doing your own 🤔
I'll search around for this. Thank you for the responses!
Feel free to close this 👍


Wrong behavior for wofi

version: hyprland-git 41f7736c8521162cb3ea5f3c003e0643c1bcf616dirty
os: manjaro linux
There's no wofi client information (hyprctl clients) while wofi is opened and the active client information is the window class below wofi.
Any suggestions?

wofi is not a window, see hyprctl layers

I use xremap to remap keyboard to emacs key bindings, it's failed as wofi is a layer (old version is a window). Is there any way to get the active layer?

don't use xremap cuz it's x?

xremap could be used with wayland. I'd submitted a PR for hyprland supporting.
BTW, is there any plan to add functionality to get current active layer like activewindow?

no


The input search always 100%, not take the remaining width.

As the example link : http://angular-ui.github.io/ui-select/demo-multiple-selection.html
The input seach width always 100%. It should be the remaining width of element until its size > 50px.
I think there is some problem with updateIfVisible function.
angular-ui version : 0.19.8

https://github.com/angular-ui/ui-select/issues/2010
https://github.com/angular-ui/ui-select/issues/1980


Add build time to version info

This RP modifies the output of kore-rpc-booster --version to include the build time:
kore-rpc-booster --version
hs-backend-booster version:
  revision:	0f1143648471ab3ea61da49b7d8fff3fa67168a0 (dirty)
  branch:	georgy/better-unclear-condition
  last commit:	Wed Jan 24 10:10:46 2024 +0000
  build time:	2024-01-25 08:24:28.060971253 UTC

My primary motivation for this change is convincing myself that I'm not using a stale build when testing locally.

Makes sense. Let's close it and I can reapply it locally if I'm paranoid again.


Fixed a bug in which totals doesn't work for column-indexed tables

In a nutshell, this fixes fixes #49. While doing that I tried to make the design a bit simpler in terms of handling totals. For such, I got rid of most hardcoded Totals strings I found and passed a display label for Totals as part of display_options, so that the Total implementation have less corner cases and look more like an ordinary metric. That will also make future refactoring easier. Besides, the NaN in columns with rollups are being replaced with Totals.key right at the source (i.e. query_data), even before setting the indexes. Some tests were also fixed, especially test_rollup_cont_cat_cat_dim_multi_metric() in test_datatables, which had all values for Totals set to None and therefore was essentially wrong.

Coverage decreased (-0.05%) to 97.505% when pulling 44d562222c26adea1275c381f184029a69c9e80b on x8lucas8x:fix-totals-for-column-indexed-tables into 96f14931c6a0f49f53aa2d678aa080799c50bf43 on kayak:master.

Coverage decreased (-0.04%) to 97.511% when pulling b76e1430d3dbe35e70d2f0e177032e9a7d262492 on x8lucas8x:fix-totals-for-column-indexed-tables into 96f14931c6a0f49f53aa2d678aa080799c50bf43 on kayak:master.

Coverage decreased (-0.04%) to 97.511% when pulling 909e8c453f16b7b1d14dfa295b56ad5bef94e450 on x8lucas8x:fix-totals-for-column-indexed-tables into 96f14931c6a0f49f53aa2d678aa080799c50bf43 on kayak:master.

Coverage decreased (-0.04%) to 97.52% when pulling<PHONE_NUMBER>74433e60e3fb2dd87a1a1aa534e55d on x8lucas8x:fix-totals-for-column-indexed-tables into 2c3f528647009b583dfdbc4c33a626a3b8c8f972 on kayak:master.


Force resolution of vue causing dual package hazard in testing

According to https://github.com/vuejs/vue-test-utils/issues/1982#issuecomment-1201131222. https://github.com/vitejs/vite-plugin-vue2/commit/9a78726d77ef9aadf3c07dacd4c27828fe8f4ac8 forces resolution to entry vue/dist/vue.runtime.esm.js.
But in test environment, vue.runtime.mjs should be used to avoid dual package hazard.
Maybe check the environment to conditionally override resolve.alias in this plugin?

closed as Vue 2 reached EOL


Upgrade upload-artifact and download-artifact actions from v3 to v4

The v3 to v4 upgrade introduces three breaking changes: https://github.com/actions/upload-artifact#breaking-changes
Two of them are not relevant as we don't support self-hosted runners, and we only ever save one artifact per job.
The other is that the artifacts are now immutable -- we cannot keep uploading wheels to the same artifact in each job. I've updated the workflow to write a separate artifact per build job and merge them in the upload job.
Supersedes #173 and #174.

Thanks! Is this compatible with how astropy uses this workflow in https://github.com/astropy/astropy/blob/main/.github/workflows/publish.yml ? cc @astrofrog and @saimn

For other downstream packages that uses this, will things just work or we have to change stuff too in our own repos?

Given that some artifacts are uploaded as nightly wheels (say, to https://anaconda.org/astropy/astropy/files?type=pypi ), how will this affect the "old files pruning" script that @astrofrog previously implemented?

Tested in this workflow run: https://github.com/OpenAstronomy/github-actions-workflows/actions/runs/7412831365/job/20170967258?pr=178#step:4:6

Thanks! Is this compatible with how astropy uses this workflow in https://github.com/astropy/astropy/blob/main/.github/workflows/publish.yml ? cc @astrofrog and @saimn

The astropy workflow looks to be compatible with the changes in this PR.
This PR should not introduce any breaking changes for any repo. The only new breakage would be workflows that are building the same target more than once which is likely a mistake – the astropy workflow doesn't have this issue because the upload to PyPI is disabled in the first job so only one artifact is saved for that duplicate build target.

Given that some artifacts are uploaded as nightly wheels (say, to https://anaconda.org/astropy/astropy/files?type=pypi ), how will this affect the "old files pruning" script that @astrofrog previously implemented?

This PR should not affect that. The publish workflow changes in this PR only affect how built wheels and sdists are passed from the build jobs to the upload job.

Can this be merged and a release made?
I dunno what is going on but the released upload workflow is terribly broken: https://github.com/astropy/astropy/actions/runs/7620855779/job/20756741326 (it keeps the very old wheel but deletes the new wheels that are supposed to be uploaded) 🔥


Unable to remove IPv6 route

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
IPv6 routes don't get removed when using the 'remove route' feature in the web GUI.
To Reproduce
Steps to reproduce the behavior:

Go to 'System: Routes: Status'
Click on the bin icon next to one of the IPv6 routes
Click 'Yes' in the confirmation dialogue
See error: route doesn't get removed

Expected behavior
Route gets removed.
Describe alternatives you considered
Remove the route manually via shell command.
Environment
OPNsense 21.7.a_6 (amd64, OpenSSL).
Hyper-V Server 2019

@maurice-w https://github.com/opnsense/core/commit/aa167350b27557bab1a816bdc0a80febeb712a0c should fix it, it seems I forgot to test with ipv6

Thanks, that fixed it!
But I noticed another limitation: You can't remove routes which are directly assigned to an interface (no gateway).
I noticed this when doing some tests with the Tayga plugin, which creates routes like this:
route -6 add 2001:db8::/96 -interface nat64
route -4 add <IP_ADDRESS>/24 -interface nat64
These routes show up in 'System: Routes: Status', but neither of them can be removed using the GUI.
They can be removed via shell like this:
route -6 delete 2001:db8::/96
route -4 delete <IP_ADDRESS>/24
This is kind of an edge case, I leave it up to you whether it's considered unsupported or fix-worthy.

@maurice-w https://github.com/opnsense/core/commit/219e63fe651b785d3e0f49f94af8b39c6db9948c should remove the limitation.

Thanks for the effort @AdSchellevis, but tunnel interfaces don't have a MAC address.
The netstat -rWn output for such routes looks like this:
2001:db8:1:2::a          wg0                 UHS           8   1420      wg0
2001:db8:64::/96         nat64               US            0   1500    nat64

@maurice-w I should reverse it indeed, check for a valid ip address and omit if it's not. will do so in the next commit

Did a quick test and it works. Thanks a lot!


Labeling document types

Aggregator produces three documents

Org Aggregated Doc
Consumer Aggregated Doc
Consumer Aggregated Doc at Instance Level

Though the type of doc can be inferred from the document structure/keys, can there be an explicit field thats states the type of the document?

These docs have different structures so I'm not sure why you'd need an additional flag or doc/object type field to tell you what structures they have. Javascript objects and JSON typically do not carry an object type label. ES6 introduces classes to Javascript but I don't believe that the class name gets serialized in any way in JSON.

Please reopen if I mis-understood this issue.

I am developing an app the extends the pipeline after aggregator. My application expects only org aggregated document of the 3 documents produced by the aggregator. When the aggregator produced 2 documents, I inferred based on the structure. When I pulled abacus changes and ran the application with it, the app started crashing because of the 3rd document that was produced by the aggregator. So I thought adding a field that identifies the document type would help in picking the right document.  This can be solved in a different way if  issue https://github.com/cloudfoundry-incubator/cf-abacus/issues/278 is addressed

It should be pretty easy to just filter out any doc that doesn't match the specific structure/type you expect. I'm going to close #278 as it won't be needed if you just do that.


[MHLO-Linalg] Lower mhlo.convolution to linalg.

Lower mhlo.convolution to linalg when padding is non zero and rank of
input is 4.

If I read the patch correctly: we are currently lowering these test cases but incorrectly so?
So this is a bug fix?
Can you elaborate in the pull-request description?


Add document parser with simple HTML parser

Abstract base class so that people can write their own

Awesome!  I'll look at closely in the am, but looks good
On Thu, Mar 3, 2016 at 11:39 PM Henry Ehrenberg<EMAIL_ADDRESS>wrote:

Assigned #21 https://github.com/HazyResearch/ddlite/pull/21 to @ajratner
https://github.com/ajratner.
—
Reply to this email directly or view it on GitHub
https://github.com/HazyResearch/ddlite/pull/21#event-577419478.

Whoops added an extra commit with the initial calibration plots. I'll close this and redo it


Support maps

Fixes https://github.com/realm/realm-dart/issues/685.
Fixes https://github.com/realm/realm-dart/issues/778.
TODO:

[x] Add generator test for collection of collection
[x] Add generator test for default values of collections
[x] Add generator test for Set
[x] Add changelog entry to clarify default values for lists are unsupported

Very early draft

@tanguy-penfen I assume so, but it is unlikely to be me doing it. The dedicated Dart team I was part of has been dissolved, and instead maintenance of the SDK has moved under the .NET team. Tagging @nirinchev as he may know more?
This is just a very early placeholder PR I created. 95% of the work is still outstanding.

This is related to https://github.com/realm/realm-dart/issues/685. I see @nirinchev has already commented there. Maps are not currently scheduled.

Great news. From what version will this feature be available?

Great news. From what version will this feature be available?

Next version

We want to include a few more bugfixes but hope to release it in the next few weeks.