[bazel] ensure all SW artifacts are generated on a test build

If you are building an opentitan_rom_binary or
opentitan_flash_binary Bazel would generate all SW artifacts specified
in the respective macros.
However, if you build an opentitan_functest, which subsequently
invoked the opentitan_rom_binary and opentitan_flash_binary macros,
only the SW artifacts that were dependencies of the sh_test rule that
the opentitan_functest macro instantiates would get built, because
Bazel would silently prune any unncessary deps, e.g., disassembly files.
This fixes the above scenario so Bazel always generates the SW artifacts
specified by the underlying opentitan_rom_binary or
opentitan_flash_binary macros that the opentitan_functest
instantiates by making these artifacts dependencies of it's sh_test
rule.
Signed-off-by: Timothy Trippel<EMAIL_ADDRESS>

What's the underlying motivation to do this? Why not generate these files as needed and instructed? These files can be generated after the fact if necessary, or with a wildcard if trying to comprehensively test we can generate everything. Are you trying to use the build results to assist in discovery of the availability of these artifacts?

What's the underlying motivation to do this? Why not generate these files as needed and instructed? These files can be generated after the fact if necessary, or with a wildcard if trying to comprehensively test we can generate everything. Are you trying to use the build results to assist in discovery of the availability of these artifacts?

The reason is two fold:

for consistency, as we currently define both opentitan_functest and opentitan_flash_binary (see here for an example) targets throughout the repo, and even though the opentitan_functest instantiates opentitan_flash_binary macro, it generates a different set of sw artifacts for the flash image component than building a opentitan_flash_binary target directly. If it is desirable to NOT generate the disassembly (or other artifacts) by default, then we should probably define such defaults in the macros that instantiate the rules for said targets, i.e. in the opentitan_binary rule the "output_disassembly" always defaults to true, perhaps we change this to false?
To clean up the opentitan_functest rule and make it easier to trace where specific artifacts are decided to be generated or not. In the current setup (as described above) one would expect the disassembly to be always generated and it is not. Additionally with this cleanup, we don't have to manually select the SW logging database files (for DV) in multiple macros, i.e., we just let that be handled in the macro that generates them, the opentitan_binary macro (same as reason 1).

Lastly, if we do decide to update said macros to never generate the disassembly (and other files) we should update the website docs to describe the exact bazel command to run to generate these (because they are currently missing since it seems it was assumed they were generated).
Does that make sense?

closing this in favor of #13979


add feature

can you add keylogger? and also when the pc has restarted or the file has been executed, it will chat in telegram that the pc is online. thanks! btw good rat

Thanks for comment! I will definitely add a keylogger in the future . I tried to do what you said in telegram , but it is impossible to do that immediately when opening the exe , the text was written that the file was open,but when you wrote,for example , /start or /help , the bot will display the answer from your command if the pc exe file is running on the target pc , if it is not running, the bot will not work. Again, thanks  for your comment!😊


RST-1469: Bootsnap in Production Only

Bootsnap is used to cache operations and increase boot time. This can make debugging initialisers a pain in the backside, so this PR moves bootsnap to prod only.

I will merge this after Welsh is released. Prevents another rebase in that branch.


Update the doc

Hi, pls, update the doc, e.g. Mongo embed many works fine :) can be showstopper for someone when the doc is not up to date...

Hi, if you've found any out of date documentation, I'd really appreciate if you could point to it more specifically.
Even better would be if you could create a pull request. Since it's for the Readme file, you can even do it all from your browser. Happy to help you go through making a pull request if you're unfamiliar with the process.


[Bug] Per solution config is not overriding the AppData config

VS 2019 & VSColorOutput v2.73
I've copied the vscoloroutput.json file into the directory where my .sln file is located and added it to the solution, then I modified the following regex from this:
{
  "ClassificationType": 2,
  "IgnoreCase": true,
  "RegExPattern": "(\\W|^)^(?!.*warning\\s(BC|CS|CA)\\d+:).*((?<!\/)error|fail|failed|exception)[^\\w\\.\\-\\+]"
},

To this:
{
  "ClassificationType": 2,
  "IgnoreCase": true,
  "RegExPattern": "(\\W|^)^(?!.*warning\\s(BC|CS|CA)\\d+:).*((?<!\/)error|fail|failed|(?<!custom\\.)exception)[^\\w\\.\\-\\+]"
},

So it should ignore the word 'exception' if it starts with "custom." like "custom.exception".
This change is not respected by the extension (even after VS restart), until I change the regex in to config file that is located in the AppData directory and restart the visual studio.

VSColorOutput64 is the currently supported project. VSColorOutput is for legacy systems. Furthermore, I don't have  a windows machine at the moment. The issue likely lies in settings.cs. If you're up for it, submit a fix and I'll publish an update because VSColorOutput64 will not work with VS2019.

I've subbmitted pull request #149
This was my first fork and pull request ever on this platform, I hope I created them properly.

Hello Mike,
Can you publish the update this week?

Preliminary release setup. Need a couple of you to test and verify.
https://github.com/mike-ward/VSColorOutput/releases/download/untagged-59d0e79d882d259164ef/VSColorOutput.vsix

The link is broken.

Can you see the draft release (2.74) in the release page?

Looks like draft releases are not visible. I published the release at https://github.com/mike-ward/VSColorOutput/releases/tag/v2.74

Tested it with my co-workers and it works perfectly in VS 2019.
Keep in mind, if you are using the default config file (from AppData) and you add a new config file to the solution, you will need to restart visual studio, or open the extensions configuration via Tools -> Options -> VSColorOutput and then press "OK", so the settings will be reloaded from the solution's config file.

Awesome. I'll post it to the marketplace today. Thanks for your help.

published fix in v2.74 to marketplace


regression-test support sql test cases to run as nonConcurrent test cases.

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
support sql test cases to run as nonConcurrent test cases.
Sql cases can not define a test group. so if its path has "nonConcurrent", treat it as nonConcurrent test cases.
Release note
None
Check List (For Author)

Test

[x] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.
Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

skip buildall

skip buildall


Update file extension from .js to .ts in "Module Augmentation".

Perfectly fine if this PR is not accepted but, like @vitoc reported in #562, I'd noticed this subtlety and thought it was worth submitting a PR for.
In that issue, @mhegazy thought this was intentional, however I'm not entirely convinced that it makes sense to keep it the way it is.
Specifically, it seems to me that the use of .js is maybe intentional on the (first) map.js extension, but questionable on observable.js since that example specifies a type variable (i.e. Observable<T>): a TypeScript-ism which would render it invalid JavaScript.
The code block directly below this makes mention that:
// observable.ts stays the same
// map.ts

...which would seem to indicate that the observable.ts file above was certainly intended to end with .ts and remain unchanged.
I'm lead to believe that both map an observable might be better suited as .ts extensions within all mentions of it since the next/following ask is for the reader to add a bunch of TypeScript to the map file which was previously .js and would need to be renamed to .ts to continue with the exercise.
Ultimately, I'm not sure if having the first examples use .js extensions is adding much value, but I do think that switching file extensions between blocks might be a subtle nuance that could confuse the reader.
Ref: https://www.typescriptlang.org/docs/handbook/declaration-merging.html#module-augmentation
Fixes: https://github.com/Microsoft/TypeScript-Handbook/issues/562

Thanks - yep, I've merged a PR which does this 👍


Support https with Tus uploading

Urgent PR to fix Tus uploading with SSL

While this fix is working, it is not needed.  Instead, we should be setting the environment variable for HOSTON_REVERSE_PROXY_SETUP and using the following Traefik configurations when using SSL.
# traefik.toml

[entryPoints]
  [entryPoints.web]
    address = ":80"

    [entryPoints.web.forwardedHeaders]
      insecure = true

    [entryPoints.web.http.redirections.entryPoint]
      to = "websecure"
      scheme = "https"

  [entryPoints.websecure]
    address = ":443"


Live demo not working

iPhone 6 not working in safari not chrome. Seems like a layout issue.

On iPhone all browsers run the same rendering engine (Webkit). Therefore it's irrelevant if you browser is called "chrome" or "safari", it's the same engine. That's because Apple forbids usage of non-Apple rendering engines on Apple hardware. As I have no apple device here I can't test it thoroughly. "layout issue" is not enough information to improve the demo. Maybe you can checkout the sources from this repo and try to runt he demo "locally"?
Kind regards,

live demo not working on chrome on my macbook

There could be many different reasons but because this code was "just a demo" I'll leave it as it is. Meanwhile I'm working on other projects so I don't have time to debug MacOS stuff. I don't even own a Mac 😅

Cool, no issues, as aframe itself has any demo, but i am looking from angular prospective as i am trying to do it in ionic 2 framework


Paste In and Paste Around commands do not work in vim-leader-guide menu.

The following commands work in when applied normally, but not when vim-leader-guide is present.
May have something to do with escape characters.


Issue with aapt2

Hi,
Thanks for this nice library that I still use as it does it's job perfectly.
Unfortunately it's not compatible with the new Google build tools aapt2 and causes crash.
Would you accept and merge a PR to update the tools used in this library to fix that?
See https://issuetracker.google.com/issues/73534863

Sure!

@f2prateek actually I'm a maven noob and have not find anywhere where you define the build tools version. So well can't really PR anything for now :(


Update: "Install with Sketchpacks"

Updating copy for one-click install via Sketchpacks.

Thanks~ :D


Add share/application/himalaya.desktop

This file would be really nice to have specifically so users can leverage XDG and set himalaya as a default mail app
[Default Applications]
x-scheme-handler/mailto=himalaya.desktop;

as well as getting access to be chosen as the default for Firefox, xdg-email, etc.

I think literally this could actually be a static file @ $PROJECT_ROOT/share/application/himalaya.desktop and package managers can just copy it. If you don't have the bandwidth @soywod, I could probably do this (just tap "Assign").

It is a very good idea @toastal! I'm curious to see how you could implement this. Because Himalaya is a CLI, so it implies to launch the terminal somehow? I'm quite short in time these days, so I assign it to you. Thanks a lot for your involvement!


Feature Request: Redshift Serverless Namespace admin user rotation

Summary:
Support admin user rotation for Redshift Serverless Namespaces using the update_namespace API
Details
Redshift Serverless separates out database (namespace) and compute (workgroup) into distinct resources. Generally a workgroup is associated with a namespace and a user will connect to the workgroup to query databases on the associated namespace. However, this association is mutable. A workgroup can be disassociated  from a namespace, re-associated with a new namespace, or deleted.
This makes rotating users through a workgroup connection unreliable. That being said, Redshift Serverless offers an update_namespace API which can be used to update the Admin username/password combination.
It would be helpful to have a Rotation Lambda that leveraged that API for Admin user roatation

Thank you for the request, Arun. We've noted this as an enhancement request.

It may be easier to do this now given that Secrets Manager has native support for secret rotation with Redshift Serverless


Consider Fody

Maybe generating all the code by using Fody might be even better...
This would involve writing a Fody add-in...

Started using AutoProperties.Fody, this solves this issue and removes the need for emiting code.


[5.1] [WIP] Add setRawAttribute function

As described in #9414 and #9418, and to avoid a model to be considered as dirty when it's not, we need to ensure that the $original array of the model will always contain string representations of array or objects (Carbon included) and not the object itself.

[x] update code
[ ] tests

Feedback is welcomed.

We ideally need tests here. I understand it's a WIP though. :) Thanks for taking this on.

What is the status of this?

Still needs more work and tests - should be finished soon
Le jeudi 2 juillet 2015, Taylor Otwell<EMAIL_ADDRESS>a écrit :

What is the status of this?
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/pull/9492#issuecomment-118141818.

Closing pending lack of activity.


Tag contrast

The tags for me (using a light version) are too dark to read. I've tried to find where I can change them, but as of today I haven't found it.  Currently, it is a reddish color on black.  I need more contrast. The hover is black on black.
I appreciate the help!
Originally posted by @KzBeck in https://github.com/ebullient/obsidian-theme-ebullientworks/discussions/7#discussioncomment-1905942

https://github.com/ebullient/obsidian-theme-ebullientworks/discussions/7#discussioncomment-1907177

Okay, Yes, I suspect it may be from Colored Folders or maybe Combine Nested tag colors and Highlight colors. I will try to resolve it. Thanks for your time and pointing me in a direction.
Love the theme!


Cycle number calculation vs decoded from data

#3 Related to this closed cycle no. issue.
Why do you calculate cycle no. when you can just decode it from the data itself as Neware stores the cycle no. natively (as seen in the xls/xlsx files). There are many recipes/tests which involve multiple instances of charge and discharge in the same cycle. So your calculation comes out wrong in those tests.
I am currently using the code below to get the cycle number. Essentially, the correct cycle number here will be 'Cycle +1'.
[Index, Cycle] = struct.unpack('<IH', byte_stream[2:8])

This is interesting, the newest version of Neware BTSDA returns different cycle numbers than older versions for the same nda file. Looks like they switched to reporting the cycle number from the nda. Previously, the only way I could match BTSDA was with _generate_cycle_number(df).
I wonder if the cycle number in the nda is a 4-byte integer?

I just created a pull request with a flag to switch between the two different cycle numbers. What do you think?

Let me check if my current code works with old nda files and that too if I have any old nda file. I also found another multiplier value of -12000 which is used in SIM step. Couldn't get to test around with it much.


Remove nuspec dependencies

This reverts part of #1682.
Should resolve #1725

cc @eerhardt

Thanks for the quick fix @cdmihai!

Redid history as @rainersigwald suggested.


Add alerting based on metrics tutorial

ToDo:

[x]  Upload videos and change the video links

Did you already send the videos my way for upload? I don't see anything in Slack or email, but I might have missed it

It seems Slack didn't highlight me even though you @ me; that's the second or third time this has happened to me in CNCF Slack; weird. Either way, I found the videos and uploaded them:
https://www.youtube.com/watch?v=RKXwHhQZ5RE
https://www.youtube.com/watch?v=xaMXVrle98M

Thanks!


Unable to communicate between clients

Hello, I have successfully installed and created two clients on my Centos7. However, communication between the two clients is not working properly. Is this normal

@ProgrammerXiaoQin Hello! By default, client-to-client traffic is allowed in the firewall rules created by the script in this project, please use the clients' internal IP addresses (<IP_ADDRESS>/24 subnet) to communicate with each other. To view which IP is assigned to a client, check the connection properties on the OpenVPN client. Note that client-to-client traffic may be blocked by the firewalls on your OpenVPN clients themselves.

Thank you for your reply. I have checked my network situation and it should be no problem. I successfully resolved the issue by restarting the OpenVPN service (systemctl restart<EMAIL_ADDRESS>）


Weird gcc output for arm targets

Using arm gcc >= 6.3 yields weird result when compiling this with -mtune=cortex-m0 -mthumb -mcpu=cortex-m0 -Os :
#include <stddef.h>
#include <stdint.h>
#include <stdbool.h>

// forward declaration of a foo
struct foo_s;
typedef int8_t foo_bar_t;

typedef struct foo_s {
    struct foo_s* next;
    foo_bar_t bar;
} foo_t;

extern foo_t* a_foo;
extern foo_t *a_list_of_foos;
extern bool baz;

void foo_do_stuff(foo_t* foo);
bool bar_as_bool(bool *);
void do_stuff();

void foo_do_stuff(foo_t* foo)
{
    foo_t *prev = a_list_of_foos;
    while ((prev != NULL) && (prev->bar >= foo->bar)) {
            prev = prev->next;
    }
    foo->next = prev->next;
    prev->next = foo;

     if (!bar_as_bool(&baz)) {
         return;
     }
     if (foo->bar > a_foo->bar) {
         do_stuff();
     }
 }

You're not null checking foo, so it's generating a trap in that scenario. I've seen that happen in other cases with more arm compilers as well.

I see, .L8 has a .inst 0xdeff. However, address 0 is not an invalid address on a microcontroller. GCC is being too smart in that case :/


Example broken

Hey,
I tried your example, however it does not work, currently (Linux firefox and chrome).
https://dellisd.github.io/sqldelight-sqlite-wasm/
sqlite3.js:9978 Ignoring inability to install OPFS sqlite3_vfs: This environment does not have OPFS support.
(anonymous) @ sqlite3.js:9978 CoroutineExceptionHandlerImpl.kt:11 Gcause: undefinedmessage: "{\"message\":\"sqlite result code 1: no such vfs: opfs\",\"name\":\"Error\"}"name: "G"stack: "G: {\"message\":\"sqlite result code 1: no such vfs: opfs\",\"name\":\"Error\"}\n    at R.tx (https://dellisd.github.io/sqldelight-sqlite-wasm/sqldelight-sqlite-wasm.js:1:315503)\n    at R.handleEvent (https://dellisd.github.io/sqldelight-sqlite-wasm/sqldelight-sqlite-wasm.js:1:315653)"[[Prototype]]: Errorconstructor: ƒ G(t)[[Prototype]]: Object fe @ CoroutineExceptionHandlerImpl.kt:11

Ah, I guess OPFS is currently only available on a small subset of browsers.

Ah yes, part of the issue is that only a few browsers currently support OPFS to the degree that SQLite needs (I think Chromium-based ones are the only ones to date).
The other problem is that OPFS requires the site/scripts to be loaded with certain headers, which unfortunately can't be done on GitHub pages so that live demo will never work. I'll probably set up a proper live demo eventually, but for now I'm going to remove that link.

Chromium-derived browsers released since approximately mid-2022. As of v108 (November 2022) some OPFS APIs changed from asynchronous to synchronous, which affects how client code (i.e. this library) has to deal with them.
Firefox v111 (March 2023) and later
Safari 16.4 (March 2023) and later


Enable package-private Getters/Setters/Constructors

Writes all adapters to the same package unless the type is imported.
non-final package-private fields can be (de)serialized
allow package-private getters/setters/constructors

Fixes #248

IDK if it's a JDK bug or what but it seems that I can't reference a pkg-private class from generated sources even though it's in the same package

I guess you can't use imports with pkg-private classes, you learn something new every day

seems cascading works via the module route


Running example.py using instructions causes error

Hi I am trying to run the example.py file in your repo named as script2.py on my desktop with starfish using the instructions .
blender file.blend --python script2.py --background
`Read blend: /home/sachin/Desktop/file.blend
Traceback (most recent call last):
File "/home/sachin/Desktop/script2.py", line 14, in
distance=np.linspace(10, 50, num=100)
File "/home/sachin/.config/blender/2.79/scripts/addons/modules/starfish/core/sequence.py", line 101, in standard
return cls([Frame(**args) for args in kwargs_per_frame])
File "/home/sachin/.config/blender/2.79/scripts/addons/modules/starfish/core/sequence.py", line 101, in
return cls([Frame(**args) for args in kwargs_per_frame])
File "/home/sachin/.config/blender/2.79/scripts/addons/modules/starfish/core/frame.py", line 59, in init
self.background = Spherical.from_other(background)
File "/home/sachin/.config/blender/2.79/scripts/addons/modules/starfish/rotations.py", line 74, in from_other
roll_quat = inv_rot_quat @ obj
TypeError: unsupported operand type(s) for @: 'Quaternion' and 'Quaternion'
Blender quit`

Thank you for alerting us, this is being looked at now.

My apologies, but Starfish requires Blender 2.8+.  This wasn't clear before, and the documentation has been updated.
Also, you probably don't want to run example.py as-is without modifications, since you probably don't have the exact same setup. For starting out, I would recommend opening Blender and running scripts manually from the 'Scripting' tab, first getting a feel for individual frames and then sequences.
Let me know if you have any more questions!


colab k80 is very slow

how increase  speed for k80 colab

For k80 you should try with fastGAN backbone, and just wait. The default batch size should occupy almost 80% of the GPU memory with a 256x256 dataset.


Developer Mode For the Identity Server

A suggestion to have a developer mode for the WSO2 Identity Server. The developer mode will include all the standard features, plus developer-friendly features.
An example of a developer-friendly feature would be the Cache Invalidation API.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Can't use esc after installing codeium on nvim

I'm on nvim 0.9.1 and after install codeium on it, esc just doesn't work

@SBHattarj how do you resolve this?

@SBHattarj how do you resolve this?

You are having similar issue? The issue was with key binding, after disabling the default, I had accidentally added key binding to ctrl+[ (for cycling completion) but that's the key binding that esc maps to. I thought others who are using nvim will not repeat that error so I closed this issue.


VIVI-5672 Bump snoretoast

https://github.com/viviedu/snoretoast/pull/1

oops wrong fork, thanks github


adding insertion sort in typescript

Assigned Issue
#21
Have you read the Contributing Guidelines?
Yes/No
Files Affected ?
name_of_file.extension
Checklist

[ ] I've read the contribution guidelines.
[ ] I've checked the issue list before deciding what to submit.

Hi @krishnmohan19, Please fill up your PR template properly and try again

thanks too @ahampriyanshu  for merging my pr.


docs(blockquote): docs refactor

What I did

Testing Instructions

Notes to Reviewers

@Nouveau Edits:
Global

[ ] Ensure all images render at 1x (I forget who, but someone created code to fix image sizes; Steven would know who)
[ ] Ensure h2s are --rh-font-size-heading-md
[ ] Ensure h3s are --rh-font-size-heading-sm
[ ] Run through the content doc again and double check images in containers (blue highlighting) vs. not in containers (red highlighting)
[ ] Container = white box with light gray border and rounded corners

Overview page

[ ] Order of sections: Overview, Sample element, Demo, When to use, and Repo status
[ ] Under the Sample component h2, the image is twice as large and needs to be in a container

Style page

[ ] Under the Style h2, under the bullets, the image is twice as large and needs to be in a container, it also appears to be indented (Ivanna knows how to fix the indenting)
[ ] Under the Sizes h2, the image is twice as large and needs to be in a container (for reference, under the Light theme h3, the image in the container looks perfect)

Guidelines page

[ ] Under the Alignment h2, the image is missing
[ ] Under the Variations h2, the Other elements text should be an h3
[ ] Under the Other elements h3, the images should not be in containers
[ ] Under the Layout h2, under the Minimum width h3, the images are missing and should not be in containers
[ ] Under the Maximum width h3, the images should not be in containers
[ ] Under the Card h3, the images should not be in containers
[ ] Under the Other elements h3, the alert should display the Info styling (blue)
[ ] Under the Other elements h3, the images should not be in containers
[ ] Under the Responsive design h2, under the Default size, Large size, and Other elements h3s, the images should not be in containers
[ ] Under the Best practices h2, there is specific container styling used for incorrect use cases, you can look at the code on another page for reference

Accessibility page

[ ] Remove Accessibility h2 and p text
[ ] The content and styling under the ARIA Authoring Practices Guide (APG) and Web Content Accessibility Guidelines h2s is not current, you can borrow the content and code from another page

@coreyvickery I moved the Global h2 and h3 sizes to a separate issue that will resolve for blockquote when #1111 is resolved.

@coreyvickery Everything should be ready for review again.
The min width images weren't appearing because their file name was blockquote-mid-width instead of blockquote-min-width so I've updated the file names to say min-width instead of updating the uri to match the typo.


Revert "Revert "Image Folder Cleanup""

Reverts jz-jess/RobotEyes#84

@jz-jess The pypi workflow failed.  Looks like it was an issue with the installer.  Is there anyway to rerun the GitHub action to push to pypi?

@josev814 I had rerun the workflow, it failed again.I have uploaded to pypi manually.  Issue seems to be with the action. Will fix it

@jz-jess Thank you


Pulse docs improvements

closes:

https://linear.app/prisma-company/issue/DA-973/document-why-pulse-stream-throws-generic-error-when-multiple-clients
https://linear.app/prisma-company/issue/DA-1152/question-about-possible-charges-for-enabling-event-persistence-without

@nikolasburk These changes look good to me 👍 !


[SPARK-14525][SQL][FOLLOWUP] Clean up JdbcRelationProvider

What changes were proposed in this pull request?
This PR proposes cleaning up the confusing part in createRelation as discussed in https://github.com/apache/spark/pull/12601/files#r80627940
Also, this PR proposes the changes below:

Add documentation for batchsize and isolationLevel.
Move property names into JDBCOptions so that they can be managed in a single place. which were, fetchsize, batchsize, isolationLevel and driver.

How was this patch tested?
Existing tests should cover this.

cc @cloud-fan and @gatorsmile Could you take a look please?

Test build #65982 has started for PR 15263 at commit fcb2bda.

Test build #65983 has started for PR 15263 at commit 535ad8b.

Test build #65982 has finished for PR 15263 at commit fcb2bda.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65982/
Test PASSed.

Test build #65983 has finished for PR 15263 at commit 535ad8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65983/
Test PASSed.

@HyukjinKwon Will review it after you fix all the issues.
BTW, I checked the documentation. It sounds like not all the property descriptions of JDBC are accurate. Could you please also update them too? Thanks!

Sure, will update them together soon!

Test build #66011 has started for PR 15263 at commit e3c49ce.

@gatorsmile I think it is ready to be reviewed. Please take a look.

Test build #66012 has started for PR 15263 at commit bbd7f25.

Test build #66011 has finished for PR 15263 at commit e3c49ce.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66011/
Test PASSed.

Merged build finished. Test PASSed.

Test build #66012 has finished for PR 15263 at commit bbd7f25.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66012/
Test PASSed.

Regarding the JDBC options, which properties are used for the table reading? Which ones are used for writing? Can you please improve the document and make users easily find the answer?

Good idea. Yes I will.

@gatorsmile Would this be sensible if I submit another PR to clean up options for https://github.com/apache/spark/pull/15263#issuecomment-250072008 later as strictly the purpose of this PR is to clean up JdbcRelationProvider?
I'd like to unify all the options within JDBCOptions and maybe I could fix the documentation together there if you think it makes sense.

Yeah, @HyukjinKwon . This PR is just to rewrite the implementation. No need to resolve all the comments here.

Test build #66024 has started for PR 15263 at commit f71d038.

Test build #66024 has finished for PR 15263 at commit f71d038.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66024/
Test PASSed.

Test build #66076 has started for PR 15263 at commit 016f11d.

Test build #66077 has started for PR 15263 at commit 15b38a8.

Test build #66076 has finished for PR 15263 at commit 016f11d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66076/
Test PASSed.

Test build #66077 has finished for PR 15263 at commit 15b38a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66077/
Test PASSed.

Test build #66146 has started for PR 15263 at commit 4acb14b.

Test build #66146 has finished for PR 15263 at commit 4acb14b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66146/
Test PASSed.

Merged build finished. Test PASSed.

Test build #66152 has started for PR 15263 at commit b339492.

LGTM pending test

@gatorsmile Thank you for a close look!

Test build #66152 has finished for PR 15263 at commit b339492.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66152/
Test PASSed.

Hi @gatorsmile, would there other things more I should take care of?

retest this please

Test build #66489 has started for PR 15263 at commit b339492.

Test build #66489 has finished for PR 15263 at commit b339492.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66489/
Test PASSed.

Thanks! Merging to master!

Seems it breaks scala 2.10 compilation. Can you take a look? Thanks!
[error] /home/jenkins/workspace/spark-master-compile-sbt-scala-2.10/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala:73: value contains is not a member of Option[Boolean]
[error]             if (isTruncate && isCascadingTruncateTable(url).contains(false)) {
[error]                                                             ^
[error] one error found
[error] (sql/compile:compileIncremental) Compilation failed
[error] Total time: 240 s, completed Oct 7, 2016 11:02:49 AM
Build step 'Execute shell' marked build as failure
Finished: FAILURE

Option.contains is only in Scala 2.11...

Oh, thank you for pointing this out.


wait_clean now deletes all not just pods, jobs, etc

To avoid leaving hanging resources such as statefulsets etc we can delete everything in the wait_clean function not just specific types.

/rerun minikube

/rerun minikube


Ensemble Classifiers : Bagging and RandomForest

Hi @itcraftsmanpl,
I have been thinking about some ensemble classifiers and how they generally perform well to improve performances of relatively weaker classifiers. Therefore, I just started to develop some ensemble algorithms starting from the most basic/simple ones: Bagging and a variant of it, RandomForest.
I've tested them with some base classifiers and preliminary results appeared promising. For Iris, Wine, Glass, Sin-2 and Cars datasets, average performances of classifiers are obtained as follows:

Phpml\Classification\KNearestNeighbors: 0.78%
Phpml\Classification\NaiveBayes: 0.76%
Phpml\Classification\DecisionTree: 0.82%
Phpml\Classification\Ensemble\Bagging: 0.89%
Phpml\Classification\Ensemble\RandomForest: 0.88%

I am still testing the algorithms and they may need some work. However, in order to get opinion of others who follow here I commit the current status of them.
As far as I could see, these algorithms are highly sensitive to parameters related to how big the subsets will be and how many of features will be used in subsets of the original datasets. By trial-and-error, I set some default values but I am not sure they are optimal. Maybe someone with experience in other libraries (such as scikit-learn) will suggest something about parameter tuning and possible other parameters to improve the performance.
PS (1): @itcraftsmanpl You do not need to merge the changes immediately, I will upload the test cases for each classifier. This commit is for only showing you what is on the way to come.
PS (2): And also I do not understand why previously merged changes appeared in this PR. This PR was supposed to contain only 3 files (DecisionTree.php, Bagging.php and RandomForest.php), please help me with fixing this if you know how to.

Hi @mustafakarabulut, you must rebase your current branch with origin branch.

I am working on test cases and soon I will commit the tests along with the final versions of the classifiers.

Hi,
I have just uploaded final versions of Bagging and Random Forest along with a test file for each classifier.
For now, I am done with these two. When others start to use these classifiers and ask for improvement, we can get back here and try to improve them more. As to my observations/experiments, these two ensemble algorithms are simple yet very good at improving sole performance of any base classifier at the cost of computational burden.

The pull request is ready to be merged now.

Updated the files again with some of the changes requested. However, as discussed above, I could not do any changes on the test files as the requested changes did not make much sense to me.

There is still problem with Exception class.

OK, my bad. I committed them again. Thanks for the patience.

@itcraftsmanpl

Re-run php-cs-fixer with the available config file (.php_cs)
Tried to reflect the requested changes to the code and the test files
Meanwhile, attempted to improve RandomForest (its initial version did not reflect the theory genuinely)

I hope it is ready to be published now.
By the way, thank you for your help during the development.

Hi @mustafakarabulut,
Thanks for changes. I see that couple things can be write better. Maybe we can merge it, and I will focus on code quality and you can implement other algorithms.
What do you think?

Hi @itcraftsmanpl,
It is very good idea to merge the commit as is. Then you and I can work on different parts separately. Otherwise, with the current review-edit-recommit cycle, it takes too long to finish a feature. I think the features presented here are mature enough to be merged, then you can work on parts you'd like to improve, e.g., code quality enhancements or changes including better syntax.


Bug: Ledger profile does open after starting staking

Discussed in https://github.com/iotaledger/firefly/discussions/2338

Originally posted by Buschbanker February 16, 2022
Hello,
I installed firefly yesterday and created a wallet with legder X. I send iota to the wallet and started staking. If I now want to open firefly to see if everything is in place, I can chose my profile, type in the pin and then nothing happens. I only see the fly shaking its wings on a white underground. In the top left I see the three Menue lines I can choose in the menue but nothing happens.
What can I do?
Would be glad about some help!
Thanks
Buschbanker

Duplicate of Issue #2341


Rename "DefaultSurface" to "TopbarSurface"

The template that has a top bar and the main area should be called "TopbarSurface", not "DefaultSurface".
The name "DefaultSurface" is misleading.

Closing as done.


Add tests, basic DB seeding, and email package

This biggest part of this PR adds tests for user accounts (Tests - #44) based scenarios including the default user signup, user login, and user recover password functionality in Base.
In order to achieve this xolvio:cucumber, xolvio:email-stub, and meteor add email were added. In addition a new package themeteorchef:test-fixtures was created and added as a local package. themeteorchef:test-fixtures adds a simple fixtures/reset and fixtures/seedData DB functionality.
Other issues this will touch are "Add email package and examples" (#66) by adding the email package and "Seeding" (#56) by adding a custom fixtures/seedData DB function (only adds one user for testing), but does not use Faker. I think I can integrate Faker here if you would like that before releasing this into the wild.
It might be something to think about allowing these tests to be added as a package in the future, so users can choose to have some basic tests or not. Also, this is not using any fancy ES2015 features. I tried to use arrow functions, but cucumber didn't like them. Perhaps the syntax was incorrect, who knows.
Enjoy :)
Feel free to give me a shout on TMC Slack if you have any questions, comments, complains, or praises!

Cool, thanks for putting this together :)
Will review this week and add notes.

No sweat. I'm sure I wouldn't have nailed it perfectly the first time :)

Hey @DevanB, I'm going to close out this PR for now, but let's chat in Slack on how we can bring it into the latest version.


Add accessors for oneof variant enum

Codegen currently produces accessors for all of the variants of oneof fields but not for the enum itself.  It is often desirable to match on the enum itself and see which variant is included.
For example, a message like this:
message Foo {
  oneof payload {
    Bar bar = 1;
    Baz baz = 2;
  }
}

would produce a Rust struct with has_payload and get_payload methods.  get_payload would return Option<Foo_oneof_payload>.

@stepancheg is this something you'd be willing to accept as a PR?  If so, I'd be happy to take a stab at implementing it.

@Ameobea in latest protobuf (in 2.0 IIRC) oneof fields (e. g. payload field of Foo struct) is public by default. Why get_payload/set_payload functions are necessary?
Sorry for the late response!

Closing due to old age.


Enable multiple character delimiters in read_csv

Read_CSV ParseOptions allows only a single character delimiter.   Single character delimiters are highly susceptible to the candidate value existing within the data to be loaded, negating the ability to serve as a delimiter.
If a double character delimiter is used, the current limit of a single character returns  "only single character unicode strings can be converted to Py_UCS4, got length 2"
Reporter: Jack Howard
Note: This issue was originally created as ARROW-17130. Please see the migration documentation for further details.

Looking for multiple character delimiters in read and write. Many a times hex is used as delimiters which is multi-character and limitation for current implementation.


[WIP] move to M1 runner

Fixes #1015
Developers certificate of origin

[ ] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.53%. Comparing base (37e6d36) to head (f0f423b).
Report is 15 commits behind head on main.

Additional details and impacted files

Seems like people have caught up.


Update Login with new Ui Lin primeNG

For design Spy that:
https://www.primefaces.org/mirage-ng/#/login
But button should be rounded!! --> This is our design

@timination @Ghislain1  help to design login like in  https://www.primefaces.org/mirage-ng/#/login

From Pic:

Browser should display it inside input element
What does p-comment attribut?
pinputtext for what?
p-formgrid provides what?


Small text fix on validation_helpers.rb

👍

Thanks for the fix!

Thank you for this incredible gem!


Migration drf_yasg (Swagger) -> drf_spectacular (Open API 3)

Todo:

[x] add hidden params
[x] fix errors

Validation errors:
/usr/src/app/qfieldcloud/core/views/files_views.py:40: Error [ListFilesView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/files_views.py:118: Error [DownloadPushDeleteFileView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/authentication/views.py:66: Error [LogoutView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/files_views.py:285: Error [ProjectMetafilesView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/files_views.py:297: Error [PublicFilesView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/jobs_views.py:21: Error [JobViewSet]: exception raised while getting serializer. Hint: Is get_serializer_class() returning None or is get_queryset() not working without a request? Ignoring the view for now. (Exception: tuple index out of range)
/usr/src/app/qfieldcloud/core/views/package_views.py:161: Error [PackageUploadFilesView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/package_views.py:53: Error [LatestPackageView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/package_views.py:128: Error [LatestPackageDownloadFilesView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/qfield_files_views.py:82: Error [ListFilesView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/qfield_files_views.py:151: Error [DownloadFileView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/qfield_files_views.py:25: Error [PackageView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.
/usr/src/app/qfieldcloud/core/views/status_views.py:9: Error [APIStatusView]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.

Warnings:
/usr/src/app/qfieldcloud/core/views/projects_views.py:43: Warning [ProjectViewSet]: could not derive type of path parameter "projectid" because it is untyped and obtaining queryset from the viewset failed. Consider adding a type to the path (e.g. <int:projectid>) or annotating the parameter type with @extend_schema. Defaulting to "string".
/usr/src/app/qfieldcloud/core/serializers.py:110: Warning [UserView > CompleteUserSerializer]: unable to resolve type hint for function "get_avatar_url". Consider using a type hint or @extend_schema_field. Defaulting to string.
/usr/src/app/qfieldcloud/core/serializers.py:263: Warning [ListCreateDeltasView > DeltaSerializer]: unable to resolve type hint for function "get_status". Consider using a type hint or @extend_schema_field. Defaulting to string.
/usr/src/app/qfieldcloud/core/serializers.py:130: Warning [ListUsersView > PublicInfoUserSerializer]: unable to resolve type hint for function "get_avatar_url". Consider using a type hint or @extend_schema_field. Defaulting to string.
/usr/src/app/qfieldcloud/core/serializers.py:130: Warning [ListUsersView > PublicInfoUserSerializer]: unable to resolve type hint for function "get_username_display". Consider using a type hint or @extend_schema_field. Defaulting to string.
/usr/src/app/qfieldcloud/core/serializers.py:110: Warning [RetrieveUpdateUserView > CompleteUserSerializer]: unable to resolve type hint for function "get_avatar_url". Consider using a type hint or @extend_schema_field. Defaulting to string.
/usr/src/app/qfieldcloud/core/serializers.py:156: Warning [ListUserOrganizationsView > OrganizationSerializer]: unable to resolve type hint for function "get_avatar_url". Consider using a type hint or @extend_schema_field. Defaulting to string.
/usr/src/app/qfieldcloud/core/serializers.py:156: Warning [ListUserOrganizationsView > OrganizationSerializer]: unable to resolve type hint for function "get_members". Consider using a type hint or @extend_schema_field. Defaulting to string.
Warning: operationId "admin_api_files_retrieve" has collisions [('/admin/api/files/{projectid}/', 'get'), ('/admin/api/files/{projectid}/{filename}/', 'get')]. resolving with numeral suffixes.
Warning: operationId "api_v1_deltas_list" has collisions [('/api/v1/deltas/{projectid}/', 'get'), ('/api/v1/deltas/{projectid}/{deltafileid}/', 'get')]. resolving with numeral suffixes.
Warning: operationId "api_v1_files_retrieve" has collisions [('/api/v1/files/{projectid}/', 'get'), ('/api/v1/files/{projectid}/{filename}/', 'get')]. resolving with numeral suffixes.
Warning: operationId "api_v1_qfield_files_retrieve" has collisions [('/api/v1/qfield-files/{projectid}/', 'get'), ('/api/v1/qfield-files/{projectid}/{filename}/', 'get')]. resolving with numeral suffixes.

Schema:
schema.txt

Thank you, since I am trying by best to accomodate the often renewed request to keep pull requests short I didn't add code going beyond the migration (i.e. 1-1 translation between the two libraries used to document the API). The improvements can come from another PR, to make it easier to distinguish between the "before" and the "after" the migration, don't you think?

Do a separate PR for the doc improvement based on this one. Then we can review both and merge one after another.


Added support for Laravel 9 and PHP 8.1

Thank you @justkidding96 for contribution. I've taken care of the L9 upgrade in #8 with few additional tweaks


Update requirements_experiments.txt

Hi Boris,
we will not update this branch train to ensure reproducibility of our experiments of the paper.
Also, we had some issues when we left the jax version unspecified.
Best wishes
🌞


Duplicate symbols build error in v2.0.1

After updating to 2.0.1 I get duplicate symbol errors when I try and build:
duplicate declaration of method 'backgroundRingView'
duplicate declaration of method 'ringView'
I think there is an extra declaration of the property getter in the header file, here's a PR
https://github.com/SVProgressHUD/SVProgressHUD/pull/586

I met the same problem also

I created a new Project just now,after install 2.0.1 to my  project,I get the same errors as they are.

i met same problem with XCode 7.2
after i update my os x 10.11 to 10.11.4 and update XCode 7.2 to 7.3
i can build project and this issue has solved


[Request For External] report 95 "Date Compress VAT Entries" - 'make EntrdDateComprReg' protected

Describe the request
We request to make the variable 'EntrdDateComprReg' protected in report 95 "Date Compress VAT Entries".
Additional context
We want to create a report extension and put additional checks on these settings before our customers run the report as we have found not all settings are compatible performance wise.
Internal work item: AB#540588

Additionally: expose all RequestPage-fields for every "Date Compress"-report, to be able to extend the behavior via ReportExtensions.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 22878.


Portainer can't access local stack when using Podman and Systemd

Bug description
I am using portainer to manage my stacks, which are pulled from my git repository. Instead of docker I use Podman in user space. I created a systemd unit with podman generate systemd ..., also in user space to autostart portainer after a restart of the system. When using Portainer without Systemd, all works fine, but if systemd starts the portainer instance after a reboot (also in user space), portainer starts normally and after a few minutes, i can't access my stack anymore nor am I able to look at my container. The container from my stack are not started at all. Every Podman command on the system takes a minute to execute. If running Podman ps, portainer is listed as running.
Expected behavior
The Portainer should start normally, create my container and the stack should be accessable from the web gui.
 Yes
sytsemd version: 252 (252-14.el9_21.1)

Portainer does not currently fully support Podman. This is something we're hoping to support better in the future. You can find some detail on the limitations of our current support in this issue.

after some more testing around i can finally say, that currently it is not possible to use portainer for managing stacks with podman on a non-root user

Is rootless podman management possible yet? I saw this blog article indicating it should be possible https://blog.while-true-do.io/podman-portainer/


missing main entry

since version 4.0.0 rollup picks the browser.js instead of node.js
maybe package main entry got lost in 34fedffe22be8600dc48559f4309715ef6411393 ?

Hmm ... the package.json file in the project root is not published, instead this project is build with pika into a pkg/ folder which then is published. The published package.json has a "main" field for node<EMAIL_ADDRESS>But also a "module" field which points to the browser version. I wasn't aware that folks would use that for Node, too?

I just made double sure that at least require-ing in node is still working as expected:
https://runkit.com/gr2m/gr2m-universal-user-agent-23

Any idea how to resolve problem? What would the published package.json look like, ideally?

There two degrees of freedom

content

browser
node

package format

esm
require ?

And only there entry points

browser
main
module

Let me dig around
the rollup-plugin-node-resolve  plugin
to find other modules with the same pattern (esm module(s) either for browser or node)
How is this handled in the other @octokit modules ?
For my node cli app I want to pick node/esm (through @octokit/rest)

How is this handled in the other @octokit modules ?

Hmm the other Octokit modules mostly work the same in both Node & browser, with the exception of https://github.com/octokit/auth-app.js/ which is using the browser's WebCrypto API and for Node it's using the jsonwebtoken package
I did not yet migrate all @octokit modules, but soon all of them will be built with https://github.com/pikapkg/pack and will have the separate builds for node (using require) and browsers (using import).
Pika also distributes a dist-src folder, maybe that will work for you? Try to import universal-user-agent/dist-src (See published code here<EMAIL_ADDRESS>

The problem is I am only using
import octokit from "@octokit/rest";

Ah got it. Hmmm I really don't know, but I hope we find a solution for this. I asked the folks from Pika on twitter, maybe they have an idea what to do: https://twitter.com/gr2m/status/1169357730944958464

when declaring universal-user-agent as external in rollup i am able to select the node content out of the package (even through @octokit/rest).
But then there is the breaking change between 3.0.0 and 4.0.0 (default export vs named export) which is not reflected in @octokit/rest

It should be as of v16.28.9: https://github.com/octokit/rest.js/pull/1460

@arlac77 I'm trying to use @octokit/rest in node but running into similar problems as you. I'm using webpack and I'm excluding universal-user-agent from the build but AWS Lambda is still trying to load it:

Runtime.ImportModuleError: Error: Cannot find module 'universal-user-agent'

I'm using the latest @octokit/rest but no luck. Any ideas?

@schof I have no solution only a workaround my list of to be excluded modules (rollup) gets longer and longer.
// rollup.config.js

const external = [
  ...builtins,
  "universal-user-agent",
  "@octokit/rest",
  "node-fetch"
];

@arlac77 I tried the same thing you are doing with similar results. Ultimately I got things working by not excluding anything and monkey patching the universal-user-agent library. Webpack allows you to specify multiple locations for your node file - perhaps roll up will allow you to do something similar?
resolve: {
  // Monkey patch to resolve https://github.com/mobileposse/neptune/issues/296
  modules: [path.resolve(__dirname, 'build/src/monkey-patch'), 'node_modules'],
  extensions: ['.tsx', '.ts', '.js']
}

then i took the index.js contents from the universal-user-agent package and dropped it into build/src/monkey-patch directory:
'use strict'

Object.defineProperty(exports, '__esModule', { value: true })

function _interopDefault(ex) {
  return ex && typeof ex === 'object' && 'default' in ex ? ex['default'] : ex
}

var osName = _interopDefault(require('os-name'))

function getUserAgent() {
  try {
    return `Node.js/${process.version.substr(1)} (${osName()}; ${process.arch})`
  } catch (error) {
    if (/wmic os get Caption/.test(error.message)) {
      return 'Windows <version undetectable>'
    }

    throw error
  }
}

exports.getUserAgent = getUserAgent

Hope that helps. Good luck!

I’m sorry this is causing so much headache, I hope we find a simpler solution that I can apply to the libraries, universal-user-agent is not the only one that is published this way

Hey yall, sorry for the delay jumping into this! Happy to help where i can. @arlac77 sounds like you summed it up pretty well, we have a 2x2 matrix and only 3 entrypoints to represent them with. On top of that, "module" has a real frontend focus at this point, since web bundlers are primarily the only real environment that they are expected to be used in.
The result is that "Node ESM" is relatively unsupported, given that the official plan is for Node to move to: type: "module", main: "index.mjs". But until then, there really is no good way to use ESM on Node.js.
Like @gr2m I'm still not sure I understand what situation is wanting you to use rollup inside of Node. Are you trying to bundle a Node application into a single JS file? If so, Webpack would probably be a better fit since it's much more Common.js dependent & reliant. https://github.com/zeit/ncc & https://github.com/zeit/pkg may also be good options for you.
If you really do need to use Rollup, have you tried the latest version of https://github.com/rollup/rollup-plugin-node-resolve ? Its most recent syntax allows you to define either mainFields: ['main', 'module'] (to prefer main over module) or mainFields: ['main'] (to only read from main). That could solve your problem as well.

@FredKSchott, @gr2m : The @octokit/rest library just doesn't work anymore in a nodeJS environment (Lambda) after the 4.0 release - also when webpack is used. It just crashes with module initialization error: ReferenceError.
Our CI/CD tooling completely stopped working since then and a downgrade of @octokit/rest doesn't seem to work, since the other octokit dependencies also use the v4.

@maplesteve There must be a way in webpack to workaround this, like there is in rollup as mentioned by @FredKSchott. It's not something that I can fix in Octokit itself, I'm afraid.
But people keep running into this so I'd love to address it in the READMEs.

@maplesteve @schof @arlac77
Could you please try to directly edit node_modules/universal-user-agent/package.json and add "type": "commonjs" to it, and see if that resolves the issue?
Also, could you please setup a repository with the most minimal build setup that reproduces the problem for you? I would appreciate to have both a setup using webpack and rollup.
Let's fix this 💪

There is also a new "exports" field that might work:
https://nodejs.org/api/esm.html#esm_package_exports
I've asked on the twitters and Myles shared some helpful links:
https://mobile.twitter.com/gr2m/status/1176199758127362048

Here a starting point showing rollup selecting browser content by default and the 'external' workaround to exclude 'universal-user-agent' from bundling
arlac77/universal-user-agent-bundler-problems

I’m starting to think this may be a Lambda misconfiguration/issue, If they’re using webpack internally there’s a configuration for this that they could probably set to solve for this: https://webpack.js.org/configuration/resolve/#resolvealiasfields

@gr2m
Adding "type": "commonjs" yields the same error:
"errorType":"ReferenceError",
"stackTrace": ["ReferenceError: navigator is not defined","at getUserAgent
(webpack:///./node_modules/universal-user-agent/dist-web/index.js?:4:5)","at eval
(webpack:///./node_modules/@octokit/endpoint/dist-web/index.js?:364:126)","at
<EMAIL_ADDRESS>

@FredKSchott regarding Lambda: "they" in terms of AWS are doing nothing with webpack. Webpack is used to bundle the code which then gets uploaded and used in the Lambda environment. It worked before.

@maplesteve I found https://github.com/netlify/netlify-lambda/issues/138 which sounds similar to yuor probelem. See their fix at https://github.com/netlify/netlify-lambda/pull/160/files. It looks like webpack is prefering the browser field over module and main which is causing the problem. In the case of universal-user-agent, you might need to set it to just main or ["main", "module"]. Could you give that a try?
I think Shawn summerizes the problem pretty well

this is unfortunately just a result of us using webpack for something it wasn't strictly designed to do

@maplesteve ah gotcha, I’d misunderstood. If you own the webpack config / are running webpack yourself, hopefully that resolveAlias config option fixes thing

@gr2m
The webpack changes according to the netlify issue did not help.
I created a repo to reproduce: https://github.com/maplesteve/navigator-error

Can you please try to set resolveAlias as suggested by Fred? I'd try this
module.exports = {
  resolve: {
    aliasFields: []
  }
};

@gr2m tried your suggestion re: aliasFields and also some other values ('browser', 'commonjs'...) but still get the same error. The source still references e.g. @octokit/request/dist-web/index.js where IMO it should pick @octokit/request/dist-node/index.js

Also, could you please setup a repository with the most minimal build setup that reproduces the problem for you? I would appreciate to have both a setup using webpack and rollup.
Let's fix this 💪

I think I hit this issue when trying to add webpack to the actions/typescript-action template. This is a minimal main.ts:
//import * as github from '@actions/github';
const github = require('@actions/github');

export async function run() {
  try {
    console.log("HELLO WEBPACK!");

    var slug = ['user','repo']
    if (github.context.payload.repository && github.context.payload.repository.full_name) {
        slug = github.context.payload.repository.full_name.split('/')
    }
  }

  catch (error) {
    throw error;
  }
}

run();

And the webpack.config.js:
const join = require('path').join;
module.exports = {
	entry: './dist/main.js',
	target: 'node',
	output: {
		path: join(__dirname, 'dist'),
		filename: 'main.pack.js'
	},
	optimization: {
		minimize: false
	},
	devtool: 'sourcemap'
};

Either requiring or importing @actions/github adds the following to main.pack.js:
/***/ "./node_modules/universal-user-agent/dist-web/index.js":
/*!*************************************************************!*\
  !*** ./node_modules/universal-user-agent/dist-web/index.js ***!
  \*************************************************************/
/*! exports provided: getUserAgent */
/***/ (function(module, __webpack_exports__, __webpack_require__) {

"use strict";
__webpack_require__.r(__webpack_exports__);
/* harmony export (binding) */ __webpack_require__.d(__webpack_exports__, "getUserAgent", function() { return getUserAgent; });
function getUserAgent() {
    return navigator.userAgent;
}

The published package.json has a "main" field for node<EMAIL_ADDRESS>

But also a "module" field which points to the browser version.

Using the module field for a browser version is not correct. module only indicates the package format esm.
Only the browser field indicates a browser version.
You can map all variants to files with both fields:
"main": "node-cjs.js",
"module": "node-esm.js",
"browser": {
  "node-cjs.js": "web-cjs.js",
  "node-esm.js": "web-esm.js"
}

@gr2m:  I understand the analysis of @sokra means, that this has to be done in the universal-user-agent package, correct?

@sokra Thanks Tobias, that makes sense.
@maplesteve  I will give it a try. I have to check in with @FredKSchott to see if this will still work with pika.dev

I created a repository to explore the idea mentioned above:
https://github.com/gr2m/universal-publish-test
It has two packages: @gr2m/universal-dependency and @gr2m/universal-sub-dependency. I've added two examples for rollup with node & browser targets.
@maplesteve could you maybe add a minimal example similar to https://github.com/gr2m/universal-publish-test/tree/master/rollup-node-test without the Serverless modules and Typescript?
I could not yet test if it works with @pikapkg because the packages don't seem to be building?

https://pkg.fyi/@gr2m/universal-dependency
https://pkg.fyi/@gr2m/universal-sub-dependency

@FredKSchott could you please check if it's something on my side or an error on Pika's? 🙏
For Pika, I think I could try to build and submit two new plugins:

@pika/plugin-build-universal
@pika/plugin-bundle-universal

That would follow the structure suggested above. What do you think @FredKSchott? Would that still work with the automated bundle builds for Pika CDN?

add a minimal example similar to https://github.com/gr2m/universal-publish-test/tree/master/rollup-node-test without the Serverless modules and Typescript?

@1138-4EB posted a simpler example you can use.
Maybe, the easiest way to solve this, is to just revert the change to pika, since this seems to be the root problem. The GitHub-SDK (octokit) is broken for a lot of people for nearly a week because of this.

add a minimal example similar to gr2m/universal-publish-test:rollup-node-test@master  without the Serverless modules and Typescript?

@1138-4EB posted a simpler example you can use.

Note that the simple example above requires to execute tsc before webpack. This other project uses the same base, but the entry is set to main.ts and ts-loader is used: https://github.com/1138-4EB/issue-runner/blob/master/webpack.config.js I believe this is a better 'real world' example.

Maybe, the easiest way to solve this, is to just revert the change to pika, since this seems to be the root problem. The GitHub-SDK (octokit) is broken for a lot of people for nearly a week because of this.

It is possible to work around octokit being broken with https://github.com/1138-4EB/issue-runner/blob/40e659b7f6e0cca8125ac6e67d180a390fd5625b/.github/workflows/push.yml#L23-L25. It's an ugly fix, but it will let users to keep building actions/modules until this issue is properly fixed.

Maybe, the easiest way to solve this, is to just revert the change to pika

I really don't want to do that, it's been a blessing to reduce the maintenance overhead. I'm still optimistic that we find a way around this and there are workarounds for the time being

There is no workaround that „just works“ and patching distributed files of a sub-dependency is a no-go. Then at least release a version of octokit, that does this patching itself, so that we can use it again.

I do what I can Stephan.

@gr2m I think that the main point is that adopting a tool which is less than a year old has broken a very broadly used package. This situation was reported 22 days ago, and it seems that it won't be fixed soon. From a professional point of view I think you should reconsider your position.  It is frustrating to read that you don't want to (i.e. prefer not to) fix it, although it seems that you know a way to do it now.
I understand that using pika is a blessing to reduce maintenance overhead and I am not arguing against. Nonetheless, I believe you can keep the migration to pika in a feature branch, revert the changes in master and then take your time to fix the issues with pika. It is not even clear yet if this is something to be fixed upstream.
The evolution of this issue is quite opposite of what is expected from a 'stable' tool. This is just some honest and constructive criticism; so, please, let us know how can we help you to have this issue fixed ASAP. We can then focus on enhancements and/or chores.

@1138-4EB  I know what to do. Have some patience. If you don't know how to temporarily patch (sub) dependencies without nasty hacks than please do some more research, it's really not that hard and will happen again earlier or later.
Please refrain from putting pressure on Open Source maintainers. I understand you are frustrated, but remember you are not entitled to anything. Please refrain from further commenting. I will update this issue as soon as there is a new version available.

temporarily patch (sub) dependencies without nasty hacks

Which earlier commit do you recommend?

I like https://www.npmjs.com/package/patch-package

@1138-4EB in your  webpack example, can you try the mainFields fix proposed above?
module.exports = {
   entry: './dist/main.js',
   target: 'node',
   resolve: {
     mainFields: ['main', 'module']
   }
   output: {
   	path: join(__dirname, 'dist'),
   	filename: 'main.pack.js'
   },
   optimization: {
   	minimize: false
   },
   devtool: 'sourcemap'
};

@FredKSchott, thanks for the suggestion! I tried https://github.com/1138-4EB/issue-runner/commit/be8dc20566780e557dcb11ebd0e9b730ed5bce27, but an error is produced when running webpack: https://github.com/1138-4EB/issue-runner/commit/be8dc20566780e557dcb11ebd0e9b730ed5bce27/checks#step:6:33

you might try working around the issue temporarily by marking it as an external in your webpack config. that would exclude it from the bundle and instead require it a runtime. not as ideal as everything going into the bundle, but should still work as long as node_modules/ are still available in your runtime environment.

@FredKSchott I now tried exactly the config you proposed (i.e. with a js file as an entry instead of a ts file): https://github.com/1138-4EB/issue-runner/commit/d7a7567b9ffd4af59d3b6de25bed5a7541973f40. I can confirm that it works. Compilation/build is successful, and execution too.
It is not ideal because I had to do a two-step build (first tsc, then webpack). Anyway, I consider this to be a negligible annoyance compared to not being able to build it. And it is definitely better than any other fix/patch suggested so far.
@travi, the default suggested workflow for js/ts GitHub Actions is to distribute a node_modules dir along with the main js file. I am precisely trying to avoid it. Should I need to keep node_modules for a single dep, I'd just run tsc and ignore webpack. Nonetheless, thanks for the suggestion; I will sure use it in other contexts.

Quick update: we are still looking into it.
@1138-4EB I have automated releases for my JavaScript-based actions which also use Octokit using semantic-release & ncc. I'm very happy with the setup, you can see it in action e.g. at https://github.com/gr2m/twitter-together/blob/master/.github/workflows/release.yml. I did not run into any of the problems discussed here

@gr2m thanks for reporting! According to the comments in pikapkg/builders#90, the issue seems to be an unfortunate interaction with webpacks defaults only. Anyway the suggestion by @FredKSchott fixed the issue, so I can keep using https://github.com/1138-4EB/issue-runner/blob/master/webpack.config.js until this issue is fixed, until webpacks changes the defaults, or until I switch to a different packager.

For me the problem is that there is no way to select the node (none browser) content with a esm bundler (rollup).
If the default for this module sticks to the browser version (when using esm) i am lost (and all the other users of esm bundlers for none browser targets too)
@gr2m maybe the decision of providing the browser version behind the package "module" entry should be reflected

rollup has a setting just like webpack which allows you to prefer "main" over "module" package key for builds with node target.

@gr2m shure but this is a global rollup config decision. I would rather like it the other way around and explicitly use the "browser" option of rollup-plugin-node-resolve
// some package.json files have a "browser" field which specifies
      // alternative files to load for people bundling for the browser. If
      // that's you, either use this option or add "browser" to the
      // "mainfields" option, otherwise pkg.browser will be ignored
      browser: true,  // Default: false

I understand your preference, but it's not going to happen any time soon, your use case is the edge case here.

@gr2m isn't the purpose of "universal-user-agent" to provide a user agent for none browser applications too ? shouldn't node applications be in the main focus (there the need for a user agent is higher than in the browser) ?
As shown in universal-user-agent-bundler-problems doesn't work for the minimal rollup bundling (none browser) use case

Node apps work perfectly fine, because node apps respect the "main" key. The "module" key is not used by Node it won't be in future as things state right now, the problem here are build tools with node as a target, which is an edge case compared to building for browsers.
I'm still looking into making it work, but there is a lot to consider. And the build problems for node can be worked around so there is no rush.

@gr2m even without bundling "universal-user-agent" can`t be used from node as a es6 module
So then please correct your README example and remove the import variant or state that the module is browser only (which then cascades to all the @octokit modules too)
import { getUserAgent } from "universal-user-agent";

console.log(getUserAgent());

node --experimental-modules index.mjs

file:///Users/markus/build/universal-user-agent-bundler-problems/index.mjs:1
import { getUserAgent } from "universal-user-agent";
         ^^^^^^^^^^^^
SyntaxError: The requested module 'universal-user-agent' does not provide an export named 'getUserAgent'
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:93:21)
    at async ModuleJob.run (internal/modules/esm/module_job.js:108:20)
    at async Loader.import (internal/modules/esm/loader.js:137:24)
mbpMarkus:universal-user-agent-bundler-problems markus$ cat index.mjs

I’ve said all there is to say. I recommend you do some research about the state of ES modules in Node.
I’ll add further comments when I have any update

The problem has nothing to do with ES modules itself, only with the selection between node or browser content.
I don't see any solution from node side all they are working on is improving the esm experience.
The authors an consumers of packages together have to find a way to select between both worlds
(that's why someone invented the browser field)

@gr2m the official npm doc also mentions the browser field
browser

Her another type of workaround:
replacing the whole module with one line of code during bundling (for node runtime only).
rollup.config.js
import virtual from "rollup-plugin-virtual";
...

    plugins: [
      virtual({
        "universal-user-agent":
          "export function getUserAgent() {return `Node.js/${process.version.substr(1)} (${process.platform}); ${process.arch})`}"
      }),
      ...otherPlugins
    ]

@gr2m there is a recently updated proposal for Conditional Mapping in packages
jkrems/proposal-pkg-exports

Thanks I'm following it closely, relevant discussion is here: https://github.com/nodejs/modules/issues/401

Does anyone know of a way to workaround this (other than editing the package.json) with webpack (also without using resolve.mainFields because that affects all modules). I am trying to use octokit/code in 2 of my VS Code extensions and because I use ES modules (mainly for tree-shaking) this breaks the bundling.
I've tried using
alias: {
	'universal-user-agent': 'node_modules/universal-user-agent/dist-node/index.js'
}

But that causes other Module not found: Error: Can't resolve 'universal-user-agent' in other octokit dependencies.

There is no ESM version of universal-user-agent for Node right now, sorry. The ESM version is for browsers, Node only has a CJS version. Because Node didn't support ESM until very recently.
I've worked with Node's ES Modules working group over the past weeks and there is a clear way forward now. It will take some time for the build tools and Pika to catch up, but Node's latest spec supports all that we need: https://github.com/nodejs/node/blob/master/doc/api/esm.md
The package.json will look like this:
{
  "main": "dist-node-cjs/index.js",
  "module": {
    "browser": "dist-browser/index.js"
    "default": "dist-node/index.js"
  }
}

Once the tooling catches up, I'll update the library. Shouldn't take too long, it's mostly Pika and its Rollup plugins, and Fred from Pika has been involved in the same working group.

Fixed by adding the following alias in webpack configuration as always.
alias: {
            "universal-user-agent$": "universal-user-agent/dist-node/index.js
}

I've managed to use Webpack's NormalModuleReplacementPlugin to point Webpack to the correct entry point for my Serverless service:
plugins: [
  new webpack.NormalModuleReplacementPlugin(
      /universal-user-agent\/dist-web\/index\.js/,
      "../dist-src/index.js"
    )
]

I used dist-src as it still uses modules whereas dist-node is CommonJS.

The above workaround with NormalModuleReplacementPlugin did not work for me, but this did:
resolve: {
  // ...
  alias: {
    "universal-user-agent": path.resolve(
      __dirname,
      "node_modules/universal-user-agent/dist-src/index.js"
    )
  }
}

I'll add a try/catch around the navigator.userAgent, so at least it should no longer throw an error, via https://github.com/gr2m/universal-user-agent/pull/41
Once conditional exports are supported by @pika/pack, I can provide custom exports for different environments, so the resulting user agent will be more helpful than <navigator unknown>, but at least this should unblock people for the time being
Any thoughts?

I've decided to greatly simplify this package to workaround the build problems y'all are experiencing. I was hoping for conditional exports to be adopted more quickly, but it does not look like it.
See https://github.com/gr2m/universal-user-agent/issues/52

I've managed to use Webpack's NormalModuleReplacementPlugin to point Webpack to the correct entry point for my Serverless service:
plugins: [
  new webpack.NormalModuleReplacementPlugin(
      /universal-user-agent\/dist-web\/index\.js/,
      "../dist-src/index.js"
    )
]

I used dist-src as it still uses modules whereas dist-node is CommonJS.

https://github.com/gr2m/universal-user-agent/issues/23#issuecomment-569959072


SHOW FULL COLUMNS FROM ...will be error

SELECT a.login as acc_id, a.credit, ifnull(b.profit, 0) as profit, ifnull(c.in_amt,0) as in_amt, ifnull(d.out_amt, 0) as out_amt FROM `tb_userrecord` a LEFT JOIN (select sum(profit) as profit,`login`,`cmd` from tb_2020 where cmd<=1 group by login) b ON (b.login=a.login) LEFT JOIN (select sum(profit) as in_amt,`login`,`cmd` from tb_2020 where cmd=6 and profit > 0 group by login) c ON (c.login=a.login) LEFT JOIN (select sum(profit) as out_amt,`login`,`cmd` from tb_2020 where cmd=6 and profit < 0 group by login) d ON (d.login=a.login) WHERE a.login=123456788 LIMIT 1

when i select this sql use by gdb.Will report an error
[default] SHOW FULL COLUMNS FROM (select
Error: Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(select' at line 1
Stack:

The result can be returned normally，But 8 to 10 records will be error
table := "tb_userrecord a"
	field := `a.login as acc_id, a.credit, ifnull(b.profit, 0) as profit,
	ifnull(c.in_amt,0) as in_amt, ifnull(d.out_amt, 0) as out_amt`
	where := g.Map{}
	where["a.login"] = params.AccId
	rs, err := g.DB().Table(table).Fields(field).
	LeftJoin("(select sum(profit) as profit, login, cmd from tb_2020 where cmd<=1 group by login) b", "b.login=a.login").
	LeftJoin("(select sum(profit) as in_amt, login, cmd from tb_2020 where cmd=6 and profit > 0 group by login) c", "c.login=a.login").
	LeftJoin("(select sum(profit) as out_amt, login, cmd from tb_2020 where cmd=6 and profit < 0 group by login) d", "d.login=a.login").
	Where(where).FindOne()
	if err != nil {
		return nil, err
	}
	return rs, nil

this is my code
Help solve the trouble. Thank You！！！

@RAGGA-TIME The SQL is .. a little bit complicated using ORM chaining operations. Try using g.DB().Query(xxx) or g.DB().GetOne(xxx) instead.

@RAGGA-TIME The SQL is .. a little bit complicated using ORM chaining operations. Try using g.DB().Query(xxx) or g.DB().GetOne(xxx) instead.

gf release v1.13.1
SELECT a.*, b.score, b.subjects FROM user_mstr a
INNER JOIN (
select sum(x.score) as score,x.subjects as subjects,x.u_id as u_id from user_score as x where x.subjects = '语文' group by x.u_id
) b ON (b.u_id = a.u_id)
this sql i wanna use ORM operations to select but will be error like this
[DEBU] [163 ms] SHOW FULL COLUMNS FROM user_mstr
2020-09-23 10:33:46.135 [ERRO] [ 41 ms] SHOW FULL COLUMNS FROM (select
Error: Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(select' at line 1
it just SHOW FULL COLUMNS will be error
result can be returned normally
i think use left join / inner join encounter parentheses they will be SHOW FULL COLUMNS
It would be best if can solve this error~ Thank you


More lite update ?

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
Hello,
When I try to "update" npm, I have :
root@VM:~# npm install npm -g
-bash: npm: command not found
root@VM:~#

So I try to "install" it :
apt install npm
But, like drama :
(cf screen).

759MB needed for that...
My debian is about 160MB...
Is there more lite system plz ?
thank :)
🐻 Uptime-Kuma Version
0
💻 Operating System and Arch
Debian 11.4 64b
🌐 Browser
no
🐋 Docker Version
no
🟩 NodeJS Version
no

Node and NPM are both required for this project, without them the project simply will not run. Have you tried installing as per the recomendations at https://docs.npmjs.com/downloading-and-installing-node-js-and-npm?

Node and NPM are both required for this project, without them the project simply will not run. Have you tried installing as per the recomendations at https://docs.npmjs.com/downloading-and-installing-node-js-and-npm?

No.
I can't cause NPM not present.
Your link is when NPM is already install.
As you see, there is more than 2 apps (Node and NPM) in my screen... there is about one hundred apps ask to install for install NPM alone.
This installation cause 750MB of space, for a "simple" debian of 160MB current usage...
All this for a little bot.

The instructions detail how to install using node version manager as well as the downloads from the nodejs website and do not require npm to already be installed.
As for all of these other apps, these are dependencies of nodejs and npm. Without them, node will not function correctly. There are so many likely due to your Debian install being very light weight and as such having few libraries preinstalled.

Node.js is lightweight, It is just because you were not following the official Node.js installation guide.
You don't need to run apt install npm actually.
# Using Ubuntu
curl -fsSL https://deb.nodesource.com/setup_lts.x | sudo -E bash -
sudo apt-get install -y nodejs

# Using Debian, as root
curl -fsSL https://deb.nodesource.com/setup_lts.x | bash -
apt-get install -y nodejs

Reference: https://github.com/nodesource/distributions

Hello
From my little DEBIAN 11:
docker system df -v
louislam/uptime-kuma           latest    4495e097b5fa   2 months ago   390.8MB   0B            390.8MB       1

du -sh /docker/volumes/uptime-kuma
27M     /docker/volumes/uptime-kuma

docker stats --no-stream
CONTAINER ID   NAME                         CPU %     MEM USAGE / LIMIT     MEM %     NET I/O           BLOCK I/O        PIDS
6dc0e2bb9e2c   kuma.exemple.com   0.81%     175.3MiB / 7.664GiB   2.23%     15.7MB / 3.28MB   90.8MB / 192MB   12

Rewrite to avoid closing... don't have test all


Massive issue on Mac OSX with emoji

I don't know what's going on, but when you insert an emoji, there is some odd repetition of markup happening.

Perhaps related to non-BMP character handling?

Indeed, input handling is ... difficult to get right :)

@weinand Does this work as expected now?

@alexandrudima this seems to work now. I couldn't reproduce the problem from above. But I'm not sure what tool @codepo8 was using to insert the emojis.

Still experiencing this issue on code 1.10.1


Access the original response in resolver

Thanks for this library.
I'm wondering if there is any way to intercept the original response in the resolve phase:
createInterceptor({
    modules: [interceptXMLHttpRequest],
    async resolver(req, ref) {
       const originalResponse = await ??
       return modifyResponse(originalResponse)
   }
)

Thanks.

Hey, @ArielGueta.
You can listen for any kind of response using the "response" event of the interceptor:
const interceptor = createInterceptor(...)

interceptor.on('response', (request, response) => {
  console.log(response)
})

https://github.com/mswjs/interceptors/blob/ca5cc325ef935d610ee33657e76e94e95420c500/src/createInterceptor.ts#L45-L48
This library is not concerned about whether the response was mocked or not, because it's not concerned with mocking in the first place. You can intercept requests and mock responses, but then it becomes your responsibility to distinguish between original and mocked responses. This is something we do in MSW by keeping track of request.id.
I also see that you're using a rather old version of this library in your code example. Please make sure to update to the latest one to have all the recent fixes and improvements. Thanks.

Following up on your question, I've missed the part where you wanted to perform the original request within the resolver. You can do that but you'd have to construct the request from scratch based on the info exposed in request.
Here's an example of response modification using node-fetch:
import fetch from 'node-fetch'

createInterceptor({
    modules: [interceptXMLHttpRequest],
    async resolver(req, ref) {
       const originalResponse = await fetch(req.url.href, {
         method: req.methof,
         headers: req.headers,
         body: req.body
       })
       const json = await originalResponse.json()

       return modifyResponse(json)
   }
)

But this will create an infinite loop, no?

A good catch. That's why when we do a similar thing we append a special header to the original request, forcing the interceptor to bypass requests with that header. You can check that header's presence/value in the resolver, and if it's there, do an early return, which would bypass such a request.

Thanks.

Released: v0.19.3 🎉
This has been released in v0.19.3!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


iPhone X: Additional horizontal inset for list/grid view content in horizontal layouts

Steps to Reproduce
On the iPhone X, List views in horizontal mode should include additional horizontal padding on either side to avoid drawing list content under the sensor housing notch.
See Apple's Human Interface Guidelines for iPhone X.
Dependent on issue #12098
Example from Flutter Gallery:

Flutter Doctor
[✓] Flutter (on Mac OS X 10.12.6 16G29, locale en-AU, channel master)
    • Flutter at /Users/cbracken/src/flutter/flutter
    • Framework revision dd7e313317 (51 minutes ago), 2017-09-14 12:28:21 -0700
    • Engine revision 57a1445a45
    • Tools Dart version 1.25.0-dev.11.0

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)
    • Android SDK at /Users/cbracken/Library/Android/sdk
    • Platform android-25, build-tools 25.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] iOS toolchain - develop for iOS devices (Xcode 9.0)
    • Xcode at /Applications/Xcode9.0.app/Contents/Developer
    • Xcode 9.0, Build version 9A235
    • ios-deploy 1.9.2
    • CocoaPods version 1.3.1

This isn't about list views. The same is true for any content.
We should probably just have the Scaffold automatically indent its body appropriately (using MediaQuery.of(padding), and updating the padding on the inside accordingly, see https://github.com/flutter/flutter/issues/12084), with a parameter to override that in case you want something else to take care of it.

It's not strictly about any content -- e.g. much full-screen content such as images should not be inset, but it's definitely more general than list/grid views.

ListTile and the gallery home screen done in #13545.


[Distributed] Destroy decoded parameters after executeDistributedTarget

Description: We recently fixed a similar issue where the objects created from decodeNextArgument in a distributed thunk were not properly destroyed. The fix was in https://github.com/apple/swift/pull/65952
In that fix, we missed handling of Indirect_In_Guaranteed which also need to be destroyed, this patch corrects that omission.
Risk: Low, impacts only distributed methods, and only struct arguments. The specific shape of fix was previously done already, but was missing for one of the cases of parameter ownership kind.
Impact: The problem manifests in deinitialization not running as expected for decoded arguments. The memory for those parameters freed but destroy logic is not run on those. This results in memory leak detection triggering for distributed methods. All distributed actor adopters are impacted.
Resolves https://github.com/apple/swift/issues/70004
Resolves rdar://119943672
Resolves rdar://119446012

@swift-ci please smoke test

@swift-ci please smoke test


[ENHANCEMENT]  Cleanup on configurations

Hey, I've took some time to update the configurations as requested on issue #19 to make them more organized and readable and came up focusing in the profiles, here goes my work on that.
Profiles setup:

standard
stub
docker
conda
gls
azureBatch
awsBatch

I'm at your disposal to make any requested changes and discuss this proposal, feel fee to contact me in the comments section.
Warmly, Davi

Didn't review, only commented as the PR is in draft mode.

no problem, this PR need some work until the review

Thanks @Mxrcon , this looks good to merge.
TIP: Use either the label or the PR name for specifying the type. This PR mentions Enhancement twice.

Ok :+1: in the next time I'll add only a label


Implement RFC #8

resolves #1137

Are there any unit tests that make sense for this?  For example, testing that _AutoOps gives the right number of ops is one idea that comes to mind for something that could be easily unit tested.

thank you @Theodus


=Thanks for your concern - The project is not dead; it has been held back by several subdependencies and a complicated release process. This is on me and the next release (which is actually almost finished) seeks to address a large number of these underlying issues including a single point of failure in the maintainership chain.  Unfortunately that requires a substantial amount of documentation which is also currently in progress.

Thanks for your concern -- The project is not dead; it has been held back by several subdependencies and a complicated release process. This is on me and the next release (which is actually almost finished) seeks to address a large number of these underlying issues including a single point of failure in the maintainership chain.  Unfortunately that requires a substantial amount of documentation which is also currently in progress.
I recently accepted a role that affords me time to tackle these issues so I have been making progress, albeit slowly.  I apologize for failing to be more communicative but this is incredibly important to everyone, myself included, and updates will be cascading to pipenv shortly.
Originally posted by @techalchemy in https://github.com/pypa/pipenv/issues/4058#issuecomment-565550646
')(

FYI @aserr13 I recently came across https://github.com/sarugaku/requirementslib/issues/297 which is minimally patched in https://github.com/sarugaku/requirementslib/pull/298 , would be great to merge a new requirementslib to fix multiple installations of each editable packages on each pipenv install.

Hi @aserr13 , Please modify the issue type, I can't read what you desire. Or close this issue.

@frostming I have seen many of these 'originally posted elsewhere' issues and PRs recently, many of which have similar structure. I suspect that they are possibly generated text posted by bots.
E.g.:
mdn/browser-compat-data#11280
mdn/browser-compat-data#11279
mdn/browser-compat-data#11377

Thanks, closing it now


FEAT: Added husky precommit hooks

Added huskey to run linting , formatting & build test before commiting change. #80

Good to go

I hope its ready to merge @Fryingpannn


Megaseed vendor in permabrig doesn't work with no id access

Description

If you are in permabrig as priosnner with your id taken away you can't use the megaseed vendor
Reproduction

use megaseed vendor in permabrig with no id

Additional context

if you are a prisonner in permabrig you probably don't have an id if security took it away but that doesn't mean you shouldn't be able to grow tomatos

This is a mapping specific issue. This needs to say which map specifically has this issue.

i dont remember

I checked every map with a permabrig, and it does seem like a common issue. A couple even have a NutriMax that's inaccessible as well. Listing them here:
Lighthouse
NSS Pillar +nutrimax
Packedstation
Splitstation +nutrimax

i dont recall if theres an unlocked variant prototype of the megaseed+nutrimax but there should be

A temporary solution would be to provide all the tools and a seed crate instead. That is what's in the other mid-large stations that I checked.

Respectfully wtf? We all removed the access component from them so they can be used? Unless they’ve been remapped and got the Comp back.
I had suggested adding a variant without access so we have less vv stuff.

Megaseed vendor has a access free version now so closing.


Can't select theme?

I was prompted once to select a theme but I exited out of my IDA 6.8. Once closed, I cannot bring the theme prompt to come back. I wish to switch to the dark theme/skin.
How can I go about changing the theme?

Never mind. It's in the plugins.


Update netty-tcnative-boringssl-static to 2.0.41.Final

Updates io.netty:netty-tcnative-boringssl-static from 2.0.39.Final to 2.0.41.Final.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.netty", artifactId = "netty-tcnative-boringssl-static" } ]

labels: library-update

Superseded by #419.


Add buttons on hover of headings that allow copying links to sections.

WIP, addresses #41.
Original issue suggests a hyperlink symbol, or maybe an emoji 🔗 . This PR only has text atm; we would need to think about how to include a symbol. (Icon font? Inline SVG?)
This should be built again before merging—I did not include build result template.js to avoid conflicts. Why do we check in the build results? (template.js and template.js.map)

Interaction
Most implementations of this I've seen just links to the hash, instead of copying to the clipboard. Clicking the anchor should definitely set the location hash, since that is the expected behavior with a native html implementation. Unsure whether the complexity (code + visual design needed) is worth adding the clipboard feature. Seems nice, but possibly unnecessary to combine both?
Visuals
Github uses a little link icon:

The material design icon is a candidate for an inline svg icon, though not my favorite. I think it can be misinterpreted.

Could also use a hash, like Bostock does:

Long term I was thinking of using the section number as the anchor:

Missing IDs
How should we handle headlines that don't have IDs set? Should we autofill with lowercase, hyphenated text contents? How could we make it not break old links? If we use section numbers how do we enforce that they are consistent?

Here's a interaction proposal:
Default, no chrome

On hover, headline gets an underline, button shows up to left:

Clicking on headline sets link like a normal anchor, clicking on button copies to clipboard and doesn't change the location or move the page.

all h's except first h2 if following an h1
wrap in as
underline styling on hover only
md icon on hover only