Remove console statement and add retry logic for FeedbackWidget

What type of PR is this? (check all applicable)

[x] ♻ Refactor
[x] ✨ New Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 👷 Example Application
[ ] 🧑💻 Code Snippet
[ ] 🎨 Design
[ ] 📖 Content
[ ] 🧪 Tests
[ ] 🔖 Release
[ ] 🚩 Other

Description
First Commit
This PR removes the not needed console.info statement which appears in the console when a rating is clicked.
Second Commit
In case of a failure in feedback submission due to any reason like network unreliability, added a retry mechanism which will attempt to resubmit the feedback up to three times before throwing an error in the console if it keeps failing.

I tested this locally and I noticed the request was not retrying. It was because the postFeedbackRating function was not awaiting and throwing the error.
Can you please replace the current fetch with the following?
  const res = await fetch(`${feedbackWidgetUrl}/feedback`, {
    method: 'POST',
    headers: {
      'Content-Type': 'application/json',
      'x-csrf-token': csrfToken,
    },
    credentials: 'include',
    body: JSON.stringify(requestBody),
  });

  if (!res.ok) {
    throw new Error('Failed to submit feedback rating');
  }

We can merge as soon as you do this! 👍


test 123

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

222222222222222222222222222222

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


test_format2.rs seems to be broken

test_format2.rs fails with NotFound on my machine. Actually, it doesn't look complete at all. Probably it was committed by mistake?
I suggest to remove it or at least to add an #[ignore] attribute.

Yes, this was an accident. Commented it out for now.


daemon: do not wait for entire endpoint regeneration to succeed upon endpoint creation, and re-enable Istio test

To re-enable the Istio test, I had to make changes to how endpoint creation was handled:
If the entire regeneration for an endpoint is waited to be completed (e.g., policy generation, BPF compilation / loading, and proxy updates) when an endpoint is created, then creation of endpoints which have L7 policy which selects them when Cilium is running with Istio will result in a deadlock. This is because when a pod is created, its sidecar proxy is not started yet, so when addition of the endpoint into the endpoint manager waits for regeneration to complete, the regeneration gets stuck because the its trying to configure a proxy which does not exist yet. To get around this, do not synchronously wait for the entire regeneration process to succeed for a given endpoint in endpointmanager. Instead, launch a goroutine which waits for the result of the first regeneration, and if that regeneration fails, then remove the endpoint from the endpointmanager. When the Cilium CNI plugin creates an endpoint, the API call will still wait synchronously for the generation of policy and loading of the endpoint's BPF program, but not the entire regeneration process which includes proxy updates, to complete. This means that initial L3/L4 connectivity is only in place when endpoint creation is completed when CNI creates an endpoint.
This means that currently, any L7 policy will cause deadlock in endpoint regeneration, including in v1.4. This does not affect prior branches. This will need to be backported.
I also added additional logs using the endpoint logger to make it easier to debug endpoint createion-related issues, and added the numeric identity to the endpoint logger field as well. There was a small bug in which the endpoint ID was not updated in the logger when it was allocated, so I fixed that as well.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

Coverage increased (+0.005%) to 43.737% when pulling 557f1a4d11cdc2a4809a042a22e617b267301cfb on pr/ianvernon/re-enable-istio-test into 5104ff68d4296d66334747c51330109016d0f38d on master.

The Istio test failed; bookinfo pods get stuck in Init state.
Cilium crashed due to deadlock detection getting triggered because regenerateBPF was waiting for a long time for proxy ACKS:
2018-12-18T01:13:02.232031873Z POTENTIAL DEADLOCK:
2018-12-18T01:13:02.232056866Z Previous place where the lock was grabbed
2018-12-18T01:13:02.232060584Z goroutine 117594 lock 0xc00106a750
2018-12-18T01:13:02.232063521Z /go/src/github.com/cilium/cilium/pkg/lock/lock_debug.go:78 lock.(*internalRWMutex).RLock ??? <<<<<
2018-12-18T01:13:02.232066554Z /go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:509 endpoint.(*Endpoint).regenerateBPF ???
2018-12-18T01:13:02.232069164Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:309 endpoint.(*Endpoint).regenerate ???
2018-12-18T01:13:02.232071633Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:435 endpoint.(*Endpoint).Regenerate.func1 ???
2018-12-18T01:13:02.232074289Z
2018-12-18T01:13:02.232076826Z Have been trying to lock it again for more than 5m10s
2018-12-18T01:13:02.23207926Z goroutine 117796 lock 0xc00106a750
2018-12-18T01:13:02.232092981Z /go/src/github.com/cilium/cilium/pkg/lock/lock_debug.go:78 lock.(*internalRWMutex).RLock ??? <<<<<
2018-12-18T01:13:02.232096194Z /go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:509 endpoint.(*Endpoint).regenerateBPF ???
2018-12-18T01:13:02.232098924Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:309 endpoint.(*Endpoint).regenerate ???
2018-12-18T01:13:02.232101558Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:435 endpoint.(*Endpoint).Regenerate.func1 ???
2018-12-18T01:13:02.232104015Z
2018-12-18T01:13:02.244698469Z Here is what goroutine 117594 doing now
2018-12-18T01:13:02.244718129Z goroutine 117594 [select, 5 minutes]:
2018-12-18T01:13:02.244720591Z github.com/cilium/cilium/pkg/completion.(*WaitGroup).Wait(0xc003f4e780, 0x0, 0x0)
2018-12-18T01:13:02.244722614Z 	/go/src/github.com/cilium/cilium/pkg/completion/completion.go:104 +0x195
2018-12-18T01:13:02.244724593Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).WaitForProxyCompletions(0xc0032e22c0, 0xc003f4e780, 0x0, 0x0)
2018-12-18T01:13:02.244726554Z 	/go/src/github.com/cilium/cilium/pkg/endpoint/endpoint.go:369 +0x161
2018-12-18T01:13:02.244738925Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF(0xc0032e22c0, 0x2f34a60, 0xc00030e780, 0xc00427fc20, 0x0, 0x0, 0x0, 0x0)
2018-12-18T01:13:02.244741221Z 	/go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:572 +0x502
2018-12-18T01:13:02.24474316Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerate(0xc0032e22c0, 0x2f34a60, 0xc00030e780, 0xc00427fc20, 0x0, 0x0)
2018-12-18T01:13:02.244745188Z 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:309 +0x778
2018-12-18T01:13:02.244747098Z github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate.func1(0xc002e0d4e0, 0xc002cabf10, 0xc0032e22c0, 0x2f34a60, 0xc00030e780)
2018-12-18T01:13:02.244749014Z 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:435 +0x238
2018-12-18T01:13:02.24475089Z created by github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate
2018-12-18T01:13:02.244752762Z 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:409 +0x89
2018-12-18T01:13:02.24475462Z Other goroutines holding locks:
2018-12-18T01:13:02.244756495Z goroutine 117594 lock 0xc0032e24a8
2018-12-18T01:13:02.244758306Z /go/src/github.com/cilium/cilium/pkg/lock/lock_debug.go:99 lock.(*internalMutex).Lock ??? <<<<<
2018-12-18T01:13:02.244760402Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:235 endpoint.(*Endpoint).regenerate ???
2018-12-18T01:13:02.244762283Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:435 endpoint.(*Endpoint).Regenerate.func1 ???
2018-12-18T01:13:02.244764184Z
2018-12-18T01:13:02.24476601Z goroutine 117594 lock 0xc003f4e798
2018-12-18T01:13:02.2448152Z /go/src/github.com/cilium/cilium/pkg/lock/lock_debug.go:99 lock.(*internalMutex).Lock ??? <<<<<
2018-12-18T01:13:02.244826693Z /go/src/github.com/cilium/cilium/pkg/completion/completion.go:98 completion.(*WaitGroup).Wait ???
2018-12-18T01:13:02.244838258Z /go/src/github.com/cilium/cilium/pkg/endpoint/endpoint.go:369 endpoint.(*Endpoint).WaitForProxyCompletions ???
2018-12-18T01:13:02.244840529Z /go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:572 endpoint.(*Endpoint).regenerateBPF ???
2018-12-18T01:13:02.244842436Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:309 endpoint.(*Endpoint).regenerate ???
2018-12-18T01:13:02.244844351Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:435 endpoint.(*Endpoint).Regenerate.func1 ???
2018-12-18T01:13:02.244846219Z
2018-12-18T01:13:02.244848046Z goroutine 117861 lock 0xc0032e2a28
2018-12-18T01:13:02.244849841Z /go/src/github.com/cilium/cilium/pkg/lock/lock_debug.go:99 lock.(*internalMutex).Lock ??? <<<<<
2018-12-18T01:13:02.244851844Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:235 endpoint.(*Endpoint).regenerate ???
2018-12-18T01:13:02.244853751Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:435 endpoint.(*Endpoint).Regenerate.func1 ???
2018-12-18T01:13:02.244855634Z
2018-12-18T01:13:02.244857404Z goroutine 117796 lock 0xc0032e2ce8
2018-12-18T01:13:02.24485917Z /go/src/github.com/cilium/cilium/pkg/lock/lock_debug.go:99 lock.(*internalMutex).Lock ??? <<<<<
2018-12-18T01:13:02.244861165Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:235 endpoint.(*Endpoint).regenerate ???
2018-12-18T01:13:02.244863042Z /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:435 endpoint.(*Endpoint).Regenerate.func1 ???

@jrajahalme is there anything I can look at here to determine what is happening on the Envoy side? I suspect that the VMs get bogged down due to load, but in the prior build, the test ran just fine (and succeeded in a short amount of time), so I'm wondering if there's something else at play.

test-me-please

Load on the node is still quite high:
cmd: "kubectl exec -n kube-system cilium-sd6h4 -- uptime" exitCode: 0 duration: 300.025419ms stdout:
 01:12:21 up 40 min,  0 users,  load average: 9.96, 10.11, 6.22

I think the underlying issue is that we do not have a good way of handling high-load scenarios when compiling programs. We try to use all available CPUs to compile, but if the system is running under high load, I think we should reduce the number of CPUs available. Under high enough load, operations will take longer and longer, especially compilations.

Build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8595/
Unit test failure unrelated to my changes.

test-me-please

build failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8596/

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Green build of just the Istio test:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8733/

test-me-please

Build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8734
I suspect asynchronous regeneration breaks the CI, which uses the Docker plugin. I can check whether the entire regeneration of endpoints is required (including proxy updates) in createEndpoint, and pass this as a parameter to AddEndpoint into endpointmanager to preserve the behavior that exists now.

test-me-please

@ianvernon The RegenerateWait() seems to be an optimization and is conditional on the state. I think we can simply remove it.

The RegenerateWait() seems to be an optimization and is conditional on the state. I think we can simply remove it.

I suspect that we will encounter odd behavior in the CI by removing it outright, as both PUT / PATCH operations rely on synchronous regeneration. I think that in the endpoint creation case (PUT) we are always in the expected state. Would you be okay with me merging this change as I have it (provided the tests pass) and focus on removing that separately? I suspect the change you suggested will have a lot of side effects. I can try it out locally.

Hm, same failure occurred again... https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8735/testReport/(root)/runtime/RuntimePolicyEnforcement_Policy_Enforcement_Always_Container_creation/
Checking locally.

test-me-please

Build failures: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8736/execution/node/96/log/?consoleFull

test-me-please

Found cause of build failures, will fix and re-run CI.

test-me-please

test-me-please


Change the output format of instructions to be the same as the documentation

Quoting the documentation:

The third column of the format table indicates the human-oriented syntax for instructions which use the indicated format. Each instruction starts with the named opcode and is optionally followed by one or more arguments, themselves separated with commas.
Wherever an argument refers to a field from the first column, the letter for that field is indicated in the syntax, repeated once for each four bits of the field. For example, an eight-bit field labeled "BB" in the first column would also be labeled "BB" in the syntax column.
Arguments which name a register have the form "vX". The prefix "v" was chosen instead of the more common "r" exactly to avoid conflicting with (non-virtual) architectures on which the Dalvik Executable format might be implemented which themselves use the prefix "r" for their registers. (That is, this decision makes it possible to talk about both virtual and real registers together without the need for circumlocution.)
Arguments which indicate a literal value have the form "#+X". Some formats indicate literals that only have non-zero bits in their high-order bits; for these, the zeroes are represented explicitly in the syntax, even though they do not appear in the bitwise representation.
Arguments which indicate a relative instruction address offset have the form "+X".
Arguments which indicate a literal constant pool index have the form "kind@X", where "kind" indicates which constant pool is being referred to. Each opcode that uses such a format explicitly allows only one kind of constant; see the opcode reference to figure out the correspondence. The kinds of constant pool are "string" (string pool index), "type" (type pool index), "field" (field pool index), "meth" (method pool index), and "site" (call site index).
Similar to the representation of constant pool indices, there are also suggested (optional) forms that indicate prelinked offsets or indices. There are two types of suggested prelinked value: vtable offsets (indicated as "vtaboff") and field offsets (indicated as "fieldoff").
In the cases where a format value isn't explicitly part of the syntax but instead picks a variant, each variant is listed with the prefix "[X=N]" (e.g., "[A=2]") to indicate the correspondence.

Right now, the format is a little bit off...

actually a duplicate of #683


Feature request: Data-Plane Confidentiality

Payload encryption makes LISP a highly flexible VPN solution with e.g. multi-homing, roaming, etc.
Please add support for IETF RFC 8061 to OpenOverlayRouter.

Thanks for your suggestion, we strongly believe that security is a
missing feature in OOR but we are not satisfied with LISP-CRYPTO,
since it only offers confidentiality but not authentication (it uses a
Diffie-Hellman key exchange through the MS), as such it is vulnerable
against man-in-the-middle attacks compromising the confidentiality.
We are in the process of discussing this internally to see how to fix
such issues and provide a fully-featured security solution, but this
will take some time.
As always we are more than happy to welcome any community member
willing to contribute


HBASE-29016 Refactor assembly creation to use only DependencySets and…

… move cached classpath creation to a new module

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  6s

master passed

+1 :green_heart:
compile
9m 36s

master passed

+1 :green_heart:
spotless
1m  9s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s

the patch passed

+1 :green_heart:
compile
9m 36s

the patch passed

+1 :green_heart:
javac
9m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  1s

No new issues.

+1 :green_heart:
hadoopcheck
12m  2s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 48s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

50m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6519

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 07bf2c1dcd9b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1300aa66e75725521632d094a4fdcee0ccd463b8

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
189 (vs. ulimit of 30000)

modules
C: hbase-assembly hbase-generate-dev-classpath . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s

the patch passed

+1 :green_heart:
compile
1m 54s

the patch passed

+1 :green_heart:
javac
1m 54s

the patch passed

+1 :green_heart:
javadoc
2m 18s

the patch passed

+1 :green_heart:
shadedjars
4m 53s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
281m 59s
/patch-unit-root.txt
root in the patch failed.

314m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6519

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 340c32c6411f 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1300aa66e75725521632d094a4fdcee0ccd463b8

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/1/testReport/

Max. process+thread count
9229 (vs. ulimit of 30000)

modules
C: hbase-assembly hbase-generate-dev-classpath . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Is there any difference between tarball generated with this change and without this change? If both are same, a +1 from me, as long as we all are fine to move to use only DependencySets, this is lot cleaner and avoids mixing up.
Although it is important to note that this step comes with a extra maintenance step of excluding any non base folder directory jar. Although I am fine with this given we barely add new sub folders and we already plan to add a note in code to notify devs to take care of this.

Yes, there are changes,.
I have added a list of the changes with analysis to the JIRA.
About half of them is the jaxws-ri removal, which could be split into a different issue, if desired.

Yes, there are changes,. I have added a list of the changes with analysis to the JIRA.
About half of them is the jaxws-ri removal, which could be split into a different issue, if desired.

It would prefer to have it separate it it is not too much effort since if we do more this jira should be otherwise "Refactor and cleanup"
Also thinking about the future use case of having assembly with asssembly-with-hadoop-jars, have you thought how the dependencySet mechanism will be able to handle it? Would we need to create a new module for it now? As now I am not sure how we can support multiple assemblies with single dependency set without managing exclusions lists for each assembly.xml

I have also added some reasoning on why we need the assembly changes to the JIRA.

I have also added some reasoning on why we need the assembly changes to the JIRA.

Just saw the JIRA title, sounds good to me.

For the hadoop-less assembly, I plan to copy this assembly, and add the Hadoop artifacts as provided scope dependencies.
That is the best (only) way I know to remove both the Hadoop artifacts, and their exclusive transitive dependencies, while keeping the HBase's transitive dependencies.
The only other way I know would be excluding and including everything by hand, which would be super fragile.

Re-added jaxws-ri

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  8s

master passed

+1 :green_heart:
compile
9m 35s

master passed

+1 :green_heart:
spotless
1m  8s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 50s

the patch passed

+1 :green_heart:
compile
9m 44s

the patch passed

+1 :green_heart:
javac
9m 44s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
11m 57s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 47s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

50m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6519

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 9d741cb14928 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b2059ceae9e79feaa858a72fd9e429391884477

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
188 (vs. ulimit of 30000)

modules
C: hbase-assembly hbase-generate-dev-classpath . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/2/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

I have checked the external and internal classpaths, and determined that duplicating the opentelemtry JARs is not needed.
The shaded classpaths don't care, and the internal classpath had duplicated copies.

So I removed the duplication.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s

master passed

+1 :green_heart:
compile
1m 54s

master passed

+1 :green_heart:
javadoc
2m  7s

master passed

+1 :green_heart:
shadedjars
4m 52s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s

the patch passed

+1 :green_heart:
compile
1m 54s

the patch passed

+1 :green_heart:
javac
1m 54s

the patch passed

+1 :green_heart:
javadoc
2m 16s

the patch passed

+1 :green_heart:
shadedjars
4m 49s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
238m 19s
/patch-unit-root.txt
root in the patch failed.

269m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6519

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c0cbe1ab1b32 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b2059ceae9e79feaa858a72fd9e429391884477

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/2/testReport/

Max. process+thread count
5433 (vs. ulimit of 30000)

modules
C: hbase-assembly hbase-generate-dev-classpath . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 20s

master passed

+1 :green_heart:
compile
8m 46s

master passed

+1 :green_heart:
spotless
0m 47s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s

the patch passed

+1 :green_heart:
compile
8m 50s

the patch passed

+1 :green_heart:
javac
8m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
11m 59s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 46s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

46m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6519

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux dc47287923b1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c064868f58f6ed67cbe515dd6de6d007368495ca

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
190 (vs. ulimit of 30000)

modules
C: hbase-assembly hbase-generate-dev-classpath . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s

the patch passed

+1 :green_heart:
compile
1m 50s

the patch passed

+1 :green_heart:
javac
1m 50s

the patch passed

+1 :green_heart:
javadoc
2m 17s

the patch passed

+1 :green_heart:
shadedjars
4m 48s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
269m 27s
/patch-unit-root.txt
root in the patch failed.

300m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6519

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux be1f5ad67de6 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c064868f58f6ed67cbe515dd6de6d007368495ca

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/3/testReport/

Max. process+thread count
8762 (vs. ulimit of 30000)

modules
C: hbase-assembly hbase-generate-dev-classpath . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Let's have a try first.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s

master passed

+1 :green_heart:
compile
10m 12s

master passed

+1 :green_heart:
spotless
0m 54s

branch has no errors when running spotless:check.

-0 :warning:
patch
1m  9s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s

the patch passed

+1 :green_heart:
compile
9m 33s

the patch passed

+1 :green_heart:
javac
9m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
13m 19s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 54s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

52m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6519

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux a29ca77ca737 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94734e7fd78691fba3eda694755ae4d3d8955377

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
188 (vs. ulimit of 30000)

modules
C: hbase-assembly hbase-dev-generate-classpath . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6519/4/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Fix #480 by adding nullable type casting if required during code fix

Fix #480 by adding nullable type casting to ternary operator code fix provider.

Closed in favor of #487.


docs: new_work & new_thread string argument

new_thread already had this documented, although the argument type was missing or string, it also implied that only bytecode is accepted which seems to be inaccurate, as Lua code is accepted too  (internally it just load).
The same applies to new_work.

Thanks!


Make the schedule incident accept an input to start looking N days after the input is entered

Right now, the SRE bot starts looking to schedule an incident 3 days after today but it will be nice if we could create a an input variable to start looking for N days after today.

This has been done and committed to main.


feat: repository cloner

Describe your changes
This PR implements support for the CodeRepository management.
The added functionalities:

Cloner helper program that supports both username/password and ssh key based authentication
Creation of init containers to clone the repositories.

The current implementation creates one init container per CodeRepository entry.
Known limitations:

While the cloner helper supports ssh remotes, it will fail when run in a container as the remote will not be part of the known hosts. One solution would be to provide the known_hosts file through a ConfigMap mounted in the init containers. This would allow users to add private registries in a secure fashion.
When restarting the pod, clone will fail as the target already exists.

For that last point two possible things can be done:

Test if the folder exists and if so don't clone and call it a success
Add an annotation to the pod that can be checked and not re-create the clone containers.

Tests are currently a skeleton and must be improved.
Issue ticket number and link
Fixes: #612
Part of https://github.com/SwissDataScienceCenter/renku/issues/3679

One more thing... We can actually clone a repository by using the git config. You just have to use the lower level function from go-git. See here for example: https://gist.github.com/olevski/606c6168b6072cabadaca09e89744414

Thanks @sgaist, this looks really good.
A few things:
* Please check if cloning with username and password saves the credentials in the repository's git configuration in plain text.  If the credentials are stored you can modify the repo's git config with functions from the `go-git` package.

From tests, the auth information are not stored in the cloned repository.

* I think we should rename `AuthConfig` to `Config` or `CloneConfig` because I think we will need to add more stuff there in the future. For example we may want to support cloning via a proxy.

Good point and done

* Can you please check if the `PlainClone` function actually respects/loads the global/user git configs at all. My impression is that it does not. I looked through the code for it and it seems like there are no calls to load the user or global git configs. It just loads the config inside the repository after the repository is initialized. If the global/user configs are not loaded at all then we should change the CRD spec and simply not ask for the git config to be used when cloning.

You are correct. There's a long talk about it here: https://github.com/src-d/go-git/issues/760


add random voice channel name frequency config

Closes #115
Removes the guild level config for enabling and adds the ability to set the frequency of the random voice channel name cron jobs

Merging as Ty has already approved the changes but I had to update the branch with the latest from main


publicApiUrl does not work, while PREFECT_ORION_UI_API_URL works

I found is that if I use publicApiUrl based on https://github.com/PrefectHQ/prefect-helm/blob/5c56dea3558789f8fcc56cee80c18c0efffaf3a6/charts/prefect-orion/values.yaml#L35-L36
it won't work:
orion:
  publicApiUrl: http://localhost:4200/api
  env:
    - name: PREFECT_API_URL
      value: http://prefect-orion.hm-prefect.svc:4200/api
postgresql:
  auth:
    # username: prefect
    password: passw0rd

It will give me the error

Can't connect to Orion API at http://prefect-orion.hm-prefect.svc:4200/api. Check that it's accessible from your machine.

When I open http://localhost:4200

Using PREFECT_ORION_UI_API_URL works
orion:
  env:
    - name: PREFECT_API_URL
      value: http://prefect-orion.hm-prefect.svc:4200/api
    - name: PREFECT_ORION_UI_API_URL
      value: http://localhost:4200/api

postgresql:
  auth:
    password: passw0rd

hi @Hongbo-Miao - this was recently added (this week) and hasn't been included in a release yet. We will be publishing a release today!

Thanks @jamiezieziula !
What about PREFECT_API_URL? Is there something like publicApiUrl for PREFECT_ORION_UI_API_URL?


Errors

This PR adds a special error type that is used to allow for chains to break, but not throw JavaScript errors. This way, you can write a client to handle what may be found in an object, yet not worry if that particular chain is not there.
Edit: this becomes useful when a chain fails on filters and maps.
foo = obj.get('bar').filter((el) -> el.has('baz')).map((el) -> el.toValue())

If foo above doesn't have bar, the error gets passed all the way through. This means there are no JavaScript errors thrown, but rather a minim ErrorType object that is returned on the first get('bar').

@fosrias This is kind of cool. We should chat about it soon. Code can be cleaned up quite a bit, but left it pretty raw for now.

Here is what the Ion code looks like now:
https://gist.github.com/smizell/d90cf721f506f82e7d93

@fosrias See last commit. It throws/catches error when error type is initialized. Looks like it gives a full stack trace as well. Cool idea :)

@fosrias Voting to close this for now per my thoughts here: #22.

Not usable anymore.


Disable default headers set by nginx-proxy-manager

Is your feature request related to a problem? Please describe.
I have a case where the proxied application stops working if the default Host header (proxy_set_header Host $host) is set. This is done automatically by nginx-proxy-manager.
Describe the solution you'd like
Add a checkbox (unchecked by default) to create a "raw" proxy where only the proxy_pass directive is set in the configuration file.
Describe alternatives you've considered
No alternatives I can think of.

Seems like a good solution. Could you make create a PR with these changes?

Here it is #1844

I'm facing the same issue when adding Authelia in the custom locations instead of advanced tab.
Due to 1 or more proxy_set_header which is added as default causes the login to not work.
Is there news on when this PR will be released?

+1

I have the same issue for some testing purposes, sadly the PR got deleted / closed :-(

This issue still persists… The configuration added in the advanced_config section is being added before the defaults.


Move to winapi 0.3

With the new 0.3 branch of winapi, compile times are much smaller because it only builds the bindings for the portions of winapi actually used in a build. Since this crate uses only a few functions all from the same module, it would be a great benefit to move to the 0.3 series of winapi.

Nice!  Updating from 0.2 to 0.3 reduced the build times from about 25 seconds to 5 seconds!     I've just published terminal-size version v0.1.8 that depends on winapi 0.3


Updating from 3.2.1 to 3.3.0 breaks RegisteredForRemoteNotifications()

Im using xamarin.forms and when i upgraded the Microsoft.Azure.NotificationHubs from 3.2.1 to 3.3 the RegisteredForRemoteNotifications(UIApplication application, NSData deviceToken) stopped being called.

Hi @IeuanWalker, this repo is for the native iOS SDK, but if you provide more detail on your scenario I might be able to transfer this to the proper repo.
Are you using the Microsoft.Azure.NotificationHubs nuget package in your Xamarin.Forms app?

@brannon hi, sorry I couldn't fine a specific xamarin.forms repo. Ye i'm using Microsoft.Azure.NotificationHubs for XF

@IeuanWalker thanks for confirming. Microsoft.Azure.NotificationHubs is really meant to be used server-side. Since it targets .NET Core, it can be used in client scenarios too - but only for managing the device registration (or installation). The SDK isn't involved in receiving notifications.
If updating to the a new version of the SDK caused you to stop receiving notifications, then it may be that the device is not being registered correctly.
I'm going to move this issue to the repo for Microsoft.Azure.NotificationHubs, though as I said the SDK isn't involved with receiving notifications.


React sample doesn't work

Hi,
I followed your instructions.
I installed dependencies: npm install       -> it's OK
npm run build :
PS E:\Develop\Photoshop\UXP\uxp-photoshop-plugin-samples\ui-react-starter> npm run build

<EMAIL_ADDRESS>build E:\Develop\Photoshop\UXP\uxp-photoshop-plugin-samples\ui-react-starter
webpack --mode development

[webpack-cli] Failed to load 'E:\Develop\Photoshop\UXP\uxp-photoshop-plugin-samples\ui-react-starter\webpack.config.js' config
[webpack-cli] Invalid options object. Copy Plugin has been initialized using an options object that does not match the API schema.

options[0] should be an object:
object { patterns, options? }
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: webpack --mode development
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\kaci\AppData\Roaming\npm-cache_logs\2021-06-21T15_19_11_850Z-debug.log
PS E:\Develop\Photoshop\UXP\uxp-photoshop-plugin-samples\ui-react-starter>
node --version
v14.17.1
npm --version
6.14.13
OS: Windows 10
IDE: VS Code: 1.57.1
Thx
kaci

Hello! :wave:
Have you modified the webpack.config.js file at all? I believe this issue stems from the copy-webpack-plugin, more specifically the options passed to it... although the options in the sample's configuration look okay.
If you haven't modified that file at all, you could try to remove the copyUnmodifed option (still worked fine in my dev environment).
plugins: [
    //new CleanWebpackPlugin(),
    new CopyPlugin(['plugin'], {})
]

Mind you, this may result in some issues while running the webpack dev server if you try to develop off of this locally.

Hi Jake,
Thank you for your quick  answer.
No, I didn't  modified webpack.config.js.
I tried your variation with same error.
I have same error with ui-vue-starter also.
Thx
kaci

The problem was caused by the wrong webpack version
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
Solution: I installed manually the right webpack version:
npm install --save-dev<EMAIL_ADDRESS>/kaci

The problem was caused by the wrong webpack version
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
Solution: I installed manually the right webpack version:
npm install --save-dev<EMAIL_ADDRESS>/kaci


Update device-installation-files.md

Simple changes in indentation to make it more clear the separate entities that are within the package.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: justinmcbride sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Add search feature in properties view

Currently it can get difficult to search for a property in properties view. Adding a search feature will be helpful here.

This feature is not present in insiders.

Is this what you are referring to? Just confirming @aasimkhan30 @erinstellato-ms

@tdoshin Not sure of the reference here?


Menu not modified on already selected selection click

Describe the bug
When there is a select with isSetFunc provided and the user presses the already selected button nothing should change as the selection did not change. Currently the menu is recreated and an 'nothing changed' hint is shown in the console.
Expected behavior
isSetFunc is called. When the key is already set just send an empty answerCbQuery.

Problem with this is: when the key is already set (isSetFunc returns true) the menu could be old. Then the old menu is not updated and the user does not understand why his click did not work.
setMenu should check if the text and buttons are changing. Only if different edit the menu. This is not that easy as the ctx.update contains the message.text without formatting and the user supplies text with formatting (currently always markdown).


Minimum SDK required for Material Design?

I integrated this library into a demo app and tried to build for Android 4.4 which is the minimum for React Native.. however I dont believe its the minimum for Material Design?
Is this true?  Im getting build errors if I target anything less than 5.1  And even then it crashes on startup on Android 5.1.1.  My package only loads on my simulator with Android 6.0.   I don't have a device to test with..   Just wondering if anyone else can confirm.
thanks

This lib is mostly written in JS, so it's not requiring Android L.
The demo is working great on Genymotion Android 4.x emulator

I tried to run an app that uses react-native-material-kit on a Moto G 4.4.4 (kit kat) but if fails with:
 Error while updating property `nativeBackgroundAndroid` of a view managed by: RCTView

So I guess KitKat isn't supported.

It should work, which version of ReactNative are you using?
On Thu, May 12, 2016, 6:43 AM Ivan Savov<EMAIL_ADDRESS>wrote:

I tried to run an app that uses react-native-material-kit on a Moto G
4.4.4 (kit kat) but if fails with:
Error while updating property nativeBackgroundAndroid of a view managed by: RCTView
So I guess KitKat isn't supported.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/xinthink/react-native-material-kit/issues/110#issuecomment-218612217

react-native -v says
react-native-cli: 0.2.0
react-native: 0.20.0

(note very new to react native, it's entirely possible i'm messing something up)

For reference, this is the app I was trying to build: https://github.com/InfiniteLibrary/infinite-reader
It uses "react-native": "^0.19.0" internally.   Also uses react-native-material-kit ^0.2.5, but I also tried the latest version too.

Also, my bundle process might be at fault. This is what I ran:
react-native bundle --platform android \
            --dev false --entry-file index.android.js \
            --bundle-output android/app/src/main/assets/index.android.bundle \
            --assets-dest android/app/src/main/res/
./gradlew assembleRelease
./gradlew installRelease

Does this look right?


Publish package to support brew install tsui on macOS

Title kinda says it all.

This isn't a high priority for me because the curl installer is fully functional on macOS and it would be some amount of burden to get the builds and releases playing nicely. I definitely get it because I used to be a Homebrew fangirl myself.
I'll leave this open in case I ever have some free time and feel like getting the parts to play together. Y'all are also welcome to take a stab.


GitHub Issues details per area

GitHub Issues details per area
Doughnut charts for labels with area prefix, Open / Closed state, for both Bugs and Enhancements
Screenshot:

Deployed!

Thanks, I played for some time with even more detailed view where I had history of issues created per month and per component, basically Activity Per Month from https://status.quarkus.io/bugs/ with dataset for every area/ ++ some checkbox/JS logic to customize shown datasets.
But this approach was too much, mainly because of the fact that we have ~100 labels with area prefix

It's not easy to nicely visualize such huge dataset
Chart rendering with my wasnt't reliable when I was hiding some datasets (or making visible), especially when I clicked too many checkboxes in short time
Fetching all the data per area and per month took quite some time even if I did some bulk graphql queries

So I'm quite happy with doughnut chart for current state, I may come back to per month idea again, but for now it's on ice :)


Adding min. retry time per region for 404/1002 SessionTokenRetryPolicy when RegionSwitchHint is Remote

Description
Currently with RegionSwitchHint.Remote there is the risk, that after some temporary requests to another region, with Session consistency future requests to the local region will fail with 404/1002 and result in cross-regional call (which would succeed and update the local session token again) for a long time. This PR adds a min. time spent in trying to see whether the local time can meet session consistency for write operations before attempting to call the remote region. This will add some time the local region can use to catch-up on replication lag.
The bare min. for the min. in-region wait is 100ms.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-cosmos

/azp run java - cosmos - spark

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - spark

/azp run java - cosmos - tests

/azp run java - cosmos - spark


Clicking the Stream/Topic entry box should not highlight existing text

When composing a message, the compose interface provides entry boxes for entering the stream and topic to send that message to. However, when clicking on existing text in these inputs, the whole text is selected, and any kepresses will replace the entire contents of the boxes.
This is contrary to the traditional behaviour of input boxes (which insert the cursor at the clicked location), and also interferes with the common use case of correcting typos or spelling mistakes.
This feature should either be removed, or made configurable with an option in the settings.

A few years ago, by far the dominant use case for this box was to replace the topic wholesale, which is why we designed the selection behavior we have today.
The issue @RossBrunton brought up doesn't arise with the keyboard, because after you shift+tab to get there, you need to cursor to the point to edit anyway.
So this is ultimately a question about user behavior -- is it more common for users to click into that box with intent to just change a character or two, or to type something entirely new.  The current thing is suboptimal for one intent; switching it is suboptimal for the other.
My guess is that this is one of those things where we're probably making the right choice among two options, and we'd get 5x the complaints if we switched the behavior and so we should leave it as-is.

Closing this since the current behavior is the right one in most cases and to place the cursor before or after the selected text you can just press the left or right arrow key, so this doesn't warrant a new settings option.


Schema.org transform issues

semicolon in id?
http://cinergi.sdsc.edu/geoportal/rest/metadata/item/22941afcd4b148cab135d2a92f5fe198/html
double quote in descriptions:
https://search.google.com/structured-data/testing-tool/u/0/#url=http%3A%2F%2Fcinergi.sdsc.edu%2Fgeoportal%2Frest%2Fmetadata%2Fitem%2Fbbbb14211d634329835cb8e208cbd355%2Fhtml

Did we solve this?

Looks like not.  22941afcd4b148cab135d2a92f5fe198 is a pretty worthless record, almost all default values, and the distribution link is a local SQL connection string.
I'll update the xslt.

I fixed the problems and pushed a new version of ISO19139ToSchemaOrgDataset1.0.xslt  with commit 3c9e4a4b9a7cd5070dbb397879da6780bd9252ef on the  cinergi26newISOeval branch.


mpld3.show() fails in Python 3.4

Error is the same as seen here: http://stackoverflow.com/questions/11781639/typeerror-str-does-not-support-buffer-interface
The solution is to encode the string in Python 3.
This was not caught by unit tests, because I'm not sure how to unit test the launch of an HTTP server.

Are we sure this is fixed?  I just tried using mpld3 for the first time using the example in Quick Start:
import matplotlib.pyplot as plt, mpld3
plt.plot([3,1,4,1,5], 'ks-', mec='w', mew=5, ms=20)
mpld3.show()

and I get this error:
Python 3.4.3 (v3.4.3:9b73f1c3e601, Feb 24 2015, 22:44:40) [MSC v.1600 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> runfile('C:/Users/Michael/Dropbox/INBOX/mpld3 test.py', wdir='C:/Users/Michael/Dropbox/INBOX')
Serving to http://<IP_ADDRESS>:8889/    [Ctrl-C to exit]
----------------------------------------
Exception happened during processing of request from ('<IP_ADDRESS>', 61380)
----------------------------------------
<IP_ADDRESS> - - [28/Jun/2015 15:56:18] "GET / HTTP/1.1" 200 -
Traceback (most recent call last):
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\socketserver.py", line 305, in _handle_request_noblock
    self.process_request(request, client_address)
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\socketserver.py", line 331, in process_request
    self.finish_request(request, client_address)
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\socketserver.py", line 344, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\socketserver.py", line 673, in __init__
    self.handle()
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\http\server.py", line 398, in handle
    self.handle_one_request()
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\http\server.py", line 386, in handle_one_request
    method()
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\site-packages\mpld3\_server.py", line 38, in do_GET
    self.wfile.write("<html><head>"
  File "C:\WinPython\WinPython-64bit-<IP_ADDRESS>\python-3.4.3.amd64\lib\socket.py", line 394, in write
    return self._sock.send(b)
TypeError: 'str' does not support the buffer interface

Using the usual matplotlib backend works fine:
import matplotlib.pyplot as plt, mpld3
plt.plot([3,1,4,1,5], 'ks-', mec='w', mew=5, ms=20)
plt.show()

Did you install mpld3 from master? This fix isn't in a release yet (sorry)

No I installed using pip install mpld3 as instructed in the install guide.  As you suggest I'll install from master for now.
Thanks for your great work on this project, I look forward to using it in my project.

We should absolutely create a new release.


Edit field bug (xdid -i) - strcpyn() failed

Considering this code:
xdialog -c xcomms 1 edit 5 43 $calc(%xcomms.h * 2 - 4) $calc(%xcomms.v * 2 - 16) autohs autovs multi readonly
xdid -f xcomms 1 +b default 10 Calibri
xdid -C xcomms 1 +t $rgb(250,249,237)
xdid -C xcomms 1 +bk $rgb(55,55,55)
xdid -x xcomms 1 +

alias xcomm.youtube {
  xdid -i xcomms 1 1 -------------------------------------------
  xdid -i xcomms 1 2 $lang(2124) /youtube [on|off|-d|help] [<link>] [+o]
  xdid -i xcomms 1 3 -------------------
  xdid -i xcomms 1 4 on -> $lang(2125)
  xdid -i xcomms 1 5 off -> $lang(2126)
  xdid -i xcomms 1 6 -d -> $lang(2127)
  xdid -i xcomms 1 7 +o -> $lang(2128)
  xdid -i xcomms 1 8 help -> $lang(770)
  xdid -i xcomms 1 9 $lang(787) -> $lang(2129)
  xdid -i xcomms 1 10 $lang(787) -> $lang(2130)
  xdid -i xcomms 1 11 $lang(787) -> $lang(2131)
  xdid -i xcomms 1 12 $lang(787) -> $lang(2132)
  xdid -i xcomms 1 13 -------------------------------------------
}

returns error:
D_ERROR /xdid ("xcomms 1 -i 11 Notă: -> Comanda /youtube va funcționa indiferent dacă Youtube Catcher e activ sau nu. Youtube Catcher răspunde doar de afișarea conținutului link-urilor din mesajele proprii sau a altora." error: strcpyn() failed!)
/xdid -[switch] [dialog] [ID] [options]
[switch] = depends on control type
[dialog] = the dialog containing the control
[ID] = the ID of the control
[options] = depends on the control type & switch used

After that, i tried to open again and no errors returns and when i tried to open again and again, sometimes this strcpyn() error returns with different value of id: 11, 7 etc.
Although, the dialog is displayed with all data in it perfectly, except the inserted error lines.

This is part of the debug code used to find unusual copies, i forgot to comment it out for release builds.
fixed.


add $share_work_dir flag for mounting cwd in coreos

This is to remove the need to touch the Vagrantfile, confining user changes to config.rb instead.

If this gets accepted, will also make a pull for the documentation changes on:
https://github.com/coreos/docs/blob/master/running-coreos/platforms/vagrant/index.md

@noodlehaus Can't this be done with $synced_folder now?

hi @bcwaldon. yes, realized this about an hour after this pull :D sorry forgot to close this. thanks!


Issue with Google Meet

System Details

OS: Windows 11 x64 22621.2715
Thorium Version: 117.0.5938.157 (Official Build) (64-bit)
CPU: Ryzen 7900X
GPU: nvidia RTX 4090

Problem
I switched to Thorium recently, and have never encountered this problem before. Not sure why this is happening, maybe due to hardware acceleration, I haven't had the chance to test this? The screenshot pretty much sum up the problem.
Screenshots

Additional Notes
I noticed these behaviors as well:

My camera always looks fine. Others, not so much
If there is just one other camera active, that is also fine.
Everyones cameras look fine when someone is doing a screenshare, and all of the attendees cameras are moved to the side. the screenshare itself also has no problems

I have the exact same issue. I have a RTX 2080 Super.

@x0rsw1tch @BSoD38 Can y'all try the new M119 version and see if it fixes your issues?

@Alex313031 Still happens on M119, although I am using the AVX build.
Tested it on i7 13700K + RTX 4080 if that helps.

@Alex313031  Still happening for me as well, AVX2 build: Ryzen 7900X + RTX 4090

Just confirming that I am having this issue as well.

A few screens look okay.
Once we share our screen and put something up, it seems to fix the issues for the most part.

Same issue.
Someone shared their screen and the weird artifacts stopped, but the videos seem very grainy and a little blurry. Hard to see with the censorship here. You can see it around their faces.


Possibility to localize the config.schem.json

As a plugin developer I would like to localize the config.schema.json such that my users can easily configure my plugin in their language.
I.e. plugins should be able to localize their config.schema.json UI. For many plugins this is the only end-user-facing-ui at all so it would be nice to be able to localize it based on the Homebridge-ui language.

Any Feedback from the Team on my proposal?


get cargo-quickinstall included in https://github.com/actions-rs/cargo or something?

https://github.com/marketplace/actions/rust-cargo-install feels like it does what we want, but feels deprecated. Maybe dig into why that is?
It may be that we can write a patch to cargo-bincode to install binaries from our github-releases?

I have added cargo-binstall to https://github.com/taiki-e/install-action , which installs popular crates for rust CI from binary (including non-rust one).
Though it is not the official one, there are people using it.

I have added cargo-binstall to https://github.com/taiki-e/install-action , which installs popular crates for rust CI from binary (including non-rust one).
Though it is not the official one, there are people using it.

As long as it's an action that can install from the quickinstall repo, that's good enough for me. Just need to mention it in the readme and then we can close this issue.


Komorebi Support not working: Failed to subscribe komorebi to named pipe: error: Found argument 'subscribe' which wasn't expected, or isn't valid in this context

Hey! Love the project, Everything seems super cool, but I am not able to get komorebi support working out of the box.  The error that led to the problem was:
Failed to subscribe komorebi to named pipe: error: Found argument 'subscribe' which wasn't expected, or isn't valid in this context
my komorebi folder is in the PATH so I normally just run komorebic start from powershell
specs.txt
yasb.log

@rwendell Which version of Komorebi are you running? Right now integrations on Komorebi's side require you to be running a build from the master branch, so if you have 0.1.6 installed via scoop for example, it won't work.
I'm trying to get through a few more issues before releasing 0.1.7, hopefully before the end of this month, which will no longer require people to be running builds from master to have Komorebi play nicely with yasb. 🤞

I am using 0.1.6 currently, the latest release version. So just to make sure, if I built from source I should be good to go?

Yes, you can also download the prebuilt binaries from the Github Actions job for the latest commit if you don't want to compile from source yourself. 🚀

Thanks for the tip! Marking as closed

I just have added some additional information regarding komorebi requirements for the workspace plugin within the README.
Commit: a6a51d37deb85e59a8bdebc2dcaa732a1169db01
Thanks for highlighting that this information probably should have been included to begin with!


[Feature request] Warn user when Input/output does not exist in component and type checking

Hi!
I have this component :
 @Component({
  selector: 'example-component',
  templateUrl: 'example-component.component.html',
  styleUrls: ['example-component.component.scss']
})
export class ExampleComponent {

  @Input() label: string;
 @Output() event: string;
}

If I wrote this in another template like this :
<example-component (label)="1" (noExistingInput)="'label'" [event]="exampleMethod()">
<example-component>

I have no warning on the noExistingInput, and no warning on label input waiting for a string and receiving a number.
Can you provide this?

Hey @Tukks this is a compile-time error which makes the feature outside the scope of codelyzer. To get this behavior use the Angular language service.

Ok, sorry I opened a issue at angular/angular#21204


Move contexts checks async

Description

Luckperms contexts are checked in the main thread, making the performance poor when used a lot by plugins
Proposed behaviour

Probably make it async? :/

Do you have any profiling data to back this up?

After asking to one of DiscordSRV dev:
HaeivenAujourd’hui à 19:35
mh... i don't rly understand why the mysql request isn't done in async?
VankkaAujourd’hui à 19:36
because luckperms is calculating contexts for the user on the main thread
And this is not the only one plugin to have this problem, as I see :/

Ah I see - well, ideally DiscordSRV should be caching this value, so the MySQL lookup isn't necessary.
I feel partially responsible, since I initially PRed contexts into DiscordSRV - however, I don't think the MySQL storage was there at the time.. I think that might've been added since.
Anyway, unfortunately there's not much LP can do about this - contexts have to be calculated whenever permissions are checked, which of course is going to happen sometimes on the main thread.
If you're not using DiscordSRV contexts, then it is probably easiest to just disable the integration in DiscordSRVs config. Otherwise, it's something that is going to need to be fixed at DSRVs end.

And this is not the only one plugin to have this problem, as I see :/

I'm not aware of any others?

In all fairness, the very first thing that the ContextCalculator interface "specification" mentions is that they ought to be fast and should resolve time-consuming queries and cache their results beforehand:
https://github.com/lucko/LuckPerms/blob/8167fbf73f99debb0cd8c1a46412a0176afb88af/api/src/main/java/net/luckperms/api/context/ContextCalculator.java#L33-L43

Ah I see - well, ideally DiscordSRV should be caching this value, so the MySQL lookup isn't necessary.

While this would solve the problem, it causes another; another server might change the data in the database, which would lead to the cache being out of date, and adding redis/plugin message for this would be quite the hurdle (this is just one value that's in the database)

however, I don't think the MySQL storage was there at the time.. I think that might've been added since.

It was however, it extends a regular class, making it hard to find

In all fairness, the very first thing that the ContextCalculator interface "specification" mentions is that they ought to be fast and should resolve time-consuming queries and cache their results beforehand

Please see Luck's statement;

I feel partially responsible, since I initially PRed contexts into DiscordSRV - however, I don't think the MySQL storage was there at the time.. I think that might've been added since.

I already did some experimenting with caching the values for a while while players are online, but seems like that wasn't enough - I'll see what I can do on DiscordSRV's side to mitigate this
Also, Merry Christmas :)

Thanks Vankka 👍
Going to close this issue since there's nothing to be done in LP.


⚠ GTru has degraded performance

In fce7d07, GTru ($GTRU) experienced degraded performance:

HTTP code: 521
Response time: 11510 ms

Resolved: GTru performance has improved in 368c6b5 after 1 hour, 34 minutes.


VideoStreamPlayer stops and cracking sound

Tested versions
v4.2.1.stable.official [b09f793f5]
System information
Godot v4.2.1.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; <IP_ADDRESS>52) - 13th Gen Intel(R) Core(TM) i5-13400F (16 Threads)
Issue description
When playing the video in Godot, it just pauses briefly at one point and otherwise you can hear audio crackling throughout the entire video. Am I doing something wrong or is this a bug in the engine? Outside the engine, the video works fine.
https://github.com/godotengine/godot/assets/94065666/e02d1e18-6584-4603-828b-fbfeca1bf324
Steps to reproduce

Add a VideoStreamPlayer
Put the video in the stream property

Minimal reproduction project (MRP)
video_bug.zip

FFmpeg information on the video:
❯ ffprobe cutscene1.ogv
Input #0, ogg, from 'cutscene1.ogv':
Duration: 00:00:50.90, start: 0.000000, bitrate: 1848 kb/s
Stream #0:0(und): Video: theora, yuv420p, 1920x1080 [SAR 1:1 DAR 16:9], 24 fps, 24 tbr, 24 tbn
Metadata:
creation_time   : 2024-01-12T17:44:15.000000Z
handler_name    : VideoHandler
vendor_id       : [0][0][0][0]
timecode        : 01:00:00:00
encoder         : Lavc60.35.100 libtheora
major_brand     : isom
minor_version   : 512
compatible_brands: isomiso2avc1mp41
Stream #0:1(und): Audio: vorbis, 44100 Hz, stereo, fltp, 320 kb/s
Metadata:
creation_time   : 2024-01-12T17:44:15.000000Z
handler_name    : SoundHandler
vendor_id       : [0][0][0][0]
encoder         : Lavc60.35.100 libvorbis
major_brand     : isom
minor_version   : 512

Probably related to #21568 and #66331

I just encountered this bug. the fix from @DeeJayLSP to add -g:v 1 worked. It didn't increase file size at all really for me, since my video is very small.

Consolidating in #66331 which is about the same underlying bug.


Wide of 2 tuple of size 2 doesn't fail silently anymore

can we have a test please

Turns out the issue is not EVE. We're gonna fix the other software


Meeting notes for 6/21

Thanks @jeremywight for the pizza
@bikeoid any updates on the API updates?
Now summer is here, it's a good time to remind folks that the app is here and ready to use. Please share with your social groups, Facebook groups etc. We're at 2,500 total downloads. Let's get see if we can't up this.
@rhynodesigns is planning to stop by some more bars and hotels this week. See: https://github.com/codeforgreenville/trolley-tracker/issues/145 for his initial conversation with hotel folks. He's trying to figure out the best way to communicate the value of the trolley tracker to these hotels. Any ideas welcome.
@agautsc is going reach event coordinators to market app to their customers. https://github.com/codeforgreenville/trolley-tracker/issues/148
Thanks @allella (OpenWorks) for the beer

After I hit submit and closed the laptop @allella suggested we reach out to Clemson to let folks know about the app.

Re: API updates; I've been tied up in a code sprint, I expect it to wind down by the 2nd week of July when I hope to address the API updates.


🐛 App Crashes When Navigating Back to Camera Screen

What's happening?
The app crashes when I navigate back from the camera screen and then attempt to return to the camera screen.
Steps to Reproduce:

Navigate to the camera screen within the app.
Interact with the camera screen as needed.
Use the app's navigation to go back to the previous screen.
Navigate back to the camera screen.

Error:
java.lang.IllegalArgumentException: Surface was abandoned

Reproduceable Code
function App() {

  const codeScanner = useCodeScanner({
    codeTypes: ['qr', 'ean-13'],
    onCodeScanned: console.log,
  });

  const device = useCameraDevice('back', {
    physicalDevices: ['wide-angle-camera'],
  });

  if (device == null) return null;
  return (
    <Camera
      style={StyleSheet.absoluteFill}
      device={device}
      isActive={true}
      enableZoomGesture
        focusable
      codeScanner={codeScanner}
    />
  )
}

Relevant log output
10-12 15:20:57.082  9477 10289 E AndroidRuntime: FATAL EXCEPTION: mrousavy/VisionCamera.main
10-12 15:20:57.082  9477 10289 E AndroidRuntime: Process: com.dt.johnny.jdtmelhu, PID: 9477
10-12 15:20:57.082  9477 10289 E AndroidRuntime: java.lang.IllegalArgumentException: Surface was abandoned
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.hardware.camera2.utils.SurfaceUtils.getSurfaceSize(SurfaceUtils.java:135)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.hardware.camera2.params.OutputConfiguration.<init>(OutputConfiguration.java:563)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.hardware.camera2.params.OutputConfiguration.<init>(OutputConfiguration.java:345)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at com.mrousavy.camera.core.outputs.SurfaceOutput.toOutputConfiguration(SurfaceOutput.kt:38)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at com.mrousavy.camera.extensions.CameraDevice_createCaptureSessionKt.createCaptureSession(CameraDevice+createCaptureSession.kt:57)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at com.mrousavy.camera.core.CameraSession.getCaptureSession(CameraSession.kt:438)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at com.mrousavy.camera.core.CameraSession.startRunning(CameraSession.kt:532)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at com.mrousavy.camera.core.CameraSession.access$startRunning(CameraSession.kt:49)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at com.mrousavy.camera.core.CameraSession$startRunning$1.invokeSuspend(Unknown Source:14)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:958)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:205)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:294)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	at android.os.HandlerThread.run(HandlerThread.java:67)
10-12 15:20:57.082  9477 10289 E AndroidRuntime: 	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@9a35690, mrousavy/VisionCamera.main]

Camera Device
{
  "sensorOrientation": "landscape-right",
  "hardwareLevel": "full",
  "maxZoom": 10,
  "minZoom": 1,
  "supportsLowLightBoost": false,
  "neutralZoom": 1,
  "physicalDevices": [
    "wide-angle-camera"
  ],
  "supportsFocus": true,
  "supportsRawCapture": true,
  "isMultiCam": false,
  "name": "BACK (0)",
  "hasFlash": true,
  "hasTorch": true,
  "position": "back",
  "id": "0"
}

Device
Any Android Devices
VisionCamera Version
3.3.1
Can you reproduce this issue in the VisionCamera Example app?
I didn't try (⚠ your issue might get ignored & closed if you don't try this)
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

The same issue on my side

Same
2023-10-12 15:18:03.235 12356-12805 BufferQueueProducer     com.xxx.app                 E  [ImageReader-4080x3072f21m3-12356-0](id:304400000004,api:0,p:-1,c:12356) connect: BufferQueue has been abandoned
2023-10-12 15:18:03.235  1242-8491  Camera3-OutputStream    cameraserver                         E  configureConsumerQueueLocked: Unable to connect to native window for stream 1
2023-10-12 15:18:03.235  1242-8491  Camera3-Stream          cameraserver                         E  finishConfiguration: Unable to configure stream 1 queue (non-fatal): No such device (-19)
2023-10-12 15:18:03.235  1242-8491  Camera3-Device          cameraserver                         E  Camera 0: configureStreamsLocked: Can't finish configuring output stream 1: No such device (-19)
2023-10-12 15:18:03.235  1242-8491  CameraDeviceClient      cameraserver                         E  endConfigure: Camera 0: Error configuring streams: Broken pipe (-32)
2023-10-12 15:18:03.237 12356-12805 CameraCaptureSession    com.xxx.app                 E  Session 0: Failed to create capture session; configuration failed

...

2023-10-12 15:18:03.536 12356-12805 AndroidRuntime          com.xxx.app                 E  FATAL EXCEPTION: mrousavy/VisionCamera.main
                                                                                Process: com.xxx.app, PID: 12356
                                                                                android.hardware.camera2.CameraAccessException: CAMERA_ERROR (3): endConfigure:656: Camera 0: Error configuring streams: Broken pipe (-32)
                                                                                at android.hardware.camera2.CameraManager.throwAsPublicException(CameraManager.java:1489)
                                                                                at android.hardware.camera2.impl.ICameraDeviceUserWrapper.endConfigure(ICameraDeviceUserWrapper.java:119)
                                                                                at android.hardware.camera2.impl.CameraDeviceImpl.configureStreamsChecked(CameraDeviceImpl.java:519)
                                                                                at android.hardware.camera2.impl.CameraDeviceImpl.createCaptureSessionInternal(CameraDeviceImpl.java:726)
                                                                                at android.hardware.camera2.impl.CameraDeviceImpl.createCaptureSession(CameraDeviceImpl.java:680)
                                                                                at com.mrousavy.camera.extensions.CameraDevice_createCaptureSessionKt.createCaptureSession(CameraDevice+createCaptureSession.kt:82)
                                                                                at com.mrousavy.camera.core.CameraSession.getCaptureSession(CameraSession.kt:438)
                                                                                at com.mrousavy.camera.core.CameraSession.startRunning(CameraSession.kt:532)
                                                                                at com.mrousavy.camera.core.CameraSession.access$startRunning(CameraSession.kt:49)
                                                                                at com.mrousavy.camera.core.CameraSession$startRunning$1.invokeSuspend(Unknown Source:14)
                                                                                at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
                                                                                at android.os.Handler.handleCallback(Handler.java:942)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                at android.os.Looper.loopOnce(Looper.java:201)
                                                                                at android.os.Looper.loop(Looper.java:288)
                                                                                at android.os.HandlerThread.run(HandlerThread.java:67)
                                                                                Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@87284c4, mrousavy/VisionCamera.main]
                                                                                Caused by: android.os.ServiceSpecificException: endConfigure:656: Camera 0: Error configuring streams: Broken pipe (-32) (code 10)
                                                                                at android.os.Parcel.createExceptionOrNull(Parcel.java:3025)
                                                                                at android.os.Parcel.createException(Parcel.java:2995)
                                                                                at android.os.Parcel.readException(Parcel.java:2978)
                                                                                at android.os.Parcel.readException(Parcel.java:2920)
                                                                                at android.hardware.camera2.ICameraDeviceUser$Stub$Proxy.endConfigure(ICameraDeviceUser.java:705)
                                                                                at android.hardware.camera2.impl.ICameraDeviceUserWrapper.endConfigure(ICameraDeviceUserWrapper.java:116)
                                                                                ... 15 more

The same issue

I had some similar issues and found using navigation.replace instead of navigation.navigate worked for me.

I added isFocused to my camera implementation because it was crashing everytime i go back from another screen
{ device != null && isFocused ? (...
Also I changed isActive={true} to use isActive={isActive} where isActive=
 // check if camera page is active
  const isFocussed = useIsFocused() // Implementation from '@react-navigation/core'
  const isForeground = useIsForeground() // Hook you can find on the Example app inside the package
  const isActive = isFocussed && isForeground

I think this will get fixed with this: https://github.com/mrousavy/react-native-vision-camera/pull/1996

Yea basically I need to do a refactor on the Codebase - I now know exactly what I need for the session configuration, and need to do all of this fully atomically.

我认为这将通过以下方式解决：#1996

thinks

https://github.com/mrousavy/react-native-vision-camera/assets/50100966/79b7cc8b-5a9c-4467-97d9-55a301eb81dd
Click the back button to see the following situation
  const device = useCameraDevice('back');
  const camera = useRef<Camera>(null);
  const isFocused = useIsFocused();
  const navigation = useNavigation();
  const appState = useAppState();
  const [active, setActive] = useState(true);
  useEffect(() => {
    const unsubscribe = navigation.addListener('beforeRemove', () => {
      setTimeout(() => {
        setActive(false);
      }, 0);
    });
    return unsubscribe;
  }, [navigation]);

  const isActive = active && isFocused && appState === 'active';

  const takePhoto = async () => {
    const photo = await camera.current!.takePhoto();
    console.log(photo);
  };

  if (!device) {
    return (<View className="flex-1">
      <Text>请打开摄像头</Text>
    </View>);

  }

  if (!isActive) {
    return (<View className="flex-1">
      <Text>请打开摄像头</Text>
    </View>);
  }

  return <View className="h-full w-full items-center justify-end">
    {isActive && <Camera
      ref={camera}

      style={{ position: 'absolute', left: 0, right: 0, bottom: 0, top: 0 }}
      //https://github.com/mrousavy/react-native-vision-camera/issues/1988  不然会崩溃
      fps={60}

      device={device} //此相机设备包含的物理设备类型列表。
      // video={true} //录像功能打开关闭
      // supportsVideoHDR={true}
      isActive={isActive} //是否打开相机， 可以缓存相机，加快打开速度
      photo={true} //拍照功能是否打开
    />}
    <TouchableOpacity className=" w-16 h-16 rounded-full bg-slate-500 mt-[100%] mb-[20%]" onPress={takePhoto} />
  </View>;

@810505339 can you share your adb logcat logs

NOT FIXED FOR ME I HAVE "react-native-vision-camera": "^3.5.1", "react-native-worklets-core": "^0.2.2", "react-native-reanimated": "^3.5.4"
2023-10-19 15:37:23.543 10007-10386 BufferQueueProducer     com.adonaysoft.stepsV2               I  [ImageReader-4000x1800f100m3-10007-0](id:271700000004,api:4,p:1195,c:10007) disconnect: api 4
2023-10-19 15:37:23.546 10007-10386 BufferQueueProducer     com.adonaysoft.stepsV2               I  [ImageReader-1920x864f23m3-10007-1](id:271700000006,api:4,p:1195,c:10007) disconnect: api 4
2023-10-19 15:37:23.556 10007-10386 SurfaceOutput           com.adonaysoft.stepsV2               I  Closing 4000x1800 PHOTO ImageReader..
2023-10-19 15:37:23.556 10007-10386 BufferQueueConsumer     com.adonaysoft.stepsV2               I  [ImageReader-4000x1800f100m3-10007-0](id:271700000004,api:0,p:-1,c:10007) disconnect
2023-10-19 15:37:23.556 10007-10386 SurfaceOutput           com.adonaysoft.stepsV2               I  Closing 1920x864 Video Pipeline..
2023-10-19 15:37:23.556 10007-10386 BufferQueueProducer     com.adonaysoft.stepsV2               I  [SurfaceTexture-0-10007-1](id:271700000005,api:4,p:10007,c:10007) disconnect: api 4
2023-10-19 15:37:23.557 10007-10386 BufferQueueConsumer     com.adonaysoft.stepsV2               I  [ImageReader-1920x864f23m3-10007-1](id:271700000006,api:0,p:-1,c:10007) disconnect
2023-10-19 15:37:23.557 10007-10386 BufferQueueConsumer     com.adonaysoft.stepsV2               I  [SurfaceTexture-0-10007-1](id:271700000005,api:0,p:-1,c:10007) disconnect
2023-10-19 15:37:23.557 10007-10386 CameraSession           com.adonaysoft.stepsV2               I  Camera Session stopped!
2023-10-19 15:37:23.558 10007-10386 CameraSession           com.adonaysoft.stepsV2               I  Setting isActive: false (isRunning: false)
2023-10-19 15:37:23.558 10007-10386 CameraSession           com.adonaysoft.stepsV2               I  Camera became available: 0
2023-10-19 15:37:23.558 10007-10235 CameraDevices           com.adonaysoft.stepsV2               I  Camera #0: Available!
2023-10-19 15:37:23.587 10007-10232 BLASTBufferQueue        com.adonaysoft.stepsV2               I  releaseBufferCallbackThunk bufferId:42979737731137 framenumber:1253 blastBufferQueue is dead
2023-10-19 15:37:23.798 10007-10234 ReactNativeJS           com.adonaysoft.stepsV2               I  topAf: 458x639
2023-10-19 15:37:24.069 10007-10387 libc                    com.adonaysoft.stepsV2               A  Fatal signal 11 (SIGSEGV), code 2 (SEGV_ACCERR), fault addr 0x71b16f2000 in tid 10387 (ionCamera.video), pid 10007 (naysoft.stepsV2)

@810505339 can you share your adb logcat logs

10-20 01:49:08.428 E/WifiScoringParams(  553): Invalid frequency(-1), using 5G as default rssi array
10-20 01:49:08.543 E/Transition(  553): Trying to add a ready-group twice: Display{#0 state=ON size=1440x3120 ROTATION_0}
10-20 01:49:15.445 E/BufferQueueProducer( 5135): [SurfaceView[com.myapp/com.myapp.MainActivity]#3(BLAST Consumer)3](id:140f00000003,api:4,p:468,c:5135) queueBuffer: BufferQueue has been abandoned
10-20 01:49:15.446 E/Surface (  468): queueBuffer: error queuing buffer, -19
10-20 01:49:15.446 E/Camera3-OutputStream(  468): returnBufferCheckedLocked: Stream 0: Error queueing buffer to native window: No such device (-19)
10-20 01:49:15.446 E/BufferQueueProducer( 5135): [SurfaceView[com.myapp/com.myapp.MainActivity]#3(BLAST Consumer)3](id:140f00000003,api:4,p:468,c:5135) dequeueBuffer: BufferQueue has been abandoned
10-20 01:49:15.447 E/Camera3-OutputStream(  468): getBufferLockedCommon: Stream 0: Can't dequeue next output buffer: No such device (-19)
10-20 01:49:15.476 E/BufferQueueProducer( 5135): [SurfaceView[com.myapp/com.myapp.MainActivity]#3(BLAST Consumer)3](id:140f00000003,api:4,p:468,c:5135) queueBuffer: BufferQueue has been abandoned
10-20 01:49:15.476 E/Surface (  468): queueBuffer: error queuing buffer, -19
10-20 01:49:15.477 E/BufferQueueProducer( 5135): [SurfaceView[com.myapp/com.myapp.MainActivity]#3(BLAST Consumer)3](id:140f00000003,api:4,p:468,c:5135) cancelBuffer: BufferQueue has been abandoned
10-20 01:49:15.478 E/BufferQueueProducer( 5135): [SurfaceView[com.myapp/com.myapp.MainActivity]#3(BLAST Consumer)3](id:140f00000003,api:4,p:468,c:5135) cancelBuffer: BufferQueue has been abandoned

i think i can fix this in #2049

我想我可以在#2049中解决此问题

I update ```"react-native-vision-camera": "^3.5.1" ````  ,It seems that the problem still exists .

我想我可以在#2049中解决此问题

I update ```"react-native-vision-camera": "^3.5.1" ```` ,It seems that the problem still exists .

I tried adding key and solved the problem    <Camera       ref={camera}       key={device.id}
https://github.com/mrousavy/react-native-vision-camera/issues/1773#issuecomment-1710524501

I just fixed this in #2049, and released it to npm (v3.6.0) 🎉
If you appreciate my work and dedication to fix your issues and make VisionCamera better, please 💖 consider sponsoring me on GitHub 💖 to say thanks. Thanks!


Ctrl + Space doesn't work with subqueries

Description
Ctrl + Space should expand the column list from symbol * to correct list of columns.
It doesn't happen for some types of queries, one of which is query with subquery.
DBeaver Version
Community Edition 24.1.1
Operating System
Windows 10
Database and driver
PostgreSQL 16
PostgreSQL JDBC Driver 42.7.2
Steps to reproduce

Use this code:

select s.*
from (
    select * from pg_class
) as s;

set caret to position after the second symbol *
press Ctrl + Space
set caret to position after the first symbol *
press Ctrl + Space

Expected: the star symbol should be replaced by actual list of columns for both two symbols *
Actual: message is shown: "No proposals".  Nothing happens.
Additional context

Please also check common table expressions:

with ct as (
    select *
    from pg_class
)
select *
from ct;

Check values-clause:

select *
from (values('1','2')) as s(column1, column2)

simple join:

select
    p.*
from pg_catalog.pg_class as p
join pg_catalog.pg_class as p2 on p.relname=p2.relname
;

And many other cases...

Thank you for bug report.

Sorry, I could confuse you with wrong hotkey ctrl + A, when I actually meant Ctrl + Space.
Now I fixed it in the text.


chore(deps): update jest monorepo to v26.6.0

This PR contains the following updates:

Package
Type
Update
Change

jest (source)
devDependencies
minor
26.5.3 -> 26.6.0

jest-cli (source)
devDependencies
minor
26.5.3 -> 26.6.0

Release Notes

facebook/jest
v26.6.0
Compare Source
Features

[jest-cli, jest-config] Add support for the jest.config.ts configuration file (#10564)

Fixes

[jest-config] Simplify transform RegExp (#10207)
[jest-fake-timers] Lazily instantiate mock timers (#10551)
[jest-runtime] require.main is no longer undefined when using jest.resetModules (#10626)
[@jest/types] Add missing values for timers (#10632)

Chore & Maintenance

[docs] Add step for fetching backers.json file in website setup docs (#10631)
[docs] Add page detailing environment variables set by Jest (#10630)
[jest-circus] Refactor callAsyncCircusFn parameters (#10629)

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 6.1.12 :tada:
The release is available on:

v6.1.12
GitHub release

Your semantic-release bot :package::rocket:


Update AAPB Links

Decided that we'll only be linking out to APPB records that contain digitized video or audio that can be publicly accessed on those sites.  We need to update the OV database with only pbcoreAnnotation type="Outside URL" for only those AAPB pages with available digitized media.

[ ] Update database with list of WGBH records in the AAPB online reading room

Need to wait for assetType and Description issues to be fixed before closing.


feat: add npm support in main repository

Add support for consuming the main repository via npm for releases

This addresses #4739.

This may still require a docs update - any recommendation for where to put that @Foxandxss ?

Hmm this is not quite right - need to define the ui.bootstrap module still.

My thoughts - we will want to document usage of this, as this is a major change.
There is no good way to bundle template support, but we can point people to some loaders such as https://github.com/teux/ng-cache-loader and https://github.com/WearyMonkey/ngtemplate-loader for Webpack and https://www.npmjs.com/package/browserify-ng-html2js for Browserify. We could perhaps provide a template.js helper file that does a bunch of requires for the templates, creates a ui.bootstrap.tpls module and export that, and import it into the index.js to maintain consistency with the previous complete bundle. This would require people are using Browserify or Webpack, and have the proper config setup for requiring HTML templates.

Yeah, we have our hands a bit tied in regard of what we can provide. All we can do is to document the different options.
I will think in how can we make it as easy as possible.

Cleared by @Foxandxss


CNV-31832: add linux-bridge as filter

Add linux-bridge as a filter for the interface types
Fix the empty state

Previously the No NodeNetworkStates found was showing up only with no states in the cluster.
Now the message is displayed even when there are no states with the filters selected ( as in all other pages)
Before

After

@pcbailey || @hstastna  please have another glance

/lgtm


Media "Loading..." indicator seems to be ever present at the bottom of the media panel

Bug Description
See bug. "Loading..." doesn't go away. Ever.
Expected Behaviour
Loading should only show when the user scrolls to the bottom of the loaded media and we are actively fetching more media results.
Screenshots
Video
"Loading..." at bottom of page always there.zip

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

@csossi this seems to have been Ready for QA for 2 weeks now.

As far as I can see that problem was fixed elsewhere and PR closed, just this Issue was forgotten.


[Bug]: Crash when creating a Structure task

Bug Description
The client crashed as soon as I started searching for a name of a structure in the search bar
Specifically, minecraft:nether_fortress
How to Reproduce?

Create a task
Start typing in the Structure search bar

Expected Behavior
No response
Version
1.1.11
Mod Loader Version
1.20.1 - 47.2.20
Mod Loader
Forge
Logs or additional context
heraclescrash.txt
Code of Conduct

[X] I have searched the issue tracker and confirmed that the issue has not been reported
[X] I have checked the FAQ (if one is present) and my issue is not listed
[X] I have verified that I am using the latest version of the mod
[X] I have verified that I have installed all the required dependencies for the mod
[X] I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

Fixed in dev, and minecraft:nether_fortress isnt a structure


Feature request: schema/table option

Hi Jan,
I think we cannot selectively recreate dbs at the moment. It might be a good extension

Could you elaborate on this? I've actually been working to remove support around this, based on the fact that there is only one application properties table for a project, and all objects inside the project should always be at the same version. If this is an issue, we should discuss how to deal with this.

Hi Niels,
I think we are talking about different things. The feature request I raised here refers to the situation when you have multiple databases in Noora configuration (myproject.json). for example as follows:
{ "databases": [db_a, db_b, db_c],...}' In this case it would be handy to have a switch in "mynoora recreate" command such as this: mynoora recreate -h my-host-endpoint -d [db_a, db_b]`
to recreate only db_a and db_b

Yeah that's what I'm talking about. It should not be possible to be able to make changes to individual databases inside a project, because the version of your project affects all databases inside the project.
So, inside a specific environment, all databases should always have the same version, and as such you don't want to be able to for example recreate only specific databases, because that's going to mess up your versioning.
If I'm still interpreting it wrong, maybe Jan can explain it to me. :)

You are right if you are releasing your code into production. My use case
is for development when I am tweaking certain tables for example
On 6 May 2019 Mon at 11:59 Niels Roosen<EMAIL_ADDRESS>wrote:

Yeah that's what I'm talking about. It should not be possible to be able
to make changes to individual databases inside a project, because the
version of your project affects all databases inside the project.
So, inside a specific environment, all databases should always have the
same version, and as such you don't want to be able to for example recreate
only specific databases, because that's going to mess up your versioning.
If I'm still interpreting it wrong, maybe Jan can explain it to me. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/janripke/noora/issues/2#issuecomment-489568327, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAM52W77WQKBG2OJVM3FUEDPT76PRANCNFSM4GBYMHUA
.

--
Kind regards,
Sertaç


UI Languages

Hi webtorrent,
It's possible add IU languages in this app? I think it's cool feature if you can use it in your language.
Thanks!!

This is the library. You probably want to post this here https://github.com/feross/webtorrent-desktop .

Yes, OK and thanks!!

@Azpidatziak Internationalization is something that's being worked on. You can follow along in the webtorrent-desktop repo.


Convert PyTorch Model to Hugging Face model

DPO model is .pt, how can I convert to Hugging Face model, thanks.

The easiest way is probably just to load whatever model you started with, load the .pt, and then save the updated model with .save_pretrained. For example:
model = transformers.AutoModelForCausalLM.from_pretrained('gpt2-xl')
model.load_state_dict(torch.load('/path/to/your/dpo/checkpoint.pt')['state'])
model.save_pretrained('/some/path/to/save/to')

Will close this issue, but feel free to re-open if this doesn't solve your problem.


Trial Eligibility

I am discovering using inAppBilling.GetPurchasesAsync(ItemType.Subscription) to determine if a specific user has already used the introductory offer, but I do not see that isTrialPeroid is being passed through from the receipt. (Not sure what the Google equivalent is here).
Is there another way we can accomplish this using InAppBiliing?

That would be really helpful!


feat: add new github workflow on pull requests

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


App crashes on start (Android)

I've been trying to make it work for 3 days. Also, i try to make QtAdMobApp (WidgetApp). It doesn't work. Sometimes different problems while compiling appear. In the other situations, when apk is ready, it crashes on start. Help me please.

Which Google Ads SDK version are you using?
From Google Mobile Ads SDK version 17.0.0 onwards, it is also required to add the following to the AndroidManifest
<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>

as is explained here: https://developers.google.com/admob/android/quick-start
It also states "Important: This step is required as of Google Mobile Ads SDK version 17.0.0. Failure to add this  tag results in a crash with the message: The Google Mobile Ads SDK was initialized incorrectly."
Hope this helps,