List plugin dependencies in plugin.cfg

If you create a plugin that has dependencies on other plugins, it would be nice to be able to just put
[deps]

username/repo-name

Or some functionally equivalent syntax to automatically have those Asset Library assets installed as well.

It should also include a version number, something like npm would be great, but this would just work if the asset uses git with tagged versions.

This is more an editor thing than an assetlib thing though.

Ah, ok, I will re-post this in godotengine/godot then.


Provide an example about how to build a rocket project to wasm?

Using krustlet to run a HTTP server.
If an application using rocket as HTTP framework and diesel as ORM, how to build it to wasm?

Hi, @fanux.
Currently, you are unable to compile a program that uses networking sockets to WebAssembly — this includes HTTP servers.
See https://github.com/WebAssembly/WASI/pull/312 and https://radu-matei.com/blog/towards-sockets-networking-wasi/ for a write-up of the status for the networking APIs in WASI.
The workaround for writing HTTP handlers in WebAssembly is by using Wagi (or something like it) — https://github.com/deislabs/wagi, where the underlying runtime handles the actual HTTP listener and server, and passes the request data to a WebAssembly module.
You can use it today with Krustlet by following  — https://github.com/deislabs/krustlet-wagi-provider
Closing now, as there isn't anything we can do on the Krustlet side, but feel free to reopen if you think there is something we can improve here.
Thanks!

Hi, @fanux.
Currently, you are unable to compile a program that uses networking sockets to WebAssembly — this includes HTTP servers.
See https://github.com/WebAssembly/WASI/pull/312 and https://radu-matei.com/blog/towards-sockets-networking-wasi/ for a write-up of the status for the networking APIs in WASI.
The workaround for writing HTTP handlers in WebAssembly is by using Wagi (or something like it) — https://github.com/deislabs/wagi, where the underlying runtime handles the actual HTTP listener and server, and passes the request data to a WebAssembly module.
You can use it today with Krustlet by following  — https://github.com/deislabs/krustlet-wagi-provider
Closing now, as there isn't anything we can do on the Krustlet side, but feel free to reopen if you think there is something we can improve here.
Thanks!

We might use Dapr with wasi-experimental-http to work around with this model for networking interface like this article https://www.alibabacloud.com/blog/webassembly-%2B-dapr-%3D-next-generation-cloud-native-runtime_598222 too


Fix incorrect Glue Server Object location description

AWS Glue Database is not only limited to S3.
I was able to successfully create data contract with HDFS location using datacontract import. Other options could be RDS, Redshift, DynamoDB, etc.

LGTM, thanks for your contribution


WIP: heed the ImageOptimizationPolicy

Pass the build's configured ImageOptimizationPolicy down to the build logic by keeping track of it in the DaemonlessClient.

/retest

/retest
Potential infra flake (builds failed with OOMKilled)

/test e2e-aws-image-ecosystem

/retest

/retest

/retest

/hold cancel


user_command {PID} support

I was wondering if you could add {PID} support to the user_command?
process :bla do
  command :rotate, "kill -USR1 {PID}"
end

eye command rotate all
Thanks.

:+1:


Support installing plugins from private URLs or registries

The two options available to install plugins today is a public URL or accessible file location. For scenarios where you only want to share a plugin with a defined group of people, if would be great to be able to be bale to use either a private registry or URL to share plugins.

Support from installing from private URLs was added recently via https://github.com/fermyon/spin/pull/2896. One can now do spin plugins install --url <url> --auth-header-value <authentication header value> to install plugins from secured endpoints. Is that sufficient for this?

Can you help describe the procedure to install a plug-in from a private GitHub repo? I think that's the most likely scenario which would be great to support.

GIthub repo is currently slightly complicated as for private repositories you cannot directly curl the releases. You will have to go through the github API, which spin does not have any understanding of. The solution to this would be to have a proxy app that takes a github token which it uses to fetch the appropriate asset.
An alternate but not suggested way is to check in the files into the repo. If this is done then you can install by using
spin plugins install --url <https://raw.githubusercontent.com/<github account>/<repo name>/refs/heads/<branch>/<path to plugin manifest> --auth-header-value "token: <gh token>"


Getting an error when the replace runs.

Guide Name

[ ] Bazarr
[ ] Downloaders/Deluge
[ ] Downloaders/NZBGet
[ ] Downloaders/Qbittorrent
[ ] Downloaders/ruTorrent
[X] Downloaders/SABnzbd
[ ] Downloaders/Other
[ ] Guide-Sync
[ ] Hardlinks/Docker
[ ] Hardlinks/Dockstarter
[ ] Hardlinks/Native
[ ] Hardlinks/Synology
[ ] Hardlinks/TrueNAS-Core
[ ] Hardlinks/Unraid
[ ] Misc
[ ] Plex
[ ] Prowlarr
[ ] Radarr
[ ] Sonarr
[ ] Other

Description
Getting an error when the replace_for.py
Things are still working but this error comes up after download.
here is a screen shot
Expected Behavior
replace_for.py usually runs with no errors
Screenshots

Additional Context
version  4.2.3
-- | --
No response

GitHub is not for support; please check your sab logs for details.
trash discord or better yet the sabnzbd discord for support


eliminate some of the test suite warnings

[x] I am familiar with the contributing guidelines
[x] Tests added
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

There are still some windows warnings emitted in losses and tracking. I don't want to debug them via the CI, so I'd prefer to wrap this up and let someone else take those on.

There are still some windows warnings emitted in losses and tracking. I don't want to debug them via the CI, so I'd prefer to wrap this up and let someone else take those on.

No problem. I'm glad to have a few less distracting warnings. I'll merge now. Thanks!


add os.RemoveAll err verification

Do you think you can fix them?

@codesome  I don't know why this problem occurs under the windows system. At present, I have no solution. Can you give me some suggestions? Or merge this PR first, and then someone creates a new PR to solve this problem.

The problem occurs in the ci/circleci test for MS Windows. That should give a hint (and at the same time is the reason why we cannot merge this as is: It would break the CI tests).

@q384566678 basically we are not closing files somewhere and in Windows you cannot delete a file/directory if it is open somewhere. So you have to check where all are we not closing files in the test and close them before the deletion phase.

@codesome Done, PTAL.


WebApp - Show incorrect the current account

Describe the bug
Show incorrect the current account
Actual: Show incorrect "All accounts" mode and Specific account mode

Expect:

[x] Update select box: Select network, Select account

[x] Show correct account mode (include 2 mode):

[x]  All accounts:

[x] Specific account: Show 1 avatar of the account

Validation passed.


Use of --toastContainerBottom in custom classes

I am trying to be able to place the toast message at varying distances from the bottom of the screen depending on the context of the toast.
I have tried adding "--toastContainerBottom": "Xrem" in a custom theme prop passed to push.  Since version 0.7, I have also tried passing this preference through a class.  In both cases only the --toastContainerBottom in a :root element is used (if it exists).  Is it supported to be able to modify the distance from the bottom on a per notification basis?
Thanks!

Unfortunately --toastContainer* CSS vars can't be applied on a per-toast basis (the docs should be clearer on that). Will setting --toastMargin instead fit your use case? Alternatively you can create multiple container targets (with different bottom settings) send toasts to them based on your context.

Marking this as resolved. Feel free to reopen if there are further issues.


Implement getState method

This is a PoC for a getState terminal method that will return the serialized current state of the terminal.
Things to include in state

[x] Geometry
[x] Mode
[x] Buffer
[x] Alt buffer
[x] Cursor position
[x] Cursor style
[x] Options
[ ] Version

To do

[x] Add all members in state
[ ] Implement tests for getState

State size
It seems that the serialized state of the terminal can get kinda big, relatively easily. This happens because of the (verbose) way we are storing the buffers.
Maybe we should entertain the idea of keeping less information in memory and computing some things on the fly instead, considering buffers.
Example

Open the xterm.js demo
Run less typings.json in the terminal
Then use term.getState() in the browser's dev tools to retrieve the state
The resulting state is almost 250KBs and 25k+ lines of prettified JSON data

Screenshot

This PR should eventually close #595.

Coverage decreased (-0.2%) to 67.661% when pulling 45aa7eb377d28a581ac4eb58d63d2e11e0e60681 on issue-#595-terminal-get-state into ef1b1c8ffc169e5ac70ddf7c3cedb098a26b612f on master.

@Tyriar I am thinking about whether I should include the buffers as "plain text to be rendered" or as an array of lines (each line can either be a string, or an array of characters).
I have not decided yet, but my gut tells me that having an array of lines (each line should be a string) should do the work pretty well.
Any opinions on this?

Coverage decreased (-0.3%) to 67.677% when pulling ff5baee3e42267c85eeec3a9c055c8e5df4f7530 on issue-#595-terminal-get-state into 045f361b0d4173085eac4bd957ef416e95f101d8 on master.

@parisk My use cases for this would be to:

store the state of the terminal when the application quits, and restore the state including the scrollback buffer etc. when the user reopens the app. Additionally, If I can't get hold of the old tty session, I would spawn a new tty in the background, and write a one-line notice to the terminal that indicates that the session was re-created.

provide a viewfinder, similar to what code editors like Sublime Text have on the right hand side of the code pane, where you can see a zoomed out version of the code, and allow you to scroll through  it using a view finder. To get this working, It would massively help if I would get a line representation that can be easily transformed into html, e.g.

lines: [
  // one line, saying "hello world",
  // "hello" has green foreground and white background (ascii color)
  [
    { text: 'hello', fg: 'green', bg: 'white', bold: false, underline: false },
    { text: ' world': fg: 'fg', bg: 'bg', bold: false, underline: false }
  ]
]

In general, having some sort of parser that can be used to transform raw tty data into something that can be easily rendered by a browser would be very useful.

@mofux

Thanks for sharing your use case
xterm.js has enough performance challenges without considering a minimap imo, the fact that the output changes so frequently and so much means that the minimap would have to be re-rendered a lot. Sure it's possible but there are better areas of opportunity to focus on

Coverage decreased (-0.3%) to 68.416% when pulling 7f8f8ff44954e19bd03881aa17831e3bf29b949d on issue-#595-terminal-get-state into 2221f70ff05ba2af42ee0d26bed2f75dafe2d116 on master.

I'm excited to see this PR progress along!

Coverage decreased (-0.09%) to 68.621% when pulling c74a49c3ff160ffc3b97c1062d22090017ce3558 on issue-#595-terminal-get-state into 2221f70ff05ba2af42ee0d26bed2f75dafe2d116 on master.

Coverage decreased (-0.4%) to 68.621% when pulling 42d287cd20787865d725525f9675e2e5e9088d23 on issue-#595-terminal-get-state into 35b32b721e9be175c2eedb83c264442d171152b5 on master.

OK, I just pushed an update here, that makes getState() fully-functional for a v1 IMO.
My only thought here is that the buffers can get really really big, really quickly. This implies that:

The serialized state of the terminal can get king-size
This will make testing (and debugging) of serialized buffers cumbersome (thinking of using pre-baked .json files with already serialized states

Any ideas on how we could work around better with this issue?
If nothing comes, I will move on with implementing tests utilizing static files for the buffer data.

Coverage decreased (-0.3%) to 69.094% when pulling 31a7e5197eb13e7de9e040b6fb1f52810b85e46a on issue-#595-terminal-get-state into 663d3b24cd1ce6addc5b437d055791b11c8268b4 on master.

@parisk I imagine there's pretty straightforward compression you can do if many entries in the buffer share the same mode?

@vincentwoo if size matters I was thinking consumers could always gzip it or something. Seems like the better way to go to avoid additional complexity in the codebase imo.

Compression in-lib is usually better because a problem often ends up being de/serialization costs. If you like, I can probably write a compression utility for the data format we can include as an addon?

@vincentwoo that might make better sense as an addon, sounds like a good idea to me 👍

Okay, is the format stable enough for me to program against yet or should I hold off?

@vincentwoo I'd leave that up to @parisk, I figured you would be piping it through a common compression algorithm like gzip and back again in which case the format shouldn't matter?

No, I'm talking about format-aware stuff. For instance, let's say you have an array buffer like
[ ['a,', 485499], ['b,', 485499], ['a,', 485499] ... ]
where the mode number is always the same. the problems are:

gzip can tokenize the common number, but still has to express something like ['a', TOKEN], ['b', TOKEN], etc.
the server has to pay the penalty of stringifying a large datastructure
the client has to pay the penality of deserializing a large datastructure

instead, of we represent this as something like ['a', 'b', 'a'] with a side-structure of "mode 485499 for the whole line", the client and server can both go much faster when producing the blob to send over the wire. the smaller payload gzipped will also be smaller than the larger blob gzipped, because we have simplified entropy in a way that gzip is not capable of figuring out.

Maybe this should just go in Buffer.getState/setState post https://github.com/sourcelair/xterm.js/pull/717
If the serialize functions are nicely separated it should be pretty simple.

Should we do it before then or before a release? Changes to the buffer
format are breaking between releases at that point.
On Jun 21, 2017 3:48 PM, "Daniel Imms"<EMAIL_ADDRESS>wrote:
Maybe this should just go in Buffer.getState/setState post #717
https://github.com/sourcelair/xterm.js/pull/717
If the serialize functions are nicely separated it should be pretty simple.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sourcelair/xterm.js/pull/613#issuecomment-310226679,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlbyNSKKVvoiEzgKVFTybGp8xT2bp1Zks5sGZ3FgaJpZM4MgV15
.

@vincentwoo I'd wait until at least this and #717 are merged.
The buffer format may indeed change in the future as it's still using the original character format from term.js which is a little strange ([number, string, number]), we may also want to store more metadata some day as well. Certainly don't want to lock ourselves in to anything.

@vincentwoo let's hold off until we merge the new buffer classes into master and the first implementation of getState and setState, both of which turned out to need significantly more work than I initially thought 😅 .
After that, I think it will be pretty much easier to iterate over performance improving, benchmarking etc.

I would find this useful in my Atom package script-runner as it needs to save and restore window state.

@ioquatix this will hopefully land in 3.0 🙂.

I think I mentioned it before but I think we should only move forward with this if we allow breakages across versions. Otherwise this will severely impact our ability to improve the buffer and other components in the future.
We could do this in a way that minimizes breakages for users though, the state could have a version property which declares the breakage. So when consumers try to use the state, maybe it would return false if the version is not what is expected?

I am perfectly fine with that, I don't want to constraint xterm.js development speed at all. I think anyone who uses this feature is liable to be a savvier user and probably can deal with the consequences.

In the case of script-runner, it's really not that important, it's more like, nice to have it working correctly - if the version is updated and some old panels fail to reload correctly, it's not a big deal.

I can't tell you how much I'm looking forward to this PR :)

@Tyriar I think it's OK to introduce breaking changes when we have a new major version out (e.g. 4.0).
Considering versioning the serialized state, I think it's a great idea, so I'll put it in a todo.

@parisk I think we should allow "breaking changes" to the getState data even between minor versions, not doing so could be overly restricting. Basically defer the breakage to a separate schema version contained in the getState json which may change a between versions.

@Tyriar do you have any components in might that might need to break their serialized form more than once in (let's say) a year?

@parisk buffer improvements https://github.com/sourcelair/xterm.js/issues/791 and true color https://github.com/sourcelair/xterm.js/issues/484 are the main ones that come to mind immediately.
Additional styles would change the format, perhaps in a backwards friendly way though https://github.com/sourcelair/xterm.js/issues/580

Closing this, as I will open a fresh one for 3.0.0.

Was this ever implemented?

@ioquatix, nope. This was not implemented at all. PRs are welcome though. I would love to review.

Okay. I don't really know enough about it nor do I have the time :(


(0, _typeof3.default) is not defined

webpack + jstree 3.3.3 throws exception ：_typeof3 is not defined

Sorry, I do not think this is an error with jstree itself.


Fix so focus stays on Featured Movies carousel while flipping rapidly [JetStreamCompose]

Found an issue when rapidly cycling through the Featured Movies carousel. The focus would jump either up to the TopTabBar or below to the Trending rail (depending on the direction the carousel is being cycled).
Removing the Watch Now button avoids the issue, but it isn't clear why. I didn't go with this fix because it would be removing functionality.
Instead I found that replacing the type of ContentTransform for contentTransformStartToEnd and contentTransformEndToStart animations worked around the issue. Specifically using slide instead of fade and shortening the transition to 100ms instead of 1000ms.
Unclear exactly why the slide transitions don't have the same issue (at least with 100ms duration) as the fade transitions, but this seems like an acceptable cosmetic-only change. I tried reducing the fade transitions to 100ms, but the issue still some times occurs and no animation is noticeable at such a small duration. Increasing the new slide transition to 1000s does cause the same focus issue, but the animation looks good at 100ms so there is no problem.
Example of issue and fix:
https://github.com/android/tv-samples/assets/11371505/9c51f6b8-ca43-4fff-b73a-7f8db504c2ca
Device:

Emulator
Android TV 4k
API 34

Root issue might related to having the button inside of the carousel. As per point #2 in this comment: https://issuetracker.google.com/issues/322858968#comment3

You have made use of Buttons within a ClickableSurface which is probably not what you want. Consider using NonInteractiveSurface instead.

Thanks for sending this pull request. I confirmed the behavior you mentioned in the original comment. I filed the issue as #158.
This pull request replaces the fadeIn  / fadeOut with slideIn / slideOut, which can be a workaround, and I would keep the original animation for now.
Thanks again for creating the pull request.


Select Box Styling Broken in Portal

Describe the bug
I think #904 may have cause a different issue with the styling in the portal where the selected option does not display properly.
To Reproduce
Install the latest Vitessce into the portal and open an imaging dataset:
Expected behavior
The box should display the selection
Screenshots

Environment:

Release or git hash: 298713b
Browser: FF
Browser version: 87.0

Related? https://github.com/mui-org/material-ui/issues/20461

Applying the suggestion of importing the ScopedCssBaseline first did not help.

For now we can revert the commit which introduced ScopedCssBaseline (https://github.com/vitessce/vitessce/commit/33f210da0ea09cc3e7687e67fd6ddf7ae3e3518a) since the portal styles seem more important than the other Vitessce environments right now

Ok, will do.

Closing because this appears to be fixed https://portal.hubmapconsortium.org/browse/dataset/dc289471333309925e46ceb9bafafaf4


Add support for new Kotlin K2 mode.

Since  IJ2024.2, the new k2 compiler mode is in beta and ready for most of the use cases.

But after enabling k2, JTE plugin stopped working.

Please add support for the new k2 mode.

Thanks for reporting @sureshg.
The IntelliJ plugin is a bit outdated by now. I'm pretty sure K2 wasn't even a thing back then.
Tomorrow I should have a bit of time to look into upgrading the plugin to the latest IntelliJ version. I'll have a look at K2 support while doing the upgrade.

@sureshg I could not find the option when debugging the plugin with the latest IntelliJ version (2024.2.1, Community Edition). The quick action search somehow suggested this section, but when opening it there was no checkbox.
Nevertheless, I've created a new version of the jte plugin, since quite a few things have pile up there since the last release. The release is out the door and now pending Jetbrains Approval.
Would be interested to see if this solves the problem with K2.
The only info regarding this I found was this blog post, which is a bit outdated by now but haven't found anything newer:
https://blog.jetbrains.com/idea/2024/03/k2-kotlin-mode-alpha-in-intellij-idea/

Third-party IntelliJ IDEA plugins depending on the Kotlin plugin will be disabled. We will provide migration guidance for third-party plugin authors soon!

Which sounds like it won't work? Or, maybe they got it working without plugin authors doing anything..

Which sounds like it won't work?

@casid I am not sure about that.
Anyway, I can test 2.2.0 once it's available and let you know the result. Thanks for taking care of this.

@casid 2.2 is still not available on the plugin portal... Usually how long will it take to get the approval?

jfyi: they have published the migration guide - https://blog.jetbrains.com/platform/2024/09/migrating-your-kotlin-plugin-to-k2-mode/

@sureshg sorry for the late reply!
Jetbrains rejected the update, because the plugin is using an internal API. This hasn't been a problem before, but I think with the new publishing plugin they got a bit stricter about it. The internal API isn't used for a core feature, so it doesn't look too bad. Its a convenience thing, that when typing $, or @ the autocomplete popup shows up in HTML documents. I'm currently discussing a solution with Jetbrains and they wanted to come back to me if there's a solution without internal API usage.
If you want to give it a try, you could download the latest version here and install it manually.
https://plugins.jetbrains.com/plugin/download?rel=true&updateId=595996
Thanks for sharing the migration guide! I think next Friday I should have some slack time at work to look into the plugin.

@casid thanks..plugin 2.2.0 is still shows the same error.

@sureshg I looked through my code and it looks like I don't use the packages listed in the migration article. I've marked the plugin as compatible with K2 in the plugin.xml and published a new version. This one also has the internal API usage removed.
If you don't want to wait for approval, you can have a look at it here already:
https://plugins.jetbrains.com/plugin/14521-jte/edit/versions/stable/602884

@casid Thanks, the plugin is enabled (IntelliJ IDEA 2024.3 EAP). It seems many things are broken except syntax highlighting. Autocompletion is not working, and the import is showing an error.

Oh no, that does not look good. It kinda looks like the language injection approach the plugin uses does not work the same as it did in K2 mode.
When switching back to the previous mode it is working, I guess?

Thank you for asking! That's the thing. I don't have any good idea how to fix it. So far I only have:

Remove the K2 support marker from the plugin. Maybe this way the plugin will behave the old way even with new IntelliJ versions. Thisis probably only a temporary fix, since K2 will become the default at some point and the old way won't be supported anymore. It will also block users from having the benefits of K2.

Use an alternative approach to KteKotlinLanguageInjector, but I have no idea if this is feasible. Anyways, I guess this will be a huge amount of work, which I currently don't have the capacity for.

Hope for Jetbrains to fully support MultiHostInjector to the extend that was possible in non-K2 mode.

That being said, I'm currently hoping and doing option 3.

Thank you for your thoughts on this. Is there any possibility how to test the plugin locally in the IDE with the checked out code from this repository?


Expanding all children by default

Is there a way to start with all children expanded? Thank you!

I would like to know as well ...


[networking_mapping] Make hostvars optional for partial maps

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/1011

tox -e black will fix the pre-commit and tox prow jobs.

tox -e black will fix the pre-commit and tox prow jobs.

@raukadah done!

/approve
/lgtm

/check-required-labels


Fix E2E in teams and channels

Summary
Fix E2E in teams and channels

@srkgupta Thanks for checking.  I updated to master and looks all good to me.  Could you please take a look again.
@prapti Ready for your review

(RH) Merging this now (don't want to bother you being out of office)


Issue/fetch server details from zulip api

Automatically fetch server details from server_settings API (if supported).
Make ServerName optional.
Rename server Name to Label.
Fix #214.

Does this result in users just needing to enter the URL for a server when configuring it?

Yes. URL is the only field required.
On Fri, Jul 28, 2017, 2:12 AM Tim Abbott<EMAIL_ADDRESS>wrote:

Does this result in users just needing to enter the URL for a server when
configuring it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-electron/pull/236#issuecomment-318442590,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG7R-22JAdM5kcIFZZlCGP3xTf489p3iks5sSNLrgaJpZM4OlgkR
.

Can you post a quick screenshot?  I think showing the other fields when adding a new server, even as optional, is confusing, so I want to make sure we're doing that correctly :)

@timabbott The server_settings endpoint is only supported when Zulip version > 1.6. So if we only show the URL field, we are not able to get the name and icon.
What if I collapse these fields with a ∇  button?

I think Zulip <1.6 is going to be pretty rare these days.  So I think what we should do is this:

Just ask for a URL.   if the server supports server_settings, that's all you need.
If the server is old, maybe have a second stage where we print that they're running an old server version and they need to get the server upgraded, or provide a name and icon?

Sounds good :)
On Fri, Jul 28, 2017, 12:39 PM Tim Abbott<EMAIL_ADDRESS>wrote:

I think Zulip <1.6 is going to be pretty rare these days. So I think what
we should do is this:

Just ask for a URL. if the server supports server_settings, that's
all you need.
If the server is old, maybe have a second stage where we print that
they're running an old server version and they need to get the server
upgraded, or provide a name and icon?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-electron/pull/236#issuecomment-318557454,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG7R-0iZh3rnzQEWAqojlI8SXF_TawFbks5sSWYFgaJpZM4OlgkR
.

I think Zulip <1.6 is going to be pretty rare these days.

@timabbott if this is the case then we should only ask for the URL and then fetch all the details (icon, realm_name etc) from the server API. Also, we should validate server URL against the "result":"success" from the server API instead of checking the zulip.ogg audio file.

@akashnimare Then obsolete versions can not be validated, which might affect some users. If we just ask for a URL, we can improve the user experience without affecting those users. What do you think?

I think If we have very small numbers of users who are using Zulip < 1.6 then we should drop the zulip.ogg model and encourage those users to use Zulip v1.6 since it's much better than the older versions. @timabbott do we have any counts of those users who are using Zulip < 1.6 ? The other option is just to wait for Zulip 1.7 and then drop the support for zulip.ogg model.

We don't have concrete data, but one important detail is that Zulip <1.5 links to the old app anyway.  Still, I think it's worth having it not be impossible to use the app with older Zulip.
But it can be imperfect; e.g. , we could just use the server's domain as the "name" and a randomly generated gravatar for the default icon.
I think probably we don't need to support the user customizing the name/icon fields at all; those should just be pulled from the server when connecting (and cached locally so you can display them before connecting to the realm)
Actually, that's probably a better plan than what I'd proposed before, since then we don't have to have a settings UI for setting those fields at all; we just can show a list of the servers (displayed nicely with their name and avatar) and just have options to add/remove servers from the list.  Cleaner and less code.

@geeeeeeeeek consider a case -

User enter https://chat.zulip.org
Set an icon - https://chat.fhir.org/user_avatars/2/realm/icon.png
relam_icon is being set as server icon.

Fallback for server icon should be like this -
Entered Icon > realm_icon from api > default icon

Yep. The priority of icon is now exactly like what you said :)
On Sun, Jul 30, 2017 at 10:56 PM Akash Nimare<EMAIL_ADDRESS>wrote:

@geeeeeeeeek https://github.com/geeeeeeeeek consider a case -

User enter https://chat.zulip.org
Set an icon - https://chat.fhir.org/user_avatars/2/realm/icon.png
relam_icon is being set as server icon.

Fallback for server icon should be like this -
Entered Icon > realm_icon from api > default icon
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-electron/pull/236#issuecomment-318907115,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG7R-0SOQX6fYwhirMG5ZXapFPkuxVoTks5sTJmdgaJpZM4OlgkR
.

Yep. The priority of icon is now exactly like what you said :)

@geeeeeeeeek no it isn't. Please check again. As of now, priority look like this -
realm_icon from api > entered icon > default icon

According to @timabbott's suggestion, simplified the UI. There are no more customized fields for Icon and Name, which are either fetched from API or filled with the default icon and domain name.

@geeeeeeeeek looks like server alias is clickable and triggers addDomain event.

I see. It overlaps with the hidden New Server Form. Let me see how to fix it.

@akashnimare Fixed. Have a try :)

Yup, it's working properly. PR looks good, I'll cross test it once again tonight and then merge it :)

Merged. Thanks, @geeeeeeeeek.

I think If we have very small numbers of users who are using Zulip < 1.6 then we should drop the zulip.ogg model and encourage those users to use Zulip v1.6 since it's much better than the older versions. @timabbott do we have any counts of those users who are using Zulip < 1.6 ? The other option is just to wait for Zulip 1.7 and then drop the support for zulip.ogg model.

@timabbott is this a right time to drop the support for zulip.ogg model? Our current logic generates a false alarm on *zulipchat.com servers since the zulip.ogg file is present on invalid/non-existent servers also. So for an example - app validates the server like https://plan.zulipchat.com (since that ogg file is there).

We could definitely fix while keeping backwards-compatibility that by paying attention to the error codes from /server_settings.
It's potentially reasonable to start requiring /server_settings at this point; we've had it since 1.6.0 last June, and I'd be surprised if there are many Zulip servers older than that.  But we'd need to be pretty careful about providing a good error message, so that users' experience isn't just "the desktop app auto-updated to broken for everyone".  So it might be less work to just look into fixing the HTTP error code issues here.


[html] Incorrect Element.getAttributeNS()

This issue was originally filed by<EMAIL_ADDRESS>
The test fails
co19/LibTest/html/Element/getAttributeNS_A01_t01
The value of xlink:custom attribute is not set in
  var x = new Element.html('<svg><foo xlink:href="1" xlink:custom="2"></foo></svg>',
      treeSanitizer: new NullTreeSanitizer());
  Expect.equals('2', x.firstChild.getAttributeNS(XlinkNamespace, 'custom'));

The issue is still exists.
Dart SDK version: 2.10.0-59.0.dev (dev) (Tue Aug 25 18:05:44 2020 -0700) on "windows_x64"


V2 Beta Release

Per this discussion, this is the master Issue for the Terminal.Gui v2 Beta Release.
We will close this issue once all exit criteria for the v2 Beta have been met, and the nuget packages are published.

That's really what a project is for, though.
30 different topics in one issue gets...unweildy.

That's really what a project is for, though.
30 different topics in one issue gets...unweildy.

Maybe I wasn't clear.
When we do the final merge to v2 from v2_develop to release the beta, that PR will be titled "Fixes #3479. Launch Terminal.Gui v2 Beta".


Feature request: Allowing bailing out on first error

Pretty self descriptive, but currently when I run a feature test with multiple steps and one of them fails, they don't bail. I wasn't able to find a way to force the tests to bail, is this possible?

You would like the scenario to fail, not the whole feature, right?
That should be doable.. it will make the code a bit more complex on our side but I think this is a must have

@reaktivo Please install 0.3.0 and verify if that's what you meant - if yes, please close this issue. Thanks!

@lgandecki At first I thought it was not working as expected but I had forgotten to do npm link, I've double checked and it works fine. Thanks!


The client should check with the Server after each turn if the game is over and, if so, display a winner screen.

Acceptance Criteria:

[x] The client checks after each turn (refresh) of the game if the game is over.
[x] This check should be done via a REST Endpoint in the Server.
[x] If the game is over, a new view or a popup should appear.
[x] It should show the winner (and maybe the remaining blocks of each player).
[x] It should display some options to play another round or leave/quit.
[x] No more moves should be possible.

Method that checks if the Game is over is already implemented in the Server.

Does the method in the Server include full board and empty inventory?

To-Do: the players who did not make the last turn should be redirected to the game over view as well
after that, this issue can be closed


After rollback it continues to update the latest release

Hi! I made a rollback, but the update task continues to update the latest release, not the one I rolled back to. Is there a way to delete the newest release or to update only one specific release? Thanks.

If you did a rollback, then why you're calling update at all?
The update only purpose is to make a deploy without creating new release. The rollback is supposed to be used and a countermeasure for cases, when something went terribly wrong and you immediately need to use previous release.


Improve linter output for secret: deprecation

Component
web-ui
Describe the bug
If one has secrets: specified in WP next instead of using environment: SECRET from_secret: etc, the following linter message is shown

This is quite confusing.
I'd argue that

The first two ones should be hidden
The wording of the last one should be changed to something like users can directly understand and act on: "Using deprecated secrets: notation, please use define the secret in environment: instead using the from_secret: syntax

Steps to reproduce
.
Expected behavior
.
System Info
next

Additional context
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

Using

Using by whom? Woodpecker won't process it, if I understand correctly.

deprecated secrets: notation please use define the secret in environment: instead using the from_secret: syntax

When it was deprecated, it was like you proposed. Now (in 3.0) it is not allowed.

-> https://github.com/woodpecker-ci/woodpecker/pull/4363


Z Strips Becoming Unrespnsive

Using the beta here to try and mitigate connection issues. I have two Z Strips that are still losing connection with Home Assistant. They are always available in the LIFX App.
Prior to the beta I would restart my router and they’d reappear. After installing the beta they lose connection less frequently but when they do I need to delete the LIFX integration, restart my router, then restart Home Assistant to get them to appear again. Any thoughts on how to fix this? The two Z Strips are the only LIFX devices I have.

Yeah, there is a bug in the beta that means it sometimes won't reconnect at all. Try hitting the Reload option on the Integrations page, that should kick things in the right spot.

Ah.  This makes sense, I just had the same behavior (could see the responses in the DEBUG log entries from the Z strip, but never because "available" in HA).
If there is something I can do to help debug, let me know!

As I mentioned in another issue, the plan is to deprecate/remove this beta once the switch bypass logic has been merged upstream and released in a non-beta version: https://github.com/home-assistant/core/pull/67726
If you don't have any LIFX Switches, I recommend removing this LIFX Beta to see if the core integration works for you now. They have made a few improvements upstream that has had an impact on stability (at least for me).

Thanks very much - I see your point.  Will the core implementation allow for adjusting the settings/timeouts?  That turns out to be critical.  I will try the core implementation (I'm on the very latest and beta usually) in a few days.  Really appreciate your response and work on this.

They currently don't, but I also don't think my beta exposes them effectively either. If more folks test the updated core integration, that would allow for more core-specific modifications in future.

As I mentioned in another issue, the plan is to deprecate/remove this beta once the switch bypass logic has been merged upstream and released in a non-beta version: home-assistant/core#67726
If you don't have any LIFX Switches, I recommend removing this LIFX Beta to see if the core integration works for you now. They have made a few improvements upstream that has had an impact on stability (at least for me).

The core integration is much worse for me still than the beta for my Z Strips. I can barely get a day without the strips becoming unavailable on the latest core release.

Do you have multiple NICs active on your Home Assistant server? If so, you may want to set a specific NIC instead of relying on the default automatic selection. If you're using wifi: connect a LAN cable to see if that helps.

Single NIC on a home assistant blue. Connected via Ethernet. I don’t have any LIFX devices in my other home that runs a Pi4 to test on that right now either.
On Apr 2, 2022, 5:35 PM -0400, Avi Miller @.***>, wrote:

Do you have multiple NICs active on your Home Assistant server? If so, you may want to set a specific NIC instead of relying on the default automatic selection. If you're using wifi: connect a LAN cable to see if that helps.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Huh. I have no idea what's causing your problem, to be honest. There should be very little different between this addon and the official one and I can't think of anything that would cause that problem.

I don't believe it does, but the way this addon does it doesn't work that well either, I've discovered.

This should be resolved by https://github.com/home-assistant/core/pull/70458 when it is merged to the core.


Close space event payload, fixes https://github.com/FlatFilers/support-triage/issues/1393

Please explain how to summarize this PR for the Changelog:

Ensures that the event for closing the space is only fired once
Ensures that when closing a space, opening a new space, and closing the new space, that the close event listener from the first space is unregistered, to avoid duplicate events being handled

Tell code reviewer how and what to test:
Test both preloaded and on-demand spaces in apps/vanilla

I'm not 100% sure this resolves https://github.com/FlatFilers/support-triage/issues/1393
Note that the only event that can close the Space is clicking the Continue button here:

Per the code:
flatfileEvent.topic === 'job:outcome-acknowledged' &&
flatfileEvent.payload.status === 'complete' &&
flatfileEvent.payload.operation === closeSpace?.operation

And payload looks like this:
{
  "job": "workbook:submitActionFg",
  "info": "Getting started.",
  "domain": "workbook",
  "isPart": false,
  "status": "complete",
  "operation": "submitActionFg"
},

So it seems in order to take advantage of this, closeSpace in the Flatfile options must be set up as such:
closeSpace: {
  operation: 'submitActionFg',
  onClose: (event) => {
    console.log(
      `Close space event payload: ${JSON.stringify(event, null, 2)}`
    )
  },
},

Should fix https://github.com/FlatFilers/support-triage/issues/1382

Should fix https://github.com/FlatFilers/support-triage/issues/1408

This looks great! I added a changeset file with the npm run changeset command here - for future reference @NateFerrero


Title are not recognized.

While using Nextra, titles are not recognized, this also leads to TOC being empty.

Docs Source code: https://github.com/anudit/convodocs
Live demo: https://docs.theconvo.space/integrate/Convo-API/api-docs

I am having the same issue :(

@shuding Any idea why this is happening?

@anudit You will have to give individual titles in the mdx files like this -

@siddharthborderwala  Thanks a lot!

@siddharthborderwala  Thanks a lot!

Happy to help! @anudit

checked the nextra-theme-docs/index
  const titles = React.Children.toArray(children).filter(
    child => child.props && titleType.includes(child.props.mdxType)
  )
  const titleEl = titles.find(
    child => child.props && child.props.mdxType === 'h1'
  )
  const title =
    meta.title || (titleEl ? innerText(titleEl.props.children) : 'Untitled')
  const anchors = titles
    .filter(child => child.props && (config.floatTOC || child.props.mdxType === 'h2'))
    .map(child => child.props.children)

the child.props is empty here, the floatTOC also doesnt work now
does this also reflect the same in your end @siddharthborderwala @anudit

i feel like it is because one of mdx-js plugin upgraded into 2.0 version, the schema changed

@ChinW checkout the codebase anudit/convodocs, Got the titles and floatTOC to work correctly with the latest versions of the dependencies.
Still couldn't get Stork Search to completely work correctly so switched to Docsearch.

I cloned the master branch just now and tried to run locally, but the h2 headline doesnt have the "#" effect
thanks @anudit , let me check yours

local server

the website

I feel it is because the MdxProvider doesnt work anymore

same in your repo, well... let me dig more to see if there is a quick patch

@ChinW checkout the codebase anudit/convodocs, Got the titles and floatTOC to work correctly with the latest versions of the dependencies.
Still couldn't get Stork Search to completely work correctly so switched to Docsearch.

I suggest you use algolia if your work is open-source

same in your repo, well... let me dig more to see if there is a quick patch
It won't show up on local dev environment, you'll have to deploy it to see it in action. see the same page here https://docs.theconvo.space/docs/Convo-Extensions/brightid

I suggest you use algolia if your work is open-source

@siddharthborderwala DocSearch is by Algolia.

Aah, I see. Thanks for letting me know 😅
On Fri, 19 Nov 2021 at 2:27 PM, Anudit Nagar @.***>
wrote:

I suggest you use algolia if your work is open-source
@siddharthborderwala https://github.com/siddharthborderwala DocSearch
https://docsearch.algolia.com/docs/docsearch-v3/ is by Algolia.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shuding/nextra/issues/235#issuecomment-973879867, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AM7O7V7CAKA2M353RFGMWXDUMYGQNANCNFSM5HDGGC6A
.

Still not working when using .md files instead of .mdx on 2.0.0-beta.5


fix: modify home.zh-CN and openSourceGuide.zh-CN

Checklist

[x] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #243 (e22aa2e) into dev (c1297fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #243   +/-   ##
=======================================
  Coverage   96.32%   96.32%
=======================================
  Files         209      209
  Lines        4733     4733
  Branches      963      963
=======================================
  Hits         4559     4559
  Misses        172      172
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1297fc...e22aa2e. Read the comment docs.


method to link CASTYPE1652 to Wikidata via GBIF and Bionomia

with #5 and publications of
Poelen, Jorrit. (2023). Global Biodiversity Informatics Facility (GBIF): an exhaustive list of gbif record ids, dataset keys, and their associated Occurrence IDs, Institution Code, Collection Codes and Catalog Numbers. hash://sha256/ea88f03a7bfd1ba853fdbea3203d54ab81ac3cdc8e8da7c96bbbba9c4b05d933 hash://md5/c49fe34785354847b37ea4509261e130 (0.1) [Data set]. Zenodo. https://doi.org/10.5281/zenodo.7789866
see https://github.com/beehind/beehind.github.io/issues/5#issuecomment-1492543646
we can now find a gbifID for CASTYPE1652 in a defined verifiable resource using a regex, or other (more elegant) search methods on a well-defined digital resource of known provenance/origin.
With this, we can lookup known associations to people via bionomia -
In this case, we have:
curl 'https://linker.bio/line:gz:hash://sha256/cca558f470657a3c3fb99be70907d5705e7b5c20d12412073307fc9146e94394!/L1,L10359801'

yielding
Object,Predicate,Subject
https://gbif.org/occurrence/2238760764,http://rs.tdwg.org/dwc/iri/recordedBy,http://www.wikidata.org/entity/Q23813352

or
Object    https://gbif.org/occurrence/2238760764
Predicate http://rs.tdwg.org/dwc/iri/recordedBy
Subject   http://www.wikidata.org/entity/Q23813352

or line 10359801 in gunzipped version of hash://sha256/cca558f470657a3c3fb99be70907d5705e7b5c20d12412073307fc9146e94394 , which happens to be a bionomia snapshot of https://bionomia.net/data/bionomia-public-claims.csv.gz . Header was added for semantics.
$ preston alias hash://sha256/cca558f470657a3c3fb99be70907d5705e7b5c20d12412073307fc9146e94394
<https://bionomia.net/data/bionomia-public-claims.csv.gz> <http://purl.org/pav/hasVersion> <hash://sha256/cca558f470657a3c3fb99be70907d5705e7b5c20d12412073307fc9146e94394> <urn:uuid:fa6c6542-57bc-405a-b518-01c225f474b1> .

see screenshot:

et voila - we have a path to wikidata via gbif and bionomia facilitated by preston:
 CASTYPE1652
  -[:indexedAs] ->
      https://gbif.org/occurrence/2238760764
          -[:recordedBy] ->
              http://www.wikidata.org/entity/Q23813352

fyi @dshorthouse @Daniel-Mietchen

Also see related thread at https://discourse.gbif.org/t/type-specimen-castype1652-found-via-filtered-query-https-doi-org-10-15468-dl-xf6ahb-but-not-in-open-access-gbif-data-product-https-doi-org-10-15468-dl-pk3trq/3884 .

See also https://github.com/beehind/beehind.github.io/commit/810cc5d126294eb835b7376a589a0a6aad2017a9

For methods to access published wikidata archives, see https://github.com/Hydriz/Balchivist https://meta.wikimedia.org/wiki/Grants:Project/Hydriz/Balchivist_2.0 and https://wikitech.wikimedia.org/wiki/Nova_Resource:Dumps#2022-02-12 .


Landing page enhancements needed

Problems

[x] Remove the -webkit and -mz lines from our style.css file in /twindle-web/style.css
[ ] Enhance the banner design and put it on the web page.
[ ] Retrieve the emails from form - form submission using JavaScript to Google Excel sheet.
[x] Replace lorem ipsum with the real working text.

@twindle-co/html-css

@vasudeveloper001 @JoelVinayKumar please elaborate.
So that @cankocman can pick and work!

Enhance the banner design and put it on the web page.
This point is concerned with the main section in the code. See if you can come up with some more unique and clear design and layout for this section that doesn't feel empty. Submit for others to review and if others like it, it will be merged. Background color will remain what it is for now.


VIM-210 Fix focus issues with the Ex panel

Fixes https://youtrack.jetbrains.com/issue/VIM-210 and also https://youtrack.jetbrains.com/issue/VIM-178 which is a duplicate of VIM-210.
Previously, if the editor window had been splitted, under certain
conditions some actions related to the Ex panel would cause the editor
focus to change to a different split.
The required conditions for this bug to occur:
- no docked windows (like the Project sidebar) are open
- 'View -> Navigation bar' is disabled
At least these actions triggered the bug:
- search with /
- successfully executing an Ex command
- dismissing the Ex window with Esc
- Ex commands that opened the output panel (e.g. :!)
All the deleted lines of the form
FileEditorManager.getInstance(project).openFile(vf, true);
seem to be very old, non-functional workarounds for the focus issue.

@dezgeg Thanks for your pull request! The workaround code was indeed obsolete.

I've compiled and installed this plugin just because of this bug, but documentation was a bit incomplete for a noob like me, specially about how to deploy the plugin, this guide helped but it is also outdated (plugin must be installed as this Stackoverflow's thread points out ). Anyway thanks for the great plugin.

@khromalabs Have you read https://github.com/JetBrains/ideavim#development-environment ? Are there any steps missing from your point of view?

@vlasovskikh Yes the project's wiki was my first guide, following it, I found that Idea starts another instance of itself running Ideavim in a sandboxed enviroment (as I understood). To do the actual deployment I've followed this instructions from my previously quoted Jetbrain's guide:

Prepare your plugin for deployment. To do this, on the main menu, choose Build | Prepare Plugin Module  for Deployment. This creates a .jar or .zip archive file to be used to install and publish your plugin. If the plugin module does not depend on libraries, the .jar archive will be created. Otherwise, a .zip archive will be created that will include all the plugin libraries specified in the project settings.

And then, unlike the previous guide says, I had to install the generated jar file using the Intellij's GUI provided as the linked SO thread says:

Preferences > Plugins > Install plugin from disk...

If you want a pull request adding this to the documentation just say it :)

@khromalabs It could add it by myself, but a pull request would be welcome as well :) I would add a small change to the process described above: I prepare builds of IdeaVim by running ant dist in the project directory instead of using the IDE action for that.

Unfortunately, this PR introduces a regression on Oracle Java 6: the editor doesn't get focus after typing <Enter> in the Ex command entry field. See VIM-930.

Added a workaround for VIM-930.


add package for dffram

Upstream:
https://github.com/AUCOHL/DFFRAM
License:
Apache-2.0
Dependencies:

openlane
open_pdks.{sky130A,gf180mcuC)
https://github.com/AUCOHL/DFFRAM/blob/main/requirements.txt

Install:

Python script + module

Depends on https://github.com/AUCOHL/DFFRAM/issues/120 ?


Not print results in the console

Hi this is more a question than an issue. Is there a way to not print the results of the checks in the terminal and just the progress bar?

I think that's currently not possible. Tell us more about your specific need. What's the usage scenario you have in mind?
I know that Font Bakery diverges from a pretty common behaviour of UNIX tools that is to be absolutely silent unless there's some error. We do the opposite, but I understand than some people might want the tool to only output results to log files and nothing on stdout. Is that what you're looking for?

Hi Felipe,

I understand than some people might want the tool to only output results to log files and nothing on stdout.

Is exactly that. Font Bakery is executed as a part of larger set of tests and proofs and since the profile is read from the output file I would like it to be a bit quieter. Is somewhat cosmetic but I was wondering if maybe there was an option already for that.
Thanks for you answer!
—
Guido Ferreyra
tipografia.com.ar
El 18 de abr. de 2022 19:21 -0500, Felipe Corrêa da Silva Sanches @.***>, escribió:

I think that's currently not possible. Tell us more about your specific need. What's the usage scenario you have in mind?
I know that Font Bakery diverges from a pretty common behaviour of UNIX tools that is to be absolutely silent unless there's some error. We do the opposite, but I understand than some people might want the tool to only output results to log files and nothing on stdout. Is that what you're looking for?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Bugs fixes, extended error return from broker, error cleanup

#2371 "matrix" doesn't show up in completion list on MRO
#2353 Broker returns 404 Not Found
#2381 When host could not start CM still shows connection as valid
#2355 Include C++ runtime library in remote setup
also fixes missing constants in completion such as TRUE, NA since before they used to be fetched from HTML docs and now have to be added manually.
Cleans up messaging in REPL, added some line breaks for readability. Adds returning extended errors from broker so we can better inform user why host didn't start.

@AlexanderSher please have a look as well.

:+1:


toml::from_str can not parse valid u64 integer.

Here is the test code :
extern crate toml;

#[macro_use]
extern crate serde_derive;

#[derive(Debug, Serialize, Deserialize)]
struct T {
    i:u64
}

fn main() {
    let mut i = 1u128;

    loop {
        if i > std::u64::MAX as u128 { break }
        let t = T {
            i: i as u64
        };

        println!("u64: {}", t.i);

        let toml_s = toml::to_string(&t).unwrap();

        let new_t = toml::from_str::<T>(&toml_s);
        if new_t.is_err() {
            println!("{:?}", new_t);
            println!("toml_s: {}", toml_s);
            println!("t.i: {}", t.i);
            println!("max: {}", std::u64::MAX);
        }
        i = i * 10;
    }
}

Here is the result.
u64: 1
u64: 10
u64: 100
u64: 1000
u64: 10000
u64: 100000
u64: 1000000
u64: 10000000
u64: 100000000
u64:<PHONE_NUMBER>
u64:<PHONE_NUMBER>0
u64:<PHONE_NUMBER>00
u64:<PHONE_NUMBER>000
u64:<PHONE_NUMBER>0000
u64:<PHONE_NUMBER>00000
u64:<PHONE_NUMBER>000000
u64:<PHONE_NUMBER>0000000
u64:<PHONE_NUMBER>00000000
u64:<PHONE_NUMBER>000000000
u64:<PHONE_NUMBER>0000000000
Err(Error { inner: ErrorInner { kind: NumberInvalid, line: Some(0), col: 4, message: "", key: [] } })
toml_s: i =<PHONE_NUMBER>0000000000

t.i:<PHONE_NUMBER>0000000000
max:<PHONE_NUMBER>3709551615

see,<PHONE_NUMBER>0000000000 is less than u64 max:<PHONE_NUMBER>3709551615

Is this a bug or not?

But, I am using u64.

It looks like integer deserialization always uses an i64 even if not deserializing to toml::Value. This is a bug. https://github.com/alexcrichton/toml-rs/blob/0.4.6/src/de.rs#L815

Are there any plans or WIP to solve this issue? Maybe I can help craft a patch.

Maintenance of this crate has moved to the https://github.com/toml-rs/toml repo.  As a heads up, we plan to move toml to be on top of toml_edit, see https://github.com/toml-rs/toml/issues/340.
Closing this out.  If this is still a problem, feel free to recreate this issue in the new repo.


AttributeError: dlsym(0x2068fe020, CGLGetCurrentContext): symbol not found

Python 3.10. (already tried with 3.9 and 3.11)
MacOS Monterey 12.6.5
PyOpenGL 3.1.5 (already tried with 3.1.6)

Error log
`

from animated_drawings import render
render.start('./examples/config/mvc/interactive_window_example.yaml')
Traceback (most recent call last):
File "", line 1, in
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/animated_drawings/render.py", line 17, in start
view = View.create_view(cfg.view)
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/animated_drawings/view/view.py", line 46, in create_view
from animated_drawings.view.window_view import WindowView
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/animated_drawings/view/window_view.py", line 6, in
from animated_drawings.view.shaders.shader import Shader
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/animated_drawings/view/shaders/shader.py", line 5, in
import OpenGL.GL as GL
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/GL/init.py", line 4, in
from OpenGL.GL.VERSION.GL_1_1 import *
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/GL/VERSION/GL_1_1.py", line 14, in
from OpenGL.raw.GL.VERSION.GL_1_1 import *
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/raw/GL/VERSION/GL_1_1.py", line 7, in
from OpenGL.raw.GL import _errors
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/raw/GL/_errors.py", line 4, in
_error_checker = _ErrorChecker( _p, _p.GL.glGetError )
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/error.py", line 183, in init
self._isValid = platform.CurrentContextIsValid
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/platform/baseplatform.py", line 15, in get
value = self.fget( obj )
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/platform/baseplatform.py", line 356, in CurrentContextIsValid
return self.GetCurrentContext
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/platform/baseplatform.py", line 15, in get
value = self.fget( obj )
File "/Users/tg/Projects/ZorbinLabs/app/backend/AnimatedDrawings/ad/lib/python3.10/site-packages/OpenGL/platform/darwin.py", line 62, in GetCurrentContext
return self.CGL.CGLGetCurrentContext
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/ctypes/init.py", line 387, in getattr
func = self.getitem(name)
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/ctypes/init.py", line 392, in getitem
func = self._FuncPtr((name_or_ordinal, self))
AttributeError: dlsym(0x2068fe020, CGLGetCurrentContext): symbol not found

I did some additional research and the problem was with this variable I previously added to my .zprofile:
export DYLD_LIBRARY_PATH="/usr/local/lib:$DYLD_LIBRARY_PATH"
According to this Stackoverflow, DYLD may cause symbol lookup errors when you override with a library that does not have the same symbol table.
Problem solved!

Thanks for solving that, @JacquesGodin ... frankly I had no idea how to respond to your issue.
Closing out the issue.


bind removes type hinting and replaces it with {unknown}

Here is bind commented.

Here it is not commented and it removes all my type hinting.
Is this expected or am I doing something wrong?
If it is of any help I am using Visual Studio Code with rust_analyzer

I encountered the same situation with IntlliJ IDEA .   After I use bind

@aegonz @1291431532 does this still happen with the latest VSCode+Rust Analyzer or IntelliJ IDEA+IntelliJ Rust?


[k3s upgrade] K3s upgrade stuck when one of the control plane nodes is powered down.

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Scenario 1:

Import a k3s cluster (2 control plane and 2 worker) - version v1.16.3
Power down 1 control plane, wait for it to become unavailable.
Upgrade to v1.16.7 with server/worker concurrency 1

Result:

Upgrade started with a latency of around 10 mins on the control plane node which was active.
Upgrade stuck.

Scenario 2:

Import a k3s cluster (2 control plane and 2 worker) - version v1.16.3
Power down 1 control plane, wait for it to become unavailable.
4 Upgrade to v1.16.7 with server/worker concurrency 1
When upgrade is stuck on powered down node, edit the cluster and change the server concurrency to 2

Result:

Upgrade started on the control plane node which was unavailable initially.
After editing the server concurrency to 2, upgrade started on the control plane node which was active.
Upgrade stuck for both nodes.

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-2431-head- a1bb0a3e9
Installation option (single install/HA): Single

Checked with @davidnuzik it's a low priority, moving out of 2.4.

@khushboo-rancher
We would expect these cases to be stuck until the control plane node is fixed either by it being powered on or by being deleted from the cluster.
Can you try those steps to see if the cluster can finish upgrading?

Scenario 1:

Neither of the given options worked. After deleting the node, the other Control Plane node began upgrading but became stuck after it was Cordoned. It is showing Kubelet stopped posting node status. and will not progress.
Editing cluster to have different Control Plane Concurrency values did not fix this.

Scenario 2:

Deleting the node from the cluster worked and the rest of the nodes upgraded successfully afterwards.
Powering on the node did not work.

Powering on the node did not work in either scenario.


Incorrect near account listed as NFT owner

The NFTs of the contract at v0.8bityonce.near all listed as being owned by 8bityonce.near. However 3 of these NFTs have successfully been transferred to other accounts.
keypom-146-0-8bityonce.near-1672417819217
keypom-146-1-8bityonce.near-1672417833489
keypom-146-2-8bityonce.near-1672417847792
Is there an issue resolving the owner of NFTs when the NFT contract is deployed on a sub-account?

Looks like event logs are missing the EVENT_JSON: prefix on the smart contract in question, resulting in the indexer being unable to pick up those transfers


Missing detection of disk availability when sending heartbeats.

In RocketMQ DLedger, when a disk which stores data or index fails, a status which No-Master may occur for brokerGroup.
The following is the process of the problem：
# Process
Initial state: term=2, n2 is the Master node

2023-04-13 02:04:53, disk failure, term=3, n0 becomes Master

2023-04-13 02:04:53 INFO QuorumAckChecker-n0 - [n0][LEADER] term=3 ledgerBegin=133702137569 ledgerEnd=137547196422 committed=137547196422 watermarks={3:{"n0":137547196422,"n1":137547196422,"n2":-1}}
2023-04-13 02:04:56 WARN DLedgerServer-ScheduledExecutor - preferredLeaderId = n2 is not online

2023-04-13 02:05:08, term=3, n0 detected that n2 is online, handing over the Master role.

2023-04-13 02:05:08 INFO DLedgerServer-ScheduledExecutor - preferredLeaderId = n2, which has the smallest fall behind index = 12 and is decided to be transferee.
2023-04-13 02:05:08 INFO DLedgerServer-ScheduledExecutor - handleLeadershipTransfer: LeadershipTransferRequest{transferId='null', transfereeId='n2', takeLeadershipLedgerIndex=0, group='null', remoteId='null', lo  calId='null', code=200, leaderId='null', term=3}

2023-04-13 02:05:08，term=4, n2 becomes master

2023-04-13 02:05:08 INFO StateMaintainer - [n2] [PARSE_VOTE_RESULT] cost=1 term=4 memberNum=3 allNum=2 acceptedNum=2 notReadyTermNum=0 biggerLedgerNum=0 alreadyHasLeader=false maxTerm=4 result=PASSED
2023-04-13 02:05:08 INFO StateMaintainer - [n2] [VOTE_RESULT] has been elected to be the leader in term 4
2023-04-13 02:05:08 INFO StateMaintainer - TakeLeadershipTask finished. request=LeadershipTransferRequest{transferId='n0', transfereeId='n2', takeLeadershipLedgerIndex=137547318699, group='c4cloudsrv-miot-rocketmq-raft8', remoteId='n2', localId='n0', code=200, leaderId='n0', term=3}, response=LeadershipTransferResponse{group='null', remoteId='null', localId='null', code=200, leaderId='null', term=4}, term=4, role=LEADER
2023-04-13 02:05:08 INFO StateMaintainer - [n2] [ChangeRoleToLeader] from term: 4 and currTerm: 4

2023-04-13 02:05:27, term=4, Master role transparently passed to Broker failed

2023-04-13 02:05:08 INFO DLegerRoleChangeHandler_1 - Begin handling broker role change term=4 role=LEADER currStoreRole=SLAVE
2023-04-13 02:05:27 INFO DLegerRoleChangeHandler_1 - [MONITOR]Failed handling broker role change term=4 role=LEADER currStoreRole=SLAVE cost=19334
java.lang.InternalError: a fault occurred in a recent unsafe memory access operation in compiled Java code

In the final state, DLedger chose n2 as the Master, but there was no Master for the Broker group, and the election has not been re-initiated since then.
# Question

Why did n0 and n1 not initiate an election after n2 became Master in term 4.

If the Master has not sent heartbeats to the follower, the follower will trigger the election; but if the heartbeat has been sent normally, the slave node will not initiate the election.
The memberState object lock is used to detect disk failures. When writing a message, the lock will be held. If the disk fails, the lock will not be released in time, and the heartbeat thread will not acquire the lock, thus detecting the disk failure. It can be seen that writing messages is a trigger to detect disk failures, but if the client no longer writes messages, the heartbeat thread can always acquire the lock, and it keeps sending heartbeats.

# TODO
If no data is written, the node where the faulty disk is located will also become the Master. Therefore, I think it is necessary to add a task to regularly detect whether the disks are available. to avoid this situation.

I'd like to follow this issue. Plz assign this issue to me, thanks.

I'd like to follow this issue. Plz assign this issue to me, thanks.

Welcome~ You can write a brief improvement proposal~


Include '*.pxi' files from Cython backend.

When trying to write Cython code against pyzmq, I noticed that the *.pxi files don't get included in the distribution. It would be helpful to have them so that e.g. libzmq.pxd is a functional cython header.
This change just adds these files to package_data similar to how '*.pxd' files are included.

Indeed! Goes to show how much this gets used.


Arm install recipe targets wrong BodyPart

Describe the bug
The current recipe to install Arms targets the 'arm' BodyPart instead of the 'shoulder' BodyPart. This is causing some strange behavior with installing/removing prosthesis and is just not how the vanilla game does it.
Expected behavior
Install recipe matches the way vanilla prosthetics are installed - to the shoulder body part.

Fixed in the development branch. This will be included in the next patch.


Closes #447 |  Create dataset loader for Aya Dataset

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.
Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[ ] Confirm dataloader script works with datasets.load_dataset function.
[ ] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Opening PR for early review. When running the code, I get an error at the end:
"Object of type Licenses is not JSON serializable".


UIViewController(popoverController's contentViewController) was deallocated while key value observers were still registered with it

Under some certain circumstances(but I don't know the specific condition),  the instance popoverController will soon disappear after It appeared, and Xcode said:
"An instance 0x154e20f00 of class UIViewController was deallocated while key value observers were still registered with it. Observation info was leaked, and may even become mistakenly attached to some other object. Set a breakpoint on NSKVODeallocateBreak to stop here in the debugger. Here's the current observation info:
<NSKeyValueObservationInfo 0x1700510a0> (
<NSKeyValueObservance 0x1700c6900: Observer: 0x1781ae540, Key path: preferredContentSize, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x170050a40>)"
My code is here:

(void)xxxxxx {
WYPopoverController *popoverController = [[WYPopoverController alloc] initWithContentViewController:[UIViewController new]];
[popoverController presentPopoverFromRect:CGRectZero inView:self.view permittedArrowDirections:WYPopoverArrowDirectionUp animated:YES];
}

but, if I wrote this:
@interface myClassVC (){
WYPopoverController *popoverController;
}
...

(void)xxxxxxxxx {
popoverController = [[WYPopoverController alloc] initWithContentViewController:[UIViewController new]];
[popoverController presentPopoverFromRect:CGRectZero inView:self.view permittedArrowDirections:WYPopoverArrowDirectionUp animated:YES];
}

the issue won't occur.

Adding onto @KoCMoHaBTa solution, I needed to try catch the observer in case it wasn't attached:
-(void)dealloc
{
[[NSNotificationCenter defaultCenter] removeObserver:self];
[backgroundView removeFromSuperview];
[backgroundView setDelegate:nil];

[overlayView removeFromSuperview];
[overlayView setDelegate:nil];

barButtonItem = nil;
passthroughViews = nil;

inView = nil;
overlayView = nil;
backgroundView = nil;

[self unregisterTheme];
theme = nil;

if ([self->viewController respondsToSelector:@selector(preferredContentSize)])
{

    @try{
                [self->viewController removeObserver:self forKeyPath:NSStringFromSelector(@selector(preferredContentSize))];
    }@catch(id anException){
        //do nothing, obviously it wasn't attached because an exception was thrown
    }
}
else
{
    @try{
        [self->viewController removeObserver:self forKeyPath:NSStringFromSelector(@selector(contentSizeForViewInPopover))];
    }@catch(id anException){
        //do nothing, obviously it wasn't attached because an exception was thrown
    }

}

viewController = nil;

}

Check out the fork that's being maintained. This repo was the original but has been dormant for over a year.

On 22/05/2015, at 06:25, MobileMon<EMAIL_ADDRESS>wrote:
Adding onto @KoCMoHaBTa solution, I needed to try catch the observer in case it wasn't attached:
-(void)dealloc
{
[[NSNotificationCenter defaultCenter] removeObserver:self];
[backgroundView removeFromSuperview];
[backgroundView setDelegate:nil];
[overlayView removeFromSuperview];
[overlayView setDelegate:nil];
barButtonItem = nil;
passthroughViews = nil;
inView = nil;
overlayView = nil;
backgroundView = nil;
[self unregisterTheme];
theme = nil;
if ([self->viewController respondsToSelector:@selector(preferredContentSize)])
{
@try{
            [self->viewController removeObserver:self forKeyPath:NSStringFromSelector(@selector(preferredContentSize))];
}@catch(id anException){
    //do nothing, obviously it wasn't attached because an exception was thrown
}

}
else
{
@try{
[self->viewController removeObserver:self forKeyPath:NSStringFromSelector(@selector(contentSizeForViewInPopover))];
}@catch(id anException){
//do nothing, obviously it wasn't attached because an exception was thrown
}
}
viewController = nil;
}
—
Reply to this email directly or view it on GitHub.

@property(nonatomic,strong)WYPopoverController *popvc;


Incorrect hex color documented on color page

The documented hex value for color(green, subtle) is not correct. On the color page you see #f4fa43 but it should be #f4fae3 like in the code.
See https://style.kpn.com/#/base/color

Fixed in portal v1.2.0


Minor Fixes; respect port flag and install dependencies in docker container.

Two minor changes to ensure the port flag is respected when opening the webserver and that the required dependencies are installed in the docker container.

Thanks!


Problem: Transactions rejected during DeliverTx are not tracked

Description
CheckTx validates a given transaction against the committed transactions so this validation doesn't include a transaction which has already been validated by CheckTx and placed into the mempool. So, during DeliverTx a transaction gets validated against the previous transactions received in the block which is being committed. It would be fair to assert that double spends can be detected here, which are then rejected. But the status of such rejected transactions is not stored anywhere. It might be desirable to temporarily store the transaction id of such transactions and inform the user.  /cc @ldmberman
Furthermore, Tendermint exposes /unconfirmed_txs which returns a list of transactions in the mempool awaiting to be committed.
The above description provides some pointers on how to re-implement the status API which was previously available in 1.x series.
NOTE: This is not an immediate requirement but a 'nice to have' feature for a more predictable user experience.

In the future, Tendermint might record a bit-array in the block header of each block, where each bit indicates whether that transaction was considered valid or invalid by the network (based on the response Code from DeliverTx). See https://github.com/tendermint/tendermint/issues/2175

This seem like it might be a connected to #2513.

NOTE: This is not an immediate requirement but a 'nice to have' feature for a more predictable user experience.

To improve user experience we can start by stream rejected transactions and the reason for rejection to the event stream API. What do you think?
Good suggestion

The above description provides some pointers on how to re-implement the status API which was previously available in 1.x series.


Feature Request: Receive notifications from 3rd part plugins

Hello,
I`m starting to develop a new OctoPrint Plugin that's monitors and shuts down the printer for safety reasons (Safety Printer) and it would be nice if I can use your plugin to send notifications when something wrong happens. It's possible?

Hi @SinisterRj,
This is a great idea. I will see how we can open the door so that other plugins can send push notifications to OctoPod app with custom messages. Would be good to support all translations but we can start simple for now. Filing for next release.
Thanks,
Gaston

Good news @SinisterRj. I implemented this feature which will be released in the next version. I also wrote this wiki page that shows how to use this functionality

Very nice Gaston! It's already working, Thanks!
In your wiki I recommend to substitute:
self.push_notification("My message goes here")
by:
try:     self.push_notification("My message goes here")  except AttributeError:     pass
to avoid AttributeError if the user installs the 3rd part plug-in but not Octopod.

Great catch. Updated wiki with your good suggestion. And happy to hear it is working fine for you!
Gaston


⚠ Bofrost.at has degraded performance

In a4f7455, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 995 ms

Resolved: Bofrost.at performance has improved in 34c8963.


Code and Code-insiders crash when attempting basic functions

Causes crash:
Exploring to "Help" > "About"
Attempting to save a file
Attempting to open a folder
Attempting to close an open tab
Attempting to submit an issue (had to do it manually)
Does not Crash:
Open new tab
Open new window
Exploring to "Preferences" > "Settings" (and making changes)
System Info:
Manjaro on Linux 5.6.16-1
DISTRIB_ID=ManjaroLinux
DISTRIB_RELEASE=20.0.3
DISTRIB_CODENAME=Lysia
DISTRIB_DESCRIPTION="Manjaro Linux"
Using snap for both Code and Code-insiders
Stable:
snap-id:      Ht0aUHi7ofh9Fbwh6m7jUN2pAy6kzBiu
tracking:     latest/stable
refresh-date: today at 19:52 CDT
channels:
latest/stable:    d5e9aa02 2020-07-10 (36) 151MB classic
Insiders:
snap-id:      vNVY8DiBL4e2Q8H3Xtsh71c8QSTaxBdp
tracking:     latest/stable
refresh-date: today at 19:34 CDT
channels:
latest/stable:    3bc3f95d 2020-07-13 (480) 153MB classic
CPUs
AMD Ryzen 9 3900X 12-Core Processor (24 x 2540)
GPU Status
2d_canvas: unavailable_software
flash_3d: disabled_software
flash_stage3d: disabled_software
flash_stage3d_baseline: disabled_software
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: disabled_off
protected_video_decode: disabled_off
rasterization: disabled_software
skia_renderer: enabled_on
video_decode: disabled_software
viz_display_compositor: enabled_on
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
Load (avg)    1, 1, 1
Memory (System)    62.83GB (53.50GB free)
Process Argv    --no-sandbox
Screen Reader    no
VM    0%
symbolicated_stack_insiders.txt
symbolicated_stack_stable.txt
Launched with code --disable-extensions however this continues to crash. (Also, no extensions are installed)
Code was running earlier today so I'm not sure if the snap updated causing this issue or not.

Linux Snap it seems.

Hi :hand:,
I can confirm the issue: same distro / also using snap.
It's definitely coming from the latest release (was perfectly fine yesterday evening / Berlin GMT+2).

#100940


Why can't I execute this compile command--------  cmake --build . --config Release –- -m:6

Please delete
–- -m:6

and retry.
Or you can switch to cmd and don't use powershell.

Thank you, I did open it using powershell and it worked after deleting -- -m:6


upstream_tag_template not used during srpm build

We should use upstream_tag_template also for srpm creation so users don't need to specify the custom command.

[ ] use upstream_tag_template in get_current_version
https://github.com/packit-service/packit/blob/1bb4001e751ed63ded4c9d87794c58846438d166/packit/upstream.py#L255
[ ] ? use upstream_tag_template in fix_spec`
https://github.com/packit-service/packit/blob/1bb4001e751ed63ded4c9d87794c58846438d166/packit/upstream.py#L402
[ ] document clearly, where it is used

ping @jkonecny12

Thanks @lachmanfrantisek for your help and for filing this!

Thanks @lachmanfrantisek for your help and for filing this!

Thanks for the feedback and patience...;)

This bug is blocking propose-update feature for me.
I can't run the command without it:
packit propose-update
WARNING  Job metadata key 'dist-git-branch' has been renamed to 'dist_git_branches', please update your configuration file.
Input directory is an upstream repository.
Syncing from the following branches: master
Won't be doing kinit, no credentials provided.
Version in upstream registries is '1.6'.
Version in spec file is '1.7'.
Picking version <Version('1.7')> found in spec file.
Checking out upstream version 1.7.
ERROR    Cannot checkout release tag: GitCommandError(['git', 'checkout', '1.7'], 1, b"error: pathspec '1.7' did not match any file(s) known to git", b'').

However, when I add it to solve this issue then my archive is created with bad directory in the archive.
.packit.yaml
upstream_tag_template: simpleline-{version}

simpleline-1.7.tar.gz then have sources in directory named python-simpleline-simpleline-1.7 which can't be build with spec file.

Also a question why propose-update does not using create-archive: action to create the archive?

[ ]  ? use upstream_tag_template in fix_spec`
https://github.com/packit-service/packit/blob/1bb4001e751ed63ded4c9d87794c58846438d166/packit/upstream.py#L402

fix_spec is already called with the version returned by get_current_version


Player's current target persists through targets death

When target dies, it stays targetted.

Fixed for both PC and NPC targets in 0.6.5


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-insights-datacollectionrule
Module Details
AVM Resource Module for Data Collection Rule
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi Team, I'm interested to work on this module

Hi @sharmilamusunuru
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Regards,
Sharmila Musunuru
Cloud Solutions Architect- Apps & Infra
Azure Infrastructure & Apps
Mobile: +65 89257145
[Microsoft]
Find a free slot and book my time @.***/bookings/>.
From: Predrag Jelesijevic @.>
Sent: Wednesday, July 17, 2024 8:21 PM
To: Azure/Azure-Verified-Modules @.>
Cc: Mention @.>; Comment @.>
Subject: Re: [Azure/Azure-Verified-Modules] [Module Proposal]: avm-res-insights-datacollectionrule (Issue #1082)
Hi @sharmilamusunuruhttps://github.com/sharmilamusunuru
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACIhttps://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions
Shared Specification (Bicep & Terraform)https://azure.github.io/Azure-Verified-Modules/specs/shared
Module Supporthttps://azure.github.io/Azure-Verified-Modules/help-support/module-support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/Azure-Verified-Modules/issues/1082#issuecomment-2232959085 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ32AGVWWDXIYQAQU3H2AV3ZMZARBBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI2TSMBXG43DSOBQGGSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRVHEYDONZWHE4DOMFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDKOJQG43TOMBUHA4KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGU4TGNRVGMYTEMBTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNJZGUYDSNJUHAZDDJDOMFWWLKLIMFZV63DBMJSWZAVFOZQWY5LFVI3DANBZGI2TENZWGCSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44YQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJWGYYDEMJRGU3TNAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMZVGY4TQMJUGU3YFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI2TSMBXG43DSOBQGGBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGU4TANZXGY4TQNZQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRVHEYDONZXGA2DQOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNJZGM3DKMZRGIYDHAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDKOJVGA4TKNBYGIYYFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI3DANBZGI2TENZWGCTXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hey @sharmilamusunuru
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

repo created waiting for business review


Some cleanup redux (for failed parameter checks)

@cyrillustan this might run more robustly now. I also got rid of the np.pad call in Req_func2 as it was the slowest point in testing.

Seems like it fixes the issue that broke cell-selective yesterday


Added the @silent directive.

The @silent directive allows classes that exist purely to be @extend'ed to be removed from the compiled output.
Please review.

Closing this pull request. Nathan is working on a similar feature called placeholder selectors.

'@silent' was such a good idea, it makes a lot of sense in SCSS syntax. %selector looks like SASS to me.
Also, it is just says what it is doing, saves new developers a trip to the docs.
Please, consider '@silent' for SCSS syntax.

I think the placeholder syntax is brilliant and more correctly and succinctly denotes the functionality that the @silent directive was providing.


Update contribute_to_paddle.md

Use "git pull --rebase" to update code with the latest version so that new changes is on top of the upstream instead of mixing with upstream code.
Here is a bad example of not using "--rebase": https://github.com/baidu/Paddle/pull/383/commits

@wangkuiyi @emailweixu The commit log is not important for each pull request, because we will always use squash & merge when merge the PR into develop branch. The squash & merge will make all commits in one PR into an one commit.
So the git pull --rebase is not important. And --rebase will make push more difficult, it must force rewrite the history in github.
I suggest not to use --rebase in PR, and use squash & merge when merge PR.

Actually, I am not sure we need either git pull --rebase or squash & merge.  I never used either of them in recent 7 years.
I tried to understand the necessity of --rebase and I found this explanation.  But it looks to me that "necessity" was due to bad habits of the author -- he should not trust his own remote's master at all -- he should always trust and only pull from upstream/develop.
I am not sure that we need squash & merge because I am not sure I fully understand the behavior -- in particular, how would it be if my local branch is relatively long-term and before I merge it I did several git pull upstream develop?  Would Github need to squash my long branch together with the parallel part in upstream/develop?

squash & merge's example as follow
In PR #363, there are many commits in it, and commit logs could be not clear. But when we merge them into develop, as commit c64cd6feb4b8f7c052ed8f4934dc0b9059969d84, we squash all the commits in PR #363 to one commit.
It is no matter how many or how chaos about commits in a PR, no matter if there is merge commit or not. Using squash & merge, all commits in a PR will be one commit into target branch.

Suppose that I have been working on a branch A. During the work, I had ran git pull upstream develop 3 times. Then branch A would have 4 “parent” commits. My question is -- which one of of the 4 would be the parent of the “squashed” commit?

On Nov 8, 2016, at 9:59 PM, Yu Yang<EMAIL_ADDRESS>wrote:
squash & merge's example as follow
In PR #363 https://github.com/baidu/Paddle/pull/363, there are many commits https://github.com/baidu/Paddle/pull/363/commits in it, and commit logs could be not clear. But when we merge them into develop, as commit c64cd6f https://github.com/baidu/Paddle/commit/c64cd6feb4b8f7c052ed8f4934dc0b9059969d84, we squash all the commits in PR #363 https://github.com/baidu/Paddle/pull/363 to one commit.
It is no matter how many or how chaos about commits in a PR, no matter if there is merge commit or not. Using squash & merge, all commits in a PR will be one commit into target branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/baidu/Paddle/pull/403#issuecomment-259339700, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeh57rlv8mcXot0uX2xe9g430dG8K1tks5q8WFJgaJpZM4KtGJr.

Suppose that I have been working on a branch A. During the work, I had ran git pull upstream develop 3 times. Then branch A would have 4 “parent” commits. My question is -- which one of of the 4 would be the parent of the “squashed” commit?

Squash & merge will always squash all commits into one commit, then apply this commit to the HEAD of develop branch.

To confirm that I understand this — if all PRs are merged to upstream/develop with “squashing”, we would see a linear and clean develop branch in page github.com/baidu/paddle/network http://github.com/baidu/paddle/network like the following:
commit 1 —> merge commit 2 —> merge commit 3
instead of something we current have:
commit 1 ——————--------—> merge commit 2
|                         |
`—> commit i -> commit j -/

On Nov 8, 2016, at 10:23 PM, Yu Yang<EMAIL_ADDRESS>wrote:
Suppose that I have been working on a branch A. During the work, I had ran git pull upstream develop 3 times. Then branch A would have 4 “parent” commits. My question is -- which one of of the 4 would be the parent of the “squashed” commit?
Squash & merge will always squash all commits into one commit, then apply this commit to the HEAD of develop branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/baidu/Paddle/pull/403#issuecomment-259342294, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeh5xzfE57GCmqVWQqYLHWKaYz3s22dks5q8WbzgaJpZM4KtGJr.

That's right.
By the way, we can use merge to other branch.

develop to master branch will be a simple merge commit
feature branch to develop branch, will be a simple merge commit, too. But each PR to feature branch will be a squash & merge commit.

If we start a release branch from develop and merged, with squashing, to master, how many parents would the merge commit have? I hope there would be 2 and as follows, so we could see that the merge was from the develop branch.
master branch:   release commit 1 --> release commit 2
                                                                       |
develop branch:  merge commit 1 --> merge commit 2 -> merge commit 3

I think it would be good if we open a test repo and try feature branch merging and release branching merging with "squashing", and show the result Network as a demo.  Or is there such examples in the "squash & merge" document?

@wangkuiyi The official documentation of PR merging is here.
I think I will write a blog this night maybe, it is a very interesting thing for a large repository, maybe written it down can help many people, even out of paddle team.

Yes. That document page is exactly what I checked. It doesn't have the case of release branches.

我试了一下 squash and merge。我认为我们需要严禁 使用这种merge方式。
我尝试过程如下：

创建一个空的repo，其中有两个branches：master和develop，都指向初始commit。如下图所示：


Adding Data (but not Generic) instance

Just adding these instances. Required for consumers of the text-short library to derive Data & Generic instances automatically via -XDeriveDataTypeable & -XDeriveGeneric, respectively.

What's the concrete motivation/use-case for having these instances? I usually avoid defining these instances for abstract datatypes as supplying these exposes the internal representation to some degree...

Our use case as serialization via the compact regions of the compact package. It has a Typeable constraint, and nested deep in our object are some ShortText values that need Data instances to be "glued" together for a Typeable instance of the large object to be serialized.
Thanks for dredging up the link from Data.Text.
I read through the conversation surrounding the Data instance decision of Text. I found that this comment from Neil mirrors my own philosophy on the matter:

You have to trust people not to break that abstraction, but it's not a simple abstraction to break - it's the moral equivalent of pointer prodding in a std::string, no one breaks it accidentally.

Also, I was a little surprised that ByteString, ShortByteString, and Text have Data instances, but not ShortText. It seemed a bit of an "inconsistent API," though I know that these types are from three separate packages and that there isn't really an API for all the "string type" packages.

Looks like there's another person hoping to use the Data instance here: #7

@recursion-ninja I'm actually ok with adding a Data instance in the style of Data.Text; then we'd be consistent with the prior art. Would that satisfy your needs?

@hvr yes, that's manner in which I was hoping to use the  ShortText Data instance.

@hvr any word on merging the PR and uploading a new version of short-text to hackage?

@recursion-ninja well, the PR as-is a) adds a Generic instance (which leaks internals), and b) doesn't implement the Data instance in the style of Data.Text (i.e. by faking a [Char] representation)

@hvr I misunderstood your previous comment. What you said with regards to the Data & Generic instances in the pull request makes sense.
Consequently, I removed the Generic instance from this pull request and changed the Data instance from the standard deriving mechanism to the abstracted [Char] representation similar to Text.
Please take a peek at the updated Data instance to make sure it's both sensible and what you had in mind.

Bump @hvr!
I'd also like to have that instance! :)

Thanks; I'll take it from here


Cannot set the status of a project

Hello,
I am trying to set the status of a project as follows:
Redmine.Net.Api.Types.Project project = new Redmine.Net.Api.Types.Project
            {
               Name = name,
               Identifier = projectIdentifier,
               Description = description,
               IsPublic = false,
               InheritMembers = false,
               Status = ProjectStatus.Close
            };

Redmine.Net.Api.Types.Project savedProject = redmineManager.CreateObject(project);

I have also tried to update it:
var redmineProject = redmineManager.GetObject<Project>(projectIdentifier, null);
redmineProject.Status = ProjectStatus.Close;
redmineManager.UpdateObject(projectIdentifier, redmineProject);

In both cases the status is not updated, so I am wondering whether it exists another way to do so or not. The Redmine repository version that I am using is the 4.0.5.
I hope you can help me. Thank you.

Hello,
What version of Redmine, Redmine .NET API are you using?

Hello and thank you for your answer,
The versions I am using are:

Redmine 4.0.5.
.NET API 3.0.0

The status property is not serialized because is not expected by the server.


Ability to disable laser pointer for bow aiming

Currently when you aim a bow it generates a laser pointer for aiming.  I would like to be able to disable this but there doesn't seem to be a way to do so.

Can you upload a screenshot of it in action? If you mean a green line that goes from the head of the player to the crosshair, thats a feature of epic fight, not Shoulder Surfing.

My bad.  Sorry!