Survey of MoltenVK Use - Developer Input Requested!

If you are a developer using MoltenVK for your game, engine, or app, please let us know below!
We'd love to hear the name of your game, engine, or app, and we'd love to hear about your experiences using MoltenVK.
Understanding how developers use and depend on MoltenVK will help us produce a better product for everyone.
Thanks!

@cdavis5e @tmm1 @mbarriault @aerofly @js6i @Lichtso @Michael-Lfx @mmaldacker @hanton @BearishSun @ryandesign @ePirat @w103csh @jozefkucia @csmartdalton86 @TheSpydog @Khronoswebmaster @prideout @mellinoe @EwoutH @DiegoAce @Cry-Mory @tobine @stefand @spadix0 @mlfarrell @mbechard @kusma @jherico @francoisbertelatschrodinger @davidhubbard @ch45er @alexey-lysiuk @VinDuv @Tele42 @OliverBalfour @MaddTheSane @oscarbg @741g

I've been using it for unshipped versions of https://vertostudio.com
and for a shipped game on macOS & Steam here - https://apps.apple.com/us/app/war-war/id1518435998?mt=12

I use a MacBook when working on Filament and MoltenVK has enabled me to
work on our Vulkan backend without deploying to an Android device.  This
has been a huge time saver.  No complaints!
On Tue, Sep 29, 2020 at 11:45 AM mlfarrell<EMAIL_ADDRESS>wrote:

I've been using it for unshipped versions of https://vertostudio.com
and for a shipped game on macOS & Steam here -
https://apps.apple.com/us/app/war-war/id1518435998?mt=12
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/KhronosGroup/MoltenVK/issues/1085#issuecomment-700909311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ2VSF5MFWC6NCDJVTIKZDSIITOFANCNFSM4R6FCALQ
.

Kris Rose couldn't even spell the name of the project right. He wrote Dec 3, 2018, "Thanks for your patience with my response I have been preparing for SIGGRAPH Asia which I'm now at." Proceeded to tell me that a C++ layer was a threat to Vulkan, "removing the low-level purpose of Vulkan."
As there are lots of C++ layers now, I assume all of these "developer surveys" are trojan horses designed to undermine indie efforts by leveraging our efforts with an embrace, extend, extinguish strategy.

MoltenVK is used by GZDoom to enable Vulkan renderer on macOS. With the exception of triangle fans workaround, I had no issues with it.

This is used by Fuchsia Emulator: https://fuchsia.dev/fuchsia-src/development/run/femu and Android Emulator: https://developer.android.com/studio/run/emulator
for enabling virtualization of Vulkan apps in the guest to run with Vulkan (or in this case, Metal) on the host.

I've been in the process of porting TouchDesigner over to Vulkan. I first did a full port over on the Windows side until things were working relatively well (80% + complete).
Then I started working on the macOS side. Except for a few small bugs, I had to change very little code to get things to work on macOS. MoltenVK dropped in as a ICD layer and just worked. It was a big unknown for us as part of this port but ended up being a super smooth integration.

Since Apple deprecated OpenGL, I've been using MoltenVK to build my new iOS apps and update some of my old ones. https://gammalateral.com
I mostly build/test the games on Mac, so I use MoltenVK on Mac a lot too.
The experience has been great being able to run Vulkan on Apple and Windows.

Posting on behalf of the FNA team: https://fna-xna.github.io/
FNA is in the interesting position of having both Metal and Vulkan as supported renderers, despite actively using MoltenVK at the same time. Our Metal support has shipped in games already, but as we continue working on Vulkan we're noticing two things:

Explicit APIs are hard (big surprise)
Explicit APIs are easier when more than one person is working with them

FNA3D Metal is considered stable, but it took a long time to get there, and maintenance has been a lot tougher compared to other backends like OpenGL and D3D11 since we only have one person that understands it well. On the other hand, Vulkan in general is absolutely murderous, but we usually have 3+ working on it at any given time, and being able to include Apple developers in that group has been immensely helpful since, as a very small FOSS project, we need all the eyeballs we can get.
It's also worth noting that while MoltenVK is obviously going to add overhead vs directly going to Metal, we're not entirely convinced that the delta is significant in practice, and the tradeoff of minor CPU overhead vs. having that overhead be understood by people other than us makes it an incredibly easy decision. This doesn't even factor in that, by having more experts looking at the code, it's far more likely that we'll find ways to optimize the renderer significantly in ways that we wouldn't have seen if we delegated that work to people who only cared about Metal, even when we're not looking at Apple platforms at the time of optimization (we're already seeing places where MoltenVK is faster than our direct Metal work!).
Most importantly (to us at least), the MoltenVK project has been very easy to contribute to for new features, and we're hoping to contribute possible performance improvements in the future. Being able to offload the Apple support in a way that benefits both ourselves and others, in all directions, has us feeling a whole lot better about long-term support for a group of platforms that has spent the last few years desperately trying to get us to stop developing for them.
As a Linux porter who just wants the macOS backend to be like Linux again, I fully expect to mass deploy MoltenVK in my own catalog of Linux/macOS games, past and present, in the near future.

As many of you know, macOS lacks support for OpenGL beyond 4.1, and Apple will probably never fix this. For this reason, Wine has not been able to run Direct3D 11 games on Mac, because a number of features required by wined3d are missing.
Then we discovered MoltenVK.
When Square Enix approached us for an updated port of Final Fantasy XIV to Mac, we used MoltenVK to provide them support for D3D11 features they wanted, including tessellation, added to MoltenVK for just this reason. This was so successful that we made plans to integrate MoltenVK into CrossOver, allowing users for the very first time to run a number of D3D11 titles on their Macs without installing another OS, including AAA titles such as Dark Souls Remastered, Dark Souls III, and Path of Exile; and indie games such as Raft. This will become especially important as the Apple Silicon transition continues, because once that's done, Wine will be the only way to run Windows programs on a Mac.

We're using it to update an existing OpenGL app (scientific graphing software) running on an iPad, as we felt using Vulkan was much more future proof and allows easier porting to other platforms. So far, MoltenVK has worked like a charm!

yuzu is a Nintendo Switch emulator, it emulates a Tegra X1 chip with low level emulation. The short explanation for this is that we emulate the hardware, not the driver or platform APIs. A Tegra X1 is an Nvidia Maxwell gen2 device with some tweaks (full fp16 support and ASTC textures).
We currently use OpenGL 4.5 (compatibility profile) and Vulkan 1.1 with several extensions. Our OpenGL backend gives the best user experience at the moment, extensively using vendor extensions.
macOS is not currently supported but it's something we have in mind. There have been attempts to port yuzu through MoltenVK: https://github.com/yuzu-emu/yuzu/pull/3593 https://github.com/yuzu-emu/yuzu/pull/4165.
Simple games work, although MoltenVK has some shortcomings that block it from running AAA games, but first I'd like to mention issues that have been fixed. The first one is the need to backport to Vulkan 1.0, now we only have to care about Vulkan 1.1. There were some SPIR-V -> MSL issues that have also been addressed: https://github.com/KhronosGroup/SPIRV-Cross/issues/1332 https://github.com/KhronosGroup/SPIRV-Cross/issues/1338. Thanks to the maintainers for that.
The last time it was tested, most non-trivial games didn't render properly due to the lack of arbitrary vertex buffer strides on Metal and by extension MoltenVK:
[mvk-error] VK_ERROR_INITIALIZATION_FAILED: Under Metal, vertex buffer strides must be aligned to four bytes.

There have been issues with image view swizzles (I don't have logs for these at the moment). We now use VK_KHR_timeline_semaphores for better resource management without a fallback. I plan to make VK_EXT_descriptor_indexing and VK_EXT_robustness2 (supported by MoltenVK) mandatory once the later is supported on Intel's proprietary stack.
We can address these issues from our application, it's an emulator after all. There's already code for emulating missing features on Vulkan, some MoltenVK specific fallbacks wouldn't hurt. That said, given this is a call for developer input, what we'd need for seamless MoltenVK integration:

Integrate the VK_KHR_timeline_semaphore compatiblity layer into MoltenVK.
Somehow emulate arbitrary vertex buffer strides. Maybe vertex pulling from TBOs in the vertex shader, I'd do something like that if I had to emulate this at an application level. This would give headaches if extended dynamic states have to be supported in the future.

And a lesser mention, as it's not required now but it will be relevant in the future:

Image and sampler indexing with VK_EXT_descriptor_indexing, or equivalent bindless functionality that allows combining images and samplers at runtime.

We use MoltenVK for our Flight Simulator Aerofly FS on MacOS and iOS. Experience so far has been great. The stability on iOS is very good ( no crashes even if flying for a long time ). On MacOS it's also good, however on some GPUs we do get GPU hangs from time to time, it's not clear what is causing this.
Performance of MoltenVK is quite a bit better compared to using the OpenGL which has been neglected and deprecated by Apple.
What we would like to see in future updates are less dynamic allocations during rendering. Avoiding system calls as much as possible during rendering will also likely improve the stability.
Another possible option to improve the performance is to avoid redundant state change calls, e.g. each render call repeatedly sets various rendering states which have already been set.
Besides that MoltenVK is a great project and saves us a lot of time to maintain yet another rendering backend.

BTW, in terms of experience using MoltenVK for Fuchsia/Android emulation, we have had to work around the lack of support for external memory in various ways, including setting up some specific workarounds that leveraged on the existing iosurface support. We'd love to see MoltenVK support external memory, first with external images and then buffers.

I use MoltenVK for learning purposes.
I download the SDK from LunarG, run install.sh script and use Vulkan (and MoltenVK) through CMake. Straightforward and simple!
I had no problems from MoltenVK. I tried to use Xcode Metal debugger to understand and view things without success.

I program plugins for Adobe After Effects and have been implementing GPU-acceleration using both Graphics and Compute pipelines in Vulkan on Windows, and MoltenVK for Mac. I use Vulkan as my GPGPU home-base over OpenCL or Cuda and MoltenVK fills in the OSX niche.
MoltenVK has been pretty great for this use-case and has been pretty "drop in" so far, save for having to tuck away the usage of some extensions that MoltenVK does not implement properly(Targeting Vulkan 1.1 primarily).
Now I can think totally in Vulkan and benefit both demographics with generally minimal port work.

I use MoltenVK for Excal, a rendering engine I'm building.
Being able to develop cross-platform applications with Vulkan through MoltenVK on macOS has been a great experience - over the past few months I haven't run into any significant issues with MoltenVK.

yuzu is a Nintendo Switch emulator, it emulates a Tegra X1 chip with low level emulation. The short explanation for this is that we emulate the hardware, not the driver or platform APIs. A Tegra X1 is an Nvidia Maxwell gen2 device with some tweaks (full fp16 support and ASTC textures).
We currently use OpenGL 4.5 (compatibility profile) and Vulkan 1.1 with several extensions. Our OpenGL backend gives the best user experience at the moment, extensively using vendor extensions.
macOS is not currently supported but it's something we have in mind. There have been attempts to port yuzu through MoltenVK: yuzu-emu/yuzu#3593 yuzu-emu/yuzu#4165.
Simple games work, although MoltenVK has some shortcomings that block it from running AAA games, but first I'd like to mention issues that have been fixed. The first one is the need to backport to Vulkan 1.0, now we only have to care about Vulkan 1.1. There were some SPIR-V -> MSL issues that have also been addressed: KhronosGroup/SPIRV-Cross#1332 KhronosGroup/SPIRV-Cross#1338. Thanks to the maintainers for that.
The last time it was tested, most non-trivial games didn't render properly due to the lack of arbitrary vertex buffer strides on Metal and by extension MoltenVK:
[mvk-error] VK_ERROR_INITIALIZATION_FAILED: Under Metal, vertex buffer strides must be aligned to four bytes.

There have been issues with image view swizzles (I don't have logs for these at the moment). We now use VK_KHR_timeline_semaphores for better resource management without a fallback. I plan to make VK_EXT_descriptor_indexing and VK_EXT_robustness2 (supported by MoltenVK) mandatory once the later is supported on Intel's proprietary stack.
We can address these issues from our application, it's an emulator after all. There's already code for emulating missing features on Vulkan, some MoltenVK specific fallbacks wouldn't hurt. That said, given this is a call for developer input, what we'd need for seamless MoltenVK integration:

Integrate the VK_KHR_timeline_semaphore compatiblity layer into MoltenVK.
Somehow emulate arbitrary vertex buffer strides. Maybe vertex pulling from TBOs in the vertex shader, I'd do something like that if I had to emulate this at an application level. This would give headaches if extended dynamic states have to be supported in the future.

And a lesser mention, as it's not required now but it will be relevant in the future:

Image and sampler indexing with VK_EXT_descriptor_indexing, or equivalent bindless functionality that allows combining images and samplers at runtime.

I Hope that this will work🤞🏻

I did a quick hack, trying to port my demoscene production "Aurora" on Mac using MoltenVK, but MoltenVK was not yet where it needed to be. I no longer have access to a Mac, so I don't know what the current status is.

We're currently using MoltenVK in development builds of Warzone 2100 to test the Vulkan backend on macOS.
(Currently, Warzone 2100's Vulkan backend requires Vulkan 1.0+ - the "Vulkan Portable Subset".)

We're using this in the new Ultra Engine software, primarily developed for VR projects in aerospace, defense, and games.

We over at [OpenMW](https://openmw.org) are investigating this Zink over MoltenVK as a way to work around macOS's deprecation of OpenGL. We've started adding new features and are running into OpenGL bugs in Apple's drivers so some features on our macOS build are disabled as certain extensions either don't work or not properly implemented.
Does anyone have any advice on how they setup Zink to on top of MoltenVK? Is anyone also using this setup?


Add LongTermRetentionBackups.json and update v5 readme

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@jianyexi could you take a look at the Lint error?

@jianyexi could you take a look at the Lint error?

@xaliciayang
seems the path $.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/locations/locationName/longTermRetentionServers/longTermRetentionServerName/longTermRetentionDatabases/longTermRetentionDatabaseName/longTermRetentionBackups/backupName"]
is defined multiple times  in the swaggers under the tag package-composite-v5

@xaliciayang
seems the path $.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/locations/locationName/longTermRetentionServers/longTermRetentionServerName/longTermRetentionDatabases/longTermRetentionDatabaseName/longTermRetentionBackups/backupName"]
is defined multiple times  in the swaggers under the tag package-composite-v5

What is your base api?
To speed up the review, make sure to push as your very first commit your base api as is (for example in your case I think is: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2020-08-01-preview/LongTermRetentionBackups.json) then a subsequent commit contains your updates, this way we can focus only on the changes made instead of the entire spec, since you already have the updated swagger, following this approach should be simple, create a new PR following this approach.


pressing back button twice on dark mode selection screen exits

open app in browser
go to settings
go to Select theme
press back button twice

What happens: app exits
What should happen: main screen should show. The app should exit on third back press

@om26er
I removed the setting part in the web version to change the theme and make it this way. @Mahad-10 showed me one similar example.
https://github.com/xconnio/wick-ui/assets/73787635/7e5cc51e-b56e-4740-8ad2-e8d9070ec86c


WPT test /webdriver/tests/bidi/input/perform_actions/invalid.py slow in CI and local

The test file contains 400 test and runs in 60sec on my CloudTop and timeout on CI as well, on WPT infra it run in 23sec so the test pass. We should find a way to either speed it up, split it or increase the timeout only for it.

Do you have logs which indicate why it is that slow on your CloudTop?

@whimboo it also times out for me locally for Firefox:
python3 ./wpt run --channel=nightly firefox webdriver/tests/bidi/input/perform_actions/invalid.py

Interestingly, setting the timeout multiplier to 1 makes it faster and finish in 7 sec:
python3 ./wpt run --channel=nightly firefox webdriver/tests/bidi/input/perform_actions/invalid.py --timeout-multiplier=1

Here are logs - https://gist.github.com/Lightning00Blade/715b201c0921841fd2d884b118fb8a43

Interesting there are around 100ms between each test. Formerly I found a bug with Chrome and Set Window Rect but that should be fixed via https://github.com/web-platform-tests/wpt/pull/43853. Maybe you could check with debug logs enabled?

@whimboo it also times out for me locally for Firefox:
python3 ./wpt run --channel=nightly firefox webdriver/tests/bidi/input/perform_actions/invalid.py

Interestingly, setting the timeout multiplier to 1 makes it faster and finish in 7 sec:
python3 ./wpt run --channel=nightly firefox webdriver/tests/bidi/input/perform_actions/invalid.py --timeout-multiplier=1

I don't see timeouts when checking the history on wpt.fyi.
Also running it locally it takes 12s whether which timeout multiplier is set - also note that it should not make a difference in runtime related to the value as set. Maybe run with --webdriver-arg=-vv to get trace logs which might indicate where that extra time is needed on your local machine.

So it looks like it is flaky, sometimes it ends within 7sec, sometimes times out after 30sec. Timing out log  https://gist.githubusercontent.com/OrKoN/79e9ba8995db27fbf51bfe71d6f9fc28/raw/e10ead37d89d7baee486d7f59e7fad8a2cbe5d46/gistfile1.txt

This is interesting:
 0:08.48 pid:43164<PHONE_NUMBER>009	webdriver::server	DEBUG	<- 200 OK {"value":["14d9c636-71b7-4acc-a1c5-2b31a627f25a"]}
 0:34.55 DEBUG Got command: 'log'
 0:34.55 INFO STDOUT: webdriver/tests/bidi/input/perform_actions/invalid.py::test_params_input_source_action_sequence_actions_actions_invalid_type[None-pointer]
 0:34.55 DEBUG Got command: 'log'
 0:34.55 INFO STDOUT: ERROR
 0:34.55 DEBUG Got command: 'log'
 0:34.55 INFO STDOUT: webdriver/tests/bidi/input/perform_actions/invalid.py::test_params_input_source_action_sequence_actions_actions_invalid_type[None-wheel]

Usually it should look like:
0:07.57 DEBUG Got command: 'log'
 0:07.57 INFO STDOUT: webdriver/tests/bidi/input/perform_actions/invalid.py::test_params_context_invalid_type[value3]
 0:07.57 pid:43164<PHONE_NUMBER>098	RemoteAgent	INFO	Perform WebSocket upgrade for incoming connection from <IP_ADDRESS>:58608

It's not clear to me what's going on at this point. Would you mind filing a bug for that so that we can track the work in Bugzilla? Also please mention how often this happens, and if that doesn't happen when you modify the timeout multiplier. Thanks.

@whimboo I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1882533

So If i comment out - https://github.com/web-platform-tests/wpt/blob/master/webdriver/tests/support/helpers.py#L54
The test run consistently in 12 sec, if I enable them they take around 45-60 sec.

So the fall where it fails is here - https://github.com/web-platform-tests/wpt/commit/d2b7ac0b46e174bf40d555781cb9fa7970b9d716#diff-5bca3d8b5c6c48d3020bc6bfcc2d5b6b95882e8c9de3fb35c237293d18b25ed5R67
is_maximized return true.
CC @nechaev-chromium let's chat offline

For the context:
The timeout mentioned earlier by Maxim is in [chrome_impl::SetWindowBounds].(https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/chromedriver/chrome/chrome_impl.cc;l=303;drc=644874afbd6aa7c5de82636ad52d6b298c34a458;bpv=1;bpt=1?q=SetWindowBounds&ss=chromium%2Fchromium%2Fsrc:chrome%2Ftest%2Fchromedriver%2F).
This is how the timeout appeared: chromedriver:2663.
Another bug report chromium:41403879 relates to the code below the timeout in question. The complaint was that due to window animations on MacOS the state did not change in time therefore causing flakiness.

This is now fixed by https://chromium-review.googlesource.com/c/chromium/src/+/5366899


Warnings on airy create for deprecated ingress resource

We need to migrate the ingress resources from extensiuons/v1beta1 to networking.k8s.io/v1.
This will be deprecated in Kubernetes 1.22 and is already causing warnings at airy create.

This is already fixed.


Memory properties for sw access

Added two new properties to the MemNode Component:

is_sw_writable used to determine if the memory is software writeable
is_sw_readable used to determine if the memory is software readable

Coverage decreased (-47.09%) to 47.236% when pulling d9ea8875847c2f26bdb1d9fd68ecda4dd43e880e on krcb197:master into 3875b9534b328b8c8347a7dacf623f7ff0ef08c5 on SystemRDL:master.


Adds tool to extract the model design

@benthomasson I struggle to understand the purpose of this. Can you please explain what problem we're trying to solve by moving model definitions into yaml?

@cutwater this allows me to generate diagrams like this:

We can also use this data to generate tests and validate that the implementation matches the design.


Please add qr code scanning animation....

@NAME-NikhilPatil Can add more details to this issue please?


Evolve task language

[ ] To align on bash behaviour, the -> operator will be renamed as &&.
[ ] Add a "on fail" operator ||, the next task will be executed if the current fails. Group success when the first task successes

Divided in 2 issues : #801 & #802


Add ponyfill for Object.assign

I run JS tests on phantomjs and phantom doesn't support Object.assign yet. This popular ponyfill fixes it.

lgtm

Thanks 💼

<EMAIL_ADDRESS>


using PyCall fail on master

If i try to use PyCall on 0.4 master is get the following error.
  _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.4.0-dev+7032 (2015-08-27 04:01 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 5d3ccd6 (0 days old master)
|__/                   |  x86_64-w64-mingw32

julia> using PyCall
WARNING: could not import Base.help into PyCall
WARNING: New definition
    call(Type{PyCall.PyDict}, Base.Associative{#K<:Any, Any}) at C:\Users\Hoegh\.julia\v0.4\PyCall\src\conversions.jl:464
is ambiguous with:
    call(Type{PyCall.PyDict}, Base.Associative{Any, #V<:Any}) at C:\Users\Hoegh\.julia\v0.4\PyCall\src\conversions.jl:463.
To fix, define
    call(Type{PyCall.PyDict}, Base.Associative{Any, Any})
before the new definition.
ERROR: LoadError: TypeError: apply_type: in first parameter of NTuple, expected Int64, got Type{Type{T}}
 in include at boot.jl:259
 in include_from_node1 at loading.jl:271
 in require at loading.jl:210
while loading C:\Users\Hoegh\.julia\v0.4\PyCall\src\PyCall.jl, in expression starting on line 381

julia>

I can't reproduce this anymore so I close this.

Whoops, 70232dabb57e5cd97efc1856d940a8eec3f8dfec applies to stevengj/PyPlot.jl#181, not this issue.


Question about multicodec header and object hash

I am wondering how to make sure we won't be changing every hash of every object once we switch from protobufs to ipld. We have the multicodec to handle that transition, but that doesn't work for hashing, becaue hash(protobuf) != hash(multicodec_header + protobuf).
In that case:

do we want to transfer the full object with the multicodec header, but when computing hash, ignore the header if it is pointing to the old protobuf format?
do we want to transfer the same object we have now, without the multicodec header (hashing is not changed) and detect when the header is absent and decode it as protobuf?

I'd lean towards the second solution, and this needs to be implemented (I can't see any hint on that being already implemented in the code). Or perhaps that shouldn't be implemented in go-ipld but rather in the caller package, when dealing with an error (header mismatch or something like that).
@jbenet, what do you think ? Do we need to implement a fallback mechanism? In go-ipld or elsewhere?

@mildred we can go with either,
i think the former case is nicer for the future, in that enforcing there always being a multicodec header is a good thing, instead of having to assume the old one if missing. makes parsers easier. we can leave the hashing part up to the datastructure (ipld) implementation to define, but the data on the wire would be nicely multicodec wrapped.
this may be relevant anyway if we ever want to add native support for reading objects from raw {git, bittorrent, bitcoin, tahoe lafs} objects. (when integrating with these other merkleized datastructures, "wrap them" or "implement native support" is a big debate, and i see the huge benefits and huge drawbacks of either)

for people wondering why keep the old protobuf support: it is not a good thing for a project purporting permanence to break these and make them no longer work. yes, it is very annoying to carry the legacy, but fortunately it's not very cumbersome.


fix issues caused by conflicting identifiers

fix https://github.com/SoySauceLab/CollectionKit/issues/85

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7769a1e). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master     #87   +/-   ##
========================================
  Coverage          ?   53.9%
========================================
  Files             ?      36
  Lines             ?    1037
  Branches          ?       0
========================================
  Hits              ?     559
  Misses            ?     478
  Partials          ?       0

Impacted Files
Coverage Δ

Sources/CollectionView.swift
95.7% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7769a1e...0114466. Read the comment docs.


Spec out the connection string for an open source cluster

Suggestion by Steve Lorello, please add info
Alternative endpoints are added as params
redis://redis-master-1:6379?endpoint=redis-master-2:6379&endpoint=redis-master-3:6379
for sentinel the name should also be added as a param


Initializing variable which may be used in an uninitialized fashion (closes #80)

Initializing variable which may be used in an uninitialized fashion as reported by the test case included in issue #80.
Using uninitialized memory can be a security issue, such as potentially leaking previous stack contents. By zero-initializing, we avoid such potential leaks.
Running with the specific input case after this PR is applied no longer results in any error findings (credits: the input case was found using google/clusterfuzz).
Note that this PR only avoids the uninitialized memory use identified in that bug, and is unaware of the functionality or semantics of the rest of the code. The file owners are welcome to suggest alternate fixes on this PR or address other behavioral concerns in a separate PR.
(For the record: I am currently a Visiting Researcher at Google NYC and this fix is the result of an internal project).

This is not the right fix.
If there is a problem with reading uninitialised data then this would be a problem in za_read_entry which should initialise all filesize amount of allocated bytes (and return an error if this wasn't possible).
Using calloc is solving the symptom, not the core problem.

Appropriate fix was implemented in 1d19ad61fd2011a54780335c896ceab4a7393cd3


feat: Added class to support huggingface text generation inference server

Text Generation Inference is a Rust, Python and gRPC server for generating text using LLMs.
This pull request add support for self hosted Text Generation Inference servers.
feature: #4280

@dcbark01 😃  coincidence
I've raised issue #4280 and also PR #4244 but then closed it and recreated this PR so that it'll not be lost in backlog.

@gsaivinay, awesome, I'm good with whatever is easiest. Thanks for working on this. It should make working with local LLMs a lot easier!

@dcbark01 I hope any of the maintainers check either of our PR and approve so that many of us can use this feature.

thanks @dev2049 , I've now updated accordingly.


self query + query constructor + json output parser + schema detector + fix opensearch + example semi structured rag

PR Checklist

[ ] Read the Contributing documentation.
[ ] Read the Code of conduct documentation.
[ ] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
[ ] Describes the source of new concepts.
[ ] References existing implementations as appropriate.
[ ] Contains test coverage for new functions.
[ ] Passes all golangci-lint checks.

where did I forget it?
If i split it, it will make the process very long as everything is dependent.

tried to rebase but i get some linting errors


Compiling HTTP2 with Javalin 5.6.1

Javalin version: 5.6.1
Jetty version: 9.4.43.v20210629 (I have tried newer versions)
Hello, I am trying to set up HTTP2 and TLS. I was following the example in your project here: https://github.com/tipsy/javalin-http2-example
Following the example, I get a compiler error for the missing method addConnector (cannot find symbol symbol:   method addConnector((server,ht[...]or; }). the ServerConnector constrictor also has a compiler error
I have tried moving to the newest version of Jetty and alpn, but this does not change the error. Interestingly if I go BACK to Javalin 4.0.0, I get even more compiler errors, and If I clone the javalin-http2-example project and run gradle I get a different gradle compiler error.
I threw this up in a simplified project here: https://github.com/ryber/javalin-question/tree/main/javalin-question
Is there a updated working version of this?
Javalin Config
public static void main(String[] args){
        Javalin app = Javalin.create(c -> {
            c.staticFiles.add("public/");
            c.jetty.addConnector((server, httpConfiguration) -> {
                var sslcf = new SslContextFactory.Server();
                sslcf.setKeyStorePath(Server.class.getResource("/keystore.jks").toExternalForm());
                sslcf.setKeyStorePassword("password");
                ServerConnector sslConnector = new ServerConnector(server, sslcf);
                sslConnector.setPort(443);
                return sslConnector;
            });
            c.jetty.addConnector((server, httpConfiguration) -> {
                ServerConnector connector = new ServerConnector(server);
                connector.setPort(80);
                return connector;
            });

        }).start(8080);
    }

Hi @ryber - the recommended way to handle HTTP2 is to use https://javalin.io/plugins/ssl-helpers :)

Ah yes, this is working much better, thank you. You might consider updating the documentation here which points to the older stuff: https://javalin.io/documentation#server-setup
Thank you for the quick response and excellent project!

Javalin version: 5.6.1 Jetty version: 9.4.43.v20210629 (I have tried newer versions)

Javalin 5 is Jetty 11.x compatible, it might just be the problem.
I'm the author of the javalin/javalin-ssl plugin, if you have any problem just open an issue on the repo, I'd be happy to help.

Thanks for your kind words @ryber, we'll be sure to update the docs soon :)


Prepare sample Chronomap DB

Looks good.
I did some work to normalize the naming conventions for tables/fields/settings:

Setting Keys: Capitalized_Snake_Case
Field names: lower_case_snake_case
Table names: TitleCase

There were also some small discrepencies between the bttf and aviation tables, which I fixed.


[Minor bug] Losing connection to Trezor after cancelling 'Change Pin' action

I just played around with Multibit and my Trezor (which by the way is the best combination for me right now!) and stumbled about the following behavior (a Trezor has to be connected):
1.) Go to "Manage Wallet", click "Change Pin".
2.) Select "Change an existing PIN or add a new PIN" and click "Next".
3.) A message appears on the Trezor asking if you want to change the PIN of the device.
4.) When you press the "Cancel" button on the Trezor, Multibit tells you it discovered a new Trezor.
Sometimes, after clicking "Yes" to use your Trezor, the Trezor gets re-initialized, sometimes it doesn't and you can use the wallet. I've tagged the issue with "Minor Bug" because the wallet continues to work with the Trezor, however I think it should not tell me about a new Trezor when I cancel an action on the device.

This is the MultiBit Classic issue database. I've moved your issue to Multibit HD #443 and closed this one to avoid confusion.


Can you provide the final model weights of descriptor track

thanks

Hi, I uploaded all our checkpoint to mi gdrive.


Experiments for running some more tests

Towards #17.  I don't have a Linux environment to test on, so I have to create a pull request to use the CI.  Not intended for review yet.

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I can run a bunch of SVGs from the source project through the test environment.  Some of them fail but conda build isn't seeing failed tests.

Hi @carlodri, I am pretty close to having a good test going (see the test logs here, only one test fails.  I have a clean commit at https://github.com/MutantPlatypus/cairosvg-feedstock/commit/255a2de010435d82130abb22e4eda1618d4cfac6), but I think the cssselect2 and defusedxml feedstocks need to be updated.
CairoSVG passed all of its tests at this tag, so I think the differences in dependency versions is to blame.  conda-forge is on cssselect2-0.2.1 but CairoSVG was tested against 0.2.2.  Same with defusedxml (0.5.0 vs 0.6.0).  cairocffi, cffi, and tinycss all seem to match up.  Reference line 563 of conda-forge build log and line 297 of CairoSVG's CI log.
defusedxml was updated three hours ago, so I'll just re-run this tomorrow, but I don't know who the appropriate contact is for cssselect2-feedstock:  There's no marked reviewers there.

Hi @MutantPlatypus sorro for the long silences. Two general points here:

the tests on conda feestocks need not to be exhaustive (e.g. you will not want to run a full test suite), so I leave you as a user to get a reasonable balance;

the maintainer of  https://github.com/conda-forge/cssselect2-feedstock/ is @johanneskoester (see https://github.com/conda-forge/cssselect2-feedstock/blob/9daef2fff3d927026461d2f1068af9af6bd3a493/recipe/meta.yaml#L48), maybe he can help with merging that PR. Maybe you can also volunteer as a maintainer for that feedstock.

I will review your the code with some comments in a moment...

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Login with web wallet to the settings #44

closes #44

I will add the styles as well

We would also need it here (it is more important)

and it does not look styled

@venimus https://github.com/aeternity/jitsi-meet/pull/70#issuecomment-654351090 I will add it today

We would also need it here (it is more important) -along with the I'm the host

@venimus It may be useful. But the problem that this button is not so secure as login with sdk. Maybe that's why we hide it to the settings.
@mradkov Also there will be a problem if user try to login with that button not from the room itself but from the room create screen. I will fix that later as well.

I was wrong at https://github.com/aeternity/jitsi-meet/pull/70#issuecomment-654789213 there is no any problem

@venimus hope this styles are fine

unfortunately still looks odd - too much padding at right and also the font is bigger.

@venimus what browser?

fixed that

unfortunately still looks odd - too much padding at right and also the font is bigger.

Strange that I don't have styles here. Maybe it's at other PR or reverted with force push

Yes, they are..


add a parent for estrogen and androgen biosynthetic processes?

GO:0006702 androgen biosynthetic process is "the chemical reactions and pathways resulting in the formation of androgens, C19 steroid hormones that can stimulate the development of male sexual characteristics, and GO:0006703 estrogen biosynthetic process is "The chemical reactions and pathways resulting in the formation of estrogens, C18 steroid hormones that can stimulate the development of female sexual characteristics", but neither term has  GO:0006694 steroid biosynthetic process as an is_a parent or other ancestor. (Meanwhile, GO:0006694 steroid biosynthetic process does have GO:0006700 C21-steroid hormone biosynthetic process as an is_a child, so it looks like this kind of parent - child relationship ought to be OK.
Without the added parentage, grouping androgen and estrogen synthetic pathways with ones for other steroid pathways conflicts with GO.
Thanks

https://github.com/ebi-chebi/ChEBI/issues/3257

I went ahead and asserted all the steroid parents for metabolism, biosynthesis and catabolism. At some point hopefully they will be inferred.


[Shattered Relics XP] Descriptive descriptions don't work with progress bar and xp turned off

This issue is for the external plugin: Shattered Relics XP
Plugin version: 1.7
The option "Descriptive Descriptions" under "Tooltip" only works if you have either "Show Progress Bar" or "Show XP" (or both) active, and doesn't work if you have both turned off.

ah good catch, forgot to include it in a function


test_style_aligned: switch to CLIP text batch API

Added in #263

test is still green ?

Yep, rye run pytest -k test_style_aligned -v gives:
tests/adapters/test_style_aligned_adapter.py::test_inject_eject_SharedSelfAttentionAdapter[1.0] PASSED                                                                                [ 14%]
tests/adapters/test_style_aligned_adapter.py::test_inject_eject_StyleAlignedAdapter[SD1UNet-1.0] PASSED                                                                                [ 28%]
tests/adapters/test_style_aligned_adapter.py::test_inject_eject_StyleAlignedAdapter[SD1UNet-100.0] PASSED                                                                                [ 42%]
tests/adapters/test_style_aligned_adapter.py::test_inject_eject_SharedSelfAttentionAdapter[100.0] PASSED                                                                                [ 57%]
tests/adapters/test_style_aligned_adapter.py::test_inject_eject_StyleAlignedAdapter[SDXLUNet-100.0] PASSED                                                                                [ 71%]
tests/adapters/test_style_aligned_adapter.py::test_inject_eject_StyleAlignedAdapter[SDXLUNet-1.0] PASSED                                                                                [ 85%]
tests/e2e/test_diffusion.py::test_style_aligned PASSED


Change requirement on pycrypto to pycryptodome

pycrypto isn't maintained, possibly has some exploits, and doesn't work
on python 3.8. pycryptodome is a maintained alternative that does.

#2 addressed this issue and created a PR.


audio: add offload underflow msg state

Note: Please adhere to Contributing Guidelines.
Summary

memdump: fix warnings.
audio: add offload underflow msg state

Impact
No
Testing
No

[Experimental Bot, please feedback here]
This PR does not meet the NuttX requirements.
Summary:

The summary is vague and lacks crucial information:

Why are these changes necessary? Are they bug fixes, optimizations, new features?
What specific warnings are being fixed in memdump?
How does the addition of the "offload underflow msg state" in audio work? What problem does it solve?

It lacks links to related NuttX issues or pull requests.

Impact:

Simply stating "No" for all impact points is insufficient.  Each point requires justification.

Even if there is no user-facing impact, the PR should explain why.
Does the "offload underflow msg state" affect any specific architectures, boards, or drivers?

Testing:

"No" is not an acceptable answer for testing.

The PR must include:

Details about the build host and target(s) used for testing.
Testing logs from before and after the changes to demonstrate the problem and the solution.

To improve this PR:

Provide a detailed summary explaining the purpose, functionality, and reasoning behind each change.
Address the impact section thoroughly. Justify each "No" and provide specific details for any "Yes."
Include thorough testing information.  List your testing environment and share logs demonstrating the changes.

By following the NuttX PR requirements and providing complete information, your contribution will be easier to review and merge.

Split to 2 PR, the others not audio


Fix typo in SolrContainer

There is a typo in SolrContainer. This PR fixes it.

Thanks for your contribution, @dajudge!


Need explanation about container lifecycle for graceful shutdown

Is there any doc/reference related to container lifecycle on Azure App Service/Functions? I am going to use Functions with docker container for production, so I have to implement graceful shutdown logic. But I cannot find any information about it.
Especially, I would like to understand the behavior when functions stop/restart by Azure portal/API. Does Functions control plane invoke docker stop command? How much time do we have before killing container by Functions control plane? docker default (10 seconds)?
FYI

Related issue
Good example (AWS ECS)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d505ab9-d351-6650-6d0c-bb65d2daa229
Version Independent ID: 2a1d3487-a93d-2206-7ef9-a91aa275ec4e
Content: Create Azure Functions on Linux using a custom image
Content Source: articles/azure-functions/functions-create-function-linux-custom-image.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@ToruMakabe Thank you for your feedback! We will review and update as appropriate.

@ToruMakabe If function host crashes, the container is killed immediately. However, you can check https://docs.microsoft.com/en-us/azure/azure-functions/functions-dotnet-class-library?tabs=v2%2Ccmd#cancellation-tokens (for in-process C#)

@JayaChatterjee-MSFT Thanks. It's an excellent opportunity for improvement. Please could you consider the following from docs point of view?
Clarify the behavior
Graceful shutdown is essential for maximizing robustness. If Azure App Service/Functions on docker would not send signals when stop/restart, docs should describe as a limitation. If I understood it in advance, I would not choose these products and not waste time for evaluation. Or consider crash-only design.
Specify the environment in which CancellationToken can be used
In my understanding, the IIS in-process hosting model should only be used in a limited environment. Maybe only non-docker, Windows/ASP .NET Core model. Many users do not understand the in-process model due to a lack of docs related to the internal design of these products, at least I can not find it. Please explain using terms that are easy for users to understand.  (e.g. OS, Docker/non-docker, language)
I think these products should send signals before stop/restart, giving feedback to a person in charge.

@ToruMakabe Thank you for the feedback.
@ggailey777 Could you please look into it?

@JayaChatterjee-MSFT @ggailey777 Any updates? FYI, AWS has published a new excellent article related to this topic. I believe many developers are interested in how to design and implement it.

Same issue here. I have a python function which makes a snowflake db connection. I don't want to create connection for each function call. Also, I want to make sure connection is closed before the function app is teared down. I see some capability from python extension but nothing related to tear down task. Would be great if someone provides insight on it.

I got info from the MS Azure team, that this is a bug in Azure, which will be fixed, but it seems that is not fixed yet.
I did not get a ETA when it should be fixed.

Our team would really appreciate some documentation on this as well. From some limited testing, it seems like App Service attempts to gracefully shutdown the container, and waits about 5 seconds before killing the container. It's difficult to depend on this though since it's not actually a documented behavior.
Also any kind of configuration on this shutdown timeout would also be really helpful.


mirage-server: use a block device, fix compilation

Thanks! This looks good to me. The config reading code is the same as in e.g. mirage-router.
FWIW I got an unrelated error when trying to build mirage-server for hvt. The CI builds successfully so I will merge.
Error details

The error seems related to libgmp and/or glibc:
```
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/12/../../../x86_64-linux-gnu/libgmp.a(assert.o): in function `__gmp_assert_header':
(.text+0x2c): undefined reference to `__fprintf_chk'
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/12/../../../x86_64-linux-gnu/libgmp.a(assert.o): in function `__gmp_assert_fail':
(.text+0x82): undefined reference to `__fprintf_chk'
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/12/../../../x86_64-linux-gnu/libgmp.a(assert.o): in function `__gmp_assert_header':
(.text+0x59): undefined reference to `__fprintf_chk'
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/12/../../../x86_64-linux-gnu/libgmp.a(memory.o): in function `__gmp_default_allocate':
(.text+0x27): undefined reference to `__fprintf_chk'
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/12/../../../x86_64-linux-gnu/libgmp.a(memory.o): in function `__gmp_default_reallocate':
(.text+0x7a): undefined reference to `__fprintf_chk'
collect2: error: ld returned 1 exit status
File "caml_startup", line 1:
Error: Error during linking (exit code 1)
make[1]: *** [Makefile:56: build] Error 1
make: *** [Makefile:11: all] Error 2
```

Ok, I can build if I remove --profile release from the dune build invocation.

To me your error looks like something had a bad day.. the gmp should be used from somewhere with solo5... removing _build may help? if you're using the dune cache, disabling / emptying it may help..


[BUG] Rancher v2.6.11 w/ RKE1 Kubernetes Version: v1.23.16 -Fails Install Harvester Cloud-Provider

Describe the bug
Rancher v2.6.11 that has a Harvester v1.1.2-rc3 cluster imported.
Fails to install the harvester-cloud-provider chart in RKE1 v1.23.16 3 node cluster.
To Reproduce
Steps to reproduce the behavior:

Import Harvester into Rancher v2.6.11
Create RKE1 v1.23.16 Cluster
Attempt to install Harvester Cloud-Provider

Expected behavior
That Harvester Cloud Provider would install and not timeout.
Attempted Workarounds

Attempted to change the Server Version on Harvester Cluster from v1.1.2-rc3 to v1.1.2 - then re-attempt to install harvester-cloud-provider, but with no success

Environment

Harvester ISO version: v1.1.2-rc3
Rancher: v2.6.11
RKE1: v1.23.16
Underlying Infrastructure: bare-metal

Additional context

Harvester-CSI-Driver also failing:

...
spec:
  ...
  rancherKubernetesEngineConfig:
    addonJobTimeout: 45
    authentication:
      strategy: x509|webhook
    authorization: {}
    bastionHost: {}
    cloudProvider: {}
    ...

By checking the RKE cluster YAML, we found the cloud provider is empty.
If we want to use the Harvester cloud provider, we have to select Harvester(out-of-tree) when creating RKE. Refer to
https://docs.harvesterhci.io/dev/rancher/cloud-provider#deploying-to-the-rke1-cluster-with-harvester-node-driver

@yaocw2020 thank you for looking into this - I will go ahead and close this out :smile: :+1:


Documentation fix for post_transaction

Please ignore the branch name. It is unrelated to this fix.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.064%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9382

Relevant Lines:
10776

💛  - Coveralls


Warning (comp): base16-theme-pkg.el:7:1: Warning: the function ‘define-package’ is not known

Emacs 28.0.50 native-comp branch. This was my use-package declaration
(use-package base16-theme
  :straight t
  :config
  (setq base16-highlight-mode-line t)
  (load-theme 'base16-grayscale-light))

Are you still having this issue? I seem to remember trying this out with native-comp a while back and it working fine.

I'm closing this for inactivity, but if you're still seeing issues, please let us know!


Update snowflake-snowsql to 1.1.22

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Let me know any requirement is missing.

Thanks!


Add code coverage reporting to CI.yml

Towards addressing https://github.com/Herb-AI/Herb.jl/issues/60

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Intermittent type errors when opening or editing files with typescript 3.7

VSCode Version: 1.40.0 (and 1.39.2)
OS Version: Kubuntu 18.04

Steps to Reproduce:

git clone -b refactor/ts37 https://github.com/vuetifyjs/vuetify.git,  run yarn && yarn build, then open it in vscode
Open VTreeView.ts and VtreeViewNode.ts
Reload the window, wait for the language server to start then switch to the other open file
When the errors appear, make a small edit, save the file, then undo it

Video demonstrating the problem
And anotha one
This doesn't seem to occur with ts 3.5 (master branch)

Does this issue occur when all extensions are disabled?: Yes

Confirmed with TS 3.8.0-dev.20191105. Does not depend on VS Code version and does not happen with TS 3.6.3

Is this a composite project?

Okay, I feel like this is probably the most relevant issue,
https://github.com/microsoft/TypeScript/issues/33067

Yep, it works fine when you build it. Those related issues look a lot like this other problem I had a while ago, where recursive types worked in vscode but were never in tsc: https://github.com/microsoft/TypeScript/issues/23897#issuecomment-417872711


reveal-md: init at 5.2.0

Signed-off-by: Mark Sagi-Kazar<EMAIL_ADDRESS>
Motivation for this change
Build reveal.js slides from markdown.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@jonringer interesting, thanks for pointing that out.
I looked at other examples and went with an existing solution that the mermaid-js package uses as well.
Chromium is not supported on Darwin, so I disabled downloading on every other platform.
Let me know if it's not the right solution.
Thanks again!

and the node conflicts begin :(
CONFLICT (content): Merge conflict in pkgs/development/node-packages/node-packages.nix
Auto-merging pkgs/development/node-packages/node-packages.json
Automatic merge failed; fix conflicts and then commit the result.
https://github.com/NixOS/nixpkgs/pull/144918 failed to build

I'm already rebasing it for like the 10th time now to resolve conflicts, but running the generate script takes like 2 hours every time. :)

I'm already rebasing it for like the 10th time now to resolve conflicts, but running the generate script takes like 2 hours every time. :)

We can also be sneaky and merge it without updating that file and let someone else do it.

@jonringer @SuperSandro2000 Rebase finally completed.

other updates to node packages keep causing regressions....

unrelated regression fix: #146166

Thanks a lot for your help to get this merged!

yea. node package within nix is not the greatest maintainer experience


Error: Code=InvalidTemplateDeployment

I'm getting error, I tried to create storage account with this name from portal and it work ok but it doesn't work with ARM template deployment. I also tried to latest schema and same error.
New-AzResourceGroupDeployment: 12:24:23 PM - Error: Code=InvalidTemplateDeployment; Message=The template deployment 'addstorage' is not valid according to the validation procedure. The tracking id is 'cce87a1d-3182-4ae3-93e3-5c5d38361440'. See inner errors for details.
New-AzResourceGroupDeployment: 12:24:23 PM - Error: Code=PreflightValidationCheckFailed; Message=Preflight validation failed. Please refer to the details for the specific errors.
New-AzResourceGroupDeployment: 12:24:23 PM - Error: Code=AccountNameInvalid; Message={ournewteststor99} is not a valid storage account name. Storage account name must be between 3 and 24 characters in length and use numbers and lower-case letters only.
New-AzResourceGroupDeployment: The deployment validation failed
PS C:\Users\elvir\Google Drive\AZURE\OurSolution\oursolution> New-AzResourceGroupDeployment     -Name addstorage
-ResourceGroupName myResourceGroup `
-TemplateFile $templateFile
New-AzResourceGroupDeployment: 12:26:05 PM - Error: Code=InvalidTemplateDeployment; Message=The template deployment 'addstorage' is not valid according to the validation procedure. The tracking id is 'bd6e5fe6-ef5d-4af0-9fa5-143eff93573c'. See inner errors for details.
New-AzResourceGroupDeployment: 12:26:05 PM - Error: Code=PreflightValidationCheckFailed; Message=Preflight validation failed. Please refer to the details for the specific errors.
New-AzResourceGroupDeployment: 12:26:05 PM - Error: Code=AccountNameInvalid; Message={oureknewteststor99} is not a valid storage account name. Storage account name must be between 3 and 24 characters in length and use numbers and lower-case letters only.
New-AzResourceGroupDeployment: The deployment validation failed
PS C:\Users\elvir\Google Drive\AZURE\OurSolution\oursolution> New-AzResourceGroupDeployment     -Name addstorage
-ResourceGroupName myResourceGroup `
-TemplateFile $templateFile
New-AzResourceGroupDeployment: 12:26:45 PM - Error: Code=InvalidTemplateDeployment; Message=The template deployment 'addstorage' is not valid according to the validation procedure. The tracking id is '86897a60-2aa1-4964-be32-d33ccbc31f20'. See inner errors for details.
New-AzResourceGroupDeployment: 12:26:45 PM - Error: Code=PreflightValidationCheckFailed; Message=Preflight validation failed. Please refer to the details for the specific errors.
New-AzResourceGroupDeployment: 12:26:45 PM - Error: Code=AccountNameInvalid; Message={ekoureknewteststor99} is not a valid storage account name. Storage account name must be between 3 and 24 characters in length and use numbers and lower-case letters only.
New-AzResourceGroupDeployment: The deployment validation failed
PS C:\Users\elvir\Google Drive\AZURE\OurSolution\oursolution> New-AzResourceGroupDeployment     -Name addstorage
-ResourceGroupName myResourceGroup `
-TemplateFile $templateFile
New-AzResourceGroupDeployment: 12:30:14 PM - Error: Code=InvalidTemplateDeployment; Message=The template deployment 'addstorage' is not valid according to the validation procedure. The tracking id is 'e0edbdcc-3bd5-488d-836c-f94a206b7412'. See inner errors for details.
New-AzResourceGroupDeployment: 12:30:14 PM - Error: Code=PreflightValidationCheckFailed; Message=Preflight validation failed. Please refer to the details for the specific errors.
New-AzResourceGroupDeployment: 12:30:14 PM - Error: Code=AccountNameInvalid; Message={ekoureknewteststor99} is not a valid storage account name. Storage account name must be between 3 and 24 characters in length and use numbers and lower-case letters only.
New-AzResourceGroupDeployment: The deployment validation failed
{
"$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
"contentVersion": "<IP_ADDRESS>",
"resources": [
{
"type": "Microsoft.Storage/storageAccounts",
"apiVersion": "2019-06-01",
"name": "{ekoureknewteststor99}",
"location": "eastus",
"sku": {
"name": "Standard_LRS"
},
"kind": "StorageV2",
"properties": {
"supportsHttpsTrafficOnly":true
}
}
]
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 999c1308-1285-7bc6-06aa-a83b7266e0e9
Version Independent ID: cbf8c7f4-d9bd-929f-626f-b65e2f37f896
Content: Tutorial - Add resource to template - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/template-tutorial-add-resource.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

@elvirk Thanks for the feedback! We are currently investigating and will update you shortly.

@elvirk - The problem is with the storage account name.  The error is "Storage account name must be between 3 and 24 characters in length and use numbers and lower-case letters only." See the second paragraph in the Add resource section for the instructions. I will make it as a note so it is harder to miss. The Deploy template section also lists the error message.

Thx

thank you guys link

Hi I'm also encountering similar error ##[error]2:56:36 PM - Error: Code=InvalidTemplateDeployment; Message=The template deployment
When I tried my template directly on the portal it will succeed but when I tried it on the Azure Devops pipeline it will fail with the error above.
"resources": [
{
"type": "Microsoft.Storage/storageAccounts",
"apiVersion": "2021-09-01",
"name": "c20optimportde2",
"location": "eastus",
"kind": "Storage",
"sku": {
"name": "[parameters('storageAccountType')]"
}


Support for on-site storage copy commands

Is it possible to use duplicacy-util to perform the actions for copying backups from onsite storage to a cloud provider? From what I can tell, you can't currently run a copy command without also running a backup to a specified storage. See https://forum.duplicacy.com/t/back-up-to-multiple-storages/1075:

It is also possible to run the copy command directly on your onsite storage server. All you need to do is to create a dummy repository there, and then initialize it with the same default storage (but as a local disk) and add the same additional storage:
Copy to clipboard
log in to your local storage server
mkdir -p \path\to\dummy\repository
cd \path\to\dummy\repository
duplicacy init repository_id onsite_storage_url
duplicacy add -copy default offsite_storage --bit-identical repository_id offsite_storage_url
duplicacy copy -from default -to offsite_storage
This not only frees your work computer from running the copy command, but also speeds up the copy process, since now Duplicacy can read chunks from a local disk
(local_server -> router -> offsite_storage)
instead of over the network
(local server -> router -> your computer -> router -> offsite_storage).

No, that's not true. Please carefully review the README.md file. If you look at the Command Line Usage, you'll note that duplicacy-util does support the -copy qualifier to just perform a copy operation.
Let me know if you have further questions, @akirusk. Otherwise, feel free to close this issue. Thanks!

I think my confusion was in the local config file requiring a storage to be specified. Does seem to work fine using -copy with a filler for storage in the config, thanks for your assistance.


Fix the output of the boolean knob

Issue: While doing some work on fixing an issue with the button knob discussed on Slack, I found out that the boolean knob's behaviour was also kind of broken: after the initial toggle the value of the knob would always return undefined. This was due to the incoming change object at https://github.com/storybooks/storybook/blob/master/addons/knobs/src/registerKnobs.js#L18 always being of the form: {name: "name-of-knob", type: "boolean"}, without a value. Easiest reproducible by adding a story with a boolean knob and just printing out its direct value.
What I did
Change the behaviour when the incoming change object is of type boolean, to flip the current value.

I would prefer to fix this part

The previous implementation used a ref in the input element and tried to access the value that way. That didn't work, so I removed the ref and used the event.target.checked value instead. Reverted the previous changes and seemed to work.
Linter warned that the components should be written as a pure function, so I assumed this was the way. If not, please let me know.

@wuweiweiwu please review again

@Keraito boolean knob seems to work OK on release branch, so I removed the patch label
https://release-3-4--storybooks-official.netlify.com/?knob-Dollars=12.5&knob-Name=Storyteller&knob-Years in NY=9&knob-background=%23ffff00&knob-Age=70&knob-Items[0]=Laptop&knob-Items[1]=Book&knob-Items[2]=Whiskey&knob-Other Fruit=lime&knob-Birthday=1484870400000&knob-Nice=true&knob-Styles={"border"%3A"3px solid %23ff00ff"%2C"padding"%3A"10px"}&knob-Fruit=apple&selectedKind=Addons|Knobs.withKnobs&selectedStory=tweaks static values&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs

Released as 4.0.0-alpha.8


docs(readme): Remove outdated examples

Summary
Accounts that do not exist or do not use Readme Typing SVG will be removed.
Type of change

[ ] Bug fix (added a non-breaking change which fixes an issue)
[ ] New feature (added a non-breaking change which adds functionality)
[x] Updated documentation the readme, templates, or other repo files)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[ ] Ran tests with composer test
[ ] Added or updated test cases to test new features

@Krishnapro @notauserx @krshkun
Hi, I noticed you are no longer using Typing SVG on your profiles and you are currently included in the examples.
I will be removing the examples that don't use Typing SVGs. Feel free to create a new pull request in the future if you decide to add it back.
Thanks!


Can't find keyplane that supports type 5 for keyboard

Hello,
I am seeing strange warning in my terminal logs while running my app with Keyboard plugin installed.
Can't find keyplane that supports type 5 for keyboard iPhone-PortraitTruffle-PhonePad; using<PHONE_NUMBER>_PortraitTruffle_iPhone-Complex-Pad_Default
It happends when I tap onto my input field type='tel' the number pad opens and app works fine but I thought I would ask.
Any idea what it means?
Thanks a lot.

From what I can tell it seems to be an XCode or iOS Simulator bug.

Hi,
this is happening for me too and the keyboard takes a while to show up.

If you guys remove the plugin does the error go away?

No it doesn't.

So then it's not a keyboard plugin issue :)

I also realized the bug wasn't introduced by the plugin update but it definitely didn't happen before.
Any idea on getting this fixed?

Make sure iOS Simulator -> Hardware -> Keyboard -> Connect Hardware Keyboard is not checked.

That did it, thanks a lot. I must have enable it doing some testing before and couldn't figure out it was the cause. Cheers!

I'm seeing this on the device itself (an iPhone 6), not the simulator.

Seeing this on an iPhone 7

Also seeing this on an iPhone 7 device. Not just an emulator issue. Any ideas anyone??

Iphone 7 too

It's only warning, We can don't care。

Same issue on iPhone 7 Plus

also iphone x


Bug: table can't be deleted when it has more than one colspan rows

Lexical version: 0.16.1
Steps To Reproduce
Sample Table

Colspan row 1

Cell a

Cell b

Cell c

Cell d

Colspan row 2

Visit https://playground.lexical.dev/
Copy and paste the above sample table.
Select the table by pressing Cmd+A
Press Backspace to delete the selected table.

The current behavior
Clears the table cells
https://github.com/user-attachments/assets/47a8f27b-ec43-4864-98b1-73af52fae8cd
The expected behavior
Deletes the selected content (the table).

I tried to reproduce this and I think the problem actually occurs if the last row has a merged table cell (no matter how many merged cells there are).
Also the selection has to include only the table (usually you have a paragraph before/after).
Then I can also reproduce it without copying from your issue.

No longer reproducible with recent table refactoring


Add getting started section to ReadME

README Update
Please add a getting started section to the README so people know how to start with this project.

Added Getting Started section in README file.


Some sets in the selection menu are hidden

For small screens and large selections of sets, the width of the selectable sets exceeds the browser window and there is no visual clue that more sets are available.

@flekschas - which OS/Browser is that?

Google Chrome 44 running on OS X 10.8.5

There are two little arrows below the "sort sets" caption. I didn't remember them either though...  It would be better if they were at the far right/left of the set list.

Ah I haven't seen them before. Thanks! At first I thought the list of visible sets is only accessible be making the window larger. Since this it is possible I'll close the issue.


[[FEAT]] config file extension: expand tilde

This patch allows me to use "~/" in configuration's "extends" option.
For example:
{
"extends": "~/.jshintrc",
...
}

Coverage remained the same at 96.53% when pulling 86e7d7d20649921242b7b4924f9490edfc1217f0 on gurdiga:tilde-expansion into e22b21a7bfeed9d1e38d0ed578c787aa9276690b on jshint:master.

Coverage remained the same at 96.53% when pulling 6355a184226acec02c05ff206b3d566ebd6c9cea on gurdiga:tilde-expansion into e22b21a7bfeed9d1e38d0ed578c787aa9276690b on jshint:master.

Just in case, I will elaborate a bit on the reasoning behind this change.
The first thing that came to mind when I found about the extends option was:

— Oh, that’s cool! I can have a base ~/.jshintrc, and then add tweaks for every (part of) project! For example I have different needs for Node code and browser code.

And then I found that jshint reads ~/literally.
So, what do you guys think?

Two thoughts:

The tilde does not behave this way on all platforms (I'm thinking of Windows specifically). Introducing the *nix semantics here may be surprising for some users
This use case quickly falls apart for distributed teams where it will be difficult to synchronize an externally-managed configuration file. I think this is potentially pernicious even for personal use. For instance, my own linting preferences have changed over time, but I do still return to old projects now and then. It would be frustrating to begin working on an old project only to find that it no longer passed its own linting checks because my global configuration changed.

OK, makes sense. I didn’t think about it that deep, sorry. :)

No apology necessary. I appreciate the effort!


BUG: Improve footer UI in dark mode

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Many elements in footer are not seen in dark mode.
Also the colour of social media icons does not match with the website's UI.

I want to work on this. @huamanraj @anuragverma108 Please assign this to me under GSSoC'24.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

i can totally help with that, make the UI more appealing and add animations, and some interactive codepen elements can also be added

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Many elements in footer are not seen in dark mode.
Also the colour of social media icons does not match with the website's UI.

I want to work on this. @huamanraj @anuragverma108 Please assign this to me under GSSoC'24.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

assigned! tag me when you create a PR!


Create transformers for hyper-spectral data

Task to do
Migrate TERRA REF extractors to AgPipeline transformers to process hyper-spectral data, add plot clipping https://github.com/terraref/computing-pipeline/issues/606
Reason
Adding another sensor processing pipeline
Result
Able to process hyper-spectral data

https://github.com/AgPipeline/AgPipeline.github.io/pull/2


Fix to upload configuration

This fix the issue regarding always uploading the package even when the user sets the environment variable CONAN_UPLOAD to "False"

Great, thanks! @raulbocanegra


support "verbs;ofi_rxm" libfabric provider

This allows Mercury to be initialized with "verbs;ofi_rxm" provider combination in addition to the base "verbs" provider.  The former uses a utility provider (ofi_rxm) to implements the RDM endpoint type over the MSG endpoint type of the underlying verbs provider.  This is anticipated to be more stable and performant than the base verbs provider in the long run.
Retains the same flags/options as the existing verbs provider path, but (for now at least) does not mutex lock API calls until we determine if that's needed or not.

Merged in caaaac3


typeahead drop-down li items unreadable under angularjs-1.20rc1

I am developing an application that until today used angularjs 1.1.5 and ui-bootstrap-tpls-0.4.0
The screenshot image typeahead-115.png shows how the drop-down menu looks under 1.1.5
I upgraded to 1.20rc and now the li items are unreadable (shown in typeahead-120rc1.png)
I then upgraded to ui-bootstrap-tpls-0.5.0 but the problem persists
Can anyone else recreate this?
I am using this code
                    <input type="text"
                           required="true"
                           class="input-xxlarge"
                           autocomplete="off"
                           ng-model="lineitem.description"
                           ng-change="lineitem_changed(lineitem)"
                           title="Description of commodities"
                           typeahead-min-length="-1"
                           typeahead="item as item.description for item in commodity_list | filter:$viewValue"

HI @bkc @pderksen @pkozlowski-opensource  @duncanbeevers  @miketierney , I would like to know if this issue is fixed. I am using Angular 1.5.6 and  get the same error as described above. Its pretty frustrating to also have no proper documentation around this :( Please let me know if there is a fix. I cant downgrade my Angular since i need routing and others which arent available in previous versions.
Thanks in advance,
Pruthvi

@PruthviKumarBK, if this is still an issue for you, please create a new issue making sure you follow the instructions in the issue template.  Thanks.


put intermediate datafiles in a separate directory

CAD_to_OpenMC creates a lot of datafiles along the way - these should be put in a separate directory which can be easily deleted should one want to.

Done!


Allow custom migration resolver to access SQL migration executor

Hi!
I apologize if it's a solved a problem
we have fixes script structure. Example:
20141201/1_update.sql
20141201/2_update.sql
20141202/1_update.sql
..

So we need the possibility to resolve migration info other way instead of MigrationInfoHelper
Or
override SqlMigrationResolver or implement MigrationResolver
I look after to implement custom migration resolver, but it can't access the parameterized objects (dbSupport, locations, ...)
Is there a way to override SqlMigrationResolver or implement MigrationResolver and access the configured object?
I'm sorry but I could not find any examples

Thanks in advance,
Attila

Solved as we allow providing your own MigrationResolver


figure out dependency pinning strategy

suggestion:

another PR to reduce size of requirements.txt
if still needed switch to poetry or something else

Originally posted by @Remi-Gau in https://github.com/neurobagel/api/issues/104#issuecomment-1544442863

for apps we may want to pin if not all at least many dependencies (not just the direct ones)
for libraries we may want to only pin our direct dependencies

As a first approach we can in any case trim down our requirements.txt to the minimum and then either keep it that way or freeze all our dependencies depending on what we decide.

Maybe this issue should be moved to the project level as it may apply to several repos

see also https://github.com/neurobagel/project/issues/73


pin last known good pywin32

Workaround for #8573

Can one of the admins verify this patch?

Closing to retarget branch


Breakpoint options

Like in slick slider, you can change the options at certain breakpoints. I'm just wondering if this functionality is available for this plugin and how I would go about implementing it. Thanks

Is not available for lory, lory is a lot lighter than slick. So if you nedd a lot more configuration, lory is probably not the right slider for this.
cheers Max

Still not possible?


Move db record models out of programdb into respective packages

Describe the chore that needs to be addressed.
Each of the files in the ramstk.models.programdb package need to be moved to their respective ramstk.models. package as record.py.
The class in each file needs to be renamed RAMSTKRecord.
Update init.py and any table or view models that import the record.
Update test files to import the new class name.

[X] This issue is an epic issue which subsumes the following:
#685
#687
#689
#691
#693
#695
#697

Moving record and table from ramstk.models.programdb and ramstk.controllers respectively is easier done together.  Issue #699 covers both. Closing this issue as a duplicate of #699.


Pre-built Extension Not Working

At the moment, when running in a Jupyter Notebook I get the following errors after running each cell:
from panel import extension
extension()

In Jupyter Notebook

VM600:131 Uncaught TypeError: Cannot read properties of undefined (reading 'set_log_level')
    at inline_js (eval at append_javascript (outputarea.js:765), :131:13)
    at run_inline_js (eval at append_javascript (outputarea.js:765), :9053:22)
    at eval (eval at append_javascript (outputarea.js:765), :9068:7)
    at eval (eval at append_javascript (outputarea.js:765), :23:11)
    at Array.forEach ()
    at run_callbacks (eval at append_javascript (outputarea.js:765), :21:36)
    at HTMLLinkElement.on_load (eval at append_javascript (outputarea.js:765), :51:9)

In Jupyter Lab

This doesn't result in an error. Instead Bokeh logs:
[bokeh] setting log level to: 'info'
Upon opening the page though there's a 404 when trying to load a Jupyter Lab extension:

This seems like something's going wrong when setting up Panel. Maybe that's causing the error below?
import idom
from idom_bokeh import IDOM

@idom.component
def Demo():
    return idom.html.h1("hello")

IDOM(Demo)

In Jupyter Notebook

bokeh-2.4.2.min.js:166 Uncaught Error: Model 'IDOM' does not exist. This could be due to a widget or a custom model not being registered before first usage.
    at _.get (bokeh-2.4.2.min.js:166)
    at Function._instantiate_object (bokeh-2.4.2.min.js:165)
    at Function._instantiate_references_json (bokeh-2.4.2.min.js:165)
    at Function.from_json (bokeh-2.4.2.min.js:165)
    at Object.t.embed_items_notebook (bokeh-2.4.2.min.js:591)
    at embed_document (:5:22)
    at :8:5
    at :24:3
    at eval (eval at append_javascript (outputarea.js:765), :138:28)
    at Array.forEach ()

In Jupyter Lab

Same as for the Notebook

The latter error is odd because I'm calling register_models([IDOMView]). Maybe it's getting registered under the wrong name? Even that seems unlikely though, because in the JS bundle generated by bokeh build I can see some "IDOM" string literals.

For the jupyter lab 404 you should be able to get it work by running jupyter serverextension enable panel.io.jupyter_server_extension. An issue is created here https://github.com/holoviz/panel/issues/3051 to make this command redundant.


Export ZendeskFlutter Style

As a developer I should be able to import ZendeskFlutterStyle from the package, without importing any other files.
Acceptance criteria

Create a ZendeskFlutterStyle object just importing zendesk_flutter package.

Deprecated by Style lib


Rationalise percentile methods

The _percentile function that iris.analysis.PERCENTILE is based on allows the keyword fast_percentile_method so that np.percentile may be used in place of scipy.mstats.mquantiles.  However, this option does not appear in the documentation for iris.analysis.PERCENTILE.  [Addresssed in #3901]
Also, is there any reason why the _percentile function and PERCENTILE aggregator shouldn't allow passing of **kwargs to np.percentile if this option is chosen?  If implemented, this would allow users to specify an interpolation method in np.percentile. [Addressed in #4791]

Stylistically, would it be cleaner to allow passing all kwargs, to filter passed kwargs, or to manually expose the desired functionality by manually supporting and passing the specific argument?
It's been so long since I coded with others, that I honestly don't remember at all.

It's probably just due to ignorance / oversight at the time of putting PERCENTILE together... Have you tried just passing the kwarg and seeing what happens? If it all just works then a quick docs update would be great, and if it doesn't and you feel like tackling the error (for example, the return type / shape / other from the NumPy functionality may not match what's expected by Iris) then that's also most welcome, of course 👍

I should probably add, this was prompted by a question on our internal Yammer.  The user specifically wanted to use "nearest" interpolation method, which does not appear to be available with scipy.mstats.mquantiles, but is available in np.percentile.

Have you tried just passing the kwarg and seeing what happens?

I guess you mean the fast_percentile_method kwarg?  No I haven't, but I'd be willing to bet that you're right and it just works.  Any thoughts on additional passing of the interpolation kwarg?  As @mo-g points out, the right way to do that is not trivially obvious.  It also occurs to me that we have 3 methods that do very similar things and we don't want to confuse users more than necessary:

PERCENTILE with fast_percentile_method kwarg: fastest but does not handle weights or masked data.
straight PERCENTILE: slower but handles masked data.
WPERCENTILE: (probably) slowest but handles both masked data and weights.

You might just be able to pass interpolation='nearest', but I'm much less convinced that will work as expected!
Sometime, a bunch of people sitting down and looking very hard at the aggregators would be a really good idea. In particular it would be good to look at percentile because it necessarily doesn't work quite the same as the other aggregators, and there are now three very similar aggregators that we might be able to bring together to some extent...

Percentile, WPercentile and ...?

@rcomer  we have 3 methods that do very similar things  ...

PERCENTILE with fast_percentile_method ... not handle weights or masked data.
straight PERCENTILE ... handles masked data.
WPERCENTILE ... handles both masked data and weights.

Well I hadn't grasped that : That's a really nice simple description :1st_place_medal:
So, if those different scopes are determined entirely by the keyword usage, and the results are equivalent where the scopes overlap, then that sounds like a really easy win waiting to happen ...
Does your understanding support that possibility ?

if those different scopes are determined entirely by the keyword usage

keywords are:

PERCENTILE with fast_percentile_method: use interpolate kwarg
straight PERCENTILE: use alphap and betap kwargs
WPERCENTILE: use kind kwarg.

the results are equivalent where the scopes overlap

No idea, and it might be a reasonable amount of work to test since there are several permutations.  OTOH, in all three cases we are ultimately leaving it to a numpy or scipy function, so it seems reasonable to me to just reference said function in the docs so that the user can verify whether it really does what they require.

Stylistically, would it be cleaner to allow passing all kwargs, to filter passed kwargs, or to manually expose the desired functionality by manually supporting and passing the specific argument?

Matplotlib style is to pass all kwargs to possibly multiple underlying routines, try to have different keywords to adjust different aspects, and each routine just ignores what it doesn't recognise.
The problem with that style is that there is no validity checking : a miss-spelled keyword causes no warning or error.
Another way is to package kwargs in dictionary keywords, e.g. percentile_kwargs=dict(nearest=True).  More flexible but not neat for user code.
What Iris does (?mostly) is to name and document the supported keys at the top level.
Which has the benefit of clarity, but means Iris doesn't automatically support underlying options, especially if they evolve with time.

To add to the mix, as noted at https://github.com/SciTools/iris/pull/3901#discussion_r593093437 there is also a numpy.nanpercentile.  This could give us a method for masked arrays that is equivalent to our current "fast percentile method" in terms of calling sequence.

Updated title to reflect the wider issues in this discussion.

@pp-mo  Matplotlib style is to pass all kwargs to possibly multiple underlying routines, try to have different keywords to adjust different aspects (e.g. 'markeredgecolor', 'markeredgewidth' etc), and each routine just ignores what it doesn't recognise.
The problem with that style is that there is no validity checking : a miss-spelled keyword causes no warning or error.

Is that problem because they have multiple underlying functions?  In our case we choose one underlying numpy/scipy function and so could pass all the kwargs to that chosen function.  Then the numpy/scipy function would presumably throw an error if you tried to pass the wrong kwargs.

I'm going to close this one as the points raised in the OP have now been addressed.  The conversation was rather more wide-ranging but I think it might be better to pull specific aspects out as their own issues if anyone wants to.  That would make them easier to vote on, and easier to say if/when they've been addressed.


[Feature Request]:  After DAOSpace creates a DAO, it needs to provide the ability to modify the content in DAOExt

Feature Request
Describe the Feature Request
After DAOSpace creates a DAO, it needs to provide the ability to modify the content in DAOExt

Custom DAO, after DAO is created through DAOSpace, the incoming DAOExt does not provide the ability to modify.

What capability should be needed to modify the DAOExt?

DAOModifyExtCap

@yubing744 Added at #108


Clean up headers in rp2_common to appease -Wstrict-prototypes

In C, func() is a function taking an unspecified number of arguments,
vs func(void) a function taking no arguments. In C++ both forms indicate
"no arguments."
Update these headers to use the (void) form, which is correct in both
languages and avoids complaints when -Wstrict-prototypes is specified.

Sure. Almost done, but it turns out that:
cc1plus: error: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++ [-Werror]
Do you know the Cmake incantation to add it just for C sources?
Also, how do you specify a debug vs release build?

you asked :-)
$<$<COMPILE_LANGUAGE:CXX>:-Wstrict-prototypes>
For debug, if not using an IDE which probably does this for you, you can pass -DCMAKE_BUILD_TYPE=xxx for e.g. Debug or Release, or the others..
Best to keep separate build directories for each config
you can look at
cmake -LH to see some more info

Updated patch. Looks clean for me in Debug and Release build modes.


Using TFS_HOST environment variable not working for TFS server

When using the vsts-agent-docker in combination with an on premise TFS 2017 server using the TFS_HOST environment variable produces a http url. As mentioned in vsts-agent Issue 695 the authentication with a PAT token requires a https connection.
I am aware that I can set the url using the TFS_URL environment variable to configure the correct https url.
Anyway it would make sense to change the url build from the TFS_HOST environment variable a https url as it required anyway.

I think this makes sense. Is the default port of 8080 still the right port to use for https, or should it be changed to 443?

Sorry, for the late response. Port 8080 makes indeed not much sense when using HTTPS. Port 443 as default sounds reasonable to me.

The images have been updated to use https://$TFS_HOST/tfs as the default TFS_URL.


align supported releases

This PR includes the following:

458ea03e2262b78082dc13c993e57bd6731e8908 - includes:

fix not working link to ScyllaDB Web Install
removing script description since we already have README.md

c01290bb6be42bc4be880f64fe15702d3761d9a8 - to align supported versions this commit includes the following changes:

add check of supported Scylla versions in check_scylla_version() function.
in case the specified version reached EOL, the script will exit with relevant message
remove not supported versions from the script
remove version check in architecture check process
remove set_gpg_key() function - due to old GPG_KEY for not supported versions
updated help and README example versions

Closes: https://github.com/scylladb/scylladb-web-install/issues/62

Verification:

when trying to install scylla version 4.5 that already EOL:

root@7f11c92459b3:/scylla-web-install# ./server --scylla-version 4.5
The specified scylla-version '4.5' has reached End of Life (EOL) and is no longer supported.  For supported ScyllaDB versions please refer to https://docs.scylladb.com/getting-started/os-support

when the version does not exist in Scylla:

root@7f11c92459b3:/scylla-web-install# ./server --scylla-version 5.9
There is no package repository for version '5.9'. For ScyllaDB versions please refer to https://docs.scylladb.com/getting-started/os-support

when trying to install scylla-enterprise 2021.1.0 that is already EOL:

root@7f11c92459b3:/scylla-web-install# ./server --scylla-product scylla-enterprise --scylla-version 2021.1.0
The specified scylla-version '2021.1.0' has reached End of Life (EOL) and is no longer supported. For supported ScyllaDB versions please refer to https://docs.scylladb.com/getting-started/os-support

You have some tests failing, any idea why?

Just checking it..

You have some tests failing, any idea why?

It's failing from main branch as well

You have some tests failing, any idea why?

It's failing from main branch as well

That's weird. not related to any of the changes? in any case, we need to get it fixed :-)


Wrong loss or lambda works wrong

When I try to run this code, I have the wrong loss.
import numpy as np
from keras.layers import Input, Dense, Lambda
from keras.models import Model
import keras.backend as K

def train_iterator(batch_size=16):
    x = np.zeros((batch_size, 2))
    while True:
        for i in range(batch_size):
            x[i][0] = np.random.randint(0, 100)
            x[i][1] = np.random.randint(0, 100)
        x_mean = (x[::,0] + x[::,1]) / 2
        yield [x], [x_mean]

K.clear_session()
x = Input(name = 'x', shape=(2,))
x_mean = Lambda(lambda x: (x[::,0] + x[::,1]) / 2, output_shape=(1,), name = 'x_mean')(x)
model = Model(inputs=x, outputs=x_mean)
model.summary()

model.compile(loss=['mse'], optimizer = 'adam')
model.fit_generator(train_iterator(), steps_per_epoch = 10, epochs = 5, verbose = 1)

x, x_mean = next(train_iterator(1))
print(x, x_mean, model.predict(x))

Epoch 1/5
10/10 [==============================] - 0s 7ms/step - loss: 829.3230
Epoch 2/5
10/10 [==============================] - 0s 2ms/step - loss: 936.7182
Epoch 3/5
10/10 [==============================] - 0s 2ms/step - loss: 667.0758
Epoch 4/5
10/10 [==============================] - 0s 2ms/step - loss: 757.9758
Epoch 5/5
10/10 [==============================] - 0s 2ms/step - loss: 1024.0672

Doesn't work:
def train_iterator(batch_size=16):
    x = np.zeros((batch_size, 2))
    while True:
        for i in range(batch_size):
            x[i][0] = np.random.randint(0, 100)
            x[i][1] = np.random.randint(0, 100)
        x_res = (x[::,0] + x[::,1]) / 2
        yield [x], [x_res]

Works perfect:
def train_iterator(batch_size=16):
    x = np.zeros((batch_size, 2))
    x_res = np.zeros((batch_size, 1))
    while True:
        for i in range(batch_size):
            x[i][0] = np.random.randint(0, 100)
            x[i][1] = np.random.randint(0, 100)
        x_res[::,0] = (x[::,0] + x[::,1]) / 2
        yield [x], [x_res]

Squeezed version also works fine:
def train_iterator(batch_size=16):
    x = np.zeros((batch_size, 2))
    x_res = np.zeros((batch_size, 1))
    while True:
        for i in range(batch_size):
            x[i][0] = np.random.randint(0, 100)
            x[i][1] = np.random.randint(0, 100)
        x_res[::,0] = (x[::,0] + x[::,1]) / 2
        x_res_sq = np.squeeze(x_res, axis=-1)
        yield [x], [x_res_sq]


Recommend using .txt and .lock instead of .in and .txt

What's the problem this feature will solve?
The current recommendation of using .in as the input and then .txt as the output, means that the file that all of the existing tools view is the full list of installed packages with specific versions (and potentially hashes), so it's hard to review/audit and is a long detailed list that may contain a lot of packages that the developers aren't aware of because they aren't using them directly.
Describe the solution you'd like
Recommend that .txt is the input and .lock is the output, so the existing uses of requirements.txt can be maintained as a short list that's easy to review/audit.
(this is creating a use case like package.json and yarn.lock or package-lock.json in the node ecosystem)
Alternative Solutions
N/A
Additional context
PyCharm and the IntelliJ IDEs can't handle the files generated by pip-compile so this solution also has the benefit of working around this bug and any others that may crop up from requirements.txt being more detailed/specific than may be expected.

the file that all of the existing tools view is the full list of installed packages with specific versions (and potentially hashes)

That's the whole point: tools which prepare or analyse an environment should use the long list with the exact versions.
If they used requirements.in, the environment that they produce would not be deterministic and will quite frequently have the wrong dependency versions.

PyCharm and the IntelliJ IDEs can't handle the files generated by pip-compile so this solution also has the benefit of working around this bug and any others that may crop up from requirements.txt being more detailed/specific than may be expected.

This would just replace one problem with another. If you supply the input file to PyCharm, then the environment which it creates won't have the right dependency versions.
Keep in mind that failing to parse requirement files with hashes is a security issue. Checking the hashes is what guarantees that you're fetching the exact same package as intended. If you are forced to remove hashes, then there's no way to ensure that you ve downloaded the right packages.

Definitely understand that. I'll follow up on the PyCharm/IntelliJ bug so it can be used in accordance with this.

The current recommendation of using .in as the input and then .txt as the output, means that the file that all of the existing tools view is the full list of installed packages with specific versions

I'd also like to add that the existing tools (like Dependabot) specifically recognize pip-tools maintained file pairs using this convention that's in place. So changing that would actually be breaking the ecosystem.


Fix display check on mac

env.DISPLAY is not required to be set on Mac. The check for it in JavaTestRunner is removed in this PR.
3 targets that work on Mac have been un-excluded.

Related to : infrastructure/issues/5254
Signed-off-by: Mesbah-Alam<EMAIL_ADDRESS>

Test : Grinder/21045.


Added min mass loss and replaced quadtree.js with simple-quadtree in master branch

This pull request is now managed with CodeReviewHub. Refresh.