[Feature Request] Index Controller support (Finger tracked controller in general)

I would like to figure out if and how it would be possible to support the new Valve Index Controller (aka Knuckles) within Godot.
If you don't know what these controllers are, you can find out more here: https://store.steampowered.com/app/1059550/Valve_Index_Controllers/
The basics are: Individual finger tracking, grip can be pressed with dynamic strength.
Joystick + trackpad, discrete face buttons.
I don't know what the best place to start would be but I imagine it should be the OpenVR plugin right here, as I think the basic ARVRController class in Godot has everything needed to make the Index controller usable in a fully featured way, even though the interface might not be very convenient.
Probable TODOs:

[ ] separate trackpad and joystick into different joysticks with independent axis
[ ] map face buttons and joystick click to independent button presses
[ ] map fingers to independent additional joystick axis (rest on controller without pressure = 0.0, go positive or negative with added pressure or spread fingers)

What I'm not quite sure about is how one could identify what type of controller is used.
As I have the hardware I wouldn't mind helping in actually implementing this, with the following caveats, I am a developer but:

only very minimal C++ experience
no GDNative experience
Full-time employed and constrained for time (But aren't we all?)

This is a serious offer but I would probably need some on-boarding.
Dev hardware for the index controller was shipped to a lot of VR devs so I'm looking into what to do to get some for the core developers of this module.

Hey Stephan,
I’m hoping to get the index soon as well, so far my experience with finger
tracking has been with what oculus touch controllers can do. They track
much less but i went down a similar road as you suggest here. It’s clunky
to be honest.
A little while ago i added support for supplying meshes for arvr nodes, i
still want to rewrite the openvr plugin to make use of that. What i’m
thinking about is to also add skeleton support. That would allow us to
animate a hand skeleton.
Also openvr added gesture support, openxr has that also so it’ll be
interesting to add that to godot aswell.
Until I actually have controllers and can play with the sdk I won’t be sure
what the best approach is but suggestions and help is more then welcome
On Sat, 29 Jun 2019 at 2:55 am, Stephan Lanfermann<EMAIL_ADDRESS>wrote:

I would like to figure out if and how it would be possible to support the
new Valve Index Controller (aka Knuckles) within Godot.
If you don't know what these controllers are, you can find out more here:
https://store.steampowered.com/app/1059550/Valve_Index_Controllers/
The basics are: Individual finger tracking, grip can be pressed with
dynamic strength.
Joystick + trackpad, discrete face buttons.
I don't know what the best place to start would be but I imagine it should
be the OpenVR plugin right here, as I think the basic ARVRController class
in Godot has everything needed to make the Index controller usable in a
fully featured way, even though the interface might not be very convenient.
Probable TODOs:

separate trackpad and joystick into different joysticks with
independent axis
map face buttons and joystick click to independent button presses
map fingers to independent additional joystick axis (rest on
controller without pressure = 0.0, go positive or negative with added
pressure or spread fingers)

What I'm not quite sure about is how one could identify what type of
controller is used.
As I have the hardware I wouldn't mind helping in actually implementing
this, with the following caveats, I am a developer but:

only very minimal C++ experience
no GDNative experience
Full-time employed and constrained for time (But aren't we all?)

This is a serious offer but I would probably need some on-boarding.
Dev hardware for the index controller was shipped to a lot of VR devs so
I'm looking into what to do to get some for the core developers of this
module.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GodotVR/godot_openvr/issues/57?email_source=notifications&email_token=AAO262O3L7K2HENEPY3SRHLP4Y7BNA5CNFSM4H4HAJ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4LPBSA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO262LP64ONBVGOCH3NWSLP4Y7BNANCNFSM4H4HAJ5Q
.

--
Kindest regards,
Bastiaan Olij
https://www.facebook.com/bastiaan.olij
https://twitter.com/mux213
https://www.youtube.com/BastiaanOlij
https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw
https://github.com/BastiaanOlij

In that case we should probably find out what the smallest common denominator between Oculus and Index controllers finger tracking is and build a class with an interface based on that first and then work on the Index specific interface that has even more functionality.

Couldn’t agree more because ideally we want to add logic to the godot core
that will work with a variety of controllers. Another to look into are
devices like leap motion. So far i made their driver completely separate
from the work i did on arvr controllers but ideally they should just be
implemented as part of this structure.
I haven’t had time yet to read up on the openvr sdk changes to really form
a good picture of what this solution should look like...
On Mon, 1 Jul 2019 at 4:57 am, Stephan Lanfermann<EMAIL_ADDRESS>wrote:

In that case we should probably find out what the smallest common
denominator between Oculus and Index controllers finger tracking is and
build a class with an interface based on that first and then work on the
Index specific interface that has even more functionality.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GodotVR/godot_openvr/issues/57?email_source=notifications&email_token=AAO262NBQNNLAWUN4IEJAMTP5D6YJA5CNFSM4H4HAJ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4RUUQ#issuecomment-507058770,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO262JOKSCKMKJQEF6UC5TP5D6YJANCNFSM4H4HAJ5Q
.

--
Kindest regards,
Bastiaan Olij
https://www.facebook.com/bastiaan.olij
https://twitter.com/mux213
https://www.youtube.com/BastiaanOlij
https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw
https://github.com/BastiaanOlij

Also openvr added gesture support, openxr has that also so it’ll be
interesting to add that to godot aswell.

What do you mean by gesture support?  Do you mean the individual finger summary data?
I don't use the vast bulk of the godot_openvr module, but I have my index working through OpenVR with full skeletal support in godot, and I am not sure what you mean by this.

In general I would like to now how this is being implemented now as apparently this is also an initiative by the Godot core team now as they were contacted by Valve.

@DerRidda still looking into it.
Need to start playing around with the SDK and start thinking about what I want to do. I'll be sure to do some writeups after I've done some experimenting so you guys can provide feedback before we get to far into a solution

Hello @BastiaanOlij!
Could you give a short status report on the skeleton hand support? I am working on a repository that should help VR developers getting startedand really want to include this feature. Any way i can support you in this?

You guys are magnificent people. I love the work you all are doing.
On Tue, Mar 24, 2020 at 10:28 AM MathiasBaumgartinger <
<EMAIL_ADDRESS>wrote:

Hello @BastiaanOlij https://github.com/BastiaanOlij!
Could you give a short status report on the skeleton hand support? I am
working on a repository https://github.com/boku-ilen/godot-vr-toolkit
that should help VR developers getting startedand really want to include
this feature. Any way i can support you in this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GodotVR/godot_openvr/issues/57#issuecomment-603271125,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFABOFBOB3ZMZL2VFMKOT5LRJC7QTANCNFSM4H4HAJ5Q
.

Hi Mathias,
I’m rounding off a small change around boundaries and then i’ll be working
on the hands system.
We had sweeping changes introduced here in Sydney due to COVID over the
weekend that i have to deal with first though.
Best way to help right now is to test as much as you can on the large
changes around actions as the skeleton system is build on top of that.
On Wed, 25 Mar 2020 at 1:28 am, MathiasBaumgartinger <
<EMAIL_ADDRESS>wrote:

Hello @BastiaanOlij https://github.com/BastiaanOlij!
Could you give a short status report on the skeleton hand support? I am
working on a repository https://github.com/boku-ilen/godot-vr-toolkit
that should help VR developers getting startedand really want to include
this feature. Any way i can support you in this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GodotVR/godot_openvr/issues/57#issuecomment-603271125,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO262IS6NOW6QZSBGZX75LRJC7QRANCNFSM4H4HAJ5Q
.

--
Kindest regards,
Bastiaan Olij
My personal profile on Facebook https://www.facebook.com/bastiaan.olij
My professional profile on LinkedIn
https://www.linkedin.com/in/bastiaanolij/
My profile on Twitter https://twitter.com/mux213
My tutorials on Youtube https://www.youtube.com/BastiaanOlij
My code repositories on Github https://github.com/BastiaanOlij

This is now being implemented in #84


Where to check the OpenSearch 1.2.3 Compatibility Matrix for Logstash and Beats?

https://opensearch.org/docs/latest/clients/agents-and-ingestion-tools/index/#compatibility-matrices
Couldn't see the Compatibility Matrix for Logstash and Beats for the OpenSearch 1.2.3.
In OpenSearch documentation compatibility Matrix present for OpenSearch 1.0.0 only.
Where to check the OpenSearch 1.2.3 Compatibility Matrix for Logstash and Beats?
BREAKING CHANGES section is not available in OpenSearch release notes.
Where to check Breaking changes and Deprecation changes for the OpenSearch version 1.0.0 to 1.2.3?
Could you please advise on this?

Forgot to answer re:deprecations I think we need to call that out as "none", but if there are none mentioned, then there are none.
I also opened https://github.com/opensearch-project/OpenSearch/issues/1868 and would love some suggestions about how we can improve release notes.

Thanks a lot.

Thanks a bunch for reporting, @balar06. As mentioned before, new OpenSearch 1.x versions don't introduce breaking changes, so we've updated the compatibility page to say so. Once 2.0 releases, we'll update the page again to account for new compatibility.


Add new annotation to change the config file path in the container

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

License
Apache 2.0

What's in this PR?
This PR adds an annotation "vault.security.banzaicloud.io/vault-configfile-path" to indicate where to mount the shared volume (ct-secrets) in the main container. With this annotation it is possible to place the generated config file at the desired location in the main container and not only in /vault/secrets
Why?
To be able to write the configuration file generated by consul-template in the right directory (ex: /etc/nginx/nginx/nginx.conf for nginx) and not only in /vaut/secrets
To Do

[x] User guide and development docs updated

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


HTMLElement interfaces

Can additional classes/interfaces be added and used than simply Element and FormElement? e.g. I'd like to be able to traverse through the tree and switch off of whether elements are an HTMLHeadingElement, HTMLSelectElement, HTMLOutputElement, etc., etc. Each of those interfaces would then expose logic for querying the selectedIndex, value, and other things specific to that type of element.

Um that sounds not really like what I want from jsoup... what would the different classes do? What useful methods does an HTMLHeadingElement have that a HTMLDivElement not? The w3c DOM classes are not to my taste and I believe jsoup owes some of its usefulness to the relative simplicity of its model.
I'd suggest just switching on the tag name.

Yeah, that is fine. An HTMLSelect would probably be the most useful for querying options, groups, selections, etc. but I see your point. Thanks.

Select makes sense for a custom impl of form values.

(Will close this as a bit aged, but can revisit select tags or others if we get interest and a clear utility.)


[minor] [examples] Avoid packaging duplicate classes.

Add exclusions and explicit dependencies so that the examples
assembly does not duplicate classes already packaged in the main
assembly.
Also avoid relocating the commons-math3 package since it's already
a dependency of spark-core, and thus is already available in the
main assembly.

Locally, with a few *-provided profiles, the examples assembly shrunk from > 80MB to about 16MB.

Test build #29763 has started for   PR 5379 at commit 12c258e.

Individually those changes seem believable, like, marking Scala as provided and not including the Spark-shaded classes. Most affect the Cassandra dependency and the logic there is that they are definitely provided by Spark?

Test build #29763 has finished for   PR 5379 at commit 12c258e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29763/
Test PASSed.

Yes, I checked all the exclusions I'm adding; they're either direct dependencies of Spark (and thus can be provided), or are transitive (e.g. Hadoop or some other Spark dependency pulls them in), so the assembly (or the cluster where the assembly is being run) is expected to provide them.

This LGTM as that is a huge decrease in the size of the examples JAR. I'll leave it open for comments one more day.


Handle report empty list & table message

@Bars92 looks good, please add default empty message in case not provided.

Coverage increased (+0.02%) to 81.257% when pulling ff10610dfdf8f21c6c655401d362d8ef8c05b39d on report_empty_list_table into faf6256fdf493dfd65ffd2b3cd3bef86c14ad35c on master.

@dorsha can we merge this?


azcopy failed with timeout=901: write tcp 10.x.x.x:36632->10.y.y.y.y:3128: write: connection reset by peer

Which version of the AzCopy was used?
10.9.0
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Linux
What command did you run?
innobackupex  $backup_path >>$log_file | /usr/bin/azcopy cp "https://$storage_acc_name/$remote_path/FS_$backup_file?$SASToken" --from-to="PipeBlob"
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
ERROR:#012-> github.com/Azure/azure-pipeline-go/pipeline.NewError, /home/vsts/go/pkg/mod/github.com/!azure/azure-pipeline-go@v0.2.3/pipeline/error.go:157#01
2HTTP request failed#012#012Put https://st-acc-name//backfilename?blockid=AAAAAAAAAAAAAAAAAAAAAA%3D%3D&comp=block&
$sastoken&timeout=901: write tcp 10.x.x.x:36632->10.y.y.y.y:3128: write: connection reset by peer
The backup file 824GB single file.
How can we reproduce the problem in the simplest way?
running script
Have you found a mitigation/solution?
No

250GB files are working fine

This is still a issue with 824GB single file, Trying to understand size limitations / alternatives...?

@varun22 This is an issue with n/w. Use flags --block-size-mb 32. You can also use --cap-mbps to limit the bandwidth to a more appropriate value.


Migration tool is setting outdated sdk constraints

Running the migration tool from bleeding edge or flutter master, dart version:
Dart SDK version: 2.11.0-207.0.dev (dev) (Fri Oct 9 09:16:09 2020 -0700) on "macos_x64"
The migration tool is setting a pub sdk constraint as follows:

sdk: '>=2.9.0 <2.10.0'

This should be updated for the current dev releases, and will need another update when we go to beta.
cc @srawlins @timsneath

Sam, I think this is something we'll want to get in for TP2.

Is sdk: '>=2.11.0 <2.12.0' or do I need to include -dev.0 or something?

From a discussion:

we'll want the lower bounds to work in the SDK that they're using to migrate (so, if using something like 2.11.0-207.0.dev, the lower bounds should work for that version)

And some thoughts:

if the feature has been released, we should use that version (https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/lib/src/dart/analysis/experiments.g.dart#L101) as the lower bounds
else, we should use the experimental release version (https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/lib/src/dart/analysis/experiments.g.dart#L100) as the lower bounds
for both of those, we may want to do something to ensure that the sdk used to perform the migration is included in the version range (i.e., lower the range slightly to capture a dev version of the sdk range)

What @devoncarew says above about lower bounds seems right to me.  For upper bounds, post-stable we should probably use <3.0, but for beta we may want to use < 2.12 .  @natebosch @jakemac53 @mit-mit  WDYT?

Well I landed a bandaid but I like the idea of maybe just taking the current 2.11 dev version if that's easy? And I'll wait for an answer about the upper bound

You might choose to use releaseVersion (from the generated experiments file) if it's not null, and short of that use the value from experimentalReleaseVersion (which is at 2.10.0).
  static final non_nullable = ExperimentalFeature(
    index: 3,
    enableString: EnableString.non_nullable,
    isEnabledByDefault: IsEnabledByDefault.non_nullable,
    isExpired: IsExpired.non_nullable,
    documentation: 'Non nullable by default (null safety)',
    experimentalReleaseVersion: Version.parse('2.10.0'),
    releaseVersion: null,
  );

Ah, so I can still use >=2.10.0? That works, since its released as final, and covers all 2.11 dev versions.

>=2.10.0 will work when the experiment flag is passed, or the package is in the allow list.  For TP2, the former will always be true.  For beta, I think the lower bound needs to be a 2.12 dev release.

unless we change our versioning for beta on the way to our Q1-21 release, we will be some version of 2.11 up to (and including) that stable.

unless we change our versioning for beta on the way to our Q1-21 release, we will be some version of 2.11 up to (and including) that stable.

@pcsosinski No, we always bump the minor version when we flip an experiment flag to avoid various issues, so the first null safety beta will be a 2.12 beta, and 2.12 will be the stable release.

@pcsosinski No, we always bump the minor version when we flip an experiment flag to avoid various issues, so the first null safety beta will be a 2.12 beta, and 2.12 will be the stable release.

thanks @leafpetersen, makes sense.   i guess we haven't touched any experiment flags in a while?

This seems problematic, though. Are we really going to invalidate all null
safe code with a 2.10<=x<2.11 constraint?
It feels like we're causing major package ecosystem churn. I understand the
value of doing so if we *know *it's a breaking change, but I'd love it if
the default were less invasive.
On Mon, Oct 12, 2020 at 2:33 PM Patrick Sosinski<EMAIL_ADDRESS>wrote:

@pcsosinski https://github.com/pcsosinski No, we always bump the minor
version when we flip an experiment flag to avoid various issues, so the
first null safety beta will be a 2.12 beta, and 2.12 will be the stable
release.
thanks @leafpetersen https://github.com/leafpetersen, makes sense. i
guess we haven't touched any experiment flags in a while?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/43757#issuecomment-707356238,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARWL6ZK3I32E5UB3YNPYO3SKNYZXANCNFSM4SLHHS7Q
.

This seems problematic, though. Are we really going to invalidate all null safe code with a 2.10<=x<2.11 constraint?

Any null safe code that has been published with this constraint is under the supervision of the Dart team (it has to be explicitly on the allow list) and yes, one of the beta and stable checklist items is to re-publish all of these packages.  We've already rolled this once, it's tedious, but doable.  So I'm not concerned about that.
A more real concern is what to do about packages published during the beta release, since we have no control over them.  I believe that our planned guidance for publishing pre-stable is:

Publish as a pre-release with a tight upper SDK constraint of <2.12
When stable rolls, publish a stable release with an SDK constraint of >=2.12 < 3.0.0

@natebosch @jakemac53 does that agree with your thinking?
There is a legitimate tradeoff here between the chance of a package being in a broken state because of breaking bug fixes/changes during beta vs a package author not knowing (or forgetting) to republish their package when stable is released.  We could choose to instead recommend that:

Publish as a pre-release with a constraint of >=2.12.0-beta.whatever < 3.0.0 (and make dart migrate issue this)
When stable rolls, publish a stable release with an SDK constraint of >=2.12 < 3.0.0

The main benefit of the latter workflow is that because of the dart migrate default, packages that don't follow our recommendation to publish separate pre-release and stable versions will still be available in a null safe version in stable, albeit with some chance of being broken.


Need something like SparkContext and SparkEnv for OAP

During OAP's startup, we need to initialize MemoryManager, CacheManager for each executor. (Similar to SparkEnv)
Also, we need something like HeartBeatReceiver (In SparkContext) or BlockManagerMaster (In SparkEnv) to let driver communicate with executors (e.g. get cache status of each executor, ask executor to drop some cache)

close this as #767 merged.


about problem with use

hi,i use ng2-bootstrap directives,version 1.0.0-beta2,but i find in console have two error ,
Uncaught SyntaxError: Unexpected token <  and Uncaught SyntaxError: Unexpected token <
Evaluating http://localhost:3000/ng-bootstrap2/ng-bootstrap2
Error loading http://localhost:3000/app/boot.js,i don't kown where error,what should i do???

hi, link to your repo please
it is not bootstrap problem, rather static file server configuration
but I see it second time
so how are starting an app?

"scripts": {
"tsc": "tsc",
"tsc:w": "tsc -w",
"lite": "lite-server",
"start": "concurrent 'npm run tsc:w' 'npm run lite'"
},
this is my package.json ,angular2 official website 5min quickstart have this configuration。

just push your current work dir as some public repo and give a link here
it will be faster for me to reproduce and fix issue

https://github.com/SallyOne/TheieX

@SallyOne all simple
update you systemjs config in index.html
        System.config({
            packages: {
                './app': {
                    format: 'register',
                    defaultExtension: 'js'
                },
                'ng2-bootstrap': {
                    defaultExtension: 'js'
                }
            },
            map: {
                // place for ng2 modules mapping
                'ng2-bootstrap': 'node_modules/ng2-bootstrap'
            }
        });

adding
<alert type="info" dismissible="true">Welcome to Angular 2 QuickStart</alert> to content.html
produces

I tried to explain how to solve this issue here https://github.com/angular/angular.io/pull/681

thankyou very much.


Busybox not working in debug CC image on GKE

If I try to use busybox inside the gcr.io/distroless/cc:debug image on GKE, I get the following error:
> ls /
ls: can't open '.': Value too large for defined data type

Listing individual files (eg ls /etc/passwd) works. It also works fine if I run on a local minikube cluster. I haven't seen any other surprising problems.
Cluster description:

Zone: europe-west1-c
Size: 1
Total cores: 4 vCPUs
Total memory: 15.00 GB
Node version: 1.7.8-gke.0

Repro
This assumes kubectl is already set up to use a GKE cluster.
> kubectl version
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.2", GitCommit:"bdaeafa71f6c7c04636251031f93464384d54963", GitTreeState:"clean", BuildDate:"2017-10-24T19:48:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"7+", GitVersion:"v1.7.8-gke.0", GitCommit:"a7061d4b09b53ab4099e3b5ca3e80fb172e1b018", GitTreeState:"clean", BuildDate:"2017-10-10T18:48:45Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
> kubectl run testdep --image=gcr.io/distroless/cc:debug --command -- sleep 999999
deployment "testdep" created
> kubectl exec -it testdep-3687734506-mp5c7 sh
/ # ls
ls: can't open '.': Value too large for defined data type
/ # command terminated with exit code 1
> kubectl delete deployment testdep

That's...  exciting :)
I wonder if updating will help, I found this.

Yep, found that too, although the version in `cc:debug is much more recent:
BusyBox v1.27.1 (2017-07-18 19:24:44 CEST) multi-call binary.

Also, apparently that's only for certain directories:
        /*
         * Try to detect broken toolbox/busybox binaries (see
         * https://code.google.com/p/busybox-android/issues/detail?id=1)
         *
         * It is giving "Value too large for defined data type" on certain file operations (e.g. ls
         * and chown) in certain directories (e.g. /data/data)
         */

We also ran into this, and it turns out that there is a busybox config setting CONFIG_LFS that it must be compiled with to support working with large files. Without it you may encounter errors in ls, rm, etc.
The provided busybox binaries appear to be not compiled with that flag. We built busybox from source using the default config to resolve this. The busybox http_file in distroless' WORKSPACE is using a default provided binary.

I checked, the latest binary, https://busybox.net/downloads/binaries/1.27.1-i686/config has CONFIG_LFS=y set.
This does not exist anymore.
tejaldesai@tejaldesai$ kubectl exec -it testdep-77888775fb-psf82 sh
/ # ls
busybox  etc      lib64    sys      usr
dev      lib      proc     tmp      var
/ #

Is this released in the latest gcr.io/distroless/base:debug tag? Still experiencing it.

I'm also seeing it:
/root # busybox | head -n 1
BusyBox v1.27.1 (2017-07-18 19:24:44 CEST) multi-call binary.
/root # ls
ls: can't open '.': Value too large for defined data type

on a GKE cluster, node version 1.9.4-gke.1, machine type n1-standard-4

I am also seeing this in GKE running a busybox on top of the container optimized os 4.14.22+ kernel. The busybox version is the same one that @tejal29 listed as working BusyBox v1.27.1 (2017-07-18 19:24:44 CEST) multi-call binary.

Somehow, i cant reproduce this on my end.
 kubectl run testdep --image=gcr.io/distroless/cc:debug --command -- sleep 999999
deployment.apps/testdep created
tejaldesai@tejaldesai~:$ kubectl exec -it testdep-77888775fb-psf82 sh
Error from server (NotFound): pods "testdep-77888775fb-psf82" not found
tejaldesai@tejaldesai~:$ kubectl get po
NAME                         READY     STATUS             RESTARTS   AGE
java-with-vuln               0/1       CrashLoopBackOff   15         55m
kritis-postinstall           0/1       Completed          0          1h
kritis-predelete             0/1       Completed          0          36m
kritis-preinstall            0/1       Completed          0          1h
nginx-no-digest-breakglass   1/1       Running            0          53m
testdep-6fdff65d5b-xjsh7     1/1       Running            0          15s
tejaldesai@tejaldesai~:$ kubectl exec -it testdep-6fdff65d5b-xjsh7 sh
/ # ls
busybox  etc      lib      proc     tmp      var
dev      home     lib64    sys      usr
/ # busybox | head -n 1
BusyBox v1.27.1 (2017-07-18 19:24:44 CEST) multi-call binary.

can you provide me with your docker build file?

I have a feeling it might have to do with the node image being used for the k8s cluster, and the kernel compilation options used there, which I can share if needed but its a long list.
The build file is:
container_image(
    name = "python",
    base='@distroless//cc:debug,
    debs = [
        packages['libc6'],
        packages['gcc-6-base'],
        packages['libaec0'],
        packages['libattr1'],
        packages['libbz2-1.0'],
        packages['libcap-ng0'],
        .
        .
        .
        # To not go crazy while poking around
        packages['readline-common'],
        packages['libreadline7'],
    ],
    tars = [...],
    symlinks = {
        "/usr/bin/python": "/usr/bin/python2.7",
        "/bin/sh": "/busybox/sh",
    },
    env = {
        # There is a nasty race condition while creating .pyc files
        # from multiple interpreters before Python 3.3. These errors
        # are the most common symptoms:
        #
        #    from .fromnumeric import ravel
        # EOFError: EOF read where object expected
        #
        #    from .linalg import *
        # ValueError: bad marshal data (string ref out of range)
        #
        # Either way, skip saving bytecode in ephemeral containers.
        "PYTHONDONTWRITEBYTECODE": "1",
    }
)

Where I have omitted some of the packages and tars.

I can't seem to recreate this in our GKE cluster anymore. Its possible some nodes were updated, either the underlying kernel or the k8s version.

I suspect this was the same root cause as #225


Cannot refer to module-level vars in the field initializer of an object constructor expression when the field has the same name

Consider the following:
function test() {
    var obj = object Person {
        string name = name; // error

        public function getName() returns string {
            return self.name;
        }
    };
}

// utils

string name = "John Doe";

type Person object {
    string name;

    public function getName() returns string;
};

The above code gives an error saying it's self-referencing name. Shouldn't we be able to refer to module-level vars (as well as local vars once object closure support is there) in a field initializer?

Related issue: https://github.com/ballerina-platform/ballerina-lang/issues/35202


Provide a better feedback on the already selected samples @ study listing page

Adding the issue although I strongly disagree to merge something that a group of developers already see that is confusing...

With the new contributing.md, can you provide an explanation of the problem and why it is a problem?

The main problem is that once you choose a sample in the study listing page you don't have any kind of feedback knowing which samples you've already selected.

This was solved via the current (new, it's not really that new but this issue was never closed) analysis interface ....


HSEARCH-2734 Re-brand the "ram" DirectoryProvider as "local-heap"

https://hibernate.atlassian.net//browse/HSEARCH-2734

Maybe we should also continue to support the "ram" name, but log a warning when it's used? Otherwise it looks a lot like a breaking change for users...

Maybe we should also continue to support the "ram" name, but log a warning when it's used? Otherwise it looks a lot like a breaking change for users...

Yes, definitely!

merged, thanks!


Collapsing right sidebar can't be expanded again

When you collapse the right sidebar, it seems to collapse under the invisible 'exit' button. I am unable to expand the sidebar again unless I change themes.
The expand button is not clickable, only the 'exit' button reveals on mouseover.

This should be fixed in the new version! :)


Invalid schema usage after revert of field localisation

Bug Report
When creating an entity with localization: true, then changing the schema to localization: false, the entity becomes unusable. The locales are still stored and viewing/editing the entity becomes impossible, as now the value is a set of keys, which React can't render as children.
Expected Behavior
The default locale field value is picked for the new schema. Entities stay usable after disabling localisation for fields of saved entries.
Current Behavior
Entities become unusable after

storing field value in multiple locales
disabling localisation for the field
starting the CMS again and viewing the entity

Possible Solution

Default locale value gets picked in restoration process.
Steps to Reproduce
I created a repo for quick testing. All instructions are included the in the README.md.
https://github.com/flaming-codes/payload-cms-localization-collection-issue
Detailed Description

Description
Image

valid after initial save in multiple locales

invalid, locales still present after entity is not localised anymore

A naive thought after going through the Payload codebase for some minutes: Maybe this statement lacks the context to determine what only the default locale should be selected

if multiple locales are used and
if no localisation is used now

Hey @flaming-codes — thanks for the issue. This is actually probably something that should be taken care of with a migration script, which can be written and run specific to your database. I don't think that Payload should maintain any functionality to be able to determine if a field's data was once localized, but is now not, because that would add some pretty abstract and hard-to-follow logic. And it would be unprecedented.
An extreme analog of this would be to say something like - if I have a text field, but I change it to an array field, Payload should know that I changed the field and should try to safely adapt the data. I think this is where a migration script would be better served, personally.
Here is an example for how to do a migration script:
const payload = require('payload');

require('dotenv').config();

const { PAYLOAD_SECRET_KEY, MONGO_URL } = process.env;

payload.init({
  secret: PAYLOAD_SECRET_KEY,
  mongoURL: MONGO_URL,
  local: true,
});

const migrateStatus = async () => {
  const args = process.argv.slice(2); // nodejs command line args are an array that begin at the third item
  const [
    collectionSlug,
  ] = args || [];

  const docs = await payload.find({
    collection: collectionSlug,
    depth: 0,
    limit: 700,
  });

  await Promise.all(docs.docs.map(async (doc) => {
    try {
      await payload.update({
        collection: collectionSlug,
        id: doc.id,
        data: {
          ...doc,
          _status: doc.status || 'draft',
        },
      })

      console.log(`Success! Doc with slug: '${doc.slug}' in collection: '${collectionSlug}' successfully migrated its '${doc.status}' status.`);
    } catch (err) {
      console.error(`Failed. Doc with slug: '${doc.slug}' in '${collectionSlug}' failed to migrate its '${doc.status}' status.`);
      console.error(err);
    }
  }));

  console.log('Complete');
  process.exit(0);
};

migrateStatus();

In the above script, we are migrating old (pre-Drafts) collections from relying on a custom doc.status field to the new and internally supported doc._status field which works with Versions and Drafts. But the principle is the same. Find existing docs, update each one to the new data shape. This can be done with Payload operations and can also be done straight with Mongoose raw documents by accessing the internal Mongoose models via payload.collections[collectionSlug].Model.
What do you think? I'm going to convert this to a discussion for now, but I'd like to keep this conversation going!


widgets in sliver lists don't appear in the widget tree; incompatible with the existing scrollTo methods.

From https://buganizer.corp.google.com/issues/173160127.
Not sure exactly what the appropriate FR would be here, so I'll describe our problem / use case and see if we can figure out what the best solution would be.
The underlying problem is that widgets in sliver lists don't appear in the widget tree until they're visible in the UI, which makes them incompatible with the existing scrollTo methods.
Example widget tress before scrolling and after scrolling
Would it be feasible for the test framework to, say, scroll to a specific index in a SliverList? I'm hoping that espresso/flutter driver can extract some info from the top level widget that we can use to perform more useful actions on it.
@HansMuller Any thoughts here?

I am going to close this with the suggestion given in https://github.com/flutter/flutter/issues/77722#issuecomment-794464842 as a solution for the problem.


Build failing

Currently, CI says the latest build version is failing, what's up with that?

It's failing because the Meteor update to 1.4 broke the original Meteord, which this is forked from. It hasn't really been touched since the fork of the old version.
Is there a timeline for when this will be usable with 1.4?

If someone can give me some suggestions for the fix I can try my hand at a PR, but I'm a bit of a docker n00b and I could use some help digging around.

Well the obvious change was updating Node, which has already been done. (See this commit)
From there I think it's just a matter of trying to build it and running through the errors. Someone else might have a more precise idea of what needs fixing, though. There are also 2 outstanding PRs right now that seem to be necessary updates.

@macsj200 I assume that it's not working because the pull request that should have fixed the code failed, if the big red FAILED sign on the main page is anything to go by, though I'm not sure about this.
To get around the problem I cloned the current meteorhacks:meteord code to my machine
git clone https://github.com/meteorhacks/meteord.git
and manually made the three changes from this page https://github.com/meteorhacks/meteord/pull/108/files in the copy on my machine.
I then got docker-compose to build from my local copy, and it works.


repcred failure with empty sequence_alignment

When running on repertoire_id=5f21e817e1adeb2edc126144 on covid19-1.ireceptor.org, I get:
Rendering book in directory '.'

processing file: _main.Rmd
Quitting from lines 389-444 (_main.Rmd)
Error in h(simpleError(msg, call)) :
  error in evaluating the argument 'x' in selecting a method for function 'XStringSet': The column sequence_alignment contains no data
Calls: tryCatch -> tryCatchList -> tryCatchOne -> <Anonymous>
Execution halted

Sure enough, this repertoire has this field empty, but it is a nullable field in the standard, so repcred should probably be more robust if this is not available. Not sure which reports this would effect...

Also occurs on study_id = IR-Binder-000001, repertoire_id = 5efbc7325f94cb6215deecfc

PRJNA381394, subject B00_CLL_05_10x  failed with this error as well...

I updated the code to skip the part of the code that needs sequence_alignment if there is no sequence_alignment data. I added 5000 sequences of PRJNA381394, subject B00_CLL_05_10x to the tests and seems to work. Can you please update your container and try again?

Repcred ran fine on the previous problem data sets:
subject_id=B00_CLL_05_10x
repertoire_id=5efbc7325f94cb6215deecfc
repertoire_id=5f21e817e1adeb2edc126144
So it looks like this problem is fixed...


added executor made of disruptor. #1804

There is no performance improvement in test results.
So delete all of the code that is related to disruptor.

ping @emeroad  :)

Current coverage is 40.32% (diff: 0.00%)

Merging #2121 into master will decrease coverage by 0.07%

@@             master      #2121   diff @@
==========================================
  Files          1583       1578     -5
  Lines         54799      54616   -183
  Methods       10813      10759    -54
  Messages          0          0
  Branches       7485       7465    -20
==========================================
- Hits          22140      22025   -115
+ Misses        32659      32591    -68
  Partials          0          0

Powered by Codecov. Last update 0e317bc...3b6345c


CI Failing due to new scope_guard dependency in MoveIt Task Constructor

Description
CI is failing with an error:
  --- stderr: moveit_task_constructor_core
  moveit_task_constructor_core: You did not request a specific build type: Choosing 'Release' for maximum performance
  /home/runner/work/moveit2_tutorials/moveit2_tutorials/.work/upstream_ws/src/moveit_task_constructor/core/src/task.cpp:49:10: fatal error: scope_guard/scope_guard.hpp: No such file or directory
     49 | #include <scope_guard/scope_guard.hpp>
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

See e.g., https://github.com/moveit/moveit2_tutorials/actions/runs/10917280200/job/30346870482#step:6:620
This seems to have been introduced in a merge of master to ros2 which adds a new submodule. See this commit
@rhaschke Do you know how we ensure this submodule comes in properly? Presumably the existing pybind11 one is already working? Thanks!
Your environment

ROS Distro: Rolling
OS Version: e.g. Ubuntu 24.04
Source or Binary build?
If binary, which release version?
If source, which git commit or tag?

Steps to reproduce
Tell us how to reproduce this issue. Attempt to provide a working demo, perhaps using Docker.
Expected behaviour
Tell us what should happen
Backtrace or Console output
Use gist.github.com to copy-paste the console output or segfault backtrace using gdb.

Will have a look

I think this was a cache issue. vcs fails to checkout new submodules if the package folder already exists (from cache).
I retriggered the build: https://github.com/moveit/moveit2_tutorials/actions/runs/10917280200/job/30417030494


Disable pthread in blosc

Hi, I am porting zarr with numcodecs into Pyodide (see here https://github.com/iodide-project/pyodide/pull/938), since pthread is not yet supported I have to disable it.
I applied the following patch to blosc and it seems to be working.
diff --git a/c-blosc/blosc/blosc.h b/c-blosc/blosc/blosc.h
index 40857d0..8a1e969 100644
--- a/c-blosc/blosc/blosc.h
+++ b/c-blosc/blosc/blosc.h
@@ -50,7 +50,7 @@ extern "C" {
   ((INT_MAX - BLOSC_MAX_TYPESIZE * sizeof(int32_t)) / 3)

 /* The maximum number of threads (for some static arrays) */
-#define BLOSC_MAX_THREADS 256
+#define BLOSC_MAX_THREADS 1

 /* Codes for shuffling (see blosc_compress) */
 #define BLOSC_NOSHUFFLE   0  /* no shuffle */

 diff --git a/c-blosc/blosc/blosc.c b/c-blosc/blosc/blosc.c
index a5a5bd5..2a7797c 100644
--- a/c-blosc/blosc/blosc.c
+++ b/c-blosc/blosc/blosc.c
@@ -2236,6 +2236,7 @@ void blosc_atfork_child(void) {

 void blosc_init(void)
 {
+  g_initlib = 1;
   /* Return if we are already initialized */
   if (g_initlib) return;

However, I am quite certain that this is not the best way to do it. Can someone here provide some advice on how to properly disable pthread? It would be even better if we can have a build flag that I can controlled in setup.py.

Would suggest following up with the Blosc team. As to Numcodecs, we may soon just rely on Blosc to be packaged independently. See issue ( https://github.com/zarr-developers/numcodecs/issues/262 ) for context.


enable_status option requires argument

Im using this tool to test latest WPA2 flaw (PMKID capturing). In many tutorials, the command is issued with "--enable_status" option. however it takes values 1,2,4,8. Whenever i use any of these options, if PMKID is captured its not logged in terminal.
enable_status=1
sudo hcxdumptool -o test2.pcapng -i wlp2s0mon  --filterlist=f2-matrix.txt --filtermode=2 --enable_status=1
[sudo] password for thor:

start capturing (stop with ctrl+c)
INTERFACE:...............: wlp2s0mon
FILTERLIST...............: 1 entries
MAC CLIENT...............: fcc233c3026a (client)
MAC ACCESS POINT.........: 1100aa7f0d1a (start NIC)
EAPOL TIMEOUT............: 150000
REPLAYCOUNT..............: 64933
ANONCE...................: 27eeea4b47739b815b2c536e46bac31215c891269ebb4633e41376aec13bd269

INFO: cha=3, rx=119, rx(dropped)=0, tx=2, powned=0, err=0^C

enable_status=2
sudo hcxdumptool -o test2.pcapng -i wlp2s0mon  --filterlist=f2-matrix.txt --filtermode=2 --enable_status=2

start capturing (stop with ctrl+c)
INTERFACE:...............: wlp2s0mon
FILTERLIST...............: 1 entries
MAC CLIENT...............: fcc233703b20 (client)
MAC ACCESS POINT.........: 0418b60ad190 (start NIC)
EAPOL TIMEOUT............: 150000
REPLAYCOUNT..............: 61990
ANONCE...................: 5fbd0055af0dcc03143a14bf3cddaa1acc31f9b755dc4900fd5bf0727f909bde

[15:03:34 - 003] b4e62a183a06 -> ffffffffffff matrix [PROBEREQUEST, SEQUENCE 2920]
[15:03:40 - 007] f4f26d25b268 -> fcc233703b20 matrix [PROBERESPONSE, SEQUENCE 1215, AP CHANNEL 8]
INFO: cha=7, rx=192, rx(dropped)=16, tx=14, powned=1, err=0^C

The same happens for option 4 and 8 as well.
BUT for some strange reason if "--enable_status=1,2,4,8"  its showing the status properly.
sudo hcxdumptool -o test2.pcapng -i wlp2s0mon  --filterlist=f2-matrix.txt --filtermode=2 --enable_status=1,2,4,8

start capturing (stop with ctrl+c)
INTERFACE:...............: wlp2s0mon
FILTERLIST...............: 1 entries
MAC CLIENT...............: f0a225ee1382 (client)
MAC ACCESS POINT.........: acde482d1654 (start NIC)
EAPOL TIMEOUT............: 150000
REPLAYCOUNT..............: 63478
ANONCE...................: 75ec843719a0d17613de85ca32cb4cd8c02b56e41d68b39f0de285c384e794f9

[14:42:05 - 001] f4f26d25b268 -> f0a225ee1382 [FOUND PMKID CLIENT-LESS]
[14:42:06 - 001] f4f26d25b268 -> e8de27125d90 [FOUND PMKID]

Please fix this issue, Thanks

It's not an issue. It's just wrong use of --enable-status:
We are using a bitmask!
--enable_status=            : enable status messages
bitmask:
1: EAPOL
2: PROBEREQUEST/PROBERESPONSE
4: AUTHENTICATON
8: ASSOCIATION
That means:
If you would like to see EAPOL and PROBEREQUESTS, you have to use:
--enable_status=1 --enable_status=2
or
--enable_status=3
00000000
00000001 EAPOL
00000010 PROBEREQUEST/PROBERESPONSE
00000100 AUTHENTICATON
00001000 ASSOCIATION
So, EAPOL and PROBEREQUEST/PROBERESPONSE =
00000001 or 00000010 == 00000011
in decimal
1 or 2 = 3
--enable_status=3 will show you  EAPOL and PROBEREQUEST/PROBERESPONSE.
Read more here:
https://en.wikipedia.org/wiki/Bitwise_operation

Hi ZerBea,
I got this from [PMKIDROGUE:55bcf627349fd188abda13fefd997461 KDV:2] hcxdumptool.
What does PMKIDROUGE mean?

Answere here:
https://github.com/ZerBea/hcxdumptool/issues/138

when I run this command it's show me this result.. why it's error?
-o isn't also -h section!
hcxdumptool -o testresult.pcapng -i wlan0mon --filterlist=f2-text.txt --filtermode=2 --enable_status=1
hcxdumptool: invalid option -- 'o'
hcxdumptool 6.3.1 (C) 2023 by ZeroBeat
usage: hcxdumptool -h for help


📚 Documentation/code quality improvements

13 of the 91 open issues mentions the word documentation or docs directly, maybe even more could have been resolved with better documentation. Looks like providing a high quality documentation would benefit not only the users of this package, but the maintainers as well.
I recommend beginning with the API, explaining the function signatures, comment those functions, and all parameters, not just "any" all types in the index.d.ts. Finding out how logger works was painful (there is not a word that you should set Logger to console).
I am a fan of declaration files, it makes it possible to contribute to the library even to those who are not familiar with TypeScript, but still get a good IDE experience. DefinitelyTyped may be interesting. After a while, maybe the community could take that over, so the maintainers have more time on the core stuff.
Secondly, updating the examples/samples would benefit many as well. Make them available online, so one does not have to clone the repo just to run them! A bit of coat of paint would not hurt those samples as well, but I understand it is not a priority, still could improve the quality of this repo.
Haven't looked at how bundling is done right now, but I am sure we should have some kind of code splitting, cause this package is HUGE. I have to load it async on the front-end, cause it takes up almost HALF of the entire bundle. Parcel 📦 sounds like a modern alternative.

ping @brockallen, as you look to be the main contributor/author

Great ideas, but I work on this project either in my free/spare time, or specifically for my customers. If the greater community gets benefit, then great, but that's not my primary audience. If I get time I will consider these suggestions. If you want to build your own docs project on oidc-client-js, then go for it.

I understand, thanks for the clarification. I thought this was some kind of official package meant for the masses, since it is listed in the Certified OpenID Connect Implementations (though the last mentioned version is oidc-client 1.3, so it must be a very outdated site!?).
I would gladly help with the docs, the main problem is that first I would need one, to understand the package better. :sweat_smile:, also I am not the one who knows the ins and outs of OpenID. :cry:
If it is only your "hobby project", it is understandable you have other priorities. Maybe this could/should be mentioned in the README to avoid future confusion then?
It also means, that my team and I maybe should look for an alternative, as we really do not want to focus on diving deep into source codes we are barely familiar with "just to get some basic auth working", it is just not our area of expertise. Do you know any other alternatives that may provide probably less features than this package, but is considerably smaller in size and is well-documented/meant as a true open source project?
Found Auth0 libraries better suited, but unfortunatelly not everything works with out custom IdP server.

Found Auth0 libraries better suited, but unfortunatelly not everything works with out custom IdP server.

Most product libraries are product specific, not protocol specific.
As for your comments, You misunderstand -- this is not just a hobby project. This project is meant for me and my customers. It's open source, so if you get benefit, then great. I will take your suggestions into consideration, so thanks for those. But since you're not a customer I don't foresee spending even more time to help you and your company, much in the same way you'd not give me your product for free.
I'll leave one last thought, which is nicely summarized here:
https://hueniverse.com/no-cure-for-entitlement-38eb3c80d808

No need to call it a

parasitic demand

:slightly_smiling_face:, neither I feel entitled to do anything, I am a junior developer who likes the idea of open source, and simply wanted to mention my findings. You may (and very likely will) ignore all that.
But you said yourself these are great ideas! Also, as mentioned, OpenID recommends this package and calls it a "certified implementation". It very well be the case that I misinterpret it (in that case I apologize), but for me it looked like it is the "recommended" way for the community to use. If you have no involvment with OpenID, I do not understand the endorsment of this package there.
The package is also under a verified organization of IndentityModel, which again (for me) indicates there is big support from an organization behind it.
All I have done is I went through the issues, and interpreted that a huge number of them may be solveable by better documentation, which in the long run may result in significantly less issues, ie. more time fore actual development. I did not demand anything in my opinion. It is at the end of the day a public package with 73.000 weekly downloads according to npm. My assumptions were wrong, and I apologize, again.
Closing this issue, before any more misunderstanding should rise.

The issue is that the work involved is not trivial, and it's easy to come along and throw around tasks I should be doing. Perhaps that wasn't your intent, so no worries.

The package is also under a verified organization of IndentityModel, which again (for me) indicates there is big support from an organization behind it.

I think verified means, that the email address is verified ;)
Like probably most developers, working on docs is our least enjoyable task - it is also really hard to write good documentation. If you think you can really improve the docs and thus reduce the number of issues, please go ahead and work on this! This would be very appreciated.
But in our experience, most people who thought in the past they can take on this task, simply stopped working on it halfway through - which often makes things even worse...but maybe you are different.
And that's also why we are more and more reluctant to just say "of course - we accept pull requests"...

Circulating back on this, as (in my opinion) I have now come to a better understanding of how OSS works...
I would like to again apologize @brockallen and @leastprivilege if I caused discomfort. This package in a way or another set me on a path that ultimately has led me to another project revolving around OIDC and OAuth over at https://github.com/nextauthjs/next-auth, which I am now a core maintainer of.
I have come to the understanding of how hard it is to maintain OSS in a way that everyone gets happy. (Spoiler, it is not possible to make everyone happy, and there always be people who don't see the faces/humans behind a project, but a good attitude on both sides can lead to a thriving community.)
Also, writing good (enough) documentation is hard! AuthN/AuthZ is also a topic that not many take interest in and just expect a solution that "just works", tailored for their needs. Reading through specs much more I can see a lot of ambiguity, so it is also easy to interpret things differently, which does not make things easier either.
Anyway, I just wanted to share this information, and I hope that you are doing great! Thank you for this library! :pray:
:slightly_smiling_face:


update ci

Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?

[ ] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches

What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #0001
Checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #53 (0fe99b6) into master (06a7118) will decrease coverage by 4.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   70.38%   65.67%   -4.72%
==========================================
  Files         194       36     -158
  Lines        7476      941    -6535
  Branches      861      262     -599
==========================================
- Hits         5262      618    -4644
+ Misses       1922      323    -1599
+ Partials      292        0     -292

Flag
Coverage Δ

backend-e2e-test-ginkgo
?

backend-unit-test
?

frontend-e2e-test
65.67% <ø> (-2.91%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

web/src/helpers.tsx
19.67% <0.00%> (-54.10%)
:arrow_down:

web/src/components/RightContent/AvatarDropdown.tsx
50.00% <0.00%> (-32.15%)
:arrow_down:

web/src/components/PanelSection/index.tsx
75.00% <0.00%> (-25.00%)
:arrow_down:

web/src/pages/Consumer/List.tsx
69.44% <0.00%> (-22.23%)
:arrow_down:

...b/src/components/Plugin/UI/referer-restriction.tsx
69.69% <0.00%> (-21.22%)
:arrow_down:

web/src/components/Plugin/PluginPage.tsx
82.35% <0.00%> (-16.48%)
:arrow_down:

web/src/components/ActionBar/ActionBar.tsx
69.23% <0.00%> (-15.39%)
:arrow_down:

web/src/app.tsx
87.87% <0.00%> (-12.13%)
:arrow_down:

web/src/components/Plugin/UI/cors.tsx
71.11% <0.00%> (-11.12%)
:arrow_down:

web/src/components/RawDataEditor/RawDataEditor.tsx
28.57% <0.00%> (-10.39%)
:arrow_down:

... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a7118...0fe99b6. Read the comment docs.


Retina Display support

Views are not drawn in full resolution in Retina Display, it is actually drawn in half the display's resolution in the bottom left corner of the texture. Should draw in the Retina Display resolution.
The cylinder property values are not scaled according to the screen scale. The position and radius should be proportional to the screen scale, which is 2 in Retina Display, and 1 in a normal display.

Support for retina display was added, the texture is now drawn in full resolution, but there's still a mysterious and serious problem.. the texture looks really weird. It's got transparent vertical lines for some funny reason.

"Scan lines" problem fixed. The trick is to divide the image dimensions by the screen scale.


Standardized formatting

Standardizing formatting to plugin-name (description): <url>, as mentioned in #343

Nice! Thank you.


Update what-s-new-in-msbuild-15-0.md

Fix the incorrect statement that the ImportDirectoryBuildTargets property controls the import of Directory.Build.props and add information about Directory.Build.targets.

Learn Build status updates of commit 91393b6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/msbuild/what-s-new-in-msbuild-15-0.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@ghogen
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jrdodds Thanks for these contributions!


It is not possible to change the calendar display on a mobile

NextUI Version
2.4.0
Describe the bug
It is not possible to change the calendar display on a mobile phone. it should be possible to display one by one as a column

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

add DateRangePicker with 2 visibleMonths to the page
switch to mobile mode
open calndar

Expected behavior
calendars displayed one by one as column, no scrollbars

Screenshots or Videos
No response
Operating System Version
macOs
Browser
Chrome

The way it is currently is all the 3 headers are in a div and all the 3 calenders are in another div. (visibleMonths={3}).
I can put individual header-calender pair in a div and then make the parent responsive? using breakpoints?


Plugins should be less tightly coupled

Many plugins, like smart text, are currently in core because they have to operate at specific times with respect to other plugins. This makes many operations hard to reason about and hinders extensibility, and does not accommodate those who do not want smart text.
Plugins need to be more loosely coupled; this will not only increase the clarity of the code, but allow plugins to more easily be reused in other contexts (e.g. an inline mode).

The new View introduced in 9c7dced341ecdc0e646a1b7c7473673027324899 and subsequent changes should go a long way towards more loosely coupled plugins.


limit spfx app into specific site collection/subsite

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Enhancement / Suggestion
[ ] Additional article idea

Is it possible to limit the installation of the spfx app into just a single site collection/subsite? Something like this documentation: https://msdn.microsoft.com/en-us/library/office/fp179896(v=office.15).aspx#AppScope

Hi,
this is currently not supported, but we are looking for site collection specific app catalog possibility in the future. There's however no public schedule for this currently.


Download speed indicated in the UI is higher than it actually is

Not a major issue at all, I kinda like seeing my shitty internet speeds lifted a bit :P
What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)
Version 0.17.2 (0.97.2)
What operating system and version?
OS X 10.11.6
What did you do?
Download a torrent & checked the download speed
What did you expect to happen?
What actually happened?
Download speeds are indicated as roughly 3 times what MenuMeters indicates (more or less consistently).

I think this is what happens when WebTorrent is using a lot of CPU. @lachenmayer - next time this happens, can you check what the CPU utilization of the app is and share here? Thanks.


Security Issue: signature is not checked

Check signature if cert is NON-nil

Thank you! The tests were using the wrong public key, which is why they failed, but that has also been fixed now.

You should maybe add some other tests like:

cert == nil
cert with wrong public key

To be sure that your library doesn't say "OK" even if it's the wrong public
key
Thomas
Le lun. 12 nov. 2018 à 12:35, Koen Vlaswinkel<EMAIL_ADDRESS>a
écrit :

Thank you! The tests were using the wrong public key, which is why they
failed, but that has also been fixed now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/koesie10/webauthn/pull/4#issuecomment-437848317, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXtsoxAxWQCoxD99SYdglVJmwFWq82jks5uuVz4gaJpZM4YZaKQ
.

Totally agree. However, the format of keys is binary, which makes it hard to construct valid or invalid responses. I also don't think there is some test suite which includes a list of valid/invalid responses.

I will definitely do some test suite because the library will be used for
$WORK internal authentication.
I'll share with you if I have some valid & invalid responses ;)
Thomas
Le ven. 16 nov. 2018 à 21:52, Koen Vlaswinkel<EMAIL_ADDRESS>a
écrit :

Totally agree. However, the format of keys is binary, which makes it hard
to construct valid or invalid responses. I also don't think there is some
test suite which includes a list of valid/invalid responses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/koesie10/webauthn/pull/4#issuecomment-439523665, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXtsk_TjykkR2Lcxp4-o5CrkruDLe4pks5uvyWGgaJpZM4YZaKQ
.


Implement protobuf codec for case class schemas

@thinkharderdev Looks good to merge after the conflict is fixed!

Thanks for your work on this! Protobuf continues to improve.


Update func-cli to 0.23.0

Fix: #218

@sudhirverma Update the release to 0.23.1 and add support for M1 binary too. The release is available here https://github.com/knative-sandbox/kn-plugin-func/releases/tag/v0.23.1

Codecov Report

Merging #223 (7938421) into main (bcc229d) will decrease coverage by 0.13%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   92.15%   92.02%   -0.14%
==========================================
  Files          74       74
  Lines        2831     2833       +2
  Branches      453      454       +1
==========================================
- Hits         2609     2607       -2
- Misses        222      226       +4

Impacted Files
Coverage Δ

src/cli/cli-config.ts
76.28% <50.00%> (-0.56%)
:arrow_down:

src/util/platform.ts
88.23% <0.00%> (-11.77%)
:arrow_down:

src/util/watch.ts
93.33% <0.00%> (-3.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc229d...7938421. Read the comment docs.


Try Alpine 3.14.

Try Alpine 3.14. This permits updating a lot of Python dependencies (yay), but it also requires actually compiling orjson (augh) because it's just simpler that way.

[ ] I made sure to update CHANGELOG.md.
[ ] This is unlikely to impact how Ambassador performs at scale.
[ ] My change is adequately tested.
[ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

Not going in to a 1.x; see-also https://github.com/emissary-ingress/emissary/pull/3779


Widgets using output of an analysis doesn't get refreshed when filtering in another widget

@saleiva commented on Fri Jul 08 2016
But they get refreshed after panning the map.
Test in the map above in the formula widget
https://team.carto.com/u/ernestomb/builder/a89de72e-3fa4-11e6-80c4-0e674067d321/embed?state={"map"%3A{"center"%3A[40.419769381446194%2C-3.6927795410156246]%2C"zoom"%3A12}%2C"widgets"%3A{"c7ea4ffc-82b0-4cc7-8e4e-abc9fa9ab63f"%3A{"acceptedCategories"%3A["L5"]}}}

@viddo commented on Mon Jul 11 2016
Moving and reassigning, since this should be handled internally in cartodb.js, by updating the dataviews appropriately.

I'm looking into this... Some findings so far:

the formula widget (Total Population around) is linked to an analysis with id "b2":

{
  "id": "b2",
  "type": "data-observatory-measure",
  "params": {
    "source": {
      "id": "b1",
      "type": "buffer",
      "params": {
        "source": {
          "id": "a0",
          "type": "source",
          "params": {
            "query": "SELECT * FROM madrid_metro_stations"
          }
        },
        "radius": 1000
      }
    },
    "final_column": "pop",
    "segment_name": "es.ine.t1_1",
    "percent": false
  }
}

the other two widgets (Metro Line and Metro Station) are linked to "a0":

{
  "id": "a0",
  "type": "source",
  "params": {
    "query": "SELECT * FROM madrid_metro_stations"
  }
}

Until now, widgets/dataviews were only refreshed if this was true. In this case, the formula widget is linked to a different layer than the other two widgets, and that's why widgets are not "connected".
We should change things to:

Work with source IDs instead of layer IDs.
Take into account that sources are now related... eg: "b2" depends on "a0", so filtering "a0" affect widgets that depend on "b2".

Fixed in https://github.com/CartoDB/cartodb.js/pull/1360.


Liveintent user module docs added.

This reflects changes made in https://github.com/prebid/Prebid.js/pull/4178

Thanks @jankoulaga -
We need to update the Prebid Server bid adapter to pass your value through OpenRTB. What source field value would you like. e.g.
          {
                "source": "liveIntent",
                "uids": [{
                    "id": "11111111"
                }]
            }

Thanks @jankoulaga -
We need to update the Prebid Server bid adapter to pass your value through OpenRTB. What source field value would you like. e.g.
          {
                "source": "liveIntent",
                "uids": [{
                    "id": "11111111"
                }]
            }

Hey @bretg, let's go with liveIntent as a source. Thanks.

I don't see any mention of the segment Id/s being passed?

Hey @jdwieland8282 the segments part in the response will be wrapped inside, depending whether any segment actually exist on our end.
At the time when we were writing these docs, we we're still investigating which segments will actually be added in the response, ad we thought it might be better to update these once we know more. WDYT?

@jdwieland8282 i've mentioned the segments and tried to cover it with an example in the userId object.

released with 2.36


Dropdown: Doesn't set the for property for the label

According to the Webaim accessibility standards (https://webaim.org/standards/wcag/checklist#sc3.3.2) all form labels must be associated with a form control.

Completed in #1016


build: rollup upgrade

:tada: This PR is included in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Donate page

Modeled after the webpage. Paypal link + explanation.

Should be done:
https://github.com/scottwainstock/pbm-ios/commit/19b726b4814e96d1549a9d7b168dcd022a6296c7
We're going to need a lot of QA on this stuff... I'm worried about all the different phone sizes and iPad stuff.

K, we have iPhone 5s, 4s, 3 (I think), and iPad 2 (or 3).

Looks good so far. I'll check on other devices and report back.

Here's what it looks like on iPad. It's not bad. My only suggestions would be to reduce the size of the donate button, so it doesn't look so disproportionate to the text; and make it so the text doesn't span the entire width of the screen (but that's not a big deal at all).

This should do it:
https://github.com/scottwainstock/pbm-ios/commit/54444362c7c01996015ca8ad2a4768964f2c19b3

This might be a "I don't know how to use iOS" issue: if I click the donate button, it opens up a paypal form. But I'm still inside the pbm app (the menu items are at the bottom). From there, there doesn't seem to be a way to show the Donate button + explanation again. Like, I can't go "back" on that screen. Doesn't seem super important, though...


Refactor DataSource component to be open stack based

by open stack I mean not closely tied to doctrine\dbal by default, but have a ConnectionManager for dbal or whatever components we have setup.
I want DataSource to be glue between the app's app/config/datasource.php config file and the chosen library.
So for dbal we need a handler to give you a 'connection' setup per key
For laravel's db layer there's a conection manager too which i have a gist for.
It should be a clean component with some a ConnectionManagerInterface which each library will be setup with

Waiting for @dragoonis to provide documentation. Moved milestone from 2.1.0 to 2.1.1.


Create pull_request_template.md

Add pull_request_template

@stevenj @cong-or @cameron1024 @dkijania @nicopado @FelipeRosa
Can you have a look, please?

Looking great @minikin . I would only address @Mr-Leshiy remarks as I share the same concerns


Um.. Just like... Some stuff?

Life steal buff, you can now have a constructor argument on a bunch of buffs + the heal spell, fish enemy added, swarm ai added... I think that's it?

Yeah go for it, smash that merge button


when a property template with NO default value follows another property template that DOES have a default value, the second property template incorrectly displays a default value

Attached profile has one resource template with two property templates, both type literal. the first has a default value (1976), the second does not. When I load the profile into the Linked Data Editor, both "fields" show the default value 1976. Only the first field should show this.

Default_and_no_default_literals.json.txt


Added utility functions to the new NavigationServer:

Re-added functions, to the NavigationServer:
- Vector3 get_closest_point_to_segment(const Vector3 &p_from, const Vector3 &p_to, const bool &p_use_collision = false);
- Vector3 get_closest_point(const Vector3 &p_point);
- Vector3 get_closest_point_normal(const Vector3 &p_point);
- Object *get_closest_point_owner(const Vector3 &p_point);

Hey @mourning20s check this.

@AndreaCatania I tried it out and it seems to work as expected. Once again, thank you for taking the time to do this.

Could you add the relevant documentation too?

Could you add the relevant documentation too?

Done

@akien-mga any news about this?

Thanks!


Tentative timeline for code?

Just curious to know when the code would be pushed. Wish to test it on my custom data. Thanks.

Hi @AmoghM, we are going to release the code within a few days. Thanks


cancel doesn't fire an event in the connect stream on android

On Android, after calling:
/// Disconnect from device
deviceConnection.cancel();
the connection gets closed, but the 'device.OnStateChanged' stream doesn't notify an event with 'BluetoothDeviceState.disconnected' so that I can close all the other subscriptions and do my clean-up.
It seems that iOS doesn't have this problem.
Could you please verify?
Thanks
Francesco

A StreamSubscription.cancel() should prevent any other events to fire. See here.


issue-7 stop job client

Old PR https://github.com/TWCable/grabbit/pull/146 had conflicts..
This one takes care of stopping jobs at client end.

Great! I'll take a look at this tomorrow

If you are curious about how close() behaves in our case, check out org.apache.http.impl.io.ChunkedInputStream.close() (which is wrapped by our entities EofSensorInputStream class). You can see it continues to read into a 2KB buffer on close, until EOF is reached.

This is a great start 👍 .. I agree with @jbornemann 's points as well.

https://github.com/TWCable/grabbit/commit/1ffe73f087204075e48901641abf0fb070d63b2a is merged, so this may help with your progress on this branch


BC Data Catalogue Version Upgrade

Assess whether the upgrade changes will have an impact on Arches. Forwarded email on July 9, 2024 subject line "BC Data Catalogue Version Upgrade" Feedback due August 6 - unsure when changes will be implemented.
From email:
IMPORTANT: If you or your clients use APIs to access, view or edit your datasets and resources, the schema changes will affect your current setup. Please refer to "Breaking Change" above for further guidance and test your applications using our TEST API (toyger.data.gov.bc.ca/api).
Attached Breaking change document.
BC Data Catalogue Changelog.pdf

Brett determine will have no impact


[analyzer] dead code for conditional access to a null field

class A {
  int? f;
  void m() {}
}

void test() {
  A? a;
  a?.m(); // here
  a?.f;   // and here
}

Should the method invocation and field access be triggered as dead code since a is null in this case?

We could probably do that. This seems related to https://github.com/dart-lang/language/issues/1959.
The title says null field, but do you mean null instance variable? a is not a field.

Am I mistaken, or would such a lint effectively require local data flow analysis? If so, I'm not sure we want to take on the cost of maintaining such a feature. If there's a heuristic we could use, would it catch enough cases to be valuable?

It would require the definite assignment stuff in flow analysis, which I think would not need to be altered? Given an expression a?.b, if we can ask if a is definitely unassigned, then we could report.

Excellent. I think that means that we'll need to check in the resolver rather than afterward, but I think that's where most of the dead code analysis happens anyway.

https://dart-review.googlesource.com/c/sdk/+/266381

This fix was reverted.

https://dart-review.googlesource.com/c/sdk/+/266920


[Master] Do not touch the connections in fcp database in get_available_fcp

We should just set the assigner id and not change the connections
in get_available_fcp. The connections are maintained in attach and detach
steps.
Signed-off-by: dyyang<EMAIL_ADDRESS>

I can't judge the logic here as that might need deeper understanding, anyway in the team read it already?
the code itself looks good,
/lgtm


Line to mark new/unread messages

I'm using this library in an app, and we want to add a "New Messages" line, something like Slack has. I know this library wants to mimic iOS Messages (which does not have this), but I think that since it is so widely-used and extensible, other developers may also want this feature.
I'm going to have to implement this either way, so I figured it would be cool to see if this is something you want in this project. If so, I'd appreciate a little direction on a preferred method to implement this, as I can think of a few ways of getting this in the collectionview. E.g. it could be a cell, a header (with "read" and "unread" sections), or a view that is inserted by the layout.

Thanks @rosslebeau ! :smile:
I'm actually not sure if I'm familiar with what you're describing in Slack — can you post a screenshot?

Sure, here's an example:

I find this very useful for chat threads which have important messages you don't want to miss (like for work, or in my case, medical correspondence).

Ahh I see. :+1:
So, right now this isn't supported for one major reason:
The collectionView in JSQMessages is item-based, not section-based. That is, it is a single section with many items, rather than having 1 item per section with multiple sections.
If it were section-based, this would be trivial. You could implement your own supplementary footer view and return it.
However, v8.0 of the library will address this, as it will be moving to a section-based layout.
As far as including something like this in the library, I think:

JSQMessages shouldn't contain any logic around finding new/old messages. That's too client-specific.
Thus, I think this view it a bit too client-specific.

The goal however would be to make this as easy as possible for clients to do, thus 8.0 :smile:

Oh, I didn't think the library would handle any logic around finding the old/new ones. I figured there would be some kind of delegate call to ask for the index of the last-read message when reloading data.
Yeah, with sections this will be simple, and I'm glad you're going that way...unfortunately I'm not sure I can wait until 8.0 is released. I guess if it's not usable by the time I need this, I'll have to hack in my own thing in the meantime.
I'm closing this issue since this is basically in the roadmap already. Thanks!

Thanks @rosslebeau ! :smile:
Sorry it's not ready yet! :sweat_smile: You can follow the progress on v8.0 here: https://github.com/jessesquires/JSQMessagesViewController/labels/new release roadmap

@rosslebeau  sorry for interacting inside this... but if you done new/unread message Line can you help me by posting some tips.. and code. hope you will done this..

@sreeji44 I have not done it, as it hasn't come up on my roadmap yet and I'm hoping JSQMessages v8.0 will be done first 😄 right now it will likely be a decent amount of work for such a small feature. It should be easy in v8.0.

@rosslebeau :) thankz for the reply and i also need to find it quickly as possible for my mission..  JSQMessage v8.0 when will release that  version 😄


Fix tests that rely on English messages.

The changes where the message bundle interface was used may not be needed if the same locale is used for tests and the server boot. However testing with -Djvm.args.other=-Duser.language=de only boots the server with the locale and the test itself will still run under the users default locale.
This is a test run with translated messages added https://ci.wildfly.org/viewLog.html?buildId=63595&.

Full integration - Windows Build 3615 outcome was FAILURE using a merge of 2619a2d9202de482aa7224f39e3d55cbc4d318ff
Summary: Execution timeout (new); tests passed: 4050, ignored: 115 Build time: 02:02:19

Core - Full Integration Build 5231 outcome was FAILURE using a merge of 2619a2d9202de482aa7224f39e3d55cbc4d318ff
Summary: Execution timeout (new); tests passed: 4012, ignored: 113 Build time: 01:25:14

At least some of the failures are legitimate. It looks like in the German translation the ' was changed to ". The test should likely just ignore quotations.

@jfdenise please approve the BasicOpsTestCase part.


Khadim's Clone created

🛠 Fixes Issue
Closes #543

👨💻 Changes proposed

Create a UI Clone of Khadim's India Website

✔ Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Nothing specific

📷 Screenshot

s

@gurjeetsinghvirdee Pls review this PR


Updating picard to 3.2.0 fails pipeline level tests

          New error coming out of Picard:

A field field parsed out of a read name was expected to contain an integer and did not. Read name: SRR6357072.6014972. Cause: String 'SRR6357072.6014972' did not start with a parsable number.

Originally posted by @maxulysse in https://github.com/nf-core/rnaseq/issues/1335#issuecomment-2242357830

Issue is most likely due to read group names coming from the test data, could be probably be solved with some smart args
cf https://gatk.broadinstitute.org/hc/en-us/community/posts/360074797471-Read-Names-of-Public-Fastq-Files-incompatible-with-Picard-s-MarkDuplicates

This is currently fixed by a patch that keep the same version of picard, but issue is most likely still there and will need fixing in future update, so let's keep this issue open for now


Add rustrepo.com

Obvious github scraper
https://rustrepo.com/repo/hyperium-hyper-rust-http-client
https://github.com/hyperium/hyper

pred to myself derp


Missing column "Tags" in table "Test Metrics"

After update to version v3.2.0 the column disappeared...

Due to limited space made tag to show on demand
'-t', '--showtags',
default="False",

Users can enable tags using above option like robotmetrics -t True

Ok, this new option does solve my issue.
Thank you for this quick answer!


Icon request: TryHackMe

URL for the brand / site / app
https://tryhackme.com/
Logo resources for the icon
https://assets.tryhackme.com/img/logo/tryhackme_logo_full.svg
https://assets.tryhackme.com/img/THMlogo.png (color)
Proof of the Aegis-compatible 2FA
https://github.com/2factorauth/twofactorauth/pull/7237

Anything else?
TryHackMe is a platform for learning and practicing ethical hacking and cyber security skills. It provides online virtual labs and challenges for users to develop and improve their hacking skills in a safe and controlled environment. Users can also interact and collaborate with other members of the community to enhance their learning experience.
Confirmation

[X] I have read and followed the issue guidelines & issue form.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/icons/1_Primary/TryHackMe.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


counter clockwise rotation quirk

subtle yet annoying bug: when rotating continually counter-clockwise with mouse, the ship will flip around the other way to correct.
> 0
^ 1.6
< 3.14
v 4.7
> 6.2
^ 7.6       <- problem

edit: probably the -1.57 in -atan2 finally resolved in f0d2a65
edit: its not the atan2...
I suspect its to do with getAngularImpulse

no longer able to reproduce.


Project Manager issue

If you change something on Editor's settings, like the Display Scale, you have to restart Godot, nothing wrong whit that, but when Godot get restarted the project manager is restarted too, so you have to import all your projects again, i dunno if this is a bug or what, but is annoying .
1- Go to editor settings, change something and restart Godot
O.S Windows 7 64 bits
Godot 3.1 alpha
Edit: After all this has nothing to do with the Editor Settings, if you close and open Godot, the editor maganer will not save your projects dirs -_-

This sounds like the same issue as #21823, a fix for which was recently merged into the master branch with #21927.
You can try compiling the latest master if you want to make sure.

Duplicate of #21823.


fix(cli): update text

:tada: This PR is included in version 0.1.0-alpha.2 :tada:
The release is available on:

GitHub release
v0.1.0-alpha.2

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.1.0 :tada:
The release is available on:

GitHub release
v0.1.0

Your semantic-release bot :package::rocket:


fix: adjust dialog overflow

Description
As per title
Test

[x] I have added tests that prove my fix is effective or that my feature works

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8370f45). Click here to learn what that means.
The diff coverage is 88.23%.

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage        ?   94.59%
=======================================
  Files           ?       44
  Lines           ?      481
  Branches        ?      212
=======================================
  Hits            ?      455
  Misses          ?       25
  Partials        ?        1

:tada: This PR is included in version 0.26.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Extract BurnedInAnnotation to a higher level to give the user the ability to set it when needed.

Burned In Annotation is probably a rare use case, but there could be some equipment which prints the date or something else on the image itself.

Check with functional profile first. What level of burned in annotations support is required?


[Bug] SiCFoI not being picked up as HDR

Which Guide
Sonarr
Describe the Error in the Guide
SiCFoI does not include HDR in the release name so it's not being picked up as HDR
Tom.Clancys.Jack.Ryan.S02E07.2160p.UHD.BluRay.Remux.HEVC.TrueHD.7.1.Atmos-SiCFoI
Expected behavior
For it to be picked up as HDR even where the release name doesn't mention it

Hmm, need to check if that's the case with all their releases, like framestor does

Hmm, need to check if that's the case with all their releases, like framestor does.
Which Sonarr version are you running ?

<IP_ADDRESS>1

@FonduemangVI I think you do remuxes for Sonarr don't you ?

@FonduemangVI I think you do remuxes for Sonarr don't you ?

Yep I did them. Let me take a look

@TRaSH- just did some research it looks like SICFoI doesn't include HDR in their naming but their 4k remuxes do have HDR

Tried it again using the updated custom format for HDR but it doesn't seem to be working as I can't see any score being assigned to it but HDR (undefined) seems to be working fine and also SDR custom format seems to be missing SiCFoI

It should be recognized as HDR undefined and not as HDR
After import it will recornize the correct HDR metadata
Good catch for the SDR
I will ask someone to add them ASAP being I'm already at my work and don't want to do this on my phone.

It should be recognized as HDR undefined and not as HDR After import it will recornize the correct HDR metadata Good catch for the SDR I will ask someone to add them ASAP being I'm already at my work and don't want to do this on my phone.

Well in that case everything seems to be working fine when it comes the HDR custom format also thanks for getting this issue fixed.

.

Glad to hear it's working. Sorry I missed the SDR I'll get it added shortly.


Makes Upgrades Configurable

Allows setting how many upgrades should go into a machine. Works for <8
and >8 equally well. Also adjusts new max stacksize of Upgrades
depending on how many allowed in machines.

A lot of people have been complaining on my server that Energy Upgrades are too op, this should solve it :)
It will also allow upgrades to go beyond the current 8x and they work just like expected!

Would reducing max upgrade multiplier not work?

Sorry, but I'd rather not do this - you can do exactly what you want by reducing the multiplier, as @unpairedbracket said.  The upgrade system has been refactored for v8, and I don't want to have extra config entries when I don't need them.

Reducing the max multiplier will have what effect exactly? It's going to screw over speed upgrades as well. I also don't see how more config entries are harmful, most users don't even look at them.


refactor: use lazy injection token for router listener

Issue or need
Same as #902 for router listener

Proposed changes
Same as #902 for router listener

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#913  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Increment Version

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/39655
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.7.0 -m "<description of version>" 74735b0d78f8ad399d5b808b237bf7d7dab153eb
git push origin v0.7.0


Hope to provide support for the loongarch64 architecture

our company has a large demand for loongarch, which does not require all features to be met. We can ensure that most types of text metadata can be extracted.

Hi sxj2024, and thanks for your comment.  Adding support for new platforms is a commercial decision that OpenText takes on a case-by-case basis.  Please contact your sales representative to continue the discussion.


Add Parameters as an immutable version of Config

Fix #192
Changes

Add Parameters class
Make Context#interrupt a macro
Move common package to other module due to the macro Context#interrupt
Default parameters are increased.

TODO

[ ] Update JavaScript package

Codecov Report

Merging #202 (467879c) into main (fba06f5) will decrease coverage by 0.06%.
The diff coverage is 99.31%.

@@             Coverage Diff             @@
##              main     #202      +/-   ##
===========================================
- Coverage   100.00%   99.93%   -0.07%
===========================================
  Files           50       50
  Lines         2297     1663     -634
  Branches       110       83      -27
===========================================
- Hits          2297     1662     -635
- Misses           0        1       +1

Impacted Files
Coverage Δ

...cala/codes/quine/labo/recheck/common/Checker.scala
100.00% <ø> (ø)

...n/scala/codes/quine/labo/recheck/fuzz/Seeder.scala
100.00% <ø> (ø)

...cala/codes/quine/labo/recheck/vm/Interpreter.scala
99.25% <85.71%> (-0.75%)
:arrow_down:

...la/codes/quine/labo/recheck/cli/AgentCommand.scala
100.00% <100.00%> (ø)

...main/scala/codes/quine/labo/recheck/cli/Main.scala
100.00% <100.00%> (ø)

...scala/codes/quine/labo/recheck/codec/package.scala
100.00% <100.00%> (ø)

...cala/codes/quine/labo/recheck/common/Context.scala
100.00% <100.00%> (ø)

...a/codes/quine/labo/recheck/common/Parameters.scala
100.00% <100.00%> (ø)

...odes/quine/labo/recheck/common/cancellations.scala
100.00% <100.00%> (ø)

...rc/main/scala/codes/quine/labo/recheck/ReDoS.scala
100.00% <100.00%> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba06f5...467879c. Read the comment docs.


Add labels for interop with AI Workbench

Adds a list of NVIDIA AI Workbench required labels to the notebooks images allowing it to work there with further tweaks.
This required a small change to the compute matrix to separate the linux distro & version.

/merge


[3.0] InternalThreadLocal extend ThreadLocal for compatible

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9710 (55d1d62) into 3.0 (82c1b03) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.0    #9710      +/-   ##
============================================
- Coverage     65.69%   65.37%   -0.32%
+ Complexity      296      293       -3
============================================
  Files          1192     1193       +1
  Lines         52185    52346     +161
  Branches       7926     7925       -1
============================================
- Hits          34282    34222      -60
- Misses        14211    14380     +169
- Partials       3692     3744      +52

Impacted Files
Coverage Δ

.../dubbo/common/threadlocal/InternalThreadLocal.java
79.41% <ø> (ø)

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
55.55% <0.00%> (-33.34%)
:arrow_down:

...pache/dubbo/common/function/ThrowableFunction.java
71.42% <0.00%> (-28.58%)
:arrow_down:

...ing/zookeeper/curator/Curator5ZookeeperClient.java
42.02% <0.00%> (-27.54%)
:arrow_down:

...lient/event/RetryServiceInstancesChangedEvent.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...nt/metadata/ServiceInstanceHostPortCustomizer.java
65.78% <0.00%> (-21.06%)
:arrow_down:

...ache/dubbo/rpc/proxy/InvokerInvocationHandler.java
68.00% <0.00%> (-16.00%)
:arrow_down:

...mmon/threadpool/support/AbortPolicyWithReport.java
70.17% <0.00%> (-14.04%)
:arrow_down:

...che/dubbo/metadata/AbstractServiceNameMapping.java
83.80% <0.00%> (-13.17%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c1b03...55d1d62. Read the comment docs.


Feature Request - Synchronous version of .put() and .add() methods

Currently, .put() and .add() methods of ydn.db.Storage is asynchronous. This is a request for a synchronous version of these methods, either as separate methods or an optional parameter.
Class: ydn.db.Storage
Methods: .add() and .put()

According to indexedDB API version 1, only asynchronous version will be supported. So it is not possible to provide synchronous methods by the library.


[file_crash_bug] KeyError: 'cf_status_firefox125'

2024-05-14 00:41:15,729 - ERROR - Rule file_crash_bug
Traceback (most recent call last):
  File "/home/rm_bot/bugbot/bugbot/bzcleaner.py", line 850, in run
    self.send_email(date=date)
  File "/home/rm_bot/bugbot/bugbot/bzcleaner.py", line 766, in send_email
    data = self.get_email_data(date)
  File "/home/rm_bot/bugbot/bugbot/bzcleaner.py", line 684, in get_email_data
    bugs = self.get_bugs(date=date)
  File "/home/rm_bot/bugbot/bugbot/rules/file_crash_bug.py", line 235, in get_bugs
    updates = bug_analyzer.detect_version_status_updates()
  File "/home/rm_bot/bugbot/bugbot/bug/analyzer.py", line 144, in detect_version_status_updates
    if self._bug[flag] != "---":
KeyError: 'cf_status_firefox125'

Again:
2024-07-07 00:40:50,941 - ERROR - Rule file_crash_bug
Traceback (most recent call last):
  File "/home/rm_bot/bugbot/bugbot/bzcleaner.py", line 856, in run
    self.send_email(date=date)
  File "/home/rm_bot/bugbot/bugbot/bzcleaner.py", line 772, in send_email
    data = self.get_email_data(date)
  File "/home/rm_bot/bugbot/bugbot/bzcleaner.py", line 690, in get_email_data
    bugs = self.get_bugs(date=date)
  File "/home/rm_bot/bugbot/bugbot/rules/file_crash_bug.py", line 235, in get_bugs
    updates = bug_analyzer.detect_version_status_updates()
  File "/home/rm_bot/bugbot/bugbot/bug/analyzer.py", line 144, in detect_version_status_updates
    if self._bug[flag] != "---":
KeyError: 'cf_status_firefox127'

Merge day for Firefox 129: July 8, 2024