Training a new model with different scaling factor

Hi there,
If I want to train a new ESRGAN model, a 2.5x upsampling/downsampling factor, for example, how do I get the corresponding pre-trained PSNR model?

I think you can use the weights of pre-trained X4 ESRGAN  to initialize the X2.5 model, except the upsampling layer.

@chhsieh0309  have you successfully trained the model with 2.5x scale factor? I was able to train with scale factor of integer values (e.g. 2x, 4x), but not sure how to train a model with non-integer scale factor (e.g. 1.5x, 2.5x).

@chhsieh0309 have you successfully trained the model with 2.5x scale factor? I was able to train with scale factor of integer values (e.g. 2x, 4x), but not sure how to train a model with non-integer scale factor (e.g. 1.5x, 2.5x).

why not just use 4x and then downsample to 2.5


Add Spark to configuration

Adds support for overriding the default Spark properties (sparkMaster, driverMemory) in application configuration file
These properties can be overridden within specific provider configurations
Add generalized harvester configuration properties which will support all harvester options (API, OAI etc.)

To invoke any harvester you will need to provide three parameters:

The harvest output location
Path to the application configuration file
Abbreviated of the provider (this is need to select the correct configurations from the application.conf file)

Sample application.conf file
# Default Spark configuration
spark.master="local[*]"
spark.driverMemory="2g"

# Harvard
harvard.provider = "Harvard"
harvard.harvest.type="oai"
harvard.harvest.endpoint = "http://vcoai.lib.harvard.edu/vcoai/vc"
harvard.harvest.metadataPrefix = "mods"
harvard.harvest.setlist="dag,lap,crimes,scarlet,manuscripts,eda,cna,ihp,ward,rubbings"
harvard.harvest.verb = "ListRecords"
# Overrides the default sparkMaster value
harvard.spark.master = "local[1]"

# CDL
cdl.provider = "California Digital Library"
cdl.harvest.type="api"
cdl.harvest.rows = "500"
cdl.harvest.query = "-type_ss:dataset"
cdl.harvest.apiKey = ""
cdl.spark.master = "local[3]"```

Closing this in favor of PR #78


[CI] Delete environments for secrets

Description
We've decided to stop using environment for secrets.
I've delete all the env usages in actions.
Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

@l0uden - could you provide a bit of context? Why did we decide to not use any environment variables anymore? What's the benefit of this change now? 😄
I can approve based on pure code changes, but I am not sure why we have to do this? What was so bad about our previous approach?

First of all we don't need environments for the secrets any more because forked PRs by default can't run workflows with ANY secrets inside. It is fine for us.
Second is that current PRs conversations are hard to read because of multiple messages about deploy failures for the environments.

First of all we don't need environments for the secrets any more because forked PRs by default can't run workflows with ANY secrets inside. It is fine for us. Second is that current PRs conversations are hard to read because of multiple messages about deploy failures for the environments.

Ah okay, so we basically remove the "deploying secrets step". Fine for me 👍


HOTT-3032: Populate and filter search suggestions

Jira link
https://transformuk.atlassian.net/browse/HOTT-3032
What?
I have added/removed/altered:

[x] Added full chemicals when populating search suggestions
[x] Make use of types (behind a feature flag) when filtering suggestions for the numeric and text type searches
[x] Updated test coverage
[x] Populated environment variables

Why?
I am doing this because:

This enables us to use the recently populated types to filter the
specific kinds of search suggestions.
It also improves performance by removing the expensive similarity checks where 99% of the value comes from the ilike

Okay, just validated on dev:

Using the search suggestions without the type populated
Populated the new suggestions and with feature flag off
Populated the new suggestions and with feature flag on

All working as expected


Constructive review in hn comment

Thank you for sharing this and making it available. I'd just like to draw attention to a very thorough comment on hn, that contains a handful of concrete suggested changes - some that improve the CSS - but keep the general look, some suggestions for changes.
Feel free to close this issue as #wontfix if you don't find it relevant.
chrismorgan's comment:
https://news.ycombinator.com/item?id=35709793

I'm going to add this entire comment. There are probably a whole list of issues to add here...
Another minimalist CSS framework, another review from me. :-)

:root { color-scheme: dark light; }

The stylesheet is written with light values by default, and dark values in a prefers-color-scheme media query. Therefore, this should be color-scheme: light dark instead. As written, if no preference is expressed, your styles will be light, but UA styles will be dark.

{ box-sizing: border-box; }

I personally am one of the rare contrarians that prefers content-box for the web (simplifying my position a lot: good responsive design bases sizes and such on content, not layout). But if you’re going to change it to border-box, you might want to consider changing it on pseudoelements (at least ::before and ::after) as well. Then again, you’re not using them. Then too, the whole box-sizing declaration seems no-op.

{ color: var(--dark); }

That’s… um… courageous. No, I can’t leave it at that: this is a very bad idea. This will make custom styling painful, may ruin elements that have backgrounds set in the UA stylesheet (e.g. input, mark), and I detest links being the same colour as the surrounding text.

:root { --light: …; --dark: …; }

I don’t like how these two variables are used: you’re using them as #defines (to use C preprocessor lingo) rather than what custom properties can be, and end up with significant duplication because of it. Consequently, every time you use --light or --dark, you have a counterpart the other way round in the tail @media (prefers-color-scheme: dark) block (except that input[type=submit]’s counterpart is just input; I’ll remark on that later). Here’s how you should do it:
:root {
--bg: #fff;
--fg: #404040;
}
@media (prefers-color-scheme: dark) {
:root {
--bg: #404040;
--fg: #fff;
}
}
… and then use --bg and --fg throughout, and need no more dark color scheme media query at the end. You could define two colours and have --bg and --fg use them, but because of how light works, you may not want to just swap the two colours—for example, you might want to darken both --bg and --fg in dark mode (it’s currently fairly bright for a dark mode; something like #eee on #333 would be more common).

html { border-style: solid; border-width: 5px 0 0 0; border-color: var(--dark); }

Shorter written in the :root block before it and as border-top: 5px solid var(--dark). As for what it represents, I don’t like it. It’ll tend to be an eyesore, especially on dark. If it was a colour, sure, but just --light or --dark? Nah, don’t like it.

font-family: sans-serif;

Thank you for a sensible font-family.

px

There’s quite a bit of not-great usage of pixels. Remember that the root em is not necessarily 16 pixels, so for correctness most px things should actually be defined font-relative. As a simple rule of thumb, take any px value, divide by 16 and change the unit to rem. (Single-pixel lines are about the only place I can think of where px is genuinely what you want, though even then it’s still not guaranteed to be a crisp single pixel, due to possible fractional scaling.)

p { margin-bottom: 10px; }

This doesn’t do what you probably intended. Indeed, in the sample document, I think it does nothing: remember that most of your flow content elements have 1em block margin, which is (likely) greater than your 10px, and margin collapse applies.

p { line-height: 1.4em; }

Dubious: now anything that’s not inside a  uses some other line-height. You probably want to specify line-height on the root element. Remember that line-height accepts a unitless value, too, to be calculated relative to each element’s font-size, whereas em fixes it. Me, I’ve actually started experimenting with this, to conveniently reduce otherwise-extravagant leading in headings:

{
line-height: calc(1em + 0.5rem);
}

That is, 1rem (16px) body text gets line-height 1.5 (24px), 2rem (32px) heading gets line-height 1.25 (40px).

img { width: 100%; }

This needs height: auto, or else  (which you should strongly prefer, to avoid layout reflow as the image loads) will get a mangled aspect ratio. Also consider using max-width instead of width.

button, .button, input[type=submit]

I’m not fond of various of the styling here. I reckon it could do with a hover/focus-visible colour change, and no cursor: pointer, among other things.

button:last-child, .button:last-child { margin-right: 0; }

This kind of thing is smelly.

ol { column-count: 2; }

This is a phenomenally bad idea. Some opt-in class, maybe. Numbered lists in general, no.

.row .column:not(:last-child) { margin-right: 10px; }

Better, provided you’re OK with as low as two years (to the day!) of browser support (https://caniuse.com/flexbox-gap): .row { gap: 10px }.

Put in four columns and you'll get four equally sized columns.

Not true, actually; put something too big in one column and it’ll cause the other columns to shrink. That’s what you get for using flexbox! (Grid, by contrast, is… well, more size-is-defined-by-the-parent-and-the-children-are-welcome-to-lump-it.)
Really, I don’t like the columns arrangement. I much prefer to use flexbox with flex-wrap and sensibly-chosen flex-{basis/shrink/grow}, so that the content defines when things can fit beside one another or wrap. The current .row and .column arrangement is much too fiddly, specific, and weird. Also the .column class name is superfluous, should have just used .row > *.

input

I said I’d address this later, but I’ve taken too long on this. Suffice it to say that there are problems with how form elements other than buttons are handled in diverse colouring situations. Either override (nigh-) everything, or nothing. Never override just one of background and foreground colour.

I've added height: auto to the img to prevent the layout reflow on my blog post About Protective Merics on another one of my projects. I noticed it primarily because of this feedback even though I often look at my own stuff on a fast connection.

I'm starting to work through these and I'm struggling with the "--dark" and "--light" variables. I wish I could have this conversation with the original author. I like the suggestion, as it simplifies the dark theme, but the same problem happens with elements that you want inverse. For example, you're now setting the buttons foreground color to the "--bg" value and that feels wrong. I also tried to avoid using color names in case someone wants to change the color scheme. If you wanted to use a dark red, instead of black, you could just change "--dark" to your dark red color. If I had used "--myblack" it would no longer make sense. On the flip side, your dark red is still "dark". So, dark and light still make the most sense to me. Perhaps I simply disagree with the variable naming in this point but I agree on using the :root element to swap them for dark mode.
I'm hard pressed to come up with variable names that don't have this same problem.

I'm gone through this list and implemented a lot of what is suggested here. The suggestions I didn't take into account are mostly opinions about design decisions rather than problems with syntax of my css. I've also left the columns alone because I didn't have the time, this round, to look at those details. These changes are currently just on my local machine, but I'll probably push them soon. I also need to do a bunch of tests against some of my other designs that are using this framework already. I did check it with the sample page as well as the shop in neatcss-examples. I probably need to figure out a strategy for testing this against a lot of my existing sites that are using the current version. There could be some breaking changes in this version.

 I mostly disagree with the column suggestions. I've added some comments to the docs, however, about the possibility that a column will resize if you add content that is too large as well as an option for changing your custom.css so that doesn't happen.
Because this changes a lot, because a few of the changes are not backward compatible, and because I'm using neat on tons of little projects now, I've pushed all these changes out as v1.0.1.


Revert "[Importer] Wrap the VFS passed to Clang with an overlay FS instead"

Reverts apple/swift#41546.
OverlayFileSystem does not store a separate CWD and instead calls setCurrentWorkingDirectory on all filesystem's it contains. We don't want Clang to be able to set Swift's CWD.

@swift-ci please test

My plan here is to use a small subclass of ProxyFileSystem instead. Should I just go ahead and do that instead of the revert?


read_float_parameter and/or read_float_from_inline_function(str)

In my code, I use a function to read out a float parameter from ANSYS into python. Something like
def read_float_parameter(mapdl, parameter):
    line = mapdl.run(str(parameter) + " = " + str(parameter))
    return float(re.search(r"(?<=\=).*", line).group(0))

I call it read_... instead of get_...  to avoid confusion with the ANSYS *get, which is used e.g. with mapdl.get_float(). On the other hand, my only use case right now is ANSYS inline-functions (all other use cases have been solved via mapdl.get_float()).  For example:
mapdl.run("node_maxx=node({},{},0)".format(par1, par2))
sim_result.node_minx = read_float_parameter(mapdl, 'node_minx')

Maybe a better aproach would be a method read_float_from_inlinefunction()? Or both? If interested, I could implement one or both of these functions as methods for Mapdl.

Seems useful.  Please add a pull request and I'll look it over.


error when I run spotifpod.py

When I Spotifypod.py manually it in the terminal it just spams 'no ints'  and I've looked on every issue and read the comments and I can't seem to find a solution for this problem any help im kind of a noob to all this.

same issue, looks like there is connection problems.

You have to do a refresh data !

@doris1347 could you be more specific, please?

Synchronize Spotify Data
Synchronizing Spotify data! Last but not least, if you want to make sure all your playlists artists, etc are synchronized every time you turn on your Spotypod, you can simply modify the script view_model.py
sudo nano view_model.py
go to line 16
#spotify_manager.refresh_devices()
spotify_manager.refresh_data()

Be sure to throughly read issue 69!

Good Luck! 😊✅

Another suggestion is to create a file called testit.py with the following 3 lines:
import spotify_manager
from functools import lru_cache
spotify_manager.refresh_data()
and then run it from the command line:
python3 testit.py
This will only work if you got a .cache file, I think. But if you're good to go you should see output to the screen as it downloads playlists, artists, etc.
Have Fun! 😊✅

When you make a track selection (http request) with the "sPoT" you will see it as being selected in the Spotify app. device list (and your selection will start playing) ### as long as your audio endpoint (bluetooth) is configured and working if not your selected track will only increment 3 seconds and dropout. the same will happen if you first select your device using another authorized Spotify client, if your audio endpoint (Bluetooth) isn't up and running your connection will dropout after approx. 3 seconds!


Add CocoaPods frameworks support

The sqlite3.h must be imported as a system header to be able to use
use_framework with CocoaPods.

Thank you!


How to redirect after password change

I've setup user accounts and added basic pages.
I've made my Profile page with a link to change-password page. When I open it I see:

After changing password I get

I've tried to find any options to redirect user after successful password change, but have no luck.
Also I've tried to redirect user manually via History object, but I'm staying on the same page.
Here is my current accounts.ui config:
Accounts.ui.config({
  passwordSignupFields: 'EMAIL_ONLY',
  loginPath: '/sign-in',
  signUpPath: '/sign-up',
  resetPasswordPath: '/reset-password',
  changePasswordPath: '/change-password',
  profilePath: '/profile',
  homeRoutePath: '/',
  minimumPasswordLength: 6,
});

And React Router 4 routes (RouteLayout is just wrapper function around default Route component)
<RouteLayout layoutProps={{account: true}} path="/sign-in" component={() =>

<Accounts.ui.LoginForm />
} />
<RouteLayout layoutProps={{account: true}} path="/sign-up" component={() =>

<Accounts.ui.LoginForm formState={STATES.SIGN_UP} />
} />
<RouteLayout layoutProps={{account: true}} path="/change-password" component={() =>

<Accounts.ui.LoginForm formState={STATES.PASSWORD_CHANGE} />
} />
<RouteLayout layoutProps={{account: true}} path="/reset-password" component={() =>

<Accounts.ui.LoginForm formState={STATES.PASSWORD_RESET} />
} />

I faced the same issue and could not find a solution so I added a redirect (I am using React Router v4) in onSubmitHook callback :
<Accounts.ui.LoginForm
   onSubmitHook={(error, formState) => this.props.history.push('/some-url)}
/>

You can check for formState in the callback to redirect to different URLs depending if its a login or enroll etc...


Care Controller: Remove evicted pods in Shoots control plane namespace on a Seed.

What this PR does / why we need it:
The care controller removes evicted pods in the Shoot control plane of a Seed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checkout the PR and run the Gardener locally. Deploy a cluster and wait until it is created.
Then deploy a pod, which consumes plenty of memory e. g. via dd bs=8G if=/dev/zero of=/dev/null, in the Shoot namespace on the Seed cluster.
Release note:

There was an issue where evicted control plane pods in the shoot cluster namespace confused the health check into assuming the shoot cluster control plane is broken. Gardener will now delete these evicted pods prior to its actual health check and thereby avoid false alarms.

Thanks! I would rephrase the release note a bit (hide the implementation details and add the benefit):

There was an issue where evicted control plane pods in the shoot cluster namespace confused the health check into assuming the shoot cluster control plane is broken. Gardener will now delete these evicted pods prior to its actual health check and thereby avoid false alarms.

Thanks @vlerenc. I took it in the text :)

@mvladev Could you please also have a look?


Support for jsr: deps

I haven't actually had a chance to use JSR yet, but my favorite Deno-native lib will soon likely be a JSR exclusive.

deno's stdlib will also soon be a jsr exclusive.


Use openjdk8 instead of oraclejdk8 in build

Not sure if this fixes the build yet, looking to test

This seems to bring the build back to normal
https://travis-ci.org/donbeave/graphql-java-datetime/builds/623424859

@bugflux Thank you!


Devlogs for a project are not paginated

Description:
Devlogs for the projects are not paginated currently. Ideally we should have next&previous buttons for navigation.
Steps to reproduce

Add a lot of devlogs (.md files) in the directory src/content/blog/neura-launch
Go to http://localhost:3000/projects/neura-launch/
Verify that there's no pagination

Possible Fix
We have pagination logic already implemented for posts so one can consider reusing the same logic here for devlogs too.

@TarunTomar122 assign me this issue please. Thank you.

@XanderWatson  are you actively working on this issue?

@XanderWatson are you actively working on this issue?

Ummm will do after minors


FSM Suspicious Users

Description
initial release of Suspicious Users policy
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:

  Generated by :no_entry_sign: Danger

          1 Error

:no_entry_sign:
The URL is not valid: http://docs.rightscale.com/policies/ in saas/fsm/suspicious_users/fsm-suspicious_users.pt Status: 301

  Generated by :no_entry_sign: Danger


chore: avoid adding .build directory to client's workspace

Pass --build-path to select swift package calls that are executed during update-repos (i.e., //:swift_update_pkgs).
Remove obsolete .bazelignore files.
Remove call to utility that cleans up .build directories.

Closes #758.

cc: @jpsim @AttilaTheFun

Would be good as well to release a new version with this change + some of the other stuff we've merged

Sweet this is helpful, we can now remove our .bazelignore in our project as well

Yes. If you run into an issue, please let me know.


OCPBUGS-29196: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions

When trying to set up KMS encryption in us-isob-east-1 region validation fails on the custom resource.

/ok-to-test

/assign @patrickdillon @JoelSpeed
to review the API change

/retitle OCPBUGS-29196: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions
see also: current list of aws partitions

/jira refresh

Looks okay to me, but needs a rebase.
/retest

@dobsonj just rebased, pls take a look

Thanks @ungureanuvladvictor !
/lgtm
needs approval from @JoelSpeed to merge

/lgtm

@dobsonj -- I was looking at the CSI drivers repo and not sure how you folks want to proceed with bumping this in the https://github.com/openshift/aws-ebs-csi-driver-operator + https://github.com/openshift/csi-operator. For the csi-operator I think it's p easy because the repo is active, but for the aws-ebs-csi-driver I don't have insight into how backports work there.
Let me know if I can help in any way here.

So much for the cherrypick bot
/jira help

/cherry-pick help

API backport to 4.15: https://github.com/openshift/api/pull/1767

@dobsonj -- how far back do you folks usually backport ?

@dobsonj -- how far back do you folks usually backport ?

To fully supported releases, which right now means 4.14.
https://access.redhat.com/support/policy/updates/openshift/


esbuild: 0.16.7 -> 0.16.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/evanw/esbuild/releases.
meta.description for esbuild is: "An extremely fast JavaScript bundler"
meta.homepage for esbuild is: "https://esbuild.github.io"
meta.changelog for esbuild is: "https://github.com/evanw/esbuild/blob/v0.16.10/CHANGELOG.md"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.16.10 with grep in /nix/store/5djmf0cba4yz171v74rmf9yz5cwp5q3a-esbuild-0.16.10
found 0.16.10 in filename of file in /nix/store/5djmf0cba4yz171v74rmf9yz5cwp5q3a-esbuild-0.16.10

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath
code-server
esbuild
libsForQt5.bismuth
openvscode-server
plasma5Packages.bismuth
quarto
vscode-extensions.matklad.rust-analyzer
vscode-extensions.rust-lang.rust-analyzer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5djmf0cba4yz171v74rmf9yz5cwp5q3a-esbuild-0.16.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A esbuild https://github.com/r-ryantm/nixpkgs/archive/c206ec18dfc2b5c7a1b6995b79e4495266f6f5d4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5djmf0cba4yz171v74rmf9yz5cwp5q3a-esbuild-0.16.10
ls -la /nix/store/5djmf0cba4yz171v74rmf9yz5cwp5q3a-esbuild-0.16.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

code-server
esbuild
libsForQt5.bismuth
openvscode-server
quarto
vscode-extensions.matklad.rust-analyzer

Maintainer pings
cc @Lucus16 @marsam for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/evanw/esbuild/releases.
meta.description for esbuild is: "An extremely fast JavaScript bundler"
meta.homepage for esbuild is: "https://esbuild.github.io"
meta.changelog for esbuild is: "https://github.com/evanw/esbuild/blob/v0.16.12/CHANGELOG.md"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.16.12 with grep in /nix/store/q811z00hnvh5dgniw6mnl7gy1n3dbyyh-esbuild-0.16.12
found 0.16.12 in filename of file in /nix/store/q811z00hnvh5dgniw6mnl7gy1n3dbyyh-esbuild-0.16.12

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath
code-server
esbuild
libsForQt5.bismuth
openvscode-server
plasma5Packages.bismuth
quarto
vscode-extensions.matklad.rust-analyzer
vscode-extensions.rust-lang.rust-analyzer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q811z00hnvh5dgniw6mnl7gy1n3dbyyh-esbuild-0.16.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A esbuild https://github.com/r-ryantm/nixpkgs/archive/754ca17e1f7cfcf9ddee6aa68a29ed8b7e395f58.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q811z00hnvh5dgniw6mnl7gy1n3dbyyh-esbuild-0.16.12
ls -la /nix/store/q811z00hnvh5dgniw6mnl7gy1n3dbyyh-esbuild-0.16.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

code-server
esbuild
libsForQt5.bismuth
openvscode-server
quarto
vscode-extensions.matklad.rust-analyzer

Maintainer pings
cc @Lucus16 @marsam for testing.

This broke deltachat-desktop:
error: both `vendorHash` and `vendorSha256` set. only one can be set.

@cole-h Shouldn't ofborg have caught that?


Add Code of Conduct file

Currently, the repository lacks a Code of Conduct file, which is an essential component for fostering a healthy and inclusive open-source community. A Code of Conduct serves as a guideline for expected behaviour, ensuring that contributors and participants feel safe, respected, and valued within our community space.
Please assign this issue to me.

Currently, the repository lacks a Code of Conduct file, which is an essential component for fostering a healthy and inclusive open-source community. A Code of Conduct serves as a guideline for expected behaviour, ensuring that contributors and participants feel safe, respected, and valued within our community space.
Please assign this issue to me.

Assigned

I have started working on this issue. Could you please label this issue under GSSOC'24 and also label an appropriate level like Level 1, 2 or 3.


Add functionality to skip version bump PRs

Consider adding skip for "Prepare for x.y.z" and "Next is x.y.z" commit messages. But at least for now it seems that wildfly is not using PRs to push these commits so it might not be required.

Isn't this a duplicate issue for #50 ?

yep


Use this project on Windows by pairing to Mac

Can i use this project on Windows by pairing to Mac ?

Severity	Code	Description	Project	File	Line	Suppression State
Error	MSB3073	The command "xcodebuild -project E:\Projects\SlimBindings\firebase\macios\native\analytics\MauiFirebaseAnalytics.xcodeproj archive -scheme MauiFirebaseAnalytics -configuration Release -archivePath E:\Projects\SlimBindings\firebase\macios\native\analytics.build\MauiFirebaseAnalytics-ios.xcarchive -destination 'generic/platform=iOS'  -derivedDataPath E:\Projects\SlimBindings\firebase\macios\native\analytics.build -IDECustomBuildProductsPath='' -IDECustomBuildIntermediatesPath='' ENABLE_BITCODE=NO SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES OTHER_SWIFT_FLAGS='-no-verify-emitted-module-interface' OBJC_CFLAGS='-fno-objc-msgsend-selector-stubs -ObjC'" exited with code 9009.	FirebaseAnalytics.Binding	E:\Projects\SlimBindings\eng\Common.macios.targets	40
Error	MSB3073	The command "xcodebuild -project E:\Projects\SlimBindings\firebase\macios\native\messaging\MauiFirebaseMessaging.xcodeproj archive -scheme MauiFirebaseMessaging -configuration Release -archivePath E:\Projects\SlimBindings\firebase\macios\native\messaging.build\MauiFirebaseMessaging-ios.xcarchive -destination 'generic/platform=iOS'  -derivedDataPath E:\Projects\SlimBindings\firebase\macios\native\messaging.build -IDECustomBuildProductsPath='' -IDECustomBuildIntermediatesPath='' ENABLE_BITCODE=NO SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES OTHER_SWIFT_FLAGS='-no-verify-emitted-module-interface' OBJC_CFLAGS='-fno-objc-msgsend-selector-stubs -ObjC'" exited with code 9009.	FirebaseMessaging.Binding	E:\Projects\SlimBindings\eng\Common.macios.targets	40

Same issue - Cannot run on windows - we use windows and we pair to mac

This was always going to be the case.  The native frameworks can only be built on a mac because of Apple requirements, not Microsoft.

It might be possible to make this eventually work with pair to mac, but for now it will not.  The custom targets used to create the xcframeworks for the slim bindings are not written to use any of the remote pair to mac abilities.  It is likely possible to make the xcode build invocations use tasks that can run remotely, but there'd need to be more work to make the xcode project files copied over as part of this process since they need to build there.
tl;dr - this isn't currently in scope


Consider adding more support for the nRF9160

Many modules are turned off in the nrf-hal-common crate like for example gpiote. The examples are also geared towards 51 and 52.
Is someone working on this? I could give it a try myself but I'm new to embedded programming.

Hi!
We are constantly adding features to the HALs, but of course, pretty much everyone does this in their sparetime, so this is sometimes going slower and sometimes going faster :) I believe not many folks are working with the nRF91 so it's not so well supported.
It would be awesome if you had time & motivation to add more features for it :) Being new to embedded programming is no issue, we love to provide feedback and help where needed :)
You could also join our matrix channel https://matrix.to/#/!dASuPAbUCerhCYFqJs:matrix.org?via=matrix.org for more interactive help :)

Thank you for guiding me to the matrix channel and the breakthrough help I received there. Hopefully, I can get to a stage when I can share my work, soon :)


Investigate Swift Package Manager for Swift plugins

Since Swift has a 'first-party' package manager in the form of Swift Package Manager, it would be interesting to evaluate whether we could use that, instead of CocoaPods, for Swift plugins. That would allow for gradual migration away from CocoaPods over time assuming plugin development eventually shifts toward Swift, rather than having to do an expensive, ecosystem-breaking one-time migration.
According to docs, SPM packages can contain C/ObjC/C++/ObjC++ code, which substantially mitigates the bootstrapping problem; given that people could presumably make SPM packages that wrap existing non-Swift libraries for use in Swift plugins.

Here is the docs: https://github.com/apple/swift-package-manager

The primary open questions at this point:

How difficult will it be to manage the integration into the Xcode project programatically. The generate-xcodeproj approach built into SPM itself looks like it would be awkward at best to manage, so we'll need to investigate Xcode 11.
How to express the Flutter/FlutterMacOS framework dependency; SPM doesn't seem to have a way to encapsulate a prebuilt framework. The details of Xcode project integration may or may address this for the plugin use case (i.e., we may not actually have to formally express the dependency, depending on exactly how the sources are folded in, since the project already includes the framework).

Additional potential blocker:
Swift Package Manager does not yet support resources, so plugins with assets would not be compatible.
https://forums.swift.org/t/swift-pm-bundles-and-resources/13981/30

Although on further research the plugin/ios/Assets directory in the pub package looks unused, so this probably isn't an issue, assuming lookupKeyForAsset:fromPackage: continues to be the suggested way to share assets with the underlying platform.

How to express the Flutter/FlutterMacOS framework dependency; SPM doesn't seem to have a way to encapsulate a prebuilt framework. The details of Xcode project integration may or may address this for the plugin use case (i.e., we may not actually have to formally express the dependency, depending on exactly how the sources are folded in, since the project already includes the framework).

Swift packages are checked out and built into their own directory in DerivedData
~/Library/Developer/Xcode/DerivedData/Runner-fallqhekgvwmlfbtoasqjysdpabc/SourcePackages/checkouts/
Dependent packages are compiled first, so since all plugins depend on Flutter, the Flutter framework but must be either:

Made into a Swift package and included in as Package.Dependency and completely built by SPM.  I wasn't able to get this to work.  I tried a few things, including making Flutter a system module, letting SPM compile it with a .pc file, and just making a module that linked the Flutter framework.  I also explored vending the fat binary out of GitHub, but... ugh.
or
Copy Flutter.framework to the Products Directory in the Flutter app as a Copy Files build phase before the Runner targets are built.  Packages are compiled with framework include search path arg:
-F$HOME/Library/Developer/Xcode/DerivedData/Runner-fallqhekgvwmlfbtoasqjysdpabc/Build/Products/Debug-iphonesimulator
Once Flutter.framework was in the Products Directory, the plugin packages and Runner app built, and the Runner app could import the plugin module.

How difficult will it be to manage the integration into the Xcode project programatically. The generate-xcodeproj approach built into SPM itself looks like it would be awkward at best to manage, so we'll need to investigate Xcode 11.

Just plopping down the Packages.swift and a modulemap in the plugin (to avoid Umbrella directory '$HOME/Library/Developer/Xcode/DerivedData/Runner-fallqhekgvwmlfbtoasqjysdpabc/SourcePackages/checkouts/plugins/packages/url_launcher/ios/Classes/include' not found warnings) seemed to be sufficient to make it a dependency in a Flutter app.  I haven't looked into making the example/ios Xcode project within the plugin yet, but generate-xcodeproj seems promising.
Additional notes:

With a few Build Setting updates I don't see why we can't get rid of the Runner.xcworkspace and just use the Runner.xcodeproj.
I'm not sure how CocoaPods currently handles various packages relying on different versions of Flutter.  With the copy Products Directory trick, the packages aren't expressing what Flutter version ranges they are dependent on.
With the added plugin modulemap, the plugins and apps can be in either Swift or Objective-C without any required code changes.

Does this mean SPM can only have dependencies against source code and not .frameworks officially? And option 2 is essentially a late binding mechanism? cc @blasten, we should keep a conceptual symmetry between Android and iOS where possible.
I have a bit of trouble visualizing what the xcodeproj integration steps are. Can we list them here or in a doc? e.g. flutter upgrade, flutter packages get, cd ios, pod deintegrate, [run some things here that does stuff to .xcodeproj], git commit -am 'I moved the xcode from using cocoapods to spm', profit. What are the steps in between?

1 woohoo
2 https://github.com/flutter/plugins/search?q=filename%3A.podspec+"dependency+'Flutter'"&unscoped_q=filename%3A.podspec+"dependency+'Flutter'". I don't think that's doable for plugins currently either. Though @amirh should double check.

My comments above were all based on my experimentation with the Swift Package Manager and remote repository URLs in Xcode 11.  That would require plugins to have a Packages.swift at the root of their repo.  And all pub packages would need their repository URL set in the metadata.  That seems like a lot to ask.
A more realistic scenario would be to create local packages from symlinked directories from the .packages in the .pub-cache.  We could also check those plugins for a Packages.swift file and let Xcode handle those, and only do this symlinking fallback/local package creation if it's not present.
I'm still exploring what that would look like and if it's possible.

And all pub packages would need their repository URL set in the metadata

If I understand correctly, that's more or less what we do today with plugins in general in the .packages file.

That would require plugins (and all their plugin dependencies) to have a Packages.swift at the root of their repo

This is probably trickier if we don't have a nice way to auto-convert plugins' existing .podspec to a packages.swift.

For macOS, I'm still willing to break existing plugins (there are very few), so if we think we can get a workable system with SPM we could use it for macOS now without any migration/fallback, and then later potentially add it as an option for iOS with migration tools and/or docs.

Bootstrapping the macOS plugins seems reasonable if we don't identify any dealbreakers for iOS and it's just a matter of gradual migration from .podspecs to packages.swift.

Copy Flutter.framework to the Products Directory in the Flutter app as a Copy Files build phase before the Runner targets are built.

How are you guaranteeing that this step runs before the dependencies are built? Generally Xcode likes to parallelize pretty aggressively, so I wouldn't think that a build phase in the Runner target would have ordering guarantees relative to building the SPM dependencies.

Just plopping down the Packages.swift and a modulemap in the plugin [...] seemed to be sufficient to make it a dependency in a Flutter app.

That would make a plugin into an SPM-compatible package, but my open question (2) was about what exactly is involved in adding that package as a dependency of the Runner project. Were your experiments just doing this via Xcode UI? If so, do you have a sense from resulting diffs how easy it would be to do it programatically?

Copy Flutter.framework to the Products Directory in the Flutter app as a Copy Files build phase before the Runner targets are built.

How are you guaranteeing that this step runs before the dependencies are built? Generally Xcode likes to parallelize pretty aggressively, so I wouldn't think that a build phase in the Runner target would have ordering guarantees relative to building the SPM dependencies.

A Build pre-action script in the scheme that copies the framework over.

Just plopping down the Packages.swift and a modulemap in the plugin [...] seemed to be sufficient to make it a dependency in a Flutter app.

That would make a plugin into an SPM-compatible package, but my open question (2) was about what exactly is involved in adding that package as a dependency of the Runner project. Were your experiments just doing this via Xcode UI? If so, do you have a sense from resulting diffs how easy it would be to do it programatically?

Upon further research, I don't think we can use Xcode's UI for this.  The package must be in a git repository with a Package.swift manifest in the top directory.  Versioning can only be expressed by tag names, so repositories containing multiple plugins would need to be versioned in lock-step.  So tagging won't work for https://github.com/flutter/plugins without breaking out each plugin into its own repo (for example, bumping url_launcher version would mean creating a new tag, which would bump all flutter/plugin versions).
Also, I was wrong about just adding the modulemap to get the Objective-C plugins to compile as a Swift package.  I believe the headers also need to be moved into an include directory.
So we're back to compiling packages symlinked out of the pub cache, probably from a build phase script like xcode_backend.sh.  Still investigating...

Also, this SPM feature would be neat, and Flutter could be distributed as a xcframework:
https://forums.swift.org/t/swift-package-manager-support-for-embedded-xcframework/25420

Swift Package Manager is not yet a viable option to replace CocoaPods for iOS Flutter development as of Swift tools version 5.1.

Binary files, and therefore closed-source frameworks are not supported
Assets like images are not possible to bundle in a Swift packages
All plugin dependencies must also support Swift packages

However, if plugin authors wish to support remote Swift packages, flutter tooling could be altered to respect that configuration, dropping back to CocoaPods when authors have not yet adopted Swift packages.  This would create a CocoaPod-free path for plugin authors and all Flutter developers that may be achievable in the long term.  This adoption could be accelerated with future Swift package features like embedded frameworks and assets.

I know plugin support isn’t an option. But what about for add2app? For the Flutter SDK as a swift package

The current lack of support for prebuilt frameworks prevents packaging the Flutter SDK as an SPM package.

Xcode 12 release notes say:
Swift packages can now contain resources such as images, asset catalogs, storyboards, and other files. When Xcode builds an app that depends on a package, it adds the package’s code and resources to the app bundle for use at runtime. For more information see Bundling Resources with a Swift Package. (54361843)
Swift packages can now vend prebuilt libraries distributed as XCFrameworks, allowing dependencies on libraries that can’t be distributed as source code. When Xcode builds an app that uses such a package, it embeds the libraries into the app bundle. For more information see Distributing Binary Frameworks as Swift Packages. (56592977)

Does the above comment means that it can be done? Can SPM be used to handle plugin additions to Flutter projects?

@netgfx I think it's possible now that Flutter is distributed as an XCFramework (that work hasn't reached the stable channel yet), but it would require quite a lot of work in the flutter tool and ecosystem changes to generate the Package.swift manifest and not break existing CocoaPods plugins.
I did some prototyping in https://github.com/flutter/flutter/issues/72482 that uses that XCFramework for a package distributed in the SDK, not a pub-distributed plugin.

Adding packages to an Xcode project updates the project.pbxproj in quite a few places.
		F76794722633AF3000B24594 /* device_info in Frameworks */ = {isa = PBXBuildFile; productRef = F76794712633AF3000B24594 /* device_info */; };

/* Begin XCSwiftPackageProductDependency section */
		F76794712633AF3000B24594 /* device_info */ = {
			isa = XCSwiftPackageProductDependency;
			productName = device_info;
		};
/* End XCSwiftPackageProductDependency section */

etc.  But we don't want to edit (and potentially corrupt) the Xcode project when plugins are added and removed.
I think we can accomplish this by adding one Swift package that's always present to the template.  And this package module can be responsible for exporting the plugin modules so they are visible to the app.  I'm hoping we can get away with creating all of the following BUILT_PRODUCTS_DIR to enforce Flutter.xcframework build modes.

Update the Xcode project template to add a FlutterFrameworks package.  Ideally this could be created in BUILT_PRODUCTS_DIR during the xcodebackend "Run Script" phase but something tells me that may be too late.  Still need to test this.

F76794702633AF2600B24594 /* FlutterFrameworks */ = {isa = PBXFileReference; lastKnownFileType = folder; name = FlutterFrameworks; path = FlutterFrameworks; sourceTree = BUILT_PRODUCTS_DIR; };

/* Begin XCSwiftPackageProductDependency section */
		F76794712633AF3000B24594 /* FlutterFrameworks */ = {
			isa = XCSwiftPackageProductDependency;
			productName = FlutterFrameworks;
		};
/* End XCSwiftPackageProductDependency section */

and in all the other necessary places, etc.

FlutterFrameworks will contain a Package.swift manifest that's generated by the tool to reference all the plugins, and the engine Flutter framework:
Package.swift

// swift-tools-version:5.3

import PackageDescription

let package = Package(
  name: "FlutterFrameworks",
  platforms: [
    .iOS(.v9)
  ],
  products: [
    .library(
      name: "FlutterFrameworks",
      targets: ["FlutterFrameworks"]),
  ],
  dependencies: [
    .package(path: "device_info"),
    .package(path: "Flutter"),
  ],
  targets: [
    .target(
      name: "FlutterFrameworks",
      dependencies: [
        .product(name: "device_info", package: "device_info"),
        .product(name: "Flutter", package: "Flutter"),
      ]
    )
  ]
)

Sources/FlutterFrameworks/FlutterFrameworks.swift (see note on @_exported)
@_exported import device_info
@_exported import Flutter

Also generate a Flutter framework Package.swift.  Copy the right build mode xcframework into the same directory.

let package = Package(
  name: "Flutter",
  products: [
    .library(
      name: "Flutter",
      targets: ["Flutter"]),
  ],
  targets: [
    .binaryTarget(
      name: "Flutter",
      path: "Flutter.xcframework"),
  ]
)

Plugin authors will add their own ios/Package.swift manifest that declares a dependency on the Flutter package since it needs to link on it.  There will be a contract with the plugins that its ios directory contents will be copies as a sibling of the ../Flutter package so its relative path can be referenced.  The plugin author is free to add additional remote dependencies as needed.  The only requirement is that it depend on Flutter.

let package = Package(
  name: "device_info",
  products: [
    .library(
      name: "device_info",
      targets: ["device_info"]),
  ],
  dependencies: [
    .package(path: "../Flutter"),
  ],
  targets: [
    .target(
      name: "device_info",
      path: ".",
      exclude: ["device_info.podspec"],
      sources: ["Classes"],
      publicHeadersPath: "Classes"
    ),
  ]
)

The above described file structure looks like:
FlutterFrameworks
└── Sources
│   └── FlutterFrameworks
│       └── FlutterFrameworks.swift
├── Flutter
│   └── Package.swift
│   └── Flutter.xcframework/
└──  device_info
    └── Classes
    |   └── FLTDeviceInfoPlugin.h
    |   └── FLTDeviceInfoPlugin.m
    └── Package.swift

This would also allow the tool to stop manually linking and copying the Flutter.framework around in Run Script since that would be delegated to the Swift Package Manager.

I'm hoping we can get away with creating all of the following in BUILT_PRODUCTS_DIR to enforce Flutter.xcframework build modes.... Ideally this could be created in BUILT_PRODUCTS_DIR during the xcodebackend "Run Script" phase but something tells me that may be too late.  Still need to test this.

I was right, all packages needed to be relative to the group, not BUILT_PRODUCTS_DIR.  It also corrupted when I forced the Flutter package to be an absolute reference with path="$(FLUTTER_ROOT)".

Xcode 13.3 introduces Swift Package Manager build tool plugins, which should make Flutter integration more feasible. See https://developer.apple.com/documentation/xcode-release-notes/xcode-13_3-release-notes.

@paulb777 You're right, that will be really helpful!  Thanks for the heads up!

This is good news. Integrating Swift Package Manager in place of Cocoapods will dramatically reduce build times on Apple devices.

any update ?

Hey All, do we know if the Flutter dev team is working on this, or at least has a plan to prioritize it over the next few months, please? Thanks.

It's in the works, no timeline though.

I haven't had luck with these patterns:

Using the new SPM extensible build tool plugin feature, copy the Flutter.xcframework out of the SDK artifacts to somewhere the Flutter Swift package can see it, then declare a Flutter product.

Package.swift
// swift-tools-version:5.6
import PackageDescription

let package = Package(
  name: "Flutter",
  products: [
    .library(
      name: "Flutter",
      targets: ["Flutter"])
  ],
  targets: [
    .plugin(
        name: "FlutterPlugin",
        capability: .buildTool()
   ),
     .target(
        name: "Flutter",
        plugins: ["FlutterPlugin"]
    )
  ]
)

Sources/Flutter/FlutterExport.swift
@_exported import Flutter

Plugins/FlutterPlugin/FlutterPlugin.swift
// swift-tools-version:5.6
import PackagePlugin

@main
struct FlutterPlugin : BuildToolPlugin {
  func createBuildCommands(context: PluginContext, target: Target) throws -> [Command] {
    let outputDir = context.package.directory.appending("Flutter.xcframework")
    let xcframeworkInfoPlist = outputDir.appending("Info.plist")

    // Actually use a hard-coded path, we can generate this file the same way we set the Generated.xcconfig FLUTTER_ROOT
    let inputArtifact = "/Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/Flutter.xcframework"

    return [.buildCommand(
        displayName: "Copying Flutter.xcframework",
        executable: Path("/usr/bin/rsync"),
        arguments: [ "-av", "--delete", "--filter", "- .DS_Store/", inputArtifact,
                     context.package.directory.string ],
        inputFiles: [Path(inputArtifact)],
        outputFiles: [xcframeworkInfoPlist])
    ]
  }
}

.prebuildCommand didn't seem to run every time.
Unfortunately, it seems the BuildToolPlugin script runs in a sandbox and can only copy to context.pluginWorkDirectory, which is some random spot like DerivedData/Runner-abc/SourcePackages/flutter/Flutter/FlutterPlugin
In the generated script, the script sandbox profile running the build command:
/usr/bin/sandbox-exec -p "(version 1)
(deny default)
(import \"system.sb\")
(allow file-read*)
(allow process*)
(allow file-write*
    (subpath \"/private/tmp\")
    (subpath \"/private/var/folders/bx/pyplw7v92lj58gm3_lztz5sc00mfq2/T\")
)
(deny file-write*
    (subpath \"/Users/m/Projects/test_spm/ios/Flutter/ephemeral/FlutterFrameworks/FlutterPlugins/Flutter\")
)
(allow file-write*
    (subpath \"/Users/m/Library/Developer/Xcode/DerivedData/Runner-abc/SourcePackages/flutter/Flutter/FlutterPlugin\")
)
" /usr/bin/rsync -av --delete --filter "- .DS_Store/" /Users/m/Projects/flutter/bin/cache/artifacts/engine/ios-release/Flutter.xcframework /Users/m/Projects/test_spm/ios/Flutter/ephemeral/FlutterFrameworks/FlutterPlugins/Flutter

So it's denying write to the place we want it to write: Flutter/ephemeral/FlutterFrameworks/FlutterPlugins/Flutter
Running that give the expected sb permission denied:
Showing Recent Messages
rsync: failed to set times on "/Users/m/Projects/test_spm/ios/Flutter/ephemeral/FlutterFrameworks/FlutterPlugins/Flutter/Flutter.xcframework": Operation not permitted (1)

There are more clever things to do here like making the executable flutter and making a custom assemble command just to copy the framework, which would also solve the precache issue where the ios frameworks haven't yet been downloaded (I was just trying to get something to work).  But that will hit the same write issues.  Additionally, no build configurations are accessible in this scope, so we can't specify to link on the debug or release version of the .framework.  And even if BuildConfiguration was passed in, I think it would fall apart with flavors since SPM seems to rely to the Debug and Release strings.

Much better than copying the framework around (which is large) would be to just set the linker framework search path flags on the plugins to point to the artifacts directories.  This is what we do now in CocoaPods:
https://github.com/flutter/flutter/blob/0c0087f805826cfd0b3dbe22924194c73219bd0d/packages/flutter_tools/bin/podhelper.rb#L64-L67
However, SPM only allows setting this with unsafeFlags which is problematic.  And I can't point it to the artifacts xcframework, I need to point it to the .framework, but there's no way to tell the package to use different flags depending on if it's a simulator or not, and if you mismatch you'll get linker errors. /path/to/Flutter.xcframework/ios-arm64/Flutter.framework vs /path/to/Flutter.xcframework/ios-arm64_x86_64-simulator.  There's also no way to specify to link on the debug or release version of the framework.

Do something clever with module maps and reexport the framework.  The Swift package module map could be hardcoded to point to the absolute path of the Flutter.framework umbrella header (maybe there's a way to point it directly to the module map?) and generate this the same way we set the Generated.xcconfig FLUTTER_ROOT. Then export the Flutter module, something like:

module FlutterWrapper [system] {
    header "/Users/m/Projects/flutter/bin/cache/artifacts/engine/ios/Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Headers/Flutter.h"
    link "Flutter"
    export *
}

Note I didn't test that so it may not quite be correct.  However it has the same issues as 2 in that it can't point to the xcframework, so somehow needs to differentiate between simulator and non-simulator.

Symlink the artifacts xcframework into the project Swift package during ensureReadyForPlatformSpecificTooling and use a plain binaryTarget.  Would need to figure out how to solve the precache issue to make sure the framework is downloaded.  We're already symlinking the plugins from the pub cache so this wouldn't be so bad.  Same problem with not being able to specify debug vs release, but the simulator vs real device issue would be solved.  I need to play with this one more.

Additional notes:

I first tested this on Xcode 14 beta 1 and the build tools scripts just never ran.  Beta problems.  I wound up testing all this on 13.4 which had swift-tools-version:5.6 available.
Even on Xcode 13.4 I needed to close and reopen the Xcode project every. time. I touched the package manifests. Woe to me for constantly forgetting to do so, and running stale configurations.  The whole SPM feature seems like a toy and not ready for production, which makes me nervous.
In the plugin scripts I was able to import Foundation and NSLog to see debugger print statements in Console, which was helpful.

Hi there, I've noticed an increasingly amount of iOS/Swift packages being made only available on Swift Package Manager and/or even dropping support to Cocoapods. Bumping this since having Flutter Plugins rely strongly on Cocoapods is becoming more problematic as the time goes :/

Noted, you can see from my extensively detailed updates that I am trying to get it working with Flutter.  If you have additional ideas to get it working I'm all ears. 🙂

This is becoming an actual problem for us. We need to integrate WalletConnect (https://github.com/WalletConnect/) like yesterday and it is SPM only.

While we certainly do want plugin-level support for SPM, in the short term if you have a critical need for an SPM-only SDK there shouldn't be anything preventing you from integrating it directly into your application via method channels.

While we certainly do want plugin-level support for SPM, in the short term if you have a critical need for an SPM-only SDK there shouldn't be anything preventing you from integrating it directly into your application via method channels.

Appreciate it and the route we will have to go. More code, more bugs though. More unnecessary work that will be tossed a few months down the road.

More code, more bugs though. More unnecessary work that will be tossed a few months down the road.

The code to wrap a package for use via method channels is identical in a plugin or directly in an app, so there isn't actually any more code, nor should there be any (non-trivial) work that would be thrown away later.

While we certainly do want plugin-level support for SPM, in the short term if you have a critical need for an SPM-only SDK there shouldn't be anything preventing you from integrating it directly into your application via method channels.

Hi and thanks for the hard work. Please let me know if your response adresses my use case:

There is a binary framework distributed as a Swift package
We develop a Flutter plugin that uses this framework
We use this plugin in Flutter apps

Today I am in the process of replacing an old fat version of this framework with the latest xcframework (now distributed with SPM).
Would be lovely if today Flutter allows this.

2. We develop a Flutter plugin that uses this framework

That's the part that doesn't currently work, and which is tracked by this issue. The "integrating it directly into your application" part of my comment was intended to distinguish from using an SPM package in a plugin.

@jmagman Any updates on this, it's become a critical blocker for most of us.

My team is also urgently needing to use flutter plugin modules published through SPM.  Any way to get this prioritized?  Working great for Android but does not solve our cross platform problem until this issue is resolved.

Anyone considering posting here: please read https://github.com/flutter/flutter/wiki/Issue-hygiene#when-will-my-bug-be-fixed and https://github.com/flutter/flutter/wiki/Issue-hygiene#do-not-add-me-too-or-same-or-is-there-an-update-comments-to-bugs before posting.

Basically I am also trying to achieve this thing.

Framework being distributed via swift package
Integrated that swift package into a plugin. (No issues up till now while build or running the example app of plugin)
Hooked up that plugin into flutter app. (Error : Swift Package or SDK not Found).

So I added package dependency into my flutter app (the way I added swift package inside plugin same way inside flutter app as well). So after doing so the error on the plugin code from app side went away. This way we have to constantly update plugin and swift package both from flutter app side, bit tedious but didn't find any better way, suggest me if somebody has any.

Basically I am also trying to achieve this thing.

Framework being distributed via swift package
Integrated that swift package into a plugin. (No issues up till now while build or running the example app of plugin)

@ShubhamAryanBansal  Could you share details on #2?  I am developing a plugin with a native iOS component, and need it to import a framework as a swift package, in the swift source file for the plugin.  But I'm not able to.  In the Xcode project for the example app, I can add the framework as a package dependency in the project settings, which enables me to import the framework in swift sources belonging to the example app.  But it doesn't enable me to import it in the plugin source file, where I need it; when I add the import statement there, the example app doesn't build.  Am I missing something?

Basically I am also trying to achieve this thing.

Framework being distributed via swift package
Integrated that swift package into a plugin. (No issues up till now while build or running the example app of plugin)

@ShubhamAryanBansal Could you share details on #2? I am developing a plugin with a native iOS component, and need it to import a framework as a swift package, in the swift source file for the plugin. But I'm not able to. In the Xcode project for the example app, I can add the framework as a package dependency in the project settings, which enables me to import the framework in swift sources belonging to the example app. But it doesn't enable me to import it in the plugin source file, where I need it; when I add the import statement there, the example app doesn't build. Am I missing something?

Firstly I took the help from this article https://www.kodeco.com/17753301-creating-a-framework-for-ios
This is just to make sure you are doing initial steps correctly.
So you can add your swift package as a package dependency by opening :
Pods section -> Package Dependencies(As in my case that swift package was a private repo so I had to add repo link).
After doing so in Pods section itself you will find Targets below, then go ahead choose your plugin_name from that, then it will open up the settings for the same and inside of that you will find "Framework and libraries" -> Click on add and choose your swift package. Then you are good to go. You will be able to use your swift packages classes inside the plugin.
And when you integrate this plugin in your flutter app, you have to do the same process again, because for now flutter can't download swift package dependencies of a plugin.

It keeps getting pushed out, but the summary of last attempt to get this working in flutter tool with the SPM build tool plugin feature was at https://github.com/flutter/flutter/issues/33850#issuecomment-1155938940.  And before that was https://github.com/flutter/flutter/issues/33850#issuecomment-826019439.
The useful technical conversations keep being buried by "me too" and "this is important" comments, so I'll push this to the bottom as well 🙂 :

Anyone considering posting here: please read https://github.com/flutter/flutter/wiki/Issue-hygiene#when-will-my-bug-be-fixed and https://github.com/flutter/flutter/wiki/Issue-hygiene#do-not-add-me-too-or-same-or-is-there-an-update-comments-to-bugs before posting.

Update: Swift Package Manager support is actively being worked on, check out https://github.com/flutter/flutter/issues/126005 for a list of work that's been done, and what still outstanding.
Work to migrate our own plugins in flutter/packages is at https://github.com/flutter/flutter/issues/146922
Some instructions for migrating packages, if you want to start playing with it (note these instructions or tooling around it may change): https://github.com/flutter/flutter/pull/146256#issuecomment-2038565077


Added metrics to rest.li limiter.

Changes:

Created a MetricContextFactory for broker, along with a MetricContextKey and a unit test.

Rest.li Limiter supports emitting metrics. The factory automatically acquires a metric context from the broker.

In Gobblin runtime, WorkUnitState gets a broker builder instead of a pre-built broker so it can inject its own custom configurations (not done currently). Eventually, I would want to replace all MetricContexts in gobblin runtime for ones acquired from the broker.

Added a scope id to the ScopeInstance interface.

Minor changes to generics in broker (fixes compiler/ide warnings)

@yukuai518 can you review? Thanks!


go/types: constant LHS in non-constant shift used as index expression must fit into int

Per the spec, the following code
var a []int
var s uint
var _ = a[0xffffffffffffffff << s]

is not permitted:

the type of an untyped LHS in a non-constant shift is the type it would have without the shift
the type of an untyped constant index must be non-negative and representable by a value of type int

Here, 0xffffffffffffffff does not fit into an int, but go/types accepts it.
cmd/compile reports: constant<PHONE_NUMBER>3709551615 overflows int

Not urgent but the fix may be simple in which case we may want to do it for Go1.10.


Added API docs with FORD

Thank you @rajkumardongre  for this. Can you close this PR and open a new one with just ford.md and a note in README.md on how to build the API docs? We shouldn't commit the docs build to the main branch, we will do that to gh-pages branch from CI in a separate PR. For now, just a ford.md and instruction on how to build it will suffice. Also, at the end of ford.md you can just have {!README.md!} for the README.md to be included.


Flag for adding custom headers: --header

as per dicsussion in #150, we might benefit from ability of operator to add custom headers to output websocketd generates. I suggest we add following few that could be used multiple times:

--header   (add header on all answers)
--header-ws  (add header to ws-upgraded answers)
--header-http  (add header to not-upgraded ssl and non-ssl answers, this includes errors and devconsole)

Thoughts?

+1.

Should be possible to add headers now.


Win64 build fails on Visual Studio 2017

The following line generates an error because #include <algorithm> is missing.
max_offset = std::max(max_offset, (*code)(i)-han_offset);
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2039	'max': is not a member of 'std'	libtesseract	\tesseract\ccutil\unicharcompress.cpp	208

Fixed https://github.com/tesseract-ocr/tesseract/pull/1054


Property value update callback event is not execute for cascading property

Dear Team,
Property value update event is not fired for cascading property files.
For example , I have 2 property files.

firstfile.proprties
firstkey1=firstvalue1
@next=firstfile-${myenv}.proprties

firstfile-dev.proprties
secondkey1=secondvalue2
@next=third.properties

Sample Source code to print the value :
Class Main{
static {
System.setProperty("archaius.configurationSource.defaultFileName", "firstfile.properties");
try {
ConfigurationManager.loadCascadedPropertiesFromResources("firstfile");
} catch (IOException e) {
e.printStackTrace();
}
}
final  DynamicStringProperty firstkey1DynamicStringProperty = DynamicPropertyFactory.getInstance().getStringProperty("firstkey1","defaultValue", new Runnable() {
public void run() {
System.out.println("********* firstkey1 PROP UPDATE EVENT************************");
}
});
final  DynamicStringProperty secondkey1DynamicStringProperty = DynamicPropertyFactory.getInstance().getStringProperty("secondkey1","defaultValue", new Runnable() {
public void run() {
System.out.println("********* secondkey1 PROP UPDATE VENT****************************");
}
});
} .....
// Note : This program is running in thread and key value is printed correct from both prop file.
When i change any value in firstfile.property file, callback event is executed.
But When i change any value in firstfile-dev.property file, callback event is not executed. i.e. After changing the value of secondkey1 , its callback method is not called hence updated value is not captured.
Please suggest.

You have to  add the line
spring.profiles.active=dev
in your firstfile.proprties. Then callback event will be executed. Otherwise, just read firstfile.proprties file.


Support for millisec

We have a requirement where user should be able to select a time range including millisec. It is for a log parsing application where a lot of logs get printed over a few millisec across servers. The current time formats do not seem to support this. Can support for this be added?
Thanks!!

+1


[Question] want to erase all white color(transparent)

Is there any api I could use to achieve this purpose:
Make the following jpg picture transparent. ( erase all white color, save to png )
Thank you.

I try following way, seems not right, but worked.
var sharp = require("sharp");

const width = 430;
const height = 430;
const buffer = Buffer.alloc(width * height);
sharp("octocat.jpg")
  .raw()
  .toBuffer()
  .then(data => {
    const channels = 3;
    for (var x = 0; x < 430; x++) {
      for (var y = 0; y < 430; y++) {
        const offset = channels * (width * y + x);
        const red = data[offset];
        const green = data[offset + 1];
        const blue = data[offset + 2];
        if (red < 250 || green < 250 || blue < 250) {
          buffer[width * y + x] = 255;
        }
      }
    }

    sharp("octocat.jpg")
      .joinChannel(buffer, {
        raw: {
          width: width,
          height: height,
          channels: 1
        }
      })
      .toFile("2.png")
      .catch(err => console.log(err));
  })
  .catch(err => console.log(err));

Hello, given custom per-pixel logic is required then this is a good approach.


CDK Deploy Error - invalid signature

Our team was trying to setup Airflow through the following steps via CDK:
https://aws.amazon.com/blogs/containers/running-airflow-on-aws-fargate/
However, during the cdk deploy step, and after answering "yes" to the prompt, we are encountering the following error:
#5 [2/7] RUN apt-get update && apt-get install -y python3-pip     libcurl4-gnutls-dev     librtmp-dev     python3-dev     libpq-dev
#5 sha256:787088182aea3ef729295dade2fab650429db33d33b8265ed2abda11ad49abff
#5 0.327 + apt-get update
#5 0.568 Get:1 http://security.debian.org/debian-security buster/updates InRelease [34.8 kB]
#5 0.580 Get:2 http://deb.debian.org/debian buster InRelease [122 kB]
#5 0.633 Get:3 http://deb.debian.org/debian buster-updates InRelease [56.6 kB]
#5 0.715 Get:4 http://repo.mysql.com/apt/debian stretch InRelease [21.6 kB]
#5 0.769 Get:5 http://security.debian.org/debian-security buster/updates/main amd64 Packages [508 kB]
#5 0.916 Get:6 http://deb.debian.org/debian buster/main amd64 Packages [7909 kB]
#5 1.216 Get:7 http://deb.debian.org/debian buster-updates/main amd64 Packages [8788 B]
#5 1.227 Err:4 http://repo.mysql.com/apt/debian stretch InRelease
#5 1.227   The following signatures were invalid: EXPKEYSIG 8C718D3B5072E1F5 MySQL Release Engineering<EMAIL_ADDRESS>#5 2.403 Reading package lists...
#5 3.271 W: GPG error: http://repo.mysql.com/apt/debian stretch InRelease: The following signatures were invalid: EXPKEYSIG 8C718D3B5072E1F5 MySQL Release Engineering<EMAIL_ADDRESS>#5 3.271 E: The repository 'http://repo.mysql.com/apt/debian stretch InRelease' is not signed.
#5 ERROR: executor failed running [/bin/bash -o pipefail -e -u -x -c apt-get update && apt-get install -y python3-pip     libcurl4-gnutls-dev     librtmp-dev     python3-dev     libpq-dev]: exit code: 100
------
executor failed running [/bin/bash -o pipefail -e -u -x -c apt-get update && apt-get install -y python3-pip     libcurl4-gnutls-dev     librtmp-dev     python3-dev     libpq-dev]: exit code: 100

 ❌  FarFlow failed: Error: Failed to publish one or more assets. See the error messages above for more information.
    at publishAssets (/Users/<REDACTED>/.nvm/versions/node/v16.14.2/lib/node_modules/aws-cdk/lib/index.js:391:74837)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async deployStack (/Users/<REDACTED>/.nvm/versions/node/v16.14.2/lib/node_modules/aws-cdk/lib/index.js:393:390)
    at async Object.deployStack2 [as deployStack] (/Users/<REDACTED>/.nvm/versions/node/v16.14.2/lib/node_modules/aws-cdk/lib/index.js:400:149977)
    at async /Users/<REDACTED>/.nvm/versions/node/v16.14.2/lib/node_modules/aws-cdk/lib/index.js:400:135508

Do you have any insight as to how to solve this problem? Thanks!

Update: Note that updating the Dockerfile to:
FROM apache/airflow:2.6.1

Solved the issue. Our next issue is that we have exceeded our VPC quota limit and are going to attempt to modify the CDK code to operate within our existing VPC (but am expecting downstream issues)


Freeze player votes

This would be a GM command which would:

Freeze a given victim votes.
Freeze the votes of all the players who have one or more casted votes.

The syntax for GM would be:
'''
Congelar [victim]
'''

Duplicated of #21

Duplicated of #21


ICE around validation of char

@niluxv found an ICE around validation of uninitialized char. Here's a self-contained example; this embeds linked-hash-map. It would be nice to minimize this further.
The actual ICE occurs here and it is unclear why, because uninitialized char usually work fine.

I used this example (playground link). It only includes the code from linked-hash-map that is required for the example to compile.

Actually, even this ICEs:
fn main() {
    let _b: bool = unsafe { std::mem::MaybeUninit::uninit().assume_init() };
}

Something is very odd...

Actually a call to droping a LinkedHashMap is enough: playground link.

I'll need to do a full rustc bootstrap to get more debugging information, right now nothing makes any sense.^^ This will take a while.

https://github.com/rust-lang/rust/pull/74059 should fix this.


RolledLogDeleter: do not sort on each candidate consideration.

A performance issue was noticed in Docs testing related to the
RolledLogDeleter candidates consideration. This fixes the candidate
consideration logic to not sort on consideration of every candidate but
rather sort after all the candidates have been gathered (if deletion
will indeed take place).
This addresses issue #7242.

Cherry-picked to v9.0.x branch.

This closes issue #7242.


Added details about ReFS versions and their features

Added the following features for the ReFS because they are supported:

File system compression
File system encryption (added in 3.14 in the Windows 11 24H2)
Extended attributes

https://github.com/MicrosoftDocs/windowsserverdocs/issues/6982

@robinharwood, @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Optimize UrlEncode in Utils

Description
Optimizes UrlEncode for better memory efficiency
Motivation and Context

BenchmarkDotNet v0.13.12, macOS Sonoma 14.4.1 (23E224) [Darwin 23.4.0]
Apple M3 Max, 1 CPU, 14 logical and 14 physical cores
.NET SDK 8.0.202
  [Host]     : .NET 8.0.3 (8.0.324.11423), Arm64 RyuJIT AdvSIMD
  DefaultJob : .NET 8.0.3 (8.0.324.11423), Arm64 RyuJIT AdvSIMD

https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/UrlEncode.cs
Testing
Added tests to verify the code still does the same as before.
Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

@normj @dscpinheiro I know this is still draft but would you mind having a look at it at some point? I have added a bunch of inline comments that might influence this PR.

Ping @normj

I raised https://github.com/aws/aws-sdk-net/issues/3326 because the constants are a bit messy and need an overhaul. I did my best to get things into compilable state for now.

Ok I'll do a rebase

@normj rebased

Rebased to solve the conflict

Would be nice if this could be merged since I have a bunch of other PRs that introduce more tests to the test file that probably require a rebase then ;)

Would be nice if this could be merged since I have a bunch of other PRs that introduce more tests to the test file that probably require a rebase then ;)

Taking a look

I don't visually see issues in the PR. However, this didn't build in our build system because a change is required to support the /unsafe switch. I will make the change so we can ensure this PR will build and test correctly before I approve the PR.

@danielmarbach I approved and merged #3363 and #3365, but we saw integration test failures when running this PR on our build system (they were all related to this CloudFormation section: https://github.com/aws/aws-sdk-net/blob/3.7.844.0/sdk/test/NetStandard/IntegrationTests/IntegrationTests/CloudFormation.cs#L20).
Essentially that value is passed to UrlEncode (via GetParametersAsString), but AWSSDKUtils.UrlEncode(TEMPLATE_TEXT, false) in your branch is not returning the same value as v4-development.

@dscpinheiro Ok I'll check

@dscpinheiro I'm approaching my leave period so it might take a bit longer for me to respond. Apologies in advance

@dscpinheiro I fixed the problem. It was between the chair and the keyboard 👯

Give it another run through the benchmark

Still very good allocation reduction and the throughput hit is still in very acceptable range

All the new changes are being run through the backend build system now.

One test failure for netcoreapp3.1 target running tests.
error : Test failure in XUnitTestRunner: UnitTests.NetStandard.Core.AWSSDKUtilsTests.UrlEncodeWithoutPath(input: "{\r\n\t\"AWSTemplateFormatVersion\" : \"2010-09-09"..., expected: "%7B%0A%09%22AWSTemplateFormatVersion%22%20%3A%20%2"...)

I ran against net8 and as far as I recall net4.x. I'm not installing a runtime that is out of support for almost two years and hasn't received security updates since them. Sorry.
So if you can provide me the entire test output with some information that makes it possible for me to guess what's going on I'm happy to give it another look.
Otherwise this PR has also edit rights. Feel free to push updates.

I ran against net8 and as far as I recall net4.x. I'm not installing a runtime that is out of support for almost two years and hasn't received security updates since them. Sorry.
So if you can provide me the entire test output with some information that makes it possible for me to guess what's going on I'm happy to give it another look.
Otherwise this PR has also edit rights. Feel free to push updates.

Thank you for working with us on this PR while we shake out the test issues. I ran the test in Visual Studio locally and it also fails in .NET 8.
The project containing the failed test is: .\aws-sdk-net\sdk\test\NetStandard\UnitTests\AWSSDK.UnitTests.Custom.NetStandard.csproj
The file containing the failed test within that project is: .\aws-sdk-net\sdk\test\NetStandard\UnitTests\Core\AWSSDKUtilsTests.cs
The test is: public void UrlEncodeWithoutPath(string input, string expected) which has three [InlineData] test cases. The case that is failing specifically is the third one which uses the TemplateText.
Here is a link to the test case: https://github.com/danielmarbach/aws-sdk-net/blob/f5fe55e95b98d07bb7cd2c2a8e8f4451f0b1b819/sdk/test/NetStandard/UnitTests/Core/AWSSDKUtilsTests.cs#L70
TemplateText can be found here: https://github.com/danielmarbach/aws-sdk-net/blob/f5fe55e95b98d07bb7cd2c2a8e8f4451f0b1b819/sdk/test/NetStandard/UnitTests/Core/AWSSDKUtilsTests.cs#L78
All other tests in this project pass.

From the look of it \r (0x0D) characters are being injected and encoded when the test case hits a \n (0x0A):

Honestly looking at this again on my phone I'd argue the only thing that would have been needed to cover the bug in https://github.com/aws/aws-sdk-net/pull/3307/commits/618ef3e80e8748c4f40162fe61bc95ba446ed521 would have been a long enough string. Fighting line endings and going back and forth on this PR for trying to fit the template text into here seems a bit pointless and unnecessarily holding this up. How about I remove this test case for now?

@boblodgett based on the above comment I removed the template test for now. Having some tests in place for the method where there previously have been none is already a good start and the template was only a temporary thing anyway which helped me discover the buffer length problem. Ideally, there would be another test with a longer input but I cannot do this right now since I'm not around my laptop or workstation for a while

And thanks for your support here and sorry for me being less helpful this time


[SPARK-48791][CORE][FOLLOW-UP][3.4] Fix regression caused by immutable conversion on TaskMetrics#externalAccums

This PR backports https://github.com/apache/spark/pull/47578 to branch-3.4.

What changes were proposed in this pull request?
This is a followup fix for https://github.com/apache/spark/pull/47197. We found that the perf regression still exists after that fix and located the culprit is the immutable conversion on TaskMetrics#externalAccums. This PR fixes it by avoiding the immutable conversion, and then enforce the read lock protection during the accessing on TaskMetrics#externalAccums to avoid the race issue (https://github.com/apache/spark/pull/40663).
Why are the changes needed?

Fix perf regression.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Covered by existing tests.
Was this patch authored or co-authored using generative AI tooling?

No.

Thank you, @Ngone51 and @mridulm .
Merged to branch-3.4.


After a while I get "Killed" and the server stops

Hi, I am sure this is not a commafeed issue but something I am doing wrong, but I am not sure what it is.
I managed to install everything fine on a DO droplet, but when I start the server and use it for about 30 minutes I get Killed in the console and the server stops.
Does anyone know why that might be happening?
Any tips on where to look will be appreciated,
Thanks

found the solution on /var/log/kern.log
Apr 15 20:56:15 wordpress-nyc kernel: [ 3454.697831] Out of memory: Kill process 1312 (java) score 497 or sacrifice child
Apr 15 20:56:15 wordpress-nyc kernel: [ 3454.698319] Killed process 1312 (java) total-vm:2133696kB, anon-rss:256140kB, file-rss:0kB


how to debug

Have you tested the debug can work？

i tested was not working!

The debug for web assembly as of now should work if you are debugging from the IDE. However, doing so means you will not get the extensions API and you will have to mock the response for the APIs used by the project. This is because the debugging feature in Blazor uses NodeJS as a debugging proxy and when running the project as a browser extension, this proxy is not running. AFAIK, we can't debug a published Blazor app until the team releases a browser extension that would enable debugging from just the DevTools, something like the React Developer Tools for debugging React apps.

That means that the chrome extentions developed by blazor cannot debug c# code, right?

That is right, it is only possible to debug it from the IDE for now. When it is loaded in the browser as an extension, it will be possible to debug once there is official support for it, either from Blazor or Chrome DevTools, or both.


Liveness / readiness probe for charts/stable/openvpn

Is this a request for help?:
Request
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature request

Version of Helm and Kubernetes:
Helm 2.7, Kubernetes 1.8.3
Which chart:
charts/stable/openvpn
Describe in detail the feature/behavior/change you'd like to see
I'd love to see a liveness / readiness probe added to the chart. With netcat installed in the docker image, we could exec this inside the container to check the the status of openvpn server on the pod.
echo -e "8\x01\x00\x00\x00\x00\x00\x00\x00" | nc -w10 -u <IP_ADDRESS> 443

cc: @jfelten


chore: WIP migration to derived state

This work extends off of https://github.com/TanStack/store/pull/40 to validate the behavior in that PR. Do not merge this PR before merging and publishing that one.

TODOs

[x] Move new Derived side effects to dedicated mount method
[ ] Add back transformArray
[x] Add back broken tests
[ ] Add tests to validate fix for #902

Make sure that errors doesn't change unless errorMap has changed

[ ] Make derived state more modular to avoid problems with over-generating related code

OK, I figured out what the problem was:
batch sends out prevDepVals in one single update. Meaning that when we end up receiving the new value, it will inevitably be === consistent. By removing all instances in form for batch by doing:
function batch(fn: () => void) {
  return fn()
}

It works as-intended and all tests pass.
This isn't ideal tho, so I'll try to patch it in store instead if possible


Windows: Encryption is limited by size of state

This issue is related to the implementation of #1

Do you easily reach the character limit, or do you have to have a lot of panes with a lot of out put in your experience?

PowerShell follows a Windows limit of 32,764 characters, so it takes a few tabs with a lot of text content in them to hit this limit. Since it's a Windows limit, I think the workaround would involve writing the saved state to a temporary file or compressing the command, but this adds quite a bit of code and complexity to the plugin that I'm hesitant to add.
Perhaps a better approach is to add some sample code to encryption.md for an ecnrypt() func that writes a temporary file, decrypts it with age and then deletes it, while flagging that this is less secure, but is an option.
Originally posted by @joncrangle in https://github.com/MLFlexer/resurrect.wezterm/issues/31#issuecomment-2271286853

I see several "solutions" each with their own downsides:

A temp file could be used. This could lave the secrets in a temporary unencrypted state, thus being insecure.
Do not save the lines within the panes, this should drastically cut down on the number of chars, but will ofc be a worse user experience
Encrypt in chunks of 32,764 characters at a time. This will make the encryption and decryption logic a lot worse, but it will make it possible to keep the same security and functionality as the unix systems.
Do nothing by default and make it break at 32,764+ chars and then refeer to the encryption.md docs where we can suggest options for encrypting larger states

I've come across this issue on linux as well now, so I don't think it's Windows-specific - it's just that Windows supports the shortest character limits for commands compared to Unix-based systems.
in pane_tree.lua, the line
root.text = root.pane:get_lines_as_escapes(root.pane:get_dimensions().scrollback_rows)

will return the entire scrollback history (wezterm docs). I've got my scrollback set to 5,000 lines. Also, I use a colorful Starship prompt, and all those ansi color sequences add to the command length so I think that's why I've hit the limits a few times.
I wonder if a simpler way to address this issue is to allow the user to provide an optional [nlines] opt to specify the volume of lines they want to save. That way, the pane_tree.lua function can save the entire scrollback by default (as it is now) or the provided nlines if the user provides the nlines arg to override it.

A temp file could be used. This could lave the secrets in a temporary unencrypted state, thus being insecure.
Do not save the lines within the panes, this should drastically cut down on the number of chars, but will ofc be a worse user experience
Encrypt in chunks of 32,764 characters at a time. This will make the encryption and decryption logic a lot worse, but it will make it possible to keep the same security and functionality as the unix systems.

A benefit of the above approach to let the user optionally specify nlines, is that these options you suggested would still be available if someone wants to use their own encryption and decryption logic, but it wouldn't need to be maintained as part of the plugin.

I really like the option of specifying the nlines even though it does not directly fix the underlying problem.
I might have a way to write to stdin via luas popen, but I will have to play around with it, as I havn't played a lot with lua i/o


Error while registering new clusters to Rancher (ClusterRoleBinding.rbac.authorization.k8s.io "globaladmin-u-tmzgkab7gh" is invalid: subjects[0].name: Required value )

We are creating RKE cluster and importing it using terraform to rancher UI, The clusters are added but we see the cluster rolebinding error for the global admin during the cluster registration process when 100+ clusters are added simultaneously.
We have enabled active directory authentication and added groups as global admins.
Rancher version : Tested in both v2.5.7 and v2.5.8-rc4
RKE version : 1.1.5
k8s version : 1.18.16
Downstream cluster k8s version : 1.18.10

we are also facing the same issue

+1, Issue persists for sometime and goes off automatically but when bulk import/add is done.. it persists for longer and is quite annoying.
Have tried to describe the globaladmin rolebinding and it looks correct in the yaml definition. Not sure why the subject.name is called as invalid.

I'm also facing the issue after v2.5.7 :(

+1, We are also facing same issue in our prod environment.

We have now added ability to handle 50 workers at a time as well as stopped our queue holding onto objects for hours at an end. These fixes are addressed in v2.5.9-rc2.
@BrundaBS @LathaMahesh @vijaytrainer @pramodpro @ritheshgm
Can you try upgrading to v2.5.9-rc2 and test it out?

rancher/rancher:v2.5.9-rc3

I was able to reproduce this in v2.5.7 with the following steps:

Deploy Rancher
Enable external auth (with groups)
Create a global role for a group set to Administrator
Login as a user from that group
Create and import 150 k3s clusters (used scaling framework)

Several of the clusters had the same error for ~1 hour until resolving: ClusterRoleBinding.rbac.authorization.k8s.io "globaladmin-u-...." is invalid: subjects[0].name: Required value

Deployed Rancher v2.5.9-rc3

Performed the same steps

All clusters imported and registered correctly without the previously seen CRB error


Parameters as wires

This PR allows to store attributes of a Verilog module parameter in a wire object. For each parameter a mocking wire is created with the same name. Those mocking wires are connected to constants which correspond to default values of parameters. Parameters with their default values are outputted via Ilang, Verilog and JSON backends.
The PR also adds a small test suite which compares various backend outputs with a golden reference.

See #1109, which adds <50 lines instead of >1100.

# git diff upstream/master --stat
...
 34 files changed, 1154 insertions(+), 211 deletions(-)

# git diff upstream/master --stat tests
...
 14 files changed, 791 insertions(+), 43 deletions(-)

Calculations;
In [1]: (1154-791)
Out[1]: 363

In [2]: (211-43)
Out[2]: 168

In [3]: 363-168
Out[3]: 195

Excluding tests, this PR adds 195 lines of code.

Excluding tests, this PR adds 195 lines of code.

Excluding the infrastructure for making this an optional feature, which your patch is lacking, and excluding handling of the case of attributes on Verilog-2001-style parameters, which your patch is lacking as well, and excluding the added documentation for the new parameters, which is also missing in your patch, my patch adds about 20 lines.

@cliffordwolf I appreciate that you were able to implement almost the same functionality within ~20 lines of code. But your patch targets only the Verilog frontend. What about backends?
With your patch those wires that correspond to parameters will appear as wires and there is no way to distinguish them from actual wires of a module. The change I proposed also affects backends such as Verilog, Ilang an JSON so module parameters appear in their output as parameters. That's why the code is longer.
If you want the feature of having those wires to be optional it can be easily added as well as support for attributes on Verilog 2001 style parameters.

With your patch those wires that correspond to parameters will appear as wires and there is no way to distinguish them from actual wires of a module.

No. That's why we have the attribute. That's the whole point for it.

The change I proposed also affects backends such as Verilog, Ilang an JSON so module parameters appear in their output as parameters.

We proposed the attribute solution specifically because we did not want to have intrusive changes all over the place for an obscure feature that besides you nobody is using. And we've been very clear about that context.
I you don't like it I can also remove the feature altogether again.


fix crash in depend-info --dot

Fixes https://github.com/microsoft/vcpkg-tool/pull/909#issuecomment-1475058792

Obviously not covered by tests (like most commands).
https://dev.azure.com/vcpkg/public/_build/results?buildId=86860&view=codecoverage-tab

Thanks and sorry!

Obviously not covered by tests (like most commands). https://dev.azure.com/vcpkg/public/_build/results?buildId=86860&view=codecoverage-tab

Yeah, being tracked in https://github.com/microsoft/vcpkg-tool/pull/935


pythonPackages.pyscf: init at 1.7.1

Motivation for this change
Add dependency for upcoming qiskit-terra package #78772 @jonringer
Depends on #78871
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I'm not sure if this should be included in the main Nix repo. Right now the only reason for this package's existence is a plugin to pythonPackages.qiskit-aqua, but I've fixed that package so this isn't a strict requirement. Maybe Nix User Repository would be a better fit? I don't have strong feelings.

@GrahamcOfBorg eval

@jonringer thoughts on above question? https://github.com/NixOS/nixpkgs/pull/78872#issuecomment-606676366

I'm not sure if this should be included in the main Nix repo. Right now the only reason for this package's existence is a plugin to pythonPackages.qiskit-aqua, but I've fixed that package so this isn't a strict requirement. Maybe Nix User Repository would be a better fit? I don't have strong feelings.

I think moving to the NUR is great for now. There is a lot going on with these package additions, and I'm not sure if either of us want to get it to that level of a "polished" shine.

Agreed, thanks. It's always felt like an ugly, difficult package to me, so I don't really mind removing it. Related: Would it be worth removing libcint (#78771), as this is the only thing that required it?

Agreed, thanks. It's always felt like an ugly, difficult package to me, so I don't really mind removing it. Related: Would it be worth removing libcint (#78771), as this is the only thing that required it?

If burden of maintainership is low (I'm not super familiar with the oCaml nix ecosystem), then I would say leave it.
Python packages are a pretty large maintainer burden due to how fluid most breaking changes are.

Ack @jonringer. Wrong PR, I meant libcint (C library) #78871, whoops.

Statement still applies, doesn't look like an extream burden. I would just leave

Future reference: moved to https://github.com/drewrisinger/nur-packages.
https://github.com/drewrisinger/nur-packages/commit/498953542dd1a5e6032fbd3d6713e846711c2c98


variable as environment name not working

when i try doing this: environment: '$(envName).$(resourceName)' (variables are in a stage level variable group)
i get this error: Job Deploy Resource $(resourceName) does not exist in environment $(envName)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7730ae4d-4101-9c83-1823-4ff43ff161ce
Version Independent ID: 20a7e263-4819-783e-c984-c4f3b459e22f
Content: Environment - Kubernetes resource - Azure Pipelines
Content Source: docs/pipelines/process/environments-kubernetes.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@obeyda -- Obeyda, thank you for your feedback.  You may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.

@WilliamAntonRohm, i don't really understand your answer, i used the same syntax as the docs and i got an error in the pipeline, isn't that a doc issue?

@obeyda -- Obeyda, you make a valid point.
@juliakm -- Julia, please look into this issue.

Any feedback on the environment name and resource as a variable?
Is this supported or we're missing something?

Works in the format environment: ${{ variables['EnvironmentVariable'] }}.${{ variables['ResourceVariable'] }}

@juliakm -- please review private PR 1381.


Issue while  new listing creation

Q
A

Bug report?
[ X]

Feature request?
[ ]

Support request?
[ ]

Problem :
Can't create new listing.
FrontEnd : block on loading icon with error 500 on console.log
Backend : no error on logs
Reproduce :

Install new cocorico instance
create new account from https://my-domain.com/en/register
create new listing from https://test.sigogneau.fr/en/listing/new
clic on "Publish your listing" button

Error :

Backend : no error on logs
Frontend : the only error is on Webservice

POST https://my-domain.com/en/language/translate : response code 500

Question with this bug report :
When POST listing entity is would be call?
Related issue :
#257

Hi @gantispam,
Did you fill this parameter : cocorico.translator.secret.key.
You will find its value by creating an account on  https://portal.azure.com and subscribing to
Text translator API.