Could not set unknown property 'nugetExePath' for extension 'nuget' of type com.ullink.NuGetExtension.

Hi,
using the plugin in version 2.23 with Gradle 7.4.2, I want to retrieve NuGet.exe through our local Nexus server by providing
nuget {
  nugetExePath = 'https://our.nexus.server/repository/dist.nuget.org/win-x86-commandline/v6.4.0/NuGet.exe'
}

but I get above error. Any idea what could be wrong?

Guess this comes from class NuGetExtension only defining the version property:
package com.ullink

class NuGetExtension {
    String version = '5.5.0'
}


fixed numpad for non-arabic digits

onTypeNumber(int number) method was not working when arabicDigits value was set to false, added new else statement.

published on 0.0.3


feat: add vue3-view360 and svelte-view360

Details
This adds vue3-view360 and svelte-view360

@daybrush
Methods are defined with
withPanoViewerMethods(this, "_vanillaPanoViewer");


Clean up some copy-paste code related to SMTP communication

Streamlined the way of generating data used for MAIL FROM, RCPT TO, and data
Streamlined the way communication with the SMTP server is done (i.e. use of smtp.Client)

@bosim: I search your email address, can you publish a comment here with and remove after?
Thanks in advance.


Unable to connect to an HTTPS endpoint

Describe the Bug
I have written and run this snippet as Zeebe Modeler uses zeebe-node under the hood:
const zbc = new ZBClient('<IP_ADDRESS>:50051', {
	oAuth: {
	  url: 'http://<IP_ADDRESS>:4000/token',
	  audience: '***********************************',
	  clientId: '***********************************',
	  clientSecret: '****************************************',
	  cacheOnDisk: true,
	},
	useTLS: true,
});

Here are the logs:

10:52:30.488 | zeebe |  INFO: [topology]: 14 UNAVAILABLE: failed to connect to all addresses
E0423 10:52:31.487000000 12952 ssl_transport_security.cc:1245] Handshake failed with fatal error SSL_ERROR_SSL: error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER.
10:52:31.503 | zeebe |  INFO: [topology]: Attempt 2 (max: -1).
10:52:31.505 | zeebe |  INFO: [topology]: 14 UNAVAILABLE: failed to connect to all addresses
10:52:32.505 | zeebe |  INFO: [topology]: Attempt 3 (max: -1).
10:52:32.507 | zeebe |  INFO: [topology]: 14 UNAVAILABLE: failed to connect to all addresses
E0423 10:52:33.103000000 12952 ssl_transport_security.cc:1245] Handshake failed with fatal error SSL_ERROR_SSL: error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER.

However, when I do useTLS: false, it does work ! I have another endpoint in HTTPS, and it only works when useTLS is set to false, otherwise, I get the error above!
Steps to Reproduce

Open Zeebe Modeler, and pick OAuth
Enter your OAuth credentials
Check Zeebe Modeler logs:

Windows: C:\Users\yourUser\AppData\Roaming\zeebe-modeler\Zeebe Modeler\logs\log.log
MacOS: ~/Library/Logs/Zeebe Modeler/log.log

Expected Behavior
The same behavior as when the authentication method is set to None.
Environment

OS: Windows 10 10.0.1904
Zeebe Modeler Version: 0.12
Node: 12.18.3
npm: 6.14.9
Chrome: 90.0.4430.85

@younes-io  Thanks for reporting this issue.
I understand from the description that you already located the bug in zeebe-node and that even when using zeebe-node outside of the CamundaModeler you cannot connect to a TLS endpoint by setting useTLS to true. Is my understanding correct?
If my understanding is correct, then we should open an issue directly in the zeebe-node project.
Thank your for a quick confirmation.

Hello @MaxTru
Indeed, your understanding is correct. I'm using Zeebe Modeler, not Camunda Modeler, which also uses zeebe-node under the hood.
Do I report this issue in the zeebe-node project ?
Best regards,

Opened an issue here : https://github.com/camunda-community-hub/zeebe-client-node-js/issues/218

Thank you!


Fix missing PooledList usage in CalendarItem.

What does the pull request do?

Splitting my value storage PR to make review a bit easier. https://github.com/AvaloniaUI/Avalonia/pull/8151
I've forgotten about this change in one of my recent PRs.

You can test this PR using the following package version. 0.10.999-cibuild0021043-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


Remove Binary Datatype from dropdown list

Summary
Binary Type is deprecated and should not be a part of the dropdown. Unfortunately we can't remove it entirely for backward compatibiity

How did you test this change?

[ ] Test(s) added
[ ] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

@hardikmaheshwari we dont need to do any of these changes. Studio still needs to work if there is a binary property defined. We want to just remove it from our dropdown.
The only places we need to change is the method usableClassPropertyTypes in
GraphManagerState.
We can add binary to this filter
https://github.com/finos/legend-studio/blob/master/packages/legend-graph/src/graph-manager/GraphManagerState.ts#L165


feat: filter remedies in prohibitions

What this PR changes/adds
#4056 added remedy to Prohibition but the ScopeFilter part was missing
Why it does that
policy evaluation
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Part of #3959
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.70%. Comparing base (7f20ba5) to head (a74d0c3).
Report is 202 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4092      +/-   ##
==========================================
+ Coverage   71.74%   74.70%   +2.95%
==========================================
  Files         919      979      +60
  Lines       18457    20080    +1623
  Branches     1037     1128      +91
==========================================
+ Hits        13242    15000    +1758
+ Misses       4756     4589     -167
- Partials      459      491      +32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Feature Request] --ip option for VHOST enumeration

Hello,
gobuster has been my go-to for enumeration for a while now. One issue I ran into recently is that the tool assumes the subdomain and the base domain name share the same IP address. Often times this is not the case.
I ran into an issue today where I wanted to enumerate vhosts on a server that was part of the same domain but didn't resolve to the IP of the base domain name. I had to override the domain name in my hosts file just to enumerate vhosts.
I think this is something that should built into gobuster. I'd like to request that we add an --ip option. By default gobuster will brute force using the IP of the base domain if --ip is not supplied.
Example:
gobuster vhost -r --wordlist bitquark-subdomains-top100000.txt --url https://xyz.com -k -t 100
xyz.com = <IP_ADDRESS>
test.xyz.com = <IP_ADDRESS>
Both subdomain and base domain name have the same IP.
gobuster vhost -r --wordlist bitquark-subdomains-top100000.txt --url https://xyz.com -k -t 100 --ip <IP_ADDRESS>
xyz.com = <IP_ADDRESS>
test.xyz.com = <IP_ADDRESS> <- This is the actual target.
Subdomain and base domain name have different IP addresses

Hi @pmgcrypto ,
the vhost mode is only useful to discover vhosts on the same ipadress / webserver. I think what you are looking for is dns mode where you can find subdomains of a domain hosted on another IP.

@FireFart - I'm referring to the host header portion of the HTTP request. Sometimes you can have a single IP that vends multiple websites. You can brute force the host header portion of the HTTP request in order to discover other websites hosted on the same IP
https://stackoverflow.com/questions/43156023/what-is-http-host-header
For instance:
IP: <IP_ADDRESS>
# HTTP Request
GET /someresource.html HTTP/1.1
Host: www.not-vulnerable-1.com

IP: <IP_ADDRESS>
# HTTP Request
GET /someresource.html HTTP/1.1
Host: www.not-vulnerable-2.com

IP: <IP_ADDRESS>
# HTTP Request
GET /someresource.html HTTP/1.1
Host: www.vulnerable-web-server.com

All requests are sent to the same web server but yield different web pages.

yes but they all share the same ip address so that’s exactly how ghost enumeration works 🤷🏻♂ use http://ip and you are fine


refactor(rust): implement new tray menu design for general items and shared services

Note: separators are not visible because they are currently not working on tauri's 2.0.0-alpha.11 version.
In this PR I've modified the top-level items. The invitations details within shared services as well as the full invitations section will be done in different PR's.

Bugs fixed

fix(rust): modify enrollment ticket's project name to avoid rewritting the user's owned project data
fix(rust): dead lock when refreshing inlets (reader and a writer simultaneously over the same data)

I think reference icons directly with a File could break unless the icons directory is copied when building the package on Linux and on Mac or the icon needs to be embedded like .icon(Icon::Raw(include_bytes!("my-icon.png").to_vec()))

That makes a lot of sense, thanks for the heads up!


Path error when installing from source

Seems to point at some pre-Gemini leftovers:
$ go install github.com/mosajjal/askg@latest
go: github.com/mosajjal/askg@latest: <EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: github.com/mosajjal/bard-cli
	        but was required as: github.com/mosajjal/askg

please use the new client/server model code and let me know if it works fine.


About the implementation of the randomized convolutional layer

I tried to use the randomized convolution layer on my model to improve the robustness, however, I don't understand why you use a mask_vbox to calculate img in your implementation. Why not just input the original images to the randomized convolution layer? Can you give me some advice?
mask_shape = tf.shape(images)
rh = .2 # hard-coded velocity box size
mh = tf.cast(tf.cast(mask_shape[1], dtype=tf.float32)*rh, dtype=tf.int32)
mw = mh*2
mask_vbox = mask_vbox[:,:mh,:mw].assign(tf.ones([mask_shape[0], mh, mw, mask_shape[3]], dtype=bool))

img  = tf.where(mask_vbox, x=tf.zeros_like(images), y=images)
rand_img = tf.layers.conv2d(img, randcnn_depth, 3, padding='same', kernel_initializer=tf.initializers.glorot_normal(), trainable=False, name='randcnn')
out = tf.where(mask_vbox, x=images, y=rand_img, name='randout')

coinrun puts two velocity boxes on the top-left corner; you may check Appendix A in the coinrun paper or Appendix C in our paper.
These boxes are a kind of "visualized dynamics information," not a real visual information. So we do not randomize the boxes by masking them.


ci(workflows): test now only run on push to test branch

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Renault car vendor API is blocked (gigya.com)

Since some days the Renault vhicle API domains (gigya.com) are blocked by your hosts file, which is used by pihole project
Could U please check and remove the correspondig block entries?
API URL: https://renault-api.readthedocs.io/en/latest/reference/gigya.html
Official german renault URLs/Domains: https://renault-wrd-prod-1-euw1-myrapp-one.s3-eu-west-1.amazonaws.com/configuration/android/config_de_DE.json

This domain is also used for The Open University student website.

Hi Markus @thierolm thank you for this.
Which gigya.com subdomain is specifically required here?  Same question for you @metanoia02.
Various gigya.com subdomains are blocked by four of our curators. Unless you can provide the specific gigya.com subdomain, and someone can show that it isn't used for tracking, then this won't change.
So I need more specific info.

Hi Steven,
there are several projects on git, which are providing Renault vehicle informations.
I'm using https://github.com/evcc-io/evcc which is using accounts.eu1.gigya.com domain to load my car parameters (ZOE).
There are also other git projects like https://github.com/edent/Renault-Zoe-API.
In one of its issues the My Reanult App API Domains are named: https://github.com/edent/Renault-Zoe-API/issues/18
It would be really great if your host list would not block

accounts.eu1.gigya.com.

Its necessary to login and get the token for the My Renault app: https://apps.apple.com/de/app/my-renault/id1440073013

Thanks Markus @thierolm.  We don't block accounts.eu1.gigya.com.
As for everything else, thank you for those links but going down rabbit holes, looking for meaning, is not my gig. Not what I signed-up for.
Again, I need specific gigya.com subdomains to consider so I can route this request to the proper upstream curator(s). Everything else is just noise.

I'm using pihole+unbound docker image.
pihole uses by default https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts as adlist.
In this file you can find eu1.gigya.com.

@thierolm you said, twice: accounts.eu1.gigya.com 🙄
Why is this so hard? Just tell me which domains we need to look at.
I'm closing this issue now. When and if you start understanding what's required, I'll consider it.  Stop wasting my time.


Test Markdown sanitizer thoroughly

Relevant: a development diary about documents and Markdown.
If the Markdown sanitizer can be thoroughly proven to make validatible documents when inputted into edit-text, then we can enable 1) importing Markdown files and 2) possible flatfile storage with Markdown support (like storing directly to Dropbox).

Is there an independent Markdown test suite of documents?
Can this be fed into a test suite for making sure the sanitizer can always produce a valid Mercutio document as an output?

I compiled a markdown corpus after scraping Github.


Allow access to [parent] variable

I'd really want access to the name of the parent require. So if I require a module bootstrap and it does:
require('abc.css')
I can then control the output of that file and have it be:
somedir/bootstrap/abc.css
I'd imagine it's something like:
?name=somedir/[parent]/[name].css

Another thing that would be helpful is naming based on the parent file as well as parent module. So maybe:

[parentFile]
[parentModule]

@natew we use https://github.com/webpack/loader-utils#interpolatename for interpolate filename. What mead parent*? How we can determinate parent?


Nginx based ingress controller container not starting

Hi all,
I am trying to deploy the nginx based ingress controller as of in [1]. But I have been unable to do so. Simply the container won't start. It gives the following error.
nginx-ingress-rm4p7       0/1       CrashLoopBackOff   9          18m
and
18m		1s		106	{kubelet <IP_ADDRESS>}	spec.containers{nginx}			Backoff		Back-off restarting failed docker container
Any help on this is highly appreciated.
[1] https://github.com/kubernetes/contrib/tree/master/Ingress/controllers/nginx-alpha

Hello, you can check my public image dimamack/ingressrc:0.1
Also, make sure that you have Ingress configured properly.

Hi,
There was an issue in my ingress yaml. Sorry for creating the noise. Thanks for your reply.

Sounds like things are resolved. Closing. cc @bprashanth

Hello,
The issue indeed exists if you create an Ingress resource before creating services this resource references.

Thanks pleshakov.
I had created the replication controller and the server prior to creating the ingress.


[Feat] Add support for route params

Added support for parameters in the routes, which are then stored in a RouteParams config object passed to the HandleFunction.
The code is mostly taken and adapted from gorilla mux. I suppose there isn't a problem from taking code from there but please let me know if there is.
Changes

Routes can now be entered with route parameters such as /example/{id}/{id2} and will match the correct HandleFunction
Matcher allows for regex expressions: /example/{v1:[0-9]{3}}/hello
Added tests for the mux to control as many cases as possible
mux.Message now also contains a RouteParams struct which has the path entered and the Variables stored as a string map
Routes should always have a / at the start

I've cherry-picked the commits into a branch and did the necessary updates - https://github.com/plgd-dev/go-coap/pull/295 .
@jkralik what do we do about the license:

The code is mostly taken and adapted from gorilla mux. I suppose there isn't a problem from taking code from there but please let me know if there is.

gorilla/mux uses BSD license (https://github.com/gorilla/mux/blob/master/LICENSE), if I read it correctly then we should add the copyright notice to the mux/regexp.go file which is mostly adapted from the gorilla/mux code.

I've cherry-picked the commits into a branch and did the necessary updates - #295 .
@jkralik what do we do about the license:

The code is mostly taken and adapted from gorilla mux. I suppose there isn't a problem from taking code from there but please let me know if there is.

gorilla/mux uses BSD license (https://github.com/gorilla/mux/blob/master/LICENSE), if I read it correctly then we should add the copyright notice to the mux/regexp.go file which is mostly adapted from the gorilla/mux code.

Sure.

Oh, hey guys, sorry about that I totally forgot about this :(
Probably it's a bit late but if you need any help just let me know

Commits merged in this rebased PR - https://github.com/plgd-dev/go-coap/pull/295.


docker: Error response from daemon: manifest for tombenke/darduino:v1.8.5 not found.

Could maybe use a bit more documentation on bringing this up on a fresh machine.

@rdm If you check out https://hub.docker.com/r/tombenke/darduino, you can see there is only one tag, latest.
you need to use
docker pull tombenke/darduinoordocker pull tombenke/darduino:latest`

I had this same issue.


⚠ Jenkins Plugins Artifactory has degraded performance

In 86a64c0, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1306 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 8fcc403 after 13 minutes.


Searching in the search bar.

You shouldn't need to copy any more Ninetails code, so please try not to.
Its as simple as,
if no https:// or http://
then search
duck duck go
right...?

I can do that.

no not DDG, use startpage, google search results but private and better than bings search results (thats what DDG uses right?)

ddg is the best, I refuse to use some off-brand crap nobody uses

I have used Duck duck go. I am not changing it right now. Please give me some time to refine the UX for tabs.

@webdev03 k

no not DDG, use startpage, google search results but private and better than bings search results (thats what DDG uses right?)

If they can get "google search results" they connect to google and so you STILL have your search queries sent to google, or am I missing something?

arguments slow progress

OK, I am working on favicon.

Resolved by #32


Badly broken constant scope-lookup in VM.

Trying to land a (seemingly unrelated) CL, I get an odd error from int the presubmit logs.
The error is:
  NoSuchMethodError: Class '_InternalLinkedHashMap<String, Object>' has no instance method 'encode'.
  Receiver: _LinkedHashMap len:3
  Tried calling: encode(_LinkedHashMap len:3)
  dart:core-patch/dart:core/object_patch.dart 46                       Object.noSuchMethod
  package:analyzer_plugin/src/channel/isolate_channel.dart 289:36      ServerIsolateChannel.sendRequest

That line is the second line of:
Map<String, Object> json = request.toJson();
String encodedRequest = JSON.encode(json);

It seems something looks at JSON.encode, looks up the definition of JSON, which is const JSON = json;, where json refers to a constant declared right next to it, and then "inlines" the definition of JSON without retaining the correct scope. Instead it tries to call encode on the map from just above.
This doesn't hapen for simple examples, so it's likely some kind of optimization that is broken.

Nevermind, I actually changed that file, and I'm looking at the wrong code.


Text in tabs titles are always in upper case

Things to check

[X] I have searched the existing issues for this bug
[X] To rule out a caching problem I made sure the bug also happens in an incognito tab

Bug type
Component
Component name
MudTabPanel
What happened?
the title in the tabs are always trnsform in uppercase when display the tabs.
Expected behavior
keep the right sentence
Reproduction link
https://try.mudblazor.com/snippet/nZA9C8IwEIZ3_4ThdhUcnNqC1I5Fkezlaq5YCElJUr9-vWltilOGZsrd8_LccVVVYqu2Bj_arJOyFxxrywpJD3StVinsgV11rwSJFJzpCdix6-S7aBq6Oct1rpXzBjIBX1CRzCVam0KHmwNkK-bf5B4p4_RyKfiSnRVNgTnkWTZYSbkBJ7vQ_Hl2f6Komj91TO3xcvXdUHTvMbBYf2ot1pIEzL_puJGJIRkfGkqbfQE
Reproduction steps
see the test
Relevant log output
.

Version (bug)
7.8
Version (working)
No response
What browsers are you seeing the problem on?
Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi. Please, use search, such issue was already created in past: https://github.com/MudBlazor/MudBlazor/issues/1130
This is expected as its style convention in material 2.
You can always use css to override it: https://try.mudblazor.com/snippet/GaGeuZmTHAuaCMFg

Thanks


Upgrade module version to use beta only features.

V3 HL7 and V2 BQ export schema are beta only features, released in https://github.com/hashicorp/terraform-provider-google-beta/releases/tag/v4.17.0

Reopened as https://github.com/GoogleCloudPlatform/solution-acceleration-toolkit/pull/1127


Controller should fail health check until API server comes up

Currently the controller returns 200 ok on it's health check endpoint as soon as it starts serving.
We should wait until it can communicate with the API server before returning 200 ok.

The code to do the healthz actions looks to move into apimachinery. Potentially should wait to do work until after rebase in #596.

Moving to 0.0.3 because this isn't done yet.

How much of this will https://github.com/kubernetes-incubator/service-catalog/pull/615/files#r110766510 solve since it won't stay up?
Should we move the http server AFTER that block?

I might not understand your question entirely but this issue is not relevant if the controller fails on startup. We only care about checking the API server if controller comes up healthy.

Right now, before 615, there is a gap when 129-141 runs and when the controller is started.
We also don't install a handler that says whether we can contact the apiserver.
There are two remedies, part of which is done in 615

don't start up
install a handler that itself does a ping on the apiserver

Additionally, we could fail and blowup the controller if the apiserver fails to respond.
I think I know what to do now.

Moving to 0.0.4 because this isn't done yet.

@MHBauer any progress toward this issue? I am moving to the beta cycle for now

This issue is unrelated to the API surface, moving to 1.0.0


don't use immutable=1, only mode=ro

Opening db files in immutable mode sometimes leads to the file being mutated, which causes duplication in the docker image layers: see #1836, #1480
That this happens in "immutable" mode is surprising, because the sqlite docs say that setting this should open the database as read only.
https://www.sqlite.org/c3ref/open.html

immutable: The immutable parameter is a boolean query parameter that indicates that the database file is stored on read-only media. When immutable is set, SQLite assumes that the database file cannot be changed, even by a process with higher privilege, and so the database is opened read-only and all locking and change detection is disabled. Caution: Setting the immutable property on a database file that does in fact change can result in incorrect query results and/or SQLITE_CORRUPT errors. See also: SQLITE_IOCAP_IMMUTABLE.

Perhaps this is a bug in sqlite?

:books: Documentation preview :books:: https://datasette--1870.org.readthedocs.build/en/1870/

Relevant sqlite forum thread: https://www.sqlite.org/forum/forumpost/02f7bda329f41e30451472421cf9ce7f715b768ce3db02797db1768e47950d48

as far as i can tell, this is where the "immutable" argument is used in sqlite:
      pPager->noLock = sqlite3_uri_boolean(pPager->zFilename, "nolock", 0);
      if( (iDc & SQLITE_IOCAP_IMMUTABLE)!=0
       || sqlite3_uri_boolean(pPager->zFilename, "immutable", 0) ){
          vfsFlags |= SQLITE_OPEN_READONLY;
          goto act_like_temp_file;
      }

so it does set the read only flag, but then has a goto.

Just saw your comment here: https://github.com/simonw/datasette/issues/1836#issuecomment-1272357976

when you are running from docker, you always will want to run as mode=ro because the same thing that is causing duplication in the inspect layer will cause duplication in the final container read/write layer when datasette serve runs.

I don't understand this. My mental model of how Docker works is that the image itself is created using docker build... but then when the image runs later on (docker run) the image itself isn't touched at all.
Are you saying that I can build a container, but then when I run it and it does datasette serve -i data.db ... it will somehow modify the image, or create a new modified filesystem layer in the runtime environment, as a result of running that serve command?

Saw your comment here too: https://github.com/simonw/datasette/issues/1480#issuecomment-1271101072

switching from immutable=1 to mode=ro completely addressed this. see https://github.com/simonw/datasette/issues/1836#issuecomment-1271100651 for details.

So maybe we need a special case for containers that are intended to be run using Docker - the ones produced by datasette package and datasette publish cloudrun? Those are cases where the -i option should actually be opened in read-only mode, not immutable mode.
Maybe a datasette serve --irw data.db option for opening a file in immutable-but-actually-read-only mode? Bit ugly though.
I should run some benchmarks to figure out if immutable really does offer significant performance benefits.

Are you saying that I can build a container, but then when I run it and it does datasette serve -i data.db ... it will somehow modify the image, or create a new modified filesystem layer in the runtime environment, as a result of running that serve command?

Somehow, datasette serve -i data.db will lead to the data.db being modified, which will trigger a copy-on-write of data.db into the read-write layer of the container.
I don't understand how that happens.

Hello! Resurrecting this issue since we're running into something similar with data.catalyst.coop as our database files have ballooned up to several GB. Our Cloud Run revisions now require huge amounts of RAM to start up without receiving a SIGBUS.
I'd love to see this fix merged in. It sounds like we want to make the immutable/read-only mode decision more flexible before doing so, so that we can use ro in Docker and immutable outside. If that sounds right, I'm happy to take a crack at adding that as a command-line flag or something that gets set automatically based on the expected execution environment.


[BEAM-5697] Support legacy pipeline option deserialization

Please add a meaningful description for your change here

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


[DISCUSSION] General folder structure for reco, cv, and forecasting repos

I'm setting this discussion public in case any of our users or customers want to provide feedback.
Context
We are building repos around computer vision and time series forecasting. We would like to homogenise the structure between them and the recommenders repo. The CV repo is still starting and the forecast repo has been running for some time internally and it is focused on benchmarks.
The idea is to have a common structure (and user experience) between the 3 repos. Trying to have the best of each: nice examples and utilities from recommenders, nice benchmarks from forecasting repo and support for CV, as well as the other solutions in reco and forecast.
Question
What will be the optimal structure that will help our users and us to build better solutions in recommendations, CV and forecasting?
Please provide answers in detail ways, example:
e1) I would take the recommenders structure (notebooks, reco_utils, tests) and rename the folders to X, Y, Z...
e2) I would take the recommenders structure (notebooks, reco_utils, tests) and add a folder for benchmarks...
e3) ...

I think one of the other main differences between the recommenders and forecast repo structure is the idea of broad vs industry specific. I think we want a mix of both mixed throughout the repos, as there is always going to be someone looking for a specific example, like fraud detection, that offers a concrete example of how to do a thing. The more broad examples are useful if you’re looking for ideas like “anomaly detection” in general. We should also figure out how to have a progression between general > specific workflows.
I like the general structure of the recommenders repo but with some tweaks. I think we should have some sort of algo cheat sheet explaining why a user might choose one algorithm over the other (similar to the Studio cheat sheet , and that could also include the benchmarks similar to the time series repo.
This repo scaffolding could work:

Notebooks

local (might need a better name)

prepare data, models, ...

AzureML

prepare data, models, ...

Examples by Industry Vertical
utils (should be named utils instead of reco_utils)
scripts
Tests

Moves Tests.md here

.gitignore
Contributing
Contributors (A better name might be AUTHORS/ CODE OWNERS)
License
SETUP.md
README

Name
Overview
Getting Started
Notebooks
Algorithm Comparison (cheat sheet)

Benchmarks

Why AzureML?
Releases
Contributing
Build Status

I like this setup, most repos also have a code_of_conduct file.
I'm not sure we need a separate azureml directory under notebooks, we might just have examples scattered through there on how to utilize azure ml?

Great suggestion @heatherbshapiro and @bethz. I like the structure.
I'm just going to comment on the changes that you propose:

Notebooks

local (might need a better name)

prepare data, models, ...

AzureML

prepare data, models, ...

Examples by Industry Vertical

In my mind notebooks and examples by industry is the same concept, so maybe, to reduce the folders we can have 1 folder called examples. So we will have 4 big folders: examples, utilities, tests and scripts.
I think it is very interesting to have information about industry vertical. I think we need to think this well to not repeat code. This is related to how we do the transition of general to specific. Maybe we can add documentation that explains what would be the best algorithms if you are an ecommerce, and then link a notebook with an example. Or we can mention, algorithm X, Y, Z is very good for this kind of business. This could also be related to the idea of recommending an algorithm.
I agree with @gramhagen, I wouldn't add an AzureML folder. I think we should add AzureML is a less explicit way and in the places where it add value. In some situations, like the test or for computing large networks is very valuable. In that situations we use AzureML because it makes a significant difference.

utils (should be named utils instead of reco_utils)
scripts
tests

Moves Tests.md here

.gitignore
Contributing
Contributors (A better name might be AUTHORS/ CODE OWNERS)
License
SETUP.md

I agree with all this. In the past the name we had was utilities. Also, about renaming Contributors, I think it makes sense, I've seen other repos using the name AUTHORS.

README

Name
Overview
Getting Started
Notebooks
Algorithm Comparison (cheat sheet)

Benchmarks

Why AzureML?
Releases
Contributing
Build Status

Here I would remove releases. Another change I would suggest is to give more importance to the benchmarks, and this is something that the forecasting guys are doing really well. If we target professional DS, they would be super interesting on seeing algos results on different datasets. An idea on how to do this would be to have a BENCHMARKS.md, and then have code that computes the algos in the folder examples. Ideally, we would like the benchark tables to be generated automatically (the idea of a live benchmark was proposed some time ago but not implemented yet https://github.com/Microsoft/Recommenders/issues/282).

I think we want to be very explicit on the value add of AzureML and how it enhances the existing solutions. If they are intertwined in the same folder, then it might be difficult to differentiate what I can do without it and what I can do with it and what the actual value add is. We could call it out in the readme for descriptions of each notebook, but we do need to differentiate them somehow.

local->generic
AzureML->azureml or azureML?  (have a preference of using lower case in first letter of directory so user does not need to press the shift key).  This may collide with azureml python packages though.

A few items:

can we use utils_rec instead of reco_utils? makes it easier for users to recognize it's a utils folder. TLA is more common than 4 letters. And by having all our stuff be utils_xxx and utils_yyy it's easier to find them in the path
I need to think on/incorporate other comments

I like the idea of incorporating different industry verticals, which is also what we do in the forecasting repo. Since there is a lot of unique aspects in each use case (e.g., dataset, feature engineering, forecast goal), we find this way could be helpful for users interested in a specifc vertical.
Under each user case/industry vertical folder, we have a hierachy of two lower levels: benchmarks and submissions, where benchmark is a forecasting problem defined on a given dataset and submission is the implemenation of a certain algorithm that solves the problem. Currently the repo structure is as follows

common
docs
energy_load

probabilistic_forecasting_benchmark

common
data
reference (includes data exploration notebooks)
submissions

implementation_of_algorithm1
implementation_of_algorithm2
....

retail_sales

point_forecasting_benchmark

common
data
reference (includes data exploration notebooks)
submissions

implementation_of_algorithm1
implementation_of_algorithm2
....

prototypes (includes tools/methods under testing)
README
However, we don't group all the use cases in one folder which reduces another folder level. Besides, we don't have a folder named Notebooks, although we do have Jupyter notebooks that either does feature engineering or illustrates the implementation of a certain algorithm. I feel that a unified folder structure across the three repos is definitely helpful. According to our internal discussions, this will be one of the main tasks in the second phase of TSPerf project.

I don't think that we would want to only break it down by industry verticals. This will exclude users who do not fit into these categories. I think we want to have both a broad view and a specific industry view so that users can benefit from both.

@bethz rec is already widely used to be the shorthand of record.    Changing names like this require a lot of work, so let's make sure there is strong reason to do that.

@heatherbshapiro how about we list algos as the primary view, then add a folder called "use_cases" or similar to surface different use cases?

@heatherbshapiro @wutaomsft  It would be nice to accommodate both views and creating two separate folders like 'algorithms' and 'use_cases' sounds a good way to me. This may incur some redundancy though and I'm thinking how to avoid the overlap between these two folders. For instance, if we have used LightGBM algorithm to do probabilistic forecast in the energy use case and point forecast in the retail use case, it may be a bit redundant to create another experiment to demonstrate the usage of LightGBM for both applications. Maybe we can add a toy example under 'algorithms' or simply document each algorithm there with links referring to the implementations in 'use_cases' folder? The former approach may not complemetely resolve the redundancy and does require a lot of additional effort for the forecasting repo. Thus I'm not sure if this is a realistic approach.

I agree, i like the idea of having 'algorithms' with a toy example and then 'use_cases' if there is not too much work - that was similar to what I originally proposed with notebooks and industry verticals. Would use_cases be a sub directory of algos or another top level one?

What I had in mind was a list algorithms (no need for an "algorithms" top level folder).  There would be a folder called "use_cases" that describe how one would solve a particular use case.  I don't think we need to duplicate any content in algorithms notebooks here; instead we will just present some technical discussions of the use case and then make references to the appropriate algorithm notebooks.  In this sense, the "use cases" folder is more like a "soft link" to other materials in the repo.

I am not sure what is the situation with forecasting, but for recommendations there are not so many public data sets available to cover all the use cases that arise in practice. So this restricts how many notebooks / code we can write, whereas we can write documentation for more use cases.

It would be great to simplify the top-level folder layout like "examples, utilities, tests and scripts" being placed in parallel. Under examples we may have want to have notebooks for

quick-start (or anything else we want to call it) that contains toy-examples for demonstrating a particular algorithm, together with necessary data prep, feature engineering, etc., for an actual use cases.
deep-dive which explains what each algorithms/data-prep/benchmarks do in a theoretical way.
azure-deploy that shows how things can be augmented by using Azure services (e.g., AML, Databricks, Cosmos DB, etc.).

To elaborate more, in the reco repo, we have "quick-start" notebooks that demonstrate how algorithms can be developed into an e2e pipeline (in local environment). Probably we can extend these notebooks with use case examples to show the efficacy of each algorithm in resolving a particular problem. The "quick-start" notebooks reference the "deep-dive" notebooks for technical details about data-prep/feature-engineering/algorithm and "azure-deploy" notebooks for about Azure services and products.
The idea of cheat sheet is great. Alternatively we can tabulate the offerings in the repo and list their pros & cons as guidance for users to choose wisely for their actual use cases.
Generally, IMHO it would be great to make the things in each repo "modular" and "reusable".

i like the idea of having 'algorithms' with a toy example and then 'use_cases' if there is not too much work
algorithms looks pretty similar to what we call quick_start. Then we have in model the deep dives which explain in detail each algo, then we have operationalization that focuses on production (and assume that if you want to know in detail about an algo, you would go to the deep dives).

@chenhuims I would like to understand better the usecases you guys have. I see that you have 2 industries: sales forecasting and energy forecasting, and also you only have 1 dataset per each. Do you have a list of all the usecases you would like to add and the datasets that you would use?
same question for @PatrickBue

Hi, not sure this answers your question @miguelgfierro fully, but at the very least we will have ~10 internal datasets for testing and parameter tuning. In addition, there will be at least one tiny dataset for each use case which is used in the demo notebooks, plus eventually real-life examples for different verticals. We do not currently plan to show how to train using research datasets such as MNIST (too small resolution and hence meaningless) or ImageNet/Coco (too big and pre-trained models exist anyway).

https://github.com/zalandoresearch/fashion-mnist is an interesting alternative to mnist

@miguelgfierro We don't have a complete list of all the use cases and datasets, since there are probably too many variations in time series forecasting. Some example use cases that I can think of are financial forecasting, traffic forecasting, manufacturing quality prediction, etc.
@wutaomsft I think it is a good idea to use a soft link to bridge the gap between use cases and algorithms. This echoes with my thoughts about doing this in the other way by referring to the use cases in the 'algorithms' folder for the forecasting repo.


adding transformation

looks great! hav eyou tested that it works on the merfish example we had issues in the hackathon?

yes it works @giovp

Codecov Report
Patch coverage: 95.23% and project coverage change: +0.27 :tada:

Comparison is base (beefab2) 76.55% compared to head (c61fe5d) 76.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   76.55%   76.82%   +0.27%
==========================================
  Files          11       11
  Lines        1322     1342      +20
==========================================
+ Hits         1012     1031      +19
- Misses        310      311       +1

Impacted Files
Coverage Δ

src/napari_spatialdata/_utils.py
70.31% <92.85%> (+2.76%)
:arrow_up:

src/napari_spatialdata/_interactive.py
92.30% <100.00%> (+0.64%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Support for 4.2″ ST-GR42003N2

Add Support for 4.2″ ST-GR42003N2 (https://github.com/OpenEPaperLink/Home_Assistant_Integration/issues/145)

Thank you for your contribution


Fix CORS requests

Check for options requests on CORS

Super excited for this PR - started to build out a versioned aPI with this module and my versioned routes weren’t getting through CORS due to these lines.

fixed building error in travis-ci

Thanks for the PR.


future update

multi-language support
yu-gi-oh db link for each card
task on background

희망사항

all implemented


Feature request: Identifiable secret labels on x509_read_errors metric

Hello!
Similar to the other 3 metrics, would be possible to get more identifiable secret labels on the x509_read_errors metric?
For example, the exporter logs read
read error 1: failed to parse "k8s/kube-test/first-tls", tried to parse
malformed x509 data, x509: SAN dNSName is malformed

but the x509_read_errors metric does not give indication of which secret or certificate has failed to have been read
x509_read_errors{container="x509-certificate-exporter", endpoint="metrics",
instance="xx.xxx.x.xx:xxxx", job="x509-certificate-exporter-headless",
namespace="monitoring", pod="x509-certificate-exporter-7d4878bd67-sv9qw",
service="x509-certificate-exporter-headless"}

Maybe something like secret_name, secret_namespace, etc. to identify the problem without having to look at the logs?
Thanks for the work on this great project :)

Hi Luke,
thanks for proposing, we will get back to you by the end of next week, sooner if possible.
Cheers

Hi @LukeBalizet
A new version was released with improvements regarding this issue. It's available on our Helm Chart from version 1.16.0.
New metrics will not be enabled by default, so depending how you deploy the exporter you would either :

add argument --expose-per-cert-error-metrics to command lines
set Helm value exposePerCertificateErrorMetrics: true

There were a few concerns with reusing the metric named x509_read_errors, as it's supposed to be a counter, and may have a loose definition of errors it catches despite it's naming.
So when enabling the feature flag we now push x509_cert_error with labels :
x509_cert_error{secret_namespace="demo", secret_name="demo-failure", secret_key="tls.crt"}
An alerting rule can be as basic as :
x509_cert_error > 0
No need to compute the rate as was required with x509_read_errors.
I hope you'll be happy with the implementation. Let us know if you have any remark.
Cheers

Hi @npdgm
This is PERFECT! Everything looks great. (Also thanks for adding the alert to the PrometheusRule!)
Thank you for the awesome response time and all your hard work on the project 😄


Method of using the model generated after training

I would like to know how to use the trained model. It generates a checkpoint 30 folder, adapter_ Config.json and adapter_ model.bin。 How should I use Lora's finely tuned model? Can anyone help me?

I found the following information online, but I don't understand the rest. Can anyone help me?
tokenizer = AutoTokenizer.from_pretrained("base-model", trust_remote_code=True)
model = AutoModel.from_pretrained("bsae-model", trust_remote_code=True).half().cuda()
peft_config = LoraConfig(
task_type=TaskType.CAUSAL_LM,
inference_mode=False, r=8, lora_alpha=32, lora_dropout=0.1,
target_modules=['query_key_value',],
)
model = get_peft_model(model, peft_config)

So I did not complete all training iterations, hence, the adapter-model.bin does not exist in my saved weights. How do I load my saved weights then? I have all the rest of my files in my checkpoint but adapter_config.json and adapter_mode.bin


KFAnimatedImage looses animation if downsampled

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[x] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
KFAnimatedImage looses animation if downsampled
What
I want to display images on the grid and often downsample them to reduce memory consumption. KFAnimatedImage works well, however if I try to downsample the image no longer moves and only first frame (I think) is visible.
Reproduce
The following gif will not be animated.
        KFAnimatedImage(URL(string: "https://static.wikia.nocookie.net/128059c1-2a7a-48b7-b807-48fe9e417ca7/scale-to-width/755")!)
            .downsampling(size: CGSize(width: 150, height: 150))

Downsampling is a processor only for static images. For animated images like GIF, I guess there is currently no way to get its thumbnail before decoding it yet.

is there any way get the image format first, after that i can know if use the Downsampling


please do version 1.21.1 Looting Shears

it doesnt work for me on 1.21.1 so please make it work for 1.21.1

Support cannot be added for 1.21.1 as the required loot tables do not exist until 1.21.3


Minor HTML changes and livereload fix

I noticed, when browsing http://localhost:9000/#/app/about that livereload wasn't detecting changes in HTML views when updating.  The attached has grunt watch search all html files, not just the first level down.

Thanks for this PR @drmikecrowe , I'll check it over the weekend :)

@drmikecrowe I've merged the first three commits.
Could you please put the docker support in another pull request? Thanks a lot for considering!


Update Composer dependencies (2022-01-28-00-08)

Visual regression test passed!
View the visual regression test report


feat(runtime-dom): defineCustomElement without shadowDom (#4314)

This PR add an optional parameter to defineCustomElement to disable shadow DOM on mount.
This is a first draft, let me know if that sounds good to you and I can add more tests / docs if needed.
Thanks :)
Fixes https://github.com/vuejs/vue-next/issues/4314

There is a current limitation when not using Shadow DOM : using slot inside web components is not working :
<my-comp>

Some content

</my-comp>

The div is rendered after the element instead of replacing my-comp-defined slot.
This is because slot elements are not natively supported without Shadow DOM.
However, it should be possible to implement slot without shadow DOM inside Vue. Stencil seems to already support this : https://stackoverflow.com/questions/48726904/is-there-a-way-workaround-to-have-the-slot-principle-in-hyperhtml-without-using

I implemented slot without shadow DOM on the same principle as https://github.com/vuejs/vue-web-component-wrapper/ (creating a VNode with innerHTML).
I'm using a local copy of apiCustomElement.ts for the needs of my project.
If anyone is interested, I can share it!
Let me know if you want me to add the slot implementation without shadow DOM to this PR.
Thanks!

Any chance this will get officially supported?

Hoping to see this move along! One thing to be mindful of with this option, is how fallthrough attributes behave. For example, currently, class attributes are inherited on single root elements, but they also remain on the custom element leaving duplicate, nested, style declarations.

@chasegiunta You're right, this PR does not support named slots. I don't have remaining local changes that are not part of this PR.
Feel free to create a fork from my own to add support for it :)

@gnuletik I've added named slot support locally. Getting fallthrough attributes to work for single root elements can be included next to button up this feature, but curious if it's even worth pursuing @LinusBorg @yyx990803 ? Is this the right direction?

@gnuletik I've PR'd support for named slots into this branch. As for fallthrough attributes onto single root element components, or for slots without parent elements, I've worked out my own solution wrapping the contents in an element with display: contents for now, but I'd suspect that's not the best approach as an official solution to either of those issues. If anyone reading this is interested in that approach until something concrete is put into place, feel free to reach out.

I needed this functionality now so I implemented the PR locally as described here:
https://github.com/vuejs/core/issues/4314#issuecomment-1021393430
However, my Vue project is not using TypeScript, so I used an online TypeScript to JavaScript converter.  My Vue project built fine, via Vue CLI, but I got an error in the browser:
apiCustomElement.js:467 Uncaught ReferenceError: __DEV__ is not defined
    at eval (apiCustomElement.js:467:11)
    at Array.forEach (<anonymous>)
    at VueCustomElement._applyStyles (apiCustomElement.js:460:16)
    at resolve (apiCustomElement.js:296:16)
    at VueCustomElement._resolveDef (apiCustomElement.js:307:9)
    at VueCustomElement._connect (apiCustomElement.js:176:14)
    at VueCustomElement.parsedCallback (apiCustomElement.js:167:14)
    at eval (index.js:18:25)
    at Array.forEach (<anonymous>)
    at upgrade (index.js:15:21)

To resolve it, I had to add a line of code to the converted JavaScript.
const BaseClass =
    typeof HTMLElement !== "undefined" ? HTMLParsedElement : class { }

**const __DEV__ = (process.env.NODE_ENV === "development")**

export class VueElement extends BaseClass {
    /**
     * @internal

@retail-robot we are waiting for maintainers feedback.

There is an error when trying to build this
D:\vue-next\packages\reactivity\src\index.ts → packages\reactivity\dist\reactivity.global.js... [!] (plugin rpt2) Error: D:/vue-next/packages/runtime-dom/src/apiCustomElement.ts(25,31): semantic error TS7016: Could not find a declaration file for module 'html-parsed-element'. 'D:/vue-next/packages/runtime-dom/node_modules/html-parsed-element/cjs/index.js' implicitly has an 'any' type.   Try npm i --save-dev @types/html-parsed-elementif it exists or add a new declaration (.d.ts) file containingdeclare module 'html-parsed-element';packages\runtime-dom\src\apiCustomElement.ts Error: D:/vue-next/packages/runtime-dom/src/apiCustomElement.ts(25,31): semantic error TS7016: Could not find a declaration file for module 'html-parsed-element'. 'D:/vue-next/packages/runtime-dom/node_modules/html-parsed-element/cjs/index.js'  implicitly has an 'any' type.   Trynpm i --save-dev @types/html-parsed-elementif it exists or add a new declaration (.d.ts) file containingdeclare module 'html-parsed-element';     at error (D:\vue-next\node_modules\.pnpm\rollup@2.38.5\node_modules\rollup\dist\shared\rollup.js:5239:30)     at throwPluginError (D:\vue-next\node_modules\.pnpm\rollup@2.38.5\node_modules\rollup\dist\shared\rollup.js:18179:12)      at Object.error (D:\vue-next\node_modules\.pnpm\rollup@2.38.5\node_modules\rollup\dist\shared\rollup.js:18786:24)          at Object.error (D:\vue-next\node_modules\.pnpm\rollup@2.38.5\node_modules\rollup\dist\shared\rollup.js:18348:38)          at RollupContext.error (D:\vue-next\node_modules\.pnpm\rollup-plugin-typescript2@0.27.3_rollup@2.38.5_typescript@4.5.3\node_modules\rollup-plugin-typescript2\src\rollupcontext.ts:37:18)     at D:\vue-next\node_modules\.pnpm\rollup-plugin-typescript2@0.27.3_rollup@2.38.5_typescript@4.5.3\node_modules\rollup-plugin-typescript2\src\print-diagnostics.ts:41:11     at arrayEach (D:\vue-next\node_modules\.pnpm\rollup-plugin-typescript2@0.27.3_rollup@2.38.5_typescript@4.5.3\node_modules\rollup-plugin-typescript2\node_modules\lodash\lodash.js:516:11)     at Function._.each [as forEach] (D:\vue-next\node_modules\.pnpm\rollup-plugin-typescript2@0.27.3_rollup@2.38.5_typescript@4.5.3\node_modules\rollup-plugin-typescript2\node_modules\lodash\lodash.js:9368:14)     at printDiagnostics (D:\vue-next\node_modules\.pnpm\rollup-plugin-typescript2@0.27.3_rollup@2.38.5_typescript@4.5.3\node_modules\rollup-plugin-typescript2\src\print-diagnostics.ts:9:2)     at Object.transform (D:\vue-next\node_modules\.pnpm\rollup-plugin-typescript2@0.27.3_rollup@2.38.5_typescript@4.5.3\node_modules\rollup-plugin-typescript2\src\index.ts:242:5)
Does something need to be done to fix the html-parsed-element dependency?

Any update on this? any chance we will see this in official package?

Are you aware of #7942?

@LinusBorg any chance someone from Vue core team can look at this PR? We need a way to create web components that allows an end-user to be able to customize the style of the component.

Thanks for pushing this forward! @gnuletik any thoughts on @sodatea's comments? Anything eager audience members can do to help? 😊

The latest version of https://www.npmjs.com/package/vue-web-component-wrapper can now generate vue web component
without Shadow DOM with slots and name slots and nested web-component
Here is the demo of web component without shadow DOM
https://stackblitz.com/~/github.com/EranGrin/web-component-no-shadow-dom-demo

https://github.com/vuejs/core/issues/4314#issuecomment-2266382877


Add DNS port forwarder and P2P UDP tunnel

The TCP tunnel code helped me much , THANKS
I implemented the UDP port forwarder to let this repo more functional

Hi! Thanks you very much for the new features. Looks very useful. Just some minor requests:
-Can you fix the comments? So remove pointless empty comments and at least UDPTunnel.java has a comment in some foreign language (Google Translate tells me it is Chinese). Could you just translate that to English?
-Can you fix the author in your Javadocs from Administrator to yourself?
-I see there are no tests for the commit, so can you just briefly tell me the procedure to test this?
Thanks again :)


Fix viable individuals being double counted in steady_state

When individuals are born, they are already added to the birth counter. When checking for viability, non-viable individuals are counted down (if told to do such), but viable individuals were counted again.

Just noting for now that this complements #273, which addresses a different manifestation of a similar issue.


Sync doesn't seem to work Chrome Win7 -> Chrome Win8

I used dropbox to sync the program & the backup file for my work computer and I did restore backup to first server multiple times.

It still doesn't work.

I am unsure what isn't working.

Chrome sometimes ends up running in the background and changing extension data then leads to the file not being written properly - or more accurately chrome overwriting it soon-ish. Do you see it running when you open task manager?

There we go, there were some processes in the background.
Shit chrome does.

Btw, you're a boss and you should join the RES team
Syncing is the only thing the whole shebang was missing, and you saved me time (after about 10 RES data losses and only sticking to default)
Thanks.

Thanks, I really appreciate it! I'm glad it helped and worked as expected!


What is CLIENT_AUTHORIZATION?

Issue description
Hello!
Code examples have CLIENT_AUTHORIZATION, but this not described (what is format of this? String? some object from SDK?).
Also, in some examples it's a String, like key/switcher. There is, for example: https://developers.braintreepayments.com/guides/client-sdk/setup/javascript/v3
I have a key looking like access_token$sandbox$alpha_numeric$another_alpha_numeric, and I don't understand what to do next.

Here are the docs for a client authorization: https://developers.braintreepayments.com/guides/authorization/overview
The short answer is that it's either:
• a client token that you generate on your server for each page load.
• a tokenization key, which is generated in the Braintree control panel and can basically only tokenize payment methods. (it can't do client side vaulting or 3d secure, etc)
Please reach out to our support team if you have additional questions: https://help.braintreepayments.com/


Removes tab character from a bunch of templates.

Also need to regen templates. List values are included in the validations. I can do that on this branch just to make sure

I don't know how to do that, so feel free to update this branch with the necessary stuff or create a new PR.  I just figured it would be easier to submit a PR with the problem rather than trying to describe it in an issue.  :)


feat(player): Entity visibility

Description
Implements hideEntity, showEntity, canSee(Entity) and makes hidePlayer, showPlayer, canSee(player) use the same map as the hidden entities
Checklist
The following items should be checked before the pull request can be merged.

[x] Code follows existing style.
[x] Unit tests added (if applicable).

Looks good to me, I'm going to wait until the v1.21 branch gets fully set as the main branch. I don't have perms to do anything about that, so I have to wait.


Allow to execute commands

Great work on codetour!
In order to improve user interactivity, have you considered allowing to execute commands as part of tour steps? Some buttons could allow end users to trigger those.
ShepperdJS does that kind of things and it greatly improves tours IMO.

Hey! Yes this is definitely something I’d like to add 🤗 CodeTour currently supports adding shell commands to a step, and it would be a simple addition to allow calling arbitrary VS Code commands. Out of curiosity: do you have any specific actions/commands in mind?

I think having any vscode commands be invliked in a tour step could make it possible to even demo custom extensions.
For example, I've been thinking about creating a code tour to demo Data Preview If I could specify vscode commands in tour steps, I could add data.preview <somePublicDataUrl> for a brief display of what it does ...

Right, pretty much what @RandomFractals said! Would be a great way to showcase other extensions :)
Another use-case I had in mind: open a rendered markdown file, open a preview browser, ..
You could probably even reuse it to trigger different tour flows e.g. skip some steps

yeah, could open a lot of opportunities. Since code tour is one of the gistfs/gistpad dependencies I was thinking one could even pull in gists in gistpad and create a code tour for a gist with refs to code lines and light docs about what they do in addition to typical gist md docs.

@lostintangent Would you be interested with help on this one?

I pushed a change in v0.0.026 that ensures this is possible 😄 But I think there can potentially be some improvements to the experience to better optimize certain workflows (e.g. similar to how I introduced the >> syntax for adding shell commands to a tour step).
To make use of this, you can simply add a markdown link to a step's description, and instead of it being an HTTP URL, you can point it at a command: URL that references the name of the VS Code command that you want to call when the end-user clicks the link. For example, the following illustrates how you could add a link to call a command that doesn't require any parameters.
[Link Title](command:extensionName.commandName "Optional link title")

If the VS Code command requires parameters, then you simply define them as a JavaScript array, URL-encode them, and then add that string as a query string of the command URL. For example, to pass "foo" to a command, the URL would look like the following: command:extensionName.commandName?%5B%22foo%22%5D

I just shipped an update to CodeTour that makes two additional improvements:

It automatically encodes your command arguments, in order to make the authoring process simpler
It now includes a completion provider, for prompting you with common commands as soon as you type (command:. This way, you don't have to remember the name or arguments for basic scenarios (e.g. navigating to another tour/step, launching a URL, running a shell command).

With this, you should have everything you need to call any command from a tour step. That said, I'd love to hear if there are other commonly-used commands, that would benefit from being added to the completion list. Thanks again for the feedback and let me know how I can improve things further!

Wow thanks a ton! This is seriously awesome!

This works for me with opening the file, however I was wondering if I'd be able to run the command markdown.showPreview in order to open the preview of an existing Markdown file in the codebase from a link in the CodeTour step.
i.e. ./docs/CONTRIBUTING.md but in Markdown preview mode.


Output color properties can be either six-digit hexadecimal or RGB. After converting to HTML, 8-digit hexadecimal colors cannot be recognized.

Is there an existing issue for this?

[X] I have searched the existing issues

The question
Output color properties can be either six-digit hexadecimal or RGB. After converting to HTML, 8-digit hexadecimal colors cannot be recognized.

duplicate


Thoughts on using illuminate/collections to avoid direct array access wherever possible?

Currently, as per the README example, I would have to access a completion this way:
echo $result['choices'][0]['text'];

OR

echo $result->choices[0]->text;

Proposal using illuminate/collections:
echo $result->choices->first()->text;

In my opinion, it doesn't have any major impact but still cuts down the direct array access

No plans for that at this time.


Remove uses-permission from AndroidManifest.xml

Fixes #34.

This looks good to me. 👍
Will wait for Mike's approval before we merge it.

Yeah - I'm okay with this philosophically, I think it's a good change
But it's a breaking change as integrating it might cause existing installs to suddenly stop working with permission errors. For the record I am pro-breaking change just with some help for devs
I feel it should be accompanied by a bump to version 2.0 and a "migrating" section in the README that outlines what changed and why (this PR has great text for that already) and what exactly needs to be done (again, I think the PR does a great job already).
Not trying to create busy-work, I am literally picturing about 7 lines in the README.md - it is just that you know that feeling when a library you depend on either breaks something with a minor release (arrrggghhh!!) or you see a major release, go to the site to see what happened and either blow an hour reading stuff (booo) or see that magical "migrating from version N to version N+1" section (sound of angels singing)
I'd like to be in the "angels singing" section of modules :-)

Yeah. Totally agree... WIll add a upgrade section in README.
@mikehardy  When are you planning to release the new version? Just curious so that I can upgrade it to my app too.

@sulaysumaria not me man, @briankabiro is the boss here, I'm just helping out because I use the module and like spreading my effort upstream too :-)

Hey @sulaysumaria. We(I) usually do a release after merging a PR. Once we have the README updated, we can get this merged and do a release.

@briankabiro, Updated the README. Maybe you can review it once if it is good enough.

readme change looks good and then I just though hey! does the example have this in the manifest so it will continue to work? I checked and it does, so it should still run out of the box. LGTM...

Yeah.
I just noticed the example is missing the deleting messages exmaple.
On other note
Maybe we should add all this points to check in a CONTRIBUTING.md file. Like what all things to perform when contributing. To mention a few:

Update README if necessary.
Update example if broken.
Add comments to code explaining what it is doing.

Something like a checklist?

I love the idea of a checklist personally, markdown has it and it works well in other projects I use. I would just put it in .github folder as a template like so https://github.com/react-native-community/react-native-device-info/blob/master/.github/pull_request_template.md
As for the example not including delete that's because delete is basically forbidden on android these days. You may only do it if you are the default SMS app on the system, which is a very strong position for an app to occupy - if you are doing that, you'll know how to do delete I think ;-). Could be worth a comment but for me, trying to get the example to demonstrate that (ask for permission to be the default SMS app etc) was more than I wanted to do when I was working in there...

Okay. So unless you set your app to default SMS App, there is no way to delete SMS. That's something new for me. 😄
I would also like the checklist. Maybe we can include that with the 2.0 release.

https://developer.android.com/about/versions/kitkat.html#44-sms-provider - there is the reference - it is as of Android 4.4 (API19, which is almost completely obsolete meaning almost no one can delete sms now, unless they are the default provider) but as I read that changelog maybe this package could implement a listener for SMS_RECEIVED intent on the Android side and EventEmitter on the react-native side, allowing for javascript listeners to hook in and be notified of new SMS
I am not volunteering but it seems like it would be fit in this module :-)
As for the PR template, I am not authoritative and would not want to stop this PR from merging but that is an easy stand-alone PR if you have the time to submit it...

Okay. In another PR then.

Hi, going to take another look at this and see whether we can get it merged.

Hey, @sulaysumaria. Apologies for the late reply.
I think there's a merge conflict in the README file from the merged changes in #40.
Could you be kind as to make the change?

@briankabiro , this PR is actually too old and I am no longer using react-native... Anyone else who wants this change to be merged can look at this...
Btw, I switched to flutter and its awesome...

Haha, I understand. I can make relevant changes and merge it.

Going to close this as I've opened a duplicate PR here. #41
Thanks, @sulaysumaria. I'm also going to get started on creating a changelog for the project.


[Examples Browser] Updates & fixes

This PR contains a bunch of tweaks and fixes to the examples browser project. There were too many small changes to justify individual PR's so i've grouped them here.
Updates

Bump playcanvas dependancy to 1.44.2 playcanvas/engine@32b7a1c
Support performance and debug builds of playcanvas in examples (defined using the static ENGINE property). This enables the mini stats in the clustered lighting example playcanvas/engine@2a61f07 (#3254)
Show mini stats toggle no longer requires an example rebuild to switch playcanvas/engine@6b1b3ac (#3297)
All non example paths now direct to the hello world example playcanvas/engine@70179a1 (#3303)
When switching thumbnail sizes in the side bar, the position of the top most nav item is maintained playcanvas/engine@5c5a94d
Opening the examples browser using a specific path to an example will scroll that example's nav item into view in the side bar playcanvas/engine@fd6f7b4

Fixes

Filter out code editor warnings when validating browser edits of examples. Warnings were previously blocking rebuilds. playcanvas/engine@1f593a1
Fixes an issue where including extra functions in an Example class could break the example build playcanvas/engine@4ebe5e1 (#3310)
The code view panel was hidden on mobile for examples without controls. Fixed in: playcanvas/engine@1eb6fe8
The input of text in the filter text input no longer closes the side bar on mobile playcanvas/engine@c1b4904 (#3287)

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Some great changes!

why are you stripping anything other than spaces from the start?

I'm stripping the first 4 columns from the example function as it begins at column 4 in each examples .tsx file. When these functions are displayed in the browser editor they should start at column 0.

The fix will allow comments like this:

to appear as follows:


permanent bar on other file-types

Even when no haskell file is open (or near), a bar with the text "otherwise :: Bool" is showing.

Hint panel doesn't track currently active file, and it's unlikely to change for various reasons (I will accept a PR though). But if you have 'Hide Hint Panel if Empty' setting enabled (this is the default), you can hide the panel with autocomplete-haskell:conceal-hint-panel command (which is bound to escape by default, but that binding only works -- again, by default -- on Haskell files to avoid polluting global scope).
Alternatively, you can configure panel to not show at all and instead rely on ide-haskell-powered tooltips.

I need to hide it on start up every time.Anyway to disable the bar while enable the plugin?


[materialx] Add port MaterialX 1.38.4

Describe the pull request

What does your PR fix?

This PR adds a new port materialx

Which triplets are supported/not supported? Have you updated the CI baseline?

All, No

Does your PR follow the maintainer guide?

Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Committed patch has also been reproted upstream in AcademySoftwareFoundation/MaterialX#940

@JonLiu1993 everything should now be in order, let me know if we can proceed with the merge

Hi @JonLiu1993 , I have added one last commit as my upstream AcademySoftwareFoundation/MaterialX#940 PR was merged in the meantime and hence I do not need anymore to patch the port

I checked for problematic find_package calls:
documents/CMakeLists.txt has find_package(Doxygen), but that whole CMakeLists.txt is disabled by -DMATERIALX_BUILD_DOCS:BOOL=NO
There are several find_package(pybind11 QUIET) but I'm assuming -DMATERIALX_BUILD_PYTHON:BOOL=NO guards them.
Everything else has REQUIRED :D

Thanks for checking @BillyONeal !
Indeed I started with as few features as possible, and only then will try to gradually add them while also proposing changes upstream.
Keep an eye on my future PRs !


Window Close after await in Closing handler crashes on macOS

Describe the bug
https://github.com/Stannieman/AvaloniaMacOSClosingCrash/blob/main/MainWindow.cs
After the window is closed a crash happens (macOS shows a crash report, seems to be on native side). It only happens when the await is before the call to Close. I think it did not occur on Avalonia 10.
public MainWindow()
        {
            Closing += async (_, e) =>
            {
                if (canClose)
                {
                    return;
                }

                e.Cancel = true;

                // A particular MVVM framework calls an async CanCloseAsync function on the view model here.
                // This await causes a crash on macOS.
                await Task.Yield();

                canClose = true;
                Close();
            };
        }

Desktop (please complete the following information):

OS: macOS 13.5 on ARM
Version 11.0.2

I think your await continuation is called with dispatcher priority > input. Which means it can be executed during NSView::updateLayer call. Make sure to close the window from either an input event handler or with dispatcher priority <=Input

@kekekeks you are right! Something like this does not crash. Thanks!
public MainWindow()
        {
            Closing += (_, e) =>
            {
                if (canClose)
                {
                    return;
                }

                e.Cancel = true;

               _ = Dispatcher.UIThread.Invoke(() =>
               {
                    await Task.Yield();
                    canClose = true;
                    Close();
               }, DispatcherPriority.Input);
        }


Added boto3 to  requirements.txt

Description
In the case of using bedrock with litellm import boto3 exception is raised

Changelog Entry
Added

boto3 to  requirements.txt

LGTM, Thanks!


AOT - incorrect environment

OS?
OSX El Capitan
Versions.
angular-cli: 1.0.0-beta.17
node: 6.7.0
os: darwin x64
Repro steps.
-- create a new app with ng new
-- in src/app/app.module.ts
import { environment } from '../environments/environment';

-- then in the NgModule add
@NgModule({
  imports: [
    ...
  ],
  declarations: [
    ...
  ],
  providers: [{ provide: AppConfig, useValue: environment }],
  bootstrap: [AppComponent]
})
export class AppModule { }

-- run ng build --prod --aot
If you inject AppConfig into a component or service you will get the incorrect environment.
I am pretty sure aot is breaking the environment switching. when statically analyzing the app module aot pulls in the initial config if passing it to module. The only way I have managed to work around is to copy the file with a script before build.

for those needing a workaround you can use a script to copy the file to environment.ts BEFORE running build and aot. This is the one I use on my CI server.
echo "HACK!!!"
__dirname="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
cp $__dirname/src/environments/environment.$1.ts $__dirname/src/environments/environment.ts
echo "Copied environment.$2.ts"
`

I can confirm this behavior. It only occurs when building with the --aot flag.

I try this, with success !
export function env() {
    return environment;
}

@NgModule({
  imports: [
    ...
  ],
  declarations: [
    ...
  ],
  providers: [{ provide: AppConfig, useFactory: env }],
  bootstrap: [AppComponent]
})
export class AppModule { }

That is a much better workaround then what I was doing! Solid idea

Experiencing same behaviour, except that workaround only works if AppConfig is within the environment file. Conditionally adding config within other files will not work

Same issue here. The enableProdMode() method in the main.ts doesn't get called, because aot compiling only loads the default environment.ts file.

Same issue here. I try to get my firebase config from the environment, but i always receive the default environment file.

Like @a-legrand mentioned. A workaround right now is to useFactory instead of useValue

Also experiencing this issue, attempted to use a factory but for some reason the result of the factory wasn't being injected, instead the actual function was. I was most likely doing something wrong but this issue is still the root of it.

Just want to bump this. I added --aot to our prod environment and thus exposed our DEV database to the public. Thankfully there was no big harm this time, but this could potentially have some really serious implications!

@deebloo I'm having some trouble reproducing this. Can you provide me with a repo where this happens, or tell me what's the definition of AppConfig in your example?

@filipesilva ill create a small repo with the latest cli

@filipesilva https://github.com/deebloo/env-error

Fixed by https://github.com/angular/angular-cli/pull/4542

I just have the same issue here when using the ng2-admin 1.0.0 version
(https://github.com/akveo/ng2-admin/blob/master/package.json)
Could anyone help me on this? Thanks


test(otb): add gherkin tests

Hello @fchabrolle,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3


Enable both CTS and Optimizations for Caravel top-level

The current Caravel implementation doesn't allow any top level CTS. However, clock signals are buffered properly to avoid any SI issues.
Caravel has to be redesigned using different hierarchy to allow top level CTS, this might be tackled in the near future.


Implement Process page

Using the designs that @pamela-drouin worked on in #56

Hi @deathbearbrown - whenever you are able to implement this, let me know, and I'll help however I can.
I'm trying this design tool that I hope will be helpful for implementation (mockup): https://zpl.io/1M1CFz
Here's the link to zip file (assets): https://www.dropbox.com/s/5t7v9fli94dm3bk/ODK assets.zip?dl=0

@pamela-drouin can you invite me to your zeplin project.  Use my bocoup email

Sorry about that! Just invited you @deathbearbrown


Cache plugins which depend on internet results

Any plugin which relies on results from the internet (YouTube, Vimeo, Websites) should be cached for a few hours.

This doesn't seen necessary and will be decided on a per-plugin basis.


Add Codenet language classifier Model

Thanks @kmh4321 for working on this!
Tasks:

[x] create the model source repo on Github, with REST API and Dockerfile
[ ] build and push the Docker image
[ ] add the Model YAML to the katalog repo
[ ] add the Model to the Bootstrapper and Quickstart in the mlx repo
[ ] fix up the README (fill in place holders)

FYI @romeokienzler

Pushed to Dockerhub:
https://hub.docker.com/repository/docker/codait/codenet-language-classifier

Created PR for katalog repo and fixed the README.
@ckadner can you take care of step 4:  add the Model to the Bootstrapper and Quickstart in the mlx repo

All done. Thanks @kmh4321


[11.0 stable] Do not try to use invalid network config

Backport of https://github.com/lf-edge/eve/pull/3940 to 11.0

Note that I'm not going to backport this to 10.4. There are so many differences between 10 and 11 that I cannot just cherry-pick this commit but effectively would have to create it from the scratch. Given that this is not a very important fix/improvement, I believe that such effort is not worth it.


Completed / End of Questions Modal Animation.

Applying Animation when the last question is answered to show the result modal ( dialog ).
Some Ideas:

A pop up animation ( kinda default behavior ),
A  Flip Animation,
Combination of different animations.

i got this.

Hey bro you can mark this one complete, I've completed it already.


How can the remaining messages in claim.Messages() be consumed when using manual commit in a consumer group?

As the code show in #1987,
func (h *handler) ConsumeClaim(sess sarama.ConsumerGroupSession, claim sarama.ConsumerGroupClaim) error {
	i := 0
	for m := range claim.Messages() {
		msg := m.Value
		if err := h.f(context.Background(), msg); err != nil {
			// noop
		} else {
			sess.MarkMessage(m, "")
			i++
			if i%dfv1.CommitN == 0 {
				sess.Commit()
			}
		}
	}
	return nil
}

If the producer sends 8 messages and then the consumer pulls 8 messages, and if dfv1.CommitN=3, that means the remaining 2 messages will not be committed until another message is pulled
If I restart the consumer client, the remaining 2 messages will be consumed again, even though they have been marked but not committed.
Is there a good way to avoid consuming the 2 messages again?

Other, When I use kafka-producer-perf-test.sh to mock the producer to send 10000 message to the topic t, which have 2 partitions, and use the consumer code as above, and set dfv1.CommitN=3, I found the case that when consume the message 9748, the sess.Commit() is too slow, which reach to 500ms~1004ms, however, when consume the message from 1~9747,  the cost time of sess.Commit() about 1~3ms.


Can not update another provider state inside FutureProvider

Describe the bug
In riverpod 1.0.0-dev.5 I was able to modify a provider state inside a FutureProvider but in versión 1.0.0-dev.7 the following error is been thrown: Providers are not allowed to modify other providers during their initialization
To Reproduce
final futureProvider =
    FutureProvider.autoDispose<void>((AutoDisposeProviderRef ref) async {
    UiProvider _uiProvider = ref.watch(uiProvider.notifier);

  _uiProvider.showGlobalLoader(); --> This modifies state
  await asyncTask();
});

Expected behavior
Before triggering an async task I would like update the state of another provider.

As per the error message, this is expected.
You shouldn't modify providers like that, and should update your code to use a different solution.


minor doc fixes for admin resource

It is looking for get() not list().
Add in return types.
Fix access for class, I got an error trying to use a class with package level access.

It might also be useful to clarify what restrictions
are present on the return types. For example, should
listChild always return a Collection?

NetflixOSS » karyon » karyon-pull-requests #92 FAILURE
Looks like there's a problem with this pull request


faster_decoding=1 or faster_decoding=2 has extremely bad size with lossless images.

Describe the bug
faster_decoding 1 and 2 when encoding with lossless results in extremely large file sizes. faster_decoding 3 and 4 do not
To Reproduce
cjxl img-in.png img-out.jxl -d 0 -e 7 --faster_decoding=1 or cjxl img-in.jpeg img.jxl -d 0 -e 7 --lossless_jpeg=0 --faster_decoding=1
Expected behavior
Create reasonably sized files
Screenshots
Not Applicable
Environment

OS: Arch Linux
Compiler version: Unkown
CPU type: x86_64
cjxl/djxl version string: cjxl v0.10.2 e1489592 [AVX2,SSE4,SSE2]

Additional context
The issue does not occur when doing lossless-transcoding or during normally lossy transcoding cjxl mona.png mona-f1.jxl -d 0.1 -e 5 --faster_decoding=1 (though the overall hit is very large still)
results of lossless compression
➜  jxl-debug l mona*
Permissions Size User  Date Modified Name
.rw-r--r--   17M quack 25 Apr 13:13  mona-f0.jxl
.rw-r--r--  100M quack 25 Apr 13:14  mona-f1.jxl
.rw-r--r--  100M quack 25 Apr 13:15  mona-f2.jxl
.rw-r--r--   26M quack 25 Apr 13:16  mona-f3.jxl
.rw-r--r--   26M quack 25 Apr 13:16  mona-f4.jxl
.rw-r--r--   27M quack 25 Apr 13:13  mona.png

➜  jxl-debug l wind*
Permissions Size User  Date Modified Name
.rw-r--r--   51M quack 25 Apr 13:17  windwaker-0.jxl
.rw-r--r--  533M quack 25 Apr 13:18  windwaker-1.jxl
.rw-r--r--  533M quack 25 Apr 13:19  windwaker-2.jxl
.rw-r--r--   90M quack 25 Apr 13:20  windwaker-3.jxl
.rw-r--r--   90M quack 25 Apr 13:21  windwaker-4.jxl
.rw-r--r--   23M quack 25 Apr 13:17  windwaker35xnative.jpg

results of lossy compression
➜  jxl-debug l
Permissions Size User  Date Modified Name
.rw-r--r--  4.2M quack 25 Apr 13:27  mona-f0.jxl
.rw-r--r--   26M quack 25 Apr 13:27  mona-f1.jxl
.rw-r--r--   26M quack 25 Apr 13:27  mona-f4.jxl
.rw-r--r--   27M quack 25 Apr 13:13  mona.png

I'd say we need to fix this before the 1.0 release, if needed by making faster_decoding > 0 do the same as fd0.


cmd/stringer: can't find packages

I'm having a problem using stringer with go generate.  It reports errors because it can't find packages that I think it should be able to find.  go build has no trouble finding them.
a.go, in directory $GOPATH/src/a:
package a
import "a/b"
type A int
const (
Aone   A = 1
Atwo     = 2
Athree   = 3
)
//go:generate stringer -type=A
func a() {
b.B()
}
b.go, in directory $GOPATH/src/a/b:
package b
func B() {
}
In $GOPATH/src/a, this happens:

go generate
stringer: checking package: a.go:3:8: could not import a/b (can't find import: a/b)
a.go:13: running "stringer": exit status 1

Running go build instead of go generate works fine.

Have you tried "go install a/b" before running stringer?

Ok, that works.  Why?

Stringer packages to be installed so it can parse and type check the files it's reading.

Ok, that works. Why?

stringer uses go/types, which uses go/loader to find packages. There are multiple strategies for finding packages available. Stringer uses gcimporter, which parses gc's object files. If the package has not been installed, the object files are not available to parse.

So this should be documented somewhere, perhaps at https://godoc.org/golang.org/x/tools/cmd/stringer
Confused the hell out of me.

It's not a property of stringer per se. You can't build or parse (actually type check) a package without building (or parsing) its dependencies first. Any tool that looks at types has the same property.
It's the nature of the work.

So shouldn't stringer build its dependencies if they haven't been built yet?  Or at least parse them if it can't find a built object file?  Or give me a better error message than "could not import a/b (can't find import: a/b)", like "could not import a/b (it must be built first)"?

@randall77 I agree entirely, but this is a broader problem than just stringer. Filed #10276 for this.

For the record:
This CL https://go-review.googlesource.com/#/c/8561/ changes stringer to use go/loader, which loads the entire program from source code, so it gets the correct result no matter what compiler you use or how fresh your .a cache is.  The change has been mothballed pending a clean-up of the go/loader API (some of which has already happened).

What's the status on this? Will this not be implemented, or will this be addressed somewhere else?

for the record, i'm still getting can't find import for installed pacakges when using fatih/vim-go

Don't hold your breath: it will likely be several months before go/loader is stable enough to have its API frozen, and this is why CL 8561 was rejected.
I agree that using compiler export data is rarely the right solution for analysis tools; source is the ground truth (and provides better diagnostic information such as locations for types and functions).  The set of installed packages is usually very stale.

@alandonovan where can I find the blocking go/loader issue(s)?  I tried searching this tracker but couldn't find anything open that appears relevant.

@pdf: https://github.com/golang/go/issues/14120

I know this problem isn't specific to stringer, but I just spent ages trying to track it down before realizing that it's using go/types and things have to be installed; I came here to file an issue about documentation and found this issue. Even though the problem isn't specific to stringer, lots of people will be using stringer that might be confused by this issue, so I still think that it's worth documenting in the mean time, or at least mentioning it in the error message ("Can't find package , did you go install it?")

@alandonovan

Don't hold your breath: it will likely be several months before go/loader is stable enough to have its API frozen, and this is why CL 8561 was rejected.

Is there a reason the API needs to be frozen before any other package under godoc.org/golang.org/x/tools depends on it? Or is this a preference, based on the quite understandable desire to avoid having to refactor N other packages with every changes to loader?
I understand that for go vet loader needs to have moved to the Go repo, but for stringer we could probably make the change now?

Since they live in the same repo (x/tools), having stringer depend on go/loader would add little to the maintenance burden, but in https://go-review.googlesource.com/#/c/8561/ Rob said he'd prefer to wait until go/loader is tidied up, by which he likely means the changes described here:
https://docs.google.com/document/d/1IIjEhq54T5KZHTdSyquMhaQ58htYclQpFEX4WRVOhJw
Unfortunately I have not yet found the time to get the API into a state that I would be happy to freeze forever.

Since they live in the same repo (x/tools), having stringer depend on go/loader would add little to the maintenance burden

Indeed; I more made the comment in the context of...

Unfortunately I have not yet found the time to get the API into a state that I would be happy to freeze forever.

... you having plenty of other things to do!
Thanks for clarifying.

Reopening because the fixing CL was reverted.

Reverting that CL just broke any code that assumed stringer was safe to run without running go install -i first. And that was a valid assumption to make for the last twelve months. I realize it was slow (in fact I raised that very issue on the mailing list in May: https://groups.google.com/forum/#!topic/golang-dev/NL1zE4Sesg0), but better slow and correct than fast and subtly broken.
I realize that x/tools is not subject to the standard compatibility promise, but we'd lived with slow stringer for a year. Couldn't we have waited a few more months for go/packages to land? Or put the fast-but-broken importer behind a flag, like -importer=gc? It's one thing for code to be broken, but it's another thing entirely to fix it, then break it again.
And when I say "broken," I understand that it's working as designed. I mean that it has a very hostile design. Running go build -i PKG beforehand isn't even a workable solution, since that often tries to install to an unwriteable GOROOT.

I doubt that go/packages will fix it, since I presume it too will require a complete type-checkable package before stringer will run.

Can we not simply loosen the requirement that the target fully type checks? e.g.:
https://go-review.googlesource.com/c/tools/+/122377
That way we can leverage the constant evaluation code etc in go/types.
Same approach could be followed with go/packages (which would also solve the "speed" problem as well as imports being current), although the configuration/usage would likely be a bit different.
The above CL allows the following to generate successfully:
package main

//go:generate stringer -type Banana

type Banana uint

const (
        B1 Banana = iota
)

var x Apple

func main() {
}

whereas with the current stringer it fails:
stringer: checking package: main.go:11:7: undeclared name: Apple
main.go:3: running "stringer": exit status 1

I doubt that go/packages will fix it, since I presume it too will require
a complete type-checkable package before stringer will run.

go/packages is intended to be robust to metadata, syntax, and type errors
in any given package and to record them in the returned Package.  There are
undoubtedly bugs bug they should be fixable.
BTW, I measured the speed of go/packages doing the operation needed by the
frustratingly slow 4s run of stringer discussed in another issue---I forget
the package bit it was gopkg.in/something---and it took under 300ms, so it
should be fast enough even though it does some type-checking.
On 6 July 2018 at 04:21, Paul Jolly<EMAIL_ADDRESS>wrote:

I doubt that go/packages https://goto.google.com/packages will fix it,
since I presume it too will require a complete type-checkable package
before stringer will run.
Can we not simply loosen the requirement that the target fully type
checks? e.g.:
https://go-review.googlesource.com/c/tools/+/122377
That way we can leverage the constant evaluation code etc in go/types
https://goto.google.com/types.
Same approach could be followed with go/packages
https://goto.google.com/packages (which would also solve the "speed"
problem as well as imports being current), although the configuration/usage
would likely be a bit different.
The above CL allows the following to generate successfully:
package main
//go:generate stringer -type Banana
type Banana uint
const (
B1 Banana = iota
)
var x Apple
func main() {
}
whereas with the current stringer it fails:
stringer: checking package: main.go:11:7: undeclared name: Apple
main.go:3: running "stringer": exit status 1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/10249#issuecomment-402962860, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AICt9EWC7vZ7cZKOrSQDyzG-6WH5vweKks5uDx3ygaJpZM4D01Ue
.

"Reverting that CL just broke any code that assumed stringer was safe to run without running go install -i first. " No it didn't, only some code, while not reverting it broke mine.

No, it subtly broke all code and workflows that do not involve running some equivalent of go install -i.
If I have a file in package github.com/benesch/stringertest/b like this
package b

type Garbage int

const (
  FooGarbage Garbage = iota
  BarGarbage
)

I can run stringer -type=Garbage ./b successfully. But as soon as I introduce a dependency on a new package, I run the risk of using outdated type information. Suppose I apply this diff:
diff --git a/b/b.go b/b/b.go
index ebfda0e..3c9bcb7 100644
--- a/b/b.go
+++ b/b/b.go
@@ -1,8 +1,11 @@
 package b

+import "github.com/benesch/stringertest/a"
+
 type Garbage int

 const (
   FooGarbage Garbage = iota
   BarGarbage
+  BazGarbage = a.Sym
 )

Now stringer fails because github.com/benesch/stringertest/a is not installed:
$ stringer -type=Garbage
stringer: checking package: b.go:3:8: could not import github.com/benesch/stringertest/a (can't find import: "github.com/benesch/stringertest/a")

There are two ways to resolve this. I can run go install on every dependency of b (in this case, just go install ./a), or I can run go install -i ./b and let the Go toolchain sort out the dependency graph. The latter option is the only reasonable option when a package has hundreds of transitive dependencies and any one of them may have changed.
This was not a problem when stringer used the source importer. Here, github.com/benesch/stringertest/a is not installed, and source-importer stringer succeeds:
$ (cd $GOPATH/src/golang.org/x/tools && git checkout ffe8890^ && go install ./cmd/stringer)
$ stringer -type=Garbage
# success

The situation is unfortunately very messy. I for one have never run go install -i, not once.

Yes, which is why you ran into the "could not import" error when trying to use stringer: https://github.com/golang/go/issues/25650#issuecomment-394513354

I thought the resolution would be to go back to the beginning and roll out as much as possible of the dependence on types. Evaluation of constants would then require avoiding type checking and adding its own evaluator. I haven't done that yet; one reason is that in general one might have to look at another package to do that, for cases like const A = pkg.C, and doing that requires importing again. Back to square one.

There are two orthogonal issues that are being conflated in this discussion. The first issue is how stringer loads a package's dependencies. The second is what sort of type checking stringer performs, if any.
I don't see why the first issue has any bearing on the second. Your change to pass IgnoreFuncBodies to the type checker is equally effective with the source importer as it is with the gc importer. Ditto for the CL @myitcv has proposed to ignore errors from the type-checker.

With great reluctance, I will roll back my changes and pray that Alan Donovan's work will fix this, if only to shut down this conversation.
I do believe there is a deep problem here that only I am worried about, but then if it's only me that worries about it, I guess it doesn't matter much.

With great reluctance, I will roll back my changes and pray that Alan Donovan's work will fix this, if only to shut down this conversation.

Thanks. It's appreciated.

I do believe there is a deep problem here that only I am worried about, but then if it's only me that worries about it, I guess it doesn't matter much.

I'm also worried about this problem now that you've raised it, so that makes at least two of us. As I've mentioned elsewhere, I think https://go-review.googlesource.com/c/121995/ is a step in the right direction and I hope you'll resubmit it.


Add Atlas init action

Thanks @DariuszAniszewski contributing to this init action. Upgraded with Atlas 1.2. This init action now should be used together with Dataproc 1.5+

d any issues), please reply here with

@googlebot I signed it!

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

Closing in favor of original https://github.com/GoogleCloudDataproc/initialization-actions/pull/478 PR