Full upgrade run december 2024, v1.10.40-preview

ℹ
As suggested in issue #1009 I've opened a new one with the latest feedback.
Pictures tell a thousand words, so let me include those where possible.
Note: My PC was already pending a reboot for Windows Updates, not sure if that has had any effect during this process.
Starting off situation:

⏳
Running command as user without elevated permissions:
winget update --all --accept-package-agreements --accept-source-agreements --silent --verbose-logs
⚠
Even though it first tells me there are 58 upgrades available, it then only processes 53:

✅
These apps prompted for elevation after winget showed The installer will request to run as administrator, expect a prompt.

RSI launcher [RSI Launcher [CloudImperiumGames.RSILauncher]]
Android Studio [Google.AndroidStudio]
Git [Git.Git]
HWiNFO® [REALiX.HWiNFO]
Notepad++ [Notepad++.Notepad++]
WinMerge [WinMerge.WinMerge]
GitHub CLI [GitHub.cli]
NVIDIA GeForce Experrience [Nvidia.GeForceExperience]
Visual Studio Community 2022

⚠
These apps did not show a prompt in Winget, but did request elevation from the installer:

Docker Desktop [Docker.DockerDesktop]
Speccy [Piriform.Speccy]
Total Commander [Ghisler.TotalCommander]
VLC [VideoLAN.VLC]
WinRAR [RARLab.WinRAR]
Winaero Tweaker [winaero.tweaker]
Obsidian [Obsidian.Obsidian]
qFlipper [FlipperDevicesInc.qFlipper]
OpenShot Video Editor [OpenShot.OpenShot]
MySQL Workbench 8.0 CE [Oracle.MySQLWorkbench]
blender [BlenderFoundation.Blender]
NVIDIA CUDA Toolkit [Nvidia.CUDA]
Elgato Stream Deck [Elgato.StreamDeck]
GNU Privacy Guard [GnuPG.GnuPG]
Gpg4win [GnuPG.Gpg4win]
OBS Studio [OBSProject.OBSStudio]
Ubisoft Connect [Ubisoft.Connect]
Wireshark [WiresharkFoundation.Wireshark]
mIRC [mIRC.mIRC]
WinSCP [WinSCP.WinSCP]
PowerToys [Microsoft.PowerToys]
Microsoft Visual C++ 2015-2022 Redistributable (x64) [Microsoft.VCRedist.2015+.x64]
Epic Games Launcher [EpicGames.EpicGamesLauncher]
Power Automate for desktop [Microsoft.PowerAutomateDesktop]
Progress Telerik Fiddler Classic [Telerik.Fiddler.Classic]
Prism Launcher [PrismLauncher.PrismLauncher] (for the required redist dependency)

❌⛔
HWiNFO installer failed, even though I never did anything to cancel the installation

WinGet-REALiX.HWiNFO.8.16-2024-12-11-08-30-28.517.log
MongoDB [MongoDB.Server] failed to install, error 1603. There is no separate log file for this installer.

Java 8 failed, did not prompt for elevation, error 1603. There is no separate log file for this installer.

Blender showed multiple command prompts flashing, too fast too see if there was any text om them or to grab a screenshot.
Then it promped for elevation.
OBS Studio did prompt for elevation but failed anyway, exit code 6. There is no separate log file for this installer.
Despite the error message, I can confirm that OBS was already closed and my webcam was not in use.

Epic Games Launcher did prompt for elevation but failed anyway, error 1603.
WinGet-EpicGames.EpicGamesLauncher.<IP_ADDRESS>-2024-12-11-12-11-18.749.log

LM Studio failed to install, 0x801900ce. There is no separate log file for this installer.

Spotify failed to install because it is running.
WinGet-Spotify.Spotify.<IP_ADDRESS>2.g01893f92-2024-12-11-12-21-11.227.log

ATLauncher Setup failed to install, did not prompt for elevation.
WinGet-ATLauncher.ATLauncher.<IP_ADDRESS>-2024-12-11-12-23-09.324.log

Windows Subsystem for Linux failed to install, did not prompt for elevation.

⚠ After winget update --all, the following result is shown running winget update:

⚠ After the winget update --all command finished, the following results were shown:
375 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.
2 package(s) are pinned and need to be explicitly upgraded.
Both before and after winget update --all, the winget update command shows the following:
3 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.
Somehow two different numbers are shown, despire them appearing to tell the same thing to the user.
Running winget update --include-unknown only shows three packages:

⏳Running command as with elevated permissions:
winget update --all --accept-package-agreements --accept-source-agreements --silent --verbose-logs
⚠Out of the 18 (not including unknown) packages, only 12 packages are being attempted for an update

HWiNFO® fails to install:
WinGet-REALiX.HWiNFO.8.16-2024-12-11-12-33-06.044.log

OBS failed to install, there is no separate log file for this installer.

Epic Games Launcher failed to install:
WinGet-EpicGames.EpicGamesLauncher.<IP_ADDRESS>-2024-12-11-12-37-45.039.log

LM Studio fails to download:

ATLauncher Setup failed to install:
WinGet-ATLauncher.ATLauncher.<IP_ADDRESS>-2024-12-11-12-40-15.458.log

⚠ And again it reports a different number of packages for which the version number cannot be determined.

ℹ Attached the DiagOutputDir completely as well:
WinGet_DiagOutputDir.zip

Thanks, I've added a new label "Issue-Feedback" and since this will serve as a master to track other issues, I've marked it as a "Task" for the Issue Type. I'll add any existing issues to this comment and update this is the first "human" comment to help track. I'd also love some help from @Trenly and @mdanish-kh via Gitter or Teams to keep some of the discussion clutter reduced here.

The list of packages that triggered an elevation request might need updates in their manifest if they always prompt for elevation, but they may also be installed "per user" which shouldn't need elevation. @Trenly & @mdanish-kh. Those seem like a decent selection of packages to evaluate for manifest updates.
Docker Desktop [Docker.DockerDesktop]
Speccy [Piriform.Speccy]
Total Commander [Ghisler.TotalCommander]
VLC [VideoLAN.VLC]
WinRAR [RARLab.WinRAR]
Winaero Tweaker [winaero.tweaker]
Obsidian [Obsidian.Obsidian]
qFlipper [FlipperDevicesInc.qFlipper]
OpenShot Video Editor [OpenShot.OpenShot]
MySQL Workbench 8.0 CE [Oracle.MySQLWorkbench]
blender [BlenderFoundation.Blender]
NVIDIA CUDA Toolkit [Nvidia.CUDA]
Elgato Stream Deck [Elgato.StreamDeck]
GNU Privacy Guard [GnuPG.GnuPG]
Gpg4win [GnuPG.Gpg4win]
OBS Studio [OBSProject.OBSStudio]
Ubisoft Connect [Ubisoft.Connect]
Wireshark [WiresharkFoundation.Wireshark]
mIRC [mIRC.mIRC]
WinSCP [WinSCP.WinSCP]
PowerToys [Microsoft.PowerToys]
Microsoft Visual C++ 2015-2022 Redistributable (x64) [Microsoft.VCRedist.2015+.x64]
Epic Games Launcher [EpicGames.EpicGamesLauncher]
Power Automate for desktop [Microsoft.PowerAutomateDesktop]
Progress Telerik Fiddler Classic [Telerik.Fiddler.Classic]
Prism Launcher [PrismLauncher.PrismLauncher] (for the required redist dependency)

OBS Studio is actually behaving (mostly) as expected. There are applications like Teams, Chrome, and a few others that will continue to use OBS files even if OBS is closed and the camera is not in use.
Spotify is the same way, and WinGet will not close a running application to ensure user data is preserved

The number of unknown packages is also a known bug; I'll have to find the issue number, but the gist of it is that the count of packages with unknown version is happening before the check to see if packages are available from a known source.

Definitely agree with @denelon that the manifests for many of the packages mentioned should be checked for an elevation requirement

The issue of packages listed for update but not actually being updated by the command is another known issue, but probably needs more focus (@denelon - once I find the number can you look at priority?); Effectively, when using --all specific output messages explaining inapplicability will be skipped (e.g - installer type mismatch, system doesn’t support the new installer, architecture not found, etc)


Deploy the web app

[ ] Deploy using vercel
[ ] Update readme.md with deployment info

Deployed using Cloudflare


Instantiating new Objects within a Rule

Attempting to perform the following rule, if true, instantiates the correct object type for the RateCalculationEngine.  If this valid?  Can new objects be instantiated within MVEL or a Rule?
Thanks,
Jeff
Example Code:
.
.
.
// Other Facts sets...
...
// Add a Resultant Fact
RateCalculationEngine rce = null;
facts.put("rce", rce);
   MVELRule aRule_XY = new MVELRule()
            .name("rate engine - XY")
            .description("Inject the proper Rate Calculation Engine Implementation")
            .priority(1)
            .when("quote.isXYQuote()")
            .then("rce = new com.x.y.z.a.b.XYPPACAExcelRateCalculationEngineImpl();");

    Rules rules = new Rules();
    rules.register(aRule_XY);

    //create a default rules engine and fire rules on known facts
    RulesEngine rulesEngine = new DefaultRulesEngine();

    // Process Rules against supplied Facts
    Map<Rule,Boolean> x = rulesEngine.check(rules, facts);  **// Shows one rule as True!**

    // Process Rules against supplied Facts
    rulesEngine.fire(rules, facts);

   return rce;   **// Always Null!**

}

I believe I have found my solution where I was not getting the result mutated rce object.
After simply modifying the return to return facts.get("rce");   Appears to have solved my issue.
Many thanks,
Jeff


bug: add missing helpers import

Field
Description

Plugin
neotest

Nixpkgs
unstable

Home Manager
unstable

[x] I have read the FAQ and my bug is not listed there.

Description
When attempting to build this configuration snippet:
{ config, lib, pkgs, ... }: {
  config = {

    programs.nixvim.plugins.neotest = {
      enable = true;

      adapters = {
        rspec = {
          enable = true;
          settings = {
            root_files = [ "README.md" "flake.lock" "flake.nix" "README.mkd" ];
          };
        };
      };
    };
  };
}

I had an error:
error:
       … while calling the 'head' builtin

         at /nix/store/j8pbrsb3nybdap3hhg9kw0ffqd4rlbx6-source/lib/attrsets.nix:1575:11:

         1574|         || pred here (elemAt values 1) (head values) then
         1575|           head values
             |           ^
         1576|         else

       … while evaluating the attribute 'value'

         at /nix/store/j8pbrsb3nybdap3hhg9kw0ffqd4rlbx6-source/lib/modules.nix:821:9:

          820|     in warnDeprecation opt //
          821|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          822|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: undefined variable 'toLuaObject'

       at /nix/store/lmpwiwcimdgz2083glllhyf22rvqzfi8-source/plugins/neotest/adapters.nix:49:86:

           48|             let
           49|               settingsString = optionalString (cfg.settings != { }) (settingsSuffix (toLuaObject cfg.settings));
             |

Upon investigating, I saw that plugins/neotest/adapters.nix had a bare toLuaObject call, and did not import the helpers module like many other locations. I forked, made the change to import helpers, which resolved the issue.
The checks would not complete on my machine (pinned CPUs and did not return after 20m, I suspect this issue is local to me), but the format-on-commit seems to have taken so the change reflects that.

I'm not sure what you mean by 'add it to the inherit'; I added it to the inherit line in the file, but the issue simply recurs when applying your suggested changes. Same error as before (undefined object). There is already an inherit for lib.nixvim in the inherit line:
inherit (lib.nixvim) ...

That's where I attempted to add the helpers inherit. I believe I have reached the limits of my nix-fu here.

I'm not sure what you mean by 'add it to the inherit'; I added it to the inherit line in the file, but the issue simply recurs when applying your suggested changes. Same error as before (undefined object). There is already an inherit for lib.nixvim in the inherit line:
inherit (lib.nixvim) ...

That's where I attempted to add the helpers inherit. I believe I have reached the limits of my nix-fu here.

  inherit (lib.nixvim) mkPluginPackageOption mkSettingsOption toLuaObject;

Oh, brill, two shakes.

@mergifyio queue


JsiConsoleDecorator EXC_BAD_ACCESS

Hey @chrfalch, awesome work!
I get the following error when using rn-worklets in my custom JSI module:
com.facebook.react.JavaScript (15): EXC_BAD_ACCESS (code=1, address=0xb0c654aab240)

Error above points to a .global method being inaccessible here, for which wrapping with a check fixes the problem:
https://github.com/chrfalch/react-native-worklets/blob/d62d76c20ed7a3bbfebe5623bc976e5c2d9beabd/cpp/decorators/WKTJsiConsoleDecorator.h#L135
Here is a simplified usage snippet:
#include <thread>
#import "WKTJsiWorkletContext.h"
#import "WKTJsiWorklet.h"

void setup(Runtime &jsRuntime, shared_ptr<CallInvoker> jsCallInvoker) {
  auto workletContext = std::make_shared<RNWorklet::JsiWorkletContext>("MyLibrary");
  auto runOnJS = [jsCallInvoker](std::function<void()>&& f) {};
  auto runOnWorklet = [](std::function<void()>&& f) {};
  workletContext = std::make_shared<RNWorklet::JsiWorkletContext>("MyLibrary");
  workletContext->invokeOnWorkletThread([=](RNWorklet::JsiWorkletContext*, Runtime &rt) {});
}

Thanks!

I just noticed that I missed context initialization in the snippet above. Adding that builds successfully but hangs the application, preventing it to start:

workletContext->initialize("MyLibrary", jsRuntime, runOnJS, runOnWorklet);

Hi @azimgd - sorry for the delay and thanks for the nice words! Are you able to run with RN Worklets now? If so maybe we can close this issue.

Hey Christian. I still have these errors mentioned above.

Could you try to create a very small reproduction project on Github and share with me and I'll take a look?

here you go: https://github.com/azimgd/workletissue/blob/main/cpp/react-native-workletissue.cpp
Thanks!

Hi, I've experienced both issues here (hang and BAD_ACCESS). What did you do to fix it?


Governance clarifications

Signed-off-by: Justin Cappos<EMAIL_ADDRESS>Please fill in the fields below to submit a pull request.  The more information
that is provided, the better.
Fixes issue #:
Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

This is a docs only PR. No need to wait for the tests.


Does responsive plugin work as it should in React SDK?

For which package is this issue?
React
Describe the issue in a sentence or two.
Using the responsive plugin, the original image also loads, making the plugin redundant. I'm not sure if I've completely missed the point of a responsive plugin, but it seems like it's not working like it should. If I have a massive image that I want to load on a small screen, the responsive plugin should only load an image that is sized to fit on the small screen, but what's happening is the massive image gets loaded then a responsive one loads after that. So not only does not save any bandwidth, it actually increases it! Additionally, what is the point of continually loading smaller images if the screen size gets smaller? Surely it would make more sense to only load new images if the screen size increases? Again, seems like a complete waste of bandwidth and defeats the point of having this plugin. I can only assume this is a bug.
Issue Type (Can be multiple)
[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Incorrect Types
[ ] Other (Specify)
Steps to reproduce
Use the following as taken from the docs:
const cloudinaryImage = new CloudinaryImage("sample", { cloudName: "demo" });

<AdvancedImage cldImg={cloudinaryImage} plugins={[responsive()]} />

Observe two image downloads in the network panel, one full size and one responsive.
Error screenshots
Browsers (if issue relates to UI, else ignore)
[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Other (Specify)
[ ] All
Versions and Libraries (fill in the version numbers)
Node - 0.0.0
NPM - 0.0.0
Config Files (Please paste the following files if possible)
"@cloudinary/react": "^1.4.1",
"@cloudinary/url-gen": "^1.8.0",

Alex if you add steps as a parameter to the responsive plugin do you still have the same issues?
Here is a sandbox to reference:
https://codesandbox.io/s/fragrant-cdn-trr63y?file=/src/App.js

+1 on this, we are seeing the same issues @alexstanbury mentions regarding (1) initially loading the full size image and (2) redundantly loading smaller and smaller images as the screen size decreases

@harry-gocity did you see my previous response? Can you reproduce your issue via sandbox?
Thanks!

@PixelCook https://codesandbox.io/s/gifted-pasteur-5gft59?file=/src/App.js
https://github.com/cloudinary/frontend-frameworks/assets/111427669/11996486-e34d-4b65-8cd0-9fcefd6ecdd5

HI there,
It does seem like an issue; I'm consulting with our SDK team and respond as soon as I have insights to share.
Thanks,

Hi there,
The issue was identified as a bug. We are working on fixing the issue.
We will keep you posted once ready.
Regards,
Wissam


iOS framework tutorial

Please make sure that this is a build/installation issue and also refer to the troubleshooting documentation before raising any issues.
Describe the problem:
I am wondering how to use the iOS framework, since you have provided the solution but without documents.
v0.8.11
We have made the build targets //mediapipe/objc:mediapipe_framework_ios, //mediapipe/objc:mediapipe_input_sources_ios, //mediapipe/objc:mediapipe_layer_renderer publicly visible. These targets can now be used in external iOS applications.

Hello @fchen09 We suggest going through the Hello World on iOS document page. It provides a thorough understanding of what logic is being used to build graph and camera feed.


Top Talkers: showing IPs outside of interface network

Top talkers tab currently seems to filter on interface, but not on clients for that interface.
the function is great, and i am very aware this is a young feature that will be improved greatly over time, as we have seen with every part of opnsense, but that being said i would like to remark this:
Say we have WAN and LAN, and decide we only want the top talkers on the LAN.
currently we get:
LAN - LAN IP - IN/OUT stats
LAN - WAN IP - IN/OUT stats
like so:

i am assuming this is because currently it filters on interface, not filtering out IPs that do not actually belong to that interface.
as witnessed in 2 topics on the forums*, this confuses people (at first, me as well), because you would expect the top talker belonging TO the filtered network to be shown, not the places it is talking to.
with a few devices on the network, and the auto-refresh which cannot be paused, it also becomes fairly difficult to use fairly fast.
so i suggest filtering out the top talkers from a specific interface if they do not actually belong to that interface, so you can have a quick overview of which client on your network is causing a problem, and leaving the detailed analysis of the streams at the insights detail page.

https://forum.opnsense.org/index.php?topic=21190.0 and https://forum.opnsense.org/index.php?topic=21513

@thutex Looking at this again, I'm not 100% sure I've interpreted the iftop output correctly, so the question is if the stats are correct on the network in question. If you look at the numbers in/out, do they match up?
On a side note, usually we'll mark free-form tickets incomplete, could you be so kind using our templates next time?

Sorry about not using the template, i started off with the template but had trouble explaining the issue within the template boundaries.
currently the output from the command '/usr/local/sbin/iftop', '-nNb', '-i', interface, '-s', '2', '-t' is this:

1 <IP_ADDRESS>                                 =>     5.17Kb     5.17Kb     5.17Kb     1.29KB
<IP_ADDRESS>                               <=     2.98Kb     2.98Kb     2.98Kb       764B
2 179.60.195.x                            =>       568b       568b       568b       142B
<IP_ADDRESS>                               <=       540b       540b       540b       135B

and it seems right now each line is shown as an individual talker on the selected interface,
while we should only show the second line as that is the actual talker on the interface.
so <IP_ADDRESS> and 179.60.195.x in this case should not be shown.
on top of that, the above should probably combine the 2 lines, since both are from <IP_ADDRESS>,
and then combine the stats to get the actual in/out from that ip (so we don't risk 100 lines from 1 host, which would make top talkers useless for diagnostics).
but i have no clue as to how we can best do this... maybe jnettop -if available- could be a better alternative?
something like  '/usr/local/sbin/jnettop', '-i', interface, '--local-aggr port --remote-aggr port --display text -t 5 --format src$,$dst$,$proto$,$srcbps$,$dstbps$,$totalbps$'' would give us

<IP_ADDRESS>,<IP_ADDRESS>,TCP,42,44,86
<IP_ADDRESS>,<IP_ADDRESS>,TCP,35,35,70

which is a much more flexible output? (but it would mean another extra package, since jnettop is not installed or available by default)

@thutex no worries, let's see how we can improve this. I rather stay at iftop at the moment, we do need to aggregate in any case. Maybe if I spotted jnettop earlier we might have used that one, the output looks a bit more practical indeed.
When I looked at the output again yesterday I also came to the same conclusion, we should aggregate on the second entry, which is the actual talker. Let me try to prepare a patch for this.

@thutex can you try https://github.com/opnsense/core/commit/13c4f8eab6cefd8174f1079981035c0697f3932f?
We should probably also change the api output and gui so we don't have to push in/out separately as we do now, but I first just want to check if we can reach the proper output, which is what this commit should already do.

@AdSchellevis just applied it.
I will keep an eye on it to see if anything seems off, but at first look it seems to be exactly what you'd expect!


Infinite loop during error report

Hi, we recently faced an infinite loop caused by an error thrown while updating php files. This caused the same error to be logged thousands of times in sentry. Unfortunately it was hard to find the exact steps to reproduce for us, but we found a bug report on the symfony repo with more people with similar issues, including a possible explanation for the bug. Please see the thread here:
https://github.com/symfony/symfony/issues/26438

This may also be related to https://github.com/getsentry/sentry-php/issues/552.
I'm currently investigating this, thanks for the pointer!

https://github.com/symfony/symfony/pull/26568 fixes this issue. If you need to use it immediately, without waiting for the release, you can use my fork, that contains Symfony 3.4.6 + the cherry-picked fix.
To use the fork, you have to add to your composer.json this:
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/jean85/symfony"
        }
    ],

and the change the requirement for the Symfony package like this:
    "require": {
        "symfony/symfony": "dev-3-4-6-fatal-handler-fix as 3.4.6",
    }

Unfortunately, this fix enables a small hindrance: each fatal error is reported twice to Sentry, once as an Error, the second time as a Symfony's FatalThrowableError. I will try to solve this with a patch on my side, in the bundle.

Yes! The referenced PRs has been included in the following Symfony releases:

2.7.44
2.8.37
3.4.7
4.0.7

Please update if you're experiencing this bug!


don't return err if block already in db. overwrite it

I don't see where in the code we treat that error. until now we've treated it like we've failed to add the block which is wrong. I also don't see a reason why this is not the place. we can return a special error and start propagating it upwards so we can treat it but currently, I don't see any use case in our code which requires that feature. Also all the unit tests have passed without changing anything so I don't see a reason why we need that.

We shouldn't ignore cases where we add a block that already exists, since it is probably a bug and we should report such cases. On the other hand, returning an error is wrong for two reasons -

The caller of AddBlock doesn't care that the block was already there and it has nothing to do with this information.
If you return an error the caller might falsely assume that the operation failed and that the block isn't in the db although it is there.
This is what we should do -
Before adding a block we should check if it is already there. If it is there, print an error and don't return an error.

I've changed the code to print a warning when we try to add a block that exists, but we'll not return an error. essentially doing the same effect as before apart from writing a new value to the db.
we now check the db everytime before writing, when there's no block we have a read+write. when there's a block we have 1 read.
with overwriting we always have one write.

i think the solution i suggested is much better, overwriting things in the db is just the wrong way to solve this and in my opinion would result in bigger issues later on

probably not going to get in @almogdepaz is addressing it in another pr


Display Grid - remove update button and apply changes immediately

This sample has quite a few options to change, and I found it's cumbersome to have to press 'update' every time. This PR simply makes the updateGrid() method trigger every time a UI element is interacted with, so we don't have to go and press 'Update' manually. I've also revised the readme and the screenshot to match the new UI

hey @JonLavi, thanks for posting up a suggestion. I think we should park this one until we get feedback across this board. The reason being that this feels like quite a big design change from a UX perspective and should be proposed to the sample team first. Other SDKs still have the update button. From my perspective, it helps to be in control of all the options and then hit update rather than them happening on the fly since they might be subtle. It would be great to get the rest of the teams feedback on this though.

hey @JonLavi, thanks for posting up a suggestion. I think we should park this one until we get feedback across this board. The reason being that this feels like quite a big design change from a UX perspective and should be proposed to the sample team first. Other SDKs still have the update button. From my perspective, it helps to be in control of all the options and then hit update rather than them happening on the fly since they might be subtle. It would be great to get the rest of the teams feedback on this though.

Thanks @Rachael-E . There's no common issue for a 'redesign', since the change is considered  too trivial for a complete overhaul. I find that if changes are subtle, you would want to change only one parameter at a time, and then see it as soon as possible, without having to click an extra button in between. However if you don't think this change is worth it, just close the PR. Thanks!

Closing as it's not viable to change the common design itself for such a trivial modification


New snippet

@theRealPadster Does this seem like it fits the use case of snippets? I feel like it's different from the intended use of snippets but still rather cool.

Would be awesome if you could let this through even if it doesnt fit the use case, its still a css snippet after all, i'd just rather not have to go through the effort of creating a custom theme menu and stuff


MGMT-3952: Basic unit test for tools/test_add_triage_signature.py

It's not easy to test those signatures but at-least this will help catch
some trivial issues
A corresponding prow job will be created to run this

/cc @osherdp


Exiting abnormally

when I run "UnrealTrack-City1StefaniPath1-DiscreteColor-v1", some error occurred:
[2019.10.29-03.34.23:452][ 90]LogModuleManager: Shutting down and abandoning module PakFile (2)
[2019.10.29-03.34.23:457][ 90]LogExit: Exiting.
[2019.10.29-03.34.23:457][ 90]LogInit: Tearing down SDL.
Exiting abnormally (error code: 143)

Could you show more details about your environments ( OS, GPU, drivers, ...)?

OS: ubuntu18.04
GPU: Nvidia1080ti
cuda9.0
python3.6
thank you very much!


🐛 BUG: Pages dev does not work with functions in advanced mode

What version of Wrangler are you using?
0.0.15
What operating system are you using?
WSL
Describe the Bug
Hi y'all, I'm super excited about Pages adding first class worker support. I found a developer experience bug.
The docs say you should be able to add a _worker.js file to your dist directory, but when you run npx wrangler dev ./dist, nothing happens.
Here's a reproduction repo and steps

npm install
npm start
Go to http://localhost:8788/, you should see "Hello, world!", but it doesn't work
Go to http://localhost:8788/api/hello, you should see "Hello from the worker!", but that also doesn't work

I've tested uploading this to production and it works without any problems.

Was this fixed by https://github.com/cloudflare/wrangler2/pull/371? Can you try with wrangler@alpha?

Brilliant, thanks @petebacondarwin


Add support for additional user defined ConfigMaps

Presently the chart supports only user defined secret mounts. This PR adds support for additional user defined config mounts.
I am only just getting started with trino but my use case for this at the moment is to mount a truststore for certificate authentication that is provided as a cluster wide config map.

@cla-bot check

trinodb/charts#129 means that it is now possible to mount additional ConfigMaps.
Leaving this open though as it seems there is still benefit given that secretMounts still exists.

@huw0 can you rebase, please?

@nineinchnick now rebased


FrontEnd Service

Hi,
this is more an idea or proposal than an issue.
I would be really great if there would be also one service with serverless.yml for frontend (for example react).

Hmm do you mean adding the frontend service in the same repo? Usually we split these up: https://github.com/AnomalyInnovations/serverless-stack-demo-client
Are you putting them together?

Yes I have whole stack in one repo.
Why are you splitting UI in separate repository if it belongs to the same project?
Basically one use very same structure as you except one of my service is UI where I hold react project and serverless.yml for its deployment and configuration via serverless.
I see in this repository there is some configuration for netlify not serverless with aws.
Anyway its nice example, so thank you.
This was just my proposal you can of course ignore it if you consider it as not valid.

In this case you are using Serverless to deploy it but in the guide we use Netlify for it. We also prefer keeping it separate because for most teams the frontend is worked on completely separately from the backend teams.


Suggestion: allow to only supply single Platform (AppleParameters or GoogleParameters)

or define a 'none' constructor e.g.
google: GoogleParameters.none

It will appear in the future: https://github.com/MadBrains/Mad-Pay-Flutter/blob/main/packages/mad_pay_platform_interface/lib/src/models/processing_payment.dart#L23-L46
You can now try it in the beta

A library update has been released that adds this capability. I close this issue.


Kraken Bug ROKS nodes

Kraken find node is not authorized after logging into the cluster on ROKS:
2021-09-03 10:22:43,943 [INFO] Initializing client to talk to the Kubernetes cluster
 _              _
| | ___ __ __ _| | _____ _ __
| |/ / '__/ _` | |/ / _ \ '_ \
|   <| | | (_| |   <  __/ | | |
|_|\_\_|  \__,_|_|\_\___|_| |_|

/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py:1020: InsecureRequestWarning: Unverified HTTPS request is being made to host 'c115-e.us-south.containers.cloud.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
  InsecureRequestWarning,
Traceback (most recent call last):
  File "run_kraken.py", line 231, in <module>
    main(options.cfg)
  File "run_kraken.py", line 69, in main
    kubecli.find_kraken_node()
  File "/root/kraken/kraken/kubernetes/client.py", line 236, in find_kraken_node
    pods = get_all_pods()
  File "/root/kraken/kraken/kubernetes/client.py", line 118, in get_all_pods
    ret = cli.list_pod_for_all_namespaces(pretty=True)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api/core_v1_api.py", line 16864, in list_pod_for_all_namespaces
    return self.list_pod_for_all_namespaces_with_http_info(**kwargs)  # noqa: E501
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api/core_v1_api.py", line 16981, in list_pod_for_all_namespaces_with_http_info
    collection_formats=collection_formats)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 353, in call_api
    _preload_content, _request_timeout, _host)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 184, in __call_api
    _request_timeout=_request_timeout)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 377, in request
    headers=headers)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 243, in GET
    query_params=query_params)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 233, in request
    raise ApiException(http_resp=r)
kubernetes.client.exceptions.ApiException: (401)
Reason: Unauthorized
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Fri, 03 Sep 2021 10:22:44 GMT', 'Content-Length': '165'})
HTTP response body: {
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {

  },
  "status": "Failure",
  "message": "Unauthorized",
  "reason": "Unauthorized",
  "code": 401
}

Confirmed that this issue occurs when substituting podman in as the container cli, so it is most likely permission based

Hi @seanogor, thanks for reporting the issue. May I know what node scenario is being run and the kubernetes version? Asking to make sure it doesn't require talking to the ROKS cloud as it's not supported as of now, it's needed for things like node shutdown/terminate etc. but not for kubelet/node crash since they just involve talking to the kube API irrespective of the cloud.
From the logs, looks like it's an issue with Kubernetes auth like you mentioned, can we try the following to see if it fixes it?
$ kubectl create clusterrolebinding serviceaccounts-cluster-admin \   --clusterrole=cluster-admin \   --group=system:serviceaccounts


IRI normalization

The complete path segments "." and ".." are intended only for use within relative references (Section 4.1) and are removed as part of the reference resolution process (Section 5.2).
However, some deployed implementations incorrectly assume that reference resolution is not necessary when the reference is already a URI and thus fail to remove dot-segments when they occur in non-relative paths.
--- https://datatracker.ietf.org/doc/html/rfc3986#section-<IP_ADDRESS>

It seems that . and .. path segments are "not intended" to be included in the absolute IRI.
However, IRI and absolute-IRI syntax does not reject such path segments.
So, I think the string types should continue accepting paths with such dot segments, but should also provide a way to normalize the IRI in generic way.
I don't consider implementing scheme-specific normalization at this time.

See https://www.rfc-editor.org/rfc/rfc3987.html#section-5.

I noticed that the normalization and resolution shares most of the logic and they can be unified.
And, task type can also be unified to the single task type.
I'll make resolve::FixedBaseResolver::create_task() to return normalize::NormalizationTask.

IRI resolution and normalization can be done efficiently at once, so I'll add or change APIs for IRI resolution.

Implemented, and released as v0.5.0-beta.3.

More tests are needed...

MEMO: Normalization should be idempotent.

Released as v0.5.0-beta.4.
Note that this version contains breaking changes since beta.3.

Done.


Added Android.Arch.Navigation 1.0.0-alpha01

Support Libraries Version (eg: 23.3.0):
Added Android.Arch.Navigation 1.0.0-alpha01
Does this change any of the generated binding API's?
Added bindings for

common
runtime
fragment
ui
testing

Describe your contribution
I've added the bindings for said libraries and updated the build.cake build script to generate nugets.
ps: thanks for all the hard work with the support libs

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kibotu sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for this, but unfortunately we are moving to a completely different templated binding project model for 28.x and AndroidX, and this PR would not cleanly merge into the 28.0.0 branch.


[feature request] support for dall-e-3?

Dall-e-3 is available in OpenAI's API. I'm wondering if you can add support for it.
Thanks, I appreciate the work that you have done to let people use dall-e-2 over the API.

Dall-E-3 support added!


There is no sample how to create a custom WebAccountProvider, only how to use it?

There seems to be no sample how to create and register a custom WebAccountProvider.
There is a presentation from Microsoft Build 2015 that shows the concepts, but

the code in the appendix is not complete
the "tokenbroker" sample referenced from the presentation is not available anymore.

I found https://github.com/jaimerodriguez/WebAccountProvider/ but it would be good if that would be polished and maintained in the official Microsoft documentation as there is no other documentation about it.

I created an item on the feature team's backlog.

@oldnewthing could you please give an update its status?

Still active on the backlog.

Ok, thank you for the quick response! Is there any chance you could indicate an expected timeframe? (Weeks? Months? Half year? Year?)

The feature team didn't say. The item is still active on their backlog, and they marked it as a priority for the next major release of Windows after 1903, but they didn't give a specific timeframe.

Thank you for asking!

The same sample is asked for in

https://github.com/Microsoft/msdn-content/issues/1
https://github.com/Microsoft/Windows-universal-samples/issues/577
https://github.com/Microsoft/Windows-universal-samples/issues/377

@oldnewthing could you let us know what the status of the backlog item is?

Still on the backlog.

@oldnewthing is there any update on this?

Still on the backlog. I will update this issue if the status of the backlog item changes.

Isn't that this sample? https://github.com/Microsoft/Windows-universal-samples/tree/main/Samples/WebAccountManagement

No, because that sample does not properly implement the manifest, activation events, backgroundtask etc as explained in this repository: https://github.com/jaimerodriguez/WebAccountProvider.


[FEATURE] If else update

Is your feature request related to a problem? Please describe.
We don't need to use brackets in if statement, because we already know where logical expression and where code
Describe the solution you'd like
Replace:
...
if (some_var == 10)
{
}
...

by
if some_var == 10
{
}

Fix issue in 4c67057


DNC in the shell

You can shell DNC if you want to, you can leave spreadsheets behind~
I updated the URL that the icon downloader script pulls from to use the updated xivapi beta site, which is the one that's actually being maintained going forward.
Also included is some work to allow actions to affect/be affected by multiple cooldowns for things like GCDs with an associated longer cooldown (ie. Standard/Technical/MCH tools), or abilities that share a cooldown in-game (ie. Closed Position and Ending).
Longer term, we should probably refactor this to more closely match game state which defines cooldowns by group, and any given action can be affected by an array of coldowngroups, but this should be sufficient for any near-term use.

:0 just poked around a bit and I saw this:

I don't think we should use the green GCD bar to indicate anything other than GCD. The green GCD bars and purple cast bars are displayed like they do now to indicate whichever is longer will block the next skill/GCD, but in this case this green bar isn't blocking anything. And may overlap with later GCDs and make it hard to tell how long a skill takes.
I don't play dancer and maybe it doesn't matter as much specifically for dancers, but I think we should keep the visuals consistent whenever possible, so players using other jobs don't get confused.

How is ths status shown in game? Is it a buff? If so can we also switch to using a buff instead and get rid of this buff after Standard Finish?

That's probably an unintentional side effect of setting up the additional cooldown handling for Standard's 30s cooldown... I didn't really pay attention to that since I was focused on making things work right. I'll take a look to see if I can figure out how to fix that

Here's the file I'm using to get the exception, I see the exception after loading this and then pressing any GCD.
dnc_error_after_one_more_button.txt

Also no.... let's not leave the huge minHeight as is... I will figure something out......

(continuation from discord)
Seems like even to do something special for DNC is going to require a tiny bit of refactor... I guess, for this PR can we have the huge minHight just for DNC but not other jobs? And I'll make another PR to implement this:

Or alternatively merge the minHeight as-is but don't deploy yet...

Changes should all be present. If there are more indent level problems we should consider setting up eslint rules to enforce whichever flavor we want, and can also set up vscode rules to automatically fix lint errors on save so we don't have this problem in the future.
The minHeight change is being left in for now since the code locus that was made at has no notion of the current job, so I can't condition it as such. Plus it seems there's other ideas baking anyways...

If there are more indent level problems we should consider setting up eslint rules to enforce whichever flavor we want, and can also set up vscode rules to automatically fix lint errors on save so we don't have this problem in the future.

Yeah... we should probably wait until a couple weeks after FRU and the codebase settles down so we don't introduce a bunch of merge conflicts due to linting though. Might also want to make precommit hook for this purpose.

The minHeight change is being left in for now since the code locus that was made at has no notion of the current job,

We have a hacky way to get the currently displayed job with controller.getActiveJob(). It's unidiomatic but it should work, and I think it's worth doing because the big minheight does make the other jobs look kinda weird.

Also, damage table still isn't rendering modifiers correctly: should be an easy fix, you'll just need to modify the buffName and BuffTag functions in src/Components/DamageStatistics.tsx (https://github.com/xivintheshell/xivintheshell/wiki/Adding-a-new-job#the-damage-table).

There's this but should be quick to fix; I can fix it later too


Can't style react-autosuggest__container since it doesn't pass className prop

Since the container/root element does not pass className prop we can't use styled components on it.
Since we're not using any other styling other than styled in our project there is no way for me to set position relative on the root element.

I think you can get that to work, please check: https://github.com/moroshko/react-autosuggest#theme-optional
I was able to do with CSS Modules. Should be the same with styled components.

I think if allow add a custom className to root element, will help a lot.

You can also wrap AutoSuggest in a StyledWrapper
ex:
<StyledWrapper>
  <Autosuggest {...yourProps} />
</StyledWrapper>

const StyledWrapper = styled.div`
 & .react-autosuggest__container{
  // your style
  }
`

What is styled here??

What is styled here??

Google styled-components

I face a similar issue to customize aria attributes of the container. Is there any way to manage aria attributes of container?


feat(segment): add segment component

Description
This PR implements the segment component. The way the segment stack is controlled by the stack input which by default is set to be falsey.
Requirements
The segment component should be either inline at all breakpoints or stack whenever needed (sm, md, lg breakpoint).
It takes the full width of the container element.
Storybook link: https://deploy-preview-86--legal-and-general-canopy.netlify.app/
Design link: https://legalandgeneral.invisionapp.com/share/NSZDSDYUWFE#/screens/416751156_Segment
Screenshots:

Checklist:

[x] The commit messages follow the convention for this project
[x] I have provided an adequate amount of test coverage
[x] I have added the functionality to the test app
[x] I have provided a story in storybook to document the changes
[x] I have provided documentation in the notes section of the story
[x] I have added any new public feature modules to public-api.ts
[x] I have linked the new component to adobe DSM (if appropriate)

I noticed this, which I think we know about as the emphasis is on the developer to set it up correctly, should we drop something in the notes?

Looking good from my point of view, although I'm wondering if there should be a default stack behaviour on a small mobile viewport? Just to echo @thatguynamedandy comment above, here's a screenshot of the segments with stack set to false. I wonder if we should always stack them on this sized viewport, or if there could be a scenario where you'd want them inline here -- perhaps if there is just two small, one-word segments?
CC @alexcanning

The preference was to keep them inline because if the options fit in the viewport they should be displayed like that but maybe we could set the default to be stacked at 'sm' breakpoint instead of inline? I guess it depends on the number of items we are expecting to see the most in the segment. Any idea @alexcanning?

The preference was to keep them inline because if the options fit in the viewport they should be displayed like that but maybe we could set the default to be stacked at 'sm' breakpoint instead of inline? I guess it depends on the number of items we are expecting to see the most in the segment. Any idea @alexcanning?

The preference would always be for horizontal version to be the default, with the designers and developers consciously identifying circumstances where the stacked variant is required.

Looks great overall! The only thing I noticed is that the instance on Storybook seems to have an initial option set. One of the main purposes of this control when compared with a radio group is that the segment control should not have an initial value set. This is to allow for situations when we need the user to make a conscious choice between several options.

Looks great overall! The only thing I noticed is that the instance on Storybook seems to have an initial option set. One of the main purposes of this control when compared with a radio group is that the segment control should not have an initial value set. This is to allow for situations when we need the user to make a conscious choice between several options.

This is an interesting one, as I always assumed that setting an initial value on a radio button is wrong, but do we have a slightly different need? drawing comparison from GOV.uk
https://design-system.service.gov.uk/components/radios/
Do not pre-select radio options as this makes it more likely that users will:

- not realise they’ve missed a question
- submit the wrong answer

A few sources recommend always having a radio button selected by default, e.g.:
https://www.nngroup.com/articles/radio-buttons-default-selection/
Although some of the thinking on why you should do this seems to differ.
We should default radio groups to their safest choice, or perhaps providing confirmation as part of our journeys.

@alexcanning @thatguynamedandy I've updated both the story for the segment and the test app example to not have any initial value.


Import Validation: If import validation fails, the page hangs

Found in 5.2
Related to https://github.com/CarnegieLearningWeb/UpGrade/issues/1423
Expected: When uploading a completely wrong .json file, I will get a helpful error message in UI.
Actual:
I tried uploading a wrong kind of .json file to try and fail the validation. It allowed me to select this "segments" object .json and on POST to /validation it gets a 500 Server Error, which is not handled in the UI, it just hangs there spinning and I can't close the modal.
In 5.1 I found that when I import this file, I get an syntax error, cannot use forEach of undefined. Possibly this code was ported to backend and is now failing the same way.
Exclude from research NEW!.json

QA: empty files and files containing only '"' still allow upload and then fail with a generic toast error


Add dropdown selector for countries

Add dropdown selector programmatically populated with countries in dataset so that users can select countries from map or from dropdown. Bind dropdown value to selections made on the map.

Country dropdown implemented in commit a1748b7 . Does not "select" the country (so far only admin level 1s are selectable, ie, with data to be shown), but it does zoom to the country so that ppl can select the admin level they want.
This makes accessible the small countries that are pretty much hidden in the map.


Implement state verifier for order book graph

We check the state correctness in Horizon DB using ingest/verify.StateVerifier but we don't check in-memory order book graph.

fixed by https://github.com/stellar/go/pull/1917


ABNT2 (Brazilian) keyboard - console key the same as ' and "

In Brazil, the most common keyboard layout is ABNT2, and the Console Key for Cyber Engine is the single quotation mark ' but if I try to type commands that uses double quotation mark ", I need to press Shift + ' but pressing it closes the console.
But if I open the console with Shift + ' it will open and insert the " but it's annoying toggling the console while typing a command.

You can configure the key to something else in config.json

You can configure the key to something else in config.json

Okay, thanks!
I changed it to 45 (Insert key).
I looked into the documentation before posting, and when I saw this page I thought there wasn't a way to change, maybe a note there would also help other users:
https://wiki.cybermods.net/cyber-engine-tweaks/console/usage#how-to-open-the-console

Okay, thanks!
I changed it to 45 (Insert key).
I looked into the documentation before posting, and when I saw this page I thought there wasn't a way to change, maybe a note there would also help other users:
https://wiki.cybermods.net/cyber-engine-tweaks/console/usage#how-to-open-the-console


Cookie uses dnn_IsMobile with term "dnn"

Description of bug
Not really a bug but a preference, I would like to see less references to the platform as possible and I believe changing the cookie used for dnn_IsMobile could be changed to something else less revealing
Steps to reproduce
List the precise steps to reproduce the bug:

Go to a dnn site
Click on security lock to view cookies used in browser
Scroll to dnn_IsMobile

Current behavior
cookie uses dnn_IsMobile
Expected behavior
something more generic that is less revealing used instead of terms like "dnn" in cookie.
Screenshots
If applicable, provide screenshots to help explain the bug.

Additional context
I will create a PR using app_IsMobile for a more generic cookie name
Affected version

[x ] 10.00.00 alpha build
[x ] 09.07.01 release candidate
[x ] 09.07.00 latest supported release

Affected browser

[x ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[x ] Microsoft Edge Chromium

Folks do have configurations and documentation making use of that name, so just changing the name would be a breaking change for some people.  Making the name configurable would not be a breaking change, and it much more likely to get accepted.  Hope it helps!

Looking into a web.config solution as proposed here would it be something like adding the following:
 <appSettings>       <add key="MobileViewSiteCookieName" value="dnn_IsMobile"/>       <add key="DisableMobileViewCookieName" value="dnn_NoMobile"/>     </appSettings>
Then in FriendlyUrlController.cs file:
        private const string MobileViewSiteCookieName = ConfigurationManager.AppSettings["MobileViewSiteCookieName"];         private const string DisableMobileViewCookieName = ConfigurationManager.AppSettings["DisableMobileViewSiteCookieName"];
Settings in app settings could change or maybe it needs to be in <dotnetnuke> web.config settings?

One thing you should probably do is default to the old value, and then you don't need to add it to existing web.config files.  It could look like this:
private readonly string MobileViewSiteCookieName = ConfigurationManager.AppSettings[name: "MobileViewSiteCookieName"] ?? "dnn_IsMobile";
private readonly string DisableMobileViewCookieName = ConfigurationManager.AppSettings[name: "DisableMobileViewSiteCookieName"] ?? "dnn_NoMobile";

You can also see 09.08.00.config from #3969 for an example of adding new elements to the web.config

I will try to have this done up today, I was hoping to work on the PR last night...


Double extension of interfaces is not allowed in TS

Description
There is an error in TS: 'An interface may only extend a class or another interface' in DateTextField, because double interface extensions are not allowed in TS (https://github.com/Microsoft/TypeScript/issues/16936) Changed interface to type in this PR.

It's clone https://github.com/dmtrKovalenko/material-ui-pickers/pull/695


Support for identifying GitHub App users via OAuth

GitHub Apps have support for identifying users via OAuth, which allows an app to check which resources they have access to, or perform some actions as a user.
It's pretty easy to implement this:

npm install --save github-oauth
Get OAuth credentials from the General tab of your GitHub App settings page, and update your .env the GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET environment variables, and set APP_URL to the public URL of your App (such as https://yourusername.localtunnel.me).
Update the User authorization callback URL on your App settings page to to be https://yourusername.localtunnel.me/github/callback
Add this code to your app:

const oauth = require('github-oauth')({
  githubClient: process.env.GITHUB_CLIENT_ID,
  githubSecret: process.env.GITHUB_CLIENT_SECRET,
  baseURL: process.env.APP_URL,
  loginURI: '/github/login',
  callbackURI: '/github/callback'
})

module.exports = robot => {
  oauth.addRoutes(robot.route())

  oauth.on('token', function (token, serverResponse) {
    console.log('here is your shiny new github oauth token', token)
    serverResponse.end(JSON.stringify(token))
  })
}

The token can then be used to make requests:
const GitHubAPI = require('github')
const github = new GitHubAPI()
github.authenticate({type: 'token', token: token.access_token})
github.users.get({}).then(robot.log);

Which will output something like:
22:39:37.414Z DEBUG PRobot:
  data: {
    "login": "bkeepers",
    "id": 173,

So this is the easy part. There's a few other blockers with actually implementing this:

How do we persist the user's token?
What does the user see after the OAuth dance?

I'm going to just bake this into the App I'm working on right now, but wanted to share the code and start a discussion in case anyone had other ideas.
cc @wilhelmklopp

Note that this is also related to https://github.com/probot/probot/issues/204, but this is using OAuth  with GitHub Apps, not instead of.

I somehow have the impression that you have other use cases in mind, but I think I my ideas don’t have your blockers.

How do we persist the user's token?

Do we need to? For my app, I’ll store the token in the browser’s store, similar to good old cookies. The user will be "signed in", signin out just means to clear the local store

What does the user see after the OAuth dance?

In my case people would use http://octonews.org/ (https is WIP). They click on login, the user gets redirected to GitHub for the oauth dance, then redirected to http://octonews.org/ where it then turns the code & secret into a token, after which the user is shown as signed in.

As a proof of concept, I've tried this:
oauth.addRoutes(app)

oauth.on('token', async (token, res) => {
  const UserModel = mongoose.model('User')

  github.authenticate({ type: 'token', token: token.access_token })
  const {data: user} = await github.users.get({})

  const foundUser = await UserModel.findOne({ githubId: user.id }).exec()
  if (foundUser) {
    foundUser.token = token.access_token
    await foundUser.save()
  } else {
    const newUser = new UserModel({
      username: user.login,
      githubId: user.id,
      profileUrl: user.html_url,
      avatarUrl: user.avatar_url,
      email: user.email,
      displayName: user.name,
      token: token.access_token
    })
    await newUser.save()
  }

  res.end('Working!')
})

However, it doesn't reach the res.end() and instead returns a 404 which confuses me (no errors in console, everything works fine in the DB). Based on my attempts at commenting out lines, it looks like it just dies if github.users.get({}) (and everything below) isn't commented out, which is the first Promise-y thing. It still doesn't work when converted to normal Promises instead of async/awaits, so it might be a limitation of the internal EventEmitter 🙁

I'm looking into OAuth APIs for GitHub Apps right now. Please share your use cases :)

I'm going to close this issue because enough additional tooling exists (@octokit/app, @octokit/auth.js) that adding OAuth identification functionality to Probot is already very straightforward. Huge shoutout to @gr2m for his hard work on all those modules ❤
Feel free to reopen if you think there's more that Probot should be doing!


Diode breakdown voltages are in the models, but misspelled?

I have noticed something odd in the sky130 models I'm using (version cd1748bb197f9b7af62a54507de6624e30363943): there are what I believe are breakdown voltages for diodes in many spice models, but they seem to be misnamed 'vb' rather than 'bv':
+ vb = 11.7 ; Units: volt
+ ibv = 0.00106 ; Units: amper

If I change this to 'bv' as ngspice wants, which also matches the ibv data present, then I get successful simulated breakdowns, as attached.
This is true of both sky130_fd_pr__diode* type things and *__parasitic__diode type things

Great observation, Pat!
This seems to come from the "quick & dirty" implementation of the level 3 diode in ngspice, which is a recent addition (prompted by the existence of sky130).  Level 3 diodes are a Cadence thing, so without the (proprietary) level 3 model equations, the best the ngspice developers could do was to implement the basic underlying idea of a diode whose parameters are based on physical dimensions instead of a scale factor (which is how the original level 1 diode is defined).
Apparently they did not notice some aspects of the level 3 definition;  at least what I found by googling "level 3 diode model breakdown voltage" was a reference at  which states
Diode Model Parameters  - Level = 3

Name | Description | Units | Default

BV, VB, VAR, VRB | Reverse breakdown voltage | V | ∞

So apparently the official Level 3 definition allows any of BV, VB, VAR, and VRB to represent reverse breakdown voltage (that has all the trappings of a model created from a bunch of people's independent hacks to solve the same problem).
Therefore the correct solution is to encourage the ngspice developers to allow all four variants of the breakdown voltage parameter.  The quickest solution is for me to change vb to bv in the diode models, as that should be compatible with the most simulators.

Ah,  well that explains it.  If you want the quick & dirty, I can go through and do a PR.

Ah, screw it, I did the right thing instead.  Or tried to.  I now have added breakdown voltage synonym support to ngspice and made a PR:
https://sourceforge.net/p/ngspice/ngspice/merge-requests/17/
The change was minor, basically 3 lines:
https://sourceforge.net/u/psychogenic/ngspice/ci/80209f021565dc05c7c0ef47cf6965f9f7a39530/
Logging into sourceforge after all this time was the most exciting part.

@psychogenic: PR #20 fixes the issue within the PDK itself, so that can take effect immediately while waiting for your pull request to be merged into the next ngspice distribution.  Thanks again for investigating the issue!

Meanwhile parameter aliases VB, VAR, and VRB are implemented in pre-master-43.
Basic mask and etching offsets are now considered with XW model parameter for level=3 diodes.
Further TLEV=2 uses now an alternative bandgap calculation with GAP1 and GAP2. There are still open topics for this temperature model e.g. saturation currents etc.
Would be helpful to get response after checking with sky-water-libs.


No Calender App for Android

Its super hard to find a great calender app for android. I hope you got some recommendations

Two good android calendar apps are simple calendar from simple mobile tools and etar

Will add some Calendar apps soon


Doesn't work with workspace package settings

So I'm setting this
[workspace.package]
version = "0.3.2"
license = "GPL-3.0-or-later"
repository = "https://github.com/hyprland-community/hyprland-rs"
keywords = ["hyprland", "ipc", "hypr", "wayland", "linux"]
categories = ["api-bindings"]
authors = ["yavko<EMAIL_ADDRESS>
and referencing it here
[package]
name = "hyprland"
edition = "2021"
readme = "README.md"
description = "A unoffical rust wrapper for hyprland's IPC"
homepage = "https://github.com/hyprland-community/hyprland-rs"
version.workspace = true
license.workspace = true
author.workspace = true
repository.workspace = true
keywords.workspace = true
categories.workspace = true

but I'm and getting this error

So it seems like it needs to be able to reference workspace settings.

This needs to be fixed in dream2nix

Oh I've been trying to fix this for so long that I was starting to feel very frustrated with myself haha.
Does this happen also if I was to use directly the crane flake?
Thanks

Oh I've been trying to fix this for so long that I was starting to feel very frustrated with myself haha. I'm happy to find this issue rofl
Does this happen also if I was to use directly the crane flake? Thanks
edit: I found a temporary solution, which is using the fix PR in dream2nix nix-community/dream2nix#525
{
  inputs = {
    dream2nix = {
      url = "github:71/dream2nix/rust-ws-inherit-version";
    };
    nci = {
      url = "github:yusdacra/nix-cargo-integration";
      inputs = {
        dream2nix.follows = "dream2nix";
      };
    };
  };
}

In case someone needs it, here's my project's flake with workspaces

ooh thanksies

Can we reopen this please? It's not fixed

It is for me

Ah, it seems I've found an instance where it still doesn't work: when you set license.workspace = true in a crate's Cargo.toml. I have opened a PR that allows one to observe this behaviour. I therefore think this issue can be reopened.

Ah, it seems I've found an instance where it still doesn't work: when you set license.workspace = true in a crate's Cargo.toml. I have opened a PR that allows one to observe this behaviour. I therefore think this issue can be reopened.

Works for me in https://github.com/hyprland-community/hyprland-rs/tree/master

I seem to get an error if I even try to load that flake:
nix-repl> :lf github:hyprland-community/hyprland-rs
error (ignored): error: end of string reached
error:
       … in the left operand of the update (//) operator

         at «string»:56:13:

           55|             # This is shadowed in the next //
           56|             // sourceInfo
             |             ^
           57|             // {

       … in the condition of the assert statement

         at «string»:66:13:

           65|           if node.flake or true then
           66|             assert builtins.isFunction flake.outputs;
             |             ^
           67|             result

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: getting status of '/nix/store/jiyanhix45y0a7m9nsrng44yjzrp79m9-source': No such file or directory

My nix version is nix (Nix) 2.15.1

Could you please try to replicate this in a nix repl:
nix repl
Welcome to Nix 2.15.1. Type :? for help.

nix-repl> :lf github:yusdacra/nix-cargo-integration?rev=c6379c8b0af83da0049cfa1f3adaeb315dadfb73&dir=examples/simple-workspace
Added 19 variables.

nix-repl> packages.x86_64-linux.default
error:
       … in the condition of the assert statement

         at /nix/store/631cgbs310h1rcix7zs171xzx7p2y97g-source/lib/customisation.nix:222:17:

          221|     in commonAttrs // {
          222|       drvPath = assert condition; drv.drvPath;
             |                 ^
          223|       outPath = assert condition; drv.outPath;

       … in the left operand of the update (//) operator

         at /nix/store/631cgbs310h1rcix7zs171xzx7p2y97g-source/pkgs/stdenv/generic/check-meta.nix:444:17:

          443|       validity = checkValidity attrs;
          444|     in validity // {
             |                 ^
          445|       # Throw an error if trying to evaluate a non-valid derivation

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: cannot coerce a set to a string
«derivation

Could you please try to replicate this in a nix repl:
nix repl
Welcome to Nix 2.15.1. Type :? for help.

nix-repl> :lf github:yusdacra/nix-cargo-integration?rev=c6379c8b0af83da0049cfa1f3adaeb315dadfb73&dir=examples/simple-workspace
Added 19 variables.

nix-repl> packages.x86_64-linux.default
error:
       … in the condition of the assert statement

         at /nix/store/631cgbs310h1rcix7zs171xzx7p2y97g-source/lib/customisation.nix:222:17:

          221|     in commonAttrs // {
          222|       drvPath = assert condition; drv.drvPath;
             |                 ^
          223|       outPath = assert condition; drv.outPath;

       … in the left operand of the update (//) operator

         at /nix/store/631cgbs310h1rcix7zs171xzx7p2y97g-source/pkgs/stdenv/generic/check-meta.nix:444:17:

          443|       validity = checkValidity attrs;
          444|     in validity // {
             |                 ^
          445|       # Throw an error if trying to evaluate a non-valid derivation

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: cannot coerce a set to a string
«derivation

No I'm away from home and will be for a couple days


Sentry - Support browser

Work in progress

[x] Refactor to support browser

SentryClient from package:sentry/sentry.dart with conditional import
SentryBrowserClient for web from package:sentry/browser_client.dart
SentryIOClient for VM and Flutter from package:sentry/io_client.dart

[x] Write test for browser

[x] Working Angular Sentry packages => https://github.com/leftyio/angular_sentry

Main implementation difference are:

gzip compressing not available on browser
javascript stacktrace need to be prefix with window.location.origin to be resolve by sentry

Thanks for the PR! A couple of things before we can move forward. This PR needs two reviews, one to cover the dart-for-web side of things and one to cover the Flutter/VM parts. We have a few people on the Flutter team (including myself) who can provide the latter, but not the former. Therefore we need to find someone on our team who would be willing to own the Web functionality for flutter/sentry.
@kevmoo, @matanlurey, can you help with this?
If you need to move fast and can't wait for these organizational/ownership issues to be resolved, one option is to fork this library (Go open source!).

I already have a fork that we use in production and that is used by angular_sentry for a few month now.
I don't need to move fast, the coming release of dart 2 and angular 5 seems to be a good opportunity to build a strong library for sentry.

It is unlikely my team will be able to own this anytime soon @yjbanov

angular implementation => https://github.com/leftyio/angular_sentry/pull/1/

@yjbanov Are you able to continue to shepherd this through?

Unfortunately, no.

@lejard-h We've moved this to the packages repo. I'm not sure we have anyone who would be able to review the change, still, but in the meantime, would you be willing to resubmit the PR to the other repo?

Any news?

Any news? (Flutter for a web already presented)

Yes, this will have to align with the Flutter for web efforts, likely after we merge the Web support into Flutter proper.

Any updates as to when this PR will be accepted ?

As of September 10, 2019, Flutter for web merged into the mainline Flutter SDK, so we can certainly reopen this discussion.

I fixed the conflicts.
Test are passing but I still need to check my angular_sentry implementation and run additional tests on real env.
I also added conditional import support on package:sentry/sentry.dart so it should not be breaking change.

I've added sentry without checking first if it's support web :( shame on me lool can't run on web anymore.
But now I'm interested to see this merged ^^

I'm reviewing this PR right now in between other high-priority tasks that have been assigned to me, but it's big! :) So it will take some time.

All good now @yjbanov ? :)

Thanks for the ping @jaumard.
@lejard-h Is this ready for another pass? This looks almost there.

@lejard-h I can't thank you enough for your boundless patience! As I read through the history of this PR, I'm amazed at how things have changed since August 2018, when it was first filed. This PR survived tectonic shifts in Flutter and Dart.


Possibility to display Payment fee in checkout

Expected behavior
Payment fee displayed in shopping cart.
Actual behavior
Not possible
Steps to reproduce the behavior

see attached sreenshot. Display "transactie kosten" when payment method is selected with a payment fee (updated on the fly)
Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 5.0.0
PHP version: 7.1.26

Hi @basemedia!
Thank you for reaching out to us! I have forwarded the request to our team to check out and we will let you know once we have more details.
If you have any other questions in the meantime, let us know!
Best regards,
Invertus Support team

Hi @basemedia! How are you today?
Our team has looked into this request and at the moment, it is hard to implement due to Prestashop's logic with Payment Fees.
You can find a related issue right here: Prestashop Github
As it is difficult to achieve with the current Prestashop logic, currently I'm adding the to our wiki page named - Upcoming fixes-Wishlist and we will let you know once this feature is implemented.
For now, we will close the issue, but if you have any further questions, please do let us know!
Best regards,
Invertus Support team


Icons misplacement

For me, all icons are placed too far up when using the Genesis UI theme, like this:

However, folders appear to be fine:

On the default themes everything is alright.

You have to change you them to atom default them and I hope that work.

ex: One Dark

Try to disable Genesis UI theme.

Yes with the default UI theme it works all well, but I want to use Genesis UI

Maybe it would be better to post this issue in the Genesis UI repo

Whenever #37 is merged in the Geneus theme will work perfectly well with Seti-icons.
It is somewhat similar to Genesis UI, it has the "Focus mode" so it may be what you want, we have to wait for the PR to be merged in though. If you have suggestion on how the theme could be better you can always go to the repository

This fix is published in v1.3.3.

Thank you.


openafs: Patch for Linux kernel 6.2

Description of changes
Cherry-pick patches from the openafs-stable-1_8_x branch that allow building for Linux kernel 6.2.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1872


Resolve Molecule idempotence errors in site.yaml

Several commands used in the site.yaml playbook fail Molecule's idempotence tests, as they do not adequately report when a change has or has not occurred.
This patch adds appropriate changed_when conditions to resolve these errors.

CLA signed.


Separate tRPC from Next.js app

Reapply of #835 without refresh logic
Changes
The tRPC backend is now fully separated from the Next.js apps. This means that any first-party Next.js app can simply use createProxyRoute which acts as a proxy in the BFF pattern.
Refresh of access tokens not implemented.
Endpoint will be available on rpc.online.ntnu.no once infra is completed. Runs on :4444 locally

Will merge when infra is ready otherwise main breaks in "prod"


⚠ Processors has degraded performance

In 3754dcc, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 76 ms

Resolved: Processors performance has improved in 9f91736.


SearchBar

Can you please explain us how to create a search bar to search all the users. Thanks

@mk3301 You could just add a search box on the top and filter values returned from firebase, shouldn't be too hard

You make it by coding it yourself.


[Control_01] The ikCns node won't be generated if there's no information added on the ikRef list

Omit this PR, because I just discovered that the controller has rotation values upon generation. Therefore, it is necessary to set its parent to ik_ref to prevent these values from affecting the controller.


Is controlling when the CDM upgrades possible?

For rights reasons we geo ip block out of country downloads, this includes license issue. However we support download in country and watch anywhere (with persistent licenses) but users are getting tripped up by CDM upgrades requiring license reissue. In one case a charity worker arrived abroad with enough content to cover the 3 months they were away to find they couldn't watch it.
Obviously there's going to be scenarios where the CDM needs upgrading regardless. However I don't know what the policy actually is, so might there be some room for being able to control when an upgrade happens?

Interesting, this is a case we have clearly overlooked where internet access is available but the ability to request licenses is not. I will see about the possibility of adding something to handle cases like this.
In the meantime there is a bit of a hackish solution you might employ that could allow you to work around this, if you are using recent enough release (3.1.9, 4.2.0 or 5.0.1, or later in respective series). The idea is that you could use verifyWidevineCdm to dynamically override the Widevine configuration if you are in offline mode, more specifically to override the versionPattern to only look for the version that is already installed. The versionPattern option is currently undocumented but it is a RegEx pattern that decides which versions to consider when performing a CDM update, e.g. "^4\\.10\\..+$" for all CDMs in the 4.10 release series (it can even be used to force a downgrade). By saving the currently installed version and generating a pattern based on that when in offline mode, you could make sure an update is not installed. There is an edge case here too however: If an update is already pending (downloaded during the users last session and awaiting restart before being applied) just changing the versionPattern won't be enough to stop it. To avoid this you can override the updateDir option, defaulting to "{{baseDir}}/WidevineCDM.pending" but also currently undocumented, pointing it to a non-existant directory. Example call for forcing CDM 4.10.1196.0 in offline mode, ignoring any pending update:
app.verifyWidevineCdm({
  versionPattern: "^4\\.10\\.1196\\.0$",
  updateDir: "{{baseDir}}/WidevineCDM.pending-ignore"
});

It is important the versionPattern really represents the currently installed version, e.g. as provided in the widevine-ready event, or this would instead force an upgrade/downgrade to commence.

I finally got around to doing something about this. The latest release, electron 6.0.2-wvvmp contains new options to control the update behaviour. This will roll out to the other release series too as new releases are made available.
Check it out and let me know what you think!

Apologies for the lack of a response on this, I've been both away and addressing other work. Hopefully I'm getting the time to investigate properly shortly, but your changes look good, so thanks in the meantime.

All implemented our side. Thanks again @khwaaj


Integrate no keywords rule into variable-name rule

@myitcv:
@adidahiya and I spoke offline and he suggested merging your rule into the variable-name rule.
Basically, we want to have all functionality related to the names of variables in one rule. Two benefits to this: first, it makes it easier to find the rules/options you're looking for when related functionality is grouped together. Second, it is a little bit better performance-wise, as it's one less rule to traverse the AST.
I've made a PR with the modifications, does it look good to you?

@JKillian

Basically, we want to have all functionality related to the names of variables in one rule

No fundamental objection, and sounds like a reasonable goal. See my comment at the end of this reply.

Two benefits to this: first, it makes it easier to find the rules/options you're looking for when related functionality is grouped together.

Agreed. However I will add that it might be worthwhile (in the near future) having a 'registry' of rules, where you can tag each rule with certain keywords (no pun intended), easily navigate to a description of the rule and some examples (examples that are compiled examples so they don't fall out of date) etc. This would obviate the need to group things into the same rule. But I believe your point still stands in this case.

Second, it is a little bit better performance-wise, as it's one less rule to traverse the AST.

Point taken, although you could say this about every rule.... There are other ways to solve that performance problem.
All that said... The only reason I made this a separate rule in the first place was because what's being enforced here feels like something the compiler should be doing in any case. That's a subjective comment I know, and folks in the TypeScript core team can and do think that things like this should be linter rules (root issue). The naming convention for a variable however is more subjective and is definitely not (if you assume the syntax is correct) something the compiler would ever fail on.
Equally, however, it's just as easy to remove an option from the variable-name rule so maybe it's six of one, half a dozen the other.
But hopefully you understand my rationale for making it a separate rule in the first place.

Yep, I think either rule or rule option works fine in the end.
Just curious, have you ever run into performance issues in general? If people are, then it's something to think about, perhaps in conjunction with #680

Just curious, have you ever run into performance issues in general

Not as yet, but our app is not massive. And importantly the per file lint runtime is relatively low, meaning it's quite acceptable to have a separate terminal showing you the lint errors on save (for example)

If people are, then it's something to think about, perhaps in conjunction with #680

Indeed, and it's at this point we will probably need to consider an architecture whereby the linter can operate in a 'watch' mode, a la tsc --watch. Because otherwise per-file lint times start to go through the roof. And if we were to do this we start getting very close to TypeScript #3003

:+1: lgtm

:+1:  (though technically these are not keywords)
looking forward to the next release

though technically these are not keywords

Agreed, not all of them are keywords, but I borrowed from the spec for the best possible all-encompassing term that captures the spirit of what we're after here. number is a keyword according to the language of the spec, with Number its primitive type counterpart. Very open to other suggestions.
Incidentally, I think we should add Undefined to this list (even though it cannot be referenced as a type)

PR to add Undefined for consistency: #749

@alexeagle @myitcv just published a dev release, 3.0.0-dev.1, with this new rule option

@adidahiya great thanks


Evaluate variables in associated domains in iOS analyze

Change the logic to archiving the app and use codesign cli to pull the entitlement. if any of it fails, fallback to original behavior. The original behavior may contain variable still, my current plan is to handle that in devtool deeplink validation tool. Probably to show a prompt to ask for user input, or just display error.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

the new workflow goes through the buildXcodeProject, I am not sure how to mock it in the test. Can use some advice

@chunhtai Do you have a tracking Github issue for this? Seems like https://github.com/flutter/flutter/issues/140463 may be caused by this issue.

will reopen once I am back from vacation


Regexp replace

New node + a fixes commit.

Alright, adding

I'll change the option for no-match scenarios to forward the packet instead, also adding a new commit doing that on string/replace. So wait for a v2 soon.


i could not build  Failed to resolve entry for package "astro-biome". The package may have incorrect main/module/exports specified in its package.json.

[astro] Unable to load your Astro config

 error   Failed to resolve entry for package "astro-biome". The package may have incorrect main/module/exports specified in its package.json.
  File:
    /home/ende/DEV/sup/test/uno66/astro.config.mjs
  Stacktrace:
Error: Failed to resolve entry for package "astro-biome". The package may have incorrect main/module/exports specified in its package.json.
    at packageEntryFailure (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:28725:11)
    at resolvePackageEntry (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:28722:5)
    at tryNodeResolve (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:28453:20)
    at Context.resolveId (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:28212:28)
    at Object.resolveId (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:44276:64)
    at async TransformContext.resolve (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:43992:23)
    at async normalizeUrl (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:41836:34)
    at async file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:41998:47
    at async Promise.all (index 2)
    at async TransformContext.transform (file:///home/ende/DEV/sup/test/uno66/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:41914:13)

Waiting for the debugger to disconnect...
Waiting for the debugger to disconnect...

Fixed in 0.0.3


Increase size of column name in table ab_view_meu

https://github.com/apache/incubator-superset/pull/5915 introduced support for Google Spreadsheets as datasources, using the gsheetsdb module. The code was tested using only SQLite as Superset's database. Today I discovered it fails in MySQL (and probably other databases that enforce column sizes for strings), since the table name of a Google spreadsheet is too big to be stored in the ab_view_menu table.
I increased the size of the column name from 100 to 255 characters, and tested the Google connector using MySQL as the main database for Superset.

Codecov Report

Merging #6532 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #6532      +/-   ##
=========================================
+ Coverage    73.5%   73.5%   +<.01%
=========================================
  Files          72      72
  Lines       10001   10002       +1
=========================================
+ Hits         7351    7352       +1
  Misses       2650    2650

Impacted Files
Coverage Δ

superset/views/core.py
75.01% <0%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852c512...0cb805b. Read the comment docs.

Ping @mistercrunch

LGTM

@betodealmeida when I do superset db upgrade, it always hangs on this upgrade

@aboganas I also had problems when deploying this, but it eventually went through after I killed some processes in MySQL. I assumed in my case it was taking too long because of the size of the table.
I tested on a clean install and it works fine. @mistercrunch any idea why this could be hanging?

There's another script that runs a similar command (https://github.com/apache/incubator-superset/blob/46c86672c8320c0003c2eb26f73db6daa2767996/superset/migrations/versions/956a063c52b3_adjusting_key_length.py#L18).

I left it running and it went through after like 8 hours. so maybe as you said there was a process holding it up


Cluelessness with codecs / Video-pixelation

Hi guys,
i have a problem in my code and i think its caused by the codec (or probably by me).
codec = 'libx264'
images = [img for img in os.listdir(plots_path) if img.endswith(".png")]
images.sort()
frame = cv2.imread(os.path.join(plots_path, images[0]))
height, width, layers = frame.shape

video_name = video_path + os.path.sep + str(name) + ".mp4"

video_file = av.open(video_name, 'w')
stream = video_file.add_stream(codec,fps)
stream.time_base = Fraction(1,1000)
stream.pix_fmt = 'yuv420p'
for i,image in enumerate(images):
    img=Image.open("plots/"+str(image))
    frame= av.VideoFrame.from_image(img)
    frame.pts=frame_time[i]
    packet = stream.encode(frame)
    video_file.mux(packet)

    os.remove(plots_path + os.path.sep + str(image))

video_file.close()`

I will briefly describe my code:
It will take a list of images and turn them into a video-file.
'frame_time' is an array with the specific time (in ms) at which the frame should be shown.
Therefore im setting the stream.time_base to Fraction(1,1000) that one time_base-unit should be 1ms right?
If im using some functions wrong etc. please feel free to correct me :)
But now to my problem:
When i use the codec 'mpeg4' the video will lose quality the longer it goes and at the end it will have a very pixelated quality but the video will render till the end.
But when i use the codec 'libx264' the quality will stay super sharp, but the video won't render till the end. The last 0.5 seconds won't be in the video.
I will appreciate every help i'd get and im sorry for the inconvenience.
Thanks guys
//Edit:
i added this at the end:
    for packet in stream.encode():               video_file.mux(packet)
and now the libx264 is working (the video is playing until the end).
But the mpeg4 version is still getting very pixelated (which is probably a mistake of mine?!)
Its working for me now so this thread could be closed, unless the pixelation of mpeg4 isnt my fault.
PS: Im fairly new to PyAv, so if you see ways to improve my code or give me tips in any way, im more than happy to hear it ;)
Greets TheRedCupDude

My guess with the "pixelation" problem is the default settings for mpeg4 are not great.
My takeaway from this issue is that an av.flush() or something that deals with the boilerplate of muxing the final packets would be great.
Unless there is something else, shall we close?

@mikeboers yup, closing


Safari input placeholder overlaping(MacOS X)

Version
2.3.4
Reproduction link
https://jsfiddle.net/wp27wa42/5/
Steps to reproduce
Push the button "Set Data"
What is expected?
Placeholder changes to data (works in Chrome, Firefox)

What is actually happening?
Data overlaps placeholder

Safari 10.1.1 (12603.2.4) Mac OS X 10.12.15

Could not reproduce it with the same env and the steps. Anyone else could check it?

@prsth The version in your fiddler is<EMAIL_ADDRESS>it seems to be ok here with the same env & steps.
I update it with the latest version here https://jsfiddle.net/wp27wa42/6/, and it works well too.
Anyone else could help to check it.

Cannot reproduce either (Safari 10.1.1)


[AJ-1310] Only show protected workspaces when importing protected data

https://broadworkbench.atlassian.net/browse/AJ-1310
When showing the menu to select a workspace to import data into, workspaces that don't meet the authorization domain requirement are filtered out of the list. But options for workspaces that don't meet the protected data requirement are disabled.
https://github.com/DataBiosphere/terra-ui/blob/e91a6aba8a3a171a3f94c05f7ebd986165f12253/src/import-data/ImportDataDestination.ts#L154-L166
For a more consistent user experience, this also filters out workspaces that don't meet the protected data requirement.
As part of that, it splits out the logic for checking if data can be imported into a workspace into a separate function and adds some additional tests for it.

Is this just for pre-existing workspaces or does it work for creating new workspaces too?

This only affects the list of workspaces shown when choosing to import into an existing workspace.
The requirements for a new workspace are enforced elsewhere, by passing options to NewWorkspaceModal.
https://github.com/DataBiosphere/terra-ui/blob/e91a6aba8a3a171a3f94c05f7ebd986165f12253/src/import-data/ImportDataDestination.ts#L295-L307