fixing url generation from markdown

There is a bug where &'s in links get escaped to &. I believe the correct behavior is to not escape the & when it is a href attribute, and to continue escaping it when it is in the html element.
Bug:
require 'redcarpet'
renderer = Redcarpet::Render::HTML.new
s = '[/z?a=b&c=d](/z?a=b&c=d)'
Redcarpet::Markdown.new(renderer).render(s)

Actual:
=> "
/z?a=b&c=d
\n"

Expected:
=> "
/z?a=b&c=d
\n"

I would love to have this PR merged. We are having issues open by this "bug".

@mdeniz: @mattr- and @robin850 are the maintainers of this repository. I'm afraid I no longer have any context about Redcarpet to review these changes, since I no longer develop or use the library myself. :(

Hi there!
Sorry folks, it's been a long time since I really contributed to Redcarpet, I didn't have much time recently. I will try to have a look at it tomorrow or this week end at least, thank you very much !

Nice @robin850, thank you so much! :smile:

@robin850 don't forget me!! :smiley:

Sorry for the delay, thank you very much guys ! :heart:

Thank you very much @nolman  and @robin850, you save us much time.

This seems wrong to me. Not understanding why this change was made, as it violates the HTML spec.
https://stackoverflow.com/questions/3705591/do-i-encode-ampersands-in-a-href
https://stackoverflow.com/questions/15776556/whats-the-difference-between-and-amp-in-html5
http://www.peterbe.com/plog/amp
Seems like it should be reverted, unless I'm misunderstanding something...

Hi @reedloden, ok, using & in the url is more HTML compliant, but in many cases it just doesn't work. Try this url https://www.google.com/search?start=10&q=ampersand (it works) and this other https://www.google.com/search?start=10&q=ampersand (it doesn't work).
What should we do then?

BTW @robin850, can you release a new gem version for this?

FWIW, from what I've read elsewhere, this change is arguably HTML5 compliant, but possibly isn't XHTML compliant. Whether that's of concern, I'll leave for others to decide.
Even for HTML5, the unescaped ampersand must be unambiguous. Most of the time this will be true, but it is possible to have semicolons in URLs and that could present problems.
@mdeniz, in your example above with the google URLs, the reason the first works and the second doesn't is that GitHub is escaping the & every time, including inside the href (check the page source).
So, in the first case, GitHub is rendering start=10&q=ampersand as start=10&q=ampersand.
In the second case, they're rendering start=10&q=ampersand as start=10&amp;q=ampersand, which is (of course) going to break as it's double-escaped.


[4.0] RangeInfo: Add a new range info kind that describes part of a parent expression. rdar://32039874

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 69a907621725b07d2495a371fe720c7b1ec1388f
Test requested by - @nkcsgexi

@swift-ci please test

Approved by Ted via email


Please, leave a keyboard shortcut for creating a new item!!

What feature or improvement do you think would benefit Files?
One reason I like your Files app is that Ctrl+Shift+N shortcut can not only create a folder, but also different types of files, which is much better than Explorer. Creating an item without touching mouse is superb!
However, the latest V3 update changed the function of this, and the process of creating an item via Ctrl+Shift+N doesn't work, it just creates a folder. To create an item without a mouse, now we have to use Ctrl+Shift+P and search the prompt.(p.s. Command Palette is a great improvement indeed)
As always, I'd love to use Files, but I don't think that replacing the old one is a good idea.
Requirements
Restore the Ctrl+Shift+N menu to its original functionality.
Alternatively, create a separate shortcut key for the "Create new item" menu.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.2506
Comments
No response

Thank you for your feedback, the next update will use the ctrl + shift + i shortcut for creating new items.

Thanks, you're making great things happen!


[IOTDB-6190] Increase the threshold for Ratis to shut itself down if it detects that a process is stuck

change to 100 year after pr

We're currently processing your upload.  This comment will be updated when the results are available.


APEX-126 #comment made sure that handleIdleTime is called inside wind…

…ow boundaries

@243826 Please review it


FindById and job identifiers/human names

So jobs.FindById attempts to retrieve job by its unique ID, which is generated randomly - so it's not really possible to fetch a job by "some-identifier". Is there any way to list jobs by their readable name?

@utrack I'm not sure I understand. Can you elaborate on what you mean by "readable name"?

@albrow well uh, term "job type identifiers" is a better term : )
Here's what i mean:
welcomeEmailJobs, err := jobs.RegisterType("welcomeEmail", 3, func(user *User) error {
   // here be dragons
})

// spam poor guy
job, err := welcomeEmailJobs.ScheduleRecurring(100, time.Now(),time.Second*60, &User{EmailAddress<EMAIL_ADDRESS>if err != nil {
    // Handle err
}

... somewhere else
tasks,err := jobs.FindById("welcomeEmail") // it doesn't work but nice to have
// -- tasks would contain job from previous snippet or at least unique string identifiers, which can be used to retrieve scheduled tasks by current FindById()

Okay I think I understand now. What you want to do is get all jobs of a particular Type? I don't like the idea of saying that FindById takes a job id or a job type as an argument. It's conflating two different things.
What I would rather do is add a new method on Type. Something like FindAll. Continuing from your example, you could run something like:
tasks,err := welcomEmailJobs.FindAll()
for _, task := range tasks {
    // Do what you want with each task.
}

Does that cover your use case?

Yup, that's even better :)

Is there any update on this one? @albrow

@umayr sorry for going dark on this one.
I have many projects to maintain and moving forward I'm going to focus on bug fixes and maintenance. I will not be adding any new features to Jobs in the near future, but I would be happy to review PRs. I have also been speaking with a few developers to try and find additional maintainers.
I will update the Development Status section of the README to reflect this.


Warn user on file not created by jupyterdrive

Should at least be of (some) help.

Looks good, but I think it would be even better to catch the error at line 110.  They way you've written it, we catch all errors, but we really only want to catch errors from the specific call made at line 110.

Moved the .catch()  and updated message.

just move the .catch() one more line upwards again...
The reason is that currently catch will be executed when any error happens during contents_prm.  But if we move this upwards (to line 110, inside metadata_prm.then( ... )), it will only get executed when metadata_prm is successful, but api_utils.download(resource['downloadUrl']) fails.  Which is exactly when we want this code to execute.

Will do, brain overheat right now. I'm getting confused with the promise all and contents_prm being cain with metadata ...

We cannot access requested resource\n -> We cannot access requested resource. \n

Done.

great, thanks.


Doesn't work with Amazon RDS?

We've been trying to get the MySQL storage to work on Amazon RDS with little success.
Using docker-zipkin we manage to use the MySQL storage and it works fine.
Changing the MYSQL_HOST to an RDS instance, send dummy traces and try to see them in the web UI (by submitting the search form) ends up in errors such as:
query_1     | java.lang.RuntimeException: UnexpectedNullableFound(ColumnName(zipkin_annotations.end_ts,Some(end_ts)))
query_1     | 	at scala.sys.package$.error(package.scala:27) ~[zipkin-query.jar:na]
query_1     | 	at anorm.Sql$.anorm$Sql$$as(Anorm.scala:472) ~[zipkin-query.jar:na]
query_1     | 	at anorm.Sql$class.as(Anorm.scala:292) ~[zipkin-query.jar:na]
query_1     | 	at anorm.SimpleSql.as(Anorm.scala:190) ~[zipkin-query.jar:na]
query_1     | 	at com.twitter.zipkin.storage.anormdb.AnormSpanStore$$anonfun$getTraceIdsByName$1.apply(AnormSpanStore.scala:204) ~[zipkin-query.jar:na]
query_1     | 	at com.twitter.zipkin.storage.anormdb.AnormSpanStore$$anonfun$getTraceIdsByName$1.apply(AnormSpanStore.scala:180) ~[zipkin-query.jar:na]
query_1     | 	at com.twitter.zipkin.storage.anormdb.DB.withRecoverableRetry(DB.scala:120) ~[zipkin-query.jar:na]
query_1     | 	at com.twitter.zipkin.storage.anormdb.DB$$anonfun$inNewThreadWithRecoverableRetry$1.apply(DB.scala:147) ~[zipkin-query.jar:na]
query_1     | 	at com.twitter.util.Try$.apply(Try.scala:13) ~[zipkin-query.jar:na]
query_1     | 	at com.twitter.util.ExecutorServiceFuturePool$$anon$2.run(FuturePool.scala:115) [zipkin-query.jar:na]
query_1     | 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_60]
query_1     | 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_60]
query_1     | 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_60]
query_1     | 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_60]
query_1     | 	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60]

in the console while the web UI itself is a white unstyled screen stating:
{"errors":["internal server error"]}
com.twitter.finagle.NoStacktrace(Unknown Source)

We've been trying both MySQL 5.6 and 5.5, no change.
The only difference between works/doesn't work really is the DB, everything else is the same. The schema etc are also the same.
@adriancole any pointer would be highly appreciated, this is hopefully the last blocker before we put zipkin to good use here.
cc @jcarres-mdsol

hmm "MAX(a_timestamp) as end_ts" is called by getTraceIdsByName. I'll
add a test to see what happens if you call that and there's no
endpoint with the corresponding service name..

So empty data test passed. only guess is that there's an annotation
missing data in the a_timestamp field. Can you do a select null or
empty on that? Should be impossible, but worth a try.

a_timestamp is never null.
One more thing we have just realized.
When we run it locally with 3 test apps, we create 16 annotations. When executing this against RDS, we create 8 annotations.
Checking the differences, we have seen that the "sr", "ss" and related binary annotations were all in RDS. And the "cs" "cr" annotations and related binary annotations were none of them in RDS.

Is this reproducible without the test apps? Ex. By just clicking refresh on
zipkin, are you also missing cs annotations? This should be testable I
think.. Maybe by curl and then curl against the api's trace endpoint to
verify.


Interactive ads fix

1 more ad fix for walking-tour interactive

Coverage remained the same at 100.0% when pulling 10d5cd5bd7e602b4b50d27f9320be5e88346d5f5 on interactive-ads-fix into 35bd5b327c9e4335b25d67e1e8543b854725a680 on master.

Coverage remained the same at 100.0% when pulling a04eedba6ec9642ae2ae296bb4b013040456e65b on interactive-ads-fix into 35bd5b327c9e4335b25d67e1e8543b854725a680 on master.


[Feature Request]: Automate greeting using Github bot 🤖

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
As the contributor count rises on the repo, it becomes increasingly challenging for maintainers to personally greet and encourage each contributor for their valuable input. Equally important is the reminder for them to review the project's contribution guidelines.
Use Case
Use Case: Automating Contributor Engagement in a Repository
Context:

Increasing contributor count in a software repository.
Difficulty in personally greeting and encouraging each contributor.
Need to remind contributors to review contribution guidelines.

Solution:

Implement an automated system to:

Detect new contributors.
Send personalized greetings and encouragement.
Remind contributors to review the guidelines.

Benefits

Scalability: Handles more contributors without extra effort.
Consistency: Ensures uniform messaging.
Efficiency: Frees up maintainer time.
Encouragement: Creates a positive community.
Compliance: Promotes adherence to guidelines.

Add ScreenShots
PR greeting message ⬇

ISSUE greeting message ⬇

Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I want to work on this issue

Hey @subinoybiswas I would like to work on this issue kindly assign


ADFS MFA msolmodule

Procedure of setting up Azure AD MFA is using MSOL module which is going to be deprecated and there is no graph equivalent provided.
The main concern is with this cmdlet New-MsolServicePrincipalCredential which has no respective graph module cmdlet.
Can you review this one and update the doc, so it contains mg graph cmdlets?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f333e8cb-c046-ee06-d33d-d7dc8e8af695
Version Independent ID: 10838695-f60e-42a7-b0e8-eed7820fd333
Content: Configure AD FS 2016 and Azure MFA
Content Source: WindowsServerDocs/identity/ad-fs/operations/configure-ad-fs-and-azure-mfa.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Remove missingPackage Linting Option

Main
I'd like to have Visual Studio Code team do one of two things:

Remove the Python extension user/workspace option Missing Package: Severity.
If unable to remove, add one of two options:

"Hide"
"None"

I'm not sure why or how this was approved, but there's really no reason to have this option with a requirements.txt file.

Bug
Further, the linting feature doesn't target requirements.txt; I might setup a requirements folder with various filenames (eg - dev.txt, prod.txt) to help keep separation of requirements.  However, the severity warning/hint/etc. still appears in those files.

Finally
The Python extension was nearly perfect (by Microsoft's standards) several iterations ago; stop farting around with it and making it worse.  Python is a very-flexible language by design and doesn't need all the "features" that keep making the creation of simple projects a chore.

/causedByExtension
This is caused by the Python extension. Please file a new issue for it: https://github.com/microsoft/vscode-python/issues/new/choose

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Where should the 'Home' links lead to

Do we allow a user to navigate back to the home page of the Annual Report site mid-flow?
What is the expected behaviour of selecting the 'Service BC Connect' link in the header?
What is the expected behaviour of selecting the 'Home' link in the footer?
Currently these both point to the home page of the Annual Report site, which causes a redirect to the 'Authorization Required' page, since there is no nanoid in the url.
Should we allow users to navigate back to the home page? Or should the 'home' links point back to the Registry site?
I could make the 'Service BC Connect' in the header be text only and remove the link and then the 'Home' in the footer can point to the Registry site.
I don't see the purpose of allowing a user to go back to the home page of the Annual Report site (given the structured flow of this app) as then I would have to save the current business nanoid, which would immediately either show the 'completed' state or redirect the user to the Annual Report form if the filing wasn't completed.

Do we allow a user to navigate back to the home page of the Annual Report site mid-flow? No, for mvp, suggesting no links out mid-flow.
What is the expected behaviour of selecting the 'Service BC Connect' link in the header? Do not enable the link in the header please.
What is the expected behaviour of selecting the 'Home' link in the footer? User can navigate to www.bcregistry.gov.bc.ca. Suggest new window. This page does not require authorization.
Currently these both point to the home page of the Annual Report site, which causes a redirect to the 'Authorization Required' page, since there is no nanoid in the url.
Should we allow users to navigate back to the home page? Or should the 'home' links point back to the Registry site? Only home. See above.
I could make the 'Service BC Connect' in the header be text only and remove the link and then the 'Home' in the footer can point to the Registry site. see above.
I don't see the purpose of allowing a user to go back to the home page of the Annual Report site (given the structured flow of this app) as then I would have to save the current business nanoid, which would immediately either show the 'completed' state or redirect the user to the Annual Report form if the filing wasn't completed. Agreed. What happens if they click their ‘back’ button in the browser mid-flow?

@trishreimer
I will update the links accordingly.
As for using the back button in the browser, its less using the back button and more-so what happens when navigating to a new page (manually typing in a new url will cause the same behaviour), it depends on the filing/auth state.
The home page will either show the filing is completed, redirect to the AR page if theres a filing in progress or redirect to the choose account screen if theres no filing in progress.
The account pages will redirect you to the AR page if you already have a filing in progress.
I will need to add something for the AR + final page depending on the filing state.
Every page except for home and missing-id page will redirect back to home if theres no logged in user.


[ACT-97] Support IAD SDA test in Permutive module

Updates the Permutive RTD module to support a test for segmentation with
the new IAB standard data taxonomy.
Initially we are mapping a small selection of Permutive to IAB cohort
IDs and including these in the ORTB2 object. We also set the segtax
value appropriately for the Index exchange, which we're using for this
test.

Type of change

[ ] Bugfix
[ ] Feature
[ ] New bidder adapter
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
[ ] Other

Description of change

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
[ ] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

@Mullefa thanks for the review so far, I've just found quite a major bug in that the transformations aren't being applied for index because I missed the fact that the getSegments call always loads the ac segments so isn't applying the transformations for  ix.
I'm looking at this now but it makes me think that I haven't quite modelled it right and instead of thinking in terms of per bidder we should be thinking about different taxonomies that we want to support and how to build segment IDs appropriately for each one.
There will definitely be some more changes resulting from this so it might be worth pausing on any other reviewing until I push these up.

@Mullefa have applied the changes we discussed, think it's a real improvement 👍
David and Franz were on board with this idea, Franz is now checking with Steve on the topic of getting Hearst to make the config change.


Latest react-native app doesn't work ":CFBundleIdentifier", Does Not Exist

this very long thread: https://github.com/facebook/react-native/issues/7308 was closed without a solution.  I have the same problem with the most modern environment
Environment
Environment:
OS: OS X El Capitan 10.11.6
Node: 9.10.1
Yarn: Not Found
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 8.2.1 Build version 8C1002
Android Studio: Not Found
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.4 => 0.55.4
Description
the application never gets deployed to the simulator, as it should.  I've checked to make sure the port isn't the problem and have read through the aforementioned thread but find no solutions
Steps to Reproduce
react-native init test
cd test
react-native run-ios

Expected Behavior
a running application
Actual Behavior
the build generates the following error:

** BUILD FAILED **
The following build commands failed:
CompileC /Users/ekkis/dev/test/ios/build/Build/Intermediates/React.build/Debug-iphonesimulator/React.build/Objects-normal/x86_64/RCTShadowView+Internal.o Views/RCTShadowView+Internal.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
Installing build/Build/Products/Debug-iphonesimulator/test.app
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2):
Failed to install the requested application
An application bundle was not found at the provided path.
Provide a valid path to the desired application bundle.
Print: Entry, ":CFBundleIdentifier", Does Not Exist
Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/test.app/Info.plist
Print: Entry, ":CFBundleIdentifier", Does Not Exist

thanks.  I added the information.  I've also found something curious: the previous thread was closed because the OP found that something was tying up the port.  when I run the run-ios command, it automatically spawns a process Metro Bundler on that port.  the previous thread was closed because apparently killing that process solves the problem. in my case it does not.  it breaks regardless the Metro Bundler is already running

The CFBundleIdentifier is a red herring, it basically means your project did not build "for reasons".
It looks like you can repro this on a new project using react-native init, which as of this writing would result on a project that depends on 0.55.4. You're using Xcode 8, however. Updating to Xcode 9 will likely fix your issue. We just updated the docs to make it clear Xcode 9 is required in recent releases.

Running in the same issue. @hramos Is there a place in the documentation where I can check what is the latest RN version that builds correctly on Xcode 8 ?

an upgrade to XCode 9.4.1 fixed the problem.  of course, I had to upgrade to HighSierra for that :( thanks everyone for the help

Is there any way how to fix this problem without updating macOS to high sierra and update xcode to 9.4.1? It is not a good solution, you know

@SilencerWeb you can't upgrade XCode unless you upgrade the OS

@ekkis i see, it sucks that you need high sierra for working with react-native >=0.56 :(


Enchant items stages not working (4.0.0-rc.3)

Hi there!
Either by loading the item to enchant by hand, or specifying item & enchantment type manually in the quest editor menu, I can't seem to trigger the event when applying the enchant with anvil / table
Thanks!

is onEnchantItem used in the listeners for enchant related aspects? I see that onCraftItem is, but for enchant related quests that handler isn't. I cloned and put a quick little "item was crafted", "item was enchanted" message for the server log right at the top of the handlers and i didn't see anything happen for onEnchantItem. Is this type of event handled elsewhere?

Yes, that handler is used for enchantment objectives. It was working last I checked with an Enchantment Table. Are you certain another plugin is not canceling/altering the event?

on this test server i only have citizens and wg installed

I just realized i'm testing the wrong handler (i was using anvil with enchanted book + item). when i use enchant table IllegalArgumentException is thrown in EnchantItemEvent, which now makes this issue a duplicate of issue #1483


Godot choosing the wrong scenes when duplicate UUIDs exist

Tested versions

Reproducible in 4.4-dev (ce8a837aab2568f9cdc41b4b410c478b0cd711fc)
Reproducible in 4.3 stable

System information
Windows 10
Issue description
Mentioned this on core on Rocketchat but the plot thickened so I am raising this as an issue just in case we can find good ways to deal with this.
The issue I reported on Rocketchat was somewhat self inflicted, when starting new project I often copy stuff I need from other projects, but as some of these were also copied into a plugin that I started using, weird clashes ensued and I spend a fair bit of time cleaning up the mess.
But my problem is actually larger then this. I'm working on a new prototype for our XR Tools plugin (aptly named XR Tools 2, though that is going to bite me in the A$$ so that is unlikely to be final). This new version is structurally different hence starting from scratch, but I copy across many of the original XR tools scenes where I can reuse things, or use the old implementation as a base for the new implementation. This copying off course happens on the file system, NOT in the IDE.
The two plugins thus share MANY UUIDs
However, when migrating an existing project from the original XR Tools to XR Tools 2, you will likely start by adding the new version of the plugin to the project and slowly moving things over, it is not a drop in replacement. At this point our problem starts happening.
Godot will load all the scenes for the original XR Tools, then it will load all the scenes for XR Tools 2 however when it encounters referenced UUIDs that it has already loaded, instead of verifying if this UUID is correct, it will CHANGE XR TOOLS 2 TO USE XR TOOLS 1s SUBSCENES. When the subscene then gets loaded it detects that UUID is already in use and gives that scene a new UUID completely severing any ties that this subscene was the actually one used. This breaks the entire plugin.
It gets worse from there, because even if I fix up the subscenes in this project, the UUIDs are now different from the upstream project so I will have a continued fight over the lifecycle of this project every time I pull down an updated version of the plugin that restores the original UUIDs.
I don't think this scenario will be unique, when a major rebuild of a plugin is the only way to get rid of technical debt, it is likely things will be copied from old to new.
While I don't think the problem can be entirely fixed, duplicating files on the file system will duplicate UUIDs and while Godot tries to recover from this, it may not recover from this properly in all scenarios, I do think think there is one improvement we can contemplate here.
As part of marking a folder as a plugin, plugins should maintain their own UUID so that duplicate UUIDs can exist between plugins.
This means that when a class in a plugin is referenced from outside of that plugin, it should be prefixed somehow. Though I wonder how we can deal with dependencies between plugins.
Steps to reproduce
Easiest way to reproduce this I guess is to start with a project that has a plugin with scenes that include subscenes, and duplicate that plugin.
Minimal reproduction project (MRP)
N/A

It's not clear if the problem comes from scenes or scripts. If it comes from scenes, could a tool to generate a new UUID exist? It could solve the issue if you're a plugin maker that copy files from another plugin.

Does this also happen when you drag the files onto the godot filedock instead of just copying them on disk? I think if you drop them on the dock it should regenerate the UUIDs but not sure.

It's not clear if the problem comes from scenes or scripts. If it comes from scenes, could a tool to generate a new UUID exist? It could solve the issue if you're a plugin maker that copy files from another plugin.

Really any file that gets a UUID and is referenced by it, but the main problems I was dealing with today were with scenes used as subscenes.
The problem is, how does Godot know to use new UUIDs? When building a new version of an existing plugin, or when re-using scenes from another project for a new project, Godot just sees new scenes with a UUID that it's happy to use.
The problems don't start until you get into a situation when you combine things, such as adding both old and new version of the plugin to the same project, which is a likely scenario when migrating an existing project from using an old version of the plugin to the new version of the plugin (again in the complete rewrite scenario, not normal version upgrades where you would just overwrite the plugin and deal with the changes).
Changing UUIDs here is disastrous through the continued lifecycle of that project. At some point when migration is done you will delete the old plugin, and now you have the new plugin in this project with all new UUIDs. When you go and update that plugin to a newer minor version where you overwrite stuff, you go back to the old UUIDs because those still exists upstream. While likely Godot will recover from this, it still opens up the possibility for the wrong scenes to be referenced and breaking your application.
Also when changes are made to the plugin which are then up-streamed, you now get a mix of old and new UUIDs as upstream we're still using the original UUIDs.
This is actually a major concern in XR Tools 2 where it's now optionally possible to submodule the plugin, which makes it much easier to develop new features (I love git submodule, soo powerful when used correctly), though we ran afoul of this very often with the current XR Tools as people copy the changes they made in their project, back to a copy of their fork of XR Tools to push in those changes, with now mismatches of UUIDs as Godot opening their project assigned new UUIDs to scenes.

I think the root of the problem is that the uid system interacts poorly with adding externally created resources into a project (including scenes made in another project, or plugin):
Such resources have their own uids written in the .tres, but they are not parsed by the uid cache until the resource is loaded. This results in path fallback (and an annoying error). If the uid is already registered it loads the wrong resource.
I think the first step to solving this would be to make it so that every time a new uid having file is added to the filesystem, the uid is either registered if not there or changed if there. This wouldn't fix the vcs interaction, which is unfortunate, but should stop things from breaking.

About making it work well with vcs:
I really think scenes, etc. made for downloading should not contain or reference uids at all. Files in a repository are going to stay with the same paths, so path references will stay valid.
This would mean that, when creating an addon, there would need to be an option to strip uids, and when downloading an addon, they will be created for the specific project. This way in whatever project context an addon is used, it can be modified locally, have it's uids stripped and will generate a clean diff.

@Jordyfel
The problem is that this still means new UIDs are created when importing a plugin for the first time, that happens to have overlapping UIDs with existing classes, and thus the UIDs of the plugin changing. When you update that plugin to a newer version, the old UIDs return back into your project and things again risk to be broken.

One solution I tried this week was to change the UIDs of the new version of my plugin manually to UIDs that are prefixed with something unique.
Problem is, Godot doesn't like my new UIDs and sporadically changes them to newly generated UIDs. I couldn't confirm whether it does this because it finds my custom chosen UIDs invalid, or whether there is a bug in the save logic of Godot which will change UIDs when it shouldn't.
Discussed this with @KoBeWi and he thinks its probably because I broke some formatting rules around UIDs.
Just for reference, #92972 is a nice enhancement but won't help me here because the project I use to develop the new version of the plugin won't trigger any duplicate UID warning. It's only when the plugin is added to an existing project that uses the old plugin because someone wants to migrate over to the new version, that issues start to happen.
Still a nice enhancement.

^ cc @Chaosus @Calinou

One solution I tried this week was to change the UIDs of the new version of my plugin manually to UIDs that are prefixed with something unique.

Why would you change your UIDs? The same file should keep the same UID, this way you won't have problems.

@KoBeWi

No, they will have new UIDs assigned.

This has two problems.

if my original class UID gets changed, and the new class retains the duplicate UID, all my existing code now points to the WRONG class
if I'm an author/contributor for the plugin I'm bringing in, these changed UIDs will be uploaded back into the project and cause further problems.

And again, I'm not using them both, in my use case I am developing the new plugin separately and most people will use it as is. It is the people that are using the old plugin and want to migrate that have a problem. They will have existing projects, now the new plugin is brought in, IF Godot decides to renumber UIDs in the old plugin, things break (which I've already proven is exactly what happens). Especially because the new plugin is setup that it can be submoduled into the project, so you would normally do this outside of Godot.
But I was discussing this further with others. Here is another scenario that is very likely to happen. I have a sample project on godot-demo-projects showing how to use compositor effects. We even reference this in our documentation. This contains a lot of boilerplate code.
Someone who wants to create a compositor effect is likely going to copy my project and use that as a base. Their compositor effect will thus have the same UID as the compositor effect in the demo.
If the effect is cool, they are going to share it with other users.
The more people create compositor effects, the more effects will be obtainable through the asset library that all share the same UIDs because they all have the same ancestor implementation.
So if I am working on a project for months that includes such a compositor effect, and I've referenced it in many places, and I now see someone elses effect that I'd like to also include in my project. I run a realistic risk of pulling in code with a duplicate UID.
IF in this scenario Godot decides to renumber the existing effect, instead of the new effect.. TROUBLE
But worse yet, if this person UPDATES their effect, and I pull in the new version, and I thus pull in the OLD DUPLICATE UID, I could be in even more trouble, especially if this person moved files around in their asset and Godot has no idea how to decipher the mess that has been created.
We have to have a way to namespace UIDs within plugins so that we can work with multiple assets having duplicate UIDs because they have the same ancester code.

What is the purpose of that UUID? (eg can be it created for exported builds only or something?) I was copying files around in a gamejam, and things broke because of this. This is not even an edge case, it's extremely easy to trigger it.


Cloud HSM usage guide (and small fixes to validator guide)

Description
New docs for using a cloud HSM signer with celocli or contractkit.
Other changes

FAQ section for validators
Remove 0x prefix before $CELO_ATTESTATION_SIGNER_ADDRESS to be consistent with other areas of the documentation
Add a note on voting guide for using HSM keys
Add flag --allow-insecure-unlock to running the attestation node

@codyborn thanks for adding these docs!  I am not sure they belong in the Celo Gold holder guide however -- I see the parallel to "Using a Ledger" but the technical bar is much higher, and I suspect most folks who follow this guide will be developers building services for the community. WDYT?

@codyborn thanks for adding these docs! I am not sure they belong in the Celo Gold holder guide however -- I see the parallel to "Using a Ledger" but the technical bar is much higher, and I suspect most folks who follow this guide will be developers building services for the community. WDYT?

Good point @timmoreton. For the community HSMs can be used for both vote signing key management and securing application keys. It was in the first use-case that I was thinking of adding it here. However, I can also move it under "Developer Guide" -> "Quick Start" and link to it from the voting guide. Which do you prefer?

@codyborn thanks for adding these docs! I am not sure they belong in the Celo Gold holder guide however -- I see the parallel to "Using a Ledger" but the technical bar is much higher, and I suspect most folks who follow this guide will be developers building services for the community. WDYT?

Good point @timmoreton. For the community HSMs can be used for both vote signing key management and securing application keys. It was in the first use-case that I was thinking of adding it here. However, I can also move it under "Developer Guide" -> "Quick Start" and link to it from the voting guide. Which do you prefer?

@timmoreton, chatted with @pranaymohan and he recommended locating it under Dev-Resources/Integration to align with upcoming changes.


Have problem with start_vid.sh

I add a line to start_vid.sh. I ran it in terminal with no problem. It created a audio.wav file in /var/www/media as what I asked it to do.

When I use web interface to record a video. Nothing happened. I checked the log. It shows Raspimjpeg executed start_vid.sh. what did I missed?

For a macro script to execute successfully under the web interface it must satisfy three conditions.

It must be executable. This is achieved using the chmod command. You must have already done this as you are executing it from a command line.

It must be owned by user www-data. The web server runs as user www-data and anything executed by it must have the same owner. This is for security reasons as user www-data has limited privileges to stop nasty things being done. You make script owned by www-data by using the chown command e.g.
chown www-data:www-data /var/www/macros/start_vid.sh

Any processes actions within the script must be allowed for user www-data otherwise they will not successfully run. So user www-data may need to be explicitly given permission for run arecord. One way to achieve that is to add the process to the sudoers file /etc/sudoers.d/RPI_Cam_Web_Interface  This already has entries to allow the web interface to run the shutdown and date commands. Use those as an example.

You are legend. It works.


doesn't work on my friend's device

he doesn't speak English 😜
markdown test blah blah

http://comeandspeak.pl/ 🤡


logs: changing config logs from JSON to YAML

Risk Level: Low
Testing: fixed up unit tests
Docs Changes: n/a
Release Notes: added

:frowning: the world needs less YAML

mm, I guess if some folks prefer json changing the default may be crummy?  I think adding a flag but having it not be the default would probably not achieve my goals.  Basically I thought we were trying to make yaml the gold standard for Envoy config, and it's annoying to take unit test config logs and have to manually convert them over before making them canonical config.
If we think having a yaml default and flag override is worthwhile I'll go add a command line flag, otherwise I'd be inclined to revert.  Thoughts?

If you're just after reformatting unit test configs to YAML, if we have the flag, you can run the test with --test_arg setting the flag.

Also, I've never tried it, but there's a bunch of utils like https://github.com/drbild/json2yaml.

yeah, the server options are nowhere near the log lines, so I guess json wins :-(


Fixes #180 issues with IE 10

First of all thanks for this awesome library. I had to make this library work for IE 10 and I found a pretty easy solution for it.

@Ixl123 Thanks


Improve changelog / release process

Our changelog is currently a list of commits grouped into a few sections. To end users this isn't useful as it is hard to make sense of what individual commits do. It would be a lot more useful if we describe what each PR does and how it impacts the end user. But doing this once every two months is a lot of work.
We've discussed this on IRC a bit, the best we came up with is to make this part of every PR. Each PR that add/changes/fixes something that impacts the user must also create a change log entry. Internal changes (refactoring etc) don't need a changelog entry.
To make sure we don't forget this we can add a PR template or even hook it into the CI.
Are there any objections to this?

+1

So github actions can't comment on a pull request coming from a forked repository: https://github.community/t5/GitHub-Actions/Github-Workflow-not-running-from-pull-request-from-forked/td-p/32979/highlight/true
Quite unfortunate. I think the next best thing is a pull request template

PR template: #1299

I think the current flow is good enough for now


Autotest.html error: Uncaught ReferenceError: complex is not defined

Setting up Transcryt, and after following the solutions found here https://github.com/QQuick/Transcrypt/issues/103#issuecomment-242958627 I successfully ran
transcrypt -r autotest.py

Results:
Transcrypt (TM) Python to JavaScript Small Sane Subset Transpiler Version 3.6.19
Copyright (C) Geatec Engineering. License: Apache 2.0

Ready

However, when I open the generated autotest.html file, I get a page with the table headings, no info, and an error in the consul:

Any thoughts?

Hi,
The autotest contains also tests for complex numbers which need the -c switch.
Use:
transcrypt -r -c autotest.py
transcrypt -b -c -da autotest.py
The -da is to activate assertions, which are also tested.
Let me know if adding these switches works for you.
Kind regards
Jacques

command line switch fixes added here: https://github.com/QQuick/Transcrypt/pull/373


Add docs for spark-operator

Add docs for kubeflow/spark-operator.

cc @andreyvelich @yuchaoran2011 @vara-bonthu

/assign @andreyvelich

@ChenYi015 thanks for this!
We can iterate on the wording in the future, but it's much better than having no docs!
My main requests are for consistency with the other pages:

Can you rename quick-start.md to getting-started.md and change the title to Getting Started
Can you rename API Reference to Reference
Can you add a What is Kubeflow Spark Operator? heading to the top of the Overview page, which very briefly introduces what it is (check the other components for inspiration)

Can you also update the link on the "Installing Kubeflow" page to point to the installation guide on the website (it currently points to the repo):
https://github.com/kubeflow/website/blob/2e451d18c8b21bfa70a7a8255306b2cd83efe609/content/en/docs/started/installing-kubeflow.md?plain=1#L121-L123
Update it to point to the "Installation" section of the getting started page.

Done.

@vara-bonthu if you can wait, I have a few comments, but I still didn't have time to complete the review. I plan to do it today.

@hbelmiro Thanks for the review! I had updated the docs and fixed the borken links.

@vikas-saxena02 Thanks for the review. This PR is mainly for moving docs from spark-operator to this repo. We can enrich and reword the docs lately e.g. using spark operator on other clouds.

@vikas-saxena02 Thanks for the review. This PR is mainly for moving docs from spark-operator to this repo. We can enrich and reword the docs lately e.g. using spark operator on other clouds.

Thanks @ChenYi015 I totally agree, I am happy with the changes so far!!

/approve

/lgtm

Since there hasnt beenymore comments on this since last 24 hours, I am giving it the lgtm label so that @ChenYi015 doesnt get demotivated :)


[DOCFIX] Add configuration guide for HDFS namenode HA mode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12516/
Test PASSed.

Merged build finished. Test PASSed.

@gpang Thanks for your review. I've already included the assumption!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12616/
Test PASSed.

LGTM. Once @gpang  is good. we could merge this PR. thanks @saltylin


Support serving releases and stemcells over http as to support caching

As a bosh user, in order to speed up bosh deployments dependent on remote internet stemcells/releases, I would like that URLs served by bosh.io for releases and stemcells to be cacheable by intermediate caches (such as a corporate http proxy). Bosh director does support explicit http proxy (or could use transparent caching proxies) for downloading releases and stemcells.
Releases and stemcells can be downloaded and their sha checksum checked (see https://bosh.io/docs/release-urls/#http), through urls served by bosh.io such as https://bosh.io/d/github.com/cloudfoundry/os-conf-release?v=12 . Bosh.io currently does a 302 redirect
In order for an intermediate proxy server to cache release and stemcells, the URLs can't use the HTTPS scheme and instead use plain http scheme.
Currently, bosh.io seems to only redirect releases and stemcells endpoints such as https://bosh.io/d/github.com/cloudfoundry/os-conf-release?v=12 to HTTPS urls on AWS S3.
> GET /d/github.com/cloudfoundry/os-conf-release?v=12 HTTP/1.1
> Host: bosh.io
> User-Agent: curl/7.47.0
> Accept: */*
>
< HTTP/1.1 302 Found
< Date: Fri, 18 Jan 2019 16:01:18 GMT
< Content-Type: text/html; charset=utf-8
< Content-Length: 907
< Connection: keep-alive
< Location: https://dfdtmjpfvu0dy.cloudfront.net/c9081528-d29c-4b09-555d-96702d704faa?response-content-disposition=attachment%3B%20filename%3Dos-conf-release-12.tgz&Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cHM6Ly9kZmR0bWpwZnZ1MGR5LmNsb3VkZnJvbnQubmV0L2M5MDgxNTI4LWQyOWMtNGIwOS01NTVkLTk2NzAyZDcwNGZhYT9yZXNwb25zZS1jb250ZW50LWRpc3Bvc2l0aW9uPWF0dGFjaG1lbnQlM0IlMjBmaWxlbmFtZSUzRG9zLWNvbmYtcmVsZWFzZS0xMi50Z3oiLCJDb25kaXRpb24iOnsiRGF0ZUxlc3NUaGFuIjp7IkFXUzpFcG9jaFRpbWUiOjE1NDc4Mjc4Nzh9fX1dfQ__&Signature=YxLD8IYlFLxTQVbpGDxyx6~vhwEOI20w67LduarhrKBKmh7F5WeUJU8HvjlSOJ3fR9DK5PwPwiDaobg46GG7-PzYoQnFXsPzcN-YzUa35ywH9Jpprdjowt~dThDKccd9duBOLNsUx4t8Jc2GtarGGweiu9Q5-nACOPi0AVfHefEU9m0NGpsbKJd68qjNK~cqskje6XNvaV~5ebps8aHvx~9KSyTXi3hITSmtHaLsoFWob0wBeWcBZ9FrNsjq~u0CD7JQfJC56f50Xa-1SsEu7zEW6yaYFCQWfAl8hONTORaKZXoSr0Cd7oXXqF0npVOrAnOluOciKSigUFwWMJDNzw__&Key-Pair-Id=APKAICIFS42OUZR7AVEQ
[...]

Possible implementations:

add a new query param (e.g "plainHttp=true|false") that would redirect to plain http url instead of https url.

https://github.com/bosh-io/web/blob/eafa2223d47ccb3078204ed77e0940eb5ab84693/controllers/releases_controller.go#L88-L111

when the releases and stemcells endpoints are accessed through plain http, redirect to HTTP S3 urls instead of HTTPS urls. Keep redirection to HTTPS S3 urls when bosh.io endpoints are accessed over https

cc @heyjcollins

Hi @gberche-orange, the teams have chatted about this a little bit, and I don't think we want to support the changes you're describing for a few reasons. One general principal is that all connections should be encrypted, regardless of content or other content verifications that may be happening (like BOSH doing checksums). We store our assets via HTTPS, we should really be giving them back to users as HTTPS and not trying to manipulate storage URLs. Another complicating factor is that proxies often have a size limit of what they will cache; this will eventually lead to mixed and, likely, surprising behavior to operators who are unaware of this, eventually leading to debates between IT Ops and BOSH Ops.
That being said, I understand the use case and do think it's valid and reasonable. As a more general solution, what I've done in similar cases is to recommend setting up your own reverse proxy server with caching enabled. This gives you proper control on how large of assets and which kind of assets you're interested in keeping for your environments. You can do this with a fairly short nginx configuration and update your release URL references to point to your mirror with sed or ops files.
If you're interested in other mirroring strategies for BOSH assets, I'd be interested to chat more. It's not something we currently, officially support, but I'd be interested to learn how you'd identify which assets are worth mirroring.
Let me know if you want to discuss this more.

thanks @dpb587-pivotal for considering this feature proposal. While I acknowledge the team decision some comments over its rationales:

One general principal is that all connections should be encrypted, regardless of content or other content verifications that may be happening (like BOSH doing checksums).

Using TLS for downloading content provides two benefits:

authenticating the server
preserving confidentially of the downloaded content.
preventing MITM trying to serve forged content

For bosh.io download urls the content is public. So 2) does not seem necessary. 1) and 3) are covered by bosh director checking content checksums

We store our assets via HTTPS, we should really be giving them back to users as HTTPS and not trying to manipulate storage URLs.

Did you mean We upload our assets into S3 securely using TLS, we should really be serving them to users with TLS, and not allow users to opt-in for downloading content over plain http ?

Another complicating factor is that proxies often have a size limit of what they will cache; this will eventually lead to mixed and, likely, surprising behavior to operators who are unaware of this, eventually leading to debates between IT Ops and BOSH Ops.

In our case, we're running dedicated proxies for bosh downloads, with proper control over max cached size or cache exclusion patterns

As a more general solution, what I've done in similar cases is to recommend setting up your own reverse proxy server with caching enabled. This gives you proper control on how large of assets and which kind of assets you're interested in keeping for your environments.

You can do this with a fairly short nginx configuration and update your release URL references to point to your mirror with sed or ops files.

I understand that in current state of ops files syntax, ops file can only replace complete yml key/value but not perform transformations on a given value content (such as a regexp) and that most manifests directly reference bosh.io urls. This would therefore require bosh manifest files preprocessing step that would need to be included in associated tooling such as bbl.

https://bosh.io/docs/cli-ops-files/
https://github.com/cppforlife/go-patch/blob/master/patch/replace_op_test.go

However, @heyjcollins could recommend best way to reference mirrored bosh.io bosh-releases and stemcells URIs in cf-deployment, or consider a future native support for it.

@bosh-admin-bot please keep this issue open as I believe it is still relevant


Delay block production while waiting for delegation certificate to take effect

When a node posts a delegation certificate to the chain, and is restarted, it may produce blocks with that new certificate before the certificate takes effect.

Fixed in https://github.com/input-output-hk/ouroboros-network/pull/2176


Blade component ignores provided error bag

Laravel Version: 9.23.0
PHP Version: 8.1.8
Database Driver & Version: N/A

Description:
Whenever a Blade component is used in a Blade template, which had an error bag explicitly assigned, then any component used in such view will not have access to this error bag. Instead, the components will only access the error bag globally shared, by default via \Illuminate\View\Middleware\ShareErrorsFromSession.
Is this done on purpose?
Steps To Reproduce:

Create a validator instance:

$validator = \Validator::make([], ['test' => 'required'])

Create a blade component:

    <input type="{{ $type }}"
           class="form-field__input {{ $errors->has($name) ? 'has-error' : '' }} {{ $value ? 'filled' : '' }} {{ $class }}" required
           name="{{ $name }}" value="{{ $value }}"
           id="{{ $id }}"
           {{ $attributes }}
    >
    {{ $label }}
    @error($name)
    {{$message}}
    @enderror

Create a blade view with a component:

            <x-components::forms.input
                    label="Test"
                    type="text"
                    name="test"
                    id="test"
                    :value="old('test')"
            />

Validate input & render the Blade template:

        if (! $validator->passes()) {
            return view('name')
                ->withErrors($validator)
                ->render();
        }

The blade component will not render the has-error class, nor will it render the invalid-feedback span - as the global error bag does not contain the errors passed to the component's owner view.

Afaik, it's not meant to explicitly assign errors to a Blade component.


Update IAM sdk and mocks

mock generated with:
mocker --prefix "" --dst mock/api_invitations_iam_v2.go --pkg mock api_invitations_iam_v2.go InvitationsIamV2Api

@linouk23 should i remove the devel and stag servers from the openapi file?

that'd be great! you might want to remove them from iam/v2/configuration.go too and force push the changes as well

thanks! could you squash these commits and force push the changes?

thanks! could you squash these commits into one commit and force push it to origin/update-iam branch?

Thanks! Just did


Use arabic numerals starting from "1" on the first section or chapter page

Core matter (the main body of the book) should be numbered with Arabic numerals (4, 11) starting from “1” on the first section or chapter page. Some publishers use Roman numerals for the front matter, and carry on the sequence in Arabic numbers (i, ii, iii, iv, v, 6, 7, 8 etc.), but this is not ideal. Roman numerals are used for the front matter of the book to allow additional pages to be added in the front matter without re-flowing the page numbers throughout the book. All pages, including blank pages, are included in the core matter numbering even if the page numbers are not visible on the page.

https://www.artbookbindery.com/guide/page-numbering

(Unfortunately the link above is now 404 waiting on website payment.)
To implement the above numbering scheme we need to be able to identify the first section or chapter page in our output. It is not easy after pagedjs processing or in Asciidoctor output as far as I can tell.
What is the first section or chapter? I thought it might be the first sect1 element although that may be too simple.
first-of-type or nth-child or first-of-class all result in multiple hits within the html produced by asciidoctor-web-pdf. Partly I think this is caused by chunking.
I was trying to do something like:
.sect1:first-of-type(1) {
  counter-reset: page 1;
}

or
.pagedjs_page.pagedjs_tableofcontents_page + div.pagedjs_page .sect1 {
 counter-reset: page 1;
}

I really thought this might provide the next page after the table of contents with a heading. But alas. Something similar would work fine in Asciidoctor:

.pagedjs_page.pagedjs_tableofcontents_page + div.pagedjs_page:first-of-type {
 counter-reset: page 1;
}

This option doesn't work "Error: item doesn't belong to list" because I think first-of-type is a list thing.
My tentative conclusion is that standard css selectors are not working out and the root cause is that the first section/chapter should be more clearly identified in the html output:

Should our converter identify the first section more clearly for styling purposes and (especially) to support improved page numbering? How would we do this - would we need a TreeProcessor to add this information?
Would we want pagedjs to provide a an identifier for the page after the table of contents?
One alternative is manipulating via js but that feels like a workaround and could cause complexity in the pagedjs interaction.


No message if no inactive/active user

A scren : http://i.imgur.com/yTKzYV1.png
Add a message could be a good idea.

Empty columns don't show up anymore.


Tip: increase your max_iter

If your ECE is going up, try simply increasing max_iter on line 60 of temperature_scaling.py
before: optimizer = optim.LBFGS([self.temperature], lr=0.01, max_iter=50)
after: optimizer = optim.LBFGS([self.temperature], lr=0.01, max_iter=100)

It does not work for me, whatever the max_iter is.


Issue: 562 fix: download pdf after login

PR Fixes:

Update signIn component for redirect url from searchparams
Update /pdf endpoint to verify if user is logged in or not

Resolves #562
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

@hkirat @devsargam Please look into this PR
https://github.com/user-attachments/assets/f79f9b56-6b93-4692-82c6-ee743bbee263


Abracadabra: Fix new deployment

Fixes a couple of bugs in abracadabra code, which makes sure that the subgraph can be deployed again for mainnet.

@tannishmango @harsh9200 @0xbe1 @this-username-is-taken

Thanks guys!


Public Folder

I reset my account after losing access to all my rekey devices and noticed my public folder is not syncing with https://keybase.pub/wolf1098/
my log id: 24f1dd8ec0edf7ec9ee7541c

Hi @Wolf1098, I restarted the server and things look ok now.  Sorry for the inconvenience.


ADD RSC(Resource token)

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

Update RSC (Resource Protocol)

Token Address: 8Ci2uQFhWvPuEupoBpmh7EJG8eTepDYrfoPgu7MKCddi
Token Name: RESOURCE PROTOCOL
Token Symbol: RSC
Logo: (https://raw.githubusercontent.com/sangkyy94/RSC/main/RSC icon.png)
Link to the official homepage of token: https://rsctoken.com
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):


Redo capacitor primitive to have pins on grid

@stevenmburns started this (accidentally opened from ALIGN-analoglayout)
Generate capacitors with on grid M1 and M2 pins.
This is even if the capacitor pitch is smaller than the normal routing pitch.
This works for both directions. Should solve issues with cap_array generation.

@arvuce22
I'm merging this. It might bread some stuff that is not using the Mock PDK. Be on the look out.


About Page

This website has to have an About section with a detailed explanation of what this website does, why, who made it, and how to contact the dev. It also has to have a link to the repo.
I was thinking the info can be on the sides of the content.

This content should be easy to read and contain images, icons, etc... Appealing to the eye

The about page will be an article which will be featured.


Broken link in android/app/build.gradle of a new Flutter project

The android/app/build.gradle of a new Flutter project contains:
defaultConfig {
    // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
    applicationId "com.example.myapp"
    // You can update the following values to match your application needs.
    // For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-build-configuration.

The link is incorrect. The page still exists, but the anchor changed and is now: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration

PTAL @anderdobo

Thanks for the report. Seeing same behavior upon creating new Flutter project.

Seeing the same behavior for a new Flutter project and looking forward to the WIP fix to the correctly anchored link called out by Puf.


Support for uint8, uint16, and uint32 fields in structs

Hello, great project!  I've just started experimenting and have found that the uint types mentioned in the subject don't seem to be supported fully.  If I have a struct like so that I generate capnp from:
type Envelope struct {
	Ver   uint8  `capid:"0"`
	SvcId string `capid:"1"`
}

then the test below fails on the last 2 "if" statements.  It appears as if the bytes are serializing / deserializing correctly but the "Ver" field is being set to its go default value rather than the value from the deserialized bytes:
func TestSerializationBytes(t *testing.T) {
	source := Envelope{
		Ver:   1,
		SvcId: "Svc1",
	}

	var o bytes.Buffer
	source.Save(&o)
	oBytes := o.Bytes()

	sink := &Envelope{}
	sink.Load(bytes.NewReader(oBytes))

	var o2 bytes.Buffer
	sink.Save(&o2)
	o2Bytes := o2.Bytes()

	if bytes.Compare(oBytes, o2Bytes) != 0 {
		t.Errorf("Source and Sink Envelope bytes do not match: %v -- %v", source, sink)
	}

	if source.SvcId != sink.SvcId {
		t.Errorf("source.SvcId: %v != sink.SvcId", source.SvcId, sink.SvcId)
	}

	if source.Ver != sink.Ver {
		t.Errorf("source.Ver: %v != sink.Ver: %v", source.Ver, sink.Ver)
	}

	if !reflect.DeepEqual(&source, sink) {
		t.Errorf("Structures do not match: %+v vs %+v", source, sink)
	}
}

Do you plan to support these uint types?

Hi @dmccurley, thanks for noting this. I can confirm it does seem to be a problem.
It would be lovely to support this, but I don't have time just now. I you would be so kind as to prepare a pull request with a fix, I would be happy to incorporate it.  Otherwise you may have to make due with signed ints.
Jason

@dmccurley Please test it out and let me know how it works for you. Thanks! - Jason

Thanks!  I'll check it out.


Readme: fixed typo: javascaript -> javascript

Fixed typo javascaript -> javascript

closing minor prs for now as they are fixed in 0.1.2 release


Fix content-tagger env sync configuration

It incorrectly tries to pull from the staging s3 bucket, rather than
production.  This fixes that.

I think several other jobs have the same issue:

pull_service-manual-publisher_production_daily
pull_collections_publisher_production_daily
pull_contacts_production_daily
pull_search_admin_production_daily
pull_maslow_production
pull_govuk_content_production
pull_publisher_production
pull_short_url_manager_production
pull_travel_advice_publisher_production

I think several other jobs have the same issue:

pull_service-manual-publisher_production_daily
pull_collections_publisher_production_daily
pull_contacts_production_daily
pull_search_admin_production_daily
pull_maslow_production
pull_govuk_content_production
pull_publisher_production
pull_short_url_manager_production
pull_travel_advice_publisher_production

Excellent!  Fixing them too.


test: watcher's /status.get cabbage test

Overview
Script kiddie trying to move the simplest integration test (/status.get) into cabbage.
Changes

Remove OMG.Watcher.Integration.StatusTest
Add WatcherStatus cabbage test

Testing
cd priv/cabbage && mix test test/itest/watcher_status_test.exs

Coverage remained the same at 78.167% when pulling 18b3b8ba5bbc841270524530701ffd2d26cbaa9a on unnawut/cabbage-watcher-status-get into 6e178d27b64d8a452742923cd83a9fa1171c46ed on master.


Updates to frontend template code

Added default homepage
Added default 404
Fixed lint warnings - typescript
Fixed gulp tasks which were throwing error on change/watch

when you do the pull request you can choose to pull it to develop instead of master. That is the most up-to-date branch.

there was no develop branch, when this pull request was generated


Failed to add attachment

为了方便国外友人阅读，还是用英文来沟通了。
When I tried to add an attachment to the file, I meet some problems.
I've add the path of attachment folder like this in settings.json
  "evermonkey.attachmentsFolder": "/Users/XuXiaotian/Xiaotian/Evernote/attachement"
  "evermonkey.uploadFolder": "/Users/XuXiaotian/Xiaotian/Evernote/attachement"
But still I got a tip like
Attachments upload folder not set, you may have to use absolute file path.

Wrong warning. I think if you have configured the directory correctly, you may have already added the attahment, you can use ever resources to check it out.
This warning message will be fixed next version.


The Remove-ComplianceTag cmdlet seems to be gone

When connected to Exchange Online, I cannot find the Remove-ComplianceTag cmdlet:
"Get-Command -noun compliance*" doesn't give me any relevant cmdlets to remove tags.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d3460f6-0eaa-8f6f-e684-833ce077618c
Version Independent ID: 7980acef-b066-9e4b-a1cf-408acbb5bdec
Content: Remove-ComplianceTag (exchange)
Content Source: exchange/exchange-ps/exchange/policy-and-compliance-retention/Remove-ComplianceTag.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@MarcoJanse, according to the topic, Remove-ComplianceTag is only available in Security & Compliance Center PowerShell. Those connection instructions are here Connect to Office 365 Security & Compliance Center PowerShell.
Thanks for the feedback.

This doesn't seems to work and we get below error even after connecting to SNC powershell:


Add default behavior when no origin points match zones

Sometimes there are no origin points e.g. in buildings.geojson, which intersect with zones in input files.
This casuses following error:
"Error: Some zones have no matching origin points: ['zoneid1','zoneid2' ... etc]"
In these cases default behaviour would be good, either to use zone centroid or to select a random node within the zone.

Fixed, do this:
"BetweenZones": {
        "zones_path": "zones.geojson",
        "csv_path": "od.csv",
        "origin_zone_centroid_fallback": true,
        "destination_zone_centroid_fallback": true
}


Creating tasks for Private Github repositories

Hi, the examples only show public Github repo's and private Azure DevOps repos. We're trying to make it work for a private Github repo. Is this supported? The documentation does not specifically say whether it is or is not supported.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd0e3f3c-5aed-28b6-1e28-22ff32a8521d
Version Independent ID: 128e5bc6-e518-bd5a-f511-48e0ed185739
Content: az acr task
Content Source: src/azure-cli/azure/cli/command_modules/acr/_help.py
Service: container-registry
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

It's supported.

Create a qualified github personal access token
Pass the above PAT to --git-access-token

@jaysterp @dlepow

Ok, good to know that it should be possible. Unfortunately, I don't get it to work. Please advice. I run the following command:
az acr task create --registry <ourregistry> --name twinfield-addresses --image <ourregistry>.azurecr.io/twinfield.addresses:{{.Run.ID}} --context https://github.com/Twinfield/Twinfield.git#ARC-P42-6 --file Generic/Addresses/Addresses.Service/Dockerfile --git-access-token <valid PAT token> --platform linux
Which succeeds, so webhooks are created, with following output:
{
  "agentConfiguration": {
    "cpu": 2
  },
  "creationDate": "2019-11-29T10:54:13.436100+00:00",
  "credentials": null,
  "id": "/subscriptions/<oursubscription>/resourceGroups/<ourresourcegroup>/providers/Microsoft.ContainerRegistry/registries/<ourregistry>/tasks/twinfield-addresses",
  "identity": null,
  "location": "westeurope",
  "name": "twinfield-addresses",
  "platform": {
    "architecture": "amd64",
    "os": "linux",
    "variant": null
  },
  "provisioningState": "Succeeded",
  "resourceGroup": "<ourresourcegroup>",
  "status": "Enabled",
  "step": {
    "arguments": [],
    "baseImageDependencies": null,
    "contextAccessToken": null,
    "contextPath": "https://github.com/Twinfield/Twinfield.git#ARC-P42-6",
    "dockerFilePath": "Generic/Addresses/Addresses.Service/Dockerfile",
    "imageNames": [
      "<ourregistry>.azurecr.io/twinfield.addresses:{{.Run.ID}}"
    ],
    "isPushEnabled": true,
    "noCache": false,
    "target": null,
    "type": "Docker"
  },
  "tags": null,
  "timeout": 3600,
  "trigger": {
    "baseImageTrigger": {
      "baseImageTriggerType": "Runtime",
      "name": "defaultBaseimageTriggerName",
      "status": "Enabled",
      "updateTriggerEndpoint": null,
      "updateTriggerPayloadType": "Default"
    },
    "sourceTriggers": [
      {
        "name": "defaultSourceTriggerName",
        "sourceRepository": {
          "branch": "ARC-P42-6",
          "repositoryUrl": "https://github.com/Twinfield/Twinfield.git#ARC-P42-6",
          "sourceControlAuthProperties": null,
          "sourceControlType": "Github"
        },
        "sourceTriggerEvents": [
          "commit"
        ],
        "status": "Enabled"
      }
    ],
    "timerTriggers": null
  },
  "type": "Microsoft.ContainerRegistry/registries/tasks"
}

Things that make us wonder:

contextAccessToken and sourceControlAuthProperties are null, while I also would not have expected the actual access token to be shown, it is also strange it shows as null

When we then run: az acr task run --registry <ourregistry> --name twinfield-addresses
The output is as follows:
Queued a run with ID: cbh
Waiting for an agent...
2019/12/02 19:05:33 Downloading source code...
Run ID: cbh failed after 12s. Error: failed to download context. Please check if the URL is incorrect. If it has credentials, please check if they are expired

The PAT has the following permissions assigned:

repo Full control of private repositories

repo:status Access commit status
repo_deployment Access deployment status
public_repo Access public repositories
repo:invite Access repository invitations

admin:repo_hook Full control of repository hooks

write:repo_hook Write repository hooks
read:repo_hook Read repository hooks

admin:org_hook Full control of organization hooks

We found somewhere in closed questions underneath one of the documentation pages (which I could try to find later if you're interested) that the hook rights were necessary for private repositories.
@northtyphoon @jaysterp @dlepow

@jmeijrink it looks your repository includes submodules. We are deploying a fix to support private git repo with submodule. I will let you know once we finish the deployment.

@jmeijrink can you try rerun the task to see if it works?

Hi @northtyphoon, I tried it again. Unfortunately I still get the same error. I could share output of the command running with --debug, but am not sure whether it will contain any sensitive keys.

@jmeijrink can you send your .gitmodules file to<EMAIL_ADDRESS>We can continue the investigation there.

If anyone finds this issue and has a problem with Error: failed to download context. Please check if the URL is incorrect. note that GitHub's default branch is main and ACR tries to pull from master, if nothing else is specified. I saw this problem a few times already, just add #main to the end of your repository url. This will probably not help the issue author, but other people, who are coming across this.

@itpropro thank you, that helped. Especially when you have applied the same branch name policy to ADO

@jmeijrink Apologies for the late reply. Could you please let us know if you are still facing this issue ? This issue is open for quite sometime. Please let us know if you need any further assistance on this. Awaiting your reply.

If anyone finds this issue and has a problem with Error: failed to download context. Please check if the URL is incorrect. note that GitHub's default branch is main and ACR tries to pull from master, if nothing else is specified. I saw this problem a few times already, just add #main to the end of your repository url. This will probably not help the issue author, but other people, who are coming across this.

Thanks #main was what I was missing !!!

We've also been facing this issue for the last few days. We've Tried changing credentials with new ones, Tenant ID, and upgrading/downgrading the Azure CLI version but nothing seems to be working.
Any idea what could be happening?

Have the same issue - was there a resolution given to the author?


Test open privacy mode behaviour

Related to & waiting for #102

I did a lot of the open test in #215 but need to double check if we need to make muxrpc related changes.

re my previous comments: I think this might be done.

membership on new connections are checked in restricted
tunnel.endpoints only works for members in community and restricted.


Remote-duck best practise

Hi guys,
I need some help with the remote-duck event. How is it possible to detect of the player was playing and then resume play after the "paused" is returned with false.
If paused = false
Then I need to check if player was "playing" and only resume play if it was.
Let's say the user paused the player and is still in background (paused), then the user received a phone call, after they hang up, the player starts playing (for the user might be a sudden play because they were not playing a track when they received the call.
If I detect the state before I pause (when we receive true for "paused"), ios will always be false, which means it will never resume playing (when we receive false for "paused"). Android will work in most cases.

You likely want to keep track locally of whether playback was paused because of a duck event.
Something similar to:
if (e.permanent === true) {
				TrackPlayer.stop()
			} else {
				if (e.paused === true) {
					this.wasPausedByDuck = this.state !== State.Paused
					TrackPlayer.pause()
				} else {
					if (this.wasPausedByDuck === true) {
						TrackPlayer.play()
						this.wasPausedByDuck = false
					}
				}
			}

I will close this as there has been no more comments. Please checkout out the example app :)


question of data

dear author，I have a question.
In this demo, loading data for one day, so how can I achieve the visualization of data for multiple days?

Probably you can make use of the Cesium timeline, you can load the corresponding data when time changes.
If you are not familiar with Cesium API, you can ask for help in the Cesium community


assets: prod asset server can accept version to serve as query param [ch2284]

Hello @nicks, @jazzdan,
Please review the following commits I made in branch maiamcc/specify-asset-version:
de425dd03db3c61cc3cac7df5a57ec0e0a3b203e (2019-05-02 13:59:54 -0400)
respect version query param
558a14aafb93c2cbe7ec3bef40a64c08206bff7e (2019-05-02 12:21:31 -0400)
preserve existing behavior constructing with default url
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

hmmm...i don't think this does what we want?
we want the instance of Tilt that creates the room to set the version, not the person viewing the room

so this doesn't do anything for the sail use case yet, it's just ensuring that the prod server can give you whatever version of the assets you ask it for.
I've got a change in progress to a. attach version info to a room when it's created, and b. send that version along to the asset server when actually making the request for assets (i.e. attaching a query param here. (So, the request to <sailserver>/view/<room-id> doesn't need to set any query params, that's all taken care of internally.
does that make sense?


Cache seems to get out of sync quickly

Since the last releases, I have noticed that the type cache seems to quickly get out of sync, especially when changing branches. Code will appear correct in the editor but will not compile, or vice versa. I have to remove the cache and completely restart VSCode before it fixes itself.

That's not really actionable error report 🙃

I'm also having similar issue from the last release. Ionide stops working after a while. No error checking or intellisense available. I have to restart VSCode to make it work again. Also noted that this error logs appears in the F# output console around the time it stops working.
[Error - 8:48:48 pm] Request textDocument/completion failed.
Message: System.ArgumentOutOfRangeException: Index and length must refer to a location within the string. (Parameter 'length')
at System.String.Substring(Int32 startIndex, Int32 length)
at FsAutoComplete.Lsp.TextDocumentCompletion@627.Invoke(Unit unitVar) in D:\Programowanie\ionide\paket-files\github.com\fsharp\FsAutoComplete\src\FsAutoComplete\FsAutoComplete.Lsp.fs:line 640
at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvoke[T,TResult](AsyncActivation`1 ctxt, TResult result1, FSharpFunc`2 part2) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 398
at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 109
Code: -32603
[20:48:49.271 WRN] [LSP] ParseFile - Workspace not ready
[20:48:50.071 WRN] [LSP] ParseFile - Workspace not ready
[20:48:51.497 WRN] [LSP] ParseFile - Workspace not ready
[20:48:53.394 WRN] [LSP] ParseFile - Workspace not ready
[20:48:54.470 WRN] [LSP] ParseFile - Workspace not ready
[20:48:56.256 WRN] [LSP] ParseFile - Workspace not ready
[20:48:57.506 WRN] [LSP] ParseFile - Workspace not ready

This is not an actionable problem report, and a lot of things have changed regarding handling project files in the 5.0 version, so I'm closing this one.
In case of any problems, please create an issue with specific descriptions and reproductions.


bump iceberg version to use 1.1.0

Thanks for creating this PR @abmo-x. I've just merged https://github.com/tabular-io/iceberg-rest-image/pull/5 which also bumps the AWS version, which should be in line with the ones used by Iceberg. I'll publish the containers right away, let me know if you bump into anything.


[Feature] Number of times a macro is used

Describe the solution you'd like
Beeftext keeps track of when a macro was last used. I think it would be cool if it could also keep track of the number of times a macro has been used. It could be added as a column.
Example:

Interesting idea. It will most likely make it to v10.


Rename News and Events Page to just Events

Is your feature request related to a problem? Please describe.
Currently the News & Events section is only displaying Events, therefore would it make sense to rename it to just Events and in the future, when we will add press releases to the platform we could add the News section in?
Describe the solution you'd like
Change the name of News & Events to just Events

PR merged, thanks!


adding qr tracking picture

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/Qr-coordinatesystem.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Send parameter indicating the protocol of the requesting page

secure parameter will equal true if the requesting page uses https and false otherwise
document.location.protocol wrapped in a function for testing purposes

PR against Prebid.js: https://github.com/prebid/Prebid.js/pull/4578
Story: #169736764

Closing this pull request. Our changes were merged into Prebid.js and released under version Prebid client version 3.1.0: https://github.com/prebid/Prebid.js/releases/tag/3.1.0.


TT-3 Implemented docker on web app. closed #3

Docker file added
docker compose added
github publish readme added

all checks passed so merging the code


When an EVC should be allow to be created

Switches have three type of status: UP, DOWN and DISABLED. These status are determined whether a switch is enabled and active.

Enabled
Active
Status

True
True
UP

True
False
DOWN

False
True
DISABLED

False
False
DISABLED

Does it make sense to create an EVC that cannot be deployed at the creation time? A proposed implementation for the creation of EVCs is that:

Allow the creation when there is an DOWN or UP switch
Do not allow creation when in its path there is a DISABLED switch.
Allow the creation with a DISABLED switch by adding an extra item to the body of the request (ie. force)

Challenge:
To create an inter-switch EVC, a path is requested from pathfinder which only recognizes switches with an UP status ignoring the other instances.

Does it make sense to create an EVC that cannot be deployed at the creation time?

@Alopalao, it does, except for disabled entities. Also, creation time and deployment time have different criteria as you know that are important to maintain. It should be OK to allow a static EVC to be created if none of the GenericEntity instances (Switch|Interface|Link) are DISABLED, otherwise return an HTTP conflict 409, and a network operator should resolve that by enabling it again.

To create an inter-switch EVC, a path is requested from pathfinder which only recognizes switches with an UP status ignoring the other instances.

Right, yes we don't plan to support that on pathfinder in the short-term based on the use cases that we have. If one day we were to introduce to an option to ignore, it'd be aligned with status_reason (and status). The only use case that we currently have on our radar would be for potential static EVCs to allow to pass a ignore_status_reasons: list[str], but still needs to be refined and discussed, since that would also impact how an EVC should be ignoring certain link_down events depending on the reason too.
In summary
Currently, in the short-term, to create an EVC, for static EVCs, all entities.status should be != DISABLED. For dynamic EVCs, ingress and egress entities should be != DISABLED (the first two bullet points you mentioned). For both cases it should only be deployed if status is UP for now. I think that solves most of the reported issues, while still allowing to evolve in the future to support static EVCs with custom status reasons to be deployed or converge accordingly too.
This can also solves issue 288 too, in addition to issue 317

Allow the creation with a DISABLED switch by adding an extra item to the body of the request (ie. force)

It's good to think about it and consider it, but for now, this use case needs to be completely refined and confirmed and discussed its implications, the only related one that we have on radar at the moment, is for potentially provision static EVCs over a path that might be under maintenance, but even this one is still confirmed/refined on @Ktmi's interruptions blueprint, which will probably likely only be confirmed/refined in a next iteration.
@italovalcy can also complement and confirm the use cases (and future ones).

Hi @viniarck and @Alopalao, Excellent to see that we have this issue to discuss this behavior and use cases better. Vinicius, I was talking with Aldo about creating an EVC that cannot be deployed at creation time, and it does makes sense in some scenarios but also can be problematic in other scenarios. Thinking about a temporary situation that made the EVC not be deployed, it makes sense. However, thinking about some permanent error that will make the EVC never be deployed (unless an action is taken) is not so good.
That's where comes this discussion. I agree that we should refine the requirements here, and that is why I think we can leave this issue to be better discussed before putting any effort into it.
Ccíng @jab1982 to also hear his opinion.


How can we use existing sessions with this package ? (Is there an option to pass sessionId through the options)

Hi @rajatKumarr
Thanks for the feedback!
We've just published the new version of this package with new spm_session_id parameter. Check it out!
Also consider our new Smart Browser which have browser built in.

@geronsv can this be added as option in puppeter.launch instead of options of SmartProxyManager as sessionId can be changed for multiple requests and we normally use puppeter.use once to plugging in the manager plugin ?

Sounds great @rajatKumarr !
Have added it just now.


[ASP-4558] Allow application script to dynamically overwrite job-script's name

What
As a a Jobbergate maintainer, I want to allow application scripts to dynamically overwrite the name of the job-script rendered from it, so that the filename is consistent to what the users are used to from jobbergate-legacy.
Why
It was identified that the Abaqus application on Jobbergate asks the user for the name of the job, and that the user provided value is expected to overwrite the original name. This ultimately results in the job-script files being named according to it, since they follow the schema <job_script_name>.job.
This is consistent with the logic on jobbergate-legacy.
Task: https://jira.scania.com/browse/ASP-4558

Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.

The backport to release/4.2 failed:
The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/4.2 release/4.2
# Navigate to the new working tree
cd .worktrees/backport-release/4.2
# Create a new branch
git switch --create backport-456-to-release/4.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0906583f80cad7607db0c8cb5698db1e553c096d
# Push it to GitHub
git push --set-upstream origin backport-456-to-release/4.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/4.2

Then, create a pull request where the base branch is release/4.2 and the compare/head branch is backport-456-to-release/4.2.


Fixed typo (mangement)

Docs Build status updates of commit 1c86987:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/tutorial-1-enterprise-application-integration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Snake Classic by @PiXeL16

[ ] Project URL: https://github.com/PiXeL16/SnakeClassic
[ ] Update contents.json instead of README
[ ] One project per pull request
[ ] Avoid iOS or open-source in description as it is assumed
[ ] Use this commit title format if applicable: Add app-name by @github-username
[ ] Use approved format for your entry

edited

thx!


debase: init at 2

Description of changes
debase is a TUI for drag-and-drop manipulation of Git commits:

Resolves #317240

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Aleksanaa I see you thumbs-upped this PR. Want to merge it? This PR has been languishing for a few weeks.

Thanks for the review, @Aleksanaa! I addressed all of your comments.


Test class name missing (unnamed)

Jenkins and plugins versions report

Environment

Jenkins: 2.387.3
OS: Linux - 3.10.0-1160.92.1.el7.x86_64
Java: 11.0.19 - Eclipse Adoptium (OpenJDK 64-Bit Server VM)
---
ace-editor:1.1
active-directory:2.25
allure-jenkins-plugin:2.29.0
analysis-core:1.95
ansicolor:1.0.2
ant:1.11
antisamy-markup-formatter:2.1
apache-httpcomponents-client-4-api:4.5.14-150.v7a_b_9d17134a_5
artifactory:3.13.2
async-http-client:<IP_ADDRESS>
audit-trail:3.10
badge:1.9.1
bootstrap4-api:4.6.0-3
bootstrap5-api:5.3.0-1
bouncycastle-api:2.28
branch-api:2.7.0
browserstack-integration:1.2.3
build-blocker-plugin:1.7.7
build-failure-analyzer:2.4.1
build-monitor-plugin:1.14-717.v3efcdffe8d58
build-name-setter:2.2.0
build-timeout:1.20
build-user-vars-plugin:1.8
build-with-parameters:1.5.1
buildresult-trigger:0.17
built-on-column:1.1
caffeine-api:2.9.3-65.v6a_47d0f4d1fe
checks-api:2.0.0
cloudbees-folder:6.815.v0dd5a_cb_40e0e
cloverphp:0.6
cobertura:1.16
code-coverage-api:1.4.1
command-launcher:90.v669d7ccb_7c31
commons-lang3-api:3.12.0-36.vd97de6465d5b_
commons-text-api:1.10.0-36.vc008c8fcda_7b_
conditional-buildstep:1.4.1
config-file-provider:938.ve2b_8a_591c596
copy-to-slave:1.4.4
copyartifact:1.46.2
credentials:1254.vb_96f366e7b_a_d
credentials-binding:604.vb_64480b_c56ca_
cucumber-reports:5.6.0
custom-tools-plugin:0.8
data-tables-api:1.11.2-1
date-parameter:0.0.4
dependency-check-jenkins-plugin:5.1.1
deployed-on-column:1.8
deployer-framework:1.3
display-url-api:2.3.7
dropdown-viewstabbar-plugin:1.7
durable-task:1.39
dynamicparameter:0.2.0
echarts-api:5.4.0-5
email-ext:2.83
embeddable-build-status:2.0.3
envinject:2.4.0
envinject-api:1.8
extended-choice-parameter:0.82
extended-read-permission:3.2
external-monitor-job:1.7
flaky-test-handler:1.2.0
font-awesome-api:6.4.0-1
forensics-api:1.4.0
fortifyJenkins:1.4.21
fstrigger:0.41
generic-webhook-trigger:1.86.5
ghprb:1.42.2
git:5.1.0
git-client:4.4.0
git-parameter:0.9.18
git-server:1.10
github:1.34.1
github-api:1.133
gitlab-plugin:1.5.12
golang:1.4
gradle:1.37.1
grails:1.7
greenballs:1.15.1
groovy:2.4
groovy-postbuild:2.5
hashicorp-vault-plugin:2.1.1
hidden-parameter:0.0.4
hockeyapp:1.5.0
htmlpublisher:1.25
instance-identity:173.va_37c494ec4e5
ionicons-api:56.v1b_1c8c49374e
ivy:2.1
ivytrigger:0.35
jackson2-api:2.15.2-350.v0c2f3f8fc595
jacoco:3.3.0
jakarta-activation-api:2.0.1-3
jakarta-mail-api:2.0.1-3
javadoc:1.6
javax-activation-api:1.2.0-6
javax-mail-api:1.6.2-8
jaxb:2.3.8-1
jdk-tool:1.5
jenkins-multijob-plugin:1.36
jenkinswalldisplay:0.6.34
job-import-plugin:3.6
jobConfigHistory:2.28.1
jquery:1.12.4-1
jquery-detached:1.2.1
jquery3-api:3.7.0-1
jsch:<IP_ADDRESS>
junit:1214.va_2f9db_3e6de0
ldap:2.7
logfilesizechecker:1.5
m2release:0.16.2
mailer:457.v3f72cb_e015e5
mapdb-api:<IP_ADDRESS>
mask-passwords:3.3
matrix-auth:3.1.8
matrix-project:789.v57a_725b_63c79
matrix-reloaded:1.1.3
maven-plugin:3.13
metrics:4.2.18-439.v86a_20b_a_8318b_
mina-sshd-api-common:2.10.0-69.v28e3e36d18eb_
mina-sshd-api-core:2.10.0-69.v28e3e36d18eb_
monitoring:1.88.0
msbuild:1.30
mstest:1.0.0
multiple-scms:0.8
naginator:1.18.1
next-build-number:1.7
nodejs:1.4.0
nodelabelparameter:1.9.2
okhttp-api:3.14.9
pam-auth:1.6
parameter-separator:1.3
parameterized-scheduler:1.0
parameterized-trigger:2.45
performance:3.20
plain-credentials:143.v1b_df8b_d3b_e48
plot:2.1.9
plugin-usage-plugin:4.0
plugin-util-api:3.3.0
popper-api:1.16.1-2
popper2-api:2.10.1-1
port-allocator:1.8
postbuild-task:1.9
powershell:1.6
promoted-builds:892.vd6219fc0a_efb
rebuild:320.v5a_0933a_e7d61
release:2.11
resource-disposer:0.16
role-strategy:3.2.0
run-condition:1.5
sbt:1.5
scm-api:676.v886669a_199a_a_
scoverage:1.4.0
script-security:1251.vfe552ed55f8d
scriptler:3.3
scripttrigger:0.34
sectioned-view:1.25
secure-requester-whitelist:1.6
show-build-parameters:1.0
skip-certificate-check:1.0
slack:999999-SNAPSHOT (private-143253a3-iaroic2)
slack-uploader:1.7
snakeyaml-api:1.33-95.va_b_a_e3e47b_fa_4
sonar:2.13.1
ssh-agent:1.23
ssh-credentials:305.v8f4381501156
sshd:3.237.v883d165a_c1d3
structs:324.va_f5d6774f3a_d
swarm:3.28
test-results-analyzer:0.3.5
testng-plugin:1.15
text-finder:1.16
timestamper:1.13
token-macro:359.vb_cde11682e0c
translation:1.16
trilead-api:2.84.v72119de229b_7
twistlock-jenkins-plugin:18_11_96
uno-choice:2.5.6
urltrigger:0.49
validating-string-parameter:2.8
variant:59.vf075fe829ccb
vault_pki_plugin:1.0-SNAPSHOT (private-eba358b8-jenkins)
windows-slaves:1.8
workflow-api:1215.v2b_ee3e1b_dd39
workflow-basic-steps:2.24
workflow-cps:3697.vb_470e454c232
workflow-cps-global-lib:2.21
workflow-durable-task-step:2.40
workflow-job:1308.v58d48a_763b_31
workflow-multibranch:2.26
workflow-scm-step:415.v434365564324
workflow-step-api:639.v6eca_cd8c04a_a_
workflow-support:839.v35e2736cfd5c
ws-cleanup:0.39
xtrigger:0.54

What Operating System are you using (both controller, and any agents involved in the problem)?
Linux
Reproduction steps

Build any job with the plugin enabled.

Expected Results
See class names prefixing the test names
Actual Results
website_tests - #172 Still Failing after 9 min 50 sec (Open)
Test Status:
Passed: 764, Failed: 2, Skipped: 2
2 Failed Tests:
unnamed.checkFocusOnEligibleGamesIosLessThan7 after 0 ms
unnamed.testEligibleGamesForLoggedIn after 0 ms
Anything else?
We were using an older version of this plugin 2.49 and after upgrading to the latest version we noticed that the class name is missing or rather replaced by unnamed which isn't very helpful in debugging tests.
Any info/hints/help would be greatly appreciated.
Thanks.

No idea please provide a minimal reproduction.

Even when running jenkins locally (mac) via the mvn hpi:run command with a simple spring boot project I get the following slack notifications:
test_slack - #3 Started by user anonymous ([Open](http://localhost:8080/jenkins/job/test_slack/3/display/redirect))
[13:56] test_slack - #3 Failure after 14 sec ([Open](http://localhost:8080/jenkins/job/test_slack/3/display/redirect))
No Tests found.

First one when job starts and second when it finishes. Apparently it cannot find the tests this time even though they are run via mvn clean install and I can see the failed tests in the jenkins job console output.
With the previous example the tests are somehow seen but the class name is missing (unnamed is returned by the getTestClassAndMethod method for the class name).
I'm not sure if this has anything to do with some java/mvn/junit plugin but the action AbstractTestResultAction<?> action = this.build.getAction(AbstractTestResultAction.class); definitely doesn't have the right information.

Yes it’s the junit plugin which returns this. If you search the code it does it when a parent is missing

Understood, I'll try to dig into that plugin a bit. I did notice that the action was from the hudson package but thought there might be something more. Thanks, will get back if I get to the bottom of this. Is there a "compatibility matrix" between the junit and this plugin?

Is there a "compatibility matrix" between the junit and this plugin?

Only latest and latest are tested and expected to work together.
Others should work but are not tested.

After spending too much time on this I finally got to the bottom of it (ish). We are using (for some jobs) the testng plugin for test reports. For some reason since upgrading our jenkins instance and this plugin the TestResult result no longer had the className populated. I've debugged and changed a bit this method:

private String getTestClassAndMethod(TestResult result) {
            String fullDisplayName = result.getFullDisplayName();

            if (fullDisplayName.contains("unnamed.")) {
                return ((CaseResult) result).getClassName() + "." + result.getName();
            }
            if (StringUtils.countMatches(fullDisplayName, ".") > 1) {
                int methodDotIndex = fullDisplayName.lastIndexOf('.');
                int testClassDotIndex = fullDisplayName.substring(0, methodDotIndex).lastIndexOf('.');

                return fullDisplayName.substring(testClassDotIndex + 1);

            } else {
                return fullDisplayName;
            }
        }

I'm pretty sure the fullDisplayName.contains("unnamed.") check is a code smell, however the ((CaseResult) result).getClassName() + "." + result.getName(); works to add the class name back to the test name.
If you think this would be useful as a PR - I can add it. If not maybe you have some idea of how to fix this in a better way.


TipCommentsView: Move comment input box to bottom

fixes https://github.com/aeternity/aepp-raendom/issues/35

closing this for now, feel free to reopen if discussion is resolved


Add read error correction

We should support read error correction via an algorithm like Quake

Closing in favor of #597.