lint-staged: Avoid git add after fixes where applied

Description

I am coming from the land of pre-commit, that it is my job to git add files after they are fixed, and not the frameworks'.
Looking at the code https://github.com/okonet/lint-staged/blob/3f3e1523b284056c70b90d3f0ec350b5dce60a50/lib/gitWorkflow.js#L267-L273, it seems that this is "one-way": If the files are linted, they are added no-matter-what 😕
I was hoping there would be a way to get my behavior back.
Steps to reproduce

Debug Logs

expand to view
COPY THE DEBUG LOGS HERE

Environment

OS:
Node.js:
lint-staged:

This is the behaviour, yes.
It might be possible to add a --no-add flag, but so far it hasn't been necessary or requested.

I would love this as well!

I'd use a --no-add flag as well.
Use case: I want to provide a tool for my team to format all the files with staged changes, with the following caveats:

Easily review changes that are made, comparing to what was staged already, approve formatting-only changes on a case-by-case basis.
Support the workflow where you manually stage a few lines at a time, leaving other changes untouched.

Currently, with automatic git-add, someone trying to do this will lose the selections they made.

Currently looking for this myself.

@SchadtJ did you get anywhere with this? If not, I might take a swing in the coming weeks.

Some linters like clang-format, black, etc. return non-zero exit code after they have applied fixes. Since, lint-staged automatically do git add only if command returns with zero exit code, instead of adding them automatically, it reverts them with the staged changes and applied fixes vanish at all. One option is to use --no-stash option but --no-add feels superior to it as we can always inspect changes made by linters before adding them to git and also have the stash backup.

The thing about using a potential --no-add is that it would mean the commit that lint-staged ran on would be potentially not "pretty". One would have to do a second commit for fixing it. Then they're not really atomic commits in some sense...
Just something to consider.

Any news on this? I come from pre-commit world and I can't understand how I can trust eslint to not mess up some things.
Prettier is ok but I can't use ESLint like this...

Strongly agree with a need for such an option. Just starting to use lint-staged with husky (pre-commit) and it feels imperative that even if the workflow speeds things up, the developer can still review the changes that the automated tools have introduced, and only then - create a commit.
The ideal workflow would be:

developer stages files for commit
developer commits code
pre-commit hook runs lint-staged
now, depending on the result:
a) if one of the commands returned a non-zero code, any changes are reverted and the commit is aborted
b) if no commands return a non-zero code, but there are new changed files (due to e.g. eslint --fix or prettier --write), the commit is aborted but the new changes are not reverted. The developer can then review the changes, stage them together with the initial changes, and commit again - which restarts the logic from point 1.
c) if all commands return 0, and no additional files were modified, the commit is created as usual.

This would help avoid creating commits that contain potentially unwanted changes, that the developer might not even realise are in the commit.

@mz8i your suggestion seems to work a bit differently than the original proposal. It would also require us to diff all staged files before/after running linters in order to be able to detect new changes.

You should be able to review the changes added at the commit message step. At least that’s what works well for me. I don’t see a reason to complicate the workflow any further. I guess an option to abort instead of adding to stage could still be added but I’ll leave it to @iiroj

We would just have to make sure to define everything well. IMO one way to introduce these could be:

--no-add = logic works as before, but linter changes are left unstaged. Commit is aborted if linters exit with code 1, and state is reset.
--abort = with exit code 1, lint-staged aborts without resetting state, leaving it as-is. This would mess up partially staged files because the unstaged changes would be left hidden.

I'm not totally sure if these would actually be useful or not. All my teams have used lint-staged in check-only mode together with editors' "fix on save" features.

We already have --no-stash which disables the backup stash logic and by extension, reset on failure.

Yeah that’s what I mean. It’s probably not worth adding more logic to the library at at point. If you don’t trust the linter, don’t let them modify your code in lint-staged config. And if that’s not enough, bypass the stash / add with —no-stash completely.

Maybe --no-stash could have an alias to --abort, because that's what it basically does and might be a bit clearer?
  --no-stash                         disable the backup stash, and do not revert in case of errors

I don't want to sound purist. I'd like to refocus the ticket back at my request.
All I ask from lint-staged is to do this:
diff --git a/bin/lint-staged.js b/bin/lint-staged.js
index f1ae6ab..4eec100 100755
--- a/bin/lint-staged.js
+++ b/bin/lint-staged.js
@@ -71,6 +71,12 @@ cli
       'disable the backup stash, and do not revert in case of errors'
     ).default(false)
   )
+  .addOption(
+    new Option(
+      '--no-add',
+      'do not run `git add`'
+    ).default(false)
+  )

 cli.option('-q, --quiet', 'disable lint-staged’s own console output', false)

@@ -103,6 +109,7 @@ const options = {
   relative: !!cliOptions.relative,
   shell: cliOptions.shell /* Either a boolean or a string pointing to the shell */,
   stash: !!cliOptions.stash, // commander inverts `no-<x>` flags to `!x`
+  add: !!cliOptions.add, // commander inverts `no-<x>` flags to `!x`
   verbose: !!cliOptions.verbose,
 }

diff --git a/lib/index.js b/lib/index.js
index 7fdbebc..8345cd1 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -77,6 +77,7 @@ const lintStaged = async (
     shell = false,
     // Stashing should be disabled by default when the `diff` option is used
     stash = diff === undefined,
+    add = true,
     verbose = false,
   } = {},
   logger = console
diff --git a/lib/runAll.js b/lib/runAll.js
index 7377b23..5a1efce 100644
--- a/lib/runAll.js
+++ b/lib/runAll.js
@@ -79,6 +79,7 @@ export const runAll = async (
     shell = false,
     // Stashing should be disabled by default when the `diff` option is used
     stash = diff === undefined,
+    add = true,
     verbose = false,
   },
   logger = console
diff --git a/lib/state.js b/lib/state.js
index 30f63c9..b7b7f5a 100644
--- a/lib/state.js
+++ b/lib/state.js
@@ -23,6 +23,10 @@ export const hasPartiallyStagedFiles = (ctx) => ctx.hasPartiallyStagedFiles
 export const applyModificationsSkipped = (ctx) => {
   // Always apply back unstaged modifications when skipping backup
   if (!ctx.shouldBackup) return false
+
+  // Do not apply modifications if `--no-add` is added
+  if (!ctx.add) return false
+
   // Should be skipped in case of git errors
   if (ctx.errors.has(GitError)) {
     return GIT_ERROR

I would've started the MR immediately (and hopefully you'd have a comprehensive testing suite) - but I wasn't able immediately able to come up with the patch. Also, since this might be a "breaking case" of your utility, and I wanted to ask.
... Also, I may not be able to modify my lint-staged husky script - so I might want to expose this (and/or) via an environment variable (e.g. LINT_STAGED_NO_GIT_ADD?).

@stdedos Anything update about the "--no-add" pull request ?
I am looking forward to it.


Dependency error on deploy

When trying to run sst deploy with verbose logging I am receiving these errors:
level=INFO msg="esbuild building"
level=ERROR msg="esbuild error" text="Could not resolve \"path-to-regexp\"" location.file=.sst/platform/src/components/cloudflare/remix.ts location.line=3 column=29
level=ERROR msg="esbuild error" text="Could not resolve \"@pulumiverse/vercel\"" location.file=.sst/platform/src/components/vercel/dns.ts location.line=34 column=24
|  Error       .sst/platform/src/components/cloudflare/remix.ts:3:29: Could not resolve "path-to-regexp"
.sst/platform/src/components/vercel/dns.ts:34:24: Could not resolve "@pulumiverse/vercel"

level=ERROR msg="exited with error" err=".sst/platform/src/components/cloudflare/remix.ts:3:29: Could not resolve \"path-to-regexp\"\n.sst/platform/src/components/vercel/dns.ts:34:24: Could not resolve \"@pulumiverse/vercel\""
×  Unexpected error occurred. Please check the logs or run with --verbose for more details.

can you try deleting your .sst folder and see if that helps?

I'm so dumb. Shockingly, trying to run this in a directory that has a : in the name does all sorts of horrible things to your linux path!
Works great once you stop being dumb, thanks.


Add file upload component

Description
Add a file upload component, for example, as in PrimeVue https://primevue.org/fileupload/
Additional context

Hi @karyna4k
Did you see this?
https://ui.nuxt.com/components/input#type

Hi @moshetanzer
Yes, I saw it, but it would be nice to have a ready component with drag-drop and other useful features.
It's just a thought on how we could make things better.

Upvote.
Having a feature-rich file field component is one of the most essential requirements for NuxtUI.
In my opinion, the current file field has significant room for improvement.
It should support drag-and-drop functionality, allow for UI customization, and include built-in features for validation.
The file field components in PrimeVue or Vuetify serve as excellent examples of what a feature-rich file component should look like.

I have already built one using Nuxt UI 2, I will take a look at it and see if I can migrate it to v3.

It would've great if the upload component have an image preview too, since it's one of a common case to happen

I working on it @ezmemoar

Hi @rdjanuar thanks for the response
Just a suggestion, maybe it will be better to show the image in large size like naive-ui? what do you think?

I think I won't create it exactly like that, but I might add composables later, so you can create custom components as shown  @ezmemoar

Ok that's great to know. Thanks.

agree - need this!


feature request

Issue Type: Feature Request
please add a feature to search between stored procedures and tables name . thanks
Azure Data Studio version: azuredatastudio 1.35.1 (fab63efd307e54c063c8af03474bbb5d77f5fd11, 2022-03-15T18:03:38.261Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

Duplicate of https://github.com/microsoft/azuredatastudio/issues/12932


Input window history actions mappings conflict with nvim-cmp

Input windows provide key actions to browse input history by showing next/previous history item upon key press.
Standard mappings for these actions are <C-n> and <C-p>, which also happen to be standard mappings used by nvim-cmp.
These mappings conflict in the insert mode.
This is reproducible in the input window that sends code to the REPL (bound to <LocalLeader>si by default).
Since nvlime's documentation mentions the usage of nvim-cmp it would be helpful to also mention that this conflicting situation is likely to arise.
One solution to this problem is to provide additional configuration for nvim-cmp that takes care to fall through when nvlime's input window is active (this can be determined from the b:nvlime_input variable).
cmp.setup.filetype('lisp', {
  sources = {
    { name = 'nvlime' },
  },

  mapping = {
    ['<C-n>'] = cmp.mapping(function(fallback)
      if vim.b.nvlime_input then
        fallback()
      elseif cmp.visible() then
        cmp.select_next_item()
      else
        fallback()
      end
    end, {'i'}
    ),

    ['<C-p>'] = cmp.mapping(function(fallback)
      if vim.b.nvlime_input then
        fallback()
      elseif cmp.visible() then
        cmp.select_prev_item()
      else
        fallback()
      end
    end, {'i'}
    ),
  }
})

You can change any mappings of the plugin :h nvlime-mappings. Documentation can be improved for sure, but it is input table.


Allow an easy way to turn the analytics library on and off at runtime

There should be an easy way to disable/re-enable analytics at runtime, so it can be toggled with ie a checkbox (like in Etcher). Corvus handles this by taking a callback at initialization that will check before sending any event. If the callback the user passes resolves to false, we need to make sure we don’t send any requests at all. This was a pain point in Etcher, since it looks like Mixpanel will still send some requests to check configuration and some other stuff even if we explicitly disable it

Closing stale issues


REALLY annoying to work with messages

Well, I've seen some people having this problem before, so I'll just point out the issue.
Yes I know, there are documentation pages out there explaining how to set up the CMakeLists.txt to reinforce message dependency or message headers dependencies from one package to another, or messages from the same package, etc. I know in case I get some fatal error: message_package/msg.h: No such file or directory #include "message_package/msg.h" I might just go read them all again and spend an hour trying the different combinations of solutions until it compiles.
But please, could you make this a little simpler? It's almost as annoying as mandatory windows upgrades. Just build the goddamn msg headers first or something.

Thanks for the feedback. It sounds like you've seen the documentation, but want to write less CMake code to generate and depend on messages. I'm not sure which part of the process you would like simplified. Please consider submitting a pull request with the changes you would like to see.
For anyone coming across this looking for documentation:

http://wiki.ros.org/catkin/CMakeLists.txt
http://docs.ros.org/kinetic/api/catkin/html/howto/format2/cpp_msg_dependencies.html
https://cmake.org/cmake/help/v3.0/command/include_directories.html
https://cmake.org/cmake/help/v3.0/command/add_dependencies.html

Also, there is catkin_lint that does static analysis on your cmake files to check for common errors. Not sure if in your case it would detected the issue, but you could give it a try.

The current documentation on this topic is pretty detailed. Also the example code generated for new packages contains a lot of helpful information in the CMake file. Therefore I will close this ticket for now since there is simply not enough information to act on. Please feel free to propose specific improvements here and the issue can be reopened. Even better would be to contribute them directly with a pull request.

Use catkin_tools instead of catkin_make

An isolated build (which can also be done with catkin_make_isolated only addresses the problem for cross-package target dependencies. Within a single package an explicit declaration of the target dependencies is still necessary.

An isolated build (which can also be done with catkin_make_isolated only addresses the problem for cross-package target dependencies. Within a single package an explicit declaration of the target dependencies is still necessary.

This doesn't arise if you also follow my suggestion 2. Or am I mistaken?

Only define messages in pure message packages (i.e. packages which only have messages and no code).

Yes, this avoids the problem of target dependencies within one package. When using catkin_make it still has the cross-package dependency problem though.


Added newline after modules print

World's simplest pull request...
Feature enhancement issue was created by me that has all the details: https://github.com/fastfetch-cli/fastfetch/issues/989
Not sure why, but the newline was not working in flashfetch.c after module printing, but worked in init.cs ffFinish() method.
Built and tested on macOS, attached is a screenshot with the behavior showing the newline:

No. There are many ways to print a newline. However if you hard coded it into fastfetch, it's not easy to remove it.

Valid, as it's preferential and someone might want it to run up against their shell greeting or prompt.


The provided value for 'model' is not valid for provider [tenants]

First of all, congratulations on the 1.0-alpha release! This project shows a lot of potential, and I truly appreciate the effort you’ve put into it.
I’ve been experimenting with it and encountered an error I can’t seem to resolve. I’ve installed the package and configured it for subdomain tenancy with an Eloquent model. Here’s my multitenancy.php configuration file:
<?php

use Sprout\TenancyOptions;

return [

    /*
    |--------------------------------------------------------------------------
    | Multitenancy Defaults
    |--------------------------------------------------------------------------
    |
    | This option defines the default tenancy, tenant provider and identity
    | resolver for your application.
    | You may change these values as required, but they're a perfect start
    | for most applications.
    |
    */

    'defaults' => [

        'tenancy'  => 'tenants',
        'provider' => 'tenants',
        'resolver' => 'subdomain',

    ],

    /*
    |--------------------------------------------------------------------------
    | Tenancies
    |--------------------------------------------------------------------------
    |
    | Next, you may define every tenancy type for your application.
    | If you only have one type of tenancy within your application, which will
    | be the case for most people, you can leave it at one.
    |
    | All tenancies have a tenant provider, which defines how the
    | tenants are actually retrieved out of your database or other storage
    | system used by the application.
    |
    | Tenancies can also have options, which is an array of options provided
    | by the TenancyOptions class that lets you fine tune the tenancies
    | behaviour.
    |
    */

    'tenancies' => [

        'tenants' => [
            'provider' => 'tenants',
            'options'  => [
                TenancyOptions::hydrateTenantRelation(),
                TenancyOptions::throwIfNotRelated(),
            ],
        ],

    ],

    /*
    |--------------------------------------------------------------------------
    | Tenant Providers
    |--------------------------------------------------------------------------
    |
    | All tenancies have a tenant provider, which defines how the
    | tenants are actually retrieved out of your database or other storage
    | system used by the application.
    |
    | If you have multiple tenant tables or models, you can configure multiple
    | providers to represent each.
    | These providers may then be assigned to any extra tenancies you have defined.
    |
    | Supported: "database", "eloquent"
    |
    */

    'providers' => [

        'tenants' => [
            'driver' => 'eloquent',
            'model'  => \App\Models\TenantModel::class,
        ],

        // 'backup' => [
        //     'driver' => 'database',
        //     'table'  => 'tenants',
        // ],

    ],

    /*
    |--------------------------------------------------------------------------
    | Identity Resolvers
    |--------------------------------------------------------------------------
    |
    | Where Laravel's auth would have a separate guard for each way that a
    | user can be authenticated in a request (think session, header, etc.),
    | Sprout abstracts this out into identity resolvers.
    | This means that all tenancies within the application can use all
    | configured resolvers.
    |
    | If you have multiple ways that tenant can be identified, say, through
    | subdomain and then a HTTP header for APIs, you can define one for each.
    |
    | There are sensible defaults for each supported driver, though it is
    | recommended that you remove any that you don't need, for simplicity
    | sake.
    |
    | Supported: "subdomain", "header", "path", "cookie" and "session"
    |
    */

    'resolvers' => [

        'subdomain' => [
            'driver'  => 'subdomain',
            'domain'  => 'tenancy.test',
            'pattern' => '.*',
        ],
    ],

];

My tenant model looks like this:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use Sprout\Database\Eloquent\Concerns\IsTenant;
use Sprout\Contracts\Tenant;

class TenantModel extends Model implements Tenant
{
    use IsTenant;

    protected $table = 'tenants';

    protected $fillable = [
        'name',
        'identifier',
        'resource_key',
    ];
}

Then, I've set up the route like this:
Route::tenanted(function () {
    Route::middleware('guest')->group(function () {
        Route::get('login', [AuthenticatedSessionController::class, 'create'])->name('tenant.login');
    });
});

Then when I try to access let's say, example.tenancy.test/login I get this error, I've traced and it's being raised by the createEloquentProvider function. The db has a record with the tenant, and I've also tried to add the getTenantKeyName and the getTenantIdentifierName but doesn't work, probably because I'm doing something wrong.
Sprout\Exceptions\MisconfigurationException
The provided value for 'model' is not valid forprovider [tenants]

Appreciate if you can give me a hand here to keep playing with it, thanks!

Hello @endikainchaurtieta, apologies for the delay, but I was quite severely ill last week.
Did you manage to solve this? That particular error is thrown by the following code:
if (
    ! class_exists($config['model'])
    || ! is_subclass_of($config['model'], Model::class)
    || ! is_subclass_of($config['model'], Tenant::class)
) {
    throw MisconfigurationException::invalidConfig('model', 'provider', $name);
}

Which means that the exception is only thrown if one of the following conditions isn't met.

The provided class exists as an autoloadable class.
The provided class is a descendant of the Illuminate\Database\Eloquent\Model class.
The provided class implements Sprout\Contracts\Tenant, either directly or indirectly.

From what you've provided, I don't see why that wouldn't be the case, but the only way I can recreate this locally is if I force one of those conditions to not be met.

Hey @ollieread, apologies for the delayed response! It turned out to be an autoloading issue. I’m using a modular directory structure, and PSR-4 was expecting capitalized folder names. It seems to be working fine now. I'm really excited about this project and will gladly share any feedback or progress. Happy to help and contribute!


Installation of stuff in requirements.txt

(For ubuntu)
While installing psycopg2==2.6.2 as per requirements.txt (pip install requirements.txt), you might get an error like this:
Error: pg_config executable not found
This is solvable by running:
sudo apt install libpq-dev python3-dev (python3, and ubuntu 16.04. If you are using 14.04, use apt-get)
then when you do pip install, it works fine.

Thanks.


feat(icon): Adding missing cog icon alias, fix SUI.js

Cog icon (alias of single gear) is missing in current list

Codecov Report

Merging #2766 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2766   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files         160      160
  Lines        2762     2762
=======================================
  Hits         2755     2755
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed935f8...2ac1ff1. Read the comment docs.

Just realized that, it may be need SUI 2.3.x

Just realized that, it may be need SUI 2.3.x

Yep.  This is done in our next branch.  Closing as a dupe of #2657.


Fixed ProjectionCommand dispose / using bug

Fixes https://github.com/JasperFx/marten/issues/2450

Is there any way to run / create a unit-test for this?

Not a unit test. I think this would require something with a lot of data to try to reproduce the issue. I'm comfortable taking this in as is.


Fix bug for exporting PDF and HTML

There was a bug in the Nessus export functionality to HTML and PDF.
Now fixed with this pull request

Thanks @blabla1337 much appreciated!


test: bsim: Notification EATT test

Increasing the test coverage of notification on EATT bearers.

test implementation

Signed-off-by: Alexandru Carbuneanu<EMAIL_ADDRESS>

@jhedberg can you pls have a look at this PR?

@CarbuneanuAlexandru please rebase

@jhedberg can you please approve again ?


Black screen

after updating the container on synology nas the the login screen is all black

Could you provide the following information:

Output of docker logs crashplan-pro.  Replace crashplan-pro by the name of your container.
Output of docker inspect crashplan-pro.  Replace crashplan-pro by the name of your container.
The following files, found in the directory you mapped to /config:

log/ui_app.log
log/ui_error.log
log/ui_output.log

On Synology I updated my CrashPlan container to the latest version and I seem to have the same issue: I can see the navigation bar but the rest of the screen is just black.
The docker log is as follows:
23/09/2018 19:11:53 client_count: 0
23/09/2018 19:11:53 Restored X server key autorepeat to: 1
23/09/2018 19:11:53 Client <IP_ADDRESS> gone
23/09/2018 19:11:53 Statistics             events    Transmit/ RawEquiv ( saved)
23/09/2018 19:11:53  ServerCutText       :      1 |         8/        8 (  0.0%)
23/09/2018 19:11:53  FramebufferUpdate   :      1 |         0/        0 (  0.0%)
23/09/2018 19:11:53  LastRect            :      1 |        12/       12 (  0.0%)
23/09/2018 19:11:53  tight               :      1 |        16/  3932172 (100.0%)
23/09/2018 19:11:53  RichCursor          :      1 |      1374/     1374 (  0.0%)
23/09/2018 19:11:53  TOTALS              :      5 |      1410/  3933566 (100.0%)
23/09/2018 19:11:53 Statistics             events    Received/ RawEquiv ( saved)
23/09/2018 19:11:53  FramebufferUpdate   :      2 |        20/       20 (  0.0%)
23/09/2018 19:11:53  SetEncodings        :      1 |        56/       56 (  0.0%)
23/09/2018 19:11:53  SetPixelFormat      :      1 |        20/       20 (  0.0%)
23/09/2018 19:11:53  TOTALS              :      4 |        96/       96 (  0.0%)
23/09/2018 19:11:53 Got connection from client <IP_ADDRESS>
23/09/2018 19:11:53   other clients:
23/09/2018 19:11:53 Got 'ws' WebSockets handshake
23/09/2018 19:11:53 Got protocol: binary
23/09/2018 19:11:53   - webSocketsHandshake: using binary/raw encoding
23/09/2018 19:11:53   - WebSockets client version hybi-13
23/09/2018 19:11:53 Disabled X server key autorepeat.
23/09/2018 19:11:53   to force back on run: 'xset r on' (3 times)
23/09/2018 19:11:53 incr accepted_client=2 for <IP_ADDRESS>:36696  sock=10
23/09/2018 19:11:54 Client Protocol Version 3.8
23/09/2018 19:11:54 Protocol version sent 3.8, using 3.8
23/09/2018 19:11:54 rfbProcessClientSecurityType: executing handler for type 1
23/09/2018 19:11:54 rfbProcessClientSecurityType: returning securityResult for client rfb version >= 3.8
23/09/2018 19:11:54 Pixel format for client <IP_ADDRESS>:
23/09/2018 19:11:54   32 bpp, depth 24, little endian
23/09/2018 19:11:54   true colour: max r 255 g 255 b 255, shift r 16 g 8 b 0
23/09/2018 19:11:54 no translation needed
23/09/2018 19:11:54 Enabling NewFBSize protocol extension for client <IP_ADDRESS>
23/09/2018 19:11:54 Enabling full-color cursor updates for client <IP_ADDRESS>
23/09/2018 19:11:54 Using image quality level 6 for client <IP_ADDRESS>
23/09/2018 19:11:54 Using JPEG subsampling 0, Q79 for client <IP_ADDRESS>
23/09/2018 19:11:54 Using compression level 9 for client <IP_ADDRESS>
23/09/2018 19:11:54 Enabling LastRect protocol extension for client <IP_ADDRESS>
23/09/2018 19:11:54 rfbProcessClientNormalMessage: ignoring unsupported encoding type Enc(0xFFFFFECC)
23/09/2018 19:11:54 Using tight encoding for client <IP_ADDRESS>
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
[app] starting CrashPlan...
Can I DM you the other log files here? Thanks!

Yes, I would need you to attach the same log files as requested in my previous comment.

The logs probably contain a lot of sensitive information. How can I send you the logs without posting them here publicly?

Since the application is crashing in a loop, you can look at the log files yourself and provide the error messages that are repeated.

Can you provide the output of docker inspect [container name]?

Oh you are running the HOME version, not the PRO version.
This git repository is for the PRO version.  Sorry I got confused.
I can reproduce the issue with the HOME version.  I'm looking at this...

Oh, sorry about the confusion. But it’s good that you can repro the issue on your end. Thanks for your help!

New image is available with the fix :)

Works, awesome! Thank you :-D


Change GA4 contents list type

What
Change GA4 attributes for the contents list component from type content to type contents list.
Why
We want more specific types when tracking different kinds of interactions.
Visual Changes
None.
Trello card: https://trello.com/c/kPQBqdSw/675-change-contents-navigation-selectcontent-event-types-to-contents-list

@AshGDS good spot. I don't think that list could be easily switched to using the gem component as it has some custom JS associated with it to highlight where you are in the page as you scroll. Since it's not technically the gem component I'll ask the PAs if they want this also changed to match, and raise a separate PR if so.


add on_change event for model: gr.Radio to control visibility of Melody: gr.Audio

add on_change of model for gr.Audio named Melody
when model == "melody", the Melody Audio Component would be visible, otherwise it's hidden.

Hi @HaiyiMei!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at<EMAIL_ADDRESS>Thanks!

I registered, please check.

This is now conflicting due to the major changes introduced with version 1.0.0.
In any case, the logic in the demo is a bit complex, combining both a batch and non batch version, and this is a mostly cosmetic change, given we have no automated test on the demo, we won't accept such a change in the future.


Structure generated not properly

Mod Loader
1.19.2 Forge 43.4.0
Mod version
2.35.1
Issue description
The structure generated not correctly.(A giant floating object) Use "What structure is this" mod shows goety:crypt.
Before:

After remove the mod:

However thing good while use /place command.
the mod Terralith applied. Seems cause by it.
Link or Post Log Files
No response
Steps to reproduce
No response
Additional information
No response

Crypt structure generation has been changed from Goety 2.36.1 and up to not modify the surrounding/ground above.


vim: better way to get a list of available plugins

Fixes #387

I fixed the XMLization of the < and > characters in <nixpkgs> and rebased to master in 6eea2a409e56d23f1e3f703afb3aa0527d1cc8e7. Thanks!

Thanks :)


Supplies tracker

Works like a loot tracker, except it tracks all supplies you use so you know exactly how much you spend in supplies on your trips. Have the tracker keep track of how much food you consume, pots you sip, arrows/darts you use ect. Maybe even able to keep track of things like how many zulrah scales your blowpipe and serp helm have used

Duplicate of #6700


Could not find module in path: 'dom-helpers/transition/properties'

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Clean installation of react-swipeable-views can be used with the example from the README.
Current Behavior

ModuleNotFoundError
Could not find module in path: 'dom-helpers/transition/properties' relative to '/node_modules/react-swipeable-views/lib/SwipeableViews.js'

Seems to have been introduced by https://github.com/oliviertassinari/react-swipeable-views/pull/556
Steps to Reproduce (for bugs)

https://codesandbox.io/s/dreamy-euler-xifo5
Context

We had to lock our version of react-swipeable-views to a previous version to fix our build.
Your Environment

Tech
Version

react-swipeable-views
0.13.4

React
16.12.0

No idea why this was closed. I just updated and got this error.

Are you using the latest release?

@oliviertassinari  if you mean by "latest release" to install via "yarn add<EMAIL_ADDRESS>then, yes, I tried the latest release. Going back to 0.13.4 did not help either, so I finally reinstalled 0.13.3 and it worked again.
In other words, I can't upgrade this module because it breaks my app otherwise.

@yanickrochon Something is off in your env, proof: https://codesandbox.io/s/x8x11zjmp.

Well, since it works with 0.13.3, and not with any other, what did change?

@yanickrochon Hopefully it will work for your project in the next release :).


Autorest Regen Preview to 3.0.0-alpha.20230905.4 by Dapeng Zhang from refs/pull/3483/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/3483

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.ChangeAnalysis


Starlight

Short description

Brigmedic glasses for DT because they'd get flashed with their sechud
Why we need to add this

Media (Video/Screenshots)

Checks

[ ] I do not require assistance to complete the PR.
[x] Before posting/requesting review of a PR, I have verified that the changes work.
[x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
[x] I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.

Changelog

:cl: Aedler

tweak: Changed deathsquad sechud to brigmedic glasses.

Added an implant, but i don't know what to do with it. Its my first PR

Added an implant, but i don't know what to do with it. Its my first PR

unluck, but you need to use C# for adding Implants addition in start gear, maybe i write this thing in feuture.


Long-running WebSocket connection stops sending data

I have the following code listening for trade matches:
webSocket.on('message', data => {
  if (data.type === 'match') {
    // Trade occurred
    console.log(`${data.side} ${data.size} ${data.product_id} @ ${data.price} @ ${data.time}`);
});

After a variable amount of time (typically a few hours), the socket stops receiving any messages. I have not seen any errors.
Any idea what might be going on? The setup is as followes:
const Gdax = require('gdax');

const products = {
  'BTC-USD': { vol: 0 },
  'ETH-USD': { vol: 0 },
  'LTC-USD': { vol: 0 },
  'BTC-EUR': { vol: 0 },
  'ETH-EUR': { vol: 0 },
  'LTC-EUR': { vol: 0 },
  'BTC-GBP': { vol: 0 },
  'ETH-GBP': { vol: 0 },
  'ETH-BTC': { vol: 0 },
};
const webSocket = new Gdax.WebsocketClient(Object.keys(products));

We terminate the connection shortly after deploying the feed service.

(or rather: this library should handle that properly)

:+1:
Until then, what would be the timeframe to reconnect after? Seconds? And what can be done about the missed messages during that timeframe?

@meteorpublish I also noticed this and have implemented the following logic to auto-reconnect:
// if it closes reconnect
websocket_client.on('close', (data) => {
    log_message('ERROR', 'Websocket Error', `websocket closed unexpectedly with data: ${data}. Attempting to re-connect.`);

    // try to re-connect the first time...
    websocket_client.connect();

    let count = 1;
    // attempt to re-connect every 30 seconds.
    // TODO: maybe use an exponential backoff instead
    const interval = setInterval(() => {
        if (!websocket_client.socket) {
            count++;

            // send me a email if it keeps failing every 30/2 = 15 minutes
            if (count % 30 === 0) {
                const time_since = 30 * count;
                log_message('CRIT', 'Websocket Error', `Attempting to re-connect for the ${count} time. It has been ${time_since} seconds since we lost connection.`);
            }
            websocket_client.connect();
        }
        else {
            clearInterval(interval);
        }
    }, 3000);
});


Leading characters in German Strings not capitalized correct

In german language the leading characters of capitalized german strings are not capitalized.
To Reproduce
Simply select german language
Screenshots

**Desktop **

OS: Win10
Browser: Firefox, Chrome

All our translations come from crowdin. Please propose the change there. Here are the instructions: https://makecode.com/translate

@abchatra
As you can see, the strings are capitalized in crowdin but are not rendered correct in the Makecode Menus!

Only Math is capitalized correct.

Perhaps interesting for you: same bug in makecode for microbit regarding the actuell Beta.

We might programmatically lower case the block strings.

This is the problem: https://github.com/microsoft/pxt/blame/2162d160d11bc700e495a51da3477e70a5c27f2c/pxtlib/blocks.ts#L103

now works correct in https://arcade.makecode.com/beta


Train on full GQA dataset

hi, I currently work on this dataset.
I followed the guide and successfully train on Data1.2.zip and CLEVR version.
but now I want to train on the full Dataset from the website (70G).

Is Dataset1.2.zip a small subset of which on the website, or it has all questions and images (just remove some unnecessary part)?
if yes, then what should I do to run on "full" dataset with the baseline model?

thanks for your great work

Hi, thanks a lot for the interest in the dataset!
dataset1.2 contains all the questions. The reason why the dataset on the website is bigger is mainly the image features, which we handle in the repository in the "Feature extraction" section (they are in a different zip file outside of dataset1.2).
However, the default settings make the model run on the "balanced" training set, which is a subset of the whole training data (1M out of 14M training samples) with reduced biases in questions etc. Regardless of what the models are being trained on, the test (in the challenge etc) is performed only on the balanced test set (so that models can't cheat by exploiting question biases). In experiments I've done I saw that baselines get no performance improvement on the balanced test set when training on the full training set (14M) instead of the balanced training set (1M).
However, if you would like to train on the full dataset, all that is needed to do is to pass the following flag: --dataSubset all.
(note: in that case epoch time will get to be about 10-12hours as each epoch will run over 14M questions).
Hope it helps! Please let me know if you have any other questions!

I think I get the point, will keep trying
thanks a lot :)

happy to help! :)


Bump pyo3

Fixes #152

@clin1234 Your changes look good, but if I'm reading the failure output correctly, it looks like pydantic-core==2.18.2 doesn't distribute a pre-built wheel for 3.13, and it needs an incompatible version of pyo3 (0.21.1). This requirement must be coming from pydantic which we have as a floating version.
I would recommend upping our pydantic version requirement when python_version is 3.13, since the latest version of pydantic and pydantic-core seem to be using a later version of pyo3.

I do not know where that specific version of pydantic-core is pulled from: latest release is https://github.com/pydantic/pydantic-core/releases

Perhaps you should setup dependabot support so that manual updates to dependencies won't be necessary...

Perhaps you should setup dependabot support so that manual updates to dependencies won't be necessary...

We may in the future, but the change you are trying to make here is purely to support Python 3.13, which is a beta release and not a target version that Tach supports today, so I don't think Dependabot would have changed anything here.
Your latest commit updates the dev requirements, but the issue here is the package requirement in pyproject.toml:
"pydantic~=2.0"
This dependency is purposefully loose so that we can avoid unnecessary conflicts in users' Python projects, since pydantic is a very common dependency. Upgrading it to force a late enough version of pydantic-core to support the beta release of Python 3.13 is not a good tradeoff in general, so the only reasonable change I could see here is a specific version upgrade when the detected python version is 3.13 or higher. You can see an example of using the python version to specify dependencies also in pyproject.toml:
    "stdlib-list>=0.10.0; python_version < '3.10'",
    "eval-type-backport>=0.2.0; python_version < '3.10'"

If you can specify a workable version range for Python 3.13 and avoid impacting other users, that would work.

Perhaps you should setup dependabot support so that manual updates to dependencies won't be necessary...

We may in the future, but the change you are trying to make here is purely to support Python 3.13, which is a beta release and not a target version that Tach supports today, so I don't think Dependabot would have changed anything here.
Your latest commit updates the dev requirements, but the issue here is the package requirement in pyproject.toml: "pydantic~=2.0"
This dependency is purposefully loose so that we can avoid unnecessary conflicts in users' Python projects, since pydantic is a very common dependency. Upgrading it to force a late enough version of pydantic-core to support the beta release of Python 3.13 is not a good tradeoff in general, so the only reasonable change I could see here is a specific version upgrade when the detected python version is 3.13 or higher. You can see an example of using the python version to specify dependencies also in pyproject.toml:
    "stdlib-list>=0.10.0; python_version < '3.10'",
    "eval-type-backport>=0.2.0; python_version < '3.10'"

If you can specify a workable version range for Python 3.13 and avoid impacting other users, that would work.

I haven't modified pyproject.toml, where most users would find a suitable version of pydantic; I only bumped the version of pydantic within the dev requirements, in order to fix a specific dep for building on 3.13 through CI. This shouldn't impact the workflow of a casual user.

I haven't modified pyproject.toml, where most users would find a suitable version of pydantic; I only bumped the version of pydantic within the dev requirements, in order to fix a specific dep for building on 3.13 through CI. This shouldn't impact the workflow of a casual user.

I see what you're saying - all Rust dependencies should be build-time/dev dependencies assuming we pre-build wheels for all supported environments. In that case, there may be another change required to the publish workflow. It uses the --find-interpreter option to determine which Python interpreters it will build wheels for. This depends on the interpreters installed in our GitHub Actions runner, which I believe are shown here: https://github.com/gauge-sh/tach/actions/runs/9848383661/job/27190215219#step:4:394
This means we will not build wheels for 3.13, so if you are planning to use this version you'll need to manage the Rust toolchain on your local machine as well - or you'll need to modify the publish.yml to setup Python 3.13 (and also it looks like we are missing 3.7)
I'm happy to merge this as-is and deal with the wheel change separately, or if you want to make the GHA change and use this branch that's fine too!

Good enough. I'll make the publish.yml change in a different branch


i18n(zh-cn): Translate images.mdx

What kind of changes does this PR include?

Translated content

Description

Translate images.mdx

So excited for this @liruifengv !
Heads up that I made another commit with some changes to three of the migrate-to/from- guides: https://github.com/withastro/docs/pull/3739/commits/58feb02f562be4bd0f113617b287ec25614079d7
Then, there were some small conflict fixes in the following commits.

So excited for this @liruifengv !↳
Heads up that I made another commit with some changes to three of the migrate-to/from- guides: https://github.com/withastro/docs/pull/3739/commits/58feb02f562be4bd0f113617b287ec25614079d7↳
Then, there were some small conflict fixes in the following commits.↳

Done!


Improvements to PowerShell script recognizing Functions <4 version

The current script to identify functions apps requiring an upgrade can be improved upon. It assumes it will analyze one subscription at a time as well as only identify if the Azure Function is of v3.
The current script:
$Subscription = '<YOUR SUBSCRIPTION ID>'

Set-AzContext -Subscription $Subscription | Out-Null

$FunctionApps = Get-AzFunctionApp

$AppInfo = @{}

foreach ($App in $FunctionApps)
{
     if ($App.ApplicationSettings["FUNCTIONS_EXTENSION_VERSION"] -like '*3*')
     {
          $AppInfo.Add($App.Name, $App.ApplicationSettings["FUNCTIONS_EXTENSION_VERSION"])
     }
}

$AppInfo

Proposed changes, I could not located the original script source:
 $subscriptions = Get-AzSubscription
$AppInfo = @{}
  foreach ($s in $subscriptions) {

Set-AzContext -Subscription $s| Out-Null

$FunctionApps = Get-AzFunctionApp

foreach ($App in $FunctionApps)
{
     if ($App.ApplicationSettings.FUNCTIONS_EXTENSION_VERSION.Substring(1,1) -le 3)
     {
  $Row = "" | Select Subscription,FunctionName,Location,FunctionVersion
  $Row.FunctionName = $App.Name
  $Row.Location = $App.Location
  $Row.Subscription = $App.SubscriptionId
  $Row.FunctionVersion=  $App.ApplicationSettings.FUNCTIONS_EXTENSION_VERSION.Substring(1,1)
  $AppInfo+= $Row
     }
}
}
$AppInfo

PowerShell is not my expertise so feel free to adjust as needed.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bc6841ed-301e-a134-b76a-40f8ff96a2bf
Version Independent ID: 0a53f3bd-baf6-af8a-e36b-fe2b2632b98b
Content: Migrate apps from Azure Functions version 3.x to 4.x
Content Source: articles/azure-functions/migrate-version-3-version-4.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@JFolberth
Thanks for your feedback! We will investigate and update as appropriate.

This document is specifically for V3 to V4  , so I am suggesting the below snippet so that all the subscriptions associated with the tenant can be reviewed
$subscriptions = Get-AzSubscription
foreach ($s in $subscriptions) {
Set-AzContext -Subscription $s| Out-Null
$FunctionApps = Get-AzFunctionApp
$AppInfo = @{}
foreach ($App in $FunctionApps)
{
if ($App.ApplicationSettings["FUNCTIONS_EXTENSION_VERSION"] -like '3')
{
$AppInfo.Add($App.Name, $App.ApplicationSettings["FUNCTIONS_EXTENSION_VERSION"])
}
}
$AppInfo
}

I have suggested the changes. It will be published soon. Closing this issue for now. Feel free to reopen if required

@MughundhanRaveendran-MSFT  the article says the script should:
Use the following PowerShell script to generate a list of function apps in your subscription that currently target versions 2.x or 3.x:
This means either the text in the doc or the script should be updated.


Update to docker-gen 0.7.0

Since jwilder/docker-gen@5043565 some timings seem to have changed. This caused the unit tests to fail intermittently, from my testings especially on Ubuntu systems (much less often on e.g. Arch).
This commit adds the dockergen_wait_for_event helper-function to try and wait for the configuration to be generated by docker-gen before continuing on with the actual tests themselves.
Additionally, at the end of every test file, all containers spun up by the bats-tests will be stopped. This required adding the bats-type label to every container started during the bats-tests.
The stopping of the containers reduces the amount of events docker-gen has to process, thus resulting in lower wait times for the generation to happen.

Well, Travis seems to be happy with that.
Ping @jwilder @baptistedonaux (cc @jeanpralo @md5): can you guys take a look (also regarding the notes I added)?

:+1:

@jwilder given your :+1:, some more tests I've done and now three successful Circle-CI runs, I have removed the WIP notice.
From my side this PR is ready for merge.

LGTM

Thanks @pitkley!

No worries, glad I could help!


ASCII character 128 not being encoded by he

var _char = String.fromCharCode (128);
var got = he.encode (_char, {
  'encodeEverything': true
});
console.log (got);
alert (got);

When I run the above code snippet, I see a small square like character in both alert box and console instead of the encoded string. Is this like a special case or bug. I don't know how to fix this.

128 === 0x80, so this is U+0080 <control> / Padding Character / PAD.
And per the spec:

The numeric character reference forms described above are allowed to reference any code point excluding U+000D CR, noncharacters, and controls other than ASCII whitespace.

So this is working as intended.


SQL DataNode doc for Microsoft SQL Server

#162

@jrobinAV I would like to delete the Docker documentation for Airflow. It is in the Git history. What do you think about it?

@jrobinAV I would like to delete the Docker documentation for Airflow. It is in the Git history. What do you think about it?

@florian-vuillemot
OK.
I believe it is not exposed anymore, but we can delete it.


SQL function registry fix

Signed-off-by: Jason T. Brown<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@fcc7bbb). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             develop      #51   +/-   ##
==========================================
  Coverage           ?   79.57%
==========================================
  Files              ?       93
  Lines              ?     2100
  Branches           ?      110
==========================================
  Hits               ?     1671
  Misses             ?      429
  Partials           ?        0

Impacted Files
Coverage Δ

...astraea/spark/rasterframes/functions/package.scala
74.15% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc7bbb...76488b6. Read the comment docs.


Roll Engine from 99cc50dfffab1 to 7d6180c3014a (2 revisions)

Roll Engine from 073263e39d1d to 7d6180c3014a (37 revisions)
https://github.com/flutter/engine/compare/073263e39d1d...7d6180c3014a
2020-10-30<EMAIL_ADDRESS>Fix viewInset.bottom and viewPadding.bottom… (flutter/engine#21730)
2020-10-30<EMAIL_ADDRESS>Manual Roll of Dart to ba80ed989cc...9c6e76468ca (flutter/engine#22213)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
...

Commit queue failed; closing this roll.


Fix: Error: (0 , time_speak_1.default) is not a function

The following is the output of checking in, with the package installed from the registry (vs linked locally).
 10:07 ▶ 100% 🔌 ▶ xia ▶ f3rno64 ▶ ~ ▶ $ ▶ tt in --at '2 hours ago' laptop reset
Error: (0 , time_speak_1.default) is not a function

Fix this.

Fixed by https://github.com/f3rno64/track-time-cli/commit/1b4927574605e15950cebd2bcbd4ff93ce612127


numpy version conflicts despite clean virtualenv

I've installed virtualenv and created and activated a new virtualenv in the source folder.
I'm running Python 3.6.5 on a Mac OS X High Sierra 10.13.6.
When running make run_dev I get the following error:
RuntimeError: module compiled against API version 0xc but this version of numpy is 0xb
ImportError: numpy.core.multiarray failed to import
ImportError: numpy.core.umath failed to import
ImportError: numpy.core.umath failed to import
2018-08-11 14:54:46.402447: F tensorflow/python/lib/core/bfloat16.cc:675] Check failed: PyBfloat16_Type.tp_base != nullptr
/bin/sh: line 1:  7848 Abort trap: 6           python run.py
make: *** [run_dev] Error 134

Since I run it in a virtualenv, I suppose the error is produced in ai-chatbot-framework and not in my own settings on my local computer?
The numpy that gets installed on my computer running make setup is version 1.14.3, but I can't figure out what that RuntimeError is really saying, because I'm a noob.
I tried
pip uninstall numpy
pip install numpy --no_cache-dir
to see if that helped, but it didn't.

We don't support python 3.6 yet. Please create a Py 2.7 virtualenv and try again.


teste

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]
Is the device enrolled in a MDM solution? Which one?
Device rooted / jailbroken, or using Custom Rom?
Crash report integration (e.g crashlytics, any crash report can be provided?):

Product Info (please complete the following information):

SDK version: [e.g. Beta]
SDK Module(s): [e.g. FRAuth]
AM version: [e.g. 6.5.2]

Additional context
Add any other context about the problem here.

ok


[0.13.9] Regression regarding expanded method signature

I have a utility-method in my build.sbt:
def makeExtensionDir(baseDir: File, extension: String, extensionTargetDir: File, typeDir: String = "extension")(implicit log: Logger): Unit = …

It seems that this method is expanded prior to use, resulting in this error:
/Users/meg/dev/ping/multibank2/clients/build.sbt:114: error: not enough arguments for method makeExtensionDir: (x$1: java.io.File, x$2: String, x$3: java.io.File, x$4: String, x$5: sbt.Logger)Unit.
Unspecified value parameters x$4, x$5.
  makeExtensionDir(baseDirectory.value, "firefox-extension", targetDir)

The same code works when using sbt 0.13.8

can you link (gist) your .sbt file so we have a better test case?

Sure thing!
I had to cut away some code due to company policy, but this outlines the culprit.
The project, called 'extensions', is a sub-project of a multi-project build. This may be a contributing factor but I can't really gist the whole project structure due to it being too big.
The error seems to be spurious, I'm guessing a race condition of some sort.

I should probably add some more context to my problem: I have two instances of SBT running in the project; one in the base project and one in the sub-project. Things were just now working using sbt 0.13.9, until I changed a simple string value in the sub-project configuration.
It turns out exiting both SBT processes and restarting the base project configuration alleviates the problem as it allows everything to recompile.
Maybe I'm not supposed to run two instances at once..

Another addendum: This happens even though I only run one SBT. When this happens, I can make it work again by changing code inside a project object that defines several taskkeys. This seems to refresh the target directory which allows the sub-project build to compile successfully.

Sorry for bumping this, but I figured out a way to remedy my problem when it occurs; simply removing the /project/target directory allows the configuration to work again

Thanks for the update.
sbt should probably check for the exact version of sbt and try to wipe out the directory on its own.


Use starknet-rs types in rpc

Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:

Feature
Refactoring (no functional changes, no API changes)

What is the current behavior?
The RPC crates define custom types while:

we strive to have one single typing for the whole starknet X rust ecosystem
it takes useless time to write them, especially when they are complex
it's bug prone

Resolves: #359
What is the new behavior?
Use only types from starknet-rs.
Does this introduce a breaking change?
Yes and No.
We need to do #381 to use these types in the runtime as well. In the current state, H256 cannot be converted to FieldElements, not sure about what's going on.
Other information

Need to do https://github.com/keep-starknet-strange/madara/issues/381 ASAP to remove all the H256>FieldElement conversions


Renamed Cheatable Starknet to Cheatnet

Closes #314
Introduced changes

Renamed Crate Name from Cheatable Starknet to Cheatnet.
Change made on CI too.

Breaking changes

Checklist

[x] Linked relevant issue
[ ] Updated relevant documentation
[ ] Added relevant tests
[x] Performed self-review of the code
[ ] Added changes to CHANGELOG.md

@Radinyn @binsta can we keep the team name as it is for now 🙏 Otherwise thanks for the contribution


Update OpenBSD menu options

A new version of OpenBSD was released yesterday! When trying to test it out with netboot.xyz, I noticed that the menu options needed to be updated, which the PR addresses. This PR also updates the snapshot entry since it was outdated.

Thanks for the contrib!


AttributeError for certain key combinations with MinutesMenu

When playing around with the timer I noticed it would crash while displaying the minutes menu. I managed to reproduce the problem with this stack trace:
Traceback (most recent call last):
  File "code.py", line 14, in <module>
  File "/lib/meditation_timer.py", line 21, in perform_sequence
  File "/lib/meditation_timer.py", line 44, in select_minutes
AttributeError: 'NoneType' object has no attribute 'integer_value'

The code in question:
    def select_minutes(self):
        menu = MinutesMenu()
        menu.light_all_option_keys()
        menu.wait_for_selection()
        # At this point something should be selected and get_selected() returns something.
        menu.display_selection()

        pause = Pause(seconds=1.5)
        pause.wait_until_complete()

        # BUG: With some key combinations get_selected() returns None.
        return menu.get_selected().integer_value

Perhaps what happens is this:

An active selection button is pressed and a choice is made.
There is a pause.
During the pause the user presses an unassigned button and the selection becomes None.
Once the pause is complete we attempt to retrieve integer_value but get_selected() returns None

A quick test shows this problem is reproducible:

Start and press the red key
Within a second press an unlit key.
An exception is thrown.

Note that debounce is 0.125 seconds and hold is 0.75 seconds so each press needs to be for that span of time.

A quick fix in the end:
    def _set_selected(self, key_num):
        if key_num in self._options:
            self._selected = self._options.get(key_num)

I managed to reintroduce the same bug. Here's the stack trace:
Traceback (most recent call last):
  File "code.py", line 427, in <module>
  File "code.py", line 26, in perform_sequence
  File "code.py", line 74, in get_users_choice
AttributeError: 'NoneType' object has no attribute 'value'

In general it might be better to return a default value rather than None.

Fixed the bug. Still need to look at alternatives to returning None.


timeoutmilliseconds parameter not working

Hi, im having problems using the plugin. it gives me errors when i use a recent version or version 4+. i tried using version 3.0.4, it worked in that it didn't give me any errors but what would happen is that the application would enter into break mode and not tell me what the problem was.
please help as I am not sure of how to proceed from here.
Thanks.
Bug Information
Version Number of Plugin:4.1.1
Device Tested On:  android 6.0 marshmallow
Simulator Tested On: android 6.0 marshmallow
Version of VS: 2017
Version of Xamarin: 4.7
Versions of other things you are using: xamarin.forms version 2.4.0
Steps to reproduce the Behavior
Expected Behavior
Actual Behavior
Code snippet
    private async void BtngetLocation_Clicked(object sender, EventArgs e)
    {
     var locator = CrossGeolocator.Current;
     locator.DesiredAccuracy = 50;

     var position = await locator.GetPositionAsync(timeoutMilliseconds: 10000);
    }

Screenshotst

It is now a TimeSpan... so TimeSpan.FromSeconds(10)


Allow a larger surface for mpeg2/jpeg encoding

Like other CODECs, we may allow a larger surface for mpeg2/jpeg
encoding. If do so, we may use the same way to allocate surfaces for all
CODECs in user application / library.

No concern from my side about the idea of the change but please fix the build. Also need a review from @stasefremov

The script expects 2019 year in updated file. Currently it's 2018. Please update

I think it should be done in another patch.

I think it should be done in another patch.

No need. Feel free to update current one.

Ok, I updated the patch, thanks for your comment.

Thanks!
@stasefremov, your turn:)

@dvrogozh I adjusted the stride in gst-msdk (https://github.com/intel-media-ci/gst-plugins-bad/pull/6) , which works well for decoding, vpp and h264/h265/vp9 encoding, however it broke mpeg2/jpeg encoding.  Without this fix, I have to use different stride in gst-msdk for mpeg2/jpeg encoding.

@stasefremov any comment? A MR for gst-msdk (https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/519)  is blocked by this fix.

Sorry, owner of this task is on sick leave, need more time for internal preparations, I hope we finish it next week

Any progress on this PR?

Sorry, no, task owner is still unavailable

@gkrivor @onabiull Internal preparations were done.

Thanks all for merging the patch.


go install fails - shims not a directory

Describe the bug
go install fails to run, saying my asdf shim is not a directory
To Reproduce
Steps to reproduce the behavior:
{user}@MLDCXKX25V4J gokit % asdf install
golang 1.21.0 is already installed
golangci-lint 1.56.2 is already installed

{user}@MLDCXKX25V4J gokit % echo $GOPATH
/Users/{user}/.asdf/installs/golang/1.21.0/packages

{user}@MLDCXKX25V4J gokit % echo $GOBIN
/Users/{user}/.asdf/shims/go/bin

{user}@MLDCXKX25V4J gokit % which go
/Users/{user}/.asdf/shims/go

{user}@MLDCXKX25V4J gokit % asdf which go
/Users/{user}/.asdf/installs/golang/1.21.0/go/bin/go

{user}@MLDCXKX25V4J gokit % go install golang.org/x/tools/cmd/godoc@latest
golang.org/x/tools/cmd/godoc: go install golang.org/x/tools/cmd/godoc: mkdir /Users/{user}/.asdf/shims/go: not a directory

{user}@MLDCXKX25V4J gokit % which godoc
godoc not found
{user}@MLDCXKX25V4J gokit % asdf reshim
{user}@MLDCXKX25V4J gokit % which godoc
godoc not found

Expected behavior
go install installs the package
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Mac
Version Sonoma 14.1

Additional context

This looks fixed after #143 was merged. Feel free to re-open if you're sill having issues.


Useless compile error while lacking encoder/decoder

If there is no encode for date, then compiler complains
 [error] /home/jilen/workspace/jfc-test/src/main/scala/Foo.scala:26: diverging implicit expansion for type io.circe.Encoder.Secondary[this.Out]
[error] starting with method encodeCaseClass in trait GenericInstances

Is there any chance to improve the error reporting ?

import io.circe._
import io.circe.generic.auto._
import io.circe.syntax._

import java.util.Date
case class Foo(
  date: Date,
  number: Int,
  str: String)

object App {

  def encodesDate(fmt: String): Encoder[Date] = new Encoder[Date] {
    def apply(a: Date) = {
      val sdf = new java.text.SimpleDateFormat(fmt)
      Json.string(sdf.format(a))
    }
  }

  def main(args: Array[String])  {
    //implicit val DateEncodes = encodesDate("yyyy-MM-dd HH:mm:ss")
    val f = Foo(new Date, 1, "fff")
    println(f.asJson.noSpaces)
  }
}

Yeah, that's a pretty terrible error message—thanks for pointing it out.
The implementation of the generic derivation mechanism will be changing with #30, which I'm hoping to get done tomorrow, so after that dust settles I'll revisit this and #34, since things might be a little different by then. We should be able to use @implicitNotFound in a few places to improve these messages a lot (see for example this message in Finch).

+1 to use implicitNotFound !
To decode and encode date, juest implicit
  implicit val dateTimeEncoder: Encoder[DateTime] = Encoder.instance(a => a.getMillis.asJson)
  implicit val dateTimeDecoder: Decoder[DateTime] = Decoder.instance(a => a.as[Long].map(new DateTime(_)))

Because of date has many format, I suggest that defined it in the documention and don't add a default format in the jfc.

I'm going to go ahead and close this since the following is a huge improvement:
<console>:59: error: could not find implicit value for parameter e: io.circe.Encoder[Foo]
           println(f.asJson.noSpaces)
                     ^

I'm not actually sure there's much additional useful information we could add with @implicitNotFound in this case, apart from maybe a pointer to the docs.


[CI] retry vm provisioning, increase timeout

This change is

test-me-please

test-missed-k8s

test-upstream-k8s

Coverage remained the same at 44.502% when pulling 7271e29129e206e6eed6688a172431a9a2e626ef on pr/retry-vagrant-provision-all into 68812a5b272623a1de1b36e9c23a095e61d2279f on master.

test-me-please

test-me-please


Unable to Authorize with Spotify

Issue Description
Unable to Authorize Plugin. Downloaded plugin, created the app in developer Spotify. Setup Security.Store file with Client ID and secret. Setup URI.
Then, when going into Flow, it tells me that the client needs to be authorized. Nothing happens when I click on it. I go to no webpage to authorize the application.
Functionality Affected
Please mark the functionality of the plugin that is affected by the issue:

[X] Controlling the local Spotify client (changing track, pausing, skipping, muting)
[X] Searching Spotify for albums, artists or songs

Software Versions
Please fill in the following information:

Spotify client version (Help > About Spotify): Spotify for Windows <IP_ADDRESS>3.gc2965cdf
Flow Launcher version (Flow Settings > About): 1.9.2

Please also make sure you're running the latest version of Flow.Launcher.Plugin.SpotifyPremium

Thanks for letting me know! Not sure what broke it but looking into it now.

Looked into this - not sure exactly what's going on but I think the new version of Flow probably uses a different .NET runtime or something. I updated flow (Flow -> Check for update) and the spotify plugin is working fine. Does that resolve the issue?

Logs.zip

Looked into this - not sure exactly what's going on but I think the new version of Flow probably uses a different .NET runtime or something. I updated flow (Flow -> Check for update) and the spotify plugin is working fine. Does that resolve the issue?

Excellent! That looks like it did the trick. Thank you for the quick turnaround! Keep up the great work you are doing.


Cleanup: Update Icon, Switch About/Add buttons, upload design

updating icon
switching order of about and add button
uploading designs used when brainstorming

Was thinking, would it be a good idea having the icons as the HOW logo instead of a Book? Not including the Book logo on Home Looks good otherwise.

Thats a good idea, do you know how we can generate such an icon ?


Rework AppendOperation struct

As this struct is only used in Request::Append, it is not necessary for it to contain address -- every other adata variant in Request already explicitly contains an address field. What we can do instead is make AppendOperation an enum with Seq and Unseq variants, so we can collapse the Request::AppendSeq and AppendUnseq variants into a single Request::AppendAData variant. This would simplify the API, but would require changes in safe_vault and safe_client_libs.

Closing - struct no longer in use


mysql migrations are always assumed transactional

What version of Flyway are you using?
4.2.0
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
api
What database are you using (type & version)?
mysql 5
What did you do?
executing a script containing 'alter table' and 'update' statements
What did you expect to see?
exception by default (with mixed = false)
What did you see instead?
migration succeeds
as an aside, would it be possible to enforce a failure if migration contains multiple non-transactional statements?
ie i expect a failure whenever a migration cannot be executed in single transaction, current mixed transactions implementation even for pgsql allows multiple non-transactional statements per migration
if this behavior is implemented, what might be the strategy to allow already existing migrations with multiple transactions ignore that setting?

Please share a small test case that demonstrates this behavior.

please see https://github.com/OlegYch/flyway-1725/

This works as expected. mixed=false is meant for databases where certain statements absolutely cannot be run within a transaction. The MySQL statements you used have no such restriction. Works as designed.

in mysql ddl statements cannot participate in existing transaction
it would be nice to be able to enforce that there is exactly one transaction per migration so that you don't accidentally have partially applied migrations

Hey @axelfontaine
I have a question related to this thread because I also feel there is a bug.
I use mysql and have this migration:
INSERT INTO persons
(ID,
 LastName,
 FirstName,
 Age)
VALUES
(4,
 'TEST4',
 'TEST4',
 67); #Transactional!

CREATE TABLE Persons2 (
	 ID int NOT NULL,
	 LastName varchar(255) NOT NULL,
	 FirstName varchar(255),
	 Age int,
	 PRIMARY KEY (ID)
); #Non-transactional!

DROP TABLE Persons2; #Non-transactional!

I run migrate with the option set to mixed=false even if it is also the default value just to be sure.
As you can see if you try it, no exception is issued even if we clearly mix statement that are transactional (insert) and statement that are not (CREATE and DROP).
I did additional testing by creating a migration containing only "INSERT" and making sure the last insert fail and the migration was rollbacked as expected.
I created another migration containing only "CREATE" or "ALTER TABLE" with something that didn't work at the end and it was not rollback as expected.
So it seems Flyway knows whether some statement are transactional or not but it doesn't apply this when enforcing the mixed option.
Do you have an explanation for this? Is this a bug? I read you comment above saying it is working as intended but I can't wrap my head around this based on my testing, reading mysql documentation and reading Flyway documentation.

@JFCote The docs for mixed were indeed a little unclear. We have now updated them with more details to better reflect what this does. See https://flywaydb.org/documentation/commandline/migrate#mixed

@axelfontaine Thank you very much for the clarification!


CI build and remove hard-coded PRODUCT_UID

Problem
Over time, code changes can lead to the build breaking, such as when updating note-c. Additionally, customers at scale require a dependable, repeatable build.
Solution
This PR implements a dockerized CI build for the examples in this repo and builds each example in all applicable configuration permutations

example.c - I2C/Serial with note-c, with and without a PRODUCT_UID defined

example_min.c - Serial only without note-c, with and without a PRODUCT_UID defined

To help guide the developer to using the correct PRODUCT_UID, firmware examples no longer include a hard-coded PRODUCT_UID by default. Building the examples outputs an informational message about setting PRODUCT_UID with a link to further details.
The solution comprises these elements:

A docker image that includes the required dependencies - CMake, the MSP430-gcc toolchain, and 7z decompression.

CMake scripts to build the examples in the permutations listed above

A github workflow and action that executes the docker image to run CMake and verify the examples build successfully

Source code changes

NOTECARD_USE_I2C and DISABLE_NOTE_C_LIBRARY are now optional defines so can be defined on the command line

PRODUCT_UID is an optional define. Both examples conditionally set product in the hub.set request when PRODUCT_UID is defined

Debug directory has been removed.

 note-msp430 PRODUCT_UID tweaks and CI build


ModSecurity 2.7.4 mlogc utilizing 100% CPU

I have a recently installed reverse proxy deployed WAF installed running 2.7.4 using mlogc sending logs to a central AuditConsole server. We use the atomicorp commercial rules, hardware spec is as follows: dual quad core Xeon CPU, 32GB RAM, CentOs 6.4 64-bit.
Today, the web apps being protected by the WAF went down and after looking at the reverse proxy I could see mlogc running at 100% on a single CPU core, after running "ps aux | grep mlogc" I could see 2 instances running. I issued the command "kill 1983" as 1983 was the process utilizing 100%. This did not work, so I issued the command "kill -9 1983" which was successful. I am keeping a very close eye on this now
httpd -v
Server version: Apache/2.2.15 (Unix)
Server built:   May 13 2013 22:11:16
/opt/modsecurity/bin/mlogc -v
ModSecurity Log Collector (mlogc) v2.7.4
APR: compiled="1.3.9"; loaded="1.3.9"
PCRE: compiled="7.8"; loaded="7.8 2008-09-05"
cURL: compiled="7.19.7"; loaded="libcurl/7.19.7 NSS/<IP_ADDRESS> zlib/1.2.3 libidn/1.18 libssh2/1.4.2"
Can I provide any further details to help assist? All configuration other than CollectorRoot and LogstorageDir  and the sensor credentials are default in mlogc.conf
Thanks,
Craig

Hello dears. I'm hitting the same problem now.
(gdb) bt
#0  0x00002b533e63316f in pthread_mutex_unlock () from /lib64/libpthread.so.0
#1  0x00002b533e8659b0 in apr_thread_mutex_unlock () from /usr/local/apache/lib/libapr-1.so.0
#2  0x00002b533e8668ca in apr_pool_destroy () from /usr/local/apache/lib/libapr-1.so.0
#3  0x00002b533e866834 in apr_pool_destroy () from /usr/local/apache/lib/libapr-1.so.0
#4  0x0000000000404069 in create_new_worker (lock=0) at mlogc.c:1796
#5  0x00000000004043b5 in add_entry (
    data=0x6139468 "xxx.com <IP_ADDRESS> - - [23/May/2015:10:22:26 --0500] \"GET /favicon.ico HTTP/1.1\" 200 0 \"-\" \"-\" VWCbMthWnAEAAE6@H4AAAAC0 \"-\" /nobody/20150523/20150523-1022/20150523-102226-VWCbMthWnAEAAE"...,
    start_worker=1) at mlogc.c:409
#6  0x00000000004057a4 in receive_loop (argc=2, argv=0x7fffa78118a8) at mlogc.c:2065
#7  main (argc=2, argv=0x7fffa78118a8) at mlogc.c:2306

This process is ancient as you might see. The newer one doesn't consume much cpu.
4     0 20080     1  29   4 171752  3544 -      RNl  ?        305:09 /usr/local/modsecurity/bin/mlogc /etc/httpd/conf/mlogc.conf
4     0 27756 27755  18   0 171752  3556 pipe_w Sl   ?          0:02 /usr/local/modsecurity/bin/mlogc /etc/httpd/conf/mlogc.conf

# strace -fx -p 20080
Process 20080 attached with 3 threads - interrupt to quit
[pid 20261] select(0, NULL, NULL, NULL, {0, 5000} <unfinished ...>
[pid 20260] futex(0x60d8fe0, FUTEX_WAIT_PRIVATE, 2, NULL <unfinished ...>
[pid 20261] <... select resumed> )      = 0 (Timeout)
[pid 20261] select(0, NULL, NULL, NULL, {0, 10000}) = 0 (Timeout)
[pid 20261] select(0, NULL, NULL, NULL, {0, 10000}) = 0 (Timeout)
............
[pid 20261] select(0, NULL, NULL, NULL, {0, 10000}) = 0 (Timeout)
[pid 20261] select(0, NULL, NULL, NULL, {0, 10000} <unfinished ...>
Process 20080 detached
Process 20260 detached
Process 20261 detached

strace -fx -p 20080 2>&1 |grep -v 'select(0' produces nothing.

It appears the thread is essentially stuck in:
(gdb) next
811             apr_pool_destroy(pool->child);
1: pool->child = (apr_pool_t *) 0x35585c8
(gdb)
810         while (pool->child)
1: pool->child = (apr_pool_t *) 0x35585c8
(gdb)
811             apr_pool_destroy(pool->child);
1: pool->child = (apr_pool_t *) 0x35585c8
(gdb)
810         while (pool->child)
1: pool->child = (apr_pool_t *) 0x35585c8
(gdb)
811             apr_pool_destroy(pool->child);
1: pool->child = (apr_pool_t *) 0x35585c8
(gdb)
810         while (pool->child)
1: pool->child = (apr_pool_t *) 0x35585c8
(gdb)
811             apr_pool_destroy(pool->child);
1: pool->child = (apr_pool_t *) 0x35585c8
(gdb)
810         while (pool->child)
1: pool->child = (apr_pool_t *) 0x35585c8

(gdb) p *pool->child
$8 = {parent = 0x3575cf8, child = 0x0, sibling = 0x35585c8, ref = 0x3575d00, cleanups = 0x0, free_cleanups = 0x0, allocator = 0x34c65e0, subprocesses = 0x0, abort_fn = 0, user_data = 0x0, tag = 0x0, active = 0x35585a0,
  self = 0x35585a0, self_first_avail = 0x3558640 "VWEww9hWnAEAADIFOPUAAADu", pre_cleanups = 0x0}

(gdb) list 811
806
807         /* Destroy the subpools.  The subpools will detach themselve from
808          * this pool thus this loop is safe and easy.
809          */
810         while (pool->child)
811             apr_pool_destroy(pool->child);
812
813         /* Run cleanups */
814         run_cleanups(&pool->cleanups);
815

If you need more info, tell me.

I am assuming that it is no longer a problem, therefore I am closing this issue.


Order Button on Review Purchase Module

order button should say purchase instead of order

edit order module on the buyer hub page should be the Edit Purchase Module.


mistake on documentation? Implicit conversions involving type parameters

Is that a mistake on C# 6.0 Draft Standard or am i missing some new feature of C# 6.0?
C# 5.0 Standard

From T to an interface type I if it has an implicit conversion to an interface type I0, and I0 is varianceconvertible to I

C# 6.0 Draft Standard

From T to an interface type I if it has an implicit conversion to an interface or delegate type I0 and I0 is variance-convertible to I

If I is an interface type and I0 is variance-convertible to I, them I0 must also be an interface type! I0 will never be a delegate type!
so instead of:

From T to an interface type I if it has an implicit conversion to an interface or delegate type I0 and I0 ...

it should be:

From T to an interface type I if it has an implicit conversion to an interface type I0 and I0 ...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7be4c24e-9e92-6b75-2b8e-2cb6cb072b5b
Version Independent ID: 450064c8-720e-3b90-18d6-7bd5f183857e
Content: Conversions - C# language specification
Content Source: spec/conversions.md
Product: dotnet-csharp
Technology: csharp-spec
GitHub Login: @dotnet-bot
Microsoft Alias: wiwagn

I believe it's like this because the C# 5.0 spec is newer than the C# 6.0 draft spec (yes, really) and so only the C# 5.0 spec has the fixed wording. Once proper C# 6.0 spec is released (I think https://github.com/dotnet-foundation/projects/issues/90 is the most recent activity on that front), it should have the correct wording.
In more detail: MS released their version of the C# 5.0 spec in 2013, which contains the mistake you mention. Then, MS released a draft spec for C# 6.0, based on their version of the C# 5.0 spec, still containing the mistake. In 2017, Ecma released their version of the C# 5.0 spec, which contains improvements from the MS version of the spec. Now, Ecma is working on releasing their version of the C# 6.0 spec, based on their version of the C# 5.0 spec.

Thanks for writing this @leekr7070
@svick has provided all the background on the history.  The standards committee has been working to add the C# 6.0 features to the C# 5.0 standard, and we should have a public draft if and when we are approved by the .NET foundation.
I'll keep this open until we release that update, and assign it to me.

@svick @BillWagner
Ok! Thanks for your attention!
Now i understand it.

Closing.  This is correct in the draft standard in csharpstandard


KAFKA-8988. Replace CreatePartitions Request/Response with automated protocol

This change update the CreatePartitions request and response api objects
to use automated protocol. The change involved updating all client code
to use the newly updated CreatePartitionsRequest and
CreatePartitionsResponse classes.
Updated relevant tests. All tests pass.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

CC: @ijuma, @mumrah, @hachikuji, @cmccabe, @jsancio

SaslSslAdminClientIntegrationTest.testCreatePartitions failed for JDK 8
SaslScramSslEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl
fails for JDK 11
Ran them locally (with JDK 8) to make sure that they pass.

retest this please

PlaintextAdminIntegrationTest.testCreatePartitions failed when empty partition assignment was passed. New code was filtering empty reassignment list, in old code it was an error condition. Fixed by removing the filter.

retest this please

retest this please

retest this please

On 2.12 the TopicCommandWithAdminClientTest.testCreateWithReplicaAssignment test failed with error: "org.apache.kafka.common.errors.UnknownTopicOrPartitionException: This server does not host this topic-partition". Passes locally.


Lag spike when using towny /town command?

Gringotts (2.4/2.5 Github @ Jenkins) & Towny (<IP_ADDRESS>/<IP_ADDRESS>) & Vault 1.5.3-b37
I get about quarter second lag spikes when the town command is executed.
Server running Spigot 1.8.3 via BuildTools.
CPU / Mem / TPS all fine.
Other economy plugins such as Fe and iConomy do not do this.
Tried using Gringotts with Flatfile & SQL.
Tried setting towny async from true to false.
I don't know what to do!
The spikes are horrible.

It is worth noting that the spikes occur even if there are no vaults owned by the player or for the town.
But yet commands like /money do not cause issues.
Not very useful, but I tried spamming /t and doing a timings...
http://timings.aikar.co/?url=11226664

Did some more testing..
Only plugins installed:
-Towny, Gringotts
No lag.
Added Vault, suddenly lag.
Using vault 1.5.3-b37 (latest)
Adding every other plugin minus vault results in no lag, but everything requires vault, so there's not much I can do about that.
Thanks

Thanks for looking into this. Unfortunately so far you're the first I know of experiencing this specific problem, so I can't really help. :(
Are you using the default Towny and Gringotts configs aside of the async setting?
Are you testing with an empty world or one with lots of vaults ot town vaults?

I was able to reproduce this with the latest spigot build (1.8.6) and only Towny, Gringotts and Vault, latest version of each plugin from bukkitdev, I also tried to compile latest Towny & Gringotts, still had the problem. I haven't modified any of the configs, and I deleted Towny's & Gringott's config before trying with the new build. Heres a video of the problem https://www.youtube.com/watch?v=rG6UvxK_pXA&feature=youtu.be
Thanks in advance, your plugin is amazing ^_^

Thanks for the illustration. Just for clarification:

Do you have this problem in a virgin world, or only a more highly developed one?
If developed: How many town vaults are in your db?
Do you have any problem when using the /money command?

I'm working together with Joannou on his server, and he's asleep at the moment, so I will answer for both :P
Joan's server:

The server is in development at the moment, so it's not really developed, however we use TerrainControl & have generated a lot of chunks if it makes a difference :)
1-3 town vaults
Nope, it works perfectly :)

Mine:

Was just generated.
1 chest
Works perfectly :)

yeah, so far it seems to be an issue with just those 3 plugins, exclusive towards gringotts.
If you need any more information or help leme know.
No hurry or anything, but the timing on this is a bit odd.. (gringotts is the only really good item based economy plugin out there and we really wanted to use it for our new relaunch!)

I took a jar snapshot while rapidly spamming /t and got some possibly useful information.
It seems the highest percentage of stuff is in:
org.gestern.gringotts.api.impl.VaultConnector.getBalance() | 20.64%
org.gestern.gringotts.api.impl.VaultConnector.hasAccount() | 19.57%
The rest is thread sleep.

It seems if you expand those two even more, it boils down to more sleeping and getting offline player requests or something for org.bukkit.Bukkit.getOfflinePlayer() & com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService.makeRequest()

Thanks! I think I get the problem now. Apparently "getOfflinePlayer" now attempts to resolve player names over the internet. Ugh. And Gringotts tries to resolve the account for the town via an offline player. Because it is not a UUID, it will always do a blocking web request to lookup the UUID, which will of course fail. I'll see if this can be easily fixed.

I pushed an (untested) quick fix, see if that works for you, please. Otherwise I might have to see if I can spend more effort on this ;)

I think that did the trick! :)
Popped it in there and did /t and no freezes!
Apparently it takes about half a millisecond now.. which is quite the improvement over the ~500ms web requests lol.
Thanks for fixing this!
If there are any more odd spikes/things I'll be sure to try to narrow it down again to make it a bit easier to pinpoint.

That should be the only occurence of this particular problem. Let me know if everything works as expected otherwise over the next days, and I'll publish an update.


Minor CLI UX issue: '--f'

Hi!
I am right now in the ContainerDays Boston workshop and noticed something when I fired unik up.  It is a minor thing, but just something I wanted to note when you can look at it.
--f="/Users/qmurphy/.unik/daemon-config.yaml"
you use '--f' for the location of the config file, but the '--' is convention for longhand, like '--file'. I made the mistake of doing -f (the conventional shorthand) and found it a bit confusing.
Again, really enjoying this, but wanted to note the usability issue right now before I forget.
Thank you for the demo!
Quinn

appreciate the feedback. i'll leave this open as a personal TODO to generally clean up our CLI flags


NSA doesn't recognize Quilt Kotlin Libraries as Fabric Kotlin Libraries

I know the mod supports both Quilt and Fabric but I can't run this mod without Fabric Kotlin Libraries
I'm using Quilt with Quilt Kotlin Libraries currently and as the title said, can't use any mods that need QKL in order to run because I have to leave FKL in there in order to run NoStringsAttached
so I guess give NSA recognize QKL?

This was no needed, QKL v1.0.0 fixed this


Hovering over css color does not open color picker, instead opens MDN reference box.

Issue Type: Bug
Hovering over CSS color does not open color picker, instead, it opens the MDN reference box.
Earlier (not sure of the exact version, however,) it used to open up a color picker box, which was useful in case the user wants to choose a diff color and play around.
I have checked the stable build (with no extensions installed) and able to replicate this issue in it as well.
Is this intended behavior? I liked the color picker. not sure if I am missing something here.

 Likely a dup of https://github.com/microsoft/vscode/issues/40634

@aeschli issue started appearing after the vscode open link update was pushed.

@sanket-bhalerao I'm pretty sure it's an issue in #40634. If you hover over the box, it doesn't show color picker.


Support for linear and radial gradients

Example:
http://jsfiddle.net/GVfpT/
The generated SVG from the example:
http://jsfiddle.net/hXfgH/
References:
http://www.w3schools.com/svg/svg_grad_linear.asp
http://www.w3.org/TR/SVG/pservers.html
http://raphaeljs.com/reference.html#Element.attr

Hi there,
This project is no longer being maintained so this issue is being closed. Thank you for using r2d3 and taking the time to report this issue.


[Data] Add data to account links

Stripe::AccountLink.create({
  account<EMAIL_ADDRESS>  refresh_url: "https://example.com/reauth",
  return_url: "https://example.com/return",
  type: "account_onboarding"
})

Will throw NoMethodError: undefined method 'data' for {}:Hash when testing with stripe-ruby-mock.
Adding empty data hash to mock_account_link fixes the error.

@alexmamonchik

I'm also getting this error creating AccountLinks, would be great to merge this

I'm also getting this error creating AccountLinks, would be great to merge this

While we wait for this to be merged, you can use my fork which contains this fix.

gem "stripe-ruby-mock", git: "https://github.com/dudyn5ky1/stripe-ruby-mock"


chore: bdd-spring-1584433469 to 0.0.1

chore: Promote bdd-spring-1584433469 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Panic while booting up the app causes weirdly formatted error message

Reading config from /Users/bradcypert/Projects/luna_api/config.ymlpanic: interface conversion: interface {} is nil, not string

The panic is fine, but it should read like so:
Reading config from /Users/bradcypert/Projects/luna_api/config.yml
panic: interface conversion: interface {} is nil, not string

@bradcypert Hi, I would like to work on this issue, simply, it only lacks of linefeed in Reading config...

Yup! It's simply a line feed that needs adding! @u5surf have at it :D


Programatic hits to POST:/api/collect not logged (filtered as a bot)

Hi there,
I have a use case where I want to track downloads of a podcast to /api/collect programatically from the backend as events in Umami. My workflow is,

User goes to a URL like https://example.com/podcast/download/episode/100
I then log an Umami stats event from the backend by sending a POST request to /apt/collect with body similar to,{
  "payload": {
    "website": "my-website-id",
    "url": "/podcast/download/episode",
    "event_type": "podcast-download",
    "event_value": "episode-100",
    "hostname": "example.com"
  },
  "type": "event"
}

302 redirect to the MP3 asset's true location (ie on Amazon S3)

However, I note that using Python's Requests library in my backend to perform this POST operation, the event doesn't get logged.
I've tracked this down to the following line of code in umami/pages/api/collect.js,
if (isbot(req.headers['user-agent'])) {
  return ok(res);
}

This silently filters and drops the request on the assumption that Python's Requests library's user agent is a bot — which I guess it technically is.
My hack is to not send a user-agent at all which does the trick. However, this is feature undocumented and I arrived at after head scratching. I propose that there should be an explicit argument to /api/collect to allow for tracking of events from the backend, or perhaps to document the behaviour in the docs.
Cheers and thanks for consider it! Thanks for the great tool as well.
Cheers,
David

It also works with NO User-Agent header, worth noting that in the docs as well. (isabot(null) -> true)


Imported bug: Full day event import issue / invalid iCal-file

What steps will reproduce the problem?

Start app
Select URL for import (http://localhost/test.ics
load iCal file

What is the expected output? What do you see instead?
Refuses all full-day events.
Refuses import file/URL with
Error at line6:[DTSTART]
Unparseable date: "20110624"
What version of the product are you using? On what operating system?
1.5 on Android 2.3.3 Samsung Galaxy S2
Please provide any additional information below.
I write some own PHP code, so I can influence the generated ICS-code.
What I would like it to accept (and most other progs/Google does) is a file like
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Custom written JD//NL
BEGIN:VEVENT
TZNAME:CET
DTSTART:20110624
DTEND:20110625
SUMMARY:Example event
END:VEVENT
END:VCALENDAR
This is valid code for a single day full day event. So untimed DTSTART, DTEND.
I can see the progs accepts:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Custom written JD//NL
BEGIN:VEVENT
TZNAME:CET
DTSTART:20110624T000000
DTEND:20110625T235959
SUMMARY:Example event
END:VEVENT
END:VCALENDAR
But this gives an event between the times mentioned. Which is ugly and gives all sort of problems. For instance when changing to daylight-saving-time, which shifts the event one hour into the next day.
I'm totally new to Android, but would like to load stuff like this in my calendar.
Found your app, and it looks very nice.
Any resolvement of the issue would be appreciated.

fixed with https://github.com/dschuermann/ical-import-export/pull/18


Enable dhcrelay for baremetal provider

Issue #, if available:
Description of changes:
Add dhcrelay to the bundle and configure tinkerbell stack to use dhcrelay
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can we update the testing section to describe how we tested the changes?

/cherry-pick release-0.20