Fix kruskal's exception message for directed graph

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #138   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         117    117
  Lines        2283   2283
  Branches      396    396
=====================================
  Hits         2283   2283

Impacted Files
Coverage Δ

src/algorithms/graph/kruskal/kruskal.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4b829...6bb1393. Read the comment docs.


My code challenge

Here is my Solution for the main-tasks.
feel free to leave feedback at any time.

Closed as this was a kata run.
Keep up the good work! 😊


confuse about your project?

hello sir
as you named it mritopng it means that this repo will convert all mri images wheater its in nifty, or nii or nii.gz extension will convertible??
I have images from ADNI and I want to convert it to a series of png or tiff or jog and than pass through my modal so kindly guide me please in this situation if I am using wrong repo than please correct me thanks and jazakAllah

Hi @Aliktk
The repository currently only support conversion from DICOM to PNG. It doesn't have support for nifty.
I'm sorry the name of the repository misled you. It's meant to be a place where people can collaborate and add more functionality, hence I hope we will eventually have support for other formats.


1453 create application

Card: https://github.com/bcgov/cas-cif/issues/1453

Good slice! I'm wondering if we could get the jsonSchemaForm from the database?

I thought about it, but the fields will probably change a lot throughout the slices, and if the schema's in the db, every time we want to update it we'll need to do a sqitch migration. And doing 10 sqitch migrations will probably be more time-consuming than refactoring it later

That's a really good plan while things are in flux

A couple things I found during manual testing:
Clicking submit application overview after filling out the Project Overview & Legal Name directs me to 404 page not found.
If "Return to Dashboard" is clicked while the project is in draft, there is no way to get back to that draft

The next pages (attachments, summary) aren't part of this ticket, so that's why you get a 404 page. Getting back to the draft/edit also isn't part of this ticket (or the slice).


Feature/product by

added route for specific product id
wrote basic display for single item
updated product list view links for single product

I think you said to close this until after you'd merged Owen's, right?


Use polymorphic value types for manifolds

[x] remove shared_ptr for manifold types
[x] greatly simplify CartesianProduct class

closed by #90


Channels are cheap

You can have thousands of them without worrying about the performance.

"gophers are cheap"


Progress for containers actions is inconsistent

https://github.com/microsoft/vscode-remote-release/issues/1291#issuecomment-537915650

Or, arguably the issue is that the containers explorer is taking to long to provide a tree item.

Solving the real issue would require a risky refactor. As an improvement, for Start Container (which is the only one affected by this since it is the only one that doesn't show a modal dialog) I'm moving the progress to the parent tree node.


robots.txt / favicon.ico - Call to a member function setTimezone() on null

Laravel Version
10.14.0
PHP Version
8.1.12
Database Driver & Version
No response
Description
Looks like the new addition in the Http/Kernel is not working with Laravel Vapor.
The setTimezone() method is being called on a null value. This suggests that $this->requestStartedAt is null.
$this->requestStartedAt->setTimezone($this->app['config']->get('app.timezone') ?? 'UTC');
https://github.com/laravel/framework/compare/v10.13.5...v10.14.0#diff-e36bdc4c31d5863d42e9b5322d00d1982187d0239debc74625e1cce2ff7d486aR217-R218
https://flareapp.io/share/yPa2l9K7
Steps To Reproduce
Laravel 10.14.0
Vapor-core 2.26
Browse to /robots.txt or /.favicon

I'm currently retrying with the latest vapor-core (^2.3)

Opened a fix to address this: https://github.com/laravel/framework/pull/47596


use laravel-tidb-driver in eclipse che ide

TODO

[ ] php-8 docker image for che
[ ] laravel-tidb

https://github.com/ti-click/laravel-tidb/pull/1

#2
#3

#4


Commit message should use imperative mood

Using the imperative mood in commit message is a best practice that ImgBot currently doesn't follow (see https://chris.beams.io/posts/git-commit/#imperative).
tl;dr the commit message should be [ImgBot] Optimize images instead of [ImgBot] optimizes images.
Would be great to change by default, but would be fine to be able to change it as part of the config too.

👍 Sounds good to me.
I don't think we should make it configurable unless someone really wants to customize it.

need to update:

https://github.com/dabutvin/ImgBot/blob/master/Test/PullRequestBodyTests.cs
https://github.com/dabutvin/ImgBot/blob/master/Common/KnownGitHubs.cs
https://github.com/dabutvin/ImgBot/blob/master/OpenPrFunction/PullRequestBody.cs (just a code comment here)

Fine with me! Go ahead :)

After much overthinking, I've submitted a PR for this issue - #189

Quick turnaround! The change is integrated. I'll close this issue when the jobs get deployed

It's live! Thanks all


com.android.support:appcompat-v7:24.2.1

The sumup SDK includes
com.android.support:appcompat-v7:24.2.1
and thus prevents the applications from including
com.android.support:appcompat-v7:27.0.2 without conflicts

This means that neither compileSdkVersion nor targetSdkVersion can be higher then 24 (e.g. 27)

Gradle allowed to force the version of a dependency. And the SDK can survive it . Therefore, compileSdkVersion and targetSdkVersion can of course be greater than 24.
The code could be for instance in the android node of the build.gradle script:
configurations.all {
        resolutionStrategy {
            force 'com.android.support:appcompat-v7:27.0.2'
            force 'com.android.support:support-v4:27.0.2'
            force 'com.android.support:appcompat-v7:27.0.2'
            force 'com.android.support:cardview-v7:27.0.2'
            force 'com.android.support:design:27.0.2'
        }
    }

Declaring these dependencies in the build.gradle and excluding the support group from the sdk works as well.

Forcing a version number is not an acceptable solution.

@MarcusWolschon
implementation('com.sumup:merchant-sdk:3.0.0'){
exclude group: 'com.android.support', module: 'appcompat-v7'
}

actually:
`implementation "com.android.support:appcompat-v7:$support_version"
implementation "com.android.support:support-v4:$support_version"
implementation "com.android.support:design:$support_version"
implementation "com.android.support:cardview-v7:$support_version" // for sumup
implementation "com.android.support:support-core-utils:$support_version"
implementation "com.android.support:support-annotations:$support_version"
implementation 'com.android.support.constraint:constraint-layout:1.1.2'
//implementation 'com.sumup:merchant-sdk:3.0.0'
implementation('com.sumup:merchant-sdk:3.0.0'){
    exclude group: 'com.android.support', module: 'appcompat-v7'
    exclude group: 'com.android.support', module: 'support-v4'
    exclude group: 'com.android.support', module: 'design'
    exclude group: 'com.android.support', module: 'cardview-v7'
    exclude group: 'com.android.support', module: 'support-annotations'
}`


Support for showBrowserContextMenu

Couldn't take these annoying context menus popping up everywhere.
If you agree, please merge.
Merge also related toolbox branch.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[X] Caught up with develop branch as of last change.
[X] Added CHANGELOG entry, or determined not required.
[X] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[X] Updated doc comments / prop-types, or determined not required.
[X] Reviewed and tested on Mobile, or determined not required.
[X] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

FYI I did see this PR last week - wanted to pull and run the branch to ensure I understand it as these browser context menus are always contentious with our clients.


Add SSL support for client nodes

On Azure we could use keyvault - https://docs.microsoft.com/en-us/azure/virtual-machines/linux/tutorial-automate-vm-deployment


Streamline WIP workflow

Switch branch to WIP
Undo WIP
Clean up WIP commit

For ideas, some WIP workflows

https://github.com/bartman/git-wip
https://taingmeng.medium.com/quick-terminal-command-to-make-a-wip-commit-b6205be0cf64
https://gist.github.com/bkmeneguello/2c0fe08d4b10938768a7f0d8dcea8f68


Sep 10 JWT Token Customer Filtering

As a anchor platform developer, I want to make sure that only customers exposed are only those related to the SEP10 JWT Token that was authenticated.

After chatting with @marcelosalloum and @lijamie98 about this, I think this runs into the same problem as Marcelo was running into last week, and attempted to address in PR403. Jamie mentioned kicking off a conversation about introducing a new platform-owned customer id


The code not work in XCode 16,If I release an ipa file

The code work well,if I direct run in device or emulator via cable.
But if I use the release test to generate an ipa file, install ipa file in iPhone,it not work

I modify the function decryptWithRSAKey in RSAUtils.swift
old:
return Data(bytes: UnsafePointer(decryptedData), count: decryptedData.count)
new:
return Data(decryptedData)
It work well


The collection doesn't appear automatically under the "Database" node after executing the script

OS: All
Build Version: 20200915.3
Repro Steps:

Create a new Mongo Scrapbook --> Connect a database of Mongo DB.
Type the content as below in the Scrapbook.
			db.test2.drop()
 		db.test2.insert({"_id":"a","abc":"def"})
 		db.test2.insert({"_id":123,"abc":"def"})
 		db.test2.find()
Click "Execute All".
Check the result.

Expect:
The collection "test2" appears automatically under the "Database" node of Mongo DB.
Actual:
The collection "test2" doesn't appear automatically under the "Database" node of Mongo DB.

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


Allow conversion of some IPv4 header fields to host byte order when serialized

Just an unassuming fix for #150.
Just to describe the issue concisely:
darwin, dragonfly, netbsd, and freebsd<11.0 expect native byte ordering (only for length/fragmentation offset fields) when writing serialized IPv4 headers to raw IP sockets, as reflected by a fix for ipv4/header.go.
This strange assumption was removed since freebsd 11.0, but the other systems still have issues with this (as used to be the behaviour in freebsd with IP_HDRINCL, you will likely get EINVAL from the kernel due to incorrect packet length).
It would be nice to have a fix inside SerializeTo, but this would probably require an extra global variable for native byte order along with the magic you see in header.go to determine versions/endianness. I also assume changing such a critical method for this fix is not ideal.
Here is an example from some code that lets you craft empty packets with custom source/destination fields. Later the buffer is used with a raw IP socket (this works on Darwin, whereas I got EINVAL before).
I have tested a good amount with Wireshark to ensure that the length, fragmentation offset, and flag fields are preserved properly in transit.
func craftPacket(p *gopacket.SerializeBuffer, src net.IP, dst net.IP) error {
	opts := gopacket.SerializeOptions{
		FixLengths: true,
	}

	ipv4 := layers.IPv4{
		Version:  4,
		IHL:      5,
		SrcIP:    src,
		DstIP:    dst,
		TTL:      64,
		Protocol: layers.IPProtocolUDP,
	}
	if err := gopacket.SerializeLayers(*p, opts, &ipv4); err != nil {
		return err
	}
	ipv4.RawSocketByteOrder(*p, binary.LittleEndian)

	return nil
}

...

p := gopacket.NewSerializeBuffer()
craftPacket(&p, src.IP, dst.IP)

fd, err := syscall.Socket(syscall.AF_INET, syscall.SOCK_RAW, syscall.IPPROTO_RAW)
if err != nil {
	panic(err)
}

if err := syscall.SetsockoptInt(fd, syscall.IPPROTO_IP, syscall.IP_HDRINCL, 1); err != nil {
	panic(err)
}

to := &syscall.SockaddrInet4{
	Addr: [4]byte{127, 0, 0, 1},
	Port: 0,
}

if err := syscall.Sendto(fd, p.Bytes(), 0, to); err != nil {
	panic(err)
}

It would be easy enough to include a function that determines host endianness, but maybe that's best left to the user? Please let me know what you think!

It's worth noting that this will require extra attention on the header deserialization side.
As reflected again in header.go, there are even more OS-dependent interpretations of IPv4 headers that must be accounted for.
I'm happy to implement and test these, but first I'd like to see what approach seems best to others.

I'm not completely sure about this, since I use those OSes only on rare occasions, but does this affect both bpf sockets and raw sockets? (So far I was under the impression this only affects raw sockets - but I might be mistaken here).

Good point - I don't believe this affects BPF sockets. Testing with gopacket's BPF sniffer, I get identical results with Wireshark, implying that maybe this byte order is only imposed by the kernel when reading from raw IP sockets.
Test packet bytes after host endianness conversion, before sending on raw socket (length is 0x001e -> 0x1e00 for little endian):

Results in Wireshark/gopacket (length is back to big endian):

A bugfix in FreeBSD 11 seems to support this:

Before FreeBSD 11.0 packets received on raw IP sockets had	the ip_len and
ip_off fields converted to	host byte order.  Packets written to raw IP
sockets were expected to have ip_len and ip_off in	host byte order.


Add Kuma charts repo

Signed-off-by: Nikolay Nikolaev<EMAIL_ADDRESS>

The Artifact Hub, a CNCF sandbox project, is another place you can list your repos. To do that, you login (or create an account), create an organization, and list your repository. You can link it to a user or organization.

@austince are you ok being listed as a maintainer on this chart?

@austince are you ok being listed as a maintainer on this chart?

Yes!


Self-remove Azure AD roles is it possible/will it be possible in the future?

Can Azure AD Admins remove themselves from any Azure AD roles that they are members of?
Just want to make clear the following
-By themselves, without asking for another GA to remove the role that was assigned
-Not only for the Company Administrator role but for any other Azure AD Admin Role

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5eac37f-77bd-6367-bf29-f4f5ffb75c6f
Version Independent ID: a9d7f46e-b074-8654-aa09-1568afa2e1d0
Content: Assign Azure AD roles in PIM - Azure Active Directory
Content Source: articles/active-directory/privileged-identity-management/pim-how-to-add-role-to-user.md
Service: active-directory
Sub-service: pim
GitHub Login: @curtand
Microsoft Alias: curtand

@aleazofeifam Thanks for your feedback! We will investigate and update as appropriate.

Duplicate issue, closing this one out and addressing issue on this git issue : https://github.com/MicrosoftDocs/azure-docs/issues/39526


Customizing the travis.yml configuration for pygen

Travis CI build is not enabled for upstream repo as of now but in the future, it will break for pygen related PRs.
Travis CI is breaking because of  - sphinx-build -E -W -b linkcheck docs/source build.
The build logs are here https://travis-ci.org/github/aneels3/riscv-dv/jobs/695695999
I have commented out the - sphinx-build -E -W -b linkcheck docs/source build  of script section of .travis.yml file and its working fine.
https://travis-ci.org/github/aneels3/riscv-dv/jobs/695700126
Is it possible to customize the CI configuration for pygen related PRs only without eliminating the sphinx-build?
@danghai @taoliug

The sphinx-build is wrong because it has a broken link.
/home/travis/build/aneels3/riscv-dv/docs/source/end_to_end_simulation.rst.rst:30:broken link: https://github.com/lowRISC/ibex/blob/master/dv/uvm/Makefile#L68 (Anchor 'L68' not found)

I think it is good to check the sphinx build. We just fix the link. It will pass the test

Got it!
Thanks @danghai

Still, I am getting the same error
https://travis-ci.org/github/aneels3/riscv-dv/jobs/695762073

The sphinx-build is wrong because it has a broken link.
https://github.com/lowRISC/ibex/blob/master/dv/uvm/Makefile#L68 at end_to_end_simulation.rst.rst line 30
/home/travis/build/aneels3/riscv-dv/docs/source/end_to_end_simulation.rst.rst:30:broken link: https://github.com/lowRISC/ibex/blob/master/dv/uvm/Makefile#L68 (Anchor 'L68' not found)

I think it is good to check the sphinx build. We just fix the link. It will pass the test

I think @udinator need to fix that link because he documented the end_to_end_simulation.rst.rst.
I see the it passed the flake8.
Warning, treated as error:
/home/travis/build/aneels3/riscv-dv/docs/source/end_to_end_simulation.rst.rst:30:broken link: https://github.com/lowRISC/ibex/blob/master/dv/uvm/Makefile#L68 (Anchor 'L68' not found)
The command "sphinx-build -E -W -b linkcheck docs/source build" exited with 2.
0.34s$ pip uninstall -y riscv-dv
Uninstalling riscv-dv-1.0:
  Successfully uninstalled riscv-dv-1.0
The command "pip uninstall -y riscv-dv" exited with 0.
0.57s$ flake8 --show-source pygen/pygen_src/ --config=.flake8
The command "flake8 --show-source pygen/pygen_src/ --config=.flake8" exited with 0.

Do you modify the source? If yes, you can create PR. Just ignore the sphinx-build.

I have modified the pygen source files for flake8 related issues only.
Should I create the PR?

yes, please go ahead to create the PR, thanks

Any update on this issue?

Hi @taoliug and @udinator
I think the issue is fixed in #738 .
If I am correct then you can close this issue for now.


Add PauseOnStart Recording Option Swagger

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
The pauseonstart call recording option was added using a new swagger spec.
New swagger: https://github.com/williamzhao87/azure-rest-api-specs/blob/5b7321a923a30b83b978e3a30ed1d497e35052fd/specification/communication/data-plane/CallAutomation/preview/2023-01-15-preview/communicationservicescallautomation.json
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-communication-callautomation


install latest go

fixes #182

Duplicate #189

This doesn't look like a duplicate of #189.  Seems #189 fixes Dockerfile-deb, whereas this fixes Dockerfile.  Case in point, I'm still seeing issue #182 on a clean pull/build.


Query the histogram for the current valid query after all other queries are finished

https://github.com/zazuko/alod/wiki/sparql_queries#histogram
Gets as input the query (filters) the pixel amount of the zack-timeline width.

works


🩹 add .formatter.exs config file to hex package

Issue
When using cva as hex dependency and using the CVA.Component approach, code formatting as documented in https://hexdocs.pm/cva/CVA.Component.html does not work.
Cause
The .formatter.exs file is missing from the published hex package.
Fix
Add .formatter.exs to the mix.exs package declaration.

Oh, this is a duplicate of #1 🤦♂ .


New reports created on powerbi.com have the new filter experience enabled. Existing reports don't

Per this documentation you need to enable this from desktop, that doesn't seem to be the case now?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 169f0fd8-5f91-c727-863e-775092492219
Version Independent ID: f2870679-e514-3e52-3513-eb62c81983c7
Content: The new filter experience in Power BI reports (Preview) - Power BI
Content Source: powerbi-docs/power-bi-report-filter-preview.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @jackwoodward -- thanks for your question! To be sure I'm answering the question you're asking: Are you asking if you no longer need to enable it in Power BI Desktop to see it in Desktop? Or are you asking if you no longer need to enable it in Power BI Desktop to see it in the Power BI service online? Thanks!

2 questions, 1. Is the intent that new reports will have the new filter pane enabled with the Power BI service(because that is what I see)? Is there a way to enable existing reports to have the new filter pane using Power BI service?

Hi, @jackwoodward -- thanks for clarifying!

Yes, new reports have the new filter pane enabled in the service.
As of today, no. Coming very soon, yes. Stay tuned!


Update mrlearning-base-ch2.md

loc header

Docs Build status updates of commit fe71f79:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch2.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Metrics $SYS Topics  include subscribe $SYS counter

I subscribe the Topic<EMAIL_ADDRESS>to keep every clientid into a database , however Metrics $SYS Topics   include broker send to subscribe $SYS ,
it inaccurate when monitor  send message per second 。

Fixed in 0.12.1 release


Not working for m.youtube.com

In kiwibrowser

For the time being, I only implemented a redirect. be1a48e743c01b49af3312d5202db5653512fe63

Kiwi browser is now supported in v1.4.0!!


Notification-PushDeer: unavailable

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
When I test with Configure PushDeer, the error is reported as in the following screenshot.
image
My key is correct and has been tested successfully on other platforms.
👟 Reproduction steps
Configure PushDeer and click the Test button
👀 Expected behavior
It looks like the PushDeer server is unavailable, I'm not sure what the program's default PushDeer API URL is, now the official default one should be: https://api2.pushdeer.com.
At the same time, I hope to add a custom API URL, because PushDeer supports setting up the user's own server, not using the official server, which is what I did. The official API also provides this parameter, the name of which should be API_BASE.
😓 Actual Behavior
The screenshot of the reported error is in the description.
🐻 Uptime-Kuma Version
1.22.1
💻 Operating System and Arch
Official Docker latest version
🌐 Browser
Google Chrome 114.0.5735.199
🐋 Docker Version
Docker 24.0.2
🟩 NodeJS Version
No response
📝 Relevant log output
No response

https://pushdeer.com/ seems to be down, but https://www.pushdeer.com/ seems not.
According to https://www.pushdeer.com/dev.html we are using their API correctly
See:
https://github.com/louislam/uptime-kuma/blob/8e72d6f5341a6c916408fc40bf81cf04173dffe6/server/notification-providers/pushdeer.js#L11-L29

Okay, so not a bug, right?
In this case:
Could you recreate this issue with the different fields in the feature_request template?
Rationale:

only louis can change tags
This removes the Server Error confusion

Alternative:
If you want to provide a PR for this, this would be appreciated. Such a PR should include screenshots that the notification provider works using https://api2.pushdeer.com/ before and after making this parameter configurable.

feature_request

Yes, sure, this is not a bug, I'll close this issue and re-submit a feature request, Thank you very much for your kind help.
But I'm sorry I don't have the development capacity to provide this PR.


Add PlotX (PLOT) to MetaMask

PlotX is a non-custodial prediction market protocol that enables users to earn rewards on high-yield prediction markets. Dubbed as the Uniswap of Prediction Markets, PlotX uses an Automated Market Making algorithm to settle markets and distribute rewards on the Ethereum Blockchain without any counterparty risk. Markets are focused on crypto-pairs like BTC-USD & ETH-USD and created in intervals of 4h, 1d, and 1w.
Media publications:

https://www.coindesk.com/investors-india-defi-scene-central-bank-ban
https://cointelegraph.com/news/looks-like-defi-is-coming-to-prediction-markets
https://www.newsbtc.com/all/former-nexus-mutual-and-govblocks-developers-launch-uniswap-for-prediction-market/
https://blockonomi.com/plotx-guide/

Website: https://plotx.io
Etherscan: https://etherscan.io/token/0x72F020f8f3E8fd9382705723Cd26380f8D0c66Bb
Github: https://github.com/plotx
Twitter: https://twitter.com/TryPlotX

Medium: https://medium.com/plotx
Facebook: https://www.facebook.com/TryPlotX
Discord: https://discord.com/invite/8CWNQnG
Reddit: https://www.reddit.com/r/PlotX/
Telegram: https://t.me/plotx_official
CoinGecko: https://www.coingecko.com/en/coins/plotx

Hi @ankit5902 - I would like to merge this request but there is a new requirement that the logo has to be in SVG format. Can I ask you to add it as a replacement for the PNG one? Thanks

@xrn Sure. I’ll get it replaced.

@xrn I have updated the PlotX (PLOT) Logo in SVG format. Kindly check and let me know if there are any changes to be made.

@ankit5902 Thanks
Please check that logo - https://github.com/MetaMask/contract-metadata/blob/bd2154811eb75deb78e1407a064f624d366e9746/images/plotx.svg seems that something is wrong here I think
Also, you did not change extension of the logo in the JSON file

Ah! I see, let me get it corrected. Thanks, @xrn!

@xrn I have updated and corrected both the JSON and SVG files. Please check and let me know if still there are any issues.

@xrn It still isn't showing the Logo on MetaMask. Is there a time frame after which it gets updated or am I missing something?

Got it, I guess it'll be pushed with the next release.

@xrn I see that the new release has already been pushed but the logo is still isn't showing on MetaMask. Is there a time frame after which it gets updated or am I missing something?

@xrn I see that the new release has already been pushed but the logo is still isn't showing on MetaMask. Is there a time frame after which it gets updated or am I missing something?

@ankit5902 please update MM extension to newest version - everything should be ok

@ankit5902 please update MM extension to newest version - everything should be ok

@xrn Already updated the MetaMask extension and the MetaMask App as well. But still, the logo isn't reflecting in either of them.

@xrn Already updated the MetaMask extension and the MetaMask App as well. But still, the logo isn't reflecting in either of them.

@ankit5902 can you send me your MM version please?

@ankit5902 can you send me your MM version please?


Add a reference anomaly

var a = { value: 1 };
var b = a;
b.value = 2;
console.log(a.value); // 2

Reference anomaly was added by 8d3b5afb0f0e7d0964c37956d95ac681f0973f6d commit. Thanks for enhancement


Support OpenCL in core and examples

Feature description
Provide support for OpenCL as first class capability.
Feature motivation
CUDA only supported on NVidia Hardware, other GPU makers are mostly behind OpenCL
(Optional) Suggest a Solution

Could be linked to #243

Could be linked to #243
WebGPU is more about portable graphics, its more in the OpenGL space, OpenCL is about accessing the GPU or other accelerators for compute resource, im not sure that these are hitting the same requirements.

https://www.techlusive.in/apps/google-chrome-gets-webgpu-tech-that-allows-high-performance-3d-graphics-1369760/#:~:text=“WebGPU is a new web,said in a blog post.

This is true, however compute shaders can be used for general cross platform GPGPU.

@thawkins have you come across a good Rust library that implements kernels for OpenCL? We don't have the specialty for writing kernels. Are there good implementations out there?
The closest that I found is TVM's C++ implementation that has Rust bindings .

No, im afraid I dont, Im just myself starting to get familiar with CUDA,
OpenCL and ML applications. Im moving from c/c++ to rust, and was looking
for a good framework to learn. All my machines are intel 11th/12th gen with
Xe, hence the interest.
I will however do some research and report back if i find anything.
On Sun, Apr 9, 2023, 01:14 Dilshod Tadjibaev @.***>
wrote:

@thawkins https://github.com/thawkins have you come across a good Rust
library that implements kernels for OpenCL? We don't have the specialty for
writing kernels. Are there good implementations out there?
The closest that I found is TVM's C++ implementation that has Rust
bindings
https://github.com/apache/tvm/blob/main/rust/tvm-sys/src/device.rs#L70.
—
Reply to this email directly, view it on GitHub
https://github.com/burn-rs/burn/issues/278#issuecomment-1500936737, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAADRSKAHEF47LJHL4VJ4BTXAGMF5ANCNFSM6AAAAAAWXHQ7XM
.
You are receiving this because you were mentioned.Message ID:
@.***>

OpenCL is deprecated in macOS. Metal framework is suggested instead. https://developer.apple.com/library/archive/documentation/Performance/Conceptual/OpenCL_MacProgGuide/Introduction/Introduction.html
I don't see much support out there and there is non that I could find for Rust.
@nathanielsimard @thawkins I would recommend we close this issue and we address the original request of non-nvidia GPU support by doing work in https://github.com/burn-rs/burn/issues/243.

Im ok, with it, as chrome 113 supports webgpu, for the record the opencl3 crate supports opencl. Also rusticl is an opencl impementation of opencl written in rust which is part of the mesa package.

wgpu also targets vulkan and metal, making it a decent choice to build a cross platform backend.
However, I'm still unsure if it's the best tech to build the most performant GPU backend, we might explore how we can call non-wgpu based kernel implementations from it.
For example, we might implement most things with wgpu, but call CuBlas for some operations that can leverage tensor cores (without having to translate the memory format). It would be nice to support specialized kernels with compilation flag to better leverage the hardware, while still being cross-platform.
I'm going to close the issue, since I don't think OpenCL will have first class support, but feel free to continue the discussion in the wgpu issue #243. If some other tech seems more promising, we might open another issue then.


Use Pandas dataframe as data structure for holding spot properties

The pipeline currently use a mix of numpy array, dictionary, and regionprops objects to store/pass the spot properties. It would be nice to switch to pandas dataframe. This will also allow easier integration with the analysis notebook, which uses dataframe as data structure.

I made a duplicate issue before seeing this one.  Here are my notes:
** What is the bottleneck? Please describe.**
After some discussion with @smguo, we realized that the "interp" or "fit" spot detection methods depend almost entirely on centroid positions and do not use the np.ndarray format. Additionally, pandas dataframes can read these centroid dictionaries easily, maintaining tabular data for easy reading and reporting.
Describe the solution you'd like and alternatives
We can continue to report the array format for intensities, antigens, etc., but this data structure should not be used before or during the spot detection.
We can remove several lines that create blank arrays: "txt_parser.create_array"
adjust "compute_od" to receive dictionaries with key, value = centroid, regionprops (instead of arrays)

good idea, pandas dataframes make sense, and will make integration with interpretation part of analysis clean.

Added dataframe for spot properties in https://github.com/czbiohub/pysero/pull/74.


Failed to fix host object open.

Trying to use your tool and i get to the point where I change the GUID's and this is the output:
PalWorldTools Version: 0.9.7 Enter new GUID: B71E8005000000000000000000000000 Enter old GUID:<PHONE_NUMBER>0000000000000000000001 WARNING: Running this script WILL change your save files... Backup recommended. Press enter to continue... Converting LocalWorldSave\Level.sav to JSON Decompressing sav file Loading GVAS file Traceback (most recent call last):   File "<string>", line 1, in <module>   File "C:\Program Files\Python312\Lib\multiprocessing\spawn.py", line 122, in spawn_main     exitcode = _main(fd, parent_sentinel)                ^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Program Files\Python312\Lib\multiprocessing\spawn.py", line 131, in _main     prepare(preparation_data)   File "C:\Program Files\Python312\Lib\multiprocessing\spawn.py", line 246, in prepare     _fixup_main_from_path(data['init_main_from_path'])   File "C:\Program Files\Python312\Lib\multiprocessing\spawn.py", line 297, in _fixup_main_from_path     main_content = runpy.run_path(main_path,                    ^^^^^^^^^^^^^^^^^^^^^^^^^   File "<frozen runpy>", line 286, in run_path   File "<frozen runpy>", line 98, in _run_module_code   File "<frozen runpy>", line 88, in _run_code   File "C:\Users\Uplin\Downloads\PalWorldSaveTools.v0.9.7\fix_host_save.py", line 1, in <module>     from fix_save import *   File "C:\Users\Uplin\Downloads\PalWorldSaveTools.v0.9.7\fix_save.py", line 23, in <module>     os.remove(file) PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'fix_save.log' Converting LocalWorldSave\Players\00000000000000000000000000000001.sav to JSON Decompressing sav file Loading GVAS file Modifying JSON save data... Converting data to SAV, saving to LocalWorldSave\Level.sav Compressing SAV file Compressing: 0% completedERROR: Unpack failed: incomplete input Press any key to continue . . .

Yeah, I realized my mistake. I've just pushed a new release. Please check on here. Thank you.


Include an example, like with glutin

I really like how I can just cargo run --example window to get some working code to poke around with in glutin.
Could something similar be provided for glium?

Everything in the "examples" directory can be run with cargo run --example foo.

Ah, that's a cargo trope I missed then.
I get a boat load (26) of compiler errors when I try to run the examples, but that might another issue.
Closing this :+1:


Error using generics: cannot find type definition: T

Describe the bug
In package httpx I have the following struct:
type Response[T any] struct {
    StatusCode int      `json:"-"`
    Data       *T       `json:"data,omitempty"`
    Errors     []string `json:"errors,omitempty"`
}

And in the handler in another package I have the following annotation:
// @Success 200 {object} httpx.Response[[]person]
person is a struct within the same package where this annotation is.
When I try to run swag, I get the following error:
2022/10/12 21:05:08 ParseComment error in file /...redacted.../internal/handler/persons.go :cannot find type definition: T
To Reproduce
Steps to reproduce the behavior:
I believe this is also explained above.
Expected behavior
Swagger docs should be generated.
 :)

Possibly useful to programmers: if I use a second reference to the same generic (but with a different sub-type), I get:
2022/10/13 09:44:56 Skipping 'main.DataObject', recursion detected.

It's like it can't handle generics within generics as it is losing reference.

Could you please try the latest PR and give me some feedback?

I have already tried fix-generics branch and it worked. Shall I still try the latest PR?

I have already tried fix-generics branch and it worked. Shall I still try the latest PR?

No need.
@JohnAD How about you?

I found that this behavior could also reproduce in an environment with the new swag v1.8.8  on Linux   go v1.19, BUT with swag v1.8.7 works well.

still broken in v1.8.9 ... (linux go 1.19)


less visibility on Hovering over github button in footer

Describe the bug
When the Github button is hovered ,it is becoming fully white and the github icon is not visible

Screenshort

I  can add different color on hovering so that it looks better.Can you assign this task to me?

Hi i am interested in working upon this issue can u assign this to me.

@MonalikaPatnaik  I can fix this issue quickly. Please assign me this issue.


rollback stop-invisible-media

FYI, I'm relying on the observeOnHidden here: #318

restored ObserverService

I'm hesitant to merge this. I think I'll a shot at adding an option into Settings (storing it in localStorage).

For the record, superseded by #323


Hide on lockscreen / notification panel

Please, add an option to hide the overlay when lockscreen is showing or when notification panel is expanded.
Since that music controls already exist on these system screens, the pill becomes redundant.

Sure about lockscreen, not sure about about notification, will try


fix(generateGraphQLHandlers): instantiate "GraphQLList" with "new"

Fixes #258

Released: v0.11.1 🎉
This has been released in v0.11.1!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/data@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


Change default port for NG Live Development Server

I use the Angular Template 2.0.0 with ASP.NET Core with Docker Support.
Here is my Dockerfile:
FROM microsoft/dotnet:2.1-aspnetcore-runtime AS base
ENV NODE_VERSION 6.11.3
ENV NODE_DOWNLOAD_URL https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz
ENV NODE_DOWNLOAD_SHA 610705D45EB2846A9E10690678A078D9159E5F941487ACA20C6F53B33104358C
RUN curl -SL "$NODE_DOWNLOAD_URL" --output nodejs.tar.gz \
    && echo "$NODE_DOWNLOAD_SHA nodejs.tar.gz" | sha256sum -c - \
    && tar -xzf "nodejs.tar.gz" -C /usr/local --strip-components=1 \
    && rm nodejs.tar.gz \
    && ln -s /usr/local/bin/node /usr/local/bin/nodejs
WORKDIR /app
EXPOSE 80

FROM microsoft/dotnet:2.1-sdk AS build
WORKDIR /src
COPY WebApps/WebSPA/WebSPA.csproj WebApps/WebSPA/
RUN dotnet restore WebApps/WebSPA/WebSPA.csproj
VOLUME ["."]
WORKDIR /src/WebApps/WebSPA
RUN dotnet build WebSPA.csproj -c Release -o /app

FROM build AS publish
RUN dotnet publish WebSPA.csproj -c Release -o /app

FROM base AS final
WORKDIR /app
COPY --from=publish /app .
ENTRYPOINT ["dotnet", "WebSPA.dll"]

I want code changes (Typescript, HTML, CSS, ...) to show up in the browser without having to restart the whole docker-compose.
But it doesn't seem to work.
Now I saw following entry in the Debug output:

info: Microsoft.AspNetCore.SpaServices[0]
Starting @angular/cli on port 44695...

ng serve --extract-css "--port" "44695"
** NG Live Development Server is listening on localhost:44695, open your browser on http://localhost:44695/ **

Microsoft.AspNetCore.SpaServices:Information:

<EMAIL_ADDRESS>start /app/ClientApp

Where does the port number come from, since the "start" entry in the package.json is only "ng serve --extract-css".
My theory is, if I can change this port to "80" the code changes will show up.
How do I solve this issue?

Hi. It looks like this is a question about how to use ASP.NET Core. While we do our best to look through all the issues filed here, to get a faster response we suggest posting your questions to StackOverflow using the asp.net-core-mvc tag.

@SteveSandersonMS, any suggestions here? Thanks!


Not obvious distributions for categorical features

Not obvious distributions for categorical features
Summary
I want to see difference in Feature attribution window for two groups and for categorical feature, that has two possible values Mobile and Desktop.
As I can See:
Group0 has MOBILE: 1361   DESKTOP: 1478
Group1 has  MOBILE: 3282  DESKTOP:  2823
Expected Behavior
I expected to see two bar charts, that reflects distribution differences
Current Behavior
I see barcharts that don't reflect anything

Context and Environment
Browser - Chrome. npm 6.16, manifold  v0.0.1
Behaviour is the same as in http://manifold.mlvis.io/

Thank you for bringing this up. @Lomdjaria1
The current design was optimized for features with multiple categories (ref).
There's definitely space for improvement.
Mind opening a PR or suggest a design? : )

I don't understand how current layout was made? I suppose, that overlapped barcharts, with percentages of such type will be more informative. For example: I would like to see, that in group 1: mobile - is 12% precent of data, but in group1 - mobile is 40% . (on y_axis = 0.12 and 0.4)


[RFC][DNM]DTS service nodes

This is an attempt to expose "software services" as DTS nodes.
Software services are mostly all these code being initialized through SYS_INIT() (it currently creates a struct device, but most of them are just not devices per-se)
Exposing them is a primary requirement for fixing #22545
(Or then we will have a problem with all these hardcoded leve/prio used on SYS_INIT())
So I took a quick example with the UART console for qemu_x86, so you'll get an idea.
I put it into a services {} .dtsi root node, it has nothing to do in soc {}, as it is not a hardware device being exposed.

@tbursztyka not sure I follow what info you are trying to encode and extract from the DTS for this purpose.

If we go this way we might need to reconsider rewriting this section a bit:
https://docs.zephyrproject.org/latest/guides/dts/dt-vs-kconfig.html
Since it will no longer be true.
@mbolivar and @galak comments welcome.

@galak check mbolivar's issue #22545 this won't be really reliable without exposing all build time init level/prio based objects (which are all struct device). There will be nothing to help the user setting the level/prio properly by hand if, depending on the device tree, the dependency devices (uart in case of uart console) have level/prio varying depending on the board/config/build/etc... Getting rid of pre_kernel_<1/2> will not be possible either.
@carlescufi DTS could help to set some options, like the uart dev name being used for the uart console. But I would not switch all the options to DTS. That said, I don't think the mentioned documentation needs to be updated: for instance if the user unset CONFIG_UART_CONSOLE via menuconfig, the uart console service won't be built anyway.
Note as well that some services are in fact a mix of hardware and software service, such as the rtt based console. The line is quite blurry sometime.

this won't be really reliable without exposing all build time init level/prio based objects (which are all struct device).

The fact that they are all struct device seems to be a historical artifact. I'm not sure I agree we should be putting software objects into DT. That doesn't seem to be what it's for.

The fact that they are all struct device seems to be a historical artifact.
Indeed. However, because of dependency between devices and such software services (in this example: uart console needs the uart device to be initialized first), you must keep all of them in the same initialization ordered list anyway. Unless you start to bloat things up (having some slist or else), but this is exactly what I don't want to do.

I think software dependencies could be managed entirely in software, though, e.g. by letting system initialization functions declare the devices they need set up before they run, rather than mixing software into DT.

No, you cannot do that: the array of device should be fully in rom and not reshuffled at run-time. That would be a regression in term of memory usage. Current situation is already not the best, that would just get things worse.

I think this deserves some measurement. Allocating an entire struct device for a single function is also a waste of space.

I think this deserves some measurement. Allocating an entire struct device for a single function is also a waste of space.

On that we agree. I already started a few days ago to rework struct device and all to fix that issue.
I did mentioned it in #22941 issue number 9.

On that we agree. I already started a few days ago to rework struct device and all to fix that issue.

Do you have any code to share? Now that #23245 is basically ready to go in and I have some bandwidth back, I would like to start discussing devicetree.h vs. device.h issues more seriously.

@mbolivar-nordic I have a draft still in wip state. Anyway, let me close this RFC as it's a wrong approach altogether.

@mbolivar-nordic I have a draft still in wip state. Anyway, let me close this RFC as it's a wrong approach altogether.

If you have a branch you can post I would be very curious to see it with a full understanding that it's WIP. If not, any idea when you will have one?

just look at my drafts, I updated #22941 with references there

Let's close this one, as it won't go any further.


Crash on startup with latest wheel

=== ENDSTONE CRASHED! - PLEASE REPORT THIS AS AN ISSUE ON GITHUB ===
Operation system: Windows
Endstone version: 0.5.6.dev71
Api version     : 0.5
Description     : Signal received: 22
Stack trace (most recent call first):
[0 ] 0x7ffad4a1049e     (0x1800e049e) in endstone::detail::`anonymous namespace'::signal_handler(int) at D:\a\endstone\endstone\src\endstone_runtime\windows\signal_handler.cpp:47
[1 ] 0x7ffb812ce6d4     (0x18007e6d4) in raise
[2 ] 0x7ffb812cf6e0     (0x18007f6e0) in abort
[3 ] 0x7ffb812cee18     (0x18007ee18) in terminate
[4 ] 0x7ffb6be31910     (0x180001910) in  ??
[5 ] 0x7ffb6be3218e     (0x18000218e) in  ??
[6 ] 0x7ffb6be321e8     (0x1800021e8) in  ??
[7 ] 0x7ffb6be34018     (0x180004018) in __CxxFrameHandler4
[8 ] 0x7ffb8395527e     (0x1800a527e) in __chkstk
[9 ] 0x7ffb838ce885     (0x18001e885) in RtlFindCharInUnicodeString
[10] 0x7ffb83904954     (0x180054954) in RtlRaiseException
[11] 0x7ffb80dffa4b     (0x18005fa4b) in RaiseException
[12] 0x7ffb6bf05266     (0x180005266) in _CxxThrowException
[13] 0x7ffad4a20cf2     (0x1800f0cf2) in nlohmann::json_abi_v3_11_3::detail::json_sax_dom_parser<nlohmann::json_abi_v3_11_3::basic_json<std::map, std::vector, std::basic_string<char, std::char_traits, std::allocator >, bool, __int64, unsigned __int64, double, std::allocator, nlohmann::json_abi_v3_11_3::adl_serializer, std::vector<unsigned char, std::allocator >, void> >::parse_errornlohmann::json_abi_v3_11_3::detail::parse_error(unsigned int, unsigned int, std::basic_string<char, std::char_traits,  at C:\Users\runneradmin.conan2\p\nlohm0567ffc90cfc1\p\include\nlohmann\detail\input\json_sax.hpp:290
[14] 0x7ffad4a234d8     (0x1800f34d8) in nlohmann::json_abi_v3_11_3::detail::parser<nlohmann::json_abi_v3_11_3::basic_json<std::map, std::vector, std::basic_string<char, std::char_traits, std::allocator >, bool, __int64, unsigned __int64, double, std::allocator, nlohmann::json_abi_v3_11_3::adl_serializer, std::vector<unsigned char, std::allocator >, void>, nlohmann::json_abi_v3_11_3::detail::input_stream_adapter>::sax_parse_internal<nlohmann::json_abi_v3_11_3::detail::json_sax_dom_parser<nlohmann::json_abi at C:\Users\runneradmin.conan2\p\nlohm0567ffc90cfc1\p\include\nlohmann\detail\input\parser.hpp:425
[15] 0x7ffad4a2f3cb     (0x1800ff3cb) in nlohmann::json_abi_v3_11_3::detail::parser<nlohmann::json_abi_v3_11_3::basic_json<std::map, std::vector, std::basic_string<char, std::char_traits, std::allocator >, bool, __int64, unsigned __int64, double, std::allocator, nlohmann::json_abi_v3_11_3::adl_serializer, std::vector<unsigned char, std::allocator >, void>, nlohmann::json_abi_v3_11_3::detail::input_stream_adapter>::parse(bool, nlohmann::json_abi_v3_11_3::basic_json<std::map, std::vector, std::basic_string<c at C:\Users\runneradmin.conan2\p\nlohm0567ffc90cfc1\p\include\nlohmann\detail\input\parser.hpp:126
[16] 0x7ffad4a2e1fa     (0x1800fe1fa) in endstone::detail::EndstoneLevel::loadResourcePacks() at D:\a\endstone\endstone\src\endstone_core\level\level.cpp:126
[17] 0x7ffad4a24efe     (0x1800f4efe) in endstone::detail::EndstoneLevel::EndstoneLevel(endstone::detail::EndstoneLevel*) at D:\a\endstone\endstone\src\endstone_core\level\level.cpp:42
[18] 0x7ffad49b57a3     (0x1800857a3) in std::make_unique<endstone::detail::EndstoneLevel, Level &, 0>(Level&) at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory:3382
[19] 0x7ffad49ce080     (0x18009e080) in ServerInstanceEventCoordinator::sendServerThreadStarted(ServerInstance&) at D:\a\endstone\endstone\src\endstone_runtime\bedrock\world\events\server_instance_event_coordinator.cpp:50
[20] 0x7ff6a55c2985     (0x141312985) in  ??
[21] 0x7ff6a5518a7d     (0x141268a7d) in  ??
[22] 0x7ffb81279332     (0x180029332) in _recalloc
[23] 0x7ffb82be259c     (0x18001259c) in BaseThreadInitThunk
[24] 0x7ffb8390af37     (0x18005af37) in RtlUserThreadStart

Interesting. It seems the issue is caused by a broken json. Can you check if the world_resource_packs.json under your world folder is valid?

I do have comments in the world_resource_packs.json but otherwise it is formatted correctly and would normally load in vanilla BDS.

Just tested it, it was the comments lol

Thanks. That explains. I've recently updated the loading mechanism of resource packs to support a mixture of folder packs specified in world_resource_packs.json and zipped packs. To do that we load the world_resource_packs.json first and append any zipped packs to the list. The library we use raises an exception when encountering comments by default (see: https://json.nlohmann.me/features/comments/). Explicitly telling it to ignore the comments should fix the error.


Regridder to conserve horizontal mass fluxes

@sdeastham has requested a MAPL regridding option to provide exact regridding for horizontal mass fluxes  to a coarse grid from a fine grid that nests "exactly".   E.g.  C90 and C360.   The basic ideas is that conservation is then a simple process of summing the fluxes from the finer grid.   Generalization would be nice, but is not essential.

NOTE:   I encountered a surprise that will require more thought on our end when I started sketching out the process.   You are welcome to read below, as it is at least indicative of what needs to be done.       If I knew for certain how to ensure that ESMF conservative regridding would include the cells with the correct edges then this could just be a matter of setting up some custom weights  in an initialize method.   But ESMF works with overlapping areas which makes edges potentially fragile constructs under roundoff.   Our older system would work well for this, but ... it is the older system and not used.
MAPL already has hooks to introduce variant regridders.     The capability is almost pointless now given that ESMF regridding is used in almost all cases, but fortunately it was not eliminated and remains as a means to implement the desired functionality.    The no longer used lat-lon to lat-lon regridder at
https://github.com/GEOS-ESM/MAPL/blob/main/base/MAPL_LatLonToLatLonRegridder.F90
can be used as a rough guide.
Basically a new subclass (type extension) of AbstractRegridder must be implemented that provides concrete methods for  the various regrid_*() type-bound procedures and the initialize() method.    And actually, the scalar regridding can be ignored, as that case does not make sense.      I think we should also assume that the decomposition is "friendly" in that the edges to be summed together should all fall on a single process.  (Bonus points to at least add a check to enforce this.)
The first step would be to determine during initialize the nesting factor  N between the 2 grids.   Lots of heuristics suggest themselves.
Then in the vector regrid procedures, one would have outer loop over the coarse (target) grid points, and an inner loop over the contained segments of the fine (source) grid:
do k = 1, LM
     do j = 1, JM
          jj = 1 + (j-1)*N
          do i  = 1, IM
               m_y = 0
               do ii = 1 + (i-1)*N, i*N
                    m_y = m_ y + v_in(ii,j,k)
               end do
              v_out(i,j,k) = m_y
         end do
    end do
end do

There would be a similar loop for the x-fluxes which would have an inner loop over the j coordinate:
do k = 1, LM
     do i  = 1, IM
          ii = 1 + (i-1)*N
         do j = 1, JM
               m_x = 0
               do jj = 1 + (j-1)*N, j*N
                    m_x = m_ x + u_in(ii,j,k)
               end do
              u_out(i,j,k) = m_x
         end do
    end do
end do

The final step is to register the new subclass and a unique integer "method".   But that ties into the big caveat at the beginning of this post.

Thanks Tom! I want to make sure I understand correctly before I act. Am I right in thinking that this could currently be implemented using the "old" techniques without necessarily causing a problem, but that it will be non-trivial to develop an "ESMF-based" method? Or is there a way already in which the ESMF regridding will interfere?

It could have been implement in the older mechanism in a straightforward manner, but ... the older mechanism is not used in ExtData so it won't help us now.      Doing this as a custom ESMF regridder might be possible, but I currently don't know how to force ESMF to choose the right cells.     Setting the weights is otherwise straightforward, and we'd be able to loosen the constraint that both grids divide evenly into the process topology.
The way forward is probably to slightly extend the new manager mechanism to allow alternative regridders to be injected.    It has the ability to use them, just no interface to add them in in the first place.   I think what I want to do is change the RegriddingMethod into a derived type (currently it is an integer).   I can then make the existing support use EsmfRegriddingMethod, and introduce a new derived type for your case.   This lets us keep the single interface for adding regridders.    ExtData would then just need a modify the logic for how it specifies the RegriddingMethod argument.   Unfortunately, History would also need corresponding modifications.    Not terribly hard, but would need to be tested thoroughly before we add your case in.
It won't hurt for you to also request this capability from ESMF itself in the mean time.    On their end they probably have to add 2 different regridding methods:  one for Mx and one for My, as they don't recognize vectors.   I'm sure they cannot get it to you quickly, but it will allow MAPL to drop the custom code if/when they do add that capability.

Hmm. Had not realized that the line of dashes was making my "note" above bold and large font.  Had not meant to "scream".  Sorry about that.
Gave this a bit more thought and came back to the same conclusion.  Here are the implementation steps (and rough guidance on GMAO vs GCHP regarding who should implement):

(GMAO) Introduce new base class for regridding methods.       Possibly this can be the existing ESMF derived type, but often their use of "sequence" precludes type extension in the way that I envision.   The goal is to end up with 2 derived types that both extend some base type, with the ESMF regridding methods associated with one class and our extensions associated with the other.
(GMAO) Modify existing references to regridding methods to use the type from (1) associated with ESMF methods.
(GCHP) in ExtData where the regridding method is determined, detect if "horizontal conserve" (or whatever we call it) and encapsulate in the new derived type.
(GMAO) modify logic in new RegridderManager to check the type of the regridding method and either use EsmfRegridder (as it is now) or CustomHorzConservativeRegridder (or whatever we call it).
(GCHP) Implement a subclass of AbstractRegridder for this scenario along the lines described at the beginning of this thread.

Item (4) should eventually be improved so that we register prototypes.   But until there is more than one custom case this is not necessary.
I'll try to tackle at least (1) today.

Just a note to myself:  confirming that one cannot "extend" ESMF types:
/gpfsm/dswdev/tclune/GEOS-ESM/GEOSgcm/src/Shared/@MAPL/base/CustomRegridMethod.F90(8): error #8204: The parent of an extended type cannot have the BIND attribute or SEQUE\
NCE property.
   type, extends(ESMF_RegridMethod_Flag) :: CustomRegridMethod
-----------------^

That breakdown of responsibilities for implementation makes sense to me. Assuming I understand correctly, I'll wait on completion of (2) (or at least (1)) before embarking on (3) or (5).

I suspect I'll do most of everything in the end anyway - just to have something to exercise the new machinery.    But I'll leave it to you to test with real use cases.
Below is mostly catharsis for myself, but others may find the reasoning useful:
I did a fair bit on this on Monday, and decided I was making a mess by cleaning  and extending at the same time.   Started over Tuesday and did a quick sweep of cleaning some things that were simply in the way.  (Mostly cases where we were a bit lazy and had multiple modules and/or types declared in the same file.)
I'm now fence sitting between two implementation choices.    In the older grid manager,  there was a look up table for the class of regridder to be used.   The key to the table was a triple  (grid type in, grid type out, and regrid method).   This reflected the granularity of the home-grown regridding methods in MAPL.     As we switched to ESMF, we could use the same class regardless of grid types, and eventually (albeit temporarily given the case at hand) for all regrid methods.    So the registry was removed.     I'm torn between re-introducing the registry (which might allow us to have a single RegridderManager again!), and converting the method specification from integer to derived types which would then be used to control the class of Regridder.
The latter probably involves fewer changes and meets the existing case reasonably well.   It does not quite work with arbitrary grid types though, which suggests the registry would be a more robust solution.       Alternatively, the old registry needs to get a bit smarter so that we don't have to explicitly list every possible combination of grid types and regrid methods that are supported by ESMF.   (If we have just lat-lon, CS, and tripolar, there are already O(50) combinations.)
Possibly the right thing to do is to introduce a new method for the RegridderClass family which checks whether it can handle particular grid types and methods.     The EsmfRegridder can then basically ignore the grid type and just check that the method is one of the ones defined by ESMF.   The old home-grown regridders (still used in some bits of GEOS), can do a more explicit check. E.g., the LatLonToLatLonRegridder would check that both grids are, er, lat-lon, and that the method is either bilinear or conserve.

OK - the basic infrastructure is now in place on branch feature/tclune/#637-horz-conserve-regridder
There is a stub implementation of HorzFluxRegridder.F90 in MAPL/base.    I suspect I need to do the rest of the implementation, but it really should be very much like I sketched out at the beginning of this issue.

The intermediate progress is now merged into the develop branch, so no need to look at the feature branch.

Wow - it has already been 2 months since this was (re) opened!    I think I now finally have some time to address the issue.   I'll catch up on the weekly telecon to be sure I capture any work @sdeastham has done in the mean time.

This is nominally completed no on the feature/tclune/#637... branch.     Almost worked right out of the box - just needed some little tweaks for the declaration of ESMF arguments.    Tested with synthetic case using @bena-nasa 's ExtDataDriver.   Now could use some more thorough testing before being merged.

Great! Attempting a merge into GCHP now - I'll try to test this out with some mass fluxes over the next few days.

@tclune - merge went smoothly, and just ran the first test (regridding from C90 to C30). Results not quite as expected, so wanted to check that I'm doing things correctly:

Getting MFXIN and MFYIN through ExtData.rc with the following line:

MFXIN;MFYIN 'kg s-1' N H F0;003000 none 1.00 MFX;MFY  ./Met_c90/tavg1_3d_asm_CSv-/%y4%m2/Heracles-5_4_p3.tavg1_3d_asm_CSv-.%y4%m2%d2_%h230z.nc4 2000-01-01T00:00:00P01:00

Specifying MFXIN and MFYIN imports in our gridded component with (does this perhaps need a rotation keyword?):

      call MAPL_AddImportSpec ( gc,                                  &
           SHORT_NAME = 'MFXIN',                                     &
           LONG_NAME  = 'x-direction_mass_flux',                     &
           UNITS      = 'kg s-1',                                    &
           DIMS       = MAPL_DimsHorzVert,                           &
           VLOCATION  = MAPL_VLocationCenter,           RC=STATUS  )
      _VERIFY(STATUS)

At the moment, I get the result below. Top row is the true mass fluxes at c90, in the X (left) and Y (right) directions. Below is the result at c30; the increase in magnitude looks about right (~3x, although I truncated the color bars) but otherwise looks like perhaps there is an issue with rotation and/or placement?

Follow-up: this issue appears to be sensitive to the number of cores (see figure below, which shows a c90 simulation and then a c30 simulation using online regridding with 24, 12, and 6 cores). Most interestingly, the X and Y mass fluxes respond differently?

Sorry - I missed this email is a blizzard of other GEOS-ESM traffic.       I think you are correct that this is probably related to the "rotate" option.       Worst case is that I need to add a mechanism to deactivate some otherwise automatic treatment of vectors that operates at a higher level in the call sequence.

I spent a bit of time on this, but am still none the wiser.    The synthetic data I originally tested with was constant which clearly would not reveal any pattern like what you are seeing above.   But it does indicate that X and Y are not being mixed, which eliminates certain types of issues.
I'm going to try to modify the synthetic case to have more useful results.   I'll also speak with @bena-nasa to see if there is something outside regridding for vector cases that I've not properly understood.

This made me think I should add something to my tester so that I could fill in something other than constant values so I added the ability to use the grid lats and lons from the grid in the expression used to fill in the variables when generating the synthetic data. I then tested this on top of Toms flux regridding branch and ran the test case I provided him utilizing the new flux regridding option. Instead of constants I put the lons in the x flux and the lats in the y flux. When I did this I found I was getting different results on 6 or 12 processors so something seems wrong.

OK - I'll double check my code again.    The decomposition dependence is an important clue.
In theory we should be able to look at 3 neighboring cells in the input data (with the right modulo wrt the nesting ratio) and add the fluxes by hand.   And then go see what is in the output grid at the corresponding position.

Shouldn't this be ii, and not i on the right hand side of that expression:
https://github.com/GEOS-ESM/MAPL/blob/feature/tclune/%23637-horz-mass-flux-regrid/base/HorizontalFluxRegridder.F90#L144
Likewise for the y fluxes, j->jj?

Yep, that fixed in my layout test. I get the same answer now on difference core counts.

I pushed to the branch with this fix Seb if you want to pull and try again.

Looks good! Preliminary tests show that the online regridding
a) reproduces the expected fluxes based on hand regridding;
b) yields the same results with 6 and 24 cores;
c) produces reasonable transport; and
d) seems to result in pressure errors which are ~30 times smaller (at c30) than when using winds (compared to ~10 times smaller at c90).
That last line is subject to (a lot) more testing, but seems encouraging!


Error in mnist_1.0_softmax.py with tensorflow 1.0

I have an error when I run mnist_1.0_softmax.py with tensorflow 1.0.
$ python3 mnist_1.0_softmax.py
Successfully downloaded train-images-idx3-ubyte.gz 9912422 bytes.
Extracting data/train-images-idx3-ubyte.gz
Successfully downloaded train-labels-idx1-ubyte.gz 28881 bytes.
Extracting data/train-labels-idx1-ubyte.gz
Successfully downloaded t10k-images-idx3-ubyte.gz 1648877 bytes.
Extracting data/t10k-images-idx3-ubyte.gz
Successfully downloaded t10k-labels-idx1-ubyte.gz 4542 bytes.
Extracting data/t10k-labels-idx1-ubyte.gz
Traceback (most recent call last):
  File "mnist_1.0_softmax.py", line 78, in <module>
    I = tensorflowvisu.tf_format_mnist_images(X, Y, Y_)  # assembles 10x10 images by default
  File "/Users/guillaumegirou/dev/tensorflow/tensorflow-mnist-tutorial/tensorflowvisu.py", line 42, in tf_format_mnist_images
    everything_incorrect_first = tf.concat(0, [incorrectly_recognised_indices, correctly_recognised_indices]) # images reordered with indeces of unrecognised images first
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/ops/array_ops.py", line 1047, in concat
    dtype=dtypes.int32).get_shape(
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 651, in convert_to_tensor
    as_ref=False)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 716, in internal_convert_to_tensor
    ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 176, in _constant_tensor_conversion_function
    return constant(v, dtype=dtype, name=name)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 165, in constant
    tensor_util.make_tensor_proto(value, dtype=dtype, shape=shape, verify_shape=verify_shape))
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/tensor_util.py", line 367, in make_tensor_proto
    _AssertCompatible(values, dtype)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/tensor_util.py", line 302, in _AssertCompatible
    (dtype.name, repr(mismatch), type(mismatch).__name__))
TypeError: Expected int32, got list containing Tensors of type '_Message' instead.

I needed to rollback to tensorflow 0.12.1
pip3 install 'tensorflow==0.12.1' --force-reinstall

Same issue -- thanks for the workaround.

I migrated the code to TF 1.0 and submitted a pull request.

Thanks Guillaume and quarkw. I know about this an I plan to fix it next week. Your pull req. will help.

Thanks for the workaround! @martin-gorner may I suggest updating the readme to reflect this requirement until your fix is pushed?

Hi, I'm having problem when using python3 mnist_1.0_softmax.py in Windows. It return errors as below
'python3' is not recognized as an internal or external command,
operable program or batch file. Any advice for this?

Yes. I having the same wrong here.And also put a question on stack overflow😂

Please follows the Windows installation instructions in the INSTALL.txt file. In short, install Anaconda, it comes with a command line whre you can issue Python commands (maybe in the Anaconda install, "python3" is just "python"). In any case, you type this in the Anaconda command line window, not the Windows command line.
Closing this issue because it is about TF1.0 compatibility, not windows compatibility.

I work with Windows 7/64, Phyton 3.6.0 Anaconda 4.3.0 (64bit), TF1.0.
I cloned the updated example and run the mnist_1.0_softmax.py (after commit +init = tf.global_variables_initializer()).
Te same error as above: TypeError: Expected int32, got list containing Tensors of type '_Message' instead.
Here is lising:
C:\ProgramData\Anaconda3\Scripts\tensorflow-mnist-tutorial>python mnist_1.0_softmax.py
I d:\build\tensorflow\tensorflow_gpu-r0.12\tensorflow\stream_executor\dso_loader.cc:128] successfully opened CUDA librar
y cublas64_80.dll locally
I d:\build\tensorflow\tensorflow_gpu-r0.12\tensorflow\stream_executor\dso_loader.cc:128] successfully opened CUDA librar
y cudnn64_5.dll locally
I d:\build\tensorflow\tensorflow_gpu-r0.12\tensorflow\stream_executor\dso_loader.cc:128] successfully opened CUDA librar
y cufft64_80.dll locally
I d:\build\tensorflow\tensorflow_gpu-r0.12\tensorflow\stream_executor\dso_loader.cc:128] successfully opened CUDA librar
y nvcuda.dll locally
I d:\build\tensorflow\tensorflow_gpu-r0.12\tensorflow\stream_executor\dso_loader.cc:128] successfully opened CUDA librar
y curand64_80.dll locally
Successfully downloaded train-images-idx3-ubyte.gz 9912422 bytes.
Extracting data\train-images-idx3-ubyte.gz
Successfully downloaded train-labels-idx1-ubyte.gz 28881 bytes.
Extracting data\train-labels-idx1-ubyte.gz
Successfully downloaded t10k-images-idx3-ubyte.gz 1648877 bytes.
Extracting data\t10k-images-idx3-ubyte.gz
Successfully downloaded t10k-labels-idx1-ubyte.gz 4542 bytes.
Extracting data\t10k-labels-idx1-ubyte.gz
Traceback (most recent call last):
File "mnist_1.0_softmax.py", line 78, in
I = tensorflowvisu.tf_format_mnist_images(X, Y, Y_)  # assembles 10x10 images by default
File "C:\ProgramData\Anaconda3\Scripts\tensorflow-mnist-tutorial\tensorflowvisu.py", line 42, in tf_format_mnist_image
s
everything_incorrect_first = tf.concat([incorrectly_recognised_indices, correctly_recognised_indices], 0) # images r
eordered with indeces of unrecognised images first
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\ops\array_ops.py", line 1075, in concat
dtype=dtypes.int32).get_shape(
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\framework\ops.py", line 669, in convert_to_tensor
ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\framework\constant_op.py", line 176, in _constant_t
ensor_conversion_function
return constant(v, dtype=dtype, name=name)
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\framework\constant_op.py", line 165, in constant
tensor_util.make_tensor_proto(value, dtype=dtype, shape=shape, verify_shape=verify_shape))
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\framework\tensor_util.py", line 367, in make_tensor
_proto
_AssertCompatible(values, dtype)
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\framework\tensor_util.py", line 302, in _AssertComp
atible
(dtype.name, repr(mismatch), type(mismatch).name))
TypeError: Expected int32, got list containing Tensors of type '_Message' instead.


When is this package ready for usage with graphene 3.1?

Hi, and this is a much requested package so thanks for the initiative!
I'm having trouble combining this package with graphene version 3.1, and I cannot find the package on pypi.org.
Is there a reason to that, or is it not ready yet? If so, do you think it will be ready soon?
I cannot start using graphene 3.1 without proper graphql federation support.
My goal is to have this graphql gateway work with graphene 3.1 and graphql federation:

https://github.com/hansehe/graphql-gateway

It's currently working with graphene 2.9 and the graphene_federation 0.1.0 package.
It also works with the Strawberry graphql package, both for graphql federation v1 and v2.

Hey Hans,
this package is a fork of the original preply/graphene-federation package including changes and updates to make it compatible with v3.
@tcleonard probably knows best what is required to support Graphene 3.1.
Since the original package is hosted by preply, they also own the PyPi access. We haven't had the time to contact them yet, but still wanted to make the updates visible to everyone. This was possible due to the MIT License of the preply package. I will try to contact them soon. Until then, you can use pip/conda to install the release tag of this repo:
pip install https://github.com/graphql-python/graphene-federation/archive/refs/tags/v3.0.0.tar.gz

Ok, I'll try it out and thanks in the meantime.

What kind of issues do you get with graphene 3.1?
I am using it with graphene 3.x already but maybe I didn't encounter the same issue as you do...

Using graphene 3.1 had a version dependency on graphql-core, that doesn't match the version required by graphene-federation. And due to that, my application won't start it seems.

This could the cause:
https://github.com/graphql-python/graphene-federation/blob/c65d2bb18836c244ed2c8da55515d1b652f4845c/setup.py#L36
The referenced PR has since been released, so we should be able to increase the version

I've fixed setup.py. @hansehe Please try this PR out:
https://github.com/graphql-python/graphene-federation/pull/3
pip install git+https://github.com/graphql-python/graphene-federation.git@refs/pull/3/head

Hi again, and sorry for delaying.
So your new graphene-federation package solved the basic problem with my service not working, so now that works!
Both queries, mutations and subscriptions (through websockets) work.
However, I still cannot get my graphql-gateway service work with the new versions of graphene3 and graphene-federation.
The graphql-gateway is a node based apollo server with the graphql federation implementation.
I get it to work with graphene2 and corresponding version of graphene-federation, and it works with https://strawberry.rocks/.
Do you see any reason on why it doesn't work?
The graphl-gateway service throws this exception:
"Error: request to http://localhost:8181/graphql/ failed, reason: connect ECONNREFUSED <IP_ADDRESS>:8181",
            "    at new CombinedError (/app/node_modules/graphql-tools/src/stitching/errors.ts:85:5)",
            "    at Object.checkResultAndHandleErrors (/app/node_modules/graphql-tools/src/stitching/errors.ts:107:11)",
            "    at Object.<anonymous> (/app/node_modules/graphql-tools/src/stitching/delegateToSchema.ts:94:14)",
            "    at step (/app/node_modules/graphql-tools/dist/stitching/delegateToSchema.js:40:23)",
            "    at Object.next (/app/node_modules/graphql-tools/dist/stitching/delegateToSchema.js:21:53)",
            "    at fulfilled (/app/node_modules/graphql-tools/dist/stitching/delegateToSchema.js:12:58)",
            "    at <anonymous>",
            "    at process._tickDomainCallback (internal/process/next_tick.js:228:7)"

So the graphql-gateway service is able to initially federate the schema from the graphene3 service, but raises an exception when delegating a request to the service. It states clearly some schema delegation error.

Are you sure it's not a problem in your schema itself... it's hard to tell without the query in question and the corresponding schema.
I have been able to use this lib with apollo gateway and a federated schema using graphene 3.1 so I'm not sure what are the specificity of your setup that cause problem...

Ok, maybe there is something wrong with my gateway then.
Do you have an example code of your apollo gateway that I can test?

Finally made it work! Seems like I did something wrong, but I made it work like this:
https://github.com/hansehe/graphql-gateway/blob/master/examples/GrapheneExample/main.py


Make $settings public

Hello, I need a way to access Layout names (before registration), but I can't seem to find an api to get them. It seems the name and label are both passed to settings, but I can't access settings because it's protected.
Would it be possible to either make $settings public; or add some public methods to get a fields name or label?

II would be open to adding $name and $label properties to the field class. Making $settings public could introduce side effects and increase the likelihood of mistakes. In the future, using property hooks may help with this.

a solution right now for @kevinruscoe could maybe be to extend the Layout class and write custom getters for name/label?

to fix your trouble check this solution click
maybe this will solve your problem.

I'm also in need of access to the $name and $label properties, among other settings. I have used ReflectionClass in the past:
$property = (new \ReflectionClass($field))->getProperty('settings');
$property->setAccessible(true);
$settings = $field->settings;

@vinkla and I have talked about this in the past on PR #139, and concluded not to add a getter method to make $settings accessible. But I think php 8.4's Asymmetric Property Visibility addresses the concerns that prevented that PR from merging; eg. protected array $settings; becomes public protected(set) array $settings; -- this makes $settings public for the "read" scope while keeping it protected for the "set" scope.


Defect fix  # Delete it after merging to common master

defect fix for:- My Know-how dashboard rename functionality not working fine.

Code is merged and pushed to common master


TZNames.GetCountryNames() throws ArgumentNullException

I'm having a hard time figuring this out. I'm trying to get all country names for a language, but TZNames.GetCountryNames() keeps throwing an exception (I've reduced the code to something as simple as TZNames.GetCountryNames( "en" )).
The weird thing is that it only throws an exception in my actual code, but not in my test code! I tried to take a picture of the exception message:

According to the stack trace it happens in GetLanguageKey(), but I couldn't figure out why.
at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
at TimeZoneNames.TZNames.GetLanguageKey(String languageCode)
at TimeZoneNames.TZNames.GetCountryNames(String languageCode)

Interesting.  I cannot reproduce though.
Can you tell me more about your environment?  What version of .NET are you targeting? What version of Newtonsoft.Json is in your project?  What version of Visual Studio are you debugging with?
Thanks.

So I cannot reproduce it either; that is, I'm only able to reproduce it in my particular solution, but I cannot create a minimal working example that fails.
I'm developing on Windows 10 in VS 15.3.5, targeting .NET 4.6.1 (using the new project structure) with Newtonsoft.Json 10.0.3.
I managed to debug the code using a locally compiled version of the TimeZoneNames project and its pdb. The problem seems to be that Data is empty! CldrLanguageData is empty, so GetLanguageSubkey() is called and returns null since keyParts only contains a single element ("en"). So, there seems to be two problems: GetLanguageKey doesn't guard properly for null keys returned from GetLanguageSubkey(), but more importantly, Data doesn't get populated.

Okay, so I think I've figured it out. The problem seems to be caused by TimeZoneData.Load() using JsonSerializer.CreateDefault(). We override JsonConvert.DefaultSettings in our WebApiConfig file to use snake-case property encoding (MyProperty -> my_property), among others.
Changing JsonSerializer.CreateDefault() to JsonSerializer.Create() fixes the problem.

Nice find!  I think I've been just used to using CreateDefault instinctively. 😉
And thanks for the PR.  I'll merge and ship it in the next few days or so.


New batch library export

Hello
Thank you for MzMine3, it is a great software!
I want to use it for MSMS annotation for 1) database generation and 2) matching new experiments to these databases.
In the new version a "Batch spectral library generation" feature is available, which causes some problems for me.
Basic information

My operating system and version: Windows 10
My MZmine version: 3.3.0

What happened
After generation of feature lists from different files, I selected a couple of example spectra to export. Their names and adducts were set and then I wanted to export them (see attached screenshot).
However, I am getting the error (not in the message box but in the red text at the bottom of the window) that the export cannot be generated as an object "AdductType" is None.
Is this a bug or did I forget to set some parameter? Or is this AdductType information automatically derived from some previous processing module?
I did not find any documentation of this (I guess based on the changelog) rather new module.
Thanks for any help on how to correct this.
Best regards, christoph

Thanks for already trying out the new module. Documentation will follow. The idea is that you use the Local csv data base search to annotate your compounds and then create a spectral library fully automatically.
We still do not support manual annotations or even spectral library matches. Could be something for the future.
Are you generating reference spectra or just spectra of your compound of interest?
So a few things we are still working on:

a file format that holds all information we have
batch submission format for the GNPS libraries

Cheers
Robin

Hello
Thank you for the quick reply. I wanted to generate a reference spectra library. So far I was using the local CSV database search. I will check the adduct annotations there - thanks for the hint!
Best regards, christoph

Hello
Thank you for the hint. With that (adducts in the compound annotation rather than the manual annotation) it worked.
Would it please be possible to export only a single spectra per compound with that new module? E.g., the most intense one or an average spectrum?
Thank you!
Best regards, christoph

We are still changing a lot and making room for more options.
Also you should check out the feature that you actually only annotate the compounds that are actually in the sample. So in the metadata file during local database search you select the column with the data file name or an identifier inside the file name.
For each precursor ion and energy we export a merged spectrum and the most abundant.
And one spectrum merged from all energies.

Hello
Oh, that is convenient. Thank you, I will give it a try


feat: add all mav2 contract addrs, abis

Pull Request Checklist

[x] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
[ ] Did you follow the contribution guidelines?

PR-Codex overview
This PR introduces several new modules and updates existing ones in the account-kit smart contracts. It primarily focuses on defining various modules' ABIs and a centralized addresses object for better contract management and interaction.
Detailed summary

Added addresses object in addresses.ts with various module addresses.
Defined paymasterGuardModuleAbi in paymasterGuardModule.ts.
Defined timeRangeModuleAbi in timeRangeModule.ts.
Defined webauthnValidationModuleAbi in webauthnValidation.ts.
Defined nativeTokenLimitModuleAbi in nativeTokenLimitModule.ts.
Defined allowlistModuleAbi in allowlistModule.ts.
Added maV2Abi in maV2.ts for the main contract.
Added smaStorageAbi in smaStorage.ts for storage management.

The following files were skipped due to too many changes: account-kit/smart-contracts/src/ma-v2/abis/smaStorage.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Dec 13, 11:13 AM EST: The merge label 'graphite-merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1207  👈 (View in Graphite)
#1203
main

How to use the Graphite Merge Queue
Add the label graphite-merge-queue to this PR to add it to the merge queue.
You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.


Added YAML parser node

Coverage remained the same at 87.94% when pulling 3a3dfb86674c23f20747d5e39d0ce7b493b9fdec on natcl:0.16 into 0ca3cdb9ae4f5ded3df1ce1b1f90f3ff3d1af7aa on node-red:0.16.

Note: put my name as copyright but I assume it should be the foundation instead ? Feel free to change !

Coverage increased (+0.06%) to 87.996% when pulling<PHONE_NUMBER>19bd72d9ed5a46ffcd0bcb7c7f1155 on natcl:0.16 into 0ca3cdb9ae4f5ded3df1ce1b1f90f3ff3d1af7aa on node-red:0.16.

Coverage remained the same at 87.94% when pulling e56319bce5f5afd8598f915b346f5767faddafea on natcl:0.16 into 0ca3cdb9ae4f5ded3df1ce1b1f90f3ff3d1af7aa on node-red:0.16.

Coverage remained the same at 87.938% when pulling f5ae7c6390e945dc3d8135d96971766c3eb0e284 on natcl:0.16 into d5f3ba8d8a6d20655043a43eec08bb9d201e52a7 on node-red:0.16.

All changes made !

Coverage remained the same at 87.938% when pulling 775fd26d638100a53038bc381429d8262b9eb4c6 on natcl:0.16 into d5f3ba8d8a6d20655043a43eec08bb9d201e52a7 on node-red:0.16.

Coverage remained the same at 87.938% when pulling 775fd26d638100a53038bc381429d8262b9eb4c6 on natcl:0.16 into d5f3ba8d8a6d20655043a43eec08bb9d201e52a7 on node-red:0.16.

Coverage decreased (-0.1%) to 87.827% when pulling 775fd26d638100a53038bc381429d8262b9eb4c6 on natcl:0.16 into d5f3ba8d8a6d20655043a43eec08bb9d201e52a7 on node-red:0.16.

Coverage decreased (-0.1%) to 87.827% when pulling 775fd26d638100a53038bc381429d8262b9eb4c6 on natcl:0.16 into d5f3ba8d8a6d20655043a43eec08bb9d201e52a7 on node-red:0.16.

Test added !

Coverage decreased (-0.1%) to 87.858% when pulling b113e2989172d4cf4251a69ae7b8eb600fb95aa5 on natcl:0.16 into 89a05c580ff446a3ecc656ed349f73eb4bdb851e on node-red:0.16.

Thanks @natcl

Coverage decreased (-0.1%) to 87.858% when pulling b113e2989172d4cf4251a69ae7b8eb600fb95aa5 on natcl:0.16 into 89a05c580ff446a3ecc656ed349f73eb4bdb851e on node-red:0.16.

Coverage decreased (-0.1%) to 87.858% when pulling b113e2989172d4cf4251a69ae7b8eb600fb95aa5 on natcl:0.16 into 89a05c580ff446a3ecc656ed349f73eb4bdb851e on node-red:0.16.


sh: webpack: command not found after use yarn add

Laravel Mix Version: 1.4.2
Node Version (node -v): 8.1.1
NPM Version (npm -v): 5.3.0
Yarn Version: 0.16.1
OS: macOS Sierra (10.12.6)

Description:
After using command yarn add when I try yarn run watch (for e.g) I got:

rafal$ yarn run watch
yarn run v0.16.1
$ NODE_ENV=development webpack --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js
sh: webpack: command not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Steps To Reproduce:
I can't try reproduce it at this moment but I can tell what I have done.

Install Laravel Mix for standalone app used Yarn followed by wiki guide
Install with yarn add:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Create git repository used Bitbucket
Clone project at other Mac (this one at the begining)
yarn install
yarn run watch
Stoped watch
Add<EMAIL_ADDRESS>with yarn add (for e.g - can be anything else)
yarn run watch and I got this error (even tried npm run watch)

To temporary fix (until next yarn add command) I have to use npm install command - then I can use watch again.
Yes I clear everything without result.

Yeah I think this is a weird yarn bug. I was reading a couple weeks ago about how, on a recent version, when you install a new dependency, Yarn actually uninstalls other dependencies. 👀
Anyways, there's nothing on the Mix end I can specifically do. Just have to reinstall all node dependencies until that issue is fixed.

@JeffreyWay that's odd. This is a known issue with npm v5 instead of yarn.

@ruchern Do you have more details/conversation about this npm issue?

@asimqt https://github.com/npm/npm/issues/17929 A problem I personally faced since npm became v5.


AppAuth support

https://github.com/openid/AppAuth-Android/blob/master/README.md
Hi,
Are there any plans to support this?
Thanks.

https://pub.dev/packages/flutter_appauth
Apologies.


Version info in ogg.h

Many other projects (zlib, png, SDL2, ...) embed version info in header file. I think ogg could also benefit from that. Yes, I'm aware of version info in pc files but that's not an option on Windows.

I don't think its a good idea to have it in the header file, mainly because the header and the actual lib can be out-of-sync with each other. Instead, I would suggest a function like:
const char * ogg_version_str (void);

Actually never liked this approach. In my opinion if you have not corresponding versions of library and header it's already something really wrong. That way you can't trust version in pc file also.

Somebody else's thoughts on this?

...if you have not corresponding versions of library and header it's already something really wrong. That way you can't trust version in pc file also.

I don't see why the header is any more or less trustworthy than the pc file?

Somebody else's thoughts on this?

I tend to agree with erikd, but I don't think either make sense for libogg. It's quite mature, and unlike codecs is unlikely to have per-release bugs an embedded version string would help track down in the output. What benefit were you hoping to get by adding version information to the header?
If you want make sure the library and header are in sync you need both. For example, libpng does this. In practice no one checks both and compares, so I think it's not worth adding the api surface.

I don't see why the header is any more or less trustworthy than the pc file?

A little missunderstanding here. I'm not saying that pc file is not trustworthy. I'm saying that pc file cannot be used on Windows and OS X. So it would be great to have version info both in header and pc files.

What benefit were you hoping to get by adding version information to the header?

I just like to see library versions while configuring projects like:
-- Found ZLIB: /usr/lib/libz.dylib (found version "1.2.5")

It looks like FindZLib just does a regexp on the .h to find the version.
Source packages of Theora have a configure script. This script has a PACKAGE_VERSION line. Couldn't you parse that?

@tdaede And now imagine someone configuring ogg-dependent project on Windows. In many cases they will use prebuilt binaries pacakges that contain lib and h files only. Or prebuilt framework on OS X. Or even install devel package from apt-get on Debian.  Header file seems the only common denominator across all platforms for me.

On Linux (and OS X when using homebrew), the .pc file will be installed and should always be the mechanism used.
We don't distribute official packages for Windows, and until recently most users of libogg were building it themselves in their own projects. So these prebuilt binary packages don't exist yet. Presumably we can also define what goes in them.
Putting it in a .h file would be okay, but it is slightly weird as it is intended for the build system, not programs using libogg. Does windows have a native version of .pc, maybe provided by OneGet/NuGet? We could also bundle a VERSION file in the binary packages or something.

OS X when using homebrew

While homebrew is awesome for using on developer machines you can't actually link against libraries from homebrew in apps you plan to distribute. You simply can't ask users to install homebrew and run brew install ogg for your app would work. And many OS X developers tend to use frameworks for their  dependencies.

until recently most users of libogg were building it themselves in their own projects

And many of them still do. And most of them build ogg once and than copy header and library to some kind of "prebuilt dependencies" folder.

Btw maybe we can simply add version to THIS FILE IS PART OF THE.. disclaimer. And a simple configuration step to keep it updated alongside with copyright year

I don't think we're convinced the benefits here outweigh the drawbacks. Closing as wontfix.

So, I asked on #cmake:
 is there a standard way to specify a library's version to cmake? like pkg-config, but on windows
 some projects specify a version in their headers, which is parsed by some cmake regexp, but that is hardly a standard pattern
 the equivalent to pkg-config in cmake would be package configuration files which may also come with package version files
 ngladitz, ah, I see, thanks! this will also work even if the project wasn't built with cmake, correct?
 yes e.g. Qt5 provides package configuration files but isn't build with cmake
Does this seem like a good solution? If so, you can reopen this issue or make a new one about implementing this.


Creating a new token crashes the daemon

I am using the rosetta container to build a local network to test the new CLI. I am building off the https://github.com/CodaProtocol/coda/pull/5710 branch (it's now been merged.)
To start the network I'm running:
coda/src/app/rosetta/start.sh CURL
The daemon crashes when I issue:
./coda.exe client create-token -sender $CODA_PUBLIC_KEY1
coda_crash_report_2020-08-20_22-45-51.056911.tar.gz

@MartinMinkov can you recheck this by running the tokens challenge when the new release branch is available?

@aneesharaines I checked the tokens challenge yesterday while writing new token docs and I can confirm that the tokens challenge is successful and works as expected!