error while compressing buildstream/buildstream image

I'm getting below error while compressing buildstream/buildstream image,. Can someone tell me if I'm missing something here.
$ docker-slim build --http-probe buildstream/buildstream
docker-slim[build]: info=http.probe message='using default probe'
docker-slim[build]: state=started
docker-slim[build]: info=params target=buildstream/buildstream continue.mode=enter
docker-slim[build]: state=image.inspection.start
time="2019-10-11T11:11:05+05:30" level=fatal msg="docker-slim: failure" error="remove /home/user/.asdf/installs/docker-slim/1.25.3/bin/.docker-slim-state/images/9678d0392a820ceed97f8d4e2914234b610ef539949d15d8e7226d8bb7a5ebe1/artifacts/files/etc/ld.so.cache: permission denied" stack="goroutine 1 [running]:
runtime/debug.Stack(0xc00051a1e0, 0x0, 0xc0003cc000)
	/usr/local/Cellar/go/1.11.1/libexec/src/runtime/debug/stack.go:24 +0xa7
github.com/docker-slim/docker-slim/pkg/util/errutil.FailOn(0x98b540, 0xc0005025a0)
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/pkg/util/errutil/errutil.go:14 +0x51
github.com/docker-slim/docker-slim/pkg/util/fsutil.PrepareImageStateDirs(0xc000442080, 0x30, 0xc0001ec007, 0x40, 0x0, 0x0, 0x0, 0x0, 0x20, 0x904fc4)
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/pkg/util/fsutil/fsutil.go:564 +0x6eb
github.com/docker-slim/docker-slim/internal/app/master/commands.OnBuild(0x86d701, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc00007db30, 0x0, 0x0, 0x7ffe907c1417, ...)
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/internal/app/master/commands/build.go:156 +0x8c2
github.com/docker-slim/docker-slim/internal/app/master.init.0.func6(0xc0000e0b40, 0x0, 0xc0000e0b40)
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/internal/app/master/cli.go:682 +0x1310
github.com/docker-slim/docker-slim/vendor/github.com/codegangsta/cli.HandleAction(0x85c9c0, 0x920a38, 0xc0000e0b40, 0xc000072700, 0x0)
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/vendor/github.com/codegangsta/cli/app.go:485 +0xc8
github.com/docker-slim/docker-slim/vendor/github.com/codegangsta/cli.Command.Run(0x900af0, 0x5, 0x0, 0x0, 0xc000069750, 0x1, 0x1, 0x919408, 0x3e, 0x0, ...)
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/vendor/github.com/codegangsta/cli/command.go:207 +0x991
github.com/docker-slim/docker-slim/vendor/github.com/codegangsta/cli.(*App).Run(0xc000096b60, 0xc00001c0c0, 0x4, 0x4, 0x0, 0x0)
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/vendor/github.com/codegangsta/cli/app.go:250 +0x6ea
github.com/docker-slim/docker-slim/internal/app/master.runCli()
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/internal/app/master/cli.go:1027 +0x55
github.com/docker-slim/docker-slim/internal/app/master.Run()
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/internal/app/master/app.go:6 +0x25
main.main()
	/Users/q/docker-slim/docker-slim/_gopath/src/github.com/docker-slim/docker-slim/cmd/docker-slim/main.go:8 +0x20
" version="linux|Transformer|1.25.3|b5aef546a575de242b2c3ace97e1fc11f028b137|2019-08-04_04:31:18PM"

This is an interesting use case... Thank you for opening the ticket @byteshiva ! I assume this is the Dockerfile for the image you are trying to minify: https://gitlab.com/BuildStream/buildstream-docker-images/blob/master/buildstream/latest.Dockerfile . I also assume you want the tools explicitly installed in that Dockerfile to stay there, so you can use them later. Can you share an example (or two :-)) of how you use the BuildStream image? Trying to understand how to support this use case...
The failure itself is a bit strange... It complains about a permission problem with the files docker-slim copied from the temporary container it created internally. The latest version of docker-slim shouldn't have the same permission problem because it archives the container artifacts before they are copied from the target container, so the docker-slim master app doesn't  need to worry about the permissions set on the files that were copied.

This is an interesting use case... Thank you for opening the ticket @byteshiva ! I assume this is the Dockerfile for the image you are trying to minify: https://gitlab.com/BuildStream/buildstream-docker-images/blob/master/buildstream/latest.Dockerfile . I also assume you want the tools explicitly installed in that Dockerfile to stay there, so you can use them later. Can you share an example (or two :-)) of how you use the BuildStream image? Trying to understand how to support this use case...
The failure itself is a bit strange... It complains about a permission problem with the files docker-slim copied from the temporary container it created internally. The latest version of docker-slim shouldn't have the same permission problem because it archives the container artifacts before they are copied from the target container, so the docker-slim master app doesn't need to worry about the permissions set on the files that were copied.

To start with, I'd like to create a disposable dev/sandbox environment along with buildstream to deliver different packages right from flatpak to go executables. Based on the meta data the dev Container profile changes. Why to choose docker-slim, for the obvious reason to lower the size of dockers.
There is another usecase where I would like to create a disposable go dev server to capitalize some of the language server protocol features. In this usecase I would have very low end machine for development all the heavy lifting code analysis and build and others would be done on the remote server. It could be related with cloud IDEs.
Let me test it with latest docker-slim and will update with it's state of error.


All JSON options explicitly listed

ICON External Parameter Request
Instructions

Give this issue a meaningful title.
Replace PASTE_YOUR_REQUEST_HERE with your request that you copied to clipboard:

{
  "extpar": {
      "igrid_type": 1,
      "iaot_type": 1,
      "ilu_type": 1,
      "ialb_type": 1,
      "isoil_type": 1,
      "itopo_type": 1,
      "lsgsl": false,
      "lfilter_oro": false,
      "lurban": false
  },
  "icontools": {
    "grid_level": 5,
    "grid_root": 3,
    "centre": 1,
    "subcentre": 2,
    "icopole_lon": 45,
    "icopole_lat": 30,
    "icorotation": 20,
    "lspring_dynamics": false,
    "maxit": 1000,
    "beta_spring": 0.95,
    "outfile": "DE",
    "domains": [
      {
        "region_type": 3,
        "center_lon": 63.5,
        "center_lat": 42.16,
        "hwidth_lon": 20.0,
        "hwidth_lat": 20.0,
        "lrotate": false,
        "pole_lat": 50.0,
        "pole_lon": 0.0
      },
      {
        "region_type": 3,
        "center_lon": 63.5,
        "center_lat": 42.16,
        "hwidth_lon": 10.0,
        "hwidth_lat": 10.0,
        "lrotate": false,
        "pole_lat": 50.0,
        "pole_lon": 0.0
      }
    ]
  }
}

Click on "Preview" to verify that the JSON format of your request is correctly formatted and displayed within a code block.
Click on "Submit new issue".

Extpar Data Request will now process your data based on the request you provided here. Once the processing is successful, it will post a link in this issue.
The processed data will be available under that link for up to 7 days.
If you encounter any problems, please add the label  to the issue. Make sure you post all relevant information from the logfiles in the issue directly.
Status Labels
Labels reflect the current state of your request:
 - Your request is currently under processing. Please wait for further updates.
 - Your request has been successfully processed. You can download your data using the provided link.
 - Unfortunately, your request could not be processed. Please refer to the log files in the zip file at the download link for more details.
 - Your request was aborted. This might be due to a timeout. Please try again or contact support if the problem persists.

Your data is ready for up to 7 days under this link.


Thanos IAM configuration

Is it possible to use thanos with an iam role instead of aws credentials? I see the example here only references access/secret keys: https://github.com/coreos/prometheus-operator/blob/master/Documentation/thanos.md#configuring-thanos-object-storage
type: s3
config:
  bucket: thanos
  endpoint: ams3.digitaloceanspaces.com
  access_key: XXX
  secret_key: XXX

Looks like we just need to annotate the Prometheus CRD with:
podMetadata:
  annotations:
    iam.amazonaws.com/role: YOUR_ROLE


Simplify and fix "removeComments()"

The separate treatment of comments at the documentElement's level is not necessary - they have a parent (as tested in Python 3.5.0 and 2.7.11 and 2.6.6)! It might not have worked before due to a typo - note the "if isinstance(element,...)" and "len(element.data)" which should both refer to "subelement" instead - or a bug in very old versions of Python).
Fix the iteration over childNodes (i.e. replace "for subelement in element.childNodes:" with ""for subelement in element.childNodes[:]:". We have to create a copy of the list to iterate over, otherwise we'd be iterating over a list as we change it which leads to unpredictable results.

Fixes #25

Thanks in particular for the detailed description of "why?". Both of these are quite subtle issues ..

@Ede123 I've pushed https://pypi.python.org/pypi/scour/0.32

:+1:


Add CPLD class for Mihawk platform

If PGOOD signal is abnormal when chassis poweron, read
Mihawk's CPLD-register via I2C to confirm the error.
First confirm whether the PSU is present, then confirm
whether the power_on_error signal is 1 (1 means abnormal).
If the signal is 1, read the error-code-register to
analysis reason.
Since the openbmc/master part is constantly being updated,
I will sent a "pull requset" on the ibm-openbmc/OP940 for
Mihawk.
https://gerrit.openbmc-project.xyz/c/openbmc/witherspoon-pfault-analysis/+/25028/19

Hello every reviewers,
In this PR, I added two files, mihawk-cpld.cpp & mihawk-cpld.hpp.
These two files referenced to ucd90160.cpp & ucd90160.hpp, and also inherited the original "Device class".
The part modified in main.cpp is a mechanism for adding runtime discriminating, that determines which device to be monitor (ucd or cpld).
If it is Witherspoon, use UCD; if it is Mihawk, use CPLD.
This part will not affect the original settings.
The modified part of Fault.errors.yaml, Fault.metadata.yaml and elog-errors.hpp are the new error event settings used by Mihawk.
This part will not affect the original Witherspoon.

see https://github.com/ibm-openbmc/witherspoon-pfault-analysis/pull/7


Wstyles2

@plhnk I don't understand why I have all these :(

Do you reset your local environment when starting new dev?
git pull upstream master && git reset --hard upstream/master

It looks like there's only 1 commit in this PR right now that's new content? (bde7ae1) probably easier to start a new branch, reset it to be even with what's upstream/master and then cherry-pick that commit from your current working branch. LMK if you want to do a screenshare?


[$32,000] Allow keyboard shortcuts to work on native devices

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Try to use <Command, K> to access the chat switcher on my tablet.
Expected Result:
The chat switcher should open
The goal is to let native listen and react to hardware keyboard shortcuts similar to how it works in web.
Actual Result:
Keyboard shortcuts doesn't work. It doesn't open.
Workaround:
Nope.
Platform:
Where is this issue occurring?

iOS
Android

View all open jobs on GitHub

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@jasperhuangg Don't forget to revert https://github.com/Expensify/App/pull/6881 which hides the shortcut button from the settings page.

Whoops! This issue is 2 days overdue. Let's get this updated quick!

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@jasperhuangg Is there any progress here? If you're fine and like to make it External, I can help with this.

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Thanks, @luacmartins. I'll send in a proposal in a few hours.

Hi @mananjadhav 👋  ☝  Are you still committed to working on this?

Thanks for the ping. I won't be able to soon.  If somebody doesn't pick in a week, then I'll check again.
I'll share my progress so far if it helps anyone. There are three parts to the implementation.

Enabling views/shortcut modal etc in all devices
At the moment, the keyboard shortcut map is created after the shortcut is registered, I feel we can create it purely from the CONST file.
Adding the shortcuts for Native devices with attachable external keyboards will not be done by the current shortcut implementation. It'll need UIKeycommand implementation. There are two packages that I found react-native-keycommands and  @envoy/react-native-key-commands. I haven't tested them.

Still looking for contributors

Still looking for contributors.

Doubled: https://www.upwork.com/jobs/~0190053c928a98fb14

doubled - https://www.upwork.com/jobs/~0190053c928a98fb14

doubled - https://www.upwork.com/jobs/~0190053c928a98fb14

@luacmartins It seems there are no new proposals. Can you review this comment for the approach? https://github.com/Expensify/App/issues/6883#issuecomment-1042130274 If this sounds acceptable as a proposal then I can work on this.
My only concern is I don't know how to test. I don't have an iPad to test, nor we allow contributors to build iOS app.

@mananjadhav Could you expand more on each step? Why are each of those necessary? What code changes are you proposing?

😱 doubled -- https://www.upwork.com/jobs/~0190053c928a98fb14

Can we clarify that a physical/hardware keyboard is needed - there's no "command" button on on-screen keyboards and on-screen keyboards appear only when an input field is focused
The goal here is to let native listen and react to hardware keyboard shortcuts similar to how it works in web, and not supporting shortcuts from the on-screen keyboard, correct?

Proposal
As I mentioned in this comment, there are three parts to the implementation (with the 3rd one being most tedious/uncertain).

Showing up KeyboardShortcuts modal in all platforms - It looks like this already exists and we don't need to change in the view logic of the KeyboardShortcuts
The shortcuts in the KeyboardShortcuts modal are shown from the map built in libs/KeyboardShortcut/index.js:getDocumentedShortcuts

This documentedShortcuts map is built only when the events are registered/subscribed to the shortcuts. I feel we can build a map purely from CONST file.
  function getDocumentedShortcuts() {
  	const shortcutsInConfig = _.values(CONST.KEYBOARD_SHORTCUTS);

  	const documentedShortCuts = lodash.map(shortcutsInConfig, shortcut => {
  		const platformAdjustedModifiers = getPlatformEquivalentForKeys(shortcut.modifiers);
  		const displayName = getDisplayName(shortcut.shortcutKey, platformAdjustedModifiers);

  		return {
            shortcutKey: shortcut.shortcutKey,
            descriptionKey: shortcut.descriptionKey ,
            displayName,
            modifiers,
        };
  	});

  }

This will also allow us to refactor subscribe function to only pass shortcutKey and maybe remove description and modifiers.

For KeyboardShortcuts/index.native.js we add an implementation which subscribes to the shortcuts.

We add the shortcuts using https://github.com/adamtew/react-native-key-commands package. I don't have anyway of testing this as of now, and hence I am refering to their documentation for the usage. In the actual implementation I'll fork the above package to add the shortcuts via actions instead of a component
We use the forked version of the KeyCommand component to replicate the subscribe and unsubscribe functions.
    const eventHandlers = {}

    function subscribe(key, callback, modifiers) {
    	const { KeyCommandEvent } = NativeModules;
    	const eventEmitter = new NativeEventEmitter(KeyCommandEvent);
    	const subscription = eventEmitter.addListener('KeyCommandEvent', callback);
    	NativeModules.KeyCommandsView.registerKeyCommand('KeyCommandEvent', key, getPlatformEquivalentForKeys(modifiers));
    	const platformAdjustedModifiers = getPlatformEquivalentForKeys(shortcut.modifiers);
  		const displayName = getDisplayName(shortcut.shortcutKey, platformAdjustedModifiers);
    	const callbackID = Str.guid();
    	eventHandlers[displayName] ={
    		callbackID: callbackID,
    		subscription,
    	};
    	return () => unsubscribe(displayName, callbackID);
    }

    function unsubscribe(displayName, callbackID) {
    	const callback =  _.find(eventHandlers[displayName], callback => callback.id === callbackID);
    	callback.subscription.remove();
 	   	eventHandlers[displayName] = _.reject(eventHandlers[displayName], callback => callback.id === callbackID);
	}

	function getPlatformEquivalentForKeys(modifiers) {
		return {
			'SHIFT': KeyCommandModifiers.ModifierShift,
			....
		}
	}

Proposal:

Implement a native module using Obj-C and Java that registers and listens to specified keyboard events, and dispatches payload from native to JS.
Add support for the native module into KeyboardShortcut/index.native.js

Native module
I wrote a sample RN library that allows us to capture hardware (+ simulator) keyboard events and propagates a payload to JS that you can see here: https://github.com/azimgd/keycommandlib.
The motivation behind this was that there are no active and maintained libraries (last commit 2-3 years ago) that work with the recent versions of RN and are multiplatform (Android + iOS). Tested 3 libraries Manan mentioned above, and none worked well.
It mounts on the root view and triggers onKey whenever keyboard is pressed. Couple caveats here:

onKey from the native module should have event bubbling support. Meaning that onKey works even when user is focused on TextInput.
iOS is implemented using event method swizzling. Get event and propagate further, similar approach is done with Android.

Module consists of 3 main methods:

registerKeyEvent: accepts: [input char, modifier flag keycode], registers keyevent. Duplicated execution is handled.
unregisterKeyEvent: unregisters.
getConstants: modifier flags (CMD, Ctrl, Alt, ArrowUp ...`) constants that vary per platform.
additionally integrate https://developer.apple.com/documentation/uikit/uiresponder/1621141-keycommands?language=objc

React.useEffect(() => {
   registerKeyCommand([
     {
       input: 'k',
       modifierFlags: constants.keyModifierCommand,
     },
   ]);

   const eventListener = eventEmitter.addListener('onKeyCommand', (event) => {
     // fire an action here
   });

   return eventListener.remove;
}, []);

JS Side
Add support for the library at: KeyboardShortcut/index.native.js. Shortcuts are already implemented in the web version it should work out of the box after when we add register + subscribe capability from the step above added into index.native file.

Fetch the list of shortcuts specified at CONST.js
Treat Ctrl as Cmd on ios
Register / unsubscribe callback

https://user-images.githubusercontent.com/4882133/167899950-452696f4-037f-4a48-acb7-1dfbed9097ba.mp4
https://user-images.githubusercontent.com/4882133/167902269-03cd2eca-6776-4a4d-bb9b-71ca656942ee.mp4
Tested on both real device and the simulator.
https://github.com/azimgd/keycommandlib/blob/master/ios/Keycommandlib.m
https://github.com/azimgd/keycommandlib/blob/master/android/src/main/java/com/keycommandlib/KeycommandlibModule.java (Android version needs a bit more work)

Thanks for the proposal everyone. @mananjadhav I see that https://github.com/adamtew/react-native-key-commands#android is not supported on Android.
@azimgd Great job on the package. Are you planning on maintaining it?

onKey from the native module should have event bubbling support. Meaning that onKey works even when user is focused on TextInput.
iOS is implemented using event method swizzling. Get event and propagate further, similar approach is done with Android.
What are your plans on the caveats? Any roadmaps. I think we can work with capturing instead of bubbling if that works.

Thanks @parasharrajat. I do plan to maintain it. We can also think on:

Integrate the changes directly into expensify/app
Transfer repo and get the package released under @expensify

Don't see any caveats, R&D and implementation for the first version showed that the things should be straightforward.
Current roadmap:

Implement iOS version using current keycommandlib version (which works pretty well on iOS).
Fix last bits on Android version

Cache registered keys
Better subscribe/unsubscribe logic

Integrate and Android
Test both iOS and Android on real hardware keyboard

POC I have been working on:
import {registerKeyCommand, eventEmitter, constants} from 'keycommandlib';
import _ from 'underscore';
import lodashGet from 'lodash/get';
import Str from 'expensify-common/lib/str';
import getOperatingSystem from '../getOperatingSystem';
import CONST from '../../CONST';

// Handlers for the various keyboard listeners we set up
const eventHandlers = {};

// Documentation information for keyboard shortcuts that are displayed in the keyboard shortcuts informational modal
const documentedShortcuts = {};

/**
 * Generates the normalized display name for keyboard shortcuts.
 *
 * @param {String} key
 * @param {String|Array<String>} modifiers
 * @returns {String}
 */
function getDisplayName(key, modifiers) {
    let displayName = [key.toUpperCase()];
    if (_.isString(modifiers)) {
        displayName.unshift(modifiers);
    } else if (_.isArray(modifiers)) {
        displayName = [..._.sortBy(modifiers), ...displayName];
    }

    displayName = _.map(displayName, modifier => lodashGet(CONST.KEYBOARD_SHORTCUT_KEY_DISPLAY_NAME, modifier.toUpperCase(), modifier));

    return displayName.join(' + ');
}

/**
 * Return platform specific modifiers for keys like Control (CMD on macOS)
 *
 * @param {Array<String>} keys
 * @returns {Array}
 */
function getPlatformEquivalentForKeys(keys) {
    const operatingSystem = getOperatingSystem();

    return _.map(keys, (key) => {
        if (!_.has(CONST.PLATFORM_SPECIFIC_KEYS, key)) {
            return key;
        }

        const platformModifiers = CONST.PLATFORM_SPECIFIC_KEYS[key];
        return lodashGet(platformModifiers, operatingSystem, platformModifiers.NATIVE || key);
    });
}

function getKeyEventModifiers(event) {
    const modifiers = [];

    if (event.modifierFlags === constants.keyModifierShift) {
        modifiers.push('SHIFT');
    }
    if (event.modifierFlags === constants.keyModifierCommand) {
        modifiers.push('CONTROL');
    }
    if (event.modifierFlags === constants.keyModifierAlternate) {
        modifiers.push('ALT');
    }
    // if (event.modifierFlags === constants.keyModifierCommand) {
    //     modifiers.push('META');
    // }
    return modifiers;
}

function bindHandlerToKeydownEvent(event) {
    const eventModifiers = getKeyEventModifiers(event);
    const displayName = getDisplayName(event.input, eventModifiers);

    // Loop over all the callbacks
    _.every(eventHandlers[displayName], (callback) => {
        if (_.isFunction(callback.callback)) {
            callback.callback(event);
        }
        return false;
    });
}

eventEmitter.addListener('onKeyCommand', bindHandlerToKeydownEvent);

/**
 * This is a no-op component for native devices because they wouldn't be able to support keyboard shortcuts like
 * a website.
 */
const KeyboardShortcut = {
    subscribe(key, callback, descriptionKey, modifiers = 'shift', captureOnInputs = false, shouldBubble = false, priority = 0, shouldPreventDefault = true) {
        const platformAdjustedModifiers = getPlatformEquivalentForKeys(modifiers);
        const displayName = getDisplayName(key, platformAdjustedModifiers);
        if (!_.has(eventHandlers, displayName)) {
            eventHandlers[displayName] = [];
        }

        const callbackID = Str.guid();
        eventHandlers[displayName].splice(priority, 0, {
            id: callbackID,
            callback,
            captureOnInputs,
            shouldPreventDefault,
            shouldBubble,
        });

        if (descriptionKey) {
            documentedShortcuts[displayName] = {
                shortcutKey: key,
                descriptionKey,
                displayName,
                modifiers,
            };
        }

        registerKeyCommand([
            {
                input: key,
                modifierFlags: constants.keyModifierCommand,
            },
        ]);

        return () => {};
    },
    getDocumentedShortcuts() { return []; },
};

export default KeyboardShortcut;

Ok. Thanks. Although @mananjadhav's proposal is quicker and easier, docs say that lib lacks support for iOS. On the other hand, I liked the idea of creating the package. @azimgd's proposal looks good to me.
cc: @luacmartins
:ribbon: :eyes: :ribbon:  C+ reviewed

The goal here is to let native listen and react to hardware keyboard shortcuts similar to how it works in web, and not supporting shortcuts from the on-screen keyboard, correct?

@kidroca correct! I added that to the issue description.
@mananjadhav as Rajat mentioned, that package has no support for Android, so we should keep looking.

@azimgd thanks for the detailed proposal and @parasharrajat for the review. I'll analyze this further and ask for a few more eyes on it as well.

I see that https://github.com/adamtew/react-native-key-commands#android is not supported on Android.

@parasharrajat
why not use the key-command lib for ios and react-native-key-event for android (it works for android only ).
https://github.com/Yufeikang/react-native-key-event
if you ok with this approach I can make POC.
there is also library support both but after the test. it's not working fine for multiple keypresses on ios.
https://github.com/kevinejohn/react-native-keyevent

@ahmdshrif we already have good proposals and I am confident to go either of those. Thanks for your interest.

@azimgd's proposal looks good! However, I think that we would move forward with the package being released as a Expensify/* library, but still remain open source.
Assigning @azimgd to this issue and working on getting the repo created under Expensify.

@luacmartins I need a write access to the repo above 👆

Maybe fork it and send PRs.

Yea, I think fork + PRs should work for now. Thanks for the suggestions @parasharrajat! Let me know if you have any issues!

Expecting to push a PR and update by Mon-Tue next week.

@azimgd any updates?

Nice! Thanks for the update. Let me know when things are ready to be reviewed!

I will review this.
A few other things:

Please break your implementation in multiple PRs. You can use any number of PR you want.
To reduce the time, create a plan or roadmap on features you are going to implement on the lib. I suggest using the project and issues to track milestones. This way we can also track progress.

First create a initial PR with a POC (this one could be large). Then use small PRs to improve it.
Initially, we can only focus on making the lib suitable for E/app. Later things can be generalized. I am sure that when this would be opened to open source community, it will get more traction and help to make it work for everyone.

Thanks for jumping in the review and the tips @parasharrajat! I really appreciate it!

Review started on the PR. It would be great to get this info.

@parasharrajat how's the review going?

I am still waiting on https://github.com/Expensify/App/issues/6883#issuecomment-1150357942 details. And some instructions to test the PR. Currently, PR is in a draft state.

Thank you @azimgd

Any updates here?

Heads up! I am going OOO so am reassigning

Hey @luacmartins and @parasharrajat. Everything is almost ready from my side. I started with Rajat's suggestion of creating atomic PR's to simplify CR process for you. Here is the first PR https://github.com/Expensify/react-native-key-command/pull/2 with the boilerplate only code. Please go ahead and start reviewing it. I will then move the code from the first PR as soon as it's merged.

I'll let @parasharrajat review it first!

@luacmartins I reviewed the PR, you can also take a look.

Yes, seems like we have some unaddressed comments.

First PR in review!

Hey team! Any updates?

Hey, blocked / waiting for https://expensify.slack.com/archives/C01GTK53T8Q/p1659024346154599 to be answered

@azimgd answered in the PR!

First PR merged!

We have another PR up

PR above is still in review

Just adding a note that I'm OOO until September 21st. As this is on hold I won't reassign it, but if you need a contributor manager to do anything before that point please reapply the external label.

Waiting for deployment, not overdue!

Nice! I marked the PR as ready for review!

3rd PR is in review!

https://github.com/Expensify/react-native-key-command/pull/4 in review

What is next @azimgd ?

Working on a new PR against E/App. @luacmartins could you work towards deploying https://github.com/expensify/react-native-key-command on NPM please ?

Let's test this out first with NewDot and then we can prepare to release. May be both can be done parallel.

@azimgd can we add a wrapper for web so that we have a unified API and don't need to split our files into index.js and index.native.js?

Can we add a wrapper for web so that we have a unified API and don't need to split our files into index.js and index.native.js?

JS Implementation of the same functionality you mean ?

Yea, we should be able to import the module once and it should export the native functionality if it's a native platform or the web functionality if it's web/desktop.
You can see how we did that for Onyx by following the entry points for the lib - https://github.com/Expensify/react-native-onyx/blob/4f2cd795499d3a94ffea78812a461c7baad38f55/package.json#L31-L33

Good question. @luacmartins  Do we need to implement the web platform as well for this lib? I understand that you are asking to creating noop web exports to keep it consistent for RN projects.
@azimgd As we are progressing towards Fabric, we might have to add turbo modules implementation as well.

I understand that you are asking to creating noop web exports to keep it consistent for RN projects.

This

What if we port current KeyboardShortcuts implementation within this project, so that it becomes truly cross platform?

That would work too!

Working on a new scope for this issue per discussion with @luacmartins. New milestone is to create a web version for keycommand package.
Ready to be reviewed:
https://github.com/Expensify/react-native-key-command/pull/8
Work in progress:
https://github.com/Expensify/react-native-key-command/pull/9

https://github.com/Expensify/react-native-key-command/pull/8 is merged.

@azimgd Any update?

https://github.com/Expensify/react-native-key-command/pull/10

@azimgd is the last PR ready to be reviewed?

Yeap

Asked for an update here

@azimgd are we ready to start implementing the new lib into App?

Correct, on it now.

@luacmartins not able to sign-in for the last couple days, added my IP address into gdoc earlier yesterday.

@azimgd thanks for the update! Hopefully we'll get this issue sorted soon!

@azimgd have you been able to signin?

It got fixed just couple hours ago (had issues with for couple weeks).

It got fixed just couple hours ago (had issues with for couple weeks).

@azimgd glad it got fixed. Let's push this through the finish line!

Haha, spent a week trying to understand why “cmd + k” (and couple other specific combinations) don’t, while “cmd + f” etc work on simulator with expensify app. Until I re-tested on a hardware device where everything works just fine. 🤷♂ Those are actually reserved keywords which don’t bubble up.
@luacmartins @parasharrajat I will push my code by the end of this week, so when you test iOS beware of this fact and please test on an iPhone.

Thanks for the update @azimgd

@azimgd did you manage to work on this some more?

Integrated both, will create a PR tomorrow.
Should I match the designs to web version? Because right now, shortcuts modal is completely broken on mobile.

Yes, please match them to the web version.

@luacmartins could you deploy https://github.com/Expensify/react-native-key-command to npm ?

@luacmartins what's the easiest way for me to test PR above on a real device (iOS) ?

@azimgd can you change the package name to @expensify/react-native-key-command we are trying to standardize on using the @expensify scope for our new packages.

We can build the PR for testing

for sure, let me know once @expensify/react-native-key-command is published.

@azimgd we decided to keep the package name outside the Expensify scope since our other original libs like react-native-onyx are also published outside the scope.
That being said, I tried to publish the package today, but I wasn't able to because the package was already published about a month ago. Could I ask you to please un-publish the package so we can move forward with publishing it from the Expensify org?

Needs to be reviewed and merged: https://github.com/Expensify/react-native-key-command/pull/12

I'm not able to find a way to have "Enter (Return)" key for ios.
https://developer.apple.com/documentation/uikit/uikeycommand/input_strings_for_special_keys?language=objc
https://developer.apple.com/documentation/uikit/uikeymodifierflags?language=objc
Here is the list of all key-commands we support (iOS):
https://github.com/Expensify/react-native-key-command/blob/main/ios/KeyCommand.mm#L8-L27
@luacmartins what do you suggest ?
@sketchydroide maybe you have an idea ?

I'll check this tomorrow!

@azimgd no sorry, never dealt with anything like this before, key shortcuts are not normally a thing in Native development, and I think it's more now that iPad has become something more like a computer that it starts to make more sense.

@azimgd I'm not too sure, but maybe this page could help?
It mentions some keys having dedicated constants, but others such as return/enter use @"\\r"

That's for textfield I believe.

What do you mean by textfield?

That’s not applicable for swizzled keyboard event.
However, I just realized that real device might output a result instead of nil.

Enter key is fixed

https://github.com/Expensify/react-native-key-command/pull/12 is merged!

Thanks @luacmartins. Do you mind taking a look at https://github.com/Expensify/react-native-key-command/pull/13 as well ?

Can you please publish next version when you have a chance. We are getting very close.

published v0.5.0!

Hey @parasharrajat @luacmartins. Do you think we can speed up the review and get this issue completed this week ? I'm happy to synchronize with Rajat and help if needed.

@azimgd how can I help?

@luacmartins, I guess Rajat will be able to test on android and web only. What was your suggestion to test it on iOS ?

@parasharrajat we need both testing and code-review here.

https://github.com/Expensify/App/pull/14168

https://github.com/Expensify/App/pull/14168 is in review!

This issue has not been updated in over 15 days. @azimgd, @luacmartins, @parasharrajat, @kadiealexander eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

App PR in review!

We have merged and reverted the original PR due to deploy blocker, more context here: https://github.com/Expensify/App/pull/14767#issuecomment-1513431667
I'm in the process of rewriting obj-c side which should be ready this week.

📣 @azimgd! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@luacmartins @parasharrajat rewrite is happening here: https://github.com/Expensify/react-native-key-command/pull/22

Thanks for jumping on this so quickly @azimgd!

PR is ready for review.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.1-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/14767

If no regressions arise, payment will be issued on 2023-04-26. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.5-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17708

If no regressions arise, payment will be issued on 2023-05-03. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BZ checklist is not applicable in this case, since this is a new feature.

@kadiealexander are we good to go?

Yes I believe so! I've sent contracts to @azimgd and @parasharrajat at the new agreed price of $40,000 (discussed here).

Everyone is paid. @luacmartins I think this issue is too old to have a bugzero regression checklist, do you think it needs a regression test or should I close the issue?


Add details about epoch lengths

Description

Extend Epoch Length section with more details about what influences epoch length and its variance
Add a link to Epoch Length in the schedule
Update hashes of boot-utils tools to match new build including check-machine-account self-serve utility

⚠ This new tool version needs to be shipped concurrently with merging this PR

boot-utils update is shipped


Add a GOVERNANCE file

It describes what is the role of maintainers and how one can become maintainer.

PTAL @radu-matei and @carolynvs  🙏

This is the same governance document as the spec repo.
There is also a governance document in the community repo.
If we want to make changes, I would like for the various governance documents for projects to be consistent (and ideally in the same place?)

community is a good place to put template documents

Rebased onto master

I agree with @radu-matei that if we change something to the governance then it should be at the organization level. And I agree too with @carolynvs that we should change the process because we don't respect it strictly in practice. We should add this point to the agenda of the next community meeting 👍

Bullet point added on the agenda.


[fix] undefined method open_uri' for class #Class:OpenURI' (NameError)

Coverage decreased (-9.4%) to 75.223% when pulling 18d55a0c88445f3633b1bb416f809c176561b02f on itowtips:fix-openuri into d9225e6b94ad2869d2c377d1fddce89c2b3d8f8d on shirasagi:master.


How to resolve console application exited with code 9009

Im try to run a c# console application in build process by using below command
<Target Name="AfterBuild" AfterTargets="AfterBuild">
     <Exec Command="$(ProjectDir)$(OutputPath)$(AssemblyName).$(OutputType)" />
   </Target>

Error when Build : error exited with code 9009
Note : This error occurs due to my project have space in  parent folders
this same scenario working fine when parent folder name does not have space
How to resolve this issue?

This is nothing at all to do with Windows Terminal, note.
The command line syntax of, and quoting rules that you should be using in, an Exec task in MSBuild are the same as you would use passing a command line to the cmd command interpreter, because that is of course what it runs.

Yea, this doesn't have anything to do with the Terminal, so I'm gonna close this thread. The link @jdebp provided should be able to help you.


Unable to access jarfile forge-1.6.4-<IP_ADDRESS>5-universal.jar

I'm trying to run a 1.6.4 server and I'm using forge <IP_ADDRESS>5 instead of <IP_ADDRESS>5 because I saw a post on how old installers don't work anymore but <IP_ADDRESS>5 did. Whenever I start the server it gets past the connectivity check and repeats the message below until it stops due to crashes.
Starting server
Error: Unable to access jarfile forge-1.6.4-<IP_ADDRESS>5-universal.jar
Server will restart in ~10 seconds. No input needed...
Skipping internet connectivity check
Rebooting now!

Can you provide more details about how you created your container?

Hello there,
I'm having the same issue, trying to install 1.17.1 with Forge Version 37.0.0. Here's the log: https://pastebin.com/J5dfy7ae
After that it will spit out a few lines then say: "Unable to access jarfile forge.jar. Looking at the folder where everything is it seems to have created libraries and mods folder, but the forge.jar (not even the vanilla minecraft jar) files are nowhere to be seen at the root.
I've tried deleting the .forge-installed file as mentioned in one of the earlier issues of the same nature, and restarting the container, to no avail. I've also tried various things like not specifying the minecraft and forge version, going for <IP_ADDRESS>, among other things but no luck.

@carltibule can you provide more details about how you created your container?

For sure! I usually deploy mine using Docker Compose, on Portainer. Here's what my compose file looks like: https://pastebin.com/smZ92kiZ
It seems to work fine if it's just a vanilla installation though, only fails when it's forge.

I am using docker compose

I believe I have a similar issue, but can open a new one if that's better.
Goal: mc version 1.17 with Forge.
Container creation:
$ docker run -d -v <my favorite_path>/MC_1_17_1:/data -it -e EULA=TRUE -e OPS=<user1>,<user2>,<user3> -e WHITELIST=<user1>,<user2>,<user3> -e ALLOW_NETHER=true -e VERSION=1.17.1 -e TYPE=FORGE -e MEMORY=4G -p 25560:25565 --name MC_1_17_1 itzg/minecraft-server:java8
Forge installer log finishes:
 The server installed successfully You can delete this installer file now if you wish
Forge .jars seem to exist:
$ find . -iname 'forge-*.jar'
./libraries/net/minecraftforge/forge/1.17.1-37.0.1/forge-1.17.1-37.0.1-universal.jar
./libraries/net/minecraftforge/forge/1.17.1-37.0.1/forge-1.17.1-37.0.1-server.jar
Yet, the server log says: Error: Unable to access jarfile forge.jar
$ docker logs -f MC_1_17_1 | tail
[init] Setting level-name to 'world' in /data/server.properties
[init] Setting online-mode to 'true' in /data/server.properties
[init] Updating ops
[init] Updating whitelist
[init] Checking for JSON files.
[init] Setting initial memory to 4G and max to 4G
[init] Starting the Minecraft server...
Error: Unable to access jarfile *forge*.jar
2021-07-23T22:27:22.393Z	WARN	mc-server-runner	sub-process failed	{"exitCode": 1}
2021-07-23T22:27:22.393Z	INFO	mc-server-runner	Done

Oh, they made a major change to their installer and are using Java jigsaw modules. Now it drops a run.sh that contains
java @user_jvm_args.txt @libraries/net/minecraftforge/forge/1.17.1-37.0.2/unix_args.txt

and libraries/net/minecraftforge/forge/1.17.1-37.0.2/unix_args.txt contains a bunch of critical arguments.
This is going to take a fair bit of redesign in my startup script :(

...I spoke way too soon. The latest image now supports their run.sh mechanism.
Now, @clock-boy the 1.17 behavior is probably totally different from your original issue. Specifically I was needing to know what environment variables you set, but maybe it's basically TYPE=FORGE and VERSION=1.6.4?

@clock-boy this started up fine for me:
docker run -it -p 25565:25565 -e EULA=TRUE -e TYPE=FORGE -e VERSION=1.6.4 itzg/minecraft-server:java8

and it looks like it actually grabbed <IP_ADDRESS>5 as the forge version.

Just tested again, still having the same issue as before. The change has not been released yet I suppose?

Just tested again, still having the same issue as before. The change has not been released yet I suppose?

The 1.17.1 fix is fully released -- make sure you have pulled the latest image. docker-compose pull in your case.

The 1.17.1 fix is fully released -- make sure you have pulled the latest image. docker-compose pull in your case.

Forgot to provide an update but it's working for me now. Thank you!


create silent middleware named "acceptSilent"

Hi @zhanghao-zhoushan,
Please create a middleware named "acceptSilent" and add unit test for it.
The behavior of the middleware:

When ctx.options.silent is truthy, alter ctx.reporter with silentReporter. When ctx.options.silent is falthy, do nothing.
Pass through the next callbacks. Do not block or terminate middleware passthrough process.

The test cases of the middleware:

when ctx.options.silent is truthy, alter it with the silent one.
when ctx.options.silent is truthy, pass through middleware process.
when ctx.options.silent is falsy, do nothing.
when ctx.options.silent is falsy, pass through middleware process.

Well done! 👍👍


Register a service with Discoverd

I have added memcached as an additional process in my Procfile using the apt buildpack and the multi-buildpack. From what I can tell it is up and running on the default port. However, I have no idea how you would tell another app how to connect to this service. Is there a way to register it with Discoverd and access it by that DNS name?

This issue seem similar to the closed issue #4248, the answer there is not really what either of us is asking though. I don't really want to create a routable app, just a resolvable one.

@bbaptist you can do this by assigning a port to the process type using flynn release update release.json where release.json contains something like the following:
{
  "processes": {
    "memcached": {
      "ports": [
        {
          "port": 11211,
          "proto": "tcp",
          "service": {
            "name": "memcached",
            "create": true
          }
        }
      ]
    }
  }
}

It will then be discoverable at memcached.discoverd.
This is admittedly not a great API, to be addressed by introducing a Flynnfile (#1084).

OK, great start. However, some questions.
To make sure the name is something unique per app I would be able to change the service name to appname-memcached and have it discoverable at appname-memcached.discoverd correct?
If I have already added your example release does it remove the previously created memcached.discoverd entry upon running another release update?

To make sure the name is something unique per app I would be able to change the service name to appname-memcached and have it discoverable at appname-memcached.discoverd correct?

Correct.

If I have already added your example release does it remove the previously created memcached.discoverd entry upon running another release update?

It is not removed but it will not interfere with other services.


POLIO-1409: Make campaing round date required again

Round date needs to be required
Related JIRA tickets POLIO-1409
Self proofreading checklist

[ ] Did I use eslint and black formatters
[ ] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] New translations have been added or updated if new strings have been introduced in the frontend
[ ] My migrations file are included
[ ] Are there enough tests
[ ] Documentation has been included (for new feature)

Changes
just put back fields to required
How to test
try to crreate a round without start or end date
Print screen / video

reverts POLIO-697


[2213] Difference in compiled JS in between deck and VS - Possible symbol resolving failed

Fixes #2213

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Is there an equivalent to /etc/init/docker.conf?

Hello,
I'm trying to enable the remote api for docker as described here: http://blog.trifork.com/2013/12/24/docker-from-a-distance-the-remote-api/
which according to them, in order to get this to work, we would need to add:
description     "Docker daemon"

start on filesystem and started lxc-net
stop on runlevel [!2345]

respawn

script
    /usr/bin/docker -H tcp://<IP_ADDRESS>:4243 -d
end script

I've tried this without a bosh release and it works like a charm, however, I've tried to use the same thing on (creating the docker.conf file and putting it in /etc/init/docker.conf) but that didn't work (didn't think it would anyway).
My question is, how to get this to work with this bosh release? Is there a configuration file similar to this some where that I haven't noticed or something?
Thanks in advance
EDIT: The reason why I need this, is because I have a jenkins master (located in a different vm) that uses containers as slaves.

What is your use case/how do you use this release? In the standard use case (brokered docker or swarm setup), you would configure the properties defined in the spec file in your deployment manifest.

Ah I see, my use case for this release is I'm spinning up a Jenkins master vm and a Jenkins slave vm, and I'm installing https://wiki.jenkins-ci.org/display/JENKINS/Docker+Plugin on the master which provisions slaves (docker containers on the slave vm). Because they're in two different vms I need to turn on the remote api.
So I now notice there's docker.tcp_address: and docker.tcp_port: which I believe takes care of
script
    /usr/bin/docker -H tcp://<IP_ADDRESS>:4243 -d
end script

but what is equivalent to:
start on filesystem and started lxc-net
stop on runlevel [!2345]

Thanks in advance

And how is this related to this bosh (as in https://bosh.io/docs/) release?

I'm using this bosh release to deploy jenkins (did some small modifications to achieve that), and the only thing left to complete this is to enable the remote api for the docker daemon...

You use this bosh release to deploy Jenkins that shall talk from inside the container to the Docker engine outside?

One job deploys jenkins master (which runs inside a container), I also have another job in the release which runs docker daemon and pulls jenkins slave images and that's it (this is the small modification that's been done).. Now I just want the daemon on the jenkins-slave job to accept remote API calls from the jenkins-master vm.

This is similar to the Swarm setup in which the Swam container scheduler on the broker VM talks remotely to the Docker engines. See e.g. https://github.com/cloudfoundry-community/docker-boshrelease/blob/master/examples/docker-swarm-broker-openstack.yml#L114. This enables TCP (listening on all interfaces) in https://github.com/cloudfoundry-community/docker-boshrelease/blob/master/jobs/docker/spec#L17-L19 with expression in https://github.com/cloudfoundry-community/docker-boshrelease/blob/master/jobs/docker/templates/bin/job_properties.sh.erb#L22-L25 and usage in https://github.com/cloudfoundry-community/docker-boshrelease/blob/master/jobs/docker/templates/bin/docker_ctl#L73.

I am closing the ticket now as there was no feedback after my last comment.


How to add orml_tokens benchmarks to the runtime?

Hey, I face the following error message, when trying to add the orml_tokens pallet to the benchmarks:

no function or associated item named run_benchmark found for struct orml_tokens::Pallet in the current scope

I activated the benchmark feature in the runtime Cargo.toml
runtime-benchmarks = [
...
  "orml-tokens/runtime-benchmarks",
...
]

I added orml_tokens here:
#[cfg(feature = "runtime-benchmarks")]
mod benches {
	define_benchmarks!(
                ...
		[orml_tokens, Tokens]
	);
}

What am I missing? In addition to that I think orml_nft and orml_currencies have no benchmark feature activated, so using the type WeightInfo = (); for orml_currencies is accurate in the runtime?

I am using polkadot-v0.9.29 currently.

Oh I see, that you use default weights, nice! https://github.com/open-web3-stack/open-runtime-module-library/blob/80ed32dad524955b63e2c3fea7c14defcd24d79c/tokens/src/weights.rs#L40

Do those default weights have any flaws, which should be taken into consideration to benchmark them manually?

Could you provide the benchmarks for each pallet, so that the users can just benchmark it quicker without writing the benchmarks manually but with weights based on their own reference machine?
Because currently the default weights force the users to use the recommended reference machine, right?

You would want to run your own benchmark for each orml pallets used, as different runtime configs could have very different results. For instance, the hooks functions impl in Config has impact on some specific dispatch-able calls. Refer to config in Acala runtime as an example of how to config benchmarks for orml pallets https://github.com/AcalaNetwork/Acala/blob/master/runtime/acala/src/lib.rs

It is hard (if not impossible) to write generic benchmarking code. The frame-benchmarking framework is not generic to handle that. We use our fork orml-benchmkaring to be able to write runtime specific benchmarks and therefore able to actually correctly do it without tons of overhead on trying to make it generic.
So yeah it is not ideal but you can just use Acala benchmarking code as reference and make it your own one https://github.com/AcalaNetwork/Acala/blob/master/runtime/mandala/src/benchmarking/tokens.rs
Feel free to make suggestion if you can think of a better way.

Thanks for your new input! Loved it.

I get the following error when adding the orml_tokens benchmarks:
  error[E0573]: expected type, found module `crate::benchmarking::orml_tokens::benches`
     --> /Users/userproject/container-chains/templates/simple/runtime/src/lib.rs:654:23
      |
  654 |         [orml_tokens, crate::benchmarking::orml_tokens::benches]
      |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not a type
  ...
  762 |             list_benchmarks!(list, extra);
      |             ----------------------------- in this macro invocation
      |
      = note: this error originates in the macro `list_benchmarks` (in Nightly builds, run with -Z macro-backtrace for more info)

      ....
        error[E0573]: expected type, found module `crate::benchmarking::orml_tokens::benches`
     --> /Users/userproject/container-chains/templates/simple/runtime/src/lib.rs:654:23
      |
  654 |         [orml_tokens, crate::benchmarking::orml_tokens::benches]
      |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not a type
  ...
  816 |             add_benchmarks!(params, batches);
      |             -------------------------------- in this macro invocation
      |
      = note: this error originates in the macro `add_benchmarks` (in Nightly builds, run with -Z macro-backtrace for more info)

My folder structure is /benchmarking/orml_tokens/benches as outlined. It looks like frame_benchmarking::define_benchmarks requires a type rather than a module like in my case. But this is basically the same approach as on the Acala main branch here.
How can you in Acala use benchmarking::tokens inside define_benchmarks here, which is a module defined here (not a type).

are you using the define_benchmarks from orml? can you share the code?

Oh, I used the define_benchmarks from frame-benchmarking. You got me, thanks for helping out!
Another option would be to use the define_benchmarks! macro for all pallets other than the orml pallets and then use orml_benchmarking::{list_benchmark as orml_list_benchmark} and orml_benchmarking::{add_benchmark as orml_add_benchmark} for each orml pallet separately. I did this in combination of using add_benchmarks! and list_benchmarks! for all other pallets.


Ensure proper error handling in all cubits

Ensure that error handling blocks return in all places to avoid entering unpredictable states in cubit and storage.

Closing in favor of #174


Add check for Ubuntu

When installing on Ubuntu without swiftenv, the bootstrap script looks for the string swift-DEVELOPMENT-SNAPSHOT-2016-06-20-a (SWIFT_VERSION) in the path. An earlier step in the documentation has the user rename the folder to swift, causing this check to fail and the script to exit.
https://github.com/qutheory/vapor-toolbox/blob/master/bootstrap.sh#L24
Quick fix was to skip the rename step, but there is probably a better way so the documentation can remain consistent across platforms.

I think this will be solved when the toolbox switches to Swift 3.0 preview 2.


introduce memory usage benchmarks for Rust-based frameworks

In private conversations with @tumberger we discussed 2 ways of measuring memory usage:

in-language memory benchmarks: this would require most likely require usage of jemalloc, which means we need to depend on libc directly.

external tools: we could also use /usr/bin/time or something like valgrind.

If we decide on 2), the logic between the test runner<>benchmarks would have to be separated, since in the current runner we are doing other tasks like writing to CSV, etc. which means we may not get the most accurate results.

We will probably need to go with the second option so that we can use the same tooling across all frameworks. Hence, we will need separate runners per phase.

In #32, we use time to perform the measurement.


@gluestack-ui/themed: Invalid peer dependency warning for React 18

Description
The @react-aria/checkbox dependency in the current version of @gluestack-ui/themed does not report itself as being compatible with React 18.
CodeSandbox/Snack link
No response
Steps to reproduce

Follow the installation instructions for creating an Expo-based project with the themed version of Gluestack.

Using pnpm, a warning is issued when the dependencies are installed:
 WARN  Issues with peer dependencies found
app
└─┬ @gluestack-ui/themed 1.0.37
  └─┬ @gluestack-ui/checkbox 0.1.22
    └─┬ @react-native-aria/checkbox 0.2.8
      └─┬ @react-aria/checkbox 3.2.1
        └── ✕ unmet peer<EMAIL_ADDRESS>|| ^17.0.0-rc.1": found 18.2.0

gluestack-ui Version
@gluestack-ui/themed 1.0.37
Platform

[X] Expo
[ ] React Native CLI
[ ] Next
[ ] Web
[ ] Android
[ ] iOS

Other Platform
No response
Additional Information
@react-aria/checkbox introduced support for React 18 in v3.4.0, which was released 2 years ago. Bumping the dependency in the @react-native-aria/checkbox package to at least this version will solve the peer dependency issue.

@ts-candide Thanks for reporting this. We'll have a look.

I'm running into this issue as well. Getting warnings during my pre-build and build stages. I'll tag this issue to track for an update!

@surajahmed, any update on the progress for a fix for this.

@millerm30 Please update to the latest version of @gluestack-style/themed, @gluestack-style/react and @gluestack-ui/config.
Thanks for your patience.

@surajahmed
Thank you for the update! I will update to the latest today for testing.

@surajahmed
Just updated to the latest. I am running the following:
"@gluestack-style/react": "^1.0.52",
"@gluestack-ui/config": "^1.1.18",
"@gluestack-ui/themed": "^1.1.17",
But I am still running into the same issue.
m WARN ERESOLVE overriding peer dependency
npm WARN While resolving<EMAIL_ADDRESS>npm WARN Found<EMAIL_ADDRESS>npm WARN node_modules/react
npm WARN<EMAIL_ADDRESS>from the root project
npm WARN   129 more (@gluestack-ui/accordion, @gluestack-ui/actionsheet, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer<EMAIL_ADDRESS>|| ^17.0.0-rc.1" from<EMAIL_ADDRESS>npm WARN node_modules/@react-native-aria/checkbox/node_modules/@react-aria/checkbox
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/@react-native-aria/checkbox
npm WARN
npm WARN Conflicting peer dependency<EMAIL_ADDRESS>npm WARN node_modules/react
npm WARN   peer<EMAIL_ADDRESS>|| ^17.0.0-rc.1" from<EMAIL_ADDRESS>npm WARN   node_modules/@react-native-aria/checkbox/node_modules/@react-aria/checkbox
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN     node_modules/@react-native-aria/checkbox

@ts-candide We'll have a look, there is a conflicting peer dependency with @react-aria/checkbox. For now, you can try with --legacy-peer-deps flag while installing packages.
eg, npm i --legacy-peer-deps

It seems that the react-native-aria is relying on an outdated dependency in "@react-aria/checkbox": "3.2.1" which is now I believe running 3.14.1 which includes support for React 18
"dependencies": {
"@react-aria/checkbox": "3.2.1",
"@react-aria/utils": "^3.6.0",
"@react-native-aria/toggle": "^0.2.8",
"@react-native-aria/utils": "0.2.11",
"@react-stately/toggle": "^3.2.1"
},

Hi team, I'm facing the same issue on install:
Found<EMAIL_ADDRESS>node_modules/react
<EMAIL_ADDRESS>from the root project
peer react@">=16" from<EMAIL_ADDRESS>node_modules/@gluestack-ui/themed
@gluestack-ui/themed@"*" from the root project
Could not resolve dependency:
peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>node_modules/react-dom
peer react-dom@">=16" from<EMAIL_ADDRESS>node_modules/@gluestack-ui/themed
@gluestack-ui/themed@"*" from the root project
Any update on the progress for a fix for this?

We're working on it. For now, please use --legacy-peer-deps flag.

Hi team, I'm facing the same issue on install: Found<EMAIL_ADDRESS>node_modules/react<EMAIL_ADDRESS>from the root project peer react@">=16" from<EMAIL_ADDRESS>node_modules/@gluestack-ui/themed @gluestack-ui/themed@"*" from the root project
Could not resolve dependency: peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>node_modules/react-dom peer react-dom@">=16" from<EMAIL_ADDRESS>node_modules/@gluestack-ui/themed @gluestack-ui/themed@"*" from the root project
Any update on the progress for a fix for this?

Having this exact same issue, which looks like the opposite of the original in this thread.
It seems like we bumped all the way to<EMAIL_ADDRESS>which is not yet supported by the latest react native sdk, I think we need to bump to no more than 18.2.0 which is the current supported version in react native. Thoughts? @surajahmed

Using --legacy-peer-deps doesn't seem to fix the issue unfortunately. Installing in an expo SDK v50+ application causes the app to freeze/hang at post-bundling with no errors or warnings. Connecting a debugger fails, and eventually the app kills itself.

Hi,
Is there a reason that the fix isn't simply to unlock the version in here:
https://github.com/gluestack/gluestack-ui/blame/aeb48302cad4a7e155f548b59ff90d6cbbde3f33/packages/react-native-aria/checkbox/package.json#L54
Why is it 3.2.1 and not, say, ^3.2?

Using --legacy-peer-deps doesn't seem to fix the issue unfortunately. Installing in an expo SDK v50+ application causes the app to freeze/hang at post-bundling with no errors or warnings. Connecting a debugger fails, and eventually the app kills itself.

Can you provide repo or reproduction of this? This seems to be working for us.

Hi,
Is there a reason that the fix isn't simply to unlock the version in here:
https://github.com/gluestack/gluestack-ui/blame/aeb48302cad4a7e155f548b59ff90d6cbbde3f33/packages/react-native-aria/checkbox/package.json#L54
Why is it 3.2.1 and not, say, ^3.2?

@nishant7156, I tried with latest version of @react-aria/checkbox but seems to be breaking in some cases. That's why we have froze the version to 3.2.1 instead of ^3.2. We will be running sprint some to update all the react-aria deps to latest versions.

So will this ever be fixed? I see issues being closed as duplicated of this one but this one doesn't go forward. This should be a priority! I've been unable to update my clients projects for over two months now! And before someone tries that again, using legacy flag is not a solution.

Is there an update about this issue?

@ts-candide could you mark the issue as not answered or something? This looks like it's getting no attention at all :/


⚠ PrivateHD has degraded performance

In 34d3486, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2086 ms

Resolved: PrivateHD performance has improved in c9783d4.


Add link to CodeHeader

Add link to CodeHeader
Signed-off-by: Christoph Kleine<EMAIL_ADDRESS>

[ ] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit
[ ] Ensure that the commit message is a good commit message
[ ] Ensure to use auto format in all files
[ ] Change in CHANGELOG.md described
[ ] Tests created for changes
[ ] Screenshots added (for UI changes)

Can one of the admins verify this patch?


Analyse Heroic and user's perspective when hitting a timeout. Then implement necessary changes.

Implement Findings
Use Case Resolved: unknown Bigtable timeout & retry behaviour

I am a Heroic developer
who wants to make sure that our timeout & retry changes will work as expected
so that we don't have a disaster on our hands!

Design & Implementation Notes

this ticket was spun up off of peterk & adam's chat w.r.t. upgrading the Bigtable java client lib
this PR depends a lot on what’s discovered as part of “Discover how Heroic reacts to BigtableRetriesExhaustedException” (Issue #741), for which you should check out the Heroic API Request Timeout Settings document for the latest updates/findings
currently it’s looking like we want a 6s timeout across the board
but we don’t know why 65 data channels are created and why there are 72 timeouts logged before the 6s timeout occurs

Concrete changes to make

delete maxElapsedBackoffMs - it’s irrelevant for our Use Case (double check with Adam about his as it’s still in his doc)
upgrade the Bigtable java lib from 1.12.1 to 1.18.1 and check that we see 2x retries before the 6s timeout (see Slack thread with Adam / testing Doc). We know we need this as it resolves 2 or 3 retry-related bugs.
fine-tune all our *TimeoutMs and *TimeoutMillis settings

we finally know how API clients will experience the BT Timeout :

they’ll get a 200. Which is … interesting. And misleading IMO.
they get no results. Well, at least for the query I was running.
they get the following error message in the response body in errors[0].error :
"Some fetches failed (100) or were cancelled (870), caused by Some fetches failed (100) or were cancelled (870)"

we (Prism) need to decide if the above is acceptable. @malish8632 's argument is that this is the current behaviour and always has been, hence no changes are necessary.
My argument is that many more users who've never received a timeout before will now receive one, in the shape of a 200, which is super misleading cos it actually failed, in effect.
Hence the agreed-upon action is to phrase the 1, 2, 3 above as a "reminder" of how heroic returns requests that time out.


Booting from USB card /dev/sda possible?

Is booting from USB card /dev/sda , and not an SD card, possible on the PI version of ChromeOS?
With raspbian you just modify the config.txt in the boot partition. But with the ChromeOS more complex partition layout it looks like the PI boot files and settings are locked away in ROOT-A/boot/zImage-4.19.83-v7-g3c235dcfe80a-dirty ?
Can it be done if I attempt to build my own ChromeOS from this source? (I am attempting it, but it is quite a steep learning curve)

This can be closed. Linux OS was not picking up the Fat partition by defaukt. When the usb was inserted in a Windows Os, the fat partition showed and I could edit the cmdline. txt to change root=/dev/sda3

This can be closed. Linux OS was not picking up the Fat partition by defaukt. When the usb was inserted in a Windows Os, the fat partition showed and I could edit the cmdline. txt to change root=/dev/sda3

Can you specify what you did, I'm trying to boot Chromium from the USB 3 port of the Pi4b.
Following this vid @8:50
https://www.youtube.com/watch?v=FM9wuFLufyA
I edited cmdline.txt
changed root=/dev/sda3
But, when I go to boot I get a an error
"end kernel panic - not syncing: VPS: Unable to mount root fs on unknown-block(0,0)"
I've tried sda1 - sda7
Any help would be greatly appreciated

Is it possible on a PI 4?
See:
https://jamesachambers.com/raspberry-pi-4-usb-boot-config-guide-for-ssd-flash-drives/
This was required on the PI 3, but it might cause damage on a Pi4
https://www.raspberrypi.org/documentation/hardware/raspberrypi/bootmodes/msd.md


VCS Error

on executing  both these commands
run --test=riscv_arithmetic_basic_test
run --test riscv_arithmetic_basic_test --iss spike
I got this error
/bin/bash: line 0: exec: vcs: not found
Wed, 03 Nov 2021 21:51:27 ERROR    ERROR return code: True/127, cmd:vcs -file /home/ubuntu/riscv-dv/vcs.compile.option.f

Do you have VCS license and have you set up the environment path? What do you see with running this command?
"echo $VCS_HOME"

no I don't have VCS license but installed spike

Spike is an Instruction Set Simulator (ISS) which can run the generated assembly tests and not the SystemVerilog/UVM code. If you want to generate assembly tests from the riscv-dv, then you need either a simulator which supports UVM (e.g vcs, questa etc) or you need Python to be installed on your PC and use pyflow.

thanks, I'll try pyflow

what do you mean by "spike can only run generated assembly tests and not the SystemVerilog/UVM code". because riscv_arithmetic_basic_test  is an assembly code not the SV/UVM code, then why it's giving that error. Can you please explain.

Spike is an Instruction Set Simulator (ISS) which can run the generated assembly tests and not the SystemVerilog/UVM code. If you want to generate assembly tests from the riscv-dv, then you need either a simulator which supports UVM (e.g vcs, questa etc) or you need Python to be installed on your PC and use pyflow.

what do you mean by "spike can only run generated assembly tests and not the SystemVerilog/UVM code". because riscv_arithmetic_basic_test is an assembly code not the SV/UVM code, then why it's giving that error. Can you please explain.

@sundas56 , which error did it give while running an assembly test on spike? Can you also paste the command here for running the test on spike?

command
run --test riscv_arithmetic_basic_test --iss spike
error
" /bin/bash: line 0: exec: vcs: not found
ERROR return code: True/127, cmd:vcs -file /home/ubuntu/riscv-dv/vcs.compile.option.f  "

@sundas56 by default the vcs simulator is used. You should specify explicitely a simulator you have using --simulator argument. For 100% open source solution try with --simulator=pyflow.


YAML builds only work with latest (>2.158.0) agents

We noticed that YAML builds only work when you have the latest (2.158.0+) agent version.
> We had an earlier version (2.155.0) running, and YAML builds where not picked up.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43799c5d-2f13-cc76-a1c0-a3f850e16d4e
Version Independent ID: 97a5b73f-faf7-f9c0-9269-fc79984616d6
Content: Deploy a Azure Pipelines agent on Windows - Azure Pipelines
Content Source: docs/pipelines/agents/v2-windows.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

We have the same issue everytime the agent version upgrades (even prereleases).
And Azure it self doesn't prompts that we uses an old version of the agent.

The issue is still valid: the yaml build doesn't start if the on-premise agent doesn't have the latest pre-release version; lost 3 hours on this.

We have this issue too, the self-hosted agents don't update for some reason and every time a new version comes out the builds stop getting picked up.


legacy: replaces DatabaseError with IntegrityError in bibtasks

BibIndex and BibRank uses try to test insert
when a conflict may arise. After 2.1, this fails
as the exception thrown is now an IntegrityError

Signed-off-by: Øystein Blixhavn<EMAIL_ADDRESS>

Please amend commit message as follows:
legacy: fix database exception in bibtasks

* FIX BibIndex and BibRank uses `try` to test `insert` when a conflict
  may arise, however this fails as the exception thrown is now an
  `IntegrityError`.

Reviewed-by: Jiri Kuncar<EMAIL_ADDRESS>Signed-off-by: Øystein Blixhavn<EMAIL_ADDRESS>


[GH-657] add make all-test target, to locally run checks done by ci

Could you please add coverage folders to the gitignore file in this PR

@DanielaIvanova good point, I did do


YARN-11544. Add backlogs metrics  for request proposal

YARN-11544. Add backlogs metrics  for request proposal

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 20s

https://github.com/apache/hadoop/pull/5899 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/5899

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5899/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 19s

https://github.com/apache/hadoop/pull/5899 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/5899

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5899/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


made best recipe ever workshop

Your personal recipe workshop commits shouldn't be merged into main. Sorry!


The exporter panics when it looses connection to the Big-IP

We had an network outage, where the communication to the Big-IP was lost. The exporter paniced and exited, thus no more metrics.

I've located the issue and a new release containing the fix as well as some other improvements should be available in the coming days

Good job! Looking forward to the new release!
Thanks!

This is fixed in the new release 0.2.1


CaIman

See how to operates with Caiman

I'm currently finally coming around to this: using neuroconv to build a proper save functionality to replace Caiman's broken save_NWB() functionality.  Today I played with neuroconv and it works very well (with a minor terminological question from me: https://github.com/catalystneuro/roiextractors/issues/287).
When I used neuroconv to save nwb and then load the result directly into pynapple. It works mostly fine. The nwb time series are Neuropil, Deconvolved, and DfOverF. Pynapple yields the following:

It seems the dff field isn't getting parsed quite right 🤷♂ I can share an ipynb or py file to illustrate this. Just highlighting this for now maybe we can look after Cosyne.

Closing this issue as we already have some calcium imaging examples in the doc.


Can I set headers when use native loader?

You can set headers for the templates loader, but not for the js / css loaders. The files are loaded by appending script/link elements into the dom, that's why you can't use any headers. But you can disable cache with the param cache: false, it will add a timestamp to the url.
Templates on the other end are loaded via $http, so you can use any param that you'd use with $http.

thank you :)


Req. ― Web Component / Polymer widget

A Polymer widget would be nice. Here's an example of such a widget:
https://github.com/zenorocha/gplus-button
It just makes it easier to place in a page. Adding the JS / CSS / and relevant init() boilerplate is time consuming.

I think it would be really nice to add mibamur example or just a link to the README

https://github.com/kolarski/select2-wrapper

@kevin-brown Maybe you should evaluate these and add to README? Webcomponentisation is definitely a good use case for select2.


Investigate recognising array ops $push, $pop etc.

@mirek a little late to the party but that would be a very cool feature ! :)

it will also be good to have the $addToSet


Add debug option

Add debug option to pass an postcss-debug instance.
Fixes #39

Apart from that one comment this looks good to me. Nice one 👍


Median of 3 implementation and quicksort fixes

This pull request features the median of 3 implementation of quicksort and some quicksort fixes.
In this version, quicksort median of 3 and the default quicksort uses a shared module called quicksort_shared.js
The implementation focuses on toggling between the two quicksort modes and fixing the bugs related to both modes.

LGTM


Counting all the elements of a large collection is breaking

Summary
While migrating the ship-api to DaVinci we discovered that trying to list all the shipments was timing out.
The problem seems to be coming from trying to get an exact count of the documents in a very large collection in this line.
According to mongoose's documentation, the countDocuments method doesn't use any index, and it suggests to user estimatedDocumentCount() for large collections.
Problems

Using an estimated document count could break pagination -> This could be acceptable for very large collections where it is very unlikely that anyone will get to the last page. A possible solution could be to enable/disable the estimated count through the configuration.
Previously, of-base-api was using a mongoose plugin to handle pagination (feathers-mongoose). Using a plugin could be another solution.

@pierissimo could you please have a look when you have some time? @adriasala124 encountered this issue when migrating ship-api to DaVinci. We think the same may be happening in pimienta-api (workforce-api uses a different mechanism for pagination and always limits to 1000 elements)

Yep, digging a bit more into the feathers-mongoose current version used in previous api it looks like it is doing this operation for the count:
            this.model.where(where).count().exec()

and according to the documentation, using that without a predicate ( where : {} ) returns an estimate document count.
unsure if we can use that condition to choose one method or the other, probably we need to do some more testing @adriasala124

Fixed in #122

As discussed in the PR, estimatedDocumentCount() does not accept a filter criteria and that partially defeats the purpose of the change, as we rarely request the count of the entire collection, not even filtering by the organization ID.
Another approach would be to set the upper bound limit when counting:
model.find(where).limit(10000).exec();

A limit is already set in DaVinci's code here.

sorry I've fixed the example query of my previous comment, including the .count().
This is the way it works in the workforce-api

Yes, we explored to do in that way. As you said is not so common to request the count of the entire collection (in this case it was an internal API call), but decided to go with the estimated as the behavior was less breaking (it should behave very similar as previous implementation)

Yeah, I agree that is probably a separate problem.
Thanks


Issue #16: team-05 - Dispersion class

Pull request type
Please check the type of change your PR introduces:

[X ] Code base additions (bugfix, features)
[ ] Code maintenance (refactoring, formatting, renaming, tests)
[ ] ReadMe, Docs and GitHub maintenance
[ ] Other (please describe):

Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:

ReadMe, Docs and GitHub maintenance:

[ ] Spelling has been verified
[ ] Code docs are working correctly

Code base maintenance (refactoring, formatting, renaming):

[ ] Docs have been reviewed and added / updated if needed
[ ] Lint (black rocketpy) has passed locally and any fixes were made
[ ] All tests (pytest --runslow) have passed locally

Code base additions (for bug fixes / features):

[ ] Tests for the changes have been added
[ ] Docs have been reviewed and added / updated if needed
[ ] Lint (black rocketpy) has passed locally and any fixes were made
[ ] All tests (pytest --runslow) have passed locally

What is the current behavior?

Enter text here...
What is the new behavior?

Dispersion class
Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Enter text here...

Hey. This is really great!
There seem to be some issues still with some of parachutes' plots/attributes and some plot formatting. Since these are minor things I will give you the 50 points, but if you still want to work on this it would be great


More intrusive notifications

I research if is possible to get more "intrusive" notificacions for the desktop client (at windows OS for now).
Permanent/Sticky popup notifications.. (just stay visible until user get click)
Flash icon / on bottom panel/toolbar
Popup the main window?

Or some else.
The idea is to ensure to user must be notified even if leave and back from the computer for some little time.
thanks!

+1
Permanent/Sticky popup notifications.. (just stay visible until user get click)

Permanent/Sticky popup notifications.. (just stay visible until user get click)
As I discovered when trying to implement permanent notifications on Windows, this need to be some kind of custom undecorated window like https://github.com/blainesch/electron-notifications#introduction.

Flash icon / on bottom panel/toolbar
What do you mean by "flash"?

Popup the main window?
It can be activated via Window > Show on unread messages.

All these features depend on implementing a functional (and already planned) Preferences screen.

In Windows 10 not activate window application. Only blinked in task panel.

According to me, I think that the issue has been resolved, please try updating to the latest version...
These are the PRs that fixed this issue, please go through these and consider closing the issue.
https://github.com/RocketChat/Rocket.Chat.Electron/pull/2122
https://github.com/RocketChat/Rocket.Chat.Electron/pull/2465


Activate CodeCov

https://github.com/elijahf22/JuliaBoyz.jl/blob/c62dfaeb75e37c2ed541c616418735ba283f9c6c/README.md?plain=1#L6
For this button to be useful, you need to give CodeCov access to your repo

I'm not sure why it doesn't show up on the badge, I can see the coverage when I click the button, but I can't seem to get it to show up on the repo.


Refactor ProjectStatistics API

This PR cleans up ProjectStatistics API. Passing result from $stats->generate() to $stats->getTotalRow() feels really weird. It suggests that we are missing an abstraction of "ComponentAnalyser". We can take a look into that once the API stabilizes.

Solid work. I definitely agree, that the $stats->getTotalRow() thing was kinda ugly.
I really like the components() and other() methods. In order to get #21 forward, we will have to sort component in 2 "meta-groups" (application-code and test-code). I think this could happen here (or in a new class and the ProjectStatistics class gets the data from the new class)


main file should point at an actual file

While installing https://github.com/eviltrout/ember-performance I ran into some code that explicitly looks to the main file as defined in bower.json. It turns out bower.json still point at dist/ despite the components bower repo having no dist/ directory.
Fixes the main path to point as a real file.

so i think the components output needs to have this adjusted, but if people link to this repo and build manually this is accurate...

I have the same problem: https://github.com/Swiip/generator-gulp-angular/issues/448#issuecomment-86111332
It looks like this pull request could fix it.

bower should be pulling from https://github.com/components/rsvp.js which is (as of this morning correct)
https://github.com/components/rsvp.js/commit/0b1e4942dd638d6b49ae8a8e7a3b35f1efbbdce7


fix: content may not be a string

🐛 The bug
tag.props.content.startsWith is not a function
🛠 To reproduce
https://nuxtseo.com
🌈 Expected behavior
The content may not be a string and you need to add a judgment
ℹ Additional context
No response

This isn't a valid reproduction, however, I'm guessing you're trying to use a malformed og image path. I've pushed up a fix to handle this.


[2.9] Add a New Chart Test Suite that Installs Monitoring, Alerting, Istio and Logging

Issue: https://github.com/rancher/qa-tasks/issues/1200 & https://github.com/rancher/qa-tasks/issues/1190

Problem

Currently, chart tests in an Airgap Environment happen manually.
Solution

Add a new validation test suite that installs;

Monitoring
Alerting
Logging
Istio

And checks all pods are coming from the registry.
Automated Testing

Test types added/modified:

Validation (Go Framework)

Sanity checks will be provided offline.

Backports:

https://github.com/rancher/rancher/pull/45558
https://github.com/rancher/rancher/pull/45559


/home/$user/protection.sh: line 104: [: too many arguments

Script is getting stuck while checking under_attack status.

Thanks for reporting this! I will look into it.
Probably your curl command fails due to some reason (Lines: https://github.com/bobbyiliev/cloudflare-ddos-protection/blob/main/protection.sh#L35-L38).
I will try to add better error handling for that.

Just wanted to update on this. Originally I only received a couple of emails like that from the script.
I have been monitoring since and received the same message occasionally until today where I now got the following
/home/stephenl/protection.sh: line 104: [: ==: unary operator expected

I have tested adding extra []s to the code and so far it is correctly managing the security level. This PR should fix it.

Thanks for opening the PR! I've merged it now! Changes look great!


Fix navbar text

Change navbar text font and make it more visible.

I would like to work on this !

Sure but if you are looking for jwoc contribution then let me tell you this repository is not under jwoc

I am not looking for jwoc contribution but thank you for letting me know.


Set the border around images

Is there any way to reduce the border/padding that ends up in the print? Both left, right and bottom, to basically fill the paper as best possible.
Footer test is set to nothing.
Is there anything that can be done about this, or have i simply missed something?
It seems no matter the config I cannot do anything about the padding
See attached image. Orientation is set to auto in both cases.
These are 2 square images. 2848, 2848. I think this would be better in landscape

This is two images with resolution 4288x2848 This would be better in portrait mode I think

Normally if you put no footer text it shall use the whole height of the photo to put the images. Can you confirm that you kept the "footer_text1" and "footer_text2" keys in the config but put empty value in it (like "" or None)?
I don't think it is a good idea to give the possibility to set the border size around images.

A more dynamic way to set up to layout would be amazing, but probably out of scope.
The variables are set as
footer_test1 =
footer_test2 =
Should it rather be a double quote "" or the word None?

Hi,
I'have pushed a fix in order to improve the orientation=auto mode, but this doesn't change the padding .
The footer_test1 and footer_test2 shall be empty (not None nor "").
anxuae

I'm glad to hear! We're already live now so, it is what it is. Works great with picam as preview tho! Sent from my Huawei Mobile-------- Original Message --------Subject: Re: [werdeil/pibooth] Set the border around images (#55)From: Tony Anxuae To: werdeil/pibooth CC: layer91 ,Author Hi,
I'have pushed a fix in order to improve the orientation=auto mode, but this doesn't change the padding .
The footer_test1 and footer_test2 shall be empty (not None nor "").
anxuae
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/werdeil/pibooth","title":"werdeil/pibooth","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/werdeil/pibooth"}},"updates":{"snippets":[{"icon":"PERSON","message":"@anxuae in #55: Hi,\r\n\r\nI'have pushed a fix in order to improve the orientation=auto mode, but this doesn't change the padding .\r\n\r\nThe footer_test1 and footer_test2 shall be empty (not None nor "").\r\n\r\nanxuae\r\n"}],"action":{"name":"View Issue","url":"https://github.com/werdeil/pibooth/issues/55#issuecomment-464361451"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/werdeil/pibooth/issues/55#issuecomment-464361451",
"url": "https://github.com/werdeil/pibooth/issues/55#issuecomment-464361451",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Ok, it seems difficult to add borders handling in config


Duplicated values in public/gscd_data.csv

There are duplicate values for some years in our final dataframe for four countries when we use the following command: df[df[df.columns[1:-2].values].duplicated(keep=False)]
The countries are Afghanistan, Niger, Somalia, and Zambia. I have found the issue for Zambia, which is that there are multiple names for Maize in just one or two years. I will follow up on Niger as well.
Can you find the issue with the Afghanistan and Somalia data? Presumably there should be no duplicate values in this final public dataframe
Best,
Weston

Hi @WestonAnderson  Sorry for the late follow up on this issue. The current final combined file is /public/hvstat_data.csv, and I have found no duplicated rows. check this lines:
df = pd.read_csv('../public/hvstat_data.csv', index_col=0)
assert df[df.columns[:-1].values].duplicated(keep=False).sum() == 0

df.columns[:-1] only excepts for value.

I believe this has been resolved so I'm closing this out


Simplify portal defaults, get rid of 10-year-old migration code

Rationale

Related Pull Requests

Changes

So sad to see this beautiful code going away


Add a loader when API calls are loading

For next time, also be more cautious about reformatting a file, it makes the review more tedious.


[bug]: Update Linux installer to install necessary apt dependencies

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
No response
What happened?
A user reports in Discord:

python3-opencv requires the following libraries to be present:
apt update && apt install -y libglib2.0-0 libgl1-mesa-glx

we should either add this to the install script (but that will require interactivity and sudo from the user), or the docs
first investigate if other solutions also exist that don't require these libraries. maybe python-opencv-headless can be used, unless python3-opencv is a transitive dependency.
Screenshots
No response
Additional context
No response
Contact Details
No response

Theoretically possible, but not feasible with the amount of package managers out there.
You'd have to have a list of package managers like pacman, dnf, dpkg, portage and check which one is present.
Depending on that use the one present, search for the needed packages (they are not always named the same for every Distro) and assemble a command to install them.
Thats a lot of room for error and mistakes, i feel like it would be better to just list the dependencies and let the user install them manually.

@SammCheese yes, agreed. Besides, throwing unexpected OS package installation at the user is kind of icky. We'll take the documentation route.


The Results of Model Ensemble

Hello author! May I ask how the test set results obtained from model ensemble were obtained? Is it through the ensemble of several models obtained from a single training session or through multiple training sessions? Can you disclose the specific ensemble details?

Hi,
As described in the paper, we use ensemble techniques to get the test set results on the Argoverse 1, which is a quite standard procedure. We train several models with different random seeds. For the focal agent in a sequence, we gather the results produced by all these models, and use k-means clustering to find K=6 distinct categories and their corresponding weight. The final trajectories are calculated using the average of trajectories in each category, and the probability score is the mixture weight from k-means clustering.


nested npm-run-all. parent doesn't stop script execution after an error, in child run-all script

//build-script.js
runAll(     [         "a-script",       "run-all-b-script"         "c-script",     ],     { parallel: false })
//run-all-b-script.js
runAll(     [         "throw-an-error-script",       "execute-after-an-error-script",     ],     { parallel: false })
when running build-script, c-script gets executed, after error was thrown and exit code was 1 inside run-all-b-script. ("execute-after-an-error-script" is not executed which is correct)
Am I swimming against a river and exploiting npm scripts, by nesting run-all's?

Yes, all of them are .then .catched
in run.task.js
        cp.on("close", (code) => {             cp = null             resolve({ task, code })         })
"child" npm-run-all script
(which correctly stops further script execution and returns code: 1, when is started 'directly' with npm run "child"),
returns code 0, when is called from inside another npm-run-all script.

I finally had some time to play with the example code. I resolved the issue in the example code.
But what code is actually in the .catch(err => {}); block of the runAll().then().catch() statement in run-all-b-script.js ?
With a runAll statement, you can't throw in its .catch block. There is nothing to handle it (promises, promises). Of course using return Promise.reject(err) will also not work. Identical issue, unhandled  : UnhandledPromiseRejectionWarning.
So if you want to stop script execution (stop Node's process) you need to tell Node differently.
You can do it abrupt (abort) with process.exit(1);.
Or you can do it gracefully with process.exitCode = err.code; or process.exitCode = 1.
Reasons to exit gracefully are here : https://nodejs.org/api/process.html#process_process_exit_code
In the example that you created, change script-a-error-c.js to the following and play with the commented statements at the bottom of the .catch() block. Uncomment only one each time.
process.exitCode = err.code is what I use in nested runAll statements.
The lines throw (err);, throw (new Error('Something bad happened!'));, and return Promise.reject(err); will display the UnhandledPromiseRejectionWarning warning in the console.
const runAll = require('npm-run-all');

runAll(["a", "error", "c"], { parallel: false, stdout: process.stdout, stderr: process.stderr })
    .then(() => {
		console.info('>>> success running scripts a and c');
    })
    .catch(err => {
    console.error('>>> error running scripts a and c');

    // Lines below, added by @BobbyBabes.

    console.dir(err);
    console.log(err.code, err.results[1].code);

    // throw (err);
    // throw (new Error('Something bad happened!'));
    // return Promise.reject(err);
    // process.exit(1);
    // process.exitCode = 1;
    // process.exitCode = 0;
    process.exitCode = err.code // a.k.a. err.results[1].code;

  });

@BobbyBabes thank You very much for your time and help. I was unaware that I needed to stop node process. Have a nice day :}


Add getting started section to README

README Update
Please add a getting started section to the README so folks know how to start with this project.

added  getting started issue in README file.


Update list of permissions available in UI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This needs to be back ported to 7.9


Adding two player mode

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

[ ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ ] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

#3428
## Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @mishikagithub ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@mishikagithub resolve the changes!

Resolve the merge conflicts