Improved loading of the website

Fixes/Closes: #485
Additional Notes 📒

Hey @PiyushKalyanpy This is my new PR for the issue #485 (previous PR has some issues)
For all the information and screenshots please refer previous PR #486

Hey @PiyushKalyanpy Please provide level3 because it require so many files to change

🎉Thank you for your contribution @parasss19

Image is not working in some of the sections, please check


How to get gto describe --path

I am using artifacts.yml in the repo in order to annotate the artifacts registered with GTO.
I noticed that in the lates version v0.3.1 the command describe is removed.
How can I get the filepath to the artifact that is registered with gto?

Hi @rnoxy! Starting from 0.3.0, artifact annotations migrate from artifacts.yaml to dvc.yaml. For more details on the update, check out this comment specifically https://github.com/iterative/gto/issues/337#issuecomment-1559806244
There is a DVC API to add/read annotations if you need them:
from dvc import Repo

repo = Repo.Repo(".")

# reading
repo.artifacts.read()
# adding
repo.artifacts.add("added-from-python", Artifact(path="some"))

For the reasons for this migration, please check out the discussion here https://github.com/iterative/gto/issues/337
Are you using GTO with DVC, or GTO as a standalone tool? Also, once you read this, please let me know if this is solves your issue. Thanks!

Also, if you need to get path in CI, there is an action for that http://github.com/iterative/gto-action

Hi @aguschin , thanks for your reply. It really helped.
I am using GTO with DVC, but the confusion came from this documentation https://mlem.ai/doc/gto/command-reference/describe
Now I know how to migrate. Thanks.

Also, if you need to get path in CI, there is an action for that http://github.com/iterative/gto-action It also uses the DVC API I mentioned, so you can check it out to see an example of using it.

Hey @aguschin ,
but could you tell how to use this action with --repo option.
I see it can only work with . local repository, right?
So I cannot run gto dedscribe artifact_name --path with new dvc in CLI.

I have found the env variable GITHUB_REF
https://github.com/iterative/gto-action/blob/v2/read_annotation.py#L13
so one can try (probably) setting this to be --repo option.

The action works with the repo that's cloned in GH workflow. So to use that script, you better to cd into the repo dir. So yes, it doesn't work with remote repos. Moreover, I think DVC doesn't work with them if you do Repo(remote_url), but you can give it a try I think.


⚠ Bofrost.lu has degraded performance

In 3226c44, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1837 ms

Resolved: Bofrost.lu performance has improved in 96d3822 after 6 minutes.


Update Poll Functionality change request

As a cooperation admin I want to be able to update the poll with the following parameters:
Poll can be update only when its start_date is in future

title (header)
description
list of included houses
start date (only in case the current start date is in the future)

changes required from back-end team:
For endpoint PUT cooperations/{cooperation_id}/polls/{id}

add a description field to the request body,
add start_date field,
add included_houses field,
remove completion_date field,
remove status field

Please add your planning poker estimate with ZenHub @BohdanLysenko

We need to keep "status" for update
If user wants to change status to active we should change start_date to local timestamp


why I trained binary model is bigger than the original model?

hi,
I use the Lasagne to train a mlp model and cnn model on mnist, and get their ”model.npz” files.
I found that the size of  binary net  ”model.npz”  is larger than the  ”model.npz” of mlp and cnn.
Is that means the binary net will use more parameters and cost too much memory???

I found that the size of binary net ”model.npz” is larger than the ”model.npz” of mlp and cnn. Is that means the binary net will use more parameters and cost too much memory???

Those are the full precision training weights.
You might want to:

Binarize them with the sign function
Concatenate them in int32 variables.
Store them in a file.


expr: 1.14.3 -> 1.15.0

Diff: https://github.com/antonmedv/expr/compare/v1.14.3...v1.15.0
Changelog: https://github.com/antonmedv/expr/releases/tag/v1.15.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 252565 run on x86_64-linux 1

1 package built:

expr


Added merge capabilities to arguments passed to the Store constructor, making it possible to pass multiple mixins (to be merged as part of store creation).

@dcneiner @rniemeyer @arobson @johndmathis - putting this here to start the conversation. Let me know if you see issues or have concerns. One thing I'm not addressing is the fact that normal Store construction allows a custom state prop - I think we should just document that if you're using mixins, you need to not override the state prop name.

Per my chat today with @dcneiner and @rniemeyer, we'll proceed with this approach, and then (after Store's get an extend method), come back to this and allow multiple mixins to provide same-named function members (and each would be invoked).


Fix EKS provisioner and export Agent

What does this PR do?
Modify the EKS provisioner to use KubernetesAgent component and export it
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


ValueError: The provided lr scheduler "<torch.optim.lr_scheduler.LambdaLR object at 0x7fda400bdee0>" is invalid

Hi @kxz18 , I am trying to run your repo locally. I have the same package versions of the libraries you are using and I am getting File ".../lib/python3.9/site-packages/pytorch_lightning/trainer/optimizers.py", line 192, in _configure_schedulers     raise ValueError(f'The provided lr scheduler "{scheduler}" is invalid') ValueError: The provided lr scheduler "<torch.optim.lr_scheduler.OneCycleLR object at 0x151eea83f520>" is invalid  when I run train.py. This seems to be an issue with Lightning but I have the exact same version of Lightning as your codebase so I am not sure why this error is occuring. Is there any workaround?
This is the output after I run collect_env:
Collecting environment information...
.../lib/python3.9/site-packages/torch/cuda/__init__.py:173: UserWarning:
NVIDIA H100 PCIe with CUDA capability sm_90 is not compatible with the current PyTorch installation.
The current PyTorch install supports CUDA capabilities sm_37 sm_50 sm_60 sm_61 sm_70 sm_75 sm_80 sm_86 compute_37.
If you want to use the NVIDIA H100 PCIe GPU with PyTorch, please check the instructions at https://pytorch.org/get-started/locally/

  warnings.warn(incompatible_device_warn.format(device_name, capability, " ".join(arch_list), device_name))
PyTorch version: 2.0.1
Is debug build: False
CUDA used to build PyTorch: 11.7
ROCM used to build PyTorch: N/A

OS: CentOS Linux release 8.1.1911 (Core)  (x86_64)
GCC version: (GCC) 8.3.1 20190507 (Red Hat 8.3.1-4)
Clang version: Could not collect
CMake version: version 3.11.4
Libc version: glibc-2.28

Python version: 3.9.17 (main, Jul  5 2023, 20:41:20)  [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-4.18.0-147.8.1.el8_2.arc.x86_64-x86_64-with-glibc2.28
Is CUDA available: True
CUDA runtime version: 11.7.64
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA H100 PCIe
GPU 1: NVIDIA H100 PCIe
GPU 2: NVIDIA H100 PCIe
GPU 3: NVIDIA H100 PCIe

Nvidia driver version: 525.116.04
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              48
On-line CPU(s) list: 0-47
Thread(s) per core:  1
Core(s) per socket:  24
Socket(s):           2
NUMA node(s):        2
Vendor ID:           GenuineIntel
CPU family:          6
Model:               106
Model name:          Intel(R) Xeon(R) Gold 6342 CPU @ 2.80GHz
Stepping:            6
CPU MHz:             800.421
BogoMIPS:            5600.00
Virtualization:      VT-x
L1d cache:           48K
L1i cache:           32K
L2 cache:            1280K
L3 cache:            36864K
NUMA node0 CPU(s):   0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46
NUMA node1 CPU(s):   1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 invpcid_single ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local wbnoinvd dtherm ida arat pln pts avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq rdpid md_clear pconfig flush_l1d arch_capabilities

Versions of relevant libraries:
[pip3] numpy==1.24.3
[pip3] pytorch-lightning==1.5.7
[pip3] torch==2.0.1
[pip3] torch-geometric==2.3.1
[pip3] torchaudio==0.8.1
[pip3] torchmetrics==0.9.3
[pip3] torchvision==0.15.2
[conda] blas                      1.0                         mkl
[conda] cudatoolkit               11.3.1              h9edb442_10    conda-forge
[conda] cudatoolkit-dev           11.7.0               h1de0b5d_6    conda-forge
[conda] ffmpeg                    4.3                  hf484d3e_0    pytorch
[conda] mkl                       2021.4.0           h06a4308_640
[conda] mkl-service               2.4.0            py39h7e14d7c_0    conda-forge
[conda] mkl_fft                   1.3.1            py39h0c7bc48_1    conda-forge
[conda] mkl_random                1.2.2            py39hde0f152_0    conda-forge
[conda] numpy                     1.26.0                   pypi_0    pypi
[conda] numpy-base                1.24.3           py39h31eccc5_0
[conda] pyg                       2.3.1           py39_torch_2.0.0_cu117    pyg
[conda] pytorch                   2.0.1           py3.9_cuda11.7_cudnn8.5.0_0    pytorch
[conda] pytorch-cuda              11.7                 h778d358_5    pytorch
[conda] pytorch-lightning         1.5.7                    pypi_0    pypi
[conda] pytorch-mutex             1.0                        cuda    pytorch
[conda] torchaudio                0.8.1                    pypi_0    pypi
[conda] torchmetrics              0.9.3                    pypi_0    pypi
[conda] torchtriton               2.0.0                      py39    pytorch
[conda] torchvision               0.9.1+cu101              pypi_0    pypi

Hi, I think it might be because that pytorch 2.0.1 is used here. The base class of schedulers is _LRScheduler in versions below 2.0.0 (see here), which is used for if-else in pytorch-lightning 1.5.7 (see here). However, the name is changed to LRScheduler in versions above 2.0.0 (see here). Therefore, I think downgrade pytorch to versions below 2.0.0 might solve the problem.

In that case, please make sure your requirements.txt is updated. For instance, the wheel for torch==1.8.1+cu101 is no longer available. I had to install Pytorch 2.0 and that resulted in another set of error. Over the past week I have just worked on setting up 10 different virtual environments with various combinations of torch, pyg, sparse, scatter etc. but i still cant get your code to work. Please kindly check the requirement.txt file

I somehow managed to replicate your requirements.txt environment after reinstalling via various methods:
Collecting environment information...
PyTorch version: 1.8.1+cu101
Is debug build: False
CUDA used to build PyTorch: 10.1
ROCM used to build PyTorch: N/A

OS: CentOS Linux release 8.1.1911 (Core)  (x86_64)
GCC version: (GCC) 8.3.1 20190507 (Red Hat 8.3.1-4)
Clang version: Could not collect
CMake version: version 3.11.4

Python version: 3.8 (64-bit runtime)
Is CUDA available: True
CUDA runtime version: 10.1.243
GPU models and configuration:
GPU 0: NVIDIA H100 PCIe
GPU 1: NVIDIA H100 PCIe

Nvidia driver version: 525.116.04
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.24.4
[pip3] pytorch-lightning==1.5.7
[pip3] torch==1.8.1+cu101
[pip3] torch-cluster==1.6.0
[pip3] torch-geometric==2.1.0.post1
[pip3] torch-scatter==2.0.9
[pip3] torch-sparse==0.6.12
[pip3] torch-spline-conv==1.2.1
[pip3] torchaudio==0.8.1
[pip3] torchmetrics==0.9.3
[pip3] torchvision==0.9.1+cu101
[conda] cudatoolkit               10.1.243             h6bb024c_0
[conda] cudatoolkit-dev           10.1.243             h516909a_3    conda-forge
[conda] numpy                     1.24.4                   pypi_0    pypi
[conda] pytorch-lightning         1.5.7                    pypi_0    pypi
[conda] torch                     1.8.1+cu101              pypi_0    pypi
[conda] torch-cluster             1.6.0                    pypi_0    pypi
[conda] torch-geometric           2.1.0.post1              pypi_0    pypi
[conda] torch-scatter             2.0.9                    pypi_0    pypi
[conda] torch-sparse              0.6.12                   pypi_0    pypi
[conda] torch-spline-conv         1.2.1                    pypi_0    pypi
[conda] torchaudio                0.8.1                    pypi_0    pypi
[conda] torchmetrics              0.9.3                    pypi_0    pypi
[conda] torchvision               0.9.1+cu101              pypi_0    pypi

But I am getting the following error:
OSError: /.../lib/python3.8/site-packages/torch_spline_conv/_basis_cuda.so: undefined symbol: _ZN6caffe28TypeMeta21_typeMetaDataInstanceIdEEPKNS_6detail12TypeMetaDataEv

Hi, I've updated procedure for installing the dependencies in the README. I apologize for the inconvenience caused by the previous buggy requirements.txt. As for the newly posted problem, I think it might be related to the problem mentioned in the official pages of torch-geometric here.


PDF.js throws error when trying to Open PDF file generated from a GIF file

We get an error when we try to open certain PDF files that are created from iText with a GIF image in the file. We are using version 1.1.469 of PDF.js. I can provide a copy of the PDF file in question if needed to duplicate the test.
If you go to line 3840 of the function putBinaryImageData, the library throws an error because the 'dest' object does not have a 'set' method. The 'dest' object just looks like a byte array, and it does not appear to have a set method.

Please include the PDF. browser version, etc. See https://github.com/mozilla/pdf.js/blob/master/CONTRIBUTING.md for instructions on creating bug reports.
This sounds like a non-modern browser. Did you include compatibility.js to fill the gaps?

Thanks for your Rob.
Here is a link to that PDF file;
https://github.com/davidfekke/SamplePDFsForPDFjs/blob/master/somecrummyGIFConvertedTo.pdf
I will try adding the compatibility.js to my project. We are only having this issue with IE.

I added the compatibility.js file to my bundle, and it is rendering the PDF file correctly now. Thanks for your help.


[SuperEditor] - Audit example app using Flutter 3.3.x and fix any issues found

Flutter 3.3 introduced breaking changes to the IME API, and possibly other areas, too.
Update SuperEditor and SuperTextField to work with Flutter 3.3.x.
EDIT:
After upgrading to 3.3.3, I'm not seeing any compile-time breakages, which is odd, because there should have been breaking IME changes.
That said, here are some issues that I am seeing:
BLOCKED BY FLUTTER: When moving the cursor over SuperEditor, we initially see a text I-beam. However, once we place the caret, the cursor turns into a default cursor and never changes back to an I-beam. This is probably related to https://github.com/flutter/flutter/issues/111425
BLOCKED BY FLUTTER: When scrolling down a document with a magic mouse on Mac, we no longer have any scroll momentum. I filed https://github.com/flutter/flutter/issues/112880
PUNT: Task components in the example editor no longer respond to pressing enter. However, the other components seem to handle enter as usual. After further investigation, I think this problem always existed. I filed https://github.com/superlistapp/super_editor/issues/804
WILL FIX: In the example editor, once the popover toolbar appears, it doesn't move when the user changes the selection, or collapse the selection to a caret.
PUNT: The example with slivers has a somewhat janky momentum. Also, while scrolling with momentum, tapping on the content doesn't stop it from scrolling. We're stuck waiting for the scroll to stop itself. I'm going to assume this is tied to other scrolling issues and I'm going to wait for the next Flutter version to worry about this.
WILL FIX: The "switch focus" demo is failing. It shows a caret in the document, and in the text field.
PUNT: When scrolling through the drawer menu in the example app, as the scroll moves, the cursor doesn't automatically change to a pointer when scrolling over buttons. Instead, we have to stop scrolling, and then move the cursor somewhere. (I filed this: https://github.com/flutter/flutter/issues/112760). Flutter says this is fixed on master, which means it's out of our control and we won't get it until 3.4.
WILL FIX: The mobile demos on Mac have too much horizontal padding, which causes an ugly content flow.

After upgrading to 3.3.3, I'm not seeing any compile-time breakages, which is odd, because there should have been breaking IME changes.

I think you'll find the breaking changes are in Flutter 3.4.x-beta and above.

I think you'll find the breaking changes are in Flutter 3.4.x-beta and above.

Do you know the tentative schedule for a 3.4 release? Is that next quarter?

We have yet to roll out our Q4 Flutter release. So, I'd guess sometime before end of year.

I merged in a PR addressing issues I found that weren't blocked by Flutter. I'm going to close this ticket. We have another ticket at #806 to deal with a scrolling momentum bug from Flutter 3.3.3.

Where is the 3.4.x-beta ImeAttributedTextEditingController error being tracked? #792 is closed but I'm still seeing this error.

Since that breaking change ended up in 3.4 instead of 3.3.3, I'll re-open the other ticket.


Clear all hardware breakpoints on attach

closes #137

Should we do this on detach too?

Code looks good to me, I would really do this on detach as well too and not just on attach :)

@Yatekii  On detach I would need to iterate over all cores and clear all possible breakpoints each? Or would it be sufficient to do it in drop() of core?

@Yatekii On detach we would need to iterate over all cores and clear all possible breakpoints. Or would it be sufficient to do it in drop() of core?

It would have to be in Drop::drop() of the Core state. Because the actual core state and whether it is attached is stored within the Session :) But yes, that would work. And also, if we ever have a Session::detach_core() or similar, this will automatically clear everything for the right core :)


Add test for comment count and linters check

Add a new test for the comments counter function and install a package for a mock of the fetch.

Good job creating the test for the comments counter.
You can go ahead and merge.


API to fetch single testimonial

Description
Fetch a single testimonial by Id.
Acceptance Criteria

The endpoint should be accessible at GET /api/v1/testimonials/:testimonial_id
User should be authenticated to access the endpoint.
The endpoint should return a 404 status code if the testimonial does not exist.
The endpoint should return a 401 status code if the user is not authenticated.
The endpoint should return a 200 status code if the testimonial is fetched.
The endpoint should return a single testimonial.
The endpoint must accept access token Authorization: Bearer: <token>

Purpose
Be able to view a single testimonial and leave a comment.
Requirements

Implement API endpoint for single testimonial.
Testimonial should be fetched successfully if it exists.
Handle unexpected errors and return the appropriate status code.
User must be authenticated to access this endpoint.
The endpoint must accept access token Authorization: Bearer: <token>

API Endpoint
GET /api/v1/testimonials/: testimonial_id

Response
{
  "message": "Testimonial fetched successfully",
  "status_code": 200,
  "data": {
    "id": "String",
    "author": "String",
    "testimonial": "String",
    "comments": Array,
    "created_at": "DateTime",
  }
}

Error Responses
{
  "status_code": 404,
  "message": "Testimonial not found"
}

{
  "status_code": 401,
  "message": "Unauthorized "
}

Expected Outcome
User should be able to view Single Testimonial and all the comments associated with it.
Tasks

[ ] Develop API endpoint to view Testimonial.
[ ] Return proper error cases.
[ ] Write tests for the API endpoint.

Testing

Unit tests should be written for the API endpoint.
Integration tests should be written for the API endpoint.

Reference ticket: hngprojects/hng_boilerplate_nestjs#255
Slack id: - Habeeb Babasulaiman


generateMigrationsHash should not include all files - fix EISDIR error

After following the RDS Migration guide I ended up creating a package.json inside services/migration in order to be able to add import { Kysely, sql } from 'kysely' inside my migration files.
After doing so, I started seeing the following error:
Error: EISDIR: illegal operation on a directory, read

Trace: Error: EISDIR: illegal operation on a directory, read
    at Object.readSync (node:fs:751:3)
    at tryReadSync (node:fs:451:20)
    at Object.readFileSync (node:fs:497:19)
    at file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/constructs/RDS.js:367:31
    at Array.map (<anonymous>)
    at RDS.generateMigrationsHash (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/constructs/RDS.js:367:14)
    at RDS.createMigrationCustomResource (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/constructs/RDS.js:341:52)
    at new RDS (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/constructs/RDS.js:64:18)
    at EmptyStack.Database (file:///frontend/.sst.config.1701332147477.mjs:13:10)
    at stack (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/constructs/FunctionalStack.js:20:35)
    at App.stack (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/constructs/App.js:500:16)
    at Object.stacks [as fn] (file:///frontend/.sst.config.1701332147477.mjs:117:9)
    at synthInRoot (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/stacks/synth.js:56:24)
    at async Module.synth (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/stacks/synth.js:19:16)
    at async buildApp (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/cli/commands/bind.js:84:13)
    at async Object.handler (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/cli/commands/bind.js:51:9)
    at process.<anonymous> (file:///node_modules/.pnpm/sst@2.36.7_@types+react@18.2.39/node_modules/sst/cli/sst.js:58:21)
    at process.emit (node:events:529:35)
    at process.emit (node:domain:489:12)
    at process._fatalException (node:internal/process/execution:158:25)
    at processPromiseRejections (node:internal/process/promises:288:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)

This happens because generateMigrationsHash has a very hungry glob pattern and eats up all the files from node_modules and whatever else it find.
    generateMigrationsHash(migrations) {
        // Get all files inside the migrations folder
        const files = globSync("**", {
            dot: true,
            nodir: true,
            follow: true,
            cwd: migrations,
        });
        ...
    }

Ah I can see that. I'll tell the team.


Router does not match #[not_found] if it fails to parse into the target type

Problem
#[derive(Routable, Debug, Clone, PartialEq)]
pub(crate) enum AppRoute {
    #[at("/")]
    Home,
    #[at("/:id")]
    Article { id: u64 },
    #[at("/404")]
    #[not_found]
    NotFound,
}

println!("{:?}", AppRoute::recognize("/not/matched/route"));
println!("{:?}", AppRoute::recognize("/not-matched-route"));

And the output is:
Some(NotFound)
None

When using this route with Router, if the path matches /anything-but-u64, the router will simply stop rendering with no route matched.
Expected behavior
The output of the snippet above should be:
Some(NotFound)
Some(NotFound)

Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

Yew version: master
Rust version: 1.55.0
Target, if relevant: wasm32-unknown-unknown
Build tool, if relevant: not relevant
OS, if relevant: not relevant
Browser and version, if relevant: not relevant

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[x] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

This behavior is intentional. I kept it that way because more often than not, you would want to display a 404 message related to path segment missing. For example, you might want to display "route article not found". If we were to redirect to /404 in such case, that data would be lost. I think this is something that needs to be discussed before being changed.

For example, you might want to display "route article not found".

I don't think the current method has a way to recover from the "no route matched" error.
(This error message is shown in console as a warning and renders an empty page.)

If we were to redirect to /404 in such case

#[not_found] currently does not redirect, AppRoute::NotFound variant is returned to render_fn so an 404 page can be render in current path.
which means the path is obtainable via window().location().pathname().


Is it possible to specify Action ID in the array?

I'm wondering if its possible to set Action id for each menu item?

you mean pass id to action in actions option?

Yes, something like this:
Menu.popup({
  view: this.page.getViewById("menuBtn"),
  actions: [{id:'asdf', label:"Example"}, {id:'id-vertib', label:"NativeScript"}, {id:555, label:"Menu"}]
})

That would be very useful.

@ibnYusrat I think that possible.
I'll try

done

Beautiful!


Add support for port range mappings when deploying services

Is your feature request related to a problem? Please describe.
Port range mapping was introduced for containers in this pull request, it would be nice to have it for services also.
Describe the solution you'd like
The ability to forward a port range from the host to the service.
Additional info:
I believe this will likely be the same or very similar functionality as the previously mentioned PR.

@Whinarn you did a great job of the previous port range PR for containers! Feel free to dig into this one if you have the time! :+1:


fix(deps): update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.11.8

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/kms-all-inclusive/ibm (source)
module
patch
4.11.2 -> 4.11.8

Release Notes

terraform-ibm-modules/terraform-ibm-kms-all-inclusive (terraform-ibm-modules/kms-all-inclusive/ibm)
v4.11.8
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/key-protect/ibm to v2.7.1 (#482) (5f058fa)

v4.11.7
Compare Source
Bug Fixes

deps: bump provider version of DA solution to 1.65.1 to pickup fix for provider bug(#481) (d7138b8)

v4.11.6
Compare Source
Bug Fixes

deps: upgrade module required provider to at least 1.65.0 (#480) (f1bea48)

v4.11.5
Compare Source
Bug Fixes

new input variable rotation_interval_month for deployable solution (#479) * added new input variable rotation_interval_month to the deployable architecture solution, default to 12 months (0a72f66)

v4.11.4
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#473) (af5bff9)

v4.11.3
Compare Source
Bug Fixes

updated the deployable architecture keys variable description to point to a helper doc (#465) (b90c78c)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.2.11 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Set CPACK loading priority

When multiple dependent CPACKs are loaded the priority of loading is important. It is ensured by sorting of the config file names.

@likelion do you think a comment somewhere about the loading rule (that the 500 module shall be always loaded before 700 module) would be beneficial?

Definitely! It will be part of the README file describing the usage of OSCL lib.

Still, it would have been nicer if the priority was decoupled from the name of the module #iapproovedtoofast

I still don't see the explanation which module needs to be in which order and why. But doing this through the filename is OK as a quick fix, as long as we can understand it later.

Guys, this is the way ClioPatria works, I cannot do anything about it, took some time to figure it out also :) We can affect the situation through the official open source channel https://github.com/ClioPatria/ClioPatria.


updates and improvements in tools/find_deprecated

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.01%) to 88.961%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
1
92.48%

crates/accelerate/src/two_qubit_decompose.rs
1
92.13%

crates/accelerate/src/unitary_synthesis.rs
1
92.2%

Totals

Change from base Build<PHONE_NUMBER>1:
0.01%

Covered Lines:
79436

Relevant Lines:
89293

💛  - Coveralls


Wrap lines

It would be cool, if the user can set line wrapping to on. If conclave could then persist that as a user setting (localStorage?) that would be even better!

Hey @perguth, this project is no longer maintained and we aren't adding any features to it. We're keeping it open for education purposes. But feel free to fork it and implementing that feature!
For context, we did want to add line wrapping, but it caused the cursors to not function properly. I'm sure there's a way to fix it by improving the cursor logic. That's where I would start.


alias rustup date to update

I keep typing rustup date, and it looks like it's easier to fix the code
to work around that than my brain.

Hi, thank you for your contribution to rustup.
Unfortunately we're not really interested in extending the CLI surface of rustup in this way because it implies a requirement to support these typos for the foreseeable future, and adds a support burden for other distribution channels and the like.
I'd suggest that, if this is a very common typo for yourself, that you add a shell function to your shell's RC file, along the lines of:
rustup () {
    if test "x$1" = "xdate"; then
        shift
        command rustup update "$@"
    else
        command rustup "$@"
    fi
}

Again, thank you for wanting to contribute, and I'm sorry that we can't take this patch on.

no worries :) thanks for the work @kinnison !


If some cells are undefined, the filter can generate an invalid AST

If some cells are undefined, the filter can generate an invalid AST. For example, with this markdown:
::: list-table
* - A
  - B

* - 1
:::

...we get the following (edited to show just the offending rows; rep.lua reports the AST using the logging module; see below):
% pandoc-3.1.8 -L list-table.lua list-table-bug.md -L rep.lua -t html -o /dev/null
(#) blocks Blocks[1] {
  [1] Table {
    ...
    bodies: List[1] {
      [1] {
        ...
        body: List[1] {
          [1] pandoc.Row {
            ...
            cells: List[1] {
              [1] pandoc.Cell {
                alignment: "AlignDefault"
                attr: Attr {
                  attributes: AttributeList {}
                  classes: List {}
                  identifier: ""
                }
                col_span: 1
                contents: Blocks[1] {
                  [1] Plain {
                    content: Inlines[1] {
                      [1] Str "1"
                    }
                  }
                }
                row_span: 1
              }
            }
          }
        }
        ...

The row only contains a single cell, so this is an invalid AST and isn't handled correctly by all writers (see jgm/pandoc#9096 for further discussion).
The filter should be updated to add empty cells for any missing ones.
Here's rep.lua
local logging = require 'logging'
function Pandoc(pandoc)
    if logging.loglevel > 0 then
        logging.temp('meta', pandoc.meta)
    end
    logging.temp('blocks', pandoc.blocks)
end

In general it seems okay for a writer not to render malformed tables, but it should only affect that table, not the whole document. At the same time, I think it would be appropriate for pandoc to provide a function that turns a malformed table into a well-formed one, and that such a function should be exported to Lua.

Thanks @tarleb. Should I create a jgm/pandoc issue for this, or does such an issue already exist?
I propose making this issue depend on the above jgm/pandoc issue.

I thought the existing table builder in Text.Pandoc.Builder already did something like this?

In this case the list-table lua filter created the Table object directly. Does this bypass Text.Pandoc.Builder?

I thought the existing table builder in Text.Pandoc.Builder already did something like this?

I forgot about that. The filters bypass the builder functions, but that would offer a good way to normalize the AST. I'll look into it.

Please do open a new issue

I've created jgm/pandoc#10356.

FWIW my (no longer working) list-table filter did go out of its way to make sure that all rows were the same length simply by padding short rows with empty cells towards the end. It contained code like
-- NB at this stage rows[1] is the header row
local col_count = 0
-- First loop: get column count
for _, row in ipairs(rows) do
  if #row > col_count then
    col_count = #row
  end
end
-- Second loop: adjust row lengths
for _, row in ipairs(rows) do
  while #row < col_count do
    row[#row + 1] = { }
  end
end
-- Adjust widths list
while #widths < col_count do
  widths[#widths + 1] = 0.0
end
-- Adjust the alignments list
-- by simply copying the last explicit alignment!
if 0 == #aligns then
  aligns[1] = 'AlignDefault'
end
while #aligns < col_count do
  aligns[#aligns + 1] = aligns[#aligns]
end

(This wasn’t the actual code since my filter was written in MoonScript, but it compiled to Lua code equivalent to the above.)
My filter generated a SimpleTable, so things like colspan weren’t any concern.
It did require two loops over the rows list but neither loop is very complicated.
Instead of setting missing alignments to AlignDefault — unless there were no alignments — I copied the last alignment actually present. The rationale for that is that often all colums have the same aligment or the stub (leftmost) column is left aligned and all the rest are right or center aligned. The div around the list (which of course contained the class telling the filter that this was a list-table, but also some other formatting attributes) took an attribute aligns. In the common case where all cols had the same alignment you could just say aligns=c and in the second commonest case you could say aligns="lc" rather than aligns="ccccc" or aligns="lcccc". Of course there was a mapping with fields like d = 'AlignDefault', somewhere.
Nowadays I would use an re pattern {| ( %s* [dlcr] -> align_for %s* )* !. |} where align_for is the above-mentioned mapping, to parse the attribute value and create the list variable in one go, and similarly for the widths {| ( %s* %d+ -> pcnt2dec %s* )* !. |} where
pcnt2dec = function(p)
  return tonumber(p / 100)
end

(since I prefer using percentages for the widths!)

@tarleb, is https://github.com/jgm/pandoc/issues/10356 close enough to what you were envisaging?

It is, thanks. I probably won't do a full integration (for performance reasons), but want to provide a function that runs the AST through the builder to get a normalized document.


tests: setup jest, testing library and add tests

This PR set up jest and testing library. I also added a snapshot test to get some coverage.
I'll work on adding more tests to cover the other cases into another PR just to keep things simple.
@computerjazz Can we run this on a CI? CircleCI for instance.

I appreciate the PR, but I haven't found snapshot tests to be useful in my experience -- I've never caught a bug because of failing snapshots, and developers tend to just update them whenever they fail.
What use case do you see snapshots being useful for here?

@computerjazz I've added this snapshot test just to make things easier as I'll add tests to cover other scenarios such as on drag start, end, rendering placeholder, and so on.
But I can remove it if you want

ah ok, well, if creating those tests seem interesting/useful for you I'm open to setting that up.
I'd gravitate towards github actions for CI.

Sounds good.
That's just a way to contribute to the amazing work you did here. :smiley:
Also, it'll make it easier to track bugs and breaking changes.
I'll work on that in the next few days. thank you

Done @computerjazz. I was able to add a few scenarios but I couldn't cover others because of Animated.Code is mocked. Maybe when #245 got merged we can add a few more around the componentDidUpdate.


Trouble installing fluent-ffmpeg

balter@spectre:~/videoinfo$ node --version
v8.11.1
balter@spectre:~/videoinfo$ which node
/home/balter/conda/bin/node
balter@spectre:~/videoinfo$ npm --version
6.1.0
balter@spectre:~/videoinfo$ which npm
/home/balter/conda/bin/npm
balter@spectre:~/videoinfo$ npm install fluent-ffmpeg
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! path /home/balter/videoinfo/node_modules/isexe
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/home/balter/videoinfo/node_modules/isexe' -> '/home/balter/videoinfo/node_modules/.isexe.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR!
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.4 LTS
Release:        16.04
Codename:       xenial

Very strange. I was able to install using -g. However, I'm still not able to install locally with npm install --save.


add gracenote id for channels dvr epg loading to m3u

this adds the tvc-guide-stationid to the generated m3u, which enables channels dvr to pull the guide data directly from their gracenote db rather than having to use the locast epg.

Nice! Thanks!


chore(catalog): aboutcard tests typo fix

typo fix
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks for the contribution! All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Fixed. Didn't have the correct email set as public 🙃

Thanks!


support Tuple types

just adding this for completeness

@tballmsft Can you please give an example here?

Typescript supports tuples, see here. I imagine the most straightforward way to implement it would be via unnamed classes.

IMHO this is overkill though...

No immediate plans. Closing.


Support for in-app docked Admin Console

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[ ] Caught up with develop branch as of last change.
[ ] Added CHANGELOG entry, or determined not required.
[ ] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[ ] Updated doc comments / prop-types, or determined not required.
[ ] Reviewed and tested on Mobile, or determined not required.
[ ] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Wild! It certainly is a cool idea, and makes for a pretty impressive demo.
I can think of a few prefs / capabilities we might wish to add if we want to push forward here - 2-3 sizing modes, swap to a standard browser tab, etc. Would be interesting to discuss how we think it might be useful IRL. Could be a fun topic for our Friday standup...

Yeah! Would love to hear others' input on this. One thing I would like to figure out is if we can reload the main app to read in any admin changes without hard refreshing the tab (i.e. refresh everything except the admin dock?)

Its definitely a lot to think about -- am curious about the use-case you are tying to optimize -- monitoring tracking? Changing config/preferences and seeing behavior on the fly?
Seems like an interesting option would also be to expose certain admin tasks (config and prefs?  monitoring? ) in a more minimal popup/modal view in the main app.  Imagine you could even flip between key views in that tool just using a select affodance, rather than the full tabsets.
Think my my concerns are:

anything that will complexify our runtime behavior for initialization.  (e.g. the smart refresh you describe)
It seems like our admin UI would need some additional adjustments -- right now it looks too much like the actual app with the two level tabs, and all of the other app chrome of its own.  Its like looking into a mirror facing another mirror....

Looking forward to discuss more...


Checking a number has exactly 4 factors using number theory using C++

🚀 Feature
Checking a number has exactly 4 factors
An efficient approach is to use the concepts of number theory for four-factor numbers. So, if a number has four factors then,

If the number is a cube of a prime number. Then it will have four distinct factors. Example, if N = (p^3), the factors will be 1, p, (p^2), N.
If the number is a product of two distinct prime numbers. Then also it will have four distinct factors. For example, if N = p1*p2, the factors will be 1, p1, p2, N.

I want to add this code under CP folder
Have you read the Contributing Guidelines on Pull Requests?
YES
Motivation
This problem is the base of many problems of CP. A naive approach is to calculate all the factors of a number and then checking either they are equal to 4 or not, but this has more time complexity. So I want to implement it using number theory with less time complexity.
Pitch
This will be used in CP.

/assign


Fix CRI image pull timeout test for ppc64le

The ghcr.io/containerd/registry:2.7 image does not support the ppc64le architecture, causing the TestCRIImagePullTimeout tests to fail when executed on a ppc64le device. The ghcr.io/containerd/registry:2.7 image is replaced by the ghcr.io/containerd/volume-ownership:2.1 image, allowing all tests to pass. This commit addresses issue #7197.

/ok-to-test


Add Dremio as a destination

Description
This PR adds Dremio as a destination to DLT
Additional Context

Tested locally against OSS Dremio running in docker and against Dremio Enterprise cluster.
dockercompose.yaml provided for creating local Dremio environment with minio as an object store for staging.

Some details for future PRs:

implement merge write disposition using MERGE INTO
implement table partition evolution

@maxfirman this is amazing! we'll assign a reviewer tomorrow and add tests to our CI jobs after merging

@maxfirman PS: You're welcome to join our community at dlthub.com/community and text me directly if you'd like to discuss this PR.

Hi @sh-rp, thanks for taking the time to review this. To answer your questions:

pydremio.py contains some code originally taken from dremio arrow flight examples repo here, with some modifications and additional code. The code in that repo is licensed under Apache 2.0.   I believe this means I need to copy the original license header text into the file and state that the file has been modified from the original.
I hadn't run the all tests/load tests, thanks for pointing out how this is done. I've just tried to run this now and there were some failures that I will need to address.
I've only tested against s3 so far. Dremio supports Azure and Google storage, so there is no reason why this couldn't work. s3 is straightforward to test locally as I can spin up minio in docker container, I assume there are equivalents for google and azure but I'm unfamiliar. Would you be happy to only include s3 support as part of this PR? Google and Azure could always be added as a followup if demand arises.

I should be make the changes tomorrow otherwise it will be mid next week.

@sh-rp I've got this mostly passing against the tests in tests/load except for the following tests:

tests.load.pipeline.test_replace_disposition.test_replace_disposition
tests.load.pipeline.test_restore_state.test_restore_state_utils

I've run out of time today to get these working, but will have another look next week.

@maxfirman could you provide me with your secrets.toml that you are using to connect to the local dremio and s3-mocker?

That's right. Here is the secrets.toml:
[destination.filesystem]
bucket_url = "s3://dlt-ci-test-bucket"

[destination.filesystem.credentials]
aws_access_key_id = "minioadmin" # copy the access key here
aws_secret_access_key = "minioadmin" # copy the secret access key here
endpoint_url = "http://<IP_ADDRESS>:9010"

[destination.dremio]
staging_data_source = "minio" # the name of the "Object Storage" data source in Dremio containing the s3 bucket

[destination.dremio.credentials]
database = "dlt" # the highest level of hierarchy under "data_source". e.g for AWS Glue catalog this is the Glue Database name
host = "localhost" # the Dremio hostname
port = 32010 # the Dremio Arrow Flight grpc port
data_source = "nas" # the name of the destination data source in Dremio
flatten=false # if true tables will be written as <dataset>__<table_name>, otherwise <dataset>/<table_name>
drivername="grpc" # either 'grpc' or 'grpc+tls'
username="dremio"
password="dremio123"

@maxfirman thanks! When running tests/load/dremio/test_dremio.py::test_dremio with your creds and the docker containers running, I am getting:
E           dlt.pipeline.exceptions.PipelineStepFailed: Pipeline execution failed at stage load when processing package<PHONE_NUMBER>.017133 with exception:
E
E           <class 'OSError'>
E           [Errno 5] An error occurred (426) when calling the CreateBucket operation: Upgrade Required

Is this something you have encountered? All the other tests also fail, but I wanted to get this one to run first.

Unfortunately I haven't seen that one before.
Perhaps the bucket creation failed during the docker compose startup and dlt is trying to create the bucket and failing for some reason.
Its worth confirming that the bucket in minio is being created by the createbuckets service in the docker compose. Once the docker-compose is running you should be able to login to the minio ui at http://localhost:9011 and confirm that the bucket has been created. I would then check the Dremio UI at http://localhost:9047 to confirm that minio is configured as a data source in Dremio and that you can see the dlt-ci-test-bucket within it.

@rudolfix  thanks for time and effort reviewing this PR!
Indeed Dremio does not support NOT NULL constraints on columns. I think you are right that is the cause of the test failure.
I agree with all of your points. I have a few other thoughts as well for follow up PRs:

Dremio recently fixed a bug that enables the use of the ADBC client https://github.com/apache/arrow-adbc/issues/1559. We could therefore remove the pydremio.py file and cut over to ADBC. I don't think there is any rush on this.
I'd like to test a wider selection of destination data source types in Dremio. We are somewhat hamstrung by the lack of CREATE SCHEMA support, which is why the CI tests run against a "NAS" (really local file system). I know that Dremio does support CREATE FOLDER sql statements for Nessie catalogs, so Nessie might be next logical thing to add to the testing pipelines as it should be possible to get all the tests passing against it. It might also be worth running a subset of the tests that don't require CREATE SCHEMA against a Hive Metastore data source.
I can foresee that we may want to expose a "path_prefix" config option to build tables at arbitrarily nested levels in a folder structure.
MERGE INTO sql support is vital given that Dremio doesn't support transactions, so I'm really glad to hear that is on your backlog!

@maxfirman one question to:

I'd like to test a wider selection of destination data source types in Dremio. We are somewhat hamstrung by the lack of CREATE SCHEMA support, which is why the CI tests run against a "NAS" (really local file system). I know that Dremio does support CREATE FOLDER sql statements for Nessie catalogs, so Nessie might be next logical thing to add to the testing pipelines as it should be possible to get all the tests passing against it. It might also be worth running a subset of the tests that don't require CREATE SCHEMA against a Hive Metastore data source.

we will be able to test against dremio cloud right? this "NAS" is also available there - the "local" filesystem is in the cloud then, right?
also: https://github.com/dlt-hub/dlt/issues/1199

this "NAS" is also available there - the "local" filesystem is in the cloud then, right?

@rudolfix I'm not 100% sure as I'm only familiar with their on-prem offering.
If we are running tests against Dremio Cloud it may make sense to use the built in "Arctic" catalog (which is basically managed Nessie) instead.
Nessie can be run in a docker container, so we could also extend the docker-compose.yaml to stand up a Nessie server if we wanted to test this out against a Dockerised deployment.


Fixes 2631: handle bucket hostname with proto

Summary
Sometimes the objectstore  hostname has a protocol/scheme, sometimes it doesn't.  Handle both cases (with a test!)
Testing steps
snapshotting works in ephemeral, we'll test stage after merge

merged with blessing from @swadeley


Indeterminate (Looping) Progress Bar control is not compatible to firefox

Bug description
Indeterminate (Looping) Progress Bar is not working in firefox
How to reproduce
Link: Progress bars.
Steps to reproduce the behavior:

Open firefox browser and paste the url 'https://clarity.design/documentation/progress' in address bar
Scroll down to 'Indeterminate (Looping) Progress Bar'
See the progress bar looping is static (not working)

Expected behavior
Progress bar should be looping infinitely
Versions
App

Clarity: v4

Device:

Firefox Browser [v80.0.1 (64-bit)]

I tested this on macOS and Windows but it works as expected. The demo is only set to repeat ten times.

Thanks for reporting this. There is something going on with FF for sure.

I cannot reproduce this issue in current versions of Firefox, closing as fixed in the browser.


#102 collapse all installation instruction

Signed-off-by: gunjanmimo<EMAIL_ADDRESS>

@leecalcote sir, now I made all correction, I noticed that we have all the expected changes in this pr?


feat: Add widget responsiveness and conversion algorithm

Description
QA branch for mobile responsiveness

/build-deploy-preview env=release

@prsidhu Preview is available at https://appsmith-goutham-appsmithcom-get-appsmith.vercel.app/
You need to check the 7th step in vercel-local-build to see the URL

/build-deploy-preview env=release

/build-deploy-preview env=release

DP Link: https://appsmith-ojudnw5pt-get-appsmith.vercel.app/user/login

/ok-to-test

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/ok-to-test

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/ok-to-test

/ok-to-test sha=780ce7e

/build-deploy-preview env=release

/build-deploy-preview env=release

/ok-to-test sha=0fc61ea

/build-deploy-preview env=release

/ok-to-test

/ok-to-test

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/ok-to-test

/build-deploy-preview env=release

/ok-to-test

/build-deploy-preview env=release

/build-deploy-preview env=release

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test

/ok-to-test

/build-deploy-preview env=release

/build-deploy-preview env=release

/ok-to-test

/perf-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/ok-to-test

/build-deploy-preview skip-tests=true

/perf-test

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/ok-to-test

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/ok-to-test

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test

/perf-test

/build-deploy-preview skip-tests=true

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview skip-tests=true env=release

/build-deploy-preview skip-tests=true env=release

/build-deploy-preview skip-tests=true env=release

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview env=release

/ok-to-test

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview env=release

/ok-to-test

/build-deploy-preview skip-tests=true

/perf-test

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview env=release

/ok-to-test

/perf-test

/ok-to-test

/perf-test

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/perf-test

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test

/ok-to-test

/build-deploy-preview skip-tests=true

/perf-test


Unproper error message if an identifier can not be resolved by PIDMR backend  (invalid identifier)

code	500
message	"Cannot communicate with metaresolver: Hostname pidmr.lab.pidconsortium.net not verified:\n    certificate: sha256/JNruRqJ6ITdwwfmhj8ekBCnypweKca6yU7CMTb1DMrY=\n    DN: CN=prefix-info.pid.gwdg.de, O=Gesellschaft für wissenschaftliche Datenverarbeitung mbH, ST=Niedersachsen, C=DE\n    subjectAltNames: [prefix-info.pid.gwdg.de]"

There was a test Provider in the backend where its regex matched the 2022icrc.confE1145C. Consequently, when resolving 2022icrc.confE1145C, the backend considered it belonged to the test Provider. This test Provider had metadata mode, so the backend requested metadata from the Handle system for 2022icrc.confE1145C. Hence, the specific message.


Make central services report their version to wmstats

otherwise it's just undefined for the moment.

@amaltaro,  Alan, I include this on the other fetch to avoid conflict. #7796


Support for arbitrary query strings

Hello!  I'm trying to use the OpenAPI 3.0 spec to document an API that supports a subset of the Resource Query Language (RQL).  However, because this query string format doesn't adhere to the typical name=value parameter structure, I'm struggling to express it in OpenAPI.
For example, a valid query string might be:  http://localhost:5000/books?select(title,author)&gt(published,2000-06-30T12:20:08Z)&sort(published).
I wouldn't expect OpenAPI to understand RQL, but if there were a way to specify that an endpoint may have a query string, and that the query string contents are beyond the scope of OpenAPI, that would suffice.  (I'm really thinking from the Swagger UI perspective -- so a user wanting to try the API can type in the entire RQL query string themselves.)
If anyone has any thoughts on other ways this can be accomplished with the existing 3.0 specification, that would be great too!
Thanks,
Paul

Hmm.... is there (or could there be) a media type for RQL query strings?
Technically, the name=value parameter structure is not a URI thing, it's the application/x-www-form-urlencoded media type.  As far as URIs are concerned everything in between the ? and the # is the query string with no mandatory structure.
OpenAPI could offer an in value of queryContent or something like that, and then use the content field for that parameter to express RQL as a media type.  Maybe?  Just brainstorming a bit here, there might be obvious problems with this approach as I've not thought it through.  I definitely have no idea what tooling challenges this might introduce (Hi @webron!)
(interestingly, this would also allow expressing relationships among query parameters as you could use queryContent with application/x-www-form-urlencoded and then apply schema to that to produce the name=value stuff - see also #256)
(also, I can't tell if #1054 is similar to this or not)

As @handrews mentioned, you probably need to use the content keyword for your query parameter. content uses the media type identifier to define the serialization format for the parameter schema.
You can find a similar example for SPARQL at https://github.com/OAI/Gluecon-Workshop/blob/master/Different/parameters.md#complex-parameters-in-v3
In your case, you can try something like this:
    parameters:
    - name: complexQuery
      in: query
      content:
        application/rdf:
          schema:
            ???   # type: string? type: object?
          example: select(title,author)&gt(published,2000-06-30T12:20:08Z)&sort(published)

application/rql is the proposed media type for RDF according to http://dundalek.com/rql/draft-zyp-rql-00.html#rfc.section.13

Thanks for the replies!  I tried the content suggestion above and unfortunately it's putting [parameters.name]= in front of the RQL string.  When I include allowReserved=true and supply a value of "select(author)&sort(published)" for this field in the Swagger Editor, it transforms into http://localhost:5000/books?complexQuery=select(author)&sort(published).
If there's a way to prevent it from adding complexQuery=, I'll be all set!

If there's a way to prevent it from adding complexQuery=, I'll be all set!

@pofallon assuming setting the name of the parameter to '' (the empty string) doesn't work?

That's a good suggestion!  Unfortunately it appears that with either an empty name, or no name defined at all, it omits the parameter altogether.

The only question is how to delimit multiple simple parameters in the query string

Would it be reasonable to restrict the query string to a single parameter when using the simple style?  Usually the rare occasions that I see the whole query string used as a string, there's some very specific syntax (such as the example given here) that's in use and won't mix well with anything else anyway.
It would be interesting if we could find any examples of multiple values in a free-form string that are not following an externally-defined syntax.

I'm not exactly sure how simple and form parameters in the query would interact.

My intuitive guess would be that when using form parameters you always have to end up with a valid application/x-www-form-urlencoded string in the query, which is part of why I'd assume that you couldn't mix these.

According to
https://swagger.io/specification/#parameterContent
you can use a combination of style and  explode to select how the url looks like.
From the table of examples, since I want "in: query", I can choose style from form,space delim, pipedelim or deep object.
If I now use an array of size 1, and spaceDelimited, and explode=false, I should be getting the value without the variable name or the equals sign.
However, https://editor.swagger.io/ still adds the "=". According to the messages above, it looks like the table in https://swagger.io/specification/#parameterContent is wrong in various places, and the parameter name is always included.
For the moment, I would recommend that the table be fixed; while we wait for a new OpenAPI version allowing the new features requested here.

I would like to see this feature as well.. RAML handles it using regex. OAS uses regex with field values, it should be a short hop for keys.

This would also be useful for JSONAPI exposed through OpenAPI. ?filter[foo]=bar is the format for JSONAPI filtering, (though the specifics are not defined, and left to implementations). In this case, foo could be just the field name, or some complex thing like foo.contains or foo.prop[2] or whatever.
What I'd like to be able to do, similar to @RubenGarcia's idea, is some way to allow the user to add multiples, but instead of just specifying the right hand side, specify the left too if that makes sense?
Just illustrive - something like this:
      - in: query
        name: filter[{my_query}]
        required: false
        schema:
          type: string

That would allow adding multiple params of the form filter[...]=....
We can enumerate these server side for basic types, but we also have complex nested objects, and operations, such as ?filter[inputs.datetime.gte]=242839744 - to query for the datetime property of inputs where the time is greater than or equal to 242839744. With all of these enumerated, it can easily end up with hundreds, if not thousands of combinations, which gets completely over the top quite quickly. Cleaner (for us) to just provide a template, and document.

@keyz182 your scenario can be described by using a deepObject-style parameter:
      - in: query
        name: filter
        required: false
        schema:
          type: object
          additionalProperties: true
          example:
            foo: bar
            inputs.datetime.gte: 242839744
        style: deepObject

        # The example translates to:
        # ?filter[foo]=bar&filter[inputs.datetime.gte]=242839744

@hkosova Oh wow, that's perfect! Looks like I need to do some more RTFM :)

This issue has a use case of an almost-but-not-quite application/x-www-form-urlencoded format that includes "flag" parameters without a = involved.

#1782

As noted in a comment there, I think implementing this would also allow more experimentation with deepObject-like formats that handle more use cases.
This could also be explicitly called out as an extension point so that tools can provide a hook for 3rd-party support, rather than adding an open-ended mandatory tooling requirement.

@OAI/tsc review request:  Let's approve this for 3.2, and I can write a PR to add in: queryString as an option.  It would solve numerous other issues.  There are two major use cases:
Parity with form-urlencoded request bodies
in: queryString
content:
  application/x-www-form-urlencoded: {...}

This provides exact parity with how application/x-www-form-urlencoded request bodies work, which would also solve at least the following:

#2511 (by using additionalProperties normally in the schema)
#2347 (by using required normally in the schema)
#2298 (by using $ref normally)

Ability to use (and experiment with) arbitrary query string formats
This is the original motivation for this issue.  This would also allow us to recommend that people who want new/complex query serializations define a media type and a way to model them in schemas as an extension, particularly if we implement #3771 (Registry of media type modeling approaches).  This could arguably allow us to close (by deferring to extensions) issues including:

#230
#883
#1501
#1504
#2276
#3048

All of these request new serialization approaches based on either existing formats that we can't easily describe (OData) or on a variety of other formats used elsewhere, or just directly requested for one reason or another.  It's unlikely that we'd deal with any of these because this area is complex enough as it is, but given users full control over the query string gives them a way to solve it themselves.

Discussed in this week's TDC meeting and agreed that this idea has lots of merit. We requested @handrews to work this into a formal proposal to target 3.2


chore(tests): updating the syntax to the new ES2017

I'm planning to clean up the code a little bit using the newest syntax of ES2017. At the same time, I get used to the lib and tests.
@Hackdom @joshuahannan please take a look and let me know your thoughts.

Yeah this looks great Paulo. Are you ready for a merge on this?

@Hackdom not yet, still refactoring the remaining tests. this will probably be finished late tomorrow.

ok, no problem, looks great man

This looks great to me, Josh do you have anything else?

I’m still updating the variables names, will send the commit first thing
tomorrow.

Everything looks great to me. So clean looking!

I like the changes. a lot easier to read with the new variable names.


serverinfo not fully working

as it seems like this is the first non-troll issue xD
well, your serverinfo command has two bugs:

it always says "1 Member"
it says "Owner: None"

any quick fix for this?

Also.. im getting an error saying " sh: 1: mode: not found "

hey VerstreuteSeele i'd be happy to help you with your issue, i gotta admit it was really a long time for a respond but now we will update the code and you should see if everything is as it should be now, thanks for reporting the issue! Much love,
owersite

Fixed, if u find any other issues open an issue, thanks !


[Proposal] Proof of Environmental Sustainability activities and best practices for CNCF projects

Description
We would implement a process/approach for CNCF projects (and others) to qualify their commitment to Environmental Sustainability and give them a KPI on their hand to show improvements.
Therefore we can leverage the Software Carbon Intensity (SCI). I think we will have to define 2 SCI.

Default SCI: Within the default SCI, we will define some values as the Embodied and Energy Carbon Intensity. Also, we will specify the test setup.
Custom SCI: The custom SCI is up to the project, and we will assist. Also, we will provide a reference implementation that can be used (eg. we identify an approach how to easily measure relevant data).

Besides the SCI we can think of a checklist out of the Green Software Patterns and how much they are adhered to by the projects where possible.
Both can be checked per release. If the project thinks of optimizations it will get visible over time.
In the beginning, the definition and KPIs tracked per project could be stored in an "ensu.md" within their repositories. Where a project has multiple components, either each will require its own definition or all together are evaluated.
In the future, we can further automate this and display the SCI value per project in a Grafana dashboard. We could add tags like the following to the projects as indicator etc.

We could add this as entry criteria for CNCF projects when the approach is matured.
Impact

This activity will increase the visibility and relevance of or topic.
Projects have a reference value against which they can optimize their software.
We will provide a relevant approach to how to implement this measurement.

Timeline
I would like to postpone working on this until we have all deliverables for KubeCon EU. However, if this proposal founds support within the TAG, I want to introduce this idea also to the TOC and receive their feedback, before we start planning activities.
Scope
The initial scope should focus on a pragmatic approach. Therefore, we need 3-5 projects for testing before rolling it out. Also, we should work and push this topic top down, from the big graduated to the smaller incubated and sandboxed projects.
Resources
Working document: https://docs.google.com/document/d/1qLjYlkOvcduxRnGo2-zfaGb9170Ziq0Pf9-OeI1GFqo/edit#

Hi @mkorbi - we discussed this in our https://github.com/Green-Software-Foundation/opensource-wg/issues/75 meeting today - @srini1978 of Microsoft has been working on a way to generate CarbonQL scores in an automated way
Are you interested in collaborating with us on this? FYI @jawche @seanmcilroy29 @dtoakley-tw @dtoakley
We also have a guide here: https://sci-guide.greensoftware.foundation/

hey @Sealjay we are looking forward to working with you on this and I'm very interested in @srini1978 approach. I joined the meeting yesterday, but no one (1-2 silent people) joined within the first 10min, maybe I have the wrong invite.
About the guide, I'm well aware. For me would be the question of whats the right approach to support the OSS projects in it. Thats why I came up with the idea to find a half way generic SCI spec to get things rolling and then in extend to do custom SCIs. Not sure if it makes sense though.

Perfect @mkorbi! And sorry, we moved the meeting to :15 past the hour yesterday.
So this is the CarbonQL project:
https://github.com/Green-Software-Foundation/carbon-ql
I'm not sure I understand the idea of a custom SCI though - is this about defining how the score was calculated and the variables used? If so, that might be related to the SCI reporting requirements:
https://github.com/Green-Software-Foundation/sci-reporting/blob/main/reporting_requirements.md

@mkorbi it will be at :30 past the hour next week going forward; still happy to discuss.

Checking in here on this - specifically best practices for CNCF projects IAW with this group's charter:

Capabilities, benchmarks, and processes to evaluate technological and architectural health of projects

Is the expectation on this issue's deliverable to be an initial guide in evaluating resource consumption for projects in a default configuration so that interested projects can receive such an evaluation from this TAG? there is a balance between projects in CNCF that can do this for things running in an environment, however there is also an outstanding need for projects to understand how they are performing and areas they could improve so that as they develop features and other capabilities, this is in the forefront of those decisions. Even starting with common trade-offs for efficiency would be beneficial.

@TheFoxAtWork This whole space is fairly new and I don't think we are anywhere near where we want to be regarding measurement.  The tooling regarding networking consumption or cooling offsets for CPUs heating (cooling is 30-50% of datacenter costs) are not there.  Most measurements currently have to do more with the power use of the CPUs, maybe something regarding memory use.  I think stating maybe what is in existence regarding measurements (which we have some of in the landscape doc) and then continuing to expand on what capabilities exist is helpful.
Let me give an example of my concerns:
The SCI repo with their published example here:
https://github.com/Green-Software-Foundation/sci/blob/main/case-studies/eshoppen.md
They talk about the energy consumption being measured here:
https://github.com/Green-Software-Foundation/sci/blob/main/case-studies/eshoppen.md#energy-e
P[kwH] = (Power consumed by CPU or Pc Number of cores + Power consumed by Memory or Pr + Power consumed by GPU or Pg Number of GPUs)/1000 (
This slice of energy measurement, for instance, misses the networking power consumption (and "those switches can be indistinguishable from blast furnaces that happen to route packets"-not my words) and heating requirements (for everything involved-sometimes those labs sound like jet engines because of the power required to cool).  If we dig into even more optimal ways we can save energy, I am also unaware of anything that measures the amount of energy required by things like crossing the UPI bus in a multi-socket system in the case that the CPU/memory/GPUs are not co-located in the same NUMA node.  I'm sure there are other pieces I'm missing, like packet-processing core consumption (something that may be done as part of auxiliary functionality on the board), length of time to run a process according to its efficiency, et cetera.  Additionally, I suspect that not only does the CPU Utilization not scale linearly with power consumption, but also the heat generated does not.
And none of this talks about time-to-failure, as may be discussed on this paper here (HPC has done a lot of work around the space of saving power in massively distributed systems):  https://www.osti.gov/servlets/purl/1140455
(things that keep me up at night)
...
Which is a very long way of saying I worry and this is not an easy space.

Understood. Recommend narrowing the focus to areas where we've got something we can begin with - CPU & GPU utilization, cores, & memory. How do our projects today measure up across those categories? are there specific operations, configurations, and functions that increase or decrease those categories? What about specific functionality that could be smartly considered to reduce across those categories?  Take security and event logging for instance, is it more efficient to do on-host processing or send logs off host to a central service to aggregate, analyze, process, and display? Can we educate adopters on reasonable expectations for logging to reduce consumption? i.e. logging touches these "hot spots" in sustainable computing: processes, storage, networking, detection, etc. these hot spots have other consideration to reduce their footprint, do you really need to "log all the things"? balancing why its needed, what it conveys, and other observations that convey the same value for less consumption. can logging be limited until indicators of an issue occur which in-turn trigger on-demand expanded logging?

@TheFoxAtWork You are absolutely correct.  We have a tendency to measure everything and goodness gracious do we love our dashboards.
I've been advocating we partner with something like GSF with SCI in the "what" to measure, and generally how to get those metrics, and then as part of the CNCF TAG work here do more of the "how" and "minimal resource consumption" part.
I would like more scientists/industrial engineers involved.  Part of my general concern is that CPUs are such a small part of the total power consumption while cooling is a larger part of that total usage.  We may be optimizing for the components that are much smaller in impact over other factors.
We also have to be aware that some customer requirements, depending on how the chips work and whether the kernel scheduler looking at the current core usage causes an interrupt, will not find acceptable those measurement methods (think traffic that cares about kernel interrupts, like most things with quick packet processing).  I know that K8s does not allow for core assignment like that, but there are many workarounds that let us get around that (see CMK for instance) which are being used in industry.

@TheFoxAtWork This whole space is fairly new and I don't think we are anywhere near where we want to be regarding measurement. [...
Let me give an example of my concerns:
[...]
This slice of energy measurement, for instance, misses the networking power consumption (and "those switches can be indistinguishable from blast furnaces that happen to route packets"-not my words) and heating requirements (for everything involved-sometimes those labs sound like jet engines because of the power required to cool).  If we dig into even more optimal ways we can save energy, [...]

I'd agree on networking - to note that the SCI is a living document, so please do propose PRS or issues to include networking considerations further.
It's part of a bigger landscape for us - so we include networking in our training patterns ( https://patterns.greensoftware.foundation/catalog/cloud/reduce-transmitted-data ) and it's in discussions for some of the other measurement tooling like carbonQL.

@Sealjay do you think we could get the GSF to give a presentation at our next meeting, on the 7th of June, on SCI and current efforts shaped around that?

Sure, I'll drop Abhishek and Henry an email (they are the chairs of the Standards WG.)

Contact me via slack (or @mkorbi  or @leonardpahlke  or @caradelia  and we can make sure it is reflected on the agenda ahead of time.

Contact me via slack (or @mkorbi or @leonardpahlke or @caradelia and we can make sure it is reflected on the agenda ahead of time.

Please do so by dropping a message to the #tag-env-sustainability channel - so others are aware. Looking forward to it 🙌

I'm on a mobile without slack at the moment, but just dropped @catblade and @mkorbi an email - @Henry-WattTime is happy to support.

There is an ongoing discussion among GSF folks about how to measure the energy consumption of networking, as raised by @catblade: https://github.com/Green-Software-Foundation/sci-guide/issues/13
That repo has a bunch of other open issues around this. It looks like the right place to start a similar investigation on how to quantify the energy consumed by cooling. There is a reference to cooling here, which points to: https://devblogs.microsoft.com/sustainable-software/how-to-measure-the-power-consumption-of-your-backend-service/, which uses the Thermal Design Point as a reference.
Echoing what @catblade said on the GSF leading "what" to measure while the TAG takes care of "how" to do that in a cloud-native context.
There are open-ended questions about handling known unknowns, mapping these, and incorporating new/evolving data points. However, it would be great to start collecting data on what we can already measure (CPU, GPU, memory), as @TheFoxAtWork said.

SCI = (E * I) + M per R
(E) - Energy consumption
(I) - Emissions factors
(M) - Embodied emissions data for servers

While we have some of the Energy component, it is equally challenging to collect data in a consistent way for carbon emissions (I) and embodied carbon emissions (M) in the context of the cloud. There are a few different methods for doing this. We may want to start by crowdsourcing and documenting these different methodologies. @mkorbi I remember you mentioned something around this during the project meetup at KubeCon EU?
Lastly, the Tools & Practices / GreenOps / etc WG has gathered some momentum and a group of folks who would like to contribute to this kind of technical work, but it lacks focus so we are trying to narrow down the scope. In the last meeting, we decided to shift focus to support this initiative. How about we merge this project and the WG effort?

FYI: https://github.com/falcosecurity/falco/issues/2435#issuecomment-1598567599

Service Desk ticket opened for an account and hardware

I am currently running some testing and screwing things together, which slowly leads me to the following picture we can provide.

In that case, we would have to provide:

GH Action template
GH Action that executes the testing
Test server with the setup
dev stats config?
Shema/approach for the test e.g. idle, avrg. load, scaled load?

@mkorbi happy to chime in if help is needed with k6.io, as this is my squad at Grafana.

I will close this issue since we started the WG Green Reviews last summer which addresses this issue.


StreamType Enum are case sensitve

In the latest version, the Media.StreamType enum types are lowercase, however the specifications and some apps (pandora) use all caps.
https://developers.google.com/cast/docs/reference/receiver/cast.receiver.media#.StreamType
"W/s*.l*.c*.a*.v*.Channel: Error while reading: Can not construct instance of su.litvak.chromecast.api.v2.Media$StreamType from String value 'BUFFERED': value not one of declared Enum instance names"
Should they be changed to all caps or should additional logic be added to make case not a factor?

I don't know. Probably it should be case-insensitive, since in example provided by @haku it is in lower case while in specification and in pandora case it is upper-case. I have asked about that in #14 Let's wait for an answer.

I have just merged your pull request #16 and added upper-case enum elements for StreamType along with unit test. Let me know if it works for you with Pandora.


Refactor things in node manager to be in wallet

Found a couple other smaller areas where node_manager was being called. Fix them and tested both ln address and subscriptions, all of that works now.


Master Broken

I can neither start the editor nor the game:
Uncaught exception thrown in Thread[jME3 Main,5,main]
RendererException: compile error in: ShaderSource[name=matdefs/MyTerrainLighting.frag, defines, type=Fragment, language=GLSL100]
0(238) : error C1008: undefined variable "m_DiffuseMap_3_scale"
0(244) : error C1008: undefined variable "m_DiffuseMap_4_scale"
0(249) : error C1008: undefined variable "m_DiffuseMap_5_scale"
0(254) : error C1008: undefined variable "m_DiffuseMap_6_scale"
0(259) : error C1008: undefined variable "m_DiffuseMap_7_scale"

Pull the frag file from buildingqndmining branch

I'm up to date on that branch. Maybe the file was not commited?

Is there a change?


Add TCPC driver for RT1715

Add TCPCI functions and add driver for Richtek RT1715.

Looking good. One last ask. Please add a build test that links in this driver.
See #83187 for an example.
Locally, you can run ./scripts/twister -ivc -s drivers.usb.build.i2c to verify the test.

Thanks for your review.
The commit has been added. In order to ensure that everything works well together, this PR contains #83187 now. If #83187 is merged first, I will rebase and update this PR.

Looking good. One last ask. Please add a build test that links in this driver.
See #83187 for an example.
Locally, you can run ./scripts/twister -ivc -s drivers.usb.build.i2c to verify the test.

Thanks for your review. The commit has been added. In order to ensure that everything works well together, this PR contains #83187 now. If #83187 is merged first, I will rebase and update this PR.

#83187 has now merged.

看起来不错。最后一个问题。请添加在此驱动程序中链接的构建测试。有关示例，请参阅 #83187。在本地，您可以运行以验证测试。./scripts/twister -ivc -s drivers.usb.build.i2c

感谢您的评论。提交已添加。为了确保一切顺利，此 PR 现在包含 #83187。如果先合并 #83187，我将变基并更新此 PR。

#83187 现已合并。

Just updated. Local tests passed.


Node not running

When i put the electron files into the app directory it fire´s up the index.html but give me errors like

In my opinion the node server is not running, but i have checked the environment variable

I´m stuck with that for a long time some help would be really nice

hi @WoodyPhil the errors you showed are not related with node running or not - in fact, it is running and that's the cause of your issue. Please have a read here about jQuery being confused on electron https://stackoverflow.com/questions/32621988/electron-jquery-is-not-defined


cannot download through web ui

I've run ./utils/mkdisk.sh and copied build/images/disk.vmdk.gz and build/images/disk.vmdk.manifest to webapp/dist/. I've built the webapp and run python -m http.server in the dist folder.
However, downloading fails:

The web console does not show much:

Is there a way to get an image without the Web?

I think the problem was with my browser. It works better now.


Finalize parameterization strategy for CV32E20

Moving status to "Not Started" as there is no indication that anything was done on this task.


Implement additive blending for animation graphs.

Additive blending is an ubiquitous feature in game engines that allows animations to be concatenated instead of blended. The canonical use case is to allow a character to hold a weapon while performing arbitrary poses. For example, if you had a character that needed to be able to walk or run while attacking with a weapon, the typical workflow is to have an additive blend node that combines walking and running animation clips with an animation clip of one of the limbs performing a weapon attack animation.
This commit adds support for additive blending to Bevy. It builds on top of the flexible infrastructure in #15589 and introduces a new type of node, the add node. Like blend nodes, add nodes combine the animations of their children according to their weights. Unlike blend nodes, however, add nodes don't normalize the weights to 1.0.
The animation_masks example has been overhauled to demonstrate the use of additive blending in combination with masks. There are now controls to choose an animation clip for every limb of the fox individually.
This patch also fixes a bug whereby masks were incorrectly accumulated with insert() during the graph threading phase, which could cause corruption of computed masks in some cases.
Note that the clip field has been replaced with an AnimationNodeType enum, which breaks animgraph.ron files. The Fox.animgraph.ron asset has been updated to the new format.
Closes #14395.
Showcase
https://github.com/user-attachments/assets/52dfe05f-fdb3-477a-9462-ec150f93df33
Migration Guide

The animgraph.ron format has changed to accommodate the new additive blending feature. You'll need to change clip fields to instances of the new AnimationNodeType enum.

r? @aecsocket

It's probably worth mentioning in the 0.15 migration guide that the changes to weight normalization in #15589 can be counteracted by shoving each AnimationClip behind its own additive blend node if the previous behavior is desired. Please correct me if I'm wrong :) @pcwalton

I never really considered that, but I think that's correct?

Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to https://github.com/bevyengine/bevy-website/issues/1715 if you'd like to help out.


Unable to rebuild apk with apktool

when i was binding payload with metasploit the error shows that
32 bit support is deprecated.
pls help 🙏
thank u

There is a lot going on here. You can clearly using a mobile device, that is detected as 32 bit and using a tool that uses Apktool.
That is not supported. So closing.


Run CI in multiple languages for the print screen

I didn't have much knowledge about GitHub Actions, but I copied our iOS integration test file. I'm not sure if this is the correct approach, but the task was fulfilled :).
I think it's sufficient for the iOS system alone, but if it's needed for the Android system as well, please let me know and I will add it. (Since we already have screenshots for different screens, I thought we could also use them for Android. Additionally, our CI testing for Android hasn't been very successful.)
Test artifacts https://github.com/encointer/encointer-wallet-flutter/actions/runs/5076102599
The screenshots are taken for the following devices:

iPad Pro (12.9-inch) (3rd generation)
iPad Pro (12.9-inch) (2nd generation)
iPhone 11 Pro Max
iPhone 8 Plus

[x] Create github action release_ios_integration_test.yml (multi language-"de, fr, ru, en")
[x] Added integration-app-test-ios-screenshot-multi-language && integration-app-test-android-screenshot-multi-language melos commands. (We could have done it without them, but as developers, we also added "melos" commands in case we want to use them.)

Closes #1113

This is one approach, but you can also just make the dependent on the tag creation instead of the entire workflow
https://github.com/integritee-network/integritee-node/blob/89f8cc939c719025cd57379a007b7f36a58bdd29/.github/workflows/ci.yml#L487
Then you don't have to recreate the entire workflow file. :)
# some pseudocode:
test-with-all-languages:
    name: Run integration tests with printscreens in all languages
    if: startsWith(github.ref, 'refs/tags/')
    ...

test-english-only:
    name: Run integration tests with printscreens in en only
    if: !startsWith(github.ref, 'refs/tags/')


Added android roadmap

Fixes Issue
#204

Changes proposed
Added roadmap for Android. Added necessary resources
Screenshots

Note to reviewers
Please review it. Let me know if anything missing

Hi @siddhant-khisty please review my PR and merge it

@c99SRS Please don't link to the website. The entire roadmap needs to be converted to a markdown format. Also please make new PRs for the other files that you have changed. Keep the scope of this PR focused on converting the roadmap.

@c99SRS please read the instructions provided in the issue. Every step is mentioned clearly. You can ask us if you find something difficult. I am closing this PR as a fresh new pr would be easier for both of us

yeah sure

hey can you assign this issue to me @kaiwalyakoparkar


Update Azure Identity AAD links

Summary of changes

Update links that were broken or redirecting due to the Azure AD rebranding
Update old docs.microsoft.com links to use learn.microsoft.com

API change check
API changes are not detected in this pull request.


Notebook cleanup and binder for public demo?

Hi CMIP6 Hackers!
We are beginning to think about how to collect and share all of the amazing work that happened at the CMIP6 hackathon. Google will announce the CMIP6 public data program on Dec. 2, and we'd like to have some examples to share with the world by that time. We have identified your project as one of the ones we'd like to include in an examples gallery.
What we'd like to see happen are the following:

[ ] pick ONE notebook as representative of your project and clean it up so that it can execute in sequence with no errors. (It doesn't have to be the most complex or ambitious thing--just something that loads and visualizes some of the data is more than sufficient.)
[ ] create a binder using http://binder.pangeo.io/ (we can help with the details on this)
[ ] use Zenodo to make your repo citable to ensure you get proper attribution.

We're really excited about your project and hope you can find some time to work with us to get these items completed by the target date.

Thanks for letting us know! We'll coordinate a share a binder with you before December 2nd.

@rabernat, we are currently prepping that notebook, but some of the analyses need quite a bit of computing time. Would the output be expected to run on the binder (e.g. can we link to the kubernetes dask clusters somehow?) and if that is possible should we aim for a maximum execution time?

@rabernat We created a binder and the repository is now citable. Let us know if there is anything else that you need for the announcement of the public data program


Array Input support for CoordInterpGrid

Is CoordInterpGrid could be modified to support array input?
Below example gives error
x = sort(collect([-1.0:0.1:1.0;2:0.01:3]))
y = collect( 2.0:0.5:10.0)
z_2d = Float64[sin(i+j) for i in x, j in y]

z_2di = CoordInterpGrid((x,y), z_2d, BCnil, InterpQuadratic);

while this works.
x = [-1.0:0.1:1.0;2:0.01:3]
y = 2.0:0.5:10.0
z_2d = Float64[sin(i+j) for i in x, j in y]

z_2di = CoordInterpGrid((x,y), z_2d, BCnil, InterpQuadratic);

Coordinates would not be always range type if we do some fitting from experimental data.
I hope CoordInterpGrid to support range or is there some other way?

This package is deprecated in favor of Interpolations.jl; now new development is likely to happen on this package (it will in fact not be installable on Julia 0.6).
Interpolations.jl requires Julia 0.4 or higher, but the functionality you want is supported.


refactor: destroy_note(...) optimization

Fixes #1718

1657547-1423179=234368 gates 👀

Benchmark results
Metrics with a significant change:

avm_simulation_time_ms (FPC:prepare_fee): 150 (-31%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 7,966 (+16%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_30_ms
11,392
3,061
1,469 (+6%)
1,636 (+3%)
1,559 (+1%)

proof_construction_time_sha256_100_ms
44,684
12,034
5,663
5,590
5,547 (+1%)

proof_construction_time_poseidon_hash_ms
79.0 (+1%)
34.0
35.0 (+3%)
57.0
89.0 (+1%)

proof_construction_time_poseidon_hash_30_ms
1,516
417
203
220 (-5%)
267 (+2%)

proof_construction_time_poseidon_hash_100_ms
5,762
1,579
727
777 (+1%)
798

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,476
9,474
9,476

l1_rollup_execution_gas
610,297
610,295
610,297

l2_block_processing_time_in_ms
754
1,408 (+1%)
2,668 (+1%)

l2_block_building_time_in_ms
25,354 (+1%)
50,928 (+1%)
100,371 (+2%)

l2_block_rollup_simulation_time_in_ms
25,257 (+1%)
50,627 (+1%)
100,018 (+2%)

l2_block_public_tx_process_time_in_ms
21,678 (+1%)
46,863 (+1%)
96,274 (+2%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
6,959 (+1%)
9,852 (+3%)

node_database_size_in_bytes
12,148,816
16,101,456

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
67.8 (-1%)
13,873

GasToken:set_portal
16.6 (-4%)
3,495

Token:constructor
95.7 (+1%)
24,207

FPC:constructor
63.0 (-2%)
13,893

GasToken:mint_public
52.6 (+2%)
10,241

Token:mint_public
73.1 (+19%)
19,216

Token:assert_minter_and_mint
210 (-7%)
13,034

AuthRegistry:set_authorized
32.9 (-4%)
7,869

FPC:prepare_fee
:warning: 150 (-31%)
15,187

Token:transfer_public
31.4 (-20%)
31,425

FPC:pay_refund
161 (+13%)
20,080

Benchmarking:increment_balance
2,679 (+1%)
15,465

Token:_increase_public_balance
54.7 (-9%)
15,089

FPC:pay_refund_with_shielded_rebate
146 (-10%)
21,167

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.181 (-1%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.3 (+1%)
16.7 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.596 (+1%)
0.513 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.3 (+1%)
75.7 (+1%)
130 (-1%)
245 (+2%)
467 (+2%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.492 (+1%)
0.465 (+1%)
0.448 (-1%)
0.443 (+2%)
0.436 (+2%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.2 (+1%)
111 (+2%)
181 (+1%)
352 (+2%)
687 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.501 (+1%)
0.499 (+2%)
0.481 (+1%)
0.478 (+2%)
0.472 (+1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
72.7 (+1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.518 (+1%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
85,672
670,983

Transaction size based on fee payment method
| Metric |  |
| - |  |

Docs Preview
Hey there! 👋 You can check your preview at https://6673e65d9b6d6414fb03657f--aztec-docs-dev.netlify.app


Add an input to tell the analyzer what runtime is being used

When calculating braking changes, it would be helpful to let the analyzer know what the desired target framework would be. Right now, all known breaking changes would be returned, when this could be trimmed if we know what the desired target is.

Nice to have