Unchecking "Experiments: Enabled" in Python setting re-checks it for Jupyter setting and vice versa

VS Code version
1.62.2
Extension version
v2021.11.1422169775
OS type
Windows
OS version
10
Python distribution
Anaconda
Python version
3.9
Language server
Pylance
Expected behaviour
I expect experiments to remain disabled
(not sure where to report this, but since python and the jupyter extension are installed together i guess here works?)
Actual behaviour
Experiments get re-enabled for Python when I uncheck it for Jupyter and vice versa.
Experiments also get re-enabled when checking/unchecking other options.
Steps to reproduce

Logs
nothing is shown in ouput when doing this.
jupyter extension version: v2021.10.1101450599
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@fohria When following these steps which other extension did you use https://github.com/microsoft/vscode-python/issues/18067#issuecomment-974329783. Can you also provide a list of extensions installed?

ah good question, could be this only happens in conjunction with the remote plugins i use for WSL:

weird though, they're all official microsoft plugins so i would expect them to work well together

I have not been able to repro this in the latest version of VS Code and python extension. I have tested in both desktop and WSL scenarios. If it continues to occur this might be an issue with VS Code setting UI, do let us know it is still happening.


type cast in tuples

TypeScript Version:  3.1.6
Code
		const a1:[number, number, boolean] = [1, 0, false];
		//... code
		if (a1[2]) {
			a1[2] = false; //error TS2322
		}

Expected behavior:
no error (run in TypeScript 2.9.2)
Actual behavior:
TS2322: Type 'false' is not assignable to type 'true'.
why is the type cast to true ?

if (a1[2]) checks for truthiness and thus narrows the type of a[2] from boolean to true.

first of all, this has nothing to do with type casting. this is an issue with narrowing.
This is fixed by #27574 which is part of v3.2.0-rc (and probably this week in v3.2.1)


Update scalafmt-core to 3.0.0-RC7

Updates org.scalameta:scalafmt-core from 3.0.0-RC3 to 3.0.0-RC7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-pre-release

Closing for https://github.com/tanishiking/scalafix-unused/commit/f929736284bed35dc43f0027d90da985839bd53c


Changing of build path

to dist

Hi @ragingwind
I've just tried a dozen React PWA Boilerplates. Turns out your is the only one which works! The rest have too many bugs or do not work at all.
Great job! Thanks.
PS: Sorry spamming in this unrelated issue.


Cannot query field "allLocale" on type "Query".

I've followed the How to use instructions here: https://www.gatsbyjs.com/plugins/gatsby-plugin-react-i18next/
and upon restarting my server with gatsby develop, I get the above error. Full error message here:
Cannot query field "allLocale" on type "Query".
ERROR #85923

There was an error in your GraphQL query:

Cannot query field "allLocale" on type "Query".

If you don't expect "allLocale" to exist on the type "Query" it is most likely a typo.
However, if you expect "allLocale" to exist there are a couple of solutions to common problems:

- If you added a new data source and/or changed something inside gatsby-node.js/gatsby-config.js, please try a restart of your development server
- The field might be accessible in another subfield, please try your query in GraphiQL and use the GraphiQL explorer to see which fields you can query and what shape they have
- You want to optionally use your field "allLocale" and right now it is not used anywhere. Therefore Gatsby can't infer the type and add it to the GraphQL schema. A quick fix is to add at least one entry with that field ("dummy content")

It is recommended to explicitly type your GraphQL schema if you want to use optional fields. This way you don't have to add the mentioned "dummy content". Visit our docs to learn how you can define the schema for "Query":
https://www.gatsbyjs.com/docs/reference/graphql-data-layer/schema-customization#creating-type-definitions

I'm no Gatsby veteran, so I'm guessing I have an issue with my setup that I'm just not seeing. Any help greatly appreciated. I realise I haven't given much detail about my project, so let me know what you need and I'll provide it.
Edit - 18/02/2022
Here is my current gatsby-config.js

const dotenv = require("dotenv");

dotenv.config({
  path: `.env.${process.env.NODE_ENV}`,
});

module.exports = {
  plugins: [
    `gatsby-plugin-image`,
    `gatsby-plugin-jss`,
    `gatsby-plugin-sharp`,
    `gatsby-plugin-react-helmet`,
    `gatsby-transformer-sharp`,
    {
      resolve: `gatsby-source-filesystem`,
      options: {
        path: `${__dirname}/locales`,
        name: `locale`,
      },
    },
    {
      resolve: "gatsby-plugin-i18n",
      options: {
        langKeyDefault: "en",
        localeJsonSourceName: "locale",
        languages: ["en", "es", "de"],
        useLangKeyLayout: false,
        prefixDefault: true,
        i18nextOptions: {
          interpolation: {
            escapeValue: false,
          },
          keySeparator: false,
          nsSeparator: false,
        },
        pages: [
          {
            matchPath: "/:lang?/*",
            getLanguageFromPath: true,
          },
        ],
      },
    },
  ],
};

There should be an issue in your gatsby-config.js. Can you post how did you config the plugin?

@michaelrevans  the name of the plugin should be resolve: "gatsby-plugin-react-i18next", because gatsby-plugin-i18n is another plugin. Otherwise, it looks good.

Thanks @leduchung, this solved my issue.


CarInfo: Toyota detail sentence exception for stock longitudinal

Only Toyota that are openpilot longitudinal technically resume from a stop automatically

⚠ This PR makes changes to CARS.md ⚠--path ~/car_info
🏅 Detail Sentence Changes

Sentence for Lexus Lexus CT Hybrid 2017-18 changed!+ openpilot upgrades your Lexus CT Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Lexus CT Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Lexus Lexus ES Hybrid 2017-18 changed!+ openpilot upgrades your Lexus ES Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Lexus ES Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Lexus Lexus NX 2018-19 changed!+ openpilot upgrades your Lexus NX with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Lexus NX with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Lexus Lexus NX Hybrid 2018-19 changed!+ openpilot upgrades your Lexus NX Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Lexus NX Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Lexus Lexus RX 2016-18 changed!+ openpilot upgrades your Lexus RX with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Lexus RX with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Lexus Lexus RX Hybrid 2016-19 changed!+ openpilot upgrades your Lexus RX Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Lexus RX Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Avalon 2019-21 changed!+ openpilot upgrades your Toyota Avalon with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Avalon with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Avalon Hybrid 2019-21 changed!+ openpilot upgrades your Toyota Avalon Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Avalon Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota C-HR 2017-21 changed!+ openpilot upgrades your Toyota C-HR with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota C-HR with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota C-HR Hybrid 2017-19 changed!+ openpilot upgrades your Toyota C-HR Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota C-HR Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Camry 2018-20 changed!+ openpilot upgrades your Toyota Camry with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Camry with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Camry Hybrid 2018-20 changed!+ openpilot upgrades your Toyota Camry Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Camry Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Highlander 2017-19 changed!+ openpilot upgrades your Toyota Highlander with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Highlander with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Highlander Hybrid 2017-19 changed!+ openpilot upgrades your Toyota Highlander Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Highlander Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Prius 2016 changed!+ openpilot upgrades your Toyota Prius with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Prius with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Prius 2017-20 changed!+ openpilot upgrades your Toyota Prius with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Prius with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Prius Prime 2017-20 changed!+ openpilot upgrades your Toyota Prius Prime with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Prius Prime with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota RAV4 2022 changed!+ openpilot upgrades your Toyota RAV4 with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota RAV4 with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota RAV4 Hybrid 2016 changed!+ openpilot upgrades your Toyota RAV4 Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota RAV4 Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota RAV4 Hybrid 2017-18 changed!+ openpilot upgrades your Toyota RAV4 Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota RAV4 Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota RAV4 Hybrid 2022 changed!+ openpilot upgrades your Toyota RAV4 Hybrid with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota RAV4 Hybrid with automated lane centering at all speeds, and adaptive cruise control.

Sentence for Toyota Toyota Sienna 2018-20 changed!+ openpilot upgrades your Toyota Sienna with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop.
- openpilot upgrades your Toyota Sienna with automated lane centering at all speeds, and adaptive cruise control.


How do I specifiy gradle version.

I don't want to use gradle v9.0.0 it has some deprecated symbols. I want to use specifically gradle:6.8.3

Run mv -f ./src/main/resources/application.properties.prod.local ./src/main/resources/application.properties
  mv -f ./src/main/resources/application.properties.prod.local ./src/main/resources/application.properties
  gradle build
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.19-7/x64

Welcome to Gradle 8.2!

Here are the highlights of this release:
 - Kotlin DSL: new reference documentation, assignment syntax by default
 - Kotlin DSL is now the default with Gradle init
 - Improved suggestions to resolve errors in console output

For more details see https://docs.gradle.org/8.2/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

FAILURE: Build failed with an exception.

* What went wrong:
'void org.gradle.api.internal.artifacts.dsl.LazyPublishArtifact.<init>(org.gradle.api.provider.Provider)'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in [29](https://github.com/git01softlines/Atelier-Back/actions/runs/5544314224/jobs/10121590317#step:5:30)s
Error: Process completed with exit code 1.

Run mv -f ./src/main/resources/application.properties.prod.local ./src/main/resources/application.properties
  mv -f ./src/main/resources/application.properties.prod.local ./src/main/resources/application.properties
  gradle build
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.19-7/x64

Welcome to Gradle 8.2!

Here are the highlights of this release:
 - Kotlin DSL: new reference documentation, assignment syntax by default
 - Kotlin DSL is now the default with Gradle init
 - Improved suggestions to resolve errors in console output

For more details see https://docs.gradle.org/8.2/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

FAILURE: Build failed with an exception.

* What went wrong:
'void org.gradle.api.internal.artifacts.dsl.LazyPublishArtifact.<init>(org.gradle.api.provider.Provider)'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in [29](https://github.com/mygit/myapp/actions/runs/5544314224/jobs/10121590317#step:5:30)s
Error: Process completed with exit code 1.

Hi, @Eboubaker 👋 Thank you for the issue! The Gradle 8.2 is installed on the GitHub-hosted runners by default, to use another version you can either install it manually or use that action.
Now I'm going to close the issue, if you have any questions or additions, feel free to ping me.


Add function to check if a DateTime is in the future

The are a fair number of DateTimes in this API where one wants to know if they are in the future or the past. This new function can be used to determine this. To check if the given datetime is in the present or the past, just negate the result.

I feel like something could be improved here, but I can't tell how.
Calling servertime.is_in_future(val) almost reads, as if it would check, if the server time, as in the timezone adjusted time at the game server is in the future, compared to the local timezone. Implementing this as a trait on DateTime is even worse though and I can't think of a better name for the function to clear up any confusions.
So I guess you already picked the best way to do this. Thanks!

Sorry for the merge & immediate revert. I forgot how exactly I handled the times in this API. When I read this initially, I assumed this was correct, but thinking about it, this might have been wrong. IIRC the DateTimes in the API should be compared to Local::now(), not servertime.current(). servertime.current() should be the local time at the server, whilst all values in the API should be the current time in your local timezone. That does not matter for servers in your timezone, but can cause issues for international servers.
I can't test if that is how it works right now, but I don't wan't to have something I am not sure about in main, sorry for the trouble. I will check later and if my memory is wrong, I will merge this again.

You are right, I've just checked https://f1.sfgame.net/. I've


[Absinthe v1.5.0-rc]: Connection default pagination args not configured

After upgrading all Absinthe dependencies to the latest v1.5 RC (and Absinthe itself on master@1495a09c, I see these errors on all Relay connections I have defined:
     Assertion with == failed
     code:  assert response["errors"] == nil
     left:  [%{"message" => "Unknown argument \"first\" on field \"batches\" of type \"RootQueryType\"."}]
     right: nil
     stacktrace:
       test/graphql/batch_test.exs:357: MyApp.GraphQL.BatchTest.assert_returned_batches/3
       test/graphql/batch_test.exs:370: (test)

The connection definition is pretty simple for this connection:
connection node_type: :batch do
    field :nodes, non_null(list_of(non_null(:batch))) do
      resolve(&MyApp.GraphQL.Helpers.resolve_conn_edge_nodes/2)
    end

    # edge is required since we're customizing this connection, even if empty:
    edge do
    end
  end

Glancing at the schema output confirms that none of these pagination args (first, last, etc) are defined anymore.

Hey @bgentry can you confirm that you're on the latest 1.5 Absinthe.Relay as well? What is the output of mix deps|grep absinthe?

can you confirm that you're on the latest 1.5 Absinthe.Relay as well?

Yes, I believe so @benwilson512 (unless something got released tonight):
➜  mix deps|grep absinthe
* absinthe 1.5.0-rc.2 (https://github.com/absinthe-graphql/absinthe.git) (mix)
* absinthe_relay 1.5.0-rc.0 (Hex package) (mix)
  locked at 1.5.0-rc.0 (absinthe_relay) e0db315e
* absinthe_sorting_codec 1.0.1 (Hex package) (mix)
  locked at 1.0.1 (absinthe_sorting_codec) d865e516
* absinthe_plug 1.5.0-rc.1 (Hex package) (mix)
  locked at 1.5.0-rc.1 (absinthe_plug) c06e0674
* absinthe_phoenix 1.5.0-rc.0 (Hex package) (mix)
  locked at 1.5.0-rc.0 (absinthe_phoenix) 9a76cda0

@benwilson512 please lmk if this turns out to be difficult to reproduce in any way, I'm happy to help wherever I can! You can ping me on Elixir Slack too.

@bgentry if you have time to create a failing test case PR on Absinthe.Relay you'd definitely save me time. Otherwise I'll try to get a look at it this weekend.

I have added a failing test case for this issue in #156. I believe it's because we're not using the full functionality of absinthe_relay and are instead using only the Connections implementation. This worked prior to the v1.5 series (on v1.4) but is broken in these RCs.

Solution: Include this line in your root schema:
@pipeline_modifier Absinthe.Relay.Schema

@benwilson512 I got time to try this out today and I can confirm that it works! Thanks for sorting it out and correcting the documentation (and my test case) :v:


Mobile: Clicking in the navigation should dismiss it

Describe the bug
On mobile devices, we have a mobile navigation menu. Clicking within it navigates to a new page, but the navigation itself does not dismiss. It should go away once a new page is navigated to.
To Reproduce
Steps to reproduce the behavior:

Open Awesome Learning on mobile
Click on the navigation
Click on a page

Expected behavior
Navigation should disappear

Hello! is this the navigation menu you're referring to?

If so, I'm unable to reproduce this issue on mobile.

That's the one!

Hey @Cooperbuilt , I second @Eshno comment. I am not able to reproduce this. Could you confirm if this is still an issue?

Not able to repro either - closing. Thanks y'all!


Correction in passed file name to checkPageExistsUsingTitle, function…

Description (required)
Fixes file override bug mentioned in #3026
What changes did you make and why?
Correction in passed file name to checkPageExistsUsingTitle, function expects file name prefixed with File:
Tests performed (required)
Tested betaDebug on MotoX-4 with API level 27. Duplicate file names are suffixed with numbers

Codecov Report

Merging #3194 into backend-overhaul will not change coverage.
The diff coverage is 0%.

@@               Coverage Diff                @@
##           backend-overhaul   #3194   +/-   ##
================================================
  Coverage              5.98%   5.98%
================================================
  Files                   260     260
  Lines                 11150   11150
  Branches                850     850
================================================
  Hits                    667     667
  Misses                10427   10427
  Partials                 56      56

Impacted Files
Coverage Δ

...java/fr/free/nrw/commons/upload/UploadService.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d0d5e...7d81cd8. Read the comment docs.

Now that this PR is merged, I will go ahead and merge backend-overhaul to master.


Improve #6041, Migrate to CircleCI 2.0

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
We are going to migrate to CircleCI 2.0 with #6041, but with a simpler description, we can make the build run time shorter.
When caching node_modules, the build is now finished in 1 minute 20 seconds.
https://circleci.com/workflow-run/7ea0d4e0-48ca-449d-9a52-9880dbbd93a5
In the case of 2.0, we have to describe all of the procedures procedurally, but on the contrary, I think that approach is easy to understand.
Please check this PR 😃 @yyx990803 @posva

Very nice! I noticed that our CI actually has a 4x parallelism limit, so I merged some of the jobs together to minimize queueing.

@yyx990903 Thank you for balancing the test! It got faster!


Errors when running the demo app

I get the following errors when i run the demo app.

This is an issue with DMC 0.14, check the migration guide, you need to use react 18.

thank you!, yes it was my mistake for not reading the migration guide.
Do you happen to know what might be causing the following errors?
they don't hinder any functionality of my app but they only appeared when i migrated from dmc 0.12 to 0.14 and replaced the transfeList with the transferlist_aio component
any help is appreciated.


Increased API loading performance

Following on from #292 I have applied json_fastapi serializers across the entire application.
Additionally, I discovered that a lot of time is spent loading last_modified_user_id from the versions association using paper trail.  If we use a subquery to load the last version (according to created_at DESC) when we load the records then it only requires a single query to load the lot. See the VersionedRecord model for details.
In my experience this has made the application respond to API requests much faster!

Hi @parndt,
Unfortunately the last_modified_user_id in the PUT response appears to be the outdated id and not the updated id. Here is how that "meta" information looks on the frontend - a reload is required to get the updated id:
Before update

Meta
Updated by: Previous User
Last updated: 21/12/2017, 06:07
Created: 21/12/2017

After update:

Meta
Updated by: Previous User
Last updated: 19/04/2018, 14:11
Created: 21/12/2017

After Reload:

Meta
Updated by: Current User
Last updated: 19/04/2018, 14:11
Created: 21/12/2017


tv community rules

spacing
allow to use multiple nodes in node filter to ease
add line lenght fixer

Surpassed by https://github.com/rectorphp/getrector-com/pull/2556


Translations for subdivision names

Is there a way to determine what each name listed in names, for subdivisions, belongs to which language?
It was simple to figure this out for the countries, since each entry has a translations table.

This should be thought about as well with #186

Subdivision translations has been implemented for some time now. Closing.


Enhancing designs of existing projects

Hi
@Subhradeep10 I wish to enhance the styling of existing projects whose UI aren't looking very good..like the button press counter,Lorem generator and adding social media icons on product laundhing website.
Please assign this task to me.

@RishabhJain0721 assign to you

@Subhradeep10 I have made a PR. Please review it.


Wip/6.0 member of predicate impl

thanks for explanation. seems a false alarm.
On Thu., Aug. 6, 2020, 11:37 Steve Ebersole<EMAIL_ADDRESS>wrote:

@sebersole commented on this pull request.
In
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/QueryTest.java
https://github.com/hibernate/hibernate-orm/pull/3492#discussion_r466502663
:

@Test

@TestForIssue(jiraKey = "HHH-5209")
public void testMemberOfSyntax(SessionFactoryScope scope) {
// performs syntax checking of the MEMBER OF predicate against a basic collection
scope.inSession(

		session ->

				session.createQuery( "from EntityWithAnElementCollection e where 'abc' member of e.someStrings" )

						.list()

		session -> {

			List<EntityWithAnElementCollection> list = session.createQuery(

					"from EntityWithAnElementCollection e where 'abc' member of e.someStrings" )

					.list();

			assertThat( list.size(), is( 1 ) );

		}
);

You mean that someStrings for a particular e has no elements
(e.getSomeStrings().isEmpty() == true)? That's still ok. The sub-query we
generate would simply return no rows. But the in-predicate sub-query
expression itself is not null. Meaning, in SQL, this is perfectly valid
whether the sub-query returns no rows or more than zero:
select e
from entity_with_elem_coll e
where 'abc' in (
select ...
)
where i
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-orm/pull/3492#discussion_r466502663,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6UYAVB6SNKYKBFKCV5SJDR7LE4NANCNFSM4PWU4VSQ
.

You're welcome :)
And thank you for your continued help with many of these pull requests
On Thu, Aug 6, 2020 at 10:42 AM Nathan Xu<EMAIL_ADDRESS>wrote:

thanks for explanation. seems a false alarm.
On Thu., Aug. 6, 2020, 11:37 Steve Ebersole<EMAIL_ADDRESS>wrote:

@sebersole commented on this pull request.
In

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/QueryTest.java

<
https://github.com/hibernate/hibernate-orm/pull/3492#discussion_r466502663
:

@Test
@TestForIssue(jiraKey = "HHH-5209")
public void testMemberOfSyntax(SessionFactoryScope scope) {
// performs syntax checking of the MEMBER OF predicate against a basic
collection
scope.inSession(

session ->
session.createQuery( "from EntityWithAnElementCollection e where 'abc'
member of e.someStrings" )
.list()

session -> {
List list = session.createQuery(
"from EntityWithAnElementCollection e where 'abc' member of
e.someStrings" )
.list();
assertThat( list.size(), is( 1 ) );
}
);

You mean that someStrings for a particular e has no elements
(e.getSomeStrings().isEmpty() == true)? That's still ok. The sub-query we
generate would simply return no rows. But the in-predicate sub-query
expression itself is not null. Meaning, in SQL, this is perfectly valid
whether the sub-query returns no rows or more than zero:
select e
from entity_with_elem_coll e
where 'abc' in (
select ...
)
where i
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/hibernate/hibernate-orm/pull/3492#discussion_r466502663
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AB6UYAVB6SNKYKBFKCV5SJDR7LE4NANCNFSM4PWU4VSQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-orm/pull/3492#issuecomment-670008180,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABZIE7P3H2ESZMFKL6BAP3R7LFO3ANCNFSM4PWU4VSQ
.

Applied upstream.
@NathanQingyangXu @sebersole thanks for the review


there is no response when i click the Run Tests button after completing challenge

Challenge Nest an Anchor Element within a Paragraph has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.124 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

cat photos

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

view more cat photos

If you scroll down on the left section of the page below the Run Tests button you can see the results of the tests for your code. In this instance, the test Your p element should have the text "View more " (with a space after it). fails because you have a capitalization error.
For help with writing code, please consult the Help chat room. Issues are for reporting bugs with the challenges or website.
Happy coding!

thanks for help :)
i have found the error it was on the coding i was placing another anchor tag while i supposed to use the existing one
thank you  :+1:

@mwasif41@BKinahan thanks for the help diagnosing the issue! Closing this issue as it looks like the issue has been resolved. Happy coding!


can't download items from front page

I've been putting off reporting this, but a while ago I tried to download:
S&M Lawn Care (stuck at 14%)
It's a Disaster (stuck at 0%)
Cinema Six (stuck at 18%)
When I restart and do pause/resume, it seems to start but then nothing happens.  This has been the same result over the last couple of version (3 weeks or so)

Eventually I was able to get "It's a Disaster" to download...


TabLeave and TabEnter are triggered unnecessary number of times

Steps to reproduce

run

vim -u NONE --clean \
     --cmd 'autocmd! TabLeave * echom "Tab " . tabpagenr() . " left"' \
     --cmd 'autocmd! TabEnter * echom "Tab " . tabpagenr() . " entered"' \
     -p f1 f2 f3

inside Vim run messages clear and tab drop f1
see

Tab 1 left
Tab 2 entered
Tab 2 left
Tab 3 entered
Tab 3 left
Tab 1 entered
Press ENTER or type command to continue

It's almost a copy of https://github.com/neovim/neovim/issues/14567
Expected behaviour
TabLeave and TabEnter are not triggered redundantly.
Version of Vim
9.0.1365
Environment
OS: Debian Sid
Terminal: Kitty + tmux
TERM: tmux-256color
shell: bash
Logs and stack traces
No response

Steps to reproduce

run

- vim -u NONE --clean \
     --cmd 'autocmd! TabLeave * echom "Tab " . tabpagenr() . " left"' \
     --cmd 'autocmd! TabEnter * echom "Tab " . tabpagenr() . " entered"' \
     -p f1 f2 f3

inside Vim run messages clear and tab drop f1
see

Tab 1 left
Tab 2 entered
Tab 2 left
Tab 3 entered
Tab 3 left
Tab 1 entered
Press ENTER or type command to continue

It's almost a copy of https://github.com/neovim/neovim/issues/14567
Expected behaviour
TabLeave and TabEnter are not triggered redundantly.

"redundantly" is not the right word.  What happens is that Vim goes over
all the windows and might close some, those that are not in the updated
argument list.
With the specific example no windows are actually closed, but Vim still
goes over all the tab pages and all windows inside each tab.  No window
actually gets closed, thus triggering the autocommand events most likely
is not useful.  However, if we would leave out the autocommands in this
specific situation, and still trigger them for the "tab all" command, it
gets inconsistent.
Unless the current behavior causes a problem, other than some overhead,
I would rather leave it alone.  Making it more complicated by skipping
some autocommand events in specific situations is not an improvement.
--
LAUNCELOT: Isn't there a St. Aaaaarrrrrrggghhh's in Cornwall?
ARTHUR:    No, that's Saint Ives.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

@brammool thanks for response. I can convert the above example to something more practical:
- run
```sh
vim -u NONE --clean \
     --cmd 'autocmd! TabLeave * echom "Tab " . tabpagenr() . " left"' \
     --cmd 'autocmd! TabEnter * echom "Tab " . tabpagenr() . " entered"' \
     -p f1 f2 f3

inside Vim run messages clear and tab drop f3
see messages

Tab 1 left
Tab 2 entered
Tab 2 left
Tab 3 entered

run g<TAB>. Note that the current tab is f2 - not expected f1.

In practice, we can imagine that f1 contains a reference to a definition located in f3.
While it's not fixed. I use some (probably buggy) workarounds to simulate tab drop without the effect described above.

@brammool thanks for the workaround.
I was hoping 8281a16 would solve the practical part but it fails with another simple test. In the above example please run tab drop f4 and type g<Tab>. For me, the last used tab contains f3, not expected f1.


export anchored tag and digest regular expression

Exported two regular expressions, anchoredTagRegexp and anchoredDigestRegexp.
Sometimes people want to validate if a string is a tag or digest, then they can refer to this directly.

can you give more details about why it needs to public these variables?

I didn't mean it needs to, I mean export these variables means a lot to other projects that have a dependency on distribution project.

Closing as reference has been moved to a dedicated repo https://github.com/distribution/reference


Move name, setName to ActiveModal so we can persist

Paired with @travis on this, merging to staging for QA


Bump tokio-tungstenite version to 0.15

Build and tests seem to be passing with no required change.

Released as 0.4.0 :)
Thanks again!

Oh I didn't know that 0.15.0 and 0.15 were equivalent, thanks for the info ! And thanks for the release :)

Oh I didn't know that 0.15.0 and 0.15 were equivalent, thanks for the info ! And thanks for the release :)

Maybe there are some subtle differences in which pre-release versions are accepted, but I think they are really fully equivalent :)
I tend to specify the patch version too, because it ensures no older patch version is used, which I would not have tested with. It may have included an important bug fix :)
More importantly, below version 1.0.0, the patch version is more or less equivalent to the minor version, which means that backwards compatible API changes (usually additions) are allowed. But then, if cargo chooses an older version it might break compilation, so you really need to specify a minimum 0.x.y. Of course, with 0.x.0 it doesn't matter, but I do like to be explicit :)


perf: Use transactions for better latency in bubblebench/sharedtree

Changes:

Added optional support for transactions to bubblebench/common
Changed bubblebench/sharedtree to use transactions

Switching to use the Shared Tree transactional API reduced the variance in task-level latency, significantly reduced the longest task's duration, and shrank the time attributed to processDeltas to ~19% of what it was before.

@microsoft-github-policy-service agree company="Microsoft"


CSS rules gets purged by PurgeCSS when using whitelist pattern /^flatpickr-/

When using PurgeCSS and whitelisting /^flatpickr-/ not all rules from flatpickr.css (see css content here: https://cdn.jsdelivr.net/npm/flatpickr/dist/flatpickr.css) are preserved. Some classes are not prefixed with .flatpickr- or are not children of a class starting with .flatpickr-.
Rules removed when running PurgeCSS with whitelist pattern /^flatpickr-/ are:

Every rule starting with class .numInputWrapper
span.flatpickr-weekday
Every rule starting with class .dayContainer
.rangeMode .flatpickr-day

I would assume just prefixing these with .flatpickr- (ex: .flatpickr-numInputWrapper) would work, or namesapce them under .flatpickr-wrapper or .flatpickr-calendar maybe (ex: .flatpickr-calendar .numInputWrapper).
I have tried PurgeCSS ignore comments around the @import of flatpickr.css, but they don't seem to work with @import statements, as can be read here: https://github.com/FullHuman/purgecss/issues/170

Open the flatpick.css file and start the beginning of the content with:
/* purgecss start ignore */
Go to the end of the file and add:
/* purgecss end ignore */
npm run production and you should be good to go.

Open the flatpick.css file and start the beginning of the content with:
/* purgecss start ignore */
Go to the end of the file and add:
/* purgecss end ignore */
'npm run production' and you should be good to go.

Yes, that is a working workaround, but then I would need to copy the flatpickr.css and have it locally to be able to modify it and keep the changes when updating flatpickr. It's a vendor file, so I would like to keep it imported from node_modules to be able to update it without having to copy the newly updated files and modify them again.
I believe good practise would be to namespace/prefix flatpickr css, since it would solve this problem, and it won't affect the styles or functionality of it. Almost everything is already namespaced/prefixed with .flatpickr, except the rules I mention above, so why not just add namespace/prefix to these rules as well?

I solved this by creating a local CSS file and importing the flatpickr CSS with the purgeCSS comments thusly:
/* purgecss start ignore */ @import '~flatpickr/dist/flatpickr.css'; /* purgecss end ignore */

I solved this by creating a local CSS file and importing the flatpickr CSS with the purgeCSS comments thusly:
/* purgecss start ignore */
@import '~flatpickr/dist/flatpickr.css';
/* purgecss end ignore */

If you read my original post, that was my first option to try:

I have tried PurgeCSS ignore comments around the @import of flatpickr.css, but they don't seem to work with @import statements, as can be read here: https://github.com/FullHuman/purgecss/issues/170

Sadly it doesn't work for me.

@petrusolofsson you're right, that doesn't work.
In the end I ugly hacked it by copying the flatpickr.css locally as a SCSS and adding the /*! purgecss start ignore */ tags either side. Adding the exclamation mark to prevent the comments being stripped was also required for me.

In the end I ugly hacked it by copying the flatpickr.css locally as a SCSS and adding the /*! purgecss start ignore */ tags either side. Adding the exclamation mark to prevent the comments being stripped was also required for me.

Yes, and this is the whole point why I opened this issue. There are a variety of ugly hacks/workarounds to solve this, but they all come with a cost in complexity and maintainability.
Prefixing or namespacing the few remaining CSS classes mentioned above solves the problem, and I have not found any issue with changing the classnames, so it should be fine making that change. If there's no special reason for why these few classes are not prefixed/namespaced, I don't see any reason for not making this change.

@chmln @viorelsfetea Do you think these changes could be made? :)


Giving some love...

Hello! I've featured your repository in the Delphi Game Development Facebook group. If you haven't joined yet, consider becoming a part of the community.
https://www.facebook.com/groups/322814267886893/posts/2650837968417833/

Thanks for the share and support.
But unfortunately, I don't use Facebook.
I'll keep adding more APIs for the ImGui Class and other demos to help people using it.

Thanks for the share and support. But unfortunately, I don't use Facebook.

Ahh ok.

I'll keep adding more APIs for the ImGui Class and other demos to help people using it.
Cool, I keep checking in and keep the group updated.

How are you handling high DPI and moving between monitors with different DPIs?

DPI support is on my TODO list.
There's a starting point of DPI support on https://github.com/ocornut/imgui/blob/docking/backends/imgui_impl_win32.cpp
I'm still paying with some Ideas for ideal DPI support on multiOS.
Feel free to reach me on Discord. I'm very active there.
My Discord ID: Coldzer0

This is what I am currently doing:

when the dpi changes, I calc new dpi and scale
I shutdown/restart cimgui
load a custom font size * scale (cache this font base on dpi and just reuse on the same dpi)
scale the styles by the new scale (ImGuiStyle_ScaleAllSizes). Doing this after a restart will resize all the windows to the appropriate size.

As I move the window across monitors with different DPIs, I get a scaled imgui without the blurry. Not ideal but gives the best results as is and way better than calling IO.GlobalFontScale, which is simple, but can look terrible.

This is what I am currently doing:

when the dpi changes, I calc new dpi and scale
I shutdown/restart cimgui
load a custom font size * scale (cache this font base on dpi and just reuse on the same dpi)
scale the styles by the new scale (ImGuiStyle_ScaleAllSizes). Doing this after a restart will resize all the windows to the appropriate size.

As I move the window across monitors with different DPIs, I get a scaled imgui without the blurry. Not ideal but gives the best results as is and way better than calling IO.GlobalFontScale, which is simple, but can look terrible.

Nice approach for a single window, but the problem with this one is if you are using Multi-viewports, you have to close all opened windows and reinit in the same state.
I'll keep this repo updated whenever I get a working solution.


Property Control files not found

Category

[ ] Enhancement
[ X] Bug
[ ] Question

Version
Please specify what version of the library you are using: [1.11.0 ]
Expected / Desired Behavior / Question
Well i'd expect it to work.
Observed Behavior
Error - [webpack] 'dist':
<EMAIL_ADDRESS>Module not found: Error: Can't resolve 'PropertyControlStrings' in 'C:\Dev\WebParts\SharePoint-WebPart-App-Showcase\node_modules\@pnp\spfx-property-controls\lib\propertyFields\colorPicker'
Parsed request is a module
  using description file<EMAIL_ADDRESS>(relative path: ./lib/propertyFields/colorPicker)
    Field 'browser' doesn't contain a valid alias configuration
  after using description file<EMAIL_ADDRESS>(relative path: ./lib/propertyFields/colorPicker)
    resolve as module
      C:\Dev\WebParts\SharePoint-WebPart-App-Showcase\node_modules\@pnp\spfx-property-controls\lib\propertyFields\colorPicker\node_modules doesn't exist or is not a directory

Steps to Reproduce
Install property controls, follow the steps here -> https://sharepoint.github.io/sp-dev-fx-property-controls/controls/PropertyFieldColorPicker/
Thanks!
EDIT: Added full pasteibn code, perhaps it helps.
https://pastebin.com/gqYs9Nnt

Category

[ ]  Enhancement
[ X] Bug
[ ]  Question

Version
Please specify what version of the library you are using: [1.11.0 ]
Expected / Desired Behavior / Question
Well i'd expect it to work.
Observed Behavior
Error - [webpack] 'dist':
<EMAIL_ADDRESS>Module not found: Error: Can't resolve 'PropertyControlStrings' in 'C:\Dev\WebParts\SharePoint-WebPart-App-Showcase\node_modules\@pnp\spfx-property-controls\lib\propertyFields\colorPicker'
Parsed request is a module
  using description file<EMAIL_ADDRESS>(relative path: ./lib/propertyFields/colorPicker)
    Field 'browser' doesn't contain a valid alias configuration
  after using description file<EMAIL_ADDRESS>(relative path: ./lib/propertyFields/colorPicker)
    resolve as module
      C:\Dev\WebParts\SharePoint-WebPart-App-Showcase\node_modules\@pnp\spfx-property-controls\lib\propertyFields\colorPicker\node_modules doesn't exist or is not a directory

Steps to Reproduce
Install property controls, follow the steps here -> https://sharepoint.github.io/sp-dev-fx-property-controls/controls/PropertyFieldColorPicker/
Thanks!
EDIT: Added full pasteibn code, perhaps it helps.
https://pastebin.com/gqYs9Nnt


Upgrade GDEF checks from WARN to FAIL

We've just had to rollback Raleway because the backtick glyph was classified as a mark when it should've been a base glyph.
The check correctly identified it was incorrect but the output was only a warn. Since this issue has now happened twice and in both instances caused a rollback, this check should be upgraded to a FAIL.

thanks, @m4rc1e

@felipesanches we might not want to do this, please hold :)
Related https://github.com/googlefonts/diffbrowsers/issues/23

ok


Repo sync for protected CLA branch

The pull request is created from main637822731793891227 to main to fix git push error for protected CLA branch

@opbld15 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Javascript Example 120 conversion does not work with EE Repo

Environment Information
Please run the following code on your computer and share the output with us so that we can better debug your issue:
import geemap
geemap.Report()

Mon Feb 20 21:06:06 2023 UTC
OS	Linux	CPU(s)	2	Machine	x86_64
Architecture	64bit	RAM	12.7 GiB	Environment	IPython
Python 3.8.10 (default, Nov 14 2022, 12:59:47) [GCC 9.4.0]
geemap	0.20.0	ee	0.1.341	ipyleaflet	0.17.2
folium	0.12.1.post1	jupyterlab	Module not found	notebook	6.3.0
ipyevents	2.0.1
Description
I was trying to run this example: https://geemap.org/notebooks/120_javascript/ especially the EE repo example at the end.
It does not work and give me error. I could not setup oeel in my m1 mac to help fix the bug. I am interested in testing out nested require in js file, for example a js has require which has another require in it.
What I Did
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
[<ipython-input-21-22010224fb00>](https://localhost:8080/#) in <module>
----> 1 lib = geemap.requireJS('users/gena/packages:grid')

1 frames
/usr/local/lib/python3.8/dist-packages/geemap/common.py in change_require(lib_path)
  13019
  13020     if not os.path.exists(lib_path):
> 13021         raise ValueError(f"{lib_path} does not exist.")
  13022
  13023     output = []

ValueError: packages/grid does not exist.

You need to set up Git properly to clone Git repos from Earth Engine. If you have never cloned a Git Repo from Earth Engine, the notebook example will not work. This blog might be helpful.

I was trying to do it using EE repo and it appears to be cloning the EE git repo here. Anyways, I hosted the EE git repo in Github and provided that path.
And thanks for the warning on the nested JS files in oeel.

Please provide source code that can reproduce the issue.


Fixed #156 and general array behavior problems. See #1369.

In the last comment of #1369, I mentioned this.
It broke some of the arrays so I made this pull request which shouldn't do so badly for #156.

Great, thanks @michaelcheers, we will review the pull request.

@michaelcheers,
That is a good idea to use System.Array.getItem (please note the current Bridge code uses System.Array instead of Bridge.Array) in EmitSingleDimArrayIndexer method (but a trade-off is checking index vs performance). However, there are two problems with the fix:

it misses closing parentthesis as it added this.Write("System.Array.getItem("); but did not added extra this.WriteCloseParentheses();
arr[0] = "x"; ->  System.Array.getItem(arr,  0) = "x"; causing error JS Invalid left-hand side in assignment

@LeonidVeriga, I think you should make an option to use javascript indexer (s) instead of C# ones.

@LeonidVeriga, I did add a close parentheses. I'll change it to System.Array and setItem (for setItem only if I can figure out how to).

@michaelcheers, regarding closing parentheses, yes, there is a call added  this.WriteCloseParentheses(); but it is in a conditional if however the opening one  this.Write("Bridge.Array.getItem("); added unconditionally.

Thanks @michaelcheers. We will review the changes and preliminary it looks good.
1.14 release scope is defined already; we will have an internal discussion on 1.14 release date early next week. If we have time we include this pull request into 1.14.

@LeonidVeriga, I couldn't figure how to fix the setter problem.

It would be nice when config is set to  "overflowMode": "Javascript", then array behaviour should be as in javascritp, and not like in c#, this will have better performance for javascript code since no getItem() that checks index range will be required

Me too

The change is going to be postponed.


closeTab warning (When more then one pane is open)

Summary of the Pull Request
Presents a dialogue when more then one pane is open.

References
Connected to #5301

PR Checklist

[X] Closes #5301
[X] CLA signed. If not, go over here and sign the CLA
[X] No docs!
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
I can't seem to figure out the if statement (_CloseFocusTabPane) so if anyone can help, that would be great!

Again, I can't figure out why there are unrelated commits.

Alright, a few things are going on here:

[ ] you accidentally copied the method header for _GetActiveControl() and replaced the one for _CloseFocusedTabPane()
[ ] You haven't exposed Tab::_GetLeafPaneCount() as public yet
[ ] Your _CloseTabWarningPrimaryButtonOnClick() calls _CloseFocusedTab() instead of _CloseFocusedTabPane()

If you fix those three things, I think you should be in a position where this works (functionally speaking). There's still some more code-health related things that would be nice to fix but they'll be found during a code review. Let's just focus on getting this working first 😊
Idk if you'll have to expose _GetLeafPaneCount() in the idl file. But if you start noticing that you've exposed it as public in Tab and you still can't call it from TerminalPage, that might be a problem.

Okay thanks. I’ll look into it.

From: Carlos Zamora<EMAIL_ADDRESS>Sent: Monday, May 18, 2020 4:23:01 PM
To: microsoft/terminal<EMAIL_ADDRESS>Cc: Eric Tian<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/terminal] closeTab warning (When more then one pane is open) (#5874)
Alright, a few things are going on here:

you accidentally copied the method header for _GetActiveControl() and replaced the one for _CloseFocusedTabPane()
You haven't exposed Tab::_GetLeafPaneCount() as public yet
Your _CloseTabWarningPrimaryButtonOnClick() calls _CloseFocusedTab() instead of _CloseFocusedTabPane()

If you fix those three things, I think you should be in a position where this works (functionally speaking). There's still some more code-health related things that would be nice to fix but they'll be found during a code review. Let's just focus on getting this working first 😊
Idk if you'll have to expose _GetLeafPaneCount() in the idl file. But if you start noticing that you've exposed it as public in Tab and you still can't call it from TerminalPage, that might be a problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/pull/5874#issuecomment-630485466, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RRRJ5JZ5ACPKOUFZSLRSG7NLANCNFSM4M7MQIRQ.

Hello. I'm sorry for bugging you again but *index is coming up with error, Operand of "*" must be a pointer.

Alright, so it all works, but, I need to figure out the code for the close tab button on click. If anyone can help that would be great! Thx!

Sure! The click on the Close button is handled in TerminalPage::_OnTabCloseRequested. That function is called when the user wants to close a tab with the [x].

Alright. Thanks.
From: Dustin L<EMAIL_ADDRESS>Sent: May 19, 2020 20:31
To<EMAIL_ADDRESS>Cc: Eric<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [microsoft/terminal] closeTab warning (When more then one pane is open) (#5874)
Sure! The click on the Close button is handled in TerminalPage::_OnTabCloseRequested. That function is called when the user wants to close a tab with the [x].
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/pull/5874#issuecomment-631214502, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RTWTP346AQHKAJIOWDRSNFIVANCNFSM4M7MQIRQ.

Sorry all the commits are a mess.

That's totally fine :)

Can anyone review this? @zadjii-msft @carlos-zamora? Thx!

Hello?

2. I think before this merges I want to have a resolution of how a setting to disable this would work. I've discussed this a bit more in #6549 (comment), but not really taken to any conclusions. I don't think that you need to be the person to implement all the appropriate settings, but I want to make sure that we've got our eye on that before we merge this.

Definitely

@zadjii-msft @carlos-zamora Okay, this is ready for review. Thanks

@carlos-zamora @zadjii-msft Alright. I think we're all set.

Since the commits are a mess and I don't like it, and because it's inactive, I'll close this pr and make a new one later.

This has now moved to #7077


Refactor model manager: model installer component

What type of PR is this? (check all applicable)

[X] Refactor
[X] Feature
[ ] Bug Fix
[ ] Optimization
[X] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[X] Yes
[ ] No, because:

Have you updated all relevant documentation?

[X] Yes
[ ] No

Description
This is the next phase of the model manager refactor, as discussed with @psychedelicious and @RyanJDick. This implements the model installer, which is responsible for managing model weights on disk and installing new models.
Currently only installation of local files and directories is supported. Remote installation will be implemented after the queued download manager is reviewed and approved.
Please see the documentation located at docs/contributing/MODEL_MANAGER.md for an explanation of how this module works.
Things that have changed relative to the current implementation.

Model importation runs in a background thread. Access to the installation status is through a ModelInstallJob object returned by the import_model() call. In addition, the installation process generates a series of model_install events on the event bus.
model_install_progress events are documented, but not currently issued. These will be issued when background downloading is  implemented.
The model installer currently runs in parallel to the current model manager. The frontend continues to use configs/models.yaml and ignores what is in the model_config table of invokeai.db.
When the installer is initialized at app startup time, it synchronizes its database to the contents of the InvokeAI models directory. The current model manager does this as well, so you will see two log messages indicating that this directory is being scanned.

Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings
You can test using the FastAPI swagger pages at http://localhost:9090/docs. Use the calls listed under model_manager_v2. Be aware that only installation of local models (indicated by their file or directory path) are currently supported.
Added/updated tests?

[X] Yes -- see tests/app/services/model_install/test_model_install.py
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Can you remind me why tests/aa_nodes is named that way? I seem to remember seeing a discussion about this in the past, but can't seem to find it.
Without recalling the details, having test ordering requirements seems like a symptom of a pretty major design flaw that I'm hesitant to just work around.

Can you remind me why tests/aa_nodes is named that way? I seem to remember seeing a discussion about this in the past, but can't seem to find it.

Related to the construction of the union of invocations - all invocation models must init* before the Graph, which uses a union of them in its field definitions. If this happened in the wrong order, Graph won't know about invocations that were init'd afterwards, and when those are used in a graph, a ValidationError is raised
In this case, pytest crawls the test dir and often imports Graph before some/all invocations, causing the tests to fail w/ ValidationErrors
*by "init", I mean, the python files are executed and classes created in memory. I'm not sure what the right term is for this process.

Can you remind me why tests/aa_nodes is named that way? I seem to remember seeing a discussion about this in the past, but can't seem to find it.
Without recalling the details, having test ordering requirements seems like a symptom of a pretty major design flaw that I'm hesitant to just work around.

@psychedelicious explains the problem here: https://discord.com/channels/1020123559063990373/1156089584808120382/1156802853323673620
It isn't specific to the model manager. It is an issue with pytest fixtures and the relative order in which BaseInvocationClass, BaseInvocationOutput and Graph are loaded. The current PR introduces a test that loads EventServiceBase, and this in turn loads other modules that eventually bring in BaseInvocationOutput.
I keep tripping over this problem, and it does feel like a design problem -- just not one that I feel qualified addressing.

Thanks for the explanations about aa_nodes. I'm going to resist the urge to dig into this now and add it to my list of interesting tech debt problems to tackle at some point 😅

Thanks for the explanations about aa_nodes. I'm going to resist the urge to dig into this now and add it to my list of interesting tech debt problems to tackle at some point 😅

It definitely needs to be addressed at some point.

@RyanJDick Indeed, the service will never be garbage collected. I've changed this method to be called stop() and have documented that the method must be called prior to deleting the installer service.
I don't  think we'll actually ever want to stop the installer and this functionality could be removed entirely. However, there is a similar pattern in the download queue implementation and here you could argue either way. There are two design patterns for how the installer and download queue interact:
Pattern #1 - A single download queue for the entire application
In this pattern there is a single multithreaded download queue that all download requests go into. When the installer is called to install a model, it:

The install thread looks up the metadata for the model to determine what files need to be downloaded (this generally applies to HF diffusers models)
The install thread puts the URLs for these models into the global download queue and waits for completion. It does this by waiting on a threading.Event, that is triggered when all the pending URLs are downloaded, using a download queue callback to keep track of the completed download jobs.
The install thread now completes the install and model registration operation, or reports an error  back to the user.

Pattern #2 - One download queue for each install operation
In contrast to #1, there is no global download queue. Instead, the installer creates queues as needed and then deletes them.

The install thread looks up the metadata for the model to determine what files need to be downloaded (this generally applies to HF diffusers models)
The install thread creates a new download queue and adds the URLs for each of the file(s) needed.
The install thread calls queue.join() in order to wait for each download to complete or error.
The install thread then completes the registration operation.

The advantages of #1 are that the global download queue limits the total number of simultaneous downloads, and enables a front end display of all download activity. The disadvantage is that it will be trickier to program and catch all edge conditions.
The advantages of #2 is simplicity. However, it won't allow the files from distinct models to be downloaded simultaneously. Also there is no one place to get a list of all downloads that are occurring.
I was planning to do #1. What are your thoughts?

Can someone explain what causes the installation to take so much time? I sometimes need to wait for minutes until a file is getting installed. It feels like my file is copied to another location, but it is just an in-place installation, from an existing folder. Probably there is some kinde of auto configuration happening? I wish, there would be some more information about the process during the installation :)

Can someone explain what causes the installation to take so much time? I sometimes need to wait for minutes until a file is getting installed. It feels like my file is copied to another location, but it is just an in-place installation, from an existing folder. Probably there is some kind of auto configuration happening? I wish, there would be some more information about the process during the installation :)

It is being hashed- this is typically reported in the terminal


[BUG] Radzen Pager/Paging is not showing

Forum reference
https://forum.radzen.com/t/radzen-pager-paging-not-showing/9533
Bug / Issue

Radzen Pager is unable to show.
Radzen DataList unable to show pager with AllowPaging="true"

To Reproduce
Steps to reproduce the behavior:

Radzen Pager

<RadzenPager Count="2" PageSize="10" PageNumbersCount="3" PageChanged="@PageChanged" />

Radzen DataList

<RadzenDataList WrapItems="true" AllowPaging="true" Data="@games" TItem="Models.Game.GameDto">
    <Template Context="game">
        <RadzenCard Style="width:300px;">

                @game.Name

        </RadzenCard>
    </Template>
</RadzenDataList>

Expected behavior
Pager component and Pager under Data List is able to be shown.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 3.13.2 (Latest)
Application: Blazor Server App (.Net 5)

Additional context
Noticed that rz-paginator was not rendered in HTML.

Question

Is it a bug or due to missing any configuration?
Is it supported in the free version?
Do the Pager component works independently?
[This means I can use my own table/list and plugin with the Pager component, with the PageChange event to fire the filtering & paging logic to update my table/list. Without the needs of Radzen DataList.]

Please do not post questions as github issues.


Fix .NET display strings

I've changed some of the strings to match the official product names.
@MichaelSimons @richlander:
Do we want to change the package ids? I understand that this is a breaking change but I guess now is the time to do that if we aren't happy with them. These are the current ones:

Id
Name

Microsoft.dotnet
.NET Core

Microsoft.dotNetFramework
.NET Framework

Microsoft Reviewers: Open in CodeFlow

LGTM

@terrajobst, In order to get this PR green, I think you need to split is apart.  The repo readme states that only one manifest can be contained in a PR.

Do we want to change the package ids? I understand that this is a breaking change but I guess now is the time to do that if we aren't happy with them.

I don't care for the inconsistent casing of dotnet vs dotNet
I chose Microsoft.dotnet vs Microsoft.dotnetCore so that it will be long term applicable when 5.0 is released and we drop “core” from the product name.  I thought it would be acceptable to change the name once .NET 5.0 is released from .NET Core to .NET.  An alternative option would be to have a "core" package for <= 3.1 and a non-core package for >= 5.0.
Outside of the casing, I have no objections to Microsoft.dotNetFramework.

@terrajobst, In order to get this PR green, I think you need to split is apart. The repo readme states that only one manifest can be contained in a PR.

Oopsy... probably should have read that. Submitted #551 for .NET Framework and kept this to .NET Core.

I chose Microsoft.dotnet vs Microsoft.dotnetCore so that it will be long term applicable when 5.0 is released and we drop “core” from the product name. I thought it would be acceptable to change the name once .NET 5.0 is released from .NET Core to .NET. An alternative option would be to have a "core" package for <= 3.1 and a non-core package for >= 5.0.

I figured and I'm OK with that reasoning. I just raised it because it seems we should make this decision deliberately.

Outside of the casing, I have no objections to Microsoft.dotNetFramework.

Should I submit a PR to change the casing? I'm afraid this will break stuff.

Should I submit a PR to change the casing? I'm afraid this will break stuff.
Yes please, I think now is the time to change it.


React & Redux group project - Space Travelers' Hub

Space Travelers' Hub
In this pull request, we have :

[ ] Create React App.
[ ] Installed React Redux, Redux Logger and React Router.
[ ] Downloaded the free image for the app logo.
[ ] Created routes and view components: rockets, missions, my profile.
[ ] Used  for the page navigation links and style active class to indicate which section/page the user is currently on (underline active navigation link).
[ ] Created directories for all Redux state slice files: rockets and missions
[ ] used Rockets: https://api.spacexdata.com/v4/rockets and the Missions: https://api.spacexdata.com/v3/missions
[ ] Used useSelector() Redux Hook to select the state slices and render lists of rockets and missions in corresponding routes.
[ ] Wrote actions and reducers for cancelling rockets/dragons and leaving missions
[ ] Rendered UI for rockets and missions

Hi @jeanbuhendwa @Patfarmurs ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
Your project looks awesome👏 ✔
Your PR is professional and well-detailed ✔
I love the fact that you collaborated to a great extend as shown by the structure of the commits messages 👏 ✔
It's a good thing that you were able to get your linter checks to pass ✔
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you @alexander16108


Add room options dropdown

Hi,
Checkbox to select multiple rooms for some actions such as empty the messages or delete the selected rooms. select all and unselect all. select by tags etc.

That's a nice idea, but I don't think I'll implement that anytime soon.

I don't think I'll implement multiple rooms selection, however as a middle ground I'll implement this feature:

I don't think I'll implement multiple rooms selection, however as a middle ground I'll implement this feature:

Feature added https://github.com/antoine92190/vue-advanced-chat/commit/68b505e4b05c94fd936f61a3acde8a12683a9b17

Feature added https://github.com/antoine92190/vue-advanced-chat/commit/68b505e4b05c94fd936f61a3acde8a12683a9b17


Decorrelate subqueries with ORDER BY / TopN

Example
WITH a AS (SELECT 1 employee_id),
     b AS (SELECT * FROM (VALUES (1, 2, 2), (1, 1, 1), (1, 3, 3)) t(employee_id, date, rating))
SELECT a.*,
       (SELECT b.rating FROM b
        WHERE b.employee_id = a.employee_id
        ORDER BY b.date DESC LIMIT 1) as rating
FROM a;

I assume LIMIT 1 will be a common factor in this type of queries.
We should implement this by automatically converting SELECT x ... ORDER BY y LIMIT 1 into `SELECT min_by(x, y).

max_by(x, y) and min_by(x, y) ignore all rows where y is null.
So, in the case where the null ordering NULLS FIRST is specified (or implicit), it might return a different value than TopN would.
Moreover,  if all y values are null, it will return null instead of any x value`.

I assume LIMIT 1 will be a common factor in this type of queries.

Any other LIMIT could be simply removed from the query.

Any other LIMIT could be simply removed from the query.

Maybe we can rewrite correlated ORDER BY col LIMIT n to:

grouped TopN (by correlation columns) in subquery. This will lead to having n top rows for every matching correlation.
we also need to apply grouped TopN above decorrelated join in order to restore order (join build rows might be produced in random order).

For reference, grouped TopN is `TopNRowNumberNode``

I don't think we can decorrelate a subquery containing TopN.
However, TopN can be removed from a subquery and re-applied on top of decorrelated join.
It could take the form of TopNRowNumberNode partitioned by a unique row id which in this case would have to be added to the left join source.

Additionally, we need to make sure that:

any Project in a subquery is restored above (plus remove row_number symbol, plus identities on left source symbols),
TopN's ordering scheme is not correlated,
TopN's count is 1, in the case when EnforeceSingleRow is present.
LateralJoin type is suitable for this transformation.

I don't think we can decorrelate a subquery containing TopN.
However, TopN can be removed from a subquery and re-applied on top of decorrelated join.

If limit is 1, then you can just rewrite TopN into TopNRowNumberNode with correlation symbols as partitioning symbols
If limit is >1, you also need to re-apply TopNRowNumberNode on top of de-correlated join.

TopN's ordering scheme is not correlated,

Technically, correlated symbols are constants from subquery perspective. You could just rewrite TopN (with limit N) into Limit N (remove order).

TopN's count is 1, in the case when EnforeceSingleRow is present.

That's not needed unless TopN physically produces more than 1 row

any Project in a subquery is restored above (plus remove row_number symbol, plus identities on left source symbols),

I think you can extend PlanNodeDecorrelator with support for TopN (limit 1). For limit >1, you need extra transformation rule

Technically, correlated symbols are constants from subquery perspective. You could just rewrite TopN (with limit N) into Limit N (remove order).

Or you can do other way around. That is convert Limit N to TopNRowNumberNode on correlated symbols. This gives nice benefit of supporting Limit N in lateral join correlated subqueries!

Got it. Limit / TopN can indeed be transformed in situ, which is much better than pulling limit above join.
You said before that for TopN where N > 1, we need to reproduce partitioned sort above decorrelated join.
But does LateralJoin with sorted subquery grant any order on output? If it doesn’t, we don’t need to reproduce it.

But does LateralJoin with sorted subquery grant any order on output? If it doesn’t, we don’t need to reproduce it.

I'm not sure you can assume that. Although execution might produce ordered result, one should consult property derivation (see: io.prestosql.sql.planner.optimizations.PropertyDerivations.Visitor#visitJoin) to check if that's the case.
I this particular case I think it will be the case, but you would need to modify io.prestosql.sql.planner.optimizations.PropertyDerivations.Visitor#visitJoin to reflect that

There are no derived properties for LateralJoin:
https://github.com/prestosql/presto/blob/ab0382cdd912bb1c8e5b5a0f7ac3733b13b51ab4/presto-main/src/main/java/io/prestosql/sql/planner/optimizations/PropertyDerivations.java#L215-L219

But does LateralJoin with sorted subquery grant any order on output?

I'm sure it doesn't. See @martint 's https://prestosql.io/blog/2019/06/03/redundant-order-by.html quote from SQL specification (ISO 9075 Part 2):

A <query expression> can contain an optional <order by clause>. The ordering of the rows of the table specified by the <query expression> is guaranteed only for the <query expression> that immediately contains the <order by clause>.

Right, so I assume that the ordering specified for the subquery's TopN shouldn't be expected, or referred to, in non-immediate context (above join).

I this particular case I think it will be the case, but you would need to modify io.prestosql.sql.planner.optimizations.PropertyDerivations.Visitor#visitJoin to reflect that

PropertyDerivations currently guarantees keeping probe side order in left and inner join, in the case of no spill.
In our case, if the probe side order is kept, nothing can be assumed about the overall order of the decorrelated join's result, that is not captured by PropertyDerivations.

To sum up the topic of implementation:
each of the cases: Top 1, Top N, Limit N can be transformed in the same way, that is rewritten to TopNRowNumberNode in PlanNodeDecorrelator.
That will enable decorrelating not only scalar subqueries, but any LateralJoin’s subqueries containing Limit or TopN.

Limit N can be transformed in the same way, that is rewritten to TopNRowNumberNode in PlanNodeDecorrelator.

Technically, we could have a dedicated grouped limit operator. It could have a better performance. I would start with rewrite to TopNRowNumberNode though.

You said before that for TopN where N > 1, we need to reproduce partitioned sort above decorrelated join.

I don't think we need to reproduce sort above decorrelated join after all. I don't think SQL requires that. What would the order be anyway?


feat: build and deploy container

Codecov Report
Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 65.09%. Comparing base (ffec353) to head (ff241ad).

Files
Patch %
Lines

cli/server_command.go
0.00%
12 Missing :warning:

app/turl/service.go
0.00%
1 Missing and 1 partial :warning:

cmd/turl/main.go
0.00%
2 Missing :warning:

app/turl/handler.go
83.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   66.28%   65.09%   -1.20%
==========================================
  Files          24       24
  Lines         703      719      +16
==========================================
+ Hits          466      468       +2
- Misses        210      223      +13
- Partials       27       28       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Video tape testing: moving annotations

Want to test how this works with video tapes. Test, merge etc.
Tried to move annotations from one dive to another. I can't see how to do this. In bulk editor, the move frames drop down menu doesn't list the dive I want them to go to. That dive has an annotation in it, so I know it exists in the new database.
Also, unclear as how we would change them to same dive, different tape number.

This should be reopened. There is no way to move annotations from one tape set to a new tape set. If a tape set exists already you can move annotations as expected. If not, you have to create a new real time annotation set and move all of them to that set; there appears to be no way to create a new tape set -- maybe this has to be done with a deck on through the browse to tape window? If so, that means to simply move dives I have to sit down and open up all the tape sets at a station that has a deck. In the old vars I could simply select annotations and move them wherever I want even if that tape set didn't exist the move process would do that for me.

This is related to #25


Add sugar overloads of ConfigureFacebookAuthentication (etc) that automatically read options from configuration

Not going to happen for RC at this point

These are actually already there, they were just in the wrong namespace (Builder), https://github.com/aspnet/Security/issues/107 is tracking


Sprint 6: Discussion and planning on next visualizations and metric

This is a part of the extended series of development for dashboard visualizations. Let this be the place where people can put their new ideas for visualizations or to voice the questions they would like to see answered.
For each sprint cycle, the following criteria must be met:

[ ] 2 (or more) new potential visualization or metrics
[ ] 2 proposed visualizations generated into a detailed issue to be assigned the next sprint
[ ] Discussions in this issue condensed into the following document

Some potential ideas from some work on the chaoss side:
-https://chaoss.community/metric-license-coverage/
-https://chaoss.community/metric-code-of-conduct/
-https://chaoss.community/metric-license-declared/
-https://chaoss.community/metric-test-coverage/
-https://chaoss.community/metric-bus-factor/
-https://chaoss.community/metric-elephant-factor/

@thewizzy Curious if you have any thoughts on this

Another idea: Looking at the response/close rate to issues with the bug/defect tag

Update: will be hosting a discussion around the topic of "What is the first question you have when initially see/hear of an open source community?" with the hopes to get more guidance on this at the next Community Architects CoP

Age and activity on pull requests? Could be part of the story of how receptive the project is to contributions.

@thewizzy can you elaborate a bit?

By looking at the Pull Requests for a project and consider a few of the attributes of them:

Who created it?
How old it is?
How much activity the PR has had (comments, reviews etc)?
Who, if anyone is responding to the PR?
How many PR are there and what is the spread of creation dates?
How many have been merged between those remaining?

By looking at these data points we could answer a few questions:

Is the project merging any new code?
How receptive are they to new contributions/Contributors? (Are they merging PRs by existing contributors and ignoring new contributors PRs?)

Could be useful for determining the general speed with which they would merge code but more importantly, how open they are to input from the community.

https://github.com/sandiego-rh/sandiego/blob/main/notebooks/pr_activity.ipynb
https://github.com/sandiego-rh/sandiego/blob/main/notebooks/performance/pr_performance.ipynb
https://github.com/sandiego-rh/sandiego/blob/main/notebooks/performance/pr_delta.ipynb
Would any combination of these cover what you are thinking?

https://github.com/sandiego-rh/sandiego/blob/main/notebooks/performance/pr_performance.ipynb
https://github.com/sandiego-rh/sandiego/blob/main/notebooks/performance/pr_delta.ipynb

These two in particular answer at least half of the attributes. The augur schema looks like it could be used to answer the rest.
Of the two questions, the first is pretty easy, if they have a PR merged in x time frame, they are merging new code. The second is probably more interesting to look at. In the meeting a few days ago one of the notebooks shared (I think James') was looking at contributors over time. How receptive a project is to new contributors will possibly influence that and could be useful as a health metric.


The initial dev-* into release-* pipeline for a new *-configs repository is difficult

See https://github.com/ACCESS-NRI/model-config-tests/pull/56#issuecomment-2319606419
Currently, we have to create release-* config branches on top of dev-* then push a boring commit to activate the config-pr-3-bump-tag.yml workflow (which is on.push.paths=metadata.yaml).
See if we can make this a bit more streamlined, maybe with a on.create trigger for release-* branches?
TODOs

[x] Modify CI for access-om2-configs. See https://github.com/ACCESS-NRI/access-om2-configs/pull/140
[x] Modify CI for access-esm1.5-configs. See https://github.com/ACCESS-NRI/access-esm1.5-configs/pull/91
[x] Modify CI for access-esm1.6-configs. See https://github.com/ACCESS-NRI/access-esm1.6-configs/pull/2
[x] Modify CI for access-om3[-wav]-configs if created before then. Note: Not required.
[x] Modify CI for template model-configs-template. See https://github.com/ACCESS-NRI/model-configs-template/pull/3
[x] Update potential triggers in model-config-tests config-pr-3-bump-tag.yml. See https://github.com/ACCESS-NRI/model-config-tests/pull/62

Closing as the above PRs are merged!


Adding support for docker build in travisCI

Description

Adding support for docker build in travisCI
Motivation and Context

To check docker image build automation through Travis CI
How Has This Been Tested?

Manually testet
Screenshots (if appropriate):
Types of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the Code style guidelines of this project
[ ] My unit test follow the Unit test guidelines
[ ] Unit test coverage percentage is maintained(increased/remains the same but not decreased)

@pravinrajr9 Please make sure the changes above can be used by jenkins to generate container images as well. Is this being validated on the BLR jenkins or the SC Jenkins?

Hi @arvindn05, this has not been validated through Jenkins. Will validate it


Add-to-app memory leak test

Make sure we don't get regressions on the embedding or in the engine. We manually tested and fixed issues for 1.12 to make sure the show screen, dismiss screen cycle doesn't cost any memory on a pre-warmed engine. Make sure it's locked it.

A lot of plugins are leaking memory because they do not get callback when activity is destroyed (issue)

A lot of plugins are leaking memory because they do not get callback when activity is destroyed (issue)

How to fix it ?

Note for future, make sure that we have some mechanism to test for https://github.com/flutter/engine/pull/9288

Example cases we should probably catch with LeakCanary in CI, https://github.com/flutter/engine/pull/18657, https://github.com/flutter/engine/pull/17646.

Another example https://github.com/flutter/flutter/issues/45499

Once that issue is solved, we should cover scenarios like https://github.com/flutter/flutter/issues/56482 as well.


Updated Set or override cloud role name section to include Python

New PR was created in MicrosoftDocs

New PR was created in MicrosoftDocs


use ‘UpSample‘ in DCGAN, loss do not decline. use ‘ConvTranspose2d‘ in DAGAN，loss decline

thank you  for the  work.
I meet a problem:  "use ‘UpSample‘  in DCGAN, loss do not decline.  use  ‘ConvTranspose2d‘ in DAGAN，loss   decline."
by the way, have you  re-upload the whole project?

@1210264601 , I'm not sure what is the issue.
And yes, I re-upload the whole project as a clean repo.

@1210264601 , I'm not sure what is the issue.
And yes, I re-upload the whole project as a clean repo.

as the picture I showed above， I add BN and RELUafter UPsample/conv2d.  Without these,  Loss in cglo cannot decline.

Please share your run params. Your reported issue doesn't make sense, as the loss is effectively computed by 2 factors: the classified and the reconstruction loss. So even if there is any problem with the classifier the reconstruction loss will decrease the loss anyway.


Support for NSDate parsing, fixes #17

Also removes the Date wrapper object, as it's no longer needed.
Fixes #17 .

Current coverage is 100.00%

Merging #36 into master will not affect coverage as of b975804

@@            master     #36   diff @@
======================================
  Files            4       3     -1
  Stmts          220     179    -41
  Branches         0       0
  Methods
======================================
- Hit            220     179    -41
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of b975804

Powered by Codecov. Updated on successful CI builds.


feat: always declare a ts_project _types target to fetch dts files

Sometimes the dts files need to be fetched, there is no reason this shouldn't be done when a transpiler is not being used.
This makes the declare targets more predictable.

Changes are visible to end-users: yes

Searched for relevant documentation and updated as needed: yes
Breaking change (forces users to change their own code or config): no
Suggested release notes appear below: yes

ts_project(name) declaration files can be fetched using the {name}_types target.
Test plan

Covered by existing test cases
New test cases added

@jbedard disabled auto merge so you an address the comment

The docs in https://github.com/aspect-build/rules_ts/blob/main/docs/transpiler.md#macro-expansion should be updated to say that the [name]_types expansion is always generated.


Add support for custom external HTTP/HTTPS ports

This PR allows to choose arbitrary ports for HTTP and HTTPS instead of 80 and 443.
While it does not change anything in the way ports can be mapped to host using native Docker capabilities, it fixes the "invalid" X-Forwarded-Port when the port on which nginx listens to is different from the one it is mapped - and accessed by clients - on the host.
Typical usage in docker-compose (here with the custom ports 1080 and 10443):
  reverse-proxy:
    image: jwilder/nginx-proxy
    ports:
      - "1080:1080"
      - "10443:10443"
    environment:
      HTTP_PORT: "1080"
      HTTPS_PORT: "10443"
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro

I'm open to suggestions.
Thanks for your amazing work on this image, it helps a lot.
Regards,

It was already merged in https://github.com/jwilder/nginx-proxy/pull/1388.
Please close.

Is there any timeline for this feature getting into the docker images?
We were just looking into finding something like this, and then discovered this PR merged a few hours ago!

Will this also create correct redirects from HTTP_PORT to HTTPS_PORT?


YAMLLoadWarning: calling yaml.load() without Loader=

Hi,
I got warning about deprecated and unsafe load:
/usr/local/lib/python3.6/site-packages/yamlconfig-0.3.1-py3.6.egg/yamlconfig.py:63: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.

https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

What are the steps to reproduce this?

this error appeared after container start.
I see this problem on pryorda/vmware_exporter:v0.11.1

What are the steps to reproduce this?

Try to load a config.yaml:
sudo docker run -it --rm  -p 9272:9272 -e VSPHERE_USER=${VSPHERE_USERNAME} -e VSPHERE_PASSWORD=${VSPHERE_PASSWORD} -e VSPHERE_HOST=${VSPHERE_HOST} -e VSPHERE_IGNORE_SSL=True -e VSPHERE_SPECS_SIZE=2000 --name vmware_exporter -v $(pwd)/config.yaml:/config.yaml pryorda/vmware_exporter -c /config.yaml

There is something (of course) to do with PyYAML version. Inside the container, PyYAML is 5.3, and here in my CentOS 8, it is 3.12 where the error does not happen.

I made a PR replacing yamlconfig for PyYAML.

Hi,
I got warning about deprecated and unsafe load:
/usr/local/lib/python3.6/site-packages/yamlconfig-0.3.1-py3.6.egg/yamlconfig.py:63: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.

https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

@dreiggy I believe it is solved. You may close this issue.

@rmontenegroo sure :)


Normalize interaction claim types

Closes #367

I converted this to a draft PR so that we don't merge it before I can update the data dump.


HTTPS not working for freeCodeCamp.com redirect

It seems HTTPS is not currently working on freeCodeCamp.com. This could be confusing some people who are still going to that domain, and it may be affecting backlinks.
For anyone reading this, freecodecamp.com redirects to freeCodeCamp.org. But some people still  mistakenly link to freeCodeCamp.com or visit it. So we need the https to work here.

Duplicate of https://github.com/freeCodeCamp/freeCodeCamp/issues/38201


Possibility to only request Country

Could we get a possibility to pick certain Countrys in an option menu?
It reduces the load on the API and not everyone needs all the data from ever country.
Thanks :)

yes its on my to do will work on it this weekend

implemented in 0.3.0
https://github.com/iobroker-community-adapters/ioBroker.coronavirus-statistics/commit/2f6b0d782f4339a1539c4090535d8b73d9a829db


chore: nlinarith bug caused by exposing loose bvars

Certainly better fixes to the panicking problem here are possible, by simply not traversing into places that would have loose bvars. However I'd like to get this patched quickly, so anyone wanting to make such a change can please do it in a follow up PR! :-)

bors merge


[OpenAI] Fix toolChoice

Packages impacted by this PR
@azure/openai
Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/28325
Describe the problem that is addressed by this PR
@jmaczan found that the spec contains a bug in representing an input option to chat completions. The spec is being fixed in https://github.com/Azure/azure-rest-api-specs/pull/27487.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
https://github.com/Azure/azure-rest-api-specs/pull/27487
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/openai


ARROW-8952: [C++] WIP Support for textual, JSON schema representation

7110

 Quality gate: Passed
34 Issues

 34 Code issues

Details


rake neo4j:install  error

rake neo4j:install[enterprise-latest,test]
Errno::ENOENT: No such file or directory @ rb_sysopen - db/neo4j/test/conf/neo4j-server.properties

I think you have an old version of neo4j-rake_tasks.
If you write rake neo4j:install[enterprise-latest,test], it will try to install v3.0.1, that is supported from v0.5.5+
https://github.com/neo4jrb/neo4j-rake_tasks/blob/master/CHANGELOG.md
Try upgrading it running bundle update neo4j-rake_tasks.

Thank you, solved


v1.2: Add Project and PropertyUsage trace elements

Looks good! Can you share a screenshot of the resulting report?

@abstratt Here's a screenshot:


Add an option to specify the name of the constraint (primary key, unique key, and foreign key)

It would be nice to, when desired, override the generated name of the constraint.

Are you thinking that you would like to set a constraint name for a specific test or are you hoping to specify a different naming convention?

Something like so:
- name: dim_duplicate_orders
    description: "Test that we do not try to create PK/UK on failed tests"
    columns:
      - name: o_orderkey
        description: "The primary key for this table"
      - name: o_orderkey_seq
        description: "duplicate seq column to test UK"
    tests:
      - dbt_constraints.primary_key:
          column_name: o_orderkey
          constraint_name: ddo_pk
          config:
            severity: warn
      - dbt_constraints.unique_key:
          column_name: o_orderkey_seq
          constraint_name: ddo_uk
        config:
            severity: warn

The value for 'constraint_name' would be used to name the constraint on the table rather than the generated name.  Not specifying a constraint name would use the current behaviour.  Sorry, I should have put this in the original message.

I'm still fairly new to dbt/jinja2, but I went ahead and tried implementing it myself.  Attached is a copy of my clone of the git repository with the changes in a branch named '34-optional-constraint-name'.  I made a slight change from my example above.  Instead of using a generic 'constraint_name' parameter for each of the key types, I used distinct parameters: 'pk_name', 'uk_name' and 'fk_name' .
dbt_constraints-34-optional-constraint-name.zip

I noticed that the most recent release provided this.  Thanks for that!


[Bug] The Token cannot move because it is locked.

I am using Elevation Ruler version 0.9.9 on Foundry version 12.328 with the Pathfinder 2e 6.0.4 system. I am accessing our server in the Firefox v127.0.2 (64-bit) browser on Windows 10, if that matters. Unfortunately, since I'm not the GM of the game, I'm unable to provide all world settings, but I will try to provide as much detail as I can as a player.
In short, Elevation Ruler seems to cause the error in the title when I try to move my token in one of the possible ways to move a token. The three methods that I typically use are the following:

Arrow keys
Left click and drag works fine
Ctrl+left click to measure out a path and space to make the token follow the path

If I use methods (1) and (2) on their own, I have no issues. If I use (3), the error in the title is triggered. If I attempt to use (1) and (2) after getting this error, the token refuses to move. If I refresh the browser after getting the error in the title, (1) and (2) work until I use (3) again.
My GM and I are pretty certain that Elevation Ruler is the issue, as we're able to return expected behavior once Elevation Ruler is turned off. I will note finally that, while I can replicate the issue on my end as a player, my GM is unable to find any issues on theirs, so it's possible that it might be a bug arising from the interaction between my browser, Foundry, and the module.
I also quickly went into the Console and this is the full detail of the error:

I cannot make this error appear. When you say "ctrl+left click to measure out a path", what exactly are the steps you are taking there? Maybe I am not doing it the same.

Sorry about the slow response. When I measure distance by making a chained ruler to determine a path for my token, then press space to make the token follow that path, I get the above error. Let me know if you need anything else from me to help debug.

I have the exact same issue. When I push control to design the path I want my character to move, then I push spacebar to activate the movement, I have the message "This token cannot be moved because it's locked".

I found an easier way to deal with the mod. I noticed that every player should activate the option "Use Token Ruler" in their own settings.

Per @aburley1234's PR, this might be fixed in v0.10.0.