Bad SEO

I can't find your library in github by query "php websocket" or "websocket" in "php".
https://github.com/search?l=PHP&p=1&q=websocket&type=Repositories

https://github.com/search?q=php+websocket&type=Repositories

Even my old library is on second position but your library is even not in top 10. (I checked in google chrome incognito).
I think the problem is in very long description.
https://github.com/search?q=workerman+websocket&type=Repositories

And may be github is indexing only "An asynchronous event driven PHP framework for easily building fast, scalable network applications. Supports HTTP, We".
If you like to have more traffic from search queries in github try to short your description.
For example:
An asynchronous event driven PHP framework. Supports HTTP, Websocket, SSL and other custom protocols. Supports libevent, HHVM, ReactPHP. http://www.workerman.net
I think only first 120 symbols will be indexed. So use it for important keywords.
And you need to use tags for your others repositories, for example, walkor/workerman-todpole . Now walkor/workerman-todpole is on third position by query "php websocket"  despite your project has much more likes then mine.

Thank you for your post. This is really a problem. Now I've shortened the description and will check the effect  in a few days.


[Feature Request] Provide binary artifact

Hi.
Do you plant to provide the binary artifact in the release page?
I am happy to help!
Thank you for maintaining cargo-leptos :heart:

My focus is currently to implement tailwind support, but yes, it would be nice to have binary artefacts.
@benwis also talked about possibly contributing it. Please sync with each other to avoid double contributions :)


Rename repository to weezl

This crate is published under the name weezl. It might make sense to rename the repository to match, to avoid possible confusion

If you do, please also make a release that updates the repo url in the crate, so that link between them can be verified.

You can verify the link by observing that https://github.com/image-rs/lzw redirects here now, but I'll publish a new release with the updated URL soon


replace deprecated tile server

The tilelayer service we were using went paid-only. This PR replaces it with a free service.
It also updates leafjs and uses higher-res maps if you're viewing on a retina screen

This looks reasonable, but when I tried to follow the install instructions in the README to run main locally and confirm they don't seem to work - I get a half-empty site with only some of the images, some of the text, and a disappearing navbar. Same behaviour running locally (from a poetry install) or in docker (using just up)
Fixing it is probably beyond the scope of this ticket though

yeah, that's expected behavior AFAICT.
the instructions get you an empty wagtail site with the same schema, etc, as our main site but the database is empty so there's no content.
If you want to validate this PR locally, you can

run the local site
log in as an admin user (you'll probably have to run just manage createsuperuser)
create a new venue page (the only important things here are getting the lat/long in - it should be fine if everything else is junk)
then view the new venue page


Nuitka is unable to get the return value of the API using requests

My running environment:
requests 2.28.2
nuitka 1.7.10
python 3.11.3
I wrote the following code to implement a simple API request:
import json
import requests
url = 'https://api.github.com/repos/erduotong/Simple_Class_Information_Display/releases/latest'
print("start")
response = requests.get(url,verify=True)
print("after")
print(json.dumps(response.json(),indent=4,ensure_ascii=False))

Then I compiled it with this command:

nuitka --standalone --mingw64 --show-memory --show-progress --remove-output --output-dir=../exe test.py

On my environment, it can normally output 'start', 'after' and the results obtained from the API, and then exit.
But in the exe processed by nuitka, it can only output 'start', and then there is nothing, no error, nothing at all.

The version output really shouldn't be typed up manually but incomplete.

Sorry, the information provided is insufficient
1.7.10
Commercial: None
Python: 3.11.3 (tags/v3.11.3:f3909b8, Apr  4 2023, 23:49:59) [MSC v.1934 64 bit (AMD64)]
Flavor: CPython Official
Executable: C:\Users\13568\AppData\Local\Programs\Python\Python311\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10
Version C compiler: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\x64\cl.exe (cl 14.3).

I cannot reproduce it. The output contains what I believe to be chinese characters, I was wondering if it is that, but if you say you do not get the output after the request, then it's not chinese yet. I tried with MSVC and MinGW64 both working. I was one minor behind in requests with that, updating to yours also worked fine.
As as cheap shot, can you run with --debug compilation enabled? If this is a crash, Nuitka has high chances of doing an assertion about it.

I tried using the same parameters, but now it can get and output normally again.
However, during the last error, Nuitka told me:
Assertion failed: dict_mp->ma_keys->dk_kind == DICT_KEYS_GENERAL, file C:\Users\13568\AppData\Local\Programs\Python\PYTHON~2\Lib\SITE-P~1\nuitka\build\static_src/HelpersDictionariesGenerated.c, line 705

Oh wow, that's bad. We got to find that for sure, the dictionary kind is not what Nuitka expects in some place. Errors might very well be random and spurious when that happens. I do not reproduce it. Since it depends on an external query, that might be bad for reproducing it entirely. It seems related to a DICT_COPY_KW that is not in an expected mode during what is probably a call with star dict argument. I am trying to see if I can somehow reproduce it elsewise, or wrap my head around why the assertion might fire, and if it's even warranted.

Running the test suite in debug mode, did not reveal anything like it.

I don't know what happened, but there's no problem in building it now. I can't reproduce this problem，too
(using the same procedures and commands)

In this code the assertion triggers:
        if (_PyDict_HasSplitTable(dict_mp)) {
            Py_ssize_t size = DK_ENTRIES_SIZE(dict_mp->ma_keys);

            PyDictObject *result_mp = _Nuitka_AllocatePyDictObject();
            assert(result_mp != NULL);
            result = (PyObject *)result_mp;

            for (Py_ssize_t i = 0; i < size; i++) {
                PyDictKeyEntry *entry = &DK_ENTRIES(dict_mp->ma_keys)[i];

                if (entry->me_value != NULL) {
                    PyObject *key = entry->me_key;
                    if (unlikely(!checkKeywordType(key))) {
                        had_kw_error = true;
                    }
                }
            }

            PyDictValues *new_values = _Nuitka_PyDict_new_values(size);
            assert(new_values != NULL);

It needs to be investigated, if maybe something got added for 3.11 dictionaries besides split tables, that can make this trigger.

This should be fixed by now, we have made corrections in the dictionary area. Please open the issue again should it happen all over, but I never reproduced it, so I cannot tell if it's current still.


chore(merge-back): 2.22.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: c87730fbcba2cc7c37c4da979f30eac1570b48ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Implement machine readable output format

I'm currently writing an automation shell script that buys a number, creates a sync service, and deploys a function. These deployed function should be used by the just bought number. Unfortunately, I didn't see a way to get the command response in an easy machine readable format.
The twilio CLI provides the command option -o=json for several other commands. This option allows to get the command response in JSON and thus in a machine readable format. It makes it possible to re-use values and to write advanced scripts. It would be great to have this option in the Twilio Serverless CLI plugin, too.
As the CLI is only a wrapper around twilio-run I thought that it's best to open the issue here first. :)
What I'm looking for is something as follows:
# in the Twilio CLI
$ twilio serverless.deploy -o=json

# and in twilio-run
$ twilio-run deploy --output=json

Is this something you'd be up for?

This is definitely on the roadmap for post SIGNAL. Thanks for filing this.

OK, so I've been working on this and I got quite a way into it before getting confused 😄
The commands list, list-templates, deploy, activate and logs all call off to APIs and have JSON results.
The commands new and start do not do that and don't really have an obvious return data. start isn't really a command that would be used by a machine but new is used by create-twilio-function.
So far, the work is ongoing on my json-output branch. I've added a output-format option to the BaseCliFlags but now I realise that the start and new commands don't necessarily need a JSON output, so perhaps it shouldn't be in BaseCliFlags.
So, to my questions:
Should the start and new commands have the --output-format flag as an option at all?
Should those two have another flag/option which silences their output so that other programs can use them without them making a mess over the terminal (e.g. see the test output of create-twilio-function)?
Or should I just leave the start and new commands alone for now?


Publish Python client and SDK to pypi

Won't do for now - instead, get repo and pip install locally


Add cursor pointer to top-scroll button

This scroll button should be cursor pointer

No, It looks good


[Retrospective] Release 2.9.0

This is Retrospective for the release 2.9.0

https://github.com/opensearch-project/opensearch-build/issues/3616

How to use this issue?
Please add comments to this issue, they can be small or large in scope. Honest feedback is important to improve our processes, suggestions are also welcomed but not required.
What will happen to this issue post release?
There will be a discussion(s) about how the release went and how the next release can be improved. Then this ticket will be updated with the notes of that discussion along side action items.

@AMoo-Miki during the release meeting you mentioned that the ODBC <IP_ADDRESS> artifact file prevented a script from completing successfully. Could you explain what happened? Is there something that needs to be done during ODBC release process to make this script pass?

Thank you @bbarani.
How does one go about updating the website next time there is a new version of JDBC or ODBC drivers?
cc @acarbonetto

Details of all major event points for release 2.9.0, along with their dates and short descriptions.
July 11 2023 — Initial Planned Code Freeze date for 2.9.0
July 11 2023 -- Initial Planned Code Complete date for 2.9.0
Jul 14, 2023 — 1st RC generated
PR's after the 1st RC

https://github.com/opensearch-project/dashboards-observability/pull/680
https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4577
https://github.com/opensearch-project/alerting-dashboards-plugin/pull/645
https://github.com/opensearch-project/alerting-dashboards-plugin/pull/649/
https://github.com/opensearch-project/alerting-dashboards-plugin/pull/649
https://github.com/opensearch-project/index-management-dashboards-plugin/pull/813
https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/656
https://github.com/opensearch-project/index-management-dashboards-plugin/pull/818/files
https://github.com/opensearch-project/OpenSearch/pull/8513
https://github.com/opensearch-project/cross-cluster-replication/pull/1078
https://github.com/opensearch-project/OpenSearch/pull/8738

Jul 14, 2023 — 1st RC Integration tests.
Jul 14, 2023 - 1st RC manual sign off.
Jul 17, 2023 — 2nd RC generated.
Jul 18, 2023 -- 2nd RC Integration tests.
July 18, 2023 — 2nd RC manual sign off.
PR's after the 2nd RC

https://github.com/opensearch-project/alerting-dashboards-plugin/pull/659
https://github.com/opensearch-project/alerting-dashboards-plugin/pull/661
https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4599
https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/776

Jul 18, 2023 — Go/No-Go call, move the release to July 20, 2023.
July 19, 2023 (1:07 pm) - Called out in the “feature-anywhere” channel of the saved object limit issue on OSD
July 19, 2023 (5:04 pm) - Called out in the “opensearch-releases” channel of the saved object limit issue on OSD and the need to get the fix in after discussing amongst the team if this is required for the 2.9 release.
July 19, 2023 - Got the OSD change for 2.9 related to the saved object limit issue merged.
Related PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4595
July 19, 2023 - Got the Alerting dashboard change for 2.9 related to the saved object limit issue merged.
Related PR: https://github.com/opensearch-project/alerting-dashboards-plugin/pull/659
July 19, 2023 - Got the AD dashboard change for 2.9 related to the saved object limit issue merged.
Related PR: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/pull/562
July 20, 2023 — Move the release to July 24, 2023.
As its not recommended to do the release on Friday's, the release date was adjusted to Monday (July 24, 2023).
July 20, 2023 — 3rd RC generated(Only for OSD)
**July 20, 2023 - July 24, 2023 — 3rd RC manual sign off.
July 24, 2023 — Release.
July 24, 2023. - Post Release

Following in the link to Retro Board:
https://github.com/orgs/opensearch-project/projects/140/views/1

Closing the issue as the Retrospective Meet was completed


How to solve this?

Error detected while processing function 98_OnCall:
line    2:
E701: Invalid type for len()
line    1:
E474: Invalid argument
line    2:
E701: Invalid type for len()
line    1:
E474: Invalid argument
line    2:
E701: Invalid type for len()
line    1:
E474: Invalid argument
line    2:
E701: Invalid type for len()
line    1:
E474: Invalid argument
line    2:
E701: Invalid type for len()
line    1:
E474: Invalid argument
line    2:
E701: Invalid type for len()
line    1:
E474: Invalid argument
line    2:
E701: Invalid type for len()
E701: Invalid type for len()
line    1:
E474: Invalid argument
line    2:
E701: Invalid type for len()
Press ENTER or type command to continue

Not enough information.
When I used deoplete I think that is what happens when there is an error with phpcd.
Try using c-X c-O and see what happens

估计是autoload设置不对,. 我也出现过这个问题,  原因是项目目录目录更改 ,  然后composer.json未更新(我仅仅用composer用来自动补全), 此时打开或者w 会报 和 asterism612 一样的问题,   ctrl+] 则是其他报错信息

@asterism612, I have this problem a lot, too.  Looking at my ~/.phpcd.log I noticed fatal errors coming from PHP.
[26-Sep-2017 22:26:24 UTC] PHP Fatal error:  Class TestClass contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (TestInterface::avg, TestInterface::max) in /Users/nomad/Code/engine/src/TestClass.php on line 11

I had just implemented an interface and hadn't yet defined the methods.  I'm assuming this happens if phpcd encounters any sort of exception/error when loading the working file (syntax errors, parse errors, etc).

syntax error and parse error can be catched by Error throwable. However, defining a class without implementing all methods is a true fatal error and cannot be handled by php code.


Updated translations for ja/ko/zh

All files updated, pushing through the TMS does not seem to allow me to add a commit message to sign-off, I'll get that sorted out later.

/ok-to-test

/cc @RobDolares


Fix R2 score test in gpu

Codecov Report

Merging #323 into master will decrease coverage by 5.79%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #323     +/-   ##
=========================================
- Coverage   89.59%   83.79%   -5.8%
=========================================
  Files         182      182
  Lines        8272     8274      +2
=========================================
- Hits         7411     6933    -478
- Misses        861     1341    +480


@conda-forge-admin,please add bot automerge

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/dvc-data-feedstock#38.


Checkout what is already there...

https://github.com/topics/fis-broker

R package: https://github.com/patperu/berlingeo

Python: https://github.com/berlinonline/ckanext-fisbroker

https://blog.buergerbautstadt.de/daten-aus-dem-fis-broker-nutzen/
https://www.codefor.de/projekte/fis-broker/
http://sebastian-meier.github.io/BerlinRefined/pages/fisbroker/details/wms_parkraumbewirt.html
https://swilke-geoscience.net/post/maptips_1/

Don't ask how I got it. I cannot reproduce...
fis-broker_contents.txt
(Rename .txt to .html, GitHub does not allow to upload .html)

Found another R package which tries to read wfs from FIS-Broker:
https://github.com/EcoDynIZW/d6raster


Have any GUI/Visual Builder?

Is there have any gui/visual builder?
Or have plugins for Pinegrow?
This will be amazing, older Intel XDK does the job, but very slow and not smooth.
Copy/paste is nice, but visual will be much better and faster.
Thanks for amazing framework

This would be good to have but i wouldn't have a clue where to start.
Perhaps https://polymer-designer.appspot.com/ (GitHub) could provide some inspiration for any implementation.

Thanks a lot for reply. I look into app

On the Framework7 Patreon page, it says that a "drag & drop visual app builder" is in the plans: https://www.patreon.com/vladimirkharlampidi.


doc error at https://docs.scipy.org/doc/scipy/reference/tutorial/stats/discrete_poisson.html

in it’s own right

should be
in its own right

Also

“sparsity “constraints.

should be
“sparsity“ constraints.

Thanks - I made  pull request with the changes - have a look at #9137 ?

Thanks - looks good now!
K

From: Matthew Brett<EMAIL_ADDRESS>Sent: 13 August 2018 10:38:08
To: scipy/scipy
Cc: Briggs,KM,Keith,TUD2 R; Author
Subject: Re: [scipy/scipy] doc error at https://docs.scipy.org/doc/scipy/reference/tutorial/stats/discrete_poisson.html (#9135)
Thanks - I made pull request with the changes - have a look at #9137https://github.com/scipy/scipy/pull/9137 ?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/scipy/scipy/issues/9135#issuecomment-412462736, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE6IEQ_zWTFYDWRygp22-oGYi5xiUFY9ks5uQUkAgaJpZM4V6LCM.


Switching between TextInputs with values set does something funny to the keyboard

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes 👍
Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 8.1.0
Yarn: 0.19.1
npm: 5.5.1
Watchman: 4.6.0
Xcode: Xcode 9.0 Build version 9A235
Android Studio: Not Found
Packages: (wanted => installed)
react: ^16.0.0-beta.5 => 16.0.0-beta.5
react-native: ^0.49.5 => 0.49.5
Steps to Reproduce

(Write your steps here:)

Add two simple <TextInput /> ( can even use react natives example )
Make sure both <TextInput /> have values in them and autoCapitalize is set to default
Then switch between the two inputs ( better tested on a phone ).

Expected Behaviour

Simply when focusing on a new <TextInput /> with a value, the keyboard should not shift from Uppercase to Lowercase
Actual Behaviour

When navigating between the two TextInput components the keyboard for some reason starts with uppercase keyboard, then quickly changes to lowercase.
Example below is a bare bone of react native using Expo.

Reproducible Demo

Link to simple demo
Continually tap between the two <TextInputs/> and you should notice the keyboard flickers between uppercase and lowercase.

Hi @KirMcC, I think you missed that you are changing the first input in the setState on both text inputs.
_handleTextChange = inputValue => {
    this.setState({ inputValue });
};

see your modified demo.

Ah my bad on that part @omar-dev . But doesn't fix the issue :(. Still set's the keyboard to uppercase first then switches to lowercase. Only if you have values in the TextInputs components and autoCapitalize is set to default. Setting the inputs to autoCapitalize ='none' doesn't bug out the keyboard, but I can't have all inputs set like this.
I'm still able to input/update values okay, but seeing the keyboard flicker when focusing on the next input looks terrible.

@KirMcC yes I missed that one, hope it got fixed soon.
Thanks.


OLS-346: E2e tests for console reconciliaiton

Description
This PR is on top of #56     <== merge that before this one.
This PR adds E2E tests about reconcile console related resources after unintended modification.
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue # OLS-346
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[x] If it is a core feature, I have added thorough tests.

Testing

/hold

/unhold

/hold
Needs rebase to pass test. Will use https://github.com/openshift/lightspeed-operator/pull/124

@raptorsun We can close this PR as we merged https://github.com/openshift/lightspeed-operator/pull/124

/close


How to handle double click?

ondbclick={handler} seems not work.

Maybe a typo? It's dblclick (https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers.ondblclick).

I have used ondblclick and it is ok.

my bad, it was typo. ondblclick works.


Did did:key substitute did:peer or are both still available for the rest agent?

Hi! This is more of a question than an issue report.
I ran the openapi demo today and I noticed that it used the did:key method, instead of the did:peer method that is mentioned in the openapi demo markdown for documentation.
I wanted to ask was the did:peer method completely removed for some reason, or there is some extra configuration that needs to be done to switch to using it.
Thank you!

My mistake, this turned out to be a huge misunderstanding from my side


OAuth & Identity Framework

Task description
Investigate Identity Framework and OAuth integration with different providers (Google, Facebook, etc.)

Link to documentation:
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/identity?view=aspnetcore-5.0&tabs=visual-studio

Link to documentation:
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/identity?view=aspnetcore-5.0&tabs=visual-studio


calico: User "system:serviceaccount:kube-system:calico-node" cannot list resource "endpointslices" in API group "discovery.k8s.io"

Pod calico-node not coming up.
Example:
kube-system   calico-node-rm2pl                          0/1     Running   0          25m
2022-01-23 19:01:04.265 [INFO][50] felix/kubeendpointslice.go 101: Unable to list K8s EndpointSlice
resources error=endpointslices.discovery.k8s.io is forbidden: User "system:serviceaccount:kube-system:
calico-node" cannot list resource "endpointslices" in API group "discovery.k8s.io" at the cluster scope
2022-01-23 19:01:04.265 [INFO][50] felix/watchercache.go 186: Failed to perform list of current data during
resync ListRoot="/calico/resources/v3/projectcalico.org/kubernetesendpointslices" error=connection is
unauthorized:  endpointslices.discovery.k8s.io is forbidden: User "system:serviceaccount:
kube-system:calico-node" cannot list resource "endpointslices" in API group "discovery.k8s.io"
at the cluster scope

patch is merged, all green now. /close


api,server,ui: tagged resource limits

Description
Introduces the concept of tagged resource limits. Limits can be enforced on accounts and domains for the deployment of entities for a tagged resource. Current tagged resource limits can be used for the following resource types,
Host limits
- user_vm
- cpu
- memory
Storage limits
- volume
- primary_storage
Following global settings can used to specify tags for which limit needs to be enforced,
Host: `resource.limit.host.tags`
Storage: `resource.limit.storage.tags`

Option for specifying tagged resource limits and viewing tagged resource usage are made available in the UI.
Enhances the use of templatetag for VM deployment and template creation
Adds option to list disk offering with suitability flag for a virtual machine. A new parameter named virtualmachineid has been added to the listDiskOfferings API which when passed returns suitableforvirtualmachine param in the response.
ToDo: Schema changes to be moved in 4.20 upgrade path
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8075

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8148

@blueorangutan test

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8702)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48924 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t8702-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_07_deploy_kubernetes_ha_cluster
Failure
3623.14
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_10_vpc_tier_kubernetes_cluster
Failure
46.93
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
99.38
test_kubernetes_clusters.py

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15.  It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8406

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8458

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8477

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8488

@blueorangutan test

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Test results from backend,
[SF] Trillian test result (tid-9040)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43368 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t9040-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 341.70 | test_safe_shutdown.py

@shwstppr from your description, it seems like you're proposing something that already exists, we already have limits for all resources you listed (and a few more) on an account/domain scope, I feel like I'm missing something here, could you maybe describe a little further what you're proposing?
Also, about this:

Adds option to list disk offering with suitability flag for a virtual machine. A new parameter named virtualmachineid has been added to the listDiskOfferings API which when passed returns suitableforvirtualmachine param in the response.

To me this looks like an unrelated change, this PR is already big, so adding more context will make it a little too complex for reviewing. It would be better to separate different changes in different PRs so that we can properly review the code.

Now there is one global parameter for maximum volume size. With this new feature will it be possible to specify different maximum volume sizes for different storage pools?

@JoaoJandre Description in the PR specifically mentions limits for tagged resources. I'll review and make further changes to make it clearer.
Regarding listDiskOfferings change I would prefer it in the same PR as it has already been tested internally. We will add relevant test reports. Also, diskoffering suitability for a VM is quite related to offering and storage pool tags. I'll update the title and description for the PR if needed.

Now there is one global parameter for maximum volume size. With this new feature will it be possible to specify different maximum volume sizes for different storage pools?

@gogast no, this feature will not add that functionality. You may add an improvement request for this if needed.
However, with this feature, operators will be able to specify host and storage tags as resource limit tags. Once these tags are specified in the new global config, operators will be able to set limits (VM, cpu, memory, volumes and primary storage) for account and domains.
This can be useful when you have some specialized hardware on which you would want to enforce some extra limits.
Eg, For an account you've set volumes limit as 10. But now you want the account to deploy only 5 volumes on SSD storage. To facilitate this you can tag your SSD storage with tag - SSD. Create a corresponding disk offering with this tag. Specify this tags resource.limit.storage.tags. With UI and API now you can set limits for volume resource type  with tag SSD as 5.
In short, it gives functionality to set certain resource limits on a granular level for accounts and domains.

@JoaoJandre Description in the PR specifically mentions limits for tagged resources. I'll review and make further changes to make it clearer. Regarding listDiskOfferings change I would prefer it in the same PR as it has already been tested internally. We will add relevant test reports. Also, diskoffering suitability for a VM is quite related to offering and storage pool tags. I'll update the title and description for the PR if needed.

@shwstppr, does the change on the list disk offering depends on the other change you are proposing? Because if one does not affect or depends on the other, they are different contexts, even if related to the same set of functionalities (storage's and host's tags, in this case).
Mixing contexts in a PR is not encouraged. It makes it difficult for others to review the changes and understand what is being done, especially in these cases with thousands of changes. Furthermore, unrelated changes being tested internally should not be used as reason to open a PR with all of them. While contributing to a community, we should structure our changes and proposals in a way that others can easily understand what is being done/proposed; thus, communicating without noise.

Not interested at all in unnecessary noise like some, I'll move some of the offerings API related change to separate PRs. cc @vladimirpetrov

@blueorangutan test matrix

@vladimirpetrov a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-9076)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 54968 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t9076-vmware-67u3.zip
Smoke tests completed. 119 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_balanced_drs_algorithm
Error
430.45
test_cluster_drs.py

test_08_upgrade_kubernetes_ha_cluster
Failure
1037.44
test_kubernetes_clusters.py

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8626

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-9164)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 1530 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t9164-kvm-centos7.zip
Smoke tests completed. 7 look OK, 122 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

runTest
Error
0.00
test_2fa.py

runTest
Error
0.00
test_diagnostics.py

runTest
Error
0.00
test_accounts.py

runTest
Error
0.00
test_deploy_vm_extra_config_data.py

runTest
Error
0.00
test_affinity_groups_projects.py

runTest
Error
0.00
test_deploy_vms_with_varied_deploymentplanners.py

runTest
Error
0.00
test_affinity_groups.py

runTest
Error
0.00
test_annotations.py

runTest
Error
0.00
test_domain_disk_offerings.py

runTest
Error
0.00
test_async_job.py

runTest
Error
0.00
test_attach_multiple_volumes.py

runTest
Error
0.00
test_direct_download.py

runTest
Error
0.00
test_backup_recovery_dummy.py

runTest
Error
0.00
test_events_resource.py

runTest
Error
0.00
test_backup_recovery_veeam.py

runTest
Error
0.00
test_deploy_vm_iso.py

runTest
Error
0.00
test_certauthority_root.py

runTest
Error
0.00
test_disk_provisioning_types.py

runTest
Error
0.00
test_cluster_drs.py

runTest
Error
0.00
test_global_acls.py

runTest
Error
0.00
test_console_endpoint.py

runTest
Error
0.00
test_deploy_vm_with_userdata.py

runTest
Error
0.00
test_create_list_domain_account_project.py

runTest
Error
0.00
test_global_settings.py

runTest
Error
0.00
test_create_network.py

runTest
Error
0.00
test_deploy_vgpu_enabled_vm.py

runTest
Error
0.00
test_disk_offerings.py

runTest
Error
0.00
test_guest_os.py

runTest
Error
0.00
test_deploy_virtio_scsi_vm.py

runTest
Error
0.00
test_deploy_vm_iso_uefi.py

runTest
Error
0.00
test_guest_vlan_range.py

runTest
Error
0.00
test_deploy_vm_root_resize.py

runTest
Error
0.00
test_deploy_vms_in_parallel.py

runTest
Error
0.00
test_domain_network_offerings.py

runTest
Error
0.00
test_domain_service_offerings.py

runTest
Error
0.00
test_domain_vpc_offerings.py

runTest
Error
0.00
test_enable_account_settings_for_domain.py

runTest
Error
0.00
test_gateway_on_shared_networks.py

runTest
Error
0.00
test_host_control_state.py

runTest
Error
0.00
test_hostha_simulator.py

runTest
Error
0.00
test_host_ping.py

runTest
Error
0.00
test_image_store_object_migration.py

runTest
Error
0.00
test_internal_lb.py

runTest
Error
0.00
test_ipv6_infra.py

runTest
Error
0.00
test_iso.py

runTest
Error
0.00
test_kubernetes_clusters.py

runTest
Error
0.00
test_kubernetes_supported_versions.py

runTest
Error
0.00
test_list_accounts.py

runTest
Error
0.00
test_list_disk_offerings.py

runTest
Error
0.00
test_over_provisioning.py

runTest
Error
0.00
test_list_domains.py

runTest
Error
0.00
test_list_hosts.py

runTest
Error
0.00
test_nonstrict_affinity_group.py

runTest
Error
0.00
test_list_ids_parameter.py

runTest
Error
0.00
test_list_service_offerings.py

runTest
Error
0.00
test_list_storage_pools.py

runTest
Error
0.00
test_list_volumes.py

runTest
Error
0.00
test_password_server.py

runTest
Error
0.00
test_loadbalance.py

runTest
Error
0.00
test_login.py

runTest
Error
0.00
test_metrics_api.py

runTest
Error
0.00
test_migration.py

runTest
Error
0.00
test_multipleips_per_nic.py

runTest
Error
0.00
test_nested_virtualization.py

runTest
Error
0.00
test_network_acl.py

runTest
Error
0.00
test_portable_publicip.py

runTest
Error
0.00
test_network_ipv6.py

runTest
Error
0.00
test_outofbandmanagement.py

runTest
Error
0.00
test_network_permissions.py

runTest
Error
0.00
test_network.py

runTest
Error
0.00
test_nic_adapter_type.py

runTest
Error
0.00
test_nic.py

runTest
Error
0.00
test_non_contigiousvlan.py

runTest
Error
0.00
test_outofbandmanagement_nestedplugin.py

runTest
Error
0.00
test_persistent_network.py

runTest
Error
0.00
test_portforwardingrules.py

runTest
Error
0.00
test_primary_storage.py

runTest
Error
0.00
test_privategw_acl_ovs_gre.py

runTest
Error
0.00
test_privategw_acl.py

runTest
Error
0.00
test_projects.py

runTest
Error
0.00
test_public_ip_range.py

runTest
Error
0.00
test_pvlan.py

runTest
Error
0.00
test_quarantined_ips.py

runTest
Error
0.00
test_regions.py

runTest
Error
0.00
test_register_userdata.py

runTest
Error
0.00
test_volumes.py

runTest
Error
0.00
test_reset_configuration_settings.py

runTest
Error
0.00
test_reset_vm_on_reboot.py

runTest
Error
0.00
test_vm_life_cycle.py

runTest
Error
0.00
test_resource_accounting.py

runTest
Error
0.00
test_resource_detail.py

runTest
Error
0.00
test_vm_schedule.py

runTest
Error
0.00
test_router_dhcphosts.py

runTest
Error
0.00
test_router_dns.py

runTest
Error
0.00
test_router_dnsservice.py

runTest
Error
0.00
test_vm_deployment_planner.py

runTest
Error
0.00
test_routers_iptables_default_policy.py

runTest
Error
0.00
test_routers_network_ops.py

runTest
Error
0.00
test_routers.py

runTest
Error
0.00
test_vm_snapshot_kvm.py

runTest
Error
0.00
test_safe_shutdown.py

runTest
Error
0.00
test_scale_vm.py

runTest
Error
0.00
test_secondary_storage.py

runTest
Error
0.00
test_service_offerings.py

runTest
Error
0.00
test_vm_snapshots.py

runTest
Error
0.00
test_set_sourcenat.py

runTest
Error
0.00
test_vpc_ipv6.py

runTest
Error
0.00
test_snapshots.py

runTest
Error
0.00
test_ssvm.py

runTest
Error
0.00
test_storage_policy.py

runTest
Error
0.00
test_templates.py

runTest
Error
0.00
test_update_security_group.py

runTest
Error
0.00
test_usage_events.py

runTest
Error
0.00
test_usage.py

runTest
Error
0.00
test_vnf_templates.py

runTest
Error
0.00
test_vm_autoscaling.py

runTest
Error
0.00
test_vm_lifecycle_unmanage_import.py

runTest
Error
0.00
test_vpc_redundant.py

runTest
Error
0.00
test_vpc_router_nics.py

runTest
Error
0.00
test_vpc_vpn.py

runTest
Error
0.00
test_host_maintenance.py

runTest
Error
0.00
test_hostha_kvm.py

@blueorangutan test

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@JoaoJandre Description in the PR specifically mentions limits for tagged resources. I'll review and make further changes to make it clearer. Regarding listDiskOfferings change I would prefer it in the same PR as it has already been tested internally. We will add relevant test reports. Also, diskoffering suitability for a VM is quite related to offering and storage pool tags. I'll update the title and description for the PR if needed.

@shwstppr, does the change on the list disk offering depends on the other change you are proposing? Because if one does not affect or depends on the other, they are different contexts, even if related to the same set of functionalities (storage's and host's tags, in this case).
Mixing contexts in a PR is not encouraged. It makes it difficult for others to review the changes and understand what is being done, especially in these cases with thousands of changes. Furthermore, unrelated changes being tested internally should not be used as reason to open a PR with all of them. While contributing to a community, we should structure our changes and proposals in a way that others can easily understand what is being done/proposed; thus, communicating without noise.

@GutoVeronezi (cc @JoaoJandre), I agree with the principal of submitting small isolated chunks of functionality as much as possible. In this case, it is work done for a customer now given back to the upstream source tree. It is indeed slightly different pieces of code and could be separated out, but this is not work we (as in @shwstppr) will do now. It has been tested and any comments on either of the pieces that will lead to further changes, will then have to be tested on the integrated version as well. the QA work is what is leading in this case. I don't like reviewing 7000 lines of code in one go either, sorry.

[SF] Trillian test result (tid-9184)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46393 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t9184-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8654

@blueorangutan test

@harikrishna-patnala @vishesh92 I've addressed your comments. Can you please check?

@blueorangutan package

@shwstppr is this ready/can it go out of draft ?

@shwstppr is this ready/can it go out of draft ?

Waiting for @vladimirpetrov to finish some manual QA

[SF] Trillian test result (tid-9213)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46491 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t9213-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@JoaoJandre @GutoVeronezi , this has been reviewed by several and has gone through our QA procedure (manual and automated testing. Do you guys hace any concerns with merging this?

@DaanHoogland, my concerns are regarding the structure of the proposal, as I mentioned here. Regarding the code itself, I did not have time to review 7,000+ lines of changes; therefore, I do not have an opinion on it. I am -0.

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el7 ✔ el8 ✔ el9 ✖ debian ✔ suse15. SL-JID 8700

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8701

@blueorangutan test

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-9277)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44396 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t9277-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Merging based on approvals, manual QA and smoke test results


feat(op): use RollupCostData instead of full encoding

This is a WIP to ultimately replace the tx_envelope part of the OptimismFields with a new struct.
Currently it just introduces the struct, which basically mirrors the RollupCostData from op-geth, and uses it in a few places. The plan is to first integrate this internally, without breaking OptimismFields, and once it is properly tested, break OptimismFields to use this instead.

@Rjected this looks nice, did you check why tests are failing?

nope, was busy with other things, can pick this back up this week


Get rid of need to .get() from the agents HashMap constantly

This is an obvious UX issue and will also be a slowdown since we will have to search the map each time we want to call a contract or deploy. There's got to be a nice way to get rid of this issue with the borrow checker, but I'm not sure what it is yet.

It might be possible to extract the struct inside the AgentType enum in some way and use that:
        let base_arbitrageur = match arbitrageur {
            AgentType::SimpleArbitrageur(base_arbitrageur) => base_arbitrageur,
            _ => panic!()
        };
        base_arbitrageur.detect_arbitrage();

Closed for now.


Add support for TLV Bytes Control

Alsa Bytes Control mixer can be reached using TLV methods.
This allows Bytes Control to be greater than 512 bytes.
Add support for read/write TLV access methods.

:+1:


Fix title and remove excess package references from Steeltoe sample

fixes #56 and removes a couple NuGet references that aren't needed

LGTM


WIP: Make OS-provided env vars override defaults

Fixes #1673
PR Type

Bugfix Pull Request

Somebody plz test this :)

Oh yes, great to try and get this fixed.
I've manually tested it and didn't see --debug functionality occur ...
(.venv) ➜  testrolelatest (bugfix/allow-real-env-vars-take-precedence) ✗ export MOLECULE_DEBUG=True
(.venv) ➜  testrolelatest (bugfix/allow-real-env-vars-take-precedence) ✗ molecule create
--> Validating schema /home/decentral1se/ansible/molecule/testrolelatest/molecule/default/molecule.yml.
Validation completed successfully.
--> Test matrix

└── default
    ├── create
    └── prepare

--> Scenario: 'default'
--> Action: 'create'

    PLAY [Create] ******************************************************************

    TASK [Log into a Docker registry] **********************************************
    skipping: [localhost] => (item=None)

    TASK [Create Dockerfiles from image names] *************************************
    changed: [localhost] => (item=None)
    changed: [localhost]

    TASK [Discover local Docker images] ********************************************
    ok: [localhost] => (item=None)
    ok: [localhost]

    TASK [Build an Ansible compatible image] ***************************************
    changed: [localhost] => (item=None)
    changed: [localhost]

    TASK [Create docker network(s)] ************************************************

    TASK [Determine the CMD directive] *********************************************
    ok: [localhost] => (item=None)
    ok: [localhost]

    TASK [Create molecule instance(s)] *********************************************
    changed: [localhost] => (item=None)
    changed: [localhost]

    TASK [Wait for instance(s) creation to complete] *******************************
    changed: [localhost] => (item=None)
    changed: [localhost]

    PLAY RECAP *********************************************************************
    localhost                  : ok=6    changed=4    unreachable=0    failed=0

--> Scenario: 'default'
--> Action: 'prepare'
Skipping, prepare playbook not configured.

I dropped into the debugger to see what was what on this run:
(.venv) ➜  testrolelatest (bugfix/allow-real-env-vars-take-precedence) ✗ molecule create
> /home/decentral1se/ansible/molecule/molecule/config.py(275)_reget_config()
-> env = util.merge_dicts(self.env.copy(), os.environ)
(Pdb) self.env['MOLECULE_DEBUG']
'False'
(Pdb) os.environ['MOLECULE_DEBUG']
'True'
(Pdb) env = util.merge_dicts(self.env.copy(), os.environ)
(Pdb) env = set_env_from_file(env, self.env_file)
(Pdb) env['MOLECULE_DEBUG']
'True'
(Pdb) env = self._combine(env=env)
(Pdb) env
{'dependency': {'name': 'galaxy', 'command': None, 'enabled': True, 'options': {}, 'env': {}}, 'driver': {'name': 'docker', 'provider': {'name': None}, 'options': {'managed': True}, 'ssh_connection_options': [], 'safe_files': []}, 'lint': {'name': 'yamllint', 'enabled': True, 'options': {}, 'env': {}}, 'platforms': [{'name': 'instance', 'image': 'centos:7'}], 'provisioner': {'name': 'ansible', 'config_options': {}, 'connection_options': {}, 'options': {}, 'env': {}, 'inventory': {'hosts': {}, 'host_vars': {}, 'group_vars': {}, 'links': {}}, 'children': {}, 'playbooks': {'cleanup': 'cleanup.yml', 'create': 'create.yml', 'converge': 'playbook.yml', 'destroy': 'destroy.yml', 'prepare': 'prepare.yml', 'side_effect': 'side_effect.yml', 'verify': 'verify.yml'}, 'lint': {'name': 'ansible-lint', 'enabled': True, 'options': {}, 'env': {}}}, 'scenario': {'name': 'default', 'check_sequence': ['cleanup', 'destroy', 'dependency', 'create', 'prepare', 'converge', 'check', 'cleanup', 'destroy'], 'cleanup_sequence': ['cleanup'], 'converge_sequence': ['dependency', 'create', 'prepare', 'converge'], 'create_sequence': ['create', 'prepare'], 'destroy_sequence': ['cleanup', 'destroy'], 'test_sequence': ['lint', 'cleanup', 'destroy', 'dependency', 'syntax', 'create', 'prepare', 'converge', 'idempotence', 'side_effect', 'verify', 'cleanup', 'destroy']}, 'verifier': {'name': 'testinfra', 'enabled': True, 'directory': 'tests', 'options': {}, 'env': {}, 'additional_files_or_dirs': [], 'lint': {'name': 'flake8', 'enabled': True, 'options': {}, 'env': {}}}}

It's confusing that it returns the full configuration ....
It seems there is a bug further in self._combine?

Yeah, maybe. I didn't check it that deeply. So multiple bugs?

https://github.com/ansible/molecule/issues/1673 has been resolved by https://github.com/ansible/molecule/pull/1802 :+1:

@decentral1se does this mean that the current PR is irrelevant?

@decentral1se does this mean that the current PR is irrelevant?

Maybe? It fixes another bug that isn't #1673?

@webknjaz Base on the description I do not find it irrelevant. I would just wait for it to pass CI and have the "WIP" removed and I will review it. I like the idea of having a generic way to loading environment variables which would override the config ones, just like ansible.

@ssbarnea isn't that what your PR's done? I didn't inspect it closely, though.

I don't have time to work on this currently but feel free to post any thoughts or pick it up anyway :)

have the "WIP" removed and I will review it.

It's like a 6 character change ;)

I like the idea of having a generic way to loading environment variables which would override the config ones, just like ansible.

Is this not already possible?
I would probably just close this off since the bug it is targetting has already been fixed.


Help !  My svg image cannot render success with html2canvas

before use html2canvas

after user html2canvas

If you are still running into this issue, please create a new ticket with a repro


Lost Connection to IoT Hub after 30 minutes

Hello,
I followed your article and I my sensor is able to send data to my IoT Hub but after 30 minutes it stopps with the following error messages (I removed the time and path to make it easier to read):
Error: [...]Arduino\libraries\AzureIoTUtility\src\adapters\tlsio_arduino.c Func:tlsio_arduino_send Line:378 TLS failed sending data
Error: [...]Arduino\libraries\AzureIoTProtocol_HTTP\src\azure_uhttp_c\httpapi_compact.c Func:HTTPAPI_ExecuteRequest Line:1212 Send heads to HTTP failed (result = HTTPAPI_SEND_REQUEST_FAILED)
Error: [...]Arduino\libraries\AzureIoTUtility\src\adapters\tlsio_arduino.c Func:tlsio_arduino_create Line:161 Host cld-test.azure-devices.net not found.
Error: [...]Arduino\libraries\AzureIoTProtocol_HTTP\src\azure_uhttp_c\httpapi_compact.c Func:HTTPAPI_CreateConnection Line:233 Create connection failed
After that, I get these error Messages over and over:
Error: [...]Arduino\libraries\AzureIoTUtility\src\adapters\tlsio_arduino.c Func:tlsio_arduino_create Line:161 Host cld-test.azure-devices.net not found.
Error: [...]Arduino\libraries\AzureIoTProtocol_HTTP\src\azure_uhttp_c\httpapi_compact.c Func:HTTPAPI_CreateConnection Line:233 Create connection failed
Error: [...]Arduino\libraries\AzureIoTUtility\src\azure_c_shared_utility\httpapiex.c Func:HTTPAPIEX_ExecuteRequest Line:475 unable to recover sending to a working state
Error: [...]Arduino\libraries\AzureIoTHub\src\sdk\iothubtransporthttp.c Func:DoEvent Line:1684 unable to HTTPAPIEX_SAS_ExecuteRequest
Error: [...]Arduino\libraries\AzureIoTUtility\src\adapters\tlsio_arduino.c Func:tlsio_arduino_create Line:161 Host cld-test.azure-devices.net not found.
Error: [...]Arduino\libraries\AzureIoTProtocol_HTTP\src\azure_uhttp_c\httpapi_compact.c Func:HTTPAPI_CreateConnection Line:233 Create connection failed
Error: [...]Arduino\libraries\AzureIoTUtility\src\azure_c_shared_utility\httpapiex.c Func:HTTPAPIEX_ExecuteRequest Line:475 unable to recover sending to a working state
Error: [...]Arduino\libraries\AzureIoTHub\src\sdk\iothubtransporthttp.c Func:DoMessages Line:2077 unable to HTTPAPIEX_SAS_ExecuteRequest
When I reupload the code to my Feather M0 Wifi, everything works fine for 30 minutes and then the connection is lost again and I get the same Errors. Is there anything I have to change to make it run for longer?
I appreciate any help!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86e8e5e0-b932-bbeb-1b34-e66a3242906a
Version Independent ID: 15c5b01b-ecaa-6022-cd9d-720d4c691f8d
Content: M0 to cloud -- Connect Feather M0 WiFi to Azure IoT Hub
Content Source: articles/iot-hub/iot-hub-adafruit-feather-m0-wifi-kit-arduino-get-started.md
Service: iot-hub
GitHub Login: @rangv
Microsoft Alias: rangv

@cocosnuss Thanks for the feedback. We are actively investigating and will get back to you soon.

@cocosnuss I believe there is a configuration value in the config.h file that determines how long the temperature alert remains active upon start.
In the instructions where you add a TRUE/FALSE based upon whether you are using a simulated sensor or not, the 30 min TEMPERATURE_ALERT is the next line down:

Use the sample application if you don’t have a real BME280 sensor.
Please let me know if you have additional questions.
Regards,
Mike

I changed the configuration value but these Errors still occur after 30 minutes

@cocosnuss Did you follow the steps to redeploy the sample application? I unfortunately do not have access to the hardware necessary to reproduce this, nor test a fix. The Temperature Alert duration appears to be static. Can you make an enhancement request to make the sensor data collection period configurable: Azure IoT Hub User Voice.
Thanks,
Mike

@shizn Are you able help out with this issue. Can the period of time the sensor collects data (currently 30 minutes) be changed to another value?

@Mike-Ubezzi-MSFT
I am not completely sure that these 30 minutes are a fixed value. I found this issue where it was possible to run the application for a couple of hours (https://github.com/Azure/azure-iot-arduino/issues/30)
What do you mean by "follow the steps to redeploy"? Follwing the instructions from the article?
I made the enhancement request, let's see if something happens :)

@cocosnuss whe looking at the error messages this makes me suspect that the wifi connection drops and the device is not able to reconnect. Is this occurring "always" after 30 minutes or sometimes is less and other times is more? One quick test is to start the sample, turn off your Wifi Router during some period and turn it back on to check if the device can reconnect or the error reported occurs.
Another option I can see is that you use MQTT protocol instead of HTTP to see if it makes any difference?
Let us know what enhancements you did so far and the results. You can copy\paste the entire log. Searching for similar issues on these three repos may also help:
https://github.com/Azure/azure-iot-arduino-utility
https://github.com/Azure/azure-iot-arduino-protocol-http
https://github.com/Azure/azure-iot-arduino
Thanks!

I tested it a few times before and it was always exactly 30 minutes. I'll do some additional tests and let you know what happend

One other question is if the error occurs both for simulated and real sensor data? Thanks.

It does occur with both simulated and real sensor data. I also tested the MQTT Protocol but the connection also stopped after 30 minutes. At the moment I suspect that it has something to do with my wifi. I'll test another wifi network on the weekend and let you know if there's something wrong.

When using the MQTT protocol the errors differ a Little bit. At the beginning I get the following errrors, but after that the messages still get send (I removed the time and path to make it easier to read):
Info: Attempting to connect to SSID: myWifiNetwork
Info: Connected to wifi myWifiNetwork
Info: Fetched NTP epoch time is:<PHONE_NUMBER>
Error: [...]\Arduino\libraries\AzureIoTUtility\src\adapters\tlsio_arduino.c Func:tlsio_arduino_setoption Line:523 Failed tlsio_options_set
Error: [...]Arduino\libraries\AzureIoTHub\src\sdk\iothub_client_ll.c Func:IoTHubClient_LL_SetOption Line:1790 unable to IoTHubTransport_SetOption
Info: failure to set option "MinimumPollingTime"
Info: Sending message: {"deviceId":"Feather M0 WiFi","messageId":1,"temperature":25,"humidity":39}
Info: IoTHubClient accepted the message for delivery
Info: Message sent to Azure IoT Hub
[...]
Then I can send Messages for 30 minutes and after that I get These errors:
Error: [...]Arduino\libraries\AzureIoTUtility\src\adapters\tlsio_arduino.c Func:tlsio_arduino_send Line:378 TLS failed sending data
Error: [...]Arduino\libraries\AzureIoTProtocol_MQTT\src\azure_umqtt_c\mqtt_client.c Func:sendComplete Line:201 MQTT Send Complete Failure send_result: 1
Error: [...]Arduino\libraries\AzureIoTProtocol_MQTT\src\azure_umqtt_c\mqtt_client.c Func:sendPacketItem Line:342 369: Failure sending control packet data
Error: [...]Arduino\libraries\AzureIoTProtocol_MQTT\src\azure_umqtt_c\mqtt_client.c Func:mqtt_client_publish Line:1040 Error: mqtt_client_publish send failed
Error: [...]Arduino\libraries\AzureIoTHub\src\sdk\iothubtransport_mqtt_common.c Func:publish_mqtt_telemetry_msg Line:839 Failed attempting to publish mqtt message
Info: Failed to send message to Azure IoT Hub
Info: Sending message: {"deviceId":"Feather M0 WiFi","messageId":31,"temperature":29,"humidity":33}
Info: IoTHubClient accepted the message for delivery
Error: [...]Arduino\libraries\AzureIoTUtility\src\adapters\tlsio_arduino.c Func:tlsio_arduino_create Line:161 Host cld-test.azure-devices.net not found.
Error: [...]Arduino\libraries\AzureIoTHub\src\sdk\iothubtransport_mqtt_common.c Func:GetTransportProviderIfNecessary Line:1724 Unable to create the lower level TLS layer.
These last two messages get repeated over and over

At the moment I suspect that it has something to do with my wifi. I'll test another wifi network on the weekend and let you know if there's something wrong.

This seems a good test to perform. I would also recommend that you double check that you have all the latest versions of libraries necessary to run this sample + the latest firmware bits installed on your board.
Thank you! I will wait for more news after you do the tests.

I used another wifi network and the same computer and my device was able to send longer than 30 minutes. I will do another test to see if it will run longer.
I will check the wifi network if there is some kind of configuration that kicks out any device which performs regular activities after 30 minutes.

I talked to our network guy (this is a corporate wifi network) and he suspects that it has something to do with our firewall. Strangly, Microsoft's Raspberry Pi script works continiously and doesn't loose connection. So it is hard for me to tell where exactly the mistake is. I'll try to investigate further but I think it will be difficult to solve this problem. Because the issue maybe is caused by our Firewall, I'll close this issue.
Thank you very much for your help!

Thank you @cocosnuss we appreciate that, please feel free to reopen this issue if needed :).


proposal: add a build tag "test"

To have code be compiled only during tests, it's easy: just put the code in a file suffixed _test.go. However, there is no mechanism for the complement: to have code that is excluded when testing. I propose we set the tag "test" when the build is being run under "go test".
The desire for this came up for me recently when I wanted to test some code's behavior given a value I wanted to be constant. The only way to do this now is to make it a variable that the test modifies, but a variable is not a constant. There are things you can do with a constant, such as declare array types, that are illegal with a variable.
It was necessary to change the semantics of the code to make it testable. That bothers me.
This is a small problem, I admit, but the proposed solution is also small.

Isn't this the same as #14668, which you didn't like?

This also looks like a duplicate of/related to #12120 (/cc @slimsag), which is even older.
I'll paste a point I made there, since it's relevant:

However, it is not possible to exclude some code from being built into tests ran by go test [via a build tag]

I want to share an opinion related to that. I consider that a feature. I think it's great you (or anyone) can't exclude some .go files from tests. That makes test code purely additive and easier to reason about.

Yes, I didn't like it then, but today I encountered an actual instance where I wanted it. My arguments before still stand, but I did find a new argument in favor.
It's not quite a duplicate of #14668, and that's closed anyway, so I'll leave this for now.

... sentiment about my proposal being closed as working-as-intended and later reopened two years later aside..
I've had a desire for this functionality multiple times. Most recently, I've had to exclude certain code from a test invocation inside a package-level init, i.e.:
func init() {
	if !isTest {
		...
	}
}

This led me to use an atrocious concoction like this, which relies on initialization order to function correctly:
mypackage.go:
var isTest bool

mypackage_test.go:
var _ = func() bool {
	isTest = true
	return true
}()

If a test build tag existed today, I would use it.

I haven't made up my mind quite yet, just musing aloud:
Assuming a test built tag, arguably the _test.go file name extension mechanism is not needed anymore; in some sense it would remove a mechanism. I'm not suggesting we do, having test files marked by name seems like a nice thing to have, but a test build tag will lead to overlap where currently there's none. Imagine also the confusion that can be created by excluding a _test.go file from a test by using a !test build tag...
This suggests an alternative, such as a _notest.go filename extension.
(And pushing this a bit further: Instead of build tags, one could encode the file build properties in the file name: imagine x+test.go, x-test.go, or syscall+linux+mipsx.go... In fact, we already do essentially this in file names because otherwise we can't keep the files apart in a meaningful way. Would also allow the build system to determine whether a file is required or not by simply looking at the name rather than the contents. But I digress. Maybe something to think about for Go 2.)

I'll be that guy, what's wrong with go test -tags test?
You are in control of the tests, you can easily add that without changing the testing logic.

@OneOfOne That is something extra I have to explain to every contributor who wishes to run the tests of my project, and it's the kind of command that makes people go Wait, what?!. Not having that build tag would mean compilation would fail, and they'd report issues because of it.

@slimsag while that's a valid point, it's easily worked around, for example just add an extra test file to notify the users:
checktags_test.go
// +build !test

package pkg

func init() {
    log.Println("please rerun go test with -tags test")
}

I admit, that is a pretty decent workaround I had not thought of. Thanks @OneOfOne I think I'll start using that for now!
It'd still be nice to have real support for this, though.

I think it's worth noting that this would require us to potentially rebuild every dependency of the package being tested.  This is somewhat problematic when using a build system other than go build, such as Bazel.  It essentially implies that every package must be treated as having two possible outputs, one to use for a normal build and one to use for tests.  This doesn't prevent us from adopting this plan, but it's worth considering.

I'll expand on @ianlancetaylor's point to say that it'd affect not only the build system, but the experience of Go users. If this is adopted, it could mean that a dependency of a dependency of a dependency (any one of them) can in theory change its behavior when you do go test your/package compared to when you do go build your/package.
Imagine running into an issue in production, then trying to reproduce it by running some tests and running them with go test, only to eventually find out it's not possible to reproduce via go test because the issue happens only when test tag is not specified.
Right now, that is not possible, so a Go user is safe knowing their dependencies will behave identically for go build your/package and go test your/package.
However, I'll note that the original proposal doesn't necessarily mean the test tag would have to apply to all dependencies. One way of implementing this is to have that tag only apply to the current package whose test are being executed, but not to its dependencies.

Is there any other real-world example where we could benefit from having this build tag, or is it really just about constants? If it's just about constants, maybe we can find a better solution.

Rob says to pull this.


Skip Token Issue

Hello -
I am receiving the following error when trying to run the script. I've been unable to find any similar error through general searching and research.
ERROR: {
"code": "BadRequest",
"message": "Please provide below info when asking for support: timestamp = 2024-07-08T18:00:08.1462571Z, correlationId = 43f5a0a5-fbf1-40f1-a726-f87f3ec9e1d4.",
"details": [
{
"code": "CouldNotDecodeSkipToken",
"message": "Skip token could not be decoded."

Hello,
Same error for me.

@Claudio-Merola  I am having the same errors
ERROR: {ventory [3% Complete.                                                ]     "code": "BadRequest",     "message": "Please provide below info when asking for support: timestamp = 2024-07-10T07:24:06.7335216Z, correlationId = 13458ad1-8c5a-4bcf-adc9-096e714e38fe.",     "details": [         {             "code": "CouldNotDecodeSkipToken",             "message": "Skip token could not be decoded."         }     ] } ERROR: {     "code": "BadRequest",     "message": "Please provide below info when asking for support: timestamp = 2024-07-10T07:24:08.3106135Z, correlationId = dcf7ddcf-29b6-4050-8f31-a6736544d220.",     "details": [         {             "code": "CouldNotDecodeSkipToken",             "message": "Skip token could not be decoded."         }     ] } ERROR: {     "code": "BadRequest",     "message": "Please provide below info when asking for support: timestamp = 2024-07-10T07:24:09.8610084Z, correlationId = a6bb4556-0193-483c-ae6f-749f7dc6bfd3.",     "details": [         {             "code": "CouldNotDecodeSkipToken",             "message": "Skip token could not be decoded."         }     ] }
Client: MacOS & WIndows
azure cli version: 2.62.0
Thanks for your kind support

Hello,
Yea, it was a bug in version 3.1.33, should be fixed now. Can you give a try at version 3.1.34?

The issue has been resolved in 3.1.34. Thanks.


fix: assorted prod performance fixes

High Level Overview of Change
This PR has several fixes:

Fixes some issues with Buffer still being used in the app (even though the polyfill is no longer there)
Fixes some issues with time calculations on ledgers
Shrinks the max ledger count from 20 to 15 to save memory
Optimizes the ledger and validation store to save memory on the home page

Context of Change
The recent high load on the ledger has been stretching the memory and performance limits of the Explorer.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

TypeScript/Hooks Update
N/A
Before / After
N/A
Test Plan
Fixes work locally. The optimizations shrink the object sizes by 25-30%.

Can you also update the Buffer usages in /src/rippled/NFTTransactions.ts, /src/rippled/lib/utils.js and src/index.html?


Replacing RadClass.RadClass with RadClass.Processor

With #38, the workflow of RadClass will slightly change. RadClass.RadClass will now be seen predominantly as a data processing unit. While it does have functionality to conduct analysis iteratively as it processes data (see AnalysisParameters, or RadClass.H0), the new SSML models will be used separately, after data processing occurs, acting upon the fully processed dataset.
Since RadClass.RadClass's scope has changed, I am renaming it to reflect its role: RadClass.Processor. Now, the output of the processor (i.e. processed data, or spectra) will be given to ML models as a post-processing step by the user.

@gonuke This PR is rebased and now ready for merge.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
221

Relevant Lines:
221

💛  - Coveralls


yaml bool type inconsistent boolean instance evaluation

Describe the bug
In yaml/_types/bool.ts, booleans are evaluated as
typeof value === "boolean" || value instanceof Boolean

This means Boolean instances are handled as booleans in yaml but the representation is evaluated as
represent: {
    lowercase(object: boolean): string {
      return object ? "true" : "false";
    },
    uppercase(object: boolean): string {
      return object ? "TRUE" : "FALSE";
    },
    camelcase(object: boolean): string {
      return object ? "True" : "False";
    },
}

This will always stringify Boolean instances to "true", which  is probably not the intended behavior.
Steps to Reproduce
import { stringify } from "@std/yaml";
import { assertEquals } from "@std/assert";
assertEquals(stringify(new Boolean(false)), "true\n");

Expected behavior
new Boolean(false) should evaluate to "false" OR Boolean instances should not be special treated and value instanceof Boolean  removed so they are handled as objects.
I am leaning torwards the removal. WDYT?

Yeah, it seems the predicate should just be value === true || value === false. I don't see why Boolean instances should be treated in any special way. I'm not aware of any such treatment elsewhere in the codebase.

I'll open a PR. Would that be breaking or fix?


Do not want to use static functions in Events.php file

Hi Walkor,
Previously we were using workerman so we have used onMessage, OnWorkerStart etc without static method and we have used $this in the whole project that are used for workerman.
Now we want to use the same code in the GatewayWorker but we are facing issue when we using $this keyword inside static functions. We want to keep the older code same as current because there are lots of functions and variables in our existing project are using $this keyword.
Is there any way we can use these function without static keyword?
For Examples:-
public static function onWorkerStart($businessWorker)
{
   $this->telemed = new telemed();
   $this->telemed->socketStartAlert(SYS_ID_ALERT);
}

A better way is create your own BusinessWorker which extends GatewayWorker\BusinessWorker.
The codes may like this.
class MyBusinessWorker extends GatewayWorker\BusinessWorker {
    protected function onWorkerStart()
    {
        static $event_instance = null;
        $event_instance = new $this->eventHandler;
        if (function_exists('opcache_reset')) {
            opcache_reset();
        }

        if (!class_exists('\Protocols\GatewayProtocol')) {
            class_alias('GatewayWorker\Protocols\GatewayProtocol', 'Protocols\GatewayProtocol');
        }

        if (!is_array($this->registerAddress)) {
            $this->registerAddress = array($this->registerAddress);
        }
        $this->connectToRegister();

        \GatewayWorker\Lib\Gateway::setBusinessWorker($this);
        \GatewayWorker\Lib\Gateway::$secretKey = $this->secretKey;
        if ($this->_onWorkerStart) {
            call_user_func($this->_onWorkerStart, $this);
        }

        if (is_callable([$event_instance, 'onWorkerStart'])) {
            call_user_func([$event_instance, 'onWorkerStart'], $this);
        }

        if (function_exists('pcntl_signal')) {
            pcntl_signal(SIGALRM, array($this, 'timeoutHandler'), false);
        } else {
            $this->processTimeout = 0;
        }
        if (is_callable([$event_instance, 'onConnect'])) {
            $this->_eventOnConnect = [$event_instance, 'onConnect'];
        }

        if (is_callable([$event_instance, 'onMessage'])) {
            $this->_eventOnMessage = [$event_instance, 'onMessage'];
        } else {
            echo "Waring: {$this->eventHandler}::onMessage is not callable\n";
        }

        if (is_callable([$event_instance, 'onClose'])) {
            $this->_eventOnClose = [$event_instance, 'onClose']
        }

        if (is_callable([$event_instance, 'onWebSocketConnect'])) {
            $this->_eventOnWebSocketConnect = [$event_instance, 'onWebSocketConnect'];
        }

    }
}

Thank you!


Unable to set namespace for C# client

Hi,
in the documentation
https://github.com/RSuter/NSwag
https://github.com/RSuter/NSwag/wiki/SwaggerToCSharpClientGenerator
there is an example how to set the namespace for the generated client:
var clientSettings = new SwaggerToCSharpClientGeneratorSettings
{
    ClassName = "MyClass",
    Namespace = "MyNamespace"
};

But there doen't seem to be a "Namespace" attribute in the SwaggerToCSharpClientGeneratorSettings  class: Error CS0117 'SwaggerToCSharpClientGeneratorSettings' does not contain a definition for 'Namespace'
So how do I set the namespace? (At the moment, the namespace is always "MyNamespace"...)

The Namespace property is on the CSharpGeneratorSettings property...

According to
https://github.com/RSuter/NSwag
it is
var clientSettings = new SwaggerToCSharpClientGeneratorSettings
{
	ClassName = "MyClass",
	Namespace = "MyNamespace"
};

where "Namespace" is unknown. So the example on this page is not correct?
According to
https://github.com/RSuter/NSwag/wiki/SwaggerToCSharpClientGenerator
it is
var settings = new SwaggerToCSharpGeneratorSettings
{
    ClassName = "MyClass",
    Namespace = "MyNamespace"
};

which is also not possible as SwaggerToCSharpGeneratorSettings is an abstract class. So the example on this page is not correct?
If I use CSharpGeneratorSettings then I have to use CSharpGenerator, too? How to I decide if I want server or client code here? In addition, CSharpGenerator doesn't accept a SwaggerDocument as suggested in the samples on the pages above. So what is a valid example here?
May I kindfully suggest to have a verifying look at the documentation?

Ok, ive updated the docs. CSharpGeneratorSettings  is part of SwaggerToCSharpGeneratorSettings  as you can see now..

Just back from holiday. Documentation looks correct now. I've just tested the code. Works great! Thank you.


Can't customize path for lazy loaded module chunks

Command
config
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
i have the sam problem as decribed in https://github.com/angular/angular-cli/issues/22418
Set APP_BASE_HREF does not work, cause it affected also the router.
Minimal Reproduction
Create a simple Angular application with a router, where files are located. The chunks are not loaded.

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1402.10 (cli-only)
@angular-devkit/core         14.2.10 (cli-only)
@angular-devkit/schematics   14.2.10 (cli-only)
@schematics/angular          14.2.10 (cli-only)

Anything else relevant?
No response

Hi @heeeman,
You'd need to configure the baseHref build option and not APP_BASE_HREF injection token. See https://angular.io/cli/build for more information about the build options.
If the problem persists, please provide a simple repository reproducing the problem.  You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

It does not work. The  of the html page override the baseHref  build option

@heeeman, it is the other way round the baseHref build option overrides what's in the HTML.
Kindly provide a minimal reproduction of the problem otherwise we will be unable to look into this issue.

I hope this works as reproducer:
https://github.com/heeeman/angularReproducer.git

Thanks for the reproduction.
The problem here is that the base href in the CMS project is set incorrectly. As this is set to point to the application path and not were the resources are located. Relative resources (which lazy chunks are) are longer relative to the base href.
Also, APP_BASE_HREF also needs to be configured as otherwise the router will use the base href from HTML which would cause routing not to work correctly.
Below find the diffs needed.
diff --git a/serverContent/cms/dynamic/path/angularembedded/index.html b/serverContent/cms/dynamic/path/angularembedded/index.html
index e896e29..8a6a3d3 100644
--- a/serverContent/cms/dynamic/path/angularembedded/index.html
+++ b/serverContent/cms/dynamic/path/angularembedded/index.html
@@ -3,10 +3,10 @@

   <meta charset="utf-8">
   <title>CMS Page</title>
-  <base href="/cms/dynamic/path/angularembedded">
+  <base href="/standalone/">
   <meta name="viewport" content="width=device-width, initial-scale=1">
   <link rel="icon" type="image/x-icon" href="favicon.ico">
-  <link rel="stylesheet" href="/standalone/styles.css">
+  <link rel="stylesheet" href="styles.css">

@@ -24,7 +24,7 @@

back to root

-
+

diff --git a/src/app/app.module.ts b/src/app/app.module.ts
index a9b3db1..b22a8a0 100644
--- a/src/app/app.module.ts
+++ b/src/app/app.module.ts
@@ -6,18 +6,22 @@ import { AppComponent } from './app.component';
 import { OtherPageModule } from './other-page/other-page.module';
 import { NicePageComponent } from './nice-page/nice-page/nice-page.component';
 import { NicePageModule } from './nice-page/nice-page.module';
+import { APP_BASE_HREF } from '@angular/common';

 @NgModule({
   declarations: [
     AppComponent
   ],
   imports: [
     BrowserModule,
     AppRoutingModule,
     // OtherPageModule,
     // NicePageModule
   ],
-  providers: [],
+  providers: [
+    {
+      provide: APP_BASE_HREF,
+      useValue: '/cms/dynamic/path/angularembedded',
+    },
+  ],
   bootstrap: [AppComponent],
 })
  export class AppModule { }

The  cms path is not under my control and dynamic, that's the problem. Actually I read the base href from the cms site to set APP_BASE_HREF  for my routing. But it's not possible to set or change base href from the cms site.
For the moment I have removed the lazy loading.

You can set the APP_BASE_HREF dynamically by the means of a factory function.
providers: [
  {
    provide: APP_BASE_HREF,
    useFactory: getAppBaseHref,
    deps: [HttpClient],
  }
],
…

function getAppBaseHref(http: HttpClient): string {
 // get value from config / dynamically from CMS
}

Closing as this issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.

so - there's no possibility for lazy loading, if it's not possible to set <base href> tag on the page.


For deep-forms isPristine is false when adding and removing fields in an array without modifying any of the sub-values

Change of array is not considered as isPristine.

lets say fields = { fieldKey: [{value: 'first'}, {value; 'second''}] }  Now try removing the second entry.
isPristine is not caught.

Yep. Known bug that probably won't get fixed in v5, but is already fixed in v6. There are some workarounds discussed in previous issues: #391 #484 #749


DHT Crawler

ℹ This is more based off of dht-graph although this repository is a better long-term home for the crawler

[x] Propose data model for result format. A mix of Node holding existing dht-graph style format, and Trial structure used for connectivity analysis by Michigan
[x] Clean up code quality a bit
[x] Hooking of additional event-bus events to properly tag connectivity times and successes for peers.
[ ] Unit Tests
[ ] CI
[x] Automatic archival / push of data into google bigquery

⚠  I plan to merge this tomorrow, to iterate on CI/CD against a tagged release.

⚠  I plan to merge this tomorrow, to iterate on CI/CD against a tagged release.


feat(home): reduce card content spacing + move social links into own component

I reduced the spacing in the card component by altering the card height and margins.  I also cleaned up the card's css.  In addition, I created styles / added some markup for the social links and made a new component for them (to help with reusability and maintenance).
Finally, I added some base link styles (should have made a separate commit for this, but the change is a small refactor).
[EDIT]
My apologies, I should have split up the commits a bit better.

Well it is much better than the average PR. Good work @vinnyA3!


Configure Multiple Schedulers

Following the steps on page https://kubernetes.io/docs/tasks/extend-kubernetes/configure-multiple-schedulers/ , the my-scheduler pod in kube-system do not work.
root@node1:~/repos/kubernetes# kubectl logs -f my-scheduler-547c8f5b76-rspp4 -n kube-system
I1111 07:20:05.023342       1 serving.go:348] Generated self-signed cert in-memory
I1111 07:20:05.024111       1 configfile.go:57] "KubeSchedulerConfiguration v1beta2 is deprecated in v1.25, will be removed in v1.28"
W1111 07:20:05.024175       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
W1111 07:20:05.235543       1 requestheader_controller.go:193] Unable to get configmap/extension-apiserver-authentication in kube-system.  Usually fixed by 'kubectl create rolebinding -n kube-system ROLEBINDING_NAME --role=extension-apiserver-authentication-reader --serviceaccount=YOUR_NS:YOUR_SA'
W1111 07:20:05.235575       1 authentication.go:349] Error looking up in-cluster authentication configuration: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot get resource "configmaps" in API group "" in the namespace "kube-system"
W1111 07:20:05.235585       1 authentication.go:350] Continuing without authentication configuration. This may treat all requests as anonymous.
W1111 07:20:05.235593       1 authentication.go:351] To require authentication configuration lookup to succeed, set --authentication-tolerate-lookup-failure=false
I1111 07:20:05.243353       1 server.go:152] "Starting Kubernetes Scheduler" version="v1.26.0-beta.0.9+cf12a74b18b66e"
I1111 07:20:05.243380       1 server.go:154] "Golang settings" GOGC="" GOMAXPROCS="" GOTRACEBACK=""
I1111 07:20:05.244450       1 configmap_cafile_content.go:202] "Starting controller" name="client-ca::kube-system::extension-apiserver-authentication::client-ca-file"
I1111 07:20:05.244487       1 shared_informer.go:273] Waiting for caches to sync for client-ca::kube-system::extension-apiserver-authentication::client-ca-file
I1111 07:20:05.244565       1 secure_serving.go:210] Serving securely on [::]:10259
I1111 07:20:05.244645       1 tlsconfig.go:240] "Starting DynamicServingCertificateController"
W1111 07:20:05.245857       1 reflector.go:424] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1111 07:20:05.245905       1 reflector.go:140] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
W1111 07:20:05.250037       1 reflector.go:424] vendor/k8s.io/client-go/informers/factory.go:149: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1111 07:20:05.250100       1 reflector.go:140] vendor/k8s.io/client-go/informers/factory.go:149: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1111 07:20:06.066029       1 reflector.go:424] vendor/k8s.io/client-go/informers/factory.go:149: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1111 07:20:06.066065       1 reflector.go:140] vendor/k8s.io/client-go/informers/factory.go:149: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1111 07:20:06.399020       1 reflector.go:424] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1111 07:20:06.399074       1 reflector.go:140] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
W1111 07:20:08.545546       1 reflector.go:424] vendor/k8s.io/client-go/informers/factory.go:149: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1111 07:20:08.545586       1 reflector.go:140] vendor/k8s.io/client-go/informers/factory.go:149: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1111 07:20:09.168313       1 reflector.go:424] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1111 07:20:09.168362       1 reflector.go:140] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
W1111 07:20:11.861222       1 reflector.go:424] vendor/k8s.io/client-go/informers/factory.go:149: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1111 07:20:11.861276       1 reflector.go:140] vendor/k8s.io/client-go/informers/factory.go:149: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1111 07:20:14.883044       1 reflector.go:424] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1111 07:20:14.883082       1 reflector.go:140] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
W1111 07:20:21.388520       1 reflector.go:424] vendor/k8s.io/client-go/informers/factory.go:149: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1111 07:20:21.388558       1 reflector.go:140] vendor/k8s.io/client-go/informers/factory.go:149: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1111 07:20:21.934834       1 reflector.go:424] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1111 07:20:21.934878       1 reflector.go:140] pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:my-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
^C
root@node1:~/repos/kubernetes#

The following execution solved this
kubectl create rolebinding -n kube-system my-scheduler-extension-apiserver-authentication-reader --role=extension-apiserver-authentication-reader --serviceaccount=kube-system:my-scheduler

I've found other issues mentiond this problem like #30172 , will you consider modify the page  content ?

/triage accepted
/help
Would you like to propose a fix for this? @chenxinlong

@tengqm I'll try to fix this on this weekend.

@chenxinlong please let me know if you are still interested in raising a PR for this.

I would like to give a try on this.
/assign


[BUG] - update proposal for major version bump ignored on network forked to Alonzo at epoch 0

Internal
Update proposal is being successfully submitted:
Aug 27 08:41:01 bft-a-1 cardano[523853]: Chain extended, new tip: ca245bbea4fdb177c0428c26a79e48e2d684b127fe7d73f7e2bfe4ba464872c4 at slot 590761
                                         Event: LedgerUpdate (HardForkUpdateInEra S (S (S (S (Z (WrapLedgerUpdate {unwrapLedgerUpdate = ShelleyUpdatedProtocolUpdates [ProtocolUpdate {protocolUpdateProposal = UpdateProposal {proposalParams = PParams {_minfeeA = SNothing, _minfeeB = SNothing, _maxBBSize = SNothing, _maxTxSize = SNothing, _maxBHSize = SNothing, _keyDeposit = SNothing, _poolDeposit = SNothing, _eMax = SNothing, _nOpt = SNothing, _a0 = SNothing, _rho = SNothing, _tau = SNothing, _d = SNothing, _extraEntropy = SNothing, _protocolVersion = SJust (ProtVer {pvMajor = 3, pvMinor = 0}), _minPoolCost = SNothing, _coinsPerUTxOWord = SNothing, _costmdls = SNothing, _prices = SNothing, _maxTxExUnits = SNothing, _maxBlockExUnits = SNothing, _maxValSize = SNothing, _collateralPercentage = SNothing, _maxCollateralInputs = SNothing}, proposalVersion = Just (ProtVer {pvMajor = 3, pvMinor = 0}), proposalEpoch = EpochNo 83}, protocolUpdateState = UpdateState {proposalVotes = [KeyHash "2414c612dcacf4785346cceb153daf0681e5a0c5a537e1c4727e559b"], proposalReachedQuorum = True}}]}))))))

At epoch where it should take effect we see:
Aug 27 10:35:00 bft-a-1 cardano[523853]: Chain extended, new tip: 86de8b5c414c621e4170b2a755cbb63d15c7228a09199a3ac4db1837fbbb3126 at slot 597600
                                         Event: LedgerUpdate (HardForkUpdateInEra S (S (S (S (Z (WrapLedgerUpdate {unwrapLedgerUpdate = ShelleyUpdatedProtocolUpdates []}))))))

But cardano-cli query protocol-parameters still gives
    "protocolVersion": {
        "minor": 0,
        "major": 2
    }

(on alonzo-qa network: https://hydra.iohk.io/build/7363249/download/1/alonzo-qa-config.json)

Closing this. If this is still relevant please reopen.


Enabling filesystem cache doesn’t output svg when cache is used

Describe the bug
Enabling filesystem cache breaks the plugin (https://webpack.js.org/configuration/cache/). First run is OK but the second one doesn’t output anything.
First run
asset sprite.svg 829 bytes [emitted]
modules by path
  modules by path ./icons/ 191 bytes
    ./icons/icon1.svg 100 bytes [built] [code generated]
    ./icons/blogs/icon2.svg 91 bytes [built] [code generated]

Second run — not even output to the console
To Reproduce
Steps to reproduce the behavior:

Add cache: { type: 'filesystem', } to your webpack config
Run build
Icons are correctly compiled
Re-run build again
Icons aren’t compiled

Expected behavior
Icons compile when cache is used
Additional context
All other svg sprite loaders I tried also suffer from this issue, so not sure how fixable this is.

@patrikholcak Hi. Thank you for your feedback. Please try version 2.2.1.


docs: "OnDestroy" needs to be listed in "implements"

The ngOnDestroy method will not be called unless OnDestroy is declared in the "implements" section of AppComponent

@cstillwell89 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @joarroyo

#sign-off


Progressive Web App Client Side - SEO

Dear Team,
Please help to understand if I have a client website developed by Progressive Web App and I need to work on the SEO Section.
The application is E-Commerce Website and the development company reject to add Website site map or to support our requirements to start working on the SEO Phase.
So please advice how it works and what is the correct information regrading the SEO Section.

sounds like you need a new developer.
The site map is served from the server, not client-side. Content and other assets are also served from the server.
A PWA wont have much direct affect or interference with your SEO. I build PWAs all the time that rank well in search engines.
https://love2dev.com/blog/pwa-seo/


Feat/model update transforms

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits are signed-off.

Description

Changes for OSCAL 1.0.0 rc2 migration
Update test cases data
Update transforms
Update doc (with revised emitted OSCAL)
Add missing input test data?

Closing as not required based on other pulls.


Improve formatting and spacing in android native modules docs

Hi there,
I've been reading this section in great detail. There is some really good content in here, but it can be hard to read when it looks like one big paragraph. This breaks up the text to make it easier on the eyes
Thank you!

( i will get this stuff fixed shortly )


IOS 9 -> navigationbar overlay tableview

Hello. Thanks you for great library, tested ok in IOS 11.
But in IOS9 the navigation bar overlay tableview, i tried to set tableview content insets but it's not working.
In layout interfacebuilder, i set top contraint of tableview to super view = 0, not safe area.
Here is my picture

Hi @fukemy
sorry to hear that, but I see no point in supporting iOS9 at the moment. If you find the specific issue in the code I'll be happy to push a fix, but I'm not going to debug an obsolete version of iOS.

Hi. Thanks you for quick response.
May be other will need it:
if responds(to: #selector(getter: edgesForExtendedLayout)){
                edgesForExtendedLayout = UIRectEdge(rawValue: 0);
            }


Branches structure

What branches to create for the project?
For example:

develop
staging
{version}-release

Thank you very much! 😊

I suggest changing the structure of the project branches by adding the following branches:

master - last release.
develop - for development.