Drawing many rects possible?

Thanks for providing bindings to ImPlot, it seems to have a lot of great potential! :)
(Unfortunately it's not on crates.io, I first searched there and couldn't find it, I only found it by accident.)
I'm familiar with imgui-rs but haven't use implot yet. I need to decide what the best way is to render dynamic data (rendering as ~10k rects each frame).
Is it possible to render something like this with implot?

Does it support the following?

(transparent) rects
with border color different from fill color
border thickness
10k rects without high CPU usage?
text labels anywhere in the "canvas" with flat-colored background to make them more readable
rendering without axes & axis labels

(Unfortunately it's not on crates.io, I first searched there and couldn't find it, I only found it by accident.)

The reason for that is that I'm waiting for a release of implot-rs that includes https://github.com/Gekkio/imgui-rs/pull/339 - until that time, I have to depend on an unreleased version of imgui-rs, which in turn means I can't publish to crates.io. I plan on publishing as soon as that imgui-rs release comes out though.
I've been adding features at a relatively comfortable pace because I've only used the library for myself so far, but I'd try to be as responsive as possible if anyone starts using it more seriously. I'd also be open to adding collaborators to the repo or just getting PRs.

Is it possible to render something like this with implot?

I'll answer to the best of my knowledge so far, but it may be better to ask over at implot itself (https://github.com/epezent/implot) - the author is pretty responsive and will be able to answer your questions in more detail. One thing to note is that I'm currently pointing to an older version of implot-rs. I plan on reaching out to @epezent to ask what the API stability looks like and whether it's a good idea to "move to the current release" now, or if there are major API changes to be expected in the near future.

(transparent) rects

I don't know of a "PlotBox" function in implot, at least not in the release I'm currently wrapping here. Could likely be added though, but that'd have to be done in implot itself and then wrapped here - I'd prefer contributing new functionality to the base library and then wrapping it over adding functionality in the wrapper. You can definitely draw outlines of rectangles with PlotLine, but I guess that's clear and doesn't add filling.

with border color different from fill color

Once 1. is addressed, adding a different border should not be hard - one can draw the outline separately with PlotLine, for example.

border thickness

Lines can have thicknesses and colors, yes.

10k rects without high CPU usage?

This part I'm not that convinced about - especially if drawing things with imgui primitives itself is slow, I'm not sure if ImPlot (which, I presume, uses the same primitives internally) will be faster. The only thing that might be nice is that ImPlot has a feature where the data for plots is culled to only what is visible in the current viewport, so I presume things that are not currently shown are also not drawn.

text labels anywhere in the "canvas" with flat-colored background to make them more readable

Text is supported using PlotText, I don't know about any background feature though.

rendering without axes & axis labels

You can fully turn off axis labels, the grid and ticks, or also customize axis ticks if you like.
@epezent If you happen to read this and spot anything wrong, please correct me!

Closing this due to inactivity.


Bump Dependencies #2745620405

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/2745620405

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Added Anime Api

🎯 Title and Issue Number
Added anime fact api

Closes #274

🗒 Checklist:

[y] I have mentioned the issue number in my Pull Request.
[y]  I have gone through rules of when PR will get merged.
[y] I have commented my code, particularly in hard-to-understand areas
[y] I have created a helpful and easy to understand README.md
[y] I have followed proper file structure.
[y] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @ananyag309, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

Hey @ananyag309, As you are already using the api from the project maintained by someone else, would want that you move this folder under the already existing api's folder. Also please remove the code portion mentioned in README.md

@dishamodi0910 sure i am making the necessary changes

@ananyag309 ,I wanted to reach out and let you know that we have decided to close your pull request.🙇
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣

@dinxsh thank you
please merge it as 10th is the last date @dishamodi0910

@ananyag309 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥
Happy Coding! ✨
Will See you soon❣

@dinxsh @dishamodi0910 please add gssoc and level label too and my name under assignes otherwise the points won't be counted under gssoc please

@Kritika30032002  @dinxsh @dishamodi0910 please add gssoc and level label too and my name under assignes otherwise the points won't be counted under gssoc please

@Kritika30032002 ma'am please help me out!!!

I hope that works now @ananyag309

thank you ma'am


slack-username not respected

slack-username is not respected any more.
❯ git grep -i "slack.*username"
README.md:      --slack-username string               slack username for reboot notfications (default "kured")
charts/kured/README.md:| `configuration.slackUsername` | cli-parameter `--slack-username`                                      | `""`                      |
charts/kured/templates/daemonset.yaml:          {{- if .Values.configuration.slackUsername }}
charts/kured/templates/daemonset.yaml:            - --slack-username={{ .Values.configuration.slackUsername }}
charts/kured/values.minikube.yaml:  # slackUsername: ""         # slack username for reboot notfications (default "kured")
charts/kured/values.yaml:  slackUsername: ""          # slack username for reboot notfications (default "kured")
cmd/kured/main.go:      slackUsername                   string
cmd/kured/main.go:      rootCmd.PersistentFlags().StringVar(&slackUsername, "slack-username", "kured",
cmd/kured/main.go:              "slack username for notifications")
kured-ds.yaml:#            - --slack-username=prod

kured on  main via 🐹 v1.16.12
❯

This came up after #368 (along with #469).
I'm a bit unsure what to do. I feel that going with shoutrrr is the right thing to do, but some "old" setups won't work they used to any more.

Looks like channel is not respected either... at least it looks like it in our deployments 😕

@atighineanu Can you help?

We still have this issue.

upgraded to chart version 1.12.1
changed to --notify-url

slack-username is not respected. Message to slack is sendt as Kured.


K-12 Flag

Include a K-12 filter in each report/chart. This would be connected to the newly added field in the project form.

Related to #1395 in sprint 2

Issue Fixed.


Central app error with Laravel Nova (NotASubdomainException)

Describe the bug
Hello, I'm not 100% sure if this is considered a bug, if not, feel free to redirect me to where I should report this!
I am trying to set Laravel Nova in both my central & tenants domain, I want the following:

website.localhost/nova → handling tenants & its own users
test.website.localhost/nova → handling its own users and other resources

I tried following the documentation and successfully installed Nova, however I'm getting a weird behavior on the central domain.
Following the documentation, I added this to my config nova.middleware  :
    'middleware' => [
        InitializeTenancyByDomainOrSubdomain::class,
        'web',
        Authenticate::class,
        DispatchServingNovaEvent::class,
        BootTools::class,
        Authorize::class,
    ],

When I hit my subdomain  test.website.localhost/nova everything works fine, and I can access nova and see the tenant's users.
When I hit my central app website.localhost/nova I get a NotASubdomainException with error:
Hostname website.localhost does not include a subdomain.

Steps to reproduce

Install Laravel 8 with tenancy
Set central to be website.localhost
Install Laravel Nova
Follow configuration steps from https://tenancyforlaravel.com/docs/v3/integrations/nova/

Expected behavior
I expect to reach nova from my central app and be able to see its own users & tenants.
Your setup

Laravel version: 8.52.0
Laravel Nova version: 3.27.0
stancl/tenancy version: 3.4.4

I'm closing this issue!
The solution was to declare nova routes as Universal Routes :
Added universal to nova.php middleware list, before the InitializeTenancyByDomainOrSubdomain :
'middleware' => [
        'universal',
        InitializeTenancyByDomainOrSubdomain::class,
        'web',
        Authenticate::class,
        DispatchServingNovaEvent::class,
        BootTools::class,
        Authorize::class,
    ],

Thanks to @morloderex !

Hey, I'm trying to do the same thing, the docs are very poor when it come to install nova. I was wondering if you have any kind of guide?
Right now I'm getting the ERR_TOO_MANY_REDIRECTS error on my browser when I try to access https://localhost.test/nova/login
Thanks in advance.

i'm having the same problem @stancl

Hey, I'm trying to do the same thing, the docs are very poor when it comes to install nova. I was wondering if you have any kind of guide? Right now I'm getting the ERR_TOO_MANY_REDIRECTS error on my browser when I try to access https://localhost.test/nova/login
Thanks in advance.

Getting the same Error,  i think this issue should be reopened

Getting the same Error when trying to access In the tenant app
http://foo.localhost/nova

Same error, getting ERR_TOO_MANY_REDIRECTS

Unfortunately, I also get the error message ERR_TOO_MANY_REDIRECTS when I follow these instructions https://tenancyforlaravel.com/docs/v3/integrations/nova/

Nova is already integrated in this repo, so there's no need to follow that guide.
As for the ERR_TOO_MANY_REDIRECTS — that has to be something related to your setup. We regularly use this boilerplate on multiple setups and don't face the issue when following the installation guide step by step.

Any solutions yet?

Hi all, I found a fix, as this doesn't seem to be working. I created a new Middleware with the following code:
/**
     * Handle an incoming request.
     *
     * @param  \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response)  $next
     */
    public function handle(Request $request, Closure $next): Response
    {
        if ($this->isSubdomain($request->getHost())) {
            return app(InitializeTenancyBySubdomain::class)->handle($request, $next);
        }

        return $next($request);
    }

    protected function isSubdomain(string $hostname): bool
    {
        return !in_array($hostname, config('tenancy.central_domains'));
    }

Then placed that inside the middleware array in nova.php, seems to work


Error installing dbt from develop branch on M1

Describe the bug
I'm trying to install dbt on my M1 mac (python 3.9.1) and need to use the Snowflake connector. Based on other issues I saw, I tried to install dbt from the develop branch until the 0.20 release. I got this error:
ERROR: Command errored out with exit status 1: /Users/meeravalliath/.pyenv/versions/3.9.1/envs/dbt/bin/python3.9 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/br/htcj0kr57lsb3s83p4ydqzzh0000gn/T/pip-install-dc7n96yz/grpcio_206327e5a6db4d8d8b8ce737a6021074/setup.py'"'"'; __file__='"'"'/private/var/folders/br/htcj0kr57lsb3s83p4ydqzzh0000gn/T/pip-install-dc7n96yz/grpcio_206327e5a6db4d8d8b8ce737a6021074/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/var/folders/br/htcj0kr57lsb3s83p4ydqzzh0000gn/T/pip-record-k7do0l8o/install-record.txt --single-version-externally-managed --compile --install-headers /Users/meeravalliath/.pyenv/versions/3.9.1/envs/dbt/include/site/python3.9/grpcio Check the logs for full command output.

Steps To Reproduce

pip install git+https://github.com/fishtown-analytics/dbt.git@develop

Expected behavior
Dbt to install without error and be able to connect to Snowflake on my M1 mac.
Screenshots and log output

System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[ ] bigquery
[X] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
zsh: command not found: dbt

The operating system you're using:
macOS Big Sur v11.2.3
The output of python --version:
Python 3.9.1
Additional context
Add any other context about the problem here.

Hey @mvtemple, thanks for opening the issue!
Could you paste the error message text? It's a bit hard to read the screenshot.
Also, are you using the latest versions of pip + setuptools?
pip --version

python3
>>> import setuptools
>>> setuptools.__version__

Hey @jtcohen6, attaching the output of the install command here as the output is quite long. The error occurs while trying to install grpcio.
Confirmed I've updated pip and setuptools to the latest version and am still getting this error.

@mvtemple I believe the dependency on grpcio may be coming from google-api-core here. Could you try installing just the plugin you need:
# from PyPi
pip install dbt-snowflake==0.20.0b1

# from source
git clone https://github.com/fishtown-analytics/dbt.git
cd dbt
pip install -r plugins/snowflake

@jtcohen6 That worked!! Thank you so much for looking into this!


Add withdraw method to stake-cw20-reward-distributor

This new execute message allows the owner to reclaim the reward funds. This would be used by a DAO that wants to change something significant about how rewards are being distributed such as lowering by a large amount or change the contract.

LGTM


test-dump-counters: Test dump-counters via unix-command socket

Ticket
Test for: https://github.com/OISF/suricata/pull/10468
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6732

Interesting approach, but I do have a few concerns..

First, it fails in GitHub CI and when I run locally.
Second, for 8.0 I hope to have the Python Suricata SC gone. Could this be written in terms of the suricatasc command? I plan to have a CLI to replace that, but PR work has only been drafts as of now.

I think simile semi-live tests have been desired in the past, so need to think about how this fits into the bigger picture I think. But getting it passing would be a good start.
Executing: timeout -k 1 10 /home/jason/oisf/dev/suricata/review/src/suricata -v -l /home/jason/oisf/dev/suricata-verify/review/tests/test-dump-counters/output -c /home/jason/oisf/dev/suricata/review/suricata.yaml --pcap=lo --runmode=workers --pidfile=/home/jason/oisf/dev/suricata-verify/review/tests/test-dump-counters/output/suricata.pid --set capture.disable-offloading=false --set capture.checksum-validation=none --set pcap.1.threads=2 --set flow.managers=3 --set flow.recyclers=5 --set stats.interval=1 --set unix-command.filename=/home/jason/oisf/dev/suricata-verify/review/tests/test-dump-counters/output/suricata.sock &
PYTHONPATH=/home/jason/oisf/dev/suricata/review/python /home/jason/oisf/dev/suricata-verify/review/tests/test-dump-counters/test-dump-counters.py --pidfile /home/jason/oisf/dev/suricata-verify/review/tests/test-dump-counters/output/suricata.pid --suricata-socket /home/jason/oisf/dev/suricata-verify/review/tests/test-dump-counters/output/suricata.sock > /home/jason/oisf/dev/suricata-verify/review/tests/test-dump-counters/output/dump-counters.json
Notice: suricata: This is Suricata version 8.0.0-dev running in SYSTEM mode [LogVersion:suricata.c:1147]
Info: cpu: CPUs/cores online: 20 [UtilCpuPrintSummary:util-cpu.c:182]
Info: suricata: Setting engine mode to IDS mode by default [PostConfLoadedSetup:suricata.c:2684]
Info: exception-policy: master exception-policy set to: auto [ExceptionPolicyMasterParse:util-exception-policy.c:200]
Info: ioctl: lo: MTU 65536 [GetIfaceMTU:util-ioctl.c:100]
Info: suricata: Preparing unexpected signal handling [InitSignalHandler:suricata.c:2186]
Info: conf: Running in live mode, activating unix socket [ConfUnixSocketIsEnable:util-conf.c:154]
Info: logopenfile: fast output device (regular) initialized: fast.log [SCConfLogOpenGeneric:util-logopenfile.c:616]
Info: logopenfile: eve-log output device (regular) initialized: eve.json [SCConfLogOpenGeneric:util-logopenfile.c:616]
Info: logopenfile: stats output device (regular) initialized: stats.log [SCConfLogOpenGeneric:util-logopenfile.c:616]
Info: classification-config: Added "43" classification types from the classification file [SCClassConfParseFile:util-classification-config.c:370]
Info: reference-config: Added "19" reference types from the reference.config file [SCRConfParseFile:util-reference-config.c:342]
INFO:root:pidfile and socket appeared
INFO:root:Failed to connect: L178: [Errno 2] No such file or directory
INFO:root:Failed to connect: L178: [Errno 2] No such file or directory
INFO:root:Failed to connect: L178: [Errno 2] No such file or directory
INFO:root:Failed to connect: L178: [Errno 2] No such file or directory
INFO:root:Failed to connect: L178: [Errno 2] No such file or directory
INFO:root:Failed to connect: L178: [Errno 2] No such file or directory
INFO:root:Failed to connect: L178: [Errno 2] No such file or directory
...
INFO:root:Stopping Suricata
===> test-dump-counters: FAILED: got exit code 2, expected 0

PASSED:  0
FAILED:  1
SKIPPED: 0

Thanks, interesting approach, but I do have a few concerns..

:sweat_smile:

First, it fails in GitHub CI and when I run locally.

Did you pick up the fix from https://github.com/OISF/suricata/pull/10468 ? I broke stats in 7.0.x and master, so the CI failures are valid I think. Do I just put the "requires suricata pr" label on it?

Second, for 8.0 I hope to have the Python Suricata SC gone. Could this be written in terms of the suricatasc command?

Oh. Hmm. I guess that could be done. I opted for a bit of Python convenience compared to the shell scripting involved, but I can give that a shot.

so need to think about how this fits into the bigger picture I think.

Yes, totally agree. I was thinking of extending the yaml with some keywords to allow running command in the background and executing commands, but I think that's a project by itself. Seems useful though even if only testing interactions via the unix socket though (rule reloading, pcap submission, ...).

Ok, so figured out the issues.
Running on my workstation, and if I happen to be running from my Suricata build directory, which has also been installed, and ASAN enabled, this times out before all the rules are loaded and Suricata is listening.  Providing an empty rule could prevent this timeout.
I guess my lo is sufficiently busy that I get a wrong_thread errors in the JSON, and these are not yet in the schema, so the test fails out there. Kind of a separate issue, but still needs a fix.

This will fix the schema issue: https://github.com/OISF/suricata/pull/10534

Replaced by https://github.com/OISF/suricata-verify/pull/1676


OCM-5346 | fix: Do not wait for clusters in terminal states to be ready

This PR updates the cluster wait functions to ensure that we only wait for a cluster that is in a state that can become ready. A cluster that is in a state error or uninstalling will never become ready and we can shortcut the waiting function.

lgtm. Would advise to wait for Nir or Danielle review :)

/retest


feat(dashboard): adding dateTime on graphs

Showing date and time on tooltips.

Before
After

Closes #229

I created a ticket here in order to improve tooltip.


Develop - Formik With Validation & Merkle Tree Preview Improvements | Test - Custom Render & Replaced FireEvent With UserEvent

Added

Formik to make form validation work in tests as expected
Title to preview tree cells on hover, created helper functions for their classNames and text
Tests folder to code linting script
Code analysis action
Linting prior to testing

Fixed

Wallet (sign & send) by using global state
Formik issues, such as not being able to show a textarea element properly
Yup validation for amount input - adjusted tests accordingly
Sign tests where tried to verify feedback is present (due to use of Formik) - cleaned up form validation tests in Sign component

Changed

Created a wrapper setup file for testing components

Moved shared import (jest-dom) into jest config (setupFilesAfterEnv).

Replaced fireEvent with userEvent since it:

provides more advanced simulation of browser interactions

Adjusted testing workflow to use NodeJS version 12.

Removed

<canvas>...</canvas> and replaced it with a responsive (bootstrap) table - looks & functions much better. This was done by calculating the preview cell positions given a 9 column layout.

Codecov Report

Merging #14 (61a9fe9) into master (157b2b4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        17    +3
  Lines          297       366   +69
  Branches        56        70   +14
=========================================
+ Hits           297       366   +69

Impacted Files
Coverage Δ

src/components/Block/Statistics.tsx
100.00% <ø> (ø)

src/components/Transaction/TransactionItems.tsx
100.00% <ø> (ø)

src/utils/merkleTree.ts
100.00% <ø> (ø)

src/components/Block/Block.tsx
100.00% <100.00%> (ø)

src/components/Transaction/Send.tsx
100.00% <100.00%> (ø)

src/components/Transaction/Sign.tsx
100.00% <100.00%> (ø)

src/enums/AppDispatchActions.ts
100.00% <100.00%> (ø)

src/reducers/AppReducer.ts
100.00% <100.00%> (ø)

src/schema/SignSchema.ts
100.00% <100.00%> (ø)

src/utils/numberManipulation.ts
100.00% <100.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157b2b4...61a9fe9. Read the comment docs.


Add UDP input and flow Codec

**Is your feature request related to a problem? no
Describe the solution you'd like
I'm working on creating Stitched and deduplicated Cisco Netflow config and to make this more efficient we need udp input and a flow codec to make this more efficient.
Similar to this one codec
https://www.elastic.co/guide/en/logstash/current/plugins-codecs-netflow.html
Will be sharing our config in this repo
https://github.com/Cargill/OpenSIEM-Logstash-Parsing
Describe alternatives you've considered (Optional)
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@brian-grabau , To clarify, I think you are looking for two different features:

A udp source in Data Prepper. This would take in UDP data and create events.
A codec that you would use within the udp source to decode the data into events.

The pipeline configuration might look somewhat like the following:
source:
  udp:
    port: 4000
    codec:
      netflow:

Does sound like what you are looking for?

Yes, udp input and codec of netflow would be perfect


[WIP] Variational Quantum Time Evolution

Summary
This PR introduces Variational Quantum Time Evolution algorithms, imaginary and real, to the algorithms module. It uses variational principles: real McLachlan's, imaginary McLachlan's and real Time Dependent. It supports an option for an error-based ODE function. It is part of the bigger framework for Quantum Time Evolution and implements the relevant interface.
The work is based on the PoC by @Zoufalc which has been significantly redesigned. The correctness has been cross-checked with the PoC.
Relevant papers:
https://github.com/Qiskit/qiskit-terra/pull/7349#issuecomment-985339705
It closes the following epic: #6838 and the following associated issues:

Closes: #6912,
Closes: #6913,
Closes: #6914,
Closes: #6915,
Closes: #6916,
Closes: #6931,
Closes: #7268,
Closes: #7070,
Closes: #7143.

Details and comments
Things still to be addressed in this PR:

[ ] There might be problems with using backends other than statevector_simulator. A change in the gradient framework is necessary. @Cryoris (link issue when created)
[x] Making use of or getting rid of EvolutionResult. (got rid of it because we did not agree on specification yet)
[ ] Adding some more unit tests to cover all parameters options and combinations.
[x] Completing docs for methods, classes and modules.
[x] Completing docs for packages (init files).
[x] Getting rid of print statements.
[x] Adding release notes.
[ ] Fixing pylint.

Things that will be addressed in separate PRs:

Calculating error bounds.
Implementation of the gradient() method in varqrte.py and varqite.py
Saving intermediate results to log files. #6935

Example code for using the algorithm:
        # define a Hamiltonian
        observable = SummedOp(
            [
                0.2252 * (I ^ I),
                0.5716 * (Z ^ Z),
                0.3435 * (I ^ Z),
                -0.4347 * (Z ^ I),
                0.091 * (Y ^ Y),
                0.091 * (X ^ X),
            ]
        ).reduce()

        # define a parametrized initial state to be evolved
        d = 1
        ansatz = EfficientSU2(observable.num_qubits, reps=d)
        parameters = ansatz.ordered_parameters

        # define values of initial parameters
        init_param_values = np.zeros(len(ansatz.ordered_parameters))
        for i in range(len(ansatz.ordered_parameters)):
            init_param_values[i] = np.pi / 2
        param_dict = dict(zip(parameters, init_param_values))

        # define a variational principle
        var_principle = ImaginaryMcLachlanVariationalPrinciple()

        # optionally define a backend
        backend = Aer.get_backend("statevector_simulator")

        # instantiate the algorithm
        var_qite = VarQite(
            var_principle, backend=backend, error_based_ode=False
        )

        # define evolution time
        time = 1

        # run the algorithm/evolve the state
        evolution_result = var_qite.evolve(
            observable,
            time,
            ansatz,
            hamiltonian_value_dict=param_dict,
        )

UML diagram for this feature (click to enlarge):

You are welcome to add comments regarding the code except for issues listed above as not yet completed.

Adding relevant papers
Theory of Variational Quantum Simulation
Error Bounds for Variational Quantum Time Evolution
Variational Quantum Boltzmann Machines - VarQITE for Gibbs State Preparation

Please can you make a complete list of all issues that might be closed by this and the closure of #6838?  I don't see any obviously linked issues referenced in either this PR or that issue.  You can then write a list like:
- Fix #6838
- Fix #...
- Fix #...

which will cause GitHub to automatically close them if the PR merges.

Please can you make a complete list of all issues that might be closed by this and the closure of #6838? I don't see any obviously linked issues referenced in either this PR or that issue. You can then write a list like:
- Fix #6838
- Fix #...
- Fix #...

which will cause GitHub to automatically close them if the PR merges.

Done.

One minor remark: The changes in qiskit/quantum_info/states/densitymatrix.py and  qiskit/opflow/gradients/qfi.py seem to have acted as temporary changes and should be uncommented.

I reverted these changes.

Is it difficult to split it into several PRs? I feel this PR is too big.

Is it difficult to split it into several PRs? I feel this PR is too big.

I agree that it is a good practice to have possibly small PRs. As you see in the first post, we already excluded some elements of Variational Time Evolution to make it possibly basic and smaller.
We could possibly break this one into contributions to the Gradient Framework and to the Variational Time Evolution... We discussed it with @Zoufalc, however, and decided that it is not worth the effort at this stage.
I included a UML diagram in the first post to help understand the whole setup and people can take their time and decide on which parts they might want to give feedback.

This PR will be replaced by a leaner and updated one.


Added LiveStreamingMode parameter to New/Set-CsTeamsMeetingPolicy.md

Closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/9175.
The instance parameter is not available anymore in Set-.

Docs Build status updates of commit 519c9ee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cc76a5b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@dariomws

Docs Build status updates of commit 3a545ec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f6d2f0e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@get-itips @tseward

@get-itips

@tiburd Please merge this PR. Thanks

Docs Build status updates of commit e3cc255:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[stable/elastic-stack] setup issues

Is this a request for help?: yes

Is this a BUG REPORT or FEATURE REQUEST? (choose one): bug/help

Version of Helm and Kubernetes:
$ helm version
Client: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T19:44:19Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.2", GitCommit:"cff46ab41ff0bb44d8584413b598ad8360ec1def", GitTreeState:"clean", BuildDate:"2019-01-10T23:28:14Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
stable/elastic-stack
What happened:
The default install configured ELASTICSEARCH_URL: http://http.default.svc.cluster.local:9200 in the deployment. That left the Kibana pod fail-looping with error Unable to revive connection since there's no such Kubernetes service. I assume it should be http://{{ .Release.Name }}-elasticsearch-client:9200 (or suffixed with .default.svc.cluster.local if you prefer the long DNS name)?! I edited the deployment manually to http://elastic-stack-elasticsearch-client:9200 (where elastic-stack is my chosen release name), and Kibana connected just fine.
If someone googles this issue: for me, this was the reason why the Kibana web interface showed the error "Kibana server is not ready yet".
What you expected to happen:
Working out of the box <naive developer face emoticon>
How to reproduce it (as minimally and precisely as possible):
helm install --name elastic-stack stable/elastic-stack
Anything else we need to know:

It looks like the elastic-stack chart might be rather outdated compared to the most recent individual components. For example, it looks like kibana is pinned at version 1.1.2 (https://github.com/helm/charts/blob/1912822188517fa4c71554b047667d494a85ea2e/stable/elastic-stack/requirements.lock#L5-L7) while the latest version is 1.4.0 (https://github.com/helm/charts/blob/1912822188517fa4c71554b047667d494a85ea2e/stable/kibana/Chart.yaml#L2).
It is also unclear how the configuration is supposed to transfer from the meta chart elastic-stack down to the dependency charts.
For example, this is the default configuration for kibana (https://github.com/helm/charts/blob/1912822188517fa4c71554b047667d494a85ea2e/stable/elastic-stack/values.yaml#L7-L9) in the elastic-stack chart, while the kibana chart has a much more detailed set of options including the files map added about 6 months ago (https://github.com/helm/charts/commit/67aeda73f3bc35200266627635e8138ee48ba195#diff-761d187d0b4be7a6e7099800525bcb80R19) which doesn't seem to be respected.
I've tried the following, for example, but get the same error as @AndiDog (http://http.default.svc.cluster.local:9200 is always set in kibana):
      kibana:
        env: {}
        files:
          kibana.yml:
            ## Default Kibana configuration from kibana-docker.
            server.name: kibana
            server.host: "0"
            elasticsearch.hosts: ["http://elastic-stack-elasticsearch-client.default.svc.cluster.local:9200"]

Errors always look like:
{"type":"log","@timestamp":"2019-02-01T20:05:56Z","tags":["warning","elasticsearch","admin"],"pid":1,"message":"Unable to revive connection: http://http.default.svc.cluster.local:9200/"}
{"type":"log","@timestamp":"2019-02-01T20:05:56Z","tags":["warning","elasticsearch","admin"],"pid":1,"message":"No living connections"}

@AndiDog Can you post your elk-values.yaml file? I'm having the same issue today and want to make sure I understand what all needs to change in the values file since that name appears in multiple places. Thanks.

http.default.svc.cluster.local only appears once 😉 (kibana: section). I ran the chart without any changes, then edited the Kubernetes resource directly. Still a Helm beginner...

I am facing the same issue while installing the elastickstack/stable helm chart

Any update on this issue?

same issue with mac


[REFACTOR][IR] Add Node suffix to low-level IR nodes

This PR adds Node suffix to all the low-level IR containers(see RFC #4648) so that we have a consistent naming convention throughout the codebase.
Ideally we would also move the Node::make function into a Reference class. However, given that the reference classes will have the same name as the original Node class, we propose to wait for
a bit until the codebase stabilizes, before adding the reference class

Node suffix is added to each low-level IR node
Variable-> VarNode

cc @merrymercy @icemelon9 @yzhliu @ZihengJiang


bump VersionSuffix

I am not sure if this project is active or not. You have already bumped PackageVersion, AssemblyVersion,FileVersion and InformationalVersion .
Can you bump VersionSuffix too?

Can you give an example to describe your needs?

Thank you for your reply. I have forgotten why I needed it that time.


Fix Prettier spread values

It's pretty common for us to use the arguments object but leave a comment to explain what the arguments represent. Prettier screws those up.
Desired:
static of (/*...values*/) {

Produced:
static of /*...values*/() {

This was introduced to the codebase in #1123 and hopefully when fixed (https://github.com/prettier/prettier/issues/882 ?) will require a manual pass to cleanup.

I'm glad I went through recent issues and saw a link to here. The comment in parenthesis is fixed in 0.21 (not remember when) but looks like class methods are still broken. I'll open an issue for this!
function f(/* a */) {}
class X {
  f(/* a */) {}
}

outputs
function f(/* a */) {}
class X {
  f /* a */() {}
}

Once https://github.com/prettier/prettier/pull/957 lands,
static of /*...values*/() {

will be normalized to
static of (/*...values*/) {

so you'll just have to run prettier again on your codebase and it'll fix it.

Sweet!

Can be closed now :)


Rename fails to rename implementation reference

For the code below, the rename request at line 7, charpos 22, fails to rename in line 12. For some reason
fortls --debug_rootpath . --debug_rename new_name --debug_filepath testB.f90 --debug_line 7 --debug_char 22
fails with some python error. However, lsp-rename from emacs succeeds in renaming the references on line 7 and 14, but fails on 12 as mentioned.
Also invoking the rename request at line 14, charpos 20 fails the same. But rename at line 12, charpos 20 works.
testB.f90:
module mod

implicit none

type :: t
contains
   procedure :: to_be_renamed
end type t

contains

   subroutine to_be_renamed(self)
      class(t), intent(in) :: self
      call self%to_be_renamed()
   end subroutine to_be_renamed

end module mod

Thanks for the report! This should now be fixed in master and will be included in the next patch. Let me know if you run into any issues.
Please note that change requests are limited to a given object and will not "move through" the link. Therefore an explicit link will be added to the type-binding line to support a consistent rename on one side of the link. For example if you rename the subroutine the link line will become procedure :: to_be_renamed => new_name.


Fix share button not working for some users

Fixes https://github.com/bluesky-social/social-app/issues/5719
Why
This is one that I was unable to reproduce for some time, but was finally able to "accidentally" discover. If you press too long on the "share" button, the dialog actually ends up staying open a tad bit longer. It seems like when that happens, the app isn't able to present the share dialog because the menu sheet is still presented and animating away.
Notably here, we were not calling our menu item onPress inside of the close() function's callback, but rather in parallel. We've seen in the past where its pretty essential to do that, and it seems like this is another one of those cases.
Test Plan
Before this PR, open the share sheet and take a bit longer on pressing the "Share" button. It shouldn't open the share sheet. Then, test this pr and do the same. It should still open.
Also worth checking other buttons like "Translate" to ensure they still work.

If an OTA update happens for 1.93, could this be included please? I've run into it quite a few times by tapping too long 🤦🏻♂

@haileyok I still run into this occasionally, would it be possible to get this in for 1.96 please? 🙏

Thanks so much @estrattonbailey, @haileyok and @roni-castro! :)


Commands corrected in deployments

Description
Binary images are in /bin directory now.
Changes proposed in this pull request:

Deployments corrected

Related issue(s)

/retest

/retest

/retest

/retest

/retest

/retest

/test pre-main-control-plane-gke-integration

/test pre-main-control-plane-gke-integration


Teach check_version.sh about MPI version numbers

See https://github.com/sourceryinstitute/opencoarrays/commit/74debcba9ccf073128b8ed78a70371e6d8fe6c49 for more details.

TODO: handle version numbers in the major.minor format and then
use check_version.sh to verify the version number returne dby
"mpif90 -v".  Currently install.sh instead uses "mpif90 --version"
which returns the version number of the Fortran compiler that mpif90
wraps. No check on the version number of the MPI implementation itself
is performed.

@rouson: Is this issue still relevant? If not let's close it.

I guess not.


Clarify ReScript pipe

The pipe symbol of ReScript is unusual and widely used in the metamath-lamp codebase. Document it with a few examples.

Thanks, done. BTW, I like the -> - it is sweet syntactic sugar, with literally no run-time costs.


Refactored to make it work with Atlassian Bamboo

Found the repo while searching for a formatter that could be used together with Atlassian Bamboo, but could not get Bamboo to accept the report when there were no errors reported (the empty <testsuites>-tag was not enough for it to conclude that everything was fine) so I ended up refactoring it. Just thought I'd pitch it back into this repo if your interested in the changes.
Do note that this was written for a Node 6.9.x environment.

I will make sure to update the tests in the coming days so they pass as well :)

@epavletic sorry for the delay on this. I've been traveling the past week and won't be back for another couple days. will review this asap!

After pondering about it for a few days, I have a few thoughts about the tests, but I'll wait until you've checked the rest before changing anything more :)


Apply defaults to invokes

Fixes #115
This change applies default values as part of Invoke. This is inline with the behavior for resources.

https://github.com/pulumi/pulumi-go-provider/pull/114 has the bulk of the discussion on why this is needed.


bug: Appflow Deploy fails update on certain 2G WiFi Networks

Bug Report
Ionic version:

[x] @ionic/pro ^2.0.3
Current behavior:
Appflow Deploy manual updater will work on most WiFi networks, however some 2G WiFi networks the appflow will pend an update and never follow through. We've launched our software across 100 tablets and know its WiFi network based.
Expected behavior:
For the appflow deploy updater to work regardless of WiFi network type.
Steps to reproduce:
It's random, not exactly sure why appflow decides to fail with certain WiFi networks and its not that the internet is not connected because everything else loads perfectly besides specifically appflow updater.
Related code:
 forceAppUpdate(channelId) {
        return new Promise((resolve, reject) => {
            try {
                Pro.deploy.configure({
                    'channel': channelId
                }).then(() => {
                    Pro.deploy.sync({updateMethod: 'auto'}).then((resp) => {
                        if (!resp) {
                            reject("No response");
                            return;
                        }

                        if (this.currentVersion < resp.versionId) {
                            resolve();
                            // We found an update, and are in process of redirecting you since you put auto!
                        } else {
                            reject("No update available");
                        }
                    }).catch(() => {
                        reject("Sync failed");
                    });
                }).catch(() => {
                    reject("Configure failed");
                });
            } catch (err) {
                reject("forceAppUpdate failed");
            }
        })
    }

I'm also running into this issue and its creating major problems. If this can't be fixed we'll need to find another solution as an alternative to Ionic Appflow for rapid deployment.

Thanks for the issue. If you are running into an issue with AppFlow, please contact AppFlow support. This issue tracker is dedicated to bugs and feature requests for Ionic Framework.


Implement non-function type alias support in AngularDart

This issue tracks support of the non-function type alias feature.  See the enclosing meta-issue for details.
@matanlurey Just a tracking issue for us to validate any work needed in the angular compiler to support this feature.
cc @matanlurey @franklinyow

@matanlurey Is there work we need here?

We don't track internal issues on GitHub, sorry.

Un-assigning as I'm going OOO for quite some time and I don't think there is anything actionable here for us.


Runtime-extensible opsets

Make opsets run-time user-extensible
Add lookup by op-name to opsets
Make opsets able to use factory methods
Add some opset and factory doc

In general LGTM!
2 comments:

Agreed with Ilya, please add NGRAPH_API macros
Please return constant reference for default OpSets, we shouldn't provide a way to change their


Add bugchecks for un-recoverable and or fatal errors, non-terminating 'wait for..'

Describe the bug
We currently have 'asserts' for un-recoverable and/or fatal errors.  These asserts are triggered in debug builds but are compiled out in 'release' builds.
This can often lead to silent failures and/or buggy system behavior in release builds.  Also, considering that most ebpf consumers would prefer running the retail builds (ebpf program verification times are un-acceptably slow in debug builds), the subsequent inconsistent behavior would only end up confusing the ebpf end customers.
We should bugcheck the system and generate a crash dump to debug and fix issues such as:

Un-recoverable errors
Fatal errors
indeterminate 'waits'

OS information
No response
Steps taken to reproduce bug
N/A
Expected behavior
The system should bugcheck and generate a crash dump.
Actual outcome
The failures are ignored and system behavior becomes indeterminate.
Additional details
No response

Need to investigate how crash dumps generated in eBPF binaries in production can be consumed for investigation.


Make dimension of an ndarray a parameter and known at compile time

Current situation
Currently, the dimension of the ndarray is inferred from the shape at the run time. This would lead to extra cost.
Proposal
As the dimension is known at initialisation, it might be nice to make ndim a parameter and known at compile time. Example:
var NDArray[2, DType.float64](1000, 1000, random=True)  # Creating a 1000x1000 2-D array (matrix)

Additional benefits
Making dimension a parameter at compile time may have additional benefits. For example, we can define alias to NDArrays more easily.
alias Vector = NDArray[1, _]
alias Matrix = NDArray[2, _]

That would make NDArray[1,_] and NDArray[2,_] not the same type and add a requirement for casting rules between differently ranked arrays. A good example of this is that a linear-arranged array from 0 to 100 (100) would be a different type than after that array has been reshaped into a square (10x10). Also, there are a good number of operations that need to be able to take arguments of different ranks and then return an array that is not the same rank as the first two.
We want NDArray to be as easy to use as is reasonable to still get the benefits from Mojo. I feel that the better optimization would be to build a Statically Dimensioned/Shaped array separate from NDArray, and allow NDArray` to be more dynamic.  A statically dimensioned/shaped array will require more skill and math knowledge to use correctly but it would do much of its work at compile time. Once Modular adds field declarations to traits we could have a trait that our array types conform to that would allow the parts of the library where the rank doesn't matter to work the same for both, and then write overloads where the difference would be meaningful (statically shaped array matmul would probably be way faster).
Either way, it feels like something we want pre-v1.0 but not necessarily something we want to do in the next few months.

A good example of this is that a linear-arranged array from 0 to 100 (100) would be a different type than after that array has been reshaped into a square (10x10). Also, there are a good number of operations that need to be able to take arguments of different ranks and then return an array that is not the same rank as the first two.

I fully agree. This is a good example of the limitation of the ndim parameter.

I feel that the better optimization would be to build a Statically Dimensioned/Shaped array separate from NDArray, and allow NDArray to be more dynamic.

Yes, that seems to be a better way. We can even define a ArrayLike trait in future so that functions can be applied on NDArray, Vector, and Matrix.

I agree that we should have NDArray and something like StaticNDArray should be separate to make NuMojo more accessible for anyone, this can also be a standout feature. Although it is not important for v0.2, We can start porting things slowly and release once we feel it's good enough. I will make an initial version and create a branch.


How to set the timestep？I want to compare the effect of ESN and LSTM in a time series prediction task

I want to preditct  the daily price of  a stock with several features and compare the prediction effect of ESN and LSTM .
This example  use the price of  today to predict the price of  tomorrow.(timestep=1）
https://github.com/TUD-STKS/PyRCN/blob/master/examples/stock-price-prediction.ipynb
X : ndarray of shape (n_samples, n_features)
Using LSTM, we can use the price in last 10 days to predict the price of tomorrow.(n_timestep=10）
In  tensorflow2.0 ,we reshape the input X into (n_samples, n_timesteps，n_features)
1）How can I set  the n_timestep in PyRCN like LSTM？
（I want to  use the price and it's features  in last 10 days to predict the price of tomorrow.）
2）How can I set the parameters to compare ESN and LSTM？
Should I use the same  number of neurons？
Thank you for your help.

Hi imhithanks,

As you have noticed, X is of shape (n_samples, n_features). If you would like to use the price of the last 10 days (n_timesteps=10), you could create X of shape (n_samples, n_features*n_timesteps), where each sample contains then the price of the last 10 days. I think, numpy provides stride operations, which can be used to create X easily.

Note that you should increase K_in for a multidimensional input. For you, K_in = 5 might be a good choice. Afterwards, you should optimize the hyper-parameters as described in the digits notebook.

You have several opportunities. What I usually do is comparing the trainable parameters of ESNs ((number of neurons + 1)* number of outputs) and other models (LSTM, MLP etc.).

Hi imhithanks,

As you have noticed, X is of shape (n_samples, n_features). If you would like to use the price of the last 10 days (n_timesteps=10), you could create X of shape (n_samples, n_features*n_timesteps), where each sample contains then the price of the last 10 days. I think, numpy provides stride operations, which can be used to create X easily.

Note that you should increase K_in for a multidimensional input. For you, K_in = 5 might be a good choice. Afterwards, you should optimize the hyper-parameters as described in the digits notebook.

You have several opportunities. What I usually do is comparing the trainable parameters of ESNs ((number of neurons + 1)* number of outputs) and other models (LSTM, MLP etc.).

There's still something  I don't quite understand.
For example,  There are daily price of a stock and it's  9 features in 1000 days . n_timestep=10 .
I  create X of shape (1000, 9*10)，Y of shape (1000, 1)
1)K_in should be 9？
param k_in: This element represents the sparsity of the connections between the input and recurrent nodes. It determines the number of features that every node inside the reservoir receives.
I don't understand this parameter. Is it right that k_in=5 means the other 4 features are useless?
2) I want to compare the prediction effect of ESN and LSTM.
I  adjust there parameters on the validation set respectively and compare their MSE on test set.
Is it a right way?

There's still something  I don't quite understand.
For example,  There are daily price of a stock and it's  9 features in 1000 days . n_timestep=10 .
I  create X of shape (1000, 9*10)，Y of shape (1000, 1)
1)K_in should be 9？
param k_in: This element represents the sparsity of the connections between the input and recurrent nodes. It determines the number of features that every node inside the reservoir receives.
I don't understand this parameter. Is it right that k_in=5 means the other 4 features are useless?
2) I want to compare the prediction effect of ESN and LSTM.
I  adjust there parameters on the validation set respectively and compare their MSE on test set.
Is it a right way?

K_in = 5 would mean the each neuron inside the reservoir receives 5 randomly selected features. Every neuron thus receives different combinations of 5 features.

Yes, this is a right way to go.

K_in = 5 would mean the each neuron inside the reservoir receives 5 randomly selected features. Every neuron thus receives different combinations of 5 features.

Yes, this is a right way to go.

@renierts
I got it. There are still several problems.
1)Can I set bi_directional=True in  a time series prediction task？Is there any reference about it？

bi_directional: If True, the input sequences are passed through the network two times, forward and backward.

Must the number of parameters be less than the number of samples
For example , I just have 1000 samples .Can I set reservoir_size=1500？

3）Does different reservoir_activation can make a big difference in prediction effect ?
reservoir_activation: {‘tanh’, ‘identity’, ‘logistic’, ‘relu’}

I hope ESN can perform better than LSTM. But ESN is not better than LSTM on my stock dataset.
From your experience, Does ESN often perform worse than LSTM？
I'm very anxious and don't know how to improve the prediction effect of ESN.

Thank you for your help and patience ！！

@renierts
I got it. There are still several problems.
1)Can I set bi_directional=True in  a time series prediction task？Is there any reference about it？

bi_directional: If True, the input sequences are passed through the network two times, forward and backward.

Must the number of parameters be less than the number of samples
For example , I just have 1000 samples .Can I set reservoir_size=1500？

3）Does different reservoir_activation can make a big difference in prediction effect ?
reservoir_activation: {‘tanh’, ‘identity’, ‘logistic’, ‘relu’}

I hope ESN can perform better than LSTM. But ESN is not better than LSTM on my stock dataset.
From your experience, Does ESN often perform worse than LSTM？
I'm very anxious and don't know how to improve the prediction effect of ESN.

Thank you for your help and patience ！！

Hi imhithanks,

This is strongly task-dependent. As I am not frequently working with time-series prediction, I cannot give you a clear reference. Regarding "Bi-ESN", you can call it that way.
I would strongly recommend to try out various reservoir sizes, e.g. from 50 up to 1000 samples. This is strongly task-dependent.
This is also task-dependent and you should compare the impact of activation functions (as in any neural network).
From my experience with music, ESNs performed similar or even a bit better than LSTMs. You should try to find some reference publications that utilized ESNs for stock price prediction.

Hi imhithanks,

This is strongly task-dependent. As I am not frequently working with time-series prediction, I cannot give you a clear reference. Regarding "Bi-ESN", you can call it that way.
I would strongly recommend to try out various reservoir sizes, e.g. from 50 up to 1000 samples. This is strongly task-dependent.
This is also task-dependent and you should compare the impact of activation functions (as in any neural network).
From my experience with music, ESNs performed similar or even a bit better than LSTMs. You should try to find some reference publications that utilized ESNs for stock price prediction.

@renierts
There are still something i want to learn from you.

I wonder how to explain "the input sequences are passed through the network two times "mathematically.
The Wout is decided when the  sequences are passed through . How does it change when the sequences are passed through backward？
( If i set bi_directional=True,the prediction MSE reduces largely on test set. I wonder if it use the future information )

input_scaling: This element represents the input scaling factor from the input to the reservoir.
For example , input_scaling=5 means that the randomly generated matrix Win is multiplied by 5. Is it right?

In the example below , n_feature=1. I found that I can set K_in=4.What is the other 3 feature?
https://github.com/TUD-STKS/PyRCN/blob/master/examples/stock-price-prediction.ipynb
X : ndarray of shape (n_samples,1)

@renierts
There are still something i want to learn from you.

I wonder how to explain "the input sequences are passed through the network two times "mathematically.
The Wout is decided when the  sequences are passed through . How does it change when the sequences are passed through backward？
( If i set bi_directional=True,the prediction MSE reduces largely on test set. I wonder if it use the future information )

input_scaling: This element represents the input scaling factor from the input to the reservoir.
For example , input_scaling=5 means that the randomly generated matrix Win is multiplied by 5. Is it right?

In the example below , n_feature=1. I found that I can set K_in=4.What is the other 3 feature?
https://github.com/TUD-STKS/PyRCN/blob/master/examples/stock-price-prediction.ipynb
X : ndarray of shape (n_samples,1)

Yes, the sequence is passed through the ESN forward and backward if you set bi_directional=True. Thus, it utilizes future information.
Yes
K_in does not affect the number of features. The result should not strongly change if you increase K_in that example. In the next version of PyRCN, which I have already started, I will throw an error if K_in > n_features.

Yes, the sequence is passed through the ESN forward and backward if you set bi_directional=True. Thus, it utilizes future information.
Yes
K_in does not affect the number of features. The result should not strongly change if you increase K_in that example. In the next version of PyRCN, which I have already started, I will throw an error if K_in > n_features.

@renierts
I see. Thank you for your help！！

@renierts
I see. Thank you for your help！！

You're welcome

You're welcome


Building Lists of Records

I'm submitting a ...

[x] feature request

Building a list of records.

Resolved in https://github.com/RommelTJ/react-pics/pull/6


What is next for LM format enforcer?

Wondering what your plans are for the future.
Perhaps there are further plans to integrate JSON schema and regex? E.g. support the attribute "pattern" inside of the schema:
https://json-schema.org/understanding-json-schema/reference/string

Can't seem to edit it @noamgat. I think you have to allow other to be able to do this.

👍 This would be super useful for URL fields, selecting one of allowed tags, phone numbers etc.
(Sorry, not sure how you wanted enhancement voting to happen @noamgat, I failed to spot any dedicated button for it from the GUI.)

+1 re this feature - I would love to limit the string inside certain fields. Are there any workarounds in the meantime (beyond the most primitive -- doing a narrow regex step followed by a 'convert to json' step)

With the advancements in LMFE in the past few weeks, it is relatively easy to add regex value support to LMFE, with the exception of quoting the " character inside the regex inside a json string field. There is also the concept of regex pattern keys, that would be harder. I'll see if I can get something working in an hour of work.
(My main project is porting the core of LMFE to c++ to get a big performance gain)

I added support for it in a side branch:
https://github.com/noamgat/lm-format-enforcer/tree/feature/json_string_pattern_regex
You can install it by running
pip install git+https://github.com/noamgat/lm-format-enforcer.git@feature/json_string_pattern_regex

Do you want to be the beta testers and check if it works properly?

Awesome! Yes, I'll try it out and report back Monday.

I tried it out, and I don't know if the output failure is due to user error or the code - here is a summary followed by the full code you can run.
I tried the following pydantic model with and without a simple phone number regex pattern:
class ContactInfo(BaseModel):
    name: str
    phone: str = Field(pattern=r"\([0-9]{3}\)[0-9]{3}-[0-9]{4}")
    #phone: str

The prompt
f"""<s>[INST] Could you convert the following contact information into JSON:
Frank Balone
324.512.8920

Please to the following JSON schema:
{ContactInfo.schema_json()} [/INST]"""

Without regex pattern I get
 {
"name": "Frank Balone",
"phone": "324.512.8920"
}

With regex pattern I get
 {
"name": "Frank Balone",
"phone": "3

(there were no errors in the output)
Here is a full code snippet to run (just add your model path):
from pydantic import BaseModel, Field
from vllm import LLM, SamplingParams
from lmformatenforcer import CharacterLevelParser
from lmformatenforcer.integrations.vllm import (
    build_vllm_logits_processor,
    build_vllm_token_enforcer_tokenizer_data,
)
from lmformatenforcer import JsonSchemaParser
from IPython.display import display, Markdown

model_path = MISTRAL_7B_INSTRUCT_AWQ_PATH
llm = LLM(model=model_path)
tokenizer_data = build_vllm_token_enforcer_tokenizer_data(llm)

class ContactInfo(BaseModel):
    name: str
    # phone: str
    phone: str = Field(pattern=r"\([0-9]{3}\)[0-9]{3}-[0-9]{4}")

parser = JsonSchemaParser(ContactInfo.schema())
print(ContactInfo.schema())

sampling_params = SamplingParams()
sampling_params.max_tokens = 1024
logits_processor = build_vllm_logits_processor(tokenizer_data, parser)
sampling_params.logits_processors = [logits_processor]

instruction = f"""Could you convert the following contact information into JSON:
Frank Balone
324.512.8920

Please to the following JSON schema:
{ContactInfo.schema_json()}"""
prompt = f"<s>[INST] {instruction} [/INST]"
results = llm.generate(prompt, sampling_params=sampling_params)

display(Markdown(f"```\n{results[0].outputs[0].text}\n```"))

I think the problem is with the regex - I don't think you need the \ backslashes.
Here is my result (with llama-2-7b-chat, but same code except for the fixed regex):

If the regex is being used (assuming I'm not bungling it), the area code
should be in parentheses, e.g.<PHONE_NUMBER>
On Mon, Jan 8, 2024, 1:59 PM Noam Gat @.***> wrote:

I think the problem is with the regex - I don't think you need the
backslashes.
Here is my result (with llama-2-7b-chat, but same code except for the
fixed regex):
image.png (view on web)
https://github.com/noamgat/lm-format-enforcer/assets/1331304/2b51be91-9b6c-4102-9bbd-190b9e68b723
—
Reply to this email directly, view it on GitHub
https://github.com/noamgat/lm-format-enforcer/issues/32#issuecomment-1881887415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADNPOLQYMVALCY7Y57TFSUTYNRT3BAVCNFSM6AAAAABAFYQED2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRHA4DONBRGU
.
You are receiving this because you commented.Message ID:
@.***>

There were two minor bugs that prevented it from functioning correctly. They were solved, and are in the 0.8.2 release (just released). Please try the latest version and open the issue if problems persist.


[hardening] [java] GCSToJDBC

For RDBMS, hardening goal can be 100GB

As discussed with Shashank last week, I am setting up an AlloyDB cluster and use that as JDBC for testing 100GB load from GCS to postgres.

Many thanks Abhijat for the awesome work.
In my previous tests dataproc templates have taken ~10 mins for a 30GB
database to AlloyDB.
On Wed, Dec 7, 2022 at 4:26 AM abhijat-gupta @.***>
wrote:

I am able to bring down the load time from ~3 hours to 1 hour 15 min for
100 GB. Have tweaked the code to accept another argument for custom spark
partitions in the bin command.
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/dataproc-templates/issues/148#issuecomment-1340894243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYQX6VYLC3YWFXL7TEGED3WMB65RANCNFSM5YMOJGYA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Unable to see my last comment here, hence writing it again -
I am able to bring down the load time from ~3 hours to 1 hour 15 min for 100 GB. Have tweaked the code to accept another argument for custom spark partitions in the bin command.

@hhasija : PR raised. Please review and merge


Add Visual Studio 2022 support

Hi, I'm using Visual Studio 2022 preview, and I can't run flutter on Windows.
I got the error:

On the same computer with installed Visual Studio 2019 everything was working fine.
All the required components for flutter are installed.
The latest Visual Studio version info:

This will require an update here at least: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/windows/build_windows.dart#L25-L28

This will require an update here at least: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/windows/build_windows.dart#L25-L28

Thanks, I will try to fix it today)

How can I debug the flutter project?
I mean the build method, where is the cmake path is checking

See https://github.com/flutter/flutter/wiki/The-flutter-tool#making-changes-to-the-flutter-tool

I'd like to see an update on this.
However, it seems that Flutter uses the CMake binary shipped with VS. Sadly, VS 17 ships with an outdated CMake version (3.20.21032501-MSVC_2) that does not have 'Visual Studio 17 2022' as a valid generator option (It was added in 3.21). So, we'll just have to wait for them to update to 3.21....

Visual Studio 2022 Preview 4 ships with CMake 3.21, please fix this @spnda @LeftTwixWand

@Baneeishaque, thank you for reply! I will check it today)

@timsneath can we confirm this would be a blocker for a stable release? Obviously, we'll want to support it ASAP, but this will involve infra/buildbot upgrades to ensure we're testing all supported configurations in CI.

@godofredoc @keyonghan my recollection is we currently source our VS 2019 install from the Chromium CIPD bundle. Do you know if a Chromium bundle exists for VS 2022, and if not, when we might expect one?

Answer from @godofredoc is that on the devicelab/framework test side we bundle the VS install ourselves. Instructions for creating a new bundle are at go/flutter-infra-vs (Google internal).

There are a couple infra changes remaining to land; in particular https://github.com/flutter/cocoon/pull/1446. Once that's in the remaining work will be:

[ ] Create a VS 2022 bundle following the instructions at go/flutter-infra-vs (Google internal)
[ ] Make the changes necessary to support VS 2022
[ ] Ensure we have enough Windows bots to cover the load of running our Windows tests against a new VS install
[ ] Add a test suite similar to the tests we already execute in framework CI, but using VS 2022

One remaining item would be to determine the impact on plugin repo testing.
/cc @stuartmorgan for comment.

The only impact I can think of would be to make sure that https://github.com/flutter/plugins/blob/master/.ci.yaml#L28 is installing whatever version we want to use there (or to update that line to a pinned version).

\cc @CaseyHillers

With @stuartmorgan's patch, this looks fixed (at least on my machine). I uninstalled Visual Studio 2019 and now just have VS2022;  flutter run -d windows works on a VS2022-only machine running the latest master channel build at the time of writing.
I think this might be good to close when another issue exists for any testing work.

@stuartmorgan's fix allows developers on VS2022 to build and run Flutter apps, but this is still untested and pending infra. As with all Flutter bugs, we'll close this once we have tests in place that prevent a regression.

If filed https://github.com/flutter/flutter/issues/93680 with some non-blocking followup work to avoid users being hit by a caching bug on future Visual Studio upgrades.

FWIW - while I don't think we should close this, since it includes prior discussion and the list of remaining tasks, I do think it's fair to remove this from the blockers list, since at this point, the remaining work is to eliminate the testing tech debt we've accrued here. There are unit tests, but no integration test.

so, which flutter channel that support vs2022? or it is not supported yet?

so, which flutter channel that support vs2022?

master

It works for me!
Thank you guys so much🚀🚀
Should I close the issue, or it's better to wait, when all the remaining task will be completed?

Good to hear! Please leave the issue open; we'll close it once we've upgraded our infrastructure to test with VS 2022; that way we avoid any regressions.

Is there an ETA for when VS22 support will trickle down to the lower branches?

See https://github.com/flutter/flutter/wiki/Flutter-build-release-channels for general information about release schedules.
Support landed after the current beta (2.8) branched, so it will be whenever a version of 2.9 or higher reaches each channel.

Could this be added as a hotfix? Waiting for 2.9 would rule out my ability to use Flutter on a major project we are in the planning stages on. We just upgraded all the developers to 2022 :(

This is not a P0 or P1 issue, so is extremely unlikely to be cherry-picked to 2.8.

Waiting for 2.9 would rule out my ability to use Flutter on a major project we are in the planning stages on.

Keep in mind that the desktop support that is on the stable channel is described as a "beta snapshot". If you are developing for desktop right now you will in general be better off using beta (in which case you only have to wait for the next beta branch, which happens monthly) or even master.
Alternately, my PR is small; you could easily patch it in locally for your own use.

flutter channel master and update flutter sdk

这是来自QQ邮箱的假期自动回复邮件。

您好，我现在因外出有事，无法亲自回复您的邮件。我会在事情处理好后的第一时间回复您。如有急事，可以通过手机或短信的方式联系我。如果给你的工作或生活带来不便，请您原谅。

This is not a P0 or P1 issue, so is extremely unlikely to be cherry-picked to 2.8.

Waiting for 2.9 would rule out my ability to use Flutter on a major project we are in the planning stages on.

Keep in mind that the desktop support that is on the stable channel is described as a "beta snapshot". If you are developing for desktop right now you will in general be better off using beta (in which case you only have to wait for the next beta branch, which happens monthly) or even master.
Alternately, my PR is small; you could easily patch it in locally for your own use.

Does the beta channel also support Visual Studio 2022?

Not yet. It should support VS 2022 when they release the next beta later this month.

For those, who asked about the beta channel. 2.9.0-0.1.pre just have been landed there, so you are free to test it out :)

For those, who asked about the beta channel. 2.9.0-0.1.pre just has been landed there, so you are free to test it out :)

I confirm this worked
Updated to beta channel and it correctly detects Visual Studio 2022

@cbracken do you want to close this bug now and raise a new one for infrastructure, or do you want to update the title to reflect the outstanding work? It's a lil misleading at the moment.

@domesticmouse makes sense; I've opened https://github.com/flutter/flutter/issues/96138 for the infra side.

None works for me.
I have vs2022 in windows 11, what should I do?

Switch to the beta channel. If that doesn't work, open a new issue and describe your problem there.

There are instructions to patch Flutter 2.8 to work with VS2022 here - I haven't done anything extensive but it compiles and runs a basic app

@davidfraser I suspect you could get away with just using the latest flutter beta to regenerate the Windows runner. I can't see anything in the delta between the Flutter 2.8 generated Windows runner and the Flutter 2.10 beta generated Windows runner that would cause backwards incompatibilities.

@domesticmouse The change was to the build command in flutter, not to the template, so regenerating with a newer version won't make 2.8 work.

Ahh, I stand corrected. My bad.


BotframeworkAdapter CreateConversationAsync method fails to create conversation between bots (Bot1 and Bot2)

Using BotframeworkAdapter.CreateConversationAsync to create conversation from Bot1 to Bot2 always fails. The following fails even when using directline.botframework.com as ServiceUrl.
Scenario:
a.	Send message from Bot1 to Bot2 using CreateConversationAsync
b.	Both of them are hosted on localhost,
Bot1 url: "http://localhost:3979/api/messages";  or  "https://directline.botframework.com/";
Bot2  url: "http://localhost:3980/api/messages"; or   "https://directline.botframework.com/";
c.	Forward bot1 activity to bot2
Expected Output: Bot1 is able to Create Conversation with Bot2
            //Code To CreateConversationAsync from Bot1 To Bot2:

            // Credentials of Bot1
            var credentialProvider = new SimpleCredentialProvider("xxx", "yyy");

            var channelProvider = new SimpleChannelProvider(turnContext.Activity.ChannelId);
            var adapter = new BotFrameworkAdapter(credentialProvider, channelProvider);
            var parameters = new ConversationParameters
            {
                Bot = new ChannelAccount("bot1AppID", "HelloWelcomeBot"),
                Members = new ChannelAccount[] { new ChannelAccount("bot2AppID ") },
            };

            parameters.Activity = turnContext.Activity;
            parameters.TopicName = "Forwarded Activity";
            parameters.ChannelData = turnContext.Activity.ChannelData;

            // Create Conversation
            // Bot2 Credentials
            string url = "http://localhost:3980/api/messages";
            var appCredentials = new MicrosoftAppCredentials("www", "zzz");
            MicrosoftAppCredentials.TrustServiceUrl(url, DateTime.Now.AddDays(10));
            if (MicrosoftAppCredentials.IsTrustedServiceUrl(url))
            {
                await adapter.CreateConversationAsync(turnContext.Activity.ChannelId, url, appCredentials, parameters, null, cancellationToken);
            }

Actual Output: Bot2 gets the Http Post message but fails with following callstack:
Actual Output: Bot2 gets the Http Post message but fails with following callstack:
  "name": "Microsoft.ApplicationInsights.Dev.Exception",
  "time": "2018-11-12T17:03:05.1308865Z",
  "tags": {
    "ai.location.ip": "::1",
    "ai.cloud.roleInstance": "simore-laptop",
    "ai.application.ver": "<IP_ADDRESS>",
    "ai.operation.name": "POST /api/messages/v3/conversations",
    "ai.operation.id": "13da7b6b0d50074ab4db75ed70e7feb0",
    "ai.operation.parentId": "|13da7b6b0d50074ab4db75ed70e7feb0.d3aad9b3_5., |13da7b6b0d50074ab4db75ed70e7feb0.d3aad9b3_6.9ff79405_",
    "ai.internal.sdkVersion": "aspnet5c:2.1.1",
    "ai.internal.nodeName": "simore-laptop"
  },
  "data": {
    "baseType": "ExceptionData",
    "baseData": {
      "ver": 2,
      "properties": {
        "DeveloperMode": "true",
        "handledAt": "Platform",
        "AspNetCoreEnvironment": "Development"
      },
      "exceptions": [
        {
          "id": 49607738,
          "typeName": "System.ArgumentNullException",
          "message": "Value cannot be null.\r\nParameter name: uriString",
          "hasFullStack": true,
          "parsedStack": [
            {
              "level": 0,
              "method": "System.Uri..ctor",
              "assembly": "System.Private.Uri, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"
            },
            {
              "level": 1,
              "method": "Microsoft.Bot.Connector.Authentication.MicrosoftAppCredentials.TrustServiceUrl",
              "assembly": "Microsoft.Bot.Connector, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35",
              "fileName": "D:\\a\\1\\s\\libraries\\Microsoft.Bot.Connector\\Authentication\\MicrosoftAppCredentials.cs",
              "line": 128
            },

Console app repro:
using System;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Bot.Builder;
using Microsoft.Bot.Connector;
using Microsoft.Bot.Connector.Authentication;
using Microsoft.Bot.Schema;

namespace TestCreateConversation
{
    class Program
    {
        static void Main(string[] args)
        {
            InitiateConversationWithBot().Wait();
        }

        public static async Task InitiateConversationWithBot()
        {
            string appid = "";
            string password = "";

            var credentialProvider = new SimpleCredentialProvider(appid, password);

            var channelProvider = new SimpleChannelProvider(Channels.Directline);
            var adapter = new BotFrameworkAdapter(credentialProvider, channelProvider);
            string serviceUrl = "https://directline.botframework.com/";
            var bot1 = new ChannelAccount("Bot1", "Bot1");
            var bot2 = new ChannelAccount("Bot2", "Bot2");

            var activity = new Activity()
            {
                Type = ActivityTypes.Message,
                Recipient = bot2,
                From = bot1,
                Text = "TEST Create Conversation",
                ServiceUrl = serviceUrl,
            };
            var parameters = new ConversationParameters
            {
                Bot = bot1,
                Members = new ChannelAccount[] { bot2 },
                Activity = activity,
            };

            var credentials = new MicrosoftAppCredentials(appid, password);
            MicrosoftAppCredentials.TrustServiceUrl(serviceUrl);

             await adapter.CreateConversationAsync(Channels.Directline, serviceUrl, credentials, parameters, CreateCallback(), CancellationToken.None);
        }

        private static BotCallbackHandler CreateCallback()
        {
            return async (turnContext, token) =>
            {
                await turnContext.SendActivityAsync($"inside createcallback");
            };
        }
    }
}

Also repros with the v3 ConnectorClient:
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using Microsoft.Bot.Connector;

namespace TestCreateConversatonV3
{
    class Program
    {
        static void Main(string[] args)
        {
            InitiateConversationWithBot().Wait();
        }

        public static async Task InitiateConversationWithBot()
        {
            string appid = "";
            string password = "";

            string serviceUrl = "https://directline.botframework.com/";
            var bot = new ChannelAccount("bot", "bot");
            var user = new ChannelAccount("user", "user");

            var credentials = new MicrosoftAppCredentials(appid, password);
            var connector = new ConnectorClient(new Uri(serviceUrl), credentials);
            MicrosoftAppCredentials.TrustServiceUrl(serviceUrl);

            //ConversationParameters cp = new ConversationParameters(false, bot);
            //var conversationId = await connector.Conversations.CreateConversationAsync(cp);

            var conversationId = await connector.Conversations.CreateDirectConversationAsync(bot,user);
        }

    }
}

Creating a new conversation with a bot using the ConnectorClient appears to be broken.

Once we understand the issue with v4, can we also understand what the impact is for v3?

Probably related:
CreateDirectConversationAsync throws ArgumentNullException
https://github.com/Microsoft/botbuilder-dotnet/issues/784

The protocol is not intended for communication between bots in this way. And in particular direct line doesn't support create channel.
However, investigating the null exception we have found an issue in the CreatedDirectConversation implementation whereby the serviceUrl can be null and then that causes a later null exception. This has been fixed.

Refer to #1193


ConnectAsync

Hello !
I've been using the library for the TCP connection with Xamarin and in Android I have problems.
In my App I have to simultaneously use 2 IP to the same client, also occasionally do REST requests via HTTP.
I find deadlocks in my application randomly.
Doing debugging, I noticed that the ConnectAsync method goes to dead lock, once invoked, never leaves.
I tried with
myTCPClient. ConnectAsync (hostName, portNumber) await;
and also
**myTCPClient. ConnectAsync (hostName, portNumber) await. Configureawait (false);
**
Known also that even when I invoke the post method of the http client that's deadlocked.
The latter only occurs if I have at least a TCP client connected.
Honestly is unexplainable, or at least didn't understand why!
How long the ConnectAsync function attempts to connect?
You can define the timeout?
Want you to know there are operating system-level constraints regarding number of TCP client for App?

Hey @galex66,
I couldn't tell from your message whether you are reusing the same TcpSocketClient for two different connections - if so I expect that would not work. But if you are using unique clients for each connection then I don't think there should be any problem at all; certainly there should be no restriction in that regard, but I have noticed on Android in particular that from time to time the platform behaves a bit differently.
There is better support for cancelling the connect call in the current prerelease, but you should be able to use this code to put a timeout on your connect call.
Can you let me know whether you are reusing the tcp client? If not, I will do some tests to see if I can reproduce.

Both .Net and WinRT sockets allow tcp ConnectAsync to have a callback in the event of a successful connection. This is very convenient.


Generic amd64

I tested this with the unmanaged OS suite, but we still need to test HUP.
Additionally, I'm open to input on the full name for the DT.
Relevant thread: https://jel.ly.fish/thread-560c1829-a97f-4d1b-8cc6-6320fb1d76b4

@jakogut let's take the name question to the product call, and also whether it should have an amd or intel logo

@jakogut let's take the name question to the product call, and also whether it should have an amd or intel logo

@alexgg I would actually prefer we not acknowledge any specific company in the logo (or maybe both?), given the fact that amd64/Intel 64/x86_64 is derived from technical contributions from both companies, who cross license their patents to each other. I don't know if there's a company agnostic logo available for x86_64.
I do still like generic-amd64 for the slug, as it's faster and easier to type than x86_64, and is consistent with Balena and Docker in the naming of this architecture.
Product call item created. :)

@jakogut I've enabled the generic-amd64 job on PRs for this repo, and we should get leviathan results as well. We can expect HUP to fail since no releases exist, but the other suites should pass.

You need to rename the old machine config:

@klutchell I'm a little confused, it should be renamed. I started this PR by reverting the rename from generic-amd64 to genericx86-64-ext.

@resin-jenkins retest this please

HUP failed as expected, but I've never seen this cloud failure before. Perhaps because the device does not exist in the dashboard in order to create the app? Unmanaged tests passed though which is good.
jenkins-leviathan-v2-template-3664-client-1  | [2022-08-09T00:59:21.197Z][worker-cloud] Getting application config.json...
jenkins-leviathan-v2-template-3664-client-1  | [2022-08-09T00:59:22.151Z][worker-cloud] # Subtest: Managed BalenaOS release suite
jenkins-leviathan-v2-template-3664-client-1  | [2022-08-09T00:59:22.151Z][worker-cloud]     not ok 1 - Application not found: testbot/off5k12z

consoleText4.txt

I agree with your earlier comments that this PR should not be failing, and is currently blocking other PRs.
https://github.com/balena-os/balena-generic/pull/113


[BUG] Fatal: $HOME not set

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
Run bash $GITHUB_ACTION_PATH/get-changed-paths.sh
  bash $GITHUB_ACTION_PATH/get-changed-paths.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_WORKSPACE: /actions-runner/_work/REDACTED-REDACTED/REDACTED-REDACTED
    GITHUB_BASE_REF: main
    INPUT_FILES_PATTERN_FILE: /tmp/0658cf4a-97a5-4014-9815-d0efe86936c9.txt
    INPUT_SEPARATOR:
    INPUT_PATH: .
    INPUT_PREVIOUS_SHA: dc96ac7ba9ca0443172c39b0d5bd545771927b52
    INPUT_CURRENT_SHA: db2490a6da9b81898355bce5389548cbd9e1492d
    INPUT_TARGET_BRANCH: main
    INPUT_CURRENT_BRANCH: feat/live-streaming-documentation
    INPUT_QUOTEPATH: true
    INPUT_INCLUDE_ALL_OLD_NEW_RENAMED_FILES: false
    INPUT_OLD_NEW_SEPARATOR: ,
    INPUT_OLD_NEW_FILES_SEPARATOR:
    INPUT_DIFF_RELATIVE:
    INPUT_DIR_NAMES: false
    INPUT_JSON: false
    INPUT_HAS_CUSTOM_PATTERNS: false
fatal: $HOME not set
Error: Process completed with exit code 128.

To Reproduce

I'm running on an enterprise GH instance 3.5
I have a simple action copied from your example.

- name: Get changed files
     id: changed-files
    uses: tj-actions/changed-files@v33

When I try to trigger your action from a

  pull_request:
      types: [opened, reopened]

What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04
Expected behavior?
Should have counted the files changed on my branch
Relevant log output
Run bash $GITHUB_ACTION_PATH/get-changed-paths.sh
  bash $GITHUB_ACTION_PATH/get-changed-paths.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_WORKSPACE: /actions-runner/_work/REDACTED-REDACTED/REDACTED-REDACTED
    GITHUB_BASE_REF: main
    INPUT_FILES_PATTERN_FILE: /tmp/0658cf4a-97a5-4014-9815-d0efe86936c9.txt
    INPUT_SEPARATOR:
    INPUT_PATH: .
    INPUT_PREVIOUS_SHA: dc96ac7ba9ca0443172c39b0d5bd545771927b52
    INPUT_CURRENT_SHA: db2490a6da9b81898355bce5389548cbd9e1492d
    INPUT_TARGET_BRANCH: main
    INPUT_CURRENT_BRANCH: feat/live-streaming-documentation
    INPUT_QUOTEPATH: true
    INPUT_INCLUDE_ALL_OLD_NEW_RENAMED_FILES: false
    INPUT_OLD_NEW_SEPARATOR: ,
    INPUT_OLD_NEW_FILES_SEPARATOR:
    INPUT_DIFF_RELATIVE:
    INPUT_DIR_NAMES: false
    INPUT_JSON: false
    INPUT_HAS_CUSTOM_PATTERNS: false
fatal: $HOME not set
Error: Process completed with exit code 128.

### Anything else?

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

@alfred-stokespace Given that the error is likely a misconfiguration I'll suggest you take a look at<EMAIL_ADDRESS>particularly noting that the AMI ID is correct.

@jackton1 we have a ubuntu runner on site, are you suggesting I try that?

hmm... I guess I took this as a suggestion runs-on: ubuntu-latest  # windows-latest | macos-latest
I'll give this a try on our ubuntu runner.

Running on ubuntu didn't fix the issue,
this did...
echo "HOME=$(pwd)" >> $GITHUB_ENV
like below
echo "HOME=$(pwd)" >> $GITHUB_ENV
  cat /etc/os-release
  shell: /usr/bin/bash -e {0}
NAME="Ubuntu"
VERSION="20.0[4](https://REDACTED/runs/28849?check_suite_focus=true#step:3:4).4 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
....

The question would be why isn't the HOME env set on the box, If you can take a look at the post generation script here https://github.com/actions/runner-images/tree/b7f276c003aea42575b52247bdb2183e355fca2f/images/linux/post-generation

set:
export HOME="/home/ubuntu"

or
export HOME="/home/root"


Some backends make newly created contexts active

In particular, the unix backend does, but mac, android, and windows do not. This behaviour should be standardized across platforms.

By "active" you mean "current", right?

Correct.


Added "Artificial Intelligence" and "Cybersecurity" to the typed words.

Added "Artificial Intelligence" and "Cybersecurity" to the typed words.
Set the typing to finish on "Computer".

I believe @Daxorinator is very passionate on this addition, so I would ask for @Daxorinator's review before merging.


Change of periodic-gcs-logs-cleanup to use googlecloudstorageclient instead of gsutil

Changing the existing periodic job periodic-gcs-logs-cleanup to use googlecloudstorageclient instead of gsutil to delete the objects older than the specified no. of days in the config file.
Removing the current logic of moving the logs to IBM COS s3 storage as per the below comment:
https://github.ibm.com/powercloud/container-dev/issues/1375#issuecomment-27545024

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Rajalakshmi-Girish
To complete the pull request process, please assign mkumatag after the PR has been reviewed.
You can assign the PR to them by writing /assign @mkumatag in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @mkumatag

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag, Rajalakshmi-Girish
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

key cleanup-gcs-logs-periodics.yaml using file config/jobs/periodic/housekeeping/cleanup-gcs-logs-periodics.yaml

In response to this:

Changing the existing periodic job periodic-gcs-logs-cleanup to use googlecloudstorageclient instead of gsutil to delete the objects older than the specified no. of days in the config file.
Removing the current logic of moving the logs to IBM COS s3 storage as per the below comment:
https://github.ibm.com/powercloud/container-dev/issues/1375#issuecomment-27545024

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Refactor DefaultTheme to be more easily extended

I pulled the internal functions out of getNavigation into a separate NavigationBuilder class so that a custom theme doesn't have to re-implement all of them.
I also changed the default behavior of build to no longer add links to empty modules.  This fixes #1126

This is awesome :+1: I don't have the time to go through and look at it today, but should be able to get to it soon. Thanks!


Kafka table engine

(you don't have to strictly follow this form)
Feature Request
Describe the feature you'd like
May I ask if there will be a new Kafka table engine added?

(you don't have to strictly follow this form)
Feature Request
Describe the feature you'd like
May I ask if there will be a new Kafka table engine added?

What do you mean by new Kafka table engine? ByConity provided one differ from ClickHouse provided.

@Adora627 thx, I originally thought there was no similar functionality to Kafka table engine, but now I see it.


AccessDeniedException: ./world/session.lock

docker-compose.yaml
  smp:
    image: itzg/minecraft-server
    environment:
      EULA: "TRUE"
      TYPE: "PAPER"
      INIT_MEMORY: "1G"
      MAX_MEMORY: "2G"
      VERSION: "1.16.5"
      COPY_CONFIG_DEST: "/data"
      USE_AIKAR_FLAGS: "TRUE"
    volumes:
      - ./smp/config:/config # copy
      - ./smp/plugins:/data/plugins # read/write
      - ./smp/worlds/world:/data/world
    command: --noconsole
    restart: unless-stopped

If ./smp/worlds/world is empty, it will give this error. Don't get confused by AccessDeniedException as it is not a permission-related issue because it can't access due to the empty directory
smp_1          | [01:01:43 FATAL]: Failed to start the minecraft server
smp_1          | java.nio.file.AccessDeniedException: ./world/session.lock
smp_1          |        at sun.nio.fs.UnixException.translateToIOException(Unknown Source) ~[?:?]
smp_1          |        at sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source) ~[?:?]
smp_1          |        at sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source) ~[?:?]
smp_1          |        at sun.nio.fs.UnixFileSystemProvider.newFileChannel(Unknown Source) ~[?:?]
smp_1          |        at java.nio.channels.FileChannel.open(Unknown Source) ~[?:?]
smp_1          |        at java.nio.channels.FileChannel.open(Unknown Source) ~[?:?]
smp_1          |        at net.minecraft.server.v1_16_R3.SessionLock.a(SourceFile:37) ~[patched_1.16.5.jar:git-Paper-790]
smp_1          |        at net.minecraft.server.v1_16_R3.Convertable$ConversionSession.<init>(Convertable.java:257) ~[patched_1.16.5.jar:git-Paper-790]
smp_1          |        at net.minecraft.server.v1_16_R3.Convertable.c(Convertable.java:227) ~[patched_1.16.5.jar:git-Paper-790]
smp_1          |        at net.minecraft.server.v1_16_R3.Main.main(Main.java:154) ~[patched_1.16.5.jar:git-Paper-790]
smp_1          |        at org.bukkit.craftbukkit.Main.main(Main.java:289) ~[patched_1.16.5.jar:git-Paper-790]
smp_1          |        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
smp_1          |        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
smp_1          |        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
smp_1          |        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
smp_1          |        at io.papermc.paperclip.Paperclip.main(Paperclip.java:58) ~[paper-1.16.5-790.jar:?]
smp_1          | 2021-10-21T01:01:43.784Z       INFO    mc-server-runner        Done

Expected Behavior:
Generate a new world

/data is a volume and you can't mount other volumes inside a volume path, such as
      - ./smp/plugins:/data/plugins # read/write
      - ./smp/worlds/world:/data/world

Use the mount points that are documented:

https://github.com/itzg/docker-minecraft-server#optional-plugins-mods-and-config-attach-points
https://github.com/itzg/docker-minecraft-server#cloning-world-from-a-container-path

...or simply attach /data:
      - ./smp:/data

I think I understand what you're wanting, but you're not explaining why the documented solutions won't work for you.
As for downsides to nested volumes within volumes? It doesn't work and/or it's complicated: https://github.com/moby/moby/issues/26051

I want to version control things like paper.yml, bukkit.yml, spigot.yml...
especially server.properties, i keep it my copy in my config directory and copy it to the container because it will get updated by the server.

I think I understand what you're wanting, but you're not explaining why the documented solutions won't work for you.
As for downsides to nested volumes within volumes? It doesn't work and/or it's complicated: moby/moby#26051

i don't have any nested volume mentioned in the ticket. /data is not a mounted volume.

okay, I will mount ./data:/data, and ./config:/config
and then configs will be copied over to /data