Interventions [Rules]

Formulation missing from intervention and alignment with IDMP.
See feature ticket #316
See JIRA 520

@ASL-rmarshall and @dih-cdisc
Can you review my suggestions below?
Updates of the V3 rules that are needed based on the changed attribute names:

CHK0125 and CHK0151: AgentAdministration -> Administration

Additional checks based on change to optional filling Administration frequency, route and dose

If a dose is specified a route is expected and vice versa
if a dose is specified a frequency is expected
Or should we make this a must?

Additional checks based on new additions to the model:

administrableDoseForm coded according to CDISC terminology
AdministrableProductProperty coded according to CDISC terminology
Referenced AdministrableProduct defined within the study version.

I think the rest is all handled by the referential integrity and schema.
Maybe we need to reconsider the required link to ingredient. Do we want to require an ingredient in case of placebo?

@BSnoeijerCD I agree with your suggestions above, with the following additional thoughts:

I agree that frequency is only expected when you have a dose (in the same way that route is only expected). However, if you have a frequency, I don't think it would make any sense not to have a dose.  This suggests that the "vice versa" for frequency could be a "must", but I think it'd be OK for it only to be a warning if we want it to be part of the same rule.
I don't think a specific rule is needed for "Referenced AdministrableProduct defined within the study version". The wording suggests that you're expecting StudyVersion to have an API-only collection of AdministrableProducts. However, given that rules are only applied within the context of a study version, checking that an administrable product is defined within the study version is the same as the generic "referenced id values must be valid" rule that we were discussing on 2024-0816 (#454).
I agree that specifying ingredients should be optional.
I think there may need to be some additional rules - I'll add them as a separate comment below.

@BSnoeijerCD These are my thoughts for additional checks based on this modelling (without my suggested tweaks):

A referenced ingredient must not have any references
An ingredient must not reference itself.
There must be a corresponding strengthsLowerLimit strength for every strengthsUpperLimit of an Ingredient.

We'd need to figure out how to identify a "corresponding" strength.
This check wouldn't be necessary if numerator range were a property of Strength

The unit for the denominator of a strengthsUpperLimit strength is expected to be the same as the unit for the denominator of the corresponding strengthsLowerLimit strength.

We'd need to figure out how to identify a "corresponding" strength.
This check wouldn't be necessary if numerator range were a property of Strength.

If the unit for the numerator of a strengthsUpperLimit strength is the same as the unit for the numerator of the corresponding strengthsLowerLimit strength, then the value for the numerator of the strengthsUpperLimit strength must be greater than the value for the numerator of the corresponding strengthsLowerLimit strength.

We'd need to figure out how to identify a "corresponding" strength.
If numerator range were a property of Strength and the Range class were used, this would be covered by the new rule I've proposed for the Range class (see CHK0198).

If a dose is specified (for an Administration), then an administrable product must also be specified, and vice versa.  (Or is this just a warning?)
A unit must be specified for every strength denominator and numerator.

If numerator range were a property of Strength and the Range class were used and the unit relationship were updated to point to AliasCode instead of Code, then this rule would apply for both Quantity and Range.

The standard code for a unit of a quantity must be coded according to the Unit (C71620) SDTM codelist.

If numerator range were a property of Strength and the Range class were used and the unit relationship were updated to point to AliasCode instead of Code, then this rule would apply for both Quantity and Range.

Are there any situations in which a substanceCode is required for an Ingredient?  If so, we should define a rule.
What's the standard CDISC codelist that will be used in AliasCode.standardCode for Ingredient.substanceCode?  If there is one, we should add a rule.  If there isn't one, we shouldn't use AliasCode - there should just be multiple substanceCodes instead.
Should we try to check for unique ingredients of an administrable product?  If so, should we just use Ingredient.name?  (If so, I think this would be covered by CHK0009).
I don't think we need to check for unique administrable product properties - I'm assuming that you can probably have more than value for a given property, which would be represented as separate instances of AdministrableProductProperty with the same type.  But should we have a rule for unique property values (no more than one property per type/text/quantity)?
How are AdministrableProductProperty text and quantity expected to be used?  It looks like text is required, so what happens when the property value is specified as a quantity?
Do we need a check for non-unique administrable product identifiers (in the same way we have checks for non-unique study identifiers and reference identifiers)?
Should we make denominator required in Strength?  If we don't have a denominator, it'll be difficult to figure out what the strength represents and how it relates to the dose.

@dih-cdisc @ASL-rmarshall
I added the following rules based on the above:

If a dose is specified a route is expected and vice versa
if a dose is specified a frequency must also be specified. (A frequency can also be applicable to another type of intervention (like psychological therapy). So I did not include vice versa.)
if a dose is specified an administrable product must also be specified.
administrableDoseForm coded according to CDISC terminology
AdministrableProductProperty type coded according to CDISC terminology
added rule for a referenceSubstance not having a reference itself
did not add rules for self-referencing as this will be handled by the api (referenced substance will be nested within the substance instance referencing it)
model is updated so strengthsLowerLimit and strengthsUpperLimit are replaced by strength relationship
added rule for units to be specified for numerator and denominator
range class minValue<maxValue rule looks good.
updated rule for unique identifiers within an identified organization to include AdministrableProductIdentifier

Not added

code requirement for substance. They are not always specified in a study definition.
unique substance names are checked with general CHk0009 rule.
required denominator as this is also not required in IDMP as far as I could see.
unique administrable product property types - this could be anything. So we need to learn first what is in here before we restrict this to only 1 per type.

To discuss with PO:

not sure whether aliasCode is specifically intended to have CDISC code as the standard

To discuss with PO:

not sure whether aliasCode is specifically intended to have CDISC code as the standard

No, they can be any code lists, generally CDISC, bit not always. An example is geographic/country codes from ISO. There was a note in the IG but updated to make it clearer

@dih-cdisc @BSnoeijerCD OK - rephrasing the question about the standard codelist for substanceCode (as it was) based on above responses and updated model:

What's the standard codelist that will be used in AliasCode.standardCode for Substance.code? The CT spreadsheet currently says "Point out to multiple Biomedical coding dictionaries such as WHODrug, ATC, UNII, etc.", but doesn't indicate which codelist is the standard one. If there is a standard codelist, we should document the codelist in the CT file and IG, and consider adding a rule (if the codelist is accessible for checking against). If there isn't one, we shouldn't use AliasCode; there should just be multiple codes instead - i.e., a 0..* codes relationship to the Code class (in the same way that we allow multiple StudyIntervention.codes, which has the same "Point out to multiple..." comment in the CT file).

It would probably also be a good idea to change "CDISC code" to something like "term from a standard codelist" in section 4.5 of the IG, which currently says:

Where a CDISC code is demanded by the model but flexibility is needed, users may include other terms (aliases) using the AliasCode class.

It would probably also be a good idea to change "CDISC code" to something like "term from a standard codelist" in section 4.5 of the IG, which currently says:

Where a CDISC code is demanded by the model but flexibility is needed, users may include other terms (aliases) using the AliasCode class.

See comment above "No, they can be any code lists, generally CDISC, bit not always. An example is geographic/country codes from ISO. There was a note in the IG but updated to make it clearer"

@dih-cdisc Apologies - missed that. But the question still remains.  The updated IG says:

Where a standard code (typically a CDISC code but not always) is demanded by the model but flexibility is desirable / needed, users may include other terms (aliases) using the AliasCode class.

When coded, would each substance have a "standard code ... demanded by the model"? I haven't heard or found any mention of a standard codelist for substance that's demanded by the model, so I don't think we should be using AliasCode.
We already have an apparently equivalent relationship for StudyIntervention - in the CT spreadsheet, StudyIntervention.codes has an equivalent description and exactly the same text in the "Has Value List" column:

Y (Point out to multiple Biomedical coding dictionaries such as WHODrug, ATC, UNII, etc.)

The StudyIntervention.codes relationship is defined as a 0..* relationship with Code and, if the relationships are equivalent, I think we should define a Substance.codes 1 -> 0..* Code relationship in the same way, instead of Substance.code 1 -> 0..1 AliasCode.

@dih-cdisc Apologies - missed that. But the question still remains. The updated IG says:

Where a standard code (typically a CDISC code but not always) is demanded by the model but flexibility is desirable / needed, users may include other terms (aliases) using the AliasCode class.

When coded, would each substance have a "standard code ... demanded by the model"? I haven't heard or found any mention of a standard codelist for substance that's demanded by the model, so I don't think we should be using AliasCode.
We already have an apparently equivalent relationship for StudyIntervention - in the CT spreadsheet, StudyIntervention.codes has an equivalent description and exactly the same text in the "Has Value List" column:

Y (Point out to multiple Biomedical coding dictionaries such as WHODrug, ATC, UNII, etc.)

The StudyIntervention.codes relationship is defined as a 0..* relationship with Code and, if the relationships are equivalent, I think we should define a Substance.codes 1 -> 0..* Code relationship in the same way, instead of Substance.code 1 -> 0..1 AliasCode.

Agree, looks like a list of codes rather than an Alias with a single std code plus aliases

@dih-cdisc Apologies - missed that. But the question still remains. The updated IG says:

Where a standard code (typically a CDISC code but not always) is demanded by the model but flexibility is desirable / needed, users may include other terms (aliases) using the AliasCode class.

When coded, would each substance have a "standard code ... demanded by the model"? I haven't heard or found any mention of a standard codelist for substance that's demanded by the model, so I don't think we should be using AliasCode.
We already have an apparently equivalent relationship for StudyIntervention - in the CT spreadsheet, StudyIntervention.codes has an equivalent description and exactly the same text in the "Has Value List" column:

Y (Point out to multiple Biomedical coding dictionaries such as WHODrug, ATC, UNII, etc.)

The StudyIntervention.codes relationship is defined as a 0..* relationship with Code and, if the relationships are equivalent, I think we should define a Substance.codes 1 -> 0..* Code relationship in the same way, instead of Substance.code 1 -> 0..1 AliasCode.

Agree, looks like a list of codes rather than an Alias with a single std code plus aliases

Ok. I will update it in the next push today.


Function overload requires an if statement for TS to parse argument types correctly

🔎 Search Terms
Function overload
🕗 Version & Regression Information
This is the behavior in every version I tried starting at 4.x, as well as the nightly version
⏯ Playground Link
Playground link with relevant code
💻 Code
// Say a function myFunc takes in 2 arguments.
// Both arguments are either strings or booleans.
type MyFunc =
  | [arg1: string, arg2: string]
  | [arg1: boolean, arg2: boolean];
const myFunc = (...[arg1, arg2]: MyFunc) => {}

// myFunc2 has the same input type and invokes myFunc inside
// TS throws an error because it thinks arg1/arg2 can be both string & boolean
const myFunc2 = (...[arg1, arg2]: MyFunc) => {
  myFunc(arg1, arg2)
}

// myFunc3 has the same input type and invokes myFunc inside
// TS doesn't throw an error because myFunc3 has an if statement to separate out string/boolean
// but the if statement is effectively useless since myFunc(arg1, arg2) is always invoked
const myFunc3 = (...[arg1, arg2]: MyFunc) => {
  if (typeof arg1 === 'string'){
    myFunc(arg1, arg2)
  }else{
    myFunc(arg1, arg2)
  }
}

🙁 Actual behavior
TS throws an error for myFunc2 because it thinks arg1 can be both string or boolean  but it should only be either one.
🙂 Expected behavior
TS should not throw an error for myFunc2

Duplicate of #40827.

Duplicate of #40827.

This is a single call signature with a union type for the arguments so it's not actually an overload.  This is closer to https://github.com/microsoft/TypeScript/issues/32639; the type system can't form a dependent narrowing relationship between arg1 and arg2.  You can get around the limitation here by not destructuring:
const myFunc4 = (...args: MyFunc) => {
  myFunc(...args);
}

See also https://github.com/microsoft/TypeScript/issues/30581 and/or https://github.com/microsoft/TypeScript/issues/35873

Thanks all for the pointers and @nmain for the cool workaround, very interesting that not destructuring would make it work 👍

@xitanggg Basically the destructured version fails because the compiler is only looking at the types of values individually, it doesn’t track “where they came from” (a MyFunc in this case), so as far as TS is concerned (prior to narrowing) you’re passing in a newly minted [ string | boolean, string | boolean ]—which isn’t allowed by the call signature because it doesn’t guarantee the elements match.
By not destructuring, you keep a MyFunc around, which is known upfront to be a valid input to the call.

Thanks for the explanation @fatcerberus. Right, this seems like a TS limitation as it doesn't try to loop through the options of call signature.
My actual use case is slightly more complex with where a function with a call signature of an array union calling another function with a call signature of an object union. It seems it would have to destructure to create the object with no easy workaround
type MyFuncObjArgs =
  | {
      arg1: string;
      arg2: string;
    }
  | { arg1: boolean; arg2: boolean };
const myFuncObj = (args: MyFuncObjArgs) => {};

type MyFuncArrayArgs =
  | [arg1: string, arg2: string]
  | [arg1: boolean, arg2: boolean];
const myFunc = (...[arg1, arg2]: MyFuncArrayArgs) => {
  // Have to destructure here to create an object, but Typescript yells
  myFuncObj({ arg1, arg2 });
};

Playground

Right, this seems like a TS limitation as it doesn't try to loop through the options of call signature.

@RyanCavanaugh talks about that often - in general, if something can only be proven safe through manual enumeration of the possibilities, the compiler is most likely going to reject it.  Type safety has to be provable “in the abstract”, so to speak.


Morph border radius

When manually editing CSS styles on example page, border-radius property is not morphed

screenshot

Yes! Last night I created a new border-radius branch to try and solve this issue. It's not totally straightforward - if the elements are the same shape, it works...

...but if they're a different shape, the transform stretches the corners so they don't overlap:

(It's subtle, but you can probably see what I'm talking about - the corners don't quite line up.) So we'll have to compensate for the transform when setting the border-radius (I didn't realise this until just now, but you can use two radii for each corner, which is exactly what we need to compensate for the 'stretch', which is great news because it means that this is in fact possible.)
Hopefully I'll get a chance to work on this soon.
Anyway, to your example: is the original border radius preserved, at least? It looks as though it isn't, but when I do the same thing locally I can see the blue circle beneath the translucent green square. Which is odd...

Right, I think I've got this sussed:

You can also see it in action on the ramjet homepage (iOS grid example at the bottom). Released in 0.4.5

works like a charm :)


Disable screen rotation in all activities

I think that disabling screen rotation instead of forcing portrait mode is better, since if someone is using this app on a device which is running in landscape by default, they will not have to turn it by 90° in order to use the app.
Closes #6 .

Thanks! Yes, that makes sense. I was not thinking of tablets when I created #6. :)


Build Android release whenever the app changes

Also:

Produce a universal APK
Upload that APK to the build artifacts
If this is a release add that APK to the release also

This resolves #140. Thanks to bartekpacia@ for the initial commit.

:D


independant periodic signals

Hi,
I have an issue to create a widget with two independant periodic signals and I've created a gist to demonstrate my problem:
https://try.purescript.org/?gist=b6a4189f977795ed7dd694671b9db8a8
Initially, I've created two signals to drive the movement of my shape : one for the translation (lines 264-270) and one for the rotation (lines 272-275). Unfortunately, my shape in widget1  (lines 277-294) is only modified by rotation because the rotation signal happens sooner than the translation one. I have confirmation of this behaviour in widget2 (lines 293-313) where it is the translation that is triggered sooner, and thus is the only one to drive my shape.
I've designed a library (lines 87-260) to address this issue : it is built around the periodically function which modifies a model by creating a signal from three records : one record for updating the periodic independant signals (lines 330-336 and lines 338-341) of any type, one for the independant periods ({t: 15.0, r: 12.0} line 349) of type Number and one for the current state of the model which is a record having the labels sample and period, should the corresponding quantities have the same labels (translation and rotation here). This way, I can get the expected behaviour in widget3 (lines 343-357) where both translation and rotation are observed simultaneously.
Depending on your thought about this, I'd like to know if you can point me towards an easier way to do that. Otherwise, I'd be glad to propose my library as a contribution.
Thanks

Here's a slightly updated (debugged) and improved (no more use of the pickFn function) version of the library, together with a 3-independant-part signal demo :  https://try.purescript.org/?gist=419deac545741f065dad5e60276cb9fe

Thanks, the example looks very interesting! I'll take a look soon.


French translation

I merged #5

@EragonJ Could you only merge the French translation?

merged at https://github.com/EragonJ/Kaku/commit/e2280e460796ecf001044f36dc066e8ff0adafa1


ZEPPELIN-1897 REST API - Update paragraph text/title via API

What is this PR for?
Support updating paragraph text/title via REST API
https://issues.apache.org/jira/browse/ZEPPELIN-1897
What type of PR is it?
Improvement
Todos
What is the Jira issue?
[ZEPPELIN-1897]
How should this be tested?

Create a note and paragraph
Hit REST API to update the paragraph, e.g. curl -X PUT http://localhost:8080/api/notebook/NOTE_ID/paragraph/PARAGRAPH_ID -d '{"text": "some updated text"}'

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes, doc update included in the change.

@felixcheung I've updated the the PR title to be more clear

also, there are some test failures, could you take a look?

@felixcheung The build seems to be very flaky.
In any case they're passing now https://travis-ci.org/chilang/zeppelin/builds/282217322, except for the web e2e tests in the build #2 (which are also failing on master)

ok, agreed that seems unrelated.
btw, it would be easier for reviewer to track changes if you do not force push
any comment on this PR? I'd wait for a couple of days.


OpenSSL -> OpenTLS

Rename project to openTLS.

This was discussed some time ago
https://github.com/openssl/openssl/issues/6384.

This has been discussed from time to time by the OMC. Whilst there are differing views on this within the OMC I don't think there is sufficient support there to make such a change. I doubt this will happen anytime soon.

Automated Ping: This issue is in a state where it requires action by @openssl/omc but the last update was 45 days ago

There are no plans to make this change, so closing this PR.


Beam_labels of Waymo

Thank you for your outstanding work。
when running
python -m pcdet.datasets.waymo.waymo_dataset --func create_waymo_infos     --cfg_file tools/cfgs/dataset_configs/waymo_dataset.yaml
I meet
Traceback (most recent call last):
  File "/space/chensj/anaconda3/envs/ST3D/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/space/chensj/anaconda3/envs/ST3D/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 388, in <module>
    processed_data_tag=dataset_cfg.PROCESSED_DATA_TAG
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 364, in create_waymo_infos
    used_classes=['Vehicle', 'Pedestrian', 'Cyclist']
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 287, in create_groundtruth_database
    points, _ = self.get_lidar(sequence_name, sample_idx)
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 119, in get_lidar
    beam_labels = beam_labels[NLZ_flag == -1]
IndexError: boolean index did not match indexed array along dimension 0; dimension is 183680 but corresponding boolean dimension is 171606

I try
import numpy as np
lidar_file = '/space/chensj/projects/DTS-main/data/waymo/waymo_processed_data/segment-15832924468527961_1564_160_1584_160_with_camera_labels/0000.beam_labels.npy'
point_features = np.load(lidar_file)
beam_labels_file = '/space/chensj/projects/DTS-main/data/waymo/waymo_processed_data/segment-15832924468527961_1564_160_1584_160_with_camera_labels/0000.npy'
beam_labels = np.load(beam_labels_file).astype(np.int32)  # (N, )

for point_features.shape, I find:
(185289,)
but for beam_labels.shape, I find:
(169035, 6)
so the dims between npy and its beam_labels are not completely matched.
Can you help me solve this problem?

It seems like the 0000.npy is corrupted, have you check the completeness of segment-15832924468527961_1564_160_1584_160_with_camera_labels?

Thank you for your outstanding work。
when running python -m pcdet.datasets.waymo.waymo_dataset --func create_waymo_infos --cfg_file tools/cfgs/dataset_configs/waymo_dataset.yaml  I meet
Traceback (most recent call last):
  File "/space/chensj/anaconda3/envs/ST3D/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/space/chensj/anaconda3/envs/ST3D/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 388, in <module>
    processed_data_tag=dataset_cfg.PROCESSED_DATA_TAG
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 364, in create_waymo_infos
    used_classes=['Vehicle', 'Pedestrian', 'Cyclist']
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 287, in create_groundtruth_database
    points, _ = self.get_lidar(sequence_name, sample_idx)
  File "/space0/chensj/projects/DTS-main/pcdet/datasets/waymo/waymo_dataset.py", line 119, in get_lidar
    beam_labels = beam_labels[NLZ_flag == -1]
IndexError: boolean index did not match indexed array along dimension 0; dimension is 183680 but corresponding boolean dimension is 171606

I try
import numpy as np
lidar_file = '/space/chensj/projects/DTS-main/data/waymo/waymo_processed_data/segment-15832924468527961_1564_160_1584_160_with_camera_labels/0000.beam_labels.npy'
point_features = np.load(lidar_file)
beam_labels_file = '/space/chensj/projects/DTS-main/data/waymo/waymo_processed_data/segment-15832924468527961_1564_160_1584_160_with_camera_labels/0000.npy'
beam_labels = np.load(beam_labels_file).astype(np.int32)  # (N, )

for point_features.shape, I find: (185289,) but for beam_labels.shape, I find: (169035, 6)  so the dims between npy and its beam_labels are not completely matched. Can you help me solve this problem?

Hello, I encountered the same issue. Have you managed to solve it?


Generate-ODTConfigurationXml - OneDrive

Added OneDrive to the list of availabl excluded apps (it worked also without having OneDrive in the list, but just for house keeping pruposes)

Hi @manoth-msft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thank you for the contribution! We have included your edits with another commit so we are not going to merge this Pull Request.  Thanks again.


RELATED_TO relationship in neo4j not found - 404

When running the Backend (java + docker-compose) and Frontend (docker) in the current version with the azure properties file (using gpt-4o) configured and a repo from the local file system ingested, which worked nicely btw, I get the following error when asking a question in the frontend:
Status code 404, "{"error":{"code":"404","message": "Resource not found"}}"
and the following error in the backend:
Neo.ClientNotification.Statement.UnknownRelationshipTypeWarning: The provided relationship type is not in the database.         MATCH (f:FileNode)-[:RELATED_TO]->(c:ConversationNode) WHERE c.id = $conversationNodeId RETURN f                              ^ One of the relationship types in your query is not available in the database, make sure you didn't misspell it or that the label is available when you run this statement in your application (the missing relationship type is: RELATED_TO)
The neo4j graph doesn't have any RELATED_TO relationships currently, only HAS_FILE and MIGRATED_TO

Did I miss any step in the setup?

@JanEisen will have a look

@JanEisen I'm not sure where the problem is stemming from, but I would recommend few steps.

go to the DB

http://localhost:7474/
default username: neo4j
default password: neo4j.password

run command MATCH (n) DETACH DELETE n; - this will wipe the DB
then follow this video for uploading a repo and querying it: https://www.youtube.com/watch?v=4SqG5EA10lo

Please let me know whether this helped.


[BUG]: OLink network tests always fails on Mac

Description of the bug
-------------------------------------------------------------------------------
OLinkHost tests
  Source removal doesn't affect setup. It should inform somehow clients that
  service is not available.
-------------------------------------------------------------------------------
/Users/runner/work/template-cpp14/template-cpp14/goldenmaster/apigear/olink/tests/olinkhost.test.cpp:172
...............................................................................

/Users/runner/work/template-cpp14/template-cpp14/goldenmaster/apigear/olink/tests/olinkhost.test.cpp:188: FAILED:
  REQUIRE( nodes.size() == 1 )
with expansion:
  0 == 1

/Users/runner/work/template-cpp14/template-cpp14/goldenmaster/build/_deps/trompeloeil-src/include/catch2/trompeloeil.hpp:54: FAILED:
  CHECK( failure.empty() )
with expansion:
  false
with message:
  failure := "/Users/runner/work/template-cpp14/template-cpp14/goldenmaster/
  apigear/olink/tests/olinkhost.test.cpp:182
  Unfulfilled expectation:
  Expected *source1.olinkCollectProperties() to be called once, actually never
  called
  "

/Users/runner/work/template-cpp14/template-cpp14/goldenmaster/build/_deps/trompeloeil-src/include/catch2/trompeloeil.hpp:54: FAILED:
  CHECK( failure.empty() )
with expansion:
  false
with messages:
  failure := "/Users/runner/work/template-cpp14/template-cpp14/goldenmaster/
  apigear/olink/tests/olinkhost.test.cpp:182
  Unfulfilled expectation:
  Expected *source1.olinkCollectProperties() to be called once, actually never
  called
  "
  failure := "/Users/runner/work/template-cpp14/template-cpp14/goldenmaster/
  apigear/olink/tests/olinkhost.test.cpp:180
  Unfulfilled expectation:
  Expected *source1.olinkLinked(objectId, ANY(ApiGear::ObjectLink::IRemoteNode*
  )) to be called once, actually never called
    param  _1 == tests.sink1
    param  _2 matching ANY(ApiGear::ObjectLink::IRemoteNode*)
  "

===============================================================================
test cases:   3 |   2 passed | 1 failed

Steps To Reproduce

Run olink tests manually or CI
See https://github.com/apigear-io/template-cpp14/actions/runs/10008342102/job/27670364638?pr=138#step:18:531

Additional Information
No response

more logs here:
https://github.com/apigear-io/template-cpp14/actions/runs/11011505318/job/30575737481?pr=150
still olink host tests are failing


3D viewport control modifier keys acting as toggles when using a Wacom pen

Godot version:
3.2.2 stable win64
OS/device including version:

Windows 10 Pro 19041
Wacom Intuos Pro
Default Godot control scheme
Issue description:
When using the Wacom pen's middle-click button to navigate the 3D view, the modifier keys are acting as toggles.
You can no longer hold ctrl and shift to zoom and pan, you must instead press to activate and then press again to deactivate.
The keys are working as usual with a mouse, and working as usual with the Wacom in 3.2.1 stable.
Steps to reproduce:
Minimal reproduction project:

@profanicus Can you test this with 3.2.2 betas and RCs to narrow down the regression?

Hey @Calinou, no problem!
I checked and the last good version is Godot_v3.2.2-beta2_win64.
One other notable thing that may help, is the state of these toggled modifier keys seems to be remembered between sessions.

Might be related to #38658, CC @bruvzg.

(Assigning 3.2 milestone to track the regression fix for stable, but it's likely also affecting master too.)


core: allow setting max ws rpc connections

Adds --ws-max-connections cli option to set the maximum number of WS connections allowed on the RPC server (defaults to 100).

@andresilva can you give some context on this? I'd rather avoid adding too much CLI options for rpc servers, so maybe we can just increase the default value instead?

poc-3.polkadot.io keeps going down due to amount of web sockets (it's a public RPC server). I'm OK with just increasing the default but not sure by how much.

Code itself looks fine but I'll defer to @tomusdrw on whether it should just be a default or not.

We can't find a good default for this particular use case. AFAIK the issue has been alleviated by banning spammy IPs, but increasing max number of sockets will not make the issue go away, we rather need a proper rate limitting for public services which really shouldn't be part of substrate codebase imho.
That said, I'm ok with merging it if there is no alternatives and the issue persists, however I'd really like to try https://github.com/tomusdrw/jsonrpc-proxy as a proper fix.

oh nice - that looks pretty awesome.

@tomaka yes good point on the jsonrpc-proxy, will be rolling this out. However each backend still only supports 100 websocket connections and it taking a very tiny amount of CPU while doing this. So I don't see any reason not to bump this up by quite a bit as the poc-3.polkadot.io frontend is generating lots of requests.


Slow update

Describe the Bug
With the window opened, I see LTN generating some requests and a train departing from the depot to fulfill it. But nothing shows on the LTN Manager window. I try to click on the refresh buttons, but nothing is refreshed. Enabling auto-updating don't appear to help.
After some 30 seconds the window is synced...
To Reproduce
Steps to reproduce the behavior:

Open GUI for LTN Manager
Wait some action from LTN
Nothing appear on the window
Try to refresh and nothing happens
After a long time (30s) the GUI is refreshed

Log file
Nothing appear on the logs
Thanks

Hi
I have exactly the same problem .
I test to change the configuration of the mod (iterate by ticks ) but it change nothing

@Lolo54001 @Dominiquini does this problem still exist? I did not notice it right now on the latest version. The auto refresh takes one or two seconds.

Hi
I still have the problem ex I build a factory to produce more than one resource when I go to ltn manager (inventory tab) and I look at the quantity of this resource it does not increase (autorefresh is active) I have to wait around 30 second for it to update.
I play space exploration with a mega base (my save is around 2.4G)


Cannot Add New Worksheet

The "+" tab doesn't do anything. No errors in inspection console.

@litopia I know you had this working. May have been broken when things were hooked up

I had it fixed. Still working on some other issues. And i will do a pull request.


Cassandra 19398 5.0

Thanks for sending a pull request! Here are some tips if you're new here:

Ensure you have added or run the appropriate tests for your PR.
Be sure to keep the PR description updated to reflect all changes.
Write your PR title to summarize what this PR proposes.
If possible, provide a concise example to reproduce the issue for a faster review.
Read our contributor guidelines
If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:
<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

Green CI https://app.circleci.com/pipelines/github/bereng/cassandra/1179/workflows/071dd6ba-f55e-4505-b047-9bf1eeca9801/jobs/39136


Pressing 'Enter' on a text element is not entering in edit mode sometimes

Bug Description
Pressing Enter in a selected text element sometimes not put that text element in edit mode.
Expected Behaviour
Text elements selected in display mode should always go to edit mode when pressing Enter.
Steps to Reproduce
Scenario 1:

Select a text element (display mode)
Press Enter
Text element will go to Edit mode
Click outside the text element to leave the edit mode (without unselecting the text element)
Text element will go to Display Mode
Press Enter again

Scenario 2:

Add a text element
Press Enter

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

@barklund Is this related to focus-trapping or don't know yet?


Windows Admin Center: FQDN interpretation cause connection impossible (Server management)

Background:
We have domains AAA.com and BBB.com . Some servers are registered in domain AAA.com, but are accessible from domain BBB.com using BBB.com suffix (but not using AAA.com).
Issue:
I have installed Windows Admin Center on server with domain suffix AAA.com and added server registered in BBB.com domain using AAA.com suffix (=> typed to hostname S1.AAA.com). But server was added to list as S1.BBB.com . Such a hostname (S1.BBB.com) is not pingable from AAA.com domain (S1.AAA.com is), so I am not able to connect to and manage the server,
Can you fix it, please?
Thank you. Ondrej.

Hi @eda2000 thank you for your question. This looks like a question about how to use the product, not feedback on a topic on docs.microsoft.com. Am I interpreting your comment correctly? If so, you have two better options for communicating your question. The first is the "product feedback" button right next to the "documentation feedback" button at the bottom of  every topic. The second is the product forum where experts and product team members can help.
I'm closing this doc feedback but feel free to reply back if I am misunderstanding your question.
Best,
Dawn


[style]: Redesign the text presentation style in about us page

What's the style idea?
We need to improve  the style of text presented in about us page. I mean the text size is too big almost similar to size of logo, that is not good in the sense  of user experience. Hence I want to add some proper style so the size of text automatically gets adjust itself according to screen size. Also to make it more responsive I want to add hovering effect on text as well as on images. The hovering effect is there but only in dark mode.
Because of same sizes in every size of screen it is taking a lot of space, and it is not for user experience as for reading this short content also they need to scroll up, so it will be tiring work.
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hello
could you assign it to me

@Srishtikumari2002 as you have been assigned with other issue, this issue will be assigned to @bhanu17crypto

Hey, if this issue is still not completed, so would you allow me to work on it?


feature request: Import API: add overwrite to collision_strategy

In cartoframes development, we rely on the Import API for updating a table in a user's account.
Having a collision_strategy=overwrite option would make our development cleaner and allow us to offload the complexity of data/map management to CARTO's APIs instead of having to rely on the unintended consequences of dropping a table that a visualization is attached to.
cc @juanignaciosl

cc @noguerol @javisantana

Looks like this is a duplicate of this one: https://github.com/CartoDB/cartodb/issues/9776

Yep, it's similar (although this one doesn't address the naming).
As this is an enhancement, I think that we should ask @kevin-reilly about implementing this.

I'd like to explain the use case, step by step:

Let's say Andy uploads a dataset with Import API and he creates a map with it.
Some time later, he wants to change the data, but...

He could use the SQL API, but as he has a file, it's not straightforward.
He can't just use the Import API, because the table already exists, so he wouldn't override it but create a new one.
He can't drop the dataset before reimporting it, because the visualization would be deleted.
He could just sync file feature from Import API. He could push the new file and then force the sync. This has one obvious limitation: the file must be available at the Internet (an URL, Dropbox...).

@andy-esch what do you think? Am I missing something?
@noguerol what do you think? Does this worth the effort, or should we just encourage using sync tables for this use case?

Makes sense to me but it seems to be more an internal than an external request, so I would love to have @CartoDB/support opinion about the user impact this could have.

@juanignaciosl, that sums it up really well. Being able to swap out an existing dataset with a new one without having the ability to rely on the sync feature of the Import API sums it up really well. This exact issue came up in a meeting we had with a city agency (@zingbot can give more details) where they could not host files on a server or through Dropbox, etc, but wanted to programmatically swap out the old dataset with a new one with proprietary data.

If we want to implement this we should close the scope a lot, specifically about table schema. If the schema does not exactly match I'd raise an error.
To give some perspective. We had (during years) a feature called import append flag. Actually we had that feature in the first version of the editor, it was always disabled and we finally removed it because we didn't implement it. I also heard a lot of times the "replace table" thing

+1 to raise an error if schema changes
--
Jorge Sanz
CARTO - Predict through location
Sent from my phone, excuse my brevity.
El 26 jun. 2017 19:23, "javi santana"<EMAIL_ADDRESS>escribió:

If we want to implement this we should close the scope a lot, specifically
about table schema. If the schema does not exactly match I'd raise an error.
To give some perspective. We had (during years) a feature called import
append flag. Actually we had that feature in the first version of the
editor, it was always disabled and we finally removed it because we didn't
implement it. I also heard a lot of times the "replace table" thing
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/11990#issuecomment-311125502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALfaNS1Z7uFycE_b7aV9sIG5G3U_OVxks5sH-kTgaJpZM4M7mUL
.

Let's do it that way.

Ok. Should this feature be available for FREE users? It's quite similar to sync tables, which is not available for free users.

Interesting. I say no, but @kevin-reilly to decide

FREE users don't have api key at the end of the day so they'd not be able to use it.

In production. Documentation ticket: https://github.com/CartoDB/docs/pull/1245

@andy-esch give this a try at your CartoFrames workflow. If you find bugs or rough edges open a new issue and we'll discuss it.


step-kms-plugin: 0.7.0 -> 0.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/smallstep/step-kms-plugin/releases.
meta.description for step-kms-plugin is: step plugin to manage keys and certificates on cloud KMSs and HSMs
meta.homepage for step-kms-plugin is: https://smallstep.com/cli/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.8.0 with grep in /nix/store/fbn8w4w5nmjnzl9m11fdwqs0dyngy5xp-step-kms-plugin-0.8.0
found 0.8.0 in filename of file in /nix/store/fbn8w4w5nmjnzl9m11fdwqs0dyngy5xp-step-kms-plugin-0.8.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
step-kms-plugin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fbn8w4w5nmjnzl9m11fdwqs0dyngy5xp-step-kms-plugin-0.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A step-kms-plugin https://github.com/r-ryantm/nixpkgs/archive/f703a121c0fc3be1b2fcbbefa670c14b988fd424.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fbn8w4w5nmjnzl9m11fdwqs0dyngy5xp-step-kms-plugin-0.8.0
ls -la /nix/store/fbn8w4w5nmjnzl9m11fdwqs0dyngy5xp-step-kms-plugin-0.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

step-kms-plugin

Maintainer pings
cc @qbit for testing.

Result of nixpkgs-review pr 221747 run on x86_64-linux 1

1 package built:

step-kms-plugin


orca: 3.38.0 -> 3.38.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for orca is: "Screen reader"
meta.homepage for orca is: "https://wiki.gnome.org/Projects/Orca"
meta.changelog for orca is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.38.1 with grep in /nix/store/s2mmbckl8cm7fvr22prxl7vxbgk6bwka-orca-3.38.1

directory tree listing: https://gist.github.com/43ff5e7db55580a094f63e8aec07f0b4

du listing: https://gist.github.com/bf3d93c26bf14bfb818d50933aaf0d01

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gnome3.orca
orca
pantheon.elementary-session-settings

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s2mmbckl8cm7fvr22prxl7vxbgk6bwka-orca-3.38.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A orca https://github.com/r-ryantm/nixpkgs/archive/0c7e325ad7024c668ac6543b473f6bb1afcafd03.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s2mmbckl8cm7fvr22prxl7vxbgk6bwka-orca-3.38.1
ls -la /nix/store/s2mmbckl8cm7fvr22prxl7vxbgk6bwka-orca-3.38.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

2 packages built:

gnome3.orca
pantheon.elementary-session-settings

Maintainer pings
cc @berce @hedning @jtojnar @worldofpeace @dasj19 for testing.

Changes look okay:

#3.38.1 - 3 December 2020
Web:

Fix crash when generating speech for childless math element

General:

Fix bug causing the new radio button group to not be presented
when the group was first entered

New and updated translations (THANKS EVERYONE!!!):
pt            Portuguese              Juliano de Souza Camargo
pt_BR         Brazilian Portuguese    Henrique Machado Campos


Wrong DATABASE_URL format

This changes postgresql:// DATABASE_URL to postgres://

Why do you think postgresql is wrong?

@janpio I run linux and windows and it uses postgres:// as the protocol, as well as some people having the same issue in the Slack channel with this as well. But it could be different in whatever system you guys use

In general Prisma works with both - we just convert to what works.
But the Postgres docs itself define postgresql://: https://www.postgresql.org/docs/10/libpq-connect.html#LIBPQ-CONNSTRING

@janpio if that works for prisma then that's fine. I'm sure most Linux/macOS users will figure it out then. I sure did. Or maybe just add some sort of comments at the top of the page, something like:
If postgresql:// URI gives you issues, try doing postgres://. But it's up you guys at this point.

I am sure it will not give you issues - or we have a bug.
But adding a note somewhere in the docs might be worth it, instead of replacing all uses of it.

Hi folks - I've added a note at the top of this doc

@mhwelander Thanks a lot!


Add Gohufont 11px & 14px, from koemaeda/gohufont-ttf

Hey @braver.
Thank you very much for this great package.
I was looking to get bitmap fonts works in Atom. With your package, we can use Proggy Clean, GNU Unifont. But I was looking for Gohufont.
You were already included Gohufont in resources, but it seems that the version that you included was this one whose ttf files does not seem to be loaded with Atom.
So I removed these two .ttf and added those from @koemaeda, availables here. The LICENCE of this version seems compatible with this reutilization.
Those fonts are available in 11px and 14px sizes. And each one is available on Unicode and Non-Unicode version. I was not sure for the need of both Unicode and Non-Unicode version, so I added both. Maybe @koemaeda can help on this topic.
@braver, I'm pretty sure that .no-smoothing is needed, but can you confirm this ?

Looks great (without the font-smoothing)! I don't see why we would need a non-unicode font though?


Add a pre-commit hook to run a code formatter such as clang-format

In order to avoid malformed code, it would be great to define and use a code formatter such as clang-format
Any preference ? If not I would go for the one used in vk-gl-cts ?

https://github.com/KhronosGroup/VK-GL-CTS/blob/main/scripts/src_util/run_clang_format.py


Make the GUID code a bit more robust

This isn't passing travis on my repo, but not sure why, it's not building at all.

LGTM, thanks!


koji_promote: store correct config

Store a correct config in koji's metadata: its a config of the blob, identified by a digest in the response from the registry

Coverage increased (+0.02%) to 88.023% when pulling bdc33b7076589d9216e54e6bf9da650d81ce4aec on vrutkovs:koji_store_config_fix into 227ac012f111690ec8f3ccb0466950b2fe76d2d3 on projectatomic:master.

Coverage increased (+0.02%) to 88.023% when pulling 8a29395ba7720ad227db5cf4d1c0ea18f08e20e9 on vrutkovs:koji_store_config_fix into 227ac012f111690ec8f3ccb0466950b2fe76d2d3 on projectatomic:master.

Updated the tests (instead of mocking get_manifest_digests function we're mocking request.Response now) and trying out on docker 1.9/1.10

Coverage increased (+0.005%) to 88.003% when pulling 2adae926b43d839c6129c873145ffbf1f56b6934 on vrutkovs:koji_store_config_fix into 227ac012f111690ec8f3ccb0466950b2fe76d2d3 on projectatomic:master.

Coverage increased (+0.005%) to 88.003% when pulling 2adae926b43d839c6129c873145ffbf1f56b6934 on vrutkovs:koji_store_config_fix into 227ac012f111690ec8f3ccb0466950b2fe76d2d3 on projectatomic:master.

Coverage increased (+0.005%) to 88.003% when pulling 8b76a73f60c7d68c60f991c06eeb559d3fcdc6b7 on vrutkovs:koji_store_config_fix into 227ac012f111690ec8f3ccb0466950b2fe76d2d3 on projectatomic:master.


PythonFile2's code is all messed up!

Traceback (most recent call last):
  File "PythonFile2.py", line 16, in <module>
    import PythonFile2
ModuleNotFoundError: No module named 'PythonFile2'

I don't know why you tried to do this. You would need an "os" import to restart the program. I would try to fix it myself but I don't have the time on my hands.

Whoops, Sorry about that. I'll try to fix it.

Don't stress it, I noticed this myself and I'm already working on it.


Html entities encoding problem

It could be impossible to output HTML entity without double encoding. Also, some encoded entities are decoded. It's hard to explain (encodinception) so I made a fiddle:
http://jsfiddle.net/cahnory/663aht7n/
I noticed that hexEntityPattern is /&#x([0-9]+);?/g, I think it should be /&#x([a-f0-9]+);?/ig but this does not fix the issue.

Thank you so much...


Add exception for trying to write DICOM with ImageSeriesWriter

The default behavior of the ITK ImageSeriesWriter with DICOM does not
produce a correct DICOM series. Each file written has a different
series ID, and overrides the physical origin to (0,0,0).
Due to these problems we are disabling writing a DICOM series with
this class.

LGTM - code + documentation and ran it - does what it should.


Add reflection bindings

I think this covers most of the currently available reflection API exposed by ID3D12ShaderReflection.
I've added code comments about this in the change but want to call it out explicitly:

There's a new reflection example and an HLSL file that came from a D3D12 sample for it to load
I've added #[rustfmt::skip] in places where I felt it was clearer without rustfmt
The reflection API I'm adding bindings for is COM-like, in that it returns objects with a vtable pointer, but they don't inherit from Unknown. The com crate doesn't like this, and I've had to implement bindings for these by hand. The lifetime for these pseudo com objects is probably the lifetime of the owning ID3D12ShaderReflection com object. So the safe wrappers contain both the COM-like object and the ref-counted ID3D12ShaderReflection.
I added the enums that are used by the reflection. I used the machine-generated code from the windows crate and did a human pass on them to clean them up. They aren't strictly needed and could be removed from this change. (The constants, not the new types for the enums.

I've used code from the following MIT-licensed sources:

The shader from the D3D12 sample, nearly verbatim (https://github.com/microsoft/DirectX-Graphics-Samples/blob/master/Samples/Desktop/D3D12Multithreading/src/shaders.hlsl)
Enums from the windows crate, but heavily simplified such that they look human-authored instead of machine-authored.

Thanks for the contribution, I haven't looked too deeply yet at the setup / implementation, however, I think the wrapper structs at least should be snake_case rather then how they are defined now.

Im also ok with bumping this to the 2021 edition but we should do that in a separate PR from this one.

I'm not strongly opinionated about it, but I kept the original member names verbatim so that they are easier to locate in documentation.


Use a confined Arena for IOContext.READONCE

Use a confined Arena for IOContext.READONCE.
This change will require inputs opened with READONCE to be consumed and closed on the creating thread. Further testing and assertions will need to be added.
relates #13325

Loopy testing runs without issue for 100+ times ( I just stopped it at that point ).
$ export x=; while ./gradlew :lucene:core:test ; do echo $x | wc -c; export x=x$x; done

When backporting we need to apply same changes for java 19 and 20.

Cool. Seems useful to achieve the goal.
As written in the original issue maybe we should disallow clones, random access and slices of IndexInput on top of that. This may allow us to find more bugs.

Yeah,  we can either pass in a boolean, or something based on MemorySegment::isAccessibleBy. The former seems more straightforward, while the latter seems more flexible to allow slices, etc, but just for the calling thread. But that seems likely incorrect usage and not something we need to add complexity for.

In general we should document thois somehow on the methods in the base class Directory that the IOContext has implications on usage from multiple threads.

++ I'll see if I can find, at least, some minimal wording that we can add here.

I also grepped through source code: https://github.com/search?q=repo%3Aapache%2Flucene READONCE&type=code
It looks like IOContext.READONCE is used at all places we are interested in. ChecksumIndexInput is not compatible to multithreading anyways (you can only read sequentially) and the other ones like reading lifedocs also look correct.
There are some occurrences with index sorting. We should make sure that there is no multithreading (optionally) used.

Maybe run all tests with -Ptests.directory=MMapDirectory; this raises chance that we hit a bug.

loopy testing with -Ptests.directory=MMapDirectory all successfully after several dozen runs.

Looks ok to me. Maybe ask @jpountz for his opinion; maybe he has more ideas where we only work single threaded.

Not sure about this: We could possibly also modify the general Exception handler which catches IllegalStateException and rethrow it as IOException.  We do this already for closed inputs to throw EOFException. Not sure about pros and cons, but when we add more tests and an "official documentation" for the READONCE case, this might be useful.

I believe that this could be a problem for cross-data-structure merging concurrency (which we just disabled, but would like to re-enable soon-ish) since merging uses READONCE. In this case, I'd expect a SegmentReader to be opened in one thread, and then XXXProducer#getMergeInstance() (a clone() optimized for merging) to be called on the thread where the actual merging happens. So while the clone would be consumed in the thread where it's been created, the arena was previously initialized in a different thread?

Merging uses sequential read ahead but from my review it never passes the constant IOContext.READONCE (see the link with references to READONCE above).
Merging uses an IOContext with a MergeInfo attached. This uses same ReadAdvice SEQUENTIAL, but that different to READONCE. Or do I miss something?

Merging uses an IOContext with a MergeInfo attached. This uses same ReadAdvice SEQUENTIAL, but that is different to the Singleton READONCE IOContext. Or do I miss something?

I see same as you @uschindler, however ...
An alternative to modifying the semantics of the existing IOContext.READONCE constant is to add a new constant that indicates both the read-once, sequential, and same-thread semantics. Then opt-in use sites as appropriate, for example, ChecksumIndexInput, etc.

P.S.: Because of this I proposed that READONCE IndexInputs should throw exceptions on clone/slice.

bq. I'm contemplating making MockDirectoryWrapper also fail if IndexInputs get used in a different thread from the one where they were created.
You mean this for READONCE ones, correct?

I updated clone and slice. It finds some issues. These look like incorrect usage of READONCE.

... there's still some intermittent failures because of this. I'll track them down so that we can discuss.

What intermittent failures did you see?

To me those problems where a CFS file was opened with READONCE look like a bug. It is also unlikely that the CFS file is just opened once and then closed again.
If we want to keep the CFS file support, we should at least allow slices of IndexInput. Whenever you create clones its a bug., because those are used in different threads, but slices may be acceptable (e.g. for CFS files).

To me those problems where a CFS file was opened with READONCE look like a bug. It is also unlikely that the CFS file is just opened once and then closed again.
If we want to keep the CFS file support, we should at least allow slices of IndexInput. Whenever you create clones its a bug., because those are used in different threads, but slices may be acceptable (e.g. for CFS files).

Maybe the pending deletes stuff really only wants to open the CFS file to read deleted docs, but this still looks strange to me.

Thanks, looks fine now. I think we can revert the changes to the SegmentReader and look into this in another issue. It still looks strage not me, but I had not time to look closely into the code of the parts which used READONCE on CFS files, that you now changed to DEFAULT.

I am not really sure how we should proceed. The new SegmentReader() which is closed a few lines below looks like a valid use case for READ_ONLY, but SegmentReader creates clones. - damn!
Not sure how we should handle that. Maybe let's remove disallowing of clones and slices, but check that the threads are correct. @jpountz ?
About the CFS files we should really look if we can't get a "better way" to only request a single file from a huge CFS. But this is just an observation we have seen here and has nothing to do with this isse: It seems very bad to mmap a whole huge CFS file just to extract one child file from it in an readonce context. This is an idea for another issue to refactor the CFS Directory to better work with an underlying index input and maybe allow to mmap only slices from begining. This is more complicated to implement but might be worth to look into.

I'm contemplating making MockDirectoryWrapper also fail if IndexInputs get used in a different thread from the one where they were created.

You mean this for READONCE ones, correct?

I meant all IndexInputs actually, they should all be used in the thread where they were created (either via Directory#openInput or IndexInput#clone)? But I'm happy to look into it in a separate issue.

Not sure how we should handle that. Maybe let's remove disallowing of clones and slices, but check that the threads are correct. @jpountz ?

This sounds like ok progress over perferction to me. We can look into getting stricter in a followup.

Thanks for the comments so far. I updated the PR to only check same-thread semantics for MSII clone and slice. And also added some basic thread checks to MockIndexInputWrapper.   I think this is a reasonable improvement and a good place to stop in this PR. As suggested, further improvements can be done as a follow up.


🐛 vue formatter does not recognize vue magic

Environment information
CLI:
  Version:                      1.7.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v20.13.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?
I'm trying to use Biome on Vue3 files and I get some lint/correctness/noUnusedVariables errors on defineProps, defineEmits, defineExpose.
Per the vue docs, these are not actually global functions but macros for the vue compiler.
Expected result
These (and other vue "magic") should not throw an error or there should be some recommendation for how to handle this gracefully.
My current workaround is to put this in the biome.json file. Note this does not detect whether it's in a <script setup> nor the targeted vue version, both of which affect the existence of these macros.
   "overrides": [
      {
         "include": ["*.vue"],
         "javascript": {
            "globals": [
               "defineEmits",
               "defineProps",
               "defineExpose",
               "defineModel",
               "defineOptions",
               "defineSlots"
            ]
         }
      }
   ]

Code of Conduct

[X] I agree to follow Biome's Code of Conduct

Your solution is the correct approach and solution. We suggest this caveat for other files too. Would like to send a PR to the website to document it?

I dislike the workaround and don't love the idea of enshrining it. It's superficial (e.g. it shouldn't but does allow x = defineEmits) and can't provide many of even more semantic checks currently only available in vue-plugin-eslint, e.g. https://eslint.vuejs.org/rules/valid-define-emits.html
Maybe we should just capture this issue for now as low-hanging fruit for when a plugin API debuts.

I can accept a PR to add these globals when the file is vue

I'd like to give this a shot.

Minor update: I haven't been able to get noUnusedVariables to trigger for this, but it does trigger noUndeclaredVariables (which makes a little more sense).
I have a prototype that technically works, but it's a hack in biome_analyze, which is supposed to be language agnostic, so I haven't posted the PR yet.

The fix should be applied to this function
https://github.com/biomejs/biome/blob/main/crates%2Fbiome_service%2Fsrc%2Ffile_handlers%2Fjavascript.rs#L817-L820


Checking of Email should be case-insensitive

When retrieving a lost password, entering user email is case-sensitive. shouldn't be.

Case sensitive e-mail: that's issue in meteor's original accounts package. Also, there is discussion should e-mail be case sensitive or not: https://github.com/meteor/meteor/issues/550


Clean up rules 942180 and 942340

As discussed in #2355, rules 942180 and 942340 both include tests for stuff that's not SQL injection related. These things should be covered by other rules. Move tests to other rules and remove the regex statements that match other things than SQL injection.

There is a lot of discussion around this and I see some need to move these tests.
I am not entirely sure I get which tests. Could you indentify them please @theseion.
Maybe it would also be OK to just drop them. A call we can make when we have defined which ones we are talking about.


Key Reset transaction cost must be 0

The client libraries do not account for special transaction costs of the SetRegularKey transaction. Check this page: https://xrpl.org/docs/concepts/transactions/transaction-cost#special-transaction-costs
At the moment, I believe the reference-transaction-cost of 10 drops will be included with Key Reset transactions. I don't have a test case to prove the behavior.
This special transaction needs to be included in both xrpl-py and xrpl.js libraries.

This is the culprit function: https://github.com/ckeshava/xrpl-py/blob/f182eadc10aa1995cf82aaedff14216fd565ec2d/xrpl/asyncio/transaction/main.py#L424
There's a similarly named function in xrpl.js as well


Python Preview is blank

Python Preview is absolutely blank and shows no previews for anything. Neither the lists are being previewed nor the functions.

The same issue on my side!

I noticed that question #28 solved this problem: Need a global python environment.


Seemingly inefficient queries generated for simple IncludeFilter() scenario

I am wiring up some queries and trying to use the IncludeFilter() to limit the results in a child collection.  In my most basic case, I can’t make sense of the SQL that is being returned.  The query returns more results than are necessary, and though it’s not a major problem in this example, in cases when we are pulling a large set of records, the additional records will hurt performance.  Here is the scenario:
We have 2 tables, in a one-to-many relationship:
Contacts
ContactNotes
As an initial POC, I am trying to pull the most recent ContactNote for each Contact.  Here are 2 examples:

Pull a single contact, and the most recent note:

IQueryable<Contact> query = _db.Contacts
       	.IncludeFilter(c => c.ContactNotes.OrderByDescending(n => n.ContactNoteId).Take(1))
       .Where(c => c.ContactId == 1);

The generated SQL query returns what I would expect: a single row, with Contact columns first, followed by columns for the most recent ContactNotes record.

Pull a list of contacts, and the most recent note for each:

var contactIds = new List<int>() { 1, 2, 3 };

IQueryable<Contact> query = _db.Contacts
    	.IncludeFilter(c => c.ContactNotes.OrderByDescending(n => n.ContactNoteId).Take(1))
        .Where(c => contactIds.Contains(c.ContactId));

I would think this query could be written in such a way as to retrieve only 3 rows, much like the previous example.  However, I get 9 rows of data.  Again, this isn’t a major deal here, but when I am returning thousands of records, and including additional tables, the extra overhead is a problem.
I assume I am using this correctly, so just wanted to get your thoughts on this.  Thanks!
Query2.txt
Query1.txt

Hello @mcdonams ,
Unfortunately, we don't create the SQL query, we only create a project and get the result from the SQL generated by Entity Framework.
I suggest you to use instead IncludeOptimized instead of IncludeFilter. You can also filter the Include part.
Wiki - Include Optimized
By using the IncludeOptimized, 6 rows will be returned. 3 rows for the contact and 3 rows for the contact notes.
So if you need to return 1000 contact, 2000 rows will be returned in your example.
Let me know if this suggestion is good for your scenario.
Best Regards,
Jonathan

Thanks for the response!  I'll take a look at IncludeOptimized() and see how it fits as well.


Help testing separated classes stub functions

Any clue(if possible) on how to unit testing something like this? The idea is having the classes in different files to not cram up the chaincode.ts and also test separately both chaincode.ts and car.ts without dependency between them.
is it possible or put/getState must be mocked manually?
car.ts
import { ChaincodeStub } from 'fabric-shim';
export class Car {
    id: string;
    model: string;
    owner: string;

    constructor(
        id: string,
        model: number,
        owner: string
    ){
        this.id = id;
        this.model = model;
        this.owner = owner;
    }

    function save(stub: ChaincodeStub){
        <logic>
        return await stub.putState(this.toString()); //how to test this solely w/o doing the invoke?
    }

    function get(stub: ChaincodeStub){
        <logic>
        return await stub.getState(this.id); //how to test this solely w/o doing the invoke?
    }
}

chaincode.ts
import shim = require('fabric-shim');
import { ChaincodeStub } from 'fabric-shim';
import { Car } from './car';

export class  Chaincode {
    async Init(stub: ChaincodeStub) {
        //do nothing for now
        return shim.success();
    }

    async Invoke(stub: ChaincodeStub) {
        console.log('Transanctions ID: ' + stub.getTxID());
        const ret = stub.getFunctionAndParameters();
        const args = ret.params;
        const method = this[ret.fcn];
        if(undefined == method){
            console.log("There's not such method");
            return shim.error(Buffer.from('not such method'));
        }
        try{
            console.log(`=============== ${ret.fcn} ================`);
            const result = await method(stub, args);
            return shim.success(result);
        }catch(err){
            return shim.error(err.message);
        }
    }

    async saveCar(stub: ChaincodeStub, args: Array<string>){
       //this two are mocked to only test the whatever logic is before
        const car = new Car(<params>)
        return await car.save();
    }
    async getCar(stub: ChaincodeStub, args: Array<string>){
       //this two are mocked to only test the whatever logic is before
        const car = new Car(ID);
        return await car.get();
    }
}

Easy, you can test the Car service class by calling it the same way as in your saveCar method. Instead of the passing the actual chaincodeStub, you can pass your mock chaincode const stub = new ChaincodeMockStub('mock', chaincode);. You can then do some expecting on that mockstub to see if the correct value was set.
Also, I think it should be return await car.save(stub);, right?

umm, i think i got it, I'll try to test it,
Yeah, it was kind of pseudo code, so there may be mistakes😅
Also thanks for the speed answering!

@Superjo149 Perfect!! the only missing part was that to be able to perform the putState the txID must be set, so a mockStub.mockTransactionStart('tx1'); is needed, resulting in something like:
    it('Should save the car', async function() {
        const chaincode = new Chaincode();
        const mockStub = new ChaincodeMockStub('mockChaincode', chaincode);
        mockStub.mockTransactionStart('tx1');
<...>
        const car = new Car(<...>);

        console.log(await check.saveCar(mockStub));
    });

Now to check the possible asserts...
Thanks again!


Improve documentation to explain that Inverted Sections uses falsy

The documentation (here and here) explains:

The block of an inverted section is rendered only if the value of that section's tag is null, undefined, false, or an empty list.

they will be rendered if the key doesn't exist, is false, or is an empty list.

But the spec says

If the data is not of a list type, it is coerced into a list as follows: if the data is truthy (e.g. !!data == true), use a single-element list containing the data, otherwise use an empty list.

(From issue #186)
The documentation should be more clear that the inverted section uses falsy. Personally I was confused when a value of 0 was triggering the inverted section (I read the docs thinking "is" is like ===).

If no one offers to send a PR, I'll assign this to myself.

Fixed with 5f06df20d20aee2


landing strip reporter breaks in iTerm

and possibly others

I have iTerm2. I tried this on mocha's own source code:
./bin/mocha -R landing

Worked fine.

Upgraded iTerm2 to Build <IP_ADDRESS>20123 and it still worked on mocha's source. I have no specific settings. What OS (OS X version) are you using?

MacOSX 10.7.2
I forgot to mention that I use zsh as default shell prompt, although it still happens when i change to bash
not quite sure what else I can say, I believe i don't use any other weird setting beside the zsh instead of bash

I have the same version of OS and I use zsh as well.
Can you paste what you have in the terminal when you try running the specs with the landing reporter. Also could you run the specs on Mocha's own source code with the same command I used above.

http://cl.ly/011p1k0q1P262f280m1T
http://cl.ly/2C3i2m271Z3b163W3G2D
This is what I get normally...
using the same command that you did results in a "no such file" I installed mocha using npm -g so i guess the binary is somewhere else.


cruft: remove copy_without_render

https://github.com/iterative/cookiecutter-dvc-plugin/pull/6

Apparently there are some dependency resolution issues, a dvc version pre 2.27.0 is installed, which doesn't include the testing extra. Looking into it.

I think this is due to dvc-http being pinned to 2.19.0 in the dvc repo: one cannot pip install .[tests] and dvc because the latter requires dvc-http==2.19.0, thus we end up installing dvc==2.18.0 which is the first available version with no dvc-http dependency.
Bumping its version here and in dvc should fix the issue, although I think we'll need to fix this issue properly, as it impacts all plugins. c.c. @efiop


Add info about integerDigits feature

I've not been able to find any documentation about the integerDigits feature: however it was mentioned in the issue tracker and so I was able to use it.
I thought it could be a good idea to add an example here.
(I'm new to GitHub and its policies, so if I'm doing something not correct, please forgive me but let me know)

@insac ,
Thx !!
I need to document the aliases, but did not took the time yet.


UI update

Lgtm. Let's merge this after the issue at thermal_base are closed, since there'll be some changes to the styling required here too post that
@renilthomask can you try running this once before we merge it, provide recommendations on improving it? You can test the version available at https://github.com/mukheshpugal/Thermal_Image_Analysis

Added features discussed in yesterday's meeting

@mukheshpugal  - now that thermal_base's PR is merged, will the import structure here have to change?

Fixed the import structure.


Create GitHub issue and pull request templates

Related Issue (required)

Description (required)

[#917] Create GitHub issue and pull request templates
Review Procedure (required)

This PR creates a pull request and issue templates. It guides Delta users to report issues and contribute code more efficiently.
Related PR (optional)

Pre-Review Checklist for the PR Author (required)

[ ] Read commit-guidelines
[ ] Assign PR to reviewer
[ ] Target branch set correctly. Default: master
[ ] Fill out all the required sections

[ ] Related Issue
[ ] Description
[ ] Review Procedure
[ ] Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer (required)
Only the reviewer is allowed to make changes in this section!
Reviewers should check the checkboxes below before approval.

Basic Checks

[ ] Commits are properly organized and messages fully satisfy the guideline
[ ] PR title describes the changes

Code correctness

[ ] The problem/feature is solved (reproducibly)
[ ] The solution is performant enough for the use case in mind

Post-Review Checklist for the PR Author (required)
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues
[ ] Close the issue if this PR resolves the issue (e.g. close #〇〇)

Hi @ahlag, I saw your comment on #917, is this ready for review? (If so, could you remove the [WIP] tag?) Thanks!

@allisonport-db
I am sorry for the late reply. Yes, it is ready for review.

Testing will depend on the pull request. It often will be unit tests, but could also include performance tests, stress tests, manual testing, or more. This section is where the contributor will clarify how they tested the changes introduced in the pull request (which could be any combination of the above). Hope that helps.
Also, please resolve the conversations once you address the comments. It'll make it easier to keep track of our conversations. Thanks!

@allisonport-db
I have submitted the changes. Could you please review?

@allisonport-db
Thank you for your time. I have finished the corrections you requested except for the pending sections. Please let me know if there's any more correction you need on your end.

@allisonport-db
Ok, done.

@allisonport-db
Ok, done.


Fixed bug in PersonDirectory

This change is

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

app/src/main/java/edu/byu/suite/features/personDirectory/controller/PersonDirectoryMainActivity.java, line 220 at r1 (raw file):

					return;
				}
				showErrorDialog(byuError.getReadableMessage(), null);

This used to be like this (passing in null as the onClickListener) but then Hammad changed it, and I'm not sure why. It should definitely be null. I think Hammad doesn't realize that showErrorDialog("error", null) is not equivalent to showErrorDialog("error"). I'll send him a message explaining that.

app/src/main/java/edu/byu/suite/features/personDirectory/controller/PersonDirectoryMainActivity.java, line 232 at r1 (raw file):

			enqueueCall(createCall(), new ByuCallback<PersonResponseWrapper>(this) {
				@Override
				public void onSuccess(Call<PersonResponseWrapper> call, Response<PersonResponseWrapper> response) {

This part was a bug

app/src/main/java/edu/byu/suite/features/personDirectory/controller/PersonDirectoryMainActivity.java, line 243 at r1 (raw file):

				@Override
				public void onFailure(Call<PersonResponseWrapper> call, ByuError byuError) {
					showErrorDialog(byuError.getReadableMessage(), null); // Don't kick them out

This is also just me reverting a change that Hammad made

app/src/main/java/edu/byu/suite/features/personDirectory/controller/PersonDirectoryMainActivity.java, line 244 at r1 (raw file):

				public void onFailure(Call<PersonResponseWrapper> call, ByuError byuError) {
					showErrorDialog(byuError.getReadableMessage(), null); // Don't kick them out
					personAdapter.remove(personAdapter.getItemCount() - 1); // But don't try to load any more data

This is new - it seemed like a good idea

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

app/src/main/java/edu/byu/suite/features/personDirectory/controller/PersonDirectoryMainActivity.java, line 232 at r1 (raw file):
Previously, coreywoodfield (Corey Woodfield) wrote…
This part was a bug

How was this a bug? It looks like you just inlined a variable...

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

app/src/main/java/edu/byu/suite/features/personDirectory/controller/PersonDirectoryMainActivity.java, line 232 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
How was this a bug? It looks like you just inlined a variable...

Yes, that fixes the bug. What was happening was that we saved the index of the last position in the list (where null was) and then we added everything before that position. Then we tried to take out null by removing from the index where null had been before we inserted stuff. but null wasn't there anymore so it wasn't behaving as expected, and the app crashed

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Problem with Gitlab and Github provider

For some reason when i tried to login with github or gitlab provider, the access token is not decoed properly and got invalid character error, the problem is in jwt decoder in atob call...
With google provider works without problem...
If the first login is with google (the user is created in supabase table with the google provider), then the github or gitlab login works too

Can you provide a JWT where you are experiencing this? For me GitHub is working fine, but I assume it might be some character in the GitHub name etc, not sure.

I experience the same error when trying to log in with GitHub:


nuget.exe CLI questions

From customer feedback:

Add a beginner how-to execute nuget commands

I couldn't find a way to replace a dll on my nuget server.

Expand on details or give additional usage/concepts. You mention CLI will not perform some functions  what are they? It would also be nice if comments/questions could be answered or acknowledged.

How can you update specific packages based on a wildcard/regex pattern? I notice CLI reference ignores expressions such as (nuget.exe update a.sln | where Id -like “DefinitelyTyped” | foreach { update-package $_.Id  -reinstall }) [Comment on docs page]

pack Version 2.7+ Creates a NuGet package based on the specified .nuspec or project file. Note that the pack command requires MSBuild and will not work on Linux systems. But i'm working with .net core web apps and i can use this command on Linux and it works

Mostly addressed in PRs going in. #4 is in a comment that is being answered separately; #2 isn't supported.


PNG RGB8 -> BMP RGB8 saving is not working

I'm using Compressonator CLI.
Following command:
./CompressonatorCLI.exe -fs RGB_888 -fd RGB_888 testpat_y_optimized.png qwe.bmp

on this texture: https://sites.google.com/site/richgel99/_/rsrc/1468890589308/luma_chroma_texture_compression/testpat.1k.png_y_optimized.png
will result in uncomplete image saving:
http://i.imgur.com/XQTFuFZ.png

We are investigating the issue and will report back ASAP on the issue.

please try with CompressonatorCLI.exe -fs ARGB_8888 -fd ARGB_8888 testpat_y_optimized.png qwe.bmp This should give you the complete image saving.

Hi  rbt2008,
Did the suggestion from xooiamd help with your issue?

@NPCompress
Setting input and output formats to ARGB_8888 to do the trick, thanks!. But I can't understand - there is no alpha channel in png and bmp files. Will this be fixed in the upcoming releases?
Thanks!

We will take a look at the data of the sample file and verify alpha is preserved during the transfer from png to bmp.

BMP with alpha channel seems pretty non-standard.

Full channel mapping will be available in V2.5 release.


Add a note to the README with flight heritage of this framework

We are considering using this framework on an upcoming cubesat mission, but want to fully understand how far along its development is before we commit to it.
Can you please add a note to the README which indicates any cubesat missions this framework has been used on? Ideally, links to project pages would also be helpful!

Thanks so much for the interest! The framework is not being developed nor maintained anymore. I developed the code for a CubeSat project which started in 2018, however the project was never finished. So till the date, the framework has not yet been used in orbit.
That being said, if you end up choosing this framework for your project, I could allocate some work hours to continue the development/maintenance, hand in hand with your project/team. I believe the framework still have a lot of potential, specially for student projects and teaching.

Thanks a lot for the offer! We're quite interested, and would love to be able to help continuing this framework.
However, we want to make sure we understand the state of the software before we invest significant resources in a potentially unstable framework/foundation for the project. How extensively has the existing framework been tested? Do you know if it's been used in more than one codebase? Do you know if there's a repo which shows example usage of this framework? Thanks!

How extensively has the existing framework been tested?

Being honest, the verification status is poor.  I tested it manually, by implementing the Flight Software of the CubeSats and trying out all commands, scenarios, etc. Unfortunately, I didn't write any unittest or integration test, but I'm interested in doing it.

Do you know if it's been used in more than one mission/codebase?

As far as I know, No. Just in the CubeSat I was working on.

Do you know if there's a repo which shows example usage of this framework?

The examples directory shows an example of a simple ground terminal which will receive telemetry and can send commands from/to a "Space segment", which is implemented as a Linux process.

Has this code ever been run on a microcontroller/custom on-board computer for a CubeSat? Or was it only used in the early development stages? Can you suggest how much work it would be to port it for STM32?

Has this code ever been run on a microcontroller/custom on-board computer for a CubeSat?

Yes, in a custom OBC with an AVR32. The drivers for CSP were not written by me and that was kept private.

Can you suggest how much work it would be to port it for STM32?

Porting the framework is basically porting CPS (the network layer).
For porting CSP there are two aspects: the OS and the communication interface.

CSP can use several interfaces for reading sending packages, the recommendation would be to keep it simple and just use USART, that means to write a driver like any of the already existent, [see these examples] (https://github.com/libcsp/libcsp/tree/develop/src/drivers/usart). I consider this is not much work, ~200 lines of code.
Regarding the OS, CSP is implemented for running in FreeRTOS, Linux and Windows. Although running it in other OSes is possible, the recommendation is using any of the two first ones. If you stick to that, no porting effort is needed.


dynamic  labels support

Proposal
Use case. Why is this important?
we want to use the same metric, but use different tag in some case, for user or developer, because we have a lot of metric in our application, we cannot list them , after all,  the metric is still growing in the feature and now.
“Nice to have” is not a good use case. :)

Could you please clarify your need, your programming language, and whether you are looking for a solution in the Prometheus server (that would be relabeling) or in client libraries (that would be declaring variables with labeled gauges/counters I think). In this case, can you also share some code that you find "very very terrible"? Thank you!

Reviewed at the bug-scrub meeting; the issue was never clarified so closing.


v2: DepositAddress and CreateDepositAddress do not work

Issue type

[x] bug
[ ] missing functionality
[ ] performance
[ ] feature request

Brief description
NotifyInfo is nil
Steps to reproduce
package main

import (
	"fmt"

	"github.com/bitfinexcom/bitfinex-api-go/v2/rest"
)

func main() {
	key := "<KEY>"
	secret := "<SECRET>"
	r := rest.NewClient().Credentials(key, secret)
	n, err := r.Wallet.DepositAddress("exchange", "bitcoin")
	if err != nil {
		panic(err)
	}
	fmt.Println(n.NotifyInfo)
}

Nice spot @andreygrehov - fixed in https://github.com/bitfinexcom/bitfinex-api-go/pull/203 please review when you get the chance

Resolved. Thank you, Jacob.


expose is replaying flag

expose is replaying flag

Coverage decreased (-0.1%) to 65.059% when pulling 9ebf09bfa8957e81d81c0dfce019edf484a805fd on yiminc:expose_is_replay into 2f5e5bf15dc8572e72b390c7ac75e253e2511f53 on uber-go:master.


Real version Internet Explorer in Compatibility View

Browser: Internet Explorer 10
default:
browser.version: 10
request.env['HTTP_USER_AGENT']: Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/6.0)
compatibility view:
browser.version: 7
request.env['HTTP_USER_AGENT']: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; Trident/6.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.3; Tablet PC 2.0; .NET4.0C; .NET4.0E)
I need a method to determine the real version browser.
Maybe add some method for this?
I think for that you can check the layout engine (Trident version).

:+1:
A user requested this in GitLab: https://gitlab.com/gitlab-org/gitlab-ce/issues/2271 Any chance this can be added soon?

Hey! Dealing with this long standing issue. Can you all review PR #168 and maybe try it out?
Since this breaks the current API detection, I'll do a major release.


Hyperlink the ORCiD

The class should follow the iD display guidelines for journals (as explained in #6).

https://info.orcid.org/id-display-guidelines-for-journals-now-released/

This means that the ORCiD logo and the URI should be hyperlinked (as raised in #14).

The recommended display is the green ORCID iD icon followed by the full iD URI (https[s] scheme optional). The iD icon should be scaled to the text, and both icon and URI should be hyperlinked to the ORCID URI.

Hi @mroman42! FYI, the v3 version @tetrapharmakon and I are working on solves this issue -- https://github.com/paolobrasolin/latex-template/blob/bf9b0b719bff00917c942c179b1ebc54cc578d2a/compositionalityarticle.dtx#L285-L290


#0: point umd to main, comestic change

@tt-rkim @TT-billteng cosmetic change to point umd to main branch instead of my side branch. Literally no changes in code


Add third_party file

Add markdown file containing list of third party libraries information used within repo.

Created issue in wrong repo.


Create short demo

Closed as per https://github.com/vyahello/fast-weather-api/commit/01c3286cfa1feadc89636be43f79f0d76bebe88c


Is this language supports Android?

It can be transpiled to C++, and C++ can by compiled on Android with the NDK. Also, it is built in C++ with no dependencies, so you could compile the language for Android and run it as an interpreter.


Unexpected blank line when using multiple lines in an alert box

Issue description
single line:

{{< alert >}}
abc
{{< /alert >}}

multiple line:

{{< alert >}}
abc

def
{{< /alert >}}

The first and last blank lines of the second box are unexpected. Not sure about the middle one.
Theme version
v2.8.2
Hugo version
hugo v0.125.7+extended darwin/arm64 BuildDate=2024-05-08T14:46:24Z VendorInfo=brew
Which browser rendering engines are you seeing the problem on?
Chromium (Google Chrome, Microsoft Edge, Brave, Vivaldi, Opera, etc.), WebKit (Safari)
URL to sample repository or website
No response
Hugo output or build error messages
No response

This seems to be due to the markdownify partial in the alert shortcode.


AnimatedParticle.prototype.update wrong frame calculation

AnimatedParticle.prototype.update = function (delta) {
    var lerp = this.Particle_update(delta);
    //only animate the particle if it is still alive
    if (lerp >= 0) {
        this.elapsed += delta;
        if (this.elapsed > this.duration) {
            //loop elapsed back around
            if (this.loop)
                this.elapsed = this.elapsed % this.duration;
            else
                this.elapsed = this.duration - 0.000001;
        }
        var frame = (this.elapsed * this.framerate + 0.0000001) | 0;
        this.texture = this.textures[frame] || PIXI.Texture.EMPTY;
    }
    return lerp;
};

I used this library on my project and i`ve got the situation when frame was bigger than textures length. I think the problem in this row:  var frame = (this.elapsed * this.framerate + 0.0000001) | 0;
Why do we add 0.0000001

The short answer is to stop floating point errors from preventing the final texture from displaying.
I've had issues in the past where Math.floor(this.elapsed * this.framerate) when elapsed was at the end resulted in textures.length - 2, not the desired textures.length - 1. By adding a number larger than any possible floating point error but small enough to not affect the calculation proper, then flooring it, ends up with a fix for the floating point error throwing off the frame calculation.
If you think this is causing I problem, then I will need more information on the configuration you are initializing the AnimatedParticle with (loop, # of textures, framerate).


Add polyfill for Enumerable.ToHashSet method

Enumerable.ToHashSet implemented for netstandard2.1 and net4x, but not for netstandard2.0.
https://learn.microsoft.com/en-us/dotnet/api/system.linq.enumerable.tohashset
As for me this slightly strange since netstandard2.0 is common subset between netstandard2.1 and net4x.
In my solution I have .net6.0 and legacy net472 projects and common logic between them in netstandard2.0.
I just want to have modern C# features in all projects and polyfill helps me in that, thanks a lot btw.
But my netstandard2.0 suffers from absense of ToHashSet method, I made it by myself very simple like
namespace System.Linq;

internal static class HashSetExtensions
{
    public static HashSet<TSource> ToHashSet<TSource>(this IEnumerable<TSource> source) =>
        source.ToHashSet(null);

    public static HashSet<TSource> ToHashSet<TSource>(
        this IEnumerable<TSource> source,
        IEqualityComparer<TSource> comparer)
    {
        if (source == null)
            throw new ArgumentNullException(nameof(source));
        return new HashSet<TSource>(source, comparer);
    }
}

Not sure is this code snippet helpful for you.
This will be to have support for ToHashSet method in netstandard2.0 projects

happy to consider a pull request for this

@maximpashuk https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

@SimonCropp I just tested the 2.1.0 version and it works as expected.
Thanks the quick fix.


http-sfv deprecated

http-sfv is marked as deprecated and replaced by http-sf. Anyone working on migration or should I give it a go?

I started work on this but haven't had the time to finish it. I pushed my partial work in progress to https://github.com/pyauth/http-message-signatures/pull/14/files. Please feel free to give it a go! I am not actively working on it right now.


Reference operator in network_time.h header file

Describe the bug
I'm not sure wether it's desired, but it looks like in the network_time.h a reference operator has sneaked in:
otNetworkTimeStatus otNetworkTimeGet(otInstance *aInstance, uint64_t &aNetworkTime);

This results in a build error when trying to include this file from some other .c file.
To Reproduce
Information to reproduce the behavior, including:

Git commit id: 0208d10563aa21c518092985c78ecf9cd223ab74
IEEE 802.15.4 hardware platform: nRF52840
Build steps:
For the purposes of this example, I simply added #include <openthread/network_time.h>  to the examples/apps/cli/main.c. Then I executed

./bootstrap
make -f ./examples/Makefile-nrf52840

Network topology - not relevant I think

Expected behavior
I would like to use network time synchronization functions from OT API in the .c source files.
Console/log output
In file included from openthread/examples/../examples/apps/cli/main.c:37:0:
openthread/examples/../include/openthread/network_time.h:87:70: error: expected ';', ',' or ')' before '&' token
 otNetworkTimeStatus otNetworkTimeGet(otInstance *aInstance, uint64_t &aNetworkTime);
                                                                      ^
In file included from openthread/examples/../examples/apps/cli/main.c:37:0:
openthread/examples/../include/openthread/network_time.h:87:70: error: expected ';', ',' or ')' before '&' token
 otNetworkTimeStatus otNetworkTimeGet(otInstance *aInstance, uint64_t &aNetworkTime);

@szymonnnm, thank you for raising this issue. I just submitted #3833. Please review.


Currency digits and delete

When using the currency alias, pressing delete does not reach the digit numbers.
    $('#HourlyCost').inputmask({
        max: '99999999.99',
        alias: 'currency',
        prefix: '',
        allowPlus: false,
        autoUnmask: true,
    });

If using decimal protection, pressing delete works, but if you enter a value like 32.32, blur and refocus the field, and enter any value like 2, it will change to 23232.00

Would appreciate any help or input on that

When I am back trom vacation I will fix it.
Op ma 15 aug. 2016 18:33 schreef Kousen Luersen<EMAIL_ADDRESS>
Would appreciate any help or input on that
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RobinHerbots/jquery.inputmask/issues/1351#issuecomment-239852981,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATb79xlqLBsBWPAL68sPFQWHYgEkNAGks5qgJTDgaJpZM4JdvLI
.

@kousenlsn ,
Which versoion do you use?  Can you make a jsfiddle which shows the problem.
I cannot reproduce.

https://jsfiddle.net/kousenlsn/a4ngsc0p/
I couldn't reproduce the issue with the decimalProtect option here, but it is behavering exactly the same not reaching the digits when pressing delete.
Version: 3.2.6-24 I think