Re working wad loading and launching. First version (multiple files - only one mod at a time)

THIS FEATURE WILL NOT INCLUDE LOADING MULTIPLE DIFFERENT MODS. This feature is mostly reworking existing functionality, and also acting as an enabler for building the multiple mod loading feature later on.
What do we have:

When searching through a mod directory, we have an okay function for collecting mod files.
Currently we stop at finding the first launchable file. This is good for idgames/ style mappacks, with no external dependencies, and the downloaded zip only contains 1 .wad file.
support for .wad, .pk3
Launcher, only supporting loading 1 mod file and 1 iwad file
file viewer, when a wad is selected, a list will display the contents of the directory of the mod.

What do we need:

One mod can contain multiple files that need to be loaded (mappack .wad file, music .wad file, extra monster .deh files), we need to collect all of them in a list of paths, and display them to the user.
A mod can also be a standalone game, ie: it can be it's own iwad file (iwad standalone, pwad is a mod)
support for .bex and .deh files as well (possibly more, adding more file formats is simple though).
Our launcher should guess what file is to be loaded. And it should guess an initial load ordering of files. In most cases there will only be one single .wad file. The entire concept of the launcher is to be a thin (but opinionated) layer on top of actually playing the mod, with categorization/convenience things if you decide you like it.
In any case, the launcher can absolutely guess the load order wrong, and maybe even miss file formats that should be supported. we need to let the user customize load order  / what files to be loaded, despite misses in the automatic loading

Detailed Requirements:

User should be able to select a wad in their listing of choice (table, tree, list view) and immediately be able to launch it, without customizing anything
User should see a list of what is loaded. The list should be ordered. The list should also spell out what iwad is acting as a base.
For example: User playing Sunder for doom2, the iwad selected is doom2.wad, the pwad selected is sunder.wad. The load-order list displays doom2.wad first, then sunder.wad below it.
User should be able to reorder the list by dragging and dropping. (maybe the system guesses that requiemmus.wad is loaded before requiem.wad, the user should be able to manually correct this). Important note: the user should not be able to drag and drop move the iwad acting as a base. the iwad should always be the first element in the list.

These 2 requirements will be split into enhancement issues, and will be dealt with at a later time, since they are extensions of the new re-work, and not critical components of the new rework.

The system should provide functionality for deciding whether a .wad file is iwad or pwad, and adjust accordingly. (This will be pushed out into a separate enhancement issues, this functionality is too different and specific for now.)
If the system fails to identify some random file format as launchable, the user should be able to drag and drop it from the directory content list over to the wad-list.

Implementation Specifics:
wad: {
  ...
  path: '/some/file.wad'
  //  -> changes to ->
  paths: ['/some/file.wad', 'some/filemusic.wad'] // <- oh look there were more files
  ...
}

This extension will be simple to implement, only need to adjust code to path = paths[0] the directory searcher already takes care of recursive searching and nested directories within the mod directory.
Load order list:
-----------
1. doom2.wad
2. requiem.wad
3. requiemmus.wad
-----------
// items inside should be draggable. Note the numbered ordering.

Launcher:
No change in -iwad needed.
// More tricky, will need to rework how the base template launcher command string is handled
'-file {path}' for path in paths, and join with spacebar.


Generate dependency graph for all objects in application container

I created a simple proof of concept for generation graph of all dependencies in container: link to gist file.
For this I used "custom" auto_inject register for creating included_keys class method with all dependencies.
After that I detect all classes with this method and generate "AST" with associations between classes.
With this changes we can detect unused dependencies in container, build GUI graph for easily understand system (like UML diagrams) and ect.
We can start build something like this for dry-system, WDYT? I can create a simple plan with small steps for this feature if you want.

After discussion with @solnic we decided to create a graph of all registered dependencies in dry-system. Also, we want to provide public API for working with this graph. It’ll allow using dry-system-graph for everyone.
Our strategic product goals now: build GUI graph for dependencies, detect unused keys and calculate heat map.
Implementation
We want to use dry-events and dry-monitoring for sending events that something was registered in the container. After that, create a new library for detecting it and detecting what and when was called. And build a graph depend on these events.
After that, we want to create plugins for GUI, unused keys and etc.
Schematically it can look like this. In dry-event we subscribe on something that happen in dry-system (registered, joined and called):

After that we can build a directed graph with weight for edges:

Current state and TODO
dry-events and monitoring

[ ] Understand how to work with dry-events and update (or make documentation);
[ ] Have a call with @mensfeld do understand what our next steps in dry-monitoring library;

dry-system dependency graph

[ ] Update  #register method for broadcasting events;
[ ] Update injectable object for dry-system for broadcasting events on dependency injection;

main issue - how to understand what was injected and target for this;

[ ] Describe dry-system monitoring/event mechanism in documentation;
[ ] Move allow logic to dry-system (instead auto_inject);
[ ] Create a dry-system-graph library and subscribe to dry-system notifications for generation graph of dependencies;
[ ] Create documentation for dry-system-graph project and create a simple example of how to build own plugins;
[ ] Make a plugin (based on the pure rack) for show dependency graph on a web page;

This looks like an exciting development, @davydovanton! Mind if I ask a few questions? I'm sure many of these might've been clear to those of you chatting in person, but it might help for people like me, following from afar and perhaps interested in helping.
(1) Firstly, is the goal of this to be able to get the dependency graph simply from booting the system? Or will it need the system to actually be run and exercised in order to generate the graph? (i.e. have actual web requests run over it, in the case of a web app)
(2) Would you mind explaining a bit more what you meant here?

Move allow logic to dry-system (instead auto_inject);

Thanks! I'll be following this closely and will try to help where I can!

@timriley thanks for questions! Really love it 👏
(1) I hope we will able to detect nodes/edges after call register method and include Inject[...] line. I want to use running application only for optional detecting weight across nodes (dependencies).
(2) Forgot to update comment and link this PR - https://github.com/dry-rb/dry-auto_inject/pull/59

The current state of the feature:
We merged notifications to dry-system #113 and create a simple WIP project https://github.com/dry-rb/dry-system-dependency_graph. And now working on building and working with the dependency graph.
Generated dependency graph for repository example:
https://github.com/dry-rb/dry-system-dependency_graph/blob/master/examples/standalone/dependency_graph.png

Since the initial dependency_graph plugin is already implemented, I'm closing this issue.


fix(envied_generator): build extensions setting

Fixes #28

@cmengler Thank you for the quick work on this! Can you pull the latest change from main before I merge this? I made a quick fix to some of the dependencies and fixed the CI so this PR should pass all the workflows.


excluded files (not in build) from fsharp suite project

the project was too large (performance) and these files where not needed for build
/cc @dsyme

Looks good


Jenkins Job to run OSDInteg in Parallel

Description
The existing OSDIntegTest Jenkins Job is updated to run in parallel
Issues Resolved
Follow up to the issue https://github.com/opensearch-project/opensearch-build/pull/3316
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3465 (6a1a290) into main (1c6da01) will decrease coverage by 0.27%.
The diff coverage is n/a.

:exclamation: Current head 6a1a290 differs from pull request most recent head 363ad6f. Consider uploading reports for the commit 363ad6f to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
- Coverage   91.81%   91.55%   -0.27%
==========================================
  Files         181      181
  Lines        5268     5268
==========================================
- Hits         4837     4823      -14
- Misses        431      445      +14

see 2 files with indirect coverage changes

After talking to @gaiksaya we will merge this PR, and all the comment changes on OS part will be added in a new PR by @Divyaasm . Thanks.


Fix Firebase limitation: it now has a js lib for push notifications

It was added fairly recently, you can read more about the supported features, browsers etc on their blog:
https://firebase.googleblog.com/2016/10/announcing-firebase-cloud-messaging-for.html

Thanks for the information 👍


High RAM usage of visual scripts

Godot v3.1.stable.official
Linux Mint 19.1
In my project, not the one linked here, literally 60% of the RAM usage is caused by visual scripts attached to instanced scenes. (GDscript only 6,7%)
Is it possible to share scripts (or parts of scripts) attached to instanced scenes by all instances of that scene and avoid duplicated data in memory? Just like textures (hopefully) are handled?
Minimal reproduction project:
ScriptSizeRep.zip
The output of the reproduction project shows the ram usage.
Just run it.
Then open the sprite.tscn scene, detach the script from the sprite, run it again and compare the outputs.
The difference of RAM usage is significant. (270MB compared to 90MB)
This issue report was edited a lot, sorry about that, but it should be fine now.

As long as I understand each loaded script is instanced. And you cannot avoid this as each instanced scene has its own state (say, position).
I wonder if Singletons are what you are looking for? They won't let you get rid of scripts on instanced scenes at all, but will let you use the same logic and/or state (though, it seems dangerous to me).
This way you may end up in having to instance a script that simply delegates all the processing logic to the singleton... sounds weird =)

The state of the node is inherited in the node (scene) itself, not the script.
Variables in the script, if providing an additional state to the inherited node, have to be instanced as well.
Functions in the script do not necessarily have to be instanced, but could possibly be shared, saving memory.
I leave the possibility of shared scripted functions (or maybe even some shared variables in the script) up to the developers.
Singletons, which, as far as I understand, could help providing one state between multiple scenes, are not what I mean. Each instance should still have its own state, which it doesn't need to share with other instances.

I didn't dig into Godot sources so, please, correct me if I'm mistaken
From a usual point of view everything is an instance. "Treat something as a resource" means to create only a single instance of that resource / class / whatever. In case of textures, I guess, that means all changes made by one user of that texture will be visible to all the other users. Same would apply for scripts if we were to treat them as resource.
About scripts (that appear to be classes as well).
You said that state is ok to be instanced because it's a state and has to be unique for each object. As for functions - I don't believe that class methods are something that can be instanced. It's just piece of code located somewhere in the memory. It is not duplicated for each instance. So here is nothing to optimize.
So, generally speaking, you already have everything you need:

functions are already shared because they are just piece of executable code not objects
state is fairly unique and has to be instanced
there's nothing else in a class (=script) aside state and functions -> nothing to optimize

Could you, please, clarify what do you mean when suggesting to share script between instanced scenes? What is to be shared?
PS. If for some reason under the hood functions are in fact objects that can be "called" then it sounds like a major performance issue to solve=)

I didn't dig into Godot sources so, please, correct me if I'm mistaken

I'm not a teacher, in fact I'm a very, very impatient person.
But I can recommend a good youtube-channel if you want to learn the basics of programming:
The Cherno Project

Resources which could possibly be shared:
Functions/Methods, local variables, constants(visual script: variables set in a vs-node)
Resources which should be instanced:
Variables, probably Signals(so they can be connected to different nodes/functions/methods by different instances)
Multithreading might be challenging, but I don't know how multithreading is implemented in godot.

@TrickMe ehm, please, feel free to let me know if my help or opinion is not desired here:) (I feel kind of intrusive). If you don't mind below some thoughts. (sorry for long-read)
First of all, I have never profiled projects in Godot so I may overlook some important metrics. But anyway I think that it might be helpful for the others if you provided some stats that you gathered with the help of profiler that we have to pay more attention to.
So it would be like "hey, guys, look how much memory is consumed by ineffective variables handling! Could you please fix that?"
As far as I understand the politics guys won't fix or implement anything unless there are lots of devs voting for that feature or there's a strong evidence or a proof (especially if the proposal relates to performance optimization) that things are bad, so they will need numbers anyway=)
Things below relate only to GDScript and not Visual Script (I have no experience with it and do not know how it is handled by the engine).
I'm not that good to inspect what way Godot handles scripts in. I guess it might be helpful for me (and other developers who know nothing about the core of the engine) to learn more about Godot if you gave some links to the sources or documentation which proof some of your thoughts (for instance, that methods are resources and can be instanced, because this idea really blows my mind away=) ).
As for the rest I would expect common terms (listed below) to be implemented as they are in other, more traditional, languages like C#, Java, Python, etc . Otherwise these terms have to be stated explicitly in documentation. But they are not.

Static vars are assumed to be allocated once and exist for the whole game lifetime. Same for constants.
Local variables are ones that are given local scope. They kind of belong to the scope - usually a block (which is marked with { } or simple tabs in GDScript). So, generally speaking, they are created (when the execution enters the scope) and destroyed (when it leaves it) quite often. And as wikipedia says their purpose is to avoid side-effects (which is what we may bump into if we try to share some state or resource). So it is definitely against the rules to share local vars because they are not meant to be shared=) If you want to share something you need to make it global. And global means singletons / God objects / whatever (not particularly Godot's Singletons but just any implementation of that pattern, even your own)
Local vars are thread-safe (because they are created each time when execution enters the scope, and each execution (i.e. thread) will have its own copy of local variable).
Having signals shared is probably not what most of developers would opt for. In fact I fail to imagine a case when I need to subscribe to some event of all objects of this particular type (this is what we'd get if we had "shared signals"). I would go for some game-wide events in this case. The case is really too rare to be implemented in the core.

Thank you for your comment, it really helps clarifying things.
My comment really shows my lack of programming experience, which I want to point out here.
I just post my first thoughts as soon as they cross my mind, because I'm very impatient.
I'm working on my bad habit of providing insufficient data and will try to collect that data before opening an issue in the future.

Local vars are thread-safe (because they are created each time when execution enters the scope, and each execution (i.e. thread) will have its own copy of local variable).

I didn't know that, thanks for clarifying. Great!
I really have no idea how local variables ended up to be possibly shared in my prior post, oops, my bad. I'll fix that one.
I provided some reproduction projects, hopefully they are helpful, so devs can do some profiling.

sources or documentation which proof some of your thoughts (for instance, that methods are resources and can be instanced, because this idea really blows my mind away=) ).

Aren't they? Everything in memory can be seen as a resource in some way, even if not treated as a resource.
I can't provide a prior documentation, because it's my idea and I can't write a proof of concept at this low level, because I'm not a programmer.
If the devs say it's not a thing, then it's not a thing.

Having signals shared is probably not what most of developers would opt for.

I wouldn't ether.

This does not relate to the topic
Generally speaking, a function - is just a named piece of commands. Consider the following commands to the processor (just some abstract imaginary language):
# '0x' means hexadecimal number (numbers from 0 to F are used)
# the whole '0x<something>' designates an address of some cell in the memory
take_value_from 0x12345678
take_value_from 0x9ABCDEF0
sum_what_is_taken
put_result_to 0x00112233

This imaginary code just takes to values from somewhere in the memory, sums it and puts the result to somewhere else in the memory. That is very inconvenient for us if we need to write the whole algorithm of actions each time we need to sum 2 numbers. It gets even worse if the algorithm is much more complicated, say, rendering of a sprite.
So, having this in mind, guys came up with a solution. They said something like (ok, they didn't but who cares?:) ) "Lets just jump to the place where the code is located which we want to execute and then jump back to where we've been!". And that looks like:
# all the commands to the processor are first loaded to the memory
# so every command has its own address; it is located in a special "code" block or something.
# that may sound weird but both commands of the application and its "data" (textures,
# sounds, variables, etc) are stored in the memory. Commands generally operate on data.
#
# let the first column designate the address in the memory
#
0x000001: take_value_from 0x12345678
0x000002: take_value_from 0x9ABCDEF0
0x000003: sum_what_is_taken
0x000004: put_result_to 0x00112233
0x000005: *jump_back*
...
# somewhere further
0x000101: *set_jump_back_address* 0x000103
0x000102: *jump_to* 0x000001
0x000103: ...
# and we can use that piece of code again as many times as we want!
0x000201: *set_jump_back_address* 0x000203
0x000202: *jump_to* 0x000001
0x000203: ...

So, here we can easily reuse some piece of code. It can be extremely complicated, it can invoke jumps to another pieces of code, but the main concept is quite simple.
The last thing to say: it would be quite inconvenient if we had to know which address our function (a piece of commands) is located at. So guys said: "Let there be names!". And it became:
# here's "sum_numbers" is just a simple label for convenience
0x000001: sum_numbers: take_value_from 0x12345678
0x000002: take_value_from 0x9ABCDEF0
0x000003: sum_what_is_taken
0x000004: put_result_to 0x00112233
0x000005: *jump_back*
...
# somewhere further
0x000101: *set_jump_back_address* 0x000103
0x000102: *jump_to* sum_numbers
0x000103: ...
# and we can use that piece of code again as many times as we want!
0x000201: *set_jump_back_address* 0x000203
0x000202: *jump_to* sum_numbers
0x000203: ...

This is it. A function - is a named piece of code (more precisely - piece of commands).
I hope it wasn't overcomplicated and boring=)

I can't catch up with you, you edit your comments so fast that mine become outdated before they're posted:)

I worried you would type a comment while I edited.
Your prior comment was a long read indeed and I mixed up something.
This is the most confusing issue report ever, but I hope devs can still spot the issue and fix it.

This issue does not effect GDscripts attached to instanced scenes, only visual scripts.
Updated initial issue report.

Still valid in 3.2.3
The script doesn't work on master.

This issue has become worse in Godot 4. You can test it by opening the Visual Script in my project below:
Godot 4:
G4 Super 3D Targeting System.zip
Godot 3:
3D-Targeting-Syetem-Ultimate-main.zip
Both projects essentially have the same code (I ported it for Godot 4). In Godot 4, by opening the Visual Script, it uses around 1.5-2GB of RAM, while it's 800MB-1GB maxed in Godot 3.

Tested the project in alpha 3. Look.vs gives me CPU spikes when panning, but RAM usage is around 100MB (with all scripts open). Which version exactly are you using?

Tested the project in alpha 3. Look.vs gives me CPU spikes when panning, but RAM usage is around 100MB (with all scripts open). Which version exactly are you using?

I am using Godot 4 alpha 3, as shown in the screen recording below:
https://user-images.githubusercontent.com/1403194/156848207-42b86eb9-0807-47d8-9cb0-7a45c016b2ee.mp4

I don't know what has changed in Godot 4 alpha 4. But RAM usage seems to be a lot better now compared to alpha 3, as shown in the screen recording below:
https://user-images.githubusercontent.com/1403194/157799238-c83f0ce8-658c-4c44-9e1a-603c609bbae1.mp4


CONFLUENT: Sync from apache/kafka/2.5 (18 February 2020)

Conflicts:

ConfigCommand.scala - some of the imports

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I cherry-picked https://github.com/confluentinc/kafka/pull/266/commits/acaa45f234bb5d9dc8cef87277a19b4cae597e63 to drop the 2.11 builds

Ugh, different commit hashes


Can't scroll past a certain point in "Upcoming Series"

Description
When scrolling through "Upcoming Series" it get's stuck after the second "page" (I can see that it loads new items 2 times).
I can see in the network requests of the browser, that there are continuous requests with the same URL http://jellyseerr/api/v1/discover/tv?page=1&firstAirDateGte=2024-04-19 at a rate of about 30 requests per second.
The same happens in different Browsers (Firefox and Chrome) and on different devices (Windows PC and iPhone)
"Upcoming Movies" works fine.
Version
1.8.1
Steps to Reproduce

Open "Upcoming Series" from the "Discover" start page
Scroll down

Screenshots
No response
Logs
No response
Platform
desktop
Device
Windows PC and iPhone
Operating System
Windows 10 and iOS 17.4.1
Browser
Firefox, Chrome and Safari
Additional Context
No response
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

I can't reproduce this, is this still the case for you?
If yes, what Discovery Region and Discovery Languages are you using (in your settings)?

Kind of. There are no more requests in the background but the page still ends after scrolling down two times, which totals to just 86 displayed TV shows.
I am using the discovery region United States and discovery language English and German. I also tried it with only English and All Languages but the result is the same.


os: Windows: MkdirAll fails with valid path that starts with \? (e.g. \?\D:\test)

What version of Go are you using (go version)?
1.9
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\xxx\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
What did you do?
precondition: Directory D:\test does not exist
dir := "\\\\?\\D:\\test"
err = os.MkdirAll(dir, 0777) // results in error
err = os.Mkdir(dir, 0777) // works

https://play.golang.org/p/Z2ONpbvDyV
What did you expect to see?
os.Mkdir and os.MkdirAll will create the directory
What did you see instead?
os.MkdirAll fails with an error

CC @alexbrainman

Mkdir just calls correspondent Windows API, so it succeeds with whatever path it is given. But MkdirAll recursively calls itself for its parameters parent directory. It finds parent directory by looking for path delimiter in the file path and taking whatever is on the left. When file path is \\?\D:\test, it obviously finds empty path at the end. We could fix MkdirAll by removing \\?\ prefix on Windows. But I suspect MkdirAll is also broken for network shares, like \\server\share\a\b\c. Do we want to fix \\?\ (it will be easy), or do we want to fix both?
I also noticed that path/filepath does not handle \\?\ at all. Do we want to try and fix that? It is bit confusing some code works with \\?\ and some don't. Should we say we support long paths everywhere and will try and fix whatever breaks?
Alex

An rclone user has noticed this in https://github.com/ncw/rclone/issues/1754
However it seemed to work for me in Windows 7 so maybe this is a specific Windows 10 problem?

However it seemed to work for me in Windows 7 so maybe this is a specific Windows 10 problem?

I replied on ncw/rclone#1754 . Perhaps that answers your question.
Alex


How to Optimize prompt for fewshot? (instruct model)

Hi:
I'm trying to optimze prompt in oneshot case. Expected formatted messages passing to model likes :
<|system|>
You are a helpful travel assistant.<|end|>
<|user|>
I am going to Paris, what should I see?<|end|>
<|assistant|>
Paris, the capital of France, is known for its stunning architecture, art museums, historical landmarks, and romantic atmosphere. Here are some of the top attractions to see in Paris:\n\n1. The Eiffel Tower: The iconic Eiffel Tower is one of the most recognizable landmarks in the world and offers breathtaking views of the city.\n2. The Louvre Museum: The Louvre is one of the world's largest and most famous museums, housing an impressive collection of art and artifacts, including the Mona Lisa.\n3. Notre-Dame Cathedral: This beautiful cathedral is one of the most famous landmarks in Paris and is known for its Gothic architecture and stunning stained glass windows.\n\nThese are just a few of the many attractions that Paris has to offer. With so much to see and do, it's no wonder that Paris is one of the most popular tourist destinations in the world."<|end|>
<|user|>
What is so great about #1?<|end|>
<|assistant|>

And I hope to optimize both instructions in 'system' and first 'user' part. The sample code in the tutorial does not seem to be suitable for this scenario. How to handle this scenario?

Great question! Several ways you could work with this:

Use nested templates, e.g.,

Output(
    GenerateText(
        Template(
            "<|system|>{{system}}<|system|>", system=Template("You are a helpful travel agent.", name="system_msg")
        )
    )
).run(runner)

Implement your own component. You can take a look at https://github.com/microsoft/sammo/blob/24ee50d83182d21f7581b4d38a907c66e723ea75/sammo/components.py#L171 to see how you could format it.

Hope this helps!

Thanks for reply!
It's really helpful.


Extract test ZIPs

Rather than placing test setups for the JavaMavenProject tests in ZIPs, the resources are now placed in directories. This should make it easier to inspect and change the tests.
The abovementioned test class has been given a method to set up the test files. I experimented with using a virtual filesystem (with jimfs in particular), but it didn't work for some reason and I didn't think it would be worth the effort right now.

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     74.58%   74.58%
  Complexity       90       90
=========================================
  Files            11       11
  Lines           181      181
  Branches         56       56
=========================================
  Hits            135      135
  Misses           23       23
  Partials         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fc20a...0bae97b. Read the comment docs.


Make it easier to learn hotkeys

I keep trying to remember the Origami hotkeys, but all I manage to remember is Ctrl+K.
It would be great if, when I press Ctrl+K something would happen that will remind me of the hotkeys, something like a message in the status bar:

"Press [Direction] to move to another pane, Ctrl+[Direction] to create a pane, Ctrl+Shift+[Direction] to destroy a pane"

Or even shorter:

"Move to: [Dir], Create: Ctrl+[Dir], Destroy: Ctrl+Shift+[Dir], Move file: Shift+[Dir]" (and other hotkeys)

Maybe it would help to display the shortcuts under:

View- > Origami -> ...

That's still a lot of key presses to open... And it ends up with just picking the one from the menu, and never using the actual shortcuts.

The shortcuts are displayed under the view menu now.
It's hard to print something out when you hit ctrl+k, because origami doesn't get activated until the second keypress (Sublime Text does some magic for you there). ctrl+k is also used to hide other commands as well. I think I'll close for now because they're in the view menu.


Add digest writer

PR Content

Add Kafka consumer and SQL storage handler to retrieve SHA digests from the configured topic and store them for future use
Grant additional permissions to digestwriter on cluster table
Make multiple columns nullable in cluster table, as digestwriter does not have that information
Update Dockerfile and docker-compose.yml files
Add corresponding UTs

Secure Coding Practices Checklist GitHub Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[x] Input Validation
[x] Output Encoding
[x] Authentication and Password Management
[x] Session Management
[x] Access Control
[x] Cryptographic Practices
[x] Error Handling and Logging
[x] Data Protection
[x] Communication Security
[x] System Configuration
[x] Database Security
[x] File Management
[x] Memory Management
[x] General Coding Practices

@epapbak Don't you think it should be better to squash the commits (amend) that fix something which is not even merged yet and include this fixed code into the initial feature commit? :) I mean commits like, "clean up comments", "remove method"

I planned on squashing the whole thing when merging, but I just realised that option is disabled. So yes, I will squash some of the commits together to clean it up a little bit.

And sorry for another conflict in go.mod.

Small things only. Otherwise looks good to me and I'd merge it to not block other changes. We need the kafka and data coming in to test it properly.

I'm working on that on another PR. See https://github.com/epapbak/vuln4shift-backend/tree/digestwriter_localsetup


cyclic symbolic detection is broken

create symbolic link that cycle.
a -> b -> c -> a
and open the folder that contains a

This issue has been fixed in prerelease version 2024.5.104, which we've just released. You can find the changelog here: CHANGELOG.md


Problem with longterm_scheduler_backend config

I have a trouble with using your library. I've added config for celery as mentioned in documentation:
app.conf.longterm_scheduler_backend = 'redis://redis:6739/1'
But got an error:
Traceback (most recent call last):
  File "/usr/local/bin/celery", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/celery/__main__.py", line 16, in main
    _main()
  File "/usr/local/lib/python3.8/site-packages/celery/bin/celery.py", line 322, in main
    cmd.execute_from_commandline(argv)
  File "/usr/local/lib/python3.8/site-packages/celery/bin/celery.py", line 495, in execute_from_commandline
    super(CeleryCommand, self).execute_from_commandline(argv)))
  File "/usr/local/lib/python3.8/site-packages/celery/bin/base.py", line 305, in execute_from_commandline
    return self.handle_argv(self.prog_name, argv[1:])
  File "/usr/local/lib/python3.8/site-packages/celery/bin/celery.py", line 487, in handle_argv
    return self.execute(command, argv)
  File "/usr/local/lib/python3.8/site-packages/celery/bin/celery.py", line 415, in execute
    return cls(
  File "/usr/local/lib/python3.8/site-packages/celery/bin/base.py", line 308, in run_from_argv
    return self.handle_argv(prog_name,
  File "/usr/local/lib/python3.8/site-packages/celery/bin/base.py", line 393, in handle_argv
    return self(*args, **options)
  File "/usr/local/lib/python3.8/site-packages/celery/bin/base.py", line 253, in __call__
    ret = self.run(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/celery_longterm_scheduler/scheduler.py", line 113, in run
    get_scheduler(self.app).execute_pending(timestamp)
  File "/usr/local/lib/python3.8/site-packages/celery_longterm_scheduler/scheduler.py", line 36, in from_app
    return cls(app)
  File "/usr/local/lib/python3.8/site-packages/celery_longterm_scheduler/scheduler.py", line 31, in __init__
    app.conf['longterm_scheduler_backend'], app)
  File "/usr/local/lib/python3.8/site-packages/celery/utils/collections.py", line 449, in __getitem__
    return self.__missing__(key)
  File "/usr/local/lib/python3.8/site-packages/celery/utils/collections.py", line 276, in __missing__
    raise KeyError(key)
KeyError: 'longterm_scheduler_backend'

What am I doing wrong? Thank you in advance

Can you provide more system and configuration details?

This is an issue I hit with django. For celery to work off of django's settings files, celery conf variables must be defined starting with CELERY_ and in all caps. This seems to mess with this repo's expectation of variables for celery.


Ability to simulate subscriber-bandwidth

By using room.simulateScenario('subscriber-bandwidth', bitrate), one could override server-side bandwidth estimator with set bandwidth.
This can be used to test application behavior when congested or to disable congestion control entirely (by setting bandwidth to 100Mbps)

lgtm! Is there an (easy) way to reset the behaviour in order to re-enable server side bandwidth estimation?

yeah, by setting subscriber-bandwidth to 0 - unlimited


My master didn't become even with upstream

Hello and thank you for this application.
I installed it a few days ago and when it was triggered the first time I got expected result - my master branch was marked "even" with upstream.
Today the app was triggered again but now I see "This branch is 25 commits ahead..."
The comparison indicates zero changes, i.e. contents of my master and upstream are identical.
What should I do if I want to always see my branch "even" with upstream?
Thank you!
UPD: Today the app was triggered again and now I have "This branch is even with ..." back.

Thanks for trying out Pull, please reply with the repo name should you encounter this again. It should take no more than a couple hours to be even.


Forgot passcode

Forgot passcode: In the procedure of Forgot passcode if we put wrong password  it did not show the correct answer and on 3 wrong password it ask to relogin but if we put wrong pin it did not show the forgot passcode option again,so I have to kill the app and again if I put wrong pin then it shows the Forgot passcode option.

Verifed this issue on dev app v2.0.68(420)


Issue with unit tests on NVIdia A100 (GPU)

Hi everyone.
I see the issue when run unit tests on NVidia A100 (GPU). Here is the link for more details.
Briefly:
=========================== short test summary info ============================
FAILED opt/gemma/gemma/layers_test.py::EinsumTest::test_rmsnorm0 - AssertionE...
FAILED opt/gemma/gemma/modules_test.py::FeedForwardTest::test_ffw0 - Assertio...
FAILED opt/gemma/gemma/positional_embeddings_test.py::PositionalEmbeddingsTest::test_adds_positional_embeddings0
FAILED opt/gemma/gemma/sampler_test.py::SamplerTest::test_forward_equivalence
================== 4 failed, 12 passed, 2 warnings in 26.55s ===================

The first 3 is similar to issues on V100 (#32), but the last one:
4. test_forward_equivalence link. Can you relax the tolerance when run on GPUs?

Hi folks. Any update on these 2 issues?


Find a way to allow main to have args

Right now it is not possible to pass CLI arguments to the main function. The static function String.fromBytes needs to be somehow identified and called from the VM. This involves exporting datatypes’ field names in a special segment and use hashing at runtime.

Solved by using StdCore library with runtime and auto-injected code into the main function


Use Numpy 2.0 for Python 3.9+ packages

Numpy 2.0 is backward compatible with 1.x, but introduce several API and ABI changes. Numpy authors claim, that packages built against Numpy 2.0 should work with 1.x too. The PR introduce additional packages built with Python 3.9 and Numpy 2.0.
Numpy release details: https://github.com/numpy/numpy/releases/tag/v2.0.0
The PR differs from https://github.com/opencv/opencv-python/pull/1001. It builds packages with limited API cp37, but with Python 3.9 and Numpy 2.0. It's expected that the package should work with all supported Pythons 3.7+ and Numpy 1.x and 2.x.

🙏


[Footnotes section]: Create functional specifications for the new design

User Story

As a [user role below]:
DDS developer

I need to:
have the Footnotes section functional specs

so that I can:
so that I can properly code the Footnotes section component that meets the Design functions and intent

Additional information

Overview and scope of the engineering work should be included in the linked epic (#4434 )

Acceptance criteria

[ ] Documented Footnotes section functional specifications
[ ] Sent and/or presented the specs to Design and Engineering for their review and comments
[ ] Comment is added with link to functional specs

Carbon's v11 update contains changes to the tooltip, splitting it into a default tooltip (which does not display interactive links) and a toggle tooltip (which can).
More info on the toggle tooltip: https://carbondesignsystem-git-fork-kingtra-17c6a2-carbon-design-system.vercel.app/components/toggletip/usage/


Add healthcheck listener

This commit adds an HTTP healthcheck listener. This is done to allow the broker to comply with certain requirements by cloud providers for certain scaling and container monitoring if required by the provider. For example, GCP External Passthrough Network Load Balancer

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

55 of 55 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.623%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
5228

Relevant Lines:
5301

💛  - Coveralls


Feature/composite properties and authentication

This is further work I did on top of https://github.com/tiaguinho/gosoap/pull/4
This does:

Does everything the other PR does
Successfully execute all test
Support []map[string]interface{}
More "pluggable"

Codecov Report

Merging #8 into master will decrease coverage by 0.73%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   71.26%   70.52%   -0.74%
==========================================
  Files           3        3
  Lines         174      190      +16
==========================================
+ Hits          124      134      +10
- Misses         47       52       +5
- Partials        3        4       +1

Impacted Files
Coverage Δ

soap.go
84.61% <33.33%> (-3.39%)
:arrow_down:

encode.go
62.79% <80.95%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b526b...78fcffc. Read the comment docs.

Just adding here some info about map[string]interface{} and []map[string]interface{} that should probably become an example/test, but I'm not really sure how, since I don't have a public endpoint for those.
    params := gosoap.Params{
        "String": "value",
        "Test": map[string]interface{}{
            "Test2": "value2",
        },
        "Booking": []map[string]interface{}{
            map[string]interface{}{
                "Booking": map[string]interface{}{
                    "Day":    "asd",
                    "Room": "lol",
                },
            },
        },
    }

Becomes:
            <Booking>
                <Booking>
                    <Day>asd</Day>
                    <Room>lol</Room>
                </Booking>
            </Booking>
            <Test>
                <Test2>value2</Test2>
            </Test>
            <String>value</String>

@Fale Maybe I have a fringe case, but is it possible to add attributes to params instead of values? See AccountInfo e.g.
params := gosoap.Params{
    "Booking": []map[string]interface{}{
        map[string]interface{}{
            "Booking": map[string]interface{}{
                "AccountInfo": map[string]interface{}{
                    `xml:"num,attr"`: "12345",
                    `xml:"secret,attr"`: "topsecret",
                    `xml:"country,attr"`: "US",
                    `xml:"laungauge,attr"`: "en",
                },
                "Day":  "asd",
                "Room": "lol",
            },
        },
    },
}

<Booking>
    <Booking>
        <AccountInfo num="12345" secret="topsecret" country="US" language="en" />
        <Day>asd</Day>
        <Room>lol</Room>
    </Booking>
</Booking>


[enhancement] Temperature profile with Elgato Eve App (FakeGato support)

@naofireblade Again thanks for your great work, sharing it and the ongoing development.
Any news about planning the recorded History to show up in Eve App?
Temperature profile with Elgato Eve App (FakeGato support)
https://github.com/simont77/fakegato-history

I updated the index.js to include the history service (not yet published to npm). You can try it by downloading the index.js and replacing your local one.
Sadly the eve app has a bug with device informations that contain a „/„ . I fixed that but the eve app must be uninstalled and reinstalled to get the history working.
Then you will get new history entries every 10 minutes.

Added in version 1.2.0.


Publish syntax and transform doc for numeric separator

See https://github.com/babel/babel/pull/5793
Edit:
Depends on https://github.com/babel/babel.github.io/pull/1187

Should we just have an umbrella 7.0 task?

I did track tasks in https://github.com/babel/babel.github.io/pull/1187 but an up-to-date issue would be welcome :+1:

It would be better if we could have multi version docs like a lot of other projects. Not sure how it's set up though?

Yes that would be great

I think we have the readme's already so closing


[NEW] Support extra params in UserProfile

Implement extra values for User Profile (like access_token).
Differencies with iOS implementation:

Facebook module doesn't provide us with 'expiration_date' field (because this is not provided by SimpleFacebook).
Google+ module doesn't provide us with 'refresh_token' and 'expiration_date' fields (because this is not provided by GMS module).

@refaelos, @borisspektor, it's ready to merge


_inIPAddresses[] = {"<IP_ADDRESS>", "<IP_ADDRESS>", 0};

what does all those ip means?I am using my phone developing

This is the internet address used to connect back to Xcode from your phone. It should be the address of your Mac.

I have changed the ip.And run project then control+= but Injecton Console error *** Could not codesign as 'iPhone Developer': /Users/taowang/Desktop/iBaby/iBaby/iOSInjectionProject/build/Debug-iphoneos/InjectionBundle3.bundle ***

Start in the simulator and then work your way up to injecting to a device. This issue may help you: https://github.com/johnno1962/injectionforxcode/issues/41

unfortunately,error again

*** Could not codesign as '': /Users/taowang/Desktop/iBaby/iBaby/iOSInjectionProject/build/Debug-iphoneos/InjectionBundle2.bundle

 at /Users/taowang/Library/Application Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/common.pm line 57.
	main::error('Could not codesign as  : /Users/taowang/Desktop/iBaby/iBab...') called at /Users/taowang/Library/Application Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/injectSource.pl line 508
 Bundle build failed ***

I also tried #41 didn't work either

I think it’s best if you stick to the simulator until you become a bit more familliar with injection.

Agreed, @azxfire - you're welcome to open another ticket in the future, but I'm closing this for now.


Using RedisSessionStore instead of InMemorySession

Expected Behavior
With adding these settings to application.yaml RedisSessionStore should be replace InMemorySession.

Actual Behaviour
Still InMemorySession in use.

Steps To Reproduce
Use config from expected behaviour and Shopping Cart example from here: https://micronaut-projects.github.io/micronaut-session/latest/guide/.
No error shown up, but also figured out @SessionValue isn't working for me, so used inject variant.
Environment Information
MacOS Ventura 13,5,1 Java 17.08.azul
Running inside IntelliJ 2023.2.1 Ultimate (Debug mode)
Example Application
No response
Version
4.0.3

Seems that my application isn't reading the application.yaml, it's always starting on port 8080 no matter wht port is set.

Problem with application.yaml


Gridsearch

Hey there,
Nice implementation.
I was wondering how we can apply GridsearchCV to determine the optimal alpha.
Is there a way to adjust the code ?
Best,
David

I just tried something (inherit from sklearn's Estimator class). Let me know if that helps.


feat: add global api for to get env,deps in dynamic call

Description

Closes https://github.com/line/wasmvm/pull/61 https://github.com/line/lbm-sdk/pull/500
Adds a global API instead of the env that was passed as a parameter.
A contract can obtain information by calling the global API.
Types of changes

[ ] Bug fix (changes which fixes an issue)
[x] New feature (changes which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] ETC (build, ci, docs, perf, refactor, style, test)

Checklist

[x] I followed the contributing guidelines.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] The PR title and commits are followed conventional commit form.

I added one more api also for deps(https://github.com/line/cosmwasm/pull/182/commits/c15602b92d798edcee90cd7789d89c467f9a3747).
but It has one problem.
It hasn't problem based on product code because deps is stateless.
However, it has problem based on test code because mock deps has state.
But I need deps to implement the sample contract logic of Virtual callstack right now, so I add it first.


Entering "help()" in snaketerm locks up snakewm.

OS: Artix GNU/Linux (runit)
Issue: After entering "help()" into snaketerm, snakewm completely locks up.
Why? No idea, correct behaviour should be starting interactive help.

#72


fixes #1108 Make packaging clickable

Description
Now packaging is clickable with Recycler view
Related issues and discussion
#1108

@ManavPoddar A single activity  has been created to handle all searches by @Shubham2320 in https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/1161 . We have decided to add clickables on top of that . I will be adding categories, emb codes and labels.
Can you also make packaging clickable on top of that otherwise there will be conflicts .
.

Yeah sure @PrajwalM2212 , thanks for noticing, I'll fix it soon  :)

fixed this issue in PR #1117

Is this PR to be closed? That's what I get from your last comment...

yes @Karljoones, i've fixed it in #1117


uhv: config option to control path fragment handling

Title: uhv: config option to control path fragment handling
Description:
UHV currently accepts and validates the fragment component of the request :path. There needs to be a new config option that controls this behavior (accept, reject, strip).

cc @yanavlasov @mattklein123


400 and 403 responses from KC should be returned to api clients as 401

400 and 403 responses from KC should be returned to api clients as 401 so UI can ask the user to re-login.
Reported as part of #1256

@sbose78 is this issue related to https://github.com/almighty/almighty-core/issues/1257 ?

No @hectorj2f

Okay, then I remove it from here. Thanks.

Just a note, that it's not about blindly mapping all 400 and 403 responses to 401. We should be careful here and treat each case individually.

@sbose78 I think I was not quite correct when originally report this issue as "400 and 403 responses from KC should be returned to api clients as 401".
There are two parts in that issue:

In same cases Keycloak returns 400 when it actually should return 401 or 403. For example /auth/realms//broker/github/token returns 400 if the token is expired. We should return 401 or 403 (depending on each case) in such cases.
Our API should not blindly return 401 in case KC returns 403 despite what I originally stated in https://github.com/almighty/almighty-core/issues/1256
for example if the token is not valid anymore then we should return 401. But if the token is valid but the user is not allowed to perform some operation then 403 should be returned instead.
API consumers (UI and other services) may treat 401 and 403 as they want but we should provide correct response status. Currently, if UI gets 401 or 403 it redirects the user to relogin but we may change it in the future.

Thanks @alexeykazakov ,
I think in case of user profile update, we only need to convert 400 --> 401

The case of forbidden ( a KC 403 ) does not arise since the system always tries to update the user corresponding to the identity id present in the token.

The case of token expired would give a KC 400, and platform-core should return a 401.


Unblock Python version

Closes #223

Codecov Report

Merging #224 (c1a1c56) into master (d941d96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   99.71%   99.71%
=======================================
  Files           6        6
  Lines         693      693
=======================================
  Hits          691      691
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d941d96...c1a1c56. Read the comment docs.

Does this unpin the Python version as mentioned in https://github.com/adriangb/scikeras/issues/223#issuecomment-805945243? Why not totally remove the Python specification from SciKeras?

I don't think it can be removed altogether. It seems to be needed by Poetry. In fact, I tried just >=3.6.7 but was forced to go with >=3.6.7,<4.

For the first question: this does not automatically make SciKeras compatible with 3.9, but the day that TensorFlow enables it we will be compatible as well.


feat: support upcast for arrays/span types

Feature Request
Describe the Feature Request
Add upcast support to the Array/Span types, to cast Array<T> into Array<U>, where T implements upcast to U.
This would make it possible to convert, for example, Span<u8>  to Span<felt252> for "free" when returning data from a function call to the expected return data of the __execute__ function in Account Contracts.

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)
I can try myself at it with proper guidance

[x] Yes
[ ] No

Cannot be supported - will break the concept of future compatibility.
Let us assume there is such a function.
Currently - Array is Array under the hood - so the conversion will work.
In the future - we may have felt64 as the basic element. u32 will be a felt64 - but felt252 will be 4 such felts.
The cast won't be possible.

And what if the cast is not to the field element but to another range checked uint?

What does it change?
An array of u8s and an array of u16s may have completely different underlying representation.


[Task]: Add Svelte prettier plugin

Task description
The formatter doesn't check svelte files. The svelte prettier plugin should be added and configured accordingly.
Requirements

Add prettier plugin
Initial configuration

Acceptance criteria

Doesn't allow svelte files that don't adhere to the configured prettier rules to be commited.

Creation checklist

[ ] I have assigned this task to the correct people
[ ] I have added the most appropriate labels
[ ] I have linked the correct milestone and/or project

Yes, I will close it!


Failed to load image when image property is not "url"

I have been trying to integrate this angular plugin. But I stuck at one place where my image object do not have property name "url". It is "imgUrl" and not possible to alter this property name to "url".
What should I pass in openModel method when image property name is not same? Please guide me to correct this issue.

@maheshtc you can set proper field name in configs:
LightboxProvider.getImageUrl = image => {     return image. imgUrl;   };


Document the in-memory and in-register representation of _Bool and bool

Closes #105.

The ISO C standard says that the only valid values for _Bool are 0 and 1.  It can't be ~0 in memory, and it can't use all 8 bytes of a register.  This patch is not OK.

Hi @jim-wilson , thanks for the feedback. Do you have a pointer to the paragraph of the C standard that requires that ?
The SysV ABI defines 0 as false, and any other bit-pattern as true - that is, there are multiple bit-patterns denoting true. I believe the SysV ABI to be compliant with the C standard.
IIRC, the only thing the standard says is that _Bool needs to be at least large enough to store 0 or 1, and that when scalars are converted to _Bool the result is false if the scalar compares equal to 0, and otherwise the result is true.
The true and false macros expand to the 1 and 0 integral constant expressions, which when converted to a _Bool, results in 0 being converted to false, and 1 to true; since these are constant-expressions, the conversion to the false and true bit-patterns is performed at compile-time by the compiler.
The standard is huge, so there might be a clause somewhere requiring _Bool to be either 0 or 1, but that would surprise me a bit, since that would mean that SysV is not compliant.

There is more than one SysV ABI.  You argument is meaningless without a reference.
First you say that the ISO C standard requires that values converted to bool must be 0 or 1.  Then you are saying that the correct representation in memory is ~0.  That is a contradiction.  It can't be both at the same time, unless we emit extra instructions to convert _Bool values which is pointless.  _Bool should be as efficient as possible.
It is wrong to try to define one true representation for _Bool.  It would be reasonable to say that 0 if false and any other value is true.  But when you try to force one particular value as true, that causes trouble.
I was referring to the sections you quoted.  True they don't require a particular value, but the important thing is that they don't say 0 and ~0 which is what you are trying to document, and that is wrong.

First you say that the ISO C standard requires that values converted to bool must be 0 or 1.

I think this is not what I said. I said:

when "scalars" (ints, floats, etc.) are converted to _Bool the result is false if the scalar compares equal to 0, and otherwise the result is true.

I see your point of making things as efficient as possible, and from that point-of-view, it would be ideal if we could "just use" any scalar as a _Bool. That is, if the scalar equals 0, the result is false, and the scalar itself is the result, and if the scalar doesn't equal 0, the result is true, and the scalar itself is the result. Having to convert that scalar to ~0 would indeed entail additional unnecessary work.
So

it would be reasonable to say that 0 if false and any other value is true.

this sounds much better to me.
While the compiler can easily do that in "private" registers, the question then is whether we want to allow that to be the in-memory representation of bool, and also, whether this can be used when passing bools in the calling convention.

So I've made the change in the last commit, changing the in-memory and in-register representation to 0 for false and non-zero for true.
Even if C would require exactly 0 or 1, that requirement would be compatible with this ABI.
However, iff C requires _Bool to always be exactly 0 or 1, this requirement would be sub-optimal for C, e.g., when calling unknown functions that return booleans, because these function does not need to necessarily return 1 for true - any non-zero bit pattern would do. This might cause C to have to convert these values to 1, which isn't desired, but AFAICT, if this is required by the C standard, these conversions are unavoidable, e.g., the integer 3 would need to be converted to 1. So going one way or the other only switches the places where this conversions happen.
A programming language that isn't C, and where true could be any non-zero bit-pattern, wouldn't have such a cost with this ABI specification though.

As mentioned in the other thread, we can't change the ABI.  It is too late for that.  We can only document what the ABI already is.  You can see what the ABI already is by compiling small examples with gcc.

It's unclear to me what the ABI already is. I found this program for x86_64:  https://gcc.godbolt.org/z/Y6fI4T
unsigned char reg(_Bool b) {
    union U {
        unsigned char f0;
        _Bool f1;
    };
    union U u;
    u.f1 = b;
    if (u.f0 > 1) {
        // This cannot happen
        // if b is only allowed
        // to be 0 or 1:
        return 42;
    }
    return 13;
}

Anyone can call the reg function according to the ABI. Clang assumes that _Bool is 0 or 1, and always returns 13. GCC does not assume that. Does this mean that GCC supports multiple true values for _Bool? That GCC is just missing an optimization ? That Clang is mis-optimizing this code? No idea.
AFAICT, the chances are that, since this is currently unspecified, and compilers need to assume something, different compilers assume different things and specifying this either way will break somebody.
GCC and Clang break their ABIs on every single release due to ABI-bugfixes. Compiler flags like -fabi-version=clang7 exist to allow users to re-introduce the bugs and remain abi compatible. [0]
If the priority is not breaking any assumptions that GCC made about this, I think the best bet here is pinging someone working on GCC RV and asking them to explain which assumptions does GCC make about this. We can then specify that, and ping clang and other compiler vendors to tell them to upgrade their ABIs.
I think that the best way forward would be to pick something that's compatible with the C standard, and that makes sense for the architecture, and then propose a specification and let compiler-vendors chime in and listen to their feedback. If, for whatever reason, what we pick is implementable in GCC, but impossibly hard to implement in Clang, the better trade-off might be to pick something that works for both.

[0] For example, GCC fixed the value of _Alignof(max_align_t) from 8 to 16 on Intel386 psABI in GCC 7.0. Clang still has a bug (https://bugs.llvm.org/show_bug.cgi?id=42525), and this bug was introduced in Clang because Clang wanted to be "bug-for-bug compatible" with GCC at the ABI level. When GCC fixed the bug, Clang didn't notice, so here we are.

I'm going to close this and just document equality with 0 and 1. That should be compatible with GCC, since in the case that GCC assumes that multiple value true values exist, 1 is definitely one of them.

Interesting example.  I think the problem is only that gcc is failing to optimize based on the range of a boolean/_Bool argument.  We do have a value range propagation pass, but it apparently isn't propagating the range of the _Bool b incoming arg, which is 0 to 1.

At the end of the day is up to the ABI to say what’s ok and what isn’t.
I’m not super familiar with RISC-V but on x86 you can use a “0 for false
and true otherwise” definition quiet efficiently using “jump on nonzero”
instructions. I believe this is why the x86-64 psABI has the weird sentence
saying that inside functions in register compilers are allowed to do better
than using 0 or 1. I think there is a patch to remove that sentence
somewhere that argues that compilers must only conform to the ABI at
boundaries and inside functions they can do whatever they want. At some
point somebody must have thought that making it clear that these
optimizations are ok was worth spelling out.
I don’t know whether RISC-V has these jump on non zero instructions or
similar, but ABIs can be quiet impactful here.


British School of Barcelona

British School of Barcelona

@marinaglancy Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

Hello! Thanks for the reply

https://www.britishschoolbarcelona.com/
Carrer de la Ginesta, 26, Castelldefels, Barcelona, 08860 Spain
https://www.britishschoolbarcelona.com/curriculum/pre-university/ - the pre-university education is a 2-year course. If you click on "A Levels" you can see both "Computer Science" and "Information Technology" in the list. International Baccalaureate also has Computer Science, the link to the subjects list is to the external web-site - https://www.ibo.org/school/002379/
On the same page in the bottom you can see that all school emails end with @bsb.edu.es . Is this sufficient or do I need to specifically prove that students are assigned emails @students.bsb.edu.es ? I can request some proof from the school IT department. (I do not want to attach any documents with my children's email addresses on the public website)


README talks about pow-js instead of pow-nodejs

This:

The library contains the Curl proof of work algorithm in plain NodeJS.

is confusing. It should be said that it provides interface to libccurl.dll and therefore is very fast.
Installation should also be updated from this:
npm install @iota-pico/pow-js --save
to this:
npm install @iota-pico/pow-nodejs --save

Updated for next release, it now says:
The library contains the Curl proof of work algorithm for use with NodeJS.
It is a wrapper around the ccurl binaries https://github.com/iotaledger/ccurl and is very fast.
Install command also fixed.


dead project?

Hi,
is it a dead project? if so, any alternatives?

Yes, as shown in the readme, this was just a project done for exploratory purposes and was really never in active development. I'm not familiar with any alternatives as of now. I'm sorry.


61-cli-for-template-generation

CLI for template generation
You can run the command by typing:
$ harissa template simulation path/to/my_simulation

or
$ harissa template inference path/to/my_inference

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

8 of 9 (88.89%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.144%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/harissa/inference/hartree/base.py
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1255

Relevant Lines:
1263

💛  - Coveralls

The result of harissa template simulation sim_const is
"""
Simulation template
"""

import numpy as np
from harissa.core.simulation import Simulation

class SimConst(Simulation):
    """
    SimConst simulation.
    """
    def __init__(self):
        """
        This is a dummy init. Feel free to change its implementation or
        to delete it.
        """
        self.verbose = False

    def run(self, time_points, initial_state, parameter):
        """
        Perform a constant simulation. Feel free to change its implementation.

        Parameters
        ----------
        time_points: np.ndarray
            Recorded time points.

        initial_state: np.ndarray
            initial rna and protein levels.
            The shape of this array is (2, G)
            with G the number of genes (including the stimulus).
            The first row is the rna level and
            the second row is the protein level at the start of the simulation.
            The first column of the protein levels (initial_state[1, 0])
            represents the stimulus.

        parameter: NetworkParameter
            network parameter used to simulate (here not used).
            The network parameter contains the following attributes:

            - Bursting parameters:
                - burst_frequency_min # k[0]
                - burst_frequency_max # k[1]
                - burst_size_inv      # b

            - Creation rates:
                - creation_rna        # s[0]
                - creation_protein    # s[1]

            - Degradation rates:
                - degradation_rna     # d[0]
                - degradation_protein # d[1]

            - Network parameters:
                - basal               # beta
                - interaction         # theta

            See https://harissa-framework.github.io/harissa/main/_autogenerated/harissa.core.parameter.html#module-harissa.core.parameter
            for more informations on this object.

        Returns
        -------
        Simulation.Result
            Data class to store the time points, rna levels and protein levels.
            See https://harissa-framework.github.io/harissa/main/_autogenerated/harissa.core.simulation.html
            for more informations.
        """
        # The shape of the rna and protein levels are (T, G)
        # with T the number of time points
        # and G the number of genes (including the stimulus)
        # The axis 0 represents the time points id,
        # the axis 1 represents the genes level.
        shape = (time_points.size, initial_state.shape[1])

        # create a 2D array that will record
        # the rna level for every time points
        rna_levels = np.zeros(shape)

        # copy the initial rna level for every time_points
        rna_levels[:] = initial_state[0]

        # create a 2D array that will record
        # the protein level for every time points
        protein_levels = np.zeros(shape)

        # copy the initial protein level for every time_points
        protein_levels[:] = initial_state[1]

        # Store the time points, rna levels and protein levels
        # inside a Simulation.Result object
        res = self.Result(time_points, rna_levels, protein_levels)

        # If you need to add other attributes,
        # you can dynamically define them later
        # or create a subclass of Simulation.Result.
        # For example:
        # res.my_variable = my_value or setattr(res, "my_variable", my_value)

        return res

Good thank you!
I will accept the PR and then maybe do some small changes on a branch update-template


Train only the text recognition part

Hi,
I want to train aster for recognizing text in an image. All the images contain just a line of text. Can I just train the recognition part, without training the localization or the rectification network?. What changes do I need to make to the prototxt file for this?
As far as I understand I should use the "create_ic15_tfrecord.py" script present in tools for my tasks. The other scripts which do not contain bbox ( as I do not want to annotate the bounding boxes for each text ) contain the term "lexicons". Could you explain what that term is?

@AyushP123  How did you do that? Can y ou show me? Thank you so much


No default value is set when visibility property is selected

Testing #103833
No default value is set for visibility property. When I select visibility property from intell-sense default value shall be populated automatically.

It seems that we don't support having both an enum and a default set in JSON.
For example, try using intellesense to complete editor.semanticHighlighting.enabled in settings.json. It has a default value of configuredByTheme, but it doesn't populate.

@aeschli a default property set on a json property that also has an enum set doesn't get automatically set by intellisense in json files. This is easily tested with the setting editor.semanticHighlighting.enabled in settings.json. It has a default value of configuredByTheme, but it doesn't populate when you use intellisense to complete it.

I'm not sure I understand the issue.
Having enum and default in a schema is very common, especially with configuration settings.
Code completion shows them all:

Maybe a filtering issue? As soon as there are already some characters (e.g. "), some proposals will be filtered.

What I mean is that the actual JSON file gets a default value inserted. In the following example, terminal.integrated.shell.windows has a default value of null and that is inserted into the document when I accept the suggested setting name. However, when I accept the suggested setting name for editor.semanticHighlighting.enabled, no default value is inserted into the document:

Oh, I see. Yes, that's intended. If there are more than one proposals (e.g. from an enum) then we don't fill in a value, but retrigger code assist t let the user choose.
Closing the issue, but @sandy081 let me know why the current behavior is not optimal.

Inserting the default value helps user to know the default value. I think we do that for property (setting) that is object type and default value.


this and super lost coloring

TS and JS Grammar Extension version:  0.0.46 / latest
Code
// Please include a code snippet that demonstrates the issue
export class BsConfig extends BsConfigBase implements IBsConfigMembers {
  baseStation: BaseStation;
  accessPoints: AccessPoint[];
  approaches: Approach[];
  alarms: Alarm[];
  zones: Zone[];
  pods: Pod[];

  constructor(c: IBsConfigBase) {
    super(c);
    let config = c as BsConfig;
    this.baseStation = new BaseStation(config.baseStation);
  }
}

This doesn't repro on with latest extension


static icons in bootstrap site are overriding fvicon.png in assets

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have searched for relatived questions
[X] I have read documentations

Describe the issue
Based on documentation I expected that a custom favicon.png placed in assets would be the basis for site related icons such as in the web browser tab and the about panel on the main page.
In order to get this to work, I had to delete all the static/images/icons in the bootstrap site.
I'm not sure if this is a Steve issue, a precedence issue (static images taking precedence over asset images) or asset image generation not generating all the necessary icons.
Also, it would be nice if the favicon mechanism would accept both png or webp format.
Steps to reproduce

Create 500x500 custom image (different from any image in static/images/icons) in assets/favicon.png
Start server
Note that custom image is not used in all places as expected. Specifically the browser tab icon and icon in main page about panel will not be the custom icon but one of the icons in static/images/icons)
Remove images in static/images/icons and reload server - icons are now correct.

Expected behavior
Expected behavior was that using favicon.png as a template, all bootstrap site icons would be replaced.
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Firefox
What version of theme are you using?
ad3b22d99f95caa82a6ae0b27d162f0b3f0794f5
What version of Hugo are you using?
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended linux/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=snap:0.110.0
What version of Node.js are you using?
v18.7.0
What version of Git are you using?
git version 2.37.2
Additional context
No response

The main reason is that the static favicons get higher priority to get backwards compatibility.
It's reasonable to support webp format (not sure if it's possible) and configurable sizes, will make a PR for that.

Thanks!
Backward compatibility makes sense and is quite understandable. A brief note in the favicon doc section regards the static images would be helpful!
-steve
---- On Thu, 19 Jan 2023 17:08:14 -0700 Razon Yang @.***> wrote ---
The main reason is that the static favicons get higher priority to get backwards compatibility.
It's reasonable to support webp format (not sure if it's possible) and configurable sizes, will make a PR for that.
—
Reply to this email directly, https://github.com/razonyang/hugo-theme-bootstrap/issues/845#issuecomment-1397765471, or https://github.com/notifications/unsubscribe-auth/ADKGZRRPHAW3IV3NBVSHRYDWTHJO5ANCNFSM6AAAAAAUAVFKMY.
You are receiving this because you authored the thread.

Thanks for your feedback, the feature is live now, see the favicon section.


Have PullImage / HasImage API in ContainerRuntime API

cc/ @vmarmol @yifan-gu

This was completed by @yifan-gu


train problem

Dear author,
Hello, I would like to sincerely thank you for your contribution. I encountered the following error when running the command python main.py --yaml_path configs/msrbd_train.yaml after installing DCN:
ImportError: /usr/local/cuda/lib64/libcudart.so.10.0: version 'libcudart.so.10.0' not found (required by /usr/local/iCompute/envs/gem/lib/python3.7/site-packages/DCN-1.0-py3.7-linux-x86_64.egg/DCN.cpython-37m-x86_64-linux-gnu.so)
Does this mean that the project can only run with CUDA 10? I would be very grateful if you could reply.

Hi, thanks for your interest in our work!
This seems to be a Cuda installation issue, but unfortunately I am not an expert on this topic. I found a link that might be related to your issue: https://github.com/pyg-team/pytorch_geometric/issues/114. Hope that could be helpful.
If I remembered correctly, DCN should be able to run with different CUDA versions (I used cuda 11 back then). Maybe you could also try installing pytorch that is compatible with your cuda version and re-compile DCN, and see if that works.

Thank you very much for your help. I wish you a happy life
---- Replied Message ----
| From | Xiang @.> |
| Date | 11/25/2024 21:22 |
| To | @.> |
| Cc | Ru @.>,
@.> |
| Subject | Re: [XiangZ-0/GEM] train problem (Issue #13) |
Hi, thanks for your interest in our work!
This seems to be a Cuda installation issue, but unfortunately I am not an expert on this topic. I found a link that might be related to your issue: pyg-team/pytorch_geometric#114. Hope that could be helpful.
If I remembered correctly, DCN should be able to run with different CUDA versions (I used cuda 11 back then). Maybe you could also try installing pytorch that is compatible with your cuda version and re-compile DCN, and see if that works.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Adds ion_reader_get_value_position for fetching the line & column of the current value from a text reader.

The position of the current value is the first character of its Ion-text representation or (if present) the first character of the first annotation.  This information is useful for reporting semantic errors to end-users when Ion-text files are used to express domain-specific language (DSL) scripts.
Also fixes a bug causing the current line number from being set to zero after every call to ion_reader_next.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I resolved the comments that are addressed; I think my comments on the tests are still actionable.

Yes, was still working on this.  Have another push coming in a minute.


add cn doc for get_device set_device and get_cudnn_version

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Please upgrade the Arduino framework

I am not familiar with the ownership of platformio packages, so I'm sorry in advance if this is not the correct repo for the issue.
I noticed that this platform has an outdated version of the Arduino framework. Basically I'm asking to bump the linked versions like in #22 to version 1.2.2, and hopefully to have a clear documentation on the process of getting dependent library updates into platformio.
Before bumping versions in here and here, the relevant framework packages need to be updated to the latest version in the platformio registry, but I have been unable so far to reach who can do that. The framework packages are platformio/framework-arduinorenesas-portenta and platformio/framework-arduinorenesas-uno, both built from this Arduino repo.
I opened an issue for the Arduino team because the author of the packages in the registry is listed as Arduino, but apparently they don't pushy the library themselves.
When the framework packages are updated, I will open a merge request with the changes in the platform json.

following this


Fix accidental regression in pylint Makefile check

It looks like a couple of lines were accidentely removed in dc2617040d637fb4857b16ac1c40d9ef60c71830 and since then we didn't perform any pylint checks on StackStorm components and runners code :man_facepalming:.

Per discussion with @LindsayHill on Slack - we should also enable some other non-error checks like "literal-comparison", etc.
The problem is that right now we only enable "error" checks (there is too much noise and false positives with many non fatal error messages).
If we want to enable a  single "literal-comparison" check which is part of warning / refactoring category we need to enable all other warnings and refactor messages as well and then explicitly disable all that we are not interested in.
This will take a wile (exclude list will be long) and I will do it in a different PR in the future.

LGTM but I guess you need to get all the CIs to pass here.


Unable to preventDefault errors in Chrome

It seems that by default  in Chrome onWheel is passive event

Can you explicitly mark it as active?

Do not know if it possible for react synthetic events. But it is possible to use addEventListener('wheel', handleWheel, {passive: false}) on canvas ref

Looks like not. Let's do manual event listening then: https://github.com/facebook/react/issues/14856

Closed by #130


Issues with run.wsf

Hello,
first of all I would like to thank you for providing this framework, which is really nice.
Although I am really not good at similar things, I could get it work after maybe an hour, so the
documentations and the steps are very well written.
I have a strange issue, which is the following: I can run the app, it takes some time, but it loads
all of the dependencies and opens the browser. However after I close it and try to open it again
nothing happens. After I run it as administrator the following error message pops up. Please see it below.
Once I restart the computer and run the app again, all the dependencies load, the browser opens and
the app runs just fine. After closing it and trying to open it again the same issue with the same error message appears. Thanks for your kind help in advance!
The message is displayed on german, but it says actually that the "run.wsf" could not be found.
Best regards,
Balazs

@balintba - A couple things to check.
First, make sure that your app registers an session$onSessionEnded handler that stops the shiny server (if you are using shiny that is) and subsequently stops the underlying Rscript.exe process.  See the following lines in the example app on how to do this.  If you don't you'll be left with a zombie process that needs to be tracked down in the Task Manager and killed.
Second, when you are running as administrator, CMD.exe starts in a folder that is not where DesktopDeployR and your app is.  You'll need to cd to that location before trying to launch the app.  That said, you shouldn't have to launch as administrator.  It sounds like your issue is related to the point above.

Many thanks for your kind reply! It has worked. Sorry for the late response


Fix a bug, which involved clarifying the code.

When AsyncLogClient::GetEntries returned a non-OK status, we would return without calling WalkEntries. If this range fetch happened to be the only one, that meant that the overall operation would get hung. I converted the range fetching to be its own util::Task-driven operation, ensuring that WalkEntries would always get called, no matter what, and allowing me to remove the manual adding/removing of holds on the task (since child tasks have an implicit hold), making it one less thing to get wrong.
I also renamed some methods for better clarity and searchability.

wot no tests? naughty boy.
LGTM.


Create a sprig CLI utility

A CLI application that should support three main use cases:

Compile the firmware (via docker) and copy the firmware to the first connected sprig device
Start the minicom logger on the first connected sprig device
Load a game ont ot he first connected sprig device

These are such common operations that we will end up doing thousands of times - lets make sure we make these things as easy (and non-error-prone) as possible.

This was completed to some degree.  There may be bugs, which should be logged as separate issues.  Closing this.


Missing values in Caravan Attributes

HI,
May be it is already detected, if not probably an easy task.
I found 158 bassins where caravan's attributes are missing, mostly in GB collection but some in GR and AUS.
All have small area (less than suggested 100km2).
note: DK collection is all ok
Thank you and keep going!

Hi @jnthnroy
thanks for reporting this. It seems like the hydroatlas files contains some rows (basins) that shouldn't be there. Correct are only the 408 basins from CAMELS-GB that are listed in the attributes_caravan_camelsgb.csv. The HydroATLAS file seems to contain some smaller ones (>= 50km2 instead of >= 100km2, which was my initial threshold but was then raised to 100sqkm for the publication). I will make sure that these are removed from the new version that is about to be uploaded.

Hi. Thanks for releasing a nice dataset.
I downloaded the v1.3 from Zenodo (Released May 2023) and it still has exactly 158 extra basins in the attributes/{subdataset}/attributes_hydroatlas_{subdataset}.csv files.


Adding serial type node

Studio PR to integrate the SERIAL_SINGLE_READING node PR:
https://github.com/flojoy-io/nodes/pull/46

@dstrande is this still relevant after your last PR, or can we close it?
if you still need this PR, please update to fix the conflicts so we can merge


UserListPresenter#onUserClicked naming

Hi, very interesting post.
I have a method naming question/issue.
In the UserListPresenter, you have defined a method onUserClicked(UserModel userModel). I'm not sure if this is a correct name. The idea is that the View can change but the presenter remains the same, but the concept of UserClicked is something more of the view. Maybe the view changes and the user is displayed in a double click.
In my opinion this method should be called something like viewUserDetail(UserModel userModel).
Thanks,

The methods that a View calls for it's presenter can be thought of as UI Events. No matter how/where your View shows the button, the Presenter is still concerned with the fact that a UI Event happened, that being the "click" on a user. "viewUserDetail" could also work here, if you were concerned that there is some other UI Event other than "clicking" that could possibly be used to view a user detail.

@caseykulm good explanation and totally agree. Thanks for clarifying it.


Fastlane beta shows "Couldn't decrypt the repo, please make sure you enter the right password"

I can't able to run the "fastlane beta", because it shows the error "Couldn't decrypt the repo, please make sure you enter the right password!".
Enter the passphrase that should be used to encrypt/decrypt your certificates
This passphrase is specific per repository and will be stored in your local keychain
Make sure to remember the password, as you'll need it when you run match on a different machine
Passphrase for Git Repo: ***************
Type passphrase again: ***************
Couldn't decrypt the repo, please make sure you enter the right password!
keychain: "/Library/Keychains/login.keychain-db"

@nihp Did you use the exact same password for when you create the match repo?  Please see other issues that are similar to this one - https://github.com/fastlane/fastlane/issues?q=is%3Aissue+Couldn't+decrypt+the+repo%2C+please+make+sure+you+enter+the+right+password+is%3Aclosed

@joshdholtz
My exact issue is in this thread
https://github.com/fastlane/fastlane/issues/10931
Kindly reopen this, it get auto closed
Here I have a decrypted file, I have given correct password only. Is there is any way to disable the password which I was given earlier
Enter the passphrase that should be used to encrypt/decrypt your certificates
 This passphrase is specific per repository and will be stored in your local keychain
 Make sure to remember the password, as you'll need it when you run match on a different machine
 Passphrase for Git Repo: ***************
 Type passphrase again: ***************
: 🔓  Decrypted 'HDDJNHHFDFDN32.cer'
 Couldn't decrypt the repo, please make sure you enter the right password!
keychain: "/Library/Keychains/login.keychain-db"

@nihp So you are running this over ssh?

I am running with my git repo

Any way to change the password

@nihp There is not a built in way to change the password. Your best bet to change the password would just be to just delete everything in this repo or to create a new repo. Do you not remember the password you used when creating the match repo?

I remember the password, but when I giving the password it not accepting that password

@nihp match is working for me right now 🤔 Can you maybe try creating a brand new repository (just as a test) and see if things work with that?

We just experienced the same issue. Match keeps asking for a password and even though it's the correct one, it does not get accepted.

the same issue

the same issue

Same issue, goodjob fastlane bot

I ran bundle exec fastlane match nuke development which unlocked my Keychain, decrypted the repo and cleared out all dev certificates. And then 30 seconds later I ran bundle exec fastlane match nuke distribution and it failed, deleting the password from the keychain
[✔] 🚀
[13:32:52]: Successfully loaded '/Users/proj/fastlane/Matchfile' 📄

+----------------+----------------------------------------------+
|          Detected Values from './fastlane/Matchfile'          |
+----------------+----------------------------------------------+
| git_url        | git@github.com:company/certificates.git |
| type           | development                                  |
| app_identifier | com.example.appid       |
| username       |<EMAIL_ADDRESS>                 |
+----------------+----------------------------------------------+

[13:32:52]: Cloning remote git repo...
[13:32:52]: If cloning the repo takes too long, you can use the `clone_branch_directly` option in match.
[13:32:53]: Couldn't decrypt the repo, please make sure you enter the right password!
keychain: "/Users/me/Library/Keychains/login.keychain-db"
version: 512
class: "inet"
attributes:
    0x00000007 <blob>="match_git@github.com:Company/certificates.git"
    0x00000008 <blob>=<NULL>
    "acct"<blob>=<NULL>
    "atyp"<blob>="dflt"
    "cdat"<timedate>=0x32303138303130343135353231395A00  "20180104155219Z\000"
    "crtr"<uint32>=<NULL>
    "cusi"<sint32>=<NULL>
    "desc"<blob>=<NULL>
    "icmt"<blob>=<NULL>
    "invi"<sint32>=<NULL>
    "mdat"<timedate>=0x32303138303130343135353231395A00  "20180104155219Z\000"
    "nega"<sint32>=<NULL>
    "path"<blob>=<NULL>
    "port"<uint32>=0x00000000
    "prot"<blob>=<NULL>
    "ptcl"<uint32>=0x00000000
    "scrp"<sint32>=<NULL>
    "sdmn"<blob>=<NULL>
    "srvr"<blob>="match_git@github.com:Company/certificates.git"
    "type"<uint32>=<NULL>
password has been deleted.
[13:32:53]: Enter the passphrase that should be used to encrypt/decrypt your certificates
[13:32:53]: This passphrase is specific per repository and will be stored in your local keychain
[13:32:53]: Make sure to remember the password, as you'll need it when you run match on a different machine
[13:32:53]: Passphrase for Git Repo:

Running version 2.107.0

Deleting the git repo and creating a new one with the same name seemed to work, allowing me to reset the password for the repo.

Same issue here, any help from team, pls?

Same issues here as well, after setting a password it just fails to decrypt it.

seems to have been solved in 2.116.0

It was not closed yet, still producing the same error

still getting this error

Have you tried using the ENV variable MATCH_PASSWORD ?

I'm getting the same thing. Tried both inputting the password manually and through env var MATCH_PASSWORD.

How do you set the ENV variable? I noticed that setting it in the Fastfile did NOT work. But on the command line it did!

I am also experiencing the same problem.
My distribution certificate has expired. So I have regenerated the same certificate by editing from UI in developer account. Now it is eligible to distribute my app. But I am facing an error as
❌  error: No signing certificate "iOS Distribution" found: No "iOS Distribution" signing certificate matching team ID "924775HDGD" with a private key was found. (in target 'My App')
Note: So I deleted the older Match file and generated a new Match File by running fastlane match init. But the password gets mismatched and I can't not able to encrypt the certificate in my repo.
Kindly provide any suggestion to upload my build as soon as possible

I have fixed the above mentioned error by the following
Unchecked "Automatically manage signing".
1. Select "Provisioning profile" in "Signing (Release)" section.

2. No signing certificate error will be show.

3. Then below the error has a "Manage Certificates" button. click the button.
4. This window will come. Click the + sign and click "iOS Distribution". xcode will create the private key for your distribution certificate and error will be gone.

Refer answer from the stackoverflow
https://stackoverflow.com/questions/45050902/no-signing-certificate-ios-distribution-found

I'm getting the same problem as OP. Entering the correct password produces
bad decrypt
Couldn't decrypt the repo, please make sure you enter the right password!
password has been deleted

Any one got this working ? fastlane keep asking me for Passphrase for the git repo, even though I have entered the correct password

The only workaround I know is using the ENV variable when running the script.  When use them in different branches match worked perfectly

I am still experiencing this issue on CircleCI

@hmgibson23 have you figured it out?

Yeah. It was because the original certs were on my local machine. Deleted those, regenerated and it worked. Misleading error though...

same issue

I am using fastlane 2.129.0 , the issue remains same .Any workaround to fix this out without changing repository and doing the same shit again and again

Did you tried with the exact password which you already used

Yes I did
Thanks & Regards TRINADH KOYA Work Hard.Have fun.Make History
On 22 Aug 2019, 2:33 PM +0530, nihp<EMAIL_ADDRESS>wrote:

Did you tried with the exact password which you already used
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Repository relations and nested search and filters

I've made a start on #81.
It's work in progress but figured I'd share as I've run into some problems and I'm not sure how much time I'll get to work on it in the next week.
Todo (please comment if you see anything I missed):

[x] Join Many to One relation
[x] Search support on Many to One relation
[ ] Filter support on Many to One relation
[x] Join One to Many relation
[ ] Search support on One to Many relation
[ ] Filter support on One to Many relation
[ ] Join One to One relation
[ ] Search support on One to One relation
[ ] Filter support on One to One relation

Issues I have

the Column type won't work as is because Extract only looks at the main object keys, not the relations (see https://github.com/ppetzold/nestjs-paginate/pull/119/files#diff-c58e144dadf00250381ed55e6ce83245cda76aca84131ad494fd4911932f656fR23).
I created a test for the One to Many search but i get this error Cannot query across one-to-many for property toys and I can't see what I'm doing wrong

Over this week I hope to add filter support for Many to One and add tests for One to One (I think it should just work if Many to One works).

hey, great start ! :) I'll keep an eye on it, or help contribute if I find some time.
to (1) I am ok with string. we could also look into template literal and conditional types - but not much of a priority imo.
to (2) might have a look on the weekend.

Sorry, lots of other things got in the way. I will try to return to this sometime this week

hello, any updates? happy to contribute

hello, any updates? happy to contribute

Seems stalled. You can probably just take over as is if you are up to :)

Very sorry. In the end we found an alternative solution.
Would still love this feature as I think we will eventually need it but currently can't devote any sprint time to it, so happy for someone else to take over.

closed in favour of #186