[TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38915
PROPOSAL:
Tests

To test this feature you have to have tax enabled on your Collect policy, this is how you can create it so it works in NewDot:

[x] make manual/scan money request and try check tax rate and tax amount sections.
[x] try to change tax rate type
[x] try to change tax amount

Offline tests

QA Steps

Same as Tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/88395093/215753eb-dfa4-4375-9311-45175278f142

Android: mWeb Chrome

https://github.com/Expensify/App/assets/88395093/cff41f5b-8c24-4825-8009-a70aa3c815d1

iOS: Native

https://github.com/Expensify/App/assets/88395093/90188efb-26b5-4892-b5f1-df32b252590b

iOS: mWeb Safari
https://github.com/Expensify/App/assets/88395093/6b17fd71-7653-4f02-976c-3e43fac2831c

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/88395093/f77e6356-6958-4419-aa94-2526ee67a393

MacOS: Desktop
https://github.com/Expensify/App/assets/88395093/fdbf79f7-a0a6-46a9-9094-1122e58ab7b5

@SzymczakJ  can you make this PR as ready to review?

Reviewing tomorrow!

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@SzymczakJ Could you add the recording for Mac OS: Desktop?

@jjcoffee done!

@SzymczakJ we have conflicts here

Looks good, just needs to resolve the conflicts.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.61-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.61-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Deploy production URL

Issue #20 was created fixing the production URL in the site list. I realised afterwards that the url is "used" in other places as well ( deployment ie. ).
Creating this ticket to go through the usage of production url.
( Also, not sure production URL should be defined in the utterson_config. It is already defined in Jekyll's own config )

I did look at this while I made the changes to the site list, but did not make any changes in the deployment section, that should work as before I think (I hope). I'm not sure it makes sense to relate the production url to the deployment url at all, as they may be different at least for some setups.
Anyways, I'll be happy to help if needed.


Speed up loading of fee estimates for transaction signing

Testing the release:v2.22.0
Notice similar issue in prior 2 releases before this as well and this is both on Chrome and FF
User notices that the fee estimate dialogue box takes few additional seconds to be populated while the Preview button seems enabled.
We may need to improvise the performance of the fee estimate pop up which will aid user interface
https://user-images.githubusercontent.com/38872890/143891636-3ae77e0d-a10b-42f5-881e-bfe81555b9ff.mov

@Eshwari007 Mind retesting this to see if it's still an issue?

@markmhx The issue mentioned above is no longer reproducible. Will close the ticket.


fix(actions): disable commitlint

commitlint is consistently broken for me and just screws up my commits every single time i make one
plus it doesn't make sense as a commit hook for anyone using squash-and-merge workflows: in that scenario the thing that actually matters is the merge description.

What is the commitlint rule equivalent for a pull request?

That's where the MQ comes in, I think... I don't know if there's a way around it.
Also why I filed https://linear.app/trunk/issue/TRUNK-4681/set-up-a-pre-commit-hook-in-trunk-ioplugins

Maybe when trunk push creates a pull request - it can recommend / push
through a flow to do things in a conventional format. That's what I want
On Tue, Oct 18, 2022 at 4:14 PM Samuel Lijin @.***>
wrote:

That's where the MQ comes in, I think... I don't know if there's a way
around it.
Also why I filed
https://linear.app/trunk/issue/TRUNK-4681/set-up-a-pre-commit-hook-in-trunk-ioplugins
—
Reply to this email directly, view it on GitHub
https://github.com/trunk-io/plugins/pull/38#issuecomment-1283122194, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVCPWQQOCAME7VFSJ23CTWD4VNZANCNFSM6AAAAAARHMF3U4
.
You are receiving this because your review was requested.Message ID:
@.***>


Policheck updates - Sept. 12 | Bulk Updates

PR Summary
Changes:

Cape Verde to Cabo Verde
Turkey to Türkiye
Whitelist to allowlist (in descriptions and text only)

Fixes the following bugs:

148186
148190
148213
148182
148229
148250
148150
148204
148242
148170
148227
148184
148162
148199
148219
148244
148178
148175
148194
148171
148231
148222
148164
148247

@v-thepet, 100% of these docs are autogenerated reference content. Their source resides in the azure-powershell source repo. We release a new version of Azure PowerShell monthly, and these issues will reoccur each month until the source files are updated. cc:// @jasongroce

@mikefrobbins @jasongroce - Ah, sorry. I look for evidence of autogen but this repo and PRs seemed normal. I'll try to make these changes in the source repo. I don't know if you want to merge this anyway as it would be a stopgap for the month. Or I can close it. Sorry for the hassle

@mikefrobbins - Thanks for the merge. I've now made all the same changes in the source repo, PR https://github.com/Azure/azure-powershell/pull/22790


Integrate Percy.io into workflow

User Story

As a [user role below]:
IBM.com Library Reviewer

I need to:
see a visual difference in code changes

so that I can:
quickly assess changes impacting the library visually

Additional information

Currently works locally with percy-storybook integration

Acceptance criteria

[ ] Add percy.io testing in deploy previews
[ ] Integrate with changes to master branch

Have investigated integrating the workflow through CircleCI, but feel like it will not be sufficient. This does not account for a fork and pull methodology for generating the percy snapshots. Will need to re-pivot back to looking into standing this up in Jenkins. Bumping effort to 5, but may upgrade to an 8 depending on how things go. The challenge there is that the standard Jenkins agent does not include a headless browser for rendering, so a custom agent will need to be generated to support this.


draft pr about non-streaming output

Try to get a valid output of the model, i.e. do not include the input of the model in the case of non-streaming

@BasicCoder just pass exclude_input_in_output:True to tensorrt_llm/config.pbtxt.
Still you can transform this PR into making the above option default as many people struggle with it being disabled by default.


Add support for Fixed Point numbers

Is your feature request related to a problem? Please describe.
Often when reversing old code that predates modern FPUs, Fixed Points are used. However, memorizing what a hex/dec value is in that custom fixed format can be quite tough. Hence, I'd like to request a custom data type for fixed points.
Describe the solution you'd like
Add a new data type (or maybe allow adding one to an archive?) for (s?)a.b fixed points.
Describe alternatives you've considered
Floats often don't work, and memorizing/converting manually is quite the task.

Something that should probably be taken into consideration is whether or not to support base 10 for fixed point types (besides base 2). Granted, the only use case I can come up with right now for base 10 is for anything that resembles the numeric type in Postgres.


Further factoring of the crypto interface

@Ralith I think this is ready for a first round of review!

Could we also make the quinn builders generic?

I tried some things, but if we want the high-level API to remain ergonomic, I think this gets pretty complex. Might dive into it as a follow-up, though? Seems to make sense that propagating the abstraction further out can be layered on top of this.

Have another look?


python311Packages.aioconsole: 0.7.0 -> 0.7.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.aioconsole is: Asynchronous console and interfaces for asyncio
meta.homepage for python311Packages.aioconsole is: https://github.com/vxgmichel/aioconsole
meta.changelog for python311Packages.aioconsole is: https://github.com/vxgmichel/aioconsole/releases/tag/v0.7.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.1 with grep in /nix/store/r1imn81s06ff66lf7za751lg62w3wksk-python3.11-aioconsole-0.7.1
found 0.7.1 in filename of file in /nix/store/r1imn81s06ff66lf7za751lg62w3wksk-python3.11-aioconsole-0.7.1

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)

11 package rebuild(s)

First fifty rebuilds by attrpath

crackmapexec
home-assistant-component-tests.whirlpool
knowsmore
netexec
python311Packages.aioconsole
python311Packages.bless
python311Packages.whirlpool-sixth-sense
python312Packages.aioconsole
python312Packages.bless
python312Packages.whirlpool-sixth-sense

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/r1imn81s06ff66lf7za751lg62w3wksk-python3.11-aioconsole-0.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.aioconsole https://github.com/r-ryantm/nixpkgs/archive/98ec215e95cda61bbca74f5b73b974cdc4c045e4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/98ec215e95cda61bbca74f5b73b974cdc4c045e4#python311Packages.aioconsole

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/r1imn81s06ff66lf7za751lg62w3wksk-python3.11-aioconsole-0.7.1
ls -la /nix/store/r1imn81s06ff66lf7za751lg62w3wksk-python3.11-aioconsole-0.7.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

19 packages built:

crackmapexec
crackmapexec.dist
home-assistant-component-tests.whirlpool
knowsmore
knowsmore.dist
netexec
netexec.dist
python311Packages.aioconsole
python311Packages.aioconsole.dist
python311Packages.bless
python311Packages.bless.dist
python311Packages.whirlpool-sixth-sense
python311Packages.whirlpool-sixth-sense.dist
python312Packages.aioconsole
python312Packages.aioconsole.dist
python312Packages.bless
python312Packages.bless.dist
python312Packages.whirlpool-sixth-sense
python312Packages.whirlpool-sixth-sense.dist

Maintainer pings
cc @catern for testing.

Result of nixpkgs-review pr 309282 run on x86_64-linux 1

19 packages built:

crackmapexec
crackmapexec.dist
home-assistant-component-tests.whirlpool
knowsmore
knowsmore.dist
netexec
netexec.dist
python311Packages.aioconsole
python311Packages.aioconsole.dist
python311Packages.bless
python311Packages.bless.dist
python311Packages.whirlpool-sixth-sense
python311Packages.whirlpool-sixth-sense.dist
python312Packages.aioconsole
python312Packages.aioconsole.dist
python312Packages.bless
python312Packages.bless.dist
python312Packages.whirlpool-sixth-sense
python312Packages.whirlpool-sixth-sense.dist


Organized code structure

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.182%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
108

Relevant Lines:
110

💛  - Coveralls


cqn4sql: make sure to always use calculated alias in custom on conditions

Inspired by #169

the issue here was that we had a where condition like
where exists foo[id=1] or exists foo[id=2] with foo being an association foo : Association to one Foo on foo.ID = foo_ID;.
While building up the where exists subqueries, we calculate unique table aliases for foo, which results in a table alias foo2 for the second condition of the initial where clause. Now, if we incorporate the on-condition into the where clause of the second where exists subquery, we must replace the table alias foo from the on-condition with foo2.

The test case provided here is (if I'm not mistaken) the same as in https://github.com/cap-js/cds-dbs/pull/169. But that test didn't discover the problem described in https://github.com/cap-js/cds-dbs/pull/173#issue-1852975234 - or did it?

Reference in new issue

nope it didn't, im still working on that.

Reference in new issue

nope it didn't, im still working on that.

for this pr?

Reference in new issue

nope it didn't, im still working on that.

for this pr?

Yes, I will add it as part of this pr hopefully today

@stewsk @sjvans please have a look at #173 which showcases the error which was reported in the cap issue.

Is it possible to have a dedicated cqn4sql test for the situation described in https://github.com/cap-js/cds-dbs/pull/174 ?

Is it possible to have a dedicated cqn4sql test for the situation described in #174 ?

yes you are right, this way it is much clearer what the issue is. I replaced the end-2-end test with a proper cqn4sql test illustrating the issue. :)


Typo in input and output

While I was scrolling trought TS docs i found this realy diferent thing that is the table with a  and  output for react native. Its been a while since I've not used React Native but I remeber that we used  that could transpile to  UIView, , android.view depending on your platform, but you should refer to this block of code as  like discussed in this doc (RN View Doc) [https://reactnative.dev/docs/view].
If i'm wrong on this, I would like to say sorry.  This is my first Pull request to making TypeScript better. If there is any things that i could do to make this pr better I gladly would change :) thx and good holidays

Thanks for giving it a shot, but the goal of this table is to show how the same code transforms to different outputs based on the jsx tag. There isn't a single element which does have all that because of react-natives lack of native lowercase elements so <div /> is an acceptable trade-off in that the key point is that 'jsx' is kept and it acts the same as preserve. I totally get the PR, but I think it might make it a bit more complex for folks to reasnbou about how the JSX option works

Thanks for giving it a shot, but the goal of this table is to show how the same code transforms to different outputs based on the jsx tag. There isn't a single element which does have all that because of react-natives lack of native lowercase elements so <div /> is an acceptable trade-off in that the key point is that 'jsx' is kept and it acts the same as preserve. I totally get the PR, but I think it might make it a bit more complex for folks to reasnbou about how the JSX option works


Cannot assign to read only property 'props' of object '#' with React

🐛 Bug Report
After upgrading to jest 25.x.x, when comparing 2 different React Components with
expect(<...>).toEqual(<...>)

there's an TypeError instead of a report of the differences between the components.
To Reproduce
  expect(<div prop1="" />).toEqual(<div/>)

    TypeError: Cannot assign to read only property 'props' of object '#<Object>'

      3 | test('renders learn react link', () => {
      4 |   expect(<div/>).toEqual(<div/>)
    > 5 |   expect(<div prop1="" />).toEqual(<div/>)
        |                            ^
      6 | });
      7 |

      at Object.<anonymous> (src/App.test.js:5:28)

Expected behavior
It works fine in jest 24.9
    expect(received).toEqual(expected) // deep equality

    - Expected
    + Received

    - <div />
    + <div
    +   prop1=""
    + />

Link to repl or repo (highly encouraged)
git clone git@github.com:dpinol/jest-react-toEqual-bug.git
cd jest-react-toEqual-bug
npm i -D
npm run test

envinfo

/cc @pedrottimark

I am running into this problem as well. It seems quite easy to reproduce:
const x = { foo: {} };
Object.freeze(x);
expect({ foo: { bar: 1 } }).toEqual(x);

The expect statement produces the error TypeError: Cannot assign to read only property 'foo' of object '#<Object>'.
This issue occurs on Jest >= 25.0.0.

I am also running into this bug where I have a frozen object, and comparing it against one that I want it to be equal to, using the toEqual matcher. Is it actually fixed?

Getting this issue too. Downgrading to jest 24.x reveals a normal .isEqual failure, but with 25.x we get TypeError: Cannot assign to read only property 'x' of object '#<Object>'.
Objects are frozen.

I have created a minimal reproducing test case:
Run on Repl.it
test('frozen object comparison', () => {
  expect(Object.freeze({
    a: {},
    b: {},
  })).toEqual({
    a: {},
   });
});

Error:
 FAIL  ./frozen-comparison.test.js
  ✕ frozen object comparison (10ms)

  ● frozen object comparison

    TypeError: Cannot assign to read only property 'a' of object '#<Object>'

      3 |     a: {},
      4 |     b: {},
    > 5 |   })).toEqual({
        |       ^
      6 |     a: {},
      7 |    });
      8 | });

      at Object.<anonymous>.test (frozen-comparison.test.js:5:7)

@SimenB

Also having this problem. Until it's properly fixed this solves it. https://github.com/reduxjs/redux-toolkit/issues/424#issuecomment-597508298

It looks like there's a fix in master but it's not been released yet.

25.2.0 published

This isn't a sufficient fix. I filed https://github.com/facebook/jest/issues/9745.


how i can change the name, if the name is in other model, and i just use one model?

how i can change the name, if the name is in other model, and i just use one model?

can you explain about your problem here?


Memory error with timsort and std::deque

Valgrind sometimes reports memory errors when trying to sort an std::deque with tim_sorter (see the deque-memcheck branch for more information).
It probably comes from out-of-bounds std::deque iterators. Since they are never dereferenced, it never actually causes any error, and Valgrind doesn't complain about equivalent out-of-bounds pointers. I don't know which kind of problems these out-of-bound std::deque iterators may cause, but we should probably better get rid of them as soon as possible.

I might have fixed the issue with the latest commit: when maintaining timsort upstream I got to test it with MSVC debug iterators and they detected that some iterators were going out-of-bounds. Apparently it was due to cursor1 in mergeHi sometimes pointing to the element right before the beginning of a collection, and even though said element was never dereferenced not every collection can safely form such an iterator (while it isn't an issue with contiguous iterators, I'm not surprised that it caused issues with std::deque). Most of the Valgrind traces point to mergeHi, which is quite consistent with the issue found by the MSVC debug iterators.
I fixed the issue by tweaking the way iterators are handled in mergeHi, but the only failing build in cpp-sort (OSX with Valgrind) now fails because it lasts longer than 50 minutes, so I can't really close this issue for now. I'll close it when I have enough non-failing builds again to be sure.


Fatal Layout issue on Linux

I've downloaded and installed v0.0.10. No problem at that point.
When I launch the app, a greyish window appears with a dialog half hidden on the right side to choose credentials
The main window is resizable but doing so doesn't allow the dialog to appear. It sticks to the right edge, making the app useless, which is a shame because it looks really promissing!!

My box:
System:    Kernel: 5.4.0-91-generic x86_64 bits: 64 compiler: gcc v: 9.3.0 Desktop: Cinnamon 4.8.6
wm: muffin dm: LightDM Distro: Linux Mint 20.1 Ulyssa base: Ubuntu 20.04 focal
Machine:   Type: Laptop System: HP product: HP ZBook 14u G5 v: N/A serial:  Chassis:
type: 10 serial:
Mobo: HP model: 83B2 v: KBC Version 04.53.00 serial:  UEFI [Legacy]: HP
v: Q78 Ver. 01.03.00 date: 07/18/2018
CPU:      Topology: Quad Core model: Intel Core i7-8650U bits: 64 type: MT MCP arch: Kaby Lake
rev: A L2 cache: 8192 KiB
flags: avx avx2 lm nx pae sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx bogomips: 33599
Speed: 800 MHz min/max: 400/4200 MHz Core speeds (MHz): 1: 800 2: 800 3: 800 4: 800
5: 800 6: 800 7: 799 8: 800
Graphics:  Device-1: Intel UHD Graphics 620 vendor: Hewlett-Packard driver: i915 v: kernel
bus ID: 00:02.0 chip ID: 8086:5917
Device-2: AMD Lexa XT [Radeon PRO WX 3100] vendor: Hewlett-Packard driver: amdgpu
v: kernel bus ID: 01:00.0 chip ID: 1002:6985
Display: x11 server: X.Org 1.20.11 driver: amdgpu,ati,modesetting unloaded: fbdev,vesa
resolution: 1920x1080~60Hz, 1280x1024~60Hz, 1280x1024~60Hz
OpenGL: renderer: Mesa Intel UHD Graphics 620 (KBL GT2) v: 4.6 Mesa 21.0.3
direct render: Yes

Hi, thanks for the report
This looks weird and It takes time for me to reproduce it, so please stay tuned

Same problem, looking forward to the fix 👍

Hi @pmullot @RickRyan26
https://dl.todesktop.com/211201njqikvxkx/builds/211208i3mvsqrbs
This is beta build for the fixing, would you mind help me try it and confirm does this build really help?

Hi,
It's better, but still some errors showing up...
refi-app-0.0.10-build-211208i3mvsqrbs.AppImage.log

The min/max/close buttons on the top right side doesn't work for example
The link for "I don't know how to get credential file" doesn't open any browser window nor shows anything

But the dialog position is fixed (once you resize the window once)
The rest of the features seems to work properly.

Thanks for the feedback!
At first, when the app starts, it's maximized and half its window is white.
I have to double click on the top bar to un-maximize it. At this point,
everything looks great.
I can maximize again double clicking on the top bar but when I hover the
mouse on top of the min/max/close buttons, the icon doesn't change to
pointer (still arrow) and clicking has no effect.
To close the app, I have to terminate the process.
On Thu, Dec 9, 2021 at 2:39 AM Thanh Le @.***> wrote:

Hi
It's better, but still some errors showing up...
The error is because of beta can not connect to auto update, so it will
not be a problem in the production build
The min/max/close buttons on the top right side doesn't work for example
So you can not min/max/close from the beginning or after you resize the
window?
The link for "I don't know how to get credential file" doesn't open any
browser window nor shows anything
The issue has been known and will be fixed on the next release
Thanks for your support 💪
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thanhlmm/refi-app/issues/15#issuecomment-989408428,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAASPN7SYNIPPUGQHIXCIOTUQACFLANCNFSM5JFBVUPQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Fixed in v0.0.11


Fix client session auth method

Regression reproduced https://github.com/seamapi/javascript-http/pull/218

Regression seems to have been fixed. Anything else required here?


Remove deprecated things from crypto_compat.h and dependent tests.

Signed-off-by: TRodziewicz<EMAIL_ADDRESS>Description
Remove deprecated things in psa/crypto_compat.h. For more details see the originating issue.
Fixes: #4284
Status
READY
Requires Backporting
NO
Todos

[x] Tests
[x] Documentation
[x] Changelog updated

Note: the doxygen warning only occurs in the pr-merge job, so I think before you can reproduce and fix you need to merge the current development_3.0 into your branch:
git checkout remove_deprecated_things_in_crypto_compat_h
git fetch public
git merge public/development_3.0

(Replace public with the name of the remote that points to ARMmbed/mbedtls.git, you can check with git remove -v. If you don't have a remote pointing to that repo yet, you can get one by running git remote add public git@github.com:ARMmbed/mbedtls.git before running the above commands.)
Then you should be able to reproduce the issue y running tests/scripts/doxygen.sh and fix it. (Note: if your doxygen version is too recent, you'll also get other warnings which you don't need to fix, just fix the one that's also found by the CI. The others are already tracked elsewhere.)

The CI problem is a bug introduced by #4174 and fixed by #4318. It's present in the development_3.0 branch, which was last synched from development_2.x between the merge of these two PR. The proper fix would be to update the 3.0 branch.

Oh, so this can be ignored for the purpose of merging this PR. Thanks Gille for clarifying that.

Uh, sorry if I was unclear, I meant that we should wait to merge this PR until 3.0 is up-to-date. I've made a PR to update 3.0.
Never mind about merging this PR, let's just merge https://github.com/ARMmbed/mbedtls/pull/4366 quickly.

Aw, I'll review 4366 quickly then.


The value variable for each must either be a valid identifier (e.g. item) or a pair of identifiers in square brackets (e.g. [key, value]).

I installed eslint-plugin-pug in the pug project, and when I executed eslint to detect the file, it reported this error：
The value variable for each must either be a valid identifier (e.g. item) or a pair of identifiers in square brackets (e.g. [key, value]).
The specific error is as follows：
Error: Pug:127:34
125|           if offers.length > 0
126|             .house-offer-list

127|               each item in offers
------------------------------------------^
128|                 if item.agent
129|                   .house-offer-list-item
130|                     a.house-offer-main.flex-row.flex-vertical-middle(href='/agents/' + item.agentId)&attributes({ 'data-log': 2013 })
The value variable for each must either be a valid identifier (e.g. item) or a pair of identifiers in square brackets (e.g. [key, value]).
at makeError (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-error/index.js:34:13)
at Lexer.error (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:62:15)
at Lexer.eachOf (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1108:14)
at Lexer.callLexerFunction (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1647:23)
at Lexer.advance (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1676:12)
at Lexer.callLexerFunction (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1647:23)
at Lexer.getTokens (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1706:12)
at lex (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:12:42)
at Object.exports.parsePug (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/utils.js:48:20)
at exports.preprocess (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/utils.js:71:23)
husky > pre-commit hook failed (add --no-verify to bypass)
zhouliying:client-web-mobile FangGeek$ npm install
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^5.3.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

I installed eslint-plugin-pug in the pug project, and when I executed eslint to detect the file, it reported this error：
The value variable for each must either be a valid identifier (e.g. item) or a pair of identifiers in square brackets (e.g. [key, value]).
The specific error is as follows：
Error: Pug:127:34
125| if offers.length > 0
126| .house-offer-list

127|               each item in offers
------------------------------------------^
128|                 if item.agent
129|                   .house-offer-list-item
130|                     a.house-offer-main.flex-row.flex-vertical-middle(href='/agents/' + item.agentId)&attributes({ 'data-log': 2013 })
The value variable for each must either be a valid identifier (e.g. item) or a pair of identifiers in square brackets (e.g. [key, value]).
at makeError (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-error/index.js:34:13)
at Lexer.error (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:62:15)
at Lexer.eachOf (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1108:14)
at Lexer.callLexerFunction (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1647:23)
at Lexer.advance (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1676:12)
at Lexer.callLexerFunction (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1647:23)
at Lexer.getTokens (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:1706:12)
at lex (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/node_modules/pug-lexer/index.js:12:42)
at Object.exports.parsePug (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/utils.js:48:20)
at exports.preprocess (/Users/FangGeek/company_projects/client-web-mobile/node_modules/eslint-plugin-pug/utils.js:71:23)
husky > pre-commit hook failed (add --no-verify to bypass)
zhouliying:client-web-mobile FangGeek$ npm install
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^5.3.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

How can i solve it

As this is an error from pug-lexer, this means the syntax cannot be parsed. That's not an error in my plugin, that's a syntax error in your file. Indeed, trying to load a similar file with pug itself fails in the same way:
> const pug = require('pug')
> pug.compileFile('test/fixtures/wat.pug')
Uncaught Error: test/fixtures/wat.pug:2:22
    1| .house-offer-list
  > 2|   each item in offers
----------------------------^
    3|     if item.agent
    4|       .house-offer-list-item
    5|

The value variable for each must either be a valid identifier (e.g. `item`) or a pair of identifiers in square brackets (e.g. `[key, value]`).

What it doesn't like is the offers identifier, and it seems like… because it begins with of. For now just rename the variable :)
Reported to pug-lexer: https://github.com/pugjs/pug-lexer/issues/85


Implement redis utils

What this PR does / why we need it:
Redis utils are needed for task deduplication
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

How to use:
from dolphin import redis_utils

ru = redis_utils.RedisClient()
ru.add_key('task1', expire=3) // Expiration time is 3 seconds
print(ru.contains_key('task1')) // True
time.sleep(4)
print(ru.contains_key('task1')) // False, because the key has expired after sleep 4 seconds
ru.add_key('task1')
print(ru.contains_key('task1')) // True
ru.remove_key('task1')
print(ru.contains_key('task1')) // False
ru2 = redis_utils.RedisClient()
print(id(ru) == id(ru2)) // True. Singleton pattern used

Combined dolphin/alert_manager/constants.py and dolphin/common/constants.py into dolphin/common/constants.py

@ThisIsClark , all the review comments are closed? Is it ready for merge? Can you please add a comment

Distributed lock can be implement by tooz which is already in our project, so this PR would be closed.


Fix co-ordinate issue with display: contents nodes

I observed a bug with a custom table component I have implemented, based on prosemirror-tables . The issue arises from a conditional check in posAtCaret which will cause the position to use the doc.content.size when a zeroed out client rect is returned.

This commit adds an extra conditional check which will ignore any elements that have zero width and height. This seems like a sensible solution to me but please let me know if this is unwise.

Before this fix
A DOM setup like

CARET

table {
   display: contents
}

Would incorrectly return table.posAfter from posAtCaret instead of the pos of the internal <p node
The problematic line is here
https://github.com/ProseMirror/prosemirror-view/pull/177/files#diff-8711f18f44af6275714f55277ddd18fb124ab348b03cd4b86a4fdb253b205330R241
An element with display: contents will have a zerod client bounding rect. So it will always descend into this branch.
I believe my change will handle other edge cases where an element has a zero'd bounding rects

Does alternative patch bbd0ab2 solve this for you?


All changes done in avatar,input and submit button

Description
All required changes are done in an avatar, input, and submit button
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Closes #605

Type of PR

[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

Can you also make responsive for mobile too? Will award level 2


Update eclipse-che operator for openshift to release 7.22.0

Signed-off-by: Mykhailo Kuznietsov<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/ok-to-test

@mkuznyetsov can you please rebase to latest master?

/test all

@mkuznyetsov We are moving to github actions. Can you please rebase to latest master? Thanks

/ok-to-test

/retest

/lgtm


feat: improve commit issue number handling (#91)

This pull request improves the commit issue number handling in case there is no previous commit number including an small refactoring of variable names for default commands.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
310

Relevant Lines:
310

💛  - Coveralls


Some initial interceptor implementations

Describe This Problem
"Interceptor" is a hook point in sqlness, which allows people to write tests with extra functionality. E.g., provide per-case config, parameterized SQL or resource limitation etc.
Proposal
Some interceptable points I can think of are:

before query execution
after query execution
before one .sql file start

And I plan to add one simple interceptor implementation for each point as an example, and to see if this mechanism actually works.

Interceptor Name
Stage
Description

parameter
before execution
Allow to pass K-V like parameters as execution context to DB. Some pre-query setting can be done in this way, like query mode (e.g., whether oracle-compatible in MySQL) or current user.

replace-result
after execution
Allow to modify the query result with sed-like grammar. This is useful when you only care about some parts of the result, or your query will generate some random values.

time-limit
file level
Limit the total execution time for a .sql case

Additional Context
No response

before query execution

In datafusion, it support set statement to do this kinds of job.
https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sqllogictests/test_files/information_schema.slt#L30
As for other two cases, they seems not very useful in practice.
statement error Error during planning: SHOW TABLES is not supported unless information_schema is enabled
SHOW TABLES

Also I find this error declare is useful when our sql files have lot of cases, and we need to ensure which SQL will throw error.

In datafusion, it support set statement to do this kinds of job.

Yes, parameter is to provide something like this. DataFusion does support this, and as well as MySQL, PostgreSQL. But I'm doubting if this is a standard SQL grammar and, to my opinion, it's not a conflict for us (a test framework) to support this as well. Consider these scenarios:

My database is distributed on A, B and C, I set data distribution rules for my table and I want to verify it. I execute a distributed insert, and want to connect to A, B, and C to do a non-distributed query. I want to know what query will be sent to which instance.
My database implementation simply does not support SET, but I want to change my configuration via APIs other than SQL like HTTP.

Those are two practical examples I come up with, and are relying on test context. The parameter are the way to provide context to each SQL.

As for other two cases, they seems not very useful in practice.

Post-process like replace-result is widely used in MySQL's integration test. It's very normal for a query to results in random values. What if you query random(), current_time(), or system table for current memory consumption? I'm not care about the actually value, but just want to make sure they works, or can match some fixed pattern.

Also I find this error declare is useful when our sql files have lot of cases, and we need to check which SQL will throw error.

If I read it correctly, the error message will present in .result file next to the query resulting it?

My database is distributed on A, B and C, I set data distribution rules for my table and I want to verify it. I execute a distributed insert, and want to connect to A, B, and C to do a non-distributed query. I want to know what query will be sent to which instance.

This example make sense to me, as for other aspect, I think we can wait until some real world issue arise .
The first principle I obey is to stick with SQL, if SQL can fix it, then we don't have to, it bring little value to this project IMO.

If I read it correctly, the error message will present in .result file next to the query resulting it?

I usually check SQL file to see how many cases have been added, but I can't tell the bad cases from the good one, I don't care what this SQL will output, I only want to know which SQL will throw error.
Maybe we can add a ERR: <reason> special syntax to declare it(this may belong to your first proposal parameter).
-- ERR: don't support XX type now
create table t(a XX);

My database is distributed on A, B and C, I set data distribution rules for my table and I want to verify it. I execute a distributed insert, and want to connect to A, B, and C to do a non-distributed query. I want to know what query will be sent to which instance.

This example make sense to me, as for other aspect, I think we can wait until some real world issue arise .

Nice, I'll start working on this one.

The first principle I obey is to stick with SQL, if SQL can fix it, then we don't have to, it bring little value to this project IMO.

I agree. But how do I test a random() function or results contains timestamp. I think this is also a necessary part to accomplish SQL's functionality.

If I read it correctly, the error message will present in .result file next to the query resulting it?

I usually check SQL file to see how many cases have been added, but I can't tell the bad cases from the good one, I don't care what this SQL will output, I only want to know which SQL will throw error.
Maybe we can add a ERR: <reason> special syntax to declare it(this may belong to your first proposal parameter).
-- ERR: don't support XX type now
create table t(a XX);

That makes sense. We should preserve the comment in the result file. (maybe comment is enough? Is it necessary to add new syntax?)

I agree. But how do I test a random() function or results contains timestamp. I think this is also a necessary part to accomplish SQL's functionality.

It's possible to remove random value in this way
select count(random())

Then I'd ask as a user, why this framework doesn't support SQL like random() and force me to write redundant SQL?
And the second use case, how do I test a system table query? E.g., I expect to see the node info, but want to ignore the memory usage to each node because it changes time by time. Do I have to project out that column? Then what about if my query contains timestamp column? I don't think this way is a good practice. "fix it by SQL" should be "I want to project some column, and the SQL does support projection", but not "I don't want to project column, but the framework forces me to make projection". The SQL query result is naturally unstable in most cases. That is the point we should stick to and add support for.
Require every SQLs to be stable reproducible because we are a text comparison based framework. That doesn't look good 😥

That makes sense. We should preserve the comment in the result file. (maybe comment is enough? Is it necessary to add new syntax?)

I prefer hard requirement, comment is optional.

What do you mean by hard-requirement? Isn't the original goal to make the case readable?

Then I'd ask as a user, why this framework doesn't support SQL like random() and force me to write redundant SQL?

I'm not very strong about this, I just think we should keep result as 'static' as possible, replace-result interceptor indeed has its value, and wait to see your implementation.

What do you mean by hard-requirement? Isn't the original goal to make the case readable?

hard requirement means if we must add -- ERR: xx prefix for bad sql, otherwise next SQL should not throw error.
I think it's not conflict with readability, instead it make more clear what the SQL will do.

hard requirement means if we must add -- ERR: xx prefix for bad sql, otherwise next SQL should not throw error.
I think it's not conflict with readability, instead it make more clear what the SQL will do.

Got it. This is already covered by now? If a query returns an error, it result would be something like ERR: xxx (depending on how the user formats their result). And re-run it should also return that error.

Got it. This is already covered by now?

Not exactly, we have to check result file to ensure this, what I want is to declare this in original SQL
statement error DataFusion error: Error during planning: table 'datafusion.information_schema.tables' not found
SELECT * from information_schema.tables

Like this in sqllogcitest.

Oh, like "should_panic" or "statement err", right? We can have a try. But I'm not sure if we should also take xxx into consideration, as it's duplicated with the follow-up full-text-match.

Oh, like "should_panic" or "statement err", right?

Yes.

Maybe left the reason part to only be a comment?

Comment seems OK to me.


Android app has No static method AnimatedContent issue while using voyager transitions

Hi, if we use voyager transitions, then while using SlideTransitions, we gets following issue:
java.lang.NoSuchMethodError: No static method AnimatedContent(Ljava/lang/Object;Landroidx/compose/ui/Modifier;Lkotlin/jvm/functions/Function1;Landroidx/compose/ui/Alignment;Ljava/lang/String;Lkotlin/jvm/functions/Function4;Landroidx/compose/runtime/Composer;II)V in class Landroidx/compose/animation/AnimatedContentKt; or its super classes (declaration of 'androidx.compose.animation.AnimatedContentKt' appears in /data/app/~~uvpuGkDwHhiCxB5RhweCgQ==/com.myapplication.MyApplication-Gmp19aONK-S9FmvOuDVCgg==/base.apk)
                 	at cafe.adriel.voyager.transitions.ScreenTransitionKt.ScreenTransition(ScreenTransition.kt:46)
                 	at cafe.adriel.voyager.transitions.SlideTransitionKt.SlideTransition(SlideTransition.kt:31)
                 	at ComposableSingletons$TabContentKt$lambda-1$1.invoke(TabContent.kt:33)
                 	at ComposableSingletons$TabContentKt$lambda-1$1.invoke(TabContent.kt:32)

its working fine for other platforms, but on android we have this issue.
Is there any workaround available for this?
Affected platforms
Android
Versions
Kotlin version*: 1.8.20
Compose Multiplatform version*: 1.4.0
voyager: 1.0.0-rc06
To Reproduce
I have created a reproducer for this issue, please checkout this repo:
https://github.com/sunildhiman90/compose-multiplatform-template-with-navigation
and choose the branch with-voyager-navigation
Try to build for androidApp.
It should reproduce this bug

Make sure you are implementing Compose Animation and that your Jetpack Compose version is not using the 1.5 alphas

Thanks @Syer10 , i was missing the compose animation dependency in commonMain source set, it worked now.
PS: But i think it should be mentioned in documentation that if we want to use voyager navigation, then we should add compose animation dependency as well. thnx

@Syer10 Is there a plan to support the 1.5 of compose animation? It's in beta now so the API should be stable

It will likely only be supported when its fully released. Voyager uses Compose Multiplatform, which doesnt support Jetpack Compose alphas and betas.

@Syer10 Nice to know, thanks for the info! :)

java.lang.NoSuchMethodError: No static method ModalBottomSheetLayout-BzaUkTc(Lkotlin/jvm/functions/Function3;Landroidx/compose/ui/Modifier;Landroidx/compose/material/ModalBottomSheetState;Landroidx/compose/ui/graphics/Shape;FJJJLkotlin/jvm/functions/Function2;Landroidx/compose/runtime/Composer;II)V in class Landroidx/compose/material/ModalBottomSheetKt; or its super classes (declaration of 'androidx.compose.material.ModalBottomSheetKt' appears in /data/app/~~9VpmHhRmwrZmqa_WNbIn_Q==/com.markaz.app.qa-nncJogGQRKKeRRBhTRBn9A==/base.apk)
at cafe.adriel.voyager.navigator.bottomSheet.BottomSheetNavigatorKt$BottomSheetNavigator$1$2.invoke(BottomSheetNavigator.kt:77)
at cafe.adriel.voyager.navigator.bottomSheet.BottomSheetNavigatorKt$BottomSheetNavigator$1$2.invoke(BottomSheetNavigator.kt:76)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
I am also facing the similar issue with ModelBottomSheet, can you guyz please help me out on it, I have tried a lots of the things but nothing worked out

@adrielcafe Any updates about this?

about animatedContent look for my comment here #120

Fixed on 1.0.0-rc07.


To add a calculator for calculating radius of Escribed circle of triangle

Is your feature request related to a problem? Please describe.
To add a calculator for calculating radius of Escribed circle of triangle

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018

Go ahead
Deadline 22 May,2021


RTD Support

Description
ReadTheDocs support
Rationale
Hosting an open-source website with documentation
Also somewhat of a bug report because you need a .readthedocs.yml (I think) file in order to pip install the local.txt packages.
Use case(s) / visualization(s)
Developers for an open-source (or closed-source) website can easily read up on how the website functions.

More details on the .readthedocs.yml file:
https://docs.readthedocs.io/en/stable/config-file/v2.html
Agree that we need to at least configure the requirement file to use, and probably also the python version. Not sure if we can set environment variables to avoid similar issues as in #2674

Hm so long as .envs/.local environment variables are set, we can use the USE_DOCKER environment variables to force Django-environ to read the env files.

@browniebroke I'm currently testing the RTD support for a PR in a few. Primary concern is, in the conf.py file, I have:
import os
import sys
import django

if os.getenv("READTHEDOCS", default=False) == "True":
	sys.path.insert(0, os.path.abspath(".."))
	os.environ["DJANGO_READ_DOT_ENV_FILE"] = "True"
	os.environ["CELERY_BROKER_URL"] = "redis://redis:6379"
	os.environ["USE_DOCKER"] = "no"
	master_doc = "_source/index"
else:
	sys.path.insert(0, os.path.abspath("/app"))
os.environ.setdefault("DATABASE_URL", "")

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "config.settings.local")
django.setup()

The build is passing... but there's no documentation :P If you can spot a reason why, I'd love to hear it and try it out. The previous builds failed but adding the master_doc worked out. Unfortunately, that means none of the .rst files are actually documented...........
In the meantime... I'm curious, for celery support, in the settings/base.py files, can we set the default to REDIS_URL?


<EMAIL_ADDRESS>type errors

type props
type params

let getServerSideProps: Next.GetServerSideProps.t<props, params, _>
let default: props => React.element

params is typed as a Js.t<'params> within Next.res, which means that the params type must be of type {. } (instead of being abstract).
I will relax that definition on master.

Check https://github.com/ryyppy/rescript-nextjs-template/commit/260c38abd095430a3b15e18ac2908e1ef61953c9


add goroutines example

There are often questions about how to use this lib with Goroutines (i.e. #3 , DataDog#49). There's an extensive blogpost on the topic, but it's for sbinet/go-python. We should add an example (in the examples/ dir).

Hi, @christian-korneck
I've prepared the PR that includes that example. I also up to dated еру example and tested it to be sure that it works well.
Unfortunately, I'm not sure that I've done well all things about opening PR and so on. Please feel free to highlight my mistakes if they are here.
Thank you!


feat(sdk): fetch list of required attestations from trust registry

Codecov Report
Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.03%. Comparing base (8baf56a) to head (cc08c3d).

Files
Patch %
Lines

cmd/wallet-sdk-gomobile/trustregistry/model.go
0.00%
4 Missing :warning:

...allet-sdk-gomobile/trustregistry/trust_registry.go
71.42%
2 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   89.18%   89.03%   -0.15%
==========================================
  Files         104      104
  Lines        4504     4516      +12
==========================================
+ Hits         4017     4021       +4
- Misses        315      321       +6
- Partials      172      174       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update IFEval dataset to official one

This PR updates the IFEval dataset to the one hosted under the Google org: https://huggingface.co/datasets/google/IFEval
Note the main change is an updated prompt from this commit in the GitHub repo: https://github.com/google-research/google-research/commit/26d8ccdab6fec61b5c83ad6327ea8bda9e580288

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Solve a bug in Disqus

Description
Disqus can't be loaded due to an uncaught syntax error: Identifier 'modeToggle' has already been declared at elsewhere. The solution is to use another name.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How has this been tested

[ ] I have run bash ./tools/test (at the root of the project) locally and passed
[x] I have tested this feature in the browser

Test Configuration

Browser type & version: Chrome
Operating system: MacOS
Ruby version:
Bundler version:
Jekyll version:

Suggestions accepted.


"Copy URL" Button on Restore Page Not Working

The "Copy URL" button on the restore page is intended to copy the URL of the restored tab to the clipboard. However, when clicked, it does not perform the expected behavior, and the URL is not copied to the clipboard.
Version Affected:

1.1.8

The functionality of the button on the restore page has been changed. Previously labeled as "Copy URL", it was intended to copy the URL of the restored tab to the clipboard.
However, given that the restore page is served as a Base64-encoded data URL, this environment doesn't meet the usual criteria for clipboard access, and thus the behavior is changed.
Now, when clicked, it will directly open the specified link in a new browser tab.
Version Updated:

1.1.9


doArchive (and other destructive actions) should bypass form validation

Affected Version
^4
Description
Because they're form actions, there doesn't seem to be any way to bypass form validation when doing destructive actions. This means you have to make sure a form has valid data before deleting/archiving.
Steps to Reproduce

Build a dataobject with a getCMSValidator()
Add the Versioned extension
Create it in a grid field
Leave the form empty, ensuring a required field is empty
Click the "Archive" action
See that the action is not completed. Form is invalid.

NB: Since GridFieldDetailForm_ItemRequest::doDelete() is also a form action, you can likely reproduce this without Versioned using "Delete". Have not tested.

We've learnt to live with this, but it'd be a nice fix, yes please :)

IIRC we have a Form::setValidationExemptActions() method for this use case 👍

Brilliant find, @kinglozzer ... we can actually action this as a simple fix now. Will update issue.


DataGrid jumps back and forth when scrolling upward with multiple row heights

Describe the bug
When using a DataGrid that has varying line heights due to newlines or wordwrap, using the mouse wheel to scroll shows a lot of jumping around when scrolling upwards, but not when scrolling downwards

Scrolling downward works mostly as expected with consistent pixel movements down, and only a few jumps backwards by the scrollbar
Scrolling upward does not work as expected, with the rendered view & scrollbar jumping forward and backwards

To Reproduce

Clone the sample repo here: https://github.com/garyhertel/AvaloniaDataGridMultipleRowHeights.git
Start the sample
Note how every other line is "aaa" and "b\n" x10
Try scrolling down with a mouse wheel and watch the numbers on the left and scrollbar position
Try scrolling upward with a mouse wheel watching the same numbers on the left and scrollbar position
The view and scrollbar will sometimes jump backwards instead of forwards when scrolling up

Expected behavior
Scrolling upward and downward should be as smooth as possible with no view jumps and minimal scrollbar jumps
Screenshots
Initial position, note how 91 is the first element

After scrolling up one time, 92 is now the first element, which shows the view jumping downwards instead of upwards since it should have changed to 90

Desktop (please complete the following information):

OS: Windows 10 Pro

Additional context
Possibly related issue? Although it doesn't use different line heights.
https://github.com/AvaloniaUI/Avalonia/issues/12494

Excuse me, can this issue be solved?

There's at least no easy fix for it. It's the price for being virtualized which is a huge performance benefit. So for now we have to accept that limitation.

FWIW this is probably still my number one issue that I really wish would get fixed for Avalonia.
It's pretty frustrating trying to scroll around in an Avalonia DataGrid with mixed line heights, especially for log messages that vary in height so much. A lot of the time I even give up on using the mouse wheel and instead use the scroll bar because it just doesn't work otherwise.
I'm not sure I recall seeing this issue with other DataGrids I've used either, so I wonder if it's possible to fix this somehow? Although this definitely sounds like a hard problem to solve so I'm not sure. Maybe the others are just using a non-virtualized mode for small collections? Which might still be helpful if that's in the 100 to 1000 range?

You can use a ListBox with custom ItemPanel. Use a Grid with SharedGridSize in your ItemTemplate and you are almost there. DataGrid is a beast and not as easy to customize.
Sure, if you knew how to improve scrolling, a PR would be welcome.


refactor!: Optimize serialization and make it compatible with more data formats

My previous use of serde wasn't compatible with many data formats other than JSON, particularly those that serialize enum discriminants as integers rather than strings, and those that require the size of a map to be specified at the start of serialization.
To solve this, I've refactored the node structs internally. The dynamic properties are now stored in their own struct, and only that struct needs custom implementations of Serialize and Deserialize.
I also made serialization and deserialization more efficient by serializing the bitmasks for the actions and flags directly, rather than serializing the actions as a sequence and the flags as key/value pairs in the outer map.
The serialization to JSON, and similar formats, is now less human-friendly than it was. The dynamic properties are now stored in a sub-object inside the node object, and the actions and flags are now serialized as integers rather than something self-describing. But, in the real-world uses of serialization that are now important to us, like Newton, efficiency is more important than human readability. Newton will almost certainly switch from JSON to a binary format, like postcard or GVariant.

The only downside I see with the JSON serialization being less human friendly is that I'd like UI toolkit developers to use serialized tree updates in non-regression testing at some point, akin to comparing screenshots to detect undesirable changes to styling. But that's only a minor inconvenience and I won't block on it. I'll finish reviewing this soon.


Focus on button

Hi, I have a necessity to use focus on Button, for my project I create a provider to do this, but I would like to know if is possible to include this on the component?
Thank you very much

@gmondin sure! welcome to submit PR

For the focus on the button, I used the same way that you are using on input focus, so the code will be like this.
(your code 🙂)
I needed this because for my kind of project, the users has a barcode reader, so they normally use only the fisical keyboard, to be more faster.
ButtonBase.cs
[cid:36cff064-fd8f-4f6a-8614-80af80e17ac2]
[cid:e5c86717-46b1-4e18-8e3b-e1966cae02fb]
Button.razor
[cid:75973bee-070b-48e3-a3f5-6668bf959b67]
Gabriel Mondin

De: Argo Zhang @.>
Enviado: terça-feira, 26 de abril de 2022 13:15
Para: dotnetcore/BootstrapBlazor @.>
Cc: Gabriel Mondin @.>; Mention @.>
Assunto: Re: [dotnetcore/BootstrapBlazor] Focus on button (Issue #179)
@gmondinhttps://github.com/gmondin sure! welcome to submit PR
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnetcore/BootstrapBlazor/issues/179#issuecomment-1109668498, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARSXSM5KWKJ5XUJLDGHTJRLVG7F5VANCNFSM5UK2MAYA.
You are receiving this because you were mentioned.Message ID: @.***>

Can I ask, in cases like this its opened for I change the code and submit on git hub or I need some special access? also for keep the same standard that you do.
Thank you very much
Gabriel Mondin

De: Argo Zhang @.>
Enviado: terça-feira, 26 de abril de 2022 13:15
Para: dotnetcore/BootstrapBlazor @.>
Cc: Gabriel Mondin @.>; Mention @.>
Assunto: Re: [dotnetcore/BootstrapBlazor] Focus on button (Issue #179)
@gmondinhttps://github.com/gmondin sure! welcome to submit PR
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnetcore/BootstrapBlazor/issues/179#issuecomment-1109668498, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARSXSM5KWKJ5XUJLDGHTJRLVG7F5VANCNFSM5UK2MAYA.
You are receiving this because you were mentioned.Message ID: @.***>

Now that I saw that didin't show up the images, so:
(its your code for focus on input)
ButtonBase.cs
protected ElementReference FocusElement { get; set; }
public ValueTask FocusAsync() => FocusElement.FocusAsync();
Button.razor
<button @ref="FocusElement" />
Thank you very much

@gmondin hi, sorry for the delay reply. can you create a new repro let us figure out this issue, or you can submit a PR for this issue

HI, no problem for the delay, I have use the same code for the FocusAsync() that is using for input and works really well.
Thank you very much
Gabriel Mondin

De: Argo Zhang @.>
Enviado: segunda-feira, 2 de maio de 2022 06:47
Para: dotnetcore/BootstrapBlazor @.>
Cc: Gabriel Mondin @.>; Mention @.>
Assunto: Re: [dotnetcore/BootstrapBlazor] Focus on button (Issue #179)
@gmondinhttps://github.com/gmondin hi, sorry for the delay reply. can you create a new repro let us figure out this issue, or you can submit a PR for this issue
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnetcore/BootstrapBlazor/issues/179#issuecomment-1114494285, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARSXSM26DRLDV2Y6AXGWCUTVH5M53ANCNFSM5UK2MAYA.
You are receiving this because you were mentioned.Message ID: @.***>

@gmondin that's good. i wanna add the following parameter on ButtonBase
[Parameter]
public bool IsAutoFocus { get; set; }

the default value is false. can this match your requirement?

Hi, I think is better use this one, because for my case is not autofocus, but after some information and I can't put automatic, I need that the user confirm the action.
ButtonBase.cs
protected ElementReference FocusElement { get; set; }
public ValueTask FocusAsync() => FocusElement.FocusAsync();
Button.razor
<button @refhttps://github.com/ref="FocusElement" />
what do you think?
Gabriel Mondin

De: Argo Zhang @.>
Enviado: segunda-feira, 2 de maio de 2022 10:12
Para: dotnetcore/BootstrapBlazor @.>
Cc: Gabriel Mondin @.>; Mention @.>
Assunto: Re: [dotnetcore/BootstrapBlazor] Focus on button (Issue #179)
@gmondinhttps://github.com/gmondin that's good. i wanna add the following parameter on ButtonBase
[Parameter]
public bool IsAutoFocus { get; set; }
the default value is false. can this match your requirement?
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnetcore/BootstrapBlazor/issues/179#issuecomment-1114603879, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARSXSM3SMAGZDHB2C2XBEEDVH6FARANCNFSM5UK2MAYA.
You are receiving this because you were mentioned.Message ID: @.***>

@gmondin i provider a instance method. you can use @@ref keywork and call it directly
public void Focus()
{
    FocusElement.FocusAsync();
}

Yep, this is the solution that I need, but, sorry, I dont understand, I couldnt found focus on button, also using @ref, are you saying that this alread exist or you gonna provider on the nexts milestones?
Gabriel Mondin

De: Argo Zhang @.>
Enviado: segunda-feira, 2 de maio de 2022 10:34
Para: dotnetcore/BootstrapBlazor @.>
Cc: Gabriel Mondin @.>; Mention @.>
Assunto: Re: [dotnetcore/BootstrapBlazor] Focus on button (Issue #179)
@gmondinhttps://github.com/gmondin i provider a instance method. you can use @@refhttps://github.com/ref keywork and call it directly
public void Focus()
{
FocusElement.FocusAsync();
}
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnetcore/BootstrapBlazor/issues/179#issuecomment-1114621703, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARSXSM5TQP7E4FIBP2KZBZDVH6HSBANCNFSM5UK2MAYA.
You are receiving this because you were mentioned.Message ID: @.***>

@gmondin later, I will let you know

thank you very much
Gabriel Mondin

De: Argo Zhang @.>
Enviado: segunda-feira, 2 de maio de 2022 11:07
Para: dotnetcore/BootstrapBlazor @.>
Cc: Gabriel Mondin @.>; Mention @.>
Assunto: Re: [dotnetcore/BootstrapBlazor] Focus on button (Issue #179)
@gmondinhttps://github.com/gmondin later, I will let you know
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnetcore/BootstrapBlazor/issues/179#issuecomment-1114644864, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARSXSM2M3GN64XAY2WXQN53VH6LMBANCNFSM5UK2MAYA.
You are receiving this because you were mentioned.Message ID: @.***>

@gmondin hi, I had submit 6.5.19 version on Nuget.org. later you can try it.
add IsAutoFocus parameter
[Paramter]
public bool IsAutoFocus { get; set; }

add FocusAsync method
public ValueTask FocusAsync() => ButtonElement.FocusAsync();

you can use it as the following code
<Button Text="Test" @ref="FocusButton" />

@code
{
      private async Task Test()
      {
            await FocusButton.FocusAsync();
      }
}

thank you very much :)

@gmondin can you give the repo a star? at the top right of the page

sure :)

@gmondin  thanks


fix: crash when call BluEye function in Editor

Could you be a bit more specific about what caused the crash?

Hi Aaron,
Crash 100% reproducible when I run game in the Editor window ("Selected Viewport"). In this mode BluEye initialization is skipped and browser is not created. So call of any function that depends on browser leads to crash.
Here are lines from UBluEye::init():
void UBluEye::init()
{
	/**
	 * We don't want this running in editor unless it's PIE
	 * If we don't check this, CEF will spawn infinit processes with widget components
	 **/
	if (GEngine)
	{
		if (GEngine->IsEditor() && !GWorld->IsPlayInEditor())
		{
			UE_LOG(LogBlu, Log, TEXT("Notice: not playing - Component Will Not Initialize"));
			return;
		}
	}
	...

Thus initialization is interrupted and variable browser is not initialized (NULL).
When I call for example function IsBrowserLoading I get Memory Access Violation.
bool UBluEye::IsBrowserLoading()
{
	return browser->IsLoading();
}

UE4.8.3
Thanks for such great plugin!)

Ah I see. I'm going to look into this issue a bit further to see if there's something else that can be done. Thanks for the report!

I'm not able to reproduce this crash. Playing in editor, simulating in editor, and playing in selected view-port are not crashing the demo

I'll check in the Demo and try to reproduce it.

Currently the  public demo needs to be updated to 4.9 and BLUI 3.1. Locally I've tested in 4.9 and 4.8 (newest minor release)

Here is a sample project. While I was making this sample, I have noticed that behavior is different when we create BluEye Instance in Construct and when we create Instance later on some Event. Crash is reproducing only in the second case.
I have removed ThirdParty folder from plugin to reduce the size. I am using BLUI 3.1 from Release (https://github.com/AaronShea/BLUI/releases/download/3.1/BLUI.3.1.Windows.Linux.CX.zip)
Sample: https://drive.google.com/open?id=0B9pKJqA0bh7SdVJ3ZXFOU3ZpY00

Seems I've figured out the issue.
When you construct a new BluEye on Event Contract GEngine->IsEditor() and GWorld->IsPlayInEditor() return their expected values.
However:
When the editor is already running, both of these are false. Which is very odd behavior.

In fact, even GEngine->IsInBlueprint() is false when triggered from a button press.

https://github.com/AaronShea/BLUI/commit/73d4be57b0c1bc454e2bc6bf01a0bd9a8eee1495
This fixes it all, no need for checked in every method. Thanks!

Thanks!


Case sensitive field names in sql queries #47

Just a silly question, but why are we adding double quotes if we changed all column names to lower case?

Not silly. The problem comes from the use of field names in user datasets like "My colum", "Lat point" and alike

Ping me when it's ready, so I can rebase at metrics PR


Update ConfirmationPage.tsx

changed "Get invite link in you mail" to "Get invite link to your mail"

Hello someone made a pr about this recently, to prevent this in future make sure the issue is not assigned to anyone before working on it.


Separate "Timed Race" and "Timed Trial" game modes

Why are these two listed under the same abbreviation?
In Timed Trial (should be named "Time Challenge") you have to reach time gates to increase your remaining time and not get eliminated, whereas Timed Race is the same as a Speed Race but with a time limit. They are considerably different modes. If any should be grouped together it should be Timed Race and Speed Race.

I forgot why I typed it as “Timed Trial”, but I think you’re right, I should have separated those two modes.

Any preference for the abbreviations?
e.g.

Mode
Abbr.

Timed Race
Tr

Time Challenge
Tc

Ah, wait. Was just going through these and found a "Time Trial", so there are actually 3 different time-related game modes.
For reference:

Mode
First Chapter

Time Challenge
2-5

Timed Race
1-1

Time Trial
7-2

Are you able to confirm which of the Chinese game mode names match up to each?

Any preference for the abbreviations?

Yeah that looks good. As for Time trail, perhaps Tt?

Abbr.
En
Zh

Tc
Time Challenge
限時挑戰賽

Tr
Timed Race
限時賽

Tt
Time Trial
計時賽

Thanks.
Similar, yes. I suppose that is why you combined them before. Also, there are only 3 Time Trials.
Time Trial is the normal Time Trial mode; essentially Speed Race without any opponents. Timed Race on the other hand is a Speed Race but with a time limit high enough that you shouldn't ever fail; not sure why they made that one.


'Tutorial' window buttons are confusing

At least in the English version of the game, the buttons are a bit unclear.

Currently, the dialog window displays: "Tutorial - Let's learn how to play!"  with the options 'SKIP'  and 'GO'.
I like that there is a great tutorial for any new players, but as a hurried person that just wants to play the game, I would expect the function of the 'GO' button to be to start the game and I have mis-clicked it multiple times.
I suggest renaming the buttons to 'INSTRUCTIONS' or 'GUIDE'    and   'START' or 'PLAY', and also change the order (with the button for 'no tutorial' on the right hand side), and binding that button to the 'enter' key, or give it 'KeyFocus'.

Haha, good catch, I also click on the wrong button half of the time. I'll change the wordings 👍

Thanks, please consider moving the play button to the right side as well.


Remove vdb from the code base

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (65bfd55) 100.00% compared to head (5133b0e) 98.82%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #370      +/-   ##
===========================================
- Coverage   100.00%   98.82%   -1.18%
===========================================
  Files           21       21
  Lines         2224     2209      -15
===========================================
- Hits          2224     2183      -41
- Misses           0       26      +26

Files
Coverage Δ

src/viztracer/__init__.py
100.00% <ø> (ø)

src/viztracer/functree.py
100.00% <ø> (ø)

src/viztracer/main.py
97.92% <ø> (-2.08%)
:arrow_down:

src/viztracer/tracer.py
100.00% <ø> (ø)

src/viztracer/viztracer.py
95.78% <ø> (-4.22%)
:arrow_down:

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add restamp for only specific pages

This aims to add restamp for specific pages https://github.com/TimvdLippe/iron-lazy-pages/issues/31

Thanks for this nice project !


Add Godot exclusive content tutorial

What type of PR is this? (check all applicable)

[x] Adding new(s) ressource(s)

Else :
[ ] Added icon to right of the link
[x] Checking if the ressource is not already writed

[ ] Update About Web Monetization part

[ ] Update asset(s)

Else :
[ ] Height is 16px
[ ] Format is png

Description
Adds Innkeeper Game's exclusive content tutorial (https://innkeepergames.com/how-to-monetize-a-godot-game-with-web-monetization) to the Tutorials section. The tutorial includes links to a demo and source code.

Thanks for your help @blakeearth !


T35591 Add remaining general blocks

This completes the port for blocks that don't depend on the node class.
Changes compared with #147:

The definitions for sound, graphics and "await_scene_ready" blocks were missing.
Added some missing defaults too.

https://phabricator.endlessm.com/T35591

I didn't look super closely at every commit, but they seem correct. Since these changes are primarily copied from #147, I think it would be nice to retain @wnbaum as the author of the commits. Like git commit --amend --author='Will Baumgartner<EMAIL_ADDRESS>
Good point! Although most of this is not in #147 I will add @wnbaum as co-author.


[fragment] Generalize download code

A lot of the code in hls and dash are identical. This PR attempts to merge the common parts of the code from both into the fragment base class.
Any small bug in this code could have serious consequences. So a lot of testing is required. Also, if someone could review the changes, it would be appreciated

Maybe request a review from @shirt-dev since it was mostly (if not all) of his code?

I tested this branch a little bit and it's bugged for me.

[TubiTv] 577958: Downloading JSON metadata
[TubiTv] 577958: Downloading m3u8 information
[MetadataFromField] parsed myindex from "webpage_url": 1
WARNING: Could not interpret video %(series)s - S%(season_number)sE%(episode_number)s as "^(?P.+ - S\d+E\d+)$"
[info] 577958: Downloading 1 format(s): 1358
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 427
[download] Destination: D:\Temp\TubiTv\S01 -E01 - DOME (Dub) - 1.mp4
WARNING: The download speed shown is only of one thread. This is a known issue
[download] 100.0% of ~230.27MiB at  3.13MiB/s ETA 00:00     ERROR: unable to download video data: [Errno 2] No such file or directory: 'D:\Temp\TubiTv\S01 -E01 - DOME (Dub) - 1.mp4.part-Frag30'

It starts building the part file but looks like it's failing to download some fragments (I'm not sure if it's missing at download or during merging into part file).

@Jules-A Looks similar to #373. Did you pull the changes that I made today?

@Jules-A Looks similar to #373. Did you pull the changes that I made today?

I downloaded from this branch as of https://github.com/pukkandan/yt-dlp-dev/commit/e9d5be237aa9c641e3361bb0bfdce033dae8b66c so it's currently missing 3 unrelated commits.

Please give the URL so that I can test. Btw, always post the whole log. The verbose header shows the passed options, git HEAD etc so that I dont need to ask for each thing one by one

Please give the URL so that I can test. Btw, always post the whole log. The verbose header shows the passed options, git HEAD etc so that I dont need to ask for each thing one by one

https://tubitv.com/tv-shows/577958/s01-e01-dome-dub?start=true
log.txt

I can reproduce the issue, but cant seem to figure out why it is happening. I'll have another look tomorrow

https://tubitv.com/tv-shows/577958/s01-e01-dome-dub?start=true
log.txt

There was a race condition where multiple threads where trying to modify ctx at the same time causing some filenames to get become associated with the wrong fragment. This has now been fixed
While fixing this, I also figured out how to append fragments as they download. So this PR now closes #359


Document Windows service installation

I managed to wrap ra-multiplex server into a Windows service so that it's now always available in background and figured it might be worth documenting.
In the future we might want to look into something like https://github.com/mullvad/windows-service-rs to provide a native service implementation.

That's fair. It's a fairly common tool for this particular task, but then, I didn't know about it either as I didn't have to wrap arbitrary commands into custom services before, it's a somewhat obscure task.
Ideally I'd go for tools from more popular toolsets like Sysinternals or Nirsoft instead, but they don't have such service wrappers.
I think the ideal solution would be for a-multiplex to provide a Windows service interface on its own, like via the crate mentioned above, but I'm not sure if it's something you'd want to spend time looking into, so a wrapper tool seemed like a better solution in the interim.


New OpenAI's Feature Request

Do you guys are planning to add new Open API's new Realtime API, you can use the power of voice + tools to build custom voice experiences. Any Response to this message is greatly appreciated, Thank you.

Yes i have plans.

Great, Thank you for the reply. Waiting for this update.


[GAL-3611] Post Composer [mobile]

Changes

Add Post composer screen to the mobile
Hide it behind the feature flag KOALA
Add new component for <Toast/>. It will have similar API as in web codebase

Demo
Overall Workflow
https://github.com/gallery-so/gallery/assets/4480258/e08e2386-0e5c-4b1c-b7c4-ca20ed2fa1a2
Post Input Warning Message
https://github.com/gallery-so/gallery/assets/4480258/1f51e299-9580-43be-95ac-a08fc0b2a955

@kaitoo1 Updated the 2 comments regarding TextInput and latest dark mode styling
https://github.com/gallery-so/gallery/assets/4480258/d7231cfa-3e37-4461-acbe-291afce3e1e2


Calendar Formatting Bug

Seems that when clicking into the calendar into a date without a daily note, a new daily note is created with "YYYY-MM-DD" formatting instead of "YYYY_MM_DD" formatting which is not supported by LogSeq.

@xyhp915 was this fixed in your latest release? I'm hoping to re-enable this plugin once this is resolved. Thanks!

@xyhp915 was this fixed in your latest release? I'm hoping to re-enable this plugin once this is resolved. Thanks!

Have fixed format-related issues. Could you try the latest version app with the newest calendar plugin to check it out?
Ping me anytime if have any issues.