Does not appear to work in Firefox...with multiple subscribers

In FireFox if you have two elements both listening for the same signal, neither reacts to the signal.
THIS DOES NOT WORK
element-one
< lite-signal on-lite-signal-somesignal="somefunction" >< /lite-signal >
element-two
< lite-signal on-lite-signal-somesignal="somefunction" >< /lite-signal >
THIS DOES
element-one
< lite-signal on-lite-signal-somesignal="somefunction" >< /lite-signal >
element-two
< lite-signal on-lite-signal-someothersignal="somefunction" >< /lite-signal >

Thanks for the report.
If possible, are you able to reproduce it in a bin? see https://jsbin.com/xewuraw/edit?html,output for a Polymer example.
Firefox still depends on polyfill, no native custom elements.

Well I tried to set up the bin, but I doesn't seem to work.  How do I import external components like lite-signals?.  Also, kinda of need multiple components in order to have multiple listeners.  I would be happy to share my test environment via ngrok a little later.
here is the bin I set up but I can't even get the working case to work:
https://jsbin.com/fatinar/edit?html,console,output

Thanks. I did not publish lite-signal to the bower registry 😅, now it is there.
Managed to reproduce the success use case in Chrome. But for some reason this bin isn't working in FF
https://jsbin.com/jihezehoko/1/edit?html,console,output
I managed to reproduce this in FF as well. I'll see if there is a fix for it

Fixed in https://github.com/ernsheong/lite-signal/commit/bd887998e780eab4bc20b6a3923aa66e758bf274
Unfortunately this means we are generating a lot of new CustomEvent objects on each event. Optimization would be the next step.

Thanks !


Can use PSRAM?

esp32s3 have 8MB PSRAM, rust std Vec String can use PSRAM?

Can you use the Matrix esp-rs room for asking these questions?

@ivmarkov ok, i uknow Matrix at where, header page no see

I just pasted you the link to the Matrix room. Just login there.


Add description next to HB v2 icon

Feature Description
Currently  a small icon is displayed on the left side on the plugin widget, under the plugin icon. This is either an orange circle with a question mark or a green circle with a check mark.
Plugin is ready for Homebridge v2.0: unknown

Plugin is ready for Homebridge v2.0: yes

For anyone that has used Homebridge for a little while, this is a known identifier. However for a new user, there is nothing to describe what it means.
The suggestion is to add a small label along the lines of HB v2 ready:
Especially given that there is another checkmark (gray) to the right of it, next to the version number.

Update: I don't know how long this functionality has been available, but it fulfills the criteria for this enhancement ticket.
This is the green check mark that shows a plugin is ready for Homebridge 2.0:

This is the tooltip that displays when hovering over the green check mark:

This is the popup that displays when clicking on the green check mark:

Closing this ticket as implemented or current behavior satisfies feature criteria.


ANGULAR-CLI 1.0.0-beta.20-4

Prefix, sufix and other things don't work with CLI 1.0.0-beta.20-4...
any idea whay?
<paper-input label="Usuário"><iron-icon icon="user" prefix></iron-icon></paper-input>

thanks...

Probably related to #104
The angular dependency in the cli beta.20-4 Angular dependency is: "@angular/core": "^2.1.0",

works thanks

The same issue as #104. See that for more information.


npm package

Couldn't it be useful to have an npm package for this one? :)

HI,
Can i work on this one?? Ill try my BEST.

What would an npm package even do?


change project status to EOL

Part of #103

Chased with commit https://github.com/packethost/csi-packet/commit/b41446ca1695989a1c1d4952ca62771f2bb5f966
The link was typo'd.


Changed a type "attibutes" to "attributes"

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you @Abhishek233 for your contribution and congratulations on your first PR merge to this repo! 🎉


TypeError: _this.catalog.Pages(...).traverse is not a function

What were you trying to do?
I am trying to load a 90 page PDF into the lib
How did you attempt to do it?
Here is a simple reproduction of the issue
const { PDFDocument } = require("pdf-lib");
const fs = require("fs");

const fileWithError = fs.readFileSync("./policy-doc-test.pdf");

async function main() {
  const parentPDFDoc = await PDFDocument.load(fileWithError);

  console.log(parentPDFDoc.getPageCount());
}

main();

What actually happened?
I am getting the TypeError: _this.catalog.Pages(...).traverse is not a function error anytime I call any APIs that require traversing the pages. This includes getPageCount, save, etc.
What did you expect to happen?
I expected these functions to work as expected.
How can we reproduce the issue?
Run the above code snippet using node
Version
1.17.1
What environment are you running pdf-lib in?
Node
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
Above is the code snippet for reproducing the issue. The document is a somewhat sensitive PDF so i'd prefer to not attach it here publicly. I can attach the PDF via a DM or email.
Some more context:
This is a 90 page document (3.8MB). Opening it in Acrobat causes an error in acrobat. not sure if its related but I suspect it could be.
Here's the fun part... re-exporting this file and opening it with pdf-lib works as expected so Acrobat is doing something that fixes the issue, just not sure what and unfortunately re-exporting through acrobat isn't an option given the task.

Here to see if anyone knows what may be going on and how to potentially fix this issue. Thanks!

Facing the same issue. My PDF is around 60 to 70 pages

Same issue here, is there any time frame on when this will be looked into/fixed

We are experiencing the same issue, any news on this? glad to help any way I can

Same issue, any chance to fix this soon?

no fix

We are also experiencing this issue with a specific PDF.

In my case the PDFDocument.catalog property was initialised with a PDFDict instead of a PDFCatalog. So here is my workaround for the bug:
const doc = await PDFDocument.load(bytes.buffer, { ignoreEncryption: true });
if (!(doc.catalog instanceof PDFCatalog) && ((doc.catalog as any) instanceof PDFDict)) {
    (doc as any).catalog = PDFCatalog.fromMapWithContext(doc.catalog, doc.context);
}

For me it wasn't working due to Catalog pointing to the wrong object. I did this to manually point Catalog to a PDFPageTree
let pdfPageTree;

for (const entry of pdfDoc.context.indirectObjects.entries()) {
  const [ref, obj] = entry;
  if (obj instanceof pdfLib.PDFPageTree) {
    pdfPageTree = obj;
    break;
  }
}

doc.catalog = pdfLib.PDFCatalog.withContextAndPages(pdfDoc.context, pdfPageTree);

Same here. But I also need to register pageTree ref and after that everything started working perfect:
https://github.com/Hopding/pdf-lib/blob/93dd36e85aa659a3bca09867d2d8fac172501fbe/src/api/PDFDocument.ts#L162
if (!(doc.catalog instanceof PDFCatalog) && doc.catalog instanceof PDFPageTree) {
    for (const [_ref, obj] of doc.context.indirectObjects.entries()) {
        if (obj instanceof PDFPageTree) {
            const pageTree = PDFPageTree.withContext(doc.context);
            doc.catalog = PDFCatalog.withContextAndPages(doc.context, doc.context.register(pageTree));
            break;
        }
    }
}


What is the meaning of a process with zero inputs and outputs?

I was going to implement the "zero product flow" filter, when I can across an unusual process.
So, I went back to look at the 2016 electricity baseline (as downloaded from the Fed Commons) and I cross-checked what appeared to be a weird process with a lot of input and output exchanges, but all values are marked as zero (except the main product output).
The process I'm referring to is 'coal extraction and processing - Central Appalachia, BIT, Processing' (de122d83-123a-331e-85bc-bc14026410c6).
It appears to just produce 'coal, processed, at mine' from nothing (see screenshot below). Is this okay or does this need special attention for the library feature?

The way this is supposed to work is that the coal inventory function looks in the inventory csv for an exact match - CA-B-U (central appalachia, bituminous, underground mined coal). There is logic in there to fill in gaps as necessary (or there's supposed to be). CA-B-P would be a gap - we don't count processing facilities as "mine type". The intention in this case is to use a weighted average of CA-B-U and CA-B-S profiles, since a processing plant could be getting it's bituminous coal from underground or surface mines.

The filling in of missing scenarios starts here: https://github.com/USEPA/ElectricityLCI/blob/2232c41f2cb4fd333ad59c8710aa55906e6a7ed3/electricitylci/coal_upstream.py#L325

Since there are values in both CA-B-U and CA-B-S, I'm guessing this isn't working properly, then.

Addressed in the new coal upstream.


Only import GitPython if needed

see this issue:
https://github.com/gitpython-developers/GitPython/issues/1296

done


Single Asset Vault

High Level Overview of Change
This is implementation of XLS-65 Single Asset Vault. First draft was implemented by @thejohnfreeman in #5147

Context of Change

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Performance (increase or change in throughput and/or latency)
[x] Tests (you added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation update
[ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
[ ] Release

API Impact

[x] Public API: New feature (new methods and/or new fields)
[ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
[ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
[ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

There are a few warnings, of which the most common is:
xrpl/protocol/STIssue.h:49:5: warning: definition of implicit copy constructor for 'STIssue' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
   49 |     operator=(STIssue const& rhs) = default;

And once the compile error is fixed (remove constexpr in to_json_fn::operator() return value), there are VaultDelete unit-tests failures.

This is fixed now. The VaultDelete still needs to be fixed, but for the time being I've commented the failing test out. Compilation errors in clang 16 fixed, also simplified json_value.h a little.


Make requested changes

Made the changes requested in this post

@jordan-rogers-ge would you mind merging this so your PR in PowerShell/xDnsServer will get tested again?


<IP_ADDRESS> Ensure mounting of squashfs filesystems is disabled

Profile Applicability:
 Level 2 - Server
 Level 2 - Workstation
Description:
The squashfs filesystem type is a compressed read-only Linux filesystem embedded in
small footprint systems. A squashfs image can be used without having to first
decompress the image.
Rationale:
Removing support for unneeded filesystem types reduces the local attack surface of the
system. If this filesystem type is not needed, disable it.
Impact:
As Snap packages utilizes squashfs as a compressed filesystem, disabling squashfs
will cause Snap packages to fail.
Snap application packages of software are self-contained and work across a range of
Linux distributions. This is unlike traditional Linux package management approaches,
like APT or RPM, which require specifically adapted packages per Linux distribution on
an application update and delay therefore application deployment from developers to
their software's end-user. Snaps themselves have no dependency on any external store
("App store"), can be obtained from any source and can be therefore used for upstream
software deployment.
Audit:
Run the following script to verify squashfs is disabled:
#!/usr/bin/env bash
{
l_output="" l_output2=""
l_mname="squashfs" # set module name
# Check how module will be loaded
l_loadable="$(modprobe -n -v "$l_mname")"
if grep -Pq -- '^\h*install \/bin\/(true|false)' <<< "$l_loadable"; then
l_output="$l_output\n - module: \"$l_mname\" is not loadable:
\"$l_loadable\""
else
l_output2="$l_output2\n - module: \"$l_mname\" is loadable:
\"$l_loadable\""
fi
# Check is the module currently loaded
if ! lsmod | grep "$l_mname" > /dev/null 2>&1; then
l_output="$l_output\n - module: \"$l_mname\" is not loaded"
else
l_output2="$l_output2\n - module: \"$l_mname\" is loaded"
fi
# Check if the module is deny listed
if grep -Pq -- "^\h*blacklist\h+$l_mname\b" /etc/modprobe.d/*; then
l_output="$l_output\n - module: \"$l_mname\" is deny listed in:
\"$(grep -Pl -- "^\h*blacklist\h+$l_mname\b" /etc/modprobe.d/*)\""
else
l_output2="$l_output2\n - module: \"$l_mname\" is not deny listed"
fi
# Report results. If no failures output in l_output2, we pass
if [ -z "$l_output2" ]; then
echo -e "\n- Audit Result:\n ** PASS **\n$l_output\n"
else
echo -e "\n- Audit Result:\n ** FAIL **\n - Reason(s) for audit
failure:\n$l_output2\n"
[ -n "$l_output" ] && echo -e "\n- Correctly set:\n$l_output\n"
fi
}

This audit must be done on the actual machine, virtualization or tools like Docker will fail. This is because modprobe and lsmod may not be loaded. You can't load kernel modules in a Docker container. You need to load them on the host. See https://github.com/sandevistan-server-hardening/CIS_Ubuntu_22.04_LTS_Benchmark_v1.0.0/issues/1


How to set background image in training ?

I have two classes ( classA:1, classB:2) in my custom images. Now there are some other images without any bboxes, should I use these images as background images?
And How to do the settings (For example, how to define the class index ? should it be 0 ? )
Thank you.

In coco format,  json files have the following dictionaries dict_keys(['images', 'type', 'annotations', 'categories']) . For background images without any target objects in them,  you can define the image properties  in images dictionary and leave the annotations part empty for that image id. You don't need to set a new class id for background images.

Will YOLOX use these images withou any bboxes in training for some operations?

@le02146 In my application I added background images to my training data as well to help model discriminate background images from target objects. In my case there was only one target object.


API fetch calls

Hi,
When using Universal Router with React Starter Kit, any API requests using either fetch or Axios (for example in routes/home/index.js) will call the API endpoint twice.
Any idea why?
Update March 25:
The double call only happens when server-side rendering is called. Accessing the route client-side triggers a single API request.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This issue does not relate to the router, please take a look at:

https://github.com/kriasoft/react-starter-kit/issues/813 - How to avoid the duplicate request for SSR
https://github.com/kriasoft/react-starter-kit/issues/983 - Home fetch run twice


Fix apphosting/common in build/publish

Seeing failures since the changes to @apphosting/common. It turns out that in lerna, for the dependency graph to pick up dependents / dependencies the version in the package.json dependencies needs to be in the form of *

Change monorepo deps to *, that's the easy part
Now we don't want to allow any version of @apphosting/common, so let's pin before publishing, this is the hard part

Do two passes on the filteredLernaList, so we can pin any dependencies
Don't publish dependencies, only dependents (as canaries) when tagged
Topo sort the lerna list, so packages are published in the correct order

Lerna publish would do this all for us, if we were using that.

https://kotlinlang.org/docs/releases.html#ide-support


Ability to retrieve paginated analysis results

Description
Include a summary of this pull request
New dependencies: (Added to requirements_*.txt)
Fixes # (potential issues that are fixed by this PR)
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue -> bump patch)
[ ] New feature (non-breaking change which adds functionality -> bump minor version)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected -> bump major version)
[ ] Documentation Update
[ ] CI/CD workflows Update

Checklist

[ ] I have added tests that prove that my fix/feature works
[ ] Linters pass locally and I have followed PEP8 code style
[ ] New and existing tests pass locally
[ ] I have updated the documentation if needed
[ ] I have commented hard-to-understand areas in the code

Requirements

[ ] I have updated the MVG version

The tests use the production image to run the tests. Since we have not yet released the https://github.com/vikinganalytics/vibium-cloud/pull/695 to the production, the tests here will fail. However, the mvg-integration tests in the vibium-cloud passes which also tests the new tests added in this PR in MVG. You can have a look at the latest run https://github.com/vikinganalytics/vibium-cloud/actions/runs/4073812359 to validate.


Update dependencies

This is a manually maintained project without a dependency bot creating issues for us.
Therefore we must update the dependencies before releasing the next version.

The first update is already done by 4a79c726f9ebd1e353b273d41fc4127c012e0ac6. We should check again before releasing.

@dj-fiorex please review this and release the package as we don't want to create another fork for our project.

Done!

@hexdecimal16 @uap-universe please write your npm username so I cannot add you on npm registry also! So you can publish. I don't want to be the bottleneck of this project!

@dj-fiorex here is my username dhairy and email as well<EMAIL_ADDRESS>

@dj-fiorex It is uap-universe an email is<EMAIL_ADDRESS>


Doesn't handle Slic3r gcode

Two initial problems with trying to process gcode output from Slic3r:

The G21 code is rejected (can be ignored)
Doesn't complete preprocessing (due to no Cura profile?) and the Print button is not enabled.

Looking ahead:
No ;LAYER:n tags in the GCODE. This can be fixed with changes in Slic3r settings.
The Slic3r profile is not recognized.
I will look into these if you want to assign it to me ...

Compatibility with Slic3r would be good. We should have a mechanism for ignoring some codes, like G21, in TFPPrinter, at the dequeueCode level or something. If Slic3r has an embedded profile like Cura, it would be good to be able to read it, yeah.


Cluster Tools button missing inside cluster navigation

Description
The Cluster Tools button in the sidebar is missing when navigating within the local cluster.
Left 2.10, right 2.9.

Cluster Tools has moved into the Cluster side nav group as Tools. Not quite sure when, i thought it was 2.9.0 though

Cluster Tools has moved into the Cluster side nav group as Tools. Not quite sure when, i thought it was 2.9.0 though

Looks like I was still using 2.8 and I've also forgot we have a script to update with Docker 🙃
Thanks for the hint.


Bring Go current in CircleCI

https://github.com/lrills/helm-unittest/pull/84

@lrills please review


Multiple sessions per user not working

Hi! I have encountered a problem with RDP. I have tried everything, reinstall, Windows 10 Home, PRO newest version and PRO version supported from February. When I try to use RDP I can only have 1 session. I have changed amount of sessions in gpedit.msc and "Only one session per user" and had no success with it.

Question is does anyone know how to get to work the multiple RDP sessions per user/machine?
Thanks!

Can you upgrade your PC to 1903 win10 >?
I recommanded this

please use updater from https://github.com/stascorp/rdpwrap/pull/859

@min9139 I will try and let you know, @s0nic9 yes i have updater and it has changed nothing

is "17763.292" present in your rdpwrap.ini in "program files\rdp wrapper" ?
if not, there something wrong when you use https://github.com/stascorp/rdpwrap/pull/859

I am having the same issue with Version 1903 (OS Build 18362.356)


"Infinite canvas": controlling child via parent container element

I have a similar question to one that was previously answered, but not sure how to achieve it with the new Panzoom (post-jQuery) which I'm very interested in using. It was previously answered here for the jQuery version: https://github.com/timmywil/panzoom/issues/39
How can I make both the container and the child element have the Panzoom attributes—zoomable, pannable, etc. using the new API in Panzoom? I'd like panning/zooming on the parent element to move the child.
Example (Figma):

I played around with this a bit in my demos. The old $set option wouldn't really be appropriate for the rewrite. I thought about using the setTransform option, but thought better of it because I think we can make something cleaner.
I was able to achieve this behavior by changing two lines in panzoom.ts, basically binding the down handler to the parent instead of the element. Everything else works with no further changes. So, I've added an option to the master branch called canvas. Please try it out before I release it to make sure this is accomplishing what you want.
Panzoom(elem, { canvas: true })

Oh, you can try it out with the following...
$ git clone git@github.com:timmywil/panzoom.git
$ cd panzoom
$ npm install
$ npm run build

panzoom.js will be in the dist/ folder.

Yep, works exactly as imagined! Thanks @timmywil!
Demo (using the Panzoom from dist/) + Vue:
https://codesandbox.io/s/musing-tesla-pxwqe
See src/components/PanzoomContainer.vue for usage.

Thanks for checking. Release in 4.1.0


First attempt at fixing exec_time display bug

Hello,
This is my first attempt at fixing the exec_time display bug here: https://github.com/frmendes/geometry/issues/72

I think it's a good time to take a closer look at how this plugin works. I think it's quite convoluted as of now for such a simple task as to display how long a command took.
What I see as the main problem is that we're not cleaning up prompt_geometry_command_exec_time after it's rendered. Same happens with prompt_geometry_command_timestamp, both should be cleared out. Ex:
prompt_geometry_check_command_exec_time() {
  integer elapsed
  # default value for exec_time is an empty string (ie, it won't be rendered), if we don't clear this up
  # it may be rendered each time
  prompt_geometry_command_exec_time=
  (( elapsed = EPOCHSECONDS - ${prompt_geometry_command_timestamp:-$EPOCHSECONDS} ))
  if (( elapsed > $PROMPT_GEOMETRY_COMMAND_MAX_EXEC_TIME )); then
    prompt_geometry_command_exec_time="$(prompt_geometry_seconds_to_human_time $elapsed)"
  fi
  # Clear timestamp after we're done calculating exec_time
  prompt_geometry_command_timestamp=
}

Another thing is that we're hooking precmd for prompt_geometry_set_command_timestamp but we should rather use preexec. Check out the docs (ctrl+f, precmd). I'd use the following setup:
# sets the timestamp before running a command
add-zsh-hook preexec prompt_geometry_set_command_timestamp

# before rendering the prompt do run the checks
add-zsh-hook precmd prompt_geometry_check_command_exec_time

It think this way we'll simplify a bit how this plugin work. What do you think? @ChauTNguyen

@desyncr
Ahh, I see.  Thank you. Yeah, preexec makes a lot of sense now that I've learned a bit about it.
Clearing the values after they're used makes a lot of sense to me as well, but I couldn't fix the original bug.

Check out this implementation: https://gist.github.com/desyncr/4573fa6aea5308aa7813e91ad30e9c7c
From here it seems to work.

@ChauTNguyen Do you need any help? Did my suggestion worked at all? Let me know :)

Hello, @desyncr.
I have tried the code, but I encountered a problem. The elapsed time is always 0 because the program sets the timestamp and then subsequently subtracts it from $EPOCHSECONDS (the program doesn't store the previous timestamp).
I've been trying various ways tonight to try to keep the old timestamp into the program and to kill the bug, but I can't quite get it correct.

As I understand the flow should go as follows:
Case 1: Command

User submits a command (ex, sleep 7<enter>)
preexec hook is handled by prompt_geometry_set_command_timestamp
prompt_geometry_command_timestamp is set to EPOCHSECONDS
The command ran and exists after ~7s

Then:

precmd hook is handled by prompt_geometry_check_command_exec_time
We clear up previous values in prompt_geometry_command_exec_time
We compute the execution time
We set up prompt_geometry_command_exec_time if necessary
Prompt is rendered again (geometry_prompt_exec_time_render)

Case 2: Empty line

User submits an empty line (ex, <enter>)
No preexec hook is triggered as there is no command to run
prompt_geometry_command_timestamp should be undefined as per line 21

Then:

precmd hook is handled by prompt_geometry_check_command_exec_time
We clear up previous values in prompt_geometry_command_exec_time
We compute the execution time (which should end up being EPOCHSECONDS - EPOCHSECONDS) as per this line
We set up prompt_geometry_command_exec_time if necessary (not in this case)
Prompt is rendered again (geometry_prompt_exec_time_render)

So, if the case is 2, then this behaviour is correct. There is a room for improvement here as we may explicitly check for undefined/falsy value to make the logic more obvious.
I'm probably missing a test case as from here it seems to work as expected.
What test case are you testing it against?

I'm so sorry... I've been misunderstanding the plugin's usage this whole time (I was working really late at night most of the times, didn't read properly I think...). I forgot that it cares about execution times (hence exec_time); I somehow started to think that the plugin wanted to record the elapsed time since a previous command has finished.... Yeah, your changes work perfectly then.

@ChauTNguyen No problem. This happens to me as well as I tend to work on side projects quite late at home.
Well, then there is only matter on copying and pasting this implementation into this branch.
I'm gonna go ahead and do it. @frmendes Can you review these changes?

@ChauTNguyen Oops. I think since it's a branch on your fork you'll have to merge these changes and pushing them. Otherwise I'll have to close this PR and open up another one. No big deal thou :P

@desyncr Haha, I kinda feel guilty since I've been relying on your work for the past PR's so I'll pass on this one!

@ChauTNguyen No problem! I'm gonna close this up.
Thanks for the time invested in this! Really appreciate it!


Serialization to and from vector<int8_t> and vector<uint8_t>

Hopefully this time it's done properly.

@davisking Hopefully this is better. I'm not overwhelmed by the fact that vectorstream has three dummy vectors and 3 streambuf's, one for char, int8_t and uint8_t. I though about using dlib::type_safe_union but i think this is fine and there isn't a huge overhead i don't think.  I've kept the tests for dnn and matrix as they are good sanity checks.

Na, that's a good way to do it.  I'll look it over more carefully later, but looks good from an initial quick review.

Not a huge fan that the iostream base class gets constructed with a pointer to a streambuf object that hasn't been constructed yet. Not great, but vectorstream was doing that before anyway.

@davisking any thoughts?

Ok it turns out you can pass a null pointer to iostream constructor so you can delay setting the streambuf pointer. That's good. Now we can use unique pointers and not need dummy buffers. I think this is better.
I don't like the fact that this implementation has the overhead of a heap allocation but maybe that's asking too much. I did think of using dlib::type_safe_union to contain all three types of streambuf objects but you can't use it because of cyclic header dependencies. So then i thought of using stack_based_memory_block and using placement new but things were getting a little complicated and cluttered and, in the end, I favored code readability over saving 1 heap allocation. At the end of the day, we're not doing embedded.

If someone complains of the extra heap allocation in the future, we can always tell them to get a life, or we can use stack_based_memory_block and make the code look ugly.

Yeah it's probably better to use an explicit call to rdbuf().   I just looked and can't find a guarantee that it's ok to do what was here before.  So that's an improvement.  But I'm fairly sure there are people who will legitimately care about the extra new here now though.  Why not have the dummy variables and just use rdbuf() to set the appropriate stream?  Then there is no new.

Can do. But then there are 3 vectors and 3 streambufs. There might not be any new calls but there is some object overhead.

@davisking, if we are going to care about object overhead and heap allocations, the latest commit hopefully deals with both of those concerns. Let me know what you think.

Hopefully it's not "double plus ungood"

Ha, ok, that's clever but way too complicated.  The sizeof(vectorstream) with some dummy vectors is going to be tiny enough to be insignificant and there is no construction overhead or dynamic allocation inside std::vector's default construtor.  So just having 3 dummy std::vectors is essentially free and a lot simpler.

@davisking Yeah i thought you might say that. It's just this way we have minimal object and heap allocation overhead. It comes at the cost of some ugly code. I will revert it back to what we had before.

@davisking Ready for review whenever you have time.

@davisking Just FYI, sizeof(vectorstream) is now 600 bytes whereas before, using std::aligned_union<storage_capacity,T0,T1,T2>::type mem; and placement new, sizeof(vectorstream) was 376 bytes. So there is quite an overhead there. So if people care about the size of their stack, then the latest version might be an issue. 600 bytes for vectorstream, which is a glorified wrapper around std::vector seems excessive.

Yeah it all adds up. sizeof(std::iostream) == 288, sizeof(std::vector<char>) == 24, sizeof(vector_streambuf) == 80. So if we use 3 dummy vectors and 3 vector_streambufs, you end up with sizeof(vectorstream) == 600. If we use placement new with std::aligned_union you end up with sizeof(vectorstream) == 376
So it's a matter of whether you want to sacrifice stack size for code readability. At the end of the day, I don't mind too much. L1 cache is pretty big these days. But if people care about unnecessary heap allocations, they might care about this too.
But this has been a good experiment. And it shows that harmless objects like std::vector are actually quite big, probably because they have the "small vector" optimization with some small stack capacity. And iostream objects are enormous. No wonder why some companies don't like them.

@davisking on another note, do you think there is user code out there that has something like:
static_assert(sizeof(vectorstream) == 376), "poop"); ? The latest version would break that. Whereas the one i suggested with placement new doesn't break that. I know that's an extreme example, but just another thought. Again, I don't mind which you choose, these are just things to consider.

  So I'm not worried about it.
I would be really surprised if there is any code anywhere that does static_assert(sizeof(vectorstream) == 376), "poop").  That would be a really bizarre and non-portable thing to have in your code.

Anyway, this is good.  Thanks for another PR :)

@davisking I've just realised I didn't update vectorstream_abstract.h. I think it was out of date anyway from a previous PR that fixed casting issues to iostream&


adjust the deprecation policy for python

As discussed in #7765, this extends the policy months by 6 to a total of 30 months. With that, the support for a python version can be removed as soon as the next version is at least 30 months old. Together with the 12 month release cycle python has, we get the 42 month release window from NEP 29.
Note that this is still missing the release overview proposed in #7765, I'm still thinking about how to best implement the automatic update / formatting, and how to coordinate it with the (still manual) version overrides.

[x] towards #7765, closes #7777
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

the first part of the policy change described in #7765 should be ready for review and merging. Still pondering how to implement the second part, so that will be a separate PR.

Thanks @keewis!


laravel/framework: ^9.0 requirement for 2.0, was it really necessary ?

Not of all us have the luxury of upgrading to new Framework as we need to wait for many many dependencies to catch up. Since Laravel Nova 4.0 explicitly supports both Laravel 8 and 9, was it really necessary to slap on this 9.0 requirement on your 2.0 ?
I'm going to try forking it now... if this was just an after thought, please consider changing the requirement to ^8.0|^9.0
Many thanks

Just a quick follow-up, I forked your 2.0 release and made this one tiny modification to the composer.json "laravel/framework": "^8.0|^9.0", and everything seems to work just fine.
Please consider making this modification.. in the spirit of Nova 4 itself supporting Laravel 8.0 as well as 9.0. I'd have to have to maintain and update a fork just for this tiny modification.
Thank you

The decision was mostly done to match with the laravel's php requirements, since 2.0 supports php8.0 and higher.

Removed the requirement in 2.0.1

@KasparRosin thank you!!


MIT License?

I assume that this code is released under the same license as Chart.js (MIT License, https://opensource.org/licenses/MIT), but I cannot find this spelt out anywhere.
Could you please make the copyright and license explicit?

Sure will add that when I get home.


[Feat] api-types

Summary

TRN-317
Create @therootnetwork/api-types

Checklist

[x] Add description
[x] Tag related issue(s)

I have been unable to prove it works via pnpm link, but it definitely works within @therootnetwork/api


Allow Blake2 and twoxx hashing in no_std

In order to use substrate-primitives::blake2_256 in no_std environment, I suggest this PR
Currently, it fails because dependency twox_hash doesn't support no_std (actually, the dependency wouldn't be necessary to use blake2)
https://github.com/shepmaster/twox-hash/issues/19

you can already use both of them through the sr-io module as they're provided as extern APIs.

I should've stated my use case more clearly, sorry:
I'm aware that hashing isn't done in wasm for the runtime, but instead its an extern host call.
But if I'd like to compose an extrinsic in an SGX enclave, I'd need blake2 really running within the enclave. No host call there.

Ok, but I don't want this code part of the normal build. Can you isolate in one of your own modules? If not, then I'd want it to be a feature which is off by default.

upstream twox_hash apparently fixed no-std issues: https://github.com/shepmaster/twox-hash/pull/20.
@gavofyork Just to understand: Why don't you want this beeing part of master? Because you want to make sure people are not using hashing within wasm runtimes, but rather use the sr-io API?
Of course we can do the hashing ourselves, without this PR. I just though it's easier to maintain our code if we depend on substrate codebase whereever we can.

Yeah - though Rust linker is pretty decent at removing unused code, I don't want there to be any possibility of people accidentally using the Wasm version and generating bloated runtimes (and storing them on-chain) because of it.

got it.
I guess this PR is not worth its own feature switch. We'll just copy-paste the needed code to our own repo

@brenzi if you compile substrate-io for no_std, you could use sr_io::ext_blake2_256.replace_implementation(your_implementation). By doing this, you can implement blake2_256 in your runtime directly without requiring an host implementation.


broadlink support new devices, add send_by_id

recently i bougt two broadlink devices ,the rm_mini_3 and sp3mini. so i did some modified on broadlink.py and those code works well on my local Raspi server
Description:

add devices support for rm_mini_3 and sp3mini
regist service with friendly_name if exist
save packet in known_packets.yaml when call SERVICE_LEARN with packet_id
regist a NEW service SERVICE_SEND_BY_ID for quickly send packet
fix is_on(self) never call update(self) even reboot

Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#4505
Example entry for configuration.yaml (if applicable):
switch:
  - platform: broadlink
    friendly_name: 'IRcontroler'
    host: <IP_ADDRESS>
    mac: '34:ea:34:00:00:00'

Checklist:

[x] The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

I agree with @Danielhiversen, we should not store the packets to disk. As that is what this PR adds, I suggest we close it.


Fix arrow_regular cast sound

Oh weird, I guess I always thought the vanilla sound still played even though I cancel the arrow launch, but I guess not?


Hitting Return in a text field deletes record.

When editing a record, pressing Return in any of the text fields deletes the record. If anything, it should save the changes.

I think you opened in the wrong issue tracker.


Get Ready for UI5-Development on Your Local Machine

Tutorial URL: https://developers.sap.com/tutorials/cp-cf-sapui5-local-setup.html
Please specify the step you are referring to
Step 4: Install the MTA build tool
I am unable to install mbt
C:\Users\napotnikd>npm install -g mbt
npm WARN deprecated<EMAIL_ADDRESS>request-promise has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
C:\Users\napotnikd\AppData\Roaming\npm\mbt -> C:\Users\napotnikd\AppData\Roaming\npm\node_modules\mbt\bin\mbt

<EMAIL_ADDRESS>install C:\Users\napotnikd\AppData\Roaming\npm\node_modules\mbt
binwrap-install

ERR Error communicating with URL https://github.com/SAP/cloud-mta-build-tool/releases/download/v1.0.16/cloud-mta-build-tool_1.0.16_Windows_amd64.tar.gz Error: connect ETIMEDOUT <IP_ADDRESS>:443
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: binwrap-install
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
Thanks for any help

Hi,
it's weird that you get a timeout error here. Did you try this multiple times? Maybe it was just a temporary issue of GitHub (I just tested it and it works for me).
As a plan b, I would suggest trying to install an older version with npm install -g<EMAIL_ADDRESS>

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Sublist Search in CPP

Have you read the Contributing Guidelines on Pull Requests?
Yes
(Write your answer here.)
Description
Adding sublist search algorithm in cpp.
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#2506
(Write your answer here.)

@HarshCasper Please review this PR.


readline keep throwing TypeError exception

fix(TypeError): when fifo is empty, readline keep throwing TypeError exception.  and the latest ruby-fifo:0.1.0 seems fine.
2017-01-27 11:15:07 -0800 [error]: in_named_pipe: unexpected error error_class=TypeError error="no implicit conversion of nil into String"
  2017-01-27 11:15:07 -0800 [error]: /opt/td-agent/embedded/lib/ruby/gems/2.1.0/gems/ruby-fifo-0.0.1/lib/fifo.rb:68:in `readline'
  2017-01-27 11:15:07 -0800 [error]: /opt/td-agent/embedded/lib/ruby/gems/2.1.0/gems/fluent-plugin-named_pipe-0.1.2/lib/fluent/plugin/in_named_pipe.rb:49:in `run'

ruby-fifo 0.1.0 seems to be broken https://github.com/shurizzle/ruby-fifo/issues/8


Updated hive commit to latest mce-2.7

Description
Updated hive commit to the latest mce-2.7 commit: cddd4f9551eaa6c69b2f375a98e024db5783b71c.
Related Issue
If applicable, please reference the issue(s) that this pull request addresses.
Changes Made
Updated hive mce-2.7 commit from: d83161fa7af040b0c1e1a876f2ee591c2ee2e857 to: cddd4f9551eaa6c69b2f375a98e024db5783b71c
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[ ] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[ ] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
/cc @cameronmwall @ngraham20
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

Adding a hold until the Hypbld squad picks up the latest commit.
/hold


Problems creating a classroom template

Description
Wondering if I can get some advice. I have the RequestATeamApp working but having problems setting up a template for a classroom. Is it possible?
I have another logicapp setup to bulk create classroom teams and noticed it is still using beta rather than v1.0 in the "ProcessTeamRequest" logicapp, tried changing that out but its still the same.
I got "educationClass" templateID from:
https://docs.microsoft.com/en-us/microsoftteams/get-started-with-teams-templates
Steps to reproduce

Create a new line in "Teams Templates" list on SPO
Set the "Template ID" to "educationClass"
Select Classroom template from the dropdown within the Request-A-Team-App

Expected results
Team created using educationClass template so it has a "Class Notebook, Assignments tab etc"
Actual Results
Get the following error when setting the templateID to educationClass:
"message": "Failed to execute Templates backend request CreateTeamFromGroupWithTemplateRequest. Request Url: https://teams.microsoft.com/fabric/emea/templates/api/groups/dfbe2ef1-4562-418c-ac32-8dc510d0bb14/team, Request Method: PUT, Response Status Code: BadRequest, Response Headers: Strict-Transport-Security: max-age=2592000\r\nx-operationid: 339bb1a2eabca746aca1e307857584b4\r\nx-telemetryid: 00-339bb1a2eabca746aca1e307857584b4-fb513ffbee37a24e-00\r\nX-MSEdge-Ref: Ref A: 545C8753D277404F84652518AEAC150D Ref B: DB3EDGE1906 Ref C: 2022-03-25T10:12:31Z\r\nDate: Fri, 25 Mar 2022 10:12:31 GMT\r\n,
ErrorMessage : {\"errors\":[{\"message\":\"Team with template 'educationClass' can not be provisioned using a group which does not belong to a class.\",\"errorCode\":\"Unknown\"}],\"operationId\":\"339bb1a2eabca746aca1e307857584b4\"}",

when setting the templateID to "com.microsoft.teams.template.educationClass" (just thought I would try that incase it worked)
message": "Failed to execute Templates backend request CreateTeamFromGroupWithTemplateRequest. Request Url: https://teams.microsoft.com/fabric/emea/templates/api/groups/fc50b359-e04d-4884-a1fe-c7dae30c4190/team, Request Method: PUT, Response Status Code: BadRequest, Response Headers: Strict-Transport-Security: max-age=2592000\r\nx-operationid: 46bf3bbdcf37ad4f965a8bc3c10cb1b5\r\nx-telemetryid: 00-46bf3bbdcf37ad4f965a8bc3c10cb1b5-73d29867ced5834d-00\r\nX-MSEdge-Ref: Ref A: 73A35EC44CF048D9AE6881D0DC4034CA Ref B: DB3EDGE2022 Ref C: 2022-03-25T10:19:50Z\r\nDate: Fri, 25 Mar 2022 10:19:50 GMT\r\n,
ErrorMessage : {\"errors\":[{\"message\":\"A template with id 'com.microsoft.teams.template.educationClass' and locale 'en-US' could not be found.\",\"errorCode\":\"Unknown\"}],\"operationId\":\"46bf3bbdcf37ad4f965a8bc3c10cb1b5\"}",

Solution component
Logic Apps
Operating system (environment)
Windows
Additional Info
No response

I should probably add that I went through the wiki and tried to create the classroom team via an existing template;
Teams admin panel > use existing team as template
It does create the team successfully but the classroom notebook, assignments etc are all missing.
I noticed a few MS kb articles mention:
"Custom templates are not yet supported for EDU customers."
I'm an EDU customer that probably explains why the template isnt working for me.
I bulk create Classrooms using a logicapp so it does work but I would love to get the "Request-A-Team-App" working. Anybody else manage to get classroom teams working via the app?

@fracmo2000 It does indeed seem like some kind of limitation with the Graph API and EDU specific templates. How are you bulk creating classrooms/what endpoint do you use for this?

We are experiencing same issue where we created new templates via copying the EDU templates and imported them to the app but it ended up missing Classroom Notebook and Assignment apps for Class Teams type. However surprisingly Grades app does show up in the template. Any foreseeable resolution to this? or a work around?

@alexc-MSFT It does indeed seem like some kind of limitation with the Graph API and EDU specific templates. How are you bulk creating classrooms/what endpoint do you use for this?

Hi Alex, sorry for the late reply!
I bulk create the teams using a flow which uses graph beta instead of v1, I noticed that you included the graph beta url in your flow which I did try by changing all the locations (I think I got them all)

Create Group > uri
Clone Team
body > change v1.0 to beta
Get Create Team Operation > uri

  	Authority > https://login.microsoft.com (blank previously)

Get Created Team > uriI

  authority > https://login.microsoft.com (blank previously)

However it still fails with the same error "Team with template 'educationClass' can not be provisioned using a group which does not belong to a class"
Here is the flow I use to bulk create classrooms, perhaps you can spot the difference?


js8 sandbox binary form

need docker for

start from ubuntu 1604
then launch other docker where we have the packaging done
rsync the files from the js8 packaging to /opt/... on the current one

result

a docker which is minimal in size but has all binaries / libs required in /opt...
this allows someone to use this smaller one without being in development mode and without using js8 fuse system (e.g. for disconnected usage)

started doing the work based on alpine linux,

is done


Replace n-dash in HISTORY to workaround pip bug

There exists a problem (maybe a bug?) in pip when using a locale like LC_ALL=C (which is commonly used by CI environments and system configuration tools such as Puppet), where the PKG-INFO file is decoded using ascii, raising a UnicodeDecodeError when PKG-INFO contains non-ASCII characters (such as the n-dash removed by this commit):
Downloading/unpacking requests from https://pypi.python.org/packages/source/r/requests/requests-2.5.1.tar.gz
  Downloading requests-2.5.1.tar.gz (443Kb): 443Kb downloaded
  Running setup.py egg_info for package requests

Exception:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pip/basecommand.py", line 104, in main
    status = self.run(options, args)
  File "/usr/lib/python3/dist-packages/pip/commands/install.py", line 245, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/usr/lib/python3/dist-packages/pip/req.py", line 1014, in prepare_files
    req_to_install.assert_source_matches_version()
  File "/usr/lib/python3/dist-packages/pip/req.py", line 359, in assert_source_matches_version
    version = self.installed_version
  File "/usr/lib/python3/dist-packages/pip/req.py", line 351, in installed_version
    return self.pkg_info()['version']
  File "/usr/lib/python3/dist-packages/pip/req.py", line 318, in pkg_info
    data = self.egg_info_data('PKG-INFO')
  File "/usr/lib/python3/dist-packages/pip/req.py", line 261, in egg_info_data
    data = fp.read()
  File "/usr/lib/python3.2/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 8161: ordinal not in range(128)

There are some existing issues for pip:

pypa/pip#1233
pypa/pip#761

Other projects have had the same issue occur; there is some useful discussion in these issues as well:

cleder/fastkml#9
gabrielfalcao/HTTPretty#108
rbarrois/factory_boy#118

I know this isn't really a problem with requests (and should probably be addressed ultimately in pip), but I think replacing this character in HISTORY would be a pain-free and pragmatic way to help developers and system administrators, especially given the inactivity on the pip bug reports.
Many thanks!

Yeah, I'm just sick of this now. Thanks! :cake:

This is the second time these have snuck in. Where are they coming from? Do we think this closes #2419?

I hope so.


VCalendar: Fix timezones stripping

Fix https://github.com/fruux/sabre-vobject/issues/278.
The issue is that the stripTimezones closure is recursive but the
“self” is not defined. This way it works.
Minimal Working Example:
$a = function ($i) use (&$a) {
    var_dump($i);

    if ($i < 10) {
        $a($i + 1);
    }
};

Here we can re-use “self” ($a) inside the closure because it is closed
into the same lexical scope thanks to use (&$a).

I guess we should have a unit test for this path

:+1: for the PR and :+1: for a unit test, that would have catched this. ;-)


Component metadata rule execution should be cached if it has a noticeable performance impact

As explored in #3157, the impact should not be high. Once we have extended rule with more features, we should measure the impact on large, realistic builds (one candidate can be the gradle/gradle build).
If the impact is high enough we can experiment with a simple caching mechanism. We should check how it fits with the metadata caching we already perform.

Technically speaking you cannot be sure if the rule is going to be expensive before executing it. A purely local rule is likely to be fast. But if it tries to contact a remote server to get information about say, vulnerabilities of a specific dependency then it's a different story.

@melix You are right of course.


ESP32-C3 ERROR

RFControl.cpp:4:10: fatal error: soc/dport_reg.h: No such file or directory

Sorry, HomeSpan is not presently configured for the S2 or C3 versions of the ESP32.  Once Espressif publishes their initial stable release of the Arduino-ESP32 2.0 library (with support for the S2 and C3 chips), HomeSpan will be updated to run on those chips (to the extent possible).

This bug has been fixed in release 1.4.1.

I might have something related to this bug - specifying a pin that doesn't exist, on a -C3 causes a WDT reboot loop.  How I got to that stage was compiling the simple LED example on an ESP32-WROOM  board, then chaining to the -C3 board and recompiling but left the LED pin defined as 17. Changing the pin to something present on the C3 like 5 allows it too run fine.
But, changing it to say 99 on the -WROOM board also ran fine.
This is not necessarily a HomeSpan issue of course, but I thought you might like to know or it might reveal some other variant weirdness, or if nothing else someone googling for similar may find this :-)

Oh - Important note - I have only done extremely limited testing, but this WDT reset only happens with HomeSpan, not with for example the basic blink sketch - on a serial terminal with pin 99 specified in the "blink" sketch,  this gives a GPIO error every time the LED is blinked.


influx_history grows to gigabytes

I'm using an awk script to generate queries that feed into influx to back-fill continuous queries, something like:
./migrate.awk | influx
The result is that my $HOME/.influx_history grew to 40 GB, filling my filesystem to 100%.
I would have expected influx to only save the last e.g. 1000 lines at the end, not saving every single line.
Version: <IP_ADDRESS>+dfsg1-4 (Debian unstable package)

Yes, it looks like the current implementation is naive, simply appending on every parse:
https://github.com/influxdata/influxdb/blob/0.10.0/cmd/influx/cli/cli.go#L191
Changing this to a feature request to add a limit to the number of appends.

I've got a PR here that shows a proposed solution: https://github.com/influxdata/influxdb/pull/5460
Please ignore the notice about commit 7b2505d above, it's from an old fork that I deleted. 40e04d8 is correct and on the PR.

Influx is using the Liner library for the ReadHistory / AppendHistory / WriteHistory functions.
PROBLEM:
When the influx console is started, ReadHistory reads the entire buffer from ~/.influx_history into memory, for up to 1000 lines.
Each time a command is entered into the console, AppendHistory is called. This appends to the history buffer we have in memory which has a limit of 1000 entries as well. This call by itself is fine.
Now things start to get hairy. (WriteHistory)[https://github.com/influxdata/influxdb/blob/0.10.0/cmd/influx/cli/cli.go#L192] is called. Not only does this function ignore the HistoryLimit, but it appends the history buffer in memory to the file. Additionally, when exit() is issued, WriteHistory writes that entire buffer to ~/.influx_history again. You can see how this will cause the file to quickly grow exponentially...
FIX: On the liner library example page, it looks like they open the historyFile with os.Open (read-only), and then attempt to re-create the file each time using os.Create() before WriteHistory is called. This prevents the growth problem by using WriteHistory as intended. I also modified the file open functions for Read/Write History and closed the files immediately after finished with them. I didn't see a need to use defer since the handles to the files are not re-used elsewhere.
PROPOSED SOLUTION: I've created a function called saveHistory that calls WriteHistory after clearing the ~/.influx_history file. I added historyFilePath to the CommandLine struct to make this easier. I replaced the calls to WriteHistory with my saveHistory function.

Fixed by #5460. Thanks, @sczk!


Discontinued?

Hello everyone. Just a quick check: is this project discontinued? I see that last commits were quite a while ago...

Hi @ivanmoskalev!
Buckaroo has been dormant for a while, but it has not been discontinued. We are currently working on the next version behind the scenes, building on the lessons from 1.x.
Our current focus is on building an automatic tool for porting any project to the Buckaroo format.
We hope to make a public announcement in the near future!

@njlr 🎊  Awesome! That is really good news – keep up the good work!


jdk-17.0.5 release triage

Release Summary Report for openjdk17-pipeline
Report generated at: Thu, 20 Oct 2022 01:39:40 GMT
TRSS Build and TRSS Grid View
Jenkins Build URL https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk17-pipeline/539/
Started by user Wen Zhou at 10/19/2022, 12:19:49 AM

create_installer_mac ❌ undefined ❌
create_installer_windows ❌ undefined ❌
sign_build ❌ undefined ❌
sign_installer ❌ undefined ❌
sign_temurin_gpg ❌ undefined ❌

Test_openjdk17_hs_extended.openjdk_aarch64_alpine-linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_aarch64_alpine-linux_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_aarch64_alpine-linux_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_aarch64_linux ⚠ UNSTABLE ⚠
Rerun all
java -version
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

jdk_net_1 => deep history 4/5 passed | possible issues
jdk_net_0 => deep history 4/5 passed | possible issues
Test_openjdk17_hs_extended.openjdk_aarch64_mac ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_aarch64_mac_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_aarch64_mac_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_arm_linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_arm_linux_testList_0 ⚠ UNSTABLE ⚠
jvm_compiler_2 => deep history 2/5 passed | possible issues
Test_openjdk17_hs_extended.openjdk_arm_linux_testList_1 ⚠ UNSTABLE ⚠
jdk_net_2 => deep history 4/6 passed | possible issues
Test_openjdk17_hs_extended.openjdk_ppc64_aix ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_ppc64_aix_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_ppc64_aix_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_ppc64_aix_testList_2 ⚠ UNSTABLE ⚠
jdk_nio_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_ppc64le_linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_ppc64le_linux_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_ppc64le_linux_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_ppc64le_linux_testList_2 ⚠ UNSTABLE ⚠
jdk_beans_1 => deep history 2/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_s390x_linux ❌ ABORTED ❌
Test_openjdk17_hs_extended.openjdk_s390x_linux_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 2/4 passed | possible issues
jdk_tools_1 => deep history 2/3 passed | possible issues
jdk_imageio_1 => deep history 2/3 passed | possible issues
Test_openjdk17_hs_extended.openjdk_s390x_linux_testList_1 ❌ ABORTED ❌
jvm_compiler_0 => deep history 4/5 passed | possible issues
jdk_net_1 => deep history 1/4 passed | possible issues
jdk_nio_1 => deep history 1/4 passed | possible issues
jdk_management_1 => deep history 1/4 passed | possible issues
jdk_tools_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_s390x_linux_testList_2 ⚠ UNSTABLE ⚠
jdk_nio_0 => deep history 2/3 passed | possible issues
jdk_imageio_0 => deep history 2/3 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-32_windows ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_x86-32_windows_testList_0 ⚠ UNSTABLE ⚠
jvm_compiler_2 => deep history 0/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-32_windows_testList_1 ⚠ UNSTABLE ⚠
jdk_tools_2 => deep history 1/3 passed | possible issues
jdk_net_2 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_x86-64_linux_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_linux_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 3/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_mac ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_x86-64_mac_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 2/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_mac_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 2/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_windows ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_x86-64_windows_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 3/4 passed | possible issues
jdk_tools_1 => deep history 2/4 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_windows_testList_1 ⚠ UNSTABLE ⚠
jdk_net_1 => deep history 3/4 passed | possible issues
jdk_tools_0 => deep history 1/4 passed | possible issues
Test_openjdk17_hs_extended.system_s390x_linux ⚠ UNSTABLE ⚠
Rerun all
java -version
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

MiniMix_aot_5m_0 => deep history 3/4 passed | possible issues
DBBLoadTest_5m_0 => deep history 4/5 passed | possible issues
DBBLoadTest_5m_1 => deep history 4/5 passed | possible issues
Test_openjdk17_hs_sanity.openjdk_ppc64_aix ⚠ UNSTABLE ⚠
Rerun all
java -version
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode)

jdk_lang_1 => deep history 3/6 passed | possible issues
jdk_svc_sanity_0 => deep history 3/6 passed | possible issues
jdk_svc_sanity_1 => deep history 3/6 passed | possible issues
Test_openjdk17_hs_sanity.openjdk_x86-64_alpine-linux ⚠ UNSTABLE ⚠
Rerun all
java -version
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

jdk_util_1 => deep history 6/7 passed | possible issues
Test_openjdk17_hs_sanity.openjdk_x86-64_linux ⚠ UNSTABLE ⚠
Rerun all
java -version
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

jdk_util_1 => deep history 6/7 passed | possible issues

All jdk_net failures are similar to jdk11, which should be fixed by https://github.com/adoptium/aqa-tests/pull/4057. Can be double checked by rerun.

aarch64_alpine-linux

jdk_net rerun on https://ci.adoptopenjdk.net/job/Grinder/5803

aarch64_linux

jdk_net rerun on https://ci.adoptopenjdk.net/job/Grinder/5812

aarch64_mac

jdk_net rerun on https://ci.adoptopenjdk.net/job/Grinder/5813

arm_linux

failed tests rerun on https://ci.adoptopenjdk.net/job/Grinder/5815

ppc64le_linux

failed tests rerun at https://ci.adoptopenjdk.net/job/Grinder/5816

x86-32_windows

failed tests rerun at https://ci.adoptopenjdk.net/job/Grinder/5817

x86-64_mac

failed tests rerun at https://ci.adoptopenjdk.net/job/Grinder/5818

ppc64_aix

failed tests rerun at https://ci.adoptopenjdk.net/job/Grinder/5827

Win32 jvm_compile_2 failures should be excluded by https://github.com/adoptium/aqa-tests/pull/4064, which will also be backport to release branch when ready.
Test_openjdk17_hs_extended.openjdk_x86-32_windows_testList_0 ⚠ UNSTABLE ⚠
jvm_compiler_2 => deep history 0/4 passed | possible issues

ppc64_aix jdk_svc_sanity tests failed with no tests selected. testcases updated by https://github.com/adoptium/aqa-tests/pull/4019. Can be ignored, similar to jdk11
jdk_svc_sanity_0 => deep history 3/6 passed | possible issues
jdk_svc_sanity_1 => deep history 3/6 passed | possible issues

x86-64_alpine-linux

failed targets rerun at https://ci.adoptopenjdk.net/job/Grinder/5880

s390x_linux

failed targets rerun at: https://ci.adoptopenjdk.net/job/Grinder/5882

s390x linux continued
Failures from Shelleys rerun: https://ci.adoptopenjdk.net/job/Grinder/5897
https://ci.adoptopenjdk.net/job/Grinder_testList_1/152/testReport/
https://ci.adoptopenjdk.net/job/Grinder_testList_0/189/testReport/
jvm_compiler_0,jdk_net_1,jdk_tools_0,jdk_nio_1,jdk_management_1
Rerunning these failed targets https://ci.adoptopenjdk.net/job/Grinder/6027/console with extra timeout factor

arm linux continued
Remaining failing test case
compiler/floatingpoint/TestFloatJNIArgs.java#id0.TestFloatJNIArgs_id0
Rerunning on all machines

aix continued
Failing test cases
java/lang/invoke/MethodHandles/CatchExceptionTest.java.CatchExceptionTest
java/lang/invoke/MethodHandlesGeneralTest.java.MethodHandlesGeneralTest
java/lang/invoke/MethodHandlesSpreadArgumentsTest.java.MethodHandlesSpreadArgumentsTest
Shelleys grinder, https://ci.adoptopenjdk.net/job/Grinder/5871, and the original test job, https://ci.adoptopenjdk.net/job/Test_openjdk17_hs_sanity.openjdk_ppc64_aix/185/tapResults/, shows both jdk_svc_sanity 0 and 1 fail, yet the test output mentions no specific test case failure (all the specific failing test cases belong to jdk_lang)
In both 0 and 1, I see the line
09:02:27  Test results: no tests selected
in their console outputs

https://github.com/adoptium/aqa-tests/issues/4039#issuecomment-1291987791 does it mean AIX is done, or still failing need to check? @Haroon-Khel

@zdtsw Its a bit confusing. The jdk_lang tests pass. The jdk_svc_0 and 1 tests are reporting a fail, but do not show any specific failing tests. It could be a false negative, or we are not running the test correctly

you mean jdk_svc_sanity not jdk_svc ?
according to https://github.com/adoptium/aqa-tests/issues/4039#issuecomment-1284841229, it can be ignored?

Yeah, jdk_svc_sanity sorry.  I didn't see that comment. ppc64 aix is complete then

@zdtsw - re: https://github.com/adoptium/aqa-tests/issues/4039#issuecomment-1286415061 - 1 testcase remains, it will get excluded, consider s390x_linux AQA triage completed and good to release.


[5.7] TempRValueOpt: don't move end_access instructions after a terminator instruction.

When extending access scopes, prevent that we end up with an end_access after the block's terminator.
Fixes a verifier crash.
rdar://85020372
This is a cherry-pick of https://github.com/apple/swift/pull/59721

Reviewed by @meg-gupta


Add issuer: arg to quickstart example

We weren't able to get the example to work until we added the issuer -- in the table describing options, it is marked as required, but is not in the example.
Issuer https://github.com/m0n9oose/omniauth_openid_connect/issues/18#issuecomment-483508101

Stalebot is rude. This should stay open until a maintainer reviews it. This was a big usability thing and is a simple readme correction where the current documentation is clearly incorrect. Closing this because of lack of activity doesn’t change the fact that there’s clearly an error in the docs. Rather than allowing a bot to close this, it should stay open for other users to see, and eventually a maintainer to review, even if that takes a significant amount of time.

Not having this in the readme cost me a lot of time in troubleshooting. Thanks to @ttilberg for posting the issue which greatly helped me to get my setup working.


Can someone test the master branch with Google Assistant?

Happy to @UbhiTS. What do you need? Adding another media player as an Alexa doesn’t seem to work. Am I missing something? Assume you just have to make a standard TTS call.

Yeah. Added the google group and nothing, except I find the tts .mp3s in the confit folder.

Okay, I'll update the code, is it possible we can do a remote debug on your machine online

thanks... let me know.
I'm still troubleshooting to see if its in issue here

seems the issue isits using alexa notifications, not tts services.

sorry guys, I've been off the platform for a year. but back now and will start work on all issues. thanks for all your patience. apologies for the delay


Select Image discussion

Should we keep the select image option and open the default media browser with multi select enabled? Otherwise, we could simply remove the dialog entirely and just support multi file select - I think it's still fairly easy on both platforms to select media this way.
What do you think is the desired UX @tomShoutTheSecond?

@wellhat I think it's best to let the user choose whether to browse with their gallery app or their file browser app

@tomShoutTheSecond Yeah, I think that's true. Okay, I'll try and add support for this, but I don't like how it separates images/video sometimes

We decided on a select media feature

I think this is one we're not doing now


Table with serverless functions in README.md

Motivation and context

Add --platform local command line argument for nuclio as suggested by nuclio maintainers. Also add a table with DL models for automatic labelling into README.md for better visibility of the feature.
How has this been tested?

N/A
Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Pull Request Test Coverage Report for Build 6759

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 69.07%

Files with Coverage Reduction
New Missed Lines
%

cvat/apps/engine/media_extractors.py
5
76.11%

Totals

Change from base Build 6756:
-0.01%

Covered Lines:
11140

Relevant Lines:
15620

💛  - Coveralls


Site extensions deployed on deployment

We should add a command line tool that (running on azure) can deploy site extensions similar way to nuget using packages.config file, we can use siteextensions.config in the same format.
This tool should be called from our deployment script and will install the packages/site extensions specified in the siteextensions.config file.
We can probably extend kudu.exe to do this task.

ARM Template is the right way to do this.


(refactor) some opportunities to use lambda functions

This library targets Java 6 so this isn't feasible


API: Add Tenants Feature - New Tenants API

The tenants feature just became available this week in v19 on the UI and API.
This SDK needs to be updated to have this feature.
API reference: https://docs.novu.co/api-reference/tenants/

@Eazybright Do you want to take on this?

Alright, assigned to you @Eazybright

PR raised: https://github.com/novuhq/novu-ruby/pull/35
@unicodeveloper

Thanks, will take a look @Eazybright

Done!


Settings Problem

Cache_Tests property is not being set. We probably need to loop or check per setting.

Was a bad path. Resolved.


Upgrade Lodash Version to Fix Prototype Pollution Vulnerability

The version of lodash lib uses in this project contains low-risk Prototype Pollution Vulnerability. see https://www.npmjs.com/advisories/577, please upgrade it to the latest version if possible. Thanks

The version this projects uses ( 4.17.10 ) is the latest.
I guess your warnings come not directly from this project, but from the (node-cqrs-domain)[https://github.com/adrai/node-cqrs-domain] which depends on this project, but it's dependency isn't updated.
I will update it now, and hopefully those vulnerability warnings will be gone.

I've just published an update for node-cqrs-domain which addresses those issues.


Minor update to render-coursera.yml

Purpose/implementation Section
What changes are being implemented in this Pull Request?
@arpanda There are some brief updates to some things on the docker image that affected one of the checks. This fix in this PR should address it. Sorry for the inconvenience!

Shall I merge this one?

Yes! I think that makes sense.


feat: add stripe checkout redirect

One quick question: will we change the banner for all languages? If so, I could ask for translations for the banner text.

@scissorsneedfoodtoo, no it only changes English.
Although, I should add the curriculum nav item instead of donate for english as well.


Replace Java 19 with 20

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Ready to merge? If  not please let me know how I can fix! Thanks !


consolidateAfter keeps resetting to 0s in Karpenter v1

Description
Observed Behavior: consolidateAfter keeps resetting back to 0s. I'm also seeing the annotation compatibility.karpenter.sh/v1beta1-nodeclass-reference: '{"kind":"EC2NodeClass","name":"default"}' added automatically. The migration docs mention this, but I don't understand how to avoid v1beta1 compatibility features if all my resources are already v1.
Expected Behavior: consolidateAfter respects value specified in NodePool definition
Reproduction Steps (Please include YAML):
apiVersion: karpenter.sh/v1
kind: NodePool
metadata:
  name: default
spec:
  template:
    spec:
      requirements:
      - key: kubernetes.io/arch
        operator: In
        values: ["amd64"]
      - key: kubernetes.io/os
        operator: In
        values: ["linux"]
      - key: karpenter.sh/capacity-type
        operator: In
        values: ["spot", "on-demand"]
      - key: karpenter.k8s.aws/instance-category
        operator: In
        values: ["c", "m", "r"]
      - key: karpenter.k8s.aws/instance-generation
        operator: Gt
        values: ["2"]
      - key: "topology.kubernetes.io/zone"
        operator: In
        values: ["us-east-1a", "us-east-1b"]
      nodeClassRef:
        group: karpenter.k8s.aws
        kind: EC2NodeClass
        name: default

      expireAfter: 720h # 30 days

  limits:
    cpu: 1000
    memory: "8000Gi"

  disruption:
    consolidationPolicy: WhenEmptyOrUnderutilized
    consolidateAfter: 20m

Versions:

Chart Version: 1.0.6
Kubernetes Version (kubectl version):

Client Version: v1.31.2
Kustomize Version: v5.4.2
Server Version: v1.29.9-eks-ce1d5eb
WARNING: version difference between client (1.31) and server (1.29) exceeds the supported minor version skew of +/-1

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ketozhang ,
The nodepool that you have shared doesn't seem to have the annotation you have mentioned. Is this the nodepool that you are trying to create? Can you share the nodepool config that has the annotation?

Here's the output of kubectl get nodepool/default
apiVersion: v1
items:
- apiVersion: karpenter.sh/v1
  kind: NodePool
  metadata:
    annotations:
      compatibility.karpenter.sh/v1beta1-nodeclass-reference: '{"kind":"EC2NodeClass","name":"default"}'
      karpenter.sh/nodepool-hash: "14746486448688684082"
      karpenter.sh/nodepool-hash-version: v2
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"karpenter.sh/v1","kind":"NodePool","metadata":{"annotations":{},"name":"default"},"spec":{"disruption":{"consolidateAfter":"20m","consolidationPolicy":"WhenEmptyOrUnderutilized"},"limits":{"cpu":1000,"memory":"8000Gi"},"template":{"spec":{"expireAfter":"720h","nodeClassRef":{"group":"karpenter.k8s.aws","kind":"EC2NodeClass","name":"default"},"requirements":[{"key":"kubernetes.io/arch","operator":"In","values":["amd64"]},{"key":"kubernetes.io/os","operator":"In","values":["linux"]},{"key":"karpenter.sh/capacity-type","operator":"In","values":["spot","on-demand"]},{"key":"karpenter.k8s.aws/instance-category","operator":"In","values":["c","m","r"]},{"key":"karpenter.k8s.aws/instance-generation","operator":"Gt","values":["2"]},{"key":"topology.kubernetes.io/zone","operator":"In","values":["us-east-1a","us-east-1b"]}]}}}}
    creationTimestamp: "2024-11-07T21:07:20Z"
    generation: 8
    name: default
    resourceVersion: "5355881"
    uid: a3a64f10-3695-435b-ab2e-52911fac63bd
  spec:
    disruption:
      budgets:
      - nodes: 10%
      consolidateAfter: 0s
      consolidationPolicy: WhenEmptyOrUnderutilized
    limits:
      cpu: 1k
      memory: 8000Gi
    template:
      metadata: {}
      spec:
        expireAfter: 720h
        nodeClassRef:
          group: karpenter.k8s.aws
          kind: EC2NodeClass
          name: default
        requirements:
        - key: kubernetes.io/arch
          operator: In
          values:
          - amd64
        - key: kubernetes.io/os
          operator: In
          values:
          - linux
        - key: karpenter.sh/capacity-type
          operator: In
          values:
          - spot
          - on-demand
        - key: karpenter.k8s.aws/instance-category
          operator: In
          values:
          - c
          - m
          - r
        - key: karpenter.k8s.aws/instance-generation
          operator: Gt
          values:
          - "2"
        - key: topology.kubernetes.io/zone
          operator: In
          values:
          - us-east-1a
          - us-east-1b
  status:
    resources:
      cpu: "5"
      ephemeral-storage: 209690584Ki
      memory: 19817988Ki
      pods: "70"
kind: List
metadata:
  resourceVersion: ""

Can you check the storage version on your nodepool crd? Is it v1beta1?

How do I find out? Do you mean this portion in the CRD?
  storedVersions:
  - v1beta1
  - v1

Yes, looks like the stored version on your CRD is still v1beta1. You could also check if Storage is set to true for Name:v1beta1. But this is enough to confirm that you don't have stored version set to v1. You can follow the migration guide to upgrade your CRD to v1.

I believe I did. I even tried deleting all CRDs, nodepools, and nodeclasses and reinstalling.
❯ export SERVICE_NAME=karpenter
export SERVICE_NAMESPACE=foobar
export SERVICE_PORT=8443
kubectl patch customresourcedefinitions nodepools.karpenter.sh -p "{\"spec\":{\"conversion\":{\"webhook\":{\"clientConfig\":{\"service\": {\"name\": \"${SERVICE_NAME}\", \"namespace\": \"${SERVICE_NAMESPACE}\", \"port\":${SERVICE_PORT}}}}}}}"
kubectl patch customresourcedefinitions nodeclaims.karpenter.sh -p "{\"spec\":{\"conversion\":{\"webhook\":{\"clientConfig\":{\"service\": {\"name\": \"${SERVICE_NAME}\", \"namespace\": \"${SERVICE_NAMESPACE}\", \"port\":${SERVICE_PORT}}}}}}}"
kubectl patch customresourcedefinitions ec2nodeclasses.karpenter.k8s.aws -p "{\"spec\":{\"conversion\":{\"webhook\":{\"clientConfig\":{\"service\": {\"name\": \"${SERVICE_NAME}\", \"namespace\": \"${SERVICE_NAMESPACE}\", \"port\":${SERVICE_PORT}}}}}}}"

customresourcedefinition.apiextensions.k8s.io/nodepools.karpenter.sh patched (no change)
customresourcedefinition.apiextensions.k8s.io/nodeclaims.karpenter.sh patched (no change)
customresourcedefinition.apiextensions.k8s.io/ec2nodeclasses.karpenter.k8s.aws patched (no change)

In the migration docs, it says

After the upgrade, Karpenter starts converting these resources to v1 storage versions in real time.

I'm guessing for some reason this is not happening for me.


run npm build - issue

Hello,
I have an issue with npm run build.

Error when copy files from src/assets to dist

OK => Finished 'clean' after 33 ms
FAILED => Starting 'copy'...
'images' errored after 951 ms
Error in plugin 'gulp-imagemin:'
_

Message:
spawn /Users/julie/Documents/Web/Sites web/wopi/wp-content/themes/FoundationPress/node_modules/optipng-bin/vendor/optipng ENOENT
Details:
code: ENOENT
errno: ENOENT
syscall: spawn /Users/julie/Documents/Web/Sites web/wopi/wp-content/themes/FoundationPress/node_modules/optipng-bin/vendor/optipng
path: /Users/julie/Documents/Web/Sites web/wopi/wp-content/themes/FoundationPress/node_modules/optipng-bin/vendor/optipng
spawnargs: -strip,all,-clobber,-force,-fix,-o,2,-out,/var/folders/jx/xkm2yysx39zgd54ymvlv_bj00000gn/T/05846c17-27e1-49ac-8977-a1d47a328bfe,/var/folders/jx/xkm2yysx39zgd54ymvlv_bj00000gn/T/3906ae9c-a4f5-4cc1-bd49-f0d38036102b
cmd: /Users/julie/Documents/Web/Sites web/wopi/wp-content/themes/FoundationPress/node_modules/optipng-bin/vendor/optipng -strip all -clobber -force -fix -o 2 -out /var/folders/jx/xkm2yysx39zgd54ymvlv_bj00000gn/T/05846c17-27e1-49ac-8977-a1d47a328bfe /var/folders/jx/xkm2yysx39zgd54ymvlv_bj00000gn/T/3906ae9c-a4f5-4cc1-bd49-f0d38036102b
fileName: /Users/julie/Documents/Web/Sites web/wopi/wp-content/themes/FoundationPress/src/assets/images/logo_odp.png
domainEmitter: [object Object]
domain: [object Object]
domainThrown: false

2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>Thank you for your help
Julie

Error in plugin 'gulp-imagemin:'

Not an error in Foundation Sites.
Please check and report at https://github.com/sindresorhus/gulp-imagemin/issues

Hi Daniel, thank you for your answer.
In theme directory FoundationPress/node_modules/optipng-bin, there is no vendor directory. Do you know haw I can put it?

I never had this issue or used this gulp plugin but there are some relevant issues: https://github.com/imagemin/optipng-bin/search?q=vendor&type=Issues

https://github.com/imagemin/optipng-bin/issues/84
I suggest upgrading to Node.js 8 and npm 6.

I guess https://github.com/olefredrik/FoundationPress/issues is better for your questions and support needs.


feature request: pasting path of files into an oil buffer

Did you check existing requests?

[X] I have searched the existing issues

Describe the feature
It would be nice if oil.nvim could handle absolute file paths pasted into its buffers. In macOS when you copy a file in Finder, you can paste it in terminal and it will input its absolute path, if oil.nvim can copy the files upon writing the buffer, it will be possible to copy from Finder into oil.nvim.
Provide background
No response
Additional details
No response

To clarify: if you put an absolute path in an oil buffer and save, you want it to copy the file from the absolute path into the current buffer?

To clarify: if you put an absolute path in an oil buffer and save, you want it to copy the file from the absolute path into the current buffer?

Yes

For relative paths, I think it may increase the potential for errors. Users may be confused if they are addressing a relative path from current directory of oil.nvim, the cwd of Noevim or the directory of the last opened file, etc.
So we can give up on relative paths altogether or we can consider resolving them to absolute paths upon pasting so that users can see and confirm the resolved path before writing the buffer.


Has the latest build's exe been submitted to Microsoft?

It's still getting flagged on virustotal, so I was wondering if anyone has actually submitted it to microsoft yet? Sometimes it might get flagged by other antivirus because they're ai based and rely on detection from other sources like microsoft, so it might get rid of the false flag from windows defender.

I don;t have plan for that.
Related to #972


How to recieve binlog ?

May I recieve real-time binlog from mysql through this lib and how to do that ?

This module just implements the mysql text protocol. Myswl does not provide a way to do that over the text protocol.

This module just implements the mysql text protocol. Myswl does not provide a way to do that over the text protocol.

@RifeWang https://github.com/nevill/zongji extends this driver to add binlog parsing
Also there is binlog support in https://github.com/sidorares/node-mysql2


syz/syz-extract: Update Fuchsia extractor with current Fuchsia paths.

A change in Zircon a while back moved around where sysroots are located
in Fuchsia; this update will allow for proper extraction.

Otherwise looks good.


Amc loading page

@jamesjefferies Looks like a good solution given the constraints we have. Couple of thoughts:

it's quite a common user journey so I think we could do with some tests. Preferable to not have to have JS turned on all the time so maybe we could just hit the cache controller manually, or a controller test.....
It doesn't play that well with the back button. Not a deal breaker and I'm not sure about what a fix might be for that at the moment.


@swc/jest not transpiling a workspace dependency

Describe the bug
From the README of the minimal repro:

Demonstrates an issue with swc not transpiling a dependency.
This repository uses Yarn workspaces with Yarn v3 and the node-modules linker. package-b depends on package-a which
exports testVariable. package-b has a single test which imports testVariable and checks that it is defined.
package-a is not pre-transpiled. It is up to the Jest transformer to transpile it into a CommonJS module. package-b uses transformIgnorePatterns in jest.config.js to tell the transformer that node_modules/package-a needs to be transpiled.

Input code
Minimal repro with instructions to reproduce the issue:
https://github.com/srmagura/swc-repro2
Config
{
   "jsc": {
      "parser": {
         "syntax": "typescript",
         "tsx": true,
         "dynamicImport": true
      },
      "target": "es2021"
   },
   "module": {
      "type": "commonjs"
   }
}

Expected behavior
swc should transpile package-a/index.ts into a CommonJS module. The Jest test should succeed.
Version
The version of @swc/core: 1.2.85
The version of @swc/jest: 0.2.3
Additional context
Tested on Windows 10 with Node 14.17.6.

The tests in my minimal repro work after upgrading all packages! 👏👏👏


README.md change require

The text "contersAsGauges" has to be rename to "countersAsGauges" - in README.md. The spelling mistake is confusing to the user who is completely new for statsd-librato-backend.

@samitkumarpatel just fixed this - sorry about the trouble, and thank you for pointing it out!


[ECO-4947] Spec complete for typing indicators

Spec complete for typing indicators
https://github.com/user-attachments/assets/36f08ea1-c91e-4fd2-9030-5bf5d67a8d5c
add unit tests as part of this issue

@coderabbitai pause

I would suggest filter out own typings.

some users might not run it on 2 separate simulators so i think it's still nice to see in the demo app


added multi-section capabilities

This example demonstrates how we might include multi-build capabilities without breaking backward compatibility with the existing yaml structure. Not sure if this exact code will get merged, but hopefully will help facilitate the design discussion

 You should sign our Contributor License Agreement in order to get your pull request merged.

wow, that was quick. Just wanted to make sure we can still use when blocks in each of these. That would be clutch for us.

@gtaylor I haven't added the when blocks yet but shouldn't be too difficult. First we need to modify the build structure at https://github.com/drone/drone-exec/blob/master/yaml/types.go
type Build struct {
	Container `yaml:",inline"`

	Commands []string
+	Filter Filter `yaml:"when"`
}

Then we need to modify the appendBuild function to create a filter node. This will look very similar to our plugin code at https://github.com/drone/drone-exec/blob/master/parser/parse.go#L90

I think it's pretty good as the first step. I'd merge it w/o adding anything else since it's backward compat.

@crhym3 thanks for the review, I've made a number of adjustments per your recommendation. @gtaylor I ended up hooking up the when section when I was back in the code

You both are amazing. <3

LGTM

LGTM


Add When assert

This PR adds a When assert, inspired by joi. In order to achieve this we've needed to expose the validation context.

Seems great. But could you provide a real world example for this assert? I cannot find a real case it could suit me for example ;)

Hi,
Sure. Picture the following object:
{
  country: 'US',
  state: 'California'
}

The validation context makes possible to access the country value in a hypothetical State assert and match the value against a country specific list.
 assert = {
   state: new Assert().State(/* value of country available here  */)
 }

Regarding the assert. Lets say you just want to allow registration of users from California, New York and London. You can do something like:
assert = {
  country: new Assert().Choice([ 'UK', 'US' ]),
  state: new Assert().When( 'country', {
    is: [ new Assert().EqualTo( 'US' ) ],
    otherwise: new Assert().Choice( [ 'London' ] ),
    then: new Assert().Choice( [ 'California', 'New York' ] )
  } )
}

WDYT?

Hum,
I personally find it quite complicated and a bit flawed in your above example: what if you have many more countries?
I'd find more useful or elegant the usage of a second Choice assert like:
choicesAssert = {'UK': ['London'], 'US': ['New York', 'California']};
assert = {
  country: new Assert().Choice([ 'UK', 'US' ]),
  state: new Assert().Choice(choicesAssert(dynamicvalueofcountry)),
}

But dunno how to do it :)

Maybe the example I gave was a little bit "academic".
For complex situations we can use Assert.extend() to add a custom assert, maybe something like a StateByCountryAssert, or something like that, in this country/state situation.
The when assert is useful to avoid the necessity of creating new asserts.
Imagine (in the same example/object) you want to make state required for US users only:
assert = {
  state: new Assert().When( 'country', {
    is: [ new Assert().EqualTo( 'US' ) ],
    then: new Assert().Required()
  } )
}

Does this make more sense?

Hi @guillaumepotier,
Today I run in another use case, also country/state related, when developing a third party integration.
Check out the following requirements from the partner api documentation:

Field
Type
Length
Required
Description

country
string
3

ISO 3166-1 alpha-3 code. Defaults to USA if not specified.

state
string
2/55
?
If country is USA or CAN, 2 digit state code required.

Solutions
Using  When
We would be able to do something like:
assert = {
  country: [new Assert().String(), new Assert().Length({ min: 3, max: 3 })],
  state: new Assert().When( 'country', {
    is: [ new Assert().Choice( ['USA', 'CAN'] ) ],
    then: [new Assert().Required(), new Assert().String(), new Assert().Length({ min: 2, max: 2 })],
    otherwise: [new Assert().String(), new Assert().Length({ min: 2, max: 55 })]
  } )
}

Using  a CustomAssert
The alternative is to create a custom assert to validate state if country exists. Something like:
Please note that this is all pseudo-code and the real solution will require even more code:
export default function stateAssert(country) {
  this.country = country;

  this.validate = value => {
    if (!this.country) {
      return true;
    }

    if (typeof value !== 'string') {
      throw new Violation(this, value, { value: Validator.errorCode.must_be_a_string });
    }

    if (country === 'USA' || country === 'CAN') {
      return value.length === 2;
    }

    return value.length > 2 && value.length < 55;
  };

  return this;
}

Then we need to extend the validator asserts with this custom assert:
import { Assert as BaseAssert } from 'validator.js'

Assert = BaseAssert.extend({ StateAssert })

export Assert;

And then we could use it:
assert = {
  country: [new Assert().String(), new Assert().Length({ min: 3, max: 3 })],
  state: new Assert().state(country) // Note that we need to implicitly pass the country as we don't have access to the context.
}

This solution requires extra tests to the custom assert, etc.
WDYT?

Ok,
The above examples makes much more sense now :)

Hi @guillaumepotier,
Do you think you'll have time to review/merge this PR soon?
I'm really needing the assert.
Thanks in advance and best regards.

When assert is good. I'm just a bit perplex for the multiples context passing in various methods. This is not wrong, but feels a bit inelegant. Do not have much time to think about it and did not find a prettier solution :(

@guillaumepotier about your latest concern, I also don't see an easier solution without a major rewrite. Do you still think this is not a useful feature? If not, I would urge you to merge it as is, and maybe improve it later.

Yup you can go ahead and merge it.
Best

Examples could be better but we can improve documentation later on.

@guillaumepotier can you tag a new release?

Should be good now.

Thanks 🚀.

@guillaumepotier It seems the contents of dist have not been built since 2.0.0? When I get the lib with bower, either the 2.0.2 version or directly the github tag, I receive an old lib version that does not contain When.

Ok @jods4 my bad. 2.0.3 should have the proper built dist files now.
Best


Download only diff from unpacked FW

Is your feature request related to a problem? Please describe.
This feature request is not related to a problem I encounter using Bifrost but more a QoL improvement. Downloading 16GB of firmware each time an update is there is quite tedious. I notice on my phone, when using OTA updates, it only downloads a couple hundreds of MB (see screenshot below). If I already have an unpacked firmware downloaded, would it be possible to download only the "update" itself and not the whole firmware like OTA does?
Describe the solution you'd like
Being able to download less data when downloading an updated firmware over an already downloaded firmware.
Describe alternatives you've considered
Download the update on my phone using the OTA app in the settings and get the /data/fota/update.zip file. But I don't really know how to safely flash it using Odin (while preserving data and root).
Additional context
Screenshot showing how tiny the update is when using OTA updates.

Samsung's system for downloading OTAs is really complicated. It involves the device registering with Samsung's servers using a key generated based on device identifiers, and I don't think it's ever been fully reverse-engineered. The OTA packages are also in a different format compared to the full firmware; to flash an OTA you need to use ADB sideload in Recovery. OTAs also rely on a specific base firmware version to patch. Samsung sometimes serves multiple OTAs for multiple base versions, but in general, an OTA can only be installed over the previous firmware release.
I'm sure it's technically possible to figure out how the OTA system works and generate a patched full firmware for flashing through ODIN, but it's way outside of what I can do.

Thank you for your detailed answer. I did expect this to be a lot harder than it sounds, otherwise it would already have been done.