go get k8s.io/helm/pkg/kube  is failing because of missing packages

I am importing a package k8s.io/helm/pkg/kube  in my go file.
When I am doing go get k8s.io/helm/pkg/kube in my local , it is complaining about two missing packages.
../../../k8s.io/cli-runtime/pkg/kustomize/k8sdeps/factory.go:24:2: cannot find package "sigs.k8s.io/kustomize/pkg/factory" in any of:
../../../k8s.io/cli-runtime/pkg/kustomize/k8sdeps/factory.go:24:2: cannot find package "sigs.k8s.io/kustomize/pkg/factory" in any of:
Could you please tell me the resolution for this.

Currently, Helm's master branch is built against kubernetes 1.14. By using go get, you are fetching a newer version of Kubernetes. Kubernetes does not make backwards compatibility guarantees with their SDK.
I suggest using a proper package manager like dep instead of go get. That way you can fetch the proper version. Thanks.


[BUG]Python ImageBuf.make_writeable() + write() causes bad values for image with mixed depth channels

Describe the bug
OpenImageIO.ImageBuf writes out channels with bad values when the source image contains channels of mixed depths.
Background:  We are using OpenImageIO to inject metadata into rendered images.  This pipeline code just attempts to lazily do this by reading the source image via ImageBuf, making it writeable, adding some specmod attributes and writing it to a new file using the code below (metadata injection omitted as it is not relevant to this bug.)
The attached .exr file contains an single part image generated by Redshift where RGBA are all 32-bit and two aovs (P, N) are 16-bit.  These mixed depths seem to be causing this issue.  If all the channels are the same depth (all 32-bit, all 16-bit) then there is no issue.
To Reproduce
Unzip the attached image multidepth.exr.zip
Replace paths with valid source and target and execute the following statements in Python:
>>> import OpenImageIO as oiio
>>> filepath = "/path/to/multidepth.exr"
>>> target_path = "/some/target.exr"
>>> img_in = oiio.ImageBuf(filepath)
>>> img_in.make_writeable()
>>> img_in.write(target_path)

View the image and notice the resulting image is not correct.  See screenshot in Evidence below
Expected behavior
The images should match and not contain bad values.
Evidence
Comparison between source and re-written images:
Platform information:

OIIO branch/version: <IP_ADDRESS>-beta2
OS: Cent7
C++ compiler:  gcc-6.4.0
Any non-default build flags when you build OIIO:

I should mention that in an effort to work around/update the code I did find this example thiat is basically doing the same thing as we're trying to do https://openimageio.readthedocs.io/en/latest/imageoutput.html#copying-an-entire-image  however I appear to get the same result.

Proposed fix: https://github.com/OpenImageIO/oiio/pull/3088

Thanks Larry!


The process.py consistency checks do not accept input variable runtitle

In GitLab by @ajpearcey on Jul 15, 2020, 15:52
When running process as a python script it fails when checking the input variables in IN.DAT for the input runtitle. If this line of the IN.DAT is removed then it runs successfully.
The error spit out into the terminal is:
apearce@ajpearceyVM:~/work/PROCESS/testing_folder$ python ~/work/PROCESS/process.py
Running process.py
Traceback (most recent call last):
  File "/home/apearce/work/PROCESS/process.py", line 10, in <module>
    main()
  File "/home/apearce/work/PROCESS/utilities/process.py", line 221, in main
    Process()
  File "/home/apearce/work/PROCESS/utilities/process.py", line 42, in __init__
    self.validate_input()
  File "/home/apearce/work/PROCESS/utilities/process.py", line 206, in validate_input
    input_validator.validate(self.input)
  File "/home/apearce/work/PROCESS/utilities/process_io_lib/input_validator.py", line 136, in validate
    rule_list = RuleList(input_file_path)
  File "/home/apearce/work/PROCESS/utilities/process_io_lib/input_validator.py", line 26, in __init__
    self.data = in_dat.StructuredInputData(filename=input_file_path)
  File "/home/apearce/work/PROCESS/utilities/process_io_lib/in_dat.py", line 1403, in __init__
    use_string_values=False)
  File "/home/apearce/work/PROCESS/utilities/process_io_lib/in_dat.py", line 405, in get_parameters
    line_value = data[item].get_value
  File "/home/apearce/work/PROCESS/utilities/process_io_lib/in_dat.py", line 858, in get_value
    return parameter_type(self.name, self.value)
  File "/home/apearce/work/PROCESS/utilities/process_io_lib/in_dat.py", line 674, in parameter_type
    param_type = DICT_VAR_TYPE[name]
KeyError: 'runtitle'

The identical IN.DAT will run with no issues if run using run_process.py
ref @jonmaddock

I can't recreate this error as process.py has been removed. I was able to run python process/main.py -i tests/integration/data/large_tokamak_IN.DAT and this worked as expected and did not throw any errors, so will close the issue


Re-enable JSR166TestCase on jdk23 and jdk24 for OpenJ9

The reason for exclusion is resolved via: https://github.com/ibmruntimes/openj9-openjdk-jdk/pull/812
and: https://github.com/ibmruntimes/openj9-openjdk-jdk23/pull/11
Signed-off-by: Nathan Henderson<EMAIL_ADDRESS>

@llxia Could you review too?


Disconnection from BLE device on sending commands via Android App version 12.

Hi
I am working on Health & Fitness based android app, which is paired with Smart Ring BLE device. After pairing process app is discovering services for various UUID. For every UUID, app is enabling the Notification, to notify the app whenever any value is triggered from any characteristic. This procedure is working very fine for 95% of android phones.
But I am facing issues with One Plus Nord Android Version 12. Observations are mentioned below :

Discover the services -> Enable notification -> Send command to BLE device to receive data from a characteristic -> BLE device disconnecting

Discover the services -> Send command to BLE device to receive data from a characteristic -> Enable notification -> Working fine

Discover the services -> Send command to BLE device to receive data from a characteristic -> Enable notification -> Worked fine for few minutes but disconnected

-Discover the services -> Send command to BLE device to receive data from a characteristic -> Notification enabled Before -> Worked fine for few minutes but disconnected
-Discover the services -> Send command to BLE device to receive data from a characteristic -> Enable Notification -> No response
I am using same BLE device with other Android model it working very fine no disconnecting issue faced.
I tested this scenario with this github repo and my project facing same behaviour.
What I did to resolve it

Network and Bluetooth Reset
Bluetooth Cache clear from system app
I tried by changing connection interval, slave latency and supervisor timeout in ring side.

Sample code of enabling notification in my project
`
fun queueSetNotificationForCharacteristic(
gatt: BluetoothGatt,
characteristic: BluetoothGattCharacteristic
) {
val ghattQueueItem = GhattQueueItem(
characteristic = characteristic,
enabled = true,
ghatt = gatt,
ghattQueueItemType = SUBSCRIBE_CHARACTERISTIC
)
setNotificationForCharacteristic(ghattQueueItem)
}
private fun setNotificationForCharacteristic(ghattQueueItem: GhattQueueItem) {
ghattQueueItem.ghatt?.let { gatt ->
ghattQueueItem.characteristic?.let { characteristic ->
gatt.setCharacteristicNotification(characteristic, true)
// This is specific to Heart Rate Measurement.
val descriptor = characteristic.getDescriptor(UUID.fromString("00002902-0000-1000-8000-00805f9b34fb"))
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU){
gatt.writeDescriptor(descriptor, BluetoothGattDescriptor.ENABLE_NOTIFICATION_VALUE)
}else{
descriptor.value = BluetoothGattDescriptor.ENABLE_NOTIFICATION_VALUE
gatt.writeDescriptor(descriptor)
}
}
}
}
`
Do I need to get descriptor for other UUIDs too and then write descriptor to enable notification value ??
I am stuck here where and how to proceed furthur.

Hello, we've also seen odd BLE behaviors with OnePlus Nord across a couple of Android versions so this isn't surprising. That said, we cannot provide technical support without more debug information, and we'd highly recommend you post somewhere like StackOverflow where the community may be able to assist you better.

Hey
As you mentioned that techniacl support cannot be provided without more debug information.
If you can let mw know what other information you need I'll provide it to you.
As you also mentioned, this odd BLE behaviors is seen before how did you manage to resolve it?? Any suggestion might be helpful for me. Because it is not just in OnePlus Nord, this behaviour also observed in other mobile phones like Vivo and Samsung.

We did not notice odd BLE behaviors on VIvo/Samsung, if anything, Samsung is the most reliable Bluetooth stacks on Android based on our observations — it's even better than AOSP/Pixel and they figured out an Android 13 BLE issue before Google did.
On the technical information, you may provide any stack trace from Logcat that points to an issue with this codebase, upon which we may try to reproduce and fix the issue; however, from the sounds of it, it's likely a device/stack-specific issue that we don't have control over. For this latter case, unfortunately there's not a lot we can do to help.

For BLE stack trace, is Bluetooth Snoop Logs are good for tracking ??

Not really, because those don't reveal what's happening with the code from this codebase.
I'd recommend posting on StackOverflow — the community there (myself included) may be able to help you better there.


failed to move temporary token to desired output location. when syncing multiple containers in parallels

Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
AzCopy 10.16.1
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
I have a powershell script running in a pipeline that downloads the latest azcopy from Microsoft and runs azcopy login using a spn key. Then in a foreach-object loop, I queue 5 jobs to sync 5 containers at the same time  awaiting the completion
most of the time this works great but occasionally I get the following error. 4 of the containers will sync just fine but then 1 will fail to process.
Cannot perform sync due to error: failed to move temporary token to desired output location. src="C:\Users\user\.azcopy\plans\token1928218855" dst="C:\Users\user\.azcopy/plans/accessToken.json", rename C:\Users\user.azcopy\plans\token1928218855 C:\Users\user.azcopy/plans/accessToken.json: Access is denied.
How can we reproduce the problem in the simplest way?
  .\azcopy.exe login;
    $storageSyncJob = $containers | ForEach-Object -AsJob -ThrottleLimit 5 -Parallel {
      Write-Output "*** sync container $_ from $using:sourceStorageAccount to $using:targetStorageAccount ***";
      ./azcopy.exe sync "https://$using:sourceStorageAccount.blob.core.windows.net/$_" "https://$using:targetStorageAccount.blob.core.windows.net/$_" --recursive --delete-destination $using:deleteDestination;
      if (!$?)
      {
        Throw "Azcopy failed to sync container $_";
      }
    }
    $storageSyncJob.ChildJobs | ForEach-Object { $_ | Receive-Job -Wait; }
    Remove-Job $storageSyncJob;

Have you found a mitigation/solution?
No, Is there a way to specify a different plan folder for each run? I tried to set AZ_JOB_PLAN_LOCATION to disambiguate but that seems to be a global environment variable.

Hi @skyaddict, use auto-login for this scenario.  With auto-login, you can skip the explicit login command in your script.
Plan location is global at this time, and we will continue to do so.

I will give that a shot thanks!

@nakulkar-msft It appears that autologin does not honor AZCOPY_JOB_PLAN_LOCATION. If I set this along with $env:AZCOPY_LOG_LOCATION, I get the following error:
INFO: Authenticating to destination using Azure AD
Cannot perform sync due to error: no cached token found, please log in with azcopy's login command
If I use just AZCOPY_LOG_LOCATION autologin works fine. do you think that is a bug?


Not getting rewards

A few users have reported an issue of not getting rewards.

Looks like performing a UX action does the trick. Seems to be a UX-side bug.
cc @ciocan feel free to ping me for a wallet that has this issue.

fixed here:
https://github.com/NearDeFi/burrow-cash/commit/8b1b7132fdccf84d6276c7d16c6dc2f8daf6697c
the unclaimed supply rewards were not computed right


Reset ignored issues has disappeared

Previously if you clicked "X Ignore this issue" then a "reset" link would appear in the issue panel. However it seems to have disappeared in recent versions - assume this is a bug?

This still appears if there aren't any other warnings or errors to display, but it should always display if there are ignored warnings 🤔

Ah yes you're right, it reappears if there's no issues so it's definitely a bug. At least I know how to get it back if required!


Create a dev folder; add instructions on git braches, pull requests and linking commits to issues for the rest of the team

Self-assigned as the other team members may need a reminder in the form of a tutorial

The "tutorial" has been added in commit 60be144.
@vvv-hikka @IcySergio
The issue is closed.


Update copyright year and segregate Javascript code

Hello @Virtual4087,
I would like to contribute to this project as part of Hacktoberfest 2024. I am suggesting two changes:

Update the copyright year in the footer to 2024. Currently, it's 2023:

Move all the javascript code to respective script files for better segregation and reduce code debt in HTML files.

@Maaz-Code That would be really helpful but please check everything is working as they were originally before creating a pr.

@Maaz-Code I've assigned this to you under hacktoberfest


(PUP-6474) Add gettext-setup gem and externalize some early strings

Typo in the PR title? Says "6464" but means "6474".

Grumble. Not sure why the @#$)(*@#$ commit checker got confused here. We can probably just ignore that.
This LGTM. IIUC it's only the 1d0874f commit that we'd want to revert once the server change goes in - do I have that right?

@kylog did we ever fix the "wrong base branch" thing?
And yeah, that's the only commit to revert. I tried to keep it contained

@branan yes in e1efdebf. I think you may not have that in your branch. As an experiment, can you rebase this branch from current master and push?

@kylog done. Let's see what happens...

wait, darn. I forgot to fetch master. Mine was way out of date. Let's try this one more time

@kylog There we go, that did the trick

This looks good. If it works, I say 👍

CLA signed by all contributors.

Looks like we still need more packaging changes to make gettext happy. I'm working on it.

The message it's failing on isn't in this PR. I'm going to try rebasing onto latest mater to see if that helps

@branan I verified that from this PR I can use the gem to generate a POT file on OSX and Ubuntu. I was hoping to do Windows too, but I've been having trouble just getting bundle install to complete cleanly on my VM, for reasons unrelated to this. Do you have any recommended ways to verify this on Windows?

reviewing

Also the gettext-setup gem has no automated testing, only trivial spec test coverage and no OS specific acceptance tests.  Are we sure we want to depend on this gem?

@glennsarti regarding the gettext-setup gem: It's owned by us, and is intended to be a lightweight way to share gettext initialization code across ruby projects. We can definitely evaluate pulling it out and handling that stuff internally, but probably we just need to take ownership of it now that it's past "prototype" stage and make it less bad.

This PR is superseded by #910


lolcat no longer working, i have ruby installed.

a_random_lantern@hal-9000:~$ lolcat
bash: /usr/local/bin/lolcat: /usr/bin/ruby2.5: bad interpreter: No such file or directory

I don't know why this is happening all of a sudden, it used to work before.

I have the same problem after updating my system. Ruby is on version 2.7 now.

What OS?  Have you tried snap install?

Yes, it didn't change anything. I have also reinstalled ruby.

What OS is this on and how was lolcat installed?

I use ubuntu on WSL:
neofetch
            .-/+oossssoo+/-.               dan@Daniellaptop
        `:+ssssssssssssssssss+:`           ----------------
      -+ssssssssssssssssssyyssss+-         OS: Ubuntu 20.04 LTS on Windows 10 x86_64
    .ossssssssssssssssssdMMMNysssso.       Kernel: 4.19.104-microsoft-standard
   /ssssssssssshdmmNNmmyNMMMMhssssss/      Uptime: 6 hours, 37 mins
  +ssssssssshmydMMMMMMMNddddyssssssss+     Packages: 2246 (dpkg), 4 (snap)
 /sssssssshNMMMyhhyyyyhmNMMMNhssssssss/    Shell: bash 5.0.16
.ssssssssdMMMNhsssssssssshNMMMdssssssss.   CPU: Intel i7-7500U (4) @ 2.903GHz
+sssshhhyNMMNyssssssssssssyNMMMysssssss+   Memory: 330MiB / 6280MiB
ossyNMMMNyMMhsssssssssssssshmmmhssssssso
ossyNMMMNyMMhsssssssssssssshmmmhssssssso
+sssshhhyNMMNyssssssssssssyNMMMysssssss+
.ssssssssdMMMNhsssssssssshNMMMdssssssss.
 /sssssssshNMMMyhhyyyyhdNMMMNhssssssss/
  +sssssssssdmydMMMMMMMMddddyssssssss+
   /ssssssssssshdmNNNNmyNMMMMhssssss/
    .ossssssssssssssssssdMMMNysssso.
      -+sssssssssssssssssyyyssss+-
        `:+ssssssssssssssssss+:`
            .-/+oossssoo+/-.

 ✘ dan@Daniellaptop  ~  sudo snap remove ruby
ruby removed
dan@Daniellaptop  ~  sudo snap install lolcat
snap "lolcat" is already installed, see 'snap help refresh'
dan@Daniellaptop  ~  sudo snap remove lolcat
lolcat removed
dan@Daniellaptop  ~  sudo snap install lolcat
lolcat 100.0.1 from moe (busyloop) installed
dan@Daniellaptop  ~  echo test | lolcat
Traceback (most recent call last):
2: from /usr/local/bin/lolcat:23:in `<main>'
1: from /usr/lib/ruby/2.7.0/rubygems.rb:294:in `activate_bin_path'
/usr/lib/ruby/2.7.0/rubygems.rb:275:in `find_spec_for_exe': can't find gem lolcat (>= 0.a) with executable lolcat
(Gem::GemNotFoundException)
✘ dan@Daniellaptop  ~  whereis ruby
ruby: /usr/bin/ruby /usr/bin/ruby2.7 /usr/lib/x86_64-linux-gnu/ruby /usr/lib/ruby /usr/share/man/man1/ruby.1.gz

What does which lolcat say? 🤔

$ which lolcat
/usr/local/bin/lolcat
$ head "$(which lolcat)"
#!/usr/bin/ruby2.7
#
# This file was generated by RubyGems.
#
# The application 'lolcat' is installed as part of a gem, and
# this file is here to facilitate running it.
#                                                                                require 'rubygems'

I found a workaround:
sudo mv /usr/local/bin/lolcat lolcat
$ sudo snap remove lolcat.bkp
lolcat removed
$ sudo snap install lolcat

Yes, it looks like you had a lolcat installed from a different source
(ever done a gem install lolcat or apt install lolcat in the past?).
Lolcat installed from snap should be located in /snap/bin/lolcat. 🙂

Yes, I used apt previously and I updated using apt (sudo do-release-upgrade). However, lolcat was not available there after the update.

Hmm yep. Will need to look into ways to make this all less confusing.
Glad you figured it out tho 👍

Let's see if it works for the original poster, too.

Yeah it worked for me, thanks.
Late reply I know

I encountered the same problem on Linux Mint 21. I had lolcat installed, via apt I think, on Mint 20.3, and all worked. But now:
$ lolcat
bash: /usr/local/bin/lolcat: /usr/bin/ruby2.7: bad interpreter: No such file or directory
$ which ruby
/usr/bin/ruby
$ ruby --version
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]
$ apt list ruby
Listing... Done
ruby/jammy,now 1:3.0~exp1 amd64 [installed]
ruby/jammy 1:3.0~exp1 i386

I don't know the ruby setup in mint but you can most likely fix it
with gem install lolcat (or sudo gem install lolcat).
You may need to remove any previously installed version first
(either with the package manager you used, or with sudo rm -f /usr/local/bin/lolcat)

@m-o-e
Marvellous: that worked. Thank you. I did indeed have to use sudo.

Ah: sorry to bang on, but suddently I see the following!
neofetch | lolcat
/usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1401:in `rescue in block in activate_dependencies': Could not find 'paint' (~> 2.1) among 94 total gem(s) (Gem::MissingSpecError)
Checked in 'GEM_PATH=/home/<redacted>/.gem/ruby/3.0.0:/var/lib/gems/3.0.0:/usr/local/lib/ruby/gems/3.0.0:/usr/lib/ruby/gems/3.0.0:/usr/lib/x86_64-linux-gnu/ruby/gems/3.0.0:/usr/share/rubygems-integration/3.0.0:/usr/share/rubygems-integration/all:/usr/lib/x86_64-linux-gnu/rubygems-integration/3.0.0' at: /var/lib/gems/3.0.0/specifications/lolcat-100.0.1.gemspec, execute `gem env` for more information
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1398:in `block in activate_dependencies'
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1387:in `each'
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1387:in `activate_dependencies'
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1369:in `activate'
	from /usr/lib/ruby/vendor_ruby/rubygems.rb:286:in `block in activate_bin_path'
	from /usr/lib/ruby/vendor_ruby/rubygems.rb:285:in `synchronize'
	from /usr/lib/ruby/vendor_ruby/rubygems.rb:285:in `activate_bin_path'
	from /usr/local/bin/lolcat:25:in `<main>'
/usr/lib/ruby/vendor_ruby/rubygems/dependency.rb:311:in `to_specs': Could not find 'paint' (~> 2.1) among 94 total gem(s) (Gem::MissingSpecError)
Checked in 'GEM_PATH=/home/<redacted>/.gem/ruby/3.0.0:/var/lib/gems/3.0.0:/usr/local/lib/ruby/gems/3.0.0:/usr/lib/ruby/gems/3.0.0:/usr/lib/x86_64-linux-gnu/ruby/gems/3.0.0:/usr/share/rubygems-integration/3.0.0:/usr/share/rubygems-integration/all:/usr/lib/x86_64-linux-gnu/rubygems-integration/3.0.0' , execute `gem env` for more information
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1399:in `block in activate_dependencies'
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1387:in `each'
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1387:in `activate_dependencies'
	from /usr/lib/ruby/vendor_ruby/rubygems/specification.rb:1369:in `activate'
	from /usr/lib/ruby/vendor_ruby/rubygems.rb:286:in `block in activate_bin_path'
	from /usr/lib/ruby/vendor_ruby/rubygems.rb:285:in `synchronize'
	from /usr/lib/ruby/vendor_ruby/rubygems.rb:285:in `activate_bin_path'
	from /usr/local/bin/lolcat:25:in `<main>'

. . And, after reinstalling lolcat, again, the problem disappeared once more. I reinstalled lolcat via apt. So that was the needful in my case.


How can I use the Lora Adapter for a model with Vocab size 40960?

The error occurs when I call the LLMEngine object.
The error below appears.
ValueError: When using LoRA, vocab size must be 32000 >= vocab_size <= 33024

Does the method using the Lora Adapter not apply to models that expand the vocab or have a vocab size larger than 32000?

please support bigger vocab size like yi_6b: 64000

same issue, I deployed a LLaMA structure LLLM but the vocab_size had been expanded to 130,000

same problem, please add support for vocab_size over 32000. in my case you need vocab_size 60256

I found a solution which inspired by  Gemma
you can find the file: vllm/vllm/model_executor/models/llama.py,  then find the definition of LlamaForCausalLM (in line 278)
that's the original support lora modules
    # LoRA specific attributes
    supported_lora_modules = [
        "qkv_proj",
        "o_proj",
        "gate_up_proj",
        "down_proj",
        "embed_tokens",
        "lm_head",
    ]
    embedding_modules = {
        "embed_tokens": "input_embeddings",
        "lm_head": "output_embeddings",
    }
    embedding_padding_modules = ["lm_head"]

just remove some modules which may cause errors and finally saving like this:
    # LoRA specific attributes
    supported_lora_modules = [
        "qkv_proj",
        "o_proj",
        "gate_up_proj",
        "down_proj",
    ]
    embedding_modules = {}
    embedding_padding_modules = []

+1 for this, Please add more vocab size.

Why doesn't the lora adapter load based on the vocabulary size of the origin model, even though the target_modules in adapter_config.json doesn't have embed_tokens and lm_head?

Was also trying to run Yi with the same problem..
@Yard1 can you elaborate on what's needed to support? I'd be glad to work on this PR

We'd need to modify the kernel/write a new LoRA kernel to support such a large vocabulary size. The current Punica ones cannot do that.

@Yard1 How does the Gemma avoid this? it also has a huge vocab_size

We just don't allow the embeddings layer to be modified

We just don't allow the embeddings layer to be modified on gemma

The Yi_6B has  64000 vocab_size, when i modify the source just like gemma，it's work fine。
but the Yi_6B_200K always throw exception:

"+1. Need support for a larger vocabulary size. In addition to vocabulary size, there is also a use case like LLaMA Pro block expansion fine-tuning with LoRA, which may not have LoRA weights for all layers. For example, only layers 5, 10, 15, and 20 might have corresponding LoRA weights."

It should already be possible to use adapters which do not modify every layer - if that is not the case, it is a bug and should be fixed.

Also made it work with a gemma-like adaptation to Yi and it works :)

lora finetune for Llama-3 has the same problem, however same code finetune Qwen1.5-7B-Chat, with vocab size 151643, has no such problem, why?

@qZhang88 Llama 3 should be supported in latest release.

@Yard1 I've tried llama3 on v0.4.0.post1, but this issue is still present when initializing the engine with lora adapters. The latest main code seems to get further in the initialization process (ie. no explicit crash about vocab size) but seems to stall out later in the pipeline - haven't gotten a chance to debug that yet.
But to confirm - llama3 with adapters is supposed to work on 0.4.0.post1, or were you referring to the latest version of the codebase that's currently unreleased?

It should be 0.4.1 - this is the commit: https://github.com/vllm-project/vllm/commit/1e96c3341a4e055ae392085fecc7a672295b71c2

@Yard1 how can we upgrade to this release ??

@Techinix You can either manually install the wheel from the Release page or build yourself locally from the tagged git version. On my setup, local building takes around 15-30min.

For the LLaMA 3 model:
Please use the following codes for your tokenizer:
tokenizer.pad_token = tokenizer.eos_token

In this way, the vocabulary size is still 128256 .
However, if you use
tokenizer.add_special_tokens(
    {'pad_token': '[PAD]'}
)
# Resize input token embeddings matrix of the model if new_num_tokens != config.vocab_size.
model.resize_token_embeddings(len(tokenizer))

The vocabulary size is increased to 128768 , which leads to this ValueError: When using LoRA, vocab size must be 32000 > vocab_size < 128512 error.
For now, I don't know the reason. If you know the reason, please leave a message. Thank you very much in advance!
Shuyue
May 11th, 2024

Wouldn't it make more sense to check which layers the LoRA-adapter actually applies to? Most LoRA-frameworks don't even touch the embedding layer by default.


change starting point runtime.

Hi. how can i change starting points in runtime mode?
I called the getResultsInternal () function;
but I still have a problem. how to clear allocated memory in GPU. you can help me.
cudaFree () doesn't work.
please tell me.

This code i have no plan to update.
Please use KeyHunt-Cuda Project.


Dockerfile: Change exposed port.

Port 32400 is not used within the container (expose has nothing to do with outbound traffic). Changed it to 8484 in order to allow for service discovery to function correctly when using stuff like reverse proxies.

Thanks for the help!

Thanks for the help!


Fix #1254: don't ignore errors when retrieving service classes and plans

Was the change discussed in an issue?
fixes #1254
How to test changes?
odo service create while connected to a non service catalog enabled cluster.

@metacosm Thanks for the pr, However i find some issue while i run manual test.
Test environment i used:
macOS, minishift v1.30.0

Steps i followed to hit the issue:

minishift start

$ MINISHIFT_ENABLE_EXPERIMENTAL=y ./minishift start --extra-clusterup-flags "--enable=*,service-catalog"

odo login (Got binary from running "make bin" on master branch)

$ ./odo login
[...]
Using project "myproject".

odo service create

$ ./odo service create
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x1c742d3]

goroutine 1 [running]:
github.com/redhat-developer/odo/pkg/service.NewServicePlan(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/amit/go/src/github.com/redhat-developer/odo/pkg/service/service.go:364 +0xc3
github.com/redhat-developer/odo/pkg/odo/cli/service/ui.enterServicePropertiesInteractively(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/amit/go/src/github.com/redhat-developer/odo/pkg/odo/cli/service/ui/ui.go:240 +0x92
github.com/redhat-developer/odo/pkg/odo/cli/service/ui.EnterServicePropertiesInteractively(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/amit/go/src/github.com/redhat-developer/odo/pkg/odo/cli/service/ui/ui.go:234 +0x76
github.com/redhat-developer/odo/pkg/odo/cli/service.(*ServiceCreateOptions).Complete(0xc4207c5f20, 0x247b099, 0x6, 0xc420868900, 0x32b1bd8, 0x0, 0x0, 0xc420a25c30, 0x0)
	/Users/amit/go/src/github.com/redhat-developer/odo/pkg/odo/cli/service/create.go:98 +0x5c0
github.com/redhat-developer/odo/pkg/odo/cli/service.NewCmdServiceCreate.func1(0xc420868900, 0x32b1bd8, 0x0, 0x0)
	/Users/amit/go/src/github.com/redhat-developer/odo/pkg/odo/cli/service/create.go:196 +0x6d
github.com/redhat-developer/odo/vendor/github.com/spf13/cobra.(*Command).execute(0xc420868900, 0x32b1bd8, 0x0, 0x0, 0xc420868900, 0x32b1bd8)
	/Users/amit/go/src/github.com/redhat-developer/odo/vendor/github.com/spf13/cobra/command.go:702 +0x2c6
github.com/redhat-developer/odo/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc4208c0240, 0xc420a25ea0, 0x8, 0x2091514)
	/Users/amit/go/src/github.com/redhat-developer/odo/vendor/github.com/spf13/cobra/command.go:783 +0x2e4
github.com/redhat-developer/odo/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4208c0240, 0x257b4c0, 0xc4200aea80)
	/Users/amit/go/src/github.com/redhat-developer/odo/vendor/github.com/spf13/cobra/command.go:736 +0x2b
main.main()
	/Users/amit/go/src/github.com/redhat-developer/odo/cmd/odo/odo.go:64 +0x382

However user scenario works fine for odo service create while connected to a non service catalog enabled cluster. Steps

minishift start
odo login
odo service create

$ ./odo service create
 ✗  unable to retrieve service classes: unable to list cluster service classes: clusterserviceclasses.servicecatalog.k8s.io is forbidden: User "developer" cannot list clusterserviceclasses.servicecatalog.k8s.io at the cluster scope: no RBAC policy matched

@metacosm Would you please confirm if the issue is reproducible from your end (@mik-dass Could not reproduce it) and also would be great if you add these scenario in integration test in a separate pr.

@amitkrout how long have you waited after you started minishift with the service catalog to run the tests? Service catalog is notoriously tricky when it comes to timing and it needs quite a bit of time to be properly ready to serve. I use a cluster where service catalog is set up and running and never saw this issue.

how long have you waited after you started minishift with the service catalog to run the tests?

Ahh...this could be the issue. Let me try it with some time gap then

Service catalog is notoriously tricky when it comes to timing and it needs quite a bit of time to be properly ready to serve. I use a cluster where service catalog is set up and running and never saw this issue.

No luck even after a long gap of 1 hr :( .Any thoughts
@mik-dass is not able to reproduce it because he follows same the steps that you following.


Verovio rendered examples missing captions

The examples in the Guidelines rendered by Verovio are missing a figcaption element. It would be good to have a similar style for all example images.

Compare cmnOctave and cmnFing. The latter graphic carries the caption Figure 34. Fingering in Hanon’s exercise no. 21. Similar should be the rendered examples.

I agree, it would be good. However, I am afraid I am not the right person to have this assigned to

I guess this is just because the head element in the cmnOctave example (and others with rend="verovio code") is empty?
https://github.com/music-encoding/music-encoding/blob/b48d5cbc4b7c232932020f456e6db3c72089782d/source/docs/04-cmn.xml#L1011-L1014
Compare to cmnFing:
https://github.com/music-encoding/music-encoding/blob/b48d5cbc4b7c232932020f456e6db3c72089782d/source/docs/04-cmn.xml#L1088-L1091

Files are here: https://github.com/music-encoding/music-encoding/tree/develop/source/examples/verovio

Missing captions to all examples in the chapter on Mensural notation has been added in PR #1409
Does anyone feel responsible for the other chapters?

By the way, there are also missing captions for listings. At least in the Mensural chapter, I added captions to every figure.

There are something about 70 listings in metadata chapter and about 100 in cmn chapter. So I guess, applying captions to all of them is something for a very rainy day....


Old version i.e. 1.6.0

Hi all,
why old android sdk version (1.6.0) has been deleted from repository and when it was happend?
Thanks for reply!

Hi there
SumUp endeavours to keep our developer offerings inline with the market and all security requirements at all times.  The existing legacy repos were reviewed and amended accordingly. If you'd like to discuss further, please reach out to<EMAIL_ADDRESS>Thanks


[WIP]Fix width of select elements in settings.

First commit is to fix width of select elements in settings page. The width is set to auto so that they can be wide enough for different languages with minimum width set to 325px.
Second commit is to fix width of select elements in stream settings page. The width is set to auto so that they can be wide enough for different languages with minimum width set to 325px.
Third commit is to fix the width of dropdown-list-widget for long options.

https://chat.zulip.org/#narrow/stream/101-design/topic/select.20elements.20in.20settings

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

GIFs for settings page -

GIFs for stream settings page -

Note that for dropdown-list-widget, I have only fixed the behavior for long options in stream settings page. We can fix others if this looks good.

Can we make the page scrollable horizontally in such case? If we do this then user can see the options completely. We do that currently for stream settings.

Sure, that seems reasonable to me.

Added commit to enable horizontal scrolling.

Also, if the behavior for dropdown-list-widgets (the one for "Who can unsubscribe others" stream setting) seems fine, I can try doing that change for others as well.

Also, if the behavior for dropdown-list-widgets (the one for "Who can unsubscribe others" stream setting) seems fine, I can try doing that change for others as well.

I didn't notice any problems with it. Anything in particular I should pay attention to?
The only thing is that it would be great if the down-angles looked the same across all dropdowns, or at least within a single settings page.

The things that have changed in the widget are -

The position of the dropdown menu iopened is shifted slightly above.
For long options present in the dropdown. the menu is wide enough to fit the longest option, while the button to open the dropdown can be less wide as its width is to fit the selected option.

The only thing is that it would be great if the down-angles looked the same across all dropdowns, at the very least within a single settings page.
This should be fixed in #23071. I stopped working on it due to it not working correctly for long options, so should be able to work on it once we finalize this.

OK, cool, those changes feel fine to me.
One subtle thing I noticed while testing again is that I hover over an option with the mouse, pressing "Enter" does not select it. It does select it for other dropdowns, which I think is better.

What's the next step for this? I see it's still marked as a draft but don't know what the next action is.

I skipped the commits and they look generally reasonable. We should consider moving .settings_select to be a top-level class in app_components.css rather than one that has a duplicate copy in stream settings.

I am still doing the work to update the width of menus for all dropdown list widgets. Will try to update the PR by tonight.

Thanks! We should prevent the bot owner dropdown from going on two lines:

Looks good to me otherwise! The follow-ups sound good as well.

We should prevent the bot owner dropdown from going on two lines when the selected option is long:

I think this is being fixed in #24487. Need to review that PR too once. Will do it today itself.

@timabbott I think you should take a look now. There are some follow-ups, but this PR may be ready for integration.

Merged, thanks @sahil839!


I'll be on shortly.


merge package template from arlac77/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   79.78%   79.78%
=======================================
  Files           3        3
  Lines         183      183
=======================================
  Hits          146      146
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e37d39...65b1bd8. Read the comment docs.

Coverage remained the same at 72.574% when pulling 65b1bd866cf79ef412e6df5a76656efc37c46526 on template-sync-1 into 6e37d398f5eeff7a8b314c393d027c9f88943988 on master.


Add observers to user defaults

Added observers to make Home respond to changes in UserDefaults.shared.didUserMakeContactWithSickUser and UserDefaults.shared.lastTestedDate. Additional changes to the drawScreen() were necessary to prevent redrawing / other funkiness on state change.
Linter checks are going to be complaining over the TODO's I left in there, which are a result of my incredibly jank method for testing this: I've set it up so that when you click the spreadButton it logically not's the UserDefaults.shared.didUserMakeContactWithSickUser value and makes the user have been tested 15 days ago, and when you click the testedButton it makes the user have been tested 13 days ago. This way you can manually check all the different transitions work properly (just keep clicking the buttons).
You can test that manually yourself, once this PR is approved I'll delete that logic and uncomment the segue logic.

"I've set it up so that when you click the spreadButton it logically not's the UserDefaults.shared.didUserMakeContactWithSickUser value and makes the user have been tested 15 days ago, and when you click the testedButton it makes the user have been tested 13 days ago." Just to be sure, this logic is just for testing, yes?

"I've set it up so that when you click the spreadButton it logically not's the UserDefaults.shared.didUserMakeContactWithSickUser value and makes the user have been tested 15 days ago, and when you click the testedButton it makes the user have been tested 13 days ago." Just to be sure, this logic is just for testing, yes?

Yes that was just for testing and now its gone. For now you'll have to take my word that I tested it; it maybe makes sense to create a ticket that adds some options in the menu to toggle these states manually based on a DEV flag.

Sounds good, we don't want that code anyway to be on dev.


Add debounce to move_cover

Description:
The PR adds the logic already used for the light brightness sliders in HomeKit to the cover position sliders.
Related issue (if applicable): fixes #14292
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

Hi guys,
has this PR embedded on latest version 0.72?
Thanks

@stich86 This PR is included in HA since 0.69.


[29/01/23] Project documentation - Setup/Introduction

Summary

Create technical documentation for project
Fixes #151
Lorem ipsum dolor sit amet, consectetur adipiscing.
List of changes proposed in this PR (pull-request)

Create technical documentation for project
Add necessary tutorial files
Complete doc homepage
Add contribution guides

@sandygudie please how did you create the netlify preview for the blog site, i'd like something similar for the  code documentation

I have completed the introduction, usage and getting started guide

Welldone Richie
You would have to open an account with Netlify to deploy projects there.
I don’t mind doing it from my account if needed
Also you could try GitHub pages if the folder containing the work is in the root folder
Let me know which one suits you

Welldone Richie You would have to open an account with Netlify to deploy projects there. I don’t mind doing it from my account if needed
Also you could try GitHub pages if the folder containing the work is in the root folder
Let me know which one suits you

Thanks @sandygudie I'll open the netlify account

Thank you, Sandy!
Yes, let us know if GH pages can be an easier option!


Add juju action for ad-hoc certificates

For debugging/experimentation it would be helpful if the charm had an action that would take the same args as generate_csr  (except private key) and output the (newly generated) private key and signed cert.

We do have the tls-certificates-requirer that can leverage the tls-certificates interface and be used for receiving certs from self-signed-certificates operator. Does this satisfy the need?

@sed-i Any comment before I close this issue?

The tls-certificates-requirer addresses the exact use case I was looking for, but I think usability is higher with an action, because it is easier to extract content from juju run ... --format json | jq ... .
The analogous with juju show-unit would require us to know the app name.


java.lang.OutOfMemoryError: Metaspace while running plugin tests on Travis CI

Following https://github.com/gradle/gradle/issues/8354#issuecomment-529666227, a more detailed description of the problem:
This error happens systematically on Travis CI (works fine on my machine) when running the apollo-gradle-plugin-incubating tests:
./gradlew :apollo-gradle-plugin-incubating:test

After ~10min the tests fail (full logs at https://travis-ci.org/apollographql/apollo-android/builds/582181815):
com.apollographql.apollo.gradle.KotlinDSLTests > project configures correctly and generates something FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /home/travis/build/apollographql/apollo-android/apollo-gradle-plugin-incubating/build/testProject with arguments [generateApolloClasses, --stacktrace]
    Output:
    Daemon will be stopped at the end of the build after running out of JVM memory
    FAILURE: Build failed with an exception.
    * What went wrong:
    A problem occurred configuring root project 'testProject'.
    > Could not open cache directory 5pj9vcbz7mfs0olb6tql927ze (/tmp/.gradle-test-kit-travis/caches/5.6/gradle-kotlin-dsl/5pj9vcbz7mfs0olb6tql927ze).
       > Metaspace

[...]

Caused by: java.lang.OutOfMemoryError: Metaspace
    	at org.jetbrains.kotlin.com.intellij.openapi.util.objectTree.ObjectNode.execute(ObjectNode.java:105)
    	at org.jetbrains.kotlin.com.intellij.openapi.util.objectTree.ObjectTree.executeAll(ObjectTree.java:162)
    	at org.jetbrains.kotlin.com.intellij.openapi.util.Disposer.dispose(Disposer.java:129)
    	at org.jetbrains.kotlin.com.intellij.openapi.util.Disposer.dispose(Disposer.java:125)
    	at org.gradle.kotlin.dsl.support.KotlinCompilerKt.compileToDirectory(KotlinCompiler.kt:624)
    	at org.gradle.kotlin.dsl.codegen.ApiExtensionsJarKt.compileKotlinApiExtensionsTo(ApiExtensionsJar.kt:113)
    	at org.gradle.kotlin.dsl.codegen.ApiExtensionsJarKt.compileKotlinApiExtensionsTo$default(ApiExtensionsJar.kt:130)
    	at org.gradle.kotlin.dsl.codegen.ApiExtensionsJarGenerator.compileExtensionsTo(ApiExtensionsJar.kt:64)
    	at org.gradle.kotlin.dsl.codegen.ApiExtensionsJarGenerator.generate(ApiExtensionsJar.kt:52)
    	at org.gradle.kotlin.dsl.codegen.ApiExtensionsJarKt.generateApiExtensionsJar(ApiExtensionsJar.kt:39)

The history of what I tried (Xmx4096m, -XX:MaxMetaspaceSize=512m, oraclejdk vs openjdk) is there: https://github.com/apollographql/apollo-android/pull/1577/commits
Most of the red crosses are MetaSpace OOMs except the 3 first ones which were a different issue. This commit for an example, should have the error: https://github.com/apollographql/apollo-android/pull/1577/commits/040770a5b3c686861a87d109975097c2029f49b7
Ultimately, I was able to make the tests pass by splitting them in 2 gradle invocations but that doesn't sound super robust: https://github.com/apollographql/apollo-android/pull/1577/commits/5ccdae8dbbff7cb64d556e8491b44741aaabcda8
The plugin tests use the GradleRunner APIs to run on 34 test projects. Most of them use groovy buildscripts but the one who fails uses build.gradle.kts kotlin buildscripts, that might be a lead.

Build scan there: https://scans.gradle.com/s/vgoygq6oiacsy/

Hi Stale Bot 👋 . Can we keep this one open a bit more? Finding the root of the MetaSpace error would allow to keep the daemon alive longer and have tests run faster

I'm seeing the OutOfMemoryError: Metaspace when running tests for a custom plugin on our build servers (AWS CodeBuild).  Maybe the same thing.

I'm seeing the OutOfMemoryError: Metaspace when running tests for a custom plugin on our build servers (AWS CodeBuild).  Maybe the same thing.

@martinbonnin I am facing a similar issue with sonarqube. Have you found any workaround or root cause for this?

@utsav0209 I ended up increasing the Java heap and metaspace:
https://github.com/apollographql/apollo-android/blob/59bc9ca38ea9bc4b9fbe2b01ba8f4d38340c260a/apollo-gradle-plugin/src/test/kotlin/com/apollographql/apollo3/gradle/util/TestUtils.kt#L31

Saw this in a gradle project too. Upgrading from gradle 2.13 to 6.5 and such java metaspace error happen. Sometimes also complain heap exhausted.
Sus: saw Xmx Xms both set to 64m, but that shouldn't affect metaspace, it's in native memory...

Just keeping this alive, saw this just today consistently on just the 8th invocation of GradleRunner, all fairly simple projects with build.gradle

@martinbonnin , I see you attempted increasing metaspace via gradle.properties, however, it does not help me. Do you know if it really helped you?
What worked for me was casing GradleRunner to org.gradle.testkit.runner.internal.DefaultGradleRunner and adding metaspace:
this as DefaultGradleRunner
withJvmArguments("-XX:MaxMetaspaceSize=1g")

Do you know if it really helped you?

I think it did ? I'm not 100% certain TBH but I haven't had any issue in a while now so I'm not really eager to open this pandora box...
FWIW, the gradle.properties is in the project under test so I'm assuming the GradleRunner will be able to pick this one up too so it's technically equivalent to your commit. But since this not always reproducible, it's hard to tell for sure.

the gradle.properties is in the project under test so I'm assuming the GradleRunner will be able to pick this one up too so it's technically equivalent to your commit

I tried creating gradle.properties in project under test, and it did not work for me for unknown reason.

Thank for the update! I removed the -XX:MaxMetaspaceSize=1g from gradle.properties (here). I'll report here if the build fails again.


Odd behavior with accented characters

I'm having problems with accented characters. For example, if I put console.log('é');in the hello.js example right before the var spooky = new Spooky on line 7, it works fine but if I put it inside a spooky.then(function () { on line 24, it just hangs after starting. I've tried many different things to try to have it use the accented characters but it always hangs (it just displays [info] [phantom] Starting...).
It works fine on my local machine (MacOSX) but it has problems on my Centos server. Any pointers would be greatly appreciated. Thanks.

This is probably a duplicate of #110. It's fixed in 3235388.

Sorry, didn't see that one! I thought I searched everything. Thanks!


Add support for pyarrow=11

Codecov Report
Base: 98.81% // Head: 98.81% // No change to project coverage :thumbsup:

Coverage data is based on head (d82ec73) compared to base (0d54577).
 Consider uploading reports for the commit dad5587 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   98.81%   98.81%
=======================================
  Files          94       94
  Lines        3033     3033
=======================================
  Hits         2997     2997
  Misses         36       36

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Improve the way title id is handled

Done with https://github.com/HugoGiraudel/react-a11y-dialog/commit/e89e73c12cb3e3a84457c152c19c2a3159a164dc.


Release 1.2.2

Releasing 1.2.2
and also cleared the Changelog.md File and linked to the new Release-Tag which is not yet existing.
Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My commit messages follows the conventional commit format
[ ] My change requires a change to the documentation, and updated it accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I would merge it today evening (~ in 6h), please review.


Add new Dribblish Theme and fix Shadow around the main view

Theme name: "Ant-Dracula" based on the Dracula colors from https://draculatheme.com/

You should have a much more evident contrast in the colours of the main "plate" and the "ground" one

It still doesn't convince me, sorry. Also, the z-index makes the friends tab unclickable

Okay strange, for me the z-index didn't change the clickability of the friends-tab
Sad to hear that a minimal Theme for people who are using the Dracula theme as main theme in Linux, can't use Spotify in the same style.


promtool - add option to check rule from slice

I've added an option to check rules directly from a byte slice instead of a file
this helps me creating a service that can verify rules at runtime through using promtool as a lib

Thanks for your PR. To keep things maintainable we do not add code to internal APIs that we don't need ourselves, as that makes things difficult to maintain as it creates a defacto public API where we've stated that there explicitly is no such API and can break it at will. I'd suggest shelling out to promtool instead.

We have looked at this PR during our bug scrub and decided to close it because we do not add code in Prometheus that we do not use, like specified above.


Newer CloudReady (and perhaps other Chromium distributions) don't allow flashrom access even with iomem=relaxed

It appears that it might be an artifact of using a much newer kernel than most Chromebooks, and there are some new restrictions in the 5.4.x and newer series against root accessing certain devices like the EEPROM chips without enabling certain options, and unloading the Intel module as suggested on the Flashrom FAQs failed because it was build into the kernel NOT as a module, and even adding iomem=relaxed didn't resolve the error I was getting so I ended up having to boot a Linux LiveUSB instead to restore the stock firmware to a Chromebook I was testing a couple things with.
https://flashrom.org/FAQ
I've been looking around and I think I might have found a way to turn off the kernel_lockdown feature that prevents your scripts from working on a normal "secure" CloudReady installation if a user is planning on restoring the stock firmware and abandoning their CloudReady since the workaround requires disabling verity and making some other modifications that probably aren't advisable to run long term if the system is used for banking or other sensitive information.

I don't have any interest really in working around the stuff Cloudready does differently from ChromeOS. It's easy enough to boot another Linux live USB and update from there, IMO

Now that Neverware is owned by Google I'd imagine things will probably be more consistent between ChromeOS and CloudReady, and the kernel lockdown is probably something they are testing in CloudReady before rolling out to Chromebooks when they start shipping with 5.x kernels.
I made a couple changes that don't appear to have done much, but I'll continue to poke at it a little bit more since I'll be demonstrating the full RW_LEGACY and full UEFI options and installing Linux/CloudReady then reverting it ChromeOS to a group of students in a month or so. It would be nice to avoid making an extra dozen USB drives with Linux to go with the ChromeOS recovery drives and CloudReady installers.
I'll have to try enabling PXE for an install one of these days so I can boot Linux from my travel router instead of a flash drive.

the kernel lockdown is probably something they are testing in CloudReady before rolling out to Chromebooks when they start shipping with 5.x kernels.

that would be problematic for flashing Chromebooks, since booting with adjusted kernel params isn't easily doable


fix (Sonarr): Fix x265 (no HDR/DV) section on Sonarr collection of custom formats page

Pull Request
Purpose
Fix x265 (no HDR/DV) toggle so content correctly appears inside the selector.
Approach

Fix indentation in x265 (no HDR/DV) description text.

Open Questions and Pre-Merge TODOs

[x] Build and test locally

Requirements

[x] These changes meet the standards for contributing.
[x] I have read the code of conduct.

I think there is a typo in the title?

Updated title


Peripheral Network Access

Closes #17

[x] Network invalidation hooks
[x] Packet handling
[x] INetworkAccess for peripherals attached directly to computers.
[x] Work with non-multipart cables.
[x] Work with full block modems

I'd like INetworkAccess to extend INetwork, but I don't want an API interface to extend an unpublished CC interface. Should I just have INetworkAccess implement the same named methods as INetwork?

And oh gosh I didn't realize what you had been doing in the api-rewrites branch... These might be slightly difficult to merge.

Working out some crashes that I ignorantly created, and now this is happening.

HOW??

Awesome! I wouldn't worry about my api rewrites branch - I planned to merge it after this anyway as I knew this would create conflicts.
I don't think it should all the methods of INetwork - we don't need to know where the packet is being sent from for instance. I feel we should keep the signatures as similar to INetworkNode: transmitPacket(Packet) rather than sending the individual arguments. I don't know if it should be getConnectedPeripherals/getPeripherals rather than peripheralsByName though as they aren't exactly similar - one applies to the node, one applies to the network.
For INetworkedPeripheral do we want to have a networkInvalidated(INetworkAccess) method which is called when the network is invalidated? Peripherals might do their own caching of the network and they need to know about it.
I also think INetworkAccess should have an invalidateNetwork() method if it changes something and needs to tell people, though I'm not 100% sure that it should take this form.
My one worry about deferring peripheral finding is that finding them could happen on the Lua thread instead, which shouldn't be a problem but is something to be aware of.

It's peripheralsByName because the point of network access is to let the peripheral see the other peripheral objects on the same network.
I like the ideas for network invalidation though. Updated the OP with a todo list for this.

What's the best way to deal with patching a private inner class? I need to patch PeripheralAPI$PeripheralWrapper for computer local networks, but both PeripheralAPI and PeripheralWrapper have so many private fields and methods, I'm not sure what the best way to do that is.

I've noticed some bugs with peripherals not being detached until toggling peripheral access - not removed on neighbour updates. I've added some debug blocks that test just log to console and it doesn't register it any more.

So wait you're saying IPeripheral.detach isn't being called when a peripheral's block is broken?

I've just tested this, and it is the same on master as well, so it isn't an issue with this pull request. The actual issue is that the network invalidate isn't fired unless all peripherals are removed. This is an issue with this method.

So what's the fix? Also thoughts on my question from a couple of comments ago?

I guess more accurately the issue is that the only check we do on multi-peripheral modems to see if
anything has changed is the enabled one. I'll probably add a custom change check to the multi-peripheral modem.
Sorry, I only just saw the previous question. I guess you'll need to override the attach and detach methods? So if you @MergeVisitor.Stub the m_peripheral, m_attached, m_mounts and m_fileSystem fields it should work. There really isn't a better way :frowning:.

Alright. Well do I just make a class and write in the methods that need to be overwritten, then use a partial patcher to patch? That's what I did with CableBlockRenderingHandler, since that's a private inner class, but I'm not sure that's the best way to do it.
		new ClassPartialPatcher(
			"dan200.computercraft.client.proxy.ComputerCraftProxyClient$CableBlockRenderingHandler",
			"org.squiddev.cctweaks.core.patch.CableBlockRenderingHandler_Patch"
		)

It should be fine seeing as most of the code should be copied from the original file. If you don't need methods from the outer class everything should work. I'm surprised that the CableBlock renderer works seeing as static constructors aren't supported and you have a static field. I'll probably do an ASM dump on that class to see what happened.
I'm not 100% happy with my patch to multi-peripheral modems - I ensure the IDs were identical before and after - but there could be an edge case where the IDs and so the invalidated event isn't fired.

Yea the whole CableBlockRenderingHandler thing needs a reimagination. It definitely won't work once obfuscated, ant its weird that the static field works.
And yea there should be a better fix for that.

I've tested it, it does work. Because it inherits from an FML class instead it isn't obsfucated - and so works normally. There are several things which probably will need rewriting some time in the future. They work fine, just not perfectly, and so aren't a priority.

It also seems that the network events are not always called on multipart modems or normal modems. You may be aware of this already?

I am not. What events aren't getting called?

Sorry for the slow response, detach events were never being called - I could toggle the modem and detach was never called.

Hm... I honestly have no idea why. Not able to get at the code at the moment though.

Thats fine, I'll have a go at fixing it. Gotta do some revision first though.

Is there anything else major you see that needs fixing before merging?

Sorry, Friday is 'work on other stuff' day. I'll have a look now though it looks good!

I'll be at a big MTG tournament today so I probably won't be able to respond to anything for a while, but if you have some spare time, I sent you a question in a PM on CC forums.

I've just had a look at this (8 hours after I said I would :frowning: - sorry) and I've found some more bugs. Most of these are just me being pernickety so sorry.
When you break a block next to a multipart modem,  it is not detached. I think this is because TileNetworkedModem listens to both block and tile change, whilst PartModem only listens to block change, so the tile is removed before we can attach to it. A similar bug is that attaching tiles to a full block after they are connected does not fire attachToNetwork, but does still invalidate the network and so does call attach(IComputerAccess).
I'm thinking maybe a better way would be to cache peripheral instances so it is easier to track when attach/detach events should be fired and we are not dependent on events as much. However I'm not sure how best to do this as we would have to compare peripherals with IPeripheral.equals(IPeripheral) so we'd want some sort of custom set - or force subclasses of BasicModem to return a fixed length array.
A more major bug is that normal wired modems do not get attach/detach events at all. TileCable doesn't use BasicModem at all so we might want to change that and get original modem methods to delegate to the BasicModem class.

I thought I fixed the block breaking detach thing. I'll take another look.
And oh I thought TileCable used BasicModem. My bad.

Definitely having some trouble here. It's painfully awkward how little happens on demand. Instead, a lot happens in the update method, leaving a tick where a lot of things aren't right. I'll figure it out and get it working despite this, but then after we merge #29, I want to take a look at rethinking some of the network code. In particular, network invalidation should be immediately followed with revalidation, rather than waiting a tick. There should be a revalidateNetwork method, where nodes clear caches and rediscover their peripherals, then there should be a networkRevalidated method, where nodes reach into the network to find the remote peripherals the rest of the network found in the revalidateNetwork call.

The update tick delay is strange. I'm guessing exists for the same reason that packets aren't sent until an update tick: to ensure thread safety whilst traversing the network. The network could be invalidate on the Lua thread which we need to be aware of. If we can get it to happen on the Lua thread however without problems and remove the need to an update method at all, that would be wonderful.

Yea but like I said, this is an issue that would be more easily solved after #29 is done. I'll submit an issue, then I'll try to close this issue today. Then hopefully we can merge master into api-rewrites, and get that swiftly taken care of.

I'm wondering if something like AE has might be worth thinking about - caching the entire network instead. There could be a shared network object for every node - though this could be much more complicated today.
I've looked at providing snapshots and it is possible - I'm not sure if it is entirely needed once 0.2 is stable though.

 Basically requires building an entire API just for managing what's on the network. Granted, I'd love to write something like that, and it would be better. But it just adds yet another big step before .2 can be released. Also, it largely invalidates a lot of the work we've done, which is a major feelbad =P

I wasn't suggesting we implemented it any time soon. It would be one of those things that would be interesting to do in the very long run. I guess I probably should have planned the entire networking code's structure before I dived into it: we're paying the price for that now. :anguished:

So getConnectedPeripherals is now cached, and everything seems to be working.
Is there anything left before merging?

I'll pull and test now. Good work!

Just tested and most things seem to work. :+1: However on modem blocks network events are not fired if the modem is active and a peripheral is placed down next to it, however attach(IComputerAccess) events are fired.
An even more minor problem is that detachFromNetwork is not called when broken. I don't know how to fix that without caching peripherals though.

Well peripherals are cached now. It was an unfortunately necessary measure....
Under what circumstances does detachFromNetwork not get called? I tested breaking peripherals next to computers, next to modems of both PartModem and TileCable kinds, and next to modem blocks, and the all seemed to work.

Ah, I didn't see the caching. My fault. TileCable works perfectly, but detach is never called when I break a networked peripheral. I'll test again to check.

Ok so the issues are

[ ] TileCable doesn't call detach when the connected peripheral is broken.
[ ] Already active modem blocks don't call attachToNetwork when an additional peripheral is placed next to it.

Am I missing anything?

I just did a test in vanilla CC, a peripheral attached via cable doesn't get detached when broken. Should we change this behavior?

There are a lot of bugs with the default TileCable implementation - if you break the peripheral (so the modem also breaks) and replace the modem, it is still on. I think we probably should fix it, but I'll also add it to my 'network bugs' topic on the forums.

Well, for now, I say we table the issue of fixing faulty vanilla behavior for later. I think I'd rather merge in the API rewrites, then try to see if we can rewrite how much of the networking works. Clearing that up and getting around all the weird stuff and corner cases we currently have to deal with would make fixing the vanilla stuff easier.

I'll do a quick test now and then I think we are ready to merge then?

Agreed. Is there anything more to do with the api rewrites branch before trying to merge these changes into it?

Just tested. Works like a charm. :shipit:
I don't think there is anything else for the API rewrites branch. I'll considering adding a INetworkNodeHost and IPeripheralHost classes that return a Peripheral/Node on TEs instead of delegating every call to a modem or using IPeripheralTile. That, and OpenPeripheral integration, I'll probably do on separate branches though.

Great. I'll pull this into master and see what I can do to merge master and api rewrites.

Yay! Merge conflicts!


Carousel repeat.for not working

I am trying to use the repeat.for to render images inside of the carousel component, but it blows up.

It works for me when the data is already there, try where you set your data asynchronously.
https://gist.run/?id=04c392533457e93f34c2a0f5813521ac

Thanks for the example.
I understand that the initialization should be deferred in that case. Maybe carousel can be re-initialized although I'm not sure if that makes sense in practice. I'll try ot.


Offset for imagery

Some satellite imagery doesn't line up with real world/ground truth and require the imagery to have an offset. Having support for specifying a known offset could help the neural network train more accurately.

Hey thanks for the feedback.
If you know the offset why not using e.g. gdal to align the imagery to the OpenStreetMap labels? You want to align anyway for the resulting map, no? I don't think we should encode this in our model.

Sometimes you don't own the imagery server such as the ESRI World Imagery server and unless you are downloading the tiles individually and rehosting it, it would be a pain to do it with gdal

Can you do it on the fly e.g. like this proxy https://github.com/mapbox/whoots-js?
We have to dowload the tiles anyway to work with their slippy map representation. Not sure I follow here. Rehosting can be as simple as starting a local http server and pointing rs download to it, no?
python3 -m http.server

In the slippy map dir should do the trick.

Correct me if I'm wrong here wms encodes the left top most corner with a certain value (z x y)
So with the current process the wms and openstreetmap data looks and aligns like this:

But with a offset to the imagery it can look like this:

So this would be during the download of the imagery it could affect the folders/images to substract/add the offset to the z/x/y? After that nothing else would have to be done as the coordinates would be corrected

I see what you mean now.
Maybe in this specific case it's easier to apply the offset to the extracted GeoJSON files directly? Assuming your offset is the same for all features. You could then work on the GeoJSON features, use e.g. shapely to do geometric transformations, and write out new GeoJSON files again.

Closing here as not actionable on our end. I'd like to keep robosat free from arbitrary transformations on satellite imagery or GeoJSON features.


About sampling

I also ran into the problem here,
problem
and I used the corresponding code you provided:
cap = captions[0].data.cpu().numpy()
sentence = ""
for j in range(len(cap)):
if cap[j] == 0:
break
word = self.ixtoword[cap[j]].encode('ascii', 'ignore').decode('ascii')
sentence += word + " "
and the altered sampling function:
ubuntu pastebin
I am confused about why this code was generating multiple same images under a same keys[j](referring to the screenshot below, the same generated images were sampled due to a same keys[j]), with different captions:

I found out the problem by myself. The var name coincidently conflicts with the parent for loop var(.........)
cap = captions[0].data.cpu().numpy()
sentence = ""
for l in range(len(cap)):
if cap[l] == 0:
break
word = self.ixtoword[cap[l]].encode('ascii', 'ignore').decode('ascii')
sentence += word + " "


findcall is not working

Describe the bug
when i get notification in background then after register , i am trying to find call using call id but i am getting null

how i can i fix ? please help ?

I am facing this issue as well

The plugin won't save the call information if the app is killed and the plugin isn't set up. You can either initialize and register in the background or save the call information so the app can read it once it is in the foreground again.

@victortive do you have any suggestions on how to use the saved call? Because in the cases the call arrives after a notification in killed state, the SipUaHelper instance is not the same on the background isolate and main isolate

if the SipUaHelper is not the same instance consider wrapping it in a class and making that class a singleton

I did that, but single isolates don't share memory, it does not work
Em ter., 6 de ago. de 2024, 17:42, Victor Uvarov @.***>
escreveu:

if the SipUaHelper is not the same instance consider wrapping it in a
class and making that class a singleton
—
Reply to this email directly, view it on GitHub
https://github.com/flutter-webrtc/dart-sip-ua/issues/438#issuecomment-2272112292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABR3LYGFLKVQ4CRWKZJNOELZQEYJRAVCNFSM6AAAAABHQHCFHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSGEYTEMRZGI
.
You are receiving this because you commented.Message ID:
@.***>

try saving it in shared preferences on the native side and reading it on the dart side

I don't know if that would work. Since shared preferences only accepts serializable types and also if I save let's say, the informations of the call, I think it's not possible to attribute the saved call to the new instance SipUaHelper

One way to work it out is, keeping the SIPUAHelper in background isolate and sending only the neccessary information to the main isolate.
In your case, send the call ID to background isolate, find the Call, handle it there and send those UI related infos to main isolate like for showing active call or any as you prefer.
But one constraint here is the video call implementation. As we need to pass MediaStream to main isolate and we can't serialize it.


Win32 - set internal _shown flag if ShowWindow will make window visible

What does the pull request do?
Fixes an issue where, if a window starts out with window state Maximized, the _shown flag isn't set because Windows doesn't send the WM_SHOWWINDOW message for Maximize state. This flag is used internal for resize operations, and should be properly synced.
What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

This solution leaves gaps. A window can be shown without hitting the method containing the new code, either because the window was directly manipulated by non-Avalonia code, or because another Avalonia type is showing it (e.g. popups).
There must be a message which is sent to the window when this situation occurs, otherwise it wouldn't know to start repainting. We should identify it and set the bool when that message is received.

This solution leaves gaps. A window can be shown without hitting the method containing the new code, either because the window was directly manipulated by non-Avalonia code, or because another Avalonia type is showing it (e.g. popups).
There must be a message which is sent to the window when this situation occurs, otherwise it wouldn't know to start repainting. We should identify it and set the bool when that message is received.

We cannot account for changes users make to the window using native apis. As said in the pr description, WM_SHOWWINDOW message isn't sent when the show command is Maximize or Minimize. As for popups, they always shown with ShowNoActivate command, which will send the message.

The proper message to use here is probably WM_WINDOWPOSCHANGED.
The lParam will point to a WINDOWPOS which contains SWP_SHOWWINDOW on show, SWP_HIDEWINDOW on hide, and neither for other position changes.

The proper message to use here is probably WM_WINDOWPOSCHANGED.
The lParam will point to a WINDOWPOS which contains SWP_SHOWWINDOW on show, SWP_HIDEWINDOW on hide, and neither for other position changes.

This works quite well. Updated to use it.


RDF::Changeset is now free of RDF::Mutable/RDF::Writable (Closes #405)

I didn't bother with a test for the coercion cause it gets tested implicitly in Writable and Mutable. Closes #405.

Coverage decreased (-0.08%) to 92.151% when pulling eff8df017821764b123078759b1277c76e98d8fa on doriantaylor:changeset-ex-mutable into 171e2ccea6b3c2a1a918fb280ac70500101e29e0 on ruby-rdf:develop.

Coverage decreased (-0.08%) to 92.151% when pulling eff8df017821764b123078759b1277c76e98d8fa on doriantaylor:changeset-ex-mutable into 171e2ccea6b3c2a1a918fb280ac70500101e29e0 on ruby-rdf:develop.

@doriantaylor please consider adding yourself to CREDITS, and if you think you may be more active in this, or other Ruby RDF repos, I can add you to an appropriate team.

Thanks; I actually started using Ruby as my daily driver to use this framework more, as it seems to be the best one of the popular general-purpose interpreted languages. I do intend to come up with a more permanent solution for Changeset, but this patch should be okay for now.


NY Times County Data For All US

Possible source?
https://www.nytimes.com/interactive/2020/us/coronavirus-us-cases.html#g-cases-by-county

Interesting @jocooper43016, I wonder if they're going to keep it up to date, and if they're sharing their data.

We now have this!


Add a cmake test target

This PR adds a separate build target using CMake with Verilator in UHDM flow. It is needed to run the tests on macOS in CI.

Updated the README to describe the new flow and special test cases.


[CMT-973-1346] translate(newsletter): YN61 - HI

hindi translation

@Urs4Maj0r could you take a look here for Translation check? There seems to be a lot of machine translate, I fixed some translated product or project names (Discord, Telegram,...), and there are names too (RestlessMik3,...).
Needs review. thanks


Nonexistent OMW offsets

In a few cases, the Open Multilingual Wordnet refers to synset offsets, which do not actually exist in WordNet. This issue has been known for some time (https://github.com/omwn/omw-data/issues/24#issuecomment-974789720), and it is not clear whether and when the OMW data will be fixed.
But from the point of view of NLTK, the issue is not harmless,
because it leads to fatal errors:
from nltk.corpus import wordnet as wn

print(wn.synsets('osim', lang='hrv'))

File "nltk/corpus/reader/wordnet.py", line 1539, in synset_from_pos_and_offset
    f"No WordNet synset found for pos={pos} at offset={offset}."
nltk.corpus.reader.wordnet.WordNetError: No WordNet synset found for pos=a at offset=2002046.

This behaviour is unfortunate, because the Croatian word 'osim' is linked to two synset offsets, where only one is nonexistent, so it would be preferrable to return at least the good synset, instead of aborting the whole processing pipeline.
It doesn't help much to wrap the call in a try-except construct
because, although a batch would be allowed to continue,
the user would still miss the good 'osim' offset.

I think these are mostly bugs in the OMW data that should be fixed. But I also want to live in a world where the non-English wordnets can grow beyond the Princeton WordNet. So, ideally, both changes would happen: fixing the OMW data, and change the code to support synsets not in PWN.

Thanks @goodmami: it is great to hear that you support fixing the OMW data.
The NLTK library already allows English concepts that were not in Princeton WordNet. For example, the new wordnet2021 package introduces additional English synsets at the end of the new 'data.noun', like 'ruled surface', 'light fitting' and 'chick sexer', which did not have a synset offset in PWN.
The problem is that the NLTK code does not yet allow OMW synsets that do not have an English counterpart, whatever the provenance of the English data. This restriction will certainly need to be lifted when OMW starts to include synsets that don't have an English translation.


[insiders] Activating extension 'vscode.search-result' failed

When using Insiders today and running the mock-debug extension in the extension host, I see this message pop up (I do not see it in the main Insiders window, only when running the Mock Debug extension in the extension host):

Activating extension 'vscode.search-result' failed: Cannot find module '/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/search-result/out/extension.js' Require stack: - /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js - /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/bootstrap-amd.js - /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/bootstrap-fork.js.
onDidNotificationChange @ /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:

@DanTup I cannot reproduce but most likely because I don't really understand the steps I have to do...
What I did:

in a VS Code insiders window I opened the latest version of vscode-mock-debug
pressed F5
in the resulting Window i opened a simple mock test project with a readme.md file and a launch.json
pressed F5

Observe: mock debugging readme.md worked fine; no search-result message popping up
Are these the correct steps?

@weinand sorry, I should've been more specific. I don't think this is related to MockDebug, I just happened to be using it.
Here's exactly what I'm doing

Open VS Code Insiders
Open a clean clone of mock-debug
Press F5 to launch the extension host with mock-debug running in it
The error appears

It literally appears at startup of the extension host without me doing anything.
I don't know if it's related (since I don't think I saw it yesterday), but as well as this error appearing in the extension host, back in the main VS Code window (where I have the mock-debug source open) I see this error appear too:

And this is the Chrome dev tools console for the main instance:

I don't think that this happens in recent builds.


make  test silent

can't be closed if not merged :-) please reopen

I figured I was making useless changes so I closed this PR and made config modification on the other PR ( #132 ). Is that fine?


[charts/redis-ha] Pull S3 credentials from k8s secret

Use existingSecret for AWS or SSH keys

Signed-off-by: Justin StGermain<EMAIL_ADDRESS>What this PR does / why we need it:

Adds the ability to use the existingSecret for AWS S3 credentials or SSH key

Which issue this PR fixes

fixes #65

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@j771 Can you rebase this? Somehow this completely slipped under my radar...

@j771 Can you rebase this? Somehow this completely slipped under my radar...

This is so old, I will do another PR. Tell me what version you want me to set the chart to and I will do an updated PR.

Closing this PR in favor of: https://github.com/DandyDeveloper/charts/pull/139

@j771 Can you rebase this? Somehow this completely slipped under my radar...

@DandyDeveloper
I created this: https://github.com/DandyDeveloper/charts/pull/139
I also just created this: https://github.com/DandyDeveloper/charts/pull/141


«Get started» button on webpage doesn’t work

The problem
Clicking the button «Get started» on the landing pge does nothing. Tested on latest iOS Safari.
How to reproduce

Go to landing page.
Try to click the «Get started» button.

Expected behavior
Clicking the button should take me to the get started page.
Actual behavior
Nothing happens. Button does not respond.
Environment
Latest iOS Safari at the time of writing.
Ask if more info is needed.

Thanks for reporting! Fixed :)


Resolving JSHint, again

Without touching images this time

Why are you changing Ankouru?
アンコール = Ankōru, ō = oo/ou, Ankōru = Ankouru.

 Looks good.


OP-2012: Check for equivocators in nctl scenarios

Adds function to nctl common which checks logs for equivocators.
Called in tests where equivocators are not expected (some tests have checks already specific to them).
https://casperlabs.atlassian.net/browse/OP-2012
spawned from discussion on: https://casperlabs.atlassian.net/browse/NDRS-1190

bors r+


Resolves GravityGeneratorVisualizer is Obsolete

About the PR

Splits the GravityGeneratorVisualizer into a component/system pair.
TODO:

[ ] Testing

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Just use the gravitygeneratorcomponent

Do you want me to make a client version of SharedGravityGeneratorComponent or move the sprite map to shared (and therefor the server)?

The status should be on shared; using a separate comp state for it would also potentially mean removing appearancecomponent.

@DrSmugleaf
Pushing commits isn't reopening the PR. Please reopen it at your convenience.