SKE Project resource creation

Hey TF Team,
i noticed a not expected behavior on the SKE project resource as it is:
even if the project exists, the resource accepts it as created by itself, so deletes it by destroy via this state even though it existed before......so any cluster in this project will going to be destroyed.
I'd expect a error message such as "already exists" and to have then a data-source in place.
Or maybe i'm wrong, i'd transparently leave the whole SKE project stuff out....there's no value in it.

The issue of project creation is a bit tricky
It was previously part of the project resource before moving to its own standalone resource, which created some issues
and the behavior currently isn't very terraform like, i agree.
for the destroy part - if it detects that there are clusters outside of what terraform is managing, it won't actually delete the project but return a warning - also, not very terraform like, but i wanted to avoid a case where manually created clusters are deleted because the project was disabled.
that being said
it's been a long while since the first versions of the provider, so it may be high to change the behavior as you said.

For the time being, i've removed the deletion code from the *_project resources
in later versions, i'll review if the extra _project resources can be removed altogether


Testing on a different dataset

Hello,
Could you please tell me how I can test the model's weights on a different dataset than the one you used?
Thank you

Hi @DoaaAburayya ,
Sorry for this late reply.
Given an image of shape (1, C, H, W), our CLIP-EBC implementation directly produces a density map of shape (1, 1, H // r, W // r) in the eval mode, where r is the model-related reduction factor. If you need to get the total predicted count, you may simply sum up the values of the density map. If you need the density map for visualization purposes, you may have to resize it to the spatial size of the input image.
Many thanks,
Yiming


Add the Apple logo to the website footer only if device that the website is visited on shows it correctly.

I will just replace it with apple emoji (🍎) until I will be smarter and find a way how to do it properly.


Board design

Some changes were made in the board that led to changes in the game too.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

129 of 129 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
461

Relevant Lines:
461

💛  - Coveralls


Add className property to SwipeableListProps for grid alignment needs

I added className property to SwipeableListProps in order to make it adaptable to grid systems. I use the library with tailwind and I found out that SwipeableList needs to have className property in order to behave like a "col".
The className property was already taken into consideration in the code, it just was not declared in SwipeableListProps which resulted in an error since I'm using typescript.
Kindly accept the PR.
Best regards.

@all-contributors please add @elmesaoudee for code
@elmesaoudee Thank you!

@elmesaoudee New version 1.7.1 released :)

Awesome! Thanks guys :)


Add Model Count + Model Observations metrics to scheduler

Adds two metrics that are always included in the PrometheusScheduler:

trustyai_model_count: the number of models registered with TrustyAI
trustyai_model_observations: the number of observations, by model

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Pull Request title is properly formatted: FAI-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.3.x] FAI-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

/test trustyai-explainability-e2e


Build: Update deps and debug test failure

Summary
This adds some logging if a task fails during introspection tests failure
It also updates deps to pull in the newest zest
Testing steps
tests pass
Checklist

[x] Tested with snapshotting feature disabled and pulp server URL not configured if appropriate

lgtm!


debug read_submissions

"Error: Sheet 'NA' not found" when run as-is with more recent data since file format has changed
I suspect it's an issue with the larger number of tabs than the function expects on line 91 but will need to investigate more

read_submissions() works now, it was tripped up by the change in the format of the column names and the location of the Total row. I have moved on to debugging calculate_net_new() , still have not generated a report yet.


Added TaskMetricsEmitted periodic controller job

This job runs every 5 mins by default and emits metrics about Minion tasks
scheduled in Pinot. For now, the following metrics are emitted for each
task type:

Number of running tasks
Number of running sub-tasks
Number of waiting sub-taks (unassigned to a minion as yet)
Number of error sub-tasks (completed with an error/exception)
Percent of sub-tasks in error
Percent of sub-tasks in waiting or running states.

Description

Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

How about splitting the task related metrics based on the task type?

They are already split based on task type

@jackjlli  can u please take another look? I have addressed all comments and also rebased the code so there are no conflicts.

Codecov Report

Merging #7091 (fb2e3de) into master (ac8f098) will decrease coverage by 31.92%.
The diff coverage is 47.31%.

@@              Coverage Diff              @@
##             master    #7091       +/-   ##
=============================================
- Coverage     73.49%   41.56%   -31.93%
+ Complexity       91        7       -84
=============================================
  Files          1492     1493        +1
  Lines         73422    73511       +89
  Branches      10574    10587       +13
=============================================
- Hits          53960    30557    -23403
- Misses        15927    40365    +24438
+ Partials       3535     2589      -946

Flag
Coverage Δ

integration
41.56% <47.31%> (+0.05%)
:arrow_up:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/apache/pinot/controller/ControllerConf.java
44.64% <0.00%> (-8.54%)
:arrow_down:

...ntroller/helix/core/minion/TaskMetricsEmitter.java
0.00% <0.00%> (ø)

...lix/core/minion/PinotHelixTaskResourceManager.java
79.41% <74.00%> (-3.55%)
:arrow_down:

...g/apache/pinot/common/metrics/ControllerGauge.java
97.22% <100.00%> (+0.55%)
:arrow_up:

...controller/helix/core/minion/PinotTaskManager.java
27.77% <100.00%> (-0.27%)
:arrow_down:

...c/main/java/org/apache/pinot/common/tier/Tier.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/spi/utils/BigDecimalUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/common/tier/TierFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/spi/config/table/TableType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 940 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8f098...fb2e3de. Read the comment docs.


Eliminate inappropriate public exposure of emails

Audit site for cases where email addresses are exposed publicly and resolve them.

email addresses should not be publicly displayed on profile
a messaging system should be used to send messages to other hydroshare users
a user should have the ability to set in their profile that messages they receive in hydroshare get forwarded to one of their registered email addresses.
email addresses are part of the resourcemetadata.xml file downloadable when resources are downloaded for resource creators and contributors.  I submit that this not be changed.  This is equivalent to an email address appearing with the downloadable copy of a published paper, which is a common and accepted practice.

@dtarb I believe this issue has been resolved. Can you verify and see whether there are still issues with email exposure or not?

Points 1 and 4 are OK.  Points 2 and 3 have still not been done.  I am OK to leave this on the backburner for now as we have higher priorities.

#1362 addresses messaging better and should be used for that thread


pkg/datapath: add base64 encoded json configuration to config header file

Fixes #8423

This change is

Coverage increased (+0.008%) to 44.318% when pulling 0b3c211c23e9764822684567a86e781a3c2c20c3 on fristonio:fristonio/bpf-config-cli-json into fc142ccfec93e90c7fe92f75bc8fe6f883ea85d7 on cilium:master.

test-me-please

The tests are failing due to failing master because of the changes made while removing EnableLegacyServices option. WIll wait for the fix in master.

@fristonio it's already fixed in master.

There @aanm, rebased with master.

test-me-please


Chore: Rename Handful of Component Folders for Consistancy

Renames the button, background-shape, brightcove-player, video player, and page-footer component folder names to match the convention used for everything else in Bolt.
CC @remydenton @EvanLovely

@remydenton you see the new Travis build status + Netlify preview link in the PR ^ via @bolt-bot?!! :D

Pretty slick @sghoweri!


Fixed permission check for hidden and internal items.

@emanuelschuetze Please have a look at the 16 12 different cases:

agenda can see
agenda can see and can see internal
agenda can see and can manage
angedan can see and can see internal and can manage

for different agenda items

normal
internal
hidden
internal AND hidden

In some cases you see all, in other you see everything but comments, in other cases you see only some list of speakers fields, in other cases you see nothing.

Works good but one case is a bit strange...

My setup:  Admin user A + Delegate user B (with agenda.can_see but without can_see_internal)
test 1: Create a topic item and set the correspoding agenda item to 'public' => B can see it (OK)
REST show the full object:{
    "weight": 10000,
    "item_number": "",
    "title": "TOP 1",
    "is_internal": false,
    "speaker_list_closed": false,
    "is_hidden": false,
    "duration": 0,
    "speakers": [],
    "content_object": {
        "collection": "topics/topic",
        "id": 1
    },
    "parent_id": null,
    "type": 1,
    "title_with_type": "TOP 1",
    "closed": false,
    "id": 7
}

test 2:Set the agenda item to 'hidden' => B cannot see it (OK)
REST object is empty.
test 3:Set the agenda item to 'internal' => B can see the interal item in the agenda (FAILURE)
REST object shows a 'restricted' object: {
     "title": "TOP 1",
     "speaker_list_closed": false,
     "content_object": {
         "collection": "topics/topic",
         "id": 1
     },
     "speakers": [],
     "id": 7
 }

=> Test 3 seems wrong! Expected: agenda item should be hidden in 'internal' state. REST object should be empty.
@normanjaeckel Please check again.

The third case is intended. Please see https://github.com/OpenSlides/OpenSlides/blob/master/openslides/agenda/access_permissions.py#L56
See also #3003 and #3035

Ok.


Support Auto-Discovery

This will make the package work with auto-discovery in Laravel 5.5

Hmm some people are still on old 5.4.
Question is would it warrant creating a new separate development package for 5.5?

@bramburn Thinks will continue working as they were for 5.4 users.

We don't actually support Laravel 5.5 yet. I'll take a look at this again when/if I decide to continue the maintenance of this package into Laravel 5.5. The same applies to all my packages. :)

I will add this once 5.5 has been released.


testing current

just testing...

@lamont-granquist  nice, wanting this merged if working or just checking for future support?

validating its still broken


add ability to add another pan gesture recognizer

The idea of additional pan gesture recognizer is ability to pan on the other view to control the switch. i.e. if Switch is the navigation bar, this pull request allows to pan on the main view to switch between the too :)

I am not sure whether this solution is good. You are setting selector in the DGRunkeeperSwitch. I would say that we have to just give UIPanGestureRecognizer to the DGRunkeeperSwitch and the only thing switch has to do, is set the delegate to itself. Thoughts?


Fix separator for returned values from HIBPv2 api

Fixes #772

Actually I'm pretty sure that this implementation used to work properly.
But thanks a lot for fixing!


uncomment columns related to GoQuorum privacy

Addresses database backwards compatibility broken by https://github.com/hyperledger/besu/commit/067a26337411833ad92d649f208255b1a7954268
Fixes org.rocksdb.RocksDBException: Column families not opened: error

Testing

create main/data by starting besu built with main 080fe87c816ca3b4e1ba55eb7306d3ef323b75af
create 42f52e72be25e75704d5116646369ae09860bb4a/data by starting besu built with last good commit 42f52e72be25e75704d5116646369ae09860bb4a
start besu-main with --data-path="42f52e72be25e75704d5116646369ae09860bb4a/data" - get column families not opened error (reproducing reported issue)
create bring-back-column-fam/data by starting besu built with 402a0047001b7417db5dd5e0ad0dd04d36be55c3
start besu-42f52e72be25e75704d5116646369ae09860bb4a with --data-path="bring-back-column-fam/data" - successful startup (new code works with new db)
start besu-bring-back-column-fam with --data-path="42f52e72be25e75704d5116646369ae09860bb4a/data" - successful startup
start besu-bring-back-column-fam with --data-path="080fe87c816ca3b4e1ba55eb7306d3ef323b75af/data" - successful startup

Is it worth trying in a later PR something to drop/destroy these column families? Instead of just keep them for backwards compatibility?

Maybe! I am not a database expert (clearly) so not sure of the pros and cons of this


Appstudio update test-component-pac-wtnm

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-wtnm-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
34 seconds
build-container

✅ Succeeded
11 seconds
sanity-inspect-image

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
9 seconds
sanity-optional-label-check

✅ Succeeded
9 seconds
sanity-label-check

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-wtnm-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
34 seconds
build-container

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
11 seconds
sanity-inspect-image

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
9 seconds
sanity-optional-label-check

✅ Succeeded
9 seconds
sanity-label-check

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-wtnm-on-pull-request has successfully validated your commit.


Command Prompt Color is reset when zooming

Windows-Terminal Version: 1.19.1942.0
Description: If you change the color of the prompt with "color a" and then zoom with CTRL + mouse wheel, the color resets itself to the standard value.
Steps to reproduce:

Open Windows Terminal with cmd.exe configuration.
Type "color a".
Zoom with CTRL + mouse wheel.
Type something, the typed text not in the set color but in the standard color.

If you change the background with "color fc" and then zoom in, the problem also occurs.

Thanks for the report! This is actually already being tracked by another issue on our repo - please refer to #32 for more discussion.
/dup #32


problems with StatusBar and SYSTEM_UI_FLAG_IMMERSIVE_STICKY

I have configured the Inmmersive as follows:
package com.myapp;

import com.facebook.react.ReactActivity;
import android.os.Bundle;
import android.view.View;

public class MainActivity extends ReactActivity {

  /**
   * Returns the name of the main component registered from JavaScript. This is used to schedule
   * rendering of the component.
   */
  @Override
  protected String getMainComponentName() {
    return "MyApp";
  }
  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    hideNavigationBar();
  }

  @Override
  public void onWindowFocusChanged(boolean hasFocus) {
    super.onWindowFocusChanged(hasFocus);
    if (hasFocus) {
      hideNavigationBar();
    }
  }

  private void hideNavigationBar() {
    getWindow().getDecorView()
        .setSystemUiVisibility(View.SYSTEM_UI_FLAG_HIDE_NAVIGATION | View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY);
  }
}

When I start the App the interface works fine, it hides the lower android buttons, but! if I configure the colors of the Status bar, either from the App.js or the browser container
App.js
......
import { StatusBar } from 'react-native';
StatusBar.setBackgroundColor("#ffffff") // BackGround White!
StatusBar.setBarStyle("dark-content")  // Color Text in Black
StatusBar.setTranslucent(false)
......

or by Navigation Config..

const BaseAppStack = createStackNavigator();
export function BaseAppStackScreen(props) {
  return (
    <NavigationContainer  >
      <StatusBar barStyle="dark-content" backgroundColor="#ffffff" translucent={false} />
      <BaseAppStack.Navigator headerMode="none" initialRouteName="BaseTabs">
        <BaseAppStack.Screen
          name="BaseTabs"
          component={BaseTabs}
          options={{ headerShown: false, ...TransitionPresets.SlideFromRightIOS }}
        />
      ........
      </BaseAppStack.Navigator>
    </NavigationContainer>
  );
}

When I turn off the screen with the app open, or lower the notification bar, or minimize the application and open again, or run a modal, and then I do some of those things and then the app is shown again (focus), the Status bar puts the font color in white, so it resets StatusBar! to the default colors text (White), after that problem happens, the StatusBar remains in white background color (my configuration) and the White Text color (default), I have to close the app and open it again
"react-native": "0.61.5"

I also have experienced this on Android, RN 0.63.1

When I turn off the screen with the app open, or lower the notification bar, or minimize the application and open again, my header height is changing

I'm also hitting a similar issue...
I have a bridge module for hiding the Status Bar and Bottom Navigation bar on Android. Hiding works great but when showing the status bar and navigation bar again, it appears like the status bar remains hidden...
The issue is that the StatusBar text color is getting set to white on a white background (whereas before hiding the StatusBar the text color was set to black).
My workaround is to configure the StatusBar again as soon as I exit immersive mode...
// Hide StatusBar and bottom navigation controls (i.e. go immersive)
SomeBridgeModule.hideStatusAndNavBar();

// Show StatusBar and bottom navigation controls (i.e. exit immersive)
SomeBridgeModule.showStatusAndNavBar();
StatusBar.setBackgroundColor('white');
StatusBar.setBarStyle('dark-content');

@mrbrentkelly As a curiosity, does your bridge module that hides the bottom navigation bar works in a modal? Thanks

Yes (I think 😄 ). You could try and see. Here's my library https://github.com/hudl/react-native-system-bars#react-native-android-system-bars

@mrbrentkelly Thanks :) It kind of works with modals, something like 2 out 3 times, so there must be a race condition in RN code somewhere (around there #21078)
Might also be related to the problems in this issue


fix: Refactor preloads to fix an issue with CDN on EE

Description
Our preloads were not using CDN, this PR fixes it. More details in the linked issue.
PR fixes following issue(s)
Fixes #28359
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[x] Manual

Should verify CDN once deployed on release.
Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview skip-tests=true


Fix cd destination and language of code blocks

Pull Request Template
Description
Fixed the following issues
Fixes keploy/keploy#1274, Fixes keploy/keploy#1275
Type of change
How Has This Been Tested?
I checked the documentation generated by yarn start locally.
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.
[ ] I have added corresponding tests.
[x] Any dependent changes have been merged and published in downstream modules.

LGTM

Thanks for the contribution! 🙏


'//@ sourceURL' and '//@ sourceMappingURL' are deprecated, please use //# sourceURL= //# sourceMappingURL

Am I the only one seeing this in chrome canary 51?
'//@ sourceURL' and '//@ sourceMappingURL' are deprecated, please use '//# sourceURL=' and '//# sourceMappingURL=' instead.

https://developers.google.com/web/updates/2013/06/sourceMappingURL-and-sourceURL-syntax-changed

ah I see it's a dupe of https://github.com/webpack/webpack/issues/91

In which technology you have developed this application.If MVC then don't allow to render by default js file like site.js.


Nuance.xyz showcase.json tags update

Nuance.xyz showcase.json tags update.
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

[ ] Follows the developer docs style guide.
[ ] Follows the best practices and guidelines.
[ ] New documentation pages include document tags.
[ ] New documentation pages include SEO keywords.
[ ] New documents are in the .mdx file format to support the previous two components.
[ ] New documents are registered in /sidebars.js, otherwise, it will not appear in the
side navigation bar.
[ ] Make sure that the .github/CODEOWNERS file is
filled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.

Dear @mertsahin89,
In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.
If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.
— The DFINITY Foundation


Add creation date to follow and shout relation

We need to add a date to the shout and follow relationships to also maybe able to sort them.

@appinteractive why?


SQLite Crash on Coverage 5.0a2 inside Hypothesis

I was running some unit tests using hypothesis (link) which relies on coverage, and I ran into a crash. Specifically, I received the following error message:
coverage.misc.CoverageException: Couldn't use data file '/Users/me/my_project/.coverage': UNIQUE constraint failed: file.path
I have experienced this issue both on macOS and Linux while running python 3.6, and the issue does not persist with COVERAGE_STORAGE=json.
I have included a gist below which contains files to reproduce the error. Specifically, the error occurs when the hypothesis assume statement in test.py fails more than half the time and when wrap is called.
To reproduce the error, run the build.sh script, which will initialize a virtualenv, install required modules, and run a short example which should throw the error.
Additionally, I am including a vagrantfile which will run build.shin a VM, thus providing a clean slate for testing.
https://gist.github.com/TylerADavis/393ee6382b4f645774100ae0c490c5ba
Please let me know if there is any other information I could provide that would be useful.

Thanks, this reproduces well, even without Vagrant in the mix.

It looks like Hypothesis is creating a number of CoverageData objects, each of which is trying to write to the .coverage file.  @DRMacIver thoughts?

It looks like Hypothesis is creating a number of CoverageData objects, each of which is trying to write to the .coverage file. @DRMacIver thoughts?

Hmm. I thought the way Hypothesis was using those CoverageData objects they weren't trying to write to the file at all. I don't know whether my belief there was wrong or whether this has changed as part of the new version of Coverage.
I'm currently arguing that we should pull the Coverage support in Hypothesis anyway (https://github.com/HypothesisWorks/hypothesis/issues/1551). This is not due to problems with coverage-the-library, I just don't think coverage information in general has proven useful in the sort of testing we can feasibly do in normal runs. My recommended workaround is to put use_coverage=False in your Hypothesis settings.

https://github.com/HypothesisWorks/hypothesis/pull/1564 will fix this.

@DRMacIver Coverage.py 5.0 uses SQLite as the data storage, instead of a JSON-like file.  So the file is created well before any save() call. This perfectly explains the problem.  I'm wondering whether to retain a memory-only data scenario also?

Or at least, avoid creating the file until save()....

In the immediate future, the Hypothesis side of this is going away, so do what you like. :-) In the medium to long-term, I would definitely need to be able to to have in memory only coverage data if I were to keep using coverage in the kind of ways that I want to for coverage-guided testing purposes.
I'm a little confused about how creating the file without saving it causes this error though. It seems like data must be be written to it in order to violate a unique constraint?

The current SQLite support writes to the .coverage file before save() is called, as data is added to the CoverageData object.  That shouldn't be hard to change though.

I am also seeing a reproducible crash when testing feed2exec in python 3.6 and 3.7 with pytest-cov 2.6, which i do not get in python 3.5:
INTERNALERROR> coverage.misc.CoverageException: Couldn't use data file '/home/anarcat/src/feed2exec/.coverage': UNIQUE constraint failed: file.path

i wonder if this could be something with changes in the sqlite3 standard library? or is this really just a bug in 5.0 alpha?
i first thought this was #716 which similarly stumbles upon the new sqlite storage...
thanks!

@anarcat That is a separate problem: you need to be sure to use [run] parallel = True if your tests run simultaneously: https://github.com/nedbat/coveragepy/issues/716#issuecomment-429491441

i confirm setting parallel = True fixes this magically. it seems weird i need to tweak this - i don't remember enabling parallel builds - but at least it works, thanks! :)

@anarcat It seems like this is going to happen more and more.  Can you help me out?  How are you running your tests?  What can I tell people to look out for?

I have no idea. :) The source for my project is here. Tests are ran by gitlab CI or locally (it doesn't matter) with this tox.ini file, which in turn calls setuptools (or distutils or whatever it's called) with the pytest-runner plugin. The setup.py test alias is defined in setup.cfg and then pytest magically finds the tests in feed2exec/tests. There's a minor betamax config in conftest.py but it should matter here. I have more test docs if you want as well..

I've bisected this to d2f77ab2ffc308e616af0207546ee1bef1cb8c75.
The problem appears to be that the file_map is only read when opening the DB, but another subprocess might have added the file later when the ID is needed.
https://github.com/nedbat/coveragepy/pull/723 fixes this for me.

For the "UNIQUE constraint failed: file.path" problem, I would like people to use parallel=True.  Or should I make that happen all the time anyway?  I don't think I trust SQLite's concurrency enough to have multiple processes accessing the same database.

I would rather not use "isolation_level = immediate" because in the future, writes to the database may not be idempotent (for example, counting line executions, rather than just true/false per line).


[wip] Allow overriding target platform when cross-compiling

Supersedes https://github.com/prebuild/prebuildify/pull/20

A first stab at documenting this:

Option
Input
Subprocess env
node-gyp args

target arch
opts.arch or ARCH or os.arch()
ARCH, PREBUILD_ARCH
--target_arch

target platform
opts.platform or TARGET_PLATFORM or os.platform()
PREBUILD_PLATFORM
-

enable strip
opts.strip or false
n/a
n/a

strip bin
STRIP or 'strip'
-
n/a

strip args
os.platform() == 'darwin' ? '-Sx' : '--strip-all'
n/a
n/a

node gyp bin
PREBUILD_NODE_GYP or 'node-gyp(.cmd)'
-
n/a

shell
os.platform() == 'android' ? 'sh' : undefined
-
n/a

There's no easy (non-breaking) way to clean this up, but now would be the time. Knowing that:

We cannot use PLATFORM for Windows-compat reasons
It may be useful to have a normalized env for subprocesses (like pre/post hooks).
There seems to be consensus that a TARGET_ prefix makes names more intuitive
But we don't "own" TARGET_. To prevent further conflicts PREBUILD_ makes sense.
That way we can confidently add more env variables, both as input and output.

I propose (changes bold) (I'm not sure what to do with strip args):

Option
Input
Subprocess env
node-gyp args

target arch
opts.arch or PREBUILD_ARCH or os.arch()
~ARCH,~ PREBUILD_ARCH
--target_arch

target platform
opts.platform or PREBUILD_PLATFORM or os.platform()
PREBUILD_PLATFORM
-

enable strip
opts.strip or PREBUILD_ENABLE_STRIP or false
PREBUILD_ENABLE_STRIP
n/a

strip bin
opts['strip-bin'] or PREBUILD_STRIP_BIN or 'strip'
PREBUILD_STRIP_BIN
n/a

strip args
os.platform() == 'darwin' ? '-Sx' : '--strip-all'
n/a
n/a

node gyp bin
opts['node-gyp'] or PREBUILD_NODE_GYP or 'node-gyp(.cmd)'
PREBUILD_NODE_GYP
n/a

shell
opts.shell or PREBUILD_SHELL or os.platform() == 'android' ? 'sh' : undefined
PREBUILD_SHELL
n/a

@vweevers looks really good and I agree with your prefix. For simplicity/completeness I would name strip simply PREBUILD_STRIP with same semantics as above. Then there is no special case for that one

Do we support setting strip args from the outside?

For simplicity/completeness I would name strip simply PREBUILD_STRIP

Table updated.

Do we support setting strip args from the outside?

We could start with process.env.PREBUILD_STRIP_ARGS.split(' ') which would be sufficient until someone needs exotic arguments like --foo "arg with spaces" - if that is even a thing. For comparison, in prebuild we don't support custom args either. Let's leave it out for now?

I'll open a new PR (but please keep this override-platform branch, leveldown master depends on it atm).


[BugFix] record cte expressionMapping all the time

Why I'm doing:
view1 with lots of cte1_1, cte1_2, ..., cte1_n.
view2 with a cte2_1 ref view1.
select * from view1 t1, view1 t2, view2 may fail in transform phase.

What I'm doing:
The root cause:

when anaylze view each time, it generate a new ast object from string definition. So the cteRelation in view1 t1, view1 t2 is different object with different  mouldId.
when transforming the cte2_1, it will register cte1_i in the cteContext. When fininshed, the cteContext in outer only register cte2_1 becuase we only copy the cteExpressions:

public CTETransformerContext(CTETransformerContext other) {
        // This must be a copy of the context, because the new Relation may contain cte with the same name,
        // and the internal cte with the same name will overwrite the original mapping
        this.cteExpressions = Maps.newHashMap(other.cteExpressions);
        // must use one instance
        this.cteRefIdMapping = other.cteRefIdMapping;
        this.uniqueId = other.uniqueId;
        this.cteMaxLimit = other.cteMaxLimit;
    }

then we transform query statement in the view2, which transforming cte2_1 and its ref view1 again.  This time it may skip put the mapping in cteExpressions beacuse  cteContext.isForceInline return true. When transform the cte1_i , we may found nothing in cteExpressions.
Pair<OptExprBuilder, OptExprBuilder> buildCTEAnchorAndProducer(QueryRelation node) {
        OptExprBuilder root = null;
        OptExprBuilder anchorOptBuilder = null;
        for (CTERelation cteRelation : node.getCteRelations()) {
            if (cteRelation.getRefs() <= 1 || cteContext.isForceInline()) {
                continue;
            }
       ...
}

The same cte in different useage scope with a different realtion id is used for analyzing phase. We don't need record its useage scope in transforming scope.
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.2 branch-3.1


Plan for other platforms?

Hi! Syncing clipboard across devices is a very much needed feature for people working on multiple devices. Thank you for working on such a great idea!
By the way, do you have plan to make it cross platform? Currently it looks kinda weird on macOS.

Thanks!

Thank you.
Yeah, I sure want to support other platforms, I just didn't have a need so far.
It should not be too difficult to make it work on macOS. I'll keep this issue posted if I have news.

A bit of news:

https://github.com/felipecrs/clipboard-sync/pull/41

This is a step towards cross platform

Other things I believe will be necessary:

Ensure fswin is only imported and called in Windows platform
Fix the icon for macOS as it should not be .ico there

Just commenting to agree with Colinleefish. I am very keen to have a cross-platform clipboard sync as it is currently such a pain syncing between mac and windows.
Thanks!

Support for macOS at this point is only a matter of fixing the tray icon.
Looks like it requires a special Template.png: https://www.electronjs.org/docs/latest/api/tray#:~:text=)%0A%7D)-,MacOS,-Icons%20passed%20to
I just didn't add support yet because I don't have a macOS environment to test, but I can try making the changes and asking someone to test.

@colinleefish @Perchycs v0.12.0 adds support for macOS. Please give it a try. :D


Special characters support

I tried using this amazing tool and figured it doesn't read my password.
The password I'm using for my user is %yaron11 and for some reason I get the following message (using web or cli):
Error: parse postgres://autheticated:%yaron11@localhost:5432/customerrecords?sslmode=disable: invalid URL escape "%ya"

Ah, i think someone mentioned about this before. Will fix.

Fixed in latest release. However, you should be using proper escaping for the full uri's

Confirmed, I must say I'm impressed, blazing fast and very easy to use, thank you for the wonderful tool!


PP-9784 Add cancel agreement endpoint

Add cancel agreement endpoint at /v1/agreements/AGREEMENT_ID/cancel that takes an empty POST body and, if successful, returns a 204.
with @sfount

Functionality depends on https://github.com/alphagov/pay-connector/pull/3901

Review review:

The exception mapper should be registered with the public api app
The cancel response should explicitly check for 204 from connector


Update to Linebender CI configuration

This is a draft to see what fails other than typos, copyright, clippy.

@xStrom @DJMcNab Let's do this!

When you're ready to land this, let me know and I'll do the repository setup beforehand.

When you're ready to land this, let me know and I'll do the repository setup beforehand.

Ping me on Zulip anytime after 45 minutes from now.


Brazilian local government open data portals

I manage a list of Brazilian local government (state and municipal) open data portals:
https://github.com/augusto-herrmann/transparencia-dados-abertos-brasil/blob/main/data/valid/brazilian-transparency-and-open-data-portals.csv
it could be useful as a data source.

Hi @augusto-herrmann, It's a great list! Thanks a lot, I will schedule to add it to the registry ASAP.


Automation Scripts for Passwordless SSH for Non Root Users Validation

Automation Scripts for Passwordless SSH for Non Root Users Validation

PR has been merged.


Nested artboard button not working at runtime

Description
I have a nested artboard button using events, inputs, and listeners. It works in the editor but it doesn't work with React Native on Android.
Provide a Repro
See the attached riv and rev.
Expected behavior
I have a nested artboard button that works in the editor but not in runtime (react native). The button works with listeners, inputs, and events. See the attached file. Open the artboard called “Button issue” and try to click any of the buttons. You will see that the buttons on the left remain pressed down if you click-press-hold. The other buttons are radio buttons (only one at a time can be pressed). Now try this on react native on Android and you will see that none of the buttons work.
nested_bug.zip

Hi @BitBarrel, are you using the latest version of the Rive React Native runtime? And is this working on iOS but not on Android?
Something that you should also ensure is passing the correct State Machine Name as a property (to ensure the correct state machine is playing).
If you're still seeing an issue then please note that it may just require using the latest version of Rive Android. The React Native runtime is a little behind our latest Android + iOS runtimes. We're resolving a few issues here to update to the latest. Once that is done, this should be fixed.

Let me check with my software engineer and get back to you.

HayesGordon
The buttons 1234 on WebJS also don't work:
https://codesandbox.io/p/sandbox/rive-quick-start-js-forked-j5znq2?file=%2Fsrc%2Findex.mjs
Does this mean it is not a react native problem but instead it is a bug in The Rive logic which is platform-wide?

We are using the latest version of the Rive react runtime. The problem exists both on IOS and Android (and Web JS).
Getting the Android only version to work without React Native is going to be a bit hacky so we will wait for an update which hopefully will fix the issue.


Wasm :remove wasm from CI

It's failing so for now, just remove.  Will enable again in #8224

There's a fix now so closing


better support for contenteditables in iframes (ckeditor, tinymce, etc)

Sorry for the extremely long delay in submitting this PR, I've had this fix on a forked copy for a while, but just recently had the time to update our version, and decided to re-submit the fix as an official PR.
This should result in no changes in behavior, but will now support textcomplete when used by contenteditables in an iframe.  This is popular with plugins such as tinymce and ckeditor.  We currently use this fix with tinymce and it works well, I haven't tested ckeditor but the fix should apply there as well.
It makes the following changes:

added detection code in init to detect whether element is contained in an iframe (popular with ckeditor, tinymce, etc)
altered logic in contenteditable to use ownerDocument instead of document or window to correctly reference parent window instead of assuming it to be document
altered positioning logic for situation where autocompleter is located in an iframe
built new dist files

Hi @kjhangiani, thanks for sending the patch.
Please check my comments. And please reset dist directory. I'll update the directory when I release the next version.

Looks like I did something similar today ... anyways, thanks :-) https://github.com/yuku-t/jquery-textcomplete/pull/253/commits/9a61b19ac4e55baa84e47cc038e6adc3e41e1d7a

@yuku-t I have made those changes and reset the dist directory.
Also, while I haven't encountered this situation, I imagine a similar problem will exist if using a textarea with autocomplete in an iframe.  I think that situation is very rare, but I imagine similar ownerDocument logic will be required there as well (and possibly positioning logic too).
If I get some time this weekend I'll try and throw a test together and confirm if it has the same bug, but just thought I should mention.
Thanks for the great addon!

Thanks for your contribution!

Hi Developers, Can you please answer to this questions? #285 Thanks


Updated bug-report.yml as per v9.12.0 release

Updated bug-report.yml as per v9.12.0 release

This is a release management task, as per our policy, we are self-approving it.


Shared Fedimint-UI workspace : Part 2 / 3

In this PR:

[x] - Migrate gateway UI from gateway/ui to fedimint-ui/apps/gateway-ui
[x] - Add @fedimint/ namespace to apps and packages

Next

[ ] - Create a shared ui library in fedimint-ui/packages/

This makes the UI's unrunnable. I'd hate to trend back in that direction when we just demo'd a semi-functional thing that people can start playing with.
I have a few more coming with changes. It involves updating the dev script in guardian-ui/package.json to:

UI's are prefectly runnable but the instructions around dev were not helpful.
simplified and clarified


Storage Link Hangs on Deployment

Description
When deploying via ssh using the default ubuntu user, our deployment hangs here:
php artisan storage:link --env=production

It also hangs if I ssh into the server and release folder and run it manually.
So it is obviously a permissions error. I have manually checked permissions on the storage folder and it looks ok.
sudo getfacl storage
# file: storage
# owner: ubuntu
# group: www-data
user::rwx
group::rwx
other::r-x

The deploy.rb has the following symlinks:
append :linked_files, ".env", "storage/README.md"
append :linked_dirs, "public/upload"
append :linked_dirs, "vendor"
Server Info
SSH - user: ubuntu (Added to www-data with, "sudo usermod -a -G www-data ubuntu" )
Ubuntu 20.04.3 LTS
Laravel: 8.54
PHP/FPM: 8.2.24
Apache: 2.4.41
acl - installed
FPM - user = www-data, group = www-data
Apache - export APACHE_RUN_USER=www-data, export APACHE_RUN_GROUP=www-data
GEMS
capistrano: 3.16.0
capistrano-laravel: 1.2.3
ed25519: 1.3.0
bcrypt_pbkdf: 1.0
uri: 0.12.0

Conflict because capistrano creates a storage folder with symlinks and then storage_link was also symlinking to shared/storage folder. Resolved by clearing the task in config/deploy.rb
Rake::Task["laravel:storage_link"].clear

Conflict because capistrano creates a storage folder with symlinks and then storage_link was also symlinking to shared/storage folder. Resolved by clearing the task in config/deploy.rb
Rake::Task["laravel:storage_link"].clear


Validation for purchase information and sales informations

[x] Sales and purchase information can't disable after record transaction.

Issue fixed !


Improve bundled files

Need
As a developer
I want git to ignore all bundled files
But I don't want git to ignore index.html

Solution
Put bundled files in a separate folder and ignore that.
Make a bundle file for every bootstrap glyphicon format for better browser support.
Refactor the output config and include path: './statics' so that we can get rid of statics/.

@valentin-radulescu-hs @andrei-picus-hs Can you review?

@adela-istrate-hs Please make a PR for us to review


Update Nokogiri to v1.9.1

There's a CVE that affects the version that we are using:
CVE-2018-14404 More information
moderate severity
Vulnerable versions: < 1.8.5
Patched version: 1.8.5
A NULL pointer dereference vulnerability exists in the xpath.c:xmlXPathCompOpEval() function of libxml2 through 2.9.8 when parsing an invalid XPath expression in the XPATH_OP_AND or XPATH_OP_OR case. Applications processing untrusted XSL format inputs with the use of the libxml2 library may be vulnerable to a denial of service attack due to a crash of the application.

I can't update to the latest version available because it no longer supports Ruby 2.2.

bors r+


OutlineCLI blocks docker

Hello, I'm really appreciated to use outline-cli after .appimage version stopped working. But I've encountered this issue that routing rules of cli are blocking traffic for docker containers. Not really expert in that, but is it possible to configure somehow the cli itself or add specific ip routes to bypass vpn for docker containers? I've validated that before I was able to utilize containers (when worked with .appimage), also on windows and macos with desktop app everything is fine

@jyyi1 any ideas?

Hi @Misery7100 , I'm not sure about your issue, but here is how OutlineCLI configures the routing table, hopefully this could help you understand it better: https://github.com/Jigsaw-Code/outline-sdk/issues/138#issuecomment-1854796842


nociception is not the same as sensory perception of pain

GO term
GO:0019233 'sensory perception of pain'
Issue description
'sensory perception of pain' has_exact_synonym nociception
According this reference:

The terms nociception and pain should not be used synonymously, because each can occur without the other.[1]. Pain arising from activation of the nociceptors is called nociceptive pain.

nociception  may be a better synonym for detection of stimulus involved in sensory perception of pain

See also https://pain.ucsf.edu/understanding-pain-pain-basics/nociception-versus-pain. Thus, nociception may (or may not) lead to pain and pain may (or may not) be induced by nociception. I think the best synonymous relationship is "related".
Nociception is the "the neural process of encoding noxious stimuli" and we should have a stand-alone GO term for that.

It seems that this issue is more deeply entangled. Uberon nociceptor is logically defined as "'sensory receptor'
and ('capable of' some 'detection of mechanical stimulus involved in sensory perception of pain')". Thus I think an agreement among more people is needed to either rename "sensory perception of pain" as nociception or to create a new term nociception. But then it's unclear what "sensory perception of pain" is.
PMID:29032407 states that "Nociception is the neural process of encoding noxious stimuli, whereas pain is defined as an unpleasant sensory and emotional experience associated with actual or potential tissue damage, or described in terms of such damage".
IASP https://www.iasp-pain.org/resources/terminology/ definition of nociceptor: A high-threshold sensory receptor of the peripheral somatosensory nervous system that is capable of transducing and encoding noxious stimuli.

@raymond91125 Yes. I originally rain across this issue b/c I was working with UBERON (cc @cmungall ).

PMID:29032407 states that "Nociception is the neural process of encoding noxious stimuli, whereas pain is defined as an unpleasant sensory and emotional experience associated with actual or potential tissue damage, or described in terms of such damage".

Thanks for including this.

Well, even though nociception and pain are not the same per se, it seems that in the literature, nociception and the sensory perception of pain are not different. That is, there does not seem to be another type of sensory perception of pain and nociceptor is synonymous with pain receptor. @wdduncan have you come across anything contradicting?

Re: nociception vs. sensory perception of pain
I suppose it depends what is meant by sensory perception of pain . The current definition reads:

The series of events required for an organism to receive a painful stimulus, convert it to a molecular signal, and recognize and characterize the signal. Pain is medically defined as the physical sensation of discomfort or distress caused by injury or illness, so can hence be described as a harmful stimulus which signals current (or impending) tissue damage. Pain may come from extremes of temperature, mechanical damage, electricity or from noxious chemical substances. This is a neurological process.

I would agree that nociception is a part of this part this process. It seems a bit strong to specify that nociception is an exact synonym of sensory perception of pain (IMHO).
To be honest, I don't completely understand what it means for nociception to be the process that "encodes" the noxious stimulus (as defined in the IASP terminology, and how nociception (in the IASP sense) is distinct from detection of stimulus involved in sensory perception of pain, which is defined as:

The series of events involved in the perception of pain in which a stimulus is received and converted into a molecular signal.

Depending what is meant by "encodes", it seems that nociception may be part of detection of stimulus involved in sensory perception of pain too.

I randomly checked some references that provide the evidence for EXP annotations to GO:0019233 'sensory perception of pain' directly; 8 of 8 mention nociception. Thus the usage of this term appears consistently to be about nociception.

Sure ... consistent use doesn't mean correct use, though.

@raymond91125 We've had a lot of back and forth :)
So, to summarize, the IASP makes a distinction between nociception (neural process of encoding noxious stimuli) and pain, 'pain' being defined as "an unpleasant sensory and emotional experience associated with actual or potential tissue damage, or described in terms of such damage". That is, nociception can occur without the unpleasant sensory and emotional experience of pain.
The GO definition of sensory perception of pain is ambiguous about whether this entails a sensory experience. So, all I am suggesting is that the has_exact_synonym nociception be dropped or changed to has_related_synonym nociception (which you proposed).

@wdduncan Thank you for your patience. I will bring this up in our ontology editor meeting (as soon as next week). My concern about the action 'has_related_synonym nociception' is that nociception is an important biological process that should be more formally represented in GO, not just as a related synonym.
The examples I've read (e.g.  https://pain.ucsf.edu/understanding-pain-pain-basics/nociception-versus-pain) to distinguish between nociception and the perception of pain are about conditions that may be considered abnormal (patient under general anesthesia or patient with central neuropathic pain after stroke). Thus, 'normally', perhaps the sensory input that leads to pain is exclusively nociception. I don't have the answer.
Nociception is more generally applicable to animals and readily definable whereas pain may be more relevant to human perception and experiences.

@wdduncan I made the change of nociception as a related synonym, since @ukemi pointed out that in GO lingo "sensory perception" covers the CNS part of 'interpretation' (recognition). As you pointed out, "detection of stimulus involved in sensory perception of pain" is probably an exact synonym for nociception instead.

Thanks @raymond91125 !


Back to development mode

Switches the version tag back to development mode and adds a short checklist to follow for making releases.

I think those instructions should be much improved, but in a subsequent PR so it doesn't block on the tag being changed. I'll open an issue about that then I'm +1 on merge if the tests pass


Include  to get declaration of std::array type

The guid_t class' element 'data_' has std::array template type.
So it is necessary to include  to get the declaration of the type.
Fixes the clang + libc++ error
.../opae-sdk/common/include/opae/cxx/core/pvalue.h:133:27: error: implicit instantiation of undefined template 'std::_1::array<unsigned char, 16>'
std::array<uint8_t, 16> data;
^
.../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
^

Coverage increased (+0.02%) to 81.185% when pulling 54aa22c2a76e556627397ecd1a9fbc2cc7a7ca35 on trixirt:trix/master/sa-pvalue into 71ac5d4a7923826bc3b6c8e971b5b3b48a08044d on OPAE:master.


Error building from Makefile

# make juicefs
go build -ldflags="-s -w -X github.com/juicedata/juicefs/pkg/version.revision=1eb0d3d4 -X github.com/juicedata/juicefs/pkg/version.revisionDate=2022-04-21"  -o juicefs ./cmd
build github.com/juicedata/juicefs/cmd: cannot load io/fs: malformed module path "io/fs": missing dot in first path element
make: *** [Makefile:23: juicefs] Error 1

Using outdated go 1.13, update to 1.18 fixed build issue.


Merge Ubiquity Changes In

I accidentally nuked the main branch with a force push (from the GitHub UI!?)
Perhaps this can remedy things.

sorry, was busy with https://github.com/ubiquity/ubiquity-dollar/issues/292

sorry, was busy with ubiquity/ubiquity-dollar#292

You're all good. I accidentally closed this by deleting the branch it was associated with. When you're ready we can make a brand new issue for this! I was just doing some restructuring on the branches.


[tests]: fix 1.28 release CI

What this PR does / why we need it:
This PR fixes the 1.28 CI. OpenStack Zed release is not maintained anymore.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/test pull-cloud-provider-openstack-check

/lgtm
/approve


Support for stack frames from xerrors

Summary
This is related to the xerrors package: https://godoc.org/golang.org/x/xerrors
For high level context, we are still using this in favor of Go 1.13 stdlib because of the stack trace collection that when logged helps developers understand where the errors are coming from.
An issue was raised before in https://github.com/getsentry/sentry-go/issues/137. While I see that the unwrapping an xerror to its original error is working, I do not see stack traces from xerrors working in Sentry.

Steps To Reproduce

func foo() {
	sentry.CaptureException(x1())
}

func x1() error {
	return xerrors.Errorf("%w", x2())
}

func x2() error {
	return xerrors.New("x2msg")
}

Expected Behavior
If you print the extended format of the xerror you see a stack trace like:
x2msg:
  grax/x/log.x1
    foo/x/log/error_test.go:84
- x2msg:
  grax/x/log.x2
    foo/x/log/error_test.go:88

But if I look at Sentry UI I do not see anything about x2 or x1 in the call stack. See the screenshot below.
Screenshots

Sentry.io Event

Environment

SDK

sentry-go version: github.com/getsentry/sentry-go v0.6.1
Go version: go version go1.14.3 darwin/amd64
Using Go Modules? yes

Sentry

Using hosted Sentry in sentry.io? yes

Additional context
Digging into the sentry-go code I see support for getting stack frames from interfaces packages like https://github.com/pkg/errors use. But I do not see anything related to the xerrors interface.
https://github.com/getsentry/sentry-go/blob/master/stacktrace.go#L71
I will attempt to patch this, but wanted to open an issue first to discuss.

I haven’t found a good way to get the actual frame data in since xerrors doesn’t offer a public interface to get the data out.
For now I am copying the expanded xerrors formatting with stack trace into the sentry exception message.

@nzoschke thanks for filing the issue. I confirm I've implemented unwrapping and overlooked the stack trace extraction at the time, my bad.
I'm working on revamping the stack trace extraction and was able to extract the stack from an xerrors error using reflection:
field := reflect.ValueOf(err).Elem().FieldByName("frame") // type Frame struct{ frames [3]uintptr }
field = field.FieldByName("frames")
pc := make([]uintptr, field.Len())
for i := 0; i < field.Len(); i++ {
	pc[i] = uintptr(field.Index(i).Uint())
}

One thing to notice is that unlike github.com/go-errors/errors (max depth 50 frames) and github.com/pkg/errors (max depth 32 frames), golang.org/x/xerrors retains at most 3 (physical) frames (there can be more logical frames due to inlining).
If all goes well this week I should be able to prepare a patch and submit a PR.


Feature/gradle 8.10.2

You could rename the PR to have a nicer name than just the branch name

You could rename the PR to have a nicer name than just the branch name

This should have happened because the branch already had several commits when the PR was created.


[Pending Review]Update you-cannot-complete-this-process.md

Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:

We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

Hi @theley502, I restructured the Resolution section based on your draft. Can you have a look? Thanks!


use skaffold build

I don't know what's going on with CI here but we do need this change to build in latest JX.


Create Objects & Copy Object Name

1- We need to ability to Create Objects like Tables, Triggers, Sequence,.....etc. Wizard not only using Commands .
2- I can`t Copy any object Name Like Tables 'Name.
3- Can Rename the Untitled worksheet with the Schema name.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Question about Preprocessing HCP-style

I have a dataset that has full dwi scans in both AP and PA directions. My understanding is that I should be including the --distortion-group-merge average option in command line, per the "Preprocessing HCP-style" section. The documentation here suggests I should be including the --combine-all-dwis option as well, but I believe that flag has been removed (and is the default option?).
However, in terms of setting up the BIDS-valid dataset, am I right in thinking that I should put both of these scans (AP and PA) in the dwi folder? Also, is there any metadata field that needs to be added? I have tried a couple different options but kept running into errors.
Thanks,
Andrew

We've also run into issues with this setting and HCP-style data. In particular we're running this command line call:
docker run -ti --rm   -v /<path to data>/:/data:ro   -v /<path to data>/derivatives/:/out   pennbbl/qsiprep:0.15.3   /data /out participant --fs-license-file /data/fs_license.txt --output-resolution 1.5 --dwi-only --distortion-group-merge average

And we're running into this error:
ValueError: Field of view of image #1 is different from reference FOV.
Reference affine:
array([[-1.48667288e+00,  1.99421033e-01,  5.91740012e-03,
         9.18560028e+01],
       [ 1.86300784e-01,  1.40355873e+00, -4.95292544e-01,
        -8.66671829e+01],
       [ 7.13847876e-02,  4.90157068e-01,  1.41585684e+00,
        -1.19574066e+02],
       [ 0.00000000e+00,  0.00000000e+00,  0.00000000e+00,
         1.00000000e+00]])
Image affine:
array([[-1.49594903e+00,  1.06968507e-01, -2.63520107e-02,
         1.02660027e+02],
       [ 1.08431503e-01,  1.36621404e+00, -6.09673440e-01,
        -7.02401581e+01],
       [ 1.94755811e-02,  6.09931827e-01,  1.37025690e+00,
        -1.36695358e+02],
       [ 0.00000000e+00,  0.00000000e+00,  0.00000000e+00,
         1.00000000e+00]])
Reference shape:
(140, 140, 92)
Image shape:
(140, 140, 92, 100)

Is that also the error you are seeing @andrew-yian-sun? Should we be using a different setting for distortion-group-merge? Or is something wrong with the data?

In terms of how to set it up, @andrew-yian-sun I think the dwi directory needs to include:

DWI data (_dwi.nii.gz)
bvec / bval (_dwi.bv[ec,al])
BIDS sidecars (_dwi.json)

For example,
sub-999999_ses-MR1_acq-98dir_dir-AP_dwi.bval
sub-999999_ses-MR1_acq-98dir_dir-AP_dwi.bvec
sub-999999_ses-MR1_acq-98dir_dir-AP_dwi.json
sub-999999_ses-MR1_acq-98dir_dir-AP_dwi.nii.gz
sub-999999_ses-MR1_acq-98dir_dir-PA_dwi.bval
sub-999999_ses-MR1_acq-98dir_dir-PA_dwi.bvec
sub-999999_ses-MR1_acq-98dir_dir-PA_dwi.json
sub-999999_ses-MR1_acq-98dir_dir-PA_dwi.nii.gz
To work properly, these files must contain the same measurements (same bvecs and bvals) with opposite phase encodings. For example, for AP we should see in the JSON
    "PhaseEncodingDirection": "j-",

and for PA
    "PhaseEncodingDirection": "j",

This also works for LR / RL pairs (eg WashU HCP sequences).
The error that @arokem has is more complicated, and happens if the FOV is not consistent among the scans to be merged. This is a really tricky question to deal with (see https://github.com/PennLINC/qsiprep/issues/273). If the rotation is small and the translation is fairly small, in my opinion it's safe to copy the header transforms from the first image to the second one.

@arokem No, that is not the same error that we are getting. What happens is that if we simply put both the AP and PA in the dwi folder:

dwi/

sub-01_ses-1_dir-AP_dwi.bval
sub-01_ses-1_dir-AP_dwi.bvec
sub-01_ses-1_dir-AP_dwi.json
sub-01_ses-1_dir-AP_dwi.nii.gz
sub-01_ses-1_dir-PA_dwi.bval
sub-01_ses-1_dir-PA_dwi.bvec
sub-01_ses-1_dir-PA_dwi.json
sub-01_ses-1_dir-PA_dwi.nii.gz

and AP and PA jsons have j- and j, respectively, in their "PhaseEncodingDirection" fields, we get a packet_write_wait: Connection to <IP_ADDRESS> port 22: Broken pipe. After this, we have to manually restart our Linux machine to be able to access it again.
We've successfully run the same version of QSIprep on the same computer, but on another dataset where opposite encoding fieldmap was collected (B0_PA in fmap, IntendedFor field set to the AP files in dwi).
Forgot to mention this as well but here are the software details:
QSIprep version: 0.14.3
OS: Centos 7

and AP and PA jsons have j- and j, respectively, in their "PhaseEncodingDirection" fields, we get a packet_write_wait: Connection to <IP_ADDRESS> port 22: Broken pipe. After this, we have to manually restart our Linux machine to be able to access it again.

I think this is only indirectly related to the data.
By manually restart, do you mean the machine becomes unresponsive, and you have to physically reset it? Could it be that qsiprep is using all the resources? How much RAM is on the machine?

By manually restart, do you mean the machine becomes unresponsive, and you have to physically reset it? Could it be that qsiprep is using all the resources? How much RAM is on the machine?

Yup, everyone who has ssh'ed into the machine lose connection, and are unable to ssh back in until the machine is physically reset. The RAM is 92 GB.

@cookpa : Thanks for pointing out that issue! 🤔

@andrew-yian-sun Are you limiting the parallel threads? When your jobs start, you should see something like
220314-13:35:46,286 nipype.workflow INFO:
         Running with omp_nthreads=3, nthreads=4
220314-13:35:46,288 nipype.workflow IMPORTANT:
    Running qsiprep version 0.14.3:
      * BIDS dataset path: /data/input.

what does it say?

No, I haven't been adding --nthreads or --omp-nthreads options. Here's what I see when my jobs start:
220315-01:07:35,441 nipype.workflow INFO:
	 Running with omp_nthreads=8, nthreads=32
220315-01:07:35,454 nipype.workflow IMPORTANT:

    Running qsiprep version 0.14.3:
      * BIDS dataset path: /data.

This might help then, add --nthreads 4 --omp-nthreads 3 to the call. It will take longer but may avoid locking up the system. If that works, you can try increasing to --nthreads 8 --omp-nthreads 7.
The idea of setting omp threads to (nthreads-1) comes from a discussion about fmriprep, I've not tested it on qsiprep specifically, and it might be more efficient to run with the same number for both. But you will use more RAM and may see diminishing returns past 8 threads.

@cookpa is right, you should definitely limit omp_nthreads and nthreads to prevent your computer from crashing.

@cookpa Thanks! That seems to have worked. However, we're now running into another issue:
The b-table /work/qsiprep_wf/single_subject_01_wf/sub_01_ses_1_final_merge_wf/distortion_merger/averaged_pairs.bval and /work/qsiprep_wf/single_subject_01_wf/sub_01_ses_1_final_merge_wf/distortion_merger/averaged_pairs.bvec do not match each other
mismatch between bvec file and the loaded images

Here is the full crash file:
crash-20220318-061132-root-raw_src-1cc8a703-6744-41fc-8606-2fd088416bba.txt
And here relevant bval and bvec files that aren't matching.
averaged_pairs.bval.txt
averaged_pairs.bvec.txt
I see that the bvec has nans while the bval has 0's - is this an issue?

Hmm, do your input bvecs have zeros corresponding to bval = 0? If so, that might be the source of the NaN.

Yes the input bvecs haves zeros corresponding to where bval = 0, but shouldn't that be the case?
Here are the input bval and bvec files:
sub-01_ses-1_dir-AP_dwi.bval.txt
sub-01_ses-1_dir-AP_dwi.bvec.txt
sub-01_ses-1_dir-PA_dwi.bval.txt
sub-01_ses-1_dir-PA_dwi.bvec.txt

Yes, a zero b-value has an undefined gradient direction. But wherever I see a "nan" I think of where a division by zero may have crept in. This sounds like a bug, but one we've probably not encountered before because we don't typically see zero b-vectors.
Modern data, at least for Siemens scanners, don't have true zeros because they record all the gradients in play at the time of acquisition, not just the diffusion-sensitizing gradients. So the bvecs are always a unit vector, and the bvals are off by some small amount from their nominal value.
Just curious - are these bval.txt and bvec.txt files produced from dcm2niix? Or are they they nominal bvecs and bvals programmed into the sequence?


Add comments for PBFT and all relative files

Fixed by https://github.com/Taraxa-project/taraxa-node/pull/1755


V22F-612 Blackbox replayer command line arguments

Blackbox replayer now can read command line arguments in a terminal

Also I wonder what the main file entails? Is that needed for this pr to work?


please disable logging jsonstr in console OR make it optional

ok, I guess logging is enabled only in dev mode right? please correct me if I'm wrong

ok, I guess logging is enabled only in dev mode right? please correct me if I'm wrong


Fix spacing in contact.forms

Coverage remained the same at 99.204% when pulling b8edeeeaa7f9b04b2de9f05e6231b8c24df07885 on forms-spacing into fe53170daeaa1c89d5aa5147ccae5ea417b342f3 on master.

Coverage remained the same at 99.204% when pulling 563adc3180e713d0f68820af919fe6ae2d682563 on forms-spacing into fe53170daeaa1c89d5aa5147ccae5ea417b342f3 on master.


[web] --optimization-level 4 breaks web apps on Safari

When building my Flutter web application with --optimization-level=4 (the default), Safari only displays a gray box, whereas Chrome and Firefox show the application correctly. Using --optimization-level=2 resolves the issue for Safari, suggesting that the optimization level might be causing the bug.
Steps to Reproduce

Visit Non-Working Build (https://bug-report-non-workung.pages.dev/)

Compiled with: flutter build web --release --no-web-resources-cdn --optimization-level=4(default)
Chrome/Firefox: The app runs successfully.
Safari: The app shows only a gray box (error).

Visit Working Build (https://bug-report-working.pages.dev/)

Compiled with: flutter build web --release --no-web-resources-cdn --optimization-level=2
Chrome/Firefox: The app runs successfully.
Safari: The app also runs successfully.

Note: I was unable to isolate a minimal reproducible example, but I’m happy to attempt it if given further guidance.

Expected results
Using --optimization-level=4 (the default) should produce a web build that works on Safari, just like it does in Chrome and Firefox.
Actual results
With --optimization-level=4, the web app fails to render on Safari (displays a gray box), even though it works correctly on Chrome and Firefox.
Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.27.1, on macOS 14.6.1 23G93 darwin-arm64, locale en-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.3)
[✓] Android Studio (version 2021.3)
[✓] Android Studio (version 2022.2)
[✓] IntelliJ IDEA Community Edition (version 2024.2.3)
[✓] VS Code (version 1.95.3)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Update: Both links work on Safari on iOS.
The bug occurs on Safari (Version 18.0.1) on macOS.

Hi @dxvid-pts, can you add the --source-maps option to the build command to see if we can get a clearer error message? There appears to be error related to a format exception in the logs [Log] FormatException: Invalid double (main.dart.js, line 46586)
Are you able to create a minimal reproducible code sample?
Also, locally, does the application work as expected in profile mode?


feat: remove block range limit in eth_getLogs when filtering with a single address

Description:
This PR removes the block range limit, e.g., 1000, when the filter in the eth_getLogs contains a single address (the optional address param might be either a string or an addresses array).
This change allows consumers to query all the log entries of the given address. For now, we permit only a single address, but in the future we might relax this constraint as well.
The block range validation is also used in eth_newFilter, but it should not be affected by this change.

Related issue(s):
Fixes #2175
Notes for reviewer:

It also fixes function type signatures, _i.e., use string[] instead of [string].
Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.15%. Comparing base (adfe759) to head (fa0ae68).
 Consider uploading reports for the commit cd4805e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2236   +/-   ##
=======================================
  Coverage   75.15%   75.15%
=======================================
  Files          13       13
  Lines         644      644
  Branches      118      118
=======================================
  Hits          484      484
  Misses        115      115
  Partials       45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@ebadiere @AlfredoG87 I would appreciate your input here if you have some time, thanks!

should we really allow for unlimited amount of blocks? could it become too much too handle, maybe having a different limit altogether? like maybe, 100,000 blocks or something. let me know your rationale here.
Have we tested limits on the mirror node for timestamp of query? (`contracts/${MirrorNodeClient.ADDRESS_PLACEHOLDER}/results/logs)

The mirror node supports the query without timestamp. The openrpc.json was updated to reflect pagination limits in f341324e5a9ac865dee9f3ba3685843b62443a2b.


Missing documentation about how to properly use ESP-NETIF LWIP abstraction (IDFGH-6701)

Environment

Development Kit:      Custom PCB with mentioned chip
Module or chip used:  ESP32-WROOM-32E
IDF version (run git describe --tags to find it): v4.4 Stable
Build System:         CMake with idf.py
Compiler version: xtensa-esp32-elf-gcc 8.4.0
Operating System:  Windows
(Windows only) environment type: [MSYS2 mingw32|ESP Command Prompt|Plain Command Prompt|PowerShell].
Using an IDE?: Yes: CLion

Problem Description
ESP-IDF Uses LWIP for handling network interfaces(netif objects). In our project, we are using WiFi, Ethernet and Cellular(PPPoS) network interfaces. We want to switch accordingly. esp_netif abstraction of LWIP has some functionality to set a default network interface. That function specific is
static void esp_netif_set_default_netif(esp_netif_t *esp_netif)
{
   if (esp_netif->is_ppp_netif) {
       esp_netif_ppp_set_default_netif(esp_netif->netif_handle);
   } else {
       netif_set_default(esp_netif->netif_handle);
   }
}

The documentation says it must be called from an lwip thread. Unfortunately it is unclear how this is called and how this should be used, hence I think some documentation is missing. Correct me if I'm wrong.
At the moment we are switching interfaces by using the base layer of lwip, and using the following code.
netif* tmp;
NETIF_FOREACH(tmp){
// do stuff, switch interfaces etc.
}

We would like to use the abstraction layer of ESP_NETIF.

Hi @crisvdn
This ESP-NETIF API esp_netif_set_default_netif() is only meant to be used internally. This is called automatically whenever any interface is set up or down, so the default interface is chosen from those, that are up, with the highest route_prio. In that sense, it should be enough to configure the route_prio when initializing an interface.
Do you need to implement some additional logic when setting default netif? Could you please explain a bit what is your use case?

Hi @david-cermak , thanks for your quick response.
Ah, as far as I understood it was an API function call and we could use it ourselves. That clears it up that its linked to the route_prio.
We have multiple use-cases regarding the network interfaces and a single development issue that has to be resolved with it.
Our interface combinations are primarily the following:

Ethernet + Wifi
Ethernet + Cellular.

Unfortunately our PHY(kzs8863) is not supported as of yet and a basic custom implementation of the driver is written. But it will always be "available/link up", even though an Ethernet cable is not connected. The ETHERNET_EVENT_START and ETHERNET_EVENT_STOP are not triggered.
I assume Ethernet has the highest priority by default, but this is something I would have to check. We do have proper IP_EVENTS we can listen to, so then we trigger the netif_set_default() function for Ethernet.
As of now, I want to switch manually to WiFi as a default interface when a connection to an access point is made.
Also manually switching to Cellular when the PPPoS connection is made and an IP is assigned. But we want to switch to Ethernet when an Ethernet cable is plugged in, no matter if WiFi or Cellular has been set up.
I dont think changing route_prio values dynamically is the solution here. So a manual function call would be the best solution in my eyes. Let me know what you think.

@crisvdn Thanks for explaining!
Yes, I agree that for this use case it would be more convenient to add the esp_netif_set_default_netif() to public API of ESP-NETIF, so it could be called manually (and at the same time, optionally disable the route_prio functionality).
I will propose this API update to ESP-NETIF and share it here, soon.


Question about prior loss

Hello, in my training, the prior loss does not decrease and has been maintained at a certain value.

How can I solve this problem?

What is your prior_loss_weight? Not sure there is a problem per se, as your total loss is decreasing.


email validation

email address validation needs to be implemented, should be in the form of <username>@<domain>

now covered by #17


修复解析配置role、type字段 fix #3

What this PR does:
Which issue(s) this PR fixes:

Fixes #3
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

麻烦再修改下 lint 检查到的拼写错误。


[NOMERGE] Add Alchemist Server

This was a lot of work and theres still things to be done, however it
should be good for now.
Rocket is the backend for the web server with serde for json, it takes
requests at "http:///api/v0/". There are three endpoints ATM:
- / for the index, takes a GET
- /version["/", "/client", "server"] returns the current
versions of the client and server on GitHub respectivly, or both if not
specified.
- /packages Takes POST request with the package[s], distro name,
the name of the client and version of the client.
This is a pretty big change to how Alchemist will work and is a on going
progress.

Fixes: #77
On the block to be fixed are: #75 #26 #79
Until the issues mentioned above are fixed this shouldn't be considered for merging/

This is also waiting on #81 for Travis support for these changes.

I was just rebasing the branch to be up to date with master, no actual changes

I pushed some new changes, I want to get #79 working before merging this into master... however all code not related to that should be good for review.

Looks like travis borked its self again, I'll push a commit to fix that when I get the chance. Also going to note that #79 is coming along pretty good, hopefully should be done in a few days.

I don't want to merge this in until I have #79 done as part of this merge, I feel like that is a important part of the server's core functionality.

Ahh I see. Normally if someone puts in a PR and notes why it shouldn't be merged yet then nothing will happen until it's done. That's why I had removed it but good to know you're waiting till you close #79 with it!

Yep, it's being worked on, but if it takes too long and everything else is fixed feel free to merge it. It shouldn't take that long though.

There's no rush your stuff is independent from the other code so this is fine!

@SirDoctors I was wrong with the code I gave you for the filter. You needed to do a filter/map/collect and I forgot that was what was needed. I've updated the code above for you.

@SirDoctors just letting you know I saw this and will get to reviewing when I can!

Going to update this pr for serde 1.0

@SirDoctors sounds good to me!


Add deprecation note to Adaptive Card tab samples

We have announced that "Adaptive Card tabs will be deprecated in the new Microsoft Teams" - https://learn.microsoft.com/en-gb/microsoftteams/platform/tabs/how-to/build-adaptive-card-tabs
Can we update the samples that use adaptive card tabs to include this deprecation notice?

tab-adaptive-cards/csharp
tab-adaptive-cards/nodejs

There may be more samples but these two definitely should be updated.
Thanks.

@eoinobrien - Thanks for reporting your issue. We will raise the PR for adding the deprecation note in below sample.
tab-adaptive-cards/csharp
tab-adaptive-cards/nodejs

@eoinobrien - The PR has been raised for this issue: #796.

Hello @eoinobrien - PR changes are merged.

We are closing this issue. Please feel free to re-open it if required.


[FLINK-26495][table-planner] Prohibit hints(dynamic table options) on view

What is the purpose of the change
This PR aims to throw an explicit exception when querying a view with hints to improve user experience. Currently, the hints on view are swallowed quietly during the planning phase without any trace, and users complain that the hints don't work on view.
Brief changelog

Add check on ExpandingPreparingTable to throw a ValidationException
A monitor fix for CliClientITCase to correct the assertion order for expected and actual

Verifying this change
This change added tests and can be verified as follows:

TableEnvironmentTest#testQueryViewWithHints
OptionHintsTest#testOptionsHintOnTableApiView and #testOptionsHintOnSQLView
Add test case in view.q, which can be verified by running CliClientITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=32676&view=logs&j=5c8e7682-d68f-54d1-16a2-a09310218a49&t=86f654fa-ab48-5c1a-25f4-7e7f6afb9bba
ChangelogPeriodicMaterializationITCase is unstable

@flinkbot run azure

Hi, @godfreyhe, do you have time to take a look?

Thanks @LadyForest for the contribution, can you add a case:

create view1 ....
create view2 select ... from view1 /** dynamic table hints .....*/;

Explain select view2.

Thanks @LadyForest for the contribution, can you add a case:
create view1 ....
create view2 select ... from view1 /** dynamic table hints .....*/;
Explain select view2.

Sure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


Zinc doesn't register dependencies on wildcard imports + name shadowing

This is yet another example of why using wildcard imports is evil.
This issue is ported from sbt/sbt https://github.com/sbt/sbt/issues/1751.
Problem
In essence, Zinc is unable to register dependencies of shadowed names coming from two subsequent wildcard imports. For mortals, this means that this situation is not handled correctly:
// A.scala
import p1._
import p2._
class A {
  val b = new B()
}

// p1.scala
package p1 {
  class B
}

// p2.scala
package p2 {
  // Uncomment in next iteration -> Zinc doesn't recompile A
  // class B
}

The problem is that p2 definitions shadow p1's and it's not possible for Zinc to know that beforehand. Zinc only know what the compiler knows, and since we don't see any reference to p2.B, the dependency on that B will never be registered.
Possible solutions
What can we do about this? I'm afraid there's nothing to do.
The name hashing algorithm buys us a very good tradeoff to detect dependencies, but the only constraint is that dependencies are explicit throughout the trees of a given compilation unit (which is the case for every used definition).
There is no way to detect this new dependency reasonably because we don't know if it will ever happen, and therefore we need to guard us against any instance that could introduce it.
To support this use case, we would need to register phantom dependencies on all used names coming from imports used in all the enclosing scopes of a given wildcard import, for every name that is not defined in the imported symbol. In our example, we would get all the members of p1 that are not defined in p2 and create a "phantom" dependency on that name as if it were defined inp2 (and bail out if it's defined).
For the sake of correctness, we should do that for every member defined in p1 and any wildcard import that is present in an enclosing scope. Then, the easy part: our algorithm would identify those "phantom" dependencies when changes in API happen. If the API introduces a member with the target name of the "phantom" dependency, the sources that introduced the dependency should be recompiled.
But hey, we're not done yet. We also need to register phantom dependencies on names coming from inherited classes and defined present in enclosing scopes (e.g. nested objects have access to all the names in enclosing classes, so if we use a wildcard import inside that object, we need to register phantom dependencies on the symbol of the Import node for every accessible name). How fun!
At this point, we realise that supporting this use case is totally unfeasible. The complexity of the algorithm and the memory required to host those phantom dependencies would be very big, especially given:

The frequency in which wildcard imports happen in Scala code.
The large number of definitions present in any scope.
The complex scoping rules that Scala has.

With this, I suggest that Zinc does not handle this use case. To our defense, I will say that this is a pretty intricate bug, difficult to find in any Scala codebase, and whose fix would render Zinc highly inefficient and slow, plus add a bunch of code that anyone would ever want to touch.
To our attentive reader, if there's something you should remember, this is it:
Avoid wildcard imports + name shadowing, Zinc won't do the right thing.

I am marking this as wontfix. I'm happy to reconsider if someone finds a better solution than the one I proposed or any issues with my explanation.

I run few tests and is seems that that is only the case where we are dealing with classes that comes from packages (package objects or plain objects are handled correctly).
I should soon create PR with improvements around sealed class (now adding new child recompiles every usage of sealed class but should only recompile pattern matching) and we based fix for this problem on that.

Sounds to me like what @romanowski says does contest the "wontfix". So dropping. Optimistically :)
@jvican Are you aware of the different strategies that zinc used over time? The original one, the name-hashing and the class-based name-hashing. Could you tell me if this bug is more or less fixable depending on the strategy used?

I think scope of dependency (class based name hashing is all about) does not matter since it is also present if we have only one class per source file (and in that case there is no difference in both name hashing).
@dwijnand Fix for this will probably require some serious changes in hash computation (since we need to aggregate hash for package across all dependencies no just for single source (either single jar or outer project).

I didn't say that scoping from nested classes are not supported, it is supported indeed. At the moment you modify one source file, the whole source file will be recompiled again, so if you define values in outer scopes that are used in inner scopes, you'll always get the right value.
The problem with scoping comes when you have open-ended features like wildcard imports. Because these imports could shadown any name in the scope, Zinc is not capable of recognising them.
Yes, I'm aware of the different strategies. In my view, the previous and overly pessimistic strategy worked because Zinc was overcompiling. But in this case, we have a more fine-grained algorithm that avoids overcompiling at any cost and aims at a higher precision.
I was thinking how this could be solved with more complex and better techniques, like the call-graph, and my conclusion is that this is not possible. So, in conclusion, my ticket only refers to wildcard imports + scoping together, not separately.

Yes, I'm aware of the different strategies.

I should have clarified: I'm a noob; I was asking because I'm not aware of the exact differences between them.

In my view, the previous and overly pessimistic strategy worked because Zinc was overcompiling. But in this case, we have a more fine-grained algorithm that avoids overcompiling at any cost and aims at a higher precision.

At the cost of this bug. Hopefully Krzysztof is able to fix this, because I don't consider wildcard imports "evil" and don't want to give them up because of zinc.

@dwijnand No, there's no issue using wildcard imports in cases where name shadowing doesn't exist, that's why the title of this issue says "wildcard imports + name shadowing".
If you use wildcard imports effectively, you will always register its dependencies with Zinc. Why? Because of two things:

The Scala compiler will expand some paths and use Selects chains.
The Scala compiler will fill in the trees with symbol information that will allow you to know that a certain name comes from a concrete path.

So, using wildcard imports is totally okay. What it's not okay is that you introduce a new name on a wildcard import that shadows an existing name at the use-site. In that case, Zinc cannot register the dependency for the reasons explained above.
I'm not a fan of wildcard imports because of these hard-to-spot subtleties. I was trying to fix this issue, but I found out it's not possible.
@dwijnand Regarding the previous strategy, AFAIK, any reference to a previous class meant that the source file defining it had to be recompiled. There was no fine-grained control over what kind of dependency we were handling.
I'd like to retract what I said before about the previous Zinc algorithm. After giving it some more thought, I think that not even the previous algorithm was handling this case.

But it's definitely a lot less than I thought.

Yeah, exactly, that's why I said that it's a intricate behaviour that would rarely happen. IIRC, some small corners in ScalaJS rely on this, but they are so small that should not suppose any issue. The reason for ScalaJS to use this feature interaction is, I think, for patching stuff and making it compatible with any Scalac version (Scalajs hasn't broken compatibility since first release).

#267 "Implement used scopes for used names and implement PatMat scope" (now merged!) states

In future this mechanism can be used in #227 #226

So I guess this is no longer "wontfix"?

I already explain in #267 that those have nothing to do with this. This won't be ever fixed.

No, didn't explain it in the ticket but the Gitter channel. I'll post link later for future reference.

I'll post link later for future reference.

Excellent. Thank you.

Is this same issue?
https://github.com/xuwei-k/sbt-incremental-compiler-bug/commit/6976731454879eb117bcd809839858bdb4aed355

At first glance, no, I don't think so. Is this happening with Zinc 1.0?
If so, can you open a new issue in this repo? Otherwise, can you do it in the sbt repo? If it's  a Zinc 1.0 error, I'll look into it and do a deeper diagnosis of this error.

I fear root of problem may be the same since every class has a 'wildcard import' from its package(s) (but I need to confirm that).

I fear root of problem may be the same since every class has a 'wildcard import' from its package(s) (but I need to confirm that).

@romanowski Yes, typer definitely puts into scope all the names that are known to be defined under a package foo. If you're curious about that, have a look at Contexts.scala: https://github.com/scala/scala/blob/2.12.x/src/compiler/scala/tools/nsc/typechecker/Contexts.scala.
@xuwei-k Actually, yes, your issue is basically reproducing the situation that I describe in the description. I missed the package y in the createFoo task.

Problem manifested in another form (please correct me if I am not right): https://github.com/romanowski/zinc/commit/82d660cf2f245da400ab68a145b1f3ed21f83046
Do want me to PR this test?

Hey @romanowski, excellent! You found another instance of the same problem. Let's try to generalize the title of this ticket. I would name the new instance "implicit shadowing". Let me know if you agree with it.
Regarding the PR, feel free to, but I wouldn't see it as necessary since there is no way we can fix this in the current name-hashing algorithm without making Zinc substantially slower :smile:. Test cases are great when we can fix them!

Interesting. I will experiment about ways we could make Zinc aware of that implicit resolution, I have some ideas that could go in the right direction. I will report on them soon.

Note that the issue with implicit resolution only happens because we're declaring an implicit in a package object, which following the SLS (Scala Language Specification) is always auto-imported in sources defined in the same package name. Any change that requires a source change in the file that triggered implicit resolution would be perfectly handled.
Note also that if you import an implicit name and then you declare an implicit with higher priority in a wilcard imported scope, Zinc will not recompile that source file. This is just a subset of the problem described in the description of the ticket, but it's worth pointing it out.

always auto-imported in sources defined in the same package name

Not in this case. The problem here is that we've got unused import on type foo,Foo and later on I am creating implicit val Foo in package `foo.
Anyway, should I do a PR? :)

The problem here is that we've got unused import on type foo,Foo and later on I am creating implicit val Foo in package `foo.

Yes in this case :smile:. You're adding that implicit to a package object that requires no import in the original file to be in scope. Package objects are always auto-imported in packages with the same namespace. I say that it's auto-imported or wildcard-imported because defining members in package object have the same effect, even though they don't use _.
That will also happen if you do the following:
package foo
package bar.baz

class Baz

Separate package definitions (in different lines) auto-import members in the use site. For instance, Baz will have access to all member ofsfoo, even if there's no wildcard import.

Anyway, should I do a PR? :)

PR it :wink:, but I don't know an efficient solution to this problem.

I think we are will be forced to hash packages entries. I think we can do it without much overhead (for sure there will be some).
Anyway we need to at least try to solve this.

PR created: https://github.com/sbt/zinc/pull/289

Example:
mkdir project
echo sbt.version=1.2.3 > project/build.properties
echo import example._ > A.scala
echo 'class A {}' >> A.scala
echo 'class B {}' > B.scala
sbt compile # fail

echo package example > Example.scala
echo 'class Example' >> Example.scala
sbt compile # succeed

rm Example.scala
sbt compile # succeed

It seems macros and shadowing are two dark areas of incremental compilation. I think wontfix is an acceptable solution, as (1) the problem is not frequent; (2) programmers may always do a clean compile to remove all problems.
It would be nice that

when programmers publish artifacts, SBT always forces a clean build.
In the SBT build documentation, make programmers aware of the case of dirty cache, and instruct them how to deal with that.


Adds an effector to swarm-manager that interacts with the docker CLI

@m4rkmckenna I agree with @drigodwin - would be good to have a test with this before merging, so we can test it automatically in the QA Framework.


Optionally migrating tracker into an electron app

Suggestion

establish another script for package.json to develop/build for the electron desktop app
the app would build for mac, win and linux
See example here: https://github.com/TimSusa/midi-bricks-mono better: https://github.com/TimSusa/midi-bricks-mono/blob/master/packages/midi-bricks/package.json
As starting point some kind of electron.js has to be established: https://github.com/TimSusa/midi-bricks-mono/blob/master/packages/midi-bricks/app/electron.js

Personally, I can't see any benefit to wrapping the tracker up into an Electron app. If anything it could make the development process more complex as there will be more things to maintain and release.
That said, I'm happy to be convinced. What advantages do you think an electron version would give us vs loading a URL in the browser?

Hey @keithclark,
I have this project running by the way: https://github.com/TimSusa/midi-bricks-mono, which is a kind of hypbrid electron app. People, using this are quite happy to have the possibility of being independent about Online or Offline.  The app does more feel like an native installed application.

If you download the ZzFXM release you can just open it in a browser to run it offline.

We also have the option of adding a service worker to provide offline support, along with adding a manifest.json so it can be installed as a PWA.

I can see your point, but electron gives you access to special features like opening the window in a pre-configured setup or location, for example. I am talking about all these small things, which makes your gear better fit into some creative workflows. You have access to the operation system with electron. I mean thats the point. You could even have an auto-updater for latest versions. Build a local server for local connections.. etc pp.

Yea ok I see... https://www.youtube.com/watch?v=IkdmOVejUlI&t=38s maybe this discussion is out of your scope and I do not have the energy to convince you further. As far as for me you can close this issue. Machts gut!