Prepare Istio 1.23 release

Modified version of https://github.com/istio/istio/issues/50551 (from 1.22)

Introduction
This issue tracks all steps needed to prepare the release 1.23 branches/builds.
This issue was created early to help document the steps using some new automation as well as any ordering changes, etc. Please update/add additional steps taken here so we can document for future releases.
Note that the actual coding steps done by the automation steps are left in this issue for reference only. You only need to run the automated steps, and not the individual instructions. Also note that the reference steps may be INCOMPLETE as the automation is updated, not necessarily the reference steps.
The Automation
The release-builder automation can be found in https://github.com/istio/release-builder, master branch.  It's best if you fork this repo into your own org, as you will need to submit PRs into the repo to trigger the automation to run on Github rather than locally.
Whilst you're there it's also worth forking all* of the other Istio repos into your own organisation, as that way you can dry-run against it.  *by all, I mean the ones specified in release/branch.sh
Important things to know about the automation
First, spend a little time understanding the release-builder readme.  Don't worry if you don't understand all of it, it's not really necessary to in order to work through the rest of these steps, but having some understanding will help.  Here are the important things you must know:
The release directory contains three config files:

trigger-branch - this contains the version and step for the automation to work on
trigger-build - this contains the tag for the release-builder to use for whatever it's building
trigger-publish - this contains the tag that the release-builder will publish.

Before you start testing the automation with dry runs, update those files to whatever you need them to be.
Each time you start the build container with make shell you need to:

Run gh auth login (watch for errors, you may need to run this command with sudo
You also need to remember that for not-dry-runs you need to ensure that the GITHUB_TOKEN environment variable is set within the build container.  The automation does not care at all if you've logged in with the gh CLI.  The token that you use has to have repo permissions.  If you don't do this, the automation will fail when trying to interact with github by pushing, creating PRs etc.

How to run it
Update the relevant files to specify what you want, then:
make shell
gh auth login
GITHUB_TOKEN=my_token
REPO_ORG=myorg STEP=x ./release/branch.sh

This generates the changes for you to review (look at git status or git diff to see them).  When you are satisfied with what you see, run
make shell
REPO_ORG=myorg STEP=x DRY_RUN=false ./release/branch.sh

This will cause the actual step to happen and PRs to be raised in whichever github org you specified in REPO_ORG
Note that the automated steps 3 and on require the new release's branch in the various repos which are created by automated step 2.
Also note that if you're on a Mac you need to:

Run make shell with sudo
Runbrew install docker-credential-helper first to avoid difficult-to-spot errors in the scripts
Edit ~/.docker/config.json, change the line credsstore (two s) to credstore.
On Linux, I had no luck getting it to work on ubuntu (git clone would hang), but it worked fine on debian11.  That could just have been that my system had gremlins though.

Manual / Pre-req steps
When to start: 2 weeks before branch cut date

[x] Set up release manager team - Ensure the new team has write access to the repositories. (see teams.yaml) PR
[x] Create a slack channel for the 1.23 release. Edit the description/topic of the channel to include RM's for the release, expected release date, etc.
[x] Add new label: cherrypick/release-1.23: 1.23 PR
[x] Create a 1.24 milestone: 1.24 PR
[x] Send an announcement on Discuss pre-announcing branch cut
[x] Send an announcement on Discuss announcing the start of branch cut and to stop merging of PRs
[x] Fork (and update) istio repos mentioned in Step2. Example of forking a single repo from cli

gh repo fork https://github.com/istio/common-files --clone --default-branch-only

Step 0 - Alpha build
Build and release alpha 1.23-alpha from master. Examples build PR and release PR
Automation Step 1 - Update Dependencies
This step updates dependencies in master prior to the release branch being cut
Command to run
make shell
REPO_ORG=myorg STEP=1 ./release/branch.sh

example PR after the automation step 1, legacy manual steps should generate the same: 1.23 PR
Legacy Manual Steps

(Automation step=1) Update dependencies. This must be done before branching so that PRs can be easily backported later. PR

Run go get github.com/envoyproxy/go-control-plane@main to update (Added in 1.17 in https://github.com/istio/release-builder/pull/1332).
Run the following command in istio/istio UPDATE_BRANCH=master ./bin/update_deps.sh; make gen (example)
[ ] Merge PR in istio/istio. Wait for it to complete.
[ ] Need to verify git code to allow commits and pulls to work for upcoming 1.23 branch cut.

Automation Step 2 - Create The Release Branches
When to start: 1 week before branch cut date
This step creates release-1.23 branches in the necessary repos. Please run it against the istio org since there are no PRs for this step
Command to run
make shell
REPO_ORG=(myorg|istio) STEP=2 ./release/branch.sh

Branches need to be created after step 2:

istio/istio
istio/api
istio/ztunnel
istio/proxy
istio/client-go
istio/tools
istio/common-files
istio/release-builder
istio/enhancements

Skip istio/test-infra
Legacy Manual Steps

(Automation step=2)  (new step because we are waiting on prior change to master before branching) Create a release-1.23 branch in every Istio repo - run commands export org=xyz ; export repo=xyz ; (git clone git@github.com:${org}/${repo}.git && cd $repo && git checkout -b release-1.23 && git push --set-upstream origin release-1.23).

istio/istio
istio/pkg
istio/api
istio/envoy  (NOT done as part of release-builder) ([ ] Should update code to include this again? It seems Step=4 needs it, so will add it back) PR to add it back
istio/proxy
istio/client-go
istio/tools
istio/common-files
istio/release-builder
istio/enhancements
Explicitly skipped: istio-releases/pipeline, istio/tests, istio/istio.io, istio/test-infra, istio/gogo-genproto (No longer used and not done as part of release-builder 1.15 PR)
No PRs to merge as the new branches were created by automation

Post-automation steps

[x] Set up branch protection. Modify prow/config.yaml in test-infra to add release managers as owners for a branch. 1.23 PR

Automation Step 3 - Set Up Prow On Release Branches
21/4/2023 - automation for this step is currently broken with an early segmentation fault, run the manual commands
Only a Googler who has the ability to tag new images in the istio-testing gcr repo can run this step.  That means that you have three choices available:

Find one who is willing to work through running the automation
Puzzle out how the release-builder automation works well enough to edit out the three tagging commands below, comment them out.  Then find a googler to create the three tags and then run your edited automation
Find a googler to create the three tags below, then work through the remaining steps below manually

Command to run
make shell
REPO_ORG=myorg STEP=3 ./release/branch.sh

"Legacy" Manual Steps
Note: Here is the 1.18 PR for the manual steps - https://github.com/istio/test-infra/pull/4675
Since the automation currently doesn't work, in order to do this manually you need to:

Have a someone with creds for the istio-testing GCR repo create the new tags for build-tools, build-tools-proxy and build-tools-centosimages (e.g. John Howard).  For instance (replace tags with latest):
- gcloud container images add-tag gcr.io/istio-testing/build-tools:master-3a1982fd09c72f345f85d394d5cce906b5484b76 gcr.io/istio-testing/build-tools:release-1.23-3a1982fd09c72f345f85d394d5cce906b5484b76
- gcloud container images add-tag gcr.io/istio-testing/build-tools-proxy:master-3a1982fd09c72f345f85d394d5cce906b5484b76 gcr.io/istio-testing/build-tools-proxy:release-1.23-3a1982fd09c72f345f85d394d5cce906b5484b76

You can query tag like this
gcloud container images list-tags gcr.io/istio-testing/build-tools | grep master-latest
Next, checkout your fork of the test-infra project (making sure it's up to date with master first), gh auth login, create a new branch etc.  Then:

sudo make shell

go get github.com/kballard/go-shellquote then go get istio.io/test-infra/tools/prowgen/pkg -- don't commit the modified go.mod and go.sum from these commands

Generate the jobs: go run tools/prowgen/cmd/prowgen/main.go branch 1.23

Generate the private jobs: go run ./tools/generate-transform-jobs/main.go branch 1.23

In the job configs prow/**/*-1.23.yaml, replace any image build-tools(-centos|-proxy):master with build-tools(-centos|-proxy):release-1.23.  This is easy to do in VSCode, like this:

Remove duplicated env entries of the following in the configs (you can use a similar search in VSCode as above, but beware, it'll only match the indentation level that you specify if you have strict matching enabled.):
- name: BUILD_WITH_CONTAINER
  value: "0"

- Manually update [testgrid/config.yaml](https://github.com/istio/test-infra/blob/master/testgrid/config.yaml) by adding in the relevant entries for 1.23.  It's pretty obvious once you see the file what you have to do.  TBD - decide what to do with the previous entries - do we delete them?
- Run `make gen`

[x] Merge PR in istio/test-infra. Wait for it to complete. https://github.com/istio/test-infra/pull/5434

Automation Step 4
This step has a two steps:

Run the automation
Merge the PRs created by it, EXCEPT FOR ONE! As part of the STEP 4 PR post-submits, a new PR will be created in the istio/common-files repo with a title like: Automator: update build-tools<EMAIL_ADDRESS>in<EMAIL_ADDRESS>The work in this PR is only a portion of Step 5, and merging it will cause issues with reverting the repos to the main branch common-files. CLOSE this PR.

These are the PRs created by the automation for 1.23:

https://github.com/istio/ztunnel/pull/1210
https://github.com/istio/client-go/pull/2174#issuecomment-2231940190
https://github.com/istio/tools/pull/2987
https://github.com/istio/release-builder/pull/1902
https://github.com/istio/enhancements/pull/184
https://github.com/istio/istio/pull/52096
https://github.com/istio/api/pull/3266
https://github.com/istio/proxy/pull/5673

Command To Run
make shell
REPO_ORG=istio STEP=4 ./release/branch.sh

Legacy Manual Instructions

(Automation step=4) (new step since we want the automation from prior step to actually create the image after PR merges) PRS: 1 - istio/pkg 2 - istio/client-go 3 - istio/tools 4 - istio/common-files 5 - istio/enhancements 6 - istio/release-builder 7 - istio/istio 8 - istio/api 9 - istio/proxy 10 - istio/envoy

Updates istio/tools to build new release-1.19 build image (update BRANCH in docker/build-tools/build-and-push.sh. PR postsubmit will create new container images whose name will be used in the next step)
Update common-files in new release. You first have to manually update the common/Makefile.common.mk update-common target to point to the new release  (but not in common-files). In Step=5, the prow automation will actually call make update-common in these repos to do the actual make update-common against the new common-files release branch

istio/common-files - skipped. Covered in next step
istio/istio
istio/pkg
istio/api
istio/client-go
istio/proxy
istio/release-builder
istio/tools

Update CODEOWNERS to contain only the release managers for this release. Command: export org=xyz ; export repo=xyz ; (git clone git@github.com:${org}/${repo}.git && cd $repo && git checkout release-1.23 && git checkout -b release-1.23-codeowners && echo '* @istio/release-managers-1.23' > CODEOWNERS && git add CODEOWNERS && git commit -m 'Set release managers as CODEOWNERS for release-1.23' && git push --set-upstream origin release-1.23-codeowners).

istio/common-files  - skipped. Covered in next step
istio/istio
istio/pkg
istio/api
istio/proxy
istio/client-go
istio/tools
istio/release-builder
istio/enhancements

Stop publishing latest tags
Update istio/release-builder branch changes from master to new release in build.sh, publish.sh and manifests.

[x] Merge PRs from STEP 4. Wait for the new build images to be created at https://gcr.io/istio-testing/build-tools.
WARNING -- DO NOT MERGE As part of the STEP 4 PR post-submits, a new PR will be created in the istio/common-files repo with a title like: Automator: update build-tools<EMAIL_ADDRESS>in<EMAIL_ADDRESS>The work in this PR is only a portion of Step 5, and merging it will cause issues with reverting the repos to the main branch common-files. CLOSE this PR.

Closed PR: https://github.com/istio/common-files/pull/1026
Automation Step 5
Important: DO NOT START STEP 5 UNTIL ALL POST JOBS FROM STEP 4 IS COMPLETED
Command to run
make shell
REPO_ORG=istio STEP=5 ./release/branch.sh

Legacy Manual Steps

(Automation step=5) (new step since we need image from prior step)

Update istio/common-files to set release-1.23 build image (Update the UPDATE_BRANCH in files/common/Makefile.common.mk to be the new release name
Update IMAGE_VERSION in files/common/scripts/setup_env.sh  to be the new build image from prior step (found at https://gcr.io/istio-testing/build-tools).
Also Update CODEOWNERS to contain only the release managers for this release.

[x] Merge PR from STEP 5. Wait until step 5 PR merges and all the postsubmit generated PRs (to update common files in repos) merge.

Remaining Manual Steps
After the automation is complete, there are some manual steps that need to be completed to finish the branch cut

[x] Fix up proxy automated job to pull from correct envoyproxy release branch if possible (set UPDATE_BRANCH) https://github.com/istio/test-infra/pull/5316

[x] Verify that the github.com/envoyproxy/go-control-plane matches the latest commit before github.com/envoyproxy/envoy was branched. Easiest way to determine this is to go to the new envoy branch: https://github.com/envoyproxy/envoy/tree/release/v1.30 in this case, and click on commits behind main to find the commit where the branch happened. Then go to the main branch and find that commit. Finally go to https://github.com/envoyproxy/go-control-plane/commits/main and find the last commit (57c85e1829e6fe6e73fb69b8a9d9f2d3780572a5) made before the branch commit. Update in istio and proxy repos. 1.23 istio PR 1.23 proxy PR

[x] #52130

BASE_VERSION should update when a new base image is created (vulnerabilities scan fails)
UPDATE_BRANCH in update_deps.sh
[x] 1.23 istio PR
[x] 1.23 test-infra PR

[x] Bump 1.23 to 1.24 in the master branch

Update Istio: 1.23.0 to 1.24.0, 1.23-dev to 1.24-dev, etc:
[x] https://github.com/istio/istio/pull/52129

[x] Send an announcement on Discuss announcing branch cut complete and PRs can be merged again

[x] Ask istio.io team to run job to update to use the 1.23 branch (probably Daniel Hawton). Verify the EOL date for the n-2 release as 6 weeks after the planned release date. https://github.com/istio/istio.io/pull/15443

Publishing a Release
The next step is to publish a release.  You will need to follow these steps for each beta and release candidate and finally for the final release build.

[x] Publish a beta release (from https://docs.google.com/document/d/1ilwz-HGSeiRDCFwP5rm-5d_UY6OOYL_nflx7bNggek0/edit#heading=h.qex63c29z2to, builds on release branch are labeled beta. Updating below names to reflect that.

[x] Run bin/update_deps.sh in istio/istio
[x] Trigger a 1.23 beta.0 build https://github.com/istio/release-builder/pull/1830
[x] Some verification to verify build is good

You can download the build tar from the appropriate directory here: https://gcsweb.istio.io/gcs/istio-prerelease/prerelease/
untar the file and install, specifying the image repository. (ex: ./bin/istioctl install --set profile=demo -y --set hub=gcr.io/istio-prerelease-testing).
Run bookinfo from within the untar'd directory

[x] Publish a 1.23 beta.0 release

[x] Send an announcement on Discuss announcing availability of beta.

Generating a release candidate
When to start: 10-14 days before the release date
Use the Publishing a Release instructions above to update_deps, trigger the build, do verification and publish the release
Next, contact Sergii Shapar and ask him to run the long running tests on the build, and any subsequent release candidate builds if there winds up being more than one.
Preparing for final release
### When to start: 2 weeks ahead of the release date

[x] Verify the min and max K8s version supported for the release.

RMs usually determine the range of k8s versions and it appears on the TOC agenda at times. The max version is usually is the current K8s version and the min version is 3 past versions.

Generating the release notes

[ ] Prepare the release notes for the release.

Preparing the release notes for a major release is time-consuming; allow 4-5 hours across several days to factor in time for reviews.  An example PR for the 1.18 release notes is here
To generate the release notes, first make sure you have up-to-date forks of istio, API and tools repositories checked out to the same folder.  Specifically, they must contain the release-N and release-N-1 branches (where N is the version that you're working on, and N-1 is the previous one), so you must not have only forked the repos' master branches.
To generate release notes, run the command ./gen-release-notes --notes ../../../istio --oldBranch 1.17.0 --newBranch release-1.18 (against the istio/istio and istio/api repos). Follow the instructions from here.  This will get you text files that contain the contents of what will be the change-notes part of your PR (see the 1.18 PR above for what I mean)
The output of the tool will fail linting.  Once you've copied the content into the right place in your fork of the isio.io repo, run make lint then go get a cup of coffee.  Five to ten minutes later, you'll have a list of things that are wrong with the automatically generated content that you'll need to work through.  The biggest source of errors is that there cannot be more than one blank line between any line in the file, headers must be surrounded by blank lines, all istio.io links must be relative and that there will be trailing whitespace that will need removing.  To fix the last of these, run sed -i 's/[[:space:]]*$//' file.txt; this will clean up the trailing whitespace that will otherwise drive you slightly mad trying to find (since it's not always quite on the line indicated by the tool)

[ ] Each time you publish a beta/rc/official release build, make sure that the build/helm charts/images are published correctly to Istio release repo/Helm repo/gcr repo.
[ ] After official release, send out an announcement on announcement and release slack channel for Istio. Currently Craig Box handles all the twitter announcements related to Istio and he usually sends release related announcements on twitter. Coordinate with him. discuss, twitter
[ ] Update the description in the release slack channel to reflect the official release date.

This is done. Thanks everyone!


Syntax highlighting for unique node names is not working with inline annotations

Godot version
4.1.1
System information
Any
Issue description
When using unique names with annotations on one line, the unique name is not highlighted, but the script is still valid.

Steps to reproduce
Have an annotation and inline unique name like this:
@warning_ignore("unsafe_property_access") %MyLabel.text = "Hello World!".
Minimal reproduction project
reproduction.zip

I can confirm that the bug happens for me on android editor with:
Godot v4.1.1.stable • LineageOS 18.1 • 20230614-NIGHTLY • a5y17lte • Vulkan (Mobile) • integrated Mali-T830 • (4 Threads)

In this context, the %character is treated as a string remainder / formatting operator because it comes after the "operand" (close parenthesis). I don't think it's possible to fix this without a major refactoring of the highlighter. But I don't mean that this is a reason to close this issue, just clarifying that we probably shouldn't expect a fix soon.
To me, using inline annotations with statements looks like an undesirable style. This is ok with short definitions (like @onready and @export), but otherwise I prefer annotations on separate lines.

To me, using inline annotations with statements looks like an undesirable style. This is ok with short definitions (like @onready and @export), but otherwise I prefer annotations on separate lines.

I agree, but sometimes, you just have a lot of these lines and want to save space. That's how I discovered it.

but sometimes, you just have a lot of these lines and want to save space

In 3.x there is a warning-ignore-all comment. There is no analogue in 4.x yet, but there is a PR #76020.


missing download_dir for jars and files

When it comes to specifying the dependency jars, spark-operator no longer accepts
.spec.deps.jarsDownloadDir and .spec.deps.filesDownloadDir
since the betav2 version according to
https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/1469#issuecomment-1025400675
https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/1469
Is this deprecation intentional due to some better workaround?
OR
users need to specify things in the init-containers?
Thanks

I've used initContainer to get around this. @zhangminzhong


Support 1536 cube image for some mobile browser.

Description
No Work or Crash were reported on iOS9, Android 6.x (GalaxyS5, LG G5) when loading 1536px(=width) cube image.
Steps to check or reproduce

Load cube projection type image with width (=1536px)
Run on browser iOS9, Android 6.0 (Galaxy S5, LG G5)

Test

Image: test/manual/img/test_cube_1x6_LRUDBF.jpg
Image Size: 1536 x 9216

Target Device

[x] Galaxy S5 (Android 6.0.1)

Samsung Internet (6.4.10)
NAVER (8.5.1)
Chrome (65)

OK
OK
OK

[x] iPhone 5S (iOS 9.0 - 13A344)

Safari
NAVER (8.4.3)
Chrome (65)

OK
OK
OK

We've tested issued device and found latest PanoViewer is working well on issued device although G5 is not tested because we could not get LG G5 device.
There were too many changes and it's difficult to find what's the cause.
Any way we found it's resolved and will close this.


add timestep retry mechanism

This is an old idea, but was specifically inspired by the implementation in Castro (https://amrex-astro.github.io/Castro/docs/timestepping.html#retry-mechanism) and Quokka (https://quokka-astro.github.io/quokka/instability/):

If the post-update state does not satisfy the CFL-stable timestep that was computed pre-update, then go back and re-do the hyperbolic update with a new timestep $\Delta t/2$ where $\Delta t$ was the just-used value of the timestep. Repeat recursively if necessary, up to a maximum number of retries.

This may be implemented in Parthenon codes by:

I don't think the default driver is set up for that at all. But maybe you modify the downstream's EvolutionDriver subclass to tweak Execute and maybe SetGlobalTimeStep? There you have the power to just tweak tm.dt and re-run Step()

I think the basics would technically be very straightforward to implement by

adding an input/runtime parameter that enables this feature
adding a cons_orig field
adding a task that always backups cons to cons_orig
"hack" PreStepUserMeshWork (or similar) to directly update dt and revert t (both should be possible as directly chaning tm.dt was originally done for the RKL2 integrator)
adding a task that conditionally restore cons_orig
make the ConsToPrim checks a softfail

*BUT * the details might become ugly

we need to ensure that all reductions or data that is accumulated for an hst dump (or more generally stored in Params) is also backed up and restored
ensure that no mesh refinement is triggered on a failed step
output logic keeps working (or also ensure that no outputs are triggered)

Some of those piece might be fairly cleanly to fix/add upstream in Parthenon.


Allow parsing cast expressions.

Revival of https://github.com/jethrogb/rust-cexpr/pull/15.

@emilio @reitermarkus Would either of you be opposed to creating a fork of this PR minus the dependency on the new clang-sys and associated test changes?

@dpaoliello, I have given up on cexpr since it is way too limited. I have written a replacement (cmacro-rs) which supports much more complex macros.
Sadly no one has reviewed my PR at https://github.com/rust-lang/rust-bindgen/pull/2369 replacing cexpr with cmacro yet. Would love to get some feedback on it.


added binary-search-tree.py

A python program for binary-search-tree creation , insertion of nodes and traversal of the tree using breadth first search(which uses a queue)

@007DSJ , Please add desc!

@Haris-Mohanty Done !!


[UI] Profile (Donors) show reflect sum of stewards of each collective supported

i.e.
“Wonderful's funding supported {sum of all stewards paid from x collectives}”
“Towards this collective, supporting {# stewards paid in that collective}”

related to this question from @krisbitney - captured as a to-do in ticket 81


Foreground push notification arrives and then disappears from the status bar

In our application whenever the foreground notification arrives, it is displayed as a push notification on top but disappears after that.
We have added forceShow as true

@dipanshukapoor-sirion this is expected behaviour. iOS autohides foreground notifications by default, for Android logic emulates it.

Do we have some way to show local notification in such case? As user doesn't get enough time to click on the notification and it disappears

It's not a part of this plugin. I suggest to use forceShow:false and trigger rich notification in onMessage callback using plugin for local notifications.

Can you provide a small snippet on how to trigger rich notification?

Try https://github.com/katzer/cordova-plugin-local-notifications


Tooltip disappearing after first tap

Hey there! First of all, thanks for this cool library. It has been working great.
We are having an issue when displaying the tooltip the first time after the user opens the app.

The tooltip dissapears that first time. After that, it works correctly:

The code is simple:
export default class ContextMenu extends React.PureComponent {
  componentWillUnmount() {
    if (this.ref) {
      this.ref.hideMenu();
      delete this.ref;
    }
  }

  setRef = (ref) => {
    if (!ref) {
      return;
    }

    this.ref = ref;
    if (ref) {
      setTimeout(() => {
        if (this.ref) {
          this.ref.showMenu();
        }
      }, 100);
    }
  }

  render() {
    const actions = getActions(this.props);

    return (
      <ToolTip
        actions={actions}
        ref={this.setRef}
      >
        <View />
      </ToolTip>
    );
  }
}

Note that we had to introduce that delay because the tooltip doesn't appear when placed in componentDidMount.
I tried to debug this, as I thought that a hideMenu() was being called, but it wasn't. showMenu() is called correctly and then the context menu disappears without a call to hideMenu().
Any help would be appreciated, thanks!

@FranDepascuali did you find a way to solve this? it's happening with me too :/

@andrewdazs no longer working with RN, sorry!


Jenkins build server: PostgreSQL installer is not being copied

After build process completes the following folder is empty:
OPSServerInstall\Software\Database\PostgreSQL_9.2.2
Please compare with an Ops Server release and make changes accordingly.

Items manually copied to the UC build.  Changes have been made to build scripts, will test on next build.

9.2.2 folder is still empty. PostgreSQL_9.3.5 is being populated with the installers.  I will need to delete the 9.2.2 folder from copy source and or batch file that is creating the folder structure.

Database is being copied.


Support multiple routes

Is your feature request related to a problem? Please describe.
main-yaml example is using top level element route. it has the advantage to allow providing an id to the route.
https://github.com/apache/camel-examples/blob/main/examples/main-yaml/src/main/resources/routes/my-route.yaml
- route:
    id: "foo"
    from:
      uri: "quartz:foo?cron={{myCron}}"
      steps:
        - to: "bean:myBean?method=hello"
        - log: "${body}"
        - to: "bean:myBean?method=bye"
        - log: "${body}"

Describe the solution you'd like
support this other way of defining route
Describe alternatives you've considered
Additional context
this might be covered when supporting multiple routes? To be verified

Other examples I have seen:
routes:
  - from:
      uri: file:inputDir
    choice:
      when:
        xpath: "/order[@type='book']"
        to: file:bookOrderDir
      when:
        xpath: "/order[@type='music']"
        to: file:musicOrderDir
      otherwise:
        to: file:unknownOrderDir

camelContext:
  routeBuilders:
    - routeBuilder:
        from:
          uri: file:inputDir
        choice:
          when:
            xpath: "/order[@type='book']"
            to: file:bookOrderDir
          when:
            xpath: "/order[@type='music']"
            to: file:musicOrderDir
          otherwise:
            to: file:unknownOrderDir

camelContext:
  routes:
    - route:
        from:
          uri: file:inputDir1
        to:
          uri: file:outputDir1
    - route:
        from:
          uri: file:inputDir2
        to:
          uri: file:outputDir2
    - route:
        from:
          uri: file:inputDir3
        choice:
          when:
            xpath: "/order[@type='book']"
            to: file:bookOrderDir
          when:
            xpath: "/order[@type='music']"
            to: file:musicOrderDir
          otherwise:
            to: file:unknownOrderDir

Related https://github.com/KaotoIO/kaoto-ui/issues/801

still work in progress

Related pull request: https://github.com/KaotoIO/kaoto-backend/pull/638

@lordrip that pull request is merged. Is this issue closed?

Hi @delawen not yet, because we still need to support and we're not there yet
- route:
    id: "foo"
    from:
      uri: "quartz:foo?cron={{myCron}}"
      steps:
        - to: "bean:myBean?method=hello"
        - log: "${body}"
        - to: "bean:myBean?method=bye"
        - log: "${body}"

Now we have multiple route support like the one shown in https://github.com/KaotoIO/kaoto-backend/blob/main/camel-route-support/src/test/resources/io/kaoto/backend/api/service/step/parser/camelroute/route-with-id.yaml thanks to #706


Update to latest contracts - alpha 34

What's the different between the CompoundPrizePoolBuilder and the SingleRandomWinnerPrizePoolBuilder? Won't we only be calling one of these?


Improve Error Page

Improve the error page with a responsive and attractive UI.
I want to work on this issue under JWOC

Go for it @TuhinBanerjee31


Lint for Code of Conduct

How do we feel about adding "has a code of conduct" to the feature detection?

Is there a standard for the file name?

CODEOFCONDUCT / CODE-OF-CONDUCT is what I have seen

SGTM. you want to do it?
I can try and put together a first timer friendly issue, but not until tomorrow - earliest.

On mobile, so can't edit.
I meant if you don't want to do it.

I don't have the time now, but could maybe get to it Fri/Sat/Sun? :)
If you are able to prepare a first-timer-friendly issue, that'd be awesome. Thanks for your help!

@Charlotteis Welcome to Forkability, good to see you! :+1: :+1: :D
Code of Conduct sounds like a good idea. It might be something we should make a flag too - let's see how it plays out, some people might think it's a bit much. I'm actually not too familiar with existing code of conduct files people use. Do you know any good examples?
I'm sorta wondering how it might be different from a CONTRIBUTING file, I suppose it's more about community though right?

@basicallydan how do you feel about a third level of strongly suggested?
(although I think that should wait until #30  and related are taken care of)
As a reference here are some Code of Conducts I have bookmarked as nice examples (in my opinion at least)

http://www.openssl.org/community/conduct.html
https://golang.org/conduct
https://github.com/mono/mono/blob/master/code_of_conduct.md

E.G. Chai have just added one today, using the Contributor Covenant: https://github.com/chaijs/chai/blob/master/CODE_OF_CONDUCT.md

Also, hai :)

@Charlotteis see #79

closed with #84
Thank you @Charlotteis for your work


missing comma in orderBy when using two references

Hi,
version: 0.8.9 and 0.9.0
orderBy(ref("table.data:one"), ref("table.data:two"))
gives
order by "table"."data"#>'{one}' "table"."data"#>'{two}'.

Ha sunday mornings, sorry. It's orderBy(name, order).


Not generating Css retina output file

Currently I'm using this Grunt setup below:
sprite: {
	all: {
		src: '_img_sprites/*.png',
		retinaSrcFilter<EMAIL_ADDRESS>		dest: 'img/all-sprite.png',
		retinaDest<EMAIL_ADDRESS>		destCss: 'scss/modules/_sprite.scss',
		cssFormat: 'css',
		cssTemplate: 'hbs/sprite-template.hbs',
		imgPath: '/img/all-sprite.png',
		retinaImgPath<EMAIL_ADDRESS>		cssVarMap: function (sprite) {
			sprite.name = 'sprite-' + sprite.name;
		}
	}
},

But I'm missing some kind of retinaDestCss setting for a custom scss/modules/_sprite-2x.scss output file.
When running grunt I'm not getting any retina related (rendert) Css output. Just the regular Css rendert output with no mentioning of any for example Css background-image: url(/img/all-sprite@2x.png); retina version of the sprite.
What am I doing wrong? Is the retina Css concatenated to the destCss file? I did get a Grunt warning about a missing grunt-contrib-concat. I've npm install this missing plugin; but still no retina related Css.

Under normal circumstances, the destCss file will contain both normal and retina information/mixins/rules. Your setup seems to have some legacy from the non-retina version of spritesmith.
There are 2 problematic options you have which are causing problems:

cssFormat overrides the default template used. By specifying css you are forcing spritesmith to use the normal CSS template, not a retina one

This is documented in the retina parameters section: https://github.com/Ensighten/grunt-spritesmith/tree/4.5.1#retina-parameters

For your case, we would want css_retina

However, this parameter might be irrelevant altogether if you are using cssTemplate which is looks like you are

cssTemplate uses a custom defined template file. This means we load up the file and render our CSS based on that.

This is where your current destCss template is being generated from

To summarize your situation, your custom cssTemplate is likely the source of the problem and needs to be updated to support retina sprites. New parameters for retina cases can be found in the Templating section:
https://github.com/Ensighten/grunt-spritesmith/tree/4.5.1#templating
One other option is to ditch cssFormat and cssTemplate parameters and using the scss mixin for generating retina sprites.
// After importing autogenerated SCSS
@include retina-sprites($retina-groups);

The grunt-contrib-concat warning is likely another grunt task/configuration complaining.

Thanks for the tips. I've got a working version now (regular & retina) using custom Handlebar templates.


Remove font-awesome

We don’t really use many glyphs — could be get away with just SVGs for the few we do?

Yeah, I reckon that'd be good. Wonder if https://fortawesome.com would be worth a try. Only issue I can see is that the free option makes you CDN-serve. Otherwise we could just SVG the glyphs we use.

Hrm, I’d rather not have another external dependency. Ideally we could simply use inline SVGs in the few places we have these glyphs.

Have ripped out Font Awesome and replaced with a custom subset with only the glyphs we're using + bare bones CSS: https://github.com/icelab/berg-assets/commit/47b12bac1c384666d80659a407cfa60ce9f95b58

This seems reasonable to me, though I reckon we could still just use inline SVGs wherever you want to use these. Any reason for not doing that?

There's a bunch of places where I'm altering the size for different breakpoints and a couple of spots I'm altering the colours etc. Seems like a lot of work to me to inline these and have to replicate those style changes. Is there a bigger win we'd get with that approach?

I think that’d be pretty easy to do if you have a little wrapping div with those class changes — inline SVGs allow you to alter the appearance entirely in CSS.

Is there a bigger win we'd get with that approach?

The main win is just avoiding loading external resources all the time (even if they’re small).

Wouldn't we then be loading 6 or 7 SVGs versus a couple of font files? Sorry — just want to get my head around the approach first :)

Ah, that’s why I keep saying inline SVGs, not just SVGs. I mean literally writing the SVG into the template:
span.svg-wrapper.color-blue.bordercolor-red
  erb:
    <svg> ...

Oh, right! Sorry — I was reading that as an element in the template with SVG backgrounds. Yes, this is much nicer. Shall do.

@andyicelab Not quite sure how to do it in dry-web land, but we could also make some little helpers to make it easy to reuse these sort of things throughout.

Hey @makenosound — have ripped out the icon font and used the inline SVG technique instead.

@andyicelab Cool, happy to close this!


How to have static IP address in AWS Amplify App

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting questions.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
App is already hosted
AWS Region
us-east-1
Amplify Hosting feature
Build settings, Frontend builds
Question
I have site in react js on AWS Amplify and now I am adding a payment gateway, but payment company asking for the static IP address, so how to create static IP address in AWS Amplify App

Hi @zubair999 , thank you for opening this issue, unfortunately this isn’t currently possible. However, I am discussing this internally with the team and will follow up soon with more information.


Prisma Migrate Failure exposes database connection parameters

Bug description
Upon a permission failure in accessing the database, schema or tables, prisma migrate will error and expose the full database connection parameters to the logs.
How to reproduce
Steps to reproduce the behavior:

Setup PRISMA schema and adapter (I was connecting in node to postgres)
Create a migration
Run the migration but change the db permission to deny access
See error

Expected behavior
A database error without the credentials and connection properties being exposed
Prisma information
datasource db {
  provider = "postgresql"
  url      = env("POSTGRES_URL")
}

The error
actual values replaced with xxxx
with self=PostgresFlavour { url: PostgresUrl { url: Url { scheme: "postgresql", username: "xxxx", password: Some("xxxx"), host: Some(Domain("xxxx")), port: Some(5432), path: "/xxxx", query: Some("schema=xxx&statement_cache_size=0"), fragment: None }, query_params: PostgresUrlQueryParams { ssl_params: SslParams { certificate_file: None, identity_file: None, identity_password: <HIDDEN>, ssl_accept_mode: AcceptInvalidCerts }, connection_limit: None, schema: "xxxx", ssl_mode: Prefer, pg_bouncer: false, host: None, socket_timeout: None, connect_timeout: Some(5s), pool_timeout: Some(10s), statement_cache_size: 0 } }, features: BitFlags<MigrationFeature>(0b0) } connection=Connection(Postgres(PostgresUrl { url: Url { scheme: "xxxx", username: "xxxx", password: Some("xxxx"), host: Some(Domain("xxxx")), port: Some(5432), path: "/xxxx", query: Some("schema=xxxx&statement_cache_size=0"), fragment: None }, query_params: PostgresUrlQueryParams { ssl_params: SslParams { certificate_file: None, identity_file: None, identity_password: <HIDDEN>, ssl_accept_mode: AcceptInvalidCerts }, connection_limit: None, schema: "bambee-payroll", ssl_mode: Prefer, pg_bouncer: false, host: None, socket_timeout: None, connect_timeout: Some(5s), pool_timeout: Some(10s), statement_cache_size: 0 } }))

Environment & setup

OS: Alpine Docker
Database: Postgres (aurora)
Node.js version: 14.15.1
Prisma version: 2.19.0

I can confirm similar behavior for db push, see error message from https://github.com/prisma/prisma/issues/6277 which included the actual password instead of ....

This is bad — for now I will do a quick review of the migrate codebase to fix this and search for similar cases.
I also created an internal issue for us to spend time finding mechanisms to make sure it doesn't happen again.

@uptownhr https://github.com/prisma/prisma-engines/pull/1787 should fix this short term. As noted above we scheduled some time to ensure we have mechanisms in place to prevent this from happening again in the future.

The fix will be in tomorrow's release (2.20.0).


Is the current version of pgbm still compatible with the scikit-learn API?

Hi @elephaint:
Is the current version of pgbm still compatible with the scikit-learn API? I tried to import the wrapper, PGBMRegressor, but got an error:
from pgbm import PGBMRegressor
ImportError                               Traceback (most recent call last)
/tmp/ipykernel_22348/3286960087.py in
----> 1 from pgbm import PGBMRegressor
ImportError: cannot import name 'PGBMRegressor' from 'pgbm' (/data/home/r-yucao/.local/lib/python3.7/site-packages/pgbm/init.py)
Thank you.

Hi,
Yes, I did not make any changes and checked the source; PGBMRegressor is part of both pgbm and pgbm_nb. Perhaps a fresh reinstall should do the trick? (I suspect the init.py of pgbm has not been updated in your environment, but don't know why that happens).
Best,
Olivier

From: flippercy @.>
Sent: Tuesday, September 21, 2021 12:00:03 AM
To: elephaint/pgbm @.>
Cc: Olivier Sprangers @.>; Mention @.>
Subject: [elephaint/pgbm] Is the current version of pgbm still compatible with the scikit-learn API? (#6)
Hi @elephainthttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Felephaint&data=04|01||96701dbe838d413867bd08d97c82014a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637677720071768042|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=DjNU8pL7mgH3QV1uTXUPXIA2RMv2bpTraM0K9qu4wjM%3D&reserved=0:
Is the current version of pgbm still compatible with the scikit-learn API? I tried to import PGBMRegressor but got an error:
from pgbm import PGBMRegressor
ImportError Traceback (most recent call last)
/tmp/ipykernel_22348/3286960087.py in
----> 1 from pgbm import PGBMRegressor
ImportError: cannot import name 'PGBMRegressor' from 'pgbm' (/data/home/r-yucao/.local/lib/python3.7/site-packages/pgbm/init.py)
Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Felephaint%2Fpgbm%2Fissues%2F6&data=04|01||96701dbe838d413867bd08d97c82014a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637677720071777999|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Ttg%2FrWUQMd%2BYtLSxF0JXR1ZFt%2FHtcesoDX7ztXwTKvI%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKYHS4ACBJ2XELO5OM7VMVTUC6VGHANCNFSM5EM5IQAA&data=04|01||96701dbe838d413867bd08d97c82014a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637677720071787955|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PFHq9LS9ssoOImAIKiR4lBeJ5lThdXCWLpkga1vbUD0%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||96701dbe838d413867bd08d97c82014a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637677720071787955|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=iVqgVDzdJT1Fv5IE8Oj%2FbBOpGtUPpSpttZvCHxOAInY%3D&reserved=0 or Androidhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||96701dbe838d413867bd08d97c82014a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637677720071797911|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=MG0kvVLpWkZbVJQgZ82gxVvcVVOuqhtzaVPTlN6Ub3Q%3D&reserved=0.

@elephaint:
Thank you for the response. You are correct -- the problem disappeared after I re-installed the package.


similar resources carousel

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5878
Description (What does it do?)
This PR adds two ResourceCarousels to the new learning resource drawer based on the new "similar resources" APi endpoints. Both the opensearch and vector based results are displayed below the resource information.
Screenshots (if appropriate):

How can this be tested?

If you have Posthog set up locally, enable the lr_drawer_v2 flag
If you don't have Posthog set up locally, you can force drawerV2 to be true in LearningResourceDrawer.tsx
Spin up this branch of mit-learn
Generate vector embeddings by running docker compose exec web python manage.py generate_embeddings --skip-contentfiles --recreate-collections --all
Visit the search page at http://localhost:8062/search
View a variety of learning resources and ensure that the related resources carousels appear
Click the cards in the carousels to navigate to other learning resources and ensure that the drawer reloads with the new resource seamlessly

@shanbady This is ready for another look pending whatever @sovsey thinks we should do re: the empty space at the end of the carousel

@sovsey I'm going to merge this. If we decide we want to even out the amount of cards in the carousels as @shanbady suggested, I can put up a separate PR for that.


Hidden Power

Is it possible to change the color of Hidden Power on the moves list to show what type it is when you get it? Or another area in the tracker that shows what our HP typing is always?

Per Pie, we will not implement a feature that displays Hidden Power's type. If you figure out the type during game play, make use of the Notes feature to write it down.


How to view JSON files?

Excellent work on the chrome extension
How do I view the JSON files as if im reading messages
Opening it with NP++ just gives me 1 line of text and useless data
Thankyou

The JSON files weren't really made to be viewed manually. I intended them more to be used by any program you may want to write that can use your Facebook chat history.


Shorten spaces between products

If the spaces between the products were shorter you would be able to see more products straightaway which enhances the productivity.

@Sirove Could you elborate on that? Which spaces? Or could you maybe provide a screenshot?
Just want to make sure that we understand this issue correctly ;-)

@Sirove Thanks :)

Have a look how "Die Einkaufdliste" has done it:
https://play.google.com/store/apps/details?id=de.markusliebschner.thatlist

This would be a very nice enhancement.
Here's an example how it could look like.

Maybe the complete border could be thinner or totally removed.
I still hold the checked items at the bottom of the list, so there could be a visual separation between the unchecked items from top of the list and the checked ones at the bottom.
By the way, the border and the spaces between the lists at the lists page don't bother me, so these could stay in my opinion.
And thanks a lot for your app.

This would be a great enhancement

+1


Update migrate-dotnet-v3: Migration of JsonSerializerSettings

Internal msdata supportability work item task: 1806840:
V2 SDK allows users to set Newtonsoft.Json SerializerSettings at the operation level.
We should document the migration path:

Use Stream APIs and apply serialization on the resulting stream
Have a custom Serializer that does dynamic deserialization based on the type

@StefArroyo
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Closed, will be republished in the azure-doc-pr repo


added favourite colour input on 'reach us' page

With the "correct" spelling of "favoUrite" and "coloUr"

Great 👍


Trunk status functionality

Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Draft implementation of Trunk Status functionality, for now implemented both in SIP routing client as a function as well as separate TrunkStatus client, needs to be decided which one to use.
Does not contain changes from most recent API definition, see the .json for source swagger.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-communication-phone-numbers


Lower payload size limit and batch limit from 10 to 2

I want to lower the payload size limit and batch limit from 10 to 2, because I think they are too high.
This might solve the “Replication error” problem, since the IBM Cloudant lite plan has a 20 reads/sec and 10 writes/sec limit that is really easy to exceed.
I haven't tested it yet, but this is my idea.

hi

Thank you for opening this PR! This PR is very clear and works for specific scenes. So I will be happy to merge it!
However, if we set the lower batch size, requests will be performed more frequently. Since v0.22.0, the request interval is more solidly kept. Would you mind if I ask you to check that behaviour, please?
Unfortunately, if it does not work well, I am very sad to ask you this but could you please report it as the issue? You are always welcome to report back! Thank you so much for your contribution!


Unable to log in with default install

I am unable to get past the login screen on a default install of kanboard 1.0.22 using the username/password of admin/admin.
I am presented with the login prompt again, however it is now saying.
"The user name is required" and "The Password is required".
PHP is version 5.3 with mbstring, gd and pdo_sqlite modules enabled.
I have previously used kanboard before (around 1 year ago) so am confused to what is going wrong.
Error Log states the following:
PHP Warning:  session_start() [function.session-start]: The session id is too long or contains illegal characters, valid characters are a-z, A-Z, 0-9 and '-,' in /home/xxxxxxxx/public_html/taskboard/kanboard/app/Core/Session/SessionManager.php on line 48
I have tried both 1.0.22 and the latest nightly with the same results.
Have I missed anything?

Updating php to 5.6 and this issue has gone away


Rendering breaks when used with bevy_webgl2

I'm running the setup system from the readme example along with the bevy_webgl2_app_template.
In the native build, the shape renders properly.
In the wasm build, the shape is not visible on screen.
For giggles, we can add the shape to the webgl2 template scene. In native, the shape cuts the cube and plane in half as expected. In the wasm build, nothing renders at all!
For completeness, I've tested in Firefox and Edge.
When the shape is included, I see the following warning in the Edge console:
[.WebGL-0000177809F82080] GL_INVALID_OPERATION: It is undefined behaviour to have a used but unbound uniform buffer.
and in the Firefox console:
WebGL warning: drawElementsInstanced: Buffer for uniform block is smaller than UNIFORM_BLOCK_DATA_SIZE.
Though to be honest I don't know if these are relevant.

Given the latest news about the new renderer, I think it's best to wait for it, especially because bevy_webgl2 will be permanently broken by the new design (as bevyengine/bevy#2351 states).
However, if someone wants to fix this now, feel free to make a PR.

After spending too long fiddling around, I have no solutions but will say that I was wrong in including those warning messages. I don't see them in the first test scenario, so they appear to be unrelated.

I was able to reproduce this.
However, the main issue seems to be that bevy_webgl2_app_template is depending on an old release of bevy_webgl2. After updating that to 0.5.2, rendering generally works again.
There does seem to be some sort of issue when mixing in PbrBundles, and with strokes and 3d cameras. But I think the first thing is pretty likely to be a bevy_webgl2 bug and I don't know if very many people are trying to do that.

It seems bit odd, because it's my understanding thatbevy_webgl2 = {version="0.5.0", optional=true} should bring in 0.5.2.
But the steps of

Clone bevy_webgl2_app_template
Add bevy_protototype_lyon readme example (minus the 2d camera)
Build for web

Seem to get me
   Compiling bevy v0.5.0
   Compiling bevy_prototype_lyon v0.3.1
   Compiling bevy_webgl2 v0.5.0

And explicitly specifying
[dependencies]
bevy_webgl2 = {version="0.5.2", optional=true}

Makes things work
   Compiling bevy_webgl2 v0.5.2


Demo-App add INT as system to select

Change Label and probably the URL.

SBB needs to change Tyk or URL.

We did talk with others and found that the TEST instance is highly needed vor different things. Therefor we like to add a new instanace INT. The other 3 instances remain as is, just rename TEST LA as follows.

Connect it to: https://odpch-test.cloud.tyk.io/ojp-test/
Please place the radio buttons in the order: PROD, INT, TEST and LA beta (Please change "TEST LA" to "LA beta")


Website: Drop minima theme, fix RSS feeds

The work for this PR is to fix the RSS feeds on the ERCs website.
The problem was that the Jekyll Minima theme interferes with any custom RSS feed. (We use a custom RSS feed because people care about our ERCs, not changes to our other pages.) And therefore it was necessary for me to remove the Minima theme (and bump gem deps) to achieve this.
In this process I took the minor liberty of using the Bootstrap 5 CSS (which we were already using) to renter the header and footer rather than recreating dozens of Minima rules that we were previously relying on (and again which were duplicative to Bootstrap 5).
I did NOT take the liberty of fixing the header or footer, or all kinds of other problems with the site. I would like to do so, but that is not part of this minimal PR.

Here is what the page looks like. So you can see the slight update in style which is a side effect of this PR. And you can see the now working RSS feeds. Also the metadata on the pages linking to the RSS is fixed (and not visible in the screenshots).

Thank you for taking a look at this! I'll try to review this and merge it at some point. Is there a matching PR for EIPs? If not, don't worry about making one. I'll take care of it.
I am (very slowly) working on moving to Zola for rendering EIPs/ERCs. I'm not much of an HTML expert, but I have a theme that replicates the look of the current website. If you're interested, I'd love some help over there too!

I will need a slightly different fix for EIP repo. And I will do that.
But I need some momentum on my PRs getting merged to continue on this.

Hello hello. Can I please get a merge on this PR?

Hello hello. Can I please get a merge on this PR?

To see my current review queue, take a look at EIPs Insight.

I think this is a great direction. I am in favor of this PR to be merged. That said, is there a link we can try it?

Sorry we didn't set up webpage builds here for PRs.
But I did set up screenshots above, it works on responsive. And if there is something broken (even if I didn't break) you can see I'm quick to maintain things

Here is what the page looks like:
https://github.com/user-attachments/assets/2a08ae59-1d5b-42db-b54b-255e426d8f4e
The only visual change is in the header at top. This is demonstrated in the video by showing the header and then by showing another page which is not impacted.

@xinbenlv is this what you are looking for to review it?

Build instructions for this PR and for the project as normal:
bundle install
bundle exec jekyll serve --verbose --livereload

^ Those instructions should be in the readme. And I will propose that PR. But my PRs on this repo here are on hold until this PR is merged.


bg-gradient anomaly

UnoCSS version
0.64.1
Describe the bug
The bg-gradient property does not display correctly on iPhone 7 Plus.
The issue is caused by the --un-gradient-shape property in bg-gradient-to-([rltb]{1,2}), which defaults to in oklch.
This results in an error for background-image in older versions of Safari.
Reproduction
unocss/packages/preset-wind/src/rules
/background.ts: 90
System Info
This is the code I modified, adding some compatibility support.
    [
      /^bg-gradient-in-(oklch|srgb|lab)$/,
      ([_, v]) => ({
        '--un-gradient-shape-color-space': `in ${v}`,
      }),
      { autocomplete: 'bg-gradient-in-(oklch|srgb|lab)' },
    ],
    [
      /^bg-gradient-to-([rltb]{1,2})$/,
      ([, d]) => {
        if (d in positionMap) {
          return [
            ['--un-gradient-shape', `to ${positionMap[d]} var(--un-gradient-shape-color-space, )`],
            ['--un-gradient', 'var(--un-gradient-shape), var(--un-gradient-stops)'],
            ['background-image', 'linear-gradient(var(--un-gradient))'],
            ['background-image', `linear-gradient(to ${positionMap[d]}, var(--un-gradient-stops))`],
          ]
        }
      },
      {
        autocomplete: `bg-gradient-to-(${Object.keys(positionMap)
          .filter((k) => k.length <= 2 && Array.from(k).every((c) => 'rltb'.includes(c)))
          .join('|')})`,
      },
    ],

Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

You can use https://unocss.dev/presets/legacy-compat#legacycolorspace together.

You can use https://unocss.dev/presets/legacy-compat#legacycolorspace together.

If I directly use this method, although it works fine on older versions, the style will be lost in browsers that already support it.


Using jitsu-hammer without a hardware sound card

Hi Everybody!
Are there any configuration option in order to allow jitsi-hammer to run without a hardware sound card?
Using audiortpdump and videortpdump doesn't seems to help:
./jitsi-hammer.sh -audiortpdump ./ressources/rtp_opus.rtpdump -videortpdump ./ressources/rtp_vp8.rtpdump -users 5 -room TestHammer -MUCdomain conference.jitsi.mydomain.com -XMPPdomain jitsi.mydomain.com -XMPPhost jitsi.mydomain.com
...
ALSA lib pcm.c:2217:(snd_pcm_open_noupdate) Unknown PCM dmix
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fda69b200f8, pid=3052, tid=140576567928576
#
# JRE version: OpenJDK Runtime Environment (7.0_65-b32) (build 1.7.0_65-b32)
# Java VM: OpenJDK 64-Bit Server VM (24.65-b04 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libjnportaudio.so+0xd0f8]  Pa_GetDeviceInfo+0x58
...

Thanks for all!

I can't seem to get the hammer running in a Docker container because of the lack of a sound device.  I've installed alsa-base and alsa-utils and started the alsa-utils service before running the hammer.
I see the same stacktrace as the first one in ninioperdido's post above. Any ideas?


Upgrade Django / Python

First step is upgrade to Django 1.10, then 1.11.
Also upgrade to latest point release of Python 2.7


Update readme

Fix badge links
Remove text about syntax strictness that pertains to v1.x and replace with test about wdlTools strictness
Add limitations section
Mention CWL support is under development

the only change is a merge commit, so I am forcing the merge


feat: FCM User Token DocType

(Had to make another PR due to the Permission Changes to renovation_core made yesterday)

Added DocType FCM User Token

FCM User Token {
  user:  // the linked user
  token:   // the fcm token
  linked_sid: // the sid to which this token has to be linked with
  last_updated: yyyy-mm-dd hh:mm:ss // the last register call of the same token
}

Updated utils/fcm.py methods
get_client_tokens() will give list of Tokens that are valid (after filtering off those tokens that are linked to an expired sid)

@assemmarwan this has been live in getcar-v13 for like 4days now 😄

@faztp12 Is ignore_permissions not needed for the other frappe.delete_doc calls?


Optimize display of large DynamicMap parameter space

As described in https://github.com/ioam/holoviews/issues/2645, a DynamicMap with a large parameter space can be very slow to initialize, this is because we have started to process its keys more consistently but did not take into account the fact that the DynamicMap parameter spaces can be much larger. This now avoids a number of computations that are not necessary and optimized some others:
def test(t, z, cmap, vmin, vmax):
    return hv.Image(np.random.rand(100, 100))

dmap = hv.DynamicMap(test, kdims=['t','z', 'cmap', 'vmin','vmax']).redim.values(t=range(10), z=range(10) ,cmap=['viridis','Greys'], vmin=range(100), vmax=range(100,200))

This DynamicMap defines a parameter space with 2 million keys, previously this would take 52 seconds to display, with this PR this drops to 0.5 seconds.

@jlstevens Another good reason to get a 1.10.3 release out.

I've made one comment and I'm not sure whether you are done with it, but at a glance this PR seems fine.

Ready to merge.

Looks good. Merging.


[GSoC Proposal] Cloud-native KV-service

Explore cloud-native design for distributed KV-service that is cost effective. Investigate using different storage backend (local/persistent SSDs, EBS, S3, etc) to store TiKV data, and their pros and cons.

Hello @yiwu-arbug ,I'm interested in this project, and I'd like to take part in it. What I can do to start

@closetool sent you a message on slack. please check. thanks.

Hey @yiwu-arbug I am also interested in the project.

@de-sh Please join #gsoc-2020 channel in tikv-wg slack (tikv-wg.slack.com) and introduce yourself. We will guide you through the process. Thanks.

@Little-Wallace had composed a detailed project plan: https://docs.google.com/document/d/1rEmexICjwWe02XHWOGqNBs6zA6QpFh11d-XBt5Pvp8M/edit?usp=sharing
cc @de-sh


[DO NOT MERGE] Enable strict concurrency

Motivation:
Catch potential data races at build time.
Modifications:

Enabled strict concurrency checking in the Package.swift.
Fixed up one test that emitted a concurrency warning.

Result:
Fewer potential data races can sneak in.
Test Plan
Library and tests build without concurrency warnings, but I wasn't able to run tests, they hung (both before and after my change), so that might need to be resolved separately first.

Don't merge yet, wait for CI updates.


Documentation Example for Checkboxes

I'll mark this when it is ready for review, but this will be an documentation example on how to use Checkboxes in Stipple with StippleUI.

hey @TheCedarPrince thanks for the contribution. Can you please make any example demo contribution to Stipple Demos ?


add wasm-bindgen feature that activates the time crate's wasm-bindgen feature

This is useful, because functions such as Utc::now() don't work in webassembly imported on nodejs otherwise.
(I'm presently working around this by using the sign_with_time function)

LGTM

Thanks for the PR! I'll try making a release later in the day


Automatic code indenting

In AML Studio 1.2.1 it was possible to indent the AML via CTRL+T. Please add this functionality to this version.

Fixed by merging your pull request.


Pythran results are different from Python ones

I'm doing a benchmark of this code
#pythran export main()
from math      import sqrt
#from sys       import argv
import numpy

def eval_A(i, j):
    ij = i+j
    return 1.0 / (ij * (ij + 1) / 2 + i + 1)

def eval_A_times_u(u):
    local_eval_A = eval_A

    n = u.shape[0]
    # output is n items
    iis = numpy.arange(n)
    iis = numpy.reshape(iis,(n,1))
    j = numpy.arange(n)
    j = numpy.tile(j,(n,1)) # j is a matrix. Every row is [ 0, 1, 2, ...]
    u_j = numpy.tile(u,(n,1))
    output = numpy.sum(local_eval_A(iis,j)*u_j,axis=1)
    return output

def eval_At_times_u(u):
    local_eval_A = eval_A

    n = u.shape[0]
    # output is n items
    # each item is sum of things in loop
    iis = numpy.arange(n)
    iis = numpy.reshape(iis,(n,1))
    j = numpy.arange(n)
    j = numpy.tile(j,(n,1))
    u_j = numpy.tile(u,(n,1))
    output = numpy.sum(local_eval_A(j,iis)*u_j,axis=1)
    return output

def eval_AtA_times_u(u):
    return eval_At_times_u(eval_A_times_u(u))

def main():
    n = 550 #int(argv[1])
    u = numpy.ones(n)
    local_eval_AtA_times_u = eval_AtA_times_u

    for dummy in range(10):
        v = local_eval_AtA_times_u(u)
        u = local_eval_AtA_times_u(v)

    vBv = numpy.sum( u * v )
    vv = numpy.sum( v * v )

    #print("%0.9f" % (numpy.sqrt(vBv/vv)))
     return numpy.sqrt(vBv/vv)

#if __name__ == "__main__":
#    main()

found here: https://pybenchmarks.org/u64q/program.php?test=spectralnorm&lang=nuitka&id=3
And getting a strange results:
In [19]: spectralnorm.main()
1.042641308
In [20]: spectralnorm.main()
1.042641425
The expected answer is:
main()
1.274224125
So the results of pythran not just wrong but also changing from one run to another.
I use the latest available pythran from pip ang gcc-4.9.2
Please help me understand what I'm doing wrong.
Thanks.

Hi thoth291. At first glance, that's a pythran bug. I'll investigate and tell you more :-)

got it, your code relies on a kind of broadcasting not supported by pythran. I got a patched version that run x3 times faster when compiled with pythran, keep in touch :-)

Hi, Serge.
Thank you very much for this!
BTW, you might be interested in that benchmark list at that website.
The reason that I started looking into it is a project which I'll not name here but it's ending with "ka".
My friends from Intel pointed me to it due to the fact that I suggested them to support Pythran in their Intel Python distribution. If you want to convince them I suggest you to get access to Intel Compiler and write a page or two about how tweak Pythran to be compiled and worked with Intel.
I'll continue to suggest them Pythran any way - but official assistance from your side might be helpful.
All the Best,
Thoth.

Your code runs correctly with the following implementation that performs the broadcasting manually (at some point pythran should support it, but that's far from easy :-/)
def eval_A_times_u(u):
    local_eval_A = eval_A

    n = u.shape[0]
    # output is n items
    iis = numpy.arange(n)
    iis = numpy.reshape(iis,(n,1)).repeat(n, axis=1) #FIXME: manual repeat
    j = numpy.arange(n)
    j = numpy.tile(j,(n,1)) # j is a matrix. Every row is [ 0, 1, 2, ...]
    u_j = numpy.tile(u,(n,1))
    output = numpy.sum(local_eval_A(iis,j)*u_j,axis=1)
    return output

def eval_At_times_u(u):
    local_eval_A = eval_A

    n = u.shape[0]
    # output is n items
    # each item is sum of things in loop
    iis = numpy.arange(n)
    iis = numpy.reshape(iis,(n,1)).repeat(n, axis=1)  #FIXME: manual repeat
    j = numpy.arange(n)
    j = numpy.tile(j,(n,1))
    u_j = numpy.tile(u,(n,1))
    output = numpy.sum(local_eval_A(j,iis)*u_j,axis=1)
    return output

You need to wait for #527 to be merged though.

If you want to convince them I suggest you to get access to Intel Compiler and write a page or two about how tweak Pythran to be compiled and worked with Intel.

Last time I checked, icpc support for C++11 was not enough to compile pythran. Your advices are good and I'll check again. If everything is working fine, I'll keep you in touch :-)

Thanks, Serge.
I see that.
I tried your source code and that failed with my pythran (messages attached).
fails.txt

That's expected ;-)

You need to wait for #527 to be merged though.

@thoth291 I did some testing with a recent version of icc I get through their open source sponsorship. It turns out they do not support several features from C++11 we need for pythran, but maybe that could be fixed by changing the pythran code.
For a basic example, it compiles pythran-generated code fine, but generates much slower code than clang and gcc...

Ok. If you haven't notified them about your test results - let me know - I'll give them a message :-)
Thanks!

On Tue, Feb 09, 2016 at 12:15:52PM -0800, Anar Yusifov wrote:

Ok. If you haven't notified them about your test results - let me know - I'll give them a message :-)
Thanks!

 But
if you have an entry point there, I can surely provide more data!

I surely do have an entry point for a while (while my project is ongoing). Please provide some more data and tests. They should include the way how you compiled the pythran, dependencies and tests. Unfortunately it includes doing the same for icpc, g++ and clang. You can post them here (at the github) in markdown - I'll point Intel people to look at it. I personally use intel compilers all the time and knowning what can slow them down is a big thing for me - thanks!

I opened a thread on their forum and everything is going in the right direction!
https://software.intel.com/en-us/forums/intel-c-compiler/topic/623633

@thoth291 your issue was fixed in #563 , your code now compiles fine and returns the correct result. It also runs 1.75 times faster than the original version.


Question: SaaS UI self-hosting

Hi,
first of all thanks for developing such a great project.
I'm not sure if this is the right place to ask a question but since I'm not having Discord I wanted to give it a try. Feel free to close the issue in case it isn't appropriate.
Now to my question... is it planned to make the SaaS UI available for self hosting? Another user asked for it in the discussion section but there hasn't been any reply since January and the upvotes indicate that this is a feature people would love to see :-)
Best Regards,
FrittenToni

Hi @FrittenToni , Thank you for opening this issue and asking your question. Please do not hesitate to open issues and ask questions in the future :)
Yes! we have in our roadmap open-sourcing the portal and all other components. Unfortunately there is a lot of work to be done before we open source the portal so this might take some time.
We will be open-sourcing the kubescape helm microservices source code in the close few weeks 😇
Thanks for linking the question asked in the discussion session, I answered the question there as well so I will close this issue.

@FrittenToni DM me (email or twitter). I could not find your contact details. I have some UI already, for own purposes.


parent_id in Files.create() should be folder_id

This style is more consistent since we are referring to the company and project with company_id and project_id

Resolved with #27


add keyboard initialization to maps - for enabling moderator state in maps list

after it is done, than we should remove:
forcing moderator state upon opening mapsList
forcing non-moderator state upon going from mapList to the map

DONE i.e. removed:

forcing moderator state upon opening mapsList
forcing non-moderator state upon going from mapList to the map


Cosmosdb soft delete

Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[ ] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #5 into master will increase coverage by 2.21%.
The diff coverage is 77.2%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   75.56%   77.78%   +2.21%
==========================================
  Files         145      168      +23
  Lines        6896     7867     +971
  Branches      426      533     +107
==========================================
+ Hits         5211     6119     +908
- Misses       1685     1748      +63

Impacted Files
Coverage Δ

...che/openwhisk/core/connector/MessageConsumer.scala
83.56% <ø> (ø)

...enwhisk/core/containerpool/docker/RuncClient.scala
100% <ø> (ø)

...org/apache/openwhisk/core/entity/MemoryLimit.scala
93.33% <ø> (ø)

.../scala/org/apache/openwhisk/core/entity/UUID.scala
90.9% <ø> (ø)

...cala/org/apache/openwhisk/core/entity/SemVer.scala
95.83% <ø> (ø)

.../openwhisk/core/entitlement/ActionCollection.scala
100% <ø> (ø)

...a/org/apache/openwhisk/core/entity/WhiskAuth.scala
100% <ø> (ø)

...rg/apache/openwhisk/core/entity/WhiskTrigger.scala
100% <ø> (ø)

...core/database/cosmosdb/RxObservableImplicits.scala
100% <ø> (ø)

...rg/apache/openwhisk/core/controller/ApiUtils.scala
66.66% <ø> (ø)

... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6864b8...96fdaa0. Read the comment docs.


Update to 0.1.2

Changes:

New feestock, update to 0.1.2

Note: dev_url is not provided as the whole repository is private. The source of this particular package are however public on pypi.

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:21: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: clone/recipe/meta.yaml:52: missing_dev_url: The recipe is missing a dev_url
Errors were found


NumberBox - Added ValidationErrors to ValueProperty

This PR enables validation errors in the NumberBox control.

I took extra care not to break the placement of the spinner in both compact and inline.
I'm sorry about the changes in tabs/spaces in axaml files. I couldn't for the life of me wrestle my IDE into matching the existing pattern.

Great! I still don't understand why the data errors aren't automatically inherited to the TextBox to handle it, but whatever. No worries on the IDE gone crazy with the spacing.
Also FYI, all the current sample pages are being scrapped as part of my overhaul of the Sample App, but I will try to copy over your validation example into the new page.

Good stuff, don't worry about the sample app I just threw it in there to make sure it actually works with validation errors :)


if I can edit the text and Emoticons like in html editor? make it be editable

I only see the ngEmbed is for show, how can i edit it's content like in html editor? for example, I want use it in a comment box, any help?

This can be done with content-editable div. However, when a text is converted to html, the cursor position would change. This can be handled with rangy library. @ritz078 please have a look at this PLUNKER for reference.

I would definitely appreciate some help on this both for this library and embed.js

A quick (and dirty) suggestion is placing an (absolute positioned) textarea (with transparent background) on top of an ng-embed and show/hide the ng-embed with ng-if (to trigger a redraw) (it's best to also change the text color of the textarea to transparent, but keep in mind that some browsers/platforms also change the cursor color to transparent in that case) based on user input (ie. 1s timeout to show and hide again on keydown/mousedown/input/etc)... The downside is you have to take care of spacing and height (otherwise the textarea would collapse to 0. I actually use a similar approach combined with a mirror  element to autogrow my textarea whilst typing (up to a max height). The upside is that you don't have to fiddle around with contenteditable and the original text remains intact whilst typing (so you can change it in case a certain combination get's accidentally converted (maybe a :) combo)


Add support for VirtualNetwork

What problem are you facing?

crossplane-provider-packet does not currently support provisioning virtual networks on Packet.
How could the Packet Crossplane Provider help solve your problem?

Add v1alpha1 support for VirtualNetwork in the vlan.packet.crossplane.io group.

The VirtualNetwork name maps well to Packet API endpoint: https://www.packet.com/developers/api/vlans/#vlans-createVirtualNetwork
VLAN is also an option, which aligns with the Terraform resource name (a non-goal): https://www.terraform.io/docs/providers/packet/r/vlan.html#argument-reference


Bot Not Responding, But Online

Hey there! I was just curious if there is something I am missing about getting the bot set up for my server, or if the bot is just not working in general. I have tried -help, -tutorial, and -configure, but the bot is unresponsive with all of them. Thank you!

I'm sorry for the very late response - for some reason I am not getting notifications for this repository. The bot should always respond to the commands you mentioned, is the error still occuring? Maybe it doesn't have permission to send message?


So Whenever I Open Freeplay I Get This Error Messasge

Describe your problem here.

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x86/x32
Did you edit anything in this build? If so, mention or summarize your changes.
I Added The Charachter Holy Mami And Then I Tried To See If The Character Worked And When I Went To Freeplay I Get This Message And Then It Closes My Game, Plz Help

Make sure you put the character inside "characters", if you put it inside "weeks" then haxe explodes itself.

Thanks For The Help :)
(This Solved My Problem, Thanks)


Refactor notification code

With Android 7.0 there's no longer a clear distinction between "device notifications" (summary) and "wear notifications" (individual messages). So we should rename the classes and identifiers we use internally.
I also want to refactor the notification code to make it less awkward to test.

Also the device notifications class really only seems to generate  New Mail notifications - other types of notifications are handled separately. That makes it more confusing to reason about.


(SERVER-1084) pre-docs for initial HUP support

@gguillotte here's a rough cut at this stuff.
If you're good with these as 'pre-docs' then we can merge this and I'll assign the ticket back to you so that you can get them into a state you're happy with?

@cprice404 :+1:


Node.js debugging async/await with Babel transpilation not working, breakpoints jumping

VSCode Version: Version 1.21.0-insider (1.21.0-insider)
OS Version: MacOS 10.13.3

Steps to Reproduce:

Open up babel node project using async/await (I'm not sure I can share my whole codebase right now but I can try to create an example project if needed)
Try to set breakpoints in or step in async functions

Expected behavior - I can step through the code as normal debugging steps
Actual behavior - breakpoints jump to function declaration line
Note - When I remove async/await from code, debugging works as expected.

Does this issue occur when all extensions are disabled?: Yes
Launch.json
{
  "version": "0.2.0",
  "configurations": [
    {
      "type": "node",
      "request": "attach",
      "name": "API",
      "address": "localhost",
      "sourceMaps": true,
      "restart": true,
      "smartStep": true,
      "port": 9229,
      // "preLaunchTask": "npm: build - api",
      // "runtimeExecutable": "${workspaceFolder}/api/node_modules/.bin/babel-node",
      // "program": "${workspaceFolder}/api/src/app.js",
      "outFiles": [
        "${workspaceFolder}/api/build/**"
      ],
    },
  ]
}

Package.json scripts section
  "scripts": {
    "start": "nodemon --exec node_modules/.bin/babel-node src/./bin/www | bunyan",
    "debug": "npm run build && DEBUG=*,-babel nodemon src/./bin/www --exec node_modules/.bin/babel-node --inspect | bunyan",
    "build": "rm -rf build/ && babel src -d build --source-maps",
    "compile": "rm -rf build/ && babel src -d build --source-maps --watch",
    "test": "echo \"Error: no test specified\" && exit 1",
    "lint": "eslint ."
  },

.babelrc
{
  "presets": ["env"],
  "sourceMaps": true
}

Update. Example of function where breakpoints can't be set. Almost any line I try to set a breakpoint on, the breakpoint puts itself on the exports.createUser line.
exports.createUser = async (request, response) => {
  try {
    const hasValidationErrors = await createUserValidationCheck(request);

    if (hasValidationErrors) {
      logger.info('Create user attempt had validation errors');
      return response.status(422).send(hasValidationErrors);
    }

    const {
      email,
      password,
      fullName,
      displayName,
      accountType
    } = request.body;

    let user = await new User({
      email,
      password,
      fullName,
      displayName,
      accountType
    });

    user = await user.save();

    const tokenForUser = await AuthenticationController.tokenForUser(user);

    return response.status(200).json({
      user,
      token: tokenForUser
    });
  } catch (err) {
    const uuid = uuidv1();
    logger.error({ err, uuid });
    return response.status(500).json(err);
  }
};

Most likely this is a problem of the generated source maps and nothing we can fix.
@roblourens correct?

@weinand Meaning this is an issue or potentially bug with how Babel has decided to generated their source maps?

Yes, the source maps are the only information that we have for mapping back JS to the original source. Tools exist that visualize how JS maps to source.

Makes sense, bummer. I'll look into opening this issue against them. Seems like it is only around async/await, found one other issue https://github.com/babel/babel/issues/2515 talking about in relation to Babel but they closed it as not actionable. Do you happen to know if there is a spec where I can point them to specifically what is not implemented correctly?

Can you try it in chrome devtools and see whether it's any better than VS Code?

.babelrc
{
"env": {
"development": {
"sourceMaps": true,
"retainLines": true
}
},
"presets": [
"es2015"
]
}
Then it works!
babel sourceMaps has some problem,I guess
thank you very much.
@roblourens

Spent awhile investigating this and other babel-related complaints. Couldn't find any difference between the vscode and chrome devtools experiences, across different babel setups. So I'll continue to close these as just weird sourcemaps from babel.


Revert "Update content scope scripts to version 6.43.0 (#5403)"

Task/Issue URL: https://app.asana.com/0/414730916066338/1209021936559905/f
Description
Reverts update CSS 6.43.0
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#5420  👈 (View in Graphite)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Closing as @shakyShane is looking into it and reverting privacy dashboard changes only


a little error in the documentation, where can I fix and PR?

:no_entry_sign: INVALID :no_entry_sign:
Hi
I referred to the sample code provided at https://pkg.go.dev/gonum.org/v1/gonum/fourier to implement FFT2D, and I found that the code example in the documentation is incorrect. The example uses an 11x11 image as input, but there's an error when the number of rows and columns are different. I modified the code as follows. Is there someone specifically responsible for maintaining this, or can I submit a PR to a particular repo?
If you run code with different cols and rows (ex: 11x10 matrix) in doc sample. You will get error message "panic: fourier: sequence length mismatch"
func main() {
	// Image is a set of diagonal lines.
	image := mat.NewDense(11, 10, []float64{
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
		1, 0, 0, 1, 0, 0, 1, 0, 0, 1,
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
		1, 0, 0, 1, 0, 0, 1, 0, 0, 1,
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
		1, 0, 0, 1, 0, 0, 1, 0, 0, 1,
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
	})

	// Make appropriately sized complex FFT.
	// Rows and columns are the same, so the same
	// CmplxFFT can be used for both axes.
	r, c := image.Dims()
	cfft := fourier.NewCmplxFFT(r)

	// Perform the first axis transform.
	rows := make([]complex128, r*c)
	for i := 0; i < r; i++ {
		row := rows[c*i : c*(i+1)]
		for j, v := range image.RawRowView(i) {
			row[j] = complex(v, 0)
		}
		cfft.Coefficients(row, row)
	}

	// Perform the second axis transform, storing
	// the result in freqs.
	freqs := mat.NewDense(c, c, nil)
	column := make([]complex128, r)
	for j := 0; j < c; j++ {
		for i := 0; i < r; i++ {
			column[i] = rows[i*c+j]
		}
		cfft.Coefficients(column, column)
		for i, v := range column {
			// Center the frequencies.
			freqs.Set(cfft.UnshiftIdx(i), cfft.UnshiftIdx(j), scalar.Round(cmplx.Abs(v), 1))
		}
	}

	fmt.Printf("%v\n", mat.Formatted(freqs))

}

Here is my fix version:
func main() {
	// Image is a set of diagonal lines.
	image := mat.NewDense(11, 11, []float64{
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 1,
		1, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0,
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 1,
		1, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0,
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 1,
		1, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0,
		0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0,
		0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 1,
	})

	// Make appropriately sized complex FFT.
	// Rows and columns are the same, so the same
	// CmplxFFT can be used for both axes.
	r, c := image.Dims()
	cfftCol := fourier.NewCmplxFFT(c)
	cfftRow := fourier.NewCmplxFFT(r)

	// Perform the first axis transform.
	rows := make([]complex128, r*c)
	for i := 0; i < r; i++ {
		row := rows[c*i : c*(i+1)]
		for j, v := range image.RawRowView(i) {
			row[j] = complex(v, 0)
		}
		cfftCol.Coefficients(row, row)
	}

	// Perform the second axis transform, storing
	// the result in freqs.
	freqs := mat.NewDense(r, c, nil)
	column := make([]complex128, r)
	for j := 0; j < c; j++ {
		for i := 0; i < r; i++ {
			column[i] = rows[i*c+j]
		}
		cfftRow.Coefficients(column, column)
		for i, v := range column {
			// Center the frequencies.
			freqs.Set(cfftRow.UnshiftIdx(i), cfftCol.UnshiftIdx(j), scalar.Round(cmplx.Abs(v), 1))
		}
	}

	fmt.Printf("%v\n", mat.Formatted(freqs))

}

This is not an error. Note the comment here.

Rows and columns are the same, so the same CmplxFFT can be used for both axes.

The code is an example, with an informative comment explaining a potential optisation that is available in the particular situation that the example covers. It is up to the reader to understand the comment and adjust their code to the situation that they have. The case where the row and column transforms cannot be the same is demonstrated for the real FFT in Example_fFT2 (admittedly artificially different, but still easily generalisable).


Show start and end offset in DirectorShot

We currently have prepending and trailing time to record in a directorshot, but we do not show this to the user in the gui or the input fields.

Made this in #172 . May still need some styling

Solved in #172 like menno said


RLMArrayand RLMResults iteration in swift 4 does not compile

Goals
Use RLMArray and RLMResults from Swift 4 code.
Expected Results
Use RLMArray and RLMResults from Swift 4 code like in Swift 3.
Actual Results
Compilation error:

For loop: Type '(RLMArray<Profile> & ProfileProtocol)?' does not conform to protocol 'Sequence'
forEach(): Value of type '(RLMArray<Profile> & ProfileProtocol)?' has no member 'forEach'

Steps to Reproduce
Create a simple RLMObject subclass containing an RLMArray property and iterate on that property from Swift 4 code.
Code Sample
Full project can be found here
There's two targets, one for Swift 3 (which compile and run) and one for Swift 4 which does not compile.
The last commit was tested on Xcode 10 with Realm 3.9.0, same results on Xcode 9.4.1.
Version of Realm and Tooling
Realm framework version: v3.9.0
Realm Object Server version: n/a
Xcode version: 10.0 (GM)
iOS/OSX version: Any
Dependency manager + version: Carthage 0.30.1

Turns out our tests for using obj-c models from Swift don't include a test for enumerating an RLMArray with a generic type specified. Whoops.

This looks like an awkward consequence of how compound protocols work. The type (A & B) conforms to the protocols which A and B conform to, except for ones with static requirements. Sequence has static requirements, so this means that RLMArray<Profile *><Profile> doesn't conform to Sequence even though RLMArray<Profile *> does.
I don't know if there's a good solution to this. At the call site, you can cast to RLMArray to make it work (e.g. for profile in account.profiles as RLMArray<Profile> { ... }). Maybe we could expose a macro that lets you declare arrays as something like @property RLM_GENERIC_ARRAY(Profile) *profiles; which would hide the protocol from Swift?

I didn't think of just casting but I guess some macro would be ok.

Hi, I am running into an issue with this. Are there any workarounds for this? I have the current models defined:
@interface UploadOrderFileStatus : RLMObject

@property NSString * compositePrimaryKey;
@property NSString * orderId;
@property NSString *deviceFilePath;
@property double completionStatus;
@property NSInteger filesize;

@end
RLM_ARRAY_TYPE(UploadOrderFileStatus)

@interface UploadOrder : RLMObject

@property NSString *orderId;
@property int productType;
@property int totalFiles;
@property int uploadedFiles;
@property RLMArray<UploadOrderFileStatus> *fileStatuses;

@end

Doing something like
for profile in account.profiles as RLMArray<UploadOrderFileStatus>

doesn't work and I am still getting
"Cannot convert value of type '(RLMArray & UploadOrderFileStatusProtocol)?' to type 'RLMArray' in coercion"


WebRTC not work with IPv6

Which version are you using?
v1.6.0
Which operating system are you using?

[x] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
I deployed MediaMTX on a server with dual stack IP and a NAT. (actually a homelab)
And I set up port forwarding to expose 8189 and 8889 with both tcp&udp, and then DDNS to the server.
e.g. v4.example.com and dualstack.example.com
The former has only A record and the latter has both A and AAAA record
When using dual stack host, clients prefer to use IPv6, which should be a good thing
However, I found that whip/whep connections through IPv6 does not work well, while IPv4 does
Seems that only handshakes can be established, stream data are not transfered:
2024/04/11 16:39:48 INF [WebRTC] [session 556ebd06] created by [Client IPv6 Address]:4045
2024/04/11 16:39:59 INF [WebRTC] [session 556ebd06] closed: deadline exceeded while waiting connection

An example of IPv4 working config:
webrtcLocalUDPAddress: :8189
webrtcLocalTCPAddress: ''
webrtcIPsFromInterfaces: no
webrtcIPsFromInterfacesList: []
webrtcAdditionalHosts:
  - v4.example.com
webrtcICEServers2: []

IPv6 does not work whatever I set in config, as long as I use the dual stack host in webrtcAdditionalHosts
webrtcLocalUDPAddress: :8189 or ''
webrtcLocalTCPAddress: '' or :8189
webrtcIPsFromInterfaces: no or yes
webrtcIPsFromInterfacesList: [] or enp2s0
webrtcAdditionalHosts:
  - dualstack.example.com
webrtcICEServers2: [] or Google STUN Server

Describe how to replicate the issue

Start the server
Publish with OBS/Browser
Read with Browser

By the way, I tried on multiple devices:
Publish:

OBS 30.1.2 on Win & Linux
Chrome on Win, Linux, and iPad

Read: Chrome on Win, Linux, iPad, and Android

Did you attach the server logs?

yes

Notice that I use caddy to mux the live and api
So that the log may look weird, but it doesn't affect the bug
Here's the Caddyfile if you need

xxx.com:21935 {
  encode zstd gzip
  import tlsconfig

  handle_path /api/* {
    header {
      Access-Control-Allow-Origin: *
    }
    rewrite /api /
    reverse_proxy :29997
  }
  handle_path /live/* {
    rewrite /live /
    reverse_proxy :28889
  }
}

Did you attach a network dump?

yes

Sorry that I removed some of the dump out of security reasons
I filtered the packages with src&dst of the server ip, and the clienthello packages are removed
Feel free to contact me if any important information is filtered

ServerLog
NetDump.zip

Can reproduce


CLI flags/configuration and examples for Linux GPU training

The exact settings that need to change to successfully train with a Linux GPU can vary quite a lot by system. AMD cards vs Nvidia cards, memory available on the card, age of card, etc.
A list of the settings I've found so far that a user may want to tweak to get training working at all or to make tradeoffs in overall training speed versus resources used, nonexhaustive:

device(s) to use
fp16 vs bf16 precision
quantitization, specifically using 4bit BitsAndBytes vs not
gradient accumulation steps or disabled entirely
gradient checkpointing enabled/disabled
per-device training batch size
distributed training across multiple GPUs/CPUs (may be out of scope for just config, as that's more work to setup)

Some of these are configurable by CLI flags today. Can we expose all the needed parameters via CLI flags? Do we need configuration files? Which of these are also applicable to other lab commands, such as serve, generate, test, convert?
However we expose the necessary configuration, a list of example configuration/flags to use for different setups would be nice. Show people the things to tweak to lower memory usage at the expense of speed. Perhaps some guidance on the options needed to reduce GPU memory required under popular thresholds, like 8GB, 16GB, 24GB.
My assumption here is a goal would be to give people enough knobs to turn that they can get training going on their machine without having to change the actual Python code to do it. Perhaps others disagree with that assumption? All opinions are welcome!

@bbrowning is this issue still relevant or can it be closed?

We still don't expose all the necessary knobs so that users can get the most out of the simple Linux training in this repo without editing the source code, so this issue is still relevant in that sense. How much work we want to do to enable this depends on how far we want to push training here versus focusing on instructlab/training repo for Linux training work.

@RobotSail @Maxusmusti @JamesKunstle same question for you fellas here

Given all the changes since this was opened, I don't think it's still exactly relevant today. Closing this as outdated, and we can open specific issues based on the current CLI workflow as needed.