Running clean-css on concatenated CSS which accidentally included a PNG resulted in an unclear "RangeError: Maximum call stack size exceeded" error

Hi! This was originally filed as https://github.com/gruntjs/grunt-contrib-cssmin/issues/128 but it's been requested I file over here instead :-)
--
Our grunt build recently started failing with:
Running "cssmin:generated" (cssmin) task
File dist\css\index.min.css created: 177.13 kB → 142.92 kB
File dist\css\help.min.css created: 149.74 kB → 117.86 kB
>> RangeError: Maximum call stack size exceeded
Warning: CSS minification failed. Use --force to continue.

Aborted due to warnings.

We bisected the issue to this commit:
https://github.com/mozilla/treeherder-ui/commit/ab2bb9e2c0b131f7dbce1c324c9eedd9b76148c8#diff-837080205159fd84ad7c40ca41bc7855R9
...where someone had accidentally added the favicon before the
I'm presuming the error above is due to clean-css trying to read the png. It would be great if the error shown for this had indicated the filename being processed or even just spat out the line in question - which would have saved having to bisect.

Hi @edmorley!
I have trouble figuring out how changing HTML could affect CSS minification but let's give it a try. Could you please point me to source CSS which gets included in help.min.css file?

In our project, we've using a grunt build script, which runs the grunt cssmin
plugin as part of the build:
https://github.com/mozilla/treeherder-ui/blob/ab2bb9e2c0b131f7dbce1c324c9eedd9b76148c8/Gruntfile.js#L107
This plugin uses markup like:
<!-- build:css css/logviewer.min.css -->
...
<!-- endbuild -->

...to denote which assets to minify/concatenate, and the name of the output file. It then calls clean-css on each file:
https://github.com/gruntjs/grunt-contrib-cssmin/blob/master/tasks/cssmin.js#L16
In one of our commits, we accidentally included a png favicon inside the build:css tags, which resulted in the error above, which wasn't very clear and resulted in us having to bisect to find the cause.
Looking at the source more after filing this issue, I'm thinking that perhaps both clean-css and grunt-contrib-cssmin could do with fixing (and that perhaps the issue on grunt-contrib-cssmin's side was closed prematurely).
Ideally clean-css would output a "the content looks like a binary file" / "the content is invalid" if it's passed a PNG file, rather than "RangeError: Maximum call stack size exceeded". And grunt-contrib-cssmin would output the current filename when errors occur.

I'd say it's rather a grunt plugin issue since clean-css expects CSS to be passed into it. Let me open another issue to complain when content is not text though.

Yeah I completely agree, thanks :-)

:+1: no problem


[Snyk] Upgrade @google/generative-ai from 0.9.0 to 0.10.0

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to upgrade @google/generative-ai from 0.9.0 to 0.10.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on 21 days ago.

Release notes

Package name: @google/generative-ai

0.10.0 - 2024-05-03What's Changed

Put Github release step in publish workflow by @ hsubox76 in #117
Add a request option for custom headers by @ dlarocque in #118
Add generated docs for custom headers request options by @ dlarocque in #128
Add docs check workflow by @ hsubox76 in #129
Add UsageMetadata to GenerateContentResponse by @ DellaBitta in #127
Version Packages by @ github-actions in #126

New Contributors

@ dlarocque made their first contribution in #118
@ DellaBitta made their first contribution in #127

Full Changelog: https://github.com/google-gemini/generative-ai-js/compare/<EMAIL_ADDRESS><EMAIL_ADDRESS>

0.9.0 - 2024-04-29What's Changed

Fix Github release script by @ hsubox76 in #110
Update README by @ hsubox76 in #111
Add more properties to errors and export errors. by @ hsubox76 in #112
Allow user to provide systemInstruction as string or Part by @ hsubox76 in #113
Version Packages by @ github-actions in #114

Full Changelog: https://github.com/google-gemini/generative-ai-js/compare/<EMAIL_ADDRESS><EMAIL_ADDRESS>

    from @google/generative-ai GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Already upgrade to the latest


Allow multiple queries for the same panel.

Would you be open to allowing multiple queries to be written for a single panel so you can see the comparison of multiple time series?

Hi, I am also thinking that it might be good

@squaresurf @Oliv4945 This project no longer maintained. If you use InfluxDB 0.9+, you can do it using re:dash


Correction of the spelling of a word

修改文档内goodbye单词的拼写错误

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

多谢！


⚠ Samsung has degraded performance

In 5560826, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1848 ms

Resolved: Samsung performance has improved in d4605d9.


Add cryptography to MaaS dependencies

When pip_install_options includes --force-reinstall, cryptography needs
to be reinstalled so it's compiled cffi extensions are also rebuilt.
Addresses #1080

recheck_lint

recheck

@sigmavirus24 I think this will need to be rebased to take in the changes in  https://github.com/rcbops/rpc-openstack/pull/1106 (remove the ansible-2.0 lint check)

@sigmavirus24 could you rebase please (I can't because the PR is from a branch in your own repo...)

I was at PyCon. Rebasing now.

recheck_upgrade

recheck_upgrade

This is now passing the CI/gating tests

👍

:+1:


running npm init @haxtheweb local file issue

can not run npm init @haxtheweb

Where are you on your file system, what command did you run? Never had that before 😅

Previously it could work with version 9, but version 9.02 doesn't work on Windows 10/11

Really? What's the error message?

Really? What's the error message?

Interesting.. I'll take a look at this today via automated build testing although that can only go so far without me having a windows machine. Is it possible you used a different terminal last time? It seems to have lost scope of where npm is on your system.
@zdodson21 can you try and make a site on the windows side of your computer and let me know if you run into issues?

Weirdly enough for me Git Bash and Command Prompt in Windows seemed to work ok in their default directory, while PowerShell tried to just initialize a package like a normal npm init statement, and my WSL threw an error, which I would have expected the opposite. Will test on my Linux machine and edit this comment with a screenshot from that.

Windows Subsystem for Linux (Ubuntu / Linux Environment)

Git Bash (Windows Environment)

Command Prompt (Windows Environment)

PowerShell (Windows Environment)

I mean continuing with creating the single site /multi will get an error. I have tried using the solution from stackoverflow  site with the command but it still doesn't run smoothly

@zdodson21 are you able to make sites and can you come back and add more / administer them after the fact in the different terminals?

now work on command prompt


As a father, I want to set up a server for my family and only them, retaining some control of my children's accounts, to keep them safe on the Web.

This sets some requirements on how signups are managed, and how initial ACLs are made.

Added to readme

Opening this as part of moving all user stories into issues again.


New command: add toggle functionality to Keyboard Layout Switcher

Description
Adding Keyboard Layout Toggler which will toggle to the next keyboard layout. It is similar to Keyboard Layout Switcher but with some modifications. See #3397 .
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @agusluques 👋
Thanks for your contribution 🔥
@lucaschultz can you check this?

@pernielsentikaer will do 🙂

@lucaschultz it's ready to be reviewed it.
Thanks for the comments. I had thought about the order and had tested with more than 2 layouts but it's better to sort them just to be sure. I also added a README to have the link to that binary somewhere.
Great extension, thanks for all!

Can you check one last time @lucaschultz

Are you still available @lucaschultz

Sorry @pernielsentikaer, it has been a busy two weeks. I'll have a look later today 😊

That's okay, I didn't want to merge it without you approval @lucaschultz 😊

Can you look into this @lucaschultz

@pernielsentikaer I want to re-open this PR. I've been using this command for a while and now I'm using a new laptop so I'd like to install it from the store without cloning my fork


The connection was terminated before a greeting could be read.

FTP OS: Windows
FTP Server: WindowsServerIIS
Computer OS: Windows 10
FluentFTP Version: 32.4.6
When version 32.4.6 was updated, it no longer works.
The connection was terminated before a greeting could be read.
at FluentFTP.FtpClient.Handshake()
at FluentFTP.FtpClient.Connect()
at ConsoleApp_20200921_0929_FluentFtpStackOverflowReproduce.Program.Main(String[] args) in C:\Users\XX\Downloads\ConsoleApp_20200921_0929_FluentFtpStackOverflowReproduce\ConsoleApp_20200921_0929_FluentFtpStackOverflowReproduce\Program.cs:line 43
Logs :
Log with Version 32.4.6 ( Trace error attached.):
Connect()
Status:   Connecting to ***:21
Log with Version 32.4.5 (It works properly):
Connect()
Status:   Connecting to **:21
Response: 220 Microsoft FTP Service
Status:   Detected FTP server: WindowsServerIIS
Command:  USER ***
Response: 331 Password required
Command:  PASS ***
Response: 230 User logged in.
Command:  FEAT
Response: 211-Extended features supported:
Response: LANG EN
Response: UTF8
Response: AUTH TLS;TLS-C;SSL;TLS-P;
Response: PBSZ
Response: PROT C;P;
Response: CCC
Response: HOST
Response: SIZE
Response: MDTM
Response: REST STREAM
Response: 211 END
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Response: 200 OPTS UTF8 command successful - UTF8 encoding now ON.
Command:  SYST
Response: 215 Windows_NT
Code

Thanks for reporting this. Fixed in 32.4.7.


fix(ui) Fix selecting columns in Lineage tab for CLL

We recently made a change to fetch schemas separately from the main dataset fetch (for performance reasons) so the schema info was no longer in entityData. This uses that nice hook that only fetches schemas when we need to and will render that in the dropdown now for CLL impact analysis. Things still work the same and are all good for charts/dashboards and inputFields.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

confirmed that this works? nice!

yup! looks good locally for sure.


Support "awesome-pages"

Abstract
Adding the awesome-pages plugin to the documentation build enhances the development experience.
Background
Writing the entire configuration of pages in mkdocs.yaml requires writing cumbersome paths when adding files, and it becomes unreadable when consolidated into one file.
Details
Added the awesome-pages plugin and added a .pages file in the doc subdirectory. This allows specifying a distributed document structure. Added a dependency to the pyproject to use the awesome-pages plugin.
References
This plugin is used in the Autoware documentation, and I referenced its usage.
https://github.com/autowarefoundation/autoware-documentation
Destructive Changes
N/A
Known Limitations
N/A

@TakanoTaiga Please adding white line at EOF.

@hakuturu583
All tests have been completed. Please review 🙇.


fuzz: ensure runCleanupHooks is invoked on exit

Commit Message: fuzz: ensure runCleanupHooks is invoked on exit
Additional Description:
#29522 introduced cleanup hooks, and assumes a call will be made to runCleanupHooks at the end.
Some executions don't use our custom main file, so this PR ensures that the function will be invoked.
Risk Level: low - tests only
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/assign @RyanTheOptimist


Simulator Workload

The conductor orchestrates a set of clients.
The Workload generates requests and validates replies.
The Auditor stores the expected state of replica's state machines. It uses that state to validate replies from the cluster.
committed_requests_max is set to ~3 WAL wraps, so checkpoint is tested.
Because state transfer & block recovery aren't implemented, the cluster will not checkpoint until all replicas are ready.

For integration:

Instead of using a custom state machine to validate state, use the existing message hash chain.
Cluster no longer manages the clients or the StateChecker.
Add MessagePool.init_capacity: The Conductor needs a MessagePool that is neither a client nor a replica.
Add a grid_size_max option to the test Storage. Currently this is hard-coded, but eventually it should computed as the upper-bound amount of storage required for the test.
(The old test StateMachine is now dead code, but I'm leaving it in case we ever want to run the VOPR on just consensus, not storage).
Import PriorityQueue from Zig master's std to backport a couple fixes. This can be removed once TB upgrades to Zig 0.10.
command=reply now sets the timestamp to match the corresponding command=prepare (formerly it was 0). This enables the Auditor to check transfer timeouts.
Add Client.on_reply_callback/Client.on_reply_context. To check linearizability, the Conductor requires access to the original request and reply messages.

Misc fixes:

In benchmark.sh, don't overwrite format's logs.
Update comment in message_pool.zig.

Note that this change will require clients to rebuild on the latest client.zig to be compatible:

command=reply now sets the timestamp to match the corresponding command=prepare (formerly it was 0). This enables the Auditor to check transfer timeouts.

(Previously invalid_reply() expects a zero timestamp, but now it must be nonzero. So incompatible clients will drop messages with a nonzero timestamp).


chore: convert module.exports

also NODE_PATH is not needed anymore as plugins-ee now is within the
dcos-ui/-path.
also making jest noisy in the precommit-hook again to better see errors.

:tada: This PR is included in version 2.152.18 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ERROR: Module not found: Error: Can't resolve 'vue-i18n' in "...path"

Environment
Nuxt project info:

Operating System: Linux
Node Version:     v16.15.1
Nuxt Version:     3.0.0
Nitro Version:    1.0.0
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      ssr, builder, webpack, css, modules, app, i18n
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
I managed to reliably replicate the bug by:

creating a new nuxt 3 project with npx nuxi init
copying and pasting my nuxt.config and package.json
running npm i
running npm run dev

Describe the bug
When trying to run the local server errors pop up in the terminal.
By scanning the package.json "vue-i18n" seems to be correctly installed.
I tried removing node_modules, cleaning the npm cache, and re-installing the dependencies and it didn't work.
Additional context
This is the error message that appears:

Below my nuxt config:
export default defineNuxtConfig({
  ssr: false,
  builder: 'webpack',
  css: ['~/assets/styles/main.scss'],
  modules: ['@nuxtjs/i18n'],
  i18n: {
    strategy: 'prefix_except_default',
    locales: [
      {
        code: 'en',
        file: 'en-US.json',
      },
      {
        code: 'it',
        file: 'it-IT.json',
      },
    ],
    defaultLocale: 'en',
    langDir: 'lang',
  },
})

And here my package.json:
{
    "private": true,
    "scripts": {
        "build": "nuxt build",
        "dev": "nuxt dev",
        "generate": "nuxt generate",
        "preview": "nuxt preview",
        "postinstall": "nuxt prepare"
    },
    "devDependencies": {
        "@nuxt/webpack-builder": "^3.0.0",
        "@nuxtjs/i18n": "^8.0.0-beta.7",
        "nuxt": "3.0.0",
        "sass": "^1.57.1",
        "sass-loader": "^13.2.0"
    },
    "dependencies": {
        "vuetify": "^3.1.1",
        "webpack-plugin-vuetify": "^2.0.0"
    }
}

Logs
No response

That's duplicate #1568
Could you try to use edge version?

related #1754 #1794

@kazupon Thanks, I'll try the edge version, should that work fine on a nuxt 3 project?
Is it possible to have a rough estimate on which version of the beta (or final release) it will be fixed?

For PNPM Users, had the same issue, solved it via the .npmrc file

Docs


Readme has set serverip but you're calling webserver

You have a typo in your iPXE where you're setting the variable serverip but calling ${webserver}.
An easy fix on my end, but I thought I would let you know.
set serverip http://<IP_ADDRESS> //Modify this to match the ip address or domain of your webserver     set kernel "${webserver}/proxmox/${pveversion}/linux26 ${opts} splash=verbose proxdebug"     goto init :normal     set kernel "${webserver}/proxmox/${pveversion}/linux26 ${opts} splash=silent"     goto init :init initrd ${webserver}/proxmox/${pveversion}/initrd chain ${kernel}

Just realized this is a duplicate.


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>

Coverage remained the same at 83.983% when pulling<PHONE_NUMBER>966f6836e6819fbd45aeb551cf1ce8 on template-sync-1 into b9ad9d6e325f58576f4482a352514b42c40b77ee on master.


⚠ Avatar API Endpoint has degraded performance

In 8c1fe1b, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1034 ms

Resolved: Avatar API Endpoint performance has improved in 997e273 after 3 minutes.


Consider expiration return addresses for ledger updates

This PR changes how the owning address is calculated for spent outputs. Rather than assume the address unlock condition for basic/NFT outputs, the spent timestamp is checked against the expiration unlock condition, if it exists. Therefore, in the case where the output was spent on or after the timestamp, we use the return address to index the output.
UPDATE: Rolled the changes for the balance endpoint in as well for simplicity. The endpoint now returns availableBalance instead of sigLockedBalance and the calculation has been adjusted to include outputs with timelock conditions that have become unlocked, as well as those with matching expiration return addresses that are expired.
Linked Issues

Closes #1313
Closes #1312

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.
API Changes

[ ] Test the ledger updates by address endpoint.

INX Changes

[ ] Run chronicle using an INX connection.

Database Changes

[ ] Review database queries for correctness/conciseness.
[ ] Review migration for correctness.

https://chronicle-migr.stardust-mainnet.iotaledger.net/api/
This server can be used for testing the mainnet API before we commit to a migration.


Remove unused src/dataframe/io.jl file

This file has been removed in DataTables, but was missed when backporting
changes.

Good catch.

I wish I would have noticed it when rebasing. Apparently, that's the only one.


Missing Service Account on Bastion Host

Hi there and thanks for this module!
It seems to me, the bastion host is misconfigured to actually do its job as a jumpstation.
As far as I understand GCP os-login, the bastion host would need to have a service account with the roles roles/iam.serviceAccountUser and  roles/compute.osLogin or has roles to edit project metadata (see https://cloud.google.com/compute/docs/instances/connecting-advanced#bastion_host).
Maybe I'm getting this wrong, if that's the caase please point me in the right direction to use the bastion host.
Thanks again!

Hi @Miradorn, we actually went another route as described on that link you provided. Click the 'SSH' tab for more information. At the moment I'll leave this issue open as I'm currently deliberating with @rileykarson as to whether or not it makes sense to add additional permissions to the Bastion instance service account. We might prefer to follow a lesser privilege approach.
For the time being you should be able to connect to additional hosts using SSH key forwarding.

Hey, totally missed that tab, thank you!


Mute local microphone

Hello,
Is there anyway to mute the local microphone?
Session.mute() doesnt seems to be working.
Best Regards,
Pjata

You need to get the local tracks off of the peerConnection and then mute the tracks. This is outside of the scope of SIP.js. See Session Description Handler documentation for information on how to get the peer connection.

I solved it like this:
session.getLocalStreams()[0].getAudioTracks()[0].stop()

session.getLocalStreams is not forwards compatible with 0.8+. Y

You need to get the local tracks off of the peerConnection and then mute the tracks. This is outside of the scope of SIP.js. See Session Description Handler documentation for information on how to get the peer connection.

i did it this way
///mute
var pc = session.sessionDescriptionHandler.peerConnection;
pc.getLocalStreams().forEach(function (stream) {
    stream.getAudioTracks().forEach(function (track) {
        track.enabled = false;
    });
});

i did it this way
///mute
var pc = session.sessionDescriptionHandler.peerConnection;
pc.getLocalStreams().forEach(function (stream) {
    stream.getAudioTracks().forEach(function (track) {
        track.enabled = false;
    });
});

Chrome says peerConnection.getLocalStreams() shouldnt be used anymore. Instead use:
peerConnection.getSenders() And peerConnection.getReceivers()

in 0.15.0 version is it turned out to be done like this
const pc: any = this.session.sessionDescriptionHandler.peerConnection
    pc.getSenders().forEach((stream: any) => {
      stream.track.enabled = false
    })

thank you @koshelevvasya that worked for me!

sorry was late to the party. how do i as the remote peer know the local peer has muted their microphone so that i can update the status from my end?

@thanh-mel , the remote peer does not need to know that the microphone is muted. Maybe you need to use hold?

Any event would fire when a track is enabled/disabled
In my experience, yes. Because it is done using JavaScript


Cross-port font fix from SSD1306

https://github.com/Scott216/Arduino_Libraries/commit/5402f18b35cd68d6fa22d7192ebd6e4fb7fce731

Adding an issue so this isn't lost.

#17 resolves this.


1 GB Memory Allocation Issue

Hello,
I have looked through the documentation and some previous issues of Wasmtime
so sorry in advance if this has already been answered. I can't get a Wasm module
to be able to allocate more memory than 1GB before reaching a memory error,
in this case thread '<unnamed>' panicked at library/alloc/src/raw_vec.rs:534:5: capacity overflow. I am trying to instantiate a Wasm module through a native program
with Wasmtime 18.0.0 with the following code:
`let engine = Engine::default();
let mut linker = Linker::new(&engine);
wasmtime_wasi::add_to_linker(&mut linker, |s| s)?;
let module = Module::from_file(&engine, wasm_prg)?;

let wasi = WasiCtxBuilder::new()
    .inherit_stdio()
    .inherit_args()?.preopened_dir(Dir::from_std_file(std::fs::File::open(path)?), path)?
    .build();

let mut store = Store::new(&engine, wasi);
let memory_type = MemoryType::new(1, Some(16384*4));
Memory::new(&mut store, memory_type).unwrap();`

let instance = linker
        .instantiate(&mut store, &module).unwrap();
 match instance.get_export(&mut store, "function")
        .and_then(|e| e.into_func())
        .ok_or(0) {
          Ok(func) => ...
 }

Which instantiates a Wasm module and call a function that allocates a Vec of certain size > 1 GB this way:
let mut buf: Vec<u8> = Vec::with_capacity(2217296726 as usize);
Here is the full error upon execution:
thread '<unnamed>' panicked at library/alloc/src/raw_vec.rs:534:5:
capacity overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Error: error while executing at wasm backtrace:
    0: 0x121cc - <unknown>!__rust_start_panic
    1: 0x11f54 - <unknown>!rust_panic
    2: 0x11e87 - <unknown>!std::panicking::rust_panic_with_hook::h01fa6d9286535f9c
    3: 0x1125c - <unknown>!std::panicking::begin_panic_handler::{{closure}}::h322b08995dd5f5cc
    4: 0x111bc - <unknown>!std::sys_common::backtrace::__rust_end_short_backtrace::hd7b53dba62f7f0aa
    5: 0x1183e - <unknown>!rust_begin_unwind
    6: 0x16cf6 - <unknown>!core::panicking::panic_fmt::h2a1cf3beec13dfc3
    7: 0x16697 - <unknown>!alloc::raw_vec::capacity_overflow::h71c1886b236d8c9d
    8: 0x1505 - <unknown>!benchmark_wasm_joins
note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information

Since Wasm should support 4GB of memory I thought it was only a question of option toggling but I don't see how to do it in the first code section. Hope it was clear enough.

It appears that this is a Rust standard library issue on the guest side (i.e., your Wasm module, not Wasmtime itself): this line of code in the Vec implementation checks that the allocation size is less than isize::MAX, and on a 32-bit platform such as Wasm, isize (signed pointer-sized integer) ranges up to +2GiB, not +4GiB. Your allocation request is just over 2GiB in length, hence the error.
I'm not sure why Vec is this way; you'd have to read the library source to find out more, probably; but as this is not a Wasmtime issue (we're executing the module correctly) I'll go ahead and close this issue.

LLVM considers it UB for allocations larger than isize::MAX to exist. Libstd panics here to avoid this UB.

Thank you for your answers.
I am still looking for an alternative to fix this issue.
The initial goal remains simple, allocate the maximum memory in a Wasm module in Rust, i.e., 4GB currently.
Do you know what is being used to achieve that?

You have to make multiple separate allocations to allocate more than 2GB total. There is no way to make a single contiguous allocation.

I was afraid this was the only solution.
Thank you nonetheless.

To add a bit of nuance: not possible with LLVM, apparently. However, @bjorn3, do you know if the UB applies to a slice constructed manually (std::slice::from_raw_parts)? If that's allowed to range up to usize::MAX, then potentially you could write your own manual allocator function that uses memory.grow to grab a large (4GiB - epsilon) chunk. dlmalloc on the guest side is specifically compatible with "discontiguous grow" (some other client also using memory.grow).

However, @bjorn3, do you know if the UB applies to a slice constructed manually (std::slice::from_raw_parts)?

Yes that is still UB if you actually try to use it. LLVM assumes that any allocation is less than isize::MAX bytes. From the LLVM LangRef:
https://llvm.org/docs/LangRef.html#getelementptr-instruction

These rules are based on the assumption that no allocated object may cross the unsigned address space boundary, and no allocated object may be larger than half the pointer index type space.

and also the couple of rules above it for getelementptr inbounds (which is the instruction rustc uses for all slice indexing, pointer offsetting for field accesses and ptr::offset and so on (but not ptr::wrapping_offset)

That's too bad. @chanattan it appears this means that you'll be unable to use any LLVM-based toolchain for wasm32 (e.g. wasi-sdk, or emscripten, or Rust, or tinygo, or ...) to allocate a single object >2GiB. You could still write your own (i) allocator, as above, and (ii) load/store primitives, in raw WAT, and link that into your wasm module; raw Wasm should have no issues with a single e.g. 3.75GiB array in memory. But you'd need LTO-time inlining to make that fast (maybe wasm-opt with the right options, I'm not sure).

I will probably go for a custom allocation. I will eventually look at the rest later.
Thank you again for your precious pieces of information.


Set position and length together

Sometimes there is need to adjust position and length together. Any one you do individually will set the progress bar to an incorrect amount, until the second one is set.
To enable this scenario a method like set_length_and_position would solve the problem, as it would draw only after both are set.

Furthermore, it would be good to add a set_length_and_position_with, that could be used as follows:
bar.set_length_and_position_with(|current_length, current_position| {
    let new_length = ...;
    let new_position = ...;
   return (new_length, new_position);
});

This would enable to to the change atomically (for example incrementing the length and/or position), which is not possible currently in case of concurrent execution (except by adding and additional lock, but this is annoying to do and duplicates the lock that is already in the ProgressBar). Such a method would subsume #236.

d198f809c56868c8e998077eda3e3652e3a1c5fa adds a ProgressBar::update() method that allows the caller to mutate the ProgressState directly.


fix include

Fix lex "include [ \t]filename" handle. To support more spaces/tabs after include key word. Before this change, code supports only one space after include. but lex support more.

reasonable

will submit PR tomorrow


Invalid mount options on service should produce error

Trying to create a service with invalid mount options should produce an error instead of creating the service (and keep trying);
For example:
docker service create --name foo --mount type=volume,target=/ nginx:alpine

Is invalid, because / cannot be used as a target. This error will never be solvable, so there's no reason to create the service (without producing an error)
similar to https://github.com/docker/docker/issues/24134

@thaJeztah Unfortunately, the meaning of the path is specific to the targeted platform. These can't be validated until assigned to a specific node/platform.
In general, we need to work on the error reporting. Let's revisit this after the release and see where we land.

@stevvooe SGTM; I'll keep it on the milestone, then after release we can decide to move it to 1.13, or possibly a 1.12.1 with improvements

@stevvooe The path should be able to be evaluated.
/ is not allowed as a container path, and neither is c:\, these are pretty well-defined rules that won't change.

At least somewhere to start, anyway.

@cpuguy83 good point, I thought about that later; think we should validate that? (There's still other situations of course, but it's a start)


Faulty TLS/SSL connection and fail2ban in the log... a never-ending story

The regex entry works, apparently it can't be processed by fail2ban because the line contains the characters '->' and fail2ban fails on '>'.
2022-07-14 07:22:12,036 fail2ban.filter         [816436]: ERROR   Failed to process line: '> ', caught exception: IndexError('string index out of range',)
2022-07-14 07:22:14,640 fail2ban.filter         [816436]: ERROR   Failed to process line: '> ', caught exception: IndexError('string index out of range',)
2022-07-14 07:22:16,643 fail2ban.filter         [816436]: ERROR   Failed to process line: '> ', caught exception: IndexError('string index out of range',)
2022-07-14 07:22:18,645 fail2ban.filter         [816436]: ERROR   Failed to process line: '> ', caught exception: IndexError('string index out of range',)

I also opened an issue at fail2ban regarding this (https://github.com/fail2ban/fail2ban/issues/3317).
Do you have any other ideas what can be done?

what happens in this case? Is only the line skipped?
does this happen during test only or in the real log?
sometimes the test option gives you different results.
I added the check for the failed connections recently, based on a discussion in an issue.
And I have tested the filter with those lines and it worked for me.
I could retest and see what version I have.
But let's see what they come back with in the issue. I just subscribed to your issue to get updates.
I have no idea what might be a work-around.
Can we wait what the fail2ban guys say..

Yes please wait what the fail2ban team says. That was actually meant more to inform you.
It only came up in real operation, during the test I didn't detect the error.

As already written in the issue for fail2ban, the adjustment of the definition works.
[Definition]

datepattern = ^(?:\[[^\]]+\]\s+)?%%d\.%%m\.%%Y %%H:%%M:%%S\s+
              ^(?:\[[^\]]+\]\s+)?{DATE}\s+

failregex = ^(?:http|smtp|ldap|imap|pop3): [^\]]+\[<ADDR>\] authentication failure using internet password\b
            ^TLS/SSL connection <ADDR>\([^\)]+\) -> \S+ failed\b

As you can see here, fail2ban now snaps without any problems:
2022-07-28 04:46:37,758 fail2ban.filter         [491642]: INFO    [domino] Found <IP_ADDRESS> - 2022-07-28 04:46:36
2022-07-28 04:49:03,947 fail2ban.filter         [491642]: INFO    [domino] Found <IP_ADDRESS> - 2022-07-28 04:49:02
2022-07-28 04:49:04,148 fail2ban.filter         [491642]: INFO    [domino] Found <IP_ADDRESS> - 2022-07-28 04:49:03
2022-07-28 04:49:04,357 fail2ban.actions        [491642]: NOTICE  [domino] Ban <IP_ADDRESS>

Do we really need both for the date pattern?
If it would work with the {DATE} only, this would not make it specific to that locale.
We also should make sure it works without DEBUG_THREAD=1 even it is on by default.

Looks like we need both. the default {DATE} seems still not handle the German date.
I just tested the filter and the new rules work for me as well.
Thanks for taking care of reporting it to the Fail2Ban GitHub repo and getting a solution for us.
I just pushed the change to the start script repo.


Mysql Workbench cannot connect to sharding-proxy.

Bug Report
For English only, other languages will not accept.
Before report a bug, make sure you have:

Searched open and closed GitHub issues.
Read documentation: ShardingSphere Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot reproduce it on current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Which version of ShardingSphere did you use?
4.0.0-RC3-SNAPSHOT
Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-Proxy
Expected behavior
Actual behavior
Reason analyze (If you can)
Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
Example codes for reproduce this issue (such as a github link).

Mysql Workbench log
21:59:03 [ERR][  GRTDispatcher]: exception in grt execute_task, continuing: Exception: Access denied for user 'root'@'localhost' (using password: YES)
21:59:03 [ERR][  GRTDispatcher]: worker: task 'execute sql queries' has failed with error:.Access denied for user 'root'@'localhost' (using password: YES)
21:59:07 [ERR][  GRTDispatcher]: exception in grt execute_task, continuing: Exception: Access denied for user 'root'@'localhost' (using password: YES)
21:59:07 [ERR][  GRTDispatcher]: worker: task 'execute sql queries' has failed with error:.Access denied for user 'root'@'localhost' (using password: YES)
21:59:07 [ERR][    WQE backend]: Got an exception during connection: Access denied for user 'root'@'localhost' (using password: YES)
21:59:07 [ERR][SQL Editor Form]: SQL editor could not be connected: Access denied for user 'root'@'localhost' (using password: YES)
21:59:07 [ERR][SQL Editor Form]: Your connection attempt failed for user 'root' to the MySQL server at <IP_ADDRESS>:3307:
Access denied for user 'root'@'localhost' (using password: YES)
Please:
1 Check that MySQL is running on address <IP_ADDRESS>
2 Check that MySQL is reachable on port 3307 (note: 3306 is the default, but this can be changed)
3 Check the user root has rights to connect to <IP_ADDRESS> from your address (MySQL rights define what clients can connect to the server and from which machines)
4 Make sure you are both providing a password if needed and using the correct password for <IP_ADDRESS> connecting from the host address you're connecting from

You can also use Navicat

Sharding-Proxy only support TCP/IP communication for now.
MySQL client treat 'localhost' via UNIX Domain Socket while treat '<IP_ADDRESS>' via TCP/IP. This explains why you can't use localhost to connect Sharding-Proxy.
To resolve this problem you can:

Set protocol=tcp in my.cnf to enforce connecting by TCP/IP.
OR
You can still use localhost if your MysQL client is running on Windows, because there's no UNIX socket in Windows, the address will be tranform to <IP_ADDRESS> automatically.


Option to use React.createClass

I'd like to have a setting that allows me to use React.createClass rather than extends. Would this be ok?

Hi @jordyvandomselaar,
this would be possible. If there is enough demand we we could maybe implement it into the next major version of the generator.
@sthzg: Whats your opinion on this?

Sorry for the late reply, somehow I missed that one. IMO that is a tough call. I can see how and why it would be valuable, on the other hand it would double the variations on the template generation and on the automated tests. Especially manually testing each possibility would become even more involved than it is already.
Also it may be worth thinking about consequences for external generators like the alt and flux generator, which had to add support as well. I also figure that sometimes there might not always be an easy path to support both worlds.

No problem :)
I see, I'll just get used to it then, it's too much work for something that's not a must have to begin with.
Thanks for the replies! :D

After thinking a bit longer about this, we will currently not implement this feature. Most projects move away vom React.createClass anyways. If the question arises again, we may have another look at it...


Documentation update

A branch for the non-generated documentation

Coverage remained the same at 65.399% when pulling a58d54232177aac5273dc477d461d3b5762e346d on docs into 4cc95505594edaf7dfed67db3284af1db03291d1 on master.

Coverage increased (+0.05%) to 65.447% when pulling 22e4babaa31c45a0b746d8f850e4b492174654cc on docs into 4cc95505594edaf7dfed67db3284af1db03291d1 on master.

Coverage increased (+0.05%) to 65.447% when pulling c735421930499f8fb16b799bdc66e827b08dd1a0 on docs into 4cc95505594edaf7dfed67db3284af1db03291d1 on master.

Coverage increased (+0.05%) to 65.447% when pulling 100daaaab5e40434db14d517b42b7430ab347d1e on docs into 4cc95505594edaf7dfed67db3284af1db03291d1 on master.

Coverage increased (+0.1%) to 65.496% when pulling 2486a4c659d2ecb0445882b1adfcec7014f46efb on docs into 4cc95505594edaf7dfed67db3284af1db03291d1 on master.

Coverage remained the same at 65.447% when pulling c8b7203c1ef096abfc59a3fde6358c6ed4083a14 on docs into 2f7e766a0e5574c6139bbe2f81680a77016c3895 on master.

Coverage decreased (-0.06%) to 65.391% when pulling 95b9f57ddd11fe05b2550fcfe5343be09a880bfe on docs into 2f7e766a0e5574c6139bbe2f81680a77016c3895 on master.

Coverage remained the same at 65.391% when pulling dfd8254c9080995376621ca2c78af0a1f81df322 on docs into a9d67ba582038298390d2fb9ccfbeae220290d28 on master.

Coverage increased (+0.05%) to 65.44% when pulling 243d762dc6e8f46aa89884c38aec4e31dc04b63c on docs into a9d67ba582038298390d2fb9ccfbeae220290d28 on master.

Coverage remained the same at 65.391% when pulling 8d2d12b479a7c5116cd467c55aaa9a0b368aef9e on docs into a9d67ba582038298390d2fb9ccfbeae220290d28 on master.

Coverage remained the same at 65.391% when pulling 507e76a9117c8ff89b42afcf77f8a7943be09890 on docs into a9d67ba582038298390d2fb9ccfbeae220290d28 on master.


Create Volunteers and Sponsors page

Copy here - need some design now.
Brochure_Content_Final_Draft.pdf

NOTICE
Needs: Copy/Content label remains only because there is no content for "Volunteering"

@kylemh, volunteering content;
Volunteer

Join our community on Slack, and work with new software developers to help grow and mentor them in learning to code and enter the tech industry. Answer questions, participate in mock interviews, and review resumes.
Lead a squad of new developers in learning new skills in Linux, Python, cloud infrastructure, web development, and more.
Meet up with a local chapter (or start your own!) and network with other new developers eager to build cool apps and code the future!

Contribute

Star our open source projects on Github, and work with our members to take on the open source mission and contribute code.
Donate to Operation Code - your financial support lets us fund our mission to help the military community enter the tech industry.
Do you represent a company? Talk to us about sponsorships at<EMAIL_ADDRESS>
With your help, we can...

Provide scholarship funding to support education for veterans, transitioning servicemembers, and military spouses.
Send new developers to conferences and major tech events, to improve career outcomes.
Start tech meetups near military installations to help our community learn the career skills of the future.

Did we ever get the design for the brochure? If not I have some mockups

@hollomancer and @dmarchante let's get some emergency final description/content on this issue so we can assign a motivated @jaalah

Ok I'm assuming these are two separate pages, correct?

the goal is to be one page I beleive

The content is on the pdf attached to the issue, but the direction I was given was one 8.5 x 11. I think it is copy heavy, so if you can find a way to make it work we would be interested to see it. If anything is removed that we think was crucial we can let you know. So have at it


Spree Core Engine mount path breaks Pay with Amazon checkout pipeline

If you change the Spree Core Engine mount path to anything besides the domain root, it breaks the Pay with Amazon checkout pipeline.
Example:
change path in config/routes.rb:
mount Spree::Core::Engine, :at => '/mystore'

Merged in pull requests on all branches.


Adds spanner_tool for easy experimenting

This PR adds a spanner_tool binary that we can use to easily experiment with the spanner API in C++. It currently only calls spanner's ListDatabases RPC, which is kinda like a hello-world program. It can be extended to support others.
It only works with bazel at this point because I don't really know how to make it work with cmake yet :-) But that can be done in a later PR.

This change is

OK, thanks. I'm disconnecting now for a flight. Feel free to merge this PR if the builds are good and someone wants to use this spanner_tool. Otherwise, I'll merge later today or Monday.


csrf_token doesn't get populated in the index.html

I created a react.js app and disabled csrf validation for development. Later when deployed to production, the csrf token validation failed. When investigated, the <script>window.csrf_token = '{{ csrf_token }}';</script> part was as it is and the {{ csrf_token }} part wasn't replaced with a valida value.
Then I changed it to frappe.session.csrf_token (https://frappeframework.com/docs/v14/user/en/api/jinja#frappesessioncsrf_token)
<script>window.csrf_token = '{{ frappe.session.csrf_token }}';</script>

and it worked as expected. Should the script be updated?

So, basically in development it won't get rendered, because vite server is handling it. That is why we need to add ignore_csrf to site config.
In production, it will get rendered as jinja template.

Awesome! Basically, you have to add your own context py file for the current template to work. But now that you have found out this, we can fix the script to use your solution.
Do you want to raise a PR?
If not I will do it tomorrow.

@NagariaHussain even though I suggested the above approach, I now feel like this is not the correct approach. Seems like if we directly add the csrf_token to the html as below,
<script>window.csrf_token = '{{ frappe.session.csrf_token }}';</script>

the html page gets cached and this causes CSRFTokenError eventually. I assume the csrf_token in the session had been updated, but the server keeps serving the cached html page which has the old csrf token. I have encountered this in multiple portal page related apps now. But was unable to figure out why until now.
My suggestion is that we roll this back to how it was before and improve the documentation to mention about setting the csrf_token in the context with no_cache=1.


Expand read.myacc.csv with non-wear channel reading

Expand read.myacc.csv() with ability to also read a csv-file column that holds externally generated non-wear detection. In this way it will become possible to let GGIR rely on third party generated non-wear detection.
Envision action steps:

[x] Expand read.myacc.csv, to be able to extract the non-wear classification from a specific channel, where the column number is specified by the user.
[x] Pass data on through function g.readaccfile and g.getmeta.
[x] Use data to overrule non-wear score calculation inside g.getmeta producing a 0 (wear) or 3 (non-wear), such that the rest of the existing code for non-wear labeling and imputation can stay the same.

Work done, code currently lives in branch: issue232_NWchannel. To be merged before next release.


enable using custom Pinecone index name

Description
Enable using custom index name with Pinecone.
Fixes #1171
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (does not change functionality, e.g. code style improvements, linting)
[ ] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.

[x] Unit Test
[ ] Test Script (please provide)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Hey @peterj, Thanks for your contribution. This generally looks good to me. However, we are currently in the process of updating the Pinecone client to later version (v3). Refer PR #1200. We will merge this asap.

thanks @peterj for the contribution. this is really great.


lastJson is now the field of Instagram struct

This change makes possible to create several Instagram structs and use them separately

@CreditSuisse1 Thanks


Historic appointments could be consolidated further

Past Prime Ministers, Past Foreign Secretaries and Past Chancellors pages are as of https://github.com/alphagov/whitehall/pull/6264 rendered using the same design patterns but they are handled discretely. It would make sense to reuse the same partials for the output, after manipulating the data to make it suitable to feed in.

No longer a Whitehall thing. Is this on the Web tech debt board @maxgds @leenagupte ?
Closing this issue in the meantime.


check rendering of PDF thumbnails

@Athanaseus reported a possible problem here: https://github.com/ratt-ru/radiopadre/issues/76#issuecomment-609853199

@Athanaseus, I think this was your bandwidth. When I click on PDF thumbnails, the full PDF pops up in a separate tab. Please reopen if the problem persists.


Fix CI pipeline bug on packaging offline installer

This commit is to fix the bug introduced by PR https://github.com/vmware/harbor/pull/5207/, which adds the json library but doesn't install it in the E2E engine. The bug will cause an runtime error when to exsecute robot framework. Disable it temporary as the upgrade script havn't added into the nightly test.
And also make the CI pipeline script to throw error on packing/uploading offline installer, otherwise the latest installer will not be updated by the lastest code change.

Pull Request Test Coverage Report for Build 7545

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.05%) to 64.591%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/scheduler.go
2
81.29%

src/replication/core/controller.go
2
75.93%

src/common/utils/utils.go
4
81.55%

Totals

Change from base Build 7540:
0.05%

Covered Lines:
11080

Relevant Lines:
17154

💛  - Coveralls


style(key-manager): change key variable name

Current function returns private keys but calls the returned object public keys.

Code readability improvements. The function 'getPrivateKeyList' returns privateKeys, but the object being manipulated was labeled publicKeys.


page:partial-load without jQuery

Is there a way to bind to the page:partial-load event without jQuery? Couldn't find documentation for this.

From the turbolinks_replace_test.coffee file, I guess:
 document.addEventListener 'page:partial-load', (event) ->
      # your code here

Or in javascript:
document.addEventListener('page:partial-load', function(event) {
  // your code here
});

:+1:

Thanks!


docs(examples): adding prescript example

Added an example of puppeteer project with prescript

prescript: an end-to-end test runner that sparks joy
know more why I used prescript read my article : )

[minor] Applied prettier style to README.md file.

@Cerberus let's wait for prescript to get some user base - otherwise, these mentions won't be useful for the absolute majority of Puppeteer users.


[chore] refactor tenant_controller.go

tenant_controller.go codebase became too large to read, so I propose to split it into separate files for each of the resources it manages, like
controllers\tenant\
reconciler.go
utils.go
networkpolicy.go
limitrange.go
resourcequota.go
rolebinding.go
namespace.go

@MaxFedotov JFI that wouldn't be a chore but rather a refactor


Couldnt read champion data on League 12.13[BUG]

The program doesnt want to update the gold

We need to wait for update :)

offsets updated


request tags (or very clear doc) mapping a DirectML semver to a git commit hash

I request tags (or very clear doc) mapping a DirectML semver to a git commit hash.
As it is today, there are no useful tags. And there is no documentation I can find to know what commit hash maps to what DirectML semer.
What commit hash is DirectML 1.9.0?
What commit hash is DirectML 1.9.1?
etc...
Best approach is to TAG a commit. Perhaps you do this internally somewhere....and just need to push those tags here publically.
This allows us to automate, CI, etc.
Alternatively, and far less useful, is to clearly document somewhere in a html table a mapping of DirectML semver -> commit hash.

The source code for the DirectML library is in an internal git repository. This open-source git repo provides samples and tools that use DirectML. It's not clear what value the commit SHA provides for open-source consumption of the DirectML library, and the semver version (e.g. 1.9.1) is the definitive way to reference a specific release of DirectML in any open-source project that uses DirectML.

haha, my understanding 🤦♀ I assumed DirectML was open sourced at this git repro; its source to be optionally built by projects like onnxruntime https://github.com/microsoft/onnxruntime/issues/13094. I skimmed this repro's README again and I don't see falsehoods, rather that it has two distributions (OS and nuget) for binaries and the source itself is unmentioned so I (wrongly) assumed this repo had it in folders dxdispatch, libraries, etc.
I'm closing this issue as I see no issue now understanding DirectML itself is closed source. 👍


Please update for stylelint v15

@ricardogobbosouza

I removed this project.
It seems it is dead and won't get any updates.
If I'm informed correctly users should migrate to Nuxt 3 and its Vite Plugins instead.

@ricardogobbosouza - the previous time it was again weeks or months until the module was update to the last stylelint version.
If you don't have time or wish to deal with this project - you better give rights to someone else to do that.

Sorry for delay

Added support stylelint v15 on v4.2.0

Thank you @ricardogobbosouza
After updating to 4.2.0 I get the following warning in pnpm:
└─┬ @nuxtjs/stylelint-module 4.2.0
  └─┬ stylelint-webpack-plugin 2.4.0
    └── ✕ unmet peer<EMAIL_ADDRESS>|| ^14.0.0": found 15.2.0

and I still get the same error
 ERROR  StylelintError                                                                                friendly-errors 19:20:29

[stylelint] stylelint.createLinter is not a function

So I need to remove this module again.

Thanks @MartinX3

Fixed https://github.com/nuxt-community/eslint-module/pull/80

@ricardogobbosouza Is there any plan to fix the error mentioned by Martin? It would be great to have a fix in a v4.2.1 (in addition to v5.0.1), so that it's available for Nuxt.js 2 apps.

Release [v4.2.1(https://github.com/nuxt-community/stylelint-module/tree/v4.2.1)


Update all services

OpenAPI spec or templates produced changes on 03-10-2024   by commit.

⚠ Deprecation and Breaking Changes ⚠
Checkout
src/checkout/model_pay_to_details.go

In  the PayToDetails class RecurringDetailReference marked deprecated and StoredPaymentMethodId attribute is added to return the reference to the payment method in the response when creating the token.

LEM
src/legalentity/model_business_line_info_update.go

In the BusinessLineInfoUpdate class capability, legalEntityId, salesChannels and service are removed

Management
src/management/model_payment_method.go

In PaymentMethod and PaymentMethodSetupInfo class GenericPmWithTdiInfo name change to JCBInfo


pip

Is this library fully compatible with the semantic versioning recognized by pip?

@chaddotson
I'm not the maintainer of this project so take this information with some caution.
As far as I can see, this library is NOT "fully compatible" with pip. If you search the pip directories for "version" you get some matches in the module pip._vendor.packaging.version with the classes
_BaseVersion,  LegacyVersion, and Version.
The seem to contain a completely different API than semver.

@chaddotson Thank you for your contribution! :+1:
I think, I've answered this question and close this bug for the time being. If you think, there is something else you need to know, just let us know.


Interactive Tutorial - Creating a Cluster Error

When running 'start' run into error below:
$ minikube start
W0414 17:03:21.074184    1208 main.go:170] Unable to make log dir /root/.minikube/logs: mkdir /root/.minikube/logs: input/output error
log: exiting because of error: log: cannot create log: open /tmp/minikube.minikube.root.log.WARNING.20210414-170321.1208: read-only file system

I think this report is about https://kubernetes.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive/ and using the provided environment to try Minikube.
/kind bug
/team katacoda

/label team/katacoda


Map incoming header to more refined customer header

It would be nice if the Cloud Stream framework would provide a way to map incoming headers to a more refined custom header. I'd imagine this would probably use a combination of SPEL and existing header enricher capabilities in Spring Integration? And it would be ideal if this could take place completely via configuration (if possible) to prevent the developer from having messaging specific code.
This would enable developers to do many things, but one example would be to extract parts of a destination as separate header variables as requested in a Solace Binder enhancement here: https://github.com/SolaceProducts/solace-spring-cloud/pull/45. It would be great if this functionality could be achieved at the framework level so everyone can benefit from it. Note that this would also assist with folks discovering Spring Cloud Stream via AsyncAPI since it has the concept (like OpenAPI) of variables that can exist in channels.
FYI @olegz this is one of the enhancements we discussed earlier.

Actually it's even simpler then I thought (still needs to be documented), but here is the short of it. You can achieve it via simple function composition.
@Bean
public Function<Message<?>, Message<?>> enrich() {
    return message -> MessageBuilder.fromMessage(message).setHeader("foo", "bar").build();
}

@Bean
public Function<Message<?>, Message<?>> myBusinessFunction() {
    // do whatever
}

Your spring.cloud.function.definition will be spring.cloud.function.definition=enrich|myBusinessFunction
Here is the complete app that you can cut/paste
@SpringBootApplication
public class DemoStreamApplication {

	public static void main(String[] args) {
		SpringApplication.run(DemoStreamApplication.class,
				"--spring.cloud.function.definition=enrich|echo",
				"--spring.cloud.stream.function.bindings.enrich|echo-in-0=myInput",
				"--spring.cloud.stream.bindings.myInput.destination=myDestination",
				"--spring.cloud.stream.bindings.myInput.group=myGroup");

	}

	@Bean
	public Function<Message<String>, Message<String>> enrich() {
		return message -> {
			Assert.isTrue(!message.getHeaders().containsKey("foo"), "Should NOT contain 'foo' header");
			return MessageBuilder.fromMessage(message).setHeader("foo", "bar").build();
		};
	}

	@Bean
	public Function<Message<String>, Message<String>> echo() {
		return message -> {
			Assert.isTrue(message.getHeaders().containsKey("foo"), "Should contain 'foo' header");
			System.out.println("Incoming message " + message);
			return message;
		};
	}
}

Note how I am simplifying the composed function name with spring.cloud.stream.function.bindings.enrich|echo-in-0=myInput, so now you can refer to the input binding as myInput and use it with other standard stream properties (as shown in the example)
Anyway, i'll document it in both stream and function before closing it

@olegz, I agree this is one approach to doing it and would work as a generic way to enrich a message. But do you think we can come up with something that exposes this via configuration? Maybe using SPEL and a generic impl of something like the headerMapperBeanName that Gary mentioned above?
I'm trying to get closer to the proposal made here where just via a few simple config changes in the yaml/json the developer/devops team can create new headers without having to write code if possible. (Note the IMPL of that specific use case is basically take the destination header on a Solace message and extract the topic levels specified between the angle brackets as variables)
In general adding this functionality via configuration would also allow for function re-use without needing to re-compile at deployment time. For example, a developer wrote a function bean to handle a REST request expecting header "foo" and an "order" POJO payload and now at some time later I, who may be on the devops team, want to re-use that function bean and expose it via Rabbit/Kafka/Solace...I have a message coming in that includes the proper "order" POJO and just need to create the "foo" header who's value is in a different header of the message already. If I can do that via config then I don't need to modify any code.

Marc, I just pushed initial support for it. It is not yet documented (i'll follow up), but wanted to give it to you as quick as possible to try.
Here is an example (it also uses composed function for added complexity)
@SpringBootApplication
public class DemoStreamApplication {

	public static void main(String[] args) {
		SpringApplication.run(DemoStreamApplication.class,
				"--spring.cloud.stream.function.autodetect=false",
				"--spring.cloud.function.definition=echo|foo",
//				"--spring.cloud.function.configuration.echo.input-header-mapping-expression[0].key1=hello",
//				"--spring.cloud.function.configuration.echo.input-header-mapping-expression[0].key2=blahblah",
				"--spring.cloud.function.configuration.echo|foo.input-header-mapping-expression.key1=headers.key3",
				"--spring.cloud.function.configuration.echo|foo.input-header-mapping-expression.key2='blahblah'"
				);
	}

	@Bean
	public Function<String, String> echo() {
		return p -> p;
	}

	@Bean
	public Function<String, String> foo() {
		return p -> p;
	}
}

Note how I commented input-header-mapping-expression[0].key2. Basically if you're only dealing with conventional function, indexing input with 0 is optional.
Anyway, give i a shot and let me know

Hey @olegz,
Sorry for the delay but I finally got a chance to try this out and I can't seem to get it working.
I pulled the latest on the main branch in this project, did a mvn install locally and added the below to my pom
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-function-context</artifactId>
			<version>3.1.3-SNAPSHOT</version>
		</dependency>

Do I need to do something else to get it to work?
I'm using the traditional uppercase function below and when I add
spring.cloud.function.configuration.uppercase.input-header-mapping-expression.foo=contentType to my application.properties file the foo header is empty even though the contentType header isn't.
	@Bean
	public Function<Message<String>, String> uppercase(){
	   return v -> {
	      System.out.println("Uppercasing: " + v.getPayload());
	      System.out.println("Headers: " + v.getHeaders());
	      System.out.println("foo: " + v.getHeaders().get("foo"));
	      return v.getPayload().toUpperCase();
	   };
	}

Output:
Uppercasing: Hello world!
Headers: {solace_senderTimestamp=1621370220410, solace_expiration=0, deliveryAttempt=1, solace_destination=uppercase-in-0, solace_timeToLive=0, solace_receiveTimestamp=0, target-protocol=kafka, acknowledgmentCallback=com.solace.spring.cloud.stream.binder.util.JCSMPAcknowledgementCallbackFactory$JCSMPAcknowledgementCallback@622016f1, solace_discardIndication=false, solace_dmqEligible=false, solace_priority=-1, solace_redelivered=false, id=4e1963cb-8fc5-d401-020a-fd8704210a49, contentType=application/json, solace_senderId=Try-Me-Pub/solclientjs/chrome-90.0.4430-OSX-10.15.7/2008818482/0002, timestamp=1621370220449}
foo: null

thanks!

@Mrc0113 I think you may have felt a victim to my bad example. Your SpEL expression is wrong. It should be spring.cloud.function.configuration.uppercase.input-header-mapping-expression.foo=headers.contentType.
I am updating tests as we speak, but wanted to give you update ASAP so  you can try

Also, @Mrc0113 I just noticed a nasty bug. I guess I was concentrating so much on getting a composed functions work I forgot to include instrumentation for non-composed functions.
Fixing it as we speak

Would this allow something like this:
spring.cloud.function.configuration.echo.input-header-mapping-expression.key2=header.destination.split(“/“)[4]

Yes, Marc and I talked about it. May not be the most efficient way, but that is a whole other story. .  wok in progress.
Anyway, the above should work, i may even add it to one of the tests.

Awesome stuff @olegz!
I pulled the latest and took it for a spin. It looks to be working for me. I can successfully map headers to other headers.
A few pieces of feedback:

What should be the default if you are trying to access a header that doesn't exist? or splitting a header on "/" like I do below and accessing an index that doesn't exist? Should it fail (like it does now) or default to a value of null for that header and maybe log a warning? I think we discussed this on one of our calls but I don't remember the outcome. I could see some headers potentially being optional so it might be nice for it not to fail. Thoughts?
Spring Tool Suite doesn't like the index on the end of the input-header-mapping-expression. It says you can't use [...] navigation for that property.
Also related to the index, I noticed if I include the index on the first input-header-mapping-expression, but not subsequent ones then the subsequent headers are null, however if I only use the index on the second input-header-mapping-expression then I just get an error when a message is received. It feels a bit inconsistent there. Are you wanting to say you either specify the index on ALL input-header-mapping-expressions or on none? or can I use it on some and not others?
I just wanted to note that it allows me to overwrite an existing header. I think this is fine but wanted to make sure it was an intentional decision.

FYI, @GreenRover I successfully tested this topic hierarchy & config out which maps different levels of a topic to other headers. Your use case is definitely top of mind and please feel free to provide feedback here as well :)

spring.cloud.function.configuration.uppercase.input-header-mapping-expression.company=headers.solace_destination.getName.split("/")[0]
spring.cloud.function.configuration.uppercase.input-header-mapping-expression.department=headers.solace_destination.getName.split("/")[1]
spring.cloud.function.configuration.uppercase.input-header-mapping-expression.system=headers.solace_destination.getName.split("/")[2]
spring.cloud.function.configuration.uppercase.input-header-mapping-expression.version=headers.solace_destination.getName.split("/")[3]
spring.cloud.function.configuration.uppercase.input-header-mapping-expression.type=headers.solace_destination.getName.split("/")[4]
spring.cloud.function.configuration.uppercase.input-header-mapping-expression.object=headers.solace_destination.getName.split("/")[5]

The message had this for headers once it hit the code (You can see the newly mapped headers show up):
Headers: {solace_senderTimestamp=1621457407602, solace_expiration=0, deliveryAttempt=1, solace_destination=acme/mfg/masterData/v1/change/o-ring, type=change, solace_timeToLive=0, version=v1, solace_receiveTimestamp=0, target-protocol=kafka, acknowledgmentCallback=com.solace.spring.cloud.stream.binder.util.JCSMPAcknowledgementCallbackFactory$JCSMPAcknowledgementCallback@387cea97, system=masterData, solace_discardIndication=false, solace_dmqEligible=false, solace_priority=-1, solace_redelivered=false, company=acme, id=93aac5dd-b87a-6333-d5e1-a89cd0542db7, department=mfg, contentType=application/json, solace_senderId=Try-Me-Pub/solclientjs/chrome-90.0.4430-OSX-10.15.7/2313035759/0002, object=o-ring, timestamp=1621457407659}

@Mrc0113

I am struggling myself with the first point, so here are my thoughts. I do not believe it should fail for one simple reason - you really can't control the state of messages coming in, so failing the entire stream just because you had a message which was not fully compatible with your expectations is not a good idea especially given the fact that you can always introduce some filtering function (via composition) that would check for things and would fail explicitly (if that is what you want). So in other words I am advocating for WARN-AND-CONTINUE approach. Thoughts?
I am assuming you mean at the end of the value of the property (headers.solace_destination.getName.split("/")[0]) right? If so, it is outside of my control since you are providing a valid SpEL expression.
Not quite sure what you're saying, perhaps you can provide an example. Also, I just added another test for split so perhaps you can look at it and suggest how to modify it to force this error that you're describing.
Yes, it is fine and fits the pattern of header enrichment which implies any modifications (including removal) to Message headers.

@olegz
1.) I am with you. Warn and continue seams for also to be the correct solution.
@Mrc0113
Thanks for the example helps me to understand ho it should work

@Mrc0113

I am struggling myself with the first point, so here are my thoughts. I do not believe it should fail for one simple reason - you really can't control the state of messages coming in, so failing the entire stream just because you had a message which was not fully compatible with your expectations is not a good idea especially given the fact that you can always introduce some filtering function (via composition) that would check for things and would fail explicitly (if that is what you want). So in other words I am advocating for WARN-AND-CONTINUE approach. Thoughts?
I am assuming you mean at the end of the value of the property (headers.solace_destination.getName.split("/")[0]) right? If so, it is outside of my control since you are providing a valid SpEL expression.
Not quite sure what you're saying, perhaps you can provide an example. Also, I just added another test for split so perhaps you can look at it and suggest how to modify it to force this error that you're describing.
Yes, it is fine and fits the pattern of header enrichment which implies any modifications (including removal) to Message headers.

I also agree with the warn & continue approach for the reasons that you stated. 👍

I'm actually referring to the index to the left of the '='. See screenshot. Note that it still works, just STS doesn't seem to like it.

I created a quick recording to show what I'm talking about, you can download it here: https://tmpfiles.org/37473/screenrecording2021-05-20at09.24.38.mov

@Mrc0113 @GreenRover
Did as discussed and added a failure test to ensure it logs and continues.
Can you please give it one more shot to validate as we are few days away from the release.
Thank you for your patience

thanks @olegz!
Just a heads up that I'll try to kick the tires on it some tomorrow afternoon

Hey @olegz, looks good.
The mapping works for me and I now see the WARN log message instead of an error as discussed above.
I do however still see the issue I described in my previous post, did the video make sense to you and you're okay with that or did you need more info from me?

3. I created a quick recording to show what I'm talking about, you can download it here: https://youtu.be/rhZtloy7gJU

@Mrc0113 sorry, almost missed your video but managed to fix it before kicking off a release - https://github.com/spring-cloud/spring-cloud-function/commit/db6e8ce7b41309aab85c7d86b1af3258ac4603ba

Excellent, thanks @olegz 👏


[Migrated] Zappa Slack appears to be closed by default.

Originally from: https://github.com/Miserlou/Zappa/issues/2132 by jonatkinson
Context
I'm interested in Zappa development, so I followed the Slack link. The Slack appears to be closed by default and requires an invite from an administrator.
Expected Behavior
I would like to join the Zappa Slack.
Actual Behavior
I cannot join the Zappa Slack.
Possible Fix
Adjust the Slack permissions.

Possible alternative solutions.

Switch to GitHub Discussions ?

Is that feature enabled for this repo?

Use an open by default chat tool like Discord.

You can join here.
https://slackautoinviter.herokuapp.com
will be added to the readme.
closing.


33 open vulnerabilities (16 High & 17 Moderate)

Describe the bug
As titled. See this post for additional context.
To Reproduce
Steps to reproduce the behavior:

Fork the repo
Turn on Dependency graph & Dependabot alerts in Code security and analysis
View the alerts under Security tab

Expected behavior
0 vulnerability
Screenshots

Our security stance is clearly documented here for reference: - please review the reporting issues section.
The team regularly reviews these findings for validity and fixes them if they impact DataHub’s operational environment. In addition, we routinely undergo thorough security review as a prerequisite to deployment at enterprises around the world.
As of today, there are 0 unresolved issues from dependabot. All issues have been triaged, vetted and resolved by the committers - this is something that is not visible on project forks.


Themed Icon

Please add an themed icon to the app

It's a duplicate of https://github.com/jonjomckay/fritter/issues/503.


Developerkit V13/UART4 support

Is your feature request related to a problem? Please describe.
The UART4 on Developerkit hardware version V13 can not work correctly
Describe the solution you'd like
Now the default support V13 correctly initializes the UART. If you want to support V12, you must add parameters "hwver=12" at compile time. E.g
aos make clean
aos make hwver=12
Additional context

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Enable get-help pattern tests on Unix

PowerShell-CI-windows failure appears unrelated:
Set/New/Remove-Service cmdlet tests.Remove-Service can accept a ServiceController as pipeline input


Isogram

Not sure why it's failing. The tests all appear to be working

Run $env:Path = "D:\a\cobol\cobol\gnucobol\bin;" + $env:Path
Checking D:\a\cobol\cobol\exercises\practice\hello-world exercise...
Cobolcheck not found. Trying to fetch it.
Run cobolcheck.
Invoke-Expression: D:\a\cobol\cobol\exercises\practice\hello-world\test.ps1:9
Line |
   9 | Invoke-Expression "bin/cobolcheck.exe -p hello-world"
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Program 'cobolcheck.exe' failed to run: An error occurred trying to start process
     | 'D:\a\cobol\cobol\exercises\practice\hello-world\bin\cobolcheck.exe' with working directory
     | 'D:\a\cobol\cobol\exercises\practice\hello-world'. The specified executable is not a valid application
     | for this OS platform.At line:1 char:1 + bin/cobolcheck.exe -p hello-world +
     | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.

Looks good to me and everything seems fine now, I'll go ahead and merge this PR


AWS S3 Retries

Here
We create a backoff read closer, but supply the reader from the HTTP response body only at creation. When we do a retry, it's going to try and read off the same reader, which will fail. Instead we should re-issue the s3 HTTP request so we get a fresh reader.

This appears to still be an issue, at least looking locally in the code, it's possible that it's actually fixed by the code above reissuing the request for the object on failures.


GenericRAII stores only a reference to cleanup function

Refactoring

Pass a cleanup function as function_ref instead of function (but store as function as is).
Rename into ScopeGuard

cf. https://stackoverflow.com/questions/31365013/what-is-scopeguard-in-c

@MatthiasKillat yes, the ScopeGuard terminology is already used by the C++ community


Update de_de.json

Hey @Krxwallo, I'm currently in the process of relicensing Goblin Traders. I would like your permission to relicense your contributions to Goblin Traders under MIT. Thank you.

Yes, you have my permission 👍


chore: alias mix compile and mix clean to make targets

This PR changes the mix compile and clean tasks to also compile and clean other artifacts, via mix aliases.

Seems to clash with CI. We should revisit this


Not compatible with compendium scenes

When I saved scenes into my compendium and later tried to add the scenes from the compendium-- the scene settings had removed the width/length dimensions and the scene image. Upon removing the Scene Defaults module and adding the compendium scene again, it was imported correctly (with background image, proper scene dimensions).
I think the ideal is for Scene Defaults to not override some of those scene-specific fields from compendium scenes, (or not even be used at all for those?)

Thanks for the report, I'll check it out.


fixed over flow of buttons and text on mobile view #47

Description
fixes the over flow of buttons and text in class content
Checklist

[x] I am making a proper pull request, not a spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
#47
Add relevant screenshot or video (if any)
(Add here)

Please resolve the merge conflict

closing the pr generated new one #114


Atomik Custom Skin Typography Issue

Affected Version of Concrete CMS
9.x
Description
When adding a custom skin using Default preset for the Atomik theme there are no options available to change fonts under Typography. If you use the Rustic preset, you only get "Base Font Family" and furthermore if you set it to default font and save the option disappears next time you try to edit. Is this by design or just an oversight? Is there a way to add the ability to change the fonts?
How to reproduce
Login, click Settings button, select "Pages & Themes", click gear on Atomik theme, click "Customize". Click the Pencil icon (Skins & Customizer). Once there you can see issue
Default Presets

Rustic Presets

Rustic ( Selecting Default )

Rustic ( After Saving to Default )

Possible Solution
No response
Additional Context
No response

This is fixed in develop and will be released in 9.1.0


Detect and handle changes in etcd info

The cert info for etcd can change as well as the connection string, and it also needs to trigger the service configs being updated and the services restarted.

Updated so that calico-kube-controller is properly restarted when either the etcd certs change, or the ServiceAccount's ca.crt changes.
Tested as described in https://github.com/charmed-kubernetes/charm-kubernetes-master/pull/34#issuecomment-510186591, went well. Needs review.


Cherry picking two commits from master

Codecov Report

Merging #443 into dtk-3.0 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           dtk-3.0     #443   +/-   ##
========================================
  Coverage    96.83%   96.83%
========================================
  Files          123      123
  Lines         9093     9093
========================================
  Hits          8805     8805
  Misses         288      288

Impacted Files
Coverage Δ

...es/Search/src/details/DTK_DetailsTreeTraversal.hpp
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99e762...994b032. Read the comment docs.


fix: #55 #76 & #77

#55 Use progress-bar-webpack-plugin
#76 Use webpack-chain and add extendWithWebpackChain() to modify Webpack config in an easier way.
#77 Use HashedModuleIdsPlugin and ModuleConcatenationPlugin.

Coverage decreased (-0.4%) to 80.725% when pulling 8612bc4e7d0be8e74ffedf3630815f23c4dade50 on feat-issue#55 into 6e9227700302f747d4e9fc1a94608382fe373793 on master.

#83 也一并修复了


updated usage instructions in README.md

replaced the direct usage of  injector to a more often use form, so that the inexperienced angular users don't afraid of it.

I'm afraid it doesn't cooperate with John Papa Angular 1 styleguide, which should be default, even to rookies.

wow, I wasn't aware of this styleguide, is it de-facto standard? I was looking at how they usually do it in official documentation, ng-book and popular libraries.

@ganqqwerty You should really check out following link:
https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md


feat: Provide a DeliveryMode enum to make clear the choices allowed by the AMQP spec (i.e. 0 or 1)

In relation to https://github.com/lenkan/deno-amqp/issues/41, this should make it more clear what is allowed for the DeliveryMode enum.

@lenkan What are your thoughts on providing these AMQP enums as Typescript enums?

Hi @custompro98. Sorry for late reply. Yeah, it seems like a good idea from a type safety perspective. However, this code is generated from the spec https://raw.githubusercontent.com/rabbitmq/rabbitmq-codegen/main/amqp-rabbitmq-0.9.1.json (also available in other formats here https://www.rabbitmq.com/protocol.html). As far as I can tell, the spec does not explicitly restrict the values that can be passed. So I don't think it should be defined in the BasicProperties interface.
There are more arguments and properties in the spec that are a bit quirky, so it could make sense to have another layer with handwritten types, but I honestly do not think it is worth it.

@lenkan Not a problem, thank you for the response and for sharing the underlying spec. I am by no means a RabbitMQ or AMQP expert, so will defer to your decision.
I was referencing the RabbitMQ publishers documentation and saw DeliveryMode is listed as an Enum type and so was trying to emulate that documentation.


pytar, sdist tool from old hg repository

This is the Python stdlib tar implementation from my 2016 mercurial pull request, plus a src_sdist packging tool.
As of PEP517 sdists are supposed to be PAX-format tar, additionally it's nice to omit the account name and uid from these files.
I might bundle this in enscons instead, but there isn't a way to add formats to SCons.Tool.packaging without monkey patching, is there?

The Appveyor build fail is one of the transients we see from time to time, don't worry about it.
I'd put a small amount of money on @bdbaddog asking for a test to go with this...

I've been thinking about this patch.
On windows due to race condition issues we've seen builds die when python
should have closed a file but the consumer finds the file still opened by a
process. (I believe this is due to python releasing the GIL around file
closing).
Anyway, it might be better to have a python script which scons will run if
there is no tar exe found instead. This way no issue with file handles
still open in process.
Thoughts?
On Sun, May 19, 2019 at 9:13 AM Mats Wichmann<EMAIL_ADDRESS>wrote:

The Appveyor build fail is one of the transients we see from time to time,
don't worry about it.
I'd put a small amount of money on @bdbaddog https://github.com/bdbaddog
asking for a test to go with this...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SCons/scons/pull/3376?email_source=notifications&email_token=AAAUCNBCNH2ACMFVCYIDIF3PWFVAVA5CNFSM4HN25GY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXEGUI#issuecomment-493765457,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUCNEXQ4VQPU4U6Z5GX5LPWFVAVANCNFSM4HN25GYQ
.

The with statement doesn't work?
I think pure python in process tar is right for scons, but what I'd like for me is a way to customize the packaging tool, at a minimum add formats without monkey patching, and change its build directory; these would solve the enscons sdist issues.
On Fri, May 24, 2019, at 8:00 PM, William Deegan wrote:

I've been thinking about this patch.
On windows due to race condition issues we've seen builds die when python
should have closed a file but the consumer finds the file still opened by a
process. (I believe this is due to python releasing the GIL around file
closing).
Anyway, it might be better to have a python script which scons will run if
there is no tar exe found instead. This way no issue with file handles
still open in process.
Thoughts?
On Sun, May 19, 2019 at 9:13 AM Mats Wichmann<EMAIL_ADDRESS>wrote:

The Appveyor build fail is one of the transients we see from time to time,
don't worry about it.
I'd put a small amount of money on @bdbaddog https://github.com/bdbaddog
asking for a test to go with this...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SCons/scons/pull/3376?email_source=notifications&email_token=AAAUCNBCNH2ACMFVCYIDIF3PWFVAVA5CNFSM4HN25GY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXEGUI#issuecomment-493765457,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUCNEXQ4VQPU4U6Z5GX5LPWFVAVANCNFSM4HN25GYQ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/SCons/scons/pull/3376?email_source=notifications&email_token=AABSZEQNVNU2YUTUVOHEBGTPXB6THA5CNFSM4HN25GY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGY7PI#issuecomment-495816637, or mute the thread https://github.com/notifications/unsubscribe-auth/AABSZEWDEZQAVKXQ3CC5TDTPXB6THANCNFSM4HN25GYQ.

shutil.copy() causes the issue. Swapping in win32 CopyFile resolves the
issue.
So I'm pretty sure the issue is multi-thread + python's c code for close
releasing the GIL.
I've not yet created a repro to submit to python devels.
Bring the other packaging issues to the dev mailing list?
On Fri, May 24, 2019 at 6:56 PM Daniel Holth<EMAIL_ADDRESS>wrote:

The with statement doesn't work?
I think pure python in process tar is right for scons, but what I'd like
for me is a way to customize the packaging tool, at a minimum add formats
without monkey patching, and change its build directory; these would solve
the enscons sdist issues.
On Fri, May 24, 2019, at 8:00 PM, William Deegan wrote:

I've been thinking about this patch.
On windows due to race condition issues we've seen builds die when python
should have closed a file but the consumer finds the file still opened
by a
process. (I believe this is due to python releasing the GIL around file
closing).
Anyway, it might be better to have a python script which scons will run
if
there is no tar exe found instead. This way no issue with file handles
still open in process.
Thoughts?
On Sun, May 19, 2019 at 9:13 AM Mats Wichmann<EMAIL_ADDRESS>wrote:

The Appveyor build fail is one of the transients we see from time to
time,
don't worry about it.
I'd put a small amount of money on @bdbaddog <
https://github.com/bdbaddog>
asking for a test to go with this...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/SCons/scons/pull/3376?email_source=notifications&email_token=AAAUCNBCNH2ACMFVCYIDIF3PWFVAVA5CNFSM4HN25GY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXEGUI#issuecomment-493765457
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAUCNEXQ4VQPU4U6Z5GX5LPWFVAVANCNFSM4HN25GYQ

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/SCons/scons/pull/3376?email_source=notifications&email_token=AABSZEQNVNU2YUTUVOHEBGTPXB6THA5CNFSM4HN25GY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGY7PI#issuecomment-495816637>,
or mute the thread <
https://github.com/notifications/unsubscribe-auth/AABSZEWDEZQAVKXQ3CC5TDTPXB6THANCNFSM4HN25GYQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SCons/scons/pull/3376?email_source=notifications&email_token=AAAUCNBGQIVR7O2PSRMLGPDPXCFEHA5CNFSM4HN25GY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWG2GIQ#issuecomment-495821602,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUCNDSNJ6M6RSQZNU2VMTPXCFEHANCNFSM4HN25GYQ
.

This was my solution. With a tar based on the standard library I can prepend the dubiously named $TARPREFIX (put everything in a subdirectory) to each file without actually copying all the files into a subdirectory, and can stop using the Packaging tool entirely. https://bitbucket.org/dholth/enscons/commits/132270824a7ec4f4d6021ef0c1286944044b90ef


added test for beets.ui.commands

Just added my first test case. Please review and comment!

Looks like this is on the right track! Thanks! See a few comments above.

So I implemented most of your suggestions. Any more comments?
Could you explain what self.io.install() did? I just copied it from another test, but did not understand it.

ok .. finally travis is also satisfied

@sampsyo It's probably not worth refactoring all tests but Nosetests actually supports calling setup instead of setUp, to conform with the snake_case rules of PEP 0008

That's awesome, @jackwilsdon; I had no idea.

About self.io.install: that's a DummyIO object, which patches the ordinary input and output streams for the process so that the tests can control them. It's necessary for testing UI code that does print and raw_input, but not for pure code like this.

This looks great. I have one mostly aesthetic comment that might help with maintainability, and then we're ready to merge. Thanks again!

ok, now i implemented your suggestion and travis is also satisfied.
Maybe i should take to always run tox before doing a commit

This looks awesome; thank you! :sparkles:
Fortunately, Travis is always happy to remind you. :smiley:


Read --token from environment variable

Hey!
Currently our deploy scripts have --token $NOW_TOKEN --team <team_name for the now deploy and now alias commands.
It's a small thing, but I feel like having a standard environment variable like NOW_TOKEN and maybe NOW_TEAM that the cli would read from could be nice. Then the deploy script would only be now && now alias.
Let me know what you think.

Configuration is hard! I agree that this would be convenient to have, but there's already so many ways to configure the CLI. I've labeled this with needs community feedback so we can see how much this is requested.

From my perspective, this is much more than an issue of convenience, it is a security concern.  With many CI systems the build output is logged.  And if it is a public project, often the build logs themselves end up being public.  I recently had this situation where my Now token was published in such a log.  The fact that I cannot hide it behind an environment variables but instead must put it on the command line makes it far too easy for these "secrets" to get exposed.  Just as a matter of best security practices, you should allow for an environment variable.  Yes, it is still possible for somebody to accidentally expose the information in a build log.  But they kind of have to go out of their way to do that while with the current approach, it is nearly impossible to prevent.  IMHO.

I expected this a a default and found out it's not implemented yet?
I'd love to have this feature!

Thank you for creating this issue!
Please note that – in order for us to be able to handle each feature request with care – we have to consume all of them through a unified pipeline that makes it easier for us to prioritize, track and progress on the features our user base is interested in.
In turn, the Issues tab on this repository is best only be used for reporting bugs, which we can immediately act on.
For well-explained feature requests (like the one you just posted), please contact us at<EMAIL_ADDRESS>so that we can consider adding it to our roadmap.


"Remove" button too tempting

Pb for admins: when approving users, "Approve" button is left where we approve users on Ramp-studio but the "Remove" button is on the right just below user list to approve to events. Sometimes it's easy to remove someone from event instead of approving them.
I suggest centering the green "Approve" button and putting the red "Remove" button elsewhere on the page, for example far below.

even better than the colors :)


Import image as tilemap

File -> Import
Open an image, and based on some specifications (show a setup window), chop up the image and put its corresponding contents within the tilemap

This can show the setup window, and based on what is entered it will chop up the image accordingly


How to model a side effect? Or, how to work around not being able to declare a side effect?

I'm trying to define a flow-typed wrapper for the package express-ws (WebSockets for Express), and have run into a roadblock:
When you call express_ws(app), the given app gains a new method ws, such that you can then call app.ws(...).
How do I declare this with Flow? Or, if I can't, what's the most appropriate way of working around this deficiency?

My strategy would be to put all your flowtype goodness in the wrapper but don't worry if inside the wrapper source code you have to work around like this:
(app: any).ws(...);

That's better, well at least tidier, than having a // $FlowFixMe comment preceding the app.ws(...) line.

Here is a good article about possible side effect implementation with Flow<EMAIL_ADDRESS>

This is not going to be supported.


Move special handling from source-build to repos

Move special handling to the repos

Msft repos: eng/*.props.
Non-Msft repos: fork the repos, add Arcade wrapper.

Can be, but not necessarily, a full blown GitHub fork.

This refers to odd things like NuGet.config manipulation. Should reduce this over time, but a place to put it that isn't the source-build repo.
Source-build still orchestrates, but very limited build command per repo.
Contrast to lots of custom ops in each source-build repos/*.proj file + common.

[Triage] this is covered by other ArPow issues.


lukegente

Why you want to put this on dev branch?

Como crean el icons de los sub-menu?

What?

As create the icon of the sub-menu?

I dont get what you mean sorry can you make it detailed? They add it to dev branch for icon?


Please who can help me

radio input, is active by default and a window should appear as in the picture if it is active!
Screenshot_2020-10-18-18-51-38-843_com.android.browser.jpg

Hi @maikShoe, can you provide more information about how to reproduce the issue?

Closing for lack of information


how to refund the money back to the user

dear community,
thanks in advance for any help, currently im learning and developing an app, that user can apply for a refund after he achieves some task, is that possible via our google-pay plugin to do this job?  It could be just refund the money to the google play or apple store credit card, I dont have any clue yet, just checking some stack overflow articles.

Processing refunds isn't the task of Google Pay or Apple Pay. It is the task of your payment provider. E. g. Stripe has it's own refund API here

cool, thanks a lot for your answer, I will work on this:)