Add ability to parse js files

Add tests on js file parsing

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6b59fda). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #128   +/-   ##
=========================================
  Coverage          ?   97.22%
=========================================
  Files             ?        4
  Lines             ?       36
  Branches          ?        7
=========================================
  Hits              ?       35
  Misses            ?        1
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b59fda...f2db29f. Read the comment docs.

That's because we have two kind of tests:

unit: with Jest
e2e: with Cypress

Actually, you broke Cypress specs because your changes made Vue components hooks appears, and we don't want them 🙂

Also you should remove package-lock.json files since this project is using yarn, thanks. 🙂

Okay! So there is still this appveyor problem, but i don't know how to solve it.
Is the rest ok for you?

Don't take care of AppVeyor, I don't know why but tests are broken since a long time ago... I will soon replace it with Travis Windows. 👍
Hum, It would be nice to have a Cypress spec for testing .js parsing and rendering.
I can give you some advice if you need.

okay! Will try on my own, i think i have enough examples in the project, thanks.
Talk to you next push :)

Added tests for each templates.
Just copied the Better Component though, hope it is okay ^^'

Thanks, I will take a look ASAP!

Really like the setup you put in place for the tests on the project, think I'll inspire myself of this for next projects :)
Have a tremendous weekend!

Thanks, you too :)


Fix code scanning alert - Clear-text logging of sensitive information

Tracking issue for:

[ ] https://github.com/open-component-model/ocm/security/code-scanning/2

This refers to an example and not the business code


Dependency type to file extension mapping not configurable

The following dependency is not resolvable with gradle.
group:'org.netbeans.cluster', name:'platform', version:'RELEASE82'
http://bits.netbeans.org/nexus/service/local/repositories/release82/content/org/netbeans/cluster/platform/RELEASE82/platform-RELEASE82.pom
Expected Behavior
In the maven world it is possible to define dependency types with a different file extension as the type name. In this case type "nbm-file" should be resolved to "*.nbm"
(See e.g. http://stackoverflow.com/questions/1427722/how-do-i-create-a-new-packaging-type-for-maven)
Current Behavior
The current implementation (as I can see so far) only supports extension = type or a static type to "*.jar" mapping.
See class org.gradle.api.internal.artifacts.ivyservice.ivyresolve.parser.GradlePomModuleDescriptorBuilder
   private String determineExtension(String type) {
        return JarDependencyType.isJarExtension(type) ? "jar" : type;
    }

Context
I try to create a netbeans platform application with gradle using the available netbeans module cluster definitions (see pom link above)
Steps to Reproduce (for bugs)
Run the following build script:
configurations {
    myConfig
}
dependencies {
    myConfig group:'org.netbeans.cluster', name:'platform', version:'RELEASE82'
}
task build {
    doLast {
        configurations.'myConfig'.resolve().each {
            System.out.println("Resolved file ->" + it);
        }
    }
}

Environment
Running gradle 3.2.1 on a mac using jdk1.8.0_112.

I was first thinking that you can solve your use with the help of dependency resolve rules. Unfortunately, you can only replace the attributes group, name and version of a dependency. The extension is currently not configurable.
Question from my end: It seems that the reason why you are trying to remap the file extension is the fact that the metadata in the provided repository is wrong. Is that a correct observation?

From a maven point of view, I think, the meta data is right. For special types like "ejb" or "test-jar" there exists already a static mapping in gradle. Why is mapping "ejb" -> "jar" fine? Why I can't map 'nbm-file' -> 'nbm"? (See  org.gradle.api.internal.artifacts.ivyservice.ivyresolve.parser.GradlePomModuleDescriptorBuilder.JarDependencyType)
By the way, the meta data is not under my control.

I see what you are saying now. I believe we have the mapping because ejb and test-jar are common, special types. So far I haven't encountered nbm-file. It's probably just used for Netbeans-related artifacts.
Instead of tagging on to the list of special mappings I'd rather like to see a stronger concept exposed through the Gradle API. From my perspective hooking into the dependency resolve rules would make sense. We don't necessarily want to expose Maven-specific internals as Gradle's dependency management aims to abstract differences between supported repository types (e.g. Maven, Ivy etc.). Would you be interested in writing a design doc for this?

@fvogler in case you, or others, are still looking for a solution here. With Gradle 6, we embrace component metadata rules as the concept to add missing information to pom metadata. Which I think can be used here.
You can have a rule that adds the npm file to the metadata. Ideally, you would declare it as a separate variant.
Example: https://docs.gradle.org/release-nightly/userguide/component_metadata_rules.html#making_variants_published_as_classified_jars_explicit (this one is for artifacts with different classifiers, but different extensions work similar)

Closing as an alternate solution was offered.


fix: dashboard show Created in user timezone

It's a terminal based UI, so I guess we should display time in user's timezone instead of UTC

Thanks,
Locally before
+---------------------------+-------+------------+--------------------------+------------+----------+
|          Created          | Count | Entrypoint | Time in Queue (HH:MM:SS) |   Status   | Priority |
+---------------------------+-------+------------+--------------------------+------------+----------+
| 2024-10-29 12:51:31+00:00 | 1335  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:31+00:00 | 1265  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:30+00:00 | 5565  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:30+00:00 | 5495  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:29+00:00 | 5667  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:29+00:00 | 5683  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:28+00:00 | 5621  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:28+00:00 | 5629  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:27+00:00 | 5648  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 12:51:27+00:00 | 5772  | asyncfetch |         0:00:00          | successful |    0     |

Locally after
+---------------------------+-------+------------+--------------------------+------------+----------+
|          Created          | Count | Entrypoint | Time in Queue (HH:MM:SS) |   Status   | Priority |
+---------------------------+-------+------------+--------------------------+------------+----------+
| 2024-10-29 13:51:23+01:00 | 3450  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:23+01:00 | 3314  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:22+01:00 | 5633  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:22+01:00 | 5457  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:21+01:00 | 6191  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:21+01:00 | 6189  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:20+01:00 | 6144  | asyncfetch |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:20+01:00 | 6016  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:19+01:00 |  782  | syncfetch  |         0:00:00          | successful |    0     |
| 2024-10-29 13:51:19+01:00 |  748  | asyncfetch |         0:00:00          | successful |    0     |

LOVE that!


Replace dependency on RequestStream in Request.Body with Stream

Prerequisites

[x] I have written a descriptive pull-request title
[ ] I have verified that there are no overlapping pull-requests open -  overlaps with #1920
[x] I have verified that I am following the Nancy code style guidelines
[x] I have provided test coverage for my change (where applicable)

Description
Use case:
We're uploading large blob files via a Nancy API
The default RequestStream implementation spools out to disk where the size of the incoming request is >85kb to avoid pressure on the Large Object Heap
When requests are aborted, or generally when errors occur, these temp files can leak and cause %TEMPDIR% to run out of space. (I have submitted a few PRs around this in the past but it seems we can't avoid this behaviour, we can't clean up the file in the RequestStream destructor as in the finalizer we have lost the reference to the File)
Since RequestStream is a drop-in-replacement for Stream, it seems logical to use the base class as the Body property on Request, this will allow me to swap in a different Stream implementation such as https://github.com/Microsoft/Microsoft.IO.RecyclableMemoryStream
This also includes tracing so I can troubleshoot where Nancy may be leaking the Request.Body stream.
I can't inherit from/override RequestStream since it has no paramaterless ctor, and this would be a cleaner approach anyhow.
Warning: possible conflicts with #1920

With this change, I can swap out RequestStream with another implementation here: https://github.com/NancyFx/Nancy/blob/a9989a68db1c822d897932b2af5689284fe2ceb8/src/Nancy/Owin/NancyMiddleware.cs#L84

I've reviewed #1920 and I'm fairly sure this change will have no impact on that PR.

By making Request use Stream and not RequestStream won't that undo the work put into RequestStream.cs?

This looks fine to me, we will still use RequestStream but others can use another inherited Stream class and write their own Middleware extension to use that

Assuming this is ok to merge, any chance of getting it backported to 1.x?

Pinging @thecodejunkie
On Wednesday, 3 August 2016, Dan Barua<EMAIL_ADDRESS>wrote:

Assuming this is ok to merge, any chance of getting it backported to 1.x?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NancyFx/Nancy/pull/2512#issuecomment-237270911, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGaplTjrr5DRtbQb1Z8tg83d3FB4slHks5qcMFsgaJpZM4JP3Fm
.

Agree that this is good to go. Merging


primesieve: 11.2 -> 12.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kimwalisch/primesieve/releases.
meta.description for primesieve is: Fast C/C++ prime number generator
meta.homepage for primesieve is: https://primesieve.org/
meta.changelog for primesieve is: https://github.com/kimwalisch/primesieve/blob/v12.0/ChangeLog
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 12.0 with grep in /nix/store/62br5r556jrf1ha2nnlqi70f3kmilczm-primesieve-12.0
found 12.0 in filename of file in /nix/store/62br5r556jrf1ha2nnlqi70f3kmilczm-primesieve-12.0

Rebuild report (if merged into master) (click to expand)

15 total rebuild path(s)

15 package rebuild(s)

First fifty rebuilds by attrpath
cantor
haskellPackages.primecount
haskellPackages.primesieve
labplot
libsForQt5.cantor
openturns
plasma5Packages.cantor
primecount
primesieve
python311Packages.openturns
python311Packages.primecountpy
python312Packages.openturns
python312Packages.primecountpy
sage
sageWithDoc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/62br5r556jrf1ha2nnlqi70f3kmilczm-primesieve-12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A primesieve https://github.com/r-ryantm/nixpkgs/archive/929ed3cde7a6f910e46d93c6752651fc1724250e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/929ed3cde7a6f910e46d93c6752651fc1724250e#primesieve

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/62br5r556jrf1ha2nnlqi70f3kmilczm-primesieve-12.0
ls -la /nix/store/62br5r556jrf1ha2nnlqi70f3kmilczm-primesieve-12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @timokau @omasanori @7c6f434c @collares @abbradar @AndersonTorres for testing.

@ofborg build sageWithDoc

Failure on aarch64-linux seems to be different from the Hydra failure…

 The failure on this PR is an intermittent due to the test being random, I've filed an issue upstream.


Multiple connections

Need to somehow get it to master

in favor of https://github.com/tiramizoo/dataclips/pull/3


Wilson Bug

Description
 wilson crash bug
Steps to reproduce

Expected behavior

Examples

Game details (please complete the following information):

Platform: [e.g. Steam]
Version [e.g. 1.21]

Additional context

some reason why I walk up to wilson and try to buy something from him, the game completely crashes

This is not related to RED4ext.


Function DebloatAll doesn't remove any package on Windows 10 21H1

With Windows 10 21H1, after a clean install, function DebloatAll doesn't remove any package. When launching Windows10Debloater.ps1 script with admin rights, result for this part is just:

Uninstalling bloatware, please wait.
Bloatware removed.

No Deployment operation progress message is displayed, function exits immediately, and no app is actually removed (all apps are still present in Start menu after the script completes, e.g. 3D Viewer, Alarms & Clock, Calendar...).
Following some tests, it seems this is due to the *Nvidia* value in the $NonRemovable variable; after removing it and relaunching the script, all apps get removed as expected.
The other functions seem to run successfully, except for UninstallOneDrive (not a big issue though as it can be uninstalled from Windows)
One minor note: Windows Camera and Microsoft Sticky Notes are indicated in Bloatware that is removed documentation section, while they are actually not ;)

I also have found this to be the case. It says "bloatware removed" but in fact no programs were removed

Thanks for the info. Looking into this.

Hi I ha ve reached the very same conclusion. Patiently await the resolution..

I have the same problem , any solution?


terraform: 1.3.4 -> 1.3.5

Description of changes
https://github.com/hashicorp/terraform/releases/tag/v1.3.5
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Please don't skip CI.


Update oracle-database.md

correct spelling

@bezhan-msft
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Admin/update pip on dependency check

Simplify dependency test script.
New way to invoke the script:
scripts/dependency_test.sh acm
The CI is now responsible for retrieving the list of services, and invoking the script once per service. This ensures that we our virtual environments are properly delineated.

Codecov Report

Merging #5827 (faa403c) into master (27a2e42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5827   +/-   ##
=======================================
  Coverage   96.18%   96.18%
=======================================
  Files         753      753
  Lines       73969    73969
=======================================
  Hits        71150    71150
  Misses       2819     2819

Flag
Coverage Δ

servertests
36.95% <ø> (ø)

unittests
96.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Regression on the fix for #50

I'm still seeing the _Print member. Either I dind't test it properly last time or the behavior has regressed
Repro:
Go to XmlProvider.fsx in F# Data (https://github.com/fsharp/FSharp.Data/blob/master/docs/content/library/XmlProvider.fsx#L276)
and add the type t = OutputXml.OrderLine  line:

#50
/cc @forki

It seems to only still be a problem in provided types.  And FWIW the member is not present in intellisense, only the tooltip.
This seems like a weird scenario - is the provided type inheriting from a record type?

Yes, the provided type inherits from a record type: https://github.com/fsharp/FSharp.Data/blob/master/src/Xml/XmlRuntime.fs#L61
The original bug was never about IntelliSense, was always about the tooltip

Is the _Print guy also implemented directly by the provided type, or does it only come along as part of the base type? From quick tests it doesn't look like base class members are normally shown at all in the tooltip for sub types.
Record types are supposed to be sealed I thought, I'm surprised you are permitted to inherit from them.  Maybe this is a bug that it's allowed at all?

It only comes from base type. This is not real inheritance, though, it's the base type for an erased type.

I see the issue, provided types are routed to a different function that was not updated with the original fix.  I'm testing a fix now.


Node 8 S2I, RPM updates

Updates for our S2I images, RPMs for Node 8 release coming soon

@balunasj is this for the centos7-s2i-nodejs images? If so, I think it can be closed - though we don't depend on the RPMs for this. Or do you want to produce another set of images that uses the RPMs and runs Fedora?

Yup, so it's all set! :-)


KeyError: 'resnet101_base'

Hi, I met error when running your code and I don't know how to fix it. Look forward to your reply!!
File "/home/lihang/OCNet/train.py", line 177, in
main()

File "/home/lihang/OCNet/train.py", line 70, in main
deeplab = get_segmentation_model("_".join([args.network, args.method]), num_classes=args.num_classes)
File "/home/lihang/OCNet/network/init.py", line 15, in get_segmentation_model
return networksname.lower()
KeyError: 'resnet101_base'

Please check the https://github.com/PkuRainBow/OCNet/blob/80229a04ab68e6cdfc60a9db536fda16ffb2796f/network/init.py#L8
You should change the 'resnet101_base' with 'resnet101_baseline'.
You are recommended to read most of the code before you make any modifications.

Thank you for your reply, but I have met another issue.
When I run the code, after showing the list of parameters below, nothing is displayed, I waited for 14 hours, and nothing to show. I am confused.....

not_restore_last False
snapshot_dir     ./snapshots_psp_ohem_trainval/
dsn_weight       0.4
save_epoch       20
save_pred_every  5000
gpu              1
whole_scale      1
use_weight       None
store_output     False
data_dir         /home/lihang/OCNet/dataset/data
ohem_thres1      0.8
use_extra        None
pair_weight      1
save_num_images  2
41650 images are loaded!
learning_rate: 0.01

Thank you for your reply, but I have met another issue.
When I run the code, after showing the list of parameters below, nothing is displayed, I waited for 14 hours, and nothing to show.  Could you tell me how to solve this issue? I also have this issue.
Look forward to your reply!!
Thank you!

Hi! I just solved the issue by enlarging the memory, You can try to see if it works.

Hi! I just solved the issue by enlarging the memory, You can try to see if it works.

How many memory do you use?

Hi! I just solved the issue by enlarging the memory, You can try to see if it works.

How many memory do you use?

two NVDIA TITAN Xp GPU with 12 GB RAM

@rinawhale
I have 2 1080ti with 11GB RAM.
Could you tell me the number of BATCHSIZE?

@rinawhale
I have 2 1080ti with 11GB RAM.
Could you tell me the number of BATCHSIZE?

I set batchsize = 2

Please check the https://github.com/PkuRainBow/OCNet/blob/80229a04ab68e6cdfc60a9db536fda16ffb2796f/network/init.py#L8
You should change the 'resnet101_base' with 'resnet101_baseline'.
You are recommended to read most of the code before you make any modifications.

Could you tell me exactly how to operate it?


fix: bugfix when last() with null value throws exception

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines: https://github.com/HackedByChinese/ng2-idle/blob/master/CONTRIBUTING.md#pr
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
LocalStorageExpiry -> last() with null value throws error because null.getTime() doesn't exists
What is the new behavior?
Add some validation on parameters to check if param is null.
If null, remove key on localStorge, otherwise, set key
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Coverage increased (+0.003%) to 99.282% when pulling 5b3d1757ecda48be8b9ee25ced53909e995cea4b on rousseaufiliong:master into 708aa9f1ca7caff944942eb08eaeab5abd446536 on HackedByChinese:master.

Coverage increased (+0.04%) to 99.317% when pulling 935ade9ae33ae6641b6bfd475497c8b189d5d8d2 on rousseaufiliong:master into 708aa9f1ca7caff944942eb08eaeab5abd446536 on HackedByChinese:master.

Coverage increased (+0.04%) to 99.317% when pulling e99173030e4cb78dabe7ce8bcb743afb6efdda65 on rousseaufiliong:master into 708aa9f1ca7caff944942eb08eaeab5abd446536 on HackedByChinese:master.

Two issues is fix by this pull request. The first one is related by the bug #36. The second one is when we use LocalStorageExpiry and AutoResume.notIdle, onIdleEnd is not emit in each tab. This bug is resolve by adding in the localstorage a key "idling", and our idle will check on storage event if idling value have changed.


docs: fixed css_selector for example

Fix CSS selector in README example
Description
This pull request updates the CSS selector in the Advanced Usage example in the README.md file. The change fixes a non-functioning example and ensures that the crawler can successfully extract content from the NBC News business page.
The previous selector "article.tease-card" was not functioning correctly and failed to extract any data from the NBC News business page. The new selector .wide-tease-item__description successfully targets the description text of the news articles, allowing the crawler to extract the intended content.
Changes

Updated the css_selector parameter in the crawler.arun() method from "article.tease-card" to ".wide-tease-item__description".

@hitesh22rana Thx for you pull request, already merged. Appreciate the support.


update vagrant scripts to support kubernetes 1.14

Signed-off-by: samuel.elias<EMAIL_ADDRESS>

Coverage increased (+0.1%) to 72.109% when pulling 11e6582054613fae393e555c8f190724d5350f2a on samelias:kube_cni into d9f96c0fc6b3e97b8d0a1b9a7cb0a51d99a83716 on contiv:master.


feat: get client ip from x-forwarded-for header if available

Description
This PR will enable the getClientIp function to return the proper client IP in cases where Uptime Kuma is running behind a reverse proxy, giving better logs.
Type of change

New feature (non-breaking change which adds functionality)
Other

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

I believe it is not safe. The header value can be modified in client side?

Indeed, but the function is only ever used for logging, meaning it won't have any security implications for the application

@theS1LV3R thanks for the PR!
I was about to write more or less the same thing after noticing the issue behind a reverse proxy ...
Just one thing, instead of:
return socket.client.conn.request.headers["x-forwarded-for"]             || socket.client.conn.remoteAddress.replace(/^.*:/, "");
it should be:
return socket.client.conn.request.headers["x-forwarded-for"]              || socket.client.conn.request.headers["x-real-ip"]             || socket.client.conn.remoteAddress.replace(/^.*:/, "");

Thank you! Pushed it just now

Unfortunately, this still does not fix the problem when the application is set behind a reverse proxy and socket.client.conn.remoteAddress is empty.
Trace: TypeError: Cannot read properties of undefined (reading 'replace')
    at UptimeKumaServer.getClientIP (/usr/home/passenger/uptime-kuma/server/uptime-kuma-server.js:134:59)
    at Socket.<anonymous> (/usr/home/passenger/uptime-kuma/server/server.js:257:43)
    at Socket.emit (node:events:527:28)
    at Socket.emitUntyped (/usr/home/passenger/uptime-kuma/node_modules/socket.io/dist/typed-events.js:69:22)
    at /usr/home/passenger/uptime-kuma/node_modules/socket.io/dist/socket.js:466:39
    at processTicksAndRejections (node:internal/process/task_queues:78:11)
    at process.<anonymous> (/usr/home/passenger/uptime-kuma/server/server.js:1711:13)
    at process.emit (node:events:527:28)
    at emit (node:internal/process/promises:140:20)
    at processPromiseRejections (node:internal/process/promises:274:27)
    at processTicksAndRejections (node:internal/process/task_queues:97:32)
If you keep encountering errors, please report to https://github.com/louislam/uptime-kuma/issues

Maybe something like this would be a better solution?
async getClientIP(socket) {
    const clientIP = socket.client.conn.remoteAddress;

    if (await setting("trustProxy")) {
        return socket.client.conn.request.headers["x-forwarded-for"]
            || socket.client.conn.request.headers["x-real-ip"]
            || clientIP.replace(/^.*:/, "");
    } else {
        return clientIP.replace(/^.*:/, "");
    }
}

Did not noticed that the remoteAddress could be undefined, thanks for the fix.


pod antiaffinity strategy evicts all pods.

Pod anti affinity strategy doesn't have a check on type of pod to be evicted. It can evict critical, mirror pods.  As this is some functionality that needs to be respected by all strategies in descheduler, I am planning to move this to pods.go to avoid code duplication so that people implementing strategies won't have to think about them.

cc @aveshagarwal


Change ss to ss3 in doc; also change gender to sex in tutorial

Main changes were changing all instances of ss to ss3 in 12runningSS.tex (even title from 12runningSS to 12runningSS3) and changing in tutorial files.
Change gender to sex in model tutorial file.
Minor formatting changes in other files.

@Rick-Methot-NOAA, on further review, it looks like this PR is mostly just changing "SS" to "SS3" and a few instances of "3.24" to "v.3.24" or "3.30" to "v.3.30", not replacing "SS3.30" (which was already rare in the documentation ). So maybe no further change in the version numbers are needed.

Ok, so could be OK.  In my thinking, SS3.30 is version 30 of SS3.  So I agree that the statement "version SS3.30" is not correct.  But stating "v.3.30" does not seem quite correct either because that would be version 3.30 of SS, not of SS3.

All references to versions of stock synthesis should be one of 3 variations:
stock synthesis v.3.xx.xx
v.3.xx.xx
version(s) 3.xx.xx

@Rick-Methot-NOAA can you review the latest commit including language about Jason's app?

@Rick-Methot-NOAA can you provide a final review on this so that I can merge?


HSTS patch 1

Tweaks only

Not 100% certain that turning HSTS header on/off based on client_secure is correct... depends if we running behind a secure reverse proxy, we should be responsible for adding the header or the proxy should be?

Commit 86eabe092a3539ecf305c54632a503f606367851 makes the change to use bst::optional, not sure whether it's better or not? 🤷
(The ternary ?: repeated in nmos/node_server.cpp and nmos/registry_server.cpp could be factored into a function in nmos/settings.h though then #include "bst/optional.h" would be needed there. 😕)

Agreed with @lo-simon that the bst::optional version was easier to maintain, so I've done some clean up and force pushed. I then found a bug in the handling of quoted strings in directive values, so I've fixed that and added more unit tests. Assuming this builds successfully on all platforms in CI, this is good for a final review...


Add project from a custom preview/live host

It should be possible to add/remove projects while on a configured custom preview or live host.

we could do the following:

make the discover service aware of the custom preview/live hosts
have the Add Project always in the context menu
in case, the project cannot be deduced from the standard url, add project will open a dialog; something like:

No Franklin Project could be associated immediately with this website:

<.....url.....>

Click to resolve: [resolve]

when clicking [resolve] the sidekick will ask the discover service and when configure the project.


Allow to create buckets from handpicked paths

The config could be something like this:
export default {
  key: "my-key",
  optionsUrl: import.meta.url,
  entry: "app.ts",
  buckets: [
    {
      name: "mybucket",
      items: [
        "data/countries/population.csv"],
        "data/fruits/vitamins.csv"],
    },
  ],
  output: "app.bundle.js",
};

this does not fit with the new version


Uncaught TypeError: htmlParser.parseFragment is not a function

at renderHTML (bundle.js:64677)
at Alert.render (bundle.js:26880)
at bundle.js:48657
at measureLifeCyclePerf (bundle.js:47936)
at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (bundle.js:48656)
at ReactCompositeComponentWrapper._renderValidatedComponent (bundle.js:48683)
at ReactCompositeComponentWrapper.performInitialMount (bundle.js:48223)
at ReactCompositeComponentWrapper.mountComponent (bundle.js:48119)
at Object.mountComponent (bundle.js:6558)
at ReactCompositeComponentWrapper.performInitialMount (bundle.js:48232)

The error means that parseFragment doesn't exist in parse5 parser, which should exist. I think it's no react-render-html issue. Please check if parse5 is installed and bundled correctly.


att_bill_pay does not login

I've gotten a few reports about att_bill_pay login not working. I'm currently looking into fixing it.
Here is a patch for Windows that I'm testing.
debbit-v2.0.2-dev-att-patch-win64.zip

Thank you so much for this amazing solutions!


Basta broken

since 1068f313039c69fc9b

Thanks for reporting @mro.
Can you provide some more details about what is broken exactly?
I just tried https://bridge.suumitsu.eu/?action=display&bridge=Basta&format=Html and to me it looks fine (though I don't use it regularly).

it brings an empty (blank, white) results html page. Plz try a clean install.

I think the form $this->uri may not be en vogue no more.

it brings an empty (blank, white) results html page. Plz try a clean install.

I just did and it still works for me. Do you receive an error message if you enable the debug mode?

I think the form $this->uri may not be en vogue no more.

You are correct. $this->uri was replaced by the constant URI which is now called via self::URI. In master however this is correctly implemented: https://github.com/RSS-Bridge/rss-bridge/blob/master/bridges/BastaBridge.php
Which commit are you working on?

from the one mentioned above until master back then. A git bisect session found the one mentioned at the top.

So, does that mean it is fixed in the current master?

ouch, sorry, my php was a bit frowsty. Version 5.3.
Now with 7.0 things work fine.

Ah, good point. Glad to hear it works for you now!
PHP requirements recently changed from 5.4 to 5.6, it may have worked with 5.3 before, but not anymore. I will check if it is possible to detect the PHP versions in order to return appropriate error messages in the future.

oh, too optimistic, now (also with php v5.6) I get for Basta as well as Arte (and mybe more):
Could not request Bastamag.

$ git clone https://github.com/RSS-Bridge/rss-bridge.git
$ cd rss-bridge
$ git log --oneline -1
5790ebc [index] Initialize variable before using it
$ curl "http://rssbridge.mro.name/?action=display&bridge=Basta&format=Html"
Could not request Bastamag.

adding allow_url_fopen=1 to php ini made the error message go away, now it's a blank white page (I cleared ./cache before)

I have had a similar issue in the past where no bridge was working.

adding allow_url_fopen=1 to php ini made the error message go away, now it's a blank white page (I cleared ./cache before)

That's what I was searching for!
You should now receive data at least (I just tried the Wikipedia bridge with your link and it works)
Try adding a print $html after loading the HTML content in the Basta bridge. That way we know if any content was returned.

sigh, now the browser cache had fooled me. Bridge works.
I may add the fopen part to the install instruction.
Thx for your patience!

btw. Arte still responds empty.

Nicely done 👍

I may add the fopen part to the install instruction.

That would be awesome!

Yeah, Arte is empty for me too

Okay, I have fixed the Arte bridge. Please have a look at https://github.com/RSS-Bridge/rss-bridge/commit/8924722b934e9a59f848fda9aedfab1550cf3978 and try the current master.

awesome, works fine, thx!

however, feedvalidator doen't like it: http://www.feedvalidator.org/check.cgi?url=http%3A%2F%2Frssbridge.mro.name%2F%3Faction%3Ddisplay%26bridge%3DArte7%26catde%3Dalle-videos%26format%3DAtom

So we basically return a couple of whitespaces at the beginning and the content type is incorrect. That's actually interesting, because according to this we don't have whitespace at the beginning and due to this the content type should be application/atom+xml
There is a bug in the matrix somewhere 😄
I guess the content type gets updated again later on, though right now I have no clue where and why. Very interesting...

Okay it is fixed now. Wasn't that hard :laughing: https://github.com/RSS-Bridge/rss-bridge/commit/72981032e4a6c444dbad2c9972e33ba473a9981c

thx, feedvalidator (see above) says it's valid now, however still grumbles a bit.

Those are due to the nature of how RSS-Bridge builds the output based on a template. Of course if no value is provided, the template remains empty or uses a default value. This can be  fixed by omitting any field that is left empty.


Fix undefined exception in API GW mgmt

@csantanapr - a good travis run should be a sufficient test


Sidebar don't work correctly in RTL build

when build css in rtl mode sidebar don't work correctly as well as the your demo in Arabic language .

body {
font-size: 15px;
height: 100%;
direction: rtl;
}
#side bar class
.ui.right.demo.vertical{
direction: ltr;
}


Mutual TLS on ApiGateway2

Api Gateway has a new feature for Mutual TLS. Can we please implement this?
References:
Announcement
Blog Post
Developers Guide (HTTP Api)
Developers Guide (Rest Api)
Requires:
AWS SDK v1.34.26

Also here is the CloudFormation Documentation for this:
CloudFormation Documentation


[FEATURE]:Added Whatsapp share button

I have added the WhatsApp share button for issue #21
I have also added the facebook icon.Its just an icon for now.For issue #12 I will open another pull request and add the share link for fb.
It will easier to make the pull request for issue #12 after this pr is merged to maintain uniformity.

button is working fine,
UI is okay,
but a request, can you make a fetch from the repo,
as original repository is a bit ahead of yours,
for example.

this buttons are changed in original repo

button is working fine, UI is okay, but a request, can you make a fetch from the repo, as original repository is a bit ahead of yours, for example.  this buttons are changed in original repo

can you work on this a bit?

Did the whole ui change during this time?

Did the whole ui change during this time?

It now has a white background

Hopefully it should be fine now

Excellent job 🔥


Handling variable number of devices in CI and failing native tests

Change for #847

This change is

PR is added to the queue for testing as 1. task. (5fdde63)

Hi @czyzm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Success) 82147046 build is completed (5fdde63)
See https://github.com/ThaliTester/TestResults/tree/821470465fdde63_Handling_variable_number_of_devices_in_CI_and_failing_native_tests_czyzm/ for the logs

Test 821470465fdde63(5fdde63) has failed
See https://github.com/ThaliTester/TestResults/tree/821470465fdde63_Handling_variable_number_of_devices_in_CI_and_failing_native_tests_czyzm/ for the fail logs

PR is added to the queue for testing as 1. task. (d1155fd)

Test (Success) 82147046 build is completed (d1155fd)
See https://github.com/ThaliTester/TestResults/tree/82147046d1155fd_Handling_variable_number_of_devices_in_CI_and_failing_native_tests_czyzm/ for the logs

Test 82147046d1155fd(d1155fd) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/82147046d1155fd_Handling_variable_number_of_devices_in_CI_and_failing_native_tests_czyzm/ for the logs

test/TestServer/UnitTestFramework.js, line 41 [r2] (raw file):

util.inherits(UnitTestFramework, TestFramework);

UnitTestFramework.prototype.abortRun =

NB: This function is almost identical with finishRun() so maybe it would be worth to extract common part

Comments from Reviewable

test/www/jxcore/lib/thaliTape.js, line 316 [r2] (raw file):

  // On mobile, or outside of jxcore (some dev scenarios) we use
  // the server-coordinated thaliTape
  exports = thaliTape;

I wonder why we're introducing a global variable here?

Comments from Reviewable

Reviewed 7 of 8 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

test/TestServer/UnitTestFramework.js, line 41 [r2] (raw file):
Previously, jareksl (Jarosław Słota) wrote…
> NB: This function is almost identical with finishRun() so maybe it would be worth to extract common part

Will refactor it.

test/www/jxcore/lib/thaliTape.js, line 316 [r2] (raw file):
Previously, jareksl (Jarosław Słota) wrote…
> I wonder why we're introducing a global variable here?

It is a bit tricky. module.exports and exports initially reference the same object and can be used interchangeably. Such construction was probably introduced in order to keep the consistency (exports pointing to the same object as module.exports). I would change it a bit to keep the consistency but to make it more readable.

Comments from Reviewable

PR is added to the queue for testing as 1. task. (3bd5c99)

Test (Success) 82147046 build is completed (3bd5c99)
See https://github.com/ThaliTester/TestResults/tree/821470463bd5c99_Handling_variable_number_of_devices_in_CI_and_failing_native_tests_czyzm/ for the logs

Test 821470463bd5c99(3bd5c99) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/821470463bd5c99_Handling_variable_number_of_devices_in_CI_and_failing_native_tests_czyzm/ for the logs

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


stable operation under load

I started the application in kubernetes
with this manifest:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: file-convert-service-gotenberg-deployment
  labels:
    name: file-convert-service-gotenberg
spec:
  replicas: 1
  selector:
    matchLabels:
      app: gotenberg
  template:
    metadata:
      labels:
        app: gotenberg
    spec:
      containers:
        - name: gotenberg
          securityContext:
            privileged: false
            runAsUser: 1001
          image: "dreg.example.com/dockerhub/gotenberg/gotenberg:7.7.0"
          imagePullPolicy: IfNotPresent
          ports:
            - name: http
              containerPort: 3000
              protocol: TCP
          livenessProbe:
            httpGet:
              path: health
              port: http
          readinessProbe:
            httpGet:
              path: health
              port: http
          resources:
            limits:
              cpu: 500m
              memory: 512Mi
            requests:
              cpu: 500m
              memory: 512Mi

if the application is idle for a couple of minutes, then the first conversion attempts will be unsuccessful, a 500 error will be thrown, and such an entry in the logs:
{"level":"error","ts":1667816697.079552,"logger":"api","msg":"convert to PDF: unoconv PDF: unix process error: wait for unix process: exit status 5","trace":"cff58268-fc06-412b-b76c-9c67e3941c78","remote_ip":"<IP_ADDRESS>","host":"file-convert-service/example.com","uri":"/forms/libreoffice/convert","method":"POST","path":"/forms/libreoffice/convert","referer":"","user_agent":"curl/7.79.1","status":500,"latency":446446326,"latency_human":"446.446326ms","bytes_in":100566,"bytes_out":21}

after that, I keep trying, every second after an unsuccessful response, and the code 500 is returned to me 7-8 more times. after that the conversion is successful. how can i fix this? maybe I should disable unnecessary modules? or something else to tweak?

added an argument, but it did not fix the situation:(
          command: ["gotenberg"]
          args: ["--uno-listener-restart-threshold=0"]

Hello @KraMorK,
I wonder if increasing the CPU and/or the memory limit may resolve your issue.

Hello @gulien,
increased resources
    limits:
      cpu: 1
      memory: 1024Mi
    requests:
      cpu: 1
      memory: 1024Mi

The situation has not changed
Application does not consume allocated resources,
actual consumption no more than 300 mCPU and 300 Mb RAM

according to the advice from https://github.com/gotenberg/gotenberg/issues/442#issuecomment-1086679877 I downgraded the version to 7.4.3, the problem is gone, it works much more stable. on test 100 attempts there was not a single conversion error

Thanks @KraMorK. I suspect the latest LibreOffice version to have a stability issue.

@KraMorK could you try the image gulnap/gotenberg:libreofficefix? It's using a downgraded version of LibreOffice (7.0.4) but with the  Gontenberg 7.7.1 codebase.

Release 7.7.2 is now available with the fix. Please open a new issue if the problem still persist 😄


Add get_ref/get_mut/get_pin_mut/into_inner methods

This adds get_ref/get_mut/get_pin_mut/into_inner methods to stream/sink combinators.
Currently, some combinators have these methods (e.g., stream::Buffered), but I think that more combinators can be implemented.
Related https://github.com/rust-lang-nursery/futures-rs/commit/dd6b045693f3d1ae611f4b9f9afd739a3be30939, https://github.com/rust-lang-nursery/futures-rs/issues/633
Closes https://github.com/rust-lang-nursery/futures-rs/issues/573
Closes https://github.com/rust-lang-nursery/futures-rs/issues/400
(These issues are feature requirements for 0.1, but we will not actively develop 0.1, so closes by this PR)

Looks like this had a merge-conflict with #1538 in master.

Yeah, I saw that-- I'll have a fix out later today.


Rename issuerPays in swaps

Fixes https://github.com/digital-asset/daml-finance/issues/311

Thanks! Just left a very minor proposal, let me know what your thoughts are

Thanks for the review and for the proposal!


Local pull request success status testing

Docs Build status updates of commit 2a70ece:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 2a70ece:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


"Removing from ens" message from wrong ensemble

I wonder why I got the following message on the console:
	Removing from ens E0A101: Radio Sraka SID = 0xE4943D, SCIdS = 0
	Removing from ens E0A101: MMR SID = 0xE49456, SCIdS = 0
	Removing from ens E0A101: Radio Maxi SID = 0xE49428, SCIdS = 0
	Removing from ens E0A101: Radio Maribor SID = 0xE49426, SCIdS = 0
	Removing from ens E0A101: Radio Krka SID = 0xE49423, SCIdS = 0
	Removing from ens E0A101: Radio Celje SID = 0xE49413, SCIdS = 0
	Removing from ens E0A101: Radio Ptuj SID = 0xE49434, SCIdS = 0
	Removing from ens E0A101: Antena Celje SID = 0xE4965E, SCIdS = 0
	Removing from ens E0A101: Radio Murski Val SID = 0xE4942A, SCIdS = 0
	Removing from ens E0A101: Koroski Radio SID = 0xE49452, SCIdS = 0
	Removing from ens E0A101: Stajerski Val SID = 0xE4943F, SCIdS = 0
	Removing from ens E0A101: Radio Aktual Kum SID = 0xE49443, SCIdS = 0
	Removing from ens E0A101: Radio Velenje SID = 0xE49448, SCIdS = 0

as these services are all on Slovenian
Ensemble:
0x9300 SLO DAB+ R2 E [ SLO R2 E ] ECC = 0xE4, UTC 60 min, INT = 1, alarm announcements = 0

and not on Austrian Bundesmux
Ensemble:
0xA101 DAB+ Austria [ DAB+ A ] ECC = 0xE0, UTC 60 min, INT = 1, alarm announcements = 0

I could not reproduce so far.

What device do you use?

RTL Stick.

Connected directly or over TCP-IP?

Direct

Hmm, interesting, I cannot reproduce this behavior. Could you please share more details?
I have understood that you switch 2 services each from different ensemble and during switching you see these messages. Is any of that 2 services in both ensembles? Is service list broken or the problem after switch?
Maybe sharing video would help again.

A video won't help you. I just saw this message in the console. The list of services was looking good.
I know that it has to do with weak signals, but I wonder why AbracaDABra mixed up the ensembles...

Yes, mixing of the IQ data was my idea too, that is why I have asked about device. It should not happen when RTLSDR is used directly because I always stop the stream and then I start it again to avoid mixing of data. This is unfortunately making tune slower but I have not found better way to avoid mixing of the stream. On the other hand it should be safe unless the underlying layer is leaving old data in buffers and sending them on new start. I will try to reproduce the issue on Linux, on Mac it does not happen. I was trying to switch 2 services from 2 different ensembles many times and it did not happen. I assume you compiled the latest version from repository on Linux, you are not using AppImage, correct?

I am always referring to the latest commit, which I am compiling myself.

This is what I have in terminal output under Ubuntu 22.04 when switching between Classic Praha and Expres FM. Both are in both ensembles, I ma switching between Classic @ 7C and Express @ 7A. There is obviously no problem.
Allocating 15 zero-copy buffers
	Service: DAB Test HQ SID = 0xE22F75, SCIdS = 0
	Service: Classic Praha SID = 0xE2244A, SCIdS = 0
	Service: DAB Test LQ SID = 0xE22F77, SCIdS = 0
	Service: 'Rádio SÁZAVA SID = 0xE22FBA, SCIdS = 0
	Service: Schwarzwaldradio SID = 0xE0100D, SCIdS = 0
	Service: Schlager Radio SID = 0xE01735, SCIdS = 0
	Service: Kiss SID = 0xE22FA0, SCIdS = 0
	Service: Country Radio SID = 0xE22F37, SCIdS = 0
	Service: COLOR MusicRadio SID = 0xE22442, SCIdS = 0
	Service: Spin Radio SID = 0xE22F43, SCIdS = 0
	Service: HEY Radio SID = 0xE224F8, SCIdS = 0
	Service: Expres FM SID = 0xE2203B, SCIdS = 0
AAC-LC 48 kHz stereo
Output SR = 48000, channels = 2
Allocating 15 zero-copy buffers
	Service: RADIO BONTON SID = 0xE22430, SCIdS = 0
	Service: Radio BEAT SID = 0xE22F31, SCIdS = 0
	Service: BLANIK DAB SID = 0xE22F3C, SCIdS = 0
	Service: Expres FM SID = 0xE2203B, SCIdS = 0
	Service: HITRADIO CITY SID = 0xE22F32, SCIdS = 0
	Service: Classic Praha SID = 0xE2244A, SCIdS = 0
	Service: RadioZET SID = 0xE2210E, SCIdS = 0
	Service: PIGY RADIO SID = 0xE22FB7, SCIdS = 0
	Service: EVROPA 2 SID = 0xE22204, SCIdS = 0
	Service: FREKVENCE 1 SID = 0xE22205, SCIdS = 0
	Service: Cesky Impuls SID = 0xE22FB4, SCIdS = 0
	Service: Radio Dechovka SID = 0xE224B2, SCIdS = 0
	Service: ROCKZONE SID = 0xE22445, SCIdS = 0
	Service: Radio Impuls SID = 0xE22203, SCIdS = 0
HE-AAC v2 48 kHz stereo
Output SR = 48000, channels = 2
Allocating 15 zero-copy buffers
	Service: 'Rádio SÁZAVA SID = 0xE22FBA, SCIdS = 0
	Service: Schwarzwaldradio SID = 0xE0100D, SCIdS = 0
	Service: Schlager Radio SID = 0xE01735, SCIdS = 0
	Service: Kiss SID = 0xE22FA0, SCIdS = 0
	Service: Country Radio SID = 0xE22F37, SCIdS = 0
	Service: COLOR MusicRadio SID = 0xE22442, SCIdS = 0
	Service: Spin Radio SID = 0xE22F43, SCIdS = 0
	Service: HEY Radio SID = 0xE224F8, SCIdS = 0
	Service: Expres FM SID = 0xE2203B, SCIdS = 0
	Service: DAB Test HQ SID = 0xE22F75, SCIdS = 0
	Service: Classic Praha SID = 0xE2244A, SCIdS = 0
	Service: DAB Test LQ SID = 0xE22F77, SCIdS = 0
AAC-LC 48 kHz stereo
Output SR = 48000, channels = 2

I am using the version from Ubuntu.

Just had the same message with Airspy, so this is not related to the dongle.
RadioControlEvent::SERVICE_STOP error 2
	Service: PRVI SID = 0xE49201, SCIdS = 0
	Service: Radio 1 DAB SID = 0xE49442, SCIdS = 0
	Service: Ekspres Slo SID = 0xE49462, SCIdS = 0
	Service: Radio 1 80-a SID = 0xE49459, SCIdS = 0
	Service: Radio Salomon SID = 0xE49463, SCIdS = 0
	Service: Rock Radio Slo SID = 0xE49516, SCIdS = 0
	Service: Center Slo SID = 0xE49414, SCIdS = 0
	Service: Radio Ognjisce SID = 0xE4932F, SCIdS = 0
	Service: Radio Si SID = 0xE4933A, SCIdS = 0
	Service: VAL 202 SID = 0xE49202, SCIdS = 0
	Service: ARS SID = 0xE49203, SCIdS = 0
	Service: Radio Veseljak SID = 0xE49449, SCIdS = 0
	Service: Radio Aktual SID = 0xE4941C, SCIdS = 0
	Service: Radio City SID = 0xE49415, SCIdS = 0
	Service: Radio Student SID = 0xE49440, SCIdS = 0
	Service: Radio Net FM SID = 0xE4942B, SCIdS = 0
	Removing from ens E49200: 'WELLE 1 SID = 0xE0AD58, SCIdS = 0
	Removing from ens E49200: *STEPHANSDOM* SID = 0xE0AC52, SCIdS = 0
	Removing from ens E49200: Antenne Österrei SID = 0xE0AD57, SCIdS = 0
	Removing from ens E49200: KLASSIK RADIO SID = 0xE0AD53, SCIdS = 0
	Removing from ens E49200: Rock Antenne SID = 0xE0AD27, SCIdS = 0
	Removing from ens E49200: arabella HOT SID = 0xE0AD59, SCIdS = 0
	Removing from ens E49200: Radio Maria SID = 0xE0A3DD, SCIdS = 0
	Removing from ens E49200: jö.live SID = 0xE0AD56, SCIdS = 0
	Removing from ens E49200: ERF Süd SID = 0xE0AD24, SCIdS = 0
	Removing from ens E49200: -AUSTRIA SID = 0xE0A3E0, SCIdS = 0
	Removing from ens E49200: arabella RELAX SID = 0xE0AD54, SCIdS = 0
	Removing from ens E49200: #Technikum ONE SID = 0xE0AD2A, SCIdS = 0
	Removing from ens E49200: Mein Kinderradio SID = 0xE0AD55, SCIdS = 0
	Removing from ens E49200: ENERGY SID = 0xE0AC51, SCIdS = 0
	Removing from ens E49200: * 88.6 * SID = 0xE0AC47, SCIdS = 0
	Removing from ens E49200: Radio Flamingo SID = 0xE0AD5A, SCIdS = 0
	Service: PRVI SID = 0xE49201, SCIdS = 0
	Service: Radio 1 DAB SID = 0xE49442, SCIdS = 0
	Service: Ekspres Slo SID = 0xE49462, SCIdS = 0
	Service: Radio 1 80-a SID = 0xE49459, SCIdS = 0
	Service: Radio Salomon SID = 0xE49463, SCIdS = 0
	Service: Rock Radio Slo SID = 0xE49516, SCIdS = 0
	Service: Center Slo SID = 0xE49414, SCIdS = 0
	Service: Radio Ognjisce SID = 0xE4932F, SCIdS = 0
	Service: Radio Si SID = 0xE4933A, SCIdS = 0
	Service: VAL 202 SID = 0xE49202, SCIdS = 0
	Service: ARS SID = 0xE49203, SCIdS = 0
	Service: Radio Veseljak SID = 0xE49449, SCIdS = 0
	Service: Radio Aktual SID = 0xE4941C, SCIdS = 0
	Service: Radio City SID = 0xE49415, SCIdS = 0
	Service: Radio Student SID = 0xE49440, SCIdS = 0
	Service: Radio Net FM SID = 0xE4942B, SCIdS = 0
	Removing from ens E49200: 'WELLE 1 SID = 0xE0AD58, SCIdS = 0
	Removing from ens E49200: *STEPHANSDOM* SID = 0xE0AC52, SCIdS = 0
	Removing from ens E49200: Antenne Österrei SID = 0xE0AD57, SCIdS = 0
	Removing from ens E49200: KLASSIK RADIO SID = 0xE0AD53, SCIdS = 0
	Removing from ens E49200: Rock Antenne SID = 0xE0AD27, SCIdS = 0
	Removing from ens E49200: arabella HOT SID = 0xE0AD59, SCIdS = 0
	Removing from ens E49200: Radio Maria SID = 0xE0A3DD, SCIdS = 0
	Removing from ens E49200: jö.live SID = 0xE0AD56, SCIdS = 0
	Removing from ens E49200: ERF Süd SID = 0xE0AD24, SCIdS = 0
	Removing from ens E49200: -AUSTRIA SID = 0xE0A3E0, SCIdS = 0
	Removing from ens E49200: arabella RELAX SID = 0xE0AD54, SCIdS = 0
	Removing from ens E49200: #Technikum ONE SID = 0xE0AD2A, SCIdS = 0
	Removing from ens E49200: Mein Kinderradio SID = 0xE0AD55, SCIdS = 0
	Removing from ens E49200: ENERGY SID = 0xE0AC51, SCIdS = 0
	Removing from ens E49200: * 88.6 * SID = 0xE0AC47, SCIdS = 0
	Removing from ens E49200: Radio Flamingo SID = 0xE0AD5A, SCIdS = 0

9200 is Slovenian DAB, not Austria ...
Could you add a debug message when tuning to a block (like tuning to block xxx) and service (playing Radio xxx).

This is an interesting screenshot. Found 2 ensembles (6A and 8A, both DAB+ Austria), but only shows one line this time.
Seems this may cause the above mentioned issue?

Normally, both blocks are listed here.

I have added the messages in e6598e5e77828878de4767c087887f1ed94aac11
Do you have any test case to reproduce the issue or it is more like random?

I fear it's more like random.

I'll close here, not checked in the past months.


Suggestion: Allow usage to be viewed in monetary amounts?

From Phillip:

we might also consider some form of crude monetary amount in the absence of the ability to change the y >axis (kWh,kWh/1000m2,kWh/100pupil,£,£/100pupil etc.) as previously discussed, for teaching purposes >assuming 12p/kWh for electricity, and 3p/kWh for gas – in the short-term hard-coded into the code would >be useful?

Will be addressed by Y axis adjustments. Close


AST without autocorrection

Tests say that it works.

Could you, please, provide some examples of autocorrection? Is it just . -> .. ```... -> ..`` or something more complicated?

@cryogenian

The build is failing due to gulp not being installed.
Can you squash all commits down?
Let me know when you're ready to merge.

Error correction cannot easily be done without building it into the parser combinators. I think that's more than we want to bite off for now. The question is: when something does NOT parse, what do we search for? For now, I think it's OK to change the background color to red, gray out the button, and prevent searching. Ultimately I'm not sure that's the best solution (what search engine prevents you from searching? None of them, they just interpret the search as best as possible).

Moved to mandragora-bucket
fixed travis
renamed Value
Don't know how to rename PredicateAndLabel
Added Printer
Added StrongCheck tests
Made pr to purescript-parsing
renamed somethingP to somethingPredicate
Added SearchAnd (it just splits input by whitespaces, though)
Don't know what runtime error can be caused by using length cs but switched to pattern matching
Most of functions are private now (parseSearchTerm is public because it's easier to test than parseSearchQuery)
SearchTermSimple always use [Label]


fix $transaction

Prettier automatically escapes $ to \$, so I think this will continue to be a problem. Any reason we go with <inlinecode>$transaction</inlinecode> and not backticks?
https://www.prisma.io/docs/guides/prisma-guides/prisma-client-transactions-guide#transaction-api

We need the inlinecode part in order to render the code style in navigation; am not sure of the details - I've added <!-- prettier-ignore --> to that section in my current branch to stop Prettier from 'fixing' it.


Added a material flag to disable material opacity fading out specular and added a value to specifically alpha fade out materials (including specular)

Fixes #2018
Implementation is based on #2019 - but with different naming and differing location of some code changes and support for clear coat specular included.
Screen grab from the material-translucent-specular engine example:

I confirm I have signed the Contributor License Agreement.

It looks good to me, even though I'd drop the s from opacityFadesSpecular.
Can you please create an issue on Editor repo to expose this in the Editor and link it here.
And please list new API changes in the description of PR.

Currently this PR does not change visual behaviour of existing projects - which is good.
As I understand newly created materials in Editor, now will have fading set to false, while old data without those flags will default to true. Correct?

@Maksims - I think the proposal will be that new materials have specular not fade with material opacity - the final decision will be made when the editor PR is reviewed - but it makes sense to me to do as you described above.

Hi @raytranuk,
Just checked out this PR and I have a few questions...
As far as I understand, the usual method of rendering glass-type specular is by enabling premultiplied blend mode and outputting roughly the following from the shader:
gl_FragColor = vec4(diffuse * alpha + specular, alpha);

The premultiplied blend mode is applied as follows:
final = gl_FragColor.rgb + final * (1.0 - gl_FragColor.a);

Which, expanded is roughly:
final = diffuse * alpha + specular + final * (1.0 - alpha);

This gives precisely what we're after: blended diffuse component with (unblended) specular.
My questions:

Reading the shader code I'm not clear how the above is accomplished? I might be wrong, but it looks like the shader calculates a rough approximation of the above based on diffuse and specular colour and works in both normal blend mode and premultiplied-alpha mode (though neither are correct?). Seems to me the approximation may behave unexpectedly under certain scenarios, like very differently coloured diffuse and specular components. Why approximate the blending result when it should be straightforward (and faster!) to do it correctly?

Why introduce a new alphaFade value? How is it different from the material's existing specular colour tint? While I understand its purpose in spirit, it also seems quite confusing.


PCF LOGIN ISSUE

When I am trying to login to cf cli, I am getting the below error:
Error performing request: Get https://api.run.pivotal.io/v2/info: read tcp <IP_ADDRESS>:56349-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host.
Can somebody assist immediately

The address api.run.pivotal.io is PWS, not PCF Dev.
Are you using the latest alpha release, or v0.30.0?

I am working on PWS only not PCF dev, and the cf cli i have installed is latest version also but still I am getting this error. Can you please help

This issue tracker is for issues related to PCF Dev, not PWS or the cf CLI.
PWS support: https://support.pivotal.io/
Issue tracker for the cf CLI: https://github.com/cloudfoundry/cli/issues
Judging by the error though, it looks like you require an HTTP proxy to make external connections and haven't set the http_proxy, https_proxy, and/or no_proxy environment variables.

One question Stephen, I am not using any proxy server in my proxy settings so if I set the above variables, will it work?


⚠ Samsung has degraded performance

In 8451cdf, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2319 ms

Resolved: Samsung performance has improved in b86735b.


Baseplate.spec calls for <protocol>_client_name instead of <protocol>_slug

💸 TL;DR
The Baseplate.spec calls for the client pools to have a label in the form <protocol>_client_name but baseplate.go uses <protocol>_slug. This PR addresses this discrepancy.
🧪 Testing Steps / Validation
Updated unit tests
✅ Checks

[ ] CI tests (if present) are passing
[ ] Adheres to code style for repo
[ ] Contributor License Agreement (CLA) completed if not a Reddit employee

I don't have permission to merge in this repo. Can one of you do that for me please ?


Component synchronization problems persist

The Key Management dialog is not getting updated when the environments change. See below the Tray knows that there are no environments while the KM component thinks there still is one.

Note no matter how many times I open and close the KM dialog it does not correct itself. Why not have the KM read the environment objects from the tray every time you open it up?


Wrong Element genetarion

I'm trying to generate a struct for the bellow element but the result wasn't the expected.
Element
<xs:element name="infNFe" maxOccurs="unbounded">
<!-- Other elements-->
<xs:element name="PIN" minOccurs="0">
	<xs:annotation>
		<xs:documentation>PIN SUFRAMA</xs:documentation>
		<xs:documentation>PIN atribuído pela SUFRAMA para a operação.</xs:documentation>
	</xs:annotation>
	<xs:simpleType>
		<xs:restriction base="xs:string">
			<xs:whiteSpace value="preserve"/>
			<xs:minLength value="2"/>
			<xs:maxLength value="9"/>
			<xs:pattern value="[1-9]{1}[0-9]{1,8}"/>
		</xs:restriction>
	</xs:simpleType>
</xs:element>
</xs:element>

Generated code :
// InfNFe ...
type InfNFe struct {
	XMLName	xml.Name	`xml:"infNFe"`
	Chave	string	`xml:"chave"`
	PIN	*PIN	`xml:"PIN"`
	DPrev	string	`xml:"dPrev"`
	InfUnidCarga	[]*TUnidCarga	`xml:"infUnidCarga"`
	InfUnidTransp	[]*TUnidadeTransp	`xml:"infUnidTransp"`
}

Expected result:
// InfNFe ...
type InfNFe struct {
	XMLName	xml.Name	`xml:"infNFe"`
	Chave	string	`xml:"chave"`
	PIN	*string	`xml:"PIN"`
	DPrev	string	`xml:"dPrev"`
	InfUnidCarga	[]*TUnidCarga	`xml:"infUnidCarga"`
	InfUnidTransp	[]*TUnidadeTransp	`xml:"infUnidTransp"`
}

Output of go version:
go version go1.14.2 windows/amd64

Environment details (OS, physical, etc.):
windows 10 64bits

Thanks for your issue. Could you provide more info about XSD? Maybe I need more context to find the reason.

The xsd is here.
I found other problem that all, or almost all, type that is created is a pointer in the struct. So it's very difficult to manage the struct where you have a lot of pointers or pointers of pointers. But it probably could be an other issue to duscuss.

Hi @luizvnasc, I have fixed it, please try to upgrade the command line tools with the master branch code.

Hi @xuri, thanks, but as you can see in #4 the bug is still happening.
What I did:
$ go get -u github.com/xuri/xgen
go: github.com/xuri/xgen upgrade => v0.0.0-20200517172312-9d8630233132
go: finding module for package golang.org/x/net/html/charset
go: found golang.org/x/net/html/charset in golang.org/x/net v0.0.0-20200513185701-a91f0712d120
go: golang.org/x/text upgrade => v0.3.2
$ xgen -l Go -p evento -o ./v1.00/evento/ -i ./schemas/Evento_AlertaFisco_v1.01/e400101_v1.00.xsd
done


Where can I find out about /api/v2/txs/signed information?

i am working for a  light wallet , now i want sent transaction to cardano node . i not find anything about how to  send transaction.  i read  https://github.com/vacuumlabs/adalite/blob/master/server/transactionSubmitter.js  find a code like this:
const response = await fetch(
        `${process.env.ADALITE_BLOCKCHAIN_EXPLORER_URL}/api/v2/txs/signed`,
        {
          method: 'POST',
          body: JSON.stringify(signedBody),
          headers: {
            'Content-Type': 'application/json; charset=utf-8',
          },
        }
      )

Someone knows what is ${process.env.ADALITE_BLOCKCHAIN_EXPLORER_URL}/api/v2/txs/signed means?
is it a cardano node url?  i have install a  cardano node  with explorer api.   looking for https://cardanodocs.com/technical/explorer/api/  not find /api/v2/txs/signed.
Where can I find out about api/v2/txs/signed information?

I found this, hope it can help you.
https://github.com/vacuumlabs/adalite-backend-service/blob/develop/src/routes.js#L234


V5 add min-width

Before opening:

Search for duplicate or closed issues
Validate any HTML to avoid common problems
Read the contributing guidelines

Bug reports must include:

Operating system and version (Windows, macOS, Android, iOS)
Browser and version (Chrome, Firefox, Safari, Microsoft Edge, Opera, Android Browser)
A reduced test case or suggested fix using CodePen or JS Bin

Please at least read our issue template and give some insights.

@ffoodd Yes, sorry, I accidentally added it mid-edit. So thanks for removing it.


Wr/oss cli

What does this PR do?
Open Sources the sfdx-cli repository
What issues does this PR fix or reference?
@W-8222430@

@WillieRuemmele - you don't want to source control ./dist right?

@WillieRuemmele - you don't want to source control ./dist right?

@WillieRuemmele - you don't want to source control ./dist right?

@shetzel I don't believe it is... I don't think it should be

@WillieRuemmele - you don't want to source control ./dist right?

@shetzel I don't believe it is... I don't think it should be


Incorrect resize result for an image

Environment
ipx - 2.0.2
nodejs - v18.16.1
Reproduction
Clone repo: https://github.com/dmitriy-nz/ipx-test
Install deps
Run npx ipx serve --dir ./imgs
Open url: http://localhost:3000/s_200x200,fit_inside/test.jpg - Already at this step you will get an image with an incorrect size
On the native sharp everything works as expected with the same set of parameters
Run node index.js for get the expected result via a native sharp
Check output.jpg
Describe the bug
When I try to resize a "skinny" image I get the wrong result.
Original image (30x600):

Call resize via ipx with parameters s_200x200,fit_inside and get wrong result (1x30):

I ran the resize with the same parameters through native sharp and everything works as expected (10x200):

Additional context
No response
Logs
No response

Tracked the issue to this clampDimensionsPreservingAspectRatio fn call. Sharp seems to handle this correctly now, as works as expected when those lines are commented out. I'd question wether this manual patching still needed.


Error experienced

Does this occur consistently?
Repro steps:

Action: appService.Deploy
Error type: Error
Error Message: Failed to get status of deployment.
Version: 0.24.9
OS: darwin
OS Release: 23.2.0
Product: Visual Studio Code
Product Version: 1.77.0
Language: en

Call Stack
extension.bundle.js:2:2436391
rejected extension.bundle.js:2:2434001

Please provide repro steps, thank you

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


MINOR: Fix SubscriptionInfoData name in exception message

More detailed description of your change
A small fix because of SubscriptionInfo.json has been renamed to SubscriptionInfoData.json
Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true]
It's a new flaky test yet it seems not related to this PR.


REST API: Add option to unpack uploaded zipfile on resource creation

Calls to POST /hsapi/resource/ should be able to specify that the uploaded resource file is a zipfile archive that should be unpacked as part of the resource creation process

Once #924 is merged, we will need to add support to the REST API for: (1) specifying unzipping on resource creation; and (2) checking the status of unzipping.

@alvacouch please consider the best solution to this functionality in API work

@sblack close if done.  Act on if not.

Workflows with hsclient and czhub create a resource without uploading files.  Files are uploaded and unzipped after creation.  This functionality is no longer needed.


Using latest stable Hugo version 0.123 seems to break build

When I run npm run dev, which calls hugo server under the hood, everything works locally. That is, as long as I have Hugo v0.118.2 installed (as is specified in the Github actions build).
I do get a warning saying
WARN  .File.Dir on zero object. Wrap it in if or with: {{ with .File }}{{ .Dir }}{{ end }}

but otherwise it builds.
Yesterday, a new stable version of Hugo was released, and my Snap package automatically updated to v0.123.2. When I try to build the website, I get the following error:
><EMAIL_ADDRESS>dev
> hugo serve --buildFuture

Watching for changes in /home/gregorlenz/Development/open-neuromorphic.github.io/{assets,content,data,hugo_stats.json,i18n,package.json,postcss.config.js,static,tailwind.config.js,themes}
Watching for config changes in /home/gregorlenz/Development/open-neuromorphic.github.io/hugo.toml, /home/gregorlenz/Development/open-neuromorphic.github.io/config/_default, /home/gregorlenz/Development/open-neuromorphic.github.io/go.mod
Start building sites …
hugo v0.123.2-929b91fe75cb0d041f22b4707700dfc117115ad4+extended linux/amd64 BuildDate=2024-02-22T15:27:15Z VendorInfo=snap:0.123.2

Built in 3655 ms
Error: error building site: render: failed to render pages: render of "404" failed: "/home/gregorlenz/Development/open-neuromorphic.github.io/themes/hugoplate/layouts/_default/baseof.html:9:7": execute of template failed: template: 404.html:9:7: executing "404.html" – File is nil; wrap it in if or with: {{ with partial "essentials/head.html" .>: error calling partial: "/home/gregorlenz/Development/open-neuromorphic.github.io/themes/hugoplate/layouts/partials/essentials/head.html:6:30": execute of template failed: template: partials/essentials/head.html:6:30: executing "partials/essentials/head.html" at <.File }}{{ .Dir }}{{ end }}

It seems to me that the warning generated with v0.118 now causes the build to break with v0.123. It would be great if the build worked with the latest stable Hugo version, which is v0.123. @neural-loop do you think you could take a look at this please?

I will look into this when I have a chance. As I changed this around, I had some other errors and it may be related to https://github.com/gohugoio/hugo/issues/11455 other breaking changes in the version differences. I don't see the issues in the other hugo site I work on so it should be some things that can be tracked down.

I think this is resolved now


JSON strings cannot generate with "" character in them

Describe the issue as clearly as possible:
I have fine tuned a model to generate json. I am using outlines with vLLM to force the model to generate correct json schema. Outlines is failing to generate:
{
  "cost": null,
  "description": "Net Equity Attributable to Holders of Redeemable Units (\"Net Equity\")",
  "footnotes": [],
  "percent_net_assets": 100.0,
  "value":<PHONE_NUMBER>
}

Specifically, it is failing to generate the "(\"Net Equity\")" in the description field.
The issue seems to be with this line
https://github.com/outlines-dev/outlines/blob/7723ce8d091230249db8840463c5cdefdb408b8e/outlines/fsm/json_schema.py#L13
It is prohibiting any \ character inside of the string.
"Net Equity Attributable to Holders of Redeemable Units (\"Net Equity\")" is a valid json string. I have tested parsing the json above using python json.loads. It should be able to generate using outlines.
Steps/code to reproduce the bug:
My schema:

class StatementInvestmentsTotal(BaseModel):
    cost: Optional[float]
    description: Optional[str]
    footnotes: list[str]
    percent_net_assets: Optional[float]
    value: Optional[float]

Expected result:
Outlines should allow generating backslashes in json strings

Error message:
No response
Outlines/Python version information:
Version information

```
(command output here)
```

Context for the issue:
No response

Please provide package version info.
See this thread as well
https://github.com/pytorch/pytorch/issues/21819#issuecomment-2029036618

@posionus any interest in creating a PR for this fix? I have a bit on my backlog.
>>> interegular.parse_pattern(json_schema.STRING).to_fsm().accepts(r'"my escaped string: \" okay"')
False

>>> STRING_INNER = r'(?:[^"\\]|\\.)*?'
>>> ESCAPED_STRING = r'"' + STRING_INNER + r'"'
>>> interegular.parse_pattern(ESCAPED_STRING).to_fsm().accepts(r'"my escaped string:  \" okay"')
True


Update Product Scope in DG

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (3878152) compared to base (be2f5b2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add startup logger to log startup code failure

Add proper error logging when the extension startup code crashes (during app startup/bootstrapping).

If you're using the prefix defined here, you should be able to see those messages handled by the host.


ipm: imx: send firmware ready reply

After the MU is initialized send a fw ready reply
message. This is, usually, used on host side, which is waiting for this message in order to establish the communication with the remote processor - see
imx_dsp_rproc driver from Linux.
This can be enabled by IPM_IMX_FW_READY_REPLY config, which is by default N.
Set CONFIG_IPM_IMX_FW_READY_REPLY as Y for
openamp_rsc_table sample, running on nxp_adsp_imx8m.

While this PR is not problematic per se my impression is that we are kinda cheating here. Wouldn't much better just to introduce a new REMOTEPROC API class / subsystem in Zephyr and use that instead?

This is not a standard - to send a fw ready reply after the remote core is up. This is just for imx use-case.
Other remoteproc Linux drivers (i.e. omap_remoteproc) are sending an echo request and this message will wait in the mailbox fifo until the remote core is up.
Others are doing nothing.
Therefore, there is no "one way fits all" for host-remote handshake communication.
In remoteproc there's no confirmation for remote core booted.

This is not a standard - to send a fw ready reply after the remote core is up. This is just for imx use-case.
Others remoteproc Linux drivers (e.g. omap_remoteproc) are sending an echo request and this message will wait in the mailbox fifo until the remote core is up.
Others are doing nothing.
Therefore, there is no "one way fits all" for host-remote handshake communication. In remoteproc there's no confirmation for remote core booted.

What about the notify hook here https://github.com/OpenAMP/open-amp/blob/5891cb4b2e813d1c9d10def998952b062304e43f/lib/include/openamp/remoteproc.h#L413 ?
I'm not going to NACK this PR, this is fine to me. I'm just trying to understand if there is a generic way to do this.

Agree with @carlocaione,
The handshake should be performed at the application level. It probably relies on a mailbox, but
Today, similar mechanism is done in Linux but from the main to the remote processor. When the virtio device status has been updated.  A kick (notify) is sent by Linux rpmsg virtio driver to the coprocessor. The Linux remoteproc is in charge of sending this kick through the mailbox.  Associated code is available here: https://elixir.bootlin.com/linux/latest/source/drivers/rpmsg/virtio_rpmsg_bus.c#L995
In this PR the inverse is requested.
So your Linux kernel driver should probably have to block on start waiting  a mailbox kick from the coprocessor before initializing the rpmsg.
The coprocessor application (https://elixir.bootlin.com/zephyr/latest/C/ident/rpmsg_mng_task) would be in charge of sending a notification when it is ready to communicate. And then wait the resource table virtio device status update.
Using a config is nice for compatibility with other hardware

Agree with @carlocaione,
The handshake should be performed at the application level. It probably relies on a mailbox, but
Today, similar mechanism is done in Linux but from the main to the remote processor. When the virtio device status has been updated. A kick (notify) is sent by Linux rpmsg virtio driver to the coprocessor. The Linux remoteproc is in charge of sending this kick through the mailbox. Associated code is available here: https://elixir.bootlin.com/linux/latest/source/drivers/rpmsg/virtio_rpmsg_bus.c#L995

The i.MX DSP remoteproc  (imx_dsp_rproc) driver is implementing the generic kick callback - https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c and is called after starting the remote core - see https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L316.
But, this will return error, because the FW_READY flag was not set (https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L291).
This is set on rxdb callback (https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L496) which uses general purpose interrupts.

In this PR the inverse is requested. So your Linux kernel driver should probably have to block on start waiting a mailbox kick from the coprocessor before initializing the rpmsg.

It does, as mentioned above (https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L344)

The coprocessor application (https://elixir.bootlin.com/zephyr/latest/C/ident/rpmsg_mng_task) would be in charge of sending a notification when it is ready to communicate. And then wait the resource table virtio device status update.

So, @arnopo you're saying I should update the openamp_rsc_table sample?
This already sends a notify (using ipm_send), but is using TX interrupts, while in Linux, I'm waiting for GP interrupts.
So I cannot use the IPM API.
Now, in ipm_imx, I'm calling directly from NXP_HAL the MU_TriggerInterrupts() used for GP interrupts.

Using a config is nice for compatibility with other hardwares

Agree with @carlocaione,
The handshake should be performed at the application level. It probably relies on a mailbox, but
Today, similar mechanism is done in Linux but from the main to the remote processor. When the virtio device status has been updated. A kick (notify) is sent by Linux rpmsg virtio driver to the coprocessor. The Linux remoteproc is in charge of sending this kick through the mailbox. Associated code is available here: https://elixir.bootlin.com/linux/latest/source/drivers/rpmsg/virtio_rpmsg_bus.c#L995

The i.MX DSP remoteproc (imx_dsp_rproc) driver is implementing the generic kick callback - https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c and is called after starting the remote core - see https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L316. But, this will return error, because the FW_READY flag was not set (https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L291). This is set on rxdb callback (https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L496) which uses general purpose interrupts.

In this PR the inverse is requested. So your Linux kernel driver should probably have to block on start waiting a mailbox kick from the coprocessor before initializing the rpmsg.

It does, as mentioned above (https://elixir.bootlin.com/linux/latest/source/drivers/remoteproc/imx_dsp_rproc.c#L344)

The coprocessor application (https://elixir.bootlin.com/zephyr/latest/C/ident/rpmsg_mng_task) would be in charge of sending a notification when it is ready to communicate. And then wait the resource table virtio device status update.

So, @arnopo you're saying I should update the openamp_rsc_table sample? This already sends a notify (using ipm_send), but is using TX interrupts, while in Linux, I'm waiting for GP interrupts. So I cannot use the IPM API.

I thought a little bit more and I can expand the IPM API with an ipm_notify().
Give me a couple of days and I'll send a new version to this.
Thanks!
PS: If I won't be able to send it by Friday, I'll do it next week since I'll be OOO :)

I thought a little bit more and I can expand the IPM API with an ipm_notify().

Why? Please don't.
A notify hook has nothing to do with the IPM device class. The IPM API is supposed to support an Inter-Processor communication hardware, a notify hook is something related to your transport protocol, not the hardware.

I thought a little bit more and I can expand the IPM API with an ipm_notify().

Why? Please don't.
A notify hook has nothing to do with the IPM device class. The IPM API is supposed to support an Inter-Processor communication hardware, a notify hook is something related to your transport protocol, not the hardware.

But then how can I send (actually just set the interrupts I need) the fw reply? This is platform specific?
I add the ipm_notify and this will be implemented where needed - like, for now, only in ipm_imx.
As mention, I cannot use the ipm_send since is using TX interrupts, rather than GP interrupts that are expected in Linux.

But then how can I send (actually just set the interrupts I need) the fw reply? This is platform specific. I add the ipm_notify and this will be implemented where needed - like, for now, only in ipm_imx.

You realize that we cannot arbitrary extend every API device class because some random platform needs something on top right? This being platform specific is exactly the reason this hook makes no sense in the general API class.
You extend an API when the new API is going to support a wide variety of hardware and platforms and, to me, it looks like this is not the case.
The IPM class is about hardware, how do you use this hardware is not the driver concern really. You want something on top of that, an application, a subsystem, a framework, etc... that is using that driver to do something with it (notify, build packets, etc...).

I thought a little bit more and I can expand the IPM API with an ipm_notify().

Why? Please don't.
A notify hook has nothing to do with the IPM device class. The IPM API is supposed to support an Inter-Processor communication hardware, a notify hook is something related to your transport protocol, not the hardware.

But then how can I send (actually just set the interrupts I need) the fw reply? This is platform specific. I add the ipm_notify and this will be implemented where needed - like, for now, only in ipm_imx.
As mention, I cannot use the ipm_send since is using TX interrupts, rather than GP interrupts that are expected in Linux.

What about considering the GP interrupt as a specific channel of the ipm_imx (or a new instance of the ipm)?
you could implement specific action in your ipm_imx based on the channel ID.
Then in application you could define a config that is set to the channel ID value.
if the CONFIG is set the application calls ipm_send(ipm_handle, 0, CONFIG_OPENAMP_RSC_TABLE_KICK_ID, NULL, 0); that trigs the GP interrupt.

I am still not convinced that the solution is reliable in the long term (for instance, for a Zephyr project that does not use ipm driver). However, the patch should be able to respond in the short term.

I'm OK with this for now, as it seems there is no general agreement with Linux folks.
On the long run I think we can make use of struct resource_table https://github.com/OpenAMP/open-amp/blob/e63d07d10577b06c5b3fc8e1c20ede74779d3132/lib/include/openamp/remoteproc.h#L4
We could define a new fw_resource_type for example RSC_PLATFORM.
All application will need to fill this struct with information about expected behavior. Like, kernel should wait for firmware to boot (or not).
It looks like the Linux kernel infrastructure is already in place. What we need to figure out is how to define such structure with open-amp and zephyr.

I am still not convinced that the solution is reliable in the long term (for instance, for a Zephyr project that does not use ipm driver). However, the patch should be able to respond in the short term.

I'm OK with this for now, as it seems there is no general agreement with Linux folks.
On the long run I think we can make use of struct resource_table https://github.com/OpenAMP/open-amp/blob/e63d07d10577b06c5b3fc8e1c20ede74779d3132/lib/include/openamp/remoteproc.h#L4
We could define a new fw_resource_type for example RSC_PLATFORM.
All application will need to fill this struct with information about expected behavior. Like, kernel should wait for firmware to boot (or not).
It looks like the Linux kernel infrastructure is already in place. What we need to figure out is how to define such structure with open-amp and zephyr.

Yes that a way to do it.  I don't know if that would cover all use cases (XIP, start by U-boot or secure context, Zephyr <->Zephyr IPC, ...).  This would also imply that the resource table is defined for all zephyr samples. But also, that we respect cache line to make the resource table R/W for both processors during the initialization phase.
For your information we started a work in openAMP community to integrate virtio drivers/devices for IPC and the virtio-mmio transport in place of the virtio remoteproc (so no resource table). We identify similar handshake need to ensure that the coprocessor is running before probing the Linux  virtio-mmio driver.
That's why synchronization using signaling seems to me more generic. But perhaps we will need different solutions to address all hardwares and use cases.

I am still not convinced that the solution is reliable in the long term (for instance, for a Zephyr project that does not use ipm driver). However, the patch should be able to respond in the short term.

I'm OK with this for now, as it seems there is no general agreement with Linux folks.
On the long run I think we can make use of struct resource_table https://github.com/OpenAMP/open-amp/blob/e63d07d10577b06c5b3fc8e1c20ede74779d3132/lib/include/openamp/remoteproc.h#L4
We could define a new fw_resource_type for example RSC_PLATFORM.
All application will need to fill this struct with information about expected behavior. Like, kernel should wait for firmware to boot (or not).

The resource table, both in Linux and Zephyr, uses fw_rsc_vdev struct (meaning RSC_VDEV).
I cannot just add a new one and use that instead or both - this imply a serious refactorization - in Linux and openAMP.
Maybe, you mean to extend the fw_rsc_vdev struct.
Probably, a solution will be to use the config space from fw_rsc_vdev struct,
But this is nowhere  (Linux, Zephyr, OpenAMP) used - the config_len is declared 0 and that's all.

It looks like the Linux kernel infrastructure is already in place. What we need to figure out is how to define such structure with open-amp and zephyr.

Where is this? Can you please give me some links?
There is nothing in place, otherwise I would have used it.

@nashif, We appear to have a false-positive on the compliance. What should we do here?
https://github.com/zephyrproject-rtos/zephyr/pull/61709/files#diff-7a9de38974d6ca2f0d251849b385035241af755de445ddee41ab93fb33cd5d25R332

I've added a new version where I've fixed the (false positive) compliance check -https://github.com/zephyrproject-rtos/zephyr/pull/61709/files#diff-7a9de38974d6ca2f0d251849b385035241af755de445ddee41ab93fb33cd5d25R332
cc: @carlocaione @arnopo @nashif @dleach02

@arnopo could you please take another look?


Buttons appear multiple times on Wordpress.com

Dear all,
Can someone reproduce the issue that the Toggl Buttons are shown multiple times?

Thankfully,
~Robert

This should not happen as we check that there is not button present before we add a start timer button. I cannot reproduce this. Could you give more details so I can investigate.

Dear Indrek,
Thank you for your response.
I don’t know, however, which additional information to provide you with.
It concerns the posts as well as pages editor of a Blog hosted on
Wordpress.com.
Moreover, I am using the latest version of Toggl Button as well as
Chromium.
Does this help?
Thankfully,
~Robert
On Monday, March 28, 2016, Indrek V<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
This should not happen as we check that there is not button present before

we add a start timer button. I cannot reproduce this. Could you give more
details so I can investigate.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/toggl/toggl-button/issues/501#issuecomment-202374538

It seemed to happen when scrolling the page.

Thanks for rolling out that quick fix!
Warmly,
~Robert
On Tuesday, March 29, 2016, Indrek V<EMAIL_ADDRESS>wrote:

It seemed to happen when scrolling the page.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/toggl/toggl-button/issues/501#issuecomment-202878369


Leading edge rework + set bounds when activity is created

Issues:
https://nventive.visualstudio.com/Umbrella/_workitems/edit/131998
https://nventive.visualstudio.com/Umbrella/_workitems/edit/132014
https://nventive.visualstudio.com/Umbrella/_workitems/edit/134103
PR Type
What kind of change does this PR introduce?

Bugfix

What is the current behavior?

Bounds are set too late on Android
In a ListView, if the header is larger than the screen size, the ContentOffset initialization is set to the beginning of the content instead of the end of the header

What is the new behavior?

Bounds are set when the ApplicationActivity is created
the ContentOffset initialization is set to the end of the header

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Contains NO breaking changes

Other information

This should be two separate PRs.


Add as_object() and as_array() methods

This adds JsonValue::as_object() and JsonValue::as_array() methods.
This provides parity with the as_u32, as_str, etc. methods. It
simplifies code that deals with objects and arrays directly,
rather than using serde for a schematized view.
Also added JsonValue::get() and JsonValue::get_mut(), which forward
their calls to Object.

Been almost a year and these methods would be seriously useful.

Since this project is unmaintained, I forked to https://github.com/rustadopt/jzon-rs where I for example merged this PR and maintain it from now on with the community. It's also available in v0.12.5 on https://crates.io/crates/jzon


Shorten and Gist buttons currently do nothing

Since the most recent update (earlier today), these buttons are non-functional.

Perhaps the button can be allowed to exist but be hidden? as opposed to inexistent (I don't know yet if this is possible, my knowledge is limited, but I could probably look it up)


[SPARK-46140][SQL][TESTS] Remove no longer needed JVM module options from  HiveExternalCatalogVersionsSuite

What changes were proposed in this pull request?
This pr remove the no longer needed JVM module options from HiveExternalCatalogVersionsSuite due to the minimum version for the current test is Spark 3.3 (Spark 3.2 has already reached EOL).
Why are the changes needed?
Complete the TODO left by SPARK-37159.
Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass GitHub Actions

Was this patch authored or co-authored using generative AI tooling?
No

wait me check HiveExternalCatalogVersionsSuite with Java 21

@dongjoon-hyun Agree with your point, have updated the code,  will update the pr title and description later.

Thanks @HyukjinKwon @dongjoon-hyun


fix: clear the blueprint config caches when the blueprint is updated

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

What is the current behavior? (You can also link to an open issue here)

When a new blueprint is uploaded, the config cache is not cleared. This means that the blueprint can be given a stale cache that does not match the typings it expects.

What is the new behavior (if this is a feature change)?

Whenever the blueprint is modified, the relevant caches are cleared too.
Additionally some other lifecycle bits are handled, such as clearing caches for removed documents, and handling some less likely property changes

Other information:

Status

[ ] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Codecov Report

Merging #346 into master will decrease coverage by 0.01%.
The diff coverage is 77.21%.

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   67.70%   67.69%   -0.02%
==========================================
  Files         191      191
  Lines       12839    12865      +26
  Branches     2999     2853     -146
==========================================
+ Hits         8693     8709      +16
- Misses       4076     4087      +11
+ Partials       70       69       -1

Impacted Files
Coverage Δ

meteor/server/api/blueprints/config.ts
82.51% <75.34%> (-7.63%)
:arrow_down:

meteor/server/api/blueprints/context/context.ts
79.85% <100.00%> (-1.27%)
:arrow_down:

meteor/server/DatabaseCaches.ts
91.37% <0.00%> (ø)

meteor/server/api/systemTime/systemTime.ts
81.81% <0.00%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba0e2e...e2c7349. Read the comment docs.


Fix the number of output channels for super-resolution models and disable output format options

This fixes the number of output channels for super-resolution models and disables UI for output format options when super-resolution model is used. Output format options switch back on when another model type is changed in the UI.
Fix for https://github.com/PUTvision/qgis-plugin-deepness/issues/120#issue-2014233021

Thanks for contributing! Merging it.


position of dark/light mode fixed

adjusted positioning of dark/light mode so its not hidden behind the pictures.

@mohdfawad99 could you review this?