fix(bigquery): fix exception when bigquery import fails

this code was introduced with https://github.com/apache/superset/pull/23461. but in the tests, its not checked what happens if the google packages are not installed. i tried running Superset 3.0.1 without the bigquery packages installed. it failed to start, because it actually throws another exception.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

are there tests without bigquery packages installed, which could validate this?

maybe @betodealmeida can have a look as original author of the code introduction in https://github.com/apache/superset/pull/23461

the error message i got was misleading, and actually cause by a dependency which we install on top of superset. this dependency had some google package included, and seems to cause problems. i think its not a problem with superset itself. this can be closed, sry for the noise


I am getting using on while installing of shopify cli php to osiset package

Class name must be a valid object or a string
at C:\Users\Admin\Desktop\ShopifyAPP\seventh_app\vendor\osiset\laravel-shopify\src\ShopifyAppProvider.php:294
290▕      /
291▕     private function bootObservers(): void
292▕     {
293▕         $model = Util::getShopifyConfig('user_model');
➜ 294▕         $model::observe($this->app->make(ShopObserver::class));
295▕     }
296▕
297▕     /*
298▕      * Boot the middlewares for the package.
1   C:\Users\Admin\Desktop\ShopifyAPP\seventh_app\vendor\osiset\laravel-shopify\src\ShopifyAppProvider.php:64
Osiset\ShopifyApp\ShopifyAppProvider::bootObservers()
2   C:\Users\Admin\Desktop\ShopifyAPP\seventh_app\vendor\laravel\framework\src\Illuminate\Container\BoundMethod.php:36
Osiset\ShopifyApp\ShopifyAppProvider::boot()
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

Package Version: latest
Laravel Version: latest
PHP Version: latest

@vijaypareek13 what actual version numbers are you using for package, laravel and PHP?

I am also affected by this error.
I used the shopify-cli tool 3.5.0 to install a php template which than installs laravel.
PHP and Node both run in the same Docker container.
Laravel Framework: 8.83.23
PHP: 8.1
Package: 17.1.1
Do you have any advice on how to resolve this?

@hktudock @vijaypareek13
What is the cli command you are trying to run?

composer require osiset/laravel-shopify

It's hard to diagnose without some more information at the moment.
What php template did the cli use? Did you follow these install steps? https://github.com/osiset/laravel-shopify/wiki/Installation

I didn't realize that the user model configuration is commented out if you use shopify-cli >v3 to bootstrap a shopify app.
Commented in and error is gone.

@hktudock - glad you got it working!


Disparity between ops/3-concourse-release.yml and ops/9-concourse-compiled-release.yml

Why are there two operator files for concourse releases (one from bosh.io and one that's pre-compiled) and with different version numbers (3.9.2 vs 3.8.0)? Is there a CI job that's supposed to be creating the pre-compiled release but its failing?

Thanks; working now


Word wrap on username at username availability page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When a long username is used the username will continue out of visibility rather than wrap.

Expected Behavior
Username to wrap to next line.
Steps To Reproduce
Type a long username.
What platform(s) does this occur on?
Web
Which wallet(s) does this occur on?
Metamask
What browser(s) does this occur on?
Chrome
Operating System(s)
Windows
Severity
Low
Anything else?
No response

When displaying long usernames in the UI it also has no wrap or character cut off.  See screenshot.


WindiCSS ignores conditional classes in Svelte

We just migrated from TailwindCSS to WindiCSS for our SvelteKit project. Everything worked out fine, except for the following conditional classes:
<div class:bg-red-400={predicate}/>

bg-red-400 is not detected and not included in Windi's CSS files. I know that you can add it to the safe list, but it would be great if it could be detected automatically.

"vite-plugin-windicss": "^1.3.0",
"windicss": "^3.1.7"


rst description validation may require pygments

If a reStructuredText (rst) long description contains code blocks, docutils will try to load pygments to highlight them, and give a warning if it's not there. These warnings are the same mechanism flit uses to detect invalid rst, so the validation fails, and flit refuses to build the project.
Possible solutions:

Find some way to suppress that specific warning
Recognise and ignore that warning - matching human-readable messages is ugly, but docutils changes very slowly, so it might be good enough.
Require pygments. I'm reluctant to do this as it's a relatively big package which flit doesn't really need, and only a subset of projects are affected.

Totally does. My builds are failing because flit install --extras=all doesn’t install the test dependencies before doing that check: https://travis-ci.org/theislab/anndata2ri/jobs/620084576

Option 1 turned out to be easy - see #357.


Straight lines turn curved when one of the end points is panned out of the chartarea

(Split from #2 since it's not certain if the cause is the same)
Sample html code:
https://gist.github.com/jachstet-sea/956ae41702a7487502996285387ec16b
Original (after reload - straight lines):

After panning the lines are curved (the one on the left more than the other, but both are):

Tested using the latest dev version of Chart.js and this has been fixed: https://codepen.io/anon/pen/ZOWbyy


Requesting longer or toggle-able timeout for overlay

Hey there, thanks for the great plugin. I'd like to request an option to disable the overlay timeout, or maybe allow us to extend it. On a UIM, going back to Priff to get a new inventory of logs usually means I have gone past the timeout and I have to NPC contact again to get the overlay back.

Closes as done as there is a config option to set the timeout to up to 60 minutes


Fix hibp request issues

🗣 Description
Fixes #1352
HIBP is running into issues. We believe this is due to the request library currently being used
💭 Motivation and context
HIBP Scan is failing with the following error:
throw new Error('The onCancel handler was attached after the promise settled.');
🧪 Testing
Tested locally, and with current hibp tests
📷 Screenshots (if appropriate)

✅ Checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

On my tests I never got the handler issue again, but I am still getting the mitmproxy error pretty much every time on my local, I wasn't able to test in the COOL because of the AWS outage, but I will test once its up again


[release/v1.24] fips: fix Wasm extensions to comply with FIPS

Commit Message: Fixes a build issue with Wasm extensions triggering a non-FIPS mode when included into Envoy.
Risk Level: low
Testing: yes
Docs Changes: none
Release Notes: yes

/retest

pushing through to progress release - release tests passing


Remove @oleg-nenashev from CODEOWNERS

I am not doing the reviews anymore

Override merging this. I'm open to add more people later but I dont want to spam Oleg anymore.


what is this plugin

this could be used in the agar.io ?
if yes when can we use it

Can you actually be more specific?


Fix missing Parameters in InitializeObjectAttributes

The entire Parameters section disappears after #21. It seems the parameter name must match the declaration in the header file, so they must be "p, n, a, r, s".
Related: #21, MicrosoftDocs/feedback#2305

@xiaoyinl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks!


Issue: DateTime Scalar Configuration Errors

Description
There are issues with the DateTime scalar configuration in the GraphQL config. When the DateTime scalar is defined in the config, the following error occurs:

Error 1: "Scalar DateTime is Predefined"

When the DateTime scalar is not defined in the config, the following error occurs:

Error 2: "Type DateTime not found"

Screenshots

for some reason DateTime is defined in the predefined list https://github.com/tailcallhq/tailcall/blob/e129a782eec5f5988fbfa0ddef5f37e2249e625a/src/core/scalar.rs#L11
but it's neither the part of the graphql spec nor part of our defined scalars


Swagger UI for SubscriptionService

Swagger UI stuff is missing. Need a way to add it if the Feature is installed of course!

Not sure we can actually do this programmatically.
Our intention was to detect if you already had the ServiceStack.Api.SwaggerUI SwaggerFeature` installed, and if so then decorate the service and operations.
However, we wont have the attributes since we cant install the SwaggerFeature for them without the ServiceStack.Api.SwaggerUI assemblies.
Unless we can find a way to do all this programmatically (without adding ServiceStack.Api.SwaggerUI as a dependency) I don't see a way we can do it.

Closing this for now, since I dont think its technically possible to do.


falco will lose connection to containerd.socket if containerd on host gets restarted

Describe the bug
If the containerd-process on the host-system gets restarted. Falco will loose the connection to the socket.
How to reproduce it

Increase log-level of falco to show libs-debug
Restart containerd on the host
Logs will show failing containerd-socket tries
falco will continue to try to reconnect, but it will never work

Expected behaviour
Falco has no issue when containerd gets restarted on host
Additional context
The issue is caused by mapping the socket as a simple file into the pod. These mappings are done inode-based, so a restarting containerd-process will drop&create a new socket-file on the host, causing a new inode to be used. The inode within the pod will no longer point to the socket-file.
Fix: Instead map the socket-file-containing-folder into the pod, so falco detects the broken socket, retries and is able to use the new inode of the socket.
FYI: A suitable patch to provide this functionality is on the way.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
sorry, totally forgot about this issue. Will provide the requested change asap


Whats wrong with this test.lua

Hello,
I am trying to make key bind toggle on/off but I can not make it so simple.
I am always getting "Turned ON"
test.lua
function showHint(msg,duration)
	if not managers or not managers.hud then
		return
	end
	managers.hud:show_hint({text = msg, time = duration})
end

boo = false

if boo == false then
	boo = true
	showHint("Turned ON",1)
else
	boo = false
	showHint("Turned OFF",1)
end

OK I just needed not to initialize boo
working example
if not boo then
boo = true
showHint("Turned ON",1)
else
boo = false
showHint("Turned OFF",1)
end


/containers/(name)/update doens't work?

Dear,
Does the http://(IP):8080/containers/(name)/update function of the Docker API not work though?

Also using port 2375 works, however wont that avoid swarm though?


Checking for updates phase!

A quick check to find whether the current version of the package is up to date otherwise, showing a warning message and asking for an update.
Available utilities:

Johnnydep

There can be a quick yes/no question about whether the user wants to update the package.

I would like to work on this one if you haven't already :crossed_fingers:

That's awesome. I checked some benchmarks and found that some packages are a bit slow in responding. Needs a bit of R&D.

@lnxpy, Check this out, I tried it and it works very well for pasteme.

Hi @lnxpy,  The library i told you about earlier checks if the two files (either the python file itself by using the file dunder method or a path to another file) we give it as it's arguments are the same or not.
We can use this to our own advantage, for example:

Check the setup.py file for the version number
Create a constant called VERSION in the constants.py file and check that.

Which one do you think suits our needs the best ?

@SepehrRasouli We may not work on auto-update for now Sepehr. I have no plans for now.


Use unwrapped secret id when not fetching token

When setting RETRIEVE_TOKEN to "false", this writes the still-wrapped secret to file. However, it has already been unwrapped, so there is no way to get the actual secret.

Thanks!


[New Feature] Add some instructions for Hugging Face based methods

While previous version didn't explain how the weights should be loaded, most runs used the default loading method (downloaded from the modelscope), this version some instructions will be added to help those who want to run the model based on the hugging face framework loading local weight.

i can help if you are reaching otu to outside collaborators for this :-)

Thank you for your kind assistance.
If you have downloaded model weights from HuggingFace or ModelScope through various methods, you can change the inference code to your local address for inference. For example, if I download the model to the local directory "D:\data\aix-7b-model", then the inference code can be modified to load the model from this location:

tokenizer = AutoTokenizer.from_pretrained("D:\data\aix-7b-model")
model = AutoModelForCausalLM.from_pretrained("D:\data\aix-7b-model", torch_dtype=torch.bfloat16)


FFI support disabled due to licensing situation

https://github.com/rust-lang/miri/pull/2527 temporarily disabled our FFI support. It is based on libffi which depends on abort_on_panic which has a very unfortunate license situation going on.

https://github.com/tov/libffi-rs/pull/58 will hopefully help here.


Question about extend_scales.

Hello, when I made my own video dataset, I found that there is a parameter 'extend_scale' used to zoom in and out the estimated smpl model and align it to the 'rest_pose' you gave. When i draw the 2D keypoint (calculated by the aligned kp3d and c2w) on the picture, there are some deviations.  I am a little confused  about this.
Can I directly use SPIN estimated result?
Is there anything to pay attention to in the selection of this parameter?

Thanks for your answer. That helps a lot. But I'm still a little confused. What's the purpose of aligning to the provided rest_pose? Will this cause the smpl model and image to be unable to align?

Aligning the scale to the provided rest_pose ensures that all subjects that we are training have roughly the same range, i.e., the 3D keypoints are within a range that is known to work. This saves us some trouble when we were developing the approach. We didn't really encounter the alignment problem you mentioned though, because we scale the camera correspondingly, so it usually gives us basically the same projection before/after alignment

Sorry to bother you again. I got this result on my own video and zju-mocap. I have confirmed that the mask and image are OK, but there are many shadows outside the mask. Im confused why this error occurs。

No problem at all!
And yes, this is a known property of A-NeRF: the model does not rely on any pre-defined surface, and therefore it can try to explain everything (even the background) using the skeleton pose.
Please see #8 for further discussions

Thanks a lot for your reply, that helps a lot. I read the discussions in #8. I have one more question. The input images are masked during the pre-process. I think there is no back-ground images is used, why there are shadows related to the background occured? the sampled rays are sampled from masked images, i really dont know why there are still background information.

The rays are not always sampled within the mask. In our case, we dilate (expand) the mask a little bit so it will sample in both the foreground and the background. This enables A-NeRF to somewhat learn to predict 0 density in the background when mask_image=True, given perfect masks/background, and diverse enough poses. Highly diverse poses, in principle, gives you clearer background. Otherwise, A-NeRF doesn't really care what it predicts in the background, because it wouldn't block the rendering in other images/views anyway.


Post update issues

Issue
Description

Shadow blocks
new shadow blocks need to be disabled

All issues regarding shadow blocks have been resolved.


Improved Linting Workflow

The linting workflow currently only checks formatting if the ruff check passes, because they're two steps within a job.
This runs linting and formatting as parallel jobs and improves the github action security by pinning dependencies.
It also fixes the ruff formatting errors.

Great. Thanks.
I am currently fixing a lot of style and typing issues.


Casting floats to integers does not check overflow

The following code
num::cast::<f64, i32>(1.0e+123f64)

will return
Some(-2147483648)

instead of None.

I think the root problem is impl_to_primitive_float, which just typecasts to integers with as.

I'd like to try this one.

@apopiak go for it!

This issue was moved to rust-num/num-traits#12


Job or task log panels are closes on state change

If you have a job or task log open such as:

If the state of the job or task changes then the panel is minimized, which can be a little annoying if you are try to watch the log. I think the min/max state should only be controlled by the user.

closed with #409 (?)


chore: bdd-gh-1582317663 to 0.0.1

chore: Promote bdd-gh-1582317663 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Remove rspec dependency

Signed-off-by: Dmitriy Zaporozhets<EMAIL_ADDRESS>

Changes Unknown when pulling 8ef84bef727b77f45d57c8d3cee78d470c11451b on dz-remove-rspec into ** on master**.

Coverage remained the same at 87.975% when pulling 94f116a44dfae05ab7a32c33d29f9b9db284de9b on dz-remove-rspec into b9ee18ecc867a64d9a619fec3716dfdf29cc1ac3 on master.


Bad syntax highlighting of XHP class definitions

class Foo {}

class bar {}

class :biz {}

As far as HHVM and Hack are concerned, this syntax only works if EnableXHPClassModifier and DisableXHPElementMangling are both changed from their defaults, but that is currently still supported


Clean up incorrect article flags

This modifies the rss_item::sort_flags function in rss.cpp in order to
correct two bugs in the way it cleans up the input flags. Changes are :

sort_flags no longer fails to remove more than one following or identiqual
non alphabetic characters.
sort_flags no longer removes extra characters when a letter appears
twice in the flag list.

Fixes #436 #437 #438
Link to build : https://travis-ci.org/akrennmair/newsbeuter/builds/179715117

Pushing only the test for now, to demonstrate they indeed fail. Will then push the fix.

Coverage increased (+0.05%) to 32.442% when pulling 4b4704f359bcca6f1b2ad712b95333be5c6d1386 on tkerdonc:flag_cleaning into 3df0196794575f63a2870847a8f10339c54f1c34 on akrennmair:master.

Regarding tests: we create separate test files for separate source files. In this case, you're testing rss_item, which is defined in include/rss.h, so you should've created test/rss.cpp and put the tests there.
Regarding commits: I got your intention with demonstrating tests first, then adding a fix later, but I'd like to have a history where each commit does just one change. Currently your commit contains two separate changes; can you please split them?

Thanks for the review. This latest push integrates the modification you requested, moves the test to rss.cpp and squashes the commits in two. Let me know what you think !

Hmmm, tests don't look good, Should have tested the whole test suite before pushing. looking into that...

Got it, the double comparison on line 316 is indeed required.
	for (unsigned int i=0; i<flags_.size(); ++i) {
Even if the test passes, we are accessing unallocated memory on the following line. Pushing the fix

Coverage increased (+0.04%) to 32.436% when pulling 8fa1c21efd174a9fe44772876095b02c7e5ff617 on tkerdonc:flag_cleaning into 605e3350f50465b33470d3545df75ae5a16640da on akrennmair:master.

Coverage increased (+0.04%) to 32.436% when pulling 8fa1c21efd174a9fe44772876095b02c7e5ff617 on tkerdonc:flag_cleaning into 605e3350f50465b33470d3545df75ae5a16640da on akrennmair:master.

Coverage increased (+0.04%) to 32.436% when pulling 8fa1c21efd174a9fe44772876095b02c7e5ff617 on tkerdonc:flag_cleaning into 605e3350f50465b33470d3545df75ae5a16640da on akrennmair:master.

Coverage increased (+0.04%) to 32.436% when pulling 8fa1c21efd174a9fe44772876095b02c7e5ff617 on tkerdonc:flag_cleaning into 605e3350f50465b33470d3545df75ae5a16640da on akrennmair:master.

(Edited your comment to use code block instead of in-line code quotes.)

the double comparison on line 316 is indeed required.

Yes, you're right; sorry for the silly suggestion.
Regarding commits: you updated the messages, but bundled all the changes into the second commit. Can you redo it so that the first commit contains first test and first fix, and the second commit contains second test and second fix?

No worries, this was worth trying ^^. Splitted the commits properly this time, not sure what I was thinking writing messages not fitting the actual code changes, my bad.

Coverage increased (+0.04%) to 32.436% when pulling 921e930c42882e9d02bbca114bc594767100a0d9 on tkerdonc:flag_cleaning into 605e3350f50465b33470d3545df75ae5a16640da on akrennmair:master.

Coverage increased (+0.04%) to 32.436% when pulling 921e930c42882e9d02bbca114bc594767100a0d9 on tkerdonc:flag_cleaning into 605e3350f50465b33470d3545df75ae5a16640da on akrennmair:master.

Everything's in order; I'll merge once Travis checks finish (Travis has an outage at the moment, so this might take a while).
Thank you for working on this!

You're welcome, thanks for the support and advice !

Coverage increased (+0.04%) to 32.436% when pulling 81b920516a9d168a272bacddd7533b71948146ab on tkerdonc:flag_cleaning into 605e3350f50465b33470d3545df75ae5a16640da on akrennmair:master.


unable to discover netcoreapp1.1 tests.

Moving https://github.com/dotnet/cli/issues/5548#issuecomment-277313556 on behalf of @niemyjski

I am trying to upgrade my project from project.json to the new csproj format and hitting roadblocks left and right... (https://github.com/exceptionless/foundatio/tree/feature/dotnet)
It appears that VS2017 RC3 (Latest) is unable to discover or run any tests that have either netcoreapp1.0 or netcoreapp1.1.
When I try to run it from the command line I get
Test run for C:\Code\Foundatio\test\Foundatio.Tests\bin\Debug\netcoreapp1.1\Foundatio.Tests.dll(.NETCoreApp,Version=v1.1)
Microsoft (R) Test Execution Command Line Tool Version <IP_ADDRESS>
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
Warning: No test is available in C:\Code\Foundatio\test\Foundatio.Tests\bin\Debug\netcoreapp1.1\Foundatio.Tests.dll. Make sure that installed test discoverers & executors, platform & framework version settings are appropriate and try again.

Even more when I try to run with diagnostics
dotnet test .\test\Foundatio.Tests\Foundatio.Tests.csproj -v
Index was outside the bounds of the array.

but
dotnet test .\test\Foundatio.Tests\Foundatio.Tests.csproj --no-build /v
:diag

works but doesn't give me any diagnostics on why it couldn't connect to test host / run tests.

It seems to be failing to discover net standard 1.0 tests as well :(

I looked at some of your csproj's and versions + refs look ok. Do you perhaps have an old CLI version?
Regardless, @dotnet/vstest needs to take a look to help us see how we can shore up the UX.

I shouldn't as I am inside of a fresh vm with a freshly installed VS2017RC3 .03

If you pull down the repo and switch to the dotnet branch, you may need to add back the netcoreapp1.0 to one or more test projects ( I need to get this working on a ci ASAP)

fyi i checked out the feature/dotnet branch today and added back netcoreapp1.0 to Foundatio.Tests.csproj and just changed the xunit.assert package reference to xunit and then it worked.. it then also worked for netcoreapp1.1 (only tested in command line, not VS)

Thanks for this, shouldn't xunit be picked up as a transitive package?

I couldn't find any noticeable difference in the built output except for the xunit metapackage appearing in deps.json.
Even tough xunit appears to just be a meta-package, it seems to be required in order for test discovery to work.
Since you split xunit.core and xunit.assert packages across the logger project (p2p referenced) and the test project itself, the resulting dependencies are identical to the following test project which also doesn't discover tests:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-preview-20170123-02" />
    <PackageReference Include="xunit.assert" Version="2.2.0-beta5-build3474" />
    <PackageReference Include="xunit.core" Version="2.2.0-beta5-build3474" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-beta5-build1225" />
  </ItemGroup>

</Project>

I'm unsure if this is expected or an issue with either vstest or the xunit test runner.

Yeah I added xunit and now it works so some kind of issue here

I've had a few experiences like this. The dotnet test experience seems to have a number of error cases where errors are ignored/captured and not passed on to the end-user. We need to brainstorm a bit regarding how we can pass errors/missing dependency information/next steps onto users to help them get test projects into a good state.

I had more luck after I imported xunit nuget package instead of xunit.core packages into my test framework. This used to work so I think something might be broken someplace.

Marking this as blocking-release since diagnostics is key for rtw.
Two hypothesis need to be verified:

Try this scenario with fix for #300, in case the adapter is printing relevant error messages.
If the testhost process doesn't start due to dependency missing, fix for https://github.com/Microsoft/vstest/issues/281 may help

Update: the tests are not discovered due to incorrect PackageReference. On dotnet-cli latest, following commands work as expected:
> dotnet new xunit
> # edit csproj to target netcoreapp1.1
> dotnet restore
> dotnet test

This simple example however will not work:
mkdir web && mkdir tests && cd web

dotnet new webapi --framework netcoreapp1.1

cd ../tests

dotnet new xunit --framework netcoreapp1.1

dotnet add reference ../web/web.csproj

dotnet restore

dotnet test

gives me

Build started, please wait...
Build completed.
Test run for
/tests/bin/Debug/netcoreapp1.1/tests.dll(.NETCoreApp,Version=v1.1)
Microsoft (R) Test Execution Command Line Tool Version <IP_ADDRESS>
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
Warning: No test is available in /tests/bin/Debug/netcoreapp1.1/tests.dll. Make sure that installed test discoverers & executors, platform & framework version settings are appropriate and try again.

dotnet cli version
Version  : 1.1.0
Build    : 928f77c4bc3f49d892459992fb6e1d5542cb5e86
framework version
1.0.0-rc4-004771

@jimmystridh  xunit < 2.2.0-beta5 not compatible with netcoreapp1.1, and Microsoft.NET.Test.Sdk < 15.0.0-preview-20170210-02 doesn't provide error message from xunit runner to end user.
Please update PackageReferences to following:
  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-preview-20170210-02" />
    <PackageReference Include="xunit" Version="2.2.0-rc2-build3523" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-rc2-build1249" />
  </ItemGroup>

thanks a lot @smadala , that indeed helped in both the example above and my real project

We merged in the dotnet branch of foundatio and I'm going to try this today (I know we updated to rc2) but I'm having a heck of my time for my tests to be discovered still
https://github.com/exceptionless/foundatio

We are already using those package versions in Foundatio @niemyjski and the test runner is still very flakey for us.

Yep can confirm, very flakey on our solutions. Please run them and try it... it would be greatly appreciated as it doesn't work on some projects like AWS 100% of the time and others is very flakey.

@niemyjski Seems like testplatform dependency not added to all test projects. After adding them test getting discovered and running. Few tests are failing on my machine with RedisConnectionException.
Please apply following patch and verify.
add-testplatform-deps.patch

@smadala I shouldn't have to define those. They are transitive and defined in foundatio.tests project which is referenced

I'm facing an interesting issue where no tests are discovered on Mac OS, but it's running just fine on windows and linux containers. Attached a small repo (including restore & build output).
It is an empty console and an empty xunit project template extended with the package references I have in a real app.
testrepro.zip
.NET Command Line Tools (1.0.0-rc4-004788)

Product Information:
 Version:            1.0.0-rc4-004788
 Commit SHA-1 hash:  f2ad5a39ab

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.12-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.0-rc4-004788

@niemyjski Netcore test project need direct reference of Microsoft.NET.Test.Sdk package to successful run tests. Otherwise tests fail with  Error: Could not find testhost.dll for source '<path_to>\Foundatio\test\Foundatio.AWS.Tests\bin\Debug\netcoreapp1.1\Foundatio.AWS.Tests.dll'. Make sure test project has a nuget reference of package "microsoft.testplatform.testhost".
Which is misleading, Issue: https://github.com/Microsoft/vstest/issues/341

Tried migration for following projects:
core-setup: master
ApplicationInsights-aspnetcore:develop
Foundatio:tree/78793fe646fd7f845b5bf697916275045f7dadde
Migrate Issues:
Core-setup
Compilation error: Need to add package(Microsoft.DotNet.ProjectModel) reference manually.
Test ran.
ApplicationInsights-aspnetcore
Compilation error:  Add Reference to System.Net.Http to net451 framework manually.
Test ran.
Foundatio
Took clean commit having no migration changes, it has only net46 TF, Migrated successfully,
Test ran.

@smadala you'll need to enable the tests for netcoreapp1.1 on all test projects but Foundatio.Azure.Tests, we disabled them because we couldn't detect our tests otherwise..
So you are also saying that the test reference isn't transitive? That really sucks I have to add it to everyone one of my test projects when I already have a reference to it via Foundatio.Tests. Also, why does it currently work on some projects but not others? That doesn't make no sense if it's not transitive, it should only then work on Foundatio.Tests.

Currently recommend approach for adding package reference to multiple projects is using targets. I guess tests running only for net46. Can you please verify that. If not please provide respective project.

All net46 tests will run From command line but only a few are detected within VS. We have had a ton of issues with both netcoreapp1.1 and net46 both set on the test projects (we want to run the tests for both). This causes tests to not be discoverable or ran from command line (in some cases) or vs.

And yes, currently all test projects are only targeting net46 because otherwise we'd have serious test issues so we removed .netcoreapp from the test projects until this is resolved.

Are tests still failing after adding direct reference to Microsoft.Net.Test.Sdk? If so, can you please provide the project name.

@smadala I'll try it and get back to you, but I'm not happy about it. I don't want to have to define it again in every test project even though my referenced project has it and then have to update it in every test project every time the sdk revs.... I want clean csproj files and not a million files changing when I upgrade deps.

@niemyjski Totally agreed on having clean csproj, can please raise issue for it.

@dasMulli Able to repo tests not discovered for provided project. Looks like testhost failing with error
'/Users/vstest/Downloads/testrepro/tests/bin/Debug/netcoreapp1.1/Microsoft.DiaSymReader.Native.amd64.dll'. A device attached to the system is not functioning.
 (Exception from HRESULT: 0x8007001F)
File name: '/Users/vstest/Downloads/testrepro/tests/bin/Debug/netcoreapp1.1/Microsoft.DiaSymReader.Native.amd64.dll' ---> System.Runtime.InteropServices.COMException (0x8007001F): A device attached to the system is not functioning.
 (Exception from HRESULT: 0x8007001F)
   at System.Runtime.Loader.AssemblyLoadContext.nGetFileInformation(String s)
   at Microsoft.VisualStudio.TestPlatform.Common.Utilities.AssemblyResolver.OnResolve(AssemblyLoadContext loadContext, AssemblyName args)
TpTrace Information: 0 : 2596, 3, 2017/02/17, 00:37:19.419,<PHONE_NUMBER>555, testhost.dll, AssemblyResolver: Microsoft.DiaSymReader.Native.x86: Resolving assembly.
TpTrace Information: 0 : 2596, 3, 2017/02/17, 00:37:19.420,<PHONE_NUMBER>009, testhost.dll, AssemblyResolver: Microsoft.DiaSymReader.Native.x86: Failed to load assembly. Reason:System.IO.FileLoadException: Could not load file or assembly '/Users/vstest/Downloads/testrepro/tests/bin/Debug/netcoreapp1.1/Microsoft.DiaSymReader.Native.x86.dll'. A device attached to the system is not functioning.
 (Exception from HRESULT: 0x8007001F)
File name: '/Users/vstest/Downloads/testrepro/tests/bin/Debug/netcoreapp1.1/Microsoft.DiaSymReader.Native.x86.dll' ---> System.Runtime.InteropServices.COMException (0x8007001F): A device attached to the system is not functioning.
 (Exception from HRESULT: 0x8007001F)
   at System.Runtime.Loader.AssemblyLoadContext.nGetFileInformation(String s)
   at Microsoft.VisualStudio.TestPlatform.Common.Utilities.AssemblyResolver.OnResolve(AssemblyLoadContext loadContext, AssemblyName args)
TpTrace Information: 0 : 2596, 3, 2017/02/17, 00:37:19.420,<PHONE_NUMBER>634, testhost.dll, AssemblyResolver: xunit.runner.reporters.netstandard11: Resolving assembly.
TpTrace Information: 0 : 2596, 3, 2017/02/17, 00:37:19.420,<PHONE_NUMBER>982, testhost.dll, AssemblyResolver: xunit.runner.reporters.netstandard11: Failed to load assembly. Reason:System.IO.FileLoadException: Could not load file or assembly '/Users/vstest/Downloads/testrepro/tests/bin/Debug/netcoreapp1.1/xunit.runner.reporters.netstandard11.dll'. A device attached to the system is not functioning.
 (Exception from HRESULT: 0x8007001F)
File name: '/Users/vstest/Downloads/testrepro/tests/bin/Debug/netcoreapp1.1/xunit.runner.reporters.netstandard11.dll' ---> System.Runtime.InteropServices.COMException (0x8007001F): A device attached to the system is not functioning.
 (Exception from HRESULT: 0x8007001F)
   at System.Runtime.Loader.AssemblyLoadContext.nGetFileInformation(String s)
   at Microsoft.VisualStudio.TestPlatform.Common.Utilities.AssemblyResolver.OnResolve(AssemblyLoadContext loadContext, AssemblyName args)

log.txt
log.host.17-02-17_00-37-18_20929_5.txt
Will try to find root cause.

@niemyjski wrote:

@smadala I'll try it and get back to you, but I'm not happy about it. I don't want to have to define it again in every test project even though my referenced project has it and then have to update it in every test project every time the sdk revs

This sounds like the use case for a .props and .targets file. This file could be imported in all projects, and may provide the <PackageReference Include="Microsoft.NET.Test.Sdk" />.
An example in vstest repo:
https://github.com/Microsoft/vstest/blob/master/test/Microsoft.TestPlatform.CoreUtilities.UnitTests/Microsoft.TestPlatform.CoreUtilities.UnitTests.csproj#L7
https://github.com/Microsoft/vstest/blob/master/scripts/build/TestPlatform.Settings.targets#L78

@smadala so I added it to all my test projects which made them discoverable in vs but still having some issues (will log them in two separate issues on this repo). But how do I know what they are running under (net46 or netcoreapp1.1)?

Here is a link to the other issue I am seeing (which was closed by @smadala in December) https://github.com/Microsoft/vstest/issues/280

@dasMulli Update for tests failing on MacOS, looks like issue related  Swashbuckle.AspNetCore 1.0.0-rc1 reference. Removing same reference makes tests passed. Raised issue https://github.com/Microsoft/vstest/issues/516.

But how do I know what they are running under (net46 or netcoreapp1.1)?

Running tests for MTF(Multiple Target Framework): https://github.com/Microsoft/vstest/issues/298, Currenlty does not support from IDE.

Following reference should fix the issue.
<ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-preview-20170210-02" />
    <PackageReference Include="xunit" Version="2.2.0-rc2-build3523" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-rc2-build1249" />
  </ItemGroup>

Tracking related bugs here:
Misleading error message when test project is missing test runner.
Microsoft.NET.Test.Sdk package is not transitive and is required by every test project.
On MacOS no tests discovered after adding reference to Swashbuckle.AspNetCore-1.0.0-rc1 in product code


How do I add prompts in VectorDBQAChain?

I'm using PineconeStore and VectorDBQAChain for giving answers to users questions by looking up in the pinecone vector database but now i want to add prompts to my bot. How do I add it? I tried looking up in the documentation and the typescript types but couldn't find anything

You can pass the param combineDocumentsChain with your custom prompt

Hey @Rishab1207 did it work for you?
With a bit of code if you are still struggling:
  const llmChain = new LLMChain({ llm: model, prompt: promptTemplateBot })
  const stuffChain = new StuffDocumentsChain({ llmChain })

  const chain = new VectorDBQAChain({
    vectorstore: vectorStore,
    combineDocumentsChain: stuffChain,
    returnSourceDocuments: true,
    k: 4,
  })

Hey @Rishab1207 , I just finished an entire presentation on it
Maybe this code will help you as well:
const model = new OpenAI({ modelName: 'gpt-3.5-turbo' })
 const promptTemplateBot = /*#__PURE__*/ new PromptTemplate({
   template:
     'You act as if you were Maxime Thoonsen a CTO of a digital service ...' +
     'Context:\n\n{context}\n\nQuestion: {question}\nHelpful Answer:"',
   inputVariables: ['context', 'question'],
 })

 const llmChain = new LLMChain({ llm: model, prompt: promptTemplateBot })
 const stuffChain = new StuffDocumentsChain({ llmChain })

 const vectorStore = new SupabaseVectorStore(new OpenAIEmbeddings(), {
   client,
   tableName: 'documents',
   queryName: 'match_documents',

 })

 const chain = new VectorDBQAChain({
   vectorstore: vectorStore,
   combineDocumentsChain: stuffChain,
   k: 4,
 })

 const result = await chain.call({ query: question })

@Rishab1207 I have reread your question. You don't need to pass the {context} and {question} manually. The context is pull during the processing of the chain and the question when you call the chain await chain.call({ query: question }).
Hope it helps

Thanks @MaximeThoonsen.

@MaximeThoonsen Can you also tell me how can I use memory/chat history along with VectorDBQAChain.
Here's what I tried:
router.post("/api/gpt/get-response", async (req, res) => {
	const { userQuery } = JSON.parse(req.body);

	res.setHeader("Transfer-Encoding", "chunked");
	res.setHeader("Cache-Control", "no-cache");

	try {
		// some pinecone initialisation code
		const pineconeIndex = client.Index("my index");

		const vectorStore = await PineconeStore.fromExistingIndex({some variables});

		// Model
		const streamedModel = new ChatOpenAI({
			// some required parameters
			streaming: true,
		});

		const promptTemplateBot = new PromptTemplate({
			template: `my prompt`,
			inputVariables: ["context", "question"],
		});

		const llmChain = new LLMChain({
			llm: streamedModel,
			prompt: promptTemplateBot,
			memory,
		});

		const stuffChain = new StuffDocumentsChain({ llmChain });

		const chain = new VectorDBQAChain({
			vectorstore: vectorStore,
			combineDocumentsChain: stuffChain,
			k: 4,
		});

		await chain.call({ query: userQuery });
	} catch (error: any) {
		console.log({ error: error.message });
	}
});

const memory = new BufferMemory({
	chatHistory: new UpstashRedisChatMessageHistory({
		sessionId: "test", // Or some other unique identifier for the conversation
		config: {
			url: "some_url", // Override with your own instance's URL
			token: "abcd", // Override with your own instance's token
		},
	}),
	returnMessages: true,
	inputKey: "test-input-key",
	memoryKey: "history",
});

Few questions:

When I'm using console.log({ memory: await memory.loadMemoryVariables({}) }); I'm only getting AI responses in the memory not my questions in that. Here's a screenshot of my redis db

How the prompt variables are automatically pulled in? I want to pass the conversation/conversation summary as context, how do I do it?
What's input/output key that we pass in the memory object?
How can I check the value of promptTemplateBot once the variables are passed in it?

hey @Rishab1207,
I haven't played much with history so I can't answer you.

How the prompt variables are automatically pulled in? I want to pass the conversation/conversation summary as context, how do I do it?
I think you reach a point where you should look at the code, you'll understand how it works. The context comes from the result in the search from your database. The question, it's you who give it to the chain (your userQuery)
What's input/output key that we pass in the memory object?
I haven't played much with memory..
How can I check the value of promptTemplateBot once the variables are passed in it?
Maybe with the verbose mode or with intermediate_steps. Or you extend the class and you add console.log where you need them :)

@MaximeThoonsen Can you also tell me how can I use memory/chat history along with VectorDBQAChain.

Have you found how to use memory/chat history in combination with VectorDBQAChain?

I haven't tried it

@miracsengonul Check this https://discord.com/channels/1038097195422978059/1114547577736667249/1118236755993301023

@miracsengonul Check this https://discord.com/channels/1038097195422978059/1114547577736667249/1118236755993301023

Thank you but I can't access the link


[SPARK-44796][BUILD][CONNECT] Remove grpc-java plugin related configuration from the connect/connect-client-jvm module

What changes were proposed in this pull request?
This pr remove grpc-java plugin related configuration from the connect/connect-client-jvm module for SBT because the code generation related to grpc-java is handled by the connect-common module. The reason this pr did not touch the Maven pom.xml is because the corresponding Maven modules originally did not have that configuration.
Why are the changes needed?
Clean up unnecessary sbt configurations.
Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass GitHub Actions

Merged into master and 3.5. Thanks @hvanhovell


Update documentation with respect to the changes done in hydrus

Referencing this here for a reminder to myself, https://github.com/HTTP-APIs/http-apis.github.io/pull/78#pullrequestreview-408706124

This issue can be closed. Fixed in https://github.com/HTTP-APIs/documentation-hydrus/pull/14


App config constance

Closes: #3403
What's Changed

Provide support for configuring Apps through the Nautobot Settings Config. Updates the settings_or_config templatetag helper and jinja2 filter to add App support.

TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
[x] Attached Screenshots, Payload Example
[x] Unit, Integration Tests
[x] Documentation Updates (when adding/changing features)
[x] Example Plugin Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

Looks really solid! The only thing I can think might be missing is whether the constance_configs should be added to self.features and shown on the "installed plugins" detail view? Doesn't look like we're currently doing that for the settings configs, but it might be useful to add? If so, I'm thinking it probably should only just list the variable names/help texts/field types, not the currently configured values?

That is an interesting idea. Let me look into that.


Correct typo in constant in qr-bills.rb

Relevant error: NameError (uninitialized constant QRParams::QR_BILL_WITOUTH_REFERENCE

thx for the PR @RandieM


Create DivisiblePairCount2.py

Assigned Issue Number ?
#842
Language Opted ?
Python
Number of files added or updated ?
1
Name of these files ?
Data_Structures => Maps_Hash_Dict => DivisiblePairCount2.py
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Sir I know that there is already a solution of Python in the Repo, but I think that it is more suitable and appropriate solution. I hope you will give me a chance to contribute.


how do i assemble it

whenever i click the ship controller it does nothing. im doing it with an empty hand.

nvm my game is just broken


Adding a 'best guess' scenario for the scanner to attempt to find and repair a pclntab with bad magic

Hello!
I've run into a recurring issue with packed/obfuscated samples, where the pclntab magic will be modified. This breaks GoReSym, particularly when trying to validate the table by loading it. This PR contains a fix that I've been using as a python script, but consolidating would be nice.
The fix does a couple things to accomplish a 'best guess' scan for the pclntab:

Removed short-circuit when scanner thinks it finds valid pclntab via symbol, continue to do bytescans anyways
Added scan for table by searching for first entry (internal/cpu.Initialize)
For each signature in pclntab signatures, add a candidate with the valid signature magic bytes (encompass potential Go versions)

This had no major noticeable performance hits for valid Go binaries, although it did take a bit longer when trying to repair the packed/obfuscated files I've run across.
The reason for removing the short circuit is because even if the pclntab symbol may still exist, it points to the mangled pclntab which cannot be loaded by GoReSym. Removing this and just letting it go through the repair scan didn't cause any issues in my testing and still provided useful results on mangled binaries.
I am not so familiar with the Go runtime, nor the GoReSym codebase, so if you have a more optimal way to implement this I am all ears.
Please let me know if you have any comments, questions, or concerns.
Thanks!

Thanks for submitting a PR!
We have also seen Go binaries with destroyed pclntab magics. Typically though it is fairly easy to patch back the magic bytes to get GoReSym to parse correctly. I am open to adding support for additional scan techniques to support binaries with these destroyed magics, though I have an issue with this particular technique.
The pclntab (pcHeader) has changed it's member over time between the go versions. It is not safe and general to find some later member and then subtract backwards to locate the start of the structure. For example, see this change between go 1.18 and 1.16:
1.18

type pcHeader struct {
	magic          uint32  // 0xFFFFFFF0
	pad1, pad2     uint8   // 0,0
	minLC          uint8   // min instruction size
	ptrSize        uint8   // size of a ptr in bytes
	nfunc          int     // number of functions in the module
	nfiles         uint    // number of entries in the file tab
	textStart      uintptr // base for function entry PC offsets in this module, equal to moduledata.text
	funcnameOffset uintptr // offset to the funcnametab variable from pcHeader
	cuOffset       uintptr // offset to the cutab variable from pcHeader
	filetabOffset  uintptr // offset to the filetab variable from pcHeader
	pctabOffset    uintptr // offset to the pctab variable from pcHeader
	pclnOffset     uintptr // offset to the pclntab variable from pcHeader
}

1.16

type pcHeader struct {
	magic          uint32  // 0xFFFFFFFA
	pad1, pad2     uint8   // 0,0
	minLC          uint8   // min instruction size
	ptrSize        uint8   // size of a ptr in bytes
	nfunc          int     // number of functions in the module
	nfiles         uint    // number of entries in the file tab.
	funcnameOffset uintptr // offset to the funcnametab variable from pcHeader
	cuOffset       uintptr // offset to the cutab variable from pcHeader
	filetabOffset  uintptr // offset to the filetab variable from pcHeader
	pctabOffset    uintptr // offset to the pctab varible from pcHeader
	pclnOffset     uintptr // offset to the pclntab variable from pcHeader
}

The addition of the textStart      uintptr will cause this technique to fail. I would prefer a solution that arrives at the pcHeaders start via some other means. I suggest instead doing:

Signature the assembly runtime_modulesinit for the common architectures.
Within the signatured routine, locate the reference:

for ( i = &runtime_firstmoduledata; i; i = i->next )

in x86-x64 asm:
.text:0000000000452618 48 8D 05 01 3A 28 00                    lea     rax, type_runtimeModuleData
.text:000000000045261F 90                                      nop
.text:0000000000452620 E8 9B C6 FB FF                          call    runtime_newobject
.text:0000000000452625 48 89 44 24 50                          mov     [rsp+68h+var_18], modules_0
.text:000000000045262A 48 8D 0D CF 26 52 00                    lea     rcx, runtime_firstmoduledata
.text:0000000000452631 EB 0D                                   jmp     short loc_452640
.text:0000000000452633                         loc_452633:
.text:0000000000452633 48 8B 89 30 02 00 00                    mov     rcx, [rcx+230h]           ; +0x230 will vary between go version
.text:000000000045263A 66 0F 1F 44 00 00                       nop     word ptr [rax+rax+00h]

An example signature might be:
48 8D 05 ? ? ? ? 90 E8 ? ? ? ? 48 89 44 24 ? 48 8D 0D (?<first_moduledata_offset ? ? ? ?) EB 0D 48 8B 89 ? ? ? ? 66 0F 1F 44 00 ?

This would give us an offset to the runtime_moduledata which will hold a pointer to the start of the pcHeader. Would you be up for trying to implement that technique instead, or something similar that does not rely on magic numbers or signaturing fields within the pcHeader itself?

Sure, I'll take a look and see what I can do.

Hello again,
It's a bit of a larger commit, but I've gotten it working to where I would like it for my use case. See objfile/scanner.go for the signatures and scan logic.
A couple notes:

I believe this method will not work on binaries using big endian (I can try to add that in some other time).
Performance is as expected when dealing with binaries GoReSym could already handle, but when attempting to repair it takes much longer. I think this is not because of the scanner per se and seems to be the parser that deals with the candidates. I have not looked at this code but can potentially optimize in the future. Tested binaries needing repair brought time from around 5 seconds to 25 seconds.
I only signatured recent files that I was dealing with (Go 1.20), but it should be easy to add more.

Thanks for your contribution! I will review what you've written in a week or two and likely extend it to handle the cases you've mentioned and make it robust to all versions and configurations (this may take some time - don't fret if you don't see progress here for a bit). Thanks again!

Hi! I've made the following changes:

The scanner's signature were all for the x64 architecture and not dependant on the OS - I've removed that parameter to simplify it.
The scanner now returns a structure rather than anonymous array to improve readability
The new technique is changed to always occur - but I reverted the changes done to the pre-existing techniques. The reason for this is they are independant techniques, the previous ones work well and I do not want to change that logic. So, all existing logic will occur exactly the same, the short circuit exit scan was removed, and a signature scan will occur over each section adding new candidates for this method
The .Data() call in the Sections loop was duplicating an expensive read. The DataAfterSection() data is now used instead for the signature scan
An additional loop through the sections was added to read out the pclntab data after the signature scan, this duplicated another expensive operation and also created an issue when the pclntab section is before the .text section (as only loop iterations through the sections beyond where the signature scan matching modulesinit would be checked to be in range of the found pointer) - I changed this to the much cheaper read_memory api which solves both issues.
The candidates now patch their magic values for all supported magics which handles the case they were intentionally corrupted
Big Endian and Little Endian scanner results are now both supported - candidates of each type are added from the signature scan.
Commenting added

This seems to work really well for x64 targets on windows/mac/linux. There is still no support for other architectures such as x86, or ppc. The scanner itself also does not support BigEndian, there is a single LittleEndian pointer read in there that must be changed in the future.
I will continue to work on this!

Awesome!! Thanks so much for taking a look and working on changes! I've learned a lot reading through them.
And yeah I am aware that the scanner wasn't made for both BE and LE. I think you store that data in the file structs for elf and macho (File.FileHeader.ByteOrder), so I could try and either create a second scanner or add a case to the current scanner if the findModuleInitPCHeader function also receives the ByteOrder. Let me know if you'd like help, but I also don't want to make you have to refactor more code haha.

I had not thought to use the ELF header for the endianess, that is smart I will modify this to do that! The scanner as it is now is capable of doing both big and little endian. The choice to use big/little endian is now handled in the callback that matches the signature, so we can choose which to use based on the arch being matched. I only expect us to see BE for arm and ppc really anyways.
I'll keep adding signatures and get this merged with some time!

Ah yes, I see how you use the callback. I like your implementation! I wouldn't have thought to do it that way, but it is smart and cuts down on needing to write separate implementations. Makes things much nicer!

This PR is now complete! Thank you very much for your original issue and first pass at a PR. GoReSym now supports stomped PCLNTAB magic for the following architectures/os's
win x lin x mac x ( arm64 x arm x ppc64_be x x64 x x86)
There is a new dependency on LIBYARA. I have had to add this dependency as the custom written signature scanner even with manual optimizations be myself was much too slow, and did not support features I ended up needing such as logical OR and skip ranges. The new scanner is so fast there is no perceptible slowdown when falling back to this scanning mode for stomped magics, and allowed me to support more architectures!
Mission success!


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

Ok, that took some time ...


Dynamic Routing

Hello,
I know this has been discussed in a few other places and also there is a example repo for express, however I'm struggling to get this working with the examples and help on slack:
I need two routes:

/notifications (pages/notifications/index.js)
/notifications/:id (pages/notifications/single.js)

My server (express) is setup to like so:
    server.get('/notifications/*', (req, res) => {
      return app.render(req, res, '/notifications/single', req.query);
    });

On the server getInitialProps I can grab the ID from ctx.req.params.  However, I'm struggling to navigate to the route using Router.

The following changes the URL in my browser, but reloads the /notifications route.

Router.push(`/notifications?id=${id}`, `/notifications/${id}`);

The following hits a 404 page:

Router.push(`/notifications/${id}`);

Is there anyway to handle this?
Cheers

You server route should be something like this:
server.get('/notifications/:id', (req, res) => {
  const params = { id: req.params.id }
  return app.render(req, res, '/notifications/single', params);
});

Maybe next-routes can be helpful to you, you could use it like this:
routes.add('notification', '/notifications/:id', 'notifications/single')
routes.add('notifications', '/notifications', 'notifications/index')

Router.pushRoute('notification', {id: 1})
Router.pushRoute('notifications')

<Link route="notification" params={{id: 1}}> ... </Link>

@arunoda that makes sense cheers :) Works!

I'm experiencing a similar issue but am unable to get it working. I'm linking from a route like /photo/1 to /photo/2 and I can see that the component is fetched and render is called inside of the component, but the page doesn't update. The URL does change, however, and reloading the page after following a link will load the new page.
Router.push(`/photo?id=${id}`, `/photo/${id}`)

const match = route('/photo/:id')

app.prepare()
.then(() => {
  createServer((req, res) => {
    const { pathname } = parse(req.url)
    const params = match(pathname)
    if (params === false) {
      console.log("params false")
      handle(req, res)
      return
    }
    console.log("render app")
    app.render(req, res, '/photo', params)
  })
  .listen(3000, (err) => {
    if (err) throw err
    console.log('> Ready on http://localhost:3000')
  })
})

Doing the same thing with a different page works correctly (like linking to /about) but I'm unable to make one photo link to the next (like from /photo/1 to /photo/2)

Nevermind!


HADOOP-18279. Cancel fileMonitoringTimer even if trustManager isn't define

Description of PR
The key stores factory starts a timer for monitoring file changes that should be reloaded.  The call to destroy() doesn't cancel the timer when a trust manager isn't defined.  This leaves the timer running, during shutdown.  This can be seen in unit tests that do not stop when the test completes.
How was this patch tested?
Analysis of logs for tests that were timing out despite successfully completing the test identified that the monitoring thread was still running.  With the addition of this change, these tests passed quickly.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 24s

trunk passed

+1 :green_heart:
compile
25m 14s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
22m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 39s

trunk passed

+1 :green_heart:
mvnsite
2m  5s

trunk passed

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
26m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  6s

the patch passed

+1 :green_heart:
compile
25m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
25m 23s

the patch passed

+1 :green_heart:
compile
20m 54s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 37s

the patch passed

+1 :green_heart:
mvnsite
2m  8s

the patch passed

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
23m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  6s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 33s

The patch does not generate ASF License warnings.

228m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4767/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4767

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 87b43c285c05 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b8dab8bdce3ee220c64b1284cfff2a4230f65fb4

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4767/1/testReport/

Max. process+thread count
1250 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4767/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Merged, thanks


Feature #157928407 Edit Request Endpoint

What does this PR do?
Adds the endpoint where a user can edit a request
Description of Task to be completed?

Use Test Driven Development to create the following endpoints:
PATCH api/v1/users/<int:user_id>/requests/<int:request_id>/

How should this be manually tested?

Clone this repository under the ch-Create-User-Models-#157941933 branch.

cd into the directory where this repository was cloned.

create a virtual environment using the code below
pip install virtualenv
virtualenv venv

install the requirements needed
pip install -r requirements.txt

run the code below to set the environment variables.
Windows
setx APP_CONFIG_NAME development
Mac/Linux
export APP_CONFIG_NAME=development

run the code below to start the server:
python maintenanceTracker.py

Test the above endpoints using Postman.

The endpoints documentation can be found on the path
api/v1 inside the browser.

Screenshot

What are the relevant pivotal tracker stories?
#157928407
Signed-off-by: Dave Mathews<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 69

34 of 36 (94.44%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 92.606%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

MaintenanceTrackerAPI/api/v1/users/single_user_single_request.py
34
36
94.44%

Totals

Change from base Build 67:
0.9%

Covered Lines:
501

Relevant Lines:
541

💛  - Coveralls


Errors after HA update to 2023.6.1

The Goodwe integration has stopped working in this version after giving multiple errors in the log, the integration loads on HA reboot and collects the states at that time, but does not update the data.
I have 2 inverters that until the update have worked without problems, the error seems to be related to sensor.goodwe_pv1_mode_label
I quote some of the errors found in the log
2023-06-16 11:57:05.443 DEBUG (MainThread) [goodwe.protocol] Sending: aa55c07f0106000245
2023-06-16 11:57:05.790 DEBUG (MainThread) [goodwe.protocol] Received: aa557fc001868c091a0044020a37004e020215000300500122000500020019000064006460010000010973008b171a1388010973000a08db1389010201e2000000000000d9030000273d7fe2805a000111fb0d750100300100d60001000003e3001008000000160c0d0a0f1200000000000000000000000000000000000000000000000000001ade0000112f020000000000001386
2023-06-16 11:57:05.791 DEBUG (MainThread) [custom_components._goodwe] Finished fetching GoodWe 1 (88) data in 0.348 seconds (success: True)
2023-06-16 11:57:05.793 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 583, in state
    numerical_value = float(value)  # type:ignore[arg-type]
                      ^^^^^^^^^^^^
ValueError: could not convert string to float: 'PV panels connected, producing power'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 229, in _handle_refresh_interval
    await self._async_refresh(log_failures=True, scheduled=True)
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 374, in _async_refresh
    self.async_update_listeners()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 164, in async_update_listeners
    update_callback()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 431, in _handle_coordinator_update
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 590, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 654, in _async_write_ha_state
    state = self._stringify_state(available)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 596, in _stringify_state
    if (state := self.state) is None:
                 ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 585, in state
    raise ValueError(
ValueError: Sensor sensor.goodwe_pv1_mode_label_2 has device class 'None', state class 'measurement' unit '' and suggested precision 'None' thus indicating it has a numeric value; however, it has the non-numeric value: 'PV panels connected, producing power' (<class 'str'>)
2023-06-16 11:57:08.474 DEBUG (MainThread) [goodwe.protocol] Sending: aa55c07f0106000245
2023-06-16 11:57:08.873 DEBUG (MainThread) [goodwe.protocol] Received: aa557fc001868c0a37004e020933004202021300030050012c00050005001900006400645d010000010974008a173f1389010974000209cd138a010201de00000000000135dc000040b48fc898eb000222040d720100300100000001000003e3000008000000160b02113913000000000000000000000000000000000000000000000000000035d2000026490200000000000013af
2023-06-16 11:57:08.874 DEBUG (MainThread) [custom_components._goodwe] Finished fetching GoodWe 2 (99) data in 0.400 seconds (success: True)
2023-06-16 11:57:08.881 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 583, in state
    numerical_value = float(value)  # type:ignore[arg-type]
                      ^^^^^^^^^^^^
ValueError: could not convert string to float: 'PV panels connected, producing power'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 229, in _handle_refresh_interval
    await self._async_refresh(log_failures=True, scheduled=True)
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 374, in _async_refresh
    self.async_update_listeners()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 164, in async_update_listeners
    update_callback()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 431, in _handle_coordinator_update
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 590, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 654, in _async_write_ha_state
    state = self._stringify_state(available)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 596, in _stringify_state
    if (state := self.state) is None:
                 ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 585, in state
    raise ValueError(
ValueError: Sensor sensor.goodwe_pv1_mode_label has device class 'None', state class 'measurement' unit '' and suggested precision 'None' thus indicating it has a numeric value; however, it has the non-numeric value: 'PV panels connected, producing power' (<class 'str'>)

Update:
I have installed version <IP_ADDRESS> (I had <IP_ADDRESS>) and now it works correctly.

Update:
I have installed version <IP_ADDRESS> (I had <IP_ADDRESS>) and now it works correctly.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_634ep54v1m/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_634ep54v1m/clone/recipe/meta.yaml:24: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_634ep54v1m/clone/recipe/meta.yaml:33: missing_pip_check: For pypi packages, pip check should be present in the test commands
WARNING: /tmp/abs_634ep54v1m/clone/recipe/meta.yaml:39: missing_description: The recipe is missing a description
ERROR: /tmp/abs_634ep54v1m/clone/recipe/meta.yaml:39: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_634ep54v1m/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_634ep54v1m/clone/recipe/meta.yaml:39: missing_dev_url: The recipe is missing a dev_url
Errors were found


Add a Licence to Project

Hey @onion797jp I wonder what type of license I should add to this project.

I added the LICENSE file.


XSS Bug in tryParseJSON()

The function tryParseJSON() in editable-form-utils.js is dangerously bad. The regex used to test if a string is JSON is terribly made, only checking if the string begins and ends with "[" or "{" and their counterparts "]" or "}". This means you can give it a a string such as "[]+alert(1)+[]" and it will match. Once it's matched, tryParseJSON() decides to run the text as code by doing s = (new Function('return ' + s))();. When using that code with an actual JSON string s becomes an object based on the JSON string given. Using my evil alert string s is set to "undefined" and the number 1 is alerted on the screen.
I was able to exploit this on my site by setting an editable value to "[]+alert(1)+[]" and refreshing the page. When initially inserting it tryParseJSON() isn't used but it is when the editable field is initialised on load. For my site I opted to replace the new Function() call with a JSON.parse() call. This fix won't work for everybody though, as JSON.parse() is much stricter about what is and isn't allowed in a JSON string (e.g. all properties must be surrounded in double quotes and no trailing commas are allowed).

🛠 A fix has been provided for this issue. Please reference: https://github.com/418sec/x-editable/pull/1
🔥 This fix has been provided through the https://huntr.dev/ bug bounty platform.


Rerun git pull/clone in case of network caused failure

In some server environment that network condition is not that good, running git clone/pull once is not 100% certain successful. In this case, if the git command returns a non-zero value, build.sh tries to rerun this git command 10 times maximum. Otherwise, it reports error in the log.

No longer maintaining the repo.


Add function hdfsGetRemaining to libhdfs

391

 Quality gate: Passed
2 Issues

 2 Code issues

Details

 Quality gate: Passed
2 Issues

 2 Code issues

Details


How to retrieve the public key from inside the yubikey?

Suppose I changed computers and lost the public key file. How can I extract it from the yubikey?

See issue #305 where somebody has cut and pasted the output

Reconfigure you yubikey about the part of GPG, If you do not have any keyserver you was upload and any backup in sotre.

Duping to other issue.


Wiki screenshots

First screenshots for the wiki.

I'm closing this b/c it would effectively merge develop into master which we don't want to do yet.


Porting to Arduino Uno Wifi Dev Edition (built in  ESP8266)

Hi scottlawsonbc this is an excellent project love it. I have a Uno with the built in ESP8266 chip and would love to get this working with the board but im very new to arduino. Do you have any recommendations to get this ported onto this board or would it be easier to look at a serial solution?
Thanks

We dont actually have the serial solution yet :) as of right now,  it was originally built for the esp8266 so if you can run the python, than you should be able tp get it up ajd running! I used the board that looks like an arduino uno but has an esp8266 chip. Is yours based on an esp8266, or an atmega chip?

it sounds like we have the same board....
http://www.arduino.org/products/boards/arduino-uno-wifi
using a udp example in the library i can receive the pythons generated udp packets the only other problem might be the rx pin that is used on the nodemcu not being available on the arduino uno wifi board.


Extremely slow downloads

@prateek-chaubey This is an amazing app you have created.
But download is extremely slow even on 4G, 5G.  (Like 80 kbps or something.)
Any chance faster downloads are supported.
Thank you.

This uses DownloadManager for downloading the files , i will check if it's the issue with download manager or something to better up the speed of downloading

It seems to be a command line tool, also i think a native implementation would be better rather than relying on a lib


layer update and push  flow

Description of changes:
Lambda Layer Update  flow:
-Command line prompts to take user input on what to update
-Update the template file based on user input
-added basic tests for the update flow
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cc @akshbhu @edwardfoyle @jhockett


Added icons of browser in buttons

Issue #47
I've added the icon of the respective browser followed by the name of the button add to edge & add to chrome.
Before -

After -

Good job. Thanks.

Most Welcome!


Add fallback to docker-compose running inside container

This depends on #1.
If docker-compose is not installed in the host, then we fallback to docker-compose run inside docker container. The utility binary that runs docker-compose inside a container is saved into ~/.srcd/bin.

I removed docker-compose locally and it woked really smooth, I only had to propagate the env vars to docker.

@carlosms yup, that was actually a bug in the branch this was rebased on. It's fixed now, I'm gonna rebase this on master and then it should work.

@carlosms sorry I was wrong, that was actually a bug that should be present in master, but that should have been fixed in this PR. In master there's no propagation of the env vars to the container.

@carlosms I've just rebased this on latest master. Can you try again whether it still gives you problems?

Exact same problem :/


Plugin request for plugin already on the classpath must not include a version

Hi, i'm getting this error every time i build my app

FAILURE: Build failed with an exception.

Where:
Build file 'C:\Users\hardk\AppData\Local\Pub\Cache\hosted\pub.dartlang.org\moor_ffi-0.2.0\android\build.gradle' line: 13

What went wrong:
Error resolving plugin [id: 'de.undercouch.download', version: '4.0.0']

Plugin request for plugin already on the classpath must not include a version

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
Finished with error: Gradle task assembleDebug failed with exit code 1

Hi, it seems like your moor_ffi version is outdated. Can you try switching to moor_ffi: ^0.4.0 or later? Let me know if the problem persists, thanks!


encoding issues in mail

This is not very simple to fix (apperently it requires some special encoding of the from address which is not provided by erlcloud or any of the current dependecies). It makes more sense to just send emails with HolidayPing as the display name.


Identification Issues

Caligula.The.Ultimate.Cut.2023.1080p.WEBRip.x264.AAC5.1-LAMA.mp4
Casablanca.1942.REMASTERED.1080p.BluRay.H264.AAC.mp4
Four.Rooms.1996.1080p.BluRay.H264.AAC.mp4

Not sure what can be done about the first one, but the second two seem to be picked up by the 3rd movie-title regex pattern. Regex101 Link
Running local tests.


Update .gitignore

Proposed changes

Closes #[issue number]
Checklist

[ ] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation (if appropriate)
[ ] I have run make fmt and formatted my code

Further comments

ah okay, I completely forgot it. I had an issue in my machine where .tool-versions was showing go 1.13 and I needed to run asdf local golang 1.16 to fix it. I thought it was only used by asdf to decide which plugin version to use


riot/riotcontrol project

I built this on riot and riot control if you want to add it to the readme! https://github.com/derekr/wheredamoviesat
http://wheredamoviesat.play.drk.es/

Got it added! Sorry for the delay!


🕵 NCSC Web Check for Data Platform

User Story
As a Data Platform engineer I would like to be alerted to security issues with web assets of the Data Platform
Definition of done

[ ] @ministryofjustice/data-platform-core-infra signed up to MyNCSC and joined Ministry of Justice organisation
[ ] Data Platform web assets decided and added to Web Check

Duplicate of #127


Make sure mocked actions can be identified in production build

Enable esbuild keep names as workaround
Add interactive test in vue example

Not sure if the tests should be kept in, as they add a lot of dependencies to the example.
Fixes #206.

Thanks @bodograumann!


[Bug]: Coinbase wallet takes ~30 seconds to initialize after connecting

Current Behavior
When you re-connect to a Coinbase wallet that was previously connected (no need to scan QR code), it takes 30 seconds to initialize. In this time, it says connected but all transactions fail with the message: 'sending a transaction requires a signer'
Expected Behavior
It should connect immediately or it should tell the user that they are not connected if it takes that long to initialize.
Steps To Reproduce
Coinbase Wallet on Ethereum mainnet.
Connect once, refresh the page and re-connect (it remembers the connection so need to scan QR code).
Then, try make a transaction immediately after it says connected.
What package is effected by this issue?
@web3-onboard/coinbase
Is this a build or a runtime issue?
Runtime
Package Version
"@web3-onboard/react": "2.1.6",
Node Version
14.17.6
What browsers are you seeing the problem on?
Chrome
Relevant log output
Error: sending a transaction requires a signer (operation="sendTransaction", code=UNSUPPORTED_OPERATION, version=contracts/5.6.1)
    at Logger.makeError (index.js?81dc:219:1)
    at Logger.throwError (index.js?81dc:228:1)
    at Contract.eval (index.js?11fc:314:1)
    at Generator.next (<anonymous>)
    at eval (index.js?11fc:8:1)
    at new Promise (<anonymous>)
    at __awaiter (index.js?11fc:4:1)
    at Contract.eval (index.js?11fc:312:1)
    at _callee12$ (butter.tsx?9bbc:838:44)
    at tryCatch (runtime.js?ecd4:45:16)
    at Generator.invoke [as _invoke] (runtime.js?ecd4:274:1)
    at prototype.<computed> [as next] (runtime.js?ecd4:97:1)
    at asyncGeneratorStep (asyncToGenerator.js?f2bc:3:1)
    at _next (asyncToGenerator.js?f2bc:25:1)
    at eval (asyncToGenerator.js?f2bc:32:1)
    at new Promise (<anonymous>)
    at eval (asyncToGenerator.js?f2bc:21:1)
    at _approve (butter.tsx?9bbc:853:21)
    at approve (butter.tsx?9bbc:825:21)
    at handleClick (MintRedeemInterface.tsx?24c7:149:20)

Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

@Amirjab21 I tried to reproduce the error above with the reproduction steps and wasn't able to see any errors.
I tested using our ReactDemo project available https://reactdemo.blocknative.com/
Can you confirm you are seeing the same issue using the our demo project?
If you are not seeing the same issue on our Demo you could send your Web3 Onboard config over and we can give it a look.

@Amirjab21 friendly ping on the questions above 🤓

@Adamj1232 It is working now works on the demo app too. I'm not too sure why it's working now but was failing before but it's all good now. Thanks :)

@Adamj1232 It is working now works on the demo app too. I'm not too sure why it's working now but was failing before but it's all good now. Thanks :)

@Amirjab21 excellent! Great to hear. If any other problems arise please feel free to reach back out. Thanks!


Fix empty response parsing bug

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.13%. Comparing base (c8b296e) to head (b8989e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   95.13%   95.13%
=======================================
  Files           6        6
  Lines         370      370
=======================================
  Hits          352      352
  Misses         18       18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Downgrade pipenv from 2023.2.18 to 2023.2.4

pipenv 2023.2.18 raised its minimum setuptools version to 67.x, which is newer than the setuptools version the buildpack pins to. This succeeds on the first build, however, for cached rebuilds then fails due to pip's version resolver not allowing overriding already-installed dependency versions when resolving version conflicts.
A new testcase has been added for pipenv caching (caching was already extensively tested when using pip, just not when using pipenv).
Resolves:
remote: -----> Installing pip 23.0.1, setuptools 63.4.3 and wheel 0.38.4
remote: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
remote: pipenv 2023.2.18 requires setuptools>=67.0.0, but you have setuptools 63.4.3 which is incompatible.

Longer term we will update to newer setuptools ourselves (once the dust settles on the many breaking changes introduced in newer setuptools versions), and hopefully newer pipenv will also relax its minimum setuptools version slightly.
Partially reverts #1412.
GUS-W-12670935.

https://devcenter.heroku.com/changelog-items/2552


Fix: Submissions can still be made to a deleted form

Description
We've identified an issue where submissions can still be made to a form even after it has been deleted. This results in unwanted data being inserted into our Convex database.
Expected Behavior
When a form is deleted, any attempts to submit to that form should be rejected, and no new submissions should be stored in the database.
Current Behavior
Currently, the submission endpoint does not verify whether the form ID exists in the database before accepting a submission. This allows submissions to non-existent (deleted) forms.
Steps to Reproduce

Create a form and note its form ID.
Delete the form through the provided delete functionality.
Attempt to make a submission to the deleted form using the noted form ID.
Observe that the submission is accepted and stored in the database.

Possible Solution
Implement a check in the submission endpoint to verify the existence of the form ID in the database before processing the submission. If the form does not exist, the request should be rejected.

fixed on another pr


Rename Docker EE/CE to Mirantis Docker Enterprise

Nick Chase at Mirantis requested this change
Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit b3861612a6d943afe2798f4ce5bbfd65d64cd433
https://deploy-preview-1574--landscape.netlify.com

LGTM


./change_ios_position.sh: line 69: pymobiledevice3: command not found

已安装pymobiledevice3包,但是执行命令
挂载Developer Disk Image
sudo pymobiledevice3 mounter auto-mount
提示 pymobiledevice3: command not found

Have you tried to restart the terminal after installing the pymobiledevice3?


What do I need to do to to get the nslcd service started before the Consul service

I need to change the consul service definition so that the nslcd service is started before consul so that applications running on the boxes don't have issues starting because consul is not yet up.
What's the best way to accomplish this?
Should I fork solarkennedy/puppet-consul module and change the consul.service.erb template or is there a config parameter i can pass to be added to the consul.service?
Thanks in advance.

There are lots of ways to change (override) systemd behavior. See if you can do it via local overrides:
https://askubuntu.com/a/659268

Thank you!


RST-6701 Fixing benefits value loading for reference

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/RST-6701

old branch


Update the Annotation --zoom-factor CSS variable when PDFPageView is used standalone (PR 13868 follow-up)

Without this patch, when using PDFPageView directly[1] this CSS variable won't be updated and consequently things won't work as intended.
This is purposely implemented such that when a PDFPageView-instance is part of a viewer, we don't repeatedly set the CSS variable for every single page.

[1] See e.g. the "pageviewer" example in the examples/components/ folder.

/botio-linux preview

Looks good!


Request: Shodan CLI Tool

Shodan CLI tool.
As easy as "easy_install click" "easy_install shodan" I think?
Ref: https://cli.shodan.io/
Thanks!

Done!  Using "pip install" only 6MB... thx!


Rename "Manage streams" -> "Stream settings".

Renames gear menu label, and updates code comments.
Renames "Streams settings" label in the keyboard shortcuts reference to "Stream settings" for consistency.
Updates help center docs to reflect renamed gear menu label.
Updates contributor docs to reflect renamed gear menu label.

Fixes #27754.
Screenshots and screen captures:

Gear menu

https://zulip.com/help/unsubscribe-from-a-stream

https://chat.zulip.org/#keyboard-shortcuts

https://zulip.com/help/keyboard-shortcuts

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability

Communicate decisions, questions, and potential concerns.

[x] Automated tests verify logic where appropriate.
[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alya This PR is ready for review.
@zulipbot add "help center review"

The screenshots look good to me. grep "anage streams"  | grep -v locale/ shows just changelog entries and translation guides.

Squashed and merged; thanks @drrosa!


macOS: peers inaccessible after long uptime

Unfortunately I haven't found the root cause yet, but occasionally innernet on macOS will get into a state where peers are no longer accessible, and innernet up doesn't fix the problem if you don't do innernet down before hand to reset all the states/tunnels.
The test innernet subnet is fd00:1337::/48.
I just hit this condition, so dumping some debug output here for later investigation.
tldr: at first glance, the routes and interfaces look normal, but I can't even ping my local wireguard IP via the loopback interface (lo0). Something is weird.
netstat -rn output:
Internet6:
Destination                             Gateway                         Flags           Netif Expire
default                                 fe80::%utun0                    UGcIg           utun0
default                                 fe80::%utun1                    UGcIg           utun1
default                                 fe80::%utun2                    UGcIg           utun2
default                                 fe80::%utun3                    UGcIg           utun3
default                                 fe80::%utun4                    UGcIg           utun4
::1                                     ::1                             UHL               lo0
fd00:1337::/48                          fe80::fa4d:89ff:fe85:2c87%utun5 Uc              utun5
fd00:1337:0:1:1::1                      link#26                         UHL               lo0

...truncated...

WireGuard information
$ ps aux | grep wireguard-go
root             25514   0.0  0.1 409219344  10144   ??  S    Tue08AM  14:41.65 wireguard-go utun

$ wireguard-go --version
wireguard-go v0.0.20230223

$ sudo wg
interface: utun5
  public key: <redacted>
  private key: (hidden)
  listening port: 60774

peer: <redacted>
  endpoint: <redacted>:51820
  allowed ips: fd00:1337::1/128
  latest handshake: 21 hours, 16 minutes, 31 seconds ago
  transfer: 16.56 GiB received, 838.20 MiB sent
  persistent keepalive: every 25 seconds

$ ifconfig utun5
utun5: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 1280
        inet6 fe80::fa4d:89ff:fe85:2c87%utun5 prefixlen 64 scopeid 0x1a
        inet6 fd00:1337:0:1:1::1 prefixlen 48
        nd6 options=201<PERFORMNUD,DAD>

$ route -n get -inet6 fd00:1337:0:1:1::1
   route to: fd00:1337:0:1:1::1
destination: fd00:1337:0:1:1::1
  interface: lo0
      flags: <UP,HOST,DONE,LLINFO,LOCAL>
 recvpipe  sendpipe  ssthresh  rtt,msec    rttvar  hopcount      mtu     expire
       0         0         0         0         0         0     16384         0

$ route -n get -inet6 fd00:1337::1
   route to: fd00:1337::1
destination: fd00:1337::1
  interface: utun5
      flags: <UP,HOST,DONE,WASCLONED,IFSCOPE,IFREF>
 recvpipe  sendpipe  ssthresh  rtt,msec    rttvar  hopcount      mtu     expire
       0         0         0         0         0         0      1280         0

I think @goodhoko might have had a similar issue. Though for him "long uptime" was just minutes, so not sure if the same cause.

My problem may be just me not using innernet correctly. IDK why (I think someone told me it's fine to) but I used to ctrl+c the innernet up command before it established connection with all peers and ran to completion. This leaves the network stopped (even if it was previously running).
It adds to this confusion that the network works fine while innernet up is trying to establish connection. I tend to jump between terminal tabs a lot and I often started using innernet before innernet up finished in another tab. Thinking it's all set up I jumped back and killed innernet up stopping the network again.
Unrelated to this issue, but maybe we could either make innernet up handle SIGINT more gracefully in the phase of establishing connections with peers, or just print something like Received ctrl+c. Stopping XXX network. so that it's clear what's happening. Shall I create an issue for that?

My problem may be just me not using innernet correctly. IDK why (I think someone told me it's fine to) but I used to ctrl+c the innernet up command before it established connection with all peers and ran to completion. This leaves the network stopped (even if it was previously running).

It definitely behaves differently for me: I can Ctrl+C it right after
strohel@thicky ~/work/portal $ innernet up
[*] fetching state for tonari from server...
[*]   peer dev-pablo-portal (9Wj1oUXCWW...) was modified.
[*]     Endpoint: <IP_ADDRESS>:35626 => <IP_ADDRESS>:49285
[*]   peer jen (gUwOAMVBQW...) was modified.
[*]     Endpoint: <IP_ADDRESS>:52495 => <IP_ADDRESS>:53063
[*]   peer taj (5iuERx/Z7v...) was modified.
[*]     Endpoint: <IP_ADDRESS>:58107 => <IP_ADDRESS>:32789

[*] updated interface tonari

[*] reporting 2 interface addresses as NAT traversal candidates

and the network stays up, most/all peers connected (just probably misses some NAT traversal oportunities, but that's a corner-case).
Linux, kernel-space wireguard here.

@goodhoko that happens to me too, I think like you said we just need to handle SIGINT more intelligently. I'll open a separate issue for that, because this is a whole different beast...


Deleted maki circle icons.

This PR implements #11481.
How to test
Check those icons are gone once you open the asset picker.

In my opinion, this ticket should not pass acceptance in staging, I'll check local, that's all.

Tested in local 👍