replace middle label with an svg

how can I replace a middle label in a leader line with an SVG which has a function as a button?!
I tried appendChild but it does not work out.
I use the leader line in an angular project and I put it in ngAfterViewInit.

Hi @separse, thank you for the comment.
Could you explain about the "it does not work out" you said? (e.g. any error?)
Or, this may help you: https://github.com/anseki/leader-line/issues/239

Hi @anseki, Thank you for answering. I read #239 and it was helpful but I did not achieve what was I need.

Now I can replace the middle label with what I want like a Rock, but I need these Rock sticks to the line not going around, and also because I use draggable lists and lines also move with the lists but this Rock does not move with the line.

Maybe it'll help that I show What I need. I need these relation lines which shows in below.

Sorry, my English is poor.
What is the "line not going around"?

My English is not good either :))
I mean I want the Rock to stick to the line and have no space between the line and the Rock like last photo which i sent to you.

What is different about the position you want and the position of middle label?
Did you see this? : https://github.com/anseki/leader-line/issues/239#issuecomment-852692825

yes, I see, when lines move, a gap occurred between a line and the middle label of it.

Do you mean that you want the image that is re-positioned automatically when the elements are moved?

For example: https://jsfiddle.net/reo6m1vc/

Exactly! tank you so much.
I just have another question for you. when I use multiple lines between items, like this picture, I could only click on the first line and the other line which is behind the environment of the first line is not clickable.

:smile:
Could you make new issue for another topic after closing this issue?

Sure, thank you so much again  :)


haiku build fix proposal.

Disabling non existing features and flags (close on exec). Fixing ControlLen type.

Looks good. Is there a rustup target for haiku? (to check that it builds).

no unfortunately

I've fixed the MSRV and macOS build failures on master. You just need to rebase.

This is finally released! in 0.3.0.

Hey ! I forgot about this one :)


Document Printer

Short description

Printer what prints documents using paper.

Added printer.
Added logo tag for paper.
Fixed controls for paper.

Why we need to add this

Good thing?
Media (Video/Screenshots)

Checks

[x] I do not require assistance to complete the PR.
[x] Before posting/requesting review of a PR, I have verified that the changes work.
[x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
[x] I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.

Changelog

:cl: Rinary

add: Added document printer.
add: Added nanotrasen logo tag([logo] in paper)

ADD SYNDIE LOGO AS WELL!
(not the printer of course, just in Textures_Starlight\Logo dir

ADD SYNDIE LOGO AS WELL!
(not the printer of course, just in Textures_Starlight\Logo dir)
well, you know, for possible future uses =)

Added as tag


Make nouns plural in keeping with 'world objects'

Sentence subject 'real world objects' is plural, so noun derivatives should be plural as well.

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

This sentence doesn't make sense either way - Shouldn't it be like this...
"Objects are useful for storing data in a structured way and can be used to represent real world objects like cars, hotels, or a computer."

That does read better, I agree.

@joaquinfox you should be able to make an edit to this to change that sentence to what I mentioned, then we can add it - and again, make sure you go over that checklist...
[x] My article does not contain shortened URLs or affiliate links.
^add x's to indicate you've gone over the list

Thanks @joaquinfox, LGTM


Remove Jenkins badge

Coverage remained the same at ?% when pulling 481f7a641b14979b7ecc498dac2533ff279d88eb on heuermh:remove-jenkins-badge into c2cce29a089cd03a7fb204c5e81e6daad5cf0f42 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-utils-prb/152/
Test PASSed.


Remove Twitter

Microsoft has removed the Twitter connector in Feb 2020.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


"Columns must be same length as key"

Describe the bug
[Bug]: raise ValueError("Columns must be same length as key")\nValueError: Columns must be same length as key\n", "source": "Columns must be same length as key", "details": null}
Steps to reproduce
No response
Expected Behavior
No response
GraphRAG Config Used
encoding_model: cl100k_base
skip_workflows: []
llm:
api_key: ollama
type: openai_chat # or azure_openai_chat
model: gemma2
model_supports_json: true # recommended if this is available for your model.
max_tokens: 4000
request_timeout: 180.0
api_base: https://localhost:11434/v1
api_version: 2024-02-15-preview
organization: <organization_id>
deployment_name: <azure_model_deployment_name>
tokens_per_minute: 150_000 # set a leaky bucket throttle
requests_per_minute: 10_000 # set a leaky bucket throttle
max_retries: 10
max_retry_wait: 10.0
sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
concurrent_requests: 25 # the number of parallel inflight requests that may be made
parallelization:
stagger: 0.3
num_threads: 50 # the number of threads to use for parallel processing
async_mode: threaded # or asyncio
embeddings:
parallelization: override the global parallelization settings for embeddings
async_mode: threaded # or asyncio
llm:
api_key: lm-studio
type: openai_embedding # or azure_openai_embedding
model: Publisher/Repository/nomic-embed-text-v1.5.Q5_K_M.gguf
api_base: http://localhost:1234/v1
# api_version: 2024-02-15-preview
# organization: <organization_id>
# deployment_name: <azure_model_deployment_name>
# tokens_per_minute: 150_000 # set a leaky bucket throttle
# requests_per_minute: 10_000 # set a leaky bucket throttle
# max_retries: 10
# max_retry_wait: 10.0
# sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
# concurrent_requests: 25 # the number of parallel inflight requests that may be made
# batch_size: 16 # the number of documents to send in a single request
# batch_max_tokens: 8191 # the maximum number of tokens to send in a single request
# target: required # or optional
chunks:
size: 300
overlap: 100
group_by_columns: [id] # by default, we don't allow chunks to cross documents
input:
type: file # or blob
file_type: text # or csv
base_dir: "input"
file_encoding: utf-8
file_pattern: ".*\.txt$"
cache:
type: file # or blob
base_dir: "cache"
connection_string: <azure_blob_storage_connection_string>
container_name: <azure_blob_storage_container_name>
storage:
type: file # or blob
base_dir: "output/${timestamp}/artifacts"
connection_string: <azure_blob_storage_connection_string>
container_name: <azure_blob_storage_container_name>
reporting:
type: file # or console, blob
base_dir: "output/${timestamp}/reports"
connection_string: <azure_blob_storage_connection_string>
container_name: <azure_blob_storage_container_name>
entity_extraction:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
prompt: "prompts/entity_extraction.txt"
entity_types: [organization,person,geo,event]
max_gleanings: 0
summarize_descriptions:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
prompt: "prompts/summarize_descriptions.txt"
max_length: 500
claim_extraction:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
enabled: true
prompt: "prompts/claim_extraction.txt"
description: "Any claims or facts that could be relevant to information discovery."
max_gleanings: 0
community_report:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
prompt: "prompts/community_report.txt"
max_length: 2000
max_input_length: 8000
cluster_graph:
max_cluster_size: 10
embed_graph:
enabled: false # if true, will generate node2vec embeddings for nodes
num_walks: 10
walk_length: 40
window_size: 2
iterations: 3
random_seed: 597832
umap:
enabled: false # if true, will generate UMAP embeddings for nodes
snapshots:
graphml: false
raw_entities: false
top_level_nodes: false
local_search:
text_unit_prop: 0.5
community_prop: 0.1
conversation_history_max_turns: 5
top_k_mapped_entities: 10
top_k_relationships: 10
max_tokens: 12000
global_search:
max_tokens: 12000
data_max_tokens: 12000
map_max_tokens: 1000
reduce_max_tokens: 2000
concurrency: 32
Logs and screenshots
No response
Additional Information

GraphRAG Version:
Operating System:
Python Version:
Related Issues:

this is a temp hacked solution for ollama
https://github.com/s106916/graphrag

I uses the same configuration as yours, but there is the same bug.
pip install graphrag
mkdir -p ./ragtest/input
curl https://www.gutenberg.org/cache/epub/24022/pg24022.txt > ./ragtest/input/book.txt
python -m graphrag.index --init --root ./ragtest
change .env and setting.yaml file, the same content as yours
python -m graphrag.index --root ./ragtest
raise ValueError("Columns must be same length as key")\nValueError: Columns must be same length as key\n"

sorry, can you give a try again. Please notes that settings.yaml has altered. use updated settings.yaml

This can be solved by adjusting the overlap attribute data of chunks

This can be solved by adjusting the overlap attribute data of chunks

how to adjust?

same problem

Using Xinference for models will solve this problem.

Using Xinference for models will solve this problem.

what is Xinference and how to use it?

Using Xinference for models will solve this problem.

what is Xinference and how to use it?

Refer to: https://inference.readthedocs.io/en/latest/.
Xinference is a large language model inference framework that supports LLM and embedding models, and can seamlessly call OpenAI interfaces.

Hi!
We are consolidating alternate model issues here: https://github.com/microsoft/graphrag/issues/657

This can be solved by adjusting the overlap attribute data of chunks

I have tried, and set overlap to 0, 10, 50...:
chunks:
size: 300  # 300
overlap: 0  # 100
group_by_columns: [id]
And it did not work......


Added snapshot ingestion and created a tmp filer that combines ingest/checkout

Current coverage is 63.94% (diff: 64.70%)

Merging #141 into master will increase coverage by 0.12%

@@             master       #141   diff @@
==========================================
  Files            60         60
  Lines          2590       2624    +34
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1653       1678    +25
- Misses          825        828     +3
- Partials        112        118     +6

Powered by Codecov. Last update f45186d...c4ede69


How about performance for flower dataset?

I am interested in flower dataset which is a small data set of a few thousand flower images spread across 5 labels: daisy, dandelion, roses, sunflowers, tulips. Could you write the python file for the flower dataset, besides cifar and svhn? I want to use your code to train it. Thanks
The script to download and separate into the train and validation folder is at https://github.com/tensorflow/models/blob/master/research/inception/inception/data/download_and_preprocess_flowers.sh

Hi John!
Flowers dataset was not added to the source code, because main reason of this repo to reproduce network from the paper and provide source code for it. And there are no any metrics in the paper based on this dataset. If you want to train network with any other dataset that is not related to the initial implementation you may fork the repo and make all required changes by yourself.


Sparkpost 2.0 Library

Hi,
I see you've switched to the latest Sparkpost library (2.0). I haven't spent much on investigating what's new but I did notice for instance APIResponseException class is missing which should cause this plugin to break.
Just a heads up.
Matjaz

Hi @matjaz-elumina,
no, I still use sparkpost lib v1, but I'm planning to switch to v2 soon.
For now while we use v1 all work as intended.


Logging In With WebView

General Question
Read the Notes and fill out the form.
Switch to Preview for reading.
Notes
Your issue will be closed if you violate any rule below.

You need to include a meaningful descriptions and e.g. a screenshot.
You do not include screenshots of your code.
Read the Docs.
Capturing endpoints and similar can be found here
(read it if you are going to ask about it).
You can delete this section after reading it.

Form
Put an [x] if you meet the condition, else leave [ ].

[ x ] I've searched the Issues
[ x ] I've read the basic concepts
[  ] I'm using the latest version

Question
A specific question, so it's understandable to anyone.
You may add pictures.
Hello, I finally managed to integrate this API into my react-native application, but can I continue my operations in this API by logging into Instagram with WebView ?
I don't know which values i have to pass to API for loading that WebView session

This is not an official API, you don't have some authentication page.
Users would have to log in with their username and password and you'd have to save it.


add docs for message hub

@markusthoemmes thanks for the review.
Please take a look at dc556d9d121a24ba436da95c8694bc6fdc88eacd

@bjustin-ibm I made updates based on your feedback here 9ccff1e498968b5bdd5e55a4e2c86aa1e08fc12c

Rebased/squashed/merged as 15a336e3a4343a8a37bbdba8f6c092617ea6d0d1


User can't create domain

Hi everybody,
I've set up PowerDNS-Admin and enabled the option user can create domain (allow_user_create_domain), but if I login with an test account (User Privileges) it says:
400 Oops! Bad request
Please use a valid Account
You may return to the dashboard.
Is it set up on purpose so that only the operator can change domains? That would be a bit bad because the operator can also read other domains.
BR
Phil

Can you share the server logs?

Hi @RGanor Sure :) 👍
Running with the latest docker image from the Docker Hub.
Logs with Debug enabled:
[2022-03-08 23:32:31 +0000] [11] [INFO] User "test" logged in successfully. Authentication request from IP-goes-here
[2022-03-08 23:32:31,516] [user.py:212] INFO - User "test" logged in successfully. Authentication request from IP-goes-here
[2022-03-08 23:32:31 +0000] [11] [INFO] User test authenticated successfully via LOCAL from IP-goes-here
[2022-03-08 23:32:31,519] [index.py:543] INFO - User test authenticated successfully via LOCAL from IP-goes-here
[2022-03-08 23:32:31 +0000] [11] [DEBUG] GET /login
[2022-03-08 23:32:31 +0000] [13] [DEBUG] GET /dashboard/
[2022-03-08 23:32:31 +0000] [13] [INFO] Updating domains in background...
[2022-03-08 23:32:31,611] [dashboard.py:152] INFO - Updating domains in background...
[2022-03-08 23:32:31 +0000] [13] [DEBUG] GET /static/assets/css/style.css
[2022-03-08 23:32:31 +0000] [10] [DEBUG] GET /static/generated/main.css
[2022-03-08 23:32:31 +0000] [12] [DEBUG] GET /dashboard/domains-custom/reverse
[2022-03-08 23:32:31 +0000] [13] [DEBUG] GET /dashboard/domains-custom/ip6arpa
[2022-03-08 23:32:31 +0000] [10] [DEBUG] GET /dashboard/domains-custom/inaddrarpa
[2022-03-08 23:32:32 +0000] [12] [DEBUG] GET /domain/add
[2022-03-08 23:32:32 +0000] [12] [DEBUG] GET /static/assets/css/style.css
[2022-03-08 23:32:32 +0000] [11] [DEBUG] GET /static/generated/main.css
[2022-03-08 23:32:34 +0000] [11] [DEBUG] POST /domain/add

Config under Settings -> Basic
allow_user_create_domain | ON | Toggle
allow_user_remove_domain | ON | Toggle
allow_user_view_history | OFF | Toggle
auto_ptr | OFF | Toggle
bg_domain_updates | ON | Toggle
custom_css |   | Save
default_domain_table_size |   | Save
default_record_table_size |   | Save
delete_sso_accounts | OFF | Toggle
dnssec_admins_only | ON | Toggle
enable_api_rr_history | ON | Toggle
fullscreen_layout | ON | Toggle
login_ldap_first | ON | Toggle
maintenance | OFF | Toggle
max_history_records |   | Save
otp_field_enabled | ON | Toggle
otp_force | OFF | Toggle
pdns_api_timeout |   | Save
pretty_ipv6_ptr | OFF | Toggle
record_helper | ON | Toggle
record_quick_edit | ON | Toggle
session_timeout |   | Save
site_name |   | Save
ttl_options |   | Save
verify_ssl_connections | ON | Toggle
verify_user_email | OFF | Toggle
warn_session_timeout | ON

The problem that an normal User sees:

Maybe there is lying the Problem?
https://github.com/PowerDNS-Admin/PowerDNS-Admin/blob/0da9b2185ef418261522dc0013034a8546dc2fd1/powerdnsadmin/routes/domain.py#L367-L375

@sniffingsugar
You are right, the reason you cannot create a Domain as a User is because you must associate it with an Account.
This is a security feature that was added in PR #970.
You may add your test user to an Account, and then they will be able to create a Domain.

@vmarkop
Just checked, I've created an Account an added the User to it. It don't work.


Adds cfscrape to bypass Cloudflare's I'm under attack protection

I've noticed that the requests were broken and after further inspection I found that the culprit was Cloudflare "I'm under attack' protection.
Using cfscrape fixes the issue.

why you didnt pull it on the master branch?? taht resolve all problem for a lot of person!!!! thanks

I'm not sure of what you meant by "pull it on the master branch"  :)
I've forked the project, updated the file accordingly and created a pull request to merge this to master which the owner/team needs to approve.

I don't know what you are talking about !
Hacked-emails      -> Stopped their api
HaveIBeenPwned -> They have rate limiting that makes it must be a request every 1.5 sec
I solves both poblems already weeks ago in the new version, just wait for the new version it will become a framework not just a toolkit :smile:
It's my work and other reasons what makes me very slow on working on it and it's a huge idea (wrote 1500 lines till now only in the core and five modules)

I was talking about this:
res = req.json()
Instead of returning a valid json it was getting an HTML page from cloudflare with the "I'm under attack" protection which obviously was causing an exception. The PR solves this.
But like you said, if the hacked-emails was shut down then I think you can ignore this PR :)


[bug] Move the window between multiple screens, the window size is reset

Describe the bug
The window size is configured in the tauri.conf.json file, and then modified by appWindow.setSize(...).
When dragging a window to another screen, the size of the window becomes the value in tauri.conf.json.
Reproduction
No response
Expected behavior
No response
Platform and versions
Environment
  › OS: Mac OS 12.4.0 X64
  › Node.js: 18.3.0
  › npm: 8.11.0
  › pnpm: Not installed!
  › yarn: 1.22.19
  › rustup: 1.24.3
  › rustc: 1.64.0-nightly
  › cargo: 1.64.0-nightly
  › Rust toolchain: nightly-aarch64-apple-darwin

Packages
WARNING: no lock files found, defaulting to npm
  › @tauri-apps/cli [NPM]: 1.1.0 (outdated, latest: 1.1.1)
  › @tauri-apps/api [NPM]: Not installed!
  › tauri [RUST]: 1.1.0,
  › tauri-build [RUST]: 1.1.0,
  › tao [RUST]: 0.14.0,
  › wry [RUST]: 0.21.1,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../src
  › devPath: ../src

App directory structure
  ├─ node_modules
  ├─ src-tauri
  ├─ .vscode
  └─ src

Stack trace
No response
Additional context
No response

duplicate of #5229


fix: pydocstyle kwargs #232

Fixes #232
Use named params in check_source call to deal with upstream changed function signature.
Updated mypy config to deal with the changed default behavior for implicit Optional and new(ish) annotation-unchecked code.
Existing tox/tests failed due to upstream change, now passing.

any chance this could be pushed through? The disconnect with pydocstyle is causing some sticky problems!


Recompile

Hey, nice work on this. I want some more features in it where I can plot multiple vehicle paths on the map with different colors and I don't want to see the temperature value. So can you help me with how it can be done?

@ajayavgarde what you're asking for cannot be done with the current code. This is just an example. You must extend the functionality of the OfflineMaps.Controls.dll .NET control and further pass the necessary data from the LabVIEW.
Do you have experience with C#/WinForms and LabVIEW?

@ajayavgarde p.s. also feel free to give this repository a star if you like it

no, I haven't worked on C#, but I have worked on LabVIEW.So it will be bit difficult for me work on it


Add a growvols role and playbook

When the target host has the LVM based whole disk layout, running growvols will grow each volume by the amount specified in the growvols_args variable.
The intent is that this role is invoked by a playbook after deploy-edpm-facts.yml and before deploy-edpm-pre-network.yml. If the target host has the growvols script installed, it will be run, otherwise the role is a noop.

/retest

Hey @steveb, ci test is failing with this error:

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
  Error merging github.com/openstack-k8s-operators/edpm-ansible for 74,8e6b5deeca3873697ab0dcd4931461820fda0a24```

Have you tried to rebase your patch?

I've pushed a rebase

/lgtm


[Egg Request]: Emby Media Server

Does this expand an already existing service
No
Link to a game or software
https://emby.media/
Links for the download
https://emby.media/download.html
Links for the install docs
https://emby.media/support/articles/Installation.html

Yea no. Read the main readme.


enable rust.unnameable-types = "warn" lint

Describe the feature
TODO

add new lint: https://github.com/paradigmxyz/reth/blob/bb8ff671828b2ae9f2ab71edce6e1a1f01c2b649/Cargo.toml#L155-L155
fix warnings either by making types pub(crate) or exporting them (these fixes can be submitted as separate prs to make them easier to review)

Additional context
No response

I can take this one.

@mattsse this is a larger issue and wouldn't be feasible to do it in a single issue. Should we do it crate wise and then after all the crates we can add the lint to the root Cargo.toml?

Should we do it crate wise

that sounds great!


⚠ AGEG website (redirect) has degraded performance

In c33e0e4, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2539 ms

Resolved: AGEG website (redirect) performance has improved in 1c0d85a.


Add arm64 (Ubuntu 20.10) as supported platform

I'm running homebridge-rpi on Ubuntu 20.10 (64 bit) and the rpi command failed, so this is a simple fix.
Let me know if you'd like me to update the README with instructions for getting things going on Ubuntu.

Homebridge RPi and the api command work on any type of system; only the host you're connecting to needs to be a Raspberry Pi.  Do you have vcgencmd and pigpiod on Ubuntu?

I see that Homebridge RPi (and the rpi command) are meant to work on any type of system where pigpio is available but that (presumably - I haven't checked) isn't on Intel or AMD devices with arch x86_64 or amd64 hence the reason for the check. However the hardcoded check for arm architecture caused the rpi info command to fail when run on 64 bit Ubuntu, where the architecture is arm64. I simply added that to the check.
Yes, I'm running a single Homebridge instance on an RPi 4B running 64-bit Ubuntu 20.10, with multiple RPi ZeroW's to control and measure. Although vcgencmd and pigpiod do run on the 4B, their installation isn't well documented. If you think it's worth adding to the README then I can do that and update this PR. Let me know.

I see that Homebridge RPi (and the rpi command) are meant to work on any type of system where pigpio is available but that (presumably - I haven't checked) isn't on Intel or AMD devices with arch x86_64 or amd64 hence the reason for the check.

Sorry I don't follow.  The check is for Homebridge RPi and rpi to monitor and control to the localhost, not to run on the localhost.  Monitoring and controlling only works if the localhost is indeed a Raspberry Pi.  Clearly anything running on x86_64 or amd64 isn't, as the Pi has an ARM processor.  I appreciate that a Pi can run other OSs, and happy to support monitoring and controlling those, but those OSs need to provide vcgencmd and pigpiod.

Yes, I'm running a single Homebridge instance on an RPi 4B running 64-bit Ubuntu 20.10, with multiple RPi ZeroW's to control and measure. Although vcgencmd and pigpiod do run on the 4B, their installation isn't well documented. If you think it's worth adding to the README then I can do that and update this PR. Let me know.

But are you also controlling and measuring the Pi4 running Ubuntu through Homebridge RPi?

Yes, I'm using the rpi command on localhost which is an RPi4B running 64-bit Ubuntu. Both pigpiod and vcgencmd are installed and running correctly. However executing rpi info on the localhost fails as RPiInfo.js checks for arch arm, and the arch changes to arm64 when running 64-bit Ubuntu.
I hope that's clearer!


showQuickPick: canSelectMany has no effect

Refs: #48471

Have an extension with the following api call

vscode.window.showQuickPick(['first', 'second', 'third', 'fourth', 'fifth'], {
            canSelectMany: true
        }).then(result => vscode.window.showInformationMessage(result.toString()));

I can not select multiple items when the quick pick is shown

I am doing something wrong here or is this a bug?

Well canSelectMany is what I get proposed in the suggestions.
@chrmarti Are we sure we are not breaking anything by renaming api options?  Or was the canSelectMany never surfaced to users?
canPickMany works just fine

My typo, sorry. canPickMany is correct and we only ever shipped with that.


Console: Error fetching metadata when sst start boots up

Steps to reproduce:

Open up SST Console, you should see waiting for CLI...
Run sst start
SST Console show error Error fetching metadata

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


[system-probe] re-format tracer-ebpf.c

What does this PR do?
I'm doing this in preparation of a larger eBPF PR which I want to run
the formatter on, but don't want these changes pulled in.
This was automatically generated by running inv -e sytem-probe.cfmt
Motivation
Additional Notes

@p-lambert I'm not so sure. Different versions of clang-format result in different code, so anyone building the system-probe could potentially change the C file even if they didn't touch the C code.


Redo shortcut in the Editor is not working in master

Problem Description
The Redo shortcut, which is set to default Spyder shortcut Ctrl+Shift+Z in the master branch is not working in the Editor, but is everywhere else in the application (IPython console, Find in Files, etc...)
Note that everything is working fine in the 3.x branch, so that is probably why we haven't receive any bug reports about that yet.
The goal of this issue is to document what I'm doing in order to pinpoint and understand the issue before trying to fix it.
Versions

Spyder version: Spyder 4.0.0.dev0
Python version: Python 3.6.5 64bits
Qt version: Qt 5.9.3
PyQt version: PyQt5 5.9.2
Operating System name/version: Windows  10

Dependencies

pyflakes >=0.6.0  :  1.6.0 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pygments >=2.0    :  2.2.0 (OK)
sphinx >=0.6.6    :  1.7.1 (OK)
rope >=0.9.4      :  0.10.7 (OK)
jedi >=0.11.0     :  0.12.1 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
pandas >=0.13.1   :  0.22.0 (OK)
numpy >=1.7       :  1.13.0 (OK)
sympy >=0.7.3     :  1.1.1 (OK)
cython >=0.21     :  0.27.3 (OK)
qtconsole >=4.2.0 :  4.4.0.dev (OK)
IPython >=4.0     :  6.2.1 (OK)
matplotlib >=2.0.0:  2.2.0 (OK)
pylint >=0.25     :  1.8.3 (OK)

Redo shortcut is is working in v4.0.0Beta1.

Could you test before and after split-plugins was merged?

@andfoy @ccordoba12
This Issue was introduced in https://github.com/spyder-ide/spyder/commit/5abd2a27e1c30b9ab4656e5aa290e99ac15b5ccb
More specifically, this line is the culprit:
https://github.com/spyder-ide/spyder/commit/5abd2a27e1c30b9ab4656e5aa290e99ac15b5ccb#diff-b19a1c3b49c9057f7bf2edae2a53747dR2865

I've done some digging and this clock code is very shady: https://github.com/spyder-ide/spyder/blob/master/spyder/plugins/editor/widgets/codeeditor.py#L2870
        for qname, name in checks:
            seq = getattr(QKeySequence, qname)
            sc = get_shortcut('editor', name)
            default = QKeySequence(seq).toString()
            # XXX - Using debug_print, it can be seen that event and seq
            # will never be equal, so this code is never executed.
            # Need to find out the intended purpose and if it should be
            # retained.
            if event == seq and sc != default:
                # if we have overridden it, call our action
                for shortcut in self.shortcuts:
                    qsc, name, keystr = shortcut.data
                    if keystr == default:
                        qsc.activated.emit()
                        event.ignore()
                        return

                # otherwise, pass it on to parent
                event.ignore()
                return

I think this should be rework. When I do Ctrl+Shift+Z I end up at # otherwise, pass it on to parent, but clearly, and I've checked, the event is not passed to the parent.

According to the doc (http://doc.qt.io/qt-5/qkeysequence.html), the standard shortcuts for Redo are:

If my understanding of the code shown in https://github.com/spyder-ide/spyder/issues/7743#issuecomment-415144753 is correct, for any version of Spyder :

Setting the Delete line shortcut to Ctrl+C and thenpressing Ctrl+C in the editor should not work 👎
Setting the Go to line shortcut to Ctrl+C and thenpressing Ctrl+C in the editor should not work 👎

In both cases, we enter the if event == seq and sc != default: code block because Ctrl+C is the default OS builtin key sequence for Copy and because the shortcut key sequence for the copy action in Spyder was set to something other than the default key sequence for Copy. So the XXX comment for this code block is wrong and should be removed.
In both cases though, we end up at # otherwise, pass it on to parent. On my Windows 10 laptop with PyQt5.9.2 and Qt5.9.3, the event is not handled as expected by the parent even if we ignore it and so, both cases do not work.
One of the problem is that the line if keystr == default: is wrong. This condition doesn't compare the same things at all. keystr  corresponds to the name given to the shortcut in Spyder and default corresponds to the OS default sequence of keystring used to activate the Copy shortcut. This line should be replaced by qsc.key().toString() == default:. After changing this :

Setting the Delete line shortcut to Ctrl+C and thenpressing Ctrl+C in the editor should work 👍
Setting the Go to line shortcut to Ctrl+C and thenpressing Ctrl+C in the editor should not work 👎

So, the Delete line shortcut is now handled correctly and the action is called correctly with qsc.activated.emit(). For the  Go to line  shortcut though, we still end up at # otherwise, pass it on to parent. This is because this shortcut is not defined in the codeeditor class, so there is no way we can manually activate it from the editor. So we pass the event to the parent and pray for the best. On my Windows 10 laptop, this doesn't work.
@ccordoba12 could you check please what happens in Linux when you set the shortcut Delete line and Go to line to Ctrl+C?

But, why do we even need to handle the Qt Builtin key sequences in the first place? Shouldn't these be handled by the QShortcut we are creating for each shortcut in the CodeEditor.create_shortcuts method? We are even creating QShorcut for the copy, cut, paste, undo, redo, and select all shortcut.
That would be the best... but in Windows (maybe it is the case also for Linux, I need to test it) it seems that if a shortcut is assigned a builtin qt keybindings for editing (see http://doc.qt.io/qt-5/qplaintextedit.html#editing-key-bindings for the list of keybindings), the shortcut is not activated when doing the appropriate key sequence on the keyboard. We end up in the keyPressEvent and we need to activate the shortcut manually if we want it to work.
When setting a QShorcut to a key sequence that is not a builtin keybindings, doing the appropriate key sequence is then handled directly by the shortcut and we do not even enter the keyPressEvent, so there is nothing to handle.
For example, if the Copy shortcut is set to Ctrl+C, the shortcut we define for Copy is not activated and we need to handle it in the keyPressEvent method override. If we set the Copy shortcut to Ctrl+Shift+Y instead, which is not in the list of builtin keybindings, and press Ctrl+Shift+Y, the event is then handled by the shortcut and we never enter the keyPressEvent of the codeeditor.

Now, the Redo shortcut is a more complicated case in because it is associated with 3 different default keybindings in Windows (see https://github.com/spyder-ide/spyder/issues/7743#issuecomment-415162335), while there is only one in Linux. This is the reason why it fails currently in the master branch on Windows when this shortcut is set to Ctrl+Shift+Z, while it works in Linux.
In Linux, if the Redo shortcut is set to Ctrl+Shift+Z and we press the Ctrl+Shift + Z keys, the event == seq  will be True because the key sequence of the event matches the default keybinding for the Redo shortcut on Linux, and the sc != default will be False because the key sequence set for the Redo shortcut that is set in Spyder is the same as the OS default one. Therefore, if event == seq and sc != default: will be False, and the event will eventually be handled by TextEditBaseWidget.keyPressEvent(self, event).
In Windows we have a problem because there is 3 default keybindings associated with the Redo shortcut. So, if the Redo shortcut is set to Ctrl+Shift+Z in Spyder and we press the Ctrl+Shift + Z keys, the event == seq  will be True because the key sequence of the event matches ONE of the default keybinding for the Redo shortcut on Windows. The problem occurs when evaluating sc != default. QKeySequence(QKeySequence.Redo).toString() return the keystring related to the first default key sequence listed for the Redo shortcut in Windows, so that default equals to Ctrl+Y. So sc != default will be evaluated to be True, and therefore the if event == seq and sc != default: will also be True and we will start looping through the shortcut defined in the codeeditor to find one whose key sequence matches that of default. The problem is that, the Redo shortcut will not match in this case because its key sequence is set to Ctrl+Shift+Z while default has a value of Ctrl+Y. So we end up at # otherwise, pass it on to parent and nothing happens...
If my understanding of the code is correct, in the latest version of the master branch:

The Redo shortcut should not work 👎 in Windows with Ctrl+Y, Ctrl+Shift+Z and Alt+Shift+Backspace if it is set to Ctrl+Shift+Z

The Redo shortcut should work 👍 in Windows with Ctrl+Y, Ctrl+Shift+Z and Alt+Shift+Backspace if it is set to Ctrl+Y

In the later case, it works because sc != default will be evaluated to false and the event is handled further down the keyPressEvent method in TextEditBaseWidget.keyPressEvent(self, event).
Any other shortcut set to Ctrl+Shift+Z or Alt+Shift+Backspace will not work and a Redo action will be issued instead.
So, setting the Redo shortcut to Ctrl+Y in Spyder is a valid workaround for this issue until this is fixed. But the way builtin OS shortcuts are handled in Spyder is fragile and should be improved. More discussion about that will follow.

We are even creating QShorcut for the copy, cut, paste, undo, redo, and select all shortcut.

That was done by Steve to create an Emacs shortcut set in the future.

So, setting the Redo shortcut to Ctrl+Y in Spyder is a valid workaround for this issue until this is fixed

I don't know about that because it changes the default behavior.

But the way builtin OS shortcuts are handled in Spyder is fragile and should be improved.

Ok, thanks!

We are even creating QShorcut for the copy, cut, paste, undo, redo, and select all shortcut.

That was done by Steve to create an Emacs shortcut set in the future.

This is Ok and necessary, otherwise setting the Copy shortcut to something other than a OS default keysequence, like Ctrl+Shift+Y would do nothing.

So, setting the Redo shortcut to Ctrl+Y in Spyder is a valid workaround for this issue until this is fixed

I don't know about that because it changes the default behavior.

I meant that it is a valid workaround for Windows users until the issue is resolved, I am not suggesting we actually change the default in Spyder.
Moreover, doing this in Windows doesn't change the default behavior. In Windows, when the keybinding for the Redo shortcut is set to Ctrl+Y in the keyboard shortcut preferences of Spyder, theRedo shortcut will work with Ctrl+Shift+Z, Ctrl+Y, or Alt+Shift+Backspace like it should by default in Windows. It is not the case though if it is set to Ctrl+Shift+Z due to the problems described in the comments above.

I meant that it is a valid workaround for Windows users until the issue is resolved, I am not suggesting we actually change the default in Spyder.

Ok, nice. Please go ahead with it then.


Caching and domains

Tatin creates a sub-folder in its cache folder for every domain it comes across. It constructs the name of the folder from the domain name, replacing dots by del characters (∆), but it does not add the port number.
That's is okay for port 80 and 443 but not otherwise.

Not quite: it would only go wrong for principal packages (but not dependencies) in case there are more than one server on the same name with one having a port number that is neither 0, 80, 443.
That will most likely not ever happen in real life.

Fixed in 0.65.1


I wan't to put this shader but it's crashing

Describe your problem here.
so i want to put this shader to my mod: https://www.shadertoy.com/view/3tfcD8
and it crashing like an incompatible shader. But i see a mod using it so idk pls help aaaaa ( i will not copy paste the code of that mod)
Are you modding a build from source or with Lua?
Source and/or Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

you have port the shader for it to work on haxeflixel
stuff like #pragma header at very top and change some variable names

you have port the shader for it to work on haxeflixel stuff like #pragma header at very top and change some variable names

there's some where do i lear to optimize shaders like that?

idk

You don't just throw things in flixel and expect it to work perfectly, sorry man but this issue is not specific to Psych Engine

You don't just throw things in flixel and expect it to work perfectly, sorry man but this issue is not specific to Psych Engine

i know


Reloadium exit instantly and Variable inspections are not shown.

Describe the bug

When I click orange debug button, reloadium process exits instantly.
In the official Futures Page, it says Reloadium shows variable inspection on the right of assignment. But nothing is shown after I cilck run button or debug button.

To Reproduce
Steps to reproduce the behavior:

Install Reloadium from the PyCharm plugin store.
Write your code.
Click orange debug button or run button.
step4 opens console and it says process is exited.

Expected behavior
Show variable inspection on the right of variable.
Screenshots

In the console
connected to pydev debugger (build 222.4345.23)
■■■■■■■■■■■■■■■
Reloadium 0.9.4
■■■■■■■■■■■■■■■
If you like this project consider becoming a sponsor or giving a star at https://github.com/reloadware/reloadium
(5 + 9) = 14

process exited with exit code 0

Desktop (please complete the following information):

OS: Windows
OS version: 11
Reloadium package version: 0.9.4
PyCharm plugin version: 0.8.8
Editor: PyCharm 2022.2.3
Run mode: Run and Debug

Hi @nagataaaas
You forgot to add a breakpoint

Oh, I'm really sorry.
Now it works properly!


Merge branch-PPP-Qiaoran with Master

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (e1a1b8e) compared to base (0be3d6e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Unfortunately, I think I didn't review your PPP properly as it does not seem to be showing (same issue as #24). Feel free to see my comments there.


Shadow DOM: Stop callbacks from inside an open shadow tree

This pull request:

fixes #245.
supersedes #254.
adds tests for open and closed shadow trees.
adds a sixth options parameter to KeyEvent.simulate. This was required to re-target the event target with closed shadow trees. The related code contains further explanation.

Important note: The tests pass when opening tests/mousetrap.html in a browser, but not when running npm test. This is due to the test environment not understanding Element.attachShadow; hence, it is throwing on the lines with the call to attachShadow in the test file. I’m not quite sure how to make these tests work with mocha.

@ccampbell Are you interested in continueing with this or should it just be closed?

Hi @kleinfreund,
I am not opposed to this change. The problem is more that I don’t have time to actively maintain this project.
The truth is I don’t have a lot of familiarity with Shadow DOM, and I don’t like the idea of breaking the tests.
If you can figure out a way to get the tests to pass then I’d be happy to merge this.


Error: Module does not export a method named default

Hi there! I want to use this package, but I get the following error, please help.
Thnx
Uncaught SyntaxError: The requested module '/_nuxt/node_modules/nuxt-unity-webgl/node_modules/eventemitter3/index.js?v=9a9f0ff9' does not provide an export named 'default' (at index.mjs?v=9a9f0ff9:1:8)

Thank you - I tried with the latest version and it seems to work!
(I am using DOTS in my unity project - but it does not work on webGL build :( do you know anything about this? I guess it does not work)
thank you!


Preliminary PR before opening to HL

@PeterStrob since we don't have tests running on this fork, can you provide a passing test report (run locally) for this change?

ACA-py tests are passing for me!

Looks good to me

Didn't realize that I could review on a draft PR

@PeterStrob please go ahead and open this PR to HL :slightly_smiling_face:


Add test that proves order is preserved

Closes https://github.com/pydantic/pydantic/issues/1234

Selected Reviewer: @adriangb

Great.


gh-622: Documentation refactor

Documentation refactor

@carne-vore I've added you as the reviewer for the tech-documentation, I'll let you know as soon as I'm done.

OK - waiting on your signal


prep 0.8.0 release

Coverage remained the same at 97.806% when pulling 18ab7ad6c3e9c050af585a1f32e89f4f15fb7a33 on 0.8.0-release into 684688898b47c5a4c2a725da3bc71a65a1eb40c2 on main.


Assembly for Vision Pro

I can't run tests for Vision Pro because I can't modify the Assembly

Is there any update on VisionPro?

@Polotas Just invited you to the next alpha. You'll need to manually copy the ai.natml.videokit folder in Packages and place it in your project's Packages folder. You should be good to use visionOS now.

Closing this ahead of the VideoKit 0.0.18 update.


[stable/prometheus-operator] the chart to download is incomplete

Is this a request for help?:
Well, it's more update the helm repo with the files present in Git
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug Report, I guess :)

Version of Helm and Kubernetes:
helm v2.11.0
k8s v1.13.2
Which chart:
stable/prometheus-operator
What happened:
the chart available for use doesn't not contain endpoints.yaml for 2 exporters

prometheus-operator/templates/exporters/kube-scheduler/
prometheus-operator/templates/exporters/kube-controller-manager/

What you expected to happen:
to have those manifests so as to have my endpoints working correctly :)
How to reproduce it (as minimally and precisely as possible):
edit the values.yaml with those kind of lines :
kubeControllerManager:
  endpoints:
    - <IP_ADDRESS>
  service:
    port: 10252
    targetPort: 10252

kubeEtcd:
  endpoints:
    - <IP_ADDRESS>
  service:
    port: 2379
    targetPort: 2379

kubeScheduler:
  enabled: true
  endpoints:
    - <IP_ADDRESS>
  service:
    port: 10251
    targetPort: 10251

And only the Etcd will have its endpoint works correctly
Anything else we need to know:
doing a great job, thx guys :)

Could you please provide a PR if there is a way to fix it for everyone?

my bad, the latest version has the files :+1:


swarm not functioning when one of two swarm managers is down

Output of docker version:
root@c910f04x19k05:~# docker version
Client:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd-unsupported
 Built:        Fri Jun 17 21:21:56 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd-unsupported
 Built:        Fri Jun 17 21:21:56 2016
 OS/Arch:      linux/amd64
root@c910f04x19k05:~#

Output of docker info:
Containers: 1
 Running: 1
 Paused: 0
 Stopped: 0
Images: 2
Server Version: 1.12.0-rc2
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 22
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: overlay bridge null host
Swarm: active
 NodeID: eli8zcc9qkvpyymwnkbmhcphp
 IsManager: Yes
 Managers: 2
 Nodes: 4
 CACertHash: sha256:424c3732f099885c59d66c9a498e4d8a99ace8e9186d561117a58f807b46b31d
Runtimes: default
Default Runtime: default
Security Options: apparmor seccomp
Kernel Version: 4.4.0-22-generic
Operating System: Ubuntu 16.04 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 3.859 GiB
Name: c910f04x19k05
ID: TJGZ:GRAN:BCTW:5WN7:AA44:EDV4:RS4M:2RV6:RXU7:XOHR:76XK:KETQ
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Steps to reproduce the issue:

Setup a docker swarm with 2 managers
Deploy services in the swarm
Shutdown one of the manager
You could not manipulate the service, node or swarm

Describe the results you received:
root@c910f04x19k05:~# docker node ls
ID                           NAME           MEMBERSHIP  STATUS  AVAILABILITY  MANAGER STATUS
7ciwf38osn5u05cyktcsqi3ez    c910f04x19k06  Accepted    Ready   Active
7x1cdxcttssryr5r7ock1zx7c    c910f04x19k07  Accepted    Ready   Active
eke7jq96u04yqxdt8z4vyrm9q    c910f04x19k04  Accepted    Ready   Active        Unreachable
eli8zcc9qkvpyymwnkbmhcphp *  c910f04x19k05  Accepted    Ready   Active        Leader
root@c910f04x19k05:~# docker node rm c910f04x19k04 =========> Could not delete the failed manager
Error response from daemon: rpc error: code = 9 desc = node eke7jq96u04yqxdt8z4vyrm9q is a cluster manager and is part of the quorum. It must be demoted to worker before removal
root@c910f04x19k05:~# docker node demote c910f04x19k04
Error response from daemon: rpc error: code = 4 desc = context deadline exceeded
root@c910f04x19k05:~# docker node rm c910f04x19k04
Error response from daemon: rpc error: code = 9 desc = node eke7jq96u04yqxdt8z4vyrm9q is a cluster manager and is part of the quorum. It must be demoted to worker before removal
root@c910f04x19k05:~#

root@c910f04x19k05:~# docker service tasks sshd
ID                         NAME    SERVICE  IMAGE                             LAST STATE          DESIRED STATE  NODE
5ggkrqm5ya0lajzsqup4p8hsj  sshd.1  sshd     liguangcheng/ubuntu-16.04-x86_64  Running 18 minutes  Running        c910f04x19k04
dziaej6obfxwchgld0ejfu5n4  sshd.2  sshd     liguangcheng/ubuntu-16.04-x86_64  Running 22 minutes  Running        c910f04x19k07
dokmapfyo9erx4sncfkkfxe7l  sshd.3  sshd     liguangcheng/ubuntu-16.04-x86_64  Running 22 minutes  Running        c910f04x19k05
0a7c7brujzdedljv4dtdf4jt6  sshd.4  sshd     liguangcheng/ubuntu-16.04-x86_64  Running 22 minutes  Running        c910f04x19k06
4dkb78sool9lncm8dd8ivyazw  sshd.5  sshd     liguangcheng/ubuntu-16.04-x86_64  Running 22 minutes  Running        c910f04x19k04
root@c910f04x19k05:~# docker service rm sshd =========> Could not remove the service
Error response from daemon: rpc error: code = 4 desc = context deadline exceeded
root@c910f04x19k05:~# docker service create --replicas 5 --publish 22 --name sshd-1 liguangcheng/ubuntu-16.04-x86_64 /usr/sbin/sshd -D ===========> Could not launch new services
Error response from daemon: rpc error: code = 4 desc = context deadline exceeded
root@c910f04x19k05:~#

Describe the results you expected:
I should be able to delete the failed manager from the swarm, and be able to manipulate the services in the swarm.
Additional information you deem important (e.g. issue happens only occasionally):

Could this be a duplicate of https://github.com/docker/docker/issues/24329?

Could be, #24329 reads "The only solution is to remove all members from the swarm then redo everything", but the problem for me is that I could not remove the failed manager, so I could not destroy the swarm and redo everything. If there is any force method to destroy the swarm and start from the beginning, it will be fine for me.

I had this same issue.  destroyed my swarm by doing the following:

shut down docker
rm -fr /var/lib/docker/*
delete and recreate thin storage (If you're using it)
start docker

Yes, you should not setup with only 2 managers.
If either manager goes down you will lose quorum and not be able to recover.
If you have a cluster with 1 manager, and the manager goes down the cluster goes down, but you can bring it back up by fixing the node.
If you have a cluster with 2 managers, you cannot tolerate any failure.
If you have a cluster with 3 managers, you can tolerate a single manager failure and it will continue working just fine.
If you need some level of fault tolerance, then you need at least 3 managers.
Basically you can tolerate up to (N/2)+1 failures from 3 nodes and up.
An even number is going to cause problems.
It would be better to have N-1 managers (where N is the current number of managers) instead of an even number.

With rc4 you should be able to demote 2 manager cluster to single manager cluster.

Ah, missed that it was reported with only two managers. I'm closing this issue, because demoting from two to one manager is already tracked in https://github.com/docker/docker/issues/23903, and will be in RC4 as @tonistiigi mentioned above.
Feel free to comment though!

Basically you can tolerate up to (N/2)+1 failures from 3 nodes and up.

I believe this should say you can tolerate up to (N/2)-.5 failures for an odd number of nodes.  (Obviously don't use an even number.)
I realize this issue is closed... just commenting in case somebody else runs across this.


Bump the MBOP version

MBOP PR: https://github.com/RedHatInsights/mbop/pull/18

For some reason the PR check is failing, looking...

Still failing, needs another look next week :(


One of the plugins doesn't like Angular/Ionic

Please help me locate which HTML plugin is causing errors to be reported after a save. I looked through the half dozen under the HTML section, but it doesn't seem to have any syntax checking there? (That I was able to find.)
Specifically, Ionic can look like this: (It uses Angular as an underlying engine so the problem may exist there too with the strange "anything is anything" tags)
   <ion-header-bar class="bar-positive">

Action Sheet

    </ion-header-bar>

I'm not sure of the best option for this. If the plugin can be fixed to support all these new tags (that Angular/Ionic support) or just disabled for my config...

I believe its scrooloose/syntastic. Closing for now as I research that further.

For those interested in what I had to do to fix this:
~/.vimrc.before.local:
let g:syntastic_html_tidy_ignore_errors=[" proprietary attribute "ng-","<ion-", "</ion-"]


No compatible version found<EMAIL_ADDRESS>

Hello I am new with node and npm
I have this error:
npm ERR! Error: No compatible version found<EMAIL_ADDRESS>npm ERR! Valid install targets:
npm ERR! ["0.0.3","0.1.0","0.2.0","0.3.0","0.3.1","0.3.2","0.4.0","0.4.1","0.4.2","0.4.3","0.4.4","0.4.5","0.4.6","0.5.0","0.5.1","0.5.2","0.6.0","0.6.1","1.0.0","2.0.0","2.0.1","2.0.2","2.0.3"]

I want test this library how can I do ?

That looks really strange. Can you run npm --version and post your result. In the list of available targets 2.0.2 is listed.

$ npm --version
4.0.5

I just retried it myself and don't get any errors. You are running npm install electron-screenshot-service right?

I ran npm install electron-screenshot-service
and this code
var fs = require('fs');
var screenshot = require('electron-screenshot-service');
screenshot({
url : 'http://google.be',
width : 1024,
height : 768
})
.then(function(img){
fs.writeFile('./out.png', img.data, function(err){
screenshot.close();
});
});
it is working thanks
2017-01-05 13:40 GMT+01:00 FWeinb<EMAIL_ADDRESS>
I just retried it myself and don't get any errors. You are running npm
install electron-screenshot-service right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FWeinb/electron-screenshot-service/issues/35#issuecomment-270635259,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB-TvwI_p2CUG7MGwuJGNtkn64aDDyPrks5rPOSrgaJpZM4LbK8Y
.

--
Lionel Van Winnendaele


Fix order for JoinSwapShareAmountOut CLI args

Closes: #3813
What is the purpose of the change
Swaps the token_in_max_amount and share_out_amount CLI arguments of JoinSwapShareAmountOut to match spec in docs.
Brief Changelog

Swapped order of token_in_max_amount and share_out_amount in proto
Autogenerated resulting proto files

Testing and Verifying
Based off the example that @larry0x provided in the issue, I rebuilt osmosisd locally and ran the following to verify:
$ build/osmosisd tx gamm join-swap-share-amount-out uosmo 12345 67890 --pool-id 678 --from test1 --chain-id 1

{"body":{"messages":[{"@type":"/osmosis.gamm.v1beta1.MsgJoinSwapShareAmountOut","sender":"osmo1cyyzpxplxdzkeea7kwsydadg87357qnahakaks","pool_id":"678","token_in_denom":"uosmo","token_in_max_amount":"12345","share_out_amount":"67890"}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[],"fee":{"amount":[],"gas_limit":"350000","payer":"","granter":""}},"signatures":[]}

confirm transaction before signing and broadcasting [y/N]: ^C

As seen above, the token_in_max_amount being 12345 (the 2nd argument) and share_out_amount being 67890 (the 3rd argument) indicate that the order of the arguments is now fixed.
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? bugfix
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? gamm README

The relevant code that should be edited is here: https://github.com/osmosis-labs/osmosis/blob/main/x/gamm/client/cli/tx.go#L137-L144
Osmocli doesn't have tooling right for now letting you change the arg order. Either we add that, or we make a custom parse fn (likely much easier) for this CLI tx. (ParseAndBuildMsg, but use osmocli methods for parsing each arg)

I think simply fixing the help text would be good enough.
Also, I suspect other CLI commands related to x/gamm may have the same issue, so better give them a test as well.

@ValarDragon thoughts on just changing the order of args on the usage text / README?

Ah yeah, just changing the help text SGTM

TYSM! Really appreciate the issue close :)
If you get a chance, would you be down to add a changelog entry to breaking changes in the ## v13.1.2 section for
* [3647](https://github.com/osmosis-labs/osmosis/pull/3647), [3942](https://github.com/osmosis-labs/osmosis/pull/3942) (CLI) re-order the command line arguments for `osmosisd tx gamm join-swap-share-amount-out`

Added!

Thank you!


don't use Pkg.dir

You use Pkg.dir("Homebrew", ...) to find the package directory for the brew_prefix. This is not ideal, because it breaks in cases where the package was cloned into some other location—see JuliaLang/julia#12120
The right thing to do is to use dirname(@__FILE__) to get the path of the current file.

One case in which dirname(@__FILE__) might break down is for these package-manager packages, we generally need to have write access. If you were to install Homebrew.jl (or WinRPM.jl or Conda.jl) in some read-only system-wide location, we'd need to do something different.

I really wish Pkg.dir(pkg_name) would just use the same logic as using pkg_name, so then the two were equivalent.  I feel like that is the intention behind the verb in any case.

@tkelman, that's right, but Pkg.dir is still not correct then anyway.  Possibly you should be writing into ~/.julia/lib/v0.x/...

After the rewrite, we don't use Pkg.dir anywhere.


Demand surge update xft2 485&553

update to python sdk, update surge defo and add surge category

was a fork so should be closed


Typo fix for  component.

Fix typo introduced in https://github.com/palmerhq/the-platform/pull/47.

Thanks for the quick fix!


Adding all ip address allowed in security settings in Org

Critical Changes
Changes
Issues Closed

Upon consideration, let's talk through use cases before we move towards shipping this task. It is a security risk to make this change to an org, and one that we have very clear reasons to do, but I want to make sure we can message that clearly or consider the option of keeping this task internal.

Yeah, I don't think this is a good practice. What is the reason for wanting to do this?

When capturing screenshots for metadeploy translations robot plan the ip security settings need to be enabled to allow for the robot automation to properly capture the installation flow otherwise it hangs waiting for a confirmation code, which is unique and only sent by email @davisagli . I don't intend for this to be used on production orgs but for testing this is needed.

Closing per discussion with Josh -- we'll create an internal version of this that only allows the internal IP ranges.


Remove any script tags from generated feed xml

Hey! 👋
In my opinion node-rss should remove all script (e.g. iframe) tags from a generated feed, because some rss validators show the following warnings/recommendations:
content:encoded should not contain iframe tag
description should not contain iframe tag
These warnings occur if you add custom_elements like
item.custom_elements.push({
  'content:encoded': {
    _cdata: "<iframe width="560" height="315" src="..." frameborder="0" allowfullscreen></iframe>"
  }
});

Refs https://validator.w3.org/feed/docs/warning/SecurityRisk.html
As this is a rule, it might be helpful for everybody. Let me know if you think that the caller should remove script tags by himself.

@kirrg001 I'm the maintainer here ;)
I think the best approach for a non-breaking change would be to add a flag that is disabled by default, but when enabled auto-removes iframes?  Possibly the same for #49, and then we can turn those features on by default for a 2.0.0 release?! 🤔

yeah great idea 👍


gracefully handle undefined key (#977)

#977

@eyelidlessness Do you have a minute to review this PR?

@alxndrsn How about you?

This is on our radar and we will get to it soon.


Floating point exception (core dumped)

Hello @Peter554,
I get a Floating point exception (core dumped) when I'm using transform(img) from staintools.StainNormalizer(method='vahadane') with stain_normalizer.fit(i1_standard) previously applied and i1_standard being the same image as given in the example.
Here is a sample code to reproduce the error:
import staintools
import numpy as np

i1 = staintools.read_image("i1.png")
img = np.load("out.npy")

stain_standardizer = staintools.BrightnessStandardizer()
stain_normalizer = staintools.StainNormalizer(method='vahadane')

i1_standard = stain_standardizer.transform(i1)
stain_normalizer.fit(i1_standard)

print("img shape", img.shape)
print("img dtype", img.dtype)
img = stain_standardizer.transform(img)
img = stain_normalizer.transform(img)

Output:
img shape (128, 128, 3)
img dtype uint8
Floating point exception (core dumped)

Any idea why this happens? I've put the npy array file here.
Thanks a lot for this amazing tool!

Can I ask which version of Python you are using?
Also can you also clarify exactly which line of the above is causing the error? Thanks

@Peter554 Sure, Python 3.6.6, the line causing the error is the last one:
img = stain_normalizer.transform(img)

I also obtain:
RuntimeWarning: divide by zero encountered in true_divide
  source_concentrations *= (self.maxC_target / maxC_source)

In some of my images

If I use staintools.StainNormalizer(method='macenko') instead I get:
numpy.linalg.linalg.LinAlgError: Eigenvalues did not converge

If that can help. Getting an exception by using the StainNormalizer is kinda ok, at least I can catch it and continue the execution of my code. But if I get a Floating point exception like above there is nothing much I can do.

It seems you are getting zero for the max concentration on img. I believe you load this from a numpy array img = np.load(out.npy). Can you send picture of this image? Is it in the correct format (uint8: unsigned integers in range 0-255)?

@Peter554 it's mostly a white image. I understand this is not the kind of images that's expected to fit to the normalizer my point is that I shouldn't get a segfault if I use a valid image while this image doesn't have the right concentration. I should, at worse, get a python exception that I can catch and let my program continue.
The way I planned to use your tool is to stick it to my deep learning dataset pipeline so all kind of images can go through it, I eventually could check the image content to make sure I do not pass images that the normalizer do not expect but in that case I would have to rely on my own assumptions to create the condition which prevent my whole program from crashing.
If instead your lib would just ignore the stain normalization on a given image (which is what makes the most sense to me) if that same image is not what your lib expect or at least throw a python exception I wouldn't have to create hacky conditions to avoid crashes.
The sample code I posted in that thread along with the saved numpy array are sufficient for you to be able to reproduce the crash. I would like to be able to submit a PR but I'm not sure I would make this right.
Thanks :)

Yes I agree the current behaviour is poor. If you have a solution that amends this behaviour a PR would certainly be welcome.

Hey @Peter554 I just checked and it seems the segfault is actually happening in SPAMS. spams.trainDL() in VahadaneStainExtractor seems to be the culprit (the segfault happens right after the get_stain_matrix returns so that's very weird as everything seems to happen smoothly then fails). You can reproduce by adding this test to your test suite:
def test_stain_normalizer():
    # Ensure the test do not segfault
    x = np.array([[255, 255, 250],
                  [255, 255, 255],
                  [255, 255, 255]], dtype=np.uint8)
    x = np.repeat(x[:, :, np.newaxis], 3, axis=2)  # Adds 3 channels
    stain_normalizer = staintools.StainNormalizer(method='vahadane')
    script_dir = Path(os.path.dirname(os.path.abspath(__file__)))
    i1 = staintools.read_image(str(script_dir / ".." / "data" / "i1.png"))
    stain_normalizer.fit(i1)

    output = stain_normalizer.transform(x)
    assert output.shape == x.shape

I really don't have any idea how to deal with SPAMS, do you have any recommendation of a precheck on my images that we talked about that I could add which will prevent me to end up with a segfault?
Thanks a lot!

Hi, I am part of the SPAMS dev team. I found the issue. In both examples, resp.:
img = np.load("out.npy")
stain_normalizer = staintools.StainNormalizer(method='vahadane')
img = stain_normalizer.transform(img)

and
x = np.array([[255, 255, 250],
                     [255, 255, 255],
                     [255, 255, 255]], dtype=np.uint8)
x = np.repeat(x[:, :, np.newaxis], 3, axis=2)  # Adds 3 channels
stain_normalizer = staintools.StainNormalizer(method='vahadane')
output = stain_normalizer.transform(x)

both images (img and x) are fully masked in the method VahadaneStainExtractor.get_stain_matrix (see staintools/stain_extractors/vahadane_stain_extractor.py), thus the decomposition from SPAMS is applied to an empty array, hence the segfault.
Here is a reproducible example:
import numpy as np
x = np.array([[255, 255, 250],
                     [255, 255, 255],
                     [255, 255, 255]], dtype=np.uint8)
x = np.repeat(x[:, :, np.newaxis], 3, axis=2)  # Adds 3 channels

## see staintools/stain_extractors/vahadane_stain_extractor.py
from staintools.utils.misc_utils import convert_RGB_to_OD, normalize_rows, get_luminosity_mask
luminosity_threshold=0.8
dictionary_regularizer=0.1
I=x
tissue_mask = get_luminosity_mask(I, threshold=luminosity_threshold).reshape((-1,))
OD = convert_RGB_to_OD(I).reshape((-1, 3))
OD = OD[tissue_mask]
print(OD)
print(OD.shape)

import spams
dictionary = spams.trainDL(X=OD.T, K=2, lambda1=dictionary_regularizer, mode=2, modeD=0, posAlpha=True, posD=True, verbose=False).T # segfault: OD.T is an empty array

I will see how we can add check in SPAMS for such scenario. In the mean time it might probably be a quickier fix if there was a check before using spams in StainTools.

Hello,
Thank you so much for taking the time to investigate on this issue!
As I said on the github issue a python programmer don't expect to get a segfault when something goes wrong, he must, at best, get a python exception.
I will prob be able to submit a quick fix to the staintools repo thanks to your help but SPAMS would become more robust if it is bulletproof to these kind of failures :).
Again, thanks a lot for the help.
Passe une bonne journée,
Tuatini
Tuatini
AI/Machine & Deep learning freelancer ( http://medium.com/@ekami ) ( http://fr.linkedin.com/in/tuatini-godard-619b0978 ) ( http://stackoverflow.com/users/1334473/e-kami ) ( http://github.com/EKami ) ( http://www.kaggle.com/ekami66 )
*Mobile: * +33 6 48 15 20 65 ( tel:+33%2006%2048%2015%2020%2065 )
Email<EMAIL_ADDRESS><EMAIL_ADDRESS>)
Website: https://tuatini.me/ ( http://tuatini.me/ )
Pgp pub key: http://bit.ly/2g0asc2
On Tue, Nov 13th, 2018 at 1:8 PM, gdurif<EMAIL_ADDRESS>wrote:

Hi, I am part of the SPAMS dev team. I found the issue. In both examples,
resp.:
img = np.load("out.npy") stain_normalizer =
staintools.StainNormalizer(method='vahadane') img =
stain_normalizer.transform(img)
and
x = np.array([[255, 255, 250], [255, 255, 255], [255, 255, 255]],
dtype=np.uint8) x = np.repeat(x[:, :, np.newaxis], 3, axis=2) # Adds 3
channels stain_normalizer = staintools.StainNormalizer(method='vahadane')
output = stain_normalizer.transform(x)
both images ( img and x ) are fully masked in the method VahadaneStainExtractor.get_stain_matrix
(see staintools/stain_extractors/vahadane_stain_extractor.py ), thus the
decomposition from SPAMS is applied to an empty array, hence the segfault.
Here is a reproducible example:
import numpy as np x = np.array([[255, 255, 250], [255, 255, 255], [255,
255, 255]], dtype=np.uint8) x = np.repeat(x[:, :, np.newaxis], 3, axis=2)
Adds 3 channels ## see
staintools/stain_extractors/vahadane_stain_extractor.py from
staintools.utils.misc_utils import convert_RGB_to_OD, normalize_rows,
get_luminosity_mask luminosity_threshold=0.8 dictionary_regularizer=0.1
I=x tissue_mask = get_luminosity_mask(I,
threshold=luminosity_threshold).reshape((-1,)) OD =
convert_RGB_to_OD(I).reshape((-1, 3)) OD = OD[tissue_mask] print(OD)
print(OD.shape) import spams dictionary = spams.trainDL(X=OD.T, K=2,
lambda1=dictionary_regularizer, mode=2, modeD=0, posAlpha=True, posD=True,
verbose=False).T # segfault: OD.T is an empty array
I will see how we can add check in SPAMS for such scenario. In the mean
time it might probably be a quickier fix if there was a check before using
spams in StainTools.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (
https://github.com/Peter554/StainTools/issues/26#issuecomment-438243832 ) ,
or mute the thread (
https://github.com/notifications/unsubscribe-auth/AD2AopzMhL94ve5sHZ4XGWdhpX3Z-NB3ks5uurZEgaJpZM4X10ZJ
).

Thanks for the tip. I have to look into it. I will try to look into it as soon as possible.

Should be fixed now. Thanks.


Adding a new FAQ with the pre-requisite of GitHub permissions

@lianat - Can you respond to the requested changes or let us know if you would like us to commit them?
@elazark - After the changes are made, please add a #sign-off command to signal that the PR is ready to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@LianaT just a reminder to review the changes i have proposed

#please-close


Redshift late-binding views cannot be added as datasets

When adding Redshift's late-binding views as datasets a "Table [table name] could not be found" error is raised, even though the view is seen in the loaded schema and access is granted to the parent table of the view. This stops adding new datasets from views and updating existing ones as the schema is not being loaded.
The vies can be explicitly queried in SQL Lab successfully, but the column list cannot be loaded in the side panel with an Issue 1030 - The query has a syntax error.
How to reproduce the bug

Go to Datasets
Click on +Dataset
Select a late-binding view from the populated list in SEE TABLE SCHEMA and click Add
See An error occurred while creating datasets: (table_name) Table [*table name*] could not be found, please double check your database connection, schema, and table name

Expected results
Expected a new dataset to be created linked to the existing view.
Actual results
Cannot create dataset as the table is listed as missing.
Screenshots

Environment
(please complete the following information):

browser type and version: Chrome v115.0.5790.114
superset version: v2.0.1
python version: N/A
node.js version: N/A
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@cbuffevant I see you are listed as a Redshift user, is this something you could validate/examine/help with?

@ErikIgnatiev Which redshift driver are you using pyscopg2 or redshift-connector? what is the version of sqlalchemy-redshift?

I can query late binding views properly in superset version 2.1.0 @ErikIgnatiev Which redshift driver are you using pyscopg2 or redshift-connector? what is the version of sqlalchemy-redshift?

Our Superset version is 2.0.1. We're using psycopg2 = "==2.9.3" and sqlalchemy-redshift = "==0.7.1" in the image. By querying you mean adding a dataset? I can run successful queries in SQL Lab as well but getting the schema for creating new datasets fails.

I am able to create a dataset using a late binding view.

Hi there, and sorry this has gone quiet for so long. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale. If it is still an issue in Superset 3.x, we can re-open this, or feel free to open a new issue with updated context.


CCI-77: fix test "if there are multiple location options" being neste…

…d under test "if there is only one location option", add test for backwards nav if the user has gone to view more options for state_suburb

@bruskiza Please review :)


fine tune radius config

@yoav85 , congratulations for the application, a funny fact, I've been pushing some months ago exactly the same idea, but just updated with Bluetooth and AI for a full virtual quarantine here .
About this PR, let me suggest to lower the radius to 200m, once it takes one minute to walk 100m, and we could add more 100m for the lack of precision.
https://www.researchgate.net/publication/306052159_Horizontal_accuracy_and_applicability_of_smartphone_GNSS_positioning_in_forests
https://www.researchgate.net/post/Using_a_phone_as_scientific_GPS_how_accurate_technical_specifications_Apps
best wishes,
Henry

Thanks @henry-hz! Please read #32 to understand our reasoning for the radius length (for now).


Client Certificate Validation for non-public CA

If i have a client cert signed by a non-public CA (but not self signed), it will fail validation in
https://github.com/aspnet/AspNetCore/blob/master/src/Security/Authentication/Certificate/src/CertificateAuthenticationHandler.cs
Specifically, since it is not self-signed
chainPolicy.VerificationFlags |= X509VerificationFlags.AllowUnknownCertificateAuthority;
won't be set and we result in
"A certificate chain processed, but terminated in a root certificate which is not trusted by the trust provider"
I can't tell if there is a way to pass in a CA to the X509 ChainPolicy

looks like custom store is enabled by this
https://github.com/dotnet/corefx/pull/40379
but somehow this will need to be integrated with the CertificateAuthenticationHandler

Are you on Windows or Linux? If you're on Windows the expectation here is for you to add it to the certificate store as a trusted root. If you're on Linux you do the same, but for OpenSSL.

running as docker container on Linux kubernetes.  So the certificate are actually just downloaded onto a FS mount.  And the code load the bytes into X509Certificate2 object.

This also causes some difficulty on client certificate authentication on Azure App Services. Authenticating with a self-signed client certificate is fine (the check for .IsSelfSigned() sets the VerificationFlags to avoid the CA check), but authenticating using a client certificate which has been signed by a non-public CA won't work.
App Services doesn't allow changes to the list of trusted root certificates, so this seems to prevent any kind of non-trivial client certificate authentication without using a dedicated App Service Environment.
I can submit a PR to add the feature. Would it be better to have a simple boolean (ValidateCertificateAuthority) on CertificateAuthenticationOptions to disable the CA check, or a new event (OnCertificateValidating) on CertificateAuthenticationEvents?

Would it be better to have a simple boolean (ValidateCertificateAuthority) on CertificateAuthenticationOptions to disable the CA check

I think this a good choice.
@Tratcher


determine if file run directly or imported

Is there some way for a file to tell if it was imported or run directly via jk run?
The equivalent question in node.js:  https://stackoverflow.com/questions/6398196/node-js-detect-if-called-through-require-or-directly-by-command-line

There isn't at this time. Out of curiosity, what is the use case for this?

use case described here:  https://github.com/jkcfg/jk/issues/125#issuecomment-488285182
right now when I run jk run parent.js it ouputs 34 files.    If I can just do jk run child.js to only get a couple of files of output it'll be much easier to debug.

Ah I see. That's something that could be solved if both parents and children implement the same "protocol" (export default [objects])  and if jk generate could be called with either parent or child. Seems like a nicer way to solve the use case.

Given that jk generate can now be used as I described in my latest comment, going to close this. I'd rather not introduce too many things that will result in different code paths (and so potentially different results) depending on how the script is invoked.
Do re-open if you disagree!


Add CodeReport to list of YT channels

CodeReport is a current and still active YouTube channel where problems from recent contests are explained in detail. It's been really useful, and it's nice that this resource is still updated, whereas the other YouTube links appear to be dead.

I actually stumbled upon this channel a few days ago. I'll review it later today. Thanks!
Regarding other links, I'm re-reviewing the items on the list shortly. I'm aware that some items are currently inactive/unmaintained.

I also discovered this post: http://codeforces.com/topic/43738
Unfortunately I just got stomach flu, but I will try to get back to this as soon as I can.


Added punctuation in the text.

Tried to start small and added punctuation for now.

@AtulACleaver do you need any help with the comments?

@AtulACleaver do you need any help with the comments?

@AtulACleaver Just Checking in. If you need any help let us know 🤓


Native alias test

Script used for testing: https://gist.github.com/mr-c/90dbca3383037914dbdd5abf935231d9
The following functions are implemented inside GCC 10 but not GCC 9, which causes problems when using the NATIVE_ALIASES
_mm256_loadu2_m128
_mm256_loadu2_m128d
_mm256_loadu2_m128i
_mm256_storeu2_m128d
_mm256_storeu2_m128
_mm256_storeu2_m128i
_mm256_zextps128_ps256
_mm256_zextpd128_pd256
_mm256_zextsi128_si256

The following functions need to be manually unrolled, ideally (but are probably fine as is)
AVX2:
_mm256_extract_epi8
_mm256_extract_epi16
AVX:
_mm256_extract_epi32
_mm256_extract_epi64
_mm256_insert_epi8
_mm256_insert_epi16
_mm256_insert_epi32
_mm256_insert_epi64

This is a great catch!
It looks great if we can add your script or something to verify the alias in the current testing workflow with CMakeLists.txt.
After that, we might be able to remove the following note it's recommended to only do this for testing  in README.md if we can use it safely.

If you define SIMDE_ENABLE_NATIVE_ALIASES before including SIMDe
you can use the same names as the native functions.  Unfortunately,
this is somewhat error-prone due to portability issues in the APIs, so
it's recommended to only do this for testing.

@junaruga Thanks!
In my SIMDe writeup for Debian I recommend the use of the native alias to keep the patches more maintainable: https://wiki.debian.org/SIMDEverywhere
And then I found https://github.com/nemequ/simde/commit/b30129b3b48a6823013da2b309c50a081177b6b8 the hard way so I went looking for a more comprehensive solution :-D

This is awesome, thank you!

After that, we might be able to remove the following note it's recommended to only do this for testing in README.md if we can use it safely.

Unfortunately this is still an issue.  The easiest example is all the functions that operate on 8-bit signed lanes.  Intel uses char instead of int8_t, but on most ARM platforms char is unsigned.  Code which uses SSE is likely to assume char is signed (since without SIMDe it's restricted to platforms where char is signed).  There are lots of small portability issues with the Intel APIs which make it unsafe to assume code will work as intended with SIMDe.
That said, we could probably soften the language a bit, and maybe add some documentation explaining some of the issues.

In my SIMDe writeup for Debian I recommend the use of the native alias to keep the patches more maintainable: https://wiki.debian.org/SIMDEverywhere

I think that's the right call for Debian.  If upstream projects are willing to adopt SIMDe IMHO it would be better to use the simde_* functions since that will enlist the type system to help identify portability issues, but for patches carried by Debian (or any distro) I think it's more important to keep the delta small.

I don't understand why 5522b21 is necessary. Are you running the tests after stripping off the simde prefix?

Yes, the script I linked to strip out the simde or SIMDE prefix
Without 5522b21 I got failures in CPP mode (emul vs. native calls)

@nemequ The testing script is pretty gross, so tips on cleaning it up are welcome: https://gist.github.com/mr-c/90dbca3383037914dbdd5abf935231d9
Not quite ready to be fully automated yet

I think that's the right call for Debian. If upstream projects are willing to adopt SIMDe IMHO it would be better to use the simde_* functions since that will enlist the type system to help identify portability issues, but for patches carried by Debian (or any distro) I think it's more important to keep the delta small.

Since my testing script generates a list of all the functions that have been implemented in SIMDe, a variation on that could be used to create a safer bulk renamer

I just created a wip/native-aliases-test branch.  It has an updated version of your patch to add the helpers (which, AFAICT, is all of this PR that hasn't been committed yet), and a rewritten script which uses the Intel Intrisics Guide to generate a list of functions.  I also added a test on GitHub Actions.
Let me know what you think.

@nemequ Thanks! They look good, modulo my comments about SIMDE_* on https://github.com/nemequ/simde/commit/abfca1951a158292a8631be9886a7078526c669f

@nemequ Adding -march=native to that test script raises a lot of issues: https://github.com/nemequ/simde/runs/642316073#step:7:50

@nemequ Thanks! They look good, modulo my comments about SIMDE_* on abfca19

Good point.  I think it's probably worth merging this even without those changes, but I'll try to find a way to cover the macros, too.

@nemequ Adding -march=native to that test script raises a lot of issues: https://github.com/nemequ/simde/runs/642316073#step:7:50

Oh, good point.  I'll take a look in a few minutes; it's probably more stuff I broke with the simde-features.h changes.  I'm going to need to get an SDE build running on CI for stuff like GFNI anyways, so maybe I'll just run this is SDE, too; IIRC GH Actions don't even have AVX-512, much less GFNI, and it's going to be a while before they migrate to ICL+.

I just merged the rest of this, finally.  The SIMDE_* macros aren't done yet, but that can be addressed later.  I wanted to get this in ASAP since this test catches a lot of bugs which I obviously can't be trusted to spot when reviewing patches.
I found out what was forcing you to comment out the __m512* typedefs, see 030b05f2209f1464babc221063358ca86952b404 for an explanation. The good news is that it works, and all the tests pass with -mavx512f or -mavx. Unfortunately you'll get a ton of warnings right now about redefining macros; one for each "intrinsic" that the compiler implements as a macro.
I think all we can do here is add an undef before defining each native alias.  For example,
diff --git a/simde/x86/gfni.h b/simde/x86/gfni.h
index d1b494e..2e25a2a 100644
--- a/simde/x86/gfni.h
+++ b/simde/x86/gfni.h
@@ -121,6 +121,7 @@ simde_x_mm_gf2p8matrix_multiply_epi64_epi8 (simde__m128i x, simde__m128i A) {
   #define simde_mm_gf2p8affine_epi64_epi8(x, A, b) simde_mm_xor_si128(simde_x_mm_gf2p8matrix_multiply_epi64_epi8(x, A), simde_mm_set1_epi8(HEDLEY_STATIC_CAST(uint8_t, b)))
 #endif
 #if defined(SIMDE_X86_GFNI_ENABLE_NATIVE_ALIASES)
+  #undef _mm_gf2p8affine_epi64_epi8
   #define _mm_gf2p8affine_epi64_epi8(x, A, b) simde_mm_gf2p8affine_epi64_epi8(x, A, b)
 #endif

ISA extensions prior to up to and including AVX wouldn't require this, but all the extensions which are declared by including immintrin.h (except for AVX), including AVX2, FMA, AVX-512, GFNI, etc. would.

Thanks for taking this to completion, Evan!


 Unifying how we use literals also has the knock-on effect of removing tons of code (as measured by character count) which has readability gains. For anyone curious about the int -> float conversion, this is 100% safe because these int literals are known by the compiler to convert losslessly to floats so there's no correctness lost in this PR.
The best way to look at this PR is me going back and cleaning up inconsistencies in my own code from the last few months.
Tasks

[x] Tested on Linux
[x] Tested on Windows
[x] Tested on macOS
[x] Tested on iOS
[x] Tested on Android

Sorry for always nitpicking on stylistic issues, I feel bad given the huge effort you have put into SFML over the last months 😬
One issue with using integer literals as floats is that we might not be able to do that 100% of the time (thus not fully "unifying" things). Examples I can imagine are arguments to generic functions, overloaded functions, { } initialization syntax (like {2, 1} for vectors), etc.
Other than that it's probably fine, as long as people agree it's more readable that way. I usually write the .f explicitly, but that might also be a habit stemming from old compilers, which issued warnings for such cases.

One issue with using integer literals as floats is that we might not be able to do that 100% of the time (thus not fully "unifying" things).

Maybe "unify" is the wrong word here. I mostly just wanted to make code less verbose wherever possible. I said "unify" because in earlier unit tests I was always adding .0f then realized I could just do .f then  I realized could actually just use integer literals in most places so if you look closely, the style of the unit tests I wrote shifted over time to get marginally simpler.

One issue with using integer literals as floats is that we might not be able to do that 100% of the time (thus not fully "unifying" things). Examples I can imagine are arguments to generic functions, overloaded functions, { } initialization syntax (like {2, 1} for vectors), etc.

In a few places I had to be sure I wasn't accidentally calling a different overload but for the most part SFML doesn't overload on floats and ints.

Other than that it's probably fine, as long as people agree it's more readable that way. I usually write the .f explicitly, but that might also be a habit stemming from old compilers, which issued warnings for such cases.

I'm cool with anything so long as we're not requiring the trailing 0 after the decimal point. I know I'm getting really into the weeds with this but I figured it was worth a PR cleaning up the mess I made in test/ even if we don't make a point to maintain a specific style going forward.

Sounds good. I'm personally all for readable tests! It's just that this may be highly subjective, some people prefer things to be "explicit but more verbose". I'm fine either way here, concise tests means also they are slightly more motivating to write 🙂

It's just that this may be highly subjective

This is probably a one-time change since maintaining such rigorous consistency with float literals will be painfully tedious.
For what it's worth, src/ and include/ are already very consistent with float literals. examples/ has a significant number of inconsistencies but there aren't meaningful readability gains to be made there. Fixing that up is mostly an academic exercise. I omitted those changes from this PR for the sake keep scope from exploding.

Hm, there's probably no tooling available to automate that? Like a linter with a built-in "fix" mode? 🔧

Not that I'm aware of. clang-tidy has a built-in fix mode but clang-tidy doesn't address these kinds of discrepancies. As an aside, I've played around with running clang-tidy over SFML and eventually want to add that to our CI pipeline.

SFMLBuildMaster: Build this please.

I personally prefer 1.f etc as well, as it's more explicit of what I'm wanting to achieve and removes the need to differentiate if there are int and float overloads.

I'll bite -- if we need a float expression, isn't it better to explicitly use a float literal rather than using an integer literal and relying on an implicit conversion...? The former seems more sensible to me.

2 votes to 1 from the maintainers so it looks like we have a decision. I still want to remove all the instances of .0f I added but I'll replace those with .f instead.

SFMLBuildMaster: Build this please.

Looks like not all sf::Transform constructor call used float literals to begin with

Haha I was wondering if anyone would notice that. In my latest tests I started using loads of integer literals, hence this PR. Sadly I can't easy grep for integer literals that are being used to initialize floats but I can go through and find and fix those.

Looks like you opened Pandora's Box 😁

I guess I deserve this for opening the PR ¯_(ツ)_/¯

I added .f in about a hundred more places. Let me know if there's anything I missed.

I found a few hundred more places where float literals could be used. The current state of this PR illustrates why I've been using integer literals. I don't think hundreds of unnecessary .f suffixes make the code any easier to read. Plus it's just a huge pain to audit the code for missing .f suffixes whereas finding and removing unnecessary .f suffixes is pretty easy to enforce.

Guys, I know it's "correct" but are we solving a real problem here? Readability is subjective and while there may be obscure corner-case bugs related to incorrect float/integer literal usage, I have the feeling this is a bit of an academic exercise. Especially since the other literals haven't been more correct in C++98, yet no one has complained -- at least to my knowledge.
Talking of readability, a bigger pain imho is the proliferation of static_cast<Type>(expression) all over the place. I know it's often unavoidable, but even things like toUint8(expression) would help a lot; but I know this is also controversial.
Yet even that is a relatively small issue. I'm not sure if we shouldn't focus our resources on more pressing issues which add real value to users -- like coming to a consensus on the long overdue scancode design.

I'm definitely sucking up much of the oxygen in the room with this PR and maybe regret opening it. This is far from my top priority so if we can't come to a consensus on this I'm fine closing this. I'd also much rather we spend our time discussing scancodes or SFML 3 design decisions. I've tried proposing some bigger changes I want to make but haven't gotten very much feedback, hence me filling my time with these lesser important PRs.


sanitycheck: fix false passed on localized error message

Fix false passed on localized error message in make invocation.
Fixes #8348
Originally in PR #8349

originally submitted by @b0661 , so mergining.


Support multiple resources specified in Maven war plugin

The maven plugin webResources element allows the user to specify multiple
resources. Each may be a directory optionally with a new name and certain
files included or excluded.
The loose application created by the dev mode must handle multiple resources
and the target name used in the app. Since the loose application does not actually
copy the files the include/exclude are not supported.
        <configuration>
          <webResources>
            <resource>
              ...
            </resource>
            <resource>
              <directory>configurations</directory>
              <!-- override the destination directory for this resource -->
              <targetPath>WEB-INF</targetPath>
              <!-- enable filtering -->
              <filtering>true</filtering>
              <excludes>
                <exclude>**/properties</exclude>
              </excludes>
            </resource>
          </webResources>
        </configuration>

commit 662585f948a5fbe03e0da3


Added German (de) locale for NodeJS BotBuilder

Added German (de) translation for the Node package
Thanks to Pim Steutel / Sarah Buckmann!

Hi @iMicknl, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

Hi @iMicknl, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

Hi @iMicknl, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (t-mivlee). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

(Sorry for the close / reopen messages, something didn't work with the AZPRBOT. Solved now.)

approved

This hasn't been released to npm yet, has it?


Improve Windows application details

Before:

After:

How about changing the FileDescription to something like either "Godot Engine Editor" alone or "Godot Engine $version ($status)"? I think it's weird right now to see error messages like "Godot Engine Editor (beta) has stopped".

@akien-mga might be better indeed. I think the version could be just removed, unless you think the errors with versions are better for debugging.

Removing the status would be fine with me; this visual "blabla has been stopped" is not particularly useful for debugging anyway.


http: handle _textBase64 in response text

Bug Fixes

http: handle _textBase64/None in response text

Something worth considering is adding unit tests specify for the apple HAR file, like we do with Chrome and Firefox.