Request mic access only when is needed

Fix #23682
edit : Project Settings > Audio > Enable Audio Input option is added. default is false (disabled)

Some devices won't work with this, for example the Focusrite Scarlett 6i6. Not sure why but if you don't initialize the input at the start it won't work afterwards.

I proposed one possible solution on this comment https://github.com/godotengine/godot/issues/23682#issuecomment-438304077
If we could implement a feature tag called audio_input and only enable the Microphone code if that tag is present the issue should be solved.

what a about having a Use audio input option at Project settings > Audio?

Sounds okay to me. Maybe Enable Audio Input might suit better for the name.
It should be disabled by default and maybe warn or automatically enable it if the user adds a AudioStreamMicrophone on the project.

it seems to need to take care of all kind of audio driver (core, pulse, rt, wasapi, xaudio2) right?

@marcelofg55 If I understand codes correctly, pulse and wasapi looks to initialize capturing device on demand.
would you take a look changes?

updated

@marcelofg55 thanks for the review. :)

Thanks!


[move-prover] add a flag to toggle whether unconditional abort is inconsistency-(8)

Motivation
The motivation for this change is the inconsistency issue reported in
PR https://github.com/diem/diem/pull/8851, where TransactionFee::burn_fees runs into an
unconditional abort case when and only when CoinType is instantiated
with XDX.
This is subsequently flagged by the inconsistency checker as an
violation. Where in this case, the inconsistency checker flags the
case not because we are not proving an assert false;, but because the
verification finishes successfully when the inconsistency checker
expects it to fail.
The reason verification finishes successfully is because for a function
that unconditionally abort on all arguments (and hence, never returns),
the assert false; verification condition is either not instrumented
or not reachable.
The fix, is to not only instrument assert false; before returns, but
also before an abort. In this way, we will be able to catch executions
that terminates without going through the return path.
However, we may still want to preserve the ability to check functions
that unconditionally abort, as we can prove function like the following
does look a bit odd to users.
fun always_abort() {
    abort 0
}
spec always_abort {
    ensures 1 == 2;
}

The compromise is to have an additional flag,
--unconditional-abort-as-inconsistency
to control whether we want to treat a function that aborts
unconditionally as an inconsistency violation. Unfortunately, due to the
complication in TransactionFee.move, we cannot turn on this flag by
default and have to rely on periodic manual runs to check these cases.
Testplan

Move prover test cases were added fro above changes.
CI test execution will cover updated code changes.

/canary

:sunny: Canary successful

/land


Switch to fixed delaytime for retry.Do function

retry.Do uses BackOff delay by default. This sometimes increases boot time of podVM. Investigate podVM boot time switching to fixed delay time

When using default Backoff delay, the time gap between instance creation and proxy connection is almost 2min
2023/05/25 10:09:39 [adaptor/cloud] created an instance podvm-network-debug-app-7f7f8664f9-pqt84-cbb29499 for sandbox cbb29499dc45810ca0fd9ebad18b06db4bd5e406e1a7c361e0d63d85e96dfba6

2023/05/25 10:09:39 [tunneler/vxlan] vxlan ppvxlan1 (remote <IP_ADDRESS>:9000, id: 555032) created at /proc/1/task/13/ns/net

2023/05/25 10:09:39 [tunneler/vxlan] vxlan ppvxlan1 created at /proc/1/task/13/ns/net

2023/05/25 10:09:39 [tunneler/vxlan] vxlan ppvxlan1 is moved to /var/run/netns/5494dc50-e16b-4987-8b71-820a877e2c4a

2023/05/25 10:09:39 [tunneler/vxlan] Add tc redirect filters between eth0 and vxlan1 on pod network namespace /var/run/netns/5494dc50-e16b-4987-8b71-820a877e2c4a

2023/05/25 10:09:39 [adaptor/proxy] Listening on /run/peerpod/pods/cbb29499dc45810ca0fd9ebad18b06db4bd5e406e1a7c361e0d63d85e96dfba6/agent.ttrpc

2023/05/25 10:09:39 [adaptor/proxy] failed to init cri client, the err: cri runtime endpoint is not specified, it is used to get the image name from image digest

2023/05/25 10:09:39 [adaptor/proxy] Trying to establish agent proxy connection to <IP_ADDRESS>:15150

2023/05/25 10:11:29 [adaptor/proxy] established agent proxy connection to <IP_ADDRESS>:15150

10:09:39 - instance created
10:11:29 - proxy connection established
When using default Fixed delay, the time gap between instance creation and proxy connection is few seconds
2023/05/25 12:32:26 [adaptor/cloud] created an instance podvm-network-debug-app-7f7f8664f9-vwmvl-5ef485af for sandbox 5ef485affd3806cc35139af3d5fc374a7508532c0b9cfb21f765bea748716041
2023/05/25 12:32:26 [tunneler/vxlan] vxlan ppvxlan1 (remote <IP_ADDRESS>:9000, id: 555000) created at /proc/1/task/10/ns/net
2023/05/25 12:32:26 [tunneler/vxlan] vxlan ppvxlan1 created at /proc/1/task/10/ns/net
2023/05/25 12:32:26 [tunneler/vxlan] vxlan ppvxlan1 is moved to /var/run/netns/97c66332-9261-4a87-a8c4-ecaa7f40c6fd
2023/05/25 12:32:26 [tunneler/vxlan] Add tc redirect filters between eth0 and vxlan1 on pod network namespace /var/run/netns/97c66332-9261-4a87-a8c4-ecaa7f40c6fd
2023/05/25 12:32:26 [adaptor/proxy] Listening on /run/peerpod/pods/5ef485affd3806cc35139af3d5fc374a7508532c0b9cfb21f765bea748716041/agent.ttrpc
2023/05/25 12:32:26 [adaptor/proxy] failed to init cri client, the err: cri runtime endpoint is not specified, it is used to get the image name from image digest
2023/05/25 12:32:26 [adaptor/proxy] Trying to establish agent proxy connection to <IP_ADDRESS>:15150
2023/05/25 12:32:45 [adaptor/proxy] established agent proxy connection to <IP_ADDRESS>:15150

12:32:26 - instance created
12:32:45 - proxy connection established

cc @surajssd


List Task to run

List task registred on gulp file to avoid repeat the workflow:
Open command pallete -> run taks -> write text to run -> enter
On listing tasks:
List task -> choose -> enter

Can you clarify this one a bit ?
I think I'm misunderstanding the request but it looks like it could be solved by using a Keyboard Shortcut

List Tasks is simple.
Catch all gulp.task registred on gulp file e show after type on command
pallete: "Gulp: List Tasks"
2016-05-27 10:44 GMT-03:00 Nicolás Santángelo<EMAIL_ADDRESS>
Can you clarify this one a bit ?
I think I'm misunderstanding the request but it looks like it could be
solved by using a Keyboard Shortcut
https://github.com/NicoSantangelo/sublime-gulp#shortcut-keys
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NicoSantangelo/sublime-gulp/issues/64#issuecomment-222150064,
or mute the thread
https://github.com/notifications/unsubscribe/AB1ewwsccrZFV5861Dj-ByLPFToAQMiAks5qFvVUgaJpZM4In6bb
.

--
[]'s
Danilo.

But isn't that the way the Gulp command works today ?

Ow man, sorry, I don't see it  :)
2016-05-27 17:44 GMT-03:00 Nicolás Santángelo<EMAIL_ADDRESS>
But isn't that the way the Gulp command works today ?
[image: list]
https://cloud.githubusercontent.com/assets/692077/15620755/9e8c0d66-2432-11e6-96a4-99352ea88664.gif
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NicoSantangelo/sublime-gulp/issues/64#issuecomment-222248942,
or mute the thread
https://github.com/notifications/unsubscribe/AB1ew1uw7E-btCbN95bDTWtF2MFwRL2yks5qF1e5gaJpZM4In6bb
.

--
[]'s
Danilo.

No problem :)


Cycle workspace by screen

Cycle through previously viewed workspaces in the order they were viewed most
recently on the screen where cycling is taking place.
The extremely long name is needed to differentiate this module from XMonad.Actions.CycleRecentWS which does something quite similar, with the main difference being that the history for different screens is not indendent (though it has the advantage of not depending on workspacse history)
I also provided the repeatableAction and update WorkspaceHistory as part of this change.

@IvanMalison Two things:

Please squash your commits. See this file for more details.

What's going on with all the changes in the .cabal file?

Please squash your commits. See this file for more details.

Sure. Do you want me to put everything from History and CycleRecent together or can I keep those separate.

What's going on with all the changes in the .cabal file?

I just ran M-x sort lines on all the modules since they are clearly SUPPOSED to be alphabetically sorted. It seems like a few mistakes were made here and there.

Go ahead and squash everything into a single commit.  And thanks for the note about sorting.  That makes sense.

@pjones Merge?

Thanks!


Fix shadow map using vertex normals.

Fixes #4971
Shadow map tries to output to wNormal which is an unused attribute. This cause a chain of event which begins with a uniform matrix_normal being unused but not stripped out of the shader code.

Tested GL1, GL2, clustered, non clustered and all looks good. We use the derivatives on depth for the polygon offset stuff on GL1 :).


Week 9 Documentation

Documentation for week 9 edits, including gh-pages navbar and docfixes.

Coverage remained the same at 92.537% when pulling f7e58a7f8b50caec7eb39172c53b002df1220892 on GeneralDocumentation into<PHONE_NUMBER>522ec50b67f06c9ac3beb863e54fb5 on master.

Coverage remained the same at 92.537% when pulling 76fc5b6d87cc6f767a7cbc3a091f9cfef12ea29e on GeneralDocumentation into<PHONE_NUMBER>522ec50b67f06c9ac3beb863e54fb5 on master.

Coverage remained the same at 92.537% when pulling 76fc5b6d87cc6f767a7cbc3a091f9cfef12ea29e on GeneralDocumentation into<PHONE_NUMBER>522ec50b67f06c9ac3beb863e54fb5 on master.

Coverage remained the same at 93.26% when pulling 3b58757a0904c1816605ad612c2cfa5212d51a19 on GeneralDocumentation into 5dd89ca9f30e0db7eb8d45ee3e2c9f7535d47c47 on master.


Error EISDIR when 'config' is a directory

In my project I have a directory config. The following code in config.js checks if config exists and then proceeds to read it as a file. It doesn't check if config is a file, so reading it fails with the EISDIR error.
readFrom('config', function() {

fs.exists(configPath, function(exists) {
  if (exists) {
    fs.readFile(configPath, 'utf8', function(err, data) {

I created pull request #3 for this.

config file is supposed to be read under .git directory (or in the working directory for bare repositories). Could you please provide what exact command fails (eg bower install, npm install or some manual nogit call)?

When I execute bower install jquery in a directory that contains a config subdirectory, the command fails. Looking at the code, I can only conclude that it doesn't try to read ./.git/config but ./config. But maybe I am missing something.

Thanks. Yep, nogit should read .git/config file for not bare git repos. I'll take a look at this later today and will also change exists to readFile error check.

I published new version to npm and nuget.


Change Language by manually

Hi,
i tried to implement your lib. but i have serval doubts, how i can change lng by manually .
do have any method to pass lng short to access  Localizable.string file.

Hi @syedrazackimran. Not sure what you mean. The language is generally chosen automatically by the OS based on what language the device is in. It also depends on the localizable.strings that you provide in your app.

Closing due to lack of response. Please open again if you encounter any other issues.
Thanks!

Hi hello,
I Mean in my application have Chinese, English and Spanish language. a user can able to choose they're preferred language in setting UI. if user change language how to change language manually.


⚠ Bofrost.de has degraded performance

In a1c71ca, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1337 ms

Resolved: Bofrost.de performance has improved in 1f5ab50 after 13 minutes.


[Docs/Wiki] Contribution Guide

A how-to guide for adding things like new commands to the project

Added CODE_OF_CONDUCT.md and CONTRIBUTING.md in 8ca4bd1 for review.

Added CoC and Contrib guide in https://github.com/mttaggart/OffensiveNotion/pull/113

Working on a Wiki page for adding to the project:
https://github.com/mttaggart/OffensiveNotion/wiki/So-You-Want-To-Contribute-To-OffensiveNotion


Fix NULL pointer dereference for BN_mod_exp2_mont

This fixes a bug whereby BN_mod_exp2_mont can dereference a NULL pointer if BIGNUM argument m represents zero.
Regression test added. Fixes #17648.

Probably should be backported to 1.1.1 as well.

Comment updated.
Is the process for backports to 1.1.1 documented?

The CI failure is relevant.

Is the process for backports to 1.1.1 documented?

Just cherry pick the commit into a new branch against the current OpenSSL_1_1_1-stable branch. If it cherry picks cleanly and builds, there is no need to create a separate PR. Otherwise create a separate PR from that branch against OpenSSL_1_1_1-stable branch.

If it cherry picks cleanly and builds, there is no need to create a separate PR.

In this case just put the 1.1.1 label on this PR.

Did not cherry pick cleanly, will create a PR for 1.1.

Failing CI has been fixed. Backport created in #17787.

Thanks, will do. I've addressed the style issues above.


miner does not mine

I completely configured the miner, decided to test it and download it to my pc, the miner does not turn on at all, I turned on and off the stealth mode, crypted and did't crypt the miner file, but there is no result, my gpu does not load even by 5 percent (although I set 30 percent)
I don't know what my mistake might be

What do you use yo check GPU usage? You can't use Task Manager since that doesn't display the kind of usage that the miner uses. Use something like MSI Afterburner or something like that to check the GPU usage.

i use not only the task manager but also its alternatives
even if i close the task manager, i cannot hear the cooler work

Yes I'm not aware of any Task Manager or alternative which display the correct GPU usage so that is normal. Either check with a GPU program like MSI Afterburner or you can check with something like Process Hacker by checking the VRAM of the program, if it's using up the VRAM then it's working.

i tried using msi afterburner, but again, as soon as i start the program, nothing happens, mining does not even start

What GPU usage does it show in MSI Afterburner and what GPU do you have?

GeForce GTX 1650,300 MHz

The 4GB card? If so then that's not good enough to mine Ethereum, https://github.com/UnamSanctam/SilentETHMiner#requirements, you can mine some other Ethash/Etchash coin like ETC (Ethereum Classic) instead which only requires 2.8GB of VRAM. Here is the DAG size that each Ethash/Etchash coin requires https://minerstat.com/dag-size-calculator

i've 12 gb card

Uh, I don't think that card has any releases higher than 4GB VRAM. If you check the Task Manager "Perfomance" tab and then click the GPU then you should be able to see the VRAM by checking the "Dedicated memory usage" or whatever it's called.

oh,i was wrong

sorry, i probably already pissed you off, but i turned on the ETC miner and still nothing happens

No no it's fine, did you also use an ETC pool and ETC wallet address? Since it's a different cryptocurrency (fork of Ethereum).

of course i use a different pool and different wallet for ETC

If you download Process Hacker and search for --cinit in the top right search does any process appear?

yes, but why then does the pool not show what i am mining?

You need to mine a share, the pool calculates hashrate as shares submitted over time.

If you double-click the process and check the GPU tab, how much dedicated memory is it using?

2,7 gb

Ah yeah then it's gotten a job from the pool and is mining.  It can be hard to know what to look for and what is correct.

If you double-click the process and check the GPU tab, how much dedicated memory is it using?

I've got the same issue as @dextheguy, GTX 1050ti except that the dedicated memory shows 41MB and MSI Afterburner does not show the GPU being used more than normal

I've got the same issue as @dextheguy, GTX 1050ti except that the dedicated memory shows 41MB and MSI Afterburner does not show the GPU being used more than normal

Isn't that a 4GB card? A 4GB card can't mine Ethereum https://github.com/UnamSanctam/SilentETHMiner#requirements. You'd have to mine some cryptocurrency with a smaller DAG size https://minerstat.com/dag-size-calculator like ETC.

I've got the same issue as @dextheguy, GTX 1050ti except that the dedicated memory shows 41MB and MSI Afterburner does not show the GPU being used more than normal

Isn't that a 4GB card? A 4GB card can't mine Ethereum https://github.com/UnamSanctam/SilentETHMiner#requirements. You'd have to mine some cryptocurrency with a smaller DAG size https://minerstat.com/dag-size-calculator like ETC.

oh alr, im gonna mine etc instead, thanks!


Fixed JavaDoc in areSerializedFieldsEqual

Minor patch. Just fixed javadoc and other purpose of this PR is to get familiar with development process.

Hi Sachin!
The HBase project uses the HBASE tracker in ASF JIRA instance to review and apply work. Would you mind filing a request there that describes the problem and proposed solution?
Our contributor guide section includes instructions on how to attach a patch to your issue once it exists.
Thanks for your interest in improving Apache HBase!


Update Stale Workflow

What does this PR do?
Updates stale workflow to address older issues not being properly marked as stale. In the workflow we had a start_date which by their docs means any PR or issue opened before that date is not going to be checked. Additionally, added ascending: true so that it will start from the lowest issue # item and work its way to the newer ones, ensuring that the oldest issues are checked first.

Which issue(s) does this PR fix

fixes https://github.com/devfile/api/issues/1529
fixes https://github.com/devfile/api/issues/1528
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

Open new test/doc issues under the devfile/api repo
Check each criteria if:
There is a separate tracking issue. Add the issue link under the criteria
or
test/doc updates are made as part of this PR
If unchecked, explain why it's not needed

[ ] Unit/Functional tests

[ ] QE Integration test

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer

Failing check unrelated to my changes, will rerun to see if it changes the outcome.

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

Ive noticed the same behaviour in other prs (similar error trace). Id suggest waiting a little bit as the PR is not so urgent and we can retest later. Wdyt?

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

Ive noticed the same behaviour in other prs (similar error trace). Id suggest waiting a little bit before investigating as the PR is not so urgent and we can retest later. Wdyt?

Sounds good to me. Can give it some time and revisit on Monday, if the checks are still failing we can bring it up in standup about pushing through anyway if unrelated

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

Ive noticed the same behaviour in other prs (similar error trace). Id suggest waiting a little bit before investigating as the PR is not so urgent and we can retest later. Wdyt?

Sounds good to me. Can give it some time and revisit on Monday, if the checks are still failing we can bring it up in standup about pushing through anyway if unrelated

Yeah I agree. Is very unlikely to be related with the PR :D

/retest

@thepetk rebase and fixing some whitespace seemed to fix the issue. Weird but it did the trick. Can you re-review please?

@thepetk rebase and fixing some whitespace seemed to fix the issue. Weird but it did the trick. Can you re-review please?

Very weird :D But yeah my review remains the same. Nice addition to the workflow!


Bug stuff with Salvage and new FTL System

Description

When the Salvage Shuttle arrives at the expedition planet, it can still move as if it were in space, and furthermore, move through blocks.
Reproduction

Arrive at the expedition planet.
Try to fly on the shuttle over it.

Screenshots
https://github.com/space-wizards/space-station-14/assets/142160914/1018a142-1524-4db4-b142-ecb95939d339
Additional context
Video quality suck.

Resolved in https://github.com/space-wizards/space-station-14/pull/25859


How to load a basis file at on demand

Currently the textures is loaded in the Start function, Is it possible that I pass a path to a .basis file and the texture gets loaded on demand in the middle of an execution of a script?

Would be nice to have a function
Texture 2D texture = LoadBasisTexture()

I think you should be able to do
var basis = new BasisUniversalTexture();
basis.onTextureLoaded += (tex, orientation) => texture = tex;
basis.LoadFromUrl(absPath, this);

however there seems to currently be a bug with that in the latest version (#21).

Thanks for your inputs!

Texture 2D texture = LoadBasisTexture()

This implies not just explicit loading, but also synchronous (which can cause frame stalls, so I'd discourage you to do that during game play)
@hybridherbst 's solution is explicit, but async, so that's great.
We should probably extend the Usage section in the README.md to cover this use case.

@atteneder My use case requires me to download the textures from an API at run time and then I have to decompress it.  I might just decompress in a background thread and that might resolve the stalling issue.
@hybridherbst Thanks, I will try that out.

My use case requires me to download the textures from an API at run time and then I have to decompress it. I might just decompress in a background thread and that might resolve the stalling issue.

 That's why I endorsed this solution :)

@atteneder maybe a good future thing is to implement background texture GPU upload. It certainly works on Android and iOS, and I think I've seen Windows Desktop implementations, but not sure about the latter. That would definitely speed things up quite a bit on top of the already great gains that glTFast brings.

@atteneder maybe a good future thing is to implement background texture GPU upload. It certainly works on Android and iOS, and I think I've seen Windows Desktop implementations, but not sure about the latter. That would definitely speed things up quite a bit on top of the already great gains that glTFast brings.

Absolutely!
I presume you mean by using native Graphics APIs (OpenGL,Vulkan,etc.) instead of Unity's API, right? We would then create the Unity Texture object via Texture2D.CreateExternalTexture.
This would probably be faster for two reasons:

Upload in background thread
No need to re-sort mipmap chains (has to be done atm, since Unity expects them in different order :-1:  )

Only disadvantage: Needs implementations per Graphics API (Vulkan, Metal, D3D, etc.). KTX-Software comes with native uploads for OpenGL and Vulkan already, so that might be a great starting point.
Let me know your thoughts and if you meant something different.
Thanks!


[SPARK-32434][CORE][FOLLOW-UP] Fix load-spark-env.cmd to be able to run in Windows properly

What changes were proposed in this pull request?
This PR is basically a followup of SPARK-26132 and SPARK-32434. You can't define an environment variable within an-if to use it within the block. See also https://superuser.com/questions/78496/variables-in-batch-file-not-being-set-when-inside-if
Why are the changes needed?
For Windows users to use Spark and fix the build in AppVeyor.
Does this PR introduce any user-facing change?
No, it's only in unreleased branches.
How was this patch tested?
Manually tested on a local Windows machine, and AppVeyor build at https://github.com/HyukjinKwon/spark/pull/13. See https://ci.appveyor.com/project/HyukjinKwon/spark/builds/34316409

cc @dongjoon-hyun, @srowen and @warrenzhu25

Test build #126630 has started for PR 29254 at commit ae0bd0e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31251/
Test PASSed.

Test build #126630 has finished for PR 29254 at commit ae0bd0e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126630/
Test PASSed.

Thanks, @srowen.
Merged to master.

Okay.. now all tests should be fixed now in all CIs...

Oh. Great!


[d3d9] TES4 Oblivion: Colour maps rendered differently to regular DX9 and Anisotropic Filtering not working

I have noticed a difference between how Oblivion renders textures on native DX9 vs. with DXVK installed.
This is a screenshot of what I see when running Oblivion on the native Windows 10 DX9:
https://i.imgur.com/U5OJNeu.png
This is what I see when Oblivion is running with DXVK installed:
https://i.imgur.com/qusFApQ.png
You can see some stretched colour maps especially on the stone wall to the left.
The normal maps for the dirt textures and rocks appear to have been flattened out or something as well. That said, I tried disabling the forced Anisotropic Filtering in the Nvidia control panel and the resulting normal mapping without DXVK looked very similar to the DXVK image. I also have a mod called Oblivion Reloaded that, amongst other things, enables AF in the game. I tried installing that as well and got the same result; AF didn't appear to have an effect while DXVK was installed. Thus, it seems that DXVK is not allowing Anisotropic Filtering to be applied.
Software information
The Elder Scrolls 4: Oblivion
Ultra High preset with all graphics settings set as high as they can go.
Qarl's Texture Pack 3 installed for high resolution textures.
16x Anisotropic filtering forced through Nvidia control panel.
System information

OS: Windows 10 x64 1909 (build 18363.836)
GPU: Nvidia GeForce 1080 Ti
Driver: Regular GeForce drivers version 445.75
Wine version: N/a
DXVK version: 1.7

Apitrace file(s)

I did an API trace but I'm not sure how useful it will be. This issue only appears when I have DXVK installed and I can't have both the trace's and DXVK's DLL installed at the same time.
https://mega.nz/file/unw33DzC#Cc8uPf9nSFfntmcv3BafoW7jeBQmRggonl3AK1CpGls

Log files

d3d9.log: Oblivion_d3d9.zip

In dxvk.conf you can force anisotropic filtering

So uh.. what exactly are you trying to do to enable anisotropic filtering?
The Nvidia driver option does not apply to Vulkan, so it's normal that it doesn't work with DXVK.

what exactly are you trying to do to enable anisotropic filtering?

What part of my post wasn't clear? I separately tried applying AF through the Nvidia control panel and through the Oblivion Reloaded mod.

The Nvidia driver option does not apply to Vulkan, so it's normal that it doesn't work with DXVK.

Fair enough but that leaves the question of why Oblivion Reloaded's method doesn't work unanswered. Looking at the source code, OR enables AF in Oblivion by doing two things:

Writing the value for the amount of AF you want to two bytes in the in-memory copy of Oblivion.exe (at 0x007BE1D3 and 0x007BE32B).
Calling the SetSamplerState function with the desired value.

In dxvk.conf you can force anisotropic filtering
Thanks. Forcing AF through DXVK worked. This revealed that the stretched colour mapping was also caused by the lack of AF. So this entire issue was caused by AF not being applied. So I guess the only thing unresolved at this point is why OR's patches to apply AF to Oblivion isn't working.

Also, is there any particular reason AF isn't enabled by default? It's been a long time since AF had a noticeable performance impact on even low-end GPUs. Does it cause artefacts in some cases?

Can you try this?
dxvk-anisotropy.tar.gz

Also, is there any particular reason AF isn't enabled by default? It's been a long time since AF had a noticeable performance impact on even low-end GPUs. Does it cause artefacts in some cases?

If it's not what the game requests, it shouldn't be a default and in some games it doesn't work properly at all.
It is however exposed as an option for you to play with to force it.

Code is here: https://github.com/doitsujin/dxvk/tree/d3d9-anisotropy

@Joshua-Ashton
Thanks for the help. Unfortunately, your DLL didn't work. When I ran Oblivion, a messagebox appeared with an error: Failed to initialise renderer. No D3D Device description found.

After clicking OK, the game exited. There was no d3d9.log created either.

If no log file gets created at all (not even an empty one), the DLL doesn't get loaded, i.e. you're doing something wrong. Did you pick the correct DLL (the 32-bit one)?

Try the froggi.es version of the build:
https://git.froggi.es/doitsujin/dxvk/-/jobs/1290/artifacts/download
My local one might be dodgy cause of binutils or whatever.

Okay, I just did some more testing and found that:

With the 64-bit version of the DLL, both builds that Joshua provided fixed the issue. AF works if I use either of the 64-bit versions.
For the 32-bit DLLs, the local build that Joshua provided gave the error message above. For the froggi.es build, the game does start and work but AF still wasn't being applied.

So it looks like AF is now working but there appears to be some sort of build issue that is affecting the 32-bit version.

Of course it does, because the game is 32-bit and the 64-bit version is just straight-up getting ignored.

Sorry, my mistake. I thought that the game would crash and burn or something if the 64-bit DLL was incompatible. Ignoring it was not what I expected.
Unfortunately, that means Joshua's changes didn't fix the issue.

the game does start and work but AF still wasn't being applied.

No idea then, the game isnt specifying anisotropy anywhere.

I just realised that I've made a big mistake here. I did some more testing and found that the patched in AF support that Oblivion Reloaded claims to add to the game doesn't actually do anything. All this time, the AF support I was seeing was actually what the Nvidia driver forced onto the game.
I'm so sorry I wasted your time.


Improve geocode flow

Context
Refer to this ticket
https://github.com/CartoDB/design/issues/1032

back to development

Documenting this because it's friday and we might forget.
There are a few things missing

[ ] When the geocoding analyses finishes correctly, navigate towards the style tab.
[ ] When the geocoding finishes, view should re-render. You're currently locked out of the other tabs.
[ ] We should remove a bunch of dead code that's around, like all the georeference placeholders that show on the other tabs.
[ ] The current solution marks empty layers as layers that need georeferencing. This doesn't make sense, but on the layer list we don't know if a layer has any rows.

First 3 are most likely straightforward. Fourth one requires doing an arbitrary number of requests on the layer list view, for all layers that:

Don't have a geocoding applied
Don't have a geometry
Don't have a custom query

Having no rows is the fourth condition that needs to pass, so we should fetch it if all of the above are true.
Bonus points: It would be interesting to know if users use the add empty dataset button often, and / or also what percentage of the datasets that users have without geometry are also datasets that have no rows.

I discussed this issue with design and they are already aware of the new states for the layers in the layers list. Feel free to ping them directly to ask for those new styles @rjimenezda
/cc @urbanphes @piensaenpixel

I already did the asynchronous loading, so I'm open to implementing a new style / add a transition or whatever for the layer component 🤗

In case you'd like to track our work for that: https://github.com/CartoDB/design/issues/1074

@urbanphes
There's a case that's not covered on the mocks. What happens if the user deletes the geocoding analysis? I see two options:
A) After it’s deleted, the user is immediately presented with an unsaved georeference analysis. This is what happens when the user clicks on the layer now.
B) There’s an intermediate step in which we tell the user: Hey, you have to georeference the layer, with a button that causes A)
B) is what we have on the analysis tab right now (for a non-geocoded layer), but with disabled tabs.

@rjimenezda In that case, I think we go with the option A. Our premise here is that the layer will be geocoded and the best way to gain this is with the option A.

Here they are in motion, I like A because there are less steps and is consistent, but it might be a bit weird for the user?
This is option A):

This is option B):

(please ignore the bug with the selected tab)

I've uploaded this to ded15

I'm sorry for not answering before. This was talking between @rjimenezda and me, at last, we are going with the B Option, it's more natural.

Acceptance on ded12:
I've left a map prepared with 3 layers there, on user ruben-ded12:

An empty layer
A Layer that needs geocoding
A regular layer (airbnb listings)

Things to look out for:

The empty layer and the layer that needs geocoding should show the new 'loading' state for a bit.
When clicking on the layer that needs geocoding, only the analysis tab is enabled, already showing a geocoding analysis that can't be canceled.
After applying this analyisis (for instance, geocode with coordinates, use cartodb_id for both lat/lon), it should redirect to the style tab. Tabs should be reenabled
On the layer list, the layer should display as a regular layer now.
Removing the geocoding analysis should show an intermediate step to let the user know that they should apply an analysis, which won't show if the user goes back to the layer list and back to the layer.

All of this new behavior should not affect regular layers & old behaviour.

@urbanphes or someone from design, can you give it a try?

While writing the above I noticed that I forgot to disable the add analysis button, so the user can change the analysis. I'll fix that at some point today, but I would appreciate if anyone can give it a look, since I have to switch back to this issue 💋

Hi @rjimenezda, I've tested the following steps:

[x] The empty layer and the layer that needs geocoding should show the new 'loading' state for a bit.
[x] When clicking on the layer that needs geocoding, only the analysis tab is enabled, already showing a geocoding analysis that can't be canceled.
[x] After applying this analyisis (for instance, geocode with coordinates, use cartodb_id for both lat/lon), it should redirect to the style tab. Tabs should be reenabled
[x] On the layer list, the layer should display as a regular layer now.
[x] Removing the geocoding analysis should show an intermediate step to let the user know that they should apply an analysis, which won't show if the user goes back to the layer list and back to the layer.

... and the feature works well.
My only concern is when I've deleted the analysis, the following screen say something like this.

At this point, I would remove the part " or manually add data to visualize" Because we look forward that the layer will be geocoding. But It will be great if anybody from @CartoDB/design can help us here.

Truth be told, I didn't even read that copy, it's the same that we used to show on the other tabs. While it's techincally true, user could manually add geometry, I think it doesn't make any sense to show that there. I'll remove the 'add data' 👍  and also fix the bug that I mentioned before

What do you think something like? "There's no geometry in your data, please georeference it"

@piensaenpixel @urbanphes What should I do with the add analysis button, on the horizontal list. It shouldn't do anything. Do we prefer removing it or adding a disabled state?

We are changing it, so the easiest thing for you
https://github.com/CartoDB/design/issues/1071

I don't know if the new add buttons (the ticket sharing https://github.com/CartoDB/design/issues/1071) will release this ticket. These are the examples:
Current button:

New button:

Apart from that, I think we can do:

If the new buttons release after, we can disable the current button (blue box with "+") with a 24% opacity. The same that we use in all UI.
If the new buttons release before; we can add the new buttons with the same disabled state: 24% opacity.

What do you think?

I think this'll release before, hopefully today 🤔
Since it was going to be changed at some point & @piensaenpixel gave me the choice, I removed the button completely. It's simpler than adding a new state to the button, because of how the code is

@urbanphes On ded12 one more time, with the button gone in that particular case

I'm not sure if this is related to, but... in ded12 I only can geocode it with lat and long.

Only one very small thing, if you think we can do it know ok, if not we can do it later:

[] To be consistent, could we put latitude and longitude in the same order?

Label or controls?

y prefer the select (type)

The rest is ok!


TASK: Overhaul documentation

Replace broken API docs links with links to the implementation
Mention new Form packages and their sponsors
Move YAML Builder related documentation to the Neos.Form.YamlBuilder package
Add Neos.Form.Builder screenshot
Update release & version

Merging to trigger documentation rendering..


Compiling libtensorflow_inference.so generates error: "error: undefined reference to 'dl_iterate_phdr'"

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): ('v1.8.0-2153-ge844159e63', '1.8.0')
Python version: 2.7
Bazel version (if compiling from source): 0.13.0
GCC/Compiler version (if compiling from source): 4.9
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce: bazel build //tensorflow/contrib/android:libtensorflow_inference.so    --crosstool_top=//external:android/crosstool    --host_crosstool_top=@bazel_tools//tools/cpp:toolchain    --cpu=x86

I believe this is a bug
When I run the above command, at some point the compiler / linker stops with the following error message:
ERROR: /home/karsten/.cache/bazel/_bazel_karsten/c3148022e5394457e9b87b7ac08211f4/external/protobuf_archive/BUILD:259:1: Linking of rule '@protobuf_archive//:js_embed' failed (Exit 1)
/usr/local/google/buildbot/src/android/gcc/toolchain/build/../gcc/gcc-4.9/libgcc/unwind-dw2-fde-dip.c:461: error: undefined reference to 'dl_iterate_phdr'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Target //tensorflow/contrib/android:libtensorflow_inference.so failed to build
Use --verbose_failures to see the command lines of failed build steps.
I have not injected any custom code.

Hi drpngx, I did compile and install everything from source following the manual. Are you suggesting an overall clean and recompile? Potentially with different settings?

+1

I don't see the nightly jenkins build anymore either...

@drpngx  I face the same issue. I just pulled everything from master and tried to build the inference interface but I ran into the same error. I use bazel 0.14.

hi @saeed68gm ,  do you resolve the problem? I just get this issue when I use bazel build any cpu.


Closing not working as excepted

Hi
The close() function is implemented, but in my opinion it does not have the desired behavior.
It looks as if an event listener is still running. This can be tested with the following app.
In my prototype I would like to use multiple instances of:
const rl = readline.createInterface({
    input: new tty.ReadStream(0),
    output: new tty.WriteStream(1),
  })

to switch between a chat module and the main CLI.

Another possibility would be to use pause() or resume() which are inherited from the Readable class.

What exactly do you mean by "it looks as if an event listener is still running"?

Haha sry for the weak description.
But what I meant is that when I close the interface rl.close(), an input from the terminal is still running and is also processed via _onkey.

Tried to replicate the problems below
import tty from 'bare-tty'
import readline from 'bare-readline'

const rl = readline.createInterface({
  input: new tty.ReadStream(0),
  output: new tty.WriteStream(1),
})

/* When using MODE_RAW the beavior is optimal, but Ctrl+C is not working
rl.close() is not working */
rl.input.setMode(tty.constants.MODE_RAW)

/* When using MODE_IO Ctrl+C is working, but not Ctrl+D
But the beavior is not optimal with the input repeating randomly
rl.close() is not working */
// rl.input.setMode(tty.constants.MODE_NORMAL)

/* When using MODE_IO Ctrl+C is working, but not Ctrl+D
But the beavior is not optimal with the input repeating randomly
rl.close() is not working */
// rl.input.setMode(tty.constants.MODE_IO)

rl.on('data', line => {
  if (line === 'exit') {
    rl.close()
    return
  }
  console.log('\r\n' + line)
  rl.prompt()
}).prompt()

Ah, I see the issue! The module wasn't detaching from input on readline.close() which has been fixed in https://github.com/holepunchto/bare-readline/commit/40045ce0e9504c6fc3794cb45b36ab7515175bba.


Add option to avoid managing of webhooks

Add an option to not have the GHPRB manage its webhooks.  This is preferable in cases where we have a lot of projects pointing at the same repo, or when the ghprb account has no admin access to the repo

@DavidTanner Any ideas on this failure? I can't repro locally

Maybe try changing something mundane to get the build to run again.

test this please


Add a "validate" command?

On Green (and soon on Monster), CI for WDL development follows the pattern:

Run a WDL against some collection of input JSONs
Wait for all the runs to complete
Feed the outputs of each run into a "validation WDL", along with a corresponding set of "truth" inputs
Wait for all the validation runs to complete

The test runner has typically had special knowledge about each pipeline, but it feels like it should be possible to generate the core functionality.
I'm not sure if cromwell-tools would be the best place for that functionality to live (maybe there could be a new cromwell-test-tools package?), but here's an idea for what the command might look like:
$> cromwell-tools validate -h
usage: cromwell-tools validate [-h] [-c CROMWELL_URL] [-u USERNAME] [-p PASSWORD]
                               [-s SECRETS_FILE]
                               --wdl-file WDL_FILE
                               --validation-wdl-file WDL_FILE
                               [--dependencies-json DEPENDENCIES_JSON]
                               --inputs-batch INPUTS_JSON1:TRUTH_OUTPUTS1
                               [--inputs-batch INPUTS_JSON2:TRUTH_OUTPUTS2 ...]
                               --inputs-json INPUTS_JSON
                               [--inputs2-json INPUTS2_JSON]
                               [--options-file OPTIONS_FILE]

The command would do something like:

Parse the inputs-jsons out of each inputs-batch arg
Submit each input along with wdl-file, dependencies-json, inputs2-json, and options-file using the existing submit logic
Wait for each workflow to finish using the existing wait logic
Query the outputs of each workflow, getting something like: {
   "MyMainWorkflow.out1": "gs://....",
   "MyMainWorkflow.out2": 10
 }

Strip the main workflow's name from the outputs, and combine with the truth outputs to build an input JSON for the validation WDL:{
  "ValidateMyMainWorkflow.test": {
    "out1": "gs://....",
    "out2": 10
  },
  "ValidateMyMainWorkflow.truth": {
    "out1": "gs://....",
    "out2": 20
  }
}

Run the validation WDL on each of these constructed inputs using the existing submit logic
Wait for each validation run to finish using the existing wait logic

Does this sound like logic that'd make sense to live in cromwell-tools? I'd be happy to put a PR together for it if so.

Generally it looks like a great feature to have, I have some detailed questions:

Personally, I figured validate implies more about "validate inputs for a workflow", and it doesn't need to concern about the results once we submit the workflow, wait and probably validate-results/validate-outputs should take care "validate outputs for a workflow".

In the The command would do something like: section, 1-4 are very reasonable and consistent with where we want this lib to go. I have some concerns about 5-7 though:

Adding the ability to start a validation WDL will introduce extra dependencies to cromwell-tools, making it more than a simple standalone Python API of Cromwell. Specifically, besides dealing with the response error codes from Cromwell, we will need to parse and real with various possible errors raised by the validation WDL(I guess?).
I agree this feature could live in the cromwell-tools code base, but it'd be better to put this feature/tool separate from the core APIs(submit/abort/query/) that are mapped from Cromwell endpoints and make it optional.
I'm not familiar with the validation WDL here, but given the broad uses cases of the WDL, I assume it must be portable to nearly most of the workflows and just simply checks the checksums/sizes/existence of the WDL. So if I'm correct here, can we simplify th checks/validations and make them happen in Python rather than in WDL/Cromwell? If I'm wrong here, it will get more complicated, we might end up having overhead like how to version control the validation WDL with the Python lib, how to make it compatible to all workflows, etc...

👍 to a separate module for test utilities. Am also open to tweaking the naming.
Some clarifications:
The goal is to push all custom logic for checking the outputs of a pipeline into a corresponding validation WDL, so the code in the test framework doesn't have to be extended for every new pipeline. For example, here's the validation WDL used by Green for the germline single-sample workflow, and here's the workflow they use the validate the genotyping arrays workflow. The comparisons performed are usually more complicated than a bitwise diff, so you end up wanting to run the logic in the cloud.
To really make the test harness work for any given scientific-WDL/validation-WDL pair, we'd need to rely on some convention about how the outputs of the scientific WDL map to the inputs of the validation WDL. As a rough idea, we could say if your scientific WDL has outputs:
output {
  Int my_int_output
  Array[String] my_string_array_output
  File my_file_output
}

Then the paired validation WDL should know about a struct of the shape:
struct ExpectedOutputs {
  Int my_int_output
  Array[String] my_string_array_output
  File my_file_output
}

And take as input:
input {
  ExpectedOutputs test_outputs
  ExpectedOutputs truth_outputs
}

The test runner could then have some generic logic that transforms output JSON of the scientific WDL into input JSON for the validation WDL.
A less magical alternative would be to have the validation WDL take the raw outputs JSON from the scientific WDL as input:
input {
  # i.e. "{\"MyWorkflow.my_int_output\":1,\"MyWorkflow.my_string_array_output\":[],\"MyWorkflow.my_file_output\":\"gs://path/to/the/file.bam\"}"
  String escaped_test_output_json
  String escaped_truth_output_json
}

The first task in validation would then have to parse the JSONs and extract out the data-to-compare.
For watching/interpreting validation outputs, an easy first pass would push the work onto the validation-WDL-write by setting up another convention: if test outputs don't match truth outputs, the validation WDL should fail. Then a generic wrapper around the existing wait command would be enough to catch failures.

I looked at how Mint currently handles this style of testing. They use subworkflows, with the checker WDL importing and running the scientific WDL as its first step. This has the benefits of:

Not needing magic conventions to thread scientific outputs into checker inputs
Not needing extra code in cromwell-tools

So, closing this!


ISPN-5542 Shorten interceptor stack for local caches

fixed javadoc, XSD and moved the attributes to Parser80 instead of Parser72

We need server configuration to stay symmetric with embedded, so please add it to the subsystem as well

@tristantarrant Thanks for reminding, I have added those. Though, I am not sure whether notifications should really be in server configuration since you can't register listeners on server anyway, but I've included those to keep the config symmetric.

Integrating, please format commit messages appropiately (see here)

Integrated after shorting out format (add a empty line between title and comments)


About units of params Accel Random Walk and Rate Random Walk

Hi author,
Thanks for your sharing so convient tool to community very much.
In code we average three axis Accel Random Walk to get accelerometer_random_walk of kalibr.  accelerometer_random_walk's unit is m/s^3/sqrt(HZ), namely m/s^2/sqrt(s), but the Accel Random Walk's unit is m/s^2, is there a typo ?  The same question exist about Rate Random Walk.  Velocity Random Walk and Angle Random Walk units are equal to accelerometer_noise_density and gyroscope_noise_densityof kalibr.   Thanks for your help and time!
https://github.com/ori-drs/allan_variance_ros/blob/25a33882f1fafddc910dbbdb0e2d4858cde009fc/scripts/analysis.py#L121

Hello,
There is actually a typo in the Kalibr documentation as discussed in this issue: https://github.com/ethz-asl/kalibr/issues/354 and in this issue of GTSAM: https://github.com/borglab/gtsam/issues/213
So accelerometer_random_walk should actually be m/s^2 and not m/s^2/sqrt(s),
I believe the other parameters have the same units as in the Kalibr documentation so if there is something not matching, could you be more specific? Thanks

Hi author, thanks for help very very much.
According to kalibr gyroscope_random_walk unit is  rad/s^2/sqrt(Hz), namely rad/s/sqrt(s).  Your Rate Random Walk unit is rad/s, so i mistake there is also a typo in Rate Random Walk, sorry for that.
Maybe kalibr units of \sigma_{bg} and \sigma_{ba} should be corrected by someone. My problem is solved :)

Actually, the Kalibr documentation is correct, and ethz-asl/kalibr#354 and borglab/gtsam#213 are wrong. I've already replied in those two issues.
@narutojxl wrote:

accelerometer_random_walk's unit is m/s^3/sqrt(HZ), namely m/s^2/sqrt(s), but the Accel Random Walk's unit is m/s^2, is there a typo ? The same question exist about Rate Random Walk.

You are correct. The units should be m/s^3/sqrt(s) and deg/s^2/sqrt(s). PR #4 fixes that.

Hi @mintar, thanks for your detailed explaination. I read in your PR4,  and kalibr/issues/354 comment.
sigma_bg unit is (rad/s)/sqrt(s) or (deg/s)/sqrt(s), why it is deg/s^2/sqrt(s) ?
sigma_ba unit is (m/s^2)/sqrt(s), why it is m/s^3/sqrt(s)?
I'm a little confused about this and don't  understand it . Could you please give me some info, thanks a lot.

You were almost correct. The units should be m/s^3/sqrt(s) and deg/s^2/sqrt(s) (or equivalent). PR #4 fixes that.

@narutojxl : Great catch! Yes, you were right all the time. The tables I've posted are correct, but I made a mistake in my comment to you and in #4. I've made a pull request to fix this (#8).

Thanks @mintar :).


Uberjar osgi fixes

https://issues.jboss.org/browse/ISPN-5116

First of all relocating com.google.protobuf to infinispan.com.google.protobuf breaks clients that need to use com.google.protobuf.RawProtobufMarshaller, namely the marshallers generated via annotations.
And if infinispan-remote does not export com.google.protobuf and leaves it for the client code to provide it then you'll get the split package error anyway.
I think exporting com.google.protobuf is the lesser evil, although ideally we should remove the com.google.protobuf dependecy from scratch. Protostream only uses about 4 classes from protobuf jar, so it is very doable.

FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8227/anistor:uberjar_osgi_fixes_anistor for 4374c6143e7e74819babdc5cb32cdf78db3dbab9
Tests: 11154, 4 failed (3 new), 22 ignored. Build time: 02:31:05
Failed tests detected

(new) TestSuite: org.infinispan.statetransfer.ClusterTopologyManagerTest.testClusterRecoveryAfterThreeWaySplit

(new) TestSuite: org.infinispan.client.hotrod.DistTopologyChangeUnderLoadTest.testPutsSucceedWhileTopologyChanges

(new) org.infinispan.server.test.query.ManualIndexingIT.testManualIndexing

(since 22-Dec-2014) org.infinispan.test.integration.as.InfinispanLuceneDirectoryIT

Error message is logged
Build duration (secs) is too large: 9226

@Isavin I refactored protostream to no longer expose com.google.protobuf.* in its API, so exporting com.google.protobuf from infinispan-remote is no longer needed.

FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8257/anistor:uberjar_osgi_fixes_anistor for 4c96f81e57d4fa0a63e8f72eedabc28605a368ab
Tests: 11232, 1 failed (1 new), 23 ignored. Build time: 01:41:36
Failed tests detected

(new) TestSuite: org.infinispan.interceptors.ConcurrentInterceptorVisibilityTest.testSizeVisibility

@isavin None of the failures in CI are related. I think it's fine to integrate this. Should I do it?

Integrated. Thanks @anistor!

FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8283/anistor:uberjar_osgi_fixes_anistor for 4c96f81e57d4fa0a63e8f72eedabc28605a368ab
Tests: 11232, 0 failed (0 new), 23 ignored. Build time: 02:08:59
Error message is logged
Build duration (secs) is too large: 7720


Remove unused functions from tooling API

There don't appear to be any clients using this tooling API entry point.
Also added a note about other known clients for other known tooling API entry points - I've had a quick look around for other third party clients to see if any others are using them, but they're difficult to track down. This can be restored though if needed.

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

  Generated by :no_entry_sign: dangerJS against 5ea09ac00473bec1d339e807e65a121074c419da

@3flex should we mark this as breaking change?

should we mark this as breaking change?

Maybe to be safe - if any clients use it, it will definitely break!


feat(ukb_ppp_eur) dags refactoring

Context
We want to be able to run the harmonisation and perform susie finemapping batch job within the orchestration for ukb_ppp_eur data.
This PR summarizes the developments over the processing of the

ukb_ppp_eur_harmonisation (harmonisation + locus breaker) that results in the study_locus dataset partitioned by studyLocusId (run via dataproc)
ukb_ppp_eur_finemapping (finemapping manifest generation + susie finemapping) that results in the credible_set dataset partitioned by studyLocusId. (run via google batch)

To run the harmonisation, some steps needs to be pre-executed before. I have described these steps in the docs along with the data structure.
Additional tasks

[x] Consolidated structure for batch operators (VEP and fine-mapping) in the package.
[x] New function to extract partition from path.
[x] Additional parameters AllocationPolicy added to the create_batch_task function.
[x] Cleaned old data in ukb_ppp_eur_data and uploaded new datasets from last successful run of the dags.
[x] Updated README documentation for the ukb_ppp_eur_data bucket.
[x] Added a brief description of the fine-mapping step
[x] Fixed issue with dataproc jobs that used the local[*] by default instead of yarn.
[x] Readded the idle timeout for cluster deletion.
[x] Added graphviz as a dev dependency to generate dag svgs.
[x] Added instruction on how to generate dag svg.

[!NOTE]
The yarn configuration option will now be added automatically to the dataproc steps

I tried to read the outputs but the study_validation step struggles to read the directory. Most likely because the directory contains the logs:
❯ gsutil ls 'gs://ukb_ppp_eur_data/credible_set_datasets/susie/studyLocusId=f6c6edb08ed02502869faea2d46e7c5*'
gs://ukb_ppp_eur_data/credible_set_datasets/susie/studyLocusId=f6c6edb08ed02502869faea2d46e7c5c.log

gs://ukb_ppp_eur_data/credible_set_datasets/susie/studyLocusId=f6c6edb08ed02502869faea2d46e7c5c/:
gs://ukb_ppp_eur_data/credible_set_datasets/susie/studyLocusId=f6c6edb08ed02502869faea2d46e7c5c/
gs://ukb_ppp_eur_data/credible_set_datasets/susie/studyLocusId=f6c6edb08ed02502869faea2d46e7c5c/_SUCCESS
gs://ukb_ppp_eur_data/credible_set_datasets/susie/studyLocusId=f6c6edb08ed02502869faea2d46e7c5c/part-00000-e1d26427-69b6-473b-a6fb-d5c470f28280-c000.snappy.parquet
gs://ukb_ppp_eur_data/credible_set_datasets/susie/studyLocusId=f6c6edb08ed02502869faea2d46e7c5c/part-00003-e1d26427-69b6-473b-a6fb-d5c470f28280-c000.snappy.parquet

Error in study validation:
https://console.cloud.google.com/dataproc/jobs/02873e9e-e3f2-4618-9ad5-03d1bb417396/monitoring?region=europe-west1&project=open-targets-genetics-dev
py4j.protocol.Py4JJavaError: An error occurred while calling o114.load.
: java.lang.AssertionError: assertion failed: Conflicting directory structures detected. Suspicious paths:
	gs://ukb_ppp_eur_data/credible_set_datasets/susie
	gs://gwas_catalog_sumstats_susie/credible_sets
	gs://eqtl_catalogue_data/credible_set_datasets/eqtl_catalogue_susie
	gs://gwas_catalog_sumstats_pics/credible_sets
	gs://gwas_catalog_top_hits/credible_sets
	gs://finngen_data/r11/credible_set_datasets/susie

Thanks @d0choa, I think that the paths were moved manually before
For now I have added a single dag step to move the log files, although it is very slow due to the amount of files to transfer. I think it would be better to update the gentropy command to get as input the path to log file and save the log file path in the partial manifests that are generated before the batch job is run.
Not ideal, but batch is way less flexible then dataproc :/


Load the viewer inside a div

Hello,
Is it possible to open the cleverdox viewer inside a div and not outside my application?
I need to add additional buttons related to my application as top bar menu of the viewer.
Thx,

could be realized in windows via css.
not possible in ios nor android.


Give the render method the possibility to decide if a chip should be created.

This PR gives the render method the possibility to decide if the text should be added as a new chip.  Also the text isn't cleared if no chip was added.
This is useful if I'm only allowed to add text validated by a regular expression, if I don't want to add duplicates, ...
I thought to introduce a dedicated validate method but that's maybe too much for this case. As such the alternative to letting the render method return null if nothing should be added ...

Hi,
Thanks for the PR.
you mentioned. text isn't clear if no chip added. could you please create codepen example for the same so then it's easy to figure out the issue.
Also we have render method to avoid duplicate entries so please check this link http://blog.imaginea.com/angular-chips-documentation/ for documentation.
Thanks
Mohammed Basheer

Hi @mohbasheer ,
Thanks for the nice control by the way!
But what I'm trying to do is:

User enters text (eg an email address)
I want to only add a chip when the email is valid (eg contains '@')
I'm using the render method for this.  In the render callback I return null when the text is not valid (doesn't has a '@')
In that case addChip will return false
And at that moment I don't clear the text in the input field since the the text was not added as a chip so the user can continue to edit

I will check the documentation also though since I was thinking every text resulted in a chip after clicking enter.  I didn't find a way to avoid this since the result of the render method is always added.
Would using the promise based alternative be the solution here?
kr,
Koen

I got you. I'll let you know tomorrow in my day time.
Thanks Man.


Shard-level cutover and cutoff logic for agg tier topology changes

cc @cw9 @jeromefroe @martin-mao
Client-side change to support cutting over / off writes to a shard based on shard-level cutover and cutoff times in the agg tier placement to gracefully handle agg tier topology changes.

Coverage decreased (-0.3%) to 95.096% when pulling 3f24947759113b99d906430b570801ab7c1f511f on xichen-agg-topology-change into f8c6b317a7e77550e57acbaadb069dcb5527a7bf on master.

Coverage decreased (-0.3%) to 95.096% when pulling 3f24947759113b99d906430b570801ab7c1f511f on xichen-agg-topology-change into f8c6b317a7e77550e57acbaadb069dcb5527a7bf on master.

Coverage decreased (-0.2%) to 94.039% when pulling 30c88d49cffd9821eba7df6cc7ef767dda6f67dd on xichen-agg-topology-change into a10ea6e815070e86e58ba7eaa18dd3d0ed69fbc6 on master.

Coverage decreased (-0.02%) to 94.245% when pulling 30c88d49cffd9821eba7df6cc7ef767dda6f67dd on xichen-agg-topology-change into a10ea6e815070e86e58ba7eaa18dd3d0ed69fbc6 on master.


[rhol_crc] Increase default memory

Recent CRC(v2.34.1) have bumped minimum memory requirement[1] to 10752 MB,
updating the same in the role defaults.
[1] https://github.com/crc-org/crc/commit/7e694ae
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

recheck

/approve

/lgtm


Updated descriptions for Vector2.reflect and Vector2.slide

Replaced with the updated descriptions from 3.0 docs, see https://github.com/godotengine/godot-docs/issues/1078

As I mentioned on godotengine/godot-docs#1078, that's not sufficient for the 2.1 docs. You don't "specify the normal vector" in 2.1, you have to call this method on the normal vector, to slide the vector "vec" given as argument.

Slide:

Old: Slide returns the component of the vector along the given plane, specified by its normal vector.
New: Slide returns the component of the given vector along the plane specified by its normal vector.

Reflect:

Old: Reflects the vector along the given plane, specified by its normal vector.
New: Reflects the given vector along the plane specified by its normal vector.

Would this work?

Merged manually as dd1cbd847 with added examples for clarity.


Don't load .bootloader-config section when loading kernel

Since .bootloader-config isn't used by the kernel (I think that's a safe assumption to make), it doesn't need to be loaded into memory when loading the kernel.

That would require us to set the section as NOLOAD (or not allocated?), which isn't currently possible in Rust, barring custom linker scripts.


Form.io Create Form Help

Hey @StephenOTT ,
I looked through the documentation and was not able to find much on the actual creation of forms so I thought I would start a thread and help make a better tutorial.
Here are the steps I have done:

Create Account on Form.io
Create New Form
Copy Embed JSON to Local File "Form.json"
Paste Form Key "embedded:/forms/formio.html?deployment=Form.json
Deploy through Postman
Start Process Manually

When I tested the process in the tasklist I did not get any form and I'm not sure where to start testing.
What would you suggest?
<?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" id="Definitions_1hf56xc" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="4.1.1">
  <bpmn:process id="FormIOTest" isExecutable="true">
    <bpmn:startEvent id="StartEvent_1">
      <bpmn:outgoing>Flow_10lpabf</bpmn:outgoing>
    </bpmn:startEvent>
    <bpmn:sequenceFlow id="Flow_10lpabf" sourceRef="StartEvent_1" targetRef="Activity_1cwkjt5" />
    <bpmn:userTask id="Activity_1cwkjt5" name="Test Form" camunda:formKey="embedded:/forms/formio.html?deployment=Form.json&var=subWithServerValidation">
      <bpmn:incoming>Flow_10lpabf</bpmn:incoming>
      <bpmn:outgoing>Flow_1n9zxzx</bpmn:outgoing>
    </bpmn:userTask>
    <bpmn:endEvent id="Event_161cw66">
      <bpmn:incoming>Flow_1n9zxzx</bpmn:incoming>
    </bpmn:endEvent>
    <bpmn:sequenceFlow id="Flow_1n9zxzx" sourceRef="Activity_1cwkjt5" targetRef="Event_161cw66" />
  </bpmn:process>
  <bpmndi:BPMNDiagram id="BPMNDiagram_1">
    <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="FormIOTest">
      <bpmndi:BPMNEdge id="Flow_1n9zxzx_di" bpmnElement="Flow_1n9zxzx">
        <di:waypoint x="380" y="117" />
        <di:waypoint x="452" y="117" />
      </bpmndi:BPMNEdge>
      <bpmndi:BPMNEdge id="Flow_10lpabf_di" bpmnElement="Flow_10lpabf">
        <di:waypoint x="215" y="117" />
        <di:waypoint x="280" y="117" />
      </bpmndi:BPMNEdge>
      <bpmndi:BPMNShape id="_BPMNShape_StartEvent_2" bpmnElement="StartEvent_1">
        <dc:Bounds x="179" y="99" width="36" height="36" />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNShape id="Activity_09bbdei_di" bpmnElement="Activity_1cwkjt5">
        <dc:Bounds x="280" y="77" width="100" height="80" />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNShape id="Event_161cw66_di" bpmnElement="Event_161cw66">
        <dc:Bounds x="452" y="99" width="36" height="36" />
      </bpmndi:BPMNShape>
    </bpmndi:BPMNPlane>
  </bpmndi:BPMNDiagram>
</bpmn:definitions>

see:
https://github.com/StephenOTT/camunda-formio-plugin#building-forms
https://github.com/StephenOTT/camunda-formio-plugin#deploying-your-forms
There is no account on formio.io that is required.

Did you make progress.

Sorry, just been slammed with so many technologies at once.  OpenStack, OpenShift, Camunda, etc. :)
I need to get back to it.

You inspired me to test it and after going through it with fresh eyes, I found a few things I neglected before and now it is working.
I would love to know how we can help...  It seems we are all on the same path...
Thanks for all your help...


Update pyproject.toml

Updated with the Author and Project URL to github to reflect in PyDigger

I don't use poetry to build my back-end, moreover the information you added is already covered under [project]
Hence closing this PR


requestIdleCallback not work

The requestIdleCallback doesn't work on here, I tested in master branch.
We can just run requestIdleCallback(() => alert(1)) for reproduce this issue. Maybe we can include TimerExample to UIExplorer. (currently not in macos)

Thanks for posting issue. Currently, I'm on syncing with RN upstream, fixing more than 300 merge conflicts and the whole bunch of breaking changes (Yoga, React/ namespace, and hundreds other). Right after this, I'll take a look at this.

I know, i"m probably too late, but this has been fixed in 0.15.2.


Module 1: Hello Microverse Project

Add the following files:

HTML
Style
test.md
README.md
License[MIT]

Configured:

Webhint
Stylelint
Git Actions YAML
Gitignore

Thank you @cynthiainga .Will I get any notifications on the dashboard? Currently, the status reads, submit.

Thank you @cynthiainga .Will I get any notifications on the dashboard? Currently, the status reads, submit.

You just need to merge this PR then submit it to your dashboard 👍


Document server affinity and load balancing considerations

Multi-statement transactions and eval/invoke with server fields require E-node affinity. We should document this.

The MST part of this issue was addressed in a previous release. As for eval/invoke:
After a brief discussion with Erik, I'm pushing this one, too, with the same caveat that I will pull it into 3.0-4 if everyone runs out of other things to do and has time to think about this. Reason is that sorting out even just the eval/invoke context across all the layers (REST,XDBC, Node.js, Java) isn't going to be a quickie.

Since there is still no data, there will be no documentation in 9.0-1. This seems likely to languish eternally since no one on the dev team owns it, and it is not even clear which one of them should own it.
For lack of a better idea, I will assign to Nalini to find an owner on her team.

There's no writeup for eval/invoke, as per the discussion of this task in bugtrack. However, I wrote up more detailed coverage for the transaction context, based on Sam's wiki writeup, as part of Java Client 4.0.2 and ML 9.0-2. You can find it here:
http://docs.marklogic.com/guide/node-dev/transactions#id_39877
If more than this is required, then you'll have to let me know what it is. Otherwise, I would imagine you can close this.

@jmakeig Can this be closed?


Cache the values of uniforms

Do you mean cache them so if you pass the same reference to a uniform struct, it won't call glUniform* again?

Don't call glUniform if possible.

makes sense.

Done in #711


fix: code cleanup in inventory converter helper

flake8:

2 E265 block comment should start with '# '
4 E302 expected 2 blank lines, found 1
1 E305 expected 2 blank lines after class or function definition,
found 1

Without this master fail: https://github.com/bluebanquise/bluebanquise/runs/819906192


Don't include numTotalErrors in Log(0) messages

Putting a value like numTotalErrors in a Log(0, ...) message means it's always changing in the WebUI. Removing it allows the WebUI to display the message once with a count of the times it's seen that message. Still output the numTotalErrors to the log however.

Fixed in next release


Source Detail: Narrow window formatting is bad

On the source detail page, if I make my window narrow the page looks like this. The CantusID/Incipit search should not be located where it currently is on the page.

Note: Chant detail page has the same problem

Right. I agree that it is showing up where it should since the sidebar tucks under the main content, but yes I think it should go above the main body when the page is narrow. I suppose it doesn't really matter too much either way, though. We can close this issue if you think it's best to leave it as is.

Assigning a priority of low; this would be a nice thing to address at some point, though!
It's also a bit awkward, currently, how the sidebar is wider than the main content when it tucks underneath (see the left edge in the screenshots). Hopefully this can be fixed, too, when we move the search box.

agreed that this looks weird currently. Maybe if they were both the same width and there was space between the end of the chant and the search, it would make more sense visually, though.

see also #472

with #1332, this is complete!


feature: add client debug flag

add client debug flag, so we can get more debug info when running
pouch commands
Signed-off-by: Chuanyun Li<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Add debug flag in client. So we can get more debug infos when running pouch commands
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Add debug flag in client. So we can get more debug infos when running pouch commands
Ⅳ. Describe how to verify it
root@ubuntu-1:~# ./pouch/pouch volume create -D -n volume2  -l like=football -s host=ubuntu1
INFO[0000] start client at debug level
DEBU[2018-04-27 11:41:50.937401046] create a volume: volume2, options: [], labels: [like=football], selectors: [host=ubuntu1]
Labels:       map[backend:local hostname:ubuntu-1 like:football]
Mountpoint:   /mnt/local/volume2
Name:         volume2
Scope:
Status:       map[sifter:Default]
CreatedAt:    2018-4-27 11:41:50
Driver:       local

Ⅴ. Special notes for reviews

Codecov Report

Merging #1234 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
- Coverage   15.36%   15.34%   -0.02%
==========================================
  Files         172      172
  Lines       10629    10640      +11
==========================================
  Hits         1633     1633
- Misses       8876     8887      +11
  Partials      120      120

Impacted Files
Coverage Δ

cli/cli.go
0% <0%> (ø)
:arrow_up:

LGTM


Update README.md

Added a collection of Top Websites to practice coding.

Salamaaatsuuu @coder-ralph


Cannot post data to HTTP source module

As a user, I have http --port 9000 | cassandra and http --port 9001 | jdbc streams running in YARN; however, I'm unable to post data to http://localhost:9000 or http://localhost:9001 endpoints. The request fails with 404 errors.
Reason:
In a YARN cluster, we do not know where the http modules (boot applications) are hosted. They're randomly distributed by YARN's AppMaster. It is impossible to guess the node where they're hosted.
Possible solution:
Leverage spring-cloud components to register where http modules are hosted, so they're discoverable for futures.

POC: https://github.com/jvalkeal/spring-cloud-dataflow-admin-yarn/commits/gh27-poc
more info in this commit: https://github.com/jvalkeal/spring-cloud-dataflow-admin-yarn/commit/d63752d2862dca434508b64c5b9ad6c8d13b8d87

Ran this and it works as advertised. Concern is additional services to run - admin + zuul + eureka and we'd need two of each for HA. Wonder if they could be combined into single runtime for fewer nodes needed in Ambari cluster config? Also, I think we should name the projects after the functionality rather than implementation - dataflow-zuul -> dataflow-proxy and dataflow-eureka -> dataflow-service-registry

Naming is probably better without zuul/eureka and I think functionality can be combined. Just wanted to have clear features in separated jars in this poc.
If going forward with these ideas, we need to for think about a future of a module launcher because the black magic I did with that boot auto-config jar for eureka client kinda relates to how deps are pulled in when modules are run.

closing this poc pr as concept has been reviewed.


Uploading image right from CKEditor

Is this supported? Looks like there was a big change on the last version that moved everything to another app(Though I think this wasn't necessarily. Was there a discussion on this?). How can I upload images right from the editor?

Nevermind, got it working by changing the CKEditorWidget to the new CKEditorUploadingWidget

thanks!! for this comment, i think will be useful if add this to the docs. in the widgets section. like Field

It's already there ;)


Which structure of RNN is implemented by SimpleRNN in keras?

Two types of RNN can be used:
Type1: The output is being used as state
h(t) = g(W1.x(t) + W2.h(t-1) + b1)
Type2: There is a state in addition to the output
a(t) = g(W1.x(t) + W2.a(t-1) + b1)
h(t) = g(W3.a(t) + b2)
I know both of them can be used, but I want to be sure which one is imlemented in keras. So, which of the above mathematical structure is implemented by SimpleRNN in keras? I tried looking at the documentation, but its unclear.

Looking into the code, the SimpleRNN  is your Type1.
For achieving your Type2 (aka, Elman network), one could add a TimeDistributed(Dense(...)) layer on top of the SimpleRNN.


Patch for latest PocketMine-MP API 5 Beta

Did you tested it ? I'm pretty sure there's more change

Oui, I run this changes on a builder server, it works well


fix(ci): move concurrency rules from steps to workflow top level

Summary
partially closes #819
this has the side-effect that we will no longer have ci on branches that are not linked to a pull request or a release branch
Checklist

[ ] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[ ] I have formatted the code properly by running task lint
[ ] I have type-checked the code by running task pyright

[ ] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[x] This PR is not a code change (e.g. documentation, README, ...)

this has the side-effect that we will no longer have ci on branches that are not linked to a pull request or a release branch

seems like a pretty significant side effect, is there a reason for that?

this has the side-effect that we will no longer have ci on branches that are not linked to a pull request or a release branch

seems like a pretty significant side effect, is there a reason for that?

There isn't a good way to keep ci running on any branch and also have the ci run on pulls from forks as well. There isn't a way to restrict ci in the manner that we would like.
As a stop gap, we can add a option to run on branches matching run-ci/ or something of the like so we can run ci on a branch without making a pull request?

this has the side-effect that we will no longer have ci on branches that are not linked to a pull request or a release branch

seems like a pretty significant side effect, is there a reason for that?

There isn't a good way to keep ci running on any branch and also have the ci run on pulls from forks as well. There isn't a way to restrict ci in the manner that we would like.
As a stop gap, we can add a option to run on branches matching run-ci/ or something of the like so we can run ci on a branch without making a pull request?

I've added the stop gap measure in https://github.com/DisnakeDev/disnake/pull/851/commits/12b069e25810a2a1275cb2a5ba4074610ea6c56c.


fix grammar

Closes #21

PR-Codex overview
The focus of this PR is to update the BNF Converter generated files in the eo-phi-normalizer project.
Detailed summary

Updated the Bytes token definition in Par.y and Lex.x files.
Updated the Function token definition in Lex.x file.
Updated the literals and reserved words in Doc.txt file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

This has already been fixed in https://github.com/objectionary/normalizer/pull/9/commits/9f4c9acf50f1d1a8d0b49a21bcc2eb508a35bc2d, but #9 is not merged yet. If we do not plan on merging it soon, I suggest creating another branch at that specific commit and merging it instead to avoid conflicts

That fix was partially incorrect. See https://github.com/objectionary/normalizer/commit/9f4c9acf50f1d1a8d0b49a21bcc2eb508a35bc2d#r136677204


Add documentation for Query.jl

@nalimilan Here is a first go at a section for the doc that deals with Query that you suggested. My idea was to give a hint of how things work, and then point folks to the Query documentation.

@nalimilan Thanks for the great feedback! I think I addressed all your points.
When I run make.jl locally, the docs don't seem to pick up the stylesheet, so I have a hard time checking the final look here. I don't understand why that is happening because I use pretty much the same setup for the Query.jl documentation, and there everything works great locally...

When I run make.jl locally, the docs don't seem to pick up the stylesheet, so I have a hard time checking the final look here. I don't understand why that is happening because I use pretty much the same setup for the Query.jl documentation, and there everything works great locally...

Sorry, no idea. I'm not familiar yet with Documenter.jl
Not sure if that's expected, but on Julia 0.6, I get this error if I don't load NamedTuples in addition to Query:

julia> q1 = @from i in df begin
                   @where i.age > 40
                   @select {number_of_children=i.children, i.name}
                   @collect DataFrame
              end

ERROR: UndefVarError: @NT not defined

When I run make.jl locally, the docs don't seem to pick up the stylesheet, so I have a hard time checking the final look here.

I'll have a look, not come across missing stylesheet problems before.

@davidanthoff the stylesheets are loading alright for me on a local build of this branch. What are you versions of Documenter and Julia? Which web browser are you viewing the docs in?

I get this error if I don't load NamedTuples in addition to Query

I need to tag a new version, things should work on Query.jl master.

What are you versions of Documenter and Julia? Which web browser are you viewing the docs in?

julia is 0.5.0 on Windows, Documenter is 0.6.0. I narrowed the problem down: The link to "Querying frameworks" in the navigation area on the left is file:///C:/Users/anthoff/.julia/v0.5/DataFrames/docs/build/man//querying_frameworks.html. Note that there are two / between man and querying_frameworks.html. When I click that it shows the content of that page, but the stylesheets are messed up. If I then manually remove the second /, everything looks correct.
So I think all that needs to be done is make sure that there are no two / in a row in the URLs.

Can you change examples into doctests then?

Can you change examples into doctests then?

Done.

There are conflicts with master.

I probably missed a conversation somewhere about it, but why are we running Query doctests from DataFrames?

@ararslan @nalimilan suggested that we add a section about query frameworks to the documentation, and also that I convert the examples into doc tests.

The idea is that if we don't ensure examples work and give the expected result, they will stop working at some point (witness the recent issue with constructor examples).

@davidanthoff Can you just make the move to @example so that we can merge this? Thanks!

I just tried to implement the @example thing, but at least on my system it doesn't splice the results from the last line of such a block into the output. I'm on Windows trying this with Documenter v0.7.1.
Maybe we should merge this PR at this point, given that it works, and then we can still change this at a later point?

I just tried to implement the @example thing, but at least on my system it doesn't splice the results from the last line of such a block into the output. I'm on Windows trying this with Documenter v0.7.1.

@MichaelHatherly Any suggestions?

Maybe we should merge this PR at this point, given that it works, and then we can still change this at a later point?

We can certainly do that if @example doesn't work, but I'd rather do it before merging if that's not too hard.

With the following diff everything displays as it should on Linux/Windows Julia 0.5: https://gist.github.com/MichaelHatherly/48f57ea5a60e0334e1cfc77feb68b4f4.

Thanks, now it seems to work, I must have missed something yesterday.
The DataFrame display formatting is pretty messed up. I think there is actually a bug both in the DataFrame show method and in Documenter here.
Also is there some way to have some text between the code example block and the output? Right now there is no visual indication that one is code and the other one is output, which looks strange to me.

Just as an aside, it's best to avoid using @ in commit messages, as it always pings the GitHub user with that name. Common replacements would be "example macro" or "at-example."

Is there no way to check the output of @example like with doctests?

I don't think so.

@MichaelHatherly?

(Sorry, been busy with non-Julia things.) There's no way to check @example output other than using a jldoctest block instead — I've not come up with any kind of satisfactory middle ground between the two.

The DataFrame display formatting is pretty messed up. I think there is actually a bug both in the DataFrame show method and in Documenter here.

Is this the character width for the unicode chars that form the table frame? If so there's not much that can be done in Documenter I don't think aside from changing the font again to something that properly supports those characters.

Also is there some way to have some text between the code example block and the output? Right now there is no visual indication that one is code and the other one is output, which looks strange to me.

Probably can do. Proposals/PRs for style changes to the output would definitely be welcomed.

(Sorry, been busy with non-Julia things.) There's no way to check @example output other than using a jldoctest block instead — I've not come up with any kind of satisfactory middle ground between the two.

OK, though that's kind of unfortunate. Any plans to change this in the future? I don't like encouraging people to write untested examples...

Thanks @davidanthoff!

Hm, when I look at this here now it doesn't show any of the example output...

I don't like encouraging people to write untested examples...

@example will still print a warning when any errors are encountered, which can be turned into an error by calling makedocs with the strict = true keyword. Not quite as thorough as a unit test of course, kind of more like a Jupyter notebook cell really.

Hm, when I look at this here now it doesn't show any of the example output...

Package dependencies need fixing, DataArrays isn't being installed: https://travis-ci.org/JuliaStats/DataFrames.jl/jobs/175315815#L277

Why not make the strict=true behavior the default? I don't see the use case for building docs with errors in them.

Why not make the strict=true behavior the default?

That would be quite a bad breaking change. strict=true will error out when anything is slightly wrong, such as not including all docstrings in the generated docs — for example, building DataFrames docs lists quite a large number that haven't been included in @docs blocks.

I don't see the use case for building docs with errors in them.

I agree with that, but it does need a gradual deprecation period to not cause too much trouble for all the packages that are currently ignoring those warnings. Since Documenter is currently going through the ssh-key deprecation I'd also prefer to only do one major deprecation at a time.

For what its worth, I think the doctests should actually run as part of the normal test suite, i.e. one should be able to add a line like Documenter.test("DataFrames") to the runtest.jl file in DataFrames, so that the doctests actually run if someone does Pkg.test("DataFrames"). See JuliaDocs/Documenter.jl#198.

For the failure itself: Query currently targets the tagged versions of DataFrames. So I guess this PR here really should go into a release branch for the 0.8.x series of DataFrames... Is there some way to publish new doc versions as stable before the current DataFrames master gets tagged?

Just make a PR against release-0.8, and I'll add a tag so that it appears in the online docs.


Typo in the VehicleHash enum.

It  should be RE7B instead of LE7B.

RE7B's modelName, txdName, handlingId, and gameName are internally named LE7B and not a few vehicles have different names for them. But the 4 names RE7B has are so confusing that many people would think RE7B is missing.

This kind of depends if we wants names that are meaningful or correct. RE7B is much better for devs to work with, but LE7B is the correct name

I would pefer meaningful names over "correct" names, similar to the discussion we had on "Firetruk" vs "Firetruck". Although I noticed this is still "Firetruk". Probably going to change that later. Unless there is major objection.

After this discussion, I realized meaningful names are better than "correct" names for most people.

Is this is a pretty list of names for people too look at, or a scripting tool for developers to produce modifications to the game ?


Intellisense/suggestions don't work

Type: Bug

CSS container queries: VSCode hasn't ever recognised them but now Intellisense is completely broken for them. Media queries do work though, even though they're exactly the same.

Angle brackets don't self close and all the self-closing characters ()[]''{}"" can't be escaped with tab, you have to press the right arrow key. Maybe not a bug but it feels like you should be able to. If you create a snippet for it, it works, but then you can't surround text with them.

Suggestions in general are so terrible it has to be a bug, especially in JS and it doesn't go away with TS. It gives you suggestions for the most random weird things I have never typed in before just because they share the first letter like "getJSDocOverrideTagNoCache", "toUSVString", "stripVTControlCharacters", "collapseTextChangeRangesAcrossMultipleVersions" and "ChannelSplitterNode". Sometimes being more specific with a name suggests it lower on the list. "weit" suggests "WebkitCSSMatrix", "wakeLockSentinal" and "WritableStream" and not my own function "writeJson". It even got "writable" but not the function I just defined. And helpful suggestions like "if" don't make and if statement, it's just "if". Same with fn, for, etc. In CSS a lot of the time it doesn't even show you your variables at all. I guess that makes sense if the variable is in another file and it can't know about it but it works equally badly across all files.

That little lightbulb thing gives the dumbest suggestions too, like in JS it asks if you want to turn a => a * 2 into function(a){return a * 2}. No, I do not. And usually it's not even in the right place.

VS Code version: Code 1.79.2 (695af097c7bd098fbf017ce3ac85e09bbc5dda06, 2023-06-14T08:57:04.379Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.95GB (8.38GB free)

Process Argv
--crash-reporter-id b67b341d-41c8-4d1e-9396-3ff475cbda2c

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

laravel-extra-intellisense
ami
0.6.3

tsl-problem-matcher
amo
0.6.2

vscode-intelephense-client
bme
1.9.5

vscode-eslint
dba
2.4.0

vscode-command-runner
edo
0.0.124

prettier-vscode
esb
9.15.0

code-runner
for
0.12.0

vscode-autohotkey-plus-plus
mar
3.3.1

python
ms-
2023.10.1

vscode-pylance
ms-
2023.6.20

powershell
ms-
2023.6.0

laravel5-snippets
one
1.17.0

synthwave-vscode
Rob
0.1.15

laravel-artisan
rya
0.0.31

language-stylus
sys
1.16.0

intellicode-api-usage-examples
Vis
0.2.7

vscodeintellicode
Vis
1.2.30

volar
Vue
1.8.1

quokka-vscode
Wal
1.0.546

php-debug
xde
1.32.1

Please try again and have one issue per bullet point

Please try again and have one issue per bullet point

But it's all just different aspects of the same issue?

No they are not. The light bulb is a different feature than bracket insertion or completions. CSS is a different language than JS


Whenever i use alignItems: 'center' on a container that is in a react-naviation page, that page just shows up as white.

We're looking to keep questions on our forums and bug reports on our main Expo repo -- please choose whichever you feel is more appropriate for your issue:

Post in our community forums (log in with your Expo developer account): https://forums.expo.io/c/help
File a bug on the Expo repo: https://github.com/expo/expo/issues/new
Request a feature on Canny: https://expo.canny.io/feature-requests

Thanks for reporting the issue you found with XDE!

This sounds like a question for Stack Overflow ("when I use , X happens"), please open it there.


actor shell slimmed down a bit, adjust test

Motivation:
Test fails on macos; Test should be adjusted to reflect smaller shell size
Modifications:
Adjust shell instance size (down)
Result:
passing tests on macos

Flaky test: ClusterLeaderActionsClusteredTests.test_up_ensureAllSubscribersGetMovingUpEvents https://github.com/apple/swift-distributed-actors/issues/971


...This is a bug bounty test... Please do not approve. wivadg

...This is a bug bounty test... Please do not approve. wivadg

Sorry for the spam, checking something


fix: Maybe improve controller metric performance

Closes https://github.com/argoproj/argo/issues/2815
This initial fix caches controller metrics, only causing them to be reloaded when there is a change to the Store.
This might not be enough, however. While expected response time will be significantly lower on average, we would still need to reprocess all existing workflows every time there is a change to one of them.
A better fix would be to keep the metrics in the controller's memory, manually incrementing and decrementing from each status as needed. However, this might involve a slightly more hands-on refactor of the controller code, which should be avoided if possible.

@salanki If I could get your help in testing this fix it would be appreciated. I cannot have more than 100 workflows without crashing my minikube 😄

Does your CI generate snapshot docker images of PRs by any chance? I'm gonna have to test it in the production cluster.

Sure, I’ll get you some images today

Images
simbeh7/argoexec:metrics-perf               5da580b35be1
simbeh7/argocli:metrics-perf                096a7e7c0162
simbeh7/workflow-controller:metrics-perf    103d52aea7e9

Please, please treat these as dev-only images (provided as-is) and sandbox them away from any prod environment.
Thanks for running this test!

@salanki Gentle bump :)

@salanki FYI: We came up with a better solution and the test is no longer needed. Thank you anyway!

@alexec taking over


Introduce Service Instance C/U/D APIs

Introduce Service Instance C/U/D APIs
Motivation
SM has to be able to provision and manage instances directly.
Pull Request status

[x] Initial implementation
[x] Integration tests

Coverage increased (+0.09%) to 88.392% when pulling 35bd29d70839f88fa881e1af3627b3be7ad83807 on write-instance-apis into 95dc15d855e8df20f05f652dee18d0450e6ab071 on master.


TWT-373 Improvements in Cross Plane Provider Documentation

Description of your changes

Thanks a lot your review @mimihalescu :)
I have updated the suggestions.

Hi @rijeshharidas and @mimihalescu please check the PR now and let me know about your comments :)
Actually I will be on vacation next week, so want to close this one.


Add source entry for ros2_openai_server (jazzy)

This is a new package so I'm adding the source entry per https://docs.ros.org/en/jazzy/How-To-Guides/Releasing/Release-Team-Repository.html#create-a-new-release-repository
@brettpac @yassiezar

I'd be fine with chatgpt_server if that floats your boat. I'm aware that I should drop ros2_ from the front

OK, I can live with robosoft_openai_server or robosoft_openai


PowerLauncher leads to Windows Problem Reporting

Microsoft PowerToys version
0.51.1
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Turning on PowerToys Run shows PowerLauncher in Task Manager Processes but within seconds, I get a Windows Problem Reporting that appears with no pop-up that then closes PowerLauncher
PowerToysReport_2021-12-29-11-32-27.zip
✔ Expected Behavior
PowerLauncher to remain open
❌ Actual Behavior
PowerLauncher starts
Windows Problem Reporting appears
PowerLauncher closes with no pop-up.
Other Software
No response

Can you confirm this issue is still relevant in v0.73? /needinfo


ss2tf breaks with zero D matrix

The first order system 1/(s + 1) corresponds to the system A=-1, B=1, C=1, D=0 in State Space. These matrices appear to cause an error in ss2tf. My preliminary testing suggests that this happens when D=0.
import control

A = [[-1]]
B = [[1]]
C = [[1]]
D = [[0]]

control.ss2tf(A, B, C, D)

Results in
  "results may be meaningless", BadCoefficients)
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-1-e684b1d9f8ae> in <module>()
      6 D = [[0]]
      7
----> 8 control.ss2tf(A, B, C, D)

/Users/alchemyst/anaconda3/lib/python3.6/site-packages/control/matlab.py in ss2tf(*args)
    685     if len(args) == 4 or len(args) == 5:
    686         # Assume we were given the A, B, C, D matrix and (optional) dt
--> 687         return _convertToTransferFunction(StateSpace(*args))
    688
    689     elif len(args) == 1:

/Users/alchemyst/anaconda3/lib/python3.6/site-packages/control/xferfcn.py in _convertToTransferFunction(sys, **kw)
   1129             # print(den)
   1130
-> 1131         return TransferFunction(num, den, sys.dt)
   1132
   1133     elif isinstance(sys, (int, float, complex)):

/Users/alchemyst/anaconda3/lib/python3.6/site-packages/control/xferfcn.py in __init__(self, *args)
    164                     data[i] = [[array([data[i]])]]
    165             elif (isinstance(data[i], (list, tuple, ndarray)) and
--> 166                     isinstance(data[i][0], (int, float, complex))):
    167                 # Convert array to list of list of array.
    168                 if (isinstance(data[i][0], int)):

IndexError: too many indices for array

I am using Anaconda on Python 3.6. I installed control using pip. I attach my full environment file
I receive similarly perplexing errors when "round-tripping" transfer functions via state space. I tried this because I was worried about the forms of my matrices:
def roundtrip(num, den):
    G = control.tf(num, den)
    Gss = control.ss(G)
    return control.tf(Gss)

Now, roundtrip([1, 1], [2, 1]) works as expected, but roundtrip([1], [1, 1]) gives the same error as before, and so on for higher order denominators as well: roundtrip([1], [1, 1, 1]) also fails.
environment.txt

I can reproduce this on 0.7.0, but not on HEAD.  Using git bisect, I found that this was fixed in 020734dc.

Thank you!

This issue persists. Unfortunately I have exactly the same problem. using the version 0.7.0 with python 2.7 . When the D matrix is zero, I get the same error.