[Task] investigate error when running migrations on spark production

reproduction steps

ssh to spark production instance
cd /opt/spark/latest
./knex migrate:latest

expected

no migrations run / no errors

actual
$ ./knex migrate:latest
WARNING: NODE_ENV value of 'production' did not match any deployment config file names.
WARNING: See https://github.com/lorenwest/node-config/wiki/Strict-Mode
Using environment: production
Knex:warning - migrations failed with error: drop table `volunteers_delete` - ER_ROW_IS_REFERENCED: Cannot delete or update a parent row: a foreign key constraint fails
Error: ER_ROW_IS_REFERENCED: Cannot delete or update a parent row: a foreign key constraint fails
    at Query.Sequence._packetToError (/opt/spark/latest/node_modules/mysql/lib/protocol/sequences/Sequence.js:52:14)
    at Query.ErrorPacket (/opt/spark/latest/node_modules/mysql/lib/protocol/sequences/Query.js:77:18)
    at Protocol._parsePacket (/opt/spark/latest/node_modules/mysql/lib/protocol/Protocol.js:280:23)
    at Parser.write (/opt/spark/latest/node_modules/mysql/lib/protocol/Parser.js:75:12)
    at Protocol.write (/opt/spark/latest/node_modules/mysql/lib/protocol/Protocol.js:39:16)
    at Socket.<anonymous> (/opt/spark/latest/node_modules/mysql/lib/Connection.js:103:28)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at TCP.onread (net.js:551:20)
    --------------------
    at Protocol._enqueue (/opt/spark/latest/node_modules/mysql/lib/protocol/Protocol.js:141:48)
    at Connection.query (/opt/spark/latest/node_modules/mysql/lib/Connection.js:208:25)
    at /opt/spark/latest/node_modules/knex/lib/dialects/mysql/index.js:124:18
    at Promise._execute (/opt/spark/latest/node_modules/bluebird/js/release/debuggability.js:300:9)
    at Promise._resolveFromExecutor (/opt/spark/latest/node_modules/bluebird/js/release/promise.js:483:18)
    at new Promise (/opt/spark/latest/node_modules/bluebird/js/release/promise.js:79:10)
    at Client._query (/opt/spark/latest/node_modules/knex/lib/dialects/mysql/index.js:118:12)
    at Client.query (/opt/spark/latest/node_modules/knex/lib/client.js:187:24)
    at /opt/spark/latest/node_modules/knex/lib/transaction.js:247:21
    at tryCatcher (/opt/spark/latest/node_modules/bluebird/js/release/util.js:16:23)
    at Function.Promise.attempt.Promise.try (/opt/spark/latest/node_modules/bluebird/js/release/method.js:39:29)
    at Client.trxClient.query (/opt/spark/latest/node_modules/knex/lib/transaction.js:244:39)
    at Runner.<anonymous> (/opt/spark/latest/node_modules/knex/lib/runner.js:129:36)
    at Runner.tryCatcher (/opt/spark/latest/node_modules/bluebird/js/release/util.js:16:23)
    at Runner.query (/opt/spark/latest/node_modules/bluebird/js/release/method.js:15:34)
    at Runner.queryArray (/opt/spark/latest/node_modules/knex/lib/runner.js:174:40)

I also see these when running migration on local mysql server. Looks like mysqlserver and sqlite behave somewhat differently, especially regarding foreign keys, and knex lets you find out about this the hardway... Another problem is that travis runs migrations only on sqlite, so the we have bad migrations leaking into the master branch. Opened another issue on that

@OriHoch @amotenko @LeonFedotov
This is what i think happened:
at first, volunteers table was created with compound primary key on user_id, deparment_id and event_id.
after the initial migration was merged and deployed to staging. I decided to create an id column that will be a PK and the combination of the three columns should be unique. But sqllite wouldn't let me drop compound PK. so I decided to rename the table create a new one with the correct key and then delete the old one. This work great in sqlite, but on mysqlserver renaming the table also updated the foreign keys in the table vol_schedule
The only solution I can think of is deleting all volunteers related solutions and creating them from scratch. There is a pending issue #303 that needs to be done. I think this approach will solve bosth issues.
What do you guys think?

the migrations fail on the last line of this migration -
https://github.com/Midburn/Spark/blob/master/migrations/20170308194741_recreate_volunteers_table.js#L29
seem to me if you just remove that line everything should work properly..
however, it seems some very wierd things are happening with migrations, I think people are not using them correctly, for example, I don't understand how the tables in the camps_relation migration were created - if volunteers migration failed, it would not have run
I assume someone created the tables manually, without the migrations system
this is very problematic.. need to check what's going on with how people are using the system, who does SSH where, etc.. looks like wild west at the moment - @amotenko

@OriHoch
I tried removing the suggested line, other problems appear.
I also tried executing the sql statement that knex generates directly in mysql console, got error num. 1215. From reading about it a little on SO appears that foreign key can only be defined on indexed columns. Right now Looks like the best solution is to comment out all foreign keys declarations drop all volunteers table shift and schedule tables that are no longer required (using migrations of course) and recreate the volunteers with only the required FKs

I think the other problems are due to camp members migration
your plan sounds good
another option - reset migrations

I myself executed the migration on production, once created the production databases, and imported all the camps data.
We had some issues with migration then (also because of foreign key, that mysql cannot use foreign key for unsigned fields or signed field. can't remember, but it is github documented),
but eventually everything worked flawless.
@OriHoch suggestion that something done manually is wrong.
(if the volunteers tables was crashing during migration, the camps_members will not be created)
At the moment i cannot ssh to production, so I cannot find out what is the exact time, this process was done (to see what was the migration files state at that moment)
on staging server i have created a script /opt/spark/create-db.sh
this script remove the db, and execute all migration, and import the camps data into db.
its a good place to start.
I do not know what you want to do, but you should extra carefull,
as production db is running production, and it is very important to harm the data.

I have a theory on how the camps migrations where executed before the volunteers:

Both where created on different branches.
Volunteers migration was created before the camps
Camps where merged into the master and executed on  the server before the volunteers migration was merged.

Yes. having smaller PR and shorter living feature branches would have solved that.

https://github.com/Midburn/Spark/pull/333

https://github.com/Midburn/Spark/pull/338 might solve this issue.

this issue is about investigating why it happened, I think we know now :+1:


Update cache-administration.md

call out what kinds of updates are covered and what aren’t by scheduled updates

@carldc : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

Hi @carldc @yegu-ms The update has an incomplete sentence:
In rare cases where caches are hosted on older models (you can tell if your cache is on an older model if the DNS name of the cache resolves to a suffix of "cloudapp.net", "chinacloudapp.cn", "usgovcloudapi.net" or "cloudapi.de").
I can't make out from the context what should follow the clause "In rare cases where [X]..." Could you take a look? Thanks.

@ktoliver can you please check now?

#sign-off

Thanks @carldc and @yegu-ms


fix(gha): allow opt-out of **/go.sum repo traversal

Why this change?
We have seen issues where the runner does not have permissions to enter a
certain directory. Then the post-step of the cache will fail in GHA.
The reason is that hashfiles currently traverses the entire repository.
What was changed?

Move the hashfiles entry, which is part of the cache key to become opt-out.

Notes

This PR supersedes #576

I'm closing this and we can revive it if needed.


Bridge tasks should "yield"

When the bridge gets a ton of commands to process it can take a long time before it completes all of them.
The bridge should watch this and "yield" its tasks every so often and let the UI go on so frames are not lost.

Closing this, should just add to #32


Issue when launching SF3

https://hastebin.com/oxoyuqocox.hs
Poke @ Rocky on discord when fixed.

also happened when launching age of engineering

https://hastebin.com/fapatamere.hs
is what i get when launching sf3

should be fixed in the next version.


refactor: remove static mut usage

static mut should be avoided because of UB. This PR refactors this with OnceCell.

Should be fixed by https://github.com/sxyazi/yazi/pull/63, closing then.


Any plan or interest to use OpenChat algorithm (https://github.com/imoneoi/openchat) to make mamba-chat?

Any plan or interest to use OpenChat algorithm (https://github.com/imoneoi/openchat) to make mamba-chat? I tried OpenChat, and it seems very good.

We are not planning to train such models ourselves, but are happy to support community contributions!


[feature] add a conditional separation between showRelated and showRelationship

regarding issue laravel-json-api/core#6
if method showRelated exists in the custom authorizer, the two relationship-routes :
/api/resource/{resource_id}/relatedResource
/api/resource/{resource_id}/relationships/relatedResource
will authorize differently

Thanks for submitting this. However the intent was to add the showRelated method to the authorizer interface.
I've now done that, so closing this PR in favour of 1f126027c20ce32f944edec144fe9e5e11aa81a0
Would be useful if you could try out the changes. To do this:
composer require laravel-json-api/laravel:dev-develop --no-update
composer up laravel-json-api/*

@lindyhopchris I tested it and it works as expected 👍👍

Great, thanks for confirming!


Node.js Testing Automation

Creates a Github Action which automatically tests code when a PR occurs.

Currently won't work as testing isn't implemented in main

The fact that the Prettier CI failed means that it's working


remove pool,but  something   relationship of pool    still  exist  in the etcd .

I show my environment ：

two nodes: hostname with  node1, controller
node1's IPaddress  <IP_ADDRESS>
controller's IPaddress <IP_ADDRESS>
kubernetes cluster with calico_kubernetes (all are right)

starting  container  named calico-node  using  calicoctl  node --ip xxx  on above the nodes.And it will create pool  <IP_ADDRESS>/16,as show below:
[root@controller calico_kubernetes]# calicoctl pool show
+----------------+--------------+
|   IPv4 CIDR    |   Options    |
+----------------+--------------+
| <IP_ADDRESS>/16 |              |
+----------------+--------------+
+--------------------------+---------+
|        IPv6 CIDR         | Options |
+--------------------------+---------+
| fd80:24e2:f998:72d6::/64 |         |
+--------------------------+---------+

then I use k8s to create two pods. the two pods then delete them .that's alway be OK .
ine the etcd ,there has something .
[root@controller calico_ctl]# etcdctl  ls  /calico/v1/ipam/v4/pool
/calico/v1/ipam/v4/pool/<IP_ADDRESS>-16

[root@controller calico_ctl]# etcdctl  get  /calico/ipam/v2/assignment/ipv4/block/<IP_ADDRESS>-26
{"attributes": [], "cidr": "<IP_ADDRESS>/26", "affinity": "host:node1", "allocations": [null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null]}

[root@controller calico_ctl]# etcdctl  get  /calico/ipam/v2/assignment/ipv4/block/<IP_ADDRESS>-26
{"attributes": [], "cidr": "<IP_ADDRESS>/26", "affinity": "host:controller", "allocations": [null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null]}

last , deleting pool with calicoctl pool remove <IP_ADDRESS>/16. I think the values of /calico/v1/ipam/v4/pool,/calico/ipam/v2/assignment/ipv4/block/,should be deleted.But Actually,the last one  didn't be delete.
then I seach the source code, the function   of delete pool  is defineed in pycalico/datastore.py
    def remove_ip_pool(self, version, cidr):
        """
        Delete the given CIDR range from the list of pools.  If the pool does
        not exist, raise a KeyError.

        :param version: 4 for IPv4, 6 for IPv6
        :param cidr: IPNetwork object representing the pool
        :return: None
        """
        assert version in (4, 6)
        assert isinstance(cidr, IPNetwork)

        # Normalize to CIDR format (i.e. <IP_ADDRESS>/8 goes to <IP_ADDRESS>/8)
        cidr = cidr.cidr

        key = IP_POOL_KEY % {"version": str(version),
                             "pool": str(cidr).replace("/", "-")}
        try:
            self.etcd_client.delete(key)                            ###only delete the pool
        except EtcdKeyNotFound:
            # Re-raise with a better error message.
            raise KeyError("%s is not a configured IP pool." % cidr)

Do you agree with me ????

Hi @jaywayjayway
Yes I agree.  There are a couple of issues related to dangling configuration with the IP Pools.  One is #519 in calico-docker and the other is issue 56 in libcalico.
We are thinking about the best way to fix this at the moment.
https://github.com/projectcalico/calico-docker/issues/519
https://github.com/projectcalico/libcalico/issues/56
I'm closing this issue since it is effectively a duplicate of issue 56 in libcalico.  I'll update that issue when we have a solution.  I'd suggest you watch that issue for updates.
If you think this issue covers a different scenario, reopen and let me know.
Thanks,
Rob


mkl_layout_pass_test fails due to optional BFLOAT16 support in MKL/oneDNN

Using TF 2.4 on a haswell system
Describe the current behavior
Running the test //tensorflow/core/common_runtime:mkl_layout_pass_test or //tensorflow/core/kernels:mkl fails at the BFloat16 types with e.g.
tensorflow/core/common_runtime/mkl_layout_pass_test.cc:270: Failure
Expected equality of these values:
  DoMklLayoutOptimizationPass()
    Which is: "A(BFloat16Input);B(BFloat16Input);C(Conv2D)|A->C;B->C:1"
  "A(" "BFloat16Input" ");B(" "BFloat16Input" ");C(_MklConv2D);DMT/_0(Const);" "DMT/_1(Const)|A->C;A:control->DMT/_0:control;A:control->" "DMT/_1:control;B->C:1;DMT/_0->C:2;DMT/_1->C:3"
    Which is: "A(BFloat16Input);B(BFloat16Input);C(_MklConv2D);DMT/_0(Const);DMT/_1(Const)|A->C;A:control->DMT/_0:control;A:control->DMT/_1:control;B->C:1;DMT/_0->C:2;DMT/_1->C:3"
[  FAILED  ] MklLayoutPassTest.NodeMerge_Conv2DWithBias_Negative_NoAddBias_DT_BFLOAT16 (1 ms)

This is expected on non AVX512 systems as https://github.com/tensorflow/tensorflow/blob/e211aab91939c2666987cc7ccaee29ee0dd2ba41/tensorflow/core/graph/mkl_graph_util.h#L212 checks for runtime support and exits if not found causing the operation to not be changed and failing the test.
Describe the expected behavior
Tests pass on any valid system.
Standalone code to reproduce the issue
Compile TF with Bazel and //tensorflow/core/common_runtime:mkl_layout_pass_test as the target or run that binary manually on a non-AVX-512 system.

@Flamefire
We are checking it and feedback as soon.
Thank you!

@Flamefire
We are checking it and feedback as soon.
Thank you!

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.

The test is no longer present at the previous location. If it has been moved, the issue likely persists.


Test and improve _convention_csv_to_dict

It should be tested, if the return value is correct
It should be tested if utf-8 encoding can be used instead of windows-1252 once the conventions are corrected in the original repo

fixed in develop. Will merge into main upon next release > 0.2.0


Allow to pass --no-restart to dokku_config

Taking a small patch from https://github.com/dokku/ansible-dokku/pull/51.

Please regenerate the readme using make generate.

:+1:


pkg_edit.php XXE -> LFI Injection

Exploit Title: pfSense 2.6.x-2.5.x pfSense XML external entity Vulnerability  (XXE)
Date: 2022-05-15
Exploit Author: Ali Can Gönüllü
Author Company : Defans Security
Version: 2.6.x-2.5.x
Vendor home page : https://www.netgate.com/
Authentication Required: Yes
Tested on : Windows 10 x64 & FreeBSD 13.6
1-Create a XML file on /usr/local/pkg
2-Write this code
3-Write URL on browser http://url/pkg_edit.php?xml=exploit.xml
Proof : https://prnt.sc/RfIa9N4KD7zw

Please submit security issues responsibly through https://www.netgate.com/security and not via public channels.
That said, if someone can already write to /usr/local/pkg they are already root or root-equivalent privileges so there is nothing gained by this method.


backticks DocType Element to standard and rephrases "you"

Just two small adjustments.

Great, thanks 😄


Rotate photos buttons

Some of my photos show up in the correct orientation on my phone and on my computer, but when uploaded to my Guide, they are sideways 90 degrees.
A rotate 90 degrees button would be nice

Weird. So here is my Guide I'm trying to make: https://openfarm.cc/en/guides/555273e264633900031c0000. Notice the main photo is oriented wrong.
If I inspect the element, grab the URL of the photo on AWS and open up that, it shows up the right orienation: https://s3.amazonaws.com/openfarm-project/production/media/guides/featured_images/555273e264633900031c0000.jpg?1431469417
Also, it seems to be loading the full-size image on the Guide --> Slowwwww


How do you get in the slack?

I tried to enter the slack room, but I can't.

Please refer to this forum thread and reply there in case of any issues. We only deal with code here ... I didn't even know there was a CI-related Slack, so I can't help you.


Impossible to call FMMetaModel>>descriptionOf: on an FM3Trait

It is impossible to call FMMetaModel>>descriptionOf: on an FM3Trait because FM3Trait are not present in classDict (FMMetaModel instance variables), unlike FM3Class.

I'm on it.


Track changes to MicroProfile Starter for Helidon 2.0

Environment Details

Helidon Version: 2.0.0
Helidon SE or Helidon MP: MP
JDK version: 11
OS: n/a
Docker version (if applicable): n/a

We will need to submit an issue to the MP starter so it supports Helidon 2.0 (when we release it). We can use this issue to track specific changes we will request that they make:

[ ] Change the built-in main class to use in generating new projects. It should now be io.helidon.microprofile.cdi.Main
[ ] Make sure there are no explicit references to metrics2 and, if so, change them to metrics.

Superseded by #2372


Fix workflow

This commit provides a temporal fix to rworkflow by bumping the r version of MacOS and Ubuntu and
fixing roxygen bug

https://github.com/microbiome/mia/pull/540

There are more issues related to roxygen and itemize (see the workflow)

all roxygen related warnings are resolved now.

rworkflow of miaViz is going through https://github.com/microbiome/miaViz/pull/124. It does not have any secrets. Make mia's rworkflow similar to it.

rworkflow of miaViz is going through microbiome/miaViz#124. It does not have any secrets. Make mia's rworkflow similar to it.

Tested here https://github.com/microbiome/mia/pull/550


Improve documentation to cover nested activities for adding custom parameters.

Hello,
I had an issue in adding custom parameters to my data factory arm template. and checked the documentation.
However it does not cover a very possible scenario of nesting of activities and how to adjust arm-template-definition for the same.
I suggest to modify the documentation accordingly.
Link to my question and scenario
https://docs.microsoft.com/en-us/answers/questions/428008/add-custom-parameter-to-adf-publish-arm-templates.html#comment-431149

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e22e4d6-366f-fbf8-e141-8905ca7ab7ae
Version Independent ID: 5be2acf2-66e7-cadf-6666-5a85a65b9771
Content: Continuous integration and delivery in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-deployment.md
Service: data-factory
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@mandarsj - Thank you for sharing feedback. We are actively validating it. We will get back to you soon

@nabhishek Could you please validate feedback and add requested details as appropriate


reading i2c protocoll

Hi,
How can I read I2C signals with node? The Led examples works fine, but I have problems how to access the I2C functions of firmata with node.
Is sysex the only way? And how it would look?
I tried: "arduino.sysec(I2C_CONFIG, [?], [?, I2C_READ, ?])" unfortunetly I don't know if its correct way and which parameters I can use?
Thanks
-Adrian

I initally wanted to do this but in the end went with another node module for I2C, but I need to be able to config the i2C bus before it was able to be used.
Using the node-firmata code I was able to work out the sysex call to do this...

arduino.sysex(I2C_CONFIG, [0 & 0xFF, (0 >> 8) & 0xFF]);```

Hopefully, this might be a starting point if you still want to do this.

Cheers,

David


Make SSSOM 1.0 release

All features are merged now.
Before we make a formal release we will have to deal with these two:

[x] https://github.com/mapping-commons/semantic-mapping-vocabulary/issues/2
[X] https://github.com/mapping-commons/sssom-py/issues/256 (to make sure no problems with toolkit from current standard), cc @hrshdhgd
[X] Update all documentation/specification/tutorial pages to reflect these changes DONE: https://github.com/mapping-commons/sssom/pull/205/files
[x]  Update changelog https://github.com/mapping-commons/sssom/blob/master/CHANGELOG.md

Target date for 1.0 release: June 10.

I added now another intermediate release 0.9.4 which reflects all the changes we wanted to get in for SSSOM 1.0.
https://github.com/mapping-commons/sssom/releases/tag/0.9.4
I still want to leave at least a window open for the review from @graybeal and @ernestojimenezruiz on the CV above, but I have now updates basically everything to use the vocab as is.

Hi! Do you plan to release the new version of SSSOM soon?

We are still rolling with the 0.9.X series, are you asking because of the curation_rules?

It is top of my list; I will make a new release at the end of next week, is that ok?

Great! Thanks Nico

After 4 years, the day has come.
With 79 contributors writing more than 1200 comments over the last 4 years, we have done it!
https://github.com/mapping-commons/sssom/releases/tag/v1.0.0
Contribution stats for SSSOM from 2020-04-20 to 2024-08-09
Created with grainyhead.

Event
Total
Internal
Internal (%)
External
External (%)

Contributors
79
21
26.58
58
73.42

Issues opened
218
172
78.90
46
21.10

Issues closed
114
110
96.49
4
3.51

Pull requests opened
154
145
94.16
9
5.84

Pull requests closed
152
146
96.05
6
3.95

Pull requests merged
129
126
97.67
3
2.33

Comments
1230
1017
82.68
213
17.32

Commits
345
328
95.07
17
4.93

Releases
13
13
100.00
0
0.00


distinguish whether session has expired vs new login

[ ] check whether the current Angular-based session structure is sufficient
[ ] check whether all the apps are using the same structure
[ ] If not, we discussed about storing the session info to the server object.

This is already done now.


Use entrysets to avoid map lookups in loops

patch changes various spots in code that iterates over keysets and does gets on the key to get the value, into, iterating over the entry set so the value lookup is avoided.

Looks good. have you run the unit tests (though changes seem safe)


batch_shape vs. batch_size in simulator and related objects

I was thinking about the batch_shape argument which we use across bayesflow, especially in the simulator.
Currently, we use batch_shape = (int,) to allow for potentially multi-dimensional batch shapes. My feeling is that we will never need more than one batch dimension such that we could replace batch_shape = (int,) with batch_size = int patterns throughout. That is, with the batch_size approach, we would always only have and allow for a single batch dimension.
I was wondering what others thing about this? Tagging @LarsKue and @stefanradev93. Also, @daniel-habermann do you think we would need (or at least benefit from) multiple batch dims for multilevel models?

Having batch_size as default for all flat (non-hierarchical models) is definitely nice. I can definitely see where batch_shape can also come in handy for dynamic / hierarchical models.

How would it come in handy there?

The arguments for batch_shape == tuple[int, ...] over batch_size == int are:

Consistency with ML libraries, e.g. PyTorch Distributions. These only allow a shape argument, not a single integer.
Easier extension to multi-dimensional sampling, e.g. for the current HierarchicalSimulator:

simulator = HierarchicalSimulator([fn1, fn2, fn3])

data = simulator.sample((32, 64, 128))
data["fn1_param"].shape == (32, ...)
data["fn2_param"].shape == (32, 64, ...)
data["fn3_param"].shape == (32, 64, 128, ...)

Numpy approaches this problem by allowing integers by default and additionally shape arguments where possible. The argument is also intentionally ambiguously named "size". I think we could follow this approach as well.

I don't think size alone would be a good name because it is too ambigous in our context, since there are some many different sizes floating arount. But I do like batch_size as name much more than batch_shape for the following reasons:

In 90%+ of the cases (I argue for 100% but that is a different issue) we will only need a single batch dimension.
We also call it batch_size in other parts of the library. So using batch_size everywhere would be consistent within the library.
We can still allow the Shape type in addition to int until I have convinced you we don't actually ever need more than one batch dimension.

I will try to explain my take on the HierarchicalSimulator at a different place once I have organized my thoughts on this topic.

I second that. We can also emphasize batch_size (int) for everyday users and also allow batch_shape (tuple, None as default) for power users or special cases, which overrides batch_size.


Blackscreen with games built on OSX

Tried running the "Hello World" example from the wiki:
function love.draw()
    love.graphics.print('Hello World!', 400, 300)
end

Saved it as game.love and put it into my build directory. Ran motor serve and loaded the motor2d.html page. The loading bar comes up for the fraction of a second and then all I get is a black background.
Any ideas?
EDIT: I can run the examples listed in the wiki - if that matters.

Could you try setting a font manually before printing? There might be a problem with loading the default font automatically.

Could you try setting a font manually before printing? There might be a problem with loading the default font automatically.

Tried it, but I still get a blackscreen. Tried it with another project of mine which only uses a few love.graphics functions and that one shows up as a red rectangle (although I never set the background colors to anything in the .love).
Just to be sure I am not doing anything wrong here. These are the steps I took:

Built motor in build folder with build.py build
Use buildy.py buildloader on build folder
Package a game to a .love file
Place the .love file in the "build" folder
Run motor serve on the build folder
Visit http://localhost:8000/motor2d.html

The "motor" script is meant to be run from a game directory. You should unpack your .love into a separate directory.
Then add the motor source directory to your PATH:
export PATH=$PATH:motor-source-directory

then cd to your game directory and run motor serve from there. Then open the browser and navigate to http://localhost:8000/motor2d.html.
Due to a bug in the motor server, when you first open the game, it will give you a message that it couldn't find game.love. Ignore it and restart the server. After refreshing, you should see your game loading.
When something goes wrong, you can usually see at least some output in your browser's web console.

I tried the instructions above and still only get a black screen. Tried it with both my Chrome and Safari browser.
That's the console output in chrome:


Kafka version support confusion

Under Reference guide, Quick start, Compatibility it says compatible with Kafka <IP_ADDRESS> (http://docs.spring.io/spring-kafka/docs/1.1.2.RELEASE/reference/html/_introduction.html#quick-tour).
But when checking the gradle dependencies for spring-kafka I can see that the project uses <IP_ADDRESS> kafka clients.
So basically my question is, can I use 1.1.2 with Kafka <IP_ADDRESS>?

Yes; the documentation is incorrect, 1.0.x is for 0.9.x.x; 1.1.x is for 0.10.x.x.


Support using .docx files (#225)

@pmeier If you could check out the test I added, let me know if you think that's sufficient.
Resolves (#225)[https://github.com/Quansight/ragna/issues/225]

Looks like type checks failed because of the import of python-docx (imported as just docx) dependency. I could add a # type: ignore comment.

Looks like type checks failed because of the import of python-docx (imported as just docx) dependency. I could add a # type: ignore comment.

This is a quite common thing and the best solution here is to ignore this package globally. YOu can add it here
https://github.com/Quansight/ragna/blob/c08a223e5eb6450681cabd7cfd5843c30dbe8d60/pyproject.toml#L138-L146

I'll get some of those suggestions committed when I have a chance later tonight (~20:00 MST)

@pmeier Got all the suggestions put in and pipeline passing, let's ship it! 😇


Expand structure coverage

@dave-connors-3 Other ideas include:

models without appropriate pre-fix (though maybe that's in a separate naming conventions category)
insuring each model type is in the appropriate folder (intermediate models are nested in intermediate folder, marts in marts, etc.)
models are tested and documented in a <dir_name>.yml file in the same directory as the models (not sure yet how to do the documentation piece of this)
any extra documentation in a docs block is placed in a <dir_name>.md file in the same directory (note: do we have doc blocks as resources yet? do we want them?)

Would be curious if other people have thoughts here! Was mostly looking at this article.
Originally posted by @graciegoheen in https://github.com/dbt-labs/dbt_project_evaluator/issues/55#issuecomment-1077925101

models are tested and documented in a <dir_name>.yml file in the same directory as the models (not sure yet how to do the documentation piece of this)

As noted, info on documentation doesn't currently exist in the graph object so this issue will be closed out by PR #103


Fix GCC compilation -Waggressive-loop-optimizations

GCC 13.1.0 were reporting a compilation warning with -O2/3 and -Waggressive-loop-optimizations. GCC is raising an undefined behavior in the while loop, so this workaround asserts that out_len isn't supposed to go negative.
Fixes #21088

Checklist

[x] documentation is added or updated
[x] tests are added or updated

At first sight, this fix seems wrong. I would also really prefer that the compiler is fixed not to generate bogus warnings.

At first sight, this fix seems wrong. I would also really prefer that the compiler is fixed not to generate bogus warnings.

Hi, could you tell me why it seems wrong? This has removed the warning and passed the tests with my setup, but I'm interested to know where I missed something.

Looking at the code again, out_len should always be >= 0 at this point, assuming the assert holds.
Using memset() is probably an easier fix.

FYI: with gcc version 14.0.1 20240321 (experimental) (GCC)
bootstrapped from today's git trunk version this warning is no longer there.

@bernd-edlinger that seems to strongly support this being a compiler bug I think.
It makes sense to me to just memset the array at the top of the function and eliminate the while loop at the bottom to avoid this

Thanks for your advice, I've updated the patch to use a memset instead. It's nice to know that it will be fixed in the next gcc version!

@adrien-zinger I've started the CI run for you, but we would need a cla signed from you to accept this patch.  Are you by chance able to sign one?

@adrien-zinger I've started the CI run for you, but we would need a cla signed from you to accept this patch. Are you by chance able to sign one?

I have add CLA: trivial in the commit message. Do you agree that it is trivial?

Do you agree that it is trivial?

I'm not an OTC member, but looking at https://www.openssl.org/policies/cla.html the bar for trivial is very high (low?!):

in some cases one-line bugfixes might be accepted as trivial without requiring a CLA

This really doesn't look like a one-line bug fix

This pull request is ready to merge

merged, thank you for your contribution

merged, thank you for your contribution

Looks like we have to backport this to stable versions, because ubuntu-24.04 has
the gcc version which prints this warning, and makes lots of test runs fail.


Fixe usage example in README.md

Require statement should be kraken-exchange-api, not kraken-api.

This should be done in the kraken-exchange-api branch: https://github.com/5an1ty/kraken-api


fix(mobile): hide shortcut keys on mobile

I just added a few more options to the group - which were we need that group for mobile. I am not sure how useful shortcuts would be for mobile - but I guess there are still phones that have physics keyboards may found it useful?


productionon build failed for ionic3 and angular4

Short description of the problem:
We migrated today our app to ionic3 and angular4 but run in several issues for build production bundle.
Using ionic-app-script 1.3.0
ionic cordova:build android --prod --release
or
npm run build --prod
We get this error:
[10:40:07]  cleancss finished in 1.25 s
[10:40:08]  ionic-app-script task: "build"
[10:40:08]  Error: [object Object]
Error: [object Object]
    at BuildError.Error (native)
    at new BuildError (/home/abc/software/workspace/web-client-ionic/node_modules/@ionic/app-scripts/dist/util/errors.js:16:28)
    at ChildProcess.<anonymous> (/home/abc/software/workspace/web-client-ionic/node_modules/@ionic/app-scripts/dist/worker-client.js:38:24)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at process.nextTick (internal/child_process.js:753:12)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9) hasBeenLogged: false, isFatal: false, name: 'Error' }

Using latest nightly @ionic/app-scripts": "1.3.0-201704051913 and run
ionic cordova:build android --prod --release
or
npm run build --prod
We get this error:
[10:31:58]  cleancss finished in 1.15 s
{ Error: Unexpected token: name (DEFAULT_LOG_LEVEL) in /home/abc/software/workspace/web-client-ionic/www/build/main.js at line 156519, col 6, pos 6619073
    at BuildError.Error (native)
    at new BuildError (/home/abc/software/workspace/web-client-ionic/node_modules/@ionic/app-scripts/dist/util/errors.js:16:28)
    at taskReject (/home/abc/software/workspace/web-client-ionic/node_modules/@ionic/app-scripts/dist/worker-process.js:36:22)
    at /home/abc/software/workspace/web-client-ionic/node_modules/@ionic/app-scripts/dist/worker-process.js:14:13
    at process._tickCallback (internal/process/next_tick.js:109:7) hasBeenLogged: false, isFatal: false, name: 'Error' }

What behavior are you expecting?
It should work :smile:
I know I shouldn't do this, but it is urgent and so I would mention some one of you guys @danbucholtz

@mburger81,
Are you bundling ES2015 code? Uglify seemingly cannot handle it. We were previously transpiling the bundle down to ES5 but that was proving to be slow. Maybe we need to turn that back on again.
Thanks,
Dan

Probably yes, we are using a set of libraries which probably includes ES2015 code! We use this libs:
"@swimlane/ngx-datatable": "7.1.1",
"angular2-websocket": "0.9.1",
"chart.js": "2.5.0",
"jssip": "3.0.7",
"ng2-charts": "1.5.0",

and also includes this
https://github.com/Streamedian/html5_rtsp_player
what do you think?

Some guys are discussing the issue on ionic issues
https://github.com/driftyco/ionic/issues/11092#issuecomment-292289896

This should be resolved in 1.3.1.
npm install<EMAIL_ADDRESS>
Thanks,
Dan

I confirm, version 1.3.1 is "resolving" me the problem. (I think you added only a workaround)

@danbucholtz in 1.3.1 I am getting errors with minified and just plain js files I include in the build:
If I move appSettings.js up it will error out with appSettings.js.map not found, it's just plain javascript.
copyPolyfills: {
    src: ['{{ROOT}}/node_modules/ionic-angular/polyfills/polyfills.js',
      '{{ROOT}}/node_modules/atatus-js/atatus.min.js',
      '{{SRC}}/appSettings.js',
      '{{SRC}}/local.env.client.js',
      '{{ROOT}}/node_modules/pubnub/modern/dist/pubnub.min.js',
      '{{ROOT}}/node_modules/aws-sdk/dist/aws-sdk.min.js',
      '{{SRC}}/web-animations-next.min.js',
      '{{SRC}}/web-animations-next.min.js.map'
    ],
    dest: '{{BUILD}}'
  },

[10:28:25]  ionic-app-script task: "build"
[10:28:25]  Error: ENOENT: no such file or directory, open '/Users/drew/projects/mazu/www/build/atatus.min.js.map' in
undefined at line undefined, col undefined, pos undefined
Error: ENOENT: no such file or directory, open '/Users/drew/projects/mazu/www/build/atatus.min.js.map' in undefined at line undefined, col undefined, pos undefined
at BuildError.Error (native)
at new BuildError (/Users/drew/projects/mazu/node_modules/@ionic/app-scripts/dist/util/errors.js:16:28)
at taskReject (/Users/drew/projects/mazu/node_modules/@ionic/app-scripts/dist/worker-process.js:36:22)
at /Users/drew/projects/mazu/node_modules/@ionic/app-scripts/dist/worker-process.js:14:13
at process._tickCallback (internal/process/next_tick.js:103:7)

@drewhawken, fixed in 1.3.2.
Thanks,
Dan

Workaround version 1.3.1 works fine, 1.3.2 fails with unexpected token error (like described in #898).


removes nikitha from the code owners

Good luck on the next team! Thanks for all the contributions!

Just want to mention that the output size of the app is impressive! The app is using selective imports I assume?

@sebastienlevert not on this branch, this branch only has a tiny subset of the API surface.

The number that we're most interested in is the Parsed size: 13MB, that is a 13 MB app @sebastienlevert,
We have a long way to go to reach something good, the gzipped number shows how much real world network traffic that package would cost.


After new version 1.8.0

Fast need solve . problem with item auction . permanently says to bidders - Invalid bid value

hm , install older 1.7.1 . doing same .

sry , solved on discord , god bless Lantis . thanks for help .

What was the solution? Not everyone is on the discord

Possible it's due to having static item value set and instead wanting ascending


Get QueueFamilyProperties of the physical devices before asking them …

…for presentation support.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


No string completions in JSX element type arguments

A friend of mine recently tried using JSX generics and it seems like the fix in #34958 did not work for them.
Here is an oversimplified code snippet that replicates the issue. We've tried this in two different machines and neither worked:
import * as React from "react"

type Variations = "hello" | "baaaaa" | "click"

const MyGeneric = <T extends Variations>({  }) => {
  return

}

const Issue = () => {
  return <MyGeneric<"ctrl+space should bring up suggestions here">></MyGeneric>
}

Originally posted by @varemenos in https://github.com/microsoft/TypeScript/issues/34110#issuecomment-1436055385

For the record - this isn't exclusive to JSX. It doesn't work with regular call expressions either (TS playground):
import * as React from "react"

type Variations = "hello" | "baaaaa" | "click"

const MyGeneric = <T extends Variations>({  }) => {
  return

}

MyGeneric<"ctrl+space should bring up suggestions here">({})

And it's not even about string completions:
declare function test<T extends { type: 'a' | 'b' }>(): void

test<{ type: /*1*/ }>()

test<{ type: '/*2*/' }>()

I didn't do further research right now to confirm this but I'm under impression that completions just don't work in type arguments.

When I was looking for duplicates, I saw https://github.com/microsoft/TypeScript/pull/43526, so I assumed that some support is implemented and there are just big gaps.


Colab notebook downloading and processing data access denied

Hey, when I choose the poster scene in the downloading and processing data section I get the following error:
Access denied with the following error:

 	Cannot retrieve the public link of the file. You may need to change
	the permission to 'Anyone with the link', or have had many accesses.

You may still be able to access the file from the browser:

	 https://drive.google.com/uc?id=1dmjWGXlJnUxwosN6MVooCDQe970PkD-1

I can still download it manually, but I just wanted you to know!

Yea, we are hitting download limits on google drive.

Yeah, it's an awesome project so demand is high 🚀

The following command solved the problem for me,
!pip install --upgrade --no-cache-dir gdown

From what I see the problem isn't due to download limits - @ry85's fix worked for me.

@puzzlefish @ry85 Thank you for bringing this up. Sorry I didn't notice this fix earlier.
#1140 should fix the gdown errors, and we have started hosting some of the data on our own servers as well.


[Help] OBD OEM Parameters

Hi Goncalo,
I Try to use your Teltonika Library for read params of devices. I have two type of devices (FMC920 and FMC003). In both i can read GPS data and some IOElements but into FMC003 i can't read OBD data and i don´t know why.
I try to use Codec8 and codec8 extended but nothing.
[(https://wiki.teltonika-gps.com/view/FMC003)]
`    public class MyDataHandler : ChannelHandler<IAvlData[]>
{
private readonly InfluxDbMeasurements _influxDbMeasurements;
    public MyDataHandler(InfluxDbMeasurements influxDbMeasurements)
    {
        _influxDbMeasurements = influxDbMeasurements;
    }
    public override Task ExecuteAsync(IChannelContext context, IAvlData[] data)
    {
        int i = 0;
        string imei = context.Channel.Data["imei"];

        foreach (IAvlData vlData in data)
        {
            //HelperClass.ExportToJson(vlData, i);
            _influxDbMeasurements.InsertMeasurements(data, context.Channel.Data["imei"]).GetAwaiter().GetResult();
        }
        return Task.CompletedTask;
    }
}`

Hi there!
OBD data is sent in the IAvlData.IOData.Elements array. FMC003, if I'm not mistaken, supports only OBD OEM, so you need to check the element id to know what data you are receiving. You can check the ODB element id in Teltonika's documentation. If the OBD data is not being received, you should check the device's configuration. It might be worth checking if the vehicle where the device is plugged in is supported by the device.
Also, I can see that you are writing the IAvlData array to the database. I do recommend writing an Adapter to convert the IAvlData to a custom object that fits your database schema. Then change your handler to handle the custom object instead. This way, you'll be more protected from changes in the library.
Let me know if you need further help.

Thanks for your quick answer!
I attach a Json file with dump data and image files. OBD read parametters but i can't see into JSON File
`        public static void ExportToJson(IAvlData data, int i)
{
string filePath = "C:\Users\xxxx\Downloads\JSON\teltonikaJson_"+i+".json";
// Define las opciones de serialización JSON para un formato legible
var options = new JsonSerializerOptions
{
WriteIndented = true
};
        // Serializa el arreglo data a JSON
        string jsonData = JsonSerializer.Serialize(data, options);

        // Escribe el JSON serializado a un archivo
        File.WriteAllText(filePath, jsonData);
    }`

teltonikaJson_0.json

Indeed there aren't any OBD OEM elements in the JSON you provided. Though, I don't think this has anything to do with the protocol or the library.
Did you check if the vehicle where you plugged the device into is supported? I'm assuming it IS plugged into a real vehicle.
If the vehicle is in the list, I would advise you to contact Teltonika's support to guide you through the device's configuration and/or firmware update.

Sure. You can find details on how to implement an adapter in the docs. Since the library forwards IAvlData[] in the pipeline, you should adapt from that instead of IAvlData to ensure sequence order is maintained.
public class TelemetryAdapter : ChannelAdapter<IAvlData[]>, IInputChannelAdapter
{
    public override Task ExecuteAsync( IAdapterContext context, IAvlData[] data )
    {
        // adapt/transform data
        var list = new List<MyOwnData>();

        foreach ( var avl in data )
        {
            // ... list.Add( new MyOwnData { ... } );
        }

        // forward adapted data
        context.Forward( list.ToArray() );
    }
}

Then your handler can handle MyOwnData[] instead of IAvlData[].
public class MyDataHandler : ChannelHandler<MyOwnData[]>
{
    public override Task ExecuteAsync( IChannelContext context, MyOwnData[] data )
    {
        // ...
    }
}

You then need to adjust the pipeline to use your adapter and handler.
services.AddChannels( channel =>
{
    // ...

    channel.AddTeltonikaInputAdapters()
        .AddInputAdapter<TelemetryAdapter>(); // the order is important

    channel.AddInputHandler<MyDataHandler>()

} );

You can find more examples of adapters and handlers in the repository examples.
Let me know how it goes with Teltonika. Good luck!

Closing this issue for now as it doesn't seem to be related to the library. Please let me know if this changes.


Cleanup and  minor refactoring in two APIs

Issue #, if available:
Description of changes:
Renamed some classes in PPKey for clarity; improved comments elsewhere.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Have you re-run the modified Jypiter notebooks to confirm they still work?

I'm cool with this PR once you test the modified notebooks to make sure they still work.

Have you re-run the modified Jypiter notebooks to confirm they still work?

Yes. Each PR can run all three examples and passes the unit tests.


remove reseting notifier

rubocop autofix
Description of the change
The issue is described here https://github.com/rollbar/rollbar-gem/issues/1033
I am not sure if it does not brake anything else, but since that reset was quite old and also tests are still passing - it should do the job.

Description here

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

As noted in the related issue, Rollbar.reset_notifier! is there intentionally and shouldn't be removed. It resets the notifier to a clean state.
I added some other comments to the issue that should help resolve the issue you're seeing.

Good to know, thanks!


Questions on the new API for selectLocationState param

Given the below, it's not clear if I should be creating the selectLocationState function to return an object that contains the locationBeforeTransitions. Supposing I'm using immutable, it seems to make more sense to return the payload rather than an object containing the payload.
Per this code:
export default function syncHistoryWithStore(history, store, {
  selectLocationState = defaultSelectLocationState,
  adjustUrlOnReplay = true
} = {}) {

  // What does the store say about current location?
  const getLocationInStore = (useInitialIfEmpty) => {
    const locationState = selectLocationState(store.getState())
    return locationState.locationBeforeTransitions ||
      (useInitialIfEmpty ? initialLocation : undefined)
  }

And per this documentation:
What if I use Immutable.js with my Redux store?

When using a wrapper for your store's state, such as Immutable.js, you will need to change two things from the standard setup:

Provide your own reducer function that will receive actions of type LOCATION_CHANGE and return the payload merged into state.
Pass a selector to access the payload state via the selectLocationState option on syncHistoryWithStore.
These two hooks will allow you to store the state that this library uses in whatever format or wrapper you would like.

and per this reducer with Immutable:
/**
 * This action type will be dispatched when your history
 * receives a location change.
 * Based on https://github.com/reactjs/react-router-redux/blob/v4.0.0-beta.1/src%2Freducer.js
 */
import Immutable from 'immutable';

export const LOCATION_CHANGE = '@@router/LOCATION_CHANGE';

const $$initialState = Immutable.fromJS({
  locationBeforeTransitions: null
});

/**
 * This reducer will update the state with the most recent location history
 * has transitioned to. This may not be in sync with the router, particularly
 * if you have asynchronously-loaded routes, so reading from and relying on
 * this state it is discouraged.
 */
export function routerReducer($$state = $$initialState, { type, payload }) {
  if (type === LOCATION_CHANGE) {
    return $$state.merge({
      locationBeforeTransitions: payload,
    });
  } else {
    return $$state;
  }
}

Because you're using your own selector and reducer, you can store the location in state however you'd like, including both the mechanism of storage (Immutable.js in this case) and the shape of the data. As long as your selector is returning an object with the key locationBeforeTransitions, you're doing it correctly.

Thanks @timdorr!
Is there any reason to use immutableJs for the reducer of the location? I'm using immutable for other purposes, and combineReducers to put them together.

if you're using combineReducers, you don't have a fully immutable state, just an object with keys containing immutable objects. In that case, where everything is not exclusively immutable, it's fine to not override the built-in reducer and selector.

Thanks @timdorr!
We've got a universal app running 4.0! https://github.com/shakacode/react-webpack-rails-tutorial/pull/224
As soon as I get a code review, I'll merge, and this will be live. I'll then submit a PR to your README.md.
Let me know:

if you have any comments on my installation of react-router-redux
what would be a good simple feature to show users that we've got react-router-redux working (btw, you can see the events logging if you open the console once we deploy this to heroku).


mark ocs rules as internal

Description
we need to mark ocs as internal, so they will be send only to appropriate end point once we start parsing
Fixes CCXDEV-9984
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Testing steps

n/a

Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

no, you're right, I can add some test inputs with "ocs"


All contributors/add amykapernick

Checklist

[x] I ran npm test locally and it passed without errors.

[ x I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

Hello, i am a newbie GitHub user, i want to correct the errors above. How do i do it?

@GabrielRamaldes Please check out https://github.com/twilio-labs/open-pixel-art/blob/master/CONTRIBUTING.md to learn, how to contribute to the project (and also, how not to do it).

@GabrielRamaldes Please check out https://github.com/twilio-labs/open-pixel-art/blob/master/CONTRIBUTING.md to learn, how to contribute to the project (and also, how not to do it).

I read it and tried to follow the steps but it didn't work. The problem is i need to fix this pull request to keep going in TwilioQuest (i am at the Contributing to Open Source: Merging! mission and specifically asks me to merge this pull request). Is there any way for me to do that?

Hi @GabrielRamaldes! It seems like you opened a PR from the wrong branch/repository. If you go to the previous objective inside TwilioQuest there should be a link that you can click to create the right PR. We also created a walkthrough video that might help you. https://youtu.be/ghYg42YOvHE

I'll close this PR in the meantime since you'll have to create a new one

Hi @GabrielRamaldes! It seems like you opened a PR from the wrong branch/repository. If you go to the previous objective inside TwilioQuest there should be a link that you can click to create the right PR. We also created a walkthrough video that might help you. https://youtu.be/ghYg42YOvHE

I am trying to create the right pull request, but i keep receiving this message. Can i proceed?

Ah so I just looked at your branch: https://github.com/GabrielRamaldes/open-pixel-art/tree/new-pixel and it seems like the branch got messed up. Try running the following things:
git checkout master
git checkout -b new-pixel-attempt-two
npm run sync-fork

Then go into _data/pixels.json and add your pixel and savee the file.  That should hopefully work

Ah so I just looked at your branch: https://github.com/GabrielRamaldes/open-pixel-art/tree/new-pixel and it seems like the branch got messed up. Try running the following things:
git checkout master
git checkout -b new-pixel-attempt-two
npm run sync-fork

Then go into _data/pixels.json and add your pixel and savee the file.  That should hopefully work

Thank you! It works now 😄


Add developer action to show gpu status

Closes #92586
Provide a way to show gpu status

Thanks for working on this, the current result from getGPUFeatureStatus is limited and not really helpful for all cases. What would be better is to have an action in the help menu Help > Show GPU status and it should open a new window similar to process explorer that loads chrome://gpu url which will have all the necessary stats from the runtime.

Thanks for working on this, the current result from getGPUFeatureStatus is limited and not really helpful for all cases. What would be better is to have an action in the help menu Help > Show GPU status and it should open a new window similar to process explorer that loads chrome://gpu url which will have all the necessary stats from the runtime.

Oh, that makes sense. I will work on this.

@deepak1556I got some updates in this PR.
Now it will open a new BrowserWindow to load the chrome://gpu URL with a Help > Show GPU status command.
I'm not sure if I should implement it in the browser environment since VSCode provides a Web edition.

In edge we can open edge://gpu or chrome://gpu which will redirect to edge://gpu automatically.
In firefox we can open about:support.
But I'm not finding a similar page in safari.

The feature is only needed in desktop, for web users can get the info from respective browsers using the standard way.

Sorry for the late review here but I wonder if the added files and services is a bit overkill for what we want to achieve here? I think a service is good if there are multiple users but I think here what we want is to open a window with the GPU info.
We could simply do that from the nativeHostMainService exposing a new method for it (such as the openDevtools method we already have) and put all the code there. In the end that would mean we just have 2 files to change?

Sorry I missed the ping on this. Changes LGTM but we have currently closed the main branch for release/1.94 preparation. I will merge this in once the branch is open again.

@deepak1556  Could we merge into the main branch? Just resolved a merge conflict.


Incorrect alias for bitfield writers

svd2rust 0.24.0 will incorrectly alias some bitfield writers.
For example in the stm32wl crate in the 0.15 release of stm32-rs I see this:
#[doc = "Field `AESEN` writer - AESEN"]
pub use PKAEN_W as AESEN_W;

/* ... */

pub type PKAEN_W<'a> = crate::BitWriter<'a, u32, AHB3ENR_SPEC, PKAEN_A, 16>;

AESEN_W should not alias PKAEN_W in this case because it has a different bit position.
AESEN_W should probably look more like this:
pub type AESEN_W<'a> = crate::BitWriter<'a, u32, AHB3ENR_SPEC, AESEN_A, 17>;

This only occurs in 0.24.  I generated stm32-rs with version 0.23 and did not have this problem.

CC @burrbull @adamgreig

Bug in svd2rust. Ideal morning.
Try #621, please.

That fix did not seem to do it unfortunately, still generates the alias.

That fix did not seem to do it unfortunately, still generates the alias.

Ah, sorry, I had both versions of svd2rust on my path, it's late in the day here 😅
It does not alias anymore, but it also isn't generating enabled/disabled fields now:
   Compiling stm32wlxx-hal v0.5.1 (/home/alex/git/stm32wl-hal/hal)
error[E0599]: no method named `disabled` found for struct `BitWriterRaw<'_, u32, AHB3ENR_SPEC, stm32wl::stm32wl5x_cm4::rcc::ahb3enr::PKAEN_A, BitM, 17_u8>` in the current scope
   --> hal/src/aes.rs:234:45
    |
234 |         rcc.ahb3enr.modify(|_, w| w.aesen().disabled());
    |                                             ^^^^^^^^ method not found in `BitWriterRaw<'_, u32, AHB3ENR_SPEC, stm32wl::stm32wl5x_cm4::rcc::ahb3enr::PKAEN_A, BitM, 17_u8>`
    |
    = note: the method was found for
            - `BitWriterRaw<'a, u32, stm32wl::stm32wl5x_cm4::adc::ier::IER_SPEC, ADRDYIE_A, BitM, 0_u8>`
            - `BitWriterRaw<'a, u32, stm32wl::stm32wl5x_cm4::adc::ier::IER_SPEC, EOSMPIE_A, BitM, 1_u8>`
            - `BitWriterRaw<'a, u32, stm32wl::stm32wl5x_cm4::adc::ier::IER_SPEC, EOCIE_A, BitM, 2_u8>`
            - `BitWriterRaw<'a, u32, stm32wl::stm32wl5x_cm4::adc::ier::IER_SPEC, EOSIE_A, BitM, 3_u8>`
            and 521 more types

check last commit

Everything works now, thanks for the fast fix!

Fixed by #622


Hide temporary results for external verifier

Right now, there is no security for temporary results, and it relies on the publication location being secret from the user. There are two ways to solve this:

publish temporary results to a different location that is accessible only to moderator 2. encrypt the results with the moderators private key

Prefer the first please!

Verifiers have been removed so this is defunct.


Add existence checks for observationAbout references

Checks that the ID referenced in the observationAbout field of SVObs nodes exist, using the Data Commons API. This check is behind a new flag (--oa, --observation-about), which defaults to true.
Performance
I performed tests on the performance effect of this change on my local machine. In a dataset with 1300 rows (FEMA NRI) where each row is a unique place, the run times were as follows;
--oa=false
64.144, 66.921, 68.490 -- Avg: 66.518
--oa=true
74.970, 75.152, 77.691 -- Avg: 75.937
Difference
(75.937 - 66.518) / 66.518 = ~14.1% slower.
Note that ExistenceChecker caches results locally, so when the ratio of unique place references to rows is lower, the slowdown should be less in magnitude. In other words, the results of this test likely represent an approximate upper-bound on the performance impact of these changes.

Is there a chance the chance of such errors increase from defaulting to true? Because the e2e tests now do more RPCs...

In principle this is correct. However;

this specific network failure was when installing a module from maven repos
recent changes did not increase # of RPCs more than ~20%, I believe.


When I open solder webpage it says it can't open requiered file

Are you sure that all of your needed solder files are uploaded? It looks like it's missing a file.

Here's my solder folder, can you see anything wrong?
On February 4, 2015, at 4:43 PM, fcpwiz<EMAIL_ADDRESS>wrote:
Are you sure that all of your needed solder files are uploaded? It looks like it's missing a file.
—
Reply to this email directly or view it on GitHub.￼

I can't see the file. Try responding on this site instead of via email.

Anything wrong here?

Do you have a directory under 'vender'?

The error above is asking for a file in the vendor directory. You can get that folder by using this command: composer install --no-interaction
This will take a few minutes to complete due to the many dependencies that are being downloaded.

@fcpwiz I don't have it because I uploaded this from my computer and xampp had so many files I got confused and uploaded what I could see in the repo

Ok. Well just use: composer install --no-interaction and you're good!

@fcpwiz I already did, just had no idea that I needed it


Rating is loading 10 stars on refresh then quickly returning to 5 stars

                 <Rating
                     iconsCount={5}
                     size={25}
                     ratingValue={0}
                     transition
                     allowFraction
                     readonly
                     initialValue={element}
                     fillColor="#D32748"
                   />

element is a tempory value just to see it working but it ranges from anywhere between 1 and 4, but it always loads as 5 out of 10 stars no matter what for a split second which messes up the layout with the increased height then quickly fixes itself. Any ideas what im doing wrong?

Did you found any solution? I am facing the same issue.

Im also facing the same issue

Try to add your custom class with "display:none" property to fillClassName property of the Rating component.
It works for me

@YuriyYM that did not work for me. Here's what i have
            <Rating
              allowFraction={true}
              readonly={true}
              initialValue={book.overall_rating}
              size={20}
              SVGclassName={"inline-block"}
              fillClassName="display:none"
              tooltipDefaultText={`${book.overall_rating}`}
            />

I tried display: none with taillwindcss (hidden) in fillClassName and it works.


Bots will sometimes put ingredients in other Bot's plates

fixed, there was a missing curr_Player_ID(PlayerID) inside one of the GetIngredient actions


Create bsg.txt

@winer222 I am closing this request without merging because it duplicates already merged #3129. Thank you for the understanding.


GEODE-8634: Fix AsyncInvocationTimeoutDistributedTest flakiness

Null out latch and threadId before each test.
The bug was caused by:

The previous test left threadId set to a non-zero value*
The await() in the second thread completes before the threadId.set() in the first thread executes
The second thread returns the wrong value for remoteThreadId
The wrong remoteThreadId is then compared to the caught exception's message which has a different thread id

*Previous test was await_callable_timeout_includesStackTraceAsCause in all three recorded test failures
Fix is simple: always set threadId to zero value before running each test.

I changed setUp to set threadId to zero instead of null to avoid NPE being thrown by this line:
{{{
await().until(() -> threadId.get() > 0);
}}}

ConcurrentSerialGatewaySenderOperationsDistributedTest failed.

ConcurrentSerialGatewaySenderOperationsDistributedTest failed.

That is due to GEODE-8573, which fails more frequently recently.


Add configuration options for custom DNS work.

The work relates to the enhancement https://github.com/openshift/enhancements/pull/1468. The AWS, Azure, and GCP platform status structs are updated to include custom DNS options. The internal and external load balancer ip addresses as well as the types of dns records make up the base of the data.

/cc @sadasu
/cc @patrickdillon
/cc @JoelSpeed


[CT-719] Add Grants to Postgres Materializations

blocked by: #5263
Once the above work is merged, there are some tweaks that need to be made in the Postgres adapter to fully expose the feature:
- [ ] for incremental, seed, and snapshot materializations call apply_grants(..., revoke=True)
- [ ] otherwise (i.e. view/table materializations) call apply_grants(..., revoke=False) for a performance improvement

get_grant_sql: https://www.postgresql.org/docs/current/sql-grant.html (let's take this formulation as our default)
get_revoke_sql: https://www.postgresql.org/docs/current/sql-revoke.html (let's take this formulation as our default)
get_show_grants_sql: https://www.postgresql.org/docs/current/infoschema-table-privileges.html or https://www.postgresql.org/docs/current/infoschema-role-table-grants.html (I'm more inclined to use show grants as the default, since that's supported by more databases)


CEM Processing to Update Audit Log

Update Audit log after each step completes
STAGING_AUDIT.EXECUTION_LOG

This happens in postProcessing::Execute()


⚠ Bofrost.fr has degraded performance

In 6717f4c, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 870 ms

Resolved: Bofrost.fr performance has improved in 9a0ad99 after 18 minutes.


Can't import createElement as of version 13.5

Describe the bug
import createElement from "react-syntax-highlighter/create-element";

worked to import the createElement function as late as 13.4, but no longer works on 13.5.
import { createElement } from "react-syntax-highlighter";

also does not work.
To Reproduce
Steps to reproduce the behavior:

Install version 13.4.
Try import createElement from "react-syntax-highlighter/create-element";. It works.
Upgrade to version 13.5.
Try the same import again and it fails.

Expected behavior
The import to still work.
Additional context
I'm using create-react-app with TypeScript. Project to reproduce is https://github.com/samuela/cuddlefish/tree/main/web.

Update:
import createElement from "react-syntax-highlighter/dist/esm/create-element";
import { githubGist } from "react-syntax-highlighter/dist/esm/styles/hljs";

does the trick, but it doesn't seem right to have to dig through dist/esm to get to things that are in the public API of the package.


TweetTokenizer hangs

I have the following code that I use to  TweetTokenize a day worth of tweet collection, ~2.2M tweets.
import pandas as pd
from nltk.tokenize import TweetTokenizer

tknz = TweetTokenizer()

df_25 = pd.read_csv('2015-09-25.csv', header=None,\
                     names=['ID', 'ORIG', 'LAT', 'LONG', 'CITY', 'STATE', 'TIMESTAMP', 'TWEET_ID', 'TWEET'], \
                     low_memory=False, \
                     parse_dates=['TIMESTAMP'], usecols=['TIMESTAMP', 'TWEET'])

twt25=[]
for w in df_25['TWEET']:
    twt25.append(tknz.tokenize(w.lower()))
    #debugging output
    print(w)
    print(len(twt25))

The code works as intended unless I come across certain types of tweets, I confirmed this through couple of tests.
For that specific file it was hanging for a long period and couldn't figure out why. I added the print() function to find out where the issue lies. Last time I ran it before manually interrupting the script was 30+minutes., so I decided to remove it with Sublime Text and reran it.
The tweet being: @bunicole http://t.co/LZbFWsdMnl\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ITS YOU! I'm assuming it's because there's 57 !
After removal it stopped again on http://t.co/8K2bEJe9Hn\n???????????????????????? http://t.co/PhylB6ufxw. However, that one having 24 ? was for a shorter period of time ~10s.
Is it possible to skip those types of lines without having to manually delete them?

I think we should try fixing the pathological regex; it looks like a security issue.

I created a csv file with several tweets, adding your entry at the end (I added an ID column just for test):

624492026386624513,@bunicole http://t.co/LZbFWsdMnl\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ITS YOU!

Then I parsed it using pandas (following your code):
import pandas as pd
from nltk.tokenize import TweetTokenizer

tknz = TweetTokenizer()

df_25 = pd.read_csv('test_file.csv', header=None,\
                     names=['TWEET_ID', 'TWEET'], \
                     low_memory=False, \
                     usecols=['TWEET_ID', 'TWEET'])

twt25=[]
for w in df_25['TWEET']:
    twt25.append(tknz.tokenize(w.lower()))
    #debugging output
    print(w)
    print(len(twt25))

I found out that the entry is sligthly different after pandas parsing:
>>> df_25['TWEET'][5001]
'@bunicole http://t.co/LZbFWsdMnl\\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ITS YOU!'

You can see that the \n has been modified, and it is now escaped as \\n. I think that this is because pandas uses \n to create new rows (but I did not use pandas so much, so I might be wrong). It seems that this is what causes the regexp to take so much time. In fact:
>>> from nltk.tokenize.casual import *
>>> tweet_1 = "@bunicole http://t.co/LZbFWsdMnl\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ITS YOU!"
>>> tweet_2 = "@bunicole http://t.co/LZbFWsdMnl\\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ITS YOU!"

The regexp that causes this is WORD_RE in tokenize/casual.py.


WIP - Video series

Coverage increased (+0.1%) to 86.342% when pulling 5b67ba9dda5704616d756c447faee5771826a9fc on video-series into 3621edb26f7c4e05de259dc0cfd1a526533989d4 on master.

Coverage increased (+0.1%) to 86.342% when pulling c12c8b434a22067c640978552c8505035915a8e6 on video-series into 3621edb26f7c4e05de259dc0cfd1a526533989d4 on master.

Coverage increased (+0.1%) to 86.342% when pulling 23fc4b32c96f82b0a0c13230b6d11b7518543fab on video-series into 3621edb26f7c4e05de259dc0cfd1a526533989d4 on master.

@jmelvnsn, we should pull in latest changes from master to make sure nothing broke stuff.

There's a js file flagged as being renamed from __init__.py ? -> bulbs/videos/migrations/init.py → ...deo-recirc-list/video-recirc-list.test.js

Coverage decreased (-0.08%) to 85.978% when pulling 7bf26d8a793889e84a6abb29daa03fd6418363fc on video-series into 181f58be90e2990bc3f8e1b22832f9bb20340bad on master.


The gem of rifts and the End

For some reason when you attempt to use the gem of rifts in the End only 9 chunks will load. You can't open a new rift, or break blocks, but you can build. I've also had the floor randomly not load when I use a rift in the end. Both of these issues can be fixed by rejoining the world.

What is being loaded: 9 chunks of pocket dimension or 9 chunks of the End?


Importer restores bard buttons to default?

Bug description
My bard fieldtype looks like this before I run import
            handle: hero_intro
            field:
              buttons:
                - bold
                - italic
                - anchor
              inline: break
              fullscreen: false
              allow_source: false
              remove_empty_nodes: false
              type: bard
              display: 'Hero Intro'
              container: assets

after running an import it changes to this?
            handle: hero_intro
            field:
              buttons:
                - h1
                - h2
                - h3
                - bold
                - italic
                - unorderedlist
                - orderedlist
                - removeformat
                - quote
                - anchor
                - image
                - table
                - horizontalrule
                - codeblock
                - underline
                - superscript
              inline: break
              fullscreen: false
              allow_source: false
              remove_empty_nodes: false
              type: bard
              display: 'Hero Intro'
              container: assets

This happens on all my bard field types. Even ones pulled in as fieldsets.
How to reproduce
Create a bard fieldtype, edit the buttons. Run an import. The edits to the bard fieldtype will be reset.
Logs
No response
Environment
Environment
Application Name: Statamic
Laravel Version: 11.35.0
PHP Version: 8.3.8
Composer Version: 2.6.5
Environment: local
Debug Mode: ENABLED
URL: vocal.test
Maintenance Mode: OFF
Timezone: Europe/London
Locale: en

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: redis
Database: sqlite
Logs: stack / single
Mail: smtp
Queue: sync
Session: file

Statamic
Addons: 3
Sites: 1
Stache Watcher: Enabled (auto)
Static Caching: Disabled
Version: 5.42.1 PRO

Statamic Addons
jonassiewertsen/statamic-jobs: 1.5.0
statamic/importer: 1.5.1
visuellverstehen/statamic-anchor-navigation: 1.0.0

Additional details
No response

Yes, this is intended.
It'll enable most of the Bard buttons in case it's used by your content, otherwise you'd see errors if you imported bold text somewhere, but you didn't have the "Bold" enabled.
You can disable the buttons after importing.


[Keras-Sprint] Modification of the UNet example

This PR is an effort to modify the Unet example with KerasCV.
Colab Notebook
CC: https://github.com/martin-gorner, https://github.com/margaretmz

Changes look good. Can you also post the latest Colab for review ? The one linked above does not seem to correspond to the PR (for ex. it has the Cosine decay LR still in it but commented out, which i do not see in the commit. Also the Colab uses PiecewiseConstantDecay which i do not see in the commit either.).

@fchollet over to you for the final review!

I worked with Aritra on this example. This is the final version.
LGTM

@martin-gorner I have also added the generated files!


Deletion requests: Post in English rather than in the flagger's locale

An app user (using the Romanian locale on their phone) flagged a picture for deletion.
The deletion requests was posted in Romanian:
https://commons.wikimedia.org/w/index.php?title=File%3AHexagone-Balard_%40_Paris_(23766157612).jpg&type=revision&diff=627919510&oldid=627919420
The picture's uploader probably does not understand Romanian.
Even though we can not expect everyone to understand English, the current norm on Commons is to post these notices in English.
We should thus un-internationalize this message.
The month should also not be localized (februarie in the example).

I'm bikeshedding a little here, but I wonder what would happen if we published the text in all the languages instead? It would probably mean a lot of text to be sent by the phone, i.e. data usage issues. Could we perhaps create an i18n template on Commons and use that in order to prevent the app from sending the text? How complicated would it be to update the translations then?

The template idea is great, as it would allow us to just post a short string (with parameters) and the exact wording would be easy to enhance by any wiki contributor in real-time (without having to wait for us to release a new version of the app, which does not happen often).
@strainu Would you mind creating a prototype of the wiki template and its parameter? Parameters would probably include the picture identifier and the selected reason(s?). Can templates find out the reader's locale? If not, the template's text could be in English and include short links to translations.

Hey @nicolas-raoul I was checking the Code and I think the Language of reason uploaded by users depends on users keyboard. however we can control the language of name of month. we can make it english

@devarsh-mavani-19 Thanks! We can do English for now, and then (in another issue) a template once @strainu or someone else creates a template.

@nicolas-raoul so for now should change the language of the month of deletion request to english?

Yes, and also the reason, which is Pentru că este in the example https://commons.wikimedia.org/w/index.php?title=File%3AHexagone-Balard_%40_Paris_(23766157612).jpg&type=revision&diff=627919510&oldid=627919420

@nicolas-raoul is there anyway i can read the deletion request just like you sent me this link https://commons.wikimedia.org/w/index.php?title=File%3AHexagone-Balard_%40_Paris_(23766157612).jpg&type=revision&diff=627919510&oldid=627919420. can I read my own deletion request for testing my code?

@devarsh-mavani-19 For tests, feel free to send actual deletion requests for this file: https://commons.wikimedia.org/wiki/File:Bicycles_shop_in_Ebisu.jpg You can find it in Explore by searching for "Bicycles shop in Ebisu".


Formsy.Mixin: props name="objectA.keyB" does not produce { ObjectA: {keyB:"value"} }

The documentation at https://github.com/christianalfoni/formsy-react/blob/master/API.md#name suggests that
<MyInputComponent name="email"/>
<MyInputComponent name="address.street"/>

should generate a "form model" with a nested object. {email: 'value', address: {street: 'value'}}.
But when using formsy-react 0.14.1 and react 0.13.3:
<Input
  name="textA.A"
  value=""
  label="Text"
  type="text"
  placeholder="Here is a text input."
  help="This is a required text input."
  required
/>
<Input
  name="TextB.B"
  value=""
  label="Text"
  type="text"
  placeholder="Here is a text input."
  help="This is a required text input."
  required
/>

produces the following in the console:

i.e. values for individual A and B (zero-length string in this example) but not textA.A or TextB.B.
I'd appreciate some guidance. A workaround seems to be to use mapping, but that will get unwieldy quickly.
Thanks!

+1 just ran into this

Hi, that is fixed in new version #158

Thanks @Semigradsky, and to @christianalfoni for a superb library.
@adamalbrecht, a short term workaround courtesy of @garbin, detailed at https://github.com/christianalfoni/formsy-react/pull/153/files
src/main.js:
mapModel: function () {
    if (this.props.mapping) {
      return this.props.mapping(this.model)
    } else {
      return Object.keys(this.model).reduce(function (mappedModel, key) {

        var keyArray = key.split('.');
        var base = mappedModel;
        while (keyArray.length) {
          var currentKey = keyArray.shift();
          base = (base[currentKey] = keyArray.length ? base[currentKey] || {} : this.model[key]);
        }

        return mappedModel;

      }.bind(this), {});
    }
  },

Will close this as it is fixed in new version coming soon, thanks for the feedback @ajaykurien :-)

@christianalfoni Any idea when the next version containing this fix will be released?

Release Candidate out now on React, right around the corner :-) Took a bit longer than I thought, but now it is really close!


perf(attest): lazy formatting for type strings

This PR removes the code formatting type strings for the typescript.json cache file (in ark/attest/cache/ts.ts getStringifiableType), and instead applies formatting on an as-needed basis when toString is called on object types (relevant function in ark/attest/assert chainableAssertions).
This change reduces test run time substantially, cutting ~4.08 s from a ~11.4 s process.
Relevant PR: https://github.com/arktypeio/arktype/issues/1065

Looks great! Thanks again, it's a huge improvement!


Webviews displaying results of an API call with Restclient extension are no longer accessible to screen readers

/CC @isidorn
Issue Type: Bug
I use the Restclient extension to make API calls, as many other alternatives such as Postman are inaccessible.
In the past when using it with NVDA, the webview that opens displaying the response is accessible and can be easily read in browse mode.
Today when I tried making an API request, NVDA reads the following, and I'm completely unable to navigate the contents of the webview that contains the response:
vscode-webview://31320327-84c0-4ee0-bee2-44b9f42d5edc/index.html?id=31320327-84c0-4ee0-bee2-44b9f42d5edc&swVersion=4&extensionId=humao.rest-client&platform=electron&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=vscode-file%3A%2F%2Fvscode-app

Given that the extension hasn't been updated for a few months and I have also not installed a new build of NVDA recently, I'm suspecting this to be a recent Vs Code regression.
VS Code version: Code - Insiders 1.64.0-insider (f93c69659de1a1466bd15e0f1c9f790e73be9208, 2022-01-25T08:42:41.055Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
AMD Ryzen 7 PRO 4750U with Radeon Graphics (16 x 1697)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.23GB (16.96GB free)

Process Argv
--crash-reporter-id 1304d64e-abdb-456c-beb6-72c33120f731

Screen Reader
yes

VM
0%

Item
Value

Remote
WSL: Ubuntu

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 7 PRO 4750U with Radeon Graphics (16 x 1696)

Memory (System)
24.45GB (20.89GB free)

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

remote-containers
ms-
0.215.0

remote-ssh
ms-
0.70.0

remote-ssh-edit
ms-
0.70.0

remote-wsl
ms-
0.64.2

vscode-remote-extensionpack
ms-
0.21.0

vscode-eslint
dba
2.2.2

dendron
den
0.79.0

dendron-markdown-links
den
0.6.20

dendron-markdown-preview-enhanced
den
0.10.57

dendron-markdown-shortcuts
den
0.12.1

dendron-paste-image
den
1.1.0

dendron-snippet-maker
den
0.1.6

gitlens
eam
11.7.0

prettier-vscode
esb
9.1.0

copilot
Git
1.7.4688

rest-client
hum
0.24.6

python
ms-
2021.12.1559732655

vscode-pylance
ms-
2022.1.3

jupyter
ms-
2022.1.1001614873

vsliveshare
ms-
1.0.5273

vsliveshare-audio
ms-
0.1.91

vsliveshare-pack
ms-
0.4.0

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstartedc:30421358
vscop804cf:30404767
vs360cf:30404996
vsclayoutctrc:30405799
azactmsalcf:30409288
pythonvsnew555cf:30426299
vsbas813:30426126

@Neurrone thanks for filling this issue. Can you also reproduce with VS Code stable?
@mjbvz have there been some changes to the webview in the past couple of months that might affect its accessibility?
fyi @jooyoungseo  since I know you also use webviews

@isidorn I'll try reproducing on stable tomorrow. What's the best way of ensuring that my config in insiders is replicated to stable? Does using settings sync work across channels?
I'd want to have stable use the same config to provide better results.

@Neurrone you can enable settings sync on stable, and it should ask you what "setting sync server" to use. You should choose the insider one and that should then make sure that you have the same setting in both insiders and stable. Let me know how it goes. Thanks

We have not changed anything this iteration as far as I can remember
The most recent change I remember here is 3ccfaaff7c68ad832472a3bce609732849c54063 which sets the role of webview documents

As  both NVDA and JAWS user, I haven't experienced any noticeable change in the WebView over the last couple of months. However, it feels like the terminal a11y has been broken again.... The tabindex = "-1" has been removed from the div container where "document" role is assigned. This might cause some unanticipated issues when switching between terminal and Web View widgets.

Reproduceable in 1.63.2 stable.
I believe the contributing factor is how much data is contained in the response. I was able to trigger this when the response was 9000 lines long, while it seemed to work fine for responses that are say 1000 lines long.
Perhaps this issue has always existed but I'm noticing it now because of happening to have a response from an API that contains a lot of data.

@jooyoungseo can you please file a separate issue for that
@Neurrone yes it sounds like this issue is not new. Let's assign to backlog for now and @mjbvz can investigate more when he finds the time.

I also came across the same problem.
As a workaround I set the extension to open the result in a text file.
"rest-client.previewResponseInUntitledDocument": true,

Since we haven't seen any other reports of this over the last year, I'm closing this as out-of-scope for VS Code
If someone wants to continue investigating, this sounds like it is either an issue with the rest client extension or a Chromium issue since it only happens for large documents

I can try this again and will report back on whether this is still an issue.


Mapping domains on root categories

Hi,
I'm running vue-storefront and I have few root categories for example:
http://mystore.demo.com/catA
http://mystore.demo.com/catB
http://mystore.demo.com/catC
I would like to have separate dns domains which will be "mapped" on these root categories
for example:
http://catA-domain1.com -> http://mystore.demo.com/catA
http://catB-domain2.com -> http://mystore.demo.com/catB
...
In other words if user go to: http://catA-domain1.com will be displayed the same content like for http://mystore.demo.com/catA.
Is it possbile to do by configuring routing in vue-storefront ?
I read about multistore https://github.com/DivanteLtd/vue-storefront/blob/master/docs/guide/integrations/multistore.md but it works rather on the same domain.
Thanks

@cszczotka Hey, it's out of scope. VSF can handle internal routing or can initialize external routing but then this should be resolve on server.


Raku syntax: Add .rakutest extension

Looks good now, thank you and sorry for the typo in my suggestion.
Can you please squash all your commits together?
Afterwards the way should be free for a merge.


Add fsxpub tool for compiling/running from cmd

Just a POC for employing fsc-host in a small cmd tool for compile/run an fsx script.

At present it doesn't give any significant speed improvements over dotnet fsi so closing.


Portuguese translation

Check and missing translations

Hello! When I did the translation to Portuguese, I've made the translation to portuguese from Brazil. These updates is for portuguese from Portugual.  Here in Brazul we have a different terms than Portugal (E.g: Gêneros intead Géneros, Controle instead Controlo, Ativar instead Activar,)
I've need to made another PR to portuguese from Brasil?
Thanks in advice.

Good call. I was going to ask @liberty-developer  to create a PT-BR language folder/file since this one is the PT-PT


Getting error "ConnectionResetError: [Errno 104] Connection reset by peer" when checking if directory exists in the azure file share

Package Name: azure-storage-file
Package Version: latest
Operating System: Docker container Redhat UBI 8
Python Version: 3.8

Describe the bug
Getting error "ConnectionResetError: [Errno 104] Connection reset by peer" when checking if directory exists in the azure file share
The error happens randomly but fairly often.
The stack trace also says Max retries exceeded but I cannot tell how many retries were made if any. As the caller of azure.storage.file.FileService.exists() I cannot control the retry policy.
Expected behavior
The client should be able to check if a directory exists without any errors

thanks for reaching out @sorin-bolos , we will investigate it ASAP.

Hi @sorin-bolos  thanks for opening the issue. This is a known issue that we are investigating and having discussions across languages to discuss what the best solution is. I will update you once I have more information!

Hi @sorin-bolos Sorin, thanks for your inquiry about this issue. I can see that when you created this post, you were using the azure-storage-file package, which has now been replaced by azure-storage-file-share.
I have gone ahead and written a test script to check if directory exists with our new package and did not find any connection reset issues after letting the script run for ~15 minutes.
With that being said, I am going to mark this issue as resolved for the time being. Please reach out if you have any questions!
Thanks!