[8.x] Add Request::collect() method

This pull request introduces a new Request::collect method on the Illuminate\Http\Request object.
This method behaves like Request::all(), but instead returns an instance of Illuminate\Support\Collection as opposed to a plain array.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Questioning the validity of the diffusion module

I have run the pytorch version code and found a unreasonable result: I set the parameter "diff_steps" to 0, 10, 50, 100, 200, 500, 1000, then run the code in ETTh1 and  wind datasets. What I find is that , as the number of diffusion steps increases, the results are getting worse. (Both mse and mae are). Below is the result record I run on ETTh1.  I also turn the mse result into a picture (at the end of this issue). So I doubt the validity of the diffusion module.

dataset name: ETTh1
prediction_length: 8
diff_steps: 0
mse mean:0.24760339
mse std:0.020427
mae std:0.3878688
mae std:0.017404405

dataset name: ETTh1
prediction_length: 8
diff_steps: 10
mse mean:0.26035553
mse std:0.012089639
mae std:0.39704275
mae std:0.017935857

dataset name: ETTh1
prediction_length: 8
diff_steps: 50
mse mean:0.26268333
mse std:0.0169106
mae std:0.40157977
mae std:0.015663896

dataset name: ETTh1
prediction_length: 8
diff_steps: 100
mse mean:0.281945
mse std:0.06063651
mae std:0.41526827
mae std:0.051474944

dataset name: ETTh1
prediction_length: 8
diff_steps: 200
mse mean:0.26382175
mse std:0.03267344
mae std:0.39231223
mae std:0.028107507

dataset name: ETTh1
prediction_length: 8
diff_steps: 500
mse mean:0.363977
mse std:0.06955655
mae std:0.45770007
mae std:0.048627686

dataset name: ETTh1
prediction_length: 8
diff_steps: 1000
mse mean:0.35823375
mse std:0.05329487
mae std:0.4454666
mae std:0.032828197

Thanks for your question.
Please refer to our paper's discussions (Section F in the Appendix).
When larger diffusion steps or a wider variance schedule is employed, the diffused series deviates far from the original data gradually, which may result in the loss of useful signals, like, temporal dependencies. Therefore, choosing a suitable variance schedule and diffusion steps is important to ensure that the distribution space is deviated enough without losing useful signals.


Web Experimental Build (Godot)

Research and try to get an experimental build for Web.
Tackled on #396

The research is done (https://github.com/decentraland/godot-explorer/pull/396). The Web build is possible in Godot.
The next steps are to re-implement the Scene Runtime in JavaScript, create a Content Manager that works on the Web, and so on.
So, it's the actual implementation of it.


some doubts about Master Net design

hi,first of all, thanks for your insteresting work;
however, i have some doubts about Master Net design,it is said you have designed 20 networks to select best Master Net, I want to know how you designed these networks or in other word i want to know the details of these 20 networks, i am looking forward to your reply

All Master Nets are listed in the appendix (p.12)

Hi LianShuaiLong,
Thank you for your feedback! And thank you @bonlime for kind reply!
As @bonlime explained, we manually design these networks based on our understanding of what makes a good network. In our design, we intensionally explore different design strategies, such as using all DW-Blocks, or using DW-Blocks in low-level and XX-Blocks in high-level, to see which one is better. As we expected, any GPU efficient networks follow our design space. To design the 20 networks, we did our best. Usually a less carefully designed network would achieve top-1 accuracy around 75%~76%. So these 20 networks are all good enough structures.

Hi LianShuaiLong,
Thank you for your feedback! And thank you @bonlime for kind reply!
As @bonlime explained, we manually design these networks based on our understanding of what makes a good network. In our design, we intensionally explore different design strategies, such as using all DW-Blocks, or using DW-Blocks in low-level and XX-Blocks in high-level, to see which one is better. As we expected, any GPU efficient networks follow our design space. To design the 20 networks, we did our best. Usually a less carefully designed network would achieve top-1 accuracy around 75%~76%. So these 20 networks are all good enough structures.

thanks for you kind reply


docs(docs-site,protocol): deploy proverset guide and scripts

Roger, I approved this PR. I think we may want to say something like:
ProverSet showcase how you can use a smart contract as proposer and provers, but you may want to add custom functionalities in your similar contracts to settle the proser-prover payments.

Roger, I approved this PR. I think we may want to say something like:
ProverSet showcase how you can use a smart contract as proposer and provers, but you may want to add custom functionalities in your similar contracts to settle the proser-prover payments.

will add in another pr


[QUESTION]: Converting an existing composer package to a module?

Hey Guys,
I'm looking to convert some composer packages to modules in order to have full access locally to said package code.
For example, jetstream or fortify.
I much prefer your ideology of keeping laravel conventions as opposed to the laravel-modules way, but I'm wondering, if I publish and register these modules in packagist, then require those packages in a project, how would they be published back to the app-modules directory in the new project so they can be accessed?
Thanks

I don't really think modular is right for this. You should look into "path" repositories in composer. For example:
"repositories": [
    {
        "type": "path",
        "url": "/path/to/your/copy/of/jetstream",
        "options": {
            "symlink": true
        }
    }
]


[Browser] Any interest in a browser version?

Currently I am using a small mock server to produce mDNS query results during browser-based development. It does look like I could convert this standalone service into a package that could be used inside this plugin.
Functionality might not be identical, but it would at least give us something to work with during local development.
Would this be useful for anyone else?

Please feel free to fork and propose a Pull Request. We'll see then.

I would find it helpful. It would speed development up.

:+1:

Closing old issue. Feel free to reopen.


Update URL in atom-make-runner.less

URL included in https://github.com/fiveisprime/atom-make-runner/blob/master/styles/atom-make-runner.less is not working:
Doesn't work:
// See https://github.com/atom/atom-dark-ui/blob/master/stylesheets/ui-variables.less
Works:
// See https://github.com/atom/atom-dark-ui/blob/master/styles/ui-variables.less

I would accept this as a pull request.


answers added

Here I updated my answers.

Thank you for your submission @mohammedshahim
We'll review and get back to you


FIX: Ensure USER has permissions for chmod in Dockerfile

Resolves #25

For security reasons the default user in mambaorg/micromamba:1.4.9-bullseye-slim is non-root with uid 1000 (mambauser) but this requires the user permissions to be escalated to one with chmod powers. The simplest way to do this is to chown to mambauser on COPY.

To ensure that the micromamba environment is setup correctly on entry fallback to the mambaorg/micromamba's ENTRYPOINT and set the /entrypoint.sh as CMD.

c.f. https://github.com/mamba-org/micromamba-docker/blob/675aa44d37707d67b1c3f5ef899a3cc103c73e40/_entrypoint.sh

Tests are needed in general (c.f. Issue #15), but if people would like this in sooner to fix things then a simple local test is
$ docker build -f Dockerfile -t scientific-python/upload-nightly-action:debug .
$ docker run --rm -ti --env INPUT_ANACONDA_NIGHTLY_UPLOAD_TOKEN="fail" --env INPUT_ARTIFACTS_PATH="." scientific-python/upload-nightly-action:debug

which will run all the way through until it correctly errors on
https://github.com/scientific-python/upload-nightly-action/blob/e09d83f8a9d79b1998dd94cd9fd5115162961820/entrypoint.sh#L46-L49
for not being able to upload.

Thanks, @matthewfeickert!


Use const_get instead of eval to get an exception

It a refactoring.
instance_eval method is danger and slow.
instance_eval interprets Ruby code.
So, the method can receive non constant string. It's a security risk.
However, const_get allows constant string. So, it's safety.
And instance_eval is slower than const_get method.
require 'benchmark'
Benchmark.bm 20 do |x|
  x.report('instance_eval'){1000000.times{instance_eval('StandardError')}}
  x.report('const_get'){1000000.times{Kernel.const_get('StandardError')}}
end

$ ruby test.rb
                           user     system      total        real
instance_eval          2.640000   0.000000   2.640000 (  2.645263)
const_get              0.170000   0.000000   0.170000 (  0.161186)

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Good work!


Changing stripe locale to receive error messages in different language!

can you guys help me with changing the stripe locale? can you point me to where exactly the change has to be done?

I am afraid you would have to check the documentation as we are not actively developing Stripe plugin due to the new payment gateway app which would have Stripe in the future. https://github.com/saleor/saleor-checkout/tree/main/apps/checkout-app/pages/api


Error: 9 FAILED_PRECONDITION: no matching index found. Thrown In Production, Not On Emulator

Is this a client library issue or a product issue?

I do believe it is a problem with the client library.
Environment details

OS: MacOS
Node.js version: 10
npm version: 6.14
@google-cloud/datastore version: 6.1
typescript

Hey there everyone! I have asked this on Stack Overflow and haven't gotten anywhere yet, so thought I would ask here. I would first like to point out that I am using Datastore in Native mode. Currently, I am saving user information. This is going really well:
       // The Cloud Datastore key for the new entity
        const storeKey = store.key([user, user_email]);

        // Prepares the new entity
        const record = {
            key: storeKey,
            data: {
              customer: string,
              email: string,
              ...
          },
        };

        // Saves the entity
        await store.save(record);

Later, I am trying to perform a query. Here it is:
         const query = store
            .createQuery('Users')
            .filter('customer', customer)
            .limit(1)

        const [users] = await store.runQuery(query);

        console.warn(users);

I am using the Datastore Emulator for local development and the query is working great. However, upon switching my local machine to point to production I am getting this error on the query:
Error: 9 FAILED_PRECONDITION: no matching index found.
This is odd to me because it is such a simple query. Datastore is supposed to index individual fields from what I can tell. I checked the index.yaml file that is being generated by the Datastore Emulator and it is empty (and expectedly so). I went ahead and deployed everything and am getting the same error in production. Can you see what I am doing wrong?
Thanks and hope you can help! If this should be asked somewhere else or differently, please let me know.

How did you solve this?

@zackexplosion I switched to using the Firestore library. My problem is that I was using Firestore in Native Mode, when I thought I was using it in Datastore. Interestingly, nodejs-datastore worked for a bit, but began to fail on queries.

@tytondon1234 I having the same issue now..
And my solution is change whole GCP project and reset datastore to Firestore mode...


improve postgres data descriptions + add string array tests

Hey @tanner0101, you just merged a pull request, have a coin!
You now have 1348 coins.


Undocumented caveat of ListBox.FillSaveGameList

Comment in the engine code:

// only list games .000 to .099 (to allow higher slots for other perposes)

Documented it here: https://github.com/adventuregamestudio/ags-manual/wiki/ListBox#listboxfillsavegamelist


pkg/agent initial tests and other minor improvements

Tests started passing on CI after some timing issues (I suspect CPU on GHA being stalled for some time?). Now tests styling, naming and stability needs to be reviewed, perhaps some tests can be further optimized in regards to execution time or simplicity.

The test suite is rather extensive, but I think it's a good start for further refactoring and small features. I'll merge it tomorrow if there is no objections.


Ability to search objects

Additional support for SearchControl: automatic move of our placemark

Good job, thanks!


Documentation link redirection error

The link for Azure Enterprise Policy as Code – Azure Landing Zones Integration redirects to an excel community document (https://techcommunity.microsoft.com/t5/excel/filtro-a-più-criteri/m-p/3607812) that is not applicable to this project.

Where did you click on this link from?
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: mhobson87 @.>
Sent: Saturday, October 14, 2023 2:21:38 AM
To: Azure/enterprise-azure-policy-as-code @.>
Cc: Subscribed @.***>
Subject: [Azure/enterprise-azure-policy-as-code] Documentation link redirection error (Issue #390)
The link for Azure Enterprise Policy as Code – Azure Landing Zones Integrationhttps://techcommunity.microsoft.com/t5/core-infrastructure-and-security/azure-enterprise-policy-as-code-azure-landing-zones-integration/ba-p/3607844 redirects to an excel community document (https://techcommunity.microsoft.com/t5/excel/filtro-a-più-criteri/m-p/3607812) that is not applicable to this project.
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/enterprise-azure-policy-as-code/issues/390 or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACWCJVUUSXNLKNOBD6H3NT3X7FMAHBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTGM3TCNRSHAZTRAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCOJUGIYTKOJSGU3KO5DSNFTWOZLSUZRXEZLBORSQ.
You are receiving this email because you are subscribed to this thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Fixed grammar and removed words

Fixed grammar in multiple lines and removed unnecessary words.

[x ] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @jlm323
It seems that similar changes have already been accepted earlier for this article you're editing, sorry about that. 😓
If you feel you have more to add, please feel free to open up a new PR.
Thanks again! 😊

If you have any questions, feel free to reach out through Gitter or by commenting below. 💬


Unexpected base64 signature length

For the base64 DER signature:
MEMCH1AjrYbPRI97qFHRbm/URf/BxbV4MVP+obiVt0tlg3UCIEWHQee0ZJHO1iilPLaMLicfSrfrWnOg2ML915+GeCtV

our utils serve the error:
Unknown signature format. Expected 88, 130, 132, 138, 140, 142, or 144 characters, but got 92

however, the signature is correct, because after conversion do hex it has length of 138:
3043021f5023ad86cf448f7ba851d16e6fd445ffc1c5b5783153fea1b895b74b6583750220458741e7b46491ced628a53cb68c2e271f4ab7eb5a73a0d8c2fdd79f86782b55

Solution:

Instead of validating length of base64 string we should convert it to hex, and then check length (recursion, preferably)
We should ad a test with the base 64 signature from this issue

As far as I can tell, this der signature works and does not give an error. Is this error old or did it happen recently?

This error doesn't seem to happen anymore on the newest version of sdk. If this error is occuring, make sure to check if the chaincode is updated to the newest version of sdk. Closing ticket.

This error doesn't seem to happen anymore on the newest version of sdk. If this error is occuring, make sure to check if the chaincode is updated to the newest version of sdk. Closing ticket.


Line Chart | Line thickness

Hi,
Is it possible to set the line thickness for the line chart?
Thanks,
Farnaz

Hi @oksktank  in that case, can I modify the original code to get this working for my case? If so, what do I need to to do? Thanks.

Check line-chart.js line:93
Modify borderTopWidth will be work
But it can not be perfectly matched with point or line..

Hi @oksktank,
I increased the borderTopWidth to  1.5. However, now I see pretty obvious gaps between the lines. I noticed the gaps were always there regardless but not as noticeable.  I know you are basically drawing a transformed box between a start and end point. Is the gap due to precision issues since the box top right point is not going to match the original end point? I tried to fix it by adding a fudge factor to the next start point (end point of the previous line) but that didn't work. If you can give me any suggestions on how to fix it, it would be great because I have spent hours on this.

@oksktank is the lineThickness bug solved cause it is not working for me either


Add instructions for switching to iptables-legacy (#16271)

(cherry picked from commit 9cdaf4ead1f4c514a6a2582ab00e01efad331a0d)

/milestone 1.16

/lgtm
/approve


Added flag to display filings filed by Registry Staff

Issue #: /bcgov/entity#6814
Description of changes:

added isStaff flag to IA filing
updated interface accordingly
updated unit test
updated app patch release

Yes, I know IAs are not filed by staff, but this is both future-proofing this app and also sets the flag correctly for this filing type  (ie, False) even though it's optional in the Filings History List.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

The API will set the role on filing. Close this PR as not needed.


got very bad accuracy after using syncBN

Hi,
I replace all the BN with SyncBN. but there is no bounding boxes detected in testing time.
Any advise?

There are some known issues of SyncBN in PyTorch.


Check the content type is json when calling exec start.

Supersedes #16399.
Signed-off-by: David Calavera<EMAIL_ADDRESS>

LGTM

LGTM 🐲 (assuming it's green :green_heart:)

@calavera build failure

api/client/hijack.go:130: undefined: hijackWithContentType

@runcom, @vdemeester I fixed that compilation error and everything is green, can you take another look?

reLGTM


fix(jobs): run periodic jobs once at start time

a recent refactor of DoPeriodic (inadvertently) removed the initial invocation of a periodic job, and waited instead until the first frequency interval to execute. We want the first execution to be immediate.
Includes updates to tests that verify expected job execution counts after definite time lapse periods.

Current coverage is 30.38% (diff: 33.33%)

Merging #89 into master will decrease coverage by 0.81%

@@             master        #89   diff @@
==========================================
  Files             8          8
  Lines           359        362     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            112        110     -2
- Misses          220        224     +4
- Partials         27         28     +1

Powered by Codecov. Last update 4e49625...2d4cb4c


Returns all existing server objects.

hi
which method should i use to Returns all existing server objects?

$servers = HetznerCloud\Servers::get();


How to find what proxies Requests is using?

I set no proxies in environment variables, but I set proxies in system configuration on my MacOS. And I find that Requests use it automatically (by checking what responses I get), but it seems this feature is not pointed out in your documentation. So is there any way to see what proxies are Requests is using? Will it automatically use what urllib.request.getproxies() return?

You can call requests.utils.get_environ_proxies(url), where the URL is the URL you're accessing. That will show you what proxies we found.


Nicer data for Stacked Area Demo

We need to get a nicer dataset for the stacked area chart demo. The current set results in an almost psychedelic effect with all the colors, it should be something more smooth.
maybe use any of the data generation projects out there?


Refactor data-check for protocol implementation

Problem statement
Users and developers should be able to implement their own validator's verification logic and the code structure should reflect this capability
Current state
"Data-check" logic is located under the Validator class as a standalone function and implement only the "existence" verification
Desired state
"Data-check" logic is located under the connector section and is part of the plugin (different integration for each platform). Verification logic and how to build your own figures in the documentation
Todo

[ ] Move the data-check function and the verification components to the plugin section
[ ] Implement a more generic verification scheme to help new developers implement their own functions
[ ] Document the importance of the validator's verification logic and how to modify it to match specific use cases

Fixed by #123 => users can now implement entirely custom validation logic through the plugin architecture


PGGD

Could you clarify how do you calculate the avg_gradient that is given as input in the pggd file? I could not find the script that imports this file.
https://github.com/litian96/FedProx/blob/master/flearn/optimizer/pggd.py#L56
Thank you

Thanks for the question. FedProx does not use this optimizer. This is instead used in our FedDANE paper, where the updates correspond to Line 7 in Algorithm 2 in our paper. There is some redundancy when we clean up the code and release it.


[BUG] KNeighborsTimeSeriesClassifier fails with any algorithm except brute

KNeighborsTimeSeriesClassifier has one of two bugs:

a docstring that incorrectly claims that an algorithm can be set. Currently, it is set to brute internally (when calling the sklearn algorithm), no matter what the hyperparameter is.
failing with algorithms other than brute, e.g., auto (the sklearn default) when the implementation is fixed to match the docstring.

So, either, the docstring should be corrected and refrain from claiming that more than one algorithm can be used internally; or, the algorithm needs to be properly passed through, and the failures with algorithms other than brute fixed.

@fkiraly I was actually editing the KNeighborsTimeSeriesClassifier according to #2733 (to remove the kwargs) and noticed the same! For now I simply added algorithm as a parameter (which can simply be removed for the sake of this bug). Please update me on the approach taken for this bug so that I could reflect it as well.

I have changed the default to brute, so one can set the algorithm, but it will break when choosing anything different

This was fixed in the refactor, correct?

hm, I see that the test parameters do not check for this, so we don't really know


Feature/telegram split long messages

@mrkno Can you take a look at this and let me know if you can think of a better / more sensible / less insane way to do this? I was looking at these two implementations of similar / the same problem:
https://github.com/concierge/Kassy/blob/master/core/core_integrations/messenger.js#L97
https://github.com/lukefx/hubot-telegram/blob/d0bc8c115d269a2fb6f292121a163012f1e29fb7/src/telegram.coffee#L90

If the intent of splitting the messages is to get them delivered in order (as opposed to the problem with messenger where it simply will not accept long messages) could you not wait in some way for it to acknowledge that the message has been received? I think slack has a message queue like that somewhere but you would have to ask @Awarua-

@mrkno It is, indeed, because Telegram will not accept long messages: "Current maximum length is 4096 UTF8 characters" https://core.telegram.org/method/messages.sendMessage

They do deliver in order, otherwise; it's only in this odd scenario where the message is split into parts where the out-of-order issue happens... :-/

@phillipadsmith in that case I would perdonally take the approach I did in messenger. It splits it if it is too long and tries to keep words together.

@phillipadsmith once you have finalised your approach and fixed the merge conflicts remove the WIP tag and I will look at it again

once you have finalised your approach and fixed the merge conflicts remove the WIP tag and I will look at it again

👍
I'll drop in the approach you've used for Messenger and update the PR (and remove the tag).

@mrkno So, looking at what you've done with the sentanceSplitter in Messenger, that's not going to work for Telegram because the size is so much longer, e.g., 4096 vs. 320. So, splitting on sentences doesn't make much sense unless I'm going to try to put them back together to get as close as possible to 4096. Otherwise, they definitely deliver out of order.
Going to need to give this another think. Might put this on the back burner for now in favour of adding support for sendImage and so on...

@phillipadsmith No problem. I'll just leave this here until you finish it. It would be good to have support for as many of the other API's as can be supported.

@phillipadsmith take a look at the implementation that I have for the same problem for discord. In theory you should be able to use very similar code and just change the max char length const. #200

@phillipadsmith did you ever get any further with this problem?

@phillipadsmith did you ever get any further with this problem?

@mrkno I got sidetracked unfortunately. However, based on this issue thread, I believe I need to come up with a better workaround, possibly using a queue of some sort.
I'll figure out the best place to implement, either in the node-telegram-bot-api library, or in the Telegram module for Concierge this week / weekend and send another pull request.
Let me know if you have any questions / suggestions.

@phillipadsmith no problem - I won't be able to make significant progress on anything until at least Tuesday. Within shim there is now a generic built in function for segmenting messages which could be useful.

This has been resolved in this commit


provide danger.js file in the examples

I found that the danger js file is missing in the react-native/expo folder.
It is not clear how can we make output.md file, since running reassure will only generate current.perf file which has results in JSON

It will be very helpful if you can provide some more info on this
Thanks

Thanks @mdjastrzebski for reverting back
I will try this and revert back if there is any problem


Added typewriter effect in home page to show all categories we have

Fixes Issue

Changes proposed
Added one more div in Home page that tells about categories(ex : colors, validation, blogs) we have and guides to use menu to navigate.
Screenshots

Note to reviewers

Hi, Thank you so much, It looks perfect. But could you please package-lock.json from this PR?

Sorry, I did not get it . Can you elaborate more.

Hi, Thank you so much, It looks perfect. But could you please package-lock.json from this PR?

Sorry, I did not get it . Can you elaborate more.

Could you remove package-lock.json from this PR?

Ok, will do that and let you know

Hello, I removed package-lock.json

ok


Don't require Cmd, Rpc and Target prefixes

The restriction is arbitrary.  Let the user use any name they want.

Codecov Report

:exclamation: No coverage uploaded for pull request base (mirror@229250d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             mirror    #127   +/-   ##
========================================
  Coverage          ?   6.48%
========================================
  Files             ?      29
  Lines             ?    6257
  Branches          ?     867
========================================
  Hits              ?     406
  Misses            ?    5838
  Partials          ?      13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229250d...01fb3e1. Read the comment docs.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[SUGGESTION]: Distribution mule improvement - one way transfer

**Mule Type: **
Distro
I wan to propose to add additional optional flag like one-way only, so distro mule don't do continuous movement of the same ware back again to source station.
Use case, I have next configuration:

Warehouse (WH) which collect all internal production goods and also used as supply point of intermediates for factories
Trade station (TS) which sell everything unused by production (leftovers)
So for example if I have a lot of energy cells (EC) which I want to sell, I configured dist.mule to move leftovers from WH to TS, it takes leftover EC to TS, but if meantime EC was consumed by other factories which depends on WH then it will return back EC again, so it's just not possible to create proper dist.mule configuration where I just want to move leftovers to specific warehouse.

For example if I configured to keep 50% of EC in source station,
If something is moved for example 10% then 40% will be left and because of that dist.mule will try to fill this missed 10% by return back ware that was transferred before.
I see a lot of wares that was transferred back because of second trade loop, so I propose to avoid additional trade operation by using this flag to make this operation optional.
You can review my commit, if you ok with such changes I will create pull request:
https://github.com/Silencer/Mules-and-Warehouses-Extended/commit/16077861c4e9dc5657e843347d4fa5bee00de9fa

I built a SimpleMule based on this MOD and I think it might do what you want. It's here: https://github.com/thijs/SimpleMule
Maybe I should rewrite it to be a pull request on this repo...

Neat 🙂
On Mon, 14 Jun 2021, 1:24 am Thijs, @.***> wrote:

I built a SimpleMule based on this MOD and I think it might do what you
want. It's here: https://github.com/thijs/SimpleMule
Maybe I should rewrite it to be a pull request on this repo...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/133#issuecomment-860228435,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFH3SZ3DV7L2D4IP2XPNXA3TSTESDANCNFSM45KKY2FQ
.


Why does using dlopen under macos return 0 and dlerror has no information

Using libmpv on a mac also requires other dependencies?


Make Style/RedundantArgument aware of exit and exit!

This PR makes aware of Style/RedundantArgument aware of exit and exit!. It require RuboCop AST 1.28.1+ that includes https://github.com/rubocop/rubocop-ast/pull/262.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Looks good. Thanks!


defaultSnap - snapPoints return bad value

I set up my BottomSheet like this:
<BottomSheet
  open={true}
  ref={bottomSheetRef}
  blocking={false}
  snapPoints={({ maxHeight }) => [200, maxHeight / 2, maxHeight - 150]}
  defaultSnap={({ snapPoints }) =>
    snapPoints[someComponentStateValue]
  }
>

The snapPoints in defaultSnap seem to have a bad value: an array with only 1 member and the value 0.

It's not safe to select a value from snapPoints in defaultSnap by index. The reason for that is that  two-fold:

On initial render maxHeight might be 0, I want to change this though so the defaultSnap and snapPoints are never called before dimension values are fetched and ready.
Duplicate values returned by snapPoints are removed, so its length isn't stable.

Ok, I misunderstood the API. Thanks


FATAL error when using TF_CUDNN_USE_AUTOTUNE=0

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: n/a
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): v1.12.1-10080-g6e0893c79c 1.14.0
Python version: 3.7
Bazel version (if compiling from source): 0.24.1
GCC/Compiler version (if compiling from source): 7.4
CUDA/cuDNN version: 10.0 / 7.6.2
GPU model and memory: V100 16G

Describe the current behavior
I have a model which runs fine. However, after I use
export TF_CUDNN_USE_AUTOTUNE=0

in order to save some autotuning time, it starts to crash with this error in the first iteration:
019-08-30 00:05:05.705707: F tensorflow/stream_executor/cuda/cuda_dnn.cc:262] Unsupported Cudnn convolution backward algorithm for filter: 6
zsh: abort (core dumped)  python3 xx.py

Code to reproduce the issue
Can try to provide one but I think the information is probably already enough to pin down the problem.
Other info / logs
The algorithm 6, mentioned in the error message, corresponds to CUDNN_CONVOLUTION_BWD_FILTER_ALGO_FFT_TILING, which is explictly disabled in tensorflow:
https://github.com/tensorflow/tensorflow/blob/a4bfabe12869a00138173afe739733065b39f4a0/tensorflow/stream_executor/cuda/cuda_dnn.cc#L258-L265
When I set AUTOTUNE=0, cudnn will choose the best algorithm with its own heuristics, and I suspect that TensorFlow crashes because cudnn chooses this algorithm that TF has disabled.
cc @chsigg

In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!

I understand you have a templated response to ask for repro, which is good for filtering out a large portion of issues which are more likely due to user error than a tensorflow bug. But I think I already pointed out the root cause of the issue, and a repro isn't quite necessary to investigate the issue.
In fact, the issue probably requires a very specific version of cudnn to reproduce anyway, so it's unlikely that whatever I provided would be useful.

I have the same issue. Did you find any way how to bypass this?

@ppwwyyxx, would you be willing to send a fix for this?  Probably the easiest thing to do is allow the user to pick something other than CUDNN_CONVOLUTION_BWD_FILTER_ALGO_FFT_TILING (if there is a safe choice) when TF_CUDNN_USE_AUTOTUNE is 0.

@ppwwyyxx
Please update as per above comment, if this is not an issue now, please move this to closed status.

The issue should still exist since CUDNN_CONVOLUTION_BWD_FILTER_ALGO_FFT_TILING is still disabled. Unfortunately I'm not able to send a fix.

I have the same issue. Did you find any way how to bypass this?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Updated component section

Closed #323 due to indentation error
This contains a new section that briefly explains the metal3 components
cc: @elfosardo @hroyrh

/lgtm

/approve


feat: fetch below the fold leaderboard data

Closes #5753

Is this one ready for review again? IMO this is an important one to get in the next release

I've decided to just make this PR the full refactor. These changes have resolved your two notes, but I recommend taking another look now that the scope has changed.

Added a catch for that situation. Those values are now displayed below the fold with no data.


docs(identity): design Indy solution blueprint + add RFC

[x] @hugo-borne  to share materials
[x] From there we will circulate ideas with the community to try and confirm interest & approach
[ ] Assuming there is sufficient community interest & buy-in, then will define roadmap scoping

Consortium Plugin - Indy: #675

Ideas are presented by the whitepaper and we are presenting for the HL identity WG on June 10th to facilitate productive feedback/more ideas.

@PranjayPathak @satyamgupta0103 @princekumar4812 Thank you very much for your future contribution in advance! I assigned the issue(s) to the 3 of you  as requested. Please message here/RocketChat/Mailing List if you need any help or just join one of the morning pair programming calls that we run every weekday.


fix(Android): Add missing timeout argument to socket.connect()

Adds previously missing usage of timeout option

@Rapsssito Without the timeout in native level I couldn't connect successfully after a timeout, all sequent attempts would timeout

@jesperjohansson, I didn't know that was happening. Then there must be a bug in the JS code.

This timeout is necessary for finishing connecting mode and being ready to reconnecting on another Host.


bump 0.21.0-rc1

Description:
Bump 0.21.0-rc1
Related issue(s):
Fixes #
Notes for reviewer:
Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/0.21@34850d9). Click here to learn what that means.
 Consider uploading reports for the commit e5231cf to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             release/0.21    #1001   +/-   ##
===============================================
  Coverage                ?   73.83%
===============================================
  Files                   ?       30
  Lines                   ?     2018
  Branches                ?      385
===============================================
  Hits                    ?     1490
  Misses                  ?      421
  Partials                ?      107

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I think we want to set the version to 0.20.0-rc1 instead of 0.21.0-rc1

also the release branch should be release/0.20 not release/0.21


Indirect dependency u-root is broken

Related to: https://github.com/Foxboron/sbctl/issues/394
The package that uses u-root needs to be updated because it depends on  intel-go/cpuid

https://github.com/hugelgupf/vmtest is the direct dependency with the issue

A temp workaround is to add this to go.mod
replace (
	github.com/intel-go/cpuid v0.0.0-20200819041909-2aa72927c3e2  => github.com/aregm/cpuid v0.0.0-20200819041909-2aa72927c3e2
)

Thanks, I'll fix this and forward push to sbctl!

@scj643 What error are you actually seeing here though? I have a hard time figuring out how this is pulled into the project through vmtest.

GOROOT=/usr/lib/golang #gosetup
GOPATH=/home/scj643/go #gosetup
/usr/lib/golang/bin/go list -modfile=/home/scj643/devel/secureboot/sbctl-upstream/go.mod -m -json -mod=mod all #gosetup
go<EMAIL_ADDRESS>invalid version: unknown revision 2aa72927c3e2

I dug through the cache greping for<PHONE_NUMBER>1909-2aa72927c3e2

I've PRed https://github.com/hugelgupf/vmtest/pull/129 but i'm still very confused how this actually works considering it's not listed in go.sum.


Multilingual support

Configure the website to support i18n

[x] Configure Hugo
[ ] Update .RelPermalink to RelLangPermalink
[x] Add alternate lang meta tags
[x] Add crowdin config
[ ] Shortcodes
[ ] Authors
[ ] Dates
[ ] Partials
[ ] Footer
[ ] Menu items
[x] About Page
[x] Blog Page (list & single)
[x] Challenges Page
[x] Apps compare table
[ ] Contact Page
[ ] Contribute Page
[x] Docs Page (list & single)
[ ] Download Page
[ ] FAQ Page
[ ] Features Page
[ ] Help Page
[ ] Jobs Page (list & single)
[x] Newsletter Page (list & single)
[x] Press Page
[x] Privacy Policy Page
[x] Terms Page
[ ] Home Page
[ ] Easteregg Page
[ ] Hello Page
[ ] Id Page
[ ] Fix relative assets paths with language prefix

[ ] Connect crowdin.com
[ ] initial french translation for the interface
[ ] translate one of the blogposts

Related with https://github.com/berty/berty/issues/1820
Maybe we can try to find a unique translation system for all the projects?

We now have Crowdin for our translation.
-> https://translate.berty.community/


N64 Blueretro Bassmasters 2000 controller/rumble pak switching bug

BlueRetro firmware version
24.04
BlueRetro firmware specification
HW1
BlueRetro firmware variant
System specific
BlueRetro hardware type
External adapter dongle (1 port only)
Manufacturer
8BitMods
System used
Nintendo 64
Bluetooth controller brand & name
NSO N64 Controller (official)
What is problem? (only list ONE problem per report)
NTSC JP N64, Brand new PSU, Everdrive 64 v2.5
Bassmasters 2000 (USA) (No-Intro set)
If the dongle is set to virtual controller pak and not switched over to rumble pak, the game saves normally throughout.
If you switch to rumble pak when prompted to swap, the rumble feature works correctly, but when asked to switch back to controller pak to save, the game no longer recognises the controller pak.
It says you have switched it with another and disables saving. making saving impossible.
This all occurred on slot 1 of the virtual controller pak, no switching banks was involved.
What did you expect to happen?
To be able to switch back and forth between controller pak and rumble pak when prompted to do so by the game, while retaining the ability to save.
Attach files like logs or Bluetooth traces here
No response

Updated FW to 24.10
Failed to reproduce issue after several attempts.
Marking as resolved. Thanks darthcloud :-)


Enable AutoHat support for Qemu 32 bit images

Connects to resin-os/meta-resin#517
@lifeeth @agherzan

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@resin-jenkins ok to test

New Pull Request created #36

@horia-delicoti why new PR?

@agherzan Because I created this PR from forked repo and jenkins cannot test PRs from forks.

got it


fragment/1 can't auto dump uuid string to a binary of 16 bytes

Environment

Elixir version (elixir -v):
Elixir 1.6.0-dev (ba19fc8) (compiled with OTP 20)
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.):
PostgreSQL 10.0
Ecto version (mix deps):
2.2.4
Database adapter and version (mix deps):
"postgrex": {:hex, :postgrex, "0.13.3"}
Operating system:
Mac OS

Current behavior
Fragment can't auto dump uuid string to a binary of 16 bytes
schema do
    field :targets, {:array, :binary_id}
end

  def for_user(targets, user_id) do
    from n in Notification,
      where: fragment("? && ?", n.targets, targets)
  end

n.targets is array of :uuid, input targets is array of uuid string.  Please make sure the value you are passing matches the definition in your table or in your query or convert the value accordingly.
        (clazz) deps/postgrex/lib/postgrex/type_module.ex:717: Clazz.PostgresTypes.encode_list/3
        (postgrex) lib/postgrex/extensions/array.ex:72: Postgrex.Extensions.Array.encode/4
        (postgrex) lib/postgrex/extensions/array.ex:45: Postgrex.Extensions.Array.encode/3
        (clazz) deps/postgrex/lib/postgrex/type_module.ex:717: Clazz.PostgresTypes.encode_params/3
        (postgrex) lib/postgrex/query.ex:45: DBConnection.Query.Postgrex.Query.encode/3
        (db_connection) lib/db_connection.ex:1071: DBConnection.describe_run/5
        (db_connection) lib/db_connection.ex:1142: anonymous fn/4 in DBConnection.run_meter/5
        (db_connection) lib/db_connection.ex:1199: DBConnection.run_begin/3
        (db_connection) lib/db_connection.ex:584: DBConnection.prepare_execute/4
        (ecto) lib/ecto/adapters/postgres/connection.ex:73: Ecto.Adapters.Postgres.Connection.prepare_execute/5
        (ecto) lib/ecto/adapters/sql.ex:256: Ecto.Adapters.SQL.sql_call/6
        (ecto) lib/ecto/adapters/sql.ex:426: Ecto.Adapters.SQL.execute_and_cache/7
        (ecto) lib/ecto/repo/queryable.ex:133: Ecto.Repo.Queryable.execute/5
        (ecto) lib/ecto/repo/queryable.ex:37: Ecto.Repo.Queryable.all/4
        (clazz) lib/clazz/moments/moments.ex:171: Clazz.Moments.list_notifications/2
        (clazz) lib/clazz_web/controllers/notification_controller.ex:10: ClazzWeb.NotificationController.index/3
        (clazz) lib/clazz_web/controllers/notification_controller.ex:1: ClazzWeb.NotificationController.action/2
        (clazz) lib/clazz_web/controllers/notification_controller.ex:1: ClazzWeb.NotificationController.phoenix_controller_pipeline/2
        (clazz) lib/clazz_web/endpoint.ex:1: ClazzWeb.Endpoint.instrument/4
        (phoenix) lib/phoenix/router.ex:278: Phoenix.Router.__call__/1

So I can do manual dump the string value to a  a binary of 16 bytes, then it can be success.
the dump function like this
  defp dump_uuid(uuids) do
    Enum.map(uuids, fn uuid ->
      {:ok, uuid} = Ecto.UUID.dump(uuid)
      uuid
    end)
  end

Then use the help function can get thing done.
  def for_user(targets, user_id) do
    from n in Notification,
      where: fragment("? && ?", n.targets, ^dump_uuid(targets))
 end

So it can be done auto automate or have to do manual?
Expected behavior
  def for_user(targets, user_id) do
    from n in Notification,
      where: fragment("? && ?", n.targets, targets)
  end

The uuid string  can be auto dump to a binary of 16 bytes  in the fragment.

Have you tried casting it explicitly?
    from n in Notification,
      where: fragment("? && ?", n.targets, type(^targets, :binary_id))

Although that may not work since a UUID is a binary, so it is hard for us to say which binary do you want.

The targets is a  list of :binary_id
and I try this
    from n in Notification,
      where: fragment("? && ?", n.targets, type(^targets, {:array, :binary_id}))

It's work.  👍

Hooray! :heart:

@ZhengQingchen this just helped me out of a similar issue. Thanks!!!

It works great, I was also facing the same issue.


Fixes  #82 Passes tester options down to tester

Fixes  #82 so I can peek/poke verbosely...

@chick @ucbjrl can someone review/merge or come up with a better alternative?

I'm submerged in cs250 Chisel3 support for the next day or two.
On Tue, Jan 17, 2017 at 1:46 PM, Angie Wang<EMAIL_ADDRESS>wrote:

@chick https://github.com/chick @ucbjrl https://github.com/ucbjrl can
someone review/merge or come up with a better alternative?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ucb-bar/chisel-testers/pull/83#issuecomment-273310163,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGh1wLGCRMQTLrRBh4B55upY-8l71xMvks5rTTakgaJpZM4LkEue
.

@ucbjrl I will review this


avif sequence image (animated avif) support

Hello. It's a great and really awesome work.
I'm wondering if there are any plans to incorporate support for animated AVIF.
Actually, I noticed that the libavif repository's JNI includes that functionality. However, I'm not entirely sure how to integrate it with your project.
Thank you.

Hi.
Glad to hear you have an interest in project!
At the moment library totally depends on libheif, and libheif do not support animated sequences as my best knowledge.
To separate decoding/encoding functionality from libheif to libavif for avif and keep heic images there is significant rework is required.
Also there are no exists a proper AnimatedDrawable ( with caching, prefetching, memory using cutoff ) in android ecosystem so write one is also needed.
I consider very low spreading of avif sequences.
So in resolution at the moment I do not have any plans to support avifs.
If avifs is important for you it might be easier to implement your own decoder for coil based on libavif provided JNI.
It will be slower, do not support some features ( PQ, HLG ) some ICC profiles as well however it will work.
Also your implementation of good AnimatedDrawable still will be requirement.

And without whole rework there are no sense just to add libavif to project, library does a lot of things to do a good rendering where libavif JNI provides just a basic support.

Thank you for your response.
I might have been looking for the Android library of your other library. With my limited knowledge, I'm not quite sure what functionalities should be added to the AnimatedDrawable.
I'll close the issue. Thank you again.


Added postgresql rivery and zapier connect how-to

Added postgresql rivery and zapier connect how-to

Hi @runwuf, can you please check the warnings? You should probably add Rivery to .github/vale/dics/aiven.dic and also in .github/vale/styles/capitalization_headings.yml if you plan to use it with capital R in titles

Thanks @ftisiot, fixed these warnings.


HADOOP-17611 Restore modification and access times after concat

2897

 Quality gate: Failed
3 Issues

 1 Vulnerabilities
 2 Code issues

Details

 Quality gate: Failed
3 Issues

 1 Vulnerabilities
 2 Code issues

Details


Armor impossible to take off once put on

Server version: 1.12.2
OldCombatMechanics version: 1.6.3
Server log file: https://hastebin.com/zoqixesaxi
OldCombatMechanics config file: https://hastebin.com/wuhapakoge.bash

Once you wear armor, it's just stuck onto you. You can't take it off unless if you're opped or in creative mode.
https://www.youtube.com/watch?v=F_0fFbb3HZw&feature=youtu.be

wait, i may have found a fix


fix: update role labels of unattached PVCs

Closes #1422
Signed-off-by: Marco Nenciarini<EMAIL_ADDRESS>

/test

/test ft=!upgrade

/ok-to-merge

Manually verified with the patch (follow Jonathan’s steps in cnpg)

create a cluster with 1 instance.

scale the cnpg operator to 0.

delete the pvcRole in instance pvc

delete the instance pod

scale the cnpg operator to 1

with patch: the pvcRole label is added to instance pvc, and instance pod is started successfully.
without patch: the pvcRole label is not added to instance pvc, and no instance pod.


Clarify pending docs

A summary of what is done here:

Replaced a confusing "an example" docstring of a describe statement:

- describe "an example" do
+ describe "some behaviour" do

Removed the misleading notion of a possibility to bypass hooks for any notation of a pending example:

- #`before(:example)` hooks are eval'd when you use the `pending`
- #   method within an example. If you want to declare an example `pending`
- #   and bypass the `before` hooks as well,

just because hooks are run either way.

Wrapped the example of pending example group alias into describe to make a distinction between pending example alias and pending example-scope method:

it "is pending with no message" do
  pending
end

vs
describe "SomeClass" do
  pending "does not implement something yet" do
    # ...
  end
end

Clarified the difference between different applications of pending when the failure happens inside before hook.

See the discussion:

https://github.com/rspec/rspec-core/pull/2864#discussion_r576023942
https://github.com/rspec/rspec-core/pull/2864#discussion_r576320027

looks good otherwise

I consider this as good to merge.
The change is minimal, I intend to close the identical PR against 4-0-dev.


I had a quick look at the codepen, and indeed something looks wrong.

Hello, I'm having the same error on a NextJS app with apexcharts. If i started on desktop size screen and resize for a mobile one, it works and the graph is rerendered. But if I open the app directly on mobile, it's bugged

Resizing

First load on mobile


Toml config file in the docs doesn't work

Hi. Toml example in docs throws lot of errors. I'll update this issue with exact errors in some time. Is there an example of using toml config file?

Which TOML example? I think all of the example config we currently have is YAML.

@sfackler: Perhaps not the appropriate issue to raise this, but I'm getting the following trying to deserialize a Config from TOML:
error[E0277]: the trait bound `log4rs::config::Config: config::_IMPL_DESERIALIZE_FOR_Config::_serde::Deserialize<'_>` is not satisfied
 --> src/config.rs:3:17
  |
3 | #[derive(Debug, Deserialize)]
  |                 ^^^^^^^^^^^ the trait `config::_IMPL_DESERIALIZE_FOR_Config::_serde::Deserialize<'_>` is not implemented for `log4rs::config::Config`
  |
  = note: required by `config::_IMPL_DESERIALIZE_FOR_Config::_serde::de::MapAccess::next_value`

Unsure if I'm attempting this correctly, but I have the toml_format feature enabled in my dependencies. What am I missing here?

The Config type isn't deserializable - the RawConfig is: https://docs.rs/log4rs/0.8.0/log4rs/file/struct.RawConfig.html.

Seems like this is resolved


Error building Docker container

I am trying to build a gaps docker container, on Debian Jessie. After cloning the git to a folder and running the docker build command, I get the following error:
Non-resolvable parent POM for com.jasonhhouse:Gaps:0.0.3: Could not transfer artifact org.springframework.boot:spring-boot-starter-parent:pom:2.1.2.RELEASE from/to central (https://repo.maven.apache.org/maven2): repo.maven.apache.org: Temporary failure in name resolution and 'parent.relativePath' points at no local POM @ line 5, column 13
This is the full log:
Sending build context to Docker daemon  90.11kB
Step 1/8 : FROM maven:3.6.0-jdk-11-slim
 ---> 805c08148a8d
Step 2/8 : RUN mkdir -p /usr/src/app/src
 ---> Using cache
 ---> f676f3334ea0
Step 3/8 : WORKDIR /usr/src/app
 ---> Using cache
 ---> 84e9f76b50f4
Step 4/8 : COPY startup.sh mvnw mvnw.cmd pom.xml /usr/src/app/
 ---> 7944a5cf2444
Step 5/8 : COPY src /usr/src/app/src/
 ---> e2ba08da552d
Step 6/8 : RUN chmod +x /usr/src/app/startup.sh
 ---> Running in d4f0fb800f07
Removing intermediate container d4f0fb800f07
 ---> 13375f776abf
Step 7/8 : RUN mvn clean install -Dassembly.skipAssembly=true
 ---> Running in f6fc887823b1
[INFO] Scanning for projects...
Downloading from central: https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.1.2.RELEASE/spring-boot-starter-parent-2.1.2.RELEASE.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for com.jasonhhouse:Gaps:0.0.3: Could not transfer artifact org.springframework.boot:spring-boot-starter-parent:pom:2.1.2.RELEASE from/to central (https://repo.maven.apache.org/maven2): repo.maven.apache.org: Temporary failure in name resolution and 'parent.relativePath' points at no local POM @ line 5, column 13
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project com.jasonhhouse:Gaps:0.0.3 (/usr/src/app/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for com.jasonhhouse:Gaps:0.0.3: Could not transfer artifact org.springframework.boot:spring-boot-starter-parent:pom:2.1.2.RELEASE from/to central (https://repo.maven.apache.org/maven2): repo.maven.apache.org: Temporary failure in name resolution and 'parent.relativePath' points at no local POM @ line 5, column 13: Unknown host repo.maven.apache.org: Temporary failure in name resolution -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
The command '/bin/sh -c mvn clean install -Dassembly.skipAssembly=true' returned a non-zero code: 1 ```

Can you just pull the container from docker hub?


GH-135: Fix Acks

Resolves #135
Properly transfer acks from the listener thread to the consumer thread
for all ack modes.
Previously, record ack mode was not handled in processCommits.

Merged as https://github.com/spring-projects/spring-kafka/commit/677d135932047e6d453a3897d4ff29804bd04c13
and cherry-picked into 1.0.x.


Remove: Microsoft.EdgeDriver version 129.0.2751.0

Released by the publisher by error - not a stable version
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: https://msedgedriver.azureedge.net/129.0.2751.0/edgedriver_win32.zip
OK
(Automated message - build 913)


Updated Intel config file to work with HPE MPI

Purpose

I updated the Intel config file so that it works with Intel MPI and HPE MPI (used on NAS). The config file checks for the I_MPI_ROOT environment variable to determine if Intel MPI is being used.
Expected time until merged

1 week
Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

I tested on one of our Intel MPI images and on NAS with HPE MPI.
Checklist

[ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

Reminder to review this. It should be quick


Improve Rys roots

See https://github.com/pyscf/pyscf/issues/685

Solved
https://github.com/sunqm/libcint/releases/tag/v4.1.0


Use cluster view to replace list of workers

What changes are proposed in this pull request?
Replace List<BlockWorkerInfo> with WorkerClusterView in APIs.
Important APIs that are changed:

FileSystemContext.getCachedWorkers now returns WorkerClusterView
WorkerLocationPolicy.getPreferredWorkers (as well as all its implementations) now accepts a WorkerClusterView as the first argument (but still returns List<BlockWorkerInfo> as the returned list must be ordered)

APIs that are using List<BlockWorkerInfo> (or List<WorkerInfo>) but not migrated to WorkerClusterView:

alluxio.master.scheduler.WorkerProvider.getWorkerInfos returns List<WorkerInfo>.
Job service related APIs, e.g. alluxio.job.plan.PlanDefinition.selectExecutors

Notable behavior change:
Now EtcdMembershipManager assigns the correct state (LIVE or LOST) for all workers in its  WorkerInfo struct. Before this change, this information is not available and the state defaults to UNRECOGNIZED.
Why are the changes needed?
Allow more efficient indexing and filtering workers by worker ID.
Does this PR introduce any user facing changes?
No.

@lucyge2022 @JiamingMai @jiacheliu3 can you please take a look? thanks.
@jja725 I left the scheduler related APIs unchanged but I think it can also benefit from this refactor. Let me know what you think.

alluxio-bot, merge this please

alluxio-bot, merge this please


On duplicate undo, ensure that we get the entities in the scene to delete

Fixes: https://github.com/playcanvas/editor/issues/758
Bug repro steps:

Create a new blank project
Delete all entities
Create new entity
Duplicate the newly created entity
Delete the duplicate entity
Undo all the operations

Notice that the entities originally created aren't undone and when we look at the parent Entities children in data, there are more children then what's in the scene

This is because the undo action stores references to the Entities that are created so that it can delete them on the undo.
However, the delete action removes them from the scene and so the duplicate undo action references become invalid as they are no longer in the scene.
When we undo the delete, a new Entity is created in the scene with the same data (like the GUID).
The fix in this PR is to use entities.latest() in duplicate undo to get that new Entity created from the delete undo from the scene so we can remove them correctly

I've confirmed locally this fixes the duplicate bug - awesome job @yaustar !


Can not use "space" or "=" in the "environment-variables" when creating container

Description
I'm trying to deploy container in ACI, where I would like to use " " or "=" in environment variable.
When I'm using Docker locally this works fine:
docker run -it --rm -p 2222:22 -e SSH_PUBLIC_KEYS="ssh-rsa AAA...iM=" peru/ubuntu_sshd

$ docker inspect 2b3528737878
...
            "Env": [
                "SSH_PUBLIC_KEYS=ssh-rsa AAA...iM=",
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
            ],
....

The command above is working fine. When I use the same using the "az container create" it can not handle the "space" nad "=" in the variable properly:
az container create --name mycontainer --image peru/ubuntu_sshd --environment-variables SSH_PUBLIC_KEYS="ssh-rsa AAA...iM=" --resource-group H...S --port 2222

or

az container create --name mycontainer --image peru/ubuntu_sshd --environment-variables "SSH_PUBLIC_KEYS=ssh-rsa AAA...iM=" --resource-group H...S --port 2222

As you can see here the environment variable SSH_PUBLIC_KEYS is not properly parsed/handled, because it takes " " or "=" as separator:
az container show -n mycontainer
{
  "containers": [
    {
      "command": null,
      "environmentVariables": [
        {
          "name": "SSH_PUBLIC_KEYS",
          "value": "ssh-rsa"
        },
        {
          "name": "AAA...iM",
          "value": ""
        }
      ],
...

Environment summary
I installed aws-cli using pip into virtual env.
CLI Version: What version of the CLI and modules are installed? (Use az --version)
$ az --version
azure-cli (2.0.17)

OS Version: What OS and version are you using?
Fedora 25
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Bash

Should have been addressed in https://github.com/Azure/azure-cli/issues/4084.
cc: @yolo3301


[New Snap] Zetamask

Checklist
All items in the list below needs to be satisfied.

[x] Is the Snap repository publicly accessible and linked in this ticket? https://github.com/1337-ishaan/zetamask
[x] Is the Snap distributed on npm and linked in this ticket? https://www.npmjs.com/package/zetamask
[x] Has an audit been performed and the audit report attached or linked in this issue? https://audits.hacken.io/zetachain/dapp-zetachain-snap-audit-jul2024/
[ ] Is a complete list of discovered vulnerabilities from the audit documented in this issue?
[ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue?
[ ] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue?
[ ] The corresponding pull request in this repo has been merged.

This can be closed, duplicate of : #855 and merged here of #854.


feat: rename moonsama to moonriver

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Related

https://github.com/kodadot/packages/pull/45

What's new?
Updated
{
  "@kodadot1/vuex-options": "0.0.2"
}

POST https://app.gc.subsquid.io/beta/click/001-rc0/graphql net::ERR_FAILED

in #3884 we have 🤔
click: 'https://squid.subsquid.io/click/v/001/graphql',

wait for https://github.com/kodadot/nft-gallery/issues/3905

Something that could be tackled in

#3842

other than that seems it's up

https://deploy-preview-3904--koda-nuxt.netlify.app/movr/explore?tab=GALLERY&page=1
{
    "errors": [
        {
            "message": "Variable \"$orderBy\" of type \"[NFTEntityOrderByInput]\" used in position expecting type \"[NFTEntityOrderByInput!]\".",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Variable \"$orderBy\" of type \"[NFTEntityOrderByInput]\" used in position expecting type \"[NFTEntityOrderByInput!]\".",
                        "    at Object.leave (/squid/node_modules/graphql/validation/rules/VariablesInAllowedPositionRule.js:55:35)",
                        "    at Object.leave (/squid/node_modules/graphql/language/visitor.js:344:29)",
                        "    at Object.leave (/squid/node_modules/graphql/utilities/TypeInfo.js:390:21)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}

metadata on item detail?
https://deploy-preview-3904--koda-nuxt.netlify.app/movr/gallery/0x0dad866dc0c13fb8e4a91d1b5e83cf3a61d4cee2-7636
{
    "errors": [
        {
            "message": "Unknown type \"ID\".",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Unknown type \"ID\".",
                        "    at Object.NamedType (/squid/node_modules/graphql/validation/rules/KnownTypeNamesRule.js:57:29)",
                        "    at Object.enter (/squid/node_modules/graphql/language/visitor.js:323:29)",
                        "    at Object.enter (/squid/node_modules/graphql/utilities/TypeInfo.js:370:25)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at runMicrotasks (<anonymous>)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}

Collection View
https://deploy-preview-3904--koda-nuxt.netlify.app/movr/collection/0xb6e9e605aa159017173caa6181c522db455f6661
{
    "errors": [
        {
            "message": "Unknown type \"ID\".",
            "extensions": {
                "code": "GRAPHQL_VALIDATION_FAILED",
                "exception": {
                    "stacktrace": [
                        "GraphQLError: Unknown type \"ID\".",
                        "    at Object.NamedType (/squid/node_modules/graphql/validation/rules/KnownTypeNamesRule.js:57:29)",
                        "    at Object.enter (/squid/node_modules/graphql/language/visitor.js:323:29)",
                        "    at Object.enter (/squid/node_modules/graphql/utilities/TypeInfo.js:370:25)",
                        "    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
                        "    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
                        "    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
                        "    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
                        "    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
                        "    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
                    ]
                }
            }
        }
    ]
}```

{
"errors": [
{
"message": "Unknown type "ID".",
"extensions": {
"code": "GRAPHQL_VALIDATION_FAILED",
"exception": {
"stacktrace": [
"GraphQLError: Unknown type "ID".",
"    at Object.NamedType (/squid/node_modules/graphql/validation/rules/KnownTypeNamesRule.js:57:29)",
"    at Object.enter (/squid/node_modules/graphql/language/visitor.js:323:29)",
"    at Object.enter (/squid/node_modules/graphql/utilities/TypeInfo.js:370:25)",
"    at visit (/squid/node_modules/graphql/language/visitor.js:243:26)",
"    at validate (/squid/node_modules/graphql/validation/validate.js:69:24)",
"    at validate (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:186:39)",
"    at processGraphQLRequest (/squid/node_modules/apollo-server-core/dist/requestPipeline.js:98:34)",
"    at runMicrotasks ()",
"    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
"    at async processHTTPRequest (/squid/node_modules/apollo-server-core/dist/runHttpQuery.js:220:30)"
]
}
}
}
]
}

Best would be to dowgrade click

one random

otherwise, seems working?

@petersopko let's check what's missing and what's needs to be done and update

#3647
accordingly with sub-issues

collections don't show image previews+ errors in console

same for landing / curated lists

searching through explorer is hard / takes too long to load (sometimes it just gets stuck)

holders/flippers:

@petersopko
I am unable to reproduce your bug.
Can you may provide the steps?

@yangwao the issue is already there for 3 months #3338

let's check what's missing and what's needs to be done and update
https://github.com/kodadot/nft-gallery/issues/3647
accordingly with sub-issues

@yangwao @vikiival I'm kind of confused about this PR, are we just renaming moonsama to moonriver, or fixing everything that's wrong with MOVR?

are we just renaming moonsama to moonriver,

yes

#3902

or fixing everything that's wrong with MOVR?

also fixing rest once it's this minimum viable working version merged so others can continue

#3647

fix tests here or merge it and fix them afterwards?
wyt @petersopko

fix tests here or merge it and fix them afterwards?
wyt @petersopko

the failing tests here are the usual media tests

#3812

I've hit re-run but regardless, I think it's save to merge


Improve -u and -upatch options

Right now we rely on go get -u and -u=patch
The truth is that in practice the go get logic is totally surprising and illogical (to me).
Some examples:
v0.3.0 module is released.
If you do  go get -u or go get -u=patch to module that was previously installed at v0.2.4 nothing literally change....
I think there is need for something better here. ):

Actually now it was just slow GOPROXY (: Let's write down other cases that does not work if spotted again.

Actually now it was just slow GOPROXY (: Let's write down other cases that does not work if spotted again.


added gzip check to prevent double response

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/269/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/227/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/270/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/228/


Global styling options?

Hi Janosh,
Would it be possible to add a class or attribute to target custom styling so for example I could make all icons a certain size and colour which could then be overridden by local svelte module styles or the existing colour and width parameters. I can do this:
 <Alarm/>

<style>
  :global(svg){
      margin: 1rem;
      width: 2rem;
      color: red;
  }
</style>

but I'd like to be able to be more specific, eg:
<style>
  :global(svg.svicon){
      margin: 1rem;
      width: 2rem;
      color: red;
  }
</style>

to avoid interfering with other svgs that may be on the same page.

I definitely see how this would be useful. However, I think it should be done in a way that makes the class name configurable without having to pass it to each icon individually. Don't think that's possible with svicons current setup so need to give it some thought.

OK thanks. I am looking around for some easier ways to include icons but it's not urgent for me at the moment.

You may want to try the approach described here: https://youtu.be/6fW613fblwk?t=112
I've been meaning to for a while but didn't get around to it yet. Let me know how it goes if you do.


[agnoster] add a short path option for the theme

This change to the agnoster theme adds an option for using the name of
the current directory instead of a relative path. Assume you're in the
following directory: ~/.oh-my-zsh/custom/themes. If you set
AGNOSTER_SHORT_PATH=1 in your .zshrc file, the path will render only
as themes on the command line instead of ~/.oh-my-zsh/custom/themes.
In the implementation of this option, another was added to give you even
more control if you want it (AGNOSTER_CURRENT_PATH). If
AGNOSTER_SHORT_PATH is unset and AGNOSTER_CURRENT_PATH is set, that
value will be used for the path value on the prompt.

@mcornella @robbyrussell I see that you both have merged in the most recent changes to agnoster in the past. Might you have any interest in this change?


remove motion effects (Fix issue #950)

Fix for https://github.com/SVProgressHUD/SVProgressHUD/issues/950
Needs some altering.  Not sure what the motion effects are used for exactly, but do know it is the cause of the above issue.

Sorry, @honkmaster and @samvermette but I am gonna get a little rude and @ you two.
So, I commented out the two lines, and it works beautifully for me now.  Can you explain these lines for me and their importance before I go attempting to use this in a product update?
I originally tried wrapping them in a dispatch_async(dispatch_get_main_queue(), ^{ .... }]; in order to preserve whatever affects they might have, but it only serves to correct the UI delay but still causes an execution block on the thread from the Main Thread Checker for a few seconds.
I imagine there is likely an easy solution but I am a little unfamiliar with what his code should be doing (and I usually only read objC code, never write it 🤣 )

Closed in favor of https://github.com/SVProgressHUD/SVProgressHUD/pull/952


System Notifications inject Javascript into Exports to Target

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM <IP_ADDRESS>
[ ] ACS AEM Commons Version: 5.2.0
[ ] Reproducible on Latest? yes

Expected Behavior
If a system notification is active, it should not effect HTML exports to Target
Actual Behavior
If a system notification is active, it will erroneously inject the following JS before the closing body tag:
<script>if(window === top) {   window.jQuery || document.write('<script src=\"/etc/clientlibs/granite/jquery.js\"><\\/script>');   document.write('<script src=\"/apps/acs-commons/components/utilities/system-notifications/notification/clientlibs.js\"><\\/script>');}</script>\n
Steps to Reproduce

set up a connection with Adobe Target
create an active system notification
create an experience fragment
export the experience fragment to Adobe Target
retrieve the experience fragment's HTML
observe that above Javascript is included in the HTML code

PR: https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/3022

Fixed release in 5.5.0


Fix performance issue with projectsObserved callback

https://github.com/gradle/gradle/issues/29026

I have verified the issue is gone after these changes, attaching a YourKit profile with the fix.
projectsObservedFix.zip
For comparison original issue has the problematic profile too.
Context

Contributor Checklist

[x] Review Contribution Guidelines.
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
[x] Provide unit tests (under <subproject>/src/test) to verify logic.
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes.
[x ] Ensure that tests pass sanity check: ./gradlew sanityCheck.
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

Thank you for your contribution!
This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices.

Superseded by https://github.com/gradle/gradle/pull/30010


Proposer index edge cases to test

So thanks to Prysm testnet, an under-tested proposer property was found: the proposer index and shuffling can both be correct, but if the active validators don't match regular indices there can still be a problem. And it only is off after the first inactive validator index in the system, so some tests could look like they test shuffling well (or indirectly as by rewards or otherwise), but just missed it.
TLDR: todo, add test cases for:

proposer index > len(active validators) (already have proposals, but not this edge case)
proposer index > any slashed index (already have slashings, but not this edge case).

Larger validator numbers move the proposer index to be more random and more likely to be bigger than those other numbers, while the current smaller validator sets in tests are generally only 512 validators. (and increasing that would increase the total test size by approx. the same factor).

This manifests itself a lot in the current testnet with many validators attesting over 10,000 times and without a single proposal:

closed via #1518


Package Fallback Folder archive generation

Ignore the specific packages we're using (in Archive.AspNetCore.All), its like this because of current build issues in ASP.NET Core, so I can test the process despite our packages being in a broken state

All of dotnet-archive and Microsoft.DotNet.Archive are copied as-is from https://github.com/dotnet/cli/tree/master/src

The main logic is in repo.targets.
/cc @muratg @Eilon

post-hoc :shipit:


Suggestions ranked by priority

Now that I'm back to doing 10-20 runs a day somewhat frequently I've come to use the application quite a lot haha, here are some suggestions I've come up with, some important, others more QOL ranked by importance in descending order.
1- Editing Streaks after they've been started. This is important in case a run corrupts, or you don't have the tracker open at the time, the runs won't account towards the winstreak. Overall controlling the streak number and conditions should be implemented. A current work around I believe exists is deleting the streak and starting a new one with a adjusted number (but then the prior runs won't be attached to the "current win streak") and also I've never actually gotten this function to work prior. An edit button would also fit right in on the empty space to the right of delete

One additional note would be that it would be ideal to just match the winstreak on the game itself, but I'm unsure if this is able to be done currently, so I won't make it its own suggestion.
2- Be able to start the application mid run. This works 30% of the time currently I'd say, but official implementation for it would be blessed. A lot of the times I'll forget to run the app on my first run and have to start it in the starting room instead and it still won't work. At the very least the app should be made to not crash every time you enter a new floor if the run isn't being accounted for (since otherwise you're forced to close the app and have it happen again)
3- (BUG FIX (?)) I'm not entirely sure why this happens but whenever I finish a run or even am in the middle of a run, the items won't show up:

I have to manually scroll left for them to display. Which I find weird because this panning is not something you can even do manually

the top is as far right as the app allows me to go, the bottom one is just to show that it does fix after moving far enough left
4- Adding the ability to sort through runs by run time. (I like going fast, would be appreciated to see what runs were the longest/ shortest)
5- Currently the pages only allow you to pick either the first 3 or the last page

I'd suggest making it so that if you click the ellipsis an input box would show up allowing you to type a number so you can go straight to the page.
6- implementing an any ending rule. I really only go to blue baby but if I wanted to it would be nice to be able to go do mega satan or delirium instead as somewhat harder variants and still have the run count organically.
7- Think it would be nice to add more parameters to the search runs box. Most importantly item names, being able to see how many times you've started with tmtrainer for instance in your current win streak would be cool to see.
8- (BUG FIX) active items seem to be slightly bugged at times, not really priority but thought I'd bring it to your attention.

I'm additionally leaving a copy of my latest backup here in case you need anything from it to replicate the bugs or check anything:
backup_datas_08-02-22-104952AM.zip
and this is the error dump from yesterday when starting the app during an ongoing run:
repentance_run_tracker_error_dump-08-01-22-022047PM.zip
Thank you for your time 🙏

Thanks for the feedback and ideas !
I am in hollidays currently till August 16th, so i'll be a bit busy during this time but i'll try to work on it if i have free time
1 - "An edit button would also fit right in on the empty space to the right of delete" Yes i can totally do that, i have to check !
"One additional note would be that it would be ideal to just match the winstreak on the game itself" I'm not sure if i get this, you mean the winstreak should be calculated on all the saves at the same time ? I could check that so i have to disable the possibility to add rules for different saves if this one is selected. Am i right ?
2 - I tested a lot this but maybe i have to check more, it's pretty difficult, i was working on it because the app or the game can crash at anytime, but i didn't really tested if we forget to run the tracker mid run, thanks
3 - I have to check this too, thanks
4 - Really nice idea !
5 - Yes i totally should a select to select a page manually !
6 - Ahhhh nice catch, i should check if at least the boss exist in the run and if it's a win, i should check this, i maybe missed something. It was the original idea indeed, i though it was working
7 - It could be very intensive to search for an item in every runs, every floors, or you only want items from the first floor ?
8 - It looks like it only broke with Glowing Hour Glass ? If so, i'm not sure i can fix this one at the moment, did you exeprienced this bug on other runs ?

Np, hope you have a good time whatever you're doing in holidays.
1- I meant it would be ideal for the tracker's winstreak to match the winstreak in game ie. atm I'm at 116 ws on save file 1

but on the tracker its only

So ideally it would just automatch in case you aren't always running the app. I'm unsure if it can gather this itself though without a mod or something
7- I think first floor only would work fine too, I'd mainly only use it to look for eden starts anyways :)
8- this doesn't just happen with glowing hourglass, I see it every now and then. Happened here too:

No backpack but its not really particularly an important fix

Yes ok i see, yes it is not possible actually i think, even with LUA, but adding an edit button should fix your issue since you'll be able to manually change the number.
Ok strange i should check this about the multiple active items issue, something is maybe missing in the logs because it says when an active item is voided and a new active item is added so that's strange, if there was a code issue it would happens every time

@Shaniquaniminiquani i comeback to the point "6", it looks like if you checked Blue Baby ("???") as last boss you can still do Mega Satan or Delirium and it will count the win, this isn't what you want ?

So for instance if you got the delirium portal from the mom's foot fight and beat it, it would count as a blue baby victory? I've never tried it albeit I assumed it wouldn't work this way. Basically I just wanted a checkbox to count the win towards the streak as long as the run was won for the edge cases. If it already works this way then don't mind the suggestion I was unaware 🙏

Ah yes you are right ! I have to check how to do that then, it will not works if you don't beat the boss you currently selected and if you beat delirium without beating blue baby it will not check.
Do you know if it's valid from the streaking community if you don't beat your target but fight an harder boss ?

I'm not entirely sure truthfully. Some people religiously stick to one ending while others have more lenient rulesets like just beating the game in general - any ending. Imo a harder path should count. Regardless of this I would still do blue baby first before a different ending like 100% of the time since I'm going for wr somewhat.
I hadn't yet tested whether or not doing fighting a different boss after the blue baby fight would make it count towards the tracker so that was mainly what I was inquiring about however. The way it works currently is fine 👍

So from the 0.7.7 release some points should be fixed : 1, 2, 3 and 6 : https://github.com/aymericingargiola/repentance-run-tracker/releases/tag/v0.7.7

Bless, editing works perfect 🙏. Took me a second to update because I was doing runs at the time.
I can only do real runs on stream for validity's sake so I'd only be able to extensively test tomorrow but from my quick testing with the console 2 seems to be completely fixed while 3 seems to have fixed but also introduce a new different bug. Whenever you go down ~4 floors the current floor note seems to creep under the final boss note and you are unable to scroll it back to display the current floor

Also I'm not sure if the blinking lines around the current floor is new or not (ongoing runs had always been bugged for me lmao) but it's a nice touch 👍
As for the accompanying mod, truthfully I've been using the tracker for about 9 months now so I was aware of its existence and I do actually like its functionality a lot, but no mods is a big core of streaking imo and although I believe non gameplay altering mods like External item descriptions etc are universally accepted, it's more of the principle for me. Would love to get the features on the standalone some time in the future (If the game were to ever allow it) but since you've gone through the trouble of making a specific mod for it, it's clear that it's not something that can be done without it currently 💀
Thanks for getting around to working on this on your holiday btw, was expecting this to come out later down the month

Yes this was a bit rushed, i released an hotfix ! Let me know
https://github.com/aymericingargiola/repentance-run-tracker/releases/tag/v0.7.8

My streak actually just died but the scrolling issue did seem to be fixed as well as the edited streak counter saving. Some additional things I've noticed now that I've lost is that the "best win streak" only counts the one with the most recorded tracker runs instead of the actual highest and also think it might be nice to print out the winstreak counter next to the deaths so if sorting by deaths you can see what numbers you died on (If that makes sense)

Your streak died because of the update or you died in game ?
Yeah unfortunately the best winstreak will count what is on the tracker and do not know the adjust number, I don't really know at the moment how I will change that, same for showing the number of streak you had during your death, but I maybe have some ideas 🤔

I died in game, will do though!

Everything you asked should be done now ! https://github.com/aymericingargiola/repentance-run-tracker/releases/tag/v0.7.11
Except number 8, i'm not sure how to reproduce it, but maybe if it happens again, can you send me your game logs so i can replay and debug your game ? It should be in C:\Users\[YOUR NAME]\Documents\my games\Binding of Isaac Repentance\log.txt

Will do if I notice 8 happen again, it's not very common albeit so thats a good thing
As for the custom item search, would it be possible to drop the first colon so it's "item:51:2" instead of ":item:51:2"? I thought the first colon was to specify a character but "isaac:item:51:2" doesn't seem to work + you can tech already sort by character.
Or alternatively drop the ":item:" scheme altogether and just input "51:2"/ "Pentagram:2"? I don't believe typing in numbers alone/ item names would conflict with other current search query's unless theres plan to expand in the future
I read the patch notes so I'd be able to use it but I think the functionality might be lost on anyone who doesn't already know it exists since the specific phrasing isn't very intuitive to reproduce. This is more of a low priority Qol change though, so no worries if it's outside of scope. Overall am really happy with the changes, a lot has been done this past month haha

The first ":" is to tell the search box function that this is a query and so directly bypass the basic text search, i'v updated the readme also, and I'll keep updating as soon as I add things like this ! The main idea is maybe later to have other custom queries like :monster:[id]:[floor], whatever people wants :)
Also gulped trinkets and items have conflict id's so it's interesting to keep ":item:" so we know what we search, maybe later we can have gulped trinkets query, what do you think ?
I can later make a new easy query builder filter component with an UI instead to do this in the search box (Wich will takes time to build ahah)
Yeah thank you for all your feedbacks, I can't really test every situations or miss important / qol features !

A gulped trinket query would be interesting, I think since it would have significantly less things to search for it could potentially search every floor instead. One simple way to eliminate dud searches is to only search runs that actually have a gulped trinket by giving them a special identifier at the end of the run. Ie, you might have 500 recorded runs but this would only need to scan like 20 or so that have the gulped label. This would eliminate the need to search for trinkets by floor altogether. Also since it's more niche the default query could be still used for items ie "51:2" while trinkets would have their own "trinket:51". Would this allow tracking for golden trinket variants as well? Im unsure how those are specifically handled in code.
An UI feature would definitely fix all of this as well for sure though. I think if we go this route it might be smart to also have options for turning on or off certain features like for instance the characters and search from starting date to ending date query. I hardly ever use these if at all but they do make the current ui take 2 lines vertically

If you were to have one single search ui that accepted specific parameters it would make for a cleaner app for sure
I think one back of the napkin change I thought of was to have eden starting stats be displayed on the tracker. Iirc his stats should be linked to the seed so there might be a way to do this without a mod potentially since they would be the same every time. The way I'd envision it if it was possible would be to have it be where the end stats are displayed if you use the mod and either click on them to switch between the end and starting stats or have a option in the configure menu on which should be displayed by default. I'm unsure if the technology is there yet for this implementation though. In the worst case scenario it might mean having to reverse engineer the seed to see the stats/ running a smaller separate instance of the game to scrape the stats.
Either way it could be a good idea for the modded side of the app nonetheless if not possible to do unmodded 👍

I have to check about golden trinkets but if I remember correctly they have their own IDs and I support them yes, I made something about golden trinkets ! I have to add a flag to runs with gulped trinkets then yes, I have to check to do this on previous runs also.
This is a good idea to keep starting stats of Eden ! But yeah unfortunately with the mod it's hardly possible unless I add an option to add manually starting stats and end stats wich is not very convenient.
I'll add option to hide/show filters yeah that's a nice point


Fix PVR bottom bar shortcut behavior

Fixes #587

Not sure what it is with Travis, but the tests run fine on my machine. I think this must be a travis issue as this PR doesn't change anything in the build configuration.


[oc-pushy-pedant] Don't coerce heartbeat interval to int

The heartbeat interval in pushy is in milliseconds.  When coverting it
to seconds we were inadvertantly converting it to an int.  This made
it impossible to, among other things, set up a test config with a
heartbeat_interval < 1000ms.

:+1:

@smith I updated this, but I haven't looked at in a while to know if it is still relevant.  But reading it over it seems reasonable to me.


Alert type stuck on info

Hi,
I seem to be missing something but afterreading all the issues on github and documentation I still havent found an answer.
My code is:
$.notify({
	icon: "fa fa-thumbs-o-down",
	title: "<strong>" +"Atentie! " + "</strong> ",
	message: "Campania nu este inactiva"
},{
	type: 'danger',
	placement: {
		from: "top",
		align: "center"
	},
	offset: 52,
	allow_dismiss: true,
	newest_on_top: true
});

and still the alerts are showing up as info
WHAT AM I MISSING?
Thank you.

This looks correct, would you be able to replicate this using jsfiddle.net or provide me with a demo. Everything looks coorect.

Replicating this on jsfiddle is a little bit difficult because I wold have to replicate every css and js component I load and there are a lot of them. I tried to create a static page so that I can provide as an example but surprisingly it works just fine. This leads me to belive there is an incompatibility issue with some other component either js or css I load. I will try disabling them one by one to see wich one generates the issue.
Home I will find a solution and get back to you when I do
Thank you very much,

Your best solution is to use debugger and see what csss styles are being applied to the notification. Thsi should help identify the issue.


[SPRV] AFF fixes due to suggestions

Suggestions of #563 fixed within this pull request

I have just talked to @delucapietro. He will update #563. Therefore, this PR is not required. I close it.