Race condition when publishing selected fields from collection that contains more fields on .insert()

This pertains to this issue:
https://forums.meteor.com/t/issue-with-subscribing-to-certain-fields-in-mongo-collection-crash-when-insert-new-document/29759
Way to reproduce error:
Publish a collection that only contains certain fields you want from that collection
ex. Collection.find({},{fields:{field1:1,field2:1}});
Subscribe to that collection.
Have a page/view open that displays those variables reactively.
Do an .insert() on that collection or do a Meteor.method() that will insert into that collection
Bad news.... :(
Questions you may have:
This is the only publish being subscribed to that updates that Collection on the client(minimongo).
It will also crash the app if a remote client does an .insert()
If {fields:{field1:1,field2:1}} is removed from that publish, the error goes away.
This crash happens client-side only.

what error exactly do you get?

This issue was moved to Urigo/angular-meteor#1473


Use acl id that cloud allocates.

Signed-off-by: GopiKrishna Kodali<EMAIL_ADDRESS>

@nordmark Yes, alpha cloud sends acl id now. I'll mark the local acl id allocation code for deletion later. I just want to keep this bit of local acl id allocation code for a little longer till we know for sure that we won't need it anymore.
I have also committed some more code to export drop flows. Now, drop flows are marked with app id in the MSB and 0xffffff for the rest. Also drop flows when exported to cloud will have acl id filled to ZERO (indication to cloud that these flows are dropped in EVE).


Allow more clippy::not_unsafe_ptr_arg_deref and clippy::transmute_ptr_to_ref

A followup of #451 as it didn't cover the case of impl wrappers.
Currently, if a user provides this code:
use extendr_api::prelude::*;

struct Person {
    pub name: String,
}

#[extendr]
impl Person {
    fn new() -> Self {
        Self {
            name: "".to_string(),
        }
    }

    fn set_name(&mut self, name: &str) {
        self.name = name.to_string();
    }

    fn name(&self) -> &str {
        self.name.as_str()
    }
}

#[extendr]
fn aux_func() {}

// Macro to generate exports
extendr_module! {
    mod classes;
    impl Person;
    fn aux_func;
}

they will get this clippy error and warning:
❯ cargo +nightly clippy
    Checking foooo v0.1.0 (C:\Users\Yutani\Documents\GitHub\foooo)
error: this public function might dereference a raw pointer but is not marked `unsafe`
 --> src\lib.rs:7:1
  |
7 | #[extendr]
  | ^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
  = note: `#[deny(clippy::not_unsafe_ptr_arg_deref)]` on by default
  = note: this error originates in the attribute macro `extendr` (in Nightly builds, run with -Z macro-backtrace for more info)

error: this public function might dereference a raw pointer but is not marked `unsafe`
  --> src\lib.rs:15:28
   |
15 |     fn set_name(&mut self, name: &str) {
   |                            ^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref

error: this public function might dereference a raw pointer but is not marked `unsafe`
 --> src\lib.rs:7:1
  |
7 | #[extendr]
  | ^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
  = note: this error originates in the attribute macro `extendr` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: transmute from a pointer type (`*mut Person`) to a reference type (`&Person`)
 --> src\lib.rs:7:1
  |
7 | #[extendr]
  | ^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
  = note: `#[warn(clippy::transmute_ptr_to_ref)]` on by default
  = note: this warning originates in the attribute macro `extendr` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: transmute from a pointer type (`*mut Person`) to a reference type (`&mut Person`)
 --> src\lib.rs:7:1
  |
7 | #[extendr]
  | ^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
  = note: this warning originates in the attribute macro `extendr` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: `foooo` (lib) generated 2 warnings
error: could not compile `foooo` due to 3 previous errors; 2 warnings emitted

Thanks, this looks good.
I would like to ask again, since I'm not sure what we decided last time, if this particular warning has been solved, why can we not enable it as a clippy lint on the CI, to "prove" that it's been solved, and also check for regressions?

Thanks.

if this particular warning has been solved

I don't think this pull request "solves" anything in actual. It's just that clippy says "hey, it's unsafe!" and we reply "yeah, we don't care!"
If you really think clippy is valuable, you should try it by yourself first. I currently see 6 errors and 63 warnings on my local, which feels a bit overwhelming to check all of them and decide how to fix and whether to dismiss one by one. To be clear, I don't mean clippy is useless. I use it a lot on my local, but I'm afraid we'll have a lot of noise if we enforce it on the CI.


[QUESTION] Train my own metrics without source sentences

Hi Ricardo, thank you so much for your previous answers.
I have a follow-up question regarding to train Comet myself without using any source sentences.
So the input to the system will be translated sentences, reference sentences and the rating of the translations.
Is there a way to do this in the current code base? Thank you in advance.

No, the current models accept either source and translation (Quality estimation setting) or source, translation and reference (MT metrics setting). To support your use case you will have to change the codebase.
Do you want to create a metric that receives translation, reference, and a score right? I think the easiest way is to create something similar to the referenceless.py metric but replacing the source with the reference as text inputs. Regarding the score I would incorporate that input in the feed-forward on top, after the encoding of the text inputs.

tell me if you need any help.

Thank you very much! I will go ahead and modify referenceless.py.
Btw, do you think it is possible for me to change "monitor: val_pearson" in earlystopping.yaml to some customized metrics like kendall correlation?

the WMT kendall-tau like metric based on daRR or just plain Kendall tau?
Modifying it for monitoring "plain" Kendall tau is easy although you will have to implement it. The WMT Kendall-tau based on daRR is going to give you more work ...

Our implementation uses the regression metrics from torchmetrics. They dont have kendall-tau and thats why we only look at Pearson and Spearman... but you can extend their library and build your custom metric like kendall

I did exactly that for the WMT Kendall when building the translation ranking model:  wmt_kendall.py

Cool! Thank you for your quick response. I am trying to build WMT kendall-tau. In this case, can I directly use your script wmt_kendall.py?

you can yes, but you will have to pass the score for the better and worse MT. This means that for regression metrics, during validation, you will have to load a different corpus with 4 texts (source, better MT, worse MT, reference).

Oh I see. Thank you so much! I assumed for ranking model that I can just call your wmt kendall metric with the same corpus.

if you are using the ranking model yes. If you are using regression models you have to adapt the validation part

Great! Thank you for all your answers again.


Utils: localStorage.js

Added the basics and what we might need. Likely will be adding more to this later.


Use info log level when installing rustup

Using the warning log level will show warnings in the files changed section in pull requests. Here are screenshots of such messages:

We can avoid this by using the info log level.

Hm, that's something new, and I agree, rather irritating. Thanks for a PR!

Thanks for the quick merge!
Looking forward to the release! :package:

Well, I was thinking about postponing it till the new rustup version, but it might take a few days maybe, so I'll publish it today a bit later


Handle the key-direction directive

Currently, we must use:
tls-auth [inline] {0,1}
<tls-auth>
...
</tls-auth>

But some configurations use key-direction.

This was fixed in #208 I believe.


Consider adding an ARCHITECTURE.md file

The project is quite complex, so it would help new contributors to reason about things if there was an ARCHITECTURE.md file. It should probably outline the different parts of ORT Server, such as API, Orchestrator and the Workers, and how and why they communicate.

With some Mermaid diagrams, maybe?


chore(deps): update pre-commit hook updates to v0.3.5

This PR contains the following updates:

Package
Type
Update
Change

astral-sh/ruff-pre-commit
repository
patch
v0.3.2 -> v0.3.5

Note: The pre-commit manager in Renovate is not supported by the pre-commit maintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.

Release Notes

astral-sh/ruff-pre-commit (astral-sh/ruff-pre-commit)
v0.3.5
Compare Source
See: https://github.com/astral-sh/ruff/releases/tag/v0.3.5
v0.3.4
Compare Source
See: https://github.com/astral-sh/ruff/releases/tag/v0.3.4
v0.3.3
Compare Source
See: https://github.com/astral-sh/ruff/releases/tag/v0.3.3

Configuration
📅 Schedule: Branch creation - "* * 1 * *" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add "verbose" mode

Currently, this library prints out when it's applying any styles to any views. I suggest we add a verbose flag to enable and disable these prints to the console.

+1
(+2 if you ad verbosity levels ;)

Fixed by 154366f66c00fc6cf0cd6ee1ea98fe2c3dc4546d


[Bug]: The link "Getting Started with Apache Beam Quest" in https://beam.apache.org/get-started/resources/learning-resources/#certifications page is broken

What happened?
The link to the quest is broken.
Issue Priority
Priority: 3 (minor)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[X] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

It should be https://www.cloudskillsboost.google/course_templates/724


🚑 Fix: Fixing Consistency in Layout

Description
Fixing Consistency in Layout across all pages
What
Include updated background and logo changes
Why
Consistency
How
Adding css stylesheet to all pages and updating header in all pages
Verification Steps
Local check by two team members
Checklist:

[ ] This pr is linked to the related trello card
[x] My code follows the style guidelines of this project
[x] I have requested a code review from (at least) two team members
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] This change has been verified by another team member

@ciaranRoche I added the background to index.html only, it was merged before I added the stylesheet to the rest of the pages


test rack CUAV v5 nano icm20689 persistent transfer errors

The test rack's CUAV v5 nano icm20689 IMU appears to be getting stuck with near 100% transfer errors. While in this state the other sensors on the same bus (bmi055 and icm20602) are in good health.
http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-hardware/detail/master/1678/pipeline/586

Several other boards on the test rack with the icm20689 (several other fmu-v5s, holybro durandal) do not exhibit this problem over many test runs.
TODO

is the problem with this particular unit?
does lowering the SPI bus speed help?
should the drivers self reset more aggressively (eg 1000+ consecutive failures)

More examples.
http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-hardware/detail/pr-fmu_rename/1/pipeline/827

Fixed in https://github.com/PX4/Firmware/pull/15004.


Initial implementation of structs in MaterialX

This is a follow on from the previous draft PR #1684 on implementing structs.
This implementation maintains the structs in the shader code.
This is still very much a draft and needs a lot of cleanup, but posting so we can discuss if this direction is worth pursuing.
Looking for feedback on :

Value tokenization, currently it happens during shader generation, but perhaps there a cleaner place to put it in the document parsing, creating some sort of compoundValue subclass of the Value type?
What to do if a struct name clashes with a variable name in the generated shader code, this happened in my testing when I had named my new struct texcoord which is a variable name somewhere in some generated code.
If we need to find a more elegant way to call loadStructTypeDefs, having to add it in many places to get everything to work feels a little clunky/error prone, but perhaps this sort of refactor its beyond the scope of this work.
Do we need/want to support recursively nested structs?  I don't believe the code as it's written will do this, but I think it would be possible.

Tagging @jstone-lucasfilm @niklasharrysson for discussion - happy to jump on a call if thats easier too.

@ld-kerley Great to see this work! I like this direction a lot, where structs can remain unfolded in generated code.
Some feedback on your questions:

About value tokenization: I think it would be great to introduce a CompoundValue (or AggregateValue) class, as a subclass of Value, in order to do the value parsing in one central place, instead of having to deal with the valuestring parsing in many places. This would also let us validate struct values during document validation, and not only during code generation.

For name clashes I'm surprised this doesn't work out of the box. There is a call to registerReservedWords inside registerTypeSyntax, that should handle this. So try tracing from there and see why the struct name is not registered as a reserved word.
https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/source/MaterialXGenShader/Syntax.cpp#L55

For loading in struct types from the document, perhaps we could add initialize/deinitialize methods to ShaderGenerator, to handle such things in a central place. We already have other similar methods that need to be called to initialize generation, for example the registerShaderMetadata call. So all such calls could be collected into a single init method.

For nested structs, it looks like the approach you have take should be able to support this. So that would be nice. That's one of the pros of not unfolding the structs, as that would have been more messy I think.

Ah I see! Yes, obfuscating the struct type names with a suffix sounds like a good idea then.

@niklasharrysson I hit a roadblock when adding a randomly generated suffix to the struct names in the generated shader code.  It means the struct names are not know when the node definition author is writing the shader source, and they need to declare the type of the inputs to their functions in the shader source.
We could opt for a static suffix.  texcoord -> texcoord_typedef, or something, and then node authors would be able to use the less obvious texcoord_typedef type name in their shader code.
Or, we could just not suffix at all, and instead find a way to make the error messages more informative?
The most recent push includes the AggregateValue update, and I was considering postponing the centralized initialize/deinitialize refactor for the ShaderGenerator to a separate PR, just to keep this one manageable.

@ld-kerley Aha, yes that's a roadblock indeed! :)
A codegen added static suffix feels a bit awkward, since as you note, node authors need to be aware of this and append the suffix in all shader code using this data type. Perhaps it's better then to not add a suffix at all during codegen, and instead introduce a naming convention for custom data types, that authors must follow?
For example, something like:
A custom type name should have a suffix that declare the semantic of the type. Example: texcoord_struct
In addition, if the type is declared outside of stdlib, it should have a namespace prefix to minimize name collisions. Example:  pxr_texcoord_struct, maya_light_struct, etc.
Would be great to have better error messages if collisions do occur. I'm not sure how though, since it's the target language compiler that finds this.
Sounds good to postpone the centralized initialize/deinitialize to another PR.

@niklasharrysson I really like the _struct suffix idea.  We can add a step in the document validation to check for it.  Do we want to block a render, ie. fail code gen, if we don't have the suffix?  I can imagine someone could very well get lucky and not clash.  Do we have other examples (I think we do because I've hit them) where a document could be invalid, but still render exactly as intended?
Also you suggest using the semantic of the type, does that mean that this example from the current spec
<typedef name="spectrum" semantic="color"/>
should be re-written to
<typedef name="spectrum_color" semantic="color"/>
?
Or perhaps this suggestion infers a completely new XMLTag/MaterialX type?  <structdef> ? and we would leave <typedef> alone as its written in the new spec (with no <member> child tag). That way the new concept can more cleanly have its own set of rules?
<structdef name="texcoord_struct">
  <member name="ss" type="float" value="0.5"/>
  <member name="tt" type="float" value="0.5"/>
</structdef>

Given this feature never worked before, it doesn't seem too difficult, from a backwards compatibility perspective, to pivot this way?  Perhaps @dbsmythe or @jstone-lucasfilm have input here?

@ld-kerley About validation of a naming convention, I'm not sure we need to do that, since even if we do there is no guarantee that this will help to resolve name conflicts. At least in theory, a node author could use the same name for a variable in the code added for a node implementation, even if both a prefix and suffix is used.
So perhaps the best we can do is to provide guidelines for how to name you data types and identifiers. And if there is a conflict anyway, resulting in shader compile errors, it's up to the node author to resolve it.
With this in mind perhaps it would be best to just stick with the typedef element, even for structs. It feels more consistent since after all it's a type you're defining.
As for the naming convention to use, the one I gave was just an example, and it would be great to get others feedback on this as well.

@ld-kerley We've now merged development work on MaterialX 1.39 back to the main branch of MaterialX, in preparation for the final weeks of development on the 1.39.0 release.  When you have a chance, could you retarget this pull request back to the main branch as well?

@jstone-lucasfilm - done - and also pushed my latest.
@niklasharrysson - this includes the _struct suffix, to the example only - no validation.  And also now should allow for structs-of-structs - including in the GLSL/MSL rendering path.
Logged an issue (#1850) for the common init/de-init for ShaderGeneration.

I think all the tests are passing now and I addressed the @niklasharrysson notes above - moving the the example scenes to the test suite required a little re-working of the testing framework to add another libraries location to the search path.

Addressing some notes from @jstone-lucasfilm - and also removing the unit testing changes - these will be added at a later date once this is merged.

@ld-kerley This change looks ready to merge, but it would benefit from a new description, since it's no longer a draft seeking feedback from the team!  Would you like to write up a new description before we merge this?


[BUG]: Admin | Sync Template v3 (Sync Flow Errors)

Core Components 1.98
Since upgrading core components last week to 1.98 the Sync Flow Errors flow is running but the notification is not being delivered to the Admin Email address defined in environment variable.

Headers before upgrade:

After upgrade to 1.98

Dave

Apologies...I just saw/read bug #815.  I'll follow that approach until the April update is released.

No problem at all, apologies for the inconvenience, and thanks for doing that research! And thanks for using CoE.
Duplicate of #815


Change eventhub management sdk to track2

Change eventhub management sdk to track2
@jongio for notification

The commit https://github.com/Azure-Samples/eventhub-java-manage-event-hub/commit/74ef3bbd5fa7269bbc8b04ee242a302e2e5d20a6 changed it and merged.


Set time zone config to London

Description of change
Same as in Review for consistency.
https://github.com/ministryofjustice/laa-review-criminal-legal-aid/pull/311

Requires some further investigation. Marking as do not merge for now.

Closing. Superseded by #384.


Tzx support - closes #56

Supports the most commonly used TZX blocks. Does not support the dreaded GDB (0x19) block.

Hello 👋 Nice work! I'll take look at it in a week 🕐

No worries @pacmancoder !

@pacmancoder  Addressed all the PR comments!

Hi @ArjunNair, could you please allow edits in PR for me? I need to fix CI issues before merge

Hi @ArjunNair, could you please allow edits in PR for me? I need to fix CI issues before merge

It's already set as far as I can tell:

Is there some other setting I need to enable?


Element Placement

Is it worth noting that the order of the elements are enforced? As in the BuildingBlocks shown above must appear in that order.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fcae62a-0cfd-d310-df15-ad163eacac8b
Version Independent ID: 3ec17196-68a3-eb33-d6f7-0d5f7cc55d91
Content: BuildingBlocks - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/buildingblocks.md
Service: active-directory
GitHub Login: @davidmu1
Microsoft Alias: davidmu

@WhippsP Thanks for your feedback! We will investigate and update soon on it.

@WhippsP Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.
@davidmu1 Can you please help adding a documentation note about the same.

Specifically, the Predicates and PredicateValidations elements must be placed after the ClaimsSchema element and before the ClaimsTransformations one.

@WhippsP We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Traffic-manager endpoint create: Parsing issue with --min-child-endpoints, --min-child-ipv4, --min-child-ipv6

Describe the bug
Unable to create an endpoint when specifying any of: --min-child-endpoints, --min-child-ipv4, --min-child-ipv6.
The command fails with:
Expect <class 'int'>, got <class 'str'>
Related command
az network traffic-manager endpoint create --name {} --profile-name {} --resource-group {} --type nestedEndpoints --endpoint-status Enabled --target-resource-id {} --min-child-endpoints 1 --min-child-ipv4 1 --min-child-ipv6 1 --priority 3 --subscription {}
Errors
The command failed with an unexpected error. Here is the traceback:
Expect <class 'int'>, got 1 (<class 'str'>)
Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/custom.py", line 5254, in create_traffic_manager_endpoint
    return Create_Endpoint(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 149, in __call__
    return self._handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/aaz/latest/network/traffic_manager/endpoint/_create.py", line 35, in _handler
    super()._handler(command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 153, in _handler
    self.ctx = AAZCommandCtx(
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command_ctx.py", line 32, in __init__
    self.args[dest] = cmd_arg
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_value.py", line 76, in __setitem__
    self._data[name] = attr_schema.process_data(data, key=name)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_type.py", line 48, in process_data
    raise AAZInvalidValueError('Expect {}, got {} ({})'.format(self.DataType, data, type(data)))
azure.cli.core.aaz.exceptions.AAZInvalidValueError: Expect <class 'int'>, got 1 (<class 'str'>)

Issue script & Debug output
cli.knack.cli: Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x7f8d6b337f40>, <function CLIQuery.handle_query_parameter at 0x7f8d6b3851b0>, <function register_ids_argument.<locals>.parse_ids_arguments at 0x7f8d6a40d630>]
cli.azure.cli.core.azclierror: Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/custom.py", line 5254, in create_traffic_manager_endpoint
    return Create_Endpoint(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 149, in __call__
    return self._handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/aaz/latest/network/traffic_manager/endpoint/_create.py", line 35, in _handler
    super()._handler(command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 153, in _handler
    self.ctx = AAZCommandCtx(
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command_ctx.py", line 32, in __init__
    self.args[dest] = cmd_arg
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_value.py", line 76, in __setitem__
    self._data[name] = attr_schema.process_data(data, key=name)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_type.py", line 48, in process_data
    raise AAZInvalidValueError('Expect {}, got {} ({})'.format(self.DataType, data, type(data)))
azure.cli.core.aaz.exceptions.AAZInvalidValueError: Expect <class 'int'>, got 1 (<class 'str'>)

cli.azure.cli.core.azclierror: The command failed with an unexpected error. Here is the traceback:
az_command_data_logger: The command failed with an unexpected error. Here is the traceback:
cli.azure.cli.core.azclierror: Expect <class 'int'>, got 1 (<class 'str'>)
Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/custom.py", line 5254, in create_traffic_manager_endpoint
    return Create_Endpoint(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 149, in __call__
    return self._handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/aaz/latest/network/traffic_manager/endpoint/_create.py", line 35, in _handler
    super()._handler(command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 153, in _handler
    self.ctx = AAZCommandCtx(
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command_ctx.py", line 32, in __init__
    self.args[dest] = cmd_arg
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_value.py", line 76, in __setitem__
    self._data[name] = attr_schema.process_data(data, key=name)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_type.py", line 48, in process_data
    raise AAZInvalidValueError('Expect {}, got {} ({})'.format(self.DataType, data, type(data)))
azure.cli.core.aaz.exceptions.AAZInvalidValueError: Expect <class 'int'>, got 1 (<class 'str'>)
az_command_data_logger: Expect <class 'int'>, got 1 (<class 'str'>)
Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/custom.py", line 5254, in create_traffic_manager_endpoint
    return Create_Endpoint(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 149, in __call__
    return self._handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/aaz/latest/network/traffic_manager/endpoint/_create.py", line 35, in _handler
    super()._handler(command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command.py", line 153, in _handler
    self.ctx = AAZCommandCtx(
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_command_ctx.py", line 32, in __init__
    self.args[dest] = cmd_arg
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_value.py", line 76, in __setitem__
    self._data[name] = attr_schema.process_data(data, key=name)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/aaz/_field_type.py", line 48, in process_data
    raise AAZInvalidValueError('Expect {}, got {} ({})'.format(self.DataType, data, type(data)))
azure.cli.core.aaz.exceptions.AAZInvalidValueError: Expect <class 'int'>, got 1 (<class 'str'>)
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x7f8d6a37edd0>]
cli.__main__: Command ran in 0.699 seconds (init: 0.167, invoke: 0.532)

Expected behavior
Succeed and return json values.
Example:
{
  "alwaysServe": "Disabled",
  "endpointMonitorStatus": "Stopped",
  "endpointStatus": "Enabled",
  "id": "some-id",
  "minChildEndpoints": 1,
  "minChildEndpointsIPv4": 1,
  "minChildEndpointsIPv6": 1,
  "name": "some-name",
  "priority": 3,
  "resourceGroup": "some-resource-group",
  "target": "some-target",
  "targetResourceId": "some-target-resource-id",
  "type": "Microsoft.Network/trafficManagerProfiles/nestedEndpoints",
  "weight": 1
}

Environment Summary
azure-cli                         2.49.0

core                              2.49.0
telemetry                          1.0.8

Extensions:
acrtransfer                        1.1.0
aks-preview                      0.5.141
azure-devops                      0.26.0
virtual-wan                       0.2.17

Dependencies:
msal                              1.20.0
azure-mgmt-resource               22.0.0

Python location '/opt/az/bin/python3'
Extensions directory '/home/angelgh/.azure/cliextensions'
Extensions system directory '/opt/az/lib/python3.10/site-packages/azure-cli-extensions'

Python (Linux) 3.10.10 (main, May 19 2023, 08:20:32) [GCC 9.4.0]

Additional context
This issue seems similar to the following issues:

#26274
#26248
#26379

Those were fixed by:

#26260
Which added type=int to the arguments.

A quick look seems to indicate issue is the same with --min-child-endpoints, --min-child-ipv4, and --min-child-ipv6.
Adding type=int might fix it.

Thank you for opening this issue, we will look into it.


Add awesome-password-cracking

Tools, research, papers and other projects related to password cracking and password security.
https://github.com/narkopolo/awesome-password-cracking

Thank you @narkopolo!


Furniture - All

After reaaaaaaally testing, I realize that an All section is needed for furniture.  Should be at the top.

Unsure about how to do this one due to how how this handles json.  Might focus on a search option instead.


http: added support for %REQUESTED_SERVER_NAME% to extract SNI as a custom header (Fixes #19024)

This PR adds a new command operator in the header formatter called %REQUESTED_SERVER_NAME% which can be used to extract the SNI information from the stream and set it as a custom header.
Commit Message: Added support for %REQUESTED_SERVER_NAME% to extract the SNI as a custom header.
Additional Description: Adds a new command operator called %REQUESTED_SERVER_NAME% in the http header formatter which can be used to extract the SNI information from the stream and set it as a custom header.
Risk Level: Low
Testing: Unit Tests
Docs Changes: Added description on %REQUESTED_SERVER_NAME% in the docs.
Release Notes: Added
Platform Specific Features: N/A
Signed-off-by: Rohit Agrawal<EMAIL_ADDRESS>

/assign

/retest

/assign-from @envoyproxy/first-pass-reviewers

/retest


Docs: State how to turn off status bar text

Added note in the README.md "Settings" section about how to turn off the status bar text.
Fixes: #287

grrr, wrong fork


stuck at mmap called, function address for any android app

If i try to inject to a test app then it works fine.
but when i try to inject to android app then it gets stuck here
it is basically stuck at this line
long result=ptrace(PTRACE_GETREGS, pid, NULL, regs);
result is less than 0 so it is basically unable to get the regs value
Any solution to it???
aosp:/ # ./data/local/tmp/injector 18978
process name: nextapp.fx, library path: /data/data/nextapp.fx/lib/libtest.so, pid: 18978
Injection started...
Attached to process 18978
mmap called, function address c3bb48b0 process 18978 size 1024
Write 8 bytes to 0xc76bc7d4 process 18978

this tool does not support emulators.
i was testing on emulator so that is why i was getting these errors
testing same code on mobile devices should work fine.


Randomly amp.http.client.har.timings.complete is missing

When using RecordHarAttributes sometimes after a response completes the attribute amp.http.client.har.timings.complete is missing.
I cannot reproduce this consistently. It seems to be random.
This is what i use:
$builder = (new HttpClientBuilder)
            ->interceptNetwork(new DecompressResponse());

$client = $builder->build();

$promise = call(function () use ($client, $url) {
    $request = new Request($url);
    $request->addEventListener(new RecordHarAttributes());

    $response = yield $client->request($request);
    yield $response->getBody()->buffer();

    ///   Symfony\Component\Debug\Exception\FatalThrowableError  : The requested attribute 'amp.http.client.har.timings.complete' does not exist
     $responseTime = $response->getOriginalRequest()->getAttribute(HarAttributes::TIME_COMPLETE) - $response->getOriginalRequest()->getAttribute(HarAttributes::TIME_START);

});
$responses = wait(all([$promise]));

It is possible that its related to redirects, some of the domains i try do have redirects, but it still happens randomly

You need to await the trailers promise before accessing the attribute. However, you're using an internal API without BC guarantees, so be careful. Please use your own event listener or use the LogHttpArchive interceptor directly.

ahhh, that makes perfect sense i see it in the LogHttpArchive now. Thanks

I seem to have celebrated prematurely. Using the example from the docs (a bit adapted) i sometime get empty har files.
Loop::run(static function () {
    try {
        $client = (new HttpClientBuilder)
            ->intercept(new LogHttpArchive('/tmp/1.txt'))
            ->followRedirects(2)
            ->build();

            /** @var Response $response */
            $response = yield $client->request(new Request(XXX));

        }
     catch (\Exception $error) {
        echo $error->getMessage();
    }
});

Going to LogHttpArchive and adding a message to this silenced exception:
try {
    yield $response->getTrailers();
} catch (\Throwable $e) {
    echo $e->getMessage();
    // ignore, still log the remaining response times
}

reveals the following: The operation was cancelled

Do you consume the response body every time? Do the requests use HTTP/1.1 or HTTP/2?

i do not consume the response body in this case, the requests are HTTP/1.1

If you don't consume the body and the body stream is GCed, the request is automatically aborted.
If that also happens if the body is consumed, I'll have to look into it.

Ok, let me give it a go with a few thousand requests with body consumption and will report if it happens again.

The combination of the body consumption yield $response->getBody()->buffer(); and a custom har interceptor in the client build process (instead of registering manually on each request) seems to work fine.
Again thanks for the help

There is something weird going on still, but this is probably due to something i do rather than the http client.
The basic example (from above works), but when i apply the changes to my project i start getting socket disconnections and operation cancelled again.

If you share the code, I might be able to have a look.

Sure, this is my interceptor (adapted from the LogHttpArchive to include only what i need:
use Amp\CancellationToken;
use Amp\Http\Client\ApplicationInterceptor;
use Amp\Http\Client\DelegateHttpClient;
use Amp\Http\Client\EventListener\RecordHarAttributes;
use Amp\Http\Client\Request;
use Amp\Http\Client\Response;
use Amp\Promise;
use function Amp\call;
use function Amp\Promise\rethrow;

final class RecordHarAttributesApplication implements ApplicationInterceptor
{
    private $eventListener;

    /** @var \Throwable|null */
    private $error;

    public function __construct()
    {
        $this->eventListener = new RecordHarAttributes();
    }

    public function request(
        Request $request,
        CancellationToken $cancellation,
        DelegateHttpClient $httpClient
    ): Promise {
        return call(
            function () use ($request, $cancellation, $httpClient) {
                if ($this->error) {
                    throw $this->error;
                }

                $this->ensureEventListenerIsRegistered($request);

                /** @var Response $response */
                $response = yield $httpClient->request($request, $cancellation);

                rethrow(call(function () use ($response) {
                    try {
                        yield $response->getTrailers();
                    } catch (\Throwable $e) {
                        // ignore, still log the remaining response times
                    }
                }));

                return $response;
            }
        );
    }

    private function ensureEventListenerIsRegistered(Request $request): void
    {
        foreach ($request->getEventListeners() as $eventListener) {
            if ($eventListener instanceof RecordHarAttributes) {
                return; // user added it manually
            }
        }

        $request->addEventListener($this->eventListener);
    }
}

And here is a simple use case (it doesnt work unless you yield the trailers in the main app too):
Loop::run(
            static function () {
                $builder = (new HttpClientBuilder)
->followRedirects(2)
->intercept(new SetRequestTimeout(5000, 5000, 5000))
->interceptNetwork(new DecompressResponse())
->intercept(new RecordHarAttributesApplication());
                $client = $builder->build();

                $url = "XXX";

                try {
                        /**
                         * @var $response Response
                         */
                        $request = new Request($url);
                        $request->setBodySizeLimit(1024*1024*2);

                        $response = yield $client->request($request);

                        // trailers do not complete unless you get the body too
                        yield $response->getBody()->buffer();
                        // seems i must yield trailers here too?
                        yield $response->getTrailers();

                        $responseTime = $response->getRequest()->getAttribute(HarAttributes::TIME_COMPLETE) - $response->getRequest()->getAttribute(
                                HarAttributes::TIME_START
                            );
                        echo $responseTime;
                }
            }
        );

This produces various errors (from above comments) but in the end, here is the uncaught one (unless you have the                         yield $response->getTrailers(); in the main app too as i've given the example)
The requested attribute 'amp.http.client.har.timings.complete' does not exist

This is expected, because the body stream is completed first, then EventListener::completeReceivingResponse() is called and only after all those operations completed, the trailers promise is resolved. So RecordHarAttributes sets the attribute after the body is complete and it won't be reliably available if you don't await the trailers. While trailers aren't used much, they also act as a "response complete" placeholder here.

hmm, ok im a bit confused i guess. What is the reason for resolving trailers in the:
RecordHarAttributesApplication::request if i have to resolve them again later in the main app?


Stoping audio before component unmount, not working

:beetle: Description
Currently using this package for a chat app.  before  i un-mount the component. am calling the stop() method  to stop the audio, but it keeps playing in the background.

To stop the audio currently playing when the user leaves the page.
:beetle: What have you tried?
tried calling the stop() and even d pause(), not working.

:beetle: Please post your code:
// Please post your code

const AudioPlayer = ({audioData, isUser}: any) => {
  const {data} = audioData;
  const navigation = useNavigation();
  // console.log('audio data', JSON.stringify(data?.url, null, 2));
  const song = {
    id: data?.asset_id,
    url: data?.url, // Load media from the network
    title: data?.asset_id,
    duration: data?.duration, // Duration in seconds
  };

  const [audio, setAudio] = useState<SoundPlayer>();
  const [duration, setDuration] = useState(0);
  const [currentTime, setCurrentTime] = useState(0);

  const Initialize = () => {
    let newSong = new SoundPlayer(song?.url, '', error => {
      if (error) {
        console.log('error Init', error);
        return;
      }

      setDuration(newSong.getDuration());
    });
    setAudio(newSong);
  };

  function seekToTime(seconds: number) {
    if (audio) {
      audio.setCurrentTime(seconds);
      setCurrentTime(seconds);
    }
  }

  function playPause() {
    if (audio) {
      if (audio?.isPlaying()) {
        audio.pause();
      } else {
        audio.play();
      }
    }
  }

  //stop audio
  function stop() {
    if (audio) {
      audio.stop();
    }
  }

  useEffect(() => {
    const unsub = Initialize();
    return unsub;
  }, []);

  useEffect(() => {
    let audioInterval = setInterval(() => {
      audio?.getCurrentTime((seconds: number, play) => {
        setCurrentTime(seconds);
      });
    }, 100);

    return () => {
      clearInterval(audioInterval);
    };
  }, [song]);

  useEffect(() => {
    const unsubscribe = navigation.addListener('beforeRemove', () => {
      audio?.stop();
      audio?.release();

      console.log('this component is about to be removed');
    });
    return unsubscribe;
  }, [navigation]);

  return (
    <View style={styles.audioContainer}>
      <TouchableOpacity
        onPress={playPause}
        disabled={!audio?.isLoaded()}
        style={[
          styles.playPauseWrapper,
          {borderColor: isUser() ? colors.bootomHeaderBg : colors.secondaryBg},
        ]}>
        {audio?.isLoaded() ? (
          <Ionicons
            name={audio?.isPlaying() ? 'pause' : 'play'}
            color={isUser() ? colors.bootomHeaderBg : colors.secondaryBg}
            size={hp(18)}
          />
        ) : (
          <Ionicons
            name={'stop'}
            color={isUser() ? colors.bootomHeaderBg : colors.secondaryBg}
            size={hp(18)}
          />
        )}
      </TouchableOpacity>
      <View style={{position: 'relative', height: hp(35)}}>
        <Slider
          //@ts-ignore
          value={currentTime}
          minimumValue={0}
          maximumValue={duration}
          onComplete={(value: any) => {
            console.log('value from slider', value);
            seekToTime(value);
          }}
          onChange={(value: any) => {
            console.log('value from slider 2', value);
            seekToTime(value);
          }}
          thumbSize={20}
          progressTrackColor={
            isUser() ? colors.bootomHeaderBg : colors.secondaryBg
          }
          trackStyle={{
            width: 150,
            height: hp(5),
            borderRadius: hp(3),
            backgroundColor: colors.darkGray,
          }}
          thumbStyle={{
            width: 15,
            height: 15,
            borderRadius: hp(10),
            backgroundColor: isUser()
              ? colors.bootomHeaderBg
              : colors.secondaryBg,
          }}
        />

        <Text
          style={[
            styles.lenghtStart,
            {color: isUser() ? colors.bootomHeaderBg : colors.dark},
          ]}>
          {formatTimeString(currentTime)}
        </Text>
        <Text
          style={[
            styles.lenghtEnd,
            {color: isUser() ? colors.bootomHeaderBg : colors.dark},
          ]}>
          {formatTimeString(duration ?? song?.duration)}
        </Text>
      </View>
    </View>
  );
};

:bulb: Possible solution

Is your issue with...

[ *] iOS
[* ] Android
[ ] Windows

Are you using...

[ *] React Native CLI (e.g. react-native run-android)
[ ] Expo
[ ] Other: (please specify)

Which versions are you using?

React Native Sound:
"react-native-sound": "^0.11.2",
React Native:
"react-native": "0.69.7",
iOS:
Android:
Windows:

Does the problem occur on...

[ *] Simulator
[ *] Device

If your problem is happening on a device, which device?

Device:

Please any one who can help on this ?

@tdammy92 I am facing same issue. Did you find any solution?

@mayur-shelar not yet , I might just remove the package completely. cause why would sound continue playing when user has left the screen.  I want to belive there is somthing we might be missing out. but no body is even ready to help. 🤷🏽♂

@tdammy92 I am able to stop the audio before the screen unmount. Simply add audio in the dependency array of useEffect were you are performing the operations which are to done before unmount. In our case it will like
`  useEffect(() => {
const unsubscribe = navigation.addListener('beforeRemove', () => {
audio?.stop();
audio?.release();
  console.log('this component is about to be removed');
});
return unsubscribe;

}, [navigation, audio]);`
When the component mounts the state variable audio is empty. So what I found while debugging is when listener is triggered audio was undefined when audio was not passed in the dependency array.

@mayur-shelar Thank you very much bro, Your a life saver.


Ca 43 santa rosa scraper

Created the Scrape-meta and Scrape for Santa Rosa Police Website

The minor changes to the SD and cache code both look unobjectionable to me, but wanted to check with @zstumgoren to make sure those are reasonable changes. I'll begin review of the main santa rosa downloader script...

hey @tarakc02 this pull request is asking for a approval from maintainers, can you please ask a maintainer to approve thanks.
Also how can i lint and format with pre-commit.

hey @tarakc02 this pull request is asking for a approval from maintainers, can you please ask a maintainer to approve thanks. Also how can i lint and format with pre-commit.

Hey @naumansharifwork Looks like there's a minor linting issue. Can you try installing precommit based on these docs and running locally using below steps?

Navigate to root of repo
pipenv run precommit

Note that some contributors have had headaches running precommit locally -- it can be a pain -- so if you run into issues, ping back and one of us can clone your work and run for you. Thanks!

Hey @zstumgoren i have ran pipenv run pre-commit what should i do next?

Great. Looks like there are no errors from the screenshot. If pre-commit changed any files then commit/push those changes to your branch. That should trigger another run of code checks on GiHub. I can check to see if everything is passing and if so will merge.
If pre-commit doesn't produce changes, then I would review the errors on GitHub and change them manually on your local fork.

@zstumgoren  i have checked from github logs the linting was failed so i manually checked and fixed those and re-committed,
also the command to run pre-commit is "pipenv run pre-commit run --all-files" this checks on all files from previous command it was missing files

@zstumgoren i have checked from github logs the linting was failed so i manually checked and fixed those and re-committed, also the command to run pre-commit is "pipenv run pre-commit run --all-files" this checks on all files from previous command it was missing files

Excellent. Thanks for circling back on that! Looks like all checks are passing, so going to merge. Huge thanks for the contribution!


upgrade to Wagtail 2.10

Upgrade bakerydemo to use Wagtail 2.10 and Django 3.1
I elected to use wagtail.contrib.legacy.richtext so as not to have to change '.rich-text img' style in main.css. Would people like that to be done differently?

Thanks @cnk!
I think it would be good to eliminate the .rich-text style, since people often borrow code from bakerydemo and I wouldn't really want wagtail.contrib.legacy.richtext to be common practice. As far as I can recall, most or all of the rich text areas where we'd want to include images are StreamField rich text blocks, so that should give us an alternative container element to attach the style to - that can be done in a separate PR though.
We should also update our initial-data fixture to populate the new slug field on form fields, so that we aren't relying on the system check to fill it in on first startup (which will fail when we drop the unidecode library in 2.12).


No highlighting with typst-lsp.semanticTokens set to disable

Component:

VSCode Extension:

Extension version:  0.9.3
LSP version:  0.9.3
OS version and name: Windows 11 23H2

I am on the latest stable version of the extension/LSP.
I have searched the issues of this repo and believe that this is not a duplicate.

Issue
If I set "typst-lsp.semanticTokens": "disable" in my settings.json, then I get no syntax highlighting at all. I was expecting it to fall back to the rudimentary highlighting that existed before.

That was my original intention, but VS Code seems to make this hard. Semantic tokens are enabled/disabled as part of the LSP, so can be toggled controlled by configuration. However, VS Code TextMate syntax highlighting (what was used before) is controlled by package.json, so it's either enabled or disabled unless you modify and reinstall the extension.
If TextMate and semantic token highlighting are both enabled at once, the semantic tokens appear on top of TextMate (this is the intention behind semantic tokens; the stated purpose is to highlight just a few things based on semantics that TextMate can't do by syntax, like based on if a variable is mutable or not). However, the TextMate grammar is out of date; I don't think it's been updated since it was pulled from an early version of Typst (but see #256 for a possible small update). It's hard to maintain the TextMate grammar because Typst's syntax is still in flux, whereas semantic token highlighting "just works" because it's based on Typst's own parser. If the TextMate grammar makes up the background of the semantic tokens, errors in it could highlight the code wrong, and it would have some cost for VS Code to perform TextMate highlighting.
If there is some way of enabling or disabling highlighting by configuration, I'd love to incorporate it. Without that, the best solution would probably be to make a separate extension that just provides highlighting.


Clarification in DLQ documentation

The first question I had when I read this section is what is the name of the DLQ topic. I found the answer in the Java API docs, but I think it makes sense to include it in this section, especially since this feature now also works in the Websocket client. I added the name of the default dead letter queue and an example of how to specify the DLQ name.

(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #
(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)
Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

run cpp tests


synchronize schema spec

What
APM agent json schema automatic sync
Why
Changeset

https://github.com/elastic/apm-server/commit/6dbbc4c23 Make service target backward compatible with destination resource (https://github.com/elastic/apm-server/pull/7925)

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-05-18T09:50:37.562+0000

Duration: 17 min 31 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
3514

Skipped
3187

Total
6701

Steps errors
Expand to view the steps failures

Restore files previously stashed

Took 4 min 0 sec . View more details here
Description: source

Restore files previously stashed

Took 4 min 0 sec . View more details here
Description: source

Restore files previously stashed

Took 0 min 0 sec . View more details here
Description: coverage-3.8-none

Restore files previously stashed

Took 0 min 0 sec . View more details here
Description: coverage-3.9-none

Archive the artifacts

Took 0 min 0 sec . View more details here
Description: [2022-05-18T10:07:04.858Z] Archiving artifacts
Unable to create live FilePath for apm-ci-immutable-

Error signal

Took 0 min 0 sec . View more details here
Description: hudson.remoting.RequestAbortedException: java.nio.channels.ClosedChannelException

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

:globe_with_meridians: Coverage report

Name
Metrics % (covered/total)
Diff

Packages
100.0% (68/68)
:green_heart:

Files
100.0% (225/225)
:green_heart:

Classes
100.0% (225/225)
:green_heart:

Lines
89.237% (16251/18211)
:-1: -0.005

Conditionals
76.392% (3032/3969)
:+1:


Feedback: Editor controls & more

I just test-drove v0.2.2. Wow, feels great!
What I'm missing is a bunch of editor controls:

Commit / enter: I would want to choose when to reload the map with all the changes I made. (In contrast to: reload it on unfocus of a form field.)
Undo: I would want to undo the last action. (An action history would be perfect of course at some point.)
Inspect: I want to be able to choose a layer by clicking onto the map. This could be onclick (interferes with zoom though, so we'd need +/- controls on the map) or on right click (context menu) or behind an "Inspect" button. (I had expected this behind the current inspect button.) Despite the zoom interference I'd probably prefer onclick.

Commit and Undo should also be assigned keyboard shortcuts.
Furthermore it would be nice:

if the editor would support location hashes. I want to be able to append a hash such as #10/47.2608/11.4143 to the URL, to edit a specific area of the map.
if one could directly edit the JSON code, too. Of course this would create the need of basic JSON error handling.
if templates of values used within the current style sheet would be available for form fields. (Such as in Mapbox Studio.)

And one special wish: JSON doesn't support code comments, yet it would be nice to be able to save a comment within layers, so I'll later remember what I was thinking when deciding for specific values. This could be achieved via the metadata property:
"metadata": {
        "maputnik:comment": {
            "Save here what I was thinking when creating this layer.
            },

Awesome! Thanks a lot for the feedback Helge! That's exactly what I want.

Commit / enter: I would want to choose when to reload the map with all the changes I made. (In contrast to: reload it on unfocus of a form field.)

Could you elaborate on that?
Why is a explicit style change necessary? All changes made will always immediately in the map. Isn't that the most convenient way to do styling and also most UX friendly?

Undo: I would want to undo the last action. (An action history would be perfect of course at some point.)

Undo is on the roadmap #25.

Inspect: I want to be able to choose a layer by clicking onto the map. This could be onclick (interferes with zoom though, so we'd need +/- controls on the map) or on right click (context menu) or behind an "Inspect" button. (I had expected this behind the current inspect button.) Despite the zoom interference I'd probably prefer onclick.

Inspect mode is on the roadmap #26

if the editor would support location hashes. I want to be able to append a hash such as #10/47.2608/11.4143 to the URL, to edit a specific area of the map.

Good idea! Continues in #27

if one could directly edit the JSON code, too. Of course this would create the need of basic JSON error handling.

You mean editing the entire JSON file? Instead of editing the layer JSON spec?
Editing the layer JSON spec should work (well error handling etc is missing but as proof of concept).

if templates of values used within the current style sheet would be available for form fields. (Such as in Mapbox Studio.)

I also like the idea of templates. It is however a more advanced solution that always requires preprocessing of the style.
This is probably most useful for colors and fonts - so when we you at least can choose from a predefined defaults in the style metadata (or just show the already existing values) would be a compromise.

And one special wish: JSON doesn't support code comments, yet it would be nice to be able to save a comment within layers, so I'll later remember what I was thinking when deciding for specific values. This could be achieved via the metadata property:

That's also straightforward to implement. Let us keep that in the backlog. #28

Commit / enter: I would want to choose when to reload the map with all the changes I made. (In contrast to: reload it on unfocus of a form field.)

This makes sense when editing JSON by hand.. there it is not comfortable if the editor reformats your now correct JSON each time.

Awesome!
As to commit/enter: You are right, it's ok as it is implemented (and saves one click). However I would only apply changes on unfocus, not at every key stroke. (However those are just minor details.)
I love the new JSON edit function. This way current shortcomings as e.g. the missing control to add filters can easily be worked around.
Inspect: I actually meant stylesheet layer inspection, not source layer inspection aka X-ray view. (I didn't dare to suggest the latter as I thought that's too big a feature for an early version.) Both is implemented meanwhile, great!
We'll soon switch our editor to Maputnik, so expect some real-world feedback from me in the coming weeks :-)

Such feedback is always great :)

As to commit/enter: You are right, it's ok as it is implemented (and saves one click). However I would only apply changes on unfocus, not at every key stroke. (However those are just minor details.)

You're right. Makes sense on loose focus #46

We'll soon switch our editor to Maputnik, so expect some real-world feedback from me in the coming weeks

Nice. I am working on styles with it now and that is actually an important part of the process to figure out whether it is actually comfortable to edit styles that way.


[iOS] Fix NullReferenceException when MediaElement methods are called before setting Source

Description of Change

This PR updates the iOS MediaElementRenderer to ignore Play()/Pause()/Stop() events if AVPlayerItem is not yet set (using constructor or AVPlayer.replaceCurrentItem(AVPlayerItem?), which is called when the Source is updated).
Bugs Fixed

Fixes #414

API Changes
None

Behavioral Changes

PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[x] Rebased on top of main at time of PR
[x] Changes adhere to coding standard

[ ] Updated documentation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: daniel-shuy sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@daniel-shuy thank you for this! Have you actually tried to reproduce this?
I tried to reproduce to verify this fix, but I can't seem to be able to, so maybe it was already fixed somehow? Or am I overlooking something?
I took the current main branch, removed the Source from the MediaElement and added a button that calls the Play method on the MediaElement but nothing happens with the current code as well.

Sorry, I made the fix based on what was reported in #414 without testing it myself, but looking closer at it I realize that the bug is actually in Xamarin.Forms' MediaElement, and it seems like the XamarinCommunityToolkit's MediaElement doesn't have this same issue.


To-be-deleted cookies not deleted

When the server wants to delete a cookie on the client, it sets the cookie with an expiration date in the past. However, the cookie is not deleted on the client as expected, but will be sent with the next request. Happens only with the Jetty-based HTTP web connection.

Incoming cookies with a negative max age, i.e. an expiration date in the past, were rejected by mistake on the client.


TTT Application Overhaul

Everything that has been done until this moment regarding the Hello World App.

It was closed because the project was not presented.


Fixtures with pytest.mark.fixture() with parametrize in test functions

Currently the example below doesn't work. I'd expect to produce the equivalent of the last test function.
Probably the parametrize decorator should take precedence over the parametrized fixture, as the other parametrization is not explicit.
Hope to help in development soon.
import pytest

@pytest.fixture(params=[1, 2, 3])
def one(request):
    return request.param

@pytest.fixture(params=[pytest.mark.fixture('one')])
def as_str(request):
    return str(request.getfixturevalue('one'))

# doesn't work. Fixture 'a'/'b'/'c' not found
@pytest.mark.parametrize('val', ('a', 'b', 'c'))
def test_as_str(val, as_str):
    combined = ''.join((val, as_str))
    assert combined in {'a1', 'a2', 'a3', 'b1', 'b2', 'b3', 'c1', 'c2', 'c3'}

# test_as_str expected
@pytest.mark.parametrize('val_2', ('1', '2', '3'))
@pytest.mark.parametrize('val_1', ('a', 'b', 'c'))
def test_parametrize(val_1, val_2):
    combined = ''.join((val_1, val_2))
    assert combined in {'a1', 'a2', 'a3', 'b1', 'b2', 'b3', 'c1', 'c2', 'c3'}

I fixed it on lazy_fixture branch by using own object instead of mark. The problem is pytest extracts arg values from mark, so i can't tell exactly on which objects fixture mark was applied. The easiest way to fix that problem is to implement plugin through own object (pytest.lazy_fixture) instead of pytest.mark.fixture. pytest will not touch it. The plugin code will be also a little bit simplified and all previous examples, use cases will work with lazy_fixture too.
What do you think?

Thanks @TvoroG I'll test it soon and give you feedback.