[WIP] Modifier system fixes

added formula calculation on drop and toggle
small chatbox bugfix, added function docs
fixed formula calculation for drop and sheet
added modifier stacking into dice rolling
moved: roll stacking calc; added: createRoll to stacking

Target is to collect bugs about the modifier system and fix them here.
Might as well throw away some stuff later and do it again with better code. This is more or less a working prototype.
Known Issues:

[x]  Dropped in Feats/Items that have modifiers math function calls need to have all their modifiers saved by hand to get them working correctly.
[x] Situational and Constant modifiers have problems to calculate stacking ("insight" with "insight" should not work but "insight" with "enhancement" should and so on) against each other. The result tends to be 0 if the situational modifier is higher and is not able to select the situational modifier if it's lower.
[x] LookupRange modifiers always behave as if they were their maximum value in bonus stacking calculation
[x] add all modifier to be working with new system

There are some bugs introduced by asyncing modifier stacking, actor resources throw errors

There are undoubtably lots of smaller bugs introduced by this change, so I'm not entirely happy with it, but admitedly I can't think of a better solution than just doing recalculating them in an update hook/method or something.
That said, if we can find all the bugs and ensure there are no regressions, it should be fine. How much work that will take though is unclear.

Situational and Constant modifiers have problems to calculate stacking ("insight" with "insight" should not work but "insight" with "enhancement" should and so on) against each other. The result tends to be 0 if the situational modifier is higher and is not able to select the situational modifier if it's lower.

I believe everyone knows why this happens but I want to write it down here to have it carved into stone. This is the same on dev and this branch.
Inside every "calculate-[...]-modifier.js" exists a method called "addModifier" and they all have this code:
if (bonus.modifierType === SFRPGModifierType.FORMULA) {
                if (item.rolledMods) {
                    item.rolledMods.push({mod: bonus.modifier, bonus: bonus});
                } else {
                    item.rolledMods = [{mod: bonus.modifier, bonus: bonus}];
                }
                return 0;
            }

This is done AFTER the stackmodifiers (which does not give a damn if a modifier is situational or not) is executed. This means: Every time stackmodifiers calculates that the situational modifier is the highest mod it just sets the mod to 0.
Fixing this will take some time because I need to figure out how to get out of this dead end.

Be sure to undo 8bda768 and 3aeba30 too

-Situational Modifiers to specific skills appear on all skills
-Default attack modifiers (charge, flanking etc) throw an error since container.actorId is undefined

what a shame i didn't test this. working on it

A few oddities I discovered. Just noting them here, I will (try) to investigate them further later:

Only the highest situational modifier is shown on the roll dialog. Ideally all should be shown, and only one is able to be enabled.
Didn't dice in constant formulas used to throw an error? It doesn't currently, constant dice just silently get ignored in rolls.

Just FYI too. I think we're gonna do a release soon, without this merged. After that, we can merge this pretty soon after and have it sit on dev for a while so we can find all the bugs.

Spell DCs have gone missing 😱

Spell DCs have gone missing 😱

Fixed. Note that we shall never touch that part again or we have to decide to do some major rework.


[Error] Cannot read property

@pelikhan,
The issue below (#23) has not been resolved.
And even though it is declared as below in shims.d.ts, it still shows 'of undefined', not 'of dynamixel' ...
Strangely, despite this error, the board works fine.
declare namespace dynamixel {
    /**
     * Opens a DYNAMIXEL communication driver
     */
    //% shim=dynamixel::internalCreateDXLDevice
    function internalCreateDXLDevice(tx: DigitalInOutPin, rx: DigitalInOutPin, dir: DigitalInOutPin, id: int32): DynamixelDevice;
}

And, the below .png file is the example code with the above error.

Originally posted by @OpusK in https://github.com/microsoft/pxt-robotis/pull/23

What you need to do is to implement a javascript version of the C++ call.

I think I wrote a shim through the code above as per the manual.

See serial shim: https://github.com/microsoft/pxt-common-packages/blob/76fe391800fd44825839573da32cdca3ca5076ed/libs/core/sim/serial.ts#L40

Your link is not a shim, but a sim file (for simulation). Isn't it right to refer to shims.d.ts for shim?
Of course, I haven't implemented simulation yet, so when implementing sim it's right to refer to the file you gave the link to.
I've also seen errors related to simulation, so I know I need to implement sim someday. However, the current error is about shim.
I think it was implemented properly except for simulation, isn't it?
Like docs, should it be uploaded to the cloud to be recognized as a namespace called dynamixel, not undefined?
If so, please merge. I will implement the simulator later.
Originally posted by @OpusK in https://github.com/microsoft/pxt-robotis/pull/23

Peli will put the skeleton code to unblock you.

Sorry i haven't been looking at it yet.

Fixed, see dynamixel/sim/*.ts

You'll need to implement a "dynamixel" simulator in javascript.

Thanks for your support :)


Add Image & metadata IPFS links in Media Wordpress admin Page

after mint in media page, display Image & metadata IPFS links in theDecentralized storage column
Have a reflection about wich links have to be displayed if the media is minted more that one time.

done via dapp


feat(chart): Introduce Jibri to the chart

Hello again! :)
This PR adds (almost) everything one needs to deploy Jitsi Meet in Kubernetes with fully-featured recording and livestreaming support.
Known limitations:

It's still necessary to prepare the host node beforehand by loading the snd-aloop kernel module and adding it to the autoload list;
AFAIK, one Jibri pod gives the ability to record/stream only one room at a time, and we'd need to set up multiple Jibri pods with different configs (JIDs, "nicks", etc.) to scale it properly, which requires extra work and goes beyond the scope of this chart.

Thoughts about those limitations:

I was thinking about adding an init-container that'd load the module for us if needed, but that would require mounting the /lib/modules directory from the host, which is a questionable thing to do. It also wouldn't be 100% reliable, since some distros store their modules in /usr/lib, /lib64, /usr/lib64 and so on.
Technically it's possible to generate multiple ConfigMaps for multiple Jibri instances with template-generated JIDs and nicknames. Is it feasible for us to go that far? :)

As always, do not hesitate to ask or let me know what you think.

Ok, I've tested it and local recording works! Still need to test livestreaming and figure out why Firefox on Windows clients don't work properly. (The latter is probably unrelated, but gotta be sure)

Turned out the problem was caused by some settings in that particular bunch of browsers. A "fresh" instance started with an empty profile works as intended. :)

@sapkra, what's your opinion on this?

@spijet Sorry, I don't have that much time right now. I skimmed through it and left some comments. Everything else seems to be fine. Thank you for your contribution!

@sapkra All done. :)


Changed performance.now() to Date.now() for unix timestamps

Updated the timestamps for unreferencedTimestamp and createContainerTimestamp to use Date.now() instead of performance.now().
peformance.now() returns a time relative to the document load and is not an absolute timestamp. So, it cannot be used to compare time across documents. We need to use Date.now() which gives a number that is the number of milliseconds since the unix epoch.
We could use something like performance.timing.navigationStart + performance.now() to get a comparable timestamp but performance.timing is deprecated so using Date.now() is better.

I did not look closely at it, but can we make performance from common-utils return Date.now()?
I believe we are not putting any restrictions on what it returns today, other than that one can measure progression of time using it.
If possible, it would be nice to have only one way to deal with time :)

I did not look closely at it, but can we make performance from common-utils return Date.now()? I believe we are not putting any restrictions on what it returns today, other than that one can measure progression of time using it. If possible, it would be nice to have only one way to deal with time :)

I don't think we should return Date.now() for peformance.now(). peformance.now() has its own advantages - It has more precision than Date.now (in microseconds) and it is not dependent on system clock which can be skewed. So, it will work better in scenarios where we want to compare times or find duration of certain events within a browser session.
Or do you mean have another API in common-utils performance that returns Date.now().

No, looking for ways to have just one API :) And simple message to developers.
I believe precision of both is the same, at least right now. For example, Firefox says that both are limited by privacy.reduceTimerPrecision with default value of 1ms. They leave the room open in future to improve precision of performance.now() if they can mitigate risks, but I'm not sure about probability of that happening.
I like the direction of performance.timing.navigationStart + performance.now(), but not sure what's more supported way of doing so. Though it's not that hard to reimplement - something like that:
const start: number | undefined;
export function now() {
   if (start === undefined) {
      start = Date.now() - performanceOld.now();
   }
   return start + performanceOld.now();
}

where perforamanceOld is the existing implementation of performance from common-utils, and now() is the new version that will take its place.
(Reminds me robotics and mixing high precision with drift and low precision no drift sensors :))

my 2 cents. wrapping native browser or node behavior is custom methods makes things harder for developers, as by doing it we diverge from standard javascript. i'd rather just keep using the appropriate system calls where necessary. i don't think this is such a common case that we need to improve on it.

I agree with Tony here. Wrapping a standard method and making it do something else will add confusion as the results won't be what developers expect. I think it's fine to use both Date.now() and performance.now() as they serve different purpose and are well documented on the web.

I agree with Tony. Wrapping a standard method and making it do something else will add confusion as the results won't be what developers expect. I think it's fine to use both Date.now() and performance.now() as they serve different purpose and are well documented on the web.

it looks like we weren't even using the common-utils performace shim. i'm not even really sure why that exists


Need to implement the APIs for Searches

Need to implement API lists

Implement all endpoints of searches. it will be POST request

API Doc - https://app.swaggerhub.com/apis-docs/Crunchbase/crunchbase-enterprise_api/1.0.1#/Search/post_searches_organizations

[x] organizations
[x] people
[x] funding_rounds

Finished 3 main endpoints


DOC: improve viewer configuration description, collect in one section

This was motivated by a silent failure on Linux to find okular, which appeared as if the relative path ../main_file.tex was not working at all. Noting that a change to pdf-view is needed if okular is absent emphasizes this. Also, the viewer-related sections were interspersed in the manual, so they are collected here into their own section, because most users are likely interested to find these settings before the build configuration (for which they may be using an external terminal).

Any intention to merge this?

Is this not going to be merged?


Internal error when synching with CLion (java.lang.NoClassDefFoundError for com.jetbrains.python.facet.PythonFacetType)

Not sure what help I can offer with debugging this, but feel free to give me a yell if there's more I can provide.
CLion configuration:
CLion 2017.1.2
Build #CL-171.4694.4, built on May 16, 2017
Licensed to Zippy / Brendan Drew
You have a perpetual fallback license for this version
Subscription is active until April 20, 2018
JRE: 1.8.0_112-release-736-b21 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.4
CLion with Bazel information:

Screenshot showing error:

+1, having exactly the same issue. I have a few python tests in my BUILD.
Syncing project...
Updating VCS...
Running Bazel info...
Command: /Users/gruszczy/bin/bazel info --tool_tag=ijwb:CLion --curses=no --color=no --noexperimental_ui --noprogress_in_terminal_title --
Computing VCS working set...
BUILD (modified)
CMakeCache.txt (added)
CMakeFiles/3.7.2/CMakeCCompiler.cmake (added)
CMakeFiles/3.7.2/CMakeCXXCompiler.cmake (added)
CMakeFiles/3.7.2/CMakeDetermineCompilerABI_C.bin (added)
CMakeFiles/3.7.2/CMakeDetermineCompilerABI_CXX.bin (added)
CMakeFiles/3.7.2/CMakeSystem.cmake (added)
CMakeFiles/3.7.2/CompilerIdC/CMakeCCompilerId.c (added)
CMakeFiles/3.7.2/CompilerIdCXX/CMakeCXXCompilerId.cpp (added)
CMakeFiles/CMakeOutput.log (added)
CMakeFiles/clion-environment.txt (added)
CMakeFiles/cmake.check_cache (added)
CMakeFiles/feature_tests.bin (added)
CMakeFiles/feature_tests.c (added)
CMakeFiles/feature_tests.cxx (added)
CMakeLists.txt (added)
Makefile (added)
WORKSPACE (modified)
array.c (added)
array.ll (added)
(and 61 more)
Sync targets from project view:
//...:all
Sync targets from working set:
//:all
Building IDE info files...
Command: /Users/gruszczy/bin/bazel build --tool_tag=ijwb:CLion --keep_going --experimental_show_artifacts --curses=no --color=no --noexperimental_ui --noprogress_in_terminal_title --aspects=@bazel_tools//tools/ide:intellij_info.bzl%intellij_info_aspect --output_groups=intellij-info-text -- //...:all //:all
____Loading complete.  Analyzing...
____Found 18 targets...
____Building...
____Elapsed time: 0.310s, Critical Path: 0.01s
Total rules: 22, new/changed: 22, removed: 0
Reading IDE info result...
Loaded 22 aspect files, total size 35kB
Building IDE resolve files...
Command: /Users/gruszczy/bin/bazel build --tool_tag=ijwb:CLion --keep_going --curses=no --color=no --noexperimental_ui --noprogress_in_terminal_title --aspects=@bazel_tools//tools/ide:intellij_info.bzl%intellij_info_aspect --output_groups=intellij-resolve -- //...:all //:all
____Loading complete.  Analyzing...
____Found 18 targets...
____Building...
____Elapsed time: 0.267s, Critical Path: 0.00s
Command: /Users/gruszczy/bin/bazel info --tool_tag=ijwb:CLion build-language --curses=no --color=no --noexperimental_ui --noprogress_in_terminal_title --
Prefetching files...
Computing directory structure...
Committing project structure...
Workspace has 0 libraries
Sync failed
==== TIMING REPORT ====
Sync: 2.5s (195ms)
BazelInfo: 503ms
WorkingSet: 1ms
IdeQuery: 652ms
ExecuteBazelCommand: 625ms
FetchAspectOutput: 0ms
UpdateTargetMap: 26ms
BazelBuild: 554ms
UpdateSyncState: 378ms
BUILD language spec: 378ms
ReverseDependencies: 0ms
PrefetchFiles: 0ms
RefreshVirtualFileSystem: 12ms
DirectoryStructure: 167ms
UpdateProjectStructure: 26ms
Error:Internal error. Error: java.lang.RuntimeException: java.lang.NoClassDefFoundError: com/jetbrains/python/facet/PythonFacetType

What version of the python plugin do you have?
Looks like the PythonFacet classes were recently moved from "com.jetbrains.python.facet" to "com.jetbrains.python.minor.facet".
I'd recommend downgrading to an earlier version of the python plugin (for reference, the latest version I can find compatible with 2017.1 appears to be 2<IP_ADDRESS>49.63, which doesn't have this change in it).
Realistically, we can't fix this until 2017.2, when everyone is (presumably) guaranteed to be using a python plugin with this package path change.

I am using whatever came automatically (or as part of initial configuration) for CLion. I am using 2017.1.2 and the only Python plugin I see Pycharm plugin 171.4694.4. I will take a look how I can downgrade it, thanks.

Thanks. In that case, this will affect anyone using 2017.1.2. You can either downgrade to 2017.1, or specifically downgrade the python plugin (and ignore any subsequent prompts to upgrade it).

Removing the python plugins appears to fix the problem.

Yep, that worked for me. It builds now. Thanks.


Why not make method signatures identical to linq?

Hi
So when i replaced linq with hyperlinq, it wont compile right away i had to change all linq parts
for example
.Where(a=>a!=null)  to  .Where((a,i)=>a!=null)

Why not make method signatures identical to linq? is it even possible? i couldn't think of anyhting without closure allocations.

Hi @friuns2
I'm using value types for the enumerators and interface constraints but both force me to add the explicit implementation of each operator on every enumerator. This makes the number of lines explode exponentially, making it hard to maintain and easily introducing bugs. For that reason I was limiting the number of overloads for each operation. I decided to only support predicates and selectors with indices, where the index can be ignored but, I agree with you.
I now changed strategy and I'm developing a Fody addin that automatically generates all these operations. It's taking a bit of time but the next version will support LINQ signatures and much more...
Thank you for letting me know you're trying to use this project. It's been too quiet around here... ;)

thats only linq project thats usuable keep it up! others like LinqAF is 20+mb dll because too much code generated, https://github.com/adamsitnik/slinq is abounded and https://github.com/eldereal/uniq is just slower ;)

@friuns2 Just to let you know that I'm still working on this. I'm automating some of the development to make it easier to add new operations. It's taking some time but it will be worth it. It's all in the Fody branch: https://github.com/NetFabric/NetFabric.Hyperlinq/tree/Fody

@friuns2 I finally relased a package with identical method signatures to LINQ. Please check the latest version on NuGet (still in beta). Check the README for usage documentation.

Thanks!


How to set application icon on Windows?

Using .NET 5 and <OutputType>WinExe</OutputType>, how can one set the application icon of the generated .exe?

Add <ApplicationIcon>App.ico</ApplicationIcon> to your project file.

I believe this has been answered, so closing.

While this helped with the explorer view, the icon used by the window manager and the task bar is not correct -

Is there a trick to this?

This icon comes from the window itself. It depends which UI stack you're using to create the window. For example for WinForms it can be done like this: https://stackoverflow.com/a/18736559/327203


[Distributed][Model] Rank-based Component Creation for Pipeline Parallelism Memory Optimization

Prior to this change, the Llama model initialization in Pipeline Parallel scenarios would create all components and layers for every rank, leading to unnecessary memory overhead. This pull request optimizes memory usage by creating certain components only on the relevant ranks.
The primary changes include:

Creating the embedding layer on the first rank only.
Creating the norm layer on the last rank only.
Creating the lm head, logits processor, and sampler components on the last rank only.

By selectively creating components on the relevant ranks, this optimization reduces the overall memory footprint. Testing with --pipeline-parallel-size 8 showed up to 25% per-rank memory savings for the Llama-3-70B model. This memory optimization can potentially enable higher throughput by allowing more memory to be utilized for serving.
This optimization enables serving larger models and running inference on resource-constrained environments by leveraging Pipeline Parallelism more efficiently.
Testing:

Benchmarks have been conducted to measure the memory savings and performance impact of this optimization.

Please review the changes and provide feedback or suggestions for further improvements.

looks nice. I'll do a test on H100 setups and confirm improvement.

thanks for the contribution! the overall idea looks good to me.
we actually use the minimum of the number of blocks across all processes to determine the final block size, which means it is only effective if we can reduce the lower bound of model memory usage.
In this case, you:

removed word embedding for the first pp rank
removed both word embedding and lm head for the rest ranks
removed lm head for the last rank

Overall, the minimum memory usage of the model is reduced by about the size of a word embedding or an lm head layer (typically the same size).
It would be better if you can move this logic into common layers, so that the rest models can directly benefit from it. I added PPMissingLayer in https://github.com/vllm-project/vllm/pull/6406 recently, which might help. My goal is to reduce the code change to support pp, to make sure the code is not too intrusive and people can find it easy to integrate.
One niche case, is you need to take care of models that use tie embeddings.

Thanks for your change! This should bring some improvement. I'll let @sfc-gh-hazhang report back.

thanks for the contribution! the overall idea looks good to me.
we actually use the minimum of the number of blocks across all processes to determine the final block size, which means it is only effective if we can reduce the lower bound of model memory usage.
In this case, you:
* removed lm head for the first pp rank

* removed both word embedding and lm head for the rest ranks

* removed word embedding for the last rank

Overall, the minimum memory usage of the model is reduced by about the size of a word embedding or an lm head layer (typically the same size).
It would be better if you can move this logic into common layers, so that the rest models can directly benefit from it. I added PPMissingLayer in #6406 recently, which might help. My goal is to reduce the code change to support pp, to make sure the code is not too intrusive and people can find it easy to integrate.
One niche case, is you need to take care of models that use tie embeddings.

Thanks for the feedback and suggestions!
Instead of modifying VocabParallelEmbedding and ParallelLMHead, I propose keeping the pipeline parallelism logic within the model-specific classes. We can introduce helper methods to encapsulate the rank-aware logic. These helpers would return the appropriate instances based on the current rank.
This way, VocabParallelEmbedding and ParallelLMHead remain generic and reusable across models. The pipeline parallelism logic stays in the model-specific classes, making it easier to maintain and extend.
Please let me know if this approach works for you.

The pipeline parallelism logic stays in the model-specific classes, making it easier to maintain and extend.

this idea looks good to me. I'd like to make the code change as small as possible, and it would be better if we can make the code intuitive.

@youkaichao I've rebased the branch on the latest main and integrated the PPMissingLayer component to handle weight skipping. No helper functions are added at this stage, but they can be introduced in a separate pull request if deemed necessary.
Please review the changes and provide any feedback or concerns you may have. I tested the integration of PPMissingLayer locally, and it seems to be working as expected.

/ready


One step ahead time series forecasting with CNN

Description
Conditional and unconditional one step ahead time series forecasting using Gluon, with application to Lorenz dynamical system synthetically generated data for end to end training, prediction and evaluation. The model can be applied similarly to various time series such as time series of financial returns, demand forecasting etc.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-label-bot add [pr-awaiting-review, Example, Gluon]

@D-Roberts Thank you for your contributions!
@szha Could you please look at this PR?

@szha Gentle ping for review...

@szha, @piyushghai tnx

@szha Could you please review the PR? Thanks!

@szha Gentle ping...

@szha Could you please review the PR? or tag any relevant person who can review it? Thanks!

Any news on this?


Add types for framer-motion

Adds support for framer motion props.
Example error:

Property 'initial' does not exist on type 'IntrinsicAttributes & FocusNodeProps & RefAttributes<HTMLElement>

Focus-node.d.ts snippet (before fix)
declare const ForwardedFocusNode: React.ForwardRefExoticComponent<FocusNodeProps & React.RefAttributes<HTMLElement>>;

Focus-node.d.ts snippet(after fix)
declare const ForwardedFocusNode: React.ForwardRefExoticComponent<FocusNodeProps & MotionProps & React.RefAttributes<HTMLElement>>;

The downside of this PR is that non-motion FocusNodes will accept the motion properties without triggering a typescript build error. Feel free to close if this is a deal breaker.
styled-components has an implementation as which functions similarly to elementType and adds types correctly, but I haven't yet had time to dig into how it works and to implement it.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/styled-components/index.d.ts#L97

All good. It's good to know the direction you'd like.
Thanks.


Command tx authz revoke

close: #18
Added command to allow multisig to submit a tx to revoke a authz permission for a particular message type (e.g. vote)

also need to update the README with comments about this new command


Coding best practice: do not use system.out but only logging

Review all code to:

remove commented log-configuration lines or reenable and use them
replace all system.out with log

Agreed.

Agreed.


[FEATURE REQ] should show email auto suggestion when typing email

As a user I want when I type email(s), should show  auto suggestion for good user experience

This is a good FR. The emails of all employees from the organization can be fetched and shown as an auto-suggestion dropdown like Google calendar does.

@Propo41 hey, this is great so feature and i would like to know if i can possible to work on this?

@Propo41 hey, this is great so feature and i would like to know if i can possible to work on this?

You would need an organizational google account that utilizes meeting spaces in their calendars. If you don't have one, you won't be able to do this.

Okay got it working on it, could you please add hacktoberfest label because it's my first time to participate on it.

@imkurosaki do you want to work on this feature?

Yes, i would love too but i don't have an organizational google account but you can assigned me i will find alternative or solution for this.

@imkurosaki assigned you. This is a bit urgent task, would be nice if you could work on it sooner if time persists

Hey @Propo41, I'm really sorry, but I won’t be able to work on this feature right now. I’m a bit busy with my thesis. Could we connect on LinkedIn?

Hey @Propo41, I'm really sorry, but I won’t be able to work on this feature right now. I’m a bit busy with my thesis. Could we connect on LinkedIn?

It's fine, I understand. Yeah sure, here's my linkedin: https://www.linkedin.com/in/ali-ahnaf/


issues/396: add tests for uuid8 sortable

Fixes: https://github.com/komuw/ong/issues/396

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0415d00) 69.68% compared to head (69a3d3f) 69.70%.

:exclamation: Current head 69a3d3f differs from pull request most recent head e2e6ad2. Consider uploading reports for the commit e2e6ad2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   69.68%   69.70%   +0.01%
==========================================
  Files          52       52
  Lines        6192     6192
==========================================
+ Hits         4315     4316       +1
+ Misses       1555     1553       -2
- Partials      322      323       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SWIRE

swire support

I close this Pull request as I do not want the dependency on an external library unless it is needed in all scenario's.


mark two tests as flaky

They failed in an unrelated PR's smoke test. Tracking the disabling of the test here: https://bugs.swift.org/browse/SR-14433

@swift-ci please smoke test

@swift-ci test linux


Unable to play large m4a audio file using wavesurfer

Unable to play large m4a audio file using wavesurfer

Since wavesurfer decodes the file in the browser and puts them into a JavaScript array, large files may fail to decode due to memory constrains.
We recommend using pre-decoded peaks for large files.
See this example: https://wavesurfer-js.org/examples/#predecoded.js
You can use a tool like https://github.com/bbc/audiowaveform to generate peaks.

It's not the file size .Unable to play m4a audio file.What should I do

It's not the file size .Unable to play m4a audio file.What should I do

It could be the electron environment

Any other piece of information you might want to share?

I’ll close this since different browsers support or don’t support certain file formats and there’s little we can do about it.


Writing to the last element of std::vector in Lua increases vector size by 1 (push_back?)

Hello. I was trying to fill std::vector in Lua function and noticed that if you write value to vec[#vec], size of the vector increases by 1, and you actually write to the "new last" element.  Probably I'm missing something important, because I can't find anything similar in issues.
Tried both clang and g++, as well as lua5.3 and luajit-2.0. Linux+amd64 if that matters.
This is a working example:
// g++ test.cpp -std=c++14 -I/usr/include/lua5.3 -llua5.3 -o test
#include <iostream>
#include <vector>
#include "sol.hpp"

int main() {
  sol::state lua;
  lua.open_libraries(sol::lib::base);
  lua.script(
    R"(
    function Fill(vec)
      print("#vec in lua: " .. #vec)
      for k = 1, #vec do
        vec[k] = k
      end
      print("#vec in lua: " .. #vec)
    end
    )");
  std::vector<int> vec{-1, -1, -1};

  std::cout << "#vec in C++: " << vec.size() << std::endl;
  lua["Fill"](vec);
  std::cout << "#vec in C++: " << vec.size() << std::endl;

  for (int i = 0; i < vec.size(); ++i) {
    std::cout << vec[i] << std::endl;
  }
  return 0;
}

This was a failure on my part: I did the --k AFTER I did the check for the index being the same as the vector size. There's a test there specifically for this too, so it won't happen again.
Thanks for sharing.
Grab the latest / fix here: https://github.com/ThePhD/sol2/releases/tag/v2.17.0

Side note: vec[#vec + 1] = stuff is a valid (and encouraged) Lua idiom for push_back.

Big thanks for awesome library and for fixing.


None of my timestamps show up in the entities dropdown

Checklist:

[x] I updated to the latest version available
[x] I cleared the cache of my browser

Release with the issue: Latest
Last working release (if known):
Browser and Operating System:

Description of problem:
The only entity that shows in the dropdowns is my phone's distance which shouldn't even be showing. Yet the uptime for my network devices are all missing even though they're timestamps.

Javascript errors shown in the web inspector (if applicable):

Additional information:

Sorry for taking a while to answer;
I'm not 100% sure if I remember correctly, but if I'm not incorrect, it lists only the sensors that have unit_of_measurement set to be either h, m or s (hours, minutes or seconds).
Now that it shows only sensor.eve_distance, I think it might have unit_of_measurement = m, meaning meters instead of minutes. I'm not sure where did I came up with h, m and s, are they correct ones or should they rather be hours, minutes, seconds or something else? 😬
Either way, for now you should get the sensors you want to see there, by defining the unit_of_measurement for one of the ones stated earlier.

I'm not sure where did I came up with h, m and s, are they correct ones or should they rather be hours, minutes, seconds or something else?

I don't think it should be filtering by that at all since timestamps are going to be a ISO string not a number.

Actually now that I checked the code a bit better, I noticed that it doesn't filter the entities only based on the unit_of_measurement, it also includes entities that contain either has_time or has_date attribute.
I updated the README.md again with few examples:

https://github.com/kirbo/ha-lovelace-elapsed-time-card#notice
https://github.com/kirbo/ha-lovelace-elapsed-time-card#example-sensors

Could you give me an example of the entities you want to list there? Are they something like e.g. Unifi device uptime sensors?

Well, I just added a support for device_class: timestamp entities as well. Let me know if this resolves your issue or not.
https://github.com/kirbo/ha-lovelace-elapsed-time-card/releases/tag/0.4.0

Sorry for not getting back to you quicker. The newest update that enables timestamp entities works well only the value is incorrect.
The value is currently 2021-05-31T12:22:00.837207+09:30.
I would have expected to the equivalent to 1h not -18778d 2h 52m.

Looks like this is the change needed https://github.com/kirbo/ha-lovelace-elapsed-time-card/commit/8c1ae21ae7d1c897f1da0f80392452f31ae18e6e#r51511304.


The page is unresponsive after opening the confirmation modal

Additional details

The issue is replicating only for delete confirmation modals.

Replication
https://github.com/Kiranism/next-shadcn-dashboard-starter/assets/39824625/f271ad2a-b466-451d-94dd-27deab4141f5

@AmulyaShrestha Hey, thanks for pointing that out. I've fixed the problem

@Kiranism Thanks for the update!


How can get tx hash from boc ?

please write code or help me to how can convert boc  to transaction hash ?

cl := cell.FromBoc(boc)
cl.Hash()


Create Single Task Runner

Just creating a PR so we can discuss this

Ah shoot bad timing, I was trying to rebase to main and think I mucked it up

Ah shoot bad timing, I was trying to rebase to main and think I mucked it up

Ah well, force push! haha
It looks clean?

Some of our cleanup this week didn't take. I may just destroy the branch and recreate once we settle this convo

Ah shoot bad timing, I was trying to rebase to main and think I mucked it up

Ah well, force push! haha
It looks clean?

All my nitpicking aside, this looks great @jessjaco. I'd be happy for you to refactor and create a new PR as is. We can merge it in, I'll rebase my messy branch and test it out for GeoMAD.

Ok, I think I got it all set. What a time. I'll need to look at runner.py next but right now that's unrelated.


Build has rusted

The build process for CircuitPython has been updated. Need to upgrade the build to the newest process  detailed in Creating and Sharing CircuitPython Library documented on Adafruit's Learning website.
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/creating-a-library

The build has now been updated and runs successfully. HOORAY!


Docs site

Move documentation into a docs site
Reviewer checklist

[ ] Read the contributing guide
[ ] PR should be motivated, i.e. what does it fix, why, and if relevant, how
[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage: 99.349%. Remained the same when pulling 8ed7eb0ba2dd6ee3944b599d1d8ebb68618a434f on docs into 75aa0c099e2a4193b18c5ed549847648bdb8e70f on main.


feat: add (simple) search functionality to app

Using simple substring search, since CRDB does not have full text search functionality yet.
Only minimal frontend work since still waiting on design.
TODO: Still need to search in comments, but waiting for redoing of the schema to something Tw*tter-like

Will keep this branch hanging for now to serve as example for a new feature


Session close deadlock

@fuzzypixelz : I finally understand the deadlock. It's between a TaskController::wait in zenoh (Rust) and a C++ std::recursive_mutex in rmw_zenoh.

some other peer shuts down
zenoh rust receives a token undeclaration from a peer
the callback reaches into rmw_zenoh while on the RX runtime
the subscriber tries to get the context lock but the rmw_shutdown function gets the lock first and then tries to close the session
the session close hangs because it's waiting on the RX task to complete but it can't because it's waiting on the lock we just took

@yellowhatter : Okay, let me take care of this
I think we need to solve it on Rust side
to make our core more safe in terms of user-dependent deadlocks like this

To reproduce, compile the test_communication and run the test with the following.
colcon test --event-handlers console_cohesion+ console_direct+ --packages-select test_rclcpp --ctest-args -R test_n_nodes__rmw_zenoh_cpp

The deadlock happens upon acquiring the lock here https://github.com/ZettaScaleLabs/rmw_zenoh/blob/28d917e0532fed6e9703f044662298f2b3553716/rmw_zenoh_cpp/src/detail/rmw_context_impl_s.cpp?plain=1#L62


tf-idf, adding phrases

Hi,
I am trying to add a two word phrase that we can search for.
Eg.
"meet me"
tf-idf should return weight(positive) for this only when both the terms are search.
So, if user searches for 'meet' value should be 0
if user searchers for 'me', value should be 0
if user searches for 'meet me', value should be > 0

@prashant19sep you should perhaps use underscores to unit ngrams that are part of the same phrase so meet_me becomes its own entity.


Designing the mobile view of the website

There are some issues in the text and images in the mobile view. The footer does not look that good in mobile view and the hero image is overlapped by the text.

I can solve this issue. Please assign this to me.

I need this.
Go ahead!


Remove attach-javadocs from package target

Causing problems for the release process, so let's disable it for now.

LGTM


Add variable for font weight (and refactor components' to use it)

Currently all font-weights in the Lumo themes of Vaadin components are hardcoded. This becomes very problematic when the font family is changed to one with a relatively heavy visual weight, like Rubik, since every single font-weight now has to be overriden with theme modules.
If Lumo had a --lumo-font-weight variable for the base weight, all other weights used could be based on this, i.e. e.g. font-weight: calc(var(--lumo-font-weight) + 100).
Even better of course be if all common weights had their own variables.

I suppose one property would be enough to start, to be able to set a sensible baseline. Fine-tuning would IMO be okay to do in separate component-specific style sheets (aka theme modules).


Plans on moving Vector Layer Code for OL 3.5?

Hey thanks for merging my PR and for the directive.
Do you have plans or would accept a PR for moving to the new Vector API in OL3 3.5? (https://github.com/openlayers/ol3/releases/tag/v3.5.0)
var source = new ol.source.Vector({
  url: 'features.json',
  format: new ol.format.GeoJSON()
});

I would start working on it if you would consider merging it.
Thanks.

Yes of course, it would be great if you could code the adaption to the new Vector API, I'm always trying to be in sync with the latest OpenLayers version.
In the meantime, I will update the library to the v3.5.0 to test the actual functionality is working.
Thanks

Hi, I have created this branch to update the Vector creation calls to the new API:
https://github.com/tombatossals/angular-openlayers-directive/tree/v3.5.0

I have the v3.5.0 branch working with the ol3 v3.5.0 branch. I will merge this branch on master in a few days, releasing a new version so people using ol3 < v3.5.0 can continue using their code.

@tombatossals great work! I was just looking into this issue. Are there any news on release of this as I'd like to upgrade ol3 to v3.6.
Btw, what version do you plan to release this with? Being somehow a breaking change this would be an upgrade of the major version, right (to stay in synch with semver)?

@tombatossals Any updates here? I'm sorry to ask again, but I'd have to know at which point you are as we'd need some new features from v3.6 which currently isn't compatible with this directive, though. :worried:
Thx for any info on your end. :smile:

@tombatossals I upgraded your v3.5.0 branch with the latest changes in angular-openlayers-directive and I'm using it now with ol v.3.6 for a while. Seems quite stable. My fork is here: https://github.com/juristr/angular-openlayers-directive/tree/v3.5.0
If you want, we could organize a PR to upgrade? What are your plans about this? I'd like to through my custom fork away and continue with your repo again. :smile:

Closing this as it will be solved soon with #155 .

Ok, v1.0.0 released: https://github.com/tombatossals/angular-openlayers-directive/releases/tag/v1.0.0
Now official compatible with ol3 > v3.5


Add an incremental build

Motivation
The build launched for each PR is much too long, let's experiment an incremental build. The idea is to build only what is needed.

Some random comment

New test comment

/test-component kafka

/component-test kafka

Yeah this would be good, thanks for trying this


Add documentation for downward API hugepages

Document support for hugepages in 1.20 per https://github.com/kubernetes/enhancements/issues/2053

I was not sure how to capture an example, hoping that sig-docs can assist on the right location.

/milestone 1.20
/sig node
/assign
/hold pending merge https://github.com/kubernetes/kubernetes/pull/86102

/check-cla

/cc @sftim @kbhawkey @onlydole Any assistance to @derekwaynecarr on his comment https://github.com/kubernetes/website/pull/24904#issuecomment-722446617 would be appreciated! :)

I was not sure how to capture an example, hoping that sig-docs can assist on the right location.

Hi @derekwaynecarr .
Are you interested in adding a configuration example (see content/en/examples/pods/inject directory) to this task page?
There are other examples used in this task. You can add the example to the examples directory and
reference this in the page with the codenew shortcode, such as
{{< codenew file="pods/inject/dapi-volume.yaml" >}}

/check-cla

Hi @derekwaynecarr
Does this feature also need a change to https://k8s.io/docs/reference/command-line-tools-reference/feature-gates/ ?

/hold cancel
k/k pr merged
@derekwaynecarr With k/k done, it would be really helpful for Sig Docs if you could get the docs into "ready for review" state early -- before kubecon if you can. Thank you!

Hey @derekwaynecarr a friendly reminder that this PR ready for review deadline is coming up soon! (Nov. 23rd)
When you can, please review the suggestions provided above and work on getting this PR in a ready to be reviewed state. Thank you!

Hi @derekwaynecarr today is the deadline for docs to be in ready for review state. Please address Tim's comment above and let us know if this is ready to be reviewed.

pushed updates per feedback, thanks!

Hi @derekwaynecarr
Could you also describe this feature gate - see https://github.com/kubernetes/website/pull/24904#discussion_r529007673?

Hi @derekwaynecarr , just a reminder that the docs merged deadline is on Dec 2. Can you address @sftime 's comment about describing the feature gate. Thank you

addressed feedback.

/approve


COS Integration scaffold

This PR includes everything needed to integrate the charm to the cos-lite bundle. No custom dashboards have been created so far, given that gunicorn is a "bring your own dockerfile and execute it" charm. We'll need further discussion about the custom dockerfiles and metrics to generate for each.

Looks good, the comment by @arturo-seijas on using a statsd prom exporter is good, I think this is worth looking into.

AFAIK gunicorn exports the metrics in statsD format. Do you think we can integrate the official Promehtues exporter image to be able to ingest those metrics?

I think this is an interesting suggestion, but one concern I have is that this charm is somewhat mis-named and doesn't really have any intrinsic ties to gunicorn. It really just depends on what you're running in the workload container (by default it's gunicorn but it doesn't have to be). I'd be reluctant to tie us more to gunicorn in case others want to take this charm and use it for non-gunicorn workloads.
We should likely think about renaming this charm separately if that's going to cause confusion.
I think it's also possible that this charm might end up having an nginx container added to it as we've done for indico to serve static content in a generic way.
I'd be fine to go ahead without this exporter for now, if we have the default app expose some metrics on /metrics for instance.

AFAIK gunicorn exports the metrics in statsD format. Do you think we can integrate the official Promehtues exporter image to be able to ingest those metrics?

I think this is an interesting suggestion, but one concern I have is that this charm is somewhat mis-named and doesn't really have any intrinsic ties to gunicorn. It really just depends on what you're running in the workload container (by default it's gunicorn but it doesn't have to be). I'd be reluctant to tie us more to gunicorn in case others want to take this charm and use it for non-gunicorn workloads.
We should likely think about renaming this charm separately if that's going to cause confusion.
I think it's also possible that this charm might end up having an nginx container added to it as we've done for indico to serve static content in a generic way.
I'd be fine to go ahead without this exporter for now, if we have the default app expose some metrics on /metrics for instance.

Have discussed IRL with Franco. While we don't want to create too much of a dependency on gunicorn, having useful integration with COS is a worthwhile goal, so we'll go ahead with the exporter. This can always be generalised to other applications later if appropriate.


fixChangingFeedModeCheckingForPkRangeVersion

Issue:
When customer uses handleChanges (PkRange based lease), if lease store has been initialized, then starting the change feed processor will fail with the following exception:
java.lang.IllegalArgumentException: Illegal base64 character 22
Root cause:
There has been a recent change to validate the change feed mode in the lease during changeFeed startup. When trying to validate the changeFeedMode in the lease, we are using ChangeFeedState.fromString() to parse the continuationToken, this method excepts the continuationToken to be in base64 format. However, for pkRange based lease, the continuationToken is only a long, that is when the above exception will be thrown.
Fix:
Remove the change feed mode checking if customer is on pkRange based lease, as only Incremental change feed mode is supported in the pkRange based lease.

API change check
API changes are not detected in this pull request.

/azp run java - cosmos - tests

Tested readAllItemsWithDetailMetricsWithExplicitPageSize locally

/check-enforcer override


Update binary serde

Summary

Update typescript runtime to use util for TextEncoder/TextDecoder
Return null for Unit (instead of undefined)
Handle more than double space needed for a new byte array insert (ensureBufferWillHandleSize)

Test Plan
no change

@danprinz Can you rebase this PR? (and/or squash some commits: the github UI shows that the resulting changes are very small)

Thanks!


Genericize EitherMatcher

Since both Either and Try implement success?, I suggest modifying Dry::Matcher::EitherMatcher to call success? & failure rather than right? & left?.

I will submit a PR if this is desired

@nicosuave I'd love to see this, please go ahead with the PR!


Percy failing to build / compile

Describe the bug
I was trying histoire with Nuxt 3 and Nuxt Tailwind, and I wanted to add Percy for visual regression. I followed the guide as described here https://github.com/histoire-dev/histoire/tree/main/packages/histoire-plugin-percy.
I was not able to make it work. This is the log when it fails:
% yarn test:percy
$ percy exec -- pnpm run story:build
[percy] Successfully downloaded Chromium 929475
[percy] Percy has started!
[percy] Running "pnpm run story:build"

> @ story:build /..../nuxt-histoire
> histoire build

ℹ Using Tailwind CSS from ~/assets/scss/main.scss
ℹ Vite client warmed up in 1693ms
✔ Nitro built in 1426 ms
/........../node_modules/@histoire/plugin-percy/dist/index.js:20
      const browser = await puppeteer.launch();
                                      ^

TypeError: Cannot read properties of undefined (reading 'launch')
    at Object.onBuild (/........../node_modules/@histoire/plugin-percy/dist/index.js:20:39)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async build (file:///........../node_modules/histoire/dist/node/build.js:43:13)
    at async buildCommand (file:///........../node_modules/histoire/dist/node/commands/build.js:7:5)
 ERROR  Command failed with exit code 1.
[percy] Finalized build #1: https://percy.io/7ae011fa/nuxt-histoire/builds/22228121
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Reproduction
If you want to try I made a repository: https://github.com/Archetipo95/nuxt-histoire
Just add your percy token (as described here) and run the command yarn percy:test.
System Info
System:
    OS: macOS 12.6
    CPU: (8) arm64 Apple M1
    Memory: 98.14 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v16.14.2/bin/npm
  Browsers:
    Chrome: 106.0.5249.119
    Edge: 98.0.1108.62
    Firefox: 105.0.1
    Safari: 16.0
  npmPackages:
    @histoire/plugin-nuxt: ^0.11.5 => 0.11.5
    @histoire/plugin-percy: ^0.11.5 => 0.11.5
    @histoire/plugin-vue: ^0.11.5 => 0.11.5
    histoire: ^0.11.5 => 0.11.5

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

I updated the repository with the last version of histoire and Nuxt 3


file alter index colorbox color e font size

new file alter index colorbox color e font size

Hi @cleitondeive ,
Thank you for the PR & congrats on your first contribution to Backpack. Could you please explain the PR and/or provide screenshots? Why is this better?
Thanks, cheers!

Hi @cleitondeive ,
I just noticed the changes you've made are in src/public/colorbox/example1/index.html. That file isn't used anywhere, so I think this PR doesn't do anything - so I'll close it. Let me know if I'm wrong.
Cheers!


adding nethermind as eth1

Sorry if the comment is no good, I missed my squashing.

forgot to update README.md


Why is cmdVel commented out?

In the file crazyflie.py, I noticed that cmdVel is commented out, which is a feature which I was looking for, are there any issues in its integration with ros2? The function is available on crazyswarm, and is widely used for low level control

I don't think there is any issue, we just haven't gotten around in testing it.

Oh, right, I will try to test it and create a PR

@DS3a Have you submitted a PR?

@whoenig @knmcguire
Regarding the implementation of the cmdVel functionality, would something like this work?
In crazyflie_sim/crazyflie_sim/crazyflie_server.py, creating the following topic callback
_cmd_vel_legacy_changed
def _cmd_vel_legacy_changed(self, msg : Twist, name=""):
    """
    Topic update callback to control the attitude and thrust
        of the crazyflie with teleop
    """
    roll = msg.linear.y
    pitch = -msg.linear.x
    yawrate = msg.angular.z
    thrust = int(min(max(msg.linear.z, 0, 0), 60000))
    self.cfs[name].cmdVel(roll, pitch, yawrate, thrust)

and then adding cmdVel to crazyflie_sim/crazyflie_sim/crazyflie_sil.py
 def cmdVel(self, roll, pitch, yawrate, thrust):
    self.mode = CrazyflieSIL.MODE_LOW_VELOCITY
    self.setpoint.attitudeRate.roll = np.degrees(roll)
    self.setpoint.attitudeRate.pitch = np.degrees(pitch)
    self.setpoint.attitudeRate.yaw = np.degrees(yawrate)
    self.setpoint.thrust = thrust
    self.setpoint.mode.x = firm.modeDisable
    self.setpoint.mode.y = firm.modeDisable
    self.setpoint.mode.z = firm.modeDisable
    self.setpoint.mode.roll = firm.modeAbs
    self.setpoint.mode.pitch = firm.modeAbs
    self.setpoint.mode.yaw = firm.modeAbs
    self.setpoint.mode.quat = firm.modeDisable

Similar to https://github.com/IMRCLab/crazyswarm2/blob/379601ea4c5f98f82c96749bfbe8e82a458ea9f9/crazyflie/scripts/crazyflie_server.py#L825
My main concern is the setpoint mode as I am not exactly sure which options to select to mimic the on-board controllers.
Cheers!

I'm sorry, I wasn't able to find the time to work on this

I have updated cmdVel to
def cmdVel(self, roll, pitch, yawrate, thrust):
    self.mode = CrazyflieSIL.MODE_LOW_VELOCITY
    self.setpoint.attitude.roll     = np.degrees(roll)
    self.setpoint.attitude.pitch    = np.degrees(pitch)
    self.setpoint.attitudeRate.yaw  = np.degrees(yawrate)
    self.setpoint.thrust            = thrust

    self.setpoint.mode.x        = firm.modeDisable
    self.setpoint.mode.y        = firm.modeDisable
    self.setpoint.mode.z        = firm.modeDisable
    self.setpoint.mode.roll     = firm.modeAbs
    self.setpoint.mode.pitch    = firm.modeAbs
    self.setpoint.mode.yaw      = firm.modeVelocity
    self.setpoint.mode.quat     = firm.modeDisable

but still see no movement in the sim backend (testing by publishing message with maximum thrust and zero pitch, roll and yawrate).

I have updated cmdVel to
def cmdVel(self, roll, pitch, yawrate, thrust):
    self.mode = CrazyflieSIL.MODE_LOW_VELOCITY
    self.setpoint.attitude.roll     = np.degrees(roll)
    self.setpoint.attitude.pitch    = np.degrees(pitch)
    self.setpoint.attitudeRate.yaw  = np.degrees(yawrate)
    self.setpoint.thrust            = thrust

    self.setpoint.mode.x        = firm.modeDisable
    self.setpoint.mode.y        = firm.modeDisable
    self.setpoint.mode.z        = firm.modeDisable
    self.setpoint.mode.roll     = firm.modeAbs
    self.setpoint.mode.pitch    = firm.modeAbs
    self.setpoint.mode.yaw      = firm.modeVelocity
    self.setpoint.mode.quat     = firm.modeDisable

but still see no movement in the sim backend (testing by publishing message with maximum thrust and zero pitch, roll and yawrate).

Nevermind, there was a mistake in my sim, this seems to work 😄

Great - PRs are welcome:-)


Clang Power Tools 5.6.0 causing errors when opening NuGet window.

This issue has newly started happening since I upgraded from Clang Power Tools 5.5.3 to 5.6.0.
I can reproduce it with 100% accuracy on VS 2015 Update 3 fully patched, VS 2017 Update 9.20 fully patched, on Windows 8.1 x64 fully patched (not yet tried with VS 2019).
It occurs if the solution does use NuGet packages or if it doesn't - as soon as the NuGet window opens:
To repro:

Load a solution into VS 2015 (or 2017). Any solution will do - even a Hello World one.
Right click on the solution for the "Manage NuGet Packages for Solution" context menu option.
As soon as you do, the Nuget Window opens, and you get a flurry of message boxes.

Title: Error
Text: The parameter is incorrect. (Exception from HRESULT: 0x80070057 (E_INVALIDARG))

This issue is 100% reproducible for me. If I disable Clang Power Tools, restart VS and retry, the problem doesn't occur. If I re-enable Clang Power Tools and retry the problem does occur.

Hello Mike,
Thank you for taking the time to report the bug.  We have resolved your issue in the point(5.6.1) release we just published.
If you have any other problems or feature suggestions let us know.
Have a great weekend!


Document needing sessions on stateless=false

This is a suggestion for fixing and closing issue https://github.com/spring-projects/spring-security-oauth/issues/939
I'm unsure of how I should write this documentation, and whether I should add it somewhere else, or add it to more places. Please guide me in making this PR great! :)

@gaqzi Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@gaqzi Thank you for signing the Contributor License Agreement!

Thanks for the PR @gaqzi. This is now in master.


Compose Family

I think I've mentioned this to most the collabs one by one, but want to create this issue to allow open discussion.
The #104 work has removed the CommandLineApplication, and I'm not planning to add it back. The reason being: the oldest outstanding issue in the Compose project, #7.
Essentially, I think the CommandLineApplication should probably provide some out the box features to push good practices. To do so would require more dependencies which don't belong in Compose itself.
As prompted by the repo transfer to this compose-net organisation, the intent is to create additional repos and packages.  My company (Gilmond) will (unbeknown to them) be contributing to a WinForms application. Web requires little to no work. Windows Services is a nightmare and it would be great to blackbox that stuff again within another package.
I don't know exactly what repos we'll end up with, but I suspect along the lines of:

Compose.CommandLine
Compose.WinForms
Compose.Wpf
Compose.WindowsService

In addition to host types, it gives us a nice spot to add things (if we ever get round to them) like Compose.Fallback.
Thoughts?

Sounds good to me, :+1:

Yep, lets do this. :+1:

Should this not be left open while in progress?

104 is getting collapsed on stream shortly. ;)


Remove references to old edge vscode extension

VSCode now has a built-in browser debugger, but our docs where still
mentioning old information about installing an extension to debug edge.
VSCode also has really good documentation about how to configure the
debugger, so there really isn't a need for us to re-do our own
documentation but should instead link to the existing one.
Fixes #1032.

@codepo8 please take a look at this when you get a chance. It seems like our docs about vscode were a bit outdated.
The index page was mentioning 3 extensions: the debugger for edge, the edge tools, and webhint.
While the last 2 still exist and are definitely things we want to document, the first one is deprecated as vscode has a built-in browser debugger.
So I removed references to this on the index page.
And I removed most of the docs from the "debug edge" page and instead linked to https://code.visualstudio.com/docs/nodejs/browser-debugging
What do you think?

Docs Build status updates of commit 2ab87ff:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/visual-studio-code/debugger-for-edge.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/index.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/media/vscode-debugger-install.png
:white_check_mark:Succeeded

microsoft-edge/visual-studio-code/media/vscode-edge-tools-install.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 03ea9b7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/debugger-for-edge.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/index.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/media/vscode-debugger-install.png
:white_check_mark:Succeeded

microsoft-edge/visual-studio-code/media/vscode-edge-tools-install.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f55c6da:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/debugger-for-edge.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/index.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/media/vscode-debugger-install.png
:white_check_mark:Succeeded

microsoft-edge/visual-studio-code/media/vscode-edge-tools-install.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@codepo8 mentioned elsewhere that there was already a PR to update the vs code docs. I think I found it: https://github.com/MicrosoftDocs/edge-developer/pull/1053
Waiting for guidance from Chris on what is the right move before going forward with this PR.

Thanks @mikehoffms for the review. I'll push a couple of new commits with the corresponding fixes.

Docs Build status updates of commit 2111548:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/debugger-for-edge.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/index.md
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/media/vscode-debugger-install.png
:white_check_mark:Succeeded

microsoft-edge/visual-studio-code/media/vscode-edge-tools-install.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@codepo8 please take a look at this when you get a chance. It seems like our docs about vscode were a bit outdated.
The index page was mentioning 3 extensions: the debugger for edge, the edge tools, and webhint.
While the last 2 still exist and are definitely things we want to document, the first one is deprecated as vscode has a built-in browser debugger.
So I removed references to this on the index page.
And I removed most of the docs from the "debug edge" page and instead linked to https://code.visualstudio.com/docs/nodejs/browser-debugging
What do you think?

@codepo8 - could you please review & approve this PR?


Refactor operator's code

Refactor the operators code.
The aplicar_operador definitions move to the parent class (OneQubit and TwoQubit).

lgtm


Collect OCS-must-gather for getting the remains of trash

Collect must-gather for the following commands:

rbd trash ls --pool
ceph rbd task list
https://issues.redhat.com/browse/RHSTOR-2205

BZ: #2014426
Signed-off-by: yati1998<EMAIL_ADDRESS>

/cc @ Rakshith-R

/retest

/retest-required

/assign @agarwal-mudit

/cherry-pick release-4.9


why load error when I add a emoji

There is a graph sign always on left of emoji, how to resolve this.
this is my package.json context
 "nodebb-plugin-emoji": "^5.0.5",
 "nodebb-plugin-emoji-android": "3.0.0",
 "nodebb-plugin-emoji-one": "^4.0.0",

Make sure the "url" property in config.json is set to exactly the URL at which you access the site in your browser.
Open your browser developer tools and check if there are any errors in the console.

Thanks for  the reply， I have changed “url” property in config.json to my own site and tried to rebuild nodebb
And I checked my browser developer and found some errors

I noticed some warnings when I build it. Does it matter？
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  6aa13e92b5cf7d479e73acdc7c05abf3.js (502 KiB)
  nodebb.min.js (359 KiB)
  admin.min.js (394 KiB)
  4793.dcf82000e95f412bc916.min.js (565 KiB)
  8522.0f42740e78005fe716a3.min.js (501 KiB)
  1083.65b10fecdfacafc29c2c.min.js (800 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  nodebb (359 KiB)
      nodebb.min.js
  admin (394 KiB)
      admin.min.js

Are you sure http://<IP_ADDRESS>:4567 exactly matches your browser's URL bar?

OK, the browser's URL  has only <IP_ADDRESS>, that's enough? I used Nginx to Local anti-generation 4567 to 80 port and the "port"  property in config.json that need change to 80?

The emoji plugin works, not change "port" property and set URL http://<IP_ADDRESS>:80 is ok. Thanks for your help @pitaj

If the address bar in your browser is just <IP_ADDRESS>, then you should set "url" in config.json to http://<IP_ADDRESS>.


[Request] add an option, to select the preferred source in FormBuilderImagePicker..

How to use only one Source (camera OR gallery) in FormBuilderImagePicker..?
so if we tap icon it will directly open the preferred source, camera OR gallery..
Better if there is an option to select preferred source: camera, gallery, or both..
Thanks

Is there any solution on this? am struggling to use only one source camera or gallery

This is for another repository


Does it work on 3D image as well?

I do age prediction with nifti file(MRI) then I want to use grad cam. Does it work on 3D image, nii(nifti file) as well?

Hello, it may require some modifications depending on the input and output shapes,
but this should be possible.
Can you please clarify what is the input and output from the network?
Some points to make it work with 3D

https://github.com/jacobgil/pytorch-grad-cam/blob/master/pytorch_grad_cam/grad_cam.py#L16
Need to change the axis to 2,3,4
Or even better, make it general, and be something like
axis=[i for i in range(2, len(grads.shape))]

https://github.com/jacobgil/pytorch-grad-cam/blob/master/pytorch_grad_cam/grad_cam.py#L16
weights might need another None there

The whole 2d image visualization part assumes 2D and will need to be changed.
https://github.com/jacobgil/pytorch-grad-cam/blob/master/pytorch_grad_cam/base_cam.py#L82

Once you get the 3D saliency map, you will need a nice way to visualize it.


RN High Memory Usage Post Unmount method

Hello @azesmway
Thank you for your hard work and efforts in putting this component project together. I've been able to experienment with a Unity Project increasing in size and I noticed that as my Unity project gets beefier, so does the Unity Runtime Memory usage even with the view unmounted (After mounting once).
What I'm curious to know is, have you considering adding a killSwitch to the entire Unity session? So For heavier builds we can decide to unload, or unloadUnityCompletley in order for those interested to have the option in handling memory a bit better in between scenes.
Please let me know your thoughts.
Cheers!

Any update on this? When navigating away from Unity the RAM usage is still +500mb than what it is before loading Unity


test: remove parallel exec

It causes too much noise on bench results

Results still vary a lot without parallel, it seems related to the GH env for mac/windows.


[T7][F12-B3]

Ready for review.

@MaggieMeow @gabrielsim1993 @tangshenqi @ahendraatmaja
Some comments added. Please ack & close the PR after reading comments.
Good to see all of you contributing to this PR. Please keep up the good job!

Thanks for the input!


[Docs][UI-Next] Add js-cookie license.

Purpose of the pull request
close #8729

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #8762 (4da7231) into dev (e130b82) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8762      +/-   ##
============================================
- Coverage     45.30%   45.28%   -0.02%
+ Complexity     4077     4074       -3
============================================
  Files           702      702
  Lines         27112    27112
  Branches       2897     2897
============================================
- Hits          12284    12279       -5
- Misses        13676    13678       +2
- Partials       1152     1155       +3

Impacted Files
Coverage Δ

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e130b82...4da7231. Read the comment docs.


Increase the set of synced apis from googleapis/googleapis in the bsr

Mandatory
I am looking to use a wider set of the googleapis/googleapis that are synced in the bsr. Currently the bsr includes a subset of:
https://github.com/googleapis/googleapis/tree/master/google
Specifically resources within cloud/kms/v1 are omitted:
https://github.com/googleapis/googleapis/blob/master/google/cloud/kms/v1/resources.proto#L636
The package in particular is google/cloud/kms/v1. I would like to include some of these resources within our .proto types in order to return them via our gRPC service(s).
For example (PublicKey):
message GetPublicKeyResponse {
  google.cloud.kms.v1.PublicKey public_key = 1;
}

Optional
Does this module have other module dependencies/imports?
Yes - it has quite a few dependencies. The good news is these are all already included in the bsr except one:

google/api (already included)
google/longrunning (already included)
google/rpc (already included)
google/logging (missing)

Some of these googleapis/googleapis are already synced. The suggestion would be to sync this wider set in the same manner.
I think anyone who wants to include these resources within their services within the wider community would find value in having these available on the bsr.

Hey @PeregrineFalcon - we've discussed this internally and we are not going to add these packages to googleapis/googleapis at this time. For now, we'd suggest creating a BSR module with a copy of the protos you need and depend on the types in buf.build/googleapis/googleapis. Sorry for the inconvenience!


ebmbot could do with a command to restart the application

There's a specific need for this after an import in order to pick up the new matrixstore file. But I can also imagine it being useful in cases where something has got in a weird state and none of us have easy access to an SSH session.

We actually still don't have this and I still think it would be useful!

@evansd fair enough, is this an openprescribing issue though, or should it be somewhere else?


Add one function to parse all weird IP formats

Fixes #177

And if you don't change the IP address handling in the BFD/BGP monitor tasks in this PR, then please make a new issue so that this is not forgotten :smile:

Made BFD and BGP task use parse_ip. Removed using the AddrType value in BDF to decide ipv4/ipv6 since this will be detected automatically anyways. This does mean it will accept Ipv4 adresses even if the AddrType is set to Ipv6 in the case there is some error in the MIB values, but that basically just makes the code more robust.
Does anyone have a strong opinion on using AddrType to decide ipv4/ipv6 vs letting it be automatically detected?


[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal  to Object

Historically, we have classes like NodePtr/Ref/HashEqual.
After unified object protocol, these names are just alias of the object counterpart.
Moreover, there are helper macros defined over the places for defining these object.
This PR consoldiate the terminologies into the corresponding ones
in the Object system so we have a clean and consistent API moving forward.
Changes
NodePtr/Ref/Hash/Equal -> ObjectPtr/Ref/Hash/Equal
TVM_DEFINE_NODE_REF_METHODS -> TVM_DEFINE_OBJECT_REF_METHODS
consoldate relay macros into the object ones

cc @jroesch @wweic @yzhliu @Hzfengsy @ZihengJiang

Do we also want to do renaming in python code? There are still NodeBase, register_node in python

@tqchen  Do we also want to do renaming in python code? There are still NodeBase, register_node in python.
Given a lot of rename has been done recently in several PRs. Could you also provide a upgrade instructions for us to update our codebase.

@merrymercy yes we should update the python side as well, please feel free to open PRs :)
Here is the guide #4647 , please feel free to add comments


Enable uinput kernel module as a part of the package

as I figured out,  evdev depend on the availability of the kernel module uinput, but it does not set it as part of the installation process. That leave the evdev unusable after the installation of it's package. Without manual setup.

Only BBN OS. And other install scripts take care of it


Fix Python 3.12 compat: pkg_resources -> importlib

Traceback (most recent call last):
  File ".../bin/lice", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File ".../lib/python3.12/site-packages/lice/__init__.py", line 5, in main
    from lice.core import main
  File ".../lib/python3.12/site-packages/lice/core.py", line 1, in <module>
    from pkg_resources import (resource_stream, resource_listdir)
ModuleNotFoundError: No module named 'pkg_resources'

Hi @jcarbaugh,
It seems the lice is broken on Python 3.12 because of incompatible changes. Could you review this patch which may fix it?
--
Jiangge Zhang

@tonyseek as it seems this project is not getting updated, I have forked and released lice2. It fixes this issue and a couple others while adding new features like a configuration file and a lot of internal updates. I plan to keep maintaining it for the forseeable future and have a few ideas for new features.
Check it out on https://seapagan.github.io/lice2/