make and windows are not compatible.

Within the readme.md within {{cookiecutter.package_name}}
cd docs/writeup
make html

There are a proportion using this on a windows operating system and the make command does not work here.
Either needs a suggestion for windows or a clarification that this does not work on a windows operating system.
Please don't remove the Sphinx template as it's a very good idea to include from start of project.

There is actually a batch file make.bat that will be run on windows. Updated the README to clarify this


Support Node versions > 7

For now we work with Node v7 (see https://weacast.gitbooks.io/weacast-docs/guides/DEVELOPMENT.html#prerequisites):

[x] remove the harmony_async_await flag from scripts/tests
[x] check if all dependencies work with Node versions > 7

Also fixed issue with babel env generating ES2015 code, we now use the babel-preset-env plugin.


Fix missing icon

The 3rd icon vanished on hover, I want to fix this. Please assign it to me under gssoc'23

now these properly working


Work in progress

I am trying to put the desearilizaer factory into a hashmap, which is initialized in the main function.

Closing and seems this PR is replaced by #881.


NoInstancesException

Hi,
I get a fatal error on a wierd but I think valid vcalendar object (version 1.8.9):
PHP Fatal error:  Uncaught exception 'Sabre\VObject\Recur\NoInstancesException' with message 'This recurrence rule does not generate any valid instances' in /usr/share/groupoffice/go/vendor/VObject/lib/Sabre/VObject/Recur/EventIterator.php
The strange thing about the vobject is that it's a recurring event but all the recurring instances have an exdate set:
BEGIN:VCALENDAR
BEGIN:VEVENT
UID:fa0400c1-b6b7-5d83-b452-0e1f92cc70c2
DTSTAMP:20150716T151809Z
DTSTAMP:20150716T131809Z
LAST-MODIFIED:20150701T114454Z
CREATED:20150701T114454Z
SUMMARY:Sabre bug
STATUS:CONFIRMED
DTSTART;TZID=Europe/Berlin:20150826T100000
DTEND;TZID=Europe/Berlin:20150826T103000
LOCATION:DB
RRULE:FREQ=DAILY;UNTIL=20150827T235900
EXDATE;TZID=Europe/Berlin:20150826T100000
EXDATE;TZID=Europe/Berlin:20150827T100000
END:VEVENT
END:VCALENDAR
Shouldn't this be valid and secondly, shouldn't the error at least be caught and handled with a proper response code?
Thanks!

Hey,
This is an issue that came up a little while ago. It's not clear if this is a valid event, the spec don't really seem to say if it is or isn't. What I can say is that it's completely useless data. This event will never show up in a calendar anywhere, and it can't be deleted by a user. So we decided to consider it invalid.
I agree that it should be met with a good status code. Which HTTP request is triggering the exception?

No feedback received


Handling of "auto" in deepspeed config causes crash under Zero3

System Info

Platform: Linux-5.15.0-86-generic-x86_64-with-glibc2.35
Python version: 3.10.14
PyTorch version: 2.4.1
CUDA device: NVIDIA A100-SXM4-80GB
Transformers version: 4.45.0.dev0
Accelerate version: 0.34.2
Accelerate config: not found
Datasets version: 3.0.0
HF Hub version: 0.25.0
TRL version: 0.12.0.dev0+5c21de3
bitsandbytes version: 0.41.1
DeepSpeed version: 0.14.5+ffe0af23
Diffusers version: 0.30.3
Liger-Kernel version: 0.3.1
LLM-Blender version: 0.0.2
OpenAI version: 1.51.0
PEFT version: 0.13.0

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[X] My own task or dataset (give details below)

Reproduction
This issue was reported in the hf transformers repo initially here:
https://github.com/huggingface/transformers/issues/29348
I can probably put together a fix for trl when I have some more free time if y'all are interested, since I understand the behaviour now.
Current Behaviour
The base huggingface transformer calls hf_deepspeed_config.trainer_config_finalize(args, model, num_training_steps) to change the values of total_num_steps" and warmup_num_steps from auto to be their calculated value during the inner training loop (when the total_num_steps is know). However, in DPOTrainer if total_num_steps is set to "auto" then the trainer will crash when deepspeed.initialize is called when wrapping the ref model at self.ref_model = self._prepare_deepspeed(self.ref_model).
DS config
{
    "resource": {
        "num_gpus": 0
    },
    "fp16": {
        "enabled": "auto",
        "loss_scale": 0,
        "loss_scale_window": 1000,
        "initial_scale_power": 16,
        "hysteresis": 2,
        "min_loss_scale": 1
    },
    "optimizer": {
        "type": "AdamW",
        "params": {
            "lr": "auto",
            "weight_decay": "auto",
            "torch_adam": true,
            "adam_w_mode": true
        }
    },
    "scheduler": {
        "type": "WarmupDecayLR",
        "params": {
            "total_num_steps": "auto",
            "warmup_min_lr": "auto",
            "warmup_max_lr": "auto",
            "warmup_num_steps": "auto"
        }
    },
    "zero_optimization": {
        "stage": 3,
        "allgather_partitions": true,
        "allgather_bucket_size": 2e8,
        "overlap_comm": true,
        "reduce_scatter": true,
        "reduce_bucket_size": "auto",
        "contiguous_gradients": true,
        "stage3_gather_16bit_weights_on_model_save": "auto"
    },
    "gradient_accumulation_steps": 1,
    "gradient_clipping": "auto",
    "steps_per_print": 2000,
    "train_batch_size": "auto",
    "train_micro_batch_size_per_gpu": "auto",
    "wall_clock_breakdown": false
}

Script
import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
from trl import DPOTrainer, DPOConfig  # Make sure you have this module
from datasets import load_dataset
# Load your LLaMA 2 model and tokenizer
model_name = "/home/b3schnei/pretrained/Llama-2-7b"  # Change this to the specific LLaMA 2 model you want to use
tokenizer = AutoTokenizer.from_pretrained(model_name)
model = AutoModelForCausalLM.from_pretrained(model_name)
from datasets import Dataset

# Load your reference model (if applicable)
ref_model = AutoModelForCausalLM.from_pretrained(model_name)

# Define training arguments
training_args = DPOConfig(
    learning_rate=2e-4,
    num_train_epochs=1,
    per_device_train_batch_size=4,
    output_dir='./results',
    logging_steps=10,
    remove_unused_columns=False,
    max_length=1024,
    max_prompt_length=512,
    fp16=True,
    deepspeed="/home/b3schnei/transformers_debug/debug/29348/ds_config.json"  # Ensure you have this configuration file
)

train_dataset = load_dataset("json", data_files="debug/29348/dpo.json",split="train")

# Initialize the DPOTrainer
dpo_trainer = DPOTrainer(
    model=model,
    ref_model=ref_model,
    train_dataset=train_dataset,
    tokenizer=tokenizer,
    args=training_args,
)

# Start training
if __name__ == "__main__":
    dpo_trainer.train()

Crash log
[2024-10-02 01:18:15,497] [INFO] [utils.py:789:see_memory_usage] CPU Virtual Memory:  used = 121.5 GB, percent = 12.1%
[2024-10-02 01:18:15,497] [INFO] [logging.py:96:log_dist] [Rank 0] DeepSpeed Final Optimizer = DeepSpeedZeroOptimizer_Stage3
[rank0]: Traceback (most recent call last):
[rank0]:   File "/home/b3schnei/.vscode-server/extensions/ms-python.debugpy-2024.10.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/pydevd.py", line 3489, in
[rank0]:     main()
[rank0]:   File "/home/b3schnei/.vscode-server/extensions/ms-python.debugpy-2024.10.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/pydevd.py", line 3482, in main
[rank0]:     globals = debugger.run(setup['file'], None, None, is_module)
[rank0]:   File "/home/b3schnei/.vscode-server/extensions/ms-python.debugpy-2024.10.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/pydevd.py", line 2510, in run
[rank0]:     return self._exec(is_module, entry_point_fn, module_name, file, globals, locals)
[rank0]:   File "/home/b3schnei/.vscode-server/extensions/ms-python.debugpy-2024.10.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/pydevd.py", line 2517, in _exec
[rank0]:     globals = pydevd_runpy.run_path(file, globals, 'main')
[rank0]:   File "/home/b3schnei/.vscode-server/extensions/ms-python.debugpy-2024.10.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 321, in run_path
[rank0]:     return _run_module_code(code, init_globals, run_name,
[rank0]:   File "/home/b3schnei/.vscode-server/extensions/ms-python.debugpy-2024.10.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 135, in _run_module_code
[rank0]:     _run_code(code, mod_globals, init_globals,
[rank0]:   File "/home/b3schnei/.vscode-server/extensions/ms-python.debugpy-2024.10.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 124, in _run_code
[rank0]:     exec(code, run_globals)
[rank0]:   File "/home/b3schnei/transformers_debug/debug/29348/reproduce.py", line 34, in
[rank0]:     dpo_trainer = DPOTrainer(
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/huggingface_hub/utils/_deprecation.py", line 101, in inner_f
[rank0]:     return f(*args, **kwargs)
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/trl/trainer/dpo_trainer.py", line 883, in init
[rank0]:     self.ref_model = self._prepare_deepspeed(self.ref_model)
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/trl/trainer/dpo_trainer.py", line 924, in prepare_deepspeed
[rank0]:     model, * = deepspeed.initialize(model=model, config=config_kwargs)
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/deepspeed/init.py", line 181, in initialize
[rank0]:     engine = DeepSpeedEngine(args=args,
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 307, in init
[rank0]:     self._configure_lr_scheduler(lr_scheduler)
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 907, in _configure_lr_scheduler
[rank0]:     lr_scheduler = self._scheduler_from_config(self.optimizer)
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 962, in _scheduler_from_config
[rank0]:     instantiated_scheduler = scheduler(optimizer, **scheduler_params)
[rank0]:   File "/home/b3schnei/anaconda3/envs/test_transformers/lib/python3.10/site-packages/deepspeed/runtime/lr_schedules.py", line 758, in init
[rank0]:     if self.total_num_steps < self.warmup_num_steps:
[rank0]: TypeError: '<' not supported between instances of 'str' and 'int'
Expected behavior
I expect the DPOTrainer to initialize under Zero3 when setting ds_config values to "auto" like in transformer's trainer.

I can probably put together a fix for trl when I have some more free time if y'all are interested, since I understand the behaviour now.

Thanks for reporting, help in proposing a fix would be greatly appreciated.


re-enable InheritDoc

Validated that one of the example CIs that failed previously and it passes as expected. example here
This PR re-enables InheritDoc again. I'll monitor for any failed CIs

I take it the script isn't checked in. Should it be? Or is this just a one-time thing?

I take it the script isn't checked in. Should it be? Or is this just a one-time thing?

It turns out that most of the warnings were produced are from generated code. So after fixing that, cleaning up the rest is a few fairly straightforward Regex find/replaces.
It will be a one time only fix that will be enforced going forward by CI since we run with -warnaserror.


fix travis format

Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

Codecov Report

Merging #679 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #679      +/-   ##
============================================
- Coverage     72.38%   72.32%   -0.07%
  Complexity     1078     1078
============================================
  Files           364      364
  Lines         15127    15127
  Branches       2424     2424
============================================
- Hits          10950    10940      -10
- Misses         2916     2929      +13
+ Partials       1261     1258       -3

Impacted Files
Coverage Δ
Complexity Δ

...java/com/alipay/sofa/rpc/module/LookoutModule.java
52.63% <0%> (-31.58%)
3% <0%> (-1%)

...y/sofa/rpc/bootstrap/DefaultProviderBootstrap.java
71.23% <0%> (-2.29%)
0% <0%> (ø)

.../main/java/com/alipay/sofa/rpc/event/EventBus.java
70.58% <0%> (-1.97%)
0% <0%> (ø)

...lipay/sofa/rpc/registry/consul/ConsulRegistry.java
50% <0%> (+0.57%)
19% <0%> (+1%)
:arrow_up:

...com/alipay/sofa/rpc/context/RpcRuntimeContext.java
88.88% <0%> (+1.23%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20537e...bdcf17e. Read the comment docs.


Refuse dynamic updates properly

Give proper answer to dynamic update requests.
Fixes: #111

Coverage decreased (-0.5%) to 92.903% when pulling 0f96053a2d2f9fd042d5b69f28ce846c11ebb2e2 on refuse_dynupdate into 1d85bf75b05320cf5f3029a45cee2798421acbf9 on master.


Allow Topo Data Pipeline to assume role without AD authentication

User Story

So that I can import data to the geostore from a pipeline or machine, as a LINZ/Topo developer, I want to authenticate from my AWS pipeline/account/process, instead of assuming a role that requires a user to be part of an AD group

Currently users assume the role geostore-prod-api-users which is connected to an AD group A_AWS_LINZ_LI_Datalake_Maintainers
Acceptance Criteria

[ ] Given that I am logged in to the LINZ AWS org, when I invoke a Geostore lambda, then I am allowed to do so
[ ] Given I am not logged in to the LINZ AWS org, when I invoke a Geostore lambda, then I am not allowed to do so

Additional context

Discussion with TDE team on 28/04/22:

They are building a CLI tool where the user has assumed an AD linked role already and can't assume another AD linked role in the same session
They may end up automating the entire process in the future, so there may be no user involved at all
They will be running their process from multiple accounts in the future at least 4 and probably more

Discussed some possible solutions:

Allow assuming the role from any LINZ AWS account
a.  This would mean any LINZ dev or anyone with AWS access could overwrite existing data
b. may want to add monitoring and/or prevention to catch actors that accidentally overwrite someone else's data
c. may have to revisit this in the future if it becomes a problem
Allow assuming the role to a list of Topo accounts
a. This could become unwieldly to manage if there is a large or constantly changing list of accounts that need to be redeployed every time

Tasks

[ ] Figure out how to test this
[ ] Write a test that fails
[ ] Make changes so that it passes

Definition of Ready

[ ] This story is ready to work on

[ ] Independent (story is independent of all other tasks)
[ ] Negotiable (team can decide how to design and implement)
[ ] Valuable (from a user perspective)
[ ] Estimate value applied (agreed by team)
[ ] Small (so as to fit within an iteration)
[ ] Testable (in principle, even if there isn't a test for it yet)
[ ] Environments are ready to meet definition of done
[ ] Resources required to implement will be ready
[ ] Everyone understands and agrees with the tasks to complete the story
[ ] Release value (e.g. Iteration 3) applied
[ ] Sprint value (e.g. Aug 1 - Aug 15) applied

Definition of Done

[ ] This story is done:

[ ] Acceptance criteria completed
[ ] Automated tests are passing
[ ] Code is peer reviewed and pushed to master
[ ] Deployed successfully to test environment
[ ] Checked against CODING guidelines
[ ] Relevant new tasks are added to backlog and communicated to the team
[ ] Important decisions recorded in the issue ticket
[ ] Readme/Changelog/Diagrams are updated
[ ] Product Owner has approved acceptance criteria as complete
[ ] Meets non-functional requirements:

[ ] Scalability (data): Can scale to 300TB of data and 100,000,000 files and ability to
increase 10% every year
[ ] Scability (users): Can scale to 100 concurrent users
[ ] Cost: Data can be stored at < 0.5 NZD per GB per year
[ ] Performance: A large dataset (500 GB and 50,000 files - e.g. Akl aerial imagery) can be
validated, imported and stored within 24 hours
[ ] Accessibility: Can be used from LINZ networks and the public internet
[ ] Availability: System available 24 hours a day and 7 days a week, this does not include
maintenance windows < 4 hours and does not include operational support
[ ] Recoverability: RPO of fully imported datasets < 4 hours, RTO of a single 3 TB dataset <
12 hours

Tested this and


Host admin can freeze Collective activity

User story
As a host admin, sometimes we need to flag a Collective due to various issues and not allow certain activities while we sort it out. Right now we have to manage this manually and it's really tricky in a large host with multiple staff processing expenses etc.
Examples I've dealt with:

Expense payment is pending signing of a contract before we can release funds (it was a large payment to a for-profit company, which for OCF means we need a contract for services in place)
Collective has committed the funds to a specific purpose and we can't let them spend them on something else (Collective is asking us to sign a lease on their behalf, requiring them to set aside the money to cover the value of the lease term and not spend it elsewhere)
Internal conflict among Collective admins where we don't want them to add or remove admins until we work it out
We are alerted to possible fraud or misuse of funds and need to freeze incoming contributions and outgoing expenses
We become aware that a worker has to be classified as an employee and can't continue to pay them as a contractor, and need to stop payment on outstanding invoice expenses

Best solution for this problem

A freeze menu in the hosted collectives dashboard screen with these options:

Expenses (disables pay button on all outstanding and new expenses, but still lets them submit expenses)

Invoices (select)
Receipts (select)

Admins (stops any removing or adding of admins)
Contributions (disables new contributions and pauses recurring ones)
A text box to write a note about what's going on

MVP
Add these functions to the root admin dashboard in an MVP way. The most important one in my mind is expenses, so MVP could just focus on that.

@alanna I love the freeze icon :smile: Until we have something implemented here, feel free to ping engineering for such cases; we can manually disable features selectively (expenses, contributions, etc) for an account in the database.
On the API side, there's not much needed to implement this: we can rely on account.features to disable contributions and expenses. We'll probably need a new permission like FEATURE.EDIT_MEMBERS to prevent editing admins.
We'll also need an email template to inform collectives and send them the message (it should ideally details which features are blocked).

Here to plus one and say @alanna is right. Use case is now proven out by a dispute in one of our current projects.

in the last week alone, OCF has had multiple internal disputes arise from within a few of our hosted collectives.  to me, this is the most immediate solution in the first step towards conflict resolution.
feels pretty vital to have this - before things get bigger.

Just a note to say that I've implemented a quick flag to disable all features for a collective at once: https://github.com/opencollective/opencollective-api/pull/7187. We can probably re-use that to resolve this issue

User needs
:art: = needs required

:art: Confirmation modal

Checkbox to not send a notification
Ability to add a custom message if a notification is sent. We need to record this to be accessible to the admins (BCC all host admins, store it in the database > Activities)

Notification

Include the custom message
"Your account has been frozen. Please contact your fiscal host or<EMAIL_ADDRESS>for more information." (added the support email here in case we are freezing an independent collective)
Would be sent from<EMAIL_ADDRESS>but with a link to the contact page of the host: https://opencollective.com/opensource/contact

:art: Have a special view for all collective pages to surface that the collective is frozen (kind of like what we do for achieved collectives). We must be careful with the wording and not disclose too much info, there are many reasons why a collective may be frozen. Maybe something like "Contributions to this page cannot be accepted at this time".
Must be able to unfreeze, no need for a custom message there
We must make sure that children (projects/events) are frozen as well
:art: Would be great to have some granularity: eg. block expenses, but still allow to receive contributions/issue updates

Is this issue replacing #3330 ? @alanna wdyt?

@Memo-Es They are different, and both are needed. Freezing is the more immediate need imo, but it is a preliminary step when dealing with problematic collectives. Then the host may choose to un-host, or unfreeze it and return to an active state.

[ ] Design Input

@Memo-Es I know you mentioned potentially changing the language to "pause" collective but in my opinion "freeze" is actually the proper English term. For example, the phrase "freeze" bank account is commonly used, and at a previous fiscal sponsor "freeze" was also used. It is not actually all that much like DnD :)

what about a stop sign?  (is a red octogon universal enough for 'Stop'? that hand looks like a wave to me...

I actually think a pause icon would be good. But I 100% agree we should
name it "freeze".Message ID:
@.*>

Design update

Freeze Collective icon
Confirmation modal + send message
Collective page

Feedback and help to nail down the final copy are welcome @alanna @natehn

Does freezing also include stopping contributions?

@alanna we discussed how a nice-to-have feature would be having a checkbox for whether or not to allow contributions, as shown in the design. I believe the MVP does not allow contributions. Does that feel right to you?
@Betree @SudharakaP - I'm don't think we want admins to be able to submit Updates in the MVP. In a more nuanced version, this could be its own option as well, alongside contributions.
@Memo-Es here are my edits to the copy:

change "wont" to "won't" or "will not" and "payout" to "pay out"
might remove note about Updates per above?
I would change "Let the admins know how they can solve this situation" to "Let the admins know if any action is  required" ...or something like that

For the copy for the banner - what about "temporarily restricted" rather than just restricted?
Another, softer term is "limited" - so perhaps it could be "temporarily limited"

If there could be options when the host freezes, i.e. whether to pause contributions, expenses, updates, that would be ideal.

My take:
+1 to 'temporarily limited' over restricted
on the popup:

Are you sure want to freeze this collective?
Freezing this collective means temporarily limiting what a collective (and their related Projects) can and cannot do on the platform.
They will not be able to accept funds, pay out expenses, or post updates. ^
Include a message to the Collective admins (Optional) They will also be notified of this freeze via auto-email notification.
[Write an additional note to admins to let them know if action is required]
[ ] Allow frozen collective to receive contributions
[ ] Allow frozen collective to pay out expenses
[ ] Allow frozen collective to post updates

^ can they still edit their settings/team/about section/move money between projects...is there any other functionality we're forgetting to include/that they should or shouldn't be restricted from?)

I think the granularity of the capabilities of frozen Collectives should be tackled in a follow-up project. Also, I'm not a fan of that many checkboxes in the modal.
Anyway, let's check with @Betree when he's back

(and their related Projects)

And Events right?
What happens to their recurring contributions? Are they cancelled or just paused? I hope not cancelled.
I think three checkboxes is fine. They represent the real diversity of situations where we need to apply this action. This will be a rarely used feature only seen by host admins.  We care about more fine-grained control depending on the situation. If there are technical reasons it's too much to have all three options, and it can't be in scope, fine, but let's not make that call for UX reasons.

If its a rarely used feature (I agree it is), perhaps it shouldn't be in your face all the time; then, we can put it under a 'More' icon instead of a more distracting one; it gives us the flexibility to add more stuff in there in the future.
@alanna

I think the granularity of the capabilities of frozen Collectives should be tackled in a follow-up project. Also, I'm not a fan of that many checkboxes in the modal. Anyway, let's check with @Betree when he's back

Indeed. In the MVP we're going to start with blocking everything. We can then iterate to add checkboxes for specific features.
@Memo-Es The design shared in https://github.com/opencollective/opencollective/issues/4694#issuecomment-1070341817 looks good. We can foresee that we'll probably need something like a menu to handle all the specific actions (like #3330) in the future.

I think the granularity of the capabilities of frozen Collectives should be tackled in a follow-up project. Also, I'm not a fan of that many checkboxes in the modal.

am also fine with tackling this later.  but I was not involved in the most recent need-cases so much, so not sure how vital this granularity is immediately. (or if having this level of granularity would have been helpful).  I also feel like we're not covering all the right granularity in the 3 checkboxes, so i'd rather take the time to flesh it out properly.
__
adding in the comments from above:
on the popup:
Are you sure want to freeze this collective?
Freezing this collective means temporarily limiting what a collective (and their connected Projects & Events) can and cannot do on the platform.
They will not be able to accept funds, pay out expenses, post updates, create new Events or Projects under this collective.  However, they will still continue to receive recurring donations that were started before this freeze.
Include a message to the Collective admins (Optional) They will also be notified of this freeze via auto-email notification.
[Write an additional note to admins to let them know if action is required]

we also need consider the 'unfreezing' side of this. (or whatever we might want to call it)
[ ] play icon instead of pause icon
[ ] module popup
[ ] auto email to collective
on the popup:
Are you sure want to unfreeze this collective?
Unfreezing this collective means reinstating their complete usability on the platform.
This collective (and all its related Projects & Events) will now have access to accept funds, pay out expenses, post updates, create new Events or Projects.
Include a message to the Collective admins (Optional) They will also be notified of this unfreeze via auto-email notification.
[Write an additional note to admins to let them know if action is required]

@kaylarep Thanks for the feedback on the wording, I applied your suggestions for the first implementation of the modal!
I need some more input for the emails sent to the collective admins. I created these first drafts:
Frozen collective email

Hi {name},
Your fiscal host, Open Source Collective org, has frozen your Collective. In other words, they've temporarily limiting what you (and your connected Projects & Events) can and cannot do on the platform.
Your collective, {name}, will not be able to accept funds, pay out expenses, post updates, create new Events or Projects, add new Team members under this collective. However, they will still continue to receive recurring donations that were started before this freeze.
Open Source Collective org included the following message:
...

Unfrozen collective email

Hi {name},
Your fiscal host, Open Source Collective, has unfrozen your Collective. In other words, they've temporarily limiting what you (and your connected Projects & Events) can and cannot do on the platform.
Your collective {name} (and all its related Projects & Events) will now have access to accept funds, pay out expenses, post updates, create new Events or Projects.
Open Source Collective org included the following message:
...

small edits in bold/strikethrough @Betree:
Frozen:

...they've temporarily limiting limited...

...or add new Team members under this collective.

^ noting that this list will need to change based on the check boxes

However, they the Collective will

Unfrozen:

In other words, they 've temporarily limiting what you (and your connected Projects & Events) can and cannot do on the platform. have reactivated any features that were previously limited while frozen.

...will may again have access to accept funds, pay out expenses, post updates, and create new Events or Projects.

^ again, adjusting based on granularity
Hope this is helpful!

One more line to add to the bottom of Frozen Collective:

If you have additional questions about this freeze, please contact your fiscal host.

[ ] finish the front end
[ ] limit the features a host can block
[ ] decide scope of the block

Include a message to the Collective admins (Optional) They will also be notified of this unfreeze via auto-email notification.

@kaylarep : Here we use "notified/notification" twice which to me seems repetitive somehow. I think we could avoid this by using something like, "An automatic email notification will be sent to them about the unfreeze". WDYT? 🤔


[2pt] Unit tests for Book and Label classes - Team Member #1

Add unit tests for all implemented methods.

Pull request for this task


add test to sqlite example

Adding a login-logout test to the sqlite example.
Several questions arose while implementing the test:

How to build the login request, to include cookies(*) like AuthSession and Messages in the request
How to verify that the user is logged in
Why logout is a GET request instead of a POST in these examples

these questions are documented in the test:
#[sqlx::test]
async fn test_login_logout(pool: SqlitePool) {
    let app = setup_app(pool).await.unwrap();

    let login_request = {
        let credentials = Credentials {
            username: "ferris".to_string(),
            password: "password".to_string(),
            next: None,
        };
        // todo: unclear how to instatiate or add to request; no tests in axum-messages
        // let messages: Messages;
        let credentials = serde_urlencoded::to_string(credentials).unwrap();

        Request::builder()
            .uri("/login")
            .method("POST")
            .header(CONTENT_TYPE, "application/x-www-form-urlencoded")
            // todo: where do I put messages in the request?
            .body(credentials)
            .unwrap()
    };
    let login_response = app.clone().oneshot(login_request).await.unwrap();
    dbg!(&login_response);
    assert!(login_response.status().is_redirection());

    // todo: how to verify that the user is logged in?

    // why is logout a get request instead of a post in the example?
    let logout_request = Request::builder()
        .uri("/logout")
        .method("GET")
        .body(Body::empty())
        .unwrap();
    let logout_response = app.clone().oneshot(logout_request).await.unwrap();
    dbg!(&logout_response);
    assert!(logout_response.status().is_redirection());
}

Thanks for putting this together!
I'm curious how this is different from the integration tests and why we wouldn't continue to colocate tests in that directory?

I think your question is why bother with unit tests for a server, as opposed to only integration tests, please correct me if otherwise.
Integration tests are useful for testing the overall function of a server. Unit tests are closer to sanity checks, that some component is functioning as expected.
I am currently debugging where axum-login is breaking within my own server, and these sanity checks help me reason with finer granularity as to whether I have made mistakes, or if something is broken in the library (I don't yet know).

I'd prefer this kind of thing be done in a separate repo and that we continue to use the test harness that's already in place for axum-login and its examples.


Can you remove this assertion failure in multiroot?

I keep hitting this asserion failure when debugging our C/C++ extension.
        console.assert(this.projectController.numOfWorkspaceFolders === vscode.workspace.workspaceFolders?.length);

at https://github.com/microsoft/vscode-cmake-tools/blob/8018ef5d5edfa9a06af6f88c7e5e9ea999b693fe/src/extension.ts#L118 .
Can you remove that?
My repro is with a multiroot workspace in which one or more of the workspace folders doesn't have a CMakeLists (or isn't configured to build with it).
this.projectController.numOfWorkspaceFolders is 1
and vscode.workspace.workspaceFolders?.length is 2+.

Oh -- I found out the breaking in the debugger was caused by the "Unchecked exceptions" options being checked -- if I uncheck that then it doesn't always break in the debugger from this.

@gcampbell-msft Yeah, I could also submit a PR too if you want.

#3485


None of the callbacks in the gesture are worklets.

Describe the bug
Getting this error:
 WARN  [react-native-gesture-handler] None of the callbacks in the gesture are worklets. If you wish to run them on the JS thread use '.runOnJS(true)' modifier on the gesture to make this explicit. Otherwise, mark the callbacks as 'worklet' to run them on the UI thread.
    at GestureDetector (http://<IP_ADDRESS>:8081/src/index.ts.bundle//&platform=ios&dev=true&hot=false&lazy=true&transform.engine=hermes&transform.bytecode=true&transform.routerRoot=src%2Fapp:279727:49)
    at IScrollViewGesture (http://<IP_ADDRESS>:8081/src/index.ts.bundle//&platform=ios&dev=true&hot=false&lazy=true&transform.engine=hermes&transform.bytecode=true&transform.routerRoot=src%2Fapp:368982:54)

To Reproduce
Steps to reproduce the behavior:

"react-native-reanimated-carousel": "4.0.0-alpha.12" in my project https://github.com/trevorpfiz/project-hyper
Follow https://reanimated-carousel.dev/usage
See error

I created a snack, but can't see the error there:
https://snack.expo.dev/@elektrikspark/joyous-violet-kiwi
Expected behavior
I would expect no issues with this library and react-native-gesture-handler
Versions (please complete the following information):

react: v18.3.1
react-native: v0.74.5
react-native-reanimated: v3.15.0
react-native-reanimated-carousel: v4.0.0-alpha.12
react-native-gesture-handler: v2.18.1

Smartphone (please complete the following information):

Device: iPhone 14 Pro Max
OS: iOS 17.5.1

Additional context
Let me know if more is needed, thanks!

Does #577 appear to resolve this? 🙏

Does this PR appear to resolve this? 🙏

fix: gesture onStart, onUpdate, and onEnd (et al) should be worklets #577

not totally sure, maybe. how does https://docs.swmansion.com/react-native-gesture-handler/docs/#automatic-workletization-of-gesture-callbacks relate to all this?

Does this PR appear to resolve this? 🙏

fix: gesture onStart, onUpdate, and onEnd (et al) should be worklets #577

not totally sure, maybe? how does https://docs.swmansion.com/react-native-gesture-handler/docs/#automatic-workletization-of-gesture-callbacks relate to all this?

yeah! In #577, see "Discussion of the bug" / "But why doesn't the react-native-reanimated/plugin babel plugin automatically workletify these handlers?"

Same issue here! Is there any workaround for the moment?

+1

+1

I think this should be fixed with

#577

which was released in https://github.com/dohooo/react-native-reanimated-carousel/releases/tag/v4.0.0-canary.13

I had a similar bug, here's what removed the warning for me:
Versions(details):
"react": "18.2.0",
"react-native": "0.74.5",
"react-native-gesture-handler": "~2.16.1",
"react-native-reanimated": "~3.10.1",
"react-native-reanimated-carousel": "^4.0.0-alpha.12",

Added plugins: ["react-native-reanimated/plugin"], to babel.config.js.
Added GestureHandlerRootView with a flex to my app layout.
<GestureHandlerRootView style={{ flex: 1 }}>  {app content} </GestureHandlerRootView>

I think this should be fixed with

fix: gesture onStart, onUpdate, and onEnd (et al) should be worklets #577

which was released in v4.0.0-canary.13 (and included in releases thereafter)

+1 to the issue described above. @nmassey, it is certainly possible I did something improper. However, I thought I would share that after installing "^4.0.0-canary.13" of react-native-reanimated-carousel, the onPress callback for <Pagination.Basic ... onPress /> was not firing.
Cheers.

Hi @softwaresean - there was a bug (#676) introduced in canary.13. It was fixed via #677 which was released with canary.15.
If you update to canary.15 or higher (the latest is 17), does this fix your issue?

I am facing the same issue. But I am not using gesture handler anywhere directly. I have installed it for drawer navigation. How to fix this?

I have the same problem

I updated all the packages related to navigation and it solved the issue.


Add operationId key to every call

While Swagger doesn't explicitly mandate operationId, lack of this key is basically the only thing that prevents from generating stubs in other programming languages that would marshall/unmarshall Matrix JSON. Case in point: https://github.com/KitsuneRal/gtad is a tool in development that would do exactly that over (generally) any OpenAPI spec but with a focus on Matrix CS API. The respective branch of libqmatrixclient is gradually making use of the generated files (so far only two cpp/h pairs are actually in use but much more are ready for that).

matrixbot: test this please

Sorry for a long silence. Addressed the operationid vs. operationId thing - hopefully the bot will be fine now.
As for updating validator.js - since swagger-parser is very weak on extensibility, I think I have to traverse api in the callback function once more, after the validator traversed it, and check that all endpoints have operationId. However ugly this is, I just don't see other options.

Apologies if my addition to the validator is untidy: it's my first JavaScript code in 10+ years.

matrixbot: test this please

I ended up factoring out the repetitive code into a closure and a trivial makeHandler factory method to produce it. Feel free to shout "stop throwing the code around" if you don't like it :)

Fixed as advised.

Thanks!


implement standard event bubbling methods for use with declarative bindings

For the custom event delegation that is implemented in declarative bindings, we should support standard methods related to event bubbling, such as:
event.stopPropagation()
event.stopImmediatePropagation()

There are also older properties like event.cancelBubble which we probably don't need to worry about.

New version published with event.stopPropagation() support<EMAIL_ADDRESS>Thank you, @1N50MN14, for the PR!


Added proportional and interpolated losses in RiverNode

This addresses #186 and implements a loss on the river node using a proportional factor or a piecewise linear interpolation of loss data

The loss is now calculated as in the LossLink


[BEAM-13307][Playground] Support Python SDK

[BEAM-13307][Playground] Support Python SDK on backend + Dockerfile

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

I've merged, but let's remember to address some of the comments : )


when i play an audio in a component, the swiper will update constantly

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/s/adoring-scott-b3xuuf?file=/pages/index.vue
Bug description
i use swiper in my nuxt project，and the version is under below:
"swiper": "^5.4.5",
"vue-awesome-swiper": "^4.1.1"
when i play play an audio,the swiper will destory and create constantly,and pause audio  it will stop
it cause the image reload and the swiper class、style recomputed constantly;
you could see the porject in codesandbox,and inspect the element
you will see it
here is the codesanbox url:https://codesandbox.io/s/adoring-scott-b3xuuf?file=/pages/index.vue
Expected Behavior
when i play play an audio,the swiper will not computed constantly
Actual Behavior
No response
Swiper version
5.4.5
Platform/Target and Browser Versions
chrome
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

a few things to keep in mind @kingstarstar

use client-only instead of no-ssr
you are using a different wrapper for swipper  - "vue-awesome-swiper": "^4.1.1"
try to bind your slideChange function  on the swiper itself for the event emitted

 <swiper ref="mySwiper" :options="swiperOptions" @slideChange="slideChange">
          <!-- eslint disable next-line -->
          <swiper-slide v-for="url in coverList" :key="getUUid()">
            <img :src="url" />
            <!-- {{url}} -->
          </swiper-slide>
        </swiper>

...

methods:{
 slideChange() {},
}


Data Science with Python : Bag of Words Meets Bags of Popcorn

Description
Welcome to the 'DSWP' Team, good to see you here.
With this issue, the readers will know on how to work on sentiment analysis using Google's Word2Vec for movie reviews
Here is the dataset to follow : https://www.kaggle.com/c/word2vec-nlp-tutorial/data
To get assigned to this issue, add your serial numbers mentioned in the spreadsheet of "Data Science with Python", the approach one would follow and the choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
If you had referred any resources, add them up in "DS Resources". Similarly, if you had used datasets, include them in "DS Datasets".
Domain: Kaggle Competitions
Mentors Assigned : Gauri Bharadwaj | Ishika Kesarwani
Points to Note :
The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title" should be the same. Include issue number along with it.
Changes should be made inside the Datascience_With_Python/ directory & Datascience_With_Python branch.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'GWOC' contributors of 'DSWP' domain.
All the best. Enjoy your journey ahead. 😎
Domain
Data Science with Python
Type of Contribution
Audio, Video, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

I would like to work on this.
Soumik Samanta - 97
Type: Doccumentation
Approach: Describe what is google's word2vec, and  train a model using Word2Vec to show how to use the resulting word vectors for sentiment analysis.

Issue assigned to @soumiksamanta007 for documentation


Not able to find newRelicId from environment

I am trying to add NewRelic to my Node.js Application, but am unable to do it as you can see from logs.
I am running command - serverless deploy
Logs -
Serverless: Plugins: ["serverless-offline","serverless-newrelic-lambda-layers"]
Serverless: Adding NewRelic layer to slack
Serverless: No New Relic Account ID specified for "slack"; skipping.
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Installing dependencies for custom CloudFormation resources...
Serverless: No New Relic AWS Lambda integration found for this New Relic linked account and aws account.
Serverless: No New Relic Account ID specified; Cannot check for required NewRelicLambdaIntegrationRole.

serverless.yml -
custom:
newRelic:
accountId: ${env:NEWRELIC_ACCOUNT_ID}
apiKey: ${env:NEWRELIC_API_KEY}
enableExtension: true
enableFunctionLogs: true
enableIntegration: true
logEnabled: true
logLevel: debug

serverless app parameters -

@varora1406 This sounds like an issue related to how your serverless.yml is structured. Would you be able to share the entire (redacted) serverless.yml?


Fix runtime dependencies for Verilator

I have added the following required runtime dependiencies to Verilator: cxx, bison, flex and ncurses

These dependencies are copied from the uhdm-verilator package.
This resolves the issue with a constant number of new failures for Verilator in the PR comment job (e.g. here: https://github.com/SymbiFlow/sv-tests/pull/1368#issuecomment-787031986)
The issue is that the comparison uses a build with all the packages installed at once as the baseline (so we do get the compiler from a dependency from another package there) and compare that against jobs which only install individual packages (thus the lack of dependencies for Verilator)


game stuck at 73% loading with Bulwark's Haunt loaded (PlatformNotSupportedException)

LogOutput.log
disabling bulwark's fixes the issue, only started happening after the 1.0.3 patch

Are you on Windows?

I am, yes. Windows 10 home edition.


Timeout waiting for site

Thank you for taking time to open a new issue. Please answer a few questions to help us fix it faster. You can delete text that is irrelevant to the issue.
Is this a bug report or a feature request?
Could you be bug, but not sure
If this is a bug report, please provide as much info as possible

version: 1.14.0
platform: linux
expected behavior: wait for Angular app compilation to finish before checking target site
actual behavior: times out looking for the target site when Angular compilation is not yet done

I am using start-server-and-test in a fairly large Angular 12 app.  Things work nicely on my local environment with Mac os.  But when the ci pipeline runs in linux, I get a timeout error:
...
Compiling ng2-pdfjs-viewer : module as esm5
Compiling cdk-table-exporter : es2015 as esm2015
Error: Timed out waiting for: https://localhost:3000/app/login
    at /builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/lib/wait-on.js:132:31
    at doInnerSub (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:22:31)
    at outerNext (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:17:70)
    at OperatorSubscriber._this._next (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/OperatorSubscriber.js:28:21)
    at OperatorSubscriber.Subscriber.next (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/Subscriber.js:72:18)
    at AsyncAction.work (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/observable/timer.js:28:28)
    at AsyncAction._execute (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncAction.js:76:18)
    at AsyncAction.execute (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncAction.js:64:26)
    at AsyncScheduler.flush (/builds/vN1UpTSL/18/bdc/neo2.0/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncScheduler.js:39:33)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)

From the logs, Angular's ng serve is not yet done.  The site is not yet up.  Is there a way to delay the check of the target site to wait for the completion of ng serve?

Setting WAIT_ON_TIMEOUT worked for me:
    "test:dev:headless": "WAIT_ON_TIMEOUT=1200000 start-test 'npm run e2e' :4000 'npm run cypress:headless'"

Thanks. WAIT_ON_TIMEOUT worked for me.


dspace-api: allow overriding ImageMagick density (6.x)

Allow users to override ImageMagick's default density of 72 DPI for creating PDF thumbnails. In this case a density of 144 will perform a "2x" supersample, which greatly increases the quality of the resulting images at the expense of slightly longer execution time and higher memory usage.
References

6.x port of #8553
Fixes #8514

@alanorth : Just a quick note here.  I honestly don't know whether we'll have another 6.x release (it's likely dependent on whether a high priority bug or security issue arises or not prior to 6.x going EOL).  So, please don't feel like you need to backport your PRs to 6.x.  That said, if you want to do these backports to help others use your code that are still on 6.x, that's fine with me.

@tdonohue my thoughts exactly. I am going to use these in our DSpace 6.x repository anyways, so I thought I'd submit them here in case anyone wants them (even if we close this without merging).

DSpace 6 is out of support as of 2023-06-31. Closing this. Anyone who needs it can find and apply it themselves.


support python 3.11

Description

Checklist:

[ ] This PR has a meaningful title and a clear description.
[ ] The tests pass.
[ ] All linting tasks pass.
[ ] The notebooks are clean.

This was been added in #241


⚠ ClamAV has degraded performance

In 064715b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 576 ms

Resolved: ClamAV performance has improved in a59b2fa.


auto publish?

auto check the latest version, publish the built Appimage.

this works :)
on:
  # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
  schedule:
    # The shortest interval you can run scheduled workflows is once every 5 minutes.
    # Note: The schedule event can be delayed during periods of high loads of GitHub Actions workflow runs.
    # High load times include the start of every hour.
    # To decrease the chance of delay, schedule your workflow to run at a different time of the hour.
    # Every 5 minutes.
    # - cron: '*/5 * * * *'
    # At the beginning of every day.
    - cron: "0 0 * * *"

fixed


Moderation Bot

(If you're familiar with Discord moderation - tl;dr implement ub3rbot-log.)
It is useful to get updated whenever someone updates or deletes a message - it could have been updated to break the rules of a server, or temporary harassment could have been sent and then deleted to avoid the eyes of moderators. The usual solution for this is some kind of channel that keeps track of all updates and deletions (aka anything covered by the MessageChange feature) and writes a message to this channel whenever one happens detailing the change. A screenshot from ub3rbot (which provides this functionality) is given below).
For this, you'll likely want to hardcode a channel name which can be retrieved by the bot and then used as the target for all messages. (The MessageChange provides a Message, which contains details of the server the message was in, allowing you to search that server for a channel with the correct name.)

closing because out of scope


Make propagation timeout configurable

Is your feature request related to a problem? Please describe.
At our company we have a horribly configured DNS infrastructure that is out of our control to change that requires massively long propagation times for DNS updates. We have a need to be able to change the time that cert-manager waits before it checks if a domain has been propagated.
As far as I can see, this is not configurable and is hardcoded to 60 seconds here:
https://github.com/jetstack/cert-manager/blob/640e63f618e4553897d888038b779d8cf9c09c84/pkg/issuer/acme/dns/util/dns.go#L33
Describe the solution you'd like
Make this a configurable option through cli or environment variable.
Environment details (if applicable):

Kubernetes version (e.g. v1.10.2): 1.11.5
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): Pivotal Container Service
cert-manager version (e.g. v0.4.0): 0.6.0
Install method (e.g. helm or static manifests): Helm

/kind feature

The value you pointed out is the TTL value that we set for the record itself on the DNS server. After a DNS record has been added, we should be checking for it existing every 10s https://github.com/jetstack/cert-manager/blob/master/pkg/controller/acmechallenges/sync.go#L161
Are you timing out talking to the DNS server or do you just never see the record?

You are completely right, I made a mistake, sorry for the bollocks issue.


libc: Always declare getenv, link/symlink and atexit/on_exit

Summary
since many c++ library implementation reference these symbols by using ::xxx but never
really use them, the declaration avoid the unused code is pulled into the final binary
Impact
No, only the conditional guard is removed.
Testing

Should the CONFIGs be removed as well from their respective Kconfig files?

Should the CONFIGs be removed as well from their respective Kconfig files?

No, since these functions are still optional. This patch just fix the c++ library which blindly declare(using ::) functions but not really use them.


Chrisda to Master

Docs Build status updates of commit 2226894:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-HybridMailflow.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-HybridMailflowDatacenterIPs.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Import-RMSTrustedPublishingDomain.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


show/hide-RA-details

Author checklist

[ ] Include primary ticket number in title - e.g. "#123 New styling for widget" - and any additional tickets in description
[ ] Fill in the details below and delete as appropriate
[ ] Be proactive in getting your work approved 💪

What's included?
Details for reasonable adjustments are showing regardless of weather the RA field is true or false.
This was highlighted in tests for 283.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?

On an application review page, go to 'Change' under personal details;
Ensure there is text in the 'Reasonable Adjustments Details' section.
Select 'No' for 'Reasonable Adjustment'
Save and Continue
Any details entered should NOT show
Go to 'Change' under personal details;
Ensure there is text in the 'Reasonable Adjustments Details' section.
Select 'Yes' for 'Reasonable Adjustment'
Save and Continue
Any details entered SHOULD show

Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, notes etc.

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub the text still shows on Admin when clicked 'No' -

The code on this PR is working (only changes to apply)
If "Yes" show the information

If "No" doesn't show the reason for reasonable adjustment

@tomlovesgithub @joy-ade Perhaps a ticket should be created to fix the issue on Admin side?

@mbrookeswebdev there is already ticket 1329 on the Admin side to fix the issues.

On advice from Lee this can now be merged.


Screen Brightness  needs level "1"

To Reproduce
Steps to reproduce the behaviour:

inside pinecil  menu  is 1-10  dim to bright setting.
for some people, the "1"  might turn the display black/off (so dim they see nothing), but it's supposed to be low dim but still visible. "1" turning some screens off is a different issue for outlier OLED.
still need a  "1" :)

an issue could be opened  with IronOS to see if the energy levels can be tweaked up. if not maybe Ralim could talk to Pine Store about hardware tweak.

I also suggest since the  difference is so hard to see for the human eye to  have just 1-2-3-4-5 levels in IronOS.  where
1 = current 2  level, (since we have people where "1"  is black off screen)
2= current  4
3 = 6
4= 8
5= current 10 highest brightness.

if most people can not see a difference from 2-8  then why have all these levels?

see Video example of  1= bottom lowest dim, 5 = middle bright, 10 = brightest screen
https://user-images.githubusercontent.com/97197236/223456671-ca19d246-76c9-426a-b775-4e04f327941c.mov
Expected behaviour
off should show as  "1"  in  PineSAM  since there is no off setting  on the real Pinecil,  that would put a lot of people into a pickle where they will not see their screen.

Video of screen brightness
Bottom = 1 dim     middle = 5 medium bright   top = 10 brightest
https://user-images.githubusercontent.com/97197236/223472284-f03cbbbb-9bbd-4241-9845-92a6dd2e1125.mp4


Build CMDLET to add vCenter

Expected Behavior
In order to automate the deployment of Rubrik it would be ideal to have a CMDLET that can add vCenter.
Current Behavior
CMDLET exists to add physical hosts or NAS hosts

This will be resolved in #263

This was resolved in #263, closing issue and once again a big thanks goes out to our super star contributor @atscomposer !


Invalid equations in Modelica.Electrical.Analog.Basic.OpAmpDetailed

Reported by kurzbach on 30 Sep 2010 15:24 UTC
In Modelica.Electrical.Analog.Basic.OpAmpDetailed are the equations:
		   if initial() then
		      v_source = q_fp1;
		      x = 0;
		   end if;

This imo not conform to the specification, because initial() is not a parameter expression (3.8.2) and therefore there must be an else alternative with the same number of equations (8.3.4).

Migrated-From: https://trac.modelica.org/Modelica/ticket/421

Comment by otter on 5 Oct 2010 16:18 UTC
Fixed in 8ffb9dd9f55999d3595306c7f05cb044b546ac0d
The if-clause was removed and moved in an initial equation section:
initial equation
  v_source = q_fp1;
  x = 0;

Modified by otter on 6 Oct 2010 07:44 UTC

Modified by dietmarw on 6 Oct 2010 08:27 UTC


Adding course

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Why is this valuable (or not)
How do we know it's really free?
For book lists, is it a book?
Checklist:

[ ] Not a duplicate
[ ] Included author(s) if appropriate
[ ] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

maybe it's time to start a free-courses-it page?


Always pass 9 parameters to tparm()

Some implementations like NetBSD have a non-variadic prototype of
tparm() requiring 9 explicit parameters. Therefore always make sure to
pass 9 parameters. Since other implementations uses a variadic prototype
it will work on them as well.
Inspired by how this solved in the portable version of tmux.

It works, but gcc (nb2 20150115) 4.8.5 on NetBSD 7.1 complains again:
pick.c:315:4: error: passing argument 1 of 'tty_parm1' discards 'const' qualifier from pointer target type [-Werror]

so it should be tty_parm1(const char *, int) ... and please rename it to tty_parm ... :-)

so it should be tty_parm1(const char *, int)

Well that doesn't work on OpenBSD since:
char *tparm(char *, ...);

... and on NetBSD:
char *tparm(const char *, ...);

It's not pretty but the updated commit should work, please confirm.

Confirmed.

Thanks, merged.


All changes in input fields lost when you switch to another page

Describe the bug
Any inserted data or change that you made in Method, URL and .. will be lost  when you switch to another page
To Reproduce
Steps to reproduce the behavior:

Change URL input value to something like https://jsonplaceholder.typicode.com
Go to another page, for example, Click on 'Settings' (gear icon on the top-right corner)
Go back to the HTTP page again
see the URL input, it's value turn back to default https://reqres.in

This happens for all other changes
Expected behavior
When we go to another page the changes should remain

Yeah this bugs me out too.
A save as you type (to localStorage) feature might fix this.

He could use some help!🙌🏼

What's the status of this?

It's almost done


⚠ SceneTime has degraded performance

In dad9615, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2392 ms

Resolved: SceneTime performance has improved in f54291f after 36 minutes.


fix: replace innerHTML with textContent

innerHTML has been removed in the latest indexer HTML extraction engine.
I verified that the current index contents will look identical if innerHTML is replaced with textContent
For a verification of the culprit that recently occurred, compare:
https://admin.hlx.page/index/adobe/design-website/main/stories/our-people/hacks-hobbies-and-side-hustles-nitzan-klamer
(this is the version with innerHTML that no longer works)
https://admin.hlx.page/index/adobe/design-website/use-text-content/stories/our-people/hacks-hobbies-and-side-hustles-nitzan-klamer
(this is the version with textContent that works again and delivers the expected result)

Added back innerHTML so this PR can be ignored.


Include the logo(s) by reference to environment

This ended up being a bit of a pain, because I went the monad transformer route. The massive set of type changes doesn't look too scary once committed though - just required changing everything! This should now display the logo, and I'm going to put it up on http://concert-daw-staging-site.herokuapp.com for preview.

Wondering if the logo should be bigger, or the heading text smaller, since at the moment the headings are bigger, which looks a bit odd. But I think it might be right because ultimately they're what the page is about, you don't visit a site to see the logo.


Allow group message conversations to be used with non-SMS transports.

This used to be possible, but when conversations stopped honouring conv.delivery_class, group message was never updated.
We need to make delivery_class an option in the group message send message action (similar to how it is for dialogues) and then pass that option through to the management command.

Ready for review.

:+1:


Where can I find moco code?

https://gitee.com/facebookresearch/moco

https://gitee.com/facebookresearch/moco

Thanks a lot.


Using outdated version of Adjust

Facebook rejects apps that use Adjust SDK version below 4.16.0 saying "using an old version of the Adjust SDK, may result in Facebook user access tokens being sent to a third-party analytics provider... please update the Adjust SDK to version 4.16.0 or above".
The Segment integration is using 'Adjust', '~> 4.15'.
The current Adjust version is 4.17.2.

@aapaine should be resolved with the latest release: https://github.com/segment-integrations/analytics-ios-integration-adjust/releases/tag/1.1.5


[AutoPR consumption/resource-manager] Fix to existing pricesheet API swagger - introducing 'top' filter

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2485

Done in https://github.com/Azure/azure-sdk-for-python/pull/1977


[Bug]: Articles Pagination

Relevant scope
Backend specs
Description
Hi again , As explained in the docs , in order to use articles with pagination is to set the offset=0 to get the first page ,
now the problem is I have 13 articles which I can see in the api , I do " api.realworld.io/api/articles?offset=0  " and I get the first page, then for the second page I do " api.realworld.io/api/articles?offset=1 " but I will get the same result again , I should get that 3 articles in the second page but I'm not.
thank you in advance for answering my issue

offset is not the page number !!


jobTree/Mesos permissions problems

There is a mesosbox user that runs mesos, but it seems like when tasks are assigned they are trying to run as the default ubuntu, causing problems. Fixing this manually by running mesos as root shows an additional, related problem, where mesos gets permission denied when trying to access executor.py. Some quick searching shows that the user who runs tasks is determined by the executor file, so fixing the executor permissions should fix both problems.


Update flutter_neat_and_clean_calendar.dart

update event list when add event data.

I don't see, what the purpose of this change should be. As far as I understood you add some events to the list of events on a certain day, but they don't appear in the list on the screen immediately. If this is the case, I guess there is something wrong in your programs logic.
I updated the example in the new version 0.2.3+11 to illustrate how to immediately update the list view once you added new events. The only thing you have to do is to wrap the code pieces with setState(), that modify the event list.
Please check the example code and come back, if I misunderstood the purpose of your pull request.

The calendar is updated, but the selected event list does not change.

https://user-images.githubusercontent.com/144948/129874174-3eea03bf-4341-4b38-b38a-701efa49a7fb.mov
This video shows the latest version of the example code. Every click on the floating action button adds an additional event to the event list of today. In the same moment the view gets updated. This is all done with the current version of the package code (without your additions). You can see, that the list updates. The changes are on the example app code side only. Did you try the example?


Tukebil

In Ymesei Ezekiel's 1962 song "Tal Sosoak" he starts with:  Tal sosoak kekerei el tukebil.  Apparently tukebil is a variation on ekebil which might be a regional word (particular to Ngerchelong?).  Or it might be an old word no longer in use.  Felix Okabe thought that it might mean "one young lady out of a group of young ladies."  Is anyone familiar with this word?

Tukebil, a teenager, young woman.
On Mon, Apr 1, 2024 at 15:02 JimGeselbracht @.***>
wrote:

In Ymesei Ezekiel's 1962 song "Tal Sosoak" he starts with: Tal sosoak
kekerei el tukebil. Apparently tukebil is a variation on ekebil which might
be a regional word (particular to Ngerchelong?). Or it might be an old word
no longer in use. Felix Okabe thought that it might mean "one young lady
out of a group of young ladies." Is anyone familiar with this word?
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/487, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJGEPELGVSPHXS2RTH3Y3HKRFAVCNFSM6AAAAABFSIQ5T2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTSMJVGEYTKOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks Mar - so is there a difference between ekebil and tukebil?
On Monday, April 1, 2024 at 05:17:27 PM PDT, Gnalu @.***> wrote:
Tukebil, a teenager, young woman.
On Mon, Apr 1, 2024 at 15:02 JimGeselbracht @.***>
wrote:

In Ymesei Ezekiel's 1962 song "Tal Sosoak" he starts with: Tal sosoak
kekerei el tukebil. Apparently tukebil is a variation on ekebil which might
be a regional word (particular to Ngerchelong?). Or it might be an old word
no longer in use. Felix Okabe thought that it might mean "one young lady
out of a group of young ladies." Is anyone familiar with this word?
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/487, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJGEPELGVSPHXS2RTH3Y3HKRFAVCNFSM6AAAAABFSIQ5T2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTSMJVGEYTKOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Allow the specification of bulkLoadTime filters

WHERE creationDate < :bulkLoadTime
  AND deletionDate >= :bulkLoadTime;

works now


Support for iframe capture

Please make sure you are testing with the latest release of html2canvas.
Old versions are not supported and issues reported for them will be closed.
Please follow the general troubleshooting steps first:

[x] You are using the latest version
[x] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:
i use html2canvas in iframe, but i get a blank page finally, jsfiddle code as follow:
https://jsfiddle.net/joejoe489/8qtd3vgs/14/
Specifications:

html2canvas version tested with:
Browser & version:
Operating system:

is there any plan to support iframe capture in the same origin?

It's definitely supported. Try setting a height and width on the iframe.

Iframe element must set width and height through attributes. eg:
<iframe src="./child.html" width="400" height="400"></iframe>
Because html2canvas iframe clone initialize by iframe.width and iframe.height
https://github.com/niklasvh/html2canvas/blob/6020386bbeed60ad68e675fdcaa6220e292fd35a/src/dom/replaced-elements/iframe-element-container.ts#L13-L17


Android 11 ENS requirements

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

description
According to Google, ENS does no longer require location services to be active in order to work, starting from Android 11 [1]. Thus, the CWA should not send a notification to Android 11 users when location services are deactivated. I have verified that the notification appears on a phone running Android 11, but still exposure logging seems to work fine (CWA indicates this).
I'm currently quite busy but can take care of this myself, probably next week. As Android 11 is not yet officially published and the app's core functionality is most likely not affected, I'd say this is not time critical for now.
[1] https://blog.google/inside-google/company-announcements/update-exposure-notifications/

Internal Tracking ID: EXPOSUREAPP-2050

@GPclips @JoachimFritsch Does the assignment and transfer to JIRA indicate, that you'll take care of it internally or shall I work on it?

Hello @duchampdev,
we added this to our internal JIRA and informed, as well as assigned the bug, to our dev team.
We will start working on it as soon as possible.
Thanks for asking,
LMM
Corona-Warn-App Open Source Team

Just to confirm that as expected, the issue as described by @duchampdev for Android 11 Beta is also still applicable to the final version of Android 11 (tested on Pixel 2) and the current CWA version (1.3.1).

I just realized that this has been resolved in the meantime: https://github.com/corona-warn-app/cwa-app-android/pull/1057

The onboarding screen on a clean install on Android 11 still shows a card that location services need to be activated ("Standortverwendung erlauben"). This card should not be displayed on Android 11:

@duchampdev @MikeJayDee I think we should either
a) reopen this issue, to signify that it's not resolved
or
b) move the problem @MikeJayDee discovered into a new separate issue.
What do you think?

@svengabr

@MikeJayDee @svengabr @duchampdev
The provided text has a lack of information. Showing ([...]until Android 11) or not showing the Card would be better (but here are edgecases for different Beta-Versions of Android 11 when to show the card and when not).
I reported this UI issue and there will probably be a better in-app information flow in the future.
Thanks for reporting!
As this issue doesn't effect the core function (locationless scanning under Android 11) issue stays closed.


Benchmarks multi stage

Benchmarks are added for:

Multi-stage with switching the material for a UMAT and halving the stiffness under sinus load
Multi-stage with a pulse and switching from dynamic to static after the oscillations are dissipated

Local vs Remote results differ. Maybe something related to version of gmsh or something like that?

@aronnoordam  should be okay now!


MINOR: Actually run the delete topic command in kafka.py

This was missed in #7621

Confirmed topics get deleted in this test run https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3612/


elasticsearch v5.6.9 FilteredQueryBuilder is deprecated

package com.impetus.client.es.index
class ESIndexer
can't import FilteredQueryBuilder

@jackyang1984 What exactly are you trying, please share more details.
Also check -https://github.com/Impetus/Kundera/wiki/Kundera-with-Elasticsearch

@devender-yadav
    <dependency>
        <groupId>com.impetus.kundera.client</groupId>
        <artifactId>kundera-hbase-v2</artifactId>
        <version>3.12</version>
    </dependency>
    <dependency>
        <groupId>com.impetus.kundera.client</groupId>
        <artifactId>kundera-elastic-search</artifactId>
        <version>3.12</version>
    </dependency>

@devender-yadav
class package com.impetus.client.es.ESClientFactory
line 118: Builder builder = Settings.settingsBuilder();
line 129: TransportClient.builder()
didn't work
Caused by: java.lang.NoSuchMethodError: org.elasticsearch.common.settings.Settings.settingsBuilder()Lorg/elasticsearch/common/settings/Settings$Builder;
at com.impetus.client.es.ESClientFactory.createPoolOrConnection(ESClientFactory.java:118) ~[kundera-elastic-search-3.12.jar!/:na]

@jackyang1984  are you adding any dependency for elasticsearch transport client externally?
Kundera is using
        <dependency>
		<groupId>org.elasticsearch</groupId>
		<artifactId>elasticsearch</artifactId>
		<version>2.3.3</version>
	</dependency>

There may be a newer version of this dependency in your POM


examples fail to run correctly

Hi,
The three sample apps in ./examples don't seem to be working for me under nvm/node(v0.4.12) with dependencies installed as local or global, client throws the following error:
Uncaught Error: Cannot find module 'dnode'
Is this a known issue? Anyone know of a fix before I look too deeply?

Are you seeing this on the server or the browser?

In the browser with all three example apps.


Why not to support both ESM and CommonJS?

Hi! Thanks for your awesome work regarding modern-errors, but I have a one problem with this library. It just doesn't work without ESM completely. I've seen this issue https://github.com/ehmicky/modern-errors/issues/3 and I get your points, but I wonder why it's not possible for a library to support temporarily both CommonJS and ESM. I would love to use this library in my project, but due to it's dependencies it's impossible to migrate towards pure ESM setup. I tried it, but I encounter like infinite flow of bugs in deps.

Here is a screenshot from another library that just handles it well.

Hi @stepaniukm,
Thanks for your feedback. However, as you mentioned, this is a duplicate of #3, so the answer to your question is described in that other thread. In particular, this comment and the section called "Double packaging" explains the main problem being providing support for both ESM and CommonJS, but other parts of the thread provide with some additional points.

Oh f.. I kinda scrolled through and didn't notice your comment about double packaging. Thanks for your answer.


WIP(datepicker): use selection model to eventually support selecting date ranges

This is a work in progress PR created so @mmalerba can review and provide feedback.

@SaturnTeam So I'm realizing now that this is turning out to be a lot more complicated than I originally expected. Not only is there a difference in behavior between the user updating the value and the value being updated programmatically, but there's even differences between what we need to do when the user updates the value via the input vs when they update it via the calendar. (When they update it via the calendar we want to overwrite the displayed text in the input, but not when they type in the input).
I think I need to dedicate some more time to thinking about all of the cases and trying to come up with a better solution. I don't have time to do that right now, so I think the best thing to do for now is to keep your date range picker separate until I can dedicate more time to figuring out how to best abstract the date vs range selection. Once I've done that we can revisit porting your UI changes back into Angular Material. My apologies, I didn't realize how complicated this would be until we started.

You can use amazing time picker (amazing-time-picker) for this purpose, and it is fully compatible with Angular 2-7 and Material design:
https://github.com/owsolutions/amazing-time-picker
Live demo:
https://owsolutions.github.io/amazing-time-picker
Thanks.

This change has been made as part of the date range picker work and will be going out with v10


Tamagui starter crashes with trpc ssr enabled

Describe the bug
I created a new project using the starter:
npm create tamagui-app@latest

I then implemented nextjs trpc following the following trpc docs: https://trpc.io/docs/v10/nextjs
Setting ssr: true in the trpc config will result in the following error:
TypeError: dispatcher.useInsertionEffect is not a function

To Reproduce
I've created a repo that can reproduce this error:

clone https://github.com/hlynurstef/tamagui-trpc
cd tamagui-trpc
yarn
yarn web
Notice that everything runs fine
set ssr: true in https://github.com/hlynurstef/tamagui-trpc/blob/main/packages/trpc-client/src/client.ts
Notice the error

System Info (please complete the following information):
Output of npx envinfo --system --npmPackages --binaries --browsers
  System:
    OS: macOS 12.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 1.02 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 3.2.3 - ~/.yarn/bin/yarn
    npm: 8.3.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 105.0.5195.125
    Safari: 15.3
  npmPackages:
    @babel/runtime: ^7.18.9 => 7.18.9
    @manypkg/cli: ^0.19.1 => 0.19.1
    @types/react: ^18.0.15 => 17.0.21
    @types/react-native: ^0.69.5 => 0.69.5
    eslint: ^8.21.0 => 8.21.0
    prettier: ^2.7.1 => 2.7.1
    turbo: ^1.4.2 => 1.4.2
    typescript: ^4.7.4 => 4.7.4

Tamagui info
Paste all the following below:

[x] yarn.lock or similar https://github.com/hlynurstef/tamagui-trpc/blob/main/yarn.lock
[ ] If it's a specific file, add //! debug to the top (the ! works in esbuild compiled packages but not necessary always) and include that (only for compiler, but helps to know if it's on or off).
[ ] Run your server/bundler with DEBUG=tamagui and include that output at the bottom.

This almost always is due to duplicate react / react-dom, but you do have resolutions set... looked into what they are doing with ssr and it seems just adds react-ssr-prepass.

Can you check that this react has useInsertionEffect? There's got to be some sort of duplicate react getting in there.

Tried a few things with no luck, not sure what's going on here, something with react-ssr-prepass likely.

I think I solved this issue!
I've submitted a PR to tRPC (trpc/trpc#3343).
Basically, react-ssr-prepass hasn't been updated in nearly a year and uses react-dom-17.0.2 instead of 18, and I think that was causing compatibility issues. I've patched tRPC to use React's renderToPipeableStream function instead.
SSR in Tamagui works fine for me now with this fix.
Hopefully they accept the changes. 🤞

Update - the PR didn't make it because it because it would break tRPC compatability with React 16 and 17. Potentially it could make it into the next version of tRPC (11). In the meantime, I'm just using tRPC's SSG helpers workaround and setting ssr: false. You still get SSR, it just requires a little bit of duplication in your code.

Closing as it seems to work


Simplify the SendService trait

The Service and into_service associated items aren’t necessary, since they can just exist as supertraits on SendService.

@programatik29 Can you review this?

I will consider this when or if I plan a new update. This crate might be ported to hyper-util in the future. Then I would continue development of this crate there.

I will consider this when or if I plan a new update. This crate might be ported to hyper-util in the future. Then I would continue development of this crate there.

Would you let us show some love by enabling github sponsors on this repo to get it actively maintained?


Start from hit circle center when hitTolerance is configured

When configuring a hitTolerance for Map#getFeaturesAtPixel() and friends, the user experience is somewhat strange. The reason is that hits on the hit canvas are checked starting from the top-left corner of the hit canvas. The user experience can be fixed by starting from the center of the hit canvas.

It would make sense to cache the indexes in the required order like this:
https://github.com/MoonE/openlayers/tree/hitdetect-indexes
Instead of iterating over the two-dimensional boolean array for each hit detection, the indexes can be stored in an array in the order they should be checked.
I more or less copied your changes to the getCircleArray function, so the end result should be the same.

The order in which pixels are checked is not quite correct.
It starts at the center pixel, but then checks complete lines, though it should kind of spiral outwards instead.
This is the order in which pixels would be checked with a tolerance of 3:
[
  [3,3],
  [3,2],
  [3,4],
  [3,1],
  [3,5],
  [2,3],
  [2,2],
  [2,4],
  [4,3],
  [4,2],
  [4,4],
  [1,3],
  [5,3]
]

What I also noticed is that the circle array always seems to have a 1px border (unrelated to this change)
e. g. with zero tolerance it checks the center of a 1x1 array, with 1 it checks only the center pixel of a 3x3 array.

Thanks @MoonE! Can you please create a pull request from your hitdetect-indexes branch to replace my pull request?


Fixed the logic in zoom limits and merged master to this branch

Everything looks good, and tests are successful: https://developer.cloud.unity3d.com/build/orgs/jiilaitala/projects/3dmaps/buildtargets/staging-android/builds/12/log


Removes dependency on the homebrew cookbook and sets chef_version to ~> 12

The homebrew_package resource has been included in Chef since v12.0.
This change allows compatibility with v3 of the homebrew cookbook.
This explicitly requires Chef 12. I'm not sure if Chef 11 or older were supported by this cookbook.

The build failure was just style stuff that is fixed by #2. Still considering whether to update the homebrew dep vs drop it. While the homebrew_package resource does live in core Chef now, it looks like it'll just error out if Homebrew's not installed--you'd still need the cookbook for that piece.

Yes indeed. Maybe the homebrew dependency should be changed to ">= 2.1, < 4.0" or something like that. That would mean that nothing of the functionality would have to change but a more recent homebrew cookbook version is supported. The < 4.0 might be left out, but I prefer to be a bit more pessimistic about depency locking. :)

An 0.2.0 has been released with the dependency broadened to homebrew < 4. A corresponding update for the mac-app-store cookbook is in the works.

Thanks! 👌


For OutputReporter, attempting to edit output_paths causes crash.

OpenSim-4.0.Beta_121517_Mac
Steps to reproduce

Open arm26.osim
Raise shoulder coordinate.
Tools > Forward Dynamics... > Analyses. Add OutputReporter.
Edit the OutputReporter.
Click output_paths field.
GUI crashes.

I've attached a crash log.
OpenSim4.0MacOutputReporterCrash.txt

I am assigned to this, but the crash is occurring when selecting the OutputReporter analysis to edit as @chrisdembia reported. When i provide an OutputReporter in the AnalyzeTool setup file subject01_Setup_Analyze.xml, it appears and clicking edit does not crash it (immediately at least).

Attempting to populate the list (+) eventually crashes it.

Loading Tug_of_War_Setup_Analyze.xml in the GUI (build: OpenSim-dd7dc47b-2018-02-11 for Windows) runs and produces results that are the same (but not identical) to testAnalyzeTool (locally but different build of core).
However clicking on the Analyses tab yield the red warning icon with this message:
	at org.opensim.tracking.AbstractToolModel.getAnalysisSet(AbstractToolModel.java:96)
	at org.opensim.tracking.AnalysisSetTableModel.getRowCount(AnalysisSetPanel.java:74)
	at javax.swing.JTable.getRowCount(JTable.java:2662)
	at javax.swing.plaf.basic.BasicTableUI.createTableSize(BasicTableUI.java:1692)
	at javax.swing.plaf.basic.BasicTableUI.getPreferredSize(BasicTableUI.java:1733)
	at javax.swing.JComponent.getPreferredSize(JComponent.java:1662)
	at javax.swing.ScrollPaneLayout.layoutContainer(ScrollPaneLayout.java:791)
	at java.awt.Container.layout(Container.java:1511)
	at java.awt.Container.doLayout(Container.java:1500)
	at java.awt.Container.validateTree(Container.java:1696)
	at java.awt.Container.validateTree(Container.java:1705)
	at java.awt.Container.validateTree(Container.java:1705)
	at java.awt.Container.validate(Container.java:1631)
	at javax.swing.plaf.basic.BasicTabbedPaneUI.ensureCurrentLayout(BasicTabbedPaneUI.java:1447)
	at javax.swing.plaf.basic.BasicTabbedPaneUI.getTabBounds(BasicTabbedPaneUI.java:1467)
	at com.sun.java.swing.plaf.windows.WindowsTabbedPaneUI.setRolloverTab(WindowsTabbedPaneUI.java:104)
	at javax.swing.plaf.basic.BasicTabbedPaneUI$TabbedPaneLayout.layoutContainer(BasicTabbedPaneUI.java:2400)
	at java.awt.Container.layout(Container.java:1511)
	at java.awt.Container.doLayout(Container.java:1500)
	at java.awt.Container.validateTree(Container.java:1696)
	at java.awt.Container.validate(Container.java:1631)
	at javax.swing.plaf.basic.BasicTabbedPaneUI.ensureCurrentLayout(BasicTabbedPaneUI.java:1447)
	at javax.swing.plaf.basic.BasicTabbedPaneUI.getTabBounds(BasicTabbedPaneUI.java:1467)
	at com.sun.java.swing.plaf.windows.WindowsTabbedPaneUI.setRolloverTab(WindowsTabbedPaneUI.java:107)
	at javax.swing.plaf.basic.BasicTabbedPaneUI.setRolloverTab(BasicTabbedPaneUI.java:575)
	at javax.swing.plaf.basic.BasicTabbedPaneUI.access$2100(BasicTabbedPaneUI.java:54)
	at javax.swing.plaf.basic.BasicTabbedPaneUI$Handler.mouseMoved(BasicTabbedPaneUI.java:3664)
	at java.awt.Component.processMouseMotionEvent(Component.java:6578)
	at javax.swing.JComponent.processMouseMotionEvent(JComponent.java:3342)
	at java.awt.Component.processEvent(Component.java:6302)
	at java.awt.Container.processEvent(Container.java:2237)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2295)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4889)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4539)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4467)
	at java.awt.Container.dispatchEventImpl(Container.java:2281)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:159)
[catch] at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Closing and reopening the AnalyzeTool gets the warning to stop appearing. I can then access the Analyses tab and attempt to edit the OutputReporter, up on which the GUI crashes.

@aseth1 can you clarify if you load a setup file with populated OutputReporter, whether that works and produces expected output or not? Just to make sure that if the editing issue is fixed then we're not stuck with another issue downstream. Thanks

@aymanhab Yes, loading and running Tug_of_War_Setup_Analyze.xml in the GUI produces the expected results (not identical but very close) compared to the standard in core.

Fix on branch PR #530 pending successful build

@aymanhab this bug is "fixed" because it no longer crashes the GUI, but editing is still confusing. One must click + then double-click output_paths to see the added text field. I suspect most users will click on the down arrow (triangle) icon to expand the list. Can you make it that if you hit (+) you automatically jump to the newly added text field? For the longest while i thought nothing was happening then noticed there were in fact spaces in the list. When I finally double-clicked on output_paths there were several blank entries in the expanded list.

OK it still crashes the GUI, just a bit more delayed. After editing as describe above, I hit Cancel and it crashed. Here is the log crash_report_18-02-25_1535.txt.

For the longest while i thought nothing was happening then noticed there were in fact spaces in the list. When I finally double-clicked on output_paths there were several blank entries in the expanded list.

I had the same experience with the Kinematics analysis.

Crash cancelling out analysis edit should be made into own issue and not be confused with any other random and likely unrelated crashes.

What if it's the same issue 😮

Confirmed that this appears to be working on recent Windows build


fix: let props_to_labels take properties from log line

align level label to those used in node.js pino-loki client https://github.com/Julien-R44/pino-loki
fix props_to_labels
feat: support customizing logger_tag and level_tag labels sent to loki

[x] validate with function-logger-py

@claudiu-muresan-pfa sorry, I completely changed the PR and moved the actual alignment of level loki label to https://github.com/waylayio/function-logger-py/pull/9


google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials.

Description of the bug:
when use low google-auth package will raise this problem

Actual vs expected behavior:
No response
Any other information you'd like to share?
No response

The inability to automatically apply credentials is often related to the security and access control mechanisms implemented by Google Cloud services. Google Cloud expects applications to use authentication mechanisms to ensure secure and authorized access to its services. The two main reasons why automatic credential detection might fail are:
Security and Authorization:
Google Cloud services require proper authentication to ensure that only authorized users or applications can access sensitive resources.
Automatically applying credentials without user or application consent could compromise security.
Service Account and Key File Requirement:
Google Cloud typically uses service accounts and JSON key files for authentication. These key files contain sensitive information and must be managed securely.
To ensure secure access, users or applications need to provide the location of the JSON key file explicitly or set the GOOGLE_APPLICATION_CREDENTIALS environment variable to point to the file.
By requiring explicit specification of credentials, Google Cloud ensures that:
Users or applications explicitly grant consent for accessing resources.
Sensitive information (such as the service account key file) is securely managed and not accidentally exposed.
This approach aligns with best practices for secure authentication and access control.
In summary, the need for explicit credential specification is a security measure, and it ensures that users or applications follow secure practices when interacting with Google Cloud services.

@yihong0618, could you provide a repro for this issue? As @reconsumeralization points out, we will need to see that you have the relevant env vars set to rule out a bad environment.
I can see in #115 you have suggested downgrading google-auth to an older version - that's potentially a harmful change, and not sustainable long-term. With a repro we can either help you identify if there is an issue is in your setup, or find the right place to fix the issue (e.g. in the auth library).

@yihong0618, could you provide a repro for this issue? As @reconsumeralization points out, we will need to see that you have the relevant env vars set to rule out a bad environment.
I can see in #115 you have suggested downgrading google-auth to an older version - that's potentially a harmful change, and not sustainable long-term. With a repro we can either help you identify if there is an issue is in your setup, or find the right place to fix the issue (e.g. in the auth library).

sorry its not download its update, google-auth version.
if you had installed older google-auth version you may have this issue.
Will I need to update the google-auth version to the latest in my PR?

sorry its not download its update google-auth version. if you had installed older google-auth version before you may have this issue.

Ah interesting - can you explain what the issue is then? Ideally with a repro. As @reconsumeralization pointed out, the error in the original report can be expected in some cases, so it would help us to understand what is actually wrong.

Will I need to update the google-auth version to the latest in my PR?

This is what we want to avoid, but using a >= constraint would be OK. To approve the PR we need to understand why though.
I've tried to repro your issue but I can't:
$ virtualenv ...
$ pip install 'google-auth==2.25.1' google-generativeai
$ python
Python 3.9.12 (main, Jun  2 2023, 07:29:00)
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.generativeai as genai
>>> pro = genai.GenerativeModel('models/gemini-pro')
>>> pro.generate_content('the opposite of hot is').text
'cold'

@markmcd
you can repro by using python -m pip install  google-auth==2.0
I fixed the version 2.25 caused seems its not conflict and OK for the repo
repro:

I still can't reproduce, tried with python 3.9 and 3.11 (as you are using):
$ pip freeze |grep google
google-ai-generativelanguage==0.4.0
google-api-core==1.34.0
google-auth==2.0.0
google-generativeai==0.3.2
googleapis-common-protos==1.62.0

$ python
Python 3.11.6 (main, Oct  8 2023, 05:06:43) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.generativeai as genai
>>> genai.configure(api_key="...")
>>> pro = genai.GenerativeModel('models/gemini-pro')
>>> (r := pro.generate_content('the opposite of hot is')).text
'cold'

Are you using a clean environment? e.g. an empty venv?

sorry will using a venv test and let you know later.

@markmcd
can you reproduce as this
python -m venv venv
source venv/bin/activate

cat t.txt
# output
google-ai-generativelanguage==0.4.0
google-api-core==1.34.0
google-auth==2.0.0
google-generativeai==0.3.2
googleapis-common-protos==1.59.1

pip install -r t.txt
import google.generativeai as genai
from os import environ

genai.configure(api_key=environ.get("GOOGLE_API_KEY"))
pro = genai.GenerativeModel('models/gemini-pro')

print(pro.generate_content('the opposite of hot is').text)

python test.py

Ah - I believe it's working for me because I still have credentials available (i.e. I've run gcloud auth). When I remove $HOME/.config/gcloud/application_default_credentials.json I can repro.
I think I've found the issue - this commit added API key auth support to google-auth. That commit was shipped in 2.15.0, so I think you can set that as the lower bound and we should be good.
For context, the auth lib expects some credentials to be present, but versions older than 2.15.0 don't recognise API keys as credentials, so you got that error (and I did not, because I had other supported credentials present).

Ah thanks for the explain and the commit link its very interesting and learned something from it.
and if this PR can continue can we just set google-auth>= 2.15.0
or we can do some other things and I can close that

@markmcd just found you continue commit, thanks a lot.
its fun and kind to contribute this repo, thanks again.

Thanks for the report and your patience!

Ah thanks for the explain and the commit link its very interesting and learned something from it. and if this PR can continue can we just set google-auth>= 2.15.0 or we can do some other things and I can close that

Sorry for not getting back to you sooner.
I couldn't repro it, I'm sorry.


Update test to cover source and dist files both

Codecov Report

Merging #12 (714d7e7) into main (cde8a70) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         3    +1
  Lines           54       105   +51
  Branches        11        25   +14
=========================================
+ Hits            54       105   +51

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

dist/index.js
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde8a70...714d7e7. Read the comment docs.