Cucumber: If request that includes a granularTo constraint results in double entries for both then and else

Bug Report
An if request was run that included a granularTo. It was expecting that all values would meet the if > then statement so only one set of data would be emitted; however data is emitted for both the if > then and if > else statements.

Scenario: Running an if request that contains a non contradictory granularTo constraint within its if statement should be successful
Given the following fields exist:
| foo |
| bar |
And foo is in set:
| 10 |
| 20 |
| 30 |
| 40 |
And foo is anything but null
And bar is in set:
| 1    |
| 22   |
| 333  |
| 4444 |
And bar is anything but null
And there is a constraint:
"""
{
"if": { "field": "foo", "is": "granularTo", "value": 1 },
"then": { "field": "bar", "is": "equalTo", "value": 1 },
"else": { "field": "bar", "is": "equalTo", "value": 333 }
}
"""
Then the following data should be generated:
| foo | bar |
| 10  | 1   |
| 20  | 1   |
| 30  | 1   |
| 40  | 1   |

Steps to Reproduce:

Run the above test (or the if.Feature file)
See that scenario Running an if request that contains a non contradictory granularTo constraint within its if statement should be successful fails
Look at error message to see duplicate entries are created for both the then and else conditions.

Expected Result:
Data is emitted only for the then condition as all entries meet the granularTo 1
[10, 1], [20, 1], [30, 1], [40, 1]
Actual Result:
.Data for both the then and else conditions are created and the test fails as per the below error message:

java.lang.AssertionError:
Expected: [10, 1], [20, 1], [30, 1], [40, 1]
but: [20, 1], [40, 1], [10, 1], [30, 1], [20, 333], [40, 333], [10, 333], [30, 333]
missing:
counts: expected 4, but got 8
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at com.scottlogic.deg.generator.cucumber.steps.GeneralTestStep.theFollowingDataShouldBeGenerated(GeneralTestStep.java:105)
at ✽.the following data should be generated:(C:/DataGenerator/data-engineering-generator/generator/src/test/java/com/scottlogic/deg/generator/cucumber/If.feature:2715)

Environment:
IntelliJ running ifTestsUpdated branch with full generation / exhaustive combination.
Additional Context:
Test set to @ignore

Seen when using granularTo in the then statement:

Scenario: Running an if request that contains a non contradictory granularTo constraint within its then statement should be successful
Given the following fields exist:
| foo |
| bar |
And foo is in set:
| 1     |
| 1.1   |
| 1.11  |
| 1.111 |
And foo is anything but null
And bar is in set:
| 1     |
| 2.2   |
| 3.33  |
| 4.444 |
And bar is anything but null
And there is a constraint:
"""
{
"if": { "field": "foo", "is": "equalTo", "value": 1 },
"then": { "field": "bar", "is": "granularTo", "value": 0.1 },
"else": { "field": "bar", "is": "equalTo", "value": 3.33 }
}
"""
Then the following data should be generated:
| foo   | bar  |
| 1     | 2.2  |
| 1.1   | 3.33 |
| 1.11  | 3.33 |
| 1.111 | 3.33 |

Error:

java.lang.AssertionError:
Expected: [1, 1], [1.1, 2.2], [1.11, 2.2], [1.111, 2.2]
but: [1, 1], [1.11, 1], [1.1, 1], [1.111, 1], [1, 2.2], [1.11, 2.2], [1.1, 2.2], [1.111, 2.2]
missing:
counts: expected 4, but got 8
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at com.scottlogic.deg.generator.cucumber.steps.GeneralTestStep.theFollowingDataShouldBeGenerated(GeneralTestStep.java:105)
at ✽.the following data should be generated:(C:/DataGenerator/data-engineering-generator/generator/src/test/java/com/scottlogic/deg/generator/cucumber/If.feature:2716

)

Seen when using granularTo in the else statement:

Scenario: Running an if request that contains a non contradictory granularTo constraint within its else statement should be successful
Given the following fields exist:
| foo |
| bar |
And foo is in set:
| 1     |
| 1.1   |
| 1.11  |
| 1.111 |
And foo is anything but null
And bar is in set:
| 1     |
| 2.2   |
| 3.33  |
| 4.444 |
And bar is anything but null
And there is a constraint:
"""
{
"if": { "field": "foo", "is": "equalTo", "value": 1 },
"then": { "field": "bar", "is": "equalTo", "value": 1 },
"else": { "field": "bar", "is": "granularTo", "value": 0.01 }
}
"""
Then the following data should be generated:
| foo   | bar  |
| 1     | 1    |
| 1.1   | 3.33 |
| 1.11  | 3.33 |
| 1.111 | 3.33 |

The error:

java.lang.AssertionError:
Expected: [1, 1], [1.1, 3.33], [1.11, 3.33], [1.111, 3.33]
but: [1, 1], [1.11, 1], [1.1, 1], [1.111, 1], [1.11, 3.33], [1.1, 3.33], [1.111, 3.33], [1.11, 4.444], [1.1, 4.444], [1.111, 4.444], [1.11, 2.2], [1.1, 2.2], [1.111, 2.2]
missing:
counts: expected 4, but got 13
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at com.scottlogic.deg.generator.cucumber.steps.GeneralTestStep.theFollowingDataShouldBeGenerated(GeneralTestStep.java:105)
at ✽.the following data should be generated:(C:/DataGenerator/data-engineering-generator/generator/src/test/java/com/scottlogic/deg/generator/cucumber/If.feature:2748)

@sl-slaing  to review expected behaviour of granular to with stakeholders:

Should you be able to use granularTo with a set?
Should you be able to use granularTo in an if condition
Should you be able to use granularTo with > 1 values

Review with @SL-Mark
??? Should you be able to express granularTo with values greater than 1
Also begs the question, should you be able to express other granularTo values that are NOT a power of 10, e.g. 0.25.
e.g.
foo not isNull
foo is numeric
foo greaterThanOrEqual 5
foo lessThanOrEqual 25
foo granularTo 5

foo

5

10

15

20

25

and (odd numbers only)
bar not isNull
bar is numeric
bar greaterThanOrEqual 2
bar lessThanOrEqual 10
bar granularTo 2

bar

2

4

6

8

10

and non-power of ten granularities
aaa not isNull
aaa is numeric
aaa greaterThanOrEqual 2
aaa lessThanOrEqual 3
aaa granularTo 0.25

aaa

2

2.25

2.5

2.75

3

How would merging two granularTo constraints be resolved
e.g.
foo granularTo 0.25
and
foo granularTo 0.33

might result in
foo granularTo 0.???

Where ??? is either the larger, smaller or divisible component of both

Re the last comment, I think ??? would be 8.25 (afaik the smallest value that is divisible by both 0.25 and 0.33).

This appears to be fixed.
but some of the cucumber scenarios are not correct so will need to be updated anyway

I've unignored some of the tests which now pass (when updated to use granularTo correctly).
One does still fail though.

Covered by #881


No way to detect an empty std::function?

The following code throws an error of "bad function call" because an empty std::function does not resolve to nil.
sol::state lua;
std::function<void()> foo = nullptr;
sol::function bar;

lua["Foo"] = foo;
lua["Bar"] = bar;

auto result = lua.script(R"SCR(
	if Bar ~= nil
	then
		Bar()
	end

	if Foo ~= nil or type(Foo) ~= 'function'
	then
		Foo()
	end
	)SCR");

Is there any way within Lua to check if an std::function is empty? I haven't figured one out as of yet. For now I've converted all std::function<> objects to sol::function objects, but I don't consider this a valid solution for all cases moving forward.

No, there's not. nullptr std::function's feel like a code smell but as long as I can do if (foo) to check if it's valid I'll just serialize nil instead of a dead function object, I guess.
Man, C++ makes me sad sometimes...


Cannot use v-for with multi-step steps

Reproduction
https://formkit.link/d6338e5efe22e9e4c46553eb475cdec0
Describe the bug
Using v-for to create a dynamic number of steps in a multi-step results in the following error:
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'label')
at index.mjs:635:33
at Array.map ()
at createSSRStepsFromTabs (index.mjs:632:34)
Looking at the debugger, the tab props are null, and the actual steps are listed in its children property.
Note - the reproduction link has the appropriate code but doesn't render properly. Same issue as on the marketing site demos.
Environment
Nuxt 3.x (SSR)

This will be fixed in beta.18
https://formkit.link/dfe585f9e95e71329df90c0652696dd4


fix(ui): otw update edge cases

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 12 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 23.995%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ZwaveClient.ts
0
12
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
3790

Relevant Lines:
16687

💛  - Coveralls


Demo not showing up in Safari 13/14 because webkit doesn't fully implement esm export spec

Unexpected identifier 'as'. Expected 'from' before exported module name because webkit still can't understand reexport export { default as bla } from "./bla.js";
https://github.com/tc39/proposal-export-default-from#common-concerns
Track status: https://caniuse.com/mdn-javascript_statements_export_namespace

Looks like Safari 14.1 finally got its act together.


403 Client Error: Forbidden for url

personal information has been replaced
(orionsdk) [user@linux-user orionsdk]$ cat otest.py
import orionsdk

swis = orionsdk.SwisClient("SolarWinds-Orion", "user", "password", verify="server.pem")
swis.query("SELECT NodeID from Orion.Nodes")

(orionsdk) [user@linux-user orionsdk]$ python otest.py
/home/user/orionsdk/lib/python2.7/site-packages/urllib3/connection.py:362: SubjectAltNameWarning: Certificate for solarwinds-orion has no `subjectAltName`, falling back to check for a `commonName` for now. This feature is being removed by major browsers and deprecated by RFC 2818. (See https://github.com/shazow/urllib3/issues/497 for details.)
  SubjectAltNameWarning
Traceback (most recent call last):
  File "otest.py", line 8, in <module>
    swis.query("SELECT NodeID from Orion.Nodes")
  File "/home/user/orionsdk/lib/python2.7/site-packages/orionsdk/swisclient.py", line 24, in query
    {'query': query, 'parameters': params}).json()
  File "/home/user/orionsdk/lib/python2.7/site-packages/orionsdk/swisclient.py", line 59, in _req
    resp.raise_for_status()
  File "/home/user/orionsdk/lib/python2.7/site-packages/requests/models.py", line 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://solarwinds-orion:17778/SolarWinds/InformationService/v3/Json/Query

any idea what I need to do to address this issue?

needed to create and use local Orion account


Could we use customized AES-CTR mode to replace the original AES-CBC encryption mode

Azure.Storage.Blobs.Cryptography
We want to use a customized AES-CTR encryption algorithm to replace the original AES-CBC encryption algorithm. But the original BlobEncryptionPolicy's method is not virtual. Is there any plan to expose the method to virtual?

The current plan for this package is scoped to parity with previous SDK versions. This is limited to AES-CBC.

Then how can we encrypt/decrypt using AES-CTR?

Looking again at your original description, It seems as if you're using a version older than v12 (which is not actually in this specific repository). We do not plan to add any new features to these older versions. My above comment assumed you were using a v12 library, given the repo we are in, where we are in the process of porting this functionality over.
The above comment still stands though, that even in v12 we have no current plans to support beyond AES-CBC.


Events are 18 hours behind

Hi,
Sometimes (not all the time) but as of writing my events inside https://my.openappsec.io/ are 18 hours behind.
Is there an issue or something I can do on my end to speed things up?

Hi @novastream,
Thank you for reaching out! we're looking into this.


layers/meta-opentrons: disable electron gpu usage

This breaks when using SVG animations.
Closes RQA-2287
Closes RABR-22

Doesn't seem to!


How to import the Storybook components into a new React project

I've built a component library using React and Storybook and now I'd like to import and use the components in a separate React project.
I'm having trouble finding any good tutorials on how to do this - perhaps I'm entering the wrong terms. I understand you could use Yarn, or even create an npm module, but I can't find specifics. There maybe even better ways?
Could anyone send me links on how to import the React Storybook component library I've built into a new React project? Would greatly appreciate your help.

Well, there’s no such thing as “react storybook” component library. Storybook is a development and testing tool and should not affect how your components are used.
That said, I can give you some advices, but this highly depends on specifics of your project. Is your project open sourced? If it is, can I take a look at the repo?

Hi @Hypnosphi
Thanks for your quick reply. I do understand what you're saying, that Storybook is just a tool that I'm using within Create React App.
My project isn't open source, unfortunately. Very good question though. Do you have any resources/links for private repositories?
Thanks again for your help.
Cheers
Paul

@pauldcollins - I had a similar issue when I was building something, so I recently spun up a project to try and help solve it. It is super early and not ready at all. However, I share it because eventually, the goal is to solve the exact questions you have.
https://github.com/marchdoe/cl

@pauldcollins Are you trying to have storybook & components in a different repository from your app? If not, I'm not sure I understand what the problem is?
This is what I do:
$ tree
.
├── .storybook
│   ├── webpack.config.js
│   └── config.js
├── app
│   ├── webpack.config.js
│   ├── ...
│   └── ...
├── components
│   ├── myComponentNr1
│   │   ├── myComponentNr1.js
│   │   ├── myComponentNr1.spec.js
│   │   ├── myComponentNr1.story.js
│   │   └── ...
│   ├── ...
│   └── ...
├── .babelrc
├── .eslintrc.js
└── README.md

Storybook and the app are on the same level, and both look to the same components.
In fact I've even done this:
$ tree
.
├── .storybook
│   ├── webpack.config.js
│   └── config.js
├── app1
│   ├── webpack.config.js
│   ├── ...
│   └── ...
├── app2
│   ├── webpack.config.js
│   ├── ...
│   └── ...
├── components
│   ├── myComponentNr1
│   │   ├── myComponentNr1.js
│   │   ├── myComponentNr1.spec.js
│   │   ├── myComponentNr1.story.js
│   │   └── ...
│   ├── ...
│   └── ...
├── .babelrc
├── .eslintrc.js
└── README.md

And deploy multiple apps using the same components (developed in storybook) from 1 repository.
If you hate relative paths, you can configure webpack to resolve using alias or multiple modulePaths. Though I usually do not bother since it complicates things and creates a strong dependence on webpack.
I hope this helps you.

If you really want to develop components in a different repository for some reason, You could publish the package with all components as a npm module.
Or you could use github links as npm dependency: https://docs.npmjs.com/files/package.json#dependencies

Does you company have its own private npm registry? You probably want to publish your package there instead of global npm

Thanks everyone for coming to offer advice, I greatly appreciate it.
@marchdoe - your project looks great, thanks for sharing, I am now watching 👍
@ndelangen - That would be a great solution, but we are likely to spin a number of projects off this component library, some might need different versions and we might also end up making it public one day, so I think we need to keep it separate.
@Hypnosphi Yes, I think they do have a private registry. So... I guess I need to find resources on publishing a component library as an NPM package? I saw a short tutorial on YARN, but needed more information.
Thanks again everyone - @Hypnosphi, if you have any suggested resources for publishing a component library to NPM, I'd really appreciate the help.
Cheers!

Here are docs for publishing packages on npm: https://docs.npmjs.com/cli/publish
If you're going to use the same webpack and babel settings across your projects, this should be enough. Otherwise, you probably will want to precompile your components before publishing. Do you import something other than javascript in your components?

Thanks @Hypnosphi, appreciate the help. The project settings will be the same, so it should be fine.
Hi @ndelangen - just one question on the single repository structure, I've looked into requirements and this could be an option - but do you have any way of versioning your components if they're in the same repo?
I'm just thinking of a scenario where you update a component for 'app-2', but you don't want 'app-1' to get the changes. With NPM you can version, just wondering if it's possible in the same repo?
Thanks again.

@pauldcollins NO you will not be able to version a component and that is both a curse and a blessing.
You will be forced to keep your apps on the bleeding edge.
On the other hand this can make a small change slightly more complex, but will likely make your codebase much easier to understand.
If you extract the components into their own package, do not underestimate the time you'll spend publishing little patches on the many packages you now are maintaining. I feel staying on the bleeding edge of all your internally developed components is likely to be more productive.
but it really depends on your app, complexity and team.

Hi @ndelangen
Thanks for your explanation. I was having a hard time weighing up the concerns and you've helped me decide to keep everything in the same repository. I think the trade offs are worth it and a separate package might make it overly complex, for the size of the current project.
Thanks again for all your advice, and for Storybook! All the best.

Hi @ndelangen I just had one further question on your project structure above as I dive in - using the one repo.
Are you installing a new build of create-react-app in each folder? Just wondering what it would look like in practice - can you run apps from each folder at the same time?
Thanks again.

can you run apps from different folders at the same time?

Sure you can! as long, as you give them different ports.

Thanks @ndelangen, that makes sense !!

Hi @ndelangen, I am currently setting up my first app, based on your recommended structure above: all within the same repo. I've installed a new version of create-react-app inside a sub folder, that sits alongside components at the same folder level.
When trying to import from the components folder, I get an error saying I can't import anything outside of the src folder of my create-react-app install. I'm just wondering how you work around this - do you need to eject and remove ModuleScopePlugin, as this post suggests?
Or have you found a way to do it without ejecting?
Thanks again!

Hi @ndelangen, sorry to trouble you again.
I've been trying to get this setup to work for a number of days now and can't seem to make it happen.
Basically, if I install a new version of Create React App, there are all kinds of issues with importing component files from outside the src folder and using a linter if I eject. So I can't get the storybook files in from a sibling folder to my app root directory.
I was just wondering, are you using CRA for each of your app builds, or are you creating custom webpack install? If you have any further info on setting this up, I would greatly appreciate it!
Thanks again
Paul

If you use different CRA's then you need something like symbolic links, a feature supported by plain npm / yarn, to circumvent the problems you've mentioned. You could also take the mono repo approach from lerna, which also makes use of symbolic links.
In either case you would end up with having a dependency on your storybook components from your apps with the effect that they would be available in your node_modules folder as regular dependency. If your setup is the same (component library and CRA's) then you should be able to include your components in your app. If this doesn't work (as is the case with using typescript), then you need to compile your storybook component lib and use the compiled components as dependencies.

Hi @texttechne thanks very much for your reply.
Does this mean I would need to publish an NPM package in order for the project to work? I imagine once someone else downloads it, they won't have the npm-link setup, so it wouldn't work for them. Would this also affect it going live?
Thanks for your help

The npm link stuff is only for development. For production you publish to a private or public repo and then it becomes easy: Your component lib becomes a plain npm dependency.
For private repos take a look at: Nexus (quite powerful repo manager for Java, Docker, NPM, ...) or Sinopia (much easier to setup).

Thanks for your quick reply @texttechne
It sounds like an NPM package is really the best way to go, maybe the only way, after spending the last four days on this! I thought the "all in the one repo" option would be quicker!!
Thanks for your help and advice, much appreciated.


add name placeholder to portfolio

[ ] Turn on GitHub Pages
[ ] Outline my portfolio
[ ] Introduce myself to the world

asad


Added lang attr to html tag and grommet App.

This PR adds the lang attribute to the App grommet component and to the html tag as suggested but the WCAG 2.0 guidelines.
If no lang attribute is passed to the App component, it gets the default locale from the browser. Also, the App component sets the lang attribute to the html tag if it is not set.

Thanks @TiagoJustino . I'm glad to see the first PR targeting accessibility work. @samogami


Add detail to error message

When receiving a large amount of data, it can be helpful for a client
to know which record caused the problem.
Added after request from @benilovj.

:+1:


Consider updating configuration and rake tasks to support multiple engines

I am currently working on several projects that make extensive use of engines to break large code bases into manageable chunks, and with the current react_on_rails configuration setup, it is very difficult to work with client code from several engines independently.
I'm working on a fork that will allow a per-engine configuration process for the ReactOnRails gem in such a way that including engines with ReactOnRails UIs simply works at the main application level.
I would love to discuss possible pitfalls and challenges you see with this approach.

@emerson-h Some others wanted to do that as well. Definitely read the discussions on old issues and PRs. We'd like to support this idea!

@emerson-h I invited you to our slack room.

See #562


[FR] Support for earbud pause, play, removal

Hi, can support be added for earbud pause, play buttons, and also auto-pause if both are taken out? I believe there's a native library for this.

Implemented in https://github.com/abdallahmehiz/mpvKt/pull/118

Should I add a switch preference for this? Or would you want it automatically enabled for everyone?


Fix links for stamp.init() and stamp.composers() in API documentation TOC.

I noticed some of the links in the API documentation TOC were either wrong or missing, so I just ran Doctoc on API.md and that fixed it.

So much thank you!

We are an open community. Would you like to be added to the organisation people list?
https://github.com/orgs/stampit-org/people

Sure! :)

Invite sent 👍
:)
Welcome!

Invite accepted. Thanks a lot!


Default to hex string if name is "unknown"

This applies to inspect and to_s. It should still return <unknown> when calling to_name.
irb(main):002:0> 'red'.paint.brighten
=> <unknown>

Implemented by ce49d23.


Stack reverts to non-volatile settings when changed by application

Recently #1586 has been applied to invalidate Operational Dataset in case of change of some parameters like channel or PAN ID.
Unfortunatelly i can't see this behaviour using CLI example, at least in a way i would expect this to work:
> panid 0x1234
Done
> ifconfig up
Done
> thread start
Done
> state
leader
Done
> thread stop
Done
> ifconfig down
Done
> channel
11
Done
> channel 14
Done
> ifconfig up
Done
> thread start
Done
> channel
11  <-- Channel has been reverted
Done

I found that the problem is here:
https://github.com/openthread/openthread/blob/master/src/core/meshcop/dataset_manager.cpp#L191
mLocal is actually never invalidated due to result of Compare method. If this result is omitted, then channel does not revert to one set in non-volatile memory.
@jwhui Should we just change condition or add a new parameter/method that will not perform this comparison or do you see more sophisticated solution?

Yes, good catch.  I actually think we can remove the Compare method from the if-statement.  Thoughts?
/cc @chshu @librasungirl

Great! If there will be no objections i am willing to send this simple fix.

Go ahead and submit a PR, others can still object in the mean time :)

Resolved by #1639.


fix: find highlight disappears on clicking the cell

This PR fixes #14222

Pull Request Test Coverage Report for Build 579262663

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.007%) to 43.308%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts
2
3.07%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 579128829:
-0.007%

Covered Lines:
24997

Relevant Lines:
52904

💛  - Coveralls

@MaddyDev, can we also look into not calling through to the markdown renderer code on cell selection?

I noticed on Mac OS X, with a given cell editor open, that the scroll to position of the current highlighted hit (in orange) is just out of view. See image below:

I will add, that when the editor is NOT open, the highlighted hit is not obstructed by the UI in any way. See image below:

Can you open an issue for this and assign it to me. Thanks!


[REQ] determining where on a page these links will go

It's likely that the menu interface will create categorized component libraries for menus. When a user is setting up a page, they can select what menus they'd like to have appear.

This will be done via blade extension. When a menu is created it will get a name. That name will then be rendered according to the extension itself. For example
@frondsMenu('top links')

will render a menu with that name tagged to it according to what is stored in the database for that name tag


Update ort to v2.0.0-rc.9

Following ort's 2.0.0-rc.9 "Undo The Flattening" change, update import paths:

Move from flat ort::Session to ort::session::Session
Move from flat ort::GraphOptimizationLevel to ort::session::builder::GraphOptimizationLevel

Looks good, thanks!

Looks good, thanks!

 When I was testing with the latest ort version, the current version pyannote-rs was giving errors. I would be very grateful if you could also do a new version update from crates.io so I can run my tests :)


Was release 1.3.0 ninja edited?

I'm getting:
verifying<EMAIL_ADDRESS>checksum mismatch
	downloaded: h1:g3E6mto+hFdA2uZXeNDYff8LYeg7v5D4YKP/Ng/NUkE=
	go.sum:     h1:tBpRC1/J04jBAXKnpF3V5Zqm0GVMQrIIOCOXEzME1Ks=

So either someone's attacking me, or the 1.3.0 release was re-published with changes to the files.  Can you shed any light on this?

Hi, the original v1.3.0 was bugged so I did republish it. In hindsight I suppose I should have bumped the minor version instead. I think I'll do that now just to avoid this issue.

Ok thanks

Hi, can you give an idea when you expect to push the new release?

V1.3.1 was tagged after my comment was posted. You can upgrade to it now. :)

Oh ok, I was looking at releases rather than tags.  Thanks!

Going to close this now. Left it open for a little while in case somebody else had the same question. 😄


Improve styleguide in hygen template

More harder that this?

You're introducing two ways of import.

More harder that this?

It's not a problem about default, it's a problem of the name of the function

I think the functionality if you reference the function named formulateModel the destructuring is unnecessary.

The documentation:

Named exports are useful to export several values. During the import, one will be able to use the same name to refer to the corresponding value.
Concerning the default export, there is only a single default export per module. A default export can be a function, a class, an object or anything else. This value is to be considered as the “main” exported value since it will be the simplest to import.

In general, a model should have more than 1 function. For example StoresModel could have: getStoreById, getAllStores, findNearestStore...
it's odd to do:
import getStoreById, {getAllStores, findNearestStore} from ...

I know it's allowed and in several libraries (like react for example) is useful because a method is clearly more used than the rest, but not apply for models

Ok, I understand, I change it

Done


When I sending a message by async, sometimes throw ConcurrentModificationException

I'm just sending a string, I don't know why this is happening。
client-version:  4.5.2
server-version: 4.5.2
hope somebody can help me !

Hi @yangjie9212, you can update to version 4.8 and have a try.

@yangjie9212 can you replay it by hand ?

@maixiaohai i have the same problem, can you tell me why，or  can you show me  where is the fixed code ,thanks so mush!


lxc start fails if there is a space in path

Github issues are used for bug reports. For support questions, please use our forum.
Please fill the template below as it will greatly help us track down your issue and reproduce it on our side.
Feel free to remove anything which doesn't apply to you and add more information where it makes sense.
Required information

Distribution: Ubuntu
Distribution version: 17.10
The output of "lxc info" or if that fails:

$ lxc info
config: {}
api_extensions:
- storage_zfs_remove_snapshots
- container_host_shutdown_timeout
- container_syscall_filtering
- auth_pki
- container_last_used_at
- etag
- patch
- usb_devices
- https_allowed_credentials
- image_compression_algorithm
- directory_manipulation
- container_cpu_time
- storage_zfs_use_refquota
- storage_lvm_mount_options
- network
- profile_usedby
- container_push
- container_exec_recording
- certificate_update
- container_exec_signal_handling
- gpu_devices
- container_image_properties
- migration_progress
- id_map
- network_firewall_filtering
- network_routes
- storage
- file_delete
- file_append
- network_dhcp_expiry
- storage_lvm_vg_rename
- storage_lvm_thinpool_rename
- network_vlan
- image_create_aliases
- container_stateless_copy
- container_only_migration
- storage_zfs_clone_copy
- unix_device_rename
- storage_lvm_use_thinpool
- storage_rsync_bwlimit
- network_vxlan_interface
- storage_btrfs_mount_options
- entity_description
- image_force_refresh
- storage_lvm_lv_resizing
- id_map_base
- file_symlinks
- container_push_target
- network_vlan_physical
- storage_images_delete
- container_edit_metadata
- container_snapshot_stateful_migration
- storage_driver_ceph
- storage_ceph_user_name
- resource_limits
- storage_volatile_initial_source
- storage_ceph_force_osd_reuse
- storage_block_filesystem_btrfs
api_status: stable
api_version: "1.0"
auth: trusted
public: false
environment:
  addresses: []
  architectures:
  - x86_64
  - i686
  certificate: |
    -----BEGIN CERTIFICATE-----
...
    -----END CERTIFICATE-----
  certificate_fingerprint: 80fd86119bb6b81b05baee8eb34d93d77e7f912dfb04ceafe05a45f76f805d3d
  driver: lxc
  driver_version: 2.1.0
  kernel: Linux
  kernel_architecture: x86_64
  kernel_version: 4.13.0-17-generic
  server: lxd
  server_pid: 1937
  server_version: "2.18"
  storage: btrfs
  storage_version: "4.12"

Issue description
Create a new container lxc init ubuntu:17.10 plex
Edit container lxc config edit plex
Using yaml below lxc start plex generates an error. Replacing the spaces in path: share/home/Kid TV & path: share/home/Kid Movies with underscores allows the container to start.
### This is a yaml representation of the configuration.
architecture: x86_64
config:
  boot.autostart: "true"
  image.architecture: amd64
  image.description: ubuntu 17.10 amd64 (release) (20171122)
  image.label: release
  image.os: ubuntu
  image.release: artful
  image.serial: "20171122"
  image.version: "17.10"
  limits.cpu.allowance: 50%
  limits.memory: 4GB
  raw.idmap: |-
    uid 2500 2500
    gid 2500 2500
  volatile.base_image: bcd33e96064a1bd5ed2adec3e6103e802c4cd6b524e38cda176f5dc4123535d7
  volatile.eth0.hwaddr: 00:16:3e:b0:74:7a
  volatile.eth0.name: eth0
  volatile.idmap.base: "0"
  volatile.idmap.next: '[{"Isuid":true,"Isgid":false,"Hostid":100000,"Nsid":0,"Maprange":2500},{"Isuid":true,"Isgid":false,"Hostid":2500,"Nsid":2500,"Maprange":1},{"Isuid":true,"Isgid":false,"Hostid":102501,"Nsid":2501,"Maprange":63035},{"Isuid":false,"Isgid":true,"Hostid":100000,"Nsid":0,"Maprange":2500},{"Isuid":false,"Isgid":true,"Hostid":2500,"Nsid":2500,"Maprange":1},{"Isuid":false,"Isgid":true,"Hostid":102501,"Nsid":2501,"Maprange":63035}]'
  volatile.last_state.idmap: '[{"Isuid":true,"Isgid":false,"Hostid":100000,"Nsid":0,"Maprange":2500},{"Isuid":true,"Isgid":false,"Hostid":2500,"Nsid":2500,"Maprange":1},{"Isuid":true,"Isgid":false,"Hostid":102501,"Nsid":2501,"Maprange":63035},{"Isuid":false,"Isgid":true,"Hostid":100000,"Nsid":0,"Maprange":2500},{"Isuid":false,"Isgid":true,"Hostid":2500,"Nsid":2500,"Maprange":1},{"Isuid":false,"Isgid":true,"Hostid":102501,"Nsid":2501,"Maprange":63035}]'
  volatile.last_state.power: RUNNING
devices:
  dvr:
    path: share/home/DVR
    source: /mnt/storage/home/DVR
    type: disk
  eth0:
    nictype: bridged
    parent: br0
    type: nic
  kid-movies:
    path: share/home/Kid Movies
    source: /mnt/storage/home/Kid Movies
    type: disk
  kid-tv:
    path: share/home/Kid TV
    source: /mnt/storage/home/Kid TV
    type: disk
  movies:
    path: share/home/Movies
    source: /mnt/storage/home/Movies
    type: disk
  tv:
    path: share/home/TV
    source: /mnt/storage/home/TV
    type: disk
ephemeral: false
profiles:
- default
stateful: false
description: ""

Steps to reproduce

Step one
Step two
Step three

Information to attach

[ ] Any relevant kernel output (dmesg)
[ ] Container log (lxc info NAME --show-log)
[ ] Container configuration (lxc config show NAME --expanded)
[ ] Main daemon log (at /var/log/lxd/lxd.log or /var/snap/lxd/common/lxd/logs/lxd.log)
[ ] Output of the client with --debug
[ ] Output of the daemon with --debug (alternatively output of lxc monitor while reproducing the issue)

$ lxc info --show-log plex
Name: plex
Remote: unix://
Architecture: x86_64
Created: 2017/11/30 05:34 UTC
Status: Stopped
Type: persistent
Profiles: default

Log:

            lxc<PHONE_NUMBER>0133.474 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.474 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.566 WARN     lxc_cgfsng - cgroups/cgfsng.c:chown_cgroup_wrapper:1492 - Error chmoding /sys/fs/cgroup/unified//lxc/plex: No such file or directory
            lxc<PHONE_NUMBER>0133.606 ERROR    lxc_conf - conf.c:mount_entry:1854 - No such file or directory - Failed to mount "/var/lib/lxd/devices/plex/disk.\"share-home-Kid" on "/usr/lib/x86_64-linux-gnu/lxc/TV\""
            lxc<PHONE_NUMBER>0133.606 ERROR    lxc_conf - conf.c:lxc_setup:3186 - failed to setup the mount entries for 'plex'
            lxc<PHONE_NUMBER>0133.606 ERROR    lxc_start - start.c:do_start:921 - Failed to setup container "plex".
            lxc<PHONE_NUMBER>0133.606 ERROR    lxc_sync - sync.c:__sync_wait:57 - An error occurred in another process (expected sequence number 5)
            lxc<PHONE_NUMBER>0133.658 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.658 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.658 ERROR    lxc_container - lxccontainer.c:wait_on_daemonized_start:760 - Received container state "ABORTING" instead of "RUNNING"
            lxc<PHONE_NUMBER>0133.658 ERROR    lxc_start - start.c:__lxc_start:1451 - Failed to spawn container "plex".
            lxc<PHONE_NUMBER>0133.658 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.658 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.791 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.791 WARN     lxc_monitor - monitor.c:lxc_monitor_fifo_send:111 - Failed to open fifo to send message: No such file or directory.
            lxc<PHONE_NUMBER>0133.792 WARN     lxc_commands - commands.c:lxc_cmd_rsp_recv:125 - Command get_cgroup failed to receive response: Connection reset by peer.

Right, the on-disk encoding of paths with spaces is wrong. I'm going to look into this now.

On Mon, Dec 04, 2017 at 11:42:59PM -0800, Stéphane Graber wrote:

Assigned #4064 to @brauner.

As I said on irc yesterday, I have a plan on how to handle this but I'm
not going to work on this before we have an agreement.
On the LXD side we should stop encoding paths with a simple
strings.Replace(path, "/", "-", -1)
Since this encoding will not just fail when there are spaces or tabs in
there it is also not invertible. Any device that implicitly adds other
devices that have on-disk representations (unix character and block
devices for example) will not have configuration items to track where
these devices have been mounted so safe removal cannot be guaranteed.
 For infiniband devices this is somewhat ok, since we rely
on them being present at "/dev/infiniband/" with their standard device
names. All these path components are therefore sane wrt to our
strings.Replace() call and are also invertible. However, this obviously
breaks down with user specified paths.
The approach I prefered was to do base64 URL encoding (Note, this is not
the URL encoding with "%".) of the appended device
path on the LXD side.
For example, let's say you want mount a disk device at "/opt/bla bla"
inside the container then the lxd device that gets created would be
/var/lib/lxd/devices/a1/disk.a.L29wdC9ibGEgYmxh
To decode where the device is mounted inside the container you'd simply
do:

find last "."
snip out everything after last "."
decode(last_part)
done

For someone interested in mapping this representation to the mountpoint
inside the container they can either just look at the device identified
by the unique name "a" in this case or simply look at the mount table.
Uniqueness wasn't guaranteed before meaning users couldn't reliably
conclude from the on-disk name of the device where it was mounted inside
the container. Think of something like /opt/-bla vs. opt/--bla.
There's no other way to tell these two apart other than looking at the
device name itself so this shouldn't be a concern now.
This is the LXD side of things. In addition I believe this requires a
liblxc path to handle quoted strings in mount entries which it doesn't
do right now if I'm not mistaken.

This is the LXD side of things. In addition I believe this requires a
liblxc path to handle quoted strings in mount entries which it doesn't
do right now if I'm not mistaken.

Actually, for the liblxc side we might be fine since we can just octal escape the path.

Two of those commits implement correct fstab-style path escaping so that liblxc and the corresponding C library routines around {g,s}mntent_r() can correctly deal with the mounts we pass to them.
The commits I just pushed do not yet completely fix this issue as the LXD on-disk representation of the device is still not completely sane but I'll wait for @stgraber to comment on this before proceeding.

I like it to be human readable on disk but we should use logic similar to what we have for LVM to deal with slashes, replacing them with - or _ and then replacing - or _ with -- or __ so that we don't get conflicts.
Anyway, this shouldn't be a problem with spaces as those are valid in a filename and don't need further escaping.

You should be able to merge this one though.


some discuss

Dear Professor,
I'm sorry to disturb you. I am currently studying deep learning, especially object detection and posture recognition. The content we learned in class is related to the identification of criminal behavior. My idea is to recognize behavior through 3D convolution. My approach is to divide the criminal stage into two parts and create two datasets respectively: one for suspicious behavior before a crime, and the other for successful criminal behavior. These two behaviors only last about 3-5 seconds. Then, by preprocessing the video data of these different categories into 16-frame images, along with normal behavior videos, there are three categories in total for training. Finally, a three-classification behavior division will be achieved to predict crime and issue an alarm. However, I'm very interested in your pre-processing part. Did you use OpenCV? Can I discuss it with you in more depth? Sorry for taking up your precious time. Thank you again.
Sincerely
Email<EMAIL_ADDRESS>

Dear Professor, I'm sorry to disturb you. I am currently studying deep learning, especially object detection and posture recognition. The content we learned in class is related to the identification of criminal behavior. My idea is to recognize behavior through 3D convolution. My approach is to divide the criminal stage into two parts and create two datasets respectively: one for suspicious behavior before a crime, and the other for successful criminal behavior. These two behaviors only last about 3-5 seconds. Then, by preprocessing the video data of these different categories into 16-frame images, along with normal behavior videos, there are three categories in total for training. Finally, a three-classification behavior division will be achieved to predict crime and issue an alarm. However, I'm very interested in your pre-processing part. Did you use OpenCV? Can I discuss it with you in more depth? Sorry for taking up your precious time. Thank you again. Sincerely Email<EMAIL_ADDRESS>
Welcome
Yes, you need to use OpenCV as a default in many of the video pre-processing methodologies included in the dataset.
I'm available to help with pre-processing steps and more.
I wish you success.


support x1 perception config

PR Type

New Feature
Improvement
Bug Fix

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Code follows coding guidelines
[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@satoshi-ota 少し想定と違うところがあるので、定例でお話します！

@yukkysaito fix following points in https://github.com/tier4/AutowareArchitectureProposal_launcher/pull/129/commits/75ae9f285c5e8c4fbea724d29c128d85cf254010, https://github.com/tier4/AutowareArchitectureProposal_launcher/pull/129/commits/b36b2371b7f7b9b28fa474ce965cad1a3003efdd

remove config files depend on each products
set xx1 perception config as default in ground_segmentation.param.yaml

@satoshi-ota
Why separate compare map components and ransac pipeline components?

@satoshi-ota Why separate compare map components and ransac pipeline components?

@taichiH There is no clear reason.

@yukkysaito please check modifications in 3a2a851, 9ff854c and approve :pray:


BREAKING CHANGE: remove 'SegmentedControl' component

References: 8991

@lkappeler the way i understand is that they don't want to use these 'tabs' anymore. One of the tickets of listing reactivation topic was to change the looks of the tabs because of the 'outdated' look these had.

I have the same understanding as Gzim. I remember Enrique said the element was generally misunderstood by users. Always fair to double check the designers intention though. On the other hand - should it ever come up again, it's a button click away from being reverted

in case this did not get released, I believe it's because as far as I understand, the commit message still needs a fix/chore/feat and the breaking change indicator has to be in the commit message body, for example:
chore: remove SegmentedControl component

BREAKING CHANGE: `SegmentedControl` is unused and was removed. use xyz instead

@masone It looks it didnt get released.. what do you recommend now since i already merged this PR?

Unfortunately, an empty commit is the only way in this situation (we don't want to alter history on master).
git commit -am "your full message" --allow-empty
We'll loose the reference from the commit to the PR that includes the breaking change and the changelog will be a bit wonky. But it happens. Let's make sure it's properly released and we should be fine
Please do so timely - ie. before anyone else releases some fix that would then include this breaking commit as well :)


Testing Information : CCD SCAN : Total Circulating Supply

(CCDscan will probably be deployed on mainnet on 06-12)

@SRConcordium Can you check that on mainnet now pls?


iOS failing after picture taking

Bug
Version Number of Plugin: 2.3.0
Device Tested On: physical iPhone 6s 9.3.4
Simulator Tested On: using MacinCloud - haven't tried taking picture, don't believe I can
Expected Behavior
After taking picture and "OK'ing" picture app should "close" camera and be on page. It should display picture and allow user to "name" picture. Finally Save the photo.
Actual Behavior
After taking picture & OK app "pops" my camera page and returns to the "launch" page.
The only thing I can do then from the launch page is take another picture. no other buttons on that page respond.
Steps to reproduce the Behavior
I have not created a one-off app for just this function. I will do so over the weekend.
This is a Xamarin.Forms (<IP_ADDRESS>) PCL. Currently 0 code in iOS - they way it should be :). The code I have works perfectly on the Android side, which is tested on a Motorola Droid.
Here is code on camera page: ( I never see the popup with the file location)
bool cameraReady = await CrossMedia.Current.Initialize();
if (!cameraReady) {
await DisplayAlert("Camera", "Cannot initialize camera", "OK");
return;
}
if (!CrossMedia.Current.IsCameraAvailable || !CrossMedia.Current.IsTakePhotoSupported) {
await DisplayAlert("Camera", "No camera available", "OK");
return;
}
Plugin.Media.Abstractions.MediaFile file = await CrossMedia.Current.TakePhotoAsync(new Plugin.Media.Abstractions.StoreCameraMediaOptions {
Directory = "Operations",
Name = "Image.jpg"
});
if (file == null) {
await DisplayAlert("Camera", "Image file missing", "OK");
return;
}
await DisplayAlert("File Location", file.Path, "OK");
Thanks.
Glen

Have you tried the latest beta build? See if that has any impact on your tests?

I am unable to reproduce this at all with 2.3.0 or with latest betas.

Before I do a one off, should I go uninstall the package and reinstall?
Thanks for respond so quickly btw, I really appreciate it.
Glen Meredith
Global Workplace Solutions
On Oct 7, 2016, at 7:14 PM, James Montemagno <notifications<EMAIL_ADDRESS>wrote:
I am unable to reproduce this at all with 2.3.0 or with latest betas.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jamesmontemagno/MediaPlugin/issues/99#issuecomment-252382327, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUU6_6qIuBDi9dL9CachTrJMdmUMcwBzks5qxtJagaJpZM4KRciD.

You can just upgrade them as it is easy to roll back. 2.6.0 is extremely stable though.
here is a tiny test app:
TestApp2.zip

Great, thanks! I follow up tomorrow.
FYI, I also had issues with the signaturePad (Xamarin's). I posted an issue over there. That one was weird because it works great on android, works in iOS simulator but not on the actual phone. I had to create a work around by having the user type their name in and then I turn it into an image in my WCF service.
Glen Meredith
Global Workplace Solutions
On Oct 7, 2016, at 7:37 PM, James Montemagno <notifications<EMAIL_ADDRESS>wrote:
You can just upgrade them as it is easy to roll back. 2.6.0 is extremely stable though.
here is a tiny test app:
TestApp2.ziphttps://github.com/jamesmontemagno/MediaPlugin/files/517278/TestApp2.zip

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jamesmontemagno/MediaPlugin/issues/99#issuecomment-252384902, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUU6_4P0binYMLY_FtbnZmUsQ7taXoTyks5qxte5gaJpZM4KRciD.

Issue wasn't related to package but rather that the function was called in the constructor.

Ahhhh gotcha :) makes some sense cool!


vue-swatches component not getting the value from a variable

vue-swatches is working fine the problem is that I have an edit form and I want to pass the value (color in HEX) from a variable to the component as a selected like value="{{$var->hex_color}}.
      components: {          Swatches,       },       data:{         color:'#ffffff',       },     });
<swatches v-model="color" colors="text-advanced" value="{{$var->hex_color}}"></swatches>
When I load the page it shows the default color #ffffff instead of the $var->hex_color.

Hi, why you are using v-model and value at the same time?, try using v-model only

Hi, why you are using v-model and value at the same time?, try using v-model only

Hi, you mean like this <swatches v-model="{{$var->hex_color}}" colors="text-advanced"></swatches>
I tried not working.

<swatches v-model="color" colors="text-advanced"></swatches>

{
  data:{ color:  "{{$var->hex_color}}" }
}

I will close this, due inactive, and this is actually a vue concern


Icon SubComponent Props

Components that have an icon prop that is a string should also alternatively support using IconProps.

Merged into templates branch.


[Bug]: In personal space, the icon at the top of the database is replaced by the return icon.

ODC version
Oceanbase4.2.2
OB version
any
What happened?
In personal space, the current icon in the screenshot is obviously the expand icon, but its actual function is to return to the database list. It should be replaced by the return icon.

What did you expect to happen?
It should be replaced by the return icon.
How can we reproduce it (as minimally and precisely as possible)?
In personal space, the current icon in the screenshot is obviously the expand icon, but its actual function is to return to the database list. It should be replaced by the return icon.
Anything else we need to know?
No response
Cloud
No response

By design


getOppositeEdge() not executing properly

Description
When using the getOppsositeEdge() function for filleting, it is not executing as expected. You'll see in the video I replace all of them with getNextAdjacentEdge() and they execute no problem (albeit, it doesn't look pretty, but it still renders properly).
Note: the rest of the code is no issue, I did the filleting last.
Version
v0.15.6 - web app
Screenshots/videos
https://github.com/KittyCAD/modeling-app/assets/114548659/9f9928ba-8025-4ca6-8630-2bc57b1e795c
Update
I noticed in the video I use a radius of 4, so I reduced this down to 0.25, and it renders the first edge and nothing else.

What’s the error say that it is throwing

I think it’s likely that fillets next to each other doesn’t work yet so you get a fillet error. It is def throwing an error

Also, @franknoirot, can we have the KCL errors scrollable? I can't see the errors if I open all the objects within the pane, it exceeds lower than the screen. I also cannot copy and paste the information (hence the screenshot above).
Forgot to include the KCL
const l1 = 10
const l2 = 10
const arcR = 2
const footH = 3.5
const bodyHeight = 2.5
const filletRadius = 0.25

fn kittLeg = (sk1, sk2) => {
  const legExtrude = startSketchAt([sk1, sk2])
  |> line([3, 0], %)
  |> line([0, -3], %)
  |> line([-3, 0], %)
  |> close(%)
  |> extrude(bodyHeight, %)
  return legExtrude
}

fn kittEar = (sk1, sk2) => {
  const earExtrude = startSketchAt([sk1, sk2])
  |> bezierCurve({
       control1: [0, 3],
       control2: [3, 3],
       to: [3, 0]
     }, %)
  |> close(%)
  |> extrude(bodyHeight, %)
  return earExtrude
}

fn kittFoot = (sk1, sk2) => {
  const footExtrude = startSketchAt([sk1, sk2])
  |> line([3, 0], %)
  |> line([0, -1.5], %)
  |> line([-3, 0], %)
  |> close(%)
  |> extrude(footH, %)
  return footExtrude
}

const kittBody = startSketchAt([0, 0])
  |> line({to: [0, l1], tag: 'fillet1'}, %)
  |> line({to: [l2, 0], tag: 'fillet2'}, %)
  |> line({to: [0, -l1], tag: 'fillet3'}, %)
  |> close(%, 'fillet4')
  |> extrude(bodyHeight, %)
  |> fillet({
       radius: 0.25,
       tags: [
  getOppositeEdge('fillet1', %),
  getOppositeEdge('fillet2', %),
  getOppositeEdge('fillet3', %),
  getOppositeEdge('fillet4', %)
]
     }, %)

const leg1 = kittLeg(1, 0)
const leg2 = kittLeg(6, 0)
const ear1 = kittEar(1, 10)
const ear2 = kittEar(6, 10)
const foot1 = kittFoot(1, -3)
const foot2 = kittFoot(6, -3)

const face = startSketchOn(kittBody, 'end')
  |> startProfileAt([1, 1], %)
  |> line([l1 - 2, 0], %)
  |> line([0, l2 - 2], %)
  |> line([(-l1+2), 0], %)
  |> close(%)
  |> extrude(-.5, %)

fn button = (start1, start2, w, l, h) => {
  const buttonSketch = startSketchOn(kittBody, 'end')
  |> startProfileAt([start1, start2], %)
  |> line([w, 0], %)
  |> line([0, l], %)
  |> line([-w, 0], %)
  |> close(%)
  |> extrude(h, %)
  return buttonSketch
}

const button1 = button(0.25, 0.25, 1, .25, .125)
const button2 = button(2, 0.25, 1, .25, .125)
const button3 = button(3.75, 0.25, 1, .25, .125)

Just try to fillet one edge, those are next to each other I think that’s why it’s failing. We have no fillet intersections yet

Or try two not next to each other

the problem is they intersect i need to add to known-issues
https://github.com/KittyCAD/modeling-app/assets/1445228/d2d67b48-6b9f-4db0-8f11-8b7c2d0e072d


SP5: Cache typefaces

Update FontStyle to add a typeface cache to avoid to call too often the font face lookup table.
This should solve issue #2833

Thank you for this fantastic solution @KroMignon! I really appreciate your work improving ScottPlot 5 performance with this pull request 🚀
A few thoughts about this work:

I hope to to benchmark performance before/after this PR using docker: #2851

Your original SetField<T> function was very elegant! I'm copying the code below so it can be appreciated. However, to simplify the code I chose to put all the logic in the getters for font Name, Bold, and Italic. Your solution worked well and would have been preferred if there were more properties. However, moving this logic to the getters allowed explicit typing (preventing the need for casting) and also avoided multiple levels of if statements. In the end I favored the simplicity at the cost of a small amount of code duplication.

// strategy in the original PR
protected bool SetField<T>(ref T fieldValue, T value)
{
    if (value is string)
    {
        if (string.Compare(fieldValue as string, value as string) == 0)
            return false;
    }
    else if (Equals(fieldValue, value))
        return false;
    fieldValue = value;
    _typeface = null;
    return true;
}

Thank you again for this excellent work! 🙏


Npm packages

Can I use any npm package I want or are there limitations?
Thank you in advance

You can use any npm package that does not have native bindings.  That is, any package that is a pure JS implementation, or any of the Node.js built-in modules.  You cannot use a module that requires compilation of a C/C++ addon, unless that addon has been modified for use with LiquidCore.  For example, I have created a LiquidCore-compliant version of node-sqlite3 which is a fork of the original, but updated to work with LiquidCore.  Other native modules would require some work, but it can be done.

So, @ericwlange I doubt utp-native is not going to work, right? and also this package that is built for mobile

@ericwlange how do I make my own JavaScript binding like you did with SQLite?


Search doesn't work with angular 1.3.*

Hello, Alex!
I have found that search does not work with angular 1.3.*.
The problem is in $timeout function :
self.search_promise = $timeout(function (query) {
						//TODO: this needs a lot of improving. Maybe use lunar.js?
						var filter = [];
						filter.push({
							field: $scope.search_field,
							query: query
						});

						$scope.items = amse.get_filtered_tree(filter);
						$scope.search_spinner_visible = false;
					}, 1500, true, _new);
				});

Angular's old version of $timeout doesn't support additional parameters to the executed function, therefore _new parameter is not used and query has undefined value.
 docs for $timeout's old version
 docs for $timeout's current version
Do you have any ideas how to fix it with angular 1.3.* ?
And if you don't have, is it possible to customize search ( use my own custom search)?

Doesn't look like a hard one to fix. Give me a few hours.
El El vie, 8 abr 2016 a las 16:55, AlekseyKovalevsky <
<EMAIL_ADDRESS>escribió:

Hello, Alex!
I have found that search does not work with angular 1.3.*.
The problem is in$timeout function :
self.search_promise = $timeout(function (query) {
//TODO: this needs a lot of improving. Maybe use lunar.js?
var filter = [];
filter.push({
field: $scope.search_field,
query: query
});
                    $scope.items = amse.get_filtered_tree(filter);
                    $scope.search_spinner_visible = false;
                }, 1500, true, _new);
            });

Angular's old version of $timeout doesn't support additional parameters
to the executed function, therefore _new parameter is not used and query
has undefined value.
docs for $timeout's old version
https://code.angularjs.org/1.3.19/docs/api/ng/service/%24timeout
docs for $timeout's current version
https://docs.angularjs.org/api/ng/service/%24timeout
Do you have any ideas how to fix it with angular 1.3.* ?
And if you don't have, is it possible to customize search ( use my own
custom search)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/alexandernst/angular-multi-select/issues/90

I'll release v7 in a few hours, you can use that one. Please read the upgrading docs as some things changed.

Thank you so much :)


Docs on extensions have HAProxy a lot of places in nginx section

yikes this looks like a bad merge.  thanks for reporting!

fixed in 898c7de thanks!


Missing memory flushes

While the Buffer::update functions combine map, flush and unmap operations for moving system memory into mapped memory, there are a number of places in the code that use map and unmap with no call to flush.  For example:
https://github.com/KhronosGroup/Vulkan-Samples/blob/6fbdb437e2202c7b8a6f453dae017081310a0938/samples/extensions/descriptor_indexing/descriptor_indexing.cpp#L432
AFAIK, there's no guarantee of any coherent memory pools in Vulkan so unless the flag is checked there should always be a flush preceding an unmap

This isn't actually fixed.  The allocated refactor PR underwent a lot of revisions and I eventually stripped out a lot of changes that weren't strictly necessary to the original PR.


Fix empty get_citedby() result

Referring to this issue: https://github.com/OrganicIrradiation/scholarly/issues/47
In the Publisher init method, I extracted the list of cited publications from the URL and pushed it into id_scholarcitedby.
After that, I also had to edit the get_citedby method class.
I had to transform the list of strings in a format that is acceptable from the requests lib. To do that, I had to import "urllib" library too.

The issue has been fixed in the latest release.


MongoDB configure cacheSizeGB based on memory requests/limits

According to the docs the cacheSizeGB should be based on the resource limits of the container:
If you run mongod in a container (e.g. lxc, cgroups, Docker, etc.) that does not have access to all of the RAM available in a system, you must set storage.wiredTiger.engineConfig.cacheSizeGB to a value less than the amount of RAM available in the container. The exact amount depends on the other processes running in the container.

https://docs.mongodb.com/manual/reference/configuration-options/
Right now if you run mongodb instances using kubedb in a "shared" kubernetes cluser, multiple containers take about 50% of the available memory of the system for cache. This will lead to container crashes or oom problems.

this is my current workaround
https://github.com/arvatoaws/graylog-helm-chart/blob/master/graylog/templates/mongodb-config.yaml


Enhance Help : About menu item

Include reference to open-source and MIT license (plus appropriate link).
Modify the existing link to point to something more appropriate like docs/About.  Note that this link will likely continue to evolve over time.
Include disclaimer of liability.  See PCyl-CLI "Intro" for a possible starting point.

Added  to Help : About modal.
Main liability disclaimer is MIT License.  Additional words are in docs/About/Legal/Disclaimer.md which is available through the "home page" link on Help : About modal.
Checked in to remote master.  Closing.


GAWB-2287: Cluster Initialization and support for GET

[ ] Submitter: Include the JIRA issue number in the PR description
[ ] Submitter: Make sure Swagger is updated if API changes
[ ] Submitter: If updating admin endpoints, also update firecloud-admin-cli
[ ] Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
[ ] Submitter: JIRA ticket checks:

Acceptance criteria exists and is met
Note any changes to implementation from the description
To Demo flag is set
Release Summary is filled out, if applicable
Add notes on how to QA

[ ] Submitter: Update RC_XXX release ticket with any config or environment changes necessary
[ ] Submitter: Update FISMA documentation if changes to:

Authentication
Authorization
Encryption
Audit trails

[ ] Tell the tech lead (TL) that the PR exists if they wants to look at it
[ ] Anoint a lead reviewer (LR). Assign PR to LR

Review cycle:

LR reviews
Rest of team may comment on PR at will
LR assigns to submitter for feedback fixes
Submitter rebases to develop again if necessary
Submitter makes further commits. DO NOT SQUASH
Submitter updates documentation as needed
Submitter reassigns to LR for further feedback

[ ] TL sign off
[ ] LR sign off
[ ] Product Owner sign off
[ ] Assign to submitter to finalize
[ ] Submitter: Verify all tests go green, including CI tests
[ ] Submitter: Squash commits and merge to develop
[ ] Submitter: Delete branch after merge
[ ] Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
[ ] Submitter: Verify swagger UI on dev environment still works after deployment
[ ] Submitter: Inform other teams of any API changes via Slack and/or email
[ ] Submitter: Mark JIRA issue as resolved once this checklist is completed

Oops I should refresh GitHub more often since I keep repeating Rob's comments :)

firecloud-develop PR  - https://github.com/broadinstitute/firecloud-develop/pull/624

@jmthibault79 @helgridly @jmthibault79 Please hold off on reviewing - I'll let you know when I'm ready

Read for re-review!
I added 1 test, but I'm not really sure what else I can test? Open to suggestions!

re rob's comment about testing -- somewhere near the top of my list of leo things to do post-demo is get some integration testing going, be that through sbt it:test or swat in fiab.

Another idea about how to make this more testable: pull business logic out of GoogleDataprocDAO and into LeonardoService. The DAO can just have methods which call a single Google API (e.g. create cluster, update firewall, create bucket), and the business logic of combining/chaining the Google calls can live in LeonardoService. Then we should be able to do more unit testing with a mock Google DAO.
For example, the logic in createCluster() (e.g. update firewall, init bucket, create the cluster) could probably be pulled into LeonardoService and then unit tested with a mock Google DAO.

Then again the PR says coverage increased slightly? I'm not sure I believe that because most of the new code is in GoogleDataprocDAO which is not covered by tests.

It's possible the google dao has coverage-off directives. I like the idea of moving logic to the service though.

I see what happened with Coveralls. Coverage has increased slightly relative to the last commit to this branch. But it's at 66% here and 75% on develop, so it's definitely gone down. The coverage threshold is 65%, which is why it's passing.

[offtopic for this PR] Google suggests you mock out the HttpTransport and test that way: https://developers.google.com/api-client-library/java/google-http-java-client/unit-testing Probably a bunch of work to set up mocks that only ever return data we expect anyway; I'm inclined to say we should cover this with integration testing instead.

Aha, makes sense. Just above the coverage line. :) Yeah sounds good to me to cover the Google DAO with integration tests, but try to move business logic to the service class.
(Sorry for all the changes Anu. I think all of us are still figuring Leo out.)

Not ready for a full, detailed review yet - but I have some questions

Ready for a review for test strategy !
(Still some minor things like error handling and clean up that I have to do so don't bother too much about that for a few hours at least)

The test strategy looks good to me:

Call a Leo service method
Verify the response
Verify the state of the google DAO

I like that you have a case for the templating logic too.

yes i think your strategy for testing is good 👍

Ready for re-review


Update telegram-alpha to 3.0.99999,441

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

Deleted by accident.


GHC HEAD trouble

I get below errors when building with HEAD GHC
src/Indexed/Types.hs:142:10: error:
    Could not deduce (Typeable At)
      arising from the superclasses of an instance declaration
    from the context: (Data a, Typeable i, i ~ j)
      bound by the instance declaration at src/Indexed/Types.hs:142:10-55
    In the instance declaration for ?Data (At a i j)?

src/Indexed/Types.hs:193:10: error:
    Could not deduce (Typeable Coat)
      arising from the superclasses of an instance declaration
    from the context: (Data a, Typeable i, i ~ j)
      bound by the instance declaration at src/Indexed/Types.hs:193:10-57
    In the instance declaration for ?Data (Coat a i j)?

I did not analyse why this happens.

This fails in ghc-7.10.1 too, but this simplifying declaration works:
 data At :: * -> k -> k -> * where  At :: a -> At a k k
   deriving Typeable
deriving instance (Data a, Typeable (At a i j), i ~ j) => Data (At a i j)

I can't tell if the derived instance would be as useful, or if this is a sign of a bug in the Typeable machinery.

This looks like a bug. It also pulls in
{-# LANGUAGE DeriveDataTypeable, FlexibleContexts, UndecidableInstances #-}

@michaelt to get it compiling I also had to change here:
@@ -21,7 +21,7 @@
 module Indexed.Types
   (
   -- * Natural Transformations
-    (~>)()
+    type (~>)()
   , (:~>)(Nat,($$))
   -- * Limits
   , Lim

did you see this too with 7.10.1 ?

All the changes I have together so far:
diff --git a/src/Indexed/Types.hs b/src/Indexed/Types.hs
index 7af5513..bc7fb36 100644
--- a/src/Indexed/Types.hs
+++ b/src/Indexed/Types.hs
@@ -6,7 +6,7 @@
 {-# LANGUAGE RankNTypes #-}
 {-# LANGUAGE Trustworthy #-}
 {-# LANGUAGE ScopedTypeVariables #-}
-{-# LANGUAGE DeriveDataTypeable #-}
+{-# LANGUAGE DeriveDataTypeable, FlexibleContexts, UndecidableInstances #-}
 -----------------------------------------------------------------------------
 -- |
 -- Module      :  Indexed.Types
@@ -21,7 +21,7 @@
 module Indexed.Types
   (
   -- * Natural Transformations
-    (~>)()
+    type (~>)
   , (:~>)(Nat,($$))
   -- * Limits
   , Lim
@@ -139,7 +139,7 @@ instance (Monoid m, i ~ j) => Monoid (At m i j) where
 -- | Type alias for indexed monads, functors, etc. in Bob Atkey's style.
 type Atkey f i j a = f (At a j) i

-instance (Data a, Typeable i, i ~ j) => Data (At a i j) where
+instance (Data a, Typeable (At a i j), i ~ j) => Data (At a i j) where
   gfoldl f z (At a) = z At `f` a
   toConstr _ = atConstr
   gunfold k z c = case constrIndex c of
@@ -190,7 +190,7 @@ uncoat (Coat a) = a
 -- | Type alias for indexed monads, functors, etc. in Bob Atkey's style.
 type Coatkey f i j a = f (Coat a j) i

-instance (Data a, Typeable i, i ~ j) => Data (Coat a i j) where
+instance (Data a, Typeable (Coat a i j), i ~ j) => Data (Coat a i j) where
   gfoldl f z (Coat a) = z (\x -> Coat x) `f` a
   toConstr _ = coatConstr
   gunfold k z c = case constrIndex c of

That was with
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE UndecidableInstances #-}

by the way. Elsewhere we run into trouble with Coat:
 imapCoat :: (IFunctor f) => (a -> b) -> f (Coat a i) ~> f (Coat b i)
 imapCoat f = imap $ \ c -> Coat $ case c of Coat a -> f a
 {-# INLINE imapCoat #-}

Like a number of similar definitions, this yields:
Couldn't match type ‘i’ with ‘x1’
  ‘i’ is a rigid type variable bound by
      the type signature for
        imapCoat :: IFunctor f => (a -> b) -> f (Coat a i) ~> f (Coat b i)
      at src/Indexed/Functor.hs:65:13
  ‘x1’ is a rigid type variable bound by
       a type expected by the context: Coat a i x1 -> Coat b i x1
       at src/Indexed/Functor.hs:66:14
Expected type: Coat b i x1
  Actual type: Coat b x1 x1
Relevant bindings include
  c :: Coat a i x1 (bound at src/Indexed/Functor.hs:66:23)
  imapCoat :: (a -> b) -> f (Coat a i) ~> f (Coat b i)
    (bound at src/Indexed/Functor.hs:66:1)
In the expression: Coat $ case c of { Coat a -> f a }
In the second argument of ‘($)’, namely
  ‘\ c -> Coat $ case c of { Coat a -> f a }’
In the expression: imap $ \ c -> Coat $ case c of { Coat a -> f a }

@ggreif Sorry, I missed those intervening messages, I think I had the text box open for the above. If you make the changes you mentioned, does the rest of the package compile with HEAD?  As I said, it seems still to break when it gets to Index.Functor with ghc-7.10.1

Hi! any update on this build issue on ghc 7.10?

It looks like the diff by @ggrief  works for me with ghc 7.10.2. (at least compilable, haven't tested it yet)

Ah. I have this error now.
[16 of 16] Compiling Indexed.Comonad.Store ( src/Indexed/Comonad/Store.hs, dist/build/Indexed/Comonad/Store.o )

src/Indexed/Comonad/Store.hs:18:21:
    The second argument of ‘~>’ should have kind ‘u1 -> *’,
      but ‘s’ has kind ‘v1 -> *’
    In the type ‘w a ~> s’
    In the class declaration for ‘IComonadStore’


Page(s)
https://jestjs.io/docs/testing-frameworks#angularjs
Description
The link Running AngularJS Tests with Jest is not working anymore
The line of code that needs to be deleted is here
I tried to make the change but I do not want to sign the CLA, so I was wondering if someone can take over here?

I am working on it

any update on this?


Test coverage below threshold

What happened:
Building Dive on Arch Linux's PKGBUILD failed with insufficient test coverage:
==> Starting check()...
/bin/bash: line 1: git: command not found
mkdir -p ./.tmp
Running unit tests
go test -race -coverprofile ./.tmp/unit-coverage-details.txt ./...
go: downloading github.com/sergi/go-diff v1.0.0
        github.com/wagoodman/dive               coverage: 0.0% of statements
        github.com/wagoodman/dive/cmd           coverage: 0.0% of statements
        github.com/wagoodman/dive/dive/image            coverage: 0.0% of statements
        github.com/wagoodman/dive/dive          coverage: 0.0% of statements
        github.com/wagoodman/dive/dive/image/podman             coverage: 0.0% of statements
        github.com/wagoodman/dive/runtime/ui/format             coverage: 0.0% of statements
        github.com/wagoodman/dive/runtime/ui/view               coverage: 0.0% of statements
        github.com/wagoodman/dive/runtime/ui/key                coverage: 0.0% of statements
        github.com/wagoodman/dive/runtime/ui            coverage: 0.0% of statements
        github.com/wagoodman/dive/utils         coverage: 0.0% of statements
        github.com/wagoodman/dive/runtime/ui/layout/compound            coverage: 0.0% of statements
ok      github.com/wagoodman/dive/dive/filetree 1.016s  coverage: 58.0% of statements
ok      github.com/wagoodman/dive/dive/image/docker     1.028s  coverage: 41.9% of statements
ok      github.com/wagoodman/dive/runtime       1.214s  coverage: 6.3% of statements
ok      github.com/wagoodman/dive/runtime/ci    1.028s  coverage: 55.4% of statements
ok      github.com/wagoodman/dive/runtime/export        1.027s  coverage: 43.9% of statements
ok      github.com/wagoodman/dive/runtime/ui/layout     1.013s  coverage: 82.6% of statements
ok      github.com/wagoodman/dive/runtime/ui/viewmodel  1.829s  coverage: 50.2% of statements
Coverage: 31.8%
Coverage below threshold of 55.0%
make: *** [Makefile:177: unit] Error 1
==> ERROR: A failure occurred in check().
    Aborting...

What you expected to happen:
Test passes
How to reproduce it (as minimally and precisely as possible):
makepkg -s on Arch Linux's PKGBUILD
Anything else we need to know?:
Environment:

OS version: Arch Linux w/ kernel 6.8.5-zen1-1-zen
Docker version (if applicable) N/A

Then th time is required as of now when we will be able to produce


chore: add a rewrite for /demo

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
[ ] Did you follow the contribution guidelines?

PR-Codex overview
This PR focuses on adding a new rewrite rule in the vercel.json configuration file to redirect requests from /demo to an external demo application.
Detailed summary

Added a new rewrite rule:

source: /demo
destination: https://aa-sdk-ui-demo.vercel.app/

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

aight yea this doesn't work since the rest of the next calls don't get rewritten, there might be some more we can do with the rewrites, but will revisit later


Update index.html

@ravsa Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/api-machine-stacks:SNAPSHOT-PR-7


Add Lightyears ( LYS) ERC20 to Ledger list

Contract address: 0xdd41fbd1ae95c5d9b198174a28e04be6b3d1aa27
Explorer: https://etherscan.io/token/0xdd41fbd1ae95c5d9b198174a28e04be6b3d1aa27
website: https://lightyearstoken.com

Add LYS to list of tokens


improper handling of multiple sockets from same client

so, i have two sockets /errors and /db using the following configuration:
app.ws('/errors', function(ws, req) {})
app.ws('/db', function(ws, req) {
  ws.on('message', function(data) {
    dbBroadcast(ws)
  })
})
var errWs = expressWs.getWss('/errors');
var dbWs = expressWs.getWss('/db');

function broadcast(msg) {
  errWs.clients.forEach(function(client) {
    client.send(JSON.stringify(msg));
  });
}

function dbBroadcast(ws) {
  dbWs.clients.forEach(function(client) {
    if (client !== ws) {
      client.send('update');
    }
  });
}

however, if i, from a web browser connect to both with
var errorSocket = new WebSocket("ws://localhost:3333/errors");
errorSocket.onmessage = function(evt) {
  console.log('backend error:', JSON.parse(evt.data))
}

var dbSocket = new WebSocket("ws://localhost:3333/db");
dbSocket.onmessage = function(evt) {
  console.log('Update')
}

all messages sent to dbSocket (dbSocket.send('hello') for example) will send data to errorSocket, which will error in errorSocket.onmessage
broadcast() will also trigger both errorSocket.onmessage and dbSocket.onmessage
is this because of multiple connections to the same host? or how express-ws creates and handles websockets? or is it simply ment to not be this way?

I am getting similar. Mine are from multiple clients (2 command line clients on different routes).

These methods
var errWs = expressWs.getWss('/errors');
var dbWs = expressWs.getWss('/db');
are shown in the examples, but the getWss method does not take any arguments in the code.
So that feature still needs to be implemented apparently.


Fix id: is the user the plaintiff or defendant? expandable help text is in the title

Couldn't find this in another issue. In the id: is the user the plaintiff or defendant? question, the title includes the text 'How do I know', which can expand to show the explanation. It's all the same size as the header, though.

It's intended for the body of the question, right?

I think this is fixed already
On Mon, Dec 27, 2021, 11:30 AM plocket @.***> wrote:

Couldn't find this in another issue. In the id: is the user the plaintiff
or defendant? question, the title includes the text 'How do I know',
which can expand to show the explanation. It's all the same size as the
header, though.
[image: help_in_header]
https://user-images.githubusercontent.com/52798256/147490196-7fd26c1d-fd27-480d-908d-90648044fae6.png
It's intended for the body of the question, right?
—
Reply to this email directly, view it on GitHub
https://github.com/SuffolkLITLab/docassemble-AssemblyLine/issues/354,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2KTSO3TC2IJZJNU5KJJWLUTCIADANCNFSM5K2TTDUQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

My bad, was on the PR branch and didn't realize main had been updated separately.


Search by group name in group options.

I have a lots of groups and data in a table. i want to search by group name as well as by data. is it possible to do that?

You will have to implement your own search and disable the internalSearch. See example: https://monterail.github.io/vue-multiselect/#sub-asynchronous-select

Hi, @shentao - the example link is broken for me, please do you have a working link or a little advice on how to get started on searching by group name? Thank you

Why did you close ? It would be a nice enhancement to have this natively


Adds RCON specific arguments to support the RCON Protocol

Merged to include it in the 1.2 release


Specify in documentation: FORWARD AND NAT RULES.

Hi ESP Team,
I not appear/view in documentation for ESP FORWARD keyword.
I think is necessary to specify lines for FORWORD and NAT for deploy correctly OS target.
Ref:  https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/4/html/security_guide/s1-firewall-ipt-fwd
sysctl -w net.ipv4.ip_forward=1

ESP does touch or create firewall rules.  If the firewalls had to be changed it's because of something else on the system making those firewall rules.


No unsupported system alert

Brief description of your issue
There is no unsupported system alert.
Steps to reproduce (optional)
Turn on kernel mode in the latest version of Windows 11
Expected behavior (optional)
An alert appears tells your system is not supported
Actual behavior (optional)
Nothing happens
Environment (optional)
SI 3.0.6226, Windows 11 Latest

Would you like to share a screenshot of that system alert?

I think there is a popup that shows your system is not supported, and it is not showing up rn.

Code do check whether the system is supported

32-bit XP and Vista are not supported.

An alert appears tells your system is not supported

You probably executed the 32bit binaries which is not supported.

There is no unsupported system alert ... Windows 11 Latest

Windows 11 is supported and there are no alerts.

I mean the kernel mode unsupported notification, not the software

If you click "kernel mode" in windows 11 and restart, driver not loaded and no warnings.

There's no prompt because the driver supports Windows 11 but doesn't support insider builds and insider builds are Windows 11.


ObjectStore Treats Redirect Responses as Success

Describe the bug

reqwest::error_for_status_by_ref treats a 300 response as a successful request.
To Reproduce

Currently there is a bug where if S3 has the wrong region, it receives a redirect response which doesn't get handled correctly. This gets interpreted as a success.
Expected behavior

An unhandled redirect should be an error
Additional context

Actually this relates to TLS


ENH: overwrite the bounds in lf to be consistent with the arguments specified in the model

Closes #1930

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.005%) to 91.973%

Files with Coverage Reduction
New Missed Lines
%

src/cogent3/core/alignment.py
1
93.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
30285

Relevant Lines:
32928

💛  - Coveralls


TN-731 fix references to organizations with urlencoded system identifiers.

Thanks to complexity of encoding system and value parameters, use
a more reliable path variable for organization id_or_value and
pass the system only as a query string parameter.

Hello @pbugni! Thanks for submitting the PR.

In the file portal/views/organization.py, following are the PEP8 issues :

Line 175:13: E122 continuation line missing indentation or outdented
Line 176:13: E122 continuation line missing indentation or outdented
Line 177:13: E122 continuation line missing indentation or outdented
Line 178:13: E122 continuation line missing indentation or outdented


The signature does not match

Hi,
I Facing this error message
"The signature does not match"
My credentials are fine and correctly passed at init.
If you have idea ?
many thanks ion advance

I have found the issue in signData()
line 412
replace with
parsedUrl.path() + (parsedUrl.query() != '' ? '?' : '') + parsedUrl.query(),
because when querystring is empty signature is done with ?

Apologies on the delay, I missed this somehow. Appreciate the note. I have a few minor bug fixes I've been meaning to make, and I will add this to the list. Much appreciated.


Try generate PowerShell profile modifier without templet files

This PR is related to #8948 , which added a PowerShell module.
The module is aimed to provide a tool for each psmodule-like app to edit PowerShell profile, but all of them needs templet files created in advance, so I added a function to generate files without template.

[x] I have read the Contributing Guide.

/verify

@issaclin32 Thanks, the script might be OK now.


csvstat and u'\xd6' character

Hi,
in this csv file I have  u'\xd6' character (in "Öffentliche Bibliothek").
When I run:
csvstat csvstat_test.csv > out.txt

I have
'ascii' codec can't encode character u'\xd6' in position 24: ordinal not in range(128)

Is there some way to "transform" the csv file and avoid the error?
Some notes about my csv file. These are two rows of nearby 14000, I have extracted two of these that have inside these kind of characters.
I'm using csvkit 0.9.1.
Thank you

I don't get that error on the unreleased version of csvkit. You can install it with:
pip install -e git+git://github.com/onyxfish/csvkit.git@master#egg=csvkit

Hi @jpmckinney I have just updated to 1.0.0, and I have the same result.
If I run
csvstat csvstat_test.csv > out.txt

I have
'ascii' codec can't encode character u'\xd6' in position 31: ordinal not in range(128)

Thank you

The file I downloaded from that gist doesn't produce any error. Can you download and try with that file? It's possible GitHub is changing the encoding such that it's not the same as your local file.

Hi @jpmckinney ,
with
 curl -s "https://gist.githubusercontent.com/aborruso/0dd1f52b289c4cd09028/raw/025f24b228da602e1eefa4ed0ead160d3dcc7708/csvstat_test.csv" | csvstat > out.txt

I have always the same error. Could it be for the Python version?
I have "sys.version_info(major=2, minor=7, micro=6, releaselevel='final', serial=0)".
Thank you

@jpmckinney it could be related to this kind of python 2 problem, but I'm not able to apply the solution to csvkit.
Thank you

Ah, yes, this may be related to #574

I just committed a fix for #574. Please reinstall csvkit and let me know if the error still occurs:
pip install -e git+git://github.com/onyxfish/csvkit.git@master#egg=csvkit

Thank you @jpmckinney but unfortunately I have the same error.

Weird. If you remove the > out then it runs:
 curl -s "https://gist.githubusercontent.com/aborruso/0dd1f52b289c4cd09028/raw/025f24b228da602e1eefa4ed0ead160d3dcc7708/csvstat_test.csv" | csvstat > out.txt

I found the solution. I can no longer reproduce the issue with > out. Please let me know if there's still a problem after reinstalling.

Wow it works!!!!
I'm very happy to be in some way useful to this very great project

Thanks for reporting the issue, @aborruso ! One less bug :)


Quality Assurance: Inconsistent spacing in drop-down menu

The icons and menu buttons are inconsistently spaced in dropdown. e.g. The V in View Source and R in Reply are not vertically inline. The icons seem to be different sizes.

I don't think they are supposed to be. You can look at the user_sidebar_popover and message_info_popover and both are not aligned also.

Yeah, I think it'd be nice to align them.  We should fix all the actions popovers together.

I think the problem is that we are not using monospace fonts. Maybe we could use something like a table to align them.

Yeah, that makes sense.

I can take this up, I am thinking of going with the table as suggested by @tommyip . Is it alright?

Seems worth trying!
-Tim Abbott (mobile)
On Dec 31, 2016 12:59, "Mahim Goyal"<EMAIL_ADDRESS>wrote:

I can take this up, I am thinking of going with the table as suggested by
@tommyip https://github.com/tommyip . Is it alright?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/issues/3010#issuecomment-269881724, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACnm2jLD8opLi_5T4aFHiFppRGBMg_abks5rNsIjgaJpZM4LYYzM
.

I got them aligned using table, but the rows lost some its properties.
The hover over hyperlink now only gives a underlined look rather than its earlier row highlighted type selection. I can maybe try defining new style properties to make it like before.

 Here my cursor is on Reply icon.
How should I proceed forward.

Yeah, you should fix the CSS to preserve the existing highlighting behavior.

Also, I think we may want to center the icons within the left-side table (rather than their current setup being left-aligned)

A small clarification, can I add the style in \static\third\bootstrap\css\bootstrap.css itself, or do I need to do that in some other css files and leave the bootstrap untouched.

I would rather override the bootstrap styles in our own CSS files.

Yeah, we should definitely do changes in our own CSS.  We're eventually going to either upgrade or remove Bootstrap, and in either case changes to bootstrap itself will create more work down the line.

Is this fine, my cursor is on View Source cell.

That highlighting doesn't look right; if the highlighting isn't going to go fully across the page, it should at least look centtered within the view

Sure, will make it right.

This is the final look. In first image the cursor is on the text and in the second one it is on the icon, there is no difference whatsoever. I had to remove the hyperlink text color because if the cursor was on the icon, it would only change the color of icon rather than the text too, similar thing happened when the cursor was on text. I believe the background change is fine enough for the hover. But still if we want the color change I think the change will have to be made in the script rather than the style. I hope this looks good!

@timabbott Is there any changes I need to make to these?

It definitely looks visually a lot cleaner @mahim97! I'm not sure if we want to proceed in the future using tables instead of making a component out of this, but for now it looks like a solid visual improvement and good for merging in.

@brockwhittaker I made a few changes in CSS for the padding, while doing so I even changed the hover style. Now it looks completely like before.

This looks great @mahim97! The margin on the side of the popover seems to be too wide, it is possible to narrow it?

@tommyip Yes, it can be reduced. I reduced it a bit, how does it look?

It would be great if someone could review my PR #3163 .

Reopened this since we just reverted the fix from #3163 due to breaking hotkeys.


Links in emails should use customizable scheme

The emails currently use hardcoded "http://" schemes for ticket addresses:
https://github.com/rossp/django-helpdesk/blob/master/helpdesk/models.py
It would be better to be able to configure this, since most helpdesk installations will use HTTPS nowadays.

Suggest relying settings.SECURE_SSL_REDIRECT as we don't have a request at time of sending many of these emails. Will need to ensure we've got documentation that reflects this.

This is already done: https://github.com/django-helpdesk/django-helpdesk/blob/761b91d2fe55d42ff767b8dc617925425f27fa6f/helpdesk/models.py#L733


docs: add client flags to examples in clustering.md

reviewed this with Yicheng Qin who thinks its good

re: "remove http://<IP_ADDRESS>:2379?"
if you prefer removing it that's fine.
I added it because without it, etcdctl does not work without adding a --peers option or ETCDCTL_PEERS env variable. So it kind of makes it a complete example without hidden stumbling blocks for the average person who is trying to create an etcd2 cluster from the example.

i think you are right that adding http://<IP_ADDRESS>:2379 can faciliate etcdctl usage. could you squash and change the commit title to docs: add client flags to examples in clustering.md?
lgtm
/cc @xiang90 @barakmich

LGTM


Replace the WordPress.WhiteSpace.PrecisionAlignment sniff

... with a similar sniff as merged upstream in PHPCSExtra as Universal.WhiteSpace.PrecisionAlignment.
The upstream sniff has various improvements, including:

Detecting precision alignment in the leading whitespace for PHP 7.3 flexible heredoc/nowdoc closing identifiers (was false negative).
Improved handling of (trailing) whitespace on otherwise blank lines, both in code as well as in comments and HTML. This will now be ignored by default. (was false positive).
An additional option to report on precision alignment for whitespace found on otherwise blank lines (not relevant for WP as the Squiz.WhiteSpace.SuperfluousWhitespace is used).
And it also includes a fixer. Note: the fixer works based on "best guess" and may not always result in the desired indentation.

Ref:

PHPCSStandards/PHPCSExtra#119
PHPCSStandards/PHPCSExtra#122
PHPCSStandards/PHPCSExtra#123
PHPCSStandards/PHPCSExtra#124

I'm wondering how WPCS can be sure that the Universal sniff defaults match what is wanted for WP, both now and in the future (when the Universal sniff may change) (other than the fact you're the developer of the Universal sniff...)

Well, to start, the default public property values are "sensible" (minimal) values, so I see no reason why these would ever need to be changed for this sniff.
Secondly, any change to the default values of the public properties would be a BC break and can only be made in a major release and has to be clearly annotated in the changelog (semver).


Create an example project

Packages usually contain an example folder in the root folder that demonstrates how the package works.
We should create a new flutter project in the example folder.

Here is another package you can refer to as an example:
https://github.com/suragch/audio_video_progress_bar


[BEAM-7271] adding UTF8 String coder to Java SDK ModelCoder

adding UTF8 String coder to Java SDK ModelCoder

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

 Looks good to merge, but please keep the key encoding for Flink's state backend unchanged.

@mxm This PR only fails in Python 3 postcommit tests. I guess it's related to type handling difference between Python 2 and Python 3. Will look into it.

run python postcommit

run java postcommit

run python postcommit

run java postcommit

run python postcommit

Thanks @ihji. Looks good. I'm going to merge #8472, then we can merge this PR.

@ihji Please rebase to master. Will merge then.

Done. Just found out, that I also can do this.

Run Java PreCommit


Extra spaces on command line interpreted as part of file name

When a command expects a file or directory name, any extra spaces around it are interpreted as part of the name. I am not sure if this is a bug or a feature, as there seems to be no other way to address names starting or ending with a space.
For instance, when using the load command with a cart file name, an extra space before or after the name causes it to fail with cart loading error.

now TIC trims input string if detects extra spaces on the start/end
done in .29


Remove mm_config and mm_license global state from webapp (PR #2)

Summary
This is a subset of the changes in the MM-8589-remove_mm_global_license branch, broken up into multiple PRs to facilitate easier review. See any linked PRs for other changes if you're interested.
These changes, as a whole, move towards removing our dependence on the global mm_config and mm_license objects. These changes will ultimately facilitate resolving https://mattermost.atlassian.net/browse/MM-8604, allowing us to stop hard refreshing the application whenever someone makes a configuration change.
Ticket Link
https://mattermost.atlassian.net/browse/MM-8589
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)

Related PRs
https://github.com/mattermost/mattermost-webapp/pull/816
https://github.com/mattermost/mattermost-webapp/pull/820
https://github.com/mattermost/mattermost-webapp/pull/821
https://github.com/mattermost/mattermost-webapp/pull/822
https://github.com/mattermost/mattermost-webapp/pull/823

Thanks, @saturninoabril! I've rebased and resolved some feedback from parallel reviews (re: ...ownProps and get(Config|License) selector).
@crspeller, I had to rework the getImageSrc you added and opted to just pass in the hasImageProxy where it was used vs. relying on the global state. In general, while these utilities functions can theoretically just getState() for themselves, it's harder to unit test the react component since you have to mock the store in two places now vs. just the wrapping <Provider>. Let me know if you have any concerns re: https://github.com/mattermost/mattermost-webapp/blob/30e9b3b6b67638f6de10d330ed89add1eb67275c/utils/post_utils.jsx#L45-L50

Well I don't have any concerns about that. But that was actually other Chris: @ccbrown

Oops! Thanks for reviewing anyway :)


fix #31 - Escaping HTML in messages

HTML blocks are supported by OMD, so before producing the HTML, we go through the syntax tree and replace all HTML occurrences with CODE occurrences (in block and inline).
(cc @leonard-IMBERT)

I'va made a comment in the code but I've just realised it's maybe better to put it in the general discussion

After some though an research it seems that markdown should allow for html tag to be displayed (at least following the CommonMark spec. A discussion in that goes way back from 2015 up to 2020 hint that there is still no consensus on the subject. I think It's really a choice we have to make framework wise, do we assume the fact that we ban the usage of html tags, diverging from the CommonMark standard or we implement/use some sanitization frameworks.
Here some allready existing frameworks:
* One in [haskell](https://github.com/yesodweb/haskell-xss-sanitize)

* One in [javascript](https://github.com/cure53/DOMPurify)

One way to do a custom implementation would be to try to detect js in tag, (basically a js parser and if we detect valid javascript, we escape the tag. This could (and should probably) be done server-side just before registering the message in the database.

It seems it also exist a HTTP header for that, in case one day, the html tag are allowed