Stackedsax add quickstart

Here's a quickstart guide and a helper script for minikube from Jonathan to test.
Unfortunately, the guide relies on the updated helm chart being available, and that's pending in this PR:

https://github.com/G-Research/charts/pull/7

So, for now, you'll have to pull the chart down locally and install it.  Instead of step 4:
helm repo add gresearch https://g-research.github.io/charts
helm upgrade --install siembol -n siembol -f https://raw.githubusercontent.com/G-Research/charts/0ac159d72a4fe842e3034834c3e8a9f7a5b47989/src/siembol/quickstart-values.yaml gresearch/siembol

You could just try
wget https://github.com/G-Research/charts/blob/0ac159d72a4fe842e3034834c3e8a9f7a5b47989/siembol/siembol-0.1.1.tgz
helm upgrade --install siembol -n siembol -f https://raw.githubusercontent.com/G-Research/charts/0ac159d72a4fe842e3034834c3e8a9f7a5b47989/src/siembol/quickstart-values.yaml siembol-0.1.1.tgz

We should also add a few first steps, like browsing to the URL of the UI (maybe both as part of the Helm chart output and the guide), and then maybe a little tutorial of how to create and test a rule.

I added a line to the quickstart.md to go to https://ui.siembol.local/home.  I could print that in the NOTES.txt, too, except those notes should be dynamiclly generated and I don't see how I would get the doamin name from kubectl.  This is all that I get back from: kubectl get --namespace siembol services siembol-config-editor-ui -o jsonpath="{}"
{
    "apiVersion": "v1",
    "kind": "Service",
    "metadata": {
        "annotations": {
            "meta.helm.sh/release-name": "siembol",
            "meta.helm.sh/release-namespace": "siembol"
        },
        "creationTimestamp": "2021-06-15T20:48:45Z",
        "labels": {
            "app.kubernetes.io/managed-by": "Helm"
        },
        "managedFields": [
            {
                "apiVersion": "v1",
                "fieldsType": "FieldsV1",
                "fieldsV1": {
                    "f:metadata": {
                        "f:annotations": {
                            ".": {},
                            "f:meta.helm.sh/release-name": {},
                            "f:meta.helm.sh/release-namespace": {}
                        },
                        "f:labels": {
                            ".": {},
                            "f:app.kubernetes.io/managed-by": {}
                        }
                    },
                    "f:spec": {
                        "f:ports": {
                            ".": {},
                            "k:{\"port\":80,\"protocol\":\"TCP\"}": {
                                ".": {},
                                "f:name": {},
                                "f:port": {},
                                "f:protocol": {},
                                "f:targetPort": {}
                            }
                        },
                        "f:selector": {
                            ".": {},
                            "f:app": {}
                        },
                        "f:sessionAffinity": {},
                        "f:type": {}
                    }
                },
                "manager": "Go-http-client",
                "operation": "Update",
                "time": "2021-06-15T20:48:45Z"
            }
        ],
        "name": "siembol-config-editor-ui",
        "namespace": "siembol",
        "resourceVersion": "1074",
        "uid": "bd9a78f3-f0a6-4d22-95ee-faacacc48b4c"
    },
    "spec": {
        "clusterIP": "<IP_ADDRESS>",
        "clusterIPs": [
            "<IP_ADDRESS>"
        ],
        "ports": [
            {
                "name": "http",
                "port": 80,
                "protocol": "TCP",
                "targetPort": 8080
            }
        ],
        "selector": {
            "app": "siembol-config-editor-ui"
        },
        "sessionAffinity": "None",
        "type": "ClusterIP"
    },
    "status": {
        "loadBalancer": {}
    }
}

No references to .local in there.  I looked through some other bits of k8s config, but didn't see anything that I could cue off of. Am I missing something obvious?

No references to .local in there. I looked through some other bits of k8s config, but didn't see anything that I could cue off of. Am I missing something obvious?

I think you should use something like https://{{ .Values.ui.ingress.hostname }}/home.

Hi @stackedsax,
We have modified charts and wrote quickstard guide that was based on this PR. This PR is not needed.
Thanks,
Marian


Replace catalog/refresh call with catalog/load

Fix #632
There is an issue with the catalog/refresh store method which causes it to repeatedly load the index of each cluster repository. I've replaced that method with catalog/load which will only fetch the index once per repo.
https://github.com/rancher/kubewarden-ui/assets/40806497/f8d73ba2-8861-41d5-a58f-33d59e1f8d44

App Version: ... label does not always show:
Screencast from 2024-02-29 17-26-29.webm

@kravciak There was an issue with fetching the deployment by label selector, I've changed the version computed property to point to the appVersion of the installed app rather than the deployment. This should fix that issue.

Seems the tests will fail for Pods fetched with the kubewarden/policy-server selector as well, I suppose I have to go back to the old way of fetching those unfortunately.

I tried it locally and you are right,  I see App Version but resource stats are gone.

That's strange because I can not replicate this behavior on my system, but if you and the tests are encountering it there must be something else going on with the findMatching action.


Providing a lot of dll files ends up as stack overflow

Using a response file and providing 10k or so dlls to run will result in StackOverflow in vstest.console.exe. There is no report of where it is happening.
This is unlikely to happen to anyone, but it might be highlighting some possible perf improvement.

Having the same issue. With 216 assemblies it works, but with 217 in the response file I get "Process is terminated due to StackOverflowException"
Running latest vstest.console.exe shipped with VS 2022 Enterprise Edition from Developer Command Prompt for VS 2020:
vstest.console @test.rsp

Mkay.
  All rights reserved.

Process is terminated due to StackOverflowException.

Actually only p1.dll - p55.dll is enough on my system to SO.

This is a side effect of the argument processor and argument executor design.
Argument processor in vstest is responsible for parsing out an argument that you provide on commandline.
And Argument executor is acting on the argument.
So in this case ArgumentProcessor for TestSource is created 220 times, and every time it wraps the argument executor in a lazy wrapper, capturing the argument value (the dll path) as a closure.

is this a pressing issue for you @acerock?

This would require changing architecture of argument processor and won't be implemented, we are focusing on adding new features to Testing.Platform instead.  https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-intro?tabs=dotnetcli


[$1000] “Send link” text in get your secure link page goes out of box

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/ or new.expensify.com
Go to any workspace and connect bank account,
Add all bank, company and personal information
After selecting country while issuing documents
Go to get secure link, and get link via sms
Type country code  and valid cell number and click send link

Notice that the text “ send link” goes out of the box after clicking button.
Expected Result:
“send link” text should not go out of the button container.
Actual Result:
After clicking send link button, the displayed text goes out of border.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] MacOS / Chrome

Version Number: 1.2.64-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/216417717-5d2edd51-b342-41db-9adf-85cd7fe37502.mov
https://user-images.githubusercontent.com/43996225/216417940-781f40f4-8e49-45f6-91c3-66e3a93acc21.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675344409468369
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01036f1bc43829f648
Upwork Job ID:<PHONE_NUMBER>295955968
Last Price Increase: 2023-02-10

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

@michaelhaxhiu 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

First thing I'll do tomorrow!

Woof, finally reproduced this one!

Bug checks out, seems easily external so I'm going with that.

Job added to Upwork: https://www.upwork.com/jobs/~01036f1bc43829f648

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

Triggered auto assignment to @joelbettner (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal already posted above 😸

Proposal
Please re-state the problem that we are trying to solve in this issue.
Send link button is not properly grouped with input and text overflows.
What is the root cause of that problem?
Send link button is not correctly grouped with the input due to an incorrect border-radius and button text overflows due to less width.
What changes do you think we should make in order to solve the problem?

I prefer to raise an issue with the onfido-sdk-ui over applying Onfido styles in our application, considering the same I have raised the issue here.

@michaelhaxhiu, @joelbettner, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@michaelhaxhiu, @joelbettner, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@0xmiroslav any update on the proposals provided yet?

@michaelhaxhiu @joelbettner @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Going to check internally on the latest process we have defined for upstream repo fixes, and how to guide those forward. Meanwhile @joelbettner do you agree with this approach of going upstream (just to make sure before we double down on it).

Ok I found our latest (internal) process for handling upstream repo fixes. It's viewable for internal expensify employees - https://stackoverflowteams.com/c/expensify/questions/12761
Buddy check - is the person (below) the maintainer of the onfido-sdk-ui repo?
https://github.com/DannyvanderJagt
I see they merge almost every commit so that's how I deduced it. Is there an easier way to pinpoint the repo maintainer?

@michaelhaxhiu @joelbettner @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@michaelhaxhiu, @joelbettner, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Okey doke. I've been looking into this a bit. It appears that this entire ui is imported, and we don't actually have any of the code in our repositories. This would require a fix like @Pujan92 suggested here in the onfido-sdk-ui repository, or for us to fork the repository and add it to our code base.
@roryabraham correct me if I'm wrong, but I do not think forking (and then maintaining) the repository is worth it for this.
Should we reach out to the maintainer of the onfido-sdk-ui repository? I've read the SO, but I'm still not entirely sure how the process works.

@joelbettner I think an upstream fix via patch-package could be a good option here.

Coming from the conversation here...
We pay Onfido for their services. We should not be fixing their bugs/issues. We should just insist that the owners of the onfido-sdk-ui repo fix the bug since we pay for it.

gentle bump @michaelhaxhiu

Sorry for the delay, looking now.

Yep this will be my first time trying to get an upstream fix by way of persuasion (we lucked out on other GHs in prior months and the repo maintainer responded fast / without nudge).
@joelbettner can you confirm this for me real quick?

Buddy check - is the person (below) the maintainer of the onfido-sdk-ui repo?
https://github.com/DannyvanderJagt

Once I get a quick 👍 on this, I'll reach out today as outlined in the S/O guidance post for upstream fixes, here

It appears GitHub does not provide a way to show who is a repo owner or maintainer.
I think you're good starting with DannyvanderJagt.
If that ends up being a dead end, I'd try to contact the owners of the GitHub organization for Onfido. I tracked them down here:

@michaelhaxhiu @joelbettner @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

@michaelhaxhiu, @joelbettner, @thesahindia, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

blocked on me still, will get to this soon!

Any luck?

I tried to get some update on it by tagging one of the engineer in the comment here, as per their reply it is raised internally and for urgency, Expensify can contact Customer Support.

@michaelhaxhiu, @joelbettner, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

Okay! I found the repo maintainer's email address (Danny) and reached out. Hopefully we hear back, and I have some other things I could try if no response!

@joelbettner do you think it makes sense for me to email Onfido support directly too?
Coming from this person who commented on Pujan's GH: https://github.com/onfido/onfido-sdk-ui/issues/2145#issuecomment-1474289537

@michaelhaxhiu, @joelbettner, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

No response from danny. Bumping the email thread and offering $1000 as we suggest in the internal SO guidance post

Just reached out to Onfido support too:

Madhi responded to me today, and asked for more context on the problem we are trying to fix. I shared those details and mentioned we are open to sponsoring / compensating external libraries too.

Onfido support is stepping in too, they said they'll try to help as best they can. 🤞

@michaelhaxhiu, @joelbettner, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Forgot to post - about 5 days ago I got this response from Customer Support:

Hello Michael,
I am part of the Product Support Team at Onfido. Your ticket has been escalated to me and I will be assisting with your query.
The Gitlab issue raised by you is already being discussed internally. I'll keep you updated once I hear more progress regarding this.
Thank you for your patience and understanding.
Kind Regards,
Priyanka

Hi 👋 Thanks for all the effort in reaching out to Onfido! I've made the fix and it will be released in the next version (v12.2.0, scheduled mid April). See Github issue
For any future support feel free reach out to our customer support directly.

📣 @DannyvanderJagt! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Thanks so much @DannyvanderJagt!

@michaelhaxhiu, @joelbettner, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@michaelhaxhiu, @joelbettner, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

Still not overdue. Still waiting for mid-April release to be able to test.

☺

@michaelhaxhiu, @joelbettner, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@michaelhaxhiu, @joelbettner, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Upwork job price has been updated to $4000

@Pujan92 Any update since you started testing last week?

@0xmiroslav does it work smoothly after clicking the send link button too? Before it used to go out of the box after clicking.

Just to highlight for Spanish the text Enviando not goes outside but reaches to end of the button space.

This looks like its all good to me. @michaelhaxhiu I'll leave the final decision up to you. If you think it looks good we can close it out.

So just to confirm:

Pujan was the contributor that helped deliver the fix (upstream)
Miki did the necessary C+ work to review
ashimsharma10 was the bug reporter

I'm not sure if a pricing bonus would apply in this scenario given it was merged upstream rather than locally?

@joelbettner why wouldn't we fix the text in the button that Pujan brought up in the comment above?
I think it will surely get reported as a bug if we don't fix it, and it was linked to this change right? Perhaps it's not a regression at heart, but should we fix it as part of this job anyway?

@0xmiroslav @joelbettner PR is ready for review!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.8-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/18050

If no regressions arise, payment will be issued on 2023-05-09. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@0xmiroslav] Determine if we should create a regression test for this bug.
[ ] [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

This has been a pretty long winded job, but it's close to completion. I'm OOO starting tomorrow and need a buddy to help issue the payments this week. Re-assigning label for that reason.

Assigning myself just to stay tuned. 🙇

@garrettmknight just to inform I am not able to apply for the Upwork job as it is no longer available.

New job created and all have been invited. Reassigning to pay once they accept since I'm also headed OOO.

Readding hax since he wanted to follow.
@NicMendonca can you pay this out once they accept the jobs? Thanks!

Here's the new job! https://www.upwork.com/ab/applicants/1656602649094008832/suggested

Here's the new job! https://www.upwork.com/ab/applicants/1656602649094008832/suggested

@garrettmknight seems this is a wrong link.

Try this link: https://www.upwork.com/jobs/~01e2b09551bfe1f0f7

Applied, Thanks!

@ashimsharma10 don't forget to apply for reporting bonus! https://www.upwork.com/jobs/~01e2b09551bfe1f0f7
@Pujan92 @0xmiroslav - I've extended the offers!

@0xmiroslav paid - thank you!

@Pujan92 please accept the offer when you can!
@ashimsharma10 don't forget to apply for reporting bonus! https://www.upwork.com/jobs/~01e2b09551bfe1f0f7

@NicMendonca Accepted!

@Pujan92 paid - thank you!
bump bump @ashimsharma10 don't forget to apply for reporting bonus! https://www.upwork.com/jobs/~01e2b09551bfe1f0f7

@ashimsharma10 paid! Thank you everyone!


Very long text is not rendered  (tested with text of 14,8k characters)

See attached screenshot:

To reproduce add to TutorialMessageFactory static messages a couple ("text", "<text from attached file>").
longstring.txt
File contains 14810 characters and 2081 words.

But if I rotate the device to landscape - text appears; and when I rotate the device back to portrait orientation - text disappears!

Happens as well on landscape with the given text doubled. Looks like UITextView is sized correctly.

@weyg it actually renders on real devices

@weyg it actually renders on real devices

Closing an issue then.
@diegosanchezr Thank you for feedback!


feat: add task skinDeployFiles

Checklist

[ ] the individual contributor license agreement is signed
[ ] commit message follows commit guidelines
[ ] documentation is changed or added

Description of change

Add a new task, skinDeployFiles, so that skin development does not require Tomcat restarts and tomcatDeploy.

Downloaded changes and successfully ran ./gradlew overlays:uPortal:generateSkins -DskinName=dummy to generate new dummy folder and dummy.less under overlays/uPortal/src/main/webapp/media/skins/respondr foldder


Fixes Pytest Coverage

Description
Coverage was bumped to 5.0 which now uses a SQL database rather than a file for .coverage. We switch to --parallel-mode here to build a new database per process which is then automatically merged.
I have also deleted the examples folder as it is noticeably out of data and we have similar examples many places in the documentation.
Changelog description
Fixes a testing subprocess routine when coverage is enabled for coverage 5.0 breaking changes.
Status

[x] Code base linted
[x] Ready to go

Will this affect engine or elemental?

It would only effect engine if you ran coverage on your CLI tests which you do not appear to do.


(React) o is undefined when using render props

<MaskedInput
  mask={['(', /[1-9]/, /\d/, /\d/, ')', ' ', /\d/, /\d/, /\d/, '-', /\d/, /\d/, /\d/, /\d/]}
  placeholder="Enter a phone number"
  id="my-input-id"
  render={(ref, props) => (
    <MyStyledInput innerRef={ref} {...props} />
  )}
/>

const MyStyledInput = styled.input`
  background: papayawhip;
`;

This code block is from examples but it doesn't work.

Changing innerRef to ref solves the problem.
It's about newer versions of React.


Redis health check

Shamelessly lifted from
https://github.com/kubernetes/charts/blame/master/stable/redis/templates/deployment.yaml.
Will verify and revise once I'm home and back on the work vpn.

I actually read TFD and confirmed that failing the liveness probe will cause a container restart: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/. Failing the readiness probe will take the pod out of the k8s load balancer, which should be useful once we get around to adding HA.

What's the failure mode when there are no nodes in the k8s load balancer pool?

Looks like connections to a service with no pods times out. Since this story is just about restarting an unhealthy redis instance, I think I'll just drop the readiness probe for now.


Stop binding type predicate types twice

checkTypePredicate was doing the same work bindChildren ended up doing, which caused a container type in a predicate to get its nextContainer set to itself, causing an infinite loop elsewhere.
Fixes #22076

:+1:


Add action "backspace" for insert mode.

This one is pretty simple, and if I'm being honest, stolen straight from emacs' dired:
In insert mode, If the prompt is empty and the user types <bs>, go to parent dir. If there is any user input in the prompt, then behave as normal.
This pairs very nicely with the new path_prompt feature.
https://user-images.githubusercontent.com/7228095/227717450-1113e881-4eca-4a0f-b0e8-1ac2b9f587a9.mov

Cool! Thought about this on your earlier PR as well. From quick glance LGTM, thanks :)
Slight note: should we add a selection callback (sorry on mobile, check other actions please) to retain selection on the directory the user is coming from? I think makes for a good default.

Slight note: should we add a selection callback (sorry on mobile, check other actions please) to retain selection on the directory the user is coming from? I think makes for a good default.

I like this idea. Currently goto_parent_dir doesn't implement this either so it'd probably make more sense to make that change there, probably in a separate PR. I'll take a look into that after I type this comment out.

Also, for my educational purposes, I'm wondering about the nvim_feedkeys's escape_ks argument. I can't find anything in the docs specifically about escape_ks  but under nvim_feedkeys it says:
This should be false if you already used |nvim_replace_termcodes()|, and true otherwise.

This PR's using escape_ks = true despite using nvim_replace_termcodes. It appears to work just fine but I'm wondering if there's a reasoning behind it.

Also, for my educational purposes, I'm wondering about the nvim_feedkeys's escape_ks argument. I can't find anything in the docs specifically about escape_ks but under nvim_feedkeys it says:
This should be false if you already used |nvim_replace_termcodes()|, and true otherwise.

This PR's using escape_ks = true despite using nvim_replace_termcodes. It appears to work just fine but I'm wondering if there's a reasoning behind it.

So, to be honest, no. I tried a handful of different combinations to get the behaviour working - the trick was the mode flag to make it a non-recursive mapping. I just forgot to flip this back to what the docs advise.
Just tested and it works exactly the same, so 🤷🏼

LGTM thanks


ExtensionView problem

I set "NO" for "View controller-based status bar appearance" in info.plist.   I get a image browser, which will be shown full screen without status bar if anyone tap on a picture in app.   So I set [UIApplication sharedApplication].statusbarHidden = YES in viewWillAppear, set [UIApplication sharedApplication].statusbarHidden = NO in viewWillDisAppear in ImageBrowser view controller. But if i do that, the extensionview in tlyshynavbar will got a layout problem. It will be upper than before, 20px of it hide under the navibar.

Thanks for reporting! I've done some major changes in the way the the library calculates the positions of the nav bar and extension view, so this might be resolved.
If you can test against master, or wait till v0.10.0 is live on cocoapods, I'd really appreciate that.


auto-submit failing to merge prs that have already been submitted

auto_submit: Failed to merge pr#: 1806 with OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Pull Request is not mergeable, locations: [ErrorLocation(line: 2, column: 3)], path: [mergePullRequest], extensions: null)])

\cc @keyonghan

A failure in a single PR block all the others from landing.

This is a dup of https://github.com/flutter/flutter/issues/102317

Reopening as preventing errors on the merge step may require different steps.


dmenu freeze

I experience few times across 6.1 and 6.2 sudden random freeze when launching apps from dmenu, everything blocked, can't switch tty, can't move cursor, can't type anything.
This is all I got from log:
 DEBUG [layout::commands] src/layout/commands.rs:374 Layout.SwitchWorkspace("2")
 TRACE [layout::actions::workspace] src/layout/actions/workspace.rs:79 Switching to workspace 2
 TRACE [layout::actions::workspace] src/layout/actions/workspace.rs:44 Adding workspace Workspace { name: "2", geometry: Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 1080 } }, fullscreen_c: [], id: Uuid("1f0ed350-ff38-45bf-9d0d-397537c8f9b6") }
 TRACE [layout::core::graph_tree] src/layout/core/graph_tree.rs:508 Normalized edge weights for: NodeIndex(1)
 INFO [layout::core::graph_tree] src/layout/core/graph_tree.rs:240 Added new child NodeIndex(5) for Workspace { name: "2", geometry: Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 1080 } }, fullscreen_c: [], id: Uuid("1f0ed350-ff38-45bf-9d0d-397537c8f9b6") }
 TRACE [layout::core::graph_tree] src/layout/core/graph_tree.rs:508 Normalized edge weights for: NodeIndex(5)
 INFO [layout::core::graph_tree] src/layout/core/graph_tree.rs:240 Added new child NodeIndex(6) for Container { layout: Horizontal, floating: false, fullscreen: false, output_handle: WlcOutput { handle: 1, name: "eDP-1", views: [WlcView { handle: 2, title: "Code School Free Weekend | Code School - Mozilla Firefox", class: "Firefox" }] }, apparent_geometry: Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 1080 } }, geometry: Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 1080 } }, id: Uuid("f785e646-b443-4cc9-a433-173b9bec5df3"), borders: Some(Borders { title: "", surface: ImageSurface(Surface(0x7ffb471d0080)), geometry: Geometry { origin: Point { x: -8, y: -8 }, size: Size { w: 1928, h: 1088 } }, output: WlcOutput { handle: 1, name: "eDP-1", views: [WlcView { handle: 2, title: "Code School Free Weekend | Code School - Mozilla Firefox", class: "Firefox" }] }, color: None, title_color: None, title_font_color: None }) }
 TRACE [layout::actions::workspace] src/layout/actions/workspace.rs:188 Focusing on next container
 TRACE [layout::actions::focus] src/layout/actions/focus.rs:260 Active container set to container NodeIndex(6)
 INFO [layout::core::tree] src/layout/core/tree.rs:231 Active container was 6, is now 6
 TRACE [callbacks] src/callbacks.rs:61 view_focus: WlcView { handle: 2, title: "Code School Free Weekend | Code School - Mozilla Firefox", class: "Firefox" } false
 INFO [modes::default] src/modes/default.rs:256 [key] Found an action for Keypress(MOD_MOD4, Some("Return")), blocking event
 TRACE [lua::thread] src/lua/thread.rs:212 Handling a request
 TRACE [lua::thread] src/lua/thread.rs:299 Lua: handling keypress Keypress(MOD_MOD4, Some("Return"))
 TRACE [lua::thread] src/lua/thread.rs:309 Handled keypress okay.
 TRACE [lua::thread] src/lua/thread.rs:201 Lua: awaiting request
Read 36 .desktop files, found 24 apps.
 TRACE [callbacks] src/callbacks.rs:49 view_created: WlcView { handle: 3, title: "", class: "" }: ""
 TRACE [layout::commands] src/layout/commands.rs:423 Adding view: WlcView { handle: 3, title: "", class: "" }
 w/ bit: 1
 has parent: false
title: ""
 class: ""
 appid: ""
 TRACE [layout::core::graph_tree] src/layout/core/graph_tree.rs:508 Normalized edge weights for: NodeIndex(6)
 INFO [layout::core::graph_tree] src/layout/core/graph_tree.rs:240 Added new child NodeIndex(7) for View { handle: WlcView { handle: 3, title: "", class: "" }, floating: false, effective_geometry: Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 19 } }, id: Uuid("0db27119-a620-4132-884f-6367d79ccfbd"), borders: None }
 INFO [layout::core::tree] src/layout/core/tree.rs:220 Active container was 6, is now 7
 INFO [layout::core::tree] src/layout/core/tree.rs:231 Active container was 6, is now 7
 TRACE [callbacks] src/callbacks.rs:61 view_focus: WlcView { handle: 3, title: "", class: "" } true
 TRACE [callbacks] src/callbacks.rs:99 View WlcView { handle: 3, title: "", class: "" } requested geometry Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 19 } }
 TRACE [callbacks] src/callbacks.rs:55 view_destroyed: WlcView { handle: 3, title: "", class: "" }
 TRACE [layout::core::graph_tree] src/layout/core/graph_tree.rs:508 Normalized edge weights for: NodeIndex(6)
 TRACE [layout::actions::focus] src/layout/actions/focus.rs:260 Active container set to container NodeIndex(6)
 INFO [layout::core::tree] src/layout/core/tree.rs:220 Active container was not set, is now 6
 INFO [layout::core::tree] src/layout/core/tree.rs:231 Active container was not set, is now 6
User input is: telegram/desktop
/bin/bash -i -c 'telegram/desktop'
 TRACE [layout::core::tree] src/layout/core/tree.rs:590 Removed container Ok(View { handle: WlcView { handle: 3, title: "", class: "" }, floating: true, effective_geometry: Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 19 } }, id: Uuid("0db27119-a620-4132-884f-6367d79ccfbd"), borders: None }), index NodeIndex(7)
 TRACE [layout::commands] src/layout/commands.rs:479 Removed container WlcView { handle: 3, title: "", class: "" } with id Uuid("0db27119-a620-4132-884f-6367d79ccfbd")
bash: telegram/desktop: No such file or directory
 INFO [modes::default] src/modes/default.rs:256 [key] Found an action for Keypress(MOD_MOD4, Some("Return")), blocking event
 TRACE [lua::thread] src/lua/thread.rs:212 Handling a request
 TRACE [lua::thread] src/lua/thread.rs:299 Lua: handling keypress Keypress(MOD_MOD4, Some("Return"))
 TRACE [lua::thread] src/lua/thread.rs:309 Handled keypress okay.
 TRACE [lua::thread] src/lua/thread.rs:201 Lua: awaiting request
Read 36 .desktop files, found 24 apps.
 TRACE [callbacks] src/callbacks.rs:49 view_created: WlcView { handle: 3, title: "", class: "" }: ""
 TRACE [layout::commands] src/layout/commands.rs:423 Adding view: WlcView { handle: 3, title: "", class: "" }
 w/ bit: 1
 has parent: false
title: ""
 class: ""
 appid: ""
 TRACE [layout::core::graph_tree] src/layout/core/graph_tree.rs:508 Normalized edge weights for: NodeIndex(6)
 INFO [layout::core::graph_tree] src/layout/core/graph_tree.rs:240 Added new child NodeIndex(7) for View { handle: WlcView { handle: 3, title: "", class: "" }, floating: false, effective_geometry: Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 19 } }, id: Uuid("b72293fd-c2fe-4b27-b16c-5e4d8a46aba7"), borders: None }
 INFO [layout::core::tree] src/layout/core/tree.rs:220 Active container was 6, is now 7
 INFO [layout::core::tree] src/layout/core/tree.rs:231 Active container was 6, is now 7
 TRACE [callbacks] src/callbacks.rs:61 view_focus: WlcView { handle: 3, title: "", class: "" } true
 TRACE [callbacks] src/callbacks.rs:99 View WlcView { handle: 3, title: "", class: "" } requested geometry Geometry { origin: Point { x: 0, y: 0 }, size: Size { w: 1920, h: 19 } }
 TRACE [callbacks] src/callbacks.rs:55 view_destroyed: WlcView { handle: 3, title: "", class: "" }
 TRACE [layout::core::graph_tree] src/layout/core/graph_tree.rs:508 Normalized edge weights for: NodeIndex(6)
 TRACE [layout::actions::focus] src/layout/actions/focus.rs:260 Active container set to container NodeIndex(6)
 INFO [layout::core::tree] src/layout/core/tree.rs:220 Active container was not set, is now 6
 INFO [layout::core::tree] src/layout/core/tree.rs:231 Active container was not set, is now 6
User input is: telegram-desktop
/bin/bash -i -c 'telegram-desktop'

Froze here.

Does it stay locked up (and you have to shut down the computer or ssh in)? If so, sorry about that that's annoying.
Does this happen only on certain applications? Does it only happen sometimes or are there applications that always trigger it? Does this only happen through dmenu?
Its probably a dead lock issue causing this.

Yes it stay locked up, I tryed to record the freeze in the log but this is all I got.
I don't have noticed any particular pattern in the freeze, because I use mainly terminal (termite for reference) and browser (firefox) that are the applications I have always open and because it happened only few times (like three but I'm not sure).
Yes, I observed the freeze only lauching apps from dmenu.

Thanks for the clarification, I'll look into the bug and see if I can reproduce it

From the output in the log, it looks like you're using a replacement for dmenu (specifically, this one)? I'm only going off the logs (specifically User input is:), so if I'm incorrect disregard this comment and please clarify that you are using dmenu). Have you been able to reproduce this with standard dmenu as well?
I tried testing that application instead of standard dmenu, and I noticed that when I typed in garbage (e.g "aoeu") it would spawn up a bash process that would eat quite a bit of my cpu and had to be killed with SIGKILL. Once I killed that offending process, the other programs I tried to spawn with j4-dmenu-desktop finally spawned as well.I mention that specifically because I noticed that you mistyped your application in the log and had to do it again(?).
Obviously this is still a bug, but is it possible that j4-dmenu-desktop is causing the freeze?

From the output in the log, it looks like you're using a replacement for dmenu (specifically, this one)?

Have you been able to reproduce this with standard dmenu as well?

Yes, I'm using j4-dmenu-desktop, for dmenu replacement, decided to switch for some reasons and haven't tried with dmenu.

I  mention that specifically because I noticed that you mistyped your application in the log and had to do it again(?).

I mistyped the name and when got it right everything froze, so I decided to include everything from dmenu spawn.

Obviously this is still a bug, but is it possible that j4-dmenu-desktop is causing the freeze?

It could be even OS, causes aren't that clear. For sure I can say it's a rare condition.

Unable to reproduce. Please raise once we move to wlroots if the issue persists.


[Help] Do we need to manually dispose stateManager?

I am just wondering do we need to dispose statemanager if widget dispose?

same wondering?


Update chapterTree.tex

Fix typo.

LGTM. thanks.

Thanks a lot for this quicksheet, your ideas really helped me a lot in my training in competitive programming!

It's great this quicksheet makes an impact to your life. Competitive programming is a challenging but rewarding journey. Have fun and nail it!


Made some spelling corrections in the documentation

Great addon! I made a few small typo-fixes as I was reading through the documentation, hope you don't mind :-)

@lorcan this was very much needed 😛! Thank you for taking the time in fixing all of those.


Remove dangerous dependencies

Current dep list is:
    "@ethersproject/bytes": "^5.6.1",
    "bn.js": "^5.2.1",
    "cross-fetch": "^3.1.5",
    "elliptic": "^6.5.4",
    "ethereum-cryptography": "^1.0.3",
    "hash.js": "^1.1.7",
    "json-bigint": "^1.0.0",
    "minimalistic-assert": "^1.0.1",
    "pako": "^2.0.4",
    "ts-custom-error": "^3.2.0",
    "url-join": "^4.0.1"

You're depending on ethereum-cryptography, which contains audited versions of secp256k1, all sorts of hashes (sha2, sha3...); e-c also doesn't use bn.js, instead, it uses native bigints.
So, I strongly suggest to remove bn.js, elliptic, hash.js — it would reduce your bundle size by a huge amount; and improve security drastically. Elliptic had 2 CVEs in 2020. Instead of them, you can simply use ethereum-cryptography stuff.

@janek26 I could work on this. Do you have any budget allocations, or grants?
Are you using nist p256?

we have no budget at all atm :( The project so far is just a community effort
You can find all of the ec logic here: https://github.com/0xs34n/starknet.js/blob/develop/src/utils/ellipticCurve.ts#L10

Regarding native BigInt, according to:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt

The operations supported on BigInt values are not constant-time, and are thus open to timing attacks. JavaScript BigInts are therefore not well-suited for use in cryptography.

Any thoughts on this?

thanks for your efforts @paulmillr !
So I think it‘s save to assume native bigints are more secure than any external (JS) library doing the same thing

Hey @paulmillr , we'll get some grants for a couple of issues from StarkWare 🎉 Are you still interested working on this?

Yes.

@paulmillr hi!
Here you can apply for contribution, to get compensation, through this portal: https://app.onlydust.xyz/contributions/7d2d8fa6-a35c-4797-a531-9c1b7f406686

This Issue is Assigned to @katsumotoeth but there seems like no activity around it. Can we reassign it to @paulmillr true only dust?

Related
https://github.com/paulmillr/micro-starknet

"@ethersproject/bytes": "^5.6.1",
"ethereum-cryptography": "^1.0.3",
"json-bigint": "^1.0.0",
"minimalistic-assert": "^1.0.1",
"pako": "^2.0.4",
"ts-custom-error": "^3.2.0",
"url-join": "^4.0.1"


Unexplained crash. TerraformGenerator 3.1.2

I'm not great at reading these but it seems to be related to TerraformGenerator. I've attached the log below in case somebody else can make sense of it.
https://pastebin.com/qj7vnNwn

Did you load terraform generator with a third party plugin or use /reload?

Guess I'll close this. If you are still encountering problems, seek support in the discord.


Modularize CSS to reduce bundle-size

It should be possible to only import CSS of actually used components.
Example app.ts
// Core
import<EMAIL_ADDRESS>// Components
import<EMAIL_ADDRESS>

Implemented in: https://github.com/mittwald/flow/commit/289439400e3230d679d076faefd3bde6013c6b4d
Migration infos: https://github.com/mittwald/flow/blob/main/packages/components/MIGRATION.md


Remove "parallel" feature from cc dependency

Since you're only compiling one c file we don't need the parallel feature and thus it can be turned off for cc, this makes the list of dependencies quite a bit smaller since it doesn't need to drag in rayon speeding up (clean) build times.

Done! Thanks


Document libspdm's expectations / requirements for the send and receive buffers

In particular :

If libspdm never writes to the receive buffer then it should be ok for it to be a read-only buffer. I'm not sure if there are any write-only buffers out there.
libspdm does not copy the receive buffer to a more secure region of memory. So if the receive buffer could possibly be written to by an attacker while libspdm is processing the message then it's up to the integrator to copy the data to a more secure region before handing it off to libspdm.

9/5/2022. We expect the integrator passes the secure region of memory (send/receive/scratch buffer). No TOC-TOU issue.
Agree to document that.


Converted .png to .jpg and updated HTML fixes#302

🛠 Fixes Issue
Fixes#302
👨💻 Changes proposed

Changed .png and .webp to .jpg
. Changed extension of file
. Added '..' at the start to fix the scope

Type of change

[ ] Bug fix - Changed source link of image element in HTML (1. Changed extension of file   2. Added '..' at the start to fix the scope)
[ ] New feature - Changed .png and .webp to .jpg

✔ Check List (Check all the applicable boxes)

[ ✔] My code follows the code style of this project.
[✔ ] This PR does not contain plagiarized content.
[✔ ] The title of my pull request is a short description of the requested changes.

Also, what text do you want me to add in the alt attribute?

Sure! Do u also want me to delete the .png and .webp images from the folder?

Yes

Also, what text do you want me to add in the alt attribute?

I'll let you know in a bit, it has to be relevant to the picture.

On it!

Done

Hi @ArhyaSaha ,
Thanks for your contribution!! Merged!!! 😃

@all-contributors add @ArhyaSaha to the doc


fix: Move the custom php8.0-xdebug build from ddev-webserver to user Dockerfile

The Issue

#6159
#6181

@stasadev pointed out that we're still building a custom php8.0-xdebug for a small number of users that experienced a crash with xdebug.
It's time to let that go, since PHP 8.0 is no longer supported.
How This PR Solves The Issue

Stop doing the build of php8.0-xdebug (move it to the user Dockerfile).
Stop using the results (move it to the user Dockerfile).

Manual Testing Instructions
Check that Xdebug 3.2.2 is installed for PHP 8.0, 8.1, 8.2.
ddev config --php-version=8.0
ddev restart
ddev xdebug

ddev php -v
PHP 8.0.30 (cli) (built: Sep 27 2024 04:08:13) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.30, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.30, Copyright (c), by Zend Technologies
    with Xdebug v3.2.2, Copyright (c) 2002-2023, by Derick Rethans

# the modified time should be now
ddev exec "ls -l /usr/lib/php/20200930/xdebug.so"

ddev config --php-version=8.1
ddev restart
ddev xdebug

ddev php -v
PHP 8.1.30 (cli) (built: Sep 27 2024 04:06:59) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.30, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.30, Copyright (c), by Zend Technologies
    with Xdebug v3.2.2, Copyright (c) 2002-2023, by Derick Rethans

# the modified time should be the ddev-php-base build time
ddev exec "ls -l /usr/lib/php/20210902/xdebug.so"

ddev config --php-version=8.2
ddev restart
ddev xdebug

ddev php -v
PHP 8.2.25 (cli) (built: Nov  4 2024 23:34:15) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.25, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.25, Copyright (c), by Zend Technologies
    with Xdebug v3.2.2, Copyright (c) 2002-2023, by Derick Rethans

# the modified time should be the ddev-php-base build time
ddev exec "ls -l /usr/lib/php/20220829/xdebug.so"

Rebased.

I'm talking about the contents of .ddev/.webimageBuild, where users cannot use FROM $BASE_IMAGE:
ddev config --php-version=8.0 && ddev restart

#ddev-generated - Do not modify this file; your modifications will be overwritten.

### DDEV-injected custom build for PHP extensions
ARG BASE_IMAGE="scratch"
FROM $BASE_IMAGE AS ddev-php-extension-build
SHELL ["/bin/bash", "-c"]

RUN /usr/local/bin/build_php_extension.sh "php8.0" "xdebug" "3.2.2" "/usr/lib/php/20200930/xdebug.so" || true

### DDEV-injected base Dockerfile contents
ARG BASE_IMAGE="scratch"
FROM $BASE_IMAGE
SHELL ["/bin/bash", "-c"]

ARG TARGETPLATFORM
ARG TARGETARCH
ARG TARGETOS
ARG username
ARG uid
ARG gid
ARG DDEV_PHP_VERSION
ARG DDEV_DATABASE
RUN (groupadd --gid $gid "$username" || groupadd "$username" || true) && (useradd  -l -m -s "/bin/bash" --gid "$username" --comment '' --uid $uid "$username" || useradd  -l -m -s "/bin/bash" --gid "$username" --comment '' "$username" || useradd  -l -m -s "/bin/bash" --gid "$gid" --comment '' "$username" || useradd -l -m -s "/bin/bash" --comment '' $username )

### DDEV-injected addition of not-preinstalled PHP version
RUN /usr/local/bin/install_php_extensions.sh "php8.0" "${TARGETARCH}"

### DDEV-injected copy of xdebug 3.2.2
RUN apt-get -qq remove -y php8.0-xdebug || true
COPY --from=ddev-php-extension-build /usr/lib/php/20200930/xdebug.so /usr/lib/php/20200930/xdebug.so

### DDEV-injected extra content
...

OK, let's go with it then! Thanks.


Kitchen Sink: Data Converter

Describe the feature
I would like to implement the Discount Calculator feature!

This app will convert the data value based on user input such as MB to GB etc.

Hey @tobySolutions, Please assign this issue to me under hactoberfest label. Thank you!
Additional information

[X] Would you be willing to help implement this feature?

Sure thing @lalitkumawat1m; all yours. I hope you are able to handle them all though.


Invalid tags being added when there are comments in tag section of terraform file

Describe the bug
If there is a comment anywhere within the tags block in a resource (except after the last tag), then invalid tags are being generated.
To Reproduce
Steps to reproduce the behavior:

Go to a working terraform project directory.
Use this template to reproduce:

provider "aws" {
  region = "us-east-1"
}

resource "aws_instance" "example" {
  ami           = "ami-09d56f8956ab235b3"
  instance_type = "t2.micro"
  tags = {
    "name" = "sahil" # this is name
    "env"  = "dev"
  }
}

Run cli command  yor tag -d . —tag-groups code2cloud -parsers Terraform
See error

Expected behavior
Only the relevant trace should have been added.
Screenshots
https://drive.google.com/file/d/1j5FHvmiAOLJHCfgbEGXkAonw3whO_IsM/view?usp=sharing
Desktop:

OS: [macOS, Ubuntu]
Yor Version [0.1.178]

@sahilt-ti the fix PR merged, feel free to reach out in case of an issue.


Add disputedReporter to the tallyVotes event

In my reporter implementation, I monitor these events to schedule automatic execute TXs. The disputedReporter was part of the  tallyVotes event  in tellor3

Code's frozen now, so this doesn't qualify.  But next version.  With tellor3 though, there's 5 miners on a value,  now theres only 1 so the look up isn't bad at all for a rare event


chore: add initial project structure for server

Project's server side structure:

Added the main directories and files for the project's server initial structure.
Tracked the empty directories using .gitkeep files.

Partially-addresses #3

The pull request will be accepted, but the issue won't be closed until the client's initial structure is set.


mio_uds::UnixStream support

Will be UnixStream supported in futures_mio?

Certainly! I believe the intention is to move uds outside of mio itself, so I've created a mio-uds crate and to mirror that I've added a futures-uds crate to this repo.


Is it possible to use this only on certain pathname?

I would like to apply sync query to different states on different paths.
For example, let's say there are two paths.
/books?page=1
/computers?page=1

I would like to know if i can create enhancer like this.
ReduxQuerySync.enhancer({
    params: {
        page: [{
           path: '/books'
           ... // actions, selectors, etc
        }, {
           path: '/computers'
        }]
    },
})

Or at least is it possible to provide current pathname to actions and selectors?

It would be nice to enable your use case. My intuition tells me however that this module should be indifferent to paths or other parts of its environment. I think it should rather give you the possibility to easily change its configuration, so you can still implement the desired behaviour.
A rough and untested sketch of how this might currently be done:
const querySyncParamsByPath = {
    '/books': {/* action, selector, ... */},
    '/computers': {/* action, selector, ... */},
}

let unsubscribeQuerySync
function onPathChange() {
    const path = /* read current path */
    unsubscribeQuerySync && unsubscribeQuerySync()
    unsubscribeQuerySync = ReduxQuerySync({
        params: querySyncParamsByPath[path],
        ...otherSettings
    })
}
yourRouterOrWhatever.someRoutingEvent.addListener(onPathChange)

What is still missing is a possibility to remove parameters from the query, so they don't linger after a path change. It may be worth providing a way to do this. Perhaps by passing something like {hideParams: true} to unsubscribeQuerySync?
I would be happy to hear suggestions for other simple changes to the API that would allow more versatile usage.

Or at least is it possible to provide current pathname to actions and selectors?

I don't think this module should provide it, as it is not obvious to me that the path is more important than any other piece of the environment, but feel free to convince me otherwise.
You could read the path in the functions themselves, e.g.: action: value => myActionCreator(value, window.location.pathname).

Thanks for your kind reply @Treora
unsubscribeQuerySync()
If I call ReduxQuerySync()(), then does it unsubscribe to store? If it provides unsubscribing to store, I think that would be the easiest way.

Yes, it unsubscribes from both the store and changes to the location. (see source code)
If this seems a good enough solution, I'll just close this issue now. Feel free to reopen or open a new issue if you have suggestions for API improvements.

👍  yes I think this will solve the issue for now.


Multiple classes diff is wrong

See #245
I tried to fix this but it's not as easy. The regex always looks for the last part of the diff.
Wouldn't it be better to just show the full diff of the file? Or just show the full content of the changed file? Maybe side by side?

We can change to one of your suggestions. Maybe full diff would work. Screenshot would help to decide

This is how it looks when there is only 1 diff part:

This is how it looks for when there are multiple diff parts:

@TomasVotruba WDYT?

Looks good :+1: Let's ship it


Conditional Closes on Limit Order

Hi,
I'm trying to figure out how to add a conditional close to a limit order, specifically a take profit condition.  On a standard limit order you would write something like:
Krakex.add_order(pair, "buy", "limit", lot_size, [price: buy_price])
After looking through the Krakex docs and the Kraken API I see another order type called take-profit-limit.  I've tried this as well in the following fashion:
Krakex.add_order(pair, "buy", "take-profit-limit", lot_size, [price: sell_price, price2: buy_price])
But I seem to get back an error of: EGeneral:Invalid arguments:ordertype
If you could give me a hand figuring out where I'm misapplying this it would be greatly appreciated.

@iancharters So, three years to the day and I finally get around to answering you. 😄 Up until today this library actually didn't support conditional closes for several reasons: A) it wasn't documented in Kraken's REST API and B) I hadn't needed it myself. In the meantime A still hasn't changed but B has. I was able to find out how to implement it by reading code in the python client and it turns out it was pretty simple. So, by the off chance that you're still using this library this is how you can now execute an order with a conditional close:
Krakex.add_order("XRPEUR", "sell", "limit", "20", price: "0.38", close: [ordertype: "limit", price: "0.37"])

That will return something like:
{:ok,
 %{
   "descr" => %{
     "close" => "close position @ limit 0.37000",
     "order" => "sell 20.00000000 XRPEUR @ limit 0.38000"
   },
   "txid" => ["OJAOUK-YWLRG-YM5D7L"]
 }}

There's no need to set the type on a close, i.e. if you're buying the conditional close will be a "sell" and vice-versa. All order types are supported for the conditional close; the three available keyword args are ordertype:, price: and price2: (depending on your order type).
Thanks for bringing this up and sorry again for such an inexcusably late reply. 🤷🏻♂


Reference to directives fail after minification using uglify

First of all thanks for the nice directive which works awesome on my dev environment.
I am using https://github.com/DaftMonk/generator-angular-fullstack for my project and included the latest version [1.14.10] of angularjs-google-maps.
After building my dist [grunt build:dist] all the references to the ngmap directives seem to by corrupt, probably by uglifying the code.

In my view i have:

In my controller:
'use strict';
angular.module('app').controller('MainCtrl', function (NgMap) {
NgMap.getMap().then(function(map) {
bounds = map.getBounds();
map.setZoom(7);
});
in my none uglified enviroment everything works, also using version 1.13.0 works. All versions after break on minification. Hopefully someone can give me some directions to proper inject ngmap and it's directives.

It seems all local variables e.a. $windows are broken after building dist. Am i Doing something wrong?

It seems working fine with minified version.
http://plnkr.co/edit/GErhxRRm1gWsGsHCT6WY?p=preview.
Are you using the recent 1.4.* version?

@allenhwkim thanks for your reply. I think understand what happens, by grunt build:dist the non minified version gets minified and breaks. If I exclude ngmap from bower.json and refer to your minified version in the index it all works fine.
Any clue how to prevent this to happen?
Thanks again!

No idea, I only use gulp. so someone using grunt, please help here.

I've tried to debug it with no luck so far and decided to bypass the grunt build.
For those reading this with the same problem and need a solution. Exclude ngmap in bower.json so the grunt process of angular fullstack is not minifiying. Refer in index.html like this

[make sure it's after the
I know it's not the best solution, but it's working now. If someone knows a proper solution please let me know.
@allenhwkim thanks again. You can close this iddue if you like.

Tested with gulp-usemin, and all seems working fine.
<!-- build:js myapp.min.js-->
<script src="lib/angular.js"></script>
<script src="build/scripts/ng-map.min.js"></script>
<!-- endbuild -->

output
<script src="myapp.min.js"></script>


Add an example for failover client

Purpose
Add an example for failover client
Fixes #19751
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing this PR temporary. Please reopen once we complete the implemetation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: kalaiyarasiganeshalingam:x: KalaiyarasiKalaiyarasi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #19996 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19996      +/-   ##
==========================================
- Coverage   14.72%   14.59%   -0.13%
==========================================
  Files          51       51
  Lines        1399     1411      +12
  Branches      214      219       +5
==========================================
  Hits          206      206
- Misses       1177     1189      +12
  Partials       16       16

Impacted Files
Coverage Δ

tool-plugins/vscode/src/core/extension.ts
27.23% <0.00%> (-1.14%)
:arrow_down:

tool-plugins/vscode/src/extension.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c906f...aac853e. Read the comment docs.


Webhook changes

Fix handling of fractional cpu units during mutation
Reliably install cert-manager for webhook if needed.
Deploy webhook by default during install : Will create a separate PR for this

This should fix the webhook CI errors due to cert-manager issues.


Add pet leveling info

taken from the neu repo
used in

https://github.com/hannibal002/SkyHanni/pull/2605

?

? whats wrong with the neu repo

nothing, i just think it makes more sense if the data is being used in skyhanni, for it to (also) be in the skyhanni repo.
also with a move to stop depending on NEU, i feel like it doesn't make a ton of sense to have the code look at the NEU repo, to then change it to looking at something else.
anyways i asked hanni about this yesterday, and didn't get a reply yet, if we have a better solution i'll just do that instead.

you will still be using the neu repo even after neu lmao

also with a move to stop depending on NEU, i feel like it doesn't make a ton of sense to have the code look at the NEU repo
This is only stopping depending on neu code, we will still use the neu-repo for items and other data like this.
I dont forsee anytime in the future where we will not use the neu-repo, as if we did then we would have to keep 6000+ items up to date.


False positive C4251

Microsoft Visual Studio Enterprise 2019 Version 16.3.8 VisualStudio.16.Release/16.3.8+29503.13
C4251 warning is about passing CRT objects across DLL boundaries.
Its wrong to raise this warning on private data members. The case of pimpl its especially obvious that the object is going nowhere. Here's my code snippet where this occurs...
private:
/// forward reference to private implementation.
class impl;
/// smart unique pointer to private implementation.
///<remarks> with default copy, move and compare support.</remarks>
#pragma warning (disable:4251)
spimpl::impl_ptr<impl> pimpl;
#pragma warning (default:4251)
See also: 		https://github.com/oliora/samples/blob/master/spimpl.h

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

 The documentation reflects what the compiler does. If you think compiler diagnostic behavior should change, then the best place to make the suggestion is on our Developer Community site. It gives others a place to chime in with support, which may increase its chances of being taken up by the development team. I'm closing this, as it's not (yet) a documentation issue.

Thanks, I realised that was probably the case just after I posted.
From: Colin Robertson<EMAIL_ADDRESS>Sent: 10 November 2019 08:07
To: MicrosoftDocs/cpp-docs<EMAIL_ADDRESS>Cc: JackHeeley<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/cpp-docs] False positive C4251 (#1693)
@JackHeeleyhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJackHeeley&data=02|01||268f6a9e04d248e54dac08d765ac8448|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637089663934249431&sdata=XzXI1FNRrAOza51y4Xu8dZ4j7f5AHUD%2BTT9A%2BOKKEO4%3D&reserved=0
Your complaint is acknowledged, but unfortunately, you're making it in the wrong place. The documentation reflects what the compiler does. If you think compiler diagnostic behavior should change, then the best place to make the suggestion is on our Developer Communityhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevelopercommunity.visualstudio.com%2Fspaces%2F62%2Findex.html&data=02|01||268f6a9e04d248e54dac08d765ac8448|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637089663934259440&sdata=BKshKFPcMskd%2F1teu1Ydt%2FmKkqhQaSbN4CRvmjQKuow%3D&reserved=0 site. It gives others a place to chime in with support, which may increase its chances of being taken up by the development team. I'm closing this, as it's not (yet) a documentation issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fcpp-docs%2Fissues%2F1693%3Femail_source%3Dnotifications%26email_token%3DAGIBXMZD676JSX3MPHONDHLQS6XHRA5CNFSM4JLHR3JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUW6PA%23issuecomment-552169276&data=02|01||268f6a9e04d248e54dac08d765ac8448|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637089663934259440&sdata=QFsbZK%2BrHQYKjMJ6yiLWl07K0a9%2F9Va%2B8qqr%2F0dclrg%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGIBXMYOBT3I3WCCJ36UV6DQS6XHRANCNFSM4JLHR3JA&data=02|01||268f6a9e04d248e54dac08d765ac8448|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637089663934269445&sdata=8XaO1472arXCsJd4kmczfRbM40ZY8yQJxM3R8v4J8ns%3D&reserved=0.


Braveheart

I posted this already, but I guess it's worth an own thread...
Hello elishacloud,
I have been tinkering with Braveheart (the game) for quite a while now but nothing works quite like it should.
The best result I got was with DXWND and dgvoodoo2 (using the glide-version (Braveheart has 3 exe-files: Software-mode, Glide & DirectX) yet the movies still dont work in that constellation.
I tried every setting imaginable - with DXWND and dxwrapper and/or dxcompat (another wrapper), yet they all have problems.
My last hope was dxwrapper, yet it doesnt work either. Foremost problem is the menue.
Explanation: The "background" flickers like crazy and it has a weird "afterimage" problem:
If you click in the menue (highlighted items are fine weirdly enough), the "backgrounds" stay like an echo and flicker like mad. Same effect occurs ingame in the strategy mode of the game.
I tried dxwrapper with many different ddraw-options but it all flickers or I get only a blackscreen etc.
I really would like to try out the Dd7to9 option, hoping it would solve these issues (maybe), yet it crashes if I start the game, sadly.
I added my logfile for inspection (1680x1050 is my native resolution). Maybe you have an idea or could help any other way?
I tried Dd7to9 troubleshooting but it doesnt work either. Only Software-mode works but flickering again.
As far as I can see Braveheart uses DirectX6.1 (and ddraw.dll).
I'm out of ideas by this point.
For testing the game, it can be "found" online.
dxwrapper-bhd3d.iconfix.log

The "background" flickers like crazy

I have seen this on other games, like Arx Fatalis and Knight Rider.  I have not looked into it to see what is causing it.  But, it is often fixed by enabling FullscreenWindowMode in dxwrapper.

it has a weird "afterimage" problem
the "backgrounds" stay like an echo

Yeah, I have seen this with other games, such as Star Trek: Starfleet Command III.  It has to do with how dxwrapper handles 2D images on top of the 3D rendering.  Basically the game keeps rewriting the same graphic to the surface, expecting the surface to be cleared between frames.  It is fixable, but will require a bit more work in dxwrapper.

it crashes if I start the game, sadly.

The crash is caused by the line below.  I would need to debug why the primary surface is not deleted when the game tries to create another one.  This is fixable.
4104 16:52:54.495 m_IDirectDrawX::CreateSurface2 Error: primary surface already exists!

Unfortunately, the Direct3D support is still limited.  I will add this to the list of fixes for the project.


cli: fitactivity conceal keep original protocol version

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (78a52df) to head (0242268).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #385   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           41        41
  Lines         3684      3684
=========================================
  Hits          3684      3684

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


POF workerman + mysql + increasing core numbers

Hey guys right now i have a doubt about this code:
<?php

require_once __DIR__ . '/vendor/autoload.php';
use Workerman\Worker;

// Create a Websocket server
$ws_worker = new Worker("websocket://<IP_ADDRESS>:2346");

// 12 processes
$ws_worker->count = 12;

$ws_worker->onWorkerStart = function() {
    global $db;
    $db = new \Workerman\MySQL\Connection('localhost', '3306', 'root', '', 'db');
    $all_tables = $db->query('show tables');
    //print_r(json_encode($all_tables));
    echo "test" . PHP_EOL;
};

// Emitted when new connection come
$ws_worker->onConnect = function($connection)
{
    echo "New connection\n";
 };

// Emitted when data received
$ws_worker->onMessage = function($connection, $data) {
    global $mysql;
    $mysql->query('show databases' /*trim($data)*/, function ($command, $mysql) use ($connection) {
        if ($command->hasError()) {
            $error = $command->getError();
        } else {
            $results = $command->resultRows;
            $fields  = $command->resultFields;
            $connection->send(json_encode($results));
        }
    });
};

// Emitted when connection closed
$ws_worker->onClose = function($connection)
{
    echo "Connection closed\n";
};

// Run worker
Worker::runAll();

Inside onWorkerStart I am making a query, also printing something but it seems like this is being called the number you use for cores. Maybe you will say making queries in that method (onWorkerStart ) is not right, what could be the right place to pre load some data before anyone get connected to the socket?

Don't worry about it. Each process works independently and does not affect each other.

Good evening! you can show a simple example to make a request in a function
$ws_worker->onMessage = function($connection, $data){
mysqli_query($db, "INSERT INTO hist (date, us_ip) VALUES
where are examples of request code
Thank you in advance!!!


Consolidate the compiler's command-line interface

The command-line interface for ergoc and ergoc.native should be aligned. Also calling the compiler without options should print out the help (identical to --help).

Done in #105


Using combine_files() causes file to be uploaded to s3 but framework fails to provide a link to it

Requirements::combine_files('vendor.min.js', [
    'themes/default/node_modules/selectize/dist/js/standalone/selectize.min.js',
    'themes/default/javascript/rollbar.min.js'
]);

results in:
<script type="application/javascript" src="/"></script>

combined file is uploaded to s3 though

I'm not sure if this is a bug in the Requirements class, if you think this is just close it off and i'll create a ticket there

To use S3 and Requirements you will most likely need to extended the RequirementsBackend class and configure Silverstripe to use your class as default.  Basically you will need to have your new class utilize the s3 urls. If I am correct the Requirements classes look at the local filesystem only for the combined assets and if the files don't exist it breaks.
Requirements functionality, if I am correct may be deprecated as now a days most people are using modern tooling for combining assets such as CSS preprocessors and is bundlers like webpack.

I would checkout the docs at https://docs.silverstripe.org/en/4/developer_guides/templates/requirements/#configuring-combined-file-storage
Basically your best course of action is to change the folder the combined assets get outputted to and setting configuration for how the filesystem looks for those files.


@deprecated nested namespace handling is buggy

🔎 Search Terms
deprecated nested namespace
🕗 Version & Regression Information

This is the behavior in every version I tried

⏯ Playground Link
https://www.typescriptlang.org/play/?#code/FAegVGAEACAmCmAHATvAxgQwC71pMIwAdhgLbwDOiGa8kAYgPaMCMAdAEIbKQDewkSPAAeiRsiyQ0jIhUnDIAXkgsA3MAC+wYmUrVaDZuy4AvPgKGjxk6bPlKV6rcCatO3NsPWvjGE5-VtUBAQoJ1yKho6VwAmdzN+QRExCSkZOUgFZTVNbXAoOCRUTBw8AnC9KMNGOK4eRMsUm3T7bKcg2PdkAJdmWr8e7SA
💻 Code

/** @deprecated */
namespace Foo1.Bar {
  export const x = 1;
}

namespace Foo1.Baz {
  export const x = 1;
}

Foo1.Bar.x;
Foo1.Baz.x;

namespace Foo2.Baz {
  export const x = 1;
}

/** @deprecated */
namespace Foo2.Bar {
  export const x = 1;
}

Foo2.Bar.x;
Foo2.Baz.x;

🙁 Actual behavior
Usages of Foo1 are stricken through

But usages of Foo2 are not stricken through

Yet intellisense shows the tag in the hover for Foo2

🙂 Expected behavior
Either both Foo1 and Foo2 should be treated as deprecated, or neither should and instead the Bar in Foo1.Bar and Foo2.Bar should be treated as deprecated.
Additional information about the issue
@typescript-eslint recently released a new lint rule no-deprecated which reports a lint error whenever you use a thing marked with @deprecated.
A user mentioned to us that the rule reports incorrectly in certain cases (https://github.com/typescript-eslint/typescript-eslint/issues/9902).
Specifically in a case like this
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/d1c172bdcfd4508405f4b233e11ccd7d8743f763/types/chrome/index.d.ts#L8553-L8556
We did some investigation and found that things can be pretty ambiguous when nested namespace declarations are marked @deprecated like this and TS itself struggles with it.

It's worth noting that the above behaviour is consistent between nested namespace shorthand (namespace Foo.Bar) and the non-shorthand style
Note you see similar behaviour for many declaration-merged things where TS's handling only makrs something as deprecated if the first definition is marked as deprecated, eg Enums.
But there are also cases where TS gets it right, eg Interfaces
Then there are weird cases like type/value shadowing where I'm not sure if TS is right or wrong -- depends on what you expect I guess.

I would love to see some clarification on what you guys think is the correct behaviour so that we can follow-suit!

I would love to see some clarification on what you guys think is the correct behaviour so that we can follow-suit!

I have no idea and I don't think it's likely that a poll of developers would produce a strong majority outcome either. It seems much more clarifying to either write
/** @deprecated */
namespace Foo1 {
  export namespace Bar {
    export const x = 1;
  }
}

or
namespace Foo1 {
  /** @deprecated */
  export namespace Bar {
    export const x = 1;
  }
}

depending on which is intended (hopefully they both work more consistently?)
A PR to make them consistent would be fine.

Yeah I wasn't sure what the "correct" behaviour should be and I don't think there's a right answer either.
The thing I think that is missing right now is that the order of declarations matters for TS to do its strike through.
I think it'll be worth linting and enforcing against the ambiguity in DefinitelyTyped. I'll raise an issue over there.


Reference model from a package

I am trying to write a unit test for a model that depends on a model from a different package.
I tried referencing the model name directly in mock_ref and got the following error:
Node [dbt_project].[model] not found.

> in macro raise_error (macros/utils.sql)
> called by macro model_node (macros/utils.sql)
> called by macro graph_node (macros/utils.sql)
> called by macro build_mocks_and_expectations (macros/tests.sql)
> called by macro test (macros/tests.sql)

When trying to reference the package with mock_ref([package_name], [model_name]), I got:
'str object' has no attribute 'items'

> in macro merge_configs (macros/utils.sql)
> called by macro build_mocks_and_expectations (macros/tests.sql)
> called by macro test (macros/tests.sql)
> called by macro merge_jsons (macros/utils.sql)

Hi @mdimercurio.
We don't have this feature yet, but it makes sense to add it since 'ref' supports this functionality.
We don't have much time in the next few weeks, but we'll address this later.
Meanwhile, feel free to contribute with a pr if you will.
Thank you

Hi @cdiniz. Thanks for the quick follow up.
I'll try to look into it in my side. I haven't looked much into the package's code so I might have a few questions for you as I dig into it

@mdimercurio +1 on this issue, any progress you might've made that you can share?

Hello! I was thinking about having a go at a PR for this, but to be honest it's WAY more complex than anything else I've done in dbt. I can see that the issue is with the graph_node_by_prefix macro and its cousins. They're using model.package_name which refers to the package of the model being run, not the model being referenced.
I can see a few ways around this, but I am a bit worried about unforeseen consequences. Since model names must be unique, is there a risk in just looking for a model with a matching name? How does the ref function do this?

Hi there, we are doing a clean-up of old/inactive Issues.
Happy to open again if there is a need for that.
Thank you for collaboration!

Very much still needed by me! Maybe I'll get around to a PR for it too!


Document Developing the APISnoop spyglass lens

Request: local dev prow instance to allow exploration of spyglass lens
Short description:

Current state:(Description of desired state.)

No spyglass lens dev env

Desired state:

Any developer can pull our branch and explore APISnoop data

Tasks:

[x] create branch of test-infra
[x] create gcs buckets for apisnoop data
[ ] create new prow jobs modelled after current conformance jobs
[ ] update the deck config to show the new apisnoop job output buckets
[ ] update the deck config for simple spyglass lens to pull simply list the apisnoop json files
[ ] ensure @zachmandeville can use documentation to pull down and start integrating his single html files (plus static assets) approach

@zachmandeville can you verify that the documentation works for you and bring it into  the repo.

verified!  looks good.


Nadekobot installer (setup.exe) doesn't open.

A person in #help had this issue

Windows 10
"my computer is insanely fast"
tried downloading multiple times
tried running as admin
nothing shows up in task manager
nothing detected by antivirus, nothing blocked by antivirus.

Video
throws another link

Same problem. PS Windows Server 2016

Can't see the taskbar or if there's another monitor, but I wonder if we don't see that SmartScreen or some other dumb Windows thing is being triggered?

@Jengas' issue: #1648

Tracking this in #1648


Certificate issue

A scan (see here for details and background) just revealed the APKs at your releases are signed using a debug key. As that has security implications, may I ask you to please switch to a proper release key, and provide the corresponding APK signed with it? Thanks in advance!

Code is completely open source, if you need a signed app just fork and build with your key.

Sorry, can't – I'm not an Android dev, and I don't have a build environment. So I (and others) depend on you to provide the APK :pray:

No properly signed APK means no remedy – so I'll have to remove your app from my repo now. Should you one day pick up again and have APKs signed using a release key, be welcome to let me know so I can reestablish the listing. Thanks!


Is mapview supported in viro?

Environment
Please provide the following information about your environment:

Development OS: Mac
Device OS & Version: iOS version 11.4.1
Version:
== Versions ==
react-viro-cli: 2.7.3
react-native-cli: 2.0.1
react-native: 0.55.1
Device(s): iPhone SE

Description
hello,
I am developing an App in react-viro and when app opens at first i need a mapview on whole screen.
I tried following https://github.com/react-community/react-native-maps  but it returns many error one after the other.
I need to know if mapview can be used in viro?
please help me out with the issue.
Thank you,

Are you using the Viro Testbed app? If so, that is probably why you are seeing the errors. React-native-maps has not been compiled natively into the Viro testbed app. You will need to build your app using xCode -> https://docs.viromedia.com/docs/starting-a-new-viro-project-1

hello @dam00n ,
Thank you for replying,
I am not using Testbed app but i am building my app and still it returns me many error on xcode.
This is my Podfile, tell me if i am doing anything wrong:
platform` :ios, '9.3'
target 'NSWPOI' do
  use_frameworks!
  rn_path = '../node_modules/react-native'
  rn_maps_path = '../node_modules/react-native-maps'

  pod 'ViroReact', :path => '../node_modules/react-viro/ios/'
  pod 'ViroKit', :path => '../node_modules/react-viro/ios/dist/ViroRenderer/'

  # See http://facebook.github.io/react-native/docs/integration-with-existing-apps.html#configuring-cocoapods-dependencies
  pod 'yoga', path: "#{rn_path}/ReactCommon/yoga/yoga.podspec"
  pod 'React', path: rn_path, subspecs: [
    'Core',
    'CxxBridge',
    'DevSupport',
    'RCTActionSheet',
    'RCTAnimation',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket',
  ]

  # React Native third party dependencies podspecs
  pod 'DoubleConversion', :podspec => "#{rn_path}/third-party-podspecs/DoubleConversion.podspec"
  pod 'glog', :podspec => "#{rn_path}/third-party-podspecs/glog.podspec"
  # If you are using React Native <0.54, you will get the following error:
  # "The name of the given podspec `GLog` doesn't match the expected one `glog`"
  # Use the following line instead:
  #pod 'GLog', :podspec => "#{rn_path}/third-party-podspecs/GLog.podspec"
  pod 'Folly', :podspec => "#{rn_path}/third-party-podspecs/Folly.podspec"

  pod 'react-native-maps', path: rn_maps_path
  #pod 'react-native-google-maps', path: rn_maps_path  # Remove this line if you don't want to support GoogleMaps on iOS
  #pod 'GoogleMaps'  # Remove this line if you don't want to support GoogleMaps on iOS
  #pod 'Google-Maps-iOS-Utils' # Remove this line if you don't want to support GoogleMaps on iOS

  pre_install do |installer|
    # workaround for https://github.com/CocoaPods/CocoaPods/issues/3289
    Pod::Installer::Xcode::TargetValidator.send(:define_method, :verify_no_static_framework_transitive_dependencies) {}
  end

  post_install do |installer|
    installer.pods_project.targets.each do |target|
      if target.name == 'react-native-google-maps'
        target.build_configurations.each do |config|
          config.build_settings['CLANG_ENABLE_MODULES'] = 'No'
        end
      end
      if target.name == "React"
        target.remove_from_project
      end
    end
  end
end

I just want to use react-native-maps and not google maps.
Thank you,

Hi @sjt145,
I can't tell from the podfile what you are doing wrong. What error do you get when you compile and build in XCode?

Hello @VikAdvani ,
Following error i am getting:
Ld /Users/macmini/Library/Developer/Xcode/DerivedData/NSWPOI-fawqjwxdrnznhibxottryvvbjpbx/Build/Products/Debug-iphoneos/Google-Maps-iOS-Utils/Google_Maps_iOS_Utils.framework/Google_Maps_iOS_Utils normal arm64 (in target: Google-Maps-iOS-Utils)
    cd /Users/macmini/Documents/NSWworkspace/react/NSWPOI/ios/Pods
    export IPHONEOS_DEPLOYMENT_TARGET=8.0
    /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch arm64 -dynamiclib -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.0.sdk -L/Users/macmini/Library/Developer/Xcode/DerivedData/NSWPOI-fawqjwxdrnznhibxottryvvbjpbx/Build/Products/Debug-iphoneos/Google-Maps-iOS-Utils -F/Users/macmini/Library/Developer/Xcode/DerivedData/NSWPOI-fawqjwxdrnznhibxottryvvbjpbx/Build/Products/Debug-iphoneos/Google-Maps-iOS-Utils -F/Users/macmini/Documents/NSWworkspace/react/NSWPOI/ios/Pods/GoogleMaps/Base/Frameworks -F/Users/macmini/Documents/NSWworkspace/react/NSWPOI/ios/Pods/GoogleMaps/Maps/Frameworks -filelist /Users/macmini/Library/Developer/Xcode/DerivedData/NSWPOI-fawqjwxdrnznhibxottryvvbjpbx/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/Google-Maps-iOS-Utils.build/Objects-normal/arm64/Google_Maps_iOS_Utils.LinkFileList -install_name @rpath/Google_Maps_iOS_Utils.framework/Google_Maps_iOS_Utils -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -miphoneos-version-min=8.0 -dead_strip -Xlinker -object_path_lto -Xlinker /Users/macmini/Library/Developer/Xcode/DerivedData/NSWPOI-fawqjwxdrnznhibxottryvvbjpbx/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/Google-Maps-iOS-Utils.build/Objects-normal/arm64/Google_Maps_iOS_Utils_lto.o -Xlinker -export_dynamic -Xlinker -no_deduplicate -fembed-bitcode-marker -fobjc-arc -fobjc-link-runtime -framework Foundation -compatibility_version 1 -current_version 1 -Xlinker -dependency_info -Xlinker /Users/macmini/Library/Developer/Xcode/DerivedData/NSWPOI-fawqjwxdrnznhibxottryvvbjpbx/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/Google-Maps-iOS-Utils.build/Objects-normal/arm64/Google_Maps_iOS_Utils_dependency_info.dat -o /Users/macmini/Library/Developer/Xcode/DerivedData/NSWPOI-fawqjwxdrnznhibxottryvvbjpbx/Build/Products/Debug-iphoneos/Google-Maps-iOS-Utils/Google_Maps_iOS_Utils.framework/Google_Maps_iOS_Utils

Undefined symbols for architecture arm64:
  "_OBJC_METACLASS_$_GMSSyncTileLayer", referenced from:
      _OBJC_METACLASS_$_GMUHeatmapTileLayer in GMUHeatmapTileLayer.o
  "_GMSProject", referenced from:
      -[GMUGridBasedClusterAlgorithm clustersAtZoom:] in GMUGridBasedClusterAlgorithm.o
      -[GMUClusterItemQuadItem initWithClusterItem:] in GMUNonHierarchicalDistanceBasedAlgorithm.o
      -[GMUNonHierarchicalDistanceBasedAlgorithm clustersAtZoom:] in GMUNonHierarchicalDistanceBasedAlgorithm.o
      -[GMUWeightedLatLng initWithCoordinate:intensity:] in GMUWeightedLatLng.o
  "_GMSUnproject", referenced from:
      -[GMUGridBasedClusterAlgorithm clustersAtZoom:] in GMUGridBasedClusterAlgorithm.o
  "_OBJC_CLASS_$_GMSPolyline", referenced from:
      objc-class-ref in GMUGeometryRenderer.o
  "_OBJC_CLASS_$_GMSCoordinateBounds", referenced from:
      objc-class-ref in GMUDefaultClusterRenderer.o
      objc-class-ref in GMUGeoJSONParser.o
      objc-class-ref in GMUGeometryRenderer.o
  "_OBJC_CLASS_$_CLLocation", referenced from:
      objc-class-ref in GMUGeoJSONParser.o
      objc-class-ref in GMUKMLParser.o
  "_OBJC_CLASS_$_GMSGroundOverlay", referenced from:
      objc-class-ref in GMUGeometryRenderer.o
  "_OBJC_CLASS_$_GMSSyncTileLayer", referenced from:
      _OBJC_CLASS_$_GMUHeatmapTileLayer in GMUHeatmapTileLayer.o
  "_OBJC_CLASS_$_GMSMarker", referenced from:
      objc-class-ref in GMUDefaultClusterRenderer.o
      objc-class-ref in GMUGeometryRenderer.o
  "_CLLocationCoordinate2DMake", referenced from:
      -[GMUGeoJSONParser boundingBoxFromCoordinates:] in GMUGeoJSONParser.o
      -[GMUGeometryRenderer renderGroundOverlay:placemark:style:] in GMUGeometryRenderer.o
      -[GMUKMLParser parseEndGroundOverlay] in GMUKMLParser.o
  "_kGMSTileLayerNoTile", referenced from:
      -[GMUHeatmapTileLayer tileForX:y:zoom:] in GMUHeatmapTileLayer.o
  "_OBJC_CLASS_$_GMSPolygon", referenced from:
      objc-class-ref in GMUGeometryRenderer.o
  "_OBJC_CLASS_$_GMSMutablePath", referenced from:
      objc-class-ref in GMUGeoJSONParser.o
      objc-class-ref in GMUKMLParser.o
  "_kCLLocationCoordinate2DInvalid", referenced from:
      -[GMUDefaultClusterRenderer renderCluster:animated:] in GMUDefaultClusterRenderer.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

And my recent podfile where i included google-maps too:
platform :ios, '9.3'
target 'NSWPOI' do
  use_frameworks!
  rn_path = '../node_modules/react-native'
  rn_maps_path = '../node_modules/react-native-maps'

  pod 'ViroReact', :path => '../node_modules/react-viro/ios/'
  pod 'ViroKit', :path => '../node_modules/react-viro/ios/dist/ViroRenderer/'
  # See http://facebook.github.io/react-native/docs/integration-with-existing-apps.html#configuring-cocoapods-dependencies
  pod 'yoga', path: "#{rn_path}/ReactCommon/yoga/yoga.podspec"
  pod 'React', path: rn_path, subspecs: [
    'Core',
    'CxxBridge',
    'DevSupport',
    'RCTActionSheet',
    'RCTAnimation',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket',
  ]

  # React Native third party dependencies podspecs
  pod 'DoubleConversion', :podspec => "#{rn_path}/third-party-podspecs/DoubleConversion.podspec"
  pod 'glog', :podspec => "#{rn_path}/third-party-podspecs/glog.podspec"
  # If you are using React Native <0.54, you will get the following error:
  # "The name of the given podspec `GLog` doesn't match the expected one `glog`"
  # Use the following line instead:
  #pod 'GLog', :podspec => "#{rn_path}/third-party-podspecs/GLog.podspec"
  pod 'Folly', :podspec => "#{rn_path}/third-party-podspecs/Folly.podspec"

  # react-native-maps dependencies
  pod 'react-native-maps', path: rn_maps_path
  pod 'react-native-google-maps', path: rn_maps_path  # Remove this line if you don't want to support GoogleMaps on iOS
  pod 'GoogleMaps'  # Remove this line if you don't want to support GoogleMaps on iOS
  pod 'Google-Maps-iOS-Utils' # Remove this line if you don't want to support GoogleMaps on iOS
end
pre_install do |installer|
  # workaround for https://github.com/CocoaPods/CocoaPods/issues/3289
  Pod::Installer::Xcode::TargetValidator.send(:define_method, :verify_no_static_framework_transitive_dependencies) {}
end
post_install do |installer|
  installer.pods_project.targets.each do |target|
    if target.name == 'react-native-google-maps'
      target.build_configurations.each do |config|
        config.build_settings['CLANG_ENABLE_MODULES'] = 'No'
      end
    end
    if target.name == "React"
      target.remove_from_project
    end
  end
end

i feel  https://github.com/viromedia/viro/issues/228 can be same issue , please confirm
Thank you

Thank you @VikAdvani  for the solution i will use static library and will get back if i see any more issue.
Thank you so much for helping me out. 👍

hello @VikAdvani ,
Sorry for late post, i created react-native app and integrated react-viro in it using static library as the Maps was using static library and it worked fine without any errors, thank you for helping me out with solution.

Can you explain more on how you got this to work? what are static libraries? I'm also trying to get these two libraries working and not having much luck


[Bug] Little11 issue with "double click to install" apps and screenshot

I am having issues with Little11 where I cannot "double click to install" apps or take a screenshot (Power/up button) on iPhoneX iOS 13.3.  I decided to wipe my iPhone and freshly installed checkra1n and Cydia and only Little11 and I still have the issue.  Others are reporting the same issue on Reddit (r/jailbreak).  Thanks!

Hi, can you check to see if this issue is fixed in the latest version? I changed something that I believe fixes this issue. Thank you!


Fixes for scenarios

[fix] Static IP creation and check in AKS scenario
[fix] Some missing variable rendering by defining them in a previous bash command.  Those that are defined in while loops can't be fixed easily.
[remove] Commented out some unnecessary text

[fix] VM status check in LEMP scenario that always took the full time.
[added] echo statement at end of LEMP scenario telling the user their web server url.
[fixed] styling inconsistencies across the scenarios.
[moved] variable declaration that relies on previously declared variables into new blocks so that the new value renders properly.