What is the correct way to type-annotate a destructuring assignment + parameter defaults?

For example:
const options = {
  x: {
    a: 'AAA',
    b: 'BBB',
    c: {
      d: 'DDD'
    }
  },

  y: 'YYY'
};

(function({
  x: {a, b, c} = {a: 'aaa'},
  y = 'yyy',
  z = 'zzz'
} = {}) {
  console.log(a, b, c, y, z);
})(options);

Is it the following?
(function({
  x: {a, b, c} = {a: 'aaa'},
  y = 'yyy',
  z = 'zzz'
}: {
  x: {a: String, b: String, c: Object},
  y: String,
  z: String
} = {}) {
  console.log(a, b, c, y, z);
})(options);

Destructuring + defaults is not currently supported, but you're mostly right. I expect you wanted string instead of String (primitive vs. class instance).
Also, something interesting happens when you add a default value. Consider the following:
function foo({ bar = "baz" }): string { return bar }

The type of the destructured bar binding within the function is string, but the type of the function itself is (o: { bar?: string }) => string, that is, the key is optional, and the type of bar is effectively void | string.
At least, that's how I expect it will work, once we implement it.

@samwgoldman bar doesn't seem to be optional in the example I think?

@gsklee It absolutely is optional. The default makes it optional. That's why you can call foo like this: foo({}).

@samwgoldman Oh okay... I think I got it. So when we speak about types, we are only concerned about the thing that we actively send in, not something that is automatically assigned like, in this instance, defaults?

@gsklee I'm not sure I understand the question, but maybe I can clarify things with alternate phrasing. There are 2 types here that matter: 1) the type of the function foo and 2) the type of the function-local binding bar, which results from the destructuring in the param list. These types are respectively (o: { bar?: string }) => string and string.
Note that { bar?: string } is equivalent to { bar: void | string }.
Normally you can ignore this distinction, but it is always there. Consider a simpler example without destructuring:
function foo(bar): string {
  return bar;
}

Here, the type of foo is (bar: string) => string and the type of the function-local binding bar is string. We might casually say that bar is string, ignoring there are two sides of the story.
However, we are forced to see it from both sides once we add defaults:
function foo(bar = ""): string {
  return bar;
}

Here, the type of foo "changes" to (bar?: string) => string while the type of the function-local binding bar remains string. It's harder to casually say that bar is string, because from the perspective of the caller of foo, bar-the-argument is actually string | void.
Clear?

Clear and interesting, now I see it. Thanks!


continuous integration test on files

It would be grate to have the ci to run sw on the test/test dirtectory then to compare this dirtectory with test/expected to ensure that sw works as expected

https://insta.rs/


Issue 3918 Check Versions Tool

Issue #3918 - Tool to check for updated version of dependencies
This is a new Rust written utility to read the kata-containers/versions.yaml file and automatically check for the latest version of items listed in that file.
Limitations

Not all dependencies are checked owing to difficulties in deciding how to check the version of particular dependencies.
Most Github repositories are checked against the latest released version.  QEMU repositories do not have any releases so they are not checked.
Parsing the verions.yaml file is difficult as the structure of the file doesn't lend itself to being parsed.  There is currently a tight coupling of the versions.yaml file with the check_versions utility.  Any additional dependencies added to the version.yaml will require a code change.  Because of this, we recommend changing the versions.yaml file to be more parser friendly.

Closing to submit upstream


Can't drag n drop image from email to JIRA

I often just want to drag an image from an email and drop it in a comment in JIRA. I have installed the plugin to see if it would help, but unfortunately it did not. If that could be supported it would be grea! Currently I either make a screen snip and paste it or save the image to disk then drag that to JIRA.
Thank you

+1 for image from outlook drag'n'drop to Jira
I currently copy it, open with greenshot, copy again, and paste to Jira.
Even better would be ability to drag'n'drop (or copy/paste) a selection including inline images to Jira.
Thanks for the plugin, it is already very useful for the attachments!


WFCORE-640 - Add file permissions checks during execution of add-user.bat/add-user.sh

I've completed my work on this issue.  Creating pull request.

Can one of the admins verify this patch?

I found an issue within the unit test case.  I need to close this pull request and submit a new one with an updated unit test.


[experimental][llms][ollama_functions] Update OllamaFunctions to send tool_calls attribute

Update OllamaFunctions to return tool_calls for AIMessages when used for tool calling.

@baskaryan Can I please get a review on this? Thanks.

I believe this would close #21479

@baskaryan @hwchase17 @eyurtsev  @efriis  can I get a review please? Let me know if anything was missed so I can fix it.

@ccurme I've attempted to make code adjustments based on your recommendations.
Can I get another review? Thanks.
cc @baskaryan @hwchase17

@ccurme @baskaryan @hwchase17 @eyurtsev can this PR be reviewed and merged please?

@lalanikarim Thank you for this PR. Is there a way to execute the tool and then submit back the tool output (ToolMessage) to the LLM and continue chatting with the LLM?

@andreibondarev Take a look at this notebook. Let me know if this works for you.
https://github.com/lalanikarim/austin_langchain/blob/messagegraph-tool-calling/labs/LangChain_108/langgraph-messagegraph-ollamafunctions.ipynb

@lalanikarim Is there any way to see the full complete prompts that are being sent to Ollama? Btw -- I'm working on adding Function Calling capabilities to langchain.rb.

@lalanikarim Is there any way to see the full complete prompts that are being sent to Ollama? Btw -- I'm working on adding Function Calling capabilities to langchain.rb.

Yes @andreibondarev
On the notebook I shared, there are links for langsmith traces for a few test attempts that you should be able to review.
That should provide you with information about the prompts etc.
Let me know if that format doesn't work for you for any reason. I would be more than happy to provide additional information.

@lalanikarim From this step it's unclear to me how:
{
  "input": [
    {
      "content": "What is the sum of 2 and 3?",
      "additional_kwargs": {},
      "response_metadata": {},
      "type": "human",
      "id": "e69708f0-bc51-4ff5-b399-479772c70684",
      "example": false
    },
    {
      "content": "",
      "additional_kwargs": {},
      "response_metadata": {},
      "type": "ai",
      "id": "run-f299a20d-ec50-40a4-b5c0-f1c8b9de8a34-0",
      "example": false,
      "tool_calls": [
        {
          "name": "add",
          "args": {
            "a": 2,
            "b": 3
          },
          "id": "call_226e4ac1daff4d5e81094a7241bea4a4"
        }
      ],
      "invalid_tool_calls": []
    },
    {
      "content": "5",
      "additional_kwargs": {},
      "response_metadata": {},
      "type": "tool",
      "name": "add",
      "id": "baa89d64-2b9d-415c-91ed-033da8f17b1f",
      "tool_call_id": "call_226e4ac1daff4d5e81094a7241bea4a4"
    }
  ]
}

gets serialized into a POST localhost:11434/api/chat to the Ollama process. I'm specifically interested what the body of that request looks like.
I can see how OllamaFunctions is structuring the original prompt, before a tool is called, but it's unclear to me how the tool output gets merged back into the prompt: or messages:

@lalanikarim From this step it's unclear to me how:
{
  "input": [
    {
      "content": "What is the sum of 2 and 3?",
      "additional_kwargs": {},
      "response_metadata": {},
      "type": "human",
      "id": "e69708f0-bc51-4ff5-b399-479772c70684",
      "example": false
    },
    {
      "content": "",
      "additional_kwargs": {},
      "response_metadata": {},
      "type": "ai",
      "id": "run-f299a20d-ec50-40a4-b5c0-f1c8b9de8a34-0",
      "example": false,
      "tool_calls": [
        {
          "name": "add",
          "args": {
            "a": 2,
            "b": 3
          },
          "id": "call_226e4ac1daff4d5e81094a7241bea4a4"
        }
      ],
      "invalid_tool_calls": []
    },
    {
      "content": "5",
      "additional_kwargs": {},
      "response_metadata": {},
      "type": "tool",
      "name": "add",
      "id": "baa89d64-2b9d-415c-91ed-033da8f17b1f",
      "tool_call_id": "call_226e4ac1daff4d5e81094a7241bea4a4"
    }
  ]
}

gets serialized into a POST localhost:11434/api/chat to the Ollama process. I'm specifically interested what the body of that request looks like.
I can see how OllamaFunctions is structuring the original prompt, before a tool is called, but it's unclear to me how the tool output gets merged back into the prompt: or messages:

I can spend some time over the weekend and get you some additional information.
Feel free to reach out to me over email so we can continue to collaborate on this.

@andreibondarev
Here is a sample curl request with two tools:
curl --request POST \
  --url http://localhost:11434/api/chat \
  --header 'Content-Type: application/json' \
  --header 'User-Agent: insomnia/9.2.0' \
  --data '{
	"model": "phi3",
	"format": "json",
	"stream": false,
	"messages": [
		{"role": "system", "content": "You have access to the following tools:\n\n[\n  {\n    \"name\": \"add\",\n    \"parameters\": {\n      \"title\": \"addSchema\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"a\": {\n          \"title\": \"A\",\n          \"type\": \"integer\"\n        },\n        \"b\": {\n          \"title\": \"B\",\n          \"type\": \"integer\"\n        }\n      },\n      \"required\": [\n        \"a\",\n        \"b\"\n      ]\n    },\n    \"description\": \"A tool to add two numbers\"\n  },\n  {\n    \"name\": \"duckduckgo_search\",\n    \"parameters\": {\n      \"title\": \"DDGInput\",\n      \"description\": \"Input for the DuckDuckGo search tool.\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"query\": {\n          \"title\": \"Query\",\n          \"description\": \"search query to look up\",\n          \"type\": \"string\"\n        }\n      },\n      \"required\": [\n        \"query\"\n      ]\n    },\n    \"description\": \"A wrapper around DuckDuckGo Search. Useful for when you need to answer questions about current events. Input should be a search query.\"\n  }\n]\n\nYou must always select one of the above tools and respond with only a JSON object matching the following schema:\n\n{\n  \"tool\": <name of the selected tool>,\n  \"tool_input\": <parameters for the selected tool, matching the tool'\''s JSON schema>\n}\n"},
		{"role": "user", "content": "what is the sum of 1 and 2?"}
	]
}'

Output
{
	"model": "phi3",
	"created_at": "2024-06-22T08:14:53.471415739Z",
	"message": {
		"role": "assistant",
		"content": "{\"tool\": \"add\", \"tool_input\": {\"a\": 1, \"b\": 2}}"
	},
	"done_reason": "stop",
	"done": true,
	"total_duration": 734605545,
	"load_duration": 2315856,
	"prompt_eval_count": 11,
	"prompt_eval_duration": 207173000,
	"eval_count": 24,
	"eval_duration": 374549000
}

This is the response for the tool call from Ollama.
This is then used to invoke the appropriate tool usually through an executor.
from langgraph.prebuilt import ToolNode
from langchain_core.messages import AIMessage, ToolMessage
tools = [] # this needs to be populated with individual tools
tool_node = ToolNode(tools)

ai_resp: AIMessage = llm_with_tools.invoke("what is 2 + 2?")

tool_resp: ToolMessage = tool_node([ai_resp]) # tool_node identifies the correct tool and invokes it with the arguments from the ai_resp

print(tool_resp.content) # content property of ToolMessage contains the response from the tool's execution

I hope this helps.

This is the response for the tool call from Ollama.
This is then used to invoke the appropriate tool usually through an executor.
from langgraph.prebuilt import ToolNode
from langchain_core.messages import AIMessage, ToolMessage
tools = [] # this needs to be populated with individual tools
tool_node = ToolNode(tools) # ToolNode is a tool executor that can identify and run tool from details within AIMessage

ai_resp: AIMessage = llm_with_tools.invoke("what is 2 + 2?")

tool_resp: ToolMessage = tool_node([ai_resp]) # tool_node identifies the correct tool and invokes it with the arguments from the ai_resp

print(tool_resp.content) # content property of ToolMessage contains the response from the tool's execution

I hope this helps.

First off -- I really appreciate how responsive you've been here!
Once I've got the tool_resp.content, how can I send the tool output back to the model using the /api/chat endpoint? Something along the lines:
curl --request POST \
  --url http://localhost:11434/api/chat \
  --header 'Content-Type: application/json' \
  --header 'User-Agent: insomnia/9.2.0' \
  --data '{
	"model": "phi3",
	"format": "json",
	"stream": false,
	"messages": [
		{"role": "system", "content": "You have access to the following tools:\n\n[\n  {\n    \"name\": \"add\",\n    \"parameters\": {\n      \"title\": \"addSchema\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"a\": {\n          \"title\": \"A\",\n          \"type\": \"integer\"\n        },\n        \"b\": {\n          \"title\": \"B\",\n          \"type\": \"integer\"\n        }\n      },\n      \"required\": [\n        \"a\",\n        \"b\"\n      ]\n    },\n    \"description\": \"A tool to add two numbers\"\n  },\n  {\n    \"name\": \"duckduckgo_search\",\n    \"parameters\": {\n      \"title\": \"DDGInput\",\n      \"description\": \"Input for the DuckDuckGo search tool.\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"query\": {\n          \"title\": \"Query\",\n          \"description\": \"search query to look up\",\n          \"type\": \"string\"\n        }\n      },\n      \"required\": [\n        \"query\"\n      ]\n    },\n    \"description\": \"A wrapper around DuckDuckGo Search. Useful for when you need to answer questions about current events. Input should be a search query.\"\n  }\n]\n\nYou must always select one of the above tools and respond with only a JSON object matching the following schema:\n\n{\n  \"tool\": <name of the selected tool>,\n  \"tool_input\": <parameters for the selected tool, matching the tool'\''s JSON schema>\n}\n"},
		{"role": "user", "content": "what is the sum of 1 and 2?"},
		{"role": "tool", "content": "3"}, # <-- The "tool" role here is invalid so is it possible?
	]
}'

At this point I'd like to then have the LLM take the result of the tool call and, following the conversational flow, respond with something like "The sum of 1 + 2 equals 3".

@andreibondarev
Currently, Ollama only supports "system", "user", and "assistant" for roles. https://github.com/ollama/ollama/blob/main/docs/api.md#parameters-1
I've been able to circumvent this restriction by sending "role" as "assistant" for tool messages.
There is also a default response tool that you need to add as a default tool in order to handle the last step of converting tool response to a conversational response.
This tool will not be handled by your tool executor but will ensure that your final response meets a certain predetermined structure.
Here is the updated curl request which includes the default conversation response tool.
First request to Ollama with tools and a question
curl --request POST \
  --url http://aurora:11434/api/chat \
  --header 'Content-Type: application/json' \
  --header 'User-Agent: insomnia/9.2.0' \
  --data '{
	"model": "phi3",
	"format": "json",
	"stream": false,
	"messages": [
		{"role": "system", "content": "You have access to the following tools:\n\n[\n  {\n    \"name\": \"add\",\n    \"parameters\": {\n      \"title\": \"addSchema\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"a\": {\n          \"title\": \"A\",\n          \"type\": \"integer\"\n        },\n        \"b\": {\n          \"title\": \"B\",\n          \"type\": \"integer\"\n        }\n      },\n      \"required\": [\n        \"a\",\n        \"b\"\n      ]\n    },\n    \"description\": \"A tool to add two numbers\"\n  },\n  {\n    \"name\": \"duckduckgo_search\",\n    \"parameters\": {\n      \"title\": \"DDGInput\",\n      \"description\": \"Input for the DuckDuckGo search tool.\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"query\": {\n          \"title\": \"Query\",\n          \"description\": \"search query to look up\",\n          \"type\": \"string\"\n        }\n      },\n      \"required\": [\n        \"query\"\n      ]\n    },\n    \"description\": \"A wrapper around DuckDuckGo Search. Useful for when you need to answer questions about current events. Input should be a search query.\"\n  },\n  {\n    \"name\": \"__conversational_response\",\n    \"description\": \"Respond conversationally if no other tools should be called for a given query.\",\n    \"parameters\": {\n      \"type\": \"object\",\n      \"properties\": {\n        \"response\": {\n          \"type\": \"string\",\n          \"description\": \"Conversational response to the user.\"\n        }\n      },\n      \"required\": [\n        \"response\"\n      ]\n    }\n  }\n]\n\nYou must always select one of the above tools and respond with only a JSON object matching the following schema:\n\n{\n  \"tool\": <name of the selected tool>,\n  \"tool_input\": <parameters for the selected tool, matching the tool'\''s JSON schema>\n}\n"},
		{"role": "user", "content": "what is the sum of 121231 and 989876?"}
	]
}'

Response from Ollama with tool info and args
{
	"model": "phi3",
	"created_at": "2024-06-22T18:03:39.362463777Z",
	"message": {
		"role": "assistant",
		"content": "{\"tool\": \"add\", \"tool_input\": {\"title\": \"addSchema\", \"a\": 121231, \"b\": 989876}}"
	},
	"done_reason": "stop",
	"done": true,
	"total_duration": 737056562,
	"load_duration": 1970340,
	"prompt_eval_duration": 191930000,
	"eval_count": 41,
	"eval_duration": 400907000
}

Next you get the tool executor involved and get your response as a ToolMessage
You can now append both the Ollama "assistant" response message containing the tool info and the new ToolMessage response from your tool executor as role=assistant instead of role=tool.
Here is how the second curl request to ollama looks like and it should hopefully return a response with tool = "__conversational_response" or no tool at all but with a "tool_input" property where you should find your final output.
Second request to Ollama with previous response and the tool executor response appended to the messages.
curl --request POST \
  --url http://aurora:11434/api/chat \
  --header 'Content-Type: application/json' \
  --header 'User-Agent: insomnia/9.2.0' \
  --data '{
	"model": "phi3",
	"format": "json",
	"stream": false,
	"messages": [
		{"role": "system", "content": "You have access to the following tools:\n\n[\n  {\n    \"name\": \"add\",\n    \"parameters\": {\n      \"title\": \"addSchema\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"a\": {\n          \"title\": \"A\",\n          \"type\": \"integer\"\n        },\n        \"b\": {\n          \"title\": \"B\",\n          \"type\": \"integer\"\n        }\n      },\n      \"required\": [\n        \"a\",\n        \"b\"\n      ]\n    },\n    \"description\": \"A tool to add two numbers\"\n  },\n  {\n    \"name\": \"duckduckgo_search\",\n    \"parameters\": {\n      \"title\": \"DDGInput\",\n      \"description\": \"Input for the DuckDuckGo search tool.\",\n      \"type\": \"object\",\n      \"properties\": {\n        \"query\": {\n          \"title\": \"Query\",\n          \"description\": \"search query to look up\",\n          \"type\": \"string\"\n        }\n      },\n      \"required\": [\n        \"query\"\n      ]\n    },\n    \"description\": \"A wrapper around DuckDuckGo Search. Useful for when you need to answer questions about current events. Input should be a search query.\"\n  },\n  {\n    \"name\": \"__conversational_response\",\n    \"description\": \"Respond conversationally if no other tools should be called for a given query.\",\n    \"parameters\": {\n      \"type\": \"object\",\n      \"properties\": {\n        \"response\": {\n          \"type\": \"string\",\n          \"description\": \"Conversational response to the user.\"\n        }\n      },\n      \"required\": [\n        \"response\"\n      ]\n    }\n  }\n]\n\nYou must always select one of the above tools and respond with only a JSON object matching the following schema:\n\n{\n  \"tool\": <name of the selected tool>,\n  \"tool_input\": <parameters for the selected tool, matching the tool'\''s JSON schema>\n}\n"},
		{"role": "user", "content": "what is the sum of 121231 and 989876?"},
		{"role": "assistant", "content": "{\"tool\": \"add\", \"tool_input\": {\"a\": 121231, \"b\": 989876}}" },
		{"role": "assistant", "content": "11223344"}
	]
}'

Response from Ollama containing the conversational response
{
	"model": "phi3",
	"created_at": "2024-06-22T18:04:08.824591029Z",
	"message": {
		"role": "assistant",
		"content": "{\"tool\": \"__conversational_response\", \"tool_input\": {\"response\": \"The sum of 121231 and 989876 is 11223344.\"}}"
	},
	"done_reason": "stop",
	"done": true,
	"total_duration": 542249066,
	"load_duration": 2236045,
	"prompt_eval_duration": 16764000,
	"eval_count": 51,
	"eval_duration": 376474000
}

You can now extract the final conversational response output from ollama response using the following pseudo code:
content = json decode (message->content)
conversational response = content->tool_input->response
Notice that I deliberately appended incorrect value as the "Tool Message" response in the second ollama call. Ollama then returned that back as the answer to the original question.
The correct answer is 1111107 and not 11223344. But this interaction helps verify that the LLM is returning the tool response back and not attempting to hallucinate a sum itself, in which case, the answer returned would not have been 11223344 but something else.

For your reference
Here is the original System message template for OllamaFunctions
https://github.com/langchain-ai/langchain/blob/987099cfcda6f20140228926e9d39eed5ccd35b4/libs/experimental/langchain_experimental/llms/ollama_functions.py#L43-L52
Here is the default response tool definition that needs to be added as the last tool.
https://github.com/langchain-ai/langchain/blob/987099cfcda6f20140228926e9d39eed5ccd35b4/libs/experimental/langchain_experimental/llms/ollama_functions.py#L55-L70

@lalanikarim Thank you so much! I'm still poking around; haven't been able to get consistent results yet. Just curious -- why'd you use phi3?

@lalanikarim Thank you so much! I'm still poking around; haven't been able to get consistent results yet. Just curious -- why'd you use phi3?

I run into inconsistent results as well. The choice of model you use as well as the tool definitions could have an impact on consistency of the generated output. In my local testing, I sometimes have to make the same call a couple of times before I get the desired outcomes. This usually happens when my tool names or definitions are not specific enough that can trip the model to hallucinate a conversational response instead of tool calling response.
I tested with both llama3 and phi3 locally and discovered that while both did a decent job producing JSON output, phi3 seemed to generate tool calling outputs far more consistently than llama3. For example, llama3 would create valid JSON but would change keys more often than phi3.
I hope this was helpful.

@lalanikarim Thank you so much! I'm still poking around; haven't been able to get consistent results yet. Just curious -- why'd you use phi3?

I run into inconsistent results as well. The choice of model you use as well as the tool definitions could have an impact on consistency of the generated output. In my local testing, I sometimes have to make the same call a couple of times before I get the desired outcomes. This usually happens when my tool names or definitions are not specific enough that can trip the model to hallucinate a conversational response instead of tool calling response.
I tested with both llama3 and phi3 locally and discovered that while both did a decent job producing JSON output, phi3 seemed to generate tool calling outputs far more consistently than llama3. For example, llama3 would create valid JSON but would change keys more often than phi3.
Plus phi3 being a smaller model makes it easier to test on machines without a GPU and I tend to switch machines more often depending on the day.
I hope this was helpful.

From my experience, mistral v0.3 7B and solar 10.7b are the top models at following structured requests. The rest will sometimes randomly decide to change the structure regardless of how you prompt them


Cherry-Pick: Enable OpenStack tenant deploys Passphrase to TLS offload to protect …

…the Private Key
This patch enables private key passphrase upload within ssl profile.
(cherry picked from commit 5e514ab5997550604293e8599e740125e5908853)

Link #1335


Are there ways to improve the accuracy of Question Answering?

I followed the instructions from this notebook and started with just one document, a driving guide for British Columbia.
While the model manages to answer some questions, a lot of answers even to simple questions (like "what does flashing green light mean?" or "can you cross a solid yellow line?") are either wrong or said to be unavailable (despite the document containing them).
Is there a way to improve the accuracy of matching?

I think you might've run into the number of pages limitation.

Document AIThe following limits apply for online processing with the Document OCR processor.
Limit | Value
-- | --
Maximum file size | 20 MB
**Maximum pages | 15**
For documents that don't meet these limits, you can use batch processing to extract the document text. (Not covered in this notebook.)

Document AI
The following [limits](https://cloud.google.com/document-ai/quotas) apply for online processing with the Document OCR processor.
Limit	Value
Maximum file size	20 MB
Maximum pages	15
For documents that don't meet these limits, you can use batch processing to extract the document text. (Not covered in this notebook.)

Please see comment above. Closing this issue.


Unable to start vite after 0.9.0

Hey,
Thanks for your continuous work on this 👋
just letting you know that upgrading to 0.9.0 lead to being unable to start vite,
it launched then get stuck after generating the relay files,
probably not passing the hand to the rest of the process
i suspect this one https://github.com/cometkim/vite-plugin-relay-lite/commit/b2dd74f2e9b250ffea9a5fba2d806bc97b3d5ffa#diff-a9837633f28b4c63886d9fe0a38b8dc2dab4baf078a2401d61b3cbade96efe32L51

will be fixed in v0.9.1. perhaps I missed something with signaling

thanks for the quick actions 🙌  ❤  ...let me know if i can help


Add DaeMeshGeometry, StlMeshGeometry and abstract class MeshGeometry

Goes along with https://github.com/rdeits/meshcat/pull/48
TODO:

[ ] Get https://github.com/rdeits/meshcat/pull/48 reviewed and merged
[ ] Update meshcat submodule
[ ] New meshcat-python pip release

Codecov Report

Merging #36 into master will decrease coverage by 0.83%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   87.17%   86.34%   -0.84%
==========================================
  Files           8        8
  Lines         577      593      +16
==========================================
+ Hits          503      512       +9
- Misses         74       81       +7

Impacted Files
Coverage Δ

src/meshcat/geometry.py
84.42% <70%> (-2.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4816882...7f522c8. Read the comment docs.

This also looks great, thanks again!
Do you have any example STL and DAE meshes we can include as test cases?

I've updated the meshcat submodule and added a note to the demo that DAE and STL could be loaded as well. I did not add any meshes directly.

@rdeits Is this good to merge?

I'm trying to add test meshes to make sure this works. The STL loader looks good, but my naive attempt to generate a DAE mesh with meshlab isn't loading yet. I'll merge this as soon as I've got the new tests passing.

Ok, this is now merged and available on pip in meshcat v0.0.14

Thank you, Robin! :-)


transformers version

Hi Wenhu,
I got a problem when running Step 2-2. I guess there are some problems about the transformers version. Could you specify the version you used?
Thanks,
Junjie

Thanks for the reminder, I have updated the README, the version should be Transformers 2.2.1


sanitycheck: only match 1 regex per line

Current logic searches all regex strings for a match to each line,
regardless of whether an existing match has been made.
This makes matching a similar regex later in the list impossible.
Let's only match once and then quit the regex loop.
Signed-off-by: Michael Scott<EMAIL_ADDRESS>

This addresses sanitycheck error on real HW for:
https://github.com/zephyrproject-rtos/zephyr/blob/master/samples/drivers/watchdog/sample.yaml
There are 2 issues here with this PR fixing 1 of them:

The "Watchdog sample application" string will be matched in both places at the first occurance.  Which doesn't allow the other match to happen later.  Causes a test timeout. (Fixed with this PR)
The logic in sanitycheck demands that all of the regexes be unique otherwise they will fail the check here:
https://github.com/zephyrproject-rtos/zephyr/blob/master/scripts/sanity_chk/harness.py#L69
This requires a follow-up patch to the watchdog sample.yml file.

Thank you for pointing out @andyross changes.  I'm not sure the branch I was testing had those changes in it...  Let me go back and do some testing.

Looks like this was noise as @andyross previous changes solve most of the issues I saw when I was testing a slightly out of date master (w/o his changes).

FWIW: if we want to address this, maybe just removed the "!ordered" feature entirely?

FWIW here's a surprisingly short list of handler.log files that I observed to be racy (most by design). That doesn't mean they all require ! ordered but it should be superset of those that do.
samples/cpp_synchronization/sample.cpp_syncronisation/handler.log
samples/portability/cmsis_rtos_v./timer_synchronization/sample.portability.cmsis_rtos_v.timer_synchronization/handler.log
samples/userspace/shared_mem/sample.kernel.memory_protection.shared_mem/handler.log
samples/synchronization/sample.synchronization.*/handler.log
tests/cmsis_rtos_v2/portability.cmsis_rtos_v2/handler.log
tests/kernel/fifo/fifo_api/kernel.fifo/handler.log
tests/kernel/lifo/lifo_usage/kernel.lifo.usage/handler.log
tests/kernel/fifo/fifo_timeout/kernel.fifo.timeout/handler.log
tests/kernel/fifo/fifo_timeout/kernel.fifo.timeout.poll/handler.log
tests/posix/common/portability.posix.*/handler.log


error building wheel for pymodes

Running sudo python3 -m pip install adsbcot[with_pymodes]
ends with:
subprocess.CalledProcessError: Command '['/usr/bin/python3', 'build.py']' returned non-zero exit status 1.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pymodes
Failed to build pymodes
ERROR: Could not build wheels for pymodes, which is required to install pyproject.toml-based projects

full error
sudo python3 -m pip install adsbcot[with_pymodes]
[sudo] password for wade:
Requirement already satisfied: adsbcot[with_pymodes] in /usr/lib/python3/dist-packages (8.0.2)
Requirement already satisfied: aircot>=1.2.0 in /usr/lib/python3/dist-packages (from adsbcot[with_pymodes]) (3.0.1)
Requirement already satisfied: pytak>=5.4.0 in /usr/lib/python3/dist-packages (from adsbcot[with_pymodes]) (7.1.0)
Collecting pymodes>=2.8
Using cached pymodes-2.18.tar.gz (329 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Collecting numpy>=1.26
Using cached numpy-2.1.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (16.3 MB)
Collecting pyzmq>=24.0
Using cached pyzmq-26.2.0-cp310-cp310-manylinux_2_28_x86_64.whl (868 kB)
Building wheels for collected packages: pymodes
Building wheel for pymodes (pyproject.toml) ... error
error: subprocess-exited-with-error
× Building wheel for pymodes (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [32 lines of output]
Compiling pyModeS/c_common.pyx because it depends on /tmp/pip-build-env-z3g7p_pi/overlay/local/lib/python3.10/dist-packages/Cython/Includes/libc/string.pxd.
Compiling pyModeS/decoder/flarm/decode.pyx because it depends on /tmp/pip-build-env-z3g7p_pi/overlay/local/lib/python3.10/dist-packages/Cython/Includes/libc/string.pxd.
[1/2] Cythonizing pyModeS/c_common.pyx
[2/2] Cythonizing pyModeS/decoder/flarm/decode.pyx
Traceback (most recent call last):
File "/tmp/pip-install-qhd2eegk/pymodes_f0cfdd4cacbf40e6a8d29ce64ccb6a2f/build.py", line 67, in
build()
File "/tmp/pip-install-qhd2eegk/pymodes_f0cfdd4cacbf40e6a8d29ce64ccb6a2f/build.py", line 58, in build
for output in cmd.get_output_mapping():
File "/usr/lib/python3/dist-packages/setuptools/_distutils/cmd.py", line 103, in getattr
raise AttributeError(attr)
AttributeError: get_output_mapping
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in
main()
File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 261, in build_wheel
return _build_backend().build_wheel(wheel_directory, config_settings,
File "/tmp/pip-build-env-z3g7p_pi/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/api.py", line 58, in build_wheel
return WheelBuilder.make_in(
File "/tmp/pip-build-env-z3g7p_pi/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 88, in make_in
wb.build(target_dir=directory)
File "/tmp/pip-build-env-z3g7p_pi/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 123, in build
self._build(zip_file)
File "/tmp/pip-build-env-z3g7p_pi/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 172, in _build
self._run_build_script(self._package.build_script)
File "/tmp/pip-build-env-z3g7p_pi/overlay/local/lib/python3.10/dist-packages/poetry/core/masonry/builders/wheel.py", line 262, in _run_build_script
subprocess.check_call([self.executable.as_posix(), build_script])
File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', 'build.py']' returned non-zero exit status 1.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for pymodes
Failed to build pymodes
ERROR: Could not build wheels for pymodes, which is required to install pyproject.toml-based projects``

https://github.com/junzis/pyModeS/issues/168
It looks like pymodes is not building. Which this project utilizes


ESP 32 All of a sudden stops outputting to serial port mid-cpu start

It all of a sudden outputs a unknown character at the end. No dump or anything. The code is still running on the ESP 32 after the make monitor doesn't work. It just doesn't out put anything.
make monitor  PROJECT_NAME="Test"
MONITOR
--- idf_monitor on /dev/ttyUSB0 115200 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:812
load:0x40078000,len:0
load:0x40078000,len:10212
entry 0x40078a00
I (148) cpu_start: Pro cpu up.
I (148) cpu_start: Starting app cpu, entry point is 0x4008104c
0x4008104c: call_start_cpu1 at /home/Documents/control/rm/esp-idf/components/esp32/./cpu_start.c:219

I (0) cpu_start: App cpu up.
I (151) heap_init: Initializing. RAM available for dynamic allocation:
I (158) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (164) heap_init: At 3FFB3E88 len 0002C178 (176 KiB): DRAM
I (170) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (177) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (183) heap_init: At 40087F88 len 00018078 (96 KiB): IRAM
I (189) cpu_start: Pro cpu start user code
I (�

Never mind fixed it


unknown description

Hello experts,
I am trying to use the embedding generate from text connector with simple text which is throwing me unknown description. With the same connector configuration, I am able run document parser, splitter. Is there anything missing in the connector config?
ERROR 2024-11-15 18:48:30,768 [[MuleRuntime].uber.04: [vector-db-mac].vector-db-embeddText.CPU_LITE @7c2bdfc7] [processor: vector-db-embeddText/processors/0; event: e1b5c730-a381-11ef-a709-00059a3c7a00] org.mule.runtime.core.privileged.exception.DefaultExceptionListener:

Message               : null
Element               : vector-db-embeddText/processors/0 @ vector-db-mac:vector-db-mac.xml:40 (Embedding generate from text)
Element DSL           : <vectors:embedding-generate-from-text doc:name="Embedding generate from text" doc:id="e4a7b35e-e252-497b-97d7-9d9acd9f726b" config-ref="MAC_Vectors_Config" textToAdd="#[payload.text]" modelName="text-embedding-ada-002"></vectors:embedding-generate-from-text>
Error type            : MULE:UNKNOWN
FlowStack             : at vector-db-embeddText(vector-db-embeddText/processors/0 @ vector-db-mac:vector-db-mac.xml:40 (Embedding generate from text))

Hi @Drashti065
Looks like a wrong API Key. The Parser and splitter operations does not use the connector configuration. Is it a paid API Key you are using?

Hey Amir
Thank you and yes that makes sense I don’t have any api key configurations
in place . Do you mind redirecting me to get a provisional or trial
Key or a guide how to create one.
Many thanks
Drashti
On Sun, 17 Nov 2024 at 13:06, Amir Khan @.***> wrote:

Hi @Drashti065 https://github.com/Drashti065
Looks like a wrong API Key. The Parser and splitter operations does not
use the connector configuration. Is it a paid API Key you are using?
—
Reply to this email directly, view it on GitHub
https://github.com/MuleSoft-AI-Chain-Project/mule-vectors-connector/issues/41#issuecomment-2481259840,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZW5UDBBLXSOTMO4DH5ZB4L2BCIF5AVCNFSM6AAAAABR3YXUKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBRGI2TSOBUGA
.
You are receiving this because you were mentioned.Message ID:
<MuleSoft-AI-Chain-Project/mule-vectors-connector/issues/41/2481259840@
github.com>

@Drashti065 you can create API Keys by several vendors such as openai, huggingface, mistralai.
You have to register and provide billing informations:

For OpenAI: https://openai.com/index/openai-api/
For Mistral: https://mistral.ai/
For Hugging Face: https://huggingface.co/

Hope this helps.
Thanks
Amir


Access to v3 doc?

While we wait for all the V4 plugins and issues and docs to settle down, folks still need to get work done with V3.  It would be nice to have access to the docs.

@estaub It is something missing in the official website?

@montogeek I don't know what the current state is.  AFAICT, most of the changes needed for 4 aren't there yet, which is one of the things I'm waiting for before switching.
It will be very difficult to maintain doc that works well for both, though; everything different will need to be labeled 3-only or 4-only somehow, e.g. CommonsChunkPlugin, UglifyjsWebpackPlugin, the new optimization config, etc.  People will forget to preserve 3-only content, and it will make for awkward and error-prone reading.  I'd think it would be easier to just serve two versions of the doc as a whole than to worry about any of this.

missing v3 doc too. Can a snapshot be made accessible in something like https://webpack.js.org/3?

Everything in the website is for webpack 3, AFAIK nothing has been deleted.
CommonsChunkPlugin does not longer exists in webpack 4, but the page is available (https://webpack.js.org/plugins/commons-chunk-plugin/), the plan is to add a deprecation warning linking to its replacement, never remove it.
Making a snapshot of the docs would be good, but I am afraid it would require a lot of work since it does not exist.

@montogeek The black-and-blue chip in the upper corner of the doc saying "webpack v4.0.1" leads readers (like me) to think that it at least attempts to doc v4.

That shows the latest version, but I see your point

@estaub yeah the version pill is problematic and misleading because the docs are definitely 3.x but users will end up getting 4.x if they just run npm i webpack. I'd say we should have a version selector similar to something like Django or Ember

I second having a version selector. I frequently look for nonexistent old docs and am forced to do git blame to find the right version, and read source code itself.

Thinking more about this I am not sure if it is worth to have an entire version of the website for each version, although it is a major release, not a lot of things changed, there is 113 pages of documentation from which approximately only 25 (22%) would need an update for webpack 4

@montogeek At the risk of seeming snarky...  why do folks do all that forking with git?  Most of each of the forks are all the same.
Like forking, the advantage to having separate versions is complete unambiguity.  Otherwise, for any page that has no reference to 3 or 4, the reader is left wondering:

Is it 3, not updated yet?
Is it the same in both?
Is it 4-only, and the author of the v4 content forgot (or didn't know) to preserve 3-specific guidance?

I'm ignorant of the devilish details, but I'd be surprised if, at the end of the day, it's easier to cover 3 and 4 well in the same doc than it is to publish two versions.  It isn't of only temporary value, either; there will be a 5, 6, ...

I'm usually a proponent of having versioned docs.
It might feel a bit verbose, but I think it's critical to have at the very least major versions split out in the docs as they usually differ significantly.
We could opt for latest release of each major version?
We'd have to find a way to (re)structure this on the website, but a simple dropdown should suffice and maybe adding versioned sub-directories in the project (src/content/v3).
We would need some input from other people on this though, but I'm all for it!
For example, Vue.js has a version selector for the docs: https://vuejs.org/v2/api/

I am in as well!

@TheDutchCoder, thinking of what @montogeek said: since there are only less than 1/4 of the documentation need v4 update -- may be we can have version section in the same page, place V4 at the top section, which follow by V3 section, that way we can have this up quickly without having to add a drop down or restructure the entire website.
But however the decision to be, the the version pill has to go, becasue it is very confusing.

Isn't ironic that for a build system that seems to do very well in fingerprinting output assets fails in applying this to it's own documentation.
entry: {
  docs: '**/*.html'
},
output: {
  path: '[pkg.version.major].[pkg.version.minor]/[name].[ext]'
}

Something that really needs to be thought about.

Lodash does a great job of providing access to multiple versions of their docs both via url and through a UI control that lets you easily switch versions. This should be the standard way of doing things for any documentation.
Example.
https://lodash.com/docs/4.17.5

This is really, really confusing at the moment. I am required to use v3, and it's not stated anywhere that the docs for v4 are largely compatible with the docs for v3. Keeping snapshots of old docs for a project as large as webpack would be a huge plus.

Where is the v3 docs??? Some enterprises move very slowly on upgrades. We will be v3 for a few months yet.

Please use https://webpack.js.org/v3/ for webpack 3 docs.

@montogeek that link is perfect -- thanks!
Are there plans to add a version selector to the docs? (right now it's not really discoverable)

Great!
Little remark: the doc at https://webpack.js.org/v3/ still indicates it's v4.4.1.

https://github.com/webpack/webpack.js.org/issues/1854#issuecomment-368919143

If you tag the the v3 releases you should be able to reference the tag with the shields.io badge:
https://img.shields.io/npm/v/webpack/legacy.svg:
https://img.shields.io/npm/v/webpack/v3.svg:

For the love of God pls provide v3 doc.
Im crying for it...

@kinyat  i cloned it locally:
https://github.com/webpack/webpack.js.org/issues/1961#issuecomment-378963332

@kinyat Try again please

@montogeek https://webpack.js.org/v3/ is still 404, I'm afraid.

@montogeek It's up!

@estaub It is down (404) again  😭😭😭😭😭

@montogeek, the URL you provided still (or again) returns 404.

https://webpack.js.org/v3/ is still 404 for me. I am going to be on v3 for a while, so easy access to the documentation would be a big help.

It would definitely be really helpful having the old docs hosted someplace

https://webpack.js.org/v3/ is still 404 for me.
Need access to hook names for v3 plugins.

Hi Guys, we are thinking to create a sub-domain strategy for versions and probably add a dropdown switch to walk between the versions on the website frontend. This would result at first in v3.webpack.js.org and so on.
There is no ETA for this feature as we are still trying to agree terms and requirements with hosting provider.

I come here because I struggle to find the v3 documentation website only to find out that people are already talking about Webpack v5 while your documentation website has been in shambles since day one.

@stephan-v If you think you are solving anything by talking like that to people who are donating their spare time for you to have a free tool, you are sorely mistaken. Literally any minute I spend on this, including writing this answer, is spare time taken away from me being a parent to my daughter and a husband to my wife. Tell me how this equals "all the resources in the world" please?

Don't know perhaps the 400k in funding Webpack receives yearly?

@EugeneHlushko that gameplan sounds perfect. Hoping you guys get a solid deal from your hosting provider.
@stephan-v let's try to keep this conversation civil and constructive. The unfortunate reality is that for even the most popular open source projects like webpack, 95-99% of contributor's time is voluntary and unpaid. I sincerely wish this weren't the case, but that's how open source works for the time being.

@Munter, I wish more people would lay out the realities of OSS projects like this. Also, while I can still get lost in the complexity (and power) of Webpack and its configs, I think the docs have improved immensely since I first used it.
FYI, this still appears to work (be sure to get the correct tag). The version badge appears to be querying for latest, so it's misleading, but it looks like the old docs are faithfully presented in my local.

Another way is to look up the actual source code, like the default options:
https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsDefaulter.js#L73-L93

All I have to say is:

and https://api.jquery.com/category/version/1.0/.  Doh!

@moos So we are comparing asset bundlers to JavaScript libraries now?

The unfortunate reality is that for even the most popular open source projects like webpack, 95-99% of contributor's time is voluntary and unpaid. I sincerely wish this weren't the case, but that's how open source works for the time being.

If anyone wants to see this fixed, pay someone to do it: https://www.bountysource.com/

Here you can find a zip to download the guides. [StackOverFlow}(https://stackoverflow.com/a/52003486/8439926)

For Mainland Chinese developers https://webpack-3.cdn.bcebos.com/

This is official tagged doc for v3.11.0: https://github.com/webpack/webpack.js.org/tree/v3.11.0/src/content/configuration

@bendtherules https://webpack-v3.jsx.app is not working anymore :(

@harryi3t please use webpack-v3.netlify.com in the meantime.
I changed the registrar recently, probably missed something there. Will fix it soon

https://webpack.js.org/v3/

THis is gone, is there another way to view webpack 3 documentation ?  Thanks

the links from @bendtherules still work: https://webpack-v3.jsx.app/, https://webpack-v3.netlify.com

This is beyond ridicolous...

Looking for webpack 3 docs. How does such a big project drop the ball here?


Doesn't build

$ ./scripts/docker_build_ros.sh all > log.txt 2>&1
See attached log.txt. Thanks!
Jetson Xavxer NX
JetPack 4.5
log.txt

Hi @dheera, see #41 - https://github.com/dusty-nv/jetson-containers/issues/41#issuecomment-774767272


SMB listed twice in protocol list, second should be SMBS?

Hi,
in the list of supported protocols at https://everything.curl.dev/protocols/curl, it seems to me like SMB is listed twice, and that the second one should be SMBS. Also,  the contents of the second one say "SMBS over TLS", it should maybe be "SMB over TLS".

Makes sense. Want to make a PR for it?

Done: https://github.com/bagder/everything-curl/pull/147

Thanks


Error while adding Handlebars helper

I am trying to add a Handlebars helper but I get Handlebars is not defined error. I have selected Primary Content Language as HTML. I couldn't find any docs or examples for adding a new helper. Can you please suggest a solution?

Could you add your Handlebars helper code here?
I believe you should use 'handlebars' instead 'Handlebars' at the begining
handlebars.registerHelper("replace", (context, pattern, replacement) =>   context.replace(pattern, replacement) );


Delete Kamelet and KameletBinding type - can't create new route when there is empty list

Describe the Bug
When users create Kamelet or KameletBinding route type and delete the route using the delete route button in the dropdown list, the "new route" button stays disabled and users can't create new route of this type.
Steps to Reproduce the Bug or Issue

create kamelet or kameletbinding
delete the route using the delete button in the dropdown list
see the "new route" remains disabled

Screenshots or Videos

Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [latest]

It would be a same root cause with #2077

Fixed by #2111


Add call.mix() and reuse node for reinvite

@tinpotnick just on a side note, the reason for why originally I've put everything in reinvite() is that I thought (especially in the future) we will take any chance of a reinvite to see if we have a better node. The PR should be ready.


Ability to assert a property doesn't exist?

First of all, thank you very much for creating this utility! This is very useful for lib authors and I think it it something that TS should consider adopting as built-in.
Currently, expectError only asserts function argument type errors, and "property does not exist" errors are suppressed. This causes any missing property to have type any and will be passable to any function:
// assuming foo.bar does not exist, this will result in "Expected an error, but found none."
expectError(someFunc(foo.bar))

expectType<never>(foo.bar) also doesn't work because missing property defaults to any instead of never.
I am not entirely sure if it's a limitation of tsd or there is a simple way of doing this. Any insight is appreciated!

Never mind - it seems to be working now!

Thank you!
No problem! If I can be of any assistance, feel free to create an issue or send a DM. Happy to help :).


Toggle the component pick status by clicking on the component row

This will make picking easier since you don't have to hit the tiny hit area of the checkbox.

User was unable to pick by clicking on the checkbox. Now it's fixed.


OffscreenCanvas experimental in Safari 12.1

OffscreenCanvas can be enabled through Develop -> Experimental Features in Safari 12.1, and through Advanced -> Experimental Features in iOS Safari 12.1 (iOS 12.4).
Only WebGL contexts are supported, not 2d.
Validated using caniuse tests.

Note - the same menu option also enables createImageBitmap (menu option is "ImageBitmap and OffscreenCanvas")


Scrolling Behavior Issue on macOS

I am experiencing an issue with the scrolling behavior in oTerm where the content appears to bounce up and down when I try to scroll using the trackpad on my Macbook Air. Additionally,  the scrollbar will seem to get stuck and then bounce up and down when you try and move it.
I've attached a screen recording that demonstrates the bouncing scrolling effect:

Hey there, thanks :)
I will look into it asap, not sure I can fix it though.

Would you be able to comment on how to reproduce this? I've tried adding a few chats with code embedded and tried on iTerm as well as kitty (which I think is the one I see used in your video) but can't seem to be able to reproduce. Scrolling seems to work as expected for me.


Ways to retreive Open Port Data

Support guidelines

[X] I've read the support guidelines

I've found a bug and checked that ...

[X] ... the documentation does not mention anything about my problem
[X] ... there are no open or closed issues that are related to my problem

Description
Using docker-compose and adding the containers to the same network as a PIA vpn container to route torrent traffic.
When PIA gives out an open port for port-forwarding/rtorrent incoming connections we as users of their service do not have control over the opened port.
I got to the point the forwarded port works on other services and i can output the data into a plain text file.
How would we go about getting this configured in the rtorrent container?
Can I mount the /etc/rtorrent/.rtorrent.rc file into another container and have the file updated by the external one?
Expected behaviour
A way to obtain the opened port and let rtorrent access it, even on changes
Actual behaviour
defaults to default port of 50000
Steps to reproduce
N/A
Docker info
Client:
 Context:    default
 Debug Mode: false
 Plugins:
  app: Docker App (Docker Inc., v0.9.1-beta3)
  buildx: Docker Buildx (Docker Inc., v0.9.1-docker)
  compose: Docker Compose (Docker Inc., v2.5.1)
  scan: Docker Scan (Docker Inc., v0.23.0)

Server:
 Containers: 36
  Running: 30
  Paused: 0
  Stopped: 6
 Images: 127
 Server Version: 20.10.22
 Storage Driver: overlay2
  Backing Filesystem: xfs
  Supports d_type: true
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 9ba4b250366a5ddde94bb7c9d1def331423aa323
 runc version: v1.1.4-0-g5fd4c4d
 init version: de40ad0
 Security Options:
  seccomp
   Profile: default
  cgroupns
 Kernel Version: 6.1.4-1.el9.elrepo.x86_64
 Operating System: CentOS Stream 9
 OSType: linux
 Architecture: x86_64
 CPUs: 12
 Total Memory: 30.73GiB
 Name: box
 ID: QJEF:SMKS:U7P6:F4GK:S3MU:BOZX:PUGH:BHSO:U3VH:5S5D:6OHL:DPAG
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: fals

Version

Docker compose version (type docker-compose --version): (using docker compose not docker-compose) Docker version 20.10.22, build 3a2c30b
System info (type uname -a):Linux box 6.1.4-1.el9.elrepo.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Jan  4 18:19:21 EST 2023 x86_64 x86_64 x86_64 GNU/Linux

Docker compose
name: yarhar
services:
  rutorrent:
    cap_add:
    - CHOWN
    depends_on:
      vpn:
        condition: service_started
    environment:
      PGID: "971"
      PUID: "974"
      TZ: America/Denver
    image: crazymax/rtorrent-rutorrent
    mem_limit: "1073741824"
    network_mode: service:vpn
    ulimits:
      nofile:
        soft: 32000
        hard: 40000
      nproc: 65535
    volumes:
    - type: bind
      source: /docker2/rutorrent/data
      target: /data
      bind:
        create_host_path: true
    - type: bind
      source: /docker/media/
      target: /media
      bind:
        create_host_path: true
    - type: bind
      source: /docker/media/
      target: /downloads
      bind:
        create_host_path: true
    - type: bind
      source: /docker2/rutorrent/passwd
      target: /passwd
      bind:
        create_host_path: true
  vpn:
    cap_add:
    - NET_ADMIN
    - SYS_MODULE
    devices:
    - /dev/net/tun:/dev/net/tun
    environment:
      LOC: swiss
      NFTABLES: "1"
      PASS: password
      PORT_FORWARDING: "1"
      USER: username
    healthcheck:
      test:
      - CMD-SHELL
      - ping -c 1 www.google.com || exit 1
      timeout: 10s
      interval: 30s
      retries: 3
    image: thrnz/docker-wireguard-pia
    networks:
      default: null
    ports:
    - mode: ingress
      target: 9117
      published: "9118"
      protocol: tcp
    - mode: ingress
      target: 8080
      published: "8113"
      protocol: tcp
    sysctls:
      net.ipv4.conf.all.src_valid_mark: "1"
      net.ipv6.conf.all.disable_ipv6: "1"
      net.ipv6.conf.default.disable_ipv6: "1"
      net.ipv6.conf.lo.disable_ipv6: "1"
    volumes:
    - type: bind
      source: /docker/pia-wg/pia
      target: /pia
      bind:
        create_host_path: true
    - type: bind
      source: /docker/pia-wg/pia-shared
      target: /pia-shared
      bind:
        create_host_path: true
networks:
  default:
    name: yarhar_default

Container logs
N/A
Additional info
No response

A possible option would be to use swizzin if you want wireguard support. It configures your operating system instead of creating a docker container. You can use iptables to allow certain ports to bypass the PIA VPN. I have experience with this concept and have obtained a working configuration. If you have any questions, you can come on discord and ping Vertex.
XFS will have performance issues with rTorrent metadata processing. I recommend EXT4 for significantly higher performance. The torrent metadata is written to the disk is raw format. XFS does handle many small files very well compared to EXT4.


Gas cost metering: the initial exploration

Research and build a POC version of Owasm runtime that terminate upon reaching certain gas limit. It is still pretty much open ended, but this should be a good starting place: https://github.com/wasmerio/wasmer/blob/master/lib/middleware-common/src/metering.rs.
Deliverables:

[ ] Understand and present a possible way to do gas metering to prevent an infinite loop stops the network forever.
[ ] Build some hacky POC that shows there's a way to do it on D3N.

Not relevant anymore.


Typing emoji does not trigger textViewDidChange

Emojis get caught in the shouldChangeTextIn delegate method because their utf16 count is greater than 1. In instances where I'm needing to respond to textViewDidChange, it doesn't get called when an emoji is typed.

I believe I have a fix for this issue here if you want to take a look https://github.com/szweier/SZMentionsSwift/pull/95


Get access to target clicked on

Feature Request
In js you can use the event.target to see what the element is that you clicked on allowing you to have one click event but have more flexibility.
Implement Suggestion
For example
#[component]
pub fn menu() -> Element {
    rsx! {
        div {
            class: "menu-left",
            ul {
                onclick: move |event| {
                    if event.target.tag_name == "li" { ... }
                },

                li { "Home" }
                li { "About" }
                li { "Contact" }
                li { "Blog" }
            }
        }
    }
}

It would be nice to support something like target in the future that returns a boxed platform independant element type (like the onmounted event today). As a workaround, if you are targeting the web, you can downcast events to their web-sys event counterpart with the web_event method:
#[component]
pub fn menu() -> Element {
    rsx! {
        div {
            class: "menu-left",
            ul {
                onclick: move |event| {
                    let raw_event = event.web_event();
                    // ...
                },

                li { "Home" }
                li { "About" }
                li { "Contact" }
                li { "Blog" }
            }
        }
    }
}

Then you can get the target of that web-sys event

Ok, groovy, ty


Human portrait drawing is amazing!

I want to say that the result is amazing and inspiring. The guys from the Disney laboratory have been struggling for years over the tasks of non-photo-realistic render and line art stylization, they write heaps of articles about non-solvable problems in this direction.
The main problem is that this style contains a lot of symbolism that is contrary to the physics of lighting. This is especially true for parts of the face - eyes, lips, face contour, hair. It is just too hard to catch such nuances, genre traditions, and this model almost do it.
A few years ago I was developing an ink drawing robot and the main problem was getting a high-quality contour for the brush trajectory. And your approach greatly simplifies the task.
I have uploaded my tests, dir contains some thousands processed portrait photos including SR version and video test. Original photos can be found at readme file.

Hi, Vladimir,
Thanks a lot for your interests. The results look pretty good, especially
the videos. We thought about producing some video samples, but don't have
time to do that yet. Can I show one of your video results in this repo ?
Of course, this credit belongs to you.
Regards,
Xuebin
On Sat, Nov 28, 2020 at 5:55 PM Vladimir Seregin<EMAIL_ADDRESS>wrote:

I want to say that the result is amazing and inspiring. The guys from the
Disney laboratory have been struggling for years over the tasks of
non-photo-realistic render and line art stylization, they write heaps of
articles about non-solvable problems in this direction.
The main problem is that this style contains a lot of symbolism that is
contrary to the physics of lighting. This is especially true for parts of
the face - eyes, lips, face contour, hair. It is just too hard to catch
such nuances, genre traditions, and this model almost do it.
A few years ago I was developing an ink drawing robot and the main problem
was getting a high-quality contour for the brush trajectory. And your
approach greatly simplifies the task.
I have uploaded my tests https://yadi.sk/d/Df7ecM3LtXcNOA?w=1, dir
contains some thousands processed portrait photos including SR version and
video test. Original photos can be found at readme file.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NathanUA/U-2-Net/issues/106, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORIB3T2IZOAMTGJVHP3SSGLYZANCNFSM4UGEV5QQ
.

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/

Of course, it's up to you. I do not know if you can use the results of processing random videos from YouTube. I just picked up the first one I found with a soft light and a clear focus.
I left a link to the original video in the readme. If you have any problems with the source, I will repeat the processing on any other video that suits you.

Hi, I would like to share with you one small tool that I use when checking the quality of the models. It allows you to see the entire photo-dataset or results and quickly find problematic areas.
But in this case I just hard-code compassion between u2net and artline, it just allows you to quickly switch between two different models and observe the difference (keys 2, 3).
Interactive version here

That looks great, Vladimir. I also included your tool in the ReadMe file of
U^2-Net so that others can find and use that very easily.
On Tue, Dec 29, 2020 at 4:02 AM Vladimir Seregin<EMAIL_ADDRESS>wrote:

Hi, I would like to share with you one small tool
https://github.com/peko/nn-lineart that I use when checking the quality
of the models. It allows you to see the entire photo-dataset or results and
quickly find problematic areas.
But in this case I just hard-code compassion between u2net and artline, it
just allows you to quickly switch between two different models and observe
the difference (keys 2, 3).
Interactive version here https://peko.github.io/nn-lineart/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NathanUA/U-2-Net/issues/106#issuecomment-752036084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORJNJIRTXW52CQOXJTDSXGZKZANCNFSM4UGEV5QQ
.

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/

BTW, Vladimir. Would mind that I include the following gif of your NN based
lineart in the ReadMe file of U^2-Net as well. I think that will attract
more attention to both of our repos.
[image: image.png]
On Tue, Dec 29, 2020 at 7:51 PM Xuebin Qin<EMAIL_ADDRESS>wrote:

That looks great, Vladimir. I also included your tool in the ReadMe file
of U^2-Net so that others can find and use that very easily.
On Tue, Dec 29, 2020 at 4:02 AM Vladimir Seregin<EMAIL_ADDRESS>wrote:

Hi, I would like to share with you one small tool
https://github.com/peko/nn-lineart that I use when checking the
quality of the models. It allows you to see the entire photo-dataset or
results and quickly find problematic areas.
But in this case I just hard-code compassion between u2net and artline,
it just allows you to quickly switch between two different models and
observe the difference (keys 2, 3).
Interactive version here https://peko.github.io/nn-lineart/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NathanUA/U-2-Net/issues/106#issuecomment-752036084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORJNJIRTXW52CQOXJTDSXGZKZANCNFSM4UGEV5QQ
.

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/


[bug-fix] Metric reduction with Logging

What does this PR do?

Fixes #5146
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

@teddykoker @ananyahjha93 Mind a review ?

Why did you add the code to the callbacks and not where logging happens? Shouldn't the callback metrics contain the already computed/detached values? Now we have duplicated code, and each callback has to handle the Metric with this special condition? This does not look right.


chore: Make newFileSystem work for s3x provider

Relates to Issue #243
Description of changes:
Add integration test for FileSystems.newFileSystem(). Because the s3x provider wasn't supported for that operation, the implementation for FileSystems.newFileSystem() was updated.
also Fix a buggy client.close() on Readaheadbytechannel.close()`
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hey Mark, nothing planned before a v2 release 🚀


Fix "Delete Group success as Owner" test

Currently on the main branch the "Delete Group success as Owner" (tests/Feature/Api/v1/GroupsTest.php) feature test fails. This should be fixed.
See failed job: https://github.com/Thiritin/identity/actions/runs/11601859117/job/32305547237

After discussion, it appears that owners of groups should only be able to delete groups with the team type. So the test should reflect this change.


Joulescope 0.9.3 wont work on MacOs 10.15.7

Hi,
when trying to start joulescope it wont start with an older MacOs version. Heres the error I get.

$> /Applications/joulescope.app/Contents/MacOS/joulescope_launcher
[5877] Error loading Python lib '/Applications/joulescope.app/Contents/MacOS/Python': dlopen: dlopen(/Applications/joulescope.app/Contents/MacOS/Python, 10): Symbol not found: _preadv
Referenced from: /Applications/joulescope.app/Contents/MacOS/Python (which was built for Mac OS X 11.0)
Expected in: /usr/lib/libSystem.B.dylib
in /Applications/joulescope.app/Contents/MacOS/Python

Yes, Apple has made life very difficult for developers.  From our perspective, one Mac platform has now become three:

macOS 11.0.1 (Big Sur) on AMD64
macOS 10.x on AMD64
macOS 11.0.1 (Big Sur) on ARM

The official 0.9.3 release only supports (1).  Since you are running on (2), you have a few choices:

Run Joulescope UI 0.9.2 (which does not run on macOS 11, see #108 and the forum).
Wait until we figure out how to support macOS 10.  We may end up dropping official release support in favor of (3).
Run from homebrew.

If you choose to run from homebrew, you will be using the Joulescope python packages available on pypi.  First, install brew on your machine. Open a terminal, and type:
brew update
brew upgrade
pip3 install -U  joulescope_ui PySide2

You should then be able to run the Joulescope UI using:
python3 -m joulescope

Do any of these options work for you?

Thanks for the quick replay!
For now I have reverted to Joulescope 0.9.2. I didn't know that homebrew was also an option. Maybe I will give it a shot later.

Reopening.  Although we have workarounds, we still need to determine the official course of action.

After investigating, we have no easy answer.  We will distribute two macOS binaries for the upcoming release.  The two versions will be:

macOS 10 x86_64
macOS 11 x86_64

macOS 11 arm64 will run under Rosetta using the x86_64 binaries.  We will punt on creating universal binaries through pyinstaller.

Address in v0.9.7 with two download options.


124 Filter events by categories

Summary
Adds the category selection screen, where users can select which categories they want the events filtered by.
Trello card
Long description

As user makes category selection, the CTA will update with the number of events ( to read: "Show X events")
“Clear All” CTA appears when user makes one or more selection in the category list
Clicking “Clear all” strips all selections from the list
Clicking “Cancel” reverts back to the previous selection state (if user had previously made a category selection) and returns the user to the events listing
If a user selects multiple categories (e.g. nightlife & music), the count in CTA will calculate towards events tagged with 'music' AND/ OR 'nightlife', i.e.they will not be mutually exclusive
Only in the scenario where that there are no more events within a category, e.g. it is the last week of the festival and there are no more ‘health’ events then the health category should be removed from the filter list
If there are no more events in a category because a user has already selected OTHER filter options (e.g. accessibility requirements) then the CTA should be disabled
As a user selects a category it is displayed at the top of the page (in the “show me” box) in the order that it has been selected.

Ticket / Screens
https://app.zeplin.io/project/5a916701f75c524181eebe68/screen/5ab0408d372ffa6b20773e0e
https://trello.com/c/Qaxek2qR/124-ui-events-listing-filter-events-list-by-categories
Pre-flight check-list
Before raising a pull request

[x] Works on iOS
[x] Works on Android
[x] Documentation
[x] Unit tests

Pre-merge check-list

[ ] Tester approved

Quick update
Android is getting there

but there are still some issues on iOS with the category pills component:

Will probably need to rely on something like this
https://github.com/CMP-Studio/TheWarholOutLoud/blob/8ae8ce688ad827118f3c1ab444e3b5763cafd1fa/ios/CMSAccessibilityManager.swift and this https://facebook.github.io/react-native/docs/pixelratio.html#getfontscale to make this kind of work less painful. What do you think @frigus02 ?

Hm, so what exactly is the issue on iOS? I hoped that using minHeight instead of height just solves everything. Maybe that was naive 😄
getFontScale only works on Android, right?

minHeight ends up like this on iOS

getFontScale is android only, but I think we can access the font scale with a native module on iOS

Ok turns out getFontScale works quite well on iOS too.

Tested on the following:
Galaxy S8 (8.0) Physical
iPhone 7+ (10.3.1) Physical
iPhone 6 (10.3.3) Physical
Galaxy S7 (6.0) BrowserStack
Pixel 2 (8.0) BrowserStack
iPhone X (11.0) BrowserStack
Found a few issues but overall looks good!


Can't set mining mode for Anvil

Component
Anvil
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (eb4bfb2 2022-05-05T18:06:46.302249388+00:00)
What command(s) is the bug in?
anvil
Operating System
Linux
Describe the bug
The mining mode (auto, never, interval) cannot be set using the Anvil CLI.
In ethers-rs we expect -b to be exposed to set the block time, but that flag does not exist.

Sort of, it's still not possible to set never as the mining mode. I assume if you do not pass -b the mining mode is auto, otherwise it is interval.


Gif image not playing

I've send a gif on sealed topic and it doesn't play can you check it out ?
Also I can't navigate throw the images of the sealed topic always reload the same image

I am just testing your issue now, sorry for the delay.
I am able to reproduce your issue with gif not working on sealed topics, hopefully I will be able to resolve that soon.
I am not able to reproduce your issue of navigating through multiple images on a sealed message. I can tap on any of them, and the selected one loads first. I can also swipe on the loaded image and view the next or previous. Are you able to navigate images on non-sealed topics?

No, problem I notice now with what you asked that if I open an un-sealed topic and send picture

The picture isn't send, I exit the un-sealed topic and open it again it shows

Thbaks !

I see the 'invalid date' which must be a bug.
Are you also saying that an image isn't getting sent? The app uploads the image in the background, so if you exit immediately, it might not have finished posting the image. You can switch topics while it uploads, but if you exit the app, the upload will not complete. There should be a green progress bar that appears when uploading.

Yes the screen stays blank after the bar finish, also happens if I send text.
On the sealed topic works

This seems like a serious bug, but I am having trouble reproducing.
If you create a new topic with no members, then you post just text, will it show up?

https://github.com/balzack/databag/assets/46766062/e852ffe5-83f8-4701-9f76-7dc49868c94a
Let me know when you see to delete this video

i just saw the video, you can delete, thx!

It seems that the post is successful, but it's not synchronizing with the server. If you exit the app and then reload, does the data show up?

This seems like a serious bug, but I am having trouble reproducing.
If you create a new topic with no members, then you post just text, will it show up?

Same invalid date host error
https://github.com/balzack/databag/assets/46766062/d826eee2-ac7a-4058-957f-63b8c2be1823
Warn me when you see it to edit

I see this one also now, thank you.

It seems that the post is successful, but it's not synchronizing with the server. If you exit the app and then reload, does the data show up?

Uploading 2023-07-15_00-10-16.mp4…

The message arrives on computer if I send
mobile - computer but the topic seems to crash on mobile

I see this one also if you want to delete.

could you add me as a member to that topic? If I also get the same exception, then I would be able to capture it in the simulator.

Yes, send contact request

I just requested the account I see.

Failed to Update Contact
Please try again
When requesting

Hmm, it seems like the app is having trouble connecting to your server.
Can you try and connect to my account<EMAIL_ADDRESS>

The account doesn't seem to have any server attached

oops, yes...i was testing some use cases earlier in the week....is it fixed now?

Ive send an request

ok, i think we are connected...

If you get a chance, can you see if you have the same bug with unsealed topics on the demo server 'databag.coredb.org'?

Sorry didn't catch the last message
Yes I've got the same issue using 2 accounts on databag.coredb.org

For some reason I am unable to even reproduce the title and date issue on a topic now. I saw in on my phone when we were testing last time. I will continue testing as I know there is an issue here, just letting you know it might be awhile for me to understand the issue.

No problem take your time the sealed topic work
It happens when I

Open unseal topic
Send something
Go back
Enter the unsealed topic again

Here's the logcat during the topic creation if it helps
logcat_07-17-2023_01-14-21.txt

That is really helpful, any chance you can also get the logcat for when you send a message on the topic?
Thanks!!

Great !
I'll send you the logcat later

Here's the logcat
logcat1.txt
Thanks !

This captured the error, so I should be able to fix it soon. Thank you!!!

Just updated the app and the topic creation  bug is fixed !
Thanks !

such great news!!! I was really worried about this one as I could not reproduce it. thank you so much for the logs!!

The interest was mine and probably won't happen to others now
Once the gif fix get's uploaded I'll close this issue,
I'll leave it open to refer gif isn't working yet
Thanks  once again !


Color of text is washed out if text is not clickable

I have a specific color palette in mind. However, xbar automatically washes out the color if the text is not used as a button, which causes these colors to be incorrect. Is there any solutions to this?

This is expected bahviour. Just add | shell=true | terminal=false to the end of the line. This makes it be clickable but do nothing when you click it.


fix typos

Signed-off-by: bin liu<EMAIL_ADDRESS>

@liubin
Don't change .pb.go files directly. You need to change the corresponding .proto file and run make generate. :)

hi @liubin, instead of changing *.pb.go directly, you should apply your changes in *.proto and run make generate to get corresponding *.pb.go file.
Otherwise, ci would complain.

Thank you @runshenzhu  and @jimmyxian , I will try again.

[Current coverage][cc-pull] is 53.82%

Merging [#1037][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master      #1037   diff @@
==========================================
  Files            75         75
  Lines         11660      11660
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           6276       6276
- Misses         4480       4483     +3
+ Partials        904        901     -3

[][cc-pull]

Powered by Codecov. Last updated by [bd1c047...6e5cb34][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/bd1c04747f49a4e30e04acdcc5bdb233b712c238...6e5cb346c635fd325797c475a3a78e963e181554
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1037?src=pr

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-typos" git@github.com:liubin/swarmkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM


[Bug]: Entity explorer UI/UX issues

Is there an existing issue for this?

[X] I have searched the existing issues

Description

The scroll does not occupy the whole length of the explorer when all the items in it are expanded.
While adding a datasource we are not able to see a scroll in Create New pop up making it difficult for the user to know whether there are any more options below.
https://sqvpyjxewa.vmaker.com/record/Cc543h75lJdXjR2V
Tooltip is an oxymoron.

Steps To Reproduce

Open the Entity Explorer.

Public Sample App
No response
Issue video log
No response
Version
Cloud

The new IDE fixes most of this


[FLOC-4490] Run Rackspace acceptance tests from Ubuntu Xenial

Fixes: https://clusterhq.atlassian.net/browse/FLOC-4490
I think this might fix the problem by virtue of Ubuntu 16.04 having a more modern OpenSSL.
If this doesn't work, I'll try https://libcloud.readthedocs.io/en/latest/other/ssl-certificate-validation.html#changing-used-ssl-tls-version
I've also added  few more GCE Ubuntu 16.04 slaves in:

https://github.com/ClusterHQ/segredos/pull/33

Also helps avoid "slave went offline" errors during acceptance tests for rackspace.
If it proves successful, we can move the other acceptance tests here.

Few comments to be addressed. Otherwise seeing a failed test.
}}}

Traceback (most recent call last):
  File "/tmp/32302/local/lib/python2.7/site-packages/testtools/twistedsupport/_runtest.py", line 386, in _log_user_exception
    raise e
testtools.twistedsupport._spinner.TimeoutError: <flocker.acceptance.endtoend.test_diagnostics.DiagnosticsTests.test_export id=0x7f4afd0abb90> took longer than 300.0 seconds

]
test: flocker.acceptance.endtoend.test_dockerplugin.DockerPluginTests.test_create_container_with_v2_plugin_api
Build timed out (after 90 minutes). Marking the build as failed.
Build was aborted
Archiving artifacts
Archiving artifacts
ERROR: Failed to archive artifacts: run-acceptance-tests.log
java.io.IOException: java.io.IOException: Failed to extract /tmp/workspace/ClusterHQ-flocker/rackspace-libcloud-tls-FLOC-4490/_run_acceptance_on_Rackspace_Ubuntu_Trusty_with_Cinder/transfer of 1 files

not sure if this had to do with jenkins master disk space issues or if its related, but make sure its unrelated.
Otherwise, after the comments and the above test, + slack conversation LGTM

Thanks @wallnerryan
The Rackspace + Ubuntu 14.04 + cinder acceptance tests have been failing on master for a month.

http://ci-live.clusterhq.com:8080/job/ClusterHQ-flocker/job/master/view/on_Rackspace/job/_run_acceptance_on_Rackspace_Ubuntu_Trusty_with_Cinder/245/

Mostly due to "slave went offline" errors and at other times due to similar test timeouts.
I'm hoping that if we can eliminate the "slave went offline" errors by launching these tests from GCE, we'll be able to see clearly why the tests are timing out.
I'll merge this, see how it goes and we can revert back if it causes problems.


Remove sleeps from integrated test

I think it took me longer to assign the review to myself in JIRA than it did to review.


[TW#24959] Android phone unable to obtain IP in APSTA mode from ESP32

When we run ESP32 in the AP+STA mode. We are have facing a problem.
In the AP+STA mode, the ESP correctly connects to access point and also starts as an access point.
When we connect to the ESP access point using iPhone. We are also able to connect to it using Android phone (Pptv king 7 with Android 5.1, Xiaomi Mi 6 with Android 8.0).
However, when we try to connect Android phone (Xiaomi Redmi Note 4 with Android version 7.0), it gets stuck in the "Obtaining IP address" phase and finally ends up with an "Authentication error". On the ESP side, it correctly detects that the phone has connected but fails to allocate IP.
We have tried to restore factory settings on the phone. We have also tried to erase NVS data (and also erase entire flash!) of the ESP32. But the problem persists.
We use Espressif IoT Development Framework: v3.2-dev-362-g1c7a8b3b
We have produced the following logs with an open wifi configuration.
Pptv king 7 log:
13:27:00.762> [0;32mI (73054) tasks: SR:2168 [0m
13:27:07.191> I (79474) wifi: n:1 1, o:1 0, ap:1 1, sta:1 0, prof:1
13:27:07.191> I (79474) wifi: station: 70:0b:c0:a6:08:7f join, AID=1, bgn, 40U
13:27:07.191> D (79484) event: SYSTEM_EVENT_AP_STACONNECTED, mac:70:0b:c0:a6:08:7f, aid:1[0m
13:27:07.191> [0;32mI (79484) init: WiFi hdl: 15[0m
13:27:08.682> [0;32mI (81004) tcpip_adapter: softAP assign IP to station,IP is: <IP_ADDRESS>[0m
13:27:08.682> D (81004) event: SYSTEM_EVENT_AP_STAIPASSIGNED[0m
13:27:08.682> [0;32mI (81004) init: WiFi hdl: 17[0m
13:27:09.182> [0;32mI (81474) azure: OK[0m
13:27:09.182> [0;32mI (81484) azure: SSL server wait for client ......[0m
13:27:10.747> [0;32mI (83054) tasks: SR:2166 [0m
13:27:12.680> [0;32mI (85004) azure: Client connected...[0m

Xiaomi Redmi Note 4 log:
13:18:50.436> I (70883) wifi: n:1 0, o:1 0, ap:1 1, sta:1 0, prof:1
13:18:50.436> I (70883) wifi: station: 50:8f:4c:47:ad:bf join, AID=1, bgn, 20
13:18:50.436> D (70883) event: SYSTEM_EVENT_AP_STACONNECTED, mac:50:8f:4c:47:ad:bf, aid:1[0m
13:18:50.436> [0;32mI (70883) init: WiFi hdl: 15[0m
13:18:51.560> I (72013) wifi: n:1 0, o:1 0, ap:1 1, sta:1 0, prof:1
13:18:51.560> I (72013) wifi: station: 50:8f:4c:47:ad:bf join, AID=1, bgn, 20
13:18:51.560> D (72013) event: SYSTEM_EVENT_AP_STACONNECTED, mac:50:8f:4c:47:ad:bf, aid:1[0m
13:18:51.560> [0;32mI (72013) init: WiFi hdl: 15[0m
13:18:51.622> [0;32mI (72073) tasks: SR:2122 [0m
13:19:01.592> [0;32mI (82073) tasks: SR:2123 [0m
13:19:07.838> I (88333) wifi: n:1 0, o:1 0, ap:1 1, sta:1 0, prof:1
13:19:07.908> I (88333) wifi: station: 50:8f:4c:47:ad:bf join, AID=1, bgn, 20
13:19:07.908> D (88343) event: SYSTEM_EVENT_AP_STACONNECTED, mac:50:8f:4c:47:ad:bf, aid:1[0m
13:19:07.908> [0;32mI (88343) init: WiFi hdl: 15[0m
13:19:07.908> -> 10:19:07 PINGREQ
13:19:07.908>
13:19:07.978> <- 10:19:07 PINGRESP
13:19:07.978>
13:19:11.585> [0;32mI (92073) tasks: SR:2124 [0m
13:19:21.571> [0;32mI (102073) tasks: SR:2123 [0m
13:19:27.932> -> 10:19:27 PINGREQ
13:19:27.932>
13:19:31.617> [0;32mI (112073) tasks: SR:2123 [0m
13:19:32.177> I (112653) wifi: n:1 0, o:1 0, ap:1 1, sta:1 0, prof:1
13:19:32.177> I (112653) wifi: station: 50:8f:4c:47:ad:bf join, AID=1, bgn, 20
13:19:32.177> I (112653) wifi: state: run -> auth (6c0)
13:19:32.177> I (112653) wifi: pm stop, total sleep time: 100026683 us / 110673919 us
13:19:32.177>
13:19:32.177> I (112663) wifi: n:1 0, o:1 0, ap:1 1, sta:1 0, prof:1
13:19:32.244> D (112663) event: SYSTEM_EVENT_AP_STACONNECTED, mac:50:8f:4c:47:ad:bf, aid:1[0m
13:19:32.244> [0;32mI (112673) init: WiFi hdl: 15[0m
13:19:32.244> D (112673) event: SYSTEM_EVENT_STA_DISCONNECTED, ssid:UNIT_city_guest, ssid_len:15, bssid:c8:b5:ad:c8:73:82, reason:6[0m
13:19:32.244> V (112683) event: enter default callback[0m
13:19:32.244> V (112693) tcpip_adapter: check: local, if=0 fn=0x40100c54
13:19:32.244> [0m
13:19:32.244> D (112693) tcpip_adapter: if0 start ip lost tmr: enter[0m
13:19:32.244> D (112703) tcpip_adapter: if0 start ip lost tmr: interval=120[0m
13:19:32.244> V (112703) tcpip_adapter: call api in lwip: ret=0x0, give sem[0m
13:19:32.244> V (112713) tcpip_adapter: check: remote, if=0 fn=0x40100c54
13:19:32.244> [0m
13:19:32.244> V (112723) event: exit default callback[0m
13:19:32.244> [0;32mI (112723) init: WiFi hdl: 5[0m
13:19:32.244> iothub_client_sample_mqtt has gotten quit message, call DoWork 3 more time to complete final sending...

@amuzyche I have reproduced your problem, and I will reply you as soon as I find the root cause.

@zhangyanjiaoesp  Thank you for your prompt reply, how will apply executed changes, will it be hotfix, or sdk update?

It will be sdk update

Dear @zhangyanjiaoesp , i'm reaching out to check the progress with issue solving?
If it's possible can you give us estimate fixing time ?

Dear, @zhangyanjiaoesp , we really hope to solve this problem. What terms can we get a solution? Thank you.

@asimpl3 @amuzyche
you can use the latest IDF to test, the commit ID for this solution is:
commit 020ade652d9b6b0b87b0bebe176a150cc4407749

This again/still doesn't work on current master (577f8d8) or v3.2 branch (47dea73b) - but it indeed does work on commit 020ade6.
For me I can reproduce this with just the trivial softap example code (no mixed sta/ap), with old (android 4.1.2) samsung phone.
Could you please re-check what happened to the fix?
(I can provide logs/wifi sniff if needed)


Using bold and italics together causes formatting issues.

Describe the bug
Using three asterisks together to format a part of the text to use both bold and italics causes formatting and paragraphing errors after the part where three asterisks are used.
Steps to reproduce

Create a new post
Use text with three asterisks before and after it.
Include a heading in the next line (or any other kind of text)

Screenshots or additional context

Fixed in the latest main.


Remove Stripe.js hardcoding from checkout

The template file still has Stripe hardcoded in it. Probably not best to do this & leave it to each payment gateway plugin somehow

Thanks, need to add it to the Stripe plugin I recently decoupled.


Multiple configurable build statuses

Allow multiple configurable build statuses for passing builds in pulldasher.
Problems this solves:
Right now in pulldasher if a build doesn't have a build at all, it will be failed, because there is no "passing".
Along with that, if we have multiple build statuses, pulldasher only looks at the first one.
To solve both of these problems, required builds can be specified per-repo, and a pull will only be passing if it has a successful status for each of these.
Expected behaviour:

Adding a required build to a repo that doesn't have any builds should not be passing
Adding a required build to repo that has a build that is passing and is the required context should pass if it wasn't the same context it should not pass.
Having any one required build not be in the passing builds should cause it not to pass.
If there are extra builds, but not required, they shouldn't affect whether this is passing or not.

Not done, but it still can be reviewed.
Closes: https://github.com/iFixit/pulldasher/issues/93
Closes: https://github.com/iFixit/pulldasher/issues/72

To solve both of these problems, required builds can be specified per-repo, and a pull will only be passing if it has a successful status for each of these.

That's rad!!

dev_block :+1: I'll finish this up next weekend.

un_dev_block :+1: ready!

CR 👍

dev_block :+1: on copperwall's suggestion

un_dev_block :+1:

CR 👍

CR :fire:

Would you like some QA on this? I am not sure how to configure different CI builds so we can have multiple builds on a repo.

@MooreGuy bump
What should QA look like?

dev_block 🔥 on QA tips.

Adding multiple builds on a repo can be done with cimpler, and travis ci together. If you add a cimpler build status and then add a travis build you'll have two. To specify which ones are required for passing, change the config to match this format, https://github.com/iFixit/pulldasher/pull/102/files#diff-02880f48501a3eb52890d5181ba67496R62
Clicking on the build status pull out bar will always go to just one build. This should be ignored, it's not fully decided how to correctly display multiple build statuses.

dev_block 👍  on at least the bug.

un_dev_block :+1: Check that master merge carefully. It was not easy to read through it.

Some of these are difficult to understand:

Adding a required build to a repo that doesn't have any builds should not be passing

I think this is what you mean, "If there is a pull without any builds in a repo with a required build, then that pull should not be passing."

Adding a required build to repo that has a build that is passing and is the required context should pass if it wasn't the same context it should not pass.

I think you mean: "If there is a pull with passing builds, but a new required build is added, then the pull should not be counted as passing until the newly required build and all the other builds on that pull are passing."

Having any one required build not be in the passing builds should cause it not to pass.

Makes sense.

If there are extra builds, but not required, they shouldn't affect whether this is passing or not.

Makes sense.

CR 👍
But dev_block 👍  on a few small things.

Is this ready for CR?

CR 🔥

CR 👙  would love to see this merged

I had a bit of trouble trying to test this out, I'll try again.

CR :trollface:

builds aren't showing up in the UI, dev_block :+1: on that


Replace operation pseudo hash with safe variant

Closes #

Status of this @TrueDoctor?

This is a pretty ugly soulution and probably not worth to rebase


Known commands that break with 1.6.0 client

These functions are known to break when using a 1.6.0 client with a 1.7.0 webservice.
In short, basic launching of tools and workflows should work.
Editing of paths, metadata, etc.
Everything else is a bit of a toss-up, review tests in regression-integration-tests profile for details

FYI, not sure what is happening with the push, but the pr worked


[Serverless] Add Runtime API proxy

What does this PR do?
This PR is the very first version of the RuntimeAPI proxy.
As this is an experimental feature, this is protected by a double mechanism to make sure we won't ship this in production :

a new build tag is set serverlessexperimental
env variable isolation

In this first version, we just output the content to stdout
This can be tested with a wrapper script + AWS_LAMBDA_EXEC_WRAPPER set to this wrapper script.
A full example is available on sa-east-1 sandbox go-test-mdv-dev-maxday-test-ext-proxy
Here is the output for /response

Motivation
Unblock following work with traces/spans
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The appropriate team/.. label has been applied, if known.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

Is the wrapper script also meant to be in this PR?

I was thinking about creating in the datadog-lambda-extension repo


catch permission errors when grabbing process start time

Some processes may not allow accessing the start time. If such a process
is running when Gw2 Launch Buddy is started, it can prevent the
application from starting properly.
Catch errors when trying to grab the process start time and skip that
process if we can't access it.
Signed-off-by: Jacob Keller<EMAIL_ADDRESS>

This isn't technically needed unless you're running Gw2 Launch buddy without an app manifest file, and as the non-Administrator user, but I think it's still a good idea.

Thanks for your contribution to the project! :)


pwsh script to remove test-generated onedrive files/folders

Our purge scripts remove test-generated exchange data, but we aren't cleaning up our OneDrive file creation.  Technically, the golang purge script can remove onedrive folders.  But those only get so far as the deletion-recovery folder, and graphapi is unable to remove the file from there, requiring manual intervention from the devs for full cleanup.
Acceptance Criteria

Write a pwsh script for deleting test-generated onedrive folders and files.
Add this script to the purge-m365-user-data action.
Make sure the files get removed from any retention/recovery folders as well.

This is actually done


Messaging metrics: extending general messaging metrics for individual systems

Follow up on https://github.com/open-telemetry/semantic-conventions/pull/163#issuecomment-1803669725
It makes sense for individual messaging systems to add system-specific attributes:

Kafka consumers would want to report partition id
RabbitMQ would report routing key
Azure messaging systems also have partition or subscription that are important for metrics.

We should prototype/document custom metrics for 1+ messaging systems and document how extension can be done.

We should implement a solution according to the conclusions from https://github.com/open-telemetry/semantic-conventions/issues/760.