Investigate making the focus indicator an actual border

It'd be nice to not have Windows Terminals windows become bright red when focused, and maintain the acrylic styling.

For what it's worth, I have this set up on Win 11 using the native windows configuration:

Set Settings > Personalization > Colors > Accent color to desired active-window border color, and activate "Show accent color on title bars and window borders"
In the registry, copy the Computer\HKEY_CURRENT_USER\Software\Microsoft\Windows\DWM\AccentColor key to create a new AccentColorInactive key, and set its value to the desired inactive-window border color.

AFAIK, it's not possible to change the border width using this approach, based on my testing, they are always set to 2px. But imo it looks good anyhow:


Implements simplification and deprecation of which_sbt selection logic in libci

Resolves #22
Obsoletes #20

Coverage decreased (-0.5%) to 72.666% when pulling e92f5456be8f52a8cab6c872811d5861c5883c38 on lynnju:upstream-issue/CommBank/22 into 6e8bf194a7aeebb0a861ad84bd656c467c86cdf0 on CommBank:master.

Coverage decreased (-0.5%) to 72.666% when pulling 5f4c19994ee45c3a1e80e59c9fb766cca885ebe9 on lynnju:upstream-issue/CommBank/22 into 6e8bf194a7aeebb0a861ad84bd656c467c86cdf0 on CommBank:master.

Coverage decreased (-0.6%) to 72.604% when pulling c80c20cc6e86c8da357bbcd2fdbdba6bc713e416 on lynnju:upstream-issue/CommBank/22 into 6e8bf194a7aeebb0a861ad84bd656c467c86cdf0 on CommBank:master.

Looks good @lynnju 🚀


fix: Memoize achievement inferencer

Description

Uses a per-component instance singleton and memoizes it, as we only need to keep track of the initial states of the control panel.
Also added a TODO comment for future refactoring to more modern React principles using component state and hooks.
Closes #3060.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

Checklist

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 31.454%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/achievement/control/AchievementControl.tsx
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.001%

Covered Lines:
4855

Relevant Lines:
14551

💛  - Coveralls


Remove AvroName and AvroNamespace in favour of native SerialName

Now, to redefine record's name or namespace, just use @SerialName("RecordName") or @SerialName("a.good.namespace.RecordName") (note that record name is now explicit). The goal of kotlinx serialization framework is to be a declarative serialization framework, so if the needs are to have all the records inside a specific namespace and/or all classes with a specific record name, then move all your classes inside this package and name the data classes accordingly.
Out-of-the-box:

namespace: test
record name: Bar

// Before (v1)
package test
object Bar

// After (v2)
package test
object Bar

No change as it is the default behavior

Override namespace:

namespace: foo
record name: Bar

// Before (v1)
@AvroNamespace("foo")
object Bar

// After (v2)
@SerialName("foo.Bar")
object Bar

If you need to redefine the namespace, then you also need to explicit the record's name

Override record's name:

namespace: test
record name: foo

// Before (v1)
package test
@AvroName("foo")
object Bar

// After (v2):
package test
@SerialName("test.foo")
object Bar

If you need to redefine the name, then you also need to explicit the namespace, or it will become empty

Remove namespace or redefine name-only record

no namespace
record name: foo

// Before (v1)
package test
@AvroNamespace("")
@AvroName("foo")
object Bar

// After (v2):
package test
@SerialName("foo")
object Bar

Override record's name for a specific field
Having the parent class Bar in parent.namespace and the field Subtype in custom namespace:
// Before (v1)
package parent.namespace
data class Bar(
  @AvroNamespace("custom") val field: Subtype
)

// After (v2):
package parent.namespace
data class Bar(
  @AvroNamespaceOverride("custom") val field: Subtype
)

Initial problem/proposal
We can mess with priorities because of too much annotations, and avro4k needs caching just to handling those multiple annotations (AvroName, AvroNamespace, SerialName), and also can be ambiguous because of apache's avro java annotations.
Also, the native SerialName is not fully handled because RecordNaming is using the class name, and I don't exactly understand how the AvroName and AvroNamespace is used since there are a lot of little cases (AvroFixed can change the name by example).
This is simplifying a lot the naming codebase, while it also simplifies the api. Maybe we can keep the AvroNamespace to be able to only change the namespace, but since it's the name of the package, just moving classes to the good package seems cleaner and clearer.

@thake what do you think ?

Sorry for getting back to you on this so late. I think we should consolidate the current ways of naming a record. Have you checked if the @SerialName annotation can cover all use cases?

I don't understand, what it could not work with serial name annot? 😁

I actually don't know because I've not checked it yet. That's why I'm asking you if you have checked it ;)
Everything possible according to the avro spec on naming must be possible with whatever we come up with. I just want to be sure before we settle on a future design.

No issue then, let's plan it as a breaking change to just remove the avro name and namespace annotations to centralize everything using native kotlinx annotations

There is still one edge case: overriding record's namespace of a field. I propose to still remove AvroNamespace while adding a new AvroNamespaceOverride that would be only usable on properties. The other advantage is to stop messing with the original AvroNamespace annotation.
I update the issue's description

Done in #182


Add SignatureExpire switch and make parameters mandatory

I fixed issues #289 and also introduced some improvements.  I added  ``SignatureExpire``` parameter because sometimes the default time in 3600 seconds isn't and the copy operation will cancel. I also made some parameters as mandatory because it doesn't have a sense to run the script with some default values.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: akalcik sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for your contribution.


Error in matches predictions

There are 2 errors in the match prediction section:

the data used to make the prediction is not updated, it's the data of the previous match that is reused
the data is passed as a list of values, but the list is not given in the same order as during the training

The match prediction is not usable then.

It seems it's not the data not in the good order, but the preprocessing done in preprocess_dataset which is not performed on the prediction data.

This should happen only during Cross-Validation process and it's perfectly normal. The idea is that we randomly selected a train set and a n evaluation set, to measure the performance of the models.
However, during the training period (ONLY), it should use the first 100 matches as test and the rest of the dataset should be processed in the correct order!
Otherwise, can you print the results of the preprocess_dataset for the evaluation data to verify this?

The problem is not on the evaluation data, but on the prediction data passed to the predict match dialog.
For example, I launch my trained model on Ligue 1 French league, I select Paris SG as home team (the best team in the league) and Clermont as away team (the worst team in the league), and I enter the same odd (3.00) for all possible results, the algorithm gives me probabilities of 0.32 for Paris 0.23 a draw and 0.44 for Clermont, which is totally incoherent, and this is because the data given to the model is not processed before it was passed to the model.

So the program grabs the features from the history tables, but does not preprocess them beforing passing them to model for prediction?

Exactly !
But the program also does not update the statistics with the data of the previous match !

Thanks. I will take a look into it.

Yeah, I think that would be the best way. The rows should be processed before returned using the scaler of them model's config (if any)

Any update on this issue - how was it solved in the end? @andony-arrieula did you do a PR or fork with the changes?


[Epic] Make sure the Operator is ready to deploy on OperatorHub

Bundle: https://sdk.operatorframework.io/docs/olm-integration/quickstart-bundle/#creating-a-bundle
Community Operator: https://github.com/k8s-operatorhub

[x] https://github.com/janus-idp/operator/issues/9
[x] Make sure we can deploy and run everything in our own cluster
[ ] ~PR to submit to Community Operators (can take at least 2 weeks to get reviewed and merged)~ (not the priority right now)

Closing this issue as done..
As we discussed already, for now, the priority is to have the Operator available on the downstream catalog, which should be already possible (thanks to RHIDP-488). So the Operator is ready to deploy on OperatorHub at this point.
We'll see later if we need to publish to the community Operator Hub. But this will be addressed as a separate issue.


Cannot match newlines in a custom syntax highlighter

Does this issue occur when all extensions are disabled?: This is a thing with extensions, so they need to be enabled.

VS Code Version: 1.59.1 Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfa Date: 2021-08-19T11:53:52.479Z (1 mo ago)
OS Version: macOS 11.5.2 BigSur

Steps to Reproduce:

Create an extension for custom syntax highlighting
Match any regex containing newlines.
Newlines not matched.

/duplicate of #133838


Use bufio.Reader in io.Copy source for overlay.copyRegular

It allows avoiding allocation of 32K buffer each time because of WriteTo method.
ping @unclejack

LGTM

@cpuguy83 PTAL

Nice, LGTM


Make the instruction of clicking the bars more obvious

What is the GDP growth correlation percentage between the U.S. and China?

Added font styles to make the "click" instructions more obvious.


[8.x] Add new feature validated function in Request

Illuminate\Http\Request has been improved and validated() has been added to it and safe() has also been added and I have also modified Illuminate\Foundation\Http\FormRequest so that it does not have duplicate lines
Before :
<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;

class TestController extends Controller
{
    public function __invoke(Request $request)
    {
        $validated = $request->validate([
            'name' => ['required'],
            'phone' => ['required'],
        ]);
    }
}

Now :
<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;

class TestController extends Controller
{
    public function __invoke(Request $request)
    {
        $request->validate([
            'name' => ['required'],
            'phone' => ['required'],
        ]);

        // Retrieve the validated input data...
        $validated = $request->validated();

        // Retrieve a portion of the validated input data...
        $validated = $request->safe()->only(['name', 'phone']);
        $validated = $request->safe()->except(['name', 'phone']);
    }
}

I just want to organize the code more

I hope to be a contributor I have a lot of ideas but I can't implement them alone

The validate method returns the validated fields.
$validated = $request->validate([
    'name' => ['required'],
    'phone' => ['required'],
]);

The validate method returns the validated fields.

$validated = $request->validate([

    'name' => ['required'],

    'phone' => ['required'],

]);

It's a new feature that I just added and basically it's like a shortcut

Hi @taylorotwell
It's not a problem solution or a bug correction
It's just new features that can be added to the framework and some code shortcuts

Can the withdrawal request be reopened ?

@taylorotwell Can the withdrawal request be reopened?


Add The experiment (english vocaloid) by CalypSonata

Song Name
The experiment (english vocaloid)
Artist Name
CalypSonata
Source
Youtube
Youtube Link
jzoEUIUIew8
Direct File Link
No response
Song ID
690156
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 71514967
Downloaded: No

Accept
On Fri, Nov 1, 2024, 10:32 PM auto-nong[bot] @.***>
wrote:

Thanks for contributing!
Someone will soon review your request.
Here is the JSON result for the reviewer:
{
"name": "The experiment (english vocaloid)",
"artist": "CalypSonata",
"source": "youtube",
"startOffset": 0,
"yt-id": "jzoEUIUIew8",
"songs": [
690156
]
}
To accept the request, a reviewer needs to write "accept".
—
Reply to this email directly, view it on GitHub
https://github.com/FlafyDev/auto-nong-indexes/issues/5742#issuecomment-2452809141,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJ3S62YPO3W4KYFPAJJYFBDZ6Q2SNAVCNFSM6AAAAABRBIZEE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSHAYDSMJUGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


fixed: fix white space on mobile view and z axis of theme switcher #146

Thanks for your contribution! :)


ros2_planning_system: 2.0.12-1 in 'jazzy/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros2_planning_system to 2.0.12-1:

upstream repository: https://github.com/PlanSys2/ros2_planning_system.git
release repository: https://github.com/ros2-gbp/ros2_planning_system-release.git
distro file: jazzy/distribution.yaml
bloom version: 0.12.0
previous version for package: null

plansys2_bringup
* Add parameter for timeout of plan solver
* Added support for configuring the planner timeout
* Remove cmake warning
* Restore tests and enable warnings
* Use separate problem pddl for problem expert.
* Simplifying bound checkin logic.
* Change double quotes for simple ones (linter)
* Make explicit which BTCreator is being used
* bt-builder-plugins: Setting default BT builder plugin to SimpleBTBuilder.
* bt-builder-plugins: Creating BT builder plugin interface. Moving current BT builder to plugin named SimpleBTBuilder. Adding new and improved STN-based BT builder plugin named STNBTBuilder.
* revert if statement
* Contributors: Francisco Martín Rico, Josh Zapf, Marco Roveri, Splinter1984

plansys2_bt_actions
* Remove cmake warning
* Removed some small references still related to the old version of BehaviorTree
* Bump Behaviortree.CPP v3 to v4
* fix code style issues with uncrustify
* Update BTAction.cpp
* fix groot enabling
* Linting
* Fix logger destruction at BTActions
* Update Changelog
* Insert in blackboard the action ROS 2 Node
* Insert in blackboard the action ROS 2 Node
* Correct tick function call in bt_actions test
* Merge remote-tracking branch 'origin/master' into fix_goal_structure_issue_205
* Explicitly ignore feedback in default on_feedback
* Add try/catch to bt creation, reset loggers
* Contributors: Andrianov Roman, Francisco Martín Rico, Jake Keller, Marco Roveri, Splinter1984

plansys2_core
* Integrated feedback, and fixes to have tests to pass
* Added support for configuring the planner timeout
* Remove cmake warning
* Add option to use planner node to validate domain in domain expert
* Remove reference to SharedPtr
* Contributors: Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Robodrome, Sebastian Castro, Splinter1984

plansys2_domain_expert
* include "object" in getType
* fix code style
* add params to getDerivedPredicate
* add tests for getDerivedPredicate(s)
* add getDerivedPredicate
* add getDerivedPredicates
* add DomainReader::get_derived_predicates
* Small optimization
* Fixed expected output
* Remove cmake warning
* Fixed dump of functions/constants/types to handle the case where no funcions/constants/types declared to avoid printing the entry, thus generating a valid PDDL file
* Remove commented-out line in domain expert node
* Switch to MultiThreadedExecutor
* Spin up temporary node for domain validation
* Add option to use planner node to validate domain in domain expert
* Reduce copypasta in domain expert
* Configure POPF solver in domain expert
* Merge remote-tracking branch 'upstream/master' into return-stn
* Merge remote-tracking branch 'origin/humble-devel'
* Reverting changes to checking for valid domain.
* Supporting time-triggered execution.
* Contributors: Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Robodrome, Sebastian Castro, Splinter1984

plansys2_executor
* add ActionVariant
* execute regular actions
* Remove cmake warning
* Fix ccplinti and uncrustify
* fail execute_plan action if initial conditions changed
  We terminate the program is many senarios instead of just returning an
  explict value. We used to terminate if the initial conditions changed
  before the plan is started. Now just send a result that the action
  server failed to execute the plan
* Send Cancelation response to ActionClient
* ExecutorNode, remove unused ros node
* Removed some small references still related to the old version of BehaviorTree
* Bump Behaviortree.CPP v3 to v4 - fix executor test
* Fix Timeout BT Node
* Adding imports to stn builder
* Fixing line-length
* Adding duration to dotgraphs.
* Restore tests and enable warnings
* Revert STN changes in Executor BT
* Removing unused or commented out code.
* Updating ComputeBT.cpp.
* Fix Terminal and executor bugs
* Fixing bug in propagation step.
* Adding dependency on eigen3_cmake_module to plansys2_executor.
* Fixing min time bounds in STN to adhere to plan times.
* Adding some print statements to help with debugging.
* Saving progress.
* Removing unused code. Debuggin get_threat function.
* Simplifying bound checkin logic.
* Update and propagate time constraints after applying effects.
* Adding action graph to blackboard.
* Moving STNBTBuilder node and graph structures to parent class.
* Ensure that every start node has direct link to end node in BT.
* Change MultiThreaded for SingleThreaded in CI failing tests
* Change double quotes for simple ones (linter)
* Insert in blackboard the action ROS 2 Node
* Adding Eigen3 dependency to plansys2_executor.
* Removing redundant get_current_time function.
* Fixing RCLCPP_ERROR message bug.
* Fixing colcon build warning.
* Fixing colcon build warnings.
* Cleaning up code for merge request.
* Cleaning up changes.
* Match example is now working!
* Modified BT by hand to get plan to succeed.
* BT not finishing.
* Fixing bug with updating STN time bounds.
* Adding time propagation step.
* Don't check time limits on start-end connections.
* Supporting time-triggered execution.
* Checking for self-referencing edges in STNBTBuilder. Adding standalone compute_bt service.
* bt-builder-plugins: Setting default BT builder plugin to SimpleBTBuilder.
* bt-builder-plugins: Creating BT builder plugin interface. Moving current BT builder to plugin named SimpleBTBuilder. Adding new and improved STN-based BT builder plugin named STNBTBuilder.
* Check at end reqs in bt builder
* Change MultiThreaded for SingleThreaded in CI failing tests
* Insert in blackboard the action ROS 2 Node
* Checking for self-referencing edges in STNBTBuilder. Adding standalone compute_bt service.
* bt-builder-plugins: Setting default BT builder plugin to SimpleBTBuilder.
* bt-builder-plugins: Creating BT builder plugin interface. Moving current BT builder to plugin named SimpleBTBuilder. Adding new and improved STN-based BT builder plugin named STNBTBuilder.
* Contributors: Alexander Xydes, Andrianov Roman, Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Mostafa Gomaa, Samuele Sandrini, Splinter1984, robodrome

plansys2_lifecycle_manager
* lifecycle_manager: activate planner first
* Remove cmake warning
* Contributors: Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Splinter1984

plansys2_msgs
* add uint8 EXISTS = 10 to Node.msg
* support for ParamExpression and ConstExpression
* add Derived.msg and GetDomainDerivedPredicateDetails.srv
* Add option to use planner node to validate domain in domain expert
* Contributors: Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Robodrome, Sebastian Castro

plansys2_pddl_parser
* fix Exists print
* add fromStringExists
* adjust toStringExists
* fix Exists parse
* add test for Exists::getTree
* adjust prints and utils
* adjust Ground getTree
* add exists getTree
* fix exists parse
* add :existential-preconditions requirement
* fix bug in ParamExpression getTree
* fix ParamExpression PDDLPrint
* support for ParamExpression and ConstExpression
* adjust toString for negated comp expression
* support negation of CompositeExpression
* include "object" in getType
* Fixed errors that prevented all the tests to pass
* Remove cmake warning
* Fixed the regexps in getNodeType function
* Added proper support for constants in the goal
* Slightly changed order of printing
* pddl_parser. Fix support for disjunctive-preconditions
* Add forall and imply to PDDL parsing test
* Remove commented out debug stuff
* Add Imply to PDDL domain parsing
* fix regex for 'and' and 'or'
* fix regex for NOT
* Removed debug code
* Fixed support for complex goals and other changes
* Fixed some errors and some tests to comply with the revised output
* Merge remote-tracking branch 'origin/master' into fix_goal_structure_issue_205
* Fixed support for the complex goal parsing both from the terminal and from file
* Contributors: Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Mostafa Gomaa, Paul Gesel, Sebastian Castro, Splinter1984

plansys2_planner
* Integrated feedback, and fixes to have tests to pass
* Added support for configuring the planner timeout
* Spin up temporary node for domain validation
* Add option to use planner node to validate domain in domain expert
* Minor changes to the tests to comply with some change in the generated output
* Contributors: Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Robodrome, Sebastian Castro, Splinter1984

plansys2_popf_plan_solver
* adjust prints and utils
* Integrated feedback, and fixes to have tests to pass
* Added support for configuring the planner timeout
* Add unit tests
* Do not segfault with filesystem errors in POPF, and allow ~ for home directory
* Add option to use planner node to validate domain in domain expert
* Configure POPF solver in domain expert
* Add ability to specify output folder in POPF planner
* Remove reference to SharedPtr
* Fix is_valid_domain by parsing out file
* bt-builder-plugins: Creating BT builder plugin interface. Moving current BT builder to plugin named SimpleBTBuilder. Adding new and improved STN-based BT builder plugin named STNBTBuilder.
* Fix problem in is_valid_domain function
* add status check into popf_plan_solver
* add system status check
* Remove reference to SharedPtr
* Contributors: Andrianov Roman, Francisco Martín Rico, Gustavo, Jake Keller, Josh Zapf, Marco Roveri, Robodrome, Sebastian Castro, Splinter1984

plansys2_problem_expert
* evaluate exists use_state==false
* evaluate exsits w/ problem_client
* add replace_children_param
* return derived predicates in getPredicates
* add cart_produdct and replace_children_param
* fix bug in ParamExpression getTree
* support for ParamExpression and ConstExpression
* add test for negated comp expression
* negate evaluation of comp expression
* add test problem_expert.exist_precidate
* in existPredicate check if derived predicate is satisfied
* Fixed support for constants in predicates/functions/goals
* Make problemExpert case-insensitive to Instance types
* Use separate problem pddl for problem expert.
* Minor changes to the tests to comply with some change in the generated output
* Fixed some errors and some tests to comply with the revised output
* Fixed support for the complex goal parsing both from the terminal and from file
* Minor changes to the tests to comply with some change in the generated output
* Check instance types and associated tests
* Fixed support for the complex goal parsing both from the terminal and from file
* Contributors: Ashton Larkin, Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Mostafa Gomaa, Splinter1984, adfea625

plansys2_support_py
* Support action performers in Python
* Contributors: Francisco Martín Rico, Marco Roveri

plansys2_terminal
* add get model derived predicates to terminal
* Added some information in the README to allow for using a configuration file to change the planner timeout
* Read multiple lines in terminal input
* Fix Terminal and executor bugs
* Change MultiThreaded for SingleThreaded in CI failing tests
* Fix terminal tests
* Contributors: Andrianov Roman, Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, Splinter1984
* Merge remote-tracking branch 'origin/humble-devel'
* Merge pull request #251 <https://github.com/PlanSys2/ros2_planning_system/issues/251> from PlanSys2/fix_bt_node
  Fix bt node
* Change MultiThreaded for SingleThreaded in CI failing tests
* Merge pull request #238 <https://github.com/PlanSys2/ros2_planning_system/issues/238> from roveri-marco/fix_goal_structure_issue_205
  Fix goal structure issue 205
* Fix terminal tests
* Minor fix
* Merge remote-tracking branch 'origin/master' into fix_goal_structure_issue_205
* Merge remote-tracking branch 'upstream/master'
* Merge branch 'IntelligentRoboticsLabs:master' into master
* Contributors: Andrianov Roman, Francisco Martín Rico, Marco Roveri, Splinter1984

plansys2_tests
* Bump Behaviortree.CPP v3 to v4
* Contributors: Francisco Martín Rico, Gustavo, Josh Zapf, Marco Roveri, robodrome

plansys2_tools

No changes

Investigating a critical bug. I will reopen if nothing found.


Add external directory for Conan recipe's exports

High Level Overview of Change
Adds a the external directory to the Conan exports required for generating the libxrpl Conan package.

Context of Change

Without exporting the contents of external/, package generation errors out with:
CMake Error at CMakeLists.txt:73 (add_subdirectory):
  add_subdirectory given source "external/secp256k1" which is not an existing
  directory.
CMake Error at CMakeLists.txt:74 (add_library):
  add_library cannot create ALIAS target "secp256k1::secp256k1" because
  target "secp256k1" does not already exist.
CMake Error at CMakeLists.txt:75 (add_subdirectory):
  add_subdirectory given source "external/ed25519-donna" which is not an
  existing directory.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

API Impact

[ ] Public API: New feature (new methods and/or new fields)
[ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
[x] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
[ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.9%. Comparing base (02ec8b7) to head (6f4478f).

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5006   +/-   ##
=======================================
  Coverage     70.9%   70.9%
=======================================
  Files          796     796
  Lines        66792   66792
  Branches     10998   10997    -1
=======================================
+ Hits         47378   47379    +1
+ Misses       19414   19413    -1

see 2 files with indirect coverage changes

There will be yet more new exports after the physical redesign is complete, but this reminds me that I need to add them to the final PR (#4997).


Shouldn't have to rewrite param default value in order to add more attributes

If you create a param with a default value:
param myparam string = 'my default'

and then later you need to add min/max, you shouldn't have to rewrite the default portion in order to do it:
param storageAccountName string {
  default: 'my default'
  minLength: 3
  maxLength: 24
}

Why not just allow this?
param storageAccountName string = 'my default' {
  minLength: 3
  maxLength: 24
}

We are likely going to switch parameter modifiers to a decorator syntax at which point you should be able to do this. Take a look at #64

The new decorator syntax has been merged, so you can try the nightly, but it has not yet been released. The new syntax is:
@minLength(3)
@maxLength(24)
param storageAccountName string = 'my default'


Heather reported issue: EasyCLA - Not all Signed ICLAs are showing in table

In the EasyCLA overview section, the table does not list all ICLAs signed for the project.
Example: OpenVDB
The PCC table shows 7 ICLA signatures.
The project console v1 shows 20 ICLA signatures
Verified in the database there are 20 signatures for the project where signature_reference_type = user, signature_signed = true, and signature_user_ccla_company_id is empty.
Tejas investigated it: I Verified the PROD API https://api-gw.platform.linuxfoundation.org/cla-service/v4/api-docs#operation/listClaGroupIclaSignature with CLA group ID "8034cd49-0799-4fc6-9f4f-27b8a75cfdb1" its returning 7 records from Backend. So this seems to be a backend issue.
Note: Original ticket created by Heather was https://jira.linuxfoundation.org/browse/LFX-3120 however as Tejas investigated it and found that its a backend issue so created this ticket.

Investigating - for this CLA Group - we should return a total of 20 ICLA signatures that have been signed/approved:

Updated logic to apply the correct ICLA signature query.  Augmented the results with missing data.  A number of records excluded the github username and/or the user's name/emails address.  These values are now fetched and added to the response when available.
{
    "list": [
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-10-02T09:18:01.735025+0000",
            "signature_id": "784bebee-29bc-4de6-86af-40b737148a83",
            "signed_on": "2020-10-02T09:35:32Z",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Antoine <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-02-21T19:13:07.060843+0000",
            "signature_id": "1ed2404d-2a3f-4697-b382-1da3daa9d373",
            "signed_on": "2020-02-21T19:13:07.060836+0000",
            "user_email"<EMAIL_ADDRESS>        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-10-30T18:58:01.985357+0000",
            "signature_id": "b625f576-e6a0-4bb6-82ac-f3ba9fb90fba",
            "signed_on": "2020-10-30T18:59:14Z",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Jamie <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-05-25T06:48:33.790079+0000",
            "signature_id": "ddd68752-20c1-45f6-84bd-5d960698a755",
            "signed_on": "2020-05-25T06:48:33.790072+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "<redacted> <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-03-27T19:16:09.201005+0000",
            "signature_id": "19cd032f-2229-40a5-9212-9d5cd4c45662",
            "signed_on": "2020-03-27T19:16:09.200997+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Michael <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-03-18T09:39:24.419998+0000",
            "signature_id": "34d612af-4dcf-4240-83ff-54bdf8641435",
            "signed_on": "2020-03-18T09:39:24.419990+0000",
            "user_email"<EMAIL_ADDRESS>        },
        {
            "github_username": "<redacted>-me",
            "signatureModified": "2019-11-04T03:21:23.444623+0000",
            "signature_id": "8f299af2-da97-4fbd-afb7-278a2f3be929",
            "signed_on": "2019-11-04T03:21:23.444616+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "<redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2019-10-14T21:37:10.364655+0000",
            "signature_id": "413a813d-5203-4dfa-867c-d00d0c49e20d",
            "signed_on": "2019-10-14T21:37:10.364647+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Ken <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-02-26T20:42:32.547898+0000",
            "signature_id": "ccb88dbb-9ac4-45ab-8682-80e422398f48",
            "signed_on": "2020-02-26T20:42:32.547890+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Ben <redacted>"
        },
        {
            "github_username": "tom-<redacted>",
            "signatureModified": "2020-10-13T11:04:29.905204+0000",
            "signature_id": "6e56259d-e462-4c92-bb59-631e2de60fed",
            "signed_on": "2020-10-13T11:05:53Z",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Tom <redacted>"
        },
        {
            "github_username": "<redacted>-hu",
            "signatureModified": "2020-03-11T21:35:46.870716+0000",
            "signature_id": "35ecf07d-553e-4b6e-98a4-1afc00d35098",
            "signed_on": "2020-03-11T21:35:46.870708+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "<redacted> Hu"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-03-28T01:07:21.341099+0000",
            "signature_id": "96a0045e-dc65-4bbe-8427-d908f4c9deff",
            "signed_on": "2020-03-28T01:07:21.341091+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "<redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-05-13T18:19:23.189305+0000",
            "signature_id": "ae4f9629-6385-4314-82b8-b78984cc1b5c",
            "signed_on": "2020-05-13T18:19:23.189298+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Mark <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-10-19T21:03:49.500755+0000",
            "signature_id": "bc799dac-fc31-427d-80df-726e1a13c1ba",
            "signed_on": "2020-10-19T21:05:32Z",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Stephan <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-09-16T09:31:02.111647+0000",
            "signature_id": "577423d4-a310-46c8-a4a9-534227df4211",
            "signed_on": "2020-09-16T09:32:48Z",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Mehmet <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2019-10-11T13:02:06.411435+0000",
            "signature_id": "3a6a8f7d-e11d-4a4d-934e-d70d5db8de4f",
            "signed_on": "2019-10-11T13:02:06.411427+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Nick <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2019-11-21T10:24:33.271268+0000",
            "signature_id": "5ad2cf09-75dc-4ec9-a538-2fb67170c97f",
            "signed_on": "2019-11-21T10:24:33.271260+0000",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Morten <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-08-17T10:09:37.992175+0000",
            "signature_id": "9dd82265-eab2-43a3-af48-30b2d504e2c5",
            "signed_on": "2020-08-17T10:15:13Z",
            "user_email"<EMAIL_ADDRESS>        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-12-22T16:53:06.756479+0000",
            "signature_id": "5746a577-3894-4e22-9a0d-07a7e310a92a",
            "signed_on": "2020-12-22T16:53:07Z",
            "user_email"<EMAIL_ADDRESS>            "user_name": "Rich <redacted>"
        },
        {
            "github_username": "<redacted>",
            "signatureModified": "2020-02-26T19:45:02.405629+0000",
            "signature_id": "d386c9f5-7f2f-415e-8d1c-e5a6c215e321",
            "signed_on": "2020-02-26T19:45:02.405622+0000",
            "user_email"<EMAIL_ADDRESS>        }
    ]
}

Query for large projects, e.g.
  Cloud Native Computing Foundation (CNCF) - d8cead54-92b7-48c5-a2c8-b1e295e8f7f1
    Live Project              : True
    SalesForce Projects       :
      ID                      : a0941000002wBz4AAE
        Name                  : Cloud Native Computing Foundation (CNCF)
        Parent ID             : None
        Parent Name           : None
        Enabled Services      : ['CLA']
    Repositories              : 67
    Individual Signatures     : 9,620
    Employee Acknowledgements : 3,408
    Company Signatures        : 606
    CLA Managers              : 831

there are nearly 10K ICLAs. As a result the query takes around 35 seconds to fetch.  May consider updating the signature records offline with a migration script to add the missing data.

This is deployed to all environments through https://github.com/communitybridge/easycla/releases/tag/v1.0.137

I verified it on Staging - looks fine.
I tested it for Project PerfTestFoundation & CLA Group PerfTest-ClaGroup1 for which bulk ICLAs were created.
I called API https://api-gw.staging.platform.linuxfoundation.org/cla-service/v4/cla-group/a87b899f-8c82-4f26-8acf-eaa772d048f4/icla/signatures & it returned 1216 entries. I verified it on UI & I can see 1217 entries.

Each page has 5 entries; page 244 has only 1 entry so total entries: 1216

@WillsonHG  please verify on PROD.

verilfied openvdb is correct on prod.


Social links added

Added social icons and links to the footer.
Reverted the changes done earlier.
Please review the changes and merge into main.

Can u please also add the hactoberfest-accepted tag to this pe.
Thanks!


Add local config to use Spring Boot devtools

following https://github.com/jhipster/jhipster-lite/pull/8637

@pascalgrimaud : do you really think this is necessary?
From my understanding devtools is automatically disabled by default on production application, according to Spring documentation:

Developer tools are automatically disabled when running a fully packaged application. If your application is launched from java -jar or if it is started from a special classloader, then it is considered a “production application”

Just tried it and you're right @murdos thanks.
By default, if we don't put these properties:

it's disabled by default on production application
it enabled by default when running app using Main class or with Maven, and it restarted automatically when building

No need this PR any more, I'm closing it


Badge Icons

The badge icon files shall be stored in the runtime folder along with the badge definitions

the badge icons can now be stored in a configurable folder


Identify Use Cases for Currency Reference Data

How can the Currency Reference Data solution drive efficiency & cost reduction at a high level?
Use Case # 1 - Regulatory reporting: Currency Reference Data solution may make it easier to get consistent and more explicit mapping between edge case currency codes across the industry (identified at the August 18th CurRef meeting)
Please add further use cases in the comments below.

closing this issue as it has been transferred to the Currency Reference Data project repository https://github.com/finos/curref-data/issues/13


Error of Pretraining User Defined Dataset

Hi：
I want to use TAP to pretrain model on my dataset, and I prepare the dataset following your data format.
But when I try to pretrain the model with distributed setting (use only one GPU is fine), I encounter the following error:
2022-04-15T14:13:50 INFO: m4c_textvqa:, 73100/96000, train/total_loss: 1.6139 (2.9855), train/m4c_textvqa/pretrainonly_m4c_decoding_bce_with_mask: 1.6139 (2.9855), train/m4c_textvqa/maskpred_accuracy: 0.8486 (0.7797), val/total_loss: 4.3474, val/m4c_textvqa/pretrainonly_m4c_decoding_bce_with_mask: 4.3474 (4.3474), val/m4c_textvqa/maskpred_accuracy: 0.7328, max mem: 7456.0, lr: 0.00001, time: 02m 47s 324ms, eta: 10h 43m 43s 839ms 2022-04-15T14:13:50 INFO: Batch Size of one GPU:16 2022-04-15T14:14:40 ERROR: Expected to have finished reduction in the prior iteration before starting a new one. This error indicates that your module has parameters that were not used in producing loss. You can enable unused parameter detection by (1) passing the keyword argument find_unused_parameters=Truetotorch.nn.parallel.DistributedDataParallel; (2) making sure all forwardfunction outputs participate in calculating loss. If you already have done the above two steps, then the distributed data parallel module wasn't able to locate the output tensors in the return value of your module'sforwardfunction. Please include the loss function and the structure of the return value offorward of your module when reporting this issue (e.g. list, dict, iterable). (prepare_for_backward at /pytorch/torch/csrc/distributed/c10d/reducer.cpp:514) frame #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x33 (0x7ff58f8d1193 in /home/pai/envs/vqa/lib/python3.6/site-packages/torch/lib/libc10.so) frame #1: c10d::Reducer::prepare_for_backward(std::vector<at::Tensor, std::allocator<at::Tensor> > const&) + 0x731 (0x7ff5dae6ff81 in /home/pai/envs/vqa/lib/python3.6/site-packages/torch/lib/libtorch_python.so) frame #2: <unknown function> + 0xa0f14a (0x7ff5dae5c14a in /home/pai/envs/vqa/lib/python3.6/site-packages/torch/lib/libtorch_python.so) frame #3: <unknown function> + 0x2961c4 (0x7ff5da6e31c4 in /home/pai/envs/vqa/lib/python3.6/site-packages/torch/lib/libtorch_python.so) frame #4: _PyCFunction_FastCallDict + 0x262 (0x56330c484562 in /home/pai/envs/vqa/bin/python) frame #5: <unknown function> + 0x183135 (0x56330c4b0135 in /home/pai/envs/vqa/bin/python) ...
Training loss drops as expected, but after several iterations (73100 iters in the above case), the above error happened. Which is very strange, since the kind of error should happened before the training starts.
Have you ever encounter the above problem? Or could you help me solve the problem?
Thanks very much.
Kang

Hi @kangzhao2 ,
I have not observed this problem in the TAP repo. However, this seems to be a known issue in distributed data parallel pytorch training. The cause, as indicated by the error message, is that "making sure all forward function outputs participate in calculating loss." But it does not explain why the error happens in the middle of the training. Please free feel to share more information and we could discuss about it. Thank you.

Dear zyang-ur:
It may take a long time to solve the problem. But if you public the total VizWiz dataset, I may be able to bypass this problem.
I can only find a small part of VizWiz dataset in "data/ocr_feat_resx/stvqa_conf/vizwiz" and "data/feat_resx/stvqa/train/vizwiz".
Kang

Thank you for the info.
Unfortunately, we didn't experiment on Vizwiz and do not have the feature ready (the subset you found is from ST-VQA). But does this suggest that the error is related to the dataset (i.e., work on other datasets)? That seems strange.

Could you share the feature extractor of your dataset, so I can extract the
feature of vizwiz by myself
Kang
Zhengyuan Yang @.***> 于2022年4月30日周六 02:20写道：

Thank you for the info.
Unfortunately, we didn't experiment on Vizwiz and do not have the feature
ready (the subset you found is from ST-VQA). But does this suggest that the
error is related to the dataset (i.e., work on other datasets)? That seems
strange.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/TAP/issues/19#issuecomment-1113595228, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AP7C5ATKS7RXBJT5VFK3JT3VHQR5LANCNFSM5TSKAVZA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi Kang,
For the BUTD feature, we extract it with the tool provided by M4C here https://github.com/facebookresearch/mmf/tree/main/projects/m4c/scripts, which is based on Detectron.
For the VinVL feature, we use the VinVL repo https://github.com/microsoft/Oscar. Quote: "04/13/2021: Our Scene Graph Benchmark Repo has been released. Welcome to use the code there to extract image features with VinVL pretrained models."
Thank you.


fix(deps): update all non-major

This PR contains the following updates:

Package
Type
Update
Change

axum
dependencies
patch
0.7.2 -> 0.7.3

serde (source)
dependencies
patch
1.0.193 -> 1.0.195

serde_json
dependencies
patch
1.0.108 -> 1.0.111

thiserror
dependencies
patch
1.0.51 -> 1.0.56

Release Notes

tokio-rs/axum (axum)
v0.7.3: axum - v0.7.3
Compare Source

added: Body implements From<()> now (#2411)
change: Update version of multer used internally for multipart (#2433)
change: Update tokio-tungstenite to 0.21 (#2435)
added: Enable tracing feature by default (#2460)
added: Support graceful shutdown on serve (#2398)
added: RouterIntoService implements Clone (#2456)

serde-rs/serde (serde)
v1.0.195
Compare Source

Prevent remote definitions of tuple struct or tuple variant from triggering dead_code warning (#2671)

v1.0.194
Compare Source

Update proc-macro2 to fix caching issue when using a rustc-wrapper such as sccache

serde-rs/json (serde_json)
v1.0.111
Compare Source

Improve floating point parsing performance on loongarch64 (#1100, thanks @heiher)

v1.0.110
Compare Source

Update proc-macro2 to fix caching issue when using a rustc-wrapper such as sccache

v1.0.109
Compare Source

Documentation improvements

dtolnay/thiserror (thiserror)
v1.0.56
Compare Source

Update proc-macro2 to fix caching issue when using a rustc-wrapper such as sccache

v1.0.55
Compare Source

Work around improperly cached build script result by sccache – second attempt (#280)

v1.0.54
Compare Source

Work around improperly cached build script result by sccache – first attempt (#279)

v1.0.53
Compare Source

Reduce spurious rebuilds under RustRover IDE when using a nightly toolchain (#270)

v1.0.52
Compare Source

Fix interaction with RUSTC_BOOTSTRAP (#269)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.2.10 :tada:
The release is available on:

GitHub release
v1.2.10

Your semantic-release bot :package::rocket:


Is there any feature like namespace or scoop support plan?

Description
I have a requirement that there are two similar large plates when writing the article. They only have different variable values and a few text differences. I want to reuse this section, but it seems troublesome to encapsulate it (because my text and variables are mixed together, and the text will be calculated with the variables. Part of text would quite different when the calculated value reached some threshold) and it's not necessary (I only have two similar modules), so my idea is to manually modify the variable value and text value after copying and pasting directly. This works very well, but when I write in the follow-up, I will need to use the variables of the first two parts, but due to direct copying and pasting, in the end, only The variables in the second part can be accessed, and all the variables in the first part are overwritten, so is there any feature like namespace or scope? Just like the code below.
#namespace(section1)[
Some Content
#let a = 1
]
#namespace(section2)[
Some Content
#let a = 2
]
// and we can accessible by the following code
#section1.a // 1
#section2.a // 2

Use Case
Just as the above description

A more natural grammar maybe as follows:
#let section1 = [
Content...
#let var = 1
Section1 Value: #var
]
#let section2 = [
Content...
#let var = 2
Section2 Value: #var
]
Sum: #(section1.var + section2.var)

It only needs to implement variable export.

use a function?

I don't know what your exact meaning is, guess you want me to return the needed value by function? That should work for me to solve my current problems. But I still want this feature because I have over 70 variables and I have to pick out what I need (nearly 20 of them). But still thank you for providing a new way I ignored to solve my current problems.
---Original---
From: @.>
Date: Fri, Jan 12, 2024 01:24 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [typst/typst] Is there any feature like namespace or scoopsupport plan? (Issue #3173)
use a function?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

You can define multiple separate files and use import:
// section1.typ
#let var = 1

// section2.typ
#let var = 2

// main.typ
#import "section1.typ"
#import "section2.typ"

Sum: #(section1.var + section2.var)

Import does not include any content within the files. For that, you need to use include. See https://typst.app/docs/reference/scripting/#modules for more information.

I tried that, but I found in the section also used many variables defined before. Once I move this section to a separate file I can't use these variables any more.
谢雪
@.***
---Original---
From: @.>
Date: Fri, Jan 12, 2024 03:14 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [typst/typst] Is there any feature like namespace or scoopsupport plan? (Issue #3173)
You can define multiple separate files and use import:
// section1.typ #let var = 1 // section2.typ #let var = 2 // main.typ #import "section1.typ" #import "section2.typ" Sum: #(section1.var + section2.var)
Import does not include any content within the files. For that, you need to use include. See https://typst.app/docs/reference/scripting/#modules for more information.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Mail Windows

Using ElvUI so not sure if that has any bearing... but when I open my mailbox, the Inbox/Send windows are not movable. When I try and move it it kinda freaks out, goes blank, and then all the text in it disappears. Here are before/after screenshots of trying to drag the inbox...
BEFORE:

AFTER:

Hope that helps!

Hi @webdevdave - Thanks for letting me know. My guess is it is likely related to ElvUI. I will need to investigate further.

This is fixed in Drift v2.1.1.


The gradio-demo.ipynb does not work, also it does not show what is the error.

I tried running the gradio demo in colab. It is not working. Just shows an error message without telling what is causing the error.

I saw that too I am sorry! We are investigating, I think it's a dependency issue.

@Samit33 By default debug is false in notebook so you will not see gradio error logs, try turning it true as shown in this ss. Let us know if you can see some logs for your error after that.

We found the issue, there was a problem with llama-index streaming that caused it to return None.
We provided a quick fix by removing streaming. Colab is working again. Opening an issue to fix streaming.

Hi,
I would be grateful if you could provide a fix also for the local LLM since it is broken as well

@deepbeepmeep I changed the way to extract output which made local models fail.
It should be fixed with the next PR

@deepbeepmeep Fixed. It should work for you now


Update some numbers

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Resizable columns for table

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Problem
Currently remark-gfm doesn't support resizable column for tables, is there any plan to implement this in future?
Solution
A prop that needs to be passed to enable resizable columns in the plugin such that user can drag the column widths, min width and max width can also be passed as a prop.
Alternatives
Not without help of an extra library or code from scratch.

There are many ways.
It doesn’t have anything to do with this project though.
Please ask a question in the designated support channels with much more info.


_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  4s
Maven dependency ordering for patch

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 37s
patch has no errors when running spotless:check.

_ Other Tests _

+0 :ok:
asflicense
0m  1s
ASF License check generated no output?

3m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4473/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4473

Optional Tests
dupname asflicense spotless

uname
Linux 3e6bb58b2be0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cf0ed2e1be

Max. process+thread count
33 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4473/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Add support of Promise on markerCallback

Purpose
This PR offers to support returning a Promise<HtmlMarker> on the markerCallback. This might be useful for applications and libraries having to retrieve data asynchronously to build the HtmlMarker. (cf. this open issue on the Blazor wrapper)
Does this introduce a breaking change?
[ ] Yes
[ X ] No

Pull Request Type
What kind of change does this Pull Request introduce?
[ ] Bugfix
[ X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code
Set your azure maps subscription key
Run the HTML Marker Layer.html example. The example has been updated to return an HtmlMarker in one case or a Promise<HtmlMarker>.

What to Check
Verify that the following are valid

Verify that the sample is running and that the cluster resolution is not affected

@microsoftopensource @rbrundritt Did you have by any time any chance to look at this ?

This looks fine, I changed the ts files as well. I think the js files were generated by the build task. Thanks for the review 😊

ok, great. It's merged then.


[Improvement] Improve interface Configs

What would you like to be improved?
The public interface Configs doesn't include any method but defines a lot of constants.
How should we improve?
Constants shodul be in a class or enum.

Could you please assign this task to me, I would love to work on it.

Hi @justinmclean
PR is ready for review.


refactor(es6) upgrade EvalDevToolModuleTemplatePlugin to ES6 class

What kind of change does this PR introduce?
refactor, ES5 => ES6
Did you add tests for your changes?
All testing tests pass
If relevant, link to documentation update:
N/A
Summary
upgrade EvalDevToolModuleTemplatePlugin to es6
reopen PR #3870
Does this PR introduce a breaking change?
N/A
Other information

thank you So much!!!


Output not rendering

The program installed successfully and appears to function as intended, except no files are being created... I've tried using a different song, outputting to a different folder, and changing the number of stems to no avail.  No error thrown; on the contrary, the result box at the bottom of the window states the splitting completed and saved successfully  :/

Hi! Thanks for reaching out about your issue Kasper.
How long does it take for it to finish splitting? If it says "Split Complete" within a couple of seconds, then the splitting process is most likely failing and the error is not being caught.
Just in case it's a permission issue, could you also try using the youtube downloader to see if that has any issues saving?
Let us know and we'll try to pinpoint what the issue may be.

Closed due to lack of information.


password encrypted with jasypt is breaking when "refreshed" using actuator/bus-refresh

Hi tannaga ,
@tannaga
https://github.com/spring-cloud/spring-cloud-config/issues/808#issuecomment-334249042
@spencergibb @ryanjbaxter @jnulwliang  @sathish593
I am facing similar issue, I followed the procedure mentioned.
spring:
cloud:
config:
server:
encrypt:
enabled: false  (so that configserver will not encript).
Created
org.springframework.cloud.bootstrap.BootstrapConfiguration=com.ulisesbocchio.jasyptspringboot.JasyptSpringBootAutoConfiguration  under META-INF/spring.factories under resource folder , but still I am facing issue, I am reading property from gitlab" the encripted pwd with ENC(xx)" at application.yml , during configServer starup and application startup I am able to see decripted pwd properly, If I change a property in applicatio.yml and hit actuator/bus-refresh  "the  decripted pwd is populating as change ex: o.s.cloud.bus.event.RefreshListener - Received remote refresh request. Keys refreshed [password] " but I did not change anything on this property. Can some one help on this?

If you can provide a sample and a better description of the problem we would be happy to help.
Please learn how to format code on GitHub.

Hi
@ryanjbaxter
Thx for quick reply.
db2:
datasource:
jdbc-url: jdbc:db2://hostname:port/database:currentSchema=default
username:
password: ENC(cppertuvnh)
driverClassName: com.ibm.db2.jcc.DB2Driver
schema: default
spring:
datasource:
type: com.zaxxer.hikari.HikariDataSource
hikari:
connection-timeout: 20000
maximum-pool-size: 20
#minimum-idle: 2
#idle-timeout: 10000
pool-name: HikariConnectionPool
pool-prepared-statements: true
I am maintaining these properties at application-dev1.yml file in Git
When I start config-client, it is able to get properties from git and decript the password: ENC(cppertuvnh) properly.
Issue is:
If I change connection-timeout to 50000 and trigger
https://hostName/dev1/actuator/bus-refresh/CspringAppName
I am getting this message Received remote refresh request. Keys refreshed [connection-timeout, password].Due to this my password is chnaged to  ENC(cppertuvnh) and databased conenctin are failing. Need help on this how to fix it.

@ramkumarar
I'm using jasypt-spring-boot-starter (2.1.0) in a spring cloud config project.When the config loads for the firt time from config server the encrypted values are getting properly decrypted. But when i do a refresh via actuator endpoint the encrypted value is passed as is and not getting decrypted. Iam having following properties in cloud configuration and passing the password via JVM run time argument -Djasypt.encryptor.password=pass
app.enc.attribute = ENC(hKF3c7lizZKAi75e9q9JCQ==)
jasypt.encryptor.bootstrap = true
jasypt.encryptor.algorithm = PBEWITHMD5ANDTRIPLEDES
I see in your post https://github.com/ulisesbocchio/jasypt-spring-boot/issues/112
above issue was resloved, can u please help how did u do that ? Step by step process

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.
Please learn how to format code on GitHub.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

ok


Use visual compass data

how is this meant? dont we just want to integrate the data into the world model? it doesnt seem right to directly use the data in the behaviour

Actually, it would be most useful in the localization in my opinion. But the behavior could use it directly when no localization is available. Which is currently the case.

@Flova, @SammyRamone, @MonsterUntermBett, and others: what do you think about this? should we still integrate this into the behavior or just use it for localization?
Using it twice seems kinda wrong... I think. Depending on the accuracy of the compass.
If we want to use this in the behavior, I'd suggest to use it as our goal direction when there is none and to flip it by 180 degrees (yes, it would just be an approximation) if we see a goal and the compass suggests it is ours. However then this would just be part of the NoLocalizationBehavior I think.

I think it should be included into the localization for the standard case and used directly for no localization behaviour

I think this is an old issue from a time, where the localization was not really ready yet, so plan was to use the no localization behavior, but check if the goal is ours or not via the visual compass. This is indeed not needed anymore if we use the localization.

What? No, it most definitely is needed! as long as we can't be certain that the localization works in every situation, we will need this. The behavior can switch to the NoLocalizationBehavior in every situation the localization is not certain enough.

But I think in this case we should use the most simple no localization backup behavior possible. I think the usage of the visual compass only makes sense in combination with the localization and we should focus our development resources on this and a simple backup, while not maintaining all steps in between.

why shouldn't we include the compass? It can help to reduce the number of own goals. Especially in a situation in which we used localization a situation in which the robot faces the own goa lis more common.

Because the visual compass is also a source of complexity and possible errors, therefore I wouldn't include it in the backup behavior and focus our resources a a better localization, visual compass combination. A proper integration of the visual compass in the localization would handle this whole problem. If e.g. the localization uses "most" of its orientational information from the visual compass (if it currently sees any features above the field), the output state is likely to have the same orientation. Even if the localization "fails" because it got the wrong local maximum for the other inputs, its likely that this state also has the orientation from the visual compass.

I think we have different definitions of backup behavior. The NoLocalizationBehavior is not necessarily meant to work as a backup behavior (however, it is currently used as such). It's just what we do when there is no reliable localization available (meaning in this second, not in this game or competition). However, I do think that when we use not a single value of localization precision as currently proposed in #72 but two values (one for location and one for orientation), we might use these valued to decide whether we use the orientation alone or the full pose.

Okay, so this is closed as the behavior will use visual compass data via the localization even when the position certainty is very bad. #72 will be adapted to the new requirements.


Monkey Madness Missing Item Needed

Looks like there's no indication you will need 5 bananas. Thanks for this amazing plugin tho <3

To clarify there's no indication before you actually need them, it does say you'll need them once you're at that step.

Sorry again lmao. It does tell you that you can get them during the quest. But, the first mention of it (I believe when it tells you to collect the items needed for RFD) doesn't say that it's obtainable during. It just said you needed x5. Sorry for the spam lmao


[5.7] update CommandTaskTracker to match llbuild's reporting of CustomTasks

5.7 cherry pick of #4294

@swift-ci smoke test


Introduce a KeyStoreManager to abstract management of root and non-root key storage

Do not merge, PR for review only.
This structure encapsulates what used to be "rootKeyStore" and
"privKeyStore". These are being moved out of NotaryRepository, so that
operations like listing keys, importing keys, and exporting keys aren't
tied to a NotaryRepository structure.
Initial draft for review. Will add import/export functionality next if
this looks good. Do not merge yet.
Signed-off-by: Aaron Lehmann<EMAIL_ADDRESS>

Supersedes https://github.com/docker/notary/pull/54, which was opened against the wrong branch

@aaronlehmann good direction. Can we go one step further and have caStore and certificateStore also be stored by keystoremanager?
for example, loadkeys() should be called on keystoremanager creation. Keystoremanager should be able to validate an x509 certificate (we should refactor ValidateRoot to keystoremanager), etc.

Sounds good. Working on moving caStore, certificateStore, and ValidateRoot into KeyStoreManager.
One issue I ran into is that ValidateRoot uses the GUN for its validation. I think you said earlier that the KeyStoreManager shouldn't need a GUN to be specified when it's created, because the GUN is a repository concept, not a key management concept. What do you think we should do about this?

Maybe ValidateRoot should take another argument specifying the CommonName to validate, and when NotaryRepo uses it it will pass the GUN for this parameter?

Pushed a commit to move caStore and certificateStore, and refactor ValidateRoot into KeyStoreManager. PTAL.

This looks great.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "keystoremanager" git@github.com:docker/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~9
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Closing this and reopening #54, since this is now ready to merge to master.


Not showing my notification. There is a bug in there

this is a temporary issue related to rebuilding some indexes.


[Enhancement/Feature] -Exports & Duplicates

Enable the export feature and remove duplicates of all endpoints. Would love to see that feature.

I have implemented the features in the latest version 1.1.1. PortSwigger pull request follows.
Have fun!


Add H2 tag to all items and collections migrated to H2

Be sure to retain any Hydrus tags as well.

Amy will be able to add these tags via bulk tagging in Argo.
We can get a list of all druids from H2, since they were either migrated and need the tag or were created in H2 and will already have the tag.

I'm now ready for these two lists:

druids for all the collections now in H2
druids for all the items now in H2

Bulk tagging process used to update all items in these two lists that didn't already have the H2 tag with the H2 tag.


Datepicker 0

📥 Proposed changes
Add initial package and design for datepicker
☑ Submission checklist

[x] I have read the CONTRIBUTING doc
[x] yarn build works locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

💬 Further comments
Notes:

Pushes content down when open, not over other content, don't know if we want that
Uses fafafa as background to hide input field background, its using fff with fff as background in inputfield, however that do not exsist in input yet. Should we add?
dropdown not implemented as API might change a lot with open PR

closes: #46

I'm having some issues writing tests that actually change the date. getBytText() seems to create an eternal loop that crashes the js-runtime.

I think there are some issues with testing web components out of the box with jest/testing library. @Saegrov probably knows more about this, though.


getResponse should return default response if getResponses does not have a matching status code

I am getting the following error from my mock API:
TypeError: Cannot read property 'getExample' of undefined
    at swagger_router (/swagger-node-runner/fittings/swagger_router.js:122:51)

Against a very simple path:
    "/test": {
      "get": {
        "description": "Test",
        "responses": {
          "default": {
            "description": "Test",
            "schema": {
              "type": "array",
              "items": {
                "type": "string"
              }
            }
          }
        }
      }
    },

Looking at the code:
https://github.com/apigee-127/sway/blob/d2f577e2061bf36012477e6d29d0eaae71572700/lib/types/operation.js#L179-L196
My understanding of the usage of this function is that it should return default response if getResponses() does not have a matching status code.
e.g. something like
   var response =  _.find(this.getResponses(), function (responseObject) {
     return responseObject.statusCode === statusCode;
   });

  if (typeof response === 'undefined') {
   response =  _.find(this.getResponses(), function (responseObject) {
     return responseObject.statusCode === 'default';
   });
  }
  return response;

On second thoughts, maybe swagger-node-runner is the best place for me to resolve the issue I'm having:
https://github.com/theganyo/swagger-node-runner/blob/7f85797e74ee8a182ae9458ac8e2eb4db9c7a6c3/fittings/swagger_router.js#L120
Should probably be:
      var response  = operation.getResponse(statusCode) || operation.getResponse('default');
      var mock = response.getExample(mimetype);


row-level ON DELETE / UPDATE CASCADE

Closes #2015, #2185.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7b3549ffe11c0b275e14be8903907501eeb11cad/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2385babfc7b838a98d998fef5a2dc4c1d8ac9bc8/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fa619586f078ca33770c773a7d52c78072075559/

@lhirata, it looks like the minor fixes I made in https://github.com/cockroachdb/docs/pull/2449 didn't make it into this PR. Can you reapply those fixes? It's mostly code-block formatting, but there was one error in an example.

Comments from Reviewable

Done.

Review status: 0 of 6 files reviewed at latest revision, 11 unresolved discussions, some commit checks pending.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dcb79bd16005c551dd8e5df3089a34216b7a2659/

v2.0/foreign-key.md, line 53 at r10 (raw file):
I think it'd be helpful to provide more of an intro here, for example:

When you set a foreign key constraint, you can control what happens to the constrained column when the column its referencing (the foreign key) is deleted or updated.

Comments from Reviewable

@lhirata, unfortunately, although we talked about making updates to all these pages, I'm afraid the overall sense of the feature is getting lost (on me, at least). Now that you've got this first iteration, I think we need to step back and rethink where and how we explain this. Let's set up a meeting.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c122a5cec24ff253a54618a139aef017dbed0789/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9643792fff75ba5fd4639110d91c93138f9e2873/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/529a6a4f4816370aaf293e8fbc95b9a8393e5403/

@BramGruneir & @jseldess, can you take another look? I cleaned up the examples on CREATE TABLE and Foreign Key.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b92a14dde814d85d221a28f12bbf84e953d1a4a4/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f1c54fa482ce71bd4b4fd22b36e1b25cc5e12d31/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ace6695586fe6bcb920bd9eb859d0cd635f79e82/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/07c2454bda0e92bd024f481b9206313c3ac1fb59/

Left some comments.  This is looking really good.

Reviewed 1 of 1 files at r9, 5 of 5 files at r12.
Review status: all files reviewed at latest revision, 18 unresolved discussions, all commit checks successful.

v2.0/drop-column.md, line 25 at r12 (raw file):

| `table_name` | The name of the table with the column you want to drop. |
| `name` | The name of the column you want to drop. |
| `CASCADE` | Drop the column even if objects (such as [views](views.html)) depend on it; drop the dependent objects, as well.

`CASCADE` does not list objects it drops, so should be used cautiously. However, `CASCADE` will not drop dependent indexes; you must use [`DROP INDEX`](drop-index.html).

New in v2.0: `CASCADE` will drop a column with a foreign key constraint if it is the only column in the reference. |

This is not part of my changes.  Not sure if you want to include it in this PR.

v2.0/foreign-key.md, line 134 at r11 (raw file):
Previously, lhirata wrote…
Great!

Is it worth adding in more examples?  I agree that they're great!

v2.0/foreign-key.md, line 53 at r12 (raw file):

### Foreign Key Actions New in v2.0
You can specify an action to take when a referenced column is updated or deleted.

You can set both.  So perhaps 'and/or' is more appropriate than just 'or'.

v2.0/foreign-key.md, line 57 at r12 (raw file):

Parameter | Description
----------|------------
`ON DELETE NO ACTION` / `ON UPDATE NO ACTION` | _Default actions._ If there are any existing references to the key being updated or deleted, the transaction will fail at the end of the statement.

Aliases: `ON DELETE RESTRICT` / `ON UPDATE RESTRICT`

This might need to be split in two.
ON DELETE NO ACTION means that the referenced row can't be deleted, but it could be updated depending on the update action.
ON UPDATE NO ACTION mean that the referenced row can't be updated but it could be deleted depending on the delete action.

v2.0/foreign-key.md, line 60 at r12 (raw file):

`ON DELETE RESTRICT` / `ON UPDATE RESTRICT` | `RESTRICT` and `NO ACTION` are currently equivalent until options for deferring constraint checking are added. To set an existing foreign key action to `RESTRICT`, the foreign key constraint must be dropped and recreated.
`ON DELETE CASCADE` / `ON UPDATE CASCADE` | When a referenced foreign key is deleted or updated, all rows referencing that key are deleted or updated. If there are other alterations to the row, such as a `SET NULL` or `SET DEFAULT`, the delete will take precedence.

Note that `CASCADE` does not list objects it drops or updates, so it should be used cautiously.
`ON DELETE SET NULL` / `ON UPDATE SET NULL` | When a referenced foreign key is deleted or updated, the columns of all rows referencing that key will be set to `NULL`. The column must allow `NULL` or this update will fail.

Maybe add 'respectively' to these?

v2.0/foreign-key.md, line 138 at r12 (raw file):

### Use a Foreign Key Constraint with Default Actions

In this example, we'll create a table with a foreign key constraint with the default [actions](#foreign-key-actions-new-in-v2-0) (`ON UPDATE NO ACTION` / `ON DELETE NO ACTION`).

why the /?

v2.0/foreign-key.md, line 198 at r12 (raw file):

Similarly, the deletion returns an error because `id = 100` is referenced and the default [foreign key action](#foreign-key-actions-new-in-v2-0) is enabled (`ON DELETE NO ACTION`).

Might be nice to also include two other examples that can be updated and deleted because they are not referenced.

v2.0/foreign-key.md, line 201 at r12 (raw file):

### Use a Foreign Key Constraint with `CASCADE`

In this example, we'll create a table with a foreign key constraint with the [foreign key action](#foreign-key-actions-new-in-v2-0) `ON DELETE CASCADE`.

You're adding both on delete and on updated cascade.

Comments from Reviewable

Review status: all files reviewed at latest revision, 18 unresolved discussions, some commit checks failed.

v2.0/drop-column.md, line 25 at r12 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
This is not part of my changes.  Not sure if you want to include it in this PR.

I'm not sure if we have best practices around this. @jseldess, should I put this edit in its own PR?

v2.0/foreign-key.md, line 53 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I think it'd be helpful to provide more of an intro here, for example:

When you set a foreign key constraint, you can control what happens to the constrained column when the column its referencing (the foreign key) is deleted or updated.

Done.

v2.0/foreign-key.md, line 134 at r11 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
Is it worth adding in more examples?  I agree that they're great!

Added to the "default actions" example, like you suggested.  I think that's sufficient!

v2.0/foreign-key.md, line 53 at r12 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
You can set both.  So perhaps 'and/or' is more appropriate than just 'or'.

Done.

v2.0/foreign-key.md, line 57 at r12 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
This might need to be split in two.
ON DELETE NO ACTION means that the referenced row can't be deleted, but it could be updated depending on the update action.
ON UPDATE NO ACTION mean that the referenced row can't be updated but it could be deleted depending on the delete action.

Done.

v2.0/foreign-key.md, line 60 at r12 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
Maybe add 'respectively' to these?

Done.

v2.0/foreign-key.md, line 138 at r12 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
why the /?

Done.

v2.0/foreign-key.md, line 198 at r12 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
Might be nice to also include two other examples that can be updated and deleted because they are not referenced.

Added.

v2.0/foreign-key.md, line 201 at r12 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
You're adding both on delete and on updated cascade.

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0890c3e6bf05b2802f3739e92cd10b9f4f78b27c/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8034441472144c218d9c0f871ba13b32c3c32874/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/867ca8b5f30cc70de7a6ad3c14ac1c360f08c8c4/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/1bf7c16cf6e0853a1b44d0744a97978cd81a7290/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/30b1f131ebbd580fb06bc4a46143315d656aa882/

Review status: 4 of 6 files reviewed at latest revision, 18 unresolved discussions, some commit checks failed.

v2.0/drop-column.md, line 25 at r12 (raw file):
Previously, lhirata wrote…
I'm not sure if we have best practices around this. @jseldess, should I put this edit in its own PR?

Just pulled out this edit. Will open a new PR.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/61b84b0f9f084d5003fed8147810a155cc907364/

Comments from Reviewable

v2.0/foreign-key.md, line 134 at r11 (raw file):
Previously, lhirata wrote…
Added to the "default actions" example, like you suggested.  I think that's sufficient!

I think it might be worthwhile to show how SET NULL and SET DEFAULT work too.

Comments from Reviewable

@BramGruneir - will open a new issue for the SET NULL and SET DEFAULT examples


Steamers Gallery Planned Outage for Maintenance Works

We've got some planned Security Maintenance works for the Steamers Gallery.
This will result in a short outage period, which is yet to be confirmed.
We will update here when we confirm the exact time of this occurring.
Thank You. -MPM

Maintenance now in progress @23:40 - MPM

Maintenance complete @23:51 - MPM


Add files via upload

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Pushing to github
How were these changes tested?
Yes
A reference to a related issue in your repository (if applicable)
I pushed my previous assignment and was getting error
Checklist

[ -] I can confirm that my changes are working as intended

You have unfortunately made a pull request to the wrong repo. You shouldn't be making a pull request to uoft-dsi/python, but rather your own forked shell repo. Please read the instructions on your onboarding Assignment Submission Guide more carefully.


Encoder/Decoder Protocol

Data received or provided to an endpoint is currently decoded/encoded via the decoder property (encoder respectively). These properties are of type JSONDecoder/JSONEncoder. We should introduce protocols which abstract the decode / encode function that are used in the Client class. This what we would be more flexible what kind of object we want to decode/encode. This way it would be possible to work with objects other then JSON (e.g. XML)

I created two branches on my fork to address this issue.
The first branch adds options for the encoding/decoding to the configuration: Click me
The second branch adds the same options to the endpoint: Click me
In personally like the second approach more since we can change the encoding/decoding for each endpoint. In comparison the first approach sets the encoding/decoding for the whole client.
Do you have opinions on which approach we should use? Also feedback to the implementation is appreciated.

Resolved in #60

Resolved in #60


Implement custom SA1515 fix all provider

Fixes all SA1515 violations (14525) in ~3.5s.

Blocked on #1377 (which enables us to do more extensive testing of this).

I rebased this to master and verified that it is no longer crashing.

@sharwell I implemented your feedback


Support for unity types?

Hi,
first: great asset, evaluating it right now for out next project.
A question: currently we are using ScriptableObjects to store game data, this allows us to store for example types like Unity's Color or more importantly Prefab instances that can be Instantiate()d at run-time. Will more types be supported by Charon? If not, what do you recommend tu support this case when working with Charon?

Hi @slimshader! This asset is an adaptation of standalone game data editor for use in Unity. And there is thin connection between Unity and Charon. Only .NET types for use in formulas are taken from Unity's project. Other stuff is on developer's concern.
Charon is designed to store settings for game entities (HP, Mana, Names, Damage etc). Their appearance (prefabs, textures, materials etc) is best stored in Unity native assets.
However, you can import any data in game data file from Unity editor. For example you could import list of available resources:
using GameDevWare.Charon.Utils

const string pathToResources = "Assets/Resources/";
const string pathToGameData = "StreamingAssets/gamedata.gdjs"
const string importedEntityName = "GameAsset"

var assets = (
	from assetPath in AssetDatabase.GetAllAssetPaths()
	where assetPath.StartsWith(pathToResources)
	select new { Path = assetPath, Name = Path.GetFileNameWithoutExtension(assetPath) }
).ToList();
var assetsJson = JsonConvert.WriteString(assets);

var importAsync = CharonCli.ImportAsync(Path.GetFullPath(pathToGameData), new[] { importedEntityName }, CommandInput.JsonString(assetsJson), ImportMode.Replace);
importAsync.ContinueWith(t => { /* do some stuff */ });

This gives you list of existing resources to refer from your game data entities (for example 'Prefab' reference from your 'Character' entity).

Hi @slimshader! This asset is an adaptation of standalone game data editor for use in Unity. And there is thin connection between Unity and Charon. Only .NET types for use in formulas are taken from Unity's project. Other stuff is on developer's concern.
Charon is designed to store settings for game entities (HP, Mana, Names, Damage etc). Their appearance (prefabs, textures, materials etc) is best stored in Unity native assets.
However, you can import any data in game data file from Unity editor. For example you could import list of available resources:
using GameDevWare.Charon.Utils

const string pathToResources = "Assets/Resources/";
const string pathToGameData = "StreamingAssets/gamedata.gdjs"
const string importedEntityName = "GameAsset"

var assets = (
	from assetPath in AssetDatabase.GetAllAssetPaths()
	where assetPath.StartsWith(pathToResources)
	select new { Path = assetPath, Name = Path.GetFileNameWithoutExtension(assetPath) }
).ToList();
var assetsJson = JsonConvert.WriteString(assets);

var importAsync = CharonCli.ImportAsync(Path.GetFullPath(pathToGameData), new[] { importedEntityName }, CommandInput.JsonString(assetsJson), ImportMode.Replace);
importAsync.ContinueWith(t => { /* do some stuff */ });

This gives you list of existing resources to refer from your game data entities (for example 'Prefab' reference from your 'Character' entity).

Thanks. I can't find docs for CharonCli tho, also trying with latest example this code can't find JsonConvert.WriteString()

Thanks. I can't find docs for CharonCli
There is none, actually. But it is just wrapper for Command Line Interface, so you could use CLI docs for reference.

code can't find JsonConvert.WriteString()
It is just Json.NET serializer. You could use any other.

Ah I thought maybe it was Newtonsoft JSON but it didn't have it either

Turns out it is just Newtonsoft.JSON only in uniy package, it does not have WriteString() method.

you are right, it is JsonConvert.SerializeObject();  in Newtonsoft.JSON

Also: DO I understand from code directly that I should manually overwrite my json database with Prefabs lists?

Yes, if you want to refer or catalog some Unity's entities (textures, models, other resources) you need to setup some import routine. You don't need to import manualy every time they change because Unity has 'change hooks' AssetPostprocessor, FileSystemWatcher, IPreprocessBuild, BuildPipeline. Use them to automaticaly import stuff in game data.

Turns out it is just Newtonsoft.JSON only in uniy package, it does not have WriteString() method.

you are right, it is JsonConvert.SerializeObject();  in Newtonsoft.JSON

Also: DO I understand from code directly that I should manually overwrite my json database with Prefabs lists?

Yes, if you want to refer or catalog some Unity's entities (textures, models, other resources) you need to setup some import routine. You don't need to import manualy every time they change because Unity has 'change hooks' AssetPostprocessor, FileSystemWatcher, IPreprocessBuild, BuildPipeline. Use them to automaticaly import stuff in game data.

I've added to the project new file with:
using GameDevWare.Charon.Utils;
using UnityEditor;
using System.Linq;
using Newtonsoft.Json;
using System.IO;
using UnityEngine;

public class NewBehaviourScript : AssetPostprocessor
{

  static void OnPostprocessAllAssets(string[] importedAssets, string[] deletedAssets,
    string[] movedAssets, string[] movedFromAssetPaths)
  {
    const string pathToResources = "Assets/Resources/";
    const string pathToGameData = "Assets/StreamingAssets/RpgGameData.gdjs";
    const string importedEntityName = "GameAsset";

  var assets = (
        from assetPath in AssetDatabase.GetAllAssetPaths()
        where assetPath.StartsWith(pathToResources)
        select new { Path = assetPath, Name = Path.GetFileNameWithoutExtension(assetPath) }
      ).ToList();

    var assetsJson = JsonConvert.SerializeObject(assets);

    var fullPath = Path.GetFullPath(pathToGameData);
    var importAsync = CharonCli.ImportAsync(fullPath, new[] { importedEntityName },
      CommandInput.JsonString(assetsJson), ImportMode.CreateAndUpdate);

    importAsync.ContinueWith(t =>
    {
      Debug.Log(t.ToString());
      /* do some stuff */
    });
  }
}

And while I see:
Fulfilled promise, result=GameDevWare.Charon.Utils.RunResult.

In the Console output after I add new Prefab to Resources folder, I see no changes in RpgGameData

I see no changes in RpgGameData

Do you have GameAsset entity with two attributes Path and Name in RpgGameData.gdjs file? It can't import in non-existent entity. Also import could ends with errors.
BTW more detailed result could be taken from RunResult with following code:
importAsync.ContinueWith(t =>
    {
      if (t.HasErrors) {
          Debug.Log(t.Error);
          return;
     }
     using(var result = t.GetResult())
     {
         if (result.ExitCode == 0) {
             return; // no errors
         }
         // print captured Standard Output and Standard Error
         Debug.Log(result.GetOutputData() + "\r\n" + result.GetErrorData());
     }
    });


Test ansq against py39

Codecov Report

Merging #41 (6778302) into master (c5b18c1) will decrease coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   82.88%   81.95%   -0.93%
==========================================
  Files          28       28
  Lines        1385     1347      -38
  Branches      131      131
==========================================
- Hits         1148     1104      -44
- Misses        189      192       +3
- Partials       48       51       +3

Impacted Files
Coverage Δ

tests/test_convert_to_bytes.py
96.55% <0.00%> (-3.45%)
:arrow_down:

ansq/tcp/connection.py
59.25% <0.00%> (-1.49%)
:arrow_down:

ansq/utils.py
84.44% <0.00%> (-1.12%)
:arrow_down:

tests/test_read_messages.py
96.74% <0.00%> (-0.18%)
:arrow_down:

tests/conftest.py
89.23% <0.00%> (-0.17%)
:arrow_down:

tests/test_utils.py
100.00% <0.00%> (ø)

tests/test_connection.py
100.00% <0.00%> (ø)

tests/test_http_writer.py
100.00% <0.00%> (ø)

tests/test_send_commands.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b18c1...6778302. Read the comment docs.


Secrets Management feature is now GA

What does this PR do?
Remove the Beta tag for the Secrets Management feature as it's now GA.

do we need to update https://github.com/DataDog/datadog-agent/blob/master/Dockerfiles/agent/secrets-helper/README.md as well?

do we need to update https://github.com/DataDog/datadog-agent/blob/master/Dockerfiles/agent/secrets-helper/README.md as well?

Yes, good catch !


feat(azure-service-utils): Promote generateToken from @internal to @alpha to ensure API docs are generated for it.

The API as tagged would not generate API docs, but we do expect our SDK users to at least reference it.

/azp run repo-policy-check


Prepare docs for 1.11 release

This Pull Request is created by release automation to prepare release for 1.11 documentation

Dead link checker error is false positive (temporary 502 bad gateway error for GH). Merging anyway...


Generic changes before sending the srpm command

please merge right away if you like this

upstream: break down get_upstream_version
run_command: log stderr output if there is some

TODO

[x] Implement what we agreed on with Franta.

Fixed & rebased & cheering on CentosCI

PLease rebase..;-)


Beta: Various Challenges. Cursor Jumping to Top of Page

Challenge Name
Various
Issue Description
When entering code into the challenge, the cursor will randomly jump to the top of the page mid-word while typing. Tested in 2 Browser and on 2 systems.
This is a random issue and doesn't happen on every challenge
Browser Information

Browser Name, Version: FireFox, Chrome (Latest and Greatest)
Operating System: Windows 7, Windows 10
Desktop

Your Code

Screenshot

I confirm. I noticed the same weird cursor jumps in many challenges.

@lydatech @gogolab thanks for the report.
We have had this in the older infrastructure as well. We though this was resolved.
Sad to hear that this is back again.
Will look into it.

Refer #7847

Confirmed. Tested on Chrome with Windows 7. Cursor jumps to top of the page when hitting enter for a new line. First noticed on "Nest Many Elements within a Single Div Element" in Basic HTML.

This happens to me when I stop typing and then immediately type any one character (immediately meaning some small time after the editor's debounce time). Could this be an issue with react-codemirror?

/cc @BerkeleyTrue

@raisedadead how is this issue different from #7847 ?

@BerkeleyTrue I haven't been able to confirm the cause on this.
But looks like the bug continues to stay between the original code mirror to react-codemirror as per comments from above?
I haven't been able to reproduce this either.
We could close this, in favour of the other, but I believe this is on different infrastructure than the previous.

This keeps happening to me usually when I'm on the last line of my code. I'm using Chrome on Windows 7.

For everyone having the mouse cursor problem, try Chrome Canary, works fine

I'm closing this issue as stale since it hasn't been active lately. If you think this is still relevant to the newly updated platform, please explain why, then reopen it.


Format by field value not applicable

[Enter feedback here]
Power bi report server May 2020, to format color by field value, I can’t select a column to perform this function

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3af9ce3a-a3eb-8d57-55a7-66f04f46bbf7
Version Independent ID: 58e304ed-89d2-3c85-4428-acefedaef5c0
Content: Conditional table formatting in Power BI Desktop - Power BI
Content Source: powerbi-docs/create-reports/desktop-conditional-table-formatting.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @jw3315 . This issue has been assigned to the doc author for review.

Hi @jw3315 ,
I'm cleaning up our Git Issues queue, and I noticed that this Git issue is a bit old, so I'm going to close it.  I hope that you were able to get your questions answered. If not, please let us know.  Another option for this type of issue is to submit your questions to the Power BI community (community.powerbi.com).
All the best,
the DOCS team