Middleware is broken

Bug
An important middleware pattern has been broken. IMO the majority of middleware solutions encapsulate their own concerns and are independent of the existence of other middleware. A change was made recently to break a pattern that only caused a minor issue for a specific subset of middleware: those that exhibit different behaviour when interacting with other middleware during the applyMiddleware initialisation path.
Here are some examples:
// Make state aware of browser media queries
const mediaQueries = (mediaQueries = defaultMediaQueries): Middleware => store => {
  if (typeof window !== 'undefined') {
    const reverseMap = createReverseMap(mediaQueries)

    const handleMediaChange = ({media, matches}: MediaChangedActionPayload) =>
      store.dispatch(mediaChanged(reverseMap[media], matches))

    const addMatchListener = (media: string) => {
      const match = window.matchMedia(media)
      match.addListener(handleMediaChange)
      return match.matches
    }

    values(mediaQueries).forEach(media =>
      handleMediaChange({media, matches: addMatchListener(media)}))
  }

  return next => (action: any) => next(action)
}

Another example:
// Make state aware of user adblockers
const adBlockDetection: Middleware = store => {
  if (typeof document !== 'undefined' && !document.getElementById('XMpADSwgbPUC')) {
    store.dispatch({type: AD_BLOCKER_DETECTED, payload: true})
  }
  return next => (action: any) => next(action)
}

Another example:
// Make state aware of socket connectivity and allow synchronisation of actions
const socketMiddleware = ({actionCreator, url, dataSync}) => store => {
  const socket = new WebSocket(url.replace(/(http|https)/, 'ws'))

  socket.addEventListener('message', ({data}) => {
    store.dispatch(JSON.parse(data))
  })

  socket.addEventListener('open', () => {
    socket.send(syncCreator(CONNECT_TO_DOMAIN, store.getState(), null, socket))
    store.dispatch(actionCreator({connected: true}))
  })

  socket.addEventListener('close', reason => {
    store.dispatch(actionCreator({connected: false}))
  })

  return next => action => {
    if (dataSync.hasOwnProperty(action.type)) {
      socket.send(syncCreator(action.type, store.getState(), action.payload, socket))
    }
    return next(action)
  }
}

What is the current behaviour?
The following error is thrown during applyMiddleware, essentially breaking the application:
Uncaught Error: Dispatching while constructing your middleware is not allowed. Other middleware would not be applied to this dispatch
Refactoring the above middleware to be closed over by the next => function (like below) makes no difference (but is obviously not a viable solution either).
// Still broken:
const mediaQueries = (mediaQueries = defaultMediaQueries): Middleware => store => next => {
  // ...middlewareCodeGoesHere...
  return (action: any) => next(action)
}

What is the expected behavior?
Do not break the app. Log a warning if you want, so I can ignore it, because in 100% of my use cases I do not care if other middleware can handle that dispatch. I strongly suspect that there are (or should be) very few legitimate reasons why any dispatch from within a middleware context should ever interact with any other middleware in the stack, and if it did, I would consider that a code smell (it would place implicit order dependencies on middleware at the very least).
Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?
Worked until this PR.

The middleware init process was explicitly changed in 4.0 in the PR you linked.  This was a deliberate design decision, and intended to resolve #1240.
I'm not sure I have an immediate suggestion for your use case, other than to try changing your middleware's logic to wait for some manually-dispatched "store is ready" action.

It's still possible to make every one of your examples work. Just dispatch after applyMiddleware. Perhaps in some sort of setupMiddleware(store) function or a store enhancer.
The Error was intentionally introduced as the alternative is to allow users to hit an edge case that has a very non-obvious cause (unless you're familiar with the internals of applyMiddleware). Redux takes the stance of preventing user error whenever possible, so this isn't going away.
One alternative might be some sort of callback the middleware can register as a sort of afterApply event. Then you would be guaranteed to be dispatching at the correct time, after everything is applied and in order. That would be interesting to think through.

For middleware developers encountering this issue, setupMiddleware(store) is now done with an enhancer
From the redux docs
Middleware adds extra functionality to the Redux dispatch function; enhancers add extra functionality to the Redux store.


How to save scanned images in specific directory not in pictures

At this string, I think we need to add folder like /AndroidScannerDemo/img.jpg
String path = MediaStore.Images.Media.insertImage(context.getContentResolver(), bitmap, "Title", null);
at this line:
Line 23

@nalinbansal1234 its pure java but andriod java is bit different I think


Fix getting app exe path when using PublishSingleFile

PR Details

Use PlatformFolders.ApplicationExecutablePath instead of Assembly.GetEntryAssembly().Location
https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/overview?tabs=cli#api-incompatibility
Under 'API incompatibility' Assembly.Location is not available with single file deployment.
https://learn.microsoft.com/en-us/dotnet/api/system.environment.processpath?view=net-8.0
Environment.ProcessPath can be used as a fallback, but do note that even that can return null.
Related Issue

Fixes #2304 where Icon is set via GameContext.ProductLocation
Also fixes the super secret LeftCtrl + C+ F1 screenshot command in PublishSingleFile.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[X] I have built and run the editor to try this change out.

Thanks !


Bump Dependencies #2109773120

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/2109773120

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Same Radius

HI! I've been running various objects with the SEDkit and found out that it gives out the same radius for all objects; regardless of the object, it gives out 0.9731158731046832 jupiterRad.

Ok I'll take a look! Thanks for letting me know.

Hello! @hover2pi  I just wanted to add more info to this error that we are getting. The line of code we get when initializing the sed in particular for the radius says  Setting radius to (<Quantity 0.97311587 jupiterRad>, <Quantity 0. jupiterRad>, <Quantity 0. jupiterRad>) with reference '2013ApJS..208....9P. Overall, is the radius of the objects being inferred using a specific method?

Ok, the fix for this is in the next release #80

thanks, super excited for the new release!


Stakeholder Kick-off Meeting - 24/09/2024

Tuesday Sept 24, 10:00 - 11:30 AM
Attendance

[x] Mitchell
[x] Richard
[x] Akshit (virtually)
[x] Rafeed
[ ] Kyle, Not Attending due to scheduling conflict

Team members are to carpool to the location with Mitchell.
Agenda

Meeting to begin with introductions of team members to stakeholders from the City.
Mitchell to begin the discussion with a powerpoint presentation. Presentation to explain who we are, what the capstone is, work our team has done to this point on the problem statement, and expected commitment from the City. Link to presentation is here.
Main objective after introductions is to brainstorm problems in order to further develop the scope of the project. Need to emphasize we are not thinking of solutions so much at this point, we specifically need to generate as many problems as we can which we will document and filter through to construct the requirements for the application.

Questions to Ask

For verifying that people are on-site, does this require a picture? Or would using GPS location from the device be fine?
Should every user be able to access all documents, or would some users have different permissions levels? If it is desirable to have different permission levels, is it needed? or just something that would be nice to have?
Should there be a history of edits made to a file (i.e. keep track of who modified a document and when)? If so, is it needed or nice to have?
Should documents be versioned (i.e. Allow storage of older versions of files in the system so that people can see the history of what was changed)? if so is it needed or nice to have?
Are there any existing systems that the client would like this system to be able to integrate with? what might these integrations entail? Are the integrations needed or nice to have?

Meeting Notes for meeting with City of Hamilton Sept 24, 2024
This is a meeting with stakeholders to kickoff the meeting. The goal of this
meeting is to elicit goals and determine the scope of the system.
Goals put forward by the city

Entry protocol, hazard analysis, compliance documentation. Don't want to store
documents on the site. Should be editable directly remotely.
The driver of this documentation is regulations.
to verify completion of work by facilities, don't want to involve operations.
by having a digital logbook, we just want to know who visited site when, and
what they did.
Ideally, this information can be exported as an excel document, to show
compliance.
Don't need to have a contractor portal, there are already initiatives (EAM)?
Ability to interact with other databases.
Health and safety tracking (wsib, trainings current, other things).
Notify if someone who hasn't complete training visits site.
Complement the physical logbook. Should be able to upload documents to the
system remotely.
Flag completion red flags if training is not complete.
It is a bidirectional flow of information.
Ex. go to site, scan qr code, nfc, takes you to a site that you sign into,
that site has all the hazard assessment documents, they signoff on all that
information on the spot.
Loading information to stations should be quick. i.e. how to update and upload
information? Should be easy and quick
Signoff documents, and
Ensure that all inspections are up to date.
Could be a map where contractors select a station and upload
Should be a geolocation fencing feature to prove that someone logged in.
For authentication, use the persons name and email.
Link workorder, or description of work provided.
Filter through service categories
Challenge: contractor is extension of the city, need to keep track of all
their compliance.
Developing new contracts: don't know when they are on site, what they are
doing on site, keep logs of what work was done, how long the work took, keep of
of stats, ideally export to excel.
Verify invoices based on time on site.
ARCOBUS?

Asset manager
Picture
serial numbers

Note Entry Procedures.

Checklist of things to do (e.g. call operators, ppe on?,check that the door is locked, alarm
disalarmed)
can't close work order until that these things have been completed

Note there is anm interface standard for accessibility standards. (magnify
font, speak, commonly used language)
Integration with infer (EAM), becos, BI, intellect, mysds, documents shared on
sharepoint, ideally sharepoint will be used to store the documents.
Integration with coporate security
Access control: video intercom to process supervisor to request access
(integrate access control logs, live logs?)
Emergency alert in case of shutting down out locking out equipment (maybe
contractor portal in EAM)
AIPhone intercom system
Note: There are some restrictions on collecting some types of data

Outline

Sign in identification (side, building, operations, entry procedures)
Safety (ppe on)
Wants to do

photo
service contract

Documentation provided from city
Trained?
Feedback

adding to the above:

Idea that the system could have "digital keys". Example, an upcoming corporate security keyscanner could be swiped by the phone which authenticates that the user has been granted access for a specific time period.
City has a "cut sheet" of the video intercom system, can be provided upon request.


Custom BT stack with Link Relay

Not sure this is really an issue, but I'm looking to do a modified version of Use Case 6. I have a custom Bluetooth stack, which uses a standard H4 HCI interface. I'm planning to use the Linux hci_vhci.ko module, but don't have to.
I want to connect this BT stack to a link relay, which will have several virtual devices connected.
I haven't able to find an example/application in the bumble repository that does what I'm trying to do. It looks like I need to create something like run_simulator.py which will create a RemoteLink to the link_relay, then connect that to a virtual controller, which uses vhci as its host sink/source. (also, without the devices, since those are all connected to the link relay)
                                     ┌───────────────┐
                                     │   Custom BT   │
                                     │     Stack     │
                                     ├───────────────┤
                                     │ HCI Interface │
                                     └───────────────┘
                                             ▲
                                             │
                                             │hci_vhci.ko
                                             │
                                             ▼ Custom python app (pseudocode follows)
                          ┌───────────────────────────────────────────┐
                          │rlink = RemoteLink(ws:<IP_ADDRESS>:10723)     │
                          │open_transport_or_link(vhci) as (vhci_host)│
                          │ctrl = Controller (vhci_host, rlink)       │
                          │wait_for_termination()                     │
                          └───────────────────────────────────────────┘
                                             ▲
                                             │
+--------++--------++------------+           │websock     +------------++--------++--------+
| Bumble || Bumble || Bumble     |           │            | Bumble     || Bumble || Bumble |
| Python || Host   || Controller |<--+       ▼        +-->| Controller || Host   || Python |
| App    ||        ||            |   |   +--------+   |   |            ||        || App    |
+--------++--------++------------+   +-->| Bumble |<--+   +------------++--------++--------+
                                         | Link   |
+--------++--------++------------+   +-->| Relay  |<--+   +------------++--------++--------+
| Bumble || Bumble || Bumble     |   |   +--------+   |   | Bumble     || Bumble || Bumble |
| Python || Host   || Controller |<--+                +-->| Controller || Host   || Python |
| App    ||        ||            |                        |            ||        || App    |
+--------++--------++------------+                        +------------++--------++--------+

Am I on the right track? Or is there a better / more straightforward way to do this?
Thank you for your help!!

You're definitely on the right track, this should be possible.
I'll preface the following text with a caveat: the link relay (and the Bumble Controller class that uses it) isn't full-featured, and is a fairly low-fidelity, partial, simulator for a virtual link between virtual controllers. We'll probably end up either deprecating it at some point, and/or replace it with something more comprehensive, like the "root canal" component that's now part of the Android AOSP project, used within the "netsim" daemon also part of AOSP, see https://android.googlesource.com/platform/tools/netsim/+/refs/heads/master. If/when we find a good way to package it as a standalone component so that it can be used with Bumble without having to pull the entire AOSP set of repos, that may become a viable option). But for now, the Bumble Controller and virtual link component is probably good enough for a number of use cases, including local unit tests.
Now, as to the specific scenario you're looking at here: (i'm not sure what script you're referring to by run_simulator.py, but that doesn't matter), what you want is to instantiate a bumble.Controller object, connected to the relay. That controller exposes an HCI source and sink on its "host" side, and you want to connect that to your stack. If your stack is exposed via /dev/vhci, that's a viable option, but any other supported transport from the bumble/transport collection would work as well (TCP, UDP, WS, PTY, ...). Unfortunately, the run_controller.py example isn't a good example for that, because that example instantiates a virtual controller, but doesn't expose it to an external stack, it exposes it to a local stack.
But... you should be able to do this with a combination of the existing apps included in the project.
1/ Run the link relay, ready to accept client connections. bumble-link-relay (or python apps/link_relay/link_relay.py if from source). This will listen on port 10723 by default.
2/ Run an HCI bridge from your custom stack to the link relay, via a local controller (the HCI bridge app does use the open_transport_or_link function, so it can automatically instantiate a controller when the destination is the relay and not directly an HCI transport). The "host" side of the bridge can be whatever transport you want, but I suppose vhci would be appropriate for you here. Something like: bumble-hci-bridge vhci link-relay:ws://localhost:10723/test (or python apps/hci_bridge.py xxxx if from source).
3/ Any other virtual device that connects to the /test (using /test here to match the "room" name used in step 2, but any other name would be fine, as long as they match) "room" of the relay will then be able to communicate with the stack that's bridged in step 2. For example, bumble-scan link-relay:ws://localhost:10723/test

Just one more thing: when running apps like bumble-hci-bridge, it may be helpful to set  the env var BUMBLE_LOGLEVEL=debug to see a detailed log of the HCI traffic. The same applies to all other tools, which don't have verbose logs enabled by default. Alternatively, if you want to record the HCI packets to a file instead of debug logs, you can set BUMBLE_SNOOPER=file:my_snoop_file.log (see bumble/snoop.py for details on the snooper syntax).

Thank you very much @barbibulle for the thorough response!

I'll preface the following text with a caveat: the link relay (and the Bumble Controller class that uses it) isn't full-featured, and is a fairly low-fidelity, partial, simulator for a virtual link between virtual controllers. We'll probably end up either deprecating it at some point, and/or replace it with something more comprehensive, like the "root canal" component that's now part of the Android AOSP project, used within the "netsim" daemon also part of AOSP,

Are there any high-level descriptions of how netsim/rootcanal work together? It looks like the netsim documentation is pretty limited currently, and I haven't come across a good description of the root canal design. It looks straight-forward to use with an Android emulator, but outside of that use case, I haven't really found any good information.

Thanks again!!!

Rootcanal is a standalone executable, it listen for TCP connections (used for HCI traffic) where for each TCP connections a virtual controller is instantiate.
It should be moved from AOSP to github in the next weeks🤞 (please correct me if I'm wrong @hchataing)

Netsim integrates rootcanal as a library. You can configure it to open a tcp server of grpc server to access the bluetooth controller. Work to make it open source on github has been delayed slightly because of internal dependencies on AOSP tooling, but I am hoping to make it available soon :)

Thank you all for the great information!! Netsim looks like its intended to support more than just BT, so that will be handy.
I look forward to hearing how rootcanal/netsim progress and hopefully switching over to them soon!
Is the project still open to pull requests/enhancements to the existing controller & link relay? I found a few HCI commands that I need to add to support my use case.
I was able to get basic communication working, so I'll mark this ticket as closed, but I welcome any additional info you're willing to share!

Is the project still open to pull requests/enhancements to the existing controller & link relay?
I found a few HCI commands that I need to add to support my use case.

Please go ahead and forward your requirements. You can submit patches to AOSP but I would understand if the setup is too complicated for you. It will be easier to receive external contributions when it is opensources :)

For now, I'm focusing on the Bumble/python functionality, so I'll be submitting the patches to github. The additional updates are pretty small (for example: https://github.com/google/bumble/compare/main...akuker:bumble:akuker-fork/main)
(Disclaimer - that patch isn't merge-worthy yet. It was just a quick hack for the moment. I still need to think through some of the values its returning)


brew update not working — bad substitution error on update.sh

Please follow the general troubleshooting steps first:

[X] Ran brew update and retried your prior step?

I tried to.

[X] Ran brew doctor, fixed as many issues as possible and retried your prior step?
[X] If you're seeing permission errors tried running sudo chown -R $(whoami) $(brew --prefix)?

Bug reports:
I just installed OSX El Capitan and now brew update doesn't work. I have followed these instructions: https://ohthehugemanatee.org/blog/2015/10/01/how-i-got-el-capitain-working-with-my-developer-tools/
Then I tried things like changing permissions, pulling it from origin again and doing a hard reset, uninstalling Homebrew and installing it again, and so on. The error remains. I can run brew doctor and it doesn't report any errors other than a few unlinked files that I installed myself. I just can't run brew update (the whole problem started because I ran brew doctor and it recommended that I run brew update). Xcode is installed too. Anyway here's what shows up when I run brew update:
mv: rename /usr/local/Library/Taps/homebrew-versions, to /usr/local/Library/Taps/homebrew/homebrew-versions/homebrew-versions,: No such file or directory
/usr/local/Library/Homebrew/cmd/update.sh: line 58: ${#${tap_dir_basename//[^-]}}: bad substitution

And here's the content of line 58 and the following ones, in update.sh:
if [[ ${#${tap_dir_basename//[^\-]}} -gt 1 ]]
then
        echo "Homebrew changed the structure of Taps like <someuser>/<sometap>." >&2
        echo "So you may need to rename $HOMEBREW_LIBRARY/Taps/$user/homebrew-$repo manually." >&2
      fi
    else
      echo "Homebrew changed the structure of Taps like <someuser>/<sometap>. " >&2
      echo "$tap_dir is an incorrect Tap path." >&2
      echo "So you may need to rename it to $HOMEBREW_LIBRARY/Taps/<someuser>/homebrew-<sometap> manually." >&2
    fi
Any idea what this is about?

What is the output of ls -AlF /usr/local/Library/Taps and ls -AlF /usr/local/Library/Taps/*?

What is the output of ls -AlF /usr/local/Library/Taps and ls -AlF /usr/local/Library/Taps/*?

Nevermind! I was able to reproduce this locally and fixed the bug. Thanks for reporting it! Can you please do the following one last time and report back whether it worked this time?
cd /usr/local
git checkout master
git fetch origin
git reset --hard origin/master
brew update

cc @xu-cheng Do 93e0f4f9465978460d411f27214e19ae3fc4d294 and 500f9eada854c1939bf9a0caf94085214c9399b0 need to be backported to Homebrew/legacy-homebrew?

@UniqMartin
It worked! Thank you!

@UniqMartin I think so. Thanks for catching this.

I think so. Thanks for catching this.

Done in https://github.com/Homebrew/legacy-homebrew/commit/43dda695290bb4fcc5ed458759ce797c41abb83e and https://github.com/Homebrew/legacy-homebrew/commit/f0b70e5725662377ea2feb14f59e407bd7071fe0.


Cluster installation inherit the xtrace setting from devstack plugin

What this PR does / why we need it:
For now, the devstack installation will enable the xtrace when run the plugin script, it's helpful for checking the details of plugin installation with the logs. This PR make the k8s cluster installation script inherit the xtrace setting of the plugin.sh so that we can check the k8s cluster installation details in job logs.
Which issue this PR fixes
Special notes for your reviewer:
Release note:

LGTM thanks!


how to muck dbfunction methods

How does one mock method with the DbFunction attribute using the in memory provider?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c95e5c7e-882f-76f7-5301-2a5d1ede39d3
Version Independent ID: 8754aa99-67a7-98ac-a51e-0ba995f96414
Content: Testing with InMemory - EF Core
Content Source: entity-framework/core/miscellaneous/testing/in-memory.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @rowanmiller
Microsoft Alias: divega

@smitpatel can you please answer this?

@JuanZamudioGBM- Since InMemory does not support and ignores DbFunctionAttribute, the easy way to mock a function for testing is write the function body. It could be actual body which would do similar processing of what function would do on relational database or it can be a fake one. In fake implementation, you can do similar to setting up mock, like return particular value for given parameters which you will encounter. If function throws for certain parameters but they are never encountered, it will never throw (or validate that function works for all values).


[AMBARI-23021] ServiceInfo: credential_store_supported attempts to overwrite maintenance_state

What changes were proposed in this pull request?
Provide the correct error message in response for trying to update the credential_store_supported property.
How was this patch tested?
Tested on local cluster:
$ curl -X PUT -d '{ "ServiceInfo": { "credential_store_supported": "true" } }' "http://$AMBARI_SERVER:8080/api/v1/clusters/TEST/services/ZOOKEEPER"
HTTP/1.1 400 Bad Request
...
{
  "status" : 400,
  "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot update credential_store_supported as it is set only via service definition. Service=ZOOKEEPER"
}

Related unit test:
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.88 s - in org.apache.ambari.server.controller.internal.ServiceResourceProviderTest

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1054/
Test FAILed.
Test FAILured.


Pinouts for the second Stack

Stackable: running 2 motors in the same time
Pinouts: At this point PowerShield has fixed pinout.
how to play with the Pinouts for second stack?

At this moment ( v0.2 ), this board is not stackable. The text you've quoted in in future releases.
I'll make sure to make it stackable for the next release v1. :)


Instrument select ref Crab IR

Add implementation for instrument Crab IR: select_ref by using emitters.

@caballa Refactorized my code. Please review.


Missing Installation Step on the online Version

In the prequesites the following step

Don't forget to register .NET framework with your IIS
* Run %windir%\Microsoft.NET\Framework\v4.0.30319\aspnet_regiis.exe -ir with administrator privileges

is missing on the page https://bonobogitserver.com/prerequisites/

@SebastienAndreo Thanks for this - do we know if this step is actually still necessary on any current machine / .NET framework?  I haven't had to do this for years myself.
I absolutely agree the instructions should be consistent, though.

I can confirm that it is still needed, otherwise the .NET4 application pool will not show up. Even when creating my own .NET4 pool, it would not work like the one generated by the command above. I might be missing something but running 1 command line is definitely easier than fishing the application for buttons.


How to run perf_test.js?

Could you tell me how to run the existing perf_test.js please? I can add this as a script in package.json to make it easy to run once I know how. Thanks

./node_modules/.bin/nodeunit test/perf_test.js


use rook v1.1.0 in E2E testing

rook master is not good enough to depend on for E2E testing, switching to v1.1.0 for E2E
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

@poornimag @ShyamsundarR can any one of you approve this PR ? this is blocking other PRs so te urgency


Add hover effect and show icon name on hovering

Current state :
In the current state of the adobe-xd plugin, when a user tries to hover to an icon, it remains the same and moreover the icon does not shows name of the icon.
https://user-images.githubusercontent.com/67755381/159129378-ea286191-2130-4369-8e2c-59b06346fd98.mp4
Expected state :
On hover should be applied to the icons so that a user can know on which icon its pointing and the name of the icon should aslo be provided on hovering to the icon

I am working on this


Unable to add new lines and duplicated blocks at the bottom of tA blocks

translationCore Create - v1.0.5-rc.7
This happens both in preview and non-preview mode
Movie at https://app.zenhub.com/files/191973535/8484057a-2b35-4e45-80be-e9e1e869e7c1/download

Open a tA project
Open one of the blocks
Position the cursor at the bottom of the block
Press the Enter/Return key
Note that the new line is temporarily added, then deleted with the cursor returning to the end of the previous last line

here's the behavior I see:
C:\Users\ZPennington\AppData\Local\Temp\557e1d2d-88d0-4eeb-9cc2-72539bcd6171.gif
@RoyalSix  maybe unblocking tomorrow ?

I narrowed this down to markdown-translatable 1.2.5

deploy preview is here:
https://deploy-preview-509--tc-create-app.netlify.app/

https://deploy-preview-509--tc-create-app.netlify.app/ Verified in the link- Able to add new lines at the bottom of Blocks.
There is an issue - Autofill /duplicated blocks when we type at the end of a block. This does not happen with every block. After some investigation, found that if there is a text which does not start with a md character (# or >) the blocks gets duplicated and autofilled.

Testable in v1.0.5-rc.10
https://develop--tc-create-app.netlify.app/

Testable in translationCore Create - v1.0.5-rc.10
https://develop--tc-create-app.netlify.app/
@elsylambert  @cckozie

translationCore Create - v1.0.5-rc.10. Not seeing the issue in tA blocks. Able to add new lines at the end of a block and not seeing duplicated blocks.

Looks good in v1.0.5-rc.10


Invert apiVersion and kind in docs

Fixes https://github.com/kubernetes-sigs/gateway-api/issues/810
Done with intellij find+replace on regex kind: (.*)\napiVersion: (.*)
to apiVersion: $1\nkind: $2

Thanks!
/ok-to-test
/lgtm

Thanks for improving the consistency @howardjohn.
My OCD is indebted to you.
/approve
/lgtm


Several template improvements

Move Languages services from site.js to base.js
Now the detected browser language is used as projector language.
Use verboseName instead of agendaSupplement.
Show submitters on projector (load Users on Controller).
Improve list of speakers (slide and item detail).

@emanuelschuetze Please fix the notes in another pull request


explain which targets we support to what extent

This is basically documenting my policy so far: Linux is the target I know best and can spend most time on. Apple is so close to Linux that it can basically ride along without much extra work. I don't have a lot of time to spend on our Windows support.
Of course, if people commit to contributing and maintaining support for a target, we can promise more than what is documented here. :)  But this is what I am willing to promise.
Also reduce the amount of work we do on the Windows test runner, since that one currently takes 10min longer than the other two.
r? @oli-obk

Wow why does Windows CI still take >30min? I removed an entire target, it should have gotten faster...

Hm, something seems to be wrong with our caching? We should be caching xargo, but we don't. Or rather, the cache we have contains an older xargo.
Wasn't there something about GHA caches being write-once? So if we want the cache to update when xargo / rustup-toolchain-install-master change their version, we need to include their version number in the cache name.

I guess what we should do is fix the version of RTIM and xargo that we install, and rebuild the cache when that fixed version changes. But that seems like a hassle (we want the latest version, after all) so I just ad-hoc changed the cache key now... not sure if GHA at all supports the idea of "use the latest version of some other tool and cache that build".

@bors r+

:pushpin: Commit b4089a77abbfa19b674ebf1343a8ef974c10e67c has been approved by oli-obk

:hourglass: Testing commit b4089a77abbfa19b674ebf1343a8ef974c10e67c with merge 38111b3916987c3b2a779626002830c94882b0a4...

:sunny: Test successful - checks-actions
Approved by: oli-obk
Pushing 38111b3916987c3b2a779626002830c94882b0a4 to master...


Testing the github hook [2476]

By Bluemix Marna Garage (marnagarage -<EMAIL_ADDRESS>on 2017-02-09 13:45:02.676
Just testing the hook

Migrated from https://hub.jazz.net/ccm47/resource/itemName/com.ibm.team.workitem.WorkItem/2476


" Failed to generate type for " when an input has a union field

Hello!
Consider:
type Foo {
  a: String!
}

type Bar {
  b: String!
}

union Union = Foo | Bar

input Input {
  input: Union!
}

extend type Mutation {
  example(input: Input!): String!
}

This fails with:
[SEVERE] graphql_codegen on lib/src/graphql/deployment.graphql:

Bad state: Failed to generate type for Union.
package:graphql_codegen/src/printer/base/property.dart 119:5  _printNamedTypeNode
package:graphql_codegen/src/printer/base/property.dart 52:12  _printTypeNode
package:graphql_codegen/src/printer/base/property.dart 39:10  printClassPropertyType
package:graphql_codegen/src/printer/base/input.dart 36:29     _printInputClasses.<fn>.<fn>
package:code_builder/src/specs/method.g.dart 649:33           _$ParameterBuilder.update
package:code_builder/src/specs/method.g.dart 398:32           new _$Parameter
package:graphql_codegen/src/printer/base/input.dart 34:21     _printInputClasses.<fn>
dart:core                                                     new List.from
package:built_collection/src/list/list_builder.dart 44:20     ListBuilder.replace
package:built_collection/src/list/list_builder.dart 20:45     new ListBuilder
package:graphql_codegen/src/printer/base/input.dart 32:29     _printInputClasses
package:graphql_codegen/src/printer/base/input.dart 15:5      printInputClasses
package:graphql_codegen/src/printer/printer.dart 23:20        printRootContext.<fn>
dart:core                                                     new List.of
package:graphql_codegen/src/printer/printer.dart 21:40        printRootContext
package:graphql_codegen/graphql_codegen.dart 27:10            _generateDocument
package:graphql_codegen/graphql_codegen.dart 118:10           generate
package:graphql_codegen/builder.dart 104:20                   GraphQLBuilder.build

It appears that _printNamedTypeNode does not handle Union types and throws because of it.

Looks like the schema was invalid. Closing :)


Compact re-exports babel plugin causing persistent-cache miss

#408 adds a babel plugin, but does not implement a proper cache key. This results results in warm builds not benefiting from a persistent cache.
more details on how to implement said persistent cache: https://github.com/stefanpenner/broccoli-persistent-filter#persistent-cache

cc @trentmwillis

Caching Was added in https://github.com/ember-engines/babel-plugin-compact-reexports/pull/4, we just need a release.

awesome. I'll go wrestle @trentmwillis for release bits for us.

Totally thought I had released that...oh well, now y'all have proper privs.


Reduce the amount of allocations and code for options

Improvements to how we deal with struct sol_flow_node_options.
The second patch ensures that we simply pass thru the options from the spec if nothing is being exported, as discussed in #335.

The third patch still doesn't touch JS and Simple CType, I'll look at them now but this is good enough for a review.

@ibriano could you take a look?

LGTM


Use escape characters for drawing to terminal

This PR is not ready to merge yet.
This pull request is designed to fix an issue where clearing the screen causes unsightly flickering. By using escape characters, this problem is mitigated.

[X] Draw to sections of the screen with escape characters
[X] Hide cursor

[X] Hide user input

[X] Repair damage when resizing window
[X] Save and restore user's terminal state (XTerm only)
[X] Make sure rat spinner does not generate damage

The ASCII art likely will have to be redone in order to add whitespace across the entire area that the rat inhabits. Otherwise, the rat will leave ASCII characters all over the place.
Alternatively, it may be possible to echo the file line by line and append the whitespace at that point, but this is less efficient and will probably run into other problems anyway.
Script is back to using Bash, as an exit trap is needed to re-enable the cursor and clear the screen it makes the code significantly cleaner thanks to functions. And also because the printf built-in doesn't work as well on some POSIX shells such as Dash.

You will have to update the ASCII art. While I'm sure there's probably a way to use the current ASCII art, I'm also sure it won't work as well as just using improved ASCII art that includes whitespace to overwrite the previously drawn characters.

PR is finally ready to merge. I finally bit the bullet and added the extra whitespace myself. The binary will not work correctly initially but you can repackage it. I don't know how to do it myself.

Sorry, completely forgot about this. Thanks for doing the ASCII art, I would have remembered eventually but who knows how long it'd have took. I'll package it up now.


[Do Not Merge]Create CentOS gcc4.8 & MKLDNN ci-test

Description
This pr is created to add a new ci-test which use gcc4.8 & MKLDNN to solve issues on #10168 and #10200
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@marcoabreu Compiling error is reproduced here: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-10218/3/pipeline/51
tests/cpp/operator/mkldnn.cc: In function 'bool test_mem_align(void*, size_t, size_t, size_t)':
tests/cpp/operator/mkldnn.cc:37:10: error: 'align' is not a member of 'std'
   ret2 = std::align(alignment, size, mem, space2);
          ^

I will try to restrict compiler version to >5.0 for this test case.

Great, thanks. Feel free to go ahead. Please don't forget to print a message if this specific test-case is disabled but run.

GCC version check is added. Currently, I don't know which versions of msvc and clang support std::align, so I restrict this test to GCC > 5.0.
Below is the output when compiled with GCC 4.8:
$ ./build/tests/cpp/mxnet_unit_tests --gtest_filter=MKLDNN*
Note: Google Test filter = MKLDNN*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MKLDNN_UTIL_FUNC
[ RUN      ] MKLDNN_UTIL_FUNC.AlignMem
[17:07:58] tests/cpp/operator/mkldnn.cc:77: Skipped for GCC 4.8
[       OK ] MKLDNN_UTIL_FUNC.AlignMem (0 ms)
[----------] 1 test from MKLDNN_UTIL_FUNC (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 1 test.

Please also note that centos7_mkldnn is compiled with test option on. I don't know if it is appropriate for building mxnet in ci environment.

@marcoabreu @xinyu-intel Seems there is an error when build mxnet with test option: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-10218/6/pipeline
So I removed the test option from centos7_mkldnn in this PR for further testing.

Ah that's totally fine. You were basically executing 'make test', which consists of different behaviour than 'make'. Thanks for your efforts!

JIRA issue is created: https://issues.apache.org/jira/browse/MXNET-138

Thanks a lot, @TaoLv !


Setup travis so that metalsmith can be automatically run.

It would probably be a good idea to setup travis so metalsmith is automatically run whenever a commit is made to the site branch. As devs, we all know we are lazy.

Eh I think that's going a little overboard. The site is simple enough where we can check to see if a PR or commit will break it or not

Really? It's not very hard to do and would allow it to be automatic. No one would have to remember to run it since it seems to be forgotten all the time.

I added the config I was working on at least. It's not entirely finished as we need a way to allow travis to push to github. Normally I would do this with an ssh key, but that only works with paid travis.

To do this will soon require setting up travis on each repository to execute a curl call to travis' api to trigger a build. This will be extremely important as we won't be maintaining the docs and screenshots here anymore.

Closing due to inactivity.


Instead of throwing error, external links should be opened on same window

We are currently throwing error in alert form when an external link is clicked. Instead of this we can make this process smoother by sending that URL to providers module which will eventually load the require link on the H2.

I'll take care of this.

Sure!

Hello again, need some clarification. The error is no longer being thrown but load any external link means being able to navigate between any links inside H2?

load any external link means being able to navigate to any link inside H2?

Yes, when you click any link that opens a new window, that must be prevented and that is already done but instead of showing an alert, we should open that on the same window. This can be done by passing the new url to providers module call as being done when ctrl/cmd+shift+v is called.


ValueError during script execution with conflicting generation settings

Hello,
When I execute the command bash eval.sh Salesforce/codegen-2B-multi codegen2b-cbs base cbs, I encounter the following error:

ValueError: one of constraints, force_words_ids is not None, triggering constrained beam search. However, do_sample is set to True, which is incompatible with this generation mode. Set constraints and force_words_ids to None or unset do_sample to continue.

Here is the related code:
# Running generation
echo "Running generation using $DECODING decoding."
COMMAND="python generate.py --model_type lm --model_dir $MODEL_DIR --output_name $OUTPUT_NAME --eval_type $EVAL_TYPE"
case "$DECODING" in
    nucleus)
        COMMAND+=" --do_sample --num_gen 10"
        ;;
    beam)
        COMMAND+=" --do_sample --num_beams 25 --num_gen 10"
        ;;
    cbs)
        COMMAND+=" --do_sample --num_beams 25 --num_gen 10 --use_pos_constraints --use_neg_constraints"
        ;;
    *)
        echo "Invalid DECODING method specified."
        continue
        ;;
esac

Should constraints and force_words_ids be adjusted, or should do_sample be disabled? Any guidance or workaround would be greatly appreciated.
Thank you :)

Thank you for your interest in our work! I implement constrained beam sampling (CBS) via customizing the Huggingface transformers. I haven't uploaded my customized version of transformers to this repo, so you will encounter problems while running CBS. You may either wait for my updates or email me (see the website for my email) for my uncleaned, customized version of transformers and install it from the source. Sorry for the inconvenience! By the way, I have begun to migrate this repo from my account to an official one, https://github.com/CodeGuardPlus/CodeGuardPlus. All new updates will be first made in the official repo.

Thank you for your reply. I will keep an eye on your official project repository and look forward to your updates. It looks like a very good project ：）


rewrite zhihu link in answer/article

for example, https://www.fxzhihu.com/question/610789734/answer/3111205257 , at the bottom, another zhihu link there.

PR welcome


toolbox enter is broken on containers created with a colon

At this point I'm just going to recreate it, but still filing here because it's still a bug.
Basically I just run toolbox -v enter and, voila:
toolbox: resolved absolute path for /usr/bin/toolbox to /usr/bin/toolbox
toolbox: TOOLBOX_PATH is /usr/bin/toolbox
toolbox: checking if 'podman system migrate' exists
toolbox: migration not needed: 1.3.1 is unchanged
toolbox: Fedora generational core is f30
toolbox: base image is fedora-toolbox:30
toolbox: container is fedora-toolbox-30
toolbox: checking if container fedora-toolbox-30 exists
toolbox: container fedora-toolbox-30 not found
toolbox: container fedora-toolbox-ryan:30 found
toolbox: trying to start container fedora-toolbox-ryan:30
toolbox: looking for /etc/profile.d/toolbox.sh in container fedora-toolbox-ryan:30
Error: exit status 1
toolbox: copying /etc/profile.d/toolbox.sh to container fedora-toolbox-ryan:30
Error: invalid arguments /etc/profile.d/toolbox.sh, fedora-toolbox-ryan:30:/etc/profile.d you must use just one container
toolbox: unable to copy /etc/profile.d/toolbox.sh to container fedora-toolbox-ryan:30

@refi64 did re-create work out for you? didnt solve the issue for me.

@vinzent For me it creating a new one indeed fixed the problem.

Hit this today with toolbox 0.10 and podman 1.4.0
$ toolbox list

$ toolbox -v create
toolbox: resolved absolute path for /usr/bin/toolbox to /usr/bin/toolbox
toolbox: TOOLBOX_PATH is /usr/bin/toolbox
toolbox: checking if 'podman system migrate' exists
toolbox: migration not needed: 1.4.0 is unchanged
toolbox: Fedora generational core is f30
toolbox: base image is fedora-toolbox:30
toolbox: container is fedora-toolbox-30
toolbox: checking value /var/run/.heim_org.h5l.kcm-socket (Stream) of property Listen in sssd-kcm.socket
toolbox: parsing value /var/run/.heim_org.h5l.kcm-socket (Stream) of property Listen in sssd-kcm.socket
toolbox: checking if 'podman create' supports --dns=none and --no-hosts
toolbox: 'podman create' supports --dns=none and --no-hosts
toolbox: looking for image localhost/fedora-toolbox:30
toolbox: looking for image registry.fedoraproject.org/f30/fedora-toolbox:30
Image required to create toolbox container.
Download registry.fedoraproject.org/f30/fedora-toolbox:30 (500MB)? [y/N]: y
toolbox: pulling image registry.fedoraproject.org/f30/fedora-toolbox:30
Trying to pull registry.fedoraproject.org/f30/fedora-toolbox:30...Getting image source signatures
Copying blob 4c4fc0337a75 done
Copying blob eb96ef222807 done
Copying config 42cdab313e done
Writing manifest to image destination
Storing signatures
toolbox: base image fedora-toolbox:30 resolved to registry.fedoraproject.org/f30/fedora-toolbox:30
toolbox: checking if container fedora-toolbox-30 already exists
toolbox: trying to create container fedora-toolbox-30
Created container: fedora-toolbox-30
Enter with: toolbox enter

$ toolbox -v enter
toolbox: resolved absolute path for /usr/bin/toolbox to /usr/bin/toolbox
toolbox: TOOLBOX_PATH is /usr/bin/toolbox
toolbox: checking if 'podman system migrate' exists
toolbox: migration not needed: 1.4.0 is unchanged
toolbox: Fedora generational core is f30
toolbox: base image is fedora-toolbox:30
toolbox: container is fedora-toolbox-30
toolbox: checking if container fedora-toolbox-30 exists
toolbox: trying to start container fedora-toolbox-30
toolbox: looking for /etc/profile.d/toolbox.sh in container fedora-toolbox-30
Error: unable to find user miabbott: no matching entries in passwd file
toolbox: copying /etc/profile.d/toolbox.sh to container fedora-toolbox-30
Error: error copying "/etc/profile.d/toolbox.sh" to "/var/home/miabbott/.local/share/containers/storage/overlay/1bc532e4d664fe242dc96aeebb585f24355b5faab77839aaf6fed0dde543398f/merged/etc/profile.d/toolbox.sh/toolbox.sh": mkdir /var/home/miabbott/.local/share/containers/storage/overlay/1bc532e4d664fe242dc96aeebb585f24355b5faab77839aaf6fed0dde543398f/merged/etc/profile.d/toolbox.sh: not a directory
toolbox: unable to copy /etc/profile.d/toolbox.sh to container fedora-toolbox-30

Creating new containers doesn't seem to help

Container names with colons in them are not really supported. The OCI specification disallows colons, but that wasn't enforced by Podman for a while, and that's why Toolbox ended up using them. See #106
We can paper over this for some more time for the sake of backwards compatibility, but I think users would at some point have to re-create their toolbox containers. OCI containers, which is what toolbox containers are, are quite immutable once created. So as they grow older they tend to lose niceties introduced in newer versions of Toolbox.
I think it's time to stick a notice egging users to move away.
It makes me sad to break backwards compatibility, but for a project that's less than a year old, I think we've done reasonably well, and given how new rootless Podman itself is, I think it's fine to have a soft break like this.

@miabbott yours is a different bug, which I managed to predictably reproduce today.
The key lines are:
toolbox: looking for /etc/profile.d/toolbox.sh in container fedora-toolbox-30
Error: unable to find user miabbott: no matching entries in passwd file

That's caused by a podman exec --user "$USER" ... sh -c 'mount | grep ...' invocation failing that's supposed to check if /etc/profile.d/toolbox.sh has already been bind mounted into the container. There's something funny going on in Podman, that's not related to having colons in container names. :)
Do you mind opening a separate issue?

Could some sort of migrate command that just exports and re-imports it with new options be possible?

i'm having the same issue as @miabbott with podman 1.4.0. first toolbox enter fails with unable to find user... and error copying.... running enter a second time works. if @miabbott does not mind, i'm going to create a new issue for that.

Do you mind opening a separate issue?

https://github.com/debarshiray/toolbox/issues/196

https://github.com/containers/toolbox/pull/336 added a deprecation notice for old Toolbox containers. There's no migrate command, yet, but it's still a somewhat passable excuse to close this issue about invalidly named old Toolbox containers. :)


phantomjs stack property is unconfigurable

That's what I was afraid of...

I want to support that environment if possible. I'll think about this later. Until then it won't be supported.

Since we are going to use some kind of wrapper like NativeError, this might be saveable.


Optimize clone proxy bytecode

Optimized the creation and runtime bytecode of the clone proxy
Use foundry.toml config

@wighawag Can you please merge it into master? Thanks


Clean up tests using DynamicData

https://learn.microsoft.com/en-us/visualstudio/test/how-to-create-a-data-driven-unit-test?view=vs-2022
Tests could be simplified by consolidating the many copies of the test data rows, also simplifying adding new tests for new formats.  See https://learn.microsoft.com/en-us/visualstudio/test/how-to-create-a-data-driven-unit-test?view=vs-2022#member-data-driven-test.

Partially implemented in #114 for the expected num files tests. The remainder of the tests don't generally share exactly the same arguments so there is more limited room to use dynamic data other than in the CLI tests for expected num files.


Image parameters maintained upon changing dataset

Hi,
When loading an h5 file with many datasets, when inspecting a 2D slice and then changing to a another dataset to compare, if the datasets are the same dimension, it would be useful if the image or stackview maintain the chosen slice.
Thanks

PR #2701 provides part of it (i.e., it works for all views but the StackView which needs specific handling)

Any news on this? It seems that PR #2701 was merged, but this was not resolved.

For image stacks, you can use the "Image" tab which keeps the selected slice when switching datasets.
The "Image stack" tab which is also available does not supports this.
Unless I missed something, the "Image stack" tab provides the same features as the "Image" one, so we'd better remove it (2 tabs providing the same feature is 1 too much).

I agree that the redundant tab should be removed as it can be confusing.
On the other hand, I have noticed that for 3D volumes, the labels of the axes differ a bit between the two tabs. In the image tab you have {"", "x", "y"} while in the stack tab {"depth", "x", "y"}. The empty label in the image tab can be confusing as well. So, before you do away with the stack tab, please give the dimension a label different from "". May I suggest "z"? :)


Kong no longer uses ssl certs signed by the generated EdgeX TrustCA

The edgexproxy binary no longer configures Kong to use SSL certificates that were generated by the pkisetup binary from security-secret-store from this change: https://github.com/edgexfoundry/security-api-gateway/commit/3f9f9deca250f68b56e8c8e2c54d54048e1c024a#diff-711007c703bd39258a3323751c269e25R51
This means that when you deploy EdgeX using the security services, the SSL certificate presented by kong isn't signed by the Trust CA as it should be (and as it was with California).

@tingyuz this is the issue I spoke about over Rocket.Chat and should be considered a blocker for Delhi.

we were planning to switch the cert from default to kong specific (created by vault) and the related code was updated as a result. I will have a PR to restore the logic back same as California.

This has been fixed for Delhi with #31, now just needs to be forward-ported to master for Edinburgh


How to specify DNS validation script parameters (and values) on the command-line?

Can someone please provide an example command-line usage for the EasyDNS validation plugin? How are the token and key values that are obtained from EasyDNS to be specified on the command line? Let's assume that my key is "api123x4567y89z10.12345678" and my token is "u123x4567y89z10.12345678".
wacs --test --verbose --accepttos --emailaddress<EMAIL_ADDRESS>--source manual --friendlyname "<My Friendly Name>" --commonname "<hostname.mydomain.com>" --host "<san.mydomain.com>" --store pemfiles --pemfilespath "<C:\Temp\MyPEMfiles>" --validationmode dns-01 --validation script --dnsscript "C:\ProgramData\chocolatey\lib\win-acme\tools\Scripts\EasyDNS.ps1"
I have tried using --EDKey api123x4567y89z10.12345678 and --EDToken u123x4567y89z10.12345678, and I have tried using --eab-key and --eab-key-identifier but neither have worked.

Ok - I've moved forward a little bit by adding --dnscreatescriptarguments CreateArgs --dnsdeletescriptarguments DeleteArgs which I picked up from https://github.com/win-acme/win-acme/issues/2043, but am stuck again. Where/How do I define CreateArgs and DeleteArgs?

Those are the arguments I use in my for my script as an example. Don't use EasyDNS though.
--dnsCreateScriptArguments "create {Identifier} {RecordName} {ZoneName} {NodeName} '{Token}'"
--dnsDeleteScriptArguments "delete {Identifier} {RecordName} {ZoneName} {NodeName} '{Token}'"
check out the help here for more informaton: https://www.win-acme.com/reference/plugins/validation/dns/script
CreateArgs DeleteArgs you define them yourself. in your command line the words CreateArgs and DeleteArgs are just passed as is to your powershell script.

When I use the EasyDNS script through the step-by-step process the script parameter input is setup like this:
create {RecordName} {Token} u123x4567y89z10.12345678 api123x4567y89z10.12345678
delete {RecordName} {Token} u123x4567y89z10.12345678 api123x4567y89z10.12345678
Using @CastaS comments above I would add your EasyDNS info after {Token} in a similar format as I have above.


Source Control selector interferes with Git provider options

The ellipsis that appears on the SOURCE CONTROL: GIT line is always visible and appears just above the ellipsis that appears when hovered over on the header immediately below. This is confusing and leads to misclicking when attempting to interact with the git options 'commit, sync, more'. It seems to me that it's much less common for someone to install multiple SCM providers on a regular basis than to work with the git options, so the Source Control ellipsis should be removed from the UI here and placed somewhere less common.

VSCode Version: 1.23.1
OS Version: OSX 10.12.6

Steps to Reproduce:

Open a project.
Go to the Source Control tab.
Hover mouse over PROJECT NAME GIT. Notice two ellipsis next to each other, as in the image above.
Accidentally click on the wrong one and have to click away before re-accessing the menu.

Does this issue occur when all extensions are disabled?: Yes

Configurable option to remove that bar, could be solution.

Confirm, it is solved at latest VSCode version. Both buttons now are together.

👍


Run CI tests on bash to exit fast on error on Windows

Looks like windows is the odd-one-out again. https://github.com/actions/runner-images/issues/6668.
Been sitting on this for a while now so they would hopefully fix it, but it looks like its intended behavior.

Looks like windows is the odd-one-out again.

Well yeah it's documented behaviour that github actions default to different shells between windows and linux/macos when you don't explicitly specify it

Yeah, but the docs state that windows should default to pwsh, which should exit quick on error:

But that isnt the case: https://github.com/hikari-py/hikari/actions/runs/3818983261


CORS not triggered when ports differ

This line causes an issue in development when both the API and application run on the same host:
https://github.com/nelmio/NelmioCorsBundle/blob/master/EventListener/CorsListener.php#L68
The application is running on port 80, but the API is on port 8081/8080 depending on if it is requested through varnish or not.
This is console output from the app performing the ajax request:
Access to XMLHttpRequest at 'http://localhost:8081/' from origin 'http://localhost' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. so the header is still required.
Any thoughts on if I should be configuring something differently or perhaps a port check is necessary. The thing with the port check is that we could be requesting the application via a caching layer on another port (in my case 8081).
@dunglas will be familiar with this setup because of API Platform - sorry if I'm being ignorant and I'm missing something because it's late.
Thanks for your time.

I'm missing something to do with the ports. Probably related to HEADER_X_FORWARDED_PORT. Sorry for the issue.


[bug]: Multiple file uploads seem to trigger twice

Provide environment information
System:
    OS: Windows 11 10.0.22631
    CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900K
    Memory: 2.90 GB / 31.71 GB
  Binaries:
    Node: 20.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.6.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.8.0 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Chrome: 128.0.6613.138
    Edge: Chromium (127.0.2651.74)
    Internet Explorer: 11.0.22621.3527
  npmPackages:
    @uploadthing/react: ^7.0.2 => 7.0.2
    typescript: ^5.1.6 => 5.6.2
    uploadthing: ^7.0.2 => 7.0.2

Describe the bug
I followed your remix guide and added a multiple file dropzone
https://github.com/user-attachments/assets/c6cdf72b-9763-41a7-be9a-20bee2032876
Link to reproduction
https://stackblitz.com/~/github.com/AlemTuzlak/uploadthing-remix
To reproduce
click on the text of the dropzone and try to upload multiple files
add your key in the .env first though
Additional information
No response
👨👧👦 Contributing

[X] 🙋♂ Yes, I'd be down to file a PR fixing this bug!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @markflorkowski event.stopPropagation() bug that you were fighting with in #886

I hadn't seen it in the react package, but yeah this sounds like the same issue

I added stopPropagation in the onDropCb and it seems to fix it the first time then it breaks the 2nd time you try


EchoService.class will lose if the 'types' not null

What is the purpose of the change
修正 2.6.x 版本中， AbstractProxyFactory 类的 getProxy(Invoker invoker, boolean generic) 函数的一个小问题
Brief changelog
按照既定的逻辑，interfaces 数组的前两个位置应该放的是接口类和 EchoService 类，也就是说 type 应该从第三个位置即 interfaces[2] 开始放，但是此处是从 interfaces[1] 开始放的。如果 types 不为 null，EchoService.class 将会被意外覆盖。
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #5860 into 2.6.x will decrease coverage by 0.05%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##              2.6.x    #5860      +/-   ##
============================================
- Coverage     47.46%   47.41%   -0.06%
+ Complexity     4608     4430     -178
============================================
  Files           577      566      -11
  Lines         26509    25214    -1295
  Branches       4691     4463     -228
============================================
- Hits          12582    11954     -628
+ Misses        12009    11418     -591
+ Partials       1918     1842      -76

Impacted Files
Coverage Δ
Complexity Δ

.../alibaba/dubbo/rpc/proxy/AbstractProxyFactory.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...onfig/spring/extension/SpringExtensionFactory.java
75.67% <0%> (-8.11%)
9% <0%> (ø)

...a/dubbo/remoting/transport/netty/NettyChannel.java
61.25% <0%> (-5%)
20% <0%> (-1%)

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
37.5% <0%> (-4.17%)
3% <0%> (ø)

...ba/dubbo/remoting/transport/netty/NettyServer.java
67.85% <0%> (-3.58%)
8% <0%> (-1%)

.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java
54.54% <0%> (-2.03%)
13% <0%> (ø)

.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
87.85% <0%> (-1.87%)
15% <0%> (ø)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
77.2% <0%> (-1.48%)
29% <0%> (ø)

...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java
60.08% <0%> (-0.88%)
32% <0%> (-1%)

.../java/com/alibaba/dubbo/common/json/JSONArray.java

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bada690...3f6ae5b. Read the comment docs.


Added support for creating multi-resolution stacks with upload_image.py

What
Create and upload multi-resolution stacks with upload_image.py
TODO:

[ ] pngcrush stuff?
[ ] docs
[ ] test with jpg as well

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[ ] I've included a screenshot or gif (if applicable)

PR Build Summary: https://build.rerun.io/pr/2411

Docs preview: https://rerun.io/preview/e22814e/docs
Examples preview: https://rerun.io/preview/e22814e/examples

I definitely thing pngcrush is worth it. On the highest setting it can sometime half the png size

I definitely thing pngcrush or similar is worth it. On the highest setting it can sometime half the png size

Yes, some cursory testing I just did showed 2.8MB -> 1.9MB with default setting, 1.8MB with brute force (2.5min though!). There doesn't seem to be a nice python package, so I'll have to get the binary installed via the setup.sh scripts and call into it from upload_image.py (unless someone has a better idea).


not working

When I open any world with TerraFirma it crashes the moment it starts trying to load the npc's, I have tried reinstalling terrafirma and tried reinstalling terraria but it still doesn't work.

It's probably not crashing due to the NPCs but due to something it does right afterwards, which is load textures.  Try turning off textures before you load a world and see if it still crashes.  If that fixes it, I bet you need to fix your texture path, which you can do in the settings window.

hasn't fixed it

@Mark4666 are you using a small world it seems to me they don't work with small worlds

Try new version.


Folding support in Markdown

There seems to be no folding support markdown mode. This should be relatively trivial to add, as the syntax for the headings is already there.
Current behavior:

Open a Markdown document with several header levels (# h1 section foo, ## h2 section bar, etc.)
Try to code fold a section (e.g. h3 level)
Nothing happens 😞

Expected behavior:

Open a Markdown document with several header levels (#, ##, etc.)
Try to code fold
Block gets folded 🤗 (eg. all third level headings get folded to ### h3 section baz {…})

While it seems that way, currently folding does need a hierarchical concept which the structure of markdown doesn't give. E.g. while headlines are recognized, they don't have content or demark a region per se.
That being said a folding mode for non-hierarchical syntax would be nice and interesting. Also the mode could be rewritten to create states for headings (however, due to the nature of markdown, e.g. the ability to use the non ### variant of headings just by underlining, and mix and match, doing this correctly would be slightly challenging)

OK, that explains it. As I mostly write longer prose in markdown, it would be very welcomed enhancement. As a new user it took me some time to figure out that folding with markdown just does not work. Because the markdown mode is prominently featured in the screenshot on the landing page and the app store, I got the impression that everything was supposed to work.  At first I thought I was simply inept to use the functionality properly.
I am currently using the vim with vim-markdown-folding to get folding support. Having the collab features of SubEthaEdit together with this would be great. If I find some time, I will look into the code to and try hack something up. Doing it correctly will probably exceed my abilities. There is also the standardized parser from Commonmark, but that would probably be overkill in this case.

@tolmasky wondering if you could have a look to do this easily?

I can definitely give it a shot. Funny enough, I ran into the non-hierarchical data situation in another project I was doing with Markdown.


Allow finer grained positioning

I would love to be able to position tiles on half coordinate points, so that f.e. in a case like this I can vertically center the right arrow.

Your link appears to be broken. (Note that you need to click "Save", or use the keyboard shortcut, to update the URL: it doesn't update automatically.)

D'oh, I thought I had checked that! This one then: https://varkor.github.io/tangle/?t=W1tbXV0sW1tbMSxbMCwxLDAsMV1dLFsxLFswLDAsMSwxXV0sWzAsW11dXSxbWzEsWzAsMSwwLDFdXSxbMSxbMSwxLDAsMV1dLFsxLFswLDEsMCwxXV1dXSxbWzAsMS41LDEsWyIiLDAsMV1dXV0=&c=F5A3A3,F5F5A3,A3CCF5

Ah, I see what you mean. It was actually a deliberate decision not to permit positioning like that, for several reasons. The first is that you eventually end up needing arbitrary positioning (e.g. consider a binary tree of arbitrary depth, where you need half-tile positioning at the first level, quarter-tile positioning at the second level, and so on). The second is that it is simpler to prove a formal correspondence between string diagrams and pasting diagrams when there is a fixed grid. The third is simply for aesthetic reasons (though I appreciate this one is subjective).
The intended approach to diagrams like the one you give is to make the cell wider, like this. I could potentially make it possible to scale a diagram in one direction to make it appear shorter, but I personally think the diagram looks good even with a height of 3 rather than 2.

I think the case of having a binary-like structure is not so common, but having an even number of arrows on one side and an odd number of arrows on the other side is very common. I could double the spacing of everything like f.e. this and that looks pretty good until you start adding annotations which then look tiny.

I think the case of having a binary-like structure is not so common, but having an even number of arrows on one side and an odd number of arrows on the other side is very common.

I do agree this is not uncommon. I'm not sure what the ideal solution is yet – at the moment, I have simply been leaving empty spaces where appropriate to centre both sides (as in my earlier example), which works well enough for my purposes. When I have some time, I will think about whether there are more elegant solutions.


DataSpreadsheet refactor: Refactor handlers into separate utilities or hooks

@amal-k-joy, @matthewgallo tells me you completed this work? Can you confirm?

@amal-k-joy, @matthewgallo tells me you completed this work? Can you confirm?

@sstrubberg , This is completed and the code is merged.


Some fixes to run arg_scanner on diaspora specs.

Review: https://upsource.jetbrains.com/RUBI/review/RUBI-CR-33

ide-plugin/src/test/java/CallStatCompletionTest.java:100

concatenating something and absolute path? How should this work? Could you please provide an example?

Ofc, it cannot, ty :-)


Crash on Preview

If I open a preview for a file, close the preview windows, and then click the preview button again, Flump crashes.

I've seen this as well - it's actually the Flash runtime crashing, as opposed to a logic error in the Flump exporter itself. That said, I'm not currently able to reproduce it. Are you on a Mac or Windows? What version of AIR do you have installed?

I'm on OSX 10.9.5, Air Version <IP_ADDRESS>
On Thu, Mar 12, 2015 at 3:08 PM, Tim Conkling<EMAIL_ADDRESS>wrote:

I've seen this as well - it's actually the Flash runtime crashing, as
opposed to a logic error in the Flump exporter itself. That said, I'm not
currently able to reproduce it. Are you on a Mac or Windows? What version
of AIR do you have installed?
—
Reply to this email directly or view it on GitHub
https://github.com/threerings/flump/issues/139#issuecomment-78574054.

I wonder if it's based on the number of items, or size of textures, in your project? That's basically the setup I have, but I'm not seeing these crashes for the last number of AIR versions

I think it has to do with the windows closing, because if I open a new
source directory and preview a new FLA file, it doesn't crash. I'd send the
source files that are causing the issue, but I don't have the rights to do
that.
On Thu, Mar 12, 2015 at 4:32 PM, Tim Conkling<EMAIL_ADDRESS>wrote:

I wonder if it's based on the number of items, or size of textures, in
your project? That's basically the setup I have, but I'm not seeing these
crashes for the last number of AIR versions
—
Reply to this email directly or view it on GitHub
https://github.com/threerings/flump/issues/139#issuecomment-78603584.

It sounds like it may have to do with how we're disposing of a stage3D context or something. Can you run flump in the debugger to see which call is actually triggering the crash?


Mesos HA with improved zookeeper

LGTM

OK, LGTM

https://github.com/rancher/rancher/issues/4850


app is not starting

the application is not running despite installing all dependencies it keep displaying blanks

atleast you have installed all the dependencies. In my case bunch of dependencies are getting failed to install.
tried in powershell and WSL(ubuntu)
powershell

WSL (Ubuntu)

Do you have gcc build tools installed on your system?

Nope, gcc builds are not present in both environment

I'm facing an issue with installing too -

cytoolz/functoolz.pxd:18:23: '__module__' redeclared

I managed to fix this by bumping the cytoolz version to 0.12.3 in requirements.txt, per the recommendations here


.rvmrc could not load

Issue occurs when you go into folder that contains .rvmrc file (rvm script file). It should load the script file first but it don't

This issue is very stale, so I close it. Thanks for contributing and posting!


Add TikTok social Icon @material-ui/icons/TikTok

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
why is this not done already?
Examples 🌈
No response
Motivation 🔦
No response

Our icon set is based on official Material Design icons from Google. Please create or upvote an issue on https://github.com/google/material-design-icons if you'd like to have additional icons.


ci: adds repo name to workflows for observability

Adds unique naming to workflows for external observability tool.

Not a big issue, but we stylize the name of the tool all-lower-case one-word: "ngsderive". Instead of "NGS Derive".

Sounds good. Have changed the PR.


Make Open Source

Several things have to be done to make this project open source:

[x] Disclaim a license.
[x] Improve README to explain how the application works and how to get started with development.
[x] ~Create CONTRIBUTING file which explains how to contribute to the project.~

References:

https://choosealicense.com
https://opensource.guide

Published under the MIT license.


Implement FromAbbrevStr procedural derive macro?

Following on from https://github.com/mpiannucci/gribberish/issues/41#issuecomment-2386495107
Maybe one way to easily map from abbrev strings to a parameter enum variant is that I could try to implement a FromAbbrevStr procedural derive macro. This macro would implement the FromStr trait. And then I could add #[derive(FromAbbrevStr)] to every enum in gribberish::templates::product::parameters::*. Does that sounds like a good way to go?
For example, calling TemperatureProduct::from_str("TMP") would return TemperatureProduct::Temperature.

An attempt to implement a FromAbbrevStr proc derive macro is now in PR #62 :slightly_smiling_face:


How to set env for Jaeger

I want to add base path for jaeger query (https://github.com/jaegertracing/jaeger-ui/issues/258) so that the yaml file should be:
apiVersion: io.jaegertracing/v1alpha1
kind: Jaeger
metadata:
  name: istio-tracing
spec:
  strategy: production
  env:
    - name: QUERY_BASE_PATH
      value: /jaeger
  storage:
    type: elasticsearch
    options:
      es:
        server-urls: http://elasticsearch:9200

Right now, the jaeger operator cannot support set env in yaml file.

We need this enhancement to enable jaeger-operator can be used in the Istio helm chart - https://github.com/istio/istio/pull/9508

Rather than express as an environment variable, as discussed in #72 it would be good to have this defined as:
apiVersion: io.jaegertracing/v1alpha1
kind: Jaeger
metadata:
  name: typed-options
spec:
  strategy: production
  query:
    base-path: /jaeger

@objectiser it will increase the learning curve, because it is different from the original way. I do think we should provide a general way instead of adding one-by-one. What do you think?

@clyang82 I think both approaches have their pros and cons - however I prefer the typed approach as:

it means a CR would be rejected if it had incorrect content - whereas errors in free form options or env entries would not be detected until attempting to deploy the Jaeger components.
the operator should not be exposing (and passing through) all of the config complexities - it should provide the simplest possible configuration to the end user, and the operator handle the complexity.

@objectiser agree with your point - both approaches have their pros and cons. We need to consider the goal for the operator, it should not expose all of the config complexities, it should be handled by operator and provide a easy to use way. in this way, it will be used by more and more people. But the operator cannot handle all of requirements, otherwise, the operator will be very heavy. The operator should keep flexible. the operator should not introduce new configs since there always has well-known configs. Thanks.

@jpkrohling what is your point? to provide env just like options or more specific pre-defined values? Thanks.

I discussed with @objectiser yesterday and we'll refrain from implementing #72 for now, until we have a better understanding of the pros/cons and requirements.
For this one, I think the best solution isn't via env var or typed value, but to use options as it's used for other components. The query.base-path option can be used instead of the env var QUERY_BASE_PATH, similar to what you did with the ES options:
apiVersion: io.jaegertracing/v1alpha1
kind: Jaeger
metadata:
  name: istio-tracing
spec:
  strategy: production
  query:
    options:
      query:
        base-path: /jaeger
  storage:
    type: elasticsearch
    options:
      es:
        server-urls: http://elasticsearch:9200

I'm closing this, as I think the solution from my previous comment should be sufficient. If this does not fix the problem for you, feel free to reopen this.

@jpkrohling Thanks for your solution. It can fix my problem.

guys, this is great and worked for me as well, thank you!
on a related topic, is there a way to modify the corresponding ingress object that gets created to include path: <base-path> as well?
We would like to expose it via ingress route /jaeger and currently we implemented the ingress object ourselves and set ingress to false inside the jaeger object
kind: ingress
...
spec:
  rules:
  - host: app.domain.co.uk
     http:
       paths:
       - backend:
            serviceName: jaeger-query
            servicePort: 16686
         path: /jaeger

@jungopro, setting the base path should have an effect in the ingress path as well:
https://github.com/jaegertracing/jaeger-operator/blob/01bb012c81244a273cc7b391084aac4be0e4ac6a/pkg/ingress/query_test.go#L47-L64
Are you seeing something different?

thanks @jpkrohling. I'm using the prod strategy, not the allInOne, but I do see the change reflected. I didn't notice that before, that is helpful
But, nothing is easy :-).
I'm getting 404 not found from the ingress-controller.
Is it possible that the controller didn't pickup the ingress rule?
Normally I would add annotations to the ingress rule for that to work:
nginx.ingress.kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: /<the-base-path>

I tried editing the ingress rule post-creation and add them manually but that didn't help either... I'm a bit lost to be honest. All I know is that with a stand-alone ingress rule it does work, I'm unsure if I'm missing something or simply utterly confused :-)
Thanks

Could you open a new issue, ideally reproducible with minikube? I can take a look once we clear some other issues.

will do. thanks.

@jpkrohling if use the following strategy with minikube, the base path is not reflected.
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger-tracing
spec:
  strategy: allInOne
  query:
    options:
      query:
        base-path: /jaeger

output of kubectl get ingress
NAME                   HOSTS   ADDRESS          PORTS   AGE
jaeger-tracing-query   *       <IP_ADDRESS>   80      2m54s

output of kubectl describe ingress jaeger-tracing-query
Name:             jaeger-tracing-query
Namespace:        default
Address:          <IP_ADDRESS>
Default backend:  jaeger-tracing-query:16686 (<IP_ADDRESS>:16686)
Rules:
  Host  Path  Backends
  ----  ----  --------
  *     *     jaeger-tracing-query:16686 (<IP_ADDRESS>:16686)
Annotations:
Events:
  Type    Reason  Age    From                      Message
  ----    ------  ----   ----                      -------
  Normal  CREATE  2m59s  nginx-ingress-controller  Ingress default/jaeger-tracing-query
  Normal  UPDATE  2m41s  nginx-ingress-controller  Ingress default/jaeger-tracing-query

It looks like the base path is not set at all. (ideally, correct me if i am wrong but Path should be '/jaeger' instead of *)

@mohit-chawla could you try this instead:
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger-tracing
spec:
  strategy: allInOne
  allInOne:
    options:
      query:
        base-path: /jaeger

@jpkrohling , this worked, thanks.


Object.create incorrectly used when transpiling to ES3

This code
var whatever = Object.create({a: 123});
whatever.a = 42;
alert(whatever);

gets compiled to
var a = Object.create({a:123});
a.a = 42;
alert(a);

Object.create is not part of ES3.

Thanks for the report.  Support for ES3 is extremely limited and there is no attempt to translate or polyfill ES5 features when producing ES3.
What platform are you targeting that you feel ES3 is useful?  It is likely that we will drop targetting ES3 in the coming months.

Closing


Added section for top contributors

Using contrib.rocks
For #127

@othneildrew

Thanks for the contribution!

tysm; it's my first PR to get merged :)


Sort by default checked items asc

Hi, anyone can help me with?
I need to set order by default of items checked
Expected Behavior
On load datatable order by checked asc
Current Behavior
When datatable is loaded it orders by default the items by index
Steps to Reproduce (for bugs)
https://codesandbox.io/s/001jq
Your Environment

Tech
Version

Material-UI
3.0.1

MUI-datatables
2.14.0

React
16.13.1

browser
chrome

etc

You'll want to look at the customSort option: https://github.com/gregnb/mui-datatables/blob/master/examples/customize-sorting/index.js
You'll need to use that in combination with the rowsSelected data from the table, which you can get from the onRowSelectionChange callback.
To make this easier, I could pass some table meta info (like the rowsSelected data) to the customSort function. But for the moment you'd have to get it from the onRowSelectionChange callback.

Thanks @patorjk that seems to be the way, but I cannot get how to trigger the customSort option, could you please take a look at this: https://codesandbox.io/s/001jq
thanks in advance

I think I got it working: https://codesandbox.io/s/muidatatables-custom-toolbar-r49m0?file=/index.js

you really are awesome! that's what I needed to order it correctly.
But it still seems the method "custom Sort" is never triggered, could you please give me a clue about calling manually on table initialization?

If you look at my codesandbox you'll see that customSort is being triggered. It's not firing in your sandbox because you set sort=false in the options.

I think I got it working: https://codesandbox.io/s/muidatatables-custom-toolbar-r49m0?file=/index.js

patorjk, I've tried this but it is not ordering rows by selected (asc/desc), and the "sort=true" option is setted.
Maybe other option setted is "blocking" the customSort ?
Could you please take a second view on your sandbox?

Are you saying the codesandbox I provided isn't working for you? Do the rows not sort correctly for you? Below is a gif capture of me using the codesandbox:

It works but not as expected. The behaviour I want is to init the table ordered by selected=ASC. On first render

You can use the sortOrder option to initially sort the table by a certain column.
Updated example: https://codesandbox.io/s/muidatatables-custom-toolbar-r49m0?file=/index.js

thanks a lot!! that really works !!


mobile: Receiving phone doesn't stop music

Not sure this is Ebiten's responsibility though... :-/

I guess this is an Activity's responsibility:
https://developer.android.com/guide/components/activities/activity-lifecycle

When the activity enters the Resumed state, it comes to the foreground, and then the system invokes the onResume() callback. This is the state in which the app interacts with the user. The app stays in this state until something happens to take focus away from the app. Such an event might be, for instance, receiving a phone call, the user’s navigating to another activity, or the device screen’s turning off.
When an interruptive event occurs, the activity enters the Paused state, and the system invokes the onPause() callback.

onPause/onResume should be handled.
CC @wasedaigo

I tested phone calls and found the app suspended playing music during the phone call without any fix. Thus, there is nothing to do here? Does this depend on devices?

I guess we have already fixed. A view generated by ebitenmobile command has functions that should be called on Activity's onPause/onResume.


application calltree not display anything about sql and database.

Prerequisites
Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

[ ] I have checked the FAQ, and issues and found no answer.

What version of pinpoint are you using?
master/v1.7.3/v1.7.3 etc.
Describe your problem**
only one application not display anything about sql and database.
What have you done?
Steps you have taken to trigger the problem, for example:

try to truncate_preserve the hbase and rebuild the application data,

calltree only display
queryForObject(String statementName, Object parameterObject)
prepareStatement(String String)  but not have sql info

Hi @a52yth
Does it show SQL-ID not found sqlId: xxx?
If you truncated metadata tables (such as SqlMetaData_Ver2), then this can happen.
Please check out http://naver.github.io/pinpoint/faq.html#hbase-is-taking-up-too-much-space-which-data-should-i-delete-first for more info.
Let me know if this isn't related to your issue.

Thank you for your attention.@Xylus
truncated hbase action after i cant't see sqlinfo .
right pic:http://i2.bvimg.com/685900/a8d8f5dd99beb98c.jpg
http://i2.bvimg.com/685900/a8d8f5dd99beb98c.jpg
wrong pic: http://i2.bvimg.com/685900/827ea9585cf2e614.jpg
http://i2.bvimg.com/685900/7624cd6bccfbf543.jpg
Thanks again！

@a52yth
Has anything else changed apart from truncating hbase? Such as upgrading pinpoint agent, changing oracle jdbc driver version etc.
I ask because the issue doesn't seem to be related to hbase truncate (though I could be wrong).


Refactor AnswerService

[x] 1. Compute the number of right/wrong answers and send them back.
[x] 2. Extract the bot-related logic into their own module and hook it up into the service somehow.
[x] 3. Refactor most methods in order to improve readability+maintainability (could also split some methods, etc. into another object/class.
[ ] 4. Replace custom Date logic with http://momentjs.com/ (sadly, the Meteor package is outdated…)

Done. Will open a separate issue for n°4.


IPv6 address

IPv6 addresses don't work.
2001:0db8:85a3:0000:0000:8a2e:0370:7334
2001:db8:85a3:0:0:8a2e:370:7334
2001:db8:85a3::8a2e:370:7334
::1
2001:0db8::0001
2001:db8::1
2001:db8:0:0:0:0:2:1
2001:db8::2:1

Examples are from wikipedia.

Added in version 1.1.


Release v0.55.0

has ibc-client-cw missed release on crates.io?
https://crates.io/crates/ibc-client-cw is still 0.54


Not enough detail for large data model feature

We need more detail here.

Model sizes can go larger than 10GB -> How much higher? Limitless?
A comparison with AAS model sizing would be helpful.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 246f0cce-9c53-3bea-15df-0fb7c8520f12
Version Independent ID: aefc566c-9abf-1e4f-6d38-18a1e192fa23
Content: Large models in Power BI Premium (preview) - Power BI
Content Source: powerbi-docs/admin/service-premium-large-models.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Hi @sqltj, thanks for your comments. I am forwarding them on the doc author for consideration.

With the release of Gen2, this is no longer relevant.


Docs: How about renaming MouseEvent with one that is compatible with built-in types

Page URL:
https://www.typescriptlang.org/docs/handbook/type-compatibility.html#function-parameter-bivariance
Issue:
In TypeScript playground, interface MouseEvent is a built-in type,
so the example code raises error (playground).
This is confusing for learners.

Recommended Fix:
MouseEvent should be renamed with another one, for example MyMouseEvent.

Browser:
All.

Thanks, I've prefixed it in the code samples in #1275


created a generator class for test data

The puzzle 102-c774c17d from #102 has to be resolved:
https://github.com/ammaratef45/Attendance/blob/fbdba811a613eddf24735e47ac232e93e71c179b/attendance/test/api_test.dart#L7-L7
The puzzle was created by Ammar Atef on 12-May-19.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@ammaratef45/z please, pay attention to this issue


Fix malformed test case

PermissionRequirementsTest.createObservation was constructing a function to run
the test case when it should directly run the test case.

Current dependencies on/for this PR:

main

PR #1591   👈

This stack of pull requests is managed by Graphite.


B-21410

Agility ticket
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the
Login as a

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against b10726dc8115a3dbca25cafa5134932f70d76987

Test coverage on server failed.
Last run: Mon 16 Dec 2024 06:21:53 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against c87a38c5981cd9d45da622dea5822107ca8b3cbb

Test coverage on server failed.
Last run: Mon 23 Dec 2024 08:52:52 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

Warnings

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against b15faccaa39f3ce6bd9b644aaeac655ae46f16fc


Parse errors in different files should not affect each other

If we see something like dep bar;, this should not stop parsing from continuing, and not type checking either.
If there were lexing errors in bar.sw, we should just throw away the entire file.

If there are lexing errors in bar.sw does the whole file need to be thrown away or can the compiler still return a best effort ParseProgram and TypedProgram's?

Great, that makes sense. Thanks for clarifying.


Fix Wails Pop Up Size

Context
The size of the wails pop up does not correspond to the design
https://www.figma.com/file/LSaOibVDFb1reF6FePVn5l/Massastation?type=design&node-id=562-9571&mode=design&t=4xNgArS0VLFYlrgi-4

How to
Change the wails - react front end code. It should be around 300px x 300px

old issue : https://github.com/massalabs/station/issues/919

@maxime-carabina  it seems it has been fixed, or that the bug was isolated on my screen, would you mind testing for me and show me the results ?

Yes 😉 ! It's fixed here : https://github.com/massalabs/station-massa-wallet/pull/464

Yes wink ! It's fixed here : #464

Nice i will close this issue :))

Thanks guys!! :)


Support search file by name in source control panel

Issue Type: Feature Request
In my source control panel  there is 1k+ changed files. It's hard for me to find a specific file to review.
I think it is better if VSCode supports to filter files by name.

Thank you for your powerful tool.
Luan
VS Code version: Code 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.15063

/duplicate #30199


make addon_before_class and addon_after_class effective

addon_before_class and addon_after_class don't take effect as per its document:
        addon_before_class
            Class used on the span when ``addon_before`` is used.

            One of the following values:

                * ``'input-group-text'``
                * ``None``

            Set to None to disable the span inside the addon. (for use with buttons)

            :default: ``input-group-text``

        addon_after_class
            Class used on the span when ``addon_after`` is used.

            One of the following values:

                * ``'input-group-text'``
                * ``None``

            Set to None to disable the span inside the addon. (for use with buttons)

            :default: ``input-group-text``

So this PR added code for it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 6 (83.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 96.902%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/django_bootstrap5/renderers.py
5
6
83.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
587

Relevant Lines:
601

💛  - Coveralls

Thanks! Could you also add a unit test for this change?

Thanks, we had 2 PR's for this one it seems. This was fixed in #361

Thanks, we had 2 PR's for this one it seems. This was fixed in #361

Good job, thanks~


Update partner package versions

cc @muratg \ @Eilon

@davidfowl - updated the missed Microsoft.CSharp package. The DiagnosticSources package is used in our tests which is where it's duplicated.
🆙 📅

is the build supposed to be red?

Yeah. It's not using the dotnet-core feed. which is where the packages are. I'm working on kicking off the Mirror build so we pull their packages.


Merge Statistics API into master from research-public.

This PR aims to cherry-pick necessary commit from research-public branch into master.

Thanks for the contribution


Embeddable discovery

Asciicinema is a great tool !
Any chance to implement some embed tags or metadata so that the player can be embeddable in slack, instead of jus a link ?
=> https://api.slack.com/robots

Yeah, that's neat idea. I plan to add discovery tags for oEmbed/Twitter Card/Open Graph.
This one belongs more to https://github.com/asciinema/asciinema.org/ repo so I'm closing this one.

@lucasmichot discovery has just been added: http://blog.asciinema.org/post/embedding/


fluxupgrade issue

I can't upgrade flux file from v2 to v3 by current fluxengine.
./fluxengine upgradefluxfile 01.flux
Warning: reading a deprecated flux file format; please upgrade it
Error: that flux file is version 2, but this client is for version 3
Flux file http://oldpc.su/0/01.rar
But old version make upgrade OK.
And please, please, PLEASE add 'fluxengine version' options for check version of fluxengine.

Wow --- version 2 flux files are ancient! I was hoping that nobody was using them any more. I'll try and fix the upgrader shortly.