Segmentation fault on aarch64

Alpine had to disable this library on aarch64 because of segfault.
http://git.alpinelinux.org/cgit/aports/commit/?id=aa080bf0e54b0974069abe9b8acb4151a3c72a80
cc @clandmeter

Error 139 means compiler crashed (probably with coredump).
You can repeat last command (gfortran) to no good under gdb, valgrind and whatever debugger you imagine.

Giving this the benefit of doubt - if a single line is missing from the log it could also mean that the automatic post-build test of sblat2 failed. In any case I guess much more context will be needed - what version of gcc, what kind of system was it run on (is it actual aarch64 hardware or just an emulator ?), what if any build options were set... I know nothing of alpine linux, but I trust a serious distribution will not blindly run "make" on random projects and drop any that  do not survive the process ?

I just started using alpine recently, so I'm not sure about everything.
For once, alpine uses musl instead of glibc.
I will cc @ncopa to help with better answers. Also @jirutka because he has packages that depend on openblas so he should be interested in helping.

what version of gcc

gcc version 6.2.0

is it actual aarch64 hardware or just an emulator

I think it's an R120-P30, but I'm not sure.

what if any build options were set

I think so.
http://git.alpinelinux.org/cgit/aports/tree/community/openblas/APKBUILD

I know nothing of alpine linux, but I trust a serious distribution will not blindly run "make" on random projects and drop any that do not survive the process

I agree.
This was a sad decision.

So from the APKBUILD it appears that the build is done with
make TARGET=ARMV8 DYNAMIC_ARCH=0 USE_OPENMP=0 NO_LAPACK=0 MAJOR_VERSION=3 NO_AFFINITY=1 (not sure if the reason for USE_OPENMP=0 is still valid - citing an old gcc bug report
that apparently has not been acted upon, whereas much discussion and patching went on in #294, seemingly resulting in fixed behaviour. There is unconfirmed #455 but the reporter stopped responding)
Primarily I think what is needed now is clarification if the segfault happened during the gfortran compile of test case zblat2 (in which case it would not be a flaw in OpenBLAS, but rather an internal compiler error for the GCC folks to look at, and alpine should consider using a different GCC release). This is what the part of the compile log in your original link is strongly suggesting.
Only if there was an inadvertent deletion of a line between the gfortran call and the "Program received signal SIGSEGV" line, the problem might possibly be with OpenBLAS  (or complex number support in musl)...

This issue happens when openblas with ILP64 is running test:
OPENBLAS_NUM_THREADS=1 OMP_NUM_THREADS=1 ./sblat1
This seems to be a regression in the latest version of openblas. I have reverted to previous version and it builds just fine.

Thanks for following up. If 0.2.18 works for you perhaps try undoing the changes to kernel/arm64/copy.S from 7878248 (part of PR924 by @ashwinyes, merged as 84952ee on July 14) - but this is just a really wild guess based on my limited understanding of what sblat1 tests.
Could you run gdb on the failing sblat1 to get an indication of where it crashes ?

that doesnt seem to fix it.
I tried gdb, but im probably missing debug symbols of some of the deps.
Maybe I can generate a trace later this week/nextweek.

No need for GDB yet
make --debug=j (assuming GNU make if that is available)
And tel which command crashes first.

kernel/arm64/copy.S  changes are done for target CORTEXA57.
The issue here seems to be seen when building for ARMV8 which still uses the generic C implementations.
@clandmeter I see that the compiler used is GCC 6.2.0 which is very recently released. Is it possible to try with an older version of GCC ?
I tried the OpenBLAS develop branch tip with GCC 4.8.4 and everything works fine.

@ashwinyes did you build it on native aarch64 hardware?
Our x86* builders build openblas just fine with gcc 6.2

make debug last 1k lines http://sprunge.us/fEfA
if you need the full log ill have to upload it somwhere because of filesize.

Please do a serialized build (i.e 1 compiler running at a time) only logging commands that make is running. It is necessary to drill down issue to either gfortran or openblas test failing.
$ make --debug=j MAKE_BB_JOBS=1
And find the +/- 100 lines from 'Error 139', it did not get in your output somehow.

http://sprunge.us/bAMg

@clandmeter Thanks for the logs.
I tried on native aarch64 hardware. I tried with GCC 6.2 and GCC 5.4 as well on Ubuntu 16.04. I couldn't reproduce the above issue.
You mentioned that "This issue happens when openblas with ILP64 is running test:" . I have limited understanding of ILP64 and I am not familiar with ILP64 for aarch64. Could you please let me know how you are enabling ILP64 for the aarch64 build??
Thanks

Update:
I missed the "INTERFACE64=1 SYMBOLSUFFIX=64_" options previously. With these options I am able to reproduce the issue with GCC 6.2 and GCC 5.4.
The build is failing at the blas tests. All blas tests are failing with the segfault. Let me go through the failure. I will  give an update on the issue.

Looks like OpenBLAS never supported ILP64 on Aarch64 (Not sure whether Aarch64 even supports ILP64). The tests are failing in OpenBLAS versions v0.2.18 and v0.2.19.
The reason that the build failure arises between v0.2.18 and v0.2.19 is because the build and run of tests is enabled in the Makefile by commit 3d50ccdc0de9b0756d4bdc63e196403332d68570 by @rndfax .
For now, the best thing to do would be to disable the build of OpenBLAS with ILP64 enabled in the Alpine Linux Build System.
Thanks

11.09.2016, 07:58, "Ashwin Sekhar T K"<EMAIL_ADDRESS> because the build and run of tests is enabled in the Makefile by commit 3d50ccd by @rndfax .

Seems to me that your commit also dropped an #ifndef TARGET condition from the Makefile which would have inhibited the tests in this specific case ? (And I guess ashwinyes did not mean this as criticism but as an explanation why the ILP64 incompatibility was not uncovered earlier - I guess if the tests crash, the associated library functions would not fare better in real life code ?)

@rndfax It was not meant as criticism but as an explanation for the issue :)
And your commit affect native builds also when TARGET is given explicitly. As in the current case, the tests starts running for native builds with TARGET=ARMV8. But i dont think any change is required in your commit.
@clandmeter. I think we can close this issue. GCC also says that only LP64 and ILP32 are supported in AArch64

please close, thx.


is anybody else forking this project and maintaining it?

I was thinking about it, i've almost finished my own C# application for this purpose and i just found this.

nice! tell me when it's available 😁


EB 4.5 breaks non-JavaScript flow

Clients without JavaScript (like https://github.com/OpenConext/OpenConext-engine-test-stand cannot continue past the WAYF).

It works for me in w3m and also for OpenConext-monitoring-tests. So I don't think it's broken for non-JS clients in general.


Add qcodes favicon for sphinx documentation

Add feature: qcodes favicon in sphinx documentation using sphinx-favicon extension.
Closes #3788.

Added zoomed in png file qcodes_favicon.png for the icon under _static dir.
Added sphinx-favicon extension to doc_requirements.txt.

bors merge


[tests-only] Bump commit id for API tests

Gets us:
https://github.com/owncloud/core/pull/38184 [tests-only] low level TUS tests for uploading chunks

@labkode @ishank011 there is no drone CI happening any more.
What happened?

Question about drone has been asked at https://discourse.drone.io/t/new-builds-not-appearing-on-drone/8479
Waiting for news...

@phil-davis is this still needed? In case, can you submit another PR to trigger the CI?

This is old - superseded by  #1372 which is already merged.


Make message_id nullable.

In some instances message_id is not provided, for example when subscription status is changed manually by the site owner in postmarkapp.com directly.

Thanks, sorry for my late response!


colormap not applied

Bug description & steps to reproduce
The colormap kwarg currently doesn't seem to be applied at all.
E.g. after some setup...
versioninfo()  # Julia Version 1.10.4
import Pkg; Pkg.activate(temp=true)
Pkg.add(["GLMakie", "AlgebraOfGraphics"])
using GLMakie, AlgebraOfGraphics
df = (x=rand(100), y=rand(100), z=rand(100))
plt = data(df) * mapping(:x, :y, color=:z)

...then choosing a different colormap with visual(..., colormap=:thermal) should change the colors.
plt * visual(Scatter) |> draw
# vs
plt * visual(Scatter, colormap=:thermal) |> draw

However, instead they produce the same picture (see below).
This also applies to other colormaps.
Note that with just Makie it works fine, i.e. the pictures are different:
scatter(df.x, df.y, color=df.z)
scatter(df.x, df.y, color=df.z, colormap=:thermal)

Images
Using AlgebraOfGraphics:
fig = Figure();
draw!(fig[1, 1], plt * visual(Scatter), axis=(; title="`colormap=:default`"));
draw!(fig[1, 2], plt * visual(Scatter, colormap=:thermal), axis=(; title="`colormap=:thermal`"));
save("aog.png", fig)

Using just Makie:
fig = Figure();
scatter(fig[1, 1], df.x, df.y, color=df.z, axis=(; title="`colormap=:default`"));
scatter(fig[1, 2], df.x, df.y, color=df.z, colormap=:thermal, axis=(; title="`colormap=:thermal`"));
save("makie.png", fig)

Version info
Please include the output of versioninfo() and Pkg.status() for the environment
where the issue occurred.
julia> versioninfo()
Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 16 × 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, tigerlake)
Threads: 1 default, 0 interactive, 1 GC (on 16 virtual cores)
Environment:
  JULIA_ERROR_COLOR = red

julia> Pkg.status()
Status `/tmp/jl_jkrCb0/Project.toml`
  [cbdf2221] AlgebraOfGraphics v0.8.3
  [e9467ef8] GLMakie v0.10.7

For others running into this issue, I've found that you can work with the colormap by using scales, e.g. as in https://aog.makie.org/dev/layers/draw/#Color.
Probably the example in https://aog.makie.org/dev/gallery/gallery/customization/colorbar/#Colorbar-tweaking needs to be modified, as this is where I got the syntax from in the first place.


Fix esp spi bug

Summary

Fix crash when rx buffer is NULL in esp_spi_poll_exchange
Add missing SPI setup in send one word.

Impact
Now SPI is functional.
Testing
Tested with a chip 0.96inch st7735 LCD with esp32c3.

please update the title with something more descriptive
ex:
arch/espresif: Fix spi bug


build(env): shifted env variables to github secrets

run build production main

run build production main

run build production main

run build production main

run build production main

run build production main

run build production main

run build production main

run build production main

run build production main


Attempt to use Arrow Flight's built-in AuthHandler class instead of custom middleware for authentication

The current authentication functionality of the example Flight SQL Server relies on customized middleware that handles basic and bearer token authentication.
The built-in functionality of Arrow Flight's ServerAuthHandler class should handle this for us.  We should attempt to switch to built-in Arrow functionality to reduce the code footprint as well as to improve performance and security of the authentication.
This was pointed out by: @pkit

Nice, thank you!

  I had to revert to the middleware solution...
I believe that the built-in class is designed for Flight RPC clients, not Flight SQL clients...


Fixes and updates for PHP toolkit constructor args

Corresponding gax PR: https://github.com/googleapis/gax-php/pull/174

Codecov Report

Merging #1966 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #1966      +/-   ##
============================================
- Coverage     85.93%   85.93%   -0.01%
- Complexity     4949     4951       +2
============================================
  Files           452      452
  Lines         19714    19715       +1
  Branches       2071     2071
============================================
  Hits          16942    16942
  Misses         2076     2076
- Partials        696      697       +1

Impacted Files
Coverage Δ
Complexity Δ

...codegen/viewmodel/testing/ClientTestClassView.java
88.88% <0%> (-11.12%)
4 <2> (+2)

...ransformer/php/PhpGapicSurfaceTestTransformer.java
100% <100%> (ø)
21 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af4c97...0fd1a80. Read the comment docs.


ImportError: cannot import name 'ONE_SECOND'

Using version 1.9.0
/usr/local/lib/python3.7/site-packages/orbit_predictor/accuratepredictor.py in <module>
      2 import warnings
      3
----> 4 from .predictors.accurate import HighAccuracyTLEPredictor, ONE_SECOND
      5
      6 warnings.warn(

ImportError: cannot import name 'ONE_SECOND' from 'orbit_predictor.predictors.accurate' (/usr/local/lib/python3.7/site-packages/orbit_predictor/predictors/accurate.py)

Importing should be like .predictors.base import ONE_SECOND

Oops, you're right! Fixing

Closed in 1.9.1.


The password you entered is incorrect.

In login to IG:dm - "The password you entered is incorrect. Please try again." But I tested my password and it's correct! Any idea what to do? (I have Windows 8)


Reusable request bodies are not handled correctly

According to OpenApi 3.0 spec "reusable request bodies" are supported. However with latest NSwag (version <IP_ADDRESS>) controllers are not generated correctly - action argument is always of type 'object':
openapi: '3.0.0'
paths:
  /bugs:
    post:
      summary: Returns list on NSwagStudio bugs
      requestBody:
        $ref: "#/components/requestBodies/NSwagStudioBug"
      responses:
        '200':
          $ref: '#/components/responses/NoContent'
components:
  requestBodies:
    description: Describes NSwagStudio bug
    required: true
    content:
      application/json:
        schema:
          type: string
  responses:
    NoContent:
      description: No content

and here is the generated code generated for action:
[Microsoft.AspNetCore.Mvc.HttpPost, Microsoft.AspNetCore.Mvc.Route("bugs")]
public System.Threading.Tasks.Task Bugs([Microsoft.AspNetCore.Mvc.FromBody] object body)
{
    return _implementation.BugsAsync(body);
}

Expected: body type should be 'string'.

Seems like a duplicate of https://github.com/RicoSuter/NSwag/issues/2122
However, the problem is not fixed


High accuracy 0.843 in train_msc val?

Train for 20K iterations with original parameters in train_msc.py with about 10K VOC training set and val the model.ckpt-8000 for 1449 val images but got the high accuracy:0.843?
The training loss is around 1.5 and it  seems very high.
If so, the released model by DeepLab was pre-trained on trainval, which explains high accuracy on validation.


Cargo fails when rustc isn't in default location

For my project I have a script that setups a Rust installation in a subdirectory so that the user's system doesn't need to be changed, superuser rights are not needed, and the installation doesn't mess with any Rust installation the user already has. So I execute
curl -sSf https://static.rust-lang.org/rustup.sh | sh -s -- \
--channel=nightly --prefix=/home/mint/rustbin/ \
--disable-sudo --disable-ldconfig --yes

and Rust installs fine. I can run rustc
cd ~/rustbin/bin
export LD_LIBRARY_PATH=/home/mint/rustbin/lib
./rustc --version

rustc 1.2.0-nightly (906ad7246 2015-06-15)

but Cargo doesn't work:
cd ~/rustbin/bin
export LD_LIBRARY_PATH=/home/mint/rustbin/lib
./cargo --version
Could not execute process `rustc -vV` (never executed)

Caused by:
  No such file or directory (os error 2)

I believe this is caused by Cargo looking for rustc in /usr/local/bin, where it's not unless it's installed there.

Thanks for the report! Cargo currently does not make any assumptions about where rustc is located, however, and requires that it is part of your PATH to be able to run. You can override this in nightly verions of Cargo though with the RUSTC environment variable or the build.rustc configuration key.


APP-183: Fix profiling demo

/cc @Slash32 @RostakaGmfun

Retest this please

Can one of the admins verify this patch?

Fixed


Support rotation control from touch input

It would be really useful if the 'rotationControls' of universal-controls allowed support for touch-control too. The use-case is when inside a video sphere and you just want to rotate the camera rather than move through the physical space. Currently when trying to use touch for rotation I receive an error.
TypeError: control.isRotationActive is not a function. (In 'control.isRotationActive()', 'control.isRotationActive' is undefined)

Hi @allanweir – I don't plan to include touch-rotation as a default, since more VR-friendly navigation is time consuming already, but a goal of universal-controls is that you can add your own controls components as needed, and they'll 'just work' with the existing ones. For example, to make a custom-controls component that does what you describe:
<a-entity camera universal-controls="rotationControls: hmd, gamepad, custom" />

AFRAME.registerComponent('custom-controls', {
  isRotationActive: function () { /* ... */ },
  getRotationDelta: function () { /* ... */ }
});

The code for the component would be almost identical to mouse-controls, except that in addEventListeners() you'd want to listen for touchstart / touchend instead of (or in addition to) mousedown / mouseup.
This extensibility, and a similar way of adding new controls, will probably be added to A-Frame core in v0.4.0.

Hi @donmccurdy sure that makes sense. If I was to develop that control would you want a pull request or just prefer to keep it separate? I'm having another issue with specifying multiple options for rotationControls and movementControls but i'll file that separately

If you would like to keep it separate I've uploaded it to git and npm and is ready for use https://github.com/allanweir/aframe-touch-rotation-controls
Thanks for the help!

Nice job, the component looks good!
In A-Frame v0.4.0, there will likely be a controls registration API:
AFRAME.registerControls('custom-controls', {
   /* ... */
})`)

...very similar to how universal-controls works here. PR#1248. When that lands, I'll remove universal-controls and update all of my controls components to use that API. In the meantime I'm not planning to make any big changes, so from my perspective a separate component makes most sense now.
Thanks!

@germanviscuso if you mean rotating a model like in this example, this package is probably not what you want. I'd try aframe orbit-controls: https://github.com/tizzle/aframe-orbit-controls-component


How to turn off all tray balloon messages?

I get a lot of tray balloon messages.
How do I turn off and disable the balloon messages that tell me when a sync is finished?

v1.1.27

+1, would really like an answer to this. I installed SyncTrayzor maybe 15 minutes ago and the constant notifications of "hey this file was updated from another device" are already super annoying.

This is a per-folder setting, see the "Folders" tab, as the text "See the 'Folders' tab for per-folder notification settings" instructs you to.
If you've got suggetions on making this clearer, I'm allears!

This is a per-folder setting, see the "Folders" tab, as the text "See the 'Folders' tab for per-folder notification settings" instructs you to.

You know, I totally missed this text when I looked at the dialog. 🤦 Thanks for pointing it out!

If you've got suggestions on making this clearer, I'm all ears!

Maybe put it at the top of the frame (above the checkboxes, right underneath the "Tray Icon" heading)? It's kind of sandwiched between the checkboxes and the "Animate tray icon" dropdown, so that might be why I missed it when scanning the options.
You might also consider making all the descriptive text italic although that might be a bit much. Just a thought to try out and see if you like it.
Thanks again, and I hope the suggestions help. 😄

I've moved things around a bit. Hopefully that's clearer!

Thanks, I think that will help!

Haha, thanks @canton7!
Apparently, even the additional dialog was not enough for me.
For context, I tried configuring it about 10 hours ago, look through it several times, even clicked on the Folders tab, but it just did not connect for me. I finally decided to file an issue only to be pointed here almost immediately. I feel really blind now.
I took another look, why not:

Move Show Tray Icon only on close to the SyncTrayzor group (This is icon behavior)
Move Animate Tray Icon: to the SyncTrayzor group (This is icon behavior)
Move the rest of Tray Icon and Alerts to Folders (These are notification types)
Rename Folders as Notifications or Toasts

The issue I see is that notification types and tray icon behavior were mixed together. It should be crystal clear once they are separated. Alerts could also be expanded so that they can have a sticky alert and notifications. I kept focusing on the Tray Icon as I assumed all notifications should be configured there.
Just my 2 cents. :) Thank you!

The Folders tab exists because there are many sorts of per-folder settings. However, I really need to properly ditch the filesystem watcher at some point (it's almost pointless currently, as Syncthing's watcher will replace it in almost all cases, but I haven't wanted to pull the plug).
If those are removed, then the Folders tab will only contain per-folder notifications, and so I agree it makes sense to bundle all of the notifications together in a single tab.


ToDo - Separate storage for each channel and each server

Currently, the bot shares the initiative order across all servers and all channels. This would be better handled by providing some form of separate storage for each channel and each server, perhaps using json files locally.

I have decided, for now, to just leverage Javascript objects for the channels, which will include a list of properties associated with each channel for use with this bot, such as init (initiative order) and init type -- as eventually I want to include a command to set the initiative type (5e, swrpg, etc) for each channel.

This in progress and includes use of mongodb to store the objects so that the public bot can be taken offline for maintenance without losing any channel's initiative order or preferences (coming feature set).


fix the question of Spark job cann't found com/sun/jersey/api/client/…

…config/ClientConfig in yarn cluster mode
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.

@StephenQQ thanks for reporting, could you please raise the jira also and update the commit id. For more details could you please look into https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute..? Let me know any help required on this.

Could please mention the stack which you tried.?


When executing pip install -r requirements.txt -v, an error will occur

When executing pip install -r requirements.txt -v, an error will occur because the logging package is a built-in Python module and does not need to be installed. It is recommended to remove this package from the requirements.txt file.

Thank's for the hint. The updated version will be comitted soon.

https://github.com/muehlburger/dx-2024-flex/commit/8521a7cac675af8583f573389bab267f639d6158 should fix this issue. Thank's for reporting!


Tree fixes for nested node handling (scroll and id generation)

Fixes issues with the tree component throwing errors when provided a list of nodes with more than 1 level of depth.

Lazily generate ids with get_node_id instead of generating them only for top-level nodes
Recursively calculate tree height on scroll to take into account expanded/contracted nodes

hey @willothy, thanks for contributing! I'm wondering if you could provide the code that generates the bug. I plan on writing some unit tests, and it would be great to cover that case.

Any configuration of a tree with more than one level of nodes caused errors for me, are you not able to reproduce?

Any configuration of a tree with more than one level of nodes

I probably haven't tested that case.

I don't have the original code but I can come up with a small example

that would be helpful!

This can reproduce the error for me:
local NC = require("nui-components")

local body = function()
  return NC.tree({
    size = 5,
    border_label = "Results",
    data = {
      NC.node({
        text = "Result 1",
      }),
      NC.node({
        text = "Result 2",
      }, {
        NC.node({
          text = "Result 3",
        }),
        NC.node({
          text = "Result 4",
        }),
      }),
    },
    on_select = function(node, component)
      if node:is_expanded() then
        node:collapse()
      else
        node:expand()
      end

      component:get_tree():render()
    end,
    prepare_node = function(node, line, component)
      local depth = node:get_depth()
      line:append(string.rep(" ", (depth - 1) * 2))
      if node:has_children() then
        if node:is_expanded() then
          line:append("v ")
        else
          line:append("> ")
        end
      else
        line:append("- ")
      end
      line:append(node.text)
      return line
    end,
  })
end

local view = NC.create_renderer({
  width = 40,
  height = 5,
})

view:render(body)


Fixed an issue with copying unsaved Pages

Resolves #6221

@samgans Congratulations on your first contribution! Do you have a preferred name for CONTRIBUTORS.rst? (You can use your GitHub username if you want to)


[Question]What is the right way of using g3log in different class?

I did not find any test case of using g3log in different threads, Could you write an example of using g3log in different classes which have different threads?

As long as g3log is instantiated correctly then it should be threadsafe to use. While the documentation doesn't have code examples of this, that G3log is threadsafe is mentioned
Please see

https://kjellkod.github.io/g3log/
https://kjellkod.github.io/g3log/g3log/
in case custom formatting is needed where the different thread IDs are shown, https://kjellkod.github.io/g3log/API_custom_formatting/ and these tests that uses it: https://github.com/KjellKod/g3log/blob/master/test_unit/test_message.cpp


⚠ ClamAV has degraded performance

In 5614dbd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 75 ms

Resolved: ClamAV performance has improved in 1fda44f after 536 days, 16 hours, 29 minutes.


[Question] Feedback on downstream library

I'm submitting a...

[ ] Bug report
[ ] Feature request
[x] Announce?

Reproduction steps
n/a
Version information
Browser type and version:
InscrybMDE version: 1.11.6
vue-inscrybmde
I forked vue-simplemde and updated it to use inscryb-markdown-editor.  At this point its a straight fork, no enhancement, other than those built directly into inscryb.  Looking for thoughts and feedback.  https://github.com/dantrevino/vue-inscrybmde.
Since there is no slack/twitter/whatever, I thought i'd mention it here.
Cheers,
Dan

Great addition. Please feel free to add a link to your repo in the readme through a PR.


More comprehensive javadoc conventions

Proposed by #2049

In fact, I wonder if these should be in conventions or other files.

A reminder to myself: Ask people to link topics with {@index } so javadoc search can find it

Good, the bot actually runs! I thought it was dead for an instant.

I think when I come back to work on this, I should talk about how docs on packages/constants work as well. Just a note for myself.

Note to myself: link to https://docs.oracle.com/en/java/javase/16/docs/specs/javadoc/doc-comment-spec.html#where-tags-can-be-used now as it has way more tags!

After a thousand years, I've finally updated this. The squashed commit is what there was before the update, and the modernized information was a compilation of my side notes and about java 16 update.


Word-wrap not working for git diffs?

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

python
donjayamanne
0.5.8

csharp
ms-vscode
1.7.0

Spell
seanmcbreen
0.9.1

Steps to Reproduce:

Git diff a markdown file with long lines
Attempt to toggle word-wrap
Cry bitter tears, gnash teeth

Already asked and answered (search issues for "wrap").

I was afraid of that. Clicking the magic "submit bug" button took me to open an issue. I should have searched issues before opening a new one. My bad. Closing.


Added Tibia

Added Tibia to Gaming.
See #1047.

Does this site have sensitive info?
(and travis seems to be finally working)

yeah what happened with Travis? Did anyone change anything?

I swear I didn't do anything. :)

I have to restate @mxxcon's question. Does this site belong here?


add show/hide URI buttons in questions/catalogs management

I've added checkboxes in the header of the questions/catalogs management page which can show/hide the URI for each element on the page.
Implementation for: https://github.com/rdmorganiser/rdmo/issues/449

Coverage remained the same at 90.476% when pulling 69bde356c91349bb5ef08e4966d53864150c3606 on MyPyDavid:dev-449-catalogs-display-toggles into 1bf4a3484e9bee956648cc027e4dd73e9f11159d on rdmorganiser:dev.

Hey @MyPyDavid, I thing the checkboxes should go to the sidebar (like Show questions). But then there ist little space. Maybe we need some kind of accordeon which can be opened to reveal all checkboxes.

I've moved these checkboxes now to the sidebar and gave them corresponding  colors.
We don't need the checkbox for catalogs, sections and question sets, so now there are only 4 left (see picture).
This fits also without accordion or?
I've added the margin-bottom : 0 via an ng-style conditional statement.

All fine, but the spacing seems a bit uneven. Can you try:
.showURI-checkbox {
    margin-top: 0 !important;
    margin-bottom: 15px !important;
}

and

      <input type="checkbox" ng-model="service.showURIQuestions">
      {% trans 'Questions' %}

      <input type="checkbox" ng-model="service.showURIConditions">
      {% trans 'Conditions' %}

      <input type="checkbox" ng-model="service.showURIAttributes">
      {% trans 'Attributes' %}

      <input type="checkbox" ng-model="service.showURIOptions">
      {% trans 'Options' %}

This cleans up the markup a bit and uses the .checkbox class we use in RDMO elsewhere.

The checkboxes are now evenly spaced but there is still an extra empty space between the bottom of the checkboxes and the next "Options" header.
I think it comes from the input-group, do you know where I can style that to 0 @jochenklar ?

Fixed here: https://github.com/rdmorganiser/rdmo/commit/5b03abcfb82af6637691aeb24e96cbb01bb2c805

thanks, looks nice and evenly spaced now!


Raz/1405 stop podman on cancel

@eranco74 @ori-amizur @gamli75 do we have things that we run not in a container besides the agent?

@eranco74 @ori-amizur @gamli75 do we have things that we run not in a container besides the agent?
There are somethings running on the bootstrap:

bootkube, approve-scr and progress services
openshift temp control plane containers running in crio (not podman)

@eranco74 @ori-amizur @gamli75 do we have things that we run not in a container besides the agent?

No, besides what @eranco74 mantioned.

@eranco74 @ori-amizur @gamli75 do we have things that we run not in a container besides the agent?
There are somethings running on the bootstrap:

bootkube, approve-scr and progress services
openshift temp control plane containers running in crio (not podman)

As we decided, those thing will be handled on reset.


Footer Component

I don't think this is needed, we should be able to get away with having a content component, and then a wysiwyg area that we can fill out the footer. closing until we need this again.


[SPARK-29904][SQL][2.4] Parse timestamps in microsecond precision by JSON/CSV datasources

What changes were proposed in this pull request?
In the PR, I propose parsing timestamp strings up to microsecond precision. To achieve that, I added a sub-class of GregorianCalendar to get access to protected field fields which contains non-normalized parsed fields immediately after parsing. In particular, I assume that the MILLISECOND field contains entire seconds fraction converted to int. By knowing the expected digits in the fractional part, the parsed field is converted to a fraction up to the microsecond precision.
This PR supports additional patterns for seconds fractions from S to SSSSSS in JSON/CSV options.
Why are the changes needed?
To improve user experience with JSON and CSV datasources, and to allow parsing timestamp strings up to microsecond precision.
Does this PR introduce any user-facing change?
No, the PR extends the set of supported timestamp patterns for the seconds fraction by S, SS, SSSS, SSSSS, and SSSSSS.
How was this patch tested?
By existing test suites JsonExpressionSuite, JsonFunctionsSuite, JsonSuite, CsvSuite, UnivocityParserSuite, and added new tests to DateTimeUtilsSuite, JsonFunctionsSuite for from_json() and to CSVSuite.

@cloud-fan Please, take a look at this.

Test build #113716 has started for PR 26507 at commit 3d7a611.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18596/
Test PASSed.

Test build #113716 has finished for PR 26507 at commit 3d7a611.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113716/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18607/
Test PASSed.

Test build #113727 has started for PR 26507 at commit 453ee5c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18613/
Test PASSed.

Test build #113734 has started for PR 26507 at commit 86ac2b2.

Test build #113727 has finished for PR 26507 at commit 453ee5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113727/
Test PASSed.

Test build #113734 has finished for PR 26507 at commit 86ac2b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113734/
Test PASSed.

is there some standard to define the behavior? For example, 11:11:11.123, how shall we interpret the .123 here? or it's related to the timestamp format?

is there some standard to define the behavior?

I think regular mathematical definition is applicable here: https://en.wikipedia.org/wiki/Fraction_(mathematics)#Decimal_fractions_and_percentages

For example, 11:11:11.123, how shall we interpret the .123 here? or it's related to the timestamp format?

Java 8 DateTimeFormatter says that S is fraction-of-second: https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html . So, it mean 11.123 = 11123/1000 seconds and 11.123456 = 11123456/1000000 = 11 seconds 123 milliseconds 456 microseconds for the pattern ss.SSSSSS
The doc of SimpleDateFormat says S is Millisecond: https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html. It means 11.123456 = 11 seconds 123456 milliseconds = 134 seconds 456 milliseconds for the pattern ss.SSSSSS

@cloud-fan In general, are you ok with the changes? Should I continue?

I think this is a good idea. I wasn't aware of that we can tweak SimpleDateFormat in this way.

Test build #113784 has started for PR 26507 at commit 638c640.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18657/
Test PASSed.

Test build #113789 has started for PR 26507 at commit 66d1100.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18661/
Test PASSed.

Test build #113784 has finished for PR 26507 at commit 638c640.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113784/
Test PASSed.

Test build #113789 has finished for PR 26507 at commit 66d1100.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113789/
Test PASSed.

Test build #113801 has started for PR 26507 at commit 0bdb523.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18673/
Test FAILed.

Test build #113806 has started for PR 26507 at commit 7d9a19d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18678/
Test PASSed.

Test build #113801 has finished for PR 26507 at commit 0bdb523.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113801/
Test PASSed.

Test build #113806 has finished for PR 26507 at commit 7d9a19d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113806/
Test PASSed.

LGTM except a few minor comments. Can you fill the PR description?

Test build #113857 has started for PR 26507 at commit 1852511.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18726/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113857/
Test FAILed.

jenkins, retest this, please

Test build #113861 has started for PR 26507 at commit 1852511.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18730/
Test PASSed.

Test build #113861 has finished for PR 26507 at commit 1852511.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 class TimestampParser(format: FastDateFormat)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113861/
Test PASSed.

cc @HyukjinKwon

Test build #113893 has started for PR 26507 at commit 1cbd35b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18761/
Test PASSed.

Test build #113893 has finished for PR 26507 at commit 1cbd35b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113893/
Test PASSed.

@MaxGekk . According to your finding, we may revert this from branch-2.4 completely in the worst case. Thank you for working on this area. This is reported as BUG fix, but it seems to be more Improvement .

This is reported as BUG fix, but it seems to be more Improvement .

This PR fixes bugs as well, see https://github.com/apache/spark/pull/26507#discussion_r345982915 . @dongjoon-hyun Try to parse timestamps with fraction patterns S or SS.

@MaxGekk . The existing bugs are not blocker for the release. But, new bug can be a blocker because it's called as a regression.

But, new bug can be a blocker because it's called as a regression.

ok. As far as I know this PR haven't introduced any regressions yet or I missed something?

Sure, @MaxGekk . That's the reason why I say 'in the worst case'. We are investigating this area, aren't we? This is an early notice to the relevant peers on this PR.

The document of DataFrameReader.json says that it supports the pattern string of java.text.SimpleDateFormat. That said, microseconds precision should be supported if the pattern string contains SSS. So this is a bug fix.
I think we should apply it to all the places that promise to support pattern string of java.text.SimpleDateFormat, like to_timestamp. We may also need to fix the master branch as well when we add back the legacy formatter.
BTW I don't think this is a serious bug that worth to fail the RC.

Thank you for the decision, @cloud-fan !


ci: only add /test .. comment if the branch for the PR matches

By adding an if-statement for each step of the matrix job, only those steps are executed where the base ref of the PR matches the branch in the matrix parameters.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)

/test ci/centos/k8s-e2e-external-storage

/test ci/centos/mini-e2e

/test ci/centos/upgrade-tests

@nixpanic we need to adjust the mergify rules as per the new change. for now i started some tests manually in some PR as mergify still needs all checks to be passed


Investigate using calendar instead of meetingplace api

I don't want to rely on meetingplace forever for this. Eventually we'll have some sort of calendar we can use, possibly one people can subscribe to.
Possible options:
Use public ical-formatted calendar links. Here's an example calendar:
https://calendar.google.com/calendar/ical/c_69locn61onbjf3ui8b0atnss6g%40group.calendar.google.com/public/basic.ics
I would think this would be pretty straightforward. However, we have a set of events that we don't really want to be public, but we do want posted to the slack. So, another option would be to hook into the google calendar API with credentials and then grab specific calendars from there. This would allow the calendar to remain private, but allow the bot to read from it and display info to slack.
I have no idea how much effort this would entail, but would love to hear thoughts on it.

I too know very little about that but it sounds like a good idea. Meetingplace is fine, but clunky, and it'd be so nice if we had our own calendar that slack members could check out without also needing credentials for meentingplace.io.
Do we just need to set a time to test or is this something Mike might have experience with as well?

I was thinking @MikeRogers0 could (if willing and able) adjust the current bot to try to read from the calendars. Even reading from the public one would probably be an improvement for our slack purposes. Don't want to jump head first into anything, but this could be useful.
The way we actually set up the calendars is another issue, but one we can handle separately - no matter what we put in there, the calendar entries will always have date/time, title, desc, and a url, so that should be enough to feed the bot.

https://developers.google.com/calendar/quickstart/ruby / https://github.com/googleapis/google-api-ruby-client - It looks like there is a Gem which wrappers their API (Though IIRC, Google does charge for usage of the API, but does have a free tier). I think we'd just need to authorise access to the calendar & we'll be good to go.
@danieltott Do you want to give me access to the current calendars?

Does our having Virtual Coffee GSuite give us any advantage here with the pricing/options/etc?
Totally jumping into the conversation late but curious.


How to override small icon in media3 notification

I have been trying to change the small icon from the default media3 notification following the next approach from the following links for ExoPlayer:
https://github.com/google/ExoPlayer/issues/5372
https://stackoverflow.com/a/58302954/4945933
So I have added these in one of my values xml files to test it:
<drawable name="exo_notification_small_icon">@drawable/ic_notification_icon</drawable>
<drawable name="exo_notification_pause">@drawable/ic_pause</drawable>
<drawable name="exo_notification_play">@drawable/ic_play</drawable>

These are not working and I'm wondering if this approach actually works with media3?
Should it work straight away? Don't I need to somehow reference these drawables from my theme?
Am I missing anything? :)
Thanks!

In Media3 the notification is created by the DefaultMediaNotificationProvider.
You can either override the  drawable in your resource files:
<drawable name="media3_notification_small_icon">@drawable/my_drawable_small_icon</drawable>

of use the API on the DefaultMediaNotificationProvider that has a setter setSmallIcon(@DrawableRes int smallIconResourceId).
Please re-open if this does not work. Thanks!


DQL alias required when using Embeddables in a Specification?

For some Entities we use Embeddables. It seems these Embeddables are not respected when used in a Specification? More specifically, the DQL alias e is explicitly required.
For example for an Embeddable TimeIntervalwith two properties begin and end of type DateTime this does not work:
$specification = new Specification([
    new AndX(
        new LessThanOrEquals('interval.begin', new \DateTime()),
        new GreaterThanOrEquals('interval.end', new \DateTime())
    )
]);

But this does work (note in this case the property is prefixed with the DQL alias):
$specification = new Specification([
    new AndX(
        new LessThanOrEquals('e.interval.begin', new \DateTime()),
        new GreaterThanOrEquals('e.interval.end', new \DateTime())
    )
]);

Is this behavior intended? For other properties, the DQL alias seems not required.

I must admit I have not used Embeddables much yet.
I will try to find out why the e alias is required in this case.

I believe the following line might be causing the issue you encounter:
https://github.com/rikbruil/Doctrine-Specification/blob/master/src/AbstractSpecification.php#L49
There I check if an alias was provided, by checking for the existence of a . in the $value. If it was provided, I assume we don't want to prefix it with the default alias.
This was probably written before I knew about the existence of Embeddables (the DQL example from the documentation also uses 2 dots for checking embeddable values).
I will try to figure out how to fix this.

Maybe it is better to remove the distinction between $field and $dqlAlias and just let the user pass whatever $dqlAlias, $field or $dqlAlias.$field he/she wants?
I have a case where I would like to have the first option. I want to make sure that the result is of a particular type, not just one field. In a table where two related types of entities are stored, Message and Private message, I want to select just the private ones. The resulting DQL should look like:
SELECT e FROM Message e WHERE e INSTANCE OF PrivateMessage

At the moment this is not possible, because $field is required. Passing an empty string would create e..
If you like that, I can try to make a PR.

Maybe it is better to remove the distinction between $field and $dqlAlias and just let the user pass whatever $dqlAlias, $field or $dqlAlias.$field he/she wants?

mm, that is an option indeed which makes it more flexible. But it probably means a breaking change . Currently users only provide the fieldname which will get prefixed automatically. In the suggested situation those users should provide alias.fieldname, right?
Currently typical usage would result in DQL like:
SELECT e FROM Message e WHERE e.fieldName = X;

In the suggested situation this will become:
SELECT e FROM Message e WHERE fieldName = X;

Which will result in an error:
[Semantical Error] line 0, col 53 near 'fieldName': Error: 'fieldName' is not defined. in ./vendor/doctrine/orm/lib/Doctrine/ORM/Query/Parser.php(483)

So this would mean a new major version, right?
Probably SpecificationRepository::$dqlAlias should be made protected, so Repositories that extend it can refer to it / change it when required...

Any progress on this? Or "snoozing"?

I will take a fresh look at this issue, I've been kind of busy lately unfortunately.
We could expose the $dqlAlias property, and I agree that if we change the behavior of these fields/aliases completely it should be a major version bump.
I can probably do some testing later tonight.


custom DATA(dummy) rule

even though custom DATA(dummy) is valid 702 syntax, it is bad code, add custom rule to find these
@christianguenter2

@christianguenter2
latest version not release to npm yet, will update the abapGit config when its released


[AutoComplete] filter not showing list on focus

When using showAllItems, items are displayed on AutoComplete focus. But when I'm trying to add some more logic with filter function, items are displayed only when searchText is not empty.
Trying this:
 _filterFiles(searchText, key) {
        if (this._filterLen < 5 && key.includes(searchText)) {
            this._filterLen++;
            return true;
        }

        return false;
    }

Seems that filter function is not even triggering on autocomplete focus. What am I doing wrong?

showAllItems is deprecated. You should implement this behavior in your own filter.
ex.
if (searchText === '') return true;

thanks for the answer, the problem is that filter is not called on autocomplete component focus

triggerUpdateOnFocus = true will help :)

Sadly, it also doesn't help
<AutoComplete
                    dataSource={this.state.files.map(function (file) {return file.filename})}
                    ref="filename"
                    onNewRequest={this._onFileSelect.bind(this)}
                    onUpdateInput={this._onFilenameChange.bind(this)}
                    triggerUpdateOnFocus={true}
                    filter={this._filterFiles.bind(this)}
                />

_filterFiles(searchText, key) {
        debugger;
        if (this._filterInc < 5 && key.includes(searchText)) {
            this._filterInc++;
            return true;
        }
        //if (searchText === '') return true;

        return false;
    }

I've found this issue via searching for triggerUpdateOnFocus and tacking on my experience.
updateWhenFocused still works but throws an deprecation warning

Closed by #4783


README: fix a couple of typos

Ping @dvyukov .  Just looking through some old pull requests.  This is a trivial one.

Oh, missed if before. Thanks!


add algo::transform_copy_if

Implementation of #1817 (partially, no in-place version yet)
Ended up not migrating copy_if and similar functions since transform_copy_if uses compress_store instead of compress_copy.
Wrote some documentation and moved the tests for copy_if to transform_copy_if as per Denis' advice.
I wonder if the name is alright, since it sort of implies that the function acts like transform followed by copy_if but it's actually more like the opposite, copy_if followed by transform.
Tried roughly measuring the performance and it seems to be faster than eve::algo::copy_if and eve::algo::transform_to separately but slower than std::copy_if followed by std::transform. I don't really know how to properly benchmark things though. Also, maybe the in-place version will be faster?

Awesome - will have a look in a bit. I keep benchmarks separately and I have some copy_if becnhmarks.
For this algorithm, I wouldn't worry much about benchmarks tbh (we don't benchmark everything - too expensive).
But if you want to - I can help you set that up

the documentation tests that aren't passing seem to be from a clang bug? as seen here
tried it on a new version and it seems to compile just fine

i could rewrite the example to not use std::ranges::subrange

i was thinking about names for in-place copy_if and i think keep_if makes sense
so the in-place version of transform_copy_if could be something like transform_keep_if
however that might be inconsistent with the already existing transform_to and transform_inplace. maybe something like transform_to_if and transform_inplace_if could also work?

As much as I'm not excited about keep_if - I can't come up with anything better, since filter has to be a view.
I think keep_if, transform_keep_if, transform_copy_if is the way we go. Yuck.

i don't understand why this one test didn't pass, i will push a dummy commit to restart the tests

seems to have passed now, must have been a bug in the CI?

seems to have passed now, must have been a bug in the CI?

it's a somehow random concept bug we have sometimes. Nothing from your side.

So is this a merge ?

@Temulgeh merging?

i don't see anything i'd want to change so fine with it


Clarification that the Windows 10 PC must be physical

I tried testing this out using a Windows 10 Azure AD Joined PC (Virtual Machine) hosted on my local Hyper-V. However I encountered the "The sign-in method you're trying to use isn't allowed. Try a different sign-in method or contact your system administrator." message. This docs page indicates that is because of MFA. I followed the advised steps to exclude that cloud app from my conditional access policy for MFA. However I still faced the same issue.
I opened a support ticket. Support advised me that the client Windows 10 device that is Azure AD joined must be the physical device... Unfortunately I don't have a physical device that I can Azure AD Join right now so I can't verify this. But assuming that is the reason this document could do with calling that out as I'm sure many people are interested in this feature and would like to test it out and will likely do as I have done by going down the local VM route.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c946fe0f-e18d-2529-2fbf-bce04759fbca
Version Independent ID: 885a61d1-6096-5aa0-fe8d-f1ec8d55e542
Content: Sign in to Windows virtual machine in Azure using Azure Active Directory (Preview)
Content Source: articles/active-directory/devices/howto-vm-sign-in-azure-ad-windows.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@danijam
Thanks for the feedback! We are currently investigating and will get back on this.

@VikasPullagura-MSFT Good News. I was able to trace down the root cause.
The Windows 10 Azure AD Joined Device does not need to be Physical it can be Virtual. I've provided my feedback to Azure Support via my support ticket as this information was inaccurate.
The root cause was actually MFA. The docs page in question here does mention in the troubleshooting section that if you don't have Windows Hello for business but use MFA via conditional access then you need to exclude the Azure VM Login "App". Now I did the exclusion to our conditional access rule that implements MFA with no result. During my troubleshooting I went as far as to just turn off our conditional access rule all together, which should have resulted in no more MFA. However MFA still remained enforced. This lead me down a path that resulted in realising that our org implemented MFA before conditional access was GA. We initially used the per user Office 365 method to enforce MFA. This is still on and enforced and was the reason conditional access was being overridden. For anyone interested there is a page on this topic here: https://docs.microsoft.com/en-us/azure/active-directory/authentication/howto-mfa-userstates#convert-users-from-per-user-mfa-to-conditional-access-based-mfa
I might see if I can suggest a edit to the page in question on this ticket to see if we can put a note to help anyone else who will get stuck if they have the same old settings applied.

#please-close


Update stream-analytics-autoscale.md

Feature is now in GA

#sign-off

#sing-off

#sign-off

#anboisve

#sign-off


Lz4/v4

replaces #1843

Force push was: rebase to master, but more importantly a fix to a grep command using a GNUish that fails on my OpenBSD runner.

Merged in #1848, thanks!


fix(curriculum): Increased starting font size to fix a bug on Chrome browser for Sass Apply a Style Until a Condition is Met with @while challenge

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #17629
Closes #34775
This PR attempts to address a problem with some Chrome versions not actually changing the font size below 6px on English version (see issue #34775) and below 12px on Chinese version (see issue #17629).  By starting the font-size at 15px, this should solve this issue once and for all.

@thecodingaviator Done.

@thecodingaviator Done.

@thecodingaviator #35777 has now been merged, so if you are ok with the changes, please approve and add this PR to the list of PRs needing a 2nd approval.  Thanks.


cmd/go: return best-effort results despite inconsistent vendoring

Following up on https://github.com/golang/go/issues/39100, is it possible for the go command to return partial results even with an inconsistent vendor folder? This is done in several (arguably smaller) cases, like #35973 and #38846.
If go list could return partial results along with the error, that would make the experience in gopls much better for users. Right now, our best option will be to show the user a pop-up with the error message and a button that, when clicked, runs go mod vendor. This work-around is fine for now, but I wonder if there is a better longterm solution.
/cc @bcmills @jayconrod @heschik

cc @matloob
Tentatively milestoning for 1.16. @bcmills could confirm feasibility of this though.
I think this is possible, but it will make looking up which module provides each package unreliable. We'd probably only want to do this with go list -e. That would work for gopls though, right?

Thanks!

I think this is possible, but it will make looking up which module provides each package unreliable. We'd probably only want to do this with go list -e. That would work for gopls though, right?

Yep, gopls uses -e.

Yes, I think this is feasible. The fix will be to move the inconsistent vendoring error from one that occurs at module loading time to one that applies to individual packages and/or patterns.
I think it will suffice to apply the error to every package loaded from the vendor directory, plus any wildcard patterns that could match packages outside of the standard library. All other packages (such as those loaded from std and from the main module) should be unaffected by inconsistent vendoring anyway.

I have a similar problem, but I'm not sure if my use-case fits in this issue or needs to be addressed in a separate issue.
When I list the dependencies of a Go modules based project, e.g. Delve, with GOPROXY=off by running this command:
go list -m -json -mod=vendor all

I receive the following error:
go list -m: can't compute 'all' using the vendor directory
        (Use -mod=mod or -mod=readonly to bypass.)

If I use the suggested -mod=mod or -mod=readonly then I'll receive an error similar to this:
go<EMAIL_ADDRESS>module lookup disabled by GOPROXY=off

When compiling the application with a command like the one below, the command finishes successfully:
go build -mod=vendor -o=my-delve github.com/go-delve/delve/cmd/dlv

If I set the GOPROXY=proxy.golang.org,direct, then go list downloads the dependencies and then lists them from the GOMODCACHE. This is not what I want or need.
So, the problem seems to be go lists's inability to list the dependencies when using -mod=vendor and/or work with GOPROXY=off. The -e flag does not seem to do anything in this case.
As such, I propose that go list should continue to work and list the vendored modules/dependencies when GOPROXY=off and -mod=vendor flags are present. If I need to add -e to the go list command, that's OK too.
This problem also hampers users of editors such as GoLand. It is impossible for the IDE to list the vendored dependencies and have access to their version, without parsing the vendor/modules.txt file. To the best of my knowledge, the file format is not stable, or well documented, which means it can change at any time (please correct me if my assumption is incorrect).

I understand there's not enough time to include this issue in the Go 1.16 release, so I'll reset the milestone to Backlog. Please update it as needed.

Is this issue resolved in go 1.16.2 ??

@mtalhasaleem502 No, this issue is still open.
You can resolve this problem in your module by running go mod vendor to make the vendor/modules.txt file consistent with go.mod.

I have done this but its still giving the same issue in go.mod file.

@mtalhasaleem502, please open a separate issue with steps to reproduce the problem.

@bcmills  yes I have open the new issue #45103

Is this issue likely to be done for 1.17?  Thanks.

I don't think this will be done for 1.17. Moving to Backlog, but I might reassess it alongside the changes for #36876.

@mtalhasaleem502 No, this issue is still open.
You can resolve this problem in your module by running go mod vendor to make the vendor/modules.txt file consistent with go.mod.

Hey Jay, I read a few threads you guys had and I'm facing a similar issue here: basically running go mod vendor could not fix the inconsistency between vendor and go.mod.
I'm happy to elaborate on what I'm trying to do here if this info could be helpful for you guys and get some insights from you:
I'm playing around with go-gorm/playground: https://github.com/go-gorm/playground
as the step 4, I should be able to run ./test.sh, however, it always shows:
no required module provides package

and after reading some threads from you guys, I ran go mod vendor, here is what I got:

Don't know if this is related? If not, I can delete this post, if so, do you have any idea how to fix this? or we need to wait until Go 1.17?
Thank you so much!

@AbbyDeng no, that test script edits go.mod and should rerun go mod tidy and go mod vendor after it does so

any updates ? I'm using go1.17.5,re-run go mod tidy go mod vendor doesn't work.Is there a workaround?

any updates ? I'm using go1.17.5,re-run go mod tidy go mod vendor doesn't work.Is there a workaround?

https://github.com/golang/vscode-go/issues/1595#issuecomment-1043295536

This seems to be still happening.

I am getting the same issue here (and I am pretty new with GO)

Removing gopls from setting.json did the trick for me.


Update README

Adds more FAQ
Adds ntasks option to create_cheatsheet

Codecov Report
Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36.23%. Comparing base (f358d5f) to head (d862750).
Report is 4 commits behind head on main.

Files with missing lines
Patch %
Lines

src/cheatsheet_creation.jl
0.00%
4 Missing :warning:

src/file_processing.jl
0.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   35.55%   36.23%   +0.67%
==========================================
  Files           4        4
  Lines         135      138       +3
==========================================
+ Hits           48       50       +2
- Misses         87       88       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


I should have a timeout for running pending tasks.

Every instance of PendingTask has a function, runTask(completion: (success: Bool) -> Unit).
It would be a good idea to timeout eventually after starting a task, mark the pending task as complete but unsuccessful, then move on.

The original reason that I wanted a timeout was because runTask() was asynchronous and in case I forgot to ever call the completion callback, the timeout would keep Wendy going.
Since I switched to synchronous, I decided to skip this for now.
Why:

If you use a database or a HTTP library such as Retrofit, those libraries already have timeouts. Your runTask() should timeout anyway because of that.
I don't like the idea of being able to terminate runTask() if I can help it because I don't want to interrupt a database query half way into execution. Or some other critical task such as that.


Analyzer for services in service roles

Verify that services referred to by service roles actually exist. (Need to be aware of prefix / wildcard matching)
Kiali implementation: https://www.kiali.io/documentation/validations/#_unable_to_find_all_the_defined_services
(Also see https://www.kiali.io/documentation/validations/#_servicerole_can_only_point_to_current_namespace: should this be called out directly, or just covered implicitly?)

@sushicw do you think I can be assigned to this one?

Go for it. (In the future, feel free to self-assign! :) )


Maximize on minimized view

Allow the click on minimized view to maximize this view.

why?

Working now!

Hi @ppamorim! First of all, thanks for your pull request!
You should review your branch because you have some checkstyle issues:
/home/travis/build/pedrovgs/DraggablePanel/draggablepanel/src/main/java/com/github/pedrovgs/DraggableView.java:297:7: switch without "default" clause.
[ant:checkstyle] /home/travis/build/pedrovgs/DraggablePanel/draggablepanel/src/main/java/com/github/pedrovgs/DraggableView.java:298:7: '{' should be on the previous line.
Here you have the full build details: https://travis-ci.org/pedrovgs/DraggablePanel/builds/47370138
To avoid problems with your IDE configuration you can use this Square project to configure IntelliJ or Android Studio with the correct code format configuration: https://github.com/square/java-code-styles

Hi @pedrovgs! I apologize for the bad sourcecode , made on the run because my time is very short. I'll do it better, of course.

No problem @ppamorim the important is the pull request :). Your name looks familiar to me, are you from Spain or speak spanish?

@pedrovgs I'm from Brazil. My name is Pedro Paulo de Amorim

Hey @ppamorim  are you going to update this branch with the changes I suggested you?

@pedrovgs Yup! I'm in the middle of two projects and I'm without much time . I think today I will take a little time to work on those changes , seriously ! : p

@pedrovgs But my internet connection is horrible. If all goes well , to implement an example in the sample containing the TextureView running a RTSP video.

That's could be great! Remember to update the readme project with information about this feature, just one line.
Let me know when you update your branch to review it again and prepare another pull request with TextureView and RTSP video.
Cheers!

Pushed! Can you review?

Hey @ppamorim  why have you added code not related to this pull request like the RtspSample? Please, revert your changes and use different pull requests for different features. One for the RtspSample and other for "click to maximize" feature. I'm not going to review all this code if it's not in different branches.
Update also your branch with master, you have updated the android gradle plugin to 1.0.0 and that change is already in master.

Good morning Pedro,

RTSP features removed
sample return to the base
build.gradle updated.
can you review?

@pedrovgs RTSP sample changed to textureViewSample branch.

@ppamorim code reviewed! Take a look to my comments please. In addition you should update your branch with my "development" branch to be able to see if Travis accepts your branch.
You forgot to add the same configuration to DraggablePanel class and connect it with DraggableView. I left you some comments about this.

@pedrovgs Done :p

@ppamorim, please, update your branch with my development branch. I need to see if Travis CI build is of for this pull request and I can't do it if you don't update your branch.

If you update your branch with my development branch you'll se how Travis CI mark your pull request as "invalid" because right now, your code doesn't compile. Review my comments, please.

I'm kind of stuck and tried to update my fork with yours, but do not know how to do ... :(

Take a look here https://help.github.com/articles/syncing-a-fork/ and https://help.github.com/articles/merging-an-upstream-repository-into-your-fork/. You can use sorcetree if you want. You'll have to resolve some conflicts after commit and push.

@pedrovgs Yeah!

@ppamorim you have some problems with the checkstyle -> https://travis-ci.org/pedrovgs/DraggablePanel/builds/48468744

Working on this checkstyle issues :+1:

:100: YEEP

Hey @ppamorim I see your build is ok, but when I've tested your code your feature is not working with the YouTube sample. You have changed activity_youtube_sample.xml to use your new feature but the feature is not working. Here you have a video to show the problem: https://drive.google.com/file/d/0B9xkpTnF9BXjc25IS05HaXBZbmM/view?usp=sharing

We need implement a View helper only for the touch or disable the touch listener of youtube player, always when the view is minimized.

It's not a problem of library. It's a common problem when we've a view with a listener inside another view with a listener.
Like a Google Maps inside a ViewPager. Google Maps = YoutubePlayer, ViewPager = DragView.

Then, modify the sample and use your feature in the famous places sample instead of the YouTube one. Add also some javadoc with this information inside setClickToMaximizeEnabled and setClickToMinimizeEnabled  methods for DraggablePanel and DraggableView classes.

I think placing a View is a bad idea. I believe it is better to inform the developer that he must change / add another listener along with your YoutubePlayer. This covers various cases than implement a solution in the library.
Why? Because we don't know how to be the player of them.

@pedrovgs It's ok?

Oh my god, where's you?

Sorry @ppamorim I've been working 12 h per day this week. I'll try to merge your pull request this weekend. Do you need a maven central release with this feature?

@pedrovgs No problem, In the time, I'm working with this project inside of my app  (the project) and a maven central release isn't necessary now for me.

I fell out of my bed, I thought it was a dream.

Branch merged! Thanks for your pull request @ppamorim!!

@ppamorim a new version of DraggablePanel has been released to Maven Central Repository. New version 1.6 is ready to be used!

Thanks!


Add files via upload

@lisa-parity is this intended to be for main ?

In think this is intended to patch #965 or other reported ink issues, right?


Very specific bug when formatting a dutch date

Take a look at this codepen (open the console to see the result)
I expect to see 31 mrt, but I'm seeing 31 mrt.
When I input an other date I do see the expected result (tried only a few other dates)
Very specific! :)

Correction, the other dates are also giving me the extra dot.

@maggiepint, it seems, this one is related to #3088.

Is there something I'm missing here? This locale has . in the short month names. That being the case, isn't everything here working as it should? The MMM token is displaying short months with . as the locale file specifies.

Ah, I get it. Apparently this locale indeed always had the dot. Only my
code didn't use the dot, and because of
commit fc5a352e9ca30e32a96875810604ad981d1442c3 the months are being parsed
exact, so I started getting errors.
This indeed isn't a bug. Sorry for the trouble!
2016-04-24 22:46 GMT+02:00 Maggie Pint<EMAIL_ADDRESS>
Is there something I'm missing here? This locale has . in the short month
names. That being the case, isn't everything here working as it should? The
MMM token is displaying short months with . as the locale file specifies.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/moment/moment/issues/3139#issuecomment-214032455

--
With kind regards,
Jasper Schulte | 06-24569166 | jasperschulte.nl
http://www.jasperschulte.nl

No worries!


bdd(reclaim-pv): BDD test to verify claiming of released nfs pv

Signed-off-by: mayank<EMAIL_ADDRESS>Why is this PR required? What issue does it fix?:
This PR adds a BDD test to verify claiming of released nfs pv.
Verified behavior:

PVC created with volume name set to released PV
Application deployed with above-created PVC and verified data exists.

What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #78 (58fb647) into develop (1bae643) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop      #78      +/-   ##
===========================================
- Coverage    45.17%   45.13%   -0.05%
===========================================
  Files           27       27
  Lines         2240     2242       +2
===========================================
  Hits          1012     1012
- Misses        1158     1160       +2
  Partials        70       70

Impacted Files
Coverage Δ

...ernetes/api/core/v1/persistentvolumeclaim/build.go
69.62% <0.00%> (-1.81%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bae643...58fb647. Read the comment docs.


Add WinRT noexcept support

A few years ago, I introduced an optimization for https://github.com/microsoft/cppwinrt that allowed methods and properties to be attributed as noexcept to improve call site code generation. While all WinRT methods must return an HRESULT on the ABI, noexcept methods always return S_OK and are thus infallible. This does not change the way C++ code "looks and feels" but C++/WinRT would mark such methods noexcept in the C++ sense which allows the C++ compiler to avoid a bunch of exception handling overhead at call sites, reducing code size.
In Rust, the noexcept can further be used to avoid having to unwrap method calls that are known to be infallible. This also reduces error handling overhead but additionally simplifies implementations and call sites as method return values may be used directly without unwrapping.
The test included with this update illustrates the impact of this change. Consider the following IDL definition of an interface:
namespace Test
{
    interface ITest
    {
        void MethodString(String test);
        void MethodInt32(Int32 test);
        void MethodTest(ITest test);
        String String;
        Int32 Int32;
        ITest Test;

        [noexcept] void MethodStringN(String test);
        [noexcept] void MethodInt32N(Int32 test);
        [noexcept] void MethodTestN(ITest test);
        [noexcept] String StringN;
        [noexcept] Int32 Int32N;
        [noexcept] ITest TestN;
    }
}

In Rust, the first batch of methods all return a Result while the second do not:
#[test]
fn test_except() -> Result<()> {
    let test: ITest = Test::default().into();

    test.MethodString(h!("abc"))?;
    assert_eq!(test.String()?, "abc");

    test.MethodInt32(123)?;
    assert_eq!(test.Int32()?, 123);

    test.MethodTest(&test)?;
    assert_eq!(&test.Test()?, &test);

    Ok(())
}

#[test]
fn test_noexcept() {
    let test: ITest = Test::default().into();

    test.MethodStringN(h!("abc"));
    assert_eq!(test.StringN(), "abc");

    test.MethodInt32N(123);
    assert_eq!(test.Int32N(), 123);

    test.MethodTestN(&test);
    assert_eq!(test.TestN().as_ref(), Some(&test));
}

Fixes: #2991

https://github.com/microsoft/windows-rs/pull/3070/commits/7dfe20bae4210df4577e82df731d48d92a41741f adds interop testing against C++/WinRT.


Timedelta as numeric string unparseable?

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Hi! I've upgraded my FastAPI application to use pydantic 2, and I love how strict it is in some aspects, allowing me to find so many inconsistencies in my code I wasn't even aware of.
Straight to the point: I'm having an issue with numeric query strings that Pydantic cannot parse into timedelta objects.
I believe it is because pydantic does not parse numeric timedelta strings at all, so the query string always makes it into a string.
Example Code
from pydantic import BaseModel

class MyClass(BaseModel):
    t: timedelta

# SUCCESS: Expected: t=100 seconds
MyClass.model_validate({'t': 100})
# > MyClass(t=datetime.timedelta(seconds=100))

# FAIL: Expected: t=100 seconds
MyClass.model_validate({'t': '100'})
# Traceback (most recent call last):
#   File "<stdin>", line 1, in <module>
#   File "/Users/jd/Projects/[REDACTED]/.venv/lib/python3.9/site-packages/pydantic/main.py", line 504, in model_validate
#     return cls.__pydantic_validator__.validate_python(
# pydantic_core._pydantic_core.ValidationError: 1 validation error for MyClass
# t
#   Input should be a valid timedelta, "day" identifier in duration not correctly formatted [type=time_delta_parsing, input_value='100', input_type=str]
#     For further information visit https://errors.pydantic.dev/2.3/v/time_delta_parsing

# SUCCESS: Expected: t=100 seconds
MyClass.model_validate_json('{"t": 100}')
# > MyClass(t=datetime.timedelta(seconds=100))

# FAIL: Expected: t=100 seconds
MyClass.model_validate_json('{"t": "100"}')
# Traceback (most recent call last):
#   File "<stdin>", line 1, in <module>
#   File "/Users/jd/Projects/[REDACTED]/.venv/lib/python3.9/site-packages/pydantic/main.py", line 531, in model_validate_json
#     return cls.__pydantic_validator__.validate_json(json_data, strict=strict, context=context)
# pydantic_core._pydantic_core.ValidationError: 1 validation error for MyClass
# t
#   Input should be a valid duration, "day" identifier in duration not correctly formatted [type=time_delta_parsing, input_value='100', input_type=str]
#     For further information visit https://errors.pydantic.dev/2.3/v/time_delta_parsing

Python, Pydantic & OS Version
pydantic version: 2.3.0
        pydantic-core version: 2.6.3
          pydantic-core build: profile=release pgo=false
                 install path: /Users/jd/Projects/[REDACTED]/.venv/lib/python3.9/site-packages/pydantic
               python version: 3.9.13 (main, Sep 14 2022, 15:53:35)  [Clang 14.0.0 (clang-14<IP_ADDRESS>)]
                     platform: macOS-13.5.1-x86_64-i386-64bit
     optional deps. installed: ['typing-extensions']

Hi! Glad the migration is going well overall.
The Pydantic v1 -> v2 migration guide provides this table with information about how Pydantic converts data during validation.
As you can see in the table, if a field is specified as the timedelta type and an int is provided, that int is interpreted as the number of seconds corresponding to the timedelta, hence your first example working. The table also illustrates that when you pass a str in for a timedelta field, it's assumed to be in ISO8601 format. Your second example isn't working because you're expecting the string to be interpreted in seconds.
One potential workaround you could use is the following:
from datetime import timedelta
from typing import Union

from pydantic import BaseModel, field_validator

class MyClass(BaseModel):
    t: timedelta

    @field_validator('t', mode="before")
    @classmethod
    def interpret_t_as_seconds(cls, v: Union[int, str]) -> int:
        try:
            return int(v)
        except ValueError:
            raise ValueError("t must be an int value in seconds")

With this logic, all of the test cases you outlined produce:
MyClass(t=datetime.timedelta(seconds=100))


Added commas in Data.js file

Fixes Issue
Closes #1252

Changes proposed
Previously, anyone setting up the website was not able to see it locally due to errors in the Data.js file (missing commas after some names)
Now, Since i've added the commas, the website can be viewed locally without any errors.

Screenshots

Checklist

[X] You've linked this PR to the correct issue.
[X] You have checked that the code is working correctly.
[X] You ⭐ the repository!

Note to reviewers

@sabhisharma-ise Thanks for this but we don't need this file in new UI.
Closing this as not required!


CMS data - Slider component

I had to add new content in the CMS to then make a new query for my slider component.

Data was succesfully exported to the project


xhr poll error report from user

A user reports the following error when they try to run a paged post list command:
vip --app=774 --env=preprod -- wp post list --post_type=pmc_list_item --posts_per_page=10 --paged=2

I'm enquiring whether it works without --paged and whether they can run other commands. Ping me in Slack for the ticket number 🙂

Added image of error output @nickdaugherty
User can no longer replicate, possibly due to https://github.com/Automattic/vip-go-api/issues/1906

Closing this as a "cannot reproduce."
Also important to note that with the upgrade to 5.2 we get a "Site is experiencing technical difficulties" instead of a Fatal or empty response:
vip --app=774 --env=preprod -- wp post list --post_type=pmc_list_item --posts_per_page=10
Error: The site is experiencing technical difficulties.


Update tutorial: create-and-transfer-an-nft-using-a-solidity-contract to avoid CONTRACT_REVERT

Description
@theekrystallee
This tutorial creates a Token with Precompiles. However, a user reported a CONTRACT_REVERT due to data type mismatch between the .sol file and the  .js file.
Fix:
Add the following two lines to section 3 and code check of the tutorial:

.addInt64(250) // NFT max supply
.addInt64(7000000) // Expiration: Needs to be between 6999999 and 8000001

That will ensure that what the .js file is passing matches what the .sol file is expecting. See details below:
Problem:

Solidity file expecting int64 for the last two inputs for the function that creates the token:

Code snippet in section 3 not passing int64:

Code in the Code Check section not passing int64:

Steps to reproduce
Run the example as is and see contract revert
Additional context
No response
Hedera network
testnet
Version
v2.25
Operating system
Windows

Documentation has been and code sample has been updated in commit 615c7b7


bug: Network pulsechainV4 symbol is incorrect. Currently it is set at v4PLS it should be tPLS

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
If a user does not have the pulsechainV4 network in metamask and the application goes to auto add everything works okay but you get this warning message. "The submitted currency symbol does not match what we expect for the chain ID."
Expected Behavior
No warning should happen
Steps To Reproduce
Connect to http://test.mintra.pro without having the pulsechainV4 network configured. Click the button in the top right hand corner to connect to your wallet
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Feel free to open a PR to fix


Make SecondarySortGroupByKeyDatasetFunctions object private

The intention was for this to be package-private.

Codecov Report

Merging #24 (193fdaf) into main (072acae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   99.67%   99.67%
=======================================
  Files          10       10
  Lines         310      310
  Branches        6        6
=======================================
  Hits          309      309
  Misses          1        1

Impacted Files
Coverage Δ

...ting/SecondarySortGroupByKeyDatasetFunctions.scala
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072acae...193fdaf. Read the comment docs.


Fix mypy 1.1.1 errors, resolved positional Arguments.

Added keywords to resolve positional arguments error.
Closes #658

CI build failure on mypy run. please use the following to invoke mypy as we do in CI:
mypy --config-file .github/mypy/mypy.ini --check-untyped-defs floss/ scripts/ tests/

CI build failure on mypy run. please use the following to invoke mypy as we do in CI:

Looking into it

@williballenthin
The errors due to mypy mentined below have been resolved. Please look at the changes when you have a chance.
run: mypy --config-file .github/mypy/mypy.ini --check-untyped-defs floss/ scripts/ tests/
floss/results.py:193: error: "Type[ResultDocument]" has no attribute "__pydantic_model__"  [attr-defined]
floss/utils.py:310: error: Module has no attribute "builtins"; maybe "isbuiltin"?  [attr-defined]
floss/utils.py:3[13](https://github.com/mandiant/flare-floss/actions/runs/4886852254/jobs/8724169319?pr=720#step:7:14): error: Module has no attribute "builtins"; maybe "isbuiltin"?  [attr-defined]
floss/render/default.py:277: error: "TextIO" has no attribute "reconfigure"  [attr-defined]
floss/render/default.py:308: error: "IO[str]" has no attribute "getvalue"  [attr-defined]
floss/features/features.py:[15](https://github.com/mandiant/flare-floss/actions/runs/4886852254/jobs/8724169319?pr=720#step:7:16)6: error: Argument 1 to "float" has incompatible type "Union[Any, float, None]"; expected "Union[SupportsFloat, SupportsIndex, str, bytes, bytearray, memoryview, array[Any], mmap, _CData, PickleBuffer]"  [arg-type]
floss/main.py:266: error: Module has no attribute "TRACE"  [attr-defined]
scripts/idaplugin.py:[19](https://github.com/mandiant/flare-floss/actions/runs/4886852254/jobs/8724169319?pr=720#step:7:20)4: error: Argument 1 to "apply_stack_strings" has incompatible type "List[TightString]"; expected "List[Union[StackString, TightString]]"  [arg-type]
scripts/idaplugin.py:194: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
scripts/idaplugin.py:194: note: Consider using "Sequence" instead, which is covariant
tests/conftest.py:35: error: Incompatible types in assignment (expression has type "StackString", variable has type "DecodedString")  [assignment]
tests/conftest.py:39: error: Incompatible types in assignment (expression has type "TightString", variable has type "DecodedString")  [assignment]
tests/conftest.py:57: error: LEGACY_PATH? has no attribute "open"  [attr-defined]

Thanks for the Feedback! Looking forward to make more contributions.


XWayland no primary monitor panic

I got panicked at '[winit] Failed to find the primary monitor' this morning in a gnome 3.26 xwayland session.
...
   5:     0x55b950a664f6 - std::panicking::begin_panic::h697a7df9d6f5bf31
                               at /checkout/src/libstd/panicking.rs:538
   6:     0x55b950a616ce - winit::platform::platform::x11::monitor::get_primary_monitor::hf9d328fd4ff4d083
                               at /home/alex/project/winit/<panic macros>:3
   7:     0x55b950a61369 - winit::platform::platform::EventsLoop::get_primary_monitor::h4b1d199c535a7ed8
                               at /home/alex/project/winit/src/platform/linux/mod.rs:357
   8:     0x55b950a67f5e - winit::EventsLoop::get_primary_monitor::h701a7426af0bcdb9
                               at /home/alex/project/winit/src/lib.rs:210

It seems that this is somewhat correct, in that for some reason my sole monitor XWAYLAND0 was not marked primary in xrandr. When I used xrandr to mark it primary manually this panic does not occur.
However, since get_primary_monitor does not return a Result this seems poor behaviour from winit from a user perspective.
I suggest we simply use the first available monitor as fallback for x11 primary not existing, or change this method return a Result.

I think #318 is a reasonable fix for this issue, as monitors can be connected with none primary as reported.
Or perhaps we should always return an Option<MonitorId> to force explicit handling of this by winit consumers?


combined index where equal on one part and sorted on the other

I have some kind of a logging table in Dexie and every entry in those logs is identified by a logId and a logdate. I would like to find the first date and last date for a given logId. I guess this could be optimized by indexes, but I don't know how to do it in Dexie. I have been trying to create a combined index and only pass the logId to the WhereClause.equals, but that does not seems to work, is there any other solution?

You would need to use a compound index. The built-in ordering will always be on the same index that you query in the where-clause. How to utilize this in a query is not obvious but you can do a between()-query and between the lowest and highest possible dates:
// schema
var db = new Dexie("logdb");
db.version(1).stores({
    log: 'id,[logId+logDate]'
});

var MIN_DATE = new Date(1970, 1, 1),
    MAX_DATE = new Date(3000, 1, 1);

function getMostRecentLogEntry(logId) {
    return db.log
        .where('[logId+logDate]')
        .between([logId, MIN_DATE], [logId], MAX_DATE)
        .last();
}

function getOldestLogEntry (logId) {
    return db.log
        .where('[logId+logDate]')
        .between([logId, MIN_DATE], [logId], MAX_DATE)
        .first();
}

In case you store dates as plain Numbers:
return db.log
        .where('[logId+logDate]')
        .between([logId, -Infinity], [logId], Infinity)
        .last();

Noticed you actually only needed the last date on a particular logId. You could get that even more optimal:

db.log
    .where('[logId+logDate]')
    .between([logId, -Infinity], [logId, Infinity])
    .lastKey()
    .then(function (logIdAndDate) {
        return logIdAndDate[1]; // return just date
    });

Notice that compound indexes for doesnt work on IE, Edge or Safari. In that case you can build your compound index manually by concatenating logId+date into a property and index that property.

thanks, this was what i was looking for.
i am currently only using opera (so chromium), it's just some tool for myself for now so no need for advanced crossbrowser support.
btw I had index called dateTime, but this did not seem to work on a combined index, but it did seem to work as a single index.

The index names are case sensitive. But no restriction on property names. Just make sure to declare and use the index as exactly "[logId+dateTime]" without any space character. Good luck with your tool.


tutorials: Promote AvalancheGo installer as first/default method

I believe it's just an accident of history that the manual instructions were at the top of the list. The installer script is easier, and more reliable.

Weighing in here -- I like having manual instructions at the top just because I was looking to dev on Avalanche-Go. But if the main audience of the docs are people who want to just get their node up and running, then I think this is a great improvement

Weighing in here -- I liked having manual instructions at the top just because I was looking to dev on Avalanche-Go. But if the main audience of the docs are people who want to just get their node up and running, then I think this is a great improvement

I agree with you and will close this PR and leave it as is.

Thanks for reconsidering.


Update Kubernetes repository

Kubernetes has moved to the equally named kubernetes Github organization. Let's get rid of one needless redirect. :-)

Thanks!


Added BreachCheck.io in Leaks Section #244

Closes: #244

Thanks @ChandanChainani for your contribution! appreciated


GoogleNews search is not working, please help

googlenews.search("<any keyword") is giving "'NoneType' object is not iterable" in Python

Are you using the latest version? I can see both .get_news() and .search() can return a list of result with latest version

Hi, am using version 1.6.9

Try to use browser to open google and search something with same pc, and check whether Google does robot verification or not. This may be Google recognize your behaviour as robot and do extra verification, then will cause this issue. Otherwise it seems not code issue.

No I am not getting any message about Google doing robot verification, can search as usual on browser
also same issue in multiple systems
have also tried with different internet connections

user_agent = 'Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:64.0) Gecko/20100101 Firefox/64.0'
headers = {'User-Agent': user_agent}
url='https://www.google.com/search?q=%3Cany%20keyword&lr=lang_en&biw=1920&bih=976&source=lnt&tbs=lr:lang_1en,qdr:10d,,sbd:1&tbm=nws&start=0'
req = urllib.request.Request(url.replace("search?","search?hl="+self.__lang+"&gl="+self.__lang+"&"), headers=headers)
response = urllib.request.urlopen(req)
page = response.read()

Try this code and see whether you can get the details

"self" is not defined, can I change it to "en"?

"self" is not defined, can I change it to "en"?

yes, just set your language

it ran, there is an output for page which is a huge chunk of string like this "b'<!doctype html><any keyword - Google Search

Hi, any ideas?

try to open the url directly, and then find some title, try to search the title in this string, or you can try the source code https://github.com/Iceloof/GoogleNews/blob/master/GoogleNews/init.py


Integrate CronJob + garbage collector

The e2e chart currently uses a DaemonSet with the spotify-gc container to clean up stale Docker image layers and keep the graph from getting too large. But this is clumsy; it continually fails and CrashLoops with an exponential backoff that becomes stupidly large very quickly.
There must be some way to use the new CronJob construct to run a garbage collector sidecar on each node with a regular schedule.

PR issued in https://github.com/kubernetes/charts/pull/982; chart installed on leeroy/staging cluster and docs updated with this info.

Oops; accidentally closed.  TODOs remaining for this issue are:

remove sidecar container from workflow-e2e chart
ensure spotify-docker-gc chart is installed on any leasable e2e clusters

This needs to wait until the chart is in stable; see https://github.com/kubernetes/charts/pull/982

Work completed in https://github.com/deis/workflow-e2e/pull/362 ; closing.


[BugFix] make config enable_new_publish_mechanism static

Why I'm doing:
Fe config enable_new_publish_mechanism can't support dynamic modify, because we need to rebuild transaction dependency before switch to new publish mechanism. We support rebuild transaction dependency when config change after version 3.2+, but now we don't plan to support it in 2.5/3.0/3.1.
What I'm doing:
Make enable_new_publish_mechanism become static config. So if we want to enable enable_new_publish_mechanism, we have to restart FE, and transaction dependency will rebuild when restart.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

@mergify rebase branch-3.1

@mergify rebase branch-2.5

@Mergifyio backport branch-3.0