Treasure Dungeon Maturity + POTD Modules

Accidentally left the maturity of the module as a WIP, when it was very much done. Noticed it while I was doing treasure dungeons just now XD

To better summarize all of this at once (because it's a lot)
-> Originally updated the maturity of the floor 100 treasure dungeon boss 1 (still missing boss 2)
POTD wise:
-> Created floors 160, 170, 180, 190.
-> Updated floor 80 to match the standard that I created on floor 180, and added a hint system that tells you what the following attacks are going to be/where the cleaves that behemoth does on both floor sets (both have a different rotation of attacks they do before they do the cleave, and floor 80 cleaves E -> W -> E.. vs floor 180 does S -> N -> S...
-> Floor 190 wise added an enrage timer for the bombs that need to be killed, and also while the boss is casting the attack that needs stunned.
-> Last thing was added the list of waypoints that they stun bomb spawns on floor 190, need to go back through when I get some free time and add a minimap hint where the stun bomb will be, that way if desired can pre-position the boss onto it to not have to worry about trying to KB the ad into the boss.


Update PyTorch notebook

Fix for https://github.com/opendatahub-io/notebooks/issues/98
This PR includes the following changes:

PyTorch is now being installed from the Torch repository instead of PyPI.

Package updates:

torch = "~=1.13.1" to torch = "~=2.0.0"
torchvision = "~=0.14.1" to torchvision = "~=0.15.1"

The parent image has been changed, it is now derived from the cuda-data-science notebook.

Updated the piplock files

Updated the build tree on the readme.md

Merge Note: Should be merged first the CI PR: https://github.com/openshift/release/pull/40199
IMPORTANT NOTE: This PR includes a MAJOR update to the PyTorch notebook, according to the update guidelines  it should be included in the next release to prevent any development and user impact.
How Has This Been Tested?
PyTorch Installation via Torch repocitory:

Spin up the new PyTorch notebook:

Merge criteria:
Note: Should be merged first the CI PR: https://github.com/openshift/release/pull/40199

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/retest-required

It replaced by this one: https://github.com/opendatahub-io/notebooks/pull/133


Encode all join conditions in a single expression field

Which issue does this PR close?

Closes #7611 .
Rationale for this change
For ~more efficient~ fixing the incorrect representation of join condition. Please refer to the related issue for more details.
What changes are included in this PR?

Producer: instead of encoding the join on and filter separately in expression and post_join_filter, this PR encodes both in the expression field of the JoinRel.
Consumer: Adds a check for in each part of the conjunctive JoinRel expression. If the sub-expression is a Column Eq Column expression, then it gets added to the on field, otherwise, it gets AND-ed with the filter field.

Are these changes tested?
Yes.
No new tests were added. Since the producer now hardcodes post_join_filter as None, if the changes are not working correctly, the existing would fail.
Are there any user-facing changes?

No

Thank you @nseekhao and @Dandandan
I think this code could be made simpler and left some suggestions about how to do so.
That being said the only thing I think is needed prior to merge is some tests (so we don't break this code in some future refactoring). I don't think the simplifications are necessary

I don't mind simplifying the code so I'll work on it following your earlier suggestions.
As for the tests, I agree. Since, existing cases already test for mixed join condition (roundtrip_non_equi_join()) and non-equi-only join (roundtrip_non_equi_inner_join()), are you thinking a new set of tests that specifically test for the absence of post_join_filter? Or did you have something else in mind? Thanks!

I don't mind simplifying the code so I'll work on it following your earlier suggestions.

Thank you! BTW I found the relevant code to extract equijoins predicates here: https://docs.rs/datafusion/latest/datafusion/optimizer/extract_equijoin_predicate/struct.ExtractEquijoinPredicate.html

are you thinking a new set of tests that specifically test for the absence of post_join_filter

Yes I guess I was thinking about that. Mostly I was thinking "if we broke / reverted the code in this PR accidentally, how would we know something wasn't correct"? Without some test coverage the behavior could change and we don't know.

Marking as draft as I believe this PR is not waiting for any feedback (there are some comments to address). Thanks again for pushing this forward @nseekhao

@alamb I extracted the predicate splits from the from_substrait_rel() so the code is easier to read. Unfortunately, I couldn't use the function split_eq_and_noneq_join_predicate() (from your ref) directly because the function will put the equal condition with nulls_equal_nulls = true (IsNotDistinctFrom) into a join filter, as opposed to putting it in the join condition.
As for the test, I added a test function to be used when join has a non-equi condition, to ensure that the join filter does not mistakenly get embedded into a Substrait plan as a post_join_filter. LMK if this is what you had in mind, otherwise we can discuss further changes. Thanks for the review!

I have merged up from main and plan to merge this PR once CI passes

I will propose a follow on PR that uses the newly added LogicalPlanBuilder::join_on to simplify it subsequently

I tried this and it turns out there is some subtlety involved with a = a vs a IS DISTINCT FROM that I was not able to solve when trying to simplify.

Thanks again @nseekhao


Fix ../test/recipes/80-test_ssl_old.t with no-ec build

On Tue, Dec 26, 2017 at 11:44:57AM -0800, Bernd Edlinger wrote:

=> openssl ciphers  ALL |sed 's/:/\n/g'|grep EC
ECDHE-ARIA256-GCM-SHA384
ECDHE-ARIA128-GCM-SHA256

Those ciphers should be inside an #ifndef OPENSSL_NO_EC in s3_lib.c

I wonder if we should also put the SSL_kECDHE define inside an
#ifndef OPENSSL_NO_EC, to prevent something like this.

Boah, yes!
But funny other ECDHE ciphers there are not #ifndef OPENSSL_NO_EC
And I wonder if the code at line 412 is not just papering over another problem...
Now this issue has my attention.

See #4981 for an alternate approach on fixing this.


Help Adding FirstEnergy Support

I am attempting to add support for FirstEnergy which has the following electric companies:

Ohio Edison
Illuminating Company
Toledo Edison
Met-Ed
Penelec
Penn Power
West Penn Power
JCP&L
Mon Power
Potomac Edison

The problem is all the r8loFrsvDB-? values in the POST body are created by javascript as far as I can tell. I tested by disabling javascript and the post failed with these values missing.
Login URL:
https://www.firstenergycorp.com/log_in.fecorplogin.html
Login Post Example:

Once logged in you can see they do make calls to opower.com, so this should be a valid provider.

I'm hoping the community could help come up with a way to get around this issue.

See https://github.com/tronikos/opower/discussions/19

@tronikos Thanks, I guess I should've checked the closed issues before posting. Not looking good for the FirstEnergy users... 🙁


Docs: Fix typo

Description

This PR updates Incorrect spelling in doc blocks.
Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mukeshpanchal27 thanks for the contribution, are you planning to work more on this PR? If not, please fill out the PR description and mark it as ready for review. If yes, please carry on, thanks again!

@dhruvkb The PR is ready for review.


E107: Missing braces: vundle#rc()

My .vimrc contains:
set rtp+=~/.vim/bundle/vundle/
call vundle#rc()
And the vundle repository is cloned in .vim/bundle/vundle as required.
When starting vim, I do not understand why I am receiving the error:
E107: Missing braces: vundle#rc()
After which none of the Bundle functions are recognized.
Any ideas on how I should troubleshoot this?

Ah. Needed to upgrade Vim to newer version (6.3 doesn't cut it).


MEMBERSHIP: luebken

GitHub Username
@luebken
Requirements

[x] I have reviewed the community membership guidelines
[x] I have enabled 2FA on my GitHub account
[x] I have joined the Crossplane slack channel
[x] I am actively contributing to the Crossplane project
[x] I have two sponsors that are current Crossplane Org members
[x] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application

Sponsors

@jbw976
@muvaf

List of contributions to the Crossplane project

Docs survey
Docs improvements

An invitation has been sent to you @luebken to join the Crossplane org :)


Python3.7 not found because INSTSONAME does not contain the full path

Which OS: Ubuntu 19.10
Which VSCode version: 1.40.1
Which extension version: 1.4.0
Which adapter type: native
Which LLDB version: 9.0.0
What is the problem and how did you get there:
I can't debug Rust code properly, because the variable view is very raw. The debugging console told me Could not initialize Python interpreter - only native expressions will be available. even if Python 3.7 was installed.
Another output for the LLDB plugin was [2019-11-21T11:21:45Z ERROR codelldb] load_python: Internal("\"/home/thomas/.vscode/extensions/vadimcn.vscode-lldb-1.4.0/adapter2/libcodelldb_python.so: undefined symbol: PyTuple_SetItem\"")
So I checked how Python is located (and if I can adapt it) and found
https://github.com/vadimcn/vscode-lldb/blob/81dff34c846f85050493b8c071e87f1fd75b074a/adapter2/loader/find_python.rs#L45
As far as I can tell, the executed Python code only returns the file name, but not the complete path on my system.
$ python3 -c 'import sysconfig; print(sysconfig.get_config_var("INSTSONAME"))'
libpython3.7m.so.1.0

As far as I understand the load_library function, the full path is required. See also a similar discussion on Stackoverflow: https://stackoverflow.com/questions/33517158/how-to-get-the-path-of-the-python-library-from-within-python
(I could not find any official documentation on this in the Python docs)

I downgraded the version of CodeLLDB to 1.3.0 and now it works again on the same environment.

On Linux, loading by filename seems to works fine.
Do you actually have libpython3.7m.so.1.0 on your system?    Please note that installing the python3.7 package does not necessarily install libpython3.7.

The library is present /usr/lib/x86_64-linux-gnu/libpython3.7m.so.1.0 and the libpython3.7 package is installed.
After upgrading to 1.4.1, I still get the Could not initialize Python interpreter - only native expressions will be available. error but the other error message slightly changed.
[2019-11-25T09:19:26Z ERROR codelldb::debug_session] Initialize Python interpreter: Internal debugger error: Error:  Fail
Error Message:
error: module importing failed: loading unimplemented

What happens if you add "lldb.libpython": "/usr/lib/x86_64-linux-gnu/libpython3.7m.so.1.0" to workspace settings?

I tried setting the absolute path and the Python errors went away and there is output hinting to that everything is initialized:
INFO(Python) 10:10:06 rust: Initializing, module name=rust
DEBUG(Python) 10:10:06 rust: attaching summary get_tuple_summary to "^\(.*\)$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StrSliceSynthProvider to "&str", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StrSliceSynthProvider to "&str", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StrSliceSynthProvider to "str*", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StrSliceSynthProvider to "str*", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdStringSynthProvider to "collections::string::String", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdStringSynthProvider to "collections::string::String", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdStringSynthProvider to "alloc::string::String", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdStringSynthProvider to "alloc::string::String", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdVectorSynthProvider to "^collections::vec::Vec<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdVectorSynthProvider to "^collections::vec::Vec<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdVectorSynthProvider to "^alloc::vec::Vec<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdVectorSynthProvider to "^alloc::vec::Vec<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic SliceSynthProvider to "^&(mut\s*)?\[.*\]$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_SliceSynthProvider to "^&(mut\s*)?\[.*\]$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic SliceSynthProvider to "^slice<.+>.*$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_SliceSynthProvider to "^slice<.+>.*$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdCStringSynthProvider to "std::ffi::c_str::CString", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdCStringSynthProvider to "std::ffi::c_str::CString", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdCStrSynthProvider to "std::ffi::c_str::CStr", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdCStrSynthProvider to "std::ffi::c_str::CStr", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdOsStringSynthProvider to "std::ffi::os_str::OsString", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdOsStringSynthProvider to "std::ffi::os_str::OsString", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdOsStrSynthProvider to "std::ffi::os_str::OsStr", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdOsStrSynthProvider to "std::ffi::os_str::OsStr", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdPathBufSynthProvider to "std::path::PathBuf", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdPathBufSynthProvider to "std::path::PathBuf", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdPathSynthProvider to "std::path::Path", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdPathSynthProvider to "std::path::Path", is_regex=False
DEBUG(Python) 10:10:06 rust: attaching synthetic StdRcSynthProvider to "^alloc::rc::Rc<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdRcSynthProvider to "^alloc::rc::Rc<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdRcSynthProvider to "^alloc::rc::Weak<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdRcSynthProvider to "^alloc::rc::Weak<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdArcSynthProvider to "^alloc::(sync|arc)::Arc<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdArcSynthProvider to "^alloc::(sync|arc)::Arc<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdArcSynthProvider to "^alloc::(sync|arc)::Weak<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdArcSynthProvider to "^alloc::(sync|arc)::Weak<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdMutexSynthProvider to "^std::sync::mutex::Mutex<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdMutexSynthProvider to "^std::sync::mutex::Mutex<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdCellSynthProvider to "^core::cell::Cell<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdCellSynthProvider to "^core::cell::Cell<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdRefCellSynthProvider to "^core::cell::RefCell<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdRefCellSynthProvider to "^core::cell::RefCell<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdRefCellBorrowSynthProvider to "^core::cell::Ref<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdRefCellBorrowSynthProvider to "^core::cell::Ref<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdRefCellBorrowSynthProvider to "^core::cell::RefMut<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdRefCellBorrowSynthProvider to "^core::cell::RefMut<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdHashMapSynthProvider to "^std::collections::hash::map::HashMap<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdHashMapSynthProvider to "^std::collections::hash::map::HashMap<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching synthetic StdHashSetSynthProvider to "^std::collections::hash::set::HashSet<.+>$", is_regex=True
DEBUG(Python) 10:10:06 rust: attaching summary _get_synth_summary_StdHashSetSynthProvider to "^std::collections::hash::set::HashSet<.+>$", is_regex=True

I can't test if debugging actually works, because the program freezes every time I hit a  breakpoint (the variables and the execution stack are not visualized, the program just does not proceed any more).  If the lldb.libpython configuration is not set, pausing at a break point works. I'm not sure if this is related at all, but in 1.3.0 I had no problem with actually pausing the program. Maybe evaluation some expressions with Python fails?

My follow-up issue seems to be the same as  #231.

Hmm, looks like loading by dylib name alone does not work in Ubunty 19.10.

I downgraded to 1.4.0 do avoid #231 and with the "lldb.libpython" it works. Thanks for pointing out the parameter, I missed it when reading the documentation.
I'm not sure how Ubuntu 19.10 changed the loading behaviour, and finding the full path is even more cumbersome because of the different locations it could be (e.g. the proposed get_config_var("LIBDIR") returns the wrong /usr/lib on my installation). Maybe you can try a fixed set of possible locations and if none works, mention the "lldb.libpython" parameter in the error message.

Wondering if you are still having this problem in 1.4.3?

Works perfectly fine on my system with 1.4.3 without any manual configuration. Thanks a lot for fixing this!


Distinct Support

Add support for SELECT DISTINCT. Mostly via an optional request option similar to orderBy.
Will want to ensure it's support by both topResource & subResource in complexResources (read subqueries).

Likely needs a ternary here:
https://github.com/sudowing/service-engine/blob/develop/src/database.ts#L30

Resolved in Pull-Request #66


allow accessing interfaces before setting a config

Hi! I'm porting a library that needs to access interfaces (to detach kernel drivers, etc) before calling device.setConfiguration().
usb currently doesn't make that possible... I'd suggest a fix like this one.

This is also needed to claim interfaces without setting a configuration.
As indicated by libusb documentation, setting configuration causes a lightweight device reset, which may be undesirable.

Bump!

@mildsunrise is this still something you want attention on?

Hey sorry about the silence, I just don't know what to do with this.
This PR attempts to fix some of the issues detailed in #381, but ultimately the problem lies in the API.
Things have changed since I opened this, we now offer the WebUSB API which does not have these issues.
So I think a better approach is to make WebUSB work correctly (right now it doesn't seem to, since it uses the legacy API underneath) and then deprecate (or even freeze) the legacy API. @kevinmehall's comments in #401 seem to point in that direction.

and then deprecate (or even freeze) the legacy API

I was wondering if the legacy API should literally be the exposure of choice libusb functions?
One drawback to removing this API is the loss of the non-blocking usb access this allows.

exposure of choice libusb functions

what does 'choice libusb functions' mean? you mean the bits that are not exposed by WebUSB?

One drawback to removing this API is the loss of the non-blocking usb access this allows

I'm also having trouble following here, isn't WebUSB also a non-blocking API?

what does 'choice libusb functions' mean? you mean the bits that are not exposed by WebUSB?

I mean a raw interface that resembles common, low-level libusb calls.

I'm also having trouble following here, isn't WebUSB also a non-blocking API?

I believe many of the legacy usb calls (e.g. getDeviceList()) return synchronous data from the kernel cache. Calls such as requests for strings need to interrogate the device so are async/blocking.
As WebUSB needs a lot of data loaded up to satisfy the device model, there's a lot more device access.

Ah, I see. Well... if we could go back in the past, I do agree that the legacy API should've just been a raw interface to libusb, with very little "magic".
But well, we ended up with this, and I think adding it now (either as a 3rd API, or by removing the current legacy API) would confuse users more. Maybe we could extend WebUSB with the libusb-specific bits it lacks? WebUSB looks close to a raw interface, we'd only have to give the option to disable the 'high-level' behaviour (basically the loading of string descriptors?)

OK, lets keep the legacy API (perhaps it should be called raw API?). I'm reluctant to extend the WebUSB API too much as it's already a standard and introduces incompatibility with the browser implementations.

...a better approach is to make WebUSB work correctly (right now it doesn't seem to...

Would you mind outlining how this doesn't work in a little more detail. Perhaps expanding #381 a little more with specific cases?

I'll close this for now and attack #381 issues considering the WebUSB API too.


[DNM] Demo clearTimer is not called for single_response message

This is just to demo the cancelTimer issue with single response requests.
Whenever we break inside for loop of eth2ResponseDecode, pipe decides to finish everything and cancelTimer is not called after for await

I've opened up issue for this: https://github.com/alanshaw/it-pipe/issues/3
It appears like bug but it might be like that by design not sure.

we should use controller.abort() instead of break in order for functions after for await gets called.


Adding structure to code base

Adding some additional structure to the source tree.  Since C++ doesn't have "modules" the closest we can do to help organize the code is to use directory hierarchy and namespaces where appropriate.  Also renamed all C++ headers to .hpp to avoid any confusion with pure C headers (typically .h) in the future.
Additions
Restructured code files
Removals
Removed HY_CatchementDivide.hpp/cpp since we have HY_CatchmentDivide.  Moved all relevant details into HY_CatchmentDivide.hpp
Changes

Testing

None at this time

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Yes, git moves essentially requires a delete and add. One delete is
permanent, hy_catchementdivide, because it was mislabeled and had the
correct hy_catchmentdivide so I moved the required code and deleted the
misspelled files.
On Thu, Feb 27, 2020, 10:34 AM Z<EMAIL_ADDRESS>wrote:

@ZacharyWills commented on this pull request.
These deletes are are just the changes to .hpp right? These serve the same
purpose?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/ngen/pull/19?email_source=notifications&email_token=ABHSIV2R4Z2QNG2UIFELOSLRE7TS3A5CNFSM4K44ZNCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXG5MYQ#pullrequestreview-365811298,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHSIV5V7WLSZBNLUXYMNSDRE7TS3ANCNFSM4K44ZNCA
.

I forgot to update all the includes to use the new .hpp extension I renamed to, so I need to push that commit before this is merged.

@robertbartel The models/hymod/include/Hymod.h, while technically c++ code, is also intended as an external binding so I did not change its extension.  The NGenConfig.h.in I wasn't sure of its full scope so I didn't change it yet, feel free to adjust that one.


The error with float32 rendering appeared

The error showed itself again
https://github.com/edgedb/edgedb-ui/pull/214

I'm using EdgeDB Cloud, version 3.2

Ok, should be fixed now. The latest ui updates hadn't been deployed to the cloud.

Сan be closed, I checked, the fixes are already applied :ok_hand:


New Requirement: When Click a CircularMenuItem then reduce Circular to its original state

Hello,
I like very much your circular_menu.
Is it possible to add a boolean trigger in the CircularMenuItem which indicates the CircularMenu Button to close/reduce to its original (not clicked) state?
Many Thanks
Roman

I second this. Example: one of the buttons navigate to another page/route, and when I navigate back, the menu is still in 'open' state. Maybe this can be controlled from toggleButtonOnPressed function? Thanks for great module btw.


Adding book recommendation

Description
The book recommendation feature provides users with a curated list of book suggestions tailored to their genre preferences. Users can explore these recommendations, each accompanied by essential details like title, author, publication year, average rating, and a brief description. This feature aims to facilitate users in discovering new books aligned with their interests, enhancing their reading experience by offering personalized suggestions within their preferred genre. We will provide a user preference form or bar where users can enter their preferences or select genres. Based on this input, we will recommend books matching their chosen genres.
Fixes:  #655

Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ x ] I have made this from my own
[ x ] I have taken help from some online resourses
[ x ] My code follows the style guidelines of this project
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Conflicting files
assets/css/style.css
index.html
Solve this conflicting issues & raise PR again.


flutter app not running when this library imported ver 1.1.7+2 get pub worked but 7+3 downloading

Compiler message:
../../flutter/.pub-cache/hosted/pub.dartlang.org/page_transition-1.1.7+3/lib/src/page_transition.dart:62:11: Error: No named parameter with the name
'reverseTransitionDuration'.
reverseTransitionDuration: reverseDuration,
....................................................................................

reverseTransitionDuration added after flutter 1.22 stable. Are you using old version of flutter ?

No , now i am using older version (1.1.7+2)
its working perfectly fine

No , now i am using older version (1.1.7+2)
its working perfectly fine

I mean flutter version. Can you run flutter doctor -v and put here results.

[✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.7 19H2, locale en-AE)
• Flutter version 1.17.5 at /Users/ali/Desktop/flutter
• Framework revision 8af6b2f038 (6 months ago), 2020-06-30 12:53:55 -0700
• Engine revision ee76268252
• Dart version 2.8.4
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/ali/Library/Android/sdk
• Platform android-30, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.5, Build version 11E608c
• CocoaPods version 1.9.1
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.52.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.17.0

@marzookavc as you see your Flutter version is too old. reverseDuration property is added after flutter 1.22 stable. If you upgrade your version you will not face this issue. Or you can keep it with page_transition 1.1.7+2


add goimports package

Add a package for goimports.

@jagajaga :+1:

Thanks. But squash commits please.

@jagajaga done, thanks

Oh, I'm sorry, but can't this pkg be built with buildGoPackage? https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/go-packages.nix

There's a reason I didn't use buildGoPackage... but that reason is probably 'I am dumb and still don't grok nix syntax'. I don't really mind taking another stab at it though, I'll close this PR for now.

I'll pack it.

It's fine, thanks.


Add addresses in Flint, MI

Status:

[ ] Research sources and propose best source (and it's data license)
[ ] Review proposed source
[ ] Approve source based on review comments
[ ] Add to OpenAddresses

NOTE: Proposed source notes should include basic column mapping to OpenAddress data model.

emailed Planner II- Kevin Schronce<EMAIL_ADDRESS>11/4/2016

http://services3.arcgis.com/blE8NdGZSd9Sfngv/arcgis/rest/services/genParcels/FeatureServer/0
but a token is required?

Is there a web view of these? We have dealt with tokens before like this: https://github.com/openaddresses/openaddresses/pull/2079

Not sure where I found this last night, but this has their parcels: http://flint.maps.arcgis.com/apps/webappviewer/index.html?id=6b818d399713408f92dc897d80e283bd
**You are going to have to exaplin how you do this magic.

Here's the entirety of Genesee County's parcels, about 190k records:
http://services2.arcgis.com/5ckbIY7K9TUKoseK/ArcGIS/rest/services/Parcels/FeatureServer/0


Progress on upload

User story

Story

As a user of Swarm, I want to know the progress of my upload without having knowledge of bee internals, such that I know when the upload is finished and I can estimate how long it will take until it is finished.
Acceptance criteria

Based on the information in tags, we can create a progress bar that shows percentage until completion
This information, does not rely on bee-internals (as the current tag implementation does)
An upload that is complete shows 100% completion

Background

In https://github.com/ethersphere/bee/issues/893, @janos explained that tags can show as if no progress is made anymore, but in fact this is expected behavior if the content is already pushed before.
A dapp developer wants to rely on this information to trigger other actions

Tasks

Task
Assignee
Done (1), or 0

@zelig an d@eknir sync on this together, to look at the design of the API and implementation. Basically, figure out if design is good enough.

Related: #1007

There has been a meeting with @zelig and @janos , where we spoke about the following:
Architecturally, tags are not implemented in the most optimal form. It would be most perfect to make a service out of tags and inject that service into the components that use tags, instead of passing around state.
@janos, could you please write down succinctly (in a comment under this issue), the architecture you have in mind, together with a crude estimation (in developer days) to complete this architecture?
@zelig mentioned that something that should happen anyways is to only increment tags upon the first attempt sending attempt. Here, I would like to put my question mark, as in the past, it has proven useful for spotting problems to know that the node is continuously attempting to send.
Continuing on this thought, what should be ultimately useful for the user is the tag.Synced counter, as this counter gives the user the guarantee that the content is synced (and hence available).

There has been a meeting with @zelig and @janos , where we spoke about the following:
Architecturally, tags are not implemented in the most optimal form. It would be most perfect to make a service out of tags and inject that service into the components that use tags, instead of passing around state.
@janos, could you please write down succinctly (in a comment under this issue), the architecture you have in mind, together with a crude estimation (in developer days) to complete this architecture?
@zelig mentioned that something that should happen anyways is to only increment tags upon the first attempt sending attempt. Here, I would like to put my question mark, as in the past, it has proven useful for spotting problems to know that the node is continuously attempting to send.
Continuing on this thought, what should be ultimately useful for the user is the tag.Synced counter, as this counter gives the user the guarantee that the content is synced (and hence available).

The idea about Tags service is to avoid passing the Tag instance, which includes storage.StateStorer among other fields. This would bring more clarity where tags are used and how the state is managed.
The Service would allow implementation which is responsible to store and manage tags and their counters just by their references (IDs or associated address). The Service would be injected into other components that need to query or update tags. Also the Service could contain the iterator method on the tag that would send counter changes in a channel or a callback function in order to be streamed to the caller, similarly to what localstore subscriptions work. This can be used for a websocket tag endpoint, for example, as a convenient endpoint for a user to track the progress.
The service would be responsible for persistence, or no-persistence, purging of old tags, among basic functionality to manage their state.
This is just a description of idea, I did not write the exact interface with expected methods. This would be defined if this approach is accepted and delegated. Even this was informally discussed last year in several occasions, mostly when larger changes to tags were made.

The idea about Tags service is to avoid passing the Tag instance, which includes storage.StateStorer among other fields. This would bring more clarity where tags are used and how the state is managed.
The Service would allow implementation which is responsible to store and manage tags and their counters just by their references (IDs or associated address). The Service would be injected into other components that need to query or update tags. Also the Service could contain the iterator method on the tag that would send counter changes in a channel or a callback function in order to be streamed to the caller, similarly to what localstore subscriptions work. This can be used for a websocket tag endpoint, for example, as a convenient endpoint for a user to track the progress.
The service would be responsible for persistence, or no-persistence, purging of old tags, among basic functionality to manage their state.
This is just a description of idea, I did not write the exact interface with expected methods. This would be defined if this approach is accepted and delegated. Even this was informally discussed last year in several occasions, mostly when larger changes to tags were made.

We spoke about this feature today in the backlog refinement and agreed that we should distinguish the user focused feature with "get status of upload" with the more debug related things for tags (e.g. sent is continuously incrementing).
I would propose to continue with @zelig s comment to ensure that state.sent only increments once and then expose via some other endpoint the information of how often our node is attempting to sent.

We spoke about this feature today in the backlog refinement and agreed that we should distinguish the user focused feature with "get status of upload" with the more debug related things for tags (e.g. sent is continuously incrementing).
I would propose to continue with @zelig s comment to ensure that state.sent only increments once and then expose via some other endpoint the information of how often our node is attempting to sent.

I have an additional question on the Seen status. To me, this also smells like bee-internals and should probably not be exposed to our users. However, if I'm correct, the Bee node currently won't reupload content it has already seen, so without the Seen status, a user might be clueless as to why the upload is not completing. A related issue is #1051, as this issue will change the behavior of the node to reupload content, even if it is already seen.

I have an additional question on the Seen status. To me, this also smells like bee-internals and should probably not be exposed to our users. However, if I'm correct, the Bee node currently won't reupload content it has already seen, so without the Seen status, a user might be clueless as to why the upload is not completing. A related issue is #1051, as this issue will change the behavior of the node to reupload content, even if it is already seen.


refactor(core): delegate the otrs configuration to the host app

Delegate configuration
:nail_care: Refactor
2dccfa9 - refactor(core): delegate the otrs configuration to the host app
f1c3c3e - refactor(apps.public.cloud): move components into one module
:house: Internal

No QC required.

:boom: Breaking Change

OTRS configuration no more rely on core module

Rebased on 7ef3b3fbeeb7e42051f31c6ecea6f59d57d3aa30 (since #640 was merged).

Hello @antleblanc,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3


Ability to pin gateway container to a specific node

During creation of a gateway, can be configured to be deployed on a specific node.
To expose the functionality here: https://github.com/openvcloud/openvcloud/issues/20

already the case.


Add pipeline

Description
Please provide a description of the changes you have made in this PR.
How has this been tested?
Please explain how you have tested the new changes.
Checklist

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes (make test-trigger and make test-all-components)
[ ] I have successfully run the E2E tests
[ ] I have updated any relevant documentation to reflect my changes

/gcbrun


Make "index" available in "options"-slot within the list

Hey @shentao and team!
First up, thanks for this package. I like the usage of slots here! It makes it quite easy to modify the behavior the way you wish to.
I'd like to request having access to the index within the slot named "option".
You actually get the index in the surrounding
 for loop, so I guess it should be a simple change from
<slot name="option" :option="option" :search="search">
  {{ getOptionLabel(option) }}
</slot>

to
<slot name="option" :option="option" :search="search"  :index="index">
  {{ getOptionLabel(option) }}
</slot>

Is there an argument against it?
I'd offer to create a PR for that.
Cheers and thanks again.

Hey! That sounds like a good idea. I don’t think there is anything preventing that change. Feel free to open a PR. Though be warned, it might take a few weeks before I will be able to release it... Lately, I’m a bit behind on this project.

@shentao I am glad that you like the idea.
I'd like to work on the project, but in relation to this issue: https://github.com/shentao/vue-multiselect/issues/1241 and some linting errors during npm run dev, I can't get the dev environment to work properly.
I'll try to resolve the issues during the weekend, if there is no quick fix on your part. Hopefully I can commit something useful :).
Nonetheless, thank you again for taking the time.

That would be great! The issues most likely come from automatic updating the dependencies (had to disable the dependabot as it turns out, even minor updates can cause breaking changes...).

Hey again @shentao. I am trying to fix the dev env with this PR https://github.com/shentao/vue-multiselect/pull/1251. If this looks good to you, I would create another PR for this topic on the basis of that commit :).

Reviewed – looks great! Really appreciate the help!

I am happy to be of use here :). I'd gladly support you further on this project as much as I can. Another PR for this ticket here will follow soon.

This sounds like a spark of hope for the project! 🤞 Thank you! Happy to have someone on board to help with the maintenance!


unregister machine from another device

Needs to be updated

I'm going to fix the conflicts and merge it.


Raph branch

PULLING

The conflict issue has been resolved. I deleted the initial info in the README.md file


Stray Thread hogging CPU after penetration testing with qualys

We have witnessed an odd behavior of membrane at one of our customers after repeated abuse by qualys.
It appears that with a chance of roughly 25%, their test creates a thread in membrane that does never end and eats up one CPU core. After 8 recorded tests, we had 2 stray threads with the following Stacktrace:
   java.lang.Thread.State: RUNNABLE
	at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
	at java.io.BufferedInputStream.skip(BufferedInputStream.java:380)
	- locked <0x00000000e1cff1a8> (a java.io.BufferedInputStream)
	at com.predic8.membrane.core.http.Body.discard(Body.java:90)
	at com.predic8.membrane.core.http.Message.discardBody(Message.java:77)
	at com.predic8.membrane.core.transport.http.HttpServerHandler.removeBodyFromBuffer(HttpServerHandler.java:269)
	at com.predic8.membrane.core.transport.http.HttpServerHandler.process(HttpServerHandler.java:241)
	at com.predic8.membrane.core.transport.http.HttpServerHandler.run(HttpServerHandler.java:119)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

   Locked ownable synchronizers:
	- <0x00000000e102cbc0> (a java.util.concurrent.ThreadPoolExecutor$Worker)

We assume that the culprit is the following section in the Body class (in the discard() method)
		while (toSkip > 0) {
			toSkip -= inputStream.skip(toSkip);
		}

Which will never exit in case .skip continuously returns "0" (which is clearly possible, regarding both the javadoc of InputStream.skip and the implementation of BufferedInputStream.skip and .fill)
Would it make any sense whatsoever to continue reading once .skip returned 0 or could we define this as a secondary exit parameter? Why are you pro-actively draining the inputstream anyways and don't just close it and let the operating system handle it?
Added: After dumping the heap and analyzing it, we found the following content in the BufferedInputStream's Buffer which clearly shows the involvement of Qualys:
POST /rest/json/login HTTP/1.1..Connection: Keep-Alive..Content-Type: application/json..X-Requested-With: XMLHttpRequest..Content-Length: 36..Host: <IP_ADDRESS>..Qualys-Scan: VM....{"user":"admin","password":"admin"}ugins/kish-guest-posting/uploadify/scripts/uploadify.css HTTP/1.1..Host: hostname:9000..Connection: Keep-Alive..Qualys-Scan: VM....GET /Documentation.html HTTP/1.1..Host: hostname:9000..Connection: Keep-Alive..Qualys-Scan: VM....GET /wp-content/plugins/wp-property/third-party/uploadify/uploadify.css HTTP/1.1..Host: hostname:9000..Connection: Keep-Alive..Qualys-Scan: VM....GET /manager/templates/default/header.tpl HTTP/1.1..Host: hostname:9000..Connection: Keep-Alive..Qualys-Scan: VM....GET /console/login/LoginForm.jsp HTTP/1.1..Host: hostname:9000..Connection: Keep-Alive..Qualys-Scan: VM....GET /wp-content/plugins/easy-post-types/classes/custom-image/media.php?ref=ref"</script><iframe+onload%3Dalert(%2FQUALYSXSSTEST%2F)> H

Interesting, thanks for the report!!

Why are you pro-actively draining the inputstream anyways and don't just close it and let
the operating system handle it?

At this point in the code, there could be further HTTP requests coming in over the same TCP connection. As the first request has not yet been fully read, because the body was never used (and neither read yet), it has to be removed (=skipped) from the incoming connection to - possibly - get to the second request.
If skip keeps returning 0, something should be done about this.

Ah I see that makes sense. However we assume that these threads were burning cpu cycles since for about 2 weeks so something was not working right. I do have no idea however how we could reproduce this behavior probably as apparently not even the qualys abuse reproducible caused this misbehavior

Just for clarification, are you planning on taking a look at it? I'd try to fix it but I fear I'd break it in some unintuitive way so I'm a bit hesitant :)

bump

bump

Feel free to reopen, if this is still an issue.


Add support to read from prefixed columns

This fixes #1360 in order to work towards a DL1EventSource.

The HDF5TableReader.read() method now has an additional, optional argument prefix
Following the discussion in #1360 three use cases are supported:

prefix=False: No prefix. This is the default, because per default the writer does not add a prefix as well
prefix=True: Using the container prefix
prefix="my_prefix": Using a custom prefix

This enables the reading of the image parameter containers, that are written by the stage1 tool, but support for reading into multiple containers at once is still missing.

Does anyone know why codacy is still complaining?

Does anyone know why codacy is still complaining?

Yes, you changed the signature only of the hdf table reader, not of the base class. Methods should have the same signatures for all base classes.

I am pretty sure codacy stopped complaining the last time I visited this.
Can we get this merged or is there anything left to do?


CommonJsProject.prototype.clone broke since the arguments to the CommonJs

CommonJsProject.prototype.clone broke since the arguments to the CommonJsProject class changed.
As always I'd appreciate a npm update :)

Looks like a merge problem to me. Thanks.


Short circuit queries where no rows will be returned

There are numerous types of queries where it is guaranteed that no rows will be returned. For instance - selection only queries with LIMIT 0, group by aggregation queries with LIMIT 0, queries with a filter predicate that is always false, queries where there are 0 segments left after segment pruning etc.
Ideally, all these cases should be short circuited (i.e., no actual query execution should occur) and we should only return the data schema. This is currently done for some, but not all the cases.
See https://github.com/apache/pinot/pull/13555#issuecomment-2214679736 for more details.

Can I take it?


[TACHYON-482&483] adding a authentication framework, simple authentication implementation and user mapping service

The group mapping service is used by the authentication framework. they are closely tied with each other. So this pull request includes two Jira tickets:TACHYON-482 and TACHYON-483. Authentication is the first step to implement the Acl authorization in Tachyon.

Can one of the admins verify this patch?

We can’t automatically merge this pull request.

Hi @haoyuan , I have seen you merged the master to acl branch. The PR is based the acl branch not merged from master. I will send a updated PR that the acl was merged. I am sorry for that.
Thanks

Thanks @shenguoquan

Hi @haoyuan, I have updated the patches according to the latest acl branch. If you have any idea, please feel free to comment on the PR. @dongche @sundapeng please join in the conversation.
Thanks

Jenkins, add to whitelist.

Jenkins, test this please.

Jenkins, test this please.

hi, @shenguoquan  is this PR still valid given we have other smaller incremental PRs coming in. If we are not working on this PR, feel free to close this one.


[tests-only] Pin behat/gherkin because of Gherkin issue 187

Part of issue https://github.com/owncloud/core/issues/38338 - currently CI for core API tests is broken because of the upstream Gherkin issue.
Pin behat/gherkin for now until Gherkin issue https://github.com/Behat/Gherkin/issues/187 has been resolved.

Note: this fixes the local API tests. Needs https://github.com/owncloud/core/pull/38339 merged to get the version pinned for the core API test pipelines.

Note: this fixes the local API tests. Needs https://github.com/owncloud/core/pull/38339 merged to get the version pinned for the core API test pipelines.

@labkode @ishank011 CI should pass now. This gets CI green again. Please review.

@labkode @ishank011 CI should pass now. This gets CI green again. Please review.


Custom fields for rack groups

Issue type
[x] Feature request

Environment

NetBox version:  2.1.2

Description
We use rack groups to group racks within a site by room. It would be useful to configure custom fields on rack groups as well to store extra information such as room number, locking info, floor level.

This has come up before, so I've added a section in the FAQ for it. The short answer is that we don't associate extra data with organizational models because they don't have dedicated views, and including custom fields in a list view incurs a substantial performance penalty.


Rename top level after application of parameters early enough.  Fixes DFFRAM with OpenLane2.0.8

Moves the rename of top module to before selecting it.  This fixes a problem with mainline OpenLane2 and e.g. DFFRAM where needed modules are optimised away and then synthesis fails:
...
5.23. Analyzing design hierarchy..
Top module:  $paramod\RAM128\WSIZE=32'00000000000000000000000000000100
...
Removed 30 unused modules.
ERROR: No such module: RAM128

I believe this was introduced around 2.0.0b17, during the refactoring of the synthesis script.
It needs to be run on a multiple designs to prove that the new ordering doesn't negatively affect something unexpected.

Yosys is super chaotic, so let's hope the metrics don't catch fire across the board 😅

Yosys is super chaotic, so let's hope the metrics don't catch fire across the board 😅

Indeed.  I believe this does nothing to the topology... I hope all it does is rename the top cell correctly if needed, and is otherwise a no op.
I just ran a fairly large J-Core J2 CPU+FPU macro (almost .8mm^2 in sky130 hd cells) we've been using as a test, and got a byte for byte identical verilog netlist out of the synthesis step before and after this change... so that is encouraging.  Yosys 0.41, and GHDL 4.1.0 though, which is not the typical use case.

Merged into #517 -- sorry for the delay. Should be out with OpenLane 2.1.0.


Improve lpad udf by using a GenericStringBuilder

Is your feature request related to a problem or challenge?
As noted in the discussion in https://github.com/apache/datafusion/pull/11941#discussion_r1713604384 it looks like the performance of the lpad udf may be improved a bit by using a GenericStringBuilder instead of creating a string every time.
As well, as noted in https://github.com/apache/datafusion/pull/11941#issuecomment-2284011527 there may be room for improvement with the general code.
Describe the solution you'd like
lpad udf updated to use a GenericStringBuilder and a benchmark added to showcase whether it improves performance or not
Describe alternatives you've considered
No response
Additional context
No response

take


⚠ Jenkins Plugins Artifactory has degraded performance

In d2154c0, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1084 ms

Resolved: Jenkins Plugins Artifactory performance has improved in eabaf8d after 18 minutes.


kosmosctl unjoin command exception

What happened:
kosmosctl unjoin command cannot be executed when the cluster object is abnormal.
What you expected to happen:
cluster unjoin  success from the Kosmos control plane.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kosmos version: v0.1.9
Others:

/assign


QueueUsingLinkedList.cpp

Implemented Queue using Linked List

Please star this repository to show your support, in the meantime I am reviewing your code.


Also add integration tests for some of the affected endpoints.

LGTM

Rebased to resolve conflict

LGTM


Error: adapting config using caddyfile: parsing caddyfile tokens for 'order': Caddyfile:5 - Error during parsing: php_server is not a registered directive

Using v1.0.0-beta.1 on macOS Sanoma, I'm getting this error:
$ frankenphp run --config Caddyfile
2023/10/09 09:49:46 maxprocs: Leaving GOMAXPROCS=12: CPU quota undefined
2023/10/09 07:49:46.055	INFO	using provided configuration	{"config_file": "Caddyfile", "config_adapter": ""}
Error: adapting config using caddyfile: parsing caddyfile tokens for 'order': Caddyfile:5 - Error during parsing: php_server is not a registered directive, import chain: ['']

Using the configuration from the docs:
{
    # Enable FrankenPHP
    frankenphp
    # Configure when the directive must be executed
    order php_server before file_server
}

localhost {
    # Enable compression (optional)
    encode zstd gzip
    # Execute PHP files in the current directory and serve assets
    php_server
}

$ frankenphp list-modules | grep php
frankenphp
http.handlers.php

Upgrade to the latest image. This feature has been introduced after the beta 1.

I'm not using Docker, but use the binaries attached published tags on GitHub. Could you add a new tag there too?

You can download the latest version of the binary in GitHub Actions artifacts, but yes I'll tag a new version soon.


NDVI automation files for peer review (2022)

Pull Request Template
Review Checklist
CI Checks

[ ] The notebook runs from start to finish on all operating systems:

[ ] Mac
[ ] Windows
[ ] Linux

Reproducibility

[ ] Are the data downloaded in the code
[ ] Are paths created to ensure they work on all operating systems (using  os.path.join)
[ ] Are comments used to clarify the contents of the code that can’t be clarified using expressive variable and function names alone? (not too many comments - just enough)
[ ] Does the notebook run from start to finish?

PEP 8 standards & Code Readability
Functions

[ ] Do functions follow PEP 8 format conventions?
[ ] Are function docstrings clear (all  inputs and outputs clearly  described and defined)
[ ] Are function names expressive (the name describes what the function does)?
[ ] Are functions easy to understand and read?
[ ] How many tasks does each function do? (ideally a function does one thing well).

Package imports

[ ] Are standard modules (those included with the base  python install) vs. third party (related but externally developed tools) import groups correct with appropriate spacing in between each group?
[ ] Are variable names throughout the code, expressive?
[ ] Suggest changes if not, highlight what was done well
[ ] Is the code overall easy to understand and read? Are there things that would make it more clear / cleaner?

DRY Code

[ ] Are segments of code repeated in the file or is the code DRY?
[ ] Are loops used to optimize DRY code?
[ ] Are functions used to optimize DRY code?
[ ] Are there any areas that could be potentially improved (you can suggest improvements OR you can just highlight parts of the code where you suspect it could  be cleaner / more efficient.

Novel Approaches to Problem solving

[ ] Highlight any novel approaches to completing the assignment.

Will make a start today on reviewing your code. Also going to wait until the lecture incase there are further instructions.

https://github.com/S-Kur/ea-2021-ndvi-automation-review/blob/2e1cf6a5fc3949206649445bfd4f3d2e60525c44/svetlana_kurakina_ndvi.py#L142

Really clean and concise code. Good use of comments too.


Add SameSite option to response.cookie()

Add support for the SameSite flag on cookies.

Thanks for the suggestion! We added it in the 4.14.0 release :)
Here is an example:
$ npm i express
<EMAIL_ADDRESS>node_modules\express
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
$ cat app.js
var express = require('express')

var app = express()

app.get('/', function (req, res) {
  res.cookie('foo', 'bar', {
    sameSite: true
  })
  res.end()
})

app.listen(4000)

$ node app.js &
[1] 10804

$ curl -Is http://<IP_ADDRESS>:4000
HTTP/1.1 200 OK
X-Powered-By: Express
Set-Cookie: foo=bar; Path=/; SameSite=Strict
Date: Wed, 05 Oct 2016 13:24:13 GMT
Connection: keep-alive

@dougwilson Support for sameSite is not mentioned in the docs afaict. I discovered it's existence by accident when reading through the code of the cookie NPM package but could not find it in the docs... A Google search then lead me here.

Hi @Download sorry we missed documenting it. Please open issues with the website at https://github.com/expressjs/expressjs.com

Updated http://expressjs.com/en/4x/api.html#res.cookie

SameSite=None is added in<EMAIL_ADDRESS>and express depends on an exact version of<EMAIL_ADDRESS>which is out-dated now.

Hi @Nandiin you are using an outdated Express. Please upgrade to Express 4.17.0 or higher: http://expressjs.com/en/changelog/4x.html#4.17.0


[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

Tests run on GHA should be queued shortly.

beam_PostCommit_XVR_GoUsingJava_Dataflow.yml
Two tasks failed (https://ge.apache.org/s/765iszy4taves/failure) the Dataflow Java and Python container build and push:

https://ge.apache.org/s/765iszy4taves/console-log/task/:runners:google-cloud-dataflow-java:buildAndPushDockerJavaContainer?anchor=1&page=1

Error response from daemon: No such image: apache/beam_java8_sdk:2.57.0.dev

https://ge.apache.org/s/765iszy4taves/console-log/task/:runners:google-cloud-dataflow-java:buildAndPushDockerPythonContainer?anchor=1&page=1

Error response from daemon: No such image: apache/beam_python3.8_sdk:2.57.0.dev

beam_PostCommit_Java_PVR_Spark_Batch.yml
This has been flaky for a long time, then red for a minute, then now green on master. Looking into whether this is just luck or something changed. I will verify whether it is in a perma-red state on the release branch and whether we care about the cause enough to stop the release.

Looking into it, the tests that fail each time are different. There is overlapping passing of all ValidatesRunner tests for the Spark portable runner, but something is flaky. I don't think it needs to block.

beam_PostCommit_XVR_Direct.yml
Has occasional green runs but they are practically a rounding error. This suite does not carry signal we can use.

Release is finalized. Those red test suites can be dealt with as appropriate afterwards.


opencv cant read mp4 files

Tried using videocapture to read files it just wont read it installed with ffmpeg still same thing dont know what i'm missing

install opencv[ffmpeg]

I installed it but still it won't open mp4

Give more info, what dlls are near your exe

ffmpeg dll seems not to be loaded near my exe, dont know why, but i'm sure my opencv[ffmpeg] installation was ok any help please

Thanks solved the issue had to get the 64bit dll file to make it work ,hope opencv gets updated to 4.0

This sounds like it's related to #2613 and #2799.


Add TypeDoc

Currently the only way to see what functions take is either looking at the source or using IntelliSense with roblox-ts. This PR adds TypeDoc so that stuff can easily be viewed for people using this library in Lua. An example of this is at http://dog2puppy.me/RobloxPlayFabSDK/typedoc/

Thanks for this, it's a big improvement from the previous documentation site 😊


Experiments to improve Loris performance

What is this PR trying to achieve?
improve Loris performance in the most cost effective way. Spin off of #1032
Who is this change for?
Everyone
Have the following been considered/are they needed?

[ ] Deployed new versions

[ ] Run terraform apply.

We've decided to stick with C4 xlarge backed with an EBS volume for now. C4.large was not performing well at for the time being we are ok with the c4xlarge cost. Possibly worth revisiting this once we make some changes to loris to keep tthe images in memory instead of passing around temporary files


DX12 UpdateBuffer() Allocation failure not handled.

In DX12, UpdateBuffer() has an internal Allocate() call, and the CPUAddress is used as memcpy target without any nullptr checking.

This is not the only place where nullptr is not cheked. If there is not enough dynamic space, there is no good way to recover from this error or for application to know about the error.

ok... maybe i should just close this then...


Can I set value in RN side, and get value in native side?

Yes you can get value in RN side. For native, use the native MMKV library.


Bootstrap4 collapsible and accordion does not work with Angular6

Hi
I have setup angular 6 project with bootstrap4, here is the live demo https://stackblitz.com/github/Rugved/ng6bt4Demo/
OS: Windwos 10
Browsers: Chrome, IE 11
No error in the browser but collapse does not work

I would hope you reconsider, this is issue with bootstrap version 4. It stopped working after the update.

The collapse works fine in our docs—we can't speak to using it with Angular. If there's a problem with Bootstrap's CSS or JS outside Angular, we'd need a reduced test case in a CodePen or JS Bin.

@Rugved I didn't see any import of Bootstrap in your StackBlitz,
See mine, it works very well: https://stackblitz.com/edit/github-dptdcv?file=src/app/app.component.ts

Hi guys , thanks for support. You are right i didnt have jquery defined in json file above bootstrap. That fixed the issue, no problem with bootstrap 4 at all


Support for DarkMatter

Per DiscordStyles/DarkMatter#6

Please don't post the same issue on both themes.

Fixed.


Migrate to new KeyCloak realm

The dev and test environments have been migrated.  Just waiting to co-ordinate the migration of prod.

The configurations have been deployed and tested in all the environments.


SCA

Coverage remained the same at 92.156% when pulling 1aeef7bc12618a477915b53db38eccb8bcd848bf on SpacePossum:master_sca_3 into 1ecb5e07f1fc311744ed474225ebd33d23cd1a5b on FriendsOfPHP:master.

Are those changes reported by PHPStan or another tool?

PHPStan is really suitable for doing this.

stan, psalm, phpstorm build in, https://plugins.jetbrains.com/plugin/10215-php-inspections-ea-ultimate- and some custom "fixers"

closing for now, I'll make a new one when we are aligned on the hash/list/array syntax, thanks for reviewing all :+1:


update to 2.24.1

datadog-api-client 2.24.1
Destination channel: ai-staging
Links

PKG-4017
https://github.com/DataDog/datadog-api-client-python

Explanation of changes:

New feedstock on ai-staging. Keeping as noarch for ease of maintenance.

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_03hcgtcscr/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:15: avoid_noarch: noarch: python packages should be avoided
===== Final Report: =====
0 Errors and 1 Warning were found


Document the addition of font awesome

For future evolutions of ElaoStrap, could be interessant to have a doc to add Font Awesome with ElaoStrap

Will be there in the next version.


Don't  Aframe-AR support NFT?

how Aframe-Ar to use NFT?

I receive a error when run this example:
artoolkit.min.js:formatted:606 Uncaught TypeError: Failed to execute 'createObjectURL' on 'URL': No function was found that matched the signature provided.
How I resolve it?


[question, MacOS] where is the data stored in MacOS?

i.e. what is the exact location of the database, and/or can I read/write the database directly while developing.

MacOS, same as iOS, is storing data in Application Support/[bundleID] directory.
cc @tom-un

Thanks!


Create GromacsMDProtocolSettings

We need different settings:

OpenMM settings for creating the system: e.g. forcefield settings, integrator settings, thermo settings
Gromacs MDP settings: these are the settings that will be converted to .mdp files
Gromacs run settings: e.g. number of threads,...

Should this all be separate settings classes?

Reviewed on 13 Aug, @hannahbaumann will make changes.


Generated example publishing to the server - typescript errors

I've generated asp sample by:

yo aspnetcore-spa

During generation I have chosen react with redux option.
Example works locally fine but now I'd like to publish it to my production server.
To do it I used Publish function from context menu in Microsoft Visual Studio but during building I got an error like that:

command "node node_modules/webpack/bin/webpack.js --env.prod was exited by code 2

I tried to execute this command in Developer Command Promt for VS 2017 and i got errors:

ERROR in [at-loader] ./ClientApp/routes.tsx:9:12
 TS2322: Type '{ exact: true; path: "/"; component: typeof Home; }' is no
 t assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Route<T>> &
 Readonly<{ children?: ReactNode; }> & ...'.
 Type '{ exact: true; path: "/"; component: typeof Home; }' is not assignab
 le to type 'Readonly<T>'.

ERROR in [at-loader] ./node_modules/@types/react-router/index.d.ts:67:21
 TS2694: Namespace 'React' has no exported member 'ComponentType'.

Visual Studio version is: Microsoft Visual Studio Enterprise 2017 version 15.2.
TypeScript version is 2.2.3.
I'm really new with TS and .net core apps. Is there any possibility to fix these errors?
Project which I want to publish is pure example generated by JavaScriptServices. I didn't add any changes.
The same problem occured when I generated React redux example in Developer Command Prompt for VS 2017.
Thanks for help in advance!

It sounds like #1099 .
Could you update your package.json file to:
    ...
    "@types/react": "15.0.35",
    "@types/react-dom": "15.5.1",
    "@types/react-redux": "4.4.45",
    "@types/react-router-dom": "4.0.6",
    "@types/react-router-redux": "5.0.3",
    ...
    "typescript": "2.3.4",

and try it again?

Yeah! Solved it! Publish is sucessfully completed.
Thanks for fast help.
I will try tomorrow if it works on deployment server.

Thanks for answering @stephtr!


dark-mode: Another round of dark mode fixes.

This is another round of dark mode fixes involving modals.

@timabbott

Merged, after fixing the linter issues with some commit messages.  Thanks @brockwhittaker!


Adding code-of-conduct to the repo !

why coc ?
code-of-conduct:- We propose adding a comprehensive Code of Conduct to our repository to ensure
a safe, respectful, and inclusive environment for all contributors and users. This code will
serve as a guideline for behavior, promoting diversity, reducing conflicts, and attracting a
wider range of perspectives.
Issue type:-

[✅] Docs

@eliphatfs  kindly assign this issue to me ! I would love to work on it ! Thank you !

@eliphatfs  kindly assign this issue to me ! I would love to work on it ! Thank you !

Thank you for your contribution and please go ahead.

Closing due to lack of activity.


Adding a mal_actor_get_state

The mal_actor_t stores a user data named state. But there is no mean to access this data later. Currently, the user code should keep references to both mal_actor_t and its own user data.
What about adding a mal_actor_get_state function? With such function, the user code can only keep a reference to mal_actor_t as single reference to its whole consumer/provider.

It seems that this user data structure is returned in  all the actor's methods for processing messages.
However, there is no objection to adding a method in the interface to retrieve this structure from the actor's descriptor.


Document vSphere cloud provider RBAC requirements

This is a...
Bug Report
Problem:
SInce Kubernetes v1.9.0, the vSphere Cloud Provider requires a cluster role to work on clusters with RBAC enabled. This is not documented.
Proposed Solution:
Add configuration from https://github.com/kubernetes/kubernetes/issues/57279#issuecomment-359607201 to vSphere cloud provider documentation page.
Page to Update:
https://kubernetes.io/docs/getting-started-guides/vsphere/

Hi @praseodym - based on the comments in #7583 it seems like the situation has changed since this issue was created.
I believe this issue can be closed.

/close


Decide whether to promote all ints to floats in binops

In the case of adding floats to ints, did we decide on promoting the ints to floats? Originally, we said we'll just take whatever comes first, but I couldn't remember what we decided on.

I thought we decided to promote ints to floats (for binops) because when we got together last time, we tried out the llvm library's build_add function with an int and a "float" by casting the int to const_double, then using const_uitofp

Ah gotcha. But if we have the addition of two integers, it stays type int, correct?

In the current implementation, yup indeed:
https://github.com/DavidWatkins/Dice/blob/emily/Compiler/analyzer.ml#L115


Add Dutch (NL) translations

Thanks for your great library.
Here are translations for Dutch, hope these can get merged!

Thank you!


Paradise: Can't left click on other players

Tried to attack another player with a crowbar, just clicked the floor instead

Players' mouse maps are being rendered in the top right corner of the screen


1.13.11

Using ember-simple-auth with Ember 1.13.11 and can't get the helpers to work within the context of testing. Is there a working example somewhere showing acceptance test usage?

There's an acceptance test included in this repo: https://github.com/simplabs/ember-simple-auth/blob/master/tests/acceptance/authentication-test.js

Thank you for the example, the big difference is that I was trying to use authenticateSession() within the /tests/helpers/start-app.js run loop which is failing. Is the application not completely initialized within that context?

What exactly are you trying to do? Please share some code.

Closing due to inactivity. Please reopen if the problem persists but also provide some code then.


Error "Things are bad. Refreshing"

Things are bad. refreshing
Traceback (most recent call last):
File "run.py", line 69, in AutoLiker
location = likes[i].location
IndexError: list index out of range
Constantly facing this issue when i run your code.

The code is not maintained and it strongly depends on FB html code. If that
changes (which it does every month or so), the script might have problems
operating correctly.
I am sorry, I won't have time to maintain this code.
On Thu, 23 Jul 2020 at 09:20, Harris Amjad<EMAIL_ADDRESS>wrote:

Things are bad. refreshing
Traceback (most recent call last):
File "run.py", line 69, in AutoLiker
location = likes[i].location
IndexError: list index out of range
Constantly facing this issue when i run your code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/justdvl/facebook-auto-liker/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIDF3QPTGT3GQTUPDAJCPCTR47QCVANCNFSM4PFOAG5A
.

Hey, can you guide where to look for changes in your code as i am novice to
this language.
On Thu, Jul 23, 2020 at 12:31 PM David Vendel<EMAIL_ADDRESS>wrote:

The code is not maintained and it strongly depends on FB html code. If that
changes (which it does every month or so), the script might have problems
operating correctly.
I am sorry, I won't have time to maintain this code.
On Thu, 23 Jul 2020 at 09:20, Harris Amjad<EMAIL_ADDRESS>wrote:

Things are bad. refreshing
Traceback (most recent call last):
File "run.py", line 69, in AutoLiker
location = likes[i].location
IndexError: list index out of range
Constantly facing this issue when i run your code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/justdvl/facebook-auto-liker/issues/3, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AIDF3QPTGT3GQTUPDAJCPCTR47QCVANCNFSM4PFOAG5A
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/justdvl/facebook-auto-liker/issues/3#issuecomment-662860551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALFDO52JOYWKBUNWCUNBQYLR47ROPANCNFSM4PFOAG5A
.


Add Laravel Pail

Added code in composer.json file
Please check

@gagsy
I am closing this PR.
Because:

Questions remained unanswered for a long time
CI is red


⚠ Fortnite has degraded performance

In 87fbc36, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1636 ms

Resolved: Fortnite performance has improved in 8939b4c.


Title on SVG

Adding a title to an SVG lets a visitor hover over the icon to show the name of the skill.
Some visitors/interviewers might not know the name behind all of the icons on your page.
I've added title to all 296 icons.
The title comes from the svg-filename excluding 'Dark/Light.
No extra code needed for this to work.

+1
This would be a great addition. Would adding an href to the skill's website be achievable in SVG as well?


Test cases for services deployed with convoy-nfs/convoy-gluster volume drivers

@cjellick , can you review the following test cases for services deployed with convoy-nfs/convoy-gluster volume drivers?
All the test cases below deploy services with scale 2 and  anti-affinity to itself , so they get deployed in 2 different hosts with data volumes using  convoy-nfs/convoy-gluster volume driver. Validation check done for the shared data volume is to write into data volumes from 1 container of the service and be able to read this content from another container of the same service.

Service with  data volumes
Scale up service with  data volumes
Multiple services sharing the same data volume
Deletion of data volumes

Automated test cases for  rancher-nfs has been submitted as a part of different PR.
There is no suppprt for convoy-gluster volume drivers anymore.


There are so many [Vue warn] when I use swiper in Nuxt3 framework

Check that this is really a bug

[x] I confirm

Reproduction link
https://www.vantrontech.us
Bug description
I use the Nuxt3 SSR framework to develop a website, and I used the swiper component(version:8.4.5), but when i deployment my website by PM2, there's a lot [Vue warn] when check pm2 logs, such as :
[Vue warn]: onBeforeUpdate is called when there is no active component instance to be associated with. Lifecycle injection APIs can only be used during execution of setup(). If you are using async setup(), make sure to register lifecycle hooks before the first await statement.
[Vue warn]: onUpdated is called when there is no active component instance to be associated with. Lifecycle injection APIs can only be used during execution of setup(). If you are using async setup(), make sure to register lifecycle hooks before the first await statement.

I confirm that these warning are all caused by swiper component, so is that a bug or what should i do to avoid these warnings?
Expected Behavior
there should not be these warnings
Actual Behavior
there are lots of warnings
Swiper version
8.4.5
Platform/Target and Browser Versions
<EMAIL_ADDRESS>Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


Set current WIP to be drafts

Set WIP documents to be draft to avoid reaching pages with no information on the site

Thank you so very much, much much better.
/lgtm
/approve


Mouse cursor disappears completely (from the UTM main window) if the cursor is inside the window of a closing macOS 14 VM (while it's saving its state)

Describe the issue
The mouse cursor disappears completely (edit: from the UTM main window) if you close a macOS 14 (beta) VM window and then immediately move the mouse cursor inside that same VM window (while the window is still in the process of closing / saving the VM state)
edit: The mouse cursor only comes back after quitting and reopening UTM.app
Configuration

UTM Version: v4.4.0 (Beta) / 4.4.0 (88)
macOS Version: 14.0 Beta (23A5328b)
Mac Chip (Intel, M1, ...): M1 (MacBook Air M1, 16 GB RAM)

Steps to reproduce:
0. Make a new macOS 14 Beta VM (see below for details)

Start a macOS 14 Beta VM, login into macOS normally
Close the macOS UTM VM window from the red close button (top left corner) (UTM begins to save the state of the VM)
(a) Immediately move the mouse cursor down and right so that the cursor is hovering inside the VM window you just clicked to close

What happens: the mouse cursor disappears completely (!) and doesn't reappear until you switch to another application or quit UTM.app
Expected: normal mouse cursor

(b) If after clicking close you keep the mouse cursor outside the VM window, the cursor doesn't disappear.

The mouse cursor only seems to disappear if it's hovering inside the VM window while it's closing / saving the state of the VM.
PS. Here's how I made the macOS 14 beta VM, it's as standard/uninteresting as possible:

Download "UniversalMac_14.0_23A5328b_Restore.ipsw" (14.0 beta 6) from here: https://ipswbeta.dev/macos/14.x/
In UTM, click "+" (New)
Virtualize
macOS 12+
Browse... (choose the ipsw file downloaded previously)
Continue -> Continue -> Save
Edit the VM settings -> Virtualization -> disable "Enable entropy device" and "Enable Sound" -> Save
Start the new VM
Install macOS normally

This is an issue with Virtualization.framework. You can probably report the issue to Apple but if not, at some point, I will compile all the issues filed here and send them to Apple.

Let me try

I still have this issue constantly. Randomly the cursor just disappears and i cannot get it back.

Same issue here.


Performance: Duplicated CSS code

Detailed description
in the _helper-mixins.scss file @keyframe skeleton does not have an import-once wrapped around it . This causes the keyframe to be included every time the helper-mixin file is imported.  Within Carbon's minified CSS file it appears 91 times.

Is this issue related to a specific component?

no

What did you expect to happen? What happened instead? What would you like to see changed?

I expect the keyframe to only be exported once in the distributed files or when using Sass to create my own bundle. Currently this animation is in our bundled code 65 times and increases our un-minified file by almost 2000 lines.

What browser are you working in?

Chrome, Safari, Firefox, Edge, IE11

What version of the Carbon Design System are you using?

9.1.5

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Watson Health Design System
Steps to reproduce the issue

Search for @keyframes skeleton in carbon-components.css
Note it appears 91 times

Thanks for reporting this @elizabethsjudd! Definitely an issue on our end, will flag this as a bug and try and get it added to a sprint. Will also accept any/all PRs that address this, as well 😄


Add finetuning job with maap contracts.

Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.

        "value": "Spark"

finetuning value is missing.

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json:18767 in 4a79c05. [](commit_id = 4a79c0509d94d934949c46f33feca141a69136ce, deletion_comment = False)

        "value": "Spark"

finetuning value is missing.
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json:18767 in 4a79c05. [](commit_id = 4a79c05, deletion_comment = False)

Fixed this comment.

/azp run

/pr RequestMerge


Checksum calculation result does not match expected value when updating to 4.25.1

Search first

[X] I searched and no similar issues were found

Description
The database checksums were generated with version 3.2.2. Previously we used version 4.11.0 and we tried to update to version 4.25.1. With 4.11.0 everything worked as expected.
With 4.25.1 when running our ChangeSets we now get a liquibase.exception.ValidationFailedException indicating that the checksum has changed:
was: 7:d75a94bf7ec587f02f5add0bfad10daf but is now: 7:d93a849e187d1115ee7ec7e5ade76503
We use an H2 database.
Steps To Reproduce
The change set we ran:
<changeSet id="EXCHANGE_TABLE_MATNO_FMT" author="encoway">
        <preConditions onFail="MARK_RAN" onError="MARK_RAN">
            <tableExists tableName="EXCHANGE_TABLE"/>
            <not>
                <dbms type="sqlite"/>
            </not>
        </preConditions>
        <addColumn tableName="EXCHANGE_TABLE">
            <column name="TEMPLATE" type="varchar(32)"/>
            <column name="LEADING_ZEROS" type="tinyint"/>
        </addColumn>
    </changeSet>

The data in our database:

Expected/Desired Behavior
We would expect our data to still be compatible with the 4.25.1 version. We are aware that we can workaround this issue by registering a validCheckSum for the affected ChangeSet but we need a solution and not a workaround.
Liquibase Version
4.25.1
Database Vendor & Version
H2 2.1.214
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

I got same issue on PostgreSQL

Hi @Mangooos and @richardo-kusuma, could you share your <databaseChangeLog> tag? This could be related to the .xsd files specified.

Hi @tati-qalified ! This is our databaseChangeLog-Tag:
<databaseChangeLog         xmlns="http://www.liquibase.org/xml/ns/dbchangelog"         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"         xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog          http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">

I tested this using the CLI and couldn't replicate the bug - here are the two workflows I tested:

Running the changeset with v3.2.2, then with 4.11.0, then with 4.25.1

The checksums are updated with each change, from v7 to v8 to v9

Running the changeset with v3.2.2 and then with 4.25.1 (not passing through 4.11.0)

The checksum is updated, no error is shown.

Are you using some integration other than the CLI?
One thing I noticed is that, when I used v3.2.2, the resulting checksum was the second one you indicated: 7:d93a849e187d1115ee7ec7e5ade76503. Are you certain that the changeset hasn't been modified?

Hi @tati-qalified , we do not use Liquibase with the CLI but instead we use the liquibase API in our process.

Hi @Mangooos, could you retest this issue with the latest Liquibase version, 4.29.1, and let us know if the problem persists?


Is it possible to enforce "high security" auth methods for a group of users?

I want to mandate that high privileged users within a specific AD group can only use "high security" authentication methods,
while other low privileged users can still use medium and low authentication methods with MFA.
I am wondering whether we can set a policy in AAD to enforce this. Thanks.
Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c6262808-898e-6196-de6c-d76f649f20fa
Version Independent ID: 2075ceab-b773-db35-a79d-7044e839bc17
Content: Conditional Access - Require MFA for Azure management - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-conditional-access-policy-azure-management.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

Thank you for your feedback! Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team.
The best place for specific answers about implementations are going to be the Microsoft Q&A and Stack Overflow forums. We actively look through posts in the forums, and will do our best to get you going in the right direction!

Just checking in. Could you please provide the relevant documentation so we can route this question appropriately?

this is the doc I am referring to https://docs.microsoft.com/en-us/azure/active-directory/conditional-access/howto-conditional-access-policy-azure-management
Thanks.

Hi @mpchen,
This level of granularity isn't supported at this time. As you probably know, you can choose to enforce MFA for high-risk users only, or require every user to MFA.
You can choose which authentication methods are available to users and require them to use a more "high security" method such as the Authenticator app, but these settings are available tenant-wide.

You can request this feature here: https://feedback.azure.com/forums/169401-azure-active-directory/category/160602-multi-factor-authentication


Lack of code documentation

It's really missed :(, was it a deliberate decision?
Can I try my hand at adding some docs(for files and funcs at first)?

It wasn't a deliberate decision.  You are welcome to try writing docs, but don't feel like you have to or anything :)  If you're not a go programmer, be sure to follow the Go commenting guidelines.

I'm on it, it'll be my pleasure.


What is the log format used ?

I checked some log in a debian system in /var/log/yaws/foosite.access and they dont follow the
https://en.wikipedia.org/wiki/Common_Log_Format , they seem to have identifier at the end?

Yaws use the Combined log format, as defined in Apache documentation. This format is exactly the same as the Common Log Format, with the addition of two more fields: The Referer and the User-Agent.

Cool , thanks.


pyright.lua minor setting issue

nvim --version: NVIM v0.5.0-ea3aaa0
nvim-lsp version(commit hash): 09fc9449e88b8a4f97d14e87af3685a48df2137f
What language server(If the problem is related to a specific language server): pyright

Description of the problem
Current pyright.lua has settings as such:
settings = {
      analysis = { autoSearchPaths= true; };
      pyright = { useLibraryCodeForTypes = true; };

analysis should be wrapped in another parent table python as described here:

https://github.com/microsoft/pyright/blob/master/docs/settings.md

E.g. in my personal init.lua
settings = {python = {analysis = {autoImportCompletions = false}}}

I could not get autoImportCompletions settings to work using the default way but configuring like above works for me.

Fix: https://github.com/neovim/nvim-lspconfig/pull/432


Music

Everytime i reset the board the music seems to start on its own.

Everytime i reset the board the music seems to start on its own.

Can you further explain what you mean by this? So I may be able to be assigned to this issue?

I fixed it, it was merged a few hours ago.
Basicity in the code for the button reset the audio was set to start so every time a game was reset music started playing even if you didn't have music on before.


Add SPDY support

Just put spdy keyword after ssl in the listen directive, nginx will automagically negotiate the protocol.

LGTM

:+1:

Thanks!


Update Unreal version 4.15 or later

Hi, ash3D
I am going to use it in 4.17. Do you have plans to update to meet the Unreal version of 4.15 or later?

Hi, @windslyer
The plugin should work with 4.17. I had updated it in response to #6 a while ago, recently I've added support for 4.19.
You can look at #3 for discussion on using the plugin with UE 4.17.

When can I support 4.20？

@king1107955613
4.20 should work right now, no changes to plugin required.
See #11 for report on 4.20 migration.


[BUG]:  드래그로 지도 이동 후 center 위도, 경도 정보 확인할 수 있을까요?

Is there an existing issue for this?

[X] I have searched the existing issues

Version of @mj-studio/react-native-naver-map
"@mj-studio/react-native-naver-map": "1.5.9",
Version of react-native
"react-native": "0.72.12",
What os are you seeing the problem on?
Android
What device types are you seeing the problem on?
Physcial Device
What architecture types of react native are you seeing the problem on?
Old Architecture(Bridge)
Version of device(android API, iOS OS version, etc...)
No response
Expo App

[ ] I am using Expo

What happened?
A bug happened!
Relevant a package.json.
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

onTapMap prop을 사용해보시길 바랍니다.


request changelog

v0.15.0 has been released.
Are there any details about the changes from v0.13.0 to v0.15.0?
I found a few big changes. These are important pieces of information for developers.

removed serialPortType from SerialConfig (it is destructive change!)
add FHD_Rect to PreviewMode
add advanced_mode to DeviceConfig
add FaceRect to Image

Also, I have many other questions.

Release notes:
Added recognition-only authentication mode.
Auto-exposure.

what is recognition-only authentication mode?
how did you change auto exposure? (ON or OFF)

Please release changelog! I'm afraid undocumented changes.

BTW, this is too many changes in one commit. It is hard to track changes for developer.

Hi,
Most of the changes published in release notes.
Why do you need portType in addition to port number? Our library working seamless if it's USB or UART. Moreover we have auto-detection of port type.
The rest features you mentioned (FHD_Rect, advanced_mode...) they are not documented by purpose as available only to specific customers with special license.  Published FW doesnt support them.
RecognitionOnly mode not running Anti-Spoofing algo(s) as part of authentication.
Auto-exposure is controlled automatically by FW and starts upon preview. Users dont have control for it.
Currently all development is done in an internal github, then fully validated and the release is published to the public github.
In future we plan to establish automated CI and push smaller commits directly to public github

Why do you need portType in addition to port number? Our library working seamless if it's USB or UART. Moreover we have auto-detection of port type.

No, I'm not saying that change is bad. I think that change is a good one.
However, I'm afraid undocumented changes. That change is not even listed in the release notes.
We didn't know about that change until we read the code.

The rest features you mentioned (FHD_Rect, advanced_mode...) they are not documented by purpose as available only to specific customers with special license. Published FW doesnt support them.

Haha, Yes, that's it! I want a document with such an explanation.
We didn't even know that the feature was not available to the public until your comment.

RecognitionOnly mode not running Anti-Spoofing algo(s) as part of authentication.
Auto-exposure is controlled automatically by FW and starts upon preview. Users dont have control for it.

Good! It would be better if this is documented in changelog.


how to start a service with domain or proxy by nginx

how to start a service with domain or proxy by nginx?

Not relevant to this library