CASMPET-5066 - Drive location doc

Summary and Scope

utilizes ledmon/ledctl for drive led beacon

Issues and Related PRs

Resolves CASMPET-5066

Testing
Tested on:

mug

Test description:
Enabled and disabled the LED locator beacon on drives in the mug environment.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? n/a
Were continuous integration tests run? If not, why? n/a
Was upgrade tested? If not, why? n/a
Was downgrade tested? If not, why? n/a
Were new tests (or test issues/Jiras) created for this change? n/a

Risks and Mitigations
n/a
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

/backport release/1.0 release/1.2

An entry for this new file should be added under the Node Management header in the operations/index.md file.


Extract certificates howto

Hi, I spent some time looking how to extract certificates information, so here is a example of how to use this library with PyOpenSSL to extract information and convert to PEM format.

You can convert a certificate to PEM format by base64 encoding VALUE. Would it help if I made it more clear that VALUE contains the certificate?

Hi,
Yes, could be great if you make a clarification on this point.
I have two questions.

Strictly, PEM format is not only base64, also have -----BEGIN CERTIFICATE----- and -----END CERTIFICATE----- and is cut on 64 characters per line.

Based on VALUE is DER-encoded certificate I could use something like this, for extract certificate information

    from pkcs11.util import x509.decode_x509_certificate
    certs = []
    with token.open() as session:
         for cert in session.get_objects({
                 Attribute.CLASS: ObjectClass.CERTIFICATE}):
              certs.append(decode_x509_certificate(cert[Attribute.VALUE], extended_set=True))

but I getting problems with this, see.

I am working in Costa Rican digital signature software and we use a lot extrancting certificate, so could be great if slots has and funtion to extract all certificates on slot or some utility to that help to extract it pasing a slot object.   I can make a PR with this functionality if you are agree.

PD: This is an example of pkcs11 communication for athena smartcard to support personal digital signature software. See PKCS11PersonClient

Strictly, PEM format is not only base64, also have -----BEGIN CERTIFICATE----- and -----END CERTIFICATE----- and is cut on 64 characters per line.

Yes, but you can use a module like pem or asn1crypto to handle this.

Based on VALUE is DER-encoded certificate I could use something like this, for extract certificate information

It looks like your certificates are missing some extensions that the X.509 decoding routine expects to be present. Do you have an example certificate I can use to make this code less brittle? That said, I would use your existing decoding code here, since decode_x509_certificate is designed solely to go from DER into PKCS#11 attributes.
I started a branch to port all interchange between PKCS#11 attributes and ASN.1 data structures to use asn1crypto, which is a little more obvious to use than pyasn1, however it stalled on broken tests.

Yes, but you can use a module like pem or asn1crypto to handle this.

Yea, but documentation needs an example, could be really usefull.

Do you have an example certificate I can use to make this code less brittle?

My example certificate is here , this certificate is valid in Costa Rica, and is extracted from PKCS11 device.

I've included two examples into the documentation. I think in terms of extracting all of the certificates at once, I think the existing generator provides the most flexibility for this.
I'm unsure how much coupling of the Certificate object I should add. Should I add an X509Certificate object that exposes all of the parsed features, or let people chose the correct library for their need? I'm waiting to be guided by someone who has need of more certificate features than I do (which is none).

@luisza I've confirmed your certificate definitely breaks my decoder. It doesn't break asn1crypto. Can you file this as a new issue?


Scroll to top when changing page

I think the page should scroll to top of the results when I change the page using pagination at the botton.

#7 merged and deployed!


Website redirect

I cannot get bluehost and GitHub to work together on redirecting the website.  Without it the URL is aweful.  Want to get https://TheTensor.Space to serve from here.  Anyone willing to provide support in doing that please contact James.

fixed.


[Bug]: ContentLayout is not exported

Browser
Chrome
Package version
3.0.1
React version
18.2
Description
Documentation shows a component ContentLayout (https://cloudscape.design/components/content-layout/?tabId=playground), but this is not exported from the package.
Source code
No response
Reproduction
attempt to import ContentLayout component into react
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems

Hello,
the package version you indicated (3.0.1) is out of date and does not contain the new ContentLayout component. Please upgrade to the current version (3.0.53).

Thank you!!


Fix issue with optional unions when generating code

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release fixes a bug in the codegen that marked optional unions
as non optional.

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


Allow to add noindex meta tag via frontmatter

Changes
This allows to set noindex: true via frontmatter.
Dark mode

[ ] The UI has been tested both in dark and light mode
[x] This PR does not change the UI

fyi, this was my naive approach to add noindex to one of my pages. I'm not that experienced with Hugo, so I might have missed the "correct" way to do it and I'm happy if someone gives me a hint on how to do it properly :)


HHH-6562 - Unknown collection role when accessing ElementCollection in Embeddable via Criteria API

https://hibernate.atlassian.net/browse/HHH-6562

Superseded by https://github.com/hibernate/hibernate-orm/pull/1557.


[ISSUE #3805] Add ShenyuService and ShenyuDubboService annotations for shenyu-client-apache-dubbo

Signed-off-by: mango<EMAIL_ADDRESS>
Fixes #3805

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3838 (c0ed347) into master (6a08b6c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head c0ed347 differs from pull request most recent head a0bab46. Consider uploading reports for the commit a0bab46 to get more accurate results

@@            Coverage Diff            @@
##             master    #3838   +/-   ##
=========================================
  Coverage     64.74%   64.74%
  Complexity     6095     6095
=========================================
  Files           898      898
  Lines         24708    24708
  Branches       2240     2240
=========================================
  Hits          15998    15998
  Misses         7304     7304
  Partials       1406     1406

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

please also remove ElementType.METHOD in shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/annotation/ShenyuService.java, because dubbo itself does not support annotated in method.

please also remove ElementType.METHOD in shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/annotation/ShenyuService.java, because @Service itself does not support annotated in method.

Thank for your patient review, already removed.

please also remove ElementType.METHOD in shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/annotation/ShenyuService.java, because @Service itself does not support annotated in method.

Thank you for your patient review, already removed.

The CI of build (shenyu-integrated-test-spring-cloud) failed because can not pull openjdk:8-jre-alpine image from docker.io

The CI of build (shenyu-integrated-test-spring-cloud) failed because can not pull openjdk:8-jre-alpine image from docker.io

ok, I will rerun failed jobs


Prism crashes in Safari due to corrupt color list

Describe the bug
App crashes in Safari:
https://primer.style/prism/local/81680851-365b-4cc2-89f0-4a5856b07bda/scale/7b1f34cc-d9d9-4c03-84f3-208bc962b7f8
To Reproduce
Steps to reproduce the behavior:
Using Safari (15.6.1) go here:
https://primer.style/prism/local/81680851-365b-4cc2-89f0-4a5856b07bda/scale/7b1f34cc-d9d9-4c03-84f3-208bc962b7f8
It won't load, white screen of death
Expected behavior
Expected page to load, it didn't
Exporting the palette, and re-importing, I get an invalid color error, and here's why:
  "coral": [
    "#2ebef",
    "#fce4e9",
    "#f8cdd8",
    "#f2a4be",
    "#e762a3",
    "#aa3e7e",
    "#72305d",
    "#492342",
    "#2d182c",
    "#140b16"
  ],

The first color in coral #2ebef is only 5 characters.
Screenshots
White screen
Environment
Safari (15.6.1)
Additional context
Just the specific color list (Coral) is corrupt, the other color lists for the group still work. I am not certain what I did to cause this, but I was working with linked curves IIR.

Hi there! 👋
Thanks so much for taking the time to report this issue. We were trying to investigate the issue on our end but were unable to reproduce. We tried visiting the URLs that you linked but were never able to get it into a state where the hex color value was corrupted.
Do you still observe this behavior when clearing local storage and what not for the site? Is it also present for other versions of Safari or only in 15.6.1?
Thanks so much, appreciate any additional info here!

Hi @joshblack
Unfortunately, I can't find much additional. Trying to bring up scale:
.../scale/7b1f34cc-d9d9-4c03-84f3-208bc962b7f8
Causes the editing screen to quit, with console error:

Failed to load resource: the server responded with a status of 404 (Not Found)

And drops back to the home/gallery page (primer.style/prism/), though this is probably because it can not find a scale with the hash key 7b1f34c... and my local storage no longer seems to have that corrupted scale in it.
Sorry I don't have more for you at the moment, other than it's a cool tool, wish we could re-order the scales.


Updates to align the SSO settings

Update to recent development version. Still stuck at https://issues.jboss.org/browse/SWARM-1044


Integrate NCES in ontolearn-web service and fix dllearner binding script in examples

This pull request addresses the issue#408: https://github.com/dice-group/Ontolearn/issues/408, and updates the dllearner binder script such that positive and negative examples initially given here: https://github.com/dice-group/Ontolearn/blob/develop/examples/dl_learner.py#L39 are first sent to the PosNegLPStandard class as required by the binder and most class expression learners, inc. Drill, EvoLearner, CELOE, CLIP, etc
Please review and merge

Could you please ensure that no fixed paths are being used?
The following lines must not contain only fixed paths

https://github.com/dice-group/Ontolearn/blob/49427edac0585d29e426e6ee1d40317f94e589bf/ontolearn/scripts/run.py#L59

https://github.com/dice-group/Ontolearn/blob/49427edac0585d29e426e6ee1d40317f94e589bf/ontolearn/scripts/run.py#L92

https://github.com/dice-group/Ontolearn/blob/49427edac0585d29e426e6ee1d40317f94e589bf/ontolearn/scripts/run.py#L106 There is no reason to force a user to use conex embeddings

https://github.com/dice-group/Ontolearn/blob/49427edac0585d29e426e6ee1d40317f94e589bf/ontolearn/scripts/run.py#L149

owl_learner must follow the same interface.
https://github.com/dice-group/Ontolearn/blob/49427edac0585d29e426e6ee1d40317f94e589bf/ontolearn/scripts/run.py#L195

, 2., 3., 4.

parser.add_argument("--path_of_nces_embeddings", type=str, default="./NCESData/") was removed. It now takes input from the user (same as Drill data["path_embeddings"])
if not os.path.exists(f"./NCESData/{kb_name}/embeddings/ConEx_entity_embeddings.csv"). Same as above. The function has been modified, and takes input from the user. It is only when the path provided by the user does not exist that it looks from embeddings online. This is because NCES needs embeddings to run, not like Drill which can run without embeddings.
owl_learner must follow the same interface. This has been fixed. No check whether it is an NCES instance. NCES takes PosNegLPStandard as the other learners now.
Note:
If I completely remove the possibility to download embeddings for NCES, the user will have to go download them manually if he still needs to test NCES. As it currently is, the user can provide any embeddings, and they will be used.

Another Note
NCES is trained from scratch if the provided path for pretained models does not contain any files

Can you please follow the enumeration ? and fix the each point individually.

, 2., 3., 4.

What does this enumeration mean ? Can you please nextime explicitly state whether the required is done or not?
This function is still in the script. This needs to be removed.
def get_embedding_path(ftp_link: str, kb_path_arg: str)->str:
        return f"./NCESData/{kb_name}/embeddings/ConEx_entity_embeddings.csv"

Please follow the same structure of preparting an owl reasoner as we have done for DRILL and TDL

Is still not being fixed https://github.com/dice-group/Ontolearn/blob/49427edac0585d29e426e6ee1d40317f94e589bf/ontolearn/scripts/run.py#L59

Is still not being fixed https://github.com/dice-group/Ontolearn/blob/49427edac0585d29e426e6ee1d40317f94e589bf/ontolearn/scripts/run.py#L59

You are probably looking at an old commit. New link here: https://github.com/dice-group/Ontolearn/blob/nces_web_and_fix_dllearner_binder/ontolearn/scripts/run.py#L55

I replied for 1., 2., 3., 4.
They have been resolved but with notes awaiting for your confirmation. I will write notes down here again.
parser.add_argument("--path_of_nces_embeddings", type=str, default="./NCESData/") was removed. It now takes input from the user (same as Drill data["path_embeddings"])
if not os.path.exists(f"./NCESData/{kb_name}/embeddings/ConEx_entity_embeddings.csv"). Same as above. The function has been modified, and takes input from the user. It is only when the path provided by the user does not exist that it looks for embeddings online. This is because NCES needs embeddings to run, not like Drill which can run without embeddings.
owl_learner must follow the same interface. This has been fixed. No check whether it is an NCES instance. NCES takes PosNegLPStandard as the other learners now.
Note 1:
If I completely remove the possibility to download embeddings for NCES, the user will have to download them manually in case he does not have any emeddings and still needs to test NCES. As it currently is, the user can provide any embeddings and they will be used. But feel free to request that I remove any possibility to download data.
Note2:
NCES is trained from scratch if the provided path for pretained models does not contain any files

They have been resolved but with notes awaiting for your confirmation

If they have been resolved, please push them.

Hi. If a comma or import is missing, it must have been a typo. Please feel
free to add them.
On Wed, Oct 23, 2024, 07:13 Luke Friedrichs @.***>
wrote:

@.**** commented on this pull request.
In examples/dl_learner.py
https://github.com/dice-group/Ontolearn/pull/450#discussion_r1811865794:

@@ -36,9 +38,14 @@
p = examples['positive_examples']
n = examples['negative_examples']

best_pred_celoe = celoe.fit(pos=p, neg=n, max_runtime=1).best_hypothesis()

positives = {OWLNamedIndividual(IRI.create(i)) for i in p}
negatives = {OWLNamedIndividual(IRI.create(i)) for i in n}

lp = PosNegLPStandard(pos=positives, neg=positives)

Import for this is missing
—
Reply to this email directly, view it on GitHub
https://github.com/dice-group/Ontolearn/pull/450#pullrequestreview-2387165179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK4X4ETCP32LHK4MAXPQ3YTZ44V67AVCNFSM6AAAAABP7JIJI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBXGE3DKMJXHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Adding multiple ControlNets has no effect

After doing some tests passing more than one ControlNet in the array when loading the model and more than one controlNetInputs when generating has no effect on the generated image. Only the first ControlNet is used

The pipeline would have to pass the end result of one ControlNet to the next ControlNet as the starting image, and it seems that it does not do this presently.  A clever coder could  probably make  it do so, as an option.  I hope someone will undertake this coding task.


feat: Provide averages binning to improve RF accuracy for some datasets

Provide binningStrategy and maxBins=0 options
Updated test cases for RF with tigther log loss ratio constraints (1.55 -> 1.15)
Refactored RF classes: putting class methods back to class body (remove them from global module scope)
Added pyproject.toml with instructions for black - formatted the files I touched

Because of the formatting changes, (black and CLRF to LF), the diff is very large. The individual contributions are provided in dedicated commits which might be easier to review.

/intelci: run

One PreCommit step is failed already. This particular step failure should be investigated.

It's because we were running with the wrong oneDAL version. We need to check
intel-ci.intel.com/edfaeffa-f08d-f1ec-8eba-a4bf010d0e2e

@Mergifyio rebase

/intelci: run

http://intel-ci.intel.com/edfc081a-3397-f16e-aeed-a4bf010d0e2e

http://intel-ci.intel.com/edfc9356-5ed2-f116-8266-a4bf010d0e2e

I suggest to wait for https://github.com/intel/scikit-learn-intelex/pull/1313, so this PR will be tested with correct sklearn versions

/intelci: run

/intelci: run


fix: migrate identifier

PR Description
Fixing device registry because of a faulty value: device id was wrongly stored as a int.
Old:    "identifiers":[["midea_ac_lan",146235046630005]]
New:  "identifiers":[["midea_ac_lan","146235046630005"]]

Have you tested it? I didn't trigger the migration process. and duplicate devices appear

Hello, I made some modifications and have tested on 2023.8 and 2024.6, please take a look and feel free to make any changes.

test with latest update, it should works well with HA 2024.6.3
and migrate from version 1.1 to 2.2 pass.


Slugify structured data table name in connector workers

Description
See https://github.com/dust-tt/dust/issues/3950.
This PR transfers the logic responsible for slugifying the structured data table's name and sanitizing the headers. Previously, this logic was located in the front component. However, as we intend to make this endpoint publicly accessible, it's essential to maintain the integrity of the user's input data.
In this PR, the logic for slugifying the table name and sanitizing headers has been moved to the connectors.Plus, stricter checks have been implemented on the public endpoint to ensure data consistency.

Risk
Worst case it breaks some structured data. Safe to rollback.

Deploy Plan

Thanks ! Can we also have this functionality in the upload CSV ? i.e, we'd need it in the private API csv endpoint but not in the v1/csv endpoint...

Seen IRL, I'll ship this as-is and will update the CSV parsing in the app to slugify/sanitize headers.


53504-Expensify Card-The "Issue card" flow can be completed by entering any random magic code

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.71-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5297062
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Action Performed:
Setup:
User is an admin of a workspace and has enabled Expensify Cards in more features.
User has set a fully verified VBA before.
Any Gmail or expensifail account can be used.
Steps:

Navigate to the "Expensify Card" page in WS settings
Click on "Issue new card"
Select the user you are using
Select Virtual Card
Select Fixed amount and Next
Enter $2, select Next
Enter a card name and continue
Click on the issue card button
Enter a random magic code (different from the one received in the email)

Expected Result:
An error message should appear if the user enters a different magic code than the one received in the email.
Actual Result:
The "Issue card" flow can be completed by entering any random magic code.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/835a8ffb-b2ff-4e50-9784-e9f5496e872b
View all open jobs on GitHub

Closed by mistake. Reopening as this was created by one of Applause team leads.

Can't reproduce

cc @mountiny

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Unable to reproduce, held up when tried to issue cards

Gonna see if a C+ can reproduce, thanks for trying @DylanDylann

Looking

Ok this is because this PR was just deployed to production 4 days ago that started to enforce it so nothing really to do here


Question: does this work on a self-hosted JITSI instance?

Would like to use the tool for self-hosted JITSI Meet instances, but haven't tested it yet (need to spin one up). So I wanted to check up front if it would work with a custom domain name?

Note to myself: read the manual.


[5.6] Include $columns in getCountForPagination call

This PR intends to include the $columns variable in all calls of getCountForPagination.
Currently it is already passed on Illuminate/Database/Query/Builder.php, but it is not on Illuminate/Database/Eloquent/Builder.php, in both cases it is used when paginating an model.
Problem:

Wrong total being returned from the paginate method

When Issue was found:

I'm building a search page for an eCommerce, and it has multiple relationships. When I try to get the paginate, it returns the wrong total, since Laravel needs that $columns to be passed into the getCountForPagination to a count into a distinct column, instead of the default '*'.

Note: I would be good to update the version 5.5 as well, since it affects old versions.

Check this link. This has been tried many times.

Shit! I will already search for a workaround instead!
Thanks for your message!
Even tough would be good to know which other cases it change would brake


Add Option to Minimise hosts File

This option (--minimise, -m) differs from compress (--compress, -c) in that it keeps each host on a different line, while still removing unnecessary newlines and comments.
This is necessary because many implementations of URL blockers that rely on hosts files do not conform to the standard which allows multiple hosts on a single line.

Thanks Ankit @ankitpati – very nice.
But... can I ask you to update docs, ind the Command Line Options section of the readme_template.md?

You’re welcome, and thank you for reviewing the PR.
I updated readme_template.md, but I grepped through the whole repo, and cannot find the “docs” which you mention. Essentially, I matched every mention of compress, in whatever I could find, with a mention of minimise.
I fixed the failing tests, but I feel test_get_defaults is overly restrictive and only serves to duplicate work whenever a default option is changed or a new one is added.

Ankit @ankitpati thanks!
readme_template.md is the only place where the change is required; you got it.

Thank you for the merge.


[v6rc5] initialValues are not propagated

@connect(mapStateToProps)
@reduxForm(...)
export default class extends Component {
  render() {
    console.log(this.props.initialValues) <-- undefined
    ...
  }
}

function mapStateToProps(state){
  return { initialValues: { ...} }
}

However in v6rc4 worked fine

I also noticed that the initialValues prop disappeared recently. I thought the omission was intentional because it doesn't appear to be documented:
http://redux-form.com/6.0.0-rc.4/docs/api/Props.md/
On further reflection, however, I think the initialValues prop really ought to be there.

I do have the same problem and rolled back to v6rc4 which works

This was fixed by #1598. I will post here again when it is released.

Published in v6.0.1.


add more signals for plugins

closes #297

Coverage decreased (-0.04%) to 91.166% when pulling 60c120eb70549c0e9db515d58c6ff83e49dbe949 on plugin-signals into bf35582caa8dcc1f1655f6891edc12d68415ba2d on main.


Make sure that removing a plot results in full redrawing

StackOverflow link: http://stackoverflow.com/questions/26612866/remove-plot-in-kivy-graph
The issue is that when a plot is removed, it does not disappear on redraw, unless the window is resized. This fixed that (tested by self).

Thanks you!


support for non-string type request

Plugin currently only supports requests that are for jsonapi,
updateTrainer(trainer: string): Observable<Response> {
  return this.httpClient.post('trainer', trainer);
}

Need support for non-string body based requests
updateTrainer(trainer: Trainer): Observable<Response> {
  return this.httpClient.post('trainer', trainer);
}

Can you explain the use case ?

    post(url: string, body: string, options?: RequestOptionsArgs): Observable<Response> {
        let opts: RequestOptionsArgs = this.build(RequestMethod.Post, url, options, body);
        return this.request(url, opts);
    }

What if my body is not a string? This enforces me to transform my request object to string.


cf ssh -c stuck

Please fill out the issue checklist below and provide ALL the requested information.

[x] I reviewed open and closed github issues that may be related to my problem.
[x] I tried updating to the latest version of the CF CLI to see if it fixed my problem.
[x] I attempted to run the command with CF_TRACE=1 to help debug the issue.
[?] I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with
Trying to run the command: cf ssh <app> -c 'cat $VARIABLE_WITH_FILE_PATH' to extract a certificate for a test. This happened first in our pipeline environment and then I was able to reproduce the issue locally.
App and Space SSH are enabled.
When executing cf ssh <app> followed by  cat $VARIABLE_WITH_FILE_PATH in the opened ssh console, everything works as expected.
As well as replacing the command with cf ssh <app> -c cat <resolved file path> works as expected, too.
The variable is only defined in the cloud foundry hosted app environment.
This functionality was working before.
What happened
The command got stuck without any further output.
Expected behavior
The command should execute as expected, provide the output of cat as a result and then finish normally.
Exact Steps To Reproduce
Steps to reproduce the behavior; include the exact CLI commands and verbose output:

cf ssh <app> -c 'cat $VARIABLE_WITH_FILE_PATH'
See error (nothing happens, command does not finish)

Provide more context

Mac OS 13.0.1 -  iTerm2
version of the CLI you are running: cf version 8.5.0+73aa161.2022-09-12 (same result with latest version of cf cli7)
version of the CC API Release you are on: 3.127.0

Notes regarding V6 and V7 CLI support:

V6:

Minimum supported version of CF Deployment: v7.0.0 (CAPI Release: 1.74.0 (APIs 2.128.0 and 3.63.0))
Maximum supported version of CF Deployment: v13.4.0 (CAPI Release: 1.94.0 (APIs 2.149.0 and 3.84.0))

V7:

Minimum supported version of CF Deployment: v13.5.0 (CAPI Release: 1.95.0 (APIs 2.150.0 and 3.85.0))

has been resolved, without any changes on my side. Very likely a local issue


Support for security-only updates using Dependabot CLI

This change adds support for "security-only" updates in TaskV2 using Dependabot CLI.
Security-only updates (i.e. open-pull-requests-limit: 0) incur a slight performance overhead due to limitations in Dependabot CLI (#360). To work around this, vulnerable dependencies will first be discovered using an "ignore everything" update job; After which, security advisories for the discovered dependencies will be checked against the GitHub Advisory Database before finally performing the requested security-only update job. It might be possible to optimise this process in the future, but for now this is the best that I can come up with.
High-level sequence diagram of security-only update process
 sequenceDiagram
    participant ext as TaskV2
    participant cli as Dependabot CLI
    participant gha as GitHub Advisory Database

    ext->>ext: Write `list-dependencies-job.yml`
    Note right of ext: The job file contains `ignore: [ 'dependency-name': '*' ]`.
This will make Dependabot to discover all dependencies, but not update anything.
We can then extract the dependency list from the "depenedency_list" output.
    ext->>+cli: Execute `dependabot update -f list-dependencies-job.yml -o output.yml`
    cli->>cli: Run update job
    cli->>cli: Write `output.yaml`
    cli-->>-ext: Update completed

    ext->>ext: Read and parse `output.yaml`, extract "dependency_list"
    loop for each dependency
      ext->>gha: Check security advisories for dependency
    end
    ext->>ext: Filter dependency list to only ones containing security advisories
    ext->>ext: Write `security-only-update-job.yml`
    Note right of ext: The job file contains the list of `dependency-names` and `security-advisories`.
This will make Dependanbot only update the dependencies named in the job file.
    ext->>+cli: Execute `dependabot update -f security-only-update-job-job.yml -o output.yml`
    cli->>cli: Run update job
    cli->>cli: Write `output.yaml`
    cli-->>-ext: Update completed
    ext->>ext: Read and parse `output.yaml`
    Note right of ext: Normal update logic resumes from this point.
Outputs are parsed, pull requests are created/updated/closed based on the outputs

Example update scenario
Example of security advisories being fetched from GHSA:
...snip...
##[endgroup]
##[section]GHSA dependency vulnerability check
Detected 1 dependencies; Checking for vulnerabilities...
Detected 2 vulnerabilities affecting 1 dependencies [ 'System.Text.Json' ]
##[group]Job 'update-0-nuget-security-only'
...snip...

Example of security advisories being passed in to job.yml:
  "job": {
    "id": "update-0-nuget-security-only",
    "package-manager": "nuget",
    "update-subdependencies": true,
    "updating-a-pull-request": false,
    "dependencies": [
      "System.Text.Json"
    ],
    "allowed-updates": [
      {
        "dependency-type": "all"
      }
    ],
    "security-updates-only": true,
    "security-advisories": [
      {
        "dependency-name": "System.Text.Json",
        "affected-versions": [
          ">= 8.0.0, <= 8.0.4"
        ],
        "patched-versions": [
          "8.0.5"
        ],
        "unaffected-versions": []
      },
      {
        "dependency-name": "System.Text.Json",
        "affected-versions": [
          ">= 7.0.0, < 8.0.4"
        ],
        "patched-versions": [
          "8.0.4"
        ],
        "unaffected-versions": []
      }
    ],
    "source": {
      ...snip...
      ]
    },
    "existing-pull-requests": [],
    "existing-group-pull-requests": [],
    "experiments": {
      "nuget_native_analysis": "true",
      "nuget_dependency_solver": "true"
    },
    "reject-external-code": false,
    "lockfile-only": false,
    "debug": true
  },

Example of Dependabot analysing next safe version:
updater | 2024/12/02 11:41:27 INFO <job_update_0_nuget_security_only> Starting security update job for rhyskoedijk/DevOps%20Extensions/_git/Dependabot-Tests
updater | 2024/12/02 11:41:27 INFO <job_update_0_nuget_security_only> Checking if System.Text.Json 8.0.0 needs updating
updater | 2024/12/02 11:41:27 INFO <job_update_0_nuget_security_only> Writing dependency info: {"Name":"System.Text.Json","Version":"8.0.0","IsVulnerable":true,"IgnoredVersions":[],"Vulnerabilities":[{"DependencyName":"System.Text.Json","PackageManager":"nuget","VulnerableVersions":[">= 8.0.0, <= 8.0.4"],"SafeVersions":["= 8.0.5"]},{"DependencyName":"System.Text.Json","PackageManager":"nuget","VulnerableVersions":[">= 7.0.0, < 8.0.4"],"SafeVersions":["= 8.0.4"]}]}
updater | running NuGet analyze:
updater | /opt/nuget/NuGetUpdater/NuGetUpdater.Cli analyze --repo-root /home/dependabot/dependabot-updater/repo --discovery-file-path /tmp/.dependabot/discovery.1.json --dependency-file-path /tmp/.dependabot/dependency/System.Text.Json.json --analysis-folder-path /tmp/.dependabot/analysis
updater | Starting analysis of System.Text.Json...
updater |   Determining multi-dependency property.
updater |   Finding updated version.
updater |   Finding updated peer dependencies.
updater | Restored /tmp/package-dependency-resolution_kv8HTW/Project.csproj (in 392 ms).
updater | NuGetData::Package=System.Text.Json, Version=8.0.5
updater |
updater | Build succeeded.
updater | 0 Warning(s)
updater | 0 Error(s)
updater |
updater | Time Elapsed 00:00:01.23
updater |
updater |
updater | Analysis complete.
updater | 2024/12/02 11:41:30 INFO <job_update_0_nuget_security_only> Latest version is 8.0.5
updater | 2024/12/02 11:41:30 INFO <job_update_0_nuget_security_only> Requirements to unlock own
updater | 2024/12/02 11:41:30 INFO <job_update_0_nuget_security_only> Requirements update strategy
updater | 2024/12/02 11:41:30 INFO <job_update_0_nuget_security_only> Updating System.Text.Json from 8.0.0 to 8.0.5

Example of PR creation:

@mburumaxwell this is ready now if you don't have any objections. It's not perfect due to the workarounds I've had to do (mentioned above), but it at least works.


Fix issue with moving maximized window in macOS

When opening the Godot editor and maximizing the window by double-clicking the title bar, users are unable to drag the window with the mouse.
With this commit, mouseDownCanMoveWindow is enabled, allowing the window to be moved by dragging it.
Fixes #78758.

The mentioned condition probably can be safely replaced with if (wd.fullscreen) { to fix moving maximized window.

Thanks! And congrats for your first merged Godot contribution :tada:


can't go get github.com/bazelbuild/reclient/api

tried to use github.com/bazelbuild/reclient/api/proxy etc,
$ go get github.com/bazelbuild/reclient@latest
go: added github.com/bazelbuild/reclient v0.0.0-20231026140608-dc540fe2b9d0

but can't compile with the module.
e.g.
build/siso/build/exec_reproxy.go:17:2: no required module provides package github.com/bazelbuild/reclient/api/proxy; to add it:
        go get github.com/bazelbuild/reclient/api/proxy
build/siso/execute/reproxyexec/reproxyexec.go:18:2: no required module provides package github.com/bazelbuild/reclient/api/log; to add it:
        go get github.com/bazelbuild/reclient/api/log
build/siso/execute/reproxyexec/reproxyexec.go:23:2: no required module provides package githubc.om/bazelbuild/reclient/api/proxy; to add it:
        go get githubc.om/bazelbuild/reclient/api/proxy

$ go get github.com/bazelbuild/reclient/api/proxy
go: module github.com/bazelbuild/reclient@upgrade found (v0.0.0-20231026140608-dc540fe2b9d0), but does not contain package github.com/bazelbuild/reclient/api/proxy

maybe, go.mod is needed at the top level of repo?
$ go clean -modcache -cache
$ go get github.com/bazelbuild/reclient/api/proxy
go: downloading github.com/bazelbuild/reclient v0.0.0-20231026140608-dc540fe2b9d0
go: module github.com/bazelbuild/reclient@upgrade found (v0.0.0-20231026140608-dc540fe2b9d0), but does not contain package github.com/bazelbuild/reclient/api/proxy

It started working while I was fiddling with it:
cd /tmp
mkdir siso
cd siso
go mod init github.com/siso/siso
cat <<EOT >main.go
package main

import (
	"fmt"
	"github.com/bazelbuild/reclient/api/proxy"
)

func main() {
	fmt.Println(proxy.ExecutionStrategy_Value_name[0])
}
EOT
go get github.com/bazelbuild/reclient/api@latest
go mod tidy
go run main.go

UNSPECIFIED

I wonder if proxy.golang.org didn't have it cached before?
Can you retry to confirm?

ah, now I can get the module.


Use "en" locale for internal project status change messages

Use "en" locale for internal project status change messages.  See below for an example of the problem.  And congrats to the libqmatrixclient project!
Project status change in project 1023

Project 1023 named libqmatrixclient
on bestpractices.coreinfrastructure.org
has changed
from in_progress
to passing.
The project entry was created on 2017-06-02 04:57:12 UTC.
Time from project entry creation to passing = 9 месяцев See https://bestpractices.coreinfrastructure.org/projects/1023 for more.

Thank you David, for congratulating and for your project that prompted me to bring libqmatrixclient to the next level of integrity.

@KitsuneRal - you're welcome, and thank you so very much for all that work. Translations are something I simply am not qualified to do, and there are a lot of work.
Congratulations on working on libqmatrixclient. This project has encouraged me to make changes to some of my other projects too.
The recent changes to automatically detect locales should make it easier for people to see all that work.


Number literal syntax - allow underscores or other way to make number more readable

This is likely a 2.x feature.
I would like to be able to use underscores inside number literals to break up long runs of digits.
For example<PHONE_NUMBER> is harder to understand than 1_000_000_000.
Today I saw  x & 0x3FFFFFF with a comment saying the result fits in 30 bits.
If you count the Fs, you will see there is an error, but the error has gone unnoticed for several years.
If underscores were permitted, the following difference might be more apparent to the developer or reviewer:
x & 0x_3FF_FFFF     vs     x & 0x_3FFF_FFFF

I would want the exact placement of underscores not be prescribed, the same literal might warrant different structure depending on context. In some byte-oriented code 0x3F_FF_FF_FF might make more sense.
This feature would also make binary literals (0b_1111_1111 = 255) more useful.

See also #2995

That feature is on my (rather long) list of conveniences I'd like too.
My design would only allow underscores between digits, so 0x3FFF_FFFF, not 0x_3FFF_FFFF, but apart from that I agree.

I reasonably often see code like 100 * 1000 * 1000 to dodge the issue. That could just have been 100_000_000.

I think we can close this in favor of https://github.com/dart-lang/language/issues/2 in the new language repo; 20 upvotes today.

Now that you have linked the two, I agree :)

https://github.com/dart-lang/language/issues/1
https://github.com/dart-lang/language/issues/2
https://github.com/dart-lang/sdk/issues/26845
https://github.com/dart-lang/sdk/issues/2995


penana.com is not porn domain

penana.com is a chinese novel site, which might include minor R16 but should be not R18. Expected should be false positive.
It is on line 1499075

Nvrmind, confirmed having R18 manga. I'll close this issue


selection lost when orientation changes

K-9 Mail Version: 5.600
Galaxy S8
Android v9
Priority: Minor
Steps to reproduce:

Select 2..n mails
Rotate the phone until screen gets wide/small

Issue:
Selection ist lost
Expected Result:
Selection kept when screen rotates

Was solved with reworked UI. Not reprodiceble in Version
K-9 Mail Version: 5.600
=> closed!


Venenation

text: The stolen minion is locked as part of the block resolution and the combat is prevented since the combatants now share the same controller.
link: https://www.vekn.net/forum/rules-questions/79615-burn-counter-to-gain-control-of-steal-a-minion#104588

Duplicate


GUI error?

Hello, I want to use WAT in my project but I have problems using the GUI.

As you can see on the screenshot I can manually select a test. When I run a test it generates a json file with the result of the test.
Though, I can't see the result in Godot, the Tests tab in the editor remains empty.
I tried it on my project and on your master branch. I have the same problem with both (Using your master branch the output prints this error though, /gui.gd:32 - Invalid call. Nonexistent function 'clear' in base 'TabContainer (result_forest.gd)')
I'm using Godot 3.2.3.stable.fedora.

This might be related to the GUI typo where gui.gd should be GUI.gd
Should be fixed in future versions.


roblox frozed

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.1
What problem did you encounter?
roblox froze

Bloxstrap Log
No response

Upload the screenshot again please

SIGMAHACKERS WHATS WRONG

Hope you get it fixed :grin::heart::basketball:


[Feature Request] Add Master Fingerprint Sparrow Server

Is technically feasible to add the master fingerprint? Lifehash is not necessary

Yes, it is. Good suggestion, added in 6072f6d3.


runtime.Callers: got incorrect line number in some case

What version of Go are you using (go version)?

$ go version
go version devel go1.18-7f23145 Thu Dec 16 00:34:10 2021 +0000 darwin/amd64

Does this issue reproduce with the latest release?
Not in 1.17.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
mac, amd64

What did you do?
package main

import (
	"fmt"
	"runtime"
	"runtime/debug"
	"strings"
)

func main() {
	withRecover()
}

var abc string

func willPanic() {
	abc = "1234"
	panic("oops...") // line 18
}

func withRecover() {
	defer func() {
		e := recover()
		if e != nil {
			fmt.Println(identifyPanic())
			fmt.Println(string(debug.Stack()))
		}
	}()
	willPanic()
}

func identifyPanic() string {
	var name, file string
	var line int
	var pc [16]uintptr
	n := runtime.Callers(3, pc[:])
	for _, pc := range pc[:n] {
		fn := runtime.FuncForPC(pc)
		if fn == nil {
			continue
		}
		file, line = fn.FileLine(pc)
		name = fn.Name()
		if !strings.HasPrefix(name, "runtime.") {
			break
		}
	}
	return fmt.Sprintf("%v:%v:%v", file, name, line)
}

What did you expect to see?
The expected output is "/Users/wsh/go/src/github.com/jxskiss/gopkg/tt.go:main.willPanic:18".
But I got "... tt.go:main.willPanic:17".
What did you see instead?
/Users/wsh/go/src/github.com/jxskiss/gopkg/tt.go:main.willPanic:17
goroutine 1 [running]:
runtime/debug.Stack()
        /Users/wsh/sdk/gotip/src/runtime/debug/stack.go:24 +0x65
main.withRecover.func1()
        /Users/wsh/go/src/github.com/jxskiss/gopkg/tt.go:26 +0x74
panic({0x1092e60, 0x10c1928})
        /Users/wsh/sdk/gotip/src/runtime/panic.go:838 +0x207
main.willPanic(...)
        /Users/wsh/go/src/github.com/jxskiss/gopkg/tt.go:18
main.withRecover()
        /Users/wsh/go/src/github.com/jxskiss/gopkg/tt.go:29 +0x70
main.main()
        /Users/wsh/go/src/github.com/jxskiss/gopkg/tt.go:11 +0x17

If I change the line abc = "1234" in willRecover to assigning to a local variable, the output is correct.

That's not a problem with runtime.Callers, but with runtime.FuncForPC. From docs:

To translate these PCs into symbolic information such as function names and line numbers, use CallersFrames. CallersFrames accounts for inlined functions and adjusts the return program counters into call program counters. Iterating over the returned slice of PCs directly is discouraged, as is using FuncForPC on any of the returned PCs, since these cannot account for inlining or return program counter adjustment.

So please close it :)


[BUG] Azure functions Service Bus trigger: SessionLockLost after previous run timeouts

Library name and version
Microsoft.Azure.WebJobs.Extensions.ServiceBus 5.9.0
Describe the bug
When Session Service bus trigger timeouts, second re-run gets SessionLockLost.
MessageLock is set to 30s in service bus queue
Expected behavior
The session lock is not lost.
Actual behavior
Every run ends in timeout (which is correct), but the second run contains also this error:

Azure.Messaging.ServiceBus: The session lock has expired on the MessageSession. Accept a new MessageSession. TrackingId:973f37c90000eca30000da4264269580_G16_B17, SystemTracker:G16:240034969:amqps://jm73010.servicebus.windows.net/-6cc1e03f;0:5:6:source(address:/myqueue,filter:[com.microsoft:session-filter:]), Timestamp:2023-03-31T08:14:09 (SessionLockLost). For troubleshooting information, see https://aka.ms/azsdk/net/servicebus/exceptions/troubleshoot.

Happening in local debug environment as well as in azure with this simple function.
This is annoying because session messages should not run concurrently but they are (in azure) in this case due to loosing session lock.
All logs from run:

[2023-03-31T08:10:40.909Z] Executing 'Function1' (Reason='(null)', Id=06e22585-f628-4670-96d7-c7b4ebf78f30)
[2023-03-31T08:10:40.912Z] Trigger Details: MessageId: ba8e7ae5fb2845059279546b5ae313c0, SequenceNumber: 2, DeliveryCount: 5, EnqueuedTimeUtc: 2023-03-30T10:32:09.2810000+00:00, LockedUntilUtc: 9999-12-31T23:59:59.9999999+00:00, SessionId: ses2
[2023-03-31T08:10:40.929Z] C# ServiceBus queue trigger function processing message: mes2
[2023-03-31T08:10:44.532Z] Host lock lease acquired by instance ID '00000000000000000000000011C92764'.
[2023-03-31T08:12:40.937Z] Timeout value of 00:02:00 exceeded by function 'Function1' (Id: '06e22585-f628-4670-96d7-c7b4ebf78f30'). Initiating cancellation.
[2023-03-31T08:12:40.987Z] Executed 'Function1' (Failed, Id=06e22585-f628-4670-96d7-c7b4ebf78f30, Duration=120113ms)
[2023-03-31T08:12:40.988Z] Microsoft.Azure.WebJobs.Host: Timeout value of 00:02:00 was exceeded by function: Function1.
[2023-03-31T08:12:41.021Z] Message processing error (Action=ProcessMessageCallback, EntityPath=myqueue, Endpoint=jm73010.servicebus.windows.net)
[2023-03-31T08:12:41.022Z] Microsoft.Azure.WebJobs.Host: Timeout value of 00:02:00 was exceeded by function: Function1.
[2023-03-31T08:12:41.156Z] Executing 'Function1' (Reason='(null)', Id=a79a835f-95b0-408b-b031-38ea56d09302)
[2023-03-31T08:12:41.157Z] Trigger Details: MessageId: ba8e7ae5fb2845059279546b5ae313c0, SequenceNumber: 2, DeliveryCount: 6, EnqueuedTimeUtc: 2023-03-30T10:32:09.2810000+00:00, LockedUntilUtc: 9999-12-31T23:59:59.9999999+00:00, SessionId: ses2
[2023-03-31T08:12:41.158Z] C# ServiceBus queue trigger function processing message: mes2
[2023-03-31T08:14:41.172Z] Timeout value of 00:02:00 exceeded by function 'Function1' (Id: 'a79a835f-95b0-408b-b031-38ea56d09302'). Initiating cancellation.
[2023-03-31T08:14:41.193Z] Executed 'Function1' (Failed, Id=a79a835f-95b0-408b-b031-38ea56d09302, Duration=120037ms)
[2023-03-31T08:14:41.194Z] Microsoft.Azure.WebJobs.Host: Timeout value of 00:02:00 was exceeded by function: Function1.
[2023-03-31T08:14:41.197Z] Message processing error (Action=ProcessMessageCallback, EntityPath=myqueue, Endpoint=jm73010.servicebus.windows.net)
[2023-03-31T08:14:41.197Z] Microsoft.Azure.WebJobs.Host: Timeout value of 00:02:00 was exceeded by function: Function1.
[2023-03-31T08:14:41.206Z] Message processing error (Action=Abandon, EntityPath=myqueue, Endpoint=jm73010.servicebus.windows.net)
[2023-03-31T08:14:41.207Z] Azure.Messaging.ServiceBus: The session lock has expired on the MessageSession. Accept a new MessageSession. TrackingId:973f37c90000eca30000da4264269580_G16_B17, SystemTracker:G16:240034969:amqps://jm73010.servicebus.windows.net/-6cc1e03f;0:5:6:source(address:/myqueue,filter:[com.microsoft:session-filter:]), Timestamp:2023-03-31T08:14:09 (SessionLockLost). For troubleshooting information, see https://aka.ms/azsdk/net/servicebus/exceptions/troubleshoot.

Reproduction Steps
Function:
using System;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Azure.WebJobs;
using Microsoft.Extensions.Logging;

namespace FunctionApp5
{
    public class Function1
    {
        [FunctionName("Function1")]
        public async Task Run([ServiceBusTrigger("myqueue", Connection = "myservicebus", IsSessionsEnabled = true)] string myQueueItem,
            ILogger log, CancellationToken cancellationToken)
        {
            log.LogInformation($"C# ServiceBus queue trigger function processing message: {myQueueItem}");

            await Task.Delay(TimeSpan.FromMinutes(3), cancellationToken);

            log.LogInformation($"C# ServiceBus queue trigger function processed message: {myQueueItem}");
        }
    }
}

host.json
{
  "version": "2.0",
  "logging": {
    "applicationInsights": {
      "samplingSettings": {
        "isEnabled": true,
        "excludedTypes": "Request"
      }
    }
  },
  "functionTimeout": "00:02:00",
  "extensions": {
    "serviceBus": {
      "maxAutoLockRenewalDuration": "00:03:00",
      "maxConcurrentCalls": 1,
      "maxConcurrentSessions": 1
    }
  }
}

Environment
OS Name:     Windows
OS Version:  10.0.22621
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\7.0.202\

When working with a session function, the maxAutoLockRenewalDuration refers to how long the trigger will renew the session lock. Because it is set to 3 minutes, the session lock is lost after 3 minutes (probably around 3 minutes 30 seconds based on the lock duration being 30s). So when the second function execution times out and the trigger attempts to abandon the message, 4 minutes have elapsed (2 min + 2 min timeout), and the session lock has already been lost.

We raised the timeout to 2h. Your answer solved our issue. THX.


fortran/install.py  report error  at line 49

when I try to run "python install.py --enable-fortran" , it report fail.
It failed at line 49 of file fortran/install.py
subprocess.check_call( [ pip, 'install', 'fortran-language-server' ] )
I try to change the code as the following, it is  worked .
subprocess.check_call( [ 'pip', 'install', 'fortran-language-server' ] )
I hop it is useful .

def Main():
  npm = FindExecutableOrDie( 'pip', 'pip is required to install fortls.' )
  subprocess.check_call( [ pip, 'install', 'fortran-language-server' ] )

Yeah... that npm = should have been pip =. I already applied the change to master. Thanks for the report.


fix: upgrade untool packages

As untool has increased the minimum version of react and react-dom peer dependenies to ^16.4.0, we should do the same.


fix report config file err

closes #89

test: https://github.com/RamanaReddy0M/workflow-test/actions/runs/10093424443/job/27909098941


Vulkan canvas_item shader different to GLS3

Godot version
v4.0.beta.custom_build [380fba627]
System information
Windows 10, Vulkan
Issue description
Porting projects with complex shaders from 3.x GLS3 to 4.x Vulkan, trying to fix what appears broken.
I've tried to strip it down to simpler parts that still showcase the issue. A ShaderMaterial applied to a ColorRect. None of the 'texture_filter' options seem to have any impact, nor 'texture_repeat' options in the node (which makes sense to me when directly modifying 'COLOR' in a canvas_item).
Godot 3.5:

Godot 4 [380fba627]:

I've tried different render modes to no avail, maybe there's a project setting I'm missing. I know 'MODULATE' is gone and 'COLOR' has new behaviour but it doesn't seem related.
Steps to reproduce
Same shader code on both projects:
shader_type canvas_item;

float hash12(vec2 p) {
	return fract(sin(dot(p, vec2(12.9898,12.1414))) * 83758.5453);
}

float noise(vec2 n) {
	vec2 v2_floor = floor(n);
	vec2 v2_fract = fract(n);
	float m1 = mix(hash12(v2_floor), hash12(v2_floor + vec2(1.0, 0.0)), v2_fract.x);
	float m2 = mix(hash12(v2_floor + vec2(0.0, 1.0)), hash12(v2_floor + vec2(1.0)), v2_fract.x);
	float m3 = mix(m1, m2, v2_fract.y);
	return m3;
}

void fragment() {
	vec2 v_uv = UV*5.0;
	float n = noise(v_uv);
	COLOR = vec4(n);
}

Minimal reproduction project
Shader Issue 4.x.zip
Shader Issue 3.x.zip

Likely related to the fact that COLOR behavior is different in 4.0

I don't think it's related to COLOR, but I could be wrong. It's as if the UV is being degraded over time quickly, which is a problem with shaders that use TIME. I've updated the MRP to use a better hash by default and show the problem in a different way (also removed the .godot folders, sorry about that).
4.x:

3.x:

New MRPs (also edited in OP):
Shader Issue 4.x.zip
Shader Issue 3.x.zip

I can't reproduce the issue on an intel integrated GPU with PopOS 22.04 and running current master f692b476869c14023b342c12efc21cb5cd6002b7
The result looks fine:

I can't reproduce the issue on an intel integrated GPU with PopOS 22.04 and running current master [f692b47]

Can you post a pic from the new MRP, please? I see the issues on a GTX 970.

@Lippanon

Thank you, I'll try updating my drivers and followup later.

It could be an issue from using sin in the hash function see e.g. https://www.shadertoy.com/view/4djSRW

It could be an issue from using sin in the hash function see e.g. https://www.shadertoy.com/view/4djSRW
If you notice the new MRP, it's using a different hash for that reason, without sin. I left the older hash for archive reasons, but it's not in use.

@Lippanon Can you test the same shader in shadertoy to see if you get the issue there as well?
here is the code converted to shadertoy:
float hash12(vec2 p) {
	return fract(sin(dot(p, vec2(12.9898,12.1414))) * 83758.5453);
}

float noise(vec2 n) {
	vec2 v2_floor = floor(n);
	vec2 v2_fract = fract(n);
	float m1 = mix(hash12(v2_floor), hash12(v2_floor + vec2(1.0, 0.0)), v2_fract.x);
	float m2 = mix(hash12(v2_floor + vec2(0.0, 1.0)), hash12(v2_floor + vec2(1.0)), v2_fract.x);
	float m3 = mix(m1, m2, v2_fract.y);
	return m3;
}

vec4 fragment(vec2 UV) {
	vec2 v_uv = UV*15.0;
	float n = noise(v_uv);
	return vec4(n);
}

void mainImage( out vec4 fragColor, in vec2 fragCoord )
{
    // Normalized pixel coordinates (from 0 to 1)
    vec2 uv = fragCoord/iResolution.xy;

    // Time varying pixel color

    // Output to screen
    fragColor = fragment(uv);
}

@clayjohn Here's my output on shadertoy with that code:

It does appear correct in shadertoy.
I also tested other variants that appear broken for me in 4.x, and they also seem correct in shadertoy.

This happens to me. Tested in Godot 3.5.1 (GLES3), Godot 4.0 (Vulkan, GLES3), even with a GLSL shader compiled via RenderingDevice. Same result.
Adding a non-constant term to the hash function makes it work
float hash12(vec2 p) {
	p += min(TIME,0.0);
	return fract(sin(dot(p, vec2(12.9898,12.1414))) * 83758.5453);
}

This happens to me. Tested in Godot 3.5.1 (GLES3), Godot 4.0 (Vulkan, GLES3), even with a GLSL shader compiled via RenderingDevice. Same result.
Adding a non-constant term to the hash function makes it work
float hash12(vec2 p) {
	p += min(TIME,0.0);
	return fract(sin(dot(p, vec2(12.9898,12.1414))) * 83758.5453);
}

Thank you for the temp fix! I confirm that does work for me also, it fixes the artifacts. Pinging @clayjohn to let you know.

Has anyone tested this on newer Nvidia GPUs? (16 series, 20 series, 30 series and 40 series)

It seems to be be happening on newer Nvidia GPUs.
We are working on a sky_shader for Godot 4 Stable with another developper, he's on a 10 series and have no glitches. The same fresh project with his shader glitches the same way and i have a RTX 3080.

Not the latest (It's actually 531.18), but one of the latest. I'll try update my drivers to see if it change anything.

Just to update everyone on this issue. This is an NVidia Vulkan driver bug. I'm glad to here users have found a workaround, because there isn't really anything we can do. We just pass the shader code off to the GPU driver to compile.
Other people experience this same bug and NVidia hasnt done anything about it https://github.com/danilw/GPU-my-list-of-bugs and https://www.shadertoy.com/view/stK3WG
Just a note about the workaround, if used in a sky shader another value other than TIME should be used as using TIME will force sky shaders to update reflections each frame which is a costly operation.

The issue here originates from the line: fract(sin(dot(p, vec2(12.9898,12.1414))) * 83758.5453);. From what I have read, each manufacturer, and even each version of driver has different ways to handle sin(), and is generally inaccurate, causing these issues. If you are experiencing this issue on compute shaders, you can try p += min(float(gl_LocalInvocationID), 0.0);, in my case with a 1070, it solved the problem.
I recently upgraded to a Radeon card, and had similar issues, which were not resolved by the aforementioned workaround. Instead, I had to use a different hash function that omits the use of sin() entirely.
Here is the function I used:
float hash_fract(vec2 p)
{
p  = fract( p*0.3183099+.1 );
p = 17.0;
return -1.+2.fract( p.xp.y(p.x+p.y) );
}

As already stated in https://github.com/godotengine/godot/issues/67150#issuecomment-1343330054, it also happens when using sinless hashes. The MRP is using a sinless hash.
Celyk's non-constant term work-around works perfectly with any hash I've tested aswell.

I only mention it because despite using the p += min(float(gl_LocalInvocationID), 0.0);, I still had the same issue while using a 7900XTX, where the issue was resolved by that workaround on my 1070.


feat: support performance config

Summary
#6226

Checklist

[x] Tests updated (or not required).
[x] Documentation updated (or not required).

Nice 😄

Thanks for your contribution


feat(ingestion): add Pulsar source

Add the ability to extract Apache Pulsar metadata
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@vanmeete Please merge master (due to some lib change there are some lint failures) and fix the lint in pulsar source itself. Very minor changes remaining and then we can get this merged in.


[libsigcpp] include failure

Describe the bug
Installation of libsigcpp puts include files in sigc++-3.0/sigc++/ so to include
#include <sigc++-3.0/sigc++/connection.h> is required. The issue is that internally in the library things are included with <sigc++config.h> and  <sigc++/functors/slot_base.h>.  sigc++config.h is not included in the port and even if it was the next include would fail since it doesn't have sigc++3.0 in the path.
Environment

OS: Win10
Compiler: VS 2019

To Reproduce
Steps to reproduce the behavior:

./vcpkg install libsigcpp
Compile code
Compile fails

Code is
#include <iostream>
#include <sigc++-3.0/sigc++/connection.h>
int main()
{
    std::cout << "Hello World!\n";
}

connection.h includes look like
#ifndef SIGC_CONNECTION_HPP
#define SIGC_CONNECTION_HPP
#include <sigc++config.h>
#include <sigc++/functors/slot_base.h>
#include <sigc++/weak_raw_ptr.h>

Expected behavior
Code should compile without errors
Failure logs
Rebuild started...
1>------ Rebuild All started: Project: ConsoleApplication1, Configuration: Debug Win32 ------
1>ConsoleApplication1.cpp
1>C:\code\vcpkg\installed\x86-windows\include\sigc++-3.0\sigc++\connection.h(21,10): fatal error C1083: Cannot open include file: 'sigc++config.h': No such file or directory
1>Done building project "ConsoleApplication1.vcxproj" -- FAILED.
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========

Note failure occurs with both x64 and x86 builds.

I am facing the same issue.

I will handle this issue today.

In the test code:
#include <sigc++/sigc++.h>

So the include path should be include/sigc++.
In SOURCE/CMakeLists.txt line 105:
set (LIBSIGCXX_INCLUDE_DIR	"${CMAKE_INSTALL_PREFIX}/lib/${PROJECT_NAME}-${SIGCXX_API_VERSION}/include")

Therefore, I think this is a upstream bug.
And for the config header sigc++config.h, it should be installed in include directly since some other header directly include it without any path.

Let's wait for the upstream reply first.

The upstream rejected my suggestion. I think we should fix this on the vcpkg side.

Is there any plan to address this? I just retried with the latest and got the same result.

This open issue is nearly one year old!
Can we afford such a long time?
@jhndnnqsc How can we better assist you?

No, this not a bug, you should use it with pkg-config.
find_package(PkgConfig REQUIRED)
pkg_search_module(LIBSIGCPP REQUIRED sigc++ sigc++-3.0)
target_include_directories(main PRIVATE "${LIBSIGCPP_INCLUDE_DIRS}")
target_link_libraries(main PRIVATE "${LIBSIGCPP_LINK_LIBRARIES}")


🐛 [cloud_firestore] startAfterDocument returns the last document on web, but not on mobile

Bug report
Describe the bug
Using the query.startAfterDocument() method on flutter web returns the last document with the query - but only on web. On iOS, it returns the next document onwards. As a result, paginated lists on web have a duplicated entry.
Steps to reproduce
As above.
Expected behavior
I would expect the behaviour to be consistent with iOS, that is, for the query to return ONLY the documents after the one provided.
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.5, on macOS 14.1.2 23B92 darwin-arm64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.85.1)
[✓] Connected device (3 available)
    ! Error: Browsing on the local area network for George’s Apple Watch. Ensure the device is unlocked
      and discoverable via Bluetooth. (code -27)
[✓] Network resources

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
- cloud_firestore 4.13.6 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- emoji_picker_flutter 1.6.3 [flutter flutter_web_plugins plugin_platform_interface shared_preferences]
- faker 2.1.0 [crypto]
- firebase_auth 4.15.3 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 2.24.2 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_ui_auth 1.11.0 [email_validator firebase_auth firebase_core firebase_dynamic_links firebase_ui_localizations firebase_ui_oauth firebase_ui_shared flutter flutter_localizations meta]
- fl_chart 0.65.0 [equatable flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math web sky_engine]
- provider 6.1.1 [collection flutter nested]
- share_plus 7.2.1 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32]
- syncfusion_flutter_charts 24.1.41 [flutter intl vector_math syncfusion_flutter_core]
- uuid 4.2.2 [crypto sprintf meta]

dev dependencies:
- flutter_lints 2.0.3 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math async boolean_selector characters collection material_color_utilities meta source_span stream_channel string_scanner term_glyph web]

transitive dependencies:
- _flutterfire_internals 1.3.16 [collection firebase_core firebase_core_platform_interface flutter meta]
- args 2.4.2
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- characters 1.3.0
- clock 1.1.1
- cloud_firestore_platform_interface 6.0.10 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 3.8.10 [_flutterfire_internals cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.18.0
- cross_file 0.3.3+8 [meta web]
- crypto 3.0.3 [typed_data]
- desktop_webview_auth 0.0.14 [crypto flutter http flutter_web_plugins plugin_platform_interface]
- email_validator 2.1.17
- equatable 2.0.5 [collection meta]
- fake_async 1.3.1 [clock collection]
- ffi 2.1.0
- file 7.0.0 [meta path]
- firebase_auth_platform_interface 7.0.9 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.8.12 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser js meta]
- firebase_core_platform_interface 5.0.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.10.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_dynamic_links 5.4.8 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_interface]
- firebase_dynamic_links_platform_interface 0.2.6+16 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_ui_localizations 1.9.0 [flutter flutter_localizations path]
- firebase_ui_oauth 1.4.15 [desktop_webview_auth firebase_auth firebase_ui_auth firebase_ui_shared flutter_svg flutter]
- firebase_ui_shared 1.4.1 [flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math web]
- flutter_svg 2.0.9 [flutter vector_graphics vector_graphics_codec vector_graphics_compiler]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math web]
- http 1.1.2 [async http_parser meta web]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- intl 0.18.1 [clock meta path]
- js 0.6.7 [meta]
- lints 2.1.1
- matcher 0.12.16 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.5.0 [collection]
- meta 1.10.0
- mime 1.0.4
- nested 1.0.0 [flutter]
- path 1.8.3
- path_parsing 1.0.1 [vector_math meta]
- path_provider 2.1.1 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- path_provider_android 2.2.1 [flutter path_provider_platform_interface]
- path_provider_foundation 2.3.1 [flutter path_provider_platform_interface]
- path_provider_linux 2.2.1 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.1.1 [flutter platform plugin_platform_interface]
- path_provider_windows 2.2.1 [ffi flutter path path_provider_platform_interface win32]
- petitparser 6.0.2 [meta]
- platform 3.1.3
- plugin_platform_interface 2.1.7 [meta]
- share_plus_platform_interface 3.3.1 [cross_file flutter meta mime plugin_platform_interface path_provider uuid]
- shared_preferences 2.2.2 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- shared_preferences_android 2.2.1 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.3.4 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.3.2 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.3.1 [flutter plugin_platform_interface]
- shared_preferences_web 2.2.2 [flutter flutter_web_plugins shared_preferences_platform_interface web]
- shared_preferences_windows 2.3.2 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- sky_engine 0.0.99
- source_span 1.10.0 [collection path term_glyph]
- sprintf 7.0.0
- stack_trace 1.11.1 [path]
- stream_channel 2.1.2 [async]
- string_scanner 1.2.0 [source_span]
- syncfusion_flutter_core 24.1.41 [vector_math flutter]
- term_glyph 1.2.1
- test_api 0.6.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- typed_data 1.3.2 [collection]
- url_launcher_linux 3.1.1 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.2.0 [flutter plugin_platform_interface]
- url_launcher_web 2.2.2 [flutter flutter_web_plugins url_launcher_platform_interface web]
- url_launcher_windows 3.1.1 [flutter url_launcher_platform_interface]
- vector_graphics 1.1.9+1 [flutter vector_graphics_codec]
- vector_graphics_codec 1.1.9+1
- vector_graphics_compiler 1.1.9+1 [args meta path_parsing xml vector_graphics_codec path]
- vector_math 2.1.4
- web 0.3.0
- win32 5.1.1 [ffi]
- xdg_directories 1.0.3 [meta path]
- xml 6.5.0 [collection meta petitparser]

Hi @leidig54, thanks for filing the issue. Could you please provide a complete minimal reproducible code sample in a repo that we can clone so that we can investigate this issue?
Thank you


Bugfix: padding offsets selection

Summary of the Pull Request
Padding used to offset selection. Fixes #660.

References

PR Checklist

[ ] Closes #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
Created _GetTerminalPosition() to encompass some of this logic and prevent this kind of stuff from happening again. Also, just nice to wrap everything up into a function call.
To the team: this was already somewhat reviewed back before we went on GitHub. So if you have a deja vu feeling, that's why.

/azp run


There's no way to get the maximun touch count from Input

Current values:

AndroidInput: public static final int NUM_TOUCHES = 20;
IOSInput: static final int MAX_TOUCHES = 20;
LwjglInput: implicitly 1 via eg. if (pointer > 0) return false;
MockInput: implicitly 0 via eg. return false
Lwjgl3Input: implicitly 1 via eg. return pointer == 0? isTouched(): false;
...

I would be great to bring this into the Input interface, something like int getMaxTouches(), so we can loop over all of the possible pointers and check whether they're touched down and what their coordinates are.

If this is something that could be accepted and if it helps I'm willing to submit a pull request for this.


FIX-#3736: Don't use a 2-d array to set a categorical column.

Signed-off-by: mvashishtha<EMAIL_ADDRESS>
What do these changes do?
Work around https://github.com/pandas-dev/pandas/issues/44703 by not converting a categorical scalar to a 2-d array to set a categorical column.

I think so. In contrast to the first snippet here, this seems to work on both Pandas and Modin 0.12:
import modin.pandas as pd
from numpy import array
df = pd.DataFrame({"status": ["a", "b", "c"]})
df.loc[:1, "status"] = "a"

@vnlitvinov

No doubt this is working... I just wonder if we can properly fix it without waiting for pandas, or are we upstream-blocked?

There is a fix PR out for https://github.com/pandas-dev/pandas/issues/44703, but we decided at the meeting on December 3 to not wait until that PR is released.


Yul compilation failed: * Line 3, Column 42\n  Bad escape sequence in string\nSee Line 3, Column 16643 for detail.\n* Line 5, Column 38\n  Extra non-whitespace after JSON value.\n

Compiling this file:
contract Foo:
    event MyEvent:
        s: string26
        u: u256
        s: string42
        s: string100
        a: address
        s: string13
        s: string100
    pub def __init__(s1: string42, s2: string26, u: u256,
                     s3:string100, a:address):
      emit MyEvent(s2,u,s1,s3,a,"stat\c string",string100(""))
    pub def return_casted_static_string() -> string100:
      return string100("foo")

thread 'main' panicked at 'Yul compilation failed: {"errors":[{"component":"general","formattedMessage":"* Line 3, Column 42\n  Bad escape sequence in string\nSee Line 3, Column 16643 for detail.\n* Line 5, Column 38\n  Extra non-whitespace after JSON value.\n","message":"* Line 3, Column 42\n  Bad escape sequence in string\nSee Line 3, Column 16643 for detail.\n* Line 5, Column 38\n  Extra non-whitespace after JSON value.\n","severity":"error","type":"JSONError"}]}', compiler/src/lib.rs:49:27
stack backtrace:
   0: rust_begin_unwind
             at /rustc/c0b64d97beebb09325b5587abed39f4f1621026f/library/std/src/panicking.rs:493:5
   1: std::panicking::begin_panic_fmt
             at /rustc/c0b64d97beebb09325b5587abed39f4f1621026f/library/std/src/panicking.rs:435:5
   2: fe_compiler::compile
   3: fe::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Aborted

On latest github master, built with
[profile.dev]
debug = true
panic = "abort"

for fuzzing.  Using https://github.com/agroce/afl-compiler-fuzzer + afl.rs.

This is a case of #329

This is fixed by the new parser (#346). Thanks @agroce!
error: String contains an invalid escape sequence
   ┌─ ../eth/badescape.fe:12:33
   │
12 │       emit MyEvent(s2,u,s1,s3,a,"stat\c string",string100(""))
   │                                 ^^^^^^^^^^^^^^^


Possibility of generating cache

In some applications (or endpoint, depends on the use) cache is required to not be accessing the database (PostgreSQL) in every request.
store key/value:

key: endpoint + query string (GET)
value: return body

configuration (TOML/ENV):
[cache]
time = 10M
store = bolt
sotrePath = "./"

Stores (adapters):

bolt (default, to have possibility to put embedded)
redis
memcached

Times:

S or s: second
M or m: minute
H or h: hour
D or d: day

If there is no cache in the configuration register (access the Bank in real time).

There is anybody working on this?

I'm just worried with invalidation mechanism. Query heavy update datasets can lead us to wrong results using just a timeout.


add init container for configs, fixes #4666

What this PR does / why we need it:
Adds an init container to copy CouchDB configs, since configMap mounts are now read-only, and the CouchDB image has an explicit chown -R.
Which issue this PR fixes
fixes #4666
Special notes for your reviewer:
/cc @kocolosk

CLA signed

/assign

Fixed in #5440


Support using OCP4 'latest', 'nightly', or explicit versions

pipeline/common_stages.groovy:

Rewrite if/else conditional to switch for greater flexibility & logical ease
Allow use of explicit versions (4.1.11, 4.1.9, etc.) on mirror
Support use-case for latest and nightly variable values

roles/ocp4_cluster_deploy/defaults/main.yml:

Set openshift_installer_release to latest
Add variables to support using nightly and latest

roles/ocp4_cluster_deploy/tasks/get_ocp4_installer.yml:

Consumes get_ocp4_nightly.yml
Improve support for nightly
Add support for latest

roles/ocp4_cluster_deploy/tasks/get_ocp4_nightly.yml:

Removed; consumed by get_ocp4_installer.yml

roles/login_ocp/defaults/main.yml:

Update release_url
Reorganize & comment variables now set dynamically

roles/login_ocp/tasks/download_oc_binary.yml:

Add logic to determine & use latest version


Abandoning slugs while keeping slug history

This is more of a question regarding a best/good practice than an issue.
I've been using mongoid_slugs for a while on my website. Now I would like to remove them and to switch back to using the db ids. I could remove the slugs keyword and the include statement from my model to get the result I want. But this would make me lose my slug history, which I don't want, as that could have unforseen negative consequences with Google.
What's the best practice for abandoning slugs while keeping the slug history?
I tried using slug :id, history: true but this suffixes my slugs with -1<PHONE_NUMBER>4c2b39e6c49a73-1, as it should if the id is in the slug table by default - although it does not get listed on document.slugs. What I am looking for is a way to tell mongoid_slug to use the id as the slug, instead of the last item of the slugs array.

I would remove mongoid-slug and add field :_slugs, type: Array, ensure that there's an index with index :_slugs, unique: true and reimplement a lookup in a higher level of the application that falls back to _slugs whenever something doesn't look like an ID and/or cannot be found.

It's definitely a good solution. I guess I was hoping for a built-in mechanism to achieve this kind of behavior. Like a "disabled" flag that you can set on the slug field so that the reverse lookup would still work, but the default id field gets served as the slug from now on. But probably my case is not common enough to warrant an option like that.
The problem for me with your solution is that I'm hesitant to add extra code just to achieve this behavior. So if there is no built-in solution, I am tending to simply disabling the slugs and having to live with the lost history, whatever repercussions that may entail with Google.

Feel free to PR something that accomplishes that. Instead of a disabled function I would want to split up the Mongoid::Slug module into a Mongoid::Slug::Find and Mongoid::Slug::Create so that you can include one, the other or both functionalities. Will leave this open as a feature request.
Other than above, you can roll your own Mongoid::Slug that just implements the find part and you won't have to change anything in your classes after removing the gem.


[AutoRelease] t2-connectedvmware-2022-08-08-58427(Do not merge)

https://github.com/Azure/sdk-release-request/issues/3065
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=3325

issue link:https://github.com/Azure/sdk-release-request/issues/3065


Fixes #121 IntelliSense suggestions in exceptions are missing

Fixes #121 IntelliSense suggestions in exceptions are missing
Only keep suggesting exceptions when the grouping is the first item.
(Doesn't meet the bar, but it's such a trivial fix to something new since 2.1 that if people want to convince me to take it I won't argue too hard.)

I'm okay with taking it.

:+1: lgtm


⚠ Bofrost.at has degraded performance

In 5478128, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1307 ms

Resolved: Bofrost.at performance has improved in 8072d25 after 13 minutes.


Added Kanadarm to NetKAN

#rebuild

failures are caused by jenkins itself

Oh, it already is there :)


Tracking issue for improvements to install_KLU_Sundials.py and build infrastructure

[!WARNING]
Following an imminent migration for the build system and/or choice of build-backend for PyBaMM, not all of the listed points may not be applicable for completion. Please refer to #3564 for more information.

There are a number of improvements that can be introduced to improve the installation of the build-time dependencies (SuiteSparse and SUNDIALS) and the IDAKLU extension module and general improvements to the installation scripts:

[x] Incorporate the SHA-256 hashes of the SuiteSparse and SUNDIALS release tarballs as constants in the script in order to save bandwidth and skip downloading the tarball every time. (#3719)
[x] Do not install locally if the binaries are already present at the installation location (#3418) (#3719)
[x] Set parallel builds via the use of the CMAKE_BUILD_PARALLEL_LEVEL environment variable (#3646)
[x] Introduce PEP 723 support (needs triage and should be reviewed at a later time in 2024) (#3647) (#3716)
[ ] Establish local SUNDIALS and SuiteSparse installations in a folder sundials_installed/ by adjusting CMAKE_INSTALL_PREFIX instead of modifying the .local/ folder and check this folder to establish whether the IDAKLU extension module should be compiled or not in the build_ext command class in setup.py (adding pybind11 as a build-time dependency should be possible in #3480 after this)
[ ] Build just IDAS instead of all SUNDIALS components, considering that is what we link to for the IDAKLU target
[ ] Set relevant SUNDIALS and SuiteSparse compilation options such as skipping building the examples (done in #3569), link to OpenBLAS instead of Apple's Accelerate on macOS since NumPy and SciPy are not recommending it for now
[ ] On macOS, we use compiler options to find libomp, they can be removed and we can use pkg-config from Homebrew that should be able to do it automatically. The reason for this is because Apple Clang does not come with the OpenMP specification – however, other compilers such as LLVM and GCC do (noted by @kratman: we install gcc in CI for macOS, but it is never used!)
[x] Remove wget as a dependency and use urllib from the Python standard library for downloading. In addition to this, use multiprocessing.Pool or concurrent.futures to download both tarballs in parallel to save time (#3719)
[ ] On platforms we don't support, the sdist is used to install PyBaMM, and the IDAKLU solver which is optional cannot be installed unless installing from source. To provide a means to attempt IDAKLU compilation, a --extra-options command-line flag can be added to the pip install pybamm comand that can pass to setup.py. Therefore, the users should have to manually opt-in to the compilation (the build option should be off by default). For this, pybind11 should be a build-time dependency (see #3480). This requires the points mentioned below:
[ ] Run install_KLU_Sundials.py in a subprocess via a build_py command class for macOS and Linux in setup.py if the compilation is opted in for. This can eliminate the use of nox -s pybamm-requires and a single command pip install -e . would do both things
[ ] Add CMakeLists.txt and other relevant files such as FindSuiteSparse.cmake and FindSUNDIALS.cmake to the SDist via the MANIFEST.in file, otherwise CMake will raise an error about a missing project status

These tasks have a mixture of easy and medium difficulty. Some of them have a higher priority than the rest, I am glad to take those up myself.

Closing this issue and moving individual remaining items over to #3564 – they can be tracked better there and that issue is now more relevant to the discussion.


test(devops): pipeline duration

This is just a test to compare the duration of the pipeline if we run bundlewatch as separate job. We don't expect much improvements here, since the script is so fast. 🤷🏽♂

It's not super terrible, but not great either. 6 seconds of 40 seconds job time spent doing the actual work.


Changes to obs field doesn't (seem to) change update_at for the parent obs

Steps:

create an observation in iNat (for my specific case, it's all via the API)
add an obs field for that observation (the /observation_field_values endpoint)
the updated_at for the obs will (correctly) update, take note of that value
clobber that existing obs field by POSTing to the /observation_field_values endpoint with the same observation_id and observation_field_id but a different value
check the updated_at attribute for the observation again

Expected:
The updated_at field has been updated to reflect when we touched the obs field.
Actual:
The updated_at field remains unchaged. It's worth noting that photos do not suffer this issue and will cause the updated_at field to be updated.
If implementing this is too much work, perhaps just expose the {created,updated}_at fields for the obs fields (ofvs) so clients can compute their own effective updated_at. These values are in the response to the POST/PUT/DELETE call to the obs field endpoint but not in the response for the GET to the observation endpoint, and there's no GET for the obs field values. This workaround sub-optimal but passable.
The use case is: our app keeps a record in it's local datastore that represents the edit operation and we wait to see the updated_at date change as confirmation of success. It works great for photos and changes to the core observation (species_guess, etc), just not for obs fields.
This may be loosely related to https://github.com/inaturalist/inaturalist/issues/2429 in the sense that some changes to an observation aren't reflected in the updated_at attribute.

I could not replicate this POST /v1/observation_field_values or DELETE /v1/observation_field_values/:id. Both set the updated_at attribute of the observation to the current datetime for me. PUT /v1/observation_field_values/:id is currently not designed to touch the observation, but maybe it should. First, though, can you double check that POST and DELETE are really not changing the observation record for you? If that's the case, maybe you could supply some examples with curl?

So it seems that it's only when you POST to clobber an existing value that the date is not changed. When you add a new field or delete a field, the date is updated. Sorry for not completely testing :disappointed: . I'll update the original issue.
Let's pick on this obs: https://www.inaturalist.org/observations/36689258 (https://api.inaturalist.org/v1/observations/36689258)
The obs iteself has updated_at: "2019-12-16T11:33:57+10:30".
It has an existing value for the only obs field was Hill crest. I just ran this curl to update the obs field value (yes, I'm using POST to clobber the existing value):
curl 'https://api.inaturalist.org/v1/observation_field_values' -H 'accept: application/json' -H 'authorization: eygetyourownapitokenLCJvYXV0aF9hcHBsaWNhdGlvbl9pZCI6Mzc1LCJleHAiOjE1Nzg2MTg5MDN9.13d7y-TH3yvGMoqeNkLHzge4C7TE2gFHRdje20AbMNV_Epy8XnKwgXpxNSCgu27DxJItFGh0ICqu9PiD_lV9_Q' -H 'content-type: application/json' --data-binary '{"observation_id":36689258,"observation_field_id":10432,"value":"Plain"}'

...and got a successful response:
{
  "id": 10614488,
  "observation_id": 36689258,
  "observation_field_id": 10432,
  "value": "Plain",
  "created_at": "2019-12-16T11:33:56.802+10:30",
  "updated_at": "2020-01-09T11:52:03.679+10:30",
  "user_id": 1591469,
  "updater_id": 1591469,
  "uuid": "3c348eeb-7cf5-4bd5-8f3e-1c34b233ce7e",
  "created_at_utc": "2019-12-16T01:03:56.802Z",
  "updated_at_utc": "2020-01-09T01:22:03.679Z"
}

Now if we check the obs again, we can see the updated_at for the obs has not changed. The obs field value has definitely updated too.
On another obs I have (https://api.inaturalist.org/v1/observations/36689672), I added an obs field (that was not already on the obs) and the updated_at is updated. Deleting that field also updated the updated_at date.

Thanks :smile:

This has been deployed so give it a try.

Just deployed to our dev inat instance and it's working great, thank you :tada:


Retry state needs verified

Add unit test
Add integration test
Add fuzzy test

currently, the retry state implement cannot work, should have refactory

fix by #320


Python Viewer: Clear displayed error post successful model load

Load a healthy model on the viewer using python -m mujoco.viewer --mjcf=model.xml
Now edit the model.xml to introduce a bug
Reload the viewer. The viewer correctly shows the compilation error
Now undo/fix the model edit/error
Hit reload on the viewer to pick the new model.

As there is no error, the model loads just fine
The old error from step 3 is on display. If my understanding is correct - there shouldn't be any error message on the display as the model load was successful

Version: MuJoCo 3.9
OS: Ubuntu 18.04

Can you check if this issue also happens with the native simulate app?

@saran-t Native simulate reloads the model fine and the error message disappears.

@kevinzakka beats me to this.
Thanks Kevin :)


Build in commonjs_strict mode

package statements removed from protocols, since in strict mode the whole namespace is exported instead of the package, and keeping the packages would have required changes in all js files that import protocols.
Had to rename one ConsensusService -> MirrorConsensusService, as there were two different entities named ConsensusService.
This mostly solves #267, apart from #268. I.e. with this patch, the only thing that remains polluting the global scope is:
> proto
{
  google: {
    protobuf: {
      BoolValue: [Function],
      BytesValue: [Function],
      DoubleValue: [Function],
      FloatValue: [Function],
      Int32Value: [Function],
      Int64Value: [Function],
      StringValue: [Function],
      UInt32Value: [Function],
      UInt64Value: [Function]
    }
  }
}

which comes fromgoogle/protobuf/wrappers.proto (see #268).

Thanks for the change here. I completely agree that commonjs_strict is the right way to do this. I was unaware it existed myself.

Interestingly enough, this did break everything.
UNIMPLEMENTED: Method not found: CryptoService/cryptoGetBalance

All transactions report UNIMPLEMENTED now.

Hm. This is interesting, as this was loaded correctly and test:unit passed. I'll check what's going on there.


Fragmented connections for SIDEWALK and BIKING lanes

Currently, the output CityGML files are missing some successor and predecessor connections. As for the car lanes, the successor and predecessor connections seem to be working fine. However, the lane types SIDEWALK and BIKING suffer from some unset successor and predecessor connections which leads to fragmented networks of those lane types. This is especially significant in intersection areas where many TrafficArea and TrafficSpace objects exist to model the curved street. This can be seen in the following image, showing the TrafficAreas and their TrafficSpace (red) elements.

There might be a way to set the right connections during the converting process. Otherwise, generating the missing connections using only the CityGML data  is a tedious task.

Thanks for reporting. The question is whether the original OpenDRIVE dataset contains this connection information or not.
Can you provide me with the OpenDRIVE file and another enlarged screenshot to find this exact location?
You can send it to me via<EMAIL_ADDRESS>

Thanks for providing the screenshot, @CodeMazeSolver. I double-checked and the TrafficSpaces shown in your image are missing a predecessor or successor relation because they are not connected in the OpenDRIVE dataset.


Failing to link while trying to build Godot on darwin/arm64

Godot version
master
System information
macOS 14.1, M1 SOC, LLVM 17, MoltenVK 1.2.6
Issue description
Trying to compile Godot on darwin/arm64 with MoltenVK fails at the linking step due to unresolved symbols.
Here's a link to the pastebin for the compilation logs, as it's over 3000 lines.
Steps to reproduce
Try building with the following:

LLVM 17
MoltenVK 1.2.6
macOS 14.1 arm64

Minimal reproduction project
N/A

CC @bruvzg

Please include the exact command you use to build Godot, and the exact commit you're building.

LLVM 17

Is it custom LLVM build or Xcode (which version?). Usually errors like these indicate you have object files built by newer compiler version with older linker, try cleaning up build tree and making a full build. Or it's possible that MoltenVK you are using is built with newer Xcode (either update Xcode or use custom MoletnVK build).

AFAIK there's no Xcode version released based on LLVM 17 yet, the current 15.0 and 15.1 beta are still on LLVM 16: https://en.wikipedia.org/wiki/Xcode#Toolchain_versions
So indeed this sounds like an unsupported configuration.

AFAIK there's no Xcode version released based on LLVM 17 yet, the current 15.0 and 15.1 beta are still on LLVM 16: https://en.wikipedia.org/wiki/Xcode#Toolchain_versions
So indeed this sounds like an unsupported configuration.

The build also fails with the included LLVM 15 from XCode.

Please include the exact command you use to build Godot, and the exact commit you're building.

scons platform=macos arch=arm64

@bruvzg @akien-mga This issue seems to be a duplicate of #82372 and is resolved by getting rid of binutils from brew.


v0.10.0 jenkins test

Plan of attack
Dividing test tasks into two categories, each of them has different workflow:

plugin test
framework test

Plugin test (except for dbt plugin`)
Create an issue(specific testing issue) for particular plugin you are working on, assign it to youself, and put a link in this issue.
Plugin Assignement:

Jenkins

For each of every plugin, the following operations are required, and must be presented as Checklist in specific testing issue:

[x] Main readme and plugin readme are up to date

[x] Trigger plugin with only required options and record following information
 [
  [
    {
      "Plugin": "jenkins",
      "Options": {}
    }
  ]
]

[x] Which board/repo you collected against?
[x] How many subtasks are executed by default?
[x] How long did it take to finish the whole process?
[x] How many records did each subtasks generated, and how many shoud it be according to data source if avaiable?
[x] What do you think of the plugin status? Is good enough for you? performance-wise, data-wise.

subtasks
api generated
data source

collectApiJobs
3
3

extractApiJobs
3
3

extractApiJobs
3
3

collectApiBuilds
11
11

extractApiBuilds
11
11

convertJobs
3
3

convertBuilds
11
11

[x] Trigger plugin with tasks field for those EnabledByDefault set to false

[x] Which board/repo you collected against?
[x] What subtasks did you specify?
[x] How long did it take to finish the whole process?
[x] How many records did each subtasks generated, and how many shoud it be according to data source if avaiable?
[x] What do you think of the plugin status? Is good enough for you? performance-wise, data-wise.

[x] Screen-shots or test-snipet that can show plugin works properly.
[x] Create issue for each and every bug you found during the whole process, and add link to plugin testing issue
[x] Fill out table on #1500 to what domain layer entities could a plugin provide, default means it was produced by default, optional means it was produced only when specified by using tasks field (aka. EnabledByDefault=false

finished