uh review?

client.py

[x] from .errors import * - don't use wildcard imports
[x] self.baseUrl = 'http://brawlstars-api.herokuapp.com/api/'  - should be self.base_url
[x] a blank __del__...?
[x] if tag is None: raise MissingArg('tag') - this is really useless, just don't make it an optional params and python handles it for you
[ ]

player = Player(data)
return player

i don't see the point of creating another variable here

[x] ^^ the 2 above for get_band
[x] get_player and get_profile should be aliases
[x] create an __str__
[ ] personally think get_brawlers and get_id is redundant and get_members
[ ] classes related to the above ^^

async client

[x] most stuff from above
[x] except Exception: - just do except:
[x] do an except for JSONDecodeError as i said in sharpbit's commit comments, it's because of heroku
[ ] a LOT of unnecessary coroutines that can just be functions

sidenote
am kinda tired atm so this isn't comprehensive, fix all these and ill look at it again
read this https://github.com/SharpBit/abrawlpy/issues/1
I don't think invalidarg or httperror for invalid tag is a good idea, a seperate exception should be raised for that.

1-3 Easy fixes.
4 How do you make it required? Just don’t specify a default value?
5-6 Legacy code, if its not a huge problem i wont touch it
7 How do you add aliases? Just create a new method with the same function but different name?
8 idk how to do that
9-10 I implemented that anticipating future endpoints. Also I like my stuff very object-oriented.
11-13 Ok
14 Can you provide examples? I’m not sure where await is required

Yes
How is it legacy code? 🤔
get_player = get_profile
google python str classes
all the class functions for profile, band, etc doesn't need to be coroutines

4 k
5-6 from my other wrapper cocasync
7 give example in context pls
8 k
14 but then they wont be asynchronous

what's the use for it to be asynchronous? those functions don't take up a lot of runtime and even if you call it "asyncly", it won't have much of an effect

ctrl+f __str__
http://www.greenteapress.com/thinkpython/html/book018.html

Ok I did most of them.
Stuff I am still confused about:

How to make method aliases

Stuff I didn't do

async client is supposed to be purely async, if they don't want async, they can just use the regular client
get_id, get_members, etc all return objects and i think it looks better that way
fix baseUrl to base_url because I can't find all the places where I used it and also nobody will want to get the base url so there's no point and its immutable anyways

method aliases: get_player = alias, or if in __init__, add self to both
idk what u an 4jr mean
idk ask 4jr he seems to think they are very unnecessary
use ctrl shift f in sublime text for that (find self.baseUrl in all open files and folders (default) and replace with self.base_url)

I still dont know what you mean
this is about asyncing and not asyncing
i just did
too lazy also all other attributes are camelCase cuz i didn't use camel killer box so this is for uniformity

after your get_player function, put this:

get_player = get_profile

k
k
4jr wants u to follow pep8 (he says it's more important than anything else, i think, except maybe copying code) and also, ctrl shift f is way easier then searching through yourself and fixing each one, so idk why you say "too lazy"

like this?

def get_player(self, tag):

        tag = tag.strip("#")
        tag = tag.upper()

        try:
            with self.session as session:
                resp = sesssion.get(f'{self.baseUrl}players/{tag}', headers=self.headers, timeout=self.timeout)
            if resp.status_code == 200:
                data = resp.json()
            elif 500 > resp.status_code > 400:
                raise HTTPError(resp.status_code)
            else:
                raise Error()
        except ValueError:
            raise MissingData('data')
        except:
            raise Timeout()

        data = Box(data)
        player = Player(data)
        return player
    get_player = get_profile

k
k
k

no, remove 4 spaces from the get_player = get_profile. It should be outside the function itself
um so yes or no?

it is unindented, the first line just got its indent removed
idk it would be weird for everything else to be camelCase and just that to be snake_case. example:

Attributes
player.base_url
player.trophies
player.highestTrophies
player.showdownVictories
Methods
player.get_band()
player.get_id()
It would feel weird to me if only one of the attributes were snake case while everything else was camel case because that was how i was differentiating between methods and variables

ok
the player class doesn't have that attribute... it's the client and async client

oh sorry but u can say the same for client too, even though client doesn't have any important attributes it would be weird for all other attributes to be camelCase except that one attribute of client.

idk how it's weird, it's pep8 m8

the only way i would switch it is if i used camel killer box for everything else but i dont want to because then ill be copying u since i dont know how to use it
also are u sure its get_player = get_profile and not get_profile = get_player

idk why you want it to be camelcase so much
oops yea switch it i made that same mistake on mine too

i dont want it to be camelcase so much. i want them all to be either snake case or camel case, and they were all camel case until now

@fourjr please help me convince this man to follow pep8 kthx

AEUORINAEIORNBON%(WN#%VASODI its the fucking api and ill probably keep them camel case unless u teach me how to use camel killer box

AEUORINAEIORNBON%(WN#%VASODI Class_That_Inherits_Box(data, camel_killer_box=True)
or just follow pep8 m8 so u don't have to change ur docs from camelCase to snake_case and ONLY one attribute instead of all. 🤷♂

what if the class doesn't inherit box

i thought all your classes inherit box

not client and asyncclient

could i make them inherit from box tho?

you don't need client to inherit from box

but i want to camel_kill client and asyncclient

um client doesn't have any attributes that the user needs, only methods, so it doesn't matter

then why does baseUrl need to be base_url its not like the user is going to use it anyways cuz its always the same thing

please stop replying to me

because people read source and it looks ugly

hey but on the bright side everything else is fixed right?

also i still dont understand the aliasing thing

alias is because some people call it player and some call it profile

no i know but how do i implement it

self.get_player = self.get_profile  in init

in __init__.py you should import * errors

u sure its not the other way around for get_profile

idk do what your program does :/
you get the concept right?

ok i changed all that

does session.close not work?

 Why make this library if you don't know how to use python?

@4rqm it's because he wanted to

Steal the brawlstars name
Make a better one than mine


Review use of Java varargs ... parameters in the runtime

Further to https://github.com/ceylon/ceylon-compiler/issues/1985 we should review all the uses of ... in the runtime to ensure the can't be invoked in an ambiguous way. In particular, ambiguity seems to arise when:

There's a variadic method and an overloaded fixed-arity method or
There's a variadic method that can be called will a single null argument

Done


Consider making emissions factors dynamic based on usage year

new calculations use most up to date emissions factors
consider way to not have this affect older data/calculations (use factor from the correct period of time)

seeking contributor

@ericksod The calculation can be even more accurate using real time grid intensity levels. https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/issues/972


Ensure script is not already executing

I'm running this schedule to run a script called TGForwarder.py:
import schedule import time import TGForwarder def job():         TGForwarder.run() schedule.every(25).seconds.do(job) while True:         schedule.run_pending()         time.sleep(1)
Is there a way to ensure that after the next 25 seconds are up, if the previous run through of TGFowarder.py is still running, it will pass (skip the execution of the script and check again the next time around) the script on that time around?

That's right! This library executes jobs on a single thread. If you need to run jobs in a separate thread, take a look at the parallel execution documentation. If you need more advanced multithreading you might be better off using APSchedule instead.


Build / IOS build failed (DVTAssertions error)

Build/Submit details page URL
No response
Summary
i get the following error when i try to build IOS with cache clear with:
eas build --platform ios --profile production --local --clear-cache
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: macOS 14.0
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.8.0 - /opt/homebrew/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 10.1.0 - /opt/homebrew/bin/npm
Managers:
CocoaPods: 1.13.0 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 23.0, iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10671973
Xcode: 15.0/15A240d - /usr/bin/xcodebuild
npmPackages:
@expo/metro-config: ~0.10.0 => 0.10.7
expo: ^49.0.0 => 49.0.8
react: 18.2.0 => 18.2.0
react-dom: 18.2.0 => 18.2.0
react-native: 0.72.5 => 0.72.5
react-native-web: ~0.19.6 => 0.19.7
npmGlobalPackages:
eas-cli: 5.4.0
Expo Workflow: managed
npx expo-doctor:
✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check dependencies for packages that should not be installed directly
✔ Check for common project setup issues
✔ Check npm/ yarn versions
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check for legacy global CLI installed locally
✔ Check that native modules do not use incompatible support packages
✔ Check that native modules use compatible support package versions for installed Expo SDK
✔ Check that packages match versions required by installed Expo SDK
Error output
[RUN_FASTLANE] Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
[RUN_FASTLANE] 2023-10-06 15:01:23.244 xcodebuild[32668:1121721] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22267/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103
[RUN_FASTLANE] Details:  createItemModels creation requirements should not create capability item model for a capability item model that already exists.
[RUN_FASTLANE] Function: createItemModels(for:itemModelSource:)
[RUN_FASTLANE] Thread:   <_NSMainThread: 0x6000029982c0>{number = 1, name = main}
[RUN_FASTLANE] Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
[RUN_FASTLANE] ** ARCHIVE FAILED **
[RUN_FASTLANE] Exit status: 65
Reproducible demo or steps to reproduce from a blank project
npx create-expo-app my-app
create and setup eas.json
eas build --platform ios --profile YOUR_PROFILE --local --clear-cache

Having this same issue as well

Same issue here too after updating to xCode 15.0 and macOS Sonoma 14.0 on M2 mac.

We have this problem with Sonoma and Xcode 15.... takes up 20% of all logs.

same issuea with sonoma and xcode 15

Same issue, Sonoma, XCode 15, on a M2 MacBook Air.
It's really problematic as it prevents to build the app locally 🥲

To fix an issue run iOS with env var --simulator='iPhone 15' or any preferred iPhone.
e.g.
"ios": "react-native run-ios --simulator='IPhone 15'",

Adding use_modular_headers! solved this issue. In my case, the firebase packages were the ones causing the issue

I believe that this is the same issue as here. The message that you are mentioning is only a warning. Usually Run Fastlane phase doesn't contain all of the logs. If you follow my instructions from  https://github.com/expo/eas-cli/issues/2111#issuecomment-1809954032 you should be able to access Xcode logs to see the real error there.
Let me know if it helps!

Same issue here:
Xcode 15.0.1
[RUN_FASTLANE] Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
[RUN_FASTLANE] 2023-11-30 12:33:37.325 xcodebuild[16491:86116] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22269/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103
[RUN_FASTLANE] Details:  createItemModels creation requirements should not create capability item model for a capability item model that already exists.
[RUN_FASTLANE] Function: createItemModels(for:itemModelSource:)
[RUN_FASTLANE] Thread:   <_NSMainThread: 0x7f982d7098c0>{number = 1, name = main}
[RUN_FASTLANE] Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
[RUN_FASTLANE] 2023-11-30 12:33:37.326 xcodebuild[16491:86116] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22269/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103
[RUN_FASTLANE] Details:  createItemModels creation requirements should not create capability item model for a capability item model that already exists.
[RUN_FASTLANE] Function: createItemModels(for:itemModelSource:)
[RUN_FASTLANE] Thread:   <_NSMainThread: 0x7f982d7098c0>{number = 1, name = main}
[RUN_FASTLANE] Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
[RUN_FASTLANE] ** ARCHIVE FAILED **
[RUN_FASTLANE] Exit status: 65

[RUN_FASTLANE] +---------------------------------------+
[RUN_FASTLANE] |           Build environment           |
[RUN_FASTLANE] +-------------+-------------------------+
[RUN_FASTLANE] | xcode_path  | /Applications/Xcode.app |
[RUN_FASTLANE] | gym_version | 2.217.0                 |
[RUN_FASTLANE] | sdk         | iPhoneOS17.0.sdk        |

    "expo": "^49.0.18",

Do we have an update regarding this issue? I am still facing this warning.


feat: Added scroll-to-top button in contributor's page

📋 Description

Added a scroll-to-top button in contributor's page which enhances the UX.
🔨 Changes Made

Added scroll-to-top button and its logic in "contributor.html"
Added its style in "contributor.css"
Formatted the file structure for better visibility.

✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[x] I have followed all the guidelines mentioned in CONTRIBUTING.md.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation (if applicable).
[x] I have tested it locally and it works fine.
[x] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[ ] Bug fix (non-breaking change which fixes an issue) 🐛

[x] New feature (non-breaking change which adds functionality) ✨

[x] UI enhancement (non-breaking change which enhances UI) 🎨

[ ] Documentation update 📚

Fixes #402

📸 Screenshots (if applicable)

Desktop

Phone

Tab

Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!

@Harshdev098 I have made the required changes. Please review it and add the 'gssoc-ext' and 'level2' tags.


chore(deps): update common-dev-assets digest to 9be2fba

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
ff4e109 -> 9be2fba

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.8.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Check coldcard version and request user to upgrade

Close #1343

the message is the same wether we choose PSWSH or taproo, maybe if taproot is selected we should ask for version 6.3.3?

the message is the same wether we choose PSWSH or taproo, maybe if taproot is selected we should ask for version 6.3.3?

We avoid to add more logic for now, it is past rc and goes straight into release.

tACK 7371c9df


aursearch: format long descriptions

Right now these are just wrapped around.

Looking at cower this looks more complex than expected:
https://github.com/falconindy/cower/blob/master/cower.c#L875
So I'd have to retrieve $COLUMNS et al, just because some people mistake the "Description" field for  "Popular fiction". Meh, delaying to 1.0.0.

From PKGBUILD(5)

pkgdesc
This should be a brief description of the package and its functionality. Try to keep the description to one line of text and to not use the package’s name.

Not sure why I should account for packages that ignore this guideline.


[481] Add extra environment files

Context
We have 3 additional environments that we'd like to control better - qa, staging and review
Changes proposed in this pull request
Add environment files and settings for 3 additional environments
Guidance to review
🚢

 [S] Add qa/staging/review app environment


Jamf Sync remove the package from source location

While testing the Jamf Sync, I realised that once I choose a package and click on synchronize. The package is removed from source location. I thought that synchronisation will copy the selected package to destination location.
i tested this behaviour multiple times and everytime it occurs.
The Worst Part is, that sometime the synchronisation fails the source packages are also deleted

Hmm...that's not good. What type of distribution point was the source and which type was the destination?

Yes I used the latest version available: 1.3.2
Source: a local folder on macOS
Destination: File share distribution points --> SMB Share which we used Jamf admin to connect to and upload packages

I'm not seeing that behavior. It does redraw the source list, and if it's sorting by the Sync status, which seems to be the default, it will move the item because the status will change to a circle with an '=' instead of a circle with a '+'. Is that perhaps what's happening? Otherwise, if you click the refresh button (to the left of "Show Log"), does the file come back? If you look at that directory in Finder, does the file disappear there as well? If there still seems to be an issue with this, could you send me a screen shot of a finder view before and after showing the missing file and click "Show Log", select any relevant items and click the copy button and send that as well? A screen shot of the main window with the source and destination selected would also be helpful.

I'm going to mark this as not planned since I wasn't able to recreate it and I haven't received more information. If I get more information, we can reopen it.


Chewy compatible with ES 7 or above

This is not an issue and more of the question as i am unable to find compatibility matrix for chewy to elasticsearch.
Is chewy compatible with ES 7 and above?

Current latest version doesn't support ES7, so we have to use this patch by @reneklacan.
Found from:

https://github.com/toptal/chewy/issues/708#issuecomment-673747704
https://github.com/toptal/chewy/pull/712

We've just released Chewy 6 that supports ES 6 (https://github.com/toptal/chewy/releases/tag/v6.0.0) and we're switching our focus on adding ES 7 support. Stay tuned for Chewy 7. :-)

@bbatsov glad to hear that there's some progress being done on this, thanks a lot!

Please take a look at Chewy 7.0.0 release. Stay tuned for the 7.1 release, with dropped support for ES6.8 and removed deprecation warnings.
Also, take a look at Elasticsearch compatibility matrix.


Add option to adjust gap between tree and first barplot layer

Closes #453
Adds a new element to the side panel that allows users to manually set the distance between the tree and the first barplot layer. Currently works by specifying a percentage increase to _maxDisplacement. ~Default value is 10 (1 + 10% = 1.1) to keep with current default behavior.~ Default value changed to 5 as we decided to decrease the default gap.
OLD: var maxD = 1.1 * this._maxDisplacement;
NEW: var maxD = (1 + this._displacementFrac) * this._maxDisplacement;
~A new function Empress.prototype.changeBorderGap just divides the input value by 100. This can likely be rewritten to not use a whole function - depends on what people think looks more clean.~
Current Status

[x] Pick a better display name than Separation length
[x] Update relevant documentation in empress.js
[x] Disallow negative values

@gibsramen, if this looks good to you let me know and I'll be happy to merge
this to the master branch.
On (Jan-22-21|15:59), Marcus Fedarko wrote:

@fedarko approved this pull request.
Thanks so much @gibsramen!!!
Per discussion with Gibs earlier today I modified this slightly in the following ways:

Use the same "units" for the initial gap as for barplot lengths, making things a bit more consistent for the user. The default gap value is now 10, which matches the default barplot border length.

Store the current gap value only in BarplotPanelHandler, and have Empress retrieve this value when needed rather than keeping track of it in Empress._displacementFrac. The rationale for this is that it reduces the amount of data Empress needs to keep track of, and matches some of the other ways in which the barplot functionality works (e.g. how the border color / length are also retrieved from the BarplotPanelHandler).

Provided that these changes look good, I think we can merge this in. Sorry for taking so long to get to this.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://urldefense.com/v3/__https://github.com/biocore/empress/pull/464*pullrequestreview-574701478__;Iw!!Mih3wA!Rh9uN3yU9xohsHyhHtjhh9mw8RfT2eRKgJVf7Fp_dw6bg7F9V5gj5-rMWTH0ZX4$

@gibsramen, if this looks good to you let me know and I'll be happy to merge
this to the master branch.
On (Jan-22-21|15:59), Marcus Fedarko wrote:

@fedarko approved this pull request.
Thanks so much @gibsramen!!!
Per discussion with Gibs earlier today I modified this slightly in the following ways:

Use the same "units" for the initial gap as for barplot lengths, making things a bit more consistent for the user. The default gap value is now 10, which matches the default barplot border length.

Store the current gap value only in BarplotPanelHandler, and have Empress retrieve this value when needed rather than keeping track of it in Empress._displacementFrac. The rationale for this is that it reduces the amount of data Empress needs to keep track of, and matches some of the other ways in which the barplot functionality works (e.g. how the border color / length are also retrieved from the BarplotPanelHandler).

Provided that these changes look good, I think we can merge this in. Sorry for taking so long to get to this.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://urldefense.com/v3/__https://github.com/biocore/empress/pull/464*pullrequestreview-574701478__;Iw!!Mih3wA!Rh9uN3yU9xohsHyhHtjhh9mw8RfT2eRKgJVf7Fp_dw6bg7F9V5gj5-rMWTH0ZX4$

LGTM :)

LGTM :)

Thanks so much both!

Thanks so much both!


Discussion: "Even Friendlier SQL with Risingwave"

A lot of user-friendly and innovative ideas from Even Friendlier SQL with DuckDB
But maybe not all of them are suitable for RW, let's have a discussion.

[ ] Reusable column aliases
[ ] COLUMNS() with except and replace
[ ] COLUMNS() with regular expressions
[ ] Automatic JSON to nested types conversion
[ ] FROM first in SELECT statements
[ ] Function chaining
[ ] Union by name
[ ] Insert by name
[ ] Dynamic PIVOT and UNPIVOT
[ ] List lambda functions
[ ] List comprehensions
[ ] Exploding struct.*
[ ] Automatic struct creation
[ ] Union data type

[ ] Reusable column aliases

[ ] COLUMNS() with except and replace

[ ] COLUMNS() with regular expressions

[ ] Automatic JSON to nested types conversion

[ ] FROM first in SELECT statements

[ ] Function chaining

[ ] Union by name

[ ] Insert by name

[ ] Dynamic PIVOT and UNPIVOT

[ ] List lambda functions

[ ] List comprehensions

[ ] Exploding struct.*

[ ] Automatic struct creation

[ ] Union data type


React list has no way to know that render row logic has been changed

If the props or state has not been changed component is not updated.
Should there be some way to notify component that rendered row has been changed?
JsFiddle

This is a side effect of using shallow equality checking to improve performance. Check out https://github.com/orgsync/react-list/issues/36 for options to force reload.


wireless: gs2200m: Fix error handling in sendto_request()

Summary

This commit returns -errno to the caller

Impact

gs2200m only

Testing

Tested with spresense:wifi_smp
NOTE: need to update the gs2200m driver in NuttX

See https://github.com/apache/incubator-nuttx/pull/3990 as well


Error: Proc(Log::Entry, IO, Nil) is not a module, it's a function

Got this error when trying to compile the new version
In lib/tourmaline/src/tourmaline/logger.cr:18:14

 18 | extend Log::Formatter
             ^-------------
Error: Proc(Log::Entry, IO, Nil) is not a module, it's a function

Are you using Crystal 0.35.0? Because in 0.34.0 Log::Formatter was a proc, but it's a module now.

Effectively I'm using crystal 0.34.0.
I'll try with 0.35.0 but for now there are dependencies error in my project.
Thanks for the explanation.

@fenicks Yeah that should fix the issue


Minor fixes to work with new Zenodo backend

The Zenodo backend migration has resulted in changed behaviors of the API, even without the full API migration noted in #184. These changes are accommodated here:

get_new_version endpoint no longer returns the version consistently, so we get it from the earlier GET response metadata.
The delete_deposition method has a new behavior that errors our existing tests (still needs fixing!)
changes a few tests to reflect changed error messages and behaviors

Note that something funny happened with the most recent EIA-861 archive, resulting in "Draft" URLs showing up in the datapackage.json which is resulting in 403: Forbidden errors.
        {
            "profile": "data-resource",
            "name": "eia861-1990.zip",
            "path": "https://zenodo.org/api/records/10093091/draft/files/eia861-1990.zip/content",
            "remote_url": "https://zenodo.org/api/records/10093091/draft/files/eia861-1990.zip/content",
            "title": "eia861-1990.zip",
            "parts": {
                "year": 1990
            },
            "encoding": "utf-8",
            "mediatype": "application/zip",
            "format": ".zip",
            "bytes": 1195700,
            "hash": "47660a1b8df008ae0e94998fb71c1cde"
        },

How was that archive created? We should probably just use the "canonical" path logic from the New API Branch when creating datapackage.json, even when we're using the old API.

The 861 archive was created from this branch to unblock work on new data integration - clearly more has changed on the backend than I'd caught, though! I can update the link referenced to in this PR before it gets merged and create a new production archive.

It seems like maybe the draft path shouldn't still be a problem (though using the simple canonical path still seems like a good idea) given that the path and remote_url are using exactly the same input in the datapackage construction now. And if it still an issue that's kinda wild!
        return cls(
            name=file.filename,
            path=file.links.download,
            remote_url=file.links.download,
            title=filename.name,
            mediatype=mt,
            parts=parts,
            bytes=file.filesize,
            hash=file.checksum,
            format=filename.suffix,
        )

I attempted creating a new eia861 archive with --dry-run to see if the draft path thing was still a problem, and discovered that we didn't fix the CLI to produce a summary_file of type Path so fixed that.
In the process I noticed that after running it with --dry-run the next attempt to run the archiver script failed with some errors and timeouts, apparently related to needing to delete some leftover something on the server, from the previous --dry-run which was surprising.
Then running the archiver a 3rd time, it didn't have that issue any more.  So it seems like the 2nd run cleaned up the issue whatever it was, but couldn't actually continue to create a draft archive.  So it seems like maybe --dry-run is leaving some junk that needs to be dealt with somehow.

Looks like the draft issue also appears in the most recent EIA860M:
    "resources": [
        {
            "profile": "data-resource",
            "name": "eia860m-2015-07.xlsx",
            "path": "https://zenodo.org/api/records/10086240/draft/files/eia860m-2015-07.xlsx/content",
            "remote_url": "https://zenodo.org/api/records/10086240/draft/files/eia860m-2015-07.xlsx/content",
            "title": "eia860m-2015-07.xlsx",
            "parts": {
                "year_month": "2015-07"
            },
            "encoding": "utf-8",
            "mediatype": "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet",
            "format": ".xlsx",
            "bytes": 2730620,
            "hash": "f37c121bd05397e41f4f19c0149a7cd4"
        },

The web interface also seems to be struggling with deletion of draft records like this one

I just pushed up a change that:

gets tests to pass! some of the weird behavior we were working around has now gone away!
uses the canonical URL, albeit in a sort of brittle way

The dry-run stuff that's going in is similar to some stuff I was seeing when running tests last week / 2 weeks ago:

first dry run makes a draft, populates it
second dry run deletes the existing draft, but for some reason Zenodo times out instead of responding with a 200. Then, on retry, we get 404s since the draft is now gone. When we finish retrying, second dry run errors out
third dry run sees no draft, doesn't have to delete it

This "delete succeeds in reality, but times out" thing was happening on sandbox and eventually stopped happening. But until then, I suppose we could include something in the delete logic of "If we get a 404 on deletion, in particular, we treat that as "deletion was successful!"


Guidelines, Tips and list of already posted things (Incomplete)

I hope this will help both the users and the developers/maintainers.
Most of the things I've written are my memories of Baumi talking in videos and steams, so please correct me if I'm wrong on any subject.

Merging this in because there's some great stuff already in there. If you add more you'll need to rebase and make a second PR.

All right ;)

There is one issue I didn't thought of; I referenced a bunch of issues throughout the docs, but the links aren't working; presumably because the targets don't exist in my fork. I'm not sure if github will automatically correct them, or someone will have to manually go through the files and open/save them to repair the links.


Dropdown: Fix ComboBox positioning with shouldDropDirectionUpdate

Dropdown: Fix ComboBox positioning with shouldDropDirectionUpdate

(ComboBox, by default, should always drop down, if defined)
This update fixes the up/down menu position of ComboBox based dropdowns
that happens when the list size changes (during filtering).
The solution was to introduce a new prop called shouldDropDirectionUpdate.
By default, in Dropdown, it resolves to true. However, in ComboBox,
we'll resolve it to false.
The user can adjust this, if required.
Dropdown auto positioning works as before:

Screencast
I recorded a screencast for additional details:
https://www.useloom.com/share/be89d280e6984512a707571e35e15cbc

Future enhancement idea:
Ideally, the menu position should auto calculate for ComboBox, but only on the initial render. Subsequent updates shouldn't change it's positioning. There are more edge cases with this, but I think this is the end-goal.
For now, this "hard coded" solution is simpler and more stable.

Demo URL
https://deploy-preview-515--hsds-react.netlify.com/?selectedKind=ComboBox&selectedStory=Default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs

@tinkertrain Thanks!!

Pull Request Test Coverage Report for Build 1800

13 of 13 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1797:
0.0%

Covered Lines:
6969

Relevant Lines:
6969

💛  - Coveralls


v0.7.0

The goal of v0.7.0 is to address the below issues and clean up the code to get it into a state where it's easier to contribute and develop. I'll open up the project to contributions after this. There's still many features and improvements to be done and would be great to get some help.

[x] magic method completion #13
[ ] load symbols of active extensions only #14
[ ] formatting #3
[x] symbol caching #5
[x] define() #18
[x] use declaration upon completion #20

Would like to add: Null coalescing operator

When do you plan to deploy this new version?

I'll publish on Friday 23 June. It's mostly done, I'm just debugging


⚠ ClamAV has degraded performance

In 2261886, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 142 ms

Resolved: ClamAV performance has improved in 5ceec74 after 5 minutes.


[Rebalancing] [Part4] Compute depositories target weights IX

PR Combo:

uxd-client: https://github.com/UXDProtocol/uxd-client/pull/40
uxd-program: https://github.com/UXDProtocol/uxd-program/pull/241

This PR introduces:

a new IX: compute_depositories_targets
2 new fields for credix/mercurial depositories:

redeemable_amount_under_management_weight // manual static arbitrary weight desired for the depository
redeemable_amount_under_management_target // absolute amount depending on the weight, cap and total supply

The goal of this new compute_depositories_targets IX the following:

uses all depositories redeemable_amount_under_management_weight
uses the current total supply and all depositories caps
then compute the new absolute redeemable_amount_under_management_target for all depositories

The idea is that the amount in redeemable_amount_under_management_target of each depositories will then be used as an informatory value used during computing rebalancing amounts later (this amount can fluctuate over time, rebalancing can be lagging a bit in time without any problem)

Deprecating this PR, we will take a different approach.
New PR is here:
https://github.com/UXDProtocol/uxd-client/pull/41


Warn when using building release app on master channel

See https://github.com/flutter/flutter/issues/24984

@GaryQian what's the status of this PR? I'll add the reviewers from the previous attempt at this.

I haven't had a chance to make the proper adjustments to make sure this is not happening on run also. I'll get back to this later as things with higher priority are currently on my plate.

@GaryQian if you're not working on this could we close it for now?

@GaryQian I'm going to close this PR for now, feel free to get back to it later


Fixed Bug with computed properties (to v2.2.3)

From the original commit:

There was an issue when a computed property was changed... The selected property on options fired multiple times and threw a series of deprecation warnings. See #158

Thanks to @bmass02

Back porting this to v2.2.3

Merging this since the current ember-try config will fail (v2.x will not support Glimmer 2)


Give KmsService lifecycle methods (initialize and close) (Take 2)

Type of change
Select the type of your PR

Enhancement / new feature

Description
why: sometimes KMS's need to make use of long lived resources that need to be closed once the KMS service is no longer required.
This is an alternative to #1478 and uses a simpler KmsService API.
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

Bringing over @SamBarker's comment from: #1478
Sorry for the slow reply @k-wall. The simpler API looks good to me.
To the contract points
must be called exactly once
I think its worth clarify thing the life cycle as a whole (in the resultant PR) and being quite explicit about the relationship between initialize, build and close.
Should the runtime ensure that individual Kms's are closed prior to closing KmsService or is it up to the KmsService to maintain a list of Kms services which the then closes?

Bringing over @SamBarker's comment from: #1478
Sorry for the slow reply @k-wall. The simpler API looks good to me.
To the contract points
must be called exactly once I think its worth clarify thing the life cycle as a whole (in the resultant PR) and being quite explicit about the relationship between initialize, build and close.

Please take a look at the KmsService interface in this PR.

Should the runtime ensure that individual Kms's are closed prior to closing KmsService or is it up to the KmsService to maintain a list of Kms services which the then closes?

I hadn't planned to give the Kms's themselves lifecycle.    We've got the pattern elsewhere that the filter factories have the lifecycle, so it seemed less surprise to follow the same pattern with the KmsService.


Run on Windows

Hello,i tried to run it in Windows, but i get
C:\Users\Marcel>python \holophrasm-master\run_script_ordered.py
timeout (min)? 1
num passes? 1000
search beam width? 3
hyp bonus? (0 in the paper, but 10 may give better results)0
Traceback (most recent call last):
File "C:\Users\Marcel\Desktop\holophrasm-master\run_script_ordered.py", line 57, in
with open('lm', 'rb') as handle:
IOError: [Errno 2] No such file or directory: 'lm'
I guess this file is just missing in the repo?

The release version (https://github.com/dwhalen/holophrasm/releases) should have the missing files.  Let me know if that doesn't work.

It works now somewhat, but it spits out
proven 28/389 this: 5,   7.2%
proposition onnbtwn (4030): 389/2720 (with 3 steps)
Exception in thread 0:
Traceback (most recent call last):
File "D:\programme\anacondaPY2.7\lib\threading.py", line 801, in _bootstrap_inner
self.run()
File "C:\Users\Marcel\Desktop\holophrasm\holophrasm\proof_search.py", line 180, in run
with withPool(1) as self.p:
File "C:\Users\Marcel\Desktop\holophrasm\holophrasm\proof_search.py", line 117, in init
self.p = multiprocessing.Pool(procs, init_func)
File "D:\programme\anacondaPY2.7\lib\multiprocessing_init.py", line 232, in Pool
return Pool(processes, initializer, initargs, maxtasksperchild)
File "D:\programme\anacondaPY2.7\lib\multiprocessing\pool.py", line 159, in init
self._repopulate_pool()
File "D:\programme\anacondaPY2.7\lib\multiprocessing\pool.py", line 223, in _repopulate_pool
w.start()
File "D:\programme\anacondaPY2.7\lib\multiprocessing\process.py", line 130, in start
self._popen = Popen(self)
File "D:\programme\anacondaPY2.7\lib\multiprocessing\forking.py", line 258, in init
cmd = get_command_line() + [rhandle]
File "D:\programme\anacondaPY2.7\lib\multiprocessing\forking.py", line 358, in get_command_line
is not going to be frozen to produce a Windows executable.''')
RuntimeError:
Attempt to start a new process before the current process
has finished its bootstrapping phase.
        This probably means that you are on Windows and you have
        forgotten to use the proper idiom in the main module:

            if __name__ == '__main__':
                freeze_support()
                ...

        The "freeze_support()" line can be omitted if the program
        is not going to be frozen to produce a Windows executable.

proven 28/390 this: 5,   7.2%
all the time.
Iam not used to Python, i dont think its a big problem, i hope you can fix it :)


Add UDP performance tests

Motivation:
We don't have any UDP performance tests.
Modifications:

Add UDP perf tests

Result:
We can measure perf improvements for UDP.

5.8 and nightly failures are https://github.com/apple/swift/issues/63262

@swift-server-bot test this please


docker restart a container will change the port mapping

Hi，
after docker restart containerid，it will allocate a new port to the container，Is there a way hold the port for a container？or this is feature for docker?
reproduce steps
1，docker run -d  -p 8080 imageid
2，docker restart containerid
3，compare the container the mapping port，you will found that the port is changed。
ps: on docker 1.2.0 after restart the container twice，the port will lost. but this issue can not be reproduced on docker docker-1.3.0-dev.
thanks

I have also been hit by this bug, and it's a deployment blocker for me.
Although in production one will want to use fixed port mappings, there are scenarios (development, testing, staging) where you want containers to survive a daemon/host reboot and keep their port mapping, if not just to not destroy the work-flow of all involved people that are still using the containers.

I have implemented stateful hostconfig save/restore in my docker-fw utility, feel free to give it a shot.

closing as dup of https://github.com/docker/docker/issues/7158 which is why it gets another port

also https://github.com/docker/docker/issues/9047 for reference


Add another metric_to_check

Motivation
Users might configure the check to only collect one or the other

Hmm validation is failing since kafka.net.bytes_out is not in metadata.csv?


Build folder through Bower

Hi.
When I try to install ngmap through bower, I don't get the build folder. Is there a reason for that, or is it a problem on my side?

I don't have any issue. and bower should not ignore build directory.

Well, now it's working. A couple hours ago, both on my laptop and my server, it wouldn't download that specific folder. Weird, I close the issue.


AWSSDKConfig.cmake fails to find static libraries on Windows

Hello,
On Windows platforms, the AWSSDKConfig.cmake file installed with the SDK will not locate the binaries if the SDK was build with -DBUILD_SHARED_LIBS=OFF. I believe this is due to the following check in AWSSDKConfig.cmake:
# on Windows or Win64 dlls are treated as runtime target and installed in bindir
if (WIN32)
    set(AWSSDK_INSTALL_LIBDIR "${AWSSDK_INSTALL_BINDIR}")
endif()

This unconditionally sets the lib search directory to bin by default, which is not correct in the case where the shared libraries were not built.
What platform/OS are you using?
Windows 10
What compiler are you using? what version?
MSVC 19.12.25835.0 (VS2017 community edition)
What are your CMake arguments?
-DBUILD_SHARED_LIBS=OFF -DBUILD_ONLY=s3;core
Additional info
Here's the cmake output when using find_package(AWSSDK CONFIG):
  -- TARGET_ARCH not specified; inferring host OS to be platform compilation target
  -- Building AWS libraries as static objects
  -- Generating windows build config
  -- Building project version: 1.2.0
  CMake Error at build/externals/install/lib/cmake/AWSSDK/AWSSDKConfig.cmake:125 (message):
    AWS SDK for C++ headers found, but we were unable to locate the binaries.
    Have you deleted or moved it?

                Please make sure header files and binaries are located in INSTALL_ROOT_DIR/INCLUDE_DIR/ and INST_DIR/LIB_DIR/[PLATFORM_PREFIX]/[Debug|Config|OtherConfigs]

A workaround for me is to build the SDK with -DCMAKE_INSTALL_BINDIR=lib.

Thank you for reporting this. Will get it fixed ASAP.

@tdenniston This bug should have been fixed, please take look at
https://github.com/aws/aws-sdk-cpp/blob/13720f04d54e315ff1162a953b4f290493ab2c27/cmake/AWSSDKConfig.cmake#L61
Reopen if you still have this problem.


Docs fix nginx setup

This is a single character change to the docs.
The existing config gives query string twice in Location. This is because query strings are passed by default and are also included in the $request_uri variable.

Aha, we've seen that failure mode once or twice before but didn't know why. Thank you for the catch, and for the fix!


Are the OK-Robot videos staged with telerobotics?

Someone is clearly driving this robot in the top right behind the curtain of Oz. So much for autonomous...
Thanks Elon
https://youtu.be/G7SBA5roNhI?t=62

That is a tripod in the corner, the person in the closet is recording the automated robot run.
The code for ok-robot is also public here: https://github.com/ok-robot/ok-robot


Backporting prost/tonic upgrade to 6.x line

Which issue does this PR close?
N/A (related to #897 )
Rationale for this change
Various downstream projects such as IOx would like to upgrade to the latest version of prost / tonic, etc (0.9 and 0.6 respectively at the time of writing). However, we have avoided such potentially incompatible version upgrades in the past.
However, in consultation with @shepmaster  and others, there are cases when upgrading dependencies even to new "semver incompatible" versions may not actually break sematic versioning
What changes are included in this PR?
cherry-pick 1d3d5e3 which originally appeared in https://github.com/apache/arrow-rs/pull/864 from @PsiACE  to active_relaese (aka propose to include in the arrow 6.2.0 release). I will then use this branch to see what effects it has on datafusion and others.
Are there any user-facing changes?
Versions of prost and tonic are upated

PR for upgrading datafusion to point at this branch: https://github.com/apache/arrow-datafusion/pull/1283

Unfortunately it fails to build with something like
   Compiling datafusion v5.1.0 (/Users/alamb/Software/arrow-datafusion/datafusion)
error[E0308]: mismatched types
  --> ballista/rust/core/src/client.rs:75:19
   |
75 |         Ok(Self { flight_client })
   |                   ^^^^^^^^^^^^^ expected struct `Channel`, found struct `tonic::transport::channel::Channel`
   |
   = note: expected struct `FlightServiceClient<Channel>`
              found struct `FlightServiceClient<tonic::transport::channel::Channel>`
   = note: perhaps two different versions of crate `tonic` are being used?

error[E0599]: the method `do_get` exists for struct `FlightServiceClient<Channel>`, but its trait bounds were not satisfied
   --> ballista/rust/core/src/client.rs:112:14
    |
112 |             .do_get(request)
    |              ^^^^^^ method cannot be called on `FlightServiceClient<Channel>` due to unsatisfied trait bounds
    |
   ::: /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/tonic-0.5.2/src/transport/channel/mod.rs:68:1
    |
68  | pub struct Channel {
    | ------------------
    | |
    | doesn't satisfy `<_ as Service<tonic::codegen::http::Request<http_body::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, tonic::status::Status>>>>::Response = tonic::codegen::http::Response<_>`
    | doesn't satisfy `_: Service<tonic::codegen::http::Request<http_body::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, tonic::status::Status>>>`
    | doesn't satisfy `_: tonic::client::service::GrpcService<http_body::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, tonic::status::Status>>`
    |
    = note: the following trait bounds were not satisfied:
            `Channel: tonic::client::service::GrpcService<http_body::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, tonic::status::Status>>`
            `<Channel as Service<tonic::codegen::http::Request<http_body::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, tonic::status::Status>>>>::Response = tonic::codegen::http::Response<_>`
            `Channel: Service<tonic::codegen::http::Request<http_body::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, tonic::status::Status>>>`

The conclusion is that updating prost/tonic is definitely not backwards compatible. Closing this one


cmd/go: -mod=readonly causes go install p@version to fail with "missing go.sum entry"

From https://groups.google.com/g/golang-nuts/c/XeQhJghJGPs
I have GOFLAGS=-mod=readonly in my environment to avoid unnoticed changes to go.mod and go.sum. However, I'm getting a weird error from the (new in 1.16) go install p@version form to install a Go program:
$ cd $(mktemp -d)
$ GOFLAGS=-mod=readonly go install gioui.org/cmd/gogio@40c082e94961adaf55886b45710a54d0247ff1bf
go install gioui.org/cmd/gogio@40c082e94961adaf55886b45710a54d0247ff1bf: <EMAIL_ADDRESS>missing go.sum entry

Clearing GOFLAGS does work:
$ GOFLAGS= go install gioui.org/cmd/gogio@40c082e94961adaf55886b45710a54d0247ff1bf
go: downloading gioui.org v0.0.0-20201218091821-40c082e94961
go: downloading gioui.org/cmd v0.0.0-20201218091821-40c082e94961

I can't explain the difference, nor the error. In case it makes a difference, I have a checkout of gioui.org/cmd/gogio at the above revision where go mod tidy is a no-op.
What version of Go are you using (go version)?

$ go version
go version devel +2de7866470 Fri Dec 18 18:25:14 2020 +0000 darwin/amd64

Does this issue reproduce with the latest release?
Yes

go mod tidy removes 2 lines from go.sum at that checkout

Reproduced in 1.16beta1. Thanks for reporting!


Do not center Lightbox title

Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[ ] tests are included
[x] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
The Lightbox title was centered in Image/Video gallery due to an inline style applied to SeachResultLIst. This PR makes this style conditionally working.
In standard mode

In gallery mode

Good stuff @PenghaiZhang . Merge when ready. :+1:


editor.hover.enabled is annoying sometimes

Hello,
in relation to https://github.com/microsoft/vscode/issues/52821#issue-335448818 i feel that the hover popup options should be optimized.
Principially, hover popup can be enabled for mouse or with Key CTRL+K, CTRL+I
The first one, "editor.hover.enabled": true shows it after delay every time mouse hovers, the second one, CTRL+K, CTRL+I, opens the popup, but as far as i move the mouse cursor, the popup hides, even if "editor.hover.sticky": true is set.
There are dozens of popup places in code, so, permanently moving with mouse over them can be irritating and to wait a long delay is not best option. Keying CTRL+K, CTRL+I is sometimes ok, but cursor must be placed before.
My intention is to get mouse cursor plus CTRL:

clicking is Go to definition
holding over the word opens hover popup

Actually, CTRL|CMD + mouse cursor is only bound to onclick event, if i am correct.
That addition would feel good to me.

I believe this is a duplicate of https://github.com/microsoft/vscode/issues/43857, let me know if it's not quite the same. Thanks!


Broken compatibility with .NetStandart 2.0

Hello,
I would like to use your package in a .net core 2.2 application (which is supposed to be doable) but you are using a reference which required at least .net core 3.1
The identified issue is with the package Microsoft.Extensions.DependencyInjection.Abstractions version 6+
You can find more information here : https://github.com/dotnet/runtime/issues/63744
For reference, you can find the compatibility matrix here : https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0
Could you let me know if you will provide a version compatible with .net core 2.0+ ?

I think it is doable forcing reference to an older version of Microsoft.Extensions.DependencyInjection.Abstractions. I will check as soon as return to work from vacation.
Thanks

Thanks for your answer, we will test it when it will be available

@Gamdolf could you please try pre-release version 1.3.0 published right now:
https://www.nuget.org/packages/Bonura.Hangfire.PerformContextAccessor/1.3.0-beta
Thanks.
Diego

Hello,
I will check it tomorrow.
Thanks for your fast reaction

De : Diego Bonura @.>
Envoyé : lundi 31 juillet 2023 18:03
À : meriturva/Hangfire.PerformContextAccessor @.>
Cc : Gamdolf @.>; Mention @.>
Objet : Re: [meriturva/Hangfire.PerformContextAccessor] Broken compatibility with .NetStandart 2.0 (Issue #1)
@Gamdolfhttps://github.com/Gamdolf could you please try pre-release version 1.3.0 published right now:
https://www.nuget.org/packages/Bonura.Hangfire.PerformContextAccessor/1.3.0-beta
Thanks.
Diego
—
Reply to this email directly, view it on GitHubhttps://github.com/meriturva/Hangfire.PerformContextAccessor/issues/1#issuecomment-1658681235, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPCRW3RL7CE645OC2RVEJTXS7JOVANCNFSM6AAAAAA2RK527Y.
You are receiving this because you were mentioned.Message ID: @.***>

Hello,
It look good in the project and unit test.
I will let you know if we are experiencing any issue in live context but it should be good.
Thanks for the update

I will deploy a stable release in a few days!
Thanks!

The stable release is published right now!


feat: a flag to skip CI

Instead of making assumptions such as "let's run / let's not run CI for the first / the last / whatever file", let's just make it configurable. I'm only using this flag in the simple releaser but any other releaser can be upgraded if needed. The default behavior is skipCi: true so nothing is changed for other releasers.

@bcoe OK, so now:

if skipCi is unset for all updates (default behavior), we disable CI (set skipCI = true) for all files except the last one - this case covers all the existing releasers used by Yoshi;
if skipCi is set at least for one update (to true or false), we think that this releaser cares about it, and skip CI for all updates where it is unset.


Feature/sg 901 extreme batch visualization for object detection

What would happen if I add two callbacks to visualize best and worst batch based on observed metric? Would everything work fine or they would overwrite each other? In other words - does tag value for logged images respect the max argument?

What would happen if I add two callbacks to visualize best and worst batch based on observed metric? Would everything work fine or they would overwrite each other? In other words - does tag value for logged images respect the max argument?

It will.


Incorrect behavior of rows @input with async pipe

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
When async pipe applied to rows input, table renders only last emitted data
Expected behavior
Table should render all data emitted by observable
Reproduction of the problem
          this.displayedRows = Observable.create((subscriber) => {
            const dataRange = _.range(0, this.page.size, 10); // here 10 is a step
            dataRange.forEach((value, index, array) => {
              if (index !== array.length - 1) {
                subscriber.next(response.items.slice(value, array[index + 1]));
              } else {
                subscriber.next(response.items.slice(value, this.page.size));
              }
            });
            subscriber.complete();
          });

Template:
    <ngx-datatable
      class="material striped expandable"
      [columnMode]="'force'"
      [rows]="displayedRows | async"
      [headerHeight]="50"
      [footerHeight]="50"
      [rowHeight]="75"
      [columns]="columns"
      [sortType]="'multi'"
      [trackByProp]="'id'"
      [loadingIndicator]="isLoading"
      (sort)="onSort($event)"
      [externalPaging]="true"
      [externalSorting]="true"
      [count]="page.totalElements"
      [offset]="page.number"
      [limit]="page.size"
      (page)="setPage($event)">

Default page size is 50, when I receive 50 records from server, only latest 10 visible in table

Table version:
14.0.0

Angular version:
7.1.3

Browser: Chrome latest

Language: TypeScript

The rows input expects to receive the entire set of rows to be shown in the table. If your observable is only emitting 10 at a time, it will only ever show 10.
If you want to show all rows emitted up until completion, you could use the reduce operator:
displayedRows.pipe(reduce((allRows, rows) => [...allRows, ...rows])

@eppsilon thanks, so it was my incorrect usage of this feature, closing


Added option to customize rendererSettings

Added the option to customize the rendererSettings.
The filterSize setting is required in order to display drop shadows correctly.
A full list of settings can be found here:
https://github.com/airbnb/lottie-web/wiki/Renderer-Settings#filtersize-svg-renderer

Hi @jawish would it be possible to get this reviewed?
Thanks


Better upload button

Create a way in the GUI to upload notebook for any exercise.

Solved in a1c1875


[assimp] Fix configure warning when using minizip from assimp library

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Sorry what configure warning is this fixing?

The unprefixed unofficial cmake config  warns that it is deprecated and that you should use the prefixed one instead.

The unprefixed unofficial cmake config  warns that it is deprecated and that you should use the prefixed one instead.

Yes, this is correct!

Thanks!


ServerCompatNotice: Add, to nag users connected to servers <2.0.0.

As the jsdoc says, at some point we'll settle on a non-hard-coded threshold; see
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/compatibility.20documentation/near/1174966.

The banner can go pretty much anywhere that makes sense. Here, I've got it on HomeScreen only, so it doesn't show up when you're in the message list or even on another tab like the settings screen. I considered putting it in MainTabsScreen just above or below the OfflineNotice; that'd be fine, but then I figured the current way is obtrusive enough.
The "x" button makes the banner disappear, but that state is deliberately stored in state.session, which isn't persisted, so it'll nag the user on the next startup.
The "Learn more" link goes to https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html.
Note that the correct handling of safe areas (noticeable in landscape mode on iOS) will look incongruous until #3066 is fixed; #4683 is my next step for that.
I may add an ease-in-ease-out animation when our usePrevious util from #4683 is available.
NOTE: The has-dismissed-the-banner state isn't stored per-realm, so there's currently a bug where dismissing the banner makes it go away for all <2.0.0 realms the device knows about (until app restart, anyway). I figured this was minor enough to be acceptable for the time being, unless we can think of a nice and easy way to store the state both per-realm and per-session, while being sure to clean up after ourselves when the user wants to forget the realm.
(The screenshots don't show an actual <2.0.0 version; I've tweaked the should-it-show conditional. It shows the git describe output we get from /server_settings, unmodified, and this is CZO.)

iOS

Android

Hmm, do we need to display the version? I think it makes the message harder to understand, at least for everyone who isn't the admin for the server.

By the way, do we display a different message if the user is the administrator?

The "learn more" link should probably go lower on the page: https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html#compatibility-and-upgrading

The message will usually be like "1.9.3" unless they're running a forked version from Git (like chat.zulip.org is).

The "learn more" link should probably go lower on the page: https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html#compatibility-and-upgrading

Cool, sounds good. I'm seeing this, in that section:

The Zulip mobile and desktop apps maintain backwards-compatibility code to support any Zulip server since 2.1.0.

Does that mean I can make the banner show for <2.1.0, not just <2.0.0?

By the way, do we display a different message if the user is the administrator?

I've updated the PR with this text for admins; what do you think?

Hmm, do we need to display the version? I think it makes the message harder to understand, at least for everyone who isn't the admin for the server.

Ok, either way seems OK for showing the version number to non-admins then.

For admins, can we make the call to action more explicit? E.g. for the second sentence: "Please upgrade your server as soon as possible by following the simple process described here." -- or something along those lines?

For admins, can we make the call to action more explicit?

Yeah, that makes sense. After looking a bit closer, I think we may like do that in a different direction; the "Learn more" button in my previous revision really wants to be a separate button, not so much an inline link on a word in a sentence.
I took a look at the Material Design doc for banners, and made some adjustments in this revision based on that. It says we shouldn't use an "x" to close; it says "All actions should be shown as text buttons." So I've made "DISMISS" button instead of the "x" icon. It also says "Don’t include links in a banner message. All available actions should be represented as buttons."
Here are some screenshots for what an admin sees. "Upgrade now" seemed like a more obvious wording for the action button than "fix now", but I think "upgrade now" gets used a lot when apps ask people to pay for stuff, and I didn't want an admin to be misled by that (maybe they have the power to make decisions but they're not really in the loop about how Zulip works).

And for non-admins, and one screenshot on Android:

In an earlier revision, I considered adding a Zulip logo to signify that it was a message from us, e.g.,

Images are allowed in the Material Design spec, but I think the text is running long, and that would give it less space. In the "Specs" section, there's a diagram that says "One to two lines is preferable on mobile and tablet", and I'm seeing three on the devices I'm testing on, which are pretty standard.

Cool, looks good to me! I like that we now know a lot more about adding
banners -- it may come in handy.
On Wed, May 19, 2021, 4:52 PM Chris Bobbe @.***> wrote:

For admins, can we make the call to action more explicit?
Yeah, that makes sense. After looking a bit closer, I think we may like do
that in a different direction; the "Learn more" button in my previous
revision really wants to be a separate button, not so much an inline link
on a word in a sentence.
I took a look at the Material Design doc for banners
https://material.io/components/banners, and made some adjustments in
this revision based on that. It says we shouldn't use an "x" to close; it
says "All actions should be shown as text buttons." So I've made "DISMISS"
button instead of the "x" icon. It also says "Don’t include links in a
banner message. All available actions should be represented as buttons."
Here are some screenshots for what an admin sees. "Upgrade now" seemed
like a more obvious wording for the action button than "fix now", but I
think "upgrade now" gets used a lot when apps ask people to pay for stuff,
and I didn't want an admin to be misled by that (maybe they have the power
to make decisions but they're not really in the loop about how Zulip works).
https://user-images.githubusercontent.com/22248748/118897193-c48d3500-b8d7-11eb-8642-78dc800cd4f1.png
https://user-images.githubusercontent.com/22248748/118897320-fe5e3b80-b8d7-11eb-812f-961d4b45d30c.png
https://user-images.githubusercontent.com/22248748/118897160-b7704600-b8d7-11eb-8989-80d88bf27ecd.png
And for non-admins, and one screenshot on Android:
https://user-images.githubusercontent.com/22248748/118897990-8c86f180-b8d9-11eb-8e7a-15134627b223.png
https://user-images.githubusercontent.com/22248748/118898198-0028fe80-b8da-11eb-92bc-af5a486aca48.png
In an earlier revision, I considered adding a Zulip logo to signify that
it was a message from us, e.g.,
https://user-images.githubusercontent.com/22248748/118898349-55fda680-b8da-11eb-9774-4fcb9851d086.png
Images are allowed in the Material Design spec, but I think the text is
running long, and that would give it less space. In the "Specs"
https://material.io/components/banners#specs section, there's a diagram
that says "One to two lines is preferable on mobile and tablet", and I'm
seeing three on the devices I'm testing on, which are pretty standard.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-mobile/pull/4750#issuecomment-844574087,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAP6IUUWEBEG7SLALI6VGC3TORFMLANCNFSM445GNIFQ
.

On the version threshold, commenting here in the top-level thread for a bit broader visibility: rather than go straight to 2.1.0, I'd prefer to get there gradually by first rolling this banner out to a smaller number of users on older servers. That way we get a chance to hear any feedback from people who see it, and adjust as needed before rolling it out to a wider set of users, because this is inherently a sort of message that may make people unhappy.
A threshold of 2.0 would apply to 2-4% or so of our users as of a couple of months ago, which I think is a good place to start. In fact if we were more of a giant company with tons of users, I'd start another version or two older than that; but as is, I think 2.0 is about right for getting meaningful data from the feedback we hear, or don't hear, from users as it rolls out.

Thanks for the reviews! Revision pushed.

Thanks for the review!

FYI, the first commit here introduced a regression in dev, I've pushed a fix in #4801.

Amusingly, I was the one who suggested the change that caused that, oops :)


Fixes class cast exception , and Solves #45

A child of a NoopSpan is a NoopSpan (without explicit forced sampling).
If a NoopSpan or Noop SpanContext is declared as a parent to the span during the SpanBuilder usage, then return the NoopSpanBuilder. This has been re-implemented so that a) Noop objects are separate entities in the opentracing landscape which can not be mix-and-matched, and b) can re-use them by concept so to enable fluent APIs (ie avoiding nulls being passed around).
Actions
Merge impl and impl-java8 to avoid confusion regarding their roles.
Move Noop classes to their own component "opentracing-noop" where they can't be confused to be part of, or mix-and-matched with, the impl classes.
Move the Noop classes into interfaces, while creating default implementations of this. This (along with using the create() factory method name) indicates that this is a marker interface and the instance only should not be compared against.
Opentracing-impl subclasses (extends) the Noop interfaces to provide an empty (or None) instance to the abstract classes provided. This prevents mix-and-match. Such an approach can be repeated by specific implementations too if they like.
References
Addressing the ClassCastException that is currently thrown when extract(..) is used.
Also solves https://github.com/opentracing/opentracing-java/issues/45
Supersedes https://github.com/opentracing/opentracing-java/pull/56

Overall I like this change, but the use of static methods in Noop interfaces makes it incompatible with Java 1.7. Can we downgrade it to 1.7? For example, by adding something like NoopTracerFactory.create(), or whichever is the most idiomatic way in Java?

Can we downgrade it to 1.7?

Just checking… is this really that important? (This is a brand new component with a fresh audience, and not required when using the -api).

Unfortunately, yeah, it's still important. There are plenty of systems and companies today still using 1.7. There were even requests for 1.6 recently on Zipkin channels.
I wouldn't call this a new component since the classes are simply moving from -impl, which was 1.7 compatible. For example, our tracer has a dependency on noop being 1.7:
https://github.com/uber/jaeger-client-java/blob/master/jaeger-dropwizard/src/main/java/com/uber/jaeger/dropwizard/Configuration.java#L50

For example, our tracer has a dependency on noop being 1.7:
https://github.com/uber/jaeger-client-java/blob/master/jaeger-dropwizard/src/main/java/com/uber/jaeger/dropwizard/Configuration.java#L50

ok.

For example, our tracer has a dependency on noop being 1.7:
https://github.com/uber/jaeger-client-java/blob/master/jaeger-dropwizard/src/main/java/com/uber/jaeger/dropwizard/Configuration.java#L50

ok.

done.

@michaelsembwever thank you for doing this
@yurishkuro thank you for reviewing this :)
Ought we mention something about NoopSpan and NoopSpanContext in the doc strings for -api classes that take either of the above? Seems like that's a must if we plan on replacing null with NoopSpanContext for the various reference-oriented methods...

@bensigelman

Ought we mention something about NoopSpan and NoopSpanContext in the doc strings for -api classes that take either of the above?

Yes. I think that's outside of the scope of this PR.
Today the apidocs do not make any mentione of the -api classes returning null.
Therefore, by java standards, this means that null is never returned under any condition.
Given nothing regarding certain conditions has been documented there is an obvious documentation gap.
I'm a little reluctant though to prematurely tie it to the noop package with this PR. I say wait a little bit, until different java impls have tested this code.

Updated and pushed.
Waiting 24-48 hrs before merging, given no further comments.

(Sorry for the delay, I have been buried here)
@michaelsembwever, you wrote:

Today the apidocs do not make any mentione of the -api classes returning null.
Therefore, by java standards, this means that null is never returned under any condition.

In that case I'd argue that we update the API docs to specify that extract() may return null if no SpanContext could be found. This issue need not block this PR, though (which LGTM)... just wanted to be clear about my take on this.

rebased off master.


Errors on site without expected parameters set

Hello!
$subj, when trying to run this theme against my blog source I get following (and nothing renders):
Building sites … WARNING: calling IsSet with unsupported type "ptr" (*hugolib.PageOutput) will always return false.

ERROR 2018/03/20 14:45:42 Error while rendering "page" in "": template: theme/_default/single.html:1:3: executing "theme/_default/single.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:45:42 Error while rendering "page" in "post/": template: theme/_default/single.html:1:3: executing "theme/_default/single.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:45:42 Error while rendering "taxonomy" in "": template: theme/_default/list.html:1:3: executing "theme/_default/list.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:45:42 Error while rendering "home" in "": template: theme/_default/list.html:1:3: executing "theme/_default/list.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:45:42 Error while rendering "section" in "": template: theme/_default/list.html:1:3: executing "theme/_default/list.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:45:42 Error while rendering "taxonomyTerm" in "": template: theme/_default/list.html:1:3: executing "theme/_default/list.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:45:42 Error while rendering "404" in "": template: theme/404.html:1:3: executing "theme/404.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string

Change detected, rebuilding site
2018-03-20 14:46:02.263 +0000
Source changed "/srv/hugo/content/post/2018-03-19-lust-for-text-life.markdown": WRITE
WARNING: calling IsSet with unsupported type "ptr" (*hugolib.PageOutput) will always return false.

ERROR 2018/03/20 14:46:02 Error while rendering "page" in "post/": template: theme/_default/single.html:1:3: executing "theme/_default/single.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:46:02 Error while rendering "home" in "": template: theme/_default/list.html:1:3: executing "theme/_default/list.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
ERROR 2018/03/20 14:46:02 Error while rendering "404" in "": template: theme/404.html:1:3: executing "theme/404.html" at <partial "top.html" .>: error calling partial: template: theme/partials/top.html:9:7: executing "theme/partials/top.html" at <partial "menu.html" ...>: error calling partial: template: theme/partials/menu.html:2:101: executing "theme/partials/menu.html" at <index $.Site.Data.tr...>: error calling index: value is nil; should be of type string
Total in 215 ms

The reason is likely some absent .Site. parameter but you can't tell it from error message, I guess input parameters handling could be improved.

https://github.com/hivickylai/hugo-theme-sam/pull/3 is an example of how this can be fixed.


v0.4.0

Add specific classes for file checking.
Add debug mode
More docstrings

Codecov Report

Merging #41 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           20        21    +1
  Lines         1275      1372   +97
=========================================
+ Hits          1275      1372   +97

Impacted Files
Coverage Δ

rumydata/__init__.py
100.00% <100.00%> (ø)

rumydata/_base.py
100.00% <100.00%> (ø)

rumydata/exception.py
100.00% <100.00%> (ø)

rumydata/field.py
100.00% <100.00%> (ø)

rumydata/menu.py
100.00% <100.00%> (ø)

rumydata/rules/cell.py
100.00% <100.00%> (ø)

rumydata/rules/column.py
100.00% <100.00%> (ø)

rumydata/table.py
100.00% <100.00%> (ø)

tests/test_menu.py
100.00% <100.00%> (ø)

tests/test_other.py
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527c3a6...b96d2b8. Read the comment docs.


Replace peer being null with checks for OfflineMultiplayerPeer

It seems that instead of not having a multiplayer peer when not connected, instead Godot 4 now has a class called OfflineMultiplayerPeer.

Thanks!!


Problem when mac and IPv4 are defined

I recently started seeing this and I didn't understand the problem.
[8/19/2022, 10:15:22 AM] [@vectronic/homebridge-ping-hosts] Restarting Process...
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] Launched child bridge with PID 31420
[8/19/2022, 10:15:23 AM] Registering platform<EMAIL_ADDRESS>[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] Loaded @vectronic/homebridge-ping-hosts v3.1.4 child bridge successfully
[8/19/2022, 10:15:23 AM] Loaded 0 cached accessories from cachedAccessories.0E56B10B8D61.
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] closed_on_success: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] startup_as_failed: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] closed_on_success: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] startup_as_failed: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] closed_on_success: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] startup_as_failed: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] closed_on_success: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] startup_as_failed: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] closed_on_success: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] startup_as_failed: true
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:23 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] failure_state: CONTACT_NOT_DETECTED

/homebridge/node_modules/@vectronic/homebridge-ping-hosts/index.js:68
        self.log.error("[" + self.name + "] multiple addresses specified, ipv4_address will be used");
        ^
ReferenceError: self is not defined
    at new PingHostContactAccessory (/homebridge/node_modules/@vectronic/homebridge-ping-hosts/index.js:68:9)
    at PingHostsPlatform.accessories (/homebridge/node_modules/@vectronic/homebridge-ping-hosts/index.js:37:26)
    at /homebridge/node_modules/homebridge/src/bridgeService.ts:534:24
    at new Promise (<anonymous>)
    at BridgeService.loadPlatformAccessories (/homebridge/node_modules/homebridge/src/bridgeService.ts:528:12)
    at ChildBridgeFork.startBridge (/homebridge/node_modules/homebridge/src/childBridgeFork.ts:155:36)
[8/19/2022, 10:15:24 AM] [@vectronic/homebridge-ping-hosts] Child bridge process ended
[8/19/2022, 10:15:24 AM] [@vectronic/homebridge-ping-hosts] Process Ended. Code: 1, Signal: null
[8/19/2022, 10:15:31 AM] [@vectronic/homebridge-ping-hosts] Restarting Process...
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] Launched child bridge with PID 31431
[8/19/2022, 10:15:32 AM] Registering platform<EMAIL_ADDRESS>[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] Loaded @vectronic/homebridge-ping-hosts v3.1.4 child bridge successfully
[8/19/2022, 10:15:32 AM] Loaded 0 cached accessories from cachedAccessories.0E56B10B8D61.
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] closed_on_success: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] startup_as_failed: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Brother Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] closed_on_success: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] startup_as_failed: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Abode Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] closed_on_success: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] startup_as_failed: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Cameras Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] closed_on_success: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] startup_as_failed: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [Neurio Online] failure_state: CONTACT_NOT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] closed_on_success: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] startup_as_failed: true
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] success_state: CONTACT_DETECTED
[8/19/2022, 10:15:32 AM] [@vectronic/homebridge-ping-hosts] [BigMac Online] failure_state: CONTACT_NOT_DETECTED

/homebridge/node_modules/@vectronic/homebridge-ping-hosts/index.js:68
        self.log.error("[" + self.name + "] multiple addresses specified, ipv4_address will be used");
        ^
ReferenceError: self is not defined
    at new PingHostContactAccessory (/homebridge/node_modules/@vectronic/homebridge-ping-hosts/index.js:68:9)
    at PingHostsPlatform.accessories (/homebridge/node_modules/@vectronic/homebridge-ping-hosts/index.js:37:26)
    at /homebridge/node_modules/homebridge/src/bridgeService.ts:534:24
    at new Promise (<anonymous>)
    at BridgeService.loadPlatformAccessories (/homebridge/node_modules/homebridge/src/bridgeService.ts:528:12)
    at ChildBridgeFork.startBridge (/homebridge/node_modules/homebridge/src/childBridgeFork.ts:155:36)
[8/19/2022, 10:15:33 AM] [@vectronic/homebridge-ping-hosts] Child bridge process ended
[8/19/2022, 10:15:33 AM] [@vectronic/homebridge-ping-hosts] Process Ended. Code: 1, Signal: null
[8/19/2022, 10:15:38 AM] [Flo notification] getStatus() http request returned http error code: 401
[8/19/2022, 10:15:38 AM] [Flo notification] Error occurred while pulling update from switch: Got html error code 401
[8/19/2022, 10:15:40 AM] [@vectronic/homebridge-ping-hosts] Restarting Process...

I then realized I had included both a mac and IPv4 address for a device in the configuration.

there should have been a warning in the UI. (nice to have)
the precedence should have been respected and the mac_address ignored.

Expected behavior
Things should have worked regardless.

Also noticed that with a valid and correct MAC address, one device was not discoverable for some reason.
[8/19/2022, 10:35:21 AM] [@vectronic/homebridge-ping-hosts] [Obihai VOIP Online] response error: Error: Invalid IP address 'null' for null at Fri Aug 19 2022 10:35:21 GMT-0700 (Pacific Daylight Time) with session 739

I will try to have a look at the issues you have raised in the coming week. Thanks for all of your feedback.

This should be fixed in the latest version 3.2.0.


added new scientific_operation

Added Some Scientific Operation Reciprocal and Cube. I created PR kindly check it and merge.

Please resolve the merge conflicts @Akshay-21