1801 Closed Period Reporting for ARPA and Treasury

Ticket #1801
Description
Added reporting for closed periods.
Still in draft as I finish up the test cases. Also waiting for some feedback on the github ticket.
Screenshots / Demo Video
Screenshot presented in the github ticket.
Testing
Ran locally, change the reporting period, then run the reports. Current period should work and give a report that looks normally. Prior periods look similar, but with a slight name change indicating the selected period.
Automated and Unit Tests

[ ] Added Unit tests

Manual tests for Reviewer

[x] Added steps to test feature/functionality manually

Checklist

[x] Provided ticket and description
[x] Provided screenshots/demo
[ ] Provided testing information
[ ] Provided adequate test coverage for all new code
[x] Added PR reviewers

Closing as we have not yet aligned on the product requirements here. Will re-open when there is more clarity.


[Server] Check allowed IP address and UserAgent before generating JWT in login_check

It is very confusing that it's not checked in this endpoint - the token is generated, but later it cannot be used (second part is ok - it should not be used if conditions such as IP address or UserAgent are not met)

Actually not a security issue, but it is counterintuitive


fix(repository): prevent casting json type to string

where.s the difference between json and string types?!

json is already parsed. Otherwise it will be converting it to a string resulting into "[object object]".

but then it.s an plain old javascript object. jsons are strings.

@doktordirk Type json works as expected and returns an object. This is the case in regular systems. The only way around is to re-stringify which is silly.


[R] CRAN issues with noRemap

In the CRAN checks for the last released version of XGBoost:
https://www.stats.ox.ac.uk/pub/bdr/noRemap/xgboost.out
There is now a check noRemap with this description:

Checks with -DR_NO_REMAP used for C++ code
Tests using R_CXX_NO_REMAP= true, which compiles C++ code with
R_NO_REMAP defined.  Otherwise as for the fedora-gcc checks:
see https://www.stats.ox.ac.uk/pub/bdr/Rconfig/r-devel-linux-x86_64-fedora-gcc
It is planned that this will become the default in due course, first
for CRAN incoming checks from 2024-04-14.

This gives compilation errors in XGBoost in all of the calls to R C-level functions that are not prefixed with Rf_, such as this:
xgboost_R.cc:684:28: error: 'allocVector' was not declared in this scope; did you mean 'Rf_allocVector'?
  684 |   out_shape_sexp = PROTECT(allocVector(INTSXP, out_dim));
      |                            ^~~~~~~~~~~

I am guessing that perhaps these short-hand no-Rf function names could be enabled by manually adding some define. Perhaps @jameslamb could comment here since LightGBM doesn't appear to suffer from these issues in the checks.
Otherwise, it might be a good idea to change all usages of R C-level functions to their equivalents that have Rf_ prefix (e.g. mkChar -> Rf_mkChar).

Thanks for the @.
In LightGBM, we have for a long time used this pattern:
#define R_NO_REMAP
#define R_USE_C99_IN_CXX
#include <Rinternals.h>

ref: https://github.com/microsoft/LightGBM/blob/5cd95a5b161d7630731d50e9ac529c6bf3dc809f/R-package/src/lightgbm_R.h#L10-L12
Combined with, as @david-cortes mentioned above, using the Rf_ prefix for things included from the R headers (e.g. Rf_allocVector()).
I suspect that's why {lightgbm} is not seeing this issue on CRAN. It should be safe for {xgboost} to do the same.
I think the best solution is just to do that (define R_NO_REMAP + use the Rf_ prefix). I'd be happy to put up a PR with that change.

Thank you for opening an issue. If we were to fix the CRAN errors, the fix needs to target the 1.7 branch. Will look into it and keep XGB on CRAN while the new interface is still ongoing.

Fixed in the CRAN release as well.


Add mkdtemp method

Node.js File System module has a method mkdtemp, used to create a temporary directory.
I would like to implement this method in Filer, before adding tests methods, mentioned in issue #394
  fs.mkdtemp(prefix, callback);
Here prefix is a name for a temporary directory. 6 random characters will be appended to the name to make sure directory is unique.
Error and path to created directory will be passed to a callback.
All temp directories will be created in /tmp.

Sounds good.  One thing to note: I don't think node assumes you'll always put your temp files in /tmp.  My reading of the docs is that you specify a prefix, and it uses that.  So for example you could do: mkdtemp('/tmp/', callback) and it will create /tmp/ay3ri1.  But you could also use mkdtemp('/foo/tmp-', callback) and get /foo/tmp-ay3ri1.  We should confirm this so we match what node does.

I assumed that all new tmp directories will be created in /tmp.
I will test how node handles cases you mentioned, and will update mkdtemp method accordingly.

Finished in https://github.com/filerjs/filer/commit/0eb7066a861d9d4506a4b2b2bb10865379aab82c


Model, form, and indexer mixins to load configuration from metadata yaml

Refactor creator/contributor fields to be schema driven
Rebase of #347.

Closing this as the branch has been moved to here: https://github.com/ubiquitypress/hyku_addons/pull/512


[Desktop App] onboardjs QA

This tickets relates to #412
The current build of the desktop app is pointing to staging
https://safe-team-rinkeby.staging.gnosisdev.com/app/#/
The desktop app staging repo: https://github.com/gnosis/safe-multisig-electron/releases/tag/v1.0.0-staging
The onboard has the same options that are in staging:

Opera and Metamaks options cannot work in the desktop app

Fortmatic connects fine, but most of the times it won't show the modal to sign a Tx. This issue doesn't happen in the browser version

Authereum is not consisntent, it opens a new window to sign and loads the safe-multisig app in that window, sometimes both the new window and the current window stay blank and have to restart the app.
Probably this should be fixed on the onboardjs

Ledger: It doesnt connect. This was reported in the "Ledger support" ticket

WalletConnect (using metamask in mobile) and Portis (Login with email) were the only 2 options that worked consistently

@francovenica Closing this as these issues should be addressed in the resolved in the newer versions. We can create new tickets if something pop-ups during QA.


Gather documents one at a time, as separate entries in the ALDocumentBundle

Fix #112
Fix #120

Both moved to a different part of the interview--I should have just deleted instead of commenting out th old questions, sorry for confusion there


Update README.md

Fixed image display error

<img /> is an html label, and src is its attribute to specify the source of the image to display. So I think we shouldn't use [](). See below for details:
<img> | MDN Web Docs


Regression: parsing error when opening any tailwind.config.js

The plugin throws a Parsing with every tailwind.config.js I tried, no matter how simple they are.
You can reproduce the error using this tailwind.config.js:
module.exports = {
  purge: [],
  theme: {
    extend: {
      colors: {
        cyan: '#9cdbff',
      }
    },
  },
  variants: {},
  plugins: [],
}

or this:
module.exports = {
  theme: {
    extend: {
      colors: {
        cyan: '#9cdbff',
      }
    }
  }
}

The error in console says only
{twPrefix: "", addSpaces: false, overrideStyles: false, configName: "tailwind.config.js", errorMessage: "Parsing failed!"}

@leinardi import system works different now as described on the plugin page.
I actually expected this FileUpload.tsx#L33  to work to prevent people from importing .js files.
Probably need to add a notice if someone imports .js.

I see, I don't actually use TailwindCSS (I use Figma just for Android and iOS development) so I can't generate one of this tailwind.json, but I would still like to use this plugin to import in Figma color styles from a configuration file.
Could you please point me to a very simple example of tailwind.json that I can use to manually build mine?

Never mind, I found a working one in this very same repo:
https://raw.githubusercontent.com/impulse/tailwindcss-figma-plugin/e6048553c89dd362acd8546aa854d431849980f4/src/generated/tw.min.json

This is the minimum needed to import the colors:
{
   "theme":{
      "colors":{
         "transparent":"transparent",
         "current":"currentColor",
         "black":"#000",
         "white":"#fff",
         "gray":{
            "100":"#f7fafc",
            "200":"#edf2f7",
            "300":"#e2e8f0",
            "400":"#cbd5e0",
            "500":"#a0aec0",
            "600":"#718096",
            "700":"#4a5568",
            "800":"#2d3748",
            "900":"#1a202c"
         },
         "red":{
            "100":"#fff5f5",
            "200":"#fed7d7",
            "300":"#feb2b2",
            "400":"#fc8181",
            "500":"#f56565",
            "600":"#e53e3e",
            "700":"#c53030",
            "800":"#9b2c2c",
            "900":"#742a2a"
         },
         "orange":{
            "100":"#fffaf0",
            "200":"#feebc8",
            "300":"#fbd38d",
            "400":"#f6ad55",
            "500":"#ed8936",
            "600":"#dd6b20",
            "700":"#c05621",
            "800":"#9c4221",
            "900":"#7b341e"
         },
         "yellow":{
            "100":"#fffff0",
            "200":"#fefcbf",
            "300":"#faf089",
            "400":"#f6e05e",
            "500":"#ecc94b",
            "600":"#d69e2e",
            "700":"#b7791f",
            "800":"#975a16",
            "900":"#744210"
         },
         "green":{
            "100":"#f0fff4",
            "200":"#c6f6d5",
            "300":"#9ae6b4",
            "400":"#68d391",
            "500":"#48bb78",
            "600":"#38a169",
            "700":"#2f855a",
            "800":"#276749",
            "900":"#22543d"
         },
         "teal":{
            "100":"#e6fffa",
            "200":"#b2f5ea",
            "300":"#81e6d9",
            "400":"#4fd1c5",
            "500":"#38b2ac",
            "600":"#319795",
            "700":"#2c7a7b",
            "800":"#285e61",
            "900":"#234e52"
         },
         "blue":{
            "100":"#ebf8ff",
            "200":"#bee3f8",
            "300":"#90cdf4",
            "400":"#63b3ed",
            "500":"#4299e1",
            "600":"#3182ce",
            "700":"#2b6cb0",
            "800":"#2c5282",
            "900":"#2a4365"
         },
         "indigo":{
            "100":"#ebf4ff",
            "200":"#c3dafe",
            "300":"#a3bffa",
            "400":"#7f9cf5",
            "500":"#667eea",
            "600":"#5a67d8",
            "700":"#4c51bf",
            "800":"#434190",
            "900":"#3c366b"
         },
         "purple":{
            "100":"#faf5ff",
            "200":"#e9d8fd",
            "300":"#d6bcfa",
            "400":"#b794f4",
            "500":"#9f7aea",
            "600":"#805ad5",
            "700":"#6b46c1",
            "800":"#553c9a",
            "900":"#44337a"
         },
         "pink":{
            "100":"#fff5f7",
            "200":"#fed7e2",
            "300":"#fbb6ce",
            "400":"#f687b3",
            "500":"#ed64a6",
            "600":"#d53f8c",
            "700":"#b83280",
            "800":"#97266d",
            "900":"#702459"
         }
      }
   }
}

Never mind, I found a working one in this very same repo:
https://raw.githubusercontent.com/impulse/tailwindcss-figma-plugin/e6048553c89dd362acd8546aa854d431849980f4/src/generated/tw.min.json

If you need to use a custom config I am afraid installing node/npm and running npx tailwind.json in your config directory is your only option now. Sanitizing the config for every possible scenario just got too messy.


Delete Logic and Card Design

Adding delete dialogs
Adding delete functionality for PLanguages, PViews and DesignModels
Unifying Card Style
Making Icons work for PatternViews

Requires backend branch: https://github.com/PatternAtlas/pattern-atlas-api/tree/fix/delete-functionality
Please Merge simulatinously

One tiny comment: after deleting a pattern in a pattern language, the overview of pattern languages still displays the old number of patterns for this language

One tiny comment: after deleting a pattern in a pattern language, the overview of pattern languages still displays the old number of patterns for this language


cmd/compile: optimize Write([]byte(stringVal)) to not copy the string

It would be nice to optimize Write([]byte(stringVal)) to not copy the string value.  This is normally safe because most Write methods do not modify the byte slice passed in.  In fact, the documentation for io.Writer requires that the Write method not modify the byte slice, although this is not (and can not be) enforced.
Here is how we can do this.
For each function and method that takes a parameter of slice type, record whether the slice's underlying array is modified.  This will require generating annotations similar to the ones we generate for escape analysis.  Assembly functions will require an annotation similar to //go:noescape.  (Naturally, a slice that escapes must be treated as modified.)
For each call of the form F([]byte(stringVal)), where we know that F does not modify the slice, we can pass the string value directly.  This would do essentially the same thing as the existing optimization for map lookups in which a []byte is converted to a string.  This fixes direct calls, but of course the interesting cases all involve calls to methods of values of type io.Writer.
For any type with a Write method that does modify the slice, generate at compile time an additional Write·2 method that makes a copy of the slice and then calls the Write method.  The method is named Write·2 to ensure that it does not conflict with any user written method.
When converting any type to io.Writer (or any interface type that inherits from io.Writer), check for the presence of a Write·2 method.  If that method exists, add it to the interface as an additional entry in the itab.
For any call to an interface method Write([]byte(stringVal)), modify the call to call a special function doWrite in the io package, without copying the string.  doWrite will check for a Write·2 method, and call it if it exists; that will cause the string to be copied as happens today.  If the Write·2 method does not exist, which will be the normal case, doWrite will call the Write method as usual, knowing that the Write method does not modify the slice.
Generalizing this to other methods is left as an exercise for the reader.

I feel like there was a dup bug with the same plan but rejected because as I recall: nobody should be working with such large strings and stay in bytes if they want performance.
Was this motivated by something concrete?

There was no specific motivation; it was just an idea I had.

Your compiler annotation for Write sounds a lot like the compiler secretly interpreting Write([]byte) to be Write(immutable []byte); the same could be done for other pointer arguments that are provably unmodified.
Such an (internal) annotation would have additional benefits:

Methods that do not modify their receiver won't require callers to re-load fields (I don't know  how common this is or how much it would matter, but it's something)
Functions/methods with only immutable arguments (including implicit globals) may be hoisted, etc. (Similar to __attribute__((const)) and __attribute__((pure)).

This would remove the need for my attempted optimization in #13848, which tried to optimize string writing at the standard library level.

How does this work for nested calls of io.Writer?
func (t *T) Write(p []byte) (int, error) {
	return t.wr.Write(p)
}

You do not know if T.Write mutates p or not because it depends on whether t.wr.Write mutates p. To be conservative, it will need to assume that it is mutated and the compiler will emit T.Write·2 removing any benefit from the proposed optimization.

@dsnet For a case like that you turn T.Write·2 into a copy of the entire method, that passes p along uninterpreted for possibly copying by t.wr.Write·2.

@ianlancetaylor, Doesn't that approach fail for this example (that nobody should ever write):
	t := &T{wr: ...}
	t.Write([]byte("hello"))

func (t *T) Write(p []byte) (int, error) {
	n, err := t.wr.Write(p) // Assume t.wr.Write mutates p, but not known at compile time
	fmt.Println(p[0]) // Read p, expect to see mutated value
	return n, err
}

So T.Write·2 is a copy of T.Write but the call to t.wr.Write is replaced by doWrite(t.wr, p). If t.wr.Write does mutate p, then we are guaranteed that the "hello" string is not accidentally mutated (correct). However, the fmt.Println(p[0]) will not be able to observe the mutation that t.wr.Write caused because of the copy (wrong).
I guess that this is solvable if doWrite was changed such that the new copy was known to the caller.

You're right: in general, if the method does something with the buffer after passing it to Write, it may not be possible to apply this optimization to callers of that method.

Avoiding the allocation is exactly the reason we have a separate
WriteString interface.
I think we should figure out the question of immutable types in general
before adding this kind of workarounds.
(I read that it's on Russ' plan for 2017 to research more about
immutability in Go.)
BTW, we probably don't need to make the compiler work so hard for this, one
intermediate step that is probably good enough would be to allow trivial
and allocate free WriteString implemented as:
func (t *T) WriteString(s string) (int, error) {
return t.Write([]byte(s))
}
when the compiler could statically prove that the Write method won't write
to the string.

Related to #2205 (cmd/compile: read-only escape analysis and avoiding string <-> []byte copies).


Creating an app with the name of an empty group overrides the group

If a app is created with the same name as and empty group the empty group is removed.
This also applies if the empty group does contain another empty group.
Scenario:

Create an empty group named test
Create an app with the id test.
App definition:

{
  "cmd": "sleep 100;",
  "cpus": 1,
  "mem": 128,
  "disk": 0,
  "instances": 1,
  "id": "test"
}

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1700. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1700. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


win,fs: don't modify global file translation mode

Back in https://github.com/libuv/libuv/commit/25175c when the filesystem API was initially implemented on Windows, uv_fs_open was internally implemented by calling the _open function. Shortly thereafter, in https://github.com/libuv/libuv/commit/e1af07, the implementation was changed to use CreateFile instead. However, the code in uv_fs_init that was modifying the global _fmode variable to set the default file translation mode to binary was left in place, and has been there for 8 years.
A library like libuv shouldn't be changing this global state, because the embedding application may need to use a different default file translation mode (this is how we found out libuv was doing this). Also, since the change to use CreateFile there's no longer a need for libuv to change this mode anyway, because it no longer uses either _open or _pipe, which are the functions that this global mode variable affects as per the docs.
This change stops libuv from changing this global state. All tests still pass after this change.

Thanks, added a new commit to delete the now unused uv_fs_init.

@jblazquez This PR seems to make a test fail consistently on Windows (failing on all hosts):
06:49:12 not ok 34 - fs_async_sendfile
06:49:12 # exit code 3
06:49:12 # Output from process `fs_async_sendfile`:
06:49:12 # Assertion failed in test-fs.c on line 1122: 65542 == lseek(f, 65536, SEEK_CUR)

Can you take a look?
I was kind of afraid libuv users implicitly depending on the value of _fmode  might turn out to be issue, and seeing that our own test suite does, that's probably a legitimate fear.
Here is a Node.js integration CI for good measure: https://ci.nodejs.org/view/libuv/job/libuv-in-node/98/

Surprisingly, the Node integration CI seems to be OK.

@bnoordhuis you're right, that fs_async_sendfile test was failing with my changes and I missed it, thanks. The reason was that it was assuming binary file mode but the default was text and the \n was being converted to \r\n on Windows:
static void sendfile_setup(int f) {
  ASSERT(6 == write(f, "begin\n", 6)); // <- was actually writing 7 bytes
  ASSERT(65542 == lseek(f, 65536, SEEK_CUR));
  ASSERT(4 == write(f, "end\n", 4));
}

I pushed a new change to make the test runner change the default file translation mode to binary, because that's what the tests are expecting.
I agree that it is possible some existing users of libuv may be implicitly depending on the file mode being set to binary indirectly by the library. The _fmode setting code had been there for 8 years after all. I guess we would need to decide whether we want to keep the _fmode setting code for the sake of those existing users, or go ahead with this PR for the sake of future users that may not want the mode changed under them. This is my thinking:

If we keep the _fmode setting code then existing users don't need to do anything, but future users who depend on the default file translation mode would need to reset the mode to text if that's what they need. This has to be done after the first call to any libuv library function, because that's what implicitly calls uv_fs_init and changes the mode to binary. For some users it will be trivial to add their own _set_fmode call after calling the first libuv function, but for others it might not be, for example if they don't directly use libuv but rather link to another library that internally does and they can't control when exactly that library will call the first libuv function and change this global mode. This is the main drawback of changing global process state from a library.

If we remove the _fmode setting code in libuv then future users don't need to do anything, but some existing users may need to set the default file translation mode themselves when they didn't have to before. They can do this at the start of their program or wherever is convenient for them. I can't think of any reasonable scenario where this would pose a significant challenge, other than of course the need to add some code to their application.

I understand if libuv decides that any chance of breaking an existing user is not acceptable and it would be better to keep this global state change in the library for the sake of those users, but it would be a shame being unable to ever walk back this code written so early in the project. Would a warning in the release notes or in the documentation about the file translation mode help appease these concerns?

@libuv/collaborators It would be good if you could weigh in, and @vtjnash, perhaps you can check whether this breaks Julia?
My own line of thought is that touching the global file mode in a library is a bug so I am (with some trepidation) in favor of landing this change.
We would need to call it out clearly in the release notes, though. A note at the top of docs/src/fs.rst probably won't hurt either.

It sure feels like a bug, I'm +1 on lading this.

It won't break Julia since we don't use this LTS branch, and it's already gone from master. It does seem like a breaking change to do for other consumers though, especially since it breaks the tests.

I'm OK with landing it.

Hi, just wanted to point out that there is a similar issue (e.g modifying process wide settings) with SetErrorMode() on Windows. I filed #1327 some time back and it was rejected out of fear for breaking users that depended on the existing behavior...

+1 to landing.

Landed in f9adfb2f, thanks! Let's see how many bug reports we receive. :-)

I rebased this commit out of the v1.x branch for the 1.30.1 patch release. Now that the release is out, I've landed this again as https://github.com/libuv/libuv/commit/c905e0bed86b5b6695f90844ef9ad2833b8ec2ec.


Push documentation when community changes

Added a postsubmit job to regenerate the documentation for when any part of the community docs/ folder contents changes

/lgtm


HDDS-5606. Intermittent failure in TestBlockDeletion#testContainerStatisticsAfterDelete

https://issues.apache.org/jira/browse/HDDS-5606

Thanks @ChenSammi for working on this.
* Can you please explain the problem and the solution?

    The problem is a container state change from DELETEING to DELETED check failure.  The change will happen without questoin.  The question is the timing. So the fix is the addition of a retry of the state check action.

* Does this also address [HDDS-5605](https://issues.apache.org/jira/browse/HDDS-5605)?

    This doesn't address HDDS-5605.   HDDS-5605 is still under investigation.

* Do we have any data on repeated run success rate?

   I have run the CPI three times,  two times succeed, the third fails with other UT failure, such as TestRootedOzoneFileSystemWithFSO.  It seems there are several tests which fails randomly, and need to be fixed too.

This only changes TestBlockDeletion, which is passing:
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 200.333 s - in org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion

and the only failure is in TestOzoneManagerBootstrap, which is being fixed in #2550.
Therefore I'm merging this without retriggering CI.

Thanks @adoroszlai for the code review.


[Test] Add Symbols visible on Fedora 39

Adding new symbols exposed from libstdc++ on Fedora 39 and Ubuntu 24.04.
PR against main: https://github.com/swiftlang/swift/pull/73142
PR against 6.0: https://github.com/swiftlang/swift/pull/76022

Explanation: There are more symbols exported from the libstdc++ on newer Linux distros
Scope: The symbol visibility test on Linux
Original PR: https://github.com/swiftlang/swift/pull/73142
Risk: Low (it's a test change that only affects Linux)

@swift-ci please test


Vagrant boxes not available on Vagrant cloud

Building a new vagrant box fails. Example Vagrantfile:
Vagrant.configure(2) do |config|

  config.vm.box = "boxcutter/centos7"
  config.vm.box_version = "17.0915.1"
end

It seems like all vagrant boxes are gone from vagrant cloud:
https://app.vagrantup.com/boxcutter

OK. Thanks for info.


Pass context information to operators on execution

When an ExecutionOperator gets hold of the OperatorContext it can use that information for several aspects:

a hash join could use cardinality information to find out which side to index and which side to use for probing
in-loop operators could modify certain configurations based on the current number of iteration

Thus, such context information should be made available to ExecutionOperators.

This issue was moved to rheem-ecosystem/rheem#20


Allow lists in --param

closes #1987
Work done so far: update ParseVariableFunction to return map[string]interface{} & update associated test.
ToDo: Add tests for new array functionality.

Hi @carolynvs it's not clear from the issue so is the goal to have:
svcat somecommand -p colors=red -p colors=blue somethingelse=banana -->
map{colors: [red, blue], somethingelse:banana}
OR
map{colors: [red, blue], somethingelse:[banana]}

@kibbles-n-bytes Can you help weigh in on what behavior we want for parameters that are only listed once? I am leaning towards saying that -p somethingelse=banana should be interpreted as "somethingelse": "banana".

Ready for review: @carolynvs @kibbles-n-bytes @n3wscott


fix: Modify region list to a boto3 call

Issue number:#25
Summary
Changes
The goal of this PR is update the regions list  maintained as a hardcoded list to an api call which pulls the active supported regions.
User experience
No Changes.
Checklist
If your change doesn't seem to apply, please leave them unchecked.

[X] I have performed a self-review of this change
[X] Changes have been tested
[ ] Changes are documented

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
Base: 10.89% // Head: 11.25% // Increases project coverage by +0.35% :tada:

Coverage data is based on head (73ef9a1) compared to base (9e94a28).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   10.89%   11.25%   +0.35%
==========================================
  Files          10       10
  Lines        1974     1982       +8
==========================================
+ Hits          215      223       +8
  Misses       1759     1759

Impacted Files
Coverage Δ

eksupgrade/cli.py
94.59% <100.00%> (+1.49%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Copy Grants to Options in Table and View Materialization's

Add Copy Grants to View and Table Config Statement
Typically with Snowflake Tables and Views we use a Copy Grants switch to maintain grants on current View and Tables in Snowflake. Adding this will alleviate some of the Post-Hook commands to add Grants to existing objects. If the object has no grants this is ignored by snowflake.
Alternative Approach using Post-Hooks
Adding Post-Hook Events to Re-Apply Grants. grant select on table to role myrole
Snowflake Feature Only
This feature is for the Snowflake Adapter only. If developers are not responsible for maintaining security (as in roles, as we should all be thinking about security) this would alleviate additional work by the Administrator by maintaining the current security on the object
Benefits?
This will benefit Developers and Admins when maintaining current access permissions to an object. Also it will help to create objects that need to maintain roles and are re-initialized outside of DBT. The Copy Grants switch will be present in the DDL of the Snowflake object when viewing the source through the GET_DDL command or viewing the View source.
Sample Code Output
CREATE OR REPLACE View myView  /* Added Copy Grants Here */ COPY GRANTS as  ( Select 1 as Id );

fixed by #1747


Move search icon placement to always be on the LEFT

Current search icon placement

With validation (moves to the left)

New search icon placement
ALWAYS ON THE LEFT

In percy shots it looks like the search icon isn't placed properly inside the input container and is pushing the input down. That needs to be fixed. Also some merge/stash comments need to be removed.

My bad. this is the faulty stash issue that was meant to fix the test. All shud work

Latest Percy snapshots here


Feature/query processor

What is this pull request?
Query execution and validation
Why do you implement it? Why do we need this pull request?
Each query should be validated and  execution  in Ametsuchi. QueryProcessingFactory allows to execute and validate each query. For example, Torii will use QueryExecutionFactory via ThreadPool.
How to use the features provided in the pull request?
Tests on validation  and execution are provided in:
test/module/irohad/validation/query_execution.cpp.

For some reason develop stopped building after merging this commit. I am reverting changes


[catnap] Enhancement: Move to socket2

This code is a merge of the Windows and Linux code paths for Catnap into a single socket2 API. It is a first step to supporting epoll and completion ports. There are 3 commits:

Just commenting out some overwhelming debug messages.
The bulk of the changes adding a CatnapTransport
An extra bug fix. It seems like if we start the next test too soon after the previous one exits, the old server address is still bound for a little while. We should probably set to this to some reasonable number but not really sure what.
Remove level of unnecessary abstraction for sockets. Now that we are using Socket2, we can keep all of the per-queue code in either the CatnapQueue or the transport.

An extra bug fix. It seems like if we start the next test too soon after the previous one exits, the old server address is still bound for a little while. We should probably set to this to some reasonable number but not really sure what.

@iyzhang this is due to the "TIME_WAIT" state. There are some per-system solutions that might be explored, such as using the SO_REUSEADDR.

An extra bug fix. It seems like if we start the next test too soon after the previous one exits, the old server address is still bound for a little while. We should probably set to this to some reasonable number but not really sure what.

@iyzhang this is due to the "TIME_WAIT" state. There are some per-system solutions that might be explored, such as using the SO_REUSEADDR.

Ah great! Let me know what the right solution is. I can certainly set SO_REUSEADDR on all listening sockets.

An extra bug fix. It seems like if we start the next test too soon after the previous one exits, the old server address is still bound for a little while. We should probably set to this to some reasonable number but not really sure what.

@iyzhang this is due to the "TIME_WAIT" state. There are some per-system solutions that might be explored, such as using the SO_REUSEADDR.

Ah great! Let me know what the right solution is. I can certainly set SO_REUSEADDR on all listening sockets.

Setting SO_REUSEADDR in all listening sockets works for Linux, not sure how that behaves in Windows. @kyleholohan any ideas on this?


New version: MINPACK v1.1.1

Registering package: MINPACK
Repository: https://github.com/sglyon/MINPACK.jl
Created by: @sglyon
Git reference: register/MINPACK/v1.1.1
Version: v1.1.1
Commit: 8f5f724375c36631ffec5b33749013ac930da64a
Reviewed by: @sglyon
Reference: https://github.com/sglyon/MINPACK.jl/commit/8f5f724375c36631ffec5b33749013ac930da64a#commitcomment-33562573

I'm not sure what this error is in my tests...
Does the printf code used a type SmallNumber? For some reason that isn't defined on windows 32 bit?

That is a bug with bugfix included in 1.0.1 (https://github.com/JuliaLang/julia/pull/29663), but not 0.7 where you test.

Ahh thank you. I updated my travis file, but not appveyor. Updating now

Do you still want to support 0.7?

I'm ok supporting it. Doesn't require extra code from me so it doesn't hurt


Improve docstrings in functions

Rewrite docstrings to include executable examples. This will allow for doctests in addition to improving documentation.

see eg the docstrings here for some good examples: https://github.com/ccb-hms/BioPlexPy

The documentation of each function within the codebase should contain:

[] Title
[] Short description
[] Inputs (@params) (incl. data type and short description)
[] Outputs (@returns) (incl. data type and short description)
[] An executable example that illustrates how to use the function


Update index option

Description

Make geodata index as hidden
Make geodata index as read only allow delete after creation is done
Refresh datasource index immediately after update

Issues Resolved
N/A
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #284 (120a163) into feature/ip2geo (76790bd) will increase coverage by 0.22%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@                 Coverage Diff                  @@
##             feature/ip2geo     #284      +/-   ##
====================================================
+ Coverage             86.37%   86.59%   +0.22%
- Complexity              510      511       +1
====================================================
  Files                    67       67
  Lines                  2003     2014      +11
  Branches                184      184
====================================================
+ Hits                   1730     1744      +14
+ Misses                  204      202       -2
+ Partials                 69       68       -1

Impacted Files
Coverage Δ

...rch/geospatial/ip2geo/common/DatasourceFacade.java
89.74% <100.00%> (+0.26%)
:arrow_up:

...arch/geospatial/ip2geo/common/GeoIpDataFacade.java
81.50% <100.00%> (+1.35%)
:arrow_up:

... and 1 file with indirect coverage changes


Fix wrong argument in change node

The change node could not change a value of flow and global context, because it passed wrong argument to get() function.
I fix it and add test cases.

Coverage increased (+0.3%) to 86.394% when pulling 7cb05ed822df1d0d38ca816ccb458c64a8c746f3 on HirokiUchikawa:master-changenode into 039bd1ddc0f862a981df2295a1ff786454492f84 on node-red:master.


Svelte renderer doesn't work

Imports can't be resolved
After the build, files are transformed  from .ts to .mjs files, so they can't be resolved inside the Svelte components.
-import { codeToKeyedTokens, createMagicMoveMachine } from '../core'
-import type { MagicMoveRenderOptions, MagicMoveDifferOptions } from '../types'
+import { codeToKeyedTokens, createMagicMoveMachine } from '../core.mjs'
+import type { MagicMoveRenderOptions, MagicMoveDifferOptions } from '../types.d.ts'

The fix is simple as adding the extension, which would at least make it work for the build.
No type definitions
TypeScript complains about the import.
<script lang="ts">
  import { ShikiMagicMove } from 'shiki-magic-move/svelte'
</script>

Module '"shiki-magic-move/svelte"' has no
exported member 'ShikiMagicMove'.ts(2305)

The solution might be to include a separate type declaration file, but I'm not familiar with the build system.

✘ [ERROR] Could not resolve "../core"

    node_modules/.pnpm/shiki-magic-move@0.4.0_shiki@1.5.1_svelte@4.2.16_vue@3.4.27_typescript@5.3.2_/node_modules/shiki-magic-move/dist/svelte/ShikiMagicMove.svelte:22:58:
      22 │ import { codeToKeyedTokens, createMagicMoveMachine } from "../core";
         ╵                                                           ~~~~~~~~~

✘ [ERROR] Could not resolve "../core"

    node_modules/.pnpm/shiki-magic-move@0.4.0_shiki@1.5.1_svelte@4.2.16_vue@3.4.27_typescript@5.3.2_/node_modules/shiki-magic-move/dist/svelte/ShikiMagicMovePrecompiled.svelte:23:45:
      23 │ import { syncTokenKeys, toKeyedTokens } from "../core";
         ╵                                              ~~~~~~~~~

✘ [ERROR] Could not resolve "../renderer"

    node_modules/.pnpm/shiki-magic-move@0.4.0_shiki@1.5.1_svelte@4.2.16_vue@3.4.27_typescript@5.3.2_/node_modules/shiki-magic-move/dist/svelte/ShikiMagicMoveRenderer.svelte:35:34:
      35 │ import { MagicMoveRenderer } from "../renderer";
         ╵                                   ~~~~~~~~~~~~~


Please add support of v45.0 for signed requests

Signed request of canvas application returns links for v45.0 but JSforce ignore it and trying to use v42.0 urls that is wrong.

Ok everything I do is wrong, I will keep trying
Mamie

triaging old issues...
the default API version used in jsforce v3 is 50.0, you can also specify it when creating a connection and it will be used for all requests.


max-width emulation

Great plugin!
Is there a way to maintain the classes of the breakpoints after passing the corresponding width? I want to emulate the max-width behavior of the media queries.
For example, if I have 2 breakpoints - 500 and 700 - is there a way to maintain the 700 breakpoint class when the device gets to 500 width, so it will show the 500 class and the 700 class?
I want to change something at 700 breakpoint and keep it like for any width below that.
Thank you.

If you're trying to emulate the following:
@media only screen and (max-width: 700px)  {...}

Then your Restive.JS Constructor should look like this:
    $(document).ready(function () {
        $('body').restive({
            breakpoints: ['700'],
            classes: ['css-700'],
            force_dip: true
        });
    });

This will create a breakpoint range of 0 - 700 pixels, and it will apply the class css-700 [which you can change to whatever you want] to the body tag, only if the device width falls within that range. force_dip will tell Restive.JS to use device-independent pixels as the standard of measure (the same behavior as Media Queries).
Is this what you wanted?

Yeah, but with multiple breakpoints. If I add another breakpoint:
$(document).ready(function () {
        $('body').restive({
            breakpoints: ['500','700'],
            classes: ['css-500','css-700'],
            force_dip: true
        });
    });

You get 0-500 range to css-500 and 500-700 to css-700. I want 0-500 and 0-700, like css do with @max-width.
I work around it doing:
$(document).ready(function () {
        $('body').restive({
            breakpoints: ['500','700'],
            classes: ['css-500 css-700','css-700'],
            force_dip: true
        });
    });

But is not very elegant. Doing with multiple instances of restive to diferent elements isn't either.
Maybe use a diferent sufix for this situation. Something like:
$(document).ready(function () {
        $('body').restive({
            breakpoints: ['500','700-mx'],
            classes: ['css-500','css-700'],
            force_dip: true
        });
    });

Similar to the orientation markers.

In that case, use multiple constructors like this:
$(document).ready(function () {
    $.restive.startMulti();

    $('body').restive({
        breakpoints: ['500'],
        classes: ['css-500'],
        force_dip: true
    });

    $('body').restive({
        breakpoints: ['700'],
        classes: ['css-700'],
        force_dip: true
    });

    $.restive.endMulti();
});

Restive.JS should select the best match in the way you have described.
And if that doesn't work for you, you can do it the old-fashioned way like this:
$(document).ready(function () {
    if(Restive.pixelW() <= 500)
    {
        $.('body').addClass('css-500');
    }
    else if(Restive.pixelW() <= 700)
    {
        $.('body').addClass('css-700');
    }
});


Websocket support

Thanks for this package, it's working great!
But how could I integrate this with Socket.io or SockJS? I need to mock these too.
My application have a REST-API that I mock with webpack-api-mocker during development, but my application also pushes updates with websocket and I need to be able mock these to. Can I get the HTTP-handler from webpack-api-mocker somehow, or could I create one myself and provide it to webpack-api-mocker?
https://github.com/sockjs/sockjs-node

https://webpack.js.org/configuration/dev-server/#devserver-proxy
You can use the webpack proxy, Proxy to your websocket service.
proxy: {
  '/socket/**': {
    target: 'ws://<IP_ADDRESS>:8443',
    ws: true,
    secure: false,
    logLevel: 'debug',
  },
}

Thanks for pointing me at the right direction!
Now SockJS works with these webpack.config.js settings:
  proxy: {
      '/ws': {
        target: 'ws://localhost:8081/websocket',
        pathRewrite: {'^/ws' : ''},
        ws: true,
        secure: false,
        logLevel: 'debug',
      },
    },
    before(app) {
      apiMocker(app, resolve(__dirname, '..', 'mock', 'api-mocker.js'));
      require(resolve(__dirname, '..', 'mock', 'socket-mocker.js'))(8081);
    }

And the content of the socket-mocker.js file:
  module.exports = (port) => {
  let http = require('http');
  let sockjs = require('sockjs');
  let clients = new Map();

  let wsServerer = sockjs.createServer({ sockjs_url: 'http://cdn.jsdelivr.net/sockjs/1.0.1/sockjs.min.js' });
  wsServerer.on('connection', (conn) => {
    clients.set(conn.id, conn);
    console.log('Websocket client connected, id: ' + conn.id);

    conn.on('data', (message) => {
      console.log('websocket got:' + message);
    });
    conn.on('close', () => {
      console.log('Websocket client disconnected, id: ' + conn.id);
      clients.delete(conn.id);
    });
  });

  let httpServer = http.createServer();
  wsServerer.installHandlers(httpServer);
  httpServer.listen(port, '<IP_ADDRESS>');

  setInterval(() => {
    clients.forEach((client, id) => {
      client.write("hi");
    });
  }, 2000);
}


[Regression] Stream API fails to write XLSX files

Since version 0.2.10, exceljs fails to write xlsx files using the stream API with the following error:
Unhandled rejection Error: append: input source must be valid Stream or Buffer instance
    at Archiver.append (/home/bugreport/backend/node_modules/archiver/lib/core.js:333:24)
    at /home/bugreport/backend/node_modules/exceljs/lib/stream/xlsx/workbook-writer.js:251:18
    at Promise._execute (/home/bugreport/backend/node_modules/bluebird/js/release/debuggability.js:272:9)
    at Promise._resolveFromExecutor (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:475:18)
    at new Promise (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:77:14)
    at Object.WorkbookWriter.addSharedStrings (/home/bugreport/backend/node_modules/exceljs/lib/stream/xlsx/workbook-writer.js:250:14)
    at /home/bugreport/backend/node_modules/exceljs/lib/stream/xlsx/workbook-writer.js:131:16
    at tryCatcher (/home/bugreport/backend/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:504:31)
    at Promise._settlePromise (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:561:18)
    at Promise._settlePromise0 (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:606:10)
    at Promise._settlePromises (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:685:18)
    at Promise._fulfill (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:630:18)
    at Promise._resolveCallback (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:447:14)
    at Promise._settlePromiseFromHandler (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:516:17)
    at Promise._settlePromise (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:561:18)

This is the code to reproduce the problem:
const fs = require('fs');
const Excel = require('exceljs');

let outStream = fs.createWriteStream('/tmp/aaa', {flags: 'w'})

let options = {
    stream: outStream,
    useStyles: true,
    useSharedStrings: true
};

let workbook = new Excel.stream.xlsx.WorkbookWriter(options);
let worksheet = workbook.addWorksheet('test');
let newrow = worksheet.addRow(['hello']);
newrow.commit();
worksheet.commit();
workbook.commit();

If you do not add any row, it works fine.
Also, worked fine on 0.2.9 and previous versions.

Some error. My code
router.get("/", (req, res, next) => {
  const options = {
    stream: res,
    useStyles: true,
    useSharedStrings: true
  }
  const workbook = new Excel.stream.xlsx.WorkbookWriter(options)
  const sheet = workbook.addWorksheet("Report")
  const worksheet = workbook.getWorksheet("Report")
  worksheet.columns = [
    {width: 20},
    {width: 12},
    {width: 30},
    {width: 18},
    {width: 30},
    {width: 6}
  ]
  const box = {
    top: {style: "thin"},
    left: {style: "thin"},
    bottom: {style: "thin"},
    right: {style: "thin"}
  }
  const bold = {name: "Calibri", bold: true}
  const center = {vertical: "bottom", horizontal: "center"}
  worksheet.mergeCells("A7:B7")
  worksheet.getCell("A7").alignment = center
  worksheet.getCell("A7").border = box
  worksheet.getCell("A7").font = bold
  worksheet.getCell("A7").value = "DETAILS"
  worksheet.mergeCells("A10:F10")
  worksheet.getCell("A10").alignment = center
  worksheet.getCell("A10").border = box
  worksheet.getCell("A10").font = bold
  worksheet.getRow(11).commit()
  res.setHeader("Content-Type", "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet")
  res.setHeader("Content-disposition", `attachment;filename=Reporte ${date}.xlsx`)
  workbook.commit()
})

Also getting this error

This issue is still present with<EMAIL_ADDRESS>and the latest version of Node.js.

I think I have fixed it thanks to this simple patch: https://github.com/danieleds/exceljs/commit/d5011ba46c5192942d1aa7aa6790a2a0459b54e3
I've opened a pull request at #175

I'll look at this shortly

Merged the PR. I also added an integration-test that used your example @danieleds so this regression should not happen again.
Thanks everyone!

Thank you for the wonderful project!

Since version 0.2.10, exceljs fails to write xlsx files using the stream API with the following error:
Unhandled rejection Error: append: input source must be valid Stream or Buffer instance
    at Archiver.append (/home/bugreport/backend/node_modules/archiver/lib/core.js:333:24)
    at /home/bugreport/backend/node_modules/exceljs/lib/stream/xlsx/workbook-writer.js:251:18
    at Promise._execute (/home/bugreport/backend/node_modules/bluebird/js/release/debuggability.js:272:9)
    at Promise._resolveFromExecutor (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:475:18)
    at new Promise (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:77:14)
    at Object.WorkbookWriter.addSharedStrings (/home/bugreport/backend/node_modules/exceljs/lib/stream/xlsx/workbook-writer.js:250:14)
    at /home/bugreport/backend/node_modules/exceljs/lib/stream/xlsx/workbook-writer.js:131:16
    at tryCatcher (/home/bugreport/backend/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:504:31)
    at Promise._settlePromise (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:561:18)
    at Promise._settlePromise0 (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:606:10)
    at Promise._settlePromises (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:685:18)
    at Promise._fulfill (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:630:18)
    at Promise._resolveCallback (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:447:14)
    at Promise._settlePromiseFromHandler (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:516:17)
    at Promise._settlePromise (/home/bugreport/backend/node_modules/bluebird/js/release/promise.js:561:18)

This is the code to reproduce the problem:
const fs = require('fs');
const Excel = require('exceljs');

let outStream = fs.createWriteStream('/tmp/aaa', {flags: 'w'})

let options = {
    stream: outStream,
    useStyles: true,
    useSharedStrings: true
};

let workbook = new Excel.stream.xlsx.WorkbookWriter(options);
let worksheet = workbook.addWorksheet('test');
let newrow = worksheet.addRow(['hello']);
newrow.commit();
worksheet.commit();
workbook.commit();

If you do not add any row, it works fine. Also, worked fine on 0.2.9 and previous versions.

I have the same error.


check.Rpackage command fails

When executing, I get

Running the contributed command: 'extension.checkRpackage' failed.

Without any further info. devtools::test() and devtools::load_all() work fine.

This command is actually from extension "r-check" (which I now uninstalled). Now using a custom keybinding which uses {rcmdcheck}.
The hassle of too many extensions! 😄


xtensa: fix CONFIG_NUM_IRQS if !CONFIG_*_LEVEL_INTERRUPTS

CONFIG_NUM_IRQS blindly assumes CONFIG_2ND_LEVEL_INTERRUPTS
and CONFIG_3RD_LEVEL_INTERRUPTS are always enabled together,
which is not always the case. So fix the #define.
Signed-off-by: Daniel Leung<EMAIL_ADDRESS>

FWIW: we should open a bug on this. If this is named "CONFIG_*", it's supposed to be a kconfig variable. Kconfig variables should never be defined directly in headers.
A quick grep shows that we don't declare this anywhere authoritative, it just appears in various defconfig files at the SoC level.

Those are defined in drivers/interrupt_controller/Kconfig.multilevel.

Do we need to back port this @dcpleung ?

Do we need to back port this @dcpleung ?

Yes. I just added the label.


Fix fullscreen container dimension detection when not directly on body

If the workbench is rendered in another container than the body, everything works fine except the fullscreen mode.
This PR make the layout service not rely on the parent element size in fullscreen mode as it doesn't make sense and rely on the body size instead.
I don't think it can't break anything as in the browser, the parent element is currently already the main window body

Is there an associated issue that this PR fixes?

Is there an associated issue that this PR fixes?

Not at all, it's more a code improvement than a bugfix since no issue can be reproduced in VSCode but it may impact forks and custom builds
Should I still create an issue?

But how can we hard-code a reference to document.body when the parent of the workbench might be something else? I am worried about regressions here actually, but I also do not fully understand the issue yet. If there is a repro, that would help.

But how can we hard-code a reference to document.body when the parent of the workbench might be something else?

In fullscreen mode, the parent doesn't really matter as it doesn't impact the container size at all, so it doesn't make sense to measure it to layout the container

I am worried about regressions here actually

In both cases (web.main.ts and desktop.main.ts) the given parent is mainWindow.document.body so I don't think it can actually change anything

but I also do not fully understand the issue yet. If there is a repro, that would help.

It's not simple to provide a repro
I'm integrating VSCode oss in a webpage between a header and a footer. Here's the result in fullscreen (an empty area at the bottom whose size is the height of the footer and the header combined):

Note that your change impacts not only web but also VS Code for desktop.

Indeed, I was confused by the browser directory


Update to Version 31.0.1, Rerender Graskull, Add Maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Required for https://github.com/conda-forge/vizro-feedstock/pull/11

@conda-forge-admin, please rerender

@JohanMabille - dash-ag-grid >=31.0 is a new dependency of the feedstock for vizro

https://github.com/conda-forge/vizro-feedstock/pull/11
Could you please review this PR and merge. I have updated the feedstock using Grayskull, added myself as a co-maintainer and tested locally.
Thank you and Regards.

@conda-forge/core - Can you review and merge, I can assist as a maintainer too and help keep this feedstock updated, this is a new dependency for feedstock - https://github.com/conda-forge/vizro-feedstock/pull/11.
Merging this PR will allow me to update and release the vizro feedstock.
Thanks and regards


Request: delay first alert for a few hours

When you first install the extension, it starts barking at you immediately. Adding some sort of delay might be nice (or use more relaxed default settings) to increase adoption.

Hmm so this one is tricky, because imagine this scenario:

You install the plugin about 1 hour before the end of week deadline
We don't alert you and it ends up being too late

What if we had a "snooze" button, which would silence the notification for a few minutes?

Snooze might be a worthwhile feature (if it aligns with the extension's ethos 😄) that'd solve this. Especially if that was combined with an easy way to modify settings to be more relaxed.
Suppose this scenario

You just filled in your timecard for the week, close the tab, and learn about this extension by word of mouth
You install the extension and it starts loudly screaming at you
You uninstall the extension because you don't understand what's happening, how to turn off the sound, where the snooze button is, or if a snooze button exists

If the snooze button is obvious, this might not be a problem.

Yeah I think this is gonna be partly messaging, partly snooze button. So if you click the icon, the popup should have a snooze button and text explaining why it is yelling at you.

You uninstall the extension because you don't understand what's happening, how to turn off the sound, where the snooze button is, or if a snooze button exists

This is a great point, and I think the messaging @AnthonyIacono alluded to will help out a lot with this. We are planning on adding a really simple post-install wizard to help guide you through the minimal manual steps required by the user after installing the extension. It will also provide some basic instructions that go over basic functionality and options.
We want to be careful with a snooze feature. It shouldn't be too convenient of an option that allows a user to keep putting off entering their timesheet; ultimately the purpose of the extension is to encourage the user to enter their timesheet.


feat: add hideTitle prop for map plugin

Implements: https://jira.dhis2.org/browse/DHIS2-8616
Add hideTitle=true property so maps in dashboard items don't display the title. The title is already displayed at the top of the dashboard item:

I'm confused, is this a duplicate of https://github.com/dhis2/dashboards-app/pull/718/ ? @janhenrikoverland @jenniferarnesen


Validation draft

closing without merging - as https://github.com/xmidt-org/webhook-schema/pull/16 has been merged and issues addressed here were fixed/updated in that MR


Need to update lint-staged to use next lint

instead of the direct use of eslint

oh this is a great call.

I was following this https://nextjs.org/docs/basic-features/eslint#lint-staged, and got an issue.
✖ next lint --fix --file /lint-staged.config.js --file /src/components/AppAdmin/AppAdmin.tsx:
Unknown or unexpected option: --file

NextJS 12 support --file option.

https://nextjs.org/blog/next-12#other-improvements


Subtables in pdf mode

While it works fine in docx mode, in pdf manuscript or journal mode, I have a lot of problems with generating sub-tables and sub-figures using the layout and subcap option.
Example:
#| label: tbl-demo
#| tbl-cap: 'Demo'
#| tbl-subcap:
#|   - "Subcap1"
#|   - "Subcap2"
#| layout-nrows: 2
#| apa-twocolumn: true
display(Markdown(table1.to_markdown(index = False)))
display(Markdown(table2.to_markdown(index = False)))

Something like this always generates an error, no matter how I try to display the tables (with/without using markdown, etc.).

I am surprised it works in docx. I have not yet implemented sub-tables and sub-figures in apaquarto. I am not sure when I will be able to do so. If you are anyone else has an easy solution, let me know.

Thanks for the reply. I just thought since it is supported in the “standard” quarto, it might be available here, too. Anyway, sub-figures are probably more important and are implemented, which is great. Thanks for all your work!
From: W. Joel Schneider @.>
Date: Monday, September 2, 2024 at 17:08
To: wjschne/apaquarto @.>
Cc: Nils Lang @.>, Author @.>
Subject: Re: [wjschne/apaquarto] Subtables in pdf mode (Issue #86)
I am surprised it works in docx. I have not yet implemented sub-tables and sub-figures in apaquarto. I am not sure when I will be able to do so. If you are anyone else has an easy solution, let me know.
—
Reply to this email directly, view it on GitHubhttps://github.com/wjschne/apaquarto/issues/86#issuecomment-2324955917, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BJR65BYORCOJ2SYO52FANHTZUR5QBAVCNFSM6AAAAABNQMJUUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUHE2TKOJRG4.
You are receiving this because you authored the thread.Message ID: @.***>


Distributed bench

This PR allows us to provision load generators running anywhere.
These load gens can then be used to benchmark validators.

Few other minor features:

Bulk load objects into authorities in genesis?
Genesis config objects by object id range
Optionally only provision one validator in genesis
use-move is now default

Next steps:
0. Finalize script to automate this process. Due to recent breaking config changes, the old script needs to be improved

Improve quorum logic measurement
Add utility for generating plots
Improve usage of gRPC
Add benchmarks for reads

Will have a fast follow enhancement PR to address the issues raised in this PR
Thanks guys

Looking good! Echoing with @gdanezis , we can split out benchmarking-specific stuff out of prod. Created a couple of issues to follow up


Specific authors and roles for individual notebooks

Right now, Devin and Santi are automatically stated as authors at the beginning of all pages within GitHub tutorials. We would like to be more specific regarding the authors of each notebook and roles of contributors. See: https://mystmd.org/guide/frontmatter#in-a-jupyter-notebook for how to change authors.

We could also specify roles for each author to make it clear what tasks where performed by each person.
I also suspect we could have a running list of every author in the myst.yml, set ids for each of them and then just reference them using the id in every notebook they authored (see https://mystmd.org/guide/frontmatter#in-a-jupyter-notebook). We might want to experiment with it.
BTW, we could also use ids for affiliations so we don't have to repeat them.


link to sqlblog broken?

at the home page of the repo in the top description and in the main text it says:

SQL query stress simulator created by Adam Machanic http://sqlblog.com/blogs/adam_machanic/archive/2016/01/04/sqlquerystress-the-source-code.aspx

but this link seems to be now broken

Fixed


Two cabal-version fields with verbatim.

If I'm using a verbatim block at the top level for more than just cabal-version then I end up with two such cabal-version fields when hpack renders the cabal file and cabal build fails to build the package.
> cabal build
The field "cabal-version" is specified more than once at positions _ _

See #494 for the reproduction.

@philderbeast I think the issue is that you provided cabal-version: .. within a string literal.  That way hpack has no basis to understand that it is a key/value pair.  Try this instead:
verbatim:
  - cabal-version: 3.0
  - |
    common settings
      foo
      bar
      baz

Thanks @sol. This is one instance where hpack-dhall cannot represent that mix of list elements.
-- package.dhall snippet

        , verbatim =
          [ { cabal-version = "3.0" }
          , ''
            common settings
              foo
              bar
              baz
            ''
          ]

> dhall-hpack-cabal

Error: List elements should all have the same type

- { … : … } (a record type)
+ Text

I can't help with Dhall, but conceptually you want a sum type here if Dhall supports that.

If you are already using Dhall, it might make sense to use Dhall features to DRY up your package config instead of relying on verbatim and cabal common sections.
verbatim is really just meant as a last resort escape hatch.


ADD A POMODRO TIMER WIDGET

Is this a unique feature?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.
I would like to built and add a Pomodro widget to the widget collection.
Please assign this to me.
Proposed Solution
Pomodoro timers are widely used by people who want to increase productivity by breaking tasks into manageable intervals. Integrating this as a widget in the Planner App will greatly enhance its utility, offering users a built-in time management tool alongside their daily planning.
Screenshots
No response
Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this (issue will not be assigned if this is skipped)
No response

i assigned it to you

make sure you star repo ⭐  and follow on github , giving hacktoberfest tag after this step

Thankk you, Gonna buillt it as soon as I can

#38 The Pomodro timer is done and working. Kindly look into it and merge my PR


Ecto 2 rc.4 breaks calecto

cc @lau not sure if it's something that needs to be updated in https://github.com/lau/calecto
Environment

Elixir version (elixir -v): 1.2.5
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): PostgreSQL 9.5
Ecto version (mix deps): 2.0.0-rc.4

Current behavior
I got this error after updating to ecto 2 rc4 from ecto 2 rc3
** (exit) an exception was raised:
    ** (Ecto.ChangeError) value `#Ecto.DateTime<2016-05-04 05:07:33.776539>` for `App.Group.updated_at` in `insert` does not match type Calecto.DateTimeUTC
        (ecto) lib/ecto/repo/schema.ex:610: Ecto.Repo.Schema.dump_field!/6
        (ecto) lib/ecto/repo/schema.ex:619: anonymous fn/6 in Ecto.Repo.Schema.dump_fields!/5
        (elixir) lib/enum.ex:1473: Enum."-reduce/3-lists^foldl/2-0-"/3
        (ecto) lib/ecto/repo/schema.ex:617: Ecto.Repo.Schema.dump_fields!/5
        (ecto) lib/ecto/repo/schema.ex:567: Ecto.Repo.Schema.dump_changes!/6
        (ecto) lib/ecto/repo/schema.ex:182: anonymous fn/11 in Ecto.Repo.Schema.do_insert/4
        (ecto) lib/ecto/repo/schema.ex:595: anonymous fn/3 in Ecto.Repo.Schema.wrap_in_transaction/6
        (db_connection) lib/db_connection.ex:1164: DBConnection.transaction_nested/2
        (db_connection) lib/db_connection.ex:1030: DBConnection.transaction_meter/3
        (db_connection) lib/db_connection.ex:766: DBConnection.transaction/3
        (ecto) lib/ecto/multi.ex:374: Ecto.Multi.apply_operation/4
        (elixir) lib/enum.ex:1473: Enum."-reduce/3-lists^foldl/2-0-"/3
        (ecto) lib/ecto/adapters/sql.ex:462: anonymous fn/3 in Ecto.Adapters.SQL.do_transaction/3
        (db_connection) lib/db_connection.ex:1079: DBConnection.transaction_run/4
        (db_connection) lib/db_connection.ex:1009: DBConnection.run_begin/3
        (db_connection) lib/db_connection.ex:766: DBConnection.transaction/3
        (ecto) lib/ecto/repo/queryable.ex:27: Ecto.Repo.Queryable.transaction/4
        (app) web/controllers/api/v1/group_controller.ex:12: App.API.V1.GroupController.create/2
        (app) web/controllers/api/v1/group_controller.ex:1: App.API.V1.GroupController.action/2
        (app) web/controllers/api/v1/group_controller.ex:1: App.API.V1.GroupController.phoenix_controller_pipeline/2

Expected behavior
inserted_at and updated_at should work as previously did.

That's a great catch, thank you @princemaple.
@lau or @princemaple, do you have an easy way to reproduce this issue? If so, I will investigate it straight-away. :)

As you can tell, I'm working on a Phoenix app.
Per calecto documentation, I have this in my web.ex
  def model do
    quote do
      use Ecto.Schema
      use Calecto.Schema, usec: true # notice this

      alias Ecto.Multi
      import Ecto
      import Ecto.Changeset
      import Ecto.Query
    end
  end

This should be enough to reproduce the problem, in any phoenix app, for any model that contains timestamps. I got the error as soon as I wanted to create (Repo.insert) something.

Ok, I know why this is happening.
@lau, the latest RC changed Ecto's autogenerate to return the type (i.e. Ecto.DateTime) instead of a tuple (i.e. {date, time}). That's why your datetime implementation is receiving Ecto.DateTime in dump. We have two options to fix this:

We change Ecto to call autogenerate also on your type and you would implement the logic similar to this: https://github.com/elixir-lang/ecto/blob/master/lib/ecto/date_time.ex#L578

You change Calecto to be able to dump Ecto.DateTime

My preference is 2 because, even though it is a workaround for now, it will be completely removed once we standardize on the same types.
Furthermore, how do you foresee this working in the future with Elixir 1.3 types? Would the DateTimeUTC become NaiveDateTime?

I'm for the option 1. For any field that supports autogenerate option a similar mechanism is used - the type is expected to expose an autogenerate/0 function returning the type's value. Why would timestamps be different?

@michalmuskala because there are implementation details there (like passing usec) that I don't think we should expose yet. I am also quite sure that all of this won't matter once we depend on Elixir v1.3 calendar types.

Why would the general case change because of the built-in calendar types? I'm not sure I understand.
I'd rather generalize the solution, than further special case it.
Another option is to always have autogenerate/1 instead of autogenerate/0. In this set-up passing autogenerate: opts to a field would call autogenerate(opts) on the type.
We could keep autogenerate: true calling autogenerate/0 in order to keep backwards-compatibility.
Do we know of any other use cases for autogenerate besides timestamps? Do we need to worry about that?

I'd rather generalize the solution, than further special case it.

That's exactly what I am trying to avoid. Passing :usec or not is an implementation detail to how timestamps work and I don't want to have others relying on it. Both solutions will require special casing.
My plan was to generalize autogenerate so you can pass {m, f, a}. I don't think passing opts is enough, specially in the future where the default time will likely be :datetime or something of sorts. So maybe we should just allow this to be set now.

So I have this patch:
diff --git a/lib/ecto/schema.ex b/lib/ecto/schema.ex
index 78b320f..ac5840a 100644
--- a/lib/ecto/schema.ex
+++ b/lib/ecto/schema.ex
@@ -428,6 +428,8 @@ defmodule Ecto.Schema do
       Microseconds will be 0 if false. Defaults to false.
     * `:inserted_at` - the name of the column for insertion times or `false`
     * `:updated_at` - the name of the column for update times or `false`
+    * `:autogenerate` - a module-function-arity tuple used for generating
+      both insert and update at timestamps

   All options can be pre-configured by setting `@timestamps_opts`.
   """
@@ -439,24 +441,22 @@ defmodule Ecto.Schema do
         |> Keyword.merge(@timestamps_opts)
         |> Keyword.merge(opts)

-      type = Keyword.fetch!(timestamps, :type)
-      autogen = if Keyword.fetch!(timestamps, :usec), do: [:usec], else: []
+      type    = Keyword.fetch!(timestamps, :type)
+      args    = if Keyword.fetch!(timestamps, :usec), do: [:usec], else: [:sec]
+      autogen = timestamps[:autogenerate] || {Ecto.DateTime, :autogenerate, args}

       # TODO: Revisit and expose autogenerate when Elixir's 1.3
       # calendar types are introduced .

       if inserted_at = Keyword.fetch!(timestamps, :inserted_at) do
         Ecto.Schema.field(inserted_at, type, [])
-        Module.put_attribute(__MODULE__, :ecto_autogenerate,
-            {inserted_at, {Ecto.DateTime, :autogenerate, autogen}})
+        Module.put_attribute(__MODULE__, :ecto_autogenerate, {inserted_at, autogen})
       end

       if updated_at = Keyword.fetch!(timestamps, :updated_at) do
         Ecto.Schema.field(updated_at, type, [])
-        Module.put_attribute(__MODULE__, :ecto_autogenerate,
-            {updated_at, {Ecto.DateTime, :autogenerate, autogen}})
-        Module.put_attribute(__MODULE__, :ecto_autoupdate,
-            {updated_at, {Ecto.DateTime, :autogenerate, autogen}})
+        Module.put_attribute(__MODULE__, :ecto_autogenerate, {updated_at, autogen})
+        Module.put_attribute(__MODULE__, :ecto_autoupdate, {updated_at, autogen})
       end
     end
   end

This way calecto will be able to set :autogenerate as an option and it will call whatever it wants to.

I have merged support for autogenerate because someone has just asked for this feature in the mailing list as well. As long as calecto passes autogenerate: {m, f, [args]} to @timestamp_opts, we should be golden.

Cool, I will implement the autogenerate functionality then.

Furthermore, how do you foresee this working in the future with Elixir 1.3 types? Would the DateTimeUTC become NaiveDateTime?

It would be almost the same as today. The 1.3 types and Calendar types are almost the same. I have copied a table from the readme from Calecto: https://github.com/lau/calecto (under the heading The Types).

Primitive type
Ecto schema type
Equivalent Calendar type

Used in migrations
Used in schemas
Type returned from db

:date
Calecto.Date
Calendar.Date

:time
Calecto.Time
Calendar.Time

:datetime
Calecto.DateTimeUTC
Calendar.DateTime

:datetime
Calecto.NaiveDateTime
Calendar.NaiveDateTime

:calendar_datetime
Calecto.DateTime*
Calendar.DateTime

In a future Calecto version that supports only Elixir 1.3+, the last column would simply lack Calendar. from the type names and instead use the Elixir 1.3 types.
Note that there is no DateTimeUTC type in Calendar - it is specific to Calecto.
Calecto.DateTimeUTC works with Calendar.DateTime structs today.
So why does the Calecto.DateTimeUTC exist? Why not just use a NaiveDateTime? Because then we lose the valuable information about the timestamps being in UTC. In a DateTime it is explicit. We already know that all the inserted_at and updated_at timestamps are in UTC. Imagine if Logger had DateTimes in the future - then you could compare a DateTime from Logger to an inserted_at DateTime from Ecto to see which happened first. And because the time zone information is preserved you can tell which happened first. Without making assumptions about the timezone.
There are two different Calecto types that can store DateTimes. One is Calecto.DateTimeUTC and the other is the currently postgres specific Calecto.DateTime.

Very helpful, thank you @lau.

@josevalim Thank you for making a solution so quickly. I have pushed a new version of Calecto with this change (https://github.com/lau/calecto/commit/f6bcd248f0f5bf7eb4dd2410524441372c0bed67). Tested it against 2.0.0-rc4 with you patch applied and it worked.
Will your new code come out in a 2.0.0-rc5 version?

@lau surely, I will release a -rc5 later today.

OK

I forgot to release it. :P I will try to do it tomorrow. :)


Add dockershim to the Glossary

Not a 1.24 blocker.
Original discussion on Slack.
Add dockershim to the Kubernetes glossary.
Proposed content
dockershim
A component present in Kubernetes version 1.23 and earlier that allowed Docker Engine to communicate with Kubernetes system components like the kubelet. The dockershim was removed in v1.24. For more information, read the Dockershim FAQs.
/sig docs
/language en
/cc @sftim
/assign

/triage accepted
Thanks @shannonxtreme
/help

/assign


Feature/player select

Some large changes made in order to merge, but successful still.

added player selection, name validation to come but I left it as is for testing purposes
some modifications to the game page
moved script tags to index.html

Gonna close this one out and start on a new branch...


feat: Added PyMuPDF loader for PDF files

This PDF loader is the fastest among all other PDF parsing options and text extraction from PDF files. The logic of this pdf loader is to extract the text and also extract basic metadata (if needed) such as page number, total number of pages in pdf file and also file path.

there's some test failures unrelated to this PR, we can help fix

there's some test failures unrelated to this PR, we can help fix

@jerryjliu  - Thanks, please let me know if any modifications need to be done from my end.


Initial patch for state transition (Do not merge)

This is the first part of the patch.

It will make the complete status without checking LogCollect and CleanUp tasks
workload summary will be only created all the subscription is finished
request will be moved to archived status only after LogCollect and CleanUp tasks are finished.

I will create the second patch separately which will do following.

update LogCollect and CleanUp task status to the  central couchdb (reqmgr2 db) by agent
update db clean status  to the  central couchdb (reqmgr2 db) by agent (for moving to archived status)
create the cherrypy thread which collects all the status information from agent and update reqmgr2 db request status. (including archived status)

@amaltaro, Alan please review. We can discuss in detail tomorrow. Thanks,

Refactor the code  move all archive and clean up code to CleanCouchPoller.  Still could have race condition if the couchdb clean up failed for some reason and retried. Had to rewrite the sql.
@amaltaro, Alan, please review. I will fix the unittest and some of pylint warnings.

Seangchan, I noticed the workloadSummary will only be updated when all tasks are done (including logCollect and cleanUp), and the workflow will stay in the same completed status, right? So, this one will be tricky to identify (besides checking...) when the workloadSummary is available or not.
About TaskArchiver thread, it will basically a) mark subscriptions as Done; b) populate the DataCache with 100% completed workflows; c) change workflows to a completed status and d) mark WQE as Done
The CleanCouch thread will a) change workflow status to a final archived status; b) clean up local couch (central couch cleans by itself?) c) clean up wmbs and dbsbuffer tables; d) upload workload summary and e) calculate and upload a bunch of performance data.
It seems to me there are a lot of stuff we could remove from this code (maybe even some of those dashboard reports/performance). It's worth revisit it in the near future :-)
I didn't spot any issues, though it's easy to review it. Let's put it in an agent and fullly validate in the coming weeks.


Add option to include pre bundle deps in the application builder

Command
build, serve
Description
In https://github.com/angular/angular-cli/pull/27021 an option to exclude dependencies from being pre bundled was added.
If we are trying to exclude a dependency that has nested common js dependencies, those should be pre bundled as stated in https://vitejs.dev/config/dep-optimization-options.html#optimizedeps-exclude.
Describe the solution you'd like
Expose an option for including dependencies to be pre bundled similar to exclude option.
Describe alternatives you've considered
No response

That statement from the Vite documentation doesn't apply to the Angular CLI's build system. With Angular, anything excluded from the prebundling will be bundled into the application code itself.  The module format is automatically handled by the underlying bundler (esbuild in this case).

@clydin thanks for the explanation. I still have a doubt, how should I proceeded with the nested dependencies of a dependency? Should I also exclude them then?

Can you provide the content of those warnings?

When I added a package to the exclude list, it gave me a warming for the nested commonjs dependencies saying the name of the dependency and that it could not be resolved and I was getting a error at runtime saying that it was not able to load chunk "X". I ended up adding also those libs to the exclude list and the problems went away. I can't remember what else I did and I can't reproduce it now so I must have done something wrong.
On a off topic, it would be cool to support globs in the exclude list.


change r/w rqmt of StaticNameServers

Make StaticNameServers mandatory read/write. Fix for Issue #37

Read and write should both be recommended.


Handle missing graph data gracefully

Fixes two errors when you have missing graph data:

TypeError: unsupported operand type(s) for *: 'int' and 'NoneType'

Uncaught ReferenceError: None is not defined

We can't calculate mAP for Epoch 0 since there's not a snapshot yet.

The code looks OK to me. I haven't used it for the mAP PR (https://github.com/lukeyeager/DIGITS/pull/1) as I added a separate network output type for asynchronous outputs.


Getting request Permission denied: no further information on Service Discovery with Spring-Cloud-Config

I am trying to connect to the spring cloud config server via a eureka registered serviceId.
My Spring cloud config server is up and running , and my client can connect to it via local host.
The Eureka server is up and running, and my spring config server is registered.
HP-FETCHER-CONFIG-SERVICE | n/a (1) | (1) | UP (1) - <IP_ADDRESS>:hp-fetcher-config-service:8086
I have a application  that is a eureka client, but I also want it to load config from the config server using the HP-FETCHER-CONFIG-SERVICE serviceId.
This is my clients application.yml
application.txt
it has
spring.cloud.config.discovery.enabled: true
spring.cloud.config.discovery.serviceId: HP-FETCHER-CONFIG-SERVICE
I am using java 16
spring-boot-starter-parent 2.5.3
org.springframework.cloud 2020.0.3.
Getting the following exception
Exception.txt
It can see but cant connect permision denied
GET request for "http://<IP_ADDRESS>:8086/hp-fetcher-htmlunit/local": Permission denied: no further information; nested exception is java.net.SocketException: Permission denied: no further information

Do you have spring security enabled for that endpoint on the config server?

No I dont, this is my application.yml file for the config server, I am using S3 as a repo
application.txt
.

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

Ok I will try and sort that out, but can you tell me what the exception is saying. Why its not allowing me to connect. Especailly since its the correct URL.

Permission denied makes me think it's a security issue, hence why I am asking about spring security

But I dont have spring security set.

It just needs to be on the class path.  If it's not then I am not sure, hence why I am asking for a sample to reproduce so I can take a look

hp-fetcher-htmlunit.zip
The client

I need the server too

hp-fetcher-config-service.zip

EurekaServer.zip

Its when I try  to use the ServiceId that it gets connection refused

Is that the right ip and port for the config server?  If you use the same ip and port and don't use discovery first configuration does it work?

Not sure what you mean in my eureka disvovery its
This works :
cloud:
config:
enabled: true
uri: http://localhost:8086
HP-FETCHER-CONFIG-SERVICE | n/a (1) | (1) | UP (1) - <IP_ADDRESS>:hp-fetcher-config-service:8086
cloud:
config:
enabled: true
#uri: http://localhost:8086
discovery:
enabled: true
serviceId: HP-FETCHER-CONFIG-SERVICE
The exception states
Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:8888/hp-fetcher-htmlunit/local": Connection refused: no further.
I have no idea why its ignoring the service Id and defaulting to ttp://localhost:8888/hp-fetcher-htmlunit/local.

I bet there is another property I have to set that says use the Service Id

Something with the discovery first configuration is not right, localhost:8888 is what the client defaults to when a uri is not specified or the discovery server is not being used.

Is the problem with the discovery service or the client. Does Eureka server need a property to say that the spring cloud config server will be using it

I think this is the problem
spring.config.import=configserver I just copied this. is it supposed to be config server , or the name of my config server application

See the warning at the top of this section
https://docs.spring.io/spring-cloud-config/docs/3.0.5/reference/html/#discovery-first-bootstrap

Found the problem or a problem. I am using awss3 and according to the documentation  I need to set it as awss3 So in my config server application.yml I set awss3,
So this works
spring:
profiles:
active:
awss3
application:
name: HP-FETCHER-CONFIG-SERVICE
cloud:
config:
server:
awss3:
bucket: hp-fetcher-config
region: us-west-2
order: 1
But I need to have two profiles awss3,local, or awss3,dev or awss3, qa, or awss3, prod
So when I have
spring:
profiles:
active:
awss3, local.
My client cant find the config service , I have no idea why this happening, since with or without

Found the issue, can we close this issue and open a new one


Removed newlines at the end of razor comments

Issue - #428
This does not include the fix for the issue mentioned here https://github.com/aspnet/Razor/issues/428#issuecomment-123868426.
Will add and update tests once the design is finalized.
@NTaylorMullen @dougbu

:watch:

Updated.

Design looks good. Ensure that this works (pretty sure it will, but want to double check):
<p>
  @* Hello *@    @* World *@
</p>

Just to note, you may want to label this PR as part 1/X where X is how many parts you want to take to apply the same niceness to other block level elements in Razor :smile:

:watch:

Updated.

Very close

:watch: for extra test (https://github.com/aspnet/Razor/pull/482#discussion_r36941987)

Updated.

:shipit:

:shipit: if we decide to change things related to my new question, can be done later.


Subscription and chargeback of OpenStack projects

OSCM Use Case
I'm running an OpenStack environment as internal IT service provider. My customers are departments of my company or partner companies. OSCM shall be the portal to deliver OpenStack services to these customers. The main use cases are to let customers subscribe to OpenStack services and to let me show-back costs to these customers dependent on their resource consumption. OpenStack services are VMs, network and storage.
Desired Functionality
In OSCM the customer shall be able to create one or more OpenStack projects (tenants). On subscription he shall define

define one or more OpenStack horizon users with rights to manage resources in the new created project
quotas of the project

In OSCM the customer shall be able to increase the quota of his subscribed OpenStack projects (tenants).
The price of the subscribed projects shall be calculated on the real usage of the project:  VCPU-Hours, GB-Hours, RAM-Hours.
The usage data shall be updated on daily basis.
Potential solution
Codebase could be the existing OSCM-APP controller. Add new service type "OpenStack tenant". Subscription parameters would be

Domain name
project name
openstack user1
openstack user2
openstack user3
openstack user4
number of

Metadata Items
VCPUs
Instances
Injected Files
Injected File Content (Bytes)
Volumes
Volume Snapshots
Total Size of Volumes and Snapshots (GiB)
RAM (MB)
Security Groups
Security Group Rules
Floating IPs
Networks
Ports
Routers
Subnets

Events types could be VCPU-Hours, GB-Hours, RAM-Hours
The connector would use the existing OpenStack APIs to create / update the OpenStack project. A collector could run daily to retrieve the Ceilometer data for the OpenStack and to create the corresponding OSCM events.

This issue was moved to servicecatalog/oscm#93


Error

ImportError: cannot import name 'PreTrainedBertModel'

Please install necessary packages with the correct version as specified.

It's solved! But error with
AttributeError: module 'torch.distributed' has no attribute 'is_initialized'
conda list:
torch==1.0.1

Please check the issue about Pytorch.


Add nice not found page

I think we could change this site to something like:
'''
It doesn't exist - yet!


fix react unknown prop warning

fixes react unknown prop warning, #42. use delete instead variable creating, #43.

reference for reasoning for this PR - https://github.com/JedWatson/react-tappable/blob/master/src/getComponent.js#L45


feat: implement the converter for Entity in Java

Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[ ] tests are included
[ ] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
This PR adds the implementation of Entity converter written in Java.
Here is the list of changes:

Adding a named query in Entity.scala.
Creating Service and DAO layers for Entity.
Creating the converter to support import/export of Entity.
Dropping the previous implementation.

I noticed the format of JSON files created from previous implementation is much better. I wonder how important is the format.
new

old

I tested locally by adding a Cloud Provider and then importing, exporting and deleting the institution.

After changing the type of data to JsonNode the output is correct and looks better.


ISSUE-173 Changed way to add .ssh dir to get rid of bad owner permissions

what

The way the .ssh dir is mounted into the container was changed from

mount ~/.ssh -> ~/.ssh

to:

mount ~/.ssh -> /tmp/.ssh
cp -r /tmp/.ssh ~/
chown to container user and chmod to 600

why

If the .ssh files are owned by other than the current container user, or the config file has permissions other than 600 the bad owner permissions issue is got.

references

solves https://github.com/binbashar/leverage/issues/173

Before release

Review the checklist here

IMPORTANT: do not merge this PR without documentation stating this new procedure


symbol code showing in korean

Microsoft PowerToys version
0.37.0
Utility with translation issue
Shortcut Guide
🌐 Language affected
Korean
❌ Actual phrase(s)
<Windows> 키를 누를 때 Windows 바로 가기와 함께 도움말 오버레이를 표시합니다.
✔ Expected phrase(s)
<Windows> 키를 누를 때 Windows 바로 가기와 함께 도움말 오버레이를 표시합니다.
ℹ Why is the current translation wrong
code value of symbol is apprearing

Are you sure? This should be fixed in 0.37

See: https://github.com/microsoft/PowerToys/issues/10536#issuecomment-829647887

Are you sure? This should be fixed in 0.37

Yes I'm using 0.37

https://dev.azure.com/GlobalCollaborationService/Global Collaboration Service Project/_workitems/edit/92407

Fixed with https://github.com/microsoft/PowerToys/pull/11891

Resolved.


Step 8 contains a broken link

The link for the "Espresso-Intents" documentation is broken.
broken link: https://google.github.io/android-testing-support-library/docs/espresso/intents/index.html

It still is.

Closing as the Espresso Intents section was removed in the latest update


Android Build not completing when including shaderRetention in build

Shader error in 'GLTF/PbrMetallicRoughness': '' : 'UNITY_STANDARD_SIMPLE' already defined at /Program Files/Unity/Editor/Data/CGIncludes/UnityStandardCoreForward.cginc(6) (on gles)
I am using latest version of unitygltf and also I have tested all possible solution in issues regarding to this problem in unity

What version of unity is this with? It works for me in 5.6, albeit slowly.

I am using 2017.3.0f3

Also affected by this. Can't build and run to Android. I'm on Unity 2017.4.0f1

Also affected by this. Can't build and run to Android. I'm on Unity 2017.4.0f1

OK I just barely figured out how to fix this issue the right way. (It looks like it's a bug in some core Unity includes.)
First, create a new file called UnityGltfStandardCoreForward.cginc and paste in the following code:
#ifndef UNITY_STANDARD_CORE_FORWARD_INCLUDED
#define UNITY_STANDARD_CORE_FORWARD_INCLUDED

#include "UnityStandardConfig.cginc"

#if UNITY_STANDARD_SIMPLE
    #include "UnityStandardCoreForwardSimple.cginc"
    VertexOutputBaseSimple vertBase (VertexInput v) { return vertForwardBaseSimple(v); }
    VertexOutputForwardAddSimple vertAdd (VertexInput v) { return vertForwardAddSimple(v); }
    half4 fragBase (VertexOutputBaseSimple i) : SV_Target { return fragForwardBaseSimpleInternal(i); }
    half4 fragAdd (VertexOutputForwardAddSimple i) : SV_Target { return fragForwardAddSimpleInternal(i); }
#else
    #include "UnityStandardCore.cginc"
    VertexOutputForwardBase vertBase (VertexInput v) { return vertForwardBase(v); }
    VertexOutputForwardAdd vertAdd (VertexInput v) { return vertForwardAdd(v); }
    half4 fragBase (VertexOutputForwardBase i) : SV_Target { return fragForwardBaseInternal(i); }
    half4 fragAdd (VertexOutputForwardAdd i) : SV_Target { return fragForwardAddInternal(i); }
#endif

#endif // UNITY_STANDARD_CORE_FORWARD_INCLUDED

Then, in the PbrSpecularGlossiness.shader and PbrMetallicRoughness.shader files, replace all
#include "UnityStandardCoreForward.cginc"

with
#include "UnityGltfStandardCoreForward.cginc"

Let me know if this works for you guys.

Is there a workaround for 2018.2?

Hello Guys,
Hope so you are fine and keeping well. Attached is the log of unity android build and these two shaders are taking most of the size in the app.
"58.9 mb	 8.3% Assets/UnityGLTF/Shaders/PbrSpecularGlossiness.shader
55.7 mb	 7.9% Assets/UnityGLTF/Shaders/PbrMetallicRoughness.shader"
When I don't add them in the android build the build doesn't work so I have added them and now it has increased the size. Can please anyone help me @stevenvergenz


xterm right-click context menu is shown only once

After the first time the right-click context menu in xterm has been displayed, any future invocation has no visible effect.

This might be a dupe of #104 and SirCmpwn/sway#571

The menu doesn't appear only once anymore, but it's janky and doesn't seem to draw borders correctly. I can enter and leave the context menu repeatedly. Does this mean it has been fixed?


PV-350: Update parking permit history

Description
Add new columns in parking permit history. Add support for the new parking permit event model. Not my best work, please pay attention to the code you're reviewing.
Context
PV-350
How Has This Been Tested?
Some very little manual testing.
Manual Testing Instructions for Reviewers
See if events created in the back-end end up in the permit detail page.
Screenshots

Has some missing stuff, but works otherwise. Merging this and filling out the blanks in a later PR.


Revert gh2516

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fixes https://github.com/conda-forge/openblas-feedstock/issues/101

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi,
For me it did not fix #101 :
(pgt_test_3.6) [ldelisle@SV-49-002 pyGenomeTracks]$ python
Python 3.6.10 | packaged by conda-forge | (default, Apr 24 2020, 16:44:11)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy as np
>>> t = np.array([[1, 0.5], [-1, 0.5]])
>>> matrix_a = np.dot([(1,2) for i in range(1000000)], t)
Segmentation fault (core dumped)
(pgt_test_3.6) [ldelisle@SV-49-002 pyGenomeTracks]$ conda list | grep libopenblas
libopenblas               0.3.10          pthreads_hb3c22a3_3    conda-forge

Same with openmp:
(pgt_test_3.6) [ldelisle@SV-49-002 pyGenomeTracks]$ conda install libopenblas=*=*openmp*
Collecting package metadata (current_repodata.json): done
Solving environment: done

## Package Plan ##

  environment location: /home/ldelisle/.conda/envs/pgt_test_3.6

  added / updated specs:
    - libopenblas[build=*openmp*]

The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    libopenblas-0.3.10         |openmp_h709eae2_3         7.8 MB  conda-forge
    ------------------------------------------------------------
                                           Total:         7.8 MB

The following packages will be DOWNGRADED:

  libopenblas                    0.3.10-pthreads_hb3c22a3_3 --> 0.3.10-openmp_h709eae2_3

Proceed ([y]/n)? y

Downloading and Extracting Packages
libopenblas-0.3.10   | 7.8 MB    | ###################### | 100%
Preparing transaction: done
Verifying transaction: done
Executing transaction: done
(pgt_test_3.6) [ldelisle@SV-49-002 pyGenomeTracks]$ pythonPython 3.6.10 | packaged by conda-forge | (default, Apr 24 2020, 16:44:11)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy as np
>>> t = np.array([[1, 0.5], [-1, 0.5]])
>>> matrix_a = np.dot([(1,2) for i in range(10000000)], t)
Segmentation fault (core dumped)
(pgt_test_3.6) [ldelisle@SV-49-002 pyGenomeTracks]$


Sort lines broken

Issue Type: Bug
Using the built-in line sorting, I have a sample case where the lines sort incorrectly. Below is a list of lines sorted how VSCode sorted them (which is wrong). You can put them into Sublime Text and it will sort them correctly.

We are using the locale comparator, did you perhaps customize your OS locale to one where the sorting rules are different than EN-US ?

We are using the locale comparator,

Looks like you found the bug already. ;)

I am not convinced that is a bug. The locale comparator can correctly sort "s" and "ș" next to each other if the locale is Romanian or "u" and "ü" next to each other if the locale is German. So IMHO using the locale comparator is correct.

OK. Pretty sure I know what the issue is (PEBCAK, although I think I'd argue for UX being partly to blame :smile:).
I was completely unaware that there was a need to select all the lines to be sorted before using the command. The text was already mostly sorted, so I didn't actually notice it not sorting on command until a few minutes ago when I attempted to make a test and noticed the sort command doing nothing.
Feel free to close this bug as a non-issue, but - personally - I'd recommend having sort lines either work on the entire file when nothing is selected or at least notify the user that nothing was sorted since nothing was selected.
Thanks for taking the time to double check this, though.

So IMHO using the locale comparator is correct.

What locale would it use though?
AFAIK a project (or file) doesn't have a locale.. and Code is a code editor. Would it really make sense to use the locale of the developer's machine?


Typo

Just a typo @bobbyiliev

Good catch! Thanks for the pull request 🙌

No worries, happy to help out! Great idea!