AT+CIPSTART wrong format for SSL

Hello @MaJerle ,
I was trying to enable the SSL and it seems there is some issue with the AT cmd for SSL.
This is the snipet from my actual log files using lastest release source.
AT+CIPSSL=1
AT+CIPSSL=1
OK
AT+CIPSTART=5,"device.connectivity-suite.cloud",443
AT+CIPSTART=5,"device.connectivity-suite.cloud",443
+CME ERROR: 3
According to the AT cmd document from SIMCOM for SIM800 series command format is as follows.
AT+CIPSSL=1
OK
AT+CIPSTART=1,"TCP","<IP_ADDRESS>","9600"
OK
1,CONNECT OK
I think you are missing "TCP" in your format and dobule quote in the port
Can you please let me know how can i patch these in my code. I am actually stuck in the middle of my workflow due to this.
I am looking forward for your reply.
Thank and Regards,
Samir

Hello @MaJerle,
Just for your reference, to do a quick fix i modified the code as follows in lwgsm_int.c Line no 1948 as follows
        AT_PORT_SEND_CONST_STR("+CIPSTART=");
        lwgsmi_send_number(LWGSM_U32(c->num), 0, 0);
        if (msg->msg.conn_start.type == LWGSM_CONN_TYPE_TCP) {
            lwgsmi_send_string("TCP", 0, 1, 1);
            lwgsmi_send_string(msg->msg.conn_start.host, 0, 1, 1);
            lwgsmi_send_port(msg->msg.conn_start.port, 0, 1);
        } else if (msg->msg.conn_start.type == LWGSM_CONN_TYPE_UDP) {
            lwgsmi_send_string("UDP", 0, 1, 1);
            lwgsmi_send_string(msg->msg.conn_start.host, 0, 1, 1);
            lwgsmi_send_port(msg->msg.conn_start.port, 0, 1);
        } else{
            lwgsmi_send_string("TCP", 0, 1, 1);
            lwgsmi_send_string(msg->msg.conn_start.host, 0, 1, 1);
            lwgsmi_send_port(msg->msg.conn_start.port, 1, 1);
        }
        AT_PORT_SEND_END_AT();

It simply add the changes when the SSL is set and remain same duting others.
Please let me know your feedback.
Thanks And Regards,
Samir

Yes this is because SSL was not considered


Draft try to address issue 2015

potential fix for #2015

Possible to add a test?

Possible to add a test?

Sure, I will add some tests here.


Serial crash when trying to boot t6000 dev kernel with hypervisor

I am currently trying to boot my MBP 14 Pro (target) from my M1 Mini (proxy) using the KDK Version 12.3 (21E230) & the following command sequence:
export M1N1DEVICE=/dev/cu.usbmodemP_01
./proxyclient/tools/chainload.py -r build/m1n1.bin
python3 proxyclient/tools/run_guest.py -S -m hv/trace_all.py -s ../macOS.kernel/t6000.21E230.DWARF ../macOS.kernel/dev.kc.macho.development -- "cpus=1 debug=0x14e serial=3 apcie=0xffffffef -enable-kprintf-spam wdt=-1"

The kernel starts to boot but after a few seconds it crashes with the following output (and the MBP rebooting):
[cpu0][0xfffffe00138efd28] MMIO: W.4   0x291e6f0ec (unknown, offset 0x291e6f0ec) = 0x0
[cpu0][0xfffffe001460e688] MMIO: R.4   0x2920a1300 (nub-spmi0[0], offset 0x00) = 0x1000100
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.9/site-packages/serial/serialposix.py", line 575, in read
    buf = os.read(self.fd, size - len(read))
OSError: [Errno 6] Device not configured

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 90, in runcode
    exec(code, self.locals)
  File "<console>", line 1, in <module>
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/shell.py", line 129, in display
    val()
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/hv.py", line 1440, in start
    self.p.hv_start(self.entry, self.guest_base + self.bootargs_off)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 975, in hv_start
    return self.request(self.P_HV_START, entry, *args)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 643, in request
    return self._request(opcode, *args2, **kwargs)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 609, in _request
    reply = self.iface.proxyreq(req, reboot=reboot, no_reply=no_reply, pre_reply=None)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 356, in proxyreq
    return self.reply(self.REQ_PROXY)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 230, in reply
    reply += self.readfull(1)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 167, in readfull
    block = self.dev.read(size - len(d))
  File "/opt/homebrew/lib/python3.9/site-packages/serial/serialposix.py", line 581, in read
    raise SerialException('read failed: {}'.format(e))
serial.serialutil.SerialException: read failed: [Errno 6] Device not configured

Things I have tried:

Increasing CPU to cpu=2+ but I get this instead:

[cpu1][0xfffffe0013e3ecec] MMIO: R.1   0x59020000e (apcie[0], offset 0x20000e) = 0x80
Event checksum error: Expected 0x00150100, got 0xd0decade
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 90, in runcode
    exec(code, self.locals)
  File "<console>", line 1, in <module>
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/shell.py", line 129, in display
    val()
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/hv.py", line 1440, in start
    self.p.hv_start(self.entry, self.guest_base + self.bootargs_off)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 978, in hv_start
    return self.request(self.P_HV_START, entry, *args)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 646, in request
    return self._request(opcode, *args2, **kwargs)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 612, in _request
    reply = self.iface.proxyreq(req, reboot=reboot, no_reply=no_reply, pre_reply=None)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 359, in proxyreq
    return self.reply(self.REQ_PROXY)
  File "/Users/robin/Developer/m1n1/proxyclient/m1n1/proxy.py", line 259, in reply
    raise UartChecksumError()
m1n1.proxy.UartChecksumError

Increasing iface.dev.timeout = 1 in proxy.py (no change).
Using trace_pmgr.py instead of trace_all.py (no change).
Setting the baud to 256000 using export M1N1DEVICE=/dev/cu.usbmodemP_01:256000 (no change)

That means the guest is panicking and rebooting the machine. The hypervisor makes no attempt to stop the guest from doing that; it is a thin layer, not a security boundary. So if the guest kills the machine, the hypervisor goes along with it.
You should look at the serial log from macOS (available on the secondary USB ACM interface) to figure out why it's doing that.
Are you perhaps trying to boot macOS from a m1n1 proxy installed via the Asahi Linux installer? That won't work - to boot macOS you need to be running the OS volume macOS was installed under, which means you need to install m1n1 with kmutil/bputil on top of an existing macOS install. If you try to boot the macOS kernel under an Asahi Linux volume it'll just panic when it can't mount the root filesystem.

Yes, you caught me red handed, and now that you have explained it - it makes more sense. I will ask some more questions on irc about installing a 2nd macOS Volume (avoiding touching my original macOS install for now) and will attempt to update the wiki so others don't follow my folly. Thanks for your quick reply.


Request to add my highschool to jetbrains

This is the highschool's website: http://cnogsibiu.ro

@Steopei-Cristian Thank you for your patience while waiting for a review and processing your request. Pull request merged.


zrythm: don't strip

Motivation for this change
Requested by upstream: https://github.com/NixOS/nixpkgs/issues/150403
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 150404 run on x86_64-linux 1

1 package built:

zrythm


Fix/csi 507 syncloadorstore

This PR fix thread save issue Lou found in ticket CSI-507.
Using LoadOrStorage instead of Load and then Store. And also just use Delete instead of Load and then Delete.

This change is

Run CI sanity of this PR to make sure it works ok.

node/pkg/driver/sync_lock.go, line 64 at r3 (raw file):

	logger.Debugf("Lock for action %s, release lock for volume", msg)

	s.SyncMap.Delete(id)

Will it not fail if id is not in map?

node/pkg/driver/sync_lock.go, line 60 at r3 (raw file):

	} else {
		logger.Debugf("Lock for action %s, Lock for volume ID=%s is already in use by other thread. goid=%d", msg, id, goid)
		return &VolumeAlreadyProcessingError{id}

I already removed log goid/volid from log messages and line goid := util.GetGoID()


build: add detect-secrets stage to build

:tada: This PR is included in version 3.20.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.20.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Handler for message in IMAP queue failed with KeyError

Can you please help me understand this error? I am using Microsoft exchange online and thus dkim_domain='mydomainorg.onmicrosoft.com' appears. It seems there is an issue with that. I've setup DKIM as described by Microsoft here: Use DKIM to validate outbound email sent from your custom domain.
Have I done something wrong or is there improvement in the dmarc-metrics-exporter required?
Handler for message in IMAP queue failed.,
Traceback (most recent call last):,
  File "/home/dmarc-metrics/.local/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 61, in _consume,
  File "/home/dmarc-metrics/.local/lib/python3.7/site-packages/dmarc_metrics_exporter/app.py", line 94, in process_email,
    await handler(msg),
    metrics.update(event),
  File "/home/dmarc-metrics/.local/lib/python3.7/site-packages/dmarc_metrics_exporter/dmarc_metrics.py", line 57, in update,
    self.metrics[event.meta].update(event.count, event.result),
KeyError: Meta(reporter='google.com', from_domain='mydomain.org', dkim_domain='mydomainorg.onmicrosoft.com', spf_domain='mydomain.org')

Should be fixed by PR #8.

I pulled in these changes and created a new docker image with them. Now I suddenly get an IMAP error again. Is it possible that there is a side effect causing this?
My fork I pulled your changes in is up to date here: JamborJan/dmarc-metrics-exporter
The docker image can be found here: JamborJan/dmarc-metrics-exporter/pkgs/container/dmarc-metrics-exporter
INFO:     Waiting for application startup.,
INFO:     ASGI 'lifespan' protocol appears unsupported.,
INFO:     Application startup complete.,
INFO:     Uvicorn running on http://<IP_ADDRESS>:9797 (Press CTRL+C to quit),
INFO:     <IP_ADDRESS>:33652 - "GET /metrics HTTP/1.1" 200 OK,
...
INFO:     <IP_ADDRESS>:34718 - "GET /metrics HTTP/1.1" 200 OK,
Error during IMAP queue polling.,
Traceback (most recent call last):,
  File "/home/dmarc-metrics/.local/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 59, in _consume,
    async for uid, msg in client.fetch(1, msg_count):,
  File "/home/dmarc-metrics/.local/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 125, in fetch,
    match = mail_header_regex.match(line),
TypeError: cannot use a string pattern on a bytes-like object,
INFO:     <IP_ADDRESS>:34796 - "GET /metrics HTTP/1.1" 200 OK,

That is weird. The mail_header_regex that the error is complaining about is a bytes pattern.

First of all thanks for creating the docker image, I tested your image now and it works the same way mine did before thus I delete my fork. Unfortunately the TypeError: cannot use a string pattern on a bytes-like object, is still there. I attach an example.zip report I'm receiving from Google. I hope that helps to track down the problem.

That image is still using version 0.3 depending on aioimaplib 0.7.18. That version might not have a consistent return type for the IMAP calls. At least the changelog for version 0.9.0 hints on that.. The current development version of dmarc-metrics-exporter is already using the newer aioimaplib and hopefully fixes the problem. I want to test that version for a few days on my own server to make sure there is nothing major broken, but will probably make a 0.4.0 release later this week.
Building Docker images from unreleased versions seemed to complicated to me (at least to automate this). You'd have to have a script around the docker file building the Python wheel first and some logic to copy and install the file instead of downloading it from PyPI ...

Thanks for that feedback. Another week or two for stability reasons seems legit. I'm anyway very happy how responsive and willing to implement the whole Docker stuff you are. Thanks a lot for all of that. Great work!

You can now try with the jgosmann/dmarc-metrics-exporter:0.4.1 image. Note that there has been a breaking change in the configuration. The changelog describes the details.

This is working great and all is as expected. Thank you @jgosmann !


Improve accuracy of average and delta calculations

Due to rounding errors, the average and delta calculations don't always display the true value. The full float value should be stored in each variable, but we can print a rounded value for simplicity.

Closed with commit b7c5f7fcdd67dc56847a82b1f5c5934d68b889bd.


(Edited)Automatically complete statement on semicolon

Originally posted by @tzengshinfu in https://github.com/microsoft/vscode/issues/170661#issuecomment-1375012886
I mean the function that is within parentheses and you type a semicolon , it automatically moves it to the end of the brackets
even no parameter method.

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!


-tags not working, along with zig failures

Description
Have an application I've been able to build for around a year with fyne-cross, without issue. Today I upgraded to the latest 1.4.0 and am now running into multiple issues.
The project has a configs/ directory that houses numerous .go files, with build-tags within each file, used for setting app configuration values. Issuing a go build -tags dev . runs just like you'd expect. When running with fyne-cross linux -tags dev . it fails to honor the file with the matching tag.
config/dev.go:51:14: undefined user
....

(every value set within the config file, for the matching tag, yields an undefined error)
If I remove the build tag from the specific configuration file I want to use—forcing the config without tags—I then end up with a zig linking failure:
# fyne-cross linux -tags dev .
...
/usr/local/go/pkg/tool/linux_amd64/link: running zig failed: exit status 1
ld.lld: error: /tmp/go-link-3345816007/000000.o: unknown file type
...

To Reproduce:

Create dummy hello-world app% mkdir helloworld
% cd helloworld
% go mod init helloworld
% go mod tidy ← after creating the below files

Create main.go

package main

import (
    "fmt"

    "fyne.io/fyne/v2/app"
    "fyne.io/fyne/v2/widget"
)

var Name = name

func main() {
    a := app.New()
    w := a.NewWindow("Hello World")

    w.SetContent(widget.NewLabel(fmt.Sprintf("Hello %s", Name)))
    w.ShowAndRun()
}

Create vanessa.go

//go:build vanessa
// +build vanessa

package main

var name = "Vanessa"

Build/Run (works as expected)go build -tags vanessa .
/helloworld`

Fail w/fyne-cross fyne-cross linux -tags vanessa .
 [i] Target: linux/amd64
 [i] Cleaning target directories...
 [✓] "bin" dir cleaned: /app/fyne-cross/bin/linux-amd64
 [✓] "dist" dir cleaned: /app/fyne-cross/dist/linux-amd64
 [✓] "temp" dir cleaned: /app/fyne-cross/tmp/linux-amd64
 [i] Checking for go.mod: /path/to/helloworld/go.mod
 [✓] go.mod found
 [i] Packaging app...
 # helloworld
 ./main.go:10:12: undefined: name

 error building application: exit status 1
 [✗] could not package the Fyne app: could not package the Fyne app: exit status 1

Device and debug info

OS: Linux
Version: 6.1.25-1-MANJARO
Go version: go version go1.20.3 linux/amd64
fyne-cross version: fyne-cross version v1.4.0
Fyne version: 2.3.4

I can confirm and reproduce this, it's also affecting one of my projects. It used to work in the past... Is there any workaround?

I finally got the time to track down where the problem come from. Small PR coming in and I think we should make a minor release of fyne-cross soon as we have some other bug fixes that would be nice to get in master.

I finally got the time to track down where the problem come from. Small PR coming in and I think we should make a minor release of fyne-cross soon as we have some other bug fixes that would be nice to get in master.

I can confirm that the develop branch version works, any plan to release it?

Thanks for the update. I will close this then. As for the release, I am hoping to get some clarification this week with #201 and decide accordingly when doing next release.

I keep checking on this from time-to-time in hopes there might be a release including this fix.
Is this project still being maintained?

Yes it is.
I guess the previous comment still holds - there was a hope we could understand and resolve the linked issue as well.
We were waiting for confirmation of the fix -and have probably waited long enough.
@Bluebugs what do you think?

Yes, I have had plan to do a releases for a while, but haven't had the time at this point. I think there is improvement to be made on that process to make it easier, but that's another discussion.


[RHOAIENG-1104] Design custom annotation type to track storage class metadata

https://issues.redhat.com/browse/RHOAIENG-1104
Description
Adding a type for the storage class config object to be a part of the existing annotations type.
Request review criteria:
Self checklist (all need to be checked):

[ ] The developer has manually tested the changes and verified that the changes work
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm

/approve


FR: Support Firestore Timestamp

Please please support Timestamp (See https://firebase.google.com/docs/reference/js/firebase.firestore.Timestamp) asap. We share code with backend and frontend, so we need to be able to upgrade both simultaneously or we need to duplicate a lot of code or write some mappers to all layers in the mean time.

It's on the immediate roadmap and will be part of the next major release.

Will this also enable code similar to this?
const date = new Date()
const timestamp = new TimeStamp(date)
collection.where('updatedAt', '<', timestamp)

updatedAt is of type timestamp in the database, and I need to make a range query via firebase-admin.

Yes. That will be supported.

This should work:
const admin = require('firebase-admin');
const timestamp = new admin.firestore.Timestamp(0, 10);

Thanks, Sebastian. Similarly, admin.firestore.Timestamp.fromDate(new Date()) works.

        admin.initializeApp({
            credential: admin.credential.cert(environment.adminCredential as admin.ServiceAccount),
            storageBucket: environment.storageBucket
        });

        const firestore = admin.firestore();
        firestore.settings({ timestampsInSnapshots: true });

        (await firestore
            .collection(`/apps/${options.id}/flavors`)
            //.where('updatedAt', '<', Timestamp.fromDate(new Date()))
            .get())
            .docs
            .forEach(async flavor => {
                console.log(flavor.data());
            });

This gives a result of:
{ name: 'release/7.14.0',
  latestVersion:
   { name: '7.14.0-108876',
     bucket: 'laadkisten.appspot.com',
     updatedAt: Timestamp { _seconds:<PHONE_NUMBER>, _nanoseconds: 796000000 },
     path: 'apps/kleinanzeigen-ios-sandbox/versions/release/7.14.0/7.14.0-108876/Kleinanzeigen-7.14.0-108876-sandbox-c0350efad-release7140.ipa' } }
{ latestVersion:
   { name: '7.13.0-108601',
     bucket: 'laadkisten.appspot.com',
     updatedAt: Timestamp { _seconds:<PHONE_NUMBER>, _nanoseconds: 976000000 },
     path: 'apps/kleinanzeigen-ios-sandbox/versions/release_7_13_0_test_branch/7.13.0-108601/Kleinanzeigen-7.13.0-108601-sandbox-2188e01b5-release_7_13_0_test_branch.ipa' },
  name: 'release_7_13_0_test_branch' }

If I uncomment there .where('updatedAt', '<', Timestamp.fromDate(new Date())) invocation, I get zero results. Am I doing something wrong or are timestamps still not supported in a where clause?
Using firebase-admin 5.13.1.

Try 'updatedAt', '<', 'new Date()'

I put below codes on the top of javascript(not typescript) file, then it got the error.
const admin = require('firebase-admin');
const today = new admin.firestore.Timestamp(new Date());

Error: Value for argument "seconds" is not a valid integer.
    at Object.validateInteger (/Users/app/functions/node_modules/@google-cloud/firestore/build/src/validate.js:191:19)
    at new Timestamp (/Users/app/functions/node_modules/@google-cloud/firestore/build/src/timestamp.js:54:20)

how can I use Timestamp on firebase function with javascript.

@SpaceNet see the comment right before yours. You're calling Timestamp(new Date()) while schmidt-sebastian is calling Timestamp.fromDate(new Date()).

@SpaceNet The Timestamp constructor expects a pair of seconds/nanoseconds as arguments. If you want pass a Date, use Timestamp.fromDate() as @Ruberik suggested.


New Raspberry Pi OS has vcgencmd in /usr/bin

The latest versions of Raspberry Pi OS distribute vcgencmd to /usr/bin/vcgencmd. Can we update the path here?

So sorry, just saw this. Published to npm as 3.0.0. Thanks!


Fix the price of the product when importing products

This issue is the same one as the one shown in Magento that when the price is missing, the price or listPrice of the product is sent as false.

Do you have an example product where this is the case?

Cannot reproduce


Code coverage improvements

Codecov Report

Merging #81 (0f63d61) into main (fe8289e) will increase coverage by 4.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   88.31%   92.45%   +4.13%
==========================================
  Files          25       25
  Lines         993      967      -26
==========================================
+ Hits          877      894      +17
+ Misses        116       73      -43

Impacted Files
Coverage Δ

src/ProbNumDiffEq.jl
76.47% <ø> (+9.80%)
:arrow_up:

src/filtering/update.jl
100.00% <ø> (+3.57%)
:arrow_up:

src/initialization/common.jl
100.00% <ø> (+20.00%)
:arrow_up:

src/preconditioning.jl
100.00% <ø> (+33.33%)
:arrow_up:

src/gaussians.jl
80.95% <100.00%> (+9.52%)
:arrow_up:

src/perform_step.jl
98.42% <100.00%> (+3.04%)
:arrow_up:

src/initialization/rungekutta.jl
90.32% <0.00%> (+4.83%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8289e...0f63d61. Read the comment docs.


Update app-configuration.md

Article up to date.

@johndowns
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Margin on CardView applies to headers in odd ways.

For example, if a top margin is set on the CardView the sticky headers are all pushed down by that amount, see attached screenshot. This CardView has a 4dp top margin with the intent of keeping the initial content from touching the toolbar but it moves the header down which causes odd scrolling effects. I have added background color to the headers for visibility.
In addition if a start margin is set it will only affect the "stuck" header. If I set a start margin the top header will have that margin while the second will not, until it becomes the stuck header. At that point it will jump right to the margin position.
Should the drawing of the headers even obey the margins of the cards or should it only be controlled by its own layout properties and that of the recyclerview?

Are you using master or the version from maven central? There was a recent
PR that added better support for child views with margins. If you're still
having issues please either link to a repo that reproduces the problem or
dig into the code and submit a pull request.

Please feel free to reopen if and when you add more details or instructions to reproduce.


Feature/419

#419
Please, consider this PR after all previous are merged.

This looks fine to me, minus the point from the last PR.


Filter Active and Inactive Components (View)

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context (wireframes, business rules, etc.)?
[x] Is this traceable to a feature, epic, or PI?

User Story
As a user, I want to be able to view active and inactive Components, so that I can view all Components assigned to a System.
Acceptance Criteria
Given the user is viewing MP systems
when there are both active and inactive components
Then the system displays active components only by default
Given the user is viewing MP systems
when there are only active components
Then the system displays active components only
And the Show Inactive option is not available
Given the user is viewing MP systems
when there are only inactive components
Then the system displays inactive components only
And the Show Inactive option is checked by default
Given the user has navigated to a new section of the MP (ex: methods)
When the new section has the same active/inactive selection
Then system retains the active/inactive selection from the previous section
Given the user has navigated to a new section of the MP (ex: methods)
When the new section has a different active/inactive selection
Then system updates the active/inactive selection using the logic above
Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
Testing
Test Case: TC204
Tester: @mosesdeeCVP
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Has the user story been accepted by the Product Owner?
[ ] Is the user story ready to be deployed to the test/staging environments?

Test Passed

Show Inactive button unchecked by default

Show Inactive button checked and the inactive methods are visible

There are no active methods, so the Show Inactive button is automatically checked with no option to uncheck it.

There are no inactive methods so the Show Inactive checkbox does not have an option to check it.

There are no records to show and the system lets the user know of this. The Show Inactive checkbox is automatically checked to let the user know that both active and inactive are not available


@options don't include options set via defaults

I noticed that options defined with defaults are not included in @__options__ hash. Is this expected?

I think we should re-write this variable.
For now it only takes explicitly assigned values, neither coerced, nor set by default.
AFAIK it was added by @flash-gordon to support some rom-related issue, but i'd like it to became a hash of all options being ultimately set (taking defaults, renamings and coercions into account)

I had no intention to make it work how it does now ¯\_(⊙_ʖ⊙)_/¯ All options should be in the variable

This is actually pretty bad, because it makes rom objects instantiate same objects all over again. It probably has some negative impact on performance.

I agree
I think I could fix it this week

@solnic @flash-gordon Fixed in v1.2.0

@nepalez thank you, I'll give it a try right away


Page for Someone who is Not Following Anyone

Do work for this issue in a branch called issue-24
If a user is not following anyone (signing in for the first time or removes all the people that the are following), create a page where they see "recommended people" to follow

[ ] create more default user accounts according to user schema
[ ] add to user schema: subscription for people who they are following
[ ] show this page when a user has 0 accounts they are following or if they have just signed up for the first time

design by likes? (Show top 5 liked posts at top no matter who you are?)


Fix disconnect issue

Set reconnect to true to keep-alive
There have been a number of threads (including in dependencies) raising
an issue where this client stops working a certain period of time after connecting.
The issue stems from the underlying xmppClient client. It will emit an 'offline'
event in the case of losing connection. This could be listened for and acted on
accordingly. However, there is a simpler solution:
The xmppClient client has a 'reconnect' option during creation. When set to
true, it will auto-reconnect when it goes offline, and no further action is needed.

thank you for your contribution @hufftheweevil.
may i kindly ask you to have a look at the contribution section of the readme and rephrase your commit message accordingly? the automated release build will pick up you change more easily afterwards. again, thank you!

Was that better @swissmanu? I have to admit I hadn't heard of "proper commit messages" until now.

i dont see anything changed? did you push?
having a specific format in commit messages helps me to lower the amount of work necessary to release new versions of my libraries. so "proper" is totally depending on the situation :)

Hmm, I must be a little lost then. I thought you meant the opening message to this thread. Where do I go to do this 'commit message'? I don't see how I can edit the comment on my commit itself.

@hufftheweevil see https://stackoverflow.com/questions/179123/how-to-modify-existing-unpushed-commits#179147 - this also applies to pushed commits, as explained in the answer.

What a shame that GitHub doesn't have that functionality built in. Not all of us work with the git command line interface. I've done my best at figuring out how to amend the commit message. I was only able to figure out the one-line version, not the multi-line version, so hopefully that meets your standards.

since this repo seems to be abandoned i created an updated package which includes some of the here available pull requests, hop over to @harmonyhub and give it a try.

thanks for your change. it will be included in the next version.


Can list private resources

Maybe related to https://github.com/ArunaStorage/ArunaWeb/issues/72
I can list private projects, collections and objects via S3. Only the object size is not shown correctly (it says 0 in the s5cmd output). If I try to download a private object, the download hangs first and then says:
ERROR "cp s3://my-little-project/my-little-project/my-little-collection/sample.fastq.tar.gz sample.fastq.tar.gz": InternalError: Object location not found status code: 500, request id: , host id:

Note that I had to repeat the project/bucket name my-little-project/my-little-project in order to list the resources via S3 (otherwise I get "no object found"). Maybe this is a separate issue.
If I try to download the object from s3://my-little-project/my-little-collection/sample.fastq.tar.gz sample.fastq.tar.gz (only one bucket name), I get a (correct?) "AccessDenied".

Thanks for reporting, this indeed sounds weird. Just a quick check are you the owner of "my-little-project"?
In any case we will have a deeper look at this.

No, I'm not the owner of "my-little-project". But in https://github.com/ArunaStorage/ArunaWeb/issues/72 it was explained that "private" does not mean "hidden" but rather "restricted". So I can see all private resources but I can't download them without permission. So maybe the S3 interface works as intended here (except maybe that another status code should be returned).

Ok, so this is 100% a bug. The data plane should handle permissions completely separate from the metadata plane. Private buckets & objects should not be accessible nor findable ("hidden") from an S3 perspective for people without access.
The rules described in (ArunaStorage/ArunaWeb#72) should only apply to a limited view in the search section for discoverability purposes and not extend to the data level.

It seems that 1e2a149 (I've no idea why exactly this one commit isn't signed :roll_eyes:) has fixed the problem.
Basically, the bug did not result in someone having unauthorized access to other users' resources, but was just an unfortunate error message due to incorrect permission handling of non-existent resources.
If I now repeat your request, I get the following error message that the resource does not exist:
ERROR "cp s3://my-little-project/my-little-project/my-little-collection/sample.fastq.tar.gz sample.fastq.tar.gz": AccessDenied : Invalid access key status code: 403

If I try to access a resource which I do not have permissions for, I get the following access denied error message:
ERROR "cp s3://biigletest/biiglecollection/160-1_OFOS-11_subset/SO268-2_160-1_OFOS_SO_CAM-1_20190427_181912.JPG SO268-2_160-1_OFOS_SO_CAM-1_20190427_181912.JPG": AccessDenied : Access denied status code: 403

I will close the issue as resolved. If further questions arise, the issue can be reopened.


gcc and qt-5.12.0 compilation error fix

Compililation with gcc (any version) and Qt 5.12.0 (important) fails with error:
Core/private/sysapiloader_p.h:59:26: error: no matching function for call to ‘QMutex::QMutex()’
     static inline QMutex m_mutex;
                          ^~~~~~~
include/QtCore/qmutex.h:165:5: note: candidate: ‘QMutex::QMutex(const QMutex&)’ <deleted>
     Q_DISABLE_COPY(QMutex)
     ^~~~~~~~~~~~~~

QMutex in Qt 5.12.0 has explicit (!) one-parameter constructor with a default value: QMutex(QMutex::RecursionMode mode = NonRecursive) and no default constructor. In this case declaring static inline member without initializer causes the above error.
Simplified example: https://godbolt.org/z/KzeK1nfYf

Thanks!


Players can't attack NPCs with capital letters in their name

The parser coverts input to lowercase (keep this). Comparing input to local usernames should be case-insensitive.

Dependent on #239.


Hiding Angular Material Paginator's "length" property

Bug, feature request, or proposal:
Feature request
What is the expected behavior?
mat-paginator component should allow the option to hide the length property.
What is the current behavior?
According to Angular Material docs mat-paginator does not have a hideLength (or a different named) property.
What are the steps to reproduce?
There is nothing to reproduce.
What is the use-case or motivation for changing an existing behavior?
I'm using Firebase Firestore. As you know Firestore cannot count stored items directly. But I will not create Firestore listeners to observe database CRUD operations in Cloud Functions -at least not in this project since I'm not gonna get paid for it-. So I am not able to set a length property and I should hide it.
I'm sure there might be similar use cases.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material 6.4.6
Is there anything else we should know?
Nope.

Agreed. In my case, i get already paginated results from the server. Anyone found a workaround?

From an i18n standpoint, we wouldn't be able to introduce a field to disable display of the length, since we'd have no idea where it is in the text. Instead, you can use a custom MatPaginatorIntl to change the page display however suits the application.

From an i18n standpoint, we wouldn't be able to introduce a field to disable display of the length, since we'd have no idea where it is in the text. Instead, you can use a custom MatPaginatorIntl to change the page display however suits the application.


[wallet-ext] add feature to verify your Ledger connection for your accounts

Description
This PR adds a "Verify Ledger Connection" button to the account actions menu which was requested by the Ledger team as an important feature. Once you do verify your device, we'll reset the status text back to the original link.
PS 1: We opted to remove the loading state since the operation is almost instantaneous)
PS 2: The "g" being cut off on the button is a separate visual regression that we need to fix
https://user-images.githubusercontent.com/7453188/230483494-1705548e-fd49-4233-8fba-1da1995433f9.mov

Test Plan

Manual testing (successful connection, error, etc.)
Didn't test the "Failed" connection because I don't have a second Ledger device, but I tested the UI looks good!

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[X] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes
N/A

Looking good on the verify flow.
Could we update the first error message in video to,
"Connect your Ledger device and try again."

Looking good on the verify flow.
Could we update the first error message in video to, "Connect your Ledger device and try again."

Sure thing!


How To Correct White Balance?

I recently installed OpenIPC on a birdhouse camera (based on GK7605V100 sc2239) with no problems. It's up and running, but I cannot find any means of tweaking the white balance. Under the camera's original Chinese firmware, the image looks fine, but under OpenIPC, it's quite yellow/green (see images). The project overall seems really well done, but the documentation is simply just not there in most cases and I can't find any reference on how to tweak the image outside of setting the HUE/Sat/Lum settings in Majestic which won't affect my white balance issues.
OpenIPC

Original Firmware

Can anyone make a suggestion on what I need to fix?

Nobody?


extensions won't work

Environment

Operating System: Linux
Node Version:     v18.15.0
Nuxt Version:     3.2.3
Nitro Version:    2.2.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      srcDir, extensions, typescript, routeRules
Runtime Modules:  -
Build Modules:    -

Reproduction
export default defineNuxtConfig({
	srcDir: 'src/',
	extensions: [".api.ts",  ".page.vue"]
});

Describe the bug
The configurations in nuxt.config.ts won't work, all vue files are treated as page files, I want ignore .vue as page file in pages.
Additional context
I did the same thing in next.js,
Logs
No response

Check out https://nuxt.com/docs/guide/going-further/custom-routing#using-the-pagesextend-hook.
The extensions configuration option is not about the pages directory and configuring it adds extensions, doesn't remove ones that already exist


Added JS initializer

Added a simple JS and JQuery plugin that allows the creation and
removal of a spinner to a DOM element.
Added Minified Spinkit CSS
Included Example fields for JS and JQuery usage

Thanks for adding a minified version, it's now included as of #143 🙏 the rest of this PR is obsolete.


BRT pipeline should return the path to ..._ave.mrc in the primaryFilePath parameter.

This came up during the live testing at RML. The EM team would like to enable users to download the _ave.mrc file for the BRT-type sessions.
Hence, the pipeline callback should include the path to:_ave.mrc file in the `primaryFilePath ' parameter.

I'm not sure this is OK. I'll need to talk to Seva about this.

Went over this with Seva. Probably not possible.
If they want this _ave file, then I can add it to the callback, and they can download it.
Basically the entire concept of downloading mrc files via the web interface seems silly however, given they have direct access to the filesystem and can dl files much much quicker via that interface.
I'm not going to do anything here for now, as it will break things badly on the GUI.

Please see Seva's comment on ticket https://jira.niaid.nih.gov/browse/HEDWG2-627:
If the pipeline provides the desired path as the "primary file" in the callback, this will happen with no changes to the API

I report the _ave.mrc file as the asset named volume.
If the GUI wants to download that file, it's available for use.
The input, the file/files that generate an output are listed as PrimaryFilePath. I write the outputs to an outputs directory called Assets. I list the items of interest as assets, linked with the primaryFilePath.
If a browser wants to link to a file, that logic is done on the level of GUI, it doesn't change the logic of the callback or workflow.


Disconnect Client Not Working

The disconnect client button doesn't work. Mainly because we haven't actually hooked this up yet in openwrt.
Disconnect from splash should work.
We should probably remove this from the menu while we test.

Note for @AndrewMargarit

With me

@AndrewMargarit Can we get the disconnect code sorted for the boxes so we can run a payload and disconnect.
I believe the intention was to disconnect and add to the blacklist since the client will reconnected immediately.

Yes, that's the one.
We can do it in this sprint

Temp. removed the link from the index

@AndrewMargarit @ZakMooney Can one of you test the logout button works - I removed the disconnect button - I'm talking about the splash logout button.

@simonmorley Logout worked fine in my tests

Now implemented in SocketMan


Stable Studio - yarn dev script missing?

Describe the bug
Following steps in Quick Start guide produces Yarn dev script missing/not found error. Confirmed Stable Studio not running at localhost:3000
To Reproduce
Steps to reproduce the behavior:

Open command terminal
cd to Stable Studio directory in Home directory
Set active version of NVM

:~/StableStudio$ nvm use v20.3.1
Now using node v20.3.1 (npm v9.6.7)

enter Yarn

:~/StableStudio$ yarn
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed
➤ YN0000: Done in 0s 45ms
:~/StableStudio$ yarn dev
Usage Error: Couldn't find a script named "dev".

$ yarn run [--inspect] [--inspect-brk] [-T,--top-level] [-B,--binaries-only]  ...

:~/StableStudio$

enter

Expected behavior
Expected no error msg
Screenshots
extract of command terminal session above.
Desktop (please complete the following information):

OS: Ubuntu 22.04 LTS
Browser: Chrome or Chromium
Version: latest browser from repos

Additional context
Followed instructions in the Quick Start. Installed Node using NVM. Installed Yarn using corepackage.

I've just installed (arch linux) a fresh project locally, and yarn dev worked as expected.
Check the package.json and see if there's dev.

Apparently Yarn was not configured properly based on inspection of the package.json file. Re-installed Yarn. Then deleted the /StableStudio directory. Then followed the quick start guide. StableStudio was accessible from localhost:3000 in a browser.

If your problem is resolved, consider closing the issue.
I'm glad you managed :)

Resolved. apologies for not closing this issue.


Stack level too deep with Spree 0.70.RC1

I'm getting a "Stack level too deep" after clicking on the "Add to cart" with a new Spree project
rails-dev-boot git revision: 216de40f33fe794e19c492c283d69d4911cab741
Spree version: 0.70.RC1
Full trace:
actionpack (3.1.0) lib/action_dispatch/middleware/reloader.rb:73

Looks like the problem appears when using active_reload gem.

Using rails-dev-boost and active_reload gems at the same time doesn't make any sense. I would suggest you first try rails-dev-boost as it should provide a faster developer environment and if you run into any problems please open another issue. If I am unable to fix things only then should you install active_reload (while not forgetting to remove rails-dev-boost).

Bug is not related to active_reload. Still happens with spree 0.70.1

Hey @jj05, I'm stuck on this one as I am unable to reproduce it with the steps listed above (using git checkout v0.70.1 for the spree version).

First of all, did you mean I had to do this to reproduce:
echo 'group(:development) { gem "rails-dev-boost", :git => "git://github.com/thedarkone/rails-dev-boost.git", :require => "rails_development_boost" }' >> Gemfile

The reason why requiring rails-dev-boost outside the :development group doesn't trigger the error for you is a bug with Spree, it is using the Bundler incorrectly and the non-grouped gems are not auto-required (see spree/spree#748). So rails-dev-boost placed outside the :development group isn't actually being used.
The bad news is that I still can't reproduce the error even with rails-dev-boost inside the :development group :(. What version of Ruby are you using and would you mind sending me the Gemfile.lock that Spree ends up generating for you?
Thanks!

Ruby 1.9.3-p0, Ubuntu 10.04 LTS (happens with 1.9.2 as well)
http://solsc.com/tmp/Gemfile
http://solsc.com/tmp/Gemfile.lock

This was being caused by a bug in Spree (see spree/spree#766), you'll have to wait for it to be pulled into 0-70-stable and released as gem version bump.

Still happens with a fresh 0.70.3 sandbox


Feature/Add Save Mode function and Connector-JDBC (MySQL, Oracle, SQLSERVER, PGSQL) connector has been realized

Function list

[x] add save mode function interface ，see “org.apache.seatunnel.api.sink.SaveModeHandler”
[x] add saveModeHandler default implementation ，see “org.apache.seatunnel.api.sink.DefaultSaveModeHandler”
[x] connector-jdbc(mysql,oracle,sqlServer,pgsql)  implement the save mode function interface

Will this PR be split and closed?


But I wonder why this feature not merged yet?

Awesome!
But I wonder why this feature not merged yet

I haven't had the time to test it yet
It should work as expected, mainly looking to test performance and user experience.

When will this be merged?

When will this be merged?

How can this project be build from the feature branch for an Angular project?

we fixed it at the pull request


Multi-line compliments

Allows multi-line compliments by supporting \n (newline) character in compliment text.
For example, in your config.js:
{
    module: "compliments",
    position: "lower_third",
    config: {
        compliments: {
            anytime: [ 'Blackbird singing in the dead of night\nTake these broken wings and learn to fly.' ]
        }
    }
}

Will be shown in two lines:
Blackbird singing in the dead of night
Take these broken wings and learn to fly.

This is ideal for lyrics or poems.

Thanks for your contribution. Using innerHTML isn't preferred since this could be used to fire malicious code. (IE when an external compliments file is used). Is there a way to refactor this?

Forgot the fact that compliments content can be loaded from an URL. Patch submitted.

Maybe a simpeler approach: how about we just add the white-space: pre-line; style to the wrapper? Then no further coding is nessecery.

@MichMich I'm not familiar with CSS, it's definitely simpler.

Awesome work! Thanks! :)


Browser ws fix

'ws' package used as devDependenci is actually used in the code in navigation.ts so it is a dependency,  and breaks the Browser usage of the package since "ws" is a Node.js package, instead, use isometric-ws which can be used in both browser and node

Published as version 2.0.2, FYI.


docs: add RxJs operators to hero.service.ts example

Proposed change adds RxJs operator import to hero.service.ts example - my motivation for this pull request was this issue: https://github.com/angular/angular/issues/5632#issuecomment-200444642.
Since RxJs operators are not mentioned until after the code example, I figure that this would be useful for anyone skimming the docs.

I signed it!

Interesting suggestion, Jake. I certainly appreciate the feedback.
However, I'm not ready to agree.  Yes, we do apply rxjs operators before we talk about them. Maybe you have a better idea for teaching this.  But I don't think the solution is to add an import that you don't actually need.
We do call out the need to Enable RxJS Operators in the http chapter.
I'm closing your PR with a tinge of regret.  Thanks for helping.


feat(Algebra/Category/ModuleCat): the category of sheaves of modules has limits

[x] depends on: #12264
[x] depends on: #11669

Thanks!
maintainer merge

Thanks!
bors d+

Thanks!
bors merge


Support for OSCORE Appendix B.2 context re-derivation procedure

This pull request adds support for running the Appendix B.2 procedure from the OSCORE RFC, which securely re-generates OSCORE Security Context information. The LWM2M client can now run this procedure towards the LWM2M server or LWM2M bootstrap server.
See https://tools.ietf.org/html/rfc8613#appendix-B.2
It is specified in the LWM2M 1.1 Transport Bindings document section 5.5.3 that Appendix B.2 of OSCORE should be used. Using the procedure in Appendix B.2 will derive a new OSCORE Security Context (with new Sender and Recipient keys). The benefit this has is that if a LWM2M client reboots and starts using the same Security Context that it was originally configured with, it will not be using the same Sender Key while starting over from sequence number 0 (thus having nonce and key reuse). But rather it will first run Appendix B.2 to generate a new Context (Sender and Recipient keys) with the LWM2M Server or LWM2M Bootstrap server.
So every time the client connects the first time using OSCORE to a LWM2M Server or LWM2M Bootstrap server, Appendix B.2 will be run. Furthermore, currently if the client is restarted but the server is not, the server will complain about replayed messages. But since Appendix B.2 refreshes the security contexts this problem will no longer exist.

I needed to add some code with a temporary workaround for an issue in the functionality of Appendix B.2. in Californium. When the code in this oscore branch moves to Californium 2.6.3 or 3.0.0, this workaround code can be deleted.

@rikard-sics
I scheduled the Californium 2.6.3 for next Thursday. If you need some more time, let me know.

I scheduled the Californium 2.6.3 for next Thursday. If you need some more time, let me know.

Thanks for the heads up!
But I was perhaps a bit unclear in my previous comment, or I misunderstand you.
The code in Californium should already be fixed in PR https://github.com/eclipse/californium/pull/1595
And from I understand thus added to both Californium 2.6.x and 3.0.x:
https://github.com/eclipse/californium/commit/53b16da4762881eab769682098876a3c2ed990b1
https://github.com/eclipse/californium/commit/dc45ab0642cc19709fe64a08fb09728969d9fe6a
What I meant is that I had to add some workaround in the Leshan code, just temporarily until Leshan can move to Californium 2.6.3 or 3.0.0.

Ah, OK. so no need to wait ...

@sbernard31
Should we prepone the Californium 2.6.3 to tomorrow?
It's juts a collection of bugfixes. And I guess, not the last "2.6" :-).

On my side I will be out of office from tomorrow, back next Tuesday.
So I will not be able to integrate it before Tuesday. (except it is really needed and so I can do it during my free time)

OK.
I guess, it should be possible to check leshan with californium 2.6.3-SNAPSHOT, if the feature works with that.
If that's the case, then a Californium 2.6.3 on next Thursday will be soon enough to then update Leshan to 2.6.3 afterwards.

From my point of view there is no immediate rush with this. If Californium 2.6.3 is released next week and Leshan is then updated to 2.6.3, I can remove the workaround code before this PR is accepted.
I have tested the code in this PR (excluding the workarounds), together with the latest code from the Californium 2.6.x branch, and everything seems to work fine.

@rikard-sics, just in case you don't know you can use some SNAPSHOT artifact from eclipse maven repository.
(See https://github.com/eclipse/leshan/pull/885, this is a description for Leshan but I guess it should work for californium too )
This could allow you test your code without the workaround and if it works you can remove workaround and update this PR.

@rikard-sics, just in case you don't know you can use some SNAPSHOT artifact from eclipse maven repository.
(See #885, this is a description for Leshan but I guess it should work for californium too )
This could allow you test your code without the workaround and if it works you can remove workaround and update this PR.

Thanks! Yes I can test the code with the latest snapshot to confirm 100% that it should work without the workarounds. I will do that testing and then remove the workarounds from this PR.

@rikard-sics , I integrated cf-2.6.3 in master.
I rebase oscore branch on master. There was conflicts, I hope I didn't create any issue. (I didn't test it)
The previous contain of oscore branch is available in the branch old_oscore, just in case)

Alright, this PR should be ready now. I removed the workarounds that were needed for the previous version of Californium and retested the functionality.

Integrated in oscore branch.
@rikard-sics Thx for all your contribution :pray:

Integrated in oscore branch.
@rikard-sics Thx for all your contribution

Thanks for the merge!


server_ipv6_addr need to be added to requires_one_of for a10_slb_server.py to allow IPv6 servers

What is the proper syntax for slb server and IPv6 address? 'host' gives and error about invalid IPv4 address which makes sense, but both 'ipv6' and 'server_ipv6_addr' give a validation error.
Thank you.
Also, the email in the README is rejected by the server.
Debug info below along with the play:
TASK [Create a10 server server1.v6] *******************************************************************************************************************************************************
task path: /home/vagrant/ANSIBLE/ansible-experiments/media/SV5/create-nodes.yml:142
Using module file /home/vagrant/ANSIBLE/a10-ansible/a10_ansible/library/a10_slb_server.py
<<IP_ADDRESS>> ESTABLISH LOCAL CONNECTION FOR USER: vagrant
<<IP_ADDRESS>> EXEC /bin/sh -c 'echo ~ && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/vagrant/.ansible/tmp/ansible-tmp-1524559431.28-188996405751674 `" && echo ansible-tmp-1524559431.28-188996405751674="` echo /home/vagrant/.ansible/tmp/ansible-tmp-1524559431.28-188996405751674 `" ) && sleep 0'
<<IP_ADDRESS>> PUT /home/vagrant/.ansible/tmp/ansible-local-26673ruwHrU/tmpD4T4ph TO /home/vagrant/.ansible/tmp/ansible-tmp-1524559431.28-188996405751674/a10_slb_server.py
<<IP_ADDRESS>> EXEC /bin/sh -c 'chmod u+x /home/vagrant/.ansible/tmp/ansible-tmp-1524559431.28-188996405751674/ /home/vagrant/.ansible/tmp/ansible-tmp-1524559431.28-188996405751674/a10_slb_server.py && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '/home/vagrant/ANSIBLE/.ansible/bin/python2 /home/vagrant/.ansible/tmp/ansible-tmp-1524559431.28-188996405751674/a10_slb_server.py && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c 'rm -f -r /home/vagrant/.ansible/tmp/ansible-tmp-1524559431.28-188996405751674/ > /dev/null 2>&1 && sleep 0'
fatal: [localhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "a10_host": "********_dev",
            "a10_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "a10_username": "admin",
            "action": "enable",
            "alternate_server": null,
            "conn_limit": null,
            "conn_resume": null,
            "extended_stats": null,
            "external_ip": null,
            "fqdn_name": null,
            "health_check": null,
            "health_check_disable": null,
            "host": null,
            "ipv6": null,
            "name": "server1.v6",
            "no_logging": null,
            "port_list": [
                {
                    "health-check": "server_host_check_6001",
                    "port-number": 80,
                    "protocol": "tcp"
                },
                {
                    "health-check": "server_host_check_6001",
                    "port-number": 443,
                    "protocol": "tcp"
                }
            ],
            "sampling_enable": null,
            "server_ipv6_addr": "<REDACTED>:e002:2004::102",
            "slow_start": null,
            "spoofing_cache": null,
            "state": "present",
            "stats_data_action": null,
            "template_server": "ALL",
            "user_tag": null,
            "uuid": null,
            "weight": null
        }
    },
    "message": "",
    "messages": "Validation failure",
    "msg": "",
    "original_message": ""
}
    to retry, use: --limit @/home/vagrant/ANSIBLE/ansible-experiments/media/SV5/create-nodes.retry

PLAY RECAP ***********************************************************************************************************************************************************************************************
localhost                  : ok=8    changed=8    unreachable=0    failed=1

Here is the play:
  - name: Create a10 server server1.v6
    a10_slb_server:
      a10_host: "{{ a10_host }}"
      a10_username: "{{ a10_username }}"
      a10_password: "{{ a10_password }}"
      name: "server1.v6"
      server_ipv6_addr: "<REDACTED>:e002:2004::102"
      action: enable
      state: present
      template_server: "ALL"
      port_list:
        - port-number: 80
          protocol: tcp
          health-check: server_host_check_6001
        - port-number: 443
          protocol: tcp
          health-check: server_host_check_6001

I intentionally munged the IPv6 address in that output, but use a real one to generate the debug info.

I think it is here in you validate function:
requires_one_of = sorted(['host','fqdn_host'])
maybe it should be
requires_one_of = sorted(['host','fqdn_host','server_ipv6_addr'])
?

Ah, yeah. That seemed to work.

Fixed thanks!


3dhp data required

Thanks for your wonderful job! Where can we download 3dhp data like '/Ray3D/3dhp/S1/Seq1/imageSequence/video_0/img_000001.jpg' ?

I see we must download the original dataset
thanks


[Enhancement]: Today shortcut in the date picker does not follow rules of max & min dates

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I have two date picker widgets where one is for picking the start date and the other is for picking the end date. The pickers look like this:

I have the following rules for both pickers:

Both start and end dates cannot be older than 90 days and it cannot be more than today.
Start date cannot be beyond end date in case end date is chosen first
End date cannot be before start date in case start date is chose first.
These rules are implemented in JS like this:

Given these rules, if a user chooses a date before today as the endDate and then clicks on the Today shortcut inside the startDate widget, both fields give an error like this:

This is a fairly common use-case and I think, to prevent such situations, the following two approaches can be taken to fix this:
Automatically hide or unhide the Today shortcut if it does not follow the min and/or max dates of the widget.
Create a new parameter in the widget properties where the user can write their own JS logic to hide or unhide the shortcut.

Steps To Reproduce
My description gives the complete use-case with the relevant pieces of code which can be used to recreate this.
Public Sample App
No response
Version
Appsmith v1.8.5-SNAPSHOT
 Front conversations

@dilippitchika here if we only want to show an error on the date input, that should be easy to implement, Do we need some other behaviour?


In Terminated State App is opening but not taking me to calling screen.

Specify the sample to which the issue belongs (use [x]):
[] Chat sample
[X] P2P Call sample
[] Conference Call sample
Platform (use [x])
[X] Android
[] iOS
[] macOS
[] Windows
[] Web
Device info
Manufacture:
Model: Emulator
OS version:  API 30
Describe the bug:
I am using c2c_flutter_call_kit to show the calling UI in my app. Calling perfectly work on background state (Appreciate that) but the app is showing calling UI and when I click on Accept button it opens up the app but cannot navigate me my calling screen that I build myself.
Steps to Reproduce:

I generate a firebase notification
On receiving notification I check if it is a background notification or a Message notification
After receiving background notification, I show the calling UI and on click of calling UI I navigate to my Calling Screen.

Logs:
No logs to show because I am working on terminated state of the app. Logs are not generated on terminated state.
log here
or
[Gist log](https://gist.github.com/)

**Actual result:**

**Expected behavior:**
I want my calling UI notification to open the app and navigate me to my calling screen.

**Additional info**
Add any other context about the problem here.

Why do use the forked lib but not original connectycube_flutter_call_kit? In our sample we use it and it works well for us.

Hi @TatankaConCube, i'm having the same issue even i'm using the connectycube_flutter_call_kit.
Could you please help how to fix that.
Thanks

Hey, I am getting this same thing, any updates?

Not yet! haven't got any replies from the owner.

Not yet! haven't got any replies from the owner.

Hey I spent 12 hrs on this today with my team and figured it out. Ridiculously bad sample code compared to what you have to do.
I'll share the code and files tomorrow!

Sorry to say that I have managed to do that using firebase but it was not a good option.

Sorry to say that I have managed to do that using firebase but it was not a good option.

I'm using firebase and got it working. Got to show call notification in background handler and on the onMessage handler you need to init the callManager.
Then you need to create the callAcceptedOnTerminated function handler in the push notification manager. For this just copy the rejectOnTerminated that's in the example and change the name, in the function called by that, you need to remove everything after the onSessionRestore and then call the CallManager.onAcceptCall()

Also need to change the callManager so where the state is unknown or pending yo, you navigate to incoming call screen


When one invalid image fails, it should only fail that single image.

Move to a more graceful degradation 3d asset import model.

Thanks!

Cherry-picked for 3.4.

Cherry-picked for 3.3.2.


RFE: improve usability of log files

Is your feature request related to a problem? Please describe.
At present cloud-init/declarative-onboarding logging are developer oriented. This makes unnecessarily hard to troubleshoot a DO declaration and waste effort and time for customers.
Describe the solution you'd like
At present the log files are not very user friendly:

two files for cloud-init: cloud-init.log and cloud-init-output.log
cloud-init log files include DEBUG level messages which are PD oriented and makes them very hard track where the issue is.
restnoded.log files als include DEBUG level messages which are also cryptic.

I would propose to:

Unify cloud-init and cloud-init-output
Have cloud-init.log restnoded.log as user friendly log files with LOG level <= info
Have cloud-init.debug.log and restnoded.debug.log as developer frienly log files with all logging as they are at present.

Thanks

Closing for inactivity. If you are still experiencing an issue, feel free to reopen this issue or create a new one.


STORY: Validate Unit fuel Type

User Story
As a user I want to be able to enter valid filter criteria for unit fuel type so that I can see results
Dev Tasks

[x] Create an entity for fuel_type_code
[x] Ensure enums match entries in fuel_type_code
[x] Create a custom decorator to validate
[x] Add decorator to DTO

Acceptance Criteria
Given that a user has entered invalid filter criteria for unit fuel type
When the API endpoint is executed
Then the system displays the error message FV-2

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
Testing
Test Case: TC73
Tester: @davidkwartler
Issue Requester:
Requester:

https://cvpcorp.testquality.com requirement R21. Do not remove or edit.

https://cvpcorp.testquality.com requirement R23. Do not remove or edit.

TC73 passed

TC73 passed


Add ParQueryM and fix awaitTxConfirmedWithTimeout

Closes #1021 #1037.
Pre-review checklist

[x] All code has been formatted using our config (make format)
[ ] Any new API features or modification of existing behavior is covered as defined in our test plan
[x] The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

Tests are all green. I don't know how to test exactly that awaitTxConfirmedWithTimeout is working properly, though. Suggestions welcome.

Tests are all green. I don't know how to test exactly that awaitTxConfirmedWithTimeout is working properly, though. Suggestions welcome.

 We could check the elapsed time was approximately the timeout, but it's probably not necessary (at least to catch the original bug).

I've applied all suggestions and added a test case for the (thank you @jy14898). Should be ready for merging.

Plutip failures seem to be not related to this particular PR (take a look at #1055). Could we have this merged as soon as everything else is green?

Thanks!


Fix CiliumEnvoyConfig Nodeport handling again

Adds additional service redirect handling for Services with
Nodeports set, which will automatically include the Nodeport
in the set of redirected ports if ports to redirect are
specified.
Also removes a hack in the Dedicated Ingress code that was
introduced to solve this problem previously.
Signed-off-by: Nick Young<EMAIL_ADDRESS>

/test

/test

/test

/test

/test

/test

/test


simplify same RenderPolicys to bind

Issue description
I hope simplify same RenderPolicys to bind ,support regular for tagNames in future!
Configure.builder().bind(String... tagNameList,RenderPolicy policy).build();

Configure.builder().bind(String targetRegex,RenderPolicy policy).build();

poi-tl version
1.12.0
Minimal test code to reproduce the issue
        LoopRowTableRenderPolicy loopRowTableRenderPolicy = new LoopRowTableRenderPolicy();
        MyTextRenderPolicy myTextRenderPolicy = new MyTextRenderPolicy();

        Configure config = Configure.builder()
                .bind("educationExperience", loopRowTableRenderPolicy).bind("socialPractice", loopRowTableRenderPolicy)
                .bind("startDate", myTextRenderPolicy).bind("endDate", myTextRenderPolicy)
                .build();
        XWPFTemplate template = XWPFTemplate.compile(inputStream, config).render(data);

Minimal Docx template file

Support tagNames and Will be released in the next release.
Regex doesn't look like a strong demand.


Updates to readme

Here's the first iteration of my pass at readme, and some thoughts to discuss:

I have significantly cut down on the size of the readme because a) we will have detailed docs on terraform registry side, and I don't see value in duplicating them here. Instead, I have provided links to those docs (these are currently stubs and will need to be updated once the PR with the task is merged). b) I feel that this should be more of an overview with links to other resources. E.g. once I have the tutorial(s), we can also include links to those a section of the readme.
I feel that readme should give info as to what this is, what benefits it gives, links to docs, but also where to get support
One section that is missing and that I think we need to add is about contributions. We have docs for CML and DVC for that, and it feels that readme would be a good place for contributor's docs for TPI, however, I am probably not the right person to add those.

Looking forward to feedback, this is the first raw draft.

1 & 2. I wholeheartedly agree with this feeling and choices.
3. In fact, I have been sending direct messages with this information. 🙈 🙉 🙊 Let me collect them and paste some “technical ipsum” here.

(See the collapsed comment above for some useful development tips)

Note: development guide depends on

https://github.com/iterative/terraform-provider-iterative/pull/251

@casperdcl @0x2b3bfa0 All conversations have been resolved. Please merge the PR :)


Faker version outdated

Could this package be updated to allow @faker-js/faker version ^8.0.0?

Thanks for the super fast reply!
The peer dep requires faker-js ^7.5.0, which means 8.0.0 is not allowed.
In order for me to use it, I would have to force the version:

I'll increment the version number. I'll have to ask you to wait for me to finish the test to make sure it does not break anything.

Thank you very much!

Hi Elias, I've deployed a new patch version 0.3.2.
Hope this helps!

I have installed the new version and all is well, I appreciate your help and very fast action on this issue. You're the best!
Thanks :)

No worries. I'd appreciate if you can leave a star in the Github repo 🙏.


Update version listed in mapbook.xml from 2.6 to 2.8

Somehow we missed this last time...

We should update the process too... https://github.com/geomoose/geomoose-website/blob/master/source/developer/release.rst

I'm not sure if we should do this every release or not (although I agree
it is warranted for this release).
My understanding is the reason for having the version attribute in the
mapbook is so that we can potentially support older mapbooks with newer
GeoMoose releases (by invoking a compatibility mapbook parser).  But
that also means we should only update the version in the mapbook when it
has been changed so that it doesn't apply to older versions anymore.
On the other hand, a new x.y release (by semantic versioning)  is likely
to have new features that are added to the demo which would mean a
mapbook change, so this might be moot.
Thoughts?
On 08/31/2015 12:15 PM, Eli L Adam wrote:

We should update the process too... https://github.com/geomoose/geomoose-website/blob/master/source/developer/release.rst

Reply to this email directly or view it on GitHub:
https://github.com/geomoose/geomoose/pull/103#issuecomment-136432676

I do think we should stick to x.y versions (not x.y.z) in the mapbook as we aren't supposed to be introducing features or breaking changes in the .z bugfix releases.

Yeah - I wondered about that too. It's just that it is a bit confusing to users that our Mapbook numbering is so similar to our overall version numbering. I could see us having much lower numbers for Mapbook versions than for Geomoose versions (since Mapbook versions change less frequently).
I just happened to notice this today, and assumed it was an oversight as there are a few new Mapbook elements in 2.8 (related to popups) that wouldn't work in earlier versions if someone tried.

Agree with your x.y comment

I agree sticking to x.y (and not x.y.z).
For updating the process, we can add something to the effect, evaluate  <mapbook version="#.#"> so that it doesn't get overlooked or incremented for no reason.

+1
On 08/31/2015 12:38 PM, Eli L Adam wrote:

I agree sticking to x.y (and not x.y.z).
For updating the process, we can add something to the effect, evaluate  <mapbook version="#.#"> so that it doesn't get overlooked or incremented for no reason.

Reply to this email directly or view it on GitHub:
https://github.com/geomoose/geomoose/pull/103#issuecomment-136439013


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-extensions/serving-writers
/assign knative-extensions/serving-writers
Produced by: knative-extensions/knobots/actions/update-deps

/retest

Boilerplate fixed in https://github.com/knative-extensions/net-istio/pull/1342

/lgtm
/approve

/retest


WIP: fix #1817

Like the discussion said, the SQL query is not useful so basically decided to use the actual error codes "translation" and the error message, which should be sufficient. The new error will look something like:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-24-094c959462d3> in <module>()
      1 with TRN:
      2     TRN.add('SELECT * FROM bla')
----> 3     TRN.execute()
      4

/Users/antoniog/svn_programs/qiita/qiita_db/sql_connection.py in wrapper(self, *args, **kwargs)
    506                 "Operation not permitted. Transaction methods can only be "
    507                 "invoked within the context manager.")
--> 508         return func(self, *args, **kwargs)
    509     return wrapper
    510

/Users/antoniog/svn_programs/qiita/qiita_db/sql_connection.py in execute(self)
    755         """
    756         try:
--> 757             return self._execute()
    758         except Exception:
    759             self.rollback()

/Users/antoniog/svn_programs/qiita/qiita_db/sql_connection.py in _execute(self)
    702                     # We catch any exception as we want to make sure that we
    703                     # rollback every time that something went wrong
--> 704                     self._raise_execution_error(sql, sql_args, e)
    705
    706                 try:

/Users/antoniog/svn_programs/qiita/qiita_db/sql_connection.py in _raise_execution_error(self, sql, sql_args, error)
    647         raise ValueError(
    648             "Error running SQL: %s. MSG: %s\n" % (
--> 649                 errorcodes.lookup(error.pgcode), error.message))
    650
    651     @_checker

ValueError: Error running SQL: UNDEFINED_TABLE. MSG: relation "bla" does not exist
LINE 1: SELECT * FROM bla
                      ^

Codecov Report

Merging #2193 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   92.06%   92.05%   -0.02%
==========================================
  Files         191      191
  Lines       19581    19581
==========================================
- Hits        18027    18025       -2
- Misses       1554     1556       +2

Impacted Files
Coverage Δ

qiita_db/sql_connection.py
82.57% <100%> (ø)
:arrow_up:

...t/handlers/api_proxy/tests/test_sample_template.py
97.77% <0%> (-0.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f40cf...959d9b2. Read the comment docs.


DALI 1.32 build failure on container

Fixed by PR - https://github.com/open-ce/DALI-feedstock/pull/72


table-condensed doesn't work

Trying to use table-condensed on a table but it doesn't work ...

.table-condensed has been replaced by .table-sm in  6af528cd5a547c01102f96f164f4f5303be365ee


Add version: JetBrains.Kotlin.Compiler version 1.3.40

Pull request has been created with Komac v1.9.1 :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/116251&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Executable-Error


R API Package Tasks

Dropped the beginnings of the R package into the R-package branch.  This is just a brainstorming and task list issue for myself, @ssnn-airr, and any who wants to contribute. :)
TODO:

Unit tests. Use testthat.
Simple vignette. Use rmarkdown and knitr. (#120)
Build API doc. I plan to use markr. Need to see if the markdown import into sphinx is sufficient or if I need to add rst conversion to markr.
Document the package build process. Ie, regenerating the schema data objects from the yaml file and rebuilding the docs.
read/write functions probably need more validation checks.

Merged into master in #102.  Gonna leave the R-package branch in place for a bit though as a working branch.

I attempted to plug the markr output directly into the existing docs using recommonmark. It didn't go well.  I'm going to have to add a sphinx compatible implementation to markr. Which will be time consuming.
I think all we really have is docs and unit tests though, aside from making sure the small bit of validation code in there is okay. @ssnn-airr, are you okay with focusing on the unit tests and the vignette? And I'll deal with the sphinx docs?

Yes, very ok.

R library docs are up.

Last bit is done in #128.


test: add connect integration test

Codecov Report

Merging #13 (7804cf1) into main (091481d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          112       112
  Branches        29        29
=========================================
  Hits           112       112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091481d...7804cf1. Read the comment docs.


Why the default tasks in bootstrap.yml does not get executed when i run the 'make' command

I wonder why the following task from bootstrap.yml does not get executed:
   - name: Debug all env vars
      debug:
        var: ansible_env

When i run the make command, i expect to see the list of environment variables but the task never gets executed.
I would like to check if the nomad_acl is set correctly as now i end up getting the following error:
TASK [Terraform] ***************************************************************
fatal: [default]: FAILED! => {
    "changed": false
}

MSG:

Terraform plan could not be created
STDOUT:

STDERR:
Error: No value for required variable

  on variables.tf line 1:
   1: variable "nomad_acl" {

The root module input variable "nomad_acl" is not set, and has no default
value. Use a -var or -var-file command line argument to provide a value for
this variable.

I got the above code to work by creating this file terraform.auto.tfvars here: terraform-nomad-minio/example/terraform.auto.tfvars and added nomad_acl=false
Once i made the above changes, the minio job was created fine:
TASK [Terraform] ***************************************************************
ok: [default]

TASK [Terraform stdout] ********************************************************
ok: [default] => {}

PLAY RECAP *********************************************************************
default                    : ok=4    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

@fredrikhgrelland : Any thoughts?

I am not seeing this behavior. What line in bootstrap.yml and why are you changing that?

I am not seeing this behavior. What line in bootstrap.yml and why are you changing that?

I have the same. Just run ´make´
TASK [Running poststart books] *************************************************

PLAY RECAP *********************************************************************
default                    : ok=31   changed=13   unreachable=0    failed=0    skipped=17   rescued=0    ignored=0

==> default: Running provisioner: shell...
    default: Running: inline script
    default: /tmp/vagrant-shell: line 1: /vagrant/dev/vagrant/conf/post_ansible.sh: No such file or directory
==> default: Running provisioner: ansible_local...
    default: Running ansible-playbook...

PLAY [all] *********************************************************************

TASK [Gathering Facts] *********************************************************
ok: [default]

TASK [Include and run tasks] ***************************************************
included: /vagrant/dev/ansible/02_run_terraform.yml for default

TASK [Terraform] ***************************************************************
changed: [default]

TASK [Terraform stdout] ********************************************************
ok: [default] => {}

MSG:

nomad_job.nomad-job-minio: Creating...
nomad_job.nomad-job-minio: Creation complete after 0s [id=minio]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

The state of your infrastructure has been saved to the path
below. This state is required to modify and destroy your
infrastructure, so keep it safe. To inspect the complete state
use the `terraform show` command.

State path: terraform.tfstate

Outputs:

minio_service_name = minio

PLAY RECAP *********************************************************************
default                    : ok=4    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

 ~/src/github.com/zhenik/terraform-nomad-minio1  feature/draft-1 +4 !2

In my case Its printed after prestart-books

I can't see this behaviour either. Using make within a default test_template does print all variables.

I am not seeing this behavior. What line in bootstrap.yml and why are you changing that?

I have not changed the bootstrap.yml file. I ran the make command and I do not see the environment variables printed out:
k10145@u1804i-0718:~/git-repo/terraform-nomad-minio$ make
==> default: Checking for updates to 'fredrikhgrelland/hashistack'
    default: Latest installed version: 0.2.2
    default: Version constraints: >= 0.2, < 0.3
    default: Provider: virtualbox
==> default: Box 'fredrikhgrelland/hashistack' (v0.2.2) is running the latest version.
SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt CURL_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt CUSTOM_CA= vagrant up -vvvvv --provision
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'fredrikhgrelland/hashistack' version '0.2.2' is up to date...
==> default: Uploading root certificates to guest instance...
==> default:
==> default: -- /usr/local/share/ca-certificates/2040-MinervaRootCA.crt => /usr/share/ca-certificates/private/2040-MinervaRootCA.crt
==> default:
==> default: -- /usr/local/share/ca-certificates/minerva.loc.crt => /usr/share/ca-certificates/private/minerva.loc.crt
==> default:
==> default: -- /usr/local/share/ca-certificates/ske/ske-root-ca-2033-03-18.crt => /usr/share/ca-certificates/private/ske-root-ca-2033-03-18.crt
==> default:
==> default: -- /usr/local/share/ca-certificates/ske/MINERVA-2040.crt => /usr/share/ca-certificates/private/MINERVA-2040.crt
==> default:
==> default: -- /usr/local/share/ca-certificates/ske/CACertMinervaVer3.crt => /usr/share/ca-certificates/private/CACertMinervaVer3.crt
==> default:
Updating certificates in /etc/ssl/certs...

0 added, 0 removed; done.
Running hooks in /etc/ca-certificates/update.d...

done.

==> default: Running provisioner: shell...
    default: Running: inline script
    default: cp:
    default: cannot stat '/vagrant/vagrant/conf/hashistack/consul/99-override.hcl'
    default: : No such file or directory
==> default: Running provisioner: shell...
    default: Running: inline script
    default: cp:
    default: cannot stat '/vagrant/vagrant/conf/hashistack/vault/99-override.hcl'
    default: : No such file or directory
==> default: Running provisioner: shell...
    default: Running: inline script
    default: cp:
    default: cannot stat '/vagrant/vagrant/conf/hashistack/nomad/99-override.hcl'
    default: : No such file or directory
==> default: Running provisioner: ansible_local...
    default: Running ansible-playbook...

PLAY [all] *********************************************************************

TASK [Gathering Facts] *********************************************************
ok: [default]

TASK [Running prestart books] **************************************************
[WARNING]: Unable to find '/vagrant/vagrant/conf/ansible/playbooks/prestart' in
expected paths (use -vvvvv to see paths)

TASK [Verify default variables] ************************************************
included: /etc/ansible/default_vars.yml for default

TASK [set_fact] ****************************************************************
ok: [default]

TASK [set_fact] ****************************************************************
ok: [default]

TASK [set_fact] ****************************************************************
ok: [default]

TASK [Verify Consul ACL default policy] ****************************************
skipping: [default]

TASK [Start hashistack] ********************************************************
ok: [default] => (item=vault)
ok: [default] => (item=consul)
ok: [default] => (item=nomad)

TASK [Verify Consul ACL deny policy - access deny without token] ***************
skipping: [default]

TASK [Verify Consul ACL deny policy - access granted with correct token] *******
skipping: [default]

TASK [Wait for consul to start] ************************************************
ok: [default]

TASK [Wait for nomad to start] *************************************************
ok: [default]

TASK [Wait for vault to start] *************************************************
ok: [default]

TASK [Running poststart books] *************************************************
[WARNING]: Unable to find '/vagrant/vagrant/conf/ansible/playbooks/poststart'
in expected paths (use -vvvvv to see paths)

PLAY RECAP *********************************************************************
default                    : ok=9    changed=0    unreachable=0    failed=0    skipped=5    rescued=0    ignored=0

==> default: Running provisioner: ansible_local...
    default: Running ansible-playbook...

PLAY [all] *********************************************************************

TASK [Gathering Facts] *********************************************************
ok: [default]

TASK [Include and run tasks] ***************************************************
included: /vagrant/dev/ansible/run_terraform.yml for default

@Neha-Sinha2305 I see that you are running version 0.2.2, but env feature came in 0.3

Just to add to Nikita: that is because your Vagrantfile has a wrong version constraint default: Version constraints: >= 0.2, < 0.3

https://github.com/fredrikhgrelland/vagrant-hashistack/commit/e9f3a220998da65e4417b95325aadcb5552fb586
Newest version constraint was added in this commit

@Neha-Sinha2305 This can be closed, no?

yup!


delete cmsis rtos

delete cmsis rtos includes
change cmsis rtos to freertos functions where needed
delete cmsis rtos folder

we will not delete it because it always results in failed startup


Small fixes to v1 Migration Guide

Description: A couple of small formatting fixes to v1 Migration Guide.
Does this change impact docs?

[X] Yes, PR includes docs updates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.294%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
5997

Relevant Lines:
7563

💛  - Coveralls


Inject HTML templates in each section

A useful way to make each section modular is to use a for loop for HTML templates in each one.
For example, here the sphinx book theme uses a list of template paths to insert content into the sidebar:
https://github.com/executablebooks/sphinx-book-theme/blob/master/sphinx_book_theme/sidebar.html#L13
This one follows the sphinx pattern:
html_sidebars = {
  "**": ["path/to/template.html"],
  "page-specific-sidebar": ["path/to/template.html"],
}

but we could imagine having a similar config for other parts of the page and doing this at the theme level e.g.:
html_theme_options = {
    "announcement": ["components/demos/announcement-demo.html"],
    "header": ["components/demos/header-demo.html"],
    "sidebar_left": ["components/demos/sidebar-left-demo.html"],
    "sidebar_right": ["components/demos/sidebar-right-demo.html"],
    "middle_content": ["components/demos/middle-content-demo.html", "components/page-content.html", ],
    "footer": ["components/next-prev.html"],
}

Then to extend a section of the base theme, one would define sidebar templates and then just add them to the proper list in the configuration. Obviously if they needed to make major changes to a section, they might want to directly edit that template themselves, but I think this could be a lightweight way to extend sections without having to modify the base HTML.
Then this theme and any sub-themes would be a combination of two things:

sections are high-level groups of components in specific locations (e.g., sidebar-left, content-main, content-footer
components are templates that can be inserted into any section's component list via configuration variable.

WDYT?

I will try and put together a lightweight PR to describe what I mean

If you want this to work with your theme.conf (without needing Python code in a Sphinx extension), you can use this little trick I've come up with:
https://github.com/mgeier/insipid-sphinx-theme/blob/d945ea543137acec0d99bd34e581cfd65f0a5ab2/src/insipid_sphinx_theme/insipid/layout.html#L4-L10
If you know a better way, please let me know!

Ah very clever! I have added that here #8

Is this a suggestion for how to handle #2?
As I noted there, I really really really don't want to be using theme_options for this, because Sphinx allows end-users to customise those fairly easily and I don't want that knob accessible easily.
Why is this preferable to having blocks in the template that are overridden? It seems functionally equivalent to me, and if a downstream theme wants to provide those knobs it can. (I don't want Furo to, but it makes a lot of sense for SBT and pydata-sphinx-theme)

Why is this preferable to having blocks in the template that are overridden?

I am thinking of the perspective of a theme author. I want to have to write as little HTML templating as possible. The benefit of just providing lists of elements in your config is that you don't have to touch any HTML at the page level, you just provide a list of element paths. If you want to define a custom element and add it then you can just write a small HTML snippet in your theme's templates folder, and then refer to it in the theme's configuration. To me that's simpler than having to over-load a template file each time. But again, I am just exploring design space right now, not trying to make decisions.

because Sphinx allows end-users to customise those fairly easily and I don't want that knob accessible easily to end users

To me the question of whether it is in html_theme_options is an implementation detail - it could be in some other configuration as well it just seemed natural there to me. I'd think a theme author can always just not document what they don't want users to use. I don't think most users would ever realize that an option like this was available unless the theme author decided to document it. And IMO if something isn't documented, then users likely won't discover it + can assume no promises made about supporting it.

(AAAAAAAAAAAAAAAAAAAA, I'm doing walls of text)

And IMO if something isn't documented, then users likely won't discover it + can assume no promises made about supporting it.

Yes, but this breaks down when the number of users increase. 🙈
https://www.hyrumslaw.com/
And, in an ideal world, that'd be true for more than one of the themes that derive from this.

I am thinking of the perspective of a theme author. I want to have to write as little HTML templating as possible.

I'm thinking of this as a theme author who doesn't want to give his end users any powerful knobs, documented or undocumented. 🙃
I guess my expectation is that in the simplest case, theme authors would be writing a few files that basically are blocks-containing-a-bunch-of-includes / {{ toc }} and the CSS for these and no HTML basically.
I also feel like expecting a theme author to interact with the templates is OK (they have to write some anyway). To me, the point of this whole effort is to minimise the amount of that template writing that'd get duplicated across projects.

If you want to define a custom element and add it then you can just write a small HTML snippet in your theme's templates folder, and then refer to it in the theme's configuration. To me that's simpler than having to over-load a template file each time.

Hmm... To me, this kind of thing seems pretty straightforward with Jinja2 blocks as well:
I guess this is the sort of thing you'd do in something like elements/primary-sidebar.html with:
{% include "my-fancy-thing.html" %}

If you wanna do this in page.html for some reason, that's doable too!
{% block primary_sidebar %}
{{ super() }}
{% include "my-fancy-additional-thing.html" %}
{% endblock %}

But again, I am just exploring design space right now, not trying to make decisions.

Yup yup. I didn't mean to imply otherwise. I just feel strongly that we shouldn't use theme_options for exposing things to theme authors. Part of the reason behind that is that I've dealt with a lot of backwards compatibility pain, arising from users depending on undocumented things (or things clearly marked "don't use this"), and then getting strong pushback when those things change. :)
Even if it'll end up being a case of telling those users that it's not supported by the theme; it's still additional cost to be paid. And I think its a bit more than that as well, but that's the major one. (lack of consistency across documentation sites using said theme, potential for misuse due to create poorly designed structures etc come to mind)

yeah that is reasonable to me 👍 I understand your perspective about not complexifying the basic skeleton theme too much. Perhaps this is something that can be done at the sub-theme level


Is there any way to find whether test is passed or failed in After hook?

Current behavior

Is there any way to find whether running scenario is passed or failed in after hook class? (In previous Cypresss-Cucumber-Preprocessor, we can get the status from this command testState.runTests[testState.currentScenario.name][testState.currentStep] likewise do we have any way to achieve this here?)
Also do we have any possibility to get tag name of running scenario inside before hook class? (This is not possible in previous version asking whether its possible now?)

Desired behavior

Test code to reproduce

Versions

Cypress version:
Preprocessor version:
Node version:

Checklist

[x] I've read the FAQ.
[x] I've read Instructions for logging issues.
[x] I'm not using<EMAIL_ADDRESS>(package name has changed and it is no longer the most recent version, see #689).

I can't be the one to provide general support for every user, so you need to find somewhere else to ask these types of questions.


Bitbucket password encryption/decryption with special character (#)

I was getting a 401 unauthorized error with the Bitbucket collector. After doing more research, it appears the issue is due to a special character (#) in the password used.
I placed an additional log.debug statement in the DefaultBitbucketServerClient, right after the password decryption: decryptedPassword = Encryption.decryptString(repo.getPassword(), settings.getKey());
password: testpass#
2017-01-14 00:50:01,991 DEBUG c.c.d.collector.GitCollectorTask - {password=UKlOFa2bOkMoAJSkMI26bw==, scm=Bitbucket, branch=master, userID=testuser, url=https://git-qa.******.net/scm/devops/testhygieia.git}::master
2017-01-14 00:50:01,992 DEBUG c.c.d.c.DefaultBitbucketServerClient - Rest Url: https://git-qa.******.net/rest/api/1.0/projects/devops/repos/testhygieia/commits?until=master&limit=25
2017-01-14 00:50:01,994 DEBUG c.c.d.c.DefaultBitbucketServerClient - decryptedPassword: testpass

As you can see, the '#' is missing.

I bet the UI isn't base64 encoding the password when sent in. Special characters may thus be interpretted as http parameters.

I believe this issue is closed with PR #1651


New package: Padding v0.1.0

Registering package: Padding
Repository: https://github.com/paulxshen/Padding.jl
Created by: @paulxshen
Version: v0.1.0
Commit: 58bf5f717d67a396f1b193a459826a288a042db3
Git reference: HEAD

I still think ArrayPadding is better

Superseded by https://github.com/JuliaRegistries/General/pull/91460


fix: Return Task status, update docstrings

We should return something useful from checking a Task status. The most useful thing we have is the status result from the poller. Also, updating some old docstrings with more information.

Not seeing an issue here.


feat: ample sets in real vector spaces

From the sphere eversion project.

I have incorporated your comments.
awaiting-review

Good idea, added. Thanks for the reviews!
(I also added a few lemmas to ContinousAffineEquiv which hold for Equivs and are needed here. If this duplication can/should be reduced is a topic for another discussion, not today.)
bors r+