Horizontal flip of tilemap cell is not working as expected

Godot version:
3.1.1 official
OS/device including version:
Windows 10.0.17134 Build 17134
Issue description:
Horizontally flipping tilemap cell changes the position of the tile by half of its width
Steps to reproduce:
In the project attached below, notice that the light-green tilemap cell is not placed where it should be.  Remove horizontal flip and notice that it fits into place.
Minimal reproduction project:
hflip-tilemap.zip

Note: the bug happens only with isometric tiles.

Well, not only with isometric:
https://github.com/godotengine/godot/issues/22989
https://github.com/godotengine/godot/issues/28206
https://github.com/godotengine/godot/issues/15249
Problem is displacing textures with is not needed, a dessign problem, not easy fixable, i try and fail. This bug needs an expert programmer or directly reduz, because too many people touched in the past tile_map.cpp with different ideas about texture offset, origin point, etc... so... at the day, tilemap is a chaos and this kind of issue will be very recursive.

@reduz, @Ranoller suggests that tile_map.cpp may need a rewrite.  What do you think?


free cam as positional tracking?

hi,
i was thinking, like the gta vr mod,
could the free cam be mapped to a vr hmd?
to enable positional tracking?
this, coupled with the first person mod and a third party 3d program (vorpx, reshade, tridef etc.)
could lead to a very nice vr implimentation similar to RE7 on psvr

That would be awesome, I'd die for this game with some kind of VR support.

That would be awesome, I'd die for this game with some kind of VR support.

It seems it comming:
https://streamable.com/07xuh7

Oh man, if this is true ill be sooooo happy


IOU - Modal is shifted to the left when entering a long amount number

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to NewDot
Click on request money
Enter an amount of over 15 numbers

Expected Result:
Modal should stay on the visible area of the screen
Actual Result:
Modal is shifted to the left and button is not completely visible.
Workaround:
N/A
Platform:

Where is this issue confirmed?

Web

Version Number: 1.0.94-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
View all open jobs on GitHub

From @akshayasalvi https://expensify.slack.com/archives/C01GTK53T8Q/p1630779418448200

When I enter the 15 to 20 digits long amount in Request Money it goes out of the screen (amount is cut). Also, the button aligned is misplaced. Screenshot attached in the thread.

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposed Solution
If we know that we're going to have a max value for the amount then we should add a maxLength  property to the amount field. I added 14 and it worked fine. Then basically it didn't messed up the alignment of the the button as well.
<TextInputAutoWidth
   inputStyle={styles.iouAmountTextInput}
   ...
   ...
   ...
   value={this.state.amount}
   maxLength={14}
/>

15 digits would be 900 billion max, currently the richest person in the world is Jeff Bezos with an estimated 177 billion and while I do hope we eventually have Mr Bezos using expensify to settle up his IOUs I don't think 15-20 digit numbers are going to be super common use case here so I think I agree we should just add a maxLength attribute here and be done with it.

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

i don't think this needs to be a daily so once the job is created we could move this to weekly or monthly.

Maybe countries with high inflations might be affected by this, e.g Venezuela, currently 1$ is equal to 4.200.000 Bs. So having an IOU of 1000$ would be <IP_ADDRESS> Bs. It still doesn't reach the 14 digit mark so I agree with Bondy that this will not be a common issue.

Yeah that crossed my mind too but for the time being I believe IOUs can
only be in USD. Though something might have changed there that I might have
missed so if we think it might be more common then maybe style changes are
needed.
On Tue, Sep 7, 2021 at 11:39 AM Isabella Goicoechea <
@.***> wrote:

Maybe countries with high inflations might be affected by this, e.g
Venezuela, currently 1$ is equal to 4.200.000 Bs. So having an IOU of 1000$
would be <IP_ADDRESS> Bs. It still doesn't reach the 14 digit mark so I
agree with Bondy that this will not be a common issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/5115#issuecomment-914496907, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7CPCWA6WY7EUESXSY37JTUAZE6NANCNFSM5DRH7AJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Yeah that crossed my mind too but for the time being I believe IOUs can only be in USD

That's not correct. At the moment IOUs can be in any currency available in the currency list.

Considering that the issue is uncommon, I suggested the maxLength fix rather than the style change in the IOUModal and related child components.

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Posted to Upwork here: https://www.upwork.com/jobs/~013d0ec60b16212278
@deetergp looks like we have a proposal in this comment.

I agree that we can kick the can down the street on 15+ digit numbers for the time being. Let's go with @akshayasalvi proposal of just adding a max length of 14 digits.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Hey @akshayasalvi can you please propose to the job post in Upwork so I can hire you for this: https://www.upwork.com/jobs/~013d0ec60b16212278

@stephanieelliott Done. Thanks for the help.

🚀 Deployed to staging by @marcaaron in version: 1.0.97-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by @francoisl in version: 1.0.98-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.0.98-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pulls/5192\n- https://github.com/Expensify/App/pulls/5243\n

If no regressions arise, payment will be issued on 2021-09-27. :confetti_ball:

This message is a bug, caused by today's deploy and some weird GH API behaviour. Updated the title back to what it was 🙇

@stephanieelliott Is this payment on hold?

Was there a regression from this PR? If not, it should have been paid on 22nd September. Sorry for confusion because of the bot message 😬 @stephanieelliott

@stephanieelliott  @mountiny Still waiting for this one to get paid out.

Yikes, apologies @akshayasalvi, we are having a bit busy times so some tasks simply slip from our radar. I will ping someone!

Thanks for the quick response @mountiny. Any expected date, so that I don't have to ping you :P

@akshayasalvi I think someone will do it today for sure, I have pinged our team and there will be at least one one person with time to handle this. Sorry for the delay and we appreciate you patience 🙇

Scheduling payment now - sorry for the delay @akshayasalvi !

@dylanexpensify I received half the payment I guess. I reported + resolved the issue.

Ahh my apologies @akshayasalvi! One second

@akshayasalvi I think someone will do it today for sure, I have pinged our team and there will be at least one one person with time to handle this. Sorry for the delay and we appreciate you patience 🙇

Thanks @mountiny. Received help on this. :)

@akshayasalvi no no, you're all good!! I just sent over the bonus 😄

Thank you @dylanexpensify and @mountiny 😄


Add XRS to the archived data, optimize downloads and processing

Add XRS to the archived data, optimize downloads of goes and processing. Additionally removed trailing data points causing a drop off in plots.

Codecov Report

Merging #4 (08af4f3) into main (2f9886a) will increase coverage by 8.90%.
The diff coverage is 26.27%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   23.00%   31.91%   +8.90%
==========================================
  Files           7        7
  Lines         226      235       +9
==========================================
+ Hits           52       75      +23
+ Misses        174      160      -14

Impacted Files
Coverage Δ

supersid/vlfclient.py
21.42% <17.97%> (+5.72%)
:arrow_up:

supersid/run.py
45.71% <36.36%> (+17.58%)
:arrow_up:

supersid/config/config.py
100.00% <100.00%> (ø)

...upersid/geographic_midpoint/geographic_midpoint.py
25.71% <100.00%> (+2.18%)
:arrow_up:

supersid/archiver.py
51.51% <0.00%> (+21.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9886a...08af4f3. Read the comment docs.


OLS-780: fix double reconciliation on deployment creation

Description
This PR fixes the issue that when creating the application deployment, the operator immediately reconciles the just created deployment due to a difference in the readiness & liveness probes: the created deployment does not specify all fields and upon next even the comparison between desired deployment and the existing deployment differ in the probe specifications. For example the FailureThreshold field.
Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue # OLS-780
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[x] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

/hold

/unhold

/lgtm
/approve


Improve insight collector

What this PR does / why we need it:
Change the insight collector logic to reduce communication with datastore.
Which issue(s) this PR fixes:
Fixes #1314
Does this PR introduce a user-facing change?:

NONE

@sanposhiho Hi, thanks for your great work!
I have just left some comments. Please take a look.

@sanposhiho Hi, thanks for your great work!
I have just left some comments. Please take a look.

@nghialv
Thanks for your reviews, fixed them :D

@nghialv
Thanks for your reviews, fixed them :D

Yep, looks neat 👍
/lgtm

Yep, looks neat 👍
/lgtm

@sanposhiho Thanks for your updates. Could you take a look at my recent reviews?

@sanposhiho Thanks for your updates. Could you take a look at my recent reviews?

@sanposhiho Many thanks for your efforts.
Looks good.
/approve

@sanposhiho Many thanks for your efforts.
Looks good.
/approve


Fallback to org.flatpak.Builder if host flatpak-builder is not found

Tested with either case.

no-unnecessary-condition lint uncovers a lot of bugs


0.4.1 release to fix missing import?

Hello, I believe the missing import issue fixed in  [6a1f4304964df6fb1c880ad02d2530a6d5b805a6] warrants a 0.4.1 release.  As far as I can tell, this affects the 0.4.0 release, preventing the fetching of emails.  I'm currently working around by pulling directly from stable in git instead of the pypi release.

Yep, @ilikerobots the 0.4.1 release has been tagged and put on pypi.


Large object support

[x] OID datatype support
[x] function call support
[ ] function cache
[ ] upload stream API
[ ] download stream API

started to contribute in this branch : https://github.com/vietj/reactive-pg-client/tree/blob-support

it seems actually we don't need function call support and we can rather reuse prepared statement which simplifies the implementation

large object is really something aside tables (https://www.postgresql.org/docs/9.2/static/largeobjects.html) and I'm whether the API should be oriented to be like a file system to manipulate streams keyed by OID and then the developer should use OID when referencing them in tables.

cc @pmlopes @EmadAlblueshi

cc @Sanne : any opinion on this ?

There are 2 kinds of large objects, the external files that you need to track the OID as you described and the type bytea which is stored on the table itself. They both have their use cases but usually should behave the same from a API perspective.

I don't think they should have the same API because you don't consume/produce them the same way, small one have to be handled as Buffer (a stream is overkill and anyway the bytes are fully loaded when decoding the row), other are usually stream oriented and can be seeked.


Better style picker

This changes the functionality of the generator style-picking UI to allow for preferences such as invertibility (#589).
It also eliminates the intermediate 'edit' state from this UI for simplicity.

Amazing!
Just a few comments:

can we move invertibility to the top,
can we make the whole region around the text/checkbox clickable
is it possible to disable the checkbox on certain generators (e.g. 0-generators)?

No problem, shouldn't take long...

Sorry I broke your branch :(

I've pushed a fix for these features.
This removes the invertibility option entirely from 0d generators. If preferred, I can change to keep displaying but disable input.

Brilliant, thanks Jasper!
I think it's better to remove the checkbox, rather than disabling it.

Great


Different actors when using a frontend proxy and different backend systems

Hi all!
I found an issue when using django-auditlog for multi-service environments. I think it may be interesting to identify the best way to support this.
Usually the frontend acts as a proxy for other backends which could query the database and modify the data. As its  the middleware does not support this, and you cannot audit the real user who is requesting to modify the data. You'll only get the user which is used between services (for service connections). Here is an example to make it easier:

As you can see in the image, I think it's common that between services they use their own credentials but never they 'll use the user credentials and it's the end user who should really be audited.
**first idea that surely is not the best: Maybe we should add one field to the LogEntry model (something like "author") to be able to pick it up from the request header to identify the end user .

Thanks for answer!
This could work if the user data is shared between apps and user exists.
As its my case (perhaps in many others) the authentication is not shared, I mean, the user doesn't exist in the backend service (only for the frontned app and auth app,  the rest of the services use tokens for authentication) then the foreign key of the model LogEntry would not allow call set_actor(user) with a user that doesn't exist.
Is there a way to allow this or should I extend the library for my case? Thanks!

@dalvgui, I assume SomeModel.get_additional_data() method isn't helping as well because the extra data you want to capture is an attribute of the API request, not an attribute of a model being updated?

Great, I didn't see the field LogEntry.additional_data, then I can fix my problem. If it helps others, for adding extra information,  I'm using a extra middleware.py and context.py  (inspired of these middleware.py & context.py). Finally with them, I add my own data to LogEntry.additional_data field.

Yes, the LogEntry.additional_data is not documented. we have an issue documenting it https://github.com/jazzband/django-auditlog/issues/454.


graph/network: add heat diffusion propagation function

@btracey @vladimir-ch Please take a look.

The python implementation gives me values that agree with the test expectations with increasing divergence as t increases (this is how I found the Exp behaviour), e.g. for the t=0.1 case:
{(0, 0): 0.82668405458647332,
 (0, 1): 0.07854806046143345,
 (0, 2): 0.0038588395017377115,
 (0, 3): 0.00012748739572128364,
 (0, 4): 3.2332177780049904e-06,
 (1, 0): 0.07854806046143345,
 (1, 1): 0.0074633081018349642,
 (1, 2): 0.00036665078612781686,
 (1, 3): 1.2113319002137123e-05,
 (1, 4): 3.0720682720649926e-07,
 (2, 0): 0.0038588395017377115,
 (2, 1): 0.00036665078612781686,
 (2, 2): 1.8012494879461547e-05,
 (2, 3): 5.9509240060162579e-07,
 (2, 4): 1.5092184747326786e-08,
 (3, 0): 0.00012748739572128364,
 (3, 1): 1.2113319002137123e-05,
 (3, 2): 5.9509240060162579e-07,
 (3, 3): 1.9660517192302685e-08,
 (3, 4): 4.986119086589226e-10,
 (4, 0): 3.2332177780049904e-06,
 (4, 1): 3.0720682720649926e-07,
 (4, 2): 1.5092184747326786e-08,
 (4, 3): 4.986119086589226e-10,
 (4, 4): 1.2645335472922438e-11}

I need to check the normalised case - the python reproducer is at home, so I'll do that after work.

Symmetric normalized Laplacian implementation results also confirmed with the python implementation (within an error probably due to our exp).

A consideration here is whether it would be better to provide an exp function here that takes the Laplacian (this would need to be a struct holding the matrix and the look-up map) and then also provide two functions (at least one more later - the random walk Laplacian) to generate the Laplacian and Symmetric normalized Laplacian. I think this might be nicer.

Perhaps Diffuse(Laplacian(g), h, t) or Evolve(Laplacian(g), h, t) might be indeed nicer.

Of these I'd prefer Diffuse(h map[int64]float64, by Laplacian, t float64) map[int64]float64. I'll wait for other input.

I can try to take a look tomorrow

I won't be able to give it a fair look before the weekend, sorry.

The API of HeatDiffusion looks good. The only thought I had was that the key of h is implicitly documented in the last sentence, rather than explicitly documented that it is node IDs. This is fine though, and perhaps preferable as the last sentence also covers corner cases where node IDs are present in h but not g, and vice versa.
Great work on this! Will be fun to model some epidemic spreads :) Perhaps implement a more advanced version of the board game pandemic.

@mewmew I'm wondering about relative merits of the current API and the alternatives where there are Hermitian generating functions.

To expand, there is at least a third Hermitian that I want to be able to diffuse, the random walk Hermitian, though this is usually done to equilibrium. The two API options give us either the function we have and a random walk diffusion, or alternatively two diffusion functions (one timed and one with a tolerance for termination) and three (or more) Hermitian functions (of these 6 products, 3-4 are useful).

I think that having separate functions to create some of the possible variants of the graph Laplacian is most useful. A user could want to look at its eigenvalues, for example. Then there would be functions to apply a (Laplacian) operator, just as you suggest.
I'm delighted by this PR and by the possibilities it opens. On one hand it touches on PDEs (because it is related to the heat equation du/dt = D∆u), on other hand it is related to discrete geometry of 3D surfaces, both being areas of my (past) research interest. Random walks seem to be also connected but I'm not familiar with random processes. All in all, it's pleasing for me to see an interest and activity in these areas in Gonum.

I'm delighted by this PR and by the possibilities it opens. On one hand it touches on PDEs (because it is related to the heat equation du/dt = D∆u), on other hand it is related to discrete geometry of 3D surfaces, both being areas of my (past) research interest. Random walks seem to be also connected but I'm not familiar with random processes. All in all, it's pleasing for me to see an interest and activity in these areas in Gonum.

Yeah, this addresses a research problem I have been thinking about for a few years; I bumped into the paper and realised it comes close to answering the problem I had (the random walk L is closer).

I have revised the API. The Laplacian type exports its fields to allow users to write their own Laplacian construction functions - this is important because of the multiple ways a directed graph's Laplacian can be defined. I think it's best to just provide the basic undirected case and let others modify the input to their liking.
PTAL

I've had a go at the random walk diffusion and I'm obviously missing something. The algorithm I implemented is a loop of v <- Lv while the step's vector norm is above a tolerance. This won't work for the standard Laplacian since the diagonals are non-unit, but it should work for the random walk. I'll leave this for a while. @vladimir-ch if you find some time to look into that, that would be very helpful.

I think that in the iteration v <- Lv the matrix L is the transition matrix T := D^{-1} A and not I-D^{-1} A which is what NewRandomWalkLaplacian currently returns. I'm not versed in random walks on graphs but you could try that.

I think that in the iteration v <- Lv the matrix L is the transition matrix T := D^{-1} A and not I-D^{-1} A which is what NewRandomWalkLaplacian currently returns. I'm not versed in random walks on graphs but you could try that.

Yeah, I mis-wrote in the comment, I was actually doing v <- v - Lv. I think the issue is fixed.

This is ready. PTAL

ping

PTAL

The code mostly looks good to me, but I'll leave it to you and @vladimir-ch to decide the best locations. My two cents would be that it feels like Laplacian is generic enough to be at the top level, but I don't have strong opinions

I've heard talks using these subjects, but I haven't had to implement or use them directly before, so I don't have the benefit of experience

I'm going to leave this for a bit, the comment from @vladimir-ch https://github.com/gonum/gonum/pull/292#discussion_r151743905 looks like it's a valuable idea, but I'm unclear of the details (I'd be happy to have Laplacian in graph. When you have time, can you sketch it out a bit more and I'll look into it.

With that comment I meant something like this:
package graph

type Laplacian struct {
	mat.Symmetric // or mat.Matrix
}

func NewLaplacian(g Undirected) Laplacian {
}

func NewSymNormLaplacian(g Undirected) Laplacian {
}

type TransitionMatrix struct {
	mat.Matrix // All columns sum to 1.
}

func NewTransitionMatrix(g graph.Graph) TransitionMatrix {
}

package network

// h is a general scalar field on the graph defined by the Laplacian.
func Diffuse(dst, h map[int64]float64, by graph.Laplacian, t float64) map[int64]float64 {
}

// h is a probability vector.
func RandomWalk(dst, h map[int64]float64, with graph.TransitionMatrix, tol float64, iters int) (eq map[int64]float64, ok bool) {
	for {
		// ...
		v, lastV = lastV, v
		v.MulVec(by.Matrix, lastV)
		// ...
	}
}

With this the importing of graph would bring the whole of mat and therefore lapack which we may want to do only in the more specialized sub-package like network.
Also, the distinction between TransitionMatrix and Laplacian may not be that beneficial. The usual transition matrix T is similar to the normalized Laplacian, so they have the same eigenvalues. Since the Laplacian is symmetric, it has real eigenvalue and so does T although it is not symmetric.
In short, this PR is ok as it is, my thoughts are documented and we can return to them if necessary.

Thanks for the detail.


feat: support SourceMap mapping

The source map doesn't map to generated object literal after transformed. We should update the source map range after transformation.
Original:

After this PR

Codecov Report

Merging #1 (c199216) into main (7c89ebd) will decrease coverage by 25.42%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##             main       #1       +/-   ##
===========================================
- Coverage   94.39%   68.96%   -25.43%
===========================================
  Files           2        2
  Lines         107       87       -20
  Branches       45       22       -23
===========================================
- Hits          101       60       -41
  Misses          6        6
- Partials        0       21       +21

Impacted Files
Coverage Δ

src/transform.ts
71.11% <85.71%> (-20.00%)
:arrow_down:

src/utils.ts
66.66% <100.00%> (-30.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c89ebd...c199216. Read the comment docs.


Create Axes2D from scratch

In the document for Axes it says
"The axis is just a scene object, making it easy to manipulate and share between plots. Axis objects also contains the mapping you want to apply to the data and can interactively be changed. An Axis object can be created from any boundingbox and inserted into any plot."
Is there an example of how to do that? In other words, how can I, starting from an empty scene, add Axes2D objects to it? What I have in mind in something like this (pseudocode)
scene = Scene()
ax1 = Axes2D!(scene, boundingbox1, args...)
ax2 = Axes2D!(scene, boundingbox2, args...)

where I boundingbox1/2 would expressed in raw pixels (or fraction of the scene, or something else fancy). This would make manual layouting easier, until something automatic is created, ala matplotlib's subplot.

While this could work in theory, it doesn't work very well... Did you see: https://simondanisch.github.io/ReferenceImages/gallery//layouting/index.html

Yeah, I've seen that, it is close to what I want, and I've been using that approach with some success. However, as I mentioned in #183, I'm struggling to get text to be the same size, and in general aligning different axes. I thought perhaps if I could manually create the axes, that should work. I'll just wait until something else comes along : ) In meantime, is there a way to manually set camera and such and tell Makie never to change it? I was playing around with some code, and I managed to override the camera settings to make the axes align nicely, but then once the scene was redrawn, things got a bit messed up. I'll see if I can find the code to post here.

scene.center = false

Thanks! Just got a chance to try this out. So I guess my strategy for now is to manipulate the camera controls myself and set scene.center to false.


Features available for iframes are not the same as the ide by default

canCopy and canDownloadCsv options are false by default for iframes, as opposed to true by default for the ide. Ideally, there should be parity between the defaults between these use cases.

It looks like this can be worked around by setting a query parameter http://localhost:10000/iframe/table/?name=parquet_table&canDownloadCsv, but I consider this an anti-feature wrt the original intentions (the idea was that the server should control whether or not this is enabled). I think we should get rid of allowing the value to be set by query param (in addition to having the same defaults as ide).


review of cross-concepts in PRGOV and PURPM

we were just discussing the station use in underwater noise and it was difficult to explain the concept of Program Governance and Purpose of monitoring as it seems we are mixing concepts
PURPM https://vocab.ices.dk/?ref=1473
PRGOV https://vocab.ices.dk/?ref=42
For example, HELCOM COMBINE, MSFD or OSPAR CEMP are the monitoring programmes (PRGOV), and the purpose PURPM could be underwaternoise, D11 etc. At the moment we have values that confuse this:
PRGOV:
HELCOM Continuous Underwater Noise monitoring
Marine Strategy Framework Directive - Descriptor 10 Litter
So we need to review and disentangle i'm afraid.

I agree that these are not very consistent. Would be great to clean it up as it also complicates the station allocation for assessments. So note that changing PRGOV and PURPM likely requires modifications in these procedures as well

for PRGOV:

MSFD-10
Marine Strategy Framework Directive - Descriptor  10 Litter
PRGOV
False
2017-04-03
2021-09-01

MSFD-8
Marine Strategy Framework Directive - Descriptor  8 Contaminants
PRGOV
False
2021-03-18
2022-10-21

MSFD-9
Marine Strategy Framework Directive - Descriptor  9 Contaminants in seafood destined for human consumption

	Marine Strategy Framework Directive - Descriptor 9 Contaminants in seafood destined for human consumption
@Osanna123 to take a look at which stations are using these labels; and cross-check that it matches PURPM. And then report back

Change to MSFD in PRGOV - and in the "purpose of monitoring" the descriptors (8,9,10)

Added PURPM to selection criteria in the station dictionary widget.

PURPM L to change the description to D10

@Osanna123 what is the status of this, and can we close this issue?


istioctl: fix pc secret performance issue

Please provide a description of this PR:
fix https://github.com/istio/istio/issues/53931

@my-git9: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
8fd4aaa197780952d1c4313c3d235872b00c1bb1
link
unknown
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


receive: memory spikes during tenant WAL truncation

Thanos, Prometheus and Golang version used:

thanos, version 0.34.1 (branch: HEAD, revision: 4cf1559998bf6d8db3f9ca0fde2a00d217d4e23e)
  build user:       root@61db75277a55
  build date:       20240219-17:13:48
  go version:       go1.21.7
  platform:         linux/amd64
  tags:             netgo

Object Storage Provider: GCS
What happened:
We have several prometheus instances remote writing to a set of 30 receivers. The receivers normally hover around 8GiB of memory, but once every 2 hours the memory spikes up across all receivers at the same time by roughly 20-25%.

And the corresponding WAL truncations across all receivers.

There are other memory spikes that I'm not certain the root cause, like at 6:30 and 9:07. But looking at receiver memory usage over the past 2 weeks, there are consistent spikes when tenant WAL truncations happen.
What you expected to happen:
No memory spikes during WAL truncation, or the ability to stagger when truncation happens.
How to reproduce it (as minimally and precisely as possible):
Unsure, I'm running a fairly standard remote-write + receiver setup. I've raised this in the CNCF Slack and at least one other person has observed the memory spikes as well.
Full logs to relevant components:

Anything else we need to know:

This seems to coincide with intervals when head compaction happens. I think this process acquires a write lock and pending samples pile up in memory. @yeya24 do you see something similar in Cortex?

This seems to coincide with intervals when head compaction happens. I think this process acquires a write lock and pending samples pile up in memory. @yeya24 do you see something similar in Cortex?

Just confirming the compactions happen at the same time as the memory spikes

did you get context deadline exceeded (500)  from ingestors during the WAL compaction?

Cortex and Mimir solve this by adding jitter between compaction for different tenants. We can disable automatic compaction in the TSDB and manage it ourselves.

IDK if is applicable to thanos as well, but we recently added the jitter by AZ so we make sure only 1 az is performing head compaction - and as we replicate in quorum the data the overall latency is not affected. https://github.com/cortexproject/cortex/pull/5928

We are also seeing OOM when thanos receive pod restarts, because of surge of # gorountines and go_sync_mutex_wait_total_seconds_total.
We did a profile and found it stuck at acquring lockf or creating new since we suppose that it needs to build reverse index from scratch after thanos receive restart, causing lock contention.
We think this https://github.com/prometheus/prometheus/pull/13642 would fix the issue and we should accelerating pushing to merge this into prometheus.

Compaction times are now randomized but it's still visible - not just in memory usage but also increased write latency


RFID code confsuion

This very well may not be needed, but I would say the most confusing part of the code is understanding how the Chest reads the RFID card. The rest of the code (because of your clean layout and great variable names) are easy enough to understand for anyone who has worked with arduinos. But as someone who had never coded with an RFID card I could only guess at how things were working. Perhaps an extra comment or two about how the Code is handling reading the RFID number could help new programmers work on this code in the future.

Thank you for the suggestion! I will add in some more comments and elaborate on which parts read from the sensor.


Improve errors

Note: You might want to ignore whitespace while checking the diff for 'Check for SAML signature presence', as it's mostly an indentation change.

Other than that one minor comment this looks great

Closed because it needs to be merged to main, not inline_certs.


"initial-scale" rendered as a meta tag attribute in html output.

See screen shot below. This is likely a wml issue.

Upstream issue, closing this.


drain script shouldn't fail when there is a stale HAPRroxy pid in pidfile

We encountered an issue during deployment phase. Bosh filed to drain on canary VM.
Task 6224192 | 23:51:20 | L executing pre-stop: ha_proxy_z2/16e2782c-adcd-4e88-b5b4-e064c9911c57 (0) (canary)
Task 6224192 | 23:51:20 | L executing drain: ha_proxy_z2/16e2782c-adcd-4e88-b5b4-e064c9911c57 (0) (canary) (00:00:03)
                        L Error: Action Failed get_task: Task b5e5ccc7-02af-4fc6-508c-f31d95f95749 result: 1 of 2 drain scripts failed. Failed Jobs: haproxy. Successful Jobs: syslog_forwarder.
Task 6224192 | 23:51:22 | Error: Action Failed get_task: Task b5e5ccc7-02af-4fc6-508c-f31d95f95749 result: 1 of 2 drain scripts failed. Failed Jobs: haproxy. Successful Jobs: syslog_forwarder.

Task 6224192 Started  Tue Aug 23 23:50:51 UTC 2022
Task 6224192 Finished Tue Aug 23 23:51:22 UTC 2022
Task 6224192 Duration 00:00:31
Task 6224192 error
Updating deployment:
  Expected task '6224192' to succeed but state is 'error'

Exit code 1

[bosh][INFO] Deprovisioning client 'd.haproxy.deploy.9b17b2'...
error: lifecycle 'deploy' for deployment 'haproxy' failed in action 'deploy'. Action output (can be empty):

exit status 1

After running investigation on the canary VM, we noticed that the drain script fails because the file /var/vcap/sys/run/bpm/haproxy/haproxy.pid still exists and non empty.
The script checks the existence of the pidfile and reads its content then kill the child process that belongs the PID read from the pidfile.
As the file exists and not empty, haproxy_wrapper_pid=$(pgrep -P "$pid" haproxy_wrapper) fails with exit code 1 (process doesn't exist), which makes fail the script.
With the fix we propose, haproxy_wrapper_pid=$(pgrep -P "$pid" haproxy_wrapper || true), awe handle the case of a crashed haproxy_wrapper parent process when its pidfile still exists.

Hi @kecirlotfi , please try rebasing this to the current master, we had some issues with the CI which should be good now!

@kecirlotfi please keep this in Draft state until you're ready for it to be reviewed.


python: script to build python package

This is a quick POC to build the python script, it seems to work. The only problem I see is that the version number of the python package is taken from the rust package, and not from the python one. This is a problem as python packages have their own versions on pypi and we need to keep them separate.

Interesting, this is https://github.com/PyO3/maturin/issues/2163 and I don't see any good workaround. What we could do is hard-code the --version of the CLI instead of it being automatically built by clap and modify the Cargo.toml version during build (like we do for the README). This is ugly but would unblock the situation. What do you think?

 :-)
Instead of hardcoding the version, we could also patch the appropriate rust files as part of the build script?
To make things worse, the version of the python package is computed at run time (pyproject.toml is setup for "dynamic" version => the build system takes the version from well-known python variables, such as magika.__version__ in our case).
Anyways, it would be nice to contain all the ugly parts in a specific place, and to keep as much as possible clean. So we could aim at keeping the codebase clean, and stashing all the bad stuff in a build script.
Now, if we go forward with something like this, is it clear to you how would the full build / publish package look like?
Things were much simpler in the past: I would build the package on my machine, and then publish it myself to pypi. Now, with the multiarch support for the rust binary, I guess the plan is to use gh actions to build the various versions of the package; gh actions would then produce some artifacts; and then? do we already know what's the well-lit path to publish the various wheels?
/cc @invernizzi

The problem of using a hack is that it needs to work on Windows too, so it probably needs to be a Rust (or Python) program and not a shell script. But otherwise, I think it's possible to do the following:

Replace the CLI --version with Cargo.toml:package.version
Replace Cargo.toml:package.version with __init.py__:__version__
Delete the CLI README
Build
Restore README.md and Cargo.toml

The problem of using a hack is that it needs to work on Windows too

Do we need this because we need to compile the rust binary for a windows env as well? I thought the complications were due to the different architectures (x86, arm, etc.), rather than OS?
Anyways, I'll rewrite it in python, it's not a super trivial script anymore.

Do we need this because we need to compile the rust binary for a windows env as well?

Yes, but that's not enough to explain why the script needs to work on Windows, because we could cross-compile. The reason we don't cross-compile is because of Maturin (I expect the ort crate to support cross-compilation correctly but didn't test either). Maybe there's a way to make it work but that's probably easier to have a portable script and keep the Maturin setup closer to what they assume.

Almost done, two questions in the meantime:

in https://github.com/google/magika/pull/702#issuecomment-2363200374, the first step is Replace the CLI --version with Cargo.toml:package.version: can you confirm this will happen within the rust codebase?
after I patch Cargo.toml, uv build complains with: error: the lock file /magika-github/rust/cli/Cargo.lock needs to be updated but --locked was passed to prevent this. Which command should I run to update the lock file? and, is it safe to do so?

in python: script to build python package #702 (comment), the first step is Replace the CLI --version with Cargo.toml:package.version: can you confirm this will happen within the rust codebase?

No, it's the script. You essentially need to change this line:
https://github.com/google/magika/blob/5f07dd1f6b3179bb31b75bbe538dcfddca548853/rust/cli/src/main.rs#L64
to something like this (where the version is taken from Cargo.toml:package.version):
        let binary = "0.1.0-rc.0-dev";

Feel free to change the initial line to prevent modifications:
        let binary = clap::crate_version!(); // keep in sync with python build script

after I patch Cargo.toml, uv build complains with: error: the lock file /magika-github/rust/cli/Cargo.lock needs to be updated but --locked was passed to prevent this. Which command should I run to update the lock file? and, is it safe to do so?

It should be enough to run cargo check from the rust/cli directory.

Success!
Now the resulting python package has the correct version, and the magika rust binary has its own (correct) version as well.
I'll wait for your quick review before merging, thanks!


refactor: remove DB generic

Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
The DB generic is redundant as no other type will ever implement StorageApi in Xline. This change aims to enhance readability of the codebase.

what changes does this pull request make?

are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Though xline currently has only one StorageApi impl，the generic is make sense for the community if someone want to use another storage engine.

The engine crate already provides a level of abstraction, I think introducing the StorageApi would be redundant.

If we remove the DB generic here, is it necessary to keep StorageApi trait?

removed


CAMEL-11446: Use awaitility in camel-core for testing where we otherw…

…ise use thread sleep which can be speeded up.
Great to see this getting done. :+1:
While looking at the code I noticed some places where is is possible to slightly reduce code by using additional awaitility features.

Thanks, keep them coming

Thanks for the PR it has been merged. Do you mind closing this?

Thanks for merging!


GitHub Actions CI

Similar to https://github.com/Gabriel439/nix-diff/pull/37
All green https://github.com/sorki/Haskell-Nix-Derivation-Library/actions/runs/671109680

I removed .travis.yml as well, then decided to not commit it since it's still working and then it slipped thru git commit -a --fixup.

@sorki: Thank you! 🙂


Add 1.1.3 schema

Closes #11.

@estivate Could you also upload a new crates.io version, please? (It might also be worth updating the version in the README.)

@aleokdev The Bevy example isn't working, will try a bit longer to fix that but might remove it for now so we can update.


Solar System

Issue Assigned #55
Screenshots:

Demo Video:
https://github.com/Git21221/IBMSkillsBuild/assets/98798977/31f3a5cd-22c7-49fc-a42b-20c96e443703

@Durgesh4993 I said what? when?

And said to make it 3d like

@Git21221 could you merge it

@Durgesh4993 I thought you are going to add something else...this is already in your website

you can check it


Finish: Feature/create animals table

Dear Reviewer,
This pull request adds the necessary SQL code to create and populate the vet clinic database, as per the project requirements. The project involves setting up a database named vet_clinic and creating a table named animals. It also includes inserting sample data and writing SQL queries to retrieve specific information from the database.
Changes Made

Created the vet_clinic database.
Created the animals table with the specified columns: id, name, date_of_birth, escape_attempts, neutered, and weight_kg.
Added the SQL schema code to the schema.sql file.
Inserted sample animal data with various attributes into the data.sql file.
Wrote SQL queries to fulfill the provided quests.
Added the SQL queries to the queries.sql file.
Captured screenshots of the query results.

Screenshots
Find all animals whose name ends in "mon".

[x] Find all animals whose name ends in "mon".

List the name of all animals born between 2016 and 2019.

[x] List the name of all animals born between 2016 and 2019.

List the name of all animals that are neutered and have less than 3 escape attempts.

[x] List the name of all animals that are neutered and have less than 3 escape attempts.

List the date of birth of all animals named either "Agumon" or "Pikachu".

[x] List the date of birth of all animals named either "Agumon" or "Pikachu".

List name and escape attempts of animals that weigh more than 10.5kg

[x] List name and escape attempts of animals that weigh more than 10.5kg

Find all animals that are neutered.

[x] Find all animals that are neutered.

Find all animals not named Gabumon.

[x] Find all animals not named Gabumon.

Find all animals with a weight between 10.4kg and 17.3kg (including the animals with the weights that equals precisely 10.4kg or 17.3kg)

[x] Find all animals with a weight between 10.4kg and 17.3kg (including the animals with the weights that equals precisely 10.4kg or 17.3kg)

This pull request is ready for review. The provided SQL code has been tested debugged and verified to fulfill the project requirements.
Note:
After the debug the latest changes in queries.sql line: 22 and 27 are not showing in the files changed section of this Pull Request.
But you can check the changes in the last commit: commit# cc1b04a82363de1df6a7a5136b6549da2f45d26b
Please kindly review and provide your feedback.
Regards,
@Zafron047

Thanks a lot @thecodechaser for your review. 😄


Remove signature.v parity before calculating tx hash

Motivation
I noticed that TxEnvelope::encode/decode didn't produce the same TxEnvelope. The difference was the hash only.
I fixed the issue for TxEip1559, TxEip2930, TxEip4844, TxEip4844WithSidecar and TxEip4844Variant.
Context
Fixes: https://github.com/alloy-rs/alloy/issues/539
Related to: https://github.com/alloy-rs/alloy/pull/150

I noticed that TxEnvelope::encode/decode didn't produce the same TxEnvelope. The difference was the hash only.

can you provide a minimal repro of this so we can be sure we understand the observed behavior?

Sure! My minimal repro is very close to unit tests, except I used LocalWallet to get a signature for tx. You can observe the incorrect behavior by reverting my changes and running tests.
Revert:
diff --git a/crates/consensus/src/transaction/eip1559.rs b/crates/consensus/src/transaction/eip1559.rs
index d195edb9..729d811b 100644
--- a/crates/consensus/src/transaction/eip1559.rs
+++ b/crates/consensus/src/transaction/eip1559.rs
@@ -308,13 +308,13 @@ impl SignableTransaction<Signature> for TxEip1559 {
         // Drop any v chain id value to ensure the signature format is correct at the time of
         // combination for an EIP-1559 transaction. V should indicate the y-parity of the
         // signature.
-        let signature = signature.with_parity_bool();
+        // let signature = signature.with_parity_bool();

         let mut buf = Vec::with_capacity(self.encoded_len_with_signature(&signature, false));
         self.encode_with_signature(&signature, &mut buf, false);
         let hash = keccak256(&buf);

-        Signed::new_unchecked(self, signature, hash)
+        Signed::new_unchecked(self, signature.with_parity_bool(), hash)
     }
 }

Failed test:
---- transaction::envelope::tests::test_encode_decode_eip1559_parity_eip155 stdout ----
thread 'transaction::envelope::tests::test_encode_decode_eip1559_parity_eip155' panicked at crates/consensus/src/transaction/envelope.rs:478:9:
assertion `left == right` failed
  left: Eip1559(Signed { tx: TxEip1559 { chain_id: 1, nonce: 2, gas_limit: 5, max_fee_per_gas: 3, max_priority_fee_per_gas: 4, to: Call(0x0000000000000000000000000000000000000006), value: 7, access_list: AccessList([]), input: 0x08 }, signature: Signature { inner: ecdsa::Signature<Secp256k1>(840CFC572845F5786E702984C2A582528CAD4B49B2A10B9DB1BE7FCA9005856525E7109CEB98168D95B09B18BBF6B685130E0562F233877D492B94EEE0C5B6D1), v: Parity(true), r:<PHONE_NUMBER>7604526217550949535444980007647751110991992555989432467883920033125, s:<PHONE_NUMBER>8048845831134990513685258884275296176139135115431336905099564136145 }, hash: 0xbd9e80b9d3c7027f149869eff2037c2e3ec8045c007ff4819522f67538246e90 })
 right: Eip1559(Signed { tx: TxEip1559 { chain_id: 1, nonce: 2, gas_limit: 5, max_fee_per_gas: 3, max_priority_fee_per_gas: 4, to: Call(0x0000000000000000000000000000000000000006), value: 7, access_list: AccessList([]), input: 0x08 }, signature: Signature { inner: ecdsa::Signature<Secp256k1>(840CFC572845F5786E702984C2A582528CAD4B49B2A10B9DB1BE7FCA9005856525E7109CEB98168D95B09B18BBF6B685130E0562F233877D492B94EEE0C5B6D1), v: Parity(true), r:<PHONE_NUMBER>7604526217550949535444980007647751110991992555989432467883920033125, s:<PHONE_NUMBER>8048845831134990513685258884275296176139135115431336905099564136145 }, hash: 0xa4b327fdd449fb3dcae8511f0f1c32af0d6b24c6199a67a4b099f957c9478bc2 })

thank you! I'll be looking at this and #897 this morning

per #897 (comment) can you add the following to the legacy tx into_signed
    fn into_signed(self, signature: Signature) -> Signed<Self> {
        debug_assert_eq!(signature.v().chain_id(), self.chain_id);

this prevents most issues while we move towards a larger refactor

Done

I did but CI failed with:
thread 'transaction::envelope::tests::test_serde_roundtrip_legacy' panicked at crates/consensus/src/transaction/legacy.rs:253:9:
assertion `left == right` failed
  left: None
 right: Some(1)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

So I am reverting that assert.

Hi! Is there anything else I can do in this PR?

Hello! Is there any progress? @prestwich

@onbjerg @prestwich @gakonst @mattsse @Evalir @DaniPopes
ping


The datasets with negative responses.

Thanks for your awesome work.
As shown in the Tab. 2, the preference training datasets have 150K samples from three data sources (ShareGPT-V, LLaVAR, LLaVA-Instruct). Do you have plans to release all ready-made preference datasets with negative responses (including Image-Weakened prompting and Error Injection)? I think the ready-made datasets can help the community and researchers follow your work better.

Thank you very much for your interest. We have uploaded the negative responses on huggingface in this link:https://huggingface.co/datasets/renjiepi/BPO


System reboots during ffmpeg tool installation

I have enabled QSV with reference of the streambuilder's enabling-iqsv docs.
Reference : http://streambuilder.pro/docs/requirements/enabling-iqsv/
MACHINE DETAILS
Server : Intel(R) Xeon(R) CPU E3-1285 v4 3.50GHz w/ Supermicro X10SLH-F
Kernel : Linux 3.10.0-<IP_ADDRESS>985.MSSr7.el7.centos.x86_64 #1 SMP Wed Nov 9 16:26:25 PST 2016 x86_64 x86_64 x86_64 GNU/Linux
I have installed ffmpeg with --enable-nonfree --enable-libmfx configurations, configuration command was successfully done.Then, I invoke make and our server gets hanged in few seconds and it will gets rebooted automatically.
I feel it might be compilation issue with make script.

./configure --prefix="/usr/ffmpeg" --extra-cflags="-I$HOME/ffmpeg_build/include" --extra-ldflags="-L$HOME/ffmpeg_build/lib" --bindir="$HOME/bin" --pkg-config-flags="--static" --enable-nonfree --enable-libmfx
make
--- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=2068, si_status=0, si_utime=0, si_stime=0} ---
rt_sigreturn()                          = 2068
rt_sigprocmask(SIG_BLOCK, [HUP INT QUIT TERM XCPU XFSZ], NULL, 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
stat("libavcodec/intrax8dsp.o", {st_mode=S_IFREG|0644, st_size=82840, ...}) = 0
stat("libavcodec/ituh263dec.o", 0x7ffff86affb0) = -1 ENOENT (No such file or directory)
stat("libavcodec/ituh263dec.c", {st_mode=S_IFREG|0644, st_size=38617, ...}) = 0
rt_sigprocmask(SIG_BLOCK, [HUP INT QUIT TERM XCPU XFSZ], NULL, 8) = 0
vfork()                                 = 2072
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
wait4(-1, CC libavcodec/ituh263dec.o

I have attached config.log and FFMPEG-MAKE-TRACE.log file.

Hello,
This is a ffmpeg bug, please report it to the ffmpeg community.


Add support for MySQL lookups

Could you add MySQL and / or PosgreSQL lookups in Dash for .sql files?

Definitely, would you like to submit a PR for this? Looks like you'd add that like about here: https://github.com/keith/investigate.vim/blob/master/autoload/investigate/defaults.vim#L38

Please feel free to submit a PR for this! I'll merge it if you do! Thanks!


Ask for Location Perms enabled

Fixes #269

[x] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[x] If you have multiple commits please combine them into one commit by squashing them.

@jaydeetay Please review. Thanks!

@jaydeetay Now this can be merged,


Added watch to file to transport

Hi,
i've added a file watcher to the file transport, to get rid of the problem if the file was moved or deleted when the process is running. I'm well are of the failing unit tests. Could someone be so kind and help me out with that problem? I'm not deep enough in the code to fix them in a acceptable amount of time.
This fixes #705 and #956.

Thank you for your contribution, but adding new features to the File transport is not something we are considering at this time. Once the 3.x branch is merged we would be willing to consider this in winston@3


TracingChannelInterceptor: simple refactoring

This PR contains a simple and short refactoring of TracingChannelInterceptor code style.
Feel free to merge or reject.
The purpose of this PR is more about starting a discussion and possible raising some issues here or there to address later on or immediately.
As it turns out the logic of this component is complex enough.

We probably could have a separate interceptor for Spring WebSocket support - all the Spring Integration MessageChannel implementation are an AbstractMessageChannel.
We probably can have a separate  interceptor for Spring Cloud Stream. (Or we have already but some other way).
If we still are about a ChannelInterceptor impl for Spring Integration, then it is better to look into a ThreadStatePropagationChannelInterceptor. The SecurityContextPropagationChannelInterceptor is the best sample to follow: https://docs.spring.io/spring-integration/docs/current/reference/html/security.html#security-context-propagation
It is not OK to clean up a thread local in the afterReceiveCompletion(). Well, better to say it is pointless to do thread state manipulation with postReceive() and afterReceiveCompletion() since the state is cleaned up when message is produced from the receive(). On one hand we can think to not modify thread local over there at all, or mention in the docs how to clean it up from end-user perspective. See the mentioned Security concern in Spring Integration docs.
private static final String REMOTE_SERVICE_NAME = "broker"; and its JavaDocs. Or this one is about WebSockets support or it is really a general concept to represent an endpoint on the consumer and produce side. (Correct me if I'm wrong). For tracking this purpose I definitely can suggest something similar what we do with MessageHistory in Spring Integration: https://docs.spring.io/spring-integration/docs/current/reference/html/system-management.html#message-history. And how we deal with the TrackableComponent. This way not only MessageChannel abstraction would be involved in the tracing, but also all the MessageHandlerSupport, MessageProducerSupport, MessagingGatewaySupport  implementations, plus a SourcePollingChannelAdapter. This way we would have tracing aligned with the MessageHistory and also with what we do when deal with metrics.

I probably miss something else: feel free to point me out what to pay close attention!
We can live for now with what we have so far or let me know if you want we to remove that thread state manipulation for the receive() part.
Thank you for letting me know what is going on in tracing around Spring Integration!

The changes look nice!

We probably could have a separate interceptor for Spring WebSocket support - all the Spring Integration MessageChannel implementation are an AbstractMessageChannel.

You're suggesting to remove the code from this interceptor and move the whole code to a separate one?

If we still are about a ChannelInterceptor impl for Spring Integration, then it is better to look into a ThreadStatePropagationChannelInterceptor. The SecurityContextPropagationChannelInterceptor is the best sample to follow: https://docs.spring.io/spring-integration/docs/current/reference/html/security.html#security-context-propagation

Ok I'll look into that code.

It is not OK to clean up a thread local in the afterReceiveCompletion(). Well, better to say it is pointless to do thread state manipulation with postReceive() and afterReceiveCompletion() since the state is cleaned up when message is produced from the receive(). On one hand we can think to not modify thread local over there at all, or mention in the docs how to clean it up from end-user perspective. See the mentioned Security concern in Spring Integration docs.

Sure, please update the code then.

private static final String REMOTE_SERVICE_NAME = "broker"; and its JavaDocs. Or this one is about WebSockets support or it is really a general concept to represent an endpoint on the consumer and produce side. (Correct me if I'm wrong).

Correct, however in between we have a broker so we will see a component in Wavefront / Zipkin called broker.

For tracking this purpose I definitely can suggest something similar what we do with MessageHistory in Spring Integration: https://docs.spring.io/spring-integration/docs/current/reference/html/system-management.html#message-history. And how we deal with the TrackableComponent. This way not only MessageChannel abstraction would be involved in the tracing, but also all the MessageHandlerSupport, MessageProducerSupport, MessagingGatewaySupport implementations, plus a SourcePollingChannelAdapter. This way we would have tracing aligned with the MessageHistory and also with what we do when deal with metrics.

I'm all for such changes. If this is a new feature though then we should do it in 3.1.x branch. How would you like to proceed with that?

Thanks Marcin for quick turn around!

Sure, please update the code then.

Sure, will do soon! And this is a bare minimum we can do for now to keep the code backward compatible.
I still have some doubts about copying/pasting headers, but I guess there was a reason to do that since WebSocket stuff is involved in that logic. My best guess to be able to keep an existing id and timestamp headers.

If this is a new feature though then we should do it in 3.1.x branch.

Sure! Let me see what I can do over there. Probably somewhere next week after releases.

Is it ready to be merged? :)

Sure thing, Marcin!
Sorry for not making myself clear when we discussed this in person.
Yes, it can be merged already if you don't have anything else I should pay attention to.
Thanks

Great. I wonder about one thing. How about we merge this not to main but to 3.1.x branch? Since the current main should pretty much contain only bug fixes. WDYT?

Sure! However I think those classpath checks I have fixed we can treat as bug and therefore back-port 😄 .
But if this is still to stressful, I'm OK just have a fix only for the next version.

Ah no, if it's a bug fix then no problem. I'll merge this.


[FEATURE] clean up algo traits support

It makes sense to not only allow to pass traits in the [] but also individual rbr::keyword.

https://github.com/jfalcou/eve/pull/838


Can I find the name of the certificate managed by match using command line?

Hi awesome authors, fastlane is a wonderful tool!
Short version of my question:
Can match tell me the name of the certificate it manages? Name such as "iPhone Distribution: My Name".
Long version of my question:
When I am using this tool I ran into a problem so I hope that I can get some help from you, thank you!
What I want is to use command line to archive .ipa out of source codes without opening Xcode or Keychain Access or any other GUI programs.
Here is where I've achieved:
I've used match appstore on another Mac (say it's Mac A) to generate certificate and provisioning profile and pushing them to my private git repo.
In the new Mac(Mac B)'s Keychain Access there are only Apple's root certificates. After cloning a new project onto Mac B, I cd, match init and connect this project to my private git repo. Then I match appstore so match can download and install my certificate (only one) and provisioning profile on Mac B.
Here I try using gym to archive .ipa but it failed saying No coding signing identities found. I think the reason is that I didn't use Xcode to open this project and select a team(so it could be none), in the Build Settings the Code signing property is also default(could be iOS Developer). So I add a parameter: gym -i "iPhone Distribution: My Name" and this time it succeeded.
So here is my question: on Mac B almost all steps are proceeded in command line so I can write some scripts or something to finished all the work. But now in the last step I have to check this name "iPhone Distribution: My Name" in Keychain Access, remembered and typed it into the command line. Is there a way to let match to tell me this name so I can turn the whole process to an automatic process?
PS: I can use security find-identity -p codesigning -s Keyword -v to find some certificates whose name is matched with the keywords. But there could be many Apple IDs so I can't specify a keyword. And I need the name of the very certificate managed by match to make sure gym won't failed. So this is not my solution.
Hope that you can help me, thank you~

Hi @zhengbuqian Thanks for reaching out. Can you send over your fastfile for this lane? You should be able to add the parameters there. Thanks! 👍


[IGNORE] run visual tests in parallel

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

agreed to not introduce any moments that would require interaction to the build process - it should still be completely automated


Merge Editor: Highlight conflicts that just are a single view zone

Observe that the viewzone in base is not highlighted, even though it is the active conflict.

Fixed:


New Zealand covid status website

Link to suggestion
https://thoughtfulnz.quarto.pub/nzcovidreport/
Targeted section
Real life examples/Websites formats
Describe your suggestion
As an example: once a day I render the site locally (the scripts download all the latest data and renders the graphs and summaries), check it to add any human commentary about significant daily changes, then upload the remote version.
Checklist

[X] checked if your suggestion is not already listed in Awesome Quarto list.
[X] checked if it can fit in an existed section or suggest a new section and explain why your item does not fit into one and what would be the interest of your new section.
[X] checked when it's a repository if it's maintained (archived repository will be rejected).

Thanks for the suggestion!
I had a quick look and did not find any particular things in your website.
Did you use anything in addition to the default?
There are already few "default" website, so I don't want to add more.
See for example the last five website in https://github.com/mcanouil/awesome-quarto#websites-formats, they all have custom things.

Thanks again, but I won't include it as it does not seem to include much more than the default website.


Can't even open the script after installing it

that's what the terminal is throwing at me after I installed it.
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.12/bin/spotify_sync", line 5, in
from spotify_sync.main import cli
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/spotify_sync/main.py", line 5, in
from spotify_sync.cli import SpotifySyncApp
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/spotify_sync/cli.py", line 7, in
from spotify_sync.stats import (
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/spotify_sync/stats.py", line 5, in
from spotify_sync.spotify_ import SpotifyService
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/spotify_sync/spotify_.py", line 8, in
from spotify_sync.config import Config
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/spotify_sync/config.py", line 13, in
from pkg_resources import resource_stream
ModuleNotFoundError: No module named 'pkg_resources'
I have absolutely no idea why or how I can resolve this. I tried reinstalling, restarting my Mac, restarting terminal and so on.

Had to download pip setuptools.


java.lang.NullPointerException: Attempt to read from field 'org.oscim.core.BoundingBox org.oscim.tiling.source.mapfile.MapInfo.boundingBox' on a null object reference

09-21 00:02:12.925 11734-11734/com.graphhopper.android E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.graphhopper.android, PID: 11734
    java.lang.NullPointerException: Attempt to read from field 'org.oscim.core.BoundingBox org.oscim.tiling.source.mapfile.MapInfo.boundingBox' on a null object reference
        at com.graphhopper.android.MainActivity.loadMap(MainActivity.java:374)
        at com.graphhopper.android.MainActivity.downloadingFiles(MainActivity.java:308)
        at com.graphhopper.android.MainActivity.initFiles(MainActivity.java:197)
        at com.graphhopper.android.MainActivity.access$000(MainActivity.java:66)
        at com.graphhopper.android.MainActivity$2.onSelect(MainActivity.java:219)
        at com.graphhopper.android.MainActivity$4.onClick(MainActivity.java:297)
        at android.view.View.performClick(View.java:5215)
        at android.view.View$PerformClick.run(View.java:21196)
        at android.os.Handler.handleCallback(Handler.java:742)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:157)
        at android.app.ActivityThread.main(ActivityThread.java:5613)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:774)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:652)

error happens here https://github.com/graphhopper/graphhopper/blob/master/android/app/src/main/java/com/graphhopper/android/MainActivity.java#L371

Android sample demonstrates offline maps via VTM vector map library and offline routing via GraphHopper. Last time I checked the sample works as intended.
If you have made changes need to debug your implementation and see if map file is loaded correctly.

I didn't do any changes, come on..
I cloned original project, did run it without any changes
p.s. remote german maps works
Local Ukraine didn't work
what I did

downloaded original Android Project, didn't modify it
downloaded ukraine.map v4 http://download.mapsforge.org/maps/v4/europe/ukraine.map
There is no available v5 for Ukraine... mb it doesn't work because of it (are v3/v4 still supported?)
downloaded ukraine-latest.osm.pbf http://download.geofabrik.de/europe/ukraine-latest.osm.pbf
executed ./graphhopper.sh -a import -i ukraine-latest.osm.pbf and I got ukraine-latest.osm-gh folder
copied ukraine.map to ukraine-latest.osm-gh folder and got next picture

copied to my phone storage/download/graphhopper/maps directory
when I select this map in Graphhopper app it crashes with error a described above

Can see how the folders of the working downloaded maps exist in filesystem and create similar path for any new area.


Updated file to reflect recent changes made to app only access config…

… in modern term store
Category

[X] Content fix
[ ] New article

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

What's in this Pull Request?

This reflects changes that we have made for app only access configuration for modern term store

Learn Build status updates of commit aa41fc1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-guidance/elevated-privileges-in-sharepoint-add-ins.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 71b0e68:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-guidance/elevated-privileges-in-sharepoint-add-ins.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Missing instructions - not much "teaching"

This tutorial worked as intended, but for those who are actual "beginners", I feel this tutorial will be hard to follow.  There really isn't any "teaching" in this tutorial.  It's mainly a tutorial on following instructions and copy and pasting.  There is very little description describing the code that is copied and pasted or any explanation as to how the code works.
Also, the code in the section "Add SignalR client code" there is an instruction that says "In the wwwroot/js folder, create a chat.js file with the following code:" but no instruction on HOW to make this "chat.js" file.  I figured it out, but it wasn't intuitive.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0dd2991d-c22d-ad0f-80b6-bd1b503db8f3
Version Independent ID: 5e3fbe1d-c97f-9940-4f0c-067d4b2112b1
Content: Get started with ASP.NET Core SignalR
Content Source: aspnetcore/tutorials/signalr.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @bradygaster
Microsoft Alias: bradyg

@jsmwrench ... That's mostly by-design. The tutorials are intended to get devs up and running with a quick, basic example without a lot of explanation and cross-links. The reference docs cover the details. In this case WRT your remark about the JS file, you'd learn more about that in ...
https://docs.microsoft.com/aspnet/core/signalr/javascript-client


MRDL -> MRTK Dialog & Progress control

Overview
This pull request brings MRDL’s Dialog and Progress controls to MRTK. These are standard UI for the notification/information display and visual feedback for the data loading. Both controls are tested and optimized for both HoloLens & Immersive headset. Core scripts and prefabs are added to MRTK’s main folder under UX. Example scenes are added to MRTK’S Examples folder under UX.
Supported devices

HoloLens
Immersive headset

Demo video

Dialog: https://gfycat.com/ConventionalDirtyKiskadee
Progress: https://gfycat.com/JaggedDimLacewing

Technical details
You can find technical details in these README pages:

DialogsExample README
ProgressExample README
-

Example Scenes

Dialog Example scene
Progress Example scene

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: johnppella sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Addressed:
shader issue BUFFER->CBUFFER, Removed Resources folder, removed use of Resources.Load(), version changes

Added private modifier to Start() in DialogExamples.cs and ProgressExamples.cs
removed default comment from Start()
Remoived unused usings from FadeObject.cs
Removed local definition of Singleton in ProgressIndicator.cs - replaced with MixedRealityToolkit.Common.Singleton

more Changes- added missing braces,
FadeObject.cs cached material instead of renderer
added private modifier in several places

changed script files.
deleted commented code

changed switch(name) to switch on enum for progress indicator example scene
encapsulated, serialized and cased variables
repaired missing header
removed strange spacing in header
removed Debug call
made UI element scale factor for IHMD vs HoloLens check into a variable.

@StephenHodgson Applied your feedback. Thanks!

Updated both scenes to assign button collection in the inspector panel.
Renamed inconsistent button script to avoid confusion. Now they are ProgressExampleLaunchButton.cs and DialogExampleLaunchButton.cs
Applied same scaling related scripts for the consistency.

Resolved merge conflict. Merged Dev_Working_Branch, fixed missing prefabs in the scene.

many convention conformance edits.
-encapsulation
-adding missing access modifiers
-removing or enclosing within #ifdefs referencing  UnityEngine.XR.WSA
-addressed Renderer.Material access memory leak by using sharedMaterial

@StephenHodgson README conflict Resolved.


skip dead processes and use volatility for process dumping

two things to look into:

when a parent process opens a child, then the child exits, but the parent still has the handle open, Windows does not yet remove the process from the process list. It does set a few data structures as NULL. so, we detect this and skip dead processes still in the process list.

major strategy change: stop doing our own process dumping techniques and outsource that work to Volatility. The change does require that you manually add the Xen address space plugin from the LibVMI Python bindings into Volatility's plugins path.

pay close attention to output.c to see if I did anything stupid with calling the external process. I was not going for a strict, clean environment/path/etc. for calling volatility. I also haven't ACTUALLY tested it yet. so, hold off on merging this.
also also, since we are shelling out synchronously, on purpose, we probably don't need the worker thread that was used for dumping. But, it should remain for now just in case we have to revert or have other needs.

Here are my notes on how to setup volatility for Ubuntu 16 as lazily as possible:
# Setup libvmi
# Details: https://github.com/libvmi/libvmi

sudo apt install cmake flex bison libglib2.0-dev libvirt-dev libjson-c-dev libyajl-dev
git clone https://github.com/libvmi/libvmi.git
cd libvmi
mkdir build
cd build
cmake ..
make
sudo make install
sudo ldconfig

# Setup libvmi-python + volatility
# Details: https://github.com/libvmi/python

sudo apt install volatility
git clone https://github.com/libvmi/python.git libvmi-python
cd libvmi-python
python setup.py build
sudo python setup.py install
sudo cp volatility/vmi.py /usr/lib/python2.7/dist-packages/volatility/plugins/addrspaces/vmi.py

@redspot
Two things that need to be added to this PR:

We need to add a command line parameter to control which profile volatility uses (e.g. --profile=Win7SP0x64). Without this, users can get inaccurate results and various runtime errors.
We should add some sanity checks to main(), like making sure volatility is in the path and the profile requested by the user exists.


Add permissions to the app in the portal

Changes proposed in this PR:

Extend the "Register the app in the portal" page to describe how to add the User.Read and Calendars.Read permissions as defined in the scope
Add two screenshots for the above

Thanks @CodeRunRepeat for your interest in this tutorial! The steps you've added aren't needed as the app requests Graph scopes dynamically. Did you run into a scenario where you had to add these permissions to get it to work?


Any way to set the camera intrinsic (aspect) when rendering?

Hi author, when rendering the current view, is there a way to set this if I know the camera intrinsic of the dataset? I found it seems that client.camera can only set Focal and does not support Aspect T-T

I try to use it to render the mesh like open3d and pyrender, but I found it only support setting the focal..

Unfortunately the render aspect ratio just depends on the window size of the client, which is read-only. The field of view is always vertical, though, if that helps you with your calculations.
If you're calling get_render we do respect the aspect ratio of the image height and width that you pass it though.


fix: DevTools cannot be showed in Chrome and Firefox on Nuxt v4

🐛 The bug
I am using the nightly version of Nuxt (4.0.0-28693174.8aefb554). I found Nuxt DevTools (no matter the nightly or<EMAIL_ADDRESS>does not work on Chrome 126 and Firefox 129.0b6 (Attachment 2). Notably, it works on Safari 17.5 (Attachment 1). It used to work on Nuxt v3.

When adding breakpoints to the code related to Nuxt DevTools, I found Firefox (and Chrome) indeed ran import("./view/client") but setupDevToolsClient was never called, as the Attachment 3 shown. Safari ran as expected (Attachment 4). Not sure why.
https://github.com/user-attachments/assets/df0c3b68-3e77-4791-ba55-f837bfe0efb5
https://github.com/user-attachments/assets/0ad4a9cd-7570-4cb4-b62f-df250b996a32
🛠 To reproduce
https://github.com/pan93412/nuxt-4-devtools-regression
🌈 Expected behavior
The Nuxt DevTools should be able to show on Chrome, Firefox, and Safari.
ℹ Additional context
I am using macOS 14.5 (23F79) if this matters.

Upgraded to the latest nightly (4.0.0-28693174.8aefb554 and this is still reproducible.
https://github.com/user-attachments/assets/0f9c20a6-367a-48dd-a2ba-a0953dc1a797

After the bisecting of Nuxt version, I found this issue is started from the Nuxt commit 8f95cac3: https://github.com/nuxt/nuxt/compare/5f819ab8..8f95cac3. In another word, it works in the previous Nightly version, 5f819ab8.
Sadly, the 8f95cac3 commit is about the upgradation of Nitro. Maybe I need to deep into what makes DevTools break.

After the final investigation, I can conclude this bug is a due to the circular import.
#app/config contains this import:
import { reactive } from 'vue'
import { klona } from 'klona'
import type { AppConfig } from 'nuxt/schema'
import { useNuxtApp } from './nuxt'
// @ts-expect-error virtual file
import __appConfig from '#build/app.config.mjs'  // oops

#build/app.config.mjs is basically the content I mentioned above:
import { defuFn } from 'defu'

const inlineConfig = ${JSON.stringify(nuxt.options.appConfig, null, 2)}

/** client **/
// Vite - webpack is handled directly in #app/config
if (import.meta.dev && !import.meta.nitro && import.meta.hot) {
  const { updateAppConfig } = await import('#app/config')  // oops
  import.meta.hot.accept((newModule) => {
    updateAppConfig(newModule.default)
  })
}
/** client-end **/

@danielroe Would you like to take a look with this issue? I can open a PR to revert the await import('#app/config') to import { updateAppConfig } from '#app/config'.

Thank you @pan93412 - that would be very helpful 🙏


In the title box, the text overflows the container. We need to either set a character limit or incorporate a slider within the box

@llaske
In the Fototoon activity, the title text exceeds the container boundaries. We should consider implementing either a character limit or a slider within the box.
please review this issue if it looks genuine then I would like to work on this issue:
https://github.com/llaske/sugarizer/assets/154233802/d944de4b-6304-4012-926a-3521cd6f8376

No. The user can easily change the font size to adapt to the right.
It's with this sort of thing that children learn to fix bugs.


Fetch sources live from URLs

Instead of requiring a local .pkl, fetch the content from a configured server.

This is somewhat working as of this morning.

Related to #11


Efficient data transfer through zero copy

http://www.ibm.com/developerworks/library/j-zerocopy/

@taoyonggang, This is the traditional DMA copy trick that Kafka sendFile used. It works for persistent queue/log systems that need high throughput. It's not suitable for in-memory pubsub broker like emqttd that aimed to handle massive connections with low latency and low throughput.
Closed, Thanks.

You can use kennel network to replace the user network . It can save cpu and memory copy time.


All-in-one deposit button

📄 Context
Currently, AFAIK the production version of the explorer only supports ERC-20 deposits,
but it seems also that you are in the process of supporting Ether deposits as well.
Later, you might also give support to ERC-721 tokens (NFTs) and ERC-1155 tokens (Multi tokens).
My fear is that if all of these assets have their own individual deposit button, it might overcrowd the UI.
✔ Solution
To solve this issue, we can make an all-in-one deposit button, which, when clicked, prompts the user to choose the specific type of asset they would like to deposit. It can be a pop-up component with buttons for each asset type, or a drop-down list streaming down from the deposit button...

I think @guidanoli has a good point here. Hey, @brunomenezes , @tuler if you are ok with the suggested solution, I can start working on it. Please let me know.

I think @guidanoli has a good point here. Hey, @brunomenezes , @tuler if you are ok with the suggested solution, I can start working on it. Please let me know.

That is interesting, @guidanoli. Are these standards already in use on the DApp level? Is there a Dapp you tried to use one of these?
I have been talking to @tuler about that crowded header, which we want to avoid having. For example, the create connection that is coming with Dapp-connect #41 is introducing a drawer where configs would live (e.g. there is a create custom ABI we'll experiment with soon that will also use that space).
Nonetheless, that idea is not odd to me; when I worked on International Payments, the form would change based on (currency + country + specific bank country nuances)
@nevendyulgerov, first, we need to get the following: #49 and #40 approved and merged before working on a new design.

Are these standards already in use on the DApp level? Is there a Dapp you tried to use one of these?

I think Ether and ERC-20 are, by far, the most widely used types of assets. There are, however, some DApp that deal with NFTs (ERC-721 tokens). Auction DApp and Tribes are some examples.
As for ERC-1155 tokens (multi-tokens), I don't know any example that uses them yet, but they are interesting for transferring tokens of different types in bulk. For example, imagine of an RPG where you have several resources (grain, ore, lumber, wool, clay). With ERC-1155, you can transfer resources of different types in a single transaction.

Ultrachess was thinking about using ERC-1155 to batch-transfer a chess set, with each piece wrapping a Uniswap v3 LP-NFT in a different liquidity range (narrowly spaced for pawns, wide liquidity range for kings). It's a future goal but still a concrete example of the value of ERC-1155 batch transfers.

I will close this one as we work on a single UI supporting multiple forms ( #55). We will rearrange the ones we have (e.g., send raw input, deposit erc-20, deposit eth) and make room for more to come. Also, changing the text here and there since not all are deposits.
Thanks for the insightful issue @guidanoli and @juztamau5.


2.0.0-beta.4 exposing iOS invalidate() method

I have an app that reads and writes data consecutively. If the original read goes trough, but the writing throws an error, the iOS modal still shows a checkmark as if the whole task was done successfully.
Reading trough the iOS NFC documentation, i stumbled upon this: https://developer.apple.com/documentation/corenfc/nfcreadersessionprotocol/3229946-invalidate which seems like something that could be used to determine when a native error screen would be shown.
I didn't find a way to handle this currently, do you think it would make sense to expose this native function or is there other ways to achieve this?
Thank you!

Hi @joakimgrr thanks for this insight. I think exposing the invalidateSessionWithErrorMessage Is the right approach. I will try to add this in the next release.

@joakimgrr just impl NfcManager.invalidateSessionWithErrorIOS in the latest 2.0.0-beta.5, please try it out!


How to add numberOfLines to table?

I would need to add a numberOfLines to the tableView content.
Who?

Desired result:

I have figured it out with \n but that makes it kinda hard to have it generically since the content may vary but the row height needs to adjust..

Also in this example, a comment may have too many words for the row but the row height seems fixed for the whole table. not adjustable per row.
Idea?

also, the table does not continue on a new page automatically....

I have same problem 👆🏻

@davidseek please tell me you have solved this problem?

In theory yes. You need to calculate the outcoming height yourself and then break the page yourself.
But there is no in house solution.

@davidseek thanks.

davidseek have you able to solve the draw table problem because I am stuck on that it would be great if you help me


Pint update

Ref: https://github.com/inventree/InvenTree/pull/5527#issuecomment-1941104515

Unit tests are still broken as of pint==0.23.
As there is otherwise no urgent reason to change, closing this for now.


SyntaxError stack trace source maps

With https://github.com/nodejs/node/pull/54283#issuecomment-2283390708, when the source codes containing syntax errors (like yet to be supported ECMAScript syntaxes) are used with the flag --experimental-tranform-types, there is no time for --enable-source-maps to collect source maps and perform stack trace mapping, as it collect source maps information from V8 parse results.
const obj = {
  [Symbol.dispose]() {
    console.log('disposed')
  }
}

function foo() {
  using _ = obj;
}

For example, if the following snippet is been parsed as JS, the error would be:
file:///Users/cwu631/Developer/nodejs/node/a.mjs:8
  using _ = obj;
        ^

SyntaxError: Unexpected identifier '_'
    at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:166:18)
    at callTranslator (node:internal/modules/esm/loader:436:14)
    at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:442:30)
    at async ModuleJob._link (node:internal/modules/esm/module_job:106:19)

Node.js v23.0.0-pre

However, if it is parsed as TS:
~/D/n/node (pr-54283)> ./node --experimental-transform-types a.mts
(node:11541) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
file:///Users/cwu631/Developer/nodejs/node/a.mts:7
    using _ = obj
          ^

SyntaxError: Unexpected identifier '_'
    at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:166:18)
    at ModuleLoader.<anonymous> (node:internal/modules/esm/translators:540:10)
    at callTranslator (node:internal/modules/esm/loader:436:14)
    at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:442:30)
    at async ModuleJob._link (node:internal/modules/esm/module_job:106:19)

Node.js v23.0.0-pre

Note that the reported syntax error line number is 7, not 8 as expected.

Is it an issue with the typescript loader implementation or with sourcemaps?

The problem is with the source map support, but it is only outstanding with an internal loader because the transpiled sources are not visible to users.


DeprecationWarning: BILINEAR is deprecated and will be removed in Pillow 10

When running pytest with the latest version of Pillow, you'll see:
../../../anaconda/envs/adam-py37-min/lib/python3.7/site-packages/pretrainedmodels/datasets/utils.py:33
  /anaconda/envs/adam-py37-min/lib/python3.7/site-packages/pretrainedmodels/datasets/utils.py:33: DeprecationWarning: BILINEAR is deprecated and will be removed in Pillow 10 (2023-07-01). Use Resampling.BILINEAR instead.
    def __init__(self, size, interpolation=Image.BILINEAR):

This attribute was moved to an enum in Pillow 9.1 and the old attribute will be removed in Pillow 10. We should update this soon.
Related to https://github.com/pytorch/vision/pull/5898 and https://github.com/rwightman/pytorch-image-models/pull/1256.

您的邮件已收到!


ch 7 app-stack.yaml missing

p 126-127 in the book refers to file: app-a/ch07/app-stack.yaml
the definition defines 3 pods.  This file does not exist in the repo.
Not to be confused with the app-stack-network-policy.yaml

never mind, misread the question


Added api.test endpoint

Added the api.test endpoint, which I use to test connection to slack.

Yeah, between me posting this, and now, things have changed a LOT. Since this is live where I work, I'm going to close it until the next version comes out, then make sure it is congruent with the other routes.


security(state): Limit the number of non-finalized chains tracked by Zebra

Motivation
There is no limit on the number of non-finalized chains that Zebra can track.
Theoretically, this allows unbounded use of memory. But this bug is difficult to exploit on mainnet, because it would require mining hundreds of side-chain blocks at mainnet difficulty.
Specifications
The number of chains tracked by a node implementation is a standard rule, not a consensus rule. For zcashd, it is currently 1 in memory, and some number on disk.
For Zebra, after this PR it will be 10 in memory. (Zebra doesn't store any unverified or side-chain blocks on disk.)
Complex Code or Requirements
This is concurrent code, the non-finalized state is cloned before reading it concurrently. We ensure that the limit of 10 is kept by making the list of chains into a private field, and only accessing them via a method.
Solution

Limit the number of non-finalized chains to 10

If the limit is reached, drop the chain with the least work
Make the chain list private, and provide iterator, count, and insert chain methods

Review
This is a low priority security fix.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

Temporary network errors:

warning: spurious network error (2 tries remaining): early EOF; class=Net (12); code=Eof (-20)
Warning: warning: spurious network error (1 tries remaining): early EOF; class=Net (12); code=Eof (-20)
error: Unable to update registry crates-io
Error: Unable to update registry crates-io
Caused by:
failed to fetch [https://github.com/rust-lang/crates.io-index](https://github.com/rust-lang/crates.io-index`)

https://github.com/ZcashFoundation/zebra/actions/runs/4601125572/jobs/8128642182#step:5:15

Error: -03 20:40:13 [ERROR] cargo metadata exited with an error:     Updating crates.io index
warning: spurious network error (2 tries remaining): early EOF; class=Net (12); code=Eof (-20)
warning: spurious network error (1 tries remaining): early EOF; class=Net (12); code=Eof (-20)
error: Unable to update registry crates-io
Caused by:
failed to fetch [https://github.com/rust-lang/crates.io-index](https://github.com/rust-lang/crates.io-index`)

https://github.com/ZcashFoundation/zebra/actions/runs/4601125562/jobs/8128592665?pr=6447#step:4:14


Add UTF-8 path support

This takes advantage of a Windows 10 manifest property to set the process code page to UTF-8.
Prior to this update:
cppwinrt.exe -in d:\Test❤\Windows.winmd -out d:\Test❤
cppwinrt : error Path 'd:\Test??\Windows.winmd' is not a file or directory

With this update:
D:\git\cppwinrt\_build\x86\Release\cppwinrt.exe -in d:\Test❤\Windows.winmd -out d:\Test❤

Input is parsed correctly and output is generated correctly.
I'm reluctant to add a test for this scenario to avoid complicating the build.
Fixes: #1306

@alvinhochun any suggestions for the Linux build failure?

Looks like a random unrelated failure in that one test. I suspect a thread left over from another test just happened to interfere with it, perhaps?


Issue with GUI and CLI "sudo: smc: command not found"

Hi,
I'm having some issues with both battery GUI and CLI.
On the GUI after installing and downloading the  components, I get the following prompt,  "Error installing battery limiter: undefined"
With the CLI, whenever I run a command, I get this error.
sudo: smc: command not found sudo: smc: command not found
/us/local/bin/battery: line 110: smc: command not found

For me it is the following error message on the GUI:

@aroonjawaid can you send me the output of: tail ~/.battery/battery.log please?

@jju1ez same for you :)

You must have the Xcode command line tools installed, when installing the program. The program fetches code from Github and needs the git command, which is not installed per default on MAC.
Open Terminal and install Xcode command line tools first with: xcode-select --install
(Perhaps a remark can be added on the Readme file)

@ffasbend holy sh*t I had never considered that people might not have git installed! I'll have a look at adding a "install git if not installed" section to the setup script.

I just pushed a update that should fix a few issues, could you try to run brew reinstall --cask battery and see if that fixes it?

Closing under the assumption the most recent release fixes this. Please re-open if this is not the case.

I just pushed a update that should fix a few issues, could you try to run brew reinstall --cask battery and see if that fixes it?

I'm running v1.0.8 (installed via homebrew on an M1 Pro running macOS 12.6.2 and updated today) and, although I'm not having the undefined error the OP stated nor do I see an error when running battery commands in the terminal, I do see the sudo: smc errors in the Battery CLI Logs. I have Xcode command line tools installed (xcode-select version 2395).
E.g.:
02/14/23-01:28:21 - Charge below 80
02/14/23-01:28:21 - 🔌🔋 Enabling battery charging
02/14/23-01:28:21 - 🔼🪫 Disabling battery discharging
02/14/23-10:02:50 - Charge above 80
02/14/23-10:02:50 - 🔌🪫 Disabling battery charging
02/14/23-11:35:07 - Charge below 80
02/14/23-11:35:07 - 🔌🔋 Enabling battery charging
02/14/23-11:35:07 - 🔼🪫 Disabling battery discharging
02/14/23-13:27:59 - Triggering discharge to 80 before enabling charging limiter
02/14/23-13:27:59 - Discharging to 80% from 60%
02/14/23-13:27:59 - 🔽🪫 Enabling battery discharging
sudo: smc: command not found
02/14/23-13:27:59 - 🔼🪫 Disabling battery discharging
sudo: smc: command not found
02/14/23-13:27:59 - Discharging completed at 60%
02/14/23-13:27:59 - Discharge pre battery-maintenance complete, continuing to battery maintenance loop
02/14/23-13:27:59 - Charging to and maintaining at 80% from 60%
/usr/local/bin/battery: line 143: smc: command not found
02/14/23-13:27:59 - Charge below 80
02/14/23-13:27:59 - 🔌🔋 Enabling battery charging
sudo: smc: command not found
sudo: smc: command not found
02/14/23-13:27:59 - 🔼🪫 Disabling battery discharging
sudo: smc: command not found
02/14/23-13:28:34 - Triggering discharge to 80 before enabling charging limiter
02/14/23-13:28:34 - Discharging to 80% from 60%
02/14/23-13:28:34 - 🔽🪫 Enabling battery discharging
02/14/23-13:28:34 - 🔼🪫 Disabling battery discharging
02/14/23-13:28:34 - Discharging completed at 60%
02/14/23-13:28:34 - Discharge pre battery-maintenance complete, continuing to battery maintenance loop
02/14/23-13:28:34 - Charging to and maintaining at 80% from 60%
Output running smc in terminal:
$ smc -h
Apple System Management Control (SMC) tool 0.01
Usage:
smc [options]
    -f         : fan info decoded
    -t         : list all temperatures
    -h         : help
    -k <key>   : key to manipulate
    -l         : list all keys and values
    -r         : read the value of a key
    -w <value> : write the specified value to a key
    -v         : version


Fix constants at function scope are not defined as constants for completion

Fix #47620
result:

Thanks!


Show muted messages in mentioned narrow

This isn't exactly the right approach in the long term, I think (#3542 has the start of a better solution), but I think that this is a useful tactical fix anyways.

Updated :)

And merged! I also added a couple of followup commits -- the nice new well-typed, shorter version of the tests made it easier to see what was going on there, and surfaced some things to fix. I have some more I'll send as a new PR, too.

(I also just added a mention of #3472 in the description, so that it's possible to navigate to this PR from that issue.)


Unable to build via make on for local development

I am not able to successfully build the helm repo for local setup and development. Reference from https://helm.sh/docs/community/developers/
Requirements:
Snap has installed from the snap:
 sudo snap install helm --classic
Output of helm version:
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5", GitCommit:"c285e781331a3785a7f436042c65c5641ce8a9e9", GitTreeState:"clean", BuildDate:"2022-03-16T15:58:47Z", GoVersion:"go1.17.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.5-eks-bc4871b", GitCommit:"5236faf39f1b7a7dabea8df12726f25608131aa9", GitTreeState:"clean", BuildDate:"2021-10-29T23:32:16Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}

Issue while building it locally
clone the repo and cd helm
make

Output:
[innovate@csaju helm ]$ make
GO111MODULE=on CGO_ENABLED=0 go build  -trimpath -tags '' -ldflags '-w -s -X helm.sh/helm/v3/internal/version.metadata=unreleased -X helm.sh/helm/v3/internal/version.gitCommit=2cd709c4a65beba044ee40062594e66811a8b0ba -X helm.sh/helm/v3/internal/version.gitTreeState=dirty  -X helm.sh/helm/v3/pkg/lint/rules.k8sVersionMajor=1 -X helm.sh/helm/v3/pkg/lint/rules.k8sVersionMinor=24 -X helm.sh/helm/v3/pkg/chartutil.k8sVersionMajor=1 -X helm.sh/helm/v3/pkg/chartutil.k8sVersionMinor=24' -o '/home/innovate/Desktop/opensource/helm/bin'/helm ./cmd/helm
build helm.sh/helm/v3/cmd/helm: cannot load embed: malformed module path "embed": missing dot in first path element
make: *** [Makefile:80: /home/innovate/Desktop/opensource/helm/bin/helm] Error 1
[innovate@csaju helm ]$

Here is the config of .bashrc
export GOPATH=$HOME/go
export PATH=$PATH:$GOROOT/bin:$GOPATH/bin

Since helm has been installed via snap and its the location as helm: /snap/bin/helm
Do we need to export and config in bashrc too? Since docs prefer to export helm too? How can I build local helm successfully

If you are compiling from main, you need at least Go 1.17: https://github.com/helm/helm/blob/2cd709c4a65beba044ee40062594e66811a8b0ba/go.mod#L3
The embed package was introduced in Go 1.16... This sounds like you're trying to compile Helm with an older version of Go.
What version of Go do you have installed?