[BUG] OnionBalancedService periodically stops working, resulting in Onion Service not being found

Describe the bug
After running an OnionBalancedService for a period of time, eventually the onion address is no longer resolvable.
Attempting to reach my onion service via the tor browser returns:
Onionsite Not Found

An error occurred during a connection to [redacted].onion.

Details: 0xF0 — The requested onion service descriptor can't be found on the hashring and therefore the service is not reachable by the client.

All "obb" pods appear to be working as expected, but the "daemon" pod potentially has deadlocked after a restart (see below for details).  Deleting the daemon pod, and allowing it to be recreated/restarted resolves the issue.
To Reproduce
I have not figured out specific steps to reproduce this yet, other than waiting long enough.  Although, I have a suspicion it happens when the pod restarts itself (I will continue to try and narrow down more specific repro steps).
Expected behavior
The onion service should always be available as long as the daemon and obb pods are running.
Additional information
Logs from the onionbalance container of the daemon pod:
time="2023-01-06T23:08:33Z" level=info msg="Listening for events"
time="2023-01-06T23:08:33Z" level=info msg="Running event controller"
time="2023-01-06T23:08:33Z" level=info msg="Starting controller"
W0106 23:08:33.805173       1 shared_informer.go:372] The sharedIndexInformer has started, run more than once is not allowed
time="2023-01-06T23:08:33Z" level=info msg="Added onionBalancedService: ingress/tor-service"
time="2023-01-06T23:08:35Z" level=info msg="Getting key ingress/tor-service"

NOTE: the actual time is now 8 hours later, so onionbalance has not logged any additional activity for quite some time (deadlock?).
On a successful launch, I see something along the lines of:
[...]
time="2023-01-07T10:50:04Z" level=info msg="Getting key ingress/tor-service"
time="2023-01-07T10:50:04Z" level=info msg="Updating onionbalance config for ingress/tor-service"
reloading onionbalance...
starting onionbalance...
2023-01-07 10:50:15,789 [WARNING]: Initializing onionbalance (version: 0.2.2)...
[...]

System (please complete the following information):

Platform: amd64
Version: v1.25.5-k3s1

Additional context
This does not happen often, but it has occurred 4 or 5 times over the past ~3 months.  Anecdotally, I believe the last few times this has happened was after/around performing system upgrades on my cluster (ex: upgrading Kubernetes, or restarting nodes), where lots of pods are bouncing around.
The remedy is simple (manually restart the daemon pod), but an automated fix would be preferred. If actually resolving the deadlock (if that's truly the issue...) is overly complex to diagnose at this time, I wonder if an easier fix might be to simply add a probe that can properly detect this condition?  Any thoughts on how I could do this?

Hi @conneryn! Thanks again for your detailed bug (& fix!). Gonna review it in a bit

PR #29 is good to go  / merged. I'll prepare a new release after the build finishes

Sorry for the delay. I've just published the fix under 0.7.1 (helm chart tor-controller-0.1.7)


Issue in running setup.py

Hi below is the output when I run python setup.py install
running install
running build
running build_ext
building 'echoprint' extension
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include/taglib -Ilibcodegen -I/usr/include/python2.7 -c libcodegen/AudioBufferInput.cxx -o build/temp.linux-x86_64-2.7/libcodegen/AudioBufferInput.o
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++ [enabled by default]
In file included from libcodegen/AudioStreamInput.h:14:0,
from libcodegen/AudioBufferInput.h:14,
from libcodegen/AudioBufferInput.cxx:11:
libcodegen/File.h: In static member function ‘static bool File::Exists(const char*)’:
libcodegen/File.h:30:71: error: ‘F_OK’ was not declared in this scope
static bool Exists(const char* filename){return (access(filename, F_OK) == 0);}
^
libcodegen/File.h:30:75: error: ‘access’ was not declared in this scope
static bool Exists(const char* filename){return (access(filename, F_OK) == 0);}
^
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
i think it is missing some files..
as workaround I copied files from https://github.com/echonest/echoprint-codegen/tree/release-4.12
I don't know if some one else had the issue.
So don't want to pollute repo.
But if it happens in future. Please copy files from the repo
@admin - please close the current issue

Same here!

Same here!


Need to communicate using postMessage with ServiceWorkers

While testing integration of ServiceWokers with threads.js as a mechanism to communicate with SW (see: https://github.com/arcturus/sww-render-cache).
We realized that, following the spec, the UA can kill a SW at any moment. Which mean that the broadcast communication channel won't respond to any message (as the server side in the SW has been already killed).
Following the spec, we also see that a SW can be wake up again if we send a postMessage to it, so the communication mechanism that we should have for SW should be postMessage to be sure that the SW will be alive when we perform the communication.
Another point to take into account is that with a postMessage we will relaunch the sw, so if there was already some metadata set up, needed for the communication, some how we will need to reuse it.

In order for this to work the Client will need to have a direct handle on the SW thread.
var thread = threads.create({
  target: myServiceWorker,
  type: 'serviceworker'
});

var client = threads.client('render-cache', { thread: thread });

We will also have to make some changes in the Client code so that if we have a thread reference we should communicate with it using .postMessage() and not bother creating a BroadcastChannel at all. We should probably also make some similar tweaks in Service.

Perhaps we could streamline the above code example to make it easier for the user.
var client = threads.client('render-cache', { target: myServiceWorker });

At first glance, this is all do-able :smile:

Getting a reference to the SW can be like:
var sw = null; navigator.serviceWorker.getRegistration().then(function(registration) {   sw = registraction.active; });
Which means that reference can be obtained from a window object, no worker or sharedworkerd can get a reference to the active serviceworker. (As a document has a relation with a SW, since the scope of the serviceworker indicates which documents are handled by each sw).


Easylinkin Third-Party Manufacturer Application

Easylinkin-Third-Party-Manufacturer-Application

good

good

Happy to discuss!

Happy to discuss!

Application received! Will review and let you know if we have any questions

Application received! Will review and let you know if we have any questions

Per conversations in Discord and informal polling, there is wide support for approving EasyLinkin as a third-party manufacturer of Helium-compatible hotspots and I'm marking this proposal approved ✅
On behalf of the community I request that Helium Inc get in touch and arrange for ongoing key issuance.
I expect more detail will be added to HIP19 as the process for sharing keys is fleshed out

Per conversations in Discord and informal polling, there is wide support for approving EasyLinkin as a third-party manufacturer of Helium-compatible hotspots and I'm marking this proposal approved ✅
On behalf of the community I request that Helium Inc get in touch and arrange for ongoing key issuance.
I expect more detail will be added to HIP19 as the process for sharing keys is fleshed out

Great News! Moving Forward!

Great News! Moving Forward!

Congrats!

Congrats!


EVM: Implement estimate_gas

Description
This PR implements estimate_gas endpoint which estimates the gas used by transaction. It is a copy of reth's code but with small differences to be compatible with our module system.
This also adds gas estimation feature to eth_sendTransaction endpoint.
Linked Issues

Fixes #906
Related to #502

Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Integration tests are added.
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?

My main concern on this PR is that it copies evm_db a lot because it performs several evm inspect runs. This will happen outside the zk context and it is also the same with Reth so I guess it is not a big problem but please share your thoughts.

My main concern on this PR is that it copies evm_db a lot because it performs several evm inspect runs. This will happen outside the zk context and it is also the same with Reth so I guess it is not a big problem but please share your thoughts.

Yes this is fine, we have a cache in the WrokingSet so it shown''t be that have on the db.


MM-38465 Add Discard Modal for Company Information Edit

Summary
When editing company information, the standard discard modal is not presented when navigating to another page.
This change ensures the modal appears when any field is modified.
Ticket Link
https://mattermost.atlassian.net/browse/MM-38465
Screenshots

Test Plan

Go to System Console ➜ Billing & Account ➜ Company Information
Add a new address without clicking the Save Info button
Click the back arrow to exit
Expected: The standard System Console Discard Changes modal prevents me from leaving (see screenshot)

Release Note
NONE

@Afsoon @AGMETEOR Friendly nudge on these when you two are online again :)

@JulienTant Any chance I could redeem that one free code review here? :)

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

/e2e-test

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard


Remove package/ecosystem extraction using llm

What was the situation with rust, any problems or just something to get around to later

I did not get around to adding rust. We can add it in the next iteration.


+default/search-project how to exclude results  with vertico

What did you expect to happen?
+default/search-project result  exclude some type files or exclude some code
like this

What actually happened?
can not exclude code or type files

Describe your attempts to resolve the issue
how can i do this
Steps to reproduce
SPC /    and search come code
System Information
i try M-x doom/info and open pastebin.com  nothing happened

i try M-x doom/info and open pastebin.com nothing happened

It only opens pastebin.com in your browser. You're supposed to then paste it in and click "create new paste".

In any case, this is a support question, which belongs on our Discourse or Discord, not our Github issue tracker, so I will close it.
Check here for an answer to this question.


Ensure Eventwatcher to encode comments at the same line as value

What this PR does / why we need it:
Until now, Eventwatcher has deleted comments at the same line like:
foo:
  bar: baz # comment

This PR fixes to not be deleted.
See more: https://github.com/goccy/go-yaml/issues/248#issuecomment-916606301
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Fix a bug that Eventwatcher deletes comments at the same line at the YAML value

Cool
/lgtm

Nice.
/approve


Add codec categories in doc contents

This sorts the existing codecs into three sections within the docs table of contents: Compression, Filters, and Other. I often find it hard to distinguish between these as the docs are currently, so I'm hoping this makes the docs a bit easier to read.
This also greatly improves the contents structure of the docs, giving three top-level pages:

API reference
Release notes
Contributing guide

Here's what the new API reference page looks like: https://numcodecs--458.org.readthedocs.build/en/458/api.html
I'm definitely not an expert in codecs, so I may have got some of the categories wrong!

ping @zarrdevelopers, any chance someone could review this?

Since this has been open for a year, and it's a month since I pinged for reviews I'm minded to merge it without a review since it's a big improvement to the docs and doesn't change any functionality. Unless anyone shouts in the next two weeks I will merge this.

thanks @dstansby!


feat: Add streaming_rate_limit param option for MV creation

This PR allows for the specification of a streaming_rate_limit for MV creation. See here for its use.
Script can now appear as such:
{{ config(
    materialized="materialized_view",
    streaming_rate_limit=2500
) }}
SELECT *
FROM test_table

and output DDL will look like:
CREATE MATERIALIZED VIEW mv_name
WITH (streaming_rate_limit=2500)
AS
SELECT *
FROM test_table

#52 should support this now FYI @jackson-burke .


Define host

I have done the development.
We need it this week. Do you think it's possible to validate and build it quickly?
Thanks.
Julien

LG ... have you kindly and sorry for the delay ..


Strapi-plugin-versioning not working, error: "TypeError: Cannot read property 'listEntityVersions' of undefined"

I have used the code from the latest pr about migrating to v3.6.8 to use this plugin, however, I am still getting the error "TypeError: Cannot read property 'listEntityVersions' of undefined". I went exactly by the directions in the read me as well as what was stated in the previous issue about versioning

Same here.
Any update on 3.6.8 compatibility?

Cannot read property 'listContentTypes' of undefined at routerChecker
facing the same issue here on v3.6.6 ... any solution ?


Error in getting started manual with jupiter notebook

niche_vlaanderen version:1.0a10
Python version:3.6
Operating System:windows7

Niche Python Package question
Description
I tried to go through the getting started manual, but I got stuck in the first line of code.
I downloaded the niche source code and opened the getting started manual in jupyter notebook (in which I tried to run the code).
What I Did
import niche as nv
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-11-eb9dae3d6d6d> in <module>()
----> 1 import niche_env as nv

ModuleNotFoundError: No module named 'niche_env'

Thanks for testing!
I suppose you have used the niche environment installation method.
Can you verify the installation was succesful by running (from the anaconda prompt):
activate niche_vlaanderen
niche --help

If that works, can you try starting the jupyter notebook from the same prompt, with the environment activated:
jupyter

Rereading your question:
you should do:
import niche_vlaanderen as nv

solved! Thanks


Screaming-concat case-style.

Possible implementation of #70
I used the diesel-1-branch since I'm currently using diesel 1.x in my project. I also corrected the attribute string for screaming snake case in the readme table. That typo tripped me up earlier.

Thanks for the pull request. Am I right to think that this is the same as UPPERCASE? In which case I would prefer to rename to UPPERCASE, I don't think SCREAMINGCONCAT is very common terminology

I wasn't aware of UPPERCASE. If I was I would have called it that instead. Rename is fine with me.

I pushed another commit for the name change. Is that okay or do you want a clean one-commit-PR?

This is now part of the latest release


Iscrape no longer pulling page_user data

I've installed iscrape (and re-installed it today to ensure it's the most up-to-date version). I've opened these libraries:
library(stringr)
library(devtools)
library(dplyr)
library(httr)
library(iscrape)
Then, no matter what account I try, I can't get the page_user function to pull properly. For example:
get_page_user("joebiden")
Here's the error I get:

Warning message:
In get_page_user("joebiden") :
Username joebiden did not return a valid web page.

I've double checked that the spelling is correct by logging in to the Instagram platform itself, and I've tried several different accounts with the same results.

I've also tried clarified for the code to use iscrape::get_page_user, but got the same results

I've also tried clarified for the code to use iscrape::get_page_user, but got the same results

I've also tried clarified for the code to use iscrape::get_page_user, but got the same results

I've also tried clarified for the code to use iscrape::get_page_user, but got the same results


Update map.less

Here is a simple solution for the IOS Scroll bar bug. If this does not work, I can try and implement a few other solutions. But this one should work.

@HTMLNoob thanks for the PR. Please, add closes #6227 to the description if this PR fixes that issue. Also follow our Guidelines for Contributing, especially branch naming, don't include issue messages in PR's title, commit message branch name. I recommend you to close this PR, checkout a new branch with a name like fix/a-brief-descripton-here and open a new PR. Thanks.

Ok, sorry about this bugron. I'm a bit new here so forgive me

@HTMLNoob that's OK, just follow our Guidelines for Contributing.


cutIPv6 documentation misleading

cutIPv6 is a Clickhouse function that zeroes out some bits from the end of an IPv6 or IPv4 address. The documentation for cutIPv6(x, bitsToCutForIPv6, bitsToCutForIPv4) says that it

Returns a string containing the address of the specified number of bits removed in text format.

However, the provided example contradicts this statement. Notice that the IPv6 address has its last 16 bits zeroed out, despite passing in 2 as bitsToCutForIPv6.
WITH
    IPv6StringToNum('2001:0DB8:AC10:FE01:FEED:BABE:CAFE:F00D') AS ipv6,
    IPv4ToIPv6(IPv4StringToNum('<IP_ADDRESS>')) AS ipv4
SELECT
    cutIPv6(ipv6, 2, 0),
    cutIPv6(ipv4, 0, 2)

┌─cutIPv6(ipv6, 2, 0)─────────────────┬─cutIPv6(ipv4, 0, 2)─┐
│ 2001:db8:ac10:fe01:feed:babe:cafe:0 │ ::ffff:<IP_ADDRESS>  │
└─────────────────────────────────────┴─────────────────────┘

Also, while the behavior of IPv4 address handling is unclear in this example, I confirmed that this function operates on bytes instead of bits for IPv4 as well.
This behavior was reproduced in the latest yandex/clickhouse-server Docker container running Clickhouse client version 18.10.3 and server version 19.1.9 revision 54413.

Does anyone know of a workaround for this if bits level of cuts is needed?
I figured it out for ipv4,using bitAnd, but am not sure for ipv6, which returns an Fixed(16) string for
IPv6StringToNum()
Here is what I do for IPv4
IPv4NumToString(bitAnd(IPv4StringToNum(Destination_IPv4_Address), reinterpretAsUInt32(unhex(reverse('FFFFFF00'))))) AS Destination_IPv4/24,

Does anyone know of a workaround for this if bits level of cuts is needed?

That string just contain a binary represenation of ipv6.
You can process that string by parts, but it's a bit tricky because of endianness.
Please try to follow:
WITH
    IPv6StringToNum('2001:0DB8:AC10:FE01:FEED:BABE:CAFE:F00D') AS ipv6,
    reverse(ipv6) AS ipv6_big_endian,
    substring(ipv6_big_endian, 1, 8) AS lower_part_as_string,
    substring(ipv6_big_endian, 9, 8) AS upper_part_as_string,
    reinterpretAsUInt64(upper_part_as_string) AS upper_part_numeric,
    reinterpretAsUInt64(lower_part_as_string) AS lower_part_numeric,
    bitAnd(lower_part_numeric, 0xFFFFFFFFFFFFFF8) AS lower_part_numeric_bits_reset,
    reinterpretAsFixedString(lower_part_numeric_bits_reset) AS lower_part_lower_bits_reset_as_string,
    CAST(reverse(concat(lower_part_lower_bits_reset_as_string, upper_part_as_string)), 'FixedString(16)') AS fixed_ipv6
SELECT
    hex(ipv6),
    hex(ipv6_big_endian),
    hex(upper_part_numeric),
    hex(lower_part_numeric),
    hex(lower_part_numeric_bits_reset),
    hex(fixed_ipv6)

Row 1:
──────
hex(ipv6):                          20010DB8AC10FE01FEEDBABECAFEF00D
hex(ipv6_big_endian):               0DF0FECABEBAEDFE01FE10ACB80D0120
hex(upper_part_numeric):            20010DB8AC10FE01
hex(lower_part_numeric):            FEEDBABECAFEF00D
hex(lower_part_numeric_bits_reset): 0EEDBABECAFEF008
hex(fixed_ipv6):                    20010DB8AC10FE010EEDBABECAFEF008

1 rows in set. Elapsed: 0.002 sec.

Same, oneliner:
WITH
    IPv6StringToNum('2001:0DB8:AC10:FE01:FEED:BABE:CAFE:F00D') AS ipv6,
    CAST(concat(substring(ipv6, 1, 8), reverse(reinterpretAsFixedString(bitAnd(reinterpretAsUInt64(reverse(substring(ipv6, 9, 8))), 0xFFFFFFFFFFFFFF8)))), 'FixedString(16)') AS fixed_ipv6
SELECT
    hex(ipv6),
    hex(fixed_ipv6)

Doc was updated to correct bits to bytes


Validate critical updates

Node pool attribute "only_critical_addons_enabled" is valid only for default node pool.  While setting this value to true for other node pools won't cause an error, it could lead to unintentional expectations.  This will throw an error if an invalid configuration is input.

There's no actual change to the net-result of running the code.   This just prevents the end-user from expecting that setting only_critical_addons_enabled would apply to non-default node pools.  No matter what it's set to, non-default node pools are unaffected.  The change here is that an error will appear if someone tries to set something that's not possible.


Wrapper service for any command

Solution for https://github.com/HASwitchPlate/openHASP-custom-component/issues/50.

See in examples Set Long idle time. Any other setting applies like this.

"Set long idle time" is an example of something prone to create problems... maybe we should revise that command altogether...
Commands should really be a list of keywords not json objects...

What do you mean? Several commands require json formatted lines as parameters. jsonl is the strongest example. "Set long idle time" is just similar to that, but on other (settings) topic.
We need to set idle time 2 times a day, as we don't want the screen to go completely off, just during the night. So during the day the idle2 time is 0, while during the night it's 120. (it's in the example automations, I'd like to make a blueprint instead, to simplify it)

json objects in parameters is absolutely fine, my issue is with keyword

Let's make the keyword optional?

I say, lets remove the keyword and make the topic always */command

But then, how to modify setting? That was the most important point...

lets have a "config" service, but lets discuss that with @fvanroie

I can submit a PR of course for a separate service.
I thought that you were more concerned about having too many services as HA admins don't like that on long term. My goal was to have an all-in-one service, which was intended for more advanced use...

If we drop the existing services (change page, etc) in the long run we will not have more then 2 services
It is also important that we create services that can have their parameters sanitised, too much flexibility means we can't check the user input for mistakes...


[Samples] [CDC] Update samples about using SQLServer and PostgreSQL

Purpose

Update the samples to give instructions to use SQLServer and PostgreSQL in the Listening Mode

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

This PR can be merged after bumping siddhi-io-cdc version to 1.0.11 (After the SP 4.4.0 release is done)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


pre-install-payload:  avoid using sed to edit the containerd's configuration.toml

This is an idea that @stevenhorsman brought on our CI working group meeting today, inspired on recent changes of kata-deploy to adopt the tomlq tool (see https://github.com/kata-containers/kata-containers/commit/dd9f5b07b9243ca152c3d7fe9df472e2f31eb103).
In commit https://github.com/confidential-containers/operator/commit/603a5550f70a0f126285b2d63ac87edc992ab840 we introduced a handler for the disable_snapshot_annotations in containerd's configuration.toml (see https://github.com/confidential-containers/operator/blob/main/install/pre-install-payload/scripts/reqs-deploy.sh#L188). This handler is fairly complex and error prone because it uses grep/sed commands. A better alternative would be use a specific tool for editing toml like tomlq.
If we adopt tomlq then it will be needed to get it installed in pre-install-payload image (https://github.com/confidential-containers/operator/blob/main/install/pre-install-payload/Dockerfile).
Cc @fidencio @mkulke

An alternative is to re-write https://github.com/confidential-containers/operator/blob/main/install/pre-install-payload/scripts/reqs-deploy.sh in either Go or Rust which should have libs for editing toml files.

My suggestion wouldn't be to rewrite reqs-deploy.sh but have a small, dedicated CLI tool to adjust the the containerd configuration (instead of relying on sed or yq or other tools). The rust project uses toml-edit for the cargo command.
So, specifically the logic in: remove_nydus_snapshotter_from_containerd + configure_nydus_snapshotter_for_containerd. We can write unit-tests for it, have nice error messages, etc.

So, specifically the logic in: remove_nydus_snapshotter_from_containerd + configure_nydus_snapshotter_for_containerd. We can write unit-tests for it, have nice error messages, etc.

I'm not against that, but we end up with yet another tomlq / toml editor..
I'd prefer, I think, improving one of the 7201 options that are not working well for our needs.

I'm not against that, but we end up with yet another tomlq / toml editor.. I'd prefer, I think, improving one of the 7201 options that are not working well for our needs.

I don't think that would be case. the tools are largely ok, imo. the problem is how they are used. We could indeed, instead of using compiled code + a library, write a bash function invoking a cli tool comprehensively w/ tests, ci, fixtures, proper error handling, whatnot. In practice this is not a lot of fun to do in bash, so it's not done.

note: there is containerd config dump which dumps the content of the current configuration, including the resolved imports.
I wrote a snippet that would illustrate how a dedicated tool for changing the containerd config could look like: https://github.com/confidential-containers/operator/pull/313/files
if you look at the number of panics() and expects() it becomes obvious how many code paths there are for such a seemingly simple operation


Removes redundant buffer zeroing in UnicodeScalarProperties by using init(unsafeUninitializedCapacity:initializingWith:)

Removes redundant buffer zeroing in UnicodeScalarProperties by using init(unsafeUninitializedCapacity:initializingWith:)

@swift-ci Please smoke test


[BUG] loginWithRedirect redirects to root path after login

Describe the bug
I have an protected page with a path like /app that is checking the authentication using code like this:
if (!this.authState.isLoading && !this.authState.isAuthenticated) { mapLoginActions('loginWithRedirect')(); }
When a session is active, the redirect is not triggered (as expected). When there is no active session, this redirects to the hosted login form (as expected). Once the user has logged in he/she is redirected to / e.g. the home page, instead of /app.
To Reproduce
Steps to reproduce the behavior:

Add this code to an protected page of an app with hosted login:
if (!this.authState.isLoading && !this.authState.isAuthenticated) { mapLoginActions('loginWithRedirect')(); }
Ensure that no session is active.
Navigate to the protected page (triggering a redirect to the hosted login page)
Login

Expected behavior
I expect the user to be redirected to the protected page, not to the home page.
Additional context
For a manual login I'm using code like this:
const url = `${getFronteggSubdomain()}oauth/account/login?redirectUrl=${redirectUrl}`; authState.onRedirectTo(url);
In this case the correct redirect URL is passed to the login page and the redirect after login is correct. But on the protected page I want to check for a session and trigger a redirect only when no session is active. That's why I'm using mapLoginActions('loginWithRedirect')().
Frontegg Vue client version: 2.0.11

Hi @rotemzif1, when I add this to my protected route I still get the same behavior. As far as I can see, it makes no difference.

Ok thanks @martinzwirner we will investigate that soon and update you
Thanks!

Hey @martinzwirner, I double-checked and we are not supporting this behavior in any of our frameworks. Can you please submit an FR via one of our support channels? Thanks!


New UI compatability

The Build (hammer) and More Actions (three dots) icons are barely visible when using Lotus Light on the New UI. It makes it hard to see what I'm pressing.

Fixed in 1.11 https://github.com/blai30/Lotus-Theme/releases/tag/1.11

Fixed in 1.11 https://github.com/blai30/Lotus-Theme/releases/tag/1.11

I'm curious why it was chosen that the toolbar should be dark for the light theme? Themes like Catppuchin have a light toolbar but with dark icons.

I did not realize it was possible to change icon colors for the New UI, I just looked at the default light theme and saw it had a dark toolbar so went with that. The environments I test in does not have the hammer button, and the three dots button is slightly visible in yellow.
I will submit another update that reverts the toolbar to light color and attempt to change the icon colors. If this does not help, feel free to clone the repo and help contribute as I do not plan to maintain this theme any longer.


[Chore] - Speed up client tests

Checklist

[x] Client: I followed the coding and design guidelines.

Motivation and Context

We need to shorten the duration of the client test build.
Description

Removed as many production code imports as possible and mocked the needed components. This saves a lot of time when actually executing the tests
Steps for Testing

Do code review and make sure code quality is good

Code coverage
complaint-intercations.component.ts: 87%
Review Progress

Code Review

[ ] Review 1
[ ] Review 2

@FrankeLukas Test works fine locally.. I will have a look

@lschlesinger Sorry, need another one. Client style :| 😂


Limited ObjC generic extensions

Allow extensions of ObjC generics that don't depend on the generic parameters.

@swift-ci Please test and merge


How to achieve renderToNodeStream using React.NET ?

Thanks for this awesome library.
We are using this library in production to server render our react application. We are observing that our time to first byte has increased on some large pages due to the time spent in rendering on the server. It is recommended to use renderToNodeStream to improve TTFB but I am not sure how it can be done using React.NET . Can someone point me in the right direction as to how to improve TTFB while using this library for SSR ?

Hey sorry for the delay on this, forgot to respond.
It probably won't be possible for a while; this library does not use Node streams at all (it uses an embedded JS engine like Chakra Core or V8).
Until renderToString is deprecated we probably won't move away from that as the SSR mechanism.


Update zio-prelude to 1.0.0-RC29

About this PR
📦 Updates dev.zio:zio-prelude from 1.0.0-RC27 to 1.0.0-RC29
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-prelude" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-prelude" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #576.


Add a license

An open source license adds protections for the author, contributors, and users.
I suggest a permissive license like MIT or Apache2 if you're optimizing for impact and not afraid of other projects reusing the code.


Proposal: create --force

I've hit a couple scenarios where I want to recreate a machine from scratch, and I don't really care that there's already a machine with the same name. Right now, I do:
$ docker-machine rm $NAME || true && docker-machine create -d ... $NAME
...

Not a terrible approach, but it feels kludgy. This PR allows the following:
$ docker-machine create --force -d ... $NAME
...

Signed-off-by: Dave Henderson<EMAIL_ADDRESS>

/cc @nathanleclaire @ehazlett

Thanks for the contribution, but I'm -1 on this change.  I'd really prefer the remove operation to be a step which is explicitly taken.

@nathanleclaire - thanks - mostly I was looking for a feeling of whether this is a good idea... I'm sort of +0 on the idea myself, so I could be swayed ;)

Talked with Evan and he's also -1 -- closing :)

Thanks! :)


Daily Coding Problem: Problem #87

Daily Coding Problem: Problem #87 Good morning. Here's your coding interview problem for today. This problem was asked by Uber. A rule looks like this: A NE B This means this means point A is located northeast of point B. A SW C means that point A is southwest of C. Given a list of rules, check if the sum of the rules validate. For example: A N B B NE C C N A does not validate, since A cannot be both north and south of C. A NW B A N B is considered valid. Upgrade to premium and get in-depth solutions to every problem. If you liked this problem, feel free to forward it along! As always, shoot us an email if there's anything we can help with! No more? Unsubscribe. https://ift.tt/19fNRe4

This issue was moved to ryjen/challenges#4


Question : Add Fastapi-users library for authentication ?

I was asking myself if this would be a good idea to use this library :
https://github.com/fastapi-users/fastapi-users
Since it supports a lot of features out of the box, including oauth ...
What do you think ?

Hmm, I finished reading the README.md and I understand your point of view, you want to keep it simple, without third party.
I'm closing it, i'll reopen if you think we should do something about adding an option or something.

@sorasful
That is definitely an option, currently user is prompted to enter the project_name only ;) I can not see any contraindications to add something optional, maybe one that it takes a bit of exercise, messing with if stmts in some files, or just keeping two versions for those files. I just didn't want crazy setup by default (and didn't need it really).
Let me look at it this or next weekend.
If you have any thoughts, feel free to provide eg. repo based on this template with fastapi-users included, kicking it later into template is just an implementation detail.

Since FastAPI Users started to support SQLAlchemy few weeks ago (and dropped support for databases library), I've added option to choose new template based on FastAPI Users in this repository.


Exclude priors from charts of project analytics page

Make progress_density and progress_recall python API return data from the state file without priors.

@terrymyc close this one?


OTel compat: Enable Baggage propagator by default

Description
As per spec, baggage is activated by default

Proposed solution

enable baggage by default

Seems like it's only possible to register a single propagator or am I looking at the wrong location?

I don't think you're wrong. SDKs usually have a composite propagator to make that happen


Add a columns Showing Vaccines Distributed!

Currently the amount of vaccines administered are not being tracked, and I am sure this is a statistic many people would like to see. It would be great to get this information and display it on the site, ideally another column like tested.

Hi, We've seen vaccination summary data published. Will wait to see the format and frequency at which this is published in coming days and decide the best way to represent on the site.

Hi, We've seen vaccination summary data published. Will wait to see the format and frequency at which this is published in coming days and decide the best way to represent on the site.


Capture Task Pod's Most-Recent Error Logs As Output Artifacts

Change Overview
This PR updates KubeTask to capture the most-recent logs of a failed task pod as output artifacts in the ActionSet. This ensure that these logs are preserved after the pod is terminated to aid with debugging. The number of log lines to be captured is capped by the tail size parameter, which can be overridden by the new KANISTER_TASK_LOGS_TAIL_SIZE environment variable.
Although these logs are currently streamed to the Kanister controller, it may not always be easy to parse the controller's logs for specific task errors.
(The existing status.error.message which is normally filled with the entire pod spec is untouched. It can use some re-work in a separate PR.)
Test steps:
Deploy this blueprint:
cat<<EOF |  kubectl apply -f -
apiVersion: cr.kanister.io/v1alpha1
kind: Blueprint
metadata:
  name: task-errors
  namespace: kanister
actions:
  awscli:
    phases:
    - func: KubeTask
      name: echo
      args:
        namespace: "{{ .Namespace.Name }}"
        image: ghcr.io/kanisterio/kanister-tools:v9.99.9-dev
        command:
        - sh
        - "-c"
        - |
          aws -h
          exit 1
EOF

Deploy this ActionSet:
cat <<EOF | kubectl create -f -
apiVersion: cr.kanister.io/v1alpha1
kind: ActionSet
metadata:
  generateName: task-error-awscli-
  namespace: kanister
spec:
  actions:
  - name: awscli
    blueprint: task-errors
    object:
      kind: Namespace
      name: default
EOF

Check the ActionSet for recent logs:
$ kubectl -n kanister get actionset task-error-awscli-rtknm -ojsonpath='{.status.actions[?(@.name=="awscli")].phases}' | jq .
[
  {
    "name": "echo",
    "output": {
      "recentLogs": "sh: aws: command not found\n"
    },
    "state": "failed"
  }
]

Fixes https://github.com/kanisterio/kanister/discussions/1226.
Pull request type
Please check the type of change your PR introduces:

Improvement

Issues

https://github.com/kanisterio/kanister/discussions/1226

Test Plan

[x] :muscle: Manual
[x] :zap: Unit test
[ ] :green_heart: E2E

@pavannd1 I ran a few more tests with multiline log outputs. The marshalled outputs with multiline strings aren't very consistent. Sometimes, it's able to correctly handle \n, but other times, the line breaks are escaped. AFAICT, I don't think our code is modifying the outputs, right?
Tested with mysql:
    phases:
    - name: echo-help
      output:
        recentLogs: "mysql  Ver 8.0.29 for Linux on x86_64 (MySQL Community Server
          - GPL)\nCopyright (c) 2000, 2022, Oracle and/or its affiliates.\n\nOracle
          is a registered trademark of Oracle Corporation and/or its\naffiliates.
          Other names may be trademarks of their respective\nowners.\n\nUsage: mysql
          [OPTIONS] [database]\n  -?, --help          Display this help and exit.\n
          \ -I, --help          Synonym for -?\n  --auto-rehash       Enable automatic
          rehashing. One doesn't need to use\n                      'rehash' to get
          table and field completion, but startup\n                      and reconnecting
          may take a longer time. Disable with\n                      --disable-auto-rehash.\n
          \                     (Defaults to on; use --skip-auto-rehash to disable.)\n
          \ -A, --no-auto-rehash \n                      No automatic rehashing. One
          has to use 'rehash' to get\n                      table and field completion.
          This gives a quicker start of\n                      mysql and disables
          rehashing on reconnect.\n  --auto-vertical-output \n                      Automatically
          switch to vertical output mode if the\n                      result is wider
          than the terminal width.\n  -B, --batch         Don't use history file.

    phases:
    - name: echo-help
      output:
        recentLogs: |
          Enter password: ERROR 2003 (HY000): Can't connect to MySQL server on '<IP_ADDRESS>:3306' (111)

Test with pgsql:
    phases:
    - name: echo-help
      output:
        recentLogs: |
          sh: 1: pgsql: not found
      state: failed

  phases:
    - name: echo-help
      output:
        recentLogs: |
          psql is the PostgreSQL interactive terminal.

          Usage:
            psql [OPTION]... [DBNAME [USERNAME]]

          General options:
            -c, --command=COMMAND    run only single command (SQL or internal) and exit
            -d, --dbname=DBNAME      database name to connect to (default: "postgres")
            -f, --file=FILENAME      execute commands from file, then exit
            -l, --list               list available databases, then exit
            -v, --set=, --variable=NAME=VALUE
                                     set psql variable NAME to VALUE
                                     (e.g., -v ON_ERROR_STOP=1)
            -V, --version            output version information, then exit
            -X, --no-psqlrc          do not read startup file (~/.psqlrc)
            -1 ("one"), --single-transaction
                                     execute as a single transaction (if non-interactive)
            -?, --help[=options]     show this help, then exit
                --help=commands      list backslash commands, then exit
                --help=variables     list special variables, then exit

    phases:
    - name: echo-help
      output:
        recentLogs: "psql: error: connection to server on socket \"/tmp/.s.PGSQL.5432\"
          failed: No such file or directory\n\tIs the server running locally and accepting
          connections on that socket?\n"

@pavannd1 @viveksinghggits After putting more thought into this, I don't think this is a good implementation. Although it's convenient, the status subresource isn't a good interface to retrieve this kind of datapath logs because:

there is no easy way to determine the correct log size
logs are now duplicated in two places
potentially saving sensitive data in the subresource

Feels like we need to:

separate Kanister's system logs from datapath logs
provide a sensible ways to drain and consume the datapath logs

Hi @ihcsim,
Yes, I agree with the things that you mentioned there. And I think figuring out the data path logs from kanister system's logs is going to be a bit challenging.
I am assuming by data path log you mean the logs that are generated by commands that are there in phase's command.

Superceded by #1497.


Update skus.md

The following fact has to be mentioned for clarity:
"A standard load balancer has an SLA of 99.99% when connected to two or more healthy Azure virtual machines across different availability zones in the same region."

#please-close

#please-open

After reviewing this, we've determined not to commit the addition to our docs.
Thanks for your contribution.
#please-close


Update code with original repo

@mbleigh I am sorry, I was trying to update my codebase and it worked the other way round. Please delete this PR if possible.


doubt in ld_full_hit_lo/hi_dc2

Hi,
I have doubt in the below code of load forwarding logic
https://github.com/chipsalliance/Cores-SweRV-EH2/blob/a95fdb81ea6dc19239cfe2953ef00710a6f1cf2a/design/lsu/eh2_lsu_bus_intf.sv#L404-L411
I am quite not sure why inverse of ldst_byteen_lo/hi_dc2 is in OR with ld_byte_hit_lo/hi
if the byte location of dc2 data request matches with the byte location of the element in the buffer or  sw instr in pipe then ld_byte_hit_lo/hi signal becomes high which is enough to determine a load full hit.
why | ~ldst_byteen_lo_dc2[i] , | ~ldst_byteen_hi_dc2[i] ?

A full hit requires all of the respective bytes to be either not enabled or a hit.  The key to this is that the default is set to '1. The reduction AND then stays set for hits or for bytes that are NOT enabled.

I think was thinking why it was not simply
 ld_full_hit_lo_dc2 &= (ld_byte_hit_lo[i] ~^ ldst_byteen_lo_dc2[i]);
 ld_full_hit_hi_dc2 &= (ld_byte_hit_hi[i] ~^ ldst_byteen_hi_dc2[i]);

but the above one is a better, smarter way
Thanks for your reply :)


Norwegian-Bokmål nb not supported

Hi, thanks for your tool.
The Language Norwegian-Bokmål nb is not supported?
kind regards
Ole

Hi, it's added in version 0.7.4. Please give it a try on occasion.

Thank you! But: It uses now bk as language code not nb (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes#nb)

Hi, updated in 0.7.5 please give it a try.

Looks good, works great. Thanks alot!


[VS Code] Assertion violation: No local changes, but no transitions

After a colleague joined my shared session, I was able to edit a file but I could not backspace or undo my change.
We were both using VS Code.

@Jonesie Thanks for letting us know about this. This is definitely unexpected behavior. Can you confirm that you were able to backspace/undo properly before your colleague joined your session? Also, do you know whether they were able to edit successfully, and it was just you that lost the ability to backspace/undo?
Additionally, if you could run the Live Share: Export Logs command, and attach the result zip to this issue, that would be super helpful for investigating the problem. Thanks for helping us work through this!
// CC @grork

When you experienced this, did you perform an Undo?

Here's my logs
lslogs.zip
Im sure the undo and backspace worked fine before I started the session.  Im not sure exactly when it stopped.  My colleage was able to erase the changes I had made.  It was fine again after we stopped the session - but I may have restarted VS Code, I cant recall.
I think I also had the same issue in Visual Studio.
We will have another session today and I'll take more note of what happens.

Oh and the error message was displayed when I tried to undo.

This should now be improved in 0.3.384, let us know if you see this.


Changes to NRRD-Writer

fixes bug in Writer classe
fixes unit test

@markus-hinsche: unit tests now passing again

@markus-hinsche: Please consider to mention https://github.com/Project-MONAI/MONAI/issues/4238 and https://github.com/Project-MONAI/MONAI/pull/4259 in your planned PR at Project-MONAI/MONAILabel.


add: Support LUKS encryption using IBM CEX secure keys on s390x

Added the feature of IBM CEX card based LUKS encryption. Kindly review..

Hi @travier ,
Can i've a review on this?

Hi @travier ,
I've changed the schema part to Cex. Kindly review it.

$ butane % cat bin/arm64/openshift.bu
variant: openshift
version: 4.17.0-experimental
metadata:
  name: MachineConfig
  labels:
    machineconfiguration.openshift.io/role: master1
boot_device:
  layout: s390x-eckd
  luks:
    device: /dev/dasda
    cex:
      enabled: true

 $ ./butane openshift.bu -o openshift.ign --pretty && cat openshift.ign
# Generated by Butane; do not edit
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: master1
  name: MachineConfig
spec:
  config:
    ignition:
      version: 3.5.0-experimental
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - cex:
            enabled: true
          device: /dev/dasda2
          label: luks-root
          name: root
          wipeVolume: true

Hi @prestist ,
Could you please review the updated comment?.

[root@a3elp53 s390x]# ./butane boot.bu -o boot.ign --pretty
[root@a3elp53 s390x]# cat boot.bu
variant: fcos
version: 1.6.0-experimental
boot_device:
  layout: s390x-zfcp
  luks:
    device: /dev/sdb
    cex:
      enabled: true
[root@a3elp53 s390x]# cat boot.ign
{
  "ignition": {
    "version": "3.5.0-experimental"
  },
  "storage": {
    "filesystems": [
      {
        "device": "/dev/mapper/root",
        "format": "xfs",
        "label": "root",
        "wipeFilesystem": true
      }
    ],
    "luks": [
      {
        "cex": {
          "enabled": true
        },
        "device": "/dev/sdb4",
        "label": "luks-root",
        "name": "root",
        "wipeVolume": true
      }
    ]
  }
}

Hi, Is this pr ok to approve? or anything pending from my side?

@madhu-pillai ,  I am going to run through and review from my perspective, but will not be merging until I hear from @travier  since he had a lot of feedback, and I want to ensure his concerns are resolved.

Please make sure that you have resolved, and fixed any review comments, there seems to be one which has gramar issues still here, and more importantly a question about structure here

Hi @prestist ,
These reviews were already updated in the last commit. Sorry i missed to update the review message. Now done.

Hi @travier , Could you review the PR please?

OK, we need to split this in at least two commits:

vendor code update
addition of CEX support

OK, we can not update to 2.20 until we do https://github.com/coreos/butane/issues/558

Hold on, I'm doing the rebase / resplit.

This should be good now. I'll do another pass tomorrow. Then we need to stabilize all of that.

This should be good now. I'll do another pass tomorrow. Then we need to stabilize all of that.

Makes sense, so to be clear, we land this pr then separately stabilize? (preferred) I don't want to stabilize in this pr.

Alright, I've added more tests and fixed the case where they failed so this should be ready now.


Allow user to ignore the broken disk

For https://github.com/apache/incubator-doris/issues/2754

check_dir_existed() does not defined?

check_dir_existed is defined in be/src/olap/utils.cpp


microbit_display_clearDisplay in blocks should be changed to python_display_microbitClearDisplay

[x] openblockcc/openblock-blocks#6
[x] openblockcc/openblock-vm#24

In https://github.com/openblockcc/openblock-blocks/pull/6, the modification of the openblock-blocks project has been completed. Since the vm has not been modified, the pr is currently placed in a new branch. After the vm is synchronized and updated, it will be merged into the main branch.

Since the head word of the id is the device type, there is no problem with the current naming, this issue is a wrong decision.


Overflow Bug: Mobile

Removing display flex from .post__body h2, .post__body h3 will allow the headings to wrap to the next line instead of running outside of the viewport.

Setting white-space: pre to white-space: pre-wrap will allow for the code examples to wrap to the next line instead of outside of the viewport. This suggestion comes from an post Chris Coyier made on CSS-Tricks for getting pre tags to wrap better.

I don't think the phones I tested on are as small as the one reported in #36  but I did test on the following mobile devices and wasn't able to horizontally scroll at all:
Safari and Firefox on an iPhone XS , Chrome and Firefox on a Pixel 2 XL

There is however a tiny bit of horizontal scrolling that is present after applying the fixes listed above in the following desktop browsers:
Safari, Chrome, Firefox

Applying overflow: hidden to the main tag hides this tiny bit of overflow that is being caused by the full-bleed utility.
Let me know if you have any thoughts on these suggestions!

Fantastic, thank you @marcusrelacion!!


Function names

Typically functions names start with lower case letter while structs names start with upper case. I find it quite confusing that in GMG both functions and structs start with upper case.  I know this is a large and highly breaking change, but it would be good to eventually / slowly move to the upper/lower case name convention.

Uff, I somehow missed that. That is indeed a huge amount of work

fixed in PR#99


[OpenSTA] Need command to show the statistic on inter-connect Timing arc/parasitic load by the the Spef

This request raised based on Slack discussion with @tspyrou
Prompt
OpenSTA tool has option to show the annotated status for SDF reading, But Similar details are not available for SPEF reading.
% report_annotated_check -list_annotated
Not
Check type                        Total    Annotated   Annotated
cell setup arcs                     2746           0        2746
cell hold arcs                        2746           0        2746
cell recovery arcs                 1078           0        1078
cell removal arcs                  1078           0        1078
                                         7648           0        7648

Proposal
Looking for STA command to show the SPEF annotation status shows number of timing arc loaded/not loaded.

@dineshannayya I opened https://github.com/The-OpenROAD-Project/OpenSTA/issues/120 for this issue. I am closing this one since we can track it there.

I am reopening this since github automatically links the issues.

openroad commit 91b326968 updates opensta to include the report_parasitic_annotation command


Code of GenAD

Do you plan to release the training, inference code of GenAD along with data processing scripts ?

Thanks for your interest. We have developed an upgraded version based on OpenDV and GenAD. The paper, the code and the model will be made available later this month. Please stay tuned for our updates.
For data processing scripts, we recommend referring to follow the process in the Appendix of GenAD. It should be straightforward to replicate similar results.

Hi there, please check our new work at https://arxiv.org/abs/2405.17398 and https://github.com/OpenDriveLab/Vista

Amazing !


merge related commits into a single patch (git-am)

In the patch e-mail workflow, one can send a patch with multiple
commits, e.g. pacemaker is using this. These are then applied with
git-am. Packit did not understand this since only the HEAD commit of
such a contribution has patch metadata, the rest is `not
patch.present_in_specfile`.

With this change, we detect such situation and behave accordingly.

Example:

* c1 [HEAD] - some.patch, squash_commits: true
* c2 - [no metadata]
* c3 - [no metadata]
* c4 - beer.patch, squash_commits: true
* c5 - other3.patch, squash_commits: true
* c6 - [no metadata]

This should produce 3 patch files:

* some.patch, commits: [c1, c2, c3]
* beer.patch, commits: [c4, c5]
* hops.patch, commits: [c6]

TODO:

[x] test case

Needed for https://github.com/packit/dist-git-to-source-git/pull/29

recheck

recheck

recheck

recheck

Example:

c4 - beer.patch, present_in_specfile: true
c5 - other3.patch, present_in_specfile: true
c6 - hops.patch, present_in_specfile: false

This should produce patch files:

beer.patch, commits: [c4, c5]
hops.patch, commits: [c6]

I'd expect

beer.patch, commits: [c4]
other3.patch, commits: [c5, c6]

Did you mean?

c5 - other3.patch, present_in_specfile: false
c6 - hops.patch, present_in_specfile: true

c1 - some.patch, present_in_specfile: true
c2 - other.patch, present_in_specfile: false
c3 - other2.patch, present_in_specfile: false
c4 - beer.patch, present_in_specfile: true
c5 - other3.patch, present_in_specfile: true
c6 - hops.patch, present_in_specfile: false

This should produce 3 patch files:

some.patch, commits: [c1, c2, c3]
beer.patch, commits: [c4, c5]
hops.patch, commits: [c6]

It might be only me, but it looks very messy to me and I am not sure I understand the problem we are solving here.

The current setup will produce all the patches and put the ones with present_in_specfile: false. Is that right?

What is the problem with that, is it the order of the patches in spec-file? Or/and anything else?

We might want to support both cases:

"I want to have multiple commits to be transformed into one patch file."
"I want to combine commits generated from distgit patches (present_in_specfile: true) and the other ones (present_in_specfile: false)."

Solutions I have in mind:

Cannot we have some other metadata option for this case? e.g. ammend
What about merging all commits with the same patch name? (Wasn't that the thing we originally wanted?)

It might be only me, but it looks very messy to me and I am not sure I understand the problem we are solving here.
* The current setup will produce all the patches and put the ones with `present_in_specfile: false`. Is that right?

  * What is the problem with that, is it the order of the patches in spec-file? Or/and anything else?

Yes, this code merges commits into a single patch, as they are defined right now in dist-git.

* We might want to support both cases:

  * "I want to have multiple commits to be transformed into one patch file."
  * "I want to combine commits generated from distgit patches (`present_in_specfile: true`) and the other ones (`present_in_specfile: false`)."

I don't understand fully, let's discuss tomorrow.

Solutions I have in mind:
* Cannot we have some other metadata option for this case? e.g. `ammend`

I was considering this and it would be ideal. Annotate commits and tell packit they are meant to be in a single patch file.
The problem here is that we need to implement such functionality in d2s. In lua. And bash.

* What about merging all commits with the same patch name? (Wasn't that the thing we originally wanted?)

That's not the case, only HEAD commit has patch metadata with current implementation https://github.com/packit/dist-git-to-source-git/pull/29
We don't wanna merge them since that's not the reality in the end - they are multiple commits in a single patch file.

Looks good. I only want to make one thing clear:
What we are using as a squash separator? Any metadata commit or only those with squash: True? (Looks like the latter one.)
* the top commit with metadata and `squash:True` (=start)

correct

* commit without metadata (=end)

correct

* another commit with metadata => Can we use any commit with metadata as a separator?

right now it's inly the squash_metadata=True commit
Franta, I don't understand, how do you expect me to make the if condition then?
if not current_commit.present_in_specfile?

let's discuss on Monday if I need a fixup PR to this

He's yours Franta, I don't have anything else

OK. I've tried to describe my points here: https://github.com/packit/packit/pull/933#discussion_r469988494


Monarch - simple example with entities & methods

I am trying to build my own language definition.
The very simple example I am trying to build is:

have set of defined entities to which I assign methods,
to have those methods to have defined parameters,
get proper errors when names or entities or methods (including param types) don't match.

I actually want to use Monarch with this custom language definition to validate custom expressions for an app I am building.
Thanks!

Here is relevant documentation -- https://microsoft.github.io/monaco-editor/monarch.html


2020.3 Build Support

Well it's that time of the year.
The 2020.3 EAP is here. Time to see what needs to be done to support this platform.

Closed by #212


fix(libsinsp): invalid field_info check

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mrgian
Once this PR has been reviewed and has the lgtm label, please assign incertum for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 9a5784abbb757586bab29a3b0dc2e0d9d2450392

/milestone 0.19.0

Can you rebase on latest master to unlock arm64 CI? :) We switched runners from actuated to the cncf provided ones.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mrgian
Once this PR has been reviewed and has the lgtm label, please ask for approval from jasondellaluce. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

LGTM label has been added.  Git tree hash: 73ca4be8947c7afe5f912aafbd984eb56051fe66

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


feature: Add github Repo link next to the theme button

Is your feature request related to a problem? Please describe.
It would be better if we add the Github link of the repo
Describe the solution you'd like
A GitHub icon which follows to this github repo  in the navbar beside the theme toggle icon like this

I would like to raise PR for this if it is approved. @hkirat pls add your input

hey i can add a icon are you working on this?

Hey @amanasati01, I have already raised a PR for this


Update to latest uno/master

Clean up some legacy along the way.
This PR contains:

[ ] Changelog
[ ] Documentation
[ ] Tests

Added stuff from https://github.com/fusetools/uno/pull/1405 for testing - success in AppVeyor


To implement Quick Sort 3 Way Algorithm

To implement quick sort 3 way algorithm to the sorting selection

Hey Daiwei, I will work on this :)


feat: better error message when token is missing

Description
Include description of feature this PR introduces or a bug that it fixes. Include the following information:

Context: why is it needed? In case of bug, what was the cause for the bug?
When a token is needed to initialize IBMQ providers and we fail to provide one,  IBMQ.get_provider()  will fail with the following error message: No provider matches the specified criteria, which is misleading and causes confusion.
Concise description of the implemented solution.
IBMQProviderError is the only error that IBMQ.get_provider() could raise (see source code here). If we see this error and api_token is None, we will let the user know from our error message that the failure might be due to missing API token.
If any dependencies are added, list them and justify why they are needed.
No dependencies are added.

Please verify that you have completed the following steps

[x] I have self-reviewed my code.
[x] I have included test cases validating introduced feature/fix.
[x] I have updated documentation.

Codecov Report

Merging #13 (77e886a) into main (c252e58) will decrease coverage by 1.36%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   98.25%   96.89%   -1.37%
==========================================
  Files           7        7
  Lines         572      579       +7
==========================================
- Hits          562      561       -1
- Misses         10       18       +8

Impacted Files
Coverage Δ

...c/orquestra/integrations/qiskit/backend/backend.py
96.70% <42.85%> (-2.19%)
:arrow_down:

src/orquestra/integrations/qiskit/noise/basic.py
92.64% <50.00%> (-5.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c252e58...77e886a. Read the comment docs.


Add stdeb.cfg

I couldn't re-open the other PR, but could (somehow) restore the deleted branch.
This is updated and has been rebased on top of the current master. I'm going to try it out in a container.
connects to #78

@tfoote / @nuclearsandwich I actually just have no idea what I'm doing, so I've uploaded the error log here. Let me know if you have any suggestions.


Link to Lionbridge is broken

https://intlapps.lionbridge.com/windows does not navigate to a valid page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fe32af9-271f-3e4a-91bc-bffd3f09f886
Version Independent ID: 3b9e8778-e7bc-3268-1466-881890455a16
Content: Use the Multilingual App Toolkit - UWP app developer
Content Source: windows-apps-src/design/globalizing/use-mat.md
Product: windows
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Hi, @bwaldbaum, the link is fixed now, so I'll go ahead and close this issue. Thanks! ~Steve


fix: prevent tool tip from filling container

Details

This PR fixes a regression from https://github.com/Expensify/App/issues/33542 where tooltip was misaligned.
Reason for regression:
For fixing layout issue on Android where Text component was not taking full available width, alignItems: 'stretch' was applied to parent container in UserListItem component. However on web this caused ToolTip component to fill the parent container instead of wrapping its child text content.
To fix this issue, the ToolTip element in UserList item is wrapped in another Text tag so that ToolTip will not inherit any flex properties from its parent flex container. This fixes the regression that occured on Web platform.
Fixed Issues

$ https://github.com/Expensify/App/issues/35691
PROPOSAL: https://github.com/Expensify/App/issues/35691#issuecomment-1924650444
Tests

Open the App
Login with any account who has an active Workspace
Navigate to Workspace Settings -> Members
Verify that all items in member list occupy full width and there is no large gap between the tag and display name.
Verify that tool tips over member list items are aligned properly on Web & Desktop.

[x] Verify that no errors appear in the JS console

Offline tests

Open the App
Login with any account who has an active Workspace
Navigate to Workspace Settings -> Members
Verify that all items in member list occupy full width and there is no large gap between the tag and display name.
Verify that tool tips over member list items are aligned properly on Web & Desktop.

QA Steps

Open the App
Login with any account who has an active Workspace
Navigate to Workspace Settings -> Members
Verify that all items in member list occupy full width and there is no large gap between the tag and display name.
Verify that tool tips over member list items are aligned properly on Web & Desktop.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/6880914/c854ff79-1406-42f7-a350-b9e90492e691

Android: mWeb Chrome

https://github.com/Expensify/App/assets/6880914/7d6f325c-277f-4bbf-8187-75c57f2425bd

iOS: Native

https://github.com/Expensify/App/assets/6880914/6806b536-ddda-4d1a-be51-9683edf3914d

iOS: mWeb Safari

https://github.com/Expensify/App/assets/6880914/b41d7385-57a3-4e9c-a305-137e45f53204

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/6880914/838d7d75-926d-4572-8db9-9b64e34dab31

MacOS: Desktop

https://github.com/Expensify/App/assets/6880914/1e74a18a-05b6-4459-8a7a-7a673173e815

@sobitneupane when you have time, could you review the PR please?

@sobitneupane Root cause and the fix is correct. align-item:flex-start on parent container will cause Text elements to wrap early on native devices. So we need to use align-items:stretch. There is no other fix for this.
What happened with ToolTip is something very  specific to Web. Tooltip is an immediate child of the container where align-items:stretch is defined, it uses the Text components width to position itself. Since the text element is taking full width Tooltip uses with width to position itself even though text content is short.
An alternative approach would be to use styles.alignItemsStrech only on native as the issue is present only on native.
We could introduce an isNative check in UserListItem component to swap the style on web.
const platform = getPlatform();
const isNative = platform === CONST.PLATFORM.IOS || platform === CONST.PLATFORM.ANDROID;

Or we could create a separate UserListItem.native.tsx for native devices.

@aswin-s We cannot introduce platform specific code in UserListItem. But if it is the only solution, we can add something similar to src/styles/utils/italic or src/styles/utils/wordbreak.

@sobitneupane Moved container styles into platform specific files. We cannot make it as generic like wordWrap because alignItemsStretch has other uses on web.

Thanks for the update @aswin-s. Can you please retest in Web and Native and re-upload the screen recordings since we totally changed the approach.

@sobitneupane Updated the screengrabs

@roryabraham would you like to review the PR as you also reviewed the proposal? I don't know why melvin assigned me 🤔

@aswin-s Looks like we've got a merge conflict here. Mind taking a look and resolving it?

@sobitneupane Merged master. However TextWithTooltip component seems to be broken on main.


bug on VisFly/utils/sceneDatasets.py load_scenes() function when running in Pycharm2024.2.4

hello ViSYS team! when i try to run the code in pycharm i meet a bug about scene_paths (but the same code can run on VSCode, no idea why ), i have tried except the scene_paths and let it be'[ ]' but still can't make it work
i am new to habitat-sim, can you provide some idea on how to fix this on pycharm, or what part in the habitat-sim documentation can i get some help about the load_scenes() function in utils/sceneDatasets.py
thanks for your effort!
Traceback (most recent call last):
File "/opt/pycharm/plugins/python-ce/helpers/pydev/pydevd.py", line 1570, in _exec
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/opt/pycharm/plugins/python-ce/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/examples/crossing/rl.py", line 169, in
main()
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/examples/crossing/rl.py", line 127, in main
model.learn(training_params["learning_step"])
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/VisFly/utils/algorithms/ppo.py", line 1002, in learn
return super().learn(
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/VisFly/utils/algorithms/ppo.py", line 970, in learn
return super().learn(
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/VisFly/utils/algorithms/ppo.py", line 565, in learn
total_timesteps, callback = self._setup_learn(
File "/home/anaconda3/envs/VisFly/lib/python3.9/site-packages/stable_baselines3/common/base_class.py", line 423, in _setup_learn
self._last_obs = self.env.reset()  # type: ignore[assignment]
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/VisFly/envs/MultiNavigationEnv.py", line 68, in reset
obs = super().reset()
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/VisFly/envs/multiDroneGymEnv.py", line 173, in reset
self.envs.reset()
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/VisFly/envs/base/droneEnv.py", line 219, in reset
self.sceneManager.load_scenes()
File "/home/Proj_folder/UAV_3D/habitat_sim_based/VisFly/My_Project_Using_VisFly/VisFly/utils/sceneDatasets.py", line 690, in load_scenes
scene_paths = next(self._scene_loader)
StopIteration
python-BaseException

i found thar this error was caused by the different working directory of pycharm, which make ChildrenPathDataset(self.root_path, type=scene_type, semantic=semantic) get empty due to the wrong file dirctionary(which should be a json file)

i found thar this error was caused by the different working directory of pycharm, which make ChildrenPathDataset(self.root_path, type=scene_type, semantic=semantic) get empty due to the wrong file dirctionary(which should be a json file)
sorry to disturb


Remove manifest: HDSentinel.HDSentinel.Pro version 6.20

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Reason for removal: https://github.com/microsoft/winget-pkgs/pull/166628#issuecomment-2276186857

URL: https://www.harddisksentinel.com/hdsentinel_pro_setup.zip
OK
(Automated message - build 912)

Close with reason: Package still available;

Hi @stephengillie,
I want to remove this manifest because it is a duplicate of JanosMathe.HardDiskSentinelPro, could you approve this PR instead?


feat: Add directive to disable manual tag

This PR introduces a directive to disable the addition of the manual tag to generated swift_library targets.
I understand the intent behind the tag and am ok with keeping it the default. But for more advanced users who understand that they need to pass the apple platform type configuration, it is useful to be able to build globs of these targets without a dedicated build test target.

I'd also consider adding an example that tests this behavior

I agree that we should have an example use this tag. How about we update the pkg_manifest_minimal example to use it. I believe it is a non-Apple, Swift example.

Ok I think I addressed all of your comments @cgrindel
Please let me know if I should change anything else

Sweet thanks for updating!


dependencies: Allow h5py 3.x also

Fixes #82

Failing on Python 3.7, seemingly due to a numpy compatibility issue


error in script/create-dist

Hi,
there is a typo in create-dist script.
when I try to create the dist output file, the script search ffmpeg.dylib file in a folder called native_mksnapshot, but it is not available in dist/main/
I guess that the folder is dist/main/ffmpeg.
could you confirm it?
Thanks

@manang How exactly you run the create-dist script? Any arguments?
What type of build you have run before that? Just script/build without any arguments?

Hi,
I launched
$ script/update -t x64
$ script/build -t x64
and after
$ script/create-dist

Hey there,
It's been a long time coming but the libchromiumcontent repository is being archived as it is no longer used in the Electron build system (🎉 this is a good thing).
If your issue is still relevant to Electron in it's current build system (please verify first) then you should probably raise a similar issue on electron/electron.
Thanks 😄


stop rotation?

How do I stop the constant rotation?  It makes studying the object hard (and I find it annoying).
Also, are there docs for the options?  I scoured the source and found these options.  Am I missing any?
    var madeleine = new Madeleine({
      target: 'stlview', // target div id
      data: 'http://localhost:3000/static/L4.stl', // data path
      path: '/static/src', // path to source directory from current html file
      material: 'matt',// matt skin wire
      showStatus: false,
      backgroundColor : "DADADA",
      objectColor:      "FF9999",
      viewer: {
        create: true,
        height: 300,
        width:  window.innerWidth/3,
        theme : "light", // default dark lime rose lego toxic cobalt light soft
        notappend: false,
      },
      camera : {
        sight: 45,    // Vertical Field of View
        near:   1,    // Near Field Distance
        far: 100000,  // Far Field Distance
      },
      rotateSensitivity : 0.005,
      scrollFactor      : 20,
      zoomSensitivity   : 100,
    });

I stopped it by hacking the code but I don't like to do that.
Another question?  How do I replace one url with another in-place?

@mark-hahn did you manage to solve the "replace one url with another in-place"?

Sorry but I don't remember.  I probably would have mentioned it here if I did.


"Cocești" is listed in the drop-down menu

Description:
When user writes "Cocești" the location appears in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Cocești"

Expected results
The location appears in the drop-down menu as "Cocești, Alba (Avram Iancu)"


Add Error Tests for Examination Regulation

there is already an issue for this https://github.com/upb-uc4/hlf-api/issues/89


Reduce distribution size

I've got a relatively simple Atom Shell app that I'm looking to distribute. I'm packaging it by copying my app directory into Atom.app/Contents/Resources, then renaming Atom.app to MyName.app and zipping it up.
My app directory is 2.3 mb but the resulting ZIP is 108 mb. Since the whole of the Atom editor for OS X is  75mb, I figure I must be adding some unecessary stuff to the archive. Is there anyway to reduce the file size? I'm storing on S3 so I'm keen to keep bandwidth down.

Are you running the zip command with the --symlinks option?

That took it down to 106mb haha. It hardly seems to be getting compressed at all. Atom itself is 216mb and goes down to 79mb zip, whereas mine stays around 100mb before and after. I'm using a build from grunt-download-atom-shell, downloading version 0.20.3. Would I be able to make it smaller (or more compressible) building myself?

I'm closing this since it is a question not an issue, https://discuss.atom.io/c/atom-shell is a better place for this.

The zip distribution on Mac is created via zip -r -y.


[loc][query][VSCode] Please clarify the strings

Hi, we have a question from our translator. Can you help please? Thanks!
Source:
Commit Staged
Commit Staged (Signed Off)
File Name:
extensions\git\package.nls.resx
Resource ID:
".resx", 0; "command.commitStaged"
".resx", 0; "command.commitStagedSigned"
Query:
Does this string means "commit has been staged?" or "commit the staged information/data". Thanks.

It means "Commit the staged files", in which "Commit" is a verb.


Multiple CPUs not supported!

Your Windows build number:  (Type ver at a Windows Command Prompt)
Microsoft Windows [Version 10.0.17134.112]

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)

gabe@LLLightning:/mnt/c/Users/Admin/Desktop$ nproc

56
gabe@LLLightning:/mnt/c/Users/Admin/Desktop$ numactl -s

physcpubind: 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55
No NUMA support available on this system.

What's wrong / what should be happening instead:
I should be able to see and use both CPUs as any Linux system.
nproc returns 56 when it should be returning 112
What's wrong? Processes that should use all cores are only use the cores and threads on a single processor. The other sits there idle.

OMG! WSL in Intel Xeon! 🤯 Did you try cat /proc/cpuinfo?

Yes! It shows 56 processors.
cpuinfo.txt

Interestingly, top sees all 1.61 terabytes of RAM. Half of this RAM belongs to the processor it can't see!

sockets: 2
Currently only a single socket is supported. Same as #1115

#1115 is an oldie but a goodie. I see we've gone from 88 to 112 logical cores since the previous rig.

Also -- and this is just me -- I think the dev team is prioritising #1115 all wrong. It seems to me that the whole team should get new dual socket Platinum 8180s so the problem can be thoroughly investigated. 😉

Don't forget at least a terabyte or three of RAM!
Funny you should say this about the core count -- seems to work fine on the Knights Landing CPU (mine has 272 threads -- though I don't know if all were recognized)

This is just curiosity, what happens when disable hyper-threading?
Do you see only 28 cores?

Yes, good call. Turns out disabling hyperthreading indeed reduces core
count to 28!
On Tue, Jun 19, 2018 at 6:50 PM 0xbadfca11<EMAIL_ADDRESS>wrote:

This is just curiosity, what happens when disable hyper-threading?
Do you see only 28 cores?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/WSL/issues/3314#issuecomment-398580551, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrXBrT8NSf_FcIAV_3cLr2FeWFgDjbqks5t-Y49gaJpZM4Ut-zO
.

Thank you for try.
I anticipated that it will recognize well if it is less than 64 cores that can fit in one Processor Group, but it is out of forecast.

Update on this. After the latest BIOS updates and windows updates, I did some more digging.
I found the following (HT=hyperthreading, NUMA=non-uniform memory access):
+HT+NUMA = 56 recognized; one cpu
+HT - NUMA = 48 recognized; unknown cpu
-HT -NUMA = 56 recognized, BOTH CPUs
-HT +NUMA = 28 recognized, one CPU
I think whatever this "processor group" thing you mentioned is, probably holds the key here.

Some information:
I encounter the same problem, but maybe there is some information to be useful.
I have two workstations. The one of two has two sockets with Intel Xeon CPU E5-2699 v3 2.3 GHz, so in the machine, named as WORKSTATION, I have a 72 logical processors workstation (2 sockets * 18 physical cores per socket* 2 hyper-thread per core). Another machine I have is with two sockets with Intel Xeon CPU X5650 2.67 GHz, named as HOME, totally 24 logical processors (2 sockets * 12 physical cores per socket* 2 hyper-thread per core).
In the WORKSTATION machine, installed Windows 10 Pro with 1803 update and type ver in CMD:
Microsoft Windows [Version 10.0.17134.228]
In the HOME machine, installed Windows 10 Enterprise with 1803 update and type ver in CMD:
Microsoft Windows [version 10.0.17134.228]
The WSL installed on HOME is Ubuntu 16.04.5 LTS.
The WSL installed on WORKSTATION have several versions, include Ubuntu 16.04.5 LTS, Ubuntu 18.04.1 LTS, Kali GNU/Linux Rolling, Alpine Linux v3.6, CentOS 7.
On WORKSTATION, ONLY one socket can be recognized by WSL, thus I only can use the half of this machine power to computing something.
but on HOME, Two sockets can be fully recognized by WSL. I don't know why it happens. I can think the differences are either OS version (Pro vs Enterprise) or the supported max cores limit by WSL.
Some related COMMANDS:
Check sockets/physical cores per CPU/Logical processors, using the following commands in Windows 10 CMD:

systeminfo
wmic and enter: cpu get, then check item number(sockets number), numberoflogicalprocessors, numberofcores
Windows task manager

In WSL:
lscpu
or
The socket number or CPU number
cat /proc/cpuinfo| grep "physical id"| sort| uniq| wc -l
The physical processors
cat /proc/cpuinfo| grep "cpu cores"| uniq
The logical processors
cat /proc/cpuinfo| grep "processor"| wc -l


add support for --dirty and --dirtyreload

This PR is rework of the following PR.
https://github.com/ultrabug/mkdocs-static-i18n/pull/248
Hi! I issued a PR once a long time ago.  Long time no see.🙂
description
I found mkdocs supports incremental builds (--dirty and --dirtyreload options), but this plugin does not.
This PR changes to support them.
motivation
If there are many documents, not supporting --dirty and --dirtyreload will cause extra time to build.
(For instance, my documents have been getting larger and larger, eventually taking as long as two minutes to hot reload!)
This PR allows hot reloads to be performed in a fraction of the time.
remarks
Frankly, I think dirty flag should be passed from mkdocs. However, since it is currently not possible to obtain the flag from mkdocs, I implemented this by referencing sys.argv.

I'm sorry @AngryMane but I find this solution too complicated compared to the initial sys.argv approach :(
I'd rather accept the previous PR than modify so much things for such a simple feature...

@ultrabug
I feel the same 😄  I'll rework tomorrow!

Arigato :bow:

I fixed.

Yes, thanks @AngryMane


fix create project docs for Azure

Description
Fix the "Create Project" section for Azure Dev Ops.
Pull Request Type

[x] Documentation content changes
[ ] Bugfix / Missing Redirects
[ ] Docusaurus site code changes

Hi! Is this PR still relevant?


NOCT_SAM may not handle effective irradiance correctly

Describe the problem
The noct_sam temperature model has an effective_irradiance input, which would normally have a value less than poa_global, mainly due to reflection losses.  This is implemented internally as an adjustment to the transmittance_absorptance parameter.  However, this  adjustment produces some questionable results.
Code fragment to demonstrate the problem
from pvlib.temperature import noct_sam

gpoa = 800
geff = gpoa * 0.75

wind_speed_10m = 1.0 / 0.51

NOCT = 41.6

# open circuit and max power module conditions for reuse
module_oc =dict(noct=NOCT, module_efficiency=0.00)
module_mp =dict(noct=NOCT, module_efficiency=0.20)

weather0 = dict(poa_global=gpoa,
                temp_air=20,
                wind_speed=wind_speed_10m,
                )
print()
print('mod temp under gpoa')
print('oc:', noct_sam(**weather0, **module_oc))
print('mp:', noct_sam(**weather0, **module_mp))

weather1 = dict(poa_global=geff,
                temp_air=20,
                wind_speed=wind_speed_10m,
                )
print()
print('mod temp under geff (what I would expect to be correct)')
print('oc:', noct_sam(**weather1, **module_oc))
print('mp:', noct_sam(**weather1, **module_mp))

# use the effective_irradiance input
weather2 = dict(poa_global=gpoa,
                temp_air=20,
                wind_speed=wind_speed_10m,
                effective_irradiance=geff,
                )
print()
print('mod temp under gpoa using separate geff input (different/incorrect)')
print('oc:', noct_sam(**weather2, **module_oc))
print('mp:', noct_sam(**weather2, **module_mp))

# replicate the tau_alpha adjustment that is inside noct_sam
weather3 = dict(poa_global=gpoa,
                temp_air=20,
                wind_speed=wind_speed_10m,
                transmittance_absorptance=0.9 * geff / gpoa,
                )
print()
print('mod temp under gpoa with tau_alpha adjusted externally (same problem)')
print('oc:', noct_sam(**weather3, **module_oc))
print('mp:', noct_sam(**weather3, **module_mp))

Code fragment output
mod temp under gpoa
oc: 41.6
mp: 36.8

mod temp under geff (what I would expect to be correct)
oc: 36.2
mp: 32.6

mod temp under gpoa using separate geff input (different/incorrect)
oc: 41.6
mp: 35.2

mod temp under gpoa with tau_alpha adjusted externally (same problem)
oc: 41.6
mp: 35.2

Comments on output
Note that under open circuit conditions the module temperature remains at 41.6 in the third and fourth cases despite the reduction in irradiance, which is not logical. The biggest surprise comes when you set geff to small values, like 20% of gpoa because the module temperature then goes below ambient.
Additional context
The noct_sam function in pvlib appears to correspond very closely to the code in SAM itself, so this problem would exist there too.  But it is much easier to demonstrate it here.
Solution
Reflected irradiance does not contribute to heating or electricity generation, so a single irradiance input for this thermal model is enough.

Update on this isseu: SAM code has changed to use effective_irradiance instead of poa_global for the noct_sam temperature model https://github.com/NREL/ssc/pull/1233. SAM considers the change to be correcting a bug.
I think pvlib should correct its code, with liberal in-line comments to document that the correction deviates from the published reference.

I support a correction (of course).  I haven't had time to look closely at the change in SAM though. Did they write anything about impact on results?  Since it has been this way for so long we might consider offering both behaviors.


Implement automatic replication of pointer target when an allocator is provided

It's a design decision to never duplicate memory objects automatically. Use allocator only for string -> array and object -> conversion.