[Bug] Issue in Basic Calculator

Description

Multiple operators
Please assign me to fix this issue
(Under GSSOC'24 contributions)
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

hii @Rakesh9100 ,
I'm GSSoC'24 contributor , I have experienced on HTML, CSS, JS, and react.js , so I want to work on this issue,
so, kindly requested to you to assign me the task.

Hi, I would like to contribute on this project. I can help to fix this issue. Assign me this task, and I won't disappoint you. Thank you.

Go ahead @tanu-agarwal0101

Thank you @Rakesh9100

Status of your PR pls @tanu-agarwal0101


Its recommended to roll the decryption key over every 30 days...

Hi support,
It's recommended to roll this key every 30 days. Is there any plan to automate this within either AAD Connect itself or another mechanism? It seems like a bit of an oversight to require this be done manually.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9eb97eff-d72e-ffa6-1365-5419e93ed82a
Version Independent ID: 5c8b677b-f4cd-0bb5-c7d6-9b1ef903dad4
Content: Azure AD Connect - Microsoft Entra
Content Source: articles/active-directory/hybrid/how-to-connect-sso-faq.yml
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@forward-observations
Thanks for your feedback! We will investigate and update as appropriate.

Hi @forward-observations

Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1


Bug: "Type mismatch, expected text" in properties field

Describe the bug
Breadcrumbs writes the properties as down: ['My File'] instead of down: "[[My File]]", causing Obsidian to create a small warning with the message Type mismatch, expected text. The name of the referred file in the property does not appear as a link either, but breadcrumbs seems to work otherwise as expected and can be navigated in the matrix view.
To Reproduce
In a new Obsidian vault, with only breadcrumbs installed, and a default configuration where we enable writing all relationships to the files.
Given two files My Parent File and My Child file, if I set the relationship of both files by writing only to the child the following:
---
up: "[[My Parent File]]"
---

and then ask breadcrumbs to regenerate the indices and write to all files, the content of the parent file is written as:
---
up: ['My Child File']
---

Expected behavior
Links are written to the property field in the "[[Name of file]]" format instead, such that obsidian recognizes it as a working link. In the above example, I would have expected up: "[[My Child File]]" instead of up: ['My Child File'].
Screenshots

Desktop (please complete the following information):

OS: Manjaro (Linux)
Obsidian 1.5.3
Breadcrumbs 3.6.11

Additional context
After some more experimenting, if the files are located in folders and subfolders, writing the hierarchy can become quite mangled. I believe this can be because BC likely checks if the files are already written in the hierarchy, but because the strings "[[File]]" and ['File'] are not the same, it writes it twice. However, this bug might be unrelated and warrant its own issue ticket.

This is from another vault. The blue links I added manually and are of the type "[[File]]" , the white links are the ones added by BC and are of the type ['File']
On the other hand, I'm completely new to Obsidian. I've searched thoroughly for this bug, but maybe I don't know the correct keywords to identify it and google yields no useful results.

Hey, thanks for the detailed issue!
I'm rewriting the plugin from scratch, please see the V4.md file in the root of the repo for more info.
A couple of the issues you mentioned here are resolved in the new version

Of course feel free to test the beta version using BRAT, and let me know your thoughts :)
Keep it open for now. I'll go through and close out any resolved issues once v4 is live.

I'm playing around with v4 and it seems to do exactly what I expected from it. I haven't had time to go in-depth but it looks promising.
I'm migrating an extremely large wiki (believe me, it's VERY big, at least in terms of file count) from TiddlyWiki into Obsidian. I'll give feedback if I experience any slow-downs or related performance issues. So far so good! :)

That's great to hear!
The code should be alot more performant now as well. I don't know how many notes you've got, but it should handle them better

I can confirm that with 1100 .MDs its working nicely :D
Sorry that I hijack this thread. Can you confirm that Folders can be used as the source of edges? I can't find where to enable this option but it shows as done in v4.md. If it should indeed be enabled, I'll open a new ticket with a full report :)

Great! I can confirm it works! :D
I haven't found a way to refresh + freeze all pages at once, so I'm doing so as I go, but so far v4 works like a charm

That's one of the breaking changes, it's now BC-folder-note-field.
If you open up the Obsidian console, then rebuild the BC graph, you should see a log about explicit edge sources, or something similar.  This is my bad. I read you, then went on with my usual stuff, and when I came back to this i had a nagging feeling I was forgetting something about how the property was spelled (hence my question). Thanks! I can confirm that it does indeed work :)
As for giving a special meaning to the name of the file, maybe it's now even needed if the user sets up a template. Once everything is in place, there is no need to recurse downwards

Please clarify your point about folder notes and templates, I don't follow

Please clarify your point about folder notes and templates, I don't follow

I think some of the plugin that handle folders, such as AidenLx's Folder Note, have an option* to define the default content of new Folder Pages when they are added (ie a template for new folder notes). Meaning that I could add BC-folder-note-field: down to this template and incorporate it seamlessly into my workflow
*At least I believe I've seen this template option somewhere. Maybe it was a different Folder Note plugin

Oh cool! Yeah, that integrates really well, thanks for sharing.
Gonna point to this issue #504 for when I update the docs on this feature

Yeah, nice :)
Indeed, the content isn't implemented yet!

I'm gonna close out the original issue as complete. V4 isn't fully live, but is quite stable at this point. Thanks again for all the detail! Please do share any V4 feedback, it's really helpul :)


Unknown 'type' field in sensor validation

Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/pi/ve/lib/python3.7/site-packages/mqtt_io/__main__.py", line 38, in <module>
    main()
  File "/home/pi/ve/lib/python3.7/site-packages/mqtt_io/__main__.py", line 33, in main
    mqtt_gpio.run()
  File "/home/pi/ve/lib/python3.7/site-packages/mqtt_io/server.py", line 1137, in run
    self._init_sensor_inputs()
  File "/home/pi/ve/lib/python3.7/site-packages/mqtt_io/server.py", line 518, in _init_sensor_inputs
    sens_conf, sensor_module
  File "/home/pi/ve/lib/python3.7/site-packages/mqtt_io/config/__init__.py", line 198, in validate_and_normalise_sensor_input_config
    return validate_and_normalise_config(config, sensor_input_schema, allow_unknown=False)
  File "/home/pi/ve/lib/python3.7/site-packages/mqtt_io/config/__init__.py", line 106, in validate_and_normalise_config
    "Config did not validate:\n%s" % yaml.dump(validator.errors)
mqtt_io.exceptions.ConfigValidationFailed: Config did not validate:
type:
- unknown field

Originally posted by @imkebe in https://github.com/flyte/mqtt-io/issues/185#issuecomment-796883370

@imkebe Could you please install version 2.1.0 and add the following to your config file:
reporting:
  enabled: yes
  issue_id: 186

and run the software again? This will send an error report that will include more information to help me diagnose this.
See the reporting documentation for information about this reporting feature.

@flyte I need few days more since my sensor started to randomly change address. Then I can validate.

Don't worry about the issue being closed. Just reply when you've got time
to test it and I'll reopen it.
On Mon, 29 Mar 2021, 22:07 no-response[bot], @.***>
wrote:

Closed #186 https://github.com/flyte/mqtt-io/issues/186.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/flyte/mqtt-io/issues/186#event-4523889988, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIZTWAKPOMDCGJILHGFXILTGDTXJANCNFSM4ZBA5GLA
.


Show a tooltip on an annotation

Is your feature request related to a problem? Please describe.
For a point annotation, I would like to display lots of information on hover, that would take too much space in an annotation label
Describe the solution you'd like
Add a tooltip to an annotation just like a regular point
Describe alternatives you've considered
Use a series for my annotaitons. This is the workaround I'm currently using, but annotations would be better

Thank you!

Is this feature has been added to Apex Chart Or You have found an alternative?

Is there a way to do this?

Did anyonen find a way ?

?


[Proposal] Exchange Select and Reminder buttons

It would be more obvious (and smarter and slicker to operate), if the Select and the Reminder buttons would exchange their positions in the note options drawer. Not only is the Select tool hidden and needs the user to do one more action, firstly pull the drawer open, it is probably also much more often utilised by the majority of users as it opens up many more subsequent operations.

I thought about moving the select button first thing at the top. However, I also thought about adding an edit button at the same place (at the top), that's why the Select button is currently at the bottom.
The reason I thought about adding an edit button, is that, when notes open in Reading Mode by default, the user might want to edit the note sometimes rather than opening it in Reading Mode.
I'm hesitant about this decision, because there's already an edit button in Reading Mode itself.
What do you think?

Sorry, I'm confused: Firstly, where do I find the Open In Reading Mode By Default toggle in beta 2? Or is your question about two hypothetical options at once?

Currently we're having a Reading Mode button in the note options drawer when your choice in folder options is reading mode already. Would what you're asking not simply be a continuation of the duplicate options? If so, I'd opt for a select button there, instead.
But another possibility we're to keep the Select button full width and that way make it more visible, make it easier to tap, and stress the significance of this new function.

Yup, less confusing, less redundancy.

I'm afraid the last discussion here above led away from my initial proposal to make the "Select" button more visible...


chore: Update dbus to 0.6

Oh, this is more complicated... I would appreciate help.

Yup :) this is why I haven’t updated the dependency yet. There’s no particular help to offer, but I think that every struct will need to be altered. Unless there’s a bug, I’d probably hold off on this until I have time to do myself.

I've run into a relevant issue: dbus::Error doesn't implement Sync in v0.2.0, which is preventing me from using anyhow::Context on errors from this library when compiling on Ubuntu.

Ah, sorry this is an issue. I haven't had much time lately to devote to further maintenance, but updating dbus is definitely on my radar.

I'll be closing this in favor of a port to zbus. We can revisit if the port doesn't work out.


kam doesn't display version

Describe the bug
kam version command doesn't display the CLI version of kam
To Reproduce
Steps to reproduce the behavior:

Build the binary from master
go build ./cmd/kam
Execute ./kam version
Observe the version not displayed

Expected behavior
Executing kam version should print the release version of Kam
Example
kam version v0.0.13-0-gbfb8090

/kind bug

Do make bin which creates a binary in bin.   Or you can do make install which creates a binary in $GOPATH/bin/kam


Consider renaming RequestCtx to R

Currently the type parameter representing the request context is spelled out as RequestCtx: RequestContext . This originally made (at least some) sense when we had multiple type parameters and we wanted to have some clarity (but now, there is only one type parameter).
I propose changing this simply to R: RequestContext. This will help in 2 ways. One, there will be less confusion on which is the type parameter (R) and which is the trait bound (RequestContext). Second, it will be less verbose, making the code a little bit more concise/cleaner.
@maldrake - thoughts?

Ok by me.


docstring bug

subtle bug in docstring, use of generator means that changes are lost, so cast to a list is required

Could you also remove this import? I think it just confuses things.

i think this is used in the example, so it is required?

i think this is used in the example, so it is required?

Yes, but GribMessage and filename are also used in the example but not defined. However they are defined, along with load_pairs_from_fields, in the example on line 749, as I tried to explain in the comment above

@lbdreyer I follow your point now, I had missed it the first time round.  Yes, we can treat example 2 as a continuation of example 1 and have them share teh imports
I have updated the example code to reflect this
thank you
mark

@marqh  I just noticed this is targeting the dask branch. Is this correct? If so I will remove the v1.13.0 milestone. Otherwise please retarget at master

hello @lbdreyer
i agree that the 1.13 milestone was a mistake
this is targeting the dask branch, as this is where the GRIB code is in its updated form
thank you

@marqh This PR should now target master rather than the dask feature branch, thanks.


no_sim=1 make posix_sitl_default gazebo not work

hi,everybody.i want to do the gazebo simulation inferfacing to ROS,what i do is follow the page https://dev.px4.io/simulation-ros-interface.html ,but when i do the command
no_sim=1 make posix_sitl_default gazebo
the console output

the OS is ubuntu x64 14.04
ROS rev is indigo
gazebo rev is 7
i have already installed libprotobuf-dev,but it still not work
so,please help me to slove the problem,thank you

Try sudo apt-get install protobuf-compiler in addition.

Did you even follow this page? https://dev.px4.io/starting-installing-linux.html

@mhkabir yes,all the page command i have done.and the protobuf-compiler i have already installed.but i try again just now,it also doesn't work.

Did you install the dependencies before you tried to build the first time? I'm wondering if the gazebo build is stuck without having found the protobuf compiler. Try rebooting to make sure your path is updated. Then in the PX4 source do make distclean, then try to build again.

@chuyueqiang Updates? Otherwise we will close this.

Should be fine.


A lot of errors when starting with UnityEditor.

I have launched the project in this repository with Unity2018.4.0f1, but I get an error as shown in the attached image.
Can you please let me know how to deal with this error?

you can download agora rtc unity sdk from here
https://docs.agora.io/en/sdks?platform=unity
and this unitypackage include all api-example into it.All you need to do is import this unitypackage file into a empty unity project and then you can find api-example folder in it.

@xiayangqun
Does that mean this repository alone won't work?

yes, it is. And you need import agora unity rtc sdk to use it.
You can get more information from readme.md
https://github.com/AgoraIO-Extensions/Agora-Unity-Quickstart/blob/v4.3.2/API-Example-Unity/README.md

@xiayangqun
Have you actually imported the SDK into this repository to make sure it works?
I got this VideoSDK from here and imported it, but the error still appears.
https://docs.agora.io/en/sdks?platform=unity
**

**

This is beacuse of this repository include rtm example. But sdk only have rtc code.
I suggest you dont clone any code from this repository. You can run example with the sdk you download from https://docs.agora.io/en/sdks?platform=unity

Just create an empty project with unity editor
Import sdk form https://docs.agora.io/en/sdks?platform=unity you download
You can find all example(only with rtc, but not rtm) in Assets/Agora-RTC-Plugin/API-Example

@xiayangqun
I understand that the sample Scene on this repository does not work.
The following is a change of subject from this Issue.
So, does it definitely work with the current latest version of SDK 4.3.2?
If not, can you tell us which version of the SDK you have actually tested working on Unity? If possible, I would also like to know the version of Unity at that time.
As I have asked in the Slack channel below, only the Spatial Audio functionality is not working in my environment using the Agora VideoSDK.
I would like to know in which environment it works.
https://agoraiodev.slack.com/archives/CFDG7Q6F6/p1717652209783499


 Theese should be kept to a minimum for testing and the logger.

Duplicate of #256 and #258


Speed of fitting model is hours for some reason, 07_food_vision_milestone_project. Also Found a resolution for the mixed precision float16 - float32 error

  Also running into a problem. It appears that the ETA for fitting the model after downgrading to 2.4.1 is running at like 100 hours even with using the Nvida T4. Even running the project directly from github https://github.com/mrdbourke/tensorflow-deep-learning/blob/main/07_food_vision_milestone_project_1.ipynb it still is getting 100+ hours

Saving TensorBoard log files to: training_logs/efficientnetb0_101_classes_all_data_feature_extract/20221227-085937
Epoch 1/3
3/2368 [..............................] - ETA: 97:10:20 - loss: nan - accuracy: 0.0382
Tue Dec 27 08:59:33 2022
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 460.32.03    Driver Version: 460.32.03    CUDA Version: 11.2     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Tesla T4            Off  | 00000000:00:04.0 Off |                    0 |
| N/A   66C    P0    31W /  70W |      3MiB / 15109MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+
Turn on mixed precision training
from tensorflow.keras import mixed_precision
mixed_precision.set_global_policy(policy="mixed_float16") # set global policy to mixed precision
WARNING:tensorflow:Mixed precision compatibility check (mixed_float16): WARNING
The dtype policy mixed_float16 may run slowly because this machine does not have a GPU. Only Nvidia GPUs with compute capability of at least 7.0 run quickly with mixed_float16.
If you will use compatible GPU(s) not attached to this host, e.g. by running a multi-worker model, you can ignore this warning. This message will only be logged once
Originally posted by @Jayms8462 in https://github.com/mrdbourke/tensorflow-deep-learning/discussions/82#discussioncomment-4501569

Comments from the discussion board so we know the issue is no longer a problem for me
I left this running for a few hours in case the ETA was not correct.
Running this on google colab, the GPU is enabled in the runtime as seen above and I am using the paid middle tier. I also confirmed the GPU as a NVIDIA T4 right before fitting the model.
Just an Update, I was able to run mixed_precision in Tensorflow 2.11 with no issue
I was also able to get passed my problem by running Juniper Notebook locally on my system with a 3060ti and 64 GB of ram. This sped up the fitting of my model with all the data. instead of getting a few hours executing the fit, it dropped down to 2 min on the first epoch.


Add blocks to moosepy

Adds blocks to lib and use it in default project
Adds cliLog to lib. Can be used like this:

from moose_lib import cli_log, CliLogData

log_data = CliLogData(action="UserLogin", message="User has logged in successfully.")
cli_log(log_data)

Upper case List is deprecated https://docs.python.org/3/library/typing.html#typing.List

Good call, I've updated it.


Android: second iteration for mentions

Add insertAtRoomMentionAtSuggestion method to be able to insert properly formatted @room mentions.
Add a way to track MentionsState.
Add better examples for replaceSuggestionText.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (57d97a7) 89.39% compared to head (8bfa70a) 89.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   89.39%   89.34%   -0.06%
==========================================
  Files         118       86      -32
  Lines       16821    15247    -1574
  Branches      635        0     -635
==========================================
- Hits        15037    13622    -1415
+ Misses       1760     1625     -135
+ Partials       24        0      -24

Flag
Coverage Δ

uitests
?

uitests-ios
?

unittests
89.34% <ø> (+1.32%)
:arrow_up:

unittests-ios
?

unittests-rust
89.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 32 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Certain applications do not work with FancyZones

Environment
Windows build number: 18362.329
PowerToys version: 0.11.0
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce

Enable FancyZones, and set up a grid.
Take an application from below list, and hold Shift while moving it.
No zones appear, making it impossible to snap. The applications can still be manually resized to fit.

List of applications with issues:

1Password for Windows desktop (https://1password.com/downloads/windows/)
Battle.net Launcher (https://www.blizzard.com/apps/battle.net/desktop) (requires free account to get past login screen to observe behaviour)
GOG Galaxy (https://www.gog.com/galaxy)

What all these applications have in common, as far as I'm aware, is that they're built using the Qt GUI components. I'm not sure if this would have any effect.
Expected behavior
Zones would appear to snap the windows into.
Actual behavior
Nothing -- windows are moved as standard.

Can't confirm this with GOG Galaxy, which snaps in well into the defined regions on my screen.
Howewer, can confirm this behavior with Glasswire (a desktop firewall app), which I believe is also a QT5 app. Weird...

Perhaps this is a GOG Galaxy 2.0 (beta) thing, then. From looking at the code of what is considered an 'interesting window', it seems it ignores windows that are children or tools:
In (https://github.com/microsoft/PowerToys/blob/master/src/modules/fancyzones/dll/dllmain.cpp), line 204 to 209:
    static bool IsInterestingWindow(HWND window)
    {
        auto style = GetWindowLongPtr(window, GWL_STYLE);
        auto exStyle = GetWindowLongPtr(window, GWL_EXSTYLE);
        return WI_IsFlagSet(style, WS_MAXIMIZEBOX) && WI_IsFlagClear(style, WS_CHILD) && WI_IsFlagClear(exStyle, WS_EX_TOOLWINDOW);
    }

Is it possible that the Qt5 windows without the usual window frame are considered tool windows and thus ignored?

Might be the reason. GOG Galaxy v1.2.57 here.

Yeap, Chrome in my case. Everything is up to date. Only Chrome doesn't snap

Hi @mtaanquist, @DiDu0815, @Saeglopur
we are tracking a similar problem here https://github.com/microsoft/PowerToys/issues/209
Feel free to add you comments there so we have one place where we track all the problematic apps that don't snap (even if for some might be the zone to not appear at all and for other the zone appears but the window doesn't snap).
I will close this one.
Thank you.

I am using RS232 serial terminal "Termite" from CompuPhase, it cannot snap to FancyZones, i.e. the FancyZones to show up when I hold shift. Notepad and other apps that I've used have no issue so far


switch from openai to gemini

Added notebook guide to use Gemini API with full OpenAI compatibility using Portkey.

Thanks for the contribution.  Before we do a deep review, we have a few questions about the content. It might be easier to create a new issue where we can work out what guides to include and what they look like.
My initial questions are:

Is it possible to run the Portkey system locally instead of using a remote service? This way users can try it out without giving their API key to a third party.

If not, would you mind if we put a warning on the part where they share their API key?

Can you provide some stats on the platform's popularity? See our contrib guide, but we are only accepting contributions for widely adopted platforms, with some exceptions for technical novelty. Public numbers are fine.
Can you ensure the guide is focused on a single topic (e.g. "using a compatible interface" is one topic, "observability with portkey" is another)

Focused content is more useful to users, and it will help us review each guide on its own merits.

We also have a template you can use now, it includes some authoring guidelines. And you'll need to rebase your change to HEAD so you pick up the latest GH actions.


NativeBase 5.2 don't have FABs

In the 5.2 documentation there is no FAB components.
Will they be discarded in the newer versions (I'm currently using ^5.18)?

FAB was added in v0.5.13 and 0.5.2 is an older version. We won't be discarding FAB component.

Okay, didn't knew that 😊 thank you for answering my question.
The numbering reminds me of how MS Word do its section numbers..


HDFS-17098. DatanodeManager does not handle null storage type properly.

Description of PR

From https://github.com/apache/hadoop/pull/6035 which contributed by @teamconfx.
Fix checkstyle and try to trigger Yetus again.

How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Any update about Jenkins? Why always fail here?

I have noticed some issues with the CI, as some prs are not running complete checks. I remember we were adjusting the 'hadoop on windows' feature, which should have involved modifying the CI. Is there any progress on this matter?
@GauthamBanasandra
cc: @ayushtkn @steveloughran

@slfan1989 I only disabled the Apache Hadoop Multibranch pipeline for Windows 10 -

I didn't touch the CI for Linux and it's enabled.

@slfan1989 I only disabled the Apache Hadoop Multibranch pipeline for Windows 10 -

I didn't touch the CI for Linux and it's enabled.

Thank you for your reply! After discussion, we have found the cause of CI failure, which should be related to upgrading surefire (#6664), and the related pr has been rolled back.

Thanks all. Try to trigger CI again and let's wait what it will say.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 27s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 40s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m 43s

trunk passed

+1 :green_heart:
shadedclient
20m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 28s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m 38s

the patch passed

+1 :green_heart:
shadedclient
20m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
211m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

297m 30s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6840/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6840

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 620c1788bd6e 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 97e987746192b3dd5e9b1c5ae91773a30bc6b32a

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6840/4/testReport/

Max. process+thread count
4528 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6840/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Failed unit tests are not related to this PR. Merged to trunk. Thanks @slfan1989 and also @teamconfx .

@Hexiaoqiao/ @slfan1989  looks like TestDatanodeManager is related, it is failing in the daily jobs. If I revert this locally the test passes for me.
Can you check once, I created HDFS-17571. before I started investigating

@ayushtkn Thanks for your reminder. https://github.com/apache/hadoop/pull/6919 try to follow and fix it.


Adding user to a group suffix all previous user with the user_suffix even if it's an application

When a user is added to a group we add the branch user suffix at the end even if there is some app-account , so the app account will then disapear from the group

This issue is tagged as "bug".
So we need to know how this bug can be reproduced.

To Reproduce you will need an ldap client like apache directory studio connected to the distribution full env ldap
Go to Applications -> appliTest -> webservicesLdap_objets -> Administrateurs_WebServicesLdap in the uniquemember you will uniquemeber: uid=appli_webservicesldap,ou=Webservicesldap,ou=Applications,o=insee,c=fr
Then make a PUT request on /realms/domaine1/groups/Administrateurs_WebServicesLdap?application=WebServicesLdap with the following body {"name":"Administrateurs_WebServicesLdap","description":"Administrateurs généraux du WS gestion des contacts","users":[{"username":"appli_webservicesldap","habilitations":[],"address":{},"metadatas":{},"attributes":{}},{"username":"test_password"}]}
The go back with apache directory studio in Applications -> appliTest -> webservicesLdap_objets -> Administrateurs_WebServicesLdap in the uniquemember you will see that the uniquemember have changed for appliWebservices: uid=appli_webservicesldap,ou=contacts,ou=clients_domaine1,o=insee,c=fr
expected: Not modify the application account


Add a number of well-maintained libraries.

zuckdb.zig - a duckdb driver
http.zig - an popular http 1.1 server
websocket.zig - a popular weboscket server and client cache.zig - a thread-safe LRU cache
smtp_client.zig - an SMTP client
Learning Zig - a guide to learning zig from the author of The Little Go Book

Thanks


Updated namespace and URL address to source code

Changed namespace from Microsoft.Toolkit.Uwp to Microsoft.Toolkit.Uwp.Connectivity
Changed source code url from https://github.com/Microsoft/UWPCommunityToolkit/blob/master/Microsoft.Toolkit.Uwp/Helpers/Network/NetworkHelper.cs to https://github.com/Microsoft/UWPCommunityToolkit/blob/master/Microsoft.Toolkit.Uwp.Connectivity/Network/NetworkHelper.cs

@nmetulev

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/helpers/NetworkHelper.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thank you so much for fixing this. Would you mind moving these changes to the main repo instead and creating a PR there? We update the documentation there which propagates to this repo

Sorry, I just hit edit in documentation page and after that, I submitted the PR. I've applied these changes to the main repo too. @nmetulev

That's great, thank you :)


Made changes to README.md to reflect some prerequisites.

I'd like to submit a pull request for my README.md changes (IAM policies prerequisite).

Does the change agree with Apache 2 License?

I am not sure exactly what you mean. If you are asking if my changes are consistent with the SDK's overall license, I am OK with that.

Yes. We just want to make sure you submit this under Apache 2.0 license.

Again, I have no idea how to do that. Is this a matter of just saying "Yes,
I agree with the terms of the Apache 2.0 License?" Is there any issue with
that?
On Tue, Nov 24, 2015 at 6:32 PM, Manikandan Subramanian <
<EMAIL_ADDRESS>wrote:

Yes. We just want to make sure you submit this under Apache 2.0 license.
—
Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-java-sample/pull/12#issuecomment-159439025
.

That all we need. We just need a comment saying that to keep legal happy.

Yes, we just need something like a verbal agreement that you are submitting the code under Apache 2.0 license. I will ask for approval from our open source team to make sure there is no legal issue before merging the pull request.


Upgrade XMind to 3.5.2

Latest version.

Thank you for the contribution. It needed some fixes, so they were made in the below referenced pull request. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Design for exponential backoff

Design for expontial backoff for retrying failed certificate issuances.
Note: this design currently assumes binary exponential backoff with delay periods 1h, 2h, 4h etc up to 32h at which point it would remain at 32h till reset (resetting can only happen via a successful issuance). The delay periods could be changed and that would not affect this design.
Related issues:

#4727

Signed-off-by: irbekrm<EMAIL_ADDRESS>

/release-note-none

/approve
/lgtm
/hold

I've added a few clarifying comments but largely LGTM.

Thanks James, I've made some changes in response to the comments and restructured a doc a bit

My one question is are we comfortable to put this feature straight to 'GA'? I personally think it's okay to do as it's a fairly small extension in controller code vs what we do today, and I don't think we'll want to change the API surface we're adding here either (it's pretty simple all round)

I also think it could go straight to GA by looking at the small amount of change this actually implies.
The bit that I imagine might change would be the delay periods and how they are calculated. I don't think that it is worth putting this behind a feature gate just to stabilize the delay periods, but perhaps there is a reason to do that.

After having worked on the implementation I've added a couple notes to the design:

removed references to revision number as the backoff was implemented for all consecutive failures
added a note that denied CertificateRequests will result in backoff
removed reference to the event with the next retry timestamp as that didn't seem all that useful

/test pull-cert-manager-e2e-v1-23

Just looking to trigger some tests for unrelated purpose
/test pull-cert-manager-e2e-v1-23

/test pull-cert-manager-e2e-v1-23

/test pull-cert-manager-e2e-v1-23

/test

/retest

/test

/test

Hi! As part of the effort of migrating from Bazel to Make, we have added two new Prow jobs that require this PR to be rebased on top of master in order to pass. The two Prow jobs that were added are pull-cert-manager-make-test and pull-cert-manager-make-e2e-v1-23. Thanks! 🙏

Flake
/test pull-cert-manager-make-test

/milestone v1.8

/lgtm
/unhold

e2e tests failing for a design doc makes perfect sense

/test pull-cert-manager-make-e2e-v1-23

e2e tests failing for a design doc makes perfect sense

I think it a dependency for the test failed to download :thinking:


Fix for Path variables with / are not url encoded

Fixes #3
Feign clients do not encode slash / characters by default. To change this behaviour, set the decodeSlash property to false.
feign.client.decodeSlash=false

@minerasoft  Since everything is fine with this PR, I'm going to cherry-pick your commits directly to 2.2.x and also add some docs in order to get this change included in this weeks M6 release.

Merged within https://github.com/spring-cloud/spring-cloud-openfeign/commit/d419826ca0d17c94ffd8829442096c1d7fbf90b9.

@OlgaMaciaszek Thanks you very much!

Hİ @minerasoft decode-slash=false effects all the clients in the codebase. What would you suggest if we have many clients and we only wants this config affect onyl 1 of them ?

Hello @chErdemontas. This is not currently supported and would be a separate enhancement. You may open a new issue to have it implemented, however, since the project is currently in maintenance only mode, the Spring Cloud team will not be working on it, so the only way it would get in is if you or someone else from the community submits a PR for it.


ClipRRect's borderRadius property should be of type BorderRadiusGeometry and not BorderRadius class

Hi, I'm reporting this issue that I found.. firstly I thought there should a way that somehow I can play around it, but couldn't.
Problem
The ClipRRect has a property of Type BorderRadius class and when someone try to use the BorderRadiusDirectional it gives an error that tells us:
The argument type 'BorderRadiusDirectional' can't be assigned to the parameter type 'BorderRadius'
and it is totally make sense since the the borderRadius property of the ClipRRect should be of type BorderRadiusGeometry.
Code sample
Widget buildImage() {
  return ClipRRect(
    // gives an error here
    borderRadius: BorderRadiusDirectional.only(
      topStart: Radius.circular(10),
      topEnd: Radius.circular(10),
    ),
  );
}

Solution
Replacing the BorderRadius by BorderRadiusGeometry class property in the ClipRRect.
I also made a pull request for review/merge that solves this little issue.

@abdulmuaz97
There's a similar open issue describing your case, 62011.
You may want to follow-up there.
Closing this as duplicate.


⚠ Bofrost.at has degraded performance

In 70a628a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1153 ms

Resolved: Bofrost.at performance has improved in 9745a15.


in branch #16 I have repeatedly received the error Remote thread has terminated before it could report back

in branch #16 I currently receive the error
Remote thread has terminated before it could report back
It is likely a remote error has occured
when trying to dump the calculator

this issue seems to be fixed by compiling the tool as release

this issue also occurs in xbox game pass for pc titles

could this be caused by a mismatched platform


Bug on pip upgrading pip itself?

Dear pip_upgrade_outdated people,
I suspect that your script fails when pip itself is obsolete. In this case, pip3 is not updated correctly, and still requests the former version, which results in a strange failure: raise JSONDecodeError("Expecting value", s, err.value) from None.
I personally circumvent this problem by using pip_upgrade_outdated --exclude pip.
When pip is to be upgraded, I have to do it from outside: python3 -m pip install --upgrade pip. However, there may be of course better way of doing, for sure.
Please, could you at least let your pip_upgrade_outdated script exclude pip from being upgraded and issue a message?
Thank you for your excellent work,
Luc.

Hi pip_upgrade_outdated user!
Thanks for using the app. Is this the same as this pip error in 19.2 which was fixed in the quickly updated 19.2.1? (If you're still on 19.2, try just doing pip list --outdated and you should see it without running pip_upgrade_outdated.)

Actually, I have seen this message, as I was tracking the bug exactly at the same time. But I think the two problems are different.
Please find below an extensive test trace. I attach a copy of the pip3 script after the pip install --upgrade pip command. As you can see, it has not been upgraded through the pip upgrade.
In some sense, the bug has nothing to do with pip_upgrade_outdated. What is needed from you is probably just not trying to update pip in the same way as you do for regular obsolete packages.
pip3.zip
Test trace
$ brew reinstall python

==> Reinstalling python
==> Downloading https://homebrew.bintray.com/bottles/python-3.7.4.mojave.bottle.
Already downloaded: /Users/bouge/Library/Caches/Homebrew/downloads/ffcfe300e2ad205387a2bdd27185d98d64621578d26d2f6ccbbcd091ff799fc8--python-3.7.4.mojave.bottle.tar.gz
==> Pouring python-3.7.4.mojave.bottle.tar.gz
==> /usr/local/Cellar/python/3.7.4/bin/python3 -s setup.py --no-user-cfg install
==> /usr/local/Cellar/python/3.7.4/bin/python3 -s setup.py --no-user-cfg install
==> /usr/local/Cellar/python/3.7.4/bin/python3 -s setup.py --no-user-cfg install
==> Caveats
Python has been installed as
  /usr/local/bin/python3

Unversioned symlinks `python`, `python-config`, `pip` etc. pointing to
`python3`, `python3-config`, `pip3` etc., respectively, have been installed into
  /usr/local/opt/python/libexec/bin

If you need Homebrew's Python 2.7 run
  brew install python@2

You can install Python packages with
  pip3 install <package>
They will install into the site-package directory
  /usr/local/lib/python3.7/site-packages

See: https://docs.brew.sh/Homebrew-and-Python
==> Summary
🍺  /usr/local/Cellar/python/3.7.4: 3,869 files, 60MB
pommeau:~ bouge$ pip --version
pip 19.1.1 from /usr/local/lib/python3.7/site-packages/pip (python 3.7)

$ pip list --outdated

Package Version Latest Type
------- ------- ------ -----
pip     19.1.1  19.2.1 wheel

$ pip3 list --outdated

Package Version Latest Type
------- ------- ------ -----
pip     19.1.1  19.2.1 wheel

$ pip install --upgrade pip

Collecting pip
  Using cached https://files.pythonhosted.org/packages/62/ca/94d32a6516ed197a491d17d46595ce58a83cbb2fca280414e57cd86b84dc/pip-19.2.1-py2.py3-none-any.whl
Installing collected packages: pip
  Found existing installation: pip 19.1.1
    Uninstalling pip-19.1.1:
      Successfully uninstalled pip-19.1.1
Successfully installed pip-19.2.1

$ pip3 list --outdated

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 791, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.VersionConflict: (pip 19.2.1 (/usr/local/lib/python3.7/site-packages), Requirement.parse('pip==19.1.1'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/opt/python/bin/pip3", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3241, in <module>
    @_call_aside
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3225, in _call_aside
    f(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3254, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 585, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 598, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pip==19.1.1' distribution was not found and is required by the application

Hi,
I admit I’m confused, since, as you say, the above is happening independent of pip_upgrade_outdated. Does your installation just not allow upgrading pip for some reason? Or am I missing the point? (I haven’t seen these issues, I don’t think.)
Andrew

NB: I am running macOS Mojave 10.14.5 (18F132) and Homebrew 2.1.8.
I made progress in understanding the bug.

After a fresh reinstallation of Python, the pip3 script can be accessed through 2 paths, which eventually end at the same physical file (i-node): /usr/local/Cellar/python/3.7.4/bin/pip3

$ brew reinstall python
...

$ ls -li /usr/local/Cellar/python/3.7.4/bin/pip3 /usr/local/bin/pip3

36634604 -rwxr-xr-x  1 bouge  staff   386B 24 jul 14:40 /usr/local/Cellar/python/3.7.4/bin/pip3*
36634660 lrwxr-xr-x  1 bouge  wheel    31B 24 jul 14:40 /usr/local/bin/pip3@ -> ../Cellar/python/3.7.4/bin/pip3

$ realpath /usr/local/Cellar/python/3.7.4/bin/pip3 /usr/local/bin/pip3
/usr/local/Cellar/python/3.7.4/bin/pip3
/usr/local/Cellar/python/3.7.4/bin/pip3

$ more /usr/local/Cellar/python/3.7.4/bin/pip3

#!/usr/local/opt/python/bin/python3.7
# EASY-INSTALL-ENTRY-SCRIPT: 'pip==19.1.1','console_scripts','pip3'
__requires__ = 'pip==19.1.1'
import re
import sys
from pkg_resources import load_entry_point

if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])
    sys.exit(
        load_entry_point('pip==19.1.1', 'console_scripts', 'pip3')()
    )

After the pip upgrading, it is no longer the case! 👎 A new physical file (i-node) has been created: /usr/local/bin/pip3 instead of the former /usr/local/bin/pip3, and the old /usr/local/bin/pip3, which was the same file as /usr/local/Cellar/python/3.7.4/bin/pip3 has not been updated.
Unfortunately, my PATH finds pip3 at /usr/local/opt/python/bin/pip3, according to the recommendation of brew info pip3, instead of /usr/local/bin/pip3. 👎👎👎👎👎
$ pip install --upgrade pip

Collecting pip
  Using cached https://files.pythonhosted.org/packages/62/ca/94d32a6516ed197a491d17d46595ce58a83cbb2fca280414e57cd86b84dc/pip-19.2.1-py2.py3-none-any.whl
Installing collected packages: pip
  Found existing installation: pip 19.1.1
    Uninstalling pip-19.1.1:
      Successfully uninstalled pip-19.1.1
Successfully installed pip-19.2.1

$ ls -li /usr/local/Cellar/python/3.7.4/bin/pip3 /usr/local/bin/pip3

36634604 -rwxr-xr-x  1 bouge  staff   386B 24 jul 14:40 /usr/local/Cellar/python/3.7.4/bin/pip3*
36636281 -rwxr-xr-x  1 bouge  wheel   234B 24 jul 14:42 /usr/local/bin/pip3*

pommeau:~ bouge$ realpath /usr/local/Cellar/python/3.7.4/bin/pip3 /usr/local/bin/pip3

/usr/local/Cellar/python/3.7.4/bin/pip3
/usr/local/bin/pip3

$ brew info python

python: stable 3.7.4 (bottled), HEAD
Interpreted, interactive, object-oriented programming language
https://www.python.org/
/usr/local/Cellar/python/3.7.4 (3,909 files, 60.6MB) *
  Poured from bottle on 2019-07-24 at 14:40:38
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/python.rb
==> Dependencies
Build: pkg-config ✔
Required: gdbm ✔, openssl ✔, readline ✔, sqlite ✔, xz ✔
==> Options
--HEAD
	Install HEAD version
==> Caveats
Python has been installed as
  /usr/local/bin/python3

**Unversioned symlinks `python`, `python-config`, `pip` etc. pointing to
`python3`, `python3-config`, `pip3` etc., respectively, have been installed into
  /usr/local/opt/python/libexec/bin**

If you need Homebrew's Python 2.7 run
  brew install python@2

You can install Python packages with
  pip3 install <package>
They will install into the site-package directory
  /usr/local/lib/python3.7/site-packages

See: https://docs.brew.sh/Homebrew-and-Python
==> Analytics
install: 454,942 (30 days), 1,188,085 (90 days), 4,432,887 (365 days)
install_on_request: 222,671 (30 days), 575,343 (90 days), 2,441,170 (365 days)
build_error: 0 (30 days)

$ ll /usr/local/opt/python/libexec/bin/pip

lrwxr-xr-x  1 bouge  staff    14B 24 jul 14:53 /usr/local/opt/python/libexec/bin/pip@ -> ../../bin/pip3

 $ realpath /usr/local/opt/python/libexec/bin/pip

/usr/local/Cellar/python/3.7.4/bin/pip3

$ pommeau:~ bouge$ ls -li /usr/local/Cellar/python/3.7.4/bin/pip3

36634604 -rwxr-xr-x  1 bouge  staff   386B 24 jul 14:53 /usr/local/Cellar/python/3.7.4/bin/pip3*

$ more  /usr/local/Cellar/python/3.7.4/bin/pip3

#!/usr/local/opt/python/bin/python3.7
# EASY-INSTALL-ENTRY-SCRIPT: 'pip==19.1.1','console_scripts','pip3'
__requires__ = 'pip==19.1.1'
import re
import sys
from pkg_resources import load_entry_point

if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])
    sys.exit(
        load_entry_point('pip==19.1.1', 'console_scripts', 'pip3')()
    )

To summarize this long and complex post.

It is a problem with pip and homebrew, not with you.

Your script should better refrain updating pip itself, and instead issue a warning message.

Hi,

Hi,

To summarize this long and complex post.

It is a problem with pip and homebrew, not with your pip_update_outdated script.

Agreed, I think. I use the python.org build, and don’t see this issue.

Your pip_update_outdated script should better refrain updating pip itself, and instead issue a warning message.

I don’t think it should — as above, I do want it to update pip for my framework build. You can always use pip_upgrade_outdated -x pip.
But this is a bug in homebrew python, right? Should it be reported there?

Thank you for the answer.
I could find that the key is the PATH search priority. If you use /usr/local/bin/pip, then you are safe. The problem is with /usr/local/opt/python/libexec/bin/pip, which is badly recommend by brew info python.
I think it closes this issue. I filled a bug at the Homebrew site. Until it is solved, I use the following work-around: python3 -m pip install --upgrade pip; pip_upgrade_outdated --exclude pip
Thank you for your pip_upgrade_outdated script,
Luc.

Dear Luc,
Glad we've resolved it, at least as far as pip_upgrad_outdated is concerned -- and I'm glad that you've found my code useful.
Let's hope homebrew fixes this issue!
Yours,
Andrew


test(server): improve end-to-end tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
514

Relevant Lines:
514

💛  - Coveralls


Broken URL: Plugin development

Very cool project!
I am curious to learn more about developing plugins for nendo, but the URL at the end of the README gives a 404.

Nice catch! That's a typo in the link, will fix right away. Meanwhile, this is the correct URL to the plugin development documentation.
Thanks for letting us know.


Can't create a new pool

Error when trying to create a new pool for a token that doesn't exist in the network yet.
Steps to reproduce the behavior:

Go to "swap"
Click on "pool"
Click on "Create pool"
Enter any token that doesn't exist
Select "add token"
Put in any address
See error

Tested on desktop.

no repro on the original issue but optimized the token loading and select flow when adding a new token


Lightweight version / configuration

Hi, congratulations on DBeaver, is great. Is it possible to make a lightweight version of dbeaver for old / slower computers?  Or maybe disabling certain modules of the app.
System information:
Operating system (distribution) and version: Linux MX 4.19
DBeaver version: 6.1.5
Additional extensions: none

Connection specification:
Database name and version: MySql 5.7.27
Driver name: mysql
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Greetings and keep the great work!
MB

It is not that easy. Community edition already has minimum number of pre-installed extensions.

You can set Classic theme to disable advanced css UI.
You can reduce max amount of memory (1Gb by default).
You can remove some base extensions like schema compare, ssh, spatial viewer, charts and dashboards.
It is also possible to make version just for one database (this will remove most of drivers and database extensions).

These changes can make DBeaver a bit lighter but I'm afraid we can't provide too many different versions. It takes a lot of resources to build/host different product versions.


[BUG] Encountered exception during pipeline raw-pipeline processing.

Describe the bug
The otel_trace_raw processor does not seem to work. The pipeline using this processor fails with the below
error message:
data-prepper  | 2022-09-08T07:01:33,206 [raw-pipeline-processor-worker-5-thread-1] ERROR com.amazon.dataprepper.pipeline.ProcessWorker - Encountered exception during pipeline raw-pipeline processing
data-prepper  | java.lang.ClassCastException: class io.opentelemetry.proto.collector.trace.v1.ExportTraceServiceRequest cannot be cast to class com.amazon.dataprepper.model.trace.Span (io.opentelemetry.proto.collector.trace.v1.ExportTraceServiceRequest and com.amazon.dataprepper.model.trace.Span are in unnamed module of loader 'app')
data-prepper  | 	at com.amazon.dataprepper.plugins.processor.oteltrace.OTelTraceRawProcessor.doExecute(OTelTraceRawProcessor.java:77) ~[data-prepper.jar:1.5.1]
data-prepper  | 	at com.amazon.dataprepper.model.processor.AbstractProcessor.lambda$execute$0(AbstractProcessor.java:55) ~[data-prepper.jar:1.5.1]
data-prepper  | 	at io.micrometer.core.instrument.composite.CompositeTimer.record(CompositeTimer.java:65) ~[data-prepper.jar:1.5.1]
data-prepper  | 	at com.amazon.dataprepper.model.processor.AbstractProcessor.execute(AbstractProcessor.java:55) ~[data-prepper.jar:1.5.1]
data-prepper  | 	at com.amazon.dataprepper.pipeline.ProcessWorker.run(ProcessWorker.java:62) ~[data-prepper.jar:1.5.1]
data-prepper  | 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
data-prepper  | 	at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
data-prepper  | 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) ~[?:?]
data-prepper  | 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) ~[?:?]
data-prepper  | 	at java.lang.Thread.run(Thread.java:832) ~[?:?]

I am using the sample app in examples/trace-analytics-sample-app to test this.
I am not able to see any service or traces on dashboard. Service map does seem to work though.
To Reproduce
Steps to reproduce the behavior:

Follow instruction in examples/trace-analytics-sample-app.
Check data-prepper logs. You should see the above error.
Open opensearch-dashboards, and navigate to app/observability-dashboards#/trace_analytics/services.
You should see some information in the service map section, but service and traces sections are empty.
In the opensearch-dashboards, check indices in Stack Management page, you should see no docs in the otel-v1-apm-span-000001 index.

Expected behavior
The example should work as expected.
Screenshots
NA
Environment (please complete the following information):

OS: Amazon Linux
Version: 2

Additional context
examples/trace-analytics-sample-app also dos not build unless you revert https://github.com/opensearch-project/data-prepper/pull/1691.

This sample was updated to use the otel_trace_raw processor, but the otel_trace_source source is not configured to output events. It is only outputting OTel trace requests. This is likely the problem.

Confirmed that modifying the otel_trace_source to use record_type of event fixed the issue. Have created a PR to update the configuration used for the sample app demo (https://github.com/opensearch-project/data-prepper/pull/1741)

Thank you @bimlendu-plivo for reporting this issue. The PR is merged and this example should work for you now. Please let us know if you have any other issues here?

@dlvenable Thank you for the fix.
Can we also fix other examples in the repo like this one,  and more importantly the plugin readme  and in the opensearch docs website.

Thank you for taking note of these @bimlendu-plivo . Yes, we can include fixing those as well. I'll re-open this issue to resolve these as well.


DO NOT MERGE: regenerate mainfests on a clean checkout

On a clean main checkout, on F37,, runinng ./tools/test-case-generators/generate-all-test-cases -i /dev/null --output test/data/manifests --image-type edge-commit --image-type edge-simplified-installer --image-type edge-container --image-type edge-raw-image manifests I get the diff in this PR - something must be off on either my side or projects (likely mine). The workaround I did was to run:

go run ./cmd/gen-manifests -output test/data/manifests -workers 20 -images edge-container
go run ./cmd/gen-manifests -output test/data/manifests -workers 20 -images edge-commit

but I'd have expected the command above to just work like it did in the past
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

These are differences between the older tools/test-case-generators scripts and cmd/gen-manifests.
From a quick glance, here are the major issues:

The existing manifests include "no-image-info": true.  This used to be useful to signal that a manifest didn't include image info back when we had image infos.  cmd/gen-manifests just adds it because it was never meant to include image info, but now that we never do, we should drop it.
The older scripts don't include support for adding containers to a request/blueprint.  This is a newer feature and I added support for containers in the test manifests while doing the RHEL 9 rewrite to make sure they carried over.  If the older scripts are run, the container in the request is dropped so the source and stage are removed.
Empties omitted or not: some parts of the request or metadata are omitted when empty in one tool and not the other.

The long term solution is to drop the manifests from the composer repo altogether and rely on manifest-db.  For now I think we should always use the gen-manifests tool for consistency.


[ISSUE #3473] Optimize the problem of delayed message delivery duplication

What is the purpose of the change

Optimize the problem of delayed message delivery duplication.

Brief changelog
#3473
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

persist delay message offset table after shutting down, LGTM

After calling shutdown, wait for the execution of the thread to complete. At this time, it is forbidden to submit a new thread.
First updateOffset and then execute schedule to avoid the inability to execute updateOffset after shutdown is called

Coverage increased (+0.009%) to 54.568% when pulling fd69104b11fc795f50ebd0d0dd00831e650eddfb on Git-Yang:schedule_duplicate into b35f3e4459e8cf32116bb15133aaa27d5ff63cfb on apache:develop.

Codecov Report

Merging #3478 (fd69104) into develop (b35f3e4) will decrease coverage by 0.51%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             develop    #3478      +/-   ##
=============================================
- Coverage      48.87%   48.35%   -0.52%
- Complexity      3235     4612    +1377
=============================================
  Files            421      555     +134
  Lines          26505    36729   +10224
  Branches        3503     4839    +1336
=============================================
+ Hits           12953    17760    +4807
- Misses         11899    16732    +4833
- Partials        1653     2237     +584

Impacted Files
Coverage Δ

...ocketmq/store/schedule/ScheduleMessageService.java
73.55% <60.00%> (-0.29%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-5.36%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
44.77% <0.00%> (-1.50%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
28.85% <0.00%> (-0.66%)
:arrow_down:

...n/java/org/apache/rocketmq/store/ha/HAService.java
71.28% <0.00%> (-0.34%)
:arrow_down:

...pache/rocketmq/test/util/DuplicateMessageInfo.java
0.00% <0.00%> (ø)

...tmq/client/impl/consumer/AssignedMessageQueue.java
61.66% <0.00%> (ø)

.../producer/selector/SelectMessageQueueByRandom.java
0.00% <0.00%> (ø)

.../java/org/apache/rocketmq/test/util/TestUtils.java
37.50% <0.00%> (ø)

...pache/rocketmq/test/client/mq/MQAsyncProducer.java
73.33% <0.00%> (ø)

... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b35f3e4...fd69104. Read the comment docs.

Test Results

Before optimization

First step

1w messages are sent through the script, and each message generates a unique self-increasing Key (0~9999)
After the message is sent, the delayed message is still being delivered, and the broker service is restarted at this time.

Second step

Detect whether the message is lost or repeated according to the unique self-increment key.
The test result is that no messages are lost and there are 7395 message duplications.

After optimization

Repeat the above steps
The test result is no data loss, no data duplication.

Strengthen the testing process

100w messages are sent through the script, and each message generates a unique self-increasing Key (0~999999)
The message delivery process restarts the service multiple times.
The test result is no data loss, no data duplication.

Looks Good To Me.

After calling shutdown, wait for the execution of the thread to complete. At this time, it is forbidden to submit a new thread.
First updateOffset and then execute schedule to avoid the inability to execute updateOffset after shutdown is called

When shutdown is called, will the method deliverExecutorService.schedule() throw exception？？

After calling shutdown, wait for the execution of the thread to complete. At this time, it is forbidden to submit a new thread.
First updateOffset and then execute schedule to avoid the inability to execute updateOffset after shutdown is called

When shutdown is called, will the method deliverExecutorService.schedule() throw exception？？

Right

Included in PR https://github.com/apache/rocketmq/pull/3478 , merged.


Initialize Async cancel state in call to fork

I came across this pain point today. When I wrap a function the state is initialised.
const CrockFetcher = Async((rej, res) => fetch("/myApi")) // state { cancelled = false }

If I fork I can then cancel
CrockFetcher.fork(() => console.log("fail"), () => console.log("success"))() // state { cancelled = true }

Later when I fork the fork callbacks won't run
CrockFetcher.fork(() => console.log("no run"), () => console.log("no run")) // state { cancelled = true }

This pull request aims to only set state when the fork is called. Allowing the wrapped function to be forked again after a previous cancel

Any suggestions on how to clean up the other references to cancel?

GREAT FIND. Although I am sorry this is causing a pain point for you...I think the problem here is keeping that state itself...Going to think of a way to maybe use a union type here that just gets passed down (or up?)  the "cancel" chain. That way it can have a ripple effect without state.
I have always hated that state.
I will get back to you for sure with a couple ideas

@NiallArkEnergy After playing with some options, we will need to get that state out of there...So the best way I can think we can address this is to make Async something like Async e a () =  Rejected e | Resolved a | Cancelled.

I can't picture how that union type would work. Other libraries I've been looking at expect the function provided to Async to return a cleanup function in this case it's trivial to cancel.
const timer = ms => val => Async(function(rej, res){
  const id = setTimeout(()=>res(val), ms);
  return () => clearTimeout(id)
})

const timer1000 = timer(1000);
const delayed = timer1000('Delayed');
const cancel = delayed.fork(()=>console.log('fail'),()=>console.log('pass'))
cancel()

// delayed should work if I call fork here

crocks already uses this mechanism to guard the reject and resolve callbacks. I think adding the capture of the function dispose function removes the need for a parentCancel
This should simplify composing methods, no need to pass a cancel, just return the result of the call to fork
function map(method) {
    return function(mapFn) {
      if(!isFunction(mapFn)) {
        throw new TypeError(`Async.${method}: Function required`)
      }

      return Async(function(reject, resolve) {
        return fork(reject, compose(resolve, mapFn))
      })
    }
  }

Gotcha.
The Cancelled tag will never have to be explicitly constructed, this is mostly an internal tag, that is a noop through a "chain" of Asyncs. When the function is called it would chain a move to the Cancelled tag while one of the Asyncs in the chain is "in-flight" that way once it completed it will throw away the result and pass Cancelled () down the line.
That was my thinking on adding another tag to Async.
I am curious about your solution, I do not see how it could cancel a wrapped Promise or Node CPS function in a chain like:
promAsync
  .chain(anotherProm)
  .chain(someNodeAsync)

what would happen if that promAsync has the cancel logic and it has already been completed and anotherProm is in-flight when cancelled is called? I would expect it would never run someNodeAsync and never call res or rej functions passed to fork. I may be missing something with that approach, could you demonstrate how this could cancel the whole lot of them?

Is there any use case I'm not thinking about that needs the parentCancel function. Those are the failing tests that I have at the moment. I will add tests also to check cancel functions are called

Coverage remained the same at 100.0% when pulling 109206c93c198c1d48a1ba004ddd7df72a30a87a on NiallArkEnergy:patch-1 into 873961cb00fe884985af79217ec5c4a696a50ac6 on evilsoft:master.

Awesome. @NiallArkEnergy will get some 👀on this today.

Code wise this looks GREAT thanks for the PR. One last thing that will be needed is to show the ability to return an internal cancel function in the docs.
It can be added here in the description and example for fork:
https://github.com/evilsoft/crocks/blob/master/docs/src/pages/docs/crocks/Async.md
Also would you mind if we added you to the Contributors section on the main README?

Finally got back to this. Sorry it took so long. Hope this is enough to explain my changes. Yeah please add me to the Contributors section, that sounds great

Looks pretty darn good, here have a squirrel:


Report actions Onyx migration for accountIDs

Details

This is the first stage in the email-to-accountID migrations that we are going to need to do. For now this migration:

Checks reportActions to see if any of them DO have email-based data and DONT have the accountID-based equivalent
If so, we try to add the accountID equivalent by finding the relevant accountID in personalDetails
If we aren't able to find the relevant accountID, we simply clear the reportAction from Onyx. We do this so that nothing will break due to the missing info and since the reportAction will get returned by the API again when needed.

This is built off the work that @roryabraham originally did in this PR.
Fixed Issues

https://github.com/Expensify/App/issues/21454#issuecomment-1606272577
Tests

I wrote automated Jest tests for each scenario that can happen as part of the migration
I tested some of the scenarios manually. For example, you can do:

Type Onyx.set('reportActions_123', {1234: {originalMessage: {oldLogin: 'fdjsklfjdsk'}}});

You'll now see the reportActions data you added in reportActions_123

Refresh the page

The migration will run and you should see that reportActions_123 no longer has any data

[ ] Verify that no errors appear in the JS console

Offline tests

There is no difference between being online or offline, since the migration is run over the locally stored data in Onyx.
QA Steps

There is nothing for QA to test, since this doesn't change the app experience in any way. It just updates the underlying Onyx data.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

One more question @puneetlath : Should we also be removing old email data from the front-end? Or will we do that in a different step?

We'll do that in a different step once the back-end has stopped sending it. For now, we're just making sure the client doesn't break because it is missing needed data.
Once the back-end stops sending any given email-based data, we'll also update this migration to include removing any of that type of data.

Taking this as C+

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.33-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Maybe we should have waited to merge this migration because of SHN.

Hmm maybe yeah. I should've started a convo about it at least. My thinking was that we should've done this earlier already because people could have broken report actions in Onyx already.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.33-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat(charts): import the oz-charts repo for singular releases

I'll be working on deprecating the https://github.com/diranged/oz-charts repo.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.51%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
1091

Relevant Lines:
2833

💛  - Coveralls


further changes to include additional classes in title tags

Not sure if they use different css classes to prevent scraping or if it's just a byproduct of being a wiki having multiple editors. Either way, found that it would fail sometimes and not others

thank you!


sink writes cloudevents to the database

Need to make this work with the full db schema, clean up the code, and figure out a better solution for connecting to the database. This works though. You just need to deploy the database before installing kubearchive and update the host to use the IP of the database service

the sink connects to the database through the internal cluster url for the service. The url and other connection info is harded coded so I need to modify the helm chart to add that info as env vars when the sink and database are deployed. I also need to rebase the PR since there have been changes to the operator and helm chart since last week

the test failures are in the operator code that has not been changed by this PR

I got the integration test working by adding the environment variables that it expects to have to create a database connection. Since it's doesn't receive any cloudevents yet during the test this works fine. Once it starts receiving cloudevents, we might start to see issues since it will actually try to connect to a database

testing this PR

check out the branch
revert commits that have the operator deploy the ApiServerSource (it is currently broken) git revert 4674b82c1208423c1005d8c09b016c1377e01643 and git revert 6c84ed5937d60da284b65cc71fd7b9878901851a
deploy kubearchive: ./cmd/operator/generate.sh; helm install kubearchive charts/kubearchive --create-namespace -n kubearchive --set-string apiServer.image=$(ko build [github.com/kubearchive/kubearchive/cmd/api](http://github.com/kubearchive/kubearchive/cmd/api)) --set-string sink.image=$(ko build [github.com/kubearchive/kubearchive/cmd/sink](http://github.com/kubearchive/kubearchive/cmd/sink)) --set-string operator.image=$(ko build [github.com/kubearchive/kubearchive/cmd/operator](http://github.com/kubearchive/kubearchive/cmd/operator))
get the name of the postgres pod kubectl -n kubearchive get pods
in a separate terminal, port forward the database kubectl port-forward -n kubearchive svc/postgresql 5432:5432
in another separate terminal, use psql to login to the database: psql -h localhost -U ps_user --password -p 5432 postgresdb  (default password can be found in the secret template)
initialize the ArchiveMeta table: CREATE TABLE IF NOT EXISTS ArchiveMeta ("id" serial PRIMARY KEY, "api_version" varchar NOT NULL, "kind" varchar NOT NULL, "name" varchar NOT NULL, "namespace" varchar NOT NULL, "resource_version" varchar NULL, "created_ts" timestamp NOT NULL, "updated_ts" timestamp NOT NULL, "data" jsonb NOT NULL);
run: \dt in psql to verify ArchiveMeta was created (its case insensitive)
back in the first terminal run: kubectl run -n test busybox --image=busybox
then run kubectl logs -n kubearchive -l app=kubearchive-sink -f you should see logs indicating that the sink receive cloudevents and that it successful wrote them to the database
in the psql terminal run: SELECT * FROM ArchiveMeta; This should print entries that have been added by the sink

7. nitialize the ArchiveMeta table: CREATE TABLE IF NOT EXISTS ArchiveMeta ("id" serial PRIMARY KEY, "api_version" varchar NOT NULL, "kind" varchar NOT NULL, "name" varchar NOT NULL, "namespace" varchar NOT NULL, "resource_version" varchar NULL, "created_ts" timestamp NOT NULL, "updated_ts" timestamp NOT NULL, "data" jsonb NOT NULL);

Rename the table we are creating with database/init_db.go and the table where the test objects are loaded.

nitialize the ArchiveMeta table: CREATE TABLE IF NOT EXISTS ArchiveMeta ("id" serial PRIMARY KEY, "api_version" varchar NOT NULL, "kind" varchar NOT NULL, "name" varchar NOT NULL, "namespace" varchar NOT NULL, "resource_version" varchar NULL, "created_ts" timestamp NOT NULL, "updated_ts" timestamp NOT NULL, "data" jsonb NOT NULL);

Rename the table we are creating with database/init_db.go and the table where the test objects are loaded.

I've changed the name of the table in database/init_db.go and test_objects.sql

I thought we no longer had an ArchiveMeta table, but had just checked to resource?

I thought we no longer had an ArchiveMeta table, but had just checked to resource?

The last time I looked at the database architecture, it still had the ArchiveMeta table. I must have missed the discussion where that changed. I'll change the table name to resource to Resource

I think postgres naming conventions are all lower case and also using underscores.

I thought we no longer had an ArchiveMeta table, but had just checked to resource?

The last time I looked at the database architecture, it still had the ArchiveMeta table. I must have missed the discussion where that changed. I'll change the table name to resource

my bad, I should add a shadow to the old db model.

I think postgres naming conventions are all lower case and also using underscores. Maybe @mafh314 has another change coming with the names changed? I'm not sure where the current schema stands.
Yes, I have a change with the table rename, 3 new fields (delete_cluster_ts, cluster, cluster_uid) and the required changes in the test objects.

Yes, I have a change with the table rename, 3 new fields (delete_cluster_ts, cluster, cluster_uid) and the required changes in the test objects.

I'm not sure where to find the cluster name or cluster_uid. The cloudevents from ApiServerSource don't contain them

synced with main


PVP question

Water under the bridge now, but was removing the export of "Typeable" consistent with only bumping from <IP_ADDRESS> to <IP_ADDRESS>?
I ask because I'm always assuming that I can safely upper bound things at  < A.(B+1).0.0, but in this case that broke because I was using the Polysemy export of Typeable to add it.  The constraint is harmless now that it's not needed, so removing it is backward-compatible, but now my code fails to compile because Typeable is no longer exported for me to use.

Removing any exported symbol (even a re-exported one) should be accompanied by a major version bump - it falls under point 1 here: https://pvp.haskell.org/

Whoops! Thanks for the heads up.
Is there any tooling I can use to help with this in the future?

I'm not sure. I've seen https://hackage.haskell.org/package/hackage-diff but it's old, crufty, and I'm unsure if you can run it on unreleased code.

Did Semantic become a type synonym in 0.1.2?  That also broke some things.  I would've needed to add
{-# TypeSynonymInstances #-} for that MonadRandom instance, though now I'l just update it all to Sem.
I wonder if you can fix that by adding TypeSynonymInstances to the cabal/package.yaml when making this sort of change?  Otherwise making something a synonym by way of deprecation will always be a breaking change.

Yeah, it did become a type synonym. Sorry for the growing pangs here!
Adding TypeSynonymInstances to polysemy wouldn't help here; it needs to be enabled in your package where you define the instance.

Ah, right.  Was just hoping for the future.  I guess you could rename and make the new one a type-synonym?  Then the type synonym thing itself wouldn't be a breaking change?

That's a good plan, then for the major version release just swizzle which one is a synonym. I'll keep this in mind!
If you're keen, I'd be very interested in a PR for a checklist of things I should keep in mind before cutting a new release :)

Well, I'd like to help (see my PR in the zoo!) but I've got less experience doing this than you do so I don't think I can be useful in that regard.  I only noticed because I did the cabal update because I needed the plugin (for the zoo) and then my "knit-haskell" package broke because of the Typeable thing.  But there must be some good resources.
One thought though:  Is there much downside to liberally choosing to bump B (of A.B.C.D) until things are pretty stable?  I guess it will cause people to miss the upgrades but maybe that's the point until things settle down?  Then you could worry less...

Sounds like a good plan. I'll do that from now on!
On Tue, Apr 30, 2019 at 12:02 PM Adam Conner-Sax<EMAIL_ADDRESS>wrote:

Well, I'd like to help (see my PR in the zoo!) but I've got less
experience doing this than you do so I don't think I can be useful in that
regard. I only noticed because I did the cabal update because I needed the
plugin (for the zoo) and then my "knit-haskell" package broke because of
the Typeable thing. But there must be some good resources.
One thought though: Is there much downside to liberally choosing to bump B
(of A.B.C.D) until things are pretty stable? I guess it will cause people
to miss the upgrades but maybe that's the point until things settle down?
Then you could worry less...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/isovector/polysemy/issues/33#issuecomment-488011624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACLAF4Y443GYY5HRV4V6TLPTBUPRANCNFSM4HJMSRSA
.


Remove the finalization dialog on draft order complete

I want to merge this change because it adjusts dashbaord to new API changes for draft order.
Warning dialog has been removed and order view proceeds straight to finalization.
Finalize button stays hidden until order is ready to be finalized as it was before, behavior has been adjusted on backend and it is using same validation as on frontend.
Related ticket: SALEOR-1264

PR intended to be tested with API branch:
SALEOR-1264-avatax-address-fix
Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[ ] Number of API calls is optimized.
[X] The changes are tested.
[ ] Data-test are added for new elements.
[ ] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-1264 Order without user details - TaxError