Scala Package TODO list for production environment usage

In order to bring scala-package to production environment, here are some of the issues remains to be resolved:

[x] Build binary jars and deploy to maven repository.
[ ] Support Windows.
[x] Check whether there still exists any memory leak during training & prediction.
[x] Add descriptions and copyrights in each file.
[x] Finish the IO module, e.g., PrefetchingIter and NDArrayIter.
[x] Put scala package doc in readthedocs.
[ ] Nullptr check in JNI codes for OOM exception.

Also checkout other issues, which are not that urgent, at https://github.com/javelinjs/mxnet-scala/issues

Hi @javelinjs What should I do if I want to depoly MXNet using scala-pkg(actually is Java) in production machine? Just simply add maven dependency into pom and everything is fine?
BTW. How's MXNet Serving going? TFServing need only some basic .so and require less dependencies.

@zihaolucky Yes, just add maven deps to the pom. While the current versions in maven repositories are somewhat out-of-date. We'll release the 1.0 version in the next few months.
The .so is packed into the jar. Check https://github.com/dmlc/mxnet/tree/master/scala-package#install for more infos.

Hi @javelinjs thanks for your help. I've successfully added dependency into my pom file and everything looks great so far.
I used to use Python and already familiar with its API which is not same as the Python's and confusing as well.
# python code.

# prepare data
dataiter = mx.io.NDArrayIter(data_eval.data)
# load model
model = mx.model.FeedForward.load('checkpoint/cnn', 10)
# make prediction
pred = model.predict(dataiter)

But I got some trouble when I tried to move my Python code into Java as below
public Symbol makeCNN(...) {
    /**
     * Network structure.
     */
    Symbol data = Symbol.Variable("data");  //error. Variable<String s, Map<String,String> map>
    Symbol label = Symbol.Variable("label");

    if (withEmbedding) {
        Symbol convInput = data;
    } else {
        Symbol embed = Symbol.Embedding(); //error. Embedding<String, Map<String,String>
    }

    return label;
}

public void predict(DataIter dataiter, int batchSize) {
    FeedForward model = FeedForward.load("sdf"); //error. FeedForword.load need so many other params.
    model.predict(dataiter, batchSize);
}

Could you show me a few examples in Java? Or is there any document I can refer to? Thank you!

So what's the meaning of that argument Map<String, String>

Map<String, String> is the attributes passed to the Variable. If you do not need one, pass it as null. Scala supports default function argument while Java does not. Maybe we shall also provide Java-friendly apis.

Thanks for your reply and +1 for Java APIs.
The model file is said to be language agnostic, so I trained my model in Python and write a predict function in Java as below to deploy into the production environment.
public void predict(NDArrayIter dataiter, int batchSize) {

    SGD opt = new SGD(0.0001f, 0.9f, 0.000f, 0.0f, null);
    Uniform uniform = new Uniform(0.1f);
    Context[] ctx = new Context[1];
    ctx[0] = Context.cpu(0);
    FeedForward model = FeedForward.load("prefix", 10, ctx, 200, 32, opt, uniform, 32, false);

    model.predict(dataiter, batchSize);
}

But I stuck at creating an NDArrayIter? I was going to start from creating an NDArray but failed at last. I found a quite similar issue here https://github.com/dmlc/mxnet/issues/2583

< I would find my colleagues for help and come to you again if both of us have the same problem in this issues. After that, I would like to contribute some Java examples :)

There is an NDArrayIter in Scala pkg, please let us know if it does not work so we can fix.
And it would be really appreciated if you could contribute solutions for Java.

@yzhliu can we close this, since we have a Windows Support issue already #10549
If you had some thoughts and JNI code needs to refactored/fixed can you please create a new issue.

I have updated with a CWiki page here: https://cwiki.apache.org/confluence/display/MXNET/Scala+Project+Status
Let's keep all TODOs into one place and also pick up from there. @yzhliu @nswamy let's close this for now.


Rental#create is taking a long time

It seems like the problem is because of the views taking forever to render, i'd bet at least part of that is the mail, we are already delivering async with deliver_later but it seems like it still tries to render right away. I think the reason is explained here, https://stackoverflow.com/a/28780106/4463703
Completed 200 OK in 30894ms (Views: 30733.9ms | ActiveRecord: 115.1ms)
Sucker punch seems like it would work fine for our application and is self contained which makes things simple.  https://github.com/brandonhilkert/sucker_punch
Installing is easy too just add this to the config
config.active_job.queue_adapter = :sucker_punch

This "long time" was only documented in development, it might be much faster in production

leaving any development on this at https://github.com/umts/probable-engine/tree/active-job-queue-adapter

Passing the wait param to the send_invoice call seems to have eliminated the problem without the need for a gem. I thoroughly tested the impact of the mailer running after the minute and it seems to have no impact on ui rendering this way.
InvoiceMailer.send_invoice(rental).deliver_later(wait: 1.minute)

I don't know if anybody mentioned that this only seems to be an issue for the first rental creation.
Any rentals created after the first one have no noticeable wait times.


Add support for return the type of stream

The tests must pass now! #13

What's the use-case for this?

You also need to update the readme and index.d.ts

What's the use-case for this?

I'm learning about streams and sometimes I just wanted to know what the type of stream for debugging purposes.
If this is useful I can move forward with the adjustments described above...

Travis is failing

Travis is failing

The test fails because net.Socket is a stream Duplex only after Node.js: 14.
I'm working to fix this...

Bump

You still need to fix https://github.com/sindresorhus/is-stream/pull/14/files#r464118942

You still need to fix https://github.com/sindresorhus/is-stream/pull/14/files#r464118942

After some research, it is still unclear to me how fix this.
I can go back and reopen this PR in the future, when my interest in Typescript increase, but not now ...


feat: ML Feature search API work

Signed-off-by: Allison Suarez Miranda<EMAIL_ADDRESS>
Summary of Changes
Implement API functionality for ML feature search
Tests

Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

@devtagare


NameError: name 'url' is not defined in update_entity

I encountered the following error.
Traceback (most recent call last):
File "entities_simulator.py", line 90, in
update_entity(ORION_URL, e, attrs_to_update)
File "entities_simulator.py", line 52, in update_entity
r = requests.patch(url,
NameError: name 'url' is not defined

thanks @fisuda !


Speech recognition is not supported on this machine error

I've started getting a speech recognition error as of the most recent updates.
UnityException: Speech recognition is not supported on this machine.
UnityEngine.Windows.Speech.PhraseRecognizer.CreateFromKeywords (System.String[] keywords, UnityEngine.Windows.Speech.ConfidenceLevel minimumConfidence) (at C:/buildslave/unity/build/artifacts/generated/Metro/runtime/SpeechBindings.gen.cs:47)
UnityEngine.Windows.Speech.KeywordRecognizer..ctor (System.String[] keywords, UnityEngine.Windows.Speech.ConfidenceLevel minimumConfidence) (at C:/buildslave/unity/build/Runtime/Export/Windows/Speech.cs:221)
HoloToolkit.Unity.InputModule.SpeechInputSource.Start () (at Assets/HoloToolkit/Input/Scripts/InputSources/SpeechInputSource.cs:70)

Though not sure if this is MRTK problem and not a Unity or Windows issue as there have been updates to all three.

Make sure you have Get to know me enabled in your Privacy/Speech, Inking, & Typing menu.

Have same issue , pretty sure  Privacy/Speech enabled , and mic plugin .  better to check
PhraseRecognitionSystem.isSupported before create KeywordRecognizer . Otherwise, it will crash the app

In my case it was an issue with the latest Windows update breaking Cortana & Speech services. Details on a fix at the link: But I'm adding the isSupported check in any case. Thanks!
https://aka.ms/Ksyux5
Issue: After upgrading from Build 16299.0 to 16299.15, you might lose all previously installed Feature-on-Demand (FOD) packages such as Windows Media Player, language features, etc. during the upgrade. If you upgraded to Build 16299.15 from an older build such as Build 16296 – you are not impacted.

Thanks for the update!

For me the solution is to set English (US) as primary language. It will install some additional speech recognition parts in Windows 10.

It happens to me today. I don't why, but it turns out to be a certificate issue. I removed the generated one from my project and it worked again.

NO Solution Find!!!
UnityException: Speech recognition is not supported on this machine.
Me the problem and surely on Unity3D!
I have exactly the same problem of writing here on the issue but I garentie well to have WINDOWS10 and that my unity 5.6.4 P2 this really works great!!!
Purpose
Since I've wanted to do the update of Unity3D 2018 not only the application no longer works! But same Unity3D no longer work!  (Problem of Unity Package Manager with a file manifest. JSON or elsewhere nothing is also solved at the same time! Short end This is not the topic!)
So NOW.
I Reinstall Unit 5.6.4 P2 and magically!
!!! Nothing WORKS!!!
While my Windows10 and always the same WINDOWS10!
The Cortana Application always works very well!
That my microphones is well acctiver!
So I think that I'm going to tear my hair! I was working on this project and now it say UnityException: Speech recognition is not supported on this machine.
UnityEngine. Windows. Speech. PhraseRecognizer. CreateFromKeywords (System. String [] keywords, ConfidenceLevel minimumConfidence)...... blah bla...!
I'm going crazy!
If someone can help me find a solution please?! Before I be go bald! Or to me throw out of the window with my computer.
In you, thanks in advance!

THX for the projects
i have resolut my problem here
https://github.com/lightbuzz/speech-recognition-unity
thank you
see you later

I have done all the above, but I still get the "UnityException: Speech recognition is not supported on this machine" error message. I would appreciate any help...

Please confirm that speech works on your system in a non-HoloToolkit / non-Unity application. Cortana would be a good one to try.
Thanks and please let us know what you find,

@davidkline-ms Thanks for your response. The PhraseRecognitionSystem.isSupported in my Unity program returns false despite having a Windows 10 Enterprise with Cortana enabled. However, when I click on the Start Menu button, Cortana does not appear in my apps, neither does its button appear above the Windows icon...

@HjoshM I had this issue recently after upgrading windows to 17134. If you haven's resolved your issue, maybe try:
Check mic is enabled in project settings and download En-US language pack. Somehow, additional non-display languages seem to be removed after the system update.
Note.  Just downloading that US language pack will do the job.

I am using Unity 2018.3.6f1 and Holotoolkit 2017.4.30 and I am getting "UnityException: Speech recognition is not supported on this machine" while running the app from visual studio.  sometimes it works and other times I get this exception.  Restarting hololens helps, but this issue comes back after running this app few times.  I checked settings and enabled mic for this app.

Moving discussion to Stackover flow since this seems like a non-mrtk bug.

@gianidiny
This error occurred when I tested my project today.
And before i have this error everything works good with speech recognition!
I can be sure that the windows settings are completely correct and the Cortana Application always works very well !
I have tried many methods, including reinstalling windows system.
Can you tell me how you solved this problem?


gh-pages builds still running on CircleCI 1.0?

I think they're NOOP builds, though?
https://circleci.com/gh/unitedstates/congress-legislators/222
I wonder if it's just a matter of disabling CircleCI for that branch?

Yep.


document a tun DOWN failure mode

resolves #514

I will close this issue because it is too rare to document in the troubleshooting guide for the Linux tunnel.


switched to new flags, added result background

Added support for the new flags for most, if not all, countries present in the top25 at the moment. I also added a way to add a background to text, mainly to make match results visually pop out more: Example
Just as an idea, feel free to scrap it 😉

Commented on a couple changes, but otherwise thank you very much for sorting out the country flags!


Deck tracker width

In systems with permanent scrollbars (i.e. under System Preferences -> General -> Show scroll bars), the HSTracker window isn't wide enough. There needs to be an extra 15 px allowance for these systems.

In 0.3, I added a 15px gap to avoid this... I'm looking at a better version (something like an event or property, ...)

Should be fixed in https://github.com/bmichotte/HSTracker/releases/tag/0.3.35


Stop recommending shrink wrapping in assertion messages

See more context in https://github.com/flutter/flutter/issues/103068
The framework has at least one place where we recommend using shrinkWrap: true in an assertion error.
We should stop doing this. We should instead recommend using some kind of custom sliver scheme, or just using some kind of non-scrollable widget like a Wrap or Row/Column. ShrinkWrapping can come with additional performance penalities on build/raster that get harder to reason about and test.

We should also consider deprecating the shrink wrapping classes/parameters.

So far we have identified some Dialog classes as places where shrinkwrap is often needed as some of them use intrinsics. There was a past plan to migrate dialogs to support scrolling children, I found this design doc and related change:

https://github.com/flutter/flutter/pull/45079
flutter.dev/go/scrollable-alert-dialog

Related issues:

https://github.com/flutter/flutter/issues/18108


add check whether any cluster is in use before delete backuppoint

Signed-off-by: Liucw<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@x893675 @zhuzhenfan

Codecov Report

Merging #489 (07265b3) into master (c71c3af) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   13.02%   13.00%   -0.02%
==========================================
  Files         121      121
  Lines       19020    19042      +22
==========================================
  Hits         2477     2477
- Misses      16263    16285      +22
  Partials      280      280

Impacted Files
Coverage Δ

pkg/apis/core/v1/handler.go
0.34% <0.00%> (-0.01%)
:arrow_down:

pkg/apis/core/v1/utils.go
51.14% <0.00%> (-1.20%)
:arrow_down:

/lgtm
/approve


User email verification

Thank you for such great starter kit for laravel. Just want to suggest a feature for email verification after registration process. This is considered basic functionality these days. Thanks!

Release with this as a new feature coming tonight. However, it will require a fresh app to start from. The nice part is that to deactivate it, all you need to do is remove the middleware from the routes.

It's nice to hear this! Thanks a lot!


VOC12 segmentation image resized

As shown on the image the width and height dimension sizes are exchanged for segmentation.
We used VOC12 train and segmentation split dataset for training and VOC12 val and segmentation split dataset for test. Image size is default(300).

I see the problem. Apparently, this happened in the last pull-request. I'll fix it.
Thanks for noticing.

@aokic1, Should work now. Reopen if you encounter weird behavior.


Mobile wallet 1.8 version of a back up wallet into the mobile wallet 3.0 version  failed.

App system back to the desktop

I think Max has closed this because we can't decipher what you're meaning, but if you've copied a mobile wallet into one of the desktop apps - yeah, they're not compatible storage formats, that won't work.

the 1.8 version  Mobile wallet  can't   back up into the  3.0 version mobile.  the App error and  back to the desktop

@CodeCanFly this repo is about the desktop dogecoin core wallet. And not some mobile wallet

I think they want https://github.com/langerhans/dogecoin-wallet-new - I'm also guessing 1.8 should be 1.08 - part of why I got quite so confused is we have a desktop release v1.8, but no mobile v1.8!


CUDA 9.1 Support

I am using NVIDIA GeForce GTX 1050 and installed NVIDIA 388.19. I installed cuDNN 7.0.5 and CUDA 9.1. As of my understanding, I know that, tensorflow is not supported in CUDA 9.1. My question is when I can expect the next build/release of TF to support CUDA 9.1. For the time being, shall I make a link from CUDA 9.0 to CUDA 9.1 and expect to work? Or is there any better way to solve the problem?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

@StevenGann, this is addressed in #15140. The tentative plan, AFAIK, is to move to 9.2 w/TF 1.9. See #18906 for the latest.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

still does not work on 1.8.0 Windows

We are closing this issue for now due to lack of activity. Please comment if this is still an issue for you. Thanks!

for me its also an issue the problem should stay open  because the is not easy solution

Hi.
I installed tensorflow gpu on an HPC server, I have installed the dependencies cudnn and cuda 9.1. But when i import tensorflow it get an error. I read that tensorflow-gpu installed via pip does not support cuda 9.1. Could that be the issue here? The error message is below
ImportError: libcublas.so.9.0: cannot open shared object file: No such file or directory
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/install_sources#common_installation_problems
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

Same here. I have multiple version of cuda 7.5, 8.0, 9.1 They are working fine for various projects.
I have tried installing 9.0 without installing driver and the geforce experience. It's still failed. It would be nice if someone could help me.

I solved my issue. I just installed CUDA 9.0 to a different directory.
And before i import tensorflow i make sure to set my PATH to add cuda 9.0. After doing that i get no error when i run tensorflow gpu


ENH: adding wrapping for UnaryFrequencyDomainFilter

Testing python building.

Thanks @dzenanz . Build errors look unrelated.


Home: Link to listen to current meeting missing.

During this morning's Board Meeting, the link to "Listen" to the current meeting was not showing.

The link had not been made available on Legistar. Screen shot from 1:15 CST.

@shrayshray Do you know when that link appears?

@reginafcompton So, I think the reason I didn't see the link earlier is because the meeting had already ended. The link appears when the meeting begins, and disappears after the meeting ends. Once the recording has been approved, the link appears again and links to the recording.

Show link to general link to player.

I looked into the possibility of showing a general player link, and it looks like Granicus does not have that option.
@shrayshray Do we have more information about the timing of the link activation, so that we can try to coordinate the scrapper?

@reginafcompton It's not possible to just use this link? http://metro.granicus.com/MediaPlayer.php?camera_id=2

@shrayshray Ah, okay. That will work.

Generic link has been added. Closing.


[SPARK-25575][WEBUI][FOLLOWUP]SQL tab in the spark UI support hide tables

What changes were proposed in this pull request?
After the PR, https://github.com/apache/spark/pull/22592, SQL tab supports collapsing table.
However, after refreshing the page, it doesn't store it previous state. This was due to a typo in the argument list in the collapseTablePageLoadCommand().
How was this patch tested?
bin/spark-shell
sql("create table a (id int)")
for(i <- 1 to 100) sql(s"insert into a values ($i)")

Please review http://spark.apache.org/contributing.html before opening a pull request.

Hi @srowen , Kindly review and merge. This PR will be dependent on the PR https://github.com/apache/spark/pull/22645

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Hi @srowen , Kindly review and merge.

Can one of the admins verify this patch?

Test build #4359 has started for PR 22650 at commit cd9ef14.

Merged to master


Support dynamically adding store to storage manager

1.allow server to dynamically add store via StorageManager
2.code changes made in StorageManager, DiskManager, CompactionManager
3.support adding store onto a new disk, which is empty initially.
This PR is dependent on #1210. Once this PR is merged, we can close #994 .

Codecov Report

Merging #1226 into master will increase coverage by <.01%.
The diff coverage is 90.74%.

@@             Coverage Diff             @@
##             master   #1226      +/-   ##
===========================================
+ Coverage     69.49%   69.5%   +<.01%
- Complexity     5516    5521       +5
===========================================
  Files           432     432
  Lines         33844   33888      +44
  Branches       4312    4316       +4
===========================================
+ Hits          23520   23553      +33
- Misses         9137    9141       +4
- Partials       1187    1194       +7

Impacted Files
Coverage Δ
Complexity Δ

...java/com.github.ambry.store/CompactionManager.java
86.92% <80%> (-3.08%)
21 <5> (+2)

.../main/java/com.github.ambry.store/DiskManager.java
86.59% <88.88%> (+0.2%)
49 <6> (+4)
:arrow_up:

...in/java/com.github.ambry.store/StorageManager.java
93.8% <95.45%> (-0.01%)
39 <8> (+3)

.../main/java/com.github.ambry.store/ScanResults.java
81.25% <0%> (-1.57%)
16% <0%> (-1%)

...java/com.github.ambry.network/SSLTransmission.java
69.1% <0%> (-0.64%)
67% <0%> (-2%)

...in/java/com.github.ambry.store/BlobStoreStats.java
71.95% <0%> (-0.62%)
104% <0%> (-1%)

...va/com.github.ambry.replication/ReplicaThread.java
75% <0%> (+0.18%)
67% <0%> (ø)
:arrow_down:

...ava/com.github.ambry.store/DiskSpaceAllocator.java
95.03% <0%> (+1.86%)
38% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c32e7...0a41b91. Read the comment docs.

Codecov Report

Merging #1226 into master will increase coverage by <.01%.
The diff coverage is 90.74%.

@@             Coverage Diff             @@
##             master   #1226      +/-   ##
===========================================
+ Coverage     69.49%   69.5%   +<.01%
- Complexity     5516    5521       +5
===========================================
  Files           432     432
  Lines         33844   33888      +44
  Branches       4312    4316       +4
===========================================
+ Hits          23520   23553      +33
- Misses         9137    9141       +4
- Partials       1187    1194       +7

Impacted Files
Coverage Δ
Complexity Δ

...java/com.github.ambry.store/CompactionManager.java
86.92% <80%> (-3.08%)
21 <5> (+2)

.../main/java/com.github.ambry.store/DiskManager.java
86.59% <88.88%> (+0.2%)
49 <6> (+4)
:arrow_up:

...in/java/com.github.ambry.store/StorageManager.java
93.8% <95.45%> (-0.01%)
39 <8> (+3)

.../main/java/com.github.ambry.store/ScanResults.java
81.25% <0%> (-1.57%)
16% <0%> (-1%)

...java/com.github.ambry.network/SSLTransmission.java
69.1% <0%> (-0.64%)
67% <0%> (-2%)

...in/java/com.github.ambry.store/BlobStoreStats.java
71.95% <0%> (-0.62%)
104% <0%> (-1%)

...va/com.github.ambry.replication/ReplicaThread.java
75% <0%> (+0.18%)
67% <0%> (ø)
:arrow_down:

...ava/com.github.ambry.store/DiskSpaceAllocator.java
95.03% <0%> (+1.86%)
38% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c32e7...0a41b91. Read the comment docs.

Travis is currently down :( . I ran ./gradlew build && ./gradlew test

Np, I noticed that the logs for the failed travis run implied that.
From: Yingyi Zhang<EMAIL_ADDRESS>Reply-To: linkedin/ambry<EMAIL_ADDRESS>Date: Wednesday, July 31, 2019 at 2:26 PM
To: linkedin/ambry<EMAIL_ADDRESS>Cc: David Harju<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [linkedin/ambry] Support dynamically adding store to storage manager (#1226)
Travis is currently down :( . I ran ./gradlew build && ./gradlew test
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flinkedin%2Fambry%2Fpull%2F1226%3Femail_source%3Dnotifications%26email_token%3DAHM4L4ARLGQDMBZE5Z23GADQCH7PXA5CNFSM4IHOXJG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ITNUI%23issuecomment-517027537&data=02|01|dharju%40linkedin.com|577654b40d4147fd0e8908d715fdbc92|72f988bf86f141af91ab2d7cd011db47|1|0|637002051840372753&sdata=w33x3rhCvVgSU%2Bo53GN5CNH1G15nC9x8hB0Wj94d5aE%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHM4L4EUH3DOWWV6PKXOJQ3QCH7PXANCNFSM4IHOXJGQ&data=02|01|dharju%40linkedin.com|577654b40d4147fd0e8908d715fdbc92|72f988bf86f141af91ab2d7cd011db47|1|0|637002051840382751&sdata=Gaz5kHv4EW9oCa5wGdsPFhguFxUQFbGNlIfMbFWrefY%3D&reserved=0.


Drag and Drop Components

Please be as descriptive as possible, including what is expected, why is this feature needed, what is the objective, etc.
What is the feature being requested?
To drag, drop and resize the components on the board using a button on the toolbar. It is expected to enhance the usability of the GUI. The objective will remain to simplify adding of the components. A starred line could be added around the component which could flip and resize the component.
What are the use cases for this feature?
--> Easier to change the design
--> No more filling out the sizes manually

Please add touch support also so that I can use my pen to place components wherever I want them to be in the space.


Distributed tracing issues in Azure Function App - No Correlation

I created a Azure Function App with two functions:
[HttpTrigger] http-triggered function that sends an EventGrid event in CloudEvent schema to a topic
[CloudEventsTrigger] http-triggered function that subscribes to the EventGrid topic using CloudEvent schema (webhook)
After triggering the first function, I can see in App Insights that the two functions have different Operation IDs and the consumer app's traces are not linked to the producer app.
What I understood from the devblog post is that Azure Event Grid client libraries support distributed tracing for the CloudEvents schema out of the box.
I created a repo  for my simple project. It also contains a deployment script so that you can test it yourself. I summarized my finding in the README.md. I think all the info needed for investigation can be found in the project.
Let me know if you need additional data.

/cc @ellismg

Thanks for the helpful repo here, @He-Wolf, I will take a look!

I've discovered another interesting aspect to this. In response above I show traceparent in the arriving event and in extensionAttributes.
At first glance this traceparent is not related to the HttpTrigger function app.
However, I discovered the parentid of the traceparent is the same as the id of the EventGridPublisherClient.send POST as you can see in the below picture.

What I don't understand is why EventGrid changes the traceid portion. Is this causing the two traces to not be linked? Or do we need to manually link the traces like it explains in the devblog? If manual linking is required, how is this done in JavaScript?

After much research I managed to get the CloudEventsTrigger function to link with the HttpTrigger function

In addition to adding the missing packages I also had to do two more changes
The first is setting a custom delivery property on the eventgrid subscription --delivery-attribute-mapping traceparent dynamic traceparent. Event Grid takes the traceparent-id from the CloudEvents extension and inserts it back into the webhook http header. The ApplicationInsights-node.js library is the able to pick up the id from the http header.
The second change is manually injecting traceparent into the event. This is a workaround.
extensionAttributes: {
  traceparent: context.traceContext.traceparent
},

It is needed because EventGridPublisherClient changes the trace-id portion of traceparent. I still don't understand why it is doing this. Unfortunately, manually adding the extensionAttribute sets the HttpTrigger function as parent instead of the POST dependency.

@ellismg @mpodwysocki is there anything we can do on the SDK side here?

After much research into how azure/core-tracing works, I eventually came across this note in the Azure Core Client libraries folder.
From that note I eventually figured out you can extract a tracingContext from the Azure Function context object using opentelemetry propagation.extract.
Then as per the note pass it as an OperationOption to EventGridPublisherClient.send.
I also removed the extensionAttributes workaround in my previous update. Now the timeline looks perfect.

These steps are documented in the otel docs as manual trace context propagation.
The issue is the Event Grid client only provides a single send operation using withSpan for tracing. So auto-instrumentation will always produce a new tracingContext with every send. Which explains the behaviour I mentioned in the past with trace-id being changed.
I believe there needs to be some improvement in the Event Grid client or Application Insights Node SDK to support auto-instrumentation with a proper propagated context.


Adding path variable names to avoid Spring Boot 3.x migration issues

Description
This PR has been opened to fix an IT test issues discovered in this PR: https://github.com/dapr/java-sdk/pull/1050. It is related to MethodInvokeIT test.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: https://github.com/dapr/java-sdk/issues/1061
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

@artursouza and @cicoyle this is a tiny PR to help unblock the Spring Boot 3.2.x, 3.3.x migration.


A error i can't solve ([Errno 5] EIO)

I connected the DS3231 to my Pico: SDA to pin 16, SCL to pin 17, GND to GND and VCC to VSYS.
I copied the example code in main.py and put the RTC_DS3231.py in a my_lib folder. I didn't change any code.
When i tried to run the code I got the error: ([Errno 5] EIO) and when i tried Settime() in the example code I got:
Traceback (most recent call last):
File "", line 13, in
File "my_lib/RTC_DS3231.py", line 26, in DS3231_SetTime
OSError: [Errno 5]  EIO
I tried to run a I2C address scan and got 0x57, but when a changed the address it still got the same error massages.
Does someone know how to solve this problem and make it work like intended?

That address don't sound right.  Try
def init(self, sda_pin=16, scl_pin=17, port=1, speed=100000, address=0x68, register=0x00):

Pretty sure the pin numbers refer to GPIO pin numbers. I've got mine connected up to device pins 11 and 12, GPIO 8 and 9 and I use this to initialize the RTC
rtc = RTC_DS3231.RTC(8,9,0,400000)
Try connecting to device pins 21 and 22 which are GPIO 16 and 17.


JavaScript example

Please i need a JavaScript example for the toggle, turn on or turn off events... I doesnt know how to properly use it. Using OnClick sounds a bit weird to me and i'm not sure if i'm using it properly...
This works clicking in the text but not in the toggle-button:
<input type="checkbox" data-type="simple-switch" OnClick="alert(this.checked);" /> Text
This works clicking in the toggle-button and the text but clicking in the text doesnt change the toggle-button:
<input type="checkbox" data-type="simple-switch"/> Text
Adding an ID to the input generates two alerts when clicking in the text but the toggle-button works:
<input id="whatever" type="checkbox" data-type="simple-switch" /> text
It seems that the input is still visible and can be clicked. This is the html generated:
<input id="whatever" type="checkbox" data-type="simple-switch" class="_simple-switch-checkbox"><button class="_simple-switch-track on" tabindex="-1" style="--simple-switch_size:16px;"></button> text
I'm entirely lost

The input will fire a change event (Switch.js#L169) when the switch changes states, which you can subscribe to by attaching a change event listener to the element, for example:
const switchEl = document.getElementById("mySwitchId");

switchEl.addEventListener("change", e => {
  // do something here
});

The change event should bubble up to a containing label, though I haven't personally tested this.
It may be worth, in the future, adding emitted events directly from Switch objects as well.


No vi in JupyterHub

ping @rsignell-usgs @adavies87

@julienchastang, indeed, while the pico editor is there, it would be very helpful to have vim in the environment for us enthusiasts.

It is actually in there. I don't know why it is not working but will investigate.

Should be working now. Not sure why it was not working before. All I did is rebuild the exact same Dockerfile I was using before. Note, you may have to restart your server to see this change (Hub --> Control Panel, stop and start the server).


bug: Wagmi causing "Property 'TextEncoder' doesn't exist" error in React Native Expo. Is Wagmi compatible with React Native?

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.3.9
Current Behavior
Has anyone come across the problem whereby once you've installed Wagmi in a React Native app and wrapped your app in the provider it causes an error "Property 'TextEncoder' doesn't exist"? Any help would be much appreciated.
App is wrapped in:
...
Config is:
import { configureChains, createConfig } from 'wagmi';
import { publicProvider } from '@wagmi/core/providers/public';
export const { chains, publicClient, webSocketPublicClient } = configureChains([polygonMumbai], [publicProvider()]);
export const config = createConfig({
autoConnect: true,
publicClient,
webSocketPublicClient,
});
Expected Behavior
Not sure if Wagmi and it's dependencies rely on web browser features which we don't have access to in React Native.
Steps To Reproduce
Install latest wagmi viem in React Native Expo project.
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
n/a
Anything else?
No response

See Platform Compatibility. You may have to polyfill.


Support PHP8

Fixes #83
doctrine/coding-standard ^6 and ^7 only supports PHP ^7.1, so updated to branch 8. (9 is also available.)
Updated phpstan/phpstan + phpstan/phpstan-strict-rules from ^0.11 to ^0.12 to support PHP 8.
Removed PHP 5 reference from composer.json
Ran phpcbf, which fixed all CS fails as a result of updating.
The two removed sniffs no longer exist (didnt look for the replacements, if any)
__set magic method is only allowed to return void in PHP8: https://3v4l.org/uiGk3

@jwage did you notice this Pull Request?

@dpi on PHP 8.1 this deprecation message is generated:
PHP Deprecated: Return type of Purl\AbstractPart::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ...//vendor/jwage/purl/src/Purl/AbstractPart.php:139

Might be useful to also resolve this in your patch?
https://github.com/dpi/purl/blob/php8/src/Purl/AbstractPart.php#L139

Id like to get a preference from the maintainer. Whether he prefers to litter the current branch with attributes or fix the issue with a new version. Or both.

@dpi yeah I agree
@jwage any thoughts on this? I gave it a shot myself at https://github.com/holtkamp/purl/tree/patch-php-8.1 for PHP 8.1.

This a great util library, but it seems like it may be abandoned? Anyone have suggestions for an alternate library?

I am no longer personally using this library and don't have the time to maintain it. Happy to hand over the maintenance to someone else. Here is an alternative maintained library https://uri.thephpleague.com/


reworked updateBody function

Current coverage is 100.00%

Merging #58 into master will not affect coverage as of 7da2588

@@            master     #58   diff @@
======================================
  Files            4       4
  Stmts          157     158     +1
  Branches        27      28     +1
  Methods          0       0
======================================
+ Hit            157     158     +1
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 7da2588

Powered by Codecov. Updated on successful CI builds.


⚠ Jenkins Plugins Artifactory has degraded performance

In 7d4431c, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1164 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 34bd5b7 after 12 minutes.


Initial work on OpenMetrics

This should handle all valid inputs, but does not yet reject all invalid inputs.

Whenever the next release is, there's more work to be done. You can already emulate them yourself with gauges.


UBIKSolver.uplugin needs targeted platforms in order to be included in the build

This is an issue I encountered while trying to get a build working on quest 2 (android). It did not include the animation blueprint which contained the UBIK node.
By adding
"SupportedTargetPlatforms": [
		"Win64",
		"Android"
	]

to the UBIKSolver.uplugin I got it included in the build for Windows (HTC-Vive) and Android (Oculus Quest 2) on UE 5.1.1.

thanks for the pullrequest, it's been approved. Closing this issue.


GeometryWidget: Z lable wrong.

The Z label is mistakenly displayed as X.

I remember Scott mentioned that it's fixed, so I'm going to close it.


Fix project name

Describe your changes
Project name was missing underscore
Issue ticket number and link
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[ ] I read the contribution documentation and made sure that my changes meet its requirements

From a consistency point of view, this is indeed necessary, otherwise e.g. the project will not compile in Yocto.
We are fine(r) with the underscore-less naming, but that implies changes in CMakeLists.txt' evc_setup_package() and add_library()s, also in libiso15118's target_link_libraries(). I would prefer that, but if you disagree, this change LGTM.

Why was the underscore missing?  Is there any requirement for having that underscore?


[draft] Support power domains

@eunchan
@msfschaffner
can you guys have a look? I'm not 100% sure how i feel about this.
To simplify things..all the reset outputs have all domains.  So i basically tie off ones that the system does not use..
I thought maybe this would be clearer via selects than having more unique names.
The shadow resets may eventually take a similar path.
let me know what you think.

Thanks @tjaychen.
It looks like it makes things easier to handle with arrays, so in general I think I am fine with that.
The only thing we have to be aware is that this may add a bunch of HIER_NOT_READ / NOT_READ lint warnings if we do not automatically stub off the unused ones using assign unused_* = ^{...}; assignments in the code.
Maybe we can add those assignments automatically as well?

yeah exactly i was thinking that. I was just feeling really conflicted about all these unused* so wanted to get a second opinion before going forward with that.

Thanks @tjaychen.
It looks like it makes things easier to handle with arrays, so in general I think I am fine with that.
The only thing we have to be aware is that this may add a bunch of HIER_NOT_READ / NOT_READ lint warnings if we do not automatically stub off the unused ones using assign unused_* = ^{...}; assignments in the code.
Maybe we can add those assignments automatically as well?

yeah exactly i was thinking that. I was just feeling really conflicted about all these unused* so wanted to get a second opinion before going forward with that.

added automatic declarations for unused.


Adds the unit test for pkg/support

Adds the unit test for support pkg
for #4142
Signed-off-by: Harshitha U R<EMAIL_ADDRESS>

/test-all

/test-all

@antoninbas Can this PR be merged now?

TestAntreaPolicy/TestGroupNoK8sNP/Case=ACNPFQDNPolicy  failed, but I think it is not related to this PR? @antoninbas


NIST PubID scheme: Should the Part number, if in alphabet, be capitalised?

“NIST SP 800-131a” => “NIST SP 800-131A”? (The base document “NIST SP 800-131a” has a R1 as “NIST SP 800-131Ar1”.)
"NIST SP 800-38a” => "NIST SP 800-38A”? ("NIST SP 800-38a” but "NIST SP 800-38F”)

We propose this to be the case.
This is implemented already.

This is confirmed in final PubID scheme (#153 ) to be the case as {0-9A-Z}.


3.0.0 Beta 1 - Fix System.IO.DirectoryNotFoundException when trying to save package installation options

While testing #1875 I noticed that I am unable to save any changes made to the installation options of a chocolatey package, as my %USERPROFILE%\.wingetui directory does not have a subfolder the app is trying to write to. This change ensures that the parent directory actually exists.
I'd also suggest to use the FileInfo class instead of the static methods, as I stumbled upon this pattern:
if (!Directory.Exists(Path.GetDirectoryName(__ignored_updates_database_file)))
    Directory.CreateDirectory(Path.GetDirectoryName(__ignored_updates_database_file));
if (!File.Exists(__ignored_updates_database_file))
    File.WriteAllText(__ignored_updates_database_file, "{}");

which would nicely clean up to:
var ignoredUpdatesFile = new FileInfo(__ignored_updates_database_file);
if (ignoredUpdatesFile.Directory?.Exists == false)
    ignoredUpdatesFile.Directory.Create();
if (!ignoredUpdatesFile.Exists)
    File.WriteAllText(ignoredUpdatesFile.FullName, "{}");

Less juggling of file paths and no compiler warning, as Path.GetDirectoryName technically can return null.

[X] I have read the contributing guidelines and I agree with the Code of Conduct
[X] Have you checked that there aren't other open pull requests for the same changes?
[X] Have you tested that the committed code can be executed without errors?

Looks good to me.
I will merge the PR once I test it


Added asset scraper from Tiingo.

Refactored CBOE scraper, now it is implemented as a module.
Added logging.

Solves #37, #8


NiftyExceptionLogger.java probably shouldn't log at error severity for broken connections

nifty-core/src/main/java/com/facebook/nifty/core/NiftyExceptionLogger.java contains the following line:
log.error(exceptionEvent.getCause(), "Exception triggered on channel connected to %s", remoteAddress);
It is probably not at the error severity to log a broken connection. It would show up as ERROR on log4j based logs. This class of severity is usually reserved for things that shouldn't happen in production, but broken connection happens all the time in normal operations.

I also get this error:
org.jboss.netty.handler.codec.frame.TooLongFrameException: Maximum frame size of 67108864 exceeded
I spin up a service that takes sockets and someone hits it with http. It spews ERROR logs like crazy.

org.jboss.netty.handler.codec.frame.TooLongFrameException: Maximum frame size of 67108864 exceeded
org.apache.thrift.protocol.TProtocolException: Bad version in readMessageBegin
org.apache.thrift.transport.TTransportException: Buffer doesn't have enough bytes to read

I would change logging to OFF for this class, but then I wouldn't get any errors! All errors roll up to this class. Starting to think it isn't the best approach.


Nuget Package Creation - v1.8.8

Github actions version updates.
MimeKitLite dependency update from '3.4.1' -> '3.4.2'.
Nuget package creation - v1.8.8.

Codecov Report
Base: 99.48% // Head: 99.48% // No change to project coverage :thumbsup:

Coverage data is based on head (5d6020d) compared to base (f29ac2f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   99.48%   99.48%
=======================================
  Files           1        1
  Lines         782      782
  Branches      183      183
=======================================
  Hits          778      778
  Misses          2        2
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Reflexion : Import old blocks in Thanos

Hi,
I have a question about a use case. On prometheus project a tool is almost released to import old metrics from any system, in OpenMetric format and to a local runing Prometheus instance.
I see 2 scenarios :

Prometheus has a sidecar : Blocs should be ingested I think... Everything will be ok for store gateway and bucket after that ? Metrics should be queriable ?
Prometheus has a remote write configured to Thanos : Receiver will store all blocks in its local TSDB, what appends after that ? Everyting should works ?

Also, I'm not sure to totally undertand the new receiver component. It seems imprement the original Prometheus TSDB and store data localy but what appends after ? It acts as a sidecar or data are sent to bucket by another way ?
Regards

I recommend reading the design doc we wrote for the component. But you understood correctly, the receive component accepts the writes, produces the immutable blocks on disk every 2 hours and uploads them to object storage.
The sidecar and receive approach are fundamentally different, and each have their place. We offer deployment and use case flexibility you choose what fits your situation best :)

Ok, Thanks ! It's what I thought about receiver. But in this case two solutions are compatible to ingest imported blocs from the past with potential times overlapping ?
Or it will break thanos because it needs its own import system based on cluster components ?

Both are compatible, in fact we have a system running that now only ingests via the receive component, but used to use the sidecar, and everything works just fine with the historical data, and as you already said, for a short amount of time we had some overlap during the migration, but that worked just fine.

Great ! Many thanks for your answer ! I will make some tests soon ! :)


[$250] Tags - After bulk delete, adding tag with same name shows error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.34-2
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Launch app
Create a workspace
Enable tags
From old dot, upload below tag file
In new dot, tap tags
Delete "1" tag
Add "1" tag
Note tag "1" can be added without error
Select all tags and delete it
Add "1" tag
Note tag already exists error displayed
Refresh the page
Add "1" tag
Now tag added without error

Expected Result:
After bulk delete, adding tag with same name must not show error and user must able to add tag.
Actual Result:
After bulk delete, adding tag with same name shows tag already exists and user can add tag only after refreshing the page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/8d419e5f-8979-4d5b-b155-6a66af5d7aea
Bug6601913_1726207158406!Over_500_tags.csv

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836494001906109803
Upwork Job ID:<PHONE_NUMBER>906109803
Last Price Increase: 2024-09-18

Issue OwnerCurrent Issue Owner: @ishpaul777

Proposal
Please re-state the problem that we are trying to solve in this issue.
When tags are deleted in bulk and a new tag is created with one of the deleted tags names it throws same name error.
What is the root cause of that problem?
When we delete multiple tags the network request takes significant time and the tags remain till the delete process is complete so this
https://github.com/Expensify/App/blob/587698f1f4c703bab45d10056551ede97a67abe0/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx#L50-L51
throws an error.
What changes do you think we should make in order to solve the problem?
We add CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE to each tag optimistically while they are being deleted.
https://github.com/Expensify/App/blob/587698f1f4c703bab45d10056551ede97a67abe0/src/libs/actions/Policy/Tag.ts#L301
We can use this check here
https://github.com/Expensify/App/blob/587698f1f4c703bab45d10056551ede97a67abe0/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx#L50
like
            } else if (tags?.[tagName] && && tags?.[tagName]?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {

What alternative solutions did you explore? (Optional)

It looks like this issue is no longer valid, due to validation being added before the import file.
And the csv file provided also cannot be imported anymore.


add uma abis

Signed-off-by: John Shutt<EMAIL_ADDRESS>Issue https://github.com/snapshot-labs/snapshot/issues/2814 [partial]
Changes in this PR:
Adds UMA ABIs to constants file, as a first step to integrating UMA execution in the current user interface. Eventually UMA execution will be included in the big refactor, but separating development of this feature into its own track will allow us to launch before the refactor is done.
How to test and review this PR?
Compare the new ABIs with the actual ABIs for UMA's optimistic governor, optimistic oracle, and voting contracts. (Note: The ABIs are the same as those in the big refactor branch, where UMA execution appears to be working.)
Note:
Closing out the earlier PR to use the uma branch from my fork. This new PR uses the compact ABI format.

Thanks @bonustrack! Can you merge the PRs once they're approved? Alex and I will be working on separate PRs from the uma branch so we should keep the branch up-to-date.

Yes sure @pemulis just merged


new: [script] add a download script for the sqlite and JSON cities

new: [script] add a download script for the sqlite and JSON cities

Can you give some details on why this script is required and how will this run?

Sure. it's for situation like #59 or when you have to run geograpy3 in continuous integration and the process of downloading is separated from the overall process of installation of the Python package.

Thanks for the merge!


Metrics Model Design should include Difficulty or Time Investment associated audiences

In the model of a toolkit we should also indicate up front what the investment associated with a metric model.
For example if I have to setup a notebook, and query data then that's medium to high investment, but if I just have to go to the GitHub dashboard, that's easy.
Similarly if I have to run a survey in an instance like phycological safety, we should indicate that is high investment, but also only available to certain audiences (the project maintainer, but not contributors or funders).
I will demonstrate what this might look like in https://docs.google.com/document/d/1DpHhVMAwucaKoXoOYMCnmxZuhWMqWupDsZvWpxe_A0M/edit

@emmairwin : I think you are talking about "difficulty to develop", correct?

@emmairwin -- thanks for the comments. We really worked through these but they created some difficulty in making that determination from our (CHAOSS) side of things.

I'm closing this for now as we aren't including the difficulty right now. In an effort to simplify the definition of the metrics models, we are following the template at: https://github.com/chaoss/community/blob/main/templates/metrics-model-template.md


Support Deep links for the Android app

We want to support  deepllinks for the following pages on the app-

Feed
Dashboard statistic
Goodmarket
Invite page

@omerzam not sure why you assigned this to me.
you've handled the deep/app links in one of the previous tasks.
deep link means that if a user clicks on a web link that leads to wallet.gooddollar.org/XXX it will open the mobile app in the correct XXX path.
@Esfir-E are there links that we DONT want to open the app for? i dont think there are, i think every wallet.gooddollar.org/* should open the mobile app
3. GoodMarket - that's an external website so it makes no sense

@omerzam

about the Goodmarket Hadar is right there is no need thats my bad
what we do need is the following -

invite page
Dashboard statistic

@Esfir-E i'm asking again are there links we DONT want to open in the mobile app?


Limited prompt

Is that normal that prompt are trunkated ?

If you mean at 64 / 77 tokens, then yes.  The "infinite prompt" thing is an extension in automatic1111 and such that splits longer prompts and feeds them into the model in stages.

Shark should currently detect and build a different unet if you go over 64 / 77 token, that supports a longer prompts and uses that. (I think up to 512? The .vmfb files get unet512 in the naming rather than just unet, but I'm not super sure of how it works).
It doesn't use that unet by default as that one creates somewhat different images to the 64 / 77 version with the same seed even when a longer prompt isn't needed.

That's odd.  I'm guessing I'm going over most of the time without knowing it.  Looking at my built .vmfbs most are using unet512.  At the same time I've had it error out saying the model could only handle 64/77 tokens when the prompt was nowhere near 512 tokens, so I'm not sure.  I think this only happened when I had a really long negative prompt, so it's possible only the positive prompt is checked to see which it should use?  I searched the codebase for related terms and saw quite a bit about unet512 upconvert in the chat models but not in diffusers.


Add a class to the error-debug screen

This allows developers to easily target the div and take actions on it (override styles, for example).

I think this is better done by defining your own error component?

I defined my own _error.js file, but the ErrorDebug component still gets injected during development (NODE_ENV !== 'production').
The reason I ran into this situation is because I'm trying to show a login page if the user visits a protected route. Everything works fine in production, and mostly fine during dev except my login form is being hidden because ErrorDebug has a z-index of 9999.
Here's some sample code:
import React from 'react';
import circular from 'circular';
import LoginPage from './_login';

export default class Error extends React.Component {
  static getInitialProps({ pathname, query, res, xhr, err }) {
    let statusCode = null;

    if (res) {
      statusCode = res.statusCode;
    } else if (xhr) {
      statusCode = xhr.status;
    }

    const error = JSON.parse(JSON.stringify(err, circular()));
    return { statusCode, pathname, query, error };
  }

  componentDidMount() {
    window.Raven.captureMessage(this.props.statusCode ? 'Server Error' : 'Client Error', {
      extra: {
        pathname: this.props.pathname,
        query: this.props.query,
        error: this.props.error,
      },
    });
  }

  render() {
    return (

{
        <Choose>
          <When condition={this.props.error.response.status === 401}>
            <LoginPage />
          </When>
          <Otherwise>

{this.props.statusCode
            ? `A ${this.props.statusCode} error occurred on server`
            : 'An error occurred on client'}

          </Otherwise>
        </Choose>
      }

    );
  }
}

Error.propTypes = {
  statusCode: React.PropTypes.number,
  pathname: React.PropTypes.string,
  query: React.PropTypes.obj,
  error: React.PropTypes.obj,
};

and the DOM output:

Where my div with "data-reactid=2" is my login form, but I can't see it due to the ErrorDebug z-index :/

I'm trying to show a login page if the user visits a protected route

@aesopwolf ErrorDebug component should not be injected if it's not an error. How do you implement this ?

Like so:
static async getInitialProps(ctx) {
  const user = await http.get('v1/user');

  return {
    user: user.data.user,
  };
}

However, if the user isn't authenticated then an error will bubble up (since I'm not using try/catch). The error is then exposed to me in _error.js where I proceed to use this.props.error.response.status === 401 to conditionally display a login screen.
I don't want to get sidetracked here though. The real goal of this PR is to simply add a class name to the div.

Makes sense but that is not something we recommend. I'd like to support displaying these errors in another way and think we should not add a class to the component for this purpose.
Instead you can use #__next > div > div:nth-child(2) as the css selector for now.
Related: https://github.com/zeit/next.js/issues/746

Closing in favor of what @nkzawa said.
This might help https://github.com/zeit/next.js/pull/1040


Hotfix: body scope issue

Problem
body data directive is not receiving data
Solution
Restore the original scope so that both the bodies directive and body data are contained within the bodyController scope.


Support config for default width/height of browser window

This addresses #108 (sort of). Ideally I think rows/cols make more sense since this is a terminal application. This at least gives the user something to work with.

I like the idea of just memorizing the last size the window was open. What do you think?

For anyone that creates more than one window for one-off commands or having two windows side-by-side would probably want to set a "default" for creating new windows.
I may not understand the logic fully of saving the last window size, but let's say I normally have my windows at 900x450 and then open a new window and resize it to fit in the bottom right corner of my screen for a quick command, or maybe a plugin is creating a new window for me, then that window would overwrite the last size and my next new window would be messed up and i'd have to resize it back to my preferred default. If I have defaults, I don't have to worry about resizing windows messing with my preferences.
So, thinking through the logic for window creation dimensions:
windowSize -> last window size -> fallback
So, I would actually remove windowSize from the default config, and have that be an optional config that users can set if they prefer to always create new windows with their preferred size.

Makes a lot of sense… Since it's a bit of advanced flag, maybe we should take it out of the default file? And we can document it here: https://github.com/zeit/hyperterm-website

Yep, exactly. Removing it from the default config should make it work nicely with memorizing window size and cover a lot of user preferences.

Done! PR over on https://github.com/zeit/hyperterm-website created as well.

Sorry, one last rebase 🙏

all set 🎊


Pointer location info

Show lat long coordinates.

Putting this on hold.
Information already present in the url and in the panel (selected square)

Not sure if we want to consider this at the moment anymore. Going to close this. Reopen if we want to revisit this idea.


Fix to torch_inferencer pre_process trying to use 'to(device)' on a n…

Fix to torch_inferencer pre_process trying to use 'to(device)' on a n…umpy istance with broken shape
📝 Description

With 1.0.0 the torch inferencer is broken, when working on 501a for example, if we convert the export and inferencer of the model to the TorchInferencer we will get broken result caused by doing numpy.to(device) in the pre_process of the inferencer. Being .to(device) a tensor method it is not possible to be working.
Provided the fix by making a .transpose of the ndarray coming in and exporting the result with torch.from_numpy(ndarray).to(device) instead of ndarray.to(device)

✨ Changes
Select what type of change your PR is:

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🔨 Refactor (non-breaking change which refactors the code base)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[x] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 📚 Documentation update
[ ] 🔒 Security update

✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:

[ ] 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
[ ] 📚 I have made the necessary updates to the documentation (if applicable).
[ ] 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Hello there, this is my first pr made on a open source project, happy to clarify and correct all mistake that i could have made!


Publish forthcoming and past workshops on the web

Ideally, the list of workshops should be:

Rendered on the website; and
Downloadable in machine-readable form e.g. JSON

@weaverbel Not sure if we need to do this ourselves or just tap into AMY?

Let's discuss it when we have a more fleshed out proposal @jezcope?I have AMY access but it is a bottleneck to have only one person with those credentials, and anyway, we want something open. I will check whether I can export LC workshops info from AMY.

Ok, I've drafted up a workshops page here, which you can view at https://jezcope.github.io/librarycarpentry-website/workshops/
I've imported the data from the Google sheet into this YAML file, roughly following the structure of the data that AMY outputs: https://github.com/jezcope/librarycarpentry-website/blob/master/_data/fake_amy.yml
The whole thing needs refinement and the process documenting, and the data definitely needs improving, but we're getting there.

We certainly are getting there. Great job Jez. We will need some documentation for adding new data. Feel free to hand that over if you run out of time.

@jezcope: are you happy to leave issue here or would rather consolidate at https://github.com/data-lessons/librarycarpentry/issues?

@drjwbaker @weaverbel Ok, I've pushed an update with the workshop info held in a more maintainable way. Data about workshops is now in _data/fake_amy.yaml (name chosen because the format mirrors that exported by AMY for the SWC website, but probably shouldn't really be that). There's a line down near the bottom like this:
- &id_ws_future # future workshops: move this line down as time passes

which separates the past and future workshops — this needs to be moved further down each time a workshop goes past. New workshops can be added by copying and pasting an existing workshop entry. They look like this:
  - address: Information Commons, University of Sheffield, Sheffield
    contact<EMAIL_ADDRESS>    country: gb
    start: 2017-03-07
    end: 2017-03-23
    eventbrite_id: ''
    humandate: 7 & 23 Jun 2017
    latitude:  41.7901128
    longitude: -87.6007318
    slug: 2017-03-07-sheffield-lc
    tags:
    - {name: LC}
    url: https://jezcope.github.io/2017-03-07-sheffield-lc/
    venue: University of Sheffield
    who: "Jez Cope, Martin Callaghan, Elly Cope"
    numbers: 50
    what: "Data Intro, Spreadsheets (from DC), OpenRefine, Python"
    notes: null
    blogs: null

The key fields that are currently being used are: url, venue and humandate, but try to fill in as many of the others as possible for future use.
This still needs better documentation, of course!

Awesome job @jezcope! Tried to make some changes (add workshop) but am getting a build fail on a line I didn't touch:
There was a YAML syntax error on line 102 column 5 in _data/fake_amy.yml: did not find expected key while parsing a block mapping.
Thoughts?

Hmm, not sure. Where is the error occurring? Are you running Jekyll on your own computer or testing it on github?
Could you post your modified YAML file as a gist so I can take a look?

I reverted and changed some since and it is fine now. It wast just odd that a line I didn't touch as failing. If it happens again, I'll report again.

No worries. 🙂 Most tools are bad at localising errors to where the actually occurred (try missing out a } in a C-derived language sometime…), because it's pretty hard to do! Generally the best you get is a report of where the tool finally gave up because it couldn't get any further, which is often way past where you actually made a typo.

@drjwbaker I spotted the broken commit in the history and took a look — I've added a couple of comments on 1fcffc12770a09c915d14380275919d0159573de which should clarify where the problem occurred.


How can we run R script using R server on HDInsight from Azure data factory v2?

Is there any other option to run  R script on on demand HDInsight cluster through ADF v2?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b1f56f1-dfe7-8b1b-1dd7-d497dd0b75d3
Version Independent ID: a8492158-8867-791a-e291-e9dc2d706206
Content: Compute context options for ML Services on HDInsight - Azure
Content Source: articles/hdinsight/r-server/r-server-compute-contexts.md
Service: hdinsight
GitHub Login: @nitinme
Microsoft Alias: nitinme

@RoopAnymous Thanks for the feedback. We are actively investigating and will get back to you soon.

@RoopAnymous I don't see a simple way, since there isn't a HDInsight "R" activity in ADF v2 yet.

There's a code sample of how to invoke the R script from a custom app through a Map Reduce job here:
https://github.com/Azure-Samples/data-factory-r-server-apache-spark-pipeline

ADF's custom activity could be used to run the R script within Azure Batch compute resources:
https://docs.microsoft.com/en-us/azure/data-factory/transform-data-using-dotnet-custom-activity

Someone blogged that solution based on Azure Batch here https://dataninjago.com/2018/07/20/execute-r-scripts-from-azure-data-factory-v2-through-azure-batch-service/

If I hear of an easier way I can let you know, but I'm not optimistic that any better option exists at preset.

Thanks, Jason

@RoopAnymous Two more options to try came in from asking around:

https://github.com/Azure/Azure-DataFactory/tree/master/Samples/CustomizedJavaOnHDInsight/HDInsight-ADF/ADFjsons/Pipeline/RServerOnLinux

https://github.com/Azure/Azure-DataFactory/tree/master/Samples/RunRScriptUsingADFSample

Hope that helps! Jason


Fixed, Wrong Summary Message under 'Your Name' in Settings

On Settings Page,
Summary for Your Name was Developer mode disables publishing of Apk to BuildmLearn Store
Now changed it to current username

Thanks, good catch

Thanks!


AttributeError: 'BBLogger' object has no attribute 'debug2'

I'm running into this error with latest dunfell meta-flutter:
- snip -
File: '/home/hannes/devel/tisdk/sources/meta-flutter/lib/gn.py', lineno: 82, function: _rungnclient
     0078:    def _rungnclient(self, ud, d, quiet):
     0079:        bb.utils.mkdirhier(ud.syncpath)
     0080:        os.chdir(ud.syncpath)
     0081:
 *** 0082:        logger.debug2("Fetching %s using command '%s'" % (ud.url, ud.basecmd))
     0083:        bb.fetch2.check_network_access(d, ud.basecmd, ud.url)
     0084:        runfetchcmd(ud.basecmd, d, quiet, workdir=None)
     0085:        logger.debug2("Packing %s using command '%s'" % (ud.url, ud.packcmd))
     0086:        runfetchcmd(ud.packcmd, d, quiet, workdir=None)
Exception: AttributeError: 'BBLogger' object has no attribute 'debug2'

DEBUG: Python function base_do_fetch finished
DEBUG: Python function do_fetch finished

Seems to be caused by commit 18581e6f392bf8de3a605c4a8bb3891aee5df8db. (It changed logger.debug(2, ...) to logger.debug2 in the gn.py)

I believe there's a fix for that in kirkstone.  Allows running with debug flag.

@ardera See if reverting this on dunfell helps:
https://github.com/meta-flutter/meta-flutter/commit/80728ca8206ae8f68728880257581e43a1ff4582

@jwinarske We faced on the same error.
Replacing debug2 with debug, we could solve the error.
So, reverting https://github.com/meta-flutter/meta-flutter/commit/80728ca8206ae8f68728880257581e43a1ff4582 is required for dunfell branch.

https://git.yoctoproject.org/poky/tree/bitbake/lib/bb/__init__.py?h=dunfell#n84
In dunfell, debug2 is not implemented.
https://git.yoctoproject.org/poky/tree/bitbake/lib/bb/__init__.py?h=kirkstone#n50
In kirkstone, debug2 is implemented.

@WAKazuyoshiAkiyama thanks for the confirmation.

0ca204fd23e4c15fe9fed189d21cbb6af0895241 fixes this.


Added Deserialization handling

Table of Contents
Link to GitHub issues it solves
closes #17
Description
Added Deserialization Handling
Contributing has more information and tips for a great pull request.

@Zeobot set lc to pass

@zeobot set lc to pass


Corfu window hanging with "no match"

I don't know if this is an issue that I should open at corfu, but at my end every now and then I get a popup with "no match" and have to manually "C-g" to make the suggestion window disappear.
I wonder if there is a way to not have completions be triggered unless there are actually completions available?

I think the way it currently works we don't know whether there will be completions available at the time that we're triggered.
What is your corfu-quit-no-match set to?

It's set to 'separator.

Can you try changing it to t?
https://github.com/minad/corfu/blob/12b9712f546fc7b6229e56336bfa375fa3165406/corfu.el#L119

Closing this due to inactivity. Please feel free to reopen if you still need assistance.


Failed to pull core-gateway image during bootstrapping

I'm trying to run cbd start with CBD 2.10.0 and failed to pull core-gateway image. Looks like the image is missing on docker hub. Does that mean I mis-config the dependency reference or trying to pull unexpected dependency? Can someone help me resolve the issue?
generating docker-compose.yml
generating uaa.yml
generating vault-config.hcl
generating traefik.toml
generating Caddyfile
Initialize and migrate databases
Creating volume "cbreak_common" with default driver
Creating cbreak_commondb_1 ... done
netstat: can't scan /proc - are you root?
Creating cbreak_vault_1 ... done
Profile has been updated with the Vault root token
Profile has been updated with the Vault unseal keys
Vault is unsealed
renaming: docker-compose.yml to: docker-compose-20190520-114821.yml
generating docker-compose.yml
generating uaa.yml
generating vault-config.hcl
generating traefik.toml
generating Caddyfile
Success!
The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing.

Continue with the new image? [yN]

It turns out that the image is non-public. I got permission and things work now.

I'm running into the same issue? How does one go about getting permissions to this image?

Running into the same issue, how to get permissions for this image ?


render can break valid yaml

Expected behavior
Rendering a kpt package shouldn't break otherwise valid yaml.
Actual behavior
In some cases, kpt fn render (or imperatively running any kpt fns on the package) will result in invalid yaml.
Information
$ kpt version
1.0.0-alpha.10

Steps to reproduce the behavior
mkdir test
cd test
kpt pkg init
cat <<EOF > service.yaml
apiVersion: v1
kind: Service
metadata:
  name: nginx
  labels:
    app: nginx
spec:
  selector:
    app: nginx
  ports:
    - name: http
      port: 80
      targetPort: 8080
      nodePort: null
EOF

At this point, I have a kpt pkg containing a service that other tools recognize as valid:
$ kubeval --strict service.yaml
PASS - service.yaml contains a valid Service (nginx)

$ kubectl apply -f service.yaml
service/nginx configured

But, if I render the package:
$ kpt fn render
Package "test":
Successfully executed 0 function(s) in 1 package(s).

$ kubeval --strict service.yaml
ERR  - Failed to decode YAML from service.yaml: error converting YAML to JSON: yaml: cannot decode !!null `null` as a !!int

$ kubectl apply -f service.yaml
error: error parsing service.yaml: error converting YAML to JSON: yaml: cannot decode !!null `null` as a !!int

$ cat service.yaml
apiVersion: v1
kind: Service
metadata:
  name: nginx
  labels:
    app: nginx
spec:
  selector:
    app: nginx
  ports:
    - name: http
      port: 80
      targetPort: 8080
      nodePort: !!int null

Based on the api type of nodePort, I can kind of guess why this might be happening but, since other tools support it, introducing kpt probably shouldn't break things.

@phanimarupaka Can you investigate if formatting has any role to play in it ?

Yes. This is related to formatting. I will figure out a better way to address this edge case.

@ryane The fix has been merged. You can find it in the next release within a one week span. Stay tuned. https://github.com/GoogleContainerTools/kpt/releases


 Status code: 500 InternalServerError. Message: multiple tcp connections created in a `MultiAddr` (origin: Transport, kind: Unsupported, source
  | location: implementations/rust/ockam/ockam_api/src/nodes/connection/mod.rs:228:40) (origin: Api, kind: Serialization, source location: /Users/runner/work/ockam/ockam/implementations/rust/ockam/
  | ockam_core/src/api.rs:166:17)
  help: Please report this issue, with a copy of your logs, to https://github.com/build-trust/ockam/issues

  Version 0.91.0, hash: 9f2db0ed251232946489097230ee60cd9e746cb0

HELLO

same error with:
curl --proto '=https' --tlsv1.2 -sSfL https://install.command.ockam.io | bash
ockam reset --yes

ockam identity create a
ockam node create a --identity a

ockam identity create hop
ockam node create hop --identity hop

ockam identity create b
ockam node create b --identity b

ockam secure-channel-listener create a --at a --identity a --authorized $(ockam identity show b)

ockam secure-channel create --from b --identity b \
  --to /node/a/service/a --authorized $(ockam identity show a) |
    ockam message send hello --from b --to -/service/uppercase

ockam secure-channel create --from b --identity b \
  --to /node/hop/node/a/service/a --authorized $(ockam identity show a) |
    ockam message send hello --from b --to -/service/uppercase

On my side, I would question hops from another angle. When you create a hop on a node and you allow a message to choose where to go after the hop you implicitly couple the knowledge of the network topology to the node sending the message.
I am not a networking protocol expert but it seems to me that it is contrary to encapsulation principles. In general a message should give its final destination at a high-level without having to know about the actual topology. Then that routing should be translated to concrete addresses of concrete machines as an implementation detail. Kind of what is presented in this video. Are there existing protocols where hops are actually part of the high-level route of a message?

@etorreborre that is easily achievable with the current implementation. If you instantiate the topology first, you can give it an alias and use it, which hides the implementation/topology details from the user

@SanjoDeundiak yes. My question is: shouldn't this be the preferred way to do this sort of things?

@etorreborre Secure Channels already kind of do this. We always have an open possibility to use this approach even more if we decide to, for now I don't see strong reasons to do it


feat:  Offers tab in profile and gallery item

PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context
test: https://deploy-preview-10911--koda-canary.netlify.app/ahp/gallery/166-2408213503

[x] Closes #10845
[x] Closes #10846
[x] Closes #10912

Needs Design check

@exezbcz please review

Screenshot 📸

[x] My fix has changed something on UI;

Gallery Item

Profile detail

Cancel Offer

Accept Offer

Decimals in price should be displayed in full. It looks good on the gallery details page.

fixed

At the third row of offers, the time looks incorrect.   17.08 (16 days ago?)

seems like an indexer issue, query is ok, that offer should be EXPIRED  cc @vikiival
      {
        "id": "174-4008829562",
        "expiration": "6920253",
        "blockNumber": "6919953",
        "price": "1000000",
        "status": "ACTIVE",
        "caller": "16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z",
        "desired": {
          "id": "166-2408213503",
          "name": "Ezop #56",
          "sn": "2408213503",
          "currentOwner": "13zFVp9pdsJCJPeVBBRiSAkhBgZ4qENVEZBvfbs9Ft4rHVM8",
          "__typename": "NFTEntity"
        },
        "__typename": "Offer"
      }

I mean the days look confusing and it can't tell whether it's the future or the past Is it possible to show the relative time of the offer? like (16 days ago) , (in 3 days)

I did talk with @exezbcz  about this and he wanted it without the "in x days" just "x days", added time ago if the offer is expired

Yup it is a bug

https://github.com/kodadot/stick/issues/300

Hey, seems like a lot of tests is failing on this PR

Hey, seems like a lot of tests is failing on this PR

fixed tests related to this pr


Hide html extension

Use the existing .htaccess, see https://stackoverflow.com/questions/1992183/how-to-hide-the-html-extension-with-apache-mod-rewrite#1992191

For pages other than index, this should be solved by using links without the extension. Not sure if the htaccess method is necessary.

Looks like it's solved just by using .html-less links.


Add [max] button to transfer allowance and bonding

What's the problem? (required)
I want all my LPT to be bonded, but I don't know off-hand exactly how much LPT I have to X decimal points.
Interface also shows varying levels of decimal points in diff places which can cause some minor dust issues.
What's the current behavior? (required)
Different behavior during transfer allowance and bonding, but at certain points, there isn't clear display to reference and have to switch screens.
Do you have any personal experiences dealing with this problem? (optional)
I typed in the max I saw in the interface, but after successful bonding, it looks like there was some dust remaining that wasn't bonded.
Describe a possible solution you've considered (optional)
I'd like there to be a max button that pulls the total LPT I have in an account for the transfer and bonding approval.
I would also like to see my LPT balance at all times.
Additional context (optional)
Add any other context or screenshots about the enhancement or feature request here.

@dtkong I like this idea, but I am not sure if this feature is really needed because the user's LPT balance is displayed to them with 18 decimal places precision when they are bonding. Copy and pasting the value displayed gives max. While, it would be easier to just click a button, I would like to avoid a situation where adding a button confuses new users or a user mistakenly clicks on max and bonds all their tokens when that was not the intention.
Let me know what you think.

The new explorer allow you to stake your max balance by clicking "balance".


Data races in Geometry.java

I have created a tool that detect data races in java.
The tool has detected the following races in Geometry.java:

Race between read and write of field builtAccel:

  #0 org.sunflow.core.Geometry.intersect() Geometry.java:93
  #1 org.sunflow.core.Instance.intersect() Instance.java:135
  #2 org.sunflow.core.InstanceList.intersectPrimitive() InstanceList.java:30
  #3 org.sunflow.core.accel.BoundingIntervalHierarchy.intersect() BoundingIntervalHierarchy.java:559
  #4 org.sunflow.core.Scene.trace() Scene.java:199
  #5 org.sunflow.core.LightServer$1.run() LightServer.java:231
  #6 java.lang.Thread.run() Thread.java:844

 Previous write of size 8 at 0x7f2a7ef10038 by thread T16:
  #0 org.sunflow.core.Geometry.build() Geometry.java:119
  #1 org.sunflow.core.Geometry.intersect() Geometry.java:-1
  #2 org.sunflow.core.Instance.intersect() Instance.java:135
  #3 org.sunflow.core.InstanceList.intersectPrimitive() InstanceList.java:30
  #4 org.sunflow.core.accel.BoundingIntervalHierarchy.intersect() BoundingIntervalHierarchy.java:559
  #5 org.sunflow.core.Scene.trace() Scene.java:199
  #6 org.sunflow.core.LightServer$1.run() LightServer.java:231
  #7 java.lang.Thread.run() Thread.java:844```

Race between read and write of field accel:

  Read of size 8 at 0x7f2a7ef10038 by thread T24:
  #0 org.sunflow.core.Geometry.intersect() Geometry.java:93
  #1 org.sunflow.core.Instance.intersect() Instance.java:135
  #2 org.sunflow.core.InstanceList.intersectPrimitive() InstanceList.java:30
  #3 org.sunflow.core.accel.BoundingIntervalHierarchy.intersect() BoundingIntervalHierarchy.java:559
  #4 org.sunflow.core.Scene.trace() Scene.java:199
  #5 org.sunflow.core.LightServer$1.run() LightServer.java:231
  #6 java.lang.Thread.run() Thread.java:844

 Previous write of size 8 at 0x7f2a7ef10038 by thread T16:
  #0 org.sunflow.core.Geometry.build() Geometry.java:119
  #1 org.sunflow.core.Geometry.intersect() Geometry.java:-1
  #2 org.sunflow.core.Instance.intersect() Instance.java:135
  #3 org.sunflow.core.InstanceList.intersectPrimitive() InstanceList.java:30
  #4 org.sunflow.core.accel.BoundingIntervalHierarchy.intersect() BoundingIntervalHierarchy.java:559
  #5 org.sunflow.core.Scene.trace() Scene.java:199
  #6 org.sunflow.core.LightServer$1.run() LightServer.java:231
  #7 java.lang.Thread.run() Thread.java:844

Those have been detected by running the DaCapo Benchmark Suite 23.11-Chopin.

I second this. I've been working on a Java Multi-Version Execution and Record Replay tool called JMVX ( public git, paper )  and observed races here too during testing.
Additionally I think there is a chance to race on the builtTess field.
builtAccel and builtTess act as flags in part of a double check lock. The race on those fields can be eliminated by making the fields volatile. I imagine the same is true of the accel field, if the problem doesn't go away from fixing builtAccel. My testing was also done with the DaCapo Benchmark suite (version 23.11). Based on the code in master the issue should still be present.


Unable to open the rpoj

As I followed the tutorial on https://bookdown.org/yihui/bookdown/get-started.html, at step 3, I ran into error:

proj '~/bookdown-demo.Rproj' could not be opened: BuildType not correctly specified in project config file

I installed the latest rstudio to no avail.
I am running Rstudio on windows 10.

The problem is solved by upgrading to 0.99.1273. It turns out that I did not follow the tutorial to the letter.


Updated coupon

Coupon update

Thanks! Is this still the active coupon @DataCrunchIO ?

Thanks! Is this still the active coupon @DataCrunchIO ?

Yes it is :)

Yes it is :)

@jph00 this one is fine to merge then
On Wed, Jan 6, 2021 at 7:50 AM Ruben<EMAIL_ADDRESS>wrote:

Yes it is :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fastai/course-v3/pull/568#issuecomment-755281081, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3YCV2W42SKWXWXBKHKMDLSYRMAJANCNFSM4QUN6CVQ
.

@jph00 this one is fine to merge then
On Wed, Jan 6, 2021 at 7:50 AM Ruben<EMAIL_ADDRESS>wrote:

Yes it is :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fastai/course-v3/pull/568#issuecomment-755281081, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3YCV2W42SKWXWXBKHKMDLSYRMAJANCNFSM4QUN6CVQ
.


Laravel 11.x Compatibility

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:

Checkout the l11-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/receiver.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:
{
    "require": {
        "hotmeteor/receiver": "dev-l11-compatibility",
    }
}

Finally, run: composer update


Trying to open intellisense in an open file, while omnisharp is still loading causes "Ambiguity between ..." error

Environment data
dotnet --info output:
.NET Core SDK (reflecting any global.json):
Version:   2.2.103
Commit:    8edbc2570a
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.16299
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.2.103\
Host (useful for support):
Version: 2.2.1
Commit:  878dd11e62
.NET Core SDKs installed:
2.1.500 [C:\Program Files\dotnet\sdk]
2.1.502 [C:\Program Files\dotnet\sdk]
2.2.103 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
VS Code version: 1.32.3
C# Extension version: 1.17.1
Steps to reproduce

Open Visual Studio Code (with a big .sln, that takes some time to load)
Have a .cs file already open from last vscode start (should automatically open last open files)
Try to open intellisense while omnisharp is still building intellisense
Intellisense will show symbols from within the file shortly after
After omnisharp has finished parsing everything in the .sln, it now shows an  "Ambiguity between ..." error on every symbol in that file.

Expected  behavior
No  "Ambiguity between ..." errors
Actual behavior
"Ambiguity between ..." error on every symbol defined in that already open file
My analysis on the issue
After trying to figure out how this happens, I think I was able to narrow it down:
Omnisharp has an internal Queue of all the files to parse. When a user tries to open intellisense inside an already open file, while mnisharp is still parsing the files from the selected .sln and the open file is still in that "queue"  and not parsed yet, it priorizes the opened file so it parses it first ( to ensure that intellisense works with at least the symbols defined in that open file).
However, after "priority" parsing it, there is still an "old" entry in the queue from when omnisharp started parsing the .sln initially. This causes the file to be parsed twice in the end and  "Ambiguity between ..." errors appear

I think this should be fixed in the later versions of omnisharp. My guess is that we are adding the file as a miscellaneous file before the workspace has been completely initialized and the project also adds the file hence omnisharp thinks that there are two files hence the ambiguity error.
Could you try setting "omnisharp.path": "latest" and checking if the error still reproduces ?

@akshita31 had this happen yesterday to me with beta6 bits, for me it's super inconsistent/racey so never a reliable repro.

@akshita31 I don't think that adding a file as a misc file and a regular file would have the effect you describe. Misc files go into a separate project that isn't referenced by anything, so I don't think the compiler would find the same type declared twice in the same project.

@danroth27 just ran into this guy too today with beta6 bits.

@RononDex I can't reproduce this on the latest C# extension beta + latest omnisharp build. Do you have the option "omnisharp.enableMsBuildLoadProjectsOnDemand" set?

@NTaylorMullen Can you guys move to beta-10?

@NTaylorMullen, right, the razor thing. Can you set omnisharp.Path to 'latest'?

@NTaylorMullen, right, the razor thing. Can you set omnisharp.Path to 'latest'?

Will give it a shot and report back if I see issues.

Looks like this was a Razor tooling specific issue.

@rchande the omnisharp related settings in my vscode config:
    "omnisharp.disableMSBuildDiagnosticWarning": true,
    "omnisharp.maxFindSymbolsItems": 2000,

My omnisharp.json:
{
	"RoslynExtensionsOptions": {
    "LocationPaths": [
      "C:\\Roslynator"
    ],
	"EnableAnalyzersSupport": true
  },
  "FormattingOptions": {
    "NewLine": "\r\n",
    "UseTabs": false,
    "TabSize": 4,
    "IndentationSize": 4,
    "SpacingAfterMethodDeclarationName": false,
    "SpaceWithinMethodDeclarationParenthesis": false,
    "SpaceBetweenEmptyMethodDeclarationParentheses": false,
    "SpaceAfterMethodCallName": false,
    "SpaceWithinMethodCallParentheses": false,
    "SpaceBetweenEmptyMethodCallParentheses": false,
    "SpaceAfterControlFlowStatementKeyword": true,
    "SpaceWithinExpressionParentheses": false,
    "SpaceWithinCastParentheses": false,
    "SpaceWithinOtherParentheses": false,
    "SpaceAfterCast": false,
    "SpacesIgnoreAroundVariableDeclaration": false,
    "SpaceBeforeOpenSquareBracket": false,
    "SpaceBetweenEmptySquareBrackets": false,
    "SpaceWithinSquareBrackets": false,
    "SpaceAfterColonInBaseTypeDeclaration": true,
    "SpaceAfterComma": true,
    "SpaceAfterDot": false,
    "SpaceAfterSemicolonsInForStatement": true,
    "SpaceBeforeColonInBaseTypeDeclaration": true,
    "SpaceBeforeComma": false,
    "SpaceBeforeDot": false,
    "SpaceBeforeSemicolonsInForStatement": false,
    "SpacingAroundBinaryOperator": "single",
    "IndentBraces": false,
    "IndentBlock": true,
    "IndentSwitchSection": true,
    "IndentSwitchCaseSection": true,
    "LabelPositioning": "oneLess",
    "WrappingPreserveSingleLine": true,
    "WrappingKeepStatementsOnSingleLine": true,
    "NewLinesForBracesInTypes": true,
    "NewLinesForBracesInMethods": true,
    "NewLinesForBracesInProperties": true,
    "NewLinesForBracesInAccessors": true,
    "NewLinesForBracesInAnonymousMethods": true,
    "NewLinesForBracesInControlBlocks": true,
    "NewLinesForBracesInAnonymousTypes": true,
    "NewLinesForBracesInObjectCollectionArrayInitializers": true,
    "NewLinesForBracesInLambdaExpressionBody": true,
    "NewLineForElse": true,
    "NewLineForCatch": true,
    "NewLineForFinally": true,
    "NewLineForMembersInObjectInit": true,
    "NewLineForMembersInAnonymousTypes": true,
    "NewLineForClausesInQuery": true
  }
}

(I used to test the roslyn analysers build with it)

@akshita31 if I use "omnisharp.path": "latest"
I get the following output in vscode Omsniharp log:
Error occured in loading omnisharp from omnisharp.path
Could not start the server due to Error: 404

@rchande @akshita31 Just tried with the beta10 release, still got the same issue (occurred with git checkout, checking out another branch)

It's true that when you start typing document is added to the MiscFilesProject, but OmnisharpWorkspace.TryPromoteMiscellaneousDocumentsToProject will add that misc document to the first project that is loaded if they are path of the same folder tree. This is just a heuristic and it could as well be wrong, problem is that there is no recovery mechanism when another project comes with a real hard reference to that file.
Proper fix for this would be if documents created by OmnisharpWorkspace.TryPromoteMiscellaneousDocumentsToProject would be marked as transient in BufferManager, so server would know that they should be removed if a "real" parent shows up.

A lot has changed with O# project loading since this issue was opened. If you are still having problems, please open a new issue.


Fix lint CI

Fix lint issues introduced in https://github.com/pytorch/vision/pull/7536 which were uncaught because the CI was completely toasted at the time.

Thanks for the quick review.
Lint job is passing, merging


Selectpicker doesn't work with Angularjs

I'm trying to use the selectpicker with angularjs, but doesn't show properly the use of brackets in the value parameter and the option text.
Did someone else tried to use the selectpicker in angularjs with bootstrap?

i have been facing this problem. selectpicker not working with ng-modal. Any soluttion ?

Check out https://github.com/caseyjhol/ng-bootstrap-select

Hi there!
I know the post was made long time ago but I hope my solution will be a help for others.
I got another solution to the issue related.
What I did was first load my data from back-end using angularjs and inside the .success after my validation I wrote the following code:
angular.element(document).ready(function () { $('select').selectpicker("destroy"); $('select').selectpicker("render"); });
I tried to do it without angular.element(document).ready(function (){}) but nothing happend. I suppose the plugin's methods only works inside that function.
Happy Coding!!


Truncate inbox if no bytes were read.

Also:

Only allocate what's needed before reading from socket.
Return an error if the connection to the server was closed without us exiting.

See discussion here:
https://www.reddit.com/r/rust/comments/8z6yn8/livecoding_an_asynchronous_zookeeper_client/e2i48a6/

This looks good! I made the one comment about s/orig_len/instart/, but apart from that happy to merge! Have you had a chance to test it locally?
As for exited, I think that's probably a good idea, though as you point out it would cater to a pretty small window of error. Feel free to write something up if you want, and I'll take a look :)

Yes I've tested it locally and it passes.
About exited, I'll try to submit something when i have the time.

Great! Could you push a change to make it use instart, and then I'll merge? :)

See also #3.

And the test still passes locally?

Yes.
On Wed, Jul 18, 2018, 6:31 PM Jon Gjengset<EMAIL_ADDRESS>wrote:

And the test still passes locally?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jonhoo/tokio-zookeeper/pull/2#issuecomment-406012393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AncESIF40Ju1MArQLAtJYn3vtKAABVVSks5uH3EEgaJpZM4VT7B1
.

Thanks!


Set Hive write test to ignore order on verification.

Fixes #7703.
The Hive text write tests should ignore order when verifying the write output. If not, we might not get consistent reads between CPU and GPU, especially if the output splits between multiple files.

Build


Add an EthernetRepr type

I should be able to construct an ethernet frame using the Repr pattern, same as I can with IP packets.

Doesn't seem very useful other than for completeness.

It would be useful for me with the code I'm writing right now. I'll submit a PR for it.

@dlrobertson I think you had an implementation for EthernetRepr, if @canndrew hasn't written one yet, I can probably merge that one.


Victor VosMottor: Watch ==>>

Victor VosMottor requests the watch of the watch_keyword ==>>. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

==>> has been seen in 2328 true positives, 8 false positives, and 2 NAAs.

Rejected by Ryan M in Charcoal HQ. Reason: 'Of the 7 TP, the lowest weight is 287.  A search of SO suggests that it's common, though not necessarily at word boundaries.  This seems more like coincidence than a particular spam pattern.  We also have arrow-based rules, such as 'Link following arrow'.  Note: the GitHub comment is misleading due to searching without \b bookending.'


[Examples] moved installation examples into this repo

From our conversation this morning during the cocoa meeting. /cc @segiddins
Only the first of several steps defined here: https://github.com/realm/realm-cocoa-private/issues/73

Can we add a build.sh command to run the installation examples?

update "package-examples" in build.sh to remove examples/installation

Can we add a build.sh command to run the installation examples?

I don't think that's necessary... in any case, I've updated build.sh's "package-examples" job to ignore examples/installation

@segiddins could you review this again please?

:+1:


Fix connectivity issue in bare mental environment

Signed-off-by: xuezhaojun<EMAIL_ADDRESS>

/assign @elgnay
/cc @qiujian16

/cherry-pick release-2.5
/lgtm
/hold

/unhold


not enough values to unpack

Could you please tell me how to solve this problem?

Hi there, I met the same problem. Have u solve this problem : )

 Could you please tell me how to solve this problem?