Can't open file from path 'res://.godot/global_script_class_cache.cfg'.

Godot version
d33c1b50
System information
win 11
Issue description
If you build a XR project you get this output in
Can't open file from path 'res://.godot/global_script_class_cache.cfg'.
Steps to reproduce
create project with 3d node and xr-origin, xr-camera, xr-controller, enable xr in project settings and build for windows, then this output appears
Minimal reproduction project
create project with 3d node and xr-origin, xr-camera, xr-controller, enable xr in project settings and build for windows, then this output appears

By "Build for Windows" I assume you mean create an export for Windows Desktop, correct?
Because just from the description itself within the editor I haven't got an issue (aside from the shaders throwing
ERROR: Condition "variant_size == 0 && variants_enabled[i]" is true. Returning: false
   at: ShaderRD::_load_from_cache (servers\rendering\renderer_rd\shader_rd.cpp:410)
``` times 20 or so after activating XR)

Do these errors pop up on your side too?

ERROR: OpenXR: Unsupported io path /interaction_profiles/htc/vive_cosmos_controller/user/hand/left/input/system/click
at: (modules\openxr\openxr_api.cpp:264)
ERROR: OpenXR: Unsupported io path /interaction_profiles/htc/vive_focus3_controller/user/hand/left/input/system/click
at: (modules\openxr\openxr_api.cpp:264)
ERROR: OpenXR: Unsupported io path /interaction_profiles/htc/vive_focus3_controller/user/hand/right/input/trigger/touch
at: (modules\openxr\openxr_api.cpp:264)
ERROR: OpenXR: Unsupported io path /interaction_profiles/htc/vive_focus3_controller/user/hand/left/input/thumbrest/touch
at: (modules\openxr\openxr_api.cpp:264)

I'm compiling the debug export templates so it will take me a hot minute to confirm if your error is due to the "Export" part, I'll let you know what I can see from my side.

Hmm, I cannot confirm this issue, sadly - all I get is this:
C:\Users\kuhnc\Documents\Issue72284\export>export.exe

C:\Users\kuhnc\Documents\Issue72284\export>Godot Engine v4.0.beta.custom_build.218bef90a - https://godotengine.org
OpenXR: Running on OpenXR runtime:  SteamVR/OpenXR   0.1.0
OpenXR: XrGraphicsRequirementsVulkan2KHR:
 - minApiVersionSupported:  1.0.0
 - maxApiVersionSupported:  1.2.0
Vulkan API 1.3.224 - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce GTX 1650

ERROR: Couldn't find the given section "" and key "list", and no default was given.
   at: (core\io\config_file.cpp:87)
ERROR: Condition "active_sets.size() == 0" is true. Returning: false
   at: OpenXRAPI::sync_action_sets (modules\openxr\openxr_api.cpp:2535)
ERROR: Condition "active_sets.size() == 0" is true. Returning: false
   at: OpenXRAPI::sync_action_sets (modules\openxr\openxr_api.cpp:2535)
ERROR: Condition "active_sets.size() == 0" is true. Returning: false
   at: OpenXRAPI::sync_action_sets (modules\openxr\openxr_api.cpp:2535)
ERROR: Condition "active_sets.size() == 0" is true. Returning: false
   at: OpenXRAPI::sync_action_sets (modules\openxr\openxr_api.cpp:2535)
ERROR: Condition "active_sets.size() == 0" is true. Returning: false
   at: OpenXRAPI::sync_action_sets (modules\openxr\openxr_api.cpp:2535)
ERROR: Condition "active_sets.size() == 0" is true. Returning: false
   at: OpenXRAPI::sync_action_sets (modules\openxr\openxr_api.cpp:2535)
ERROR: Condition "active_sets.size() == 0" is true. Returning: false
   at: OpenXRAPI::sync_action_sets (modules\openxr\openxr_api.cpp:2535)

Could you please upload your project so I can check if it may have already been fixed on the latest master ?
Attached I added my minimal project for this: Issue72284-xr.zip

i downloaded beta-16,created new project, created a 3d-node, saved the scene, downloaded export templates, export windows-desktop (no xr enabled or anything) and export

Similar to https://github.com/godotengine/godot/issues/72451, should be fixed by https://github.com/godotengine/godot/pull/72452.

Duplicate of #72451


crash

Mod Name
sinytra connector
Mod Homepage
https://modrinth.com/mod/connector
Minecraft version
1.20.1
Describe the bug
minecraft crashes when launched with the sinytra connector mod. when I turn it off, everything is fine
Steps to reproduce

installing other mods
installing sinytra
minecraft crash
turn off mod and launch minecraft
...

Logs
https://gist.github.com/showyxxx/2003ade1c94490d12388fa248b3e9414

my mods:

I solved the problem on my own. incompatibility with optifine

closed

Iris isn't compatible with Connector
Use Ocules as an alternative


Selector refactoring

Refactoring part of an attempt to fix #qz-3679

@rintcius try merging in master to avoid the cache uploading timeouts, just merged #3571.

@alissapajer @nicflores still timeouts, now on downloading the cache - I have added travis_wait 30 to download calls as well (in this PR)

@rintcius can you PR the travis_wait commit to master? That way it can get in sooner for other PRs as well.

Need to start working on Mimir now. I wrote the current status in qz-3679.
I still would like to create a PR with just the refactoring part of this. I'll revert the change that I made to the 4th case of the pattern match, because I want to exclude any behaviour changes for now.
@jsantos17 @wemrysi are you ok with this?
As an aside, there are at least a couple of cases that return None with the meaning "unable to plan", but I still think that the current pattern match is inconsistent with it.

@rintcius sounds good. I'll look into your comment. Thanks for the write up!

@jsantos17 There's a bunch of different things:

make spec names consistent
add and use plan3_6 in planner specs
move Selector into selector package
improve the type defs in planner.selector
make rewriteRefs monadic (rewriteRefsM)
add some RenderTree constraints
deduplicate filterBuilder
swap args in functions like this:

  def processMapFuncExpr
    [T[_[_]]: BirecursiveT: ShowT, M[_]: Monad, EX[_]: Traverse, A]
    (funcHandler: AlgebraM[M, MapFunc[T, ?], Fix[EX]], staticHandler: StaticHandler[T, EX])
    (fm: FreeMapA[T, A])
    (recovery: A => Fix[EX])

I placed fm after recovery to make them more suitable for calling them point-free style.  I'll clean it up & open a new PR after we have agreed on the new names for CExpr

@rintcius sounds good. thanks for the explanation!

Superseded by https://github.com/quasar-analytics/quasar/pull/3599


delete the warning in the compilation by casting in (int)  warning: …

delete the warning in the compilation by casting in (int)  warning: …
…comparison between signed and unsigned integer expressions
just for delete a compilation message.
please just tell me if it;s not interesting.
My two cents....
Cheer

Oh nice, I shouldn't have let a compile warning get through.
I wonder if we should actually just switch frame_zero_padding to be an unsigned int, I don't think it has any valid semantic meaning if set negative.
@apetrynet What do you think?
Either way, this fix makes things better so we'd still be improving if we decided to merge as-is.

@zebulon75018 Thanks for the catch!
@reinecke All of the APIs in this cohort have an int as the frame number. If frame numbers must be >= 0, it makes sense to "repair" the API, and consequently the variables in the methods. If frame numbers can be negative, then a static_cast would be idiomatic in this diff, rather than a C style cast. I'm guessing, >= 0 is the answer, so what do you think about taking a quick pass over the API?

@reinecke I think frame_zero_padding quite safely could be set to unsigned int. A negative frame padding would imply not having a frame number at all which makes little sense in an image sequence :)
@meshula Negative frame numbers are used in some cases where the preroll of a simulation needs to go below frame zero for instance. So, even if not that common, frame numbers should support negative numbers.

If negative frame numbers are allowable, then the zero padding algorithm should do this ~
bool isNegative = frame < 0
frame = abs(frame)
zeroPad(amount - isNegative?1:0)
if (isNegative)
   prepend('-')

~ shouldn't it?

@meshula I'm sorry, but don't think I understand what your suggesting here.

The existing code, if zero padded to 4, will do this: 1 becomes 0001.  -1 becomes 00-1. I'm proposing that 1 should become -001.

Hmm. I'm unable to replicate that. I might of course be doing something strange here. @reinecke do you have any input?

I'll try to repro after ASWF OpenSource Days wraps later today

I was quite mistaken, sorry! When I was reviewing the code, every time I looked, I didn't spot that the image_num_string conversion has an abs in it. The logic does make sense for negative numbers :)

Great! Thanks for double-checking!
On Fri, Aug 21, 2020, 00:35 Nick Porcino<EMAIL_ADDRESS>wrote:

I was quite mistaken, sorry! When I was reviewing the code, every time I
looked, I didn't spot that the image_num_string conversion has an abs in
it. The logic does make sense for negative numbers :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PixarAnimationStudios/OpenTimelineIO/pull/774#issuecomment-677940790,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIW7YJ7HP6JUO54AXPCHELSBWQMLANCNFSM4QEH3LMQ
.

Yep, negative frame numbers are allowed and (I think) have good test coverage for the examples discussed: https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/887575ae1f9febe605bb9bd7889aa6e700112193/tests/test_image_sequence_reference.py#L552-L613
@meshula would you agree switching frame_zero_padding to be an unsigned int would be a good idea?
This would probably imply fixing up static_cast in other places. Also some additional error handling on deserialization (since al JSON ints are signed) here: https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/887575ae1f9febe605bb9bd7889aa6e700112193/src/opentimelineio/imageSequenceReference.cpp#L129
Just below that point in the code is a good example of how to bubble up deserialization errors: https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/887575ae1f9febe605bb9bd7889aa6e700112193/src/opentimelineio/imageSequenceReference.cpp#L148-L151
I think this would be, overall, a good update to the API and would prevent some potentially odd behavior.
@zebulon75018 Sorry to blow out the scope on what is supposed to be a simple compile warning fix, please let us know if doing all that is more than you'd want to take on.

Waou , I just want to give to the project my 2 cents ... :) , that's produced an interesting discution :).
I never imagine, but I hope that help you a little bit.

Codecov Report

Merging #774 into master will increase coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   83.21%   83.98%   +0.76%
==========================================
  Files          74       74
  Lines        2884     3122     +238
==========================================
+ Hits         2400     2622     +222
- Misses        484      500      +16

Flag
Coverage Δ

#py27
?

#py36
?

#py37
83.32% <ø> (+0.12%)
:arrow_up:

#unittests
84.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/opentimelineio/imageSequenceReference.cpp
92.10% <ø> (+0.67%)
:arrow_up:

...pentimelineio-bindings/otio_errorStatusHandler.cpp
62.26% <0.00%> (-6.97%)
:arrow_down:

...lineio/opentime-bindings/opentime_rationalTime.cpp
97.43% <0.00%> (-1.08%)
:arrow_down:

src/opentimelineio/serializableObject.cpp
57.97% <0.00%> (-0.86%)
:arrow_down:

src/opentime/timeRange.h
100.00% <0.00%> (ø)

src/opentime/errorStatus.h
100.00% <0.00%> (ø)

src/opentimelineio/gap.cpp
100.00% <0.00%> (ø)

src/opentimelineio/effect.cpp
100.00% <0.00%> (ø)

src/opentimelineio/marker.cpp
100.00% <0.00%> (ø)

src/opentimelineio/timeline.cpp
100.00% <0.00%> (ø)

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992b3c2...90fc31c. Read the comment docs.

@zebulon75018 Thank you for pointing this one out, you managed to find a little indicator of a bigger oversight I made.


during POST //api/v2/reimport-scan/   - OSError: write error

Be informative
while importing gitleaks json with 1000 findings , we are getting below error.
but its working json with 500 findings.
uwsgi_response_writev_headers_and_body_do(): Broken pipe [core/writer.c line 306] during POST //api/v2/reimport-scan/ (<IP_ADDRESS>)
OSError: write error

Bug description
while importing gitleaks json with 1000 findings , we are getting below error.
but its working with json with 500 findinsgs.
uwsgi_response_writev_headers_and_body_do(): Broken pipe [core/writer.c line 306] during POST //api/v2/reimport-scan/ (<IP_ADDRESS>)
OSError: write error

Expected behavior
A clear and concise description of what you expected to happen.
Deployment method (select with an X)

[ ] Kubernetes

Environment information

Operating System: [e.g. Ubuntu 18.04]
DefectDojo version v. 2.40.2

@roshvin Seems related to your configuration of DefectDojo - see #11424 for some things to check.


Failed to create multiple opensearch domain in one vpc

terraform apply
│ Error: creating Security Group (vpc-03b735cda1b80c124-elasticsearch): InvalidGroup.Duplicate: The security group 'vpc-03b735cda1b80c124-elasticsearch' already exists for VPC 'vpc-03b735cda1b80c124'
│       status code: 400, request id: 52842348-c664-4a74-a5d7-f854d0c26b66
│
│   with module.analytics-opensearch.aws_security_group.es[0],
│   on .terraform/modules/analytics-opensearch/main.tf line 31, in resource "aws_security_group" "es":
│   31: resource "aws_security_group" "es" {

config
module "opensearch-1" {
  source  = "cyberlabrs/opensearch/aws"
  version = "0.0.16"
  vpc = vpc-03b735cda1b80c124
}
module "opensearch-2" {
  source  = "cyberlabrs/opensearch/aws"
  version = "0.0.16"
  vpc = vpc-03b735cda1b80c124
}

Hello, there is new variable default_security_group_name which represents name of default security group. You can fix this problem using this variable and setting some other value than deafult.


fix: exit status for fixed results

Use the Remaining values instead of Found values so that exit status is correct when processing fixes.
Also output the full summary structure which provides useful information when we trigger the status 1.

Replaced by https://github.com/nvuillam/npm-groovy-lint/pull/313


add operation/monitor.md

Codecov Report

Merging #337 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #337      +/-   ##
===========================================
- Coverage    52.94%   52.93%   -0.01%
===========================================
  Files          244      244
  Lines        23027    23027
===========================================
- Hits         12191    12189       -2
- Misses        9430     9431       +1
- Partials      1406     1407       +1

Impacted Files
Coverage Δ

bfe_util/fixed_pool.go
83.33% <0.00%> (-16.67%)
:arrow_down:

bfe_spdy/server_conn.go
78.09% <0.00%> (-0.45%)
:arrow_down:

bfe_http2/server.go
71.50% <0.00%> (-0.17%)
:arrow_down:

bfe_spdy/frame_write.go
50.50% <0.00%> (+1.01%)
:arrow_up:

bfe_balance/bal_gslb/sub_cluster.go
55.55% <0.00%> (+7.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e47dd...a36423d. Read the comment docs.


Issues regarding force penalization

Hi, Alex! If we add the end effector force penalization function called PenalizeEndeffectorForces() to the objective function, the final output will be an unreasonable walking gait (Hyq) which contains some very large forces acting on the ground. Do you have any insight on that? Also, it seems the function MakeForcesCost() add the variable from EEForceNodes at derivative (kPos) & dimension (Z). Could you help to clarify this more? Why we need to use kPos derivative to get the force rather than kVel or kAcc?

Hi! I haven't played to much around with the first question, perhaps a cost that minimizes changes in forces, instead of actual force values is better?
For the second question, the enum "kPos" is named a bit suboptmal, yes. It's ued in this case as the zero-derivative (actual value of the forces), wheras kVel would refer to the first derivative (change in forces, slope of force profile).


Key rotation service fails to restart over a new deployment

Key rotation service fails to restart over deploying a new instances with missing env variable. Possibly the variable wasnt declared in vars.tf
Error : keyrotation.NewServer: missing key manager in server environment

/assign @whaught

/reopen

There is a duplicate resource naming "revision-token-aad" that is decalred in :
service_keyrotation.tf
service_exposure.tf
The exact error :
A google_secret_manager_secret_iam_member resource named "revision-token-aad" was already declared at service_exposure.tf:48,1-72. Resource names must be unique per type in each module.


WIP: transfers: require manual approvals when over limits

This PR adds an admin route for updating transfer statues. In two scenarios right now:

Current Status
Future Status

Reviewable
Canceled or Pending

Pending
Canceled

Issue: https://github.com/moov-io/paygate/issues/397

What's this Codacy bot? Did you add it @wadearnold ?

Codecov Report

Merging #409 into master will decrease coverage by 4.61%.
The diff coverage is 73.01%.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
- Coverage   62.98%   58.36%   -4.62%
==========================================
  Files          86       88       +2
  Lines        6105     6161      +56
==========================================
- Hits         3845     3596     -249
- Misses       1586     1928     +342
+ Partials      674      637      -37

Impacted Files
Coverage Δ

internal/depository/admin.go
100% <ø> (ø)
:arrow_up:

cmd/server/main.go
20.11% <0%> (-0.12%)
:arrow_down:

internal/route/route.go
78.72% <0%> (-11.53%)
:arrow_down:

internal/transfers/admin.go
100% <100%> (ø)

internal/transfers/limits.go
83.11% <100%> (ø)
:arrow_up:

internal/model/transfer.go
80% <100%> (ø)
:arrow_up:

internal/transfers/transfers.go
59.05% <60%> (+0.42%)
:arrow_up:

internal/transfers/approval.go
85.71% <85.71%> (ø)

internal/customers/client.go
11.42% <0%> (-70%)
:arrow_down:

internal/accounts/client.go
9.09% <0%> (-69.32%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0621309...3960062. Read the comment docs.


Update projects to use the latest beta client with zumo-api-version i…

…n the request

LoginTests.cs needs a complete rewrite.  We shouldn't be adding a new identity API, without reconciling with the authenticated table controller and the processes we are using to validate login in all our other e2etest client suites.

Can you elaborate on the auth table controller and "processes"?  I'm new to the e2e test codebase.

Look at the corresponding paradigm used for login tests in Node/.Net and other SDKS:
https://github.com/Azure/azure-mobile-apps-js-client/blob/master/e2etest/TestFramework/js/tests/loginTests.js
https://github.com/Azure/azure-mobile-apps-ios-client/blob/master/ZumoE2ETestApp/ZumoE2ETestApp/ZumoLoginTests.m
https://github.com/Azure/azure-mobile-services-test/blob/master/sdk/Android/ZumoE2ETestApp/src/com/microsoft/windowsazure/mobileservices/zumoe2etestapp/tests/LoginTests.java
https://github.com/Azure/azure-mobile-services-test/blob/master/Runtime/NodeE2EServerApp/Repo/service/table/authenticated.read.js
https://github.com/Azure/azure-mobile-apps-net-server/blob/master/e2etest/Controllers/Table/AuthenticatedController.cs

Oh and the original login test suite for managed: https://github.com/Azure/azure-mobile-services/blob/master/test/PLib/ZumoE2ETestApp/ZumoE2ETestApp/Tests/ZumoLoginTests.cs
Which was never brought over in the first pass due to not doing UI automation...  We should really bring this over into the core so we have login tests on all supported platforms that do login, and not alot of one offs/app type (Except for platform specific features)

thanks, I'll work on these.


docs(readme): convert readme to asciidoc

Was easy to convert with kramdoc https://matthewsetter.com/technical-documentation/asciidoc/convert-markdown-to-asciidoc-with-kramdoc/
Only needed minor adjustments after the conversion.


Dialog Support [New Feature]

I found there is bot can send dialog to me:

When click inline keyboard, it send me a dialog, is it new in telegram api? Dose telebot support this?

I found there is bot can send dialog to me:

When click inline keyboard, it send me a dialog, is it new in telegram api? Dose telebot support this?

This is Alert. Only for Callbacks. Example.
// ShowAlert sends a text response for the current callback query.
func (b *Bot) ShowAlert(c tele.Context, text string) error {
    resp := &tele.CallbackResponse{
        Text:      text,
        ShowAlert: true,
    }

    return c.Respond(resp)
}

thanks, it is awesome


DAI - GOOD/THANK-YOU  grouping adjustments (manual)

Please see attached.
GOOD_THANK-YOU.pdf

This is one of those that required post-processing, to correct an error in the Ashwin data set.  But currently this is what is appearing.   We should discuss, when higher priority items have been addressed :-).  THANKS!

Fixed

This fix (and perhaps others intended for post-processing) still needs to be made...
THANKS.
See the pdf linked in above for details.


HADOOP-17953. S3A: Tests to lookup global or per-bucket configuration for encryption algorithm (#3525)

Followup to S3-CSE work of HADOOP-13887
Contributed by Mehakmeet Singh

+1


route parameters can also be other things than string

fix #240

@greg0ire so this "fix" actually shows a problem. there is one test that we break with this change, which works with integer parameters. can it be that you misconfigured your menu item with a string instead of a number?

Not sure how I can check this, but I'm using the identifier of a doctrine entity, which is an integer.

If I re-read @stof comments, I think casting both sides to string would be the solution :

when the id comes from a query string parameter, it is always a string, and this is what the failing unit tests was written for
when the id comes from a default value, it can be an integer, and this is what a test should be written for.

I'm trying to simplify these tests before in #244

there is a discussion in Symfony currently to decide whether we should deprecate non-string default values. So I suggest waiting for the outcome of the discussion before breaking BC here (because changing it can break BC).

@stof do you know the outcome of the symfony discussion?

@stof do you know the outcome of the symfony discussion?

ping @stof

so should i rebase this PR? and should i go for a strict comparison but just remove casting to string?

Simple strict comparison is a no-go, as it would break things for people using $entity->getId() when building the menu (which will be an integer) to compare it against the matched id (which will be a string).
Loose comparison is a no-go due to WTF comparison for int vs string (casting to int is lossy).
so I would go with the option of casting the second side to string as well.

@dbu do you have an idea about when you will be able to finish this one ? I'm wondering whether I should wait for it to release 2.3 (I'd like to do it tomorrow), or let it be part of a later patch release.

i'll have to look into the build error. looks to me like the test is assuming the incorrect behaviour. but i have meetings now, might only get to it towards the evening.
should i also add a note to the changelog? its a bugfix but changes behaviour and people might have relied on this bug...

@dbu you might add a note in the changelog. Otherwise I'll do it myself before the release (many other PRs are missing the changelog entries, including mines)

updated the test, i think it should indeed change behaviour here. and added a changelog note. (i am not only anymore tonight, feel free to adjust this to your requirements if you want tweaks and want to release). given that this is a bugfix-behaviour-change, it would seem nicer to me to have it in a new minor version than in a patch release.


New config option request: specify what to inline, css or javascript

It will be handy to specify what exactly we should inline. Sometimes it's handy to inline just css and leave javascript to be loaded.
In my use case I build browser extension and it would be great to save a tiny loading time by not doing extra request to load stylesheets. In other hand those extensions prohibit inline scripts and I'd want to keep lazy loading too.
Even though for my use case I can find solutions, I believe it's logical for this plugin to configure what exactly we want to inline.

I've got projects where a feature like this would be nice. I think a glob pattern (or RegExp) specifying which files to include would solve this in a nice way.
The default behavior should still be to inline all JS and CSS, like the name of the plugin.
However, we could add an optional parameter inlinePattern which could be a glob pattern or RegExp that is tested against all asset file names (JS and CSS). If an asset matches the inlinePattern, it gets inlined.
Suggested library to test a string against a glob pattern: https://github.com/micromatch/micromatch

Please try 0.10.0-beta, I've added this option.

0.10.0 has been released.


Unable to install OXY2DEV/markview.nvim plugin

Describe the bug
Adding the plugin OXY2DEV/markview.nvim to ~/.config/nvim/lua/custom/plugins/init.lua or directly to ~/.config/nvim/init.lua doesn't seem to work, meaning it doesn't seem to be able to load it with lazy (even if changing the option in the configuration), nor let us use the :Markview toogle command.
That said, I'm very new to kickstart, so this is probably my fault.
To Reproduce

install fresh kickstart
modify  ~/.config/nvim/lua/custom/plugins/init.lua  to:

-- You can add your own plugins here or in other files in this directory!
--  I promise not to create any merge conflicts in this directory :)
--
-- See the kickstart.nvim README for more information

-----------------  NOTE: Mis plugins -----------------

-- NOTE: Markview.nvim
return {
  'OXY2DEV/markview.nvim',
  lazy = false,
  dependencies = {
    'nvim-treesitter/nvim-treesitter',
    'nvim-tree/nvim-web-devicons',
  },
  config = function()
    require('markview').setup {
      -- Configuración opcional
      modes = { 'n', 'i', 'no', 'c' },
      hybrid_modes = { 'n' },
      callbacks = {
        on_enable = function(_, win)
          vim.wo[win].conceallevel = 2
          vim.wo[win].concealcursor = 'c'
        end,
      },
    }
    vim.cmd 'Markview enableAll'
  end,
}

or add this to the main file (~/.config/nvim/init.lua):
-- NOTE: Here is where you install your plugins.
require('lazy').setup({
[…]

  {
    'OXY2DEV/markview.nvim',
    lazy = false, -- Recommended
    -- ft = "markdown" -- If you decide to lazy-load anyway

    dependencies = {
      -- You will not need this if you installed the
      -- parsers manually
      -- Or if the parsers are in your $RUNTIMEPATH
      'nvim-treesitter/nvim-treesitter',

      'nvim-tree/nvim-web-devicons',
    },
  },
})

Save and Sync+Install+Update Lazy
open a markdown file in a new session (like a new terminal)
Open Lazy to check if it's loaded or try to use :Markview
Cry :cry:

Desktop

OS: Arch Linux
Terminal: Kitty

Neovim Version

NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1723675123

Have you enabled this line in init.lua?
https://github.com/nvim-lua/kickstart.nvim/blob/a22976111e406ec0e4903ae78bf66a1fc0125b8a/init.lua#L930-L932

I tested with the steps you provided. In all cases, the plugin installs. Restart nvim, open the README, and the plugin is activated. The Markview command works.


Support theming of file icons

Would like to be able to theme icons to match my television theme :)

Would you have an example in mind of what that would look like in terms of configuration ?

See https://github.com/rachartier/tiny-devicons-auto-colors.nvim for one, you provide a palette of colors and I think it matches the provided devicons color to the closest color from the palette. The other way is have people manually associate certain extensions/globs to nerd font characters and colors, though that is much more difficult to implement on the theme creator side of things.


Mousebindings configuration error. Nothing loads.

Hi Gabriel,
I am running awesomewm on Fedora 36. I followed the steps in the install instructions, but when I login to awesome I get the following error message:
error while running function!
stack traceback:
/home/sharpe/.config/awesome/configuration/mousebindings.lua:5 in local 'set_mousebindings'
/home/sharpe/.config/awesome/configuration/mousebindings.lua:26: in main chunk
[C]: in function 'require'
/home/sharpe/.config/awesome/configuration/init.lua:3: in main chunk
[C]: in function 'require'
/home/sharpe/.config/awesome/rc.lua:8: in main chunk
error: /home/sharpe/.config/awesome/configuration/mousebindings.lua:5: attempt to call a nil value (field 'append_global_mousebindings')
Please let me know if you are aware of any fixes.
Thank you so much,
Adog64

Hello! That could happen if you don't install the awesomewm git version. How'd u installed awesome? Using dnf?

Yes, originally I installed from dnf. I reinstalled it from git, built, and installed it, but it doesn't show up as a WM option now from my lightdm greeter.

Sorry for late response :v
Create the file (with sudo) /usr/share/xsessions/awesome.desktop and put this inside:
[Desktop Entry]
Name=awesome
Comment=Spawn awesome
Exec=awesome
Type=Application

Then (completely) the lightdm service btw, and u'll be able to login using the awesomewm compiled with git

Closing due to inactivity, please, reopen this if necessary :)


Self update check should be off by default

Describe the bug
As mentioned here: https://github.com/gradle/gradle/issues/23564 it seems that this plugin is being ran in an environment where gradle.properties cannot be set. Therefore if the self update check was set to false by default, then nothing would run from this plugin when it shouldn't.
Setting default code is here: https://github.com/JetBrains/gradle-intellij-plugin/blob/master/src/main/kotlin/org/jetbrains/intellij/BuildFeature.kt#L11
side note:
If I am using "the latest version" and run the build, then a new version comes out, my next build will fail because I'm not on the latest version? isn't this another reason to have the default as false.
Expected behavior
The build should be reproducible and pass each time.
Environment:

macOS
Gradle IntelliJ Plugin Version 1.10.2
Gradle Version 7.6

Thanks for reporting, Paul.
This flag cannot be set to false by default, as its purpose is to educate plugin users about new version availability. The actual issue is that developers bump the IDE version they want to use, ensuring the plugin is also fresh.
Extracting this check as a separate task that will run first could help. WDYT?

Thanks! I don't have the best Gradle foo, but that sounds logical to me.
At the moment there is no way to configure plugins through flags/props when ran in the above 'synthetic root' project way. But if it was a separate task, perhaps the task can always be configurable? I am not sure myself tbh.

With dependabot and/or renovatebot I don't see a use case and I disabled the (annoying) check in my repos immediately.

@blundell Could you please try the 1.12.1-SNAPSHOT snapshot release?
@hfhbd If the update message annoys you, it just means you weren't using the latest version. :)

* What went wrong:
Configuration cache state could not be cached: field `__classPathFiles__` of task `:plugin:generateExternalPluginSpecBuilders` of type `org.gradle.kotlin.dsl.provider.plugins.precompiled.tasks.GenerateExternalPluginSpecBuilders`: error writing value of type 'org.gradle.api.internal.file.collections.DefaultConfigurableFileCollection'
> Could not resolve all files for configuration ':plugin:compileClasspath'.
   > Could not find org.jetbrains.intellij.plugins:gradle-intellij-plugin:1.12.1-SNAPSHOT.
     Searched in the following locations:
       - file:/Users/pblundell/.m2/repository/org/jetbrains/intellij/plugins/gradle-intellij-plugin/1.12.1-SNAPSHOT/maven-metadata.xml
       - file:/Users/pblundell/.m2/repository/org/jetbrains/intellij/plugins/gradle-intellij-plugin/1.12.1-SNAPSHOT/gradle-intellij-plugin-1.12.1-SNAPSHOT.pom
       - https://oss.sonatype.org/content/repositories/snapshots/org/jetbrains/intellij/plugins/gradle-intellij-plugin/1.12.1-SNAPSHOT/maven-metadata.xml
       - https://oss.sonatype.org/content/repositories/snapshots/org/jetbrains/intellij/plugins/gradle-intellij-plugin/1.12.1-SNAPSHOT/gradle-intellij-plugin-1.12.1-SNAPSHOT.pom
       - https://plugins.gradle.org/m2/org/jetbrains/intellij/plugins/gradle-intellij-plugin/1.12.1-SNAPSHOT/maven-metadata.xml
       - https://plugins.gradle.org/m2/org/jetbrains/intellij/plugins/gradle-intellij-plugin/1.12.1-SNAPSHOT/gradle-intellij-plugin-1.12.1-SNAPSHOT.pom
     Required by:
         project :plugin

Closing as the issue is resolved — will be published with the upcoming release.
FTR, since 1.12.3-SNAPSHOT, the plugin is available as org.jetbrains.intellij.plugins:gradle-intellij-plugin:1.12.3-SNAPSHOT (plugin marker is also published to make proper redirections).


.d.ts file is not a module when used from the language service

Test files
tsconfig.json:
{
    "compilerOptions": {
        "target": "es5",
        "module": "commonjs",
        "moduleResolution": "node",
        "declaration": false,
        "noImplicitAny": false,
        "removeComments": false,
        "noLib": false
    },
    "compileOnSave": true,
    "filesGlob": [
        "./**/*.ts"
    ],
    "files": [
        "main.ts",
        "test/index.ts"
    ],
    "exclude": []
}

main.ts:
import {Test} from "./test";

let t = new Test();

test/index.ts:
export class Test {

}

Error details
Code compiles fine from command line. Errors in IDE test.d.ts is not a module.
Refs https://github.com/TypeStrong/atom-typescript/issues/664

@vladima  any ideas?

Is there any workaround for this?

@basarat do you know what files are passed to the language service?

do you know what files are passed to the language service?

Good call. I see test.d.ts:

Don't know where its coming from. I'll investigate tonight and get back to you if this is not because of my code :rose:

Fixed : https://github.com/TypeStrong/atom-typescript/releases/tag/v7.9.0 :rose:


fix-11739: apply continuity line trail for effectline

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

Apply continuity line trail for effectline, currently enable for 'line', 'rect', 'roundRect' symbolType
Fixed issues
https://github.com/apache/incubator-echarts/issues/11739

Details
Before: What was the problem?

Effect line breaks when zooming in or at low-end device, since symbol is rendered at discrete position

After: How is it fixed in this PR?

Applying scaled symbol to fill the gap between last position and current one

Usage
Are there any API changes?

[ ] The API has been changed.

only enable continuity trail for 'line', 'rect', 'roundRect' symbolType
Related test cases or examples to use the new APIs
test/geo-lines.html
Others
Merging options

[ ] Please squash the commits into a single one when merge.

Other information

I can see there is a remarkable visual improvement. Good job!

Requested revision is done, please help review the new commit if available @pissang , thanks ~


Bugfix related to lexical probability features + correct exit code on…

… failure + use number of reducers from hadoop, when set.
Details:
TrieLexprobTable consumes the output of WordLexprobJob. It expects the output to be sorted in order to use binary search later. So far this was not an issue as the default setting for the number of reducers is 1, which led to a sorted output. If the number of reducers is increased this fails however, as each reducer output is sorted, but the parts combined are not. The solution is to partition the output of WordLexprobJob so that the sorted parts combined are sorted too.

Thanks a ton for posting this! I'll get to it soon and run it through my tests.

No problem. Let me know if there are any issues with the tests.

Okay, this seems to check out, from my cursory tests. Can I ask you to comment on what kind of tests you ran? (e.g., what kinds of grammars, what language pairs, and how big of a parallel text?)

I'm having some trouble with this when running Thrax in paraphrase
extraction mode, actually. Investigating, but any thoughts would be
appreciated:
Exception running child : java.lang.RuntimeException: Failed loading
TrieLexprobTable. Entries must be sorted ascendingly, but cars[11244]=27825

cars[11245]=27809
at
edu.jhu.thrax.lexprob.TrieLexprobTable.checkIntegrity(TrieLexprobTable.java:71)

at
edu.jhu.thrax.lexprob.TrieLexprobTable.initialize(TrieLexprobTable.java:63)
at edu.jhu.thrax.lexprob.TrieLexprobTable.(TrieLexprobTable.java:23)
at
edu.jhu.thrax.hadoop.features.annotation.SourceGivenTargetLexicalProbabilityFeature.init(SourceGivenTargetLexicalProbabilityFeature.java:43)
at
edu.jhu.thrax.hadoop.paraphrasing.PivotingReducer.setup(PivotingReducer.java:80)
at org.apache.hadoop.mapreduce.Reducer.run(Reducer.java:168)
at org.apache.hadoop.mapred.ReduceTask.runNewReducer(ReduceTask.java:627)
at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:389)
at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:163)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1628)
at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
On Wed, Dec 23, 2015 at 1:32 PM Matt Post<EMAIL_ADDRESS>wrote:

Merged #8 https://github.com/joshua-decoder/thrax/pull/8.
—
Reply to this email directly or view it on GitHub
https://github.com/joshua-decoder/thrax/pull/8#event-499782375.

Juri, can you post the thrax.conf you used for this?


exit show_help() properly

Hi,
The command mkjail getrelease -h outputs the help 2 times in a row.
That's because of a missing exit 0 at the end of the function called show_help().
Thank you.

Looks OK to me, @feld wrote the help, so I ask for his input.


Incorrect recognition of RANGE in CREATE TABLE statement

CREATE TABLE foo (
    name character varying(255),
    range character varying(255),
    start_range integer,
    end_range integer
);

Yields to
Encountered " "RANGE" "range "" at line 3, column 5.
Was expecting one of:
    "KEY" ...
    "INDEX" ...
    "FOREIGN" ...
    "CONSTRAINT" ...
    <S_IDENTIFIER> ...
    <S_QUOTED_IDENTIFIER> ...
    "CONSTRAINT" ...

Similarly it recognizes KEY in the create table statement:
CREATE TABLE bar (
    key character varying(255) NOT NULL
);

"KEY" is a reserved word in SQL-92 and SQL:1999, "RANGE" is a reserved word in SQL:2003. So the recognition is correct depending on the SQL version :)

Yeah, they are reserved in the particular standard but JSQLParser supports also non-standard operations.
According to http://www.postgresql.org/docs/9.4/static/sql-keywords-appendix.html

Keyword
PostgreSQL
SQL:2011
SQL:2008
SQL-92

KEY
non-reserved
non-reserved
non-reserved
reserved

RANGE
non-reserved
reserved
reserved

So I would say JSQLParser should recognize this correctly ;)


Update ttf2woff2 to v2 for node v4+ support

Recently there was an update in ttf2woff2 to support the new node versions.
https://github.com/nfroidure/ttf2woff2/issues/15
When installing grunt-webfont in node 5 there are some errors.
3 errors generated.
make: *** [Release/obj.target/addon/csrc/addon.o] Error 1
Error: make failed with exit code: 2

Yeah and I'm getting antivirus errors because of ttf2woff2 so this urgent for me (i.e. I'm dumping it from my project if I have to whitelist it on everyone's machine).
+1!

Same here. Can't finish the installation. +1

A patch is available solving the node 4+ issue. It could also solve the AVG antivirus issue.

https://github.com/sapegin/grunt-webfont/releases/tag/1.0.2


feedback

a great effort bears a tangible result. testnet is perfect and running as expected, I really hope this project can provide positive things for the community when launch day arrives. I can't wait for it!

@SukmaApriyadi Thank you for your testing and we hope to continue delivering high quality features and improvements!


Failed to capture frame in UE4.25 without error message

Description
When I enabled RenderDocPlugin in UE4.25 and pressed the button
 to capture the next frame, the RenderDoc was automatically launched but I could not inspect the frame.
The Diagnostic Log was like this:

Steps to reproduce

install RenderDoc v1.8
open any project in UE4.25
open Plugins Browser and enable RenderDocPlugin
Restart UE4.25 project and  pressed the renderdoc button

Environment
RenderDoc version: v1.8
Operating System: Windows 10
Graphics API: D3D11
ps: I used RenderDoc v1.8 because UE4.25 crashed when using RenderDoc v1.10.

Can you please re-test this with the latest nightly build? I understand that v1.10 doesn't work but there are many bugs that have been fixed since v1.8.

Can you please re-test this with the latest nightly build? I understand that v1.10 doesn't work but there are many bugs that have been fixed since v1.8.

I re-tested it with the latest nightly build, but it still failed to capture the frame.

Can you please re-test this with the latest nightly build? I understand that v1.10 doesn't work but there are many bugs that have been fixed since v1.8.

I re-tested it with the latest nightly build, but it still failed to capture the frame.

Posting a screenshot of a log file is the worst way to convey text, in future you should save the log to disk and upload it as an attachment.
That log also doesn't show anything, all it shows is that RenderDoc has been started and has connected to the UE4 editor process. What happens if you trigger a capture after this point? Or alternatively launch the UE4 editor from renderdoc instead of using the plugin, so that the log contains all information including any capture made prior to RenderDoc connecting.

Posting a screenshot of a log file is the worst way to convey text, in future you should save the log to disk and upload it as an attachment.
That log also doesn't show anything, all it shows is that RenderDoc has been started and has connected to the UE4 editor process. What happens if you trigger a capture after this point? Or alternatively launch the UE4 editor from renderdoc instead of using the plugin, so that the log contains all information including any capture made prior to RenderDoc connecting.

In fact that's all the log information.  I tried connecting to UE4 editor from renderdoc and pressed the button 'Capture Frames Immediately'.

but there was nothing new in the log file.
log11-4.log

The screenshots shows that the capture has started but not completed. Is the editor still rendering and presenting?
Please run the editor through RenderDoc instead of allowing the plugin integration to load RenderDoc, and post the log from that run. That will include the logging information from the capture process itself.

The screenshots shows that the capture has started but not completed. Is the editor still rendering and presenting?
Please run the editor through RenderDoc instead of allowing the plugin integration to load RenderDoc, and post the log from that run. That will include the logging information from the capture process itself.

Thank you for your help! I found a way to successfully capture frames in UE4 editor.

Open any project with RenderDocPlugin enabled in UE4.25.
Run qrenderdoc.exe，choose 'File' - 'Inject into Process', find UE4 editor and Inject.
Press the renderdoc button in UE4 editor. Do not press the button 'Capture Frames Immediately' in renderdoc otherwise you'll get the entire editor interface.


Write EXT-X-DEFINE tags to media playlist as well

As per https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-<IP_ADDRESS>
#EXT-X-DEFINE can be used in media playlists as well

Thanks a lot! 👯


should this work?

Is this a bug or am I not understanding how routing works?
I have
polka()
  .use(init)
  .get('/', list)
  .use('/:id', findById)
  .get('/:id', single)
  .all('/:id', all)

For this route
localhost/abc
expect
init, findById, single, all
actual
init, single

assume: all functions are calling next for this demo

I know i can write:
.get('/:id', findById, single) // that works

Hey,
In current stable release, it doesn't. However, in the polka@next release (the 1.0 candidate) it works as you expect.
My recommendation is that new applications should be using @next release. It's been heavily used and tested. I'm just finishing the rest of the supporting packages for 1.0 to finish.
Hope that helps!

Thanks. I’ll update.


Deb version 0.17.2 doesn't contain the binary on bintray

Problem statement
Follow-up from https://github.com/go-swagger/go-swagger/issues/1760#issuecomment-434374229
The newest package 0.17.2 at https://dl.bintray.com/go-swagger/goswagger-debian/ doesn't contain the binary and the package size is much smaller than it should be.
/var/cache/apt/archives# ls -lah swagger_*
-rw-r--r-- 1 root root  996 окт 25 05:04 swagger_0.17.2_amd64.deb
-rw-r--r-- 1 root root 5,2M окт  7 06:34 swagger_v0.17.0_amd64.deb

Environment
swagger version: 0.17.2
OS: Ubuntu 18.04

I've uploaded a new deb package and verified I can install it


discussion - add demo link into document

Hi @jeffposnick,
I have made a demo about progressive web app using this repository and I would like to share. Does PR welcome?
Here is a repo: https://github.com/nndung179/create-react-pwa-demo

Great Demo Dung.
I was also able to develop a progressive web app react, redux mortgage calculator thanks to create-react-pwa.
https://github.com/edouardbrasier/React-Redux-Mortgage-Calculator


Update osx sign

The new version solves a number of bugs where dylibs are not all signed

I'm not sure we want to depend on a beta version of electron-osx-sign.
CC: @sethlu

I know what you mean, but its the only version that actually does the job

You could always sign manually, as described here: http://electron.atom.io/docs/v0.36.8/tutorial/mac-app-store-submission-guide/#sign-your-app

Additionally, according to Travis, upgrading to this version breaks compatibility with Node 0.12.

Its true I could sign seperately, but the point was that this tool tries to solve the whole process, and currently it doesnt because its using an old version of electron-osx-sign that is broken.
I hadn't see that it break Node 0.12 compatibility, my old comment would be that for a build tool that is unlikely to be a problem, its not like people are trying to deploy to 'stable' server environment, I doubt its a problem for any build environments to use a more up to date version of Node.

You'd be surprised how infrequently build servers get updated (unless there's a security fix required).

I would have thought anyone using electron, which has only been around for a short time, is using a relatively new server.
Also, if electron-packager is unable to sign an app, you still have to use electron-osx-sign so the newer node dependancy still remains.

My point in mentioning it was to get @sethlu's comment.

@malept I'll be releasing electron-osx-sign v3.0 later today after adding the signing with entitlements for darwin builds with default entitlements file following @jasonhinkle's comment on https://github.com/electron-userland/electron-osx-sign/issues/15 yesterday, and some extra manual tests. The only limitation with the current beta is that some binaries are not detected. This should be resolved with the release that'll be out very soon.

@mcfedr please update with new non-beta version of electron-osx-sign (which also fixes the Node version problem I mentioned).

Looks good. Please squash the commits (per the pull request instructions) and I'll merge.


Update image without redraw

Hi,
I'm trying to find a way to adjust brightness and contrast of an image, using sliders on Flutter. I tested with the library image and with that. Both works well, but needs to redraw or rebuild the screen on each change. Would be possible make changes in the image without rebuild the image on screen? In a way that's transparent for the user, i mean.

I did that on the letspicture app, have you seen that?
https://github.com/renancaraujo/letspicture

Closing due to inactivity


Feature: Markdown Linter

This PR integrates the markdown linter found here.  It has several rules that can be configured based on our needs and how much we want to follow some of the markdown best practices they have rules around.  This is one solution around https://github.com/m-lab/m-lab.github.io/issues/75.
Please note, we should carefully consider adding this linter.  I don't want to create extra burden on authors trying to meet these markdown linting rules, but if the team feels it would be beneficial, then I think it's a good decision.  We can remove it if folks think it is too burdensome.  If the only goal is to prevent whitespace, then I have also put together a pre-commit git hook that can run locally as well as in Travis that may work better.  We could also configure this linter to ONLY fail if whitespace is found if desired.
Regardless if the linter is something we want, I think we could still work in this PR with some of the markdown fixes that were made.  We could just take out the linter if it is NOT wanted.
Finally if this linter is implemented, we will also need to run this on the new-data-docs branch eventually.  This PR was branched off of master, so doing the PR against that branch.
In order to implement this solution, the following actions were taken:

[x] Updated the Gemfile to include the markdown linter gem

[x] Setup a markdown linter configuration that disables and customizes a few rules to best work for our purposes in _test/markdown-linter-style.rb.  Also updated Travis to be able to run the linter on the README file, the _posts directory, and the _pages directory.  These 3 commands could be simplified down to 1 command to work on the whole project, however, it did find issues in the submodule's README.  If we updated the submodule's README to pass the linting rules then we can change these commands.

[x] Once the linter was in place, I also fixed a number of issues that it found in several markdown files.  These fixes included lots of whitespace at the ends of lines, removal of several consecutive bland lines, extra spaces when defining list items, one occurrence of an incorrect HR rule being defined, and actually it caught an unneeded div in the ndt tool page.

Here is what the linter errors look like either in Travis or the same can be done locally:

This change is

One request for comment clarification but LGTM


RDKit cannot create mol from its own canonicalized SMILES

The following code...
mol = Chem.MolFromSmiles('c1c[C+]1')
smi = Chem.MolToSmiles(mol)
print 'smi=', smi
Chem.MolFromSmiles(smi)

... produces the following output (in Jupyter):
smi= [c+]1cc1
RDKit ERROR: [11:35:51] Can't kekulize mol
RDKit ERROR:

The same error occurs if "allBondsExplicit = True" is passed to MolToSmiles, though of course in that case the "smi" printed differs accordingly.
The mol produced is correctly depicted in Jupyter, including dotted aromatic bonds, if SVG is used.
Thus, in summary, RDKit can create the mol from some particular valid SMILES, but it cannot parse its own canonicalized SMILES to create a mol.

Peter-
I can reproduce this. I think that you just aren't seeing the warning/error in Jupyter, it gets printed to the server's console. (https://github.com/rdkit/rdkit/blob/master/Code/GraphMol/Kekulize.cpp#L471)

Hi, Dan,
So you found another bug. ;-) They say "What happens in Vegas stays in Vegas." I think the same should be true on Jupyter....
Thanks for this. The console is where my mol.Debug() output was going, too; but for some reason, I never thought of looking there. I know that Greg recently fixed the Debug() destination. Hopefully this will follow.
Of course, I also look forward to a fix for the matching issue....
Thanks again,
-P.

If you do from rdkit.Chem.Draw import IPythonConsole you should be able to see this output.

FYI, Dan,
Indeed, if I do from rdkit.Chem.Draw import IPythonConsole, I do see the error message in Jupyter.
Thanks again,
-P.

Any updates on this issue? I can provide more examples, like C1ccc(C(=O)CN2C(=O)NC@(c3ccc(Cl)cc3)C2=O)c(C)o1C

Same here! Any updates?

Did you try Dan W.'s solution, posted Oct 28, 2016?
-P.
On Mon, Sep 28, 2020 at 4:46 AM Artem Likhvar<EMAIL_ADDRESS>wrote:

Same here! Any updates?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/1092#issuecomment-699870610, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAX6LLYUOERLI4FFIJQAMXLSIBEPNANCNFSM4CSPEMNQ
.

@shenkin I think the solution you are referring to is to display warnings in jupyter notebook. However, the problem is that rdkit cannot parse some of the canonical smiles that were generated by itself. @likhvar we just get used to it and write code that accounts such peculiarity.


Make better / more flexible format for warnings

Since the very first version of HARK, we've had a "monkey patch" to the warnings module to make warnings display in a single line, rather than a big angry chunk of red text (in Spyder).  Some recent changes to numpy have increased the number of warnings it throws, for things like dividing by zero or using NaNs basically anywhere.    I would like to turn off these warnings where we know that they're not relevant (because dividing by zero or carrying around some NaNs is our intended functionality), but our current warning format gives no opportunity for traceback.
Our monkey patch needs to evolve into a human patch, roughly speaking.  The definition in HARKutilities should be greatly expanded to offer easy options.  I'm not sure what's possible, but ideally I would like the option to:

Turn off all warnings, period
Nicely display the file and line number that generates the warning
Display the warning with an N-level traceback.
Pause execution until keyboard input when encountering a warning.

I'm assigning this to Nathan because he wrote the initial warnings patch and knows the most about this.

See discussion in #283
There is a standard and flexible logging package in Python.
https://docs.python.org/3/howto/logging.html#logging-basic-tutorial
I highly recommend using this standard functionality instead of creating new logging functionality.

Responding to this, which may have been meant for this issue:
https://github.com/econ-ark/HARK/issues/283#issuecomment-597810736
The warnings controls in Python are managed through this package:
https://docs.python.org/3/library/warnings.html

I think we are using the Python logging library now. So maybe it's a good time to revisit this?

Already implemented for ConsIndShockModel, to be extended across HARK.

I think this was handled long ago. Warnings about intended HARK behavior are suppressed.


Add TransactionView::summary() method

Is your feature request related to a problem? Please describe.
There are many applications where it would be useful to display a summary of a transaction's effects on the balances of various accounts, both pre- and post-confirmation:

Pre-confirmation: in an approval dialog, for showing an exact preview of the effects of a transaction
Post-confirmation: in a frontend, for showing a summary of what a transaction did

This logic should be implemented once, in the Rust code, so that it can be standardized across the Penumbra ecosystem.
Describe the solution you'd like

[x] The Balance struct improperly has a derived Serde representation. This is a bug and a violation of our serialization policy. Verify that this was never used. Define a Protobuf message for the Balance struct and use that as the serialization format.

[x] Define a new Protobuf message and corresponding domain type, penumbra.core.transaction.v1.TransactionSummary, something like (sketch):

message TransactionSummary {
    message Effects {
        core.keys.v1.AddressView address = 1;
        core.asset.v1.Balance balance = 2;
    }
    repeated Effects effects = 1;
}

[x] Define a new method TransactionView::summary(&self) -> TransactionSummary that produces a TransactionSummary, iterating through each visible action and collecting the effects of the transaction. This should preserve the info available in the AddressViews about the meaning of the addresses.

This was done for Output/Spend/Swap/SwapClaim views in #4943. Adding the LP ones might enable some cool use cases, but afaict this is complete.


added missing cmp_opts to Riviera compilation options

Hey!
In this pull request I added missing cmp_opts to Riviera compilation options

Looks sensible to me. @udinator, can you take a quick look?


Error in console

Uncaught (in promise) TypeError: Cannot destructure property 'action' of 'usedActions' as it is undefined.
at Function.actionDialog (dnd5e-helpers.js:2279)
at HTMLDivElement. (dnd5e-helpers.js:2273)
at HTMLDivElement.dispatch (jquery.min.js:2)
at HTMLDivElement.v.handle (jquery.min.js:2)

Can we get a bit more information on what you were doing when this error occurred?

I blame kandashi he said to just post it, give me some time I'm not at home illl try to reproduce

sorry, i just asked Tryeal to throw this up and then promptly forgot about it,

Will need a refresh of this issue if it still exists. Please test again in 2.0.6.


Holocards and related functionality

About the PR

Added holocards, small icons that can be applied to people by medics doing triage
Fixes #2172
Technical details

The Holocard status component is a networked component that tells the client which icon to show when a viewer is using a medical hud
The Holocard scanner component is a component attached to medical huds that allow medically trained individuals to examine a person and change the holocard on them
The health analyzer BUI has been changed to include a holocard change button and a holocard description. The holocard change button is disabed for non-medically trained individuals
Media

https://github.com/CM-14/CM-14/assets/89804215/a6f3aae8-e7ad-4eb9-a0d1-8e5c58b85cca

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: blueDev2

add: Added Holocards

Yeah I just copied the meta file, I'll credit myself but um, should I just put it under my name or make a link to the applicable commit?

Yeah you can just use yourself as the source, link is not needed. Also applies for the two other images you made. You also get full credit for these images when someone uses our code to make a new server! That's why all assets need the copyrights text

Added spacing

Yeah I just copied the meta file, I'll credit myself but um, should I just put it under my name or make a link to the applicable commit?

Yeah you can just use yourself as the source, link is not needed. Also applies for the two other images you made. You also get full credit for these images when someone uses our code to make a new server, that's why all assets need the copyrights text (We also cannot use assets with no license)

Sorry, 2 other images? I think I only made 2 images, the ambulance and the holocard icons.

Also, is there any way for me to get the contributor role on the discord?

Sorry, 2 other images? I think I only made 2 images, the ambulance and the holocard icons.

I mean those yes sorry for confusion.

Also, is there any way for me to get the contributor role on the discord?
Ping in general, smug will review the ui code when she gets the time.


Bundling with Rollup fails due to missing export

Hello,
i'm trying to bundle my project using redux-saga and stumbled upon an issue.
using the node-resolve plugin for rollup and the { jsnext: true } option gives me the following error:
'CHANNEL_END' is not exported by '$PATH_TO_PROJECT$\node_modules\redux-saga\es\internal\io.js' (imported by '$PATH_TO_PROJECT$\node_modules\redux-saga\es\utils.js') Error: 'CHANNEL_END' is not exported by '$PATH_TO_PROJECT$\node_modules\redux-saga\es\internal\io.js' (imported by '$PATH_TO_PROJECT$\node_modules\redux-saga\es\utils.js')     at Module.traceExport ($PATH_TO_PROJECT$\node_modules\rollup\src\Module.js:376:17)     ...
Looking at the es/internal/io.js module there is no export for this but the es/utils.js re-exports this constant.
es/utils.js
export { CHANNEL_END, asEffect } from './internal/io';
Setting the { jsnext: false } option solves the issue as a workaround but also disables all other es6 imports.
Did I miss something or is this a small bug?
Thanks in advance.

That's probably a bug, PR is on the way. Fix should be published in a following week, but till this time I would advice to use a forked repo (from the tag you are using right now) with the fix included. Sorry for the problem.
I would appreciate also if you can let us know if this fix helps you.

Thank you. The fix in your PR works as intended.
Aside from this i've got an issue importing effects as stated in the documentation when using the jsnext flag.
I had to change this:
import { call, put } from "redux-saga/effects";
to this:
import { call, put } from "redux-saga/es/effects";
At least i did not find this in documentation but is this the way it should be?

Unfortunately, I'm not familiar how Rollup bundling works and what should jsnext method do. Could you try to explain those a little?
Would you compare our distribution system with some other libs which are bundled with webpack and do not cause you any problems? Then we could start from this comparison and workout the solution.

from what I see we have appropriate entry in our package.json, just in other order, but that shouldnt be a problem
  "main": "lib/index.js",
  "jsnext:main": "es/index.js",

Ill wait for the comparison, as it might be really helpful in tackling this.

I've had a look around my currently used packages and I cannot find another usecase like this. But the more i think about this i think this is more or less related to the node-resolve plugin.
You cannot put both files (es5 & 6) within the same folder therefore the bundler plugin should respect the subfolder defined in the "jsnext:main" node. But it currently does not as you can see here:
https://github.com/rollup/rollup-plugin-node-resolve/blob/master/src/index.js#L47
I do not know if it is a common practice to have submodules like the effects in the same folder because or re-export it as a named export. But if it is then this should be handled by the bundler.
Maybe I should open an issue over there.

could you create a test repo for me so I could play a little bit with the settings? would appreciate for instructions how to reproduce too

Does this one help?
https://github.com/zech/rollup-redux-saga

cool, thanks for those, gonna play around with it some time later!

Ok, I think I know why this happens, but aint sure how it should be solved.

redux-saga/effects is interpreted as node_module, so its traversing the directory tree and searches for that using this
https://github.com/substack/node-resolve/blob/7f0ce871b6d2b5cb2082b04cd72ddd4055cb7a05/lib/async.js#L172
its checking always if the found thing is a dir or file and act accordingly
it finds this https://github.com/yelouafi/redux-saga/blob/250e722419f9fcaade729c51aaf5d97a3de2b16a/effects.js and loads accordingly which in your case unfortunately points at the wrong file (from the lib) folder

In case of redux-saga itself it finds a correct directory and rollup later concatanates path with jsnext:main option. But its not working with effects.js for quite obvious reasons.
Ill try to reach out to rollup users so it can be handled in a better way.
@yelouafi
I've always wondered about dir structure in the repo, could you elaborate a little bit more on it? Ive always assumed that webpack when importing redux-saga/effects is reaching for ./lib/effects.js but it might seem (didnt check it though) that its reaching for ./effects.js and this only acts as a 'proxy' to the beforementioned file. Its kinda non obvious at first and Im wondering if maybe it could be somehow organised better as this 'proxy' seems a little bit hacky

see https://github.com/yelouafi/redux-saga/issues/70#issuecomment-182545609

Hm, so the solution would be to access a jsnext setting somehow and require this conditionally. Kinda clunky and aint sure if possible yet. Gonna search for possibilities later.
@zech
For the time being I would use effects like this, until the issue is resolved better.
import { delay, effects } from 'redux-saga'
const { call } = effects

function* saga() {
  yield call(delay, 1000)
}

Thanks,
currently i'm using
import { effects } from "redux-saga/es/effects";
I don't know if this is better or not. At least it works.

its more tied to the internal directory structure (which rather wont change ;) but still)
However as both are working, feel free to use whichever is more convenient for you.

was this fixes in v0.14.0 ?

It depends - v0.14.0 fixed wrong CHANNEL_END export
But the issue of importing redux-saga/effects within rollup is still not resolved. The best I've come with is this, where possibly in the future we could switch the default to es6 modules once rollup/webpack2 adoption increase and make the reverse fallback to the cjs module format for webpack1 users.
WDYT? cc @zech @nktssh @yelouafi

Regarding CHANNEL_END after the update i've still got the same issue but now in another file:
'CHANNEL_END' is not exported by '$PATH_TO_PROJECT$\rollup-redux-saga\node_modules\redux-saga\es\internal\channel.js' (imported by '$PATH_TO_PROJECT$\rollup-redux-saga\node_modules\redux-saga\es\utils.js')

As stated internal\channel.js has no export for CHANNEL_END.
Importing the 'right' redux-saga/effects by defining a new environment variable like JSNEXT=true looks clumsy to me to be honest but may work i think.
I think documenting the right import path for ES6 users will be sufficient. Unfortunately i don't know if this is limited to rollup. I've never used Webpack before.
Maybe it's an option for future releases to reorganize the redux-saga module structure or go all JSNEXT ;-)

bug with wrong import doesn't affect  webpack 1 and webpack 2 users - use both of them on different project, all as expected.
the main problem is to have 2 entry points while all build systems expect only 1 main file.
At least two approaches coming to my mind:

make 1 entry point
split redux-saga package into two: redux-saga-core and redux-saga-effects (naming is just example)

@nktssh Which entrypoint is webpack 1/2 using? I guess it uses the normal main node in package.json as an entry point.
With rollup you can configure jsnext:main or main as an entry point. It defaults to the main entrypoint as you can see here: https://github.com/rollup/rollup-plugin-node-resolve
Configuring it with jsnext: false works of course but this forces rollup to use the es5 standard for all other node modules as well.

@zech it depends on webpack config. You can configure it to use jsnext:main or main.
With main webpack will use "lib" folder and with jsnext:main it will use "es" for main file and "lib/effects" for separate import.
It will just not throw error and silently use "lib/effects".
So, the problem is still exist but silently. Agree, it's not a solution rather that a cheap workaround.

@zech
Ye, you are right, I got confused a little bit and changed the initial fix, gonna straighten thing up, just need to establish what should be in fact be exported as there are like 2 or 3 similar things, some internal. Sorry for the confustion.
Please read this explanation about 2 entry points problem, if you are interested.

Find comment about current topic in rollup repo https://github.com/rollup/rollup/issues/126#issuecomment-240038057

@Andarist Yes thank you. I'm following this topic as well.
@nktssh This is indeed a cheap workaround as it will mix up ES6 and ES5 code during build. But at least it works.

Found a thread on npm repo about enhancing "main" field and pass directory there
https://github.com/npm/npm/issues/10506
Resolution:

This would require changes to the Node module resolution algorithm. As was noted on nodejs/node#3953 when @evanlucas closed it, the Node module loader is basically sacred writ at this point, and won't be changed.

The solution of splitting the lib into separate modules and have them required by each other if neccessary - monorepo style - seems the most viable.
@zech how would it mix up es6 and es5 code during the build? what do you mean?

@Andarist I was referring to the webpack workaround. @nktssh explained it here https://github.com/redux-saga/redux-saga/issues/689#issuecomment-269120552
It looks like seperate packages would be the best solution. In the meanwhile documenting the issue will help.

Hm, I've just checked with validate-npm-package-name and redux-saga/effects is not a valid package name, @redux-saga/effects would be. So its probably not a problem as it would be a hard dependency of the redux-saga.
Do you know if a package can have 2 names?
Also - would you be kind enough and send a PR with a short note about bundling with rollup and suggesting to use this form
import { delay, effects } from 'redux-saga'
const { call } = effects // same thing for utils

I think its the better way for now, especially when we are discussing here splitting into 2 packages and that would certainly break this import { call } from 'redux-saga/es/effects'.
Do you know though if my proposed approach ruins tree-shaking? Aint sure how it works exactly and how smart it can be, im wondering if this reexporting of the whole thing can break the benefits of it

Hm, I've just checked with validate-npm-package-name and redux-saga/effects is not a valid package name, @redux-saga/effects would be. So its probably not a problem as it would be a hard dependency of the redux-saga.

Do you know if a package can have 2 names?

I think you've got us wrong. We're talking about seperate package names for ES6 and non ES6 code. For example redux-saga stays as is with it's legacy ES5 code. Then a second package is created like redux-saga-jsnext containing only code written with the latest standard. Or do it the other way around if you want redux-saga-es5 or redux-saga-legacy ;-)
But the package structure remains as is except that there is no es/ folder anymore.

Also - would you be kind enough and send a PR with a short note about bundling with rollup and suggesting to use this form

You mean PR for documentation? Can you tell me where you want me to put it? Troubleshooting? But bear with me because i've not done that very often.

Do you know though if my proposed approach ruins tree-shaking? Aint sure how it works exactly and how smart it can be, im wondering if this reexporting of the whole thing can break the benefits of it

I'm not 100% confident but as I see it this won't break tree-shaking.

@zech actually, I with @Andarist get you wrong - my thoughts was about two packages: one is main and one for 'effects'

Then I got the lodash approach wrong. To be honest I did not look into it.
But I don't like the lodash way for redux-saga because the effects are more coupled to redux-saga. lodash on the other side has more distinct modules

what about leave only one entry point and desctructure effects from there like an example from @Andarist
import { delay, effects } from 'redux-saga'
const { call } = effects

This is another possible solution.
Moreover, some libs (like redux-form, for example) just have exported inner Action Creators on the top-level of lib API, near the components and helpers, e.g.
import { change, submit, arrayRemoveAll, Field, Form, reduxForm } from 'redux-form'

What do you think about this approach?
Do redux-saga really need this effects separate import?
Besides, as I can see from v0.14.0 release notes, a lot of people are confused about two imports

I'm fine with this approach as well. That's what I meant with the

BTW. when you already re-export effects within the main module JS.  Why not change the documentation to use it this way in general and leave the effects.js just for historic reasons to not break code for others?

part. Would be the easiest way around i think.

@Andarist what do you think about this?

Besides, as I can see from v0.14.0 release notes, a lot of people are confused about two imports

That confusion was only about things like take and takeEvery being exported from other modules. Not that 2 modules are confusing in general.

Do redux-saga really need this effects separate import?

Personally I think this distinction helps people understand the idea behind effects (plain objects with appropriate structure, just like redux actions are - plain objects with type property)
@zech

You mean PR for documentation? Can you tell me where you want me to put it? Troubleshooting? But bear with me because I've not done that very often.

Yeah, Troubleshooting seems like a good place for this one.
@issue
still needs to think about the issue and decide what to do, w8ing also for @yelouafi's comment on the matter

Sorry for the delay. I was on holiday till today. I finally made the PR right now.

The fix is pending in the PRs here - https://github.com/redux-saga/redux-saga/pull/724 . How much of the problem does it cause now? Does the fix require using a forked repo? If so Im gonna push the simpler fix faster and release updated library asap.
Sorry for the delay and all, Ive kinda messed up things here.
cc @ok111net

@Andarist Yes it would require a forked repo as i cannot build. But for now i've done a manual change within the file omitting the CHANNEL_END export waiting for a new release.

Ok, I'll release a faster patch version asap and let you know.
pon., 16 sty 2017 o 13:24 użytkownik Tim Zech<EMAIL_ADDRESS>napisał:

@Andarist https://github.com/Andarist Yes it would require a forked
repo as i cannot build. But for now i've done a manual change within the
file omitting the CHANNEL_END export waiting for a new release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redux-saga/redux-saga/issues/689#issuecomment-272849013,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJWMkrpcymtaVAV_jrJGtN1LYMw0lVmcks5rS2FvgaJpZM4LKh0G
.

Don't rush it. But thank you for your efforts.

@zech @ok111net - please check out the new release and let me know

It builds and works. Thank you.

@Andarist I think we can close it?
Also, it can be useful for all who tired with destructuring of effects: I've created small package called redux-saga-effects, just for better development experience. Take a look
https://github.com/nktssh/redux-saga-effects

I would like to keep this opened as a reminder that something should be done in the library itself. Possibly we should release 2 builds, but thats the subject for the future for now, as there are more pressings matters at the moment.
About your package - couldnt you spread them? Would it break tree shaking? I havent done it yet, so aint familiar with the rules involved ;)

@Andarist

more pressings matters at the moment

sure, np! Just want to check if it still relevant.

couldnt you spread them? Would it break tree shaking?

it's a first version, will try to move package in dynamic direction.
I also don't like manual re-export - it means that I need to keep eye on the redux-saga releases.
Will see how far I can get with dynamic exports - ES6 modules are non-dynamic by design.
What can really solve this problem - extracting effects into separate package, all other things are workarounds (it was suggested earlier in this thread and discussed, I know).

hey guys, would this one solve the issue for you?

thanks to @Ephys I'll release a patch version today which should fix this problem entirely and fixes/hacks like:

aliasing
@nktssh 's redux-saga-effects package
importing effects from redux-saga
etc

should become obsolete :tada:

This also affects the brunch build tool:
https://github.com/brunch/brunch/issues/1695

@tcrossland I think this is brunch's issue. Answered there and hopefully we'll manage to find a solution.


Unable to replicate example from docs

I am trying to run a dependency rule, with java.
To warmup, I'm using the example from the docs: "Oscar lives in the trash can"
with the following rule
  - name: dep_event_mention_out
    label: LivesIn
    priority: 1
    type: dependency
    pattern: |
      trigger = [lemma=live]
      resident:Person = nsubj

And unfortunately, the dependency is not recognized.
even if I change nsubj to /.*/, still no results.
See code:
https://github.com/urigoren/odin_rules
Thank you

Hi -- did you already label "Oscar" as a Person?  I am guessing that that's the issue, as the EventMention needs to land on a previously found Mention (here, prob a TextBoundMention for "Oscar" labeled as Person, which you could do in a couple of ways, by first finding all nouns, or better by using the NER tags from the processor)

Hi, @urigoren.  Yes, @BeckySharp identified the issue: looking at your rules, it seems you haven't identified "Oscar" as a Person.
To test, simply add a rule like the following:
# A toy rule that will map the string "Oscar" to a Person mention.
# Note that this rule must run **before** events reference a Person mention
- name: "oscar-quick-fix"
   label: Person
   priority: 1
   type: token
   pattern: |
     "Oscar"

I think this assumption wasn't stated in the caption of the example you're using in your project, though other examples in the manual are explicit about this (ex. Examples 7 & 10).  I apologize for the confusion.  The manual really is in need of an update.
Also, you will either need to remove the priority line from your two event rules, or push both of those to priority 2, as the entity rule is responsible for producing Person mentions and your event rules reference/depend on Person mentions.

I'm sorry, but it still doesn't work.
I have tried a lot of variation, and neither of them work.
This is the last version of the rules:

rules:
  - name: dep_event_mention_out
    label: LivesIn
    priority: 2
    type: dependency
    pattern: |
      trigger = [lemma=live]
      resident:Noun = [outgoing=/nmod|nsubj|det|dep|case|nmod_in|acl:relcl/]
  - name: dep_event_mention_in
    label: LivesIn
    priority: 2
    type: dependency
    pattern: |
      trigger = [lemma=live]
      resident:Noun = [incoming=/nmod|nsubj|det|dep|case|nmod_in|acl:relcl/]
  - name: "oscar-quick-fix"
    label: Noun
    priority: 1
    type: token
    pattern: |
        "Oscar"
  - name: "np"
    label: Noun
    priority: 1
    type: token
    unit: tag
    pattern: |
      /^N/

And I also updated the repo:
https://github.com/urigoren/odin_rules

I'm looking into/using your grammar now -- will update when I've poked around

ok -- so, for the first rule, to get extractions, I think you want something like this:
    label: LivesIn
    priority: 2
    type: dependency
    pattern: |
      trigger = [lemma=live]
      resident:Noun = >/nmod|nsubj|det|dep|case|nmod_in|acl:relcl/

Note that you want to traverse the dependencies (starting from the trigger), so you use the ">" (traverse outgoing) and "<" (traverse incoming).  Using the [ ] notation, as you had it, adds a constraint on the token you're landing on, if that helps.
That makes links like this:

Likely, what you're after is a single "living in" event with multiple arguments, like this:
    label: LivesIn
    priority: 2
    type: dependency
    pattern: |
      trigger = [lemma=live]
      resident:Noun = >/nsubj/
      abode: Noun = >/nmod_in/

Which makes links like this:

But @urigoren please let us know if (a) it's still not working or (b) you have more questions!

Thank you so much, it worked !
Another quick question if I may,
Is it possible to label the subject of a verb as an entity ?
For example, to label Oscar as a person, because it is the subject of the verb lives ?
If so, what is the rule ?

Glad to hear you have it working now.

Is it possible to label the subject of a verb as an entity ?

Definitely!  For this, you'll want to use a token pattern.  The following rule checks to see if there is an incoming nsubj dependency:
- name: "nsubj-as-noun"
  label: Noun
  type: token
  pattern: |
    [incoming=nsubj]

Note that the rule above will only match a single token.  To handle subjects that are compound noun, you can modify that rule to include any surrounding nouns by adding a constraint on the POS tag and the * quantifier (zero or more):
- name: "nsubj-as-noun-expanded"
  label: Noun
  type: token
  pattern: |
    [tag=/^N/]*
    [incoming=nsubj]
    [tag=/^N/]*

Following that same idea, you can expand what's included in the match using additional token constraints in a single rule or by employing a set of scaffolding rules.

If you want to include subjects of passive constructions, you'll want to change [incoming=nsubj] to be [incoming=/^nsubj/].

Closing as I believe this is resolved, but we can reopen if needed, @urigoren.


Suggestion for the readme

This issue can instead be treated as a suggestion for the readme of the repository

Can't this code should now be updated like  :
import {express}  from "express"
As the latest version of node.js allows it to treat as a module, for which we just have to add a  type: "module" in package.json
As node features have been updating , this suggestion can also be a good updation to readme and obvio the coding style

Hi! The code in the readme (as little as there is) is meant to work on the Node.js versions that express supports. The code on the website is more flexible, and we typically keep that updated to whatever the current LTS Node.js can run. I hope that clarifies.

Cool !! , thanks


Update WP for latest BAP

This PR updates WP to work with BAP version 2.2.0-alpha+e8d63c0.

Merge it @fortunac


Licensing?

Is this code licensed for use with other projects?

I've made the license situation clearer (it is a port so not wholly my work)


Added documentation for SlideToggle value changed event.

Fixes https://github.com/SamProf/MatBlazor/issues/177.

Thank you for this example!


Not fixed for me.

Doesn't work

Strange, this post is an error, it is supposed to be a reply to an existing issue.


feat(artifacts): Add storage policy while adding files to artifacts

Description

Fixes WB-17872

What does the PR do? Include a concise description of the PR contents.
FR by Gong to disable staging files while uploading (It's a blocker for them since they're uploading large artifacts)
Proposal: https://weightsandbiases.slack.com/archives/C04MNBGJDBN/p1692910585409059
Note:

I haven't made any changes to the integrations that use the add_file() and add_dir() methods.

Testing
pytest_tests/system_tests/test_artifacts/test_wandb_artifacts_full.py
pytest_tests/unit_tests/test_artifacts/test_storage.py
Tested to make sure nexus still works the same.
import wandb

import os
import random
import tempfile

os.environ["WANDB_BASE_URL"] = "https://api.wandb.ai"
# os.environ["WANDB_BASE_URL"] = "http://localhost:8080"
# os.environ["WANDB_BASE_URL"] = "http://api.wandb.test"
# os.environ["WANDB_BASE_URL"] = "https://api.qa.wandb.ai"
# os.environ["WANDB_BASE_URL"] = "https://qa-aws.wandb.io"

ENTITY = "ibindlish"
PROJECT = "test-staging"
ARTIFACT = "test-art1"

tmpdir = ".."
with wandb.init(entity=ENTITY, project=PROJECT) as run:
    artifact = wandb.Artifact(ARTIFACT, "dataset")
    for i in range(5):
        with tempfile.NamedTemporaryFile(delete=False) as temp_file:
            data_to_write = "Hello, World!\nThis is a new temporary file."
            temp_file.write(data_to_write.encode("utf-8"))
        entry = artifact.add_file(temp_file.name, policy="immutable")
    artifact = run.log_artifact(artifact)

Do you mind changing the base to #7098 to highlight the actual content of this PR?

Do you mind changing the base to #7098 to highlight the actual content of this PR?

Oh, i did it the other way around. So this PR (only staging changes) is based off master
And then the caching stuff (#7098) is based off this one...


io error message in make_tests

This would have helped me to understand a broken configuration more quickly. I had compiletest set up to look for a couple of directories, but one was missing and it took me a while to figure it out.
PS: The previous error message was generic, something like "Path does not exist".

Hey @colin-kiegel, sorry for not getting back on this PR sooner.
I'm somewhat hesitant to merge a change like this, because this tool is meant to just be an extraction of the same tool in rust-lang/rust. The codebase here hasn't kept up with rust-lang/rust in a while (primarily because no one has asked), but if that happens, then a change like this is likely to get lost.
On the other hand, this is pretty trivial, so I'm thinking to merge it and that'll be that. May I suggest you submit this as a PR for rust-lang/rust as well?

Yes, that's ok for me.


[RAZIEL]: Update DefaultStateHandler

Matching - 98.14%
https://decomp.me/scratch/UWeF7
Current codebase version matching percentage is 13.26%.

Not 100% matching but equivalent, case 0x4010200 gets commented out in code because StateHandlerSlide glitches.


Reordering tabs still crashes when running elevated

Environment
Windows build number: 10.0.19041.0
Windows Terminal version: 0.11.1133.0

Any other software?

Steps to reproduce
Launch Windows Terminal as administrator.  Create a couple of tabs.  Use the mouse to click and drag one of the tabs.
Expected behavior
Nothing should happen
Actual behavior
Windows Terminal crashes
#4874 was supposed to prevent tab reordering while elevated and it either doesn't work (can't remember if I tested this when it first released) or some later change broke it again.

My Windows terminal does not crash.
Your @Sandra2001

Just to double-check: you are running Terminal as administrator, correct?

Sorry about that. We regressed this in an error handling cleanup pass. Fix is in #5542.


cmake visual studio source_group

Hi. I added abseil in my project using add_subdirectory(third_party/abseil-cpp). But now there are a lot of abseil projects in my solution and it's hard to find my owns. Is there are a method(like soure_group()) to move abseil projects to the folder using cmake?

To enable IDE folders in CMake, you need to set USE_FOLDERS global property first:
set_property(GLOBAL PROPERTY USE_FOLDERS ON)

Then you normally have to set CMAKE_FOLDER before adding a subdirectory:
set(CMAKE_FOLDER third_party/gtest)
add_subdirectory(googletest)

For Abseil, you have to set ABSL_IDE_FOLDER property instead:
set(ABSL_IDE_FOLDER third_party/abseil)
add_subdirectory(abseil-cpp)


Test AbstractQuery#withFieldNotIn(..)

Codecov Report

Merging #59 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #59      +/-   ##
===========================================
+ Coverage     79.03%   79.2%   +0.16%
- Complexity      652     653       +1
===========================================
  Files            85      85
  Lines          1832    1832
  Branches        158     158
===========================================
+ Hits           1448    1451       +3
+ Misses          257     254       -3
  Partials        127     127

Impacted Files
Coverage Δ
Complexity Δ

src/org/smof/collection/AbstractQuery.java
60.86% <0%> (+6.52%)
16% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e57ce...4edc978. Read the comment docs.


Create OER Commons CSV from OCW

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/3147
Description (What does it do?)
This PR is responsible for the business logic necessary for creating the CSV out of MIT Open API (OCW) data according to OER Commons Template.
Things not implemented / updated (yet):

Linting
Poetry
Update README.md
Packaged with pypi setup files/requirements
Made a pypi package
tests

This will work as a Pypi package as well as CLI interface. The intended way to be used as a package is:
from ocw_oer_export import create_csv
create_csv()

(not yet though)
Might also add a progress bar via a library perhaps, currently we are logging that without flushing. Will update that once we are set on the API client.
The API client code here is temporary.
Currently, we are also committing the created files (CSV and JSON) in the PR. I suppose we will want to not include it in the actual repository. But for now I'm just including it just for overview purposes.
How can this be tested?

Checkout to this branch
Create Virtual Environment -- install the dependencies in requirements.txt
python main.py --create_csv

Additional Context

Thanks @ChristopherChudzicki for your valuable feedback. I have implemented some of the changes, some are still to be implemented.
I will look at the following after holidays:

Setting up Linting & Formatting via pre-commit
Using csv.DictWriter over pandas

Will also see if it's worth splitting the data into chunks while writing for our use case (will see if the performance difference is noticeable, or could it become noticeable in future?)

Update README.md with purpose and instructions

This PR is ready for review.
There is one minor thing that we need to update:
setup.cfg:
author = X
author_email = Y

Please let me know what to use for these

@ibrahimjaved12 when can we see a sample output of this code? If it's close to being done, I'd like to get some feedback form the OCW team.

@pdpinch
This is the CSV file generated from the code:
ocw_oer_export.csv
Uploaded in Google Spreadsheets:
https://docs.google.com/spreadsheets/d/13G9nXziAQddtQYVHQQn80i6PdetTrTqi_74d9v8FjtE/edit#gid=1413649170
I would have to double check the fields, but I believe from the output point of view it's completed according to the instructions.
This is the API it uses: https://mit-open-rc.odl.mit.edu//api/v1/courses/?platform=ocw
This has only live-qa data (if you look at URLs field there), not production data. Do we have an API under progress for OCW production data?
Also, can you please help me fill this:
For PyPI package I need to know:
author name
author email

for this package.

Also, can you please help me fill this:
For PyPI package I need to know: ...

After (briefly) discussing this with @pdpinch this morning, I'm not sure we need to publish this to PyPI. PyPI is good for a reusable package, but my understanding is that this CSV project is really of interest to one specific consumer, OER Commons.

This is the API it uses: https://mit-open-rc.odl.mit.edu//api/v1/courses/?platform=ocw
This has only live-qa data

Good catch. The production app is deployed at  https://mitopen.odl.mit.edu/, so API is at  https://mitopen.odl.mit.edu/api/v1/courses/, etc. HOWEVER: I'm not sure if the production data is up-to-date. (The deployed app is not up-to-date.) But it should be OK for generating an example CSV for the OCW team to look at.

Good catch. The production app is deployed at https://mitopen.odl.mit.edu/, so API is at https://mitopen.odl.mit.edu/api/v1/courses/, etc. HOWEVER: I'm not sure if the production data is up-to-date. (The deployed app is not up-to-date.) But it should be OK for generating an example CSV for the OCW team to look at.

There is one difference though. Previously, in RC API link, we had a key of resource_content_tags but then it was changed to course_feature some time later. So my code uses the same term (course_feature). But in this production API link, we are using resource_content_tags again. I think we want to use course_feature, or maybe, course_feature_tags ?

There is one difference though. Previously, in RC API link, we had a key of resource_content_tags but then it was changed to course_feature some time later. So my code uses the same term (course_feature). But in this production API link, we are using resource_content_tags again. I think we want to use course_feature, or maybe, course_feature_tags ?
Edit: Do you think we should add the logic to log an error in such a use case, when we can't find a certain field in the API?, or maybe, create the CSV, but leave the field null? I think we cannot afford to have fields like this unavailable - so it doesn't make sense to create the CSV regardless of that - so I think we should maybe log the error?
Generally speaking, do you think in the long term, we could have names changed of more field(s) that could result in unwanted effects for this project?

The production release of MIT Open is currently pretty far out of date. We're working on it. In terms of structure, the RC data is correct. (Just not correct in terms of URLs).
The API should not having breaking changes going forward, though it might before we officially release the API. I'm not sure when that is. If an expected field does not exist, I think we should throw an error (not log it). That would be highly unexpected and we should fix it. It seems like we might set up the CSV generation as a re-occuring job. In that case, we would want to get some sort of alert on such errors.

Added the suggested test case, up for re-review


Correcting overly restrictive lifetimes in vectored IO

The current input lifetimes for write_vectored and write_all_vectored in AsyncWriteExt and read_vectored in AsyncReadExt are unnecessarily restrictive and disallow otherwise reasonable uses. This change fixes #2483 by relaxing that restriction, making the lifetime of the incoming references independent of the inner lifetime that the IoSlices refer to. (They could be relaxed further, but I can't see any practical difference it would make so I have tried to be consistent with the surrounding code)
Please let me know if you'd like any other changes made for this issue, or any other comments you have.
(Edit: Apologies for any log/notification noise the repeated CI runs generated, some unrelated tests wouldn't run cleanly on my local machine)

Thanks! Could you add a test to prevent this change from being accidentally reverted in the future?

I've added a corresponding test to the existing ones for write_all_vectored, but couldn't see any that use the corresponding interface with read_ / write_vectored - the tests for those structures appear to directly call poll_* rather than the methods on Async*Ext,  and the poll_* implementations are already correct. Let me know if you think testing that "gap" in the interface is worth creating an entirely new harness for, though.


Added sample script 'Govern Orphaned Microsoft Teams'

Resolves #1147

Coverage remained the same at 100.0% when pulling 1580269b03761aafa057af0ff0d9c50c4e7d4ac5 on garrytrinder:issue-1147 into 89ac4fa73958c10d06633db7707e014ed2ff3aaf on pnp:dev.

All yours @waldekmastykarz 👍🏻

Merged manually. Thank you!


Add Data privacy disclaimer to second screen

Second screen, the one with social logins, let's add the following text:
"Data privacy"
"We take your data seriously. It is stored securely on our servers and we will not share your information with any third party.
Your name and phone number will only be displayed when you are matched with another user to help out, and only to that user."
Too much text?
If too much, maybe we can have "Data privacy"; "We take your data seriously. [More info]" and More info could be clickable and it expands as a pop-up with the rest of the text.

Let's move this to account setup:
"We just need a few things to set you up. This data is private. We will only share your name and phone number when you accept to help someone."
"We just need a few things to set you up. This data is private. We will only share your name and phone number when a volunteer accepts to help you."


add link to test-drive

I suggest adding a link to https://github.com/fortran-lang/test-drive in the Readme.md, to make it easier to find the related project.

Thank you for your suggestion.
I added a new section, 'Related projects.' test-drive is listed with a description and a link to https://github.com/fortran-lang/test-drive


Check if component is mounted before setting state.

Prevents "Uncaught Error: Invariant Violation: replaceState(...): Can
only update a mounted or mounting component." -- which can occur if the
proxy component is unmounted before download completes.

Thanks


CSV previews are sometimes broken

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
What
We have had issues with CSV previews for some time, and work has been done to resolve them. However they seem to be occurring again (see Examples below). The purpose of this card is to investigate what’s going wrong and suggest a fix.
Examples

Visit https://www.gov.uk/government/statistics/postcode-level-gas-statistics-2021-experimental and click view online for the first CSV attachment
Visit https://www.gov.uk/government/statistics/legal-aid-statistics-april-to-june-2023-data-files and click view online for the first CSV attachment

Why
Trello card
Screenshots?
No user-visible changes.

https://assets.integration.publishing.service.gov.uk/media/63d0e5e9e90e071ba56e0eab/Postcode_level_gas_2021.csv/preview
https://assets.integration.publishing.service.gov.uk/media/65153d216dfda600148e3751/legal-aid-statistics-main-data-apr-jun-2023.csv/preview

Thanks Mat, this is great, and I agree with your comment in the trello card about work to limit the number of lines sent from asset manager.
I feel like this controller is now a bit out of hand though - it's become so bloated. We could either refactor here or if you prefer, we could merge this work and then refactor in a fresh PR?

As discussed, let's merge it, so we can make sure the problem is resolved and then do the refactoring as a seaprate PR.

Gonna merge tomorrow morning.