Add cc metadata file to the repository

Fixes #39 by @dhruvkb
Adds .cc-metadata.yml file to the repository.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[ ] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

the tests are failing, could you investigate and fix, @snehal199?

the tests are failing, could you investigate and fix, @snehal199?

FYI, It looks as if the tests failed due to no final newline on the new metadata file.

Made the necessary change and the tests pass now @kgodey , @dpoirier


fix caret cursor

#179 Caret is not being drawn by caret control.
For some reason the Line template wasn't being drawn. It never called into DrawingContext. I think it may be because we were drawing a line which had Width and Height but no start point or end point. I verified that Avalonia GUI ignores Lines with just width/height, so this is avalonia behavior.
I changed CaretControl template to output a Rectangle of width/1,height/1 and now it calls, gets rendered correctly.

Caret does not show up in ComboBoxItem. Visible when opening ComboBox.

Caret does not show up in ComboBoxItem. Visible when opening ComboBox.

ComboBoxItem behavior is baked into Avalonia.
   public ComboBoxItem()
   {
       this.GetObservable(ComboBoxItem.IsFocusedProperty)
           .Subscribe(focused =>
           {
               if (focused)
               {
                   (Parent as ComboBox)?.ItemFocused(this);
               }
           });
   }

Hmmm....I can't seem to figure out how to get comboboxItem to show focus.

I figured it out. I need to draw the movebrush AFTER the content is drawn, not before, otherwise the content resets the MoveBrush pixel


Combining ResourceServer with @EnableOAuth2Sso

What i wan to achieve:

Browse to protected resource and get redirected to authorization-server. After login the resource should be available.
Access the same protected resource for example via CURL with an Authorization header:
Authorization: bearer someTokenValue. If the token is correct the resource should be returned.

If i use the @EnableOauth2Sso-Annotation on a WebSecurityConfigurerAdapter the first goal is achieved.
For the second goal i had to do this:
@Override
public void configure(HttpSecurity http) throws Exception {
    http
        ...
        .addFilterAfter(oAuth2AuthenticationProcessingFilter(), AbstractPreAuthenticatedProcessingFilter.class);
}

private OAuth2AuthenticationProcessingFilter oAuth2AuthenticationProcessingFilter() {

    OAuth2AuthenticationProcessingFilter oAuth2AuthenticationProcessingFilter =
        new OAuth2AuthenticationProcessingFilter();
    oAuth2AuthenticationProcessingFilter.setAuthenticationManager(oauthAuthenticationManager());
    oAuth2AuthenticationProcessingFilter.setStateless(false);

    return oAuth2AuthenticationProcessingFilter;
}

private AuthenticationManager oauthAuthenticationManager() {

    OAuth2AuthenticationManager oauthAuthenticationManager = new OAuth2AuthenticationManager();

    oauthAuthenticationManager.setResourceId(resourceId);
    oauthAuthenticationManager.setTokenServices(tokenServices);
    oauthAuthenticationManager.setClientDetailsService(null);

    return oauthAuthenticationManager;
}

Is this the way to go to achieve both goals? Or is there something much simpler which i just didn't see?

Same needs! Any news about possible simplest solution?

I'm interested or in need of this as well. What's the proper way, or is @Yannic92's approach the proper way to configure this?

I have exactly the same needs!

I have the same needs.

Another upvote for this issue

Another one

I have the same needs too

+1

+1

+1

+1

+1

+1

The above solution works perfectly, but when you add auto-wire OAuth2RestTemplate to support the refresh token, it no longer works, anyone with any suggestion?

+1

I have exactly the same needs too!

+1

+1. Does someone know a solution on how to add multiple filters, if you have separate tokenServices e.g. a Facebook and Google Login?

I developed this configuration which is working perfectly fine with me supporting

Form based login / Authorization Code flow
Password grant type (For REST Endpoints involving user)
Client Credentials  (For REST Endpoints)

`
@Configuration
public class ResourceServerSecurityConfiguration {
@Configuration
@EnableOAuth2Sso
@EnableWebSecurity
protected static class ResourceConfiguration extends WebSecurityConfigurerAdapter {

	@Value("${sso.url}")
	private String ssoUrl;

	@Autowired
	private  RedisConnectionFactory redisConnectionFactory;

	@Bean
	protected TokenStore tokenStore() {
		return new RedisTokenStore(redisConnectionFactory);
	}

	@Bean
	@Primary
	protected ResourceServerTokenServices tokenServices() {
		DefaultTokenServices defaultTokenServices = new DefaultTokenServices();
		defaultTokenServices.setTokenStore(tokenStore());
		defaultTokenServices.setSupportRefreshToken(true);

		return defaultTokenServices;
	}

	@Override
	@Bean
	public AuthenticationManager authenticationManagerBean() throws Exception {
	    OAuth2AuthenticationManager authenticationManager = new OAuth2AuthenticationManager();
	    authenticationManager.setTokenServices(tokenServices());
	    return authenticationManager;
	}

	@Override
	protected void configure(HttpSecurity http) throws Exception {
		http.requestMatchers()
		.and().authorizeRequests()
			.antMatchers("/").permitAll()
			.antMatchers(HttpMethod.GET, "/static/**").permitAll()
			.antMatchers(HttpMethod.GET, "/profile/**").permitAll()
			.antMatchers(HttpMethod.GET, "/services/**").permitAll()
			.anyRequest().authenticated()
		.and().logout()
				.invalidateHttpSession(true)
				.logoutSuccessUrl(ssoUrl+"/logout")
				.logoutRequestMatcher(new AntPathRequestMatcher("/logout"))
				.deleteCookies("JSESSIONID").invalidateHttpSession(true)
				.permitAll();
				}

}

@Configuration
@EnableResourceServer
@Order(1)
protected static class ResourceServerConfig extends ResourceServerConfigurerAdapter {

	@Override
	public void configure(ResourceServerSecurityConfigurer resources) throws Exception {
		resources.resourceId("my-resource");
	}

	@Override
    public void configure(HttpSecurity http) throws Exception {
		http.requestMatcher(new OAuthRequestedMatcher())
			.authorizeRequests().anyRequest().fullyAuthenticated();

	}
}

private static class OAuthRequestedMatcher implements RequestMatcher {
    public boolean matches(HttpServletRequest request) {
        String auth = request.getHeader("Authorization");
        boolean haveOauth2Token = (auth != null) && auth.startsWith("Bearer");
        boolean haveAccessToken = request.getParameter("access_token")!=null;
        return haveOauth2Token || haveAccessToken;
    }
}

}
`

+1
I've same need too.

+1

@ejazazim Your variant is the only one that worked for me, thanks!

FYI, this is now supported on Spring Security 5
https://docs.spring.io/spring-security/site/docs/5.2.0.BUILD-SNAPSHOT/reference/htmlsingle/#spring-security-oauth2-core
by using a combination of .formLogin() and .oauth2ResourceServer() in your web security config.

+1，I appreciate @ejazazim help.

Many thanks
+1

+1 to @ejazazim too. Very helpful

Closing this as questions are better suited on Stack Overflow. We prefer to use GitHub issues for bugs and enhancements.


For some reason in Discord chats from in-game appear with <> around every letter

For some reason in Discord chats from in-game appear with <> around every letter. If I type Hello into game chat it appears as
How do I fix this?
Here's my code:
{
"minecraftToDiscord": {
"playerMessage": {
"customMessage": "\u003c%player\u003e %message",
"useCustomMessage": true
},
"teamPlayerMessage": {
"customMessage": "%team \u003c%player\u003e %message",
"useCustomMessage": true
},
"serverStarting": "Server is starting!",
"serverStarted": "Server Started.",
"serverStopping": "Server is stopping!",
"serverStopped": "Server Stopped.",
"channelDescription": "Playercount : %playercount/%maxplayercount,\n Uptime : %uptime",
"playerJoined": {
"customMessage": "%player joined the game",
"useCustomMessage": true
},
"playerJoinedRenamed": {
"customMessage": "%new (formerly known as %old) joined the game",
"useCustomMessage": true
},
"playerLeft": {
"customMessage": "%player left the game",
"useCustomMessage": true
},
"advancementTask": {
"customMessage": "%player has made the advancement %advancement",
"useCustomMessage": true
},
"advancementChallenge": {
"customMessage": "%player has completed the challenge %advancement",
"useCustomMessage": true
},
"advancementGoal": {
"customMessage": "%player has reached the goal %advancement",
"useCustomMessage": true
},
"deathMsgPrefix": "",
"deathMsgPostfix": "",
"atATellRaw": "%message",
"meMessage": {
"customMessage": "* %author %message",
"useCustomMessage": true
},
"adminMessage": {
"customMessage": "[%author: %message]",
"useCustomMessage": true
},
"sayMessage": {
"customMessage": "[%author] %message",
"useCustomMessage": true
},
"achievement": {
"customMessage": "%player has just earned the achievement %achievement",
"useCustomMessage": true
}
},
"discordToMinecraft": {
"message": "[%player] %message"
},
"discord": {
"commandPrefix": "!",
"botActivities": [
"!commands",
"%playercount / %maxplayercount",
"on %ip",
"%uptime_D day(s), %uptime_H hour(s), %uptime_M minute(s) and %uptime_S second(s)"
]
}
}

do you have any other mod installed?

do you have any other mod installed?

Yes. None of them should affect chat though. Here's the list:
Inv View
Deltalogger
Fabric API
Image2Map
Lithium
Sit
Spark
Survival Spectator
The version is 1.16.5

I can't reproduce the issue rn, could you send the other config file too?

fdlink.zip
This is the fdlink folder in my config folder

I can't reproduce the issue rn, could you send the other config file too?

I'm looking at it rn

Perfect

can you try after removing the empty emoji in emoji map?
"emojiMap": [
    {
      "name": "chat",
      "id": "829112994873081857"
    },
    {
      "name": "",
      "id": ""
    }
  ]

the empty one is this one:
{
      "name": "",
      "id": ""
}

It will be fixed in 0.8.18 when it will be released in a few minutes.

That fixed it! Thanks!


Fix crashing on bad bitbucketserver payload

Fix crashing on bad bitbucketserver payload
When the bitbucketserver payload is missing some fields, the parser
would crash with a panic. This change adds a check for the required
fields and returns an error if they are missing.
You can easily test this with the following curl command:
curl -X POST
https://controller
\ -H "Authorization: Bearer <SECRET>" \ -H "Content-Type:
application/json" \ -d
'{"eventKey":"pr:comment:added","comment":{"text":"/ok-to-test"}}' \ -H
"X-Event-Key: pr:comment:added"

Testing
tested it manually it now report an error and not crash.
i tested as well that gitops comment like /retest and /test pr still works

Jira issue: https://issues.redhat.com/browse/SRVKP-6706
Changes

Submitter Checklist

[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

/lgtm

/backport release-v0.28.x


Added !bomb vote commands

I'd say say that if this is going to be added, you need to make is disableable as well as changing when a vote results in a yes or no. A majority isn't always best, especially when detonating a bomb. Any no vote stops the detonation. You should have an option (possibly per vote type) to disable it, require a majority, require 2/3 majority, or require all yes votes. That could all be in the TP Settings file so the streamer can change it as they see fit.


Add Ctrl+PageUp and Ctrl+PageDown to default key bindings

I was comparing the output of showkey -a with the sakura terminal and I noticed that Alacritty does not react on Ctrl+PageUp and Ctrl+PageDown. I personally use these keys in vim, I'm adding them to the default config because think I'm not the only one 🙂
I also added them to macos config, although I didn't test on Mac.

Looks good; thanks for the PR :smile:

@jwilm @maximbaz great, I had that one in my custom config. Would it make sense to also add Shift + PageUp/Down ? I can create a quick PR.
  - { key: PageUp,   mods: Shift,   chars: "\x1b[5;2~"                   }
  - { key: PageDown, mods: Shift,   chars: "\x1b[6;2~"                   }

I actually thought about that, but the showkey -a didn't show anything for Shift+PageUp/PageDown in both of my old terminals (sakura and xterm), so I didn't know which chars should correspond to them.
If you are confident that these are the correct chars, I would be happy to see your PR :+1:

@ronjouch Would merge.

@jwilm done, PR https://github.com/jwilm/alacritty/pull/559 "Add Shift+PageUp and Shift+PageDown to default key bindings"

If you are confident that these are the correct chars, I would be happy to see your PR 👍

@maximbaz yup, have been using them with tmux for months.


Generated Assertions entry point should (could?) extend default Assertions entry point

Right now, a static import of my.pakkage.Assertions.assertThat means I can't do assertThat("a string").isNotEmpty(), for example.  If my.pakkage.Assertions extended org.assertj.core.api.Assertions, I could do that.
Maybe add a configuration property to have generated entry points optionally extend the default one?
I do know I can achieve this with a custom template, but it feel too cumbersome for that.

The generated Assertions does not inherit from the core api one to avoid ambiguous static import resolution in case you generate multiple different Assertions classes. Lets' say you have generated MyAssertions1 and MyAssertions2, you want to use both in the same test and you start with a basic basic assertions like String ones, the compiler would not know which assertThat(String) to choose, the one from MyAssertions1 or MyAssertions2 ?
You have two options here :

just static import core api Assertions and you can access basic assertions as usual
change the template that is used to generate your custom assertions and add the inheritance - see <assertionsEntryPointClass> in custom templates documentation section

Oh, I wasn't aware you could generate multiple entry point classes for the same type (assertions, bdd assertions, soft assertions, junit soft assertions).  In fact, reading over the documentation, I'm still not sure how I'd do that.
Like I said, I know I can use a custom template, and it's what I'm currently doing, it just seems a bit too cumbersome for this.

Different assertions class type is not the problem, the use case I was thinking of is when you are using generated assertions from someone else and you want to have yours also, if both generated Assertions inherit from the core  one, you would get the problem I was talking about.

Ah ok, yeah, I can see how that would be a problem.
I still think having it be configurable (off by default) could work, but given that there's already a way to do it (custom templates), I'd have no problem if you close this as "won't fix".
Thanks for your time!

closed as won't fix ;)


Adds the Yellowbrick Data Warehouse as a supported vector store

Description An integration to allow the Yellowbrick Data Warehouse to function as a vector store

this looks pretty clean and solid to me! an example notebook might be good, but not necc!

Thanks! Just raised a PR to add a notebook.


[video_player] Prevent Div/0 during network playback initialization.

Description
During network playback (HTTP), the duration may take a little longer to determine.
Until it is determined, the player must not be considered "initialized", else div/0 will occur during the progress indicator display.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@iskakaushik do you need further information approve this PR?

LGTM


Add language label only if class attribute exists

The app breaks if any of the $('pre code') tags doesn't have a class attribute. For example https://www.learnpython.dev/02-introduction-to-python/060-functions/30-function-arguments/
I change the code to be more forgiving so that it will not break which fixes #80.

Good eye! Thank you so much for your contribution.

Thank you for your courses! Looking forward to "A Practical Guide to Python".
P.S. sorry you had to deal with all those spammy PRs.

Thank you for your courses! Looking forward to "A Practical Guide to Python".
P.S. sorry you had to deal with all those spammy PRs.

I only had a handful of PRs to close -- definitely not as bad as other projects!
I hope to see you at a Practical Guide to Python, but wanted to give you a heads up that the content will be quite similar to this two day workshop. Instead of focusing on folks who are absolute beginners to programming, Practical Python will condense two days of material into one, focusing on developers who know another language and are looking to get productive with Python as quickly as possible.


Pod does not update status icon when pod is running

eg the status icon may show a download / pending state. And then a while later the image is downloaded and the pod is in running state.
The oc get pods shows the running state.
Leaving the web ui for about 1h or so (I was out) then came back and the UI still have the status icon as downloading. The pods has been running for 1h

tried to fix this one - polished the code so am sure we definitely update the $statusCss property on a pod - but for some reason dynamically changing the css style inside:
    <i class="fa {{entity.$statusCss}}"></i>

does not actually refresh the icon. I suspect its a bootstrap issue? We may need a directive to deal with dynamic icons maybe...

Most likely it's because 'entity' is different when an update occurs and what's displayed has a handle on the old instance instead.

This should be alright now if you don't mind checking after a bower update

awesome - its working great now!!!


Plot Signal-to-Read Alignment for Multiple Reads from a List

Hi,
I'm currently working on visualizing signal-to-read alignments using the basecaller move-table from dorado. In the final step (plot signal-to-read alignment), I need to plot only a specific subset of reads rather than all of them.
I've tried using the -r READ_ID option, but it only accepts a single Read ID at a time. Is there a way to specify a list of Read IDs from a file (e.g., in .txt format) or another format to filter the reads for plotting?
Thank you for your help!

Hey,
Have you tried --read_list argument? It takes a .txt file.
-l, --read_list STR (optional) Path to a file containing a list of read_ids to plot only the reads listed.

Ah, I missed that. Perfect, thanks!


Fix qs using concatenated value|key

Codecov Report

Merging #175 (e759d26) into master (d9a3a39) will decrease coverage by 0.17%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   45.22%   45.04%   -0.18%
==========================================
  Files          41       41
  Lines        1904     1918      +14
  Branches      304      305       +1
==========================================
+ Hits          861      864       +3
- Misses        971      982      +11
  Partials       72       72

Impacted Files
Coverage Δ

src/libraries/ArrayUtil.sol
51.51% <40.00%> (-1.69%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Honestly, can't think of a good solution to this problem. I think adding this is terrible in terms of complexity and gas cost.
I'd definitely prefer implementing a different algorithm that gives you the "stability".
https://en.wikipedia.org/wiki/Sorting_algorithm#Stability
Bubble sort is the easiest with stability, not the most efficient. merge sort seems reasonable


chore: release 2.16.59

Summary | Résumé

Sentinel update 169 #1627 by ben851
Production K8s 1.31 #1623 by ben851
Celery Alarm Fix #1625 by ben851
filter fix #1626 by ben851
Adding filter back for staging plan #1624 by ben851
Fixing regex for celery errors #1618 by ben851
Create dev workflow sha fix #1622 by ben851
Adding retries to TF apply stuff #1621 by ben851
Fixing the PCA Import #1620 by ben851
sentinel layer update #1619 by ben851
Dev k8s 1.31 #1611 by ben851
Update production k8s nodes to 1.30.4-20241011  by sastel

Before merging this PR
Read code suggestions left by the
cds-ai-codereviewer bot. Address
valid suggestions and shortly write down reasons to not address others. To help
with the classification of the comments, please use these reactions on each of the
comments made by the AI review:

Classification
Reaction
Emoticon

Useful
+1
👍

Noisy
eyes
👀

Hallucination
confused
😕

Wrong but teachable
rocket
🚀

Wrong and incorrect
-1
👎

The classifications will be extracted and summarized into an analysis of how helpful
or not the AI code review really is.
Test instructions | Instructions pour tester la modification
TODO: Fill in test instructions for the reviewer.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur

[ ] This PR does not break existing functionality.
[ ] This PR does not violate GCNotify's privacy policies.
[ ] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
[ ] This PR does not significantly alter performance.
[ ] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

This was superceded by .60


discovery/targetgroup: support marshaling to JSON

targetgroup.Group is able to be marshaled to and from YAML, but not with JSON. JSON is used for the http_sd API representation, so users implementing the API were required to implement their own type which is expected by the JSON unmarshaler.
Signed-off-by: Robert Fratto<EMAIL_ADDRESS>

cc @juliusv WDYT?

Thanks! Looks :+1: to me, @roidelapluie are you happy with it too?

lgtm


Previews via share jail are broken

Describe the bug
Trying to fetch the preview of an image via share jail tries to stat with a wrong path.
Steps to reproduce
Steps to reproduce the behavior:

Make a GET request for a preview via share jail, real live example request: https://localhost:9200/remote.php/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668!69b72b1a-5496-4466-9790-dd49423deca7/asdf/one-file/Okapi.jpg?scalingup=0&preview=1&a=1&c=48c300389edb6df360bdcd853fb50092&x=36&y=36

OR

set up ocis with https://github.com/owncloud/web/pull/6593 as web assets
as admin: create a folder, put a single image into it, share the folder with einstein
as einstein: accept the share and navigate into it

Expected behavior
Preview gets loaded.
Actual behavior
Preview request fails with an http 500 error
Setup
Please describe how you started the server and provide a list of relevant environment variables.

OCIS_VERSION=2ac2680e68e05e81a584328a799406bd10361a22
BRANCH=master

Additional context
The example request from above gives the following error log:
2022-04-27T12:27:21+02:00 ERR could not stat file path=a0ca6a90-a365-4782-871e-d44447bbc668!69b72b1a-5496-4466-9790-dd49423deca7!/asdf/one-file/Okapi.jpg service=thumbnails status_message="sharesstorageprovider: can only handle relative references"
2022-04-27T12:27:21+02:00 ERR could not stat file path=a0ca6a90-a365-4782-871e-d44447bbc668!69b72b1a-5496-4466-9790-dd49423deca7!/asdf/one-file/Okapi.jpg service=thumbnails status_message="sharesstorageprovider: can only handle relative references"
2022-04-27T12:27:21+02:00 ERR could not get thumbnail error="{\"id\":\"com.owncloud.api.thumbnails\",\"code\":500,\"detail\":\"could not stat file: sharesstorageprovider: can only handle relative references\",\"status\":\"Internal Server Error\"}" service=webdav

Please note that there is a trailing ! after the share id. That ! doesn't belong there (thanks to @micbar for noticing it). It doesn't exist in the request so there seems to be a faulty path construction somewhere in reva...

It should be fixed with this PR: https://github.com/owncloud/ocis/pull/3648

Can confirm the fix 🥳


Unable to revert permanent deny for fullscreen in pdf.js

After opening a pdf file in pdf.js and gone fullscreen, I clicked in the check box to remember my decision, and by mistaken I click in deny instead of allow. Now I can't go fullscreen with it: clicking in fullscreen button in pdf.js toolbar does nothing. I also can't find any way to undo this.
Even if I click in the globe icon before the url, go in More Information > Permissions > Enter fullscreen > Allow, it won't work. It also doesn't work if I try to go full screen in another PDF in another sites (domain).
I suppose it's showing the permission to the site I'm viewing, and the permission denied was for the pdf.js, as it was what was named in the fullscreen confirmation popup.
Here is the part of the dump of the permissions.sqlite dump of my profile. The last one ('www.facom.ufu.br') was made by me trying to white list the site for full screen as descried earlier.
$ sqlite3 permissions.sqlite .dump
PRAGMA foreign_keys=OFF;
BEGIN TRANSACTION;
CREATE TABLE moz_hosts ( id INTEGER PRIMARY KEY,host TEXT,type TEXT,permission INTEGER,expireType INTEGER,expireTime INTEGER,modificationTime INTEGER,appId INTEGER,isInBrowserElement INTEGER);
(...)
INSERT INTO "moz_hosts" VALUES(12,'pdf.js','fullscreen',2,0,0,1430997732127,0,0);
INSERT INTO "moz_hosts" VALUES(14,'www.facom.ufu.br','fullscreen',1,0,0,1430997870757,0,0);
COMMIT;

I can of course edit the permissions file by myself, but this is not reasonable for a normal user.
Version: Firefox 37.0.2
Mozilla Firefox for Ubuntu
canonical - 1.0
It's the Firefox that came with Ubuntu 14.04 (Trusty) 64bit, fully updated.

I think this is not an issue with PDF.js, but rather with how the full screen functionality is handled in Firefox. Please file this issue at https://bugzilla.mozilla.org for Firefox instead as this is not something that can be resolved on the PDF.js side. We would need something to undo that, but Firefox should provide that, not PDF.js.

It should be possible to revert that setting; even though I agree that it isn't too discoverable.
Try the following steps:

Open about:permissions (enter it in the URL bar).
In the "Search Sites" box, enter pdf.js and click on the result.
Reset the "Fullscreen" setting. (If that doesn't work, try clicking on the "Forget About This Site" button.)


Add validations and improvements

add field validations on setup amount: zero balance, not enough balance, no liquidity, min balance violation #8692tuvcf
add validations on continue #8692tuvcf
refresh quote each block
introduce single model for slippage and config for it
introduce base presenter to share common logic between setup and confirm

Task linked: CU-8692tuvcf iOS. Validations on Continue


Sync failed when there is a piece of  Javadocs about pre-conditions

https://github.com/spencercjh/sync-leetcode-today-problem-java-example/runs/1590050754?check_suite_focus=true

solved


Revert "Time"

Reverts Watts-Lab/surveyor#22 broke something.

Hmm, could it be that the production server isn't installing new packages?
I think we should probably make it so that it updates and installs on push. (@yli12313 might have ideas about doing this too)

Nevermind. It's not a breaking error. The start time stamp has dissappeared. I'll open another branch. Thanks!


Kile2.9.93

Microsoft Reviewers: Open in CodeFlow

looks like url should be  https://sourceforge.net/projects/kile/files/unstable/kile-3.0b3/kile-2.9.93-566-windows-msvc2017_64-cl.exe/download

looks like url should be  https://sourceforge.net/projects/kile/files/unstable/kile-3.0b3/kile-2.9.93-566-windows-msvc2017_64-cl.exe/download


Sheet: Empty Cell not set null value on BackingBean

Describe the bug
Hi,
we found an issue recently introduced working on Issue 886. When a cell containing a value is blanked the value remains in the backing bean and when the row is updated is shown again.
We have a possible solution for this problem.
Create a new Interface to mark a value to be removed
public interface ToBeRemoved{
}

Update class Sheet.java method setLocalValue in that way (in the localValues map an entry is required for each field to be updated)
public void setLocalValue(final String rowKey, final int col, final Object value) {
    final SheetRowColIndex key = new SheetRowColIndex(rowKey, col);
    if (value != null) {
        localValues.put(key, value);
    } else {
       localValues.put(key, ToBeRemoved.class);
    }
}

Update method updateModel to assign the variable newValue in that way (to set to null the value to be removed)
final Object newValue = ToBeRemoved.class.equals(entry.getValue()) ? null : entry.getValue();

Reproducer

Go to the pe:sheet showcase, basic usage

Select the cell on row 1, column Type

Click Del to remove the value 'SERVER' from the cell.

Verify this cell is now empty

Click the selected checkbox in the column Active on row 1, the row is updated

Verify that  on cell on row 1, column Active the checkbox is unchecked
Verify that  on cell on row 1, column Type the value 'SERVER' is shown again

Expected behavior

Go to the pe:sheet showcase, basic usage
Select the cell on row 1, column Type
Click Del to remove the value 'SERVER' from the cell.

Verify this cell is now empty

Click the selected checkbox in the column Active on row 1, the row is updated

Verify that  on cell on row 1, column Active the checkbox is unchecked
Verify that  on cell on row 1, column Type remains empty

PrimeFaces Extensions version
11.0.6
JSF implementation
Mojarra
JSF version
2.3
Browser(s)
No response

cc @eduarddrenth

@AlessandroRugi feel free to submit a PR for review.

@melloware I've created the pull request

I can confirm this issue in my test environment, thanks!

Does 12.0.1 contain the pr for this issue? I am running 12.0.1 in my test env and see values not being stored. I will investigate, perhaps it is me

12.0.1 doesn't contain the fix so to see, I'll be patient

No it's in 12.02 which I didn't release yet.  I can release today

comming week or so is fine for me, thnx

12.0.2 is now in Maven Central!

and using it....


Research relational DB support

Find a suitable solution
For local testing, perhaps an SQL server instance and mini-webservice (webpage) that listens to contract events and updates the database will suffice
For deployment we should use Graph-like services

The GRAPH https://thegraph.academy/developers/local-development/


fix: add missing Properties

Closes https://github.com/CycloneDX/cyclonedx-go/issues/38

Welp, looks like you discovered a bug in the XML schema! 🚀
I filed a bug for this in the specification repo: https://github.com/CycloneDX/specification/issues/147
Unfortunate, but it may take some time for the schema to be updated. For now you could comment out the properties in valid-vulnerability.xml (but not the JSON file) and regenerate the snapshots. That should make the test pass.

Yep, discovered a bug. Just wanted to check with my teammate that I wasn't crazy. Ok, going to add new commit now.

It points to lack of tests.

Thanks for merging @nscuro . Any idea when this can be released as a v0.5.3 so we can use it? If easy to do, would it be possible to release today so I don't have to code a workaround on my side and then undo it? 😉

I'm on the go currently but I'll most likely release v0.6.0 later today. Give me 1-2 hours.

@desenna Just pushed v0.6.0. Thanks again for your PR!

@desenna Just pushed v0.6.0. Thanks again for your PR!

Thanks @nscuro !!


Error if variable is null

I got this error when call htmr with null variable, it's because this variable's value haven't set in redux store, I suggest maybe htmr could catch null variable & return empty string instead.
htmr.min.js:1 Uncaught TypeError: Cannot read property 'trim' of null
    at module.exports (htmr.min.js:1)
    at TopUpUploadPaymentProofModalContainer.render (TopUpUploadPaymentProofModalContainer.js:33)
    at finishClassComponent (react-dom.development.js:10249)
    at updateClassComponent (react-dom.development.js:10226)
    at beginWork (react-dom.development.js:10605)
    at performUnitOfWork (react-dom.development.js:12573)
    at workLoop (react-dom.development.js:12682)
    at HTMLUnknownElement.callCallback (react-dom.development.js:1299)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:1338)
    at invokeGuardedCallback (react-dom.development.js:1195)

IMHO, it is better to return error so that we realize that the variable is null.
If it returns an empty string, we would have some difficulties in debugging when we accidentally passing a null value and it display nothing.


Potential bug in cross_attentive_regularization for joint-s2t

🐛 Bug
I think there is a bug in how the Cross-Attention Regularization (CAR) is applied in the joint speech-to-text task.
According to the equation (3) in the paper "Improving Speech Translation by Understanding and Learning from the Auxiliary Text Translation Task", the teacher states in the Cross-Attention Regularization (CAR) are coming from the text representations.

But it seems that in the code for the s2t_dualinputtransformer.py, the default is the opposite, meaning that the teacher states are coming from the speech representations.

The correct behavior (teacher=text) can be used with setting the argument cross_attentive_loss_reverse, but this is always set to False.

To induce the behavior according the paper, swapping lines 529-534 with 536-541 should work.
To Reproduce
I did not try to reproduce any error, I think both ways of applying CAR would work but the one described in the paper is not the default.

@yuntang
Hey Yun, could you have a quick look at it?


WIP: gcc-arm-embedded: add version 11.2

Newer GCC version for arm embedded development
Description of changes
Added a nix expression to build GCC 11 for arm embedded development. I'm not sure, I think an entry in all-packages.nix might still be missing for it to take effect?
Tested: Binaries work as expected.
Still open to do: Meta information, maintainers.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux

[ ] Tested, as applicable:
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking

[X] Fits CONTRIBUTING.md. (hopefully)

Newer toolchain version 11.3 (Rel1) is already available.


v0.3.3

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   67.97%   67.97%
=======================================
  Files          15       15
  Lines         818      818
=======================================
  Hits          556      556
  Misses        262      262

Impacted Files
Coverage Δ

bowtie/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 658f4ff...4ef694e. Read the comment docs.


Small error in documentation about including from source

Could it be that this is a small mistake installation instructions to include AudioKit from source?:
"In the Build Phases tab, add AudioKit.framework in Target Dependencies for your target. Also add AudioKitUI.framework as needed."
From: https://github.com/audiokit/AudioKit/blob/master/Frameworks/README.md
I don't see Target Dependencies under the Build Phases tab. I think it should be Frameworks, Libraries and Embedded Content under the General tab.

Tne README file is just like source code, it can be edited by you and you can make a pull request. Your update is valid and will be accepted.

I'll do it this week. I might also have a few other fixes for some issues I encountered related to AKAppleSequencer.


Add action for background box for scale bar overlay

🚀 Feature
#4511 added some really cool functionality to the scale bar, including a translucent box for improved visibility when overlaid on certain images. I totally missed it at the time and I was today years old when I discovered that functionality. 😂 A strong reason for this is that there's no corresponding toggle in the View>Scale Bar menu. We should add one! Hopefully it is not too hard to do by modeling it after the existing toggles (visible, colored, and ticks).

Yeah! Here's the implementation PR: https://github.com/napari/napari/pull/4511
There's color options too (and units of course).
Would actually be nice to have a widget for setting those. 👀

There's color options too (and units of course), so simple toggle action is a start, but would actually be nice to have a widget for setting those. 👀

Yes, I just wanted to keep this one issue small. 😅 Actually it would be good to have some magicgui providers for particular types of data, e.g. color picker for a color, then we could have actions that require color in the menus and they would just pop up a color picker on demand — and all would use the same code. Ditto for simple stuff like e.g. integers/strings (projection axis picker, or stacking axis picker.)

There's color options too (and units of course), so simple toggle action is a start, but would actually be nice to have a widget for setting those. 👀

Units should be inherited from layer metadata.


Dummy Point Surfacing SOP for testing purposes

Signed-off-by: Nick Avramoussis<EMAIL_ADDRESS>@jmlait I haven't tried to use this SOP since the initial PR which was a while ago - it still builds and looks okay but let me know if you have any issues

I spoke to soon, it doesn't build... I'll fix these soon

Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good for this to be merged more or less as-is. There are a few other small things - renaming the methods to make them a bit more descriptive (rasterZbP), removing the redundant inline statement on the templated methods, tidying up some the parameters and tooltips and ideally making this a compiled SOP instead of using duplicateSourceStealable().
This can be done as a later change after this has been merged, but it would also be good to support rasterizing multiple VDB points grids into a single level set and to add streaming support.

Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good for this to be merged more or less as-is. There are a few other small things - renaming the methods to make them a bit more descriptive (rasterZbP), removing the redundant inline statement on the templated methods, tidying up some the parameters and tooltips and ideally making this a compiled SOP instead of using duplicateSourceStealable().
This can be done as a later change after this has been merged, but it would also be good to support rasterizing multiple VDB points grids into a single level set and to add streaming support.

Thanks for the feedback - I agree with everything you've said but this was never designed to be a feature ready SOP, only to provide the necessary hooks in Houdini so people could test. If you think this is actually worth making feature complete (i.e. native SideFX support) then I'd want to go back and re-write this/re-work the UI entirely - but I'm also not sure that's worth doing until we've figured out how best to expose all these raster tools in Houdini?

Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good for this to be merged more or less as-is. There are a few other small things - renaming the methods to make them a bit more descriptive (rasterZbP), removing the redundant inline statement on the templated methods, tidying up some the parameters and tooltips and ideally making this a compiled SOP instead of using duplicateSourceStealable().
This can be done as a later change after this has been merged, but it would also be good to support rasterizing multiple VDB points grids into a single level set and to add streaming support.

Thanks for the feedback - I agree with everything you've said but this was never designed to be a feature ready SOP, only to provide the necessary hooks in Houdini so people could test. If you think this is actually worth making feature complete (i.e. native SideFX support) then I'd want to go back and re-write this/re-work the UI entirely - but I'm also not sure that's worth doing until we've figured out how best to expose all these raster tools in Houdini?

I think it absolutely could be a feature-ready SOP, there's a real gap in our toolset for a SOP like this. I think to make progress here and side-step the issue of rasterization, it would be worth introducing a Surfacing SOP like this that has a narrower scope and specializes in turning points into an SDF and not also rasterizing arbitrary attributes or generating fog volumes or masks. As I see it, it's an open source equivalent to the VDB from Particle Fluid SOP (which I believe also does not do arbitrary attribute rasterization) and it's through this node that we can introduce any other surfacing algorithms like anisotropic surfacing. After all, there's still the VDB from Particles SOP which has broader scope, like doing arbitrary attribute rasterization.


Question about Category and Genre

I am trying to fit my needs in with the existing structures to avoid making too many code changes.
My document trees are of the form e.g.:

\CircularStore\eBooks\Cooking\Chinese\Dim Sum\ or
\CircularStore\eBooks\Machining\Tools\Tool to Make\

I am thinking that if I add a Root parameter to my pdf importer I could end up with a Genre list using \CircularStore\eBooks as Root. The Genre list could then be parsed from the remaining directory structure. The top level would have category_ prepended

category_Cooking
Chinese
Dim Sum

Keep in mind that I will be extracting (already have this working) the list of Genre actually used from the Index. I have the top level working, I use IndexReader to get all the Genre and pull out the category_ ones for the top level. I have no reasonable other way to infer Genre/Category from the Pdf files.
Is that along the lines of the two or more level Genre you have implemented?

I've done Genres rework just now. Needs more testing but seems to work.
You can have as many levels as you want. Changes are in #16 as usual.

I merged the changes successfully, thank you!
Trying to get my head around the Genre tuple. If I have a single genre for a document, is it simple case of a Genre structure with Name filled in and an empty Child Genre?

If I have a single genre for a document, is it simple case of a Genre
structure with Name filled in and an empty Child Genre?

That's right: new Genre { Name = "My top level genre" }. Genre is a
just linked list structure.
2017-02-10 6:26 GMT+03:00 Gerrit Visser<EMAIL_ADDRESS>
I merged the changes successfully, thank you!
Trying to get my head around the Genre tuple. If I have a single genre for
a document, is it simple case of a Genre structure with Name filled in and
an empty Child Genre?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/DeniSix/DotOPDS/issues/17#issuecomment-278848097, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABAm6eXZQ6iKY7Em_pZFnrDMpJEEM-mcks5ra9jRgaJpZM4L6PPs
.

--
Yours sincerely,
Denis Shemanaev
Skype: denis.shemanaev

A super big Thank you!!!! This solution works perfectly for me. I use:
import pdf \<rootdir> \<maingenre>
on each of my core directories to build the Index. Genres are added based on the directory path components (after removing the <rootdir> part.  If the file is at the root level then only the <maingenre> gets added. If Keywords exist in the pdf then they are added as well.
Now my only small problem is adding Title and Keyowrds for those files where they are missing :-( Tedious but doable.

👍


Support MultipartBody for request matcher / expectations

For my application, i am trying to write Mock tests for testing Upload  functionality , i am facing difficulties while writing.
//From my Application REST Client Upload functionality expects as stated below:
Remote Address:
<IP_ADDRESS>:8080
Request URL:
http://localhost:8080/pincode/upload
Request Method:
POST
Status Code:
200 OK
Response Headers
Access-Control-Allow-Headers:
x-requested-with, Content-Type, Accept
Access-Control-Allow-Methods:
POST, GET, OPTIONS, DELETE
Access-Control-Allow-Origin:
*
Access-Control-Max-Age:
3600
Content-Type:
application/json;charset=UTF-8
Date:
Wed, 20 May 2015 04:03:45 GMT
Server:
Apache-Coyote/1.1
Transfer-Encoding:
chunked
X-Application-Context:
application
Request Headers
Accept:
/
Accept-Encoding:
gzip, deflate
Accept-Language:
en-US,en;q=0.8
Connection:
keep-alive
Content-Length:
1013
Content-Type:
multipart/form-data; boundary=----WebKitFormBoundary7LuAbBLvdBX2myhL
Host:
localhost:8080
Origin:
http://localhost:9000
Referer:
http://localhost:9000/
User-Agent:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36
Request Payload
------WebKitFormBoundary7LuAbBLvdBX2myhL Content-Disposition: form-data; name="file"; filename="pincode_master_data.csv" Content-Type: text/csv
//Please help me in writing Mock test for the above requirement
//I tried writing as below, but it is not working
new MockServerClient("<IP_ADDRESS>",1080).when(
request()
.withMethod("POST")
.withPath("/pincode/upload")
.withHeader("Content-Type", "multipart/form-data")
.withHeader("Content-Disposition", "/home/ravi/Downloads/pincode_master_data.csv")
                  )
                 .respond(
                          response()
                          .withStatusCode(200)
                  //.withHeader("Content-Type", "application/json;charset=UTF-8")
                  .withBody("Hi file is Uploaded")

            );

// I am testing this Mock test, using Rest-assured as stated below
//Making Use of given().contentType().multiPart().when().post() for Testing Search with URL
com.jayway.restassured.response.Response response_Upload = given().contentType("multipart/form-data").multiPart(new File("/home/ravi/Downloads/pincode_master_data.csv")).expect().response().when().post("/pincode/upload");
String responseBody_Upload = response_Upload.getBody().asString();
System.out.println("Response for Upload Query");
System.out.println(responseBody_Upload);
//Data in /home/ravi/Downloads/pincode_master_data.csv
//===========================================
Pincode, Region Code, Area, Area Code, City, City Code, State, State Code, Cluster Code
110021, MLNCR, ANTARIKSH, ANT, NEWDELHI, DEL, DELHI, DEL, NULL
110022, MLNCR, CPBRANCHOFFICE, CP, NEWDELHI, DEL, DELHI, DEL, NULL
110023, MLNCR, ANTARIKSHBHAVAN, ABC, NEWDELHI, DEL, DELHI, DEL, NULL
110024, MLNCR, ANTARIKSHBHAVAN, ABC, NEWDELHI, DEL, DELHI, DEL, NULL
110025, MLNCR, RAJENDRAPLACE, RAJ, NEWDELHI, DEL, DELHI, DEL, NULL
110026, MLNCR, CPBRANCHOFFICE, CP, NEWDELHI, DEL, DELHI, DEL, NULL
110027, MLNCR, CPBRANCHOFFICE, CP, NEWDELHI, DEL, DELHI, DEL, NULL
110028, MLNCR, RAJENDRAPLACE, RAJ, NEWDELHI, DEL, DELHI, DEL, NULL
110029, MLNCR, WAZIRPUR, WZR, NEWDELHI, DEL, DELHI, DEL, NULL
110030, MLNCR, DELHICANTONMENT, DCT, NEWDELHI, DEL, DELHI, DEL, NULL
110031, MLNCR, ANTARIKSH, ANT, NEWDELHI, DEL, DELHI, DEL, NULL

Sorry for the delay but are you still having issues?

Have you tried using the MockServer Proxy to record you requests?  Although record-replay is an anti-pattern the MockServer Proxy will generate the Java code (or JSON) for expectations once requests have been recorded.  You can then modify these as required to make them suitable for test expectations and copy them into your test code or test setup code.  Please see http://www.mock-server.com/proxy/record_and_replay.html

Closing this ticket now

I think the problem here is, that there is no MultipartBody that decodes a multipart body and allows to formulate expectations for the parts.
I tried this myself after a question in the Gitter room and the closest i came was a substring or regex match.
And looking at the expectation OP tried to write here, he tried to match "headers" (´Content-Disposition`) of the multipart-part, besides that the value was wrong.
Can this be opened as request to add support for multipart bodies or should a new ticket be opened?

new feature requests now prioritised on Trello, so closing issue in GitHub, only bugs or unaccepted feature requests will stay in GitHub, so that new feature can be more effectively managed, see: https://trello.com/c/zt7loffA/14-add-support-for-multipartbody


Expand operators before writing JSON

When a Decapode has composed operators, it will successfully serialize in/ out of JSON. However, when an op1 is a vector of symbols (i.e. a composed operator), it will be parsed in as a Symbol("["d","d"]"), which is not the desired behavior.
This problem can be immediately resolved by calling expand_operators before write_json_acset, but a better solution would overload read_json_acset for the special case of a vector of symbols.

With intertypes, we can serialize an attribute that is a vector of symbols.


fix drive example + add debug gems for dev

To upload_source me must setup full path to file
$ bundle exec ruby samples/drive/drive.rb
/usr/local/rvm/gems/ruby-2.0.0-p598/gems/hurley-0.1/lib/hurley/multipart.rb:33:in `initialize': No such file or directory - drive.rb (Errno::ENOENT)
	from /usr/local/rvm/gems/ruby-2.0.0-p598/gems/hurley-0.1/lib/hurley/multipart.rb:33:in `open'
	from /usr/local/rvm/gems/ruby-2.0.0-p598/gems/hurley-0.1/lib/hurley/multipart.rb:33:in `initialize'

So fix it + add debug gems to Gemfile

Looks like pry-byebug won't work with jruby and needs to be moved into the platform section along with redcarpet, yard, etc.
Also, please confirm you signed the CLA as mentioned in CONTRIBUTING.md :)
Thanks :)

@sqrrrl , fixed it in forced commit.
Also I add additional email to google account, so CLA must be valid.


Example of passing these parameters?

Would it be possible to go into some more detail about how these parameters are passed at runtime?
This is a great start but I'm not sure where to go from here.
A link to an existing document with this sort of example would be fine, I wasn't able to find one.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bf75315-da09-2cf9-6db5-d12fcc804283
Version Independent ID: bf4deb1b-fe88-a9cb-3605-0500a60fb882
Content: Parameterize linked services in Azure Data Factory
Content Source: articles/data-factory/parameterize-linked-services.md
Service: data-factory
GitHub Login: @douglaslMS
Microsoft Alias: douglasl

@dcbrown16
Thanks for the feedback! We are currently investigating and will update you shortly.

@douglaslMS could you take a look at this?  It might be better to have a non-video example if it doesn't already exist.

@dcbrown16 When you ask about "how these parameters are passed at runtime," are you asking how you provide values for the parameters at run time, or how Data Factory passes them internally? I assume the former, or something close.

Hi @douglaslMS, yes just a link or example that shows where these values go once you are done setting them.
I've also asked a DL and received no response - is there a way to use parameters to say "connect to this instance or this instance like a load balancer?" Apparently this was possible in v1 using something like the following:
data source="
(DESCRIPTION=(CONNECT_TIMEOUT=35)(TRANSPORT_CONNECT_TIMEOUT=30)
(ADDRESS_LIST=
(ADDRESS=(PROTOCOL=TCP)(HOST=)(PORT=1521))
(ADDRESS=(PROTOCOL=TCP)(HOST=)(PORT=1521))
(LOAD_BALANCE=yes)
)
(CONNECT_DATA=(SERVICE_NAME=))
)";
user id=;
password=;

Let me know if DF Team is not aware. It took a day for me ,to utilize this feature while executing a pipeline

@dcbrown16 I have learned that the load balancing is not supported at this time in ADF v2.
I see now that the existing article is light on how you pass values at run time to the parameters that you've created. Even in the video, Gaurav only mentions this briefly. I am following up.

@dcbrown16 @HarsimranjeetSingh I see that we don't tell a complete and easy-to-follow story about the use of parameters in Data Factory v2. I am going to create a backlog item to add content for this, but as I'm not sure when I'll get to that, I am going to request that this issue be closed.
The typical use of parameters at the present time is with triggers - that is, a trigger supplies values, through parameters, to other pipeline elements like linked services. In the present article on which you commented, Parameterize linked services in Azure Data Factory, we are creating a parameter to receive a value for the linked service. In this other article - related concept but not part of the same example - a trigger is providing a value for a parameter - in this case, a blob filename and path.
Again, I look forward to documenting this more clearly. Thank you for bringing this to our attention.

Thanks @douglaslMS, I appreciate the quick follow-through about load balancing and understand that it may take some time to update the parameter docs.
Incidentally, it sounds like the customer I'm working with was able to get the parameters working fine, but what they really wanted to do was load balance, so I'm fine to close with the current information. We'll look forward to additional info in the future.


Error when trying to rename or delete folder with git repo inside

Issue Type: Bug

Open some folder A with VSC
Create a new folder B inside that folder A.
Initialize a new empty git repository inside folder B.
Try to delete or rename B from inside VSC. Either through the VSC-Explorer or through the embedded command line tool. Rename will fail completely, resulting in a permission error. Deleting is not able to move to recycle bin, only deleting permanently. Elevating permission level to admin does not fix the issues.

Error when renaming:
Error: EPERM: operation not permitted, rename 'e:\path\to\folder' -> 'e:\path\to\renamedfolder'
Errors/Dialogs when deleting:

Dialog asking if I'm sure I want to delete? (I click yes)
Win-Dialog saying that access was denied, it needs elevated permission. (I grant permission)
typical Win-Dialog to give VSC admin permission (I grant permission)
Dialog saying deletion failed, asking if I want to permanently delete instead.

I tried integrated powershell, terminal and right click folder -> rename, all fail inside of VSC.
Strangely deleting and renaming do work if I do them fast enough after starting VSC, while it is still loading my folder I assume?
On the other hand using the Windows Explorer or the Windows Terminal to delete or rename works flawlessly, without any need for admin permissions.
My guess would be it's something about Source Control doing weird things?
 You can annotation those referenced before the change that filename

When the git repository is created in the B directory, VS Code sets up a file watcher on the .git folder inside the B folder. This file watcher is necessary to update the "Source Control" view. What I believe is happening here is that the file watcher locks the B directory and that is why it cannot be renamed nor deleted. To delete/rename the folder you would have to close the VS Code window to release the lock. This is currently by design on Windows, and I am not aware of any plans to make any changes to this in the near future.


Add documentation for nested selectors

The documentation for nested selectors was missing, so I read the relevant tests and comments to figure out how it works exactly and added the documentation. I'm differentiating between three types of nested selectors:

regular selectors
class selectors from css
component selectors from styled

The first two require a leading &, but component selectors don't work that way, the & must be omitted. This inconsistency should probably be fixed at some point.
This is a part of #219.

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   90.29%   90.29%
=======================================
  Files          20       20
  Lines         969      969
  Branches      261      261
=======================================
  Hits          875      875
  Misses         76       76
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a82394...d29bbcb. Read the comment docs.

Ok, I added a sentence explicitly explaining why to add the dot . in case someone misses it when reading the code snippet. I also squashed everything into a single commit, I hope that's a desired practice.


Cast a void pointer to char* before subtracting it

If both operands are pointers, and the operator is -, the pointers are subtracted and the result is divided by the size of the type pointed to by the operands. It is an error if the pointers point to different types. The type of the result is ptrdiff_t.

See DMD's PR

@LemonBoy Codecov is complaining, can you please manually verify that the line changed is covered?
Thanks

Looks like the those lines weren't covered even before this patch, what should I do?

@LemonBoy Please add a unit test

Well, I tried

Huh, must be a coverage bug.

Auto-merge toggled on


Add a reduction-v3 strategy that brings us closer to properly handlin…

…g ?.
This also cherry-picks the following LLVM commits:
  fd4214ff55cc698bb0841083e419343e4e2966f2
  06ca5c81a4d88d9c33018d5a33e38c449109e5d6
  23a057fbc423ce3f277efc54631a8a9afce85081
  93bbcffc7e9dbb30d5cd9002bc136dd3d7df950d

@antiagainst @hanhanw for integration ping.

There is an integration going on right now https://github.com/iree-org/iree/pull/11506; just have one failing CPU test to fix. Looks these commits are largely disjoint with the integration; let me see if I can roll them into #11506.

https://github.com/iree-org/iree/pull/11506/commits/8a37b38996573c919b27174d30aa475b2268d549 to pull in these commits.


[CI] Skip RISC-V compliance test or short tests

It would be good if CI can skip RISC-V compliance test if no vendored-in ibex or rv_ibex_core is changed in the PR. The RISC-V Compliance test takes majority of the entire CI run time.

[Reposting the from the Slack #software channel]
If we enable the RISC-V compliance test in our DV nightly regressions, is there still a need to run it in CI?

RTL changes other than Ibex can break riscv-compliance, in particular anything around tilelink or memory (I believe we had an issue with this in the past). So I'd prefer not to run it on Ibex vendoring only.
It's also possible SW changes would break it, though that's less of a concern as such things probably don't mean a SW bug but rather the riscv-compliance setup needing to adapt to the SW changes.
I think a nightly run could be a good compromise provided failures of it are quickly flagged up so we can get it fixed.
I'm going to see what I can do about speeding it up today. The run-time is oddly variable but I'm not sure there's much we can do about that (presumably to do with what physical system azure ends up running it on).

@gkelly replying to your slack question here to avoid one discussion across multiple channels

You can see the results of my experiments in parallelising the runs in #1987.
I've split it up into two jobs, one to run the large suite (rv32i) and the one to run the rest. I've also tried using -j2 on make which seems to work well.
With that performance I think it's reasonable to include this in normal CI. I need to tidy up my PR (plus incorporate some minor tweaks from review feedback from the original PR) but that should be good to go in some time today.

The one issue with parallel make is the log output is somewhat confusing, I'll see if I can alter the pytest logging output to give an indication of the test binary.

I see a roughly 4 minutes increase in CI latency, which equals to roughly a 20 percent increase.
So it's not for free, but let's give it a try and see how it goes. I expect the dominating factor to be the FPGA build in the near future as we grow our design, so we'll need to revisit questions and expectations around that anyways. (We're also not running into capacity issues with parallel builders most of the time currently, so running things in parallel shouldn't increase queuing for other jobs too much.)

I'm am slightly puzzled it causes a latency increase. The FPGA build job takes longer than running the tests now with the latest changes and they should be able to start at the same time (it's possible the FPGA build job gets the single agent capable of running verilator/vivado builds before the earlgrey verilator is built but the verilator build generally seems to win that).
If the agent pool that can run the riscv compliance tests is fully utilised whilst the FPGA build starts then that will increase latency but in general we'd expect that to have capacity where the FPGA/verilator build agent is the bottleneck.
Latest PR incorporating some minor tweaks plus the parallelisation is #1990

Upon a closer look, the latency in an non-queued case shouldn't be impacted, there's a small margin between the FPGA job (12 min) and the build verilated sim + run verilator jobs (2:30 + 7:45). (https://dev.azure.com/lowrisc/opentitan/_build/results?buildId=11202&view=results)
However, we are now more sensitive to queuing in the Default builder, which is needed for the FPGA job and the verilated sim build job.
But that's nothing we can solve here, the scope and approach of your solution is the right one IMO. Thanks for following up on all of that!

Thank you guys for fast feedbacks. Let me close this issue as Greg followed with a PR.


German translation

template.txt
100% done, maybe some translations will need revision...
I still don't know how to make a pull request...

100% done

No. 5 strings with the plural form are not translated. Is this your translation?

de.txt
I overlooked those plurals. Now it should be completed.

Is this your translation?
Positive

Thanks, I will include your translation in the next version.

maybe some translations will need revision

If you decide to revise the translation, attach it here in this issue


System handles data of the same name (Duplicates or updates)

The system is now capable of handling duplicate dockets, comments, and documents:

If the json file already exists, the system will check if the two files are the same. If this is true, the system will not save the job and move on. Here is an example of what the docs will say if this occurs:

mirrulations-work_server-1  | Job received: dockets for client:  1
mirrulations-work_server-1  | Work_server received job for client:  1
mirrulations-work_server-1  | Directory already exists in root: /data/EBSA/EBSA-2005-0001
mirrulations-work_server-1  | Data is a duplicate, skipping this download
mirrulations-work_server-1  | SUCCESS: client:1, job: 1

If the json file already exists but is different from the one waiting to be saved, the newest file will be saved with an integer next to it. This integer will keep increasing as different "duplicates" are saved. Here is an example of the logs:

mirrulations-work_server-1  | Job received: dockets for client:  1
mirrulations-work_server-1  | Work_server received job for client:  1
mirrulations-work_server-1  | Directory already exists in root: /data/USN/USN-2005-0001
mirrulations-work_server-1  | Writing results to disk
mirrulations-work_server-1  | Wrote job USN-2005-0001(1).json, job_id: 39, to USN/USN-2005-0001/USN-2005-0001.json
mirrulations-work_server-1  | SUCCESS: client:1, job: 39

Tests are still in progress. I could use some help with them if anyone is available.

This work has been moved to #69


Add "all" platform

[x] This software or dataset is not more easily backed up by other systems (e.g. a conda package which could more easily be mirrored by a conda mirror)
[x] This software or dataset's license allows us to distribute it. If possible please link to it.
[x] This software or dataset is related to the sciences, galaxy, or similar areas.

(Leaving this open a few -- I'd like to swap 'linux' to 'all' or something more reasonable for this packaging .whl since it's cross platform)

Usually we use src whenever it is cross-platform compatible.

@erasche Yep, but that'd conflict with the other entry that's actually the source.  Talked to nate about it and decided to add 'all' for cross-platform non-source code packages.


PWM Mode Not Producing Correct Frequency

I just received my BP6 in the mail and have started to tinker with it.  I promptly connected it to my o-scope (SDS-1104X-E) to measure the PWM outputs.  Used the following terminal session to startup the PWM generator:
DIO> G
Generate frequency
Choose available pin:
 0. IO0
 1. IO1
 2. IO2
 3. IO3
 4. IO4
 5. IO5
 6. IO6
 7. IO7
 x. Exit
 > 0
Period or frequency (ns, us, ms, Hz, kHz or Mhz) > 10kHz
Frequency: 10.000kHz = 10000Hz (10.00kHz)
Period: 100000ns (100.00us)

Actual frequency: 10000Hz (10.00kHz)
Actual period: 100000ns (100.00us)

Duty cycle (%) > 50%
Duty cycle: 50.00% = 50000ns (50.00us)
Actual duty cycle: 50004ns (50.00us)
Divider: 16, Period: 12499, Duty: 6250

Generate frequency: Enabled on IO0

The result was a frequency of 12kHz as is seen in the following screen capture from my scope:

Version information:
Bus Pirate 6 REV1
Firmware main branch (2024-07-27T14:08:40Z)
RP2350 with 512KB RAM, 128Mbit FLASH
S/N: 32A6968E95BBEBDC
https://BusPirate.com/
Storage:   0.10GB (FAT16 File System)

Configuration file: Not Detected
Available modes: HiZ 1-WIRE UART HDPLXUART I2C SPI 2WIRE DIO LED
Active mode: DIO
Display format: Auto
Data format: 8 bits, MSB bitorder
Pull-up resistors: OFF
Power supply: ON (3.3V/3.29V)
Current limit: OK (0.4mA/100.0mA)
Frequency generators:
IO0: 10.000kHz, 50.00% duty cycle

Thanks for reporting this.  I attempted to reproduce this with
commit 0b52ef7e3dea8f9243c0baf5e895b6c1dcd6be0a.
Repro steps in full
HiZ> m 8
Mode: DIO

DIO> W 3.3
3.30V requested, closest value: 3.30V
Current limit:Disabled
Power supply:Enabled
Vreg output: 3.3V, Vref/Vout pin: 3.3V, Current: 3.1mA

DIO> G
Generate frequency
Choose available pin:
 0. IO0
 1. IO1
 2. IO2
 3. IO3
 4. IO4
 5. IO5
 6. IO6
 7. IO7
 x. Exit
 > 0
Period or frequency (ns, us, ms, Hz, kHz or Mhz) > 10kHz
Frequency: 10.000kHz = 10000Hz (10.00kHz)
Period: 100000ns (100.00us)

Actual frequency: 10000Hz (10.00kHz)
Actual period: 100000ns (100.00us)

Duty cycle (%) > 50%
Duty cycle: 50.00% = 50000ns (50.00us)
Actual duty cycle: 50004ns (50.00us)
Divider: 16, Period: 12499, Duty: 6250

Generate frequency: Enabled on IO0

DIO>

My Rigol DS1054 showed the output to be spot-on at 10kHz, 50% duty cycle.
Perhaps this was fixed between when you filed this issue and now?
If not, please re-open this issue, and if I missed any repro steps, please let me know!


Recompiled to plugin version 222

Enabler to IDEA 2022.2.1
Fix StringExtensions package
Remove wildcard

Thanks for the contribution 🙏🏻


Clean up transactions that were proposed in blocks but did not make it on chain

This PR closes #95.
When a new changeProposer event is received, check if we were the last proposer.
If we are the last proposer, use the on-chain L2 information to reset any transactions that we have included in proposed blocks that did not make it on-chain before the currentProposer was rotated away from us.

Runs fine on its own but fails on merging with master.  Maybe a rebase and see what happens?


Fix for latest eurydice

This contains the fixes for libcrux to work with the latest version of the toolchain -- this just needs additional work to update libcrux's CI

Upgrading to latest Eurydice should give more stable hash names.

I fixed this in #622


App launches night theme, UI does not change

App launches night theme, UI does not change
Originally posted by @mzl1988 in https://github.com/Rannie/flui/issues/1#issuecomment-567407388

Hi @mzl1988,
In earlier versions, some widgets of flutter were not friendly to dark mode support.
FLUI will start to adapt to dark mode after migrating to flutter v1.12+ , thanks.

Already support dark mode.


macvim flashback in high Sierra 10.13.1 (17B48)

I'm afraid I don't quite understand. Can you provide more details about what you're doing and what problem you're seeing?

I just updated to high sierra 10.13.1(17B48), then every time i open macVim,  i just flashback. I don't know why. I have reinstalled MacVim, but MacVim still flashback every time i open it.

Hi. I dont know the solution to your problem. However I want to ask you,have you observed any reduction in battery life? My battery has been draining faster after updating to 10.13.1.

I guess I'm unsure what you mean by "flashback?" Is it crashing? If so do you have crash reports in ~/Library/Logs/DiagnosticReports you could provide?
This may be a duplicate of https://github.com/macvim-dev/macvim/issues/587.

@petertsengruihon Does it still an issue?

@eirnym  It seems work well now in Mojave after upgrading the system....

@tsungruihon There could be many factors which solved the issue: system upgrade, plugin upgrade, etc.
Could the ticket be closed for now?

@eirnym yeah sure.


⚠ Bofrost.lu has degraded performance

In 79ee6af, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1035 ms

Resolved: Bofrost.lu performance has improved in acde71d after 42 minutes.


Set memory and cpu requests and limit values for all containers

Relint is currently working on a scaling and Quality of Service (QoS) set of stories.
We are targeting 1.0 to be configured out-of-the-box as a "developer" edition aimed at those users who want to kick the tyres.  As part of this, we would like to set limits on mem/cpu.
Since a "developer" edition may not be preferred by everyone, we want each component to be configurable to scale both horizontally (replicas) and vertically (mem/cpu).  This will also allow users to deliver a Guaranteed QoS when required (although we are recommending that all of our pods and containers use the Burstable QoS) As part of this we would like to ask you to do several things:

consider which of your pods/containers you would like to expose for scaling properties for.
expose said configuration properties.
sets mem and cpu values for all containers in order to provide as much meta-data to k8s as possible so that its scheduler can do as good a job as possible. This PR is an initial attempt at setting these values, although we know you are much more likely to have insight into your components mem/cpu requirements than our guess.

If you have any questions or concerns, please let us know! Thanks!
#174462927
Co-Authored-By: Angela Chin<EMAIL_ADDRESS>

thanks for this! the only change I'd make to what's here is:

worker, deployment_updater, and clock should all be allowed 1000m CPU, and request 300m. They're GIL'd and sometimes do compute-intensive tasks, but are mostly idle.

are y'all interested in adding the configurability to this PR? maybe to build some empathy for how cf-for-k8s component teams add optional config parameters to cf-for-k8s?
Things that should be configurable:

cf-api-server instance count
worker instance count
clock memory limit (and request?)
deployment updater memory limit (and request?)
cf-api-controllers memory limit (and request?) AND CPU limit/request

I'm not sure if this is in-scope for this PR but if we're talking about automatic horizontal scaling...
One of the more dramatic failure modes I've seen in CF-for-VMs is the behavior of the platform when the shared internal database runs out of configured connections. If UAA can't get connections then the whole control plane becomes inaccessible. Does kubernetes have any means of taking this shared resource into account in its scaling decisions?

are y'all interested in adding the configurability to this PR? maybe to build some empathy for how cf-for-k8s component teams add optional config parameters to cf-for-k8s?

We've worked on a proposal for the Scaling Interface  and it's under review now. So for now, we'd like to place configurability out of scope.

worker, deployment_updater, and clock should all be allowed 1000m CPU, and request 300m. They're GIL'd and sometimes do compute-intensive tasks, but are mostly idle.

Done ✅

I'm not sure if this is in-scope for this PR but if we're talking about automatic horizontal scaling...
One of the more dramatic failure modes I've seen in CF-for-VMs is the behavior of the platform when the shared internal database runs out of configured connections. If UAA can't get connections then the whole control plane becomes inaccessible. Does kubernetes have any means of taking this shared resource into account in its scaling decisions?
If not, enabling horizontal autoscaling seems like it creates an availability threat to the platform, even as it resolves another one.

Great thoughts, Nat. They're out of scope for this minimal PR but I'd recommend dropping these thoughts in #cf-for-k8s slack channel to get a conversation going.
FWIW, our initial take is that this is something Kubernetes should help handle. We'd hope the Horizontal Pod Autoscaler would help here


Add support for playing against AI

done. https://github.com/lipinskipawel/LAN-Game/commit/d07e017288f417a268c80dde82b84a2f19d80159


Trouble getting account info from B2C token in componentDidMount

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[ x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Framework

[ ] Angular
[x ] React
[ ] Other

Description
I have an API call that I would like to make as soon as the logged in user has been authenticated to populate a list of items specific to the user. Part of the query string in the api call is information that I am trying to grab from the claims in the token returned by B2C but I am having trouble handling the promises.
When I am logged in, I am able to console log the claim that I am looking for. However, when I try to go through the complete auth flow, it tells me that the claim I am looking for is undefined which leads me to believe that the code in the promise is being called before the login is complete and the token is cached.
Error Message

MSAL Configuration
export const msalConfig = {
    auth: {
        clientId: 'my id',
        authority: 'https://mytenant.com/mytenant.onmicrosoft.com/B2C_1_signupsignin1',
        knownAuthorities: ['mytenant.b2clogin.com'],
        redirectUri: 'http://localhost:3001',
        postLogoutRedirectUri: 'http://localhost:3001'
    }
};

Reproduction steps
class App extends Component{
    static contextType = MsalContext;

componentDidMount(){
        this.context.instance.handleRedirectPromise()
        .then((tokenResponse) => {
            if (!tokenResponse) {
                const accounts = this.context.getAllAccounts();
                if (accounts.length === 0) {
                    // No user signed in
                    this.context.loginRedirect(loginRequest);
                }
            } else {
                // Do something with the tokenResponse
        }})
        .catch(err => {
            // Handle error
            console.error(err);
        })
        .then((res) => {
            console.log(this.context.accounts[0].localAccountId)
        });
    }
}

Expected behavior
Gain access to the localAccountId in the first index of the accounts array.
Identity Provider

[ ] Azure AD
[ x] Azure B2C Basic Policy
[ ] Azure B2C Custom Policy
[ ] ADFS
[ ] Other

Browsers/Environment

[ x] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

Regression

[ ] Did this behavior work before?
Version:

Security

[ ] Is this issue security related?

Source

[ ] Internal (Microsoft)
[ ] Customer request

In playing around with this a little bit more, I am seeing now that refreshing the browser is another way to trigger the "cannot read claim of undefined" error. This is not how I would expect this to work as it was my understanding that the token is cached (or could be retrieved) when needed. Eager to see what I'm doing wrong here.

@leskodan A couple points to note:

You should not call handleRedirectPromise yourself as this is done under the hood in the msal-react library. Instead if you need direct access to the response from a redirect please use the event API. This is called out in the FAQ
On the initial render after page load, context properties are not yet populated. You should use the inProgress context value to determine when it is safe to access the accounts. You'll find a class component example in our sample here

Hi @tnorling, thanks for the pointers. On the first note regarding the handleRedirectPromise, I was attempting to follow directions laid out about 2/3s of the way down the page in the "errors" wiki linked here.
I'll look into the "inProgress" context value. As a side note, since posting this issue, I've learned that Azure is having some issues at the moment with Active Directory at the moment: https://status.azure.com/en-us/status. They claim it is not effecting B2C, but at the moment, I can't even log into my apps that are authenticated against B2C.

@leskodan

On the first note regarding the handleRedirectPromise, I was attempting to follow directions laid out about 2/3s of the way down the page in the "errors" wiki linked here.

Right beneath that is a link to different directions if you're using msal-react. I see the confusion and I'll see what we can do to call this out more clearly.

@tnorling, thanks for the pointer, I'll be sure to read the docs more carefully next time.
That said, I am still having trouble getting this to work. My goal is to execute a login on app load but putting this method in the componentDidMount() of my App.js.
componentDidMount(){
        if (this.context.accounts[0] && this.context.inProgress === InteractionStatus.None) {
            this.context.instance.acquireTokenSilent({
                ...loginRequest,
                account: this.context.accounts[0]
            });
        }
    }

This does not trigger a login. I have successfully gotten this to work using a login button, I would like this to work on load in my class based App components so that I can set state with info called from my api immediately after authentication. Appreciate the help!

@leskodan This will not trigger a login. This will get you a cached token after you have already been logged in. If you need to login on page load you should check that there are no accounts instead of checking the first account and call loginRedirect or loginPopup instead of acquireTokenSilent

@tnorling, that makes sense, and I have tried the following code to account for this:
componentDidMount(){
        if (this.context.accounts[0] && this.context.inProgress === InteractionStatus.None) {
            this.context.instance.acquireTokenSilent({
                ...loginRequest,
                account: this.context.accounts[0]
            }).then((res) => {console.log(res.uniqueId)});

        } else {
            if(!this.context.accounts[0] && this.context.inProgress === InteractionStatus.None){
                this.context.instance.loginRedirect(loginRequest)
                .then((res) => {console.log(res.uniqueId)});
            }
        }
    }

My current issue is that my console.logs are not being fired which is where I would need to be grabbing the homeAccountId to call my api. Appreciate your continued help!

@leskodan The promise returned from loginRedirect is not expected to resolve as it will trigger a full frame redirect away from your page. If you just need the homeAccountId you can use this.context.accounts[0].homeAccountId inside the first if block. If you need to get the full response from loginRedirect you should register an event callback that will be run when you return from the auth server.

@tnorling gotcha. This still isn't working the way that I would expect unfortunately.
componentDidMount(){
        if (this.context.accounts[0] && this.context.inProgress === InteractionStatus.None) {
            this.context.instance.acquireTokenSilent({
                ...loginRequest,
                account: this.context.accounts[0]
            }).then((res) => {console.log(res.uniqueId)});
           console.log(this.context.accounts[0].homeAccountId) //Inserted to test access to homeAccountId
        } else {
            if(!this.context.accounts[0] && this.context.inProgress === InteractionStatus.None){
                this.context.instance.loginRedirect(loginRequest)
            }
        }
    }

When I navigate to the app, login is still not triggered on load. (I can get it to trigger if I change the if statements on the dev server, but not through a normal flow. Since I am using the AuthenticatedTemplate on my content (render function below), I just get a white screen. Similarly, the console log in the first if statement of my componentDidMount() is not working either.
render(){
        return(
            <ThemeContextWrapper>
                <AuthenticatedTemplate>
                    <MyContent/>
                </AuthenticatedTemplate>
            </ThemeContextWrapper>
        );
    }

I am wondering if I am simply trying to achieve functionality that isn't intended.

@leskodan Sounds like this component is mounting too early and InteractionStatus is not yet None. Does it work if you put this logic in componentDidUpdate?
An easier way to do this is by using MsalAuthenticationTemplate instead of AuthenticatedTemplate which will invoke login on page load if not already signed in. This is documented here and is demonstrated in our samples.

@tnorling , it does work if I put this code in componentDidUpdate(). HOWEVER, this causes infinite looping of the console log. That said, I think that confirms your theory of the component mounting too early (I'm assuming this isn't really meant to be used on the App.js component with conditional rendering).
Based on what you describe, it does sound like the MsalAuthenticationTemplate is the way to go over the AuthenticatedTemplate. I'll have to see if this works timing wise in terms of getting my id on componentDidMount(). Thanks!

To expand on that having refactored a bit:
By wrapping my render() in MsalAuthenticationTemplate and updating the `componentDidMount()' to:
componentDidUpdate(){
        console.log(this.context.accounts[0])
    }

This fires the console.log 3 times. Once undefined, and two more with the accounts[0] object (apparently coinciding with updates happening in the background). I'd like to find a way for this to only happen once so that my api call doesn't trigger multiple times.

@leskodan If you put your API call in a component underneath MsalAuthenticationTemplate in the component tree it will only ever render when a user is signed in. This way you can put your logic in componentDidMount and ensure it's run only once and has the account it needs.

@tnorling , that makes sense. I'm currently using the api call to set global state, so I would need to lift it up to my App.js component. I came up with this as well, not sure if it's best practice though haha:
componentDidUpdate(){
        if(this.context.accounts[0]){
            if(this.context.accounts[0].localAccountId !== this.state.userId){
                this.setState({userId: this.context.accounts[0].localAccountId}, () => {
                    console.log(this.state.userId)});
            }
        }
    }

This way, it will only update state if the account has switched. That said, it definitely adds additional logic from what you suggested.
Thanks for bearing with me through this!

@leskodan Great, glad to hear you got it working! Can we consider this resolved?

Yep, appreciate the help!


Fix: 'Object' object has no attribute 'text'

There is an error that crashes the game when there is an item either in the room or already in inventory and a say-style verb is used (i.e., SAY, CHANT, SING, UTTER, MUMBL). For example, "lamp say" results in the runtime error: AttributeError: 'Object' object has no attribute 'text'. This pull request fixes that issue.

Thanks for the fix! How are you finding these? Are you managing to try every word and phrase by hand, or are you using a cool modern technique like fuzzing or static analysis?


Adding ReactInit and ReactFunction

Could be more documentation based on the content of NativeModules.h, but followed the pattern of others to just put a quick sentence.
Added on all versions back to 0.62, which is when these were added.

Fixes #254
(unless we want to break out pages with more details)

Is the 959 files changed by design?

Definitely nope. Refresh.


Updating models or files and deployement

Hey,
First of all, thanks for this repo. Looks really good. One thing that I can't completely understand about your development and deployment workflow is that what would happen when I have a container deployed on the production server and then I have changed some models and I want to deploy them.
Obviously, current Dockerfile is going to install a new mysql instance which doesn't have the old data on the previous container so makemigrations won't be useful in this case.
Could you please explain what is the right workflow in this scenario?

current Dockerfile is going to install a new mysql instance which doesn't have the old data on the previous container so makemigrations won't be useful in this case.

Not quite. It will only install a new local MySQL instance in the development environment. In production, it will connect to an external database server. You specify the production database in config.ini in these lines:
DATABASE_HOST = <IP_ADDRESS>         ; IP address of your database server
DATABASE_USERNAME = root
DATABASE_PASSWORD = rootpassword
DATABASE_NAME = django


extras/paho_mqtt_c Outdated

In the process of trying to use the mbedTLS library with the paho_mqtt_c library, I found that the paho_mqtt_c library is on the order of two years out of date. As security is the driver behind this work, I would much prefer to have a more-current version of the paho libraries in use.
While the mbedTLS library seems to have minimal changes with respect to https://github.com/ARMmbed/mbedtls the paho_mqtt_c library is substantially different than https://github.com/eclipse/paho.mqtt.embedded-c even on a file-by-file basis. I am guessing that a significant number of the differences may be due to the esp-open-rtos build system and a likely requirement that the #define-s and symbol names must be unique.
Going on that assumption, to be able to maintain the port of paho.mqtt.embedded-c to paho_mqtt_c, a script or set of scripts would be very useful that would

Copy the needed files from a git checkout of paho.mqtt.embedded-c to a working directory
Perform the namespace changes required
Add the additional files needed for the esp-open-rtos build system

A script of this type may be useful for other "extras" with upstream source.
Is my assumption about the need for "globally" unique #define-s and symbol names correct?
Does such a script already exist, in part or in whole?
Once I get the current paho_mqtt_c working with TLSv1.2 I may take a stab at it.

Well, I've taken a good stab at comparing v1.0.0 upstream having found over 140 define/variable-name changes and it's somewhat recognizable. There's also a healthy dose of formatting style changes that will make a "clean" merge close to impossible.
I'd suggest a re-port of the upstream code, especially given that it has apparently has already been ported to FreeRTOS upstream.
https://github.com/eclipse/paho.mqtt.embedded-c/tree/master/MQTTClient-C/src/FreeRTOS

Good catch. I am hoping someone really in need of MQTT for EOR will do the porting and raise a PR. At best, the upstream code could be included as a submodule with additional glue as needed. Eg. SPIFFS is included this way.

I did note that the mbedTLS libraries consist of a "wrapper" and then a "stock" checkout of the upstream source. That seems like a good pattern to me.
Is this project "religious" about putting *.h identifiers into their own namespaces, or is conflict resolution generally left to the user? If so, is there an established naming practice? My preference would be to leave them alone, as much as possible.
I'm working through why what is running with "stock" mbedTLS and MQTTClient-C on my desktop is doing all kinds of strange things on my ESP8266; mbedtls_entropy_init() hanging, known-good cert not verifying, ... If it takes much longer, the port of MQTTClient-C may rise even more quiclky to the top of my list. The recent CVE on WPA2 vulnerability further reinforces the need for TLSv1.2 transport, even if just to protect the MQTT server.

Still working on getting a "reference implementation" going with the current mbedTLS and MQTTClient-C. Tracking down why mbedTLS isn't able to verify certificates under esp-open-rtos, though the same code compiled on a POSIX platform is successful (yes, lots of "fake" *.h and function stubs needed). I'm guessing at this point that it is either the lack of a time reference, or something buggy in the math libraries.
Once I have a reference implementation working, I'll be taking a stab at porting the upstream MQTTClient-C FreeRTOS code to esp-open-rtos.

Making reasonable progress on the port of upstream https://github.com/eclipse/paho.mqtt.embedded-c
So far it looks like I should be able to do it without changing the upstream source. One local #define at a time...
Thanks to @ourairquality for getting upstream to resolve http://savannah.nongnu.org/bugs/?52190

Unfortunately, the upstream platform-specific code for FreeRTOS relies on blocking read and it appears that socket timeouts are not supported with LWIP. #477
At least we'll get the current upstream source. Working on writing a select()-based approach next.

@jeffsf Socket timeouts should be working on lwip. Using the FreeRTOS socket api might be the problem, so perhaps see if there is posix style socket support.

Port is "works for me" now and builds without unintentional warnings with -Wall.
There is an intentional #warning inserted about lwip_gethostbyname() not being thread-safe. If anyone reading this can point me to a memory-efficient, thread-safe way to resolve a host name with LWIP, I'd appreciate it. The documentation for lwip_gethostbyname_r() is pretty sketchy, such as determining the size of the buffer needed. I don't see HOSTENT_STORAGE defined in esp-open-rtos.
I've got on-the-fly patching of upstream sources tied into the build system, all done under $(BUILD_DIR)
Patches are very minimal; missing header #include here and there, defining a function in a header (multiple versions of the same symbol in the esp-open-rtos build system), and, surprisingly, the upstream FreeRTOS-specific code not checking for EAGAIN.
Working through README.md and licensing. Three-Clause BSD OK with the project?

There does not appear to be provision in newlib for thread load storage for gethostbyname. Perhaps it is just assumed that gethostbyname_r will be used and I suggest using that. Looking at the source code in netdb.c suggests the buffer needs to be at least (sizeof(struct gethostbyname_r_helper) + LWIP_MEM_ALIGN_BUFFER(namelen + 1)).

Of course struct gethostbyname_r_helper is internal and not present in lwip/netdb.h :unamused:
Quick check from my running board gives
128    DNS_MAX_NAME_LENGTH
177    NETDB_ELEM_SIZE
148    sizeof(struct gethostbyname_r_helper) + \
              LWIP_MEM_ALIGN_BUFFER(DNS_MAX_NAME_LENGTH + 1)

Thankfully not so big as to warrant fancy memory management.
So as not to blindly assume that is the maximum, the function is linear with size
lwip/arch.h:#define LWIP_MEM_ALIGN_BUFFER(size) (((size) + MEM_ALIGNMENT - 1U))

https://github.com/jeffsf/extras_paho-embed-mqtt3c
I wouldn't say it's "pull ready" especially as it doesn't include a working example, but it seems pretty solid to me.
No "shim" included because FreeRTOS is GPL and there is yet to be any legal consensus around copyright and license of APIs and function prototypes.

Jeff I was just about to start doing the exact same thing - in my case because QOS2 simply doesn't work with the version of PAHO that's in esp-open-rtos. However it looks like you've done all the hard work already, just not quite got it over the line.
How can I help turn this into a PR so we can get it into the baseline code as I'm sure it's not just you and I who would benefit from this?

Just getting back to dusting this off, hopefully with the ability to use mbedTLS as transport as well. I was holding off to make sure that the APIs and build approach were going to support that. No guarantees on availability of time, but I'm still around!


bugfix/home_routing_issue

Description
Work in progress. Attempting to correct redirect issue.
Type

[x] This is a bugfix.
[ ] This is a new feature.
[ ] This is part of a feature.

Organization

[ ] Have you linked this pull request to a Trello card?
[x] Have you named the branch in the format of feature/describe_feature_or_change OR bug/describe_bug_this_is_fixing

Review

[x] Is this a work in progress?
[ ] Is this ready to be reviewed?
[ ] Have you added two reviewers to this pull request?

 Have user redirected to dashboard upon login.

 Have user redirected to dashboard upon login.

This has been dealt with in another PR

This has been dealt with in another PR