com.google.cloud.tools.jib.plugins.common.PluginConfigurationProcessor#createModificationTimeProvider does not support  USE_CURRENT_TIMESTAMP

Hi,
I thought the issue was already created but github didnt popped it up so creating this issue hoping it is not a duplicated.
Long story short, there are numerous cases (think serving static content for ex) where we want to get the build time as file time for extra dir and today it requires build hacks whereas USE_CURRENT_TIMESTAMP is a neat way for the classpath/classes, would be great to add it in the switch for createModificationTimeProvider too if possible.

There is a Jib extension for Maven that can selectively set file timestamps to build time. Please use that if you are on Maven. Not sure if there's a Gradle extension, but you can create one if there isn't.
Intentionally, we don't allow setting file modification time to the current timestamp, as it completely nullifies layer caching, which is a huge deal. We strongly discourage using the current timestamp for files for this reason. Even if we decided to provide this feature, we would do so via a Jib extension, never the main Jib plugins.
If you use the build time for files, I strongly recommend limiting the scope to a small layer, since such layer must be uploaded or downloaded every time. You may consider breaking down a large layer into multiple by using the Jib Layer Filter extension first (Maven / Gradle).

Actually, the user-contributed Layer With Modification Time Jib Extension that I mentioned does a very nice thing for you in that it conveniently creates a special layer for the files you want to set the last modified time to build time for. I strongly recommend this kind of preparation.

@chanseokoh why is it allowed for the classpath :thinking: ? Think both should be allowed or forbidden. On a concrete point I never have a build which is able to not use current time cause artifacts always have to be up to date. It would be ok to use the git time but it would require the PR I did which enables to use a custom format cause iso time is not always the one you can expect depending how you inject the time. I am also ok-ish to use an extension while owned by jib project but not so much to get a one man impl today for something so critical. Last thing is that ideally I don't want build time but file time to be respected, I can enhance my PR to do so if you think it would be a good replacement of current time.

My current workaround:
<plugin>
        <groupId>io.github.git-commit-id</groupId>
        <artifactId>git-commit-id-maven-plugin</artifactId>
        <version>6.0.0</version>
        <executions>
          <execution>
            <id>get-the-git-infos</id>
            <phase>initialize</phase>
            <goals>
              <goal>revision</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <injectAllReactorProjects>true</injectAllReactorProjects>
          <generateGitPropertiesFile>false</generateGitPropertiesFile>
          <dateFormatTimeZone>UTC</dateFormatTimeZone>
          <dateFormat>yyyy-MM-dd'T'HH:mm:ss'Z'</dateFormat>
          <includeOnlyProperties>
            <includeOnlyProperty>^git.commit.time$</includeOnlyProperty>
          </includeOnlyProperties>
        </configuration>
      </plugin>

and I set
<creationTime>${git.commit.time}</creationTime>
<filesModificationTime>${git.commit.time}</filesModificationTime>

works well enough even if a bit verbose if you have git setup.

why is it allowed for the classpath 🤔 ?

Sorry, I don't follow. Are talking about the small text file where Jib records the computed classpath? If the last modification time of that classpath file is set to the current timestamp, it would be a bug.
If you are talking about USE_CURRRNT_TIMRSTAMP for creationTime, it is about the image metadata, not files in an image, so image layers (which are for files) are still reproducible.
In any case, we won't allow user to use the current timestamp for files. If you really have to do so, please write an extension. Using a git commit timestamp is what people often do and should be much better than using build time.

@chanseokoh you are right so let's move this ticket to "support such an extension out of the box in jib and not a random github repo which can disappear" (and hopefully make such an extension better integration by default to avoid to be too verbose). Any chance it gets integrated in jib-core - even if packaged as an extension and not built-in?

I'll let the maintainer (@GoogleContainerTools/cloud-java-team-teamsync) decide if they will accept your contribution as a first-party extension in the jib-extensions repo.
For jib-core, as a library, you can easily set whatever file timestamp you want. For example, you can provide a ModificationTimeProvider that works for you.

And to reiterate, we strongly discourage setting file timestamps to the current time, and if someone wants to do so, they should limit the scope to a small and separate layer. As you may know, Jib is highly opinionated, and we deliberately make the user difficult to use the current timestamp for files. An extension is the only compromise we can accept at best.

We are using jib to build a webserver that servers some static data - js, css, html which constantly chagnes and some backend endpoints. As someone else mentioned, this conflicts with computation of eTag header for resources which by default uses mTime.
Main issue is then browser will not download requested resource because eTag is not changed.
I understand the argument @chanseokoh made about inefficiency of images and layers. But since we know how are layers built, we can make it that layer with resources - mostly javascript sources that are changed everytime - is the only one that has timestamps preserved - and please forgive me i dont know the right order - we can make it the last (top in stack) so no other layer depends on it. Then all layers are always reused except this one... which changes always all the time anyway.

@Donorlin if you are willing to use the community-contributed Layer With Modification Time Jib Extension, you can achieve what you described.

we can make it the last (top in stack) so no other layer depends on it. Then all layers are always reused except this one... which changes always all the time anyway.

BTW, it's a common misconception that the order of layers matters, but that's not the case. Any layers will be reused as long as they don't change, regardless of the order.

BTW, it's a common misconception that the order of layers matters, but that's not the case. Any layers will be reused as long as they don't change, regardless of the order.

@chanseokoh Thank you ! I was kinda hoping this is the case! Heh you learn everyday something new. Thank you
Actually I am using JIB-CLI and i just fixed it with timestamp property for that specific layer.
Example for future generations:
jib.yaml config file based on Fully Annotated Build File (jib.yaml)
...
layers:
  entries:
    - ... other layers
    - name: frontend
      properties:
        timestamp: ${timestamp}
      files:
        - src: ../dist
          dest: /opt/app-root/app

and by running
jib build --parameter=timestamp="DATE.NOW()" ... rest of the params

u can replace ${timestamp} placeholder.. more at JIB CLI options
since this layer that contains built SPA application is changed everytime anyway, it wont matter to set timestamp


Can I build ruby gem of grpc with OpenSSL support instead of BoringSSL ?

What version of gRPC and what language are you using?
Version : Latest source code from master
Language : Ruby
What operating system (Linux, Windows, …) and version?
Linux - SUSE, s390x architecture
What did you do?
Trying to build grpc ruby gem from source code .
Thanks in advance.

As long as you have the OpenSSL development files installed, this should work.

Hi @nicolasnoble
Thanks for the answer. Do you know how to use those development files while building gem ?

I'm not familiar with Suse, so I don't exactly know how to acquire these development files.

Ok, no issues. If you can give me an example of how to build grpc using development files in any distro, I can replicate it for my distro. I want to know how to use Openssl development files in grpc source to build ruby gem.


Server Emergency Alarm

Create alertings in kubesphere.

Give an alarm when the server shuts down.
Give an alarm when there is a node that is not working.
Give an alarm when the internet is cut off.
Give an alarm when the machines reach high temperature, high CPU usage, high RAM usage.
Alarm when storage space is low.

To be informed of these Alarms 24/7, search for applications such as DingTalk, Slack, Webhook and integrate one of them.

Necessary alarm rules were created and a Slack connection was made.


Support for declaring indexes

Schemas (or possibly models) should allow indexes to be declared.

:+1: this would be useful


fatal error: pcl/point_cloud.h: No such file or directory

Hi, I use
catkin_make -DCMAKE_BUILD_TYPE="Release" -Dfreenect2_DIR=/usr/local/freenect2/lib/cmake/freenect2
and get
[ 27%] Built target kinect2_registration
[ 36%] Building CXX object iai_kinect2/kinect2_viewer/CMakeFiles/kinect2_viewer.dir/src/viewer.cpp.o
[ 54%] Built target kinect2_calibration
[ 72%] Built target kinect2_bridge_nodelet
[ 90%] Built target kinect2_bridge
/home/user/catkin_ws/src/iai_kinect2/kinect2_viewer/src/viewer.cpp:29:29: fatal error: pcl/point_cloud.h: No such file or directory
compilation terminated.

I have already compile and install pcl 1.8.0, I can find the file pcl/point_cloud.h under /usr/local/include/pcl-1.8/
Any idea?
os: ubuntu 16.04
pcl: 1.8.0

Have you solve the problem with the iai_kinect2 when using pcl1.8? I would like to use pcl1.8 but there are a lot of problem.

@shadowdk3 have you tried printing the PCL_INCLUDE_DIRS from the Cmake? I don't see why it would not compile with 1.8; There are no breaking changes between 1.7 and 1.8;

you can add the pcl path(  /usr/local/include/pcl-1.8/  ) under include_directories in you CMakeList.txt, in my computer, solve this problem.


add support for qdrant

https://qdrant.tech/

Looking forward to contributing, could you please provide more details to help me better understand the task?

https://github.com/h2oai/h2ogpt/issues/145#issuecomment-1552281087

@AyeshGK , it would be nice if you've added this. Also, don't forget to add the tests pseudotensor mentioned in the reference comment. Tests make the quality (I came to this repository after seeing no tests in imartinez/privateGPT and su77ungr/CASALIOY repos and many issues compared to having lower features than here.


Feature/fix bq merged issue

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (72b6030) 80.83% compared to head (cd26e6a) 80.83%.
 Consider uploading reports for the commit 9c278d3 to get more accurate results

Files
Patch %
Lines

metrics_layer/core/model/field.py
66.66%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   80.83%   80.83%   -0.01%
==========================================
  Files          47       47
  Lines        5626     5635       +9
  Branches     1380     1383       +3
==========================================
+ Hits         4548     4555       +7
- Misses        830      831       +1
- Partials      248      249       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't get shore-foam to show on Unity Terrain?

Unity Terrain does not seem to write anything into the depth-cache so no shore foam?, any other object works good, any ideas?
Also, is there a way to extend the distance the shore foam shows? at the moment it looks like a thin strip sometimes.

You can also find a setting for this in the foam settings, so this is linked to #153

Oh sorry i neglected to read the first part! Looking at it now, I think i know what it is..


Bonus - Improve the codebase for long-term sustainability

Improve the codebase for long-term sustainability
User Story
AS A marketing agency,
I WANT a codebase that follows accessibility standards,
SO THAT our own site is optimized for search engines.
Acceptance Criteria
GIVEN a Bootcamp Week 1 Challenge website,
WHEN I visit the site on my browser,
THEN all links are functioning correctly.
GIVEN the bootcamp-week-1-challenge codebase repository,
WHEN I see the repository and codebase,
THEN CSS is organised following the semantic structure of the HTML elements,
THEN CSS contains comments before each element or section of the page.
THEN HTML and CSS passed the validation of the W3C Nu validator,
THEN Repository has a unique name,
THEN Repository follows best practices for file structure and naming conventions,
THEN Repository follows best practices for class/id naming conventions, indentation, quality comments, etc,
THEN Repository contains multiple descriptive commit messages,
THEN Repository contains a quality README file with a description, screenshot, and link to the deployed application.

I extended the documentation in the README, added a specific Tests section, and commented on the HTML and CSS code.


Add compact-client-side-filtering:-neutrino to bitcoin-magazine/bitcoin-explained

This PR adds Compact Client Side Filtering: Neutrino transcript to the bitcoin-magazine/bitcoin-explained directory.

Hey @NeroCherubino, great work on #368! However, in this review and #367, it seems you mostly replaced the speakers' names.
As I mentioned in your previous review, it seems there might be a disconnect in communicating our expectations clearly. To address this, we're working on more detailed Review Guidelines to provide clearer direction. In the meantime, please take a look at the Review Guidelines provided here and refer to the 'right editing' examples here.
I believe that with a glance at these guidelines, your submissions could reach an even higher standard. Thanks for your efforts!

Hey @NeroCherubino, great work on #368! However, in this review and #367, it seems you mostly replaced the speakers' names.
As I mentioned in your previous review, it seems there might be a disconnect in communicating our expectations clearly. To address this, we're working on more detailed Review Guidelines to provide clearer direction. In the meantime, please take a look at the Review Guidelines provided here and refer to the 'right editing' examples here.
I believe that with a glance at these guidelines, your submissions could reach an even higher standard. Thanks for your efforts!

Both updated.
Thanks for all explanations.

Hey @NeroCherubino, I've pushed some fixups and is now ready to merge! You can see my fixups here, I mostly fixed some of AI's transcription erros, deleted a few non-essential lines, a couple of instances of filler words, and added chapters for readability.


by default, turn off bookmarking

closes #949, for now

Coverage remained the same at 44.187% when pulling 0eb92b0cf09738497e185fa6d789f3b8e8faa579 on bookmark-fixes into d0967b30450dcb146c35935cfa852c0d53d3af2b on release2.1.


Format negative durations more intuitively.

See https://code.djangoproject.com/ticket/30443 for rationale.
Basically, duration_string(parse_duration("-00:00:05")) should not be -1 23:59:55.

Effectively, I'm arguing that there should be one way to represent -00:00:05 but today there are two, -00:00:05 and -1 23:59:55. This is because there are two signs in  django.utils.dateparse.standard_duration_re, allowing the days field and the hours:minutes:seconds field to have different signs.
Before:

1 00:00:01 is equal to 86401 seconds
1 -00:00:01 and 23:59:59 are equal to 86399 seconds
-1 00:00:01 and -23:59:59 are equal to -86399 seconds
-1 -00:00:01 is equal to -86401 seconds

After:

1 00:00:01 is equal to 86401 seconds
1 -00:00:01 is invalid.
-1 00:00:01 is equal to -86401 seconds.
-23:59:59 is equal to -86399 seconds
-1 -00:00:01 is invalid.

Note that ISO8601 dates only support one negative sign.


[test]test for 29065

Proposed changes
Issue Number: close #xxx
https://github.com/apache/doris/pull/29065
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run compile

run p0 5


Renamed ns in few tests

Signed-off-by: Mikhail Avramenko<EMAIL_ADDRESS>Issue
fixes https://github.com/networkservicemesh/sdk/issues/1048

Please check /features/ipv6 wireguard examples


feature request: using the pen to highlight parts of the canvas

first, thanks for a great and easy to use signature util.
I'm trying to use it to annotate a text image; writing on the image, signing it, which works fine, but I tried to highlight a line of text and it did not work, I tried to change the color transparency of penColor and I got bunch of circular spray patterns.
Thanks,

The problem is that because there's no native way of drawing curves with variable width, the lines are actually drawn using circles. The circles sometimes overlap, which is not visible when you use an opaque color, but is apparent when you use non-opaque one. I'll have to check if it's possible either to avoid this overlapping or if there's some blend mode that would not add up transparency values...

Thanks for quick reply, I found some other signature apps that try to make small lines instead of points, like this one https://www.youtube.com/watch?v=8KV1o9hPF5E using swift for iOS

Thanks, but I don't see anywhere that he shows how to draw a curve with variable width. Anyway, this library uses circles and it's probably not that easy to do make sure that nothing is overlapping, so unless there's some setting on canvas element that allows transparency values not to add up, it's going to be hard to fix it. Though I'd really like to make it work...

thanks, that's fine, I started to learn javascript, and wondering what's the purpose of first line of app.js which is "var wrapper = ... multiple values"

This part just defines some variables used later in the script - signature pad wrapper element, clear and save buttons etc.

closing this as stale. If this is still needed we can reopen it.


Dev Test: Balancing Act 1.3.0-dev.1

Dev Test
Mentions: @marlitas, @amanda-phet, @Luisav1
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html

Test Matrix
Please include all (non-screen reader) feature testing in these records if applicable.

[x] Latest macOS, Safari (Time = 2hrs)
[x] Latest iOS, Safari (Time = 1.75)
[x] Windows 10/11, Firefox (Time = 2)
[x] Windows 11, Chrome (Time = 2.5)
[x] Latest Chrome OS, Chrome (Time = 1)

Light testing, or optionally skip if time crunch:

[x] Latest macOS, Chrome (Time =2 )
[ ] Windows 10, Chrome (Time = )

Features included

[ ] ~PhET-iO~
[x] Dynamic Locale
[ ] ~Alternative Input~
[x] UI Sound
[ ] ~Sonification~
[ ] ~Description~
[ ] ~Voicing~

Focus and Special Instructions
This publication includes the addition of region and culture characters that can be changed in the preferences dialog, as well as the addition of dynamic locales. Otherwise the logic or functions of the sim have not changed.
Any bugs that come up that can be replicated in the published version should receive an issue labeled as deferred. They will not be fixed for this upcoming publication unless highly prohibitive or concerning.
Issues to Verify
These issues should have the "status:ready-for-review" label. The issues can be closed after verifying.

[x] https://github.com/phetsims/balancing-act/issues/25
[x] https://github.com/phetsims/balancing-act/issues/63
[x] https://github.com/phetsims/balancing-act/issues/95
[ ] https://github.com/phetsims/balancing-act/issues/103

For QA...

General features

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Try to include browser version numbers
If there is a console available, check for errors and include them in the Problem Description.
Run through the string tests on at least one platform, especially if it is about to go to rc.
Check the Game Up harness on one platform.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Calling QA here

Closing since the RC version will be ready soon.


Include minimum version number in readme install instructions

Using bundler to install Rubocop without specifying a version number resulted in installing 0.26.1, despite the most recent version having no conflicts with any other gems.

I'm not sure how version numbers work for this gem. This syntax assumes there may be breaking changes in 0.35, but not between 0.34.2 and 0.34.3.

I am not a fan of the README specifying a gem version. I have found that it tends to not get updated when the gem version is updated resulting in basically the same issue. Other people may have different opinions on this.
I just set up a new project. The Gemfile contains gem 'rubocop' and it installed 0.34.2

I can't reproduce @adsteel's issue myself as well and no one else has complained about something similar. I'm guessing he has some issues with his local setup/project.


Commiting Governance Pipeline 1

Summary: This pull request addresses [briefly describe the purpose or issue being addressed].

Version information

[x] Tested against target systems and versions: Ansible Automation Controller 23.3.0,JIRA 23.3.3
[x] Tested with Digital.AI Release version: DAI Release 23.3.3

Review

[x] Check for proper folder structure and versioning settings if a new subfolder is added under templates.
[x] Ensure autoImport is set to false for the templates folder versioning settings.
[x] If adding a new template, update the Releasefile.yaml for proper Digital.ai Release import.
[x] Avoid using community plugins.
[ ] Do not use global or folder variables.
[x] Confirm that variables follow the correct naming convention (camel case or snake case) and have appropriate labels and descriptions.
[x] Templates should have accurate titles and descriptions.
[x] Assign tasks to the appropriate user.
[x] Verify that all phases and tasks have correct titles and descriptions.
[x] Ensure the change fulfills and explains the business requirements properly.
[x] Place the template in the correct folder based on its category, and ensure that proper documentation accompanies it.

QE

[x] Confirm that the changes can be successfully imported into Digital.ai Release without any breaking issues.
[x] Generate a release from the newly added or updated template and verify that there are no failures.

PR Merge Activity

[ ] Squash and merge the PR.
[ ] After the PR is merged, make sure to push the appropriate tags on the main branch to reflect the changes in customer installations.

@ankurtrivedi Only basic xl apply testing is done on this template , all yaml file apply works fine .
Actual release failed due to missing connections in template.


Help

I have the script (PE2HEX) and the DLL, what i need to do?

@danielkrupinski

@danielkrupinski

drag dll into

convert dll into strings.


Add Kiali to observability section

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 250 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit 5d34b70cd60bc2cd2f38eb942641ffcb37896090
https://deploy-preview-1271--landscape.netlify.com

what is strange to me is that in the preview, when clicking on Kiali I see "not open source" license.
but the Kiali repo has an Apache 2 license and the project is open source.

See after that last commit.

thanks @dankohn ! indeed

LGTM


about slidedown instruction

In slidedown session, it says:
vslidedown behavior for source elements for element i in slide
0 <= i+OFFSET < VLMAX Read vs2[i+offset]
VLMAX <= i+OFFSET Read as 0
shouldn't it be "0 <= i+OFFSET <vl, Read vs2[i+offset]“ ?

No, because the source elements may have indices >= vl. vl affects how many
destination elements are written.
On Wed, Jul 24, 2019 at 5:17 AM wwang0<EMAIL_ADDRESS>wrote:

In slidedown session, it says:
vslidedown behavior for source elements for element i in slide
0 <= i+OFFSET < VLMAX Read vs2[i+offset]
VLMAX <= i+OFFSET Read as 0
shouldn't it be "0 <= i+OFFSET <vl, Read vs2[i+offset]“ ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-v-spec/issues/261?email_source=notifications&email_token=AAH3XQXOA364EUF4ABOUXYDQBBB6JA5CNFSM4IGPOEF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBF7A5Q,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH3XQXIKXC2EWPA65YLK63QBBB6JANCNFSM4IGPOEFQ
.

if the values of slidedown's source register was generated from  an instruction with the same vl  before running slidedown,  the elements between vl and VLMAX are actually zero, so there is no much difference. And if vl is not the same, current definition is more simple nd flexible. OK, I got it. Thanks.


Add npmignore and prepublish script

The .npmignore will ignore certain files in the tree like configuration
and the gulpfile and allow others like the dist folder which must be
included in the package. Other than that, it should be the same as the
gitignore.
Add a prepublish script to build the library before it is published.

See what's published with npm publish --dry-run.

LGTM, thanks!


Doc request: Document Migrate workflow for adding DB triggers

We should an example migration flow for creating a SQL trigger in a DB.

How to work around unsupported features with Prisma Migrate: https://www.prisma.io/docs/guides/database/developing-with-prisma-migrate/add-prisma-migrate-to-a-project#work-around-features-not-supported-by-prisma-schema-language

A trigger might be common enough request that we could document this as an example (or similar to how we document the views workaround).


Updates Gofmt to Cover e2e Tests

Updates fmt Make target to cover e2e tests.
xref: https://github.com/projectcontour/contour-operator/pull/269
Signed-off-by: Daneyon Hansen<EMAIL_ADDRESS>

LGTM. Not totally clear on why test/e2e isn't being picked up by the existing command, maybe due to build tags?

Yeah I think that is probably why golangci-lint isn't picking it up, I bet https://github.com/projectcontour/contour-operator/pull/275 won't fail on the test/e2e change

LGTM. Not totally clear on why test/e2e isn't being picked up by the existing command, maybe due to build tags?

Yeah I think that is probably why golangci-lint isn't picking it up, I bet #275 won't fail on the test/e2e change

I tested this locally and it looked like it works when the path is explicitly specified, 🤷♂

LGTM. Not totally clear on why test/e2e isn't being picked up by the existing command, maybe due to build tags?

Yeah I think that is probably why golangci-lint isn't picking it up, I bet #275 won't fail on the test/e2e change

I tested this locally and it looked like it works when the path is explicitly specified, 🤷♂

Yeah this run didn't fail: https://github.com/projectcontour/contour-operator/pull/275/checks?check_run_id=2176583612
Had to run this locally to get legit errors: ./hack/golangci-lint.sh run --build-tags=e2e

LGTM but we still need to fix the code linting CI job to catch these sorts of things, this change is not sufficient to prevent unformatted code from being checked in

I can do a quick PR to fix that @skriss unless youre already working on it

go for it, haven't started that


Added custom logout page

Describe your changes
Added custom logout page and changed the SecurityFilterChain to allow for such a page to exist.
Issue ticket number and link
Closes #95
Checklist before requesting a review

[X] I have performed a self-review of my code

I completey broke the branch on the merge with master.


client.ts:77 WebSocket connection to 'ws://localhost:8089/' failed:  Error

client.ts:77 WebSocket connection to 'ws://localhost:8089/' failed: Found on Frontend

Seems related:
client.ts:77 Uncaught (in promise) DOMException: Failed to construct 'WebSocket': The URL 'ws://localhost:undefined/' is invalid.
at setupWebSocket (http://localhost:8089/@vite/client:505:20)
at fallback (http://localhost:8089/@vite/client:484:22)
at WebSocket. (http://localhost:8089/@vite/client:520:13)
setupWebSocket @ client.ts:77
fallback @ client.ts:42
(anonymous) @ client.ts:99
Show 3 more frames
Show less
chun


Job workers can take a while to respond and die

Summary of problem: we have 4 web workers to reply/control the job generation, and status. However, when we have lots of jobs finishing at the same time, there are times that the workers get busy and do not reply, and all these should take micro-seconds. The question is, which are these occasions that they take longer?

This will/should be solved by supervisord.

Closed in the qiita 4.19 release to be deployed on May 15, 2019.


Provide an "installation" script

Rather than having to go into the kiwiproject-changelog repository, build the (shaded) JAR, then run the JAR using java -jar /path/to/kiwiproject-changelog/target/changelog-generator-0.10.0.jar <options>, provide a way to "install" the change log generator.]
The installation script should:

Checkout and build the most recent (production) release
Copy the shaded JAR to the installation directory, perhaps specified as an installation option
Create an executable script, e.g., .generate-kiwi-changelog, in the to the installation directory
Either add the script to the PATH or provide a snippet to add to a bash/zsh/etc profile

Installation options might include:

the install directory (perhaps this should be required)
allow a custom name for the script if someone doesn't like the default name
automatically update the bash/zsh/etc profiler script to add to PATH

The installation should also allow updating when a new version is released, which would replace the JAR in an existing installation. If the JAR is named generically, i.e., without the version number, then only the JAR needs to be updated.
The installation directory might look like:
<install-dir>/
    .generate-kiwi-changelog
    kiwi-changelog-generator.jar
    README.txt

For initial installation, usage could look like:
$ ./install.sh -d /home/alice/kiwi-changelog

Or to create a custom script name:
$ ./install.sh -d /home/alice/kiwi-changelog -n generate-changelog

To perform an update, you would simply run the install.sh script again:
$ ./install.sh -d /home/alice/kiwi-changelog

The script should be smart enough to detect an update, and only update the JAR.
Then, to run the change log generator, the usage should be pretty simple, e.g.,:
~/Projects/kiwiproject/kiwi-js $ .generate-kiwi-changelog \
    --repository kiwiproject/kiwi-js \
    --previous-rev v0.5.0 \
    --revision v0.6.0 \
    --output-type GITHUB \
    --close-milestone \
    --create-next-milestone 0.7.0

Or, using the short names:
$ .generate-kiwi-changelog -r kiwiproject/kiwi-js -p v0.5.0 -R v0.6.0 -o GITHUB -C -N 0.7.0

On a re-installation, we should update everything, in case other things have changed.


fix: set default host to ::

Fixes #3347

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.415%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3681

Relevant Lines:
18298

💛  - Coveralls

just an FYI - this change broke my docker-compose environment where I have ipv6 disabled.  I had to fix by setting an environment variable of HOST and setting it to the value of the container IP

@Skullduggeryism I'm probably having similar problem to yours.
After updating the container to 9.2 it's not starting with the error:
2023-10-18 16:19:03.238 WARN STORE: scenes.json not found Error: listen EAFNOSUPPORT: address family not supported :::8091     at Server.setupListenHandle [as _listen2] (node:net:1723:21)     at listenInCluster (node:net:1788:12)     at doListen (node:net:1937:7)     at processTicksAndRejections (node:internal/process/task_queues:83:21)
Could you please give a little bit more details was it the same as you have seen and how you fixed it. Thank you!

I can build a test docker container for it

@robertsLando Sure, I can. Send me please the new container.

I have triggered this workflow: https://github.com/zwave-js/zwave-js-ui/actions/runs/6571215103
Once it ends, you can use docker test tag

@robertsLando : just pulled the test tag Digest: sha256:2014a9da749da02d3548e3cb091ae9f185af565fed18e899e3dadfcbfc1da8da
And it works fine (after 3 min of interacting with it). Thank you!

@bpawulski Do you have ipv6 disabled?

@robertsLando: Yes i do
bartek@ubuntuser:~$ cat /sys/module/ipv6/parameters/disable
1

Thanks for your report!

@Skullduggeryism I'm probably having similar problem to yours. After updating the container to 9.2 it's not starting with the error:
2023-10-18 16:19:03.238 WARN STORE: scenes.json not found Error: listen EAFNOSUPPORT: address family not supported :::8091 at Server.setupListenHandle [as _listen2] (node:net:1723:21) at listenInCluster (node:net:1788:12) at doListen (node:net:1937:7) at processTicksAndRejections (node:internal/process/task_queues:83:21)
Could you please give a little bit more details was it the same as you have seen and how you fixed it. Thank you!

That is correct, I got the error "EAFNOSUPPORT: address family not supported :::8091"
To fix (in docker-compose environment), you should be able to just add the following environment variable:
environment:
  - HOST=<IP_ADDRESS>

However, for some reason that did not work for me so I hard-coded an IP address for this container, and then made HOST that IP address.

@Skullduggeryism try with 9.2.2

Perfect, thanks for your feedback 🙏🏼


Refactor BlockLoweringOrder::new

As discussed on Zulip.
This should be a refactor but may have some performance implications.

I want to do a quick round of profiling on this before merging it but I think it'll probably be fine.


Enable config cache

4 problems were found storing the configuration cache.

Build file 'build.gradle.kts': external process started 'git rev-parse --verify HEAD'
See https://docs.gradle.org/8.2.1/userguide/configuration_cache.html#config_cache:requirements:external_processes
Build file 'build.gradle.kts': external process started 'git status --porcelain'
See https://docs.gradle.org/8.2.1/userguide/configuration_cache.html#config_cache:requirements:external_processes
Task :rat of type org.nosphere.apache.rat.RatTask: invocation of 'Task.project' at execution time is unsupported.
See https://docs.gradle.org/8.2.1/userguide/configuration_cache.html#config_cache:requirements:use_project_during_execution
Task :signArchives of type org.gradle.plugins.signing.Sign: cannot serialize Gradle script object references as these are not supported with the configuration cache.


Update chat section UI

I want to enhance the chat page UI, kindly assign me under gssoc23

Fixed with #75.


parking_lot 0.8.1 is technically a semver breaking release

0.8.1 bumped lock_api version from 0.2 to 0.3 and, because it is a public dependency, it is a breaking change.
See https://github.com/matklad/once_cell/issues/26
I'm personally fine with just fixing once_cell, but, if we want to follow semver strictly, we probably should yank 0.8.1 and publish 0.9 instead.

I yanked 0.8.1, sorry about that.


Added toUTF

I added toUTF to replace toUTF8, toUTF16, and toUTF32. All three of those have now been scheduled for deprecation. However, the versions of toUTF8 and toUTF16 which took static arrays (and did essentially the same thing as std.utf.encode) have actually been deprecated, since they weren't documented. I also replaced all calls to toUTF8, toUTF16,  and toUTF32 with the appropriate calls from toUTF and encode.

Okay. Since the next release is coming shortly, and it would be best to unscheduled toUTF16z for deprecation before that, I just checked in those changes (without changing its implementation to use toUTFz), and I've adjusted those changes here to be making toUTF16z use toUTFz and work with any string type.

Okay. I added an overload for toUTF which takes an output range, and I fixed issue# 6632 while I was at it (toUTFz wouldn't work with a fully const or fully immutable string).

Any further feedback? Is there any reason for me not to merge in this pull request?

I removed the fix for making toUTF work with const and immutable arrays, since the recent changes to IFTI take care of that. I also committed a fix for accidentally calling appender as a property. But there should be no changes in behavior.


update of eks_managed_node_groups values result in always growing increase in MAX and desired capacity for ASGs

Description
Modification of the values eks_managed_node_groups results in constantly growing number of MAX capacity and desired capacity in ASG.
node group is created with
min_size     = 1
max_size     = 5
desired_size = 1

Initial creation - all is good
The change
Modify block_device_mappings.xvda.ebs.volume_size 50 -> 60 and perform terraform apply results in iterative updates to the ASG for the nodegroup:
The plan
# module.eks_cluster.module.eks_cluster.module.eks_managed_node_group["apps-v3"].aws_eks_node_group.this[0] will be updated in-place
  ~ resource "aws_eks_node_group" "this" {
        id              = "xxx-prod-eks:prod-apps-v3"
        tags            = {
            "Name"                                = "prod-apps-v3"
            "client"                              = "xxx"
            "cluster"                             = "xxx-prod-eks"
            "created"                             = "4/18/2022"
            "created_by"                          = "Michael"
            "environment"                         = "prod"
            "karpenter.sh/discovery"              = "xxx-prod-eks"
            "kubernetes.io/cluster/xxx-prod-eks" = "owned"
            "ops_team"                            = "Michael/Michaela"
            "ops_team_email"                      =<EMAIL_ADDRESS>            "team"                                = "example"
            "terraform"                           = "true"
            "terraform_source"                    = "https://github.com/example/xxx-infra-aws"
            "updated"                             = "4/18/2022"
            "updated_by"                          = "Michael"
        }
        # (15 unchanged attributes hidden)

      ~ launch_template {
            id      = "lt-0053d426f85699916"
            name    = "apps-v3-20220429015545647000000017"
          ~ version = "1" -> (known after apply)
        }

        # (3 unchanged blocks hidden)
    }

  # module.eks_cluster.module.eks_cluster.module.eks_managed_node_group["apps-v3"].aws_launch_template.this[0] will be updated in-place
  ~ resource "aws_launch_template" "this" {
      ~ default_version         = 1 -> (known after apply)
        id                      = "lt-0053d426f85699916"
      ~ latest_version          = 1 -> (known after apply)
        name                    = "apps-v3-20220429015545647000000017"
        tags                    = {
            "client"                              = "xxx"
            "cluster"                             = "xxx-prod-eks"
            "created"                             = "4/18/2022"
            "created_by"                          = "Michael"
            "environment"                         = "prod"
            "karpenter.sh/discovery"              = "xxx-prod-eks"
            "kubernetes.io/cluster/xxx-prod-eks" = "owned"
            "ops_team"                            = "Michael/Michaela"
            "ops_team_email"                      =<EMAIL_ADDRESS>            "team"                                = "example"
            "terraform"                           = "true"
            "terraform_source"                    = "https://github.com/example/xxx-infra-aws"
            "updated"                             = "4/18/2022"
            "updated_by"                          = "Michael"
        }
        # (9 unchanged attributes hidden)

      ~ block_device_mappings {
            # (1 unchanged attribute hidden)

          ~ ebs {
              ~ volume_size           = 50 -> 60
                # (6 unchanged attributes hidden)
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

ASG iteratively being updated with the following values:

max_size=6, desired_size=2, instances=2
max_size=7, desired_size=3, instances=3
max_size=8, desired_size=4, instances=4
max_size=9, desired_size=5, instances=5

max increased to 6

max increased to 7

max increased to 8

max increased to 9

instances:

Then it starts cooling down

max_size=9, desired_size=4, instances=5
max_size=9, desired_size=4, instances=4
max_size=8, desired_size=3, instances=4
max_size=8, desired_size=3, instances=3
max_size=7, desired_size=2, instances=3
max_size=7, desired_size=2, instances=2
max_size=6, desired_size=1, instances=2
max_size=6, desired_size=1, instances=2
max_size=5, desired_size=1, instances=2
max_size=5, desired_size=1, instances=1

It this a normal and expected behavior? If I change the "key name" in the eks_managed_node_groups - then the old nodegroup is deleted and new one is created. And overall the procedure is much faster.
I also got the same issue when my tags are updated. So if I change just tags, let's say
"created"  = "4/18/2022" to "created"  = "4/19/2022"

then I get a lot of EC2 instances spawned and it is very time consuming operation if max_size > 1
Overall the "apply" took 20minutes.

[ x ] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 18.20.5

Terraform version:

terraform -version
Terraform v1.1.8
on linux_amd64

Provider version(s):

+ provider registry.terraform.io/cyrilgdn/postgresql v1.15.0
+ provider registry.terraform.io/gavinbunney/kubectl v1.14.0
+ provider registry.terraform.io/hashicorp/archive v2.2.0
+ provider registry.terraform.io/hashicorp/aws v4.12.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/external v2.2.2
+ provider registry.terraform.io/hashicorp/helm v2.5.1
+ provider registry.terraform.io/hashicorp/kubernetes v2.10.0
+ provider registry.terraform.io/hashicorp/local v2.2.2
+ provider registry.terraform.io/hashicorp/null v3.1.1
+ provider registry.terraform.io/hashicorp/random v3.1.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/tls v3.3.0
+ provider registry.terraform.io/trois-six/sendgrid v0.2.1
+ provider registry.terraform.io/winebarrel/mysql v1.10.6

Reproduction Code [Required]
I create the eks cluster with the following config:

module "eks_ssh_sg_label" {
  source     = "git::https://github.com/cloudposse/terraform-null-label.git?ref=0.25.0"
  namespace  = var.cluster_name
  attributes = ["ssh", "access", "sg"]
}

data "aws_eks_cluster" "cluster" {
  name = module.eks_cluster.cluster_id
}

data "aws_eks_cluster_auth" "cluster" {
  name = module.eks_cluster.cluster_id
}

data "aws_availability_zones" "available" {}
data "aws_caller_identity" "current" {}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.cluster.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
  token                  = data.aws_eks_cluster_auth.cluster.token
}

resource "aws_kms_key" "eks" {
  description             = "Customer managed key to encrypt kubernetes secrets in the cluster"
  deletion_window_in_days = 7
  enable_key_rotation     = true

  tags = var.tags
}

resource "aws_kms_alias" "eks" {
  name          = "alias/${var.cluster_name}-kms-key"
  target_key_id = aws_kms_key.eks.key_id
}

resource "aws_security_group" "ssh" {
  count = var.allow_ssh_access ? 1 : 0

  name   = module.eks_ssh_sg_label.id
  vpc_id = var.vpc_id
  ingress {
    from_port   = 22
    to_port     = 22
    protocol    = "tcp"
    cidr_blocks = var.allow_ssh_access_cidr
  }

  tags = var.tags
}

module "eks_cluster" {
  source  = "terraform-aws-modules/eks/aws"
  version = "18.20.5"

  cluster_name    = var.cluster_name
  cluster_version = var.cluster_version
  vpc_id          = var.vpc_id
  subnet_ids      = var.subnet_ids

  cluster_endpoint_private_access = var.cluster_endpoint_private_access
  cluster_endpoint_public_access  = var.cluster_endpoint_public_access
  # cluster_endpoint_private_access_cidrs =
  cluster_endpoint_public_access_cidrs = var.cluster_endpoint_public_access_cidrs

  cluster_addons = {
    coredns = {
      resolve_conflicts = "OVERWRITE"
    }
    kube-proxy = {}
    vpc-cni = {
      resolve_conflicts = "OVERWRITE"
    }
  }

  cluster_encryption_config = [{
    provider_key_arn = aws_kms_key.eks.arn
    resources        = ["secrets"]
  }]

  node_security_group_additional_rules = {
    ingress_karpenter_webhook_tcp = {
      description                   = "Control plane invoke Karpenter webhook"
      protocol                      = "tcp"
      from_port                     = 8443
      to_port                       = 8443
      type                          = "ingress"
      source_cluster_security_group = true
    }

    ingress_self_all = {
      description = "Node to node all ports/protocols"
      protocol    = "-1"
      from_port   = 0
      to_port     = 0
      type        = "ingress"
      self        = true
    }
    egress_all = {
      description      = "Node all egress"
      protocol         = "-1"
      from_port        = 0
      to_port          = 0
      type             = "egress"
      cidr_blocks      = ["<IP_ADDRESS>/0"]
      ipv6_cidr_blocks = ["::/0"]
    }
  }

  manage_aws_auth_configmap = true
  aws_auth_accounts = var.grant_access_iam_accounts
  aws_auth_roles    =  local.aws_auth_roles
  aws_auth_users    = local.aws_auth_users

  eks_managed_node_group_defaults = {

    disk_size = 50
    vpc_security_group_ids = var.allow_ssh_access ? [aws_security_group.ssh[0].id] : []

    post_bootstrap_user_data = <<-EOT
      cd /tmp
      sudo yum install -y https://s3.amazonaws.com/ec2-downloads-windows/SSMAgent/latest/linux_amd64/amazon-ssm-agent.rpm
      sudo systemctl enable amazon-ssm-agent
      sudo systemctl start amazon-ssm-agent
      EOT

    iam_role_additional_policies = flatten([
      "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore",
      var.iam_role_additional_policies,
    ])

    use_name_prefix = false
  }

  self_managed_node_groups = {}
  eks_managed_node_groups = {

    // ▩ APPS ###############################################################################################
    apps-v3 = {
      name         = "prod-apps-v3"
      min_size     = 1
      max_size     = 5
      desired_size = 1
      subnet_ids = [
        "subnet-0235597d55d03df7f",
        "subnet-09f9ef6e5d66fd4ac",
        "subnet-026382e532aaed88c"
      ]
      instance_types = ["t3.medium"]

      labels = {
        apps     = "true"
        workload = "apps"
      }
      taints = []

      ebs_optimized = true
      capacity_type = "ON_DEMAND"

      iam_role_additional_policies = [
        "arn:aws:iam::xxx:policy/xxx-prod-eks-ecr-policy",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-s3-policy",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-secretmanager-policy",
        "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore",
        "arn:aws:iam::aws:policy/AmazonEC2ReadOnlyAccess",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-efs-policy",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-backup-policy"
      ]

      block_device_mappings = {
        xvda = {
          device_name = "/dev/xvda"
          ebs = {
            volume_size           = 50
            volume_type           = "gp3"
            encrypted             = true
            kms_key_id            = "arn:aws:kms:us-east-1:xxx:key/f2bcff18-395c-47c6-a442-7f859285b6e0",
            delete_on_termination = true
          }
        }
      }

      create_security_group = false
    }

    // ▩ APPS SPOT / KARPENTER ##############################################################################
    karpenter-v3 = {
      name         = "prod-karpenter-v3"
      min_size     = 1
      max_size     = 5
      desired_size = 1
      subnet_ids = [
        "subnet-0235597d55d03df7f",
        "subnet-09f9ef6e5d66fd4ac",
        "subnet-026382e532aaed88c"
      ]
      instance_types = ["t3.medium"]

      labels = {
        apps      = "true"
        workload  = "apps"
        spot      = "true"
        karpenter = "true"
      }
      taints = []

      ebs_optimized = true
      capacity_type = "SPOT"

      iam_role_additional_policies = [
        "arn:aws:iam::xxx:policy/xxx-prod-eks-ecr-policy",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-s3-policy",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-secretmanager-policy",
        "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore",
        "arn:aws:iam::aws:policy/AmazonEC2ReadOnlyAccess",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-efs-policy",
        "arn:aws:iam::xxx:policy/xxx-prod-eks-backup-policy"
      ]

      block_device_mappings = {
        xvda = {
          device_name = "/dev/xvda"
          ebs = {
            volume_size           = 50
            volume_type           = "gp3"
            encrypted             = true
            kms_key_id            = "arn:aws:kms:us-east-1:xxx:key/f2bcff18-395c-47c6-a442-7f859285b6e0",
            delete_on_termination = true
          }
        }
      }

      create_security_group = false
    }
  }

  enable_irsa = var.enable_irsa

  tags = merge(var.tags, {
    cluster                                     = var.cluster_name
    "karpenter.sh/discovery"                    = var.cluster_name
    "kubernetes.io/cluster/${var.cluster_name}" = "owned"
  })
}

this creates:
EC2

ASG

Launch Templates

Expected behavior
A new and single EC2 instance to be added if current number of instances is 1.
Actual behavior
Many EC2 instances added incrementally by updating the ASG, which is very time consuming, especially if max_size is >1

I think i have experienced something similar :eyes:

@dmitry-mightydevops this is most likely due to the rolling update config for EKS managed node groups. Can you try setting max_unavailable or max_unavailable_percentage to 0 https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_node_group#update_config-configuration-block

The valid range for max_unavailable is 1 - 100. A cluster with desired instance of 1, min 0 and max 3 will hike to desired instance of 6 and max 8 instances! Then it eventually (~30mins) shrink back to desired instance of 1 and max 3.
Any idea why is this behavior? The pods become (un-necessary) busy hopping from one node to another.

Closing since this is not a module issue but a configuration setting. Please see https://docs.aws.amazon.com/eks/latest/userguide/managed-node-update-behavior.html

So I tested and max_unavailable and it has no effect - still  getting a lot of nodes added and then removed. Changing new group (update ops) becomes very time consuming =~20-30m  and it's much faster to just add a new entry in the eks_managed_node_groups, then kordon/drain and then remove the original nodegroup.


Add pipeline io

close #1304

Can you pl. squash all the commits.

Can you pl. squash all the commits.

I believe Frank has enabled squash and merge so we can squash when we merge the pr.


Macro for asm-code inline

I suggest a macro ASM_INLINE ... END_INLINE  to include asm-code into a DX-sequence:
	IF tokenised
		MACRO ASM_INLINE
	    		DB high($+2), low($+2)
		ENDM
	ELSE
		MACRO ASM_INLINE
	    		DW $+2
		ENDM
	ENDIF

	MACRO END_INLINE
	    LD IY,$+7
	    JP next
	ENDM

This macro can be placed into zenv.asm after MACRO HEADER, for example.
There are  small Forth-words (few asm-instructions) but "JP next" is an expensive operation. Including code allows us to improve efficiency (by decreasing clarity, perhaps).
For example, let's use this macro in "DABS" (zenv.asm).
	; ( d -- |d|)    - in original zenv.asm incomplete comment "; ( d -- d)"
	; : DABS
	HEADER dabs, "DABS", 0
dabs:
	CALL colon_code
	; DUP 0< IF
	DX dup
	DX zero_less
	DX if_raw
	DB .then-$-1
         	; 0. 2SWAP D-
	      ASM_INLINE
         	LD DE,0
         	POP BC
         	PUSH DE
         	PUSH DE
         	PUSH BC
	      END_INLINE
              	;( 0 d )
	      DX d_minus
	; THEN ;
.then:
	DX exit

There is a better macro END_INLINE:
	MACRO END_INLINE
		call end_inline
	ENDM

The label end_line must be in colon_code:
; CALL colon_code in code
colon_code:
	; Push current PC to RS
	DEC IX
	DEC IX
	PUSH IY
	POP BC
	LD (IX+0), C
	LD (IX+1), B
	; Get new PC from stack
end_inline:
	POP IY
	; fall through

This is a great idea, and the code all looks nicely optimised/clean. I will play around with this after work.
I will probably not add it because I don't like writing colon words that couldn't (mostly) be compiled at the interpreter. I can't think about how to add inlining to the current compiler, without significantly increasing the size of the binary. (Load time is important to me, since I do test the system on an actual Spectrum as well as an emulator, and want it to be as 'real' and practical as I can, this is why the Forth is tokenised by default).
I am currently working on a direct threaded x86-64 Forth for UEFI, and I will probably apply this idea there, where I don't mind the compiler being more sophisticated.

A inline code is mostly faster but larger (especially when compared to tokenized system). Sometimes you can win both speed and size if you replace a few Forth-words (with literals) to a code. However the disadvantage of inline code is that decompiling back to the original source code becomes very difficult. You may want to add a decompiler in the future.
The entry "end_inline:" can be useful even now (without inline macro).  Your system has several "POP IY \ JP next" fragments. This can be replaced with "JP end_inline" (it might be better to rename the label "end_inline" for clarity).

A inline code is mostly faster but larger (especially when compared to tokenized system). Sometimes you can win both speed and size if you replace a few Forth-words (with literals) to a code. However the disadvantage of inline code is that decompiling back to the original source code becomes very difficult. You may want to add a decompiler in the future.

Yes, these are some of the considerations I have had. Although I don't expect to add a decompiler.

The entry "end_inline:" can be useful even now (without inline macro). Your system has several "POP IY \ JP next" fragments. This can be replaced with "JP end_inline" (it might be better to rename the label "end_inline" for clarity).

Good idea, I'll replace those.

I've added the POP IY \ JP next shortcut in 4e720da5, closing this issue without fixing because I do not want to add inlining as if I spend more time on this project I will probably write a trivial cross-compiler to allow writing Forth source code instead of this assembly macro stuff, which would probably be too dumb for inline assembly.


chore: automated PR to update VHDVersion for 202406.05.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 202406.05.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.969%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3458

💛  - Coveralls


[ICU] Missing debug symbols (LNK4099)

ParaView links Qt which links ICU
I see a lot of warnings due to missing debug symbols such as:
icuind.lib(ucol_res.ao) : warning LNK4099: PDB 'vc140.pdb' was not found with 'icuind.lib(ucol_res.ao)' or at 'D:\paraview_qt\buildtrees\paraview\x64-windows-static-dbg\bin\vc140.pdb'; linking object as if no debug info
icuind.lib(ucol.ao) : warning LNK4099: PDB 'vc140.pdb' was not found with 'icuind.lib(ucol.ao)' or at 'D:\paraview_qt\buildtrees\paraview\x64-windows-static-dbg\bin\vc140.pdb'; linking object as if no debug info
icuind.lib(ucal.ao) : warning LNK4099: PDB 'vc140.pdb' was not found with 'icuind.lib(ucal.ao)' or at 'D:\paraview_qt\buildtrees\paraview\x64-windows-static-dbg\bin\vc140.pdb'; linking object as if no debug info

in the build log.

Resolved or fixed?

just getting rid of stuff i don't care about ;) Also if /Z7 gets correctly forwarded (which it might now) it shouldn't generate those errors


Light behaves differently in customShader than it does in normal scenarios

So here’s a model, in the normal case, that looks something like this

When I added,
Cesium. ExperimentalFeatures. EnableModelExperimental = true;
after,
The lighting is too extreme

However, after I remove the lighting, I can’t see the outline clearly. How do I get the effect of figure 1 in CustomShader

@xuebingzzz I think what's happening here is ModelExperimental does not yet support image-based lighting, so glossy surfaces are far too dark.
Fortunately, we are actually working on adding IBL to ModelExperimental in the next couple weeks. See these issues:

https://github.com/CesiumGS/cesium/issues/10059 (in progress)
https://github.com/CesiumGS/cesium/issues/9838

Just to cross-link things, this issue corresponds to this forum post

Now that IBL has been added to the shader, the existing effect seems to be to replace the completely black texture with shadows, but when the lighting changes, this part of the texture does not change, and I'm not sure if the IBL takes reflections into account.

This is the display effect of the model under different lighting, the color of the marked part is always unchanged


fix #114416 LabelService.getUriLabel bad relative path if in root workspace

This PR fixes #114416
First commit is just a new test to show the problem.
Second commit will be the fix.

@gjsjohnmurray thanks for the PR. It looks good to me -> approved
Also adding @JacksonKearl as a reviewer since he touched that code last and has more context than me.

@gjsjohnmurray thanks for the PR. It looks good to me -> approved
Also adding @JacksonKearl as a reviewer since he touched that code last and has more context than me.

Looks, good, thanks!

Looks, good, thanks!


[skip] Question mark operator.

This commit introduces the postfix question mark operator, which semantically desugars as follows:
// For a value `x` of type `Result<T, E>`:
x?

// desugars to:
x match {
| Success(v) -> v
| Failure(err) -> return Failure(err)
}

// For a value `x` of type `Option<T>`:
x?

// desugars to:
x match {
| Some(v) -> v
| None _ -> return None()
}

In practice, it is actually desugared to:
x.branch() match {
| ControlFlowContinue(v) -> v
| ControlFlowBreak(r) -> return <ReturnType>::from_residual(r)
}
// where `<ReturnType>` is the return type of the current function.

which works on any type implementing the following Try trait:
trait Try<+TOutput, +TResidual> {
  fun branch(): ControlFlow<TOutput, TResidual>;
  static fun from_residual(r: TResidual): this;
}

NOTE: This is more of a proof of concept, as I am not too familiar with the typer, or with the FastOption implementation.

Thinking a bit more, the magic/builtin nature of the language's ;-return monad will prevent being able to use it with a monad transformer defined in the language. So that kills that approach I think.
I think I would call this something like EarlyReturn rather than Try to avoid confusion with association to exceptions, as this doesn't have anything to do with them.
Am I missing something, or could this be simplified by noting that the ControlFlow type is isomorphic to Result, and so couldn't the trait be defined as:
trait Try<+T, +E> {
  fun toResult(): Result<+T, +E>;
}

and the expansion of x? be:
x.toResult() match {
| Success(v) -> v
| Failure(e) -> return e
}

Then when defining the instances, the toResult function would not be specialized to just this usage, but could be generally useful.

Thinking a bit more, the magic/builtin nature of the language's ;-return monad will prevent being able to use it with a monad transformer defined in the language. So that kills that approach I think.

I will fully trust you on that.

I think I would call this something like EarlyReturn rather than Try to avoid confusion with association to exceptions, as this doesn't have anything to do with them.

Agreed, the name Try is confusing. Will update to EarlyReturn.

Am I missing something, or could this be simplified by noting that the ControlFlow type is isomorphic to Result, and so couldn't the trait be defined as:
trait Try<+T, +E> {
  fun toResult(): Result<+T, +E>;
}

and the expansion of x? be:
x.toResult() match {
| Success(v) -> v
| Failure(e) -> return e
}

Then when defining the instances, the toResult function would not be specialized to just this usage, but could be generally useful.

Do you mean having Result implement toResult(): Result<T, Failure<void, E>> or toResult(): Result<T, E>?
In both case, simply writing
x.toResult() match {
| Success(v) -> v
| Failure(e) -> return e
}

would not work for things such as:
fun bar(): Result<String, Error> { ... }

fun foo(): Result<Int, Error> {
  x = bar()?;
  if (x == "hello") {
    Success(1)
  } else {
    Success(2)
  }
}

which is expected to be a common use case. The reason is that bar()? would return either Failure<String, Error> or Failure<void, Error>, neither of which are Failure<Int, Error>. This is the main reason why I'm doing type erasure and fiddling with the typer in the first place. Or am I missing something?

I would be a lot more comfortable if we could implement this as just a syntactic expansion, without needing any tricks in the type checker. I played with this a bit more and so far I'm encouraged. With the following in Result.sk:
  fun toResult<U>(): Result<T, Failure<U, E>>
  | Success(val) -> Success(val)
  | Failure(err) -> Failure(Failure(err))

and the following in Option.sk:
  fun toResult<U>(): Result<T, None<U>>
  | Some(val) -> Success(val)
  | None() -> Failure(None())

then the following code type-checks:
type Error = Float;

fun bar1(): Result<String, Error> {
  if (Random.next() / 2 == 0) {
    Success("baz")
  } else {
    Failure(0.0)
  }
}

fun foo1(): Result<Int, Error> {
  x = bar1().toResult() match {
  | Success(v) -> v
  | Failure(e) -> return e
  };
  if (x == "hello") {
    Success(1)
  } else {
    Success(2)
  }
}

fun bar2(): ?String {
  if (Random.next() / 2 == 0) {
    Some("baz")
  } else {
    None()
  }
}

fun foo2(): ?Int {
  x = bar2().toResult() match {
  | Success(v) -> v
  | Failure(e) -> return e
  };
  if (x == "hello") {
    Some(1)
  } else {
    Some(2)
  }
}

This makes me think that we could make
x?

expand to
  x.toResult() match {
  | Success(v) -> v
  | Failure(e) -> return e
  }

What I don't think is possible is to define a trait for the toResult function. Consider the two instances for Option and Result:
  fun toResult<U>(): Result<T, None<U>>
  fun toResult<U>(): Result<T, Failure<U, E>>

In order to unify those, we need to be able to abstract over a type constructor, which would be U -> None<U> in the Option case and U -> Failure<U, E>> in the Result case. We would need a way to specify those when declaring that Option and Result implement the trait. For that we would need higher-kinded polymorphism, functors, etc.
Personally, I think I would prefer to have a simple syntactic expansion that just generates calls to the toResult function, and leave the trait implicit. It would mean that we could not use the trait as a constraint on type parameters, and so could not write code that is e.g. parametric over Option and Result, but I don't think that we can really do that without functors anyhow.

This indeed works. One drawback with having the construction be a simple syntactic expansion is error messages (the typer will complain about .toResult() not being defined or not returning the correct type if ? is used on types that are neither Option nor Failure), but I don't think it matters much at this point and we can always change the implementation later.


Render control on selected mesh

Hi,
Does Neuroglancer support changing opacity, silhoutte levels per segmentation (mesh)?  For example, having entire segmentations of the brain transparent except one segmentation solid.
Thank you,
m

I open the same volume in two different layers to achieve that...

Yes, what @moenigin suggested is the way to do it at the moment.

Thanks @moenigin and @jbms for verifying!


5.0 Diagrams update

New Pull Request Checklist

[X] I have read and understood the CONTRIBUTING guide

[X] I have read the Documentation

[X] I have searched for a similar pull request in the project and found none

[X] I have updated this branch with the latest 5.x to avoid conflicts (via merge from master or rebase)

This merge request fixes / reffers to the following issues: #2285
Pull Request Description
Updated the StarUML diagrams + added a High Level Diagram (thanks to @dreampiggy)

@dreampiggy please review and merge. I thought the diagram you created was very good for a high level overview of our architecture, so I added it as well.
I mean this one

Codecov Report

Merging #2407 into 5.x will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              5.x    #2407      +/-   ##
==========================================
+ Coverage   68.72%   68.87%   +0.15%
==========================================
  Files          47       47
  Lines        6634     6634
==========================================
+ Hits         4559     4569      +10
+ Misses       2075     2065      -10

Flag
Coverage Δ

#iOS
70% <ø> (+0.16%)
:arrow_up:

#macOS
68.61% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

SDWebImage/SDWebImageDownloader.m
80.82% <0%> (-0.35%)
:arrow_down:

SDWebImage/SDWebImageDownloaderOperation.m
88.31% <0%> (+3.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919751f...ac127b4. Read the comment docs.

Here are the new diagrams (so it's easy for the review):
Class Diagram

Sequence Diagram

CC @zhongwuzw @mythodeia @skyline75489

LGTM

Actually, from the one big class diagram, created several smaller ones:

still one overall class diagram, but that doesn't list any attributes, methods
dedicated diagrams for each section (containing a bigger level of detail)

top level API (WebCache categories, Prefetcher, Manager)
manager
coders
loader
cache

Created a Docs/Diagrams folder.
showcase of README
High Level Diagram

Overall Class Diagram

Top Level API Diagram

Main Sequence Diagram

More detailed diagrams

Manager API Diagram
Coders API Diagram
Loader API Diagram
Cache API Diagram

The more detailed diagrams
Manager API Diagram

Coders API Diagram

Loader API Diagram

Cache API Diagram

I'm merging (was approved).


Does it support WasmJs? not JS.

I found this error "No matching variant"

not yet, but i think that's a fair ask and we should update it


svdpatch classes

Entirely aesthetic patch.

On the whole I like this PR, thanks! The script probably should have used classes from the beginning. I'll need a little more time to review it as I'm quite busy the next couple of days and want to check it carefully.

I'm happy with the changes but please fix the merge conflict and then I'll merge this in.

Done.
I sleep when you merge :).

bors r+


Persist Settings for ConEmu

Would you be willing to update the conemu manifest to persist settings across updates?  I think it would mean setting the following:

persist: ConEmu.xml
Tell ConEmu to load the xml file from the persist folder.  This I'm less sure about - looks like it by default will load from the same folder as the exe.  There's a command line switch -LoadCfgFile file.  Can scoop make it always use this?

Thanks!

Fixed. You could move the ConEmu.xml to %APPDATA%\ConEmu.xml. See: https://conemu.github.io/en/SettingsFast.html

Thanks!


Removed PHP 5 exception catch

Now that we require PHP 7, the Throwable catch will suffice.

Coverage increased (+0.01%) to 92.351% when pulling 16d862fa123b0b47c8399f39ec1d2f3d90a696ab on GrahamCampbell:patch-4 into b3fcf260afa036de3afc1bea693373ac00261af4 on FriendsOfPHP:master.

Thank you @GrahamCampbell.


Switch Spectrogram to utilizing pre-signed URLS

The current system is creating a local image (and for non-compressed) storing in minio and then converting it to base64 so it can be transfered to the front-end.  This was just done initially to have something to display.  It would make more sense to utilize pre-signed URLs.

Use the default_storage.url(fileField) like in: https://github.com/Kitware/batai/blob/main/bats_ai/core/views/recording.py#L104
convert endpoints for spectrogram to utilize a pre-signed URL instead of the base64 text
Update the client to utilize the pre-signed url instead of base64.

Compressed View
It may make sense to make a compressed view that is also stored in MinIO. We may just have it updated when annotations are edited so it has some sort of caching system.

The system is using presigned URLs now that are stored in MinIO instead of directly generating the spectrogram every time.
This can be seen here: https://github.com/Kitware/batai/blob/main/client/src/api/api.ts#L111
Also here in the initalieViewer function for the geoJS layer it uses the URL directly to render the image:
https://github.com/Kitware/batai/blob/main/client/src/components/geoJS/geoJSUtils.ts#L117

fixed in #104


Possible Duplication in Function IfNull

Enhancement
I find two implementation of IfNull function:

one is a reusage in tiflash: https://github.com/pingcap/tiflash/blob/973de13fef5e787be1f2867f2a4fbb4af20ee77d/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzerHelper.cpp#L435-L458
one is from clickhouse: https://github.com/pingcap/tiflash/blob/master/dbms/src/Functions/FunctionsNull.h + https://github.com/pingcap/tiflash/blob/master/dbms/src/Functions/FunctionsNull.cpp

I did some experiments to see that the implementation from clickhouse is actually not used at all. But I still not sure if the IfNull from clickhouse can be removed? So we can discuss about it.

Yes, I think it can be removed.


slower using local file system than remote

We've been using imgproxy hosted on a heroku app that is remote to our app that consumes imgproxy URLs for a little while now and have been happy with its performance (requests take around 1 - 2 seconds for processing and a roundtrip on the wire).
Recently we thought we might be able to extract more performance by hosting imgproxy on the same server that is making requests for resizing.
We've setup imgproxy to use the local filesystem using the instructions provided in the docs.
Imgproxy is succesfully processing files locally, but the speed is actually about 4x slower (so approx. 4 seconds) than making network requests to the remote instance of imgproxy being served by heroku.
Any experience with this? Or ideas on why imgproxy seems to be slower locally than remotely? FWIW the computing power on the local server should be greater than the heroku dynos we have.

Nevermind, there was a speed issue resolving localhost. It had nothing to do with imgproxy itself.

Hey Jared!
It's hard to believe that serving local images can be 4x slower than serving remote ones. I'd recommend you to set up some monitoring and take a look at downloading time and processing time metrics.

Closing due to no activity here

Closing due to no activity here


insert into 的数据 不能建rollup ,但是spark load的数据就可以

errCode = 2, detailMessage = rollup task failed after try three times: task type: ALTER, status_code: RUNTIME_ERROR, status_message: [alter failed, status: DORIS_ERROR], backendId: Backend [id=11001, host=<IP_ADDRESS>, heartbeatPort=9050, alive=true], signature: 192580

Rollup can only be used on aggregate models, is your data model a Duplicate key？


Fix cardinal.rb cask

Homebrew's Cask DSL currently lacks the idioms for handling these operations cleanly and user-friendly. Closing this issue until a cleaner solution is available.


storyblok-migrate crashes when display_name is null

Current behavior
storyblok-migrate crashes when display_name is null after the question 'Migrate all components? '
// storyblok/new.js
module.exports = {
  name: "new",
  display_name: null,
  schema: {
    title: {
      pos: 0,
      type: 'text',
    },
  },
  image: null,
  preview_field: null,
  is_root: false,
  is_nestable: true,
  all_presets: [],
  preset_id: null,
  real_name: "new",
  component_group_uuid: null
};

#  npx storyblok-migrate or
$ npx storyblok-migrate --component-migrations --components new
null component has been updated
✔ Do you want to run component migrations? · No / Yes
✔ Migrate all components? · No / Yes
(node:20516) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'choices' of null
    at reset (/Users/aboulmane/.project/CMS/storyblok-migrate/node_modules/enquirer/lib/types/array.js:646:30)
    at MultiSelect.get choices [as choices] (/Users/aboulmane/.project/CMS/storyblok-migrate/node_modules/enquirer/lib/types/array.js:582:12)
    at MultiSelect.get focused [as focused] (/Users/aboulmane/.project/CMS/storyblok-migrate/node_modules/enquirer/lib/types/array.js:623:23)
    at MultiSelect.submit (/Users/aboulmane/.project/CMS/storyblok-migrate/node_modules/enquirer/lib/types/array.js:530:23)
    at Promise (/Users/aboulmane/.project/CMS/storyblok-migrate/node_modules/enquirer/lib/prompt.js:234:21)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:20516) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:20516) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Expected behavior
no crash
Environment
node --version: v10.15.3
storyblok-migrate: ^0.3.1

Thank you for your detailed bug report!
I'll think about using the name as a fallback if display_name is not specified to fix this. Thanks!


Facebook Sign-In feature

I would like to work on this issue

Update your forked repository and then start working on it. If you need access to firebase, send me your email.

Okay. I will need firebase access. Email:-<EMAIL_ADDRESS>

Oh sorry for the delay. I have added your email as an editor.


[CMake with Swift] Set rpath for stage != 0 bootstrapping builds.

@swift-ci please smoke test

lldb-shell :: SwiftREPL/BreakpointSimple.test failure is unrelated. I'm forging ahead to get this rolled out to more CI.


add plugin hyper-single-instance

An extension which prevents the creation of multiple Hyper.app windows.

You can view the deployed app at: https://hyper-site-mgudzhgput.now.sh
(This is an autogenerated message.)

Thanks for the request, I have updated it.


"Command Suggestions" setting gets turned off

In versions 1.2.1 and <IP_ADDRESS>, whenever I reset, the setting "Command Suggestions" (in Options -> Chat Settings in bottom left) automatically gets turned off. It doesn't happen if I join an already existing world. It also doesn't happen in version 1.2.0.

that sounds like you have the line 'autoSuggestions:false' in your standardoptions.txt, if not, could you send me the file?

No, I tested it with a file that just says "autoJump:false", but here's what was in the file initially: https://textsaver.flap.tv/lists/4zxt .
I believe that if there's no line "autoSuggestions:...", the mod just assumes there is "autoSuggestions:false", because when I added "autoSuggestions:true" to the file, it worked fine.
Also I believe that it wasn't initially in the file because it wasn't in the older versions of standardsettings, and when I changed the mod to a newer version, it obviously didn't add it.

i assume you're playing on minecraft version 1.16.1?

could you also send me a video of the bug happening because i can't seem to reproduce the issue

if you still want me to record the video, feel free to ask

also yes, 1.16.1

oooooh i just checked the code, turns out i forgot to add one 'break' line in the switch statement when making it java 8 compatible, will be fixed in the next update whenever that comes out!


App(v 5.4.1) not working on both "Web browser" and on "New Teams", but it works on desktop app when using "Old Teams"

Hi, It seems the app (v 5.4.1) does not work at all on the browser, no matter if using the "Old Teams" or "New teams" and it only works on "Old Teams" when using the desktop app.
I have seen that the issue has been fixed but it means changing to version 5.5 which we do not want to do at this moment since it has some additional features that we do not require. Can this issue be fixed without upgrading to version 5.5?

Is there no way to make it work without updating to the new version? We really don't want to upgrade to a new version since we have made some modifications to the app. Will there be another branch where this issue will be fixed for earlier versions? If not, then could you point me to the direction as to why version 5.4 does not work on "New Teams" and on the web browers and how this has been fixed on the new version?

Hola, buen día.
Levante un caso con Microsoft TrackingID#2311220040007768
Me apoyo Ericka De la Paz Chaves, me comento que levantara un reporte aquí para saber cuándo se liberara la versión de Company Communicator con la nueva versión de Teams.
Me apoyarían con lo solicitado por favor.
Quedo atento a sus comentarios.
Cordial Saludo.


Set ZHA device availability on new join

Fix device availability on new joins

They just need to rerun... happens a lot

@dmulcahey please use "squash & merge" when merging in the future 👍


Don't check for updates when checking for updates is disabled

Tested versions: DBeaver CE 4.0.8, 4.1.0
I have the following settings in Window -> Preferences:
Install/Update -> Automatic Updates: unchecked "Automatically find new updates and notify me"
Despite this there is a HTTP request for http://dbeaver.jkiss.org/product/version.xml during startup (somewhere else?).
Expected behaviour: no external requests coming from the program when updates are disabled.

Right option is: Preferences->Database->Automatic updates check.
Install/Update -> Automatic Updates is Eclipse specific option. I will disable it (as it is doesn't make sense).

Well, I have this option unchecked, too. It doesn't help, there is still HTTP request for http://dbeaver.jkiss.org/product/version.xml few seconds after start.

Yep, DBeaver always reads version.xml.
This option affects only on version update dialog visibility.
I'll fix this too, thanks for noticing.

issue has reappeared as of 7.0.1

The relevant setting seems to have moved to User Interface (no subcategory), presumably since 7.0.

The relevant setting seems to have moved to User Interface (no subcategory), presumably since 7.0.

I am using version <IP_ADDRESS>106021338 and I have unchecked Window -> Preferences -> General -> Install/Update -> Automatic Updates -> Autimatically find new updates and notify me.
In spite of that, DBeaver keeps checking for new versions and popping up a "new version available" dialog on start.
How do I disable this?


Bugfix/test timeout

Hi,
Running the OpenEXR.IlmImf test on one of my dev machines takes about 38 minutes which exceeds the default CTest timeout of 1500 seconds, causing it to be marked as failing. This change just doubles the timeout to 3000 seconds. The machine is not terribly slow, it's a quad core Xeon @ 3.7Ghz, maybe the slower file access on Windows is partially at fault?
This is on Windows 10 with Visual Studio 2019, compiled with Debug/x64.
Test project C:/dev/openexr/openexr-build
Start 1: IlmBase.Half
1/5 Test #1: IlmBase.Half .....................   Passed    7.16 sec
Start 2: IlmBase.Iex
2/5 Test #2: IlmBase.Iex ......................   Passed    0.01 sec
Start 3: IlmBase.Imath
3/5 Test #3: IlmBase.Imath ....................   Passed   31.03 sec
Start 4: OpenEXR.IlmImf
4/5 Test #4: OpenEXR.IlmImf ...................   Passed  2343.49 sec
Start 5: OpenEXR.IlmImfUtil
5/5 Test #5: OpenEXR.IlmImfUtil ...............   Passed  100.89 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) = 2482.62 sec

I wonder if there's a smart way to cut the test4 time in half....

For comparison, here are the test times on the same hardware with CentOS 7 (dual boot machine):
Test project /home/darby/dev/openexr/openexr-build
Start  1: IlmBase.Half
1/11 Test  #1: IlmBase.Half .........................   Passed    1.03 sec
Start  2: IlmBase.Iex
2/11 Test  #2: IlmBase.Iex ..........................   Passed    0.00 sec
Start  3: IlmBase.Imath
3/11 Test  #3: IlmBase.Imath ........................   Passed    3.54 sec
Start  4: OpenEXR.IlmImf
4/11 Test  #4: OpenEXR.IlmImf .......................   Passed  338.07 sec
Start  5: OpenEXR.IlmImfUtil
5/11 Test  #5: OpenEXR.IlmImfUtil ...................   Passed   22.94 sec

I can't imagine there is that large of a difference between CPU usage, so I suspect it's the disk access. I double checked that disk compression was turned off on Windows 10:
> fsutil behavior query disablecompression
DisableCompression = 1  (Enabled)

@darbyjohnston, your test times are definitely indicating there is
something noteworthy about your machine, not just slower but slower in an
unexpected way.  Which you could argue is a good reason to have the test
fail, or you wouldn't have noticed it. Is there a way to specify the
timeout limit at execution time?
Just because I was curious, I timed the individual steps in IlmImfTest,
wondering if it would make sense to split the test into pieces.
160.57 testHuf
118.04 testOptimizedInterleavePatterns
63.93 testDeepTiledBasic
61.01 testDwaCompressorSimd
51.94 testTiledLineOrder
42.21 testMultiTiledPartThreading
37.33 testDeepScanLineBasic
36.06 testDwaLookups
34.10 testMultiPartFileMixingBasic
26.96 testSharedFrameBuffer
26.80 testCopyDeepScanLine
25.10 testLargeDataWindowOffsets
18.45 testScanLineApi
14.17 testOptimized
9.61 testRgbaThreading
9.36 testCopyDeepTiled
9.02 testYca
8.65 testTiledRgba
6.96 testTiledCopyPixels
6.96 testCompression
4.77 testCompositeDeepScanLine
4.00 testCopyMultiPartFile
3.52 testRgba
3.39 testRle
2.15 testMultiPartThreading
1.81 testConversion
1.59 testMultiPartApi
1.54 testInputPart
1.52 testNativeFormat
0.98 testTiledCompression
0.92 testWav
0.90 testTiledYa
0.77 testFutureProofing
0.65 testCopyPixels
0.56 testSampleImages
0.48 testStandardAttributes
0.42 testPreviewImage
0.15 testMultiScanlinePartThreading
0.07 testDeepScanLineMultipleRead
0.05 testIsComplete
0.05 testExistingStreams
0.03 testBadTypeAttributes
0.02 testLut
0.02 testLineOrder
0.01 testCustomAttributes
0.01 testBackwardCompatibility
0.01 testAttributes
0.00 testXdr
0.00 testPartHelper
0.00 testMultiView
0.00 testMultiPartSharedAttributes
0.00 testMagic
0.00 testChannels
0.00 testB 44ExpLogTable
On Mon, Aug 10, 2020 at 12:18 PM Darby Johnston<EMAIL_ADDRESS>wrote:

For comparison, here are the test times on the same hardware with CentOS 7
(dual boot machine):
Test project /home/darby/dev/openexr/openexr-build
Start  1: IlmBase.Half
1/11 Test  #1: IlmBase.Half .........................   Passed    1.03 sec
Start  2: IlmBase.Iex
2/11 Test  #2: IlmBase.Iex ..........................   Passed    0.00 sec
Start  3: IlmBase.Imath
3/11 Test  #3: IlmBase.Imath ........................   Passed    3.54 sec
Start  4: OpenEXR.IlmImf
4/11 Test  #4: OpenEXR.IlmImf .......................   Passed  338.07 sec
Start  5: OpenEXR.IlmImfUtil
5/11 Test  #5: OpenEXR.IlmImfUtil ...................   Passed   22.94 sec
I can't imagine there is that large of a difference between CPU usage, so
I suspect it's the disk access. I double checked that disk compression was
turned off on Windows 10:

fsutil behavior query disablecompression
DisableCompression = 1  (Enabled)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/openexr/pull/807#issuecomment-671539052,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFC3DGKRLLOIY65NG46LOH3SABBWRANCNFSM4PYJRM7A
.

--
Cary Phillips | R&D Supervisor | ILM | San Francisco

Hi @cary-ilm,
I tried testing on another machine (Windows 10 Home, 8 core Ryzen, NVMe drive), which I thought would be faster, and actually got worse results:
Test project C:/dev/openexr/openexr-build
Start 1: IlmBase.Half
Test #1: IlmBase.Half .....................   Passed    9.45 sec
Start 2: IlmBase.Iex
Test #2: IlmBase.Iex ......................   Passed    0.06 sec
Start 3: IlmBase.Imath
Test #3: IlmBase.Imath ....................   Passed   39.19 sec
Start 4: OpenEXR.IlmImf
Test #4: OpenEXR.IlmImf ...................   Passed  2900.37 sec
Start 5: OpenEXR.IlmImfUtil
Test #5: OpenEXR.IlmImfUtil ...............   Passed  131.07 sec

Maybe this could also be from building the code in "Debug" mode, which seems to have a larger performance impact on Windows than Linux?

Is there a way to specify the timeout limit at execution time?

I believe you can also set the timeout on the CTest command line.

@darbyjohnston - I do not know what it is, but in trying to get the github actions workflows running for windows, I also noticed that in debug mode, the windows tests are extremely slow (optimized, they seem fine). On the current master, I have split it such that each test runs as a separate test, hoping I could ask you to compile that in debug and narrow down which test is particularly slow and maybe do a bit of a profile to see what it is about that which is so much slower in debug? thanks in advance...
The main branch will will be in a high state of development flux for a little while as we're doing a full re-org after the Imath split, so it may look a bit different than what you have setup currently...

I don't have a reference available at the moment, but there is a large amount of heap-sanity checking that goes on in a MSVC debug build and hence the terrible performance. I believe that under VS2019 preprocessor macros were introduced that elide that facility and get comparable performance times to release (at least same order-of-magnitude, anyway). Given that release and debug builds under msvc have vastly different runtime behavior (zero-initialized versus not, sentinel values for constructed objects versus destructed objects, 0xfeeefeee to indicate freed allocations, and so on), I wonder what we might gain from running the tests in an msvc debug mode in general though?

I wonder what we might gain from running the tests in an msvc debug mode in general though?

Presumably a debug build of OpenEXRTest needs to be available to debug any issues reported by running tests in release mode. That would likely be done by running the OpenEXRTest binary directly, rather than via the ctest mechanism.
Now @kdt3rd has made it run tests separately, perhaps ctest in debug mode could default to running one brief test (e.g. testMultiPartApi) just to make sure that the OpenEXRTest binary builds and runs. Release mode ctest should still run all the tests.

@peterhillman I'm not arguing against having a debug build, clearly we benefit from that for debugging. I'm arguing that running (as opposed to building) the entirety of the full suite in debug mode isn't providing useful information in and of itself. To devil's advocate my own suggestion about running that build, it is true that the MSVC diagnostics detect double deletes and freed memory access, but I would argue that ASAN, TSAN, and UBSAN should be our focus instead on that front.
Anyway, as you note:
Now @kdt3rd has made it run tests separately, perhaps ctest in debug mode could default to running one brief test (e.g. testMultiPartApi) just to make sure that the OpenEXRTest binary builds and runs. Release mode ctest should still run all the tests

I think that would be an excellent resolution to the issue.

Hi Nick, the message you posted to OpenEXR dev discussion yesterday, "slow tests on Windows", I assume is related to this? I tried syncing the latest from master and using:
set(CMAKE_C_FLAGS /GS-)
set(CMAKE_CXX_FLAGS /GS-)
add_definitions(-D_ITERATOR_DEBUG_LEVEL=0)
add_definitions(-D_HAS_ITERATOR_DEBUGGING=0)

This reduced the test run time in debug mode from 2877 seconds to 2266 seconds.
When I initially opened this pull request I assumed that the tests should be run in debug mode, but if that's not the case then maybe this is a non issue? Instead of special casing the debug mode to only run a single test, maybe just don't run the tests at all for the GitHub actions Windows/debug run? As Peter mentioned if a test fails and needs to be debugged on Windows then a developer can run the OpenEXRTest binary directly.

That didn't make as a big a difference as I expected!
Don't run theGitHub actions to test specifically Windows/debug sounds like the right move to me.


Unwanted text at bottom of website

@ggoddard @santosomar the bottom of the "about" section of our website still has some lorem ipsum text = "Distinctively benchmark client-focused opportunities vis-a-vis 24/365 relationships. Progressively revolutionize equity invested synergy whereas emerging web services."

Corrected via https://github.com/BSidesRDU/website/commit/ce1b02493b54009a7853056b1ab85494c94df64b
thanks @ggoddard !!!


Update Virus.js | NEW UPDATE | What is it about |???

Tell me then i will close this if i know it :)

@Megabyte918

Please stop making pointless issues, I'm tired of it and so do megabyte


[Bingo] Reward Pokemon does not have HA

Describe the bug
Bingo Reward gave me a Cryogonal, which does not have a hidden ability.
To Reproduce
Steps to reproduce the behavior:

Finish Bingo and receive rewards
In box, look for the reward Pokemon

Expected behavior
Bingo rewards are to include:

Random Shiny Pokemon
Either a random shiny Pokemon or a random Pokemon with its HA. In both cases, Pokemon is to have at minimum 2 max IV's.

Screenshots
If applicable, add screenshots to help explain your problem.
I was told that the stats were also an issue, so here is the Cryogonal's stats.

Username:
Discord: Vanitas#0326
Server name (all applicable):
Kyagiri
Logs:
Where needed, please find your logs with the method down below. Make sure to include the file, or better yet, use a site like https://pastebin.com/ to add it to the ticket without copy pasting all the contents of the file.
For the Minecraft Launcher : C:\Users\USER\AppData\Roaming.minecraft\logs
For the Technic Launcher: C:\Users\USER\AppData\Roaming.technic\modpacks\pixelmon-reforged\logs
For the ATLauncher: C:\Users\USER\AppData\Roaming\ATLauncher\Instances\PixelmonCraft\logs
For the Twitch Launcher: C:\Users\USER\Documents\Curse\Minecraft\Instances\PACK\logs
(This was days ago so I have no idea how to track old logs like that)
Additional context

Hi, You may DM me on discord (JustStriide.#5784) if you've never been refunded for this and I can sort it out for you! However Bingo has had a lot of updates since this happened, I believe it's been fixed since this incident! Apologies for the inconveniences, If anything else occurs you may reopen this or make another ticket, Thanks and Closing!