feat: shell completion

Types of PR

[x] New Features

Description

change cli command
add document to setup shell completion

How to review this PR

Install cli and shell completion scripts.
Confirm that command completion works with Tab key

pipx uninstall driving-log-replayer-cli
git clone https://github.com/tier4/driving_log_replayer.git
cd driving_log_replayer
git checkout feat/scenario-completion
# install cli
pipx install .
# install shell completion

# for bash user
_DLR_COMPLETE=bash_source dlr > $HOME/.dlr-complete.bash
_DLR_COMPLETE=bash_source dlr > $HOME/.dlr-analyzer-complete.bash

echo "source $HOME/.dlr-complete.bash" >> ~/.bashrc
echo "source $HOME/.dlr-analyzer-complete.bash" >> ~/.bashrc

# for fish user
_DLR_COMPLETE=fish_source dlr > $HOME/.config/fish/completions/dlr.fish
_DLR_ANALYZER_COMPLETE=fish_source dlr-analyzer > $HOME/.config/fish/completions/dlr-analyzer.fish

# then command below.
dlr [Space] [Tab]

Others
Completion works like this video.

Maybe bellow checkout branch is correct.
git checkout feat/shell-completion
Please check it.

Maybe bellow checkout branch is correct. git checkout feat/shell-completion  Please check it.

Thank you. I fixed description


Exception right after login

So I was giving this project a try but as soon as I click that "Login" button it throws an exception. It only does it, when the user and password match with what's in users.json. It does not crash when it was not able to login but shows the login page again as expected.
TypeError: Cannot read property 'length' of undefined
   at Object.select (<PATH>\node_modules\express-admin\lib\qb\lst.js:42:27)
   at _data (<PATH>\node_modules\express-admin\routes\listview.js:38:9)
   at Object.exports.get [as handle] (<PATH>\node_modules\express-admin\routes\listview.js:26:2)
   at next_layer (<PATH>\node_modules\express-admin\node_modules\express\lib\router\route.js:103:13)
   at Object.exports.restrict [as handle] (<PATH>\node_modules\express-admin\routes\auth.js:20:31)
   at next_layer (<PATH>\node_modules\express-admin\node_modules\express\lib\router\route.js:103:13)
   at Route.dispatch (<PATH>\node_modules\express-admin\node_modules\express\lib\router\route.js:107:5)
   at <PATH>\node_modules\express-admin\node_modules\express\lib\router\index.js:213:24
   at Function.proto.process_params (<PATH>\node_modules\express-admin\node_modules\express\lib\router\index.js:286:12)
   at next (<PATH>\node_modules\express-admin\node_modules\express\lib\router\index.js:207:19)

Anyone experienced the same problem?

Which version of Express Admin you are using? I don't see such expression in \lib\qb\lst.js on line 42

Version 1.2.6
Sorry. It's on line 43 in the repository. I was already trying to fix it on my own and missed out putting a blank line in again.

Check you settings.json file, it should be generated and filled with defaults on first start. Your configuration is corrupted for some reason. I can't tell exactly what it is just by looking at this error message.

it seems I get empty req.params in getArgs (listview.js, line 16) which results in more undefineds along the way.

Which version of node do you use? How is your url looking in the browser's address bar, I can't imagine req.params being empty.

Node is version 0.12.0
The URL looks like this http://<IP_ADDRESS>:8080/backend
I'm running express-admin in embedded mode.
args = {dpath: "<PATH>",
        config: {sqlite: {database: "<PATH>/store.db"}
                 app: {upload: "<PATH>/uploads"},
                       root: "/backend",
                       layouts: true,
                       themes: true,
                       languages: true},
      settings: require("<PATH>/settings.json"),
      custom: {},
      users { ... }
};
......
app.use("/backend", admin);

Yeah but in order to get the error in the listview route you have to navigate to something like http://<IP_ADDRESS>:8080/backend/[slug] And after login the admin redirects to the mainview, not the listview.

@yhmtg my system tests just hanged on the login screen when using sqlite in node 0.12.
It seems that there is a breaking change in 0.12 that affects the admin, I'll take a look at it this weekend.

@yhmtg it turned out that I needed to re-build my sqlite3 module for node 0.12
Here is what I did
$ nvm use 12 # you use `nvm` right?
$ npm install -g express-admin<EMAIL_ADDRESS>$ admin /path/to/config

So as far as I'm concerned the admin is working with sqlite and node 0.12

Didn't work for me sadly. Still the same error.

If you can create a small test case that reproduce the bug it will be great. Like a small db with only one table + the config you are using.

I ran into the same problem.
I am using an sqlite db without explicitly specified primary keys.
Adding "pk": "rowid" to every table in settings.json fixed it for me.

Thanks for the feedback @bnny ! express-admin requires you to have primary keys in your tables. I'm adding rowid to my sqlite tables as well.

Hello,
Same for me like bnny, I'd to add the pk. The generator doesn't detect the pk. Same for the kind of field. If it's date, I'd to change manually in the config for the controller.
Kind regards.
JB.


panic when use Omit(clause.Associations) before Table(name)

GORM Playground Link
https://github.com/go-gorm/playground/pull/31
Description
Only panic when use Table(), it works with Model()

Fixed, thank you for your report.


Feature request: Breadcrumbs generation

Would like to see this feature as in this package: https://github.com/davejamesmiller/laravel-breadcrumbs
P.s. Any ideas how to pass breadcrumbs into .vue templates?

Hey, this isn't on our roadmap at the time. It's a cool idea, but out of scope for us I think.


List view for timelines (from 1872)

Problem Description:
The current list view for timeline data is not clear and needs work. It is not clear that the years are indeed years.
Expected Behavior/Solution:
The years will have B.C.E. or C.E. after them to clarify that they are years.
Requirements:

[x] Add B.C.E. for negative years
[x] C.E. for positive years

Needed for promotion:

[x] Wireframe/Mockup - Kam
[ ] ~Committee discussions - Sarah~
[ ] ~Feasibility/Team discussion - Sarah~
[ ] ~Backend requirements~
[x] Frontend requirements - Kam
[ ] ~Questions~

UAT/LUX Examples:

https://lux-front-tst.collections.yale.edu/view/person/34f4eec7-7a03-49c8-b1be-976c2f6ba6ba (tst)
https://lux.collections.yale.edu/view/person/34f4eec7-7a03-49c8-b1be-976c2f6ba6ba (prod)
https://lux-front-dev.collections.yale.edu/view/concept/4a172143-a50e-4d91-a88b-a9931bceecf1 (dev)

Note: This is the record for Visual Works but this UUID may change with the latest data.

https://lux.collections.yale.edu/view/concept/4a172143-a50e-4d91-a88b-a9931bceecf1 (prod)

Dependencies/Blocks:
N/A
Related Github Issues:

https://github.com/project-lux/lux-frontend/issues/15

Related links:

Bugherd: https://www.bugherd.com/projects/284041/tasks/1708

Wireframe/Mockup:
Current:

Expected:

@kamerynB was this deployed? the prod link does not show the B.C.E or C.E after the years: https://lux.collections.yale.edu/view/person/34f4eec7-7a03-49c8-b1be-976c2f6ba6ba
Also, the dev link of: https://lux.collections.yale.edu/view/concept/4a172143-a50e-4d91-a88b-a9931bceecf1 was in the UAT examples, I think this UAT is for a different ticket (#15) , correct?


crash at startup

Hi, since last patch, steam oni crashes with dupery active. no other mods involved. then i installed mod updater. it shows me dupery is up to date, but when i enable dupery and restart, crash again.
updating the mod revoked all my changes to override_personalites. I disabled all dupes with bad mods. Last time i checked, there were around 13 in the game.
Error in GameAssets(Clone).Assets.OnPrefabInit
System.NullReferenceException: Object reference not set to an instance of an object
at Dupery.Db_Initialize.Postfix () [0x002c4] in <85d0f6807230451392fa99081ed32394>:0
at (wrapper dynamic-method) Db.Db.Initialize_Patch3(Db)
at Db.Get () [0x0001c] in <33cbadb4d53344698461e1b8bda03e57>:0
at Assets.CreatePrefabs () [0x00000] in <33cbadb4d53344698461e1b8bda03e57>:0
at Assets.OnPrefabInit () [0x0027f] in <33cbadb4d53344698461e1b8bda03e57>:0
at KMonoBehaviour.InitializeComponent () [0x00068] in <53ba8544b0394db88dcaac034e1fe553>:0
at UnityEngine.Debug.LogError (System.Object message, UnityEngine.Object context) [0x00000] in <9fe2cbebfa394c8da6af069ec8cc9ef4>:0
at Debug.LogError (System.Object obj, UnityEngine.Object context) [0x00000] in <53ba8544b0394db88dcaac034e1fe553>:0
at DebugUtil.LogErrorArgs (UnityEngine.Object context, System.Object[] objs) [0x00000] in <53ba8544b0394db88dcaac034e1fe553>:0
at DebugUtil.LogException (UnityEngine.Object context, System.String errorMessage, System.Exception e) [0x00000] in <53ba8544b0394db88dcaac034e1fe553>:0
at KMonoBehaviour.InitializeComponent () [0x00000] in <53ba8544b0394db88dcaac034e1fe553>:0
at KMonoBehaviour.Awake () [0x00000] in <53ba8544b0394db88dcaac034e1fe553>:0
at UnityEngine.Object.Internal_InstantiateSingleWithParent_Injected (UnityEngine.Object data, UnityEngine.Transform parent, UnityEngine.Vector3& pos, UnityEngine.Quaternion& rot) [0x00000] in <9fe2cbebfa394c8da6af069ec8cc9ef4>:0
at UnityEngine.Object.Internal_InstantiateSingleWithParent (UnityEngine.Object data, UnityEngine.Transform parent, UnityEngine.Vector3 pos, UnityEngine.Quaternion rot) [0x00000] in <9fe2cbebfa394c8da6af069ec8cc9ef4>:0
at UnityEngine.Object.Instantiate (UnityEngine.Object original, UnityEngine.Vector3 position, UnityEngine.Quaternion rotation, UnityEngine.Transform parent) [0x00000] in <9fe2cbebfa394c8da6af069ec8cc9ef4>:0
at UnityEngine.Object.Instantiate[T] (T original, UnityEngine.Vector3 position, UnityEngine.Quaternion rotation, UnityEngine.Transform parent) [0x00000] in <9fe2cbebfa394c8da6af069ec8cc9ef4>:0
at Util.KInstantiate (UnityEngine.GameObject original, UnityEngine.Vector3 position, UnityEngine.Quaternion rotation, UnityEngine.GameObject parent, System.String name, System.Boolean initialize_id, System.Int32 gameLayer) [0x00000] in <53ba8544b0394db88dcaac034e1fe553>:0
at Util.KInstantiate (UnityEngine.GameObject original, UnityEngine.GameObject parent, System.String name) [0x00000] in <53ba8544b0394db88dcaac034e1fe553>:0
at LaunchInitializer.Update () [0x00000] in <33cbadb4d53344698461e1b8bda03e57>:0
Build: U41-498381-
HARDMODE.zip
S

There've been some updates so this may be fixed now. Thank you for reporting either way, I can only close this because I can't reproduce the error.
I don't know why your override_personalites file was reset by an update, but someone else reported a similar issue so I'm working on it.


Remove duplicate GetPoSKernelPS function.

Removed Duplicate function
Moved code around
Made required changes to area affected by the duplicate function to accept use of the same function.

Releated: #553

there added back the one u mentioned still would like to keep the NetworkWeight in rpcmining as double. I just didnt see a point setting nNetworkWeight for one calculation when it could of been casted

You can declare the var as double and use it at both places.

I have to redo this one something all messed on my end and half the code has magically re-appeared

will reopen with it fixed


don't see a close() on the NATS Vert.x client that would map to the NATS client close.

One more, I need help finding a close() on the NATS Vert.x client that would map to the NATS client close.

fixed in next release.


Fix generating id="" headers for headers that have markup.

Fixes Issue #222
This change goes a bit further than the last PR. It now does a better
job stripping markup from headers to generate more accurate values for
the id="" attribute.
This is a table of headers that I've tested, and their new output:
## Header1
## Header2 [ ]
## Header3
## header4
## [Sculpin](http://sculpin.io/)

Output for the preceeding headers:

Header1

Header2 [ ]

Header3

header4

Sculpin

I am not sure what the meaning is of the travis failure :S

@evert I've been seeing phpunit fail randomly on the test suite. I'm not sure why, either. I suspect there is some case where low enough test coverage causes it to fail sometimes? Not sure. :-/

Interesting :) .

Well, the error that I think is the cause for the failure is zend_mm_heap corrupted
Sounds pretty intense =) I also saw a segmentation fault in a different failure.

Looks like zend_mm_heap corrupted could mean literally anything. :)


Introduce the EURO - drop all the ancient currencies

Yeah, totally forgivable of course because it's all so new but just recently Europe introduced the EURO, a unified currency for many of the main European countries. Currencies like the French Frank, the Belgian Frank, the Dutch Guilder and the German Mark haven't been around FOR DECADES!!

Hey @wbovela , you realize that if a budget app didn't include the Euro for 9 years you wouldn't be the first one to notice?
The currencies list comes from your device, not the app. So it's still weird that your device doesn't include Euro but let's dig and find out why.
BTW, leaving a bad rating on my app publicly before discussing the problem here is really uncool. I understand you want the app to work but since it's open source, you have the opportunity to make it better, trashing it publicly doesn't help.

Now if you're kind enough to remove your comment on the PlayStore, would you also be cool with helping me understand what's going on @wbovela ?

Also, since you seems to be a dev too, let me share some code with you. Everything happens here: https://github.com/benoitletondor/EasyBudget/blob/master/Android/EasyBudget/app/src/main/java/com/benoitletondor/easybudgetapp/helper/CurrencyHelper.kt
As you can see, it uses the Currency class from the Android framework.
PS: this kind of attitude from a fellow dev really depresses me...

I'm sure you're very disappointed with a bad review, but the truth is that your application comes with nonsense currencies. There is nothing I can change about that and it is decidedly not my responsibility but yours.
What depresses me is that developers have the gaul to not only dish out nonsensical functionality, but then blame potential users for their shortcomings. If you KNOW that a platform can show Guilders, Marks and Francs, then take it into account and make sure your app doesn't come off looking as stupid as it does.
Even if your response was valid in any way, there is still nothing I can do about it; it is still your problem. Deal with that.

Alright then, thanks a lot for your help 😅


problem with installing Pytorch-Correlation-extension package

when I want to install Pytorch-Correlation-extension I get this error:
python setup.py install
TypeError: expected string or bytes-like object
Thank you for any help/hint !

Hi~
We have not encountered this error. Maybe you could try installing it via the pip command：
pip install spatial-correlation-sampler
Or find other solution from spatial-correlation-sampler community.


Grid generator

Description
I am proposing this idea to add a grid generator into code magic, have tried some research, and did some wireframes, and it will be useful for other developers if we add this grid generator, so the generated CSS can be easily used. #5
Screenshots

Additional information
No response
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

Assigned to you, please read the rules in the contributing file

Thank you @Dun-sin , i have read the contributing file

hi, @Thilakmani-dev an update please?

Yes @Dun-sin , i have gone through the code, started my work on this

Please assign this issue to me, i didn't see the previous comments

Please assign this issue to me, i didn't see the previous comments

Okay, when can I expect a pull request? Just to doesn't have to be fixed, just want to check in again at that time.

i will show you the progress in next week, is that fine @Dun-sin

i will show you the progress in next week, is that fine @Dun-sin

That's alright, good luck🍀💪🏽

Hi @Dun-sin i was sick last week, did some progress to start today

I am learning your code too, will post updates here

Hi @Thilakmani-dev an update please?

yes @Dun-sin  , I will share the completed part by this week

there's some css and bug fixes there, working on that @Dun-sin, hopefully will complete whole thing by this week

there's some css and bug fixes there, working on that @Dun-sin, hopefully will complete whole thing by this week

Perfect👍🏽 thanks for the update

there's some css and bug fixes there, working on that @Dun-sin, hopefully will complete whole thing by this week

Perfect👍🏽 thanks for the update

Looks like the grid generator is under the wrong category, shouldn't be input, but display

will look into this @Dun-sin

Hi @Dun-sin , i have completed the part, here is the preview of the output

Can I raise the #pr

Hi @Dun-sin , i have completed the part, here is the preview of the output  Can I raise the #pr

sure, follow the guidelines for making a PR in this project

Hi @Dun-sin , i have completed the part, here is the preview of the output  Can I raise the #pr

sure, follow the guidelines for making a PR in this project

Hi @Dun-sin , i have completed the part, here is the preview of the output  Can I raise the #pr

sure, follow the guidelines for making a PR in this project

https://github.com/Dun-sin/Code-Magic/pull/475

#475

keep in mind in the future you don't need to comment back on the Issue, it's not my first rodeo, so I see your PR and will definitely do the necessary. It will just cause unnecessary notifications for me and others.

okay @Dun-sin , will keep in mind

:tada: This issue has been resolved in version 2.68.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


invalid_request after logging in to access drone

Describe the bug:
I cannot access drone after a fresh Otomi install. The login for gitea works but I get the error 'invalid_request' when trying to access Drone, se example video.
To Reproduce
Steps to reproduce the behaviour:

Login to Otomi (I used default admin user)
Click on Apps -> Drone
Login to Drone
See error

Expected behaviour:
Acces to drone after successfully logging in.
Screenshots: (if applicable, add screenshots to help explain your problem)
https://images.zenhubusercontent.com/200118806/0b8fec3b-fc50-411b-9bc9-59309171b23a/screen_recording_2023_05_01_at_15_43_53.mov

Versions:

Kubernetes: 1.25
Otomi Core main
Otomi API main
Otomi Console main

I executed github action workflow 'Deploy Otomi' from main (f1ce10b)  with kubernetes version 1.25.

Got the same issue using Kubernetes 1.24 with latest main (f1ce10b)

created PR


Use exec -a in the FHS compliant script

If we exec gitea using an explicit exec -a we can set the name of the binary
to the script's name thus ensuring all written calls by gitea will go via
the script.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@118fbd9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #17513   +/-   ##
=======================================
  Coverage        ?   45.48%
=======================================
  Files           ?      793
  Lines           ?    88793
  Branches        ?        0
=======================================
  Hits            ?    40390
  Misses          ?    41893
  Partials        ?     6510

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118fbd9...5284383. Read the comment docs.


Type two sub-modules in napari.layers.utils

Description
Adds typing to two more files.

need resolve conflicts


Grid on an angular-ui bootstrap tab. Noticeable column header render issue.

Table content rendered fine, however headers don't appear initially and when they do they move table content down. Worked in 1.14.1 but an issue in 1.15.0 onwards. (I'm using Chrome)
See forum post for repro/plunk.

cleaning up old issues. if this a problem with the grid (ie not your application) then reopen and explain. grid has moved on many versions since this was raised.


Use our ATS server to proxy for Bintray

This does require #2015 though (on the CI box it's already running with that).

I'd like to put this into 7.1.x as well.


Distinguish between desktop and mobile

I writes a spider to crawl the web from PC front with ua.random, but sometimes, it would redirect to mobile front , that's not what I expected.
I found it caused by ua.random would return a mobile ua as below:
import requests
res = requests.get("https://fake-useragent.herokuapp.com/browsers/0.1.5")
print res.json()['browsers']['safari'][41]
# Mozilla/5.0 (Android 2.2; Windows; U; Windows NT 6.1; en-US) AppleWebKit/533.19.4 (KHTML, like Gecko) Version/5.0.3 Safari/533.19.4

From https://github.com/hellysmile/fake-useragent/issues/10#issuecomment-341654267, there will be eventually added ua.desktop and ua.mobile, I'm really looking forward to it.

@acefei I second this idea. Would be great to randomly select between desktop or just mobile depending on the implementation.

+1! 👍

Just tested - it's pretty easy to know if user-agent is meant to be mobile - just check for mobile in lowercase user-agent string.

Hi friends!
Try my changes - https://github.com/hellysmile/fake-useragent/pull/105
With it you can use ua.mobile and ua.desktop.

+1

https://github.com/fake-useragent/fake-useragent/issues/61#issuecomment-1651528207

@melroy89, why is that better than distinguishing between them?

We just don't have mobile user strings from the new data source.


Suggest to change the version number 2.7.2

I did a pod update recently and found build error in project due to SwiftIconFont.
After some debugging, I found SwiftIconFont updated from 2.7.1 to 2.7.2
The version 2.7.2 have migrated to support Swift 4.0.  But I still use Swift 3.2 to compile and got the errors.
It seems not a minor change. So I suggest to use a major version number to tag it.
It will be good to have a note on README too.
Thanks for your effort to maintain this lib.

Thanks for your attention. 👍


Touch up component detection

run only on success of previous steps

Why not always run?

Why not always run?

Seems wasteful and the artifacts the detection looks at likely won't exist if the previous step fails.


GDEXPO-26 - Refresh token

Refresh the accesstoken when it expires

Key: GDEXPO-26

Assignee: toraas

This is not needed after we moved to MSAL


Include the zipped extension in each release

Since #3421 added automatic releases, now we can also include the built extension for each release.
There are several actions that allow attaching files to releases, so we just need to ensure that they're compatible with our workflow, e.g.
    - name: Update extension’s meta
      env:
        VER: ${{ needs.Version.outputs.version }}
      run: |
        echo https://github.com/$GITHUB_REPOSITORY/tree/$VER > distribution/SOURCE_URL.txt
        npm run version
    - uses: actions/upload-artifact@v2
      with:
        path: distribution
+   - uses: *some action here*
+     with:
+       files:
+         - distribution
+       release: ${{ needs.Version.outputs.version }}
+       token: ${{ secrets.GITHUB_TOKEN }}

Perhaps this would be easier as a separate release.yml workflow with - on.push: [tags], but the automatic GITHUB_TOKEN doesn't trigger other workflows. If anyone knows knows a workaround (other than providing another token) please let us know.

we can also include the built extension for each release.

For what purpose?

e.g. users wanting to test previous versions in Chrome without having to build the extension.
Firefox hosts them on AMO (at least temporarily), but Chrome doesn't

@notlmn should this be part of https://github.com/notlmn/release-with-changelog?

@notlmn should this be part of https://github.com/notlmn/release-with-changelog
Or we could output release URL from that action, and use that to upload assets to the release using https://github.com/actions/upload-release-asset.
This is what https://github.com/actions/create-release does.

So everything seems to exist already except the changelog creation. I see 2 solutions:

use GitHub’s 2 actions + a third one to generate the changelog
merge all functionality into one action

The first one would be preferred for stability (it’s 66% maintained by GitHub) but the workflow would be stupidly long apparently: https://github.com/actions/upload-release-asset#example-workflow---upload-a-release-asset
The second one doesn’t feel very UNIX-y… but it’d be very convenient. It could still import those 2 actions and still offer all of its inputs/outputs (but perhaps it wouldn’t make it any easier)

The other action don't export their functions actually for us to compose, which leaves having to implement all of it anyway.

If we were to merge all of it into a single action then from https://github.com/actions/upload-release-asset#example-workflow---upload-a-release-asset,

env and GITHUB_TOKEN can be dropped, as we already have token input
upload_url can be dropped, making it internal
asset_name can be dropped, using the filename itself (unless we want it to be something like refined-github-v20.4.9.zip or something)
asset_content_type, I'm not sure about this, mime sniff?

Going with the first option makes it easier for composing other actions. And also we will not be using @actions/create-release here as @notlmn/release-with-changelog already creates one.

Resurfacing this one.
I pushed a demo commit (https://github.com/sindresorhus/refined-github/commit/cd7991b1334112d211425e9f7784dcbdcd0cf4c8) of the changes needed here. It's only missing:

that upload_url parameter, it should probably be outputted by https://github.com/fregante/release-with-changelog
ensuring the whole thing works, finishing up the missing details

Moved to https://github.com/fregante/browser-extension-template/issues/59


Create Alpha Streams Reality Models

Expected Behavior

Build realistic fee, slippage, and margin models for institutional clients to be used in AlphaStreams. Per an institutional client, these would act in the following ways:
Fee Model

Equities

Long positions on margin pays 1-month LIBOR rate + 40bps (basis points) on USD notional (approx 0.024 + 0.004 per annum)
Short positions on margin receive 1-month Libor - 40bps on USD notional (approx 0.024 - 0.004 per annum)
I.e., a balanced long/short position only pays 2x 40bps on USD notional

Forex

If trading directly with the prime broker, the cost is baked into the bid/ask spread
If paying the PB to place trades, the commission will be about 0.000002 * USD notional value

Futures/Options

$0.40 comission per contract + $0.10 per contract for clearing

Borrowing/Financing Model

Equities

Easy to borrow (highly liquid) stocks can be modeled at 0
Difficult to borrow stocks can pay anything >= 0% per annum (need to make a reasonable estimate/sliding scale based on volume)

Forex

A position 1000 long in EURUSD (with rate 1.2, e.g.) would get the PB's EUR credit rate on 1000 EUR and you pay the PB's debit rate on 1200 USD.
Both are based on an overnight rate + spread, which will need to be investigated for best model. Spread assumption can be ~40 bps.

Futures/Options

Need to borrow from PB a certain percentage of notional value to exchange as margin
This can be modeled at the cash debit rate (overnight rate + 40bps spread)

This will require getting PB FX data history, common margin requirements for options/futures, and common overnight rates charged by PBs.
Actual Behavior

Potential Solution

Reproducing the Problem

System Information

Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

Fee Model class PR made. Once completed, the borrowing power model will need to be completed.


Issue when signing out with no network connection

If wifi is disabled and a user signs out of macOS the machine appears to hang and does not return to the XCreds sign in window until network access is restored or the machine is restarted.

Found this is probably ok and maybe only related to testing in VM and self-signed IP.  Tested again by going to macOS settings in VM > Network > Ethernet > Make Inactive.  After doing this and signing out the XCreds cloud login window was shown as expected with a network status message and sign in could be completed by switching the sign in window and signing in locally.

I still see this problem even on a M2 MacBook Air.


Updates app insights example app dependency  from @fluid-internal/app-insights-logger to @fluidframework/app-insights-logger

Updates app insights example app dependency  from @fluid-internal/app-insights-logger to @fluidframework/app-insights-logger. This was missed and didn't get caught in the build checks when the packages scope changed in a previous pr: https://github.com/microsoft/FluidFramework/pull/18239/files

Not sure if this might indicate some pnpm corner case that should be investigated?

I also got the error when changing another unrelated dependency... but what I did was actually change it to a workspace package that doesn't exist (replaced a @fluidframework with a @fluid-experimental). pnpm i started complaining about the dep in the app-insights-logger example, but not about the incorrect one I introduced somewhere else. Then after fixing the one it complained about and trying pnpm i again, now it complained about the new incorrect one. Seems it doesn't do a thorough check of workspace dependencies every time (which I can see the motivation for, but arguably a bug), only when it knows for sure it needs to change the lockfile, but even in that case it doesn't check them all?

Seems it doesn't do a thorough check of workspace dependencies every time (which I can see the motivation for, but arguably a bug), only when it knows for sure it needs to change the lockfile, but even in that case it doesn't check them all?

This very much feels like a bug, though one I certainly would have written. :smile: My hypothesis is that it's a convergence of using the workspace protocol and renaming a package without changing its path.
If you look at the lockfile it's storing the relative path to the package only, which doesn't change. I'm guessing it doesn't read the version of packages every time, or otherwise update metadata from the fs without a fs change. The lockfile has an extensive cache of package metadata, so i guess basically we're talking about the cache invalidation logic for the lockfile.
But still - any package.json metadata change should trigger a failure in pnpm i --frozen-lockfile. But I confirmed that it doesn't with this change. So that seems flat out wrong. My first instinct is to update pnpm to the latest 7.x release and see if it still repros.
I wonder if it would still repro if instead of the workspace protocol, we set exact versions in the dependencies? Since we use the workspace protocol, pnpm doesn't necessarily need to read the versions of packages or load data from package.json. But regardless of all this I can't see this as anything but a bug.


Fix regular macOS build by passing -isysroot to compiler so correct system headers are found

Hi.
I tried building master branch of Godot, and failed due to a compilation issue.
Here is the invocation and error message:
$ scons platform=osx target=release_debug verbose=true

Initial build] clang -o platform/osx/os_osx.osx.opt.tools.64.o -c -g1 -O2 -DDEBUG_ENABLED -arch x86_64 -w -Werror=return-type -DZSTD_STATIC_LINKING_ONLY -DFT2_BUILD_LIBRARY -DZLIB_DEBUG -DFREETYPE_ENABLED -DFT_CONFIG_OPTION_USE_PNG -DSVG_ENABLED -DOSX_ENABLED -DUNIX_ENABLED -DGLES_ENABLED -DAPPLE_STYLE_KEYS -DCOREAUDIO_ENABLED -DCOREMIDI_ENABLED -mmacosx-version-min=10.9 -DGLAD_ENABLED -DGLES_OVER_GL -DPTRCALL_ENABLED -DTOOLS_ENABLED -DGDSCRIPT_ENABLED -DMINIZIP_ENABLED -DXML_ENABLED -Icore -Icore/math -Ieditor -Idrivers -I. -Iplatform/osx -Ithirdparty/zstd -Ithirdparty/zstd/common -Ithirdparty/zlib -Ithirdparty/glad -Ithirdparty/freetype -Ithirdparty/freetype/include -Ithirdparty/libpng -Ithirdparty/nanosvg platform/osx/os_osx.mm

platform/osx/os_osx.mm:1421:41: error: use of undeclared identifier 'NSAppKitVersionNumber10_12'; did you mean 'NSAppKitVersionNumber'?
                                if (floor(NSAppKitVersionNumber) >= NSAppKitVersionNumber10_12) {
                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                    NSAppKitVersionNumber
/System/Library/Frameworks/AppKit.framework/Headers/NSApplication.h:26:28: note: 'NSAppKitVersionNumber' declared here
APPKIT_EXTERN const double NSAppKitVersionNumber;

This is on macOS 10.12.6, XCode Version 9.2 (9C40b)
It seems that the headers found in Appkit.framework under /System/Library/Frameworks/ are not up-to-date with respect with what is present in the SDK that comes with Xcode.
My pull request fixes that by passing -isysroot to point to the Xcode SDK.
This allows me to build successfully on my machine.
Thought it might make sense to fix it upstream as well.

Nobody else seems to report such issues building on macOS, so it would be better to diagnose why it's not working on your system when it works for others. If we can avoid hardcoding such paths, that's better.

Well it's semi-hardcoding. The same is done in the iphone/detect.py file.

I'm using macOS 10.13.6 and can't check whats going on 10.12, but NSApplication.h on my system doesn't have NSAppKitVersionNumber10_13 constant defined, and 10.14 SDK doesn't have NSAppKitVersionNumber10_14, so it's probably true that none have constant for current version defined.
Xcode can be installed anywhere outside of /Applications/Xcode.app and SDK can be also located in /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/ if someone is using Command Line Tools for Xcode instead of full Xcode.
Setting -isysroot to specific SDK is ok, but probably we should use xcode-select -p command output to get active Xcode/Command Line Tools installation path instead of hardcoded path.

Looks like $ xcodebuild -version -sdk macosx Path returns the current highest installed sdk path
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk

Looks like $ xcodebuild -version -sdk macosx Path returns the current highest installed sdk path
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk
Same with xcrun --sdk macosx --show-sdk-path

Same can be used with --sdk iphoneos for iOS in iphone/detect.py

Another way to fix the issue would be to add
#ifndef NSAppKitVersionNumber10_12
// Happens when building against SDK from 10.12 or lower
#define NSAppKitVersionNumber10_12 <whatever it should be>
#endif

CC @BastiaanOlij @endragor

Besides checking NSAppKitVersionNumber constants there also another way to check macOS version in runtime, I didn't tested how it would behave on 10.12 and earlier, but it may be more compatible.
if (@available(macOS 10.12, *)) {
      // macOS 10.12 or later code path
} else {
      // code for earlier than 10.12
}

Updated PR to query macOS / iOS / Simulator SDK path via xcrun, and pass the result as -isysroot.
Doesn't affect the macOS cross-build config.

The original issue is fixed by #23822, so this should no longer be needed. Thanks for the proposal nevertheless!

The original issue is fixed by #23822, so this should no longer be needed. Thanks for the proposal nevertheless!

It's still a good idea to select correct SDK, even if it's building without error, default SDK may cause problems.

Build will produce tons of "ld: warning: text-based stub file X.tbd and library file X are out of sync. Falling back to library file for linking." warnings.
Binaries built on macOS 10.13 with Xcode 10 will not use correct OS theme on 10.14.

Ok, merging then :)


sensor: eeprom: Add TMP116 EEPROM access

Read and write accesses are supported by using
either custom or eeprom API
Signed-off-by: Guillaume Lager<EMAIL_ADDRESS>

Only read-only access is supported by using either custom or eeprom API

Thank you. How come only read-only access is implemented?

Mainly because it's the only thing I used and that I tested. It allows to read the IDs preprogrammed in the sensor eeprom.
If I'm able clear some time I will add the write part, but I hope this will not block the PR

@MaureenHelm Are you ok with the changes to the sensor driver?

@MaureenHelm Could you review again ?


Fixed size is recommended for efficiency but windows recommends Dynamically expanding

Type of issue
Other (describe below)
Feedback
Under heading "Create new VHD" and bullet point "Disk type" it states...

Disk type:

Fixed size - This virtual hard disk file is allocated to the maximum size when created (Recommended for efficiency)
Dynamically expanding - Grows to maximum size as data is written

However on windows when creating the dev drive it states "Dynamically expanding (recommended)". Which option is the recommended configuration for Dev drives?

Page URL
https://learn.microsoft.com/en-us/windows/dev-drive/
Content source URL
https://github.com/MicrosoftDocs/windows-dev-docs/blob/docs/hub/dev-drive/index.md
Author
@mattwojo
Document Id
bfda7965-bc34-ab88-fdc9-efef4a5d8a9e

Fixed in https://github.com/MicrosoftDocs/windows-dev-docs/commit/740dd8debc0ef816144590d20888fe55bb08df94


Add alias 'Addict' to import Dict

Currently, when importing Dict from addict like this:
from addict import Dict

..., where Dict will conflict with Dict from typing.
It would be handy if the library would offer an alternative import name so both Dict classes can get imported easily:
from addict import Addict
from typing import Dict

Coverage remained the same at 100.0% when pulling 4ca3d8f529986e4d5e390991d15bbbb5dc1f3c0c on hnicke:add-alias into 62aec341d12ebbe313a67ce63838202ba9d9e742 on mewwts:master.

Thanks for your contribution @hnicke. Having given this some thought, I think it's a good idea.


Add CLI option for custom entrypoint module

Sometimes we want to use a different module than Main. For instance, we
may want to use a MainSpec module to run specs against our code base
with something like elm-spec.
module MainSpec where

import IO.IO exposing (..)
import IO.Runner exposing (Request, Response, run)

import Spec.Runner.Console as Console
import Spec exposing (..)

import CSVSpec

allSpecs =
    describe "App"
      [ CSVSpec.spec
      ]

testRunner : IO ()
testRunner = Console.run allSpecs

port requests : Signal Request
port requests = run responses testRunner

port responses : Signal Response

Closing in favor of https://github.com/laszlopandy/elm-console/pull/2


New version: LazyArrays v0.16.14

Registering package: LazyArrays
Repository: https://github.com/JuliaArrays/LazyArrays.jl
Created by: @dlfivefifty
Version: v0.16.14
Commit: 2e11c82503ae905a86da757ee7acfb3552a0c3d4
Reviewed by: @dlfivefifty
Reference: https://github.com/JuliaArrays/LazyArrays.jl/commit/2e11c82503ae905a86da757ee7acfb3552a0c3d4#commitcomment-40449379

block

[noblock]


Support JWT authentication

Support JWT Authentication
BREAKING CHANGES

rename TimeTreeClient to OAuthClient
rename Authenticator to OAuthAuthenticator

:tada: This PR is included in version 2.0.0-alpha.2 :tada:
The release is available on:

GitHub release
npm package (@alpha dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


bemenu/wayland pagination not working correctly

Tested with pinephone pro.
Should be able to swipe below the menu to move to next page. Doesn't do that. (works with dmenu under X)
Swiping up for previous page works, and swiping left for cancel works. Only swiping down for next page is broken for me.
In some odd corner-cases sometimes I can make the 'next page' appear.
This is most likely an upstream issue and I'm not planning on spending the time to debug this currently. To keep things usable I'm setting environment.variables.SXMO_BMENU_PORTRAIT_LINES = "25"; in my configuration.nix to make the menu taller such that I don't need to scroll in most cases.

There's a patch for sway that should fix this https://github.com/swaywm/sway/pull/6455, alpine ships a sxmo-sway package built from https://git.sr.ht/~stacyharper/sway which includes that patch.
Another work around is to use the volume buttons to navigate the menu.

Looks like the sway patch has finally merged, so I expect to be able to close this next sway release.


layerrule animation speed

Description
the layerrule animation's speed or duration

And i think it should be able to do like popin 50%. like slide right 50% or slide 50%


Version control current branch name in integrated terminal tab description and title not working

Type: Bug
The terminal.integrated.tabs.description and terminal.integrated.tabs.title supports various tokes to format the tab description and title.
The activeRepositoryName and activeRepositoryBranchName works only when the terminal is moved to editor area and not not when placed in bottom panel.

VS Code version: Code 1.90.1 (611f9bfce64f25108829dd295f54a6894e87339d, 2024-06-11T21:01:24.262Z)
OS version: Windows_NT x64 10.0.22621
Modes:

The activeRepositoryName and activeRepositoryBranchName works only when the terminal is moved to editor area and not not when placed in bottom panel.

Just realized that this is not true, terminal.integrated.tabs.description and terminal.integrated.tabs.title are unrelated with window.title setting.
Probably this was never supported!


No error when a union type that does not include an error type is used as the contextually-expected type for an error constructor

Description:
In below mentioned case compilation finishes without failure even though its expected to fail because given and required return types are not similar
Steps to reproduce:
import ballerina/io;

function resolveTestSemtype(string|int t) returns TestType {
    if t is string {
        io:println("test");
    }
    else {
        return t;
    }
    return error("unreachable");
}

type TestType int|string;

Closed by https://github.com/ballerina-platform/ballerina-lang/pull/33376


Introduce extrinsic state version to RuntimeVersion object

This RFC proposes adding system_version and remove state_version from RuntimeVersion object. This makes it possible to use StateVersion::V1 for both Storage and Extrinsic root derivations

Would be really helpful if we can get some more feedback on this one from other team members :)

@bkchr @tomaka The RFC is updated as per our discussion above. Please let me know your feedback

The Motivation section is not super clear. Another motivation is https://github.com/polkadot-fellows/RFCs/issues/19.
But I would vote yes.

The Motivation section is not super clear.

This is the only use case we have right now. Is the wording confusing or does not meet standards?

Another motivation is https://github.com/polkadot-fellows/RFCs/issues/19.

I can tag this in the motivation section if it helps

I just mean that someone who isn't deeply familiar with the trie format and V0 and V1 will not understand the "Motivation" section. But that's not a big deal to me.

@tomaka what would be the next steps here ?
I can submit a change set to polkadot-sdk as well. Please let me know

Any blockers for moving forward with this?

Any blockers for moving forward with this?

"Just" needs some approvals 😄

Looks good to me.
One possibility could be to use 3 instead of 2, so that the field can be interpreted as a bitfield, but then we'll be stuck if for example there's a new trie version. Overall whether to use a bitfield or plain numerical values would require anticipating how we're going to use this field in the future, which isn't really possible, and I don't think it matters much.

If there's no other comment, I can submit your RFC for voting.

No other changes from my end.
Thank you!!

/rfc propose

Proposed: https://collectives.polkassembly.io/referenda/70

/rfc process 0x10ac786bc859fbaad56ca436bd822a01e0f120d37f85680621700323d35756d9

/rfc process 0x2cd018900d9c915ce8104cc6e37141b663cb46d13aadbff9dbfa038211228789

@tomaka Can you explain what is the process next? I would be happy to produce a PR for this RFC

@vedhavyas feel free to open a pr and link to the RFC in the pr description. Thank you!

@vedhavyas, do you have an update on the status of this RFC?
Is somebody working on its implementation?
Thanks.

Was implemented [here[(https://github.com/paritytech/polkadot-sdk/pull/4257).


[BUG] Schema inference gives a blank string value for json object in cosmos container

Describe the bug
The schemaInference reads the json object in a cosmos container as a blank string. This causes a data loss while using the connector. When a customSchema is passed to spark.read.schema(customSchema) with struct types, the data is been read as expected.
To Reproduce
Steps to reproduce the behavior:

Reading from a cosmos container having ~2k documents
schema {   "id":"test",   "child":{       "id":"testid",       "number": "testnumber"   },   "element2": Array[Objects],   "element3": Array[Objects] }
Read configuration for inferSchema

"spark.cosmos.read.inferSchema.enabled" -> "TRUE", "spark.cosmos.read.inferSchema.query" -> "select * from c", "spark.cosmos.read.inferSchema.samplingSize" -> "2000", "spark.cosmos.read.inferSchema.includeSystemProperties" -> "FALSE", "spark.cosmos.read.inferSchema.includeTimestamp" ->"FALSE", "spark.cosmos.read.schemaConversionMode" -> "Relaxed", "spark.cosmos.read.partitioning.strategy" -> "Default"

The child property is expected as a valid json in dataframe, however it shows as a blank string

Code Snippet
spark.read.format("com.azure.cosmos.spark.CosmosItemsDataSource").options(config).load()
Expected behavior
When reading using the schemaInference, the connector should output the json object as a valid struct column in the dataframe instead of giving blank string values.
Setup (please complete the following information):

Running azure-cosmos-spark_3-1_2-12 (version 4.0.0) on databricks

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Hi jenil,
I looked at this work item, but unfortunately, I did not quite get what is happening. Schema inference in Spark will try to map the json documents into a relational schema (which can include Structs/Arrays - but Structs have to be well defined - there is no notion of a generic Json object like JsonNode in Java etc.)
The way it works in the Cosmos DB connector is that when you have an array[object] we look at the objects and build a schema with a superset of properties - so, if array[0] has an object { "property1", "Test" } and array[1] { "property2": "Test" } the resulting schema would be an array of struct with property1:String and property2: String.
That said, schema inference also only looks at a certain sample set of documents (1000 random documents by default, can be changed) - so only properties that exist in any of the 1000 documents would be reflected in the inferred schema.
I have a few questions regarding the work item that you created:

What schema is inferred (if df is the Dataframe you read like above - what is the df.printSchema output)?
When you say the child property shows as blank string - is this happening for all documents or only the row where the document doesn't even contain a child-property?
Are you able to share a few (can be anonymized so that they don't have privacy related info in them) documents - ideally enough that I can use them to reproduce what you are seeing after ingesting them into one of my containers? If you don't want to share them at github feel free to send them to me via mail - fabianm[at]microsoft.com
Are you aware that you can also provide your own manually created schema instead of using schema inference?
Are the documents of very different structure - so that the fact that only 1000 random documents are used for schema inference would be relevant in your case? If so, there is a way to specify a query that is used to pick the documents for schema inference - for example to force only reading documents with certain filters or only reading the most recently modified documents etc.
Which exact version of the Spark connector are you using? The latest version is 4.10.1 (can be retrieved from maven via https://repo1.maven.org/maven2/com/azure/cosmos/spark/azure-cosmos-spark_3-1_2-12/4.10.1/azure-cosmos-spark_3-1_2-12-4.10.1.jar) - assuming you are using an older version - are you able to check whether the issue still reproduces at the latest version?

@FabianMeiswinkel  Thanks for your quick response. The issue is seen in version 4.0.0  and cannot be reproduced in latest version 4.10.1
1)What schema is inferred (if df is the Dataframe you read like above - what is the df.printSchema output)?
Output
 |-- id: string (nullable = false)
 |-- child: string (nullable = false)
 |-- result: boolean (nullable = false)
 |-- element2: array (nullable = false)
 |    |-- element: struct (containsNull = true)
 |    |    |-- prop1: struct (nullable = false)
 |    |    |-- prop2: boolean (nullable = false)
 |-- element3: array (nullable = false)
 |    |-- element: struct (containsNull = true)
 |    |    |-- prop1: struct (nullable = false)
 |    |    |-- prop2: boolean (nullable = false)

Expected
 |-- id: string (nullable = false)
 |-- child: struct (containsNull = true)
 |    |-- element: struct (containsNull = true)
 |    |    |-- id: string (nullable = false)
 |    |    |-- number: string (nullable = false)
 |-- result: boolean (nullable = false)
 |-- element2: array (nullable = false)
 |    |-- element: struct (containsNull = true)
 |    |    |-- prop1: struct (nullable = false)
 |    |    |-- prop2: boolean (nullable = false)
 |-- element3: array (nullable = false)
 |    |-- element: struct (containsNull = true)
 |    |    |-- prop1: struct (nullable = false)
 |    |    |-- prop2: boolean (nullable = false)

When you say the child property shows as blank string - is this happening for all documents or only the row where the document doesn't even contain a child-property?

All elements.

Are you able to share a few (can be anonymized so that they don't have privacy related info in them) documents - ideally enough that I can use them to reproduce what you are seeing after ingesting them into one of my containers? If you don't want to share them at github feel free to send them to me via mail - fabianm[at]microsoft.com

Yes, the issue is reproduced with version 4.0.0, However this is not happening with latest version 4.10.1. I can share via mail if you still need to have a look.

Are you aware that you can also provide your own manually created schema instead of using schema inference?

Yes, The issue is not reproducible if we pass the custom schema (even with version 4.0.0)

Are the documents of very different structure - so that the fact that only 1000 random documents are used for schema inference would be relevant in your case? If so, there is a way to specify a query that is used to pick the documents for schema inference - for example to force only reading documents with certain filters or only reading the most recently modified documents etc.

No all the documents has the same schema.

Which exact version of the Spark connector are you using? The latest version is 4.10.1 (can be retrieved from maven via https://repo1.maven.org/maven2/com/azure/cosmos/spark/azure-cosmos-spark_3-1_2-12/4.10.1/azure-cosmos-spark_3-1_2-12-4.10.1.jar) - assuming you are using an older version - are you able to check whether the issue still reproduces at the latest version?

We were using version 4.0.0. Tested with latest version 4.10.1 and unable to reproduce the issue. It works as expected.

Thanks for the confirmation - yes, there have been several critical improvements made - also in this area - since 4.0.0. So, I am going to close this ticket. For reference - the change log for the different versions is here: https://aka.ms/azure-cosmos-spark-3-1-changelog
In general, my recommendation would be to snap to the latest version regularly - like at least every few months. And the change log can be used to determine how significant changes are for your workload.


A bug, Code for trash talk on kill, death, constant spam and some suggestions

Bugs :

Chickens get a white cham when using glow (style 0)
Exclude sleeves in remove hand
Backtrack is very random
The blinking cham should have a color as all the other cheats have
Manual map injection didn't work for some reason in the latest update.

And some suggestions :
(these are the ones i think a regular cheat should have)
ESP -

HP bar
Weapon Esp
Ammo
Flags like (scoped, flashed, money, armor, bomb)
Grenade Predict
Implement CGrenadeApi
Source : https://github.com/Blick1337/GRENADE-API
Implementation Example : https://www.unknowncheats.me/forum/counterstrike-global-offensive/258976-grenade-helper.html

RCS -

Standalone rcs

Chams -

A better body for the cham (it looks like the chams are flat from a distance) or maybe shadows

Movement -

Edge Jump
Directional Strafer

(these are like the cosmetic stuff)
Glow -

Weapon and Hand Glow

Code for trash talk:
Misc.h
Kill Say : https://pastebin.com/jqasW8YS
Death Say : https://pastebin.com/A4Xyh6w4
Chat Spam : https://pastebin.com/Q3G1CceD
Config.h

    bool killsay{ false };
    bool deathSay{ false };
    bool chatspam{ false};

GUI.cpp

ImGui::Checkbox("Trash talk on kill", &config.misc.killsay);
ImGui::Checkbox("Trash talk on death", &config.misc.deathSay);
ImGui::Checkbox("Constant Spam", &config.misc.chatspam);
if (config.misc.chatspam){
config.misc.killsay = false;
config.misc.deathSay = false;// this is because you might not want to flood
}
Chat spam could have been done better if there was a function for getting tick count.

The edits are for styling because add code looked bad :/

Wow nice work, thanks

And yes, manual map is bugged, i tried to inject and game is crashing

I think we should add C4 timer and location ( A or B ). It quite helpful

Yeah i forgot that.

And XQZ Chams

Isnt xqz occluded chams?

Normal chams: https://gyazo.com/8c8e67d60e3b2241da0c24c80bb5f885
XQZ Chams: https://i.imgur.com/RHM7dcG.png

@effex1337 Thanks for for chat spamming code, highly appreciated!
 I have tried most things to resolve it but I simply can't.
With chat spam commented out:
https://gyazo.com/ad651014cc2c1727396f9c6273122609
With chat spam implemented:
https://gyazo.com/25e4077550aaf416e2e30bc03550f697
I am probably just blind. I haven't slept for 2 days..

@Shaxzy
1)please, dont make private cheat from public sources.
2) learncpp.com - you need this
3) that spam method dont stabile, spam rate = fps.
static float lastSpamTime = 0.0f;
constexpr void Spam() noexcept
{
    if(lastSpamTime < memory.currenttime + 0.25f){
        interfaces.engine->clientCmdUnrestricted(@"say 'It's private cheat(free pasta)'");
        lastSpamTime = memory.currenttime;
    }
}

@Shaxzy @NexSqaud
Well I said that it could have been better if i had get tick count but i completely forgot that we had memory.currenttime. Thanks for that :)
But i don't really think it would cause too much fps drops.

@effex1337 Yes, your method will not cause a large drop in FPS, just the spam rate will depend on FPS. And you calling this from FireEventClientSide? Seriuos? In this case, the spam rate depends on the events rate. More events - more spam. Few event - few spam.

OK i actually face palmed myself when i re read the code i had just written killsay copied to death say then to constant spam after removing the death event. Thanks for reminding :)

Chicken glow works just fine.
"Fixed", corrected
I've just updated backtrack so give it a try.
Added.
It's problem with your injector, I can't really help you.

Chicken glow works just fine.
"Fixed", corrected
I've just updated backtrack so give it a try once more.
Added.
It's problem with your injector, I can't really help you.

amazing work also ignore people who treat you project like your some pay2cheat provider

@NexSqaud Bruh it's not even a private cheat just because it says so. 0 IQ btw
I just changed a bunch of stuff and made it undetected for some friends. No money involved or anything like that, just to help them cheat without getting a ban.

@danielkrupinski manual map doesn't work with bleak
https://github.com/Akaion/Bleak
Works with pretty much any other dll fine

@woah1337 Manual map works for me. I using Inflame


expected_cumulative_transactions hardcodes datetime_col as 'date'

I think there's a bug in the function expected_cumulative_transactions that prevents causes an error if the datetime_col in the transactions dataframe is not 'date'. It also comes up if you try to run the plot_cumulative_transactions function. You can generate the error by running the following:
from lifetimes import ModifiedBetaGeoFitter
from lifetimes.datasets import load_transaction_data
import lifetimes.plotting as ltplt
from lifetimes.utils import summary_data_from_transaction_data, expected_cumulative_transactions

transactions = load_transaction_data().rename(columns={'date':'Date'})
summary = summary_data_from_transaction_data(transactions,'id','Date')
mbg = ModifiedBetaGeoFitter()
mbg.fit(summary['frequency'],summary['recency'],summary['T'])
expected_cumulative_transactions(mbg, transactions, 'Date', 'id', 100)

This returns the error "Key Error: 'date'", which is triggered by line 487 in utils.py:
first_trans_size = first_transactions.groupby('date').size()

It looks to me as though 'date' is hardcoded on lines 487 and 499. I think in both cases it should use datetime_col instead, although I am not certain about line 499.
The function works fine if you run:
expected_cumulative_transactions(mbg,
                                 transactions.rename(columns={'Date':'date'}),
                                 'date', 'id', 100)

this indeed looks like a bug, ran into the same issues


[BUG]  Primate GuestNetwork Not able to Add IP Range

Describe the bug
in primate interface , zone, physical internface, guest network, not able to add ip range, a part from initially created.  Also not able to see the start and end ip that initially created.
To Reproduce
Steps to reproduce the behavior:

Log in as a User or an Admin
Go to 'Infrastructure'
Click on '.Zone, and Physical Interface, Select GuestNetwork'
Not able to see the IPRange that created , or  Not able to add New Range (start and end IP)

Expected behavior
Able to see the IP range linked to GuestNetwork, and Able to add new range.
In old interface , it able to see .
Screenshots
Desktop (please complete the following information):

OS: CENTOS, 7, Primate
Browser Chrome

Additional context

@utchoang can you check this?


Move qier222.yesplaymusic 0.2.4 to qier222.YesPlayMusic 0.2.4

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/pull/156289#issuecomment-2146097791

[Policy] Reset Labels


RFC: Mocks For Guardians?

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Draft RFC - request for comment please ;)
For your review - does this make sense?
Problem: Some things, like guardians, are very hard to test.
Potential solution: Returning mock objects from repositories to test different scenarios.
In this case, I used this to test the countdown timer widget. The mocks could be adjusted as needed depending on what scenario one wants to play out.
✅ Checklist

[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
🙈 Screenshots
👯♀ Paired with

I like it. Good job

Cool - I was not sure how many mock cases we'd have so was prepared to dump them all into MockRepository, regardless of what it's mocking. But we can make different files for each mock repo too, no harm in that.

closing this for now


Root directory error when project is selected

The project root directory should be selected when a project is first selected.  This is a problem when the project has no subfolders.

File "/Users/dave/PycharmProjects/MetaForge/MetaForge/mainwindowimpl.py", line 243, in getLocation
self.folderuuid = ht_requests.get_ht_id_path_from_ht_path(self.hyperthoughtui.authcontrol,
File "/Users/dave/PycharmProjects/MetaForge/MetaForge/ht_requests/ht_requests/ht_requests.py", line 163, in get_ht_id_path_from_ht_path
raise FileNotFoundError(f'Could not find file/folder located at {ht_path} in HyperThought: {comp} does not exist!')

If one types a '/' in the lower file path text entry -- the file will upload to "My Files" space, not project space.

Interesting. was not aware of the "myfiles" space.

My Files is what HT labels the user files space.


02a_why_sqrt5 may have wrong reference in  last cell and 2nd cell

Forgive my ignorance but the 02a notebook may have the wrong references if the 2nd and last cell

I think that's fixed now.


Algos should be in an object

Currently, an algo is just 3 functions in a file.
This should be encapsulated into an object (which would remove the need for the init function).
The reason is that any algo that requires some data has to rely on global data so that it's shared between the functions.
Global variables are bad for multiple reasons but mainly, in my case, it's easy to forget to add the global variable declaration to a function modifying it, with weird failure modes. This could also cause problems if you run multiple instance of a same algo (could make sense with some future evolution). Finally this would make it easier to make algos with parameters.

You're wright.

I make change for this issue in algo_object branch.
@ColinPitrat you need to adapt your algo (one_step_ahead) if you want

You'll need to update the readme :)

There is a bug in this algo. It's fixed now. Always in algo_object branch

Fixed and merged


Make a site for the CLI to learn more about how to use it and practice with it

Learning site on how to use the CLI itself that's a more traditional usage of web-containers static published to like create.learn.hax.cloud or something

Or directly integrated into the doc site..


Add better tests for refresh token endpoints

in user_api_test.go, there's one test for all the refresh token endpoints. There should be separate ones for List and Revoke. In addition these only test one instance of the happy path, just with different clients. We need to have tests for cases where the client doesn't exist, where the user doesnt; have a refresh token for the given client, etc, or where the user is trying access someone eles's tokens.

We now have integration testing for this.


Should fix GBL not being detected

This is probably not the best way to do it, but it should work.
I can confirm that this is working for the GBL version, but I can't test it for the CN version because I can't download it.

can you try the code I patched

It works


No data available if multiple homes exist

I've added another home last week because I will move in 2 months, but now no data is available anymore for the current home, because TeslaMateAgile always takes the first home which the API gives, but I need so select the second home now.
Is there a easy way to do that?

Hi!
I believe the setting you're looking for is TeslaMate__GeofenceId, if you have set up another home or location there should be a new ID for that one. Check the readme for more info on how to find this number.
Hope that helps! 🙂

Also keep in mind TeslaMateAgile can only track one location at a time so you'll need to run multiple instances of it with different settings if you want to run it with multiple locations

Interesting! We don't appear to have support for that, but it should be easy to add.
I'm currently on holiday this week so I'll see if I can do that next week for you 🙂

Thank you, this would be amazing!
Reach out to me if I can help you somehow😊

Might need some help to test it so I certainly will!

Hi again! This functionality is now available in the latest version v1.14.0 🙂
Check the readme for information about Tibber__HomeId and let me know how it goes!

It works great, thank you for this update! 😊

Awesome! No problem 🙂


[FLINK-18863][python] Support read_text_file() and print() interface …

What is the purpose of the change
Add read_text_file() and print() interface for Python DataStream API. It would be of benefit for ease of use and debug purpose. Further more, Users can play with Flink out of box through these simple source/sink API.
Brief change log

Add print() for Python DataStream API.
Add read_text_file for StreamExecutionEnvironment to get a DataStream.

Verifying this change
This change has test cases covered by test_print() in test_data_stream.py and test_read_text_file() in test_stream_execution_environment.py
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

@hequn8128 Thank you for your comments, I have updated the PR, please have a look at it.


Make ComboBoxDataProvider usable

I just stumbled over the data provider implementation in Hilla and think there is some misconception.
For example:
async dataProvider(params: ComboBoxDataProviderParams, callback: ComboBoxDataProviderCallback<string>) {
    const page = await GroceryEndpoint.getCategories(params.filter, params.page, params.pageSize);

    callback(page.content, page.size);
}

It seems that the total number of elements has to be passed to the callback always.
On the server side this means two calls. Count and Fetch!
This may lead to performance issues if the filter condition is complex.
My requests are:

split fetch and count callback (as in Vaadin)
allow fetch without count (as in Vaadin)

I'm talking about this:
https://hilla.dev/docs/advanced/components-definitions

Let me transfer this to the web components repository where the GridDataProviderCallback is defined.


[iOS] unable to spawn process (Argument list too long)

Ran custom shell script'[CP] Check Pods Manifest.lock
PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/elias/Library/Developer/Xcode/DerivedData/Runner-fiuohnrdzlkuxddgjocwyhssndsw/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Runner.build/Release-iphoneos/Runner.build/Script-4AE03761ECB993EA059947D1.sh (in target 'Runner' from project 'Runner')
    cd /Users/elias/Documents/GitHub/isontic-Education/Education-Mobile/ios
    /bin/sh -c /Users/elias/Library/Developer/Xcode/DerivedData/Runner-fiuohnrdzlkuxddgjocwyhssndsw/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Runner.build/Release-iphoneos/Runner.build/Script-4AE03761ECB993EA059947D1.sh

error: unable to spawn process (Argument list too long) (in target 'Runner' from project 'Runner')

flutter doctor -v
[✓] Flutter (Channel dev, v1.13.7, on Mac OS X 10.15.2 19C57, locale en-US)
    • Flutter version 1.13.7 at /Users/elias/flutter
    • Framework revision a3bbdfb23a (5 days ago), 2020-01-03 16:19:11 -0500
    • Engine revision eb139936eb
    • Dart version 2.8.0 (build 2.8.0-dev.0.0 2f57602411)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/elias/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.7.5

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[✓] Connected device (3 available)
    • macOS      • macOS      • darwin-x64     • Mac OS X 10.15.2 19C57
    • Chrome     • chrome     • web-javascript • Google Chrome 79.0.3945.88
    • Web Server • web-server • web-javascript • Flutter Tools

! Doctor found issues in 1 category.
elias@isontic-MBP-01 Education-Mobile %

Hi, facing the same problem~ Any solutions?

@AndroidNils Hi, try to delete ios/.symlinks

I'm getting the same issue. Can we reopen this?

Seeing this too, any clear solution here?  deleting ios/.symlinks didn't work for me unfortunately

Same problem here!

Mesmo problema! Qual é a solução?

Same problem! What is the solution?

@EliasDeuss how did you solve this issue? I'm encountering it too.

Not sure who this will help, but going to chime in with what fixed it for us.
Following this issue: https://stackoverflow.com/questions/53226087/error-unable-to-spawn-process-argument-list-too-long-in-xcode-build and the answer from user blaszku
For flavors, we had something similar to this (from the issue)
#include "Pods/Target Support Files/Pods-MyProject/Pods-MyProject.debug (development).xcconfig"
#include "Pods/Target Support Files/Pods-MyProjectTests/Pods-MyProjectTests.debug (development).xcconfig"

#include "Pods/Target Support Files/Pods-MyProject/Pods-MyProject.release (development).xcconfig"
#include "Pods/Target Support Files/Pods-MyProjectTests/Pods-MyProjectTests.release (development).xcconfig"

I changed this to only be
Debug.xcconfig:
#include "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
#include "Generated.xcconfig"

and
Release.xcconfig
#include "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
#include "Generated.xcconfig"

And now we can archive.  I believe the issue was that other way was including the release and debug xcconfigs which was causing the issue.  Can't really explain why that is problematic though.

It works! I'm not sure why but my old setup works before. Thank you for sharing your solution!

Not sure who this will help, but going to chime in with what fixed it for us.
Following this issue: https://stackoverflow.com/questions/53226087/error-unable-to-spawn-process-argument-list-too-long-in-xcode-build and the answer from user blaszku
For flavors, we had something similar to this (from the issue)
#include "Pods/Target Support Files/Pods-MyProject/Pods-MyProject.debug (development).xcconfig"
#include "Pods/Target Support Files/Pods-MyProjectTests/Pods-MyProjectTests.debug (development).xcconfig"

#include "Pods/Target Support Files/Pods-MyProject/Pods-MyProject.release (development).xcconfig"
#include "Pods/Target Support Files/Pods-MyProjectTests/Pods-MyProjectTests.release (development).xcconfig"

I changed this to only be
Debug.xcconfig:
#include "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
#include "Generated.xcconfig"

and
Release.xcconfig
#include "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
#include "Generated.xcconfig"

and assigned these configs to their appropriate flavor/build config combos
And now we can archive. I believe the issue was that other way was including the release and debug xcconfigs which was causing the issue. Can't really explain why that is problematic though.

Thanks!!! It works!


"Available methods" section lists the constructor method

I notice our method listings show the constructor method. How can we leave that out?
Example:
http://stephenplusplus.github.io/gcloud-node/#/docs/master/compute

I think we're going to need to add an option to the manifest.json that tells the docs app to ignore constructors. Both PHP and Ruby are going to want the constructor to display in the methods list.

How about we just leave this in.


Add basic support for viewing shared HTTP cookie storage

Hi,
I've added a very small amount of code that allows for a very basic way of browsing shared cookie storage - something I found useful.
Rich

Awesome! Can you check on the example (UICatalog) build and fill out the the ICLA if you haven't already?

Hi - apologies, I'd missed updating the UICatalog project. I have now done this and have also filled in the ICLA.

Great. Thanks for the contribution!


WIP: Implemented Skia DPI scaling.

Has a workaround for bug in DrawingContext.

https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.SceneGraph/Media/DrawingContext.cs
This class is specifically designed to allow arbitrary transformations to be applied without touching underlying implementation. Just use PushPostTransform or PushPreTransform before returning the context instead of applying hacks like you do in this PR

@kekekeks
" Just use PushPostTransform or PushPreTransform before returning the context instead of applying hacks like you do in this PR"
this didn't work.
because:
https://github.com/AvaloniaUI/Avalonia/blob/85f07274d434b11d9aa722a491c2286fcf0791d7/src/Avalonia.SceneGraph/Rendering/RendererMixin.cs#L128
causes the scaled matrix to end up in RenderTransforms and it affects hittesting and adorner layers...
set here.... (and probably other places)
https://github.com/AvaloniaUI/Avalonia/blob/85f07274d434b11d9aa722a491c2286fcf0791d7/src/Avalonia.Controls/Primitives/AdornerLayer.cs#L62
any suggestions how I can resolve this?
I guess we really want to completely separate out DPI scaling

@danwalmsley It can't affect render transforms in controls from there.


search: Add is:followed filter.

Create the is:followed search operator.
Fetch all messages that are from followed topics
using exists.
Update API documentation and changelog.
Co-authored-by: Nimish<EMAIL_ADDRESS>Fixes #27309.
Screenshots.
Search suggestions

Help menu.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Thanks! To prepare this PR for review, please include screenshots of the search (with typeahead) and help center changes.

Thanks! To prepare this PR for review, please include screenshots of the search (with typeahead) and help center / help menu changes.

Done

In the typeahead, let's make it "Followed topics", not "Topics followed".

https://zulip.com/help/search-for-messages#search-by-message-status needs to be updated as well.

In the typeahead, let's make it "Followed topics", not "Topics followed".

Done

I'm not sure need to explicitly document -is:followed in the help center (we usually don't, except for unresolved topics, which are potentially of more interest than resolved topics). But other reviewers can comment on this as well.

@laurynmm Would it make sense for you to review this one? I haven't tested.

I have addressed the comments and made the required changes.
Opened a CZO topic to discuss the question about UserMessage rows.

Also, it's good to post screenshots of any documentation changes/updates in your pull request comments. See tips and best practices for pull requests.

Ok, I have addressed the comments and added the screenshots to the description.

Resolved conflicts

@kennethnrk - Ping me for a review when you've got the merge conflicts resolved.
And I think we still need to get clarity in the CZO discussion you started about a streams: public and is:followed search. Because currently, this implementation only returns messages in followed topics with UserMessage rows, correct?

I've addressed the comments, I have opened #30125 to fix the issue with channel:public is:resolved.

I did a pretty complete review on this one from reading it, but haven't done any manual testing. Probably Alya can do a round of that once you've addressed the potential bugs, since the most likely things for us to find will be strings we want to change.

While using the API for testing, I found that the followed enum was missing for the user_topics endpoint in the open api yaml file. So I added that as a pre-commit.

Ask for a review from Alya once the remaining details discussed here are resolved.

Cool! Since we've been adding descriptions to the top nav bar, let's do that here as well:

Messages in topics you follow [?]

The [?] link should go to /help/follow-a-topic.

Looks good to me otherwise! Please mark the PR for integration review once that's been addressed.

Thanks @alya. I've made the header changes and added the screenshot to the description.
@zulipbot add "integration review"

@zulipbot remove "maintainer review"

Hm, I don't see the relevant screenshot?

I added the screenshot that @alya had requested as "Top of view" above, which looks fine. Also made the change in https://github.com/zulip/zulip/pull/29667#discussion_r1643580898 and did some fixups to the documentation; the first hunk just simplifying the text and uses the consistent "messages in topics" and present tense to be precise -- it's whether you follow the topic right now, not anything related to when the message was sent. Diff below.
With those changes, this looks good to me, marked to merge once CI passes.

diff --git a/api_docs/changelog.md b/api_docs/changelog.md
index 58953bb15d..3556be3e84 100644
--- a/api_docs/changelog.md
+++ b/api_docs/changelog.md
@@ -26,9 +26,9 @@ format used by the Zulip server that they are interacting with.
   [`GET /messages/matches_narrow`](/api/check-messages-match-narrow),
   [`POST /messages/flags/narrow`](/api/update-message-flags-for-narrow),
   [`POST /register`](/api/register-queue):
-  Added support for a [search/narrow filter](/api/construct-narrow)
-  related to followed topics: `is:followed`. This operator narrows to
-  messages from topics that the user has [followed](/help/follow-a-topic).
+  Added a new [search/narrow filter](/api/construct-narrow),
+  `is:followed`, matching messages in topics that the current user is
+  [following](/help/follow-a-topic).

 **Feature level 264**

diff --git a/api_docs/construct-narrow.md b/api_docs/construct-narrow.md
index e8eaf87390..0f69e7812f 100644
--- a/api_docs/construct-narrow.md
+++ b/api_docs/construct-narrow.md
@@ -51,7 +51,7 @@ important optimization when fetching messages in certain cases (e.g.
 when [adding the `read` flag to a user's personal
 messages](/api/update-message-flags-for-narrow)).

-**Changes**: In Zulip 9.0 (feature level 265),, support was added for a
+**Changes**: In Zulip 9.0 (feature level 265), support was added for a
 new `is:followed` filter, matching messages in topics that the current
 user is [following](/help/follow-a-topic).


Rolling update instances in ASG

related #9
Rolling update instances in ASG

By default, all instances in an ASG will be rolling updated. Also added explicit 180 seconds sleep before checking ASG for a healthy count to avoid API throttling from AWS
Terminate percentage value can be changed between 1 to 100 ( This value is hardcoded to 1 today meaning it will only do rolling update. In future, this can be changed as ASG Tag to customized terminate_percentage per ASG)

Testing

Added unit test for calculating semaphore value, Unit testing is completed.
Manual testing is done

ASG with 3 instances rotated one instance at a time ( when a k8s-minion-manager tag is set to use-spot) and all instances switched to spot.
Switch back to use on-demand has exact same behavior (rotated one instance at a time).
Tested using a sample Nginx deployment with 3 replicas, There was no downtime for the app during the rolling update.

Looks great! Thanks for doing this.
Can you also add details of testing done (other than unit tests)?

I have added Manual testing.

Awesome! Thanks for your contributions @vgunapati !


[BUG] Serialization error during peer-forwarding

Describe the bug
Peer forwarding is unable to serialize events.
2024-01-17T23:51:34.293 [test-pipeline-processor-worker-1-thread-1] WARN  org.opensearch.dataprepper.peerforwarder.RemotePeerForwarder - Unable to submit request for forwarding, processing locally.
java.lang.RuntimeException: java.io.NotSerializableException: java.lang.ref.WeakReference
  at org.opensearch.dataprepper.peerforwarder.client.PeerForwarderClient.getSerializedJsonBytes(PeerForwarderClient.java:87) ~[data-prepper-core-2.6.1.jar:?]
  at org.opensearch.dataprepper.peerforwarder.client.PeerForwarderClient.serializeRecordsAndSendHttpRequest(PeerForwarderClient.java:71) ~[data-prepper-core-2.6.1.jar:?]
  at org.opensearch.dataprepper.peerforwarder.RemotePeerForwarder.forwardRecordsForIp(RemotePeerForwarder.java:267) ~[data-prepper-core-2.6.1.jar:?]
Caused by: java.io.NotSerializableException: java.lang.ref.WeakReference
  at java.base/java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1175) ~[?:?]
  at java.base/java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1543) ~[?:?]
  at java.base/java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1500) ~[?:?]
  at java.base/java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1423) ~[?:?]
  at java.base/java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1169) ~[?:?]
  at java.base/java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1543) ~[?:?]
  at java.base/java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1500) ~[?:?]
  ... 14 more

To Reproduce

Configure Data Prepper to use peer-forwarding
Create a pipeline with an aggregate processor.
Run multiple Data Prepper instances
Inject data that will need to route across peers

Expected behavior
One Data Prepper node should be able to serialize and send the data to the other Data Prepper node.
Environment (please complete the following information):

Data Prepper: 2.6.1

I believe that the issue is we are trying to serialize the EventHandle:
https://github.com/opensearch-project/data-prepper/blob/6e921ad5bb1d709703651d9574cf1adc6f5c7555/data-prepper-api/src/main/java/org/opensearch/dataprepper/model/event/JacksonEvent.java#L71
It clearly has a WeakReference which we see in the logs above.
https://github.com/opensearch-project/data-prepper/blob/d3acfa72009a78202b44445b1f73792813dc7635/data-prepper-api/src/main/java/org/opensearch/dataprepper/model/event/DefaultEventHandle.java#L20
We should skip the eventHandle during serialization.


Adding counter for dropped dynamo requests

addresses #846
The counter should be generic enough to be used in any other exceptional case where we have to drop the entire request, instead of retrying it.

LGTM

Whoops, wrong button

Can you explain how this helps?  It seems to have the same labels as dynamoFailures, and it is only used in the case that the error is ValidationException so you can query for that.