Error handler in sub app

Using the code below, you'd expect Error in sub app to be logged, but only the parent app handler gets called.
var express = require('express');
var app = express();

app.use('/', function (req, res) {
	throw new Error('something');
});

var subApp = express();
subApp.use(function (err, req, res, next) {
	console.log('Error in sub app');
	next(err);
});
app.use(subApp);

app.use(function (err, req, res, next) {
	console.log('Error in parent app');
	res.status(500).send('Error: ' + err.message);
});

app.listen(4000);

Other handlers work just fine.

Hi @piuccio, the behavior you are seeing, where the error handler in your sub-app is not invoked for errors in the parent app, is exactly how Express is designed to behave. If you can think of improvements on our documentation to help clarify this, please feel free to make issues or even pull requests at https://github.com/expressjs/expressjs.com to improve the documentation :) !

I don't fully see why express should work by design as you described.
If you add an handler with app.use and don't specify a root path, it'll get all requests. What makes error handlers special?

Error handlers are special :) They only execute certain handlers and they are designed to act similar to DOM events, but bubbling up, not down. Sub apps are designed to be isolated, and should not be getting errors from the parent app. A classic example is implementing a JSON API as a sub app. You may have an error handler at the end of your JSON API app that responds with a JSON error body, but if an error happens in the main app, you would not want to respond with an API error, but maybe with an HTML error, etc.
Maybe if there is a discussion here with the intention to change the way in which Express has done error propagation for years and years, can you provide the following information to start a conversation:

What do you want the behavior to be?
How does this specifically compare to what it does now in all the cases?
What are the real-world use-cases that this solves over what is implemented currently?
Why does the existing behavior not work for your use-cases?

Fair enough, my only point is that maybe error handler shouldn't be special, but follow the same logic as any other middleware, but for errors instead of requests.

Sure, but without you actually answering any of those questions, we can't have a meaningful discussion on the topic. As far as I know, you may really just be confused about some use case, and once you lay out the real-world use case you are trying to solve by propagating errors down into sub apps, I can't even say if there is a simple mistake you are making.

I'll tell you how I encountered this problem. When your application grows in complexity, it's probably a good idea to split functionalities in different modules.
Take this example
import auth from './feat/authentication';
import errors from './feat/errors';
import logging from './feat/logging';
import info from './feat/info';
import security from './feat/security';
import statics from './feat/statics';

const app = express();

app.use(logging);
app.use('/status', info);
app.use(security);
app.use(helmet());
app.use(statics);
// After auth, all endpoints are authenticated
app.use(auth);
app.use('/api', api);

Those modules might contain multiple middelwares, they're all implemented along the lines of
import express from 'express';
const app = express();

app.use((req, res, next) => {});
app.use((req, res, next) => {});

export default app;

You can replace express with connect, it makes no difference.
This works perfectly for middlewares, but the same approach cannot be used for error handling.
I generally have these error handlers

authentication -> redirect to login page
log errors to file
send 5xx errors to tracking application
show error page to users

In my ideal world I can group all these error handlers in their own sub app, export it and use it. Just like in the example in my first post.
If I want to keep the logic separated I can
1: export an array, which however requires a path
// File : error-handlers.js
module.exports = [function (err, req, res, next) {
	console.log('Error handler');
	next(err);
}];

// File: index.js
var express = require('express');
var app = express();
var errors = require('./error-handlers');

app.use('/', errors);

2: Pass app to error handlers module
// File : error-handlers.js
module.exports = function (app) {
	app.use(function (err, req, res, next) {
		console.log('Error handler');
		next(err);
	});
};

// File: index.js
var express = require('express');
var app = express();
var errors = require('./error-handlers');

errors(app);

Gotcha. So for grouping:

I would not recommend you use Express app instances; they have a lot of overhead and were never meant for this kind of grouping. In Express 4.0 the "router" was introduced for exactly the use-case you are trying to achieve with grouping (you can also use the router module if you are using Express 3.x or lower).

There is no good answer for your error handler problem at this time, expect to use an array. The main thing to realize about the special-ness of error handling is how app.use works and what app actually is. If you look at an app in a debugger, you'll see that it is simple a function app(req, res, next) {} reference. By this very nature, it's impossible to pass the error argument down into sub apps (or even sub routers, for that matter).

I have three suggestions for you at this time:
A) Use the router and inject the error into your line of handlers in your error-handlers.js file and export the single function, like what you are doing with all other files (remember, app is just a function):
// File : error-handlers.js
var express = require('express');
var router = express.Router();

// special handler to "inject" error
router.use(function (req, res, next) {
  next(res.error);
});

router.use(function (err, req, res, next) {
  // your first error handler
  next(err);
});

router.use(function (err, req, res, next) {
  // your second error handler
  next(err);
});

// ... etc

module.exports = function (error, req, res, next) {
  res.error = error;
  router(req, res, next);
};

B) Use the array to do groupings in all your files. This not only works for error handlers, but also is even less overhead in your request pipeline.
C) Start up a pull request to either this repository or the router module with the proposed changes you think would help allow you to do this grouping and so we can discuss the changes, how they may impact the existing Express ecosystem, how they fit with the architecture of Express, etc. because grouping of error handlers may be something we want to do, though grouping using an array is going to be the best option (perhaps a change would be to make the path optional still if you are supplying an array to app.use, and you can even make a pull request implementing that as well :) !).


New routes and implementation of stateless in other entities

Note: I could not think of an efficient way to make a mention encode, if you can give me some suggestions, Thank you!

It's all ready to merge, I'm just waiting for your changes.


ios document ready not fired

Hello i am using your new update and i have no luck to let document ready function to be fired
simply
$(document).ready(function(){alert('initialized');});
will not alert anything when old versions of framework working as needed but scroller fix is missed so iam obligated to use your latest version .
Any suggestion or idea ! Thank you in advance for any regards !

Please post a full example somewhere, otherwise we can't help debug

This is the logic of my code :
var app =
{
config : {
web_id : 1,
os : 'android',
language : 'English',
version : 1,
admob_id : null,
analytics_id : '',
app_store : null,
api_link : null,
web_link : "",
//web_link : "",
upload_user_picture_path : null,
upload_video_path : null,
upload_image_path : null,
store :
{
'android' : '',
'ios' : ''
},
ad_units :
{
android : {
banner: '',
interstitial: ''
},
ios     : {
banner: '',
interstitial: ''
}
}
},
is_ready : 0,
debug_mode : 1,
have_back : 0,
operation : '',
current_page : '',
current_program : '',
sender_id : '',
initialize : function()
{
this.config.admob_id = ( /(android)/i.test(navigator.userAgent) ) ? this.config.ad_units.android : this.config.ad_units.ios;
this.config.app_store = this.config.store[this.config.os];
this.config.api_link = this.config.web_link + "Programs/demo/demo.php";
this.config.upload_user_picture_path = this.config.web_link + "Programs/demo/upload_user_pic.php";
this.config.upload_video_path = this.config.web_link + "Programs/demo/upload_video.php";
this.config.upload_image_path = this.config.web_link + "Programs/demo/upload_image.php";
core.bind_system_events();
}
}
var core =
{
bind_system_events : function()
{
$(document).ready(this.validate_application_version);
},
};
app.initialize();
In this scenario document ready is not loaded when using your latest update of framework
Any help !

Again, you need to have everything up so I can test.  You could be missing a file, have includes in the wrong order, etc.

World Deaf

I think this will make the status more clear
<!DOCTYPE html>

        <title>World Deaf</title>
        <meta http-equiv="Content-type" content="text/html; charset=utf-8">

        <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1">
        <meta name="apple-mobile-web-app-capable" content="yes" />
        <link rel="stylesheet" type="text/css" href="appframework/build/css/icons.css" />
        <link rel="stylesheet" type="text/css" href="appframework/css/forms.css" />
        <link rel="stylesheet" type="text/css" href="appframework/css/buttons.css" />
        <link rel="stylesheet" type="text/css" href="appframework/css/afui.css" />
        <link rel="stylesheet" type="text/css" href="appframework/plugins/css/af.popup.css" />
        <link rel="stylesheet" type="text/css" href="styles/style-ltr.css?v=2" />

        <link rel="stylesheet" type="text/css" href="appframework/plugins/css/af.selectBox.css" />

World Deaf

                <input id="temp_value_input" class="hidden" value="" />
                <textarea id="temp_data_area" class="hidden"></textarea>

Enjoy Your Quiet

Using above code will just alert before initializing and will not do anything else so document ready break code

Can you host this fully somewhere so I can see which version of the code you are using?  Also, you if you are using appframework/build/ui/appframework.ui.min.js you do not need any other JS files

after hosting same example into my online web it seem this work so what is the prob and it may be an cross domain request problem and how it may be corrected ?

Look this example is hosted here : http://deafworlapp.com/demo/
But it work as expected when same code is not working on ios emulator

Hope this can give some more infos to reproduce the issue
I noticed this line in the console log
void SendDelegateMessage(NSInvocation *): delegate (webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:) failed to return after waiting 10 seconds. main run loop mode: kCFRunLoopDefaultMode
Hope that can help to track problem
Thank you in advance again !

Looks like there is an error.  Are you using Cordova or something else?

Yes exactly i am using cordova but the matter is even i remove the reference to the cordova.js the problem stays. And if i change the appframework to an earlier version also it works . So the problem as i can explain it is in the new update of the framework , on ios devices !

Did you have any news ! I want to tell you again about the link to the online test because the link i have told about previously was broken http://deafworldapp.com/demo/
Hope you can find the issue ASAP ! Thank you in advance for your best regards !

@mouhammad-zd I just tested the kitchen sink in a cordova app and $(document).ready() works fine.

@imaffett Thank you for replying ! But did you test it on ios or android or both ? and which platform version ?

What version of app framework are you using ?
I've just upgraded to app framework v2.2 from v2.1, and now device ready is not fired on iPod running iOS6. Works just fine on iOS8.

The version i am use it was located in the master branch and as i can see in the top of file this signature
/*! intel-appframework - v2.1.0 - 2014-12-17 */
But when i make a comparison between all js files in my version and the official v2.2 i found the difference only in this line
this.scrollToTop("modal_container");
So as i can say yes i am using v2.2 .........

Please try switching to v2.1.0 release.
I believe that something got broken in v2.2.0 release. Can someone else confirm ?

I don't have time to hunt down bugs on iOS 6.  If you guys find what the issue is, feel free to submit a PR request fixing it.

I can confirm this. The combination of Xcode 6.2, AF 2.2 and iOS7 will not fire $(document).ready, both in simulator and on target. Change to iOS8, and it is OK. Change to AF 2.0 and it is OK. Have not tried AF 2.1 since I have not found the official download yet (AF 2.0 was bounded with Xdk 1632).

@Rockfogel.  Are you using an app from App Designer/XDK or App Framework?  Are you using the jQuery shim?  Please post a sample online so I can debug it.

Fixed here https://github.com/01org/appframework/commit/409d8469f3633c3d5388bd92d354b42f6e373836

I can confirm the the update made in AF 2.2 in 2015-04-21 in file appframework.ui.min.js did the trick.
Now it is working with the new AF2.2 and iOS7. @imaffett: Thanks for quick response. @mouhammad-zd: Hope this also solves your original problem. Good thing you posted it.


ninja build failed

Hi, loongson brothers,  how to solve this problem :(
rango@rango-VirtualBox:~/chromium/src$ ninja -C out/la64_cross chrome
ninja: Entering directory `out/la64_cross'
[47/64340] SOLINK ./libvk_swiftshader.so
FAILED: libvk_swiftshader.so libvk_swiftshader.so.TOC
"python3" "../../build/toolchain/gcc_solink_wrapper.py" --readelf="/opt/llvm_chromium/llvm_install_15.0.7/bin/llvm-readelf" --nm="/opt/llvm_chromium/llvm_install_15.0.7/bin/llvm-nm"  --sofile="./libvk_swiftshader.so" --tocfile="./libvk_swiftshader.so.TOC" --output="./libvk_swiftshader.so" -- /opt/llvm_chromium/llvm_install_15.0.7/bin/clang++ -shared -Wl,-soname="libvk_swiftshader.so" -Wl,-Bsymbolic -Wl,--version-script=../../third_party/swiftshader/src/Vulkan/vk_swiftshader.lds -fuse-ld=lld -Wl,--build-id -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,--icf=all -Wl,--color-diagnostics -Wl,--undefined-version -Wl,--no-call-graph-profile-sort --target=loongarch64-linux-gnu -no-canonical-prefixes -Wl,-O2 -Wl,--gc-sections -rdynamic -Wl,-z,defs -Wl,--as-needed -nostdlib++ --sysroot=../../build/linux/debian_bullseye_loong64-sysroot -o "./libvk_swiftshader.so" @"./libvk_swiftshader.so.rsp"
ld.lld: error: undefined symbol: X8632::createTargetLowering(Ice::Cfg*)
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))

ld.lld: error: undefined symbol: ARM32::createTargetLowering(Ice::Cfg*)
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))

ld.lld: error: undefined symbol: MIPS32::createTargetLowering(Ice::Cfg*)
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))

ld.lld: error: undefined symbol: X8664::createTargetLowering(Ice::Cfg*)
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))
>>> referenced by IceTargetLowering.cpp
>>>               obj/third_party/swiftshader/src/Reactor/swiftshader_subzero/IceTargetLowering.o:(Ice::TargetLowering::createLowering(Ice::TargetArch, Ice::Cfg*))

How to reproduce this error?
Maybe you can try set "supports_subzero=false" in your out/la64_cross/args.gn.


self.locust can not be found

version: 1.1
# coding=utf-8

from locust import HttpUser, TaskSet, task, between

class Google(TaskSet):
    @task
    def index(self):
        print(self.locust.ids)
        self.client.get("/")

class MyUser(HttpUser):
    tasks = [Google]
    ids = [1, 2]
    wait_time = between(3, 5)
    host = "http://www.google.com"

then error occured:
[2020-07-07 00:57:02,586] jarvan4devMac.local/ERROR/locust.user.task: 'Google' object has no attribute 'locust'
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/locust/user/task.py", line 284, in run
    self.execute_next_task()
  File "/usr/local/lib/python3.7/site-packages/locust/user/task.py", line 309, in execute_next_task
    self.execute_task(self._task_queue.pop(0))
  File "/usr/local/lib/python3.7/site-packages/locust/user/task.py", line 321, in execute_task
    task(self)
  File "/Users/jarvan4dev/Documents/locustfile.py", line 9, in index
    print(self.locust.ids)
AttributeError: 'Google' object has no attribute 'locust'

@magupov @cyberw

Try self.user instead of self.locust!

Try self.user instead of self.locust!

Great, it works!
But I can't find related description for this, can you show me?

https://docs.locust.io/en/stable/writing-a-locustfile.html#referencing-the-user-instance-or-the-parent-taskset-instance


feat(deployments): Auto-publish deployments to npm [SIM-236]

PR:

Implements Colin's suggestion that we publish deployments metadata. This should have dividends for both subgraph and set-ui repos - we'll be able to get latest addresses and other deployments data from a package dependency.
Package includes only the production and staging outputs files for Ethereum, Optimism and Polygon. It can be seen on npm here
Adds semantic-release auto-publication to CI
Releases only necessary when changes to the deployments outputs files are merged to master
Minimum Node version for this repository is now 14

We'll need to begin using the following naming convention in PR descriptions here.

Type
Increment
Pattern
Example

none
no change
chore(topic): comment
chore(scripts): DelegatedBaseManager deploy scripts

minor
1.1.1 -> 1.2.0
feat(topic): comment
feat(deploys): Deploy DelegatedBaseManager to Optimism production

(Have added the same semantic release CI check we have running in set-protocol-v2 but Github is having bot issues atm - it may not show up)
In future, if we begin following the "feature" branch convention here we would publish pre-releases by modifying the .releaserc.json file as below:
// For a feature named "intrinsicprod"
{
  "branches": [
    { "name": "master" },
+   {"name": "feat/intrinsicprod", "channel": "intrinsicprod", "prerelease": "intrinsicprod" }
  ],
  ...
}

This would automatically publish 1.0.1-notional.1 whenever deployments are merged to the feat/notional branch. And be installable via
yarn add @setprotocol/set-v2-strategies-deployments@notional

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: switch previous/next article links position

Summary
Put previous article link on the left and next on the right.
I tested it for both main site and translation using tabi demo site.
Related issue

#259

Type of change

[X] Bug fix (fixes an issue without altering functionality)
[ ] New feature (adds non-breaking functionality)
[ ] Breaking change (alters existing functionality)
[ ] UI/UX improvement (enhances user interface without altering functionality)
[ ] Refactor (improves code quality without altering functionality)
[ ] Documentation update
[ ] Other (please describe below)

Checklist

[ ] I have verified the accessibility of my changes
[X] I have tested all possible scenarios for this change
[ ] I have updated theme.toml with a sane default for the feature
[ ] I have made corresponding changes to the documentation:

[ ] Updated config.toml comments
[ ] Updated theme.toml comments
[ ] Updated "Mastering tabi" post in English
[ ] (Optional) Updated "Mastering tabi" post in Spanish
[ ] (Optional) Updated "Mastering tabi" post in Catalan

As discussed in the issue, no fix required but maybe some new features. I'll open a new PR when ready.


add the namespace cattle-fleet-system to the resourceSet for Fleet

issue https://github.com/rancher/backup-restore-operator/issues/129

@jiaqiluo I think you are safe to merge per the SME process.


Bug 2094783: storageclass should not be created for unsupported vsphere version

https://bugzilla.redhat.com/show_bug.cgi?id=2094783
This fix just moves the storage class sync below the point at which we check degradedOrBlockedFromUpgrades so that we do not create the storage class if the upgrade is blocked.
/hold for testing
/cc @openshift/storage

/retest

/test e2e-vsphere-csi-migration

/test e2e-vsphere-csi-migration

/lgtm

/cherry-pick release-4.11


flakey test: brave.jms.ITJms_2_0_TracingMessageConsumer

The below flake happens on occasion. We should fix this, potentially by replacing the test broker with docker as mentioned here https://github.com/openzipkin/brave/pull/1394#pullrequestreview-1807463298
[INFO] Running brave.jms.ITJms_2_0_TracingMessageConsumer
12:52:53,484 WARN  [Thread-1 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@75e09567)] client.ActiveMQClientLogger_impl (ActiveMQClientLogger_impl.java:293) - AMQ212037: Connection failure to invm:0 has been detected: AMQ229014: Did not receive data from invm:0 within the -1ms connection TTL. The connection will now be closed. [code=CONNECTION_TIMEDOUT]
Error:  Tests run: 23, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 26.09 s <<< FAILURE! -- in brave.jms.ITJms_2_0_TracingMessageConsumer
Error:  brave.jms.ITJms_2_0_TracingMessageConsumer.receive_customSampler -- Time elapsed: 0.026 s <<< ERROR!
javax.jms.JMSException: AMQ219016: Connection failure detected. Unblocking a blocking call that will never get a response
	at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:560)
	at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:452)
	at org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.addSessionMetadata(ActiveMQSessionContext.java:507)
	at org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.addMetaData(ClientSessionImpl.java:1531)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnection.addSessionMetaData(ActiveMQConnection.java:670)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnection.authorize(ActiveMQConnection.java:660)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.createConnectionInternal(ActiveMQConnectionFactory.java:925)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.createConnection(ActiveMQConnectionFactory.java:290)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.createConnection(ActiveMQConnectionFactory.java:285)
	at brave.jms.ArtemisJmsExtension.newConnection(ArtemisJmsExtension.java:68)
	at brave.jms.JmsExtension.beforeEach(JmsExtension.java:78)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
Caused by: ActiveMQUnBlockedException[errorType=UNBLOCKED message=AMQ219016: Connection failure detected. Unblocking a blocking call that will never get a response]
	... 13 more

[INFO] Running brave.jms.ITTracingJMSProducer
12:52:59,615 WARN  [main] client.ActiveMQClientLogger_impl (ActiveMQClientLogger_impl.java:413) - AMQ212053: CompletionListener/SendAcknowledgementHandler used with confirmationWindowSize=-1. Enable confirmationWindowSize to receive acks from server!
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.071 s -- in brave.jms.ITTracingJMSProducer
[INFO] Running brave.jms.ITJms_1_1_TracingMessageConsumer
12:53:04,509 WARN  [main] broker.BrokerService (BrokerService.java:2122) - Temporary Store limit is 51200 mb (current store usage is 0 mb). The data directory: /home/runner/work/brave/brave/instrumentation/jms only has 24632 mb of usable space. - resetting to maximum available disk space: 24632 mb
12:53:04,879 WARN  [main] broker.BrokerService (BrokerService.java:2122) - Temporary Store limit is 51200 mb (current store usage is 0 mb). The data directory: /home/runner/work/brave/brave/instrumentation/jms only has 24632 mb of usable space. - resetting to maximum available disk space: 24632 mb

Ah ... this is not Artemis anymore ... I will take it

Hopefully, fixed by https://github.com/openzipkin/brave/pull/1410


URL not found when behind Proxy with Apache (httpd) using subpaths.

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
# v1.py
from fastapi import fastAPI
app_v1 = FastApi(root_path='/api/v1')

@app_v1.get("/")
async def hello():
    return{"Hello"}

# main.py
from fastapi import fastAPI
from v1 import app_v1
import uvicorn

app = FastAPI(root_path('/api/v1')
app.mount('/api/v1', app_v1)

if __name__== '__main__':
   uvicorn.run(app,host='<IP_ADDRESS>', port=8001, debug=True)

Description
The uvicorn server is behind an Apache proxy with this configuration.
<IfModule mod_proxy.c>
        ProxyRequests Off
        ProxyPreserveHost On
        ProxyPass /api http://localhost:8001/ Keepalive=On
        ProxyPassReverse /api http://localhost:8001/
        ProxyTimeout 3600
</IfModule>

When accessing:
https://localhost/api/v1
is expected to return {'Hello'}
But instead, it returns
{"detail": "Not Found"}
As the URL has not been found. What am I doing wrong?
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.68.0
Python Version
3.8.6
Additional Context
No response

@llorencs This is a mis-configuration of your apache configuration, not a FastAPI issue. I believe the following will work:
<IfModule mod_proxy.c>
        ProxyRequests Off
        ProxyPreserveHost On
        ProxyPass /api http://localhost:8001/api Keepalive=On
        ProxyPassReverse /api http://localhost:8001/api
        ProxyTimeout 3600
</IfModule>


Redundant ReceivedCharacter after arrow key and F key on macOS

When you enter the arrow keys and F keys on a Mac, there will be redundant ReceivedCharacter events compared to Linux and Windows.
For example, you can start the window with cargo run --example window on the Mac, and press Left Arrow key, you will see the redundant ReceivedCharacter event, which does not happen on Linux and Windows.
Here are some logs.
WindowEvent { window_id: WindowId(Id(140334732557360)), event: KeyboardInput { device_id: DeviceId(DeviceId), input: KeyboardInput { scancode: 124, state: Pressed, virtual_keycode: Some(Right), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: false } } } }
WindowEvent { window_id: WindowId(Id(140334732557360)), event: ReceivedCharacter('\u{f703}') }
WindowEvent { window_id: WindowId(Id(140334732557360)), event: KeyboardInput { device_id: DeviceId(DeviceId), input: KeyboardInput { scancode: 124, state: Released, virtual_keycode: Some(Right), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: false } } } }

macOS generates unicode corporate-zone characters for various non-printable key presses (F1..., insert/delete, arrows, scroll lock, etc) within the NSResponder - (void)keyDown:(NSEvent *)event message.
Other OS's don't generate characters for these keypresses.
The question to the winit library authors is this: who is responsible for stripping these characters? The winit libray? Or clients of the winit library?
I'm prepared to submit a PR against winit if the desire is to offer clients more uniform keyboard events.

Any updates on this?


Questions about building

Found an issue or bug? Tell me all about!
Describe the issue / bug.

The final build file is too large. I try to make a build from a blank boilerplate and the size turns out to be like over 100mb.
I made a build for my app, it's ok to work with me on my own computer but reported errors while on others. Is there anything I missed during the building process?

Tell me about your development environment.

Node version: v5.3.0
NPM version: 3.3.12
vue-cli version: 2.1.0
Operating System: 10.12.1 Beta

Thank you!

@bryantchan

The final build file is too large. I try to make a build from a blank boilerplate and the size turns out to be like over 100mb.

Unfortunately, yes it is. But this is more related to electron itself, as a blank app is roughly around ~109mb (Just downloading a ZIP'd release is around ~40mb). This file size is somewhat large as electron does a lot more than you might think. It not only carries the Chromium V8 JavaScript engine, it has native APIs for each OS, and supports a portable version of Node.js. In my opinion ~109mb is rather small when you think about everything it has ready for you.
electron-vue does its best to minimize final production builds by taking advantage of webpack and ignoring node_modules.  Thanks to webpack, some of my biggest apps made have never been over 28mb, and that's with all assets like images & fonts.

I made a build for my app, it's ok to work with me on my own computer but reported errors while on others. Is there anything I missed during the building process?

You probably didn't miss anything "during the building process", but this just falls into the category of having to test your app. There's nothing extra in the electron-packager configuration that would produce better results.  A good word to follow by is to "never assume a user has something already installed". One common item I see people assume is having specific fonts available to them. I'm not saying that's your case, but it's just an example.
Hope this helps. 😊

@SimulatedGREG thank you!


NCBI specification

Converted the existing MiAIRR-to-NCBI docs to reStructuredText.
Included the modifications that came up during @javh's test submissions.
Completed split between submission manual and specification.

I looked through the GenBank submission section.  It looks pretty solid to me.  A few minor things.
1. Two changes in the example GenBank record:

KEYWORDS    TLS; Targeted Locus Study; AIRR; .
DEFINITION  TLS: Mus musculus immunoglobulin heavy chain variable region, sequence.

I haven't actually done the TLS submission yet, so these are the only changes I know of right now.
2. I'm not sure whether it should be:

/inference="COORDINATES:nucleotide motif:IgBLAST:1.6"

Or:

/inference="alignment:IgBLAST:1.6"

Something to discuss.
3. Maybe we should mention that the qualifiers in 'source' of the GenBank file need to have identical values to those same qualifiers in the BioSample record. An example of the problem from my earlier test submission:
BioSample
tissue="Peripheral blood "
cell type="B cell"
isolate="HD07"
sex="male "

GenBank submission:
/isolate="HD07"
/cell_type="naive B cell"

Required them to make the following changes:

Changed the BioSample cell type to: "naive B cell" to match the Sequin submission
Added "tissue-type" and "sex" to the Sequin file to match the information in the BioSample.

@javh: The latest commit includes all the changes we discussed today. Please have a look, thanks!

Looks good!  I made a few comments, but they are all just typographical. No content changes.

Ok, all fixed.


nightly release

Auto releases a new version daily, allowing developers to get bug fixes quickly, rather than delaying up to a week before a package that fixes issues.

I'm going to try and refactor our release workflow using GitHub reusable workflows next week. cc @h-a-n-a

For builds, I want to define a target matrix in the caller workflow:
  build:
    strategy:
      matrix:
        target:
          - x86_64-unknown-linux-gnu
          - aarch64-unknown-linux-gnu

The callee reusable workflow will take these targets as inputs and make the correct build.
It seems that I need to defined a mapping from the target to configs.

Done in

https://github.com/web-infra-dev/rspack/pull/2597


Disable-readers-word-edit

Word panel tsx: Trim panel previews and make sure that word panel and paragraph panel options are in their appropriate places. Review stale code in the word panel and paragraph panel. Separate the common panel from the word panel file.


Android - onMapReady doesn't work on Android 7.0 and RNMap 0.21.0

react-native: 0.55.4
react: 16.3.2
react-native-maps: 0.21.0

My map did work with my smartphone on Android 8.1 and others smartphone with some others Android versions
But during my internalTest, a tester noticed me that with a Huawei p8 with Android 7.0 onMapReady is never called so the map is all white and still loading ... I do not having red borders like some other issues
(Don't tell me it is the Android Map API please).
I think this is a problem of config or compatibility ...
If someone is using the map with Android 7.0 let me know to see how fix it.
This is some of my code of my build.gradle file (who is working with others smartphones) :
android {
    compileSdkVersion 26
    buildToolsVersion "25"
    defaultConfig {
        applicationId "com.??.app"
        minSdkVersion 16
        targetSdkVersion 26
        versionCode 3
        versionName "0.2.5"
        multiDexEnabled true
[...]
}

dependencies {
    implementation project(':react-native-geolocation-service')
    implementation project(':react-native-splash-screen')
    implementation project(':react-native-pdf')
    implementation project(':react-native-fetch-blob')
    implementation (project(':react-native-intercom')) {
        exclude group: "com.google.android.gms", module:"play-services-basement"
    }
    implementation "io.intercom.android:intercom-sdk:3.+"
    implementation project(':react-native-android-open-settings')
    implementation project(':react-native-system-setting')
    implementation project(':react-native-onesignal')
    implementation project(':react-native-linear-gradient')
    implementation project(':react-native-i18n')
    implementation fileTree(dir: "libs", include: ["*.jar"])
    implementation "com.facebook.react:react-native:+"
    implementation project(':tipsi-stripe')
    implementation project(':react-native-maps')
    implementation (project(':react-native-camera')) {
        exclude group: "com.google.android.gms"
    }
    implementation "com.android.support:appcompat-v7:23.0.1"
}

Same problem with Airbnb and Uber application ... I had a white animation above a message which was displayed by the map : "Google play services updating"
If you want to know the reason : it is a bug from google play services on some Huawei and Honor ...


Implement request tracking so that edits are clear and concise

Story
Description
Ref. See meeting notes in associated EPIC.
When an edit is requested, similar type of data should be packaged into a single request. For example, if the PO is changed, then the TC is changed, it would be good if both can be packaged so that only one request is sent to the robots for implementation. In addition to this, some requests must be processed sequentially and must bock subsequent requests. For example, a user can only progress through CPU request from S to M then to L; they cannot go directly from S to L. If a request to go from S to M is pending, then subsequent quota edits must be blocked. However, it would be possible for the user to edit project metadata (that only exists in the database) or project details like description or TC.
For simplicity, v1 of this feature can treat any edit as the same and block all subsequent edits until said request is made. If implemented this way crate additional tickets to improve later.
The smart robots processing request must apply them in order (FIFO).
Done When
A user can request edits to quota, and is blocked from making additional requests until the first request is made;
A user can request edits to project details, these requests do not block additional requests to project details.

**released on the registry-web-platform-registry-prod silver cluster: Dec 03, 2020


Bug - trait Scaffolding is not object safe.

This trait is not object safe.

The local documentation that is generated using cargo doc no longer identifies the trait as unsafe, however, when published, the crates.io documentation is still flagging the trait as unsafe.


update run_benchmark.sh to CE

Signed-off-by: liujie44<EMAIL_ADDRESS>
PR types

PR changes

Description

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.liujie44 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Incorrect Error Being Returned

Hey guys, I'm currently trying to integrate graphql-shield into my project which is using type-graphql, inversifyJS and prisma and I'm running into an issue where it seems that no matter what I throw, I get a "Not Authorised!" returned and I'm really not sure why. Relevant Code:
//permissions.ts
const authService = serviceContainer.get(AuthService);

const rules = {
  isAuthenticatedUser: rule()( async (parent, args, context) => {
    const userId = await authService.getUserId(context).catch(err => err);
    return Boolean(userId);
  }),
};

export const permissions = shield({
  Query: {
    me: rules.isAuthenticatedUser
  }
});

// auth-resolver.ts
@Mutation(() => UserResponse)
    async registerUser(@Arg("data") data: RegisterInput): Promise<UserResponse> {
        const { email, password, firstname, lastname } = data;
        const user = await this.authService.register(email, password, firstname, lastname);
        return user;
    }

//auth-service.ts
async register(email: string, password: string, firstname: string, lastname: string): Promise<UserResponse> {
        return new Promise(async (resolve, reject) => {
            const hashedPassword = await hash(password, 10);
            const user = await this.prisma.user.create({
                data: {
                    email: email,
                    password: hashedPassword,
                    firstname: firstname,
                    lastname: lastname,
                },
            // reject error if user can't be created
            }).catch(err => reject(err));
            if (user) {
                resolve(user);
            }
            reject(new Error("Invalid"));
        });
    }

//server.ts
const schema = await buildSchema({
        resolvers: [ AuthResolver, UserResolver ],
        container: serviceContainer,
        emitSchemaFile: path.resolve(__dirname, "./generated-schema.graphql"),
        validate: false,
        dateScalarMode: "timestamp",
    });

    const server = new ApolloServer({
        schema: applyMiddleware(schema, permissions),
        playground: true,
        context: ({ req, res }): Context => ({
            req,
            res,
            prisma: serviceContainer.get(PrismaClient),
            container: serviceContainer
         }),
    });

In the above code, I'm only protecting one endpoint me(). When I called the mutation registerUser() with an email that's already been registered (there's a unique constraint on email) it's responding with Not Authorized, instead of the error that should be resolved from Prisma, any ideas on why this might be happening when registerUser() isn't behind the shield?
(Including a link to sample repository incase that helps: https://github.com/tnolan8/typegraphql-api)

Believe I've found my issue. When inspecting the output of generateMiddlewareFromSchemaAndRuleTree() I can see that it's applying Middleware to all of my types:
MIDDLEWARE:  {
  Query: { me: [AsyncFunction: middleware] },
  UserResponse: {
    email: { fragments: [], resolve: [AsyncFunction: middleware] },
    firstname: { fragments: [], resolve: [AsyncFunction: middleware] },
    lastname: { fragments: [], resolve: [AsyncFunction: middleware] },
    createdAt: { fragments: [], resolve: [AsyncFunction: middleware] }
  },
  Mutation: {
    registerUser: { fragments: [], resolve: [AsyncFunction: middleware] },
    loginUser: { fragments: [], resolve: [AsyncFunction: middleware] }
  },
  AuthPayload: {
    token: { fragments: [], resolve: [AsyncFunction: middleware] },
    user: { fragments: [], resolve: [AsyncFunction: middleware] }
  }
}

When the middleware is executing for registerUser() it gets to: return await resolve(parent, args, ctx, info) Ln 70 in generator.ts. The parent fails to resolve because of the failure on the unique constraint and is then caught in the catch() block. Looks like all I needed was to set { allowExternalErrors: true } when creating the shield, seems to do the trick.

Thanks for following up with your solution, @tnolan8. I'm also using Prisma and was wondering why I was seeing the "Not Authorised!" message, despite having a custom error in my resolver. Adding allowExternalErrors: true fixed it for me, too. Thanks.

Hi, @maticzav. 👋
Thanks for your message. No, the docs aren't unclear; I just clearly didn't read everything thoroughly enough. Taking another look now, the docs cover all of this well.
Related to the issue I thought I had, I did have an error being thrown in my resolver but all I ever got was "Not Authorised!". I thought this was an issue that I could resolve with allowExternalErrors: true but I see now, looking at the docs again, that this is by design. I'll go back through my error handling and, where necessary, return the errors as opposed to throwing them.
This tool is great, by the way. Thank you very much for your hard work on it. I think one of the reasons I rushed through the docs is because I started a project (with Prisma 2) using an example that was using an old version of this package so I didn't pay much attention to it at first until I realised I needed to update it and add some more rules. 😄

😂 I see! Awesome! I am glad that you've fixed your issue and that you enjoy the library.


Assign Roles to Users for Managing Business Rules

Tutorial URL: https://developers.sap.com/tutorials/cp-cf-businessrules02-assign-roles.html
Please specify the step you are referring to: Step 2 Assign role collection
In some cases it seems that there's an extra step required. In my case, I had to click through this:

Might be worth adding that to avoid confusion?

Hi,
Thanks a lot for this. I'll add this particular step to avoid confusion. :)
Best Regards,
Vandana

https://github.com/SAPDocuments/Tutorials/pull/4258


pool: Remove code related to unsupported ASICs.

This requires #399.
This removes all code related to ASICs that are no longer supported since they mine blake256 and the hash algorithm is now blake3.
The removals are done in separate commits to ease review.
In particular, support is removed for the following ASICs:

Whatsminer D1
Antminer DR5
Antminer DR3
Innosilicon D9
Obelisk DCR1

Just needs a rebase and its good.

Theres one last reference to antminer in difficulty_test.go if you wanted to nuke that, no big deal though.

Theres one last reference to antminer in difficulty_test.go if you wanted to nuke that, no big deal though.

Changed it over to "non-existent" since that is the purpose of the test.


Replace Expects from MS-GSL

MS-GSL Expects works also in a release build trashing the generated assembly with checks and branches. It caused regression in #164.
Replace with another precondition check that does not work on a RELEASE build.

Yes, it does so unconditionally at the moment. But that behavior is being debated at https://github.com/isocpp/CppCoreGuidelines/issues/1561.

Now we can't use units trunk on Compiler Explorer: https://godbolt.org/z/vj4Whq.
In file included from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/ratio.h:27,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/bits/basic_concepts.h:29,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/one_rep.h:25,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/physical/si/base/electric_current.h:25,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/physical/si/si.h:25,
                 from <source>:1:
/opt/compiler-explorer/libs/mp-units/trunk/src/include/units/bits/ratio_maths.h:33:10: fatal error: gsl/gsl-lite.hpp: No such file or directory
   33 | #include <gsl/gsl-lite.hpp>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
Compiler returned: 1

Now we can't use units trunk on Compiler Explorer: https://godbolt.org/z/vj4Whq.
In file included from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/ratio.h:27,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/bits/basic_concepts.h:29,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/one_rep.h:25,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/physical/si/base/electric_current.h:25,
                 from /opt/compiler-explorer/libs/mp-units/trunk/src/include/units/physical/si/si.h:25,
                 from <source>:1:
/opt/compiler-explorer/libs/mp-units/trunk/src/include/units/bits/ratio_maths.h:33:10: fatal error: gsl/gsl-lite.hpp: No such file or directory
   33 | #include <gsl/gsl-lite.hpp>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
Compiler returned: 1


Feature/core #150

Codecov Report

Merging #153 (f49594d) into master (f61b1d5) will decrease coverage by 0.17%.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   97.99%   97.81%   -0.18%
==========================================
  Files          53       58       +5
  Lines        2092     2109      +17
==========================================
+ Hits         2050     2063      +13
- Misses         42       46       +4

Impacted Files
Coverage Δ

glasses/nn/models/__init__.py
100.00% <ø> (ø)

glasses/nn/models/classification/senet/__init__.py
100.00% <ø> (ø)

glasses/utils/PretrainedWeightsProvider.py
96.29% <81.81%> (+0.03%)
:arrow_up:

glasses/nn/models/AutoModel.py
90.00% <90.00%> (ø)

glasses/nn/models/AutoConfig.py
91.66% <91.66%> (ø)

glasses/__init__.py
100.00% <100.00%> (ø)

glasses/nn/__init__.py
100.00% <100.00%> (ø)

...asses/nn/models/classification/alexnet/__init__.py
100.00% <100.00%> (ø)

...sses/nn/models/classification/densenet/__init__.py
100.00% <100.00%> (ø)

.../nn/models/classification/efficientnet/__init__.py
99.25% <100.00%> (-0.10%)
:arrow_down:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61b1d5...f49594d. Read the comment docs.


Computed: memory leak

Version
3.0.0
Reproduction link
https://pastebin.pl/view/raw/ac6ade7c
Steps to reproduce

Click on clear button
In chrome, take a memory heap snapshot.

What is expected?
MyClass instances are not in the snapshot.
What is actually happening?
MyClass instances are in the snapshot.

The instances are retained by the 'computedField' computeds, which are retained in someRefThatExistsLongerThanA's depMaps:
https://github.com/vuejs/vue-next/blob/d52d139b854238708195f5d332b7d0ec3a4883a5/packages/reactivity/src/effect.ts#L143
This is because dependencies from someRefThatExistsLongerThanA to computedFields are never cleared, except immediately before re-evaluating them. Computed does not have an exported way to 'cleanup' them, like watch and watchEffect have (WatchStopHandle).
We ran into this when we found a memory leak in one of our applications.
Solutions:

ComputedRef.cleanup
ComputedRef could offer a cleanup method which simply runs the effects' cleanup (https://github.com/vuejs/vue-next/blob/d52d139b854238708195f5d332b7d0ec3a4883a5/packages/reactivity/src/effect.ts#L111), as well as triggering itself. The latter is necessary to recursively trigger computed dependees, so that they become dirty and don't return stale results when called later - if ever.
Downsides are that this should be done manually by the developer, and that calling computedRef.cleanup will also invoke watchers if they are still active - so they should be unregistered before cleaning up the computeds that they depend on. In practice it will be quite cumbersome, and another chore for developers.

Alternatively, we could clear the gathered Sets as part of add (https://github.com/vuejs/vue-next/blob/d52d139b854238708195f5d332b7d0ec3a4883a5/packages/reactivity/src/effect.ts#L180). There's no point in maintaining them anyway from this point, as all dependees are triggered and will re-evaluate.
The benefit is that if all dependencies have been updated for some computed, that it will be totally dereferenced. The developer doesn't have to do anything except for - possibly - being careful with refs that are never or rarely updated. When such a case is encountered, triggerRef could be used to make sure that dependees are dereferenced once in a while. In practice this is not very likely to happen though.

There is another positive side effect, in that dependees that were marked dirty have been removed already, and do not have to be traversed upon every update of the dependency. In our own use case this is greatly beneficial, as we're having up to 20'000 rows that have a computed that depends on one global computed, while only a fraction of rows is actually invoked.

see https://github.com/vuejs/rfcs/pull/212

Thank you for the boiled down and detailed report. This is a part of the problem related to the fact that reactive properties are only automatically cleaned and must be attached to a component instance to be cleared (called inside of setup). As pointed out, https://github.com/vuejs/rfcs/pull/212 is meant to tackle the larger problem.
As a workaround, you can create something like this https://github.com/antfu/vueuse/blob/039aea9809c45f74a86cdef9248d821a1d24f8f0/packages/core/createGlobalState/index.ts#L3-L16 to be able to unmount the app manually and remove all dependencies.

Thanks @posva
The workaround is not really useful for our situation, in which we have a class-based model using reactivity. We want parts to be cleaned up, not the full app.
The propasal seems good for more advanced use cases, but it seems a bit overcomplicated for simple use cases. I don't want to have to create and cleanup a scope everywhere we're using a computed. The management of creating and cleaning them up is cumbersome, hacky and prevents syntax like:
class MyClass {
  public myComputed = computed(() => ...)
}

I can't wrap that computed in a scope at that place. I'd have to move their definitions to the class constructor and then create a manual destructor method which should be called from somewhere else. The management of calling it is an unnecessary complexity. Feels like boiler plate code as well.
All I'm suggesting: when dependees are triggered, just remove them from the depsMap. This is a tiny change, and will automatically cleanup stale computeds from the deps instead of holding on to them forever. Finally allowing the GC to clean them up. And it will save some performance as well when there is a large quantitiy of dependees that are not really used, reducing the deps set. This just works, scope or no scope.

Yeah, The second proposal about clearing the Set might still be worth looking into, it seems to me.
Not necessarily as a bugfix for this rather than an optimization.

Added a PR. Tests are all passing as expected.
I verified with the original example that, after clicking the 'updateRef' button, the computeds and instances are indeed dereferenced.

You are right, it's worth cleaning up the held reference if possible. Thanks for the PR!

Hmm, technically this isn't a leak, because a computed property creates an effect which needs to be stopped to release itself from all depMaps.
When you create a computed inside a component's setup(), its effect is automatically stopped when the component unmounts so the user don't need to think about it.
In your case, you need to make sure your class instances, when "cleared", properly stop all the effects it created (including raw effects, watchers, and the computed properties).
#2263 doesn't actually fix the problem since it only deletes the effect when the effect is triggered by the outer scope ref - i.e. you need to click "updateRef" after clear for it to work. If the ref is never updated, the class instances are still going to be kept in memory. Also, this only works for computed because its getter is run lazily, it wouldn't work for raw effects or watchers.
I would say what's proposed in https://github.com/vuejs/rfcs/pull/212 should be the right solution here. In terms of ergonomics, I imagine something like this would help:
function autostop(factory) {
  let instance
  const scope = effectScope(() => {
    instance = factory()
  })
  instance.teardown = () => stop(scope)
}

// when creating class instances, wrap inside autostop
let aInstances = Array.from({ length: 10}, (x, i) => autostop(() => new MyClass(i)));

// when clearing instances, call stop()
aInstances.forEach(i => i.teardown())
aInstances = [];

Hi Evan, thanks for your response. I can see the advantage of using scopes, and I like that PR. However, it would make sense to be able to stop the computeds individually, as we can do with watchers.


Chromecast Subtitles not working

I want to move to mediaelement instead of videojs.
The chromecast plugin seems to work for media files but the subtitles are not displayed on the chromecast.
The subtitles are working in the web player but when casting they just disappear, could anyone help me out?
See source: https://pastebin.com/raw/DU8AHQVy
Reference: https://github.com/mediaelement/mediaelement-plugins/blob/master/docs/chromecast.md
Update:
I added my own vtt file to my local server to make sure cors is working, see proof that chromecast accessed the file: https://i.imgur.com/ZIVroUp.png
However, no subtitle displayed on screen.
Is it possible the code missing some request.activeTrackIds = [0] to activate the subtitle or something?

@payflix Thanks for reporting this. I'll check this and let you know my findings.


Developer Tools Blank on Linux Ubuntu 16.04

I'm still seeing #664
Any time I open the dev tools they are just a blank white area of the window. I can click and cause things to happen, but can't see any of the controls.
Screenshot appears to be in device mode. Note the white area around and on the right of the actual terminal.

Hyper 1.1.0
Electron 1.4.7
linux x64 4.4.0-59-generic

@fearphage @flybayer is this happening for you guys?

I cannot confirm, but I'm on 16.10 (x64). I would add the tag regression. This was working previously.

Dev tools work for me on Ubuntu 14.04.

Hey there, please try again with the new Hyper v2 release and open a new issue if the problem stills exists. Thank you!


Velocity RTL product image zoom floats right - not showing

Bug report
Title
Velocity RTL product image zoom floats right - not showing
Issue Description
when hovering over product image in the product details page, the zoom container floats right in RTL layout
Preconditions
1. framework Version: v1.1.2.

@devansh-webkul
when we hover a product image in ar then zoom image is should not show with spaces from the actual image https://prnt.sc/tp94rg

Fixed this issue https://github.com/bagisto/bagisto/pull/3586

need to fix for multiple images as well https://prnt.sc/vhh3sb


Add a fusion detection section

Migrated from rnabio.org proposed improvements page
We previously had a fusion detection module but it was difficult to complete in time frames appropriate for a workshop. Further optimization is required. Another challenge is the lack of well engineered fusion detection software. This publication State-of-the-art fusion-finder algorithms sensitivity and specificity does a decent job of summarizing the current options available. Another caveat of this topic is that is mostly of interest to cancer researchers so it might only be included where there are sufficient students with this interest.

Pizzly? (As already done in pmbio.org)
STAR-fusion?
FusionCatcher?
Annotate with AGfusion?


Dependency Issue -<EMAIL_ADDRESS>

Trying to run my pipelines right now is giving me a 401 error when running the set-up step for this action. Possible solution: bump to a new version of x/text?

Nope, nevermind. The error was from the pusher, not Golang. I needed to update my Tailscale API key secret.


Have both Blue and Red Teams

add the intel gpu support back

There are already several forks that have diverged before the red team update and have continued building on the Intel functionality. https://github.com/vosen/ZLUDA/network

I doubt he couldn't without spend consider amount of time.

just wrap previous code in a if macro, whats the problem :)

I'm closing this as duplicate. Feel free to continue discussion in #85


Conversion Issues

Chunker Version
chunker-cli-1.4.2
Input World Version
Bedrock 1.21.40
Output World Version
Java 1.20.2
Platform / Operating System
Windows 10
Issue Description
Converting Bedrock 1.21.40 to Java 1.20.2
Redstone Wire
I only tested a single disconnected piece of redstone wire. These results raise concern for all other redstone as this is the simplest case.
This oss version converted redstone wire to east=none,north=none,power=0,south=none,west=none
The web version converted redstone wire to east=side,north=none,power=0,south=none,west=none
I believe both are wrong and they should have created east=side,north=side,power=0,south=side,west=side
Twisting Vines
I tested a stack of 4 twisting vines.
This oss version converted all 4 to minecraft:twisting_vines_plant but I believe it should have converted the top to something like minecraft:twisting_vines[age=7]
The web version converted all 4 to minecraft:twisting_vines[age=25] but I believe it should have converted the stems to minecraft:twisting_vines_plant
Wrap
This test included every single block so other than the glaring omission of minecarts, armor stands, and even boats (because the chest boats have inventories), this is looking like a pretty good replacement for chunker. Unfortunately I have run out of willpower to run further tests before the chunker web shutdown, any other errors will have to be found one at a time.

Thanks for the detailed report, I can replicate the redstone_wire issue, so we'll hopefully get that fixed. Regarding the Twisting Vines, do you have a specific map that replicates the issue? I was unable to replicate it, and my vines are visually identical converting from Bedrock 1.21.50 -> Java 1.21.4 (with Calculate Block Connections Using Neighbours enabled).

Just as an update, the latest release (1.4.3) should improve the logic of connecting redstone_wire.


'ascii' codec can't encode characters in position 3-6: ordinal not in range(128)

Empire Version
latest
OS Information (Linux flavor, Python version)
debian 7
when i'm trying to cd or ls folder with russian name(for example)

Фото

it shows me
File "/root/Empire-master/lib/common/packets.py", line 167, in build_task_packet
    return taskType + totalPacket + packetNum + resultID + length + data.decode('utf-8').encode('utf-8',errors='ignore')
  File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 3-6: ordinal not in range(128)

if i set default language for python to utf-8 in empire file it will show:
invalid packet: <here huge number>

seems packet just gets broken
i've tried to install locales/etc from google, nothing help

This has been fix per #589

still have problem while trying cd/etc to folder with russian name

Problem still exists, used latest version from dev
Now even when client trying to connect:
[2017-11-05 15:32:08,106] ERROR in app: Exception on /admin/get.php [GET]
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/root/Empire//lib/listeners/http.py", line 891, in handle_get
    dispatcher.send("[!] Error from agents.handle_agent_data() for %s from %s: %s" % (request_uri, clientIP, results), sender='listeners/http')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xbe in position 18: ordinal not in range(128)

btw according to b3b80cb6a8a3430205cd80c532b5edb4aee16508
it anyway will not fix them problem when we try cd/etc to folder with russian name, or download file, etc

This has been reopened by #1011.

Easy to reproduce, create a folder with russian name and try to cd there, or try to download file with russian name, still not working.

This is probably going to be a giant dev pain... basically we have to go through everywhere and make sure there are correct encode and decode calls and that nothing assumes ascii. Doable but ugh.
@n0n0n0n0 if you have some spare cycles you can go to the line number indicated in the stack trace and try a variable_causing_problems.encode('utf-8'). If you track down all the places that variable is used and do proper encode/decode calls that will almost certainly fix your problem.

Hi,
What is the solution to this problem?

@LIZySARA we don't have a solution currently. If this is urgent, you can try @DakotaNelson's suggestion.

@DakotaNelson with your suggestion i see only questions rather than normal words.

@xorrior  thx

Hi, all. You can try add the following code to ./empire after import section:
reload(sys) sys.setdefaultencoding('UTF8')
This prevent mentioned exceptions, I think, and I'm event able to download file as mention later. But there is still something wrong. When you do cd command i got invalid type error:
`
(Empire: VR7HGU8F) > cd řěšč
(Empire: VR7HGU8F) > [!] Received error response from VR7HGU8F
[*] Agent VR7HGU8F returned results.
Path
C:\Users\winnie\Desktop
invalid type: 41413
You can do cd or download using question marks as follows:
(Empire: VR7HGU8F) > cd ????
[] Tasked VR7HGU8F to run TASK_SHELL
[] Agent VR7HGU8F tasked with task ID 23
(Empire: VR7HGU8F) > [*] Agent VR7HGU8F returned results.
Path
C:\Users\winnie\Desktop\řěšč
[] Valid results returned by <IP_ADDRESS>
pwd
[] Tasked VR7HGU8F to run TASK_SHELL
[] Agent VR7HGU8F tasked with task ID 24
(Empire: VR7HGU8F) > [] Agent VR7HGU8F returned results.
Path
C:\Users\winnie\Desktop\řěšč
[*] Valid results returned by <IP_ADDRESS>
(Empire: VR7HGU8F) > download ???????.txt
[] Tasked VR7HGU8F to run TASK_DOWNLOAD
[] Agent VR7HGU8F tasked with task ID 27
(Empire: VR7HGU8F) > [+] Part of file čžýýážř.txt from VR7HGU8F saved
[] Agent VR7HGU8F returned results.
[] Valid results returned by <IP_ADDRESS>
[] Agent VR7HGU8F returned results.
[] File download of C:\Users\winnie\Desktop\čžýýážř.txt completed
[*] Valid results returned by <IP_ADDRESS>
`
But cant find the main cause. Tried to play with PS agent encoding, but no luck.

@ winnie22
Hi, all. You can try add the following code to ./empire after import section:
reload(sys)
sys.setdefaultencoding('UTF8')
Hi, can you make the change and then capture us?
thx

@n0n0n0n0 The partial patch from #1083 has been applied to the dev and master branch. We'll keep this open until we have a complete solution.

Hi all, good news! #1093 should fix this issue. mkdir/cd/pwd/download everythink works for me.

Hi, everyone! I just tested dev branch with merged fix and everything works for me. Can anyone verify this fix, so we can close this issue? Thanks

@winnie22 I'll take a look at it

@winnie22 it looks like cd, pwd, etc work just fine. Download still has issues.

Hi, @xorrior thanks for testing! According to your file listing, size of the file is 0, which doesn't download anything (I hit this "feature" couple off times :)). Could you please validate download with file with size larger than 0. Thanks!


Windows CI with Appveyor

Good news: this PR introduces CI on Windows.
Bad news: tests are failing.
Ok news:  it seems reproducible on my machine, so I can probably start fixing it.
@lmcinnes: you will need to click on the badge and then activate the repo on Appveyor to start this going. If you don't have an account you can give it access via github, similarly to travis-ci. Speaking of which, the travis ci also needs to be activated by the same method (click its badge and so on).

Thanks, I believe I have enabled them both now. I have never been terribly good at CI infrastructure, so I definitely appreciate this.

Great, kooks like it's working as expected. I'll look at adding code coverage once the Windows tests are fixed.


fix: add Object.is ponyfill to improve ie compatibility

Summary
use ponyfill to replace Object.is due to ie compatibility.

Test plan

➜  loadable-components git:(add-Object.is-ponyfill) ✗ yarn test
yarn run v1.16.0
$ jest
 PASS  packages/server/src/util.test.js
 PASS  packages/server/src/ChunkExtractor.test.js
 PASS  packages/component/src/loadable.test.js
 PASS  packages/babel-plugin/src/index.test.js

Test Suites: 4 passed, 4 total
Tests:       83 passed, 83 total
Snapshots:   55 passed, 55 total
Time:        3.961s
Ran all test suites.
Done in 5.60s.

cacheKey is expected to be just a string. Do we even need Object.is comparison?

@theKashey I don't know the previous design. I found that starting from 5.10.0, I can't open the page after using this dependency in IE browser. So I submit the pr.

Fixed in #392


fix(plugins/plugin-bash-like): ls does not show mounts, but tab compl…

…etion does
Fixes #6997

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

not quite, we missed the ls (with no arguments case)


Add pointclouds to realsense_wrapper

Description
Add simple depth images and pointclouds to realsense wrapper. Makes sure to align the depth images.
Note -- is there a simple testing harness for the realsense wrapper?
Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[x] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
If this PR introduces a change or fixes a bug, please add before and after screenshots (if this is causes a UX change) or before and after examples(this could be plain text, videos etc ) to demonstrate the change.
If this PR introduces a new feature, please also add examples or screenshots demonstrating the feature.
Testing
Please describe the tests that you ran to verify your changes and how we can reproduce.
Checklist:

[ ] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added relevant collaborators to review the PR before merge.
[ ] [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

Codecov Report

Merging #1066 (3135f93) into main (97760c2) will increase coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head 3135f93 differs from pull request most recent head e1fd237. Consider uploading reports for the commit e1fd237 to get more accurate results

@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   33.92%   33.93%
=======================================
  Files         343      343
  Lines       33429    33429
=======================================
+ Hits        11341    11344    +3
+ Misses      22088    22085    -3

Impacted Files
Coverage Δ

agents/droidlet_agent.py

agents/_agent.py
51.76% <0.00%> (ø)

interpreter/craftassist/tasks.py
75.00% <0.00%> (+0.54%)
:arrow_up:

Will wait for @0wu's refactor

I totally agree the realsense_wrapper isn't the most general interface. I'm not sure which cameras we have in the pipeline, but with the barebones/simple nature of the wrapper I'm hoping it becomes easy to extend when we get there.


Button with value not setting value in event

Hi,
I'm using <RaisedButton value="5" /> and handling the onClick event.  Using a normal button, this has e.target.value set on it, however, it doesn't seem to be set with the RaisedButton.
Is this because of the touch tap? Or is there something else I need to do?
Thanks,
Chris

The value property is passed to the underlying <button> element, but in the click handler, e.target is the wrapping element instead.
What you probably want to do is something like this:
<RaisedButton onClick={this.handleClick.bind(this, 5)}>,
and then in the handler:
handleClick: function (value, event) { ... } - there you have the value.

@chrismcv could you confirm that the solution suggested above works for you, so I can go ahead and close this?

apologies - should have closed this ages ago... bind does of course work


Fix scipy < 0.14 for trapz support until we can fix it generally

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Addresses https://github.com/joezuntz/cosmosis-standard-library/issues/131 temporarily

@conda-forge-admin, please rerender


Marshmallows - Alton Brown Recipe - Food.com

https://www.food.com/recipe/marshmallows-alton-brown-270822

Use vegan version instead.


Wrong CSS selector in login page plugin

Hey I just noticed annoying little change in latest Wordpress if you want to change for example logo image you must use id-selector instead of class as shown in tutorial 2.3 Brand the login screen.
So for all those like me wondering why nothing happens instead of this:
.login h1 a {   // Styles here }
You must use:
#login h1 a {   // Styles here }
Other than that great tutorial!

thanks #samirgh


fix: remove unused imports in icons plugin

Description

This PR also includes:

bump vite pwa to 0.20.4
bump assets generator to 0.2.6
add ./package.json to package exports

Linked Issues

Additional Context

[!TIP]
The author of this PR can publish a preview release by commenting /publish below.

/publish


Add short design doc discussing handling of 10x bundles

This fixes #95 , a spike ticket.

Favor option (2) over (1) given the DSS latency we're already experiencing in the Worker. +1 to subscribing to DSS notifications.
I'm curious what complexity would be introduced if we were to create a job that scrapes all matrix-able bundles from a DSS environment and initializes bundle_cell_count_table. On the other hand, such a tool would only improve processing times for the first request and probably isn't worth all the overhead. Option (2) proposed as is (with DSS subscriptions) sounds simple and good to me!

A larger discussion, but relevant here: Do we want to reduce DSS interaction in the Worker as well? We have discussed in the past storing more bundle data than just bundle_cell_count outside of the DSS (e.g. all expression matrix data). This would be a complex feature requiring significant engineering effort, however, breaking up the DSS API and distributing its traffic may be necessary for improving performance across the DCP. That being said, I'm unsure how much of our performance bottleneck is due to DSS latency. There are 2 things I'd be interested in diving deeper into from here:

What does our performance look like now and where do we need to improve?
a. This will be captured in the Locust user load tests
Is there a larger, DCP-wide need to reduce stress on the DSS API?
a. What improvements can we make to the DSS to achieve this? As mentioned above, an example would be a separate API/system to host/serve expression matrix data

On further thought, option 2 by itself also gives me pause. A dss notification is not something easy to handle operationally. For one, you would also need to handle bundle deletes and updates. There is also the risk (guarantee at large enough scale) that a notification falls through the cracks. You are now also having to maintain another db of sorts. In this case, would we also then code in option 1 if we can't find the bundle in our local table? I think this discussion has a certain level of complexity that warrants an in-person design session. We should combine this discussion with the spike in https://github.com/HumanCellAtlas/matrix-service/issues/131 as there is quite a bit of overlap.

@mckinsel can this PR be closed per the discussion that followed?


Mention cobyla in docs and README

Cobyla 0.3 joins the argmin solvers family.

Codecov Report
Base: 93.39% // Head: 93.39% // No change to project coverage :thumbsup:

Coverage data is based on head (0dd6d6c) compared to base (f2549a9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   93.39%   93.39%
=======================================
  Files         119      119
  Lines       18975    18975
=======================================
  Hits        17721    17721
  Misses       1254     1254

Impacted Files
Coverage Δ

argmin/src/lib.rs
100.00% <ø> (ø)

argmin-math/src/vec/add.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/div.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/dot.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/eye.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/mul.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/sub.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/zero.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/l1norm.rs
100.00% <0.00%> (ø)

argmin-math/src/vec/l2norm.rs
100.00% <0.00%> (ø)

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This is excellent, thanks! :tada:


travis and coveralls setup

Changes Unknown when pulling 5d8dd25a436ddfb08824a4a675a13f4a4e00946a on travis into ** on master**.

Changes Unknown when pulling bee319abeea2db9ece34b25bf33e2f9cdd609f45 on travis into ** on master**.

Changes Unknown when pulling 29a6a706289045b916773591db8f396e3bcca3c4 on travis into ** on master**.

Changes Unknown when pulling 8b97ee7ad7498018f1eed8201d1a18b9846db9a9 on travis into ** on master**.


Suggestion: redeployment instructions

Simplicity looks really awesome, but there are no instructions in the readme for how to redeploy it. This makes it harder for people to contribute to the project, either to make Asheville's better or to build a fork for their own city.
Ideally the instructions would cover everything someone would need to know and all commands to fire off at the terminal to get their own copy running, with notes on what would need to change to swap out the datasets for another city's data sets (or a test set).
Thanks!
--Ben Novack
@CfABrigadePhiladelphia Projects Lead

Thanks, @bennovack! This absolutely needs to be done. I neglected this for a while cause things were changing rapidly, but now there's really no excuse. I'll get something up soon!

If it helps, I'm happy to play Guinea pig/tester.
On Wed, Sep 30, 2015 at 8:46 PM, Cameron Carlyle<EMAIL_ADDRESS>wrote:

Thanks, @bennovack! This absolutely needs to be done. I neglected this for a while cause things were changing rapidly, but now there's really no excuse. I'll get something up soon!
Reply to this email directly or view it on GitHub:
https://github.com/cityofasheville/simplicity-ui/issues/132#issuecomment-144584592


Added python script for a Research paper latex parser

Description
A short summary of what is included in your Pull Request.
Fixes #31
Type of change
Choosing one or more options from the following as per the nature of your Pull request.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Documentation Update

Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.

[X] I have named my files and folder, according to this project's guidelines.
[X] My code follows the style guidelines of this project.
[X] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[X] I have commented on my code, particularly in hard-to-understand areas.
[X] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[ ] I have included a requirements.txt file (if external libraries are required.)
[X] My changes do not produce any warnings.
[X] I have added a working sample/screenshot of the script.

Just add a few comments in the code(on hard to understand areas ) else everything is good
And add a requirements.txt file for the external libraries used and therefore update the section of readme to -- pip install -r requirements.txt

Okay, will do that.
Thanks!

Just add a few comments in the code(on hard to understand areas ) else everything is good
And add a requirements.txt file for the external libraries used and therefore update the section of readme to -- pip install -r requirements.txt

Okay, will do that.
Thanks!

Have added comments and a requirements.txt file.Please review the same.
Thank you!

@allcontributors please add @priya-mane for code


[Fix] Avoiding crash on cancel with only credit card

[Fix] Avoiding crash on cancel with only credit card
En el caso de sólo tarjeta de crédito, al hacer back en el formulario, se estaba intentando trackear la selección de payment vault, pero la misma era null porque se auto seleccionó crédito, entonces crasheaba la app.

Codecov Report

Merging #618 into develop will increase coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #618      +/-   ##
===========================================
+ Coverage    27.17%   27.21%   +0.04%
===========================================
  Files          223      223
  Lines        16668    16669       +1
  Branches      1457     1458       +1
===========================================
+ Hits          4530     4537       +7
+ Misses       11649    11645       -4
+ Partials       489      487       -2

Impacted Files
Coverage Δ

...ain/java/com/mercadopago/PaymentVaultActivity.java
37.73% <0%> (-0.09%)
:arrow_down:

...ain/java/com/mercadopago/GuessingCardActivity.java
16.59% <0%> (+0.2%)
:arrow_up:

.../mercadopago/presenters/GuessingCardPresenter.java
19.08% <0%> (+0.2%)
:arrow_up:

...c/main/java/com/mercadopago/CardVaultActivity.java
69.27% <0%> (+1.2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c04acf...050accd. Read the comment docs.


buildbucket "Internal server error" during try builds

I've seen this twice on the beta branch framework try jobs: https://ci.chromium.org/p/flutter/builders/try/Linux tool_integration_tests/65?
buildbucket.schedule Request #0
Status code: 13
Message: Internal server error

It seems intermittent. I'm not sure if it's actionable or not, but I filed this to track.

This is an issue being tracked by LUCI team. Will post a link to their tracking bug when I get it.

https://crbug.com/1174310

Upstream bug has been fixed. Closing this bug.


Suggestion: Add an explicit page with the recommendation against formatting/style rules

What problem do you want to solve?
Continuing https://github.com/eslint/eslint.org/issues/419: much of ESLint's community still uses ESLint for formatting logic. Two common user behaviors that are explicitly recommended against by at least me are:

Directly using ESLint's formatting rules (max-len, semi, etc.)
Using eslint-plugin-prettier to run Prettier through ESLint

I'm under the impression that at least the first of those two, using ESLint's formatting rules, is something the ESLint team explicitly recommends against (e.g. https://github.com/eslint/eslint.org/issues/419#issuecomment-1437511290). At the very least we recommend against it in https://typescript-eslint.io/linting/troubleshooting/formatting.
And I've been recommending against the eslint-plugin-prettier option because it slows formatting down to the speed of linting (which is particularly irksome on projects that enable slower, more powerful type checked rules).
What do you think is the correct solution?
Could we have an explicit notice somewhere on eslint.org indicating suggestions for how to use ESLint properly? How about a Configuration FAQs page with an entry for each of the two points mentioned here?
Participation

[X] I am willing to submit a pull request for this change.

Additional comments
No response

It's fine to state its cons. but I'm not an enthusiastic fan to against this usage. actually, i can see both sides:
Pros:

Totally configurable (compared to prettier).
Easier to use, one tool to linting and formatting.

I remember @antfu wrote an article: https://antfu.me/posts/why-not-prettier. :)

As a user, I am very fond of ESLint's rules design that allows you to do anything with the AST. Fully customizable and extendable (via custom rules/plugins), making ESLint very powerful and attractive. @aladdin-add already stated the main two points in my mind - being able to use one config + one command to set up ESLint for both linting and formatting is a very good experience.
As a maintainer of many projects, I do understand the maintenance burden on this, and I can relate to the feeling of handling a sea of nitpicking requests. So I am totally up to the decision ESLint made to freeze the stylistic rules and leave it to the community.
But I think saying "against" stylistic rules and recommending Prettier is not an ideal solution as Prettier is an opinionated tool and does not fit very well with ESLint philosophy. A statement like that feels like a 1 and 0, implicitly delivering the message of "you are doing it wrong, and you should use Prettier" making it seems there is no middle ground.
I wish there could be a more configurable, less-opinionated Prettier alternative to recommended - but honestly, I expect it ends up being very similar to what ESLint is like right now. So to me, regardless, there is a "Lint" in the name. The core of ESLint is actually an AST checker and transformer, which is capable of doing some formatting jobs.
So, IMHO, the docs should say something like:

The builtin stylistic rules are frozen and might not cover all the cases due to the maintenance priority. If you have very strict styling needs, we recommend you look for community stylistic rules, or use a standalone formatter like Prettier instead.

to directly state the reasoning and caveat, and let users do judge themselves (I think ESLint already says similar in a few places).

And as it how it reads, I use ESLint solely for formatting since day one, and I never had formatting/stylistic issues - even if I do have some nitch needs, I wrote plugins with I believe it's how ESLint is supposed to be used.
Finally, I would like to take this chance to say a big THANK YOU for making and maintaining ESLint and those rules. They literally improve my productivity every single day, and I can't imagine how to code without them. It's amazing!


Update mill version

This should fix the ClassCastException during release: https://github.com/com-lihaoyi/mill/issues/2749

Ok, I saw that you were already involved in discussions around this bug and that there are also downstream issues with SCIP.
I'll close this overly naive PR 😉


[BUG:] Navbar responsiveness issues on tab screen size and icon clickability

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
There are several issues with the navbar's responsiveness and click functionality:

Button Overlap on Tab Screen Size: The buttons in the navbar overlap when viewed on a tab-sized screen, affecting readability and usability.

Non-Clickable Icons: The icons in front of each button in the navbar are not clickable. Currently, only the text of the buttons is clickable, making it difficult for users to navigate via the icons.

Expected Behavior: The navbar should adjust its layout to prevent button overlap on tab screen sizes, and both the icons and the text should be clickable to improve the user experience.

Please address these issues to enhance the overall responsiveness and usability of the navbar.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please assign this issue to me under gssoc-extd


32603- Borrow transaction Failed

[](url

)

The abow error messege I received while borrowing
603: Internal Error - Error: The account aurora wouldn't have enough balance to cover storage, required to have<PHONE_NUMBER>20912403006 yoctoNEAR more. Please report a bug at https://github.com/aurora-is-near/aurora-relayer/issues

Hi @Alfexclancy, can you try again?

The same issues for me,
Internal Error - Error: The account  wouldn't have enough balance to cover storage, required to have<PHONE_NUMBER>3678743274908 yoctoNEAR more. Please report a bug at https://github.com/aurora-is-near/aurora-relayer/issues

Hi @luffyvnx , @Alfexclancy. Are you still encountering this issue?


New Artemis Logo not clearly recognizable in Light Mode

Describe the bug
In Chrome's light mode, the white part of the Artemis logo at the top blends completely into the background (as shown in the screenshot)
To Reproduce

Open Artemis in Chrome (Light mode)
Select the Artemis tab at the top
See that the background color of the tab and the light color of the Artemis logo are the same

Expected behavior
Maybe you could add a different color (like an Offwhite that is different from the browser white) for the light mode or set the logo against a darker background.
Screenshots

What browsers are you seeing the problem on?
Chrome
Additional context
No response
Relevant log output
No response

Same issue in Safari

And in Firefox (Only if the tab is selected):


add julials

Closes #143.
Some considerations:

The symbol cache will automatically be downloaded at the discretion of SymbolServer.jl. The upstream URL will be the default one. VSCode allows disabling this mechanism through settings.
There's no error handler provided to runserver(), I'm not sure what the implications of this are.
The Julia environment will be selected by the following logic:   something(
          maybe_dirname(Base.current_project(pwd())),
          maybe_dirname(Base.load_path_expand("@v#.#"))
    )

The VSCode extension uses the same logic, but it also allow you to change environments pretty easily in the UI (uses the custom julia/activateenvironment/julia/refreshLanguageServer commands under the hood).

Ok so, as for my comment to #143, the logic to select a Julia environment doesn't seem to work as expected (it returns nothing).
I'm gonna try fixing it today.

My bad. It turned out to be working as expected.

I just removed my changes which are no longer needed and formatted the script to a "Julia style": https://github.com/williamboman/nvim-lsp-installer/pull/432


Is it possible to configure different setting with a mediaquery

I would like to have hamburger menu on a mobile site than on a tablet or desktop. Is there a way to configure hamburgers for such cases? I guess my question is similar to https://github.com/jonsuh/hamburgers/issues/63, but I was not sure.
Thanks!

Hey there staeff, for this you would use a media query.
See - https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries
For example:
`
.hamburger-menu { // Allow menu to be shown initially on mobiles
display: block;
}
@media all and (min-width: 767px) { // Hide for tablets
.hamburger-menu { display: none; }
}
'


Win10: ImportError: DLL load failed: The specified module could not be found

Hello,
I'm trying to install PyAv:

I downloaded FFmpeg dev version
I installed requirements with pip
I built last PyAV version with 'python setup.py build --ffmpeg-dir="..."'
and finally I installed with 'python setup.py install --ffmpeg-dir="..."'

but when I try to import av I have this error:

import av
Traceback (most recent call last):
File "", line 1, in
File "C:\Program Files\Python36\lib\site-packages\av-6.1.3.dev0-py3.6-win-amd64.egg\av_init_.py", line 9, in
from av._core import time_base, pyav_version as version
ImportError: DLL load failed: The specified module could not be found.

Do you know what I did wrong ?

If you installed FFmpeg in some unusual location you'll need to help PyAV find it at runtime. Can you try adding the directory where the .dll lives to your PATH and try again to import av?

No response from submitter, closing.

How does one find the correct .dll? I am having trouble finding the right directory and file name.

I had the same error, I could fix it with pip install av==9.1.0

I had the same error, I could fix it with pip install av==9.1.0

That's a different issue, see #952


Fix no library files in pypi package version

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   88.05%   88.05%
=======================================
  Files           2        2
  Lines         134      134
  Branches       26       26
=======================================
  Hits          118      118
  Misses          5        5
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b9dcb...ab83a97. Read the comment docs.


Please delete my acccount

Please delete my account as I no longer require it. My username is lewiswatson.
Thank you.

same here if possible -- rlchu -- thanks :)


tkinter missing

Where is the best place to get tkinter?

tkinter should ship with python3 by default, as it is part of the standard library. Try to upgrade and use the newest version of python.


[T4A5][T09-A3]Francis Cheng

Ready for review.

@francischeng070
Some comments added. Please ack & close the PR after reading comments.

ack


Katholiek Onderwijs Vlaanderen

@feelitloveit Thank you for the request! This domain is registered for Flemish Secretariat for Catholic Education, and the website says that the domain belongs to an umbrella institution, which consists of many colleges, schools and other organizations. Do I understand the structure correctly?

@philipto  correct.

@feelitloveit This repository is for universities and colleges only, not for other types of institutions. Is it possible to add to this repository separate email domains for particular schools which need JetBrains tools for their educational activity?


[e2e]: generic push main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2794035905
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Thu Aug  4 03:56:10 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2801186157
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Fri Aug  5 04:07:54 UTC 2022
Tests are passing now. Closing this issue.


fix Notifications blocking items not visually under them from being interacted with

fixes #847
Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>

I think the integration test failure is a real issue. This is what I see when running those manually.

This is really weird. It seems like the follow css was the "reason" why the tests were failing:
#app {
  > * {
    height: inherit;
  }
}

Namely, once I put it back they started to pass locally.


Make some features (signature, sharing) that depend on multi_user responsive to whether it's turned on or off

I think we might want some Python functions to check for a valid SMS and email configuration.
I think we'll need to audit the default interview text to look for places we offer the ability to send by email or SMS and conditionally turn those off. In most places we allow both methods, and in some there's a backup method of clicking a link to copy text, so we probably don't want to turn these totally off in the footer.

I've made some progress on hiding SMS specific options downstream in MLH on just the Share page, trying to get it upstream now.
The places where I see we offer SMS sending that I've address in my branch:

[x] In the Share page
[ ] In the reminder system
[ ] the option to text the signature

I'm gonna focus on just those at the moment, since the email stuff seems to be in more places and more critical to running a DA server (with password resets, etc.)

Reopening, as I didn't cover things that have multi_user = False yet. I feel like there are a few approaches we could take to those interviews:

turn things off entirely
give users the ability to manually turn it on and off
automatically turn it on when some one shares the signature screen, and turns it off once the form is signed (or some other type of control)

Reopening, as I didn't cover things that have multi_user = False yet. I feel like there are a few approaches we could take to those interviews:
* turn things off entirely

* give users the ability to manually turn it on and off

* automatically turn it on when some one shares the signature screen, and turns it off once the form is signed (or some other type of control)

I think we'll want to go with your first idea, turn sharing off entirely when multi_user=False. This is because it will usually only be the case when the author has to follow some data privacy liability standard, such as storing PII like a social security number or bank account number. Likely they'll have their data controls in a written policy that they have to maintain and certify that they're following. Making it up to the user to turn off doesn't sound like a good idea.
For signature to your phone, it would still work if the user is logged in, it's just a pain to use in that scenario.