remote site settings helper page

Thought this might help for anyone looking to do an automatic creation of a remote site setting for sfdc to sfdc communication.

Fantastic contribution, thank you! Could you update the README with a section describing the component and maybe a screenshot of it in action?

Want to take a quick look now @afawcett ?

Looks great, though did you intended to leave the image URL set to the DLRS graph image? Maybe need a new attribute on your component for this? Also would it be ok if you made your component and page names lower case, and perhaps removed the underscores from the component attribute names (in favour of using mixed case, with leading lower case character instead). I realise probably should have some submission guidelines that state this my bad. After these tweeks,i think it will be ready to merge. Do you plan on doing a blog or other promotion on the feature? If not, no worries, i will for sure be singing its praises with full credit to yourself of course! Thanks again for such a great submission!

Hey @afawcett ,
I think I've got everything you were asking for. I had a really long day so forgive me if I messed something up. :)
As far as a blog post goes, I hadn't planned anything because my blog needs a major overhaul before I start to put "good" content on it...; but I suppose it's a good idea. Feel free to announce any which way you deem fit. :)
I'm just trying to get my dreamforce session submissions in on time. I've got some sweet stuff I hope I get to show off.
Thanks!

@afawcett did you want to take another look at this?

Nice looking good, can you just update the demo screenshot of the component and its all good! :+1:

It is referencing where it will be. The image just isn't in your repo yet. Is github smart enough to fix the image paths during the merging of a pull request?

Merged, thanks again, tweeted my thanks for this, great job!

Thanks! Appreciate the merge!


Since 04.2017 good friday is work free holiday in Hungary

Hi, Since 14.04.2017 Good Friday is work-free holiday in Hungary
http://hungarytoday.hu/news/official-good-friday-voted-become-hungarys-eleventh-public-holiday-89938
Can you add it?

yup, it's possible. I'll add it ASAP, thanks for the opened issue

merged

fixed and available in the v1.3.0 release


Conducting sanity checks on Testground by performing similar tests on Knuu and comparing the results

All big-block-workstream experiments were carried out on the testground platform, and results were generated using that backend. Some concerns have arisen regarding aspects of the gathered data, such as the occurrence of duplicate gossiped block parts between peers, which appears inconsistent with the expected behavior of the consensus reactor. Therefore, it would be beneficial to perform sanity checks using an alternative backend, specifically Knuu, to compare the results, including network throughput, and verify that there are no significant discrepancies.

I'm closing this in favor of the issue is app https://github.com/celestiaorg/celestia-app/issues/3147

This one had already been added in the other issue https://github.com/celestiaorg/celestia-app/issues/3147 as a bonus

We can additionally or as the next step address https://github.com/celestiaorg/celestia-core/issues/1262.

Now that it is closed, would be good to move its content to that issue.


Rename README to README.md

for markdown

closing as subset of https://github.com/mlcommons/algorithmic-efficiency/pull/327


Lint

I added back the linting rules from the original repo and followed the ESLint guide to setup each project.

Cool that the tests are running in github actions 👍
Maybe we can add another action to lint the files too with nx affected --target=test (?)

Nice thanks! Doing some additional setup atm for the docs in the Github actions, will add nx affected --target=lint to it.


html is statically generated through the server api and redirected when accessed through a browser

Environment

Operating System: Darwin
Node Version:     v16.20.1
Nuxt Version:     3.6.5
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      devtools, modules, vite, srcDir, app, router
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-agc8n9?file=package.json
Describe the bug
After the project is deployed and the interface /nuxt-demo/api/generate/detail is called, a static html file is generated and saved to disk. When I access this html in my browser, it gets redirected to the /detail/base route, which seems to be handled by the vue-router, is there any way not to redirect it?
Additional context
No response
Logs
No response

You can work around this by unsetting/deleting nuxtApp.payload.path in a server-only plugin.


Turn tree-sitter on by default

Switch useTreeSitterParsers on by default.
Failing test suites:

[x] atom core
[x] autocomplete-plus
[x] autocomplete-html

[x] https://github.com/tree-sitter/tree-sitter/pull/197
[x] https://github.com/atom/autocomplete-html/pull/88
[x] https://github.com/atom/autocomplete-html/pull/89

[x] bracket-matcher

[x] https://github.com/atom/bracket-matcher/pull/358

[x] markdown-preview

[x] https://github.com/atom/markdown-preview/pull/548

[x] link

https://github.com/atom/link/commit/cce1438f5365d28838f1bed4b4730df395e779c8

[x] snippets

Closes #17810

What an incredible accomplishment! Years of work of tireless tenacity went into making this possible. You should be really proud.


chore(master): release 0.20.0

:robot: I have created a release beep boop
0.20.0 (2023-12-01)
Features

update authz subject (89295cd)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/indykite/indykite-sdk-go/releases/tag/v0.20.0 :sunflower:


Enhancement : Set color of Viewpager header and toolbar using dominant color of image

Like some Android apps, say for example Whatsapp, the color is set based on the dominant colors of the image,  like the profile picture in Whatsapp profile Info.
I've achieved this by creating an interface between MaterialViewPager and MaterialViewPagerImageHeader and by passing the bitmap from imageviewheader to Palette support library by google.

Yes it's possible with the Palette :+1:
The developpers can do it but I don't think all the projects have to do it, the best would be to just create a Gist as free open-source code

In that case I think setting a callback for when them image is loaded exposing the imageview could be helpful, because right now I've manually set it up using Picasso's callback

Yes, that'll be a good option. I'll add it into the next release ;)
Le 16 juin 2015 23:38, "idragon81"<EMAIL_ADDRESS>a écrit :

In that case I think setting a callback for when them image is loaded
exposing the imageview could be helpful, because right now I've manually
set it up using Picasso's callback
—
Reply to this email directly or view it on GitHub
https://github.com/florent37/MaterialViewPager/issues/82#issuecomment-112576440
.

Thanks buddy,
Appreciate your work. Great library BTW 👍


Sanitize DbsUrl and remove trailing slash character

Impact of the new feature
Any WMCore service not relying on DbsApi client
Is your feature request related to a problem? Please describe.
As we migrated to the Go-based DBSServer in testbed, a new issue has been exposed where DBS calls like
/dbs/int/global/DBSReader//serverinfo

not longer work because that resource is now in a new location, e.g.:
/dbs/int/global/DBSReader/serverinfo

That means, we need to make sure that the correct url is constructed in WMCore.
Describe the solution you'd like
In order to avoid url constructions with double slash (see example above), we should sanitize the DbsUrl and strip an ending slash after DBSReader or DBSWriter.
First place is in the WMSpec factory, when validating and accepting workflow arguments:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMSpec/StdSpecs/StdBase.py#L1032
Second place is in the MicroServices, when using the pycurl module or anything different than DBS3Reader or DbsApi
Third place is in global/local workqueue (since it might be processing old workflows with possibly a trailing slash).
And any other place where DBSServer calls are made.
Describe alternatives you've considered
To enable follow redirect in the HTTP python library that we are using, however, it would double our HTTP calls and would not work for HTTP methods different than GET.
Additional context
Similar to this: https://github.com/dmwm/DBSClient/issues/55

@justinasr Hi Justinas, could you please confirm whether McM (and any other machinery that creates requests in ReqMgr2) is defining the DbsUrl without a trailing slash? So this:
https://cmsweb-prod.cern.ch/dbs/prod/global/DBSReader

instead of:
https://cmsweb-prod.cern.ch/dbs/prod/global/DBSReader/

?


Show enabled extensions only in the extension viewlet

Hope that the default extension list only shows the active plugin.

VSCode Version: latest
OS Version: OS X 10.11.5

Can I work on this if gonzofish is not working on it anymore?

Give him a bit more time.

That's a nice feature! (ping)

Looks like this issue can be closed.

Hi @joaomoreno, perhaps you could close this issue. This feature has been released.


Add Hooks on Actions

examples :
pre
post
onComplete
onError

for now, SimpleAction should be sufficient for most use cases.


Text Input word boundaries are inconvenient (unexpected Ctrl+Backspace behavior)

When working with path strings, I frequently use Ctrl+Backspace to remove a node from the path. However, in all the input widgets, the word boundaries are inconsistent with the convention of \ being a word boundary. So instead of removing a node (usually), it removes the entire path.
eg C:\Data\my\data (Ctrl+Backspace) ->
instead of the expected  C:\Data\my\data (Ctrl+Backspace) -> C:\Data\my\

I agree, I'm not sure how much control I have there, since Imgui takes care of that, but I will have a look.

Yeah, this is the logic, I don't think there is currently a way to customize it.

Looks like the imgui issue was fixed! Now it's a matter of waiting for a release and updating deps here?


Logger setup no longer sets the root log level to debug

logger = logging.getLogger()
logger.setLevel(logging.DEBUG)

Will return the root logger for the python language server, and set the default log level to debug. This change configures a new logger for the plugin and leaves the debug level at the default level.

thank you!

thank you!


Continue updating the Apple backend

some ideas we can try to improve the apple backend

[ ] in the WWDC 2023 "Use Core ML Tools for machine learning model compression", https://developer.apple.com/wwdc23/10047, Apple folks claimed that Apple's new quantization scheme could help reduce inference latency

Apple used that to convert Stable Diffusion models, see https://github.com/apple/ml-stable-diffusion

[ ] some models definitely still have room for improvement, e.g.,

the MobileDet was converted with freedom's quick-and-dirty script, and
the MobileBERT could be improved by referring to Apple's Transformer on Neural Engine guide, https://machinelearning.apple.com/research/neural-engine-transformers

@freedomtan  for further improvements should we use the saved models from your repo (MobileBert, MobileDet)? Or we can use some models from the TensorFlow hub (At least for MobileBert model: https://tfhub.dev/google/mobilebert/uncased_L-24_H-128_B-512_A-4_F-4_OPT/1). As I see the saved models are with tf 1 version.

@freedomtan for further improvements should we use the saved models from your repo (MobileBert, MobileDet)? Or we can use some models from the TensorFlow hub (At least for MobileBert model: https://tfhub.dev/tensorflow/mobilebert_en_uncased_L-24_H-128_B-512_A-4_F-4_OPT). As I see the saved models are with tf 1 version. However in new model the inputs are different than ours.

I am not proud of my repo :-)
For MobileBERT: whatever we do, it should be compatible (and mathematically equivalent) with what Google colleagues contribulted at https://github.com/mlcommons/mobile_open/tree/main/language/bert.
For MobileDet: see https://github.com/mlcommons/mobile_open/tree/main/vision/mobilenet
We should check the accuracies of models.
As far as I can tell the https://tfhub.dev/tensorflow/mobilebert_en_uncased_L-24_H-128_B-512_A-4_F-4_OPT is not for SQuAD (hence not compatible)

Hi guys! So I've converted the MobileBERT using the coreMLTools version 7, TensorFlow v 2.12 to the *.mlpackage format, as well, as optimised the model using quantization technique. Currently I have the problem to use the *.mlpackage format in our application. The problem arises when do on device compilation to receive the mlmodelc. I've tried to compile on the Mac itself and then use the compiled model, but then some issue with loading its content. So working to resolve this to see how accurate is the optimised model.
When working on the task I found such issues/possible improvements:

When do the on device model compilation we use some deprecated method, which compile the model synchronously. There are alternatives which uses async methods or method with the callback. So would be good to revise this. The problem here  is that app expects configured CoreMLExecutor after init.
flutter has some issues while debugging on the device with iOS 17. (So can't debug directly), some patches exists, but the recommended in the doc flutter version is not the official one, and can't be updated, maybe we can revise this as well, and try to update the flutter to latest, at least it will be easier to maintain in future.

Hi guys! So I've converted the MobileBERT using the coreMLTools version 7, TensorFlow v 2.12 to the *.mlpackage format, as well, as optimised the model using quantization technique. Currently I have the problem to use the *.mlpackage format in our application. The problem arises when do on device compilation to receive the mlmodelc. I've tried to compile on the Mac itself and then use the compiled model, but then some issue with loading its content. So working to resolve this to see how accurate is the optimised model.
When working on the task I found such issues/possible improvements:

When do the on device model compilation we use some deprecated method, which compile the model synchronously. There are alternatives which uses async methods or method with the callback. So would be good to revise this. The problem here  is that app expects configured CoreMLExecutor after init.
flutter has some issues while debugging on the device with iOS 17. (So can't debug directly), some patches exists, but the recommended in the doc flutter version is not the official one, and can't be updated, maybe we can revise this as well, and try to update the flutter to latest, at least it will be easier to maintain in future.

@RSMNYS I don't really get what you ran into. From my past experiences, if we can make the //flutter/cpp/binary:main work on macOS, mostly the app will work on iOS.

@RSMNYS I don't really get what you ran into. From my past experiences, if we can make the //flutter/cpp/binary:main work on macOS, mostly the app will work on iOS.

The thing is it works for main (when doing tests), and it loads the ml program with no issues. But when trying in the app the error says can't read the spec. Will continue with this today.

Hi guys! Here are the results of the inferences by using the original MobileBERT (mlmodel) and the new converted models (mlpackage and optimized mlpackage). For the optimized one we used the default int8 quantized data type). As we can see the converted mlpackage has worse results than the original mlmodel. Need to check what could be the problem. As for the quantized model all seems correct as we used the lower precision for the data type (int8 and not float16)m that's why worse results.
MLPackage is the directory and not the single file. So to have the fingerprint for it we need to archive it. To correctly handle the archive with the mlpackage I've adjusted the archive_cached_helper. So now the app can load the mlpackage and do the inferences. Still have some difficulties with the model path after app restarts, because the logic returns only the path the archive's folder.
In our case we have: https://github.com/RSMNYS/mobile_models/raw/main/v3_0/CoreML/MobileBERT.zip. After download and unarchive the model is saved to ../raw/main/v3_0/CoreML/MobileBERT/MobileBERT.mlpackage. After app restart (app uses cached resources) he app returns this model_path: ../raw/main/v3_0/CoreML/MobileBERT, which is not correct. I think we can resolve this by introducing the new property to the pbtxt settings: model_name, so we can compose the model_path correctly and support models type which are not just single file, but package(directory). Please let's discuss.

@RSMNYS Please check model performance with Xcode Performance tab and/or Core ML Instruments first.

@RSMNYS Can you try rename ‘MobileBERT.zip’ to  ‘MobileBERT.mlpackage.zip’

@RSMNYS please share your forked repo or one the .mlpackage model.

https://github.com/RSMNYS/mobile_models/raw/main/v3_0/CoreML/MobileBERT.mlpackage.zip

@freedomtan here is the forked repo: https://github.com/RSMNYS/mobile_models/raw/main/v3_0/CoreML/MobileBERT.mlpackage.zip

Let's check something basic.

can you open the model you converted in Xcode and run it in the Performance tab as in Xcode Performance tab and/or Core ML Instruments? When I try to run your .mlpackage model, I got error messages. Mostly, there is something wrong.
I converted the .mlmodel I had at https://github.com/freedomtan/coreml_models_for_mlperf/tree/main/mobilebert to .mlpackage by opening in Xcode 15.0, clicking the "Edit" button, and then accepting the conversion. I got a model in .mlpackage. And running the model with CPU and ANE is roughly as good as running the .mlmodel one.

To me a model you cannot run and get performance report in the Performance tab must have something wrong.

@freedomtan  here is my test with the converted model:

Sometimes Xcode fails to create the report, but I believe this is the Xcode issue, because it shows me sometimes the wrong operating system, but in the result all is listed correctly.
Can you share the general tab for the converted model, the results, and version of the Xcode, please.

@RSMNYS I meant "CPU and ANE". "GPU and ANE" is the reason why your model is slower.

@freedomtan here is my test with the converted model:
Sometimes Xcode fails to create the report, but I believe this is the Xcode issue, because it shows me sometimes the wrong operating system, but in the result all is listed correctly.
Can you share the general tab for the converted model, the results, and version of the Xcode, please.

@freedomtan to post profiling results how old coreml model work on couple devices.

@freedomtan  I did some more testing with MobileBERT.mlpackage. I've set different precisions for the model: Float16, and Float32  and here are the results:
FLOAT16
All units: 8.33 ms  1900 operations on NE, 8 op on GPU
CPU: can't run
CPU & GPU: 31.45 ms - all operations run on GPU
CPU & NE: can't run
FLOAT32
All unit: 31.11 ms - all operations run on GPU only
CPU only: 69.25 ms
CPU & GPU: 30.7 ms - all operations run on GPU only
CPU & NE: 69.13 ms - all operations run on CPU ony
Also found this description: ML programs use a GPU runtime that is backed by the Metal Performance Shaders Graph framework. So could it be that mlpackage is optimised to perform the operations on the gpu (to utilise parallel execution). And since nlp models has the sequence nature, it's not so beneficial to run on gpu. (In terms of qps). We can check other models (vision) to see if the operations are faster in this case. Checking more.

@freedomtan I did some more testing with MobileBERT.mlpackage. I've set different precisions for the model: Float16, and Float32 and here are the results:
FLOAT16
All units: 8.33 ms 1900 operations on NE, 8 op on GPU CPU: can't run CPU & GPU: 31.45 ms - all operations run on GPU CPU & NE: can't run
FLOAT32
All unit: 31.11 ms - all operations run on GPU only CPU only: 69.25 ms CPU & GPU: 30.7 ms - all operations run on GPU only CPU & NE: 69.13 ms - all operations run on CPU ony
Also found this description: ML programs use a GPU runtime that is backed by the Metal Performance Shaders Graph framework. So could it be that mlpackage is optimised to perform the operations on the gpu (to utilise parallel execution). And since nlp models has the sequence nature, it's not so beneficial to run on gpu. (In terms of qps). We can check other models (vision) to see if the operations are faster in this case. Checking more.

@RSMNYS
The float16 and float32 results don't surprise me at all. As far as I know,
CPU: flp16, fp32 (and maybe bf16)
GPU: fp16, bf16, and float32
ANE: fp16.
I recommend

read https://machinelearning.apple.com/research/neural-engine-transformers,
watch https://developer.apple.com/videos/play/wwdc2023/10047/, and
read https://apple.github.io/coremltools/docs-guides/source/performance-impact.html

for .mlmodel and .mlpackage we discussed,

mlmodel
mlpackage

As you can see, running on GPU is slower.
With MIL program and netron, we can find what the 10 and 8 ops in mlmodel and mlpackage, respectively

mlmodel:

0: buffer conversion
1-3: the 2  nodes after 'segment_ids'
4-5: the  2 nodes after 'input_mask'
6-7: the 3 nodes after 'input_ids'
8-9: loadConst and the add after 3

mlpackage:

0-2: bufer conversion
3: the node after 'input_ids'
4: the gather after 'segment_ids' → cast, cast folded
5, 6 : the cast and reshape after 'input_mask'
7: the gather after 3, the expand_dims, cast folded

Maybe we can change mlprogram manually to check what stopped the 8 ops from running on CPU.


[FEATURE] Integrate LinkFree with Twitter lists

Description
Twitter lists is a feature that enables one to create a separate list of users and see their content. Basically, think about it as a custom social media timeline.
The idea 💡 here is to to programmatically create a Twitter list of LinkFree users who have their Twitter handle:

Preprocess the data that's already in the repo
Write code to add new people to the list as they add their profiles

Why?

Twitter visibility motivating people to contribute to LinkFree
Integrate EddieHub community on Twitter
Learn & geek out with the Twitter API

Screenshots
No response
Additional information
No response

I would Like to work on this feature

@thamerla

@Pradumnasaraf @eddiejaoude I would like to work on this feature, but this requires moderators or code owners consent for making "Twitter Developer's" Account on behalf of linktree
What should i do?

Thank you for your energy! I think we should wait a bit and discuss this, because some people may not want this, so it would need to be an opt in
Let's wait for others to share their thoughts on it.
In the meantime have a look at our NextJS branch in the LinkFree project as we are migrating to that and any help appreciated

@eddiejaoude Sure

I am going to close this because we don't want to integrate directly with Twitter just yet


Rename Symbol doesnt seem to work when using a screen reader

Learnings from NVAccess testing:
I typed in the new symbol name, but after pressing enter and reading the document again,  nothing changed.
Steps:

Open Visual studio code editor.
Open any file and create code to target a module, method,  function, classes, variables or any of the   intellisense completions under:   https://code.visualstudio.com/docs/editor/intellisense

3. Enable the   Intellisense by pressing "Ctrl+Spacebar" key.
4. Navigate through the different completions using keyboard and   observe behavior with assistive
5. Use F2 to "Rename Symbol" in one editor and observe   behavior in multiple editiors

Use F2 to "Rename Symbol" in one editor and observe behavior in multiple editiors

@auchenberg Can you be more concrete? What is your expected behaviour? I get this when renaming a symbol

ping @auchenberg

I'm waiting for more info from NVAccess, who tested this.

Please reopen with actionable information


basic tests added

Cannot run git clone on build servers:

exception "Cloning into 'C:\Users\VssAdministrator\AppData\Local\Temp\FIFA2018'..." was thrown
exception "Cloning into '/tmp/FIFA2018'..." was thrown


debug ci

(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #
(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)
Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

/pulsarbot rerun-failure-checks


fix(lexical): calculate range selection formatting

Description
Fix range selection formatting.
It looks like this bug is related to the format of our rangeSelection calculation. Here our calculation is not quite the same as the google doc. As an example:

In google doc. When we have three letters 1(italic) 2(bold) 3(underline), and we select them, the selection will show that the format is nothing at this time. Only when all textNodes have a format at the same time will the selection show that it has a format.

And in lexical, our logic is that as long as the anchorNode or focusNode has a certain style, we will show that selection.format has that style.

When we can calculate the selection range correctly, the problem mentioned in the issue does not exist anymore.

closes #2626
https://user-images.githubusercontent.com/22126563/178920657-20ba0a72-c574-4635-ab35-472c8fca2d1b.mov

Thank you for digging into this Luci! While I don't disagree with the new proposed heuristic, the root of the problem is hiding in the beforeInput behavior. Notice how it still behaves oddly when doing the reverse thing <bold>Hello</bold> world
Also, is this GDocs heuristic? Haven't played with it extensively but my hunch is that they're using the first node instead (that is focus when selection is reversed, anchor otherwise)

Based on your concern, I have tried the same on onenote and microsoft word, both of which have this logic. It doesn't seem to be unique to GDocs.
You can see that when the second row of 2 3 has the same formatting and the selection contains only 2 3, the selection shows their common formatting.
https://user-images.githubusercontent.com/22126563/178949099-08497b79-152a-4f62-8968-13e2016ab99a.mov
https://user-images.githubusercontent.com/22126563/178949174-6fe64068-f2e5-400e-94e1-b095e8573b99.mov

Notice how it still behaves oddly when doing the reverse thing <bold>Hello</bold> world

This actually seems like a logical result, and I've tried it on google doc and onenote as well as microsoft. The new text will inherit the style of the top textNode in the deleted text.
https://user-images.githubusercontent.com/22126563/178950840-03188825-1a6b-45b4-b191-84dab3a83e78.mov
https://user-images.githubusercontent.com/22126563/178951473-067e9b8e-5d0e-4de0-a1d2-5ba1de28d665.mov
https://user-images.githubusercontent.com/22126563/178951618-301e554d-0822-4097-9139-960097e57ad9.mov

I'm good with this - I don't see any issues at the moment. I do agree that this is an area we could probably optimize in the future.
Nice work and thanks again for the contribution!


Let use the keyboard to fine-tune a bounding box

Please add an ability to use the keyboard to move bounding box borders.
Let each border has a key combination assigned to it. For example for the left border, ctrl+shift+w for the top, ctrl+shift+x for the bottom border and ctrl+shift+d for the right one.
By pressing key combination and left/right or top/bottom arrows user can move the border in the left/right or top/bottom direction.

Hi @andrew-veresov ,
So far, it supports using arrow keyboard to move the selected bounding box. Does it not work in your environment?

Hi @tzutalin !
Yes it works. But it will be really great if LabelImg get an ability to resize a box via keyboard. May be an ability to simply increase/decrease height or width of a rectangle using a keyboard.

@andrew-veresov @lorenzob
I'm thinking that WASD would increase the bounding box size in the up/left/down/right direction, respectively... What should be the keyboard input for decreasing the box size? SHIFT + WASD?

My idea was this:

I move the mouse close to one corner (or border) and this corner is implicitly selected (no click required)
now WSAD moves that corner only (obviously keeping the rectangle squared)
as soon as you move the mouse pointer away from the corner the selection is canceled and WSAD moves the whole box (if the corner moves away from the mouse pointer it does not cancel the selection, you have to actually move the mouse again)

(this is how Darktable does fine tuning and it works well)
I think directly using WSAD is confusing. Usually W goes in one direction, S does the opposite. Here S moves a different element. If I moved a border too much I cannot simply "go back" as I'm used to do with the arrows keys.
SHIFT+WSAD also complicates things because you probably have one hand on the mouse and it is not so easy to use SHIFT+WSAD with one hand only. Also is not very natural to press SHIFT+D to go left.
Selecting the element with the mouse pointer takes a little time but I'm already using the mouse, probably I'm still very close to the box and by selecting one corner I can move two borders.
In general, I think that arrow keys should also act like WSAD for left-handed people.

I think that it's better to focus on moving edges not the corners. Usually when the need to shift an edge  appears you'are looking at the middle of an edge, not at the corner. This is cause most of the real life objects are not rectangular.
So, I think it will be easy if WSAD will move a corresponding edge. Yep it will affect two corners at a time. But it's exactly what I needed most of the time. In this case Shift+WSAD might move an edge in the opposite direction. And the mouse still could be used to select a rectangle.


Support underscore templates in "html.format.enable"

Versions

VSCode Version: Version 1.10.0-insider (1.10.0-insider)
OS Version: Mac OS X 10.12.3

Steps to Reproduce

Set "html.format.enable" to true.
Open the following index.html and format the file:

<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8">
  <% console.log('hello') %>
  <title>Login</title>
</head>
<body>
  <%
    // copy configs
    require('copy-loader!./foo.js');
  %>
  <script src="foo.js"></script>
</body>
</html>

What did I expect?
No changes.
What was the actual result?
<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8">
  <% console.log('hello') %>
    <title>Login</title>
</head>
<body>
  <%
    // copy configs
    require('copy-loader!./foo.js');
  %>
    <script src="foo.js"></script>
</body>
</html>

It looks like every tag after <% %> is indented by two spaces.
Why should this be changed?
Underscore templates within HTML are a common feature in solutions like html-webpack-plugin.

We're using http://jsbeautifier.org/ to format. You could file the issue there or look out for extensions that are giving full support to your template language.

Thank you so far. I've created https://github.com/beautify-web/js-beautify/issues/1130.


Publish SDK docs on gh_pages branch

what about using a 'docs/' on the master branch?  This could be generated during a release script, so things would stay in-sync and might be easier to maintain?

That's how it has been, but @grant pushed back on that for some reason.

I understand that it's a common thing for repo's to use gh_pages,  but it seems much more streamlined if the docs lived with the code,  at least from a users perspective.
If you are going to be having typescript types in the main branch,  then why not docs?

It's also pretty common to have generated docs in /docs on master. It's the default option in the repo settings. I'm not sure what the concern is tbh - I just thought it was a minor thing to argue about. I want to set up a GH Action that generates the docs with each push to master. It should be pretty straightforward using something like https://github.com/crazy-max/ghaction-github-pages

It's common in git to not push generated files in master. Putting generated files makes searching worse, docs out of date, etc. For example, CSS files and font files shouldn't be in this repo.
Most top npm modules don't have generated docs, markdown is fine.

If you are going to be having typescript types in the main branch, then why not docs?

There are no typescript types files, assuming you're referring to .d.ts files. Only source code.

Re: generated files... unless you are volunteering to write the API documentation, I think we're going to go ahead and generate the docs

Generating docs on gh_pages SGTM as before.
Not sure what @lholmquist is suggesting.

i'm suggesting that you just use "docs/" on the main branch.

docs out of date

The docs only really get updated during a version release, and there already is a "release" script in the package.json,  it is pretty easy to just add the generate_docs script to that.


Rendering Jupyter notebooks by default when opening a Gist

Example: https://gist.github.com/danyalahmed247/cb6feecbfc0d342fdd070c803a2c33fb

This issue will be automatically solved when the Python extension adds a custom editor in Vs Code. So I’m going to close this as resolved, since there’s no work on GistPad here.


turn TCP_FASTOPEN back on if libcurl is new enough?

See https://github.com/JuliaLang/Downloads.jl/pull/76. For libcurl ≥ 7.74 it should be safe to turn on TCP_FASTOPEN even for FTP requests.

I do want to do this, but we're not using a recent enough libcurl for this to be fixed, so I'm still waiting on that so that a) will actually benefit from this and b) can test both code paths with different Julia versions.

Now that 7.74 has been out for a while, would it be worth setting TCP_FASTOPEN again?

Yeah, seems like we could, although it's a little unclear to me if it makes that much difference for downloads.


Import scala.collection.immutable._ explicitly is necessary for Term.Param

In order to create Term.Param user has to import scala.collection.immutable._ explicitly to macro annotation file.
Step to reproduce:
Try to create  Term.Param e.g.
 Term.Param(Seq(Mod.Implicit()), Term.Name("name"), None, None)
Scalac complains:
[error]  found   : Seq[scala.meta.Type.Name]
 [error]  required: scala.collection.immutable.Seq[scala.meta.Type.Name]

This is fixed in 2.0.0-M1, where all collections are actually lists.


DatabaseClientImplTest is flaky

  Error:  Errors:  Error:    DatabaseClientImplTest.testDatabaseOrInstanceDoesNotExistOnCreate:3034 » InstanceNotFound NOT_FOUND: The session pool has been invalidated because a previous RPC returned 'Database not found': NOT_FOUND: com.google.api.gax.rpc.NotFoundException: io.grpc.StatusRuntimeException: NOT_FOUND: Instance not found: Instance with id projects/my-project/instances/my-instance not found

Fixed in latest commit


[tsec-http4s] Allow customizing what happens on auth failure

Currently an auth failure results in a 401 response. It can sometimes be useful to instead redirect to some form of login page. This is not possible out of the box, but can be achieved by mapping over the result.
A customization option to allow for changing the failure case would be nice to have.
Maybe something like
// in SecuredRequestHandler
def liftService(service: TSecAuthService[F, User, Auth], fallback: => Response[F]): HttpService[F] =
  defaultMiddleware(service).handleError(_ => fallback))

Re: on gitter, :+1: to a PR for this.

I had a quick stab at this, but then I got distracted and never got back to it. Sorry :)


custom styling causing drag between line in incorrect position

Describe the bug
A clear and concise description of what the bug is.

when rendering item using the renderItem props, the dragbetweenline component is off the position

To Reproduce
Steps to reproduce the behavior:

render item using renderItem and add vertical padding to the component
when drag one of the items over the nested list, see the dragbetweenline component is off position

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS] macOs
Browser [e.g. chrome, safari] chrome
Version [e.g. 22] Version 120.0.6099.129 (Official Build) (arm64)

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

i'm currently using fixed position with some calculation to overcome this issue

It looks like the drag line just expands downward from the center between the items by the height of the line. If possible, you should be able to just move the line up with CSS by the fixed amount that the line has in height. For example, in the sample style, the line has a height of 4px, and is moved back up by css by 2px to recenter it.

I have the same issue essentially. my nodes don't have consistent height. and it seems to plot the spaces for them based on the hard coded height @--rct-item-height
this makes the drag and drop unstable very frustrating as I've put a lot of time setting this up for my use case and added the dynamically displayed elements as a last action I figured would be fast. but I was mistaken. my bad for not testing all functionality before moving forward. this is such a great library though!

Hi Austin, yes, RCT doesn't currently support elements of varying heights at the moment. Thank you very much for your contribution in the linked PR, I left some comments on your proposed changes.


Icon refresh

:warning: Don't merge yet. Still needs legal clearance.
Replaces the Atom icon with a "Yosemite" version. Issue #3923
Current

New "Yosemite" version

In context

The new version doesn't necessarily need to have the white border etc. Makes it fit in, but it might seem too close to a stock app from Apple? /cc @cameronmcefee

[x] Mac
[x] File icons
[x] Win
[x] Linux

Looks amazing.

Another thing to think about.. should the Win and Linux version be different?

I think using the same icon is fine, GitHub for Windows and GitHub for Mac use the same icon.

:+1: lookin great! @simurai have you tried increasing the stroke ever so slightly?? The icon itself seems little thin next to the thick white border.

It would be nice to fit into the metro aesthetic as well. Windows seems to have a super flat, single-color app icons (in the 'start' menu anyway). I dont know all the possibilities for windows, so maybe the icon on the desktop would be the same, but anywhere the metro look is used, IMO, we should go that route.

Of course, that can be done in a separate pull, just responding to:

should the Win and Linux version be different

@benogle You generally only single-color outline icons if they are Metro apps - even the built-in desktop apps have color:

We have the :+1: to move forward re IP. Carry on, and thanks for postponing.

Oh, also please ping me when you have finalized assets so I can do the necessary documenting.

@paulcbetts noted

@paulcbetts @benogle @kevinsawicki For this PR we could have the same icon everywhere and then as a seperate PR look into adding a "metro" tile: http://msdn.microsoft.com/en-us/library/windows/apps/hh465403.aspx#default_tiles But not sure how to add that to Atom's build script. It probably needs to be a separate file (+ manifest?) and not part of the current atom.ico.

@simurai Metro tiles only apply to Metro apps, Atom's would look different; there is no way to have a "metro-only" icon for a Desktop app. But really, it's fiiiiiiiine - just use this icon everywhere, it looks great!

@paulcbetts Ok, I see. Thanks.

@jeejkang Do you still have the original icon in vector format? I used this SVG file to create all the different sizes.

For the 3 smallest sizes, the thickness is increased a bit, but the rest is just scaled based on that SVG. I can increase it for the others too. It might also appear thinner because the new one has a dark drop-shadow instead of a glow?

@simurai I uploaded the Atom file in this temporary Dropbox folder. Please let me know if you have any trouble opening the file.

Note to self if it becomes an issue: Used Icon Slate to create the Windows atom.ico file. For some reason it moves the 256px version to the end and in the finder it shows up as a 128px file. The reason might be to fix an XP issue. From this comment:

Just a note about Windows XP compatibility: If you reuse the icon as window icon, then note that this can crash your application if you use a compressed 256 icon. The solution is to either not compress the icon or create a second version without the (compressed) 256 icon.

Ok, here all icons in an overview:
Mac

Windows

Linux

Maybe a last point of discussion: The smallest size (+ 2x) of the file icon is filled with green instead of the circle in the middle. Because it's so small, you wouldn't really recognize the white part anyways.

If nobody hates it, I'll ping the legal gatekeepers for a last check.

:+1:

It looks amazing! I really like the green file icons!

Looks great @simurai. There shouldn't be any legal issues with this change since it doesn't modify the logo itself.

@talniv can you confirm these changes before we merge this PR? Thanks.

:+1:

This will :ship: in 0.169, thanks @simurai

Awesome!! :)

awesome work @simurai!! I :green_heart: the green folder direction.

@timgthomas made a good point on twitter:

@AtomEditor I love it visually, but doesn’t it clash with OS X’s metaphors? Circles for consuming content, tilted rectangles for producing?

I wasn't aware but now when looking at my dock I totally see it. An argument to use the circle is to stay as close as possible to the previous one, so that people still feel it's the same. But I don't mind doing another round with a square version. Maybe as part of the 1.0 launch.

Maybe as part of the 1.0 launch.

:+1: That's my vote if you choose to change again.

:+1: I love it.

This just popped up on my dock today and looks great. Nice work @simurai!

@benogle would something like this work?
https://github.com/atom/atom/pull/3089#issuecomment-50837759

@ParkerK Are you asking if it's possible to have a "metro" icon on Windows? Since this PR is already merged, do you mind creating a new issue about it.


Filter invocation in View Pages

View Pages need to run the following filters as part of the request pipeline:

Resource
Auth
Exception
PageExecution

Addressed via https://github.com/aspnet/Mvc/commit/a7abdeabcd561f82ba78cf9149a8e8b7719f2b88.


Problems with parameter substitution

There are problems with parameter substitution in the following file:
module prim_subreg #(
  parameter logic [31:0] RESVAL   = '0
) ();
endmodule

module prim_subreg_shadow #(
  parameter logic [31:0] RESVAL   = '0
) ();

  prim_subreg #(
    .RESVAL(~RESVAL)
  ) staged_reg();

endmodule

The output uhdm:
slpp_all/surelog.uhdm: Restored design Pre-Elab:
design: (work@prim_subreg_shadow)
|vpiName:work@prim_subreg_shadow
|uhdmallModules:
\_module: work@prim_subreg (work@prim_subreg) prim_subreg_simpler.sv:1:1: , endln:4:10, parent:work@prim_subreg_shadow
  |vpiDefName:work@prim_subreg
  |vpiFullName:work@prim_subreg
  |vpiParamAssign:
  \_param_assign: , line:2:26, endln:2:39, parent:work@prim_subreg
    |vpiRhs:
    \_constant: , line:2:37, endln:2:39
      |vpiConstType:3
      |vpiDecompile:'0
      |vpiSize:-1
      |BIN:0
    |vpiLhs:
    \_parameter: (work@prim_subreg.RESVAL), line:2:26, endln:2:39, parent:work@prim_subreg
      |vpiName:RESVAL
<EMAIL_ADDRESS>      |BIN:0
      |vpiTypespec:
      \_logic_typespec: (RESVAL), line:2:13, endln:2:18<EMAIL_ADDRESS>        |vpiName:RESVAL
        |vpiRange:
        \_range: , line:2:20, endln:2:24
          |vpiLeftRange:
          \_constant: , line:2:20, endln:2:22
            |vpiConstType:9
            |vpiDecompile:31
            |vpiSize:64
            |UINT:31
          |vpiRightRange:
          \_constant: , line:2:23, endln:2:24
            |vpiConstType:9
            |vpiDecompile:0
            |vpiSize:64
            |UINT:0
  |vpiParameter:
  \_parameter: (work@prim_subreg.RESVAL), line:2:26, endln:2:39, parent:work@prim_subreg
|uhdmallModules:
\_module: work@prim_subreg_shadow (work@prim_subreg_shadow) prim_subreg_simpler.sv:6:1: , endln:14:10, parent:work@prim_subreg_shadow
  |vpiDefName:work@prim_subreg_shadow
  |vpiFullName:work@prim_subreg_shadow
  |vpiParamAssign:
  \_param_assign: , line:7:26, endln:7:39, parent:work@prim_subreg_shadow
    |vpiRhs:
    \_constant: , line:7:37, endln:7:39
      |vpiConstType:3
      |vpiDecompile:'0
      |vpiSize:-1
      |BIN:0
    |vpiLhs:
    \_parameter: (work@prim_subreg_shadow.RESVAL), line:7:26, endln:7:39, parent:work@prim_subreg_shadow
      |vpiName:RESVAL
<EMAIL_ADDRESS>      |BIN:0
      |vpiTypespec:
      \_logic_typespec: (RESVAL), line:7:13, endln:7:18<EMAIL_ADDRESS>        |vpiName:RESVAL
        |vpiRange:
        \_range: , line:7:20, endln:7:24
          |vpiLeftRange:
          \_constant: , line:7:20, endln:7:22
            |vpiConstType:9
            |vpiDecompile:31
            |vpiSize:64
            |UINT:31
          |vpiRightRange:
          \_constant: , line:7:23, endln:7:24
            |vpiConstType:9
            |vpiDecompile:0
            |vpiSize:64
            |UINT:0
  |vpiParameter:
  \_parameter: (work@prim_subreg_shadow.RESVAL), line:7:26, endln:7:39, parent:work@prim_subreg_shadow
|uhdmtopModules:
\_module: work@prim_subreg_shadow (work@prim_subreg_shadow) prim_subreg_simpler.sv:6:1: , endln:14:10
  |vpiDefName:work@prim_subreg_shadow
  |vpiName:work@prim_subreg_shadow
  |vpiModule:
  \_module: work@prim_subreg <EMAIL_ADDRESS>prim_subreg_simpler.sv:10:3: , endln:12:18, parent:work@prim_subreg_shadow
    |vpiDefName:work@prim_subreg
    |vpiDefFile:prim_subreg_simpler.sv
    |vpiDefLineNo:1
    |vpiName:staged_reg
<EMAIL_ADDRESS>    |vpiInstance:
    \_module: work@prim_subreg_shadow (work@prim_subreg_shadow) prim_subreg_simpler.sv:6:1: , endln:14:10
    |vpiParamAssign:
    \_param_assign: , line:2:26, endln:2:39<EMAIL_ADDRESS>      |vpiRhs:
      \_constant: , line:2:37, endln:2:39
        |vpiConstType:9
        |vpiDecompile:18446744073709551615
        |vpiSize:64
        |UINT:18446744073709551615
      |vpiLhs:
      \_parameter: (work@prim_subreg_shadow.staged_reg.RESVAL), line:2:26, endln:2:39<EMAIL_ADDRESS>        |vpiName:RESVAL
<EMAIL_ADDRESS>        |BIN:0
        |vpiTypespec:
        \_logic_typespec: (RESVAL), line:2:13, endln:2:18<EMAIL_ADDRESS>          |vpiName:RESVAL
          |vpiRange:
          \_range: , line:2:20, endln:2:24, parent:RESVAL
            |vpiLeftRange:
            \_constant: , line:2:20, endln:2:22
              |vpiConstType:9
              |vpiDecompile:31
              |vpiSize:64
              |UINT:31
            |vpiRightRange:
            \_constant: , line:2:23, endln:2:24
              |vpiConstType:9
              |vpiDecompile:0
              |vpiSize:64
              |UINT:0
    |vpiParameter:
    \_parameter: (work@prim_subreg_shadow.staged_reg.RESVAL), line:2:26, endln:2:39<EMAIL_ADDRESS>  |vpiParamAssign:
  \_param_assign: , line:7:26, endln:7:39, parent:work@prim_subreg_shadow
    |vpiRhs:
    \_constant: , line:7:37, endln:7:39
      |vpiConstType:9
      |vpiDecompile:0
      |vpiSize:65535
      |UINT:0
    |vpiLhs:
    \_parameter: (work@prim_subreg_shadow.RESVAL), line:7:26, endln:7:39, parent:work@prim_subreg_shadow
      |vpiName:RESVAL
<EMAIL_ADDRESS>      |BIN:0
      |vpiTypespec:
      \_logic_typespec: (RESVAL), line:7:13, endln:7:18<EMAIL_ADDRESS>        |vpiName:RESVAL
        |vpiRange:
        \_range: , line:7:20, endln:7:24, parent:RESVAL
          |vpiLeftRange:
          \_constant: , line:7:20, endln:7:22
            |vpiConstType:9
            |vpiDecompile:31
            |vpiSize:64
            |UINT:31
          |vpiRightRange:
          \_constant: , line:7:23, endln:7:24
            |vpiConstType:9
            |vpiDecompile:0
            |vpiSize:64
            |UINT:0
  |vpiParameter:
  \_parameter: (work@prim_subreg_shadow.RESVAL), line:7:26, endln:7:39, parent:work@prim_subreg_shadow

There are problems with sizes in uhdmtopModules. In first param assign node it have vpiSize = 64, the second time it has size 65535. In uhdmallModules the size of that parameter is correct (-1).
--disable-feature=parametersubstitution option doesn't work. The output uhdm trees are the same regardless of that flag was used.
I think that line numbers in that subtree under param_assign: , line:2:26, endln:2:39<EMAIL_ADDRESS>are wrong.
I think it should point to line 11. I'm not sure about the convention, but that assignment is caused by line 11 and I think this line number would be more helpful in debugging.

Fixed by #1681

Now there is no problem with sizes, but there is problem with values. In first param_assign node in uhdmtopModules it should be '1 or something like negation of '0. In the second param_assign node it should be '0 instead of 0.
What about points 2. and 3.? Are they bugs or not?

If you run this in a commercial simulator:
module prim_subreg #(
  parameter logic [63:0] RESVAL   = '0)();
  initial $display("RESVAL:%d", RESVAL);

endmodule

module prim_subreg_shadow #(
  parameter logic [63:0] RESVAL   = '0
) ();

  prim_subreg #(
    .RESVAL(~RESVAL)
  ) staged_reg();

endmodule

You'll see the output is:
RESVAL:18446744073709551615 (Not 1 as you mention, but Surelog's output).
Note that Surelog does not do lhs-rhs word matching, so it always resolve to a 64 bit value when the size is not specified.
This is the bitwize inversion operator you are using, maybe you are mistaking it with the Boolean ! operator?
So, no there is no problem with the values.
"In the second param_assign node it should be '0 instead of 0": At that point, the value went through evaluation and is now in canonical form, so the ' was dropped as it would happen for other prefixes like 'h, 'b. This is cosmetic and in no way impact the analysis down the line. The size is maintained to -1.
#2, this parameter expansion option is limited to a very specific use case that does not apply here. I was against naming this option using a generic name when it was created, I knew it would create confusion for the users, please work with @kamilrakoczy on either changing the name or the help
#3 That is not a bug, nor a deviation of the standard (There is no standard for this) but a long project to implement.


Correct mailcheck preference for .org domains

WHAT
Correct mailcheck preference for .org domains

Jenkins isn’t building this because it’s a PR from a fork, not a PR from a branch within the same repo.
Created PR #407, which is a branch within this repo containing @soniaturcotte’s commit.


Azure Container registry

We will need a container registry to pull images of the instance from.
It is possible to create a new container registry through the dashboard and attach it to the InvenioRDM-Dev service by selecting Attach registry => Create new.
Are we okay to do so @cc-a ?
Can I also confirm that the domain we will deploy to is http://invenio.rcs.ic.ac.uk/ ?

The current workflow publishes the docker image to the github container registry - https://github.com/ImperialCollegeLondon/fair-data-repository/pkgs/container/fair-data-repository. I've now made the repository and the image publicly available so I believe it is suitable for use.
Not totally sure about the domain... In the short term I assume we can deploy to a *.azure.com subdomain.

Okay, that's grand @cc-a
It's not clear to me however how to procure a *.azure.com domain. I've done some searching on their documentation but not yet found that. Do you know?
It seems to me that we need that for the ingress controller to work.

This guide seems to cover things - https://learn.microsoft.com/en-us/azure/aks/ingress-tls?tabs=azure-cli. I've created a public IP in the resource group that you can use -<EMAIL_ADDRESS>


functional tests: GC containers before removing temp directory

Now that the overlay fs is not mounted in a separate mount namespace
mounts will stay in host's mount namespace and to unmount them we need
to run the GC. Tests were failing because we tried to remove the
temp directory with a mounted filesystem inside.
This commit runs the GC before removing the temp directory.

/cc @eyakubovich

To repeat what I've told on IRC - it is not entirely correct. Right now when you call ctx.cleanup() it will call rkt gc three times - once with --dir parameter set to datadir (correct), once set to system config dir (useless) and once set to local config dir (also useless).

Closing in favor of #1119


Works well in AngularJS but not in Angular 6

I'm trying to implement  single sign on from an AngularJS project to an Angular 6 project. In Angular 6 I used npm install xdlocalstorage which added your starter project to my node modules but I couldn't get a reference to your xlLocalStoragage.js using import nor could I add a script reference.  Not sure if this is an issue but appreciate your help.
Thanks.
Stephen Vajda

Hey @StephenVajda are you still having this issue? I'm considering this, but my project is in Angular 7.

Thanks but don't remember the issue. everything working. Steve

From: "Jacky Choo"<EMAIL_ADDRESS>Sent: Monday, May 20, 2019 11:45 PM
To: "ofirdagan/cross-domain-local-storage"<EMAIL_ADDRESS>Cc: "Stephen G Vajda"<EMAIL_ADDRESS>"Mention"<EMAIL_ADDRESS>Subject: Re: [ofirdagan/cross-domain-local-storage] Works well in AngularJS but not in Angular 6 (#36)
Hey @StephenVajda are you still having this issue? I'm considering this, but my project is in Angular 7.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Bug: incoming DMs will not appear without a refresh of the page

There is no polling or anything yet/

also, if new DMs come in, the inReplyTo field should get updated to keep the thread consistent.


We need to show important information on the claim page

We have some bullet points of important info we need to show to users on the claim page in the rewards center.
This info can change with legal guidance, but currently:

Cross chain payments need to be claimed within 28 days of being earned
Cross-Chain payment IOUTokens are not transferable

Let's cover this one as well: https://github.com/MetricsDAO/xyz/issues/721
Feature request: Warn users to only use self-custodial wallets #721
"This is a feature request to recreate the "Don't use CEX wallets, only self custody ones" warning from the Notion submission form (legacy stack) in the app.
I am not an analyst on the app and cannot confirm what the analysts currently see when claiming rewards, but an analyst shared in Discord that they didn't see a warning like this.: https://discord.com/channels/902943676685230100/903338987022876702/1101553171127603220"

@catscatscode

Let me know if the placement of the warnings makes sense and feel free to edit the copy.
https://www.figma.com/file/66Myyf1MVmY8UKv7BrVUa5/MDAO-App-Designs?node-id=6716%3A18598&t=4El9u1UBlvL6Zu6k-1

Updated rewards warning text to also surface on the individual rewards when is approaches expiration.


Error in web console when using HMR

Bug Report
Is this a regression?

 Yes, the previous version in which this bug was not present was: 11.2.10
Description
An error appear in console when trying to use HMR from a new application (or old after ng update..) in angular 12. The error seems to be related to this webpack issue.

No, you can have the problem with an application created with the CLI with no router and css mode.
But sorry, i was not precise, it's in the web console, on Chrome Version 88.0.4324.150 (Official Build) (64-bit)
and Firefox 88.0.1.


[help wanted] How to parse decimal id in deliver receipt with leading zero

Hi,
Recently, SMSC which whom I integrate starts sending decimal id in deliver receipt with leading zero like this id:0221067780 sub:001 dlvrd:001 [...]. Based on example I wrote parsing logic, which use below snippet:
var longId = Long.parseLong(decimalIdFromReceipt)
var messageIdHex = Long.toString(longId, 16)

which obviously truncates leading zero on first line, parsing String to Long and fails matching with messageId from submit_sm_resp.
Is there any known better approach to parse messageId from deliver receipts ? Or maybe anyone knows how SMSC converts messageId into decimal representation, which I can invert on my side (assuming there is some well-known technic, not the custom one in each SMSC) ?
I know some deliver receipt's type can include messageId in optional parameter but as far I am concerned that SMSC does not support it...
Thanks for any tips in advance!

I had a similar problem. If the messageId in the delivery receipt is always 10 digits, you could use something like:
(The StringUtils is teh Apache Commons Lang3 library)
public static String messageIdIntToHex(final String messageId) {
final Long value = Long.valueOf(messageId);
if (value < 0L || value ><PHONE_NUMBER>775L) {
throw new NumberFormatException("Message ID " + messageId + " cannot be converted to hexadecimals string with length 8");
}
return StringUtils.leftPad(Long.toHexString(value).toUpperCase(), 10, "0");
}

Mine SMSC does not guarantee messageId will be always 10-digit value. For me the only way to solve such problem is to read messageId from optional parameters of a deliverSm - lucky, mine SMSC fills that parameter.


how to post json object [String:AnyObject]

How can i use below parameters in POST method as json encoded.
var params = [String:AnyObject]
var param1 = String:AnyObject
param["phoneNumber"] = "7777777"
param["firstName"] = "AA"
var param2 = String:AnyObject
param["phoneNumber"] = "88888"
param["firstName"] = "BBB"
params.append(param1)
params.append(param2)

Your code sample is too incorrect to tell what type of parameters you're actually trying to POST. Asking this question on StackOverflow with a full code sample and tagging Alamofire may provide you better answers.
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


Ignore hash links

Description
Validation of links to internal anchors was introduced to markdown-link-check in v3.10. Unfortunately this does not work with anchors created by HTML anchor tags, which is commonly used.
This change makes markdown-link-check ignore these links, which was the behaviour in previous versions.

@brikis98 @zackproser Any chance of merging this?

@endrec Thanks again for your contribution and your patience: https://github.com/gruntwork-io/pre-commit/releases/tag/v0.1.18


[remove-exec-depend] "-" not parsed in packages name

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
The regex here: https://github.com/autowarefoundation/autoware-github-actions/blob/9d8d2d8d1d0380c4a868c67c145051df4dacb048/remove-exec-depend/action.yaml#L9 doesn't match the character "-".
In the case of the autoware.universe repository, it leaves packages such as libqt5-widgets or python3-matplotlib as exec-depend.
It's not causing any problem at the moment, but it didn't look right.
Expected behavior
Remove all exec-depend.
Actual behavior
Some exec-depend are left.
Steps to reproduce
In autoware.universe, run the action command:
find . -name package.xml | xargs -I {} sed -i -rz "s|<exec_depend>\s*[a-zA-Z_0-9]+\s*</exec_depend>\n||g" {}

and grep for exec_depend:
grep -rn "<exec_depend>" $(find . -name package.xml)

Versions
No response
Possible causes
No response
Additional context
No response

Thank you for reporting this! :smile:
I'll link the background information of this action.
https://github.com/autowarefoundation/autoware.universe/issues/184
Since it's mainly to prevent dependency packages from unnecessarily increasing due to *_launch packages, as you say, there is no big problem right now.
But it seems easy to fix it, so I'll check it soon.

$ cd autoware.universe
$ find . -name package.xml | xargs -I {} sed -i -rz "s|<exec_depend>\s*[a-zA-Z0-9_-]+\s*</exec_depend>\n||g" {}
$ grep -rn "<exec_depend>" $(find . -name package.xml)
$ git reset --hard
$ find . -name package.xml | xargs -I {} sed -i -rz "s|<exec_depend>\s*[a-zA-Z0-9_]+\s*</exec_depend>\n||g" {}
$ grep -rn "<exec_depend>" $(find . -name package.xml)
./common/autoware_auto_perception_rviz_plugin/package.xml:20:  <exec_depend>libqt5-widgets</exec_depend>
./launch/tier4_integration_launch/package.xml:14:    <exec_depend>python3-bson</exec_depend>
./launch/tier4_integration_launch/package.xml:15:  <exec_depend>python3-tornado</exec_depend>
./vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/package.xml:28:  <exec_depend>python3-matplotlib</exec_depend>
./vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/package.xml:29:  <exec_depend>python3-pandas</exec_depend>
./vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/package.xml:30:  <exec_depend>python3-scipy</exec_depend>
./system/default_ad_api/package.xml:19:  <exec_depend>python3-flask</exec_depend>


Some corrections to the spanish translation.

PR Details

Description

Applied some corrections to the spanish translation (Needs to be improved)
Related Issue

Motivation and Context

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have built and run the editor to try this change out.

@dotnet-policy-service agree

Ahora las miro cuando pueda :)
Saludos!
🫡

Gracias por las sugerencias @Ethereal77
👍


Add input

For text field, text area and search field:

I found an issue with the label, help and validation text: The label and help/validation text should expand and be bound to the width of the field and could span multiple lines.

For text area:

The read-only state is missing the correct style.

For search field:

Icon color incorrect: prefx icon and icon in clear button are too dark -> there is a separate token for icons in formfields to use color-background-formfield-icon
Is there a reason why you used type=text instead of type=search?

done

Looking at the functional part, what seems to be missing from the requirements is:

All user-facing text must be translatable (including "required" and "optional"), including text to be read by assistive technology.

✅

A required field should be able to be defined to show or hide the "required" denotation.

Text Field:

Possibility to define a maximum and/or a minimum value that is valid is missing. Values not matching set the field to invalid. So for example if the max. value is set to "10" and the user enters "12", it's invalid.

✅

Text Area:

A text area can be set to have a fixed height (= minimum height) or to auto-expand vertically to fit the text until a defined max. height (rows).
It can be set to be vertically (not horizontally) resizable (default: no resizing).
minHeight and maxHeight can be set. allowResize can be set

Search Field:

The prefix icon can be defined and taken from all icons available in grape-icons via the Icon component. It needs to be customizable for different usages of the search field component.

✅

We need to discuss if we want to use a container for every single field to define the size as individual fields inside forms will vary in length corresponding to the expected text input. @AleshaOleg What are your thoughts on this?


fix(portal): hide application subscriptions when user have not the ri…

Replace https://github.com/gravitee-io/old-gravitee-api-management/pull/367
Issue
https://github.com/gravitee-io/issues/issues/6021
Description
Improve user rights management for application
Application submenu change with role permission
ex :

Additional context

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of the Element Zero team's environment.

✅  Approved! (I can't officially approved because I create the new PR)


Websites to try

https://github.com/ebidel/polymer-gmail
https://www.pubnub.com/blog/2015-01-15-creating-a-polymer-chat-app-with-material-design/
https://github.com/google/santa-tracker-web

Do we want to work with polymer then?
On Wed, Mar 22, 2017 at 11:33 AM, David Crawford<EMAIL_ADDRESS>wrote:

https://github.com/ebidel/polymer-gmail
https://www.pubnub.com/blog/2015-01-15-creating-a-polymer-
chat-app-with-material-design/
https://github.com/google/santa-tracker-web
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DavidAldon/SignalR-Project/issues/1, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AXPwF8-uzg1j5cpgjDTqKNCHyr33XwV2ks5roT82gaJpZM4MlYu-
.

Or Apache Cordova if we go the tinder clone route

This tutorial is amazing and I have a working app running in a simulator currently
https://ccoenraets.github.io/cordova-tutorial/index.html
Working on getting another sample project working...

Look at this....this is hilarious...
https://software.intel.com/en-us/html5/hub/blogs/how-to-make-a-mobile-virtual-pet-game-with-html5-and-cordova/

That's last one is pretty cool haha

They both work correctly, so we could currently do something with the puzzle or the pet thing


[Feature][Module Name] how to support flink1.14 ?

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Problem Description
how to support flink1.14 ?
Description
No response
Use case
No response
Solutions
No response
Anything else
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

You can change the flink engine dependencies and build your own version.

I'm afraid this alone won't do. The flink1.2 and 1.4 apis have changed a lot

提供最新版DataSphereStudio全家桶安装服务。
包括（DataSphereStudio, Linkis, Exchangeis(Datax, Sqoop), Scriptis, Streamis(Flink), Visualis, DolphinScheduler)

另外包含 元数据，数据安全，数据质量，数据血缘。（这些都是DataSphereStudio不自带的服务）
包含hadoop集群搭建（hive, spark, flink, kafak, kylin）
提供上述所有系统二次定制开发服务
提供系统搭建运维疑难问题解决

添加备注，DSS大数据
持续为DataSphereStudio开源贡献力量


Detect pod and service CIDR from manifests

Temporary apiserver should use service CIDR detected from kube-apiserver.yaml
Temporary controller-manager should use pod CIDR detected from kube-controller-manager.yaml
Eliminates the need to coordniation btw render and start and unblocks pod/service CIDR customization

Full discussion about why we're taking this approach over others: https://github.com/kubernetes-incubator/bootkube/issues/236#issuecomment-279797787
related. #236
Edge cases
Missing assets:
$ bootkube start --asset-dir=empty
Can't detect --service-cluster-ip-range in manifests/kube-apiserver.yaml, using <IP_ADDRESS>/24: open empty/manifests/kube-apiserver.yaml: no such file or directory
Can't detect --cluster-cidr in manifests/kube-controller-manager.yaml, using <IP_ADDRESS>/24: open empty/manifests/kube-controller-manager.yaml: no such file or directory
Running temporary bootstrap control plane...

We can introduce error handling to bootkube if you are ok with it being done here.

Yeah I'm fine if the makeXFlags functions returned an error (and NewBootkube already returns error).

I don't have further changes. I'll implement render options in a followup PR.

@dghubble overall this lgtm. Unfortunately the PR tests are currently not working - have you manually verified this works?

Rebased for v1.5.3.

@aaronlevy, I spoke with @pbx0. Tests seem to be running, just not updating the status on Github and this is considered a CI pass. https://jenkins-tectonic.prod.coreos.systems/job/bootkube-dev/314
2017-02-17T21:10:24Z kola: --- PASS: bootkube.destruct.delete on gce (406.458s)
2017-02-17T21:10:43Z kola: --- PASS: bootkube.smoke on gce (423.244s)
2017-02-17T21:12:58Z kola: --- FAIL: bootkube.experimentaletcd.smoke on gce (556.723s)
2017-02-17T21:14:16Z kola: --- PASS: bootkube.destruct.reboot on gce (632.535s)

The etcd experimental failures are on master.

code lgtm. @aaronlevy cool to merge or are we blocked on the etcd test?

I believe self-hosted etcd isn't working right now - so I'm fine to merge.


Removing an operation with mv command does not remove the operation

Proposed changes
Issue:
Removing an operation file using the mv command does not remove it from the list.
The reason for this is when a file is moved, then the file modified event gets generated and this will be considered as an add operation and tries to access the file and fails to read the file instead of removing the operation from the list.
Proposed solution:
So, the proposed solution is when a file is modified and a modified/Add event is generated, and if the operation file does not exist then remove the operation from the list.
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue
https://github.com/thin-edge/thin-edge.io/issues/1974#:~:text=Removing an operation with mv command does not remove the operation %231974
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Removing an operation file using the mv command does not remove it from the list.
The reason for this is when a file is moved, then the file modified event gets generated and this will be considered as an add operation and tries to access the file and fails to read the file instead of removing the operation from the list.

I don't understand the issue. Do you mean that the Remove event is not sent to the mapper? If so, what needs to be fix is the |inotify support.

Yes, when a file is removed from the /etc/tedge/operations/c8y directory using the mv command, the Remove/delete event is not sent to the mapper, instead modified event is generated, and sent to the mapper.

Removing an operation file using the mv command does not remove it from the list.
The reason for this is when a file is moved, then the file modified event gets generated and this will be considered as an add operation and tries to access the file and fails to read the file instead of removing the operation from the list.

I don't understand the issue. Do you mean that the Remove event is not sent to the mapper? If so, what needs to be fix is the |inotify support.

Do you mean to say that we need to fix it in our fs notify wrapper library or the actual notify crate?

Yes, when a file is removed from the /etc/tedge/operations/c8y directory using the mv command, the Remove/delete event is not sent to the mapper, instead modified event is generated, and sent to the mapper.

How about a simpler approach where we don't differentiate between Add/Remove/Modified events separately but instead always reload the contents of the operations dir whenever any update happens on that directory? This prevents the operations_by_trigger map from diverging from the reality on the file system. I don't think the cost of regenerating the map by reading the whole directory content instead of selectively adding or removing from the existing map is a big deal here as adding/removing operations is such a rare operation.

For me, it makes sense as there will not be many operations to be loaded and the change is not that frequent. @reubenmiller  @didier-wenzek  what do you guys think about Albin's suggestion?


Manual firing now invokes callback

Did a bit of code-housekeeping and introduced jshint, so the build will fail unless the code is well written :) Also introduced an additional test for manual fire.

Thanks @tomazzaman I'll take a look this weekend.

By the way, I've also written a tutorial on using Oubounce with WordPress:

Damn, nice PR. Thanks @tomazzaman.
Let me add your tutorial to the README too :smile:

Thanks, glad I could help :)


Add an end-to-end test for ThinLTO (-lto=llvm-thin flag), fix compiler crashes

Add lit.cfg support to add the right path to the just-built LTO library on Darwin
Add an end-to-end ThinLTO test
Fix discovered compiler crash 1: ThinLTO probihits unnamed global variables, let's name them all. This part of the PR is authored by @gottesmm, thx!!!
Fix discovered compiler crash 2: Stop marking llvm.used as disableAddressSanitizer, which causes ThinLTO's global variable merging logic to fail, and it's not really needed to let's stop doing that. (At first I considered this a bug in the merging logic, but on a second thought, it's highly unusual to reference llvm.used from any other variables/metadata that I actually think it's a mistake on the swiftc side to do that.)

@kubamracek I talked with compnerd offline. I explained my concern was that LLVM doesn't have a convention around this so we should have some sort of names-acing. I think what they wanted was for us to follow a true namespace. So maybe instead .swiftrestofname -> .swift.restofname.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - a55d18bed741977111070d2d1481fdafecb6d3e2

Build failed
Swift Test OS X Platform
Git Sha - a55d18bed741977111070d2d1481fdafecb6d3e2

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - e7377173b2724181d2d80aace38421118f2e2a43

@swift-ci please test

@compnerd I finally resurrected this PR, and got all the tests to pass. Could I ask for a review ? :)

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 509f5c8c0e51f70e5ac8415b14c5676344581c55

@swift-ci please test Linux platform

@swift-ci please test

@compnerd looks good now?

@swift-ci please test


Use memcached or Redis instead of DB

I suggest to have opportunity use memcached or Redis instead of DB. Add a new
settings CAPTCHA_BACKEND to point backend. By default it is DB as now.

Original issue reported on code.google.com by a.vostrjakov on 27 Mar 2011 at 4:30

Attaching a heavy patch to implement two backends: DB (like it works now) and
Django cache. This patch also included my previous patch from
http://code.google.com/p/django-simple-captcha/issues/detail?id=46

All backends functionality is in backends folder. Only small comment: because
memcached and others has 'expired' functionality included I don't implement it
in my cache backend.

由a.vostrjakov2011年3月28日12:20发表原始评论
附件：

captcha_backends.diff

captcha_backends.diff has gone, how to download it?


refactor(cli): new --in-place/--no-in-place option to the export-dynamic-plugin CLI command to allow exporting to dist-dynamic (when value is false).

Add an --in-place option (true by default) to the Janus-idp/cli export-dynamic-plugin command for frontend plugins.
When setting this option to false (with the --no-in-place sibling option), the export would generate the dynamic frontend plugin package (including the scalprum assets) as a derived package in the dist-dynamic subfolder, whose name would be suffixed by -dynamic.
This is important to:

have the same export experience and flow with both frontend and backend plugins
avoid pushing to NPMJS packages whose size is much bigger, just because of all the static Javascript files added in the dist-scalprum folder.

Background
It should be possible to run the export-dynamic-plugin CLI command directly on normal & typical backstage static frontend plugin without having to change its source.
With the current behavior, there is still the requirement to update the source package.json in order to add the dist-scalprum folder in the dist field. This is required to include the dist-scalprum assets when packaging the dynamic plugin.
Using this new --no-in-place CLI option will allow exporting a distinct package.json with the dist-scalprum folder added in the files field without changing the code of the original frontend plugin.
Signed-off-by: David Festal<EMAIL_ADDRESS>

/approve
/lgtm


Update master with the powershell hack

Fixed #1871
Adds the powershell hack in while we wait for the powershell team to merge/deploy the fix.

Pull Request Test Coverage Report for Build 59092

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.008%

Totals

Change from base Build 59025:
0.0%

Covered Lines:
4008

Relevant Lines:
6072

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll


No exported member 'ActivateRoute'. Does this works with RC4?

websitefrontend/node_modules/ng2-meta/dist/meta.service.d.ts:2:18
Module
websitefrontend/node_modules/@angular/router/index"' has no exported member 'ActivatedRoute'.

Hi,
RC4 is supported. Can you please make sure you're using the right version (the version of @angular/router specified in your app's package.json<EMAIL_ADDRESS>npm update, etc)?

Hey @UooVeee, I have just tested this with RC4 and wasn't able to reproduce your issue. So it should a matter of configuration as @vinaygopinath suggests...


Add config validate

Pull Request (PR) description
Add config validate
This Pull Request (PR) fixes the following issues
Fixes #84

the CI looks good, but, apart from any other observation/objection, I want to test this change onto my real servers, and I can try to remove ruby from my VM.

for the sake of sharing: I uninstalled ruby, I removed puppet from the PATH, I ran: /opt/puppetlabs/puppet/bin/puppet agent -t and it failed as following:
Error: Execution of '/usr/local/bin/config_validate.rb /etc/nomad.d/config.json20230424-3227133-172987x' returned 127: /usr/bin/env: 'ruby': No such file or directory

It's good to have multiple options.


Update Legacy Lexers

The dmd, rest, sml, snobol4, taskpaper, vcard, and yaml lexers are all in the
legacy lexer format. They should be updated to the new, object format. See
https://orbitalquark.github.io/scintillua/api.html#migrating-legacy-lexers

All lexers except rest have been migrated.

rest has been migrated.


automated system tests

We should have some integration / full-system tests. A few things to cover, vaguely in order of priority

basic weave * command execution. Designed to catch silly mistakes we may make in the weave script. Which has happened. Single node suffices.

weave network testing. This does require multiple notes. Most basic scenario is firing up two containers across hosts and making sure they can ping each other. But ultimately we should have tests for all weave features. We also need to include some qualitative performance tests, to catch things like forgetting to run ethtool and hence ending up with a working but abysmally performing network.

weavedns testing. ditto.

kernel versions. Would be good to test all the above across different kernel versions so we get alerted when we inadvertently introduce functionality that depends on specific kernels. We've been caught out by this already.

docker versions. ditto.

library versions. We should have tests that check our code works with the latest version of the various libs we depend on. We have been caught out by this. See also #228.

I see this specific issue as an umbrella for ideas; testing tends to be an open-ended issue where we can always come up with ideas for improvement. So let's record them here and then split out "actionable" pieces into their own issues.
Also, note that this issue is not about CI.

It occurs to me that we could test all kinds of weave functionality by running a bunch of weave router containers on the same machine. This is lightweight - allowing us to simulate large(ish) networks and iterate quickly through different configurations.
Things like connection handling, topology, gossip can be tested that way. Basically anything that doesn't actually require capturing/injecting packets. We could test most of the IP assignment too that way though would have to simulate the request/release.
Local iptable rules could simulate various network topologies and failures. We could have a generator for overlay topologies, i.e. a bunch of peers and the possible connectivity between them (tcp, udp one way, udp the other). Translate that into iptable rules.

My experience of testing distributed systems is that most of the work is in testing failure conditions (and that any recovery happens as expected).  These tend to involve timeouts.  So to test with adequate coverage, you need to be able to test with simulated time.  (Bryan did mention that he has already done something like this in the tests for the new gossip protocol.)
If we are doing thorough testing, I'd strongly recommend investing effort in that direction.  I.e., simulate the network and time, and run multiple instances of weave (or some subset of its components) within a single process.
At the other end of the spectrum, we have the smoke tests.  We should continue to enhance these, because they are a full system test, including the shell script.  But I expect they will always be "wide but shallow".

Also, note that this issue is not about CI.

#397 is.


vcpkg and unresolved external DirectX::Mouse::SetWindow

Does this lib work with vcpkg ? I get unresolved DirectX::Mouse::SetWindow(struct ABI::Windows::UI::Core::ICoreWindow *)

I don't maintain the vcpkg version, so I'm not sure what release it is. That said, are you sure you are building the right platform version? It looks like you want the UWP version?
Note I do maintain NuGet packages. See releases.

I think the issue is beyond vcpkg. I figured. The code in mouse.h has to be changed as follows:
#if (defined(WINAPI_FAMILY) && (WINAPI_FAMILY == WINAPI_FAMILY_APP)) || (defined(_XBOX_ONE) && defined(_TITLE) && (_XDK_VER >= 0x42D907D1))
void __cdecl SetWindow(ABI::Windows::UI::Core::ICoreWindow* window);
to
void __cdecl SetWindow(ABI::Windows::UI::Core::ICoreWindow* window)
{
impl->SetWindow(window);
}
#ifdef __cplusplus_winrt
    void __cdecl SetWindow(Windows::UI::Core::CoreWindow^ window)
    {
        // See https://msdn.microsoft.com/en-us/library/hh755802.aspx
        SetWindow(reinterpret_cast<ABI::Windows::UI::Core::ICoreWindow*>(window));
    }
#endif

Are you using C++/CX (/ZW) or C++/WinRT?

I am using C++/WinRT - and this the problem. Looking at the code C++/CX might be ok as it has the inline function.
#ifdef __cplusplus_winrt
void __cdecl SetWindow(Windows::UI::Core::CoreWindow^ window)
{
// See https://msdn.microsoft.com/en-us/library/hh755802.aspx
        SetWindow(reinterpret_cast<ABI::Windows::UI::Core::ICoreWindow*>(window));
    }

#endi

So the magic incantation you want is:
mouse->SetWindow(reinterpret_cast<ABI::Windows::UI::Core::ICoreWindow*>(static_cast<::IUnknown*>(winrt::get_abi(window))));

I'll see if I can make a more intuitive helper for C++/WinRT scenarios.

I add a helper for C++/WinRT in [this commit]](https://github.com/Microsoft/DirectXTK/commit/92ead37be90e3bead8f8850b0ab791071e5a8aa8) and updated the wiki.

Actually, get_abi already returns void* so you don't have to worry about the double-cast. Just do:
mouse->SetWindow(reinterpret_cast<ABI::Windows::UI::Core::ICoreWindow*>(winrt::get_abi(window)));


when I run ‘sealer run registry.cn-qingdao.aliyuncs.com/sealer-io/kubernetes:v1.20.15-test’, the tigera-operator didn't run

What happen?
when I run ‘sealer run registry.cn-qingdao.aliyuncs.com/sealer-io/kubernetes:v1.20.15-test’, the tigera-operator didn't run.

the log of tigera-operator:

the nodes are not ready:

the svc :

we found that the kube-proxy is not running:

we found that it is bacause of the podSecurityPolicy:

and we deleted enable-admission-plugins:

but some pods still did not running:

it is mainly baccause Back-off pulling image "sea.hub:5000/sealer/lvscare:v1.1.3-beta.8":

Relevant log output?
No response
What you expected to happen?
Fix the images registry.cn-qingdao.aliyuncs.com/sealer-io/kubernetes:v1.20.15-test,and after sealer run the nodes are ready
How to reproduce it (as minimally and precisely as possible)?
No response
Anything else we need to know?
No response
What is the version of Sealer you using?
No response
What is your OS environment?
Ubuntu 20.04
What is the Kernel version?
Linux VM-12-6-ubuntu 5.4.0-42-generic #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Other environment you want to tell us?

Cloud provider or hardware configuration:
Install tools:
Others:

#1768

@kakaZhou719 @Stevent-fei

The problem of "timeout" is derived from "PodSecurityPolicy".
@Stevent-fei @kakaZhou719 Is it enabled by default? Maybe we need to remove the option or add some proper "PodSecurityPolicy".

already build latest official cluster image: https://github.com/sealerio/sealer#user-guide


'kivy==master' on Android '@run_on_ui_thread' ignored

Software Versions

Python: 3.8
OS: Android
Kivy: master
Kivy installation method: Buildozer

Describe the bug
Unexpected error message with kivy==master, on Android
No error with kivy==2.0.0
01-03 16:13:55.840  3163  3163 I python  :  TypeError: Cannot create graphics instruction outside the main Kivy thread
Occurs on the last line of this fragment:
   # Run on UI thread because required by Kivy canvas
    @run_on_ui_thread
    def _update_canvas(self):
        tex = self._fbo.texture.get_region(*self.crop)
        self.canvas.clear()
        with self.canvas:
            Color(1,1,1,1)

@RobertFlatt use mainthread instead because @run_on_ui_thread is for the android native widgets like Toast i guess
from kivy.clock import mainthread
@run_on_ui_thread
def _update_canvas(self):
   tex = self._fbo.texture.get_region(*self.crop)
   self.canvas.clear()
   with self.canvas:
        Color(1,1,1,1)

This is android only code. Using run_on_ui_thread is required. I tried mainthread and Jnius complains with essentially the same message.
I don't think this is a functional issue in terms of the thread used. Simply a too sensitive error message, recently introduced.

@RobertFlatt from both your code and error it is not an android only code, it is a purely Kivy

The code sample is executed on an Android device. And to execute it is required to use run_on_ui_thread, else Jnius reports an error.
run_on_ui_thread is a documented api https://github.com/kivy/python-for-android/blob/develop/doc/source/apis.rst#runnable where is says:
**use our decorator**:
from android.runnable import run_on_ui_thread
@run_on_ui_thread

The error message test has been modified since 2.0.0 and is erroneous in the case of run_on_ui_thread.

@RobertFlatt Use @mainthread decorator, if you get any errors post it. It will help to diagnose the issue very well

My apologies.
I created a new test with @mainthread and kivy==master and there is no message from Jnius.
Clearly I messed up.


New policy: auto-close stale issues

As hinted already in the previous discussion (#15349), I want to formalize the experiment with the new policy: stale issues will be automatically closed. The closing will be automatically carried out by Stale bot.
Rationale: as long as the maintenance capacity is far beyond the demand (please read #14541) and there is not enough volunteers (#13861), the issues will continue to pile up. When that happens, it is demotivating for the team and for the potential contributors, not to mention the occassional uncalled-for drive-by comments.
What is the definition of stale? For our purpose, it means the lack of all these 3 things (as also stated in Reporting an Issue:

Detailed system info. Is a problem only on a certain OS? Which version? What's the environment?
Reproducing steps. We don't have our crystal ball, hard to replicate a problem not easily reproduced.
Case reduction. Saying PhantomJS doesn't work with website X is not sufficient.

The last one is important and yet it is often overlooked. It is not practical for the team behind PhantomJS to try to reduce the generic problem "PhantomJS does not work X" and to pinpoint it a very specific root cause (e.g. the website uses ES2017 features not supported yet by PhantomJS). Of course we do not expect a very detailed root cause analysis, however any meaningful initial steps in that direction will be immensely helpful. The WebKit project also has an explanation about this, read Test Case Reduction for more details.
I believe the above policy will help the triaging process and to make the whole issue handling slightly more humanly bearable.

Piling up issues is not the problem put prioritisation is. Closing legitimate issues due to lack of capacity is wrong. Please do not turn incompetent issue management into policy.

Working as expected.

I do understand the lack of contributers and issue piling up causing demotivation for the team or contributors, but auto-closing 1000+ items without reading them and determining priorities first ?!
We often check the number of opened issues before choosing an open source solution and here the number won't be representative anymore ..
Had opened #14445 in the past and had no workaround at the time.
Only workaround we finally found was to change to Chrome's recent Headless mode ..


MOT17 val metric

Hi,could you please provide the code to get  metrics on MOT val set? Current codes just write files in txt.

Hi @HanGuangXin, I used TrackEval for getting the metrics from created text files. For evaluation the validation set, you can put MOT17-valid.zip in TrackEval/data/gt/mot_challenge folder. Make sure to choose the correct paths and options in the TrackEval code. Good luck!

can you make the TrackEval to the zip include the text files. and send to my<EMAIL_ADDRESS>

Hi,could you please provide the code to get metrics on MOT val set? Current codes just write files in txt.

how you fix it,please


downagent.tar and downmonitor.tar error

Whitelabel Error Page
This application has no explicit mapping for /error, so you are seeing this as a fallback.
Fri Dec 21 11:36:36 CST 2018
There was an unexpected error (type=Internal Server Error, status=500).
Model has no value for key 'ngrinder_version'
Error while loading dependencies.txt
i can't find it.

could you build project and execute java -jar xxx.war or use external tomcat?
currently boot run is not work properly.

3Q


Fancy: Update to use PureComponent by default

Fancy: Update to use PureComponent by default

This update bumps Fancy to the latest version, which defaults to creating
PureComponent classes, which helps with performance.
Some minor adjustments were required for a couple of Message components,
mainly tests. This was good, as it revealed an implementation issue
with the ThemeProvider component.
A story was added for some manual testing of Message.context (just in case).
We'll minor bump this one!

Pull Request Test Coverage Report for Build 1365

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1362:
0.0%

Covered Lines:
5110

Relevant Lines:
5110

💛  - Coveralls


FirebaseRemoteConfig Unknown Error: 'long com.google.android.gms.internal.config.j.b()' on a null object reference

I received this error log in a FirebaseRemoteConfig.

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'long com.google.android.gms.internal.config.j.b()' on a null object reference
at com.google.android.gms.internal.config.zzan.run(Unknown Source)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:762)

The problem is I cant find a way to reproduce this error. But I'm sure this is FirebaseRemoteConfig error after I found the class "zzan" in the firebase-config library.
I tried to update the  gradle and plugin version but the error keeps showing in the crahslytics.
The libs:
implementation 'com.google.firebase:firebase-core:16.0.3'
implementation 'com.google.firebase:firebase-config:16.0.0'
implementation 'com.google.gms:google-services:4.0.1'
implementation 'com.google.android.gms:play-services-plus:15.0.1'
classpath 'com.android.tools.build:gradle:3.1.4'
classpath 'com.google.gms:google-services:4.0.1'
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip

@samtstern
It is our most occurring crash. By when can we expect this one to get fixed? Also, is there any work around to avoid this?
We are unable to reproduce it at our end. These are the logs from Crashlytics.
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'long com.google.android.gms.internal.config.j.b()' on a null object reference
       at com.google.android.gms.internal.config.zzan.run(Unknown Source)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
       at java.lang.Thread.run(Thread.java:818)


Anonymous invitations?

This is a placeholder PR for thinking through the use of user names and device names in the invitation process.
Context
I've been working on getting device invitations working on the taco-chat demo app.
Inviting a member and adding a device are both closely related, conceptually, and use the same internals.
When you invite a member, you provide their name (i.e. username or email), and you get an invitation code that will only work for someone who identifies themselves with that name.

I started implementing a similar UI for adding a device, but it feels cumbersome compared to WhatsApp, Keybase, or Signal, in part because I don't really want to have to know (or have to retype) a device name like Herb's iPhone 11 (2019) or DESKTOP-07A89.
Proposal
A couple of thoughts at this point:

We could just decouple names from the invitation process altogether - so I generate an invitation, and it can be used by anyone.
Like a Discord invite, maybe member invitations could be configured to be limited to N uses and/or have an expiration date.

Having a single invitation that can be used by multiple people would be less secure - you wouldn't want to do that in a high-risk context - but it would be considerably more convenient, and more than secure enough for most usage contexts.
A device invitation would just be a single-use, short-lived invitation but that could be used by any device.
When presenting one of these anonymous invitations, once it's accepted, the new member or new device would then identify itself, and the username or whatever could be stored on the chain in encrypted form - that way there wouldn't be any PID at all stored on the chain.

In many of these apps the device is able to "invite itself" - I can generate a code on my phone and show that to my laptop.
It occurs to me that it doesn't really matter which side generates the invitation code - right now the member generates a code and gives it to the invitee, but the process works exactly the same way if the invitee generates the code. So we could support that scenario pretty easily.

I'm really glad you're thinking about removing user names from the protocol, I think it improves flexibility for end user apps significantly. Are you familiar with SPAKE2 or CPace (used in magic wormhole)? Similar to what you said in the first point, they improve security of anonymous invitations by limiting the number of times you can accept the invite to 1. I think it's an elegant solution to the problem.

folded into #20