floating point exception in tf.nn.max_pool3d when value of ksize is too large.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.15
Custom code
No
OS platform and distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
floating point exception  in tf.nn.max_pool3d when value of ksize is too large, which will cause a crash. This crash occurs in the CPU execution environment.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1S9D9zdhknu9ReoPahd0_kw2OEuRxLAvB?usp=sharing

Relevant log output
Floating point exception (core dumped)

@xl1043237213,
It's not being killed because of TF. You are literally allocating so much memory that the OS is killing the process. It seems like you're giving large negative value for multiple arguments to the function. so due to Integer overflow to buffer overflow or due to insufficient memory (RAM), code is crashing or the process getting killed and I was able to replicate the issue on Google colab. Could you please specify the usecase where you are trying with the large ksize.
input:	A 5-D Tensor of the format specified by data_format.
ksize:	An int or list of ints that has length 1, 3 or 5. The size of the window for each dimension of the input tensor.
Thank you!

Thanks for your response. : )
I found the problem with a self-designed fuzzy testing tool, and have not yet found a relevant application scenario that requires setting ksize to such a large value. However, when the value of ksize is accessible to the user, packed in the model, it can cause the program to hang or even crash.

I was able to reproduce the issue on tensorflow v2.15 and v2.16. Kindly find the gist of it here.

Hi @xl1043237213,
Thanks for reporting this issue.
You can use keras.ops.max_pool API instead of tf.nn.max_pool3d.
And you are giving ksize as a single integer but it should be a list or tuple of 5 elements corresponding to 3D input tensor. Attaching gist for your reference.


Multiple Machine Rendering

Hi! How can I configure it to render one project in a network?
I tried to create a API server on a machine, and when I started a render node, to look for the ip in another machine, I'm getting this error: connect ECONNREFUSED <IP_ADDRESS>:23234

Hello!
Seems like your render node tries to connect to a api server via ip <IP_ADDRESS>.
Can you somehow show how you are configured the rendernode and project ?

Hello, thanks for reply, I have solved it :)
The problem is that I was creating a http connection to serve the assets files. But it was configured like this:
var assets = [     { "type": "project", "name": "project.aepx",    "src": http://localhost:${port}/assets/${aepxfile}}, ];
So, the another machine was looking for http://<IP_ADDRESS>:23234/assets/nm.png
Now I changed the src to the IP of the machine running the API and the render node is able to downloading the assets.
Thanks

Wonderful!
Good luck 😃

Now, How can I use several machine to render a single project?
I created a custom render node like this:
var api = require('nexrender').api;
var renderer  = require('nexrender').renderer;

// Configure api connection
api.config({
    host: "localhost",
    port: 3000
});

// connect to api, fetch queued projects, and start rendering
api.get().then(function(results) {
    // iterate, find queued
    for (let project of results) {
        if (project.state === 'queued' || project.state === 'rendering') {
            return startRendering(project);
        }
    }
});

function startRendering(project) {
    var rendered = renderer.render('/Applications/Adobe\ After\ Effects\ CC\ 2015/aerender', project);
    rendered.then(function(project) {
        // apply some custom steps, upload to youtube from there, for example

        // and mark project as finished (updates api state, and triggers remote callbacks)
        project.finish();
    });
}

But it seems every machine is rendering on different output folders. What is the best way to configure the renders node to do it?
Thanks so much,
Your project is awesome!

Ok, so in theory what you need to know whether you want to render parts of the video
and then just glue them (in the editor, or via ffmpeg for example)
Or you want to render an image sequence (search for image sequence in AE), and then render all of those images with audio on top
For me first way is easier, however it gives some artifacts on place of "glueing" every 2 videos.
Anyway, for whatever way you choose, the key option to doing this, will be creating multiple projects, using same project file BUT, having startFrame and endFrame options set up:
Lets say first part (first project):
/* Common project model might look like this: */
{
    template: 'template1.aepx',
    composition: 'composition1',
    settings: {
        outputModule: 'h264',
        outputExt: 'mp4',
        startFrame: 0,
        endFrame: 542
    },
....

And second part (other project):
{
    template: 'template1.aepx',
    composition: 'composition1',
    settings: {
        outputModule: 'h264',
        outputExt: 'mp4',
        startFrame: 543,
        endFrame: 1028
    },
....

And so on.
This way you will be able to generate multiple different parts of the same project simultaneously, using either image sequence, or partial video rendering.

Hmm I'm thinking to use image sequence.
Do you think it is possible to configure nexrender to render in a single output folder? Initializing the renderer as Watch folder.
Because my project is about short videos. Today the rendering time is 50 seconds. But the idea is to render under 10s. So, I'm trying to find the best way to do it.

Hm, well
if your renderers are running on the same machine - then its easy
you can

start them from the same directory
setup environment variable RESULTS_DIR pointing to directory where you want it to be rendered
or doing stuff below:

based on your example, you can add custom stuff inside which will just move all the results to the particular directory manually

function startRendering(project) {
    var rendered = renderer.render('/Applications/Adobe\ After\ Effects\ CC\ 2015/aerender', project);
    rendered.then(function(project) {
        // apply some custom steps, upload to youtube from there, for example

        // and mark project as finished (updates api state, and triggers remote callbacks)
        project.finish();
    });
}

However if these are different machines, which makes sense, you should use any type of synchronizer for file system. It can be shared folder, it can be dropbox (not really good idea), it can be resilio sync or rsync, or uploading via http onto target machine (o_O), or any other stuff.
What you will be needed to do it just to push rendered files in the shared folder, and after a while it will be synced and will be lying on the target machine. Where you will just need to start new rendering(compositioning) from to turn image sequence into a video with audio
Basically thats it. As you see this functionality (resulted file sync, and multipart rendering) is not (yet) builtin inside nexrender, however it can kinda easily be achieved using any 3rd party tools


Essential UI/UX Screens - Calendar Screen

A detailed documentation or video demo  showing a calendar screen . You can also add one home page. Event apps, to-do list apps, and many others provide users with the personal calendar. Depending on the type of the application, calendar accomplishes certain functions such as reminding or schedule. The visual style should fit the mood and objectives of the mobile app.
You can take some ideas from dribble also .
Referrences:
Link 1
Note:
Folder Structure should be UI_UX/Essential_Screens/Calendar_Screen  & changes should be made to  UI_UX branch.
Issue only for GWOC'21 contributors.
Issue will be assigned on a first come first serve basis, 1 Issue == 1 PR.
In the PR, keep this issue's title as your PR's title.
Must Follow : Contributing Guidelines & Code of Conduct before start Contributing

Hey, I would like to work on this!

Hey, I would like to work on this!

Yes sure ! assigned.

Hey, I am willing to work on this issue.

Hey @Debasmita-01, I've created a PR  for the issue, please check it out and lemme know if there's anything else to be done.

/assign

Hi @Debasmita-01 can I work on this issue, please?

Hey, I would like to work on this issue. Can I?

Hey @Debasmita-01 Can I work on this with Video tutorial?


instructions for installing sbt on Linux break apt unless apt-transport-https is already installed

http://www.scala-sbt.org/0.13/docs/Installing-sbt-on-Linux.html
These instructions break apt unless apt-transport-https is already installed.
steps
echo "deb https://dl.bintray.com/sbt/debian /" | sudo tee -a /etc/apt/sources.list.d/sbt.list
problem
apt will no longer work unless apt-transport-https was already installed.
expectation
apt should continue to work as normal.
notes
Performing this step unconditionally before the provided instructions will fix the problem:
sudo apt-get install apt-transport-https

Thanks for the report. Could you share more details on the environment you're seeing this? Distro and version number etc.

Sure! Basically every standard Ubuntu cloud environment, such as c9, Codenvy, etc. These are typically 14.04.5 LTS.


Why SECRET_KEY is an error? Thanks

(venv) IGOR-3:django-classified-demo igor$ python manage.py runserver
Traceback (most recent call last):
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/environ/environ.py", line 273, in get_value
value = self.ENVIRON[var]
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/os.py", line 678, in getitem
raise KeyError(key) from None
KeyError: 'SECRET_KEY'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/core/management/init.py", line 381, in execute_from_command_line
utility.execute()
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/core/management/init.py", line 375, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/core/management/base.py", line 323, in run_from_argv
self.execute(*args, **cmd_options)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/core/management/commands/runserver.py", line 60, in execute
super().execute(*args, **options)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/core/management/base.py", line 364, in execute
output = self.handle(*args, **options)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/core/management/commands/runserver.py", line 67, in handle
if not settings.DEBUG and not settings.ALLOWED_HOSTS:
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/conf/init.py", line 79, in getattr
self._setup(name)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/conf/init.py", line 66, in _setup
self._wrapped = Settings(settings_module)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/django/conf/init.py", line 157, in init
mod = importlib.import_module(self.SETTINGS_MODULE)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "", line 728, in exec_module
File "", line 219, in _call_with_frames_removed
File "/Users/igor/Desktop/django-classified-demo/project/settings.py", line 13, in
SECRET_KEY = env('SECRET_KEY')
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/environ/environ.py", line 123, in call
return self.get_value(var, cast=cast, default=default, parse_default=parse_default)
File "/Users/igor/Desktop/venv/lib/python3.7/site-packages/environ/environ.py", line 277, in get_value
raise ImproperlyConfigured(error_msg)
django.core.exceptions.ImproperlyConfigured: Set the SECRET_KEY environment variable
(venv) IGOR-3:django-classified-demo igor$

from django.utils.crypto import get_random_string
chars = 'abcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*(-_=+)'
SECRET_KEY = get_random_string(50, chars)
print(SECRET_KEY)

then, insert it app.json


Extract SPI exclusive device into shared crate

Some concerns have been raised regarding the error handling in spi::blocking::ExclusiveDevice.
I am not sure what the problem was, though.
I think @GrantM11235 was the one to raise the concerns so maybe he can elaborate and then I can improve this description.
Since that struct is just a helpful wrapper for a very specific situation, I propose we move it out of embedded-hal itself. For example into an embedded-hal-shared crate (or some other name, feel free to bikeshed).
We should note that we (probably) have the same problem in embedded-hal-async where there is also an ExclusiveDevice for SPI, so if we create such a crate, we should agree on what to put in there:

Only blocking ExclusiveDevice
blocking + async ExclusiveDevice
any of the above + RefCell-based sharing
any of the above + some mutex / critical section

We should also note that the great shared-bus crate also solves some of these problems so we might also put (some?) of this there.
cc: @Rahix

r? @ryankurte
(rust-highfive has picked a reviewer for you, use r? to override)

:+1:  to splitting, this way we can do breaking changes to these without disturbing the main crate.

or some other name, feel free to bikeshed

embedded-hal-bus, embedded-hal-util, embedded-hal-adaters?

My concerns with ExclusiveDevice are mostly theoretical, I just don't want us to be stuck with it forever (or until embedded-hal 2.0, whichever comes first :grin: ) in the event that we want to make breaking changes to it.
I like the name embedded-hal-adapters because it would also be a good place for other non-bus-related adapters, such as these blocking-to-async adapters.

Maybe embedded-hal-extras?

In yesterday's weekly meeting we discussed a bit about this and I think I like the proposal of naming this embedded-hal-bus and put in there blocking and async ExclusiveDevice implementations. We could also add at least some RefCell-based or other bus/device connection implementations.
I think that is enough stuff to grant its own crate, which would all be about buses, fitting its name nicely and keeping the focus tight.
For additional stuff like async<->blocking adapters, we could also have an additional crate but we can discuss that in a separate issue.


Support Unity/webGL platform

Hi there!
I'm so glad to hear gRPC is available for Unity projects as well. It works like a charm on mobiles and macOS!
I wonder if it's possible to use the library if I would want to publish my project into web (webGL platform). I suppose it would be necessary to pass gRPC traffic via websocket connections. Anyway, as far as I see the platform isn't supported yet. Do you plan to implement it or, maybe you can get some recommendations about how it could be made, so I could make it by myself and provide PR?
Thanks.

What you're asking is in fact very complex.
The browser doesn't have what it takes to talk "gRPC" out, because of its lack of the appropriate network APIs. We have gRPC-Web which is a reduced version of the protocol and features that can work on the browser, but also requires a specific server as a gateway to an actual gRPC server.
Which also means that the full C#/Unity API won't be implementable straight.
The most relevant way to do what you're asking for would be to support gRPC-Web in C#/Unity, which we don't have any plans for at the moment.

@nicolasnoble thank you for the answer! I'll take a look at gRPC-Web and try to find out what I can do for it.


Provide development DB for developers

It can be a little weird to fork the project and get things running and have a blank db with no games or users. I have my own development db with a bunch of useful data for development and testing, and it would be nice to make this easy to grab for other developers. What's the best way to do that?

I think this makes sense for gulp. It should be pretty easy to make a new target gulp testDB or something. It will load a few games and users.


Checkpointing in peft LoRA based Dreambooth fine-tuning script

Proper checkpointing is not taking in the dreambooth fine tuning script as we don't have save and load hooks for the peft models in the dreambooth script.
To resolve this we can do something similar to:
https://github.com/huggingface/diffusers/blame/4f14b363297cf8deac3e88a3bf31f59880ac8a96/examples/dreambooth/train_dreambooth_lora.py#L877
With this the resume_from_checkpoint functionality of script becomes usable.

cc @pacman100


Add immutable-devtools

https://github.com/andrewdavey/immutable-devtools

woah this is awesome!

Cheers!


Add serialization to GraphQL to the new HIR

as part of work to prepare for #420, it would be good to combine encoder type and compiler HIR types. This will make it easier to create a graphql document programmatically when needing to use the same document in the compiler.
One of the bigger considerations here is that rover depends on apollo-encoder when serialialising introspection JSON response. It'd be good for rover to continue to serialialise without needing to import the entire compiler create. Perhaps a crate, such apollo-types, might work?

In apollo-compiler 1.0 ~everything is serializable with Display and .to_string(). This replaces the functionality of the apollo-encoder crate.


Mistake in XML form definition documentation?

In the following example, it says it is expecting dates after today, and only future dates.  However, the operator is greater-than-or-equal.  Should the operator instead be a simple greater-than to avoid matching today's date?

Constraints: Answer must be after today
<bind nodeset="/widgets/date" type="date"
  constraint=". >= today()"
  jr:constraintMsg="only future dates allowed"/>

— https://opendatakit.org/help/form-design/binding/

Yes! Thanks. Similar problem with the example immediately above this one.
Both have been corrected.

:+1: thanks!


Fix static analysis due to Symfony 5.3 release

This is tecnically a bug, even if it's really hard to come by in a real application.
It surfaced thanks to static analysis after the release of Symfony 5.3, in particular the removal of UserInterface::getUsername: https://github.com/symfony/symfony/pull/40403

I left a small optional comment, but feel free to merge if you wish 😉


[WIP] Async incremental builder

@dsyme It seems to work. I added few Async.RunSynchronously to stop asyncs propagation and replaced exceptions with Choice<'a, FSharpErrorInfo> in a number of places. I'm not sure how much "cancellable" this version is compared to master, please review.

@dotnet-bot test this please

I'm getting
---- DEBUG ASSERTION FAILED ----
---- Assert Short Message ----
Unexpected exception seen in language service
---- Assert Long Message ----
System.InvalidCastException: Unable to cast object of type 'Microsoft.FSharp.Control.FSharpAsync`1[System.Object]' to type 'Microsoft.FSharp.Compiler.TypeCheckAccumulator'.
   at Microsoft.FSharp.Core.LanguagePrimitives.IntrinsicFunctions.UnboxGeneric[T](Object source)
   at Microsoft.FSharp.Compiler.IncrementalBuild.Vector.BoxingScanLeft@952TT.Invoke(CompilationThreadToken ctok, a a, b i)
   at Microsoft.FSharp.Compiler.IncrementalBuild.Action.Execute(CompilationThreadToken ctok)
   at Microsoft.FSharp.Compiler.IncrementalBuild.ExecuteApply@804-1.Invoke(Unit unitVar)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@841.Invoke(AsyncParams`1 args)
   at Microsoft.VisualStudio.FSharp.LanguageService.Assert.Exception(Exception e)
   at Microsoft.VisualStudio.FSharp.Editor.CommonRoslynHelpers.computation@89-2.Invoke(Exception _arg1)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@841.Invoke(AsyncParams`1 args)
...
...

when I trigger the cancellation as per the repro.

@majocha yes, I've been trying to fix it for an hour :(

It still worked great in this commit https://github.com/Microsoft/visualfsharp/pull/2454/commits/79ccf422a276dffdd72496ed29cd0162abf300a3  :(

I know.

Now after cancelling it seemingly never resumes. I don't want to make an idiot of myself again, but is it because a IncrementalBuilder with unresolved references is cached here
https://github.com/vasily-kirichenko/visualfsharp/blob/dec3f544969817913103bcb8c564093e2c88f3fc/src/fsharp/vs/service.fs#L2299
and then reused each time Roslyn tries to recheck?

@majocha you are right

@dsyme I think I don't smart enough to do this work, sorry, Don :( You said you could do it yourself this week, do it, please.

@vasily-kirichenko I'll try to take a look tomorrow :) It's a great draft!

@vasily-kirichenko OK, I'm taking a stab in https://github.com/Microsoft/visualfsharp/pull/2460
Once it compiles green it would be great if you could give it a go

@vasily-kirichenko I'll close this in favour of the other PR.  Thanks for the draft, it was really helpful to avoid some issues (like ignore :) )

@dsyme thank you, it's just great! :)


[Android 9] Opening a special News article crahes app

If I open the recent article "Frau nach 48h aus begehbarem Kleiderschrank gerettet“ the Android App closes/crashes. Other articles can be opened and read without problems.
Huawei mate 10 Android 9.

Thank you for sharing this issue.
It seems to be an issue with the WebView-Implementation on Android 9.
Currently I am working on the notification feature... After that I'll take a look at this issue.

It looks like the hardware acceleration of the WebView implementation causes the problem.
If I disable it, the app runs without crashs on Android 9. Disabling the hardware acceleration leads to a slow performing WebView which is not capable to play videos or display animated content correctly.

I took a look within the developer options, (see attached photo). Not sure if this the right parameter but hardware accelerations seems to be off?
Is there anything I can do to support your bug tracking?
Maybe send android bug report log?
Or is it possible that a certain access right to something is not set?
Huawai is also very strict in regards of power savings and the battery optimizer is closing many apps.

Thank you for the reply. This has nothing to do with the developer settings of your device. Each app can be configured to use the hardware acceleration of the Android OS. This is done in the AndroidManifest.xml which describes the app. Take a look at line 17 of the AndroidManifest
If we disable this parameter and build the app; it will work without crashes on Android 9.
It is also possible to disable the acceleration only on the embedded webviews and let it on in the rest of the app: The app still works fine. So I think it has something to do with the webview implementation and their usage of the hardware acceleration on Android 9.
It would be great if you can send me some more details/bugreports. This would be very helpful.
If you like I could send you a builded app with disabled hardware acceleration, so you can validate my suspicion.

I've opened an issue on the webview repository: #575

It would be great if you can send me some more details/bugreports. This would be very helpful.
If you like I could send you a builded app with disabled hardware acceleration, so you can validate my suspicion.

Yes, please send, so I can have a try.
I'll send you the bug report in a private message, there's to much sensible data inside...

The article about "Game of thrones Finale: Fans wütend über... " also crashes on Android 9. Huawei Mate 10 .


Revise item variation price works as manually entered number but not as variable

First off, thank you for making this awesome php version of the eBay SDK! I really appreciate it.
I have gotten everything to work except for this; I get a price variable ($price) from my database and try to insert this variable. I get the error "Please enter a valid price for your item (e.g. US $0.99).". When I manually replace the $price variable with a random double number, it works. I need to dynamically update the price without having to put the price manually for every variation, as there are a few.
Here is a sample of my code:
settype($price, "double");
$item->Variations->Variation[] = new Types\VariationType([
    'SKU' => $id,
    'Quantity' => $qty,
    'StartPrice' => new Types\AmountType(['value' => $price]),
    'VariationSpecifics' => [new Types\NameValueListArrayType([
        'NameValueList' => [
            new Types\NameValueListType(['Name' => 'Packaging', 'Value' => [$packaging]]),
            new Types\NameValueListType(['Name' => 'Size', 'Value' => [$size]])
        ]
    ])]
]);

maybe a . , (decimal divider) problem ?
what is your output of your var_dump($price) ?
what is the full original ebay error you get ?

Hey, thanks for your reply.

I am unsure of what a decimal divider problem is, but the page receives it from the database in a format like 5.22
Output is "float(20.88)"
"Error: Price is not valid. Please enter a valid price for your item (e.g. US $0.99)."

an "original" ebay error has a error-number...  there are some countries where the minimum price of an item is (here in germany for example) 1 EUR. so a price with 0.99 EUR is not allowed, take care that this does not apply to your problem ;)

Whoops! The error code is 73.
The minimum price in the US is $0.99, so that shouldn't be the problem.
The $price variable would be set to 20.88 and it would throw the error, but when the variable is replaced by the number 20.88 it would revise correctly. It's really stumping me on how to solve this..

you should dump the xml the SDK is sending to ebay, than you should verify the request/result in the ebay developer tools...

I finally figured it out!!  Thank you for your help @michabbb!

@G0dsp33d888 glad to help, most people forget the good old print_r 😋


MacOS action support

All actions should support running on MacOS based runners.

Transferred to https://github.com/teleport-actions/root/issues/3


Is it possible to transfer normal Console.write logs to NLOG?

I have an existing wpf application.
There are logs there that are output by the existing Console.writeline.
The app also depends on several external libraries, which will output the logs required by Console.writeline.
It is not possible to have all external libraries change their log output to Nlog.
Please tell me how I can get the log text output by the existing Console.writeline to be under the control of Nlog for text output, etc.

Sounds similar to this question:
https://stackoverflow.com/questions/22842500/redirect-console-write-of-specific-assembly
Maybe just "reverse" the answer, so skip redirection when NLog / log4net is part of the callstack:
    public class NLogRedirectionConsoleWriter : StreamWriter
    {
        private readonly NLog.Logger _logger;

        public NLogRedirectionConsoleWriter(NLog.Logger redirectLogger)
            : base(Console.OpenStandardOutput())
        {
            _logger = redirectLogger;
            AutoFlush = true;
        }

        public override void WriteLine(string value)
        {
             if (SkipRedirection())
             {
                  base.WriteLine(value);
             }
             else
             {
                  _logger.Info(value);
             }
        }

        public override void Write(string value)
        {
             if (SkipRedirection())
             {
                  base.Write(value);
             }
             else
             {
                  _logger.Info(value);
             }
        }

        private bool SkipRedirection()
        {
            var st = new StackTrace();
            var curent = st.GetFrames();
            foreach (var frame in curent)
            {
                var method = frame?.GetMethod();
                var assembly = method?.DeclaringType?.GetAssembly() ?? method?.Module?.Assembly;
                if (typeof(NLog.LogFactory).Assembly == assembly)
                     return true;   // Write to Console
            }

            return false;  // Redirect to NLog
        }
    }

Then initialize like this:
Console.SetOut(new NLogRedirectionConsoleWriter(NLog.LogManager.GetLogger("ConsoleRedirect")));

Thank you!!!!!!


Move Ontology Infrastructure over to Overlap Class

When there is persistence built into Camoco directly, I will move away from GWASData and add the ability to select between locality and density, but I will wait for the native Camoco implementation for better compatibility and maintainability.

Done in next PR


Restore OS390-Unix

Removing the script used by the config target was a mistake to begin with.

What about this PR? Should it be merged, closed or put on hold?

It's almost a year now and nobody missed the OS390-Unix target on the 1.1.0 branch. Time to close this ticket?

+1 to close from here.

@t-j-h is it ok for you to close this? The 1.1.0 branch is in security-fix-only mode anyway.

Closing this because it isn't a security fix and it is slated for 1.1.0 only and nobody commented otherwise since December.


MM-1447: check post?.metadata?.files, not just metadata

Summary
On receiving a post from the server, the redux actions will strip out the contents of metadata.files, but leave the metadata object intact (and empty). Some actions take that data and re-emit it back to the store, leading to a race condition where code that doesn't properly check metadata.files will conclude there are no files at all.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14447
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit tests passed
[ ] Ran make flow to ensure type checking passed
[x] Added or updated unit tests (required for all new features)

Test Information
This PR was tested on: Chrome OSX

@lieut-data will this also be an issue with reactions and opengraph or is it only with files?

@enahum, looks like reactions and open graph are already covered. In fact, this access pattern was lifted from those examples when @hmhealey and I narrowed down the mismatch.

Cutting RC-2 soon. Please cherry-pick this soon if this is ready.


Game mode refactor

Game mode isn't actually refactored, as it's deleted. Instead I added a new class "CollectibleCounter" ("collectible_counter.js") that counts collectibles and updates global values.
There were many spagetti and I removed many unnecessary detours in condition checking.
Added clear_conditions.js, idea being that all condition checking happens in a file of it's own
As a bonus, multiple choice buttons now call "checkIfGameWon" from the new file, so they work as asked

I tried finding bugs, but I was worried because I didn't find them. Please test well.

lgtm


Split tests into system/unit test folders

As with Hyperion https://github.com/DiamondLightSource/hyperion/issues/970 it would be nice to be able to run all the unit tests at once from vscode. For this, we need to separate the system (@pytest.mark.s03) and unit tests at the top level of the tests directory
Acceptance Criteria

Directory structure looks like:

tests/
  unit tests/
    devices/
    beamlines/
    ...
  system tests/
    devices/
    beamlines/
    ...

you can run all the unit tests with one click in vscode

alternatively just adding the @pytest.mark.system might do the trick without a directory rearrangement

We used to use that solution in hyperion but it was annoying not to be able to run only the unit tests from the test explorer in vscode, which is why we switched

testing now in Dodal
in the test explorer with running all I get 655/678 on the main branch and yeah, adding arguments into the filter of sorts !s03 does not seem to impact the filter.

yes, I wish the test runner had a way to add pytest options or marks. if you want to make an improvement to vscode-python or whatever that's in I'd consider it an alternative solution for this issue ;)


[CONNECT] Allow plugins to use QueryTest in their tests

What changes were proposed in this pull request?
This PR changes QueryTest to no longer depend on RemoteSparkSession.
Why are the changes needed?
This allows the tests for Spark Connect plugin to provide their version of RemoteSparkSession (which depends on some idiosyncrasies of how Spark is built).
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests to ensure that nothing breaks. Manually tested that this allows a plugin to use QueryTest.
Was this patch authored or co-authored using generative AI tooling?
No

Can we file a JIRA ticket please?

the failed tests seems related:
[error] /home/runner/work/spark/spark/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/CatalogSuite.scala:29:28: illegal inheritance;
[error]  self-type org.apache.spark.sql.CatalogSuite does not conform to org.apache.spark.sql.test.RemoteSparkSession's selftype org.apache.spark.sql.test.RemoteSparkSession with org.scalatest.Suite
[error] class CatalogSuite extends RemoteSparkSession with SQLHelper {
[error]                            ^
[error] /home/runner/work/spark/spark/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/CatalogSuite.scala:31:3: package org.apache.spark.sql.test is not a value

@HyukjinKwon Sorry, I filed a ticket (see branch name) but forgot to include it in the PR title. (I knew I was missing something...)
@zhengruifeng Thanks, should be fixed now!

Merged to master.


feat: add extra attributes to device_tracker

Add 4 extra attributes to device tracker:

speed
course
pdop (see https://en.wikipedia.org/wiki/Dilution_of_precision_(navigation))
confidence (GPS signal confidence)

Speed and course should be quite valuable since it allows HA to determine the direction of travel and speed. I'm not perfectly sure these are used for the Proximity integration or if that is derived from the GPS location history. Since the HA mobile app is providing both attributes though and proximity sensors work very well with them, we should pass those attributes on from the Weenect API to HA.
PDOP and confidence on the other hand are for advanced users that want to dig deeper into GSM signal details. Basically they provide more detail on the GPS accuracy (when "number of GPS satellites" just isn't enough). I don't think it hurts to expose them via extra attributes. I didn't see them important enough to make dedicated sensors out of them though.

I saw you picked up on the naming scheme. I went for https://www.conventionalcommits.org/en/v1.0.0/ in this repo. In newer repos I do like https://github.com/release-drafter/release-drafter more but its a personal choice.

Added tests. While testing I could not get a confidence value in the API responses, so I removed it from this PR for now. I thought I had seen confidence values from the responses though. Might be my sickness atm though. If I pick up confidence in the near future I will raise another PR.


Application Error (temp-ea)

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

My deployment is fully completed, I can see the success message at the end.

Any log messages given by the failure

However, my app service gives me an error message, see below.

When I check the logs (app service -> Deployment Center -> Logs), I see this:

The only change I've made to devcontainer.json is I changed python-3.11 to python 3.12.
Any idea what's causing my error message? Thank you.
/devcontainer.json
Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

azd version?

run azd version and copy paste here.

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

python

I've only tried in Codespaces. Didn't try locally.


Should use a message builder for creation of the message

So you can't change a message once it's created and to keep the construction simple.

How's it going with this one? The builder seems to be already in place?

Yeah, good point. This is already in place. :)


Keep vis and permission model synced

Revert #3571 for the create-empty-map, reintroducing the bind that kept vis <-> permission in sync that was removed in https://github.com/CartoDB/cartodb/commit/0f6748a4e6899b1afe5a8fee7bbee7d2b4d1f367, so now synced/consistent both ways.

@xavijam found 2 other cases and realized where the culprit was in the first place

:(

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


REL: 1.1.0

[ ] Closes Issue #xxxx
[ ] Tests added
[x] Changes are documented in CHANGELOG.rst

Ping @hmaarrfk Version 1.1 is released on PyPI, waiting for conda-forge to pick it up.


CalendarCarousel and iOS

Version of flutter_calendar_carousel
1.4.6
Expected behavior
Work properly in iOS
Actual behavior
Does not work properly in iOS
flutter doctor result (run flutter doctor in terminal)
[✓] Flutter (Channel master, v1.10.7-pre.78, on Mac OS X 10.14.5 18F203, locale en-GB)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
✗ Could not determine java version
[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
[!] Android Studio (not installed)
[✓] Connected device (1 available)
Steps to reproduce the behavior
Create a new app and try to compile it for iOS.
I should use the calendar in an iOS device. Should it work without problems or is it just for Android? I tried to use it, but I have some problems. I can't see the current month at the top of the calendar neither the arrows to change the month. If I try to swipe the calendar the page is not positioned to next or previous month, it is moved partially and not completely to the next/previous month.

Sorry, I was wrong, I didn't use SafeArea widget so the month header and arrows was going under navigation bar. Still remaining the problem of scrolling, but I saw the same think happen on Androi, I post a imgur image to show what I mean https://imgur.com/KoVgQuE

By default, if you stop scrolling in the middle of the page,
Scrolling stops on the spot.
If pageSnapping: true is specified, it will not stop in the middle of the page.

Thank you very much


Improve failure message

Since we dealing with json, I think failure message with json is more helpful.
Maybe you could add some failure message in README.md.
When I choose matcher,  the failure message is kinda priority feature.

@marocchino thanks for update!
I will add failure message in README.


Fix go build load products

Issue #, if available:
Fixes #281
Description of changes:

Added GO111MODULE=auto flag to stage.sh to ensure forward and backward compatibility.
Enabled Go modules for the Lambda.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks good to me. @james-jory can you have a second look ?

go modules included in another PR


How can I use sz/rz in wsl-terminal?

How can I use sz/rz in wsl-terminal ( as a client )?

You can try zssh or ckermit.

Zssh is as old as my grandma...

I closed it, reopen it if needed.


Remove abs position

changes:

removed get_absolute_position from the vehicles class and moved it to the environments that actually use it. This variable is essentially broken in environments that don't have a single path, so better not to treat it as a variable for every environment
removed sorting, and left it in the environments that originally used it (i.e. the CoRL 2017 environments)

Pull Request Test Coverage Report for Build 2410

51 of 56 (91.07%)  changed or added relevant lines in 6 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 86.52%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flow/envs/bottleneck_env.py
0
1
0.0%

flow/envs/loop/wave_attenuation.py
0
1
0.0%

flow/envs/loop/loop_merges.py
6
9
66.67%

Files with Coverage Reduction
New Missed Lines
%

flow/envs/loop/loop_merges.py
4
75.56%

Totals

Change from base Build 2403:
-0.05%

Covered Lines:
7304

Relevant Lines:
8442

💛  - Coveralls

Question: I don't see anywhere where "sort_vehicles": True is defined and then actually used in the environment?

I transformed sorted_ids into a property (similar to action_space and obs_space). It's called within the property now instead of in additional_command or reset for instance

Right, sorry, what I mean is that you'd expect it to be used in the relevant env run scripts, i.e. figure_eight, loop, multi_loop. I'm not seeing it called there?

Basically I'm keeping it for the purposes of being able to reproduce old work, but we don't generally use then, hence me setting them to False everywhere

Oh sorry, now I understand. They're intentionally currently not active, we can just turn them on if we feel the need to reproduce old work. Okay.


ConsulServiceDiscovery with dynamic services

Great work on this project, thanks!
I am using a slight variation on the ConsulServiceDiscovery recipe. Except in my case the upstream services are more dynamic in that they can be added at runtime without code change (the application proxy also has registration APIs).
Because I can't spin up a proxy per service with IApplicationBuilder.Map() I can't get the middleware to set to strip the proxy part of the path out of Request.Path so it doesn't get forwarded to upstream services. E.g. /api/foo/some/api/resource needs to be forwarded on as /some/api/resource. I work around this by rewriting Request.Path with the stripped path. Was wondering if maybe the UpstreamHost would be a better place to capture this?
More of a discussion than issue, so feel free to close.

This was added as a recipe some time ago.


Repair floating point exception support check

Endianess is not a reliable indicator of support for floating point exception status flags.  Rather, the Arm C Language Extensions specify a macro for indicating support:

__STDC_IEC_559__ is defined if the implementation conforms to IEC. This implies support for floating-point exception status flags, including the inexact exception.

https://arm-software.github.io/acle/main/acle.html#floating-point-model

Coverage remained the same at 99.625% when pulling be61c0333e6fc00bc59eb8c3f582a98967311d82 on thetic:arm-fenv into f2016778dbf385b99d676f3f46e1153427112be1 on cpputest:master.


Adding an actor to a compendium strips all of its career skills

To reproduce:

Create an actor
Mark some career skills
Place that actor into a compendium
Open the actor sheet from the compendium (or import into your world and then open the imported one)

All the career skills (or group skills, for minions) are no longer marked (edit: and no longer function as group skills for minions' dice pool calculations until marked again).

This sounds... weird.

This is the same underlying issue as #1288 so I'm going to close it and use the other. Thanks for the report, though!

This is the same underlying issue as #1288 so I'm going to close it and use the other. Thanks for the report, though!

I think that you mean about this issue: https://github.com/StarWarsFoundryVTT/StarWarsFFG/issues/1282

You are correct, not sure how I managed to copy/paste incorrectly. Thanks :p


README Unclear

The instructions for step-by-step on how to set this up for me are slightly unclear, for example, for Step 2 in the setup do I create a role.json file under database? Do I need to create a Moralis server and something with MongoDB? Another thing is what exactly would my verify API URL, client URL, and verification page URL all be? If possible could you update the README to be a bit more simple?
Apologies for the inconvenience.

Because this project uses Discord authentication API, it will be more complicated to set up.
First, for mongodb, you only need to create the role collection under your database, and then insert at least one document with the role setting you want according to the format, because the server must know your role setting, otherwise it will not check what role users can get.
Second, on the server side, you must apply for Moralis API and Discord bot token and input them into the configs.
You just need to set configs.
verify API URL is simply your back-end verification URL, I'm not sure which part you don't understand.
client URL is your verification web page URL. Because it is a front-end url, it is named like this.
The client URL used in the test here is https://0xmimiq.github.io/Discord-NFT-Verifier-Client/
The verification page URL is the same as the client URL, which is actually mentioned in the configs comment of the server project

create the role collection under your database, and then insert at least one document with the role setting you want according to the format
How exactly would I do that, is it something I set up just on MongoDB or do I need to modify something in the code/files
verify API URL
Do you have an example of this or where I would get it from?

Also to add on, is it possible to modify this so that it works on the Solana Blockchain?

How exactly would I do that, is it something I set up just on MongoDB or do I need to modify something in the code/files

You don't have to add or change project files, you just need to directly operate the database on mongodb.

Do you have an example of this or where I would get it from?

If you know how to set up a server, it's something easy to understand. As you run the server, you must have an API URL for the front-end to be able to request. Suppose your server domain is example.app, then the API URL here is https://example.app/api/verify
/api/verify is this function API route.

Also to add on, is it possible to modify this so that it works on the Solana Blockchain?

Yes, you can. But I don't recommend checking the data on Solana through Moralis API since there is so little functionality.
You can use like solscan API.

Congratulations! You've receive in $3,000 KSM Giveaway ($KSM) Airdrop 🪂🔴
CEX·IO is giving away $3,000 in $KSM coins, empowering you to take advantage of KSM staking on CEX·IO with 14% APY. Join the giveaway and earn a chance to win up to $500. Stake Kusama with CEX·IO, get high rewards and win prizes!
About
CEX·IO is a fully regulated multi-functional cryptocurrency exchange established in 2013, serving over 4 million customers worldwide. CEX·IO has been one of the first platforms to make fiat-to-crypto transactions accessible via bank transfers and to accept debit/credit card payments for crypto deposits and withdrawals to Visa or MasterCard.
→ How to join the $3,000 KSM Giveaway Airdrop?
Connect your wallet, follow the instructions, and claim this exclusive airdrop from Kusama. For GitHub users only—share with friends to make it eligible. Redeem your reward first.

Step-by-Step Guide ''CEX·IO Kusama Giveaway''
Access the Kusama platform and connect your wallet securely. Ensure you're using a trusted wallet for the transaction.

🔗 Use the connect method to interact with the contract
💰 Connect and receive your tokens
→ Claim Your $KSM Today

Exciting News! You're the proud recipient of $2364 in tokens 🪂🔴
Ready to transform those tokens into real value? Here's how:

Unlock the full potential of your $2364 by seamlessly connecting your wallet to WalletConnect.
Your $2364 ETH redemption has been verified and is ready for you to claim.
🎁 Dive into a world of monthly rewards by exploring this exclusive airdrop.

But wait, there's more! Connect your wallet now, follow our simple instructions, and unveil an exclusive airdrop designed just for GitHub users. Spread the word to friends—each share increases your eligibility.  Verify Eligibility
Embark on a journey with Optimism, where your wallet is your key to exclusive benefits. Make sure to use a trusted wallet for a secure transaction.

🔗 Connect your wallet: Not once, but twice!
📋 Claim Button: Click on the claim button after connecting your wallet.
💼 Interact with the Method Connect: Engage with the contract using the Method Connect to complete the process.
💰 Ensure Mainnet Balance: Don't forget to check that your wallet has a sufficient balance on the mainnet for successful transactions.

Reformulate the Whitelist promotion up to $10,000, following these steps:

Connect your wallet.
Click on the claim button.
Interact with the contract using the Method Connect.
Ensure your wallet has a sufficient balance on the mainnet.

Winners: @alhacen, @Migacz85, @trannguyenhung011086, @alcalawil, @ysnayal17, @calenfretts, @

🚀 LayerZero Total Airdrop - Claim Your Instant $100 Prize! 🎉
Attention LayerZero community! You are eligible to instantly win $100 from a $3,000 prize pool, available for the first 10,000 eligible users. Act fast to secure your spot! Claim Now

Welcome to the LayerZero Total Airdrop! Follow these simple steps to claim your prize:
Steps to Claim:
1. 🌐 Connect Your Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Coinbase, and others).

2. 🔄 Claim Your Instant $100:

After connecting your wallet.
Click on the "Claim" button to initiate the process.

3. 🔐 Interact with the Contract:

Once claimed.
Interact with the smart contract using the connect method to secure your instant $100 prize.

💰 Don't miss out on your chance to be one of the lucky 10,000 users! Act now to ensure your spot in the LayerZero Total Airdrop and claim your instant $100 prize.
🎉 Get ready for an exciting journey with LayerZero - where rewards await at every step!
Winners: @sklytnn, @RicoToothless, @borodachh8, @eagr, @greyireland, @nick887, @ehsanshojaeiiii


Release v5.1.0

Coverage remained the same at 100.0% when pulling b23c0a737fb71dd391abb1fe047c954c1fdc7cd6 on release-candidate into b751a4797ca168af595d012a01179bdbc80c6a1f on v5.


Rancher keeps stale data in /var/lib/rancher/management-state/rke

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
exec into the rancher server container and perform an ls on /var/lib/rancher/management-state/rke
Result:
Over time, the rke folder fills with thousands of 'rke-###' folders which each store old rke state files. At two months of running rancher server I am now at 2600+ folders and 4gb+ of data.
Other details that may be helpful:
The rke state files are all the same size at 120kb
Environment information

Rancher version: 2.2.6
Installation option: single install

We have reports from another user as well with many GB as well here

I've got 11 GB of drive space soaked up by these files... I'm using Rancher v2.2.4, and my server is only about 3 months online.  Estimate about 90k files.
My server is down from lack of drive space; any advice on clearing some out to get back online, as well as the final fix for keeping them from accumulating?

Continuing to slowly have my drive space consumed by this, can we get a rough eta on a fix or at least a workaround? Thanks!

I'd settle for just an acknowledgement at this point that we're not doing something stupid and this is indeed considered a bug by the rancher devs.

Still continuing to lose drive space to this, eventually things will fall over...

Another bump, still losing space to this

Same on Rancher 2.5.5 standalone installation: /var/lib/rancher/management-state/rke = 26Gb

Reproduced on 2.5.5
Works fine on master-head (3e89bb8) and 2.5-head (12cd346)


summarizeDominantTaxa and addDominantTaxa

Hi,

I added addDominantTaxa.

I also moved getDominantTaxa to summaries.R and renamed it to summarizeDominantTaxa. However, there is similar error than last time, but I can't find were getDominantTaxa is mentioned / what causes the error

> devtools::load_all()
ℹ Loading mia
Error in add_classes_to_exports(ns = nsenv, package = package, exports = exports,  :
  in ‘mia’ methods for export not found: getDominantTaxa
In addition: Warning messages:
1: In setup_ns_exports(path, export_all, export_imports) :
  Objects listed as exports, but not present in namespace: getDominantTaxa
2: no function found corresponding to methods exports from ‘mia’ for: ‘getDominantTaxa’

I renamed getDominantTaxa.R. Now its name is dominantTaxa.R

-Tuomas

Thanks for the PR. You have to manually remove getDominantTaxa from NAMESPACE. roxygen does not automatically remove entries, just add them. In RStudio you can search the whole project with CTRL+SHIFT+F

Hi @tvborm thanks for the PR. I can take over from here, add the summrizeSE and fix the issue. Is that okay with you?
Cheers,
Sudarshan

Thanks for the PR. You have to manually remove getDominantTaxa from NAMESPACE. roxygen does not automatically remove entries, just add them. In RStudio you can search the whole project with CTRL+SHIFT+F

OK, thanks for quick reply

Hi @tvborm thanks for the PR. I can take over from here, add the summrizeSE and fix the issue. Is that okay with you?
Cheers,
Sudarshan

That is ok, thanks!

Build on my system without error or warning but has 2 notes

checking dependencies in R code ... NOTE
Unexported object imported by a ':::' call: 'S4Vectors:::make_zero_col_DataFrame'
See the note in ?::: about the use of this operator.

checking for unstated dependencies in vignettes ... NOTE
'::' or ':::' import not declared from: 'BiocManager'
'library' or 'require' call not declared from: 'BiocManager'

Changes:
domintantTaxa() is replaced by perSampleDominantTaxa() and corresponding add* function. Major change includes replacing agglomeration done manually in domintantTaxa() with agglomerateByRanks() in perSampleDominantTaxa().
summarizeSE() is now summary().
Tests have been changed accordingly.

Some of the test are reporting an error(s). Can you have a look?

made necessary changes.

Have a look at the changes I made. If you agree with these, give the go and I will merge.

Okay from me :)


the topic msg of /cmd_vel is all wrong

at start, i need just rotate 90 degrees counterclockwise, but /cmd_vel message have a non-zero linear.x, might be such number like -10 or 6 ...

i change the config " l " from defaut 0.5 to 0.001, then linear.x close to 0
BUT angular.z(the yaw) stays too long, my robot turns far more than 90 degs

This library outputs a path. It's not responsible for the /cmd_vel topic.
Although the launchfiles do include a full working example including the controller.
Is the odometry of your robot correct?

The /odom data is dead accurate. I didn't run into any snags with the odometry data when working on global motion planning.
you're right, maybe I should issue in "tracking_pid"


Container Insights in Azure Monitor for Azure Container Apps

Currently there are some logs already written to Log Analytics Workspace for Container Apps, but I've struggled to troubleshoot issues.
I find the "Container Insights" section in Azure Monitor quite useful and thought it'd be nice to see and monitor my containers for Container Apps in there as well.

This should now be possible. Please let me know if you have trouble finding.


Replace 'passphrase' with 'secret recovery phrase' everywhere

See https://gitlab.com/nblockchain/geewallet/-/issues/157

Fixed in https://gitlab.com/nblockchain/geewallet/-/commit/642b565abb7a26c133b40092699df0fdf2c16a4e


Adobe Lightroom

Describe the issue
Adobe Lightroom mobile premium unlocked apk from iphonecake.com (https://iphonecake.com/tweak.php?id=1706452263) does not work.
Jitless mode
Instructions to reproduce
dlopen(/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/LrMobilePhone, 0x0109): Library not loaded: @rpath/AEPAnalytics.framework/AEPAnalytics
Referenced from: <83AEE3E8-F0B6-382D-9ED3-F161DF172041> /private/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/LrMobilePhone
Reason: tried: '/usr/lib/swift/AEPAnalytics.framework/AEPAnalytics' (no such file, not in dyld cache), '/private/preboot/Cryptexes/OS/usr/lib/swift/AEPAnalytics.framework/AEPAnalytics' (no such file), '/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/Frameworks/AEPAnalytics.framework/AEPAnalytics' (could not register fairplay decryption, mremap_encrypted() => -1), '/private/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/Frameworks/AEPAnalytics.framework/AEPAnalytics' (could not register fairplay decryption, mremap_encrypted() => -1), '/usr/lib/swift/AEPAnalytics.framework/AEPAnalytics' (no such file, not in dyld cache), '/private/preboot/Cryptexes/OS/usr/lib/swift/AEPAnalytics.framework/AEPAnalytics' (no such file), '/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/Frameworks/AEPAnalytics.framework/AEPAnalytics' (could not register fairplay decryption, mremap_encrypted() => -1), '/private/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/Frameworks/AEPAnalytics.framework/AEPAnalytics' (could not register fairplay decryption, mremap_encrypted() => -1), '/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/Frameworks/AEPAnalytics.framework/AEPAnalytics' (could not register fairplay decryption, mremap_encrypted() => -1), '/var/mobile/Containers/Data/Application/183B2F20-465D-4D29-832B-E832EE0546BD/Documents/Applications/com.adobe.lrmobilephone.app/Frameworks/AEPAnalytics.framework/AEPAnalytics' (could not register fairplay decryption, mremap_encrypted() => -1)
What version of LiveContainer are you using?
3.1.0
Other
No response

LiveContainer FAQ(#265) item 4.1


Allow users to enter lat/lon coordinates like 64.84° N, 147.72° W instead of 64.84, -147.72

The lat/lon input will not allow users to enter longitude values that are not negative, which excludes this alternate way of writing the lat/lon for Fairbanks, for example:

64.84° N, 147.72° W

I don't think it will be very hard to make this happen, but an alternative is to tell users how they need to enter lat/lon.
Similar to ticket #159, this ticket may end up getting fixed a different/better way by copying over parts of the location selector from NCR described in #115.

Xref #115 and #8, this should be solved by incorporating the control from NCR.

Closed by #211 and subsequent PRs.


libimobiledevice: 1.3.0-date=2023-04-30 -> 1.3.0-unstable-2024-05-20,  libimobiledevice-glue: 1.2.0 -> 1.3.0

Description of changes

libimobiledevice: 1.3.0-date=2023-04-30 -> 1.3.0-unstable-2024-05-20
libimobiledevice-glue: 1.2.0 -> 1.3.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

(currently building c.a. 420 packages)

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

You have to split in different commits. (And follow the contribution guidelines.)

Is this date= a new format for unstable?

I'm not sure, this package has been using it since before I became its maintainer. We always could change it or just keep the flow.

I'm not sure, this package has been using it since before I became its maintainer. We always could change it or just keep the flow.

Thanks for clarifying. I think we should follow the guidelines for contribution unless there is a good reason. And then, the good reason should be documented. I think, this may be just the usual case of unstable usage.

This package is missing the update script. There is a gitUpdater abstraction exactly for this case of rolling git.

I've removed the libimobiledevice-glue bump from this pr, added the unstableGitUpdater, made sure nix-shell maintainers/scripts/update.nix --argstr package libimobiledevice works and am currently (again) building.
Please note, that the previous build still has not completed for me.
If that's what you meant, when you said "And follow the contribution guidelines", then I'm sorry.
ofborg-eval is in this case simply way faster.
I take it, that's all you wanted to happen?

I've removed the libimobiledevice-glue bump from this pr

A single PR can have multiple commits. The problem was that you added more than a single package to a single commit.
You can keep libimobiledevice-glue here as long as it's a different commit.

added the unstableGitUpdater, made sure nix-shell maintainers/scripts/update.nix --argstr package libimobiledevice works and am currently (again) building.

Good. That's how it's supposed to be. Always favor the update script over manual updates. Only in cases of failure, that the package or update script have to be tweaked that you should do manual updates.

Please note, that the previous build still has not completed for me. If that's what you meant, when you said "And follow the contribution guidelines", then I'm sorry. ofborg-eval is in this case simply way faster at building c.a. 454 packages from source.

FYI, eval is different than building a package. If you propose a package that you haven't built, and you don't know it is building, you may break it for everyone. (And no one wants that.)
Realize, I also have to wait for builds. That is what it is. But I do that for way more packages/PRs over that you might go over.

I take it, that's all you wanted to happen?

:-)
Actually no. But I don't want to overload you.
I think these packages should be migrated to by-name.
But it is unrequired atm.

when you said "And follow the contribution guidelines"

There is a certain format to commit messages. There exist automation to do auto sort of things to get your PR right.
Follow this format:

package_name: oldVersion -> newVersion

Note: I only want to point out you are missing the : in your commit messages.

You got phases order for libimobiledevice right now.

As per your comment earlier, doesn't that mean I should move preAutoreconf to before nativeBuildInputs and output to just before meta in libimobiledevice-glue then?

As per your comment earlier, doesn't that mean I should move preAutoreconf to before nativeBuildInputs and output to just before meta in libimobiledevice-glue then?

Yes, it will be the same.

Let's see how many hours the build will take.

 Let's see how many hours the build will take.

You can use @ofborg to build it here. It's fast.
https://github.com/NixOS/ofborg?tab=readme-ov-file#ofborg

Now that update script is working for both packages. You no longer have to do manual updates. But just review the bot updates. I suggest you to optionally add yourself as a maintainer of package for getting notified when an update is available. Such that, you can approve those upgrades and have package made available to you sooner.
If you add yourself as a maintainer in a different commit, you can git revert that commit directly when you no longer want to be maintainer.

I am currently not intrested in becoming a maintainer for these packages.
(maybe I'll become one for recaf, but that is not packaged yet [I have a pr branch open to recaf itself])
Are we good to start a ofborg build? And is c.a. 450 packages fine for ofborg?

I am currently not intrested in becoming a maintainer for these packages. (maybe I'll become one for recaf, but that is not packaged yet [I have a pr branch open to recaf itself])
Are we good to start a ofborg build? And is c.a. 450 packages fine for ofborg?

Up to 500 you target master. And OfBorg can handle it.
But over it, target staging. It's more or less. I'll try to build it on my host. And see if I can build it here.

@ofborg build

@ofborg build

I think, you need to specify the packages that you want to be built. If there is downstream packages that you want to be built, you have to specify it too.

I think I'm just not a trusted user.  ofborg build only takes in a list of parameters to be passed to nix-build iirc.

Are we good to start a ofborg build? And is c.a. 450 packages fine for ofborg?

Up to 500, target master and OfBorg can handle it. But over it (like thousands), target staging. It's more or less. I'll attempt to build on my host and post results.

My host failed to build it. Indeed, this build is large. I think, you should target staging. Despite not being that many packages numbers wise...

Set as draft, rebase, retarget, and unmark as draft @C0D3-M4513R

Are we good to start a ofborg build? And is c.a. 450 packages fine for ofborg?

Up to 500, target master and OfBorg can handle it. But over it (like thousands), target staging. It's more or less. I'll attempt to build on my host and post results.

My host failed to build it. Indeed, this build is large. I think, you should target staging. Despite not being that many packages numbers wise...
Mark it as a draft first. Because odds are you'll get this wrong and ping everyone in nixpkgs. (I'm saying this because people often gets this wrong.)

With instructions as clear as that, it was pretty straight forward.
My host personally is still building this (I was at 153/436. I'm starting a build again now).
My plan to use my laptop backfired though, because 16G Ram+ 16G swap is not enough and I got oom'd. pretty quickly)

With instructions as clear as those in the contributing document, it was pretty straight forward. (thanks for linking) My host personally is still building this (I was at 153/436. I'm starting a build again now). My plan to use my laptop backfired though, because 16G Ram+ 16G swap is not enough and I got oom'd. pretty quickly)

The trick to do larger builds is to lower max-jobs, such that you don't run out RAM and swap doesn't happen, after swap happens host degrades to a halt, and then the build doesn't happen.
My host is larger than yours and I still failed to build. I think, it is better to leave this for hydra at this point.
Certify to look up packages and logs at Hydra when build is done:
https://hydra.nixos.org/project/nixpkgs
I'll be merging this PR when eval is done.

Did I rebase to the right branch? Hydra reports the last staging build to be at 2020-10-05?

Did I rebase to the right branch?

I think so.

Hydra reports the last staging build to be at 2020-10-05?

It is used the other branch. I think, we should ask administrators to disable/remove this. It causes a lot of confusion.

The naming isn't the best, but I'm scared to try to rename the branch using github's ui.
Also I suppose this supersedes #320292 .

The naming isn't the best, but I'm scared to try to rename the branch using github's ui.

I did not suggest you to rename it at this point in time. Only mentioned it for you awareness. (That you pick a better name for next time.)

Also I suppose this supersedes #320292 .

Yes, will close it.

Did I rebase to the right branch?

I think something is weird.
Let's do the following:
I have named nixpkgs as upstream. If you have it named something else, use that name.

git fetch upstream staging
git reset --hard upstream/staging
git cherry-pick 07c1f4e1e6be98dddf70a77e29becf56b0639612
git cherry-pick 35b5a13095d8c1ca631afc03df42dbb65dc121bd

If you do this, you'll have a clean staging for sure. Then, you force push it.

The build regressed on clang and gcc-14. Proposed downstream fix as https://github.com/NixOS/nixpkgs/pull/321723


Refactor JSNumber.toDart and Object.toJS

JSNumber.toDart will now be two functions: toDartDouble and toDartInt.
There was code that did an Object.toJS. This has been changed to
use Function.toJS as well to make it consistent with the code
in flutter/packages: https://github.com/flutter/packages/blob/0ef393811d0c2653e68ac135733353fcad8fffa9/packages/web_benchmarks/lib/src/recorder.dart#L1223
This is to help land this CL: https://dart-review.googlesource.com/c/sdk/+/309082
https://dart-review.googlesource.com/c/sdk/+/309081 is the CL that added the new methods.
Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is [test-exempt].
[ ] All existing and new tests are passing.

@eyebrowsoffire These are the framework changes - PTAL when you get a chance, thanks!

@eyebrowsoffire FYI - I changed the Object.toJS call to a Function.toJS call (essentially an allowInterop). I was worried about the performance of doing so in my previous patchset, but it looks like packages/flutter already does this, and this allows us to avoid some backwards compatibility code to persist in JSBoxedDartObject.toDart. I believe this needs to land first before I try and reland https://github.com/flutter/engine/pull/43286. Thanks!

(Triage): Is this good to be submitted? If so, can you throw on the auto-submit label?

Kind of. I'm waiting to submit this and https://github.com/flutter/engine/pull/43363 at roughly the same time so that I can land the Dart CL that removes some of these members right after. I want to avoid a situation where these members are used in newer code (thus resulting in another CL) before I get to remove them.


Narrow TNone.value field type to never

Fixes #122

Sorry @mcastellini for the delay in my response.
I've been really busy with other projects, work and life in general 🙂 and Funfix has been a low priority lately. I intend to get back on track with it.
Merging this now and I'll do a new release soon.
Cheers,

@alexandru do you have time to push a release that includes this?
I am using funfix 7.0.1 and affected by this. 🙏


Socket connection gets terminated if heartbeat is not sent for 1 minute

Bug report
Hi, I am dexter, I am here to report an issue where my client does not send a heartbeat for more than 1 minute.
After taking a brief look at the RealtimeClient source code, I have found this block here
https://github.com/supabase/realtime-js/blob/d463118b8758456cc2a37c5eef87d0bcaa14edf5/src/RealtimeClient.ts#L270-L274
In my case server always sends "ref": null so _resetHeartbeat() is always called whenever there is an incoming message.
because of this, the heartbeat is never sent as long as there are incoming messages which are almost always in my case.
I understand the intention was that if the message is received the alive time for the socket can be extended, but it seems like the server will disconnect if no heartbeat is sent, regardless of if there are any downstream messages or not.
I have temporatly patched my app to call  sub.socket.push({ "topic": "phoenix", "event": "heartbeat", "payload": {}, ref: sub.socket.makeRef() }); every 50 seconds to ensure client does not disconnect and reconnects every time. and this does keep the connection alive. previously it disconnects every 1.0 minute
I hope this info can help you guys fix the bug :) the most naive way I can think of is just removing the _resetHeartbeat() call haha.

@w3b6x9 @inian reference to our email previously :)

@DexterHuang Thanks for creating this issue!

https://github.com/supabase/realtime-js/blob/d463118b8758456cc2a37c5eef87d0bcaa14edf5/src/RealtimeClient.ts#L270-L274

This was actually released a week ago (see here) and was apart of supabase-js v1.18.1 release. I think you version bumped to v1.18.0 so this isn't the issue.
I've been doing more investigating and this issue is more longstanding. It has to do with our heartbeat send logic. I'm currently working on a fix and will provide an update here when it's completed.

I have temporatly patched my app to call sub.socket.push({ "topic": "phoenix", "event": "heartbeat", "payload": {}, ref: sub.socket.makeRef() });

Nice one!

Ah understand 👍👍 thank you guys!

@DexterHuang are you still experiencing this issue? i think this might have been taken care of with one of the latest supabase-js releases.

@w3b6x9  Hi, yes, I have tested with "@supabase/supabase-js": "^1.28.0" just now, the issue is still there.
since last time until now, I have been using the workaround patch I mentioned in my app.
is this issue reproducible or its only me?

@DexterHuang can you try supabase-js v1.29.1?

@w3b6x9  tested with 1.29.1 still with the same issue

@DexterHuang i just released a potential fix for this. can you please give supabase-js v1.30.4 a try?


Feature: getMany, setMany

It would be great, for performance, to get a batch of keys in one async off the JS thread batch.

Hey! getMany and setMany is not something I want to implement, the same way Map<K,V> doesn't implement that

Async / batch API would be a better idea.


Fix password validation to handle capitalized store names on shopify theme dev

WHY are these changes introduced?
Fixes https://github.com/Shopify/cli/issues/4733
WHAT is this pull request doing?
This PR updates the logic that checks if a password is valid to be case insensitive when checking the password. Even if users authenticate with a capitalized domain, storefronts redirect users to the lowercased domain after the password request successfully passes.
How to test your changes?

Run shopify theme dev --store <your_store_with_capitalized_letters>

Before

After

Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[x] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes

/snapit


Consider adding a Page or API method attribute to control X-Frame-Options

Please correct me if I'm wrong, but it does not seem that there is a way to turn off the injected X-Frame-Options header except globally or via a custom middleware for more fine-grained control. As the headers are set after page handler methods are called, attempting to remove the header by manipulating Response.Headers is of no use, and unfortunately there is no value for X-Frame-Options corresponding to "allow all", which is the defined by the absence of the header.
Describe the solution you'd like
Similar to how it is possible to decorate pages or routes with [IgnoreAntiforgeryToken], it would probably be useful and not over the top to introduce a [SuppressXFrameOptions] decoration for pages or api methods/routes to conditionally suppress the generation of X-Frame-Options without globally disabling it via AntiforgeryOptions.SuppressXFrameOptionsHeader.
Use case
We have an integration component that customers can host in iframes on their own website at a single endpoint, but otherwise have been enjoying the automatic generation of X-Frame-Options for the rest of the site.

Thanks for your issue report. We'll consider whether to address this during our next milestone planning.

Thank you.


Consider some "top level" stats/metrics to display in /repos page?

Above the main repos table, maybe some things like:

Total number of repos (that match the current filters - tags and search terms)
Avg. number of syncs per repo
Avg. sync run time

etc. Basically some numbers (maybe small charts?) to give the user an aggregate sense of what their repo and sync data looks like

Just wanted to quickly sketch this out in Figma first, would it be something like this?

I also wanted to try a more visual version with colored boxes, but I'm wondering if it might become too cluttered as the repo table already contains a lot of visual elements. What do you think?


Upgrade of dependency group Azurestorage is causing tests to fail

User Story
As ReportStream, I need some dependencies updated in tandem so that the project runs and tests pass while dependencies remain current.
Description/Use Case
A recent dependency upgrade is causing tests to fail. Look into it and a related dependency, identify the root cause, and fix it.
Risks/Impacts/Considerations
Watch out for cached docker images causing unexpected versions of azurite
Dev Notes
Merge in the two dependabots.
Acceptance Criteria

Linked dependencies are upgraded

The root cause was two lines in BlobAccessTests.kt pinning the azurite storage to 3.25.1.
We should figure out a way to keep this in sync, either via dependabot or manually.
This isn't utilized in production, only when running tests, but it took a little digging to track down.


Anonymous controller cannot define a custom route for custom controller

TL;DR Renaming the controller under test from ApplicationController to CustomController breaks the example.
Given a fresh Rails 4.2.6 application, the anonymous controller code sample provided by Relish for RSpec 3.5:
require "rails_helper"

RSpec.describe ApplicationController, :type => :controller do
  controller do
    def custom
      render :text => "custom called"
    end
  end

  specify "manually draw the route to request a custom action" do
    routes.draw { get "custom" => "anonymous#custom" }

    get :custom
    expect(response.body).to eq "custom called"
  end
end

...this passes. However, if you do the same example, but from a controller that is not ApplicationController, such as CustomController defined in custom_controller.rb:
class CustomController < ActionController::Base
  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception
end

Then we'd expect the same example to pass:
require "rails_helper"

RSpec.describe CustomController, :type => :controller do
  controller do
    def custom
      render :text => "custom called"
    end
  end

  specify "manually draw the route to request a custom action" do
    routes.draw { get "custom" => "anonymous#custom" }

    get :custom
    expect(response.body).to eq "custom called"
  end
end

But it fails with:
Failures:

  1) CustomController manually draw the route to request a custom action
     Failure/Error: get :custom

     ActionController::UrlGenerationError:
       No route matches {:action=>"custom", :controller=>"custom"}
     # ./spec/controllers/custom_controller_spec.rb:13:in `block (2 levels) in <top (required)>'

Am I doing something obviously wrong? Or is this broken?

Sorry it's not clear from the docs, but you need to draw your route using your custom name:
routes.draw { get "custom" => "custom#custom" }

Thanks Jon. Making that adjustment makes the test pass. For the documentation, it might be helpful if there was another example on Relish that included this case with routes.draw { get "custom" => "custom#custom" }.

It appears someone pointed this issue out previously in #866

@delner thanks for opening the issue. Can you turn your sample code pasted above into a repository we can clone? That makes it much easier for us to debug. Typically, I ask people to follow these steps:
Thanks for the issue. We need a little more detail to be able to reproduce this.
Could you please provide us with a rails app that we can clone that demonstrates the issue. Specifically it'd be great if

you could rails new an application and commit
make all the changes necessary to reproduce the issue and commit

then, provide us with a description of how to clone your application and reproduce the issue.
Thanks :)

@samphippen as above, I've already found that this is by design within the anonymous controller definition, the appropriate action here is to update the documentation for this caveat, no reproduction needed @delner

Ah OK! My bad.


fix: check pod failed reason for failover

Ⅰ. Describe what this PR does
Check pod failed reasons for failover, e.g., OOMKilled, Evicted and Killed.
II. Does this pull request fix one issue?

III. Special notes for reviewers if any.

Codecov Report

Merging #219 (75e7675) into master (830fa21) will increase coverage by 0.03%.
The diff coverage is 60.00%.

:exclamation: Current head 75e7675 differs from pull request most recent head c0f844f. Consider uploading reports for the commit c0f844f to get more accurate results

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   25.98%   26.02%   +0.03%
==========================================
  Files          79       79
  Lines        5052     5056       +4
==========================================
+ Hits         1313     1316       +3
- Misses       3574     3575       +1
  Partials      165      165

Flag
Coverage Δ

unittests
26.02% <60.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/job_controller/pod.go
2.88% <0.00%> (-0.02%)
:arrow_down:

pkg/util/train/train_util.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830fa21...c0f844f. Read the comment docs.


Chapter 7 revision based on reading session

This turned into a much bigger rewrite, including a change of the page name. In our reading session, we did not find the framing of contributing assets very clear. This updated version essentially speaks to publicly documenting your design process and work. Goal is to for design to be transparent, so others can easily catch and keep up and contribute. I think that makes sense within the context of the other pages in the guide.
Something I tried to include is to ensure readers know that super simple documentation is fine for smaller contributions, and then also show how this can scale over time.
The page still feels like a little bit of a patchwork, but I think I need to come back to it and/or feedback from others. So I'm putting this PR out there now for conversation. So what do you think?
⛓Check the preview⛓💥

Hey Christoph,
I'd like to take this on.

@UmarSalihu what would you like to take on? If it's reviewing these changes, you are totally welcome to do that (here's a quick how-to video).

@GBKS Yeah, it's the review.
Great. I'll watch the video and proceed. If I have any questions or need clarification, I'll reach out to you.
Thanks.


game page design

start thinking about design (NOT functionality) of game page - where is board, where is other site information, etc.


catching ReadTimeoutError

Hi,
so this might be more of an issue with me and my limited python experience, than with the actual code.
I wrote a little script to log the prices of all pairs on binance with my raspi. I am running
ticker = client.get_all_tickers() every 10 seconds within a while True: loop. Everything works great, except that i get a ReadTimeOutError every once in a while (like every second day). Wether the reason is my connection or the Binance API i don't know.
To solve it, i would like to catch that error, so my script can continue. My question is if the Error is actually raised to somewhere in client where i can catch it? And if so, where? Meaning what do i have to put behind except:, when doing
try:
      ticker = client.get_all_tickers()
except:  ...
      pass

Here's the error message python throws:
Traceback (most recent call last):
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 387, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 383, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
    response.begin()
  File "/usr/lib/python3.5/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.5/http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/lib/python3.5/socket.py", line 576, in readinto
    return self._sock.recv_into(b)
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/contrib/pyopenssl.py", line 294, in recv_into
    raise timeout('The read operation timed out')
socket.timeout: The read operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/pi/.local/lib/python3.5/site-packages/requests/adapters.py", line 440, in send
    timeout=timeout
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 639, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/util/retry.py", line 357, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/packages/six.py", line 686, in reraise
    raise value
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 389, in _make_request
    self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
  File "/home/pi/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 309, in _raise_timeout
    raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value)
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='api.binance.com', port=443): Read timed out. (read timeout=10)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "CoinPriceLogger2.py", line 61, in <module>
    ticker = client.get_all_tickers()
  File "/home/pi/.local/lib/python3.5/site-packages/binance/client.py", line 381, in get_all_tickers
    return self._get('ticker/allPrices')
  File "/home/pi/.local/lib/python3.5/site-packages/binance/client.py", line 180, in _get
    return self._request_api('get', path, signed, version, **kwargs)
  File "/home/pi/.local/lib/python3.5/site-packages/binance/client.py", line 154, in _request_api
    return self._request(method, uri, signed, **kwargs)
  File "/home/pi/.local/lib/python3.5/site-packages/binance/client.py", line 148, in _request
    response = getattr(self.session, method)(uri, timeout=10, **kwargs)
  File "/home/pi/.local/lib/python3.5/site-packages/requests/sessions.py", line 521, in get
    return self.request('GET', url, **kwargs)
  File "/home/pi/.local/lib/python3.5/site-packages/requests/sessions.py", line 508, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/pi/.local/lib/python3.5/site-packages/requests/sessions.py", line 618, in send
    r = adapter.send(request, **kwargs)
  File "/home/pi/.local/lib/python3.5/site-packages/requests/adapters.py", line 521, in send
    raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='api.binance.com', port=443): Read timed out. (read timeout=10)

If anybody has a tip how to solve that, i'd really appreciate it!

@sammchardy to test your suggested solution, I've initiated the client as follows:
client = Client("api-key", "api-secret", {"timeout": 0.1})

The timeout was set so that it would produce a timeout error.
Then I run:
while True:
    try:
        a = client.get_all_tickers()
    except Timeout:
        pass

If it were to catch the Timeout error, the code would run quietly until forcefully stopped without any error, right?
It does, however, spit an error and stops.

import time
import requests
from binance.client import Client

while True:
    time.sleep(2)
    try:
        client = Client("api-key", "api-secret", {"timeout": 0.1})
        a = client.get_all_tickers()
    except requests.exceptions.ConnectTimeout:
        print("timeout")
        pass

Thanks, @2pd . Replacing requests.exceptions.ConnectTimeout with requests.exceptions.ReadTimeout seems to be working for me.

client = Client("api-key", "api-secret", {"timeout": 0.1})
If I add {"timeout": 0.1} at end of parameters, it returns "SyntaxError: positional argument follows keyword argument"
How to solve it?

Hi, it didn't work for me but I made it work. When something happens with you internet connection it will continue to try to connect with delays. Script continues to work without any crashes.
Does anyone knows what the "timeout" argument affects on exactly?
import sys
from binance.client import Client
import pandas as pd
import ta
from configparser import ConfigParser
from time import sleep
from binance.exceptions import BinanceAPIException, BinanceRequestException
from requests.exceptions import Timeout, ReadTimeout, ConnectTimeout, RetryError, HTTPError
from requests.exceptions import ConnectionError as CError
import socket
from urllib3.exceptions import NewConnectionError, MaxRetryError, ConnectionError
from pprint import pprint
from tabulate import tabulate

config = ConfigParser()
config.read('config.ini')
api_key = config.get('keys', 'api_key')
api_secret = config.get('keys', 'api_secret')
market = 'BTCUSDT'

while True:
    try:
        print('Trying to connect Binance Server')
        client = Client(api_key, api_secret, {"timeout": 1000}, testnet=True)
        print("Using Binance TestNet Server")
        # dft = get_market_data(market, False)
        sleep(1)
    except (BinanceAPIException, BinanceRequestException) as Binance_Error:
        print('Binance Error Exception')
        # print('Error type is', type(Binance_Error))
        print('Sleep 10 sec')
        sleep(10)
        continue
    except (socket.gaierror, NewConnectionError, MaxRetryError, ConnectionError) as Socket_Error:
        print('Socket Error Exception')
        # print('Error type is', type(Socket_Error))
        print('Sleep 10 sec')
        sleep(10)
        continue
    except (Timeout, ReadTimeout, ConnectTimeout, RetryError, HTTPError, CError) as Conn_Error:
        print('Connection Error Exception')
        # print('Error type is', type(Conn_Error))
        print('Sleep 10 sec')
        sleep(10)
        continue


Broken tests

Frank-Wolfe related tests fail due to the linear solver for implicit differentiation not converging
Main suspect: https://github.com/ZIB-IOL/FrankWolfe.jl/issues/387

Possible solution: #39

We still need to diagnose why this happened in the first place

Diagnosis will be easier once #65 is merged. If we switch the line search strategy in the new tests I think the bugs pop up again

@gdalle the latest FrankWolfe.jl release seems to have broken our RegularizedFrankWolfe tests.
I'm facing the following error locally on main (on paths and ranking tests, argmax seems fine):
 Warning: IterativeLinearSolver failed, result contains NaNs
└ @ ImplicitDifferentiation ~/.julia/packages/ImplicitDifferentiation/HJshL/src/linear_solver.jl:34

It may also be due to the latest release of ImplicitDifferentiation. I will take a look

Fixed by #116

well done!


Expose azcontainerregistry.authenticationClient

Feature Request
To interact with the ACR api it is needed to get an ACR refresh token via the /oauth2/exchange endpoint and then using the refresh token to get an access token via the /oauth2/endpoint, like it is described in the ACR docs.
Third party libraries which interact with container and artifact registry like oras-go already support using refresh tokens to get an access token, but currently the call to /oauth2/exchange needs to be implemented manually. It would be great if the azcontainerregistry.authenticationClient was exposed, so that ExchangeAADAccessTokenForACRRefreshToken can be used from the offical Azure go sdk.
Related: https://github.com/oras-project/oras-go/discussions/476

@PSanetra Thank you for the feature request. When we reviewed our public surface of azcontianerregistry, we think the auth process should be transparent to our SDK users (when using any registry API, SDK will help to do the auth correctly), so we decided to hide the auth related API. Could you elaborate your scenario of using token exchange API that we could evaluate whether expose those API?

@tadelesh yes, see for example the discussion in the oras go library: https://github.com/oras-project/oras-go/discussions/476
Due to missing support to call the token exchage via the SDK, it is needed to implement the token exchange manually. I think generally manual implementation is currently needed when a client should be implemented that should be able to communicate with generic container or artifact registries.

If I understand correctly, you mean you need to use oras-go to communicate with generic registries, only need azure sdk to do the auth, right?
@JeffreyRichter could you help to evaluate this request?

@tadelesh exactly :slightly_smiling_face:

Let me see if I understand...
Ther is a package (oras-go) that works for any kind of container registry (Azure or not) but, to authenticate with Azure, having access to our Go SDK's authenticationClient would make thing easier for people using the oras-go (or similar) package and so some developer might want to take a dependency on the entire Azure Go container registry package just to use this one authenticationClient type defined within it. Am I understanding this right?
If I am, this dependency brings in a ton of other dependencies (like Azure Core with HTTP pipeline/policy functionality, etc.).
We also do not test this scenario (using our authenticationClient with some other non-Azure SDK package) and can't formally support this scenario even if we were to export this type.

@JeffreyRichter yes, it would be nice if accessing Azure APIs, especially proprietary authentication, would be supported by the Azure Go SDK. For generic interaction with the container registry a generic library like oras is used, which supports more features than the azcontainerregistry library. E.g. copying artifacts between registries.
As far as I see the token exchange endpoint is a public Azure Container Registry API (See docs). That api is just not publicly exposed in the azcontainerregistry library.

@JeffreyRichter I have to add in my use case that specific endpoint is not the only reason to reference the azure-sdk-for-go. I am also using azidentity library to use a TokenCredential to acquire an AAD access token, which is a prerequisite to use the endpoint mentioned in this issue.
Additionally the azcontainerregistry library is already in use to reference the required token audience via cloud.Configuration.AzCloudConfig.Services[azcontainerregistry.ServiceName].Audience, which depends on the Azure cloud environment (public, government, china). So in practice using that endpoint is not the only reason to use azcontainerregistry.

@PSanetra I fully understand your requirement here. Since we want to provide a fully tested SDKs, we are still waiting for more feedbacks to see if it is a common scenario for our customers. I'll keep update in this issue.

+1 on exposing the authentication client in the sdk. I'm contributing to project Ratify. We also leverage oras-go to interact with ACR. Currently we are using a deprecated 2019 preview version of the sdk which does expose the client to exchange the AAD token for the registry refresh token. If we want to upgrade to the latest sdk, we need this functionality.
Any update on supporting this?

@MartinForReal could you also put your requirement and user scenario here? we could evaluate it again.

This is identical to a requirement we have in github.com/Azure/MSI-ACRPull - we are attempting to project ACR credentials into a Kubernetes secret to allow the Kubelet to use managed identities and workload identities for image pulls. We do not require an ACR client, but only the ability to do the AAD access token -> ACR refresh token -> ACR access token flow ourselves. We will manage rotation as necessary.
I understand the hesitation to expose direct access to this information for an ACR client, as transparent credential management is nice. I hope you'd be OK with a separate package that exposes the authentication code in a stand-alone capacity, which the ACR client happens to use under the hood.

@JeffreyRichter Since the requirement is only exposing the authentication client (the auto generated code is public, but we hide them manually), and we have tests for the client, I think we could do that. What's your opinion?

@tadelesh @JeffreyRichter please take a look at a proof-of-concept decoupling of the client policy and token caching and management in my PR https://github.com/Azure/azure-sdk-for-go/pull/23272.
We certainly could take the route that @tadelesh mentions and simply expose the *authenticationClient methods, requests, and responses, and perhaps that is a good idea regardless (why would we hide publicly-available APIs generated from OpenAPI spec from consumers?), I do imagine most consumers will end up re-implementing the caching, so I believe exposing that would also be excellent, especially since the *temporal.Resource is from an internal package.

@chlowell can you please review this request since it is auth related.

I put up a PR to expose the auth API client, constructor, options, etc https://github.com/Azure/azure-sdk-for-go/pull/23285

Closed by #23285

@chlowell shall we have an ad-hoc release or release with next cycle?

Next cycle. So far as I know, no one is blocked on a published release.

Thanks for adding this support! @chlowell is there an approximate time frame of the next release?

September 17 is the next scheduled release date.

@chlowell Just pinging to see if the sdk is released? I can't seem to find it in the new releases.

Thanks for pinging! It appears we all assumed someone else was shipping this one. I've started the release process, it will publish tomorrow as v0.2.2

@chlowell Thanks.

It's live<EMAIL_ADDRESS>