Update Openshift doc to update networkType for 4.12+

From Openshift 4.12+, the default networkType is OVNKubernetes instead of OpenShiftSDN. This changeset updates the sed match pattern in both Calico OSS and Enterprise doc.
Product Version(s):

Calico OSS v3.25+.
Calico Enterprise v3.16+.

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

Does this break OCP v3.11? If so, I think we need to maintain both sed's

Does this break OCP v3.11? If so, I think we need to maintain both sed's

The updated sed command will match either OpenShiftSDN for OCP < 4.12 or OVNKubernetes for 4.12+.

LGTM


Webserver: avoid casting total  size from off_t to size_t when reading a file. Fixes issue #81

I checked that the issue existed on 32 bits system, and that the proposed fix did correct it. I guess that the pull request mentionned in the request is not coming, so here it is.

Fixes #81

After the merge I get these warnings:
src/genlib/net/http/httpreadwrite.c:200:45: warning: unused parameter ‘msgHeaders’ [-Wunused-parameter]  static void copy_msg_headers(IN LinkedList *msgHeaders,                                  ~~~~~~~~~~~~^~~~~~~~~~ src/genlib/net/http/httpreadwrite.c:201:46: warning: unused parameter ‘headers’ [-Wunused-parameter]                               OUT UpnpString *headers)                                   ~~~~~~~~~~~~^~~~~~~ src/genlib/net/http/httpreadwrite.c: In function ‘http_SendMessage’: src/genlib/net/http/httpreadwrite.c:470:25: warning: conversion to ‘off_t’ {aka ‘long int’} from ‘size_t’ {aka ‘long unsigned int’} may change the sign of the result [-Wsign-conversion]      amount_to_be_read = Data_Buf_Size;                          ^~~~~~~~~~~~~ src/genlib/net/http/httpreadwrite.c:471:26: warning: comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]     if (amount_to_be_read < WEB_SERVER_BUF_SIZE)                           ^ src/genlib/net/http/httpreadwrite.c:472:21: warning: conversion to ‘size_t’ {aka ‘long unsigned int’} from ‘off_t’ {aka ‘long int’} may change the sign of the result [-Wsign-conversion]      Data_Buf_Size = amount_to_be_read;                      ^~~~~~~~~~~~~~~~~ src/genlib/net/http/httpreadwrite.c:507:35: warning: comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]       size_t n = amount_to_be_read >= Data_Buf_Size ?                                    ^~ src/genlib/net/http/httpreadwrite.c:515:24: warning: conversion to ‘long unsigned int’ from ‘off_t’ {aka ‘long int’} may change the sign of the result [-Wsign-conversion]       amount_to_be_read -= num_read;                         ^~ src/genlib/net/http/httpreadwrite.c:515:27: warning: conversion to ‘off_t’ {aka ‘long int’} from ‘long unsigned int’ may change the sign of the result [-Wsign-conversion]       amount_to_be_read -= num_read;                            ^~~~~~~~ src/genlib/net/http/httpreadwrite.c:518:27: warning: conversion to ‘off_t’ {aka ‘long int’} from ‘size_t’ {aka ‘long unsigned int’} may change the sign of the result [-Wsign-conversion]        amount_to_be_read = Data_Buf_Size;                            ^~~~~~~~~~~~~
Maybe my compiler is too picky :)

What compiler are you using, with what options ? I was also surprised by the absence of signedness warnings actually. I find mine not picky enough ! I'll go back and fix this if I can get the warnings.

Hi Jean-Francois,
I have been using this script for a long time, I really don't remember why I have chosen those options:
./bootstrap && ./configure --enable-debug --prefix=/home/user/usr/libupnp CFLAGS="-ansi -Wconversion -Wchar-subscripts -Wall -Wextra -Wpointer-arith -Wwrite-strings -Wformat-security -Wmissing-format-attribute" && make clean > /dev/null && make -j4 > /dev/null


Add newline to .gitignore

Fixes #129.

[x] Tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

I can't merge it. @JustinBeckwith or @jmdobry can you please merge? Thanks!

Thanks @theacodes!


Option for less verbose output

This moves majority of Terragrunt's output to DEBUG level, and sets
default output mode to ERROR. The idea is that in default run user should
see much less output.
Closes: gruntwork-io/terragrunt#432

Looks like the precommit hooks failed.

Looks like the precommit hooks failed.

Running tests again!

Running tests again!

Could you pull in the latest from master?

https://github.com/gruntwork-io/terragrunt/pull/1521/ is merged now! Going to merge this in so I can work on the merge conflict in https://github.com/gruntwork-io/terragrunt/pull/1520 . That said, I don't quite have time to look into the details of this branch at this moment, so will defer the release to @brikis98 (otherwise I don't know what to put in the release notes).

Thanks Yori! I'll release this shortly.

https://github.com/gruntwork-io/terragrunt/releases/tag/v0.28.0


Update FilterButton.tsx

I gave the mobile version the same classes as the desktop version so that the button wouldn't change, and then gave the main div the class that it has when it is in desktop version as well

I create a new pull request that had changes that had been made to hannessolo/ndg , so I am closing this one.


⚠ Bofrost.at has degraded performance

In 22a66ac, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1212 ms

Resolved: Bofrost.at performance has improved in 6a6f51a after 9 minutes.


Please reduce the amount of comment packit sends to src.fp.o Pull Requests

What happened? What is the problem?
In January, I received 69 emails from src.fp.o generated by the packet user.
In December it was 110.
As more and more packagers embrace packit, I get more and more emails (mostly from packages co-maintained by python-packagers-sig).
Every Pull Request opened by packit almost immediately receives a comment by packit, doubling the amount of email notifications.
Please consider folding the initial comment to the PR description.
Thanks.
What did you expect to happen?
No immediate comments by packit on packit PRs.
Example URL(s)
https://src.fedoraproject.org/rpms/python-PyGithub/pull-request/26#comment-181891
Steps to reproduce
1. Be subscribed to notifications for many packages that use packit.
2. Receive hundreds of email from src.fp.o by packit.
3. Miss important email from PRs opened by humans because they are easy to miss.

Workaround

[X] There is an existing workaround that can be used until this issue is fixed. (Setup an email filter to delete the email from<EMAIL_ADDRESS>when it matches "Logs and details of the syncing".)

Participation

[ ] I am willing to submit a pull request for this issue. (Packit team is happy to help!)

hi @hroncok !
Thank you for bringing up this issue. Regarding the decision to create a dedicated comment for each syncing, our intention was to maintain transparency, considering that a retriggered sync has a new dashboard link. This approach ensures that each comment corresponds to a specific run and shows the time of it, making it easier to trace the history of syncs.
But I understand the issue regarding the potential noise it creates. We could change the behaviour to include the link in the PR description and for retriggers overwrite it or just provide list of links (or creating the additional comments only for retriggered syncs?)
We will discuss this with the team on Monday and provide an update here.

Comments for retriggers are probably fine. They provide valuable feedback that it happened. I only suggest to fold the firts comment to the pr description.


TimeoutError: Waiting for selector #__next .btn-primary failed

I get this error when I try to run docker:
chatgpt-telegram-bot-app-1  | ><EMAIL_ADDRESS>start /app
chatgpt-telegram-bot-app-1  | > node dist/index.js
chatgpt-telegram-bot-app-1  |
chatgpt-telegram-bot-app-1  | TimeoutError: Waiting for selector `#__next .btn-primary` failed: Waiting failed: 180000ms exceeded
chatgpt-telegram-bot-app-1  |     at Timeout.<anonymous> (/app/node_modules/.pnpm/registry.npmmirror.com+puppeteer-core@19.6.3/node_modules/puppeteer-core/lib/cjs/puppeteer/common/WaitTask.js:65:32)
chatgpt-telegram-bot-app-1  |     at listOnTimeout (node:internal/timers:564:17)
chatgpt-telegram-bot-app-1  |     at process.processTimers (node:internal/timers:507:7)
chatgpt-telegram-bot-app-1  |  ELIFECYCLE  Command failed with exit code 1.
chatgpt-telegram-bot-app-1 exited with code 1

Tried rebuilding docker image but it didn't help.

This may be due to the fact that chatgpt is currently in high demand and the login page will not show at this time. Try again after a while and see if the problem persists.

><EMAIL_ADDRESS>start /app
> node dist/index.js

TimeoutError: Waiting for selector `#__next .btn-primary` failed: Waiting failed: 180000ms exceeded
    at Timeout.<anonymous> (/app/node_modules/.pnpm/registry.npmmirror.com+puppeteer-core@19.6.3/node_modules/puppeteer-core/lib/cjs/puppeteer/common/WaitTask.js:65:32)
    at listOnTimeout (node:internal/timers:564:17)
    at process.processTimers (node:internal/timers:507:7)
 ELIFECYCLE  Command failed with exit code 1.

><EMAIL_ADDRESS>start /app
> node dist/index.js

the same error for me, I tried again and again, but i can not fix it.
and
Is there any chance we can use a bot version that doesn't require a browser? Will the arm version of the docker image be released then.

I encountered this problem today. It seems that OpenAI is sometimes asking for a new cloudflare captcha before showing the "log in" / "sign up" page.

Currently, you'll have to solve the captcha manually (if you're using xvfb, you'll need to connect to the virtual display first).

Is there any chance we can use a bot version that doesn't require a browser?

After the v4 of chatgpt api becomes stable, I'll update the code and then we'll be able to use a lightweight solution (which requires an OpenAI API key and may not be free though).

Will the arm version of the docker image be released then.

Currently it is not planned. You may search for some discussions here.

Thanks for you answers.
could i use Google reCaptcha to solve the captcha？

could i use Google reCaptcha to solve the captcha？

I'm not sure what you mean. This captcha is from Cloudflare, not the Google reCAPTCHA.

Closed as the issue is related to the upstream API.
FYI, now you can use the unofficial API that comes with v2.1.0 to bypass CloudFlare without a browser.


Fix file deletion

Closes #40
Inspired by #180

@EvWhymark Requesting review please. Thanks!
This was suuuuper tricky to figure out. The error turned out to be stemming from the fact that when we call closeTab from deleteFile in App.tsx, the internals of closeTab turned out to be using a stale version of the tab list, namely the initial one defined as [] empty array. Therefore it was not removing it from the tabList before the file actually got deleted.
The fix, interestingly, is to add a missing dependency in the useCallback that defines the event listener that ultimately gets added to the button that you click, in FileListing.tsx. This change ensures that  we call closeTab from deleteFile in App.tsx, the internals of closeTab use the latest version of tabList, so that it removes the entry from the tabList before the file actually got deleted from the ShareDB document.
Thanks for the inspiration @EvWhymark ! Without your initial push I would not have been able to track this down.


[multistage] visitor pattern for server request construction

currently ServerRequestUtils is used to construct translated plan for running leaf-stage server request. this posts problem for special requests such as subqueries.
This PR is the first step to expand the ServerRequetsUtils into doing some work of the PlanMaker

making ServerRequestUtils into a visitor pattern
let visitor use context so that any pre/post process required for subquery can be done separately.

context currently hold the visitor result (PinotQuery) but it can also extend to support extra plan results such as dynamic filter.

still returning Void for the visitor node, but later it should be unified with PlanMaker interface to return an Operator chain similar to PhysicalPlanVisitor

once done we should be able to execute pipelined subquery in generic fashion

Codecov Report

Merging #9653 (b6ccf07) into master (3de1c54) will decrease coverage by 8.18%.
The diff coverage is 83.78%.

@@             Coverage Diff              @@
##             master    #9653      +/-   ##
============================================
- Coverage     68.63%   60.45%   -8.19%
- Complexity     4920     5174     +254
============================================
  Files          1947     1938       -9
  Lines        104168   103847     -321
  Branches      15796    15752      -44
============================================
- Hits          71496    62780    -8716
- Misses        27556    36361    +8805
+ Partials       5116     4706     -410

Flag
Coverage Δ

integration1
?

integration2
24.85% <0.00%> (?)

unittests1
67.35% <83.78%> (+0.01%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...t/query/runtime/plan/ServerRequestPlanVisitor.java
76.47% <76.47%> (ø)

...va/org/apache/pinot/query/runtime/QueryRunner.java
81.18% <88.88%> (+2.24%)
:arrow_up:

...e/pinot/query/runtime/plan/PlanRequestContext.java
91.66% <91.66%> (ø)

...ot/query/runtime/executor/WorkerQueryExecutor.java
100.00% <100.00%> (ø)

.../pinot/query/runtime/plan/PhysicalPlanVisitor.java
96.96% <100.00%> (ø)

.../runtime/plan/server/ServerPlanRequestContext.java
100.00% <100.00%> (ø)

.../pinot/query/runtime/utils/ServerRequestUtils.java
94.11% <100.00%> (+11.54%)
:arrow_up:

...pinot/minion/exception/TaskCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ot/broker/requesthandler/BrokerRequestHandler.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/controller/recommender/io/ConfigManager.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 453 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

converting it back to draft. ideally we wanna get rid of ServerRequestUtil entirely and let the queryrunner compiles into a context aware request. will update shortly.
CC @agavra

LGTM! Change makes sense :) in case i missed something, this is just refactoring, correct? (there's no additional functionality in this PR)

no functional changes. I am still trying to fully get rid of the last boilerplate code in the ServerRequestUtils and make it fully visitor pattern
this is needed for doing dynamic filter poc - so that we can add additional execution info besides the pinotQuery object


Rewrote shader_param expansion using pure AST

Fixes #606

Argh, I can't do that, since my fork is outdated. Will try from a local branch.


Inconsistent romaji conversion of しょ

Hi,
First off, big thanks for the creation of Cutlet, I think it's really great and really helpful for my project!
I think I found a strange behavior of the library and I'm not sure if it's a bug or not.
When converting "しょうり" to Hepburn romaji, it's converted to "Shiyoori", which doesn't seem right to me. However, other conversions with "しょ" seem to work properly.
Check out this example:
>>> import cutlet
>>> katsu = cutlet.Cutlet()
>>> katsu.use_foreign_spelling = False
>>> katsu.romaji("しょうり")
'Shiyoori'
>>> katsu.romaji("しょ")
'Sho'
>>> katsu.romaji("しょうゆ")
'Shouyu'

Is this behavior correct? Am I missing something?
Cheers

Glad to hear cutlet's been useful to you.
Basically you have a weird case where the underlying Japanese tokenizer is failing to work as you would expect. The issue is not with しょ specifically and isn't related to small kana.
When debugging, it's often helpful to run things through fugashi to see what's happening. With my local setup I get this:
しょう  シヨー  スル    為る    動詞-非自立可能 サ行変格        意志推量形
り      リ      リ      り      助動詞  文語助動詞-リ   終止形-一般
EOS

Here we can see we're getting two tokens, the first of which is しょう. But it's being interpreted as a form of suru - it's specifically being interpreted as a variation on shiyou. And for some reason the canonical form is not shiyou, but シヨー/shiyoo - not really sure why that would be, but sometimes slangy words are like that phonetically in UniDic. (Compare やろうぜ, which becomes Yarou ze.)
It seems very hard to get the dictionary to parse しょうり as a single noun instead of a variety of weird interpretations, but on the other hand, unlike しょうゆ, 勝利 would not be written only in katakana in a normal document.
Are you working with documents written primarily in hiragana? If you just need a straightforward kana to romaji conversion you could be better off using map_kana like so:
>>> from cutlet import Cutlet
>>> katsu = Cutlet()
>>> katsu.map_kana("しょうり")
'shouri'

Hi, and thanks for the quick response.
The workaround that you suggested works for me to solve this specific case, but if there are other words that have a similar issue, it will be difficult to identify.
I need to convert directly from hiragana because in some cases I need to get all the possible readings from a kanji form.
Is there a way to pass both the kanji and the hiragana to force the tokenizer to work properly?


[M000404] Rep. Jim McDermott

Rep. Jim McDermott:
http://mcdermott.house.gov
Likely contact form URL to start with:
http://mcdermott.house.gov/index.php?option=com_content&view=article&id=476&Itemid=8

YMAL file not found. I am working on it.


Fix Vector3 slerp method by normalizing cross product

This pull request is to solve issue https://github.com/godotengine/godot/issues/27825.
Bugsquad edit: Fixes #27825.

May it break compatibility ? If so its better to be tagged for 4.0 version

No, I don't think so.
This PR just fix an issue with normalization of the cross product of 2 unit vectors, I think that it was implied that the result is always a unit vector, but it isn't (apart from when they are perpedicular).
This is the function changed:
https://github.com/godotengine/godot/blob/93845572d576133401d4f29b9bda1c90d261d577/core/math/vector3.h#L221-L228
That, on the last line calls the rotated function, the definition of rotated is here:
https://github.com/godotengine/godot/blob/93845572d576133401d4f29b9bda1c90d261d577/core/math/vector3.cpp#L35-L45
Then rotated uses Basis, and basis at a certain point does this check:
https://github.com/godotengine/godot/blob/93845572d576133401d4f29b9bda1c90d261d577/core/math/basis.cpp#L810-L815
But, as the axis is the cross product of 2 unit vectors, the check fails and return this error:
core/math/basis.cpp:813 - Condition ' !p_axis.is_normalized() ' is true.

Thanks!

May I suggest to cherry pick this one for an eventual 3.1.2 release?
This very simple code change is only a fix. 99% of users is not even using this function.
My project (and most likely only mine) relies quite a bit on this function (I had to implement it in GDSCript meanwhile, most likely reducing performance).

Dang, I realized that there is another change needed:
https://github.com/godotengine/godot/blob/93845572d576133401d4f29b9bda1c90d261d577/core/math/vector3.h#L222-L224
The math check is not needed anymore, please someone correct me if I'm wrong, but this checks that the current vector is normalized before performing the slerp, but this is not needed (rather unwanted), as far as I understand how this works.
So, in order to fix this, should I create another pull request?

Thanks for the cherrypick @akien-mga !

Cherry-picked for 3.1.2.


@material-ui/core v1.x.x TS2344 error

My UI is failing to compile because of a TS2344 error in file @material-ui/core/TextField/TextField.d.ts, in detail:

(11,62): error TS2344: Type '"defaultValue" | "onChange"' does not satisfy the constraint '"classes" | "component" | "innerRef" | "className" | "style" | "margin" | "disabled" | "fullWidth...'.
Type '"defaultValue"' is not assignable to type '"classes" | "component" | "innerRef" | "className" | "style" | "margin" | "disabled" | "fullWidth...'.

I had the same issue in the past with a beta version, and I solved thanks to Material-ui-next typescript error, but same trick didn't work. I also tried to copy and paste the configuration from the stack overflow answer, but npm wasn't able to find that exact versions of the packages.
Checking the file TextField.d.ts and following FormControlProps declaration coming from file FormControl.d.ts, I noticed an error "[ts] Type 'ReactType' is not generic." on the declaration component?: React.ReactType<FormControlProps>;, don't know if that's the triggering cause.
At the moment package.json looks like:
	...
	"dependencies": {
		"@material-ui/core": "^1.1.0",
		"immutability-helper": "^2.7.0",
		"node-sass-chokidar": "0.0.3",
		"npm-run-all": "^4.1.3",
		"react": "^16.4.0",
		"react-dom": "^16.4.0",
		"react-redux": "^5.0.7",
		"react-s-alert": "^1.4.1",
		"react-scripts-ts": "2.4.0",
		"react-tippy": "^1.2.2",
		"redux-logger": "^3.0.6",
		"redux-thunk": "^2.3.0",
		"serve": "^6.5.8"
	},
	"devDependencies": {
		"@types/jest": "^20.0.4",
		"@types/node": "^8.0.14",
		"@types/react": "^16.3.14",
		"@types/react-dom": "^16.0.5",
		"@types/react-redux": "^5.0.20",
		"@types/react-s-alert": "^1.3.1",
		"@types/redux-logger": "^3.0.5"
	},
	...

This is the first time I use v1 of Material-UI (since 0.xx is not supported anymore), I tried different version combinations for @material-ui/core (1.0.0, 1.1.0) and react / react-dom / @types/react / @types/react-dom (different v16 releases, v15 too out of desperation), no luck with any combination.
Any idea?

It looks like this is caused by an update to typescript itself and has been fixed here, but not published yet: https://github.com/mui-org/material-ui/issues/11656
There's a workaround in that issue that I just tried out in the mean time, and it works. I have a new app created with create-react-app, installed the latest material-ui, and added { "compilerOptions": { "keyofStringsOnly": true } }, and no more problem.

I'm gonna assume the issue if fixed now.


No theme color and can't change via preferences

I just installed this after installing the Material theme. This is my first time using the new theme after coming from a similar one called Materialize that appears to have gone unmaintained. After installing this theme addon I can't seem to get colors no matter what I try. I have uninstalled/reinstalled (both manually and using Package Control) and exited/reopened Sublime quite a number of times but nothing seems to help. Here is a screenshot of what I'm seeing where it's just stuck with a gray color that won't change:

I am running the ST3 Dev channel and I did get an update today (build 3128) prior to installing this so there could be a chance that something in the latest update broke it potentially.
Here is my Preferences.sublime-settings in case it helps:
{
	"always_show_minimap_viewport": true,
	"atomic_save": false,
	"bold_folder_labels": true,
	"caret_extra_bottom": 2,
	"caret_extra_top": 2,
	"caret_extra_width": 2,
	"caret_style": "phase",
	"color_scheme": "Packages/Material Theme/schemes/Material-Theme.tmTheme",
	"drag_text": false,
	"findreplace_small": false,
	"font_face": "Source Code Pro",
	"font_options":
	[
		"gray_antialias",
		"subpixel_antialias"
	],
	"font_size": 13,
	"highlight_line": true,
	"ignored_packages":
	[
		"Vintage"
	],
	"indent_guide_options":
	[
		"draw_normal",
		"draw_active"
	],
	"line_padding_bottom": 3,
	"line_padding_top": 3,
	"material_theme_accent_scrollbars": true,
	"material_theme_accent_teal": true,
	"material_theme_appbar_teal": true,
	"material_theme_bold_tab": false,
	"material_theme_compact_sidebar": true,
	"material_theme_tree_headings": false,
	"overlay_scroll_bars": "enabled",
	"revert_font_size": 13,
	"show_encoding": true,
	"sidebar_medium": true,
	"tabs_small": true,
	"theme": "Material-Theme.sublime-theme",
	"translate_tabs_to_spaces": true,
	"trim_trailing_white_space_on_save": true,
	"word_separators": "./\\()\"':,.;<>;~!@#$%^&*|+=[]{}`~?"
}

This add-on is for Material Theme that add the colored app bar (i have to fix this because the title bar should have the same color of the appbar). You don't need this addon if you don't want the colored appbar, if you want to change the color you have to add in your settins one of this rules (from the README):
"material_theme_appbar_lime": true,
"material_theme_appbar_orange": true,
"material_theme_appbar_purple": true,
"material_theme_appbar_red": true,
"material_theme_appbar_yellow": true,
"material_theme_appbar_indigo": true,
"material_theme_appbar_pink": true,
"material_theme_appbar_blue": true,
"material_theme_appbar_cyan": true,
"material_theme_appbar_charcoal": true

Seems that Sublime Text now ignore the the add-on preferences. I have to investigate..

+1, It happens to me after upgrading to Sublime Text 3 Build 3127

@equinusocio I don't think that it ignores, maybe this is due to:

https://www.sublimetext.com/docs/3/themes.html#deprecated
https://www.sublimetext.com/docs/3/themes.html#obsolete

Currently, I don't have plans to update Boxy, I'll probably rewrite it from scratch, because ST 3127+ introduces may sweet stuff, but with current implementation it's hard to fix such bugs.

You have to review all colors and remove obsolete elements.

You have to review all colors and remove obsolete elements.
This addon doesn't have any alpha value and deprecated items..

Every custom theme is inherited from the default one. Default theme introducing some styles depending on your color scheme (see "layer0.tint", "file_dark", "file_medium" and etc.), so you should disable them in this addon. For example set "layer0.tint" to [255, 255, 255].

But the question is, why ST show the latest color defined instead of use the setting?

Hmm, strange. I really don't know. Just checked the Boxy, everything works fine, except some margins and icon assets on Windows.

I'm starting hating sublime text. Now i'm using Visual Studio Code and his theming API are more more easy and clear. Maybe in the future i will rewrite Material Theme.

IMO VSCode & Atom devs knows ST weakness, that's why they introduced some better solutions. However I'm huge fan of the Sublime Text and I believe in its good future, because nothing bits it by performance. The problem is small dev resources, only two persons works on it, so that's not a surprise they doesn't keep pace with all stuff.

I'm sure ST can do whatever VSCode can, we just need good plugins and rating system on Package Control.

When i will finish Material Theme for VSC i can consider to rewrite Material Theme. I need/want your collaboration. Should be awesome The most hackable Material Theme :P

@equinusocio Thanks...I have still kept it enabled thus far because I prefer having at least somewhat of a material look. I have no experience currently with theming ST or even working with ST plugins but I'd love to learn a bit and help out if I can.


Could we see support for UPBGE 3.0?

Could we see support for UPBGE 3.0?

UPBGE has not released 3.0 yet.
I will release this one after 3.0 is released.
And I consider to support daily release same as fake-bpy-module.

@ItsCubeTime
Now, the daily build version of fake-bge-module is released.
https://pypi.org/manage/project/fake-bge-module-latest/releases/
You can try this for the latest UPBGE version including 0.3.

@ItsCubeTime
Now, the daily build version of fake-bge-module is released.
https://pypi.org/manage/project/fake-bge-module-latest/releases/
You can try this for the latest UPBGE version including 0.3.

Thanks a bunch 💝


Prototype loading fungible tokens

This is just rough prototype with hardcoded contract list to show how it might look with real data.
(farm token not yet conforming to standard so failing)

@vgrichina do you see anything wrong with just using the symbol (eg wNEAR) for the primary name in the list for now? (vs the long string?
It seems like if we are pulling contract data, and the "name" as displayed above is functioning more like a description which could potentially be a super long string, we may just want to use the shorter "symbol" alternative.

@vgrichina do you see anything wrong with just using the symbol (eg wNEAR) for the primary name in the list for now? (vs the long string?
It seems like if we are pulling contract data, and the "name" as displayed above is functioning more like a description which could potentially be a super long string, we may just want to use the shorter "symbol" alternative.

yeah, this should work
so then we just need to have placeholder icon as well

@corwinharrell I've changed according to your suggestion, now just need placeholder icon to use

@vgrichina in the future, what might be used to display icons if not token.symbol? Is it up to the author to add something like token.icon or is it on us to request that they include that? Seems like it would make sense for these contracts to have the following endpoints:
name: 'Banana',
abbreviation: 'BNNA'
icon: '🍌',
contract: 'berryclub.ek.near',
balance: '500'

How much influence do we have over what contract authors include and how it is structured?

@vgrichina in the future, what might be used to display icons if not token.symbol? Is it up to the author to add something like token.icon or is it on us to request that they include that? Seems like it would make sense for these contracts to have the following endpoints:
name: 'Banana',
abbreviation: 'BNNA'
icon: '🍌',
contract: 'berryclub.ek.near',
balance: '500'

How much influence do we have over what contract authors include and how it is structured?

We recommend to include icon as a data URL with SVG of the icon. But it’s gonna be optional.

@vgrichina in the future, what might be used to display icons if not token.symbol? Is it up to the author to add something like token.icon or is it on us to request that they include that? Seems like it would make sense for these contracts to have the following endpoints:
name: 'Banana',
abbreviation: 'BNNA'
icon: '🍌',
contract: 'berryclub.ek.near',
balance: '500'

How much influence do we have over what contract authors include and how it is structured?

We recommend to include icon as a data URL with SVG of the icon. But it’s gonna be optional.

Actually this got me thinking that we need to make some template so that icons are reasonable. @corwinharrell may you help with that so that @chadoh can include it in standard?

@corwinharrell @vgrichina I added the 'default' token icon, please see below. However, how do we know when to use a provided symbol vs the current default? Considering symbol could be either a string (BANANA or wNEAR), or generally supported icons  (🥑)?
Seems we might have to maintain a list (with icons) on our end if we want to maintain consistency and quality?

@corwinharrell @vgrichina I added the 'default' token icon, please see below. However, how do we know when to use a provided symbol vs the current default? Considering symbol could be either a string (BANANA or wNEAR), or generally supported icons (🥑)?
Seems we might have to maintain a list (with icons) on our end if we want to maintain consistency and quality?

@Patrick1904 see https://github.com/near/near-wallet/discussions/1530
I believe token contracts will now have an option for a "Symbol" (abbreviation) and an "Icon".

@vgrichina What is the middle token in the prototype? If no symbol/name is provided, do you have any ideas on what we should display in order to identify it?

@Patrick1904 see #1530
I believe token contracts will now have an option for a "Symbol" (abbreviation) and an "Icon".

I see, yea it would work for some generally supported icons like 🥑.

@Patrick1904 see #1530
I believe token contracts will now have an option for a "Symbol" (abbreviation) and an "Icon".

@corwinharrell I see, that should work. I'll update so that we use icon if provided and otherwise use the default fallback icon

@vgrichina What is the middle token in the prototype? If no symbol/name is provided, do you have any ideas on what we should display in order to identify it?

it is berry farm token (cucumber) incompatible with latest standard
that's actually a pretty good question – what should be do with tokens that we couldn't load. I assume best probably just to hide them? Or maybe only show on successful load.

it is berry farm token (cucumber) incompatible with latest standard
that's actually a pretty important question – what should be do with tokens that we couldn't load. I assume best probably just to hide them? Or maybe only show on successful load.

We risk having users contacting our support team if they have some of their tokens disappear. What about showing an error instead of the amount? This would redirect them to the token creators, asking why they don't update the standard.
Alternatively, give the option to do a pull request on a very specific Json file, such that they can override the parameters we parse from the contract?

We risk having users contacting our support team if they have some of their tokens disappear. What about showing an error instead of the amount? This would redirect them to the token creators, asking why they don't update the standard.
Alternatively, give the option to do a pull request on a very specific Json file, such that they can override the parameters we parse from the contract?

ultimately there is going to be hundreds of different contracts that user interacted with, but only some of them would implement token standard
so I'm leaning towards just showing only once successfully loaded I guess. For next iteration can cache the successful one in local storage so that UI is less glitchy

@vgrichina @Patrick1904 cool I'm in favor of omitting contracts that don't implement the token standard.

ultimately there is going to be hundreds of different contracts that user interacted with, but only some of them would implement token standard
so I'm leaning towards just showing only once successfully loaded I guess. For next iteration can cache the successful one in local storage so that UI is less glitchy

I try to formulate again my answer:

I'm good with not listing tokens that don't follow the standards and can't be loaded properly
I'm worried if we disable tokens mid-flight, after the user has seen them in the wallet and used them

The former is totally good and makes 100% sense, and it is good if it can also prevent the latter.

I second this one, as mentioned in today's meeting. Do you have the list handy, to copy/paste it here already?
Will post it here once it's ready

{
  "erc20": [
    { "name": "USDT",  "address": "0xdac17f958d2ee523a2206206994597c13d831ec7" },
    { "name": "UNI",   "address": "0x1f9840a85d5af5bf1d1762f925bdaddc4201f984" },
    { "name": "LINK",  "address": "0x514910771af9ca656af840dff83e8264ecf986ca" },
    { "name": "USDC",  "address": "0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48" },
    { "name": "WBTC",  "address": "0x2260fac5e5542a773aa44fbcfedf7c193bc2c599" },
    { "name": "AAVE",  "address": "0x7Fc66500c84A76Ad7e9c93437bFc5Ac33E2DDaE9" },
    { "name": "CRO",   "address": "0xa0b73e1ff0b80914ab6fe0444e65848c4c34450b" },
    { "name": "FTT",   "address": "0x50d1c9771902476076ecfc8b2a83ad6b9355a4c9" },
    { "name": "CHZ",   "address": "0x3506424f91fd33084466f402d5d97f05f8e3b4af" },
    { "name": "BUSD",  "address": "0x4Fabb145d64652a948d72533023f6E7A623C7C53" },
    { "name": "HT",    "address": "0x6f259637dcd74c767781e37bc6133cd6a68aa161" },
    { "name": "DAI",   "address": "0x6b175474e89094c44da98b954eedeac495271d0f" },
    { "name": "SUSHI", "address": "0x6b3595068778dd592e39a122f4f5a5cf09c90fe2" },
    { "name": "SNX",   "address": "0xc011a73ee8576fb46f5e1c5751ca3b9fe0af2a6f" },
    { "name": "GRT",   "address": "0xc944e90c64b2c07662a292be6244bdf05cda44a7" },
    { "name": "MKR",   "address": "0x9f8f72aa9304c8b593d555f12ef6589cc3a579a2" },
    { "name": "COMP",  "address": "0xc00e94cb662c3520282e6f5717214004a7f26888" },
    { "name": "LEO",   "address": "0x2af5d2ad76741191d15dfe7bf6ac92d4bd912ca3" },
    { "name": "MATIC", "address": "0x7D1AfA7B718fb893dB30A3aBc0Cfc608AaCfeBB0" },
    { "name": "ENJ",   "address": "0xf629cbd94d3791c9250152bd8dfbdf380e2a3b9c" }
  ]
}

@djsatok we are building a wallet for NEAR though, so need to know corresponding contract names on NEAR :-P
In any case I propose on Monday we just launch this with hardcoded list of tokens that work for sure (wrapped NEAR, bananas, whatever else get bridged initially from ETH) as https://github.com/near/near-wallet/pull/1377 release gonna already be pretty complicated logistically.

@vgrichina updated the list above (something out, something in)
The naming of the bridged tokens was fixed by @corwinharrell already. Just add n in the end. So bridged DAI should be referred to as DAIn.

@vgrichina updated the list above (something out, something in)
The naming of the bridged tokens was fixed by @corwinharrell already. Just add n in the end. So bridged DAI should be referred to as DAIn.

I believe it's actually the other way around. @chadoh can you confirm and perhaps lay out the naming system that we landed on somewhere as a reference with examples?

@vgrichina updated the list above (something out, something in)
The naming of the bridged tokens was fixed by @corwinharrell already. Just add n in the end. So bridged DAI should be referred to as DAIn.

I believe it's actually the other way around. @chadoh can you confirm and perhaps lay out the naming system that we landed on somewhere as a reference with examples?

I also like nDAI more, if it counts. DAIn is used in the FE at the moment, but we can update it.

Here's the full results from the polls during my ETHDenver talk: poll results.pdf
Relevant poll:

As you can see, 10 of 14 respondees wanted nDAI or nDAI21.
(The first poll here also had a fairly strong signal from the participants. Most people feel ok about using the phrase "bridged NEP141" to describe "tokens which are currently NEP141s on NEAR but which started their lives as ERC20s on Ethereum.")

@djsatok we are building a wallet for NEAR though, so need to know corresponding contract names on NEAR :-P

I think @vgrichina may have been asking for NEAR contract addresses here, since only Ethereum contract addresses were given.

I did a run on Testnet at the link https://near-wallet-pr-1512.onrender.com/ and it's not showing balances. Hope it helps

I did a run on Testnet at the link https://near-wallet-pr-1512.onrender.com/ and it's not showing balances. On mainnet it works normally. Hope it helps

it cannot work on testnet because there are no corresponding token contracts on testnet

@vgrichina in order to get any ERC20 token address, one can call the view method of the connector contract (factory.bridge.near): get_bridge_token_account_id. It consumes the ERC20 address without 0x.
At the moment corresponding accounts are deployed using the following pattern: <ERC20address>.factory.bridge.near, but this can potentially change, so there's a view call.
For example, nDAI AccountId is: 6b175474e89094c44da98b954eedeac495271d0f.factory.bridge.near

{ "name": "COMP",  "address": "0xc00e94cb662c3520282e6f5717214004a7f26888" },
{ "name": "YFI",   "address": "0xc00e94cb662c3520282e6f5717214004a7f26888" },

Please fix YFI address here. Correct one is 0x0bc529c00c6401aef6d220be8c6ea1667f6ad93e regarding https://tokenlists.org/token-list?url=defi.cmc.eth


modules/audio_processing/vad porting

Thanks for the good project!
I'm new to VAD. Seems like this folder modules/audio_processing/vad also includes some vad related codes. is it? if yes, are you planning to port that part too?
Also wonder to know if you want to write some python binding examples or not. People can easily manipulate this library. :-)

I haven't looked into modules/audio_processing/vad much, but it might be useful. Apparently it combines the VAD engine with another detector (PitchBasedVad) for better results.
I'm not planning to write python bindings at the moment (not using Python much). But there is also https://github.com/wiseman/py-webrtcvad which is a python package that wraps the same WebRTC VAD code.


Review AMPQ client/server node library RHEA

Gordon Sim has asked if we could provide him any feedback/comments on https://github.com/grs/rhea the AMPQ node library he's developed.

Looks good @helio-frota. Thanks!
I've updated the GUIDELINES.md document to address some of your points in the 'Code' and 'Style' sections here. https://github.com/bucharest-gold/entente/blob/master/GUIDELINES.md#some-things-linting-will-catch
@grs Helio has looked through your code and found a number of issues related to our "standard" recommendations for node projects. Have a look here, and we'd be happy to discuss with you.
Thanks!

'Some things linting will catch'
true !
@lance :+1:

Thanks! I'll start going through these soon (I'm on PTO from 21st for a bit, so will likely be when I get back).

This looks like it can be closed. Or is there more that needs to be done here?

Yeah, I think this can be closed.  @grs if you would like more help or reviews just open/re-open an issue and ping us on the mailing list!


.NET Core support?

This is a good tracking issue, thanks for filing it. We would definitely like to support .NET core, we just need to determine if it has everything we need at this point (reflection, il generation, etc)

any news or updates here?

Hi,
On the community meeting yesterday on gitter, it was mentioned that it’s in the works, but most probably, it will need .NET Core 1.1 or 1.2 due to missing APIs in .NET Core 1.0.
Best regards
Markus Schaber
CODESYS® a trademark of 3S-Smart Software Solutions GmbH
Inspiring Automation Solutions

3S-Smart Software Solutions GmbH
Dipl.-Inf. Markus Schaber | Product Development Core Technology
Memminger Str. 151 | 87439 Kempten | Germany
Tel. +49-831-54031-979 | Fax +49-831-54031-50
E-Mail: m.schaber<EMAIL_ADDRESS>| Web: codesys.comhttp://www.codesys.com | CODESYS store: store.codesys.comhttp://store.codesys.com
CODESYS forum: forum.codesys.comhttp://forum.codesys.com
Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915

This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received
this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure
or distribution of the material in this e-mail is strictly forbidden.
From: matthiasburger<EMAIL_ADDRESS>Sent: Thursday, September 01, 2016 3:31 PM
To: IronLanguages/ironpython3
Subject: Re: [IronLanguages/ironpython3] .NET Core support? (#77)
any news or updates here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/IronLanguages/ironpython3/issues/77#issuecomment-244078919, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA5XOh-Gp_7p7gsSRM3BgP5ZL6dLoRNVks5qltOEgaJpZM4JQVIf.

@markusschaber 3 months later .NET Core 1.2 comes closer. Is there any update at this point?

To be honest, I don't know - I'm not currently working actively on IronPython. :-(

@rogersachan I did some work on the IP2.7 branch to try and get it working (and it mostly did) but there are just too many missing APIs with netstandard1.6. We plan to support whatever version of .NET Core implements netstandard2.0.

Any plans to get something like a beta release for testing purposes?

We're still working on all the parser updates and so forth to bring the code in line with CPython 3.x.

@slide Is there any assumption about the release date?

I wish I could give you a date. I think we've realized that there is more than we expected to implement. In addition, we would wait for .NET Standard 2.0

So, referring to this - https://github.com/dotnet/core/blob/master/roadmap.md
after spring 2017

@pekunicki Like @slide mentioned, given the amount of work left to be done on IronPython 3.0 I don't think we're at a point where we can even guess at a release date. It's more than likely that .NET Standard 2.0 will be ready before IronPython 3.0 in which case the first release will support .NET Core.

@slozier it seems netstandard 2.0 will happen together with VS2017 RTM in march. Is there hope that we could see IronPython 2.7 on Core some time after that?

@vivainio Yes, IronPython 2.7 should be no problem, we should have some sort of beta release soon after VS2017 RTM.

@slozier Any update on .Net core suppport now that VS2017 is out?

@JoshMcclung We're still waiting for .NET Core 2.0. I had hoped it would come with the VS2017 release but it didn't. Maybe they'll announce something at Build this week?

FYI: https://blogs.msdn.microsoft.com/dotnet/2017/05/10/announcing-net-core-2-0-preview-1/

For those interested in helping work out the kinks: https://github.com/IronLanguages/main/pull/1645

So .net core 2.0 was released 2 months ago. :) any updates here?

If you are asking about IronPython2 I assume this will be in the upcoming release.
But @slide can probably confirm that.
If you are asking about IronPython3 I have a pending PR that I need to finish soon.
However, IronPython3 has other items to be done before a release.
I guess if you have time you can contribute to it as well.

@gpetrou nope I was asking about IronPython3.  Okay, yep, I got time.

Great! Maybe @slide or @slozier can give you some specific IronPython3 issues to work on.

I can add some "entry-level" tags to some issues. I'll try and do that today.

@slide you already added some tags? can't find any.

I had a family emergency come up and won't be able to until next week. My apologies.

@slide family is most important - best hopes that it's not too serious!

Should we close this now since the .NET Core changes were merged?
@matthiasburger there are some issues you can take a look at in https://github.com/IronLanguages/ironpython3/issues?q=is%3Aissue+is%3Aopen+label%3A"good+first+issue"

.NET core support has been merged.


amend: reverted eslint

:tada: This PR is included in version 1.10.184 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


T191661 add api type missing field

Looks like we should check the tests

Fixed tests. Needed to update regions in destinations tests


Added controller to add OCI fault domain label to node

This PR is to add a controller to add the OCI fault domain label to each node added to the cluster. The controller is run as a Go routine from the ccm.go file.
Also, oracle-oci-sdk has to be updated to version "19.4.0" to enable the working of this feature

I have made the suggested changes, please tell me if I need to make any more

A sample of the resultant node labels with the new label "oci.oraclecloud.com/fault-domain" showing the required information.


feat: store multiple tokens

Token management for #3273

Update PersistantState schema to have a list of saved tokens for multiple accounts
Create migrations for the same

@Prakhar-Agarwal-byte unit tests are failing, it expects the new schema. Can you fix that?

I think this PR should also be merged first: https://github.com/GaloyMoney/blink-mobile/pull/3122
Before we think of multiple token, we need to make storing tokens safer

I will do a thorough testing on logged in phones / non logged in phones and verify the user is not logged out before merging.

Verified and merged!


4.0 Beta 3 - Custom Checkboxes Are Unclickable Without ID on Input Element

In updating my Beta 2 code to Beta 3, one of the breaking changes concerns custom checkboxes.
Consider the following:

<input type="checkbox" name="chbxTerms" class="custom-control-input" tabindex="5" data-rule-required="true" data-msg-required="You must accept the Terms and Conditions before logging in">
 I have read and accept the

Terms and Conditions of use for this site.

Last accepted: 01/02/18 12:46:44 PM

Without an ID on the input, the checkbox is unclickable. Adding the ID (and referencing it in the for= attribute on the label restores this functionality. While the example docs do show an ID, this was not required by custom checkboxes in Beta 2 and should be noted.
Also, the documentation still refers to a span tag which is no longer used in custom checkboxes.
See the example Pen: https://codepen.io/Joyrex/pen/qpjvVx
Add id="chbxTerms" to the input element and the checkbox becomes clickable.
Originally discovered in Chrome 64 Windows 10 64-bit, but also in Chrome mobile (iOS) and Safari Mobile (iOS 11.2)

If you want the same behavior without having to use id for your inputs, just make the "custom-control" classed element the
e.g., your pen:
https://codepen.io/anon/pen/VyWNoe

Thanks! Works with BS 4.3.1.
But there is a little mistake in your example code, the second last  must be a .
Another example:

    <input type="checkbox" class="custom-control-input">

      fancy label for fancy checkbox

Happy coding.


"Import of study failed: Unpacking ZIP archive failed" on upload of study from OpenSesame/OSWeb

On a fresh install of JATOS 3.9.3 on Rocky Linux 8.10, I get the above error when trying to upload a study from OpenSesame, and the study is not created. If I explicitly set the temporary file path in jatos.conf:
jatos.tmpPath="/tmp"

the study is created as expected.

I just tried JATOS v3.9.3 with Rocky Linux 8.9 running in a Docker container (there doesn't seem to be a version 8.10 (?) according to https://dl.rockylinux.org/vault/rocky/ or https://hub.docker.com/_/rockylinux) and got it working without setting jatos.tmpPath in jatos.conf. Is there something I have to do to replicate the issue?


Rework JsonObject [WIP]

This PR makes a few API changes, including renaming fields methods that return the keys in a JSON object to keys, since we typically use "fields" to refer to the key-value pairs. These changes are all behind deprecations, so existing code won't break (for that reason). Several methods that previously returned Vector now return Iterable (which is a breaking change).
There are much more major non-public changes. I've added a JsonObject implementation based on Java's LinkedHashMap, and have rearranged the logic for printing JSON objects so that each of the two implementations can iterate over fields without unnecessary tuple allocations.
Note that by default new JsonObject values parsed by circe-jawn or built with fromIterable (or methods that call it, such as Json.obj) will use the LinkedHashMap implementation, which provides faster lookups and iteration. Calling methods like add or remove on these values will return instances of the old Map-plus-Vector implementation, which performs much better in situations where you're creating lots of "modified" (immutable) instances.
Note that it is impossible to modify the LinkedHashMap once a JsonObject value is created, of course.
The performance impact of this change is pretty remarkable—here are results from circe-benchmarks for this PR (ecfa11f; new) vs. the current master (6e17272; old):
Benchmark                              Mode  Cnt      Score      Error  Units
WritingBenchmark.writeFoosCirce (new) thrpt   10   3709.391 ±   10.734  ops/s
WritingBenchmark.writeFoosCirce (old) thrpt   10   3159.032 ±   48.561  ops/s
WritingBenchmark.writeFoosSpray       thrpt   10   3134.276 ±   16.775  ops/s
WritingBenchmark.writeFoosArgonaut    thrpt   10   2516.612 ±   20.082  ops/s
WritingBenchmark.writeFoosPlay        thrpt   10   1377.191 ±   24.037  ops/s
WritingBenchmark.writeFoosJson4s      thrpt   10   1061.630 ±    4.737  ops/s

Benchmark                              Mode  Cnt      Score      Error  Units
ReadingBenchmark.readFoosCirce (new)  thrpt   10   3578.396 ±   16.370  ops/s
ReadingBenchmark.readFoosCirce (old)  thrpt   10   2762.956 ±   55.975  ops/s
ReadingBenchmark.readFoosSpray        thrpt   10   2167.750 ±    8.348  ops/s
ReadingBenchmark.readFoosArgonaut     thrpt   10   1340.159 ±   24.207  ops/s
ReadingBenchmark.readFoosJson4s       thrpt   10   1270.613 ±    3.686  ops/s
ReadingBenchmark.readFoosPlay         thrpt   10   1249.330 ±   20.976  ops/s

I haven't added new tests since it seems like the current tests should exercise the new implementation pretty well, but we should check that.

Codecov Report

Merging #696 into master will increase coverage by 0.12%.
The diff coverage is 93.06%.

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   86.29%   86.41%   +0.12%
==========================================
  Files          71       71
  Lines        2203     2253      +50
  Branches       94       96       +2
==========================================
+ Hits         1901     1947      +46
- Misses        302      306       +4

Impacted Files
Coverage Δ

.../shared/src/main/scala/io/circe/FailedCursor.scala
30% <0%> (+2.72%)
:arrow_up:

.../core/shared/src/main/scala/io/circe/Decoder.scala
90.65% <100%> (ø)
:arrow_up:

.../main/scala/io/circe/jawn/CirceSupportParser.scala
96.55% <100%> (-0.33%)
:arrow_down:

.../src/main/scala/io/circe/cursor/ObjectCursor.scala
50% <100%> (-3.85%)
:arrow_down:

...re/shared/src/main/scala/io/circe/MapDecoder.scala
87.23% <100%> (ø)
:arrow_up:

...scala/io/circe/shapes/LabelledHListInstances.scala
100% <100%> (ø)
:arrow_up:

.../core/shared/src/main/scala/io/circe/Printer.scala
95.97% <100%> (-0.32%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/HCursor.scala
80% <100%> (+0.45%)
:arrow_up:

...a/io/circe/shapes/LabelledCoproductInstances.scala
100% <100%> (ø)
:arrow_up:

.../core/shared/src/main/scala/io/circe/ACursor.scala
53.33% <50%> (-0.16%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e17272...ecfa11f. Read the comment docs.


Title deduplication wrongly uses parent title

Describe the bug
If the parent component declares a title after the child component tag, then the parent component's title is used instead of the child component's.
According to @Conduitry in https://github.com/sveltejs/kit/issues/2009#issuecomment-886740203 the title of the deepest child component should be used instead.

<title> is replaced by lower-level components

Reproduction
See https://github.com/vwkd/sveltekit-bugs/tree/wrong-title
This example uses probably the most common case where the parent component is the layout component and the child component is the index component. But the issue occurs for any parent and child component pair.
Logs
No response
System Info
System:
    OS: macOS 11.5
  Binaries:
    Node: 16.6.0 - ~/.nvm/versions/node/v16.6.0/bin/node
    npm: 7.19.1 - ~/.nvm/versions/node/v16.6.0/bin/npm
  Browsers:
    Chrome: 92.0.4515.131
    Firefox: 90.0.2
    Safari: 14.1.2
  npmPackages:
    @sveltejs/adapter-static: ^1.0.0-next.11 => 1.0.0-next.16
    @sveltejs/kit: next => 1.0.0-next.142
    svelte: ^3.34.0 => 3.42.1

Severity
annoyance
Additional Information
No response

Duplicate of https://github.com/sveltejs/kit/issues/1540


convergenceThreshold=0 not honoured

I'm trying to do a "worst case" benchmark of antsRegistration for some job scripting by specifying a convergence threshold of 0 to ensure all iterations of of set of stages execute.
On some of my inputs, this seems to work as expected, but on others it doesn't.
Is there some other condition overriding the convergence stoppage?

No (not considering system issues, e.g., excessive memory consumption).

Set to -inf
On Friday, June 17, 2016, Nick Tustison<EMAIL_ADDRESS>wrote:

No (not considering system issues, e.g., excessive memory consumption).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stnava/ANTs/issues/332#issuecomment-226815362, or mute
the thread
https://github.com/notifications/unsubscribe/AATyfhb3TUnraDdLpEJ9km9a0rj8EU1Dks5qMspZgaJpZM4I4f-n
.

--
brian

Sadly, both -inf and -Inf break the command-line parser:
itk::ExceptionObject (0x3eb6e70)
Location: "unknown"
File: /opt/quarantine/ANTs/git/src/ANTs/Utilities/antsCommandLineParser.h
Line: 126
Description: itk::ERROR: CommandLineParser(0x3e481e0): ERROR: Parse error occured during command line argument processing
ERROR: Unable to convert '-inf' to type 'd' as double

Looks like -1 forces it to do all iterations.

Not necessarily.  That simply means that the convergence threshold value didn't go to -1.

Okay, so the question remains, how can I force a given number of iterations?

Specify a large convergence threshold value.

A large negative value.


warning<EMAIL_ADDRESS>needed

Hi
How to solve this problem?
I seem out of this error, the page is constantly overloaded
eg here http://new.life2film.com/f/v7ecEcHurdEsjrua5
`W20160706-18:52:55.666(5)? (STDERR) WARNING: npm peer requirements (for reactrouter:react-router-ssr) not installed:
W20160706-18:52:55.666(5)? (STDERR)  -<EMAIL_ADDRESS>installed<EMAIL_ADDRESS>needed
W20160706-18:52:55.666(5)? (STDERR)
W20160706-18:52:55.667(5)? (STDERR) Read more about installing npm peer dependencies:
W20160706-18:52:55.667(5)? (STDERR)   http://guide.meteor.com/using-packages.html#peer-npm-dependencies
W20160706-18:52:55.667(5)? (STDERR)
W20160706-18:52:58.206(5)? (STDERR) Warning: Material-UI: userAgent should be supplied in the muiTheme context
W20160706-18:52:58.206(5)? (STDERR)       for server-side rendering.
`

I don't think you can solve it, but if you use NPM > 3 then that error becomes a warning and you can still run the app fine.


Summary screen should show to what cluster is my app being deployed

Closed because a new react based frontend is now available.


add support of miRNA data to BDGP6

Hi,
here my PR to add support of miRNA analysis with BDGP6 genome.
Related to this bcbio issue #3112  and PR to the cloudbiolinux https://github.com/chapmanb/cloudbiolinux/pull/344

Thanks so much!


how to get class hash

What happened
i declareContract need signature
signature need get txhash
txhash   need "TransactionHashCalculator.calculateDeclareV1TxHash()". need classhash
`        Path contractPath = Paths.get(Resources.getResource("Account.json").getPath());
String contract = "";
String address = "";
try {
contract = String.join("", Files.readAllLines(contractPath));
// Deploy a contract
Cairo0ContractDefinition contractDefinition = new Cairo0ContractDefinition(contract);
Felt addressNonce = new Felt(getAddressNonce(MAIN_ADDRESS).longValue());
Felt senderAddress = Felt.fromHex(MAIN_ADDRESS);
DeclareTransactionV1Payload payload = new DeclareTransactionV1Payload(contractDefinition,Felt.ONE, addressNonce,null,senderAddress,Felt.ONE);
DeclareResponse rpcResponse = provider.declareContract(payload).send();
        TransactionHashCalculator.calculateDeclareV1TxHash()
        Felt newContractAddress = rpcResponse.getClassHash();
        address = newContractAddress.hexString();
    } catch (IOException e) {
        logger.error("deployContract Exception {} ",e);
        throw new ServerException(e.getMessage());
    }`

why not Cairo0ContractDefinition classhash

Stack trace
no trace
Steps to reproduce

i declareContract need signature
signature need get txhash
txhash   need "TransactionHashCalculator.calculateDeclareV1TxHash()". need classhash

SDK Version
0.6.2
Language
Java
Language
n/a
Language version
java11
What operating system are you using?
Mac
Is there an existing issue for this?

[X] I have searched the existing issues and verified no issue exits for this problem.

Hi @popeye2022
Sadly, we do not currently have plans to support class hash calculation for contracts written in Cairo 0. The reason behind this is the fact that Cairo 0 will soon be deprecated.
We strongly advice you to write contracts in Cairo 1. However, if migration is not possible, you will need to compute the class hash for Cairo 0 contracts yourself. One way you could do it is by using starknet.py. Here's some example code:
from starknet_py.contract import Contract
import os

def full_path(relative_path):
    cur_dir = os.path.dirname(os.path.realpath(__file__))
    return os.path.join(cur_dir, relative_path)

def main():
    contract_path = full_path("Account.json")
    with open(contract_path, "r") as f:
        compiled_cairo0_contract_json = f.read()

    class_hash = Contract.compute_contract_hash(compiled_cairo0_contract_json)

    print(hex(class_hash))

if __name__ == "__main__":
    main()

Sorry for inconviniece and let me know if you have any other questions.

https://github.com/OpenZeppelin/cairo-contracts/blob/cairo-2/src/openzeppelin/account/account.cairo
i use openzeppelin source code and compile
if i use DeclareTransactionV1 will has error
com.swmansion.starknet.data.types.Cairo1ContractDefinition$InvalidContractException: Attempted to parse an invalid contract. Missing key: sierra_program

(env) root@d5ef6e9dd96d:/cairo-contracts/artifacts# python ./starknet.py
Traceback (most recent call last):
File "/cairo-contracts/artifacts/./starknet.py", line 1, in
from starknet_py.contract import Contract
ModuleNotFoundError: No module named 'starknet_py'
(env) root@d5ef6e9dd96d:/cairo-contracts/artifacts# python3.9 ./starknet.py
Traceback (most recent call last):
File "/cairo-contracts/artifacts/./starknet.py", line 1, in
from starknet_py.contract import Contract
ModuleNotFoundError: No module named 'starknet_py'
(env) root@d5ef6e9dd96d:/cairo-contracts/artifacts#

Hopefully the exact steps to deploy an account are now clear as the instruction was added to docs: https://github.com/software-mansion/starknet-jvm/pull/287
As for class hash, there are no plans to support class hash calculation for contracts written in Cairo 0. As for deployAccount, you can look up class hashes for existing account contracts on Starknet address book for the needed network:
https://testnet.starkscan.co/address-book
https://testnet-2.starkscan.co/address-book
https://starkscan.co/address-book


Add flag for backward compatibility with TLS checks

In #392, we added stronger TLS checks for cluster gossip to prevent an unintended node from connecting. The behavior might be unexpected for some of consumers (using older versions of Garnet) as this would mean specifying the ClusterTlsClientTargetHost parameter which they might've missed earlier as it was not validated in all scenarios - it was behind a ClientCertificateRequired flag. This flag also implied that server cert was also not validated when Garnet acted as a client in gossip scenarios.
But to maintain backward compatibility we're adding another flag to enable the stronger TLS checks conditionally. However, it should be recommended that this is turned on to prevent unexpected cluster connections.

For Garnet server, is there a good reason to even expose this flag?


pipx list crashes after upgrade from <IP_ADDRESS> to <IP_ADDRESS>

I am running python 3.6.8 on macOS; my python is provided by pyenv.
i installed pipx with pip install --user pipx in the base interpreter at version <IP_ADDRESS> and have been using it happily.
Today, i pip install --upgrade pipx and bumped pipx to <IP_ADDRESS>.
Attempting to run pipx list results in:
$ pipx list
venvs are in /Users/graham/.local/pipx/venvs
apps are exposed on your $PATH at /Users/graham/.local/bin
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 119, in worker
    result = (True, func(*args, **kwds))
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar
    return list(map(*args))
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/site-packages/pipx/commands/common.py", line 124, in get_package_summary
    package_metadata = venv.package_metadata[package]
KeyError: 'isort'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/graham/.pyenv/versions/3.6.8/bin/pipx", line 11, in <module>
    sys.exit(cli())
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/site-packages/pipx/main.py", line 580, in cli
    return run_pipx_command(parsed_pipx_args)
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/site-packages/pipx/main.py", line 184, in run_pipx_command
    return commands.list_packages(venv_container)
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/site-packages/pipx/commands/list_packages.py", line 29, in list_packages
    for package_summary in p.map(get_package_summary, dirs):
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 266, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 644, in get
    raise self._value
KeyError: 'isort'

Quoting the release note of <IP_ADDRESS>:

When upgrading to <IP_ADDRESS> or above from a pre-<IP_ADDRESS> version, you must re-install all packages to take advantage of the new persistent pipx metadata files introduced in this release. These metadata files store pip specification values, injected packages, any custom pip arguments, and more in each main package's venv. You can do this by running pipx reinstall-all or pipx uninstall-all, then reinstalling manually.

I wonder if we can detect these types of errors and print a message directing them to this release notes instead of a raw stack trace.

@cs01 that would be good.  @uranusjr  is correct about the cause, but the crash was deeply unintuitive and it'd be nice to have that cleaned up a bit.

Let's leave this open as a TODO for printing a more intuitive error when migrating to 0.15. The fix should be pretty straight forward -- just a try/except in the right place.

@cs01 sure.  if you point me at the right general area, i can see if i have cycles to get a PR out.

I believe the stack trace in your original issue points to it:
  File "/Users/graham/.pyenv/versions/3.6.8/Python.framework/Versions/3.6/lib/python3.6/site-packages/pipx/commands/common.py", line 124, in get_package_summary
    package_metadata = venv.package_metadata[package]
KeyError: 'isort'

@itsayellow is this the best way to detect an upgrade is required?

I think the best way to detect a missing metadata file is if package_metadata.main_package.package is None.
Ah I see we do not print the warning from a missing metadata file in pipx_metadata_file.py unless verbose is turned on:
https://github.com/pipxproject/pipx/blob/46acc8590b843ccf32a50da0502b0dda64269dae/src/pipx/pipx_metadata_file.py#L147
I think I might vaguely remember turning that warning off for non-verbose operation, possibly for times when you are creating a new venv?

Actually I take that back, currently that won't work.  Currently venv.py Venv.package_metadata(self) just skips the main package if it finds main.package.package is None when it is filling in the @property package_metadata for a Venv.
I think what would currently work is to test if not venv.package_metadata.  With no metadata file venv.package_metadata would be an empty dict.
Another possible solution is a two-step change where Venv.package_metadata(self) gets an else clause to its if self.pipx_metadata.main_package.package is not None: that would assign None to the package_metadata member, which would allow testing for None in any calling function to show no metadata file.

Is what you're looking for just a note (like the note for missing python version)?  If so, I can make a PR.

We should never print a bare stack trace to the user. That should always be replaced with an actionable error message. What I would like is for pipx list to look something like this:
> pipx list
pipx has added additional metadata in v15.0.0, which is a breaking change for existing packages. Since this is your first time running after the upgrade, you must reinstall or upgrade your packages to continue:
  `pipx reinstall-all` or
  `pipx uninstall-all`, then reinstall manually.

So basically stop the entire list process.  (Not a warning for each package.)
OK, let me see what I can do!

Or should we detect this for any/all other pipx commands?

So basically stop the entire list process. (Not a warning for each package.)

That would be ideal, but I wouldn't spend too much time on this. Avoiding the bare stack trace is the most important thing, and getting the user actionable info.

Or should we detect this for any/all other pipx commands?

Yes if you don't mind.

It's very easy to fix on a per-venv basis, mostly because otherwise we'd have to check all the packages before printing anything to see if one of them was problematic.
How about something like this:

Looks good to me! That probably makes more sense anyway to check it individually.

cheers!  thanks for the super fast turnaround and a great project.
quick unrelated question -- coming from 14.0, is there a way to pregenerate a list of all my injected packages so that reinstall-all handles it properly after i move to 15.x? (I have a very heavily modified ipython and it'd be convenient to still have the package suite after the reinstall.  that said, grepping through my shell history isn't the worst thing in the world)

The only thing that comes to my mind is:
pipx runpip ipython list

It will give you everything installed to that venv, including all dependencies.  But included in that list will be the packages you injected.

Of course you'd still have to manually inject everything yourself.
This, of course, is the reason we added metadata in the first place.  Once you are setup with a new pipx version, commands like reinstall-all happen automatically, with injected packages and everything.

Yeah, that makes sense that it'd be a 1-time deal.
I think this gets to what I proposed some time ago in https://github.com/pipxproject/pipx/issues/109 , so that might/should be revisited as a result of the current metadata feature?


Out of memory after activating Blaze-Permission

Description
After activating BP i get a OOM heap exception on a test.
This tests writes about 70k records batched:

    Lists.partition(allPermissions, 1000).forEach(chunk -> {
      entityManager.flush();
      entityManager.clear();
      chunk.forEach(entityManager::persist);
    });

allPermissions is a Collection of PermissionCache` entries looking like this
@Entity
@Data
@EqualsAndHashCode(onlyExplicitlyIncluded = true)
@NoArgsConstructor(access = AccessLevel.PRIVATE)
@AllArgsConstructor
public class PermissionCache
{
  @EmbeddedId
  @EqualsAndHashCode.Include
  PermissionCacheId permissionId = new PermissionCacheId();

  public PermissionCache(final Long spaceId, final Long uid)
  {
    this.permissionId.setSpaceId(spaceId);
    this.permissionId.setUid(uid);
  }
}

And the EmbeddedId is
@Data
@Embeddable
@EqualsAndHashCode(onlyExplicitlyIncluded = true)
public class PermissionCacheId implements Serializable
{
  @EqualsAndHashCode.Include
  @Column(name = "space_id", columnDefinition = "INT(11)")
  private Long spaceId;

  @EqualsAndHashCode.Include
  @Column(name = "uid", columnDefinition = "INT(11)")
  private Long uid;
}

I'am using batched writes with
useServerPrepStmts=false&rewriteBatchedStatements=true
on the JDBC URL and
spring.jpa.properties.hibernate.jdbc.batch_size=1000
# suppress inspection "SpringBootApplicationProperties"
hibernate.jdbc.batch_size=1000

In the properties
I understand that batch size can be one of the reasons here - but since that code has never thrown an OOM ever yet, and does so with BP, i suspect a memory leak we are yet not aware of
Expected behavior
Perform the same way as without BP
Actual behavior
OOM exception

  org.springframework.jdbc.datasource.init.UncategorizedScriptException: Failed to execute database script; nested exception is java.lang.OutOfMemoryError: Java heap space

  Caused by: java.lang.OutOfMemoryError: Java heap space

Full stacktace: https://dpaste.de/ociG
Steps to reproduce
Probably use the describe Entity with a simple JpaRepository (save/saveAll not overriden)
Write arround 70k entries batched in one session
Environment
Version: 9.9-snapshot based on non-HEAD #846
JPA-Provider: hibernate 5.4.5
DBMS: mariadb10.3
Application Server: spring boot 2.1.7

AFAICS blaze-persistence is not involved in this test, so the reason for this error has to be a different one. You will require a little more, but constant amount, of memory when using blaze-persistence because it has it's own metadata, but depending on your model, this would be at most a few MBs

@beikov i would love to believe that - but enable PB, test fails. disable BP test ist alright.
100% reproduceable, each and every time. I checked, the test yet never failed before BP was introduced ( several months ).
So i would really think there is something that happens which you did not expect to happen or something.
E.g. i would expect, since that is EM, that efter each flush, all batched entries are loaded - and that will most probably utilize the repo, but this one uses your new BPrepoFactory - so it might be involved here, could that be possible?

@JWGmeligMeyling i checked the maximum heap size and if i get this all right it is 8GB
java -verbose:sizes -version
  -Xmca32K        RAM class segment increment
  -Xmco128K       ROM class segment increment
  -Xmcrs200M      compressed references metadata initial size
  -Xmns2M         initial new space size
  -Xmnx939904K    maximum new space size
  -Xms8M          initial memory size
  -Xmos6M         initial old space size
  -Xmox3758016K   maximum old space size
  -Xmx3760064K    memory maximum
  -Xmr16K         remembered set size
  -Xlp:objectheap:pagesize=4K	 large page size
                  available large page sizes:
                  4K
  -Xlp:codecache:pagesize=4K	 large page size for JIT code cache
                  available large page sizes for JIT code cache:
                  4K
  -Xmso256K       operating system thread stack size
  -Xiss2K         java thread stack initial size
  -Xssi16K        java thread stack increment
  -Xss1M          java thread stack maximum size
openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)
Eclipse OpenJ9 VM AdoptOpenJDK (build openj9-0.15.1, JRE 11 Linux amd64-64-Bit Compressed References 20190717_286 (JIT enabled, AOT enabled)
OpenJ9   - 0f66c6431
OMR      - ec782f26
JCL      - fa49279450 based on jdk-11.0.4+11)

The test server has 14GB of ram, so most probabl 8GB could have been used.
On the other side i found out that running the test isolated ( test class or just the method ) i will not get the OOM - it seems when i run all integration tests in a suite this happens. What i would deduct is:

it might be a different tests and therefor other codebase being the reason for the OOM ( one that runs before )
it is harder to find out for me

Are you guys used to work with the core dumps?
JVMDUMP039I Processing dump event "systhrow", detail "java/lang/OutOfMemoryError" at 2019/09/20 21:10:37 - please wait.
JVMDUMP032I JVM requested System dump using '/dwcore_java/core.20190920.211037.175.0001.dmp' in response to an event
JVMDUMP010I System dump written to /dwcore_java/core.20190920.211037.175.0001.dmp
JVMDUMP032I JVM requested Heap dump using '/dwcore_java/heapdump.20190920.211037.175.0002.phd' in response to an event
JVMDUMP010I Heap dump written to /dwcore_java/heapdump.20190920.211037.175.0002.phd
JVMDUMP032I JVM requested Java dump using '/dwcore_java/javacore.20190920.211037.175.0003.txt' in response to an event
JVMDUMP010I Java dump written to /dwcore_java/javacore.20190920.211037.175.0003.txt
JVMDUMP032I JVM requested Snap dump using '/dwcore_java/Snap.20190920.211037.175.0004.trc' in response to an event
JVMDUMP010I Snap dump written to /dwcore_java/Snap.20190920.211037.175.0004.trc

The coredump is 1.3GB so fairly hard to share but maybe the Snap / javacore / heapdump ?
You would need

https://www.eclipse.org/mat/downloads.php
And there install https://help.eclipse.org/2019-03/index.jsp?topic=%2Forg.eclipse.mat.ui.help%2Ftasks%2FinstallDTFJ.html  since it is a phd not an hprof

I tried to open the heapdump but i could not due to
Parsing heap dump from '/home/em/Downloads/oom/heapdump.20190920.211037.175.0002.phd'
Eventhough i am able to open the format, it is recognised. I could run the test on a non openj0 jvm so we might have a usual hprof dump, but maybe you guys have a better / another idea.
Here are the heapdump/javacore and snap https://we.tl/t-riiWkh2Kyl

I was able to open the PHD, it just took long and should me the error from the previous try during that .. software...
Interestingly the coredump shows that about 280MB have been used, nothing about 8GB
Size: 270.5 MB Classes: 20.8k Objects: 5.3m Class Loader: 578
So i either missunderstand the heap size calculation or something else goes on.
Those are the openj9 flags i start the tests with:
  if (project.hasProperty('debug')) {
        jvmArgs = ["-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5007"]
    }

    // hide all the refelction access warnings during compile
    //allow embedded executer to modify environment variables
    jvmArgs += "--add-opens=java.base/java.util=ALL-UNNAMED"
    //allow embedded executer to inject legacy types into the system classloader
    jvmArgs += "--add-opens=java.base/java.lang=ALL-UNNAMED"

    // ****************************************************
    // ************* speed optimization *******************
    // ****************************************************
    jvmArgs += "-noverify"

    // ************************** openj9 only
    // openj9 only
    // start quicker

    jvmArgs += "-Xquickstart"
    // optimize for containers
    jvmArgs += "-Xtune:virtualized"
    // use shared cache
    jvmArgs += "-Xshareclasses:cacheDir=/tmp/cache -XX:SharedCacheHardLimit=200m -Xscmx100m "
``

I seem to not override the heap size at all?

with  “ java -XX:+PrintFlagsFinal -version | grep -iE 'HeapSize|PermSize|ThreadStackSize'” you should be able to view the heap size used, I doubt its 8GB, because your dump is much smaller. Let me try to open it in Jprofiler.

At least the first analysis shows involvment of BP:

i think that does not work with openj9 @JWGmeligMeyling
java -XX:+PrintFlagsFinal -version | grep -iE 'HeapSize|PermSize|ThreadStackSize'
openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)
Eclipse OpenJ9 VM AdoptOpenJDK (build openj9-0.15.1, JRE 11 Linux amd64-64-Bit Compressed References 20190717_286 (JIT enabled, AOT enabled)
OpenJ9   - 0f66c6431
OMR      - ec782f26
JCL      - fa49279450 based on jdk-11.0.4+11)

@beikov wth is com.blazebit.persistence.spring.data.base.repository.EntityViewAwareCrudMethodMetadataPostProcessor#INTERCEPTOR_CACHE?

I guess the issue is that references to EntityViewManager remain cached in com.blazebit.persistence.spring.data.base.repository.EntityViewAwareCrudMethodMetadataPostProcessor#INTERCEPTOR_CACHE. Every test case probably creates a new entity view manager instance. Since the entity view manager references all kind of stuff this accumulates a large memory footprint over time.
The cached com.blazebit.persistence.spring.data.base.repository.EntityViewAwareCrudMethodMetadataPostProcessor.CrudMethodMetadataPopulatingMethodInterceptor instances again hold references to the entity view manager - also a problem.

Seems a good use candidate for a WeakHashMap I think

Yes, using WeakHashMap here should fix it.

@Mobe91 sounds about very right, just checked the code too. I think due to the nature of the tests, that thing is just never freed and GC cannot handle, so it just sums up until it blows up the heap.
Still, also in a production env, this should get freed from time to time, otherwise this is pure addtive for the whole runtime - when i understand this correctly, doing X requests on a e.g. rest controller would create X EVM which then never get freed also, right?

Wow, was not even aware of a build in feature like https://docs.oracle.com/javase/7/docs/api/java/util/WeakHashMap.html .. nice learning and sounds about exactly what might be needed

But be careful, WeakHashMap is not thread-safe so it cannot be directly used to replace INTERCEPTOR_CACHE here.

@EugenMayer

Still, also in a production env, this should get freed from time to time, otherwise this is pure addtive for the whole runtime - when i understand this correctly, doing X requests on a e.g. rest controller would create X EVM which then never get freed also, right?

No, in a production environment you would typically have 1 instance of entity view manager per entity manager factory. So this should only cause issues in your test environment.

Couldnt we not just cleanup the EMV instance properly on context destoy?
ServletContextListener
with
public void contextDestroyed(ServletContextEvent event)
Or by registering to SessionFactoryObserver which is getting a signal on EMF.close AFAICs in org.hibernate.internal.SessionFactoryImpl#close

@JWGmeligMeyling
Actually, I do not think using a variant of WeakHashMap is sufficient here because the map values hold references to the entity view manager which prevents it to be garbage collected - so not map entries would be removed.

@EugenMayer
The entity manager view itself does not have a cleanup functionality so your only bet is to make the entity view manager instances finalizable by the garbage collector. For this, you would need to manually call clear() on the com.blazebit.persistence.spring.data.base.repository.EntityViewAwareCrudMethodMetadataPostProcessor#INTERCEPTOR_CACHE - assuming that this is the only place where entity manager view instances are cached. For the time being, you can obtain a reference to INTERCEPTOR_CACHE via reflection an clear it manually. That should fix it.

Ah yes, I forgot about the EVM references everywhere. I think this should address that:
diff --git a/integration/spring-data/base/src/main/java/com/blazebit/persistence/spring/data/base/repository/EntityViewAwareCrudMethodMetadataPostProcessor.java b/integration/spring-data/base/src/main/java/com/blazebit/persistence/spring/data/base/repository/EntityViewAwareCrudMethodMetadataPostProcessor.java
index 2ce085c75..0f5e2c98b 100644
--- a/integration/spring-data/base/src/main/java/com/blazebit/persistence/spring/data/base/repository/EntityViewAwareCrudMethodMetadataPostProcessor.java
+++ b/integration/spring-data/base/src/main/java/com/blazebit/persistence/spring/data/base/repository/EntityViewAwareCrudMethodMetadataPostProcessor.java
@@ -41,10 +41,12 @@ import org.springframework.util.ClassUtils;

 import javax.persistence.LockModeType;
 import javax.persistence.QueryHint;
+import java.lang.ref.WeakReference;
 import java.lang.reflect.Method;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.WeakHashMap;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;

@@ -59,7 +61,7 @@ import java.util.concurrent.ConcurrentMap;
  */
 public class EntityViewAwareCrudMethodMetadataPostProcessor implements RepositoryProxyPostProcessor, BeanClassLoaderAware {

-    private static final ConcurrentMap<EntityViewManager, MethodInterceptor> INTERCEPTOR_CACHE = new ConcurrentHashMap<>();
+    private static final Map<EntityViewManager, MethodInterceptor> INTERCEPTOR_CACHE = Collections.synchronizedMap(new WeakHashMap<>());
     private final MethodInterceptor interceptor;
     private ClassLoader classLoader = ClassUtils.getDefaultClassLoader();

@@ -119,10 +121,10 @@ public class EntityViewAwareCrudMethodMetadataPostProcessor implements Repositor
     private static final class CrudMethodMetadataPopulatingMethodInterceptor implements MethodInterceptor {

         private final ConcurrentMap<EntityViewMetadataCacheKey, EntityViewAwareCrudMethodMetadata> metadataCache = new ConcurrentHashMap<>();
-        private final EntityViewManager evm;
+        private final WeakReference<EntityViewManager> evmReference;

         private CrudMethodMetadataPopulatingMethodInterceptor(EntityViewManager evm) {
-            this.evm = evm;
+            this.evmReference = new WeakReference<>(evm);
         }

         /*
@@ -141,7 +143,7 @@ public class EntityViewAwareCrudMethodMetadataPostProcessor implements Repositor
             EntityViewAwareCrudMethodMetadata methodMetadata = metadataCache.get(cacheKey);

             if (methodMetadata == null) {
-                methodMetadata = new EntityViewAwareDefaultCrudMethodMetadata(cacheKey.proxyClass, method, evm);
+                methodMetadata = new EntityViewAwareDefaultCrudMethodMetadata(cacheKey.proxyClass, method, evmReference.get());
                 EntityViewAwareCrudMethodMetadata tmp = metadataCache.putIfAbsent(cacheKey, methodMetadata);

                 if (tmp != null) {

I'm not sure why we even need the cache though. There seems a 1:1 relation between BlazePersistenceRepositoryFactory, EntityViewManager and EntityViewAwareCrudMethodMetadataPostProcessor. Aren't these all effectively singleton?

@JWGmeligMeyling I got the same impression. Spring's original org.springframework.data.jpa.repository.support.CrudMethodMetadataPostProcessor does not have a global method metadata cache either, it just caches locally in the interceptor. That should also be sufficient for EntityViewAwareCrudMethodMetadataPostProcessor. Maybe @beikov can shed some light into this?

In spring data 1.x CrudMethodMetadataPopulatingMethodInterceptor was implemented as singleton and I simply tried to do it like spring data did it. I'll fix that.

I guess it is time for me to have an own develop branch with #843 seems to become a integration branch :) i will rebuild to 9-12 and try to test this. Thank you guys for working this one out!

This fixed this oom and nothing else broke on our side! Thank you


[VS Code] The Visual Studio Live Share service is unavailable at this time. Please try again later.

<!--
For Visual Studio problems/feedback, please use the Report

@Republic25 Thanks for reporting this! We’re looking into the issue, and are tracking it via #917. In the meantime, I’ll close this as a duplicate so we can consolidate the conversation.


Fix dump during "New Online"

I accidentally used a copied link sapevent:url?url=https://github.com/abapGit-tests/TABL into the "New Online" dialog. AG would dump in this case.

Now you get a proper error message:

Also, it strips leading and trailing spaces when entering URLs.

ref https://github.com/abaplint/abaplint/issues/1400

yeah... I will move the condense logic to the form processing. Cleaner and reusable.


Fix attribute error for _gpus_arg_default loading checkpoint prior to 1.2.8

What does this PR do?
Fixes #7031
I remove a function in #6898 that I should not have removed.
Old checkpoints (<1.2.8) have this pickled, so in order to load the checkpoint back we need to have access to the source code.
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

So are we stuck with this function forever? 😢

I'm afraid so, unless we cut off backward compatibility at some version.
Or maybe there are some pickle tricks we don't know about to avoid it.
Also, why did the legacy checkpoint testing not catch this?
Because all legacy checkpoints were generated without hyperparameters in them.
@Borda we may want to regenerate these checkpoints with hyperparams.

we may want to regenerate these checkpoints with hyperparams.

if you wish to update the model we can regenerate all legacy models...


Implementing a Fluent UI Theme (Tablet) for Canvas App

We're so eager to add your sample to this repository as soon as possible, but we need all samples follow the same structure.
To make sure we process it as soon as possible, make sure to follow these instructions.

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

Related issues?
none

Solution Details

Q
A

Which version of the Power Apps Source File Pack and Unpack Utility did you use to unpack the solution?
0.2.3-preview

Solution requires premium license
no

Solution uses experimental features (see licensing guidelines)
no

Which connectors are used?
none

Solution uses on-premises connectors?
no

Solution uses custom connectors?
no

Layout
Tablet

What's in this Pull Request?
Implementing a custom theme (for tablet layout) to apply the style of the Fluent UI controls to the Canvas controls by deeply modification of the "Default Theme" inside the theme.json file.

Thank you @fabiofranzini! This is a beautiful sample that I know a lot of people will be happy to see!

I'll publish more deeply details in a blog post 😀


FCI differentiation of coat varieties etc. -- are these breeds?

https://www.fci.be/en/nomenclature/4-Dachshunds.html
Katie, how many breeds would you say are listed here? It is not clear to me given how the information is organized. In iDog, this is represented as 7 breeds: dachshund and then [standard, miniature] x [long-haired, smooth-haired, wire-haired]

This is a very good question.
The document https://www.fci.be/Nomenclature/Standards/148g04-en.pdf states:
For decades the Dachshund has been bred in three different sizes
(Teckel, Miniature Teckel and Rabbit Teckel) and in three different
coat varieties (Smooth-haired, Wire-haired and Long-haired),
resulting in nine varieties.
Should we have a hierarchy with:
Dachshund

size

Teckel
Miniature Teckel
Rabbit Teckel

coat variety

Smooth-haired
Wire-haired
Long-haired

Or should we have 9 breeds of Dachshund that each 'share characteristics' with the other varieties of Dachshund?
It gets even more confusing because the AKC lists 2 sizes of Dachshund with three coat varieties. "Dachshunds can be standard-sized (usually 16 to 32 pounds) or miniature (11 pounds or under), and come in one of three coat types: smooth, wirehaired, or longhaired." https://www.akc.org/dog-breeds/dachshund/
Sabrina, can these varieties of Dachshund be considered narrow synonyms of Dachshund in VBO?

@sabrinatoro (I haven't been able to add her as a collab on this repository, so hopefully this tag works!)

Thank you @katiermullen! In case it helps, here's another example: https://www.fci.be/en/nomenclature/BELGIAN-SHEPHERD-DOG-15.html
I'm glad it's not just me, I hadn't heard of the Rabbit Teckel but that makes sense if it's not an AKC breed.
I'm happy to organize these however you all think is best!

For now, is it easy to capture all of the varieties? Then we can meet with @sabrinatoro and see how we need to organize these varieties in VBO.
I will add this issue to our VBO meeting agenda.
I am happy to help, even if manual curation is needed to capture the varieties. The web scrape that you are doing still saves us a lot of work!

Hello! I didn't see this until Katie mentioned it to me (not sure the tag worked or not).
We haven't discussed "variety" yet, but I would imagine that a "variety" is a specific instance of a breed.
Another way to say/ask this is: are all 9 varieties considered to be a "Dachshund" breed? If so, the varieties should be children of the Dachshund breed. Or are they other breeds that are derived from an original breed?
The very first step is to create a clear definition for variety (even though it is probably something difficult to define), so we can have a clear explanation and decision on whether a variety should be a child of a breed. Note that we also have to check what "variety" means for livestock (it might mean the same thing or not).

Completely unrelated: this sort of issue MUST be in the VBO tracker: it is super important that we keep track of these discussions and decisions.
Can one of you create a new issue in VBO, and refer to this issue, please? thank you!


Feature/seperateportfortlbc

Based on the split config pr, so merge that first.
Only last commit is relevant.
Set different port 30302 for tlbc chain.
This will most likely break the current boot nodes, if they autoupdate.

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #554   +/-   ##
=====================================
  Coverage      76%    76%
=====================================
  Files          18     18
  Lines         925    925
=====================================
  Hits          703    703
  Misses        222    222

Flag
Coverage Δ

#bridge_end2end
0% <ø> (ø)
:arrow_up:

#bridge_unit
76% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de432c...41b2c24. Read the comment docs.


License

Please add the MIT license because you use the code in 3DDFA, which is under the MIT license.

Thanks

Please add the MIT license because you use the code in 3DDFA, which is under the MIT license.

Thanks cleardusk,

Dear Jianzhu,
Thanks for your kind reminder, I have added the MIT license as you suggested.
Xiaoguang
At 2019-04-15 17:58:11, "Jianzhu Guo"<EMAIL_ADDRESS>wrote:
Please add the MIT license because you use the code in 3DDFA, which is under the MIT license.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Questions about Query API and T-Accounts

Hello, Tiger Beetle team!
Ever since I discovered Tiger Beetle through ThePrimeagen, I've been intrigued by the possibilities it offers. We are currently considering using it in our high-performance banking services at work.
Bu I do have a few questions:

I've noticed mentions of the new "Query API" in other issues and perhaps in the documentation as well. Is there a roadmap or backlog available that outlines the capabilities this new API will provide?
Since T-Accounts create double entries for every transaction, does this mean I need to create and store a new account for every transfer received or sent to an account belonging to another bank's customer? Do you recommend any specific pattern for handling situations like these?

Hello there @wyalves! Bem vindo à comunidade TigerBeetle! :brazil:
Thanks for your interest and for the great questions.

I've noticed mentions of the new "Query API" in other issues and perhaps in the documentation as well. Is there a roadmap or backlog available that outlines the capabilities this new API will provide?

Yes, we often refer as "Query API" the set of features that will replace the stopgap functions we introduced, like query_transfers and query_accounts.
We don't have an exact ETA, but we have a draft document that details what we aim to support.
https://github.com/tigerbeetle/tigerbeetle/blob/batiati-query-execution/docs/internals/queries.md
Please note that this document is accurate about "what", but it may be outdated about "how"! So please take it with a grain of salt!

Since T-Accounts create double entries for every transaction [...]

(a) The way double entry works on TigerBeetle is that each transfer must have a "debit" and a "credit" account. It has the "double-entry" effect since it changes atomically two balances at once, but physically it's a single transfer. Different from traditional accounting (paper and pencil), which would require two equal movements on each account, but on opposite sides of the "T" chart (debit/credit).

[do] I need to create and store a new account for every transfer received or sent to an account belonging to another bank's customer?

(b) When you receive money from an external entity, typically, it means that the money was credited to the customer's account and debited from a "treasury" or "custody" account (holding the customer's money is a liability for your bank).
The same (but the opposite) when the customer transfers money to an external entity, it's debited from their account and credited into yours (so it decreases the liability).
You may represent it as a single account for all customers or an account per external bank if that makes sense for your business.

I see. Obrigado for the answer!
I have one last question: As described in the documentation, "each TigerBeetle replica stores all data inside a single file, called the data file." Since transfers cannot be deleted after creation, if the data file of a replica grows too large, would I need to manually take down that replica and start it over with a new data file? Would this be a safe procedure, or is it something I should not do?

if the data file of a replica grows too large, would I need to manually take down that replica and start it over with a new data file?

No, the data file is supposed to ever grow, and replacing it with an empty file would only reduce availability and possibly lead to data loss... at the best hypothesis, it will trigger the repair process to rebuild the entire file from other replicas.
Currently we don't have an archiving feature planned, although we might offer some storage tiering in the future, where cold data can be moved to other layers.

Got it, thanks! We should start the first tests soon.


Create iiserpune

Official website of college: https://www.iiserpune.ac.in/
Offers undergraduate degrees: https://www.iiserpune.ac.in/education

@vigneshpai2003 lib/domains/in/ac/iiserpune: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@philipto I've fixed the extension

@vigneshpai2003 Pull request merged. Thank you!