Multiple mock feature files and scenario precedence rules [based off develop]

Load Multiple Features for Karate Mocks #874
Consists of 3 changes:

Allowing multiple feature mock files to be used for server
Scenario precedence based on

Path (JAX-RS Path Precedence)
Method
Headers (Accept, Content-Type and any other)
First match
Default

Path parameter regex usage in form of {paramName:regex}

FeaturesBackend has been added that asks each FeatureBackend for matching and default scenarios, and picks the one with the highest match score (based on rules above)
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

Relevant Issues : #874
Relevant PRs : https://github.com/intuit/karate/projects/3#card-25586564
Type of change :

[x] New feature
[x] Bug fix for existing feature
[ ] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

@ptrthomas Some further enhancements I thought of:

Greedy path parameters that can match multiple segments similar to /v1/** and regex version /v1/{:.+}
Partial path parameters e.g /v{versionNumber}
Do we consider /v1/a/ == v1/a or does the longer match take precedence?
Query param matching which can be also considered during Scenario selection like

paramValueExists
paramValueEquals
paramValueLike

@michaelpro1 this is great, just skimmed through once - one of the best contributions we've got. a couple questions:

what was the motivation, are you actively using this ?
are there areas where the performance could possibly be impacted

Thanks!

what was the motivation, are you actively using this ?

Currently I'm using WireMock for most of unit and component tests, however finding its extensibility lacking.
I then implemented one of the mocks with Karate with the mock-features start from main trick but felt that approach would make it hard to maintain, regarding both the file refresh capability of sub-mocks and also specific route selection which becomes quite tricky with a lot of matching Scenarios.
Then I remembered that JAX-RS has a pretty robust way of doing that and thought the multi-feature file would make the switch much easier.

are there areas where the performance could possibly be impacted

Some I could think of:

Scenario matching for large mocks, where it has to evaluate against a lot of them (currently it's first-or-default match)
Complex regex patterns can impact performance of backend Scenarios, however currently very few are using in the codebase
Those Caches could increase memory usage especially if backend .feature files get refreshed often. LRUCache with a ceiling would help alleviate it but I didn't want to add any other dependency at this time

@ptrthomas I have tried this locally with same JDK version as well without issues. Is it possible to re-trigger the build?

@michaelpro1 apologies for not working on this yet. will do this week. let me try retrigger the build

yep ! I may rename FeaturesBackend back to FeatureBackend once I see the code in its natural habitat
FeatureBackend is actually still there - FeatureBackends is the orchestrator that does findBestMatchingScenario and then invokeScenario. AllFeaturesBackend? FeatureBackendOrchestrator?

@ptrthomas BTW are you able to resolve the pom.xml conflict manually? It's the netty dependency update conflicting with jersey import.

@ptrthomas BTW are you able to resolve the pom.xml conflict manually? It's the netty dependency update conflicting with jersey import.

yes, nearly done. I'm just pausing because I need to get the squash right since forced onto the command line this is what github is telling me to do - maybe you know what to do :) I just completed step 1

As far as I know it's just
git merge --squash michaelpro1-874-multiple-feature-file-develop
Which will get you to resolve the conflict manually.
Commit, run the tests and push if successful.

@michaelpro1 I did what I think is a squash and it is in develop. it seems the commit shows in my name so maybe I got this wrong :( and this PR now is done and has to be closed. is that the way it works :|

Ah I see, I just expected it to take the last commit message instead :/

I did use git merge --squash michaelpro1-874-multiple-feature-file-develop but I don't know what else the sequence of commits had to do with the result. sorry !
I think the only option is to close this. feel free to open a new PR and lesson learned - I think next time it is better to have you resolve the conflicts so that I can do a GUI-based PR merge

Very weird that Travis fails on that queue wait occasionally. I've just tried it out with the exact JDK used and I'm yet to have any failures with it, maybe it's OS/Docker related used?

yeah I hate these kinds of build failures. I'll watch it for a while. those tests are not the best and in the past needed some orchestration of some System.property settings - maybe that has re-surfaced

@michaelpro1 I just saw this on the console when running some other test, did not dig yet - but looks like edge case when no scenarios match

@ptrthomas I've opened https://github.com/intuit/karate/pull/1193 to include various fixes.

@michaelpro1 I fixed the npe: https://github.com/intuit/karate/commit/8ae1019b8a299b41a6f7b332400ad5fc1d058fe5

Nice, sounds like my fix didnt quite do it. Did your JMS session fix resolve build hang?

@michaelpro1 hard to tell, as you saw, impossible to replicate on local

@michaelpro1 I made some minor changes, mainly a null karate-request-id was failing the chrome mocks / interceptor - unfortunately we don't have CI for the web-tests yet https://github.com/intuit/karate/commit/9d2639dbd1a6886946b1055f2b5009597559d890

Dont know mocks still enter via FeatureServerHandler ? If they bypass it it's worth generating the requestId at common point, as it can simplify debugging - especially in high volume tests like Gatling/JMeter. The thing that I was hoping you could also do is update logback for server to include that MDC property.

@michaelpro1 ah, I see what you mean. here's the entry point for the chrome mock: https://github.com/intuit/karate/blob/1d68cfbf39bd050bdfd6a30cdfed1d237f3496fe/karate-core/src/main/java/com/intuit/karate/driver/DevToolsDriver.java#L217
one nice thing about FeaturesBackend is that it is decoupled from HTTP, good to be aware of this for e.g. one of the things I have done is wrap it behind an HTTP servlet for a situation where the team insisted that a mock be available as a Dockerized Tomcat because that was The Process™ - in the future we could include this mock-servlet "adapter" into karate
so in this case what do you suggest as the requestId, there happens to be some chrome id we already get BTW

@michaelpro1

update logback for server to include that MDC property.

can you give me a little more detail ? this reminds me - even the server side uses the same JS context as everything else and you rightly suggested that we need a ThreadLocal strategy in the future

so in this case what do you suggest as the requestId, there happens to be some chrome id we already get BTW

I've had a look and it seems you can do similar to what FeatureServerHandler is doing:
 String requestId = System.identityHashCode(dtm) + "";
If that is not unique enough something like UUID can be used as well

can you give me a little more detail ? this reminds me - even the server side uses the same JS context as everything else and you rightly suggested that we need a ThreadLocal strategy in the future

As part of the requestId creation I also store it in the MDC as karateRequestId:
https://github.com/intuit/karate/blob/8bb57fe049d76be60e6aa60a3231b1a4520307e1/karate-core/src/main/java/com/intuit/karate/netty/FeatureServerHandler.java#L84
So in the Pattern in logback profiles something like %X{karateRequestId} appears - I'm just not sure which exact logback-*.xml files need to change and where you want that to be present.

I'm just not sure which exact logback-*.xml files need to change and where you want that to be present.

For now shall we just add it to the docs ? we don't "ship" a logback config, just part of the maven archetype: https://github.com/intuit/karate/blob/master/karate-archetype/src/main/resources/archetype-resources/src/test/java/logback-test.xml
so the docs here can be updated: https://github.com/intuit/karate#logging - feel free to do a PR
it does make sense to change this file which ships with the "fatjar": https://github.com/intuit/karate/blob/master/karate-netty/src/main/resources/logback-netty.xml

@michaelpro1 would it possible for you to check if the MDC log filter is adding significant CPU utilization. just a hunch. running a build on my mac never used to spin the fans before. maybe it sticks around even after the server is stopped ?

I can try running with and without it though MDC is likely to increase memory usage very slightly - its just ThreadLocal storage which is fast. I can't see it increasing any CPU cycles

Tried adding/removing MDC which made no difference (in run times). Interesting thing that I compared:
playground/see-what-fixes-travisci-build-issues <-> develop
And karate-demo has had a substantial increase in run-time (bit more than 33%), and this project does not use MDC filter - that is only in karate-netty.

@michaelpro1 karate-demo does boot multiple netty servers in succession for those tests including the ones that keep hanging

It uses the FeatureServer, however the mdc filter has only been placed into karate-netty project which karate-demo does not refer to from what i can gather

@michaelpro1 fine. let me know if you have any theories. I guess I have to dig in to this more

I played around with a couple of things, I saw a noticeable improvement (though not to previous baseline) &waitForStart=10000 from mock.contract.QueueUtils with a send within the same thread - strangely that is almost instantaneous then. That shaved off around 6-7 seconds of the karate-demo run.
I did a diff of the rest, however I'm not really familiar with a lot of the code in the changes - only wild guesses I could come up with the json/xml changes that might be doing eager parsing?

@michaelpro1  no worries - the extra time can be explained by the "waitForStart" - I'll leave things as they are for now

Seems odd that waitForStart is a dumb wait rather than make-sure-that-its-up-and-then-continue.
Do you know of any good code profilers that can be run from command line? The one I'm using for maven is only per-maven phase but no detail around which classes/methods and how long.

@michaelpro1

quick question based on the above image, the pattern for things like afterScenario in the Background has been configure not def. question for you, if a Scenario changes the value of responseDelay won't it affect all other Scenario-s from that point onward ?

Had a quick read around the configure and I suppose you are right since configure is allowed within that block.
If I was doing a global delay would I not just have a configure or def in Background without afterScenario?
I'm also assuming this behaviour would be the similar to if you wanted to configure responseHeaders.

@michaelpro1 yes - responseHeaders is already implemented that way with 2 levels, if there is no def fall-back to configure. individual Scenario-s should be able to over-ride what was set in the Background, I can modify

Ohh thats what are you referring to - I think thats already done here?
https://github.com/intuit/karate/blob/5343648389fc28fcd0a01891345fec56deba6f03/karate-core/src/main/java/com/intuit/karate/core/FeatureBackend.java#L274

@michaelpro1 oh yes - all good then. which means the docs need to be updated right ? it should be configure responseDelay

Ah I think I remember what this was trying to demonstrate. From my understanding configure gets executed only once ever so the random delay in that example will not be random. def on the other hand is executed everytime which means that it will actually be random. Let me know if I understood that correctly.
So effectively theres 3 levels:

Scenario everytime = def
Feature everytime = def
Global once = configure

@michaelpro1 there is one difference between karate tests and mocks - which is the Background for mock is executed only once and on start. maybe that is what you missed: https://github.com/intuit/karate/tree/develop/karate-netty#background
and - the recommendation is to use configure in the Background else it gets confusing and a def can be over-ridden at any time. does that make sense ?

Oh I see, then I guess in doco you can replace it with configure and potentially use afterScenario with def

@michaelpro1 thanks. just made the doc changes: https://github.com/intuit/karate/commit/dcd6876f8614432599b9c120c08fa51dcfa5f4b5 - should be all good now

I would suggest not using Thread.sleep in afterScenario - just def responseDelay = ? should work within afterScenario.

@michaelpro1 please make the change after you verify it actually works, because I am not sure about the sequence, when is afterScenario processed. also it may need to be a karate.set('responseDelay', millis) not a def within a JS block

Also just one thing I remembered from the last RC release. Is it possible to add karate-netty to the release as it has the extra CLI component that is not included in -core?

we have an 80% duplicated CLI in core: https://github.com/intuit/karate/blob/develop/karate-core/src/main/java/com/intuit/karate/cli/Main.java - which is used by the VS Code plugin for e.g.
if you see any gaps with that, we can fill it out. the reason we have 2 is because of the slight differences e.g. logging, folder structure, cucumber reports (which we will refactor over time)

I'm not seeing any referencing to FeatureServer or the FileWatcher with hotreload in that file. That looks like test runner only?

@michaelpro1 right. the assumption is that those who use the "Java side" would be comfortable writing a couple lines code to start a featureserver

Ahh probably worth pointing out a use-case I'm thinking off. While the typical usage might be run JUnit and start server from there, another use-case is to start a mock server within a docker container.
Currently the fat-jar is not a versioned maven dependency so its not easy to retrieve it and pack it into docker container. Similarly karate-netty which has the CLI interface which I could theoretically fat jar myself along with core.
This makes it non-trivial to get the mock going as a standalone server.

@michaelpro1 not a priority for me. if you are using maven, adding a java class or shading a fatjar is trivial. PR's always welcome

@michaelpro1 can you add another PR that updates the documentation for this?

@michaelpro1 last try - we are getting multiple requests for missing documentation on how to use multiple feature files in a mock, e.g. https://stackoverflow.com/q/64004218/143475
this is my miss as I reviewed this PR in a hurry. but will you be able to do this ? let me know.

@ptrthomas have you seen any other questions regarding multiple mocks?

@jawadkalia had some questions over on the slack channel - we can ask if he has any other comments on using multiple mock files

Hello!
My specific question was answered by this part of the docs
java -jar karate.jar -m my-mock.feature -m my-2nd-mock.feature -p 8080
but then does it attach that one port to both feature files?
I think the Path precedence should also be in the docs
A example of the featuresbackend thingy (if i understood correctly)
Documentation on matching path with regex.
Hope that helps!

Hi @jawadkalia

java -jar karate.jar -m my-mock.feature -m my-2nd-mock.feature -p 8080
but then does it attach that one port to both feature files?

That's right, no matter how many feature files are supplied there is always a single mock on that port. The multiple -m is simply how picocli supports lists or arrays

I think the Path precedence should also be in the docs

Was thinking about it too, will add a bit of time to write that up as its relatively complex

A example of the featuresbackend thingy (if i understood correctly)

Not quite sure what you mean by that, could you clarify?

Documentation on matching path with regex.

That and more is in the JAX-RS spec link


Remove breaks on CLI methods

All CLI methods first print a blank line (empty echo), but it would be more in line with other CLI tools to not print this blank line.

Fixed in https://github.com/nozel-org/serverbot/commit/672cabd650328137a10c76d41996242fd46c0a67.


Fixed graphrag.query llm parameter settings not passing through to llm call.

Description
[Provide a brief description of the changes made in this pull request.]
Related Issues
[Reference any related issues or tasks that this pull request addresses.]
Proposed Changes
[List the specific changes made in this pull request.]
Checklist

[x] I have tested these changes locally.
[x] I have reviewed the code changes.
[ ] I have updated the documentation (if necessary).
[ ] I have added appropriate unit tests (if applicable).

Additional Notes
The main change is to the global_search_config_input.py and local_search_config_input.py files to accommodate additional llm parameters (temperature, top_p, n). The current branch assumes that all llm calls are classed under llm, so no dedicated global or local llm parameters. If go that route, change the Sections.llm in create_graph_config.py.

@microsoft-github-policy-service agree


Author

Removed @author annotations as specified in feedback

I had a look at your code, but I'm afraid I don't understand half of it. However, with the amazing new functionality this PR brings, our application almost runs even faster. Great work!

Looks fine by me


Search and replace string value

@ac3ss0r, Is there search and replacement ASCII and Unicode strings?

Hi bro ! I'm currently making an mod of this project on my GitHub. You can watch my project to see the future functions :) Have a nice day

Hi bro ! I'm currently making an mod of this project on my GitHub. You can watch my project to see the future functions :) Have a nice day

Many thanks for activity in fork https://github.com/JustCoolDev/ZMemory-mod


Add support for scheduled actions

Change-type: minor
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>
Add support for scheduled actions in the worker. Make the worker aware of scheduled actions and work with the queue to schedule the action to be executed in the future.
Depends on:

https://github.com/product-os/jellyfish-queue/pull/1059

@balena-ci I self certify!


Graph Power Sources

Overview
Adds a new pie chart showing how power is generated in all states with a % of emissions from power > 0 (so this graph doesn't show for Vermont or DC).
Note: I also dropped our recommendation on adding solar to your home - I think that makes more sense in the Take Action page and broke out the flow of the state details page - the main thing is to close down fossil fuel plants, not to get everyone to add solar panels to their roof.
Demo

Desktop
Mobile

Notes
Holy moly, this one is challenging to handle because of the wide variety of data ranges - Nevada in particular is a great test case because it has a bunch of small slices that are at risk of having overlapping labels.
Testing Instructions

Test a variety of states on desktop and mobile and confirm you can read all the labels
Also confirm the homepage state emissions map tooltip is properly positioned again, particularly for DC and L shaped states like Louisiana

Note to self: if I can do it easily, making it so to the single bar chart is clickable as a form of shortcuts is something some users requested and would make QA-ing this and other changes easier

@derekeder - I basically stole the current colors from the EIA, and I think they actually work a lot better at a glance than our typical orange and green approach - here's what that might look like:

I wonder if it would help to draw an outside outline of grey if the electricity is from fossil fuels, and green if it's from a clean source of power

Well this is surprising and sad - I have to account for Rhode Island not having any renewables:

@derekeder - alright this should be in a lot better place right now. Here's a few samples to show off how different states may look:

California
Washington
Indiana


Preview that encourages editors to think about different screen sizes

Currently the preview feature just launched the page an editor is working on at whatever size browser window they happen to have open. This encourages editors to think of their content at the size they're producing it at.
It would be great to have an editor preview UI that allowed/encouraged editors to look at their content at different screen sizes. Perhaps something like Pattern Lab (see attached)?

Thanks for the suggestion @tmsndrs!
In an ideal world editors shouldn't be making design-related decisions at all... on balance I think this is a step in the right direction, though.

I don't think this is a design related decision - it's about shaping optimal content, consonant with http://alistapart.com/blog/post/content-first-design

Agree with Paul. It's about writing content appropriate for different devices. I'm all for separation of presentation and content. Ultimately though editors are always going to want to see how their content is being represented and it would be great if Wagtail encouraged them to be thinking about that for different screen sizes.

I did a really quick mock-up of this. I've come across lots of instances of clients only thinking about how their content is presented on desktop, especially when using streamfield for more complex content structures and think this would be a good way to get people to think about multiple devices sizes.
The design is really rough and needs some work to make it a bit more visually pleasing but wanted to share the idea.

https://html5up.net/massively example with nice transitions between sizes.

I think that's really nice Tom. Would be great to implement this.

+1!

On 12 Sep 2017, at 16:33, Olly Willans<EMAIL_ADDRESS>wrote:
I think that's really nice Tom. Would be great to implement this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/wagtail/wagtail/issues/3243#issuecomment-328886066, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLzbszzC51LzhalPV6l-s3lR_uTWlLhks5shqRggaJpZM4LTL-x.

Hey @thibaudcolas I was wondering if you had done any work on this? I'm going to develop the design further.

👋 no, didn't do anything. I'm really interested to see this happen though.

@tmsndrs we should chat again and make this happen 🙂

FWIW, with our work at the city of austin we've instead opted for a preview panel on the same page (esp since we are using wagtail headless).
I'd recommend thinking about these contexts, I think a side by side view is better UX overall and more flexible.

Not sure on the technical implementation here but if we are going down the iframe or separate tab path - this library may be useful (even as a reference).
https://github.com/jcubic/sysend.js

@KalobTaulien also made a version of the side by side preview at some point

@KalobTaulien also made a version of the side by side preview at some point

That would be https://github.com/KalobTaulien/wagtail-livepreview
City of Austin also had a toggle-able preview sidebar - https://github.com/cityofaustin/joplin/search?q=preview

For people interested in this – I have good news and bad news. This is tentatively in scope of the page editor 2022 for Wagtail 4. It’s unfortunately at risk – as per our most recent build update blog post, we’re currently looking for funding to support this project, and this is one of the features that could be de-scoped if we don’t find this funding.
Here is what we’re planning to build for reference, as a side panel that would live update when authoring content, with three supported breakpoints, and a way to keep using the existing full-page preview if needed:

PR: #8671.

This has been implemented, and will ship in the next release :)

@thibaudcolas very exciting!!


Undo and Redo doesn't work

Thank you for your this library.
I am using this code to draw lines but the undo and redo doesn't work.
I just attached a video.
Can you please let me know how to fix this problem?
https://user-images.githubusercontent.com/20561207/159237268-34f5a003-6011-4d56-80ee-bfa69e40122a.mp4
Regards.

does this only occur on the simulator? It works well on my real device.

thanks for your message. it doesn't occur in real device exactly but there is another problem on real device.
I just added a new video.
https://drive.google.com/file/d/1WAh897HlzKjH8YAAjvkejTHR_FE2GO_h/view?usp=sharing
Thanks.

hi @Harley-xk.
do you have any idea about undo/redo issue?

I can't reporduce the probelm, what's the model and system of your device?

my device is iphone 12 mini and ios is 15.1

I am sorry, I was using old code. I have downloaded final one and tested it. It working well. Thanks.


FAQ format adjustment

Hi and thanks for this change. The FAQ does look awkwards at the moment. I have notifced on "search and replace"-error though, that should be fixed before merging.


add verifier(inline) for contains_pair; contains

I had to revert this due to https://github.com/secure-foundations/verus/issues/248 for which there wasn't an obvious workaround.


Door status lights behave incorrectly in debug mode

Description
When running the debug configuration of the game airlock door lights will flash green and red and will not buzz when trying to open them without access, they will also start the opening animation occasionally but do not open. They do however function correctly in release.
This is more an annoyance than a serious problem but it did act as a red herring and cost me an hour of my life.
Reproduction
Run debug
try to open a door without the correct access
be dazzled by the buggy behavior

Probably this and #29372 are related in some way.


confirmMetamaskDataSignatureRequest() fails with Seaport

The Seaport protocol loads some extra data into the message body, which is why an "arrow" is displayed in Metamask.
Even if the signature request gets signed by synpress (it can be seen visually during execution), it doesn't seem to be done properly.

Synpress: 3.0.0
Metamask: 10.20.0

Thanks for report! Gonna fix it today. Gimme few hours.

@mp-dthr Hey, do you have any example code to reproduce this? What exactly is the issue?
If I understood correctly, the issue is that you're using:
cy.confirmMetamaskDataSignatureRequest() to confirm this notification:

But it doesn't seem to work properly? It hangs? What exactly is the issue?
I'm asking because I've added a code to handle this case ("arrow"), it's present here:
https://github.com/Synthetixio/synpress/blob/master/commands/metamask.js#L626-L634
We also have an e2e test for this specific function (with an arrow), here:
https://github.com/Synthetixio/synpress/blob/master/tests/e2e/specs/metamask-spec.js#L169-L176
And it's passing without issues, you can see it here (video is available to download on GitHub Actions CI):

I'm just not sure that I can understand this part:
Even if the signature request gets signed by synpress (it can be seen visually during execution), it doesn't seem to be done properly.
What do you mean by signature gets signed by synpress, but is "not done properly"?
Thanks,
Jakub.

Also, would be super-helpful if you could run your tests with DEBUG=synpress:* env var! It will give you more details about the issue.

Thanks for your reply @drptbl.
I have tried with debug logs, not much can be seen there since the method itself returns true (signature is signed). But somehow, there are no visible transactions on etherscan for my account address and the platform I am testing is returning that listing an item failed.
This is the method, same as in the link you have shared:
 cy.confirmMetamaskDataSignatureRequest().then(confirmed => {       expect(confirmed).to.be.true;     });
Although, when I do it manually, there are no issues with signing the same signature request.

@drptbl One additional info, when running with confirmMetamaskSignatureRequest(), this error can be seen in the logs:
CypressError: cy.task('confirmMetamaskSignatureRequest') failed with the following error:
> page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for selector ".notification .request-signature__footer__sign-button" to be visible
============================================================

@drptbl As you can see from the video below, there are two selectors when message data is present (the one from the Metamask notification window and the one inside the message body), so it seems that synpress is scrolling only the one inside the message body:
https://user-images.githubusercontent.com/114396660/199688394-ce3447bc-2f2c-434d-9be5-63a70644f3b3.mov

@drptbl As you can see from the video below, there are two selectors when message data is present (the one from the Metamask notification window and the one inside the message body), so it seems that synpress is scrolling only the one inside the message body:
https://user-images.githubusercontent.com/114396660/199690522-7be67a65-e7b7-42df-8eff-01ee7f834498.mov

Thank you for explanation and recording, this is indeed the root cause! I will take a look in to this today and prepare a fix. Thanks a lot for helping out to investigate 🙇♂🙏.

Thanks to you @drptbl ! 🙂
Please let me know when the fix is ready and in which version of synpress.

@mp-dthr Will do!
Do you know any website where I can reproduce this case with signature request and seaport?
Thanks,
Jakub.

@drptbl Try with https://testnets.opensea.io/.
Connect your wallet, create a collection with one item and try to sell it.
I have managed to reproduce it that way.
https://user-images.githubusercontent.com/114396660/199723236-2aca88f9-2cee-4101-9925-9f82ce3d9a59.mov

Love it! Thank you again 🙏

Hey @mp-dthr, sorry for delay.
Can you try<EMAIL_ADDRESS>and let me know if that fixes your issue?
Thanks,
Jakub.

Hi @drptbl,
I have tried with synpress 3.0.1. Request gets signed, but the listing fails and there is no activity visible in my Metamask wallet that there was a signed request. It could be due to low gas fees.
Is there a way that I can increase the gas fees within this synpress method?

Found the root cause of the second issue, not related with synpress.
Somehow, my user acc was not signed in on the platform while running steps for listing, which caused the issues with rejection.
Everything works perfectly with this fix! 🙂
Thanks a lot @drptbl!
You can close this bug.

@mp-dthr Thanks for letting me know and reporting this issue 🙏.


make custom 500 pages have a 500 error message

When there is a template file available, Symphony did not automatically set the 500 Error message. I'm not sure if this was intended for the developer to set the error header within the file overrides but I think it should be handled within the core before applying any custom templates.

I think we should actually fix this by removing the header line altogether and instead let the errorhandler deal with it. What do you think?

@brendo Those line were added because the HTTP status code was 200. If the user wants another code, he should use the status code property of the exception.

@brendo / @nitriques not sure what happened with this PR seems like it got messed up (probably needs a rebase / to be redone)
@brendo not sure I'm following.. maybe the 200 status code would already be sent when using a custom template within workspace? All our custom 500 error pages were being served as 200's maybe there's actually a bug elsewhere?

I guess the only way to know for sure is to retest the current build and see if the issue persists

not sure what happened with this PR seems like it got messed up (probably needs a rebase / to be redone)

Yup. @brendo rebased integration and now your branch is out-of-date.
What I would do is:

Checkout a fresh copy of the repo.
Checkout the integration branch.
git checkout -b new-branch-name
git cherry-pick individual commits, starting from the oldest.
create a new PR.

Thanks!

https://github.com/DeuxHuitHuit/symphony-2/tree/errorhandler should take care of this.


ews is not

News is not displayed... the title news is there but the now it won't even display american news... also the weather is not displayed. It prints this into the command line though: ,"temperatureMax":13.13,"temperatureMaxTime":1477321200,"apparentTemperatureMin":4.39,"apparentTemperatureMinTime":1477278000,"apparentTemperatureMax":13.13,"apparentTemperatureMaxTime":1477321200,"dewPoint":7.71,"humidity":0.88,"windSpeed":7.82,"windBearing":66,"visibility":8.77,"cloudCover":0.78,"pressure":1010.68,"ozone":297.84},{"time":1477350000,"summary":"Partly cloudy throughout the day.","icon":"partly-cloudy-day","sunriseTime":1477377924,"sunsetTime":1477414269,"moonPhase":0.84,"precipIntensity":0.0279,"precipIntensityMax":0.0508,"precipIntensityMaxTime":1477368000,"precipProbability":0.05,"precipType":"rain","temperatureMin":6.89,"temperatureMinTime":1477375200,"temperatureMax":14.44,"temperatureMaxTime":1477407600,"apparentTemperatureMin":5.93,"apparentTemperatureMinTime":1477375200,"apparentTemperatureMax":14.44,"apparentTemperatureMaxTime":1477407600,"dewPoint":8.04,"humidity":0.89,"windSpeed":3.23,"windBearing":70,"visibility":10,"cloudCover":0.44. Also it does not recognise the pictures like partlymoon.png


Does Scope.AttachToParent only affect Dispose behaviour?

Lets say there are several cache services that should be tracked in parent scope "A".
I use Hangfire to run several worker jobs. Hangfire is connected to Stashbox and creates a new "job" scope (B1, B2, B3...) for each job. That's fine. The job scopes are child scopes of my scope "A" and have AttachToParent set to "true".
If the job service classes use other services, these services are created and tracked in the job scope. That's all fine.
But the job services should now be able to use some cache services. So, if a service requests a cache service, Stashbox should look into scope A for that service - and if it creates a new cache instance, it should be automatically tracked in scope A. How to solve this?

The AttachToParent only adds the given scope to its parent's disposable list, which means all "B" scopes will be disposed when "A" is being disposed. So it's only affecting the tracking.
What you described is basically the main concept behind the named scopes. I prepared some tests to show its functionality.
While I wrote those tests I found a bug in the named scope resolution so it'll work only with the latest pre-release package, please use that for testing.
Please tell me if this isn't what you are looking for or if you have any questions.

The AttachToParent only adds the given scope to its parent's disposable list, which means all "B" scopes will be disposed when "A" is being disposed. So it's only affecting the tracking.
What you described is basically the main concept behind the named scopes. I prepared some tests to show its functionality.
While I wrote those tests I found a bug in the named scope resolution so it'll work only with the latest pre-release package, please use that for testing.
Please tell me if this isn't what you are looking for or if you have any questions.

I'm closing this due to inactivity, please re-open or file a new one if you have more questions or suggestions.


[Addition]:SenseCAP Same maker witnessing cluster

Hotspot b58 Addresses
112AjuLNCrgJrE27mUkduu4jzvMxWDFx1yeovpkiJpah2wmbXBLN
11uBKD6jQYbe8H99PoCmZJV2LPtdpGXR4mg6NQn21Bnwb4Fby39
113HRxtzxFbFUjDEJJpyeMRZRtdAW38LAUnB5mshRwi6jt7uFbt
11JojZ4k4JYgRzCEVKW71QZNZEZM4MEFYntQFsQazeuymhPm332
114Gr8trPRzVbcq7BTqNAAZsMGg1U5Ba585bQ7ks1AvYqeASS4v
112Sp5Vw12vUf3xEsSqPU5nkGE8pkchsmknXsLRrDVz9mhxz5Bmg
11KmjTCnZ7k9joJGi28PSDKNqeUx7pq8oTP7oA67T7wp1AcFvRE
11265Ez3cpbjQ9x2GQjrGQdfjwEGnTTwJybUWBs3J22ZnBd8dqqS
11q3oMycn6bShUEMASFW2ySPkC2wV6cjBHcdPbEUyqJ6mgdChMy
11x7k1eaniJ11T31wBcJJ6dn3HvKKWY1HU9m442ZG5X2ku866QK
112R4WHvVmSMaKdzJyaWxyYoxhiGs7AaMdHtma37EPEF4vUeSrv7
Discord Handle
No response
Reason(s)
Half witnessing are invalid (signal is too good)
This is a cluster of many hotspots witnessing each other only.

This is not an effective way of stopping the denylist process, as you simply get banned each time you try it.
It's really boring, please stop it.


OpenSSHUtils install reference no longer valid

[Enter feedback here]
The required command...

Install-Module -Force OpenasSSHUtils -Scope AllUsers

...fails reporting:

PackageManagmenet\Install-Package : No match was found for the specified search criteria and module name

Please provide a link for resolving this common error and/or superseding documentation

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c89b7b3-c05f-b517-6109-04e6a97195c3
Version Independent ID: 1e4b742e-d999-2c1e-a396-dc149f7ac76b
Content: OpenSSH key management for Windows
Content Source: WindowsServerDocs/administration/OpenSSH/OpenSSH_KeyManagement.md
GitHub Login: @maertendMSFT

For reference; See also the list of following related issues:

Can't install the "OpenSSHUtils" (#3400)
kljkyzsl opened on 14 October 2019, 7 comments

OpenSSHUtils is deprecated (#3806)
FizzBuzz791 opened on 28 January, 1 comment

Instructions provided ends with an error (#4598)
jyavenard opened on 28 June, 5 comments

More documentation required (#4634)
garylawuk opened on 11 July 2020

Outdated instructions? (#4023)
RussKeldorph opened on 16 March 2020, 6 comments

OpenSSH installation (#3970)
DavidA2014 opened on 2 March 2020, 4 comments

Misleading title/summary causing search confusion (#3456)
ChrisDodd opened on 30 October 2019, 7 comments

Unable to configure OpenSSH for public key auth following docs (#4518)
jaraco opened on 20 June1 2020

A better explanation can be found here (#2747)
ElimAdmin opened on 23 Apr 2019, 2 comments

See Pull Request #4788 for a suggested improvement to this issue.
(The PR will close this issue ticket when it gets merged.)

List of related issue tickets:

#2747 A better explanation can be found here (Open)
#3400 Can't install the "OpenSSHUtils" (Closed)
#3456 Misleading title/summary causing search confusion (Open)
#3806 OpenSSHUtils is deprecated (Open)
#3970 OpenSSH installation (Closed)
#4345 OpenSSHUtils Not Needed (Open)
#4518 Unable to configure OpenSSH for public key auth following docs (Open)
#4598 Instructions provided ends with an error (Open)
#4622 Out-of-date - OpenSSHUtils no longer available. (Open)
#4634 More documentation required (Open)
#4702 OpenSSHUtils got unlisted from the PowerShell gallery (Open)
#4743 Nope. First example errors out. (Open)
#4770 Error when following instructions to install OpenSSHUtils (Open)
#4787 OpenSSHUtils module does not exist (Open)
#5000 Clarification needed (Open)
#5138 These instructions do not work on Windows 10 20h2 (Open)

Thanks for submitting this issue. I have reworked this document to remove or replace parts that are no longer relevant or correct based on this and several other issues raised for this page.
The changes should be visible in around 6-12 hours.
#please-close


Add installation steps

How to install and achieve this on fresh base Arch Linux or Artix?

Will work on the tutorial README and video soon :) Also, a user named lotation has been very kind to make an install script specifically for this rice, you can check it out here https://github.com/lotation/scripts/blob/archlinux/elektropunk-install.sh :)

Hello there,
Pretty cool rice, congratulations for the amazing work!
The provided script is not working properly.
Any updates on the installation for the particular rice?

Will try to work on it soon, but I can't give a solid date as these are very difficult times in our country. As much as I wanted to, due to the circumstance it may take longer than usual sorry.

No need to apologize at all. I will also try to make the above installation script work, and If I succeed I will post back here! I do face difficulties in my country as well, with all these fires expanding into more and more places! Stay strong!

Hello there,
Pretty cool rice, congratulations for the amazing work!
The provided script is not working properly.
Any updates on the installation for the particular rice?

Sorry, I forgot to update the script, can you tell where it fails?

Hello, @lotation
On lines 167 to 171 you've forgotten a git diff there,
<<<<<<< HEAD
		yay -S spotify --noconfirm --noprogressbar --skippgpcheck 1>/dev/null 2>>~/errors.log
=======
		yay -S spotify --noconfirm --noprogressbar --nopgpfetch 1>/dev/null 2>>~/errors.log
>>>>>>> bbcc7771341c2968d532085dc2d3d9b9e62be5c1

I don't remember which one i removed in the end but even still the script didn't complete successfully.
I tried to use it on a fresh install of Artix Linux (runnit).
Excuse me but I don't exactly remember now where exactly it failed, and I've not kept the logs as I've added myself stuff I needed for my Artix Installation. Maybe you want to try and run the script for a new user on your existing Artix Installation if you already have one?
Else when I do find some free time (I'm super busy with work right now), I'll try to play with it a bit more and see what I can do about it and update you here!
Have a good day!

Hey @andrewpap22 I accepted your Incoming Change and reviewed the whole script since has been a while.
As you can see from lines 199 and 200 I wrote it for Arch Linux, thus I had systemd in mind.
Anyway I suggest to use the script as reference to do the steps by yourself since many things have changed and will always change, maintaining a script like that consumes a lot of time.
Plus I ditched SLiM since it's discontinued and doesn't conform to the modern login manager requirements as you can see in the warning here
PS: I don't use this rice anymore and I'd need to set up a VM with Artix to test it but right now I'm pretty busy too. Tho, if you need help setting up anything PM me and I'll try to help


"Error: Solve failed - maximum time exceeded (29500 ops, 5036 ms)"

Not much to say other than it times out easily.
Maybe an async call is in order? (Freezes the browser tab as well during processing)

The timeout is a safety measure. Due to the nature of the problem, the solver (especially on 4x4 and 5x5) can end up taking an extremely long time, which is why it stops after 5 seconds. I'll have to look into async a bit more, I'm not familiar with browser concurrency features.

I've improved the heuristic - it's more efficient when searching for a solution now, and doesn't choke as easily. It doesn't fix the freezing, but it helps prevent it from timing out as easily.

Can still manage to time it out on 4x4 / 5x5 with shuffling, however it does definitely have a performance boost. 36k ops now. 👍


Improve speed of lint check

Currently the lint check in the integration-tests workflow runs slow because Pipenv installs a full dev-environment on the CI.
https://github.com/WordPress/openverse-api/blob/eda11d2335d58747fc07764b4a5dd47b8fe174d3/.github/workflows/integration-tests.yml#L24
That's not really necessary because all we need for the lint check is the pre-commit package. With the following small change, we might be able to reduce the run-time considerably.
-          pipenv install --dev
+		   pipenv install pre-commit

hi, i would like to work on this issue

Sure @himanshu007-creator, feel free to take this up.

Some extra suggestions to improve the linting even further:
https://github.com/WordPress/openverse-api/pull/237#issuecomment-926277015


Multiple file downloads from server fails after first download.

Hi there,
In one of my requirements, I was trying to download multiple csv files from ftp server and parse these files into json object and store it into mongodb. I was facing bad sequence of command error. logs attached in file.
Steps to reproduce

Connect to ftp and list down remote folder.
Filter only csv files.
Download the filtered csv files.

Thanks

I got the same issue but in reading multiple csv files, reading the first was successful but not the other csv.
var getArray = [];
files.forEach(function (file) {
  if (file.type !== '1' && path.extname(file.name) === '.csv') {
    getArray.push(function(cb) {
     c.get(file.name, './server/csvdata/' + file.name, function (hadErr, socket) {
       if (hadErr) {
        console.error('There was an error retrieving the file.');
       } else {
          socket.on("data", function(csv) {
            console.log(csv.toString())
          });
          socket.on("close", function(hadErr) {
            if (hadErr)
            console.log('There was an error retrieving the file.');
          });
          socket.resume();
          checkIfDone();
       }
       cb();
     });
    });
  }
});
async.series(getArray);

Is there any way without creating a new instance for every file?
Any ideas? Thanks.

@louiepiol
I have tried what @sergi  mentioned and it worked for me. You should try the same approach.
Thanks

See on my sample code that I already tried what @sergi mentioned, but there's a problem on reading multiple files continuously.


react-native 0.69.1 빌드 안되는 문제

Version of kakao-login libraries
4.2.2
Version of react-native
0.69.1
Platforms you faced the error (IOS or Android or both?)
Android
Expected behavior
빌드가 정상적으로 되어야 하나 오류 발생.
Actual behavior
react-native run-android 실행 시 빌드 도중 빌드 실패.
error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081 -PreactNativeDebugArchitectures=arm64-v8a -PreactNativeArchitectures=arm64-v8a

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/{userName}/{projectName}/node_modules/react-native/ReactAndroid/build.gradle' line: 11

* What went wrong:
Error resolving plugin [id: 'org.jetbrains.kotlin.android', version: '1.6.10']
> Plugin request for plugin already on the classpath must not include a version

Tested environment (Emulator? Real Device?)
실제 기기

저도 비슷한 에러가 발생했었는데 kotlinVersion: "1.6.21"로 하니까 해결되더라구요..!

android studio에서 kotlin 버전 확인 후 해당 버전으로 수정하시고 다시 빌드해보세요!


Catch HTTP exceptions in Request.application

This catches HTTP exceptions in Request.application which just generally
makes that function a bit more useful. I don't think there are that many
users of this but for simple apps it's actually not that useless.

@ThiefMaster can I merge this?

You are much more familiar with that part anyway, I just pointed out the typo ;)


WebPack 2 query object in loader chain

Any idea where to look to fix this?
Loader
{
          test: /\.css$/,
          loaders: ExtractTextPlugin.extract([
            "style",
            {
              loader: "css",
              query: {
                camelCase: true,
                importLoaders: 1,
                localIdentName: "[path][name]--[local]",
                modules: true,
              },
            },
            "postcss",
          ]),
        }

Error
ERROR in ./src/…
Module not found: Error: Can't resolve '[object Object]' in '/Users/dnalot/Documents/Jane/jane-com'
 @ ./src/…

CC @kentcdodds.

I strongly suspect it's loaders.join("!") in ExtractTextPlugin.extract(). Trying it out.

Did it work @AppShipIt? I see you referenced this issue in a commit

Definitely it. I wrote up a test case before I fell asleep and will PR before end of day!


Do I just need to run the code by scripts？

thanks you for your great works!
now I have a question that I run the scripts to get the results, but I got a great gap with the result in the paper . I think maybe something wrong in my progress, does it have the relationship with the environment of colab?
thanks

Thanks for your interest. One possible reason is the downstream task. e.g., classifying activity types or users. What's your command to run the classifier.py?

one is benchmark Deepsense on hhar
the other one is classifier_bert on hhar
the result is about 74%
tomorrow I will paste the details.
thanks for your quick replay！

python classifier_bert.py v1_v2 hhar 20_120 -f hhar -s limu_gru_v1 -l 0
Train Size: 43992, Vali Size: 5496, Test Size: 5508
Balance Label Size: 432, Unlabel Size: 43560; Real Label Rate: 0.010
cpu (0 GPUs)
Loading the model from saved/pretrain_base_hhar_20_120/hhar
The Total Epoch have been reached.
Best Accuracy: 0.995/0.769/0.765, F1: 0.995/0.763/0.758
Is there any error in scripts？Thanks!

Have you tried the pretrained models provided in the saved folder? I just tested it and got the following results for hhar:
Best Accuracy: 0.998/0.958/0.955, F1: 0.998/0.953/0.953.
If you use the same setting as that in our paper, please give the above result or paper result. However, if you have other settings, e.g., different labeling rates, and methods of partition, feel free to report any actual result from our codes.

I just use the pre-trained models provided in the saved folder, in the result above it printed: Loading the model from saved/pretrain_base_hhar_20_120/hhar, there is a file called hhar.pt, is it right?
python classifier_bert.py v1_v2 hhar 20_120 -f hhar -s limu_gru_v1 -l 2, this command use this pre-trained model.
And if I want to use hhar dataset and the pre-trained model the command above have any error?
Thanks!

It is not classifier_bert.py, please use classifier.py. The classifier_bert.py is to train the classifier by freezing the encoder. The command is the same.

python -u  classifier.py v2 hhar 20_120 -f hhar -s limu_gru_v1 -l 2
Train Size: 43975, Vali Size: 5495, Test Size: 5507
Balance Label Size: 438, Unlabel Size: 43537; Real Label Rate: 0.010
cuda:0 (1 GPUs)
Best Accuracy: 0.995/0.962/0.967, F1: 0.995/0.958/0.965
Yeah, there's a great result!
But this result is generated by two steps： first, use LIMU-Bert to generate Embedding， second use the Embeddings to train the classifier， two parts can be seen as two individual models, when training the model only one part can update the parameters, and could not update params simultaneity.
Why not train the two parts together? Just because of the results? Or other reasons?

Yeah, you can train them together. The two steps are for improved efficiency. 1) To evaluate the performance of LIMU-BERT on different tasks, we are able to reuse the embeddings in the first step with such a design. 2) We do need to infer LIMU-BERT in the second step, which accelerates the classifier training process.


Add a CHANGES entry for fully pluggable groups

Fixes #12283

This pull request is ready to merge

Merged to master.


[WIP] Add approval_required and start_time fields to AoisToProjects model

Overview
Add field to store whether an AOI should automatically add scenes to a project
without approval
Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~

[x] Symlinks from new migrations present or corrected for any new migrations

Notes
Logic for actually using this field will be in a future PR when the feature is more fleshed out
Testing Instructions

Run the migration
Verify that ./scripts/test runs successfully (or just wait for commit build)
Verify in the DB that the new column exists on aois_to_projects

Closes #1765

TODO: add start_time field to model


Channel shutting down chansrv after triggering CVE-2022-23479 check

Apologies if this is not relevant, since it's mostly being triggered by our own code, let me know and I'll close this issue.
We implemented custom RDP channels for our solution in xrdp. Starting a session leads to chansrv shutting down after approximately two hours, and we can see in the logs xrdp closing the transport channel due to CVE-2022-23479 (header size check, implemented in this commit). Given that the header size is some abnormally huge value, like 486539435, there seems to be a memory overflow/underflow somewhere.
This header size is being set in xrdp_mm_chan_data_in, so if our understanding is correct it's coming from one of the channels. The other attributes for this first message, like chan_id or chan_flags, have normal values, but disabling the check for debugging purposes leads to every subsequent message having messed up values for every attribute, so it seems more like something is mangling the transport channel rather than a single malformed message.
We've tried memory debugging tools like DUMA and valgrind in the xrdp-chansrv process, but haven't been able to identify the issue. Interestingly, using valgrind leads to the issue happening in seconds instead of hours. Our custom channel is relatively simple, receiving a single byte message from the client and replying with another single byte message every 5 seconds. We based the implementation on the other chansrv channels, and have validated that no abnormal values are being sent in the send_channel_data() function to chansrv.
It's entirely possible the problem is only in our code, but we're considering if maybe we're triggering some undefined behaviour in the underlying xrdp libraries. We can still post some our channel code if you feel it's relevant. Have you had to debug memory-related issues in chansrv or the transport library in the past? Do you have any suggestions for further testing or other tools we can use to try to identify the issue?

Hi @matt335672,
Makes perfect sense, thank you for your help.
Sorry for not making this clearer in my previous explanation, but it's the xrdp forked process that is hitting the header-size check code, which in turn shuts down the transport channel for xrdp-chansrv. Regardless, I did as you suggested, and have the following backtrace:
#0  trans_check_wait_objs (self=0x28d4eb0) at trans.c:376
#1  0x000000000041d2ae in xrdp_mm_check_wait_objs (self=0x1b8eca0) at xrdp_mm.c:2908
#2  0x00000000004293be in xrdp_wm_check_wait_objs (self=0x1b93970) at xrdp_wm.c:2253
#3  0x0000000000422d56 in xrdp_process_main_loop (self=self@entry=0x1b3f1e0) at xrdp_process.c:287
#4  0x0000000000410947 in xrdp_process_run (in_val=in_val@entry=0x0) at xrdp_listen.c:152
#5  0x0000000000411dca in xrdp_listen_fork (self=self@entry=0x1b3c340, server_trans=server_trans@entry=0x1b42260) at xrdp_listen.c:802
#6  0x00000000004121d9 in xrdp_listen_main_loop (self=0x1b3c340) at xrdp_listen.c:954
#7  0x0000000000406abd in main (argc=1, argv=0x7ffdfe583048) at xrdp.c:709

We've added some custom logging, so some of the line numbers may not match the original source. Checking the trans struct, everything seems normal outside of the header_size:
self->sck = 26
self->mode = 2
self->status = 1
self->type1 = 3
self->trans_data_in = (ttrans_data_in) 0x41b023 <xrdp_mm_chan_data_in>
self->trans_conn_in = (ttrans_conn_in) 0x0
self->callback_data = (void *) 0x1b8eca0
self->header_size = 16715546
self->in_s = (struct stream *) 0x28eaec0
self->out_s = (struct stream *) 0x28d0460
self->listen_filename = 0x0
self->is_term = (tis_term) 0x405dc5 <g_is_term>
self->wait_s = (struct stream *) 0x0
self->addr = '\000' <repeats 255 times>
self->port = '\000' <repeats 255 times>
self->no_stream_init_on_data_in = 1
self->extra_flags = 1
self->tls = (struct ssl_tls *) 0x0
self->ssl_protocol = 0x0
self->cipher_name = 0x0
self->trans_recv = (trans_recv_proc) 0x7efc7f4331a3 <trans_tcp_recv>
self->trans_send = (trans_send_proc) 0x7efc7f4331d5 <trans_tcp_send>
self->trans_can_recv = (trans_can_recv_proc) 0x7efc7f433207 <trans_tcp_can_recv>
self->si = (struct source_info *) 0x1b44e6c
self->my_source = XRDP_SOURCE_CHANSRV

I'm going to try and make this reproducible in standard xrdp, in order to see if it's really due to our code or an underlying bug. I'm thinking maybe adding some dummy behaviour similar to our custom channels to one of the default channels could work. Also, just to be clear, we are using code from the latest release, v<IP_ADDRESS>.
Let me know if there's anything else you want me to check, or any additional information I can provide.

I can see some of that from your trace. self->my_source is showing the read data is coming from chansrv.
The most likely reason is that chansrv is either sending a bad packet, or is writing some extra data on the file descriptor.
One thing you could try doing is adding debugging output to my_api_trans_data_in() in chansrv.c - I think this is where your data will be entering chansrv but it's not an area I'm intimately familiar with, so I could be wrong. Please tell me if I am.
Another things you might do is add logging to xrdp_mm_chan_data_in() in xrdp_mm.c where the header_size is set:-
https://github.com/neutrinolabs/xrdp/blob/d7c3809ce859760ebe92e3daafb78b8607aa2234/xrdp/xrdp_mm.c#L1626-L1636

Hi @vscfreire
Can I give you any more help with this?

Hi @matt335672,
Thank you for your support. The --enable-devel-all run-time checks showed some overflows in our custom code, and we're focusing on that as the possible source of problems.
If we manage to reproduce this issue in base xrdp, we'll create a new issue with more information and reproducible code. I'd say for now we can close this one if you wish.

Let's leave it open for now. I'll close it at the end of the month or thereabouts if I don't hear from you.
Let me know if you need any more help with this.


generic metaclass overload only matches struct metaclasses but not class metaclasses

I’m doing some type dispatching based on *.class overloading. I handle all nullable types in a generic function, so that I don’t have to repeat myself. This seems to work fine both for built-in types and user-defined classes, but not with String?. Take a look at the following example:
def x(t : Int32.class);  puts t;  end
def x(t : String.class); puts t; end
def x(t : (T | Nil).class) forall T; puts t; end

The result of the above is:

x(Int32) # => Int32
x(Int32?) # => (Int32 | Nil)
x(String) # => String

However; the following line yields compile time error:
x(String?)

no overload matches ‘x’ with type (String | Nil).class
Overloads are:
x(t : Int32.class)
x(t : String.class)
x(t : T | Nil.class)

The difference seems to be structs vs classes https://carc.in/#/r/7e3u
struct A; end
class B; end

def x(t : A.class);  puts t;  end
def x(t : B.class); puts t; end
def x(t : (T | Nil).class) forall T; puts t; end

x(B?)

Reduced:
def foo(x : T?) forall T
end

foo("" || nil)

Error: no overload matches 'foo' with type (String | Nil)

Overloads are:
 - foo(x : T | ::Nil)
Couldn't find overloads for these types:
 - foo(x : String)

Reduced:
def foo(x : T?) forall T
end

foo("" || nil)

Error: no overload matches 'foo' with type (String | Nil)

Overloads are:
 - foo(x : T | ::Nil)
Couldn't find overloads for these types:
 - foo(x : String)


Fix Circle CI

You need to touch the example to get it to run. Maybe we should do that and restart CircleCI a few times. Did you look at the CircleCI log from the failure I linked to in my other comment? It had some weird messages

I'm going to disable it for now
https://circleci.com/gh/mne-tools/mne-python/12458?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification

I'll close this one, open new PR to rename back to plot_lslclient_rt.py when you are ready

The error log seems to tell me that there is some issue with pylsl and not just a random error ... I think users might hit it as well


Issues with shared files

Deployer version: v7 beta 13

I copied over my shared files and dirs settings from a working pre v7 beta project but shared dirs are just created but empty and shared files are created with the correct file name but are just empty files.

What content of such files should be? And what in shared dirs?

What content of such files should be? And what in shared dirs?

In this case the file is a php file, which is created but empty (0 kb). The dirs should contain various sub dirs and files but on the server then, there is only the folder structure defined in the code below but no sub dirs or files in it. In v6 I started my project in development without any shared dirs/files. In production I added those lines and after the next deployment all relevant files were copied to the shared dir.
add('shared_files', [
    'config/statamic/protect.php'
]);
add('shared_dirs', [
    'content',
    'public/assets',
    'users'
]);

This time my workaround was uploading the files manually to the shared dirs

In this case the file is a php file, which is created but empty (0 kb). The dirs should contain various sub dirs and files but on the server then, there is only the folder structure defined in the code below but no sub dirs or files in it. In v6 I started my project in development without any shared dirs/files. In production I added those lines and after the next deployment all relevant files were copied to the shared dir.
add('shared_files', [
    'config/statamic/protect.php'
]);
add('shared_dirs', [
    'content',
    'public/assets',
    'users'
]);

This time my workaround was uploading the files manually to the shared dirs

You think shared file should be copied other on if it’s missing?

You think shared file should be copied other on if it’s missing?

I expected the files to be copied/moved to the shared dir with the first deploy after shared dirs and/or files are added to the deploy.php. In v6 it worked this way, I think.

I expected the files to be copied/moved to the shared dir with the first deploy after shared dirs and/or files are added to the deploy.php. In v6 it worked this way, I think.


How could I use PerRequestLifetimeManager with .Net Core 3.1

PerRequestLifetimeManager is in unity.mvc ,but unity.mvc doesn't support NetCoreApp，
how could I use PerRequestLifetimeManager  with asp.net webapi core  3.1?

You could just copy source and use it in your project

I think that it's not necessary anymore, you should use Hierarquical Lifetime Manager and add scope on each request.


[alpaka] Update the develop branch to 2022.03.10 / 4189bd1e2d

Update the version of alpaka to the HEAD of the develop branch as of 2022.03.10, corresponding to the commit 4189bd1e2d .
Relevant changes:

remove the alpaka::extent namespace;
use alpaka::getNativeHandle instead of data members.

Other changes:

rename getDevIndex to getDeviceIndex;
check that the index used to select the devices matches the one returned by getDeviceIndex.

Tested on patatrack02 with multiple GPUs:
$ ./alpaka --cuda --numberOfThreads 20 --numberOfStreams 20 --maxEvents 20000 --validation
Found 5 devices:
  - NVIDIA A10
  - NVIDIA A10
  - Tesla V100-PCIE-32GB
  - Tesla T4
  - Tesla T4
Processing 20000 events, of which 20 concurrently, with 20 threads.
CountValidator: all 20000 events passed validation
 Average relative track difference 0.000893301 (all within tolerance)
 Average absolute vertex difference 0.0005 (all within tolerance)
Processed 20000 events in 6.907347e+00 seconds, throughput 2895.47 events/s, CPU usage per thread: 52.4%


chore(deps): upgrade project dependencies

Upgrade all project dependencies except coverage.

:tada: This PR is included in version 1.0.2-rc.1 :tada:
The release is available on:

v1.0.2-rc.1
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

v1.0.2
GitHub release

Your semantic-release bot :package::rocket:


Exit Syscall

We're not actually intercepting exit() in SafePOSIX. This was causing some bugs in my pipe tests, because exit should close fds, including pipe-ends.
It's also adding overhead by not cleaning up the now dead data structures.
We should add interception to NaClSysExit, add RPC, and create a function in SafePOSIX which calls close on all open fd's and cleans up the data structures.

@kliu513 seems to have mostly finished this addition. I'd like to see an additional test since pipes were why we caught this issue.
We should run test programs using pipes to make sure the fd's have closed properly.
Let's run a script through lind bash that does this.
We should run
lind /bin/bash pipescript where pipescript is the following:
#!/bin/bash

./write_to_pipe.nexe | ./read_from_pipe.nexe

write_to_pipe.c
#include <stdio.h>
#include <fcntl.h>
#include <stdlib.h>
#include <unistd.h>
#include <time.h>

#define WRITE_BUFFER_SIZE    1UL << 14
#define NUMBER_OF_WRITES     1UL << 11

int main()
{

    char buffer[WRITE_BUFFER_SIZE] = "";

    for (int i = 0; i < WRITE_BUFFER_SIZE; i++) buffer[i] = 'A';

    clock_t before = clock();

    for (int count = 0; count < NUMBER_OF_WRITES; count++)
    {
        if (count == (NUMBER_OF_WRITES - 1)) buffer[WRITE_BUFFER_SIZE - 1] = '\0';
        write(STDOUT_FILENO, buffer, WRITE_BUFFER_SIZE);
    }
    clock_t difference = clock() - before;
    int msec = difference * 1000 / CLOCKS_PER_SEC;

    fprintf(stderr, "write msec: %d ms\n", msec);
}

read_from_pipe.c
#include <stdio.h>
#include <fcntl.h>
#include <stdlib.h>
#include <unistd.h>
#include <time.h>

#define READ_BUFFER_SIZE    1UL << 30
#define READ_BUFFER_CHUNK   1 << 17

int main()
{

    char* buffer = (char*)calloc(READ_BUFFER_SIZE, sizeof(char));

    int total_read = 0;
    int readlen = 0;

    clock_t before = clock();
    while((readlen = read(STDIN_FILENO, buffer + total_read, READ_BUFFER_CHUNK)) > 0){
        total_read += readlen;

    }
    clock_t difference = clock() - before;
    int msec = difference * 1000 / CLOCKS_PER_SEC;

    fprintf(stderr, "read msec: %d ms\n", msec);

}

Alright this is tested and merged. Good job @kliu513 !


[Pendragon 6] - Update pendragon.html - Fixing repeating container bug

Fixing repeating container bug in the squire section The syntax was wrong hence making the line unusable

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[x] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.

Hey @Greyblade ,
It looks like you're modifying compiled html files directly here - you'll probably want to edit the pug files, and recompile instead, or your change will be lost the next time it's recompiled.
This is also a publisher sheet - just checking that you've got permission to make this change?

Hi there
I am proposing the chance on my own.
No worries I will ask Chaosium directly :)
Thank you


ePub support and workflow to automate moving content to Kindle

Excellent project, looking forward to seeing ePub support
The idea is similar as you mentioned in the Readme to automate the workflow moving the content from Notion to Kindle automatically. Any idea or article how this workflow can be implemented?

Hi @furqansafdar; Thank you for the kind words. 🤗

ePUB support: Strictly speaking it should be easy, but only problem is that it requires a lot of manual testing to ensure that all notion blocks gets into the export in the desired format. (But I've been procrastinating this feature a lot. Let me work on it).
There are many ways, I had a simple (custom) github action workflow to run everyday (at say, 1700 hrs) and perform the following actions:
a. Use this notion-to-ebook package to get the pdf of the desired document.
b. Now send an email (you can use sendgrid), to send the email to your kindle device.

Let me know if anything was unclear. Or if you want me to have the workflow setup in a public repository. 🙌

Excellent, It would be really good to see ePUB support being added.
For the workflow, let me try that out myself and if i couldn't do it, I'll discuss it with you again. Btw, don't we require to change the token value for each run?
There was however another objective I was thinking about of syncing Notion content to OneNote for example for offline viewing. I know for sure that markdown content cannot easily fit or formatted well in OneNote but atleast it would allow contents accessibility in offline scenarios. Do you have any idea if this can be achieved?

Btw, don't we require to change the token value for each run?

Usually websites don't let the token expire if it's being used regularly. I feel the same for Notion too. The last time I worked on it, the same auth token worked fine for more than 2 months. (After which I killed the workflow, as stopped using kindle).

syncing Notion content to OneNote

That's interesting. We should be able to create the page using the HTML content. (Ref: https://learn.microsoft.com/en-us/graph/onenote-create-page). So we can do this one-way sync (from notion to onenote). I believe we can have a workflow for this too. :)

Sounds awesome, so formatting will not be an issue and yes one-way sync is fine as long as we can update the same page instead of creating new ones in OneNote.

Hello, just wanted to say that I would love the ePub support feature!

Any plans to enhance for oneway sync to OneNote as we discussed earlier?

Hi. @furqansafdar, this package was never meant for that purpose. But you can setup a workflow (using GitHub action), use this package for auth, downloading relevant assets, etc and then get the one-way sync. https://github.com/subhamX/notion-to-ebook/issues/4#issuecomment-1365782434 shares on bit more on how to do it.

Hi @subhamX,
Unable to setup workflow correctly to move contents to Kindle after many attempts as being new to GitHub Actions. Would you please provide the setup details placing it in a public repository if convinent for you?

My apologies for the late reply. The task sounds interesting, but I don't think I currently have the bandwidth. Still, I will give it a shot this or the next weekend (no promises though 😥).

Anyhow, I am using VS Code now and trying to inspect the HTTP traffic through Fiddler but somehow it is not logging the traffic there even after setting the proxy to http://localhost:8888/ in the VS Code for troubleshooting. Would you be able to tell how you normally do this inspection?

I usually do not use any such apps. Network tab in the browser is my goto tool. I do have the burp suite though, it comes handy in certain situations.

My apologies for the late reply. The task sounds interesting, but I don't think I currently have the bandwidth. Still, I will give it a shot this or the next weekend (no promises though 😥).

Kept waiting for you on this, hope you have aquired some bandwidth to help me on setting up this :)
Eariler I tried myself but couldn't succeed in setting up auto syncing notion pages to Kindle and therefore I forgot to follow up.

Here is the repo I have setup to automate the process.
https://github.com/furqansafdar/notion-to-kindle

Thank you for your patience. Unfortunately, my bandwidth hasn't quite expanded for side projects as much as I'd hoped. Still, let me try to get the root cause of the problem.
Let's keep ePub support out of discussion for now. What's the problem you're facing? notion-easy-export tool should be able to give you a pdf, and now all we need to do is to send an email with something like AWS SES.


Can this plugin be used to access notification sounds also (ios)?

Sorry for the late response, this https://github.com/TUNER88/iOSSystemSoundsLibrary repo shows the list in iOS 7.0.2. Based on this note on Apple's docs [(link),https://developer.apple.com/documentation/audiotoolbox/1405202-audioservicesplayalertsound?preferredLanguage=occ:], we don't have access the "internal" sound clips:
Note System-supplied alert sounds and system-supplied user-interface sound effects are not available to your iOS application. For example, using the kSystemSoundID_UserPreferredAlert constant as a parameter to the AudioServicesPlayAlertSound function will not play anything.


Stop timer at Wrapper::onExpired() when server is inactive (#420)

Note, that this uses close(true) - do not wait for a lot of time since server hasn't responded  for about 1.5 timeout seconds.

[ ] check ev_ref/ev_unref

I think the issue #420  is closed by #423, so we can close this PR.


Fix local testing

@ftomassetti this works for me, can you check the same ?
(this PR doesn't fix the maven plugin tests, which would require help from @jimidle)

I tried to run the tests locally, I am not sure if the PR is expected to fix running tests, but just in case this is useful this is what I get.
I tried to:

clean the repo (git clean -fdX && mvn clean)
install mvn install -DskipTests=true -Darguments="-Dmaven.javadoc.skip=true" -B -V
run mvn test

This fails locally:
[INFO] ANTLR 5 ............................................ SUCCESS [  0.224 s]
[INFO] ANTLR 5 Runtime .................................... SUCCESS [  4.604 s]
[INFO] ANTLR 5 Kotlin Runtime ............................. SUCCESS [ 17.654 s]
[INFO] ANTLR 5 Tool ....................................... SUCCESS [  5.553 s]
[INFO] ANTLR 5 Maven plugin ............................... FAILURE [  5.269 s]
[INFO] ANTLR 5 Runtime Tests (4th generation) ............. SKIPPED
[INFO] ANTLR 5 Tool Tests ................................. SKIPPED

If I then move into runtime tests and run mvn test. I get some failues.
For example:
[ERROR] Tests run: 663, Failures: 28, Errors: 0, Skipped: 0, Time elapsed: 73.374 s <<< FAILURE! - in org.antlr.v5.test.runtime.java.api.TestExpectedTokens

If I then move into tool tests and run mvn test that succeeds.

Thanks
We'll have to understand why the runtime tests fail locally when they succeed in the CI, but that's progress

If I run:
mvn -Dtest='java.**' test
or
mvn -Dtest='kotlin.**' test
I suspect that mvn test fails because it also tries running ts/js tests, which haven't been migrated.
(we're only keeping the code here for later use)

I am in the middle of relocating so I will be out until next week. But I
hve locally revamped the whole Maven stuff and fixed the build anomalies.
I'll have to check it. There is also an old plugin that I will have to
rewrite as it is for an older version of Maven. Hopefully I can get back to
this soon.
Jim
On Wed, Feb 7, 2024 at 7:23 AM ericvergnaud @.***>
wrote:

@ftomassetti https://github.com/ftomassetti this works for me, can you
check the same ?
(this PR doesn't fix the maven plugin tests, which would require help from
@jimidle https://github.com/jimidle)
You can view, comment on, or merge this pull request online at:
https://github.com/antlr/antlr5/pull/27
Commit Summary

32c4346
https://github.com/antlr/antlr5/pull/27/commits/32c43469c1b9310b376ddb3e0ad363b5c564bdb7
rename for consistency
8b1e1da
https://github.com/antlr/antlr5/pull/27/commits/8b1e1da27a856baa45fe96c64857ac354b02b9ba
fix build order
a57a273
https://github.com/antlr/antlr5/pull/27/commits/a57a273c6fb019f8c76a16a564613a8dcfcfd7f9
fix remaining v4 names
52a8e03
https://github.com/antlr/antlr5/pull/27/commits/52a8e03bafbcabd4bb976b38ab38c1e3bb3bd55c
fix test sources dir

File Changes
(12 files https://github.com/antlr/antlr5/pull/27/files)

M antlr5-maven-plugin/pom.xml
https://github.com/antlr/antlr5/pull/27/files#diff-fbca1944130e6d589f9dddb93d1b80c9164a621a1f0cb801fde045b15e36a6e4
(2)
M
antlr5-maven-plugin/src/main/java/org/antlr/mojo/antlr5/Antlr5Mojo.java
https://github.com/antlr/antlr5/pull/27/files#diff-c7a16112855af975b2f14a78becdce27dcaf377a629d81330a7905e7433d04f0
(2)
M antlr5-maven-plugin/src/site/apt/examples/libraries.apt.vm
https://github.com/antlr/antlr5/pull/27/files#diff-1a7284280a74b4f4807978f2ce6abdc764cb592ab8baeb280f68f551cb59ff0c
(2)
M antlr5-maven-plugin/src/site/apt/index.apt
https://github.com/antlr/antlr5/pull/27/files#diff-934f83cd731b078c568146e15106e38dbbed3aad3f592562f076c1ea4c514ba6
(4)
M antlr5-maven-plugin/src/site/apt/usage.apt.vm
https://github.com/antlr/antlr5/pull/27/files#diff-e522e412a6fd946160820971d46ecddbc3cc3e962505482c3c6883dd2fd6ecbb
(2)
M antlr5-maven-plugin/src/site/site.xml
https://github.com/antlr/antlr5/pull/27/files#diff-ba1ed912e0b025aec44e7db5cf8034077e0d6226ffc007a5327de69b53d33cb4
(2)
M
antlr5-maven-plugin/src/test/java/org/antlr/mojo/antlr5/Antlr5MojoTest.java
https://github.com/antlr/antlr5/pull/27/files#diff-27968e05a2b01234fb03e89bd7c0b200528199b0e941b027cd7ba0c500846c1c
(2)
M pom.xml
https://github.com/antlr/antlr5/pull/27/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8
(2)
R
runtime-testsuite/test/org/antlr/v5/test/runtime/kotlin/commonTest/org/antlr/v5/runtime/kotlin/BitSetTest.kt
https://github.com/antlr/antlr5/pull/27/files#diff-cd6b32305df280719f61f1cd0fedc149389847cad47758a66dddd340581c796a
(2)
R
runtime-testsuite/test/org/antlr/v5/test/runtime/kotlin/commonTest/org/antlr/v5/runtime/kotlin/CharStreamsTest.kt
https://github.com/antlr/antlr5/pull/27/files#diff-ddfc3f2ba5b3ade06a7dbbc67dfa5488a5030dc27ff2397f3cb60512be3cd090
(0)
R
runtime-testsuite/test/org/antlr/v5/test/runtime/kotlin/commonTest/org/antlr/v5/runtime/kotlin/StringCharStreamTest.kt
https://github.com/antlr/antlr5/pull/27/files#diff-be974fe9c1e920581690a3cbd3de2627dc3b0a1f442aaac571f2452bec4652a2
(0)
R
runtime-testsuite/test/org/antlr/v5/test/runtime/kotlin/commonTest/org/antlr/v5/runtime/kotlin/misc/IntegerListTest.kt
https://github.com/antlr/antlr5/pull/27/files#diff-2a3a75a84bb8dd2198d6be456a4b43ee9bcfba6851e072259bf624f4a7ea5611
(0)

Patch Links:

https://github.com/antlr/antlr5/pull/27.patch
https://github.com/antlr/antlr5/pull/27.diff

—
Reply to this email directly, view it on GitHub
https://github.com/antlr/antlr5/pull/27, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ7TMDUNVSPT3IDM4DRLV3YSO2C3AVCNFSM6AAAAABC6AX2HKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZDGMRXG43DEOI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Just as an update, I get the exact same results from two different machines (both macs)

I'll give it ago this afternoon, let's see if I can repro too.

I can run tests correctly with:
cd runtime-testsuite
mvn -Dtest=kotlin.** test
mvn -Dtest=java.** test

Which is what CI does.
Running mvn test fails tho, it seems on JS tests, which we don't need anyway.

Yes, that works (with the slight changes of adding " around the -Dtest parameter).
Are instead the tests of the maven plugin expected to fail?

Are instead the tests of the maven plugin expected to fail?

Plugin's tests use takari-plugin-testing, which received its last meaningful update more than three years ago. At this point testing with anything above Maven 3.6 is likely to fail.


MC_36: Slider ball is slightly cut off from right side

RELEASE: v0.6.0
SEVERITY: Minor
MODULE: Mountain Chart
OS/BROWSER: Windows 7 / Chrome 45.0
STEPS TO REPRODUCE:

Navigate to URL: http://static.gapminderdev.org/vizabi/release/v0.6.0/preview/mountainchart.html
Mountain Chart page will be loaded
Click on Full under label Responsiveness
Note that slider ball is truncated from right side

ACTUAL RESULTS:
slider ball is truncated from right side
EXPECTED RESULTS:
Slider ball should be appear in in complete spherical shape
SCREENSHOT:

Can't reproduce this issue on develop branch.

@IncoCode
At this moment, not able to load Mountain chart in release 0.6 as tried many times. we can retest it, once release 0.7 will be available.

Might be fixed, can't be reproducible also on my side as checked on develop branch


R u still working?

If yes, I want to help u, but idk how. Tell what I need to know and to do.
Knowledge languages: C, C++, C#, Java and others.
PS: I never have programmed for games.

Sorry, wrong way

Hello @JvDelicia
no I am not playing the game anymore.

Hi @JvDelicia
It is very hard for me to understand the existing source code.
Also I dont know if there is any possibility to synchronize roads, buildings, ...
I also don't play this game at the moment. But I think it would be nice to play with friends together.


🎨 Add colours in Rust

🎨 Add colours in Rust. I had to do quite a lot of refactoring.

This change is

Having the file split in the same commit as the rest makes it a lot harder to review, but I guess we have to live with that


Feature Request: Give all roll messages generated from a chat button a flag linking back to their parent card

I'm asking because it'd make PF2e Target Damage work slightly but significantly better, but there's probably lots of reasons this might be useful I'm not thinking of.

I expect we would sooner combine the rolls into a single message

Still, the ability to reference what message caused another would be great functionality even if chat cards would be compressed into one.
Currently Pf2e Target Damage does this through adding the message ID to the roll options, but it requires replacing the roll buttons (Damage, Saving Throw) with my own version.


Ordered and Unorderd list should be removed when again clicking on ordered and unordered icon from the toolbar.

Version
3.2.1
Development Environment
All Browser and OS system
Current Behavior
When selecting multiple line codes and clicking on the unordered list then the selected multiple lines convert to unorder list but selecting the unordered list and clicking on the unordered list icon from the toolbar again will not remove the unordered list. we have to remove the unordered list line by line.
Expected Behavior
When selecting an unordered list and clicking on the unordered list icon from the toolbar then the selected unordered list should be removed.
Loom Issue Video
https://user-images.githubusercontent.com/36799606/201846952-dc459869-303d-4119-ae7a-ceb39a7a41e3.mp4

Thank you for the issue. I think your opinion is a valid UI/UX. We will check on this later.


Updating Simplified Chinese translation

refer to PR #58

Great!  Thank you very much! Also a reminder that I still need to add a thank you note for you.  You can respond here with that info or email<EMAIL_ADDRESS> Thanks :)

Oh sorry I missed your comment in the other PR.  Will add to the about page shortly. :)


Stroke style changes when crossing some longitudes

Seems to happen at multiples of 90 degrees.

@rsupnekar Have you had a chance to validate the fix from NASAWorldWind/WorldWindAndroid#173 ?

Yes.


GH-2478 Handle conversion exception in AsyncRabbitTemplate

Previously, conversion errors in AsyncRabbitTemplate lead to AmqpReplyTimeoutException
Fixes https://github.com/spring-projects/spring-amqp/issues/2478
https://github.com/spring-projects/spring-amqp/issues/2478#issuecomment-2543745530

@BenEfrati Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@BenEfrati Thank you for signing the Contributor License Agreement!

Hi,
Sorry, at first I fork and created branch from old code, missed the import after sync with upstream.
https://github.com/BenEfrati/spring-amqp/commit/50452f89c3c306cc6dcad5b7dee27c036ffa81ac
Pushed the fixed code

@BenEfrati ,
thank you for contribution; looking forward for more!


Show intersection of overlays

I use Leaflet.Control.Layers.Tree to display properties that I import via a GeoJSON file.  That you very much for this.
I create an overlay that contains for example all houses that are for sale. Another overlay shows all objects that are suitable for living in.
So far so good.

Via Radio Group a user can display either all houses for sale or all houses that can be lived in.
With the Checkbox he can display the sum of all saleable and livable houses, if he activates both overlays.

Now I would like to display the intersection. So I want that if both checkboxes (sellable and livable) are checked, only houses that are sellable and livable are shown. Properties that are sellable but not livable should not shown.
At first glance, it looks to me like it is mandatory that I create a separate layer for this and add it to the tree. But I have the feeling, that others have this issue too and there must be a better solution for this!
It would be kind, if someone can point me to a better solution.

This plugin is designed to work with Layers, enabling or disabling them. You want to go further, and add some logic depending on how the different layers are selected. Such a functionality is not there.
However, you can try to implement the logic in your code, using the tree just as the UI tree. Try adding "virtual layers" (maybe an empty layerGroup?). Then, when a "virtual layer" is added or removed (there are Leaflet events for that), you add or remove your data. For that you have to keep the state, or ask the map if a layer is in the map or not every time.
You can have a look at the advanced functionality eventedClasses (not very tested), but I think it is not what you need.
If you get a nice solution, you can share it with us :)

Thank you very much for your feedback @jjimenezshaw
You are right. This plugin is for displaying the layers and not for creating them. But it could have been that someone here already had the same problem and solved it. I'm planning a solution right now. When I have one that is generally usable, I'll be happy to share it here.


Create alwaysblue

Hi @natereid72 it looks like you didnt include the .yml extension on your filename, so the automated workflow that normally processes your request did not trigger. If you could please redo the steps but include .yml extension on the filename, that should work. Thanks!


Support for accessing Python scope

According to pyodide runPython can return a value https://pyodide.org/en/stable/usage/quickstart.html?highlight=expression#running-python-code
I was looking to the code and I see that you wrap the run call into an exec method which is part of the problem here.
Right now I don't really understand why this wrapper is here and I assume that's because I'm pretty new to the python engine.
In an other hand I don't see how to get anything else then stdout and/or stderr with this hook.
I'll be happy to contribute if you think that could be a great enhancement to get the result of code execution and/or share some variables like globals for exemple.

Hi, are you asking why the runPython function doesn't return a value? If so I'm happy to explain this further.
We're always looking to improve the API to make it more useful, so suggestions are certainly welcome.
Currently, there isn't support for directly accessing the Python scope (i.e. globals) from JavaScript, or vice versa. Ideally, I'd like to support this behaviour but due to using web workers to run the Pyodide instances, this is tricky to get working.

My first question is why are you using python's exec function instead of a direct execution.
Then I would like to use this hook to run a python script that computes a value and use this value in javascript. If you have some idea on the way to add this I can contribute in that way :)

To answer your first question, every execution is wrapped in some additional Python code to improve the default error handling behaviour.
Getting the value of variables directly from Python (other than from stdout) is currently unsupported, so I'm unable to provide any examples of this just yet. We're looking into supporting access to globals, so once I have more to share I'll update this issue with further information.

ok, thank you for your answer

Hi,
Very exciting project!
I had initial success interoperating a React app with NumPy/SciPy for scientific computing.
For now, the numerical array data in TS is passed to Python by embedding it in the Python script string, and the result from Python is passed back to TS through stdout.
A smoother interoperation is crucial, and I am very much interested in the progress of this issue.
It seems that you have a PR on accessing the Python global scope hanging around for a while https://github.com/elilambnz/react-py/pull/71
What is holding back from merging this?
Thanks!

I have forked and added the feature of getting value from globals

This removed the improved error handling.


changed the parity default port to the current port number (see https…

…://github.com/ethcore/parity/wiki/Basic-Usage). Also added this to the constructor of the parity subclass.

Thanks @jo-tud .


[Communication - Calling] Failed to start Screen Share

Package Name: @azure/communication-calling
Package Version: 1.30.4
Operating system: Windows
browser
name/version: Chrome(122.0.6261.131) and Edge(131.0.2903.63)

Describe the bug
Screen share failed to start on following the steps mentioned below.
Note: Issue is specific to Group Calls. Not happening on 1:1 calls
Steps To Reproduce on Sample App

Launch ACS Calling Sample app (**using 1.27.1-beta.1 as of today)
Join a group call

I got two users in the group call

Turn ON Local camera
Start Local Screen share
Turn OFF Local camera
Start Screen share from remote
Turn ON Local camera

Note: App crashes at this stage if using Edge. See the 'Actual behavior' section for more info

Start Local Screen Share

Expected behavior: Starts Screen share from local end.
Actual behavior: Outcome is different based on the browser we use,

Chrome

Screen share not started and got the following error logs

Edge

App crashes on Step# 7.

We are still experiencing this regularly and the crashes are obviously problematic. Is there any way that we can get this prioritized?


Closes #73 73 format testthat

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue so that it closes after successful merging.
[x] Address all merge conflicts and resolve appropriately.
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63 , yes, fine with me.

@bundfussr Hey Stefan.  Made a few additions to the vignette.  Hope that is okay and up version the news and description.

@bms63 , thanks for your updates. I fixed the checks (spelling and links). I have also rephrased the part where to create the test script such that it does not refer to admiral core.


Docstrings for azure-storage-blobs

Customer-facing docstrings for blobs.

Can one of the admins verify this patch?


How to use coverage to get the test execution report?

Is your feature request related to a problem? Please describe.
We have to use sonarqube as part of our deployment cycle. Sonarqube needs as input a test coverage report and test execution report. I am using written all my tests using python unittest and coverage to create the coverage report. But it seems that coverage does not provide the test execution report to feed it to sonarqube.
Describe the solution you'd like
A parameter to add to coverage command to get the test execution report.
Additional context
If I am wrong and there is already a solution for this in coverage, please tell me.

I'm not sure what test execution report you're looking for.  Keep in mind that coverage doesn't run your tests.  Your test runner (pytest, unittest, etc) runs the tests, knows what tests were run, and which succeeded and failed.  I think perhaps you are looking for a report from your test runner.


No parameter intelligence for classes

@SimantoR commented on Sun Apr 21 2019

Environment data

VS Code version: 1.33.1
Extension version (available under the Extensions sidebar): 2019.3.6558
OS and version: macOS 10.14.4
Python version (& distribution if applicable, e.g. Anaconda): 3.7.2
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Relevant/affected Python packages and their versions: TensorFlow=2.0.0a0

Expected behaviour

Actual behaviour

@ericsnowcurrently commented on Mon Apr 22 2019
Hi @SimantoR, thanks for letting us know about this problem.  First off, I'm guessing that you have the "Expected" and "Actual" switch above. :)  As to the problem, are you using Jedi or the new language server (see #3977)?

@SimantoR commented on Mon Apr 22 2019
Its the language server in use right now. Jedi does show the parameters. Well more like what ever fits in the box width-wise, rest is underput by the description. But with the language server (that analyzes for a bit), no parameters. I noticed this while using the classes under keras.layers

I believe this is #983.