Add find/fix missing packages for markdown_pkg

Tasks

[ ] Refactor find/fix missing pkgs for bzlformat to a shared utility //bzllib/tools.
[ ] Update bzlformat find/fix to use the shared utility.
[ ] Implement find/fix missing pkgs for markdown.
[ ] Remove doc_files filegroup targets and use the ones defined by markdown_pkg.

I am going to defer implementing this until I have implemented markdown_format.


robotidy screws up the syntax in python files

before:
def foo() -> None:
    if True:
        ...

command:
robotidy main.py

after:
def foo() -> None:
    if True:
...

i think robotidy should throw an error when you attempt to run it on a python file.
use case: i have vscode configured to run robotidy when saving .robot files, however there seems to be an issue with the extension i use where it sometimes attempts to run it on the wrong file (https://github.com/Gruntfuggly/triggertaskonsave/issues/24), which means robotidy sometimes incorrectly runs on .py files

Thanks for the report - yeah it's not expected behaviour. You already found the place where robotidy takes care of paths in your attached PR -> we should update logic here so files provided from cli are also checked against our exclude/include options.


SuperH4: SH7091 Processor Support

SuperH4 SH7091 processor support. The SH7091 is basically a stock SH-4 with the addition of the  "fsca" and "fsrra" instructions that are normally listed as SH-4A exclusive. The SH7091 is most notably used in the Sega Dreamcast console and the Naomi arcade board. I have implemented both instructions as pcodeops.
PR closes tickets https://github.com/NationalSecurityAgency/ghidra/issues/1730 and https://github.com/NationalSecurityAgency/ghidra/issues/4194.

Hi @mumbel,
Good catch. I had tried this:
	FRN_0 = 1.0 f/ sqrt(FRN_0);
Which fails with:
ERROR SuperH4.sinc line 3090: no viable alternative on IDENTIFIER: '.0':

	FRN_0 = 1.0 f/ sqrt(FRN_0);
-----------------^
 (SleighParser_SemanticParser)
ERROR SuperH4.sinc line 3090: extraneous input 'f/' expecting <invalid>:

	FRN_0 = 1.0 f/ sqrt(FRN_0);
-----------------------^
 (SleighParser_SemanticParser)
ERROR Unrecoverable error(s), halting compilation (SleighCompile) ghidra.sleigh.grammar.BailoutException: Abort
	at ghidra.sleigh.grammar.AbstractSleighParser.bail(AbstractSleighParser.java:35)
	at ghidra.sleigh.grammar.SleighParser.spec(SleighParser.java:502)
	at ghidra.pcodeCPort.slgh_compile.SleighCompile.run_compilation(SleighCompile.java:1800)
	at ghidra.pcodeCPort.slgh_compile.SleighCompileLauncher.runMain(SleighCompileLauncher.java:213)
	at ghidra.pcodeCPort.slgh_compile.SleighCompileLauncher.launch(SleighCompileLauncher.java:50)
	at ghidra.GhidraLauncher.launch(GhidraLauncher.java:59)
	at ghidra.Ghidra.main(Ghidra.java:47)

Switching to
	FRN_0 = 1 f/ sqrt(FRN_0);
Like you suggested works. I'll commit the change.

I have added support for the remaining instructions here, if this is useful:
https://github.com/LemonHaze420/ghidra/

Strangely, and seemingly not coincidentally, I have added support for the remaining instructions here... 8 days ago, if this is useful:
https://github.com/LemonHaze420/ghidra/
I have since squashed and committed my changes and submitted a PR #4210

You are a much braver man than I for tackling the pcode. I'll take a look at your PR.

Strangely, and seemingly not coincidentally, I have added support for the remaining instructions here... 8 days ago, if this is useful:
https://github.com/LemonHaze420/ghidra/
I have since squashed and committed my changes and submitted a PR #4210

You are a much braver man than I for tackling the pcode. I'll take a look at your PR.

I would strongly advise continuing with my PR instead, purely due to the quality of the decompilation output provided alone. I worked some time into implementing it and my PR contains commits which are fully complete whereas the one here is not. It is also missing important steps. Thank you for applauding the pcode work! I had a very specific usecase for this and it was really fun implementing the different instructions I needed.

Obsoleted by 5050741?

@jobermayr Yes, this is OBE.


FIX: Check only defined replication rule IDs

To be forward ported through to master branch in S3 and Arsenal.

PR has been updated. Reviewers, please be cautious.

@ironman-machine r+

:hourglass: PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/15442

Hello @LaurenSpiegel
"r+": Success

:sunny: :+1: circleCI test succeeded!


It's not work now

window10
python3.8
Is it need any environment?

I also have the some problem, any suggestion?


Consider supporting dasks

[pasted from an offline conversation with mrocklin]
I would like to utilize dask to parallelize the computation of some of the ‘into’ ETL arcs/production rules by partitioning (given that there is so much high level type information and metadata accessible)

Interesting.
Can you give an example of how you'd like to use dask and odo together? Doesn't have to be super detailed, just a little more than what's in your initial description.
In particular, I'm not sure what aspect of odo graph traversal you'd like to parallelize. You mention partitioning. Are you thinking of something like this (implementation details aside):
df = <huge DataFrame>
odo(df, 'df.bcolz')  # <- there's a dask in the middle that performs parallel writes to a bcolz store?

Thanks for your interest!

I have written a lot of yuck ETL code over the years and yearned for some mechanism where locus of execution, batch size, caching, pre-fetching etc. were orthogonal to the E and T logic. I applaud your design where you have a bunch of knowledge about special case transforms between different data-representation e.g. CSV <-> HDF5 and try to 'do the right thing' in a transparent way and failing over to iterators if the optimization fails. It looks like into/odo does not support much if any by the way of {T}ransform so the shape of the {L}oad destination has to be much the same as the {E}xtract source.
I am excited by dask.bag in the same way as I was excited by SQLAlchemy expression language in that what looks like Python code is actually building up a data-structure behind the scene that when iterated over will cause an intelligent runtime to actually materialize the results. I believe that a dask runtime armed with sufficient metadata and type information from the dask could do a very good job with choosing the locus of execution for parts of the dask tree, running stuff in parallel etc. in the same way that a query optimizer does with a SQL query.
So, I think that some kind of first class support for dasks within odo would facilitate a bunch of filtering/reshaping of data for the {T}ransform stage of ETL. I like the idea of being able to specify the T in what looks like vanilla-ish Python code but having dask+odo figure out and perhaps rewrite the dask so that, say, filter operations are pushed down to the source (e.g. SQL WHERE clause, pytables indexes) and combine/type-conversions done in parallel or at the destination (where 'destination' might be some intermediate representation chosen by the runtime)
I guess my feature request comes more from lots of experience with 'wrong' ways of doing it rather than a firm proposal (other than the sketch/handwaving above) .
In any case, I will be following the development of this project with interest as it looks great. Thanks very much!


about dcap interface version

As commented, the SDK now supports DCAP 1.6 (like sgx_ql_set_path function), yet Intel has released DCAP 1.13 and there are already changes happened (like enum sgx_ql_path_type_t now has 4 variables). Just wondering if there is a planned update to catch up.

I have submitted a  PR #380   which will be merged into master after review.


Add Michael Froh as a maintainer

Description
Michael has graciously accepted our invitation to become a maintainer. Welcome, Michael!
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We can retry checks post #9486


Use the design system for the changelog

The changelog setup by @flickz on https://github.com/opencollective/opencollective-changelog is great. A simple way to make it look better without an input from design would be to use the design system.
Because we don't use a monorepo, sharing the code is not very straightforward.
We have three options to do it:

Copy/paste the theme and components (:cry:)
Export to an npm package
Give a try to https://bit.dev

The third approach has my preference because this is exactly the problem Bit.dev is trying to solve - and I'm curious about it. Doing this for the changelog is a scoped experiment.
Regarding the components to update, I'd say:

Use the typography (H1, P...) for all texts to add consistency on the font(-size)s
Use StyledTag for all tags, try to use the base theme (success, error, info...) as much as possible

This issue should be fairly simple now that we have our design system on https://bit.dev/opencollective/design-system

@Betree : I'll be working on this; hope no one is already on it. :smile:

@SudharakaP check https://bit.dev/opencollective/design-system for installing the components that you need. You'll probably need to create an .npmrc file at the root of the repo with the following content:
@bit:registry=https://node.bit.dev

@Betree : Thanks much for the info. Will do. :+1:

@Betree : I've created a draft pull request for this but there's a small issue blocking this. I cannot import StyleTag at the moment since in StyleTag we use react as a dependency. This creates a problem unless we define react as a peer dependency as mentioned at; https://docs.bit.dev/docs/react-guidelines#add-react-libraries-as-peer-dependencies-with-relaxed-versions. I've opened a pull request for this; can you merge this first, then I think this would work. :smile:


Background download

Thank you for this great library.
Please help with an example how can I setup fetch with FetchNotificationManager so it can continue to download in the background when a user exits the app. I know it can be achieved with a background service but I can't get it to work especially with the background restrictions which requires the  service to run in the foreground.

Thank you!
I have tested the code again, the download notification stays on but actually the download does not continue, after 7 to 10 mins the download resumes and completes. I wonder why Google put time interval even in MICROSECONDS when creating a PeriodicWorkRequest and worker seems to ignore this specified interval.

In terms of the TimeUnit I think Google wanted to keep it standard but did make it clear in the documentation the limit.
Are you able to share sample code, here or via Email in terms of the download notifications?. Email is on my profile page.

Have decided to use AlarmManager and broadcasts. What have done is when the app exits and has active downloads I schedule a repeating alarm within 2 seconds and a receiver keeps the instance of fetch running when the app is closed and the download continues. It seems to work but have to run more tests


Getting Error to Render the DB diagram

Below is the error snap, it's throwing while rendering and nothing came up in Preview.

I think this extension is not considering or parsing the alias name for tables, due to which it's throwing this error.

Hi, the use of alias should be possible with the last version
Table posts as P {
id integer [primary key]
title varchar
body text [note: 'Content of the post']
user_id integer
status varchar
created_at timestamp
}
Ref: P.user_id > users.id // many-to-one


Docker install does not work on Ubuntu 20.04

I tried multiple install settings, several rebuilds.  It all starts fine, trying to connect via HTTPS gives a 500 Internal server error. .. one time I got an API error instead.  Nothing I tried worked.  Any magic I'm missing?

Hi! Could you post full list of settings you have used? That's basically:
cat .env # execute in bitcart-docker dir
cat /etc/profile.d/bitcartcc-env.sh

Please redact any sensitive settings if needed. That error may often occur when https is not enabled, i.e. BITCART_REVERSEPROXY != nginx-https
Another case is that https certificate was failed to acquire
Some logs may be useful, please send
docker logs compose_backend_1
docker logs compose_admin_1
docker logs letsencrypt-nginx-proxy-companion

Ok now we're narrowing it down... LetsEncrypt issues.  What should i be setting in env for it?

root@crypto1:/home/jd/bitcart-docker# docker logs letsencrypt-nginx-proxy-companion
Info: running acme-companion version v2.1.3
Warning: '/etc/acme.sh' does not appear to be a mounted volume.
Info: 4096 bits RFC7919 Diffie-Hellman group found, generation skipped.
Reloading nginx docker-gen (using separate container nginx-gen)...
Reloading nginx (using separate container nginx)...
Warning: /app/letsencrypt_service_data not found, skipping data from containers.
Sleep for 3600s
2022/02/06 18:01:40 Generated '/app/letsencrypt_service_data' from 12 containers
2022/02/06 18:01:40 Running '/app/signal_le_service'
2022/02/06 18:01:40 Watching docker events
2022/02/06 18:01:40 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/signal_le_service'
[Sun Feb  6 18:01:41 UTC 2022] Create account key ok.
[Sun Feb  6 18:01:41 UTC 2022] Registering account: https://acme-v02.api.letsencrypt.org/directory
dgst: Can only sign or verify one file.
[Sun Feb  6 18:01:42 UTC 2022] Registered
[Sun Feb  6 18:01:42 UTC 2022] Can not find account id url.
[Sun Feb  6 18:01:42 UTC 2022]
[Sun Feb  6 18:01:42 UTC 2022] The account url is empty, please run '--update-account' first to update the account info first,
[Sun Feb  6 18:01:42 UTC 2022] Then try again.
Reloading nginx docker-gen (using separate container nginx-gen)...
Reloading nginx (using separate container nginx)...
Creating/renewal crypto1.MYNETWORK.net certificates... (crypto1.MYNETWORK.net)
[Sun Feb  6 18:01:43 UTC 2022] Using CA: https://acme-v02.api.letsencrypt.org/directory
[Sun Feb  6 18:01:43 UTC 2022] Registering account: https://acme-v02.api.letsencrypt.org/directory
dgst: Can only sign or verify one file.
[Sun Feb  6 18:01:43 UTC 2022] Registered
[Sun Feb  6 18:01:43 UTC 2022] Can not find account id url.
[Sun Feb  6 18:01:43 UTC 2022]
[Sun Feb  6 18:01:43 UTC 2022] Please check log file for more details: /dev/null
[Sun Feb  6 18:01:43 UTC 2022] The account url is empty, please run '--update-account' first to update the account info first,
[Sun Feb  6 18:01:43 UTC 2022] Then try again.
Creating/renewal crypto1.MYNETWORK.net certificates... (crypto1.MYNETWORK.net)
[Sun Feb  6 18:01:44 UTC 2022] Using CA: https://acme-v02.api.letsencrypt.org/directory
[Sun Feb  6 18:01:44 UTC 2022] Registering account: https://acme-v02.api.letsencrypt.org/directory
dgst: Can only sign or verify one file.
[Sun Feb  6 18:01:45 UTC 2022] Registered
[Sun Feb  6 18:01:45 UTC 2022] Can not find account id url.
[Sun Feb  6 18:01:45 UTC 2022]
[Sun Feb  6 18:01:45 UTC 2022] Please check log file for more details: /dev/null
[Sun Feb  6 18:01:45 UTC 2022] The account url is empty, please run '--update-account' first to update the account info first,
[Sun Feb  6 18:01:45 UTC 2022] Then try again.

Ok, resolved that with setting: BITCART_LETSENCRYPT_EMAIL
Now it's hanging on something else, let me see what I find.

Weird, did you have it set? It shouldn't be required anyway
Your full list of settings would still help me to find out the cause faster (:
But yeah it is probably SSL fetching issue

Ohh, I can reproduce on a new deployment. It is a regression due to unpinned image upgrading to 2.0.0:
https://github.com/nginx-proxy/acme-companion/issues/510
I will try to fix it soon

It does fetch when I use an admin email but something else is still wrong.  It also seems like it's grabbing a new cert every restart so this happened:
[Sun Feb  6 19:47:49 UTC 2022] Create new order error. Le_OrderFinalize not found. {
"type": "urn:ietf:params:acme:error:rateLimited",
"detail": "Error creating new order :: too many certificates (5) already issued for this exact set of domains in the last 168 hours: crypto1.dyni.net: see https://letsencrypt.org/docs/rate-limits/",
"status": 429
}

[Sun Feb  6 19:47:49 UTC 2022] Create new order error. Le_OrderFinalize not found. {
"type": "urn:ietf:params:acme:error:rateLimited",
"detail": "Error creating new order :: too many certificates (5) already issued for this exact set of domains in the last 168 hours: crypto1.MYNETWORK.net: see https://letsencrypt.org/docs/rate-limits/",
"status": 429
}

A workaround for now would be:
./stop.sh
docker image rm jrcs/letsencrypt-nginx-proxy-companion
docker pull jrcs/letsencrypt-nginx-proxy-companion:v1.13.1
./start.sh

Looks like so, it doesn't mount the new volume dir.
As for too many certs issue you have to wait

Fixed by bitcartcc/bitcart-docker@7f9e90e4d6771f37664368b163bad39d034cd58a
You can now do unset BITCART_LETSENCRYPT_EMAIL and re-run setup (before that, of course update via ./update.sh)
As per the rate limits, probably waiting a bit should help
Let me know when the issue is fixed so that we can close the issue

Well I see some issues with your setup, both store and admin host share URLs
Do you want to run everything on one domain?
If so unset all unneeded variables, do it like so:
unset BITCART_STORE_HOST
unset BITCART_ADMIN_HOST
unset BITCART_STORE_API_URL
unset BITCART_ADMIN_API_URL
./setup.sh

That will enable one-domain mode, so you will access the store at https://crypto-1.mynetwork.net, the admin at https://crypto-1.mynetwork.net/admin and api at https://crypto-1.mynetwork.net/api
See https://docs.bitcartcc.com/guides/one-domain-mode

Ok that worked. thank you sir.
I followed this doc, it might need updating.
https://docs.bitcartcc.com/deployment/docker
"Why was it done like so? It's because it is possible to run Merchants API on one server, and everything else on different servers.
But in most cases, you can basically do:
if https (BITCART_REVERSEPROXY=nginx-https, default)
export BITCART_ADMIN_API_URL=https://$BITCART_HOST
export BITCART_STORE_API_URL=https://$BITCART_HOST
if http (BITCART_REVERSEPROXY=nginx, local deployments, other)
export BITCART_ADMIN_API_URL=http://$BITCART_HOST
export BITCART_STORE_API_URL=http://$BITCART_HOST"

Well it's a description of another posible usecase (onedomain mode off), but right at the top of the page it says:

Here is an example of the setup you will use in 90% cases. Replace yourdomain.tld with your actual domain (for bitcartcc demo, it was bitcartcc.com):
sudo su -
git clone https://github.com/bitcartcc/bitcart-docker
cd bitcart-docker
export BITCART_HOST=yourdomain.tld
./setup.sh

Closing as the issue was resolved, I will look if there is something I can do with the docs
Maybe non-one-domain usage can be moved to advanced section or so


Implementation of prepare_meeting_issues method for GitHubInterface class

The goal is to implement the method  prepare_meeting_issues in GitHubInterface class, part of utilities.creators module.

The code was checked with the following call:
from dynpy.utilities.creators import GitHubInterface
client = GitHubInterface()
client.prepare_meeting_issues()


Bugged when leaving the world with goggles still in curious.

The goggles wont be unequipped and the functions still work across all saves. 1.20.1 latest version.
Bugged when creating a new world

Removing the mod fixes this.

Its not a bug, it's a Feature. The second world is probably a creative world in which you have the goggles without having to wear them in creative mode. You can disable this in the client config.

oh ok mb


Port steps from Citrus repository

Citrus defines some predefined steps, too. Port steps to this YAKS repository

Docker steps
Selenium steps

Docker steps are not going to be ported


client: use next ssh key on HTTP_FORBIDDEN

does #728 replace this?

@mattnworb No the two are unrelated. I havent looked into why tests fail on this one yet.

@rohansingh

Replaced by https://github.com/spotify/helios/pull/749


Autodetecting current width and height of image

Thanks for the great work guys!  You library makes our developer lives so much easier.
I'd like to request for support for autodetecting height and width for images (or this might already be supported and im just not aware of).
I'm trying to load images of different sizes.  There's currently no way for me to know the image sizes ahead.  I'd like the images to just render on the document without specifying a size... OR better yet provide a size (x or y) constraint so they dont go over a specific size (proportionately).  TIA!

👍

For anyone looking for this i'm doing it more or less with this code:
                additionalJsContext: {
                    imageGenerator: function(url) {
                        return new Promise(function(resolve) {
                            var image = new Image();
                            image.onload = function() {
                                var canvas = document.createElement("CANVAS");
                                var ctx = canvas.getContext("2d");
                                const imageDPI = 96;  // Put all your images with the same DPI
                                canvas.height = this.naturalHeight;
                                canvas.width = this.naturalWidth;
                                ctx.drawImage(this, 0, 0);
                                var dataUrl = canvas.toDataURL("image/png", 1);
                                resolve({
                                    height: (this.naturalHeight * 2.54) / imageDPI,
                                    width: (this.naturalWidth * 2.54) / imageDPI,
                                    data: dataUrl.slice(
                                        "data:image/png;base64,".length
                                    ),
                                    extension: ".png",
                                });
                            };
                            image.src = url;
                        });
                    },
                },

Yes, I'd go by @fpuga's suggestion. Thanks!


Golang CI Deprecations

Hey,
on running golangci I got the following output,
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'ifshort' is deprecated (since v1.48.0) due to: The repository of the linter has been deprecated by the owner.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.

Fixed by #169


Add button to start registration again

Nice to have: sometimes registrations get stucked :/ an easy way to explain a user to start over the process would be adding a button to do so.

Keep track of when the user started the process. Then query that with the setInterval, after x minutes, show button to offer to manually start interval again.

2 minutes in main, 5 in testnet?
To test this, use local, ganache, set to NOT auto-mine

Keep track of when the user started the process. Then query that with the setInterval, after x minutes, show button to offer to manually start interval again.

2 minutes in main, 5 in testnet?
To test this, use local, ganache, set to NOT auto-mine


Bumpy required version of pytest to at least 4.6

Bump pytest version to 4.6 as required by pytest-cov.

Coverage remained the same at 100.0% when pulling e73727ebc84f5467ca3315609560234ebe84f4c5 on stuaxo:patch-2 into 1aec93e7627bc99ec4321f1fbc53b20f2602bab1 on sgillies:master.

@sgillies I'm withdrawing this PR.
I assumed Affine would have native code parts, like Planar did, in which case it woul be worth checking Pypy compatibility.
Since they are not there this should just work in Pypy already.


Displaying the Buildroot version

In connection with the transfer of builds to Buildroot LTS version, please make a display of which is currently used on the front page. The information can be taken from /etc/os-release.
Thank you
root@openipc-hi3516ev200:~# cat /etc/os-release
NAME=Buildroot
VERSION=-g1840ef03-dirty
ID=buildroot
VERSION_ID=2023.02
PRETTY_NAME="Buildroot 2023.02"
OPENIPC_VERSION=<IP_ADDRESS>
GITHUB_VERSION="master+1840ef03, 2023-05-14"
BUILD_OPTION=lite
root@openipc-hi3516ev200:~#

done in dev.


Game shortcuts advanced customization

I would like an option to remove some of the installed games. as an example: I have portal and portal 2, but I already finished the first, so I would like to remove it from the list so that when I type gl only portal 2 appears.

Hello. Thanks for contribution!
Yes, it will indeed be very useful, feature to hide certain games from plugin list is on my to-do feature list.

Hello. Thanks for contribution!
Yes, it will indeed be very useful, feature to hide certain games from plugin list is on my to-do feature list.

Thank you!

This feature has been implemented in version 1.5.0: https://github.com/KrystianLesniak/Flow.Launcher.Plugin.GamesLauncher/releases/tag/v1.5.0


Better webpack config

The config has become unwieldy. Consider separating parts of it into dev and prod versions.

Webpack config files now sit within webpack/ directory.


Included NULLCON'19, Goa

Included NULLCON
1st March, 2019
Holiday Inn Resort, Goa

@vamsivd00 Can you point me to a link where the conference lists that it supports CFPs and has a Code of Conduct? This repo only accepts conferences which supports CFPs and I'd like to include conferences which support CoC from now on...


Implementation of setDefaultEventParameters

Theres no other way to include additional parâmeters to an automatic event such as screen_view without the usage of
setDefaultEventParameters.
What I really need is the implementation of the setDefaultEventParameters()
val parameters = Bundle().apply {
this.putString("level_name", "Caverns01")
this.putInt("level_difficulty", 4)
}
firebaseAnalytics.setDefaultEventParameters(parameters)
https://firebase.google.com/docs/analytics/events?platform=android

Hey @hcondottalima did you find a way to send parameters along all requests?

Hello @BkMiguel12, actually i didnt, but I can check with our devs if they found a workaround.


improvement Materialization context and mtmv decoupling

Proposed changes
draft
optmize code  for sync materilaized view
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


Next.js and redux. Populating store on server side does not take effect

Hey, I'm having trouble with redux and nextjs. If that's okay I will post a link to SO question where I described in details what I'm trying to do.
https://stackoverflow.com/questions/45191080/next-js-and-redux-populating-store-on-server-side-does-not-tak-effect

try changing withRedux(initStore() to withRedux(initStore
the initStore function should be passed to withRedux, not executed by you

@jedlikowski my initStore() is a function that returns function
export default function initStore(logActions) {
return function init() {
const middleware = [tokenMiddleware, axiosMw];
if (logActions) middleware.push(logger);
return createStore(getReducer(), applyMiddleware(...middleware));
};
}


Add Guardians and Modules to Peek Mint UI

Worked together with @Kodylow

Added guardians and module_kinds to FederationInvite
Added just watch command
Started a reusable styles file

https://github.com/MutinyWallet/harbor/assets/43247027/084892f4-0ec2-412b-a615-37c393fec8f1

Awesome would it be possible to build this on top of #63?

Closing, rebasing over https://github.com/MutinyWallet/harbor/pull/63
new PR: https://github.com/MutinyWallet/harbor/pull/86


[Discussion] 8-Directional Movement/Animation

Discussion for http://godotrecipes.com/2d/8_direction/

Hi I cant seem to get direction number 4, when I try this.

I fixed it by adding
a = stepify(input_dir.angle() , PI/4) / (PI/4)
a = wrapi(int(a), 0, 8)
to the keyboard-input code section, I copied the way you did it in the mouse control section.

Thanks


Bern features: No tooltip in shared categories of other users

If I select e foreign track and this track contains Mine-Categories those categories get shown to me in a tab named after the owner. But when hovering over the category title or the labels no tool tip appears. Would it be possible to enable the tool tips, which means showing the entire name of the category and label?

I did some investigating, and while it should not be impossible, with the current implementation it seems more work than it's worth. Therefore I would suggest to leave this issue for last, i.e. give it a lower priority than other issue related to "Bern features".

I agree.


[MB-5307] Formik Migration: DOD Info

Description
This PR completes the Formik & Wizard migration for the DOD Info profile step.

Created a new DodInfoForm component that replicates the existing DOD info step, with added tests and Storybook page

There is a minor difference from the current functionality of the DOD ID number input. Currently the input does not accept any values that are non-numeric, which means if a user types in non-numeric characters, nothing happens. This can be a confusing UX that might feel broken. The new functionality is that the input will accept up to 10 of any type of character, but if the value is not 10 digits an error message will display. See the screenshot below and related Slack thread.

Created a new DodInfo page component that renders the form, connects to Redux, and passes along initial values, the submit handler, and routing functions.
Delete the old DodInfo component and use the new one in getWorkflowRoutes
I also turned off the react/jsx-props-no-spreading eslint rule for stories & tests files

Reviewer Notes
There should be no apparent changes to the user. Verify you're able to complete the DOD Info step of profile creation as before.
You can also review the new DOD Info form in Storybook at Customer Components / Forms / DOD Info Form.
Design should review the DOD Info form in Storybook & the DOD Info profile step at various screen sizes to verify it matches the design.
Setup
To run the app locally:
make server_run
make client_run

To view Storybook locally:
yarn storybook

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
DOD Info page:

DOD ID validation error:

With a server error:

Warnings

:warning:

It looks like you are attempting to bypass a linter rule, which is not within
security compliance rules.
** Contains a rule that is not in the permitted eslint list. You are free to disable only: (
no-underscore-dangle
,prefer-object-spread
,object-shorthand
,camelcase
,react/jsx-props-no-spreading
,react/destructuring-assignment
,react/forbid-prop-types
,react/prefer-stateless-function
,react/sort-comp
,import/no-extraneous-dependencies
,import/order
,import/prefer-default-export
,import/no-named-as-default
) **
Please remove the bypass code and address the underlying issue. cc: @transcom/Truss-Pamplemoose

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-5307

  Generated by :no_entry_sign: dangerJS against b4b96f577bb86bb30fe1da1a0d8e4b974d06730c

@transcom/truss-design The screenshots show an extra margin above the Branch label, that should be fixed in the code

@kimallen @felipe-lee thanks for catching those!! I have removed them


Support deployment to a namespace

The charts didn't specify metadata.namespace anywhere so have added support for this. Have used the {{ .Release.Namespace }} variable which defaults to default if not set. This makes it a non-intrusive change for anyone not wanting to use it, but a useful change for those who do
Fixed #41
Have tested against my own cluster with these commands:
Default namespace
helm upgrade \
  --atomic \
  --cleanup-on-fail \
  --install \
  --wait \
  registry .

This deploys registry to default namespace
Custom namespace
helm upgrade \
  --atomic \
  --cleanup-on-fail \
  --create-namespace \
  --install \
  --namespace registry \
  --wait \
  registry .

This deploys registry to registry namespace

@canterberry specifying --namespace may well work with you're using it with helm install or helm upgrade, but it doesn't seem to work with helm template which is my specific use-case - see gitpod/installer for more details.
I've not come across what you've said about the resource/release namespace matching not being desirable, but I can see that it could be a problem with a library. I'll make the change you suggested and document it in the values.yaml

@canterberry apologies, I hadn't signed the commit - done now

Released in v1.15.0.


Add custom ETA calculation

Current eta provided by upstream indicatif has issues with slow ticks of some encode jobs. It also struggles with switching between different rates of encoding and VMAF part of a single job.
A custom eta calculation tailored for ab-av1 usage may do better.

One workaround could be to increase granularity from using encoding progress seconds / total_seconds  to µs / total_µs to provide the  upstream algorithm more regular progress.

#175 improves some scenarios but I can still see it eta rocketing up to years when it should be minutes.

Why not base the ETA on frames per second?

Why not base the ETA on frames per second?

Indeed. Currently we use upstream eta calc based on progress bar updates. So yes replacing that with a custom calculation we can base it on ffmpeg reported rate. We can also account for vmaf rate & encoding rate in crf-searches.


Fix finding testing file search in the right path

The current github helper doesn't check if .yml test file exists in the right path.
git diff returns paths relative to the cloned directory (security_content), but the script's working directory is in ../security_content

I'm not sure if we should do it. When we allow that people use *.yaml file then our content would break also at a lot of other places.


Fix, test for #204 "allOf deserialised incorrectly"

Please review/accept this pull request to fix Issue #204. The fix is required by swagger-codegen Issue #2258, for which I shall shortly be raising a PR. Many thanks.

Excellent! Thanks Tony. Just working up some tests for the other issue, then I'll commit that as well.


uninstall does not work for -  JetBrains.PyCharm.Community

Not sure if it is an issue with PyCharm basically copying files to a location and unable to overwrite for upgrades.  Currently have three versions of PyCharm installed
winget list
...
PyCharm Community Edition 2021.3.3         JetBrains.PyCharm.Community                 213.7172.26         221.5787.24
PyCharm Community Edition 2022.1           JetBrains.PyCharm.Community                 221.5080.212        221.5787.24
PyCharm Community Edition 2022.1.2         JetBrains.PyCharm.Community                 221.5787.24
...
attempt to run
winget uninstall --name 'PyCharm Community Edition'
Winget tells me no associated packages are installed.

You likely need to include the version since it is part of the "Name". For example:
winget uninstall "PyCharm Community Edition 2021.3.3"
I'm guessing since there are three packages with the "packageIdentifier" "JetBrains.PyCharm.Community" the Windows Package Manager is likely not to be able to disambiguate.

This does seem a bit strange. I think it may be another edge case we need to look at, or potentially an ask for JetBrains to improve install and / or uninstall scenarios.

try doing it via uninstall page on control panel

That is not the issue
I can uninstall with the uninstaller
The fail is when I was using winget
The folder that contains the software does not clean out and there is probably a isnotempty boolean of some sort and the folder is not empty so winget is assuming the app is there
Marcus Fernandez
principal Software Engineer
Office: +1<PHONE_NUMBER>tel:+1<PHONE_NUMBER>
<EMAIL_ADDRESS>9 AM - 6 PM Easternoutlook-data-detector://1 Standardoutlook-data-detector://1 timeoutlook-data-detector://1
If you have any feedback about my work, please let either me or my manager s Richard Justice<EMAIL_ADDRESS>Azure Data Bloghttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fazure.microsoft.com%2Fen-us%2Fproduct-categories%2Fdatabases%2F&data=02|01|Marcus.Fernandez%40microsoft.com|5b0d71cc96e744d3a78a08d811780bc1|72f988bf86f141af91ab2d7cd011db47|1|0|637278554578182899&sdata=IclY%2BFBuWxReEPy%2BeTZpW3WmdD9WZuXmm4RyElE3Rtc%3D&reserved=0 |Azure Gov Bloghttps://aka.ms/azuregovblog | @.***https://aka.ms/devops
Get Outlook for iOShttps://aka.ms/o0ukef

From: roblox34 @.>
Sent: Saturday, September 10, 2022 10:19:03 AM
To: microsoft/winget-cli @.>
Cc: Marcus Fernandez @.>; Mention @.>
Subject: Re: [microsoft/winget-cli] uninstall does not work for - JetBrains.PyCharm.Community (Issue #2260)
try doing it via uninstall page on control panel
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fwinget-cli%2Fissues%2F2260%23issuecomment-1242739608&data=05|01|marcus.fernandez%40microsoft.com|de356f36e01f4f17990a08da933769fe|72f988bf86f141af91ab2d7cd011db47|1|0|637984163482225406|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=xo9Turyrs0Zo7wO%2FLDKIJ7NPTXaynYzryjld9QBS728%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZBD2CZFS7YFBLBN24YZV6LV5SKFPANCNFSM5ZJMQ4NQ&data=05|01|marcus.fernandez%40microsoft.com|de356f36e01f4f17990a08da933769fe|72f988bf86f141af91ab2d7cd011db47|1|0|637984163482225406|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=W3JcXQ4BARuIHPX7qmomejGXl2up0hAxK%2F5636j5OLE%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

WinGet is looking at registry entries to see what is installed. If the uninstaller isn't removing those entries, the Windows Package Manager has no other way to determine the package isn't installed.


Components cant be used

ATM there is a refactor on the component system. With current changes it is impossible to use components. Need to find a solution to use the render method of the components.

Works atm, needs a revision in the future


Rename IKeyConfig to ICache

:white_check_mark: Build Magneto 115 completed (commit https://github.com/shaynevanasperen/Magneto/commit/854d461917 by @shaynevanasperen)

:white_check_mark: Build Magneto 116 completed (commit https://github.com/shaynevanasperen/Magneto/commit/eb12cba6af by @shaynevanasperen)


Simplify Bitcoin network parsing

Currently, and especially after #123, we have to convert the networks back and forth in order to work with the two json-rpc client used in the codebase. We can simplify this if https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/247 gets merged.
Opening an issue to keep track of it.

@meryacine FYI


Prefixed names

I ran into a collision with the proposed 'esp' variable name.
There's definitely other ways to fix this issue specifically; I'm proposing a name prefix on the variable names in the generated .idc file here.
NB: I've put this on-top-of the "surround with quotes" changes. I can easily rebase this to be independent if you would prefer.

Thank you for your update.


How to achieve high FPS while rendering lots of text and updating its position?

Hi, I am currently investigating PixiJS for a new project and I really like it so far! There are some requirements regarding the performance of the application. The really tricky part is that this will result in lots of displayed text labels which are constantly updated. I could not find a way to further improve the performance and my last hope is to finde some help in this community.
Goal
1500 text labels
60 position updates per second
60 FPS
Pixi Playground
I already created a minimal example using BitMapText resulting in ~28 FPS on MacBook Pro.
https://www.pixiplayground.com/#/edit/rLbAN_xrw7yUU_cg_c8Xv
Do you have any idea to improve this? Thanks a lot in advance!

Are you sure you need 1500 on screen at all times? Culling offscreen labels will help a lot with performance. Pixi doesn't do any culling out of the box, but there are a few community plugins (e.g., @pixi-essentials/cull by @SukantPal) that might help you here.
Are all 1500 labels unique? If there are many duplicates, you can convert it into a Sprite using a RenderTexture and share references at the expensive of more memory.

@ChristophWalter The example you've shown could potentially benefit from culling as @bigtimebuddy mentioned. 1500 labels each with 112 characters is a lot to render. There are reasons why your example cannot be used to suggest relevant optimization, for example the text is mostly overlapping. I don't think your project will be displaying jumbled text that is so dense it can't be read by the user.
Setting MESH.BATCHABLE_SIZE to a higher value like 200 might help. I didn't throughly test this because it still powers through 45 FPS after a 6x CPU slowdown on my iMac.
I haven't profiled the example too much. However, if you're working on a commercial project & this turns out to be GPU-side bottleneck, you might consider an out-of-order that renders each letter (all As, then all Bs, all Cs, etc.) together to improve texture locality, developing a tile-engine and/or doing a diff-rect optimization that renders the portion of the screen that has changed (i.e. based on the 60 updates out of 1500 labels). This are just ideas and should be taken as such.

Thank you for your help!
In reality we will use culling and it will be very unlikely to display that many labels at the same time. But for benchmark reasons we need to compete against non-web applications. We already questioned these requirements, but it would help a lot if we can show that webgl can handle this as well.
The labels will be unique. But they might not change that often. The example doesn't change the text content at all. So there might be some potential to optimize. I noticed that the  FPS stay the same even if I do not update the positions (playground). Is there a way to rerender the texts only when they change?
Setting MESH.BATCHABLE_SIZE did not change anything on my side. I will take a look at your other ideas or recommend to buy iMacs 😏 I am not that much into rendering, so these ideas really help me!

Ah, if you really are optimization that specific example then the supreme method would be to do what @bigtimebuddy said, with one change - use a Mesh and update that mesh directly (instead of using 1500 sprites).
This provides two key benefits:

This will eliminate the overhead of the batch renderer’s buffering phase.
The number of vertices will be cut by 112x (4/text instead of 4/character). That brings down the vertices to just 6K.
Only one DisplayObject in the scene.

So basically, the process would look like:

Render the BitmapText into a RenderTexture
Create a Mesh with 1500*4 vertices.
Animate the vertices directly. You must be careful because there are four vertices per instance (i.e. rectangles). So you would calculate the position for the first vertex. Then the other three would be (x + width, height), (x + width, y + height), (x, y + height).

This should be a straightforward process. Please tell us how it goes!

Hey, I tried to implement your suggestion. Converting the BitmapText to a texture seemed to work. But I am currently stuck trying to display the texture in a mesh. I tried using a PIXI.Mesh and PIXI.SimpleMesh. Do I need to create my own shader or can I use PIXI.MeshMaterial?
const bitmapFontText = new PIXI.BitmapText(
    'Lorem ipsum dolor\nsit amet consetetur\nsadipscing elitr sed',
    { font: '55px Desyrel', align: 'left' }
);

const texture =  PIXI.RenderTexture.create({ width: 800, height: 600 });
app.renderer.render(bitmapFontText, texture);

const vertices = [
    -0.5, -0.5,
    0.5, -0.5,
    0.5, 0.5,
    -0.5, -0.5
];
const uvs = [
    0, 0,
    1, 0,
    1, 1,
    0, 1,
];
const indices = [0, 1, 2, 0, 2, 3];
const geometry = new PIXI.MeshGeometry(vertices, uvs, indices);
const shader = new PIXI.MeshMaterial(texture);

const mesh = new PIXI.Mesh(geometry, shader);
app.stage.addChild(mesh);

https://www.pixiplayground.com/#/edit/7RHqFti0tdSzw-6iOtylk

I noticed that the FPS stay the same even if I do not update the positions (playground). Is there a way to rerender the texts only when they change?

Will a PIXI.Mesh help with this? Do you know any resource where I can read about the rendering process of PixiJS?

@ChristophWalter You can create a renderer yourself (instead of using an Application), setup a ticker loop which calls Renderer.render only when your scene changes.

You can also pass autoStart: false to the Application options and then call app.render() when something changes. Same diff.

Thanks, it somehow worked generating a texture out of the text and using it on a sprite. But I currently do not understand why and I can't reproduce it in a playground. 😄
However the application currently updates all 1500 label positions every frame with 60FPS. Furthermore each second the text content gets updated. This leads to a short freeze every second. So the next step will be to render those text updates asynchronous, e.g. in a web worker. I am currently reading about ImageBitmap and OffscreenCanvas. This might be interesting to others, so I will share my progress.

Short update as I stopped investigating some weeks ago
I rendered the text in a web worker which actually worked quite straight forward:
// render-text-worker.js
onmessage = function(event) {
    const textLines = event.data.text.split(/\n/);
    const index = event.data.index;
    const offscreen = new OffscreenCanvas(150,45);
    const ctx = offscreen.getContext("2d");
    ctx.font = "15px monospace";
    textLines.forEach((text, index) => {
        ctx.fillText(text, 0, 15 + index * 15)
    })
    const imageBitmap = offscreen.transferToImageBitmap();
    postMessage({imageBitmap, index});
};

// index.js
const worker = new Worker("render-text-worker.js");
const callbacks ={}
function getLabelTexture(index, text, callback) {
  callbacks[index] = callback
  worker.postMessage({ index, text });
}
worker.onmessage = function({ data }) {
  const callback = callbacks[data.index]
  callback(PIXI.Texture.from(data.imageBitmap));
}

Unfortunately there is no improvement for my use case. The frames still drop while rendering the texts. Maybe due to the work required for transferring the image bitmaps from the worker.
For our specific use case we ware able to recommend reducing the text length of each label to achieve the performance requirements.


update index

hi,thanks for your open source project. This time is working my third time with  open source project.

@thehanir95  thnx for contributing , try this year aswell with updated repo and make sure to follow me and star this repo so that you don't miss updates regarding the new changes and issues during Hacktoberfest 2020.


Removed Travis config in favor of GitHub Actions

Summary of changes

removed .travis.yml
updated badge for test and CI checks run via GitHub Actions

I usually think that Marco is the one who needs to be happy about Odinson PRs, but if he isn't offended, I can look at the small ones.  The punctuation of the changed line seems to have changed and if I click on the icon, it just shows the image in a window rather than anything useful, unlike the other icon.  Something might be off, possibly me.

I usually think that Marco is the one who needs to be happy about Odinson PRs, but if he isn't offended, I can look at the small ones.

I think this sort of thing can get shuffled through without the Supreme Leader personally signing off, though substantive changes to Odinson (ex. new features/behavior) warrant more eyes/deeper review.

The punctuation of the changed line seems to have changed and if I click on the icon, it just shows the image in a window rather than anything useful, unlike the other icon. Something might be off, possibly me.

Ack! That certainly wasn't intended.  I copied that line from the GitHub Actions badge generator (with a slight modification to the display text).  This might require some digging to produce a magic link to log of the most recent CI run...

I think it's fixed now.

@kwalcock


Add homebrew

Add support for homebrew in the final image. It is often easier to use than apt and also allows for additional parallelism.

Brew should probably be installed as user?

Add the brew binary path in the .zshprofile script at the front. Do not use environment variables in the Docker image.

Use .zshrc instead of .zprofile as is standard because a Docker container logs in as an interactive non-login shell, which ignores .zprofile.

Also, use ' single quotes to surround the commands to prevent multiple execution.

Use HomeBrew's own shell environment activation for path setting.


How to modify the competition

Hi! I created a new competition using the tool given here. All good up till here.
Then I had the space automatically running. To modify the competition, I cloned the repository of the space locally with the command given on the UI
git clone https://huggingface.co/spaces/cmdgentest/commandgen

When I inspected the contents, it had only two files - Dockerfile and README.md. This was surprising as i expected the files mentioned here.
However, I still created these files myself and pushed the changes to the spaces repo. Once the space was restarted and running, I still wasn't able to see the changes I made.
At this point I am confused where exactly should I put files like conf.json in my case.

These files should be in the dataset repo from what I understand


fix: Add scipy to the UI jupyter-images list

Add kubeflownotebookswg/jupyter-scipy:v1.7.0 to the list of jupyter-images exposed as a configurable option via the jupyter-ui charm. Adding it to the top of the list restores it as the default option.
Closes https://github.com/canonical/notebook-operators/issues/290

Looks like Prometheus and Grafana were having issues (looks unrelated to the changes introduced here). Retriggering the failed run.

So, I reran the tests which didn't help. I saw this error which seemed curious.
It turns out, the error is caused by Prometheus, and more specifically this change introduced just yesterday, which assumes juju > 3.0.3:
https://github.com/canonical/prometheus-k8s-operator/blob/9d544539a99281a80507e85c205e73f0f76fb5a7/metadata.yaml#L7-L8
I'd say that's unfortunate. It means we can't deploy the latest/edge version of Prometheus.


Serial connection Optimizations

First thing, define debug mode for debugging serial communication. In actual usage, you will send only the necessary data.
const bool debug=true;
if (debug)  Serial.println("Some Message");

Remember that each character you add will introduce a delay to the system. Be mindful of adding characters in serial communication; avoid adding extra characters to keep the system running smoothly.

Use flash memory space instead of RAM for fixed messages. For example:
SerialUSB.print(F("constant string"));

Accumulate data in a local buffer and send it in larger chunks. Here’s an example:
const int data = 230;
const float fdata = 203.5;
const char sdata[] = "Hello";
char buffer[100]; // Buffer to hold the formatted string
int index = 0;
for (int i = 0; i < 100; i++) {
  index += snprintf(buffer + index, sizeof(buffer) - index, "Motopya! data %d float %.2f String %s index %d", data, fdata, sdata, i);
  if (index >= sizeof(buffer) - 50) {  // Ensure there's enough space for the remaining data
    Serial.println(buffer);
    index = 0;
  }
}

Minimize Serial Flushes. Use SerialUSB.flush() sparingly, as it can block program execution.

This issue is no longer necessary; we are no longer using serial communication.


Invalid order of arguments passed to geod_inverse()

The definition of the function Proj.geod_inverse() in geod.jl is as follows.
function geod_inverse(g::geod_geodesic, lat1::Real, lon1::Real, lat2::Real, lon2::Real)
    s12 = Ref{Cdouble}(NaN)
    azi1 = Ref{Cdouble}(NaN)
    azi2 = Ref{Cdouble}(NaN)

    geod_inverse(Ref(g), lat1, lat2, lon1, lon2, s12, azi1, azi2)

    return s12[], azi1[], azi2[]
end

However, I think the correct order of arguments passed to the (inner) geod_inverse() function should be
    geod_inverse(Ref(g), lat1, lon1, lat2, lon2, s12, azi1, azi2)

Yes, it looks like you're right, thanks for the report. We should fix and add some tests for this function.
https://github.com/OSGeo/PROJ/blob/3c47abf8fd1175dc6ccd00b725e60e75897de90a/src/geodesic.h#L271


:arrow_up: GitHub package version

see https://github.com/atom/github/issues/1752 for changes going into this release.

@annthurium are you sure you committed package.json?  Isn't showing up for me in the diff.

Superseded by #18300


[FP]: graphql-java-17.4.jar flagged with cpe:2.3:a:graphql-java_project:graphql-java:17.4:::::::*

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:graphql-java_project:graphql-java:17.4:::::::*
CVE
CVE-2022-37734
ODC Integration
{"label"=>"Gradle Plugin"}
ODC Version
7.1.1
Description
According to CVE description version 17.4 contains the required fix, but cpe is not updated.

My goal is to suppress alerts of this CVE for version 17.4 of that package, because that version actually received a backport of the fix.
So I'm going with this suppression rule:
    <suppress base="true">
        <notes><![CDATA[
   FP per issue #4861
   ]]></notes>
        <packageUrl<EMAIL_ADDRESS>        <cve>CVE-2022-37734</cve>
    </suppress>

I don't think adding a suppression for a specific CVE in this project is a scalable or desirable solution to this and the blanket CPE suppression suggested by the bot here would be totally wrong.
IMHO the data should be fixed upstream in NIST NVD and you should suppress on your side until that happens. NIST make such corrections all the time, and there is a process to submit requests for change/evaluation with appropriate evidence (email nvd@nist.gov).

@chadlwilson Fully agree on that part, so we won't fix this one in the project.

I don't think adding a suppression for a specific CVE in this project is a scalable or desirable solution to this and the blanket CPE suppression suggested by the bot here would be totally wrong.
IMHO the data should be fixed upstream in NIST NVD and you should suppress on your side until that happens. NIST make such corrections all the time, and there is a process to submit requests for change/evaluation with appropriate evidence (email nvd@nist.gov).

@chadlwilson I absolutely agree. Afaik the graphql-java people are currently trying to get the cpe updated. Until this is done I will suppress on my side with the above mentioned rule that is specific to that CVE and package version.

@melo0187 Should be OK by now. NVD reported that they've updated the affected software versions to properly match the affected versions of graph-ql. Online it's visible that they now have the appropriate ranges (up to excluding 17.4 and 18.0 up to excluding 18.3)

@aikebah thank you for leting me know. I can confirm the updated entry. When using graphql-java 17.4 I don't need any suppress rule anymore and the CVE is not reported by the check :+1:


Conda Package

Short description of the changes:

Long description of the changes:

Check list for the pull request

[ ] I have read the [CONTRIBUTING]
[ ] I have read the [CODE_OF_CONDUCT]
[ ] I have added tests for my changes
[ ] I have updated the documentation accordingly

Check list for the reviewer

[ ] I have read the [CONTRIBUTING]
[ ] I have verified the proposed changes
[ ] best software practices

[ ] all internal functions have an underbar, as is python standard
[ ] clearly named variables (better to be verbose in variable names)
[ ] code comments explaining the intent of code blocks

[ ] All the tests are passing
[ ] The documentation is up to date
[ ] code comments added when explaining intent

Manual test for the reviewer

References

Codecov Report
Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.48%. Comparing base (24f1954) to head (9d18cc4).

Files
Patch %
Lines

src/garnet/workflow.py
71.42%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             next       #5      +/-   ##
==========================================
+ Coverage   54.45%   54.48%   +0.03%
==========================================
  Files          15       15
  Lines        2301     2307       +6
==========================================
+ Hits         1253     1257       +4
- Misses       1048     1050       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🤔 请问heatmap 3d图层，怎么按照等分位、等间距等方式根据字段值映射高度呢？

🐛 Question description [Please make everyone to understand it]
💻 Link to minimal reproduction
Please provide a link by forking these links L7Plot or GitHub repo. What is a minimal reproduction, and why is it required?
🏞 Expected result
🚑 Any additional [like screenshots]

L7Plot Version:
Platform:

不支持


Optimize canvas hit detection by rendering features in a limited extent

Inspired by @tsauerwein's work in #3065, this adds an optimization for hit detection with the Canvas renderer.  Features are only considered for hit checking if their extent intersects a buffered extent around the provided coordinate - using the buffer from the new renderBuffer property for vector layers (see #3061).
In some unscientific benchmarking, it looks like this cuts the hit detection time by up to 50% (~2.3ms v. ~4.9ms in the vector layer example and ~9ms v. ~16ms in the synthetic points example in worst case scenarios).

@elemoine did you want to give this another look?  @tsauerwein and I agree it is good to go.

Where are the tests? ;-) Just kidding. I don't really think this needs tests at this point. Please merge.


perf: option to exclude cached from stats

This PR contains a:

[x] bugfix

Motivation / Use-Case
stats.toJson is a heavy method, and is called for every incremental build.
I made a webpack build performance profiling, and found that stats.toJson from webpack-hot-middleware takes around 50ms work - while complete incremental build for small change is cost around 200-250ms fo CPU work.
After trying to change statsOptions, I found that cached: true option is the slowest, and with disabled cached: false full stats.toJson call cost around 10ms - five times faster.
Looks like we don't need this option for most projects, but for backward compatibility I just add one parameter to rewrite it.
Breaking Changes
This PR is backward compatible with previous changes in https://github.com/webpack-contrib/webpack-hot-middleware/pull/336
Additional Info
CPU profiles included
tramvai-cli.cached-false.cpuprofile.zip
tramvai-cli.cached-true.cpuprofile.zip
No cached:

And cached, as default:

@alexander-akait Hello! Want to ask you for PR review 🙏

I am fine with it, I will merge and release this tomorrow, I want to look at code why it is slow and maybe we need to put TODO about change it in the future major release

Thanks a lot!
Say if you need any CPU profile traces for debugging.

@alexander-akait hello! Can you merge and release this fix please?

@alexander-akait hello! Just want to remind about thix fix 🙏

Sorry for delay, I will do releasae tomorrow

@SuperOleg39 Hm, until I released it, maybe we can make it more flex, let's allow to override stats options (make an option for this) and use const statsOptions = { /* Default options */ children: true, ...opts.statsOptions }, so you can override everything and make it even faster

@SuperOleg39 Hm, until I released it, maybe we can make it more flex, let's allow to override stats options (make an option for this) and use const statsOptions = { /* Default options */ children: true, ...opts.statsOptions }, so you can override everything and make it even faster

Something like this? https://github.com/webpack-contrib/webpack-hot-middleware/pull/444


Update util-core to 6.45.0

Updates com.twitter:util-core from 6.39.0 to 6.45.0.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.twitter", artifactId = "util-core" } ]

labels: semver-minor

Codecov Report

Merging #296 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #296   +/-   ##
========================================
  Coverage    61.29%   61.29%
========================================
  Files           50       50
  Lines         1540     1540
  Branches        40       40
========================================
  Hits           944      944
  Misses         596      596

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09bae75...67ba4dc. Read the comment docs.

Maybe this should be 19.10.0 instead?


[backport] Skip tests that segfault when using SciPy 1.3.x

Backport of #2712

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit f29490d71031e27914001b3ab383d320e5cc0906, target branch v6) succeeded!


[FEATURE] want some css change in Contributor card

Detailed description
Hey Look at this design
Context
css change
Possible implementation
No response
Additional information

Checklist

[X] I have read the Contributing Guidelines
[X] I have checked the existing issues
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Hi! The first cards look very cool 🔥
What do you think @WebXDAO/gssoc-mentors @WebXDAO/webx-guild-designers ?

Hi! The first cards look very cool 🔥 What do you think @WebXDAO/gssoc-mentors @WebXDAO/webx-guild-designers ?

So, did he made a PR?


App Builder: Expose configuration of window size on all app configs

We already model app window size, but we need to add it to the app configuration UIs.

Jackson, please integrate window parameters for non-kiosk configs wherever it makes sense in the UI.


ixed issue #1408 #1406 - [closed]

In GitLab by @liyanq528 on Jun 28, 2018, 01:53
Merges 20180428 -> dev

In GitLab by @wknet123 on Nov 13, 2019, 11:09
The test coverage for backend is FAIL  ,The test coverage for frontend is 38.11   , check  consolse log

In GitLab by @wknet123 on Nov 13, 2019, 11:09
The test coverage for backend is 23.9%  ,The test coverage for frontend is 38.11   , check  consolse log

In GitLab by @wknet123 on Nov 13, 2019, 11:09
The test coverage for backend is 23.9%  ,The test coverage for frontend is 38.11   , check  consolse log

In GitLab by @wknet123 on Nov 13, 2019, 11:09
The test coverage for backend is 23.9%  ,The test coverage for frontend is 38.11   , check  consolse log

In GitLab by @wknet123 on Nov 13, 2019, 11:09
The test coverage for backend is 23.9%  ,The test coverage for frontend is 38.11   , check  consolse log

In GitLab by @wknet123 on Nov 13, 2019, 11:09
closed


[Wait for #1261] [Trivial] Change return -> retval

[Pending commit: #1261]

[Trivial] Change return -> retval

When stating value in doxygen it is recommended to use @retval, this
patch reflects the issue

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [X]Skipped
2. Run test: [ ]Passed [ ]Failed [X]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1264. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @zhoonit, nntrainer/utils/util_func.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md


Image compression using 'auto' affects the quality more than WhatsApp algorithm

Hello, I started usign this library and, according to the documentation, I was expected similar results of this library with the WhatsApp algorithm. However, I noticed a very big difference in quality, without even zooming too much into the picture.
I will provide you two links to see the differences. Out of the same original image, one was compressed by attaching it to WhatsApp, the other by using react-native-compressor.
library compression
whatsapp compression
You will see very big differences if you zoom over the screen in the picture, with react-native-compressor you don't see the text very good.
Could you please explain me if there is any setting to improve the quality? In the meanwhile I will play with the 'manual' customization property, but maybe you can provide some info about this quality loss.
Thanks a lot!

Found the issue: I noticed in the documentation that the default value for maxWidth and maxHeight is 1280, this is what affected my quality so hard.

@marcopacurariu3 if you think, the documentation is not clear, you can make a PR, I will welcome your PR


add: Rashid Siddiqui

Description
Updated my profile in the project.
Changes Proposed
Updated my profile in the project.

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x]  My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@RashidSiddiqui2004 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!


ci: switch to python 3.11.0b4

@samuelcolvin Thanks for your email. It seems to have done miracles ;)

😆 maybe.


Build dependencies missing pip

Python pip package missing and the second command was missing sudo prefix

Thanks @jacksteroo !
I am curious, why do you need pip to build?
I have not seen this issue in CI:
https://github.com/cosmos/ledger-cosmos/blob/master/.circleci/config.yml#L9


Jodit 3.4.2 fails in Webpack (JS) project

Jodit Version:  3.4.2
Browser:  Chrome
OS:  Mac
Code / Steps to recreate

If you don't have create-react-app, install it via npm i -g create-react-app
create-react-app jodit-test-react
(this will create a new npm project in subfolder jodit-test-react)
In package.json, add the following to dependencies:
"jodit": "3.3.24”,
npm i
In src/App.js - add textarea, add imports, add effect that calls Jodit.make

import React, { useEffect } from 'react';
import logo from './logo.svg';
import './App.css';
import Jodit from 'jodit';
import 'jodit/build/jodit.min.css';

function App() {
  useEffect(() => {
    Jodit.make('#editor');
  }, []);

  return (

        <textarea id="editor" name="editor"></textarea>

  );
}

export default App;

npm start
In browser, navigate to http://localhost:3000, and verify jodit works as expected with this version (3.3.24)
stop npm start process
Modify package.json - change jodit version from 3.3.24 to 3.4.2
npm i
npm start
In browser, navigate to http://localhost:3000.  You'll now get the following error:
TypeError: Cannot read property 'make' of undefined

Expected behavior:
On step 11, using version 3.4.2, no error occurs.  Jodit is rendered in place of the textarea.
Actual behavior:
error from calling Jodit.make:
TypeError: Cannot read property 'make' of undefined
Note: I do not get the error if I use build/jodit.min.js directly in an index.html file.
I think i would get the error in any project where I tried importing it in this way, in a project that is using webpack.  I used create-react-app only because it uses webpack out-of-the-box, and so the steps to recreate were straightforward (at least for me :) )  Perhaps the issue stems from the fact that my test project is not using TypeScript, only JavaScript?
Thanks for the great library!!!

I'm using typescript and webpack. I just tried updating from v3.3 and ran into the same issue.

If I change the import to this:
import { Jodit } from 'jodit';
Jodit is at least something other than undefined.  With this modified import, I can call Jodit.make() or new Jodit() without getting an error like "cannot call 'make' on undefined", but I still get an error:
Uncaught ReferenceError: Jodit is not defined
    at Object.t.isJoditObject (jodit.min.js:9)
    at Object.t.makeCollection (jodit.min.js:9)
    at Jodit.t [as constructor] (jodit.min.js:9)
    at new Jodit (jodit.min.js:9)
    at Function.Jodit.make (jodit.min.js:9)
    at App.js:9

@rockwood, if you try this modified import in a TypeScript app, do you get the same error?
@xdan please let me know if you need more information.

@keithrz I also get that error.

It looks like the issue is fixed in 3.4.6.  With 3.4.6 or later, it works if I change the import to use named export instead of default export, that is:
import { Jodit } from 'jodit';
before 3.4, the import I used was:
import Jodit from 'jodit';


Allows BaseHtml::activeListInput to override the field value

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues

Allows BaseHtml::activeListInput to override the field value, to follow BaseHtml::activeInput which already allows it.

My use case:
Generating new fields loaded via ajax, I can let Yii generate the exact same layout for the fields with model data, setting value = '', so it doesn't call the model to load a field which does not exists.

need a CHANGELOG entry.

Thank you


2.1.0 doesn't work without log level set to debug (maybe missing code)

The new pre-release version 2.1.0 doesn't seem to have all the changes necessary changes in the OnStreamStart function in ResolutionMatcher-Functions.ps1 file to change the resolution when the log level isn't debug. I thought this new version didn't need read the log, but when I turned my log level in Sunshine to info, the script stopped working.
I tracked down the issue to a call to OnStreamStart passing in width, height, and frequency params that don't exist in the OnStreamStart function. In the 2.1.0 release source code OnStreamStart just gets the resolution from Get-ClientResolution, which is just reading the log.
Maybe you just forgot to push changes to this function, but I wrote an updated version of OnStreamStart that uses the Sunshine environment variables that are passed in from the call site. And it works:
function OnStreamStart($width, $height, $frequency) {
    $expectedRes = @{
        Height  = $height
        Width   = $width
        Refresh = $frequency
    }
    Set-ScreenResolution -Width $expectedRes.Width -Height $expectedRes.Height -Freq $expectedRes.Refresh
    Assert-ResolutionChange -originalRes $expectedRes
}

Looks like I need to also change code in Assert-ResolutionChange:
function Assert-ResolutionChange($originalRes) {
    for ($i = 0; $i -lt 12; $i++) {
        $currentRes = Join-Overrides -resolution (@{
            Height  = $env:SUNSHINE_CLIENT_HEIGHT
            Width   = $env:SUNSHINE_CLIENT_WIDTH
            Refresh = $env:SUNSHINE_CLIENT_FPS
        })
        if (($currentRes.Width -ne $originalRes.Width) -or ($currentRes.Height -ne $originalRes.Height) -or ($currentRes.Refresh -ne $originalRes.Refresh)) {
            # If the resolutions don't match, set the screen resolution to the current client's resolution
            Write-Host "The client resolution changed within the past 6 seconds, this implies the first time the resolution was changed may have been incorrect due to stale data"
            Write-Host "Original Requested Resolution: $($originalRes.Width) x $($originalRes.Height) x $($originalRes.Refresh)"
            Write-Host "Expected Requested Resolution: $($currentRes.Width) x $($currentRes.Height) x $($currentRes.Refresh)"
            Set-ScreenResolution $currentRes.Width $currentRes.Height $currentRes.Refresh
            break
        }
        # Wait for a while before checking the resolution again
        Start-Sleep -Milliseconds 500
    }
}

I know it's not consistent in OnStreamStart I'm using the params passed in (which are the Sunshine environment variables), and then in Assert-ResolutionChange I'm just straight up using them directly. But I used the params in OnStreamStart because your call to it was passing them in, so I wanted to write the function to use them. You do what you think is best :)

Maybe you just forgot to push changes to this function, but I wrote an updated version of OnStreamStart that uses the Sunshine environment variables that are passed in from the call site. And it works

Kind of, this was more of a quick test release of Sunshine’s new feature. I am going to push the code again sometime tomorrow that essentially removes the Assert and Get-ClientResolution functions as they are obsolete now.
You are correct the intention for this new version is to move away from having to set the log level to debug. I’ll work on fixing this issue today :)

Thanks for letting me know. I look forward to the push :)

This should be resolved now, let me know if that is not the case

It all looks good except the Join-Overrides function doesn't work because you forgot to change the if test to test the passed in $width, $height, and $refresh. It's still using $resolution.width, $resolution.height, $resolution.refresh.
$resolution still being used:
if ($widths[0].Value -eq $resolution.width -and $heights[0].Value -eq $resolution.height -and $refreshes[0].Value -eq $resolution.refresh) {

Corrected code using passed in variables:
if ($widths[0].Value -eq $width -and $heights[0].Value -eq $height -and $refreshes[0].Value -eq $refresh) {

It all looks good except the Join-Overrides function doesn't work because you forgot to change the if test to test the passed in $width, $height, and $refresh. It's still using $resolution.width, $resolution.height, $resolution.refresh.
$resolution still being used:
if ($widths[0].Value -eq $resolution.width -and $heights[0].Value -eq $resolution.height -and $refreshes[0].Value -eq $resolution.refresh) {

Corrected code using passed in variables:
if ($widths[0].Value -eq $width -and $heights[0].Value -eq $height -and $refreshes[0].Value -eq $refresh) {

Good point, this has been fixed in latest commit


Question regarding early_stopping_rounds & fitted model best_iteration

Hi ,
I have three questions :

If I am adding 'train_data_Dataset' to  'valid_sets' like that :
lgbm_model = lgbm.train(lgbm_params,  						  train_set = train_data_Dataset,	   					    						  early_stopping_rounds = 10, 					    						  valid_sets = [ train_data_Dataset,valid_data_Dataset], #valid_sets = [train_data, valid_data],  						  verbose_eval = 100 ,  						  evals_result = eval_result_dict  						  )
How the  training data is being ignored  during the early stop functionality  ?

I am using the 'n_estimators' that controls number of build decision trees  (for example n_estimators =1000 ).
But through the training the num of best_iteration = 20. If I am retraining the  model again on all data - I should change the n_estimators  to be 20  (n_estimators  =20)?

Why in prediction there is 'num_iteration' attribute ? The model uses the best achieved iteration automatically  so why this attributed is needed ?

Thanks,
Boris R

Thanks very much for using LightGBM!

How the training data is being ignored during the early stop functionality

Please see https://github.com/microsoft/LightGBM/issues/4679#issuecomment-955872028 for a detailed recent description of how LightGBM ignores the training data for early stopping.

through the training the num of best_iteration = 20. If I am retraining the model again on all data - I should change the n_estimators to be 20 (n_estimators =20)

Your interpretation is correct. best_iteration = 20 means "LightGBM stopped training after 21 iterations, because performance on the validation data stopped improving". This suggests that if you re-train on the full dataset with, for example, n_estimators = 1000, the training time, computing, and memory consumed for most of those additional training rounds will not make the resulting model much better. Note that best_iteration is 0-based, e.g. best_iteration = 20 means "21 iterations".
If you have a fairly small dataset (say, less than 10,000 observations), I recommend using n_estimators slightly higher than best_iteration you obtained during training where somme data was held out for validation.

Why in prediction there is 'num_iteration' attribute?

Tree-based gradient boosting models like LightGBM create predictions by adding the predicted values from each tree, in sequential order. That means that if you have a 10-tree model, creating a prediction on a sample involves passing it through 10 trees and summing the values of the leaf nodes the sample falls into.
If your goal is "generate the most accurate possible prediction, regardless of how expensive it is to compute it", then leaving num_iteration at the default value is the right choice.
However, that's not always the case. Consider these scenarios:

"I've found that the predictions as of num_iteration = 500 are not that different than those produced as of num_iteration = 5000, so I'm comfortable using fewer iterations in exchange for each prediction being calculated faster"
"I want to inspect the model structure by checking  which leaf nodes some evaluation data fall in, and I just want to visually inspect the output for the first 10 trees" (using pred_leaf, see the Booster.predict() docs (link))
*"I want to figure out how different the predictions would be is I only used the first 100 trees vs. the full model I trained, because I'm interested in trying to make the model object smaller or reducing the time-per-prediction"

Thank you very much !


Duplicate logging messages after calling model.save()

System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Issue on both CentOS8 Stream and Ubuntu 22.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.9.0-18-gd8ce9f9c301 2.9.1
Python version: 3.9
Bazel version (if compiling from source): N/A
GPU model and memory: A100 (40 GB)
Exact command to reproduce:

import logging
import tensorflow as tf

logger = logging.getLogger('test')
logger.setLevel(logging.INFO)
logger.addHandler(logging.StreamHandler())
logger.info("Message (1) not duplicated")

model = tf.keras.applications.Xception()
logger.info("Message (2) not duplicated")

model.save('test')
logger.info("Message is duplicated")

Describe the problem.
When using a logger from python's logging module, messages are duplicated after a model is saved.
Describe the current behavior.
Running the above script will yield (some output not shown):
Message (1) not duplicated
Message (2) not duplicated
WARNING:tensorflow:Compiled the loaded model, but the compiled metrics have yet to be built. `model.compile_metrics` will be empty until you train or evaluate the model.
WARNING:absl:Found untraced functions such as _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op while saving (showing 5 of 40). These functions will not be directly callable after loading.
Message is duplicated
INFO:test:Message is duplicated

Logging is not duplicated if logging.basicConfig() is called before model saving:
...
logger.setLevel(logging.INFO)
logger.basicConfig()
logger.info("Message (1) not duplicated")
...

This behavior is only observed in Tensorflow 2.9 and does not occur with version <2.8.
I suspect the issue is in tensorflow.python.saved_model.save:268 where a module-level logging.warning() function is called, which may be unintentionally adding a stream handler to the root logger if none is configured.
Describe the expected behavior.
Logging messages are not duplicated.
Standalone code to reproduce the issue.
An issue was first opened on the Tensorflow repo, and their team posted a gist which reproduces the issue here. They requested that the issue be moved to the keras repo.

@gadagashwini,
I was able to reproduce the issue on tensorflow v2.8, v2.9 and nightly. Kindly find the gist of it here.

I will take a look.

Environment
I have written a script here which reproduces the problem in TF 2.7.3 / 2.8.2 / 2.9.1 via a simple Sequential model.
The problem can also be observed in some of the official TensorFlow guides, e.g. Using the SavedModel format:
INFO:tensorflow:Assets written to: /tmpfs/tmp/tmp_terpd74/mobilenet/1/assets
INFO:tensorflow:Assets written to: /tmpfs/tmp/tmp_terpd74/mobilenet/1/assets

Cause
As mentioned by @jamesdolezal, the cause appears to be misuse of the root logger in several of TensorFlow's Python modules, contrary to best practices for logging in Python libraries.
Offending modules include tensorflow.python.saved_model.save which calls absl.logging.warning directly (rather than using a specific logger): https://github.com/tensorflow/tensorflow/blob/v2.7.3/tensorflow/python/saved_model/save.py#L263
This results in a stream handler being added to the root logger (if no handler has been attached yet): https://github.com/abseil/abseil-py/blob/v1.1.0/absl/logging/__init__.py#L547
Potential solution
Replacing each import
from absl import logging

with
from tensorflow.python.platform import tf_logging as logging

should resolve the problem, as the latter routes messages through TensorFlow's logger instance (tf.get_logger()).


Any Integer Assignment

The "screen name" was transformed into the "any integer" assignment because the new platform does not support the leader board.

Current coverage is 80.32% (diff: 92.59%)

Merging #21 into master will increase coverage by 0.05%

@@             master        #21   diff @@
==========================================
  Files            17         17
  Lines          1044       1052     +8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            838        845     +7
- Misses          206        207     +1
  Partials          0          0

Powered by Codecov. Last update 278fdd1...4d10ab8


Unexpected keybinding config error

Environment
Windows build number: [Version 10.0.18363.720]
Windows Terminal version (if applicable): 0.10.761.0

Any other software? not sure what this is asking

Steps to reproduce
This is happening any time I start terminal -- not a new tab in terminal, but starting the very first terminal window.

Expected behavior
I expect the window to open as it had done earlier in the day -- without popping an error message.

Actual behavior
All of a sudden (from my point of view) starting up terminal presented me with an "Encountered errors while loading user settings" message (I will try to attach a screen shot of the message and a copy of my settings json file).  The thing is, I have been working with VS2019, my own software, notepad++, outlook and other stuff all day, with most things (especially terminal) being started and stopped multiple times.  I have not even looked at the settings for anything, so there is no reason for them to have changed -- I never did it myself, nor did I authorize anything else to do it for me.  My system has not rebooted, though God only knows what Windows Update may have done in the background without telling me...

profiles.json.txt

It looks like your profiles.json file has contained some invalid settings for a while, and the new version of Terminal is correctly calling those invalid settings out.
      "keybindings": [
        {
          "command": "closePane",
          "keys": [
            "shift+f4",
            "ctrl+shift+w"
          ]
        },
        {
          "command": "copy",
          "keys": [
            "ctrl+ins",
            "ctrl+shift+c"
          ]
        },

An entry in "keybindings" cannot have multiple keys. That feature is intended for key chording, such that you can configure "shift+f4 ctrl+shift+w" in sequence to trigger closePane.

I have not even looked at the settings for anything

Terminal has never shipped a settings file with multiple bindings for the same key, so I'm going to say that some software on your system must have made this change.
Incidentally, your settings file looks like it's very old (pre-version-0.5). The eminent Scott Hanselman wrote up a good blog post on why it might be a good time to start anew.

I may have added those extra bindings at the direction of a post here.  It is unlikely that I 'invented' them myself.  (As a rule, I try to avoid directly looking at JSON files almost as much as I avoid XML -- I don't want to go blind!)  I remember making a couple changes to the default shell, the font and default rows/columns, but I don't remember doing anything more.  I might have, but I don't remember.
As for "starting anew" ... that's the kind of thing I tend to trust the application updates to take care of, even if they need to ask me for "assistance" in what to keep, lose or change.
I guess the error just "appeared" because terminal was silently updated by Windows Update (or something like it) between two runs of the program today.  Gotta love it, I suppose -- do I have a choice?

So, are there any instructions or documentation for this "starting anew" procedure?  I would guess that the best way should be to uninstall and then reinstall, but since so few programs actually clean any old stuff out during either of those processes, I have little hope that would work.
Related to the error message:  It was VERY surprising that I was able to type commands BEHIND the error popup!  Apparently the error does not have the keyboard focus, even though the different brightness levels of the shell and error seem to indicate otherwise.  I think THAT is an actual bug.
FWIW, I like the terminal for a simple reason:  it loads faster than CMD while still supporting (most of) the things I did with CMD.  I am not interested in hacking away (and learning a whole new language in the process) directly within a JSON configuration file.  I do everything I can to avoid JSON (and XML).

OK, I started "anew" by renaming profiles.json and restarting terminal.  Then I moved over the few things I changed (font face/size, rows/columns, default shell).  Works great.  I have been reading the docs about the configuration file and came across this line about key bindings:

This is an array of key chords and shortcuts to invoke various commands. Each command can have more than one key binding.

This appears to directly conflict with your earlier statement that only one binding is allowed.  Given the error message, perhaps the documentation should be corrected to reflect the (new?) reality.
The quote may be found just after Key Bindings on this page:  UsingJsonSettings
Thanks again for all your help and to everyone working on this nifty tool!

@nurbles No, that documentation is actually saying what we want there. You can have multiple keys bound to the same action, but they should each be in their own bindings. For example:

    "keybindings" :
    [
        { "command": "copy", "keys": ["ctrl+shift+c"] },
        { "command": "copy", "keys": ["ctrl+c"] },
        { "command": "copy", "keys": ["enter"] },
        { "command": "paste", "keys": ["shift+insert"] },
        { "command": { "action": "splitPane", "split":"auto", "splitMode": "duplicate" }, "keys": [ "ctrl+alt+t" ] }
    ]

In this snippet from my keybindings, all three of ctrl+shift+c, ctrl+c and enter are bound to copy

Ah-ha!  Thanks for the clarification.  Also, thank's for allowing comments in terminal's JSON file! They are super helpful to remind me how the bits work and what I changed, since I almost never look at the thing.

Just curious... Why does terminal allow multiple bindings for each key, but only defined as a set of separate definitions with an array of bindings that only ever has ONE element?  Since I'm being forced to learn about JSON in order to make sure my configuration changes are correct, everything I have found says that the
      { "command": "copy", "keys": ["ctrl+shift+c"] },
syntax is defining an array of "keys" for the "commnd":"copy", but terminal only allows one element in the array. Then this is even more strange:
   { "command": "copy", "keys": ["ctrl+shift+c"] },     { "command": "copy", "keys": ["ctrl+c"] },     { "command": "copy", "keys": ["enter"] },
This is defining a set of three different keys (and chords) for the command copy by using THREE ARRAYS with ONE ELEMENT each!  It seems to me that if you are going to use JSON, you might as well actually use it in the way it is defined instead of having a strange restriction like this.  I have not tried it yet, but the documentation says that the one element arrays OR non-array settings may be used -- so all the square brackets above could be removed.  So I think the documentation (and any sample JSON file(s)) should NOT use the array format when more than one value is not allowed.  That's just confusing.
(Sorry about the lack of CR/LF on the second example.  I tried numerous ways to get this things to allow it, but it refused.)

There's not a great reason here. Basically, we knew that one day, we'd like to support keychords with multiple keystrokes in them, like pressing Ctrl+B,Ctrl+1 to do an action. Since we knew we'd one day need multiple keys in the array, we made it an array to begin with.
Then we realized

We're not going to be able to do chords like this before 1.0
We can trivially parse the JSON differently for a single string value vs an array value

So older versions of the settings file will have an array for the keys property, while newer versions will just use a string, like
    "keybindings" :
    [
        { "command": "copy", "keys": "ctrl+shift+c" },
        { "command": "copy", "keys": "ctrl+c" },
        { "command": "copy", "keys": "enter" },
        { "command": "paste", "keys": "shift+insert" },
        { "command": { "action": "splitPane", "split":"auto", "splitMode": "duplicate" }, "keys": "ctrl+alt+t" }
    ]

Both this and the snippet I have above are treated the same way.

PS: markdown protip: you can use "code fences" to have multiple lines of code in your comments. By using something like:
```
This is code
With multiple lines
```

You can get content that looks like
This is code
With multiple lines

Thanks for the info about the arrays, it makes lots more sense when the multiple keystroke concept is added.  Add I had seen before was comments about defining keys and key-chords that (to me) seemed to imply that the chords might need an array.
I guess I don't know git markdown well enough for advance code blocks.  I foolishly trusted the 'insert code' button on this form to allow that, but it only inserts a single pair of backticks with the cursor placed between them, I guess for inline code examples.  I was fooled into thinking the tool I was given did what I needed.  Silly me.  (smile)


Please upgrade http to latest version

Before the update if you need http latest version, you can use:
dependency_overrides:
  http: ^1.1.0

An update that uses version 1.1.0 of the http package is made, the next release on pub will make the use of it available.


Feat: Adding dark mode on shop webpage properly

Describe the feature

In dark mode , the item cards have white background, which may not look good to the user , I have made them according to the dark theme

Fonts of the header part where discription of fruits , herbs , etc was written was not visible so I changed its color in dark mode.

Add ScreenShots
Before :
https://github.com/Anushkabh/krishiconnect/assets/162733812/474a7241-ea4a-4cff-88e1-1b2aa64667a0
After:
https://github.com/Anushkabh/krishiconnect/assets/162733812/e5100e2b-fd42-40d6-8b8b-342b4c13099e
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@himanshu-03 I want to work on this issue , please assign it to me

@himanshu-03 should I also modify the footer as mentioned in issue #712 ?


draw hitboxes doesnt even work anymore

happened at the version where fixed hitbox thingy

Pretty sure changing the enum shouldn't affect it.

still works, I updated it to use a different function, make sure the transparency of BOTH colours is set to full and it will draw perfectly.


Integrate NAT Traversal

As per meeting on 28/7/2022, logic is as follows:
If CLI param IP present, it overrides everything.
Otherwise use NAT PNP, in combination with NAT traversal externally visible addresses.

Duplicate of #753 (actually the other way around, but by now that one is more recent :slightly_smiling_face:)


Signed Pipelines fail to verify when using interpolated environment variables

Is your feature request related to a problem? Please describe.
Currently, signed pipelines fail to verify if uploading a definition that contains a variable such as ${VAR_NAME} in the command.
Describe the solution you'd like
Variables are supported in pipelines with risks and tradeoffs documented and mitigation options available.
Describe alternatives you've considered
Not using variables at all or only interpolating them from within wrapper scripts is a significant effort that would require rework across a large number of pipelines.
Additional context
There's some complexity in this because simply accepting any variable content could lead to a trivial bypass of the signature while evaluating the variable at signature time might lead to a different result compared to a runtime evaluation. However, the current situation is an edge case the pipeline signature feature has not addressed yet, so some explicit solution would be needed here.

Hey @fruechel-canva – I can see that @patrobinson has reached out to investigate your particular case here, so we can see where that support thread leads.
In general, signing of runtime env var interpolation (e.g. escaped env vars with $$ or \$) wouldn't be possible because changing the value of the env var between upload and running could change the behaviour of the step.
However normal env var interpolation (where the agent replaces ${VAR_NAME} before the steps are uploaded) should be signed – this seems to be where the bug would be if that's not working correctly. We'll dig into this further with you directly so we can talk about your example pipeline, then come back to this issue with an update for any readers (cc @bpoland)

yo! i (mis)informed @dabarrell on his reply above and am here to correct my mistake - you absolutely can (or should be able to!) use $$ and/or \$ interpolation in signed pipelines, as you can see in this screenshot:

the reason this is okay is that the interpolation happens after the signature check, rather than before - the signature verification is basically just checking that the text of the command is echo $PWD in the example above, and isn't smart enough to interpolate that envar.


Shot 'hit_events' not re-enabling

I've come across a bug in shots where those that use hit_events instead of switch don't properly re-enable after being disabled. I've scoured the code looking for where the hit_events behavior is defined, but could find nothing.
shots:
  switchy_shot:
    switch: s_orbit
    enable_events: enable_shots
    disable_events: disable_shots
  eventy_shot:
    hit_events: hit_that_shot
    enable_events: enable_shots
    disable_events: disable_shots

The result is this:
Event: ===== 's_orbit_active'
Event: ===== 'switchy_shot_hit'
Event: ===== 'hit_that_shot'
Event: ===== 'eventy_shot_hit'
Event: ===== 'disable_shots'
Event: ===== 's_orbit_active'
Event: ===== 'hit_that_shot'
Event: ===== 'enable_shots'
Event: ===== 'hit_that_shot'
Event: ===== 's_orbit_active'
Event: ===== 'switchy_shot_hit'

I might have missed that in my refactoring. MPF will magically register a handler for all hit_events to the hit method of the device. Works with any xxx_events config setting in devices. The error probably is inside the hit function. If you feel like it you can extend the test: https://github.com/missionpinball/mpf/blob/dev/mpf/tests/test_Shots.py

tricky bug. the code was a bit lazy when removing handlers and accidentally also removed the control events. fixed now

Awesome, thanks!


Add matrix to e2e.yaml

Codecov Report

Merging #169 (74d3bd1) into master (f85b316) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   64.85%   64.67%   -0.19%
==========================================
  Files          22       22
  Lines        1104     1104
==========================================
- Hits          716      714       -2
- Misses        334      335       +1
- Partials       54       55       +1

Impacted Files
Coverage Δ

sampler.go
78.68% <0.00%> (-3.28%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more