Error when exporting a PyTorch quantized model

Hi:
I'm trying to quantize and compile a pytorch model with Vitis-AI (version 2.5). I have a quantization script with all the required steps.
First of all, I run the script specifying quant_mode=calib, and I get the expected result from the quantization step: files quant_info.json and Vgg19.py in the output folder:
-rw-r--r-- 1 vitis-ai-user vitis-ai-group   3005 Sep  2 12:38 quant_info.json
-rw-r--r-- 1 vitis-ai-user vitis-ai-group   9363 Sep  2 12:38 Vgg19.py

However, the following error occurs when exporting the model with quant_mode=test and flag --deploy:

2022-09-02 11:54:37.613 | INFO     | __main__:quantize:474 - Exporting xmodel

[VAIQ_NOTE]: =>Converting to xmodel ...

Traceback (most recent call last):
  File "quantize_vgg19_features_vai25.py", line 554, in <module>
    run_main()
  File "quantize_vgg19_features_vai25.py", line 548, in run_main
    args.input_pairs)
  File "quantize_vgg19_features_vai25.py", line 475, in quantize
    quantizer.export_xmodel(deploy_check=False, output_dir=quant_output)
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/pytorch_nndct/apis.py", line 127, in export_xmodel
    self.processor.export_xmodel(output_dir, deploy_check)
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/pytorch_nndct/qproc/base.py", line 248, in export_xmodel
    dump_xmodel(output_dir, deploy_check, self._lstm_app)
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/pytorch_nndct/qproc/base.py", line 321, in dump_xmodel
    deploy_graphs = get_deploy_graph_list(quantizer.quant_model, quantizer.Nndctgraph)
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/pytorch_nndct/qproc/utils.py", line 283, in get_deploy_graph_list
    g_optmizer.layout_tranform()
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/nndct_shared/compile/deploy_optimizer.py", line 445, in layout_tranform
    if pn.transpose_out_order is None and pn.out_tensors[0].ndim and node.out_tensors[0].ndim and pn.out_tensors[0].ndim == node.out_tensors[0].ndim:
IndexError: list index out of range

Do anybody have any thoughts on how this could be solved?

As an additional test, if I use the Inspector (even before the quantization step), I also get the same error:
device = torch.device(f"cuda:0")
.
...
.
model = model.to(device)
model.eval()
target_shape = (224, 224)
example_inputs = torch.randn([batch_size, 3, target_shape[1], target_shape[0]]).to(device)
logger.debug(f"example_inputs.shape={example_inputs.shape}")
inspector = Inspector("DPUCZDX8G_ISA1_B4096")
inspector.inspect(model, example_inputs, device)

The error message in this case is the same as above, although the Traceback is not exactly the same:
2022-09-02 12:02:58.840 | DEBUG    | __main__:quantize:343 - example_inputs.shape=torch.Size([2, 3, 224, 224])

[VAIQ_NOTE]: =>Inspector is initialized successfully with target:
name: DPUCZDX8G_ISA1_B4096
type: DPUCZDX8G
isa_version: 1

[VAIQ_NOTE]: =>Start to inspect model...

[VAIQ_NOTE]: =>Quant Module is in 'cuda'.

[VAIQ_NOTE]: =>Parsing Vgg19...

[VAIQ_NOTE]: Start to trace model...

[VAIQ_NOTE]: Finish tracing.

[VAIQ_NOTE]: Processing ops...
██████████████████████████████████████████████████| 44/44 [00:00<00:00, 1790.06it/s, OpInfo: name = return_0, type = Return]

[VAIQ_NOTE]: =>Doing weights equalization...

[VAIQ_NOTE]: =>Quantizable module is generated.(quantize_result/Vgg19.py)
Traceback (most recent call last):
  File "quantize_vgg19_features_vai25.py", line 551, in <module>
    run_main()
  File "quantize_vgg19_features_vai25.py", line 545, in run_main
    args.input_pairs)
  File "quantize_vgg19_features_vai25.py", line 346, in quantize
    inspector.inspect(model, example_inputs, device)
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/pytorch_nndct/apis.py", line 182, in inspect
    self._inspector_impl.inspect(module, input_args, device, output_dir, verbose_level)
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/pytorch_nndct/hardware/inspector.py", line 83, in inspect
    dev_graph = self._prepare_deployable_graph(copied_model, input_args, device, output_dir)
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/pytorch_nndct/hardware/inspector.py", line 110, in _prepare_deployable_graph
    g_optmizer.layout_tranform()
  File "/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/nndct_shared/compile/deploy_optimizer.py", line 445, in layout_tranform
    if pn.transpose_out_order is None and pn.out_tensors[0].ndim and node.out_tensors[0].ndim and pn.out_tensors[0].ndim == node.out_tensors[0].ndim:
IndexError: list index out of range

The model I am using is a slightly modified version of VGG19, which allows the extraction of some intermediate layers:
class Vgg19(torch.nn.Module):

    # modified from the original @ https://github.com/chenyuntc/pytorch-book/blob/master/chapter08-neural_style/PackedVGG.py

    def __init__(self, batch_normalization=True, required_layers=None):

        if required_layers == None and batch_normalization:
            required_layers = [3, 10, 17, 30, 43, 46]
        elif required_layers == None:
            required_layers = [2, 7, 12, 21, 30, 32]

        # features 2，7，12，21, 30, 32: conv1_2,conv2_2,relu3_2,relu4_2,conv5_2,conv5_3
        super(Vgg19, self).__init__()

        if batch_normalization:
            features = list(models.vgg19_bn(pretrained=True).features)[
                :47]  # get vgg features
            self.avgpool = models.vgg19_bn(pretrained=True).avgpool
            self.classifier = models.vgg19_bn(pretrained=True).classifier
        else:
            features = list(models.vgg19(pretrained=True).features)[
                :33]  # get vgg features
            self.avgpool = models.vgg19(pretrained=True).avgpool
            self.classifier = models.vgg19(pretrained=True).classifier

        # construct network in eval mode
        self.features = torch.nn.ModuleList(features)

        # record required layers to save them in forward
        self.required_layers = required_layers

    def forward(self, x):
        results = []
        for ii, model in enumerate(self.features):
            x = model(x)
            if ii in self.required_layers:
                results.append(x)
        # x to head and get output
        x = self.avgpool(x)
        flatten = torch.flatten(x, 1)
        output = self.classifier(flatten)

        return results, output

@daniperfer
This is a bug in vitis-ai pytorch quantizer 2.5 version. You can bypass it by change the code in file
/opt/vitis_ai/conda/envs/vitis-ai-pytorch/lib/python3.7/site-packages/nndct_shared/compile/deploy_optimizer.py，near line 443, to the following code:
      **if len(node.in_nodes) <= 1 or len(node.out_nodes) == 0 or node in implicit_ops:
        continue**
      if pn.transpose_out_order is None and pn.out_tensors[0].ndim and node.out_tensors[0].ndim and pn.out_tensors[0].ndim == node.out_tensors[0].ndim:

Thanks, @niuxjxlnx:
After having applied your solution above, I was able to export the model.


RFC: Drop Spectrum in favor of Github Discussions.

I think it's time to drop Spectrum in favor of Github Discussions.
See TailwindCSS discussions here: https://github.com/tailwindlabs/tailwindcss/discussions. Amazing!
And you can also move an issue in discussion and the other way around.
Also Spectrum almost always in the last few days is like this:

Funnily enough we were talking about this just today! We don't have access to the discussions Beta yet but I'll see what I can do.
Totally agreed that Spectrum isn't cutting it anymore.

Done! 🎉


the plugin is broken?

The first password authentication part passes, however the next flow (twofactor-authn-flow.xml) fails.
Trackback from main idp process (debug mode):
2016-12-12 08:22:48,737 - ERROR [org.springframework.webflow.execution.ActionExecutionException:76] -
org.springframework.webflow.execution.ActionExecutionException: Exception thrown executing [AnnotatedAction@3667f1d1 targetAction = [EvaluateAction@3bbfadd4 expression = T(it.reti.integrations.TwoFactorAuthentication).instance(environment.getProperty('twofactor.token', ''), usernamePasswordContext.getUsername()), resultExpression = flowScope.twofactor], attributes = map[[empty]]] in state 'null' of flow 'authn/twofactor' -- action execution attributes were 'map[[empty]]'
	at org.springframework.webflow.execution.ActionExecutor.execute(ActionExecutor.java:60)
Caused by: org.springframework.binding.expression.EvaluationException: An ELException occurred getting the value for expression 'T(it.reti.integrations.TwoFactorAuthentication).instance(environment.getProperty('twofactor.token', ''), usernamePasswordContext.getUsername())' on context [class org.springframework.webflow.engine.impl.RequestControlContextImpl]
	at org.springframework.binding.expression.spel.SpringELExpression.getValue(SpringELExpression.java:92)
Caused by: org.springframework.expression.spel.SpelEvaluationException: EL1011E:(pos 48): Method call: Attempted to call method getUsername() on null context object
	at org.springframework.expression.spel.ast.MethodReference.throwIfNotNullSafe(MethodReference.java:144)

Environment:
Ubuntu 16.4
IdP version 3.3.0

Sorry for getting back so late.
The problem seems to be present onyl from IdP version 3.3.0. Some of the beans in the authentication flows changed and so the process is no longer able to retrieve username from authentication session.
Still looking for a solution, keep you updated when found!


Bookmarks

Please create and implement the Ultimate Bookmark system for  VS Code.
Ok any basic bookmark system would be really useful right now working on an enterprise project.   But you could go to the top with this adding colour coding for different sets of bookmarks and groupings etc.
Good luck!!!

Have you tried using any of the bookmark extensions that are available?

Have you tried using any of the bookmark extensions that are available?

Have you tried using any of the bookmark extensions that are available?

Hi John.
tbh it never entered my mind that there would be one!   I'm a Visual Studio 20xx bunny.   I don't often add gizmos to it anymore.  If it's worth having MS usually buys it and implements it such as CSharpener etc.
Thanks for the tip.   Is there one you'd recommend?

Have you tried using any of the bookmark extensions that are available?

Hi John.
tbh it never entered my mind that there would be one!   I'm a Visual Studio 20xx bunny.   I don't often add gizmos to it anymore.  If it's worth having MS usually buys it and implements it such as CSharpener etc.
Thanks for the tip.   Is there one you'd recommend?


refactored accessKey object

issue -> #49
https://tfs/DefaultCollection/Server Tools/_workitems/edit/389207
Note: I initially wasn't sure whether to publish prod or preview but since this is relatively small change, i just published preview

As for this comment Note: I initially wasn't sure whether to publish prod or preview but since this is relatively small change, i just published preview
Maybe next time could get the api client core merged in before creating package for other libraries since it is a pain to update the package again in the other repos if there are comments to resolve.
I think after this is merged in, we can publish to prod since we don't want the sample project to use a preview package


Home Page New Idea

Description

New Folder named "ui" has been created for UI contributions
Readme file in UI folder has been added
Guideline for uploading files in "ui" folder and preview has been added

Solves #14
Type of change

[x] New Design Idea Added (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

Screenshots

Original
New Idea

@jhasuraj01 Please put image in this format assets/homepage/<your name>/xyz.png

@codewithvk I guess we should keep UI submission and Website assets separate as those assets (images, logo) will be used in frontend and keeping everything in one place might be confusing

@codewithvk I Made all the suggested Changes kindly review

@jhasuraj01 don't worry it is fine.
Thanks for having contributing :)


Fix github workflow on release-0.10

Update python-test github workflow to be compatible with new pip and setuptools.
https://setuptools.pypa.io/en/latest/userguide/development_mode.html#legacy-behavior
What this PR does / why we need it:
I tried to backport a fix https://github.com/kserve/kserve/pull/2886 into a new 0.10 release. However build failed here
https://github.com/kserve/kserve/actions/runs/4920110455/jobs/8788555585?pr=2886, and we got an import error.
________________ ERROR collecting tests/test_anchor_tabular.py _________________
ImportError while importing test module '/home/runner/work/kserve/kserve/python/alibiexplainer/tests/test_anchor_tabular.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
alibiexplainer/tests/test_anchor_tabular.py:19: in <module>
    from sklearnserver.model import SKLearnModel
E   ModuleNotFoundError: No module named 'sklearnserver'

I reproduced this issue in a local Ubuntu container. It only occurs on pip 23.1 and newer and we upgrade pip to the latest version in GitHub actions. Pip 23.1 upgrades setuptools from 44.0.0 (pip 23.0.1) to 67.6.1. setuptools 64.0.0 introduced a change on editable install implementation.
I am adding --config-settings editable_mode=compat to pip install command as a workaround as suggested on setuptools docs. Not an expert on this, I am not sure how we can fix with the best practice.
Some other libraries does this too, for example bentoml. https://docs.bentoml.org/en/latest/installation.html#editable-install (click to expand For users using setuptools>=64.0.0 section).
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.
Fix a github workflow issue causing test failures. No change to kserve code.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Python build checks passed for this pull request.

Logs
N/A

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:
None

Thanks @greenmoon55 !!
/lgtm
/approve


Must construct additional test coverage

I made sure we had test coverage measurement here. It looks like we're possibly missing some spots. Please make sure we've got enough coverage on the keys bits.

Done!


Get the query type for a message by a common get_query_type method

Refactor towards getting RedisCache working.
Simplifies and unifies the implementation of various transforms

Just rebased and pushed


fix(resizable-directive): browser check for angular universal

Because it doesn't know what document is
Fixes 'ReferenceError: document is not defined'

Codecov Report

Merging #83 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   95.94%   95.97%   +0.02%
==========================================
  Files           4        4
  Lines         296      298       +2
  Branches       29       29
==========================================
+ Hits          284      286       +2
  Misses          8        8
  Partials        4        4

Impacted Files
Coverage Δ

src/resizable.directive.ts
95.75% <100%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2c74c...dd3dfaf. Read the comment docs.

All fixed. If you would be so kind to merge and release, you‘ll get a virtual beer directly from the Oktoberfest brewery next to me.

Perfect, thank you! Cutting a new release momentarily 🎉


chore: remove deprecated f64 constants to satisfy Clippy

The MSRV Clippy check was failing; looks like std::f64::EPSILON is now f64::EPSILON.

I'm surprised by the deprecation of std::f64 but I guess it makes sense. Docs: https://doc.rust-lang.org/std/f64/constant.EPSILON.html


Fix any nullability and refactor typing model

Major changes:

Fixes an issue where we assume that all JSAnys should be nullable, whereas all anys should be nullable instead.
Changes typing model to go from IDLType to "raw" type, which is either an IDL declaration type or a dart:js_interop type, to a Dart type reference. This makes it easier to add generic types later as well.

Minor changes:

Reuses _Type and renames it to _RawType instead of using a record.
Removes unnecessary "isReturn" parameters as undefined can only appear in a return type per the web IDL spec.
JSVoid -> void as it's more readable.

Quite a large diff in the output but it's entirely either the void change or the any nullability change.


Dramacool addon not retrieving episode from server

I have trouble to load dramacool server. It can load the drama or movies available but when I click on it to view the episode available, it just won't load... I tried install kodi on my pc and it is working fine. I had tried rollback to 19, reset tv factory setting, reinstall kodi, clear cache but it is still not working. Problem only with dramacool. Other addon are working fine.

faced the same issue.

@groggyegg, it is not working after your update. Thanks! :)


penalty shoot out game

PR Description 📜
add a new game penalty shootout game
Fixes #4893

Mark the task you have completed ✅

[X] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[X] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.
[X] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[X] I have added screenshot for website preview in assets/images
[X] I have added entries for my game in main README.md
[X] I have added README.md in my folder
[] I have added working video of the game in README.md (optional)
[X] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @ANKeshri ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit please review once and merge my pr

@kunjgit @ishita-43 please review once and merge my pr

Will soon be merged by the admin

/assign

@kunjgit solved the conflict please merge it


Markdown models don't have equals/hashcode implementation

Since https://github.com/JetBrains/jewel/pull/331, equality and hashcode checks on ALL Markdown entities are meaningless, since all those models are value classes wrapping CommonMark models. CommonMark models do NOT implement equals and hashcode. This is potentially problematic for Compose usages, and many other cases.
We need to revert #331, since value classes do not support custom equals and hashcode implementations and we cannot rely on CommonMark models. We need true, content-based equals and hashcodes.

Fixed in #458


Inheritance Planning - Key Security - Assisted Keys - Textual changes.

Change to “Inheritance Key” Subtitle: “Create a vault with Inheritance Key”
Inside we only need Inheritance Key, not Signing Server.

Title: Inheritance Key
Subtitle: Add to any vault
Top para: While creating a vault, you can assign any applicable key as Inheritance Key. This key can then be kept with the heir or a trusted party. It will become active only after a given period.
Bottom para: When the Inheritance Key is added to the vault a period to activate it is chosen. Until such a time it remains inactive. You can restart the timer anytime by performing re-vaulting.

CTA: Create vault with Inheritance Key
No subtitle needed.
It will take the user directly to the custom vault creation screen with the Inheritance Key checkbox selected

Textual changes have been done on both screens
Section:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=6492-6736&t=FFx5AHuiSdc91RDP-1
S.S

Vault is created with IK still it is showing create vault option.

Verified this issue on keeper app v 1.3.1(429)


How to achieve the effect of secure header signing?

I need to implement anti-replay capabilities for all interfaces, which means that all authenticated interfaces need to perform a SHA256 signature on all URLs, headers, or payloads and then place it in a specific key in the header. This functionality is relatively easy to implement, but does Swagger have a similar description, or can Utoipa generate a UI that automatically performs the signing action when a request is made?
I can only find the SecurityAddon component, but it seems to only define the scheme; the specific behavior is still implemented by Swagger UI or the client itself

Studied for 2 days. Understood. The UI can override init js, and then request interception can be done inside to complete this work. The project is really great, there are openings everywhere.


CalcPad crashes when using nested include statements and system variables in the path

See the images above showing the nested include statements and folder structure. The program crashes without an error message when using a system variable to do both include statements.

This is the traceback for the crash.

Update:
This crash still occurs when using nested include statements without the system variable in the path unless all files are in the working directory.

This code in the images above crashed it with the same traceback.

Hi!
I fixed the crash but the reason is an unhandled exception with non-existing file. So, please check the file names.
I can see that the slash after Modules/ is reversed. Should be Modules.
It also did not work with environmental variables in nested includes. I have forgotten to expand the variables in this case, which caused the same  exception with non-existing file. Anyway, I fixed this and added the appropriate exception handling. Also, fixed the units issue, but will write about this later. I will release an update in the beginning of the next week.

Ned,
Thanks for taking care of those items. I am still interested in working on the Excel/csv functionality, I wasn't sure how you felt about using EPPlus for this versus trying to reduce the size of the software by using system libraries and manually coding more of it:
@.***
I can send you the function files that converts the data into an array CalcPad can use after I know if you are comfortable using this module or not. This module would cover reading and writing to Excel, but it has much more functionality we wouldn't really need (and space consumption as a result).
Thank you,
[A picture containing icon  Description automatically generated]
Isaiah Martin, EIT
Structural Project Engineer
CORNERSTONE ENGINEERING, INC.
Office:<PHONE_NUMBER> | Cell:<PHONE_NUMBER>
www.cei-engineering.comhttp://www.cei-engineering.com/
NOW OFFERING ENVIRONMENTAL, GEOTECH, AND MATERIALS TESTING SERVICES!
Inc.5000 | USPAAC Fast 100 | Business First Fast 50
[Facebook]https://www.facebook.com/CornerstoneEngineeringInc          [Linkedin] https://www.linkedin.com/company/cei-engineering/
From: Ned Ganchovski @.>
Sent: Saturday, November 16, 2024 2:51 PM
To: Proektsoftbg/Calcpad @.>
Cc: Isaiah Martin @.>; Author @.>
Subject: Re: [Proektsoftbg/Calcpad] CalcPad crashes when using nested include statements without being in the same working directory (Issue #388)
Hi!
I fixed the crash but the reason is an unhandled exception with non-existing file. So, please check the file names.
I can see that the slash after Modules/ is reversed. Should be Modules.
It also did not work with environmental variables in nested includes. I have forgotten to expand the variables in this case, which caused the same exception with non-existing file. Anyway, I fixed this and added the appropriate exception handling. Also, fixed the units issue, but will write about this later. I will release an update in the beginning of the next week.

Reply to this email directly, view it on GitHubhttps://github.com/Proektsoftbg/Calcpad/issues/388#issuecomment-2480758225, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEZ26UQX564NOSDCQN2D4GL2A6O3PAVCNFSM6AAAAABR325YIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQG42TQMRSGU.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Expensify Card institution icon looks bland compared to others

Action Performed:
Break down in numbered steps

Go to Settings > Payments in an account that has an Expensify Card and is importing other cards
Look at the list of Payment methods

Expected Result:
The Expensify "institution" icon should look on par with other institutions like Chase and Bank of America. Given that we aren't showing an icon of a card for other banks, but rather the icon shown is the institution's logo, I would think we should use the Expensify logo since that is the institution issuing the card. Here's what it would look like if we did:

Actual Result:
The icon next to the Expensify Card looks bland and not like an actual institution.

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.0.97-0
@Expensify/design curious what you think.

Yeah, I agree that this would be a positive change!

Cool, I'll do that then.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Dataset cleanup, gnorm clipping/reporting

Requested (and one extra) additions:

Remove deprecated modules from (very large) dataset source file
Add support for gradient clipping via config flag, and use it to track progression of gnorm throughout training
Impose original Llama init scheme via a post-init function call after model construction (see PR 177 in fms repo)

Remaining todo for future PR: unit tests for dataloaders from closedFMS

we should keep unit test (your todo) in a different PR.

Branch has been updated to remove all the extra stuff surrounding model init. We'll now rely on the updated init scheme in PR 177 to ensure the init scheme matches the original Llama2.

LG.
@daviswer from the discussion above I assume the dependency PR is https://github.com/foundation-model-stack/foundation-model-stack/pull/177, so we should hold merging until that one is merged?

we'll need to fix the mypy test failures before landing this, but I think the init changes in the main repo can be landed independently / either order

Looks like there are some check failures:
pretraining/utils/config_utils.py:1: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/wrapping.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 3 errors in 3 files (checked 13 source files)
Error: Process completed with exit code 1.

which seems to be coming from FMS repo, rather than this PR. Now the question would be:
@afrittoli  Do we want to force the per-import check, or we are ok to suppress it?
If we want to enforce this, @JRosenkranz , what's the amount of effort (i.e. the current typed coverage) needed in FMS repo?

Looks like there are some check failures:
pretraining/utils/config_utils.py:1: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/wrapping.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 3 errors in 3 files (checked 13 source files)
Error: Process completed with exit code 1.

which seems to be coming from FMS repo, rather than this PR. Now the question would be:
@afrittoli Do we want to force the per-import check, or we are ok to suppress it? If we want to enforce this, @JRosenkranz , what's the amount of effort (i.e. the current typed coverage) needed in FMS repo?

mypy needs the types from imports to check the types in the current package. The FMS repo is already typed (except for the hf package where the typing is incomplete), and I added a py.typed there, but it seems that it's not picked up for some reason, I will check what's going on.

cc @nairbv

Looks like there are some check failures:
pretraining/utils/config_utils.py:1: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/wrapping.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 3 errors in 3 files (checked 13 source files)
Error: Process completed with exit code 1.

which seems to be coming from FMS repo, rather than this PR. Now the question would be:
@afrittoli Do we want to force the per-import check, or we are ok to suppress it? If we want to enforce this, @JRosenkranz , what's the amount of effort (i.e. the current typed coverage) needed in FMS repo?

mypy needs the types from imports to check the types in the current package. The FMS repo is already typed (except for the hf package where the typing is incomplete), and I added a py.typed there, but it seems that it's not picked up for some reason, I will check what's going on.

cc @nairbv

Looks like there are some check failures:
pretraining/utils/config_utils.py:1: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/wrapping.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: error: Skipping analyzing "fms.models.llama": module is installed, but missing library stubs or py.typed marker  [import-untyped]
pretraining/policies/ac_handler.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 3 errors in 3 files (checked 13 source files)
Error: Process completed with exit code 1.

which seems to be coming from FMS repo, rather than this PR. Now the question would be:
@afrittoli Do we want to force the per-import check, or we are ok to suppress it? If we want to enforce this, @JRosenkranz , what's the amount of effort (i.e. the current typed coverage) needed in FMS repo?

mypy needs the types from imports to check the types in the current package. The FMS repo is already typed (except for the hf package where the typing is incomplete), and I added a py.typed there, but it seems that it's not picked up for some reason, I will check what's going on.

Oh, it's the install command, it looks like it must be installed in dev mode from the a specific sha, otherwise it picks v0.0.3, which does not contain the py.typed command. I will make a PR to fix it now.

re-running type checking as https://github.com/foundation-model-stack/fms-fsdp/pull/10 has been merged.
I will merge this PR once that passes.

@daviswer @nairbv
I think this PR does require https://github.com/foundation-model-stack/foundation-model-stack/pull/177 to be landed first due to the introduction of reset_parameters.
I will try to push on the other end otherwise I might have to revert this merge as it is broken.

@lchu-ibm what's the failure case you're seeing?
I think in this commit the model.reset_parameters() should have been gated on hasattr:
https://github.com/foundation-model-stack/fms-fsdp/pull/5/commits/8a275873160ae5620471747cc0d08053dd258146
That commit came after my comment, but not sure if that's the breakage you're seeing.

ah I see this issue: https://github.com/foundation-model-stack/fms-fsdp/issues/15
that makes sense. model needs to be initialized before applying fsdp.


Add QueryEditor components

Ref: #28
Similar to #4, I'm adding several util components that can be used in a QueryEditor:

FillValueSelect: Select to set the fillValue property of the query. The possible values are fixed so they are included here.
FormatSelect: Select to set the format property of the query. Since each data source can have a different set of formats (Timeseries, Table, Logs...), the possible values are not defined here.
QueryCodeEditor: Simple query editor.

TODO:

[x] Write tests.

Thanks for the input @sarahzinger !


(semi issue) Regarding failed CIA tickets

In issue 247, i said that all the CIA installations were failing and I gave the error code, to which you replied that I should delete the ticket and try again. Well the thing is that the FIRST CIA that I downloaded ( the one which it gave an signature check fail) wasn't legit. The second one was legit, but the ticket failed to install. I deleted the ticket and installed the CIA again, but it still failed. I'm guessing this is not FBIs fault. But do you think the bad ticket is somewhat stuck in my system and it refuses to take anything else? Should i use another SD card?

Ummm... Tickets are in NAND.

Whoops


speedup is_iterable by using PyIter_Check

This especially speeds up the is_iterable call if it's not iterable (6x faster) and only provides 30% speedup for iterables.

not enough speedup to justify this change


ADT: PeftTest: Pass in the correct cancellation token in the perf test scenario.

Instead of NONE, pass in the cancellation token provided by the method signature to the underlying API call.

Is there an opportunity to pass the cancellation token while iterating so it could cancel on a new page too?

I will investigate

Is there an opportunity to pass the cancellation token while iterating so it could cancel on a new page too?

I will investigate

The SDK will internally pass down the cancellation token to all page retrieval method calls. so the user has to only pass it down to the initial query API.


Update CI configs.

Add back node.js 0.10
Install npm@2 for node.js 0.10
Enable caching for Travis (currently doesn't work with Trusty)
Test node.js x64 for v4 on Windows
Move grunt-cli to devDependencies.

@jzaefferer: please merge #92 first and then I'll rebase to check how things actually go.

Waiting for appveyor to finish...

Yeah, takes a while unfortunately.
BTW, will you release a new version?

Yep, just published v7.0.0. Bumping major as usual when vnu.jar changes. Thanks for your help!


🛠 Tooling: Changelogs violate markdownlint header-increment rule

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
This is CHANGELOG.md right now:
# [1.4.0](https://github.com/JoshuaKGoldberg/template-typescript-package/compare/v1.3.0...v1.4.0) (2022-12-13)

### Features

- bind console log for performance (not really) ([#105](https://github.com/JoshuaKGoldberg/template-typescript-package/issues/105)) ([98155c5](https://github.com/JoshuaKGoldberg/template-typescript-package/commit/98155c5fdb301c78bc9a04a5933b4843fb186692))

Note the # up top. That should be a ##, with a # Changelog above it.
CHANGELOG.md:3 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h3]

https://github.com/JoshuaKGoldberg/template-typescript-package/actions/runs/3689565107/jobs/6245646600
https://github.com/DavidAnson/markdownlint/blob/2b2dc27f24a16a2afdf66d850a247f7ce02df6c8/doc/Rules.md#md001---heading-levels-should-only-increment-by-one-level-at-a-time
Additional Info
No response

https://github.com/semantic-release/changelog/issues/279 😞


pass env to docker image in build_from_dir

Is there any way to pass env to docker image when calling build_from_dir method? I read the document but not found any solution to do this.

I think this is more for non static ARGs, IE proxies.
docker build --build-arg http_proxy=$http_proxy --build-arg https_proxy=$http_proxy
Is there a way to pass these to build_from_dir im looking for a way to do the same.

Hi @bcg62, did you managed to pass build args? We face the same problem

Looks like the options are passed all the way down to the POST request without being manipulated at all[1]. The Docker docs state that the buildargs field should key value pairs in JSON so this should work:
Docker::Image.build_from_dir '.', buildargs: {key: value}.to_json

[1] https://github.com/swipely/docker-api/blob/c1387816b6a9d88fe0e26a81af0f4bb3533a18a2/lib/docker/connection.rb#L91

I think we figured out, something like:
Docker::Image.build_from_dir('.', { 'dockerfile' => './Dockerfile', 'buildargs' => { 'myarg': myvalue } } )


Isolated function not working in Azure (NET7 RC2)

Hi,
I have built a simple net7 isolated function and cannot get it to work in Azure.
This is a link to a repository that shows the issue: https://github.com/demyte/repro-azure-functions-net7-issue-02
Based on what the log is saying, it looks like NET7 RC2 is not available as a runtime in the isolated image yet?
It seems if I flag it as "Ready To Run" using the additional project file directives:
<PublishReadyToRun>true</PublishReadyToRun>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>

It works, but this is not the way I want to run my functions.
Will NET7 RC2 be available on the isolated functions runtime in Azure soon?

Closing as net7 support has been GA


Waiting for events after they have been fired

Waiting for an event which is fired afterward works as expected:
#include "simcpp.h"

class Waiter : public Process {
public:
  Waiter(std::shared_ptr<Simulation> sim, std::shared_ptr<Event> event)
      : Process(sim), event(event) {}

  virtual bool run() override {
    PT_BEGIN();
    printf("Waiting for event\n");
    PROC_WAIT_FOR(event);
    printf("Event fired\n");
    PT_END();
  }

private:
  std::shared_ptr<Event> event;
};

int main() {
  auto sim = Simulation::create();
  auto event = std::make_shared<Event>(sim);
  sim->start_process<Waiter>(event);
  event->fire();
}

However, calling event->fire() before starting the Waiter process produces a segementation fault, as listeners is set to nullptr and thus event->add_handler(...) (called by PROC_WAIT_FOR(...)) no longer works. For me, this concept makes sense -- and it also works in SimPy ;).
It would be possible to check whether the event has been fired via event->is_processed(), but doing this every time seems a bit complicated. Instead, I would suggest adding a check to PROC_WAIT_FOR(...).
What do you think? I can also submit a pull request if desired.

Thanks for the report. As you might have guessed, this repository was an experiment that I abandoned after a short time, so I don't remember at this point how everything was supposed to hang together. :)
I made an attempt anyway to fix the specific problem you are describing. Added the check for event->is_triggered() to the PROC_WAIT_FOR macro.
If you have further suggestions for cleaning up this code I would be happy to hear about it.

Thanks for the fix!
Did you still continue with discrete-event simulation, and if so, what frameworks did you find useful?
About clearing up the code: I guess the whole thing could be improved with C++20 coroutines, but as they are not easy to use as of now, I would not do it. Overall, the code is clear enough in my opinion (though for myself, I split it into .cpp and .h to include it in multiple files).

Actually, another problem occured with the fix you commited: If the processes waiting for an event immediately waits for the same event again (or starts another process waiting for the same event), a segmentation fault occurs. value should be set before resuming the processes to prevent this.

Having co-routines in the language would make discrete event simulation so much better. I actually gave up on coroutines and wrote a railway simulation in Rust with explicit state machine code instead of coroutines.
You can see the simulation setup here: https://github.com/koengit/trainspotting/blob/master/rolling/src/eventsim/simulation.rs
You can see an example of simulation code here: https://github.com/koengit/trainspotting/blob/master/rolling/src/railway/infrastructure.rs#L85
I'm not claiming this is elegant code, but I found this approach to be easier to wrap my head around than trying to hack together co-routines a language that don't really support it. I'm also not a C++ expert.
I tried again to fix the issue, feel free to correct me again or make a pull request :) Thanks.

Yeah, that's why I chose SimPy for my simulation, but know I want to check whether a compiled simulation would bring a major speed-up (compared to JIT compilation with PyPy).
Thanks for the examples! I think I like SimPy more, but I guess then it wouldn't be a fast simulation.
And thanks again for the fix, see my pull request #2 for further changes.


Why using older es4..?

It's clearly 2024 and why would you write
const express = require('express');
when you can use module import from es7
"type": "module"
import express from "express"
No hate though i'm just curious

Hello, thank you for your feedback. I'll make the changes. I used it because I received starter files from the course I'm learning from.


Operator does not recognize that carrier is ready

It seems the image id looks different:
    Image ID:       docker-pullable://nginxdemos/hello@sha256:4771326623912d34d19f8bac8e7b50e132e2589ec103af7f21265592fb897170

This seems specific for Kubernetes coming with Docker Desktop.

This should be fixed in version 0.8.1
Please confirm it working

Works like a charm! Cheers! 🎉


Fix some broken links in Markdown files

Whoops, forgot to submit the CLA - done.

/ok-to-test

/lgtm

Thanks for fixing this @abayer (and sorry for the broken links!!) :heart:
/approve


autobrr: init at 1.36.0

Description of changes
Reopening #283389. Closes #224560.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I think I've addressed all remaining concerns.

We just released v1.38.0 so might be a good idea to bump the version in this pr :smile:

Is this still being worked on?

I plan on picking this up again shortly.

Great! The move to pnpm was the most recent big build related changes but other than that it should be smooth sailing.
Current version is 1.50.0 :)

I plan on picking this up again shortly.

Can I assist you with anything?

I think I've got it mostly figured out. I'm just not sure how to handle the session secret. Ideally autobrr's config.toml would be created from the NixOS module's settings, but I believe this would cause it to be added to the nix store. Which is problematic, since the nix store is world-readable, and that file also contains the secret for cookie authentication.

Any suggestions on how to avoid this?

https://github.com/autobrr/autobrr/blob/e2df1e4fb8e501fbf1b81b1878c2ae472bf7d62b/internal/config/config.go#L246-L354
I think optimal is to add an environmentFile option and specify the secrets in there, since autobrr has env var support

I think this is ready for review.

Addressed most of your suggestions @gepbird, thanks for the feedback. Still need to fix the update script, and a new issue  related to fetchGithub not retrieving the commit hash when it downloads the repository archive. Marking as this as draft again until I get those issues fixed.


[Bug report] Code is not aligned with line numbers

Description
at code block , it is easy to find the Code is not aligned with line numbers
this picture is from your offical site, and i find many vuepress2's site, all have this bug, include of me

and this is from my site

Reproduction
https://v2.vuepress.vuejs.org/guide/getting-started.html#manual-installation
https://nibazshab.github.io/app/aria2.html#配置文件
Used Package Manager
yarn
System Info
$ vuepress info

  System:
    OS: Linux 5.10 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (4) x64 Intel(R) Xeon(R) Gold 6133 CPU @ 2.50GHz
    Memory: 918.90 MB / 3.59 GB
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.9.0 - /tmp/yarn--1661252137425-0.1813988074204187/node
    Yarn: 1.22.19 - /tmp/yarn--1661252137425-0.1813988074204187/yarn
    npm: Not Found
  Utilities:
    Git: 2.30.2 - /usr/bin/git
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    @vuepress/bundler-vite:  2.0.0-beta.49
    @vuepress/bundler-webpack: Not Found
    @vuepress/cli:  2.0.0-beta.49
    @vuepress/client:  2.0.0-beta.49
    @vuepress/core:  2.0.0-beta.49
    @vuepress/markdown:  2.0.0-beta.49
    @vuepress/plugin-active-header-links:  2.0.0-beta.49
    @vuepress/plugin-back-to-top:  2.0.0-beta.49
    @vuepress/plugin-container:  2.0.0-beta.49
    @vuepress/plugin-docsearch: Not Found
    @vuepress/plugin-external-link-icon:  2.0.0-beta.49
    @vuepress/plugin-git:  2.0.0-beta.49
    @vuepress/plugin-google-analytics: Not Found
    @vuepress/plugin-medium-zoom:  2.0.0-beta.49
    @vuepress/plugin-nprogress:  2.0.0-beta.49
    @vuepress/plugin-palette:  2.0.0-beta.49
    @vuepress/plugin-prismjs:  2.0.0-beta.49
    @vuepress/plugin-pwa: Not Found
    @vuepress/plugin-pwa-popup: Not Found
    @vuepress/plugin-register-components: Not Found
    @vuepress/plugin-search: Not Found
    @vuepress/plugin-shiki: ^2.0.0-beta.49 => 2.0.0-beta.49
    @vuepress/plugin-theme-data:  2.0.0-beta.49
    @vuepress/plugin-toc: Not Found
    @vuepress/shared:  2.0.0-beta.49
    @vuepress/theme-default:  2.0.0-beta.49
    @vuepress/utils:  2.0.0-beta.49
    vue:  3.2.37
    vue-loader: Not Found
    vue-router:  4.1.4
    vuepress: ^2.0.0-beta.49 => 2.0.0-beta.49
    vuepress-vite:  2.0.0-beta.49
    vuepress-webpack: Not Found

Duplicate of #901


WIP ARC-1090: delete builds and deployments on repository delete

When a user deletes a GitHub repo, the GitHub app currently deletes the commits, branches, and pullrequests from Jira, but not the builds and deployments.
This PR adds deletion of builds and deployments as well.
I chose not to feature flag this change as I tested it successfully in staging and deleting a repository is not a function that is used too often.
Issue view before deleting the repo in GitHub:

Issue view after deleting the repo in GitHub:

No builds and deployments anymore :)

WIP that has been open for almost a year... killing.


feat(RCTAppDelegate): Implement RCTRootViewFactory

Summary:
This PR implements RCTRootViewFactory a utility class (suggested by @cipolleschi) that returns proper RCTRootView based on the current environment state (new arch/old arch/bridgeless). This class aims to preserve background compatibility by implementing a delegate that can implement all necessary methods inside of RCTAppDelegate.
Basic usage of this class:
self.rootViewFactory = [[RCTRootViewFactory alloc] initWithDelegate:self];

UIView *rootView = [self.rootViewFactory viewWithModuleName:self.moduleName
                                            initialProperties:[self prepareInitialProps]
                                                launchOptions:launchOptions];

As you can see we retain the RCTRootViewFactory which can be later used to create as many root views as we need. Also making it easier for brownfield integrations to work in RN
For React Native visionOS it's handy because we want to create root views "on demand" not only in the application didFinishLaunchingWithOptions method.
Resulting in the ability to create multiple window apps (This will be useful when React Native core adopts SceneDelegate and multi-window apps):
https://github.com/facebook/react-native/assets/52801365/460b3361-c060-49ab-adc2-8b080d4d0c9b
Changelog:
[INTERNAL] [ADDED] - Implement RCTRootViewFactory
Test Plan:
Check if root view is properly created on app initialization

@cipolleschi Creating RCTRootViewFactory would be the ideal solution but I didn't want to introduce too many changes. However I'm not re-creating key components every time with this approach: self.bridge, _reactHost and bridgeAdapter are created only once on the first call (I accidentally pushed code without this change at first).
Also, I can work on implementing the RCTRootViewFactory (if you are okay with having this)

@cipolleschi I decided to jump straight into it and implement this class, I think it will make initialization of RN a lot easier also in brownfield apps.
I tried to implement everything in a backward-compatible way

Thanks for your review @cipolleschi I think now it's much better the public interface is not changed except for the runtimeSchedulerEnabled, bridge and bridgeAdapter but those are properties that users shouldn't override.
I also fixed those hardcoded values

Hey @cipolleschi, I've rebased the PR on top of the latest changes, is there anything I can do to help you get this merged?

Hi @okwasniewski, sorry for the delay. I was quite busy in the past couple of weeks  dealing with other high priority tasks and I couldn't really spend some time on this.
I'll try to make this move forward this week. Thank you for your patience!


Segmentation fault at 0x0000000000000008

Enviroment
ruby -v
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18]### ###
Gemfile
source 'https://rubygems.org'
gem 'pycall'
require 'pandas'
users.controller.rb
def show

  require 'pycall'
  require 'pandas'

  pd = Pandas

  df = pd.read_csv(Rails.root + 'lib/csv/sample.csv', engine='python')

end

/Users/takuma/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/pycall-1.2.1/lib/pycall/pyobject_wrapper.rb:43: [BUG] Segmentation fault at 0x0000000000000008
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18]

-- Crash Report log information --------------------------------------------
   See Crash Report log file under the one of following:
     * ~/Library/Logs/DiagnosticReports
     * /Library/Logs/DiagnosticReports
   for more details.
Don't forget to include the above Crash Report log file in bug reports.


filter.py read_csv with line terminator '\n' as sep causes an error

I got the following error when running the notebook 1-NMT-Data-Processing:

Hi Oriane!
Thanks for your report!
Could you please give more details about your environment. For example, Pandas version.
pip3 freeze | grep pandas

I tried the script here with the same FR-EN UN dataset, with Pandas 1.4.4. on Mac OS. I tried it also on Google Colab. I could not replicate the issue in either case. So, I will highly appreciate if you can shed some light on what might be different on your environment. Thanks in advance!
I see your offered a solution here. Alternatively, you can try this solution, which replaces sep="\n" with sep="\0" Does this work for you?
Thanks!
Yasmin

I am closing this issue. Feel free to reopen it, if needed.


iOS build doesn't work after app-framework update

Root cause identified: https://forum.ionicframework.com/t/add-platform-ios-failed-for-cordova-ios-3-9-2/36164/9

solved with 1.2.17


Create a Sequenced table

Creates a place for storing generic items that have been sequenced.
Particuarly of the form: mapID, epoch.
Technically, a Trillian Log could serve the same purpose, but...

You can't do an atomic transaction across an API call.
We need to separate storing signed map heads from putting them in
an append only log in order to match the trillian Map API.

This API supports the trillian Map function for storing Signed Map Heads.

Updated for readability, PTAL


Gltfio : Skinning - Some wrong bones influence

Hi,
I have a strange skinning behavior.
It seems that there is little gap between some bones influences on some vertex groups:

Everything seems OK when rendering it from Blender or Kronos sample model viewer

I can't see it on the web Filament model viewer since the camera is in the wrong orientation.
Do you have an idea of where it could come from?

OK.
I figure out that disabling the
Blender > Export > gltTF 2.0
   v Animation
      v Skinning
         x Include All Bone Influences

is the way to go.

Now I have to make my animation more natural

There's a limit on the number of influences a vertex can receive, I imagine that's what you are running into. @prideout

Hard to tell what's going on without looking at your gltf file, but here are our known skinning limitations:

Filament supports only one vec4 joints/weights set (however this conforms with the glTF spec).
Filament does not support shearing in the bone matrix, where shearing is defined as rotation + non_uniform_scale + rotation.

This is not actionable unless we have a repro model to work with.


fix: Refactor to encapsulate Camel resources

Fixes: #201

#211 should go first

@lordrip thanks for the review, will work on those :+1:
in the meantime, what do you think about exposing CamelResource instead of these separate 3 propertyes through EntitiesContextResult?
https://github.com/KaotoIO/kaoto-next/pull/210/files#diff-4c2e81258e2bca994fbf3aea8ffbbbba648205b699002839dc31d34fb57be774R17
https://github.com/KaotoIO/kaoto-next/pull/210/files#diff-4c2e81258e2bca994fbf3aea8ffbbbba648205b699002839dc31d34fb57be774R18
https://github.com/KaotoIO/kaoto-next/pull/210/files#diff-4c2e81258e2bca994fbf3aea8ffbbbba648205b699002839dc31d34fb57be774R20
It might not be a significant difference in practice, but in this way the CamelResource is exposed as a part of the hook API.

@lordrip thanks for the review, will work on those 👍 in the meantime, what do you think about exposing CamelResource instead of these separate 3 properties through EntitiesContextResult? https://github.com/KaotoIO/kaoto-next/pull/210/files#diff-4c2e81258e2bca994fbf3aea8ffbbbba648205b699002839dc31d34fb57be774R17 https://github.com/KaotoIO/kaoto-next/pull/210/files#diff-4c2e81258e2bca994fbf3aea8ffbbbba648205b699002839dc31d34fb57be774R18 https://github.com/KaotoIO/kaoto-next/pull/210/files#diff-4c2e81258e2bca994fbf3aea8ffbbbba648205b699002839dc31d34fb57be774R20
It might not be a significant difference in practice, but in this way the CamelResource is exposed as a part of the hook API.

I'm having mixed feelings :smile:.
I think that exposing the CamelResource class is better for the following reasons:

Smaller API
You work with a single object rather than a bunch of separate little objects
We have all the details about how adding/removing entities in a consolidated place
It would greatly simplify the orchestration between entities

That being said, my doubts are about how would this affect the react render mechanism because before, we had an entities array tracked by react but now we have a method that creates a new array every time that it's called, so it means that very likely it will force to rerender the entire UI.
If we reach this point, we have seen in the past how this heavily impacts performance.
In case of doubt and as a rule of thumb, for things that end up being rendered, it's better to use them through React mechanism for this very same reason.
That being said, I think that the mentioned upsides are worth investigating further, so my vote would be to continue as we're doing in this pull request for now, and once is merged, we focus on evaluating if this causes the issue that I mentioned before, this way if we don't identify a problem now, but later, we would be able to pinpoint when this was introduced.
In addition to that, if we follow the path of using the CamelResource class, we need to make sure that we're using the interface everywhere and not a hard implementation.

metadata.name is not available for canvas
That's a good point, suggests that the metadata.name is a part of PipeVisualEntity. We can fix it to feed metadata.name to PipeVisualEntity for sure.

we need to keep the models as closes to the source code as possible

I think this part should be represented by the CamelResource classes, not the individual visual entities.

metadata.name is not available for canvas

That's a good point, suggests that the metadata.name is a part of PipeVisualEntity. We can fix it to feed metadata.name to PipeVisualEntity for sure.
EDIT: Not really. for Pipe it's OK as it only has one visual entity, but for Integration which could have multiple visual entities, it breaks the multiplicity contract - multiple visual entities would hold a reference to the resource global metadata.name. We might need to feed whole CamelResource into Canvas. And then, visual entites are actually Flow from the naming perspective.

We're doing this at the individual Camel objects level, my suggestion is to do the same for CRDs as well (Pipe, Integration), later on, how do we provide the ID to the canvas, we can figure it out later, but the main point is to have the object referenced in the individual Visual entities as close as possible to the Camel model.
If we leave aside the ID topic (metadata.name) for a moment, I still think we should provide the entire underlying object to the Visual entity class, as this helps with other stuff, like having access to the dependencies array or the annotations field.
Another very important topic is that by doing what we're doing now with the Pipe object, we're relying on updating an object by reference, and as I pointed out, this is not the best approach as is being updated "magically".

That's why I think we might need to provide entire CamelResource to the canvas, but not only the indivisual visual entities

Also want to point out w/r/t >  we could show multiple Pipes
We should visually distinguish these 2 completely

Multiple routes in one Integration
Multiple Integration CRs and each of those have multiple routes

The "multiple Pipe" is the 2nd, they're in separate resource/context.

Also want to point out w/r/t >  we could show multiple Pipes
We should visually distinguish these 2 completely
1. Multiple routes in one `Integration`

2. Multiple `Integration` CRs and each of those have multiple routes

The "multiple Pipe" is the 2nd, they're in separate resource/context.

Alright, then I would like to skip those for a moment, as we'll have logic to avoid having more than one CR for now

That's why I think we might need to provide entire CamelResource to the canvas, but not only the indivisual visual entities

I would prefer to not do this, as we'll end up with a God Class. We'll use this class for the Source Code editor, for the Canvas, and potentially for the Metadata editor as well :scream_cat:
My vote would be, let's go step by step, first by passing the pipe object to the Pipe class as this will make editing the Pipe more straightforward. In addition to that, we would avoid creating memory leaks by leaving objects linked in an unexpected manner.
At this point, I don't see a need to pass the entire CamelResource class to the canvas component, as we only need the definition of the object being rendered and nothing else (at least at the moment of writing).
Later on, if we require access to the entire CamelResource class for some reason, well, then we can thing of ways to work around that.


adding install of server component in conda build

This builds on #7, and uses:

the shiny new dist frontend build, which generates MUCH smaller, uglified packages
the ConfigManager to enable running the server component

The total size of the conda package is now 95k, which is getting respectable.

This seems OK but I can not see where the server component lives... can you point to it?

Erm, probably too many branches right now.
The server component (which does the nbconvert thing) is presently on layout-refactor.
I hope to have all that sorted by the end of the day.

Erm, probably too many branches right now.

jeje... I was thinking I was getting mad :wink:


Update gadget icons

Recolored gadget icons to match dark blue of current CMS theme. Image changes only.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Passing params

Hey,
Thanks for sharing the code.
I am a bit new with this and I am trying to pass a connection string parameter to the ApplicationDBContext. Can you please give some tips on that?

Hello,
You can set the connection string in web.config file
<connectionStrings>
    <clear />
    <add name="connectionString1" connectionString="Data Source=(local);Initial Catalog=TestDbIdentity;Integrated Security = true" providerName="System.Data.SqlClient" />
</connectionStrings>

Its key (connectionString1) is set in the ApplicationDbContext.cs file
public ApplicationDbContext(): base("connectionString1")
{

Aslo if you want to change the connection string at runtime, first you need to add a new constructor to the ApplicationDbContext.cs file
        public ApplicationDbContext(string connectionString)
            : base(connectionString)
        {
            //Note: defaultConnectionFactory in the web.config file should be set.
        }

And then in the SmObjectFactory.cs file, set the connection string:
 ioc.For<IUnitOfWork>()
      .HybridHttpOrThreadLocalScoped()
      .Use<ApplicationDbContext>()
      // Remove these 2 lines if you want to use a connection string named connectionString1, defined in the web.config file.
       .Ctor<string>("connectionString")
       .Is("Data Source=(local);Initial Catalog=TestDbIdentity;Integrated Security = true");

Cheers mate. Will give that a go.

Hey just one last question.
You have commented out this line in the SmObjectFactory.
//config.For().Use(()=> app.GetDataProtectionProvider()); // In Startup class
Is there a way I can inject the IDataProtectionProvider in the SmObjectFactory and not in the Startup class?


How can i add progress bar and duration in them generate canvas image ?

You can take a look at the options available here: https://github.com/cestef/spotify-card/blob/main/src/types/index.ts
You're probably looking for the progress options

You can take a look at the options available here: https://github.com/cestef/spotify-card/blob/main/src/types/index.ts
You're probably looking for the progressBar option

why it's not automatically fetching duration and progress bar

As I said, you need to pass the progressBar related options, you are providing a youtube link, and there's no way to retrieve the player's positions from withing the package being only given a link

As I said, you need to pass the progressBar related options, you are providing a youtube link, and there's no way to retrieve the player's positions from within the package being only given a link

can i have an example ? cuz your docs are not working so i am pretty confused how can i pass "progressBar related options"
also what is the correct way of fetching data from youtube url instead for providing url directly ?

I fixed it thanks


categories order of val.json and train.json

❓ Questions and Help
I trained mark rcnn on train.json, then tested on val.json. But ap is approximately 0. I checked the predicted bbox in bbox.json and gt, bboxs are localized but not classified.
Afterwards, I find that the categories order of train.json and val.json is different. When generating the json file, I only pay attention to make the name and id of categories correspond.
For example, my train.json is like this:
data['categories']
[{'supercategory': 'SUPER', 'id': 1, 'name': 'CLASS1'},
 {'supercategory': 'SUPER', 'id': 2, 'name': 'CLASS2'},
 {'supercategory': 'SUPER', 'id': 3, 'name': 'CLASS3'}
]

my val.json is like this:
data['categories']
[{'supercategory': 'SUPER', 'id': 2, 'name': 'CLASS2'},
 {'supercategory': 'SUPER', 'id': 1, 'name': 'CLASS1'},
 {'supercategory': 'SUPER', 'id': 3, 'name': 'CLASS3'}
]

If you have the same problem with me, you can check the categories order.

Thank you. I transferred the data in VIA format to COCO, without realizing the inconsistency between train and val categories


Switch to main antlr-kotlin plugin

switch to the official antlr-kotlin release
update our KotlinAntlrPlugin for official version of antlr-kotlin
update parser-expressions to use the main release of antlr-kotlin

I'm currently testing the change on our various platforms

I've tested this on Android, iOS, and knowgod.com


Implement eigen for second-order symmetric tensor

Codecov Report

Merging #14 (ca57630) into main (384b656) will decrease coverage by 2.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   88.85%   86.17%   -2.68%
==========================================
  Files          11       10       -1
  Lines         592      593       +1
==========================================
- Hits          526      511      -15
- Misses         66       82      +16

Impacted Files
Coverage Δ

src/ops.jl
100.00% <100.00%> (ø)

src/tensor.jl
96.77% <100.00%> (+0.26%)
:arrow_up:

src/einsum.jl
38.77% <0.00%> (-37.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384b656...ca57630. Read the comment docs.

Codecov Report

Merging #14 (ca57630) into main (384b656) will decrease coverage by 2.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   88.85%   86.17%   -2.68%
==========================================
  Files          11       10       -1
  Lines         592      593       +1
==========================================
- Hits          526      511      -15
- Misses         66       82      +16

Impacted Files
Coverage Δ

src/ops.jl
100.00% <100.00%> (ø)

src/tensor.jl
96.77% <100.00%> (+0.26%)
:arrow_up:

src/einsum.jl
38.77% <0.00%> (-37.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384b656...ca57630. Read the comment docs.


Fix fields in OH entities to match models

This PR makes changes to our entities that reflect the modifications requested of our Pydantic models.

Several string fields are now non-nullable, with a default of empty string, if they are optional fields
location_id is changed to room_id
Defaults given for fields with DateTime types

LGTM!!


Type hint  at property in basearray.pyi

Type hint jax.Array.at to aid IDEs.
Didn't submit a PR directly because

Not sure if there is any circular import issue
_IndexUpdateHelper is in internal, do we change the name or __name__ to make it look better?

General question for JAX developers: is there a 'canonical' name for the at-properties? jax.Array.at is not convenient for verbal communication. Maybe, functional array index accessor? I really want a name that is searchable, and I could refer to, say when answering questions in Github discussions.

Thanks for raising this! I think I left this out because circular imports make it tricky, but we should be able to figure it out.
The name we use now is "index update helper", and if you search for "jnp.ndarray.at" you find this page: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.ndarray.at.html

The name we use now is "index update helper"

I don't think it's a bad name. As for discoverability, I'd suggest inserting the exact phrase in ndarray.at document, Array class, jax.ops document, and maybe also in the shape bits. Something like
Index update helper
 or the `.at`-property

in CS paper title fashion.

Unfortunately, the title of that page is generated by sphinx autodoc, so it's not easy to change it. We can certainly add more words in the dosctring though.

We can certainly add more words in the dosctring though.

Yes, this is what I meant.


intersect mapped enum record and object

How would I create the equivalent to this with zod?
enum Status {
  NotStarted = 'not-started',
  InProgress = 'in-progress',
  CompletedSuccesfully = 'completed-succesfully',
  CompletedWithFailures = 'completed-with-failures',
  Failed = 'failed',
}
type StatusReports = {
  [k in Status]: number;
};

type StatusReport = StatusReports & {
  total: number;
};
const sr: StatusReport = {
  total: 5,
  [Status.NotStarted]: 1,
  [Status.InProgress]: 1,
  [Status.CompletedSuccesfully]: 1,
  [Status.CompletedWithFailures]: 1,
  [Status.Failed]: 1,
};

problems I've encountered so far
defining the mapped key type  for StatusReports with z.record() and z.nativeEnum(} yields Partial<Record<Status, number>>;,  with the mapped properties incorrectly being optional
enum Status {
  NotStarted = 'not-started',
  InProgress = 'in-progress',
  CompletedSuccesfully = 'completed-succesfully',
  CompletedWithFailures = 'completed-with-failures',
  Failed = 'failed',
}
const StatusReports = z.record(z.nativeEnum(Status), z.number());
const sr: z.infer<typeof StatusReports> = {}; // const sr : Partial<Record<Status, number>>

even if the mapped key properties were correctly inferred as required, I haven't figured out a way to merge z.record() with z.object({total: number})
using z.intersection() like so complies but throws the following error when parsed at runtime
const StatusReportSchema = z.intersection(
  z.record(StatusReports, z.number().min(0)),
  z.object({ total: z.number().min(0) }),
);

"Invalid enum value. Expected 'not-started' | 'in-progress' | 'completed-succesfully' | 'completed-with-failures' | 'failed', received 'total'"

Hi @tim1uphealth, I don't think there's a way to intersect an enum or a ZodNativeEnum with a ZodObject right now.
I have some ideas on how we can change that. Check out this PR: https://github.com/colinhacks/zod/pull/1660


Bolt-list missing class on bolt-list-item on web component

Jira
http://vjira2:8080/browse/BDS-1157
Summary
Update examples of web components by adding flex example and update web component bolt-list-item by adding behavior the same as in twig version.
Details
Both versions must have the same HTML structure.
Twig version:

Web component version:

How to test
Run this code locally and check if the web component version of display flex is the same as twig version by checking rendered HTML.

@mikemai2awesome i remove all files from this PR except js file which fixing the issue.

whoa whoa whoa - hold on a sec.
Why on earth are we externally adding component-specific CSS classes to these web components?

@sghoweri without this fix flex don't be working as expected. I can add new css styles to bolt-list-item when a parent has a specific class. Please give me info if this approach will be better. I want to b consistent between twig and web component.

@sghoweri i updated this PR to be working as a parent-child relation. Right now no class is added to bolt-list-item in twig or web component but correct behavior is in place.


Workflows

Adds CI workflows for the following:

pre-commit checks
CASE validation on any .json files in the data/ directory
Build and run the three language projects

How about we merge this now and address the comments I made in follow-on PRs.  They should all be straightforward if I understand the syntax and nesting right, but it might be a few round-trips with GitHub Actions.

All of my comments have been or are being addressed in other PRs.


Update geofence plugin and add geofence inclusion example

Thanks @jzaturensky. The CI is failing because of an effc++ warning:

error: ‘dronecode_sdk::GeofenceImpl::_mavlink_geofence_item_messages’ should be initialized in the member initialization list [-Werror=effc++]

Almost there! Just the style now :sweat_smile::
This should do it:
$ make fix_style

Note that there is a bug in clang-format, so dont commit the other changes if there are any (just the ones below should be fine):
< GeofenceImpl::GeofenceImpl(System &system) : PluginImplBase(system), _mavlink_geofence_item_messages()
---
> GeofenceImpl::GeofenceImpl(System &system) :
>     PluginImplBase(system),
>     _mavlink_geofence_item_messages()```

And now missing some documentation :laughing:. But that's the last step of the CI build :+1:.
Parsing file /home/user/DronecodeSDK/install/inclu/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:33: warning: Compound dronecode_sdk::Geofence::Polygon::Point is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:13: warning: Compound dronecode_sdk::Geofence is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:32: warning: Compound dronecode_sdk::Geofence::Polygon is not documented.
Generating code for file plugins/log_files/log_files.h.../home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:18: warning: Member Result (enumeration) of class dronecode_sdk::Geofence is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:30: warning: Member result_callback_t (typedef) of class dronecode_sdk::Geofence is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:15: warning: Member Geofence(System &system) (function) of class dronecode_sdk::Geofence is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:47: warning: Member send_geofence_async(const std::vector< std::shared_ptr< Polygon >> &polygons, result_callback_t callback) (function) of class dronecode_sdk::Geofence is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:28: warning: Member result_str(Result result) (function) of class dronecode_sdk::Geofence is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:38: warning: Member Type (enumeration) of class dronecode_sdk::Geofence::Polygon is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:40: warning: Member points (variable) of class dronecode_sdk::Geofence::Polygon is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:41: warning: Member type (variable) of class dronecode_sdk::Geofence::Polygon is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:34: warning: Member latitude_deg (variable) of class dronecode_sdk::Geofence::Polygon::Point is not documented.
/home/user/DronecodeSDK/install/include/dronecode_sdk/plugins/geofence/geofence.h:35: warning: Member longitude_deg (variable) of class dronecode_sdk::Geofence::Polygon::Point is not documented.


Installation Issues

running install
running bdist_egg
running egg_info
writing pointnet2.egg-info/PKG-INFO
writing dependency_links to pointnet2.egg-info/dependency_links.txt
writing top-level names to pointnet2.egg-info/top_level.txt
reading manifest file 'pointnet2.egg-info/SOURCES.txt'
writing manifest file 'pointnet2.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_ext
building 'pointnet2_cuda' extension
gcc -pthread -B /home/anaconda3/envs/FR1/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/anaconda3/envs/FR1/lib/python3.7/site-packages/torch/include -I/home/anaconda3/envs/FR1/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/home/anaconda3/envs/FR1/lib/python3.7/site-packages/torch/include/TH -I/home/anaconda3/envs/FR1/lib/python3.7/site-packages/torch/include/THC -I/usr/local/cuda-10.2:/include -I/home/anaconda3/envs/FR1/include/python3.7m -c src/pointnet2_api.cpp -o build/temp.linux-x86_64-3.7/src/pointnet2_api.o -g -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=pointnet2_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++11
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
In file included from src/pointnet2_api.cpp:4:0:
src/ball_query_gpu.h:6:10: fatal error: cuda.h: No such file or directory
#include <cuda.h>
^~~~~~~~
compilation terminated.
error: command 'gcc' failed with exit status 1

Please go to previously asked questions to find answers.


us-mt

state data
ftp://ftp.gis.mt.gov/

Added
https://github.com/openaddresses/openaddresses/blob/master/sources/us/mt/statewide.json


Footer

Feature description
All the pages have different footers,please assign this issue to me I'll work on it
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

All the pages have different footers,please assign this issue to me I'll work on it

@Gunjanrathore8178 All pages have different themes and accordingly different footers.


Update SourceLink to 1.0.0-beta2-19367-01

From 1.0.0-beta2-19270-01.
Relates to #469.

Part of #469.


Compile (5) Related Papers for Proposal

Per project guidance, we need to review (5) papers to include in our project proposal. Please create an issue ticket for each paper selected so team members can divide up review responsibilities and commit a paragraph to the proposal write-up.

I can write 2 or 3 paper review. I can focus on the LLM. If someone else can write about the current methods of detecting security threaths from system logs.

silly question? 🙂 where do I go to see the kahnban board?

From: Cruzportillo @.>
Sent: Monday, October 7, 2024 7:04 AM
To: JGillette71/SLLIM @.>
Cc: Subscribed @.***>
Subject: Re: [JGillette71/SLLIM] Compile (5) Related Papers for Proposal (Issue #1)
I can write 2 or 3 paper review. I can focus on the LLM. If someone else can write about the current methods of detecting security threaths from system logs.
—
Reply to this email directly, view it on GitHubhttps://github.com/JGillette71/SLLIM/issues/1#issuecomment-2396738818, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMZBWUBW4ZCJB6C6WRVNPDZ2J2DXAVCNFSM6AAAAABPNVLQWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWG4ZTQOBRHA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Bring back Fix bug where an invalid instance relative filename would crash rather than returning null, fix a bug where the wrong exception was being thrown (NullPointer instead of IllegalArgument) in a method, write tests for HttpRestProtocolWrapper

Not tested yet

This should be multiple pull requests. Please isolate changes so they can be addressed and reviewed on their own


US#456048 Make IDOL Admin work through Ingress

Just a draft as still need to make this configurable and modify the haproxy thing. Had a couple of questions:

Do I need to update the idol-library and single-content .tgz files in helm/release?
I've tested ingress manually, but is there testing for this and should we add tests?

Need to update the idol-library version in order to actually publish the ingress template changes (and that means then updating the charts that use it).

We might need to rethink how the idol-library ingress templating is handled if we want to avoid having to individually update every components ingress template

Haven't yet addressed your comment https://github.com/opentext-idol/idol-containers-toolkit/pull/48#issuecomment-2061063788, but have addressed everything else.
I haven't actually tested this yet since making the changes since I think my ingress might be broken again, will try recreating the cluster.

Okay, I've managed to test and it seems fine, idol-library and single-content updates are done, just need to update the ingress templates for every other chart.

Sorry, a lot of files to look through, but it's mostly version updates

I think everything is working as it should now, templating seems to be all good. The only chart that I haven't changed is nifi, but can look into that?


GC: profiling stats and warning bindings

These bindings allow further profiling stats and binding to warnings of boehm.
Extracted from:

https://github.com/crystal-lang/crystal/issues/3997#issuecomment-320500210
https://github.com/crystal-lang/crystal/issues/2104#issuecomment-180471871

Bdw seems to design the api in a backward compatible way. If fields are no longer user they will remain in that struct probably and the size is used as a version check.
Better to decouple for that and remove unused fields in the GC module.


implement defaultValue for RichTextField

Find it hard to believe that there is no way to display a defaultValue in a RichTextField... if there is please tell me

@jshinroblox You can set the content to whatever you want, and that will be used as the default value, as can be seen in the CodeSandbox linked from the README (https://codesandbox.io/p/devbox/mui-tiptap-demo-3zl2l6?file=%2Fsrc%2FEditor.tsx%3A142%2C1-143%2C1). This is the behavior of Tiptap's useEditor hook: https://tiptap.dev/docs/editor/api/editor#content

@jshinroblox You can set the content to whatever you want, and that will be used as the default value, as can be seen in the CodeSandbox linked from the README (https://codesandbox.io/p/devbox/mui-tiptap-demo-3zl2l6?file=%2Fsrc%2FEditor.tsx%3A142%2C1-143%2C1). This is the behavior of Tiptap's useEditor hook: https://tiptap.dev/docs/editor/api/editor#content

That is for a RichTextEditor. For a RichTextField there seems to be no way to do that.

RichTextField renders the content that comes from the editor, so you should set content with the useEditor hook, which is what you then provide as context via <RichTextEditorProvider editor={editor}>. RichTextField is for displaying the content of the editor but does not update the editor's content, etc. itself.


docs: re-format contributing

Issue
The document CONTRIBUTING.md contains some minor formatting and other text issues:

Docker terms "Docker Hub" and "Docker" not always written according to their Trademark
Prettier suggests formatting changes

Change

Write "Docker Hub" and "Docker" correctly
Format literal references
Format according to Prettier rules
Correct typos & grammar

Preview
https://github.com/MikeMcC399/cypress-docker-images/blob/format/contributing/CONTRIBUTING.md


STA infers a latch from a liberty model with a negative edge triggered clock gate cell

I'm seeing issues with the following test case: RAM8-new.tar.gz
The issue is with the EN0 and A0* inputs. Both feed into a clock gate cell, which is clocked by the inverted clock.  I did not update the OR submodule yet.

Thanks @jjcherry56 this does look to have fixed it. Closing.


CNV-23157: Adding Sysprep section on Scripts tab

📝 Description
Sysprep can only be added before creating a vm, and only for Windows vm's.
When the vm has already been created, sysprep cannot be edited.
https://issues.redhat.com/browse/CNV-23157
🎥 Demo
Before:

After:
Creating windows vm with sysprep:

Creating a non-Windows vm:

/retest

/retest

/jira refresh


PayU Logo

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification

Hi, thanks for the PR (:
Please  sign the DCO (hint git commit --amend --signoff)  and then we can merge

Seems like you got some unrelated changes in your branch. Care to rebase on top of master?

Yes Giedrius is right, let's skip unrelated changes.
Also is there any alternative for the logo? Yellow colour is not really visible on the white background... ):


Examples should not be using deprecated host devices

Host device is not mandated by SYCL 2020 spec. Support for host device has been removed in DPC++ 2023, and has been removed from dpctl in https://github.com/IntelPython/dpctl/pull/1028
Example for device querying should be modified to avoid using removed functionality: https://github.com/IntelPython/DPEP/blob/main/examples/04-dpctl_device_query.py#L33

Thank you for catching this. Will get it updated


fix(lsp): support +pyright with eglot

eglot does not work out-of-the-box with pyright, so I add the five lines

Sorry for the late response. Thanks for the help!

Take care of yourself. Hope disease will be far away from you


Docdiff: showing changes in tables that didn't change

I noticed that Docdiff shows changes in .. list-table:: even when no changes were made:

PR Build showing this issue: https://frc-docs--2791.org.readthedocs.build/en/2791/docs/software/telemetry/robot-telemetry-with-annotations.html

Thanks for reporting this. We are tracking the same issue in https://github.com/readthedocs/addons/issues/348. Please, subscribe there to get updates.


DSD-1711: MultiSelectGroup Chakra update

Fixes JIRA ticket DSD-1711
This PR does the following:

Updates MultiSelectGroup to use Chakra 2.8 and general update for its v2.

How has this been tested?

Accessibility concerns or updates

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

@bigfishdesign13 I think we should discuss some of the props and combination. The non isBlockElement and column view does not work well. And there are general zindex issues:

Try different permutations to see what I mean.

I think we should discuss some of the props and combination. The non isBlockElement and column view does not work well. And there are general zindex issues:

The recommendations were to definitely not use isBlockElement for the column view, so that will resolve some of the potential issues you are seeing.  In the FilterBar component, we can enforce some fo the MultiSelect props based on the FilterBar layout, but other than really STRONG recommendations, I am not sure what we can do if and when a MultiSelect is used on its own.

The z-index behavior of one Multiselect over another when they are stacked in a row still seems unintuitive but I can see how there's no clear default. Assuming we're leaving that to the developer

Yes. I added a note about how it's not a recommended pattern to use.

Updated all comments except for flagging or removing the layout="row" and width="full" default prop values example. We should either have different defaults or state in the story example that it is not recommended.

@bigfishdesign13 ready for another review.


Fix tanzu diagnostics collect not respecting --output-dir

What this PR does / why we need it

Fixes golang module path of diagnostics plugin module
Fixes tanzu diagnostics collect not respecting --output-dir
Adds E2E tests

Details for the Release Notes (PLEASE PROVIDE)
Fix `tanzu diagnostics collect` not respecting `--output-dir`

Which issue(s) this PR fixes
Fixes: #1750
Describe testing done for PR
Tested using the e2e-test.sh script in GitHub Actions using the workflow config present in this PR. Example run from my fork - https://github.com/karuppiah7890/community-edition/runs/3782918205?check_suite_focus=true
Tested locally too -
tce $ /Users/karuppiahn/projects/github.com/vmware-tanzu/tce/cli/cmd/plugin/diagnostics/e2e-test/e2e-test.sh
Entering /Users/karuppiahn/projects/github.com/vmware-tanzu/tce/cli/cmd/plugin/diagnostics/e2e-test/.. directory to build tanzu diagnostics plugin
~/projects/github.com/vmware-tanzu/tce/cli/cmd/plugin/diagnostics ~/projects/github.com/vmware-tanzu/tce
Finished building tanzu diagnostics plugin. Leaving /Users/karuppiahn/projects/github.com/vmware-tanzu/tce/cli/cmd/plugin/diagnostics/e2e-test/..
~/projects/github.com/vmware-tanzu/tce
Creating a kind cluster for the E2E test
Creating cluster "e2e-diagnostics-181" ...
 ✓ Ensuring node image (kindest/node:v1.21.1) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-e2e-diagnostics-181"
You can now use your cluster with:

kubectl cluster-info --context kind-e2e-diagnostics-181

Have a nice day! 👋
Context "kind-e2e-diagnostics-181" renamed to "e2e-diagnostics-181-admin@e2e-diagnostics-181".
Running tanzu diagnostics collect command
2021/10/01 20:00:27 Collecting bootstrap cluster diagnostics
2021/10/01 20:00:27 Info: Bootstrap cluster: name=e2e-diagnostics-181
2021/10/01 20:00:27 Warn: Bootstrap cluster: specified name may not be valid: e2e-diagnostics-181
2021/10/01 20:00:27 Info: Found bootstrap cluster(s): ["e2e-diagnostics-181"]
2021/10/01 20:00:27 Info: Bootstrap cluster: e2e-diagnostics-181: capturing node logs
2021/10/01 20:00:30 Info: Capturing pod logs: cluster=e2e-diagnostics-181
2021/10/01 20:00:30 Info: Capturing API objects: cluster=e2e-diagnostics-181
2021/10/01 20:00:33 Info: Archiving: /var/folders/4z/09jpfvfj6c19lxl7ch78pzvc0000gn/T/tmp.27exp3N5/bootstrap.e2e-diagnostics-181.diagnostics.tar.gz
2021/10/01 20:00:33 Info: Capturing management cluster diagnostics: cluster=e2e-diagnostics-181; context=e2e-diagnostics-181-admin@e2e-diagnostics-181; kubeconfig=/Users/karuppiahn/.kube/config;
2021/10/01 20:00:33 Info: Capturing pod logs: cluster=e2e-diagnostics-181
2021/10/01 20:00:33 Info: Capturing API objects: cluster=e2e-diagnostics-181
2021/10/01 20:00:36 Info: Archiving: /var/folders/4z/09jpfvfj6c19lxl7ch78pzvc0000gn/T/tmp.27exp3N5/management-cluster.e2e-diagnostics-181.diagnostics.tar.gz
2021/10/01 20:00:36 Info: Retrieving workload cluster credentials
2021/10/01 20:00:36 Info: Retrieving workload cluster: cluster=e2e-diagnostics-181; context=e2e-diagnostics-181-admin@e2e-diagnostics-181; kubeconfig=/Users/karuppiahn/.kube/config;
2021/10/01 20:00:36 Info: Capturing pod logs: cluster=e2e-diagnostics-181
2021/10/01 20:00:36 Info: Capturing API objects: cluster=e2e-diagnostics-181
2021/10/01 20:00:40 Info: Archiving: /var/folders/4z/09jpfvfj6c19lxl7ch78pzvc0000gn/T/tmp.27exp3N5/workload-cluster.e2e-diagnostics-181.diagnostics.tar.gz
Checking if the diagnostics tar balls for the different clusters have been created
Cleaning up
Deleting cluster "e2e-diagnostics-181" ...
warning: this removed your active context, use "kubectl config use-context" to select a different one
deleted context e2e-diagnostics-181-admin@e2e-diagnostics-181 from /Users/karuppiahn/.kube/config
/var/folders/4z/09jpfvfj6c19lxl7ch78pzvc0000gn/T/tmp.27exp3N5/bootstrap.e2e-diagnostics-181.diagnostics.tar.gz
/var/folders/4z/09jpfvfj6c19lxl7ch78pzvc0000gn/T/tmp.27exp3N5/management-cluster.e2e-diagnostics-181.diagnostics.tar.gz
/var/folders/4z/09jpfvfj6c19lxl7ch78pzvc0000gn/T/tmp.27exp3N5/workload-cluster.e2e-diagnostics-181.diagnostics.tar.gz
/var/folders/4z/09jpfvfj6c19lxl7ch78pzvc0000gn/T/tmp.27exp3N5
tce $

Special notes for your reviewer
Check the e2e-test/README.md for understanding what has been done in the E2E test script

Looks like I have to close this PR unfortunately. The repo is detached from the PR 😅

I'll recreate the PR


add start delay

failed an integration test:
Error Trace:	/home/runner/work/iwf-golang-sdk/iwf-golang-sdk/integ/workflow_uncompleted_test.go:116
Error:      	Not equal:
expected: "workflow is not completed successfully, closedStatus: FAILED, failedErrorType(applies if failed as closedStatus):STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE, error message:activity error (type: StateApiWaitUntil, scheduledEventID: 9, startedEventID: 10, identity: ): activity StartToClose timeout (type: StartToClose)"
actual  : "workflow is not completed successfully, closedStatus: FAILED, failedErrorType(applies if failed as closedStatus):STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE, error message:activity error (type: StateApiWaitUntil, scheduledEventID: 8, startedEventID: 9, identity: ): activity StartToClose timeout (type: StartToClose)"
but seems not related to this change, because I also tried checking out previous commit without any of this change, and it still fails. I think it's probably some change of temporal


zsh completions cause errors due to backticks not being escaped

Excerpt from the output of cargo crev config completions --shell zsh:
_cargo__crev_commands() {
    local commands; commands=(
        "config:Local configuration" \
"crate:Crate related operations (review, verify...)" \
"id:Id (own and of other users)" \
"proof:Find a proof in the proof repo" \
"repo:Proof Repository" \
"trust:Add a Trust proof by an Id or a URL" \
"goto:Shortcut for `crate goto`" \
"open:Shortcut for `crate open`" \
"publish:Shortcut for `repo publish`" \
"review:Shortcut for `crate review`" \
"update:Shortcut for `repo update`" \
"verify:Verification Requirements" \
    )
    _describe -t commands 'cargo crev commands' commands "$@"
}

Those backticks aren’t escaped, and so are subshell invocations that will… well, hopefully fail rather than doing something weird. This mangles your prompt something awful, starting with this:
$ cargo crev Tab_cargo__crev_commands:1: command not found: crate
_cargo__crev_commands:1: command not found: crate
_cargo__crev_commands:1: command not found: repo
_cargo__crev_commands:1: command not found: crate
_cargo__crev_commands:1: command not found: repo
  cargo crev
<cargo crev commands completions>
config                               -- Local configuration
crate                                -- Crate related operations (review, verify...)
id                                   -- Id (own and of other users)
proof                                -- Find a proof in the proof repo
publish  update  review  open  goto  -- Shortcut for
repo                                 -- Proof Repository
trust                                -- Add a Trust proof by an Id or a URL
verify                               -- Verification Requirements

I think we are using structopt generated completion. Upgrading to recently released clap 3.0 could fix this and improve other things.

Seems like clap 3.0 does not have completion functionality (yet?). I can't do much about it then, sorry.


Explain why we're using English in GitHub Issues & PRs

The reasons we're using English in GitHub Issues & PRs:

It's more natural for software engineers to communicate in English because it involves many technical terms in English. Trying to translate them into Bahasa Indonesia posing a risk of miscommunication, while keeping them in English requires us to do a lot of italic formatting, according to PUEBI.
It accustoms the contributors, which are mostly Indonesian, to communicate in English. It is important to increase our English reading and writing skills because the vast majority of the global open-source communities are using Engish as the main language.
It makes this project easier to be recognised globally. So if we need to get more support from the global communities, they could easily understand what we are doing and help us out with their access and competence. e.g., providing us free credits for their services, advocating us to global leaders, or contributing directly to our codebase.

i'm not quite understand the reason behind this mas @zainfathoni. Could you enlighten me mas @zainfathoni ?

I have updated the description with my explanation, @andriawan. 😁


Is there a pybee-based Python app available on the App-store today?

Is there an app today that has gone through the app-store process and is available for download today from the app store?

Unfortunately, not at present.
However, there is precedent for having apps that use Python in the same way that BeeWare does - the approach used by BeeWare is the same as that used by Kivy, and Kivy does have apps in the app store. So - while there aren't any BeeWare apps in the app store, there is reason to believe they won't be rejected.
Closing this ticket because there's nothing directly actionable (other than submitting something to the app store, which isn't strictly a BeeWare issue - it's something that a BeeWare user will need to do at some point in the future).