Replace None with an object NoSharding.

This is to make the change to a C++ ShardingSpec easier.

This LGTM, I asked @skye to take a look also.
I am assuming that pxla.ShardingSpec is not considered public API. Do users ever need to construct or read those objects?

This LGTM, I asked @skye to take a look also.
I am assuming that pxla.ShardingSpec is not considered public API. Do users ever need to construct or read those objects?

It's also internal for me, but there are  few calls from e.g. tensorflow_models, ml_perf. It seems the be the same snippet of code which has been forked with a train script (there are like ~18 such non-jax files doing so, but it does not seem they use None):
def _unbroadcast(x):
  """Assuming `x` is replicated along its leading axis, remove that axis."""
  assert isinstance(x, jax.pxla.ShardedDeviceArray)
  sharding_spec = x.sharding_spec
  assert sharding_spec.shards_per_axis[0] == x.shape[0]
  assert not sharding_spec.is_axis_materialized[0]
  aval = jax.abstract_arrays.ShapedArray(x.shape[1:], x.dtype)
  sharding_spec = jax.pxla.ShardingSpec(
      sharding_spec.shards_per_axis[1:],
      sharding_spec.is_axis_materialized[1:],
      [(x.shape[0], 0)] + [(factor, index - 1) for factor, index
                           in sharding_spec.replication_factors])
  return jax.pxla.ShardedDeviceArray(aval, sharding_spec, x.device_buffers)

I launched a GTP in cr/352116408 to check nothing fails, assuming tests exist.

It's also internal for me, but there are  few calls from e.g. tensorflow_models, ml_perf. It seems the be the same snippet of code which has been forked with a train script (there are like ~18 such non-jax files doing so, but it does not seem they use None):
def _unbroadcast(x):
  """Assuming `x` is replicated along its leading axis, remove that axis."""
  assert isinstance(x, jax.pxla.ShardedDeviceArray)
  sharding_spec = x.sharding_spec
  assert sharding_spec.shards_per_axis[0] == x.shape[0]
  assert not sharding_spec.is_axis_materialized[0]
  aval = jax.abstract_arrays.ShapedArray(x.shape[1:], x.dtype)
  sharding_spec = jax.pxla.ShardingSpec(
      sharding_spec.shards_per_axis[1:],
      sharding_spec.is_axis_materialized[1:],
      [(x.shape[0], 0)] + [(factor, index - 1) for factor, index
                           in sharding_spec.replication_factors])
  return jax.pxla.ShardedDeviceArray(aval, sharding_spec, x.device_buffers)

I launched a GTP in cr/352116408 to check nothing fails, assuming tests exist.

I ran it internally, because it would take me a lot of time to do it in OS (I would need to build jax locally, which I don't know how to do).
I think it does not change anything, just the usual noise.
Without the change:
└──╼ TARGET_TOTAL_SECS=2 CUDA_VISIBLE_DEVICES= XLA_FLAGS=--xla_force_host_platform_device_count=500 bb pmap_benchmark
...

---------Benchmark summary for pmap_shard_sharded_device_array---------
  nargs    nshards      mean       %std    relative
-------  ---------  --------  ---------  ----------
     10          8  0.105513  11.4454       1
    100          8  0.368193   8.90511      3.48956
    101          8  0.356172   6.58713      3.37563
    500          8  1.14319    0.237879    10.8346
   1000          8  2.04005    0           19.3347
   5000          8  8.01584    0           75.9704
    100          2  0.241554   6.35878      2.28934
    100          4  0.294926   6.34386      2.79517
    100          8  0.369116   6.62533      3.49831
    100        100  1.71755    1.24343     16.2782
    100        500  6.70799    0           63.5753

---------Benchmark summary for pmap_shard_device_array---------
  nargs    nshards       mean      %std    relative
-------  ---------  ---------  --------  ----------
     10          8  0.0590367  18.0683      1
    100          8  0.246328    8.73276     4.17245
    500          8  1.05955     1.05783    17.9473
    100          2  0.101085   21.8612      1.71224
    100          4  0.174109   10.2306      2.94915
    100          8  0.250661   11.4526      4.24584

---------Benchmark summary for pmap_shard_outputs---------
  nouts    nshards       mean      %std    relative
-------  ---------  ---------  --------  ----------
     10          8   0.137291  10.5298      1
    100          8   0.413141   7.95815     3.00923
    500          8   1.41002    1.23046    10.2703
   1000          8   2.6428     0          19.2496
   5000          8  11.6036     0          84.518
    100          2   0.266749   9.34605     1.94294
    100          4   0.3165     8.00129     2.30531
    100          8   0.404103   6.20919     2.94339
    100        100   2.41844    0          17.6154
    100        500  12.2105     0          88.9383

---------Benchmark summary for ShardedDeviceArray_indexing---------
indices_fn               mean     %std    relative
------------------  ---------  -------  ----------
integer_indices     0.0719787  12.1457       1
integer_2D_indices  9.12722     0          126.804

With the change:
└──╼ TARGET_TOTAL_SECS=2 CUDA_VISIBLE_DEVICES= XLA_FLAGS=--xla_force_host_platform_device_count=500 bb pmap_benchmark
---------Benchmark summary for pmap_shard_sharded_device_array---------
  nargs    nshards       mean       %std    relative
-------  ---------  ---------  ---------  ----------
     10          8  0.0996357  13.1614       1
    100          8  0.351055   10.8804       3.52339
    101          8  0.366211    4.27462      3.6755
    500          8  1.09212     2.30705     10.9611
   1000          8  1.94619     1.09397     19.5331
   5000          8  7.59713     0           76.2491
    100          2  0.219362   12.8559       2.20164
    100          4  0.279566    6.64543      2.80589
    100          8  0.364913    5.00456      3.66248
    100        100  1.66384     0.624914    16.6992
    100        500  6.5926      0           66.1671

---------Benchmark summary for pmap_shard_device_array---------
  nargs    nshards       mean       %std    relative
-------  ---------  ---------  ---------  ----------
     10          8  0.0567073  23.0601       1
    100          8  0.226417    7.28242      3.99274
    500          8  1.03926     0.354028    18.3267
    100          2  0.0899203  19.5304       1.58569
    100          4  0.163566   17.4084       2.88438
    100          8  0.247211    6.71917      4.35942

---------Benchmark summary for pmap_shard_outputs---------
  nouts    nshards       mean      %std    relative
-------  ---------  ---------  --------  ----------
     10          8   0.12988   9.07826      1
    100          8   0.408531  9.56531      3.14544
    500          8   1.36306   0.714324    10.4947
   1000          8   2.62184   0           20.1866
   5000          8  11.4392    0           88.0747
    100          2   0.262397  7.61874      2.02029
    100          4   0.30444   9.01886      2.344
    100          8   0.388523  6.51703      2.99139
    100        100   2.42062   0           18.6373
    100        500  11.9683    0           92.1488

---------Benchmark summary for ShardedDeviceArray_indexing---------
indices_fn               mean     %std    relative
------------------  ---------  -------  ----------
integer_indices     0.0657426  15.4291       1
integer_2D_indices  8.35978     0          127.159

I ran it internally, because it would take me a lot of time to do it in OS (I would need to build jax locally, which I don't know how to do).
I think it does not change anything, just the usual noise.
Without the change:
└──╼ TARGET_TOTAL_SECS=2 CUDA_VISIBLE_DEVICES= XLA_FLAGS=--xla_force_host_platform_device_count=500 bb pmap_benchmark
...

---------Benchmark summary for pmap_shard_sharded_device_array---------
  nargs    nshards      mean       %std    relative
-------  ---------  --------  ---------  ----------
     10          8  0.105513  11.4454       1
    100          8  0.368193   8.90511      3.48956
    101          8  0.356172   6.58713      3.37563
    500          8  1.14319    0.237879    10.8346
   1000          8  2.04005    0           19.3347
   5000          8  8.01584    0           75.9704
    100          2  0.241554   6.35878      2.28934
    100          4  0.294926   6.34386      2.79517
    100          8  0.369116   6.62533      3.49831
    100        100  1.71755    1.24343     16.2782
    100        500  6.70799    0           63.5753

---------Benchmark summary for pmap_shard_device_array---------
  nargs    nshards       mean      %std    relative
-------  ---------  ---------  --------  ----------
     10          8  0.0590367  18.0683      1
    100          8  0.246328    8.73276     4.17245
    500          8  1.05955     1.05783    17.9473
    100          2  0.101085   21.8612      1.71224
    100          4  0.174109   10.2306      2.94915
    100          8  0.250661   11.4526      4.24584

---------Benchmark summary for pmap_shard_outputs---------
  nouts    nshards       mean      %std    relative
-------  ---------  ---------  --------  ----------
     10          8   0.137291  10.5298      1
    100          8   0.413141   7.95815     3.00923
    500          8   1.41002    1.23046    10.2703
   1000          8   2.6428     0          19.2496
   5000          8  11.6036     0          84.518
    100          2   0.266749   9.34605     1.94294
    100          4   0.3165     8.00129     2.30531
    100          8   0.404103   6.20919     2.94339
    100        100   2.41844    0          17.6154
    100        500  12.2105     0          88.9383

---------Benchmark summary for ShardedDeviceArray_indexing---------
indices_fn               mean     %std    relative
------------------  ---------  -------  ----------
integer_indices     0.0719787  12.1457       1
integer_2D_indices  9.12722     0          126.804

With the change:
└──╼ TARGET_TOTAL_SECS=2 CUDA_VISIBLE_DEVICES= XLA_FLAGS=--xla_force_host_platform_device_count=500 bb pmap_benchmark
---------Benchmark summary for pmap_shard_sharded_device_array---------
  nargs    nshards       mean       %std    relative
-------  ---------  ---------  ---------  ----------
     10          8  0.0996357  13.1614       1
    100          8  0.351055   10.8804       3.52339
    101          8  0.366211    4.27462      3.6755
    500          8  1.09212     2.30705     10.9611
   1000          8  1.94619     1.09397     19.5331
   5000          8  7.59713     0           76.2491
    100          2  0.219362   12.8559       2.20164
    100          4  0.279566    6.64543      2.80589
    100          8  0.364913    5.00456      3.66248
    100        100  1.66384     0.624914    16.6992
    100        500  6.5926      0           66.1671

---------Benchmark summary for pmap_shard_device_array---------
  nargs    nshards       mean       %std    relative
-------  ---------  ---------  ---------  ----------
     10          8  0.0567073  23.0601       1
    100          8  0.226417    7.28242      3.99274
    500          8  1.03926     0.354028    18.3267
    100          2  0.0899203  19.5304       1.58569
    100          4  0.163566   17.4084       2.88438
    100          8  0.247211    6.71917      4.35942

---------Benchmark summary for pmap_shard_outputs---------
  nouts    nshards       mean      %std    relative
-------  ---------  ---------  --------  ----------
     10          8   0.12988   9.07826      1
    100          8   0.408531  9.56531      3.14544
    500          8   1.36306   0.714324    10.4947
   1000          8   2.62184   0           20.1866
   5000          8  11.4392    0           88.0747
    100          2   0.262397  7.61874      2.02029
    100          4   0.30444   9.01886      2.344
    100          8   0.388523  6.51703      2.99139
    100        100   2.42062   0           18.6373
    100        500  11.9683    0           92.1488

---------Benchmark summary for ShardedDeviceArray_indexing---------
indices_fn               mean     %std    relative
------------------  ---------  -------  ----------
integer_indices     0.0657426  15.4291       1
integer_2D_indices  8.35978     0          127.159

ok, Global Tap presubmit showed one test failing internally. So I am closing this one, and we can submit it as cr/352116408

ok, Global Tap presubmit showed one test failing internally. So I am closing this one, and we can submit it as cr/352116408


Step by step Nodejs REPL tutorial

Article checklist
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines
This fixes #1972

working on progress

@srishilesh, work done!

@srishilesh, thanks for the suggestions, just a quick question,

Installing Node.js comes with REPL, why would I include a link to download it?
Adding a table of contents does not seem to fit this tutorial, but again I followed this, not mentioned anywhere.
I've also introduced this article by explaining REPL, how do you suggest I do it, I've read multiple published articles on section, am confused about how to rework the article while it seem to follow guidelines.

Kindly help, thanks!

@srishilesh, thanks for the suggestions, just a quick question,

Installing Node.js comes with REPL, why would I include a link to download it?
Adding a table of contents does not seem to fit this tutorial, but again I followed this, not mentioned anywhere.
I've also introduced this article by explaining REPL, how do you suggest I do it, I've read multiple published articles on section, am confused about how to rework the article while it seem to follow guidelines.

Kindly help, thanks!

@odiwuoramos

My bad. Realized that at the end of the article, forgot to delete that comment.
Adding Table of contents is not mandatory. But, I usually suggest adding it. Since, it helps readers understand what they're going to learn. (Let me do this for you during the tech review.)
I totally agree that you have explained about REPL in your introduction, but I believe a little in-detailed introduction would help the beginners. For instance, I didn't know about REPL earlier, so I had to refer other websites to actually understand what it is.

You could start the introduction by referencing excerpts from this Wikipedia article.
Later, you could state why we use REPL shell when we already have existing command prompts (Based on what I understood, REPL shell is primarily used for debugging javascript codes, and making runtime more tangible and allows you to test hypotheses).
Then, you can explain about Read-Evaluate-Print-Loop in-detail, as shown in this article.
Finally, you can give an overview of what is going to covered in the step-by-step tutorial. For example, performing mathematical operations, calling methods and so on.

I'm also adding few other articles, which could be of help to you:

https://www.freecodecamp.org/news/this-is-why-your-read-eval-print-loop-is-so-amazing-cf0362003983/
https://www.digitalocean.com/community/tutorials/how-to-use-the-node-js-repl
https://www.tutorialspoint.com/nodejs/nodejs_repl_terminal.htm

Hope this helps.
Please do not hesitate to ping me here or via Slack.
Thanks.

@srishilesh, I've made changes, could you check them out?

@odiwuoramos
Thanks for making the changes.
I'll review them by tomorrow

@srishilesh, are you still reviewing this article? 7 days?

@odiwuoramos
I'm so sorry.
Due to certain personal emergencies, I was not able to review them.
So, I'm assigning it to @cyberShaw . He'll continue the review from here.
Thank you.

@cyberShaw, all changes requested by @srishilesh had been made. I think it's just updating the labels!
cc @hectorkambow

I'll do the review, @odiwuoramos

@hectorkambow,  what could be wrong with this article that the reviewer is unable to finish up?
cc @cyberShaw

@odiwuoramos
Be patient, sometimes article reviews might be delayed due to various reasons.

Please make all changes and then ping the author, @odiwuoramos
Make sure you don't miss out on anything

This article is ready for final review. @odiwuoramos
A few points to note:

I noticed a ton of grammatical errors in the article. Please use a grammar checker such as Grammarly to fix grammar before making the pull request.
Make all the changes that the reviewer has requested. Don't leave out changes, this takes away a reviewer's time which they can spend in reviewing other articles. Multiple rounds of revision may lead to the PR being closed.
Please check out the edits I've made in the commit: 23589d2. Please add relevant articles/resources in the Further reading section to make sure it adds value to the article.

This article is ready for final review.
cc: @hectorkambow

@odiwuoramos @cyberShaw
Thank you - we are making some changes to the main repo now - and this is delaying a few article from being published as we want to implement the changes 1st - once these are done - we will publish this one asap. Thank you 🚀

just need to preview and published - when repo changes are finalized
NOTE

https://www.section.io/engineering-education/nodejs-repl-tutorial/


Add style to navbar

Is your feature or change request related to a problem? Please describe.
The navbar doesn't have a styling
Describe the solution you'd like
One file needs to be changed: resources/views/partials/MainNav.vue
Just add a basic styling black background is prefered.

I can work on it. I have some experience in navbar so I think I could handle this.

Resolved by #16


Accurately list listening services

The following commits enable interactsh to:

more consistently log

using gologger instead of a combination of gologger, fmt, and log

accurately list listening services

before this change, the server will always state that it is "Listening on DNS, SMTP and HTTP ports" even if those services have failed or more services are being used.
with the use of channels, each of the "ListenAndServe" goroutines can communicate to the main goroutine:

when they are starting
in case they fail or error, stop the server instead of failing silently

Done!
Sorry for the delay.


Can't delete access keys

Seems near-shell doesn't support deletion of the access keys.
It doesn't allow create keyless contracts.

We can add it. What is the RPC call that needs to happen?

It's DeleteKey action. As here: https://github.com/near/near-api-js/blob/9ffd92ed02cf4128df8428e7350662697a767b89/src/account.ts#L264

Seems like this is getting more important as we get to Stake Wars, think we should change the label of "enhancement"?

Clarifying from discussion:
near delete <PubKey> will allow you to use the full access key to delete any key.

fixed here: https://github.com/near/near-shell/pull/383
although I guess that's already appearing in "Linked pull requests" in the right sidebar. I'll use that from now on.


Implement adding conformers up to a maximum number of edges in training dataloader

Description
The intermediate layers' edgewise features usually account for most of the GPU memory usage of a batch, based on my previous experience trying to train SAKE. This PR implements a dynamically batching dataloader that computes the number of edges in the upcoming conformer and adds conformers to the batch until a maximum number of edges is reached.
Todos

[ ] Update tests

Questions

[ ] This dataloader has two parameters: the Euclidean cutoff with which to filter the edges and the maximum number of edges in this batch. At which level of abstraction should we supply these parameters?

Status

[ ] Ready to go

Codecov Report

Merging #46 (b1f35a6) into main (09cbfb6) will increase coverage by 0.10%.
The diff coverage is 84.21%.

Additional details and impacted files

is this PR ready for review?

A question I have is about how to integrate this into the PyTorch Lightning Dataloader API. I have currently implemented the maximum edge dataloader in a separate function here.
There are currently two issues with overriding the existing train_dataloader function:

This breaks current expectations about the shape of batched data. This is because I introduced a custom batch_sampler argument that behaves differently from the behavior when using the batch_size argument to DataLoader. The test dataset generation  depends on these expectations.
There are two more hyperparameters necessary to batch this way: the maximum number of edges and Euclidean cutoff we're using to filter the edges. The first issue needs to be resolved in order to determine how to supply these hyperparameters. (One option is to make them default to float('inf') when we want to use all edges, but we would have reimplement downstream tests to work with the shapes that this outputs.)

Can we hold off with this one for now and concentrate on implementing SAKE?


Generate predictable IPs for bind stateful set

Generate and manage predictable IPs for each member of the bind
statefulset and store in it's own predictable IPs config map.
The reason it needs to be it's own map is that we do not want to cause
minidns to restart if a scaling change occurs on mind - nor do we want
minidns scale changes to affect bind pods.

/hold

TODO: a few comments from beagles:

predictable IPs for bind’s cannot be tied to the node list, they are tied to replica count and should not reference nodes at all.
you need to avoid IP conflicts either by examining both config maps and extracting the used addresses before you start allocating IPs -OR- use two non-overlapping ranges, one for each  case. I’m not sure what is easier. You still of course have to query the existing IPs, but it would be per-range

/unhold

/retest


WebView/WebView2 memory leak

Describe the bug

WebView2 (and old WebView) exhibits a memory leak when creating and deleting the control in a loop. In my application, the user can change the content every (x) seconds and with a WebView/WebView2 control the user will get a memory leak.

Steps to reproduce the bug

Steps to reproduce the behavior:
GitHub repo

Start a loop / a timer var timer = new DispatcherTimer  		{  			Interval = TimeSpan.FromSeconds(1)  		};  		timer.Tick += Timer_Tick;  		timer.Start();
In a loop logic find the old WebView/WebView2 control in a DOM VisualTreeHelper.GetChildrenCount(parent);  ..... VisualTreeHelper.GetChild(parent, i) ...)
Remove the old WebView from the DOM (VisualTreeHelper.DisconnectChildrenRecursive(rootGrid);)
For a WebView call webViewToRemove.Navigate(new Uri("about:blank")); For a WebView2:  webViewToRemove.Close();
Add a new WebView/WebView2 control to the DOM rootGrid.Children.Add(newWebView);
Application crashes after 15 minutes.

Screenshots

Version Info

NuGet package version:

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2020 Update (19042)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

Additional context

I can reproduce, it crashes after 20 minutes.

Hi @tj-jyk, we're monitoring the issue that was opened in the WinUI repo. If the issue isn't able to be resolved with their advice we recommend that you open an Issue in the WebView2 repo

Hi @tj-jyk, thank you for opening the issue under the MicrosoftEdge organization.


feat: support macros 2.0

fix #45
This PR rename the former macro_definition (macro_rules!) to macro_rules, and reuse macro_definition for the new macro syntax.
Tests are copied from the RFC: https://github.com/rust-lang/rfcs/blob/master/text/1584-macros.md.

The syntax is not concretely defined, and it's likely subject to change - we can add it once there is a more proper specification

However, this syntax is already being used in rustc (for example in https://github.com/rust-lang/rust/blob/9afe7136958edaa403f0b0eb00f0353c125b7352/compiler/rustc_driver_impl/src/lib.rs). When treesit parses this file, it generates a bunch of errors, causing the entire file to fail to highlight correctly.


Add SSL support to WebSocketClient

Uses java 7 SSLSocketFactory when the scheme is wss.
Note this introduces a dependency on java 7.

Would this change not fit better as a new client, solely to demonstrate SSL?

Right now not happy with introducing a java 7 dependency

Closing this pull request due to the introduction of a java 7 dependency


the time provided by your paper including preprocess time / post-precess time or not?

How is your time metric,including pre/post process time? Have you calculate time from cpu---gpu---cpu?
This is a very important question,which determines your core idea "real-time" lies or not！！！
It matters a lot!!! But you don't mention it on your paper.
Could you please answer me?Thanks a lot.

We report time including network forward time, decode time(just like CenterNet), and our geometry computing time.

No cpu-gpu-cpu time is included. We believe this time is not reported in most methods with geometric constraint modules.


[lz4] Build error

Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+openssl
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[openssl]+Build+error&body=Copy+issue+body+from+D%3A%2Fvcpkg%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.mdpkg/installed/vcpkg/issue_body.md

Please report your issue according to the steps here: https://github.com/microsoft/vcpkg/issues/30604.

We don't have enough information to solve this issue, if you have any more information to help us solve this, please contact us again.


Update step.yml

Do not put single input in a new Category
Typo in input description

If you have a Jira issue for this PR, please add it to the name of the PR.

@trapacska Please check/merge the PR.


[SYSE-15]: Additional releng changes

Smoke tests, ci/tests: Adds the split test strategy used in gateway
Version package: Along with version package, there are changes in gateway and portal which changes the variables inside the package too. This adds another configuration item versionkeys that supports this.
analytics: Do ci push only on cgo matrix run.

This has been done in https://github.com/TykTechnologies/gromit/pull/219


Define labels in pattern instead of relying on Node/Relationship variables

Instead of relying on withoutLabels and withoutProperty, labels used in a Pattern should be defined in the pattern, instead of the Cypher.Node and Cypher.Relationship types.
There are 2 alternatives for achieving this:
Option 1: Using a chained command pattern, similar to current solution
new Cypher.Pattern({ variable: movie, labels: ["Movie"] })
    .related()
    .withDirection("left")
    .withLength("*")
    .to({ labels: ["Actor"] })
    .withProperties({
        name: new Cypher.Param("Keanu"),
    });

Option 1.5: Same as before but with labels in a method
new Cypher.Pattern(movie)
    .withLabels("Movie")
    .related()
    .withDirection("left")
    .withLength("*")
    .to()
    .withLabels(["Actor"])
    .withProperties({
        name: new Cypher.Param("Keanu"),
    });

Option 2: Use objects chained with related and to
new Cypher.Pattern({
    variable: movie,
    labels: ["Movie"],
})
    .related({
        direction: "left",
        length: "*",
    })
    .to({
        labels: ["Actor"],
        properties: {
            name: new Cypher.Param("Keanu"),
        },
    });

Regardless of the option to be implemented, the Cypher.Node and Cypher.Relationship types should be maintained as sugar syntax, but every possible pattern should be possible to produce with plain variables.
The following methods should be deprecated:

withoutLabels
withoutVariable
withoutType
(optionally) getVariables

Related Discussion: https://github.com/neo4j/cypher-builder/discussions/293

This also requires hasLabel and hasType methods to be available in variables


[Fastlane.swift] Fix string_callback type override

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Up until now, :string_callback was mapped to Any? instead of (String) -> Void when generating the Swift API.
Thus, there was no way to get a hook to callback functions when using Fastlane Swift, i.e. the sh action which takes an error_callback parameter.
Open issue: https://github.com/fastlane/fastlane/issues/15720
Description

The issue lied in the way the ConfigItem data_type was built, returning nil when data_type is of kind Symbol.
Fixing the above issue, as well as adding the Swift @escaping solved the issue and I was able to test using:
sh(command: "exit 1", errorCallback: { fatalError($0) })

Testing Steps

sh(command: "exit 1", errorCallback: { fatalError($0) })

Known Issues
sh(command: "exit 1", errorCallback: { println(message: $0) })

Will make the runner get stuck.

If you have any idea what might cause the SwiftRunner to get stuck when calling an action from the errorCallback like so:
sh(command: "exit 1", errorCallback: { println(message: $0) })

Please let me know, I'd be happy to fix it as well! 👍

No laptop for me to debug for this week, but a thought: if println is being calling and then the runner is stuck, I think the ruby fastlane process died and never sent a signal that it did. It’s been a while since I built it, but maybe the pipe broke and the runner doesn’t know it so the next command is just sitting there waiting for a response that will never come. Fatal error works because it kills the swift runner. So I think maybe sending a command over a broken connection needs work. Exit 1 might be a corner case.

No laptop for me to debug for this week, but a thought: if println is being calling and then the runner is stuck, I think the ruby fastlane process died and never sent a signal that it did. It’s been a while since I built it, but maybe the pipe broke and the runner doesn’t know it so the next command is just sitting there waiting for a response that will never come. Fatal error works because it kills the swift runner. So I think maybe sending a command over a broken connection needs work. Exit 1 might be a corner case.

Tried to do some more testing, here are the verbose logs:
DEBUG [2019-12-07 14:57:16.42]: received command:#<Fastlane::ActionCommand:0x00007fd3c2a01188 @method_name="sh", @class_name=nil, @command_id="", @args=[named argument: command, value: ls -2, type: , named argument: log, value: true, type: , named argument: error_callback, value: ignored_for_closure, type: string_closure]>
INFO [2019-12-07 14:57:16.42]: -------------------
INFO [2019-12-07 14:57:16.42]: --- Step: ls -2 ---
INFO [2019-12-07 14:57:16.42]: -------------------
INFO [2019-12-07 14:57:16.42]: $ ls -2
INFO [2019-12-07 14:57:16.43]: ▸ ls: illegal option -- 2
INFO [2019-12-07 14:57:16.43]: ▸ usage: ls [-@ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1%] [file ...]
ERROR [2019-12-07 14:57:16.43]: Exit status of command 'ls -2' was 1 instead of 0.
ls: illegal option -- 2
usage: ls [-@ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1%] [file ...]

DEBUG [2019-12-07 14:57:16.43]: sending {"payload":{"status":"ready_for_next","return_object":"ls: illegal option -- 2\nusage: ls [-@ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1%] [file ...]\n","closure_argument_value":"ls: illegal option -- 2\nusage: ls [-@ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1%] [file ...]\n"}}
DEBUG [2019-12-07 14:57:16.43]: received command:#<Fastlane::ActionCommand:0x00007fd3b455a3e0 @method_name="println", @class_name=nil, @command_id="", @args=[named argument: message, value: Hello World!, type: ]>
INFO [2019-12-07 14:57:16.43]: Hello World!
DEBUG [2019-12-07 14:57:16.43]: return_value_type is nil value:
DEBUG [2019-12-07 14:57:16.43]: sending {"payload":{"status":"ready_for_next","return_object":"","closure_argument_value":""}}

When executing action:
sh(command: "ls -2", errorCallback: { _ in
    println(message: "Hello World!")
})

So it seems the runner does get the response but just doesn't know when to exit.
Any idea where should I look into @taquitos?
I couldn't find a solution myself.

I'm running 2.137.0 and seeing some changes I don't recognize. It's bee a while, so maybe red herring, but last I remember, these error callbacks should be typed errorCallback: ((String) -> Void) = { _ in }, in the Fastlane.swift. Instead, I'm seeing errorCallback: Any? = nil and that's causing me problems because the argument that is getting passed to the json parser is a Function instead of a value and that's blowing up.
[FastlaneRunner.RubyCommand.Argument(name: "command", value: Optional("sh"), type: nil), FastlaneRunner.RubyCommand.Argument(name: "log", value: Optional(true), type: nil), FastlaneRunner.RubyCommand.Argument(name: "error_callback", value: Optional((Function)), type: nil)]

Note the value: Optional((Function))
Which is triggering:
FastlaneRunner[75084:5434033] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Invalid type in JSON write (__SwiftValue)'

That is to say, I think there is a problem with the Fastlane.swift function generator.

@taquitos Did you run the fastlane generate_swift_api lane before creating/updating your sample project? The Fastlane.swift file as the correct method signature for me 🙃
/**
 Runs a shell command

 - parameters:
   - command: Shell command to be executed
   - log: Determines whether fastlane should print out the executed command itself and output of the executed command. If command line option --troubleshoot is used, then it overrides this option to true
   - errorCallback: A callback invoked with the command output if there is a non-zero exit status

 - returns: Outputs the string and executes it. When running in tests, it returns the actual command instead of executing it

 Allows running an arbitrary shell command.
 Be aware of a specific behavior of `sh` action with regard to the working directory. For details, refer to [Advanced](https://docs.fastlane.tools/advanced/#directory-behavior).
*/
@discardableResult func sh(command: String,
                           log: Bool = true,
                           errorCallback: @escaping (String) -> Void = {_ in }) -> String {
  let command = RubyCommand(commandID: "", methodName: "sh", className: nil, args: [RubyCommand.Argument(name: "command", value: command),
                                                                                RubyCommand.Argument(name: "log", value: log),
                                                                                RubyCommand.Argument(name: "error_callback", value: errorCallback, type: .stringClosure)])
  return runner.executeCommand(command)
}

The issue
@taquitos @jhandguy The issue with the hanging starts happening here 👇
https://github.com/fastlane/fastlane/blob/master/fastlane/swift/Runner.swift#L120
This block is being execute on the same thread (???) which is okay if just standard Swift things are being called but becomes weird when another socket call is made for another action. What ends up happening is that we hang in this function 👇
https://github.com/fastlane/fastlane/blob/master/fastlane/swift/SocketClient.swift#L149-L159
It will eventually time out after the 1 hour default 👉  https://github.com/fastlane/fastlane/blob/master/fastlane/swift/SocketClient.swift#L36
So what are we going to do?!
It seems like we need to do some magical changes that allow for nesting of action calls. I'm have no great ideas of the top of my head. I assume that I would probably start experimenting with some sort of operation queue or another blocking process to send off this nested command on another thread or something. @taquitos any big 💡 ideas?

Wow, sounds rather complex @joshdholtz! 😮
My initial intention was to fix the bug with the sh action specifically, which does not fail when running using Fastlane Swift.
To try it out simply run:
sh(command: "exit 1")

and the exit status will still be 0 (success) instead of 1.
It probably has to do with the bridging and the Ruby action thinks there is an error callback while there isn't.
Maybe something to investigate first? 🤔

This shouldn’t have been closed!

Enter
[1591470759.092904]: sending: {"commandType" : "action", "command" : {"commandID" : "","methodName" : "println","args" : [{"value":"Hello World!","name":"message"}]}}
Enter

Enter: 7
Leave:  3
This is a dispatch group unbalanced entering-exiting, even if they're waiting, there're unbalanced calls to fix here...

@jhandguy I need you to sign with: @googlebot I consent. In #16577 16577


No debug adapter, can not send 'terminate'

Issue Type: Bug
Various issues after performing File|Save Workspace As...
To reproduce, use the following steps

Open a Workspace
With Debug UI docked, start
Two C# sessions
One Chrome client
Ensure debugging is working
Go to File|Save Workspace As...
Rename Workspace

Expected:
The running debug sessions should be shutdown.
Actual:

Chrome client is still running but entry in Debug dock is absent

Terminate button for C# session displays message
No debug adapter, can not send 'terminate'

Must now shutdown and restart VSCode

Note:

In previous releases of VSCode, changing the active workspace would terminate running sessions. I've come to rely on this behaviour -- has it changed?
I'm not sure if this is reproducible without docking the Debug UI, which has had its problems.

VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:08:29.692Z)
OS version: Darwin x64 19.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.29GB free)

Process Argv

Screen Reader
no

VM
0%

@dfdumaresq thanks for filling this issue. However let's try to destill it into smaller issues.
First of all docking the debug toolbar should have no effect on this.
Second can you reproduce this with vscode insiders https://code.visualstudio.com/insiders/
If yes, can you please try to find a minimal reproducable steps for one of these issues. Once we tackle that we can look into the rest. Thanks

@isidorn - thanks. I am unable to reproduce the issue with the vscode-insider. To clarify, after launching my debug sessions with the Debugger docked, I can switch workspaces and the running sessions are closed. No error message is displayed.
What to do now? I would like to switch to the insiders version to avoid this bug. However, it seems like a huge task to include all of my settings and extensions.
Is it possible keep my original vscode and switch update channels? Or is there a way to import my settings and extensions into the insiders version?

@dfdumaresq you can also wait for the next vscode stable release.
Or ideally - you can disable your extensions one by one since probably one of the extensoins is causing an issue.
Since there is nothing we can do to fix this - since it works in insiders I will close this.
You can easily import your settings and extensions using settings sync. We should hit stable release soon I think.

Sounds good, @isidorn. Unfortunately I was unable to reproduce with my original install this morning. At least I have options now. All the best.


Updated SDK and other gradle libs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM! thank you


Add a case-studies list page

Fixes #2418.

Closing this PR as the preview's borked. Will resubmit.


Labelled as obsolete with no direction on upgrade method

Field is marked obsolete with a hint on using a caml query but doesn't provide an example.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ecbd5f0e-7064-2666-fdf6-8e9211a94c89
Version Independent ID: 7b605908-29c1-8886-9d85-f579df3d9db1
Content: SPList.GetDistinctFieldValues(SPField, Object[,]) Method (Microsoft.SharePoint)
Content Source: sharepoint-server/xml/Microsoft.SharePoint/SPList.xml
Product: sharepoint
Technology: sdk
GitHub Login: @dotnet-bot
Microsoft Alias: o365devx

Here's a good reference documentation on that server side operation - https://docs.microsoft.com/en-us/sharepoint/troubleshoot/administration/use-spquery-to-query-a-list


Background Color Lost On Scrolling Fixed Columns

Great library, just started using this week, I have colored the background of a fixed column and it returns to white when scrolling.
I've added a fiddle here to demonstrate.

All you need to do is edit the css of .jexcel_freezed in JExcel.css!
Removing the background-color should do the trick.
On Fri, Mar 12, 2021, 4:53 AM auto-mate @.***> wrote:

Great library, just started using this week, I have colored the background
of a fixed column and it returns to white when scrolling.
I've added a fiddle here https://jsfiddle.net/ojy37mqz/ to demonstrate.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jspreadsheet/ce/issues/1338, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMOORAMI5ALZHBUYACZ4QZ3TDH6EVANCNFSM4ZCET5FA
.

@auto-mate it is important to keep the background for the frozen cells. That is because, if no background color is defined the stuck cells would be transparent showing the content of the cells behind bringing a bad experience. Said that you can overwrite the colors using CSS or using !important to overwrite the default white ones.


CI Pipeline Unzip Backend Artifact step failed

Runs normally then gives an error exit code without much indication as to what happened.
https://github.com/UniversityOfSaskatchewanCMPT371/term-project-2024-team-4/actions/runs/8088746225/job/22103431159?pr=65

Issue is due to unncessary package*.json files in root directory (rather than being in frontend/backend directories).

Reopened due to frequency of issue. Need to develop a patch that gives more knowledge on what specifically happened

Is there an update with this issue? Is this step still failing after the above #65 pull request?

Is there an update with this issue? Is this step still failing after the above #65 pull request?

This step was reopened to develop a patch, but it is sufficient enough to have the issue here documented. If it comes up again, this issue should signal the problem is related to an unnecessary package.json file in root directory.


[Support] TLS Error: tls-crypt unwrapping failed

In raising this issue, I confirm the following:

[x] I have read and understood the contributors guide.
[x] The issue I am reporting can be replicated.
[] The issue I am reporting is directly related to the pivpn installer script.
[x] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Describe the bug
I had this working way back but then I moved and over a year I did not try it. Since then I have upgraded my RPI to bullseye and now it does not work with the error in the title. I have tried to reinstall pivpn but the same issue happens (tried both normal and Testing branch).
Smartphone (please complete the following information):

OpenVPN
Device: Samsung S10
OS: Android 11

Additional context
pivpn debug snippet
::: Generating Debug Output
::::            PiVPN debug              ::::
=============================================
::::            Latest commit            ::::
Branch: test
Commit: 65ffa9afd262d68afd242823ccb0711c1a280fc8
Author: Orazio
Date: Thu Nov 18 14:28:35 2021 +0100
Summary: Spelling
=============================================
::::        Installation settings        ::::
PLAT=Raspbian
OSCN=bullseye
USING_UFW=0
IPv4dev=wlan0
dhcpReserv=1
IPv4addr=<IP_ADDRESS>/24
IPv4gw=<IP_ADDRESS>
install_user=pi
install_home=/home/pi
VPN=openvpn
pivpnPROTO=udp
pivpnPORT=1194
pivpnDNS1=<IP_ADDRESS>
pivpnDNS2=<IP_ADDRESS>
pivpnSEARCHDOMAIN=
pivpnHOST=REDACTED
TWO_POINT_FOUR=1
pivpnENCRYPT=256
USE_PREDEFINED_DH_PARAM=
INPUT_CHAIN_EDITED=0
FORWARD_CHAIN_EDITED=0
pivpnDEV=tun0
pivpnNET=<IP_ADDRESS>
subnetClass=24
ALLOWED_IPS=""
UNATTUPG=0
INSTALLED_PACKAGES=(openvpn)
HELP_SHOWN=1
=============================================
::::  Server configuration shown below   ::::
dev tun
proto udp
port 1194
ca /etc/openvpn/easy-rsa/pki/ca.crt
cert /etc/openvpn/easy-rsa/pki/issued/lab_d334b775-ed99-492a-8ad4-f94ace60641b.crt
key /etc/openvpn/easy-rsa/pki/private/lab_d334b775-ed99-492a-8ad4-f94ace60641b.key
dh none
ecdh-curve prime256v1
topology subnet
server <IP_ADDRESS> <IP_ADDRESS>
# Set your primary domain name server address for clients
push "dhcp-option DNS <IP_ADDRESS>"
push "dhcp-option DNS <IP_ADDRESS>"
# Prevent DNS leaks on Windows
push "block-outside-dns"
# Override the Client default gateway by using <IP_ADDRESS>/1 and
# <IP_ADDRESS>/1 rather than <IP_ADDRESS>/0. This has the benefit of
# overriding but not wiping out the original default gateway.
push "redirect-gateway def1"
client-to-client
client-config-dir /etc/openvpn/ccd
keepalive 15 120
remote-cert-tls client
tls-version-min 1.2
tls-crypt /etc/openvpn/easy-rsa/pki/ta.key
cipher AES-256-CBC
auth SHA256
user openvpn
group openvpn
persist-key
persist-tun
crl-verify /etc/openvpn/crl.pem
status /var/log/openvpn-status.log 20
status-version 3
syslog
verb 3
#DuplicateCNs allow access control on a less-granular, per user basis.
#Remove # if you will manage access by user instead of device.
#duplicate-cn
# Generated for use by PiVPN.io
=============================================
::::  Client template file shown below   ::::
client
dev tun
proto udp
remote REDACTED 1194
resolv-retry infinite
nobind
remote-cert-tls server
tls-version-min 1.2
verify-x509-name lab_d334b775-ed99-492a-8ad4-f94ace60641b name
cipher AES-256-CBC
auth SHA256
auth-nocache
verb 3
=============================================
::::    Recursive list of files in       ::::
::: /etc/openvpn/easy-rsa/pki shows below :::
/etc/openvpn/easy-rsa/pki/:
ca.crt
crl.pem
Default.txt
ecparams
index.txt
index.txt.attr
index.txt.attr.old
index.txt.old
issued
openssl-easyrsa.cnf
phone.ovpn
private
renewed
revoked
safessl-easyrsa.cnf
serial
serial.old
ta.key

/etc/openvpn/easy-rsa/pki/ecparams:
prime256v1.pem

/etc/openvpn/easy-rsa/pki/issued:
lab_d334b775-ed99-492a-8ad4-f94ace60641b.crt
phone.crt

/etc/openvpn/easy-rsa/pki/private:
ca.key
lab_d334b775-ed99-492a-8ad4-f94ace60641b.key
phone.key

/etc/openvpn/easy-rsa/pki/renewed:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/renewed/private_by_serial:

/etc/openvpn/easy-rsa/pki/renewed/reqs_by_serial:

/etc/openvpn/easy-rsa/pki/revoked:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/revoked/private_by_serial:

/etc/openvpn/easy-rsa/pki/revoked/reqs_by_serial:
=============================================
::::            Self check               ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
:: [OK] OpenVPN is running
:: [OK] OpenVPN is enabled (it will automatically start on reboot)
:: [OK] OpenVPN is listening on port 1194/udp
=============================================
:::: Having trouble connecting? Take a look at the FAQ:
:::: https://docs.pivpn.io/faq
=============================================
::::      Snippet of the server log      ::::
Nov 21 13:22:56 lab ovpn-server[573]: REDACTED:55437 Incoming Control Channel Encryption: Using 256 bit message hash 'SHA256' for HMAC authentication
Nov 21 13:22:56 lab ovpn-server[573]: REDACTED:55437 TLS: Initial packet from [AF_INET]REDACTED:55437, sid=b668c30c b17025df
Nov 21 13:22:56 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) 2021-11-21 13:22:54 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Nov 21 13:22:56 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: packet replay
Nov 21 13:22:56 lab ovpn-server[573]: REDACTED:55437 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:55437
Nov 21 13:22:57 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) 2021-11-21 13:22:54 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Nov 21 13:22:57 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: packet replay
Nov 21 13:22:57 lab ovpn-server[573]: REDACTED:55437 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:55437
Nov 21 13:22:58 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) 2021-11-21 13:22:54 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Nov 21 13:22:58 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: packet replay
Nov 21 13:22:58 lab ovpn-server[573]: REDACTED:55437 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:55437
Nov 21 13:22:59 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) 2021-11-21 13:22:54 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Nov 21 13:22:59 lab ovpn-server[573]: REDACTED:55437 tls-crypt unwrap error: packet replay
Nov 21 13:22:59 lab ovpn-server[573]: REDACTED:55437 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:55437
Nov 21 13:23:22 lab ovpn-server[573]: REDACTED:48572 TLS Error: TLS key negotiation failed to occur within 60 seconds (check your network connectivity)
Nov 21 13:23:22 lab ovpn-server[573]: REDACTED:48572 TLS Error: TLS handshake failed
Nov 21 13:23:22 lab ovpn-server[573]: REDACTED:48572 SIGUSR1[soft,tls-error] received, client-instance restarting
Nov 21 13:23:56 lab ovpn-server[573]: REDACTED:55437 TLS Error: TLS key negotiation failed to occur within 60 seconds (check your network connectivity)
Nov 21 13:23:56 lab ovpn-server[573]: REDACTED:55437 TLS Error: TLS handshake failed
Nov 21 13:23:56 lab ovpn-server[573]: REDACTED:55437 SIGUSR1[soft,tls-error] received, client-instance restarting
=============================================
::::            Debug complete           ::::
:::
::: Debug output completed above.
::: Copy saved to /tmp/debug.log
:::

I did not check the box if it sdirectly related to the script because Im not sure. Since a reinstall does the same I think that it is but I cannot answer with certainty.

Moving to discussions, this is connection related. please check other issues and discussions, you will find plenty of those your solution might be in one of those, if not then feel free to reply back.
Moving to discussions as per:
https://github.com/pivpn/pivpn/blob/master/README.md#general-guidelines

The Github issues page is not intended for general support usage or feature requests
PiVPN team may close any Discussion/Issue without any warning if they don't follow the Guidelines


Adding berks file

I'm guessing you figured it out already, but we are not using a Berksfile in favor of Chef's Policyfile.
Feel free to ask questions if you have any.  :smile:


Update notification controller git tag in upstream projects tracker

Update notification controller git tag to latest in upstream projects tracker.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


asdf install v 0.1.17 does not work

I tried to open the url showed in the output in browser and I got an 404, (url:https://github.com/vlang/v/archive/v0.1.17.tar.gz), only asdf install v ref:0.1.17 works properly.

Part of the issue may be this...a quote character at the beginning of the version and a '.z' at the end in asdf list-all

Sorry for having this plugin not updated. I just made an update which includes this fix.
This was because v changed the format of the release tag (before: vX.Y.Z, after: X.Y.Z), so now this plugin requires to have the "v" if the release tag has it.
(Actually, I dropped support for versions < 1.1.16 because of the ~/code directory problem, so no more "v"s...)


Sentry PHP Tracing/Performance support for WordPress

Hi,
This is a follow-up to https://github.com/getsentry/sentry-laravel/pull/358#issuecomment-669804042, with the goal of adding the new PHP Tracing/Performance support specifically for WordPress.
Thanks.

I've moved this issue to the WordPress plugin repository I think you meant to place it: stayallive/wp-sentry#68.


Adapt to new async handling of compilation calls

This PR adapts the %kata magic command to include changes to asynchronous handling of compilation calls (https://github.com/microsoft/iqsharp/pull/615), and fixes a small typo in Update-QDKVersion.ps1.

Hmm, I'm not sure where did my in-code comment go, the project that can be kept on existing beta rather than the new one is utilities/DumpUnitary/DumpUnitary.csproj - it's a separate tool that shouldn't be affected.

Looks good, I think you can keep one more project on the existing QDK version rather than update it.

Sounds good, I'll revert that file as well, then.

Which beta version is this - is it the one built from microsoft/iqsharp#615?

That's correct. The corresponding e2e build included an earlier version of this PR (without the version update) to check that everything builds correctly together.


DS2482 via Nanpy I2C

Hi All, I am working on a distributed temperature and other data monitoring system, eventually to be used for control as well.
I'm using python (2.7) + Nanpy on a regular debian (jessie) PC (which will get me to a "high-level" back end for web, reporting and other stuff), which is talking to nanpy firmware on an arduino UNO in the same enclosure. This part all seems to be working well - I can 'python i2c_scan.py' and see the expected devices on the arduino I2C bus.
Next step is talking to a DS2482-800 I2C slave to 1-wire master. This also /had/ been going pretty well - I can talk to the DS2482 to the extent that I can send control codes etc with no errors, and if I intentionally send an invalid code, I get an error (NACK) from the I2C bus as expected.
But I cannot read logically valid data back from the DS2482 corresponding to the datasheet - whatever I send I always get the same reads back from the 4 internal registers. (But again no error on I2C bus).
I know it sounds like the DS2482 is fried or incorrectly configured, except I have successfully used this arduino library on the same unchanged hardware to interact with it:
https://github.com/paeaetech/paeae/tree/master/Libraries/ds2482
and find devices on the 1-wire side of the DS2482, so I really believe the hardware is good.
I have tried slowing the nanpy Serial down to 9600 with identical results (no errors), and I am beginning to think I am misunderstanding the data returned by I2C_Master.request, or how to use it. Especially as python is not my 'first language'.
The DS2482 requires setting a register pointer, and then issuing a read  on the I2C bus, and the only other thing I am wondering about is whether there is anything in the way the nanpy firmware sends and then reads that might disrupt that sequence - I notice that stop=False is not exposed in I2C_Master for example.
Would really appreciate any tips on where to look next to debug this setup. I can post my code if it's helpful obviously.
Thanks

Anyone out there??

In case anyone else ends up here, I decided that duplicating the DS2482 lib through nanpy and its I2C wrapper was not a smart way to go, and so I wrote a new nanpy + nanpy-firmware extension to wrap the existing arduino C library: https://github.com/paeaetech/paeae/tree/master/Libraries/ds2482
This is working really well, and I am datalogging from 1-wire devices connected to a DS2482 from python on desktop PC via arduino.
At some point I will commit and issue a pull request. If any specific interest pm me, and I will try to get to it sooner.

Hi! I know that this topis is quite old but, are you still using Nanpy to read devices connected via I2C? I'm facing a lot of issues doing the same

Hi! Yes it is working well. We have a set up where a laptop (running our extended nanpy python code) scans via USB to the arduino and then I2C to the DS2482. We scan several 1-wire buses on the "external" side of the DS2482 every minute via a cron job, and write the results to a database, which can then be queried asynchronously by "higher level" software (we use cacti to make graphs). This has all been working with almost zero attention for the last year!


Learning rate scheduler

🚀 The feature, motivation and pitch
I don't see any option to set up a learning scheduler in the fine-tuning input arguments. Is there a way to implement it?
Alternatives
No response
Additional context
No response

Hi @NicoZenith currently there is only a learning rate decay scheduler implemented that you can configure through train_config.gamma. What options are you looking for?

@mreso this gamma factor is about decaying after each epoch, I'm looking for the scheduler that decays over iterations

@NicoZenith I see what you mean, I think it would be a great idea to provide some more flexibility with the learning rate schedule also to allow for warmup steps which we currently don't support IIRC.
My first thought was to implement it similar to custom_dataset with the option to point to a file with a function create an LRScheduler like StepLR and then a config to choose if we run step after an epoch or an iteration:
@dataclass
class LRScheduler:
   scheduler: str = "llama_recipes.utils.lr_schedulers.get_step_lr"
   # This is not good for customization.....
   step_on_epoch_end: bool = True
   step_on_iteration_end: bool = False
   def __post_init__(self):
      assert self.step_on_epoch_end != step_on_iteration_end, "Chose to either step after the epoch or after iteration ends, not both"

But then we don't have a great way to route parameters to the scheduler (like the gamma for step StepLR we have now) or to add custom parameters to a custom factory. Will try to give it some thoughts in the next days to come up with a design pattern that we can also reuse in other areas.


How to use "hanaOptions"?

I want to use a LOCALE Property(SQLDBC Connection Properties).
(Ref. https://help.sap.com/viewer/1efad1691c1f496b8b580064a6536c2d/LATEST/en-US/4fe9978ebac44f35b9369ef5a4a26f4c.html )
I want help.

I want to use a LOCALE Property(SQLDBC Connection Properties).
(Ref. https://help.sap.com/viewer/1efad1691c1f496b8b580064a6536c2d/LATEST/en-US/4fe9978ebac44f35b9369ef5a4a26f4c.html )
I want help.

Fortunately, I looked at other sqltools db addons and found a way. I salute you for your products.
{
"dialect": "SAPHana",
"port": 443,
"server": "hanadevserver.hana.prod-jp10.hanacloud.ondemand.com",
"name": "hdi-server-ko",
"database": "myhdischema",
"username": "myhdischema_username_RT",
"password": "mypassword_RT",
"hanaOptions":{"LOCALE":"ko"},
"isActive": true,
"isConnected": true,
"connectionTimeout": 60
}

Thanks for the compliments (you may also star us :-))


1.0.0 release for macos-arm64 is downloading as amd64

Tried downloading the arm64 binary for Mac, but it appears it is actually the same version as the amd64.
$ file geni-macos-arm64
geni-macos-arm64: Mach-O 64-bit executable x86_64
$ file geni-macos-amd64
geni-macos-amd64: Mach-O 64-bit executable x86_64
⦁⦁⦁ ls -la geni-macos-a*
-rw-r--r--@ 1 michael  staff  15261496 Mar  1 08:50 geni-macos-amd64
-rw-r--r--@ 1 michael  staff  15261464 Mar  1 08:50 geni-macos-arm64

Hey, thank you for reporting. I will have a look ☺

Hey,
Seems as the CI have ARM for building mac and rust compiler fallbacks to ARM target when building.
Can you use cargo ( cargo install geni) or Homebrew (brew install emilpriver/geni/geni) instead?

I am closing this as I added targets for mac builds. Please re-open if the issue still exist.

Not a homebrew user but will try installing via cargo.  Thanks for looking into this.

Do it :) It's way easier for you as a consumer of the cli with using cargo as it get compiled into the target fitting your machine


Follow up to selectOnFocus + multiple selection changes in useSelectableCollection

🐛 Bug Report
Followup work after https://github.com/adobe/react-spectrum/pull/1843 is merged/added:

implement similar behavior for mouse interactions, current pull handles keyboard interactions only (see below bugs for details)
With selectOnFocus I can tab into the list, but it won't select the item, shift+down arrow then selects "Cut" but "Copy" is left unselected. In order to select it, I'd need to tab in, then down arrow, then up arrow, then shift down arrow

Up for debate, perhaps this is desired behavior

clicking on a selected item (single selection) doesn't unselect the item

for multi-select it properly unselects the item

for multiselect w/ selectOnFocus:

clicking on a unselected item w/o shift doesn't unselect previously selected items

how to support multiselect on mobile? no modifier keys so do we switch modes away from selectOnFocus=true?

🧢 Your Company/Team
RSP
🕷 Tracking Issue (optional)

Needed for highlight functionality in components such as TableView

clicking on a selected item (single selection) doesn't unselect the item

I can't reproduce this without disallowEmpty. And of course with disallowEmpty it makes perfect sense.
will update this comment as i work the rest

With these new selection modes, there does not appear to be a way to select/deselect multiple non-contiguous items.
I tend to agree with the sentiment expressed in this Twitter thread: https://twitter.com/codingchaos/status/1383583716623065089

Also selection following focus is a pretty shitty pattern in general.
“Oh, you selected some items and want to keep them? WELL TOO BAD, SHOULDN’T HAVE USED THE ARROW KEY, THEN”

Why do we have to reproduce UI choices that OSX made twenty years ago, if they suck and exclude keyboard-only users from certain tasks?
Windows 10's File Explorer uses Ctrl+Alt+ArrowUp/ArrowDown to allow a user to navigate between items in the Explorer without losing selection.

I assume you're only talking about selectOnFocus.
Ctrl+Alt+Up seems reasonable, but I can't tell if that's what you're recommending doing or if you're upset with Windows as well.


fix WrapperExpandableListAdapter :

override (getChildType / getChildTypeCount) and (getGroupType /getGroupTypeCount) to make the group list and the child list could display different style layout

hello,firstly . i am very grateful for your work . it is really save me a lot of time .thanks . and during my using. i found this little bug .so i fix it . and i hope it will works and make this dependency better . finally . thank you again .^_^


Clicking provider-links does not work in VSCode

I understand that this is very much a VIP and experimental but wanted to report that a simple provider-links does not work when clicking in the editor. Using the icon at the top of the screen to show all matches in a dropdown works however.
        {
          "title": "🐘 $<table> table (PostgreSQL console)",
          "url": "https://example.com/postgresql?table=$<table|queryEscape>",
          "description": "View table schema and data...",
          "path": "**",
          "pattern": "(FROM|UPDATE|INSERT INTO|DELETE FROM|ALTER TABLE) (?<table>\\w+)"
        },

The example you provided works to show it in the editor but clicking it produces nothing from what i can see.

Clicking it should take you to the example.com URL. Is it that clicking it did not take you there, or that it's confusing because an example.com URL is not actually a helpful link for that? If the latter, then that should be resolved when we add some more non-example providers. We've got a bunch more in progress in the last few weeks and will soon be able to show off exclusively providers that are actually useful.

With the new version this seems to be fixed for me.


bower_components default directory

Hi,
In this article(https://www.polymer-project.org/0.5/docs/start/reusableelements.html) it is mentioned to run bower install command which will create a bower_components directory and put polymer library as a child sub directory.The screenshot shows the Polymer directory as a sibling of custom element definition file(test-element.html).
To get this project structure we have to add a .bowerc file to configure bower's default directory of installation.
Can you please recheck it and do the changes in the article?

Right, the default .bowerrc was removed from seed-element in https://github.com/PolymerElements/seed-element/commit/55e5e2c569f712a3b158fe37c6a768a6144d0096, as it was proving to be too much of a footgun for users unaware that dependencies would be installed outside of the folder (which is technically the correct place per the relative paths that components use to reference their dependencies, but potentially dangerous nonetheless).
In the meantime, the polyserve tool has emerged as one way to deal with the disconnect between where bower puts dependencies when running bower install from within a component vs. running bower install of a project bower.json that contains components.  It effectively allows you to put a components dependencies inside of it, but serve them as if they were peers to it.
I'll assign this to our docs editor to make sure our 1.0 docs reflect the change to seed-element and current best practices.

Closing, docs have been updated for seed-element.


Incorrect Reporting of event status when robot is sent to waypoint it already is at.

Bug report
Required information:

Operating system and version:

Ubuntu 20.04

OpenRMF installation type:

From source

OpenRMF version or commit hash
dbaae57b6a451236408843534ebb1ebd3805b96f
ROS distribution and version:
Galactic
ROS installation type:
Binaries

Description of the bug
Incorrect reporting when you ask a robot to move to whatever node it already is at. Status will always be "underway" via the GET /tasks API.
Steps to reproduce the bug

launch rmf_api_server
In a terminal, ros2 launch rmf_demos_gz hotel.launch.xml server_uri:=ws://localhost:8001/ headless:=0 use_sim_time:=true
Send a robot task via the tasks/robot_task endpoint (I'm not too sure if the json below is supposed to look like this, seems a bit funky)

{
    "type": "robot_task_request",
    "robot": "deliveryBot_1",
    "fleet": "deliveryBot",
    "request": {
        "category": "compose",
        "description": {
            "category": "compose",
            "phases": [
                {
                    "activity": {
                        "category": "sequence",
                        "description": {
                            "activities": [
                                {
                                    "category": "go_to_place",
                                    "description":  "deliverybot_charger"
                                }
                                ,{
                                    "category": "perform_action",
                                    "description": {
                                        "unix_millis_action_duration_estimate": 0,
                                        "category": "teleop",
                                        "description": {}
                                    }
                                }
                            ]
                        }
                    }
                }
            ]
        }
    }
}

Call GET /tasks. This is the response i get. Note that status under events will always be underway for the Go to place event even when completed is 1.

 {
    "booking": {
      "id": "c6a00b4e-3d3e-4fc6-b401-d0aae963c5a9",
      "unix_millis_earliest_start_time": 1504206,
      "priority": null,
      "labels": null
    },
    "category": "compose",
    "detail": {},
    "unix_millis_start_time": 1504605,
    "unix_millis_finish_time": 2198249,
    "original_estimate_millis": 0,
    "estimate_millis": 0,
    "assigned_to": {
      "group": "deliveryBot",
      "name": "deliveryBot_1"
    },
    "status": "underway",
    "dispatch": null,
    "phases": {
      "1": {
        "id": 1,
        "category": "Sequence",
        "detail": "[{\"category\":\"Go to [place:deliverybot_charger]\",\"detail\":\"Moving the robot from [place:deliverybot_charger] to [place:deliverybot_charger]\"},{\"category\":\"Perform action\",\"detail\":\"Performing action teleop at waypoint [[place:deliverybot_charger]]\"}]",
        "unix_millis_start_time": 1504605,
        "unix_millis_finish_time": null,
        "original_estimate_millis": 0,
        "estimate_millis": 0,
        "final_event_id": 0,
        "events": {
          "0": {
            "id": 0,
            "status": "underway",
            "name": "Sequence",
            "detail": {},
            "deps": [
              1,
              2
            ]
          },
          "1": {
            "id": 1,
            "status": "underway" <--!!,
            "name": "Go to [place:deliverybot_charger]",
            "detail": "Moving the robot from [place:deliverybot_charger] to [place:deliverybot_charger]",
            "deps": []
          },
          "2": {
            "id": 2,
            "status": "standby",
            "name": "Perform action",
            "detail": "Performing action teleop at waypoint [[place:deliverybot_charger]]",
            "deps": []
          }
        },
        "skip_requests": null
      }
    },
    "completed": [1],
    "active": 1,
    "pending": [],
    "interruptions": null,
    "cancellation": null,
    "killed": null
  }

Please do let me know if the JSON payload im posting to the tasks/robot_task endpoint is incorrect.

This should be fixed by 032c01e. To save some hastle, I'm lumping that commit into this broader PR: https://github.com/open-rmf/rmf_ros2/pull/186

Fixed by  #186


Depth Mode Session Limit

Can this page also include information  about what happens when Depth mode is set for a host pool and all session hosts have reached their maximum session limit, are new sessions allowed or are they they disallowed due to resource constraints ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac08640a-844c-d509-7af0-86abd6007916
Version Independent ID: 1d525109-52fd-31d8-de24-7db8f2ff084e
Content: Azure Virtual Desktop host pool load-balancing - Azure
Content Source: articles/virtual-desktop/host-pool-load-balancing.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks for the feedback. I have added this to the article and the change should be visible later today.
#please-close


Use runfiles from rules_python

Based on comments in https://github.com/bazelbuild/bazel/issues/18128
This does not solve some of the bzlmod strangeness, but it is a first step.

The checks that are failing are known.


Add integration tests that detect race condition

Describe the feature request
Race condition causes various kinds of program errors in Istio. This feature requests for adding Istio integration tests that detect race condition.
Describe alternatives you've considered
N.A.
Additional context
Race condition causes various kinds of program errors in Istio.

Is this an actual problem we hit?
This is not going to work for K8s based tests, and for native it will have limited value at the limit I think.

Yes, race condition is an actual problem we hit. There were ~100 commits in Istio repo for fixing bugs caused by race condition. Currently detecting race condition is only enabled in istio-integ-race-native-tests for integration tests running in native environment. The race condition detection is not enabled yet for tests that use Istio images in k8s environoment because Istio images are currently not built with -race flag due to CPU and memory overhead.

I was asking specifically about race conditions and the integration testing.
Unit tests are more likely to give us a much stronger signal about race conditions.

Revised the issue description to cover unit tests.

BTW, we already have racetests: https://testgrid.k8s.io/istio-presubmits#circleci-racetest

Thanks for the link!

Closing this in favor of https://github.com/istio/istio/issues/13282


JBPM-5030: Security Management N&N

@manstis Can you verify please?

@manstis Fixed.

+1 to merge.


if track["streamStartDate"] is None, strptime() will fail

I stumbled upon this problem on the title as part of checking out this playlist.
My thought was to change the line below and use Epoch time.
https://github.com/oskvr37/tiddl/blob/2ba6c9b9767da4eac7188029a592d1556eb94e4c/tiddl/utils.py#L81
with
       track["streamStartDate"] if track["streamStartDate"] is not None else "1970-01-01", "%Y-%m-%dT%H:%M:%S.000+0000"

Thanks for this issue!
Now, if streamStartDate is missing, it will be replaced with Epoch time


build!: bump targets

Description
Bumping targets
Additional context
According to this table https://kangax.github.io/compat-table/es2016plus/ it is mostly safe to go with ES2020
The lowest node version would be v14.6.0. This is also the requirement in package.json and in vitest and other "modern" packages.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

I think you forgot to change this one.
https://github.com/vitejs/vite/blob/c86329bd180b7dbfb22bc40e1f4bc21c536ed33f/packages/plugin-legacy/tsconfig.json#L6

I think you forgot to change this one.
https://github.com/vitejs/vite/blob/c86329bd180b7dbfb22bc40e1f4bc21c536ed33f/packages/plugin-legacy/tsconfig.json#L6

I did not forgot that, I left that over due to this is the legacy plugin

IIUC plugin-legacy enables bundled code to be able to run in legacy browsers, but the plugin itself does not run in legacy browsers (it requires node 14.16+). So I think it could be changed.

@patak-dev Could you approve this statement?


Add more examples to test hide_chapter_navigation

We need some more examples in order to be able to test the new guide property, hide_chapter_navigation.

remove hide_chapter_navigation from guide-with-step-navs and add a new example for this, guide-with-step-navs-and-hide-navigation
add example of a single page guide with step navs and hide_chapter_navigation

@leenagupte thanks - any idea why the tests are failing? Doesn't seem related to this PR, but I could be wrong?


O3 hole plot x-axis fix

fix O3 hole x-axis and remove O3 emission on summary table

@xylar ChemDyg has some changes. Will it be too late for the new E3SM unified?

@hsiangheleellnl, no, it's definitely not.  You can make a new release when you like and we can use that.  The conda-forge recipe hasn't been reviewed yet so we're also still waiting on that.

@tangq The new ozone hole plot is like this. I did not rerun the summary table. It is simplely to remove the line of O3 emission from the table.


Add Statistics Section With Examples

Add a statistics section to the cookbook!
Add an example showing how to calculate mean, median, and mode using the
Rust standard library.
Add a second example showing how to compute the standard deviation and zscore
of a set of data.
fixes #447
recreated after losing the repository reference for #470

Ready to pull in master and fix the links.

Thank you for this sorry for the delay!


Add MetadataOperations RBAC support for PUT APIs

Similar to #2128  introduce RBAC for PUT APIs
PATCH APIs provide jsonPatch, which makes it easier to map to MetadataOperations
For PUT APIs, we would need to compute the potential change to identify the MetadataOperation

@mithmatt for the short term we can check if the user is admin or bot. Almost all of the UI is using PATCH for user interactions . Where as any automated process such as ingestion we use PUTs

Closing as won't fix since PATCH support is sufficient for now.


Interactive component code examples cause flashing turquoise in mobile view

Summary of the bug
When interactive components examples are used on the site the component area flashes turquoise. After a little investigation this affects;

Breadcrumb
Card with interaction button
Checkbox
Data Entity
Radio Button
Switch

🪜 How to reproduce

Go to page: https://design.sis.gov.uk/components/switch#
Click on: the interactive Switch component
See the error

🧐 Expected behaviour
Should not flash turquoise when interacted with.
Mobile

OS: iOS
Browser: Safari

Closed as only Switch as an issue, which will be addressed bu the ticket to reduce the click area


perf(neo4j): improve neo4j query performance by using node labels

Checklist

[X] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
~[ ] Links to related issues (if applicable)~
[X] Tests for the changes have been added/updated (if applicable)
~[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.~
~[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub~

This PR introduces an optimization to the Neo4j querying process within our Datahub project. Previously, our Neo4j queries did not specify node labels during the match phase, which resulted in scanning all nodes in the database. This approach was inefficient, especially for large datasets. By integrating dynamic node labels into our match queries, we significantly improve query performance by leveraging Neo4j's ability to use indexes more effectively.
Node Label Integration: Modified the Neo4j queries wherever applicable and now, the query explicitly targets nodes with the specified label, reducing the search space and improving performance.
Performance: By applying node labels directly in our match clauses, the database engine can optimize node lookups using existing indexes, thus speeding up the query execution by reducing the number of nodes scanned.
Scalability: These improvements make our database queries more scalable, handling larger datasets more efficiently.
Maintainability: This change also enhances the clarity of our queries, making them more understandable at a glance, which benefits new contributors and maintainers alike.
You can find the screenshot attached comparing the profile result:
Profile WITHOUT NODELABEL query

Profile WITH NODELABEL query

@pashashaik-mms
Run './gradlew :metadata-io:spotlessApply' to fix these violations.

@RyanHolstien @david-leifker Could you please approve it as I had fixed the changes. It was a formatting issue and hence the build was failing and so are the unit-tests. I fixed it now and would need your approval.

Could you please approve it as I had fixed the changes. It was a formatting issue and hence the build was failing and so are the unit-tests. I fixed it now and would need your approval.

@pashashaik-mms , as mentions here
the below error is occurring because in testcases here, "sourceEntityFilter" is passed as null and because of that the variable "srcNodeLabel" in method "findRelatedEntities" is not setting having a default value of blank, which results in the below query which is not correct.
MATCH (src: )-[r:DownstreamOf ]-(dest ) WHERE left(type(r), 2)<>'r_'  RETURN dest, type(r) SKIP $offset LIMIT $count"
Please also handle the case where variable "sourceEntityFilter" in method "findRelatedEntities" can be null or empty
metadata-io > nonsearch > com.linkedin.metadata.graph.dgraph.DgraphGraphServiceTest > testFindRelatedEntitiesDestinationType[11](dataset, [HasOwner], {or=[], direction=UNDIRECTED}, [RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset1,PROD), via=null), RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset2,PROD), via=null), RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset3,PROD), via=null), RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset4,PROD), via=null)]) STANDARD_ERROR     org.neo4j.bolt.protocol.common.fsm.error.TransactionStateTransitionException: Invalid input ')': expected "%", "(" or an identifier (line 1, column 13 (offset: 12))     "MATCH (src: )-[r:DownstreamOf ]-(dest ) WHERE left(type(r), 2)<>'r_'  RETURN dest, type(r) SKIP $offset LIMIT $count"

@pashashaik-mms , as mentions here
the below error is occurring because in testcases here, "sourceEntityFilter" is passed as null and because of that the variable "srcNodeLabel" in method "findRelatedEntities" is not setting having a default value of blank, which results in the below query which is not correct.
MATCH (src: )-[r:DownstreamOf ]-(dest ) WHERE left(type(r), 2)<>'r_' RETURN dest, type(r) SKIP $offset LIMIT $count"
Please also handle the case where variable "sourceEntityFilter" in method "findRelatedEntities" can be null or empty
metadata-io > nonsearch > com.linkedin.metadata.graph.dgraph.DgraphGraphServiceTest > testFindRelatedEntitiesDestinationType[11](dataset, [HasOwner], {or=[], direction=UNDIRECTED}, [RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset1,PROD), via=null), RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset2,PROD), via=null), RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset3,PROD), via=null), RelatedEntity(relationshipType=HasOwner, urn=urn:li:dataset:(urn:li:dataPlatform:type,SampleDataset4,PROD), via=null)]) STANDARD_ERROR org.neo4j.bolt.protocol.common.fsm.error.TransactionStateTransitionException: Invalid input ')': expected "%", "(" or an identifier (line 1, column 13 (offset: 12)) "MATCH (src: )-[r:DownstreamOf ]-(dest ) WHERE left(type(r), 2)<>'r_' RETURN dest, type(r) SKIP $offset LIMIT $count"

FIXED NOW

@deepgarg-visa fixed now. Could you please check and approve it. Its been waiting a while now.

@pashashaik-mms are all metadata-io testcase passed ?

Looks like the changes were added in a different PR, closing this one. Thanks!


Documentation is not available for users

Sphinx documentation is available in the docs directory but there is no link to actually view the documentation. The only way to view the documentation is to download the repository, install/activate a virtual environment with the necessary dependencies, build the docs on your local machine, then view the generated HTML files in your local web browser. The docs need to be built and hosted with Read The Docs so a link is available for users to view the documentation website. This is standard practice for Python packages and is expected for this package too.

What do you need to make this available?

@wigging I'm an admin of this repo. Can you guide me through the steps?

@wigging The automatic addition didn't work. I will try to manually add the project, following these steps:
https://docs.readthedocs.io/en/stable/intro/add-project.html#manually-add-your-project
Can you check if any modification is needed on this file to make it work on Flowcept?
https://github.com/ORNL/Zambeze/blob/main/.readthedocs.yaml
If not, I will just copy it and put it on Flowcept's repository.

I would add a .readthedocs.yaml to the repository before setting it up on Read The Docs website. The contents of the yaml file will be slightly different than the one used for zambeze. I can push up a branch with the changes later this week.

It's available at: https://flowcept.readthedocs.io/


build: add missing dependency

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Add a dependency on LLVMCore to satisfy the link dependency.  Upstream changes
to the Target structure have caused a missing definition:
Undefined symbols for architecture ...:
"llvm::DataLayout::~DataLayout()", referenced from:
clang::TargetInfo::~TargetInfo() in libclangBasic.a(TargetInfo.cpp.o)

@swift-ci Please smoke test

@tkremenek This is for master-next. swift-ci does not support it yet.

I tested this on master-next on my own machine. LGTM.


Handling overloaded functions?

Pydocstest does not seem to be able to handle @typing.overload-ed functions right now. According to Ruff, only the actual implementation should be endowed with a docstring:
https://docs.astral.sh/ruff/rules/overload-with-docstring/
Currently, pydoctest does not seem to be able to handle this case:
import typing

@typing.overload
def timestwo(x: int) -> int: ...

@typing.overload
def timestwo(x: float) -> float: ...

def timestwo(x):
    """blabla

    Parameters
    ----------
    x: int | float
        Input scalar

    Returns
    -------
    int | float
        x times two.
    """
    return 2 * x

$ pydoctest --parser numpy
-> /test.py::timestwo FAIL | Return type differ. Expected (from signature) <class 'inspect._empty'>, but got (in docs) int | float.
I think that given the tool logic, those multi-definition cases will be hard to handle. In the case it would be too difficult, I think being able to ignore checking for a specific docstring with a kind of # nopydoctest option would be acceptable for these rare occurences.
Thanks!

Thanks for posting this. Is it on purpose that the final implementation is untyped?
Does your linter/typechecker know the type of x and enforce the return type in the last implementation function?

Indeed, this pattern allows the typechecker to pick the signature that matches the arguments type in order to infer the correct return type :)


Drivers: add Speak Component for audio

Includes

Speaker Cyber RT Component -- speaker_component.h, speaker_component.cc
Driver for Respeaker -- respeaker.h, respeaker.cc
Dependency

portaudio19-dev

Docker: add apt-get install in install_drivers_deps.sh
ThirdParty & Tools: add link options

TODO:

add code to extract and transform orientation of audio
add header to AudioData
Use real sound to test

@Crysple give adequate namespace and correct scopes, as the other modules do.


ONNX Version of Models

Hi, thank you for sharing these models, the quality of the output is amazing! Is there any chance of an ONNX release?

Not sure if onnx inference would be slow, and it is very possible that we will publish updated ckpt (e.g. more language support)
If anyone is familiar with onnx and interested, welcome to pr

ONNX does not yet support ISTFT needed for Vocos. There are a couple of workarounds.
https://github.com/gemelo-ai/vocos/issues/38

Hi
For ONNX support we can use WaveNeXt which is based on Vocos but it does not use the istft component.
Unless the tokenizer is separated, exporting to ONNX will not be that useful. The whole point is to have a minimal inference-only package that does not require pytorch.

#214 @DakeQQ got a onnx version.
Will move to there with onnx discussion, closing this issue~


Add an option to skip ipv6 DNS queries (AAAA) to reduce DNS calls

Firefow set this parameter network.trr.early-AAAA to false.
This means for each normal name resolve, Firefox issues one HTTP request for A entries and another for AAAA entries. The responses come back separately and can come in any order. If the A records arrive first, Firefox will - as an optimization - continue and use those addresses without waiting for the second response.
So every dns call form Firefox becomes two queries for the upstream server and only one (the IPv4) will be used.
I created an option to silently drop the AAAA query and ask to the upstream server only the IPv4 resolution.

Hello,
Thank you for your contribution!
But I would like to say that this is a controversial change, and even though, you might need to make some changes before I can accept your contribution.
First, you implemented this feature as a server-side option, instead of a client-side option. This is what I am against. One of the reason I created this piece of software is that, my local ISP "cleverly" optimizes my DNS requests and drops the AAAA records. And more severely, my local ISP "more cleverly" redirects any DNS requests to their own cache server. So most responses come in within 3ms, but with AAAA and RRSIG truncated.
DoH is an attempt to provide authentic, non-tempered DNS experience for users. If you want to turn off AAAA, don't deploy it on the server, because it may affect thousands of innocent users without being notified. At least, please make it on client-only.
Second, a 400 response will generate a SERVFAIL error on my client implementation, or cause other implementations to simply treat this DoH server as down (e.g. Firefox, DNSCrypt) and fallback to other methods. At least, please make it an NXDOMAIN, instead of 400 or SERVFAIL.
Third, please don't turn this feature on in the default configuration file. As of 2018, there are 534 million users, or 15% out of Internet users, with IPv6 access. Please don't force your preference to be the default of others.
Forth, by utilizing HTTP/2, actually the A and AAAA requests are sent simultaneously to the server. Firefox's early-AAAA means to only use the "response" that comes back first, not eliminating AAAA totally. In fact, with an IPv6 access, my Firefox test setup connects to a website in 50% chance of IPv4 and 50% chance of IPv6 with this option. (And early-AAAA is against Happy Eyeballs protocol.) This piece of software cannot control the time when the downstream client (e.g. the browser) thinks they are enough, thus does not really achieve the optimization results as early-AAAA.
Fifth, on a dual-stack machine, Happy Eyeballs protocol is used, so if AAAA does not return in time, the connection should fall back to IPv4 in mo more than 300 ms. Happy Eyeballs is implemented in major browsers excluding Internet Explorer so you don't really need to worry about it.
Last, please separate your different changes in different changesets and only send me the ones that you want me to merge.
Again, thank you for your contribution, and please give me your answers or explanations below so we can discuss about it.

Hi,
let me explain my setup so you understand why I did this:
my FF is configured to use a doh-server which is statically compiled and dockerized and used just by me. I noticed when FF is using DOH it's sligthly slower due to the dns overhead, so I had a look on few ways to improved the resolution speed.
To answer to your questions:

my doh-server is basically a dns-proxy between my FF and google/other dns servers,  there aren't housands of innocent users but just my FF instance.
NXDOMAIN is definetely an improvement I can do :)
like point 1, it's a personal resolver instead of the common services like Cloudflare/Google, I'm fully aware IPv6 is the future but given the FF logic I just wanted to remove one additional query. The default can be reverted, no issues.
this PR it's a small improvement useful in my setup, which can be summarized in 'take control of your DOH server in FF'
given how many 3-party objects are loaded in an average website, the DNS query saving grows exponentially
admin stuff: I'll amend them (night time hacking..) if you think it's worth merging

Thank you for your explanation!
From your point of view, the real thing that slows you down is the double request from doh-server to <IP_ADDRESS> and <IP_ADDRESS>.
I often receive requests on adding features to doh-server or doh-client. However most of the time what they want is to manipulate DNS packets in a traditional manner (such as modifying some values).
Usually I suggest to use a software that is originally intended for DNS manipulation. Because they are more professional, more powerful, and most important, you always need one for other reasons (e.g. caching).
Here is an example dnsdist configuration file:
newServer({address="<IP_ADDRESS>"})
newServer({address="<IP_ADDRESS>"})
newServer({address="<IP_ADDRESS>"})
newServer({address="<IP_ADDRESS>"})

getPool(""):setCache(newPacketCache(10000))

addAction(QTypeRule(dnsdist.AAAA), RCodeAction(dnsdist.NXDOMAIN))

Would you accept the solution that you would need another software combined to achieve your requirements?
Thanks!

Thanks for the reply, of course I can use another tool to achieve this.
Let's close it if you think this functionality does not qualify as core improvement.
Cheers!

Thank you.
I appreciate your understanding!


readme: use SVG for GoDoc button

This has the advantage that on high DPI displays the button is not
blurry.

LGTM.

Coverage decreased (-0.7%) to 98.817% when pulling 58b012a1624f3736a2082373d882931df220b695 on ashishgandhi:master into 7b3b6140aefe29b32f779da1ea73510d3d315609 on sony:master.

LGTM.


Update issue templates with post-graduation checklist

Depends on https://github.com/openjs-foundation/cross-project-council/pull/386.

@ljharb, I shouldn't have merged those here, actually. Those changes should me made in https://github.com/openjs-foundation/cross-project-council/pull/386 first. Could you please suggest them there too?

Now that openjs-foundation/cross-project-council#386 has been landed, can we just land this?


FSM scaffold tool help does not work properly.

Subject of the issue
when executing autonomy scaffold fsm --help it outputs:
Error: Agent configuration file 'aea-config.yaml' not found in the current directory.
when executed inside an agent directory (hello world agent) it produces
autonomy scaffold fsm --help
Error: Cannot find connection: 'valory/abci:0.1.0:bafybeiaw3tzlg3rkvnn5fcufblktmfwngmxugn4yo7pyjp76zz6aqtqcay'
Your environment

OS: Ubuntu
Python version: 3.10.9
Package Version 0.6.0

Steps to reproduce
See above
Expected behaviour
Help message should be displayed unconditionally.
Actual behaviour
See above

When running the command outside of an aea project you need to use -tlr flag, eg
autonomy scaffold -tlr fsm --help

Sorry but I am not satisfied with the solution.
IMO, as an user, I do not expect to use a specific flag to see a help message. Whenever we include a "--help" flag in a command, it should not start doing any operation (as it seems it is doing above, because it does not find the .yaml file); it should simply print the help message with the available parameters. How can the user know otherwise what is the flag required to display the --help message? This should apply not only to this but to all commands in the framework.
Of course, my complain can be overridden by @dagacha or @DavidMinarsch and they can close this ticket if the solution proposed above satisfies them.

i have fallen foul of this muoltiple times, and very odd that this help is shown on the main cli group

The standard behaviour of --help is to display information on options related to the command being run. In particular, it should not return any error.


[AutoPR eventgrid/data-plane] Add new Event Grid event type for SignalR Service

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5913

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/3039


Compilation of druid-shell fails on windows

Hi,
I wanted to give druid a try, but I'm unable to compile druid for windows.
This is the error I get:
Compiling druid-shell v0.4.0
error[E0308]: mismatched types
 --> C:\Users\Zwolin\.cargo\registry\src\github.com-1ecc6299db9ec823\druid-shell-0.4.0\src\platform\windows\window.rs:1007:48
     |
1007 |         SetWindowLongPtrW(hwnd, GWLP_USERDATA, wndproc_ptr as LONG_PTR);
     |                                                ^^^^^^^^^^^^^^^^^^^^^^^ expected i32, found isize

And the toolchain I use:
stable-i686-pc-windows-msvc
rustc 1.40.0 (73528e339 2019-12-16)

Any special reason you're using a 32 bit target? It might not be too hard to fix this, but it's not been a priority.