Linking against multiple static libraries that use cxx

In my C++ project I have two rust crates that export a C++ API using cxx.
That setup ends in a bunch of linking errors like this:
/usr/bin/ld: libangelfish_readability.a(cxx-546393ec83734d88.cxx.77528ncj-cgu.12.rcgu.o): in function `cxxbridge1$exception':
/home/jbb/.cargo/registry/src/github.com-1ecc6299db9ec823/cxx-1.0.49/src/symbols/exception.rs:6: multiple definition of `cxxbridge1$exception'; libangelfish_adblock.a(cxx-506fb85a29953a06.cxx.6ziszbha-cgu.12.rcgu.o):/home/jbb/.cargo/registry/src/github.com-1ecc6299db9ec823/cxx-1.0.49/src/symbols/exception.rs:6: first defined here
/usr/bin/ld: libangelfish_readability.a(cxx-546393ec83734d88.cxx.77528ncj-cgu.12.rcgu.o): in function `cxxbridge1$str$from':
/home/jbb/.cargo/registry/src/github.com-1ecc6299db9ec823/cxx-1.0.49/src/symbols/rust_str.rs:18: multiple definition of `cxxbridge1$str$from'; libangelfish_adblock.a(cxx-506fb85a29953a06.cxx.6ziszbha-cgu.12.rcgu.o):/home/jbb/.cargo/registry/src/github.com-1ecc6299db9ec823/cxx-1.0.49/src/symbols/rust_str.rs:18: first defined here

Can I do anything about it apart from moving everything into one crate, or is this a general limitation?

What's the status on this? Any clue if it's a limitation or if some method is available to make that work?

According to https://cxx.rs/build/other.html (source: @adetaylor in #345):

you first need to use rustc and/or cargo to generate a single Rust staticlib target and pass that into your foreign linker invocation.

If you need to link multiple Rust subsystems, you will need to generate a single staticlib perhaps using lots of extern crate statements to include multiple Rust rlibs. Multiple Rust staticlib files are likely to conflict.

That all seems consistent with what you've described. Rust does not expose any way for a C++ linker to link multiple Rust staticlibs. That part always has to be done by Rust's linker.
https://github.com/rust-lang/rust/issues/73632 has more extensive discussion of this situation.


Range is bigger than it should.

It seems that the range is bigger than it should.

        textLabel.enabledTypes = [.url]
        textLabel.URLColor = .white

        textLabel.configureLinkAttribute = { (type, attributes, isSelected) in
            var atts = attributes
            atts[NSAttributedString.Key.underlineStyle] = NSUnderlineStyle.single.rawValue
            return atts
        }

Solved by setting value to .urlMaximumLength, which leads me to think that
guard let maxLength = maximumLength, word.count > maxLength else {
    let range = maximumLength == nil ? match.range : (text as NSString).range(of: word)
    let element = ActiveElement.create(with: type, text: word)
    elements.append((range, element, type))
    continue
}

(ActiveBuilder.swift 37:42)  might be the problem.


[SECURITY-2394] Prevent XXE

Potential fix for XXE vulnerability in Performance Plugin (SECURITY-2394 / CVE-2021-21701)

@artem-fedorov When do you plan to make a release with that fix?

@daniel-beck can you file a release to get this security fix released?

I am not a maintainer, never have been.

I know, but you created a security fix related release in the past. So i thought you can do it again.

Any update on releasing this?

A JIRA issue has been logged for getting this fix released...   JENKINS-69026

+1
I am waiting for the release too. Please do it.

@basil this CVE was patched 8 months ago but people are still waiting for a release...
Is this something you can do please? Or notify someone who can?

I am not a maintainer of this plugin. See this page.

@artem-fedorov @manolo Hi Artem and Manuel, I saw you were maintainers on Jenkins.io. Could you please create a new release for this which includes the XXE fix? Thanks!

@a-st , thank you very much for talking care of the release that addreses the vulnerability.  However,  as I have documented on JENKINS-69026,  Jenkins is still warning that the vulnerability is still present.

@msymons You're welcome! There's a PR pending (https://github.com/jenkins-infra/update-center2/pull/683) which will take care of removing the warning.


Child batch

Workers will now accept a PERCHILD env variable. This will process multiple jobs in each child to reduce the amount of forks and drastically improve performance. Not setting the variable, or having a value of 1, is equivalent to the previous behaviors.
Did not write unit tests, but did document in comments and did adhere to code style used.
Deployed this in production in our (chartboost.com) high-traffic (1k jobs per second) environment and is running smoothly so far. Will report back tomorrow if anything is new.

I'd love to see this get pulled in to the new repo, resque/php-resque, if you wouldn't mind a rebase/rebuild? It would be good, IMO, to give users this option.

Given I wrote this code almost 7 years ago now, and I haven't written a line of PHP since 2014, I'll opt out from working on this further. There didn't seem to be much willingness to merge this anyways in the previous 7 years.

Fair enough. I'll create an issue on the new repo (where things are moving forward quite rapidly at the moment) to get this implemented by someone else. Thanks for the original code, and the reply to my inquiry!


update download-artifact and update-artifact from v3 to v4

@ortizjeronimo Have you checked the key differences on V4?
See Deprecation notice and key differences


MQTT prefix

Currently MQTT topics follow the VSS semantic, e.g. a topic is Vehicle/Speed, can we have a configurable prefix, i.e.
<myprefix>/Vehicle/Speed
@wenwenchenbosch

Closed by #24


Add Outdoor Smart Cam device

I got the new Outdoor Smart Cam (video doorbell) last week and it didn't show up in devices as it's a new device type, device_type.vdp. This PR adds the new device type to be used like the other cameras.

Coverage remained the same at 83.833% when pulling cb517a7c34d80a2062ce76561842ea47421aa05e on thedeany:master into 450edc05bbf3ca984b8a76eace7f6521cb40fe9c on MisterWil:master.

Coverage remained the same at 83.833% when pulling cb517a7c34d80a2062ce76561842ea47421aa05e on thedeany:master into 450edc05bbf3ca984b8a76eace7f6521cb40fe9c on MisterWil:master.

Released in v1.2.1


Kaggle kernels push results in Kernel push error: Notebook not found

I am using the CLI for the first time and maybe I am doing something wrong, but this seems to be an issue with the cli / api.
Could be related to #574.
Steps to reproduce the result:
kaggle kernels pull mthiede/api-test -m

output:
Source code and metadata downloaded to /home/fawkes/tmp/kaggle

After that I execute
kaggle kernels push

in /home/fawkes/tmp/kaggle, which gives me
Kernel push error: Notebook not found

Directory structure and metadata
ls
ls -l /home/fawkes/tmp/kaggle

total 8
-rw-r--r-- 1 fawkes fawkes 2024 May  1 19:28 api-test.ipynb
-rw-r--r-- 1 fawkes fawkes  375 May  1 19:28 kernel-metadata.json

cat
cat kernel-metadata.json

yields
{
  "id": "mthiede/api-test",
  "id_no": 56005324,
  "title": "api-test",
  "code_file": "api-test.ipynb",
  "language": "python",
  "kernel_type": "notebook",
  "is_private": false,
  "enable_gpu": false,
  "enable_tpu": false,
  "enable_internet": true,
  "keywords": [],
  "dataset_sources": [],
  "kernel_sources": [],
  "competition_sources": [],
  "model_sources": []
}

Environment
$ kaggle -v
Kaggle API 1.6.12

$ lsb_release -a
...
Description:    Debian GNU/Linux 12 (bookworm)
...

I was able to repro your problem. After going back to the notebook and creating a version this issue no longer occurs; the notebook was found once it had been versioned. Unfortunately, that led to another problem:

Kernel push error: Object reference not set to an instance of an object.

I created an issue in our internal tracker: http://b/343728043

The new error I discovered does not apply.
Please make a version of your notebook and try to push again, then let us know what happened. It worked for me.

Yes! It works after creating a version of the notebook, thank you!

@m-thiede if you have created the notebook from kaggle UI right? So the kaggle API is not going to recognize it. You need to create a version to be able to use this new notebook then you can edit it on kaggle UI as you need it.


Can updateUser or PUT/USER

Bug report
Hi i just notice that the PUT /USER  endpoint can be abused for adding putting data.

is it intended?

this can be abused by anyone just because everyone authenticated can access this endpoint and they can flood the  /PUT user endpoint to set user data.

Thanks for the report, while this conscience design decision makes Supabase powerful you make a good point that it puts some responsibility on users to have good RLS policies. I'll discuss with team to see if there are opportunities for better documentation / user education. I don't think that changing defaults is on the table though.


[BugFix] Fix the typo of aliyun cloud credential

Fixes #24805
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


redis connection event not working

Hi everyone!
I have these event listeners in order to log redis connection
const cluster = new Redis.Cluster(clusterEndpoints);

cluster.on('connect', function() {
    logger.info('Redis connection for cluster established');
});

cluster.on('error',function(err) {
    logger.error('Redis connection for cluster error: ' + err);
});

cluster.on('close', function(){
    logger.info('Redis connection for cluster closed');
});

In 3.x.x version with this code, console always prints
Redis connection for cluster established
In 4.0.x and 4.1.0
Redis connection for cluster established
Redis connection for cluster closed
Redis connection for cluster established
(a bit random, sometimes 2-3 times, sometimes just one)
In 4.2.0
Nothing is printed
It works fine although it doesn't print nothing

@acuervof Thank you for the details. I tested with 4.2.0 and "Redis connection for cluster established" is printed to the console. Could you enable the debug mode with 4.2.0 (DEBUG=ioredis:* node yourapp.js) and post the logs here?


The test discovery in kotlintest 3 should not get confused by global objects

Currently, a global class definition like internal object Resources seems to confuse kotlintest's test discovery and test are skipped. This should not be the case.

Fixed on master. I'll be releasing 3.0.4 and 3.1.0-rc2 later

3.0.4 released with this fix.


Change story card image div background color  and add new art.

Please change the background color on the story card image div to
background-color: #fffaeb;
Change should be on the homepage as well as on the end of story cards.
This will work better with the new art

@duquennoisa I updated the background color, but until images are transparent it won't show up. Let me know any issues with this going forward.

@alexfinnarn looks good in the staging environment !


Change configuration for Ubuntu server address

Bionic address shouldn't be:
http://cdimage.ubuntu.com/releases/release/ubuntu-server-amd64.iso
It should be:
http://cdimage.ubuntu.com/releases/18.04.3/release/ubuntu-18.04.3-server-amd64.iso

PR #49 merged, so should be fixed now!


<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

"react": "16.0.0-alpha.6",
"react-native": "0.43.4",
<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

duplicate of #305

Fix in 5.1.8

That did not fix it since the dependency is now on<EMAIL_ADDRESS>


Dynamic Image Serve View is failing

Issue Summary
When using the Dynamic image serve view, from the documentation (https://docs.wagtail.org/en/stable/advanced_topics/images/image_serve_view.html) the URL's are generated, but they cannot be accessed from a GET request.
Steps to Reproduce

Follow setup instructions here https://docs.wagtail.org/en/stable/advanced_topics/images/image_serve_view.html
Add an image = models.ForeignKey( get_image_model(), ...) field to the HomePage class. Make migrations and apply them.
Use the dynamic serve view in the template. Example code below:

{% extends "base.html" %}
{% load wagtailimages_tags %}

{% block content %}
    {% image_url page.image "fill-150x150" as this_works %}
    {{ this_works }}

    {# This does not work #}
    <img src="{{ this_works }}" alt="">
{% endblock content %}

Other details
Terminal output is:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/wsgiref/handlers.py", line 138, in run
    self.finish_response()
  File "/Users/kalobtaulien/Sites/tmp/svgtest/.venv/lib/python3.11/site-packages/django/core/servers/basehttp.py", line 173, in finish_response
    super().finish_response()
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/wsgiref/handlers.py", line 183, in finish_response
    for data in self.result:
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/wsgiref/util.py", line 24, in __next__
    data = self.filelike.read(self.blksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: read of closed file

What the browser outputs:

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details
Python: 3.11
Wagtail: 6.0.1
Django: 5.0.2
Working on this
Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.

Hey, I am new to wagtail and I would like to pick this issue. To my understanding this issue is occurring because of removing rendition.file.open("rb")  in this commit https://github.com/wagtail/wagtail/commit/8fcf6ec1e911644e4ef5113501221dc10b9f7f16 by @RealOrangeOne. So was there a reason for removing it?

This does indeed look like a bug. I'd removed it because in testing it hadn't made a difference. It seems in some cases, it does.
FileResponse looks like it assumes it's called with an open file handle, so we probably do need to explicitly open it beforehand. We should definitely find a way to automatically test for this, as it sounds like there might be some coverage issues with that view.

@RealOrangeOne thanks for the prompt reply. In addition to adding back rendition.file.open("rb") I would like to create a pr for writing more tests for the view as well. Can you please provide some guidance on the nature of the tests and what I should cover in the tests?

Glad to see you're interested in fixing this! I think the main thing will be working out in what case this causes issues currently, and attempting to write a test to address it. I suspect writing a test which causes the issue first is a good way to go, and then add the line back and confirm the test now passes.

Sure I will start working on it and create a pr. Please review it once I finish it and thanks for all the help till now.

Hey @RealOrangeOne, even though I can confirm that adding rendition.file.open("rb") back solves this issue, I have been unable to recreate it in the test (i.e. the test does not fail even if the file is closed. I have also looked into the storage backend angle however both the wagtail tests and the bakerydemo site are using FileSystemStorage, however the issue only occurs in the bakerydemo site. Does django treat test client and browser requests/responses differently? Or am I missing something?

@RealOrangeOne I had tried it with various backends, but this happens even with Wagtail's default setup after running wagtail start mysite and modifying the least amount of local code.
@LANCECORREIA Great job picking up this ticket and running with it, you're doing fantastic!

Until fix is merged if someone get the same error it could be fixed by changing Serve behavior to redirect ie  ServeView.as_view(action="redirect")


Introduce operand parameters in CompareIntegerPipe

Closes #1073

it exists, but i have no idea about the coverage


Hydration mismatch on BNavItemDropdown with v0.17

Describe the bug
Adding a BNavItemDropdown inside a BNavbarNav triggers a hydration mismatch on Nuxt.
Reproduction example is using the example from the documentation
Reproduction
https://stackblitz.com/edit/nuxt-starter-g6bzks?file=layouts%2Fdefault.vue
Used Package Manager
yarn
Validations

[X] Have tested with the latest version. This is still alpha version and sometime things change rapidly.
[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

@VividLemon if the :to in teleport is undefined, the disabled teleport won't render in ssr 😆

Thanks @rhelling
I can confirm that we no longer get hydration errors after applying your workaround.
Cheers


query manager generic tag mapping

Depends on

https://github.com/DataDog/integrations-core/pull/9795
https://github.com/DataDog/integrations-core/pull/9814
https://github.com/DataDog/integrations-core/pull/9817
https://github.com/DataDog/integrations-core/pull/9816
Still needs tests

Replaced by https://github.com/DataDog/integrations-core/pull/9853


feat(eslint-preset)!: migrate to flat config

Description
BREAKING CHANGE: ESLint 8.x and its new config system is now required
Read more about ESLint's new config system, flat config, here: https://eslint.org/blog/2022/08/new-config-system-part-1/
Test plan
n/a

@dzearing, @sverrejoh: Could you have a look at this and let me know if it looks alright?


No Tutorial on Getting Started?!?

Originally reported on Google Code with ID 115
It seems like most of the articles I've found on ELMAH are written by
people who somehow already knew how to use it.  Can anyone point to a
tutorial or quick start guide?   I don't need to know all the history of
HTTP, or why the sky is blue.  I just want an authoratitive-
sounding "here's how you do it".  The article by Scott Hanselman is hardly
a tutorial, it's just a "here's what I do because I already know how to
use it."   It's pretty bad there is not even a help file in the
downloads.  And it's a little embarassing to show this to my manager, when
he asks "Well where is the documentation?" and I have to say "Well, there
really is no documentation, it's open source!"

We're also considering using an ELMAH replacement called SmartInspect,
which is not free, but at least it doesn't leave you out in the cold.  It
has nice tutorials, etc.

Reported by charlesachapman on 2009-06-04 20:17:47

@atifaziz Would you be open to me moving the wiki pages from code.google.com to github?

I was talking about the wiki link here https://github.com/elmah/elmah/wiki.
I wonder if there's a way to change where that points to.
I wouldn't have known they were at https://elmah.github.io/a/ now.
On Sun, Aug 14, 2016 at 7:39 AM, Atif Aziz<EMAIL_ADDRESS>wrote:

@jeremysimmons https://github.com/jeremysimmons Thanks for your offer,
but the wiki pages have already been migrated
https://github.com/elmah/www/issues?utf8=✓&q=is%3Aissue is%3Aclosed wiki
and re-published on elmah.github.io.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elmah/Elmah/issues/115#issuecomment-239674100, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABV3pt_Lr2ceSWf-5TOiEzmcoSHoTgIZks5qfxqigaJpZM4JjydU
.

I was talking about the wiki link here https://github.com/elmah/elmah/wiki.

I see. Perhaps I should remove that for now to avoid confusion.

I wonder if there's a way to change where that points to.

Not to my knowledge.

Yes, Please remove the Wiki section from the Repository.
Additionally - the styles on https://elmah.github.io/help/ don't clearly
indicate that this fragment is a link.
ArticlesPermalink
The word appears styled like a Header, and not a hyperlink (same font size
as paragraph text, no underlink without hover or with) it's not obvious
that you should click it (unless you observe the cursor)
The hover affect with the permalink icon is a nice touch, but most people
aren't going to discover what is clickable by using their mouse to hover
over an element.
On Mon, Aug 15, 2016 at 1:50 AM, Atif Aziz<EMAIL_ADDRESS>wrote:

I was talking about the wiki link here https://github.com/elmah/elmah/wiki
.
I see. Perhaps I should remove that for now to avoid confusion.
I wonder if there's a way to change where that points to.
Not to my knowledge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elmah/Elmah/issues/115#issuecomment-239747097, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABV3pvx8lOrG53vKeO6rvn8S2SqDFDM7ks5qgBpagaJpZM4JjydU
.

@jeremysimmons Point taken and fixed in elmah/www@a8a38a289ff79b96f8f95ddb55f7df6d9ba5c608.

Please remove the Wiki section from the Repository.

Done

that looks great. thanks very much.
On Tue, Aug 16, 2016 at 12:23 AM, Atif Aziz<EMAIL_ADDRESS>wrote:

@jeremysimmons https://github.com/jeremysimmons Point taken and fixed
in elmah/www@a8a38a2
https://github.com/elmah/www/commit/a8a38a289ff79b96f8f95ddb55f7df6d9ba5c608
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elmah/Elmah/issues/115#issuecomment-240013906, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABV3pr_It9K7hlMS60m4nB7yHCWP-laeks5qgVd8gaJpZM4JjydU
.


Crash when connecting the socket

Since we upgraded to 4.0.8 version, we have noticed a crash in didReceive(event: WebSocketEvent) method after calling the connect() method
Below is the screenshot of the crash , it occurs shortly after calling socket's connect() method.

socket initialisation is as below:-
`        var request = URLRequest(url: URL(string: "wss://(sSocketServerHostName)")!)
request.timeoutInterval = 30
    let cookies = HTTPCookie.requestHeaderFields(with: HTTPCookieStorage.shared.cookies(for: URL(string: sApiServerHostName)!) ?? [])
    let keys = cookies.keys
    for key in keys{
        request.setValue(cookies[key], forHTTPHeaderField: key)
    }
    request.setValue("websocket", forHTTPHeaderField: "Upgrade")
    request.setValue("\(sSocketServerHostName)", forHTTPHeaderField: "Host")
    request.setValue("\(sApiServerHostName)", forHTTPHeaderField: "Origin")
    request.setValue("13", forHTTPHeaderField: "Sec-WebSocket-Version")
    request.setValue("Upgrade", forHTTPHeaderField: "connection")
    socket = WebSocket(request: request)
    socket?.delegate = self
    socket?.connect()`

Environment:

OS/Version: [e.g. iOS/17.0]
Starscream Version [e.g. 4.0.8]
Xcode version [e.g. 15.0.1]

Additional context

Add any other context about the problem here.

@daltoniam please help here.

Hello, did you manage to resolve the issue? I am encountering the same difficulty. Do you have any suggestions for a solution?

I am still facing the same issue. Do you have any suggestions for a solution?

I am still facing the same issue. Do you have any suggestions for a solution?

on Websocket.swift file  change this code
    public convenience init(request: URLRequest, certPinner: CertificatePinning? = FoundationSecurity(), compressionHandler: CompressionHandler? = nil, useCustomEngine: Bool = true) {
        if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *), !useCustomEngine {
            self.init(request: request, engine: NativeEngine())
        }
//        else if #available(macOS 10.14, iOS 12.0, watchOS 5.0, tvOS 12.0, *) {
//            self.init(request: request, engine: WSEngine(transport: TCPTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
//        }
        else {
            self.init(request: request, engine: WSEngine(transport: FoundationTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
        }
    }

I am still facing the same issue. Do you have any suggestions for a solution?

on Websocket.swift file change this code
    public convenience init(request: URLRequest, certPinner: CertificatePinning? = FoundationSecurity(), compressionHandler: CompressionHandler? = nil, useCustomEngine: Bool = true) {
        if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *), !useCustomEngine {
            self.init(request: request, engine: NativeEngine())
        }
//        else if #available(macOS 10.14, iOS 12.0, watchOS 5.0, tvOS 12.0, *) {
//            self.init(request: request, engine: WSEngine(transport: TCPTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
//        }
        else {
            self.init(request: request, engine: WSEngine(transport: FoundationTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
        }
    }

can you describe what will this code do ? i am also facing the crash.

I am still facing the same issue. Do you have any suggestions for a solution?

on Websocket.swift file change this code
    public convenience init(request: URLRequest, certPinner: CertificatePinning? = FoundationSecurity(), compressionHandler: CompressionHandler? = nil, useCustomEngine: Bool = true) {
        if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *), !useCustomEngine {
            self.init(request: request, engine: NativeEngine())
        }
//        else if #available(macOS 10.14, iOS 12.0, watchOS 5.0, tvOS 12.0, *) {
//            self.init(request: request, engine: WSEngine(transport: TCPTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
//        }
        else {
            self.init(request: request, engine: WSEngine(transport: FoundationTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
        }
    }

can you describe what will this code do ? i am also facing the crash.

this code for don't use network.framework to transport , iOS 13.0 - use foundation transport

I am still facing the same issue. Do you have any suggestions for a solution?

on Websocket.swift file change this code
    public convenience init(request: URLRequest, certPinner: CertificatePinning? = FoundationSecurity(), compressionHandler: CompressionHandler? = nil, useCustomEngine: Bool = true) {
        if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *), !useCustomEngine {
            self.init(request: request, engine: NativeEngine())
        }
//        else if #available(macOS 10.14, iOS 12.0, watchOS 5.0, tvOS 12.0, *) {
//            self.init(request: request, engine: WSEngine(transport: TCPTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
//        }
        else {
            self.init(request: request, engine: WSEngine(transport: FoundationTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
        }
    }

can you describe what will this code do ? i am also facing the crash. and i am only dependent on starScream i am not using native socket by apple.

I understand , your crash for the reconnect scene?
you can connect after disconnect 0.5 second

I am still facing the same issue. Do you have any suggestions for a solution?

on Websocket.swift file change this code
    public convenience init(request: URLRequest, certPinner: CertificatePinning? = FoundationSecurity(), compressionHandler: CompressionHandler? = nil, useCustomEngine: Bool = true) {
        if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *), !useCustomEngine {
            self.init(request: request, engine: NativeEngine())
        }
//        else if #available(macOS 10.14, iOS 12.0, watchOS 5.0, tvOS 12.0, *) {
//            self.init(request: request, engine: WSEngine(transport: TCPTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
//        }
        else {
            self.init(request: request, engine: WSEngine(transport: FoundationTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
        }
    }

can you describe what will this code do ? i am also facing the crash. and i am only dependent on starScream i am not using native socket by apple.

I understand , your crash for the reconnect scene?
you can connect after disconnect 0.5 second

The app is crashing randomly, even though it worked fine when I first ran it on two devices. I've been repeatedly closing and joining the meeting (it's an audio-video calling app), and within milliseconds, it keeps crashing. Sometimes, this happens after 4-5 attempts.

I am still facing the same issue. Do you have any suggestions for a solution?

on Websocket.swift file change this code
    public convenience init(request: URLRequest, certPinner: CertificatePinning? = FoundationSecurity(), compressionHandler: CompressionHandler? = nil, useCustomEngine: Bool = true) {
        if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *), !useCustomEngine {
            self.init(request: request, engine: NativeEngine())
        }
//        else if #available(macOS 10.14, iOS 12.0, watchOS 5.0, tvOS 12.0, *) {
//            self.init(request: request, engine: WSEngine(transport: TCPTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
//        }
        else {
            self.init(request: request, engine: WSEngine(transport: FoundationTransport(), certPinner: certPinner, compressionHandler: compressionHandler))
        }
    }

can you describe what will this code do ? i am also facing the crash. and i am only dependent on starScream i am not using native socket by apple.

I understand , your crash for the reconnect scene?
you can connect after disconnect 0.5 second

The app is crashing randomly, even though it worked fine when I first ran it on two devices. I've been repeatedly closing and joining the meeting (it's an audio-video calling app), and within milliseconds, it keeps crashing. Sometimes, this happens after 4-5 attempts. However, after a crash, if I try again within 3-4 seconds, it works fine. I have no idea how to resolve this issue or what exactly is happening

there has two problem

you should use  show your code (fountion transport)
delay some time(e.g. 0.5 or 1 second) reconnect websocket when disconnect  and you must be sure disconnected

there has two problem

you should use  show your code (fountion transport)
delay some time(e.g. 0.5 or 1 second) reconnect websocket when disconnect  and you must be sure disconnected

Sure i will try to do that.


Use GracefulStop instead of Stop for GRPC server

GRPC Stop doesn't wait for existing RPC to be finished totally,
but just until it opens a serveStreams go routine.
It cause serveStreams go routines to exists even after
reflector eventChan is closed, and can cause a race that would
result in panic: send on closed channel.
GracefulStop does wait for the connection to be totally closed,
existing RPCs would first finish, new ones will not be created
and just after all existing ones are closed, the channel would be
closed.
Fixes: #3575
Signed-off-by: Or Shoval<EMAIL_ADDRESS>None

/lgtm
/approve

/hold
Travis fails, i must remove the timer if its ok ?

I am removing the timer, because it cause unit-test to fail.
Adding the timer, with combination of even the current grpc Stop method fails as well, the unit-test of
pkg/virt-handler/vm_test.go doesn't actually wait for the server to stop, just if one enforce it, and it isn't build totally for it at the moment.
We can fix it on other PR, and then we can add the timer.
Meanwhile we would stable the CI, and learn more about the flow.

/hold
@oshoval I think your initial question somewhere, why the client can make the server stop by sending an error is legitimate. The listwatcher was redesigned without taking this change into account. I don't think it makes any sense to recreate the server. Reconnecting if we get an error on the application layer (not the rpc layer) will not solve anything. What we want is that virt-handler tries to fetch the state again.

/hold
@oshoval I think your initial question somewhere, why the client can make the server stop by sending an error is legitimate. The listwatcher was redesigned without taking this change into account. I don't think it makes any sense to recreate the server. Reconnecting if we get an error on the application layer (not the rpc layer) will not solve anything. What we want is that virt-handler tries to fetch the state again.

ok, but dont we want to split it to 2 issues / PRs ?
so the server stop would work fine for the tests / real code ?
or we want first to go back and fix the ERROR ?
totally into what you think, thanks

ok, but dont we want to split it to 2 issues / PRs ?
so the server stop would work fine for the tests / real code ?

We can continue, but I think now after longer consideration that we should not crash virt-handler if the graceful shutdown takes a long time. We should instead fall back to a forced stop. Not sure if we can then still somehow prevent the write to the closed channel in this case. Maybe we should just not close the channel.

@rmohr
what about CI flakiness ?
i think we should provide something that will fix it, (i.e just add the GracefulStop)
and fix the 2nd issue ?
or just to delete all the ERROR that cause server to die, and it would fix as well (unless we would see something interesting happens)

ok, but dont we want to split it to 2 issues / PRs ?
so the server stop would work fine for the tests / real code ?

We can continue, but I think now after longer consideration that we should not crash virt-handler if the graceful shutdown takes a long time. We should instead fall back to a forced stop. Not sure if we can then still somehow prevent the write to the closed channel in this case. Maybe we should just not close the channel.

The issue is that the unit-test having a wrong logic, i can also there try to just open one server and close it at the end, or even not close it,
and in the code just remove the closing of the channel, which was indeed one of the approaches i thought about as well

The issue is that the unit-test having a wrong logic, i can also there try to just open one server and close it at the end, or even not close it,

Anything which eventually stops the server and does not pile up go routines in the background is fine. It is ok if it takes some time until the server stops.

Updated
Thought on it again, i don't think we should omit closing of the channel, even if GracefulStop took time.
in such a rare case it means that our Handler code is having a bug (or is blocking if the buffer of 100 is met, for 10 seconds).
Closing the channel would mask such errors, or can cause unidentified behavior.

https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3713/pull-kubevirt-e2e-k8s-cnao-1.17/1278286508880564224
                "message": "Pod Update plugin resources failed due to requested number of devices unavailable for devices.kubevirt.io/tun. Requested: 1, Available: 0, which is unexpected.",

Usually its after virt-handler restart (at least for kvm), but i dont see restart, nor panic, will take deeper look soon

/hold
@oshoval I think your initial question somewhere, why the client can make the server stop by sending an error is legitimate. The listwatcher was redesigned without taking this change into account. I don't think it makes any sense to recreate the server. Reconnecting if we get an error on the application layer (not the rpc layer) will not solve anything. What we want is that virt-handler tries to fetch the state again.

wip https://github.com/kubevirt/kubevirt/pull/3730
thanks

/assign @AlonaKaplan

@oshoval great research work!

@oshoval great research work!

Thanks for the great teamwork on it, (actually all of the 4 reviewers here)

Simulated ERROR locally
{"component":"virt-handler","kind":"","level":"info","msg":"Received Domain Event of type ERROR","name":"","pos":"server.go:78","timestamp":"2020-07-02T13:41:34.356891Z","uid":""}
{"component":"virt-handler","level":"info","msg":"notify server GracefulStop complete","pos":"server.go:181","timestamp":"2020-07-02T13:41:34.357513Z"}

/lgtm

/hold cancel
As discussed above, does not solve the grpc server restart problematic triggered by application level client errors, but should at least improve the situation.

@oshoval: The following test failed, say /retest to rerun all failed tests:
Test name	Commit	Details	Rerun command
pull-kubevirt-e2e-kind-1.17-sriov	d9b426e link /test pull-kubevirt-e2e-kind-1.17-sriov

Hi @rmohr
If i am not wrong, tide rerun the batch, just because SRIOV was failing,
https://github.com/kubevirt/project-infra/blob/3de1e69c05b74e0288c06b665a8ee45fa64b8556/github/ci/prow/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml#L431
    always_run: true
    optional: true
    skip_report: false

is this the desired situation for this configuration, or we should merge
https://github.com/kubevirt/project-infra/pull/530
which change it to skip_repotr = true please?

@oshoval the sriov job just got restarted due to the retest bot, which does not differentiate between optional and required jobs. Tide does not care about that job. It got rerun because a 4-PR batch succeeded and was merged. Your job succeeded in a 3PR batch too, but since it lost against the other batch it has to rerun the tests (note that it did not leave the merge pool).

See for instance also this job: https://github.com/kubevirt/kubevirt/pull/3726. Non-required jobs are still marked as failed there but prow merged it.

Should we cherry-pick this PR to release-0.30 ?

/cherry-pick release-0.30

@oshoval would you mind doing a manual cherry pick? Seems like there is a merge conflict.

@oshoval would you mind doing a manual cherry pick? Seems like there is a merge conflict.

Sure, np
would we want to auto cherry-pick https://github.com/kubevirt/kubevirt/pull/3598
and then after its merged, we would be able to auto cherry-pick this one as well ?
Or to do those 2 manually, in one PR ?
Thanks


Errai - Widget onLoad() called twice

Hi Errai Team,
Im using Errai 4.0.0.Beta1 for gwt-material, and it seems that the Widget onLoad() method called twice in errai.
Here is the sample widget that we implement the onload process
https://github.com/GwtMaterialDesign/gwt-material-addins/blob/master/src/main/java/gwt/material/design/addins/client/richeditor/MaterialRichEditor.java
And here is the Injection declaration of the widget
    @Inject
    @DataField
    MaterialRichEditor rich;

Here is our issue on gwt-material-addins https://github.com/GwtMaterialDesign/gwt-material-demo-errai/issues/1

Hi @kevzlou7979,
Would you mind opening a JIRA issue for this? We don't use GitHub for issue tracking so this is less likely to get lost if you file a JIRA issue.
Cheers.


Add support for regex flags inside the Pattern

Change Summary
I've updated the extraction logic for Field.pattern to inplace flags for instances of Pattern. The previous logic directly accessed the pattern attribute, which ignores all passed flags.

Related issue number
fix #9568

Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[x] Unit tests for the changes exist
[x] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

please review

@Reskov,
Thanks for your work on this. Reviewing this PR made me think more about where we want compilation to happen, and I discovered that we're recompiling patterns in pydantic-core, which causes the flag drop. See:
https://github.com/pydantic/pydantic-core/blob/34d789fc510810eee507347d5e0897d8fb9045bb/src/validators/string.rs#L232-L244
I'm going to attempt a fix in pydantic-core for this, and will keep you updated! This hopefully removes the need for the manual flag application.

Awesome work on the tests, we'll definitely want to use those.

@sydney-runkle Yes, this is a good idea similar to proposal of the @mikeleppane at the issue #9568 comments

What should be inside the JSON schema? Will the JSON schema generator also respect these flags?
if we do this at the core, the flags will not be taken into account at the rust regex engine (which is default), right?

@Reskov,
Right, The flags won't be respected for rust regex.
Good question re JSON schema - I'm actually not sure yet. Great question though.

Updates:
https://github.com/pydantic/pydantic-core/pull/1318
https://github.com/pydantic/pydantic/pull/9591
I think we'll probably want to add custom logic to the json schema generation to apply those flags to the actual pattern, like you've indicated.
I still think we want to make this change in rust though, bc there's no reason for us to compile twice (which is what we were doing).

Going to close this given the above alternatives for now, but thank you very much for your work on this. Much appreciated!


Link functionality broken

It looks like the link functionality is broken, both for links defined in Mustache code and those defined in JSON.
First the Mustache links:
Test
``````

Clicking the link returns a 404 "The requested URL `/04-pages-00-homepage/04-pages-00-homepage.html` was not found on this server."

It looks like the path is missing the necessary `/patterns/`, which is included in the path when you open a pattern in a new window.

And for the JSON link, I'm including a link using the following:

"hero" : {
"url" : "link.pages-blog"
}

Clicking the link on the demo homepage returns a 404 "The requested URL `/patterns/04-pages-00-homepage/link.pages-blog` was not found on the server.

This looks like something different than the Mustache link, and I'm not sure what's exactly going on with it.

This should be fixed. Try running composer update pattern-lab/core to see if it pulls the latest changes. Had an issue with scope after I switched to getters and setters.

@dmolsen hmmmm no dice. Running composer update pattern-lab/core was successful, but the path is still omitting the /patterns/ at the beginning. However, it now appears to be happening for both Mustache and JSON links.

I swear this issue had something else in it. I must be seeing things. So I "fixed" the wrong thing apparently. I'll try again. Sorry.

Trying to test this out again. I updated a test project, which updated successfully:

I also did a clean install of a project, and yeah in both instances the /patterns/ part of the path is missing from the links. No need to apologize; let me know what else I can provide to help fix it!

Try yet again. I think I got so focused on the second problem you listed that I missed the "patterns/" issue. If it's now working please close the issue. Thanks :)

HOORAY! IT'S WORKING! Ah this is fantastic. Looking forward to diving into it, and I'll let you know if I hit any snags.


testing matrix

Putting this here so I don't lose it.
During development, I'm seeing some slight flake already particularly with Next 15 and Node 18. When I run npm run test back-to-back, the first one succeeds, and then the second one fails with:
npm run test

><EMAIL_ADDRESS>test
> node --test

ctx: {
  fixture: Fixture {
    nextMajor: '15',
    nodeMajor: '18',
    debug: false,
    imageName: 'hdb-next-integration-test-image-next-15-node-18',
    containerName: 'hdb-next-integration-test-container-next-15-node-18',
    ready: Promise {
      undefined,
      [Symbol(async_id_symbol)]: 77,
      [Symbol(trigger_async_id_symbol)]: 76
    }
  },
  rest: 'http://<IP_ADDRESS>:38081'
}
▶ Next.js v15 - Node.js v18
  ✖ should run base component (202.76925ms)
    TypeError [Error]: fetch failed
        at node:internal/deps/undici/undici:13392:13
        at async TestContext.<anonymous> (file:///Users/ethan/dev/harperdb/nextjs/test/next-15-node-18.test.js:17:20)
        at async Test.run (node:internal/test_runner/test:935:9)
        at async Promise.all (index 0)
        at async Suite.run (node:internal/test_runner/test:1320:7)
        at async startSubtestAfterBootstrap (node:internal/test_runner/harness:296:3) {
      [cause]: Error [SocketError]: other side closed
          at Socket.<anonymous> (node:internal/deps/undici/undici:6238:28)
          at Socket.emit (node:events:530:35)
          at endReadableNT (node:internal/streams/readable:1698:12)
          at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
        code: 'UND_ERR_SOCKET',
        socket: { localAddress: '<IP_ADDRESS>', localPort: 62968, remoteAddress: '<IP_ADDRESS>', remotePort: 38081, remoteFamily: 'IPv4', timeout: undefined, bytesWritten: 252, bytesRead: 0 }
      }
    }

✖ Next.js v15 - Node.js v18 (7151.077416ms)
▶ Next.js v15 - Node.js v20
  ✔ should run base component (20.143333ms)
✔ Next.js v15 - Node.js v20 (7520.460583ms)
▶ Next.js v15 - Node.js v22
  ✔ should run base component (20.061916ms)
✔ Next.js v15 - Node.js v22 (7639.554125ms)
ℹ tests 3
ℹ suites 3
ℹ pass 2
ℹ fail 1
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 8222.458958

✖ failing tests:

test at test/next-15-node-18.test.js:16:8
✖ should run base component (202.76925ms)
  TypeError [Error]: fetch failed
      at node:internal/deps/undici/undici:13392:13
      at async TestContext.<anonymous> (file:///Users/ethan/dev/harperdb/nextjs/test/next-15-node-18.test.js:17:20)
      at async Test.run (node:internal/test_runner/test:935:9)
      at async Promise.all (index 0)
      at async Suite.run (node:internal/test_runner/test:1320:7)
      at async startSubtestAfterBootstrap (node:internal/test_runner/harness:296:3) {
    [cause]: Error [SocketError]: other side closed
        at Socket.<anonymous> (node:internal/deps/undici/undici:6238:28)
        at Socket.emit (node:events:530:35)
        at endReadableNT (node:internal/streams/readable:1698:12)
        at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
      code: 'UND_ERR_SOCKET',
      socket: { localAddress: '<IP_ADDRESS>', localPort: 62968, remoteAddress: '<IP_ADDRESS>', remotePort: 38081, remoteFamily: 'IPv4', timeout: undefined, bytesWritten: 252, bytesRead: 0 }
    }
  }

I'm not really sure how to debug this. It only seems to trigger with Node 18, so maybe its a issue in Node? Next.js 15 should work fine with Node 18. And this really only happens when executed back-to-back quickly.


Changing speech style switches the language

From Määttä Sami:

I have just now updated my own branch. Now I’m using NVDA 2024.1 and the linked MathCAT version. I noticed a bug with this configuration:

Changing the speech mode between ClearSpeak and SimpleSpeak defaults the speech language to English without indication in the menu. As in the chosen language doesn’t change, it says it’s Finnish even though the synth outputs English. Changing the language in the menu to something else and then back to Finnish fixes this or re-opening NVDA.

I have the older version of NVDA (2023.x) and MathCAT on my work laptop and it doesn’t have that bug.

I tried to replicate it in MathCAT proper, but couldn't. I can replicate it (with Spanish) from the dialog.

In MathCAT, I tried changing the fallback default and the language changed. That's a pretty clear sign that the problem does actually reside in MathCAT proper.


Add Schedule name in Schedule.draw()

Summary
I added a title to the Schedule.draw() function. This is with regard to request #3752 .

Details and comments
The file changed was matplotlib.py . I manually selected a good font size(20px), similar to the one used by the plot_bloch_vector file's title. The y(0.92) position is also hard coded to stay at a good height above the plot.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good! Can you add fontsize setting to style class and get the value from it? Best font size may change depending on the figure size, which is configurable from the style setting.

style class

Sure thing. Will do that ASAP :).

Hello @AdithyaSireesh any update one changes requested by @nkanazawa1989?

bumping again.

Apologies for not responding. I have recently recovered from a bad flu. But, I should get back to working on it in a day or two.

I hope you are feeling better, thank you for updating 😄.

 All committers have signed the CLA.

Hey, @AdithyaSireesh! I hope you are still feeling well. Do you have time to round back on this?

Apologies for not replying. I think there would be a delay if I continued as I fell sick again. Have been trying to get some rest. Once again, I would like to apologise. Is it possible to ask someone else to complete the task?

Closing because this is fixed by https://github.com/Qiskit/qiskit-terra/pull/4122


Add 'threshold' parameter to pd.DataFrame.dropna

dask.DataFrame.dropna is missing the  "thresh"  parameter.
The dask documentation includes it in the explanation but it doesn't seem to have been implemented.
As an aside, the docs also mention the "subset" parameter. However, I believe passing this through may cause unexpected behavior with the underlying metadata, we may want to remove it from the documentation.

Thanks for the contribution @nmatare .  Looks simple enough.  Would you be willing to add a small test, or perhaps modify the existing test_dropna test in dask/dataframe/tests/test_dataframe.py to exercise this new parameter?
Also, sorry for the delay in responding to this.  It's a busy month!

Checking in @nmatare , are you still planning to work on this?

Added to the existing tests. Apologies on the extended delay getting back to this.

Thanks @nmatare !  This is in.


docs(api): add configtest command

To be merged after the new webpack-cli release.
Refers - https://github.com/webpack/webpack-cli/pull/2303

Let's convert it into draft, and set it ready for review when a new version webpack-cli including this feature is released.

Let's convert it into draft, and set it ready for review when a new version webpack-cli including this feature is released.

The new webpack-cli version is released 🚀

The new webpack-cli version is released 🚀

Also we have watch (alias --watch) and build commands (alias bundle, b, or without command)

Also we have watch (alias --watch) and build commands (alias bundle, b, or without command)

https://github.com/webpack/webpack.js.org/pull/4450

https://github.com/webpack/webpack.js.org/pull/4450


Segfault with Phalcon test

When running the following test with codeception:
public function test(UnitTester $I)
    {
        $container = new \Phalcon\Di\FactoryDefault();

        $request = $container->get('request');

        $server   = [
            'PHP_AUTH_USER' => 'myleft',
            'PHP_AUTH_PW'   => '123456'
        ];

        $expected =  [
            'username' => 'myleft', 'password' => '123456',
        ];

        $_SERVER = $server;

        $I->assertEquals(
            $expected,
            $request->getBasicAuth()
        );
    }

I get a segfault. This only happens when using codeception. If I run the code standalone it works fine.
PHP 7.3.1 (cli) (built: Feb  4 2019 12:34:31) ( NTS DEBUG )
Phalcon 4.0.0-rc.1
Stacktrace:
Core was generated by `php /usr/local/bin/codecept run tests/unit/Http/Request/AuthHeaderCest.php::test'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000055a49129e318 in ?? ()
(gdb) bt
#0  0x000055a49129e318 in ?? ()
#1  0x000055a49129e5c3 in ?? ()
#2  0x000055a4912a1279 in _emalloc ()
#3  0x000055a4912c7b0e in ?? ()
#4  0x000055a4912d37cb in zend_string_tolower_ex ()
#5  0x000055a4912c2073 in zend_lookup_class_ex ()
#6  0x000055a4912c30be in zend_fetch_class ()
#7  0x000055a4913397ff in ?? ()
#8  0x000055a491339b8e in ?? ()
#9  0x000055a4913462e8 in ?? ()
#10 0x000055a4913aee06 in execute_ex ()
#11 0x000055a4913b420e in zend_execute ()
#12 0x000055a4912d9b32 in zend_execute_scripts ()
#13 0x000055a49123f8ca in php_execute_script ()
#14 0x000055a4913b7056 in ?? ()
#15 0x000055a4913b81c0 in ?? ()
#16 0x00007fa8abe93ad6 in __libc_start_main () from /lib/ld-musl-x86_64.so.1
#17 0x0000000000000000 in ?? ()

I can't help with ??. I need debug symbols because I don't see neither Phalcon nor the Zephir symbols here. Is it a PHP bug?
Please follow this guide to understand how to generate the backtrace:

https://ma.ttias.be/generate-php-core-dumps-segfaults-php-fpm/
https://bugs.php.net/bugs-generating-backtrace.php
https://bugs.php.net/bugs-generating-backtrace-win32.php

I think I'm gonna close this one. I think this is a PHP bug.
After method_exists this occurs (Codeception\Test\Test.php).
foreach (array_reverse($this->hooks) as $hook) {
            if (method_exists($this, $hook.'End')) {
                $this->{$hook.'End'}($status, $time, $e);
            }
        }


Migration ANT tests -> MAVEN

Support also the creation of GratefulDeadConcerts database, now possible with:
ant clean install -Dorientdb.test.env=ci

Duplicated, sorry.


refactor: Using raylib instead SDL

Codecov Report

Merging #43 (1a8bd82) into main (436b85e) will increase coverage by 0.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   81.86%   82.60%   +0.73%
==========================================
  Files           4        4
  Lines         535      523      -12
  Branches       61       57       -4
==========================================
- Hits          438      432       -6
+ Misses         68       62       -6
  Partials       29       29

Impacted Files
Coverage Δ

src/bus.c
85.36% <ø> (-1.00%)
:arrow_down:

src/cpu.c
88.57% <ø> (-0.32%)
:arrow_down:

src/disassembler.c
60.90% <ø> (-1.04%)
:arrow_down:

src/opcodes.c
88.88% <100.00%> (+3.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436b85e...1a8bd82. Read the comment docs.


Write JSON schema for Aspire manifest format.

We will be using the $schema attribute to specify the version of the manifest format we are using. That means we need a JSON schema which documents the format. We also need to think about where we host it.

@mitchdenny what remains here after your PR #3684 ?

Just update the manifest writing code to emit $schema. I'll put up a PR. It's a nice to have.


Update docs with strong prescriptive recommendation on how to handle dynamic form behaviour with custom slot mappings

Proposed changes:

Completes ATO-442

Status (please check what you already did):

[ ] added some tests for the functionality
[X] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

LGTM


[Genie] fails to generate genie-compatible QNN binaries

Dear Qualcomm,
It fails to generate genie-compatible QNN binaries,  according to the guide (https://github.com/quic/ai-hub-models/tree/main/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama)
The error log is following.
 			FileNotFoundError: Unable to find the model source file, invalid path: /mnt/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama/export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.cpp
	There are the ONNX file : /export/intermediate_data/input_models/model_pp_0/Llama2_PromptProcessor_1_Quantized.aimet/Llama2_PromptProcessor_1_Quantized.onnx
	but, no CPP file : /export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.cpp

Error log

(qct_python310_VENV_root) taeyeon@taeyeon-PC:/hdd/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama$ python gen_ondevice_llama.py --hub-model-id mjqyxjlvm,mdno2o9gq,m7n1x51rq,m7qk5ozxq,mpn7y95jn,mknj6orxq,mrmdwz90q,mrmdwo8oq --output-dir ./export --tokenizer-zip-path ./tokenizer.zip --target-gen snapdragon-gen3 --target-os android
Using previously extracted model
Generating model lib for split-0 pp
./export/intermediate_data/input_data/data_pp_0.h5 export/intermediate_data/input_data/data_pp_0/_data
/opt/qcom/aistack/qairt/<IP_ADDRESS>728/bin/x86_64-linux-clang/qnn-onnx-converter --input_network ./export/intermediate_data/input_models/model_pp_0/Llama2_PromptProcessor_1_Quantized.aimet/Llama2_PromptProcessor_1_Quantized.onnx --output_path ./export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.cpp --no_simplification --quantization_overrides ./export/intermediate_data/input_models/model_pp_0/Llama2_PromptProcessor_1_Quantized.aimet/Llama2_PromptProcessor_1_Quantized.encodings --preserve_io layout input_ids attention_mask position_ids_cos position_ids_sin layers_7_add_out_0 past_key_0_out past_value_0_out past_key_1_out past_value_1_out past_key_2_out past_value_2_out past_key_3_out past_value_3_out past_key_4_out past_value_4_out past_key_5_out past_value_5_out past_key_6_out past_value_6_out past_key_7_out past_value_7_out --input_layout attention_mask NONTRIVIAL --input_layout position_ids_cos NONTRIVIAL --input_layout position_ids_sin NONTRIVIAL --input_list export/intermediate_data/input_data/data_pp_0/_data/input_list.txt --input_dim input_ids 1,1024 --input_dim attention_mask 1,1,1024,1024 --input_dim position_ids_cos 1,1,1024,64 --input_dim position_ids_sin 1,1,1024,64 --input_dtype input_ids int32 --input_dtype attention_mask float32 --input_dtype position_ids_cos float32 --input_dtype position_ids_sin float32 --bias_bitwidth 32 --weight_bw 8 --act_bitwidth 16
2024-09-12 11:44:39,286 - 235 - INFO - Processing user provided quantization encodings:
2024-09-12 11:48:16,882 - 240 - WARNING - WARNING_CAST_TYPE: Only numerical type cast is supported. The op: /model/model/layers.0/input_layernorm/Cast will be interpreted at conversion time
2024-09-12 11:48:16,892 - 240 - WARNING - WARNING_CAST_TYPE: Only numerical type cast is supported. The op: /model/model/layers.0/input_layernorm/Cast_1 will be interpreted at conversion time
2024-09-12 11:48:17,879 - 240 - WARNING - WARNING_CAST_TYPE: Only numerical type cast is supported. The op: /model/model/layers.0/self_attn/Cast will be interpreted at conversion time
,,,
2024-09-12 11:48:27,826 - 240 - WARNING - WARNING_CAST_TYPE: Only numerical type cast is supported. The op: /model/model/layers.7/post_attention_layernorm/Cast_1 will be interpreted at conversion time
2024-09-12 11:48:37,409 - 235 - INFO - Processed 7623 quantization encodings
2024-09-12 11:50:31,235 - 240 - WARNING - --weight_bw option is deprecated, use --weights_bitwidth.
IrQuantizer: Param Quantizer should be set to symmetric for 32 bit biases. Will ignore param quantizer option: tf for biases
    28.2ms [  INFO ] Inferences will run in sync mode
    28.9ms [  INFO ] Initializing logging in the backend. Callback: [0x710b47a96770], Log Level: [3]
    29.0ms [  INFO ] No BackendExtensions lib provided;initializing NetRunBackend Interface
     2.4ms [  INFO ] [QNN_CPU] CpuBackend creation start
     2.4ms [  INFO ] [QNN_CPU] CpuBackend creation end
    31.4ms [WARNING] Unable to find a device with NetRunDeviceKeyDefault in Library NetRunBackendLibKeyDefault
    31.4ms [WARNING] Profile Logger with name = defaultKey doesn't exist! Returning nullptr
     3.8ms [  INFO ] [QNN_CPU] QnnContext create start
     3.8ms [  INFO ] [QNN_CPU] QnnContext create end
    33.2ms [  INFO ] Entering QuantizeRuntimeApp flow
    33.2ms [WARNING] Profile Logger with name = defaultKey doesn't exist! Returning nullptr
     4.3ms [  INFO ] [QNN_CPU] CpuGraph creation start
     4.7ms [  INFO ] [QNN_CPU] CpuGraph creation end
     4.7ms [  INFO ] [QNN_CPU] QnnGraph create end
  5407.6ms [  INFO ] [QNN_CPU] QnnGraph finalize start
Generating model lib...
/opt/qcom/aistack/qairt/<IP_ADDRESS>728/bin/x86_64-linux-clang/qnn-model-lib-generator -c ./export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.cpp -b ./export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.bin -t x86_64-linux-clang -o ./export/intermediate_data/model_libs -l Llama2_PromptProcessor_1_Quantized
2024-09-12 11:52:16,354 -    INFO - qnn-model-lib-generator: Model cpp file path  : export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.cpp
2024-09-12 11:52:16,354 -    INFO - qnn-model-lib-generator: Model bin file path  : export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.bin
2024-09-12 11:52:16,354 -    INFO - qnn-model-lib-generator: Library target       : [['x86_64-linux-clang']]
2024-09-12 11:52:16,354 -    INFO - qnn-model-lib-generator: Library name         : Llama2_PromptProcessor_1_Quantized
2024-09-12 11:52:16,354 -    INFO - qnn-model-lib-generator: Output directory     : export/intermediate_data/model_libs
Traceback (most recent call last):
  File "/opt/qcom/aistack/qairt/<IP_ADDRESS>728/bin/x86_64-linux-clang/qnn-model-lib-generator", line 495, in <module>
    main()
  File "/opt/qcom/aistack/qairt/<IP_ADDRESS>728/bin/x86_64-linux-clang/qnn-model-lib-generator", line 489, in main
    result = generator.build_targets(config)
  File "/opt/qcom/aistack/qairt/<IP_ADDRESS>728/bin/x86_64-linux-clang/qnn-model-lib-generator", line 393, in build_targets
    self._normalize_config(config)
  File "/opt/qcom/aistack/qairt/<IP_ADDRESS>728/bin/x86_64-linux-clang/qnn-model-lib-generator", line 361, in _normalize_config
    raise FileNotFoundError(f'Unable to find the model source file, invalid path: {config.model_cpp.absolute()}')
FileNotFoundError: Unable to find the model source file, invalid path: /mnt/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama/export/intermediate_data/cpp_models/Llama2_PromptProcessor_1_Quantized.cpp
Traceback (most recent call last):
  File "/mnt/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama/gen_ondevice_llama.py", line 67, in <module>
    main()
  File "/mnt/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama/gen_ondevice_llama.py", line 61, in main
    generate_shared_bins(
  File "/mnt/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama/utils.py", line 546, in generate_shared_bins
    generate_lib(
  File "/mnt/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama/utils.py", line 276, in generate_lib
    raise RuntimeError("The QNN graph compiler did not produce the output file")
RuntimeError: The QNN graph compiler did not produce the output file
(qct_python310_VENV_root) taeyeon@taeyeon-PC:~/hdd/hdd/QCT_AI_Hub/ai-hub-models/qai_hub_models/models/llama_v2_7b_chat_quantized/gen_ondevice_llama$

Best regards,

Hi @taeyeonlee,
Something is happening that is causing the converter to abruptly exit before it has finished. I think the scripts should check for exit status before it tries to proceed, so we should fix that on our end. However, that will only make the failure reason more clear, it won't solve why it is failing.
The qnn-onnx-converter step should end with outputs like this:
2024-05-14 19:12:07,107 - 235 - INFO - Model CPP saved at: [...].cpp
2024-05-14 19:12:07,108 - 235 - INFO - Model BIN saved at: [...].bin
2024-05-14 19:12:07,136 - 235 - INFO - Conversion complete!

A few things to try:

Make sure you have enough space in the output folder. These are large models and running out of space would cause an abrupt failure.
Is it consistent? If you try again, perhaps that one time was a fluke?
Try copy-pasting and running the command yourself, as opposed to through the python process. If there are files that are only prepared temporarily in the script, you can breakpoint at the point where python would run it, but you run it yourself. You may need to activate your QNN environment. This will tell us the exit status. It may also give us some outputs that are suppressed when it runs as a python subprocess.

Let us know what that yields and we'll take it from there. Sorry again about this!

Hi @gustavla
It succeeds to generate genie-compatible QNN binaries on Ubuntu PC with 32 GB RAM and 40 GB Swap memory.
The generated genie-compatible QNN binaries are working well on S24 Ultra smartphone.
Could you share an sample app (QNN C++ API or GENIE C++ API) to run ?

Hi @taeyeonlee we are working on Genie C++ app and will release it soon

closing this issue as original question is resolved


Check for context.TODO() in functions that have a context.Context argument.

This adds a check for context.TODO() in functions that have a context.Context parameter and suggests using that instead.
I think that this would be a nice check to have especially now that the context package is going to be part of stdlib.
Relates to https://github.com/cockroachdb/cockroach/issues/1779.

/cc @tamird

:+1: on the idea. This is fragile in the face of other packages locally imported as "context" or "context" being imported under a different name.

@tamird Updated to correctly infer the package name alias for "context" and "golang.org/x/net/context" to avoid those issues.

Cool. @bradfitz

Yes? I've never touched golint.

Ah, apologies. @dsymonds seems to be the most active maintainer
On Aug 1, 2016 20:29, "Brad Fitzpatrick"<EMAIL_ADDRESS>wrote:

Yes? I've never touched golint.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/lint/pull/227#issuecomment-236753055, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdsPDHekVImp15gRfm2sjPbv67s1clbks5qbo-FgaJpZM4JZ7S6
.

I don't own this any more, but it's not the right place. This new check isn't a matter of style, but one of correctness, so it'd belong in govet, not golint.

@dsymonds: Who is the maintainer of golint now?

I agree with @dsymonds that this seems like a govet issue. Usage of context.TODO in a function that accepts a context.Context seems like issue of correctness, not style.
Can you file a issue on https://github.com/golang/go/issues for cmd/vet?

I'm going to close this PR since it's captured in golang/go#16742.
@d4l3k, I encourage you to submit a similar change to golang/go to vet or something.


Remove flag when banner bloc is broken by someting else than player

instead of reliing on break, player now need to place a bloc inside the banner


Update function signatures to conform to node 0.6.7

Published as 0.2.0

Thanks (on your holiday)!


Date and Time fragment do not use custom colorAccent

Hi,
I tried updating the library and now use the latest version, added support for version2 using setVersion method, added a custom color in my color.xml file for colorAccent, also set up custom values mdtp_accent_color and mdtp_accent_color_dark, used setAccentColor method, but none of these reflects the custom color i am wanting to use.
Please assist.
Thanks

I can't immediately reproduce this. setAccentColor should do the job.
Keep in mind that you need to give it an actual color, not a resource.
dpd.setAccentColor(Color.parseColor("#9C27B0"));

or if you have the color in a resource
dpd.setAccentColor(ContextCompat.getColor(getActivity, R.color.my_accent_color));


when applied on range input v-model directive use string as value type instead of number

Vue.js version
2.0.1
Reproduction Link
https://jsfiddle.net/dede89/4tquo6sx/
Steps to reproduce
Given a input range with a v-model directive.
Click on the input range to change the value.
What is Expected?
After updating the type of the value should be number.
What is actually happening?
The type of the value  is string.

By default, when the value go to data attribute, it goes as a string.
The range input already starts as a number because v-model is now the source of truth.
To solve this, just put v-model.number="value"
PS: Hey, you're brasilian! why didn't you asks that question for us first? is not a bug xD
http://www.vuejs-brasil.com.br/

Hi, thanks for filling this issue.
It may be surprising, but the javascript type of HTML input values, regardless of it's 'type=...' attribute, is string. This is browser behavior. https://jsfiddle.net/71ta9gsn/
(https://github.com/vuejs/vue/issues/1713#issuecomment-154776864)
To work around this, you can use .number modifier as @Halfeld suggested.

@fnlctrl This is incorrect. a type="number" input - will have a special property .valueAsNumber which should be used. Also date inputs has valueAsDate.
These are the correct native properties, as they consider the locale implicitly.

valueAsNumber is not supported by all the browsers we support. The input with type=date isn't supported by popular browsers like Safari either. You can however create your own input implementation that uses those values on input events 🙂  Cheers.

Those are part of the HTML5 spec, and I there's no real reason for supporting non-HTML5 browsers these days is it?
I mean a good practice would be to look forward and use polyfills for older browsers. This way Vue can conform to standards out of the box, by playing well with browser's locale etc.
But this would probably mean a new major version anyway as it's a change in behavior...

Just ran into this. I understand that this is by design from the perspective of Vue developers, but from the perspective of a user, it seems like this is bound to be confusing - who would ever want to use a slider input as a string?
I would think that having Vue implicitly use v-model.value for range inputs would lead to the least amount of surprise. Just wanted to cast my 2 cents in with @danielgindi .


docs(CONTRIBUTING.md): comitted was changed to committed

in CONTRIBUTING.md @ line:39 comitted was changed to committed

What:

Why:

How:

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          60     60
  Branches        9      9
=====================================
  Hits           60     60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27315c0...9c8e141. Read the comment docs.


Presets do not work properly if there is a playlist setup

With the changes made in previous issues, you can now define the number of presets.  However WLED has a feature called playlist which actually shows up as a preset, but it allows you to toggle between different presets.  For example, if you have 2 presets, and create a playlist, number 3 in your list of presets will be a playlist.  This playlist could alternate between presets 1-2 and have them play for 5 seconds and alternate to the next preset.
The issue here is I defined 3 presets in wled preset and 3 presets show up in HomeKit.  I created 2 presets and I created a playlist.  My playlist (which shows up in WLED as preset 3) alternates between preset 1 & 2 in WLED.  If I select Preset 1 in wled-preset from HomeKit, Preset 1 executes.  If I select Preset 2 in wled-preset from HomeKit, Preset 2 executes.  If I select Preset 3 in wled-preset, my playlist executes.  However once I execute Preset 3 in wled-preset, my wled lights will never stop playing that preset.  Selecting Preset 1 or Preset 2 in wled-preset does not work.  The Power button does work, but when I power the lights back on, they continue to run the playlist.
I am running WLED 0.13.0-b5 if that helps.

Investigated a bit, and it does not seem that the XML response from WLED contains any details regarding the preset being a playlist or not.
I need to reproduce this and see the behaviour. Based on the behaviour of the plugin, it might be possible from the setActiveIdentifier to recognize  if a preset is a playlist or not based on a pattern.

Is there any opportunity to treat the Playlist like a Preset (especially since it is in the same menu) and allow Wled-preset to select both a Preset and a Playlist?  Been setting up Christmas lights and the playlists allow your spectators watch through various animations.   Would be nice to automate this into HomeKit so you can turn all these on when it gets dark and shut off after a certain time.  It will probably work because of the current bug as long as you have it last selected, but it would be nice to give that control into HomeKit through the plugin.

I think this should shed some light on how to approach this. Here is the link to the JSON API call for playlists. I've included a sample response below.
{
  "playlist": {
    "ps": [26, 20, 18, 20],
    "dur": [30, 20, 10, 50],
    "transition": 0,
    "repeat": 10,
    "end": 21
  }
}


Cannot create custom actor moves via Create Item

In GitLab by @AwakenedGoat on Sep 24, 2021, 08:29
Summary
Created a new custom actor with basetype = 'character', a different set of stats to the character.stats, and a unique moveType.
Problem When attempting to create a move via the Create Item option (right menu), there's no custom actor move type to choose from the Type drop-down menu (contrast with the 'move' and 'npcMove' options). Consequently, after the move item is created, it isn't possible to choose the stats of the custom actor for the Roll field on the Details tab.
However, move items can be created for the custom actor by adding them directly via the custom actor sheet. Or, if a move item is created via Create Item, it is possible to drag it into the custom actor sheet (which defaults their move type to 'Other'), then select the custom moveType specified in the custom actor config (which is now visible).
Finally, if a custom actor move is created via the custom actor sheet and then dragged into the Items menu, it loses the 'Roll' and 'Move Type' values from the Details tab.
FWIW, the use case here is adapting the config to play a hack of the Rust Hulks PbtA game. The custom actor sheet is for spaceships, which have their own stats, moves, attributes, etc.
Cheers!
Labels (do-not-change)
/cc @Asacolips

In GitLab by @crownberry on Feb 18, 2022, 10:21
+1
It is also actual for "Legacy — Life Among The Ruins", where you need two playbooks for a player: Family Playbook and Character Playbook, each one with different stats and moves.

In GitLab by @Asacolips on Feb 22, 2022, 13:07
Thanks for reporting this. This is a bit outside of the test cases I had when I originally made the custom actor type, but I'll some digging into this soon to see what I can do. Thanks!


Add Decimal128

Add support for Decimal128. This behaves as you would expect from IEEE754, including behaviour of NaN comparison, ie. Nan == NaN is false. Note that you can still query for a NaN value in the DB as realm-core treats NaN as any other (single) value, to have a total order.
Be aware that the Dart compareTo method is implemented to honor the total ordering of IEEE754-2008 paragraf 5.10, which mimic the behaviour of Dart double. Note that this means that compareTo will order any values, including +/- NaN, +/- Infinity as well as +/- 0. This implies the compareTo operation is different from the partial ordering given by operator==, operator<, and operator>. For example, IEEE doubles impose that Decimal128.zero == -Decimal128.zero and all comparison operations on NaN return false.
This function imposes a complete ordering for doubles. When using compareTo, the following properties hold:

All NaN values are considered equal, and greater than any numeric value.
-Decimal128.zero is less than Decimal128.zero (and the integer 0), but greater than any non-zero negative value.
Negative infinity is less than all other values and positive infinity is greater than all non-NaN values.
All other values are compared using their numeric value.

so pleased this is in motion @nielsenko , thank you soooo much!

@dotjon0 I will need to postpone this work about a week, but then I'll return to it. I hope it is not inconvenient.
Note that it is a fairly rudimentary implementation supporting just basic the arithmetic operations (+,-,*,/, and abs())and the ability to convert to from int, double, and String.

@dotjon0 I will need to postpone this work about a week, but then I'll return to it. I hope it is not inconvenient.
Note that it is a fairly rudimentary implementation supporting just basic the arithmetic operations (+,-,*,/, and abs())and the ability to convert to from int, double, and String.

@nielsenko no need to apologise, we are just very grateful for this feature going in! Functionality sounds great. Thank you so much

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

53 of 60 (88.33%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 88.982%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/native/realm_core.dart
9
11
81.82%

lib/src/realm_object.dart
0
2
0.0%

lib/src/decimal128.dart
44
47
93.62%

Files with Coverage Reduction
New Missed Lines
%

lib/src/subscription.dart
1
90.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
3093

Relevant Lines:
3476

💛  - Coveralls

I don't see the support for Decimal128 in Realm models. I think we should expand this PR and add it here.

I have extended the generator to allow Decimal128 props, and added a simple test

I don't see the support for Decimal128 in Realm models. I think we should expand this PR and add it here.

I have included that in this PR as well.

Will be good to add Decimal128 also to realm_set_test.dart and realm_value_test.dart tests.

Done. This actually exposed the fact that I forgot to enable Decimal128 in RealmValue

I don't see the support for Decimal128 in Realm models. I think we should expand this PR and add it here.

We now have full support, including usage in mixed.


Add Immutable to ExternalSecret template

Here I added a new key to the ExternalSecret template called Immutable,
it helps to set immutable field in the rendered secret
I also added 2 new tests for immutable key

Hey @mouhsen-ibrahim  thanks for your contribution!
We tested your PR and it works. I have a few comments though:

I am not sure if doing this in the template is the right approach or if instead doing directly in the controller would be better as it might be more Kubernetes native. What do you think?
Regarding tests, if we do this in the controller we just need to add this test case in the controller unit tests.
The thing that I am not sure is whether kubebuilder mocked control plane current version supports immutable secrets.
@knelasevero @gabibeyer @moolen @mcavoyk

@ricardoptcosta the feature is optional, so I think we must add it to the template and check this in the controller.
I do not have much experience in this and I would like to use this operator in my projects, so I started on this small issue.

Hey @mouhsen-ibrahim, just so it's clear, the controller test control plane thingy is something that we will worry about later. And it does not affect you that much since you are already testing stuff with the e2e tests (which uses the kind cluster in CI).
So the only thing missing here is changing the controller to not re-queue immutable secrets for updates. After that we can merge :) Let us know if you need any help!

Hey @mouhsen-ibrahim, do you plan to work on this PR anytime soon?

@knelasevero Sorry I was away, I will continue on this very soon, expect something from me on the weekend at most

@mouhsen-ibrahim no worries! Just checking :)

@knelasevero I updated the PR with new code, I am not sure if this is the best way to do this so I would really appreciate some feedback

@mouhsen-ibrahim I will have a look as soon as I can :) In the mean time, CI got back with some stuff for you to have a look :smiley:

I think you are going in a generally good direction. But you will have to refactor some stuff, especially after we merge #262. Can you have a look?

@knelasevero I sent you an invite, thanks a lot. I will do better next time :)

No worries! Thanks for taking the time to create the PR and work on this! Feel free to grab other issues also!


Help with pubspec.yaml

"lib/**.dart": dart format --fix && dart fix --apply && dart analyze --fatal-infos --fatal-warnings

Is it possible to auto-fix the staged files and don't receive any lint error from analyze? With the current line I'm still receiving failing lint step. Thank you!

dart fix will auto fix issues that can be fixed.
If you want to ignore lint error, you can either remove && dart analyze --fatal-infos --fatal-warnings or modify analysis_options.yaml to disable rules that you do not need.


Fixed error handling: caught error is already equal to necessary error object

Also parsedMessage is not available on error

Thank you!! It is included on the latest. Please give me a nodge in discord as I did not see this.


React-Native support?

Any chance of supporting RN? Still fairly new to React and RN but I think it may be possible, you already make CSS transforms/percents optional (which RN doesn't support), but className prop would be a problem and need all styles moved into style prop.
There isn't much layout support libs for RN and this looks like it'd be useful!

I have no plans to do so for RN - I have no RN projects in flight. I'm not sure how Draggable/Resizable will fare in an RN environment. Would be happy to accept patches to any/all projects.

I think that react-grid-layout's RN support will be the best option to have sortable masonry-lists in RN. Am I wrong?


viewer numers do now match attrib table

the number is the viewer should always match the numbers that are in the attribute table
here, you can see the numbers are different
in the viewer they are numbered 6 to 10
in the attribute table they are numbered 0 to 4
so when Show selected = true, the numbering must start at 0

fixed


Implement the clone/pull command format that git.freebsd.org understands

The version of the git server that git.freebsd.org uses doesn't appear to honor command=fetch style requests and the alternate want style needs to be implemented.

git.freebsd.org is uring git 2.29.2, what's the minimal git version required?

I did some research over the weekend and it looks like it's a protocol issue -- git.freebsd.org doesn't appear to be configured to use version 2 of Git’s wire protocol.  When I send:
GET /doc.git/info/refs?service=git-upload-pack HTTP/1.1
Host: git.freebsd.org
User-Agent: git/2.28
Git-Protocol: version=2
it doesn't include version=2 in its capability advertisement response and rejects the version 2 command syntax.
If git.freebsd.org could be configured to accept the v2 protocol, that would be fantastic.  If it can't, I'll work on adding v1 support.
Thank you!

I've done some modification in staging server, can you check if https://git-dev.freebsd.org/doc.git works?

Looks good!  Thank you!
GET /doc.git/info/refs?service=git-upload-pack HTTP/1.1
Host: git-dev.freebsd.org
User-Agent: git/2.28
Git-Protocol: version=2

==> bytes sent: 129
==> bytes read:421      bytes_expected:0        total_bytes_read:421
000eversion 2
0015agent=git/2.29.2
000cls-refs
0012fetch=shallow
0012server-option
0017object-format=sha1
0000

https://git.freebsd.org supports git protocol v2 now.

I download releng/12.2 from git.freebsd.org successfully.

I just changed the default host in gitup.conf to git.freebsd.org.  Thank you!

I just changed the default host in gitup.conf to git.freebsd.org.  Thank you!


Have previewSite task not depend on PDF docs task.

Just a suggestion for a build system improvement to save time when developing/testing website docs. Right now when previewSite is run the PDF docs are created before the HTTP server is launched.

Fixed in https://github.com/sbt/website/pull/631

Fixed in https://github.com/sbt/website/pull/631


Java 10 segfaults on latest generation AWS instances

Docker image used: docker.elastic.co/elasticsearch/elasticsearch:6.3.0

Bug Description
Running the 6.3.0 Docker image on the latest-generation AWS instances (C5, M5, etc) crashes Java with a segfault when indexing data. See elastic/elasticsearch#31425 for details.
I have tracked it down to the version of Java that ships with the 6.3.0 Docker image. Downgrading Java to the JRE provided by the base image (java-1.8.0-openjdk-headless) fixes the issue.
While this is a Java/Lucene bug, it might be advisable to downgrade the JRE version on the official Docker image or release both -jre8 and -jre10 variants until the underlying issue is resolved.
Workaround
Manually rebuild the Docker image with Java 8.

Some preliminary investigation going on in https://markmail.org/message/n7rjurxzinyrhrwb / cc @jpountz
@xose Do you happen to have a workflow/load pattern that we can use to reproduce this on the instances you mentioned?

The new machines were nearly empty when the crashes started happening. I updated the index.routing.allocation.require.* for a small active index (around 650 docs indexed/sec) and .monitoring-* to move their shards to the new c5d machines for testing, and ~10 minutes later got the first crash followed by more crashes every few minutes on different machines. I then moved the indexes back to the original i3 instances.
Problematic instances: 3x c5d.2xlarge running Amazon Linux ECS 2018.03.a
Disk: 200GB NVMe instance store, formatted as XFS and mounted on ES data directory
ES Settings: 6GB heap, 30% index_buffer_size (Other system settings as recommended on Production Mode)
Index settings on the active index: translog.durability=async, refresh_interval=10s

Seeing the same issue on M5.xlarge. What is crazy is that these actually worked for a while and I didn't start seeing errors until late yesterday.

I am closing this as a duplicate of elastic/elasticsearch#31425 as this appears to be a JVM bug and not specific to Docker; please note that thread includes a workaround.


Permit override of package names

CentOS 6 has samba4-* packages, but rather than adding explicit support for these packages it is more flexible to allow changing of the package names from the default versions.
(If you have the samba-* default packages installed for 3.x on CentOS 6, then these conflict and so you need to forceably remove the old packages before installing these, which I wouldn't want to add to this module... :)

This change is

Also added a dependency on the options being set before the domain join exec, as sometimes we were getting an incomplete config when this tried to run...


[REG2.064a] Issue 11269 - Union initialization on 64-bit platforms

http://d.puremagic.com/issues/show_bug.cgi?id=11269
Revert a part of #2605.
Refactoring and improvements following #2605.

This introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=14805


JSON editor for RDB

Is it possible to

prettify JSON viewer for blob fields? (indention)
view w/o JSON specific escape characters? In my example only "/dev/ttyS1" should be visible

Using EE 5.0.1

Pretty formatting will be applied automatically if you use panel value viewer. Click on cell value and press F7 (or click on Panels button).


Try out sana model

https://github.com/NVlabs/Sana

Wait for the diffusers implementation before working on it: https://github.com/huggingface/diffusers/pull/9982

We could also test the branch before it being merged for now

We will probably use: https://huggingface.co/Efficient-Large-Model/Sana_600M_512px_diffusers

Diffusers 0.32.0 just released; it should feature SanaPipeline


JIT cache loading/saving

This is needed to restore the Thneed functionality for openpilot.
Added a $500 bounty for this, you also have to rebase openpilot on latest tinygrad and show that Thneed stuff works.

I'm using pickle for saving the JIT


Update Whitehall CSV Rendering to handle draft CSVs

Description
At the moment, this endpoint is passed the attachment_data id. As attachment data has many attachments for the same file, it is currently not possible to distinguish which file has been requested.
At the moment, the CSV preview endpoint defaults to rendering the attachment belonging to the latest published edition for the attachment data passed in.
We need to ensure that when a draft CSV is previewed it has the correct styling and uses the draft editions details on the page.
This PR adds this functionality in by using the url to determine whether a draft asset has been requested.
Screenshots
Draft CSV

Publised CSV

Trello card
https://trello.com/c/ktlUy34f/511-csv-previews-for-shareable-preview-links
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Thanks for the feedback. I've updated it to check the hostname is draft-assets like you suggested 👍


MINOR: Print all removed dynamic members during join complete

For better visibility on the group rebalance, we are trying to print out the evicted members inside the group coordinator during rebalance complete.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

okay to test

okay to test

okay to test

Test this please

Test this please

Retest this please


Be able to install without Pipfile

Issue description
I can't install packages with just Pipfile.lock, I also need Pipfile.
During deployment I am doing.
PIP_NO_CACHE_DIR=false PIPENV_VENV_IN_PROJECT=true pipenv install --ignore-pipfile

It returns a 0 status code, creates a Pipfile file but doesn't install any packages.
.venv/bin/python -m pip freeze
# no output

Expected result
All packages in Pipfile.lock are installed. Pipfile file is not created.
Actual result
It returns a 0 status code, creates a Pipfile file but doesn't install any packages.
.venv/bin/python -m pip freeze
# no output

@Siecje pipenv install will try to lock from the Pipfile.  What if you replace that part with pipenv sync which installs dependencies from the lock file?

@Siecje I just tested this and it turns out that pipenv sync won't install anything without the Pipfile, maybe because it doesn't know what is a package and what is a dev package without the Pipfile?

@Siecje What is the use case for not including the Pipfile as well during the build process?

I didn't think I needed it, especially with --ignore-pipfile.
I assumed I only needed the one file when using pipenv.


Update add.md

Any reason adding this, pls?

I'll close this since it's been a while since it's been opened. Feel free to reopen if you have updates on this


Activate the correct get_server_info SQL for v12/13

Using old v11 SQL causes "permission denied for function pg_ls_dir" errors on managed Azure instances
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/krlc/git/postgres/pg_activity/pgactivity/__main__.py", line 4, in <module>
    main()
  File "/home/krlc/git/postgres/pg_activity/pgactivity/cli.py", line 327, in main
    ui.main(term, dataobj, host, args)
  File "/home/krlc/git/postgres/pg_activity/pgactivity/ui.py", line 29, in main
    server_information = data.pg_get_server_information(
  File "/home/krlc/git/postgres/pg_activity/pgactivity/data.py", line 225, in pg_get_server_information
    cur.execute(
  File "/usr/local/lib/python3.8/dist-packages/psycopg2/extras.py", line 146, in execute
    return super().execute(query, vars)
psycopg2.errors.InsufficientPrivilege: permission denied for function pg_ls_dir

Seems like you forgot to git add pgactivity/queries/get_server_info_post_120000.sql.

I thought I already fixed this ...

ha, I understand better I spotted it while fixing #278.

@blogh Hi, had forgotten a bit about this PR...but seems still relevant and ready to merge now. Thanks!

@kmoppel-cognite yes sorry, I've been away from work for a while.
thanks for the PR


Cannot capture region of the screen

Hi, I love your extension and have used it since version 14.5 before it was removed from the stored. I'm so glad that it is now back in.
However, I cannot capture region of the screen. This is the feature that I use the most. When I clicked on the menu on "capture region of the screen" nothing happens. I tried shortcut ALT+R also nothing happens.

I remove this option. You can take full screenshot and crop to content


Incorrectly handles routes that have (non-ASCII?) non-Latin characters

e.g., تایبەتێتی.tsx

Hmm, I believe it is an issue with Deno Deploy since the screenshot works locally.

Nonetheless, the fresh.gen.ts should better not look like that.

I did this cool trick anyway.

It's a deploy issue. The notation in the fresh.gen.ts file is a bit unexpected, but in essence it still points to the very same file. It seems like it gets parsed as an URL somewhere in Fresh before writing it to the manifest.

I was thinking of having a feature to use a different path than the file name ~as a workaround for this~. Not sure how would that work tho.

Reopening, because the issue needs to be resolved on the deploy side too.

@roj1512 Would love to know more about the use case. Can you share more what the intention should be?

The use case in this case (the Deno Deploy issue being a thing) is simple: be able to have a non-Latin/ASCII route (e.g., /пример) that has its source code in an ASCII name (e.g., routes/primer.tsx).
A more general use case would be to make the codebase more consistent by not having file names that include non-Latin/ASCII characters (e.g., пример.tsx, and especially RTL ones which are a little bit more messy, for example, نموونە.tsx).
I have already done this by modifying the generated fresh.gen.ts to for example, replace "./routes/something.tsx": $0 with "./routes/شتێک.tsx": $0.
A way to implement this functionality would be allowing the user to redirect from the non-Latin/ASCII paths to the Latin/ASCII ones, but the end user would see the Latin/ASCII path instead of the real one.

@roj1512 That should be doable via the routeOverride option. It allows you to overwrite the file based route. The bottom of the "Routing" page in the docs has an example on how to use that https://fresh.deno.dev/docs/concepts/routing

We just deployed the remaining fix on the Deno Deploy side and can confirm that this issue is resolved 🎉