npm run clean fails on Windows

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

Running npm run clean on a fresh clone produces the following output:
$ npm run clean

><EMAIL_ADDRESS>clean C:\ReviewCommunity\seed-test4
> npm run clean.js && rimraf node_modules typings && cd nativescript && rimraf node_modules hooks lib platforms && cd .. && npm i

><EMAIL_ADDRESS>clean.js C:\ReviewCommunity\seed-test4
> gulp clean.all.src.js

[16:07:43] Requiring external module ts-node/register
[16:07:45] Loading tasks folder C:\ReviewCommunity\seed-test4\tools\tasks\seed
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.assets.dev
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.assets.prod
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.assets.tns
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.bundle.rxjs
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.bundles.app.aot
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.bundles.app.rollup.aot
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.bundles.app
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.bundles
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.docs
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.html_css
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.index.dev
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.index.prod
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.js.dev
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.js.e2e
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.js.prod.aot
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.js.prod.rollup.aot
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.js.prod
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.js.test
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.js.tns
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.tns_html_css
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\build.tools
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\check.tools
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\check.versions
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.all.src.js
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.all
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.coverage
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.dev
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.e2e
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.prod
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.tns
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clean.tools
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\clear.files
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\compile.ahead.prod
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\copy.prod.rollup.aot
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\copy.prod
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\e2e
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\generate.manifest
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\karma.run
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\karma.run.with_coverage
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\karma.watch
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\minify.bundles
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\minify.index
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\noop
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\print.banner
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\serve.coverage
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\serve.coverage.watch
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\serve.docs
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\server.prod
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\server.start
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\start.deving
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\sw.manifest.static
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\transpile.bundles.rollup.aot
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\tslint.tns
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\tslint
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\watch.dev
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\watch.e2e
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\watch.test
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\watch.tns
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\seed\webdriver
[16:07:45] Loading tasks folder C:\ReviewCommunity\seed-test4\tools\tasks\project
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\project\desktop.build
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\project\desktop.libs
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\project\desktop.package.linux
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\project\desktop.package.mac
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\project\desktop.package.windows
[16:07:45] Registering task C:\ReviewCommunity\seed-test4\tools\tasks\project\desktop.watch
[16:07:45] Using gulpfile C:\ReviewCommunity\seed-test4\gulpfile.ts
[16:07:45] Starting 'clean.all.src.js'...
[16:07:46] Deleted src/client/*.js
[16:07:46] Deleted src/client/*.js.map
[16:07:46] Deleted src\client\app/*.js
[16:07:46] Deleted src\client\app/*.js.map
[16:07:46] Deleted src\client\app\components/*.js
[16:07:46] Deleted src\client\app\components/*.js.map
[16:07:46] Deleted src\client\app\components\about/*.js
[16:07:46] Deleted src\client\app\components\about/*.js.map
[16:07:46] Deleted src\client\app\components\home/*.js
[16:07:46] Deleted src\client\app\components\home/*.js.map
[16:07:46] Deleted src\client\app\modules/*.js
[16:07:46] Deleted src\client\app\modules/*.js.map
[16:07:46] Deleted src\client\app\modules\analytics/*.js
[16:07:46] Deleted src\client\app\modules\analytics/*.js.map
[16:07:46] Deleted src\client\app\modules\analytics\services/*.js
[16:07:46] Deleted src\client\app\modules\analytics\services/*.js.map
[16:07:46] Deleted src\client\app\modules\core/*.js
[16:07:46] Deleted src\client\app\modules\core/*.js.map
[16:07:46] Deleted src\client\app\modules\core\directives/*.js
[16:07:46] Deleted src\client\app\modules\core\directives/*.js.map
[16:07:46] Deleted src\client\app\modules\core\interfaces/*.js
[16:07:46] Deleted src\client\app\modules\core\interfaces/*.js.map
[16:07:46] Deleted src\client\app\modules\core\services/*.js
[16:07:46] Deleted src\client\app\modules\core\services/*.js.map
[16:07:46] Deleted src\client\app\modules\core\services\logging/*.js
[16:07:46] Deleted src\client\app\modules\core\services\logging/*.js.map
[16:07:46] Deleted src\client\app\modules\core\testing/*.js
[16:07:46] Deleted src\client\app\modules\core\testing/*.js.map
[16:07:46] Deleted src\client\app\modules\core\testing\mocks/*.js
[16:07:46] Deleted src\client\app\modules\core\testing\mocks/*.js.map
[16:07:46] Deleted src\client\app\modules\core\testing\providers/*.js
[16:07:46] Deleted src\client\app\modules\core\testing\providers/*.js.map
[16:07:46] Deleted src\client\app\modules\core\utils/*.js
[16:07:46] Deleted src\client\app\modules\core\utils/*.js.map
[16:07:46] Deleted src\client\app\modules\electron/*.js
[16:07:46] Deleted src\client\app\modules\electron/*.js.map
[16:07:46] Deleted src\client\app\modules\electron\services/*.js
[16:07:46] Deleted src\client\app\modules\electron\services/*.js.map
[16:07:46] Deleted src\client\app\modules\electron\utils/*.js
[16:07:46] Deleted src\client\app\modules\electron\utils/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n/*.js
[16:07:46] Deleted src\client\app\modules\i18n/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\actions/*.js
[16:07:46] Deleted src\client\app\modules\i18n\actions/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\common/*.js
[16:07:46] Deleted src\client\app\modules\i18n\common/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\components/*.js
[16:07:46] Deleted src\client\app\modules\i18n\components/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\effects/*.js
[16:07:46] Deleted src\client\app\modules\i18n\effects/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\reducers/*.js
[16:07:46] Deleted src\client\app\modules\i18n\reducers/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\services/*.js
[16:07:46] Deleted src\client\app\modules\i18n\services/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\states/*.js
[16:07:46] Deleted src\client\app\modules\i18n\states/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\testing/*.js
[16:07:46] Deleted src\client\app\modules\i18n\testing/*.js.map
[16:07:46] Deleted src\client\app\modules\i18n\testing\mocks/*.js
[16:07:46] Deleted src\client\app\modules\i18n\testing\mocks/*.js.map
[16:07:46] Deleted src\client\app\modules\ngrx/*.js
[16:07:46] Deleted src\client\app\modules\ngrx/*.js.map
[16:07:46] Deleted src\client\app\modules\sample/*.js
[16:07:46] Deleted src\client\app\modules\sample/*.js.map
[16:07:46] Deleted src\client\app\modules\sample\actions/*.js
[16:07:46] Deleted src\client\app\modules\sample\actions/*.js.map
[16:07:46] Deleted src\client\app\modules\sample\effects/*.js
[16:07:46] Deleted src\client\app\modules\sample\effects/*.js.map
[16:07:46] Deleted src\client\app\modules\sample\reducers/*.js
[16:07:46] Deleted src\client\app\modules\sample\reducers/*.js.map
[16:07:46] Deleted src\client\app\modules\sample\services/*.js
[16:07:46] Deleted src\client\app\modules\sample\services/*.js.map
[16:07:46] Deleted src\client\app\modules\sample\states/*.js
[16:07:46] Deleted src\client\app\modules\sample\states/*.js.map
[16:07:46] Deleted src\client\app\modules\shared/*.js
[16:07:46] Deleted src\client\app\modules\shared/*.js.map
[16:07:46] Deleted src\client\app\modules\shared\components/*.js
[16:07:46] Deleted src\client\app\modules\shared\components/*.js.map
[16:07:46] Deleted src\client\app\modules\shared\components\navbar/*.js
[16:07:46] Deleted src\client\app\modules\shared\components\navbar/*.js.map
[16:07:46] Deleted src\client\app\modules\shared\components\toolbar/*.js
[16:07:46] Deleted src\client\app\modules\shared\components\toolbar/*.js.map
[16:07:46] Deleted src\client\app\modules\test/*.js
[16:07:46] Deleted src\client\app\modules\test/*.js.map
[16:07:46] Deleted src\client\app\modules\test\e2e/*.js
[16:07:46] Deleted src\client\app\modules\test\e2e/*.js.map
[16:07:46] Deleted src\client\app\modules\test\shorthand/*.js
[16:07:46] Deleted src\client\app\modules\test\shorthand/*.js.map
[16:07:46] Deleted src\client\assets/*.js
[16:07:46] Deleted src\client\assets/*.js.map
[16:07:46] Deleted src\client\assets\favicon/*.js
[16:07:46] Deleted src\client\assets\favicon/*.js.map
[16:07:46] Deleted src\client\assets\i18n/*.js
[16:07:46] Deleted src\client\assets\i18n/*.js.map
[16:07:46] Deleted src\client\assets\svg/*.js
[16:07:46] Deleted src\client\assets\svg/*.js.map
[16:07:46] Deleted src\client\css/*.js
[16:07:46] Deleted src\client\css/*.js.map
[16:07:46] Deleted src\client\scss/*.js
[16:07:46] Deleted src\client\scss/*.js.map
[16:07:46] Finished 'clean.all.src.js' after 731 ms
Das System kann den angegebenen Pfad nicht finden.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>clean: `npm run clean.js && rimraf node_modules typings && cd nativescript && rimraf node_modules hooks lib platforms && cd .. && npm i`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>clean script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

Das System kann den angegebenen Pfad nicht finden. means the specified path cannot be found.
Expected behavior

npm run clean should not fail.
Minimal reproduction of the problem with instructions

$ git clone https://github.com/NathanWalker/angular-seed-advanced.git
$ cd angular-seed-advanced
$ npm install
$ npm run clean

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Windows 7
npm 5.3.0

Angular Seed Version: 9ec7a06

Node: node --version = v8.2.1

Can you try installing rimraf globally?
npm install -g rimraf
I'm not sure the clean script can work without rimraf being globally available.

@hellofornow I still get the same error.
This does not seem like a "command not found" as opposed to a "path not found" error.


Get Tool from Analyzer

I'm looking to retrieve the Tool from within an analyzer so I can use the FillOutStructureCmd to populate a class components before setting its super classes in place.

Here's how an existing analyzer does it:
https://github.com/NationalSecurityAgency/ghidra/blob/6d4908f0cdb32b0cbd3954c4a416e721a168e54e/Ghidra/Features/MicrosoftCodeAnalyzer/src/main/java/ghidra/app/plugin/prototype/MicrosoftCodeAnalyzerPlugin/WindowsResourceReferenceAnalyzer.java#L79-L81

Here's how an existing analyzer does it:
https://github.com/NationalSecurityAgency/ghidra/blob/6d4908f0cdb32b0cbd3954c4a416e721a168e54e/Ghidra/Features/MicrosoftCodeAnalyzer/src/main/java/ghidra/app/plugin/prototype/MicrosoftCodeAnalyzerPlugin/WindowsResourceReferenceAnalyzer.java#L79-L81

Thank you.


6.5.1  chrome reports an error

swiper.esm.js:56 Uncaught TypeError: Cannot assign to read only property '__esModule' of object '#'
at Object. (swiper.esm.js:56)
at webpack_require (bootstrap 512a21a8ae67c98bf161:686)
at fn (bootstrap 512a21a8ae67c98bf161:105)
at vue-awesome-swiper.js:9
at Object. (vue-awesome-swiper.js:9)
at webpack_require (bootstrap 512a21a8ae67c98bf161:686)
at fn (bootstrap 512a21a8ae67c98bf161:105)
at Object. (customer_information.vue?0b91:5)
at webpack_require (bootstrap 512a21a8ae67c98bf161:686)
at fn (bootstrap 512a21a8ae67c98bf161:105)

Live example, demo?


suggested addition to Readme documentation, installation section

addition to installation instructions for helium
"helium" not available directly from the Anaconda/conda environment at present (oct 2021) - so users should follow this
advice on installing non conda packages

Additional info, though this can be obtained from the link above, so may be TMI
Installing helium via command-line conda

* activate the conda environment where you will be using helium (eg conda activate myscrapingarea)
* verify pip available in that conda environment (conda install pip)
* then within that conda environment issue regular pip command (pip install helium)

Note:- when using conda you use its environments, not the regular pip virtual environments

Hi,
I don't like (Ana)conda. It fragments the Python ecosystem. I feel like we should all be pulling on the same rope, which is Python itself and PyPI / pip. Anaconda is creating an alternative ecosystem that essentially splits our efforts as developers into two halves. What's more, it's created by a for-profit organization. I really don't like it.
Helium is a Python package. Python's package manager is pip. As you were able to find out, it is possible to install Python packages in Conda via pip. So I don't see a need to add conda-specific instructions to the README.


fixed URL for Nitrokey3/Linux/udev rules troubleshooting

This PR fixes the URL that is shown as link to the Linux udev rules for troubleshooting.
Changes

URL

I accidentally pushed my master instead of the amended commit to the PR branch, so GitHub closed the PR and I can no longer push to the branch to fix it. :/  Will PR & merge separately.


kns: init @ 50b6370c88136a580599c913f0fae2cb24981dc1

Description of changes
Add new package for kns the easy kubernetes namespace switcher. Upstream can be found here: https://github.com/blendle/kns
kns is a shell script that uses fzf to help navigate namespaces within a kubernetes cluster.
I used the existing kubectl-node-shell to base my work on, as they are both fancy bash scripts.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I will probably backport this. I'm on 22.05 🤪

Result of nixpkgs-review pr 193995 run on x86_64-linux 1

1 package failed to build:

kns

i had to change the rev in fetchFromGithub such that it pointed to a full commit hash. it should also work if we just "pin" it to master as well if that aligns with how we should proceed with this. there is no release strategy or anything for this project so i'm not able to pin on a tag/release.

@crutonjohn can you take a look at the changes I suggested? I'd be happy to take over the PR if you'd like too.

@crutonjohn can you take a look at the changes I suggested? I'd be happy to take over the PR if you'd like too.

these all look good to me, I've been on holiday with my family but happy to take care of this sometime this week.

@crutonjohn can you take a look at the changes I suggested? I'd be happy to take over the PR if you'd like too.

these all look good to me, I've been on holiday with my family but happy to take care of this sometime this week.

awesome, looking forward to getting rid of this from all my shell.nix/flake.nix files :D

@crutonjohn do you have the bw to apply @drupol's suggestions? If not let me know and I'll take over (alas in a separate PR).

@crutonjohn do you have the bw to apply @drupol's suggestions? If not let me know and I'll take over (alas in a separate PR).

yeah ive been back and forth traveling for work so im tapped out. would be incredibly grateful if you could just knock it out. 🙏

@crutonjohn do you have the bw to apply @drupol's suggestions? If not let me know and I'll take over (alas in a separate PR).

yeah ive been back and forth traveling for work so im tapped out. would be incredibly grateful if you could just knock it out. 🙏

@mmlb will you tag me in the new PR plz


Single style merge method.

Right now it's very inconvenient to merge two Styles, because you have to call multiple methods, and it doesn't even cover the insertion.
private static Style mergeStyle(Style first, Style second) {
    first = first
        .mergeColor(second)
        .mergeDecorations(second)
        .mergeEvents(second);
    String insertion = second.insertion();
    return insertion != null ? first.insertion(insertion) : first;
  }

A single merge method simplifies this and also reduces object creation.

#41


docker-swarm support?

Even with a beefy ARM based machine (playing with the oDroid N2+ now) if you live in an area of high 1090 traffic, you can overload a single docker host. To that end, I've been playing around with docker swarm, thinking about breaking the decode/feeders/etc across several pi, but all the compose/run/etc commands (and shared data directories) assume a single host.
Any thoughts/plans/etc to support swarm  (aka docker services)?
thanks.

The cost of multiple RPIs will get you a single nice Celeron N5105 or i3 mini PC that can do it all.

The cost of multiple RPIs will get you a single nice Celeron N5105 or i3 mini PC that can do it all.

I guess I left that open ended when I asked "any thoughts"
Any productive thoughts specific to docker swarm support?

Sorry for the slow answering -- going through reviewing a bunch of open issues that I thought had already been address, but for some reason, we didn't 🤷♂
In any case, right now we have no plans to automatically setup Docker Swarms. This doesn't mean that it's wrong, or not interesting, but we're already a bit overwhelmed with projects and tbh you're the first one asking for it. So unless you want to do the work in such a way that it becomes an add-on feature for this repo (and we'll be happy to review any PRs for that!), I'm closing this issue for now as something we won't do. Feel free to reopen if you want to discuss further.
In any case - thanks for bringing it up and sorry for the awful delay in answering.


Planning to upgrade logo on GitHub Marketplace to Microsoft logo by end of May 2021

Team,
We are planning to upgrade the logo for all 13 GitHub Actions projects listed on the GitHub Marketplace to the official Microsoft logo.

We'd like to make this change by the end of May 2021.
Please let us know if you have any objection, otherwise we'll proceed.
https://github.com/microsoft/raft-action
https://github.com/microsoft/sarif-actions
https://github.com/microsoft/powerplatform-actions
https://github.com/microsoft/psscriptanalyzer-action
https://github.com/microsoft/vs-intellicode
https://github.com/microsoft/setup-msbuild
https://github.com/microsoft/ps-rule
https://github.com/microsoft/RichCodeNavIndexer
https://github.com/microsoft/playwright-github-action
https://github.com/microsoft/DevSkim-Action
https://github.com/microsoft/infersharpaction
https://github.com/microsoft/android-app-size-diff
https://github.com/microsoft/variable-substitution

Sounds fine.

Awesome @gfs! Would you mind closing out this issue? (Helps us keep track of which folks we've gotten approval from). Thanks again!


Java-37516 Fix modules list in profile pairs

added mapstruct-2 module in pom.xml under integration profile.

retest this please

retest this please

retest this please.

retest this please

retest this please

retest this please

retest this please

retest this please


Integration Test - Release - 2019/04/02 01:59:48

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


Address the limitations of importlib.metadata.version

See: https://docs.python.org/3/library/importlib.metadata.html

Check if this works better in various environments:
import importlib
import pkg_resources

def get_pypi_package_version(package_name: str) -> str:
    try:
        # Try to dynamically import the package
        package = importlib.import_module(package_name)

        # Get the version using pkg_resources
        version = pkg_resources.get_distribution(package_name).version
        return f"{package_name} version: {version}"
    except ImportError:
        return f"Package '{package_name}' is not installed or not importable."
    except pkg_resources.DistributionNotFound:
        return f"Package '{package_name}' is installed but its version cannot be found."
    except Exception as e:
        return f"An error occurred: {str(e)}"

I think it's fine as it is, I haven't encountered issues with my tests. Closing for now.


BNB Price takes a lot of time to load or doesnt load at all

BNB Price takes a lot of time to load or doesnt load at all.

Hi @CodahUY thanks for the heads up I see it now. It should now be fixed. Can you confirm?

Its solved! Thanks!


fix: update deprecated usage of taskiq_redis broker

See https://github.com/taskiq-python/taskiq/commit/2c28eefaa1a13c45afd409c9bc29a1ada50cce14.
Not sure if the code is the best practice, please review & edit.

Hi there. Thanks for your PR.
Indeed, it's needed to use builder API instead of parameters. But it should look like this.
broker = MyBroker().with_result_backend(MyResultBackend())

Can you please update this line as well?


Add "dom-action" schema only if render decisions is true.

Description

Personalization component should be sending "dom-action" schema ONLY when sendEvent(...) renderDecisions is set to true.
Related Issue

None
Motivation and Context

We should not send "dom-action" schema if whoever implements Alloy doesn't want decisions to be auto-rendered. This should also help the backend be a little bit more selective about the data it processes and returns.
Screenshots (if appropriate):
None
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[x] I have made any necessary test changes and all tests pass.
[x] I have run the Sandbox successfully.

The title of this PR is a bit misleading. Its really doing: Add "Dom-action" schema only if page wide scope is requested explicitly
or implicitly by setting renderDecisions = true.


unicorn breaks on i686 busybox test when single-stepping

never gets to first syscall

upstream bug #496, closing


Fixed custom arguments for commandline-specified testrunners

The testrunner that is used can define and add_arguments() method to
specify additional commandline arguments for the test management
command. To make this work even when the testrunner to be used is
specified on the commandline, the test command prescans the
commandline for the --testrunner option, to call the runner's
add_arguments() before the actual commandline parsing happens.
Previously, this prescanning only considered options like
--testrunner=foo, while the actual command also accepts --testrunner foo. In the latter case, additional arguments defined by the testrunner
would not be accepted.
This commit fixes this by checking for both argument styles. The
scanning is moved to a separate function for clarity, and to prepare for
possible reuse later.

I just discovered argparse.parse_known_args(), which allows using argparse to parse a subset of options and ignore the rest. This is of course a better approach than manually scanning the argv list, so I rewrote the commit in this PR to use that instead, which gives even simpler code. For reference, my previous commit (now obsolete) is here: 23c49d6cde38b11aaf3f74e41f5f8517a30b4464


Add a swap partition present check

As it's a recommended practice, it could be nice to add a small check on the existence of a swap partition, just to warn users... https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/requirements.md.
Thanks anyway for this role

I'd rather not add that as part of this role—it might be more suitable in it's own 'setup' role or a 'swap' role. That's something that's more a systemwide setting (similar to ssh setup, memory, disk mounts, etc.) that shouldn't be managed through a particular application's configuration.


ZenDesk Bindings for Android

Do you all happen to have any bindings for the ZenDesk Android SDK? I gave it a shot, but am having some issues.

Hi @SharpMobileCode - unfortunately not. Did you get it working in the end?

Hi everyone,
Is there any reference on Android sample using Xamarin application?


WSL: Invalid reference format

Hi, I am Ernes. I am new to Fastsurfer. I have followed the instructions using the CPU version.This is the code that I used
docker run -v C:/Users/Ernes/my_mri_data:/data
-v C:/Users/Ernes/my_fastsurfer_analysis:/output
-v C:/Users/Ernes/my_fs_license_dir:/fs_license
--rm --user $(id -u):$(id -g) deepmi/fastsurfer:cpu-v2.0.0
--fs_license /fs_license/license.txt
--t1 /data/subjectX/H1.nii.gz
--device cpu
--sid subject1 --sd /output
--parallel
But I got Invalid reference format. How do I solve this?

Hi Ernes, you are probably using windows, which requires WSL2.
Did you follow our installation instruction here: https://github.com/Deep-MI/FastSurfer/blob/dev/INSTALL.md#windows ?
Also we would need to know the exact output when you run this command.

Yeah, I already had WSL2 installed because I use Ubuntu for some analysis. So I downloaded Docker and followed the instructions on the link you provided.

You might want to replace :cpu-v2.0.0 with :cpu-latest to run the most recent release.
Also you probably double checked that the license dir and the data dir really contain the license.txt and subjectX/H1.nii.gz ?
And can you post the exact output you are getting when running the command?

Sure, I will try that. But now I am running some commands in my terminal. I will get back to you tomorrow. Thank you very much.

I think I found the issue in your command. The reason that docker throws an "Invalid reference format" error is when it cannot find the image. The image is the first parameter after the flags, and in this case should be the deepmi/fastsurfer...
If however, any flag before contains a space, then it will use some other string as the image and cannot find it. This can happen in paths with spaces, which should be inside quotation marks "". In your case it looks like there could be a space in the user flag --user $(id -u):$(id -g) before the colon? Other things to try is to put quotation marks around that --user "$(id -u):$(id -g)" .

I made the changes at --user 1001:1001 and it kinda worked but now I have error "FastSurfer asegdkt segmentation failed".
C:\Windows\System32>docker run -v C:/Users/Ernes/my_mri_data:/data -v C:/Users/Ernes/my_fastsurfer_analysis:/output -v C:/Users/Ernes/my_fs_license_dir:/fs_license --rm --user 1001:1001 deepmi/fastsurfer:cpu-latest --fs_license /fs_license/license.txt --t1 /data/subjectX/H1.nii.gz --device cpu --sid subjectX --sd /output --parallel
Version: 2.2.0+9f37d02
Sun Jan 14 08:23:58 UTC 2024
python-s /fastsurfer/FastSurferCNN/run_prediction.py --t1 /data/subjectX/H1.nii.gz --asegdkt_segfile /output/subjectX/mri/aparc.DKTatlas+aseg.deep.mgz --conformed_name /output/subjectX/mri/orig.mgz --brainmask_name /output/subjectX/mri/mask.mgz --aseg_name /output/subjectX/mri/aseg.auto_noCCseg.mgz --sid subjectX --seg_log /output/subjectX/scripts/deep-seg.log --vox_size min --batch_size 1 --viewagg_device auto --device cpu
[INFO: run_prediction.py:  546]: Checking or downloading default checkpoints ...
[INFO: common.py:  111]: Using device: cpu
[INFO: run_prediction.py:  234]: Running view aggregation on cpu
[INFO: inference.py:  200]: Loading checkpoint /fastsurfer/checkpoints/aparc_vinn_coronal_v2.0.0.pkl
[INFO: inference.py:  200]: Loading checkpoint /fastsurfer/checkpoints/aparc_vinn_sagittal_v2.0.0.pkl
[INFO: inference.py:  200]: Loading checkpoint /fastsurfer/checkpoints/aparc_vinn_axial_v2.0.0.pkl
[INFO: common.py:  820]: Single subject with absolute file path for input.
[INFO: common.py:  833]: No subjects directory specified, but the parent directory of the output file /output/subjectX/mri/aparc.DKTatlas+aseg.deep.mgz is 'mri', so we are assuming this is the 'mri' folder in the subject directory.
[INFO: common.py:  875]: Analyzing single subject /data/subjectX/H1.nii.gz
[INFO: common.py:  970]: Output will be stored in Subjects Directory: /output
[INFO: run_prediction.py:  310]: Successfully loaded image from /data/subjectX/H1.nii.gz.
[INFO: run_prediction.py:  418]: Output image directory 001.mgz does not exist. Creating it now...
Traceback (most recent call last):
File "/fastsurfer/FastSurferCNN/run_prediction.py", line 561, in
for subject, (orig_img, data_array) in iter_subjects:
File "/fastsurfer/FastSurferCNN/run_prediction.py", line 462, in pipeline_conform_and_save_orig
yield subject, self.conform_and_save_orig(subject)
File "/fastsurfer/FastSurferCNN/run_prediction.py", line 316, in conform_and_save_orig
if not conf.is_conform(
File "/fastsurfer/FastSurferCNN/data_loader/conform.py", line 625, in is_conform
iaffine = img.affine[0:3, 0:3] - LIA_affine * (
ValueError: operands could not be broadcast together with shapes (3,3) (4,)
ERROR: FastSurfer asegdkt segmentation failed.

This is a new issue and I moved that discussion to #431  so this can be closed


Raise for bad plot options in _send_to_plotly

Fixes #298
This is backwards incompatible as obsolete plot_options have previously been silently ignored. It is a little misleading and has caused confusion for users (#298).
Another option is to allow layout again, but only if (1) data is given as the first argument or (2) layout is not defined in the figure. We could just throw a deprecation warning and then stop supporting it in 2.x?

@chriddyp @cldougl
I don't want to make an incompatible change in the middle of 1.x, but maybe the updated graph reference pr could make a good change to 2.x? Then I think we're alright all-of-a-sudden erring on this .
Thoughts?

Old PR. It's pretty simple and we should just open up a new PR if we still want to fix.


Added (growingTextView:shouldChangeTextInRange:replacementText:)

(growingTextView:shouldChangeTextInRange:replacementText:) exists in protocol but never get called

Thanks!


[Popper] Floating elements are attached to the wrong document

When using @popperjs/core to show a floating element in a child window, the content is appended to the global window object. To function correctly, the anchor element's ownerDocument property should be used instead. I know this project is in maintenance mode and has been replaced, but if I submit a PR to fix this issue, would it be reviewed/accepted? thanks.

What do you mean “attached”? Popper does not attach anything for you, you do it yourself. Owner documents are already handled

yep, I had misread and looked through dom utilities instead of the old popper branch, that is my mistake. it looks like the issue we are having is upstream in chakra, sorry about that.


Please correct all instances of ADFS

It should be AD FS.
Note the space...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee6ac70d-5853-6a3a-0964-23b46910b4c4
Version Independent ID: a5beda87-9845-8807-6221-7fdc64079587
Content: Passwordless sign-in with the Microsoft Authenticator app - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-authentication-passwordless-phone.md
Service: active-directory
Sub-service: authentication
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@r-milne
Thanks for your feedback! We will investigate and update as appropriate.

@r-milne
I have created a PR to update the documentation and will now close out this issue. Please allow some time for the changes to reflect and if you don't see the document update, please let me know.
I will be more than happy to re-open this issue and look into what happened.
Thank you for your time and patience!


B002 send response

https://github.com/XenseEducation/xs-hub/issues/2

Thanks for this!  How did you discover that userProgram.print needs a response?


Update README with JSON5 prettier documentation

The Prettier default configuration prevents tokens from being parsed. Added a configuration example to the README, and also updated the token JSON example with JSON syntax highlighting and quotes around the props.
Thanks for your great work, we use this package to parse Figma variables for an upcoming Equinor Design System workshop we’re creating for an internal developer conference in September.

Hey @vnys I think this should not be an issue if you are using the json5 parser, right? Can you verify this please?
I still think it is a good additon.

I’m using the JSON5 parser. If I remove the $ from type and value the tokens get parsed, and the same with adding quotes. According to https://jsonformatter.org/json5-validator prefixing a prop with $ is perfectly valid JSON5 and shouldn’t need to be quoted, so perhaps the problem is not the prettier config after all but the parser itself. I’ll create another PR for that.


Add License Information to Maven

General Troubleshooting

[x] I have checked for similar issues.
[x] I have updated to the [latest JDA version][download].
[x] I have checked the branches or the maintainers' PRs for upcoming features.

Feature Request
JDA presently does not return any license information when queried with dependency license collection plugins such as com.github.hierynomus.license or the License Maven Plugin.  It would be helpful if the necessary metadata were added to its Maven repository.
Example Use-Case
downloadLicenses
{
    reportByDependency true
    includeProjectDependencies true
    dependencyConfiguration 'compileClasspath'
    licenses 'net.dv8tion:JDA:4.2.1_253': license('Apache License, Version 2.0', 'https://www.apache.org/licenses/LICENSE-2.0.txt')    // this line should not be necessary
}

This is now available in 5.0.0-alpha.1 https://github.com/DV8FromTheWorld/JDA/blob/54871dee319ddafbbf617156411b95c856df552a/build.gradle.kts#L356-L362
https://search.maven.org/artifact/net.dv8tion/JDA/5.0.0-alpha.1/jar


[7.x] Add Collection::sortDesc()

Currently it is not possible to sort items in descending order.
This PR adds a new method sortDesc() to the Collection, LazyCollection classes to allow for that.
Every other sorting method has a desc variation except the sort(), which is added by this PR.
sortBy and sortByDesc, sortKeys and sortKeysDesc.
The sorting supports using flags as well.
I targeted the master branch because this involves adding the new method to the \Illuminate\Support\Enumerable which may break some applications that are implementing the interface on their own.

Just fyi, this has been attempted a lot already: https://github.com/laravel/framework/pulls?q=is%3Apr+sortDesc+is%3Aclosed

@driesvints Thanks, but i didn't check before submitting. I hope that taylor will accept this because should exist like any other sorting method that has a Desc variation

The Collection is used to work with arrays in a object oriented manner instead of using php array functions.
I mean imagine if php provided a asort and didn't provide arsort
Also all other sorting methods have a desc variation, why this shouldn't ?


[v2] Ability for Picker to Submit Different Value to Server than what is Shown

This is a (multiple allowed):

[ ] bug
[x] enhancement
[ ] feature-discussion (RFC)

In a regular <select> dropdown menu, you have the ability to do <option value="server_val">Shown Value</option>, so that the value inserted into the database is different than what is shown. Could something like this be integrated into pickers?

@nolimits4web Any chance this can be added as a feature request?

@nolimits4web or @ZanderBrown any chance this feature request could be labeled?

Is this what you where looking for?

Column Parameters
When we configure Picker we need to pass cols parameter. It is an array where each item is an object with column parameters:

Parameter
Type
Default
Description

values
array

Array with string columns values

displayValues
array

Array with string columns values that will be displayed in Picker. If not specified, it will display values from valuesparameter

See docs

Thanks for the response. If I'm not mistaken, doesn't displayValues simply make the "picked" value in the input box different than the one in wheel selector? I'm looking for something that differentiates what the user sees from the server value.

As far as I'm aware it works as
If displayValues and displayValues[I]
<option value="values[I]">displayValues[I]</option>
Else
<option value="values[I]">values[I]</option>

Try it

Yes, that works, and you are correct. However, it still doesn't account for my scenario. I want the ability to be able to provide a value to my AJAX requests that is different from what the user sees. By default, just using values makes the value on both the "picked" value and "wheel" value the same. Setting displayValues differentiates the "picked" value from the "wheel value".
Both of these just deal with what the user sees, but don't let you modify the data of the AJAX data. Now consider this scenario. Let's say I'm scrolling through events I want to attend on the picker. The event could be "Cool Event". The problem is that what if my database table stores this as its numeric event id, like 874. I would like the option to store values that are not seen by the UI at all, and only the server would. This is the only reason why I can't use pickers ever and have to use a regular select instead. I think a lot of people would benefit from this, as I believe my use-case is fairly common.

It is not really possible to do on automate name, just rename the variable to what you need before sending it via XHR

Couldn't this be added as an option called serverVal, which would become the input value if specified, while the value the user sees would be something like data-shown-val to differentiate between the server value and UI value?
It would really be shame if you don't want to add this, because it would require quite a bit of extra work to use the F7 picker for my use case, which is fairly common. Selects are essentially the native version of pickers and they have <option value="server_val">Shown Value</option>. Similar to pretty much any native feature, I would prefer to use the F7 picker, as it's far more versatile. I would appreciate if this could at least be considered.


#31 Started building an order summary page for completed customer orders on back_end_experimental branch

I started building the page for order summary after user completes their order. Will need Stefan's help to complete this page.

Why do you want to merge into main? We usually merge into testing first.

Also, letting you know that it failed to build...looks like something related to some detached commit from Minh. We'll look into it tomorrow.

Also, letting you know that it failed to build...looks like something related to some detached commit from Minh. We'll look into it tomorrow.

This is a misconfiguration in the django.yml file. Github actions are set to run on push to branches and pull requests but the branch she tried to make the pull request from, backend experimental, is not in the list of branches that github actions would run on push commits. I will fix this soon.

Why do you want to merge into main? We usually merge into testing first.

That was what I meant to do, but I think I selected the wrong branch to push to. Will fix this in the morning.

Code was reworked and pushed to back_end_experimental branch


Update vim.fn.trim for nightly neovim

Describe what this PR does / why we need it
I updated my neovim to the nightly branch and broke octo.nvim when opening a PR.
Apparently vim.fn.trim is renamed to vim.trim.
Describe how you did it
Replace all occurences of vim.fn.trim to vim.trim
Describe how to verify it
Open a PR with octo.nvim
Special notes for reviews
I'm not sure if this PR should be merged for now since this is a fix for a nightly version of Neovim.

Thanks for the PR, and sorry for the late response (still on vacations). Im sorry I cannot merge the PR as is since it would break older versions. Since I still dont have access to a laptop, could you make a trim function in the utils module that calls either vim.fn.trim or vim.trim depending on which one exists?

Thank you @aaronhallaert !


vc: do not follow symlink when umounting contanier host path

So that if a guest changes it, we do not end up
propergating the error.
backport from master commit 5bf3231

Triggering a build to check this change for Power
/test-power

/test-power

/test

/test-power

/test

http://jenkins.katacontainers.io/job/kata-containers-runtime-ubuntu-18-04-PR-initrd/3083/
./rootfs-builder/rootfs.sh: line 280: /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR-initrd/go/src/github.com/kata-containers/osbuilder/rootfs-builder/*default-initrd-name/config.sh: No such file or directory

replaced by https://github.com/kata-containers/runtime/pull/2729 to add more commits to backport


[light-client] remove pending parentchain tx-inclusion check

This PR removes the parentchain tx-inclusion check, which didn't work. This led to an infinitely growing list of extrinsics with pending inclusion check in the light-client, which slowed down the block import tremendously. As the light-client was never the correct place to do that, I just removed the feature, and added a tracking issue for proper re-introduction: #1457.

Closes #1454.

I have updated the PR description. Yes, you are right that this feature is removed, but it was never complete. Because we have checked in the light-client that the extrinsic was included, but we did not check there whether the extrinsic was a success or not. So we should probably integrate this check somewhere else in the business logic, like in the indirect executor, where we are currently starting to implement checks if parentchain transfers were successful for the privacy sidechain case.


How do you get the steel upgrade?

theres no option to craft the template which suggests to me that you cant find it since it has no recipe
edit: just re read the mod description. i understand now.
but you probably should ad a way to craft it like the rest of the templates

Solved in 2.1.0


#236: Update grammar to support Swift 2.1

Resolves #236.

Current coverage is 88.41%

Merging #237 into master will decrease coverage by -0.11% as of a1a9447

@@            master    #237   diff @@
======================================
  Files           40      40
  Stmts         1621    1623     +2
  Branches       271     272     +1
  Methods          0       0
======================================
  Hit           1435    1435
- Partial         70      71     +1
- Missed         116     117     +1

Review entire Coverage Diff as of a1a9447

Powered by Codecov. Updated on successful CI builds.

:+1:


Add latest WGS84 realizations

@eliascarv it seems that the issue in some internal dispatch. I updated the tests to be more explicit about the GPS week of the WGS84 ensemble, but the tests are still failing. Can you please take a look?

@eliascarv it seems that the issue in some internal dispatch. I updated the tests to be more explicit about the GPS week of the WGS84 ensemble, but the tests are still failing. Can you please take a look?

Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.12%. Comparing base (620cfe2) to head (84aba52).
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/helmert.jl
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   95.32%   95.12%   -0.20%
==========================================
  Files          23       23
  Lines        1154     1149       -5
==========================================
- Hits         1100     1093       -7
- Misses         54       56       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The tests have been fixed


Issue/02/weight

Looks like you need to git pull base master into this branch and fix the conflict in om10/db.py before checking in again!

Oops, sorry; I did not intend to merge to your directory; I wanted to merge first with my master directory from the branch. I will merge into your directory after checking everything once again!

Also, the notebooks folder seems to have a lot of additional stuff in it (untitled notebooks, data files, pickles etc) that need cleaning out. We should try to keep the checked in notebooks to a minimum - with the code painting both the lenses and quasars at the same time, I was hoping we'd just need one "painting demo" notebook. Is it possible?

Ah, OK! See my comment about notebook consolidation though, in case you haven't done this already. Thanks, Jenny!


Graylog now expect a non-empty hostname.

Hello,
Graylog now check that host is not blank.
https://github.com/Graylog2/graylog2-server/blob/238f08d7ae0ef54ed9962d58357607b3a597c056/graylog2-server/src/main/java/org/graylog2/inputs/codecs/GelfCodec.java#L240
This patch on flowgger will help to avoid loosing logs if hostname is never given.
Thanks for the merge, build & new release, you are the best.
Signed-off-by: Pierre De Paepe<EMAIL_ADDRESS>

Merged, thanks!


SCALE: init at <IP_ADDRESS>

Description of changes
Adding package for SCALE, fixes https://github.com/NixOS/nixpkgs/issues/327469

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Some comments:

Binaries at least run, but I haven't tested functionality yet
Haven't thought how this would be used in actual use cases
Would this need to be flagged as unfree?


Feature/add audio recording

Fixes #33

@jfversluis and @cdavidyoung this is an initial bit of work to expose audio recording. Please take a look and let me know your thoughts. It is very rough but I hope that the general public API surface would work for existing known scenarios.

Well, I hate to ask such newby questions, but I am still not sure how to test this.  I see that changes were made but I am not sure whether I can download these in an updated nuget package.  I see an AudioPlayerSample project that looks like it includes updated Plugin.Maui.Audio code but I don't see where to download this much less how to build and run it.  Do you have any more hints?

@cdavidyoung you would need to clone this repo and checkout the branch or click on this link (https://github.com/jfversluis/Plugin.Maui.Audio/tree/feature/add-audio-recording) that will show you the branch and you can click the Code and then Download button

Ok, I finally figured out how to get to the branch with the recording
changes.  When I try to run the AudioPlayerSample (which works on the main
branch) I get compiler errors.  It does not seem to know about
AudioRecording.  Is this supposed to compile without error?
Charles
[image: image.png]
On Wed, Nov 30, 2022 at 2:13 AM Shaun Lawrence @.***>
wrote:

@cdavidyoung https://github.com/cdavidyoung you would need to clone
this repo and checkout the branch or click on this link (
https://github.com/jfversluis/Plugin.Maui.Audio/tree/feature/add-audio-recording)
that will show you the branch and you can click the Code and then Download
button
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1331848779,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K5VZK2LVJCVDYAHZP3WK4LC3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@cdavidyoung Windows certainly isn't in a good state. I was building on macOS so I was able to build as it doesn't support building for Windows. My main reason for asking was to see if the API surface that is currently exposed in this PR would cover your usage scenarios?

I was actually able to resolve the error and got the Windows version to
record and playback yesterday.  I'll work on getting things cleaned up
using the existing IAudioRecorder interface and then see if it meets my
needs.
Should I use this branch to check in and out as I work or should I create a
new branch?
Charles
On Thu, Dec 1, 2022 at 2:35 AM Shaun Lawrence @.***>
wrote:

@cdavidyoung https://github.com/cdavidyoung Windows certainly isn't in
a good state. I was building on macOS so I was able to build as it doesn't
support building for Windows. My main reason for asking was to see if the
API surface that is currently exposed in this PR would cover your usage
scenarios?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1333481692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K7RJ6K2ZNACX2UO5RDWLBWM3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ok, I have been playing around with the Windows platform and it seems to
work fine.  So far I would have the following suggestion for IAudioRecorder:

TimeSpan lastDuration();  This would return the duration of the last
recording or playback.  It is just a matter of adding a Timer to the
AudioRecorder partial class of each platform.

Charles
On Thu, Dec 1, 2022 at 5:04 AM Charles David Young <
@.***> wrote:

I was actually able to resolve the error and got the Windows version to
record and playback yesterday.  I'll work on getting things cleaned up
using the existing IAudioRecorder interface and then see if it meets my
needs.
Should I use this branch to check in and out as I work or should I create
a new branch?
Charles
On Thu, Dec 1, 2022 at 2:35 AM Shaun Lawrence @.***>
wrote:

@cdavidyoung https://github.com/cdavidyoung Windows certainly isn't in
a good state. I was building on macOS so I was able to build as it doesn't
support building for Windows. My main reason for asking was to see if the
API surface that is currently exposed in this PR would cover your usage
scenarios?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1333481692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K7RJ6K2ZNACX2UO5RDWLBWM3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I am getting an exception with the Android code when it tries to record
(audioRecord.StartRecording()).  I have tried adding all the permissions to
no avail.
I see this code is based on Plugin.SimpleAudioRecorder.  Was that working
for anyone previously in Xamarin?  I was using Plugin.AudioRecorder for my
Xamarin app.  Perhaps I'll try basing this Maui plugin on that instead
unless someone has an objection.
Charles
On Thu, Dec 1, 2022 at 11:25 AM Charles David Young <
@.***> wrote:

Ok, I have been playing around with the Windows platform and it seems to
work fine.  So far I would have the following suggestion for IAudioRecorder:

TimeSpan lastDuration();  This would return the duration of the last
recording or playback.  It is just a matter of adding a Timer to the
AudioRecorder partial class of each platform.

Charles
On Thu, Dec 1, 2022 at 5:04 AM Charles David Young <
@.***> wrote:

I was actually able to resolve the error and got the Windows version to
record and playback yesterday.  I'll work on getting things cleaned up
using the existing IAudioRecorder interface and then see if it meets my
needs.
Should I use this branch to check in and out as I work or should I create
a new branch?
Charles
On Thu, Dec 1, 2022 at 2:35 AM Shaun Lawrence @.***>
wrote:

@cdavidyoung https://github.com/cdavidyoung Windows certainly isn't
in a good state. I was building on macOS so I was able to build as it
doesn't support building for Windows. My main reason for asking was to see
if the API surface that is currently exposed in this PR would cover your
usage scenarios?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1333481692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K7RJ6K2ZNACX2UO5RDWLBWM3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have pushed my first changes.  Windows and Android have been tested and
are working fine.  I will move on to iOS next.
One issue is that StartAsync() blocks on Android but not on Windows.  It is
not an issue if the app takes that into account but it may be confusing.
Charles
On Thu, Dec 1, 2022 at 5:11 PM Charles David Young <
@.***> wrote:

I am getting an exception with the Android code when it tries to record
(audioRecord.StartRecording()).  I have tried adding all the permissions to
no avail.
I see this code is based on Plugin.SimpleAudioRecorder.  Was that working
for anyone previously in Xamarin?  I was using Plugin.AudioRecorder for my
Xamarin app.  Perhaps I'll try basing this Maui plugin on that instead
unless someone has an objection.
Charles
On Thu, Dec 1, 2022 at 11:25 AM Charles David Young <
@.***> wrote:

Ok, I have been playing around with the Windows platform and it seems to
work fine.  So far I would have the following suggestion for IAudioRecorder:

TimeSpan lastDuration();  This would return the duration of the
last recording or playback.  It is just a matter of adding a Timer to the
AudioRecorder partial class of each platform.

Charles
On Thu, Dec 1, 2022 at 5:04 AM Charles David Young <
@.***> wrote:

I was actually able to resolve the error and got the Windows version to
record and playback yesterday.  I'll work on getting things cleaned up
using the existing IAudioRecorder interface and then see if it meets my
needs.
Should I use this branch to check in and out as I work or should I
create a new branch?
Charles
On Thu, Dec 1, 2022 at 2:35 AM Shaun Lawrence @.***>
wrote:

@cdavidyoung https://github.com/cdavidyoung Windows certainly isn't
in a good state. I was building on macOS so I was able to build as it
doesn't support building for Windows. My main reason for asking was to see
if the API surface that is currently exposed in this PR would cover your
usage scenarios?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1333481692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K7RJ6K2ZNACX2UO5RDWLBWM3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

So when I tried to push my changes it said I did not have write
privileges.  So I created a new branch in my account.  I guess we'll figure
out how to merge it back into the main project later.  Or if someone can
give me write access I could do it sooner.
Charles
On Fri, Dec 2, 2022 at 9:34 AM Charles David Young <
@.***> wrote:

Just to keep track of things, this is what is necessary for Android.  I
added to AndroidManifest.xml

Also, it is necessary to check that this app has permission for the microphone to avoid an exception:
public async Task HavePermissionMicrophoneAsync()
{
var status = await Permissions.CheckStatusAsync<Permissions.Microphone>();
string statusNow = status.ToString();
string statusGranted = PermissionStatus.Granted.ToString();
return statusNow == statusGranted;
}
For Windows I added   to Platforms/Windows/Package.appxmanifest:

<rescap:Capability Name="runFullTrust" />

On Fri, Dec 2, 2022 at 9:24 AM Charles David Young <
@.***> wrote:

I have pushed my first changes.  Windows and Android have been tested and
are working fine.  I will move on to iOS next.
One issue is that StartAsync() blocks on Android but not on Windows.  It
is not an issue if the app takes that into account but it may be confusing.
Charles
On Thu, Dec 1, 2022 at 5:11 PM Charles David Young <
@.***> wrote:

I am getting an exception with the Android code when it tries to record
(audioRecord.StartRecording()).  I have tried adding all the permissions to
no avail.
I see this code is based on Plugin.SimpleAudioRecorder.  Was that
working for anyone previously in Xamarin?  I was using Plugin.AudioRecorder
for my Xamarin app.  Perhaps I'll try basing this Maui plugin on that
instead unless someone has an objection.
Charles
On Thu, Dec 1, 2022 at 11:25 AM Charles David Young <
@.***> wrote:

Ok, I have been playing around with the Windows platform and it seems
to work fine.  So far I would have the following suggestion for
IAudioRecorder:

TimeSpan lastDuration();  This would return the duration of the
last recording or playback.  It is just a matter of adding a Timer to the
AudioRecorder partial class of each platform.

Charles
On Thu, Dec 1, 2022 at 5:04 AM Charles David Young <
@.***> wrote:

I was actually able to resolve the error and got the Windows version
to record and playback yesterday.  I'll work on getting things cleaned up
using the existing IAudioRecorder interface and then see if it meets my
needs.
Should I use this branch to check in and out as I work or should I
create a new branch?
Charles
On Thu, Dec 1, 2022 at 2:35 AM Shaun Lawrence <
@.***> wrote:

@cdavidyoung https://github.com/cdavidyoung Windows certainly
isn't in a good state. I was building on macOS so I was able to build as it
doesn't support building for Windows. My main reason for asking was to see
if the API surface that is currently exposed in this PR would cover your
usage scenarios?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1333481692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K7RJ6K2ZNACX2UO5RDWLBWM3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

So when I tried to push my changes it said I did not have write
privileges.  So I created a new branch in my account.  I guess we'll figure
out how to merge it back into the main project later.  Or if someone can
give me write access I could do it sooner.
Charles
On Fri, Dec 2, 2022 at 9:34 AM Charles David Young <
@.***> wrote:

Just to keep track of things, this is what is necessary for Android.  I
added to AndroidManifest.xml

Also, it is necessary to check that this app has permission for the microphone to avoid an exception:
public async Task HavePermissionMicrophoneAsync()
{
var status = await Permissions.CheckStatusAsync<Permissions.Microphone>();
string statusNow = status.ToString();
string statusGranted = PermissionStatus.Granted.ToString();
return statusNow == statusGranted;
}
For Windows I added   to Platforms/Windows/Package.appxmanifest:

<rescap:Capability Name="runFullTrust" />

On Fri, Dec 2, 2022 at 9:24 AM Charles David Young <
@.***> wrote:

I have pushed my first changes.  Windows and Android have been tested and
are working fine.  I will move on to iOS next.
One issue is that StartAsync() blocks on Android but not on Windows.  It
is not an issue if the app takes that into account but it may be confusing.
Charles
On Thu, Dec 1, 2022 at 5:11 PM Charles David Young <
@.***> wrote:

I am getting an exception with the Android code when it tries to record
(audioRecord.StartRecording()).  I have tried adding all the permissions to
no avail.
I see this code is based on Plugin.SimpleAudioRecorder.  Was that
working for anyone previously in Xamarin?  I was using Plugin.AudioRecorder
for my Xamarin app.  Perhaps I'll try basing this Maui plugin on that
instead unless someone has an objection.
Charles
On Thu, Dec 1, 2022 at 11:25 AM Charles David Young <
@.***> wrote:

Ok, I have been playing around with the Windows platform and it seems
to work fine.  So far I would have the following suggestion for
IAudioRecorder:

TimeSpan lastDuration();  This would return the duration of the
last recording or playback.  It is just a matter of adding a Timer to the
AudioRecorder partial class of each platform.

Charles
On Thu, Dec 1, 2022 at 5:04 AM Charles David Young <
@.***> wrote:

I was actually able to resolve the error and got the Windows version
to record and playback yesterday.  I'll work on getting things cleaned up
using the existing IAudioRecorder interface and then see if it meets my
needs.
Should I use this branch to check in and out as I work or should I
create a new branch?
Charles
On Thu, Dec 1, 2022 at 2:35 AM Shaun Lawrence <
@.***> wrote:

@cdavidyoung https://github.com/cdavidyoung Windows certainly
isn't in a good state. I was building on macOS so I was able to build as it
doesn't support building for Windows. My main reason for asking was to see
if the API surface that is currently exposed in this PR would cover your
usage scenarios?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1333481692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K7RJ6K2ZNACX2UO5RDWLBWM3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thats awesome thank you. So in terms of committing to this branch I suspect you will need to fork from this branch/repo and then submit a Pull Request back to this branch when it is ready. I would be more than happy to guide you through that process if you aren't familiar with it?

Thanks Shaun.  I’ll let you know when I am ready to merge my changes.
Charles
El El sáb, dic. 3, 2022 a la(s) 12:30 p.m., Shaun Lawrence <
@.***> escribió:

So when I tried to push my changes it said I did not have write
privileges. So I created a new branch in my account. I guess we'll figure
out how to merge it back into the main project later. Or if someone can
give me write access I could do it sooner.
Charles
On Fri, Dec 2, 2022 at 9:34 AM Charles David Young <
@.***> wrote:
Just to keep track of things, this is what is necessary for Android. I
added to AndroidManifest.xml
Also, it is necessary to check that this app has permission for the
microphone to avoid an exception:
public async Task HavePermissionMicrophoneAsync()
{
var status = await Permissions.CheckStatusAsync<Permissions.Microphone>();
string statusNow = status.ToString();
string statusGranted = PermissionStatus.Granted.ToString();
return statusNow == statusGranted;
}
For Windows I added to Platforms/Windows/Package.appxmanifest:
<rescap:Capability Name="runFullTrust" />
On Fri, Dec 2, 2022 at 9:24 AM Charles David Young <
@.***> wrote:
I have pushed my first changes. Windows and Android have been tested and
are working fine. I will move on to iOS next.
One issue is that StartAsync() blocks on Android but not on Windows. It
is not an issue if the app takes that into account but it may be confusing.
Charles
On Thu, Dec 1, 2022 at 5:11 PM Charles David Young <
@.***> wrote:
I am getting an exception with the Android code when it tries to record
(audioRecord.StartRecording()). I have tried adding all the permissions to
no avail.
I see this code is based on Plugin.SimpleAudioRecorder. Was that
working for anyone previously in Xamarin? I was using Plugin.AudioRecorder
for my Xamarin app. Perhaps I'll try basing this Maui plugin on that
instead unless someone has an objection.
Charles
On Thu, Dec 1, 2022 at 11:25 AM Charles David Young <
@.***> wrote:
Ok, I have been playing around with the Windows platform and it seems
to work fine. So far I would have the following suggestion for
IAudioRecorder:

TimeSpan lastDuration(); This would return the duration of the
last recording or playback. It is just a matter of adding a Timer to
the
AudioRecorder partial class of each platform.

Charles
On Thu, Dec 1, 2022 at 5:04 AM Charles David Young <
@.***> wrote:
I was actually able to resolve the error and got the Windows version
to record and playback yesterday. I'll work on getting things cleaned up
using the existing IAudioRecorder interface and then see if it meets my
needs.
Should I use this branch to check in and out as I work or should I
create a new branch?
Charles
On Thu, Dec 1, 2022 at 2:35 AM Shaun Lawrence <
@.***> wrote:
@cdavidyoung https://github.com/cdavidyoung
https://github.com/cdavidyoung Windows certainly
isn't in a good state. I was building on macOS so I was able to build as it
doesn't support building for Windows. My main reason for asking was to see
if the API surface that is currently exposed in this PR would cover your
usage scenarios?
—
Reply to this email directly, view it on GitHub
#35 (comment)
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1333481692
,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K7RJ6K2ZNACX2UO5RDWLBWM3ANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>
Thats awesome thank you. So in terms of committing to this branch I
suspect you will need to fork from this branch/repo and then submit a Pull
Request back to this branch when it is ready. I would be more than happy to
guide you through that process if you aren't familiar with it?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/pull/35#issuecomment-1336240484,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHE7K4DRNIDBUD53O3JWILWLONWVANCNFSM6AAAAAASCVYUUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Introduce injectStylesAs config for html plugin

This PR introduces a injectStylesAs configuration to set the inject behavior for CSS imports in JavaScript modules.
It should fix #172

Thank you for your hard work @edoardocavazza !
This is required for CSS in Svelte files loaded via esbuild-svelte to not cause a flash of unstyled content.
Until this PR is merged I've isolated eslint-plugin-html with this patch into a drop-in replacement.


Huge bandwidth usage

(Mirror: http://i.imgur.com/exolwoT.png)
I think this was an Alarm Managing issue. Yesterday I changed my date to today's date to test a different app. Then today this happened. Ouch. Good thing I was on Wifi!
After a reboot everything went back to normal. Am monitoring the usage now.

I just had a similar issue on my Nexus 5 on Android 5.0.1. The new wallpaper kept loading in a loop in the background for one day, consuming about 38GB of data on my internet connection... I ocured with some wallpapers but not all and was reproductible after a reboot. While loading the wallpaper in Muzei, I see the animated loading logo appear and disappear in a loop for the incriminated wallpaper.
Then I uninstalled and reinstalled Muzei and the problem disappeared; I could load the failing wallpapers. Which makes me think it's probably a cache issue that you should investigate.

Muzei's sync infrastructure has been rebuilt entirely from the ground up, obsoleting this issue.
In addition, Muzei 3.0's new API moves downloading artwork to the other app, which should make it much easier to determine if a specific source is misbehaving.


Use scrollAnimation when scrolling to index

Setting scrollAnimation to false in a LineChart does not disable the initial animation for scrollToIndex. I am passing scrollAnimation to scrollRef.current.scrollTo so the scrollAnimation is applied for scrollToIndex.
Issue: https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/issues/859

Thanks for the PR @dannybit
Your changes are available from versions 1.4.44 onwards. 🎉


updating freezes

When updating, it freezes for a long time because of malwaredomainlist.com
$ python3 updateHostsFile.py
Do you want to update all data sources? [Y/n]
Updating source extensions/fakenews from https://raw.githubusercontent.com/marktron/fakenews/master/fakenews
Updating source extensions/social from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/social-hosts
Updating source extensions/porn/sinfonietta from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/pornography-hosts
Updating source extensions/porn/sinfonietta-snuff from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/snuff-hosts
Updating source extensions/porn/clefspeare13 from https://raw.githubusercontent.com/Clefspeare13/pornhosts/master/<IP_ADDRESS>/hosts
Updating source extensions/gambling from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/gambling-hosts
Updating source data/yoyo.org from https://pgl.yoyo.org/adservers/serverlist.php?hostformat=hosts&mimetype=plaintext&useip=<IP_ADDRESS>
Updating source data/mvps.org from http://winhelp2002.mvps.org/hosts.txt
Updating source data/someonewhocares.org from http://someonewhocares.org/hosts/zero/hosts
Updating source data/tyzbit from https://raw.githubusercontent.com/tyzbit/hosts/master/data/tyzbit/hosts
Updating source data/StevenBlack from https://raw.githubusercontent.com/StevenBlack/hosts/master/data/StevenBlack/hosts
Updating source data/Badd-Boyz-Hosts from https://raw.githubusercontent.com/mitchellkrogza/Badd-Boyz-Hosts/master/hosts
Updating source data/add.Dead from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Dead/hosts
Updating source data/malwaredomainlist.com from https://www.malwaredomainlist.com/hostslist/hosts.txt
Problem getting file:  https://www.malwaredomainlist.com/hostslist/hosts.txt
Error in updating source:  https://www.malwaredomainlist.com/hostslist/hosts.txt
Updating source data/add.2o7Net from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.2o7Net/hosts
Updating source data/SpotifyAds from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/SpotifyAds/hosts
Updating source data/add.Risk from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Risk/hosts
Updating source data/add.Spam from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Spam/hosts
Updating source data/UncheckyAds from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/UncheckyAds/hosts
Updating source data/adaway.org from https://raw.githubusercontent.com/AdAway/adaway.github.io/master/hosts.txt
Updating source data/KADhosts from https://raw.githubusercontent.com/azet12/KADhosts/master/KADhosts.txt
Do you want to exclude any domains?

Hi Bram @stolk.
Can you try this again?  It's not uncommon to have issues reaching some domains sometimes.

Nice welcoming bot Steven @StevenBlack :+1:
Back to our issue,
What we can note:

a wget  or curl

of https://www.malwaredomainlist.com/hostslist/hosts.txt ==> doesn't work
of http://www.malwaredomainlist.com/hostslist/hosts.txt ==> works

don't know which file to change but I currently have time to write a PR if you want.
Have a nice day/night.

@funilrys yes, @probot is pretty cool.
Yes a PR would be awesome!

@funilrys both are working for me now, from central Canada.

Still pauses a minute or so from Vancouver, BC.
But this time it did not report "Problem getting file" so I assume it eventually got it.

My results were from Germany as I live there but using a Canadian, France or even a Spanish  IP there's no problem ...
The problem is somewhere else ... Do we have an implemented timeout @StevenBlack ? :thinking:

@funilrys Nissar I would entertain a PR for timing out requests on fetching sources.  One that does not clobber the existing hosts file with an empty one upon timeout....

https://www.malwaredomainlist.com/hostslist/hosts.txt appears to be taking unnecessarily long but browser access from a Finnish 4G LTE IP and a wget access from an American one both work, with the former taking something half a minute to handshake the TLS and the latter a few extra seconds than usual it should with TLS.

Not sure about this one @stolk may confirm this but this may also be fixed by #520 as I could download that file and even bigger files without any problem @StevenBlack :thinking:

Hi @StevenBlack,
This one may be closed due to the lack of feedback after #520 and its child PR.


Add test_json_map.py and default_map.json

implement an officially supported map file format instead of this example

So we should research typical map file formats?

Your format is fine, but I'd like to move the parser function to map_config.py.
We should also consider to change the map_definition parameter of Simulator_v2 to either MapDefinition or string such that the simulator can figure out the parsing internally.

We could consider handling maps as svg files, which would reduce the importance of a map editor. Drawing svg maps, obstacles and routes could be easier and different classes are identified by color coding?

SVG Map is a very bloated format. It's very hard to parse and manually edit. The only advantage would be that OpenStreetMap uses this format, so you can get access to real map data. But even then, proportions are not 1:1.

I've added your default map and map parser logic into the project and pushed it to main. We can think about official map formats at a later stage of this project. For now, I'll close your PR. Thank you for your contribution.


Update s3, sdk-core, sqs to 2.17.134

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.121 to 2.17.134.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #432.


Isolate Rollbar loading from the rest of the application code

So that if there are fatal things like parse errors, monitoring still works.  This has three changes aimed at improving JS error reporting.
First, it inlines the Rollbar monitoring code into the application template, so that it runs and loads independently of what our application code does.  It's not compiled in the build process and the intention is that it will almost never change.  In order to respect environmental config (eg don't report local development errors), it reads those values from application code on-demand at error time.  If it can't read the environment config, it defaults to reporting.  https://rollbar.com/somerville-teacher-tool/somerville-teacher-tool/items/47/ Shows an example of this that was generated by reproducing the error with IE parsing Harmony code on the demo site.
Second, it adds an environment variable for SHOULD_REPORT_ERRORS and I set that to be true for the demo site as well.  Previously it had just checked SHOULD_REPORT_ANALYTICS so this splits that out with the idea that error reporting is always on, and deploying this would add monitoring to the demo site.
Third, since the demo site runs in "production" mode, this also reports the deploymentKey from the environment config so that we can distinguish between errors coming from demo or production site (you can also tell by the URL).  The intent here is similar to the deploy script improvements, to treat the demo site as a first class deployment.

need to test this locally with https://github.com/studentinsights/studentinsights/pull/1028 and see if it would catch it (working around the Env check).

@alexsoble @jhilde Does this seem reasonable?

@kevinrobinson Yeah seems really smart!

Confirmed logging errors works like normal: https://rollbar.com/somerville-teacher-tool/somerville-teacher-tool/items/48/


Added:  automatic version increment and CFF self-maintenance

This PR fixes #68.  I will add a review with explanations of my changes in the following.

I'm planning to make a minor release in a couple few days, then we can test this and see its magic :tada:


Error while trying to load the model

Hello everyone,
After training the model, I have tried to load the model,
when I execute this command" neuralcoref.add_to_pipe(nlp)"
this error pops out :
`ExtraData                                 Traceback (most recent call last)
 in
----> 1 neuralcoref.add_to_pipe(nlp)
~/neuralcoref/neuralcoref/init.py in add_to_pipe(nlp, **kwargs)
40
41 def add_to_pipe(nlp, **kwargs):
---> 42     coref = NeuralCoref(nlp.vocab, **kwargs)
43     nlp.add_pipe(coref, name="neuralcoref")
44     return nlp
neuralcoref.pyx in neuralcoref.neuralcoref.NeuralCoref.init()
neuralcoref.pyx in neuralcoref.neuralcoref.NeuralCoref.from_disk()
~/anaconda3/envs/coref1/lib/python3.8/site-packages/thinc/neural/_classes/model.py in from_bytes(self, bytes_data)
353
354     def from_bytes(self, bytes_data):
--> 355         data = srsly.msgpack_loads(bytes_data)
356         weights = data[b"weights"]
357         queue = [self]
~/anaconda3/envs/coref1/lib/python3.8/site-packages/srsly/_msgpack_api.py in msgpack_loads(data, use_list)
27     # msgpack-python docs suggest disabling gc before unpacking large messages
28     gc.disable()
---> 29     msg = msgpack.loads(data, raw=False, use_list=use_list)
30     gc.enable()
31     return msg
~/anaconda3/envs/coref1/lib/python3.8/site-packages/srsly/msgpack/init.py in unpackb(packed, **kwargs)
58         object_hook = kwargs.get('object_hook')
59         kwargs['object_hook'] = functools.partial(_decode_numpy, chain=object_hook)
---> 60     return _unpackb(packed, **kwargs)
61
62
_unpacker.pyx in srsly.msgpack._unpacker.unpackb()
ExtraData: unpack(b) received extra data.
`
Does anyone have a solution for this error please ?

Can you produce a minimal script that shows the error - preferably with some sample/dummy data?

hello @svlandeg ,
i have resoved this problem, but now when i'm loading the model and after adding it to the pipeline, when i try to test the model , for example when i run this command
>doc = nlp('je suis Firas Frikha')

I get this error :
---------------------------------------------------------------------------
ShapeMismatchError                        Traceback (most recent call last)
<ipython-input-11-3c410e4249d4> in <module>
----> 1 doc = nlp('je suis Firas Frikdfha')

~/anaconda3/envs/coreference/lib/python3.8/site-packages/spacy/language.py in __call__(self, text, disable, component_cfg)
    447             if not hasattr(proc, "__call__"):
    448                 raise ValueError(Errors.E003.format(component=type(proc), name=name))
--> 449             doc = proc(doc, **component_cfg.get(name, {}))
    450             if doc is None:
    451                 raise ValueError(Errors.E005.format(name=name))

neuralcoref.pyx in neuralcoref.neuralcoref.NeuralCoref.__call__()

neuralcoref.pyx in neuralcoref.neuralcoref.NeuralCoref.predict()

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/neural/_classes/model.py in __call__(self, x)
    165             Must match expected shape
    166         """
--> 167         return self.predict(x)
    168
    169     def pipe(self, stream, batch_size=128):

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/neural/_classes/feed_forward.py in predict(self, X)
     38     def predict(self, X):
     39         for layer in self._layers:
---> 40             X = layer(X)
     41         return X
     42

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/neural/_classes/model.py in __call__(self, x)
    165             Must match expected shape
    166         """
--> 167         return self.predict(x)
    168
    169     def pipe(self, stream, batch_size=128):

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/check.py in checked_function(wrapped, instance, args, kwargs)
    153                 if not isinstance(check, Callable):
    154                     raise ExpectedTypeError(check, ["Callable"])
--> 155                 check(arg_id, fix_args, kwargs)
    156         return wrapped(*args, **kwargs)
    157

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/check.py in has_shape_inner(arg_id, args, kwargs)
     72             # Allow underspecified dimensions
     73             if dim is not None and arg.shape[i] != dim:
---> 74                 raise ShapeMismatchError(arg.shape, shape_values, shape)
     75
     76     return has_shape_inner

ShapeMismatchError:

  Shape mismatch: input (0, 668) not compatible with [None, 3924].

  Traceback:
  ├─ __call__ in /home/firas/anaconda3/envs/coreference/lib/python3.8/site-packages/spacy/language.py:449
  ├─── __call__ in neural/_classes/model.py:167
  └───── predict in neural/_classes/feed_forward.py:40
         >>> X = layer(X)

In training, ihave used fastext embedding for french:
the size embedding of the vector is 300
i changed all the constants in the utils.py but this error keep persisting.
I hope if you can help, because i'm stuck on this error for weeks now,
Thank you

As the original issue is resolved, and the new issue is a duplicate from #269, I'll close this specific issue to keep the discussion in one place.

hello @svlandeg ,
i have resoved this problem, but now when i'm loading the model and after adding it to the pipeline, when i try to test the model , for example when i run this command
>doc = nlp('je suis Firas Frikha')

I get this error :
---------------------------------------------------------------------------
ShapeMismatchError                        Traceback (most recent call last)
<ipython-input-11-3c410e4249d4> in <module>
----> 1 doc = nlp('je suis Firas Frikdfha')

~/anaconda3/envs/coreference/lib/python3.8/site-packages/spacy/language.py in __call__(self, text, disable, component_cfg)
    447             if not hasattr(proc, "__call__"):
    448                 raise ValueError(Errors.E003.format(component=type(proc), name=name))
--> 449             doc = proc(doc, **component_cfg.get(name, {}))
    450             if doc is None:
    451                 raise ValueError(Errors.E005.format(name=name))

neuralcoref.pyx in neuralcoref.neuralcoref.NeuralCoref.__call__()

neuralcoref.pyx in neuralcoref.neuralcoref.NeuralCoref.predict()

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/neural/_classes/model.py in __call__(self, x)
    165             Must match expected shape
    166         """
--> 167         return self.predict(x)
    168
    169     def pipe(self, stream, batch_size=128):

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/neural/_classes/feed_forward.py in predict(self, X)
     38     def predict(self, X):
     39         for layer in self._layers:
---> 40             X = layer(X)
     41         return X
     42

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/neural/_classes/model.py in __call__(self, x)
    165             Must match expected shape
    166         """
--> 167         return self.predict(x)
    168
    169     def pipe(self, stream, batch_size=128):

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/check.py in checked_function(wrapped, instance, args, kwargs)
    153                 if not isinstance(check, Callable):
    154                     raise ExpectedTypeError(check, ["Callable"])
--> 155                 check(arg_id, fix_args, kwargs)
    156         return wrapped(*args, **kwargs)
    157

~/anaconda3/envs/coreference/lib/python3.8/site-packages/thinc/check.py in has_shape_inner(arg_id, args, kwargs)
     72             # Allow underspecified dimensions
     73             if dim is not None and arg.shape[i] != dim:
---> 74                 raise ShapeMismatchError(arg.shape, shape_values, shape)
     75
     76     return has_shape_inner

ShapeMismatchError:

  Shape mismatch: input (0, 668) not compatible with [None, 3924].

  Traceback:
  ├─ __call__ in /home/firas/anaconda3/envs/coreference/lib/python3.8/site-packages/spacy/language.py:449
  ├─── __call__ in neural/_classes/model.py:167
  └───── predict in neural/_classes/feed_forward.py:40
         >>> X = layer(X)

In training, ihave used fastext embedding for french:
the size embedding of the vector is 300
i changed all the constants in the utils.py but this error keep persisting.
I hope if you can help, because i'm stuck on this error for weeks now,
Thank you

any update for this ?


Feature request: dynamic redirect

This request is for 2.0.
The non-exact route matching strategy is good, so that we can define a router-link as the entrance of one module which contains several subroutes and the router-link remains active when we are navigating in this module.  It is common that this router-link is defined as a redirect to some default subroute, e.g.:
var router = new VueRouter({
  routers:[{
     path: '/entry', redirect: '/entry/subroute'
  }, {
     path: '/entry/subroute', component: SubRoute
  }, {
     path: '/entry/anothersubroute', component: AnotherSubRoute
  }]
})

<router-link to="/entry">Entry</router-link>
<router-link to="/anothermodule">AnotherModule<router-link>

Every time we click the Entry link , we go to SubRoute, even if last time when we left Entry module we were at AnotherSubRoute.
If we want the router-link to be smart enough to go to the last subroute we visit in Entry module, we must first save where we were in Entry module some place, such as a store.
var store = {
    last_entry_route: ''
}

and update it whenever we enter a subroute.
Currently we can use an extra component to achieve the dynamic behavior:
const DynamicRedirect = Vue.extend({
  render(){
    this.$router.replace(store.last_entry_route)
  }
})

and use it like this:
{path: '/entry', component: DynamicRedirect}

But this is quite a bit of code, and doing just a route redirect in render function does not feel quite right. I wish we can have a function as the redirect target of a route, i.e.
{path:'/entry', redirect: () => store.last_entry_route}

@posva @yyx990803 I think this is a nice-to-have feature! Should we implement it?

@fnlctrl sounds good - feel free to give it a shot!

@yyx990803 Will do! :smile:

@fnlctrl  I think it's a nice idea too!

Implemented: https://github.com/vuejs/vue-router/pull/634

Closing as it has landed in rc.5


Preventing creation of Stack root

Hello,
I am trying to create Dockerfile for a profile for JupyterHub.
After some time, I managed to successfully create the docker image and install the kernel.
The biggest hurdle was and is that the kernel and the resulting files do not end up in the /home/jovyan directory.
Unfortunately, the notebook or the kernel throws me the following error message.
Preventing creation of Stack root ‘/home/jovyan/.stack/’. Parent directory ‘/home/jovyan/’ is owned by someone else. ihaskell: readCreateProcess: stack ‘exec’ ‘env’ (exit 1): failed
I have observed that files are still copied to /home/jovyan/.stack/ when building?
The problem is that I can't use /home/jovyan as a directory for the kernel files. Because when the server starts for the user, his storage is mounted to /home/jovyan.
I hope you can help me with my problem.
Thank you very much
Dockerfile
ARG BASE_IMAGE=quay.io/jupyter/minimal-notebook:hub-4.1.5
FROM ${BASE_IMAGE}

USER root

RUN apt-get update
RUN apt-get install -y libtinfo-dev libzmq3-dev libcairo2-dev libpango1.0-dev libmagic-dev libblas-dev liblapack-dev
RUN curl -sSL https://get.haskellstack.org/ | sh

USER ${NB_UID}

RUN pwd
RUN git clone https://github.com/gibiansky/IHaskell /tmp/IHaskell
WORKDIR /tmp/IHaskell
RUN stack install --fast --local-bin-path /tmp/IHaskellKernel
RUN /tmp/IHaskellKernel/ihaskell install --stack --prefix /opt/conda

WORKDIR /home/jovyan

USER ${NB_UID}
RUN fix-permissions "${CONDA_DIR}"
RUN fix-permissions "/home/${NB_USER}"

Can you try this?

Where are you being explicit about GHC 9.6.4? I can't see it in the Dockerfile.
This looks like a bug I fixed with https://github.com/IHaskell/IHaskell/commit/b223a6c2d0d0e812c4d77c062cc82ac7df8f8eca, I'm surprised you're seeing it again

There is an alternative Dockerfile here that you might try.
https://github.com/IHaskell/ihaskell-notebook
This Dockerfile does not install anything in /home/jovyan.


[BUG] Moving a jump up changes what jumps have suspend drawbacks from the Drawback Supplement

Describe the bug
If you where to move a jump pass another jump which has a suspened drawback from the drawback supplement (I am using the U.U. Suplement) it changes in which jump the drawback is being suspened.
To Reproduce
Steps to reproduce the behavior:

Create 2 jumps
Make a drawback in the Drawback supplement
Supend the drawback during jump #2
Create a new jump
Move newest jump to the top
Check jump budgets to see change (It won't show under drawback supplements untill you do something to update it like make a new drawback or click on another drawback)

Expected behavior
Expected behavior is for the jump in which the drawback was suspend to keep said drawback suspened

Thanks for the report, this bug should be fixed in the next update.


KAFKA-9756: Process more than one record of one task at a time

Within a single while loop, process the tasks in AAABBBCCC instead of ABCABCABC. This also helps the follow-up PR to time the per-task processing ratio to record less time, hence less overhead.

Add thread-level process / punctuate / poll / commit ratio metrics.

Fixed a few issues discovered (inline commented).

I am adding metrics test coverage for 2) above in another PR, which added more sensor / metrics.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

test this please

test this please

test this please

test this please

Oh, yeah, regarding your "benchmark":

Somehow on my local laptop the streams test suite time reduced by 35% out of this branch (not sure if this is really because of the change here), but worth running the benchmark to verify if there's significant perf improvement after merged to trunk.

FYI, I ran ./gradlew clean :streams:test locally, and I got : BUILD SUCCESSFUL in 11m 47s vs. BUILD SUCCESSFUL in 12m 32s on trunk. Pretty promising, actually.

@vvcephei Addressed comments.

test this please

test this please


[POC] Model Driven SSO Configuration POC

This is a really old piece of work and is by no means ready for review. Wanted to submit the PR as a jumping off point on using database objects and/or constant config to back SSO configuration.

Going to squash this into a prototype branch, it's a take at #2547 along with #2549.
Also easier facilitation of multiple SSO backends.