Strange bahaviour with RecyclerView

Hello everybody,
I'm implementing MaterialViewPager with several fragments. One of them is a simple RecyclerView. This is my fragment XML
<?xml version="1.0" encoding="utf-8"?>
<com.github.ksoichiro.android.observablescrollview.ObservableScrollView
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/scrollView"
android:layout_width="match_parent"
android:layout_height="match_parent">

<LinearLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical">

    <include layout="@layout/material_view_pager_placeholder" />

    <android.support.v7.widget.RecyclerView
        android:id="@+id/details_list"
        android:layout_width="match_parent"
        android:layout_height="300dp">

    </android.support.v7.widget.RecyclerView>

</LinearLayout>
</com.github.ksoichiro.android.observablescrollview.ObservableScrollView>

and this is my main activity xml:
<com.github.florent37.materialviewpager.MaterialViewPager
android:id="@+id/materialViewPager"
android:layout_width="match_parent"
android:layout_height="match_parent"
app:viewpager_pagerTitleStrip="@layout/my_tabs"
app:viewpager_logoMarginTop="100dp"
app:viewpager_headerHeight="200dp"
app:viewpager_headerAlpha="1"
app:viewpager_color="@color/hc_blu_toolbar"
app:viewpager_hideLogoWithFade="true"
app:viewpager_hideToolbarAndTitle="false"
android:textColor="@android:color/white"
app:viewpager_enableToolbarElevation="true"
app:viewpager_parallaxHeaderFactor="1.5"
app:viewpager_headerAdditionalHeight="0dp"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" />

Now, what happens is that while custom layouts (for other fragments) without listViews or recyclerVires get loaded smoothly, with header picture and all, this RecyclerView of mine behaves strangely: it seems like there's a huge padding above the recyclerView itself and a smaller one above it. Also, picture is not loaded in the header.
This is a sort of screencast I made in order to let you know what I'm talking about.

I think all is fine in my code, of course. Recyclerview's content are the ones I expect and everything works, except for this bad, bad behaviour when scrolling and the too-large-top-and-bottom-paddings.
I have no clue about how to get out of this. Do you have any idea?
Thank you

As you can see, on another layout (of the same viewPager) everything works smoothly.
Layout:

<com.github.ksoichiro.android.observablescrollview.ObservableScrollView xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/scrollView"
android:layout_width="match_parent"
android:layout_height="match_parent">
<LinearLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical">

    <include layout="@layout/material_view_pager_placeholder" />

    <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:visibility="gone">

        <RelativeLayout
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_gravity="top|right"
            android:layout_marginRight="10dp">

            <RatingBar
                android:id="@+id/hotel_stars"
<EMAIL_ADDRESS>                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:clickable="false"
                android:focusable="false"
                android:isIndicator="true"
                android:numStars="5"
                android:rating="0"
                android:stepSize="0.1" />

        </RelativeLayout>

    </FrameLayout>

    <TextView
        android:id="@+id/hotel_name"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:autoText="true"
        android:textAlignment="gravity"
        android:paddingTop="10dp"
        android:paddingBottom="5dp"
        style="@style/hotelNameForDetails" />

    <Button
        android:layout_marginTop="20dp"
        android:id="@+id/book_now"
<EMAIL_ADDRESS>        android:minHeight="55dp"/>

    <TextView
        android:id="@+id/hotel_address"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:paddingLeft="@dimen/details_padding_left"
        android:paddingRight="@dimen/details_padding_left"
        android:paddingTop="15dp"
        android:paddingBottom="10dp"
        android:textSize="@dimen/details_text_size" />

    <TextView
        android:id="@+id/hotel_details_description"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        style="@style/hotelDescriptionForDetails"/>

</LinearLayout>

</com.github.ksoichiro.android.observablescrollview.ObservableScrollView>
Result:

Please do not use ScrollView & RecyclerView, choose only One :smile:

Thank you Florent,
I tried and it almost works.
Just of couple of questions:
1- It almost works, but doesn't really work. I get the right animation in the ViewPager but the margin above the list is still huge and the list does not scroll completely until the ViewPager entries. You can see what I mean in the picture below.
(Also the header pictures loads every now and then, but I think this is due to another bug still open so I don't see it much as a issue right now.)

2- Replacing the ScrollView with the RecyclerView is ok for this purpose, since I don't need to have anything above my RecyclerView. But what if I need to have a vertical Linear Layout with a TextView and, below that, a list of items? I don't want the list of items to be scrollable, I just want it to overflow the screen just like the text in the screenshot above. Once the user scrolls, the whole list should scroll up together with the Textview above and behave just like the screenshot above (but better).
Thank you

Ok,
I tried with the ListView.
This is the layout:
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical">

<include layout="@layout/material_view_pager_placeholder" />

<TextView
    style="@style/grey_header_textview"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:layout_marginTop="20dp"
    android:text="@string/requested_rooms" />

<TextView
    android:id="@+id/search_type"
    style="@style/white_blue_text_textview"
    android:layout_width="match_parent"
    android:layout_height="wrap_content" />

<TextView
    style="@style/grey_header_textview"
    android:layout_width="match_parent"
    android:layout_height="wrap_content" />

<com.towers.hotelsclick.utils.TariffsListView
    android:id="@+id/tariffs_list"
    android:layout_width="match_parent"
    android:layout_height="300dp">

</com.towers.hotelsclick.utils.TariffsListView>

</LinearLayout>

And this is what happens:

:-/ Do you have any suggestion for me or is this something I can't achieve with MaterialViewPager? (I hope not, it took me a certain effort to come to this point :-) )
Thank you

Please do not use ListView & ScrollView at the same time, please choose...
And do not use ListView, use RecyclerView
Just use your TariffsListView and fill it with your content.
In your case the listview is below your material_view_pager_placeholder so il only get 1/2 of screen help...
<com.towers.hotelsclick.utils.TariffsListView
android:id="@+id/tariffs_list"
android:layout_width="match_parent"
android:layout_height="match_parent">
</com.towers.hotelsclick.utils.TariffsListView>

Florent,
I don't want to be offensive, but your reply was not so helpful. I had already removed the ScrollView, as you can see by the example I provided. The only ScrollView I had now was in the layout without ListView or RecyclerView, which worked (and had always been).
Anyway your reply was somehow useful because it got me the idea to remove the material_view_pager_placeholder, which apparently is not needed when using just a ListView or RecyclerView. Finally I made it by removing such layout and setting the height of the RecyclerView to match_parent.
Thus, I didn't know how to have a layout above my ListView, since apparently I can only choose between "any layout, without lists" or "just list". I got what I wanted by using a composite RecyclerView with a header and a list of regular items. Maybe one of these days I'll be posting a small tutorial about it, since I guess many others will face this issue after me.
Regards

You have forgotten to document that the adapter of the recyclerview must be new RecyclerViewMaterialAdapter

sorry .. i have same issue
how i can fix it ...
when recyclerView scrolling same item get hidden


Init

This PR introduces the JSON Client, Request and Response that will form the basis of any API that both expects and returns JSON.

I guess Composer can't resolve that and we'll need to keep both up to date.

If we follow Semantic versioning principles Composer can do a pretty good job.  But yes, I expect we'll want to keep stuff like this a lot more up-to-date than we have done in the past.  That's part of the point though.  I want to set a policy like "first of the month we update minor versions, once a quarter we take major versions" or something like that.


Add training data for Canadian Addresses

us-address mostly works out of the box with (English-language) Canadian
addresses however it often misparses postal codes. This training
data adds dozen or so Canadian addresses chosen by randomly looking
them up on OSM Map. There is one address per province to ensure Provinces
are also properly recognized.
The training and test data resides in canada.xml of the respective
folders.
It is worth noting that while us-address uses ZipCode and StateName, in
Canadian parlance these are Postal-Code and Provinces.

This change also addresses https://github.com/datamade/usaddress/issues/115


PerItem +Display(FormatMethod)

Hello Again Vexe, I was wondering if there is any way to dynamically format an array perItem according to each Item properties. (Probably carrying an Index or the object itself)
Display(FormatMethod) works great for all items, but It doesn't carry the object i think.
	[PerItem, Display(FormatMethod = "FormatArray")]
	public List<UAE_Dialogue_BaseNode> DialogList = new List<UAE_Dialogue_BaseNode>();

	// gets called from editor
	string FormatArray(int index)
	{
		return "# " + DialogList[index] + " - " + DialogList[index].Actor.Name;
                //Example output:
                // #0 - Player
                // #1 - John
	}

or
[PerItem, Display(FormatMethod = "FormatArray")]
	public List<UAE_Dialogue_BaseNode> DialogList = new List<UAE_Dialogue_BaseNode>();

	// gets called from editor
	string FormatArray(UAE_Dialogue_BaseNode node)
	{
		return node.Actor.Name + ":" + node.Text;
                //Example output:
                // Player: Hello
                // John: Hi
	}

Another workaround could be change the label of each instance:

Thanks!!

Right. Actually the first version of FormatMethod used to take an instance object, but then i saw that I'm only using it to display collection count, obviously forgetting about using it PerItem. I also need to fix the fact that the sequence should ignore Display if it's applied on its elements.
There's not much can be done about the 'instance label' in your case since they're Unity objects. If they were System objects you could override their ToString and it would show whatever you specify for that element's ToString.

Thanks! the ToString override did the trick!! Very useful!


Fix context isolation for Scenario Outlines

This PR fixes context isolation for Scenario Outlines. It achieves that without BC breaks by implementing additional tester decorator - IsolatingScenarioTester. It's a bit clunky, but totally working solution until the next major, when we can break BC.

:+1:


Fix UTF-8 encoding issue in LoggedRequest

Setting the UTF-8 encoding for the request body in LoggedRequest.
The verify method fails when the request contains non-Latin chars if the machine running the tests has a default charset other than UTF-8.
Fixed it by setting encoding of the String returned by getBodyAsString(), just like it is done in Jetty6HttpServletRequestAdapter.
Also removed some exception constructors that were failing compilation on Java 1.6.

Please can you add some tests to this PR

Unit test implemented as requested.

Merged with rebase.

Thanks!

Hi,
I noticed you didn't accept this PR. Have you seen any issues with it besides the tests?
Do you have a better fix in mind?
Thanks,

Quenio

Sorry. Never mind about my previous inquiry. I just saw your merge as a rebase. I was fooled by the message above "Closed with unmerged commits".

Yep, merged in full and released!


Write invitation for TSC user journey validation workshops

Here's what I've come up with so far. I didn't use the term "workshop" because I thought that may sound like more time/effort than would actually be required for participants.
Subject line: CONSEP workflow validation session: Cone and Seed Processing
Subject line: CONSEP workflow validation session: Quality Assurance
Subject line: CONSEP workflow validation session: Inventory Management
Message body:
Thanks once again for your time and input walking us through how you use CONSEP for day-to-day activities.
We’ve taken what we heard during our CONSEP user interviews and mapped out different user journeys based on job type and associated workflows.
The next step is to schedule a brief review session to share what we mapped out, and confirm whether we captured all the relevant steps and information, or whether further details could be added or clarified.
This validation step is to make sure we don’t miss any key features or functionalities as we design new CONSEP screens.
Thank you for your participation, and feel free to suggest an alternative time if this timeslot won’t work.

@kevinginley good call not using the term workshop - I agree with you!
The invitation looks great :) Will you and @mmarsoleta want to do this with the different user groups between January 10th and January 19th? This would give you a couple of days to prepare after getting back from your holidays


In ubuntu repo it's very outdated and python 2 only.

That made it, thanks.


Using a composite value as label

I am wondering if the following is possible. We have a User model where the username is an id, so humans can identify User objects by first name and last name.
Is it possible to use the concatenation of first name and last name, i.e. full name as the label_field and display that in the selection list? (Ideally without adding/modifying the User model)

Sorry it took a year to get back to you on this 😖
Finally had time to do a full update of this package, along with examples. The way to approach this would be to use the tabular option, which would allow you to have the first name in a column and the last in another. Either or both could be searchable.
This is what it would look like in your project.
autocomplete view:
class UserAutocompleteView(AutocompleteModelView):
    """Autocomplete that returns all User objects."""

    model = User
    search_lookups = ["first_name__icontains", "last_name__icontains"]
    page_size = 20
    value_fields = ["id", "first_name", "last_name"]

forms.py
class UserSelectionForm(forms.Form):
    tomselect_tabular = TomSelectModelChoiceField(
        config=TomSelectConfig(
            url="autocomplete-user",
            value_field="id",
            label_field="first_name",
            highlight=True,
            open_on_focus=True,
            preload="focus",
            plugin_dropdown_header=PluginDropdownHeader(
                show_value_field=False,
                label_field_label="First",
                extra_columns={"last_name": "Last"},
            )
        )
    )

I know you probably moved on a long time ago since I failed to reply, but if you ever want to evaluate this package for your projects again, we now have detailed docs and 15 different usage examples in the example project.


Change ONNX default record type to NamedMpk

Pull Request Template
Related Issues/PRs
This temporarily workaround of #952 bug.
Changes
This temporarily workaround of #952 bug changes ONNX default record type to NamedMpk.
Testing
Tested on the ONNX file linked in #952.

Thanks for the patch 😄 are you planning on investigating the problem with NamedMpkGz further?

Yes! We will keep the bug issue open.


[4376] remove add user button from lead school show page

Context
Users should be added via the 'Users' page not the lead school page so we no longer need the button and associated code.
Changes proposed in this pull request
Remove the button and associated tests.

 Remove the 'Add user' button from the lead school show page


Alt text for close button on grey overlay

Description
Please provide a short description of the issue here, along with:
Actual Behavior:
The close link (highlighted in the screenshot) does not have alternative text.

Expected Behavior:
The close button should be a button, not a link.
Add alt="Close" to this button
Optional signup (tmart.com)
https://secure.tmart.com/users/cart.html?referer_site=G_WWW_TMART_COM_DOMAINtently?
Steps to reproduce
1)Click on checkout with Paypal button and you will find a grey screen coming behind with a new PayPal window popping up.
Affected browsers

[x] Chrome
[x] Safari
[x] Firefox
[x] Edge
[x] IE
[x] Chrome Mobile/Tablet
[x] Safari Mobile/Tablet
[x] Web View / Safari ViewController
[x] Other

Resolved.


[Key Vault] Create SAS token env var during test resource deployment

Description
Context: some azure-keyvault-administration tests, such as test_full_backup_and_restore, have been failing in live tests because of InternalServerErrors relating to SAS tokens. The last time this happened, it was because the lifetime of our test SAS tokens was too short.
Extending the lifetime of our tokens didn't fix things this time around, so I followed JS's approach of outputting a SAS token during test resource creation instead of creating one manually. Our prior methodology for creating tokens has apparently become invalid, presumably because of service-side changes.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run python - keyvault - tests

/azp run python - keyvault - tests

/azp run python - keyvault - tests

This has been hanging around for a while; closing.


Allow for all US state comparison and fix specified state comparison

Sorry to do 2 things in 1 pr, but it seemed to make sense because they both rely on the fetch_state_data method I added.
Adding All State Comparison
Output is the following:

Fixing specified US state comparison.
Prior to this change running kovid states Florida Tennessee, for example, would output the following.

Now the output is as follows:

Notes on Specs
This spec may seem strange, but I made it this way because I feel strongly that we should move in the direction of using stubs. I plan to create another pr very soon that addresses the need for stubbing in other areas of the spec file and ensure this added functionality has full spec coverage, but for now I just added this.
Notes on variable and argument name changes
I did this for the sake of clarity. In general I think it will be best if we avoid names like array, as it is less clear than alternatives. Happy to discuss further if you like.
Thanks again for doing the work on the gem. It's awesome.

Nice work!
I think this will be good to go once you add the alias. I agree with you on the tests and naming. I intended to fix those later and everything else gradually but you know...other projects and time constraints.
Thanks for this PR!

@siaw23 I added the alias method and this should be good to go (good call on that). One thing to note is that this commit, specifically this caused a merge conflict with the refactor I did here I resolved the conflict by selecting the version I created, as I think using select is a bit cleaner than using collect and compact. If you would like to discuss further let me know.

Perfect. Thank you for working on this :).


chore: fix NODE_AUTH_TOKEN to NPM_AUTH_TOKEN for shipjs release

see: https://github.com/algolia/shipjs/pull/928

@shipjs prepare


Documentation: translate the AI Page into french fixes #903

Please describe the changes this PR makes and why it should be merged:
This PR closes #903
Status

[x] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[x] This PR only includes non-code changes, like changes to documentation, README, etc.

Hi @tobySolutions, sorry for the delay, just finished the AI page into French.
Please check it out and review it, thanks.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-17 of 17 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 3.617%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

website/components/ai/hero.tsx
0
7
0.0%

website/translations.ts
0
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
884

Relevant Lines:
27076

💛  - Coveralls

Hi @tobySolutions, sorry for the delay, just finished the AI page into French. Please check it out and review it, thanks.

Hello @aidenybai @tobySolutions, still waiting for review, can you have a look on it and if not let me know ?


[CALCITE-457]: Non-ansi join should push join condition into join ope…

…rator.
Add Unit test.
There was proposal in CALCITE-457( https://issues.apache.org/jira/browse/CALCITE-457 ) to enable ProjectFilterTransposableRule in a HepPlanner, to avoid the planing loop issue. However, on the latest Calcite master branch, the proposal seems not been implemented yet, and the problem for non-ansi join still exists.
I would like to submit another way of fixing this issue. The code fix is used currently in Drill, since Drill has to optimize the case of non-ansi join.
The idea is quite simple.  There has been code logic in SqlToRelConverter which push the expression in ANSI-join down into project. That's why the case for ANSI join works in the way we want. To fix for the non-ansi join case, we simply move that logic from SqlToRelConverter to a utility method in RelOptUtil, and make that method be called both in SqlToRelConverter, to handle ANSI-join case,  and FilterJoinRule, to handle non-ANSI join case.
Couple of testcases are modified with this patch:

misc.oq
The new plan is what we want : the condition is pushed into join, in stead of in filter on top of join.

join.oq (JdbcTest.testRunJoin () )

one new unit testcase is added to verify the plan for non-ansi join ;
two existing unit testcases have modified plans.  The new plan makes more sense, since it merges two EnumerableCalcs into one EnumerableCalc

JdbcTest.testInnerJoinValues()
One field in EnumableCalcl from "DESC" to "EXPR$1".  My understanding is that the new plan is also valid, since Calcite does not guarantee the filed name would be kept the same in the intermediate RelNodes. Calcite uses ordinal-based execution and will call validator.getValidatedNodeType(), which will keep field names, to get ResultSet returned to client.

In misc.oq, a field that was called "DESC" is now called "EXPR$1". Can you restore the old name?

It's appropriate to always create a LogicalJoin when in SqlToRelConverter, less so in general-purpose planner rules. Can you use a join factory and not add method RelOptUtil.createJoin?

Rather than

  public static RelNode pushDownJoinConditions(RelOptCluster cluster,
                                              RexNode joinCond,
                                              JoinRelType joinType,
                                              RelNode leftRel,
                                              RelNode rightRel) {
    final List<RexNode> extraLeftExprs = new ArrayList<RexNode>();
    final List<RexNode> extraRightExprs = new ArrayList<RexNode>();
    final int leftCount = leftRel.getRowType().getFieldCount();
    final int rightCount = rightRel.getRowType().getFieldCount();

can you use project-standard formatting and diamonds:
  public static RelNode pushDownJoinConditions(RelOptCluster cluster,
    RexNode joinCond, JoinRelType joinType, RelNode leftRel, RelNode rightRel) {
    final List<RexNode> extraLeftExprs = new ArrayList<>();
    final List<RexNode> extraRightExprs = new ArrayList<>();
    final int leftCount = leftRel.getRowType().getFieldCount();
    final int rightCount = rightRel.getRowType().getFieldCount();

join.oq should end with newline

Can you add a test for FilterJoinRule's new capability to RelOptRulesTest.

Will work on revising the code based on comments.

Hi Julian,
I changed the code based on your comments. Pls see the following response.
(I squash the two commits into one. Not sure if that's OK or not for the pull request).
1 . In misc.oq, a field that was called "DESC" is now called "EXPR$1". Can you restore the old name?
[jni]  I guess you are talking about the JdbcTest.testInnerJoinValues(), where "DESC" is changed to "EXPR$1".
Actually, the field name change happens only in EXPLAIN PLAN output;  the query result is still using "DESC".  I spent quite some time trying to figure out why the field name is changed in EXPLAIN.  I do not have a completely clear idea why it happened. But seems Calcite put two RelNodes with different rowType under the same RelSet.   The following is from the calcite trace "before" my code change:
Set#1, type: RecordType(INTEGER EXPR$0, CHAR(8) EXPR$1)
rel#11:Subset#1.NONE.[], best=null, importance=0.5904900000000001
rel#1:LogicalValues.NONE.[[0, 1], [1]](type=RecordType(INTEGER EXPR$0, CHAR(8) EXPR$1),tuples=[{ 10, 'SameName' }]), rowcount=1.0, cumulative cost={inf}
rel#12:LogicalProject.NONE.[0, 1], [1], rowcount=1.0, cumulative cost={inf}
In the above, the LogicalValues has (EXPR$0, EXPR$1), LogicalProject has (ID, DESC). Yet Calcite still put them together under the same RelSet.  My guess is CALCITE-457 patch will impact the order of some rules firing, and somehow the rowType of downstream RelNode is messed up.
On the other hand, I think Calcite's API does not guarantee that the intermediate RelNode will keep the same field name;  the output field name is ensured to be same via validator.getValidatedNodeType(). That's why the query result still has "DESC" in the output. Therefore, I feel it might be ok to have different field name in the EXPLAIN plan output.
Another comment : this testcase does not have the join condition pushed. That's simply because of costing.  Values() has one row only.  I tried with two rows, and verified the condition will be pushed.

It's appropriate to always create a LogicalJoin when in SqlToRelConverter, less so in general-purpose planner rules. Can you use a join factory and not add method RelOptUtil.createJoin?

[jni]
I tried to add join factory to FilterJoinRule, that seems require more change.  In stead, I chose to passing in originalJoin, and use join.copy() method. That way, in the general-purpose planner rule or SqlToRelConverter, the new created Join will be of the same class of original join node.

[jni] Now I pass in param originalJoin. No need for such format.

join.oq should end with newline
[jni]  Done.

Can you add a test for FilterJoinRule's new capability to RelOptRulesTest.
[jni] testPushJoinCondDownToProject() is Added.


{Freeway-Bug} [Adaptive Card > Application Login]: Focus order is not in sequential order while navigating in Application login page.

Target Platforms
iOS
SDK Version
Version 1.0 (2.4.0-beta.20220628.3)
Application Name
Adaptive Cards
Problem Description
Test Environment:
Device: iPhone 11
iOS Version: 15.5
Screen Reader: Voice Over
Repro Steps:

Launch Adaptive Cards iOS application.
Home screen will appear.
Navigate to "V1.5" control and select it.
Navigate on "V1.5" screen and select "Scenarios" button.
'Scenario' screen will appear.
Navigate to "ApplicationLogin.json" control and double tap to activate it.
Navigate the 'ApplicationLogin' page and observe the issue.

Actual Result:
Focus order is not in sequential order while navigating the Application login page as on performing right swipe on 'UserName' it is going on the 'Password' after that it is going on the edit fields.
Expected Result:
Focus order should be in sequential order and on performing right swipe on the 'UserName' label it should be land on the 'Username edit field' after that on performing right swipe again it should be go on the 'Password label' after that it should go on
Password edit field.
User Experience:
It will impact the screen reader user as it will take extra effort for the user to navigate to all controls on the screen.
MAS Reference:
https://liquid.microsoft.com/Web/Object/Read/MS.Accessibility/Requirements/02.04.03
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “
Screenshots
https://user-images.githubusercontent.com/95913748/176612162-e5b106f2-505b-4f51-82ca-8f8a3e3e4d3b.MP4
Card JSON
NA

Sample Code Language
No response
Sample Code
No response

This issue is not repro on the environment below, hence closing this issue.
Test Environment:
Device: iPhone 11
iOS: 16.3.1
Application: Adaptive Cards
App Version: 1.0 (2.4.0-beta.<IP_ADDRESS>)
Screen Reader: Voice Over


Closer UX between range picker and single picker on desktop

This is a proposal to unify the behavior of the single and range date picker.

Looking at https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/datepicker-dialog.html, I don't think that the DesktopDatePicker should use the Modal component. The scroll shouldn't be blocked nor the underlying window hidden. Instead, we could replace it with Popper + TrapFocus + Escape + onBlur logic. I don't see any downside going in this direction. It seems to be a clear win. It's how the date range picker behaves.
I wonder about providing a openOnFocus and openOnClick prop to replicate a common UX competitive date pickers have. It's also how the date range picker behaves.
In any case, the current default with an icon to open the popup is great. I think that the closer we are to the native date-time picker implementation of the browsers, the better.
Well, reading https://www.hassellinclusion.com/blog/input-type-date-ready-for-use/, <input type=”date” /> might not be a good option from an accessibility standpoint 🙃
It seems that StaticDateRangePicker should have allowKeyboardControl set to true.

(?) In the regular DatePicker, one can switch to a year selection view, which is not possible (but would also be very useful) in the DateRangePicker.

@Philipp91 For this case, maybe we should encourage a double single date picker?

I don't understand? You mean not using the DateRangePicker but just connecting two DatePickers such that one's value is the other's minDate and vice versa?

@Philipp91 Yeah, maybe not if we want to support range picker for months or years.

Oh, maybe there's a misunderstanding. I don't mean a UI for selecting "Jan 2020 through Apr 2020" without specifying days. I just mean improving the UX for "Jan 1st 1990 through Jan 31st 1990". Just try entering that on any of the demo range pickers without using the keyboard -- it takes a long time to get to 1990.

@Philipp91 No objection here, I was looking a step ahead 😁


Use port other than 11095 as chip port

Problem
Chip is using port 11095 as its default port and binding to ADDR_ANY. This port is already occupied by Weave and is utilized for Nest products.
Proposed Solution
Use a port other than 11095.

Who is going to request the port? Or we are going to use ephemeral port for CHIP service, and discover it by mDNS?

If CHIP is going to support multicast, the port has to be fixed.


[Feature Request] Elytra Support on Chestplate setting

As title said, that would be appreciated. Great mod by the way!

The title is kind of vague, but I assume you mean an option to hide the elytra?
Since the elytra rendering is entirely seperate from the armor rendering, I'll add a toggle button to hide the elytra in the next update.


Have to increase the Lambda function timeout to avoid KeyError: 'Item at line 61

Hi,
Even 90sec timeout for Lambda function is still causing the issue at below lines -
'Item': KeyError
Traceback (most recent call last):
File "/var/task/DDNS.py", line 64, in lambda_handler
instance = instance['Item']['InstanceAttributes']
KeyError: 'Item'
I made the timeout to max (5min) and then the function worked. So, looks like the timeout in CF templates should be increased to more than 2min.

The first time you run the function, it creates the DDB table.  Although it usually completes within a minute, it could take longer.  If you create the table manually or you add it to the CFN template [which I will try to do when I have time], you shouldn't need to set the timeout to 5m or 2m.


kProcessor/kSpider/sourmash thoughts for downsampling/containment matrix

Extending https://github.com/sourmash-bio/sourmash/issues/1750, I am copying a conversation between @ctb and @drtamermansour to be detailed later into tasks.

Slack Conversation
Tamer Mansour  8:38 AM
@titus @taylorreiter We can solve this problem VERY efficiently by using kProcessor/kSpider.
Titus Brown:speech_balloon:  8:39 AM
it’s not hard to do in sourmash, either, although I suspect kProcessor/kSpider has specialized lookup tables that make it even faster.
8:39
the issue is integrating it into the CLI.
Tamer Mansour  8:41 AM
kProcessor/kSpider can perform pairwise calculation of shared kmers for 20k genes in a couple GB space and few minutes
8:42
We can prepare the output in a format that sourmash can read
8:44
All what we need is to implement a simple parser for sourmash signature files
8:45
In the CLI, i think sourmash can call kProcessor/kSpider under the hood
Titus Brown:speech_balloon:  8:46 AM
so, two issues here -
Rob is talking about (potentially) very large metagenomes, and the sourmash downsampling approach is probably quite important for his application, since metagenomes can be so much larger than transcriptomes. e.g. “a couple GB space” rapidly becomes 100s of GB.
As Taylor experienced, sourmash isn’t doing a good job with sparse matrices, either, so if you have 20k x 20k queries you run out of memory regardless :)
In this case, kProcessor/kSpider would be completely replacing sourmash, not producing output for it to read.
I think what we want is something similar to what you suggested - a parser for kProcessor/kSpider to read sourmash sig files. (edited)
8:46
Integrating kProcessor into sourmash is not simple or easy, especially since we moved sourmash over to rust.
Tamer Mansour  8:50 AM
Sourmash does not need to integrate kProcessor. Just use it as a third party tool. Sourmash has to do the downsampling, prep the signature files, call kProcessor/kSpider module, and finally present the output through the sourmash visualization scripts (edited)
Titus Brown:speech_balloon:  8:50 AM
call kProcessor/kSpider module
8:51
if we did it that way, sourmash would now include kProcessor/kSpider as a dependency :slightly_smiling_face:
Tamer Mansour  8:51 AM
yes
8:51
it is a python package
8:52
This is what kProcessor is made for :slightly_smiling_face:
Titus Brown:speech_balloon:  8:54 AM
I don’t think that’s a good idea; sourmash is pretty strict about versioning and dependencies.
It should be pretty straightforward to have kProcessor read sourmash sig files (it’s just k-mers and hashes!), do the comparison, and output a numpy matrix that can be read by sourmash plot. In this case I’m pretty sure Rob (and Taylor) don’t want to use the viz tools, anyway, which won’t scale to that number of samples.
8:55
If you put together a demo of the 20kx transcript query somewhere, we can suggest it, even without the downsampling.
8:56
If we had an extensions framework in sourmash, could do it that way, too.
8:56
But I don’t think we want sourmash to have kProcessor as a required dependency.
Tamer Mansour  8:57 AM
Sure we can prep a demo. But our current indexing can not make 20k whole datasets.
8:57
Mostafa is working on the new indexing algorithm to do so in the soon future
Titus Brown:speech_balloon:  8:58 AM
So this seems like a good use case for future development, but it’s not something we should suggest to Rob right now ;)
Tamer Mansour  8:59 AM
We can implement downsampling in kProcessor. That should be even easier than developing a parser for sourmash signatures
9:00
I can make something to try next week
Titus Brown:speech_balloon:  9:00 AM
yes, it’s easy, but now you have distinct code bases and you don’t get the advantage of all the sourmash signature manipulation utilities. If it’s simple to parse sourmash signatures (which it should be - they’re “just” JSON, plus we have a sourmash API to load it) then might as well add that too.
9:01
If nothing else, it’s a good way to test your downsampling code in kProcessor by running the same operations in kProcessor directly vs loading with sourmash.
9:02
(the downsampling code is now pretty simple in sourmash, but it took a while to get there, and we have a LOT of tests for it. so it’s pretty robustly tested. No reason to discard that.)
Tamer Mansour  9:03 AM
This is also a good solution
Titus Brown:speech_balloon:  9:03 AM
also check out the sourmash sketch documentation. Soooo maaaaany oppppppptions to implement. Ugh.
Tamer Mansour  9:05 AM
I was thinking of a very simple approach. Incorporating one kmer every 1000 while reading the input sequences. That is it :smile:
:+1:
1
9:05
But using sourmash is a better idea
Titus Brown:speech_balloon:  9:06 AM
I see value in both, TBH. No reason to force people to jump through hoops either way, and as you say, the code is simple for scaled downsampling.
:+1:
1
Titus Brown:speech_balloon:  9:28 AM
One other thought - the seq-to-hashes stuff that @mr-eyes implemented for sourmash could be used directly by kProcessor to build scaled=1 dataframes in DNA space (which you already have working) as well as translated and protein queries. Again, ultimately you probably want this in kProcessor directly, but it’s a pretty simple call to sourmash to get the functionality working right now.

@ctb
The same sourmash signature might have kmers of different sizes, is not it?


Running generic files

Running 'cmd /c start "calc.exe"' just opens a Command Line with the title of 'calc.exe' instead of running 'calc.exe' ("calc.exe" is handled as the title and not the command/program.) we just need to define a title to fix it.
the syntax of 'start' command in windows is:
START ["title"] [/D path] [/I] [/MIN] [/MAX] [/SEPARATE | /SHARED]
[/LOW | /NORMAL | /HIGH | /REALTIME | /ABOVENORMAL | /BELOWNORMAL]
[/NODE ] [/AFFINITY ] [/WAIT] [/B]
[command/program] [parameters]

Thanks s much.


feat: only save inlined magic when in a container

Fix CX-444

🧰 Changes
Updates some recent changes so we only save magic blocks to a single line format if they are in a container node.
🧬 QA & Testing

Broken on production.
Working in this PR app.

This PR was released!
🚀 Changes included in v6.70.0


Add linting rules and fixes

Signed-off-by: Will Kutler<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/18036

@willkutler can you rebase to make the required check pass?

@willkutler could you please squash those commits and ensure your single commit is signed off?

@willkutler could you please squash your commits to a single commit?

/retest

@willkutler Can you fixed the dco-signoff?

/check-dco


[FEATURES]  csi-node-driver-registrarimage support for arm architecture

What feature you'd like to add:
fluidcloudnative/csi-node-driver-registrar:v2.3.0 image dont support arm architecture.

Why is this feature needed:

https://github.com/kubernetes-csi/node-driver-registrar/tree/release-2.3


error: failed to get a connect link: oauth1: Server returned status 400

I am using Jira Server connected with Mattermost. I followed the tutorial to configure the Jira plugin, but at the final step of connection, when clicking in, it reports an error:
"failed to get a connect link: oauth1: Server returned status 400"
My Jira version: Jira Software 9.7.0
Mattermost version: 9.5.1
My Mattermost installation environment is on Windows 11's WSL (Windows Subsystem for Linux), and I used Docker to install the server-side. On Windows 11, I am using the client-side application. Jira is installed on another Linux server in the same network segment.

Hi @xueyu888, thanks for filing this issue.
I have a questions so I can understand better:

Are you using the Mattermost desktop app? If so, can you try running Mattermost in your browser?
Can you check your server logs to see if there are any additional logs related to this error? You may need to configure the log level to DEBUG in the MM system console.

@mickmister  Thank you for your response.

I've tried running Mattermost in the browser, and the same problem occurs.

The debug logs in Mattermost show as follows:

{"timestamp":"2024-03-12 10:19:24.912 Z","level":"warn","msg":"ERROR: ","caller":"app/plugin_api.go:1006","plugin_id":"jira","Status":"500","Error":"failed to get a connect link: oauth1: Server returned status 400","Path":"/instance/aHR0cDovLzE5Mi4xNjguMTEuMTE6ODA4/user/connect","Method":"GET","query":""}
{"timestamp":"2024-03-12 10:19:24.912 Z","level":"debug","msg":"unexpected plugin response","caller":"app/plugin_api.go:997","plugin_id":"jira","Status":"500","Path":"/instance/aHR0cDovLzE5Mi4xNjguMTEuMTE6ODA4/user/connect","Method":"GET","query":""}

The logs from the Jira server are as follows:

07-Mar-2024 15:17:59.482 INFO [http-nio-8080-exec-2] org.apache.coyote.http11.Http11Processor.service Error parsing HTTP request header
Note: further occurrences of HTTP request parsing errors will be logged at DEBUG level.
java.lang.IllegalArgumentException: Invalid character found in method name [0xff0xf40xff0xfd0x06...]. HTTP method names must be tokens
at org.apache.coyote.http11.Http11InputBuffer.parseRequestLine(Http11InputBuffer.java:419)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:271)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:891)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1784)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
created com.atlassian.jira.plugins.webhooks.ao.WebhookDaoImpl@4e953c75<PHONE_NUMBER> with events jira:issue_updated
comment_created
jira:issue_created
comment_updated
jira:issue_deleted
jira:worklog_updated
comment_deleted
AO_4AEACD_WEBHOOK_DAO {ID = 1} 406
created com.atlassian.jira.plugins.webhooks.ao.WebhookDaoImpl@10c2a38f 281191311 with events jira:issue_updated
comment_created
jira:issue_created
comment_updated
jira:issue_deleted
jira:worklog_updated
comment_deleted
AO_4AEACD_WEBHOOK_DAO {ID = 1} 406
created com.atlassian.jira.plugins.webhooks.ao.WebhookDaoImpl@73d09567<PHONE_NUMBER> with events null
AO_4AEACD_WEBHOOK_DAO {ID = 2} 407
set eventscom.atlassian.jira.plugins.webhooks.ao.WebhookDaoImpl@73d09567<PHONE_NUMBER>
AO_4AEACD_WEBHOOK_DAO {ID = 2} 407
jira:issue_updated
comment_created
jira:issue_created
comment_updated
jira:issue_deleted
jira:worklog_updated
comment_deleted
created com.atlassian.jira.plugins.webhooks.ao.WebhookDaoImpl@43c07fde<PHONE_NUMBER> with events jira:issue_updated
comment_created
jira:issue_created
comment_updated
jira:issue_deleted
jira:worklog_updated
comment_deleted
AO_4AEACD_WEBHOOK_DAO {ID = 2} 407

@raghavaggarwal2308 Can you or another team member see if this is reproducible with the version numbers specified in the issue description? @xueyu888 I assume you're using the latest version of the Jira plugin v4.1.0?
@xueyu888 Was this working before on your server? If so, have there been any upgrades of the Jira Server since then? Is there anything with your setup that comes to mind that may be related?
The errors you provided from Jira's side seem quite cryptic. I feel there's not much to go off of in terms of our interaction with Jira's API. It seems related to webhooks, so not sure if it's linked to the OAuth issue

@mickmister I tried reproducing the issue with:
My Jira version: Jira Software 9.7.0
Local Mattermost version: 9.5.1
I was able to connect to my Jira account by following the setup flow successfully. I will look more into it once we get some more details from @xueyu888 .

Hi @raghavaggarwal2308 , Did you use the HTTP protocol when you tried to replicate the issue?
I tried again following the installation tutorial, but I still have the same problem. The version of my Jira plugin is v4.1.0. Both my Mattermost and Jira are running in Docker, and both are using the HTTP protocol. Here are some of my configuration details:

If it's not because of the HTTP issue, I will try reinstalling Jira tomorrow and go through the tutorial again to see if that solves the problem.

@xueyu888 Tried with HTTP protocol as well, still working fine for me.

I changed the environment for installation, and the problem has been solved. Thanks everyone for your help!

I changed the environment for installation, and the problem has been solved. Thanks everyone for your help!
Hi @xueyu888 , I also have the same problem as you . can you explain to me how you solved your problem?
I have tried several times to adjust the setting , but when i enter the command "/jira connect" it still gives the same error.


Introduce theme::Custom::with_fn to generate completely custom themes

As discussed in https://discourse.iced.rs/t/is-it-possible-to-control-the-extended-palette/40/4.

Fantastic!


yatima_core panics on particular input with unfree variable

I get a panic when I run yatima check map_test.ya
and map_test.ya is
package map_test
  import map
  import nat
  import ord
where

def test_map: Map Nat Nat (Ord Nat) =
  let O: Ord Nat = Ord.New Nat Nat.compare;
  let empty: Map Nat Nat O = Map.empty Nat Nat O;
  let map1: Map Nat Nat O = Map.insert Nat Nat O 1 2 empty;
  map1

Checking definitions:
thread 'main' panicked at 'Variable not free', core/src/dag.rs:1290:20

Upon further investigation, the part that causes this bug is the type signature Map Nat Nat O whether O is defined via let or def.


Feature proposal: Map column names when exporting CSV

I'm seeing an issue where column names are:
A) converted to lowercase (they are uppercase in the SQL)
B) cannot be remapped in ruby code (without hacking around in the enumerator).
Would a PR to add the map: {} syntax to CSV exports be mergeable?

Sorry, I don't follow you.
Could you paste a snippet of the desired code that you would like to use?

Lets say you have CSV imports and exports, and want round-tripping to work.
You export with:
Foo.select('bar as Baz').copy_to_string

then import with:
Foo.copy_from filename, :map => {'Baz' => 'bar'}

However, the CSV from copy_to_string has a header row of baz, not Baz.

I see your point. It makes sense to have symetrical APIs on exports and imports.


Non-rc release forthcoming?

Hello,
Thanks for your work on this project. It's been a while since the last non-prerelease version; the convention with rc releases it that these are 'release candidates' and so not for production use. As such, is there any chance of a forthcoming production release with Django 4.2+ support on PyPI?

I too am very interested in a non-rc version for 3.10 to get Django 4.2 support. Support for Django 3.2 ends April 1st. Any ideas if that is to be expected? I'm not interested in Django 5 yet.

Ok, considering https://github.com/bento-platform/katsu/pull/473/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R34 as confirmation that 3.11.0rc1 is fine, released 3.11.0, please reopen in case it's not good, meanwhile
Njoy :tophat:


Missing differentiation for windows and linux at the time of Set-AzureRmVMOsDisk

https://docs.microsoft.com/en-us/azure/security/azure-security-disk-encryption-appendix#bkmk_SecretURL
no windows reference here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 246df0be-86c4-083f-5896-d9ed79a94b88
Version Independent ID: cba0daf5-b5f3-e1ba-2d79-56ef94f927cb
Content: Appendix - Azure Disk Encryption for IaaS VMs
Content Source: articles/security/azure-security-disk-encryption-appendix.md
Service: security
GitHub Login: @mestew
Microsoft Alias: mstewart

@marioanton Thanks for your feedback! We will investigate and update as appropriate.

@marioanton  You can pass -Windows or -Linux to the command "Set-AzureRmVMOsDisk" for Windows and Linux VM respectively.

Think there is some more bits missing on the rest of the document. Overall when doing the inclusion of tags in the keyvault.

Think tags like Volume label etc are required for the os to boot and procced with encryption/decryption

This issue can be closed.


The shortcut to open a new terminal/shell opens a new terminal every time.

Observed behavior
Pressing the key combination SPC -> ' to open a terminal causes a new terminal to be opened everytime.
Desired behavior
Should reuse the last open terminal.
Proposed solution:
Change SPC -> ' from executing the ideavim action Terminal.OpenInTerminal to instead executing ideavim action ActivateTerminalToolWindow

Solved in 8366e5a71ffe4813c7c7bdba0065846a7e215c81
It's in the which-key branch, so it's not available in the main branch yet.
I don't want to have merge conflicts, sorry, I hope it's not a problem :)


igfilter and nssmkig.sys missing when building with Visual Studio

I can't be able to find igfilter and nssmkig.sys when building with Visual Studio.

Because those are not FOSS components, I provide the binaries when making a release.

Can i build those myself

As I said, the sources are not publicly available, so no.

are those mandatory if i build it myself

For building, no. For operation, yes.


Reduce object allocation for CollectionCoercer#_compile! method

Check object allocation for all called code from test (blog post)
Before
==================================
  Mode: object(1)
  Samples: 1077870 (0.00% miss rate)
  GC: 0 (0.00%)
==================================
     TOTAL    (pct)     SAMPLES    (pct)     FRAME
    445591  (41.3%)      238577  (22.1%)     Lotus::Model::Mapping::CollectionCoercer#_compile!
    104712   (9.7%)       78534   (7.3%)     Lotus::Utils::String#tokenize

After
==================================
  Mode: object(1)
  Samples: 1007344 (0.00% miss rate)
  GC: 0 (0.00%)
==================================
     TOTAL    (pct)     SAMPLES    (pct)     FRAME
    400814  (39.8%)      203930  (20.2%)     Lotus::Model::Mapping::CollectionCoercer#_compile!
     99240   (9.9%)       74430   (7.4%)     Lotus::Utils::String#tokenize

:tada:

/сс @jodosha

@davydovanton Hey, thanks for this PR, but I'm not keen to merge it.
Before lotusrb-0.6.0 Lotus::Model is "frozen", we don't wanna change anything. After that release, we want to change the way it works.
I don't like how Coercer is implemented, because of metaprogramming, and this PR touches that code.
This isn't a huge benefit in terms of speed/object allocations gain, because it change the "loading" code, not the "runtime" code. The former is ran only once at the application startup, even if saves object allocations, it doesn't affect the overall performance. The "runtime" code is the one that is executed for each incoming request. By improving it, we have a gain.
Sorry about this, I hope you will understand. I encourage you to contribute to Lotus with these perf patches. Thanks Anton!

No problem, thanks for explanation!


Reset settings not working

Browsers tested:
Chrome 40.0.2214.91
Firefox 35.0
YTC dev 470
When clicking on the Reset button in the "Reset settings" dialog it gets stuck on trying to reset the settings.
In Chrome's console it displays the following:
[Storage] Checking if settings have expired.
[Tab Events] Sending new settings to other open tabs.

Firefox console:
"[Storage] Checking if settings have expired."

No matter how long I wait, nothing else happens. I have to refresh the page and the settings remain unchanged.

Same here when trying to import settings.

Confirmed on Cyberfox 35.0.1 with YTC build 471.
After a bit of testing, I realized that the settings will not save if the value of the "lastUpdated" property is less than the current value. I guess this is done to prevent YTC from accidentally overwriting the settings with invalid ones – the "settings randomly reset" has indeed not happened to me for a while now – but this also prevents importing older settings (resp. resetting all settings manually), as it would overwrite the "lastUpdated" value with a lower one (resp. clear it).
If you need to import settings, you'll have to edit "lastUpdated" manually (replacing the last few digits with "99999" will do the trick) before you save. That value will be at the very end of the input box.

Thanks, mleyen - I was pointed here from #1400 and was coming to that conclusion myself after fiddling about with the saved files.
My exported settings were from a version old enough to not have a lastUpdated property, but adding one and giving it a high value ("lastUpdated":1422762999999) was enough to allow YTC to load them.

Same here, this is a big problem as I have an issue with audio/video de-syncing in html5 player but I can't troubleshoot it without resetting the settings.

Seems like I didn't account for this when I applied the lastUpdated update. I will try to get a fix out in the coming future.


[Request] Fix Shell Casings in Vice City

In Vice City, when firing the Revolver, it ejects shell casings as if it was a self loading firearm, which it shouldn't happen with this kind of weapon as the casings are contained in the drum, could you make the revolver not eject shell casings as you fire?

That depends on whether any other weapons are "excluded" from this behaviour too. If they all eject casings it's probably impossible, but if they operate on an exclusion list, then most likely.
I'll mark it as an enhancement for now, I'll be willing to reclassify this as a bug if this behaviour is customizable and just wrongly assigned to the revolver.

Thank you! I don't know how any of this work internally, maybe if this system exists in the way you suggest it could, it would be used by the flamethrower, sniper rifle, rpg, etc, as they don't eject casings.

Yeah, this might be done on a per-weapon-type basis... although then again minigun is a heavy weapon, yet it has casings. Perhaps it's done for all "instant hit" weapons.

Yeah... maybe, checked and the both sniper rifles don't have any shell casings, and they are "instant hit" weapons AFAIK, but their lack of casing effect might have something to do with the fact that they are scoped weapons? don't know to be honest if they could get them as well

No idea at the moment. I'll keep it open as a request for now but might reclassify it to a bug depending on the findings later. Right now I'm only focusing on stabilization.


hyprbars: steam crashes hyprland on launch

Validated by unloading hyprbars and relaunching steam.
hyprlandCrashReport1343.txt

no longer reproducible.


Trigger Handler Null Pointer Exception when the Trigger Action is empty

The trigger action field is not required and can be nulled out by an end user. This will result in an error message for both Health Check and when the trigger is ran on the object: "System.NullPointerException: Attempt to de-reference a null object Class.TDTM_ObjectDataGateway.getClassesToCallForObject: line 74, column 1 External entry point Class.TDTM_TriggerHandler.run: line 89, column 1 Trigger.TDTM_Account: line 34, column 1"

**lurch: add

Tracking W-020423

I would like to fix this bug.

Hi @manikrai29, that's great thank you!! Would this be on behalf of your company (Traction I believe) or as an individual contribution?
I can see you've included the code changes from your personal GitHub org. Are you able to create a PR for it here in the Cumulus repo and link it to this fix? http://developer.salesforce.org/Cumulus/Contributor/Submit-Your-Feature.html
Also, would you mind sending me your email and full name as we'll need to send you a CLA to sign (or for Traction to sign if you've used company time/properly to submit the fix).
Thank you!!

@coriobriensfdo as suggested I opened a new pull request. Secondly, this is on behalf of Traction; so, you can forward me the CLA at<EMAIL_ADDRESS>

Great, thanks! Can you tell me your full name?

Great, can you tell me your full name @manikrai29? If you prefer you can email me that information at<EMAIL_ADDRESS>


Boko base

Adds access to and from Boko Base! The Shiekah Stone usually found in Boko Base has been added to Eldin Volcano (near the Volcano East bird statue) and offers access to Boko Base. There is another Shiekah Stone in the Boko Base prison that allows players to return to Eldin Volcano. There were plans to have Plats offer this return to Eldin but this would force players to get the Plats' Gift check which is less obvious than the Shiekah Stone.
Adds 10 checks: Plats' Gift (Mogma Mitts), the 5 b-wheel item chests, the Volcano Summit small chest, Raised Chest in Volcano Summit (True Master Sword), Chest in Volcano Summit Alcove (Pouch), and the Fire Dragon's SotH Piece.
In addition, the 2 chests that were added to Volcano Summit from Boko Base have been removed now that they can exist in their vanilla locations instead.
Players also start with the map completed to show the b-wheel items.
Currently, players keep their items when entering and leaving Boko Base. There are plans to add an option to have items become restricted when entering Boko Base but this is significantly more complex for minimal benefit.

Barring any further bugs being found, Boko Base is fully functional. What follows are my observations regarding a restrict-boko-base option where items are restricted whilst on the boko base stage.
Items can be restricted on entry and unrestricted on exit very easily. This is trivial and functions very well.
In the vanilla game, items are unrestricted when obtaining their relevant check. This is achieved with a switch on the item get event that checks for each item's restricted story flag. As a result, placing a different item on these checks doesn't unrestrict the original item.
As far as I can see, there are 3 possible solutions and 2 reasonable solutions.

A patches solution would be to utilize the fact that each of these checks sets a scene flag. By placing an AREA around each check, it could be possible to add a Plats object near each check so he pops up and "gives" an unlock for a restricted item. This would involve quite a lot of patches but would be manageable.

Create an additional chest type or make chests optionally trigger a generic event that can be patched in eventpatches.yaml. This would require asm and would likely be very complicated. It would, however, be the cleanest option - provided it exposes a visual indication that a restriction has been lifted.

Patch every item get text with a switch that can be modified to unrestrict a restricted item. This is ridiculous and would be utterly unmaintainable.

Dismissing the 3rd option, it would then be possible to randomize the lifting of the restrictions in a similar fashion to how the required dungeons are patched.
With the skills and knowledge of the game that I currently have, I believe I could implement the first solution if this were desired. However, I suspect that those who would like an option to have items restricted when entering Boko Base would be unsatisfied with this solution.
If anyone has any alternative suggestions about how it may be possible to add a restrict-boko-base option, I would be very willing to helping to help implement it.

Tested in race today - no issues found.


Long questions (>140chars) break 'Rebuild Lex Bot' action

Any question longer that 140 characters prevents "Rebuild Lex Bot" action from having any effect, though UI nevertheless reports 'Success".
Two aspects to this issue:

The Content Designer UI should detect and report bot rebuild failures.

QnABot should enforce the Lex slot type length limit by disallowing entry of questions longer than 140 characters.

Steps to reproduce

Add a long question to an item (> 140 characters), save item
Rebuild bot from ContentDesigner console
Observe Content designer reports 'Success'. Observe failures logged by Lambda 'Handler' function. Observe from Lex console that Lex bot is not actually rebuilt.

Should questions be enforced to be shorter than 140 char or should the lambda function add a truncated version of the question to the SlotType?

For now, lets fix this by enforcing questions to be less than 140 char in the Designer UI and also in the lambda handler.

fixed in v2


feat: Add auto_rollback feature to this module in instance_refresh settings

Description
Add auto_rollback feature to this module in instance_refresh settings
Motivation and Context
Spacelift uses this module and we are enabling instance refresh on our private worker but auto_rollback is missing in this module so this pull request is all about adding auto_rollback feature to this module.

Resolves #231

Breaking Changes
No
How Has This Been Tested?

[X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

This PR is included in version 6.10.0 :tada:


`services.xserver.displayManager.job.execCmd' is defined multiple times

Issue description
The unique option services.xserver.displayManager.job.execCmd' is defined multiple times in /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs/nixos/modules/services/x11/display-managers/sddm.nix' and `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs/nixos/modules/services/x11/display-managers/gdm.nix'.
Steps to reproduce
nixos-rebuild switch --upgrade
Technical details
first try with nixos-18.09
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

system: "x86_64-linux"
host os: Linux 4.14.71, NixOS, 18.03.133245.d16a7abceb7 (Impala)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.0.4
channels(root): "nixos-18.09beta739.6cbd1ec4b04"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

It looks like the system is trying to enable botth gdm and sddm which doesn't work. Probably related to https://github.com/NixOS/nixpkgs/pull/30890. What's your services.xserver config? Specifically desktopManager and displayManager.

I am not sure where or what to look for, but
/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs/nixos/modules/services/x11/display-managers/default.nix says:
options = {
services.xserver.displayManager = {

  xauthBin = mkOption {
    internal = true;
    default = "${xorg.xauth}/bin/xauth";
    description = "Path to the <command>xauth</command> program used by display managers.";
  };

  xserverBin = mkOption {
    type = types.path;
    description = "Path to the X server used by display managers.";
  };

  xserverArgs = mkOption {
    type = types.listOf types.str;
    default = [];
    example = [ "-ac" "-logverbose" "-verbose" "-nolisten tcp" ];
    description = "List of arguments for the X server.";
  };

  sessionCommands = mkOption {
    type = types.lines;
    default = "";
    example =
      ''
        xmessage "Hello World!" &
      '';
    description = "Shell commands executed just before the window or desktop manager is started.";
  };

  hiddenUsers = mkOption {
    type = types.listOf types.str;
    default = [ "nobody" ];
    description = ''
      A list of users which will not be shown in the display manager.
    '';
  };

and
/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs/nixos/modules/services/x11/desktop-managers/default.nix says:
services.xserver.desktopManager = {

  wallpaper = {
    mode = mkOption {
      type = types.enum [ "center" "fill" "max" "scale" "tile" ];
      default = "scale";
      example = "fill";
      description = ''
        The file <filename>~/.background-image</filename> is used as a background image.
        This option specifies the placement of this image onto your desktop.

        Possible values:
        <literal>center</literal>: Center the image on the background. If it is too small, it will be surrounded by a black border.
        <literal>fill</literal>: Like <literal>scale</literal>, but preserves aspect ratio by zooming the image until it fits. Either a horizontal or a vertical part of the image will be cut off.
        <literal>max</literal>: Like <literal>fill</literal>, but scale the image to the maximum size that fits the screen with black borders on one side.
        <literal>scale</literal>: Fit the file into the background without repeating it, cutting off stuff or using borders. But the aspect ratio is not preserved either.
        <literal>tile</literal>: Tile (repeat) the image in case it is too small for the screen.
      '';
    };

    combineScreens = mkOption {
      type = types.bool;
      default = false;
      description = ''
        When set to <literal>true</literal> the wallpaper will stretch across all screens.
        When set to <literal>false</literal> the wallpaper is duplicated to all screens.
      '';
    };
  };

  session = mkOption {
    internal = true;
    default = [];
    example = singleton
      { name = "kde";
        bgSupport = true;
        start = "...";
      };
    description = ''
      Internal option used to add some common line to desktop manager
      scripts before forwarding the value to the
      <varname>displayManager</varname>.
    '';
    apply = list: {
      list = map (d: d // {
        manage = "desktop";
        start = d.start
        + optionalString (needBGCond d) ''
          if [ -e $HOME/.background-image ]; then
            ${pkgs.feh}/bin/feh --bg-${cfg.wallpaper.mode} ${optionalString cfg.wallpaper.combineScreens "--no-xinerama"} $HOME/.background-image
          else
            # Use a solid black background as fallback
            ${pkgs.xorg.xsetroot}/bin/xsetroot -solid black
          fi
        '';
      }) list;
      needBGPackages = [] != filter needBGCond list;
    };
  };

  default = mkOption {
    type = types.str;
    default = "";
    example = "none";
    description = "Default desktop manager loaded if none have been chosen.";
    apply = defaultDM:
      if defaultDM == "" && cfg.session.list != [] then
        (head cfg.session.list).name
      else if any (w: w.name == defaultDM) cfg.session.list then
        defaultDM
      else
        builtins.trace ''
          Default desktop manager (${defaultDM}) not found at evaluation time.
          These are the known valid session names:
            ${concatMapStringsSep "\n  " (w: "services.xserver.desktopManager.default = \"${w.name}\";") cfg.session.list}
          It's also possible the default can be found in one of these packages:
            ${concatMapStringsSep "\n  " (p: p.name) config.services.xserver.displayManager.extraSessionFilePackages}
        '' defaultDM;
  };

};

};
These are where grep finds desktopManager and displayManager on the left side of an equals sign.

Ah, sorry should've specified that I was referring to your system configuration file: /etc/nixos/configuration.nix.
If both gdm and sddm is enabled in your config, simply remove the one you don't want (gdm is typically used by gnome and sddm by plasma/kde). If that's not the case we're dealing with a bug (probably triggered by enabling the plasma5 and gnome3 desktop managers).
Stuff to try out if the above doesn't work or apply would be to explicitly set the display manager to your preference (eg. gdm if you're using gnome and sddm if you're using plasma). If that doesn't work try to also disable the display manager you're not using, eg. services.xserver.displayManager.sddm.enable = false. That should hopefully fix it until we can fix the problem properly.

Thank you, Tor.
/etc/nixos/configuration.nix said:
Enable the xfce Desktop Environment.
services.xserver.displayManager.sddm.enable = true;
services.xserver.desktopManager.xfce.enable = true;
services.xserver.desktopManager.gnome3.enable = true;

I changed it to:
Enable the xfce Desktop Environment.
#services.xserver.displayManager.sddm.enable = true;
services.xserver.desktopManager.xfce.enable = true;
services.xserver.desktopManager.gnome3.enable = true;

to turn off sddm, and the system built and worked.
I use the xfce desktop, the gnome3 desktop does not work on this particular
laptop.
I have to enable gnome3 for network manager and bluetooth.
I have never tried kde on this system, I don't like it much, and it did not
appear as an option on the login screen.
I am curious why sddm is a display manager, and gnome3 and xfce are desktop
managers, in this section.
Carl
On Sat, Oct 6, 2018 at 8:10 PM Tor Hedin Brønner<EMAIL_ADDRESS>wrote:

Ah, sorry should've specified that I was referring to your system
configuration file: /etc/nixos/configuration.nix.
If both gdm and sddm is enabled in your config, simply remove the one you
don't want (gdm is typically used by gnome and sddm by plasma/kde). If
that's not the case we're dealing with a bug (probably triggered by
enabling the plasma5 and gnome3 desktop managers).
Stuff to try out if the above doesn't work or apply would be to explicitly
set the display manager to your preference (eg. gdm if you're using gnome
and sddm if you're using plasma). If that doesn't work try to also
disable the display manager you're not using, eg. services.xserver.displayManager.sddm.enable
= false. That should hopefully fix it until we can fix the problem
properly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/47945#issuecomment-427615251,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACi3ePhzD3K2lv_Wtig3MUSBcl3-HO8nks5uiUZfgaJpZM4XLDMv
.

Glad it worked. You should be able to replace ...gnome3.enable = true with networking.networkmanager.enable = true, that way you'll avoid pulling in a bunch of stuff you don't necessarily want. I'm guessing this happened when trying to upgrade to 18.09?  Else I can't quite understand how gnome3 would pull in gdm.
A display manager is simply used to log into a desktop manager/environment like xfce.

No, I had added gnome3 with 17.09, where I started. I hacked about to get
Nix installed from flash and ethernet, and added gnome to get network
manager for wireless. And bluetooth for a trackball I use.
With 18.09. gnome desktop now works, with and without Xorg. I don't know
which desktop I will use.
The purpose of this system was to have something besides fedora, and to
experiment with Haskell.
The computer is an Acer Asipre, with a touch screen and Amd hardware.
I picked it up cheap as refurbished. It is rather idiosyncratic.
Carl
On Sun, Oct 7, 2018 at 12:06 PM Tor Hedin Brønner<EMAIL_ADDRESS>wrote:

Glad it worked. You should be able to replace ...gnome3.enable = true
with networking.networkmanager.enable = true
https://nixos.org/nixos/options.html#networkmanager.enable, that way
you'll avoid pulling in a bunch of stuff you don't necessarily want. I'm
guessing this happened when trying to upgrade to 18.09? Else I can't quite
understand how gnome3 would pull in gdm.
A display manager is simply used to log into a desktop manager/environment
like xfce.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/47945#issuecomment-427664724,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACi3ePKi5t_yk3LcXzqod3xs2NV8xLbuks5uiiZ4gaJpZM4XLDMv
.

The root cause should've been addressed in https://github.com/NixOS/nixpkgs/pull/48080.


Stabilize the storage format

Update the storage format version number from 0 to 1.
Update documentation (at least comments) on code and types that participate in the storage format (including the semantics of integer values such as psa_key_type_t, psa_algorithm_t, etc.) to indicate that existing items must not be changed without updating the storage format version.
Update the storage format documentation.

Note that https://github.com/ARMmbed/mbedtls/issues/3276 will change the encoding of key policies, so it will change the storage format.

As discussed on a side channel, we'd very much appreciate having a compile-time option to parse version '0' as if it were version '1' (as long as version 0's state as of 2.25 is compatible with version 1).

As discussed on a side channel, we'd very much appreciate having a compile-time option to parse version '0' as if it were version '1' (as long as version 0's state as of 2.25 is compatible with version 1).


QueueManager has memory consistency issues

The last few days, I have been experimenting with making a Plex Music Player for Alexa.
However, I have run into some issues regarding Python and shared memory access.
I have tried both the Queue and collections.deque methods to build a QueueManager with, as displayed in your example samples/audio/playlist_demo
However, with both solutions, I run into the problem that global memory access and Flask doesn’t correspond well together.
Most of the times, it is possible to access the information provided in the queue.
For example, I have written a method that allows Alexa to describe the song being played.
However, this is not always the current song being played. Sometimes, it responds with a previously played song or None. As these are previous values of self._current, the problem probably lies in the fact that there is no coherency between memory here.
Have you perhaps also experienced this issue, and if so, is there a viable solution to working with shared memory for these values? Following Python documentation, collections.deque should provide thread-safe implementations for both pop* and append*. However, when I’m requesting the lengths of the current queue’s for example, they sometimes return as 0, which relates to the same problem.

I've not seen this using the Queue manager can you make it happen doing specific actions?
Off topic how are you getting a URL to play  Plex music on the Alexa? I keep getting URLs that return Bad Request. Using the Plex API.

When testing the Alexa Skill, I implemented a WhatSongIntent that returns information about the current song. When calling this intent multiple times during the same song, sometimes, it returns the name of the current song or the name of a previously played song (therefore, outdated memory access somewhere)
Mostly, the bad requests are due to not providing https streams. I'm using a Plex relay server, that enables https (the one that you use when accessing Plex through plex.tv). I'm planning on writing some GitHub documentation this afternoon and putting the current code online :)

i noticed you're using heroku, which i believe uses gunicorn. gunicorn uses a pre-fork worker model where each fork actually shares the same memory addresses, but they in fact keep separate copies of data. since the queue manager is a module level variable, you'd be getting two separate copies, which is by design with a preform worker model. this is just off the top of my head and i could be wrong about your particular use case, but it sounds like what's going on from my naive vantage point.

@johnwheeler Thank you very much for your insight. It seems that it was caused by Gunicorn, as suggested. I changed from Gunicorn to Waitress, without any memory inconsistency problems. (although it has a slower response rate)


Add high-precision mode

Initial idea as to how to do this without sacrificing all readability. The truly constant constants had to go :(
Metanorma PR checklist

[ ] Breaking changes (list related PRs)
[ ] Documentation update required (create task for this)
[ ] External dependency introduced (documentation update need)
[ ] Gem with native library introduced

One idea would be to make configuring the number of accurate significant digits an option (possibly straight away as the parameter given to set_precision, with 0 standing for ye olde ruby double floats?), BigDecimal should allow this...
I find it likely though, that long before floating-point precision proves to be the real (ha ha) bottleneck in getting accurate here, the formulae themselves will be... pretty sure the Pi and the square root of 2 are currently the most accurate among them :)

@newbthenewbd How do we test the high-precision mode? Is this mergable now?

So long as the way it is now (with only two options, :normal and :high) suffices, should be good to merge, yeah, if only it didn't rot since I last looked at it haha :)
Example usage:
require "bigdecimal"
require "atmospheric"

H = BigDecimal("32000.0")

#Atmospheric::Isa.set_precision(:normal) # This is the default
Atmospheric::Isa.set_precision(:high)

h = Atmospheric::Isa.geometric_altitude_from_geopotential(H)
TK = Atmospheric::Isa.temperature_at_layer_from_geopotential(H)
TC = Atmospheric::Isa.temperature_at_layer_celcius(H)
p_mbar = Atmospheric::Isa.pressure_from_geopotential_mbar(H)
p_mmhg = Atmospheric::Isa.pressure_from_geopotential_mmhg(H)
rho = Atmospheric::Isa.density_from_geopotential(H)
g = Atmospheric::Isa.gravity_at_geopotential(H)
p_p_n = Atmospheric::Isa.p_p_n_from_geopotential(H)
rho_rho_n = Atmospheric::Isa.rho_rho_n_from_geopotential(H)
root_rho_rho_n = Atmospheric::Isa.root_rho_rho_n_from_geopotential(H)
a = Atmospheric::Isa.speed_of_sound_from_geopotential(H)
mu = Atmospheric::Isa.dynamic_viscosity_from_geopotential(H)
v = Atmospheric::Isa.kinematic_viscosity_from_geopotential(H)
lambda = Atmospheric::Isa.thermal_conductivity_from_geopotential(H)
H_p = Atmospheric::Isa.pressure_scale_height_from_geopotential(H)
gamma = Atmospheric::Isa.specific_weight_from_geopotential(H)
n = Atmospheric::Isa.air_number_density_from_geopotential(H)
v_bar = Atmospheric::Isa.mean_air_particle_speed_from_geopotential(H)
omega = Atmospheric::Isa.air_particle_collision_frequency_from_geopotential(H)
l = Atmospheric::Isa.mean_free_path_of_air_particles_from_geopotential(H)

puts ["H = " + H.to_s, "h = " + h.to_s, "TK = " + TK.to_s, "TC = " + TC.to_s, "p_mbar = " + p_mbar.to_s, "p_mmhg = " + p_mmhg.to_s, "rho = " + rho.to_s, "g = " + g.to_s, "p_p_n = " + p_p_n.to_s, "rho_rho_n = " + rho_rho_n.to_s, "root_rho_rho_n = " + root_rho_rho_n.to_s, "a = " + a.to_s, "mu = " + mu.to_s, "v = " + v.to_s, "lambda = " + lambda.to_s, "H_p = " + H_p.to_s, "gamma = " + gamma.to_s, "n = " + n.to_s, "v_bar = " + v_bar.to_s, "omega = " + omega.to_s, "l = " + l.to_s]

Making H a BigDecimal should not be necessary, as the variable gets converted on contact with the BigDecimals in the library, so this works too:
require "atmospheric"

H = 32000.0

#Atmospheric::Isa.set_precision(:normal) # This is the default
Atmospheric::Isa.set_precision(:high)

# ...

But using BigDecimals all along, like in the prior example, would better guard against errors accumulating before the library gets to work on it :)


alternative plan for triton on windows

could someone used an alternative plan to replace the triton package in windows

Your only option at the moment is to use the cuda branch or WSL2. I got pretty close to getting triton to compile on Windows. Unfortunately, I don't know enough about CMAKE to make it work. There was a commit back in February that made changes to allow it to compile, but that build may be too old to work with this.

有人可以使用替代计划来替换 Windows 中的 triton 包吗

The CUDA version works well on Windows (without using WSL2). What is the reason for caching Triton? Is it for higher performance?

could someone used an alternative plan to replace the triton package in windows

The CUDA version works well on Windows (without using WSL2). What is the reason for caching Triton? Is it for higher performance?

could someone used an alternative plan to replace the triton package in windows

The CUDA version works well on Windows (without using WSL2). What is the reason for caching Triton? Is it for higher performance?

yes


not all 0.1.2 release elements are available in npm

Recent release 0.1.2 https://github.com/material-components/material-components-web-components/commit/8021304a412cb41bc874b04aee578aa907435b53
has many elements which are not available in npm. Are these not in sync?

Please see the disclaimer on the top of the README at https://github.com/material-components/material-components-web-components#material-web-components They will be published to NPM once we are satisfied with the working versions.


Conform to golang standard generated code comment

https://golang.org/s/generatedcode
Reference: https://github.com/golang/go/issues/13560

Fixed by #329


Bed Sleeping Action Not Working

Description
While the other ways were fixed last week, sleeping via bed action still doesn't work.

dupe


My bot is creating buy orders for items not in the pricelist

My bot recently just added 5 buy orders for the following items: Strange Professional Killstreak Direct Hit, Mega Strike Taunt: The Killer Solo, Skill Gotten Gains Taunt: Square Dance, Skill Gotten Gains Taunt: Rock, Paper, Scissors, Good-Hearted Goodies Taunt: The Killer Solo.
None of the items above are in the pricelist.
I don't know how to reproduce the behaviour, because i have no idea how the bug happened.
I expect the bot to only create buy orders for items in the pricelist.
This has happened a few times before. A backpack.tf admin contacted me a week ago about this issue. He said i'd recieve a ban if this kept happening.

Version: v4.4.7.

Are you sure about that? The bot should never add something by itself.

I don't know how the listings got added, maybe my api key got revealed to somebody?

Sorry for the very long delay.
Probably. It's safe to revoke your Backpack.tf API key and get a new one, and also for the Access Token.
I am closing this because I do believe the bot is not instructed to do such a thing.


Benefits over current approach

Hey,
Just out of curiosity, what are the benefits of using this over Reachability or SCNetworkReachability.
My impression is that this would allow for faster feedbacks into the connection status by using pinging, is that it?
Thanks!

ping is introduced to handle the situations below (I called that fake connection):

wifi network needed to be verify in the portal, if not , the connection is useless
signal too weak for your request
wifi router maybe no lan connect
Another optimization is FSM, that make sure state change is really change, can not be 1 to 1.


Dynamic Tabs for TabContainer

See also: https://github.com/xh/toolbox/pull/430
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

I will create a seperate branch to add the x affordance as part of the toolkit.  Hard to do it generally without a fixed size tab and/or better delineation between tabs.

Remaining issues:

See tabCloseAffordance branch for an example of how we could build the affordance in to the tab.  Not sure if this is strictly neccessary.  Seems like doing it properly requires a bit better seperation of tabs, and constant size tabs, a la Chrome.


Not working

Modified the Nerofest script with my own skills, press play and it shows this screen

this is the script
https://pastebin.com/raw/bDH1nJ3Q

This is an issue regarding Support. Can you screenshot or post your support settings here?

Nevermind, the code was on the bottom. You need to have "" after the Craft Essence selection. Even if you don't want anything specific. Please place empty pair of " or "Any" will work too.

Sorry, could you tell me which line should i modify?
thanks!

Line 36, the line is currently:
Support_PreferredCEs =
It needs to be:
Support_PreferredCEs = ""

Isn't the line
Support_PreferredCEs = "*cheer_for_master.png"
Since i need the macro to identify a MLB CFM CE for farming purposes

If that is what you need, then yes. But leaving it blank with no quotes makes it nil, which is the error that was thrown.

It seems it was because i was using ankulua 8.3.0, installed 8.5.2 and it works fine

Great! What's important is that it works now :D

Yeah, almost all of these newly posted issues are caused by a old cracked version of ankulua 8.3.0 that was posted on 4chan.
just make sure to ask which version are they using for now


onItemDropped not working

onItemDropped doesn't seem to be called when dragging an item outside the inventory.
It does work when the inventory is resized.

Sorry for that, this have been fixed in my latest commit to master


Theme color doesnt apply to access denied dialog

Description

The selected theme color override doesnt apply to access denied dialog. May also happen to other dialogs (didnt checked)
Steps To Reproduce

Override theme color in settings.
Get the dialog.

Requirements
Fix theme not applying to dialogs.
Files Version
<IP_ADDRESS>
Windows Version
Windows 10 Pro Release Version 21H2 | OS Build 19044.3086
Log File
debug.log

Thanks for the report, I've added this to the project board.

This is currently by design, would you mind opening a separate issue using the feature request template so that we can track feedback from other users?


Add middleware to skip token authentication in development

Allows developers to skip token authentication. See documentation.

Pull Request Test Coverage Report for Build 210

3 of 10 (30.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 91.279%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/middleware/user_authentication.rb
3
10
30.0%

Totals

Change from base Build 204:
-0.4%

Covered Lines:
1570

Relevant Lines:
1720

💛  - Coveralls


Crash when pinch and zoom on Chrome for Android

Hi,
Using Cropper v2.3.4 (the current version provided by bower), it crashes when zooming with the "pinch and zoom" gesture on Chrome for Android. Once crashed, I can't zoom nor move the image, and the data is corrupted. It crashes too on the official example (http://fengyuanchen.github.io/cropper/v2.3.4/). I disabled it with the option zoomOnTouch:false and there is no problem.
I created "zoomIn" and "zoomOut" buttons that execute the "zoom" function, and they work before pinchAndZoom, but fail after the gesture has been performed. Thus the gesture must break something when preformed.
I haven't seen this problem with the 3.0.0-alpha.1 version.
Is it related to the warning "Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080" raised by Chrome for Android browser at each touchMove gesture ?
Can you see to that ? I know that v3 is on tracks, but I'd rather use a "release" version for my site :)
Thanks !
BR,
Simon
Bug seen on :
Android 6.0.1; Nexus 5 Build/MOB31E and Android 7.0.0; ONEPLUS A3003 Build/NRD90M
Chrome 56.0.2924.87
Works on iPad, iPhone and desktop browsers

Sorry for the trouble, this is a breaking change in Chrome 56 to improve scroll performance.  This can probably be fixed by adding an appropriate touch-action CSS rule to disable the browser's own scrolling/zooming.

Adding the CSS rule touche-action:none disable the warning, but cropper still crashes. So this is probably related to the way cropper handles the touches. The pointer events API may have been changed too ?
++

@SimonBriche see #827

Perhaps the console warning isn't related to the crash at all then (there's two separate issues).

The latest version already fixed this.

v3.x doesnt crash anymore but now I cant move/drag the picture after zooming in. This problem only occurs in chrome(mobile). Everywhere else it works perfectly. I also checked and made sure I added dragMode: 'move'... and I also tried to apply touch-action:none; to the div...both of those didnt work. I feel like I am missing something. Please let me know how I can fix this. Thank you so much.

hey @Mebakassahun , did you come up with a solution for this? have the same issue a while back. Any fixes  you did for this?


Add bug-bounty page

We need a highly visible place for security researchers to find our bug bounty program and learn our preferred process of responsible disclosure.
Example of our current biggest bug bounty:
https://github.com/MetaMask/metamask-extension/issues/3127
A couple examples from other projects:

https://aave.com/bug-bounty
https://www.argent.xyz/argent-bug-bounty/

Created already :) https://metamask.io/security/


Multi-level doesn't work in mobile or with narrow menu

Awesome template! Minor flaw where multi-level doesn't work in mobile or with narrow menu.
How to reproduce:

enable mobile view in devtools (or click icon to switch from nav-md to nav-sm)
click multilevel (to see the popout menu)
click the second "level one" dropdown
whole popout menu closes/disappears

This only occurs on mobile or narrow (nav-sm), not desktop view.

I can second this issue, we have a go-live in a couple months and would love to see this fixed before then if at all possible!  TIA!

Thank you for pointing this out, we will take care of it as soon as possible.

Why have you closed it, it hasn't been fixed as of October? Surely you should leave it open until you fix it? It clearly is a problem as when you click the burger to go to the narrow menu the multi level menu doesn't work, you click and nothing happens. As far as I can tell the fix is to edit custom.js around line 85 to change from this:
if ( $BODY.is( ".nav-sm" ) ) { 	$SIDEBAR_MENU.find( "li" ).removeClass( "active active-sm" ); 	$SIDEBAR_MENU.find( "li ul" ).slideUp(); }
to this:
if ( $BODY.is( ".nav-sm" ) && !$li.parent().is('.child_menu') ) { 	$SIDEBAR_MENU.find( "li" ).removeClass( "active active-sm" ); 	$SIDEBAR_MENU.find( "li ul" ).slideUp(); }
It may be possible to pop out again though like bootstrap does rather than slide which may look neater.

@AndreiCN - maybe leave this one opened? You marked as duplicate but I couldn't find a copy of this issue. If it's an actual duplicate, please reply with the ticket #id number and close this one.

@philipcj this is the same issue from #490 am I right ?

Yes I think so. At first glance the solution on #490 is similar to the one I suggested also.On 31 October 2017 at 09:01 AndreiCN<EMAIL_ADDRESS>wrote:@philipcj this is the same issue from #490 am I right ?—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Ok , I've marked that closed because it's solved already so this one is a duplicate but the update it's not available just yet.

Great. I am going to have to consider the option of secondary level menus coming out like bootstrap does. Is there a place I can make this suggestion?
Sent from my iPhone

On 31 Oct 2017, at 09:08, AndreiCN<EMAIL_ADDRESS>wrote:
Ok , I've marked that closed because it's solved already so this one is a duplicate but the update it's not available just yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sounds great, you can create a PR with it.

A fix for the menu bug ( both responsive and desktop nav-sm ) will be available soon.
Thankyou


chore: make roadmap issues mini dashboards

I was thinking too, that we should link to the individual team roadmaps from the main roadmap.


Cache entries are not expiring

When the routing changes, we still keep the cached entries like routing and addressing There is no TTL that will automatically refresh the cache entries after a certain amount of time.
We should add an option in the server config for TTL refresh
Put this on 5 minutes?

Instead of using TTL we can ignore the cache at all during retries. So on the first attempt it will use the cache but if the delivery fails then it will move to retry queue and it will ignore the cache on the next attempts.

fixed by #101


The download links of datasets error

Sorry for the inconvenience.
I also found that there are issues with my dropbox links.
I will fix them as soon as possible.

All the links are fixed.
Feel free to contact me if you still meet problems.
Thank you.


#2800 Add isEmpty() to ArrayUtils

#2800

Codecov Report

Merging #2802 into master will increase coverage by <.01%.
The diff coverage is 20.45%.

@@            Coverage Diff             @@
##           master    #2802      +/-   ##
==========================================
+ Coverage   40.78%   40.79%   +<.01%
==========================================
  Files        1775     1775
  Lines       61197    61266      +69
  Branches     8600     8608       +8
==========================================
+ Hits        24962    24993      +31
- Misses      36235    36273      +38

Impacted Files
Coverage Δ

...t/collector/cluster/route/DefaultRouteHandler.java
65% <0%> (ø)
:arrow_up:

...a/com/navercorp/pinpoint/test/PluginTestAgent.java
0% <0%> (ø)
:arrow_up:

...erceptor/CxfClientInvokeSyncMethodInterceptor.java
75% <100%> (ø)
:arrow_up:

...ercorp/pinpoint/profiler/util/JavaAssistUtils.java
79.69% <100%> (ø)
:arrow_up:

...point/bootstrap/AgentDirBaseClassPathResolver.java
52.7% <100%> (ø)
:arrow_up:

...p/pinpoint/profiler/instrument/JavassistClass.java
17.75% <100%> (ø)
:arrow_up:

...avercorp/pinpoint/test/MethodDescriptionUtils.java
86.66% <100%> (ø)
:arrow_up:

...point/common/server/util/ApiDescriptionParser.java
83.67% <100%> (ø)
:arrow_up:

...rp/pinpoint/common/server/util/AgentEventType.java
80% <100%> (ø)
:arrow_up:

...ercorp/pinpoint/profiler/util/ByteBufferUtils.java
91.66% <100%> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657c23f...7b1af81. Read the comment docs.


public IP should specify standard SKU

The bastion host fails to create if the public IP SKU is not "standard"..
az network public-ip create -n AzureBastionIp -g <rg> --sku Standard
az network bastion create --name stubastion -g <rg> --vnet-name <vnet> --public-ip-address <pip>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a45429a-0c49-80f0-a5fa-1de707059375
Version Independent ID: 0e5d368f-a562-2ce9-3261-3e4443b08a18
Content: Create a Bastion host using Azure CLI
Content Source: articles/bastion/create-host-cli.md
Service: bastion
GitHub Login: @mialdrid
Microsoft Alias: mialdrid

@kewalaka Thank you for your feedback . We will investigate and update the thread.

@kewalaka Thanks for the feedback! Public IPs are created with SKU 'basic' by default, it is necessary to specify the SKU. I have updated the script in the doc to specify the standard SKU, and the doc will update this change within 24 hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.