vpcs fails to build

Message:
==> make -f Makefile.osx
gcc   -DDarwin -Di386 -DHV -Wall  -c vpcs.c
gcc   -DDarwin -Di386 -DHV -Wall  -c daemon.c
gcc   -DDarwin -Di386 -DHV -Wall  -c readline.c
gcc   -DDarwin -Di386 -DHV -Wall  -c packets.c
daemon.c:53:18: fatal error: util.h: No such file or directory
compilation terminated.
Makefile.osx:38: recipe for target 'daemon.o' failed
make: *** [daemon.o] Error 1

I already have a fix for this; I'll submit it after the freeze is over.

I think there's something wrong with the bottle, so I'm reopening this. I didn't pull the bottle anyways

You can use https://github-issue-mover.appspot.com to migrate issues to Linuxbrew/homebrew-core.

This issue was moved to Linuxbrew/homebrew-core#129


Fix crash when using Plain Text

Description
Fixes #128
Prior to this PR, using Plain Text would crash the application.

Thank you @andrewda. Much appreciated as always.


Make FileChangedChecker and Dependency classes more flexible to allow for cloud based file dependencies

Description
Enable doit to track file dependencies for remote file systems such as AWS S3.
doit tracks file dependencies via file_dep in the task dictionary. File dependencies are checked via the dependency.FileChangedCheckerClass, which indicates whether a file is up to date or not. The FileChangedChecker class if of the form
class FileChangedChecker:
    def check_modified(self, file_path, file_stat, state):
        ...
        return True  # if file is modified
    def get_state(self, dep, current_state):
        state = ...
        return state

doit provides two builtin implementations, MD5FileChangedChecker and TimestampFileChangedChecker, which respectively use the md5 hash and the timestamp to check if a file has changed.
The class is customizable, the user can provide a CustomFileChangedChecker class as documented here https://pydoit.org/cmd_run.html#custom-check-file-uptodate:
DOIT_CONFIG = {'check_file_uptodate': CustomFileChangedChecker}

This should provide a route to handle remote filesystems such as AWS S3. However, in doit's latest version (v0.33), the file_stat argument that is passed to FileChangedChecker.check_modified is computed by os.stat in dependency.Depenency. In addition, dependency.Dependency uses os.path.exists to check if a target exists. The dependency.Dependency class isn't itself customizable so AFAICT both calls should be updated to enable handling remote storage/filesystems such as AWS S3 via a custom FileChangedChecker.
Proposed implementation
Add two methods to FileChangedChecker, exists and info that can be called by dependency.Dependency instead of the currently hard coded os.path.exists and os.stat.
class FileChangedChecker:
	def exists(self, file_path):
	    """Return True if file_path exists, False otherwise."""
		return os.path.exists(file_path)   # default implementation

	def info(self, file_path):
	    """Return some metadat about the file at file_path."""
		return os.stat(file_path)         # default implementation

    def check_modified(self, file_path, file_stat, state):
        ...
        return True  # if file is modified
    def get_state(self, dep, current_state):
        state = ...
        return state

See PR https://github.com/pydoit/doit/pull/407
Example dodo.py
"""
Example dodo.file with S3 file_dep.
"""
from doit.tools import Interactive
from doit.dependency import FileChangedChecker
import s3fs  # TODO: should just use boto3 here to keep things simple
import os

class S3FileChangedChecker(FileChangedChecker):
    """Check if S3 File is up to date

    Assumes that FileChangedChecker has two additional methods
    `exists` and `info` that are called within
    `doit.dependency.Dependency` instead of `os.path.exists` and
    `os.stat`.
    See https://github.com/pydoit/doit/pull/407
    """
    CheckerError = FileNotFoundError

    def exists(self, file_path):
        # target might be local so handle both cases
        if file_path.startswith('s3://'):
            fs = s3fs.S3FileSystem()
            return fs.exists(file_path)
        else:
            return os.path.exists(file_path)

    def info(self, file_path):
        # for now this assumes the file is in s3
        fs = s3fs.S3FileSystem()
        raw_info = fs.info(file_path)
        # make sure the result is JSON serializable
        return {key: str(value) for (key, value) in raw_info.items()}

    def check_modified(self, file_path, file_stat, state):
        """Check if file in file_path is modified from previous "state".

        file_path (string): file path
        file_stat: result of os.stat() of file_path
        state: state that was previously saved with ``get_state()``

        returns (bool): True if dep is modified
        """
        if file_stat['ETag'] != state['ETag']:
            return True

        return False

    def get_state(self, dep, current_state):
        """Compute the state of a task after it has been successfully executed.

        dep (str): path of the dependency file.
        current_state (tuple): the current state, saved from a previous
            execution of the task (None if the task was never run).

        returns (dict|None): the new state. Return None if the state is unchanged.
           state is of the form
           {
            'ETag': '"ed076287532e86365e841e92bfc50d8c"',
            'Key': 'ssr-scratch/hello.txt',
            'LastModified': datetime.datetime(2021, 11, 27, 17, 54, 45, tzinfo=tzutc()),
            'Size': 12,
            'size': 12,
            'name': 'ssr-scratch/hello.txt',
            'type': 'file',
            'StorageClass': 'STANDARD',
            'VersionId': None
           }

        The parameter `current_state` is passed to allow speed optimization,
        see MD5Checker.get_state().
        """  # noqa
        state = self.info(dep)
        if current_state and (
                current_state['LastModified'] == state['LastModified']):
            # state not change, returning None
            return
        else:
            return state

DOIT_CONFIG = {
    'check_file_uptodate': S3FileChangedChecker
}

def task_s3_download():
    """Download file from s3"""
    return {
        'file_dep': ['s3://ssr-scratch/remote_hello.txt'],
        'targets': ['local_hello.txt'],
        'actions': [Interactive(
            'aws s3 cp  s3://ssr-scratch/remote_hello.txt local_hello.txt'
        )],
    }

Alternatives
Use a custom uptodate checker and define dependencies between tasks using task_dep. An example implementation of the uptodate checker is given below. This doesn't require any change to pydoit to handle S3 file_deps or targets (or even a mix of local and S3 files). Sort of the breaks the "there should be only one way to do it" principle, so using "proper" file_deps and targets as shown above is probably preferable?
import os
from doit.dependency import get_file_md5
import s3fs  # TODO: should just use boto3 here to keep things simple

class FileDepsAndTargetsUptodate:
    def __init__(self, file_deps=None, targets=None):
        """Check whether all input file_deps and targets are up to date

        file_deps (List[str]): input paths. Local filesystem or S3.
        targets (List[str]): output paths. Local filesystem or S3.
        """
        self.file_deps = file_deps or []
        self.targets = targets or []

    def __call__(self, task, values):

        def save_hashes():
            hashes = {
                'path': self._info(path)['hash'] for path in self.file_deps
            }
            return {'hashes': hashes}

        print(task)
        task.value_savers.append(save_hashes)

        # If any target path is missing, file isn't up to date
        if not all(self._exists(path) for path in self.targets):
            return False

        # If any input file's changed, file isn't up to date
        previous_hash = values.get('hashes', {})
        if not previous_hash:
            return False
        else:
            is_uptodate = {
                path: previous_hash['path'] == self._info(path).get('hash')
                for path in self.file_deps
            }
            return all(is_uptodate.values())

    def _exists(self, file_path):
        if file_path.startswith('s3://'):
            fs = s3fs.S3FileSystem()
            return fs.exists(file_path)
        else:
            return os.path.exists(file_path)

    def _info(self, file_path):
        if file_path.startswith('s3://'):
            fs = s3fs.S3FileSystem()
            raw_info = fs.info(file_path)
            return {
                'hash': raw_info['ETag'],
                'type': 'ETag',
                'orig_info': raw_info
            }
        else:
            stats = os.stat(file_path)
            return {
                'hash': get_file_md5(file_path),
                'type': 'MD5',
                'orig_info': stats
            }

# example dodo task using uptodate
def task_s3_download():
    """Download file from s3"""
    return {
       'actions': [Interactive(
            'aws s3 cp  s3://ssr-scratch/remote_hello.txt local_hello.txt'
        )],
       'uptodate': [
           FileDepsAndTargetsUptodate(file_deps=['s3://ssr-scratch/remote_hello.txt'], targets=['local_hello.txt'])
       ]
    }

There is also #397 "Custom up-to-date strategy" that should be taken into account.
doit was designed so that file checks are supposed to be fast (executed many times).
Making this check over a network might be too slow, so making it too easy to put remote files as file_dep might not be good idea.
Unless s3fs or boto has some kind of caching...
Anyway if you really want that I would not oppose the modifications on FileChangedChecker.
And we should add a new plugin type for FileChangedChecker...

My case is Machine Learning workflows for which there’s a handful of input files that are stored on S3. The tasks themselves are long to run (10-60mn) so checking file dependencies is negligible for me (also you can query the etag of the file stored in s3 directly rather than download the file itself).
For use cases with lots of input files and frequent checks, s3fs does have a caching layer (it’s actually not well documented and is on by default, seehttps://www.gudasoft.com/uncategorized/03/24/1754/how-s3fs-caching/2020).
The s3fs implantation is just an example, people could add their own implementation to suit their use case.
I am using doit as a nimble alternative to Airflow or Metaflow during the early research phase of a project.
If you’re happy with this change how should we proceed?

Cool. What’s the best approach? Am not too familiar with the plug-in system.
Sam
Sent from my iPhone

On 9 Dec 2021, at 17:07, eduardo naufel schettino @.***> wrote:

ok. merged that.
Do you plan to put this S3FileChangedChecker on a package or GIST?
I guess it would be nice to integrate this in one way or another into the docs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Check the "reporter" plugin. should be similar...
Not really required. Since you can set the Checker on dodo.py.

ok. merged that.
Do you plan to put this S3FileChangedChecker on a package or GIST? I guess it would be nice to integrate this in one way or another into the docs.

GIST link https://gist.github.com/samuelsinayoko/8c4f5da30132a099c3decf49849c59d8 to S3FileChangedChecker implementation


Misc updates to PivotPi docs and fix to I2C.State

Add Typespecs for PivotPi and PCA9685 along with doc updates
Fix I2C.State function...I considered typespecs, but I don't think the function should be a documented public function
Update README for minor version update from 4 to 5
Update channel in PivotPi test since channels on the board are only 1-8
One thing to note about channels, when communicating with the device the channels are 0-7 (servos) and 8-15 (leds).  The PivotPi module makes adjustments for what is labeled on the PivotPi board: 1-8 for servos/leds.  The PCA9686 module requires the channel used to communicate with the device, ie 0-15.

Let me know if you see any corrections you would like me to make.  I appreciate the feedback!

Thanks! 🤖


chore(deps): update common-dev-assets digest to ddd4511

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
9b0b7af -> ddd4511

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

GitHub release
v6.0.0

Your semantic-release bot :package::rocket:


Update the Book for 4.0

There are things in the book that have changed with Godot 4.0. For example, there is no more Navigation node.
Can the book be updated for Godot 4?

Thank you for your interest. Unfortunately, there are currently no plans to update the book for Godot 4. That being said, there are already a few Godot 4 books in the works from Packt. They will most likely come out later this year.

@mrunion I've been taking notes and adding an issue for each chapter detailing all the changes you need to make to get the examples running in Godot 4.2. I realize it might be a bit late for you, but it's available if you're interested. I should be done with the last chapter tomorrow.

That's awesome news! Sure, I'd be interested whenever this is ready.
Thanks!

@mrunion I've been taking notes and adding an issue for each chapter detailing all the changes you need to make to get the examples running in Godot 4.2. I realize it might be a bit late for you, but it's available if you're interested. I should be done with the last chapter tomorrow.


amuse-smalln depends on ph4

See #443

but please test

original problem fixed, but fails to build for me (similar to #444 now).

Actually, that was a caching problem. This is fixed.


Fix Fighter_FaithfulMount

@ParreaBob need more information here, also see #13

@ParreaBob What was going wrong here? Could you please add details of the buggy behaviour, how to reproduce it and what was expected?

The command suggests that a cavaliers mount will grab his body and take it back to the recall location.
What actually happens is the mount and the body (and all equipment lol) disappear and never return lol

I would have to add it to a cavalier. I removed the ability from the class

Thanks I'll test it locally. Technically it disappeared into a hidden room. This is somewhat different from the quickchange skill issue. Here the implementation

moves the corpse into the mounts inventory
puts the mount into a hidden room and then
tries to reach the player every 10 second but only a limited number of times...

So its more or less by design to not be accessible after a while (e.g. if you die and immediately log out.)
Need to test, to understand if there is a real bug, or if its just a broken user experience.

20241222.1138.02 debug Fighter_Faithf Death event triggered for Flar
20241222.1138.02 debug Fighter_Faithf No suitable mount found for Flar

20241222.1138.02 debug Fighter_Faithf Death event triggered for Alice
20241222.1138.02 debug Fighter_Faithf No suitable mount found for Alice

Yes it does

20241222.1215.47 debug Fighter_Faithf Trailer runnable started for Alice
20241222.1215.47 debug Fighter_Faithf Conditions met for corpse retrieval
20241222.1215.47 debug Prop_ArenaSpec executeMsg called with message:
20241222.1215.47 debug Fighter_Faithf Corpse found: the body of Alice
20241222.1215.47 debug Fighter_Faithf Trailer runnable started for Alice
20241222.1215.47 debug Fighter_Faithf Conditions met for corpse retrieval
20241222.1215.47 debug Fighter_Faithf Corpse not found for Alice
20241222.1215.47 debug Fighter_Faithf Corpse moved to mount: a horse

Additional mechanics:

the horse will move out of the room, but only if no other potential "rider" is present.
if a rider is present and in the same room, the horese will stop there and do nothing with the body in inventory.

The implementation suggests that at least two final states exist that remove the corpse from the players reach completely.
Based on this understanding the skill is considered unusable and will be removed.


Add an open-source license to the repo

Otherwise it's merely code and not open-source :)

Thanks for the reminder, there's a few new repos that need their license added!

Fixed in eadda0f483c4638918755ce0c50a3d4993801227


Clean up utils

Summary
Refactors some utility functions in utils.cpp and utils.h.

Uses constexpr where possible.
Makes sgn templated to support integer types and whatnot.
Changes angleError to use std::remainder.

Motivation
Takes advantage of newer cpp features to either simplify or improve the existing utilities.
Test Plan
TBD
Additional Notes
Nope

Will merge upon testing. Confirming chassis::follow() and chassis::moveTo() will be sufficient


Changes to GLUI assets

Delete/replace the colored icons, since we can color them in code.

Some issues now you might want to look into -
with the themes where white is the color for the footer, the passive tab icons no longer seem to be visible, only the active one is.

@twinaphex https://github.com/rz5/RetroArch/blob/master/menu/drivers/materialui.c#L852
Merge my fork, I created an extra variable that seems to be responsible for the passive tab icon color.


Ensure ready condition set if failed first time

Fixes #39
Signed-off-by: Hasan Turken<EMAIL_ADDRESS>
Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Looks like we are having issues on CircleCI.
Verified locally and force merging as discussed with @hasheddan


Nord theme for kpm-list

Good day!,
I have really been enjoying Nord!  Now I am at the point of starting to tweak little things here and there.
  But the default colors were absolutely clashing with Nord. It was jarring, and that is a buffer that I use quite a lot.
So last night, I decided to sit down and fix that. I think that what I came up with was pretty workable:

All the credit goes to @arcticicestudio (and others (are there any others?)) for picking out a really nice color palette and writing some great documentation which makes it really easy for even a total sperg like myself to adapt/apply them to new situations and places.  Thanks again for all your effort.  And for sharing.  :beers:
I had made a thread over there at kpm-list last night but figured I would make another here, too.  I can't imagine that the union in the Venn diagram between the two projects is a very large number of people :smile: but you never know.  Anyway a little cross pollination / promotion is never bad for great F/LOSS projects anyway.  :wink:  Maybe some people finds one or the other project useful.
I am not even sure I did this "properly" (any Emacs theming tips are welcomed!) but I got it to work by putting the following in my Emacs init to override the defaults.
Of course you can set the colors directly by hex value, but I find this way of aliasing them easier to work with.  Especially when "playing around" and tweaking things.  Just make sure you assign the color palette variables (nord0...16) earlier on in the init loading then when you need to use them (in case you end up using them in multiple places to override other things as well, like I do).
  ;; Ripped from:
  ;; https://github.com/arcticicestudio/nord-vim/blob/develop/colors/nord.vim
  ;; as it was most faithful (that I found in 5 second search ;) ) to:
  ;; https://www.nordtheme.com/docs/colors-and-palettes
  ;; whilst having easiest format to modify to my needs

  ;; Dark Backgrounds "Polar Night"
  (setq nord0 "#2E3440") ; darkest
  (setq nord1 "#3B4252")
  (setq nord2 "#434C5E")
  (setq nord3 "#4C566A") ; lightest

  ;; Light Backgrounds "Snow Storm"
  (setq nord4 "#D8DEE9") ; darkest
  (setq nord5 "#E5E9F0")
  (setq nord6 "#ECEFF4") ; lightest

  ;; Heart Palette (bluish colors) "Frost"
  (setq nord7 "#8FBCBB") ; lightest / highest contrast
  (setq nord8 "#88C0D0") ; primary UI elements
  (setq nord9 "#81A1C1") ; secondary UI elements
  (setq nord10 "#5E81AC") ; darkest / lowest contrast, tertiary

  ;; Colorful Accents "Aurora"
  (setq nord11 "#BF616A") ; reddish
  (setq nord12 "#D08770") ; orangeish
  (setq nord13 "#EBCB8B") ; yellowish
  (setq nord14 "#A3BE8C") ; greenish
  (setq nord15 "#B48EAD") ; purpleish

  (set-face-attribute 'kpm-list-buffer-face nil
		      :foreground nord4)

  (set-face-attribute 'kpm-list-buffer-highlight-face nil
		      :foreground nord14)

  (set-face-attribute 'kpm-list-directory-face nil
		      :foreground nord8)

  (set-face-attribute 'kpm-list-header-face nil
		      :background nord1
		      :foreground nord7)

  (set-face-attribute 'kpm-list-mode-face nil
		      :foreground nord7)

  (set-face-attribute 'kpm-list-modified-face nil
		      :foreground nord11)

  (set-face-attribute 'kpm-list-old-path-face nil
		      :foreground nord10)

Hi @TRSx80 :wave:, thanks for your contribution :+1:
Again a great and detailed documentation 😉
Adding support for other packages is always welcome.
Your prototype already looks great. The only part I'd change is to use nord8 instead of nord7 for the section headings since it's the main accent color.
Feel free to submit a PR so we can review and merge it into the theme.

The only part I'd change is to use nord8 instead of nord7 for the section headings since it's the main accent color.

I actually played with that quite a bit, IIRC.  If you look closely, there is some differentiation between regular directory font, old-path-face, etc. and I think I simply ran out of options/colors, or I couldn't get it to "look right" or... differentiation, or... something (it's been a little while now)?  Maybe it was that I started off by matching the default dired (directory editor, the Emacs file manager) directory color, for consistency reasons.  Anyway, if/when I circle back to this, I will definitely take your feedback into account on my second pass, so thanks.
Also, after I posted this, I realized that perhaps the better approach would be to talk to the kpm-list creator about maybe re-mapping his hard-coded colors to the "standard" alias ones in Emacs so they would automatically pick up whatever theme the user enabled.  Because most packages in Emacs seem to do it that way.  The couple times I changed themes the last few years, however, that package was always the only one standing out with it's own hard-coded separate theme.
Failing that, I will come back and re-visit this, perhaps submit a PR, etc.  In the meantime, anyone needing it is free to copy-paste what I posted and use it in their init file.  Everyone wins.  I just prefer to take the time and do the "right" approach.  Cheers!


Is backtest mode support microseconds history data ?

Thanks for the great repo!
I saw the config files writes the history data format is 'time_seconds,price,size,is_buyer_maker',
So I'm wondering if the backtest mode support more higher frequency than seconds? (some data I collect myself through websocket to exchanges )  Do I need to do some modifcation in source and config file?
another small question, by using the api crpyto-chassis provided, how to download a more frequent data such as less than one seconds? or maby I can only collect by myself ?

For trades, it is tick data, the time_seconds will have a fraction part. For order book data, it is 1-second granularity. So far I haven't found time modify the backtest code to accommodate for less than 1 second granularity order book data which will be a major revision. Also the order book data that we can provide is 1 second so that we can keep the cost under control. Thank you for your interest in our repository.

Thanks for reply!
Another two questions:
1、can I use 200ms trades tick data with 1-seconds orderbook for backtesting? or must be 1-second trade with 1-second book data?
2、why there's a limit for only can use 1-seconds  orderbook for backtesting ?  can you give me some advise about it ?

Thanks for reply! Another three questions: 1、can I use 200ms trades tick data with 1-seconds orderbook for backtesting? or must be 1-second trade with 1-second book data? 2、why there's a limit for only can use 1-seconds orderbook for backtesting ? can you give me some advise about it ? 3、when live-trading , what's the data frequency? Is there still a limit for using a 1-second orderbook data?

[1] uh, what do you mean by 200ms trades tick data? So trades tick data are tick data without any aggregation.
[2] If you use our market making app, then the backtest engine walk through the order book data in one-second clock ticks. If you have your own backtest engine, then any granularity will work. You'd just create a stream of Events in chronological order and walk through them one by one by calling processEvent(event).
[3] If you use our market making app, then the data frequency is 1 second. Otherwise if you really need order book tick by tick then https://github.com/crypto-chassis/ccapi/blob/v5.27.0/app/src/spot_market_making/config.env.example#L79.
Let me know whether the answers are satisfactory or not. If you have more questions, feel free to message me on https://discord.gg/b5EKcp9s8T.

great! thanks for your advice!


Dispose CTS in PostEvictionCallback

Fixes #28952

Internal previews

📄 File
🔗 Preview link

aspnetcore/performance/caching/memory.md
Cache in-memory in ASP.NET Core

@tdykstra  lets get @Tratcher  to approve this.


runtime: crash due to non-atomic pointer stores in memclr/memmove

The following program crashes when run with GODEBUG=invalidptr=1 GOARCH=386:
package main

import (
	"math/rand"
	"runtime"
)

func main() {
	P := 2 * runtime.GOMAXPROCS(0)
	ptrs := make([][]*int, P)
	for i := 0; i < P; i++ {
		i := i
		go func() {
			r := rand.New(rand.NewSource(int64(i)))
			var sink []byte
			p := make([]*int, 4)
			z := make([]*int, 4)
			ptrs[i] = p
			for {
				if r.Intn(20) != 0 {
					a := p[:1]
					a[0] = new(int)
					for j := range a {
						a[j] = nil
					}
					for j := range p {
						p[j] = new(int)
					}
					copy(p[:3], z)
					for j := range p {
						p[j] = new(int)
					}
					copy(p[1:4], z)
					for j := range p {
						p[j] = new(int)
						copy(p[j:j+1], z)
					}
				} else {
					sink = make([]byte, 8<<10)
				}
			}
			_ = sink
		}()
	}
	select {}
}

GODEBUG=invalidptr=1 GOARCH=386 go run memclr.go

runtime: pointer 0x18d90000 to unallocated spanidx=0x548 span.start=0x185d2000 span.limit=0x185d4000 span.state=3
runtime: found in object at *(0x18456000+0x0)
object=0x18456000 k=0xc22b s.start*_PageSize=0x18456000 s.limit=0x18458000 s.sizeclass=2 s.elemsize=16
 *(object+0) = 0x0 <==
 *(object+4) = 0x0
 *(object+8) = 0x18d9b354
 *(object+12) = 0x18d9b3b0
fatal error: found bad pointer in Go heap (incorrect use of unsafe or cgo?)

The problem is that memclr clears 4-byte regions on 386 with 2 separate 2-byte stores:
_3or4:
	MOVW	AX, (DI)
	MOVW	AX, -2(DI)(BX*1)

This exposes corrupted pointer to GC.
Not sure whether it can crash without invalidptr, I would not exclude such possibility. But it's clearly bad and can lead to false retention. Also it makes data race failure modes significantly worse, introducing exploitation possibilities like use-after-free and easy controlled overwrite.
There is similar issue in amd64p32 memclr which clears pointers with byte stores:
TEXT runtime·memclr(SB),NOSPLIT,$0-8
	MOVL	ptr+0(FP), DI
	MOVL	n+4(FP), CX
	MOVQ	CX, BX
	ANDQ	$3, BX
	SHRQ	$2, CX
	MOVQ	$0, AX
	CLD
	REP
	STOSL
	MOVQ	BX, CX
	REP
	STOSB
	RET

Similar issue in 386 memmove which moves pointer with 2 stores:
move_3or4:
	MOVW	(SI), AX
	MOVW	-2(SI)(BX*1), CX
	MOVW	AX, (DI)
	MOVW	CX, -2(DI)(BX*1)
	RET

Similar issue in plan9/386 memclr:
_1or2:
	MOVB	AX, (DI)
	MOVB	AX, -1(DI)(BX*1)

Similar issue in amd64 memclr:
_5through8:
	MOVL	AX, (DI)
	MOVL	AX, -4(DI)(BX*1)

Did not look at arm/ppc. I guess we just need to go through all of them one-by-one.
@rsc @randall77 @RLH @aclements @dr2chase @davecheney @minux @0intro @4ad

@ality

Amusingly arm/ppc are probably okay because we tracked this exact issue down in #12552. At the time I thought the other platforms were okay, but you're definitely right about the tails.

I checked all the memclr & memmove code, CL out for review.  It was just x86, the other architectures look ok to me.
The only other place we do byte-at-a-time copy is in the reflect.callX functions.  Both the source (a newly allocated chunk of memory) and the destination (the local stack) should be ok for non-atomic pointer copy.

This might be worth fixing for Go 1.5.2, if we release a Go 1.5.2.


Added more guiding principles

Description
Be clear in Power-Up guiding principles that Power-Ups should stand on their own, and work where Trello does.

cc @hamidp


Implement DecodeTOML

Codecov Report

Merging #2 (4d76cee) into main (ffa9c66) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main      #2   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          2       5    +3
  Lines        471     492   +21
  Branches      10      11    +1
=====================================
- Misses       471     492   +21

Impacted Files
Coverage Δ

src/TOML/Error.hs
0.00% <0.00%> (ø)

src/TOML/Parser.hs
0.00% <0.00%> (ø)

src/TOML/Utils/Map.hs
0.00% <0.00%> (ø)

src/TOML/Utils/NonEmpty.hs
0.00% <0.00%> (ø)

src/TOML/Value.hs
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa9c66...4d76cee. Read the comment docs.


oiiotool ignores --compression option when outputting multipart EXRs

When using EXR output and saving a multipart EXR, (either via building one via --siappend in oiiotool, or using as input an EXR that already is multipart) the --compression option is ignored and all EXR parts that are saved in any output file use default (zip) compression.
This occurs under current release (2.0.8) as well as the master branch (2.1.1dev). (running debian stretch, built for C++11)  bug is also present in iconvert.
We found this when trying to optimize some of our EXRs for read performance on another system.  When taking 'sample.exr' that has say R,G,B channels, plus a number of other named channels in the same view/part, let's call them SKY, WATER, FG.  We wanted to move the named channels into the second part of a new, multi-part file. (sample.exr has no compression in this case)
oiiotool -i sample.exr --dup --ch "R,G,B" --swap --ch "SKY, WATER, FG" --siappend --compression "none" -o output.exr
Will yield a file with zip compression (but, curiously a "compressionName" header field that says "none" despite the zip compression.)

I'll try to take a look at this today, thanks for the report.

I don't suppose you can send me (privately is ok) the exr file you start with? Or post a short oiiotool recipe for creating an exr file from scratch that shows the problem?

never mind, I can reproduce. Stay tuned

Fix posted as PR #2252

Sweet!


Bad Gateway error

[01-01-2016 21:50] Error downloading stash for Standard, exception details: System.Net.WebException: The remote server returned an error: (502) Bad Gateway.
at System.Net.HttpWebRequest.GetResponse()
at POEApi.Transport.HttpTransport.GetStash(Int32 index, String league, String accountName, Boolean refresh)
at POEApi.Transport.HttpTransport.GetStash(Int32 index, String league, String accountName)
at POEApi.Transport.CachedTransport.GetStash(Int32 index, String league, String accountName, Boolean refresh)
at POEApi.Model.POEModel.GetStash(Int32 index, String league, String accountName, Boolean forceRefresh)
at POEApi.Model.POEModel.getAllTabs(String league, String accountName, Stash stash)
at POEApi.Model.POEModel.GetStash(String league, String accountName)
[01-01-2016 21:50] System.Exception: Downloading stash for Standard, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues and include your DebugInfo.log
at POEApi.Model.POEModel.GetStash(String league, String accountName)
at Procurement.ViewModel.LoginWindowViewModel.LoadStashItems(Character character)
at Procurement.ViewModel.LoginWindowViewModel.d__6.MoveNext()
at System.Collections.Generic.List1..ctor(IEnumerable1 collection)
at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)    at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass2.<Login>b__1()    at System.Threading.Tasks.Task.Execute() [01-01-2016 22:07] Error downloading stash for Standard, exception details: System.Net.WebException: The operation has timed out    at System.Net.HttpWebRequest.GetResponse()    at POEApi.Transport.HttpTransport.GetStash(Int32 index, String league, String accountName, Boolean refresh)    at POEApi.Transport.HttpTransport.GetStash(Int32 index, String league, String accountName)    at POEApi.Transport.CachedTransport.GetStash(Int32 index, String league, String accountName, Boolean refresh)    at POEApi.Model.POEModel.GetStash(Int32 index, String league, String accountName, Boolean forceRefresh)    at POEApi.Model.POEModel.getAllTabs(String league, String accountName, Stash stash)    at POEApi.Model.POEModel.GetStash(String league, String accountName) [01-01-2016 22:07] System.Exception: Downloading stash for Standard, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues and include your DebugInfo.log    at POEApi.Model.POEModel.GetStash(String league, String accountName)    at Procurement.ViewModel.LoginWindowViewModel.LoadStashItems(Character character)    at Procurement.ViewModel.LoginWindowViewModel.<LoadItems>d__6.MoveNext()    at System.Collections.Generic.List1..ctor(IEnumerable1 collection)    at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass2.b__1()
at System.Threading.Tasks.Task.Execute()
[01-01-2016 22:24] Error downloading stash for Standard, exception details: System.Net.WebException: The operation has timed out
at System.Net.HttpWebRequest.GetResponse()
at POEApi.Transport.HttpTransport.GetStash(Int32 index, String league, String accountName, Boolean refresh)
at POEApi.Transport.HttpTransport.GetStash(Int32 index, String league, String accountName)
at POEApi.Transport.CachedTransport.GetStash(Int32 index, String league, String accountName, Boolean refresh)
at POEApi.Model.POEModel.GetStash(Int32 index, String league, String accountName, Boolean forceRefresh)
at POEApi.Model.POEModel.getAllTabs(String league, String accountName, Stash stash)
at POEApi.Model.POEModel.GetStash(String league, String accountName)
[01-01-2016 22:24] System.Exception: Downloading stash for Standard, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues and include your DebugInfo.log
at POEApi.Model.POEModel.GetStash(String league, String accountName)
at Procurement.ViewModel.LoginWindowViewModel.LoadStashItems(Character character)
at Procurement.ViewModel.LoginWindowViewModel.d__6.MoveNext()
at System.Collections.Generic.List1..ctor(IEnumerable1 collection)
at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass2.b__1()
at System.Threading.Tasks.Task.Execute()

P.S. I'm using the 1.9.8 version

P.S. I'm using the 1.9.8 version

As there are a high number of duplicate reports for this issue, please see the consolidated issue I have created for this here:
https://github.com/Stickymaddness/Procurement/issues/397
Please follow this issue for updates and ask any questions there.


fix: removing unnecessary statements.

What does the pull request do?

What is the current behavior?

see #11177
What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #11177

You can test this PR using the following package version. 11.0.999-cibuild0034286-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


move doc fragments about tunnelers to main article in ziti-docs

Relates to https://github.com/openziti/ziti-doc/pull/138

Can you ditch the FIXME: --use-openssl results in a build failure for arm, arm64 line in the README while you're in here?


Page: HOME should have a note for those already with EMUNAND and 9.2 SYSNAND

Specifically, that emunand can be substituted for the word rednand throughout the guide, and what step to begin at.
(Note: I had already done both my o3ds and n3ds with the very first guide that came out, using emunand)

Added to "Get Started"


Remove duplicate json keys

Remove duplicate json keys

thanks for pr. this issue has already solved by other.


Implement ADC API

It's currently possible to use the Pin API to enable an ADC channel via the switch matrix, but there is no API to actually use it without going through the low-level register mappings from the lpc82x crate.
I have some experimental ADC code in an internal repository that I plan to polish up and add to LPC82x HAL.  If you need this feature, please comment here. I'm happy to adjust the priority, if there's demand.

Implemented in #203.


feat: add support of required param in oauth config

Jira: https://jira.splunk.com/browse/ADDON-38644
Changes:

feat: add support of required param in OAuth config

The default value for required will be true to handle upgrade scenarios. For false, will need to be explicit in globalConfig.json.

:tada: This PR is included in version 1.8.0 :tada:
The release is available on:

v1.8.0
GitHub release

Your semantic-release bot :package::rocket:


Support ID3-less audio files

My gut tells me that the script crashes when an mp3 file with removed ID3 frames is used. We have to make sure it's supported.
We also have to make sure that settings empty metadata.txt removes ID3 headers and frames at all.

Partially addressed in #8


:card_file_box: Skill link to topic

resolve #300

Thanks guys for your reviews.
For the bg dark and light I've opnened a new issue . On the last commit, I've deleted the background. We didn't decided yet which color we have to use for this kind of component in light mode. It's no sense to have a background in dark mode but not in light
And so, I've opened this issue to merge PreferedTopics and SkillTopics component. tell me if you have suggestions or whatever


[Bug] While applying filter in a chart, there is a bug in it

How to reproduce the bug

Go to edit mode in 'Map of Vaccine Candidates' in COVID Vaccine Dashboard.
Add a filter with column as country_name and operator as In
Now try to add filter value with suggestions, and you can able to see the Bug which I have attached as video in this issue.

Expected results
When typing filter value and selecting with suggestion, filter value should be selected and the state of filter value should be set to empty string.
Actual results
When typing filter value and selecting with suggestion, filter value is selected and the state of filter value doesn't change.
![Before Changes]
Environment

browser type and version:
superset version: superset version
python version: python --version
node.js version: node -v
any feature flags active:

Checklist

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Hi @sivasathyaseeelan. Preserving your search input after a selection is an intentional behavior as many times people will search for prefixes and select multiple items. This behavior is only applicable to multiple selects.


typescript storybook support and general tidying up

Thanks, I've done that.
I'm about to commit "yarn add lodash" too.
BTW... each time I do a yarn add or remove I see these two warnings:
warning " ><EMAIL_ADDRESS>has unmet peer dependency "webpack@>=2".
warning "@storybook/addon-actions ><EMAIL_ADDRESS>has unmet peer dependency "regenerator-runtime@*".

However I cannot reproduce these warnings with "yarn check" which seems to do something else.
So it's difficult to diagnose.  Worth worrying about?  I guess I should try a fresh clone and "yarn install" and see if it goes away.


Updated commands to reflect esi-leap changes

Updated the client to work with recent esi-leap changes ot ensure
compatibility. Added flags for new filters on list requests esi-leap
now features. Updated start/end_date variables to start/end_time.

I updated the time-range flag to take in two strings. ESI-Leap parses the variables anyways and will throw an error if the types are not correct.

Works great! Two comments:

Make sure to address the comments I added previously
Can you pass-through the exceptions that esi-leap throws? I tried creating a contract that conflicted with existing contracts, and the CLI properly threw an error message. However, the CLI said "Could not create offers in esi-leap" while the esi-leap-api exception was the far more informative "Offer fa0b86b8-61ad-4f6a-a019-0ee95b761be6 is not available at given time range 2021-07-09 01:10:10, 2020-07-11 02:20:30". Exposing the latter to the end-user would be great.

Should hte exceptions be returned as a string or should it raise an error?

I think there's a standard error for OpenStack CLIs - something like: https://github.com/CCI-MOC/python-esiclient/blob/master/esiclient/v1/node_network.py#L117
I'd do something like the above, and just use whatever message is in the exception thrown from esi-leap-api.

I have addressed the faultstring issue

Looks good!


TypeError: init() got an unexpected keyword argument 'metadata'

Error reproduction setting

Server: running docker-compose up -d --build, expose to localhost:8000 using the current main (hash a563700)
Client: use chromadb==0.3.4

Error

Create a sample Collection using function from_documents(documents=chunks, embedding=embedding).
Run this script:

>>> import chromadb
>>> from chromadb.config import Settings
>>> client = chromadb.Client(Settings(chroma_api_impl="rest",
                                        chroma_server_host="localhost",
                                        chroma_server_http_port="8000"
                                    ))
>>> client.list_collections()

Output:
>>> client.list_collections()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/awesome_user_name/anaconda3/envs/awesome_env/lib/python3.9/site-packages/chromadb/api/fastapi.py", line 37, in list_collections
    collections.append(Collection(self, **json_collection))
TypeError: __init__() got an unexpected keyword argument 'metadata'

Proof that the error is new
Checkout hash 8184f7c and redo the aforementioned setting, the error did not show up.

Hi @dohuan - I believe there is a breaking change between the latest main returning metadata with the collection and this old version of chromadb. Could you upgrade your client to 0.3.11 and try that?

closing this but @dohuan please let us know if this fix from @HammadB does not solve your issue!

hi @HammadB and @jeffchuber , my apologies for late reply, error has been resolved. Thank you,

@dohuan glad to hear it!


Dont dismiss in onClick() of positive button

I have a form in my dialogue sheet, but I validated it with a click on the positive button, but it closes.
It would be a good feature to choose whether to close or not

I wanted this functionality too.  I have a PR up that would add this feature.

Functionality added in release 2.0.6 thanks to @owenlejeune.

how can avoid dismiss on click?

how can avoid dismiss on click?

You can set the shouldDismiss boolean to false when adding the button.

setPositiveButton(android.R.string.ok, false) {
    Toast.makeText(this@MainActivity, "Positive button clicked!", Toast.LENGTH_SHORT).show()
}


Library improvements to extend connection and session behaviour by client users

This is a series of changes that improve the ability to control connection and session behaviour by users of this library. It does this by adding a new 'kind' of session configuration object that knows its own connection pool type and a function in the session module to initialize a session with it.
The use case for this, in my case, is an internal connection pooling mechanism and internal-specific requirements on TLS parameters. These things are also connected to each other and need to work in concert, so it's not enough to simply implement a new LoadBalancer. Note that it is currently at least very difficult, if not impossible, to implement and use a custom connection type or even load balancer from outside the cdrs_tokio codebase due to several traits not being exposed as pub, so even without this I would probably still be submitting a smaller patch to expose some things.
Obviously that's a fairly specific need, but I also think this mechanism would be a good way forward for reshaping the existing session creation mechanisms since it doesn't require an independent config object per connection and can allow you to parameterize more information about the connection in a more convenient way than the plethora of connect_xxx methods that exist now, but I left that for the future as it would be a breaking change. Dynamic connection pool adjustments are also considerably simpler with this design, so it might be a path to getting those interfaces implemented without the experimental flag as well.
The following changes are also in this patch set but could probably be broken out into separate PRs if it's too much for this one:

Many complicated type constraints were removed across the code base in favour of using associated types to express type relationships.
An authenticator that can be configured at runtime to be either password or no authentication was added -- right now the type of authentication is encoded in type parameters all over the place so it makes it quite difficult to make this a config option in a using program.
Session connection pools can implement their own error types so long as they implement From<cdrs_tokio::Error> so they can convey connection-specific failures.
CDRSConnection trait methods that aren't used anywhere in the code-base are removed. They are also not really part of the public contract of the crate. At least one of them was doing something completely opposite of what it was documented to do. I would suggest that these methods should be re-designed if they are actually needed and there's no reason to keep the existing versions in.

I apologize for how sprawling these changes are. I have tried to make sure that the changes I'm submitting are connected to what I'm trying to achieve and also be beneficial. As mentioned above, if parts of this should be split off into separate PRs please let me know and I will do my best. I recommend looking at the changes on a commit-basis first if you can.
I also know that it kind of sucks to get a large PR with this much design work already done on it, but I hope I've justified my use-case well enough and I think it would probably be useful to others as well.

Thank you for this PR. Overall it looks good and I agree the API needs some work. The last major release addressed some of its issues, but looks like more work is needed. Please take a look at some comments in the PR.

Can you apply rustfmt? It's blocking CI.

Thanks!


Improves inline suggestions to work with screenreaders.

Fixes #129677.
@isidorn am I using the accessibility service correctly?
I'm not setting any aria label but adding visible text. What are your thoughts on this?
This is the outcome:

Code looks good -> approved.
Though I did not test this out.
As mentioned in the issue I think it would be better to take it safe and merge start of next week -> august.

Then lets merge start of next week.
I think copilot is still in preview, so I think next milestone is fine.


[SUPPORT] JettyServer Threadpool keeps running and ocp job hangs

Hi @codope  @nsivabalan
Describe the problem you faced
When i give wrong (non existent) recordKeys or pre-combine keys to the hudi spark job, the spark job fails with appropriate exception and spark context gets stopped. But there are other jettyserver threads running in the background which keeps running.
This in turn keep my OCP pod running , it never stops.
Points to Note.
I ran the job in overwrite mode on a path, where another table existed and also had a corresponding hive table. By going throug
h logs i can see, hudi trying to clean older data and overwriting  it successfully.
A clear and concise description of the problem.
To Reproduce
Steps to reproduce the behavior:

Create a simple input files.
Create a hudi spark job with some random columns (non-existent in input file)
Launch the spark job in a kubernetes cluster.

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description
Hudi version : 0.12.2
Spark version : 3.2.0
Hive version : 3.1.2_1
Hadoop version : Hadoop 3.2.1
Storage (HDFS/S3/GCS..) : HDFS
Running on Docker? (yes/no) : yes
Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

hudi-stacktrace.txt
threaddump.txt

Have attached stactrace, threaddump and hudi configurations for proofs

Hi, does this pr #8335   fix your problem?  You can also try to set hoodie.embed.timeline.server=false to disable timeline service and check whether you app are hang by the timeline server thread.

@stream2000 #8335 may solve the problem i believe. Also is setting hoodie.embed.timeline.server=false recommended in production env ?

No, embedded timeline server can cache the fs file handles thus can improve write performance.


System requirements (GPU?)

Hello,
This is great work @Boyiliee ! I'm excited to try this out.
I have a quick question: what kind of system requirements are necessary to train and run inference on this model? Specifically I am wondering about the type of GPU(s) needed to train LSeg.

Hi @DanielTakeshi, thanks for your interest in LSeg!
For training, we typically use V100, but I assume others would also work if the memory is allowed.
For inference, both GPU/CPU work. If you want to use CPU, for example, you can follow https://github.com/isl-org/lang-seg/blob/main/lseg_app.py#L314. And of course, you can modify based on your machine and requirements.
Hope this helps!
Best,
Boyi

Thanks! Right now I have some machines with GPUs that have 12 GB of RAM each available, I wonder if that might not be enough memory (assuming we use 1 GPU). However I guess I just have to try the code to see if it work and maybe reduce batch sizes if there are errors.

If you try the demo or inference test, I guess it should work!
But for training, we also provide different options for different model backbone implementation, for example,--backbone clip_vitb32_384, details in https://github.com/isl-org/lang-seg/blob/main/modules/models/lseg_net.py#L119. While I guess for 12GB, you might need to revise a little bit to reduce the model size for training ;)
Hope this helps! And please let me know if there are any other questions!


Remove unnecessary suppressions and fix a few warnings

Motivation and Context
Remove warning suppressions for warnings that aren't firing in the build, anyway.
Description
Also fix a few warnings that are showing up.
Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Looks like I broke it (with the Update branch button). Fixing... stay tuned.


🐛 No easy way to stop wunderctl up

Bug description
So while there is something like wunderctl up --debug that shows debug information. If you exit via ctrl+c the process remains active.
There is no wunderctl down so you can't make it stop unless you either memorized the PID or you look it up on which process is using port 9991 or 9992 and kill it manually.
How to reproduce

wunderctl up --debug

Expected behavior
Make wunderctl down
WunderGraph information
https://wundergraph.com/docs/guides/your_first_wundergraph_application/overview
Environment & setup

OS: Windows 10 10.0.19044
Node.js version: 16.13.1

WunderCtl Version
Version: 0.90.32
Commit: 386a3d4b66204411dc89da6919aad0bebe524657
Date: 2022-06-06T12:22:22Z
BuiltBy: ci

I think this is already fixed with #33. @StarpTech did we create a new release already?

But I think this won't solve the issue. wunderctl up doesn't call this place. https://github.com/wundergraph/wundergraph/pull/32 might fix it.

Hi @hinogi, could you give the latest release a shot?

2022-06-11T10:37:27+02:00       debug   listener closed {"addr": "<IP_ADDRESS>:9991"}
2022-06-11T10:37:27+02:00       debug   listener closed {"addr": "[::1]:9991"}

Seems to work now


Text rendering is flawed at a fixed height

Closing: cannot reproduce with new font.

Particularly flawed on the 4s in this screenshot.


bug: (@vtmn/svelte): VtmnListItem component tabindex yields the value false

Describe the bug
In the VtmnListItem component the anchor tag has a parameter tabindex which is validating with the value of disabled. If the disabled is true the tabindex is -1 but if the disabled is false the value of the tabindex is false instead 0. Please do the necessary changes
tabindex={disabled && -1}
Steps to reproduce
We can reproduce this in all decathlon search pages wherever the list is displayed
Expected behavior

Browsers affected

Version affected

Actually && doesn't work that way. You can use a ternary operator {disabled? 0:-1}, instead.


[query] New, readonly API

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Codecov Report

Merging #9403 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9403      +/-   ##
==========================================
- Coverage   59.02%   59.01%   -0.02%
==========================================
  Files         375      377       +2
  Lines       12136    12162      +26
  Branches     2993     3004      +11
==========================================
+ Hits         7163     7177      +14
- Misses       4794     4805      +11
- Partials      179      180       +1

Impacted Files
Coverage Δ

...c/dashboard/components/gridComponents/Markdown.jsx
89.01% <0.00%> (-2.77%)
:arrow_down:

superset-frontend/src/explore/controls.jsx
39.09% <0.00%> (-0.61%)
:arrow_down:

superset-frontend/src/chart/Chart.jsx
10.41% <0.00%> (ø)

superset-frontend/src/dashboard/App.jsx
0.00% <0.00%> (ø)

superset-frontend/src/dashboard/index.jsx
0.00% <0.00%> (ø)

superset-frontend/src/welcome/Welcome.jsx
78.57% <0.00%> (ø)

superset-frontend/src/profile/components/App.jsx
100.00% <0.00%> (ø)

...uperset-frontend/src/views/chartList/ChartList.tsx
66.05% <0.00%> (ø)

...perset-frontend/src/addSlice/AddSliceContainer.jsx
72.72% <0.00%> (ø)

...erset-frontend/src/profile/components/UserInfo.jsx
100.00% <0.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb5bad...f7706c4. Read the comment docs.


freifunk-policyrouting: do not add to ucitrack multiple times

Do not update ucitrack when the last list already has the correct option set. This prevents from adding the same items on every upgrade.
Signed-off-by: Sven Roederer<EMAIL_ADDRESS>

@SvenRoederer
I think you should remove the entry first and then add this entry again.
If the entry is present (old one) then replace this with a new one.
And additional in the end return with "exit 0".
This will delete the uci default file and will not get executed on next boot.
This is best practice.
See for example:
https://github.com/openwrt/luci/blob/44bf3f0c1640040561306caff39f34ac916b4357/applications/luci-app-olsr/root/etc/uci-defaults/40_luci-olsr

This should be reopened under the upcoming freifunk-repo (https://github.com/freifunk/openwrt-packages)

Please reopen this pullrequest in the new freifunk feed because package is already moved.
So I will close this there.


[New Feature]: Neutral/Better if newer version

Description of the new feature/enhancement
Currently we sometimes see Add version: when its actually a New version:
Proposed technical implementation details (optional)
Not sure if we're already sorting the current versions as neutral?

We are comparing against the Latest version. I know it will specifically fail in cases that don’t use a semver since the string comparison would say “50a2b4”is less than “f61ac3”, even though the 50a2b4 may be newer.
There are other examples, but basically it boils down to it being string comparison

Just found one that have this issue
2.8.8 is greater than 2.8.20

Yep; Again, string comparison. I’ll see if theres an easy way to implement semver checking

https://stackoverflow.com/questions/55335846/how-to-compare-version-numbers-in-powershell
[System.Version] resolved both of my issues

https://stackoverflow.com/questions/55335846/how-to-compare-version-numbers-in-powershell
[System.Version] resolved both of my issues
edit: adding -beta to the version obv broke it, so def not perfect with all the weird versions we got..

Yeah, definitely not a perfect solution. I’ll keep looking. Maybe I can try casting to a system.version and if that doesn’t work then fallback to string comparison.


Concepts pages: copyedits for instrumentation pages

Follow up to #3996
Copyedits in situations where the phrases didn't make sense grammatically
Includes other copyedits, such as reordering of solutions so zero-code is presented first.
Preview: https://deploy-preview-4066--opentelemetry.netlify.app/docs/concepts/instrumentation/

Given that @svrnm approved, and the order was restored, I'm going to merge now.


Move type descriptor to span context from span

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines         123    123
=====================================
  Hits          123    123

Impacted Files
Coverage Δ

src/opentracing-c/tracer.c
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f186ce8...396d5bc. Read the comment docs.


Does the obtained Lora overfit

I have also tried training portraits myself. When there are few images, it is very easy to overfit if you want to ensure the similarity of the characters. This is reflected in scenes with cues for actions like turning the face sideways or looking up, where the desired effect is not achieved. So, I would like to ask, when EasyPhoto implements few-shot Lora training, are there any particularly good techniques? Does the obtained Lora overfit (only showing the front face without the side profile)?

EN:
You mentioned some issues that we have made some attempts to address.
In EasyPhoto, Lora is just one means of ensuring similarity. There are also other methods like face fusion, material matching, and keypoint supervision. The final effect is a result of multiple factors; Lora may be important but not the sole determinant.
Our Lora does indeed require 4-10 images, covering a range of angles if possible. Naturally, this limits the angles that can be effectively generated, which is one issue we are looking to address in the future. However, the current results are already quite satisfactory.
There are quite a few Lora training techniques that you can refer to in our arXiv paper.
CN
翻译到英文
你提到的问题我们有过一些尝试，
1.EasyPhoto中Lora只是保证相似度的一个手段，还有其他例如人脸融合，素材匹配，关键点监督等手段，最终的效果是多重作用的，lora 可能很重要，但不完全决定性作用。
2. 我们的lora 确实需要4~10张图片，大致涵盖一些角度最好。当然对应在生成的时候能解决的角度也会少一些，这是未来会试图更好解决的问题之一，但当前的效果就还可以了
3.  有比较多的Lora训练技巧可以参考我们的arxiv。


[Confused] Why don't check _transformID & _textureID in calculateTrimmedVertices of Sprite?

at the begin of  calculateVertices  of Sprite.js , there is a checking :
    calculateVertices()
    {
        if (this._transformID === this.transform._worldID && this._textureID === this._texture._updateID)
        {
            return;
        }
       // something else
    }

but  in calculateTrimmedVertices of Sprite.js  , don't check _transformID & _textureID .
That's why ?
Is it a issue ?
.

@ivanpopelyshev  , should we check it ?


⚠ Secret Website 3 has degraded performance

In ea40a06, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2328 ms

Resolved: Secret Website 3 performance has improved in d62ef1f.


retain build files

Fix for #468

This change is

Codecov Report
Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (c7f1214) to head (e6a2277).

Files with missing lines
Patch %
Lines

...val.Machine.Shared/Services/PostprocessBuildJob.cs
33.33%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   56.59%   56.59%
=======================================
  Files         275      275
  Lines       14174    14179    +5
  Branches     1908     1909    +1
=======================================
+ Hits         8022     8025    +3
- Misses       5563     5564    +1
- Partials      589      590    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow provider configuration in LWRP

You can now use the attribute repo_provider for hosted, proxy and
group repositories. This will default to maven2 but you can use

rubygems-hosted
rubygems-group
rubygems-proxy
nuget-proxy
...etc

Fixes #97

@brugidou, I'm a :+1: on this addition. I think it might make sense to add these as constants to the library code and to document and validate the input.
Maybe something like Chef::Nexus::PROVIDER_HOSTED. What do you think?

Why not, but we should still let any string as input since any Nexus plugin could potentially add new providers so it's not as useful to have constants.


[Request] Flag to handle google wrapper types

It would possible to add a switch to handle in a different way google wrapper types, to map them to base types, like when using optional keyword?
It would be not compliant, but the use case is this: in c#, if a field is "optional int32" it becomes an "int" instead of "int?", while in TypeScript it is (correctly) "number | undefined".
The only way to have an "int?" on the c# side is to use google.protobuf.Int32Value, but on TypeScript side it is no more a base type.
So now you have to choose between
| c#   | TypeScript                 |
| int  | number?                    |
| int? | google.protobuf.Int32Value |
The request is to add a switch to handle wrapper types as if defined as "optional" with a base type, to have "int?" <--> "number?".

So the question is to generate google.protobuf.Int32Value field = 1 as field?: number?
Yes, we want to do that. I'm closing this as a duplicate of https://github.com/timostamm/protobuf-ts/issues/181, but thanks for bringing it up.
Unfortunately, we can't implement this yet. We need to switch our code generator to use @bufbuild/protoplugin under the hood first, so that we have more flexibility in the plugin. There hasn't been much activity on that work lately, but it's still the best way forward.


⚠ ClamAV has degraded performance

In 449eee2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 228 ms

Resolved: ClamAV performance has improved in b8dca24 after 17 minutes.


raspberry pi 4 issues with update firmware to 24.7.6 and 24.7.7

Hi
I am running opnsense with raspberry pi 4 from version 24.7.4 and having issues when upgrading firmware to 24.7.6 and to the latest version 24.7.7 because i cannot seems to access to my email via gmail and after upgrading the firmwaere from 24.7.6 to the latest version 24.7.7 the kernel cannot seems to boot. I have to edit the /boot/defaults/loader.conf files and use the kernel.old instead of kernel.

24.7.7 is a minor update and doesn't include a new kernel, so it seems unlikely that updating from 24.7.6 is the cause for a boot failure.
Not sure how Gmail issues are supposed to be related to OPNsense.
Please also keep in mind that this is a virtual machine image repository. I don't provide support for bare metal installations here.

I have to redo the whole thing again from scratch back to square one and do a opnsense-revert -r 24.7.5 opnsense in order to get the gmail to be able to login. And I have tried many times that after upgrade to the latest firmware version to 24.7.6 and to 24.7.7 having my gmail unable to login at all and keep prompting for google code to be send. But once i redo and revert back to the old version every thing is back to normal and i able to access my gmail email account.

Completely unrelated to this fork of opnsense/tools, which is explicitly about building OPNsense VM images only. Please stop spamming random repos with unspecific issues.


[Improvement] User experience of the GraphQL client generation tool

Description:

Different solutions were discussed to improve the user experience of the GraphQL client generation tool as summarized here.
Based on the research and discussions held with higher level managers it was,

[x] Agreed to add a new template tag graphql-client for the new Ballerina project creation command to generate prototypes necessary for the GraphQL client generation tool.

    bal new <package_name> -t graphql-client

[x] Agreed to provide the 3rd party GraphQL Foundation VS Code plugin as an extension recommendation in the .vscode file of the project. Users will be recommended with a pop up to install the GraphQL plugin as a prerequisite for GraphQL query validation and execution in VS Code.
[x] Suggested to provide the configurable options for GraphQL client generation tool as comments in the generated prototypes, so that the user can enable them based on their usage. Suggested to add proper references.
[ ] Suggested to implement a compile time validator as a future improvement to validate the changes in the GraphQL queries and the generated client code.
[ ] Discussed about the necessity to improve the Ballerina project creation command with additional template tags to support configuration of GraphQL API URL etc. The support for these options will be considered during future improvements of the command.

Related Tasks:

[x] https://github.com/ballerina-platform/graphql-tools/issues/46
[x] https://github.com/ballerina-platform/graphql-tools/issues/48
[x] https://github.com/ballerina-platform/ballerina-lang/issues/35889
[ ] https://github.com/ballerina-platform/graphql-tools/issues/69

The compile plugin for the validating the generated clients using GraphQL client tool is de-prioritized. This will be addressed in the future.


ical import failure

command: gcalcli import file.ics --calendar<EMAIL_ADDRESS>Traceback (most recent call last):
File "/usr/local/bin/gcalcli", line 2647, in
BowChickaWowWow()
File "/usr/local/bin/gcalcli", line 2634, in BowChickaWowWow
gcal.ImportICS(FLAGS.verbose, FLAGS.dump, FLAGS.reminder, args[1])
File "/usr/local/bin/gcalcli", line 2118, in ImportICS
body=event))
File "/usr/local/bin/gcalcli", line 654, in _RetryWithBackoff
return method.execute()
File "/usr/local/lib/python2.7/dist-packages/oauth2client/util.py", line 137, in positional_wrapper
return wrapped(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/googleapiclient/http.py", line 840, in execute
raise HttpError(resp, content, uri=self.uri)

Can you paste the full output of the failure?  The actually error message isn't shown here.  Additionally an ics that fails would be helpful.

Full output was as shown. The ics file cannot be posted; privacy.

Unfortunately I'm not going to be able to do anything with this then.  I can't reproduce it and there's not enough information to reproduce.

I'm closing this since we can't repro.
@githubgnulinux your privacy concerns are certainly valid.  If there's some way that you can redact the private information in the file and still reproduce the bug then we'd like to reopen this.


How to scale images in a controller

Found no documentation about that. Could you add it?
Best regards
Stephan

You can get ahold of Imagine service by calling $container->get('imagine'); once you have it, http://imagine.readthedocs.org/en/latest/index.html will help you with how to use it

thanks very much!

Since I just implemented this last night in JmikolaImagineBundle, I'd something like suggest:
$box = $image->getSize();
$resizedImage = $image->resize($box->scale(1.5));

That would scale an image by its own dimensions (probably what you want).

may I reiterate:
<?php
$image->resize($image->getSize()->scale(1.5));

@avalanche123: I guess you don't care about Law of Demeter anymore :)

@jmikola, do care :) here we're dealing with size immutable value object (immutable and value object pretty much assumes each other). I feel that law of demeter makes a lot of sense when each method call is returning another object. so you we had A::b() -> B and B::c() -> C then
<?php
$a = new A();
$a->b()->c(); // would be terrible as you'd have to mock the whole chain in tests

while in our case we'd do something like:
<?php
$size = new Box(100, 100);

// stub out initial size
$image->expect($this->once())
    ->method('getSize')
    ->will($this->returnValue($size))
;

$image->expect($this->once())
    ->method('resize')
    ->with(new Box(150, 150))
;

// our filter that executes my above code
$filter->apply($image);

As you can see, mocking value objects is unnecessary as they are easy to construct and have on dependencies on other objects (easy to construct and have no dependencies is pretty much the same thing).
Another example would PHP's DateTime class, while it is mutable and sucks from design POV, it is globally accessible and easy to construct.
To conclude, don't violate the LOD for service objects, while don't bother with it in cases where object operates on its internal state.
Cheers! :)

just realized, that the example is talking about and applicable to 'newables' in general and not only value objects


The Summary field is mandatory, not optional

Hi, Team.
In the Card fields section, the summary field seems to be optional, but it actually is the required field. Whenever I send a message to a Microsoft Teams channel through the "Incoming Webhook" connector, without the summary field value, it always returns 400 Bad Request error.
The schema definition may have declared that the field as optional. However, the incoming webhook connector implementation requires the value MUST be provided.
Can we mention this in this document or somewhere else?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2fa51748-908b-c781-39b2-09c961b1637a
Version Independent ID: 51b88c0a-29d3-2ca8-0b54-d96be4779dd2
Content: Legacy actionable message card reference - Outlook Developer
Content Source: docs/actionable-messages/message-card-reference.md
Product: outlook
Technology: o365-connectors
GitHub Login: @jasonjoh
Microsoft Alias: jasonjoh

@jasonjoh Yes, it gets 400 error when I send a message with Title, but no Summary.
Here's the sample test result: https://github.com/aliencube/microsoft-teams-actions/runs/442202988

Ok. Let me check internally on this. I know the Teams docs point over to our docs, but there may need to be some Teams-specific disclaimer somewhere to explain where they diverge, either in their docs or here.

@justinyoo
This simply payload without summary works (from the Teams docs):
{"text":"Hello World!"}

So summary isn't required. I believe it is required if you omit text. This matches what the 400 response has in the body. For example, if I POST:
{"title":"Hello World!"}

I get back a 400, with this text in the body:
Summary or Text is required.

This is the same behavior with Groups and mailbox connectors. I'll update the doc to reflect this.


Vimeo: 'qualities' is not a function

When building with the latest v1.7.0 version, there's an error shows in the vidstack-video-TX2o91bs.js file if I try any vimeo URL.

I looked at the original source file, and the part it's referring to is the qualities[...]

Unable to recreate on the stackblitz. But I started from scratch a couple of times and made sure I had the latest node modules, so I don't think it's something I'm doing wrong. But strange how I can't replicate on there, it works fine.
(maybe just due to  the modification of the code, i notice this doesn't happen on the stackblitz version of the files)

How are you building and serving it? If you can provide a repro or some instructions that'd help me find out what's up.

Turns out I that when I was running the 'npm run build', this time round (unlike when doing it with previous versions) the JS files being split out included a prod...js file that needed to be included in the HTML, not the index...js. file.
Not sure why this is, or if it's because of something I did wrong, but anyway including the correct file was all that was needed to fix.
I'll keep this issue open as @qlaffont seems to have run into something vimeo related, will close if another issue is created for that.

Seems like StackBlitz is blocking due to CORS, not actual issue with the provider but I'll look into it.


RequirementMachine: Odds and ends in service of protocol requirement signature minimization

@swift-ci Please smoke test


refactor: change list to itertools.cycle

itertools.cycle gives you an option not to calculate the index
(pull request to #315)

че умный да?


Optional application name parameter for connection string

This PR fixes #18165.
STS PR: microsoft/sqltoolsservice#1380
mssql-vscode PR: https://github.com/microsoft/sqltoolsservice/pull/1380
The goal is to make the application name in the connection string be optional to include.
Only when is it set to false will it not be set. In this case we do not need to show it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.282%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/sql-database-projects/src/dialogs/addSqlBindingQuickpick.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14766

Relevant Lines:
29039

💛  - Coveralls

Updating to latest STS to 1.95 from 1.93.
Commits from STS -

cc @Charles-Gagnon, @smartguest, @alanrenmsft


cloud armor rules spuriously reject requests

like #138 but we can actually see sqli rules being triggered
Seeing as we don't have a sql database, maybe we can just disable *-sqli armor rules.
cc @ameukam
found while debugging #138 and other reports.
technically this is configured in https://github.com/kubernetes/k8s.io, but filing here for visibility

owasp-crs-v030301-id942421-sqli in the most recent instance, from the logs. (I can vouch that this was a perfectly normal request triggering it ...)

https://cloud.google.com/armor/docs/waf-rules

https://console.cloud.google.com/logs/query;query=jsonPayload.statusDetails%3D"denied_by_security_policy";timeRange=PT1H;summaryFields=jsonPayload%252FenforcedSecurityPolicy%252FpreconfiguredExprIds:false:32:beginning;cursorTimestamp=2023-02-09T01:13:26.777727Z?project=k8s-infra-oci-proxy-prod&mods=logs_tg_staging

These two seem problematic:
owasp-crs-v030001-id942420-sqli
owasp-crs-v030001-id942421-sqli
https://stackoverflow.com/questions/60199025/is-there-any-way-for-the-ip-once-denied-by-a-waf-rule-to-be-unbarred-again-passi

@ameukam filed https://github.com/kubernetes/k8s.io/pull/4757 to update the armor policy including dropping all the SQLI rules (which don't make sense in our case anyhow), closing this for now, but something to keep an eye out for in the future.


Load PDFs

Load PDFs in the UI and transform them to LLM input. This will enable answering questions / summarizing / paraphrasing / writing code / etc.
UX options:

Existing button to load file will parse the PDF (right now text files are inserted as raw text in a ``` section)
When pasting a PDF URL in the Composer, it should download the PDF, parse, and queue ir up as an attachment to the message
If the size of the PDF exceeds the available context window, there should detail removed (references, appendix, and summarization) before attaching the file

There seem to be many TS/JS libraries, including:

https://www.npmjs.com/package/pdf2json
https://www.npmjs.com/package/pdfreader
more

Please vote / contribute ideas!

Merged in 421e06e617b5f530154c02d8dc0d4af6f2a63a24, by @fredliubojin.
Cleaned up in 23a3185696df0581d396a3621ab1aef560cd321.
Needs some more polish, maybe a text cutter, and I can close this.


Descriptor files

This is the new version of the PR for the creation of descriptor files.

@JuliaSprenger new PR ! i think i did a mistake with the version so i have change it ...

Comment: the goal of this PR is to create a new descriptor file so that it can be integrated in the V4A pipeline in the future... The BIDS-ification of the V4A pipeline will then follow...

The goal is to be compatible with:odmltables


Flat menu needs to adopt background color in tablet/desktop view

Dark text/icon = OK

Light icon = not visible

If you have a dark color flat menu for mobile, and make text/icons light color, then on the tablet/desktop flat menu the text/icon isn't very visible.
This will also provide a visual distinction between the flat menu and the sections when viewing tablet/desktop.

What is the concrete proposal for a solution here? Should we make the flat menu buttons in desktop match the color scheme from mobile? This would make a lot of things easier, such has setting custom colors (see #603).
In issue #484 the solution we suggest is to automatically recolor the icons so they are black in desktop and white in mobile (unless the color is manually overwritten). This would likely mean though that to customize the colors, we'd want to have a separate color setting for desktop and mobile.


Wrong Training Link in Deploy page

The Training Link on this page is not pointing to a relevant item.  It is point at an article for Azure "Application" gateway, which is not accurate.
Pasted a screenshot.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d1b6ad84-0340-8569-d927-5482c3469993
Version Independent ID: 4ed80232-5387-e555-3fdb-e9638f71bcc6
Content: Deploy Azure Communications Gateway
Content Source: articles/communications-gateway/deploy.md
Service: communications-gateway
GitHub Login: @rcdun
Microsoft Alias: rdunstan

@chrishodgkins
Thanks for your feedback! We will investigate and update as appropriate.

Hi @chrishodgkins,
Thanks for your feedback! These links are automatic recommendations from the learn.microsoft.com platform. I'm investigating whether the recommendations can be improved, but there's nothing I can do immediately to remove the incorrect recommendation.
Thanks,
Rachel

Hi @chrishodgkins. I've raised the issue with the team who manage the automated recommendations. They've investigated: they don't have an immediate fix, but have added it to their backlog.
I'm going to close this now as there's nothing more I can do here for the moment.
Thanks,
Rachel

#please-close


Migrate to DNA 4

Synapse is now a client-side only router.

Removed node server support
Migrate to DNA 4

Codecov Report
Attention: Patch coverage is 16.66667% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 59.21%. Comparing base (281c0d8) to head (0051b31).

Files
Patch %
Lines

src/Components/Transition.tsx
0.00%
9 Missing and 4 partials :warning:

src/Helpers/App.ts
0.00%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #38       +/-   ##
===========================================
- Coverage   73.47%   59.21%   -14.27%
===========================================
  Files          22       18        -4
  Lines        2843      716     -2127
  Branches      326      182      -144
===========================================
- Hits         2089      424     -1665
+ Misses        535      198      -337
+ Partials      219       94      -125

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cloud for Sustainability schema documents

Initial schema docs for Cloud for Sustainability.

Closing, per discussion the schema will be processed in the internal repo before pushing to GitHub.


Hey i got an error with the distube module

/home/container/node_modules/distube/dist/index.js:2712
throw new DisTubeError("INVALID_KEY", sourceName, invalidKey);
^
DisTubeError [INVALID_KEY]: 'youtubeIdentityToken' does not need to be provided in DisTubeOptions
at checkInvalidKey (/home/container/node_modules/distube/dist/index.js:2712:11)
at new Options (/home/container/node_modules/distube/dist/index.js:1587:5)
at new DisTube (/home/container/node_modules/distube/dist/index.js:2790:20)
at Object. (/home/container/source/main.js:158:16)
at Module._compile (node:internal/modules/cjs/loader:1275:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1329:10)
at Module.load (node:internal/modules/cjs/loader:1133:32)
at Module._load (node:internal/modules/cjs/loader:972:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
at node:internal/main/run_main_module:23:47 {
errorCode: 'INVALID_KEY'

I solved this problem a few days ago.  But I haven't updated the code yet 😅
This issue is caused by a music player package that recently removed the youtubeIdentityToken option and I forgot to remove it in the main build.
The solution to this problem is to remove this line of code without any problems.
https://github.com/Maseshi/Shioru/blob/main/source/main.js#L193-L193
Thank you for reporting such errors.

I solved this problem a few days ago. But I haven't updated the code yet 😅 This issue is caused by a music player package that recently removed the youtubeIdentityToken option and I forgot to remove it in the main build.
The solution to this problem is to remove this line of code without any problems.:
https://github.com/Maseshi/Shioru/blob/c88471923caac3aaeedc45a849a6d70238ec3f20/source/main.js#L193
Thank you for reporting the problem.

It worked, thank you 🤎


Column ordering in Table pages

Table pages:

[x] Waiting room
[x] Approval room
[x] Recent Visits

I don't know how to create sorting on custom rendered column Cell: https://www.material-react-table.com/docs/guides/data-columns#custom-cell-render

Sorting on other columns done in commits:

2b9c46e53c8464cbcefc2e9b8e8ba1631c1686e3
5cf97d929a167383c525591295f9ab604d2d2380

There is an answer to why we cannot create sorting on custom rendered column Cell:

Cell is only used to modify the appearance and cannot be sorted by it, the data model is determined by the accessor and can be sorted on it. Define accessorKey or id together with accessorFn and then use sortingFn.


Problem with RPC

Hi,
First of all, thank you for this Discord client.
My problem:
I have been trying for days to get RPC running, but it doesn't seem to work.
I tried building it from source, but I encountered this error (I've never touched JS before):
npm WARN deprecated<EMAIL_ADDRESS>This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm WARN deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm WARN deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please use @electron/asar moving forward.  There is no API change, just a package name change
npm WARN deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm ERR! code 1
npm ERR! path /home/fabian/repos/rpc/DiscordBSD/node_modules/electron
npm ERR! command failed
npm ERR! command sh -c node install.js
npm ERR! HTTPError: Response code 404 (Not Found)
npm ERR!     at Request._onResponseBase (/home/fabian/repos/rpc/DiscordBSD/node_modules/got/dist/source/core/index.js:913:31)
npm ERR!     at Request._onResponse (/home/fabian/repos/rpc/DiscordBSD/node_modules/got/dist/source/core/index.js:948:24)
npm ERR!     at ClientRequest.<anonymous> (/home/fabian/repos/rpc/DiscordBSD/node_modules/got/dist/source/core/index.js:962:23)
npm ERR!     at Object.onceWrapper (node:events:632:26)
npm ERR!     at ClientRequest.emit (node:events:529:35)
npm ERR!     at origin.emit (/home/fabian/repos/rpc/DiscordBSD/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
npm ERR!     at HTTPParser.parserOnIncomingClient (node:_http_client:700:27)
npm ERR!     at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
npm ERR!     at TLSSocket.socketOnData (node:_http_client:541:22)
npm ERR!     at TLSSocket.emit (node:events:517:28)

npm ERR! A complete log of this run can be found in: /home/fabian/.npm/_logs/2024-06-20T16_55_17_878Z-debug-0.log

uname -r:
14.1-RELEASE
Then I downloaded the binary (0.0.54), and it worked, but RPC did not.
It would be really cool if you could help me out.
Best regards,
Fab1anDev

I have tried compiling and running and I have had no problems, I am going to see what happens from a virtual machine from 0

I have tried compiling and running and I have had no problems, I am going to see what happens from a virtual machine from 0

Thanks for the reply.
Yeah that would be nice.
It looks like a connect is established and started correctly. Here are the Logs from Discord:
[arRPC] arRPC v3.1.0
(node:1643) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
[arRPC > bridge] listening on 1337
[arRPC > ipc] listening at /var/run/xdg/fabian/discord-ipc-0
[arRPC > websocket] listening on 6463
amdgpu: os_same_file_description couldn't determine if two DRM fds reference the same file description.
If they do, bad things may happen!
[1644:0623/232759.295780:ERROR:interface_endpoint_client.cc(702)] Message 6 rejected by interface blink.mojom.WidgetHost
[1644:0623/232759.295806:ERROR:interface_endpoint_client.cc(702)] Message 7 rejected by interface blink.mojom.WidgetHost
(node:1644) UnhandledPromiseRejectionWarning: Error: An object could not be cloned.
    at t.ipcRendererInternal.send (node:electron/js2c/renderer_init:2:10956)
    at EventEmitter.<anonymous> (node:electron/js2c/renderer_init:2:10428)
(Use `DiscordBSD --trace-warnings ...` to show where the warning was created)
(node:1644) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
[arRPC > bridge] web connected

It seems that the problem is in the operation of the ARRPC bookstore that is responsible for making that part work. Very possibly there was a change in some commitment

i really dont have experience with JS but i tried just for fun to run Discord without RPC and i think the Discord client is the problem itself:
.local/bin/discord
node:internal/modules/cjs/loader:1148
  throw err;
  ^

Error: Cannot find module '/home/fabian/.local/share/discordbsd/RPC/src'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
    at Module._load (node:internal/modules/cjs/loader:986:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
    at node:internal/main/run_main_module:28:49 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v20.14.0
(node:21372) UnhandledPromiseRejectionWarning: Error: An object could not be cloned.
    at IpcRendererInternal.send (node:electron/js2c/renderer_init:2:11234)
    at IpcRendererInternal.<anonymous> (node:electron/js2c/renderer_init:2:10729)
(Use `DiscordBSD --trace-warnings ...` to show where the warning was created)
(node:21372) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

Which RPC Plugin do you use for NeoVim? it also possible the RPC Plugin is broken. i mean the arRPC is running

The problem is not the plugin, since I tried running arrpc by hand and running it from discord web and it also failed there
Very possibly discord has made some change that causes arrpc to fail

fixed in https://github.com/SrWither/DiscordBSD/releases/tag/0.0.78

Alright. ill try that out. Thanks!


Repaired issue where Thrashbar component was throwing error

Description
After running git pull origin main the following error was thrown:
unexpected token ;
that prevent from running npm start to load applicaton.
Summary of Solution

Realized the error was on line 6. Repaired to class instead of className

Commits Checklist

[x] commits have clear title names
[x] commit has descriptive message of what has changed
[x] more small commits than less big commits

Code Checklist

[x] code is formatted appropriately
[x] code meets DRY standards
[x] no dead code (check for logs and print statements)
[x] no TODOS instead necessary comments
[x] code follows Scribble Stadium standards for:

Language
Framework
Libraries

PRs needs to be reviewed by at least 2 team members

TPL is the 3rd reviewer
Lots of comments and suggestions, please!

Pull Request Rubric

 Thrashbar Component throwing error.

nice catch!


For consistency, replace all use of project_id w/ project.

Also, rename regression_utils.get_environ -> check_environ, and drop return value (which only caller was ignoring).

LGTM. How did you come across this?

I was trying to find out how / where we were using / setting project, and accidentally typed git grep project_id=, finding many fewer locations than I expected.

Coverage remained the same at 100.0% when pulling bede80fa8079baed2585a088729c7bf925a39681 on tseaver:squelch-project_id into d21bc3fecbeb87165158d39c77fc2a1232166c21 on GoogleCloudPlatform:master.


node: command not found

It does not recognize the Node installed on the mac by Brew, and only the extension does not recognize it. At times it works and suddenly stops working.
To reproduce
Steps to reproduce the behavior:

Install Extension and Active
Show Debug Console
See error

Screenshots

Environment

Nova version: 10.2
Extension version: 2.5.0
TypeScript version: 4.9.3
Sidebar information: Stopeed
macOS version: 13.0.1
NodeJS information:

node version: v19.1.0
npm version: 8.19.3
installation method: homebrew

Extension console output
TypeScript[8:35:12.877000] dependencyManagement: installing:
TypeScript[8:35:12.877000] dependencyManagement: installing: up to date in 127ms
TypeScript[8:35:12.878000] dependencyManagement: installing:
TypeScript[8:35:12.878000] dependencyManagement: installing: 12 packages are looking for funding
TypeScript[8:35:12.878000] dependencyManagement: installing:   run npm fund for details
TypeScript[8:35:12.885000] dependencyManagement: clearing lock
TypeScript[8:35:12.887000] using tslib at: /.../node_modules/typescript/lib
TypeScript[8:35:12.921000] activated
TypeScript Language Server[8:35:13.715000] /.../Library/Application Support/Nova/Extensions/apexskier.typescript/run.sh: line 12: node: command not found
TypeScript Language Server[8:35:13.724000] TypeScript Language Server connection closed unexpectedly: Task exited with a non-zero exit status: 127.

This is generally due to a misconfigured login shell. If you've recently changed, ensure you do a system macos restart.

No way, I installed Node by Brew, and gave this error, the clean installation of Node.
Simply the way it is running node, does not recognize the path of the command, I was able to solve it by modifying the run.sh file, to use the absolute path of the node installation.
/opt/homebrew/bin/node \
                "$INSTALL_DIR/node_modules/typescript-language-server/lib/cli.js" \
                --stdio \
                --tsserver-path="$TSLIB_PATH/tsserver.js"

You could have an option to set the Node path, in cases where the plugin cannot use the command.

I'm not planning to add an option to set the node path, as this explicitly indicates something wrong with your setup, if Nova can't find the node executable.
If you go to "Preferences" > "Tools", ensure your environment variables contain the same $PATH you see when you use a normal terminal. This $PATH is what Nova sends to the run.sh script, and is what's used to resolve the node executable.

Even making this PATH definition, it did not solve it, it continues to inform that the node command not found.

For anyone who runs across this again, for me the issue was that Nova was not picking up the $PATH correctly from the environment. Nova only looks .zprofile or .zlogin, but not .zshrc (as per https://help.panic.com/nova/environment-variables/). I had everything in .zshrc which manifested as this error.


1544 | Make The String Great | C++

Title - 1544. Make The String Great
What will change - Add solution for the problem 1544. Make The String Great in C++
Type of Issue -

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Can I be assigned this issue, please?


Deployment script: check that all addresses are checksummed before doing anything

The deployment script should check that all addresses in the config file are checksummed before doing anything, in order to prevent partial deployments due to a trivial error.

this is already done isn't it?

done. closing.


Build payments model classes and basic structure

Codecov Report

Merging #190 (4df65b4) into branch-payments (939d0b1) will decrease coverage by 2.44%.
The diff coverage is 5.46%.

@@                  Coverage Diff                  @@
##             branch-payments     #190      +/-   ##
=====================================================
- Coverage              55.36%   52.92%   -2.45%
  Complexity               581      581
=====================================================
  Files                    117      122       +5
  Lines                   2489     2617     +128
  Branches                 315      334      +19
=====================================================
+ Hits                    1378     1385       +7
- Misses                  1050     1171     +121
  Partials                  61       61

Impacted Files
Coverage Δ

...u/awe/logic/commands/CalculatePaymentsCommand.java
0.00% <0.00%> (ø)

...e/logic/parser/CalculatePaymentsCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/awe/model/payment/Payment.java
0.00% <0.00%> (ø)

...l/payment/exceptions/PaymentNotFoundException.java
0.00% <0.00%> (ø)

src/main/java/seedu/awe/model/person/Name.java
78.57% <0.00%> (-6.05%)
:arrow_down:

...main/java/seedu/awe/model/payment/PaymentList.java
12.76% <12.76%> (ø)

src/main/java/seedu/awe/model/AddressBook.java
66.66% <50.00%> (-0.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939d0b1...4df65b4. Read the comment docs.