ConnectionResetError missing in retry

Here's a callstack we just got and it wasn't retried:
File "/pyenv/lib/python3.6/site-packages/googleapiclient/http.py", line 841, in execute
    method=str(self.method), body=self.body, headers=self.headers)
File "/pyenv/lib/python3.6/site-packages/googleapiclient/http.py", line 165, in _retry_request
    resp, content = http.request(uri, method, *args, **kwargs)
File "/pyenv/lib/python3.6/site-packages/oauth2client/transport.py", line 175, in new_request
    redirections, connection_type)
File "/pyenv/lib/python3.6/site-packages/oauth2client/transport.py", line 282, in request
    connection_type=connection_type)
File "/pyenv/lib/python3.6/site-packages/httplib2/__init__.py", line 1514, in request
    (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
File "/pyenv/lib/python3.6/site-packages/httplib2/__init__.py", line 1264, in _request
    (response, content) = self._conn_request(conn, request_uri, method, body, headers)
File "/pyenv/lib/python3.6/site-packages/httplib2/__init__.py", line 1217, in _conn_request
    response = conn.getresponse()
File "/pyenv/lib/python3.6/site-packages/aws_xray_sdk/core/recorder.py", line 374, in record_subsegment
    return_value = wrapped(*args, **kwargs)
File "/usr/local/lib/python3.6/http/client.py", line 1331, in getresponse
    response.begin()
File "/usr/local/lib/python3.6/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
File "/usr/local/lib/python3.6/http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/local/lib/python3.6/socket.py", line 586, in readinto
    return self._sock.recv_into(b)
File "/usr/local/lib/python3.6/ssl.py", line 1009, in recv_into
    return self.read(nbytes, buffer)
File "/usr/local/lib/python3.6/ssl.py", line 871, in read
    return self._sslobj.read(len, buffer)
File "/usr/local/lib/python3.6/ssl.py", line 631, in read
    v = self._sslobj.read(len, buffer)
ConnectionResetError: [Errno 104] Connection reset by peer

looks like a python3 support issue, this case is covered in py2 by socket.error.  In my implementation I've centralized this logic here: https://github.com/thehesiod/google-api-python-client/blob/thehesiod/batch-retries/googleapiclient/http.py#L143

probably should bring this into line with what the cloudsdk does: http://testcompany.info/google-cloud-sdk/lib/third_party/apitools/base/py/http_wrapper.py  at the same time handle: https://github.com/google/google-api-python-client/issues/563

Is there any traction on this ?
ConnectionResetError has become very common for those using the api in Google Cloud Functions.
We raised this with Google Support and their answer was to implement a exponential backup.
As per @thehesiod , adding the error as retriable would be an easy fix.

+1, same issue here, often happens on Cloud Functions.

I'm having the same issue when using the google-cloud-bigquery client running within a cloud function in us-east1.
@thehesiod It looks like you implemented a fix for this in your private fork. There are also some unrelated changes in that branch. Do you plan to extract the fix for this issue and open a separate pull request here? That should make it easier for someone to review it and getting it merged. Otherwise let me know, I might open a PR.

@eckardt <rant> the google APIs are IMHO a mess ;)  Here they switched to google-auth, however that doesn't support token storage so depending on your impl you may do a lot of auth calls.  Also beware of batched API calls as they didn't add retries to that (nor cared for my fixes as technically this is just in "support" mode). Also there are some weird auth errors (saying you're unauth'd when you are, fixed with retry, they didn't want my fix for either.  In the new cloud functions they switched to requests (https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3674) as you've noticed, but there were a lot of fundamental bugs (https://github.com/GoogleCloudPlatform/google-cloud-python/issues/4274, perhaps like you're finding) so I'm still wary of using the new version.  For now we're on 0.26.0 of google-cloud-pubsub and related sub-modules.  With my branch I'm able to run for ~10 days before a SSL leak in core python executale causes us to restart. </rant>

Hey @thehesiod, we hear your frustration and we're working hard to improve all of these libraries, but please keep comment this issue tracker on topic and respectful.

Also beware of batched API calls as they didn't add retries to that (nor cared for my fixes as technically this is just in "support" mode)

Just want to add some context here- it's risky for us to do this as we don't want to introduce bugs for other users, and our APIs are largely moving away from API-level batching towards protocol-level batching (gRPC). We could definitely consider something like this for a 2.0, if that happens (as we're considering switching this library over to Requests as part of a major version change).

In the new cloud functions they switched to requests (googleapis/google-cloud-python#3674) as you've noticed, but there were a lot of fundamental bugs (googleapis/google-cloud-python#4274, perhaps like you're finding)

The bugs in Pub/Sub are entirely unrelated to Requests and were due to the fact that the Pub/Sub library was under heavy active development. We are close to our 1.0.0 milestone on that, so I encourage you to try it again and give us feedback.

fyi another issue I've found is that discovery is not retried on socket.timeout. We're seeing this call periodically fail. The reliance on http2lib means that anytime socket.timeout/socket.gaierror/unhandled socket.error means the client (google-api-python-client) needs to implement the retry.  Eventually I'll add fixes for these in the batch-retries branch and our httplib2 branch (will update this msg when ready).

Also getting a ton of this error... going to assume the easiest way is to exponential back off on both ConnectionResetError and errors.HttpError (had some issue with this one too) ?

Hi everyone, do we have any update on this? We are currently using airflow which uses google-api-python-client library to check status of dataproc job. Since this code is from airflow, we cannot implement exponential backoff.

Hi everyone, do we have any update on this? We are currently using airflow which uses google-api-python-client library to check status of dataproc job. Since this code is from airflow, we cannot implement exponential backoff.
This issue is a recurring issue and happens intermittently.

can you link the code since it's in the airflow repo?

This is the line where while querying the dataproc job status, it fails: https://github.com/apache/airflow/blob/1.10.4/airflow/contrib/hooks/gcp_dataproc_hook.py#L123
Whole stacktrace:
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/airflow/models/taskinstance.py", line 921, in _run_raw_task
    result = task_copy.execute(context=context)
  File "/usr/local/lib/python3.7/site-packages/airflow/contrib/operators/dataproc_operator.py", line 1139, in execute
    super(DataProcPySparkOperator, self).execute(context)
  File "/usr/local/lib/python3.7/site-packages/airflow/contrib/operators/dataproc_operator.py", line 707, in execute
    self.hook.submit(self.hook.project_id, self.job, self.region, self.job_error_states)
  File "/usr/local/lib/python3.7/site-packages/airflow/contrib/hooks/gcp_dataproc_hook.py", line 312, in submit
    if not submitted.wait_for_done():
  File "/usr/local/lib/python3.7/site-packages/airflow/contrib/hooks/gcp_dataproc_hook.py", line 124, in wait_for_done
    jobId=self.job_id).execute(num_retries=self.num_retries)
  File "/usr/local/lib/python3.7/site-packages/googleapiclient/_helpers.py", line 130, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 851, in execute
    method=str(self.method), body=self.body, headers=self.headers)
  File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 165, in _retry_request
    resp, content = http.request(uri, method, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/google_auth_httplib2.py", line 187, in request
    self._request, method, uri, request_headers)
  File "/usr/local/lib/python3.7/site-packages/google/auth/credentials.py", line 122, in before_request
    self.refresh(request)
  File "/usr/local/lib/python3.7/site-packages/google/oauth2/service_account.py", line 322, in refresh
    request, self._token_uri, assertion)
  File "/usr/local/lib/python3.7/site-packages/google/oauth2/_client.py", line 145, in jwt_grant
    response_data = _token_endpoint_request(request, token_uri, body)
  File "/usr/local/lib/python3.7/site-packages/google/oauth2/_client.py", line 106, in _token_endpoint_request
    method='POST', url=token_uri, headers=headers, body=body)
  File "/usr/local/lib/python3.7/site-packages/google_auth_httplib2.py", line 116, in __call__
    url, method=method, body=body, headers=headers, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/httplib2/__init__.py", line 1314, in request
    (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
  File "/usr/local/lib/python3.7/site-packages/httplib2/__init__.py", line 1064, in _request
    (response, content) = self._conn_request(conn, request_uri, method, body, headers)
  File "/usr/local/lib/python3.7/site-packages/httplib2/__init__.py", line 1017, in _conn_request
    response = conn.getresponse()
  File "/usr/local/lib/python3.7/http/client.py", line 1336, in getresponse
    response.begin()
  File "/usr/local/lib/python3.7/http/client.py", line 306, in begin
    version, status, reason = self._read_status()
  File "/usr/local/lib/python3.7/http/client.py", line 267, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/local/lib/python3.7/socket.py", line 589, in readinto
    return self._sock.recv_into(b)
  File "/usr/local/lib/python3.7/ssl.py", line 1071, in recv_into
    return self.read(nbytes, buffer)
  File "/usr/local/lib/python3.7/ssl.py", line 929, in read
    return self._sslobj.read(len, buffer)
ConnectionResetError: [Errno 104] Connection reset by peer

We saw this issue recently as well (also with airflow with a very similar stack trace above).  Making ECONNRESET retriable would be a welcome change.

Greetings, we're closing this. Looks like the issue got resolved. Please let us know if the issue needs to be reopened.


Add an Arabic version of the README file

The README file has too many copies in different languages except Arabic language

I have created an Arabic version of the Readme file

I have created an Arabic version of the Readme file

Arabic translation was added in https://github.com/trekhleb/javascript-algorithms/pull/622

Arabic translation was added in https://github.com/trekhleb/javascript-algorithms/pull/622


feat(tree-shaking): improving tree-shaking for picasso and picasso-provider

SAT-1985
Description
Please refer to the RFC
Development checks

[ ] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure that all PR checks are green
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests

Breaking change

[ ] codemod is created and showcased in the changeset
[ ] test alpha package of Picasso in StaffPortal

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run package:alpha-release

@konstrybakov you might be interested in this section 🤔 https://github.com/toptal/picasso#tree-shaking

Hi @denieler Daniel! Yes, I've seen this section. And we've had a discussion about it. I am playing with a few things here, and I will prepare a proper RFC for discussions :)

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@denieler Daniel, while implementing the changes I've noticed that some of the components that are available on Compound components are already reexported at picasso/src/index.ts. Like:
Dropdown had DropdownArrow assigned to it so we could use Dropdown.Arrow, but at the same time DropdownArrow was reexported as DropdownArrow from picasso/src/index.ts. Same for:

Notification and NotificationActions
Form and FormHint, FormLabel, FormError

Do we want to keep it as is? Or should we clean it up?

Another question here. Even though this change is logically not breaking, I believe there might have been users who have imported components incorrectly, in ways other than import { Component } from '@toptal/picasso. And for them, this update will break the apps. What would be the best course of action? Have some code checker for direct imports? Or just mention it in the BREAKING CHANGES section?

@toptal-bot run package:alpha-release

Another question here. Even though this change is logically not breaking, I believe there might have been users who have imported components incorrectly, in ways other than import { Component } from '@toptal/picasso. And for them, this update will break the apps. What would be the best course of action? Have some code checker for direct imports? Or just mention it in the BREAKING CHANGES section?

I agree, that there might be some misusage of imports and it will probably be safer to release it as breaking change.

Could a codemod help for this instance? @konstrybakov

@OndrejTuma

Could a codemod help for this instance?

I think yes, I just wanted to know for sure, that we are going this way before I delve into code mods :D Never done that, but looks interesting
Now I believe I'm sure I'd better do it

BTW the happo changes are flaky and we are dealing with them in different PR

I am thinking that I'd better add a story for PicassoLight, where do you think would be the best place for it? Should I create a PicassoLight folder and have all the files there?

BTW the happo changes are flaky and we are dealing with them in different PR

Should I just re-run them?

Looks good, I'm just wondering if you tested it out, that it has expected results on bundle? :think

I've tested the changes to the CompoundComponents and they do work. However, I am running into some issues with treeshaking for react-helmet that is used by Favicon and FixViewport. Even though those 2 are not imported anywhere in my project, the webpack in our setup doesn't shake them off if I do import { PicassoLight } from '@toptal/picasso-provider', but if I use direct imports it works nicely.
This is a problem with our Webpack setup, I will have a task on our side to investigate it further

I've applied the PR feedback + added a story for PicassoLight here bc817b3d9cf94a2493e51253284f9013b2f5d1c8

checking in topteam...


Scenario outline title fix

When using the ECMAScript found that when the update for table  was added this section didn't match the step_definitions with feature file. Also, add a simple jest -verbose script to the package.

Merged, thank you!


Build not working with dependencies - 1.1.0

I get this below error -

ERROR in ./assets/index.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: [BABEL] D:\workspace\rayi\react-kanban-1.1.0\assets\index.js: Could not find plugin "proposal-numeric-separator". Ensure there is an entry in ./available-plugins.js for it. (While processing<EMAIL_ADDRESS>at getPlugin (D:\workspace\rayi\react-kanban-1.1.0\node_modules@babel\preset-env\lib\index.js:67:11)
at Array.from.map.pluginName (D:\workspace\rayi\react-kanban-1.1.0\node_modules@babel\preset-env\lib\index.js:258:62)
at Array.map ()
at _default (D:\workspace\rayi\react-kanban-1.1.0\node_modules@babel\preset-env\lib\index.js:258:43)
at D:\workspace\rayi\react-kanban-1.1.0\node_modules@babel\helper-plugin-utils\lib\index.js:19:12
at D:\workspace\rayi\react-kanban-1.1.0\node_modules@babel\core\lib\config\full.js:199:14
at Generator.next ()
at Function. (D:\workspace\rayi\react-kanban-1.1.0\node_modules@babel\core\lib\gensync-utils\async.js:26:3)
at Generator.next ()
at step (D:\workspace\rayi\react-kanban-1.1.0\node_modules\gensync\index.js:254:32)

Though I have solved it through changing versions of few lib, but I don't understand is how a tagged build released to NPM is not working ?

Hi, @iIdiomatic.
When does this error happen? On yarn add?
What libs do you have to change the version for?
Did you have added the styled-component as a dependency of your project?
This is an odd behavior since I have this version running in a production system. Including our demo on codesandbox.

@lourenci
It happens on yarn start, my build platform is windows.
List of changes: (as currently I don't have access to machine that I was working on I am writing this from what I could recall)

I need to remove semantic-release as it doesn't work on windows. (Ideally should not break anything at-least for running).
I copied dependencies from your latest master branch to make it start..
As I thought this should be an OS specific problem I made a try on amazon linux on EC2. Problem persists.

So above were the steps that makes this library standalone workable. Till now I haven't made a talk on making it as dependency. Logs are as above.
Problem second
Now even if I was able to make it work after version changes from master branch. When I tried to make change in library and build it through "prepublishOnly" command.

Firstly I have to make changes to command to make it work on windows, it became -  "webpack --config webpack.prod.js".  Mean I removed rm command and environment setting for production. I believe that impacts nothing.
It was built successfully in dist folder. But when I tried making it local dependency through "file://" in my project. It gave me runtime error for invalid hook call in memo-one library.
It was observed that the index.js file that I was creating from code from github with no changes was around 3kb more than the index.js that is been downloaded from npm.
To mention my main project is just core-ui project https://github.com/coreui/coreui-react.

I ended up copying the whole source code into my main project rather than using it as library.
But again these issues to a tagged build is somewhat strange. May be a minor library difference from the time you build and I build could be a problem as you are not using exact version.
Let me know if you need any further details.

Thanks for the response, @iIdiomatic.
I haven't tried to build the lib on a Windows machine, I'll try to this as soon as possible to figure out that build problems.
In a Linux machine, this is very odd. To run the e2e tests on CI we have to build it before. We don't have any problems with Linux on Github Actions nor Travis CI, both are ubuntu, I think...

Are you trying to use it as a dependency? You shouldn't have any problem using it as a dependency since the lib and its dependencies are bundled all the way.

Yes it don't have any issue if I directly use it from npm. But when I try to build from source it ends up in error of memo-one, in the bundle only.
I set optimize:false for bundler to debug as source code, from where I got to know on memo-one creating issue which in-turn throws error invalid react-hook call.
I believe there is some minor version mismatch that creating this issue, as you not using fixed version. Let me know if more info needed.

@iIdiomatic if i clone your project https://github.com/coreui/coreui-react and try to install this lib, the error should pops up?
I can do some tests here

That's so nice, yes please download source code of 1.1.0 and build it. Please use it as local dependency through "file://" to reproduce issue. As I mentioned, direct inclusion from NPM is working.

@iIdiomatic I download it, added the kanban locally and them npm start. The demo project worked just fine, but i cant import the package:  Can't resolve '@lourenci/react-kanban' in...
I dont know why this error since the project was installed and validated by npm install.
I dont know what else we can do :/


Allow arguments through the commands run-ios/run-android

Context
This PR allows the cavy-cli to receive react native arguments such as --simulator, --configuration and so on.

Hey @igorrfc thanks for this! We've been super busy at Pixie Labs but we'll take a look and get this released soon.


Annotations

Type of change

Refactoring

Description
This PR factors out a new kroxylicious-annotations module, which currently contains only the @VisibleForTesting annotation. This allows to use this annotation outside just the runtime (for example, in filters). In the future this module can also be used for other similar annotations, as we see fit.

Two thoughts.

Is it really independent of kroxylicious-api?

That's a good question. I'm not sure what the right answer is.
On the one hand, I think that would work. On the other hand, putting everything common in the -api means lots of things grow that dependency even if they only need a sliver of the functionality. And this provides a nice example: If you want to add a purely documentary annotation you would have to depend on the whole API module, which obscures just how narrow the dependency truly is. The Vault KMS provider another example: It depends on the api even though it doesn't provide a filter implementation. Rather it depends on some config classes and @Plugin (which is more like an SPI than an API). Having those packages all in -api allows quite distinct responsibilities to become accidentally interdependent.
I admit that I can't point to an irrefutable counterexample for why we must have a separate module. But it does feel like moving in the direction of finer-grained dependencies would be cleaner and might simplify things in the longer term.

I like VisibleForTesting as a name, but a little concerned about the clash with the more common Guava version. Should use ExposedForTesting to avoid the naming clash and breaking peoples brains.

:shrug: so Guava chose another name. I don't feel the need to ape their naming. We're using this annotation to express something about visibility (public, protected, private are almost always called the "visibility modifiers", I've never heard them called "exposure modifiers"), so using visible seems better to me.

🤷 so Guava chose another name. I don't feel the need to ape their naming.

No guava chose the same name hence the cognitive clash. As you say it's the right name.

I'm happy with a separate module, has to start somewhere. Smaller more compostable does feel like the right move.

No guava chose the same name hence the cognitive clash. As you say it's the right name.

Ah, sorry I misread/misunderstood your point!


Install and configure redis

Purpose
We will use the channel layers feature from django channels. For this we need to install channels-redis package, add a redis instance in our docker-compose file and then configure a default channel layer.
Proposal

[x] Install channel-redis
[x] add a redis instance in docker-compose
[x] configure a default channel layer

This PR is part of #1246

Also I saw In-Memory Channel Layer maybe it would be useful for testing settings ?

Definitely and it's made in PR #1284

I don't get this line, how does environ_name works ?
Should we add something to env.d/development.dist ?

It works like any environment variable with django configuration. We use this syntax also for configuring the database, you can take a look. I can add something in the environment file yes.


export default from '...'

verify this shows up as a default export in an importing module, i.e.
// mod.js
export default function () {}

// bar.js
export default from './mod'

// foo.js
import default from './bar' // <= should not report for import/default

Need to add tests for
// mod.js
export x from './x'
export y from './y'

// importer.js
import { x, y } from './mod'

Something in the last few commits broke this case without breaking any tests.


Annoying paperdoll

How to disable PaperDoll in top left corner? Readme says "An example can be found in MrCrayfish's Vehicle Mod", but i cant see anything related there. Why PaperDoll even here? I can't see how it's connected to the purpose of this mod.

It's a feature that was in the Console Edition of Minecraft, you can simply disable it in the config/settings menu.


vscode.authentication.getSession returns undefined.

Hi,
I have implemented an AuthenticationProvider and able to see the sign in option under accounts icon on bottom left.
When we click on sign in icon the browser window opens and user gets authenticated and then it redirect back to vscode.
However in our further flow of application if we ever try to get access to existing authenticationsession using this api
vscode.authentication.getSession(AUTH_TYPE, ["profile"], { forceNewSession: forceNewSession });. It either returns undefined or never returns anything.
Is there anything which we are missing?

Are you passing in true or false for forceNewSession?
Place a breakpoint in your getSessions and createSession... do either of them get called?

If you do:
await vscode.authentication.getSession(AUTH_TYPE, ["profile"], { forceNewSession: true });

It should skip over getSessions and run only createSession... do you not see this?

No.
If i pass either true/false still vscode.authentication.getSession does not return anything.
Execution stops there only.

Ok, can you show me your code? Or better yet, give me a small mocked out AuthProvider implementation that I can use to troubleshoot what's going on?
Both our Microsoft and GitHub auth providers are working fine with forceNewSession so I'm having trouble repro'ing what you're seeing.

@amitsgaba is there a reason you're not awaiting the result?

No. By adding await has fixed the issue.
Thank you for the help.


About the license for this model

Thank you for sharing your great code. :smiley_cat:
What is the license for this model? I'd like to cite it to the repository I'm working on if possible, but I want to post the license correctly.

Model Zoo
https://github.com/PINTO0309/PINTO_model_zoo

ONNX converted GazeNet (GAFA only)
https://github.com/PINTO0309/PINTO_model_zoo/tree/main/297_GazeNet

Thank you.

Thanks.  It is MIT.  We added LICENSE file in the repositry.

Thank you!
I have verified that it is committed to the development branch. :smile:


Fix crash on Kubernetes 1.25

On Kubernetes 1.25, the operator gets into a crash loop, because it tries to get policyv1beta1.PodDisruptionBudget, but it is removed in 1.25. This PR fixes that issue.
Since other resources don't have Owns(&policyv1beta1.PodDisruptionBudget{}), I opted to remove it. In case that is not the direction we want to go about it, feel free to change it.

Thanks!


json2protobuf fails on oneof fields

When decoding a message with oneof fields from JSON, the _case member of the protobuf structure is not set, causing the field to appear to have no value even though a value was given in the JSON.
The attached commits add tests for oneof decoding (currently failing) and a fix (based on code by @dapaulid).

This should fix the randomly failing test. Turns out Jansson 2.7, unlike the 2.9 I was using, does not guarantee a deterministic iteration order over JSON objects.

Coverage increased (+0.3%) to 94.189% when pulling 4cfd03793057dac4bf9c3ff69b996b22117ce4ba on cwalther:json2oneof into ba4792f88698caa7d9e0c7425e09fb29faf3a305 on Sannis:master.

@cwalther thanks!


[WIP] First version of API for object lifecycle management

What this PR does / why we need it:
This PR is for PUT/GET API for object lifecycle management
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
NA
Special notes for your reviewer:
Review PUT API, GET API is still WIP, so it is not yet updated, this is just a first version of the APIs
PUT
http://<IP_ADDRESS>:8089/v1/s3/test/?lifecycle
<LifecycleConfiguration>
  <Rule>
    <ID>id1</ID>
    <Filter>
       <Prefix>documents/</Prefix>
    </Filter>
    <Status>Enabled</Status>
    <Transition>
      <Days>30</Days>
      <StorageClass>GLACIER</StorageClass>
    </Transition>
  </Rule>
  <Rule>
    <ID>id2</ID>
    <Filter>
       <Prefix>logs/</Prefix>
    </Filter>
    <Status>Enabled</Status>
    <Expiration>
      <Days>365</Days>
    </Expiration>
  </Rule>
</LifecycleConfiguration>

GET
//TODO
Release note:

@sfzeng Please review
@skdwriting  Please review

For api/cmd/main.go:
Why you updated api/cmd/main.go ?

For api/pkg/examples/policy.json:
bucketlifecycleput should be bucketlifecycle:put, bucketlifecycleget should be bucketlifecycle:get

For api/pk/s3/router.go:
The following does not need to be added, because the RouteBucketGet can route the request to the specific function.
ws.Route(ws.PUT("/{bucketName}/?lifecycle").To(handler.RouteBucketPut)).Doc("Create lifecycle configuration for the bucket")
ws.Route(ws.GET("/{bucketName}/?lifecycle").To(handler.RouteBucketGet)).Doc("Get lifecycle configuration from the bucket")

For s3/proto/s3.proto:
Your code is conflict with the latest version of developement branch, please pull the latest version and change based on that.

For vendor/github.com/golang/protobuf/***:
Why need created so many files? We did not have them, but multi-cloud work well, so please make sure if it is necessary.

while creating lifeCycle, It's necessary to verify that the  can't be duplicated, please add  check.

please fix CI error

Also please reslove the conflict errors.

link to new PR : https://github.com/opensds/multi-cloud/pull/127


Failed to upload file to database on heroku website

Tried to upload a file with the following text to the heroku website:
#name,ID,R[pc],V[km/s],SurfDens[Msun/pc^2]
MarkSwinbank,1,110.,45.,1.0e+04
MarkSwinbank,2,116.,82.,2.2e+04
MarkSwinbank,3,105.,63.,4.0e+04
MarkSwinbank,4,160.,74.,2.8e+04
MarkSwinbank,5,300.,56.,8.6e+03
Here is the text I entered:

I get the standard "The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.” error message when I hit submit.

@snlongmore if you open the "Inspector" using chrome, safari, or firefox, and you look at the Javascript console (I can help you find this if needed), do you see errors popping up?
Does the latest version work with https://github.com/camelot-project/frontend/pull/96 included?
(also, I was wrong, this is a frontend issue, not a database issue)

@snlongmore Maybe the server didn't like the reference ;) ...shouldn't it be http://adsabs.harvard.edu/abs/2011ApJ...742...11S?

@jmdkastro very true! Good spot. Clearly there is no way to get around user error here. Perhaps a function to automatically recognise the paper from the data...just kidding @keflavich!

Sorry @keflavich but I broke it again. Tried to upload snl_bolatto_08.csv and got the same error again. Here is the screen shot of the input

Weird!!! When I go to the Heroku website and try to query the database it says the Bolatto data is there... is this related to my above issue??

Similar problem here. I tried to upload my dataset and it told me that there was no difference with the current version of the database, but on query it shows my dataset as well!

@agianne - that means your data set was already included in the database, I think?

@keflavich It would seem so. However I checked the query page before submitting and it was not there. I don't understand what's happened there

Neither do I.  Something is wrong with the database on the heroku server.   I'll investigate.

@agianne I think it is probably fixed now.  Could you give it a try in >2 minutes?

Tested again. I did not enter the ADS ID, but just the DOI and I got an internal server error. The data set was uploaded anyway.

could you save your upload form and take a screenshot?
Your database was not successfully uploaded - there is no new pull request.

I noticed - but I see my data in the query!

This is the error I get:

and finally the query results:

I think this means that the cleanup stage failed, which is very bad.

@agianne I'm deploying another attempt at a solution.  I still don't understand what's causing your underlying problem, but I should have cured enough of the symptoms to now see past them.

@keflavich same error. At least I don't see my dataset in the query!

The problem seems to be that the table did not read correctly.  However, I can't reproduce your error; I get:
There has been a server-side error:
The value must be a valid Python or Numpy numeric type.
Traceback (most recent call last): File "upload_form.py", line 306, in set_columns convert_units(table) File "/Users/adam/repos/camelot_frontend/ingest_datasets_better.py", line 93, in convert_units tbl[k] = tbl[k].to(v) File "/Users/adam/repos/astropy/astropy/table/column.py", line 688, in to return self.quantity.to(unit, equivalencies) File "/Users/adam/repos/astropy/astropy/table/column.py", line 666, in quantity return Quantity(self, copy=False, dtype=self.dtype, order='A') File "/Users/adam/repos/astropy/astropy/units/quantity.py", line 243, in __new__ raise TypeError("The value must be a valid Python or " TypeError: The value must be a valid Python or Numpy numeric type.

Try to remove the header line with the units (https://github.com/camelot-project/frontend/issues/45)

I'm also getting the same error as @agianne.

Can confirm that frontend #104 appears to fix this issue.

So I just tried to upload a file to the database for Lisa Wei's data and got the following error

I checked and found there was actually still a PR #82 for that data set from when I tried a few weeks ago, so I thought this might explain the error. However, I then checked closely and see I left a space between the first and last name, i.e. "Lisa Wei" instead of "LisaWei". I then repeated the upload removing the space and it seems to have worked fine. This rules out the previous attempt at submitting this data set from causing the problem. If it is the "space" problem, I suspect this may be a common mistake. It would be good to (i) add a warning message about this on the upload page, (ii) not let the person submit if there is a whitespace in the name field.

I just tried to upload Mark Heyer's data with these parameters

and got the following error:

Not sure what went wrong there -- I can't see anything obviously stupid with the values I put in...


java.lang.ClassNotFoundException: org.apache.hive.jdbc.HiveDriver

There is a problem when I execute hms-mirror -db tpcds_text_2 -e.

[root@host3 aux_libs]# hms-mirror -db tpcds_text_2 -e
APP_DIR: /usr/local/hms-mirror/bin
Running Host instance
Application JAVA_OPTS=-Xms2048m -Xmx4096m -XX:+UseG1GC
PRG_ARGS= "-db" "tpcds_text_2" "-e"
openjdk version "1.8.0_312"
OpenJDK Runtime Environment (build 1.8.0_312-b07)
OpenJDK 64-Bit Server VM (build 25.312-b07, mixed mode)
Using Config: /root/.hms-mirror/cfg/default.yaml
.... Accept/Acknowledge to continue ....
I have made backups of both the 'Hive Metastore' in the LEFT and RIGHT clusters (TRUE to proceed): true
I have taken 'Filesystem' Snapshots/Backups of the target 'Hive Databases' on the LEFT and RIGHT clusters (TRUE to proceed): true
'Filesystem' TRASH has been configured on my system (TRUE to proceed): true
java.lang.ClassNotFoundException: org.apache.hive.jdbc.HiveDriver
at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:822)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
at com.cloudera.utils.hadoop.hms.util.DriverUtils.getDriver(DriverUtils.java:44)
at com.cloudera.utils.hadoop.hms.mirror.ConnectionPools.initDrivers(ConnectionPools.java:59)
at com.cloudera.utils.hadoop.hms.mirror.ConnectionPools.init(ConnectionPools.java:49)
at com.cloudera.utils.hadoop.hms.Mirror.init(Mirror.java:561)
at com.cloudera.utils.hadoop.hms.Mirror.main(Mirror.java:1073)
HMS-Mirror v.<IP_ADDRESS>-SNAPSHOT                            Data Strategy: SCHEMA_ONLY*
DB/TBL  Total:(1/0)
===================================================================================
TBLS (Started/Completed/Errors)->(0/0/0)           Elapse Time: 0secs
Run Mode                 : EXECUTE
Config file             : /root/.hms-mirror/cfg/default.yaml
HMS-Mirror v.<IP_ADDRESS>-SNAPSHOT                            Data Strategy: SCHEMA_ONLY
DB/TBL  Total:(1/0)
===================================================================================
TBLS (Started/Completed/Errors)->(0/0/0)           Elapse Time: 0secs
Run Mode                 : EXECUTE
Config file             : /root/.hms-mirror/cfg/default.yaml
Databases():
tpcds_text_2
Report file              : /root/.hms-mirror/reports/2021-12-24_15-54-44/_hms-mirror.md|html
LEFT Execute file        : /root/.hms-mirror/reports/2021-12-24_15-54-44/_LEFT_execute.sql
RIGHT Execute file       : /root/.hms-mirror/reports/2021-12-24_15-54-44/_RIGHT_execute.sql
LEFT Action file         : /root/.hms-mirror/reports/2021-12-24_15-54-44/_LEFT_action.sql
RIGHT Action file        : /root/.hms-mirror/reports/2021-12-24_15-54-44/_RIGHT_action.sql

Configuration：

transfer:
concurrency: 10
transferPrefix: "transfer_"
exportBaseDirPrefix: "/apps/hive/warehouse/export_"
clusters:
LEFT:
legacyHive: true
hcfsNamespace: "hdfs://192./tmp/hivemove/"
hiveServer2:
uri: "jdbc:hive2://192.:10000"
connectionProperties:
user: "hive"
password: " "
jarFile: "/usr/hdp/current/hive-server2/jdbc/hive-jdbc-1.2.1<IP_ADDRESS>.0-292-standalone.jar"
RIGHT:
legacyHive: false
hcfsNamespace: "hdfs://192./tmp/hivemove/"
hiveServer2:
uri<EMAIL_ADDRESS>connectionProperties:
user: "hive"
password: " "
# jarFile: "/opt/cloudera/parcels/CDH/jars/hive-jdbc-3.1.3<IP_ADDRESS>.0-257-standalone.jar"
partitionDiscovery:
auto: true
initMSCK: true

The jar file for the "RIGHT" cluster needs to be in $HOME/.hms-mirror/aux_libs since it's commented out in the config.

The jar file for the "RIGHT" cluster needs to be in $HOME/.hms-mirror/aux_libs since it's commented out in the config.

Yes, I did.
If this is not done, another error will occur.
[root@host3 ~]# cd .hms-mirror/aux_libs/
[root@host3 aux_libs]# ls
hive-jdbc-3.1.3<IP_ADDRESS>.0-257-standalone.jar

The LEFT clusters JDBC driver you're referencing in the config is on the host your running hms-mirror from?  Seems like you're referencing an HDP installation and I assume you're running hms-mirror on a CDP host, so this file wouldn't be present.

You are right. I copied the jdbc driver of the LEFT cluster to the RIGHT cluster. This problem has been solved.

Thanks ,you are right. I copied the jdbc driver of the LEFT cluster to the RIGHT cluster. This problem has been solved.


[OPIK-605] [SDK] Add track parameter to LLM metrics and make evaluate function create both trace and spans

Details
A new parameter track has been added with a default value of True.
Now, evaluation metric calls will be tracked automatically. See the example in the image.
(result for sdks/python/examples/evaluation_example.py)

Testing
Tests are updated

:+1:


Initial skeleton

Thanks @traversaro. Waiting also for @diegoferigo approval since I inherited the structure from https://github.com/ami-iit/rod

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

Ah, you mean this part https://github.com/ami-iit/stepwise/blob/fab37f0aef4d67002258633eea2ddfde8027d962/.github/workflows/ci_cd.yml#L12-L46 ?

Yes.

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

Related to the very old activity I've never finalized https://github.com/ami-iit/bipedal-locomotion-framework/pull/296.

The after removing the packaging section, the CI/CD file is broken because of this line https://github.com/ami-iit/hippopt/blob/7cff695da46883033771f59b12996a93269852d7/.github/workflows/ci_cd.yml#L14

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

I'd actually suggest to keep the job there and just comment out the Upload artifacts step.

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

I'd actually suggest to keep the job there and just comment out the Upload artifacts step.

I think it is necessary for https://github.com/ami-iit/hippopt/blob/170169dbcae552aabc0aa3bc58aa014cbbf05d76/.github/workflows/ci_cd.yml#L72-L83

Sorry @S-Dafarra the file in this PR keeps changing and it's difficult to point to a section. I had a better look to the workflow. I agree with @traversaro, we can remove/comment out the entire publish job. I forgot the workflow has a test job that already pulls the artifact and tests the wheel.
For what regards deployment to PyPI, we should discuss it separately since there might be limitations in the current dependencies that are on PyPI (particularly the casadi wheel, and blf if we want to use it).

Lastly, you can consider specifying the citation in a CITATION.cff file.

Good point. I am trying to check if I can generate it in some way

Lastly, you can consider specifying the citation in a CITATION.cff file.

Good point. I am trying to check if I can generate it in some way

I did not find anything, but I also noticed that bib files should be supported too: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files#other-citation-files

All green. Squashing and merging


Use grammar to quote identifier

Fixes https://github.com/z-song/laravel-admin/issues/161
There are likely other places that need to use Grammar to quote identifiers. I'll update this PR as I learn the laravel-admin framework.

Thank you so much for fix this issue!


Add buffer-level prettier exec command to doc

Summary
Adding the changes from #256 into the proper Vim doc document

Thank you!


Migrate to TypeScript v5

Description

Supersedes #2729.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

How to test

Checklist

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

27 of 52 (51.92%)  changed or added relevant lines in 18 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 33.96%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/editingWorkspace/EditingWorkspace.tsx
0
1
0.0%

src/commons/sideContent/SideContentHelper.ts
0
1
0.0%

src/commons/utils/JsSlangHelper.ts
3
4
75.0%

src/commons/XMLParser/XMLParserHelper.ts
0
2
0.0%

src/commons/collabEditing/CollabEditingHelper.ts
1
3
33.33%

src/commons/utils/TypeHelper.ts
1
3
33.33%

src/pages/academy/gameSimulator/subcomponents/assetViewer/AssetViewerUtils.tsx
0
2
0.0%

src/pages/academy/grading/subcomponents/GradingBadges.tsx
0
3
0.0%

src/pages/academy/teamFormation/subcomponents/TeamFormationTable.tsx
0
5
0.0%

src/commons/utils/DisplayBufferService.ts
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/pages/academy/game/Game.tsx
1
0.0%

src/pages/academy/gameSimulator/subcomponents/assetViewer/AssetViewerUtils.tsx
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
5251

Relevant Lines:
14381

💛  - Coveralls


[#1472][part-5][FOLLOWUP] Fix Netty transport time when sending shuffle data requests

What changes were proposed in this pull request?
Refresh timestamp when sending SendShuffleDataRequest.
Why are the changes needed?
A follow-up PR for: https://github.com/apache/incubator-uniffle/pull/1534
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.

@jerqi @zuston PTAL


Add some missing functionality from original vulcan-api

Hello!
My team and I are working on our project with this library, but we've noticed that it doesn't implement the functionality we needed that is present in the original vulcan-api. So we created this PR to contribute our work back to this repo.

Hi, thank you for the contribution.
I was gonna add these at some point but never got around to actually do it. You did some great work. Would you mind getting rid of that console.log tho? As soon as that's done I will get it merged.

Hello, are you there?


for react 19

the peerDependencies of use-sync-external-store 1.4.0 is "react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0"
Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

The bump is within the range allowed, what was the issue you found?


Add Sync Text Reveal to the Playing Voice

This PR adds the ability to slow down text to match the current character speaking.
Many Visual Novels have this feature, it enforces the player's reading to slowdown, which may be wanted for immersion. Especially if they want to wait for the voice to finish playing.
Closes https://github.com/dialogic-godot/dialogic/issues/1908.

do you have some examples of it in action?

do you have some examples of it in action?

I have no video of this feature. However, it simply slows down the letter speed based on the current voice audio, if there is any.


fix: cogserv-luis-runtime: remove mocha arrow functions

Packages impacted by this PR
sdk\cognitiveservices\cognitiveservices-luis-runtime
Issues associated with this PR
#13005
Describe the problem that is addressed by this PR
The existing mocha tests for the sdk\cognitiveservices\cognitiveservices-luis-runtime made use of the arrow syntax for callback functions. Mocha recommends not to do this because you lose access to the mocha context (https://mochajs.org/#arrow-functions).
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The reason for utilizing the function keyword instead of an arrow syntax to write the callback functions in these mocha tests is to maintain access to the mocha context.
Are there test cases added in this PR? (If not, why?)
No additional test cases were added in this PR as the change only required modifying existing test cases.
Provide a list of related PRs (if any)
#23761 - Same fix, but for the sdk\search\search-documents package
#23789 - Same fix but for the sdk\attestation\attestation package
#23835 - Same fix but for the sdk\batch\batch package
#23850 - Same fix but for the sdk\cognitivelanguage\ai-language-conversations package
#23881 - Same fix but for the sdk\cognitiveservices\cognitiveservices-luis-authoring
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Not applicable
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)

I don't believe this is relevant.

[ ] Added a changelog (if necessary)

I don't believe this is necessary

@xirzec just bumping this since it has been some time since changes were approved.

/check-enforcer override


Change log type if AdMob id is not valid

Change log type from 'Error' to 'Warning'
When a user has his own build system, he does not need these automations from Appodeal.
And in this situation - it is not an error. I suggest to leave it as a warning when building and not as an error.It would be nice if the user could have control over the automations from Appodeal.

In general, it would be nice if the user could have control over the automations from Appodeal. In particular, to be able to completely disable Appodeal Settings and all of its checks.
Thanks!

Thank you for your answer, I write about this icon once (I know that the problem with interrupting the build is fixed).
When you compile a build, you pay attention to the console output, about logic - an error means that something is wrong in the build and it needs to be fixed, although in this situation it is not so.
And for good, there should not even be Debug.Warning(), but simply Debug.Log().
Since users who do not look at the log will not notice either one or the other.
And those who keep the log in order will also notice the "info" message.


[DDW-192] Improve form fields feedback UX

This PR updates to<EMAIL_ADDRESS>which includes the improved FormField component, using PopOver to display errors, similar to how it was implemented in the PasswordInput before:
Screenshots

Testing Checklist

Slack QA thread
[ ] Test all forms within Daedalus & Storybook to check if there is anything broken / not rendering correctly.
Validate the following inputs:
[x] Wallet - Send - Receiver
[x] Wallet - Send - Amount
[x] Wallet - Send - Confirm transaction - Password
[ ] Wallet (Byron) - Transfer funds - Password
Wallet - Transactions - Filter - Date to
[x] Wallet - Transactions - Filter - Date from
[x] Wallet - Transactions - Filter - Amount to
[x] Wallet - Transactions - Filter - Amount from
[x] Wallet - More - Settings - Name
[x] Wallet - More - Settings - Password - Change - Current Password
[x] Wallet - More - Settings - Password - Change - New Password
[x] Wallet - More - Settings - Password - Change - Repeat Password
[ ] Wallet - More - Settings - Verify wallet recovery phrase - Recovery Phrase
[x] Wallet - More - Settings - Delete - Enter the name
[ ] Add Wallet - Create - Wallet Name
[ ] Add Wallet - Create - Enter Password
[ ] Add Wallet - Create - Repeat Password
[ ] Add Wallet - Create - Verify your recovery phrase
[ ] Add Wallet - Restore - Recovery phrase
[ ] Add Wallet - Restore - Wallet Name
[ ] Add Wallet - Restore - Enter Password
[ ] Add Wallet - Restore - Repeat Password
[ ] Redeem Incentivized Testnet Rewards - Recovery Phrase
[ ] Redeem Incentivized Testnet Rewards - Password
[ ] Staking - Delegation Wizard - PasswordStaking - Stake Pools - Search box

Testing Summary
For build 15198
New:
1 - Sometimes, the red border delays to appear for the input  Wallet - Send - Amount. This doesn't happen all the time, but I could reproduce it 1/4 times in Windows. Here's a recording.
2 - There're many logs on the console now, is this expected?. Here's a screenshot.
Fixed:
1 -  The width of the tooltip extends nearly the same width as the app. 2) The text is not nicely aligned. 3) The tooltip position doesn't originate from the hovered element as it should. See screenshot here
2 - On the input Wallet - Transaction - Filter - Date/Amount to: when the value in "to" is smaller than in "from" an empty tooltip is displayed. Check screenshot for "Date to" and "Amount to"
3 - For the input Recovery Phrase  (On Wallet-Create/Restore and Settings - Verify wallet recovery phrase) the tooltip is not displayed until hovering the field. Check the recording here.
4 - This is a suggestion and needs confirmation from @nikolaglumac, as the behavior is similar in production, but is inconsistent with similar fields:
The inputs Redeem rewards - Recovery phrase and Redeem rewards - Password  show no red border when the data is invalid/incomplete. The tooltip is displayed when hovering, so it might be unclear for the user until then. Here are a recording and a screenshot.
5 - The Password inputs in Add Wallet - Restore look smaller than before. I checked this and couldn't reproduce it in production. Check screenshot.
Rejected:
1 - When attempted to delegate a wallet to a pool, during confirm delegation, the old style error message was displayed instead of the new tooltip style. See here
2 - On Storybook, screen Staking - Stake Pool list this error is displayed,

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@DominikGuzei I added a list of the inputs we validated on the description of this PR. On the build 15113 these are the issues so far:
1 - On the input Wallet - Transaction - Filter - Date/Amount to: when the value in "to" is smaller than in "from" an empty tooltip is displayed. Check screenshot for "Date to" and "Amount to"
2 - For the input Recovery Phrase  (On Wallet-Create/Restore and Settings - Verify wallet recovery phrase) the tooltip is not displayed until hovering the field. Check the recording here.
3 - This is a suggestion and needs confirmation from @nikolaglumac, as the behavior is similar in production, but is inconsistent with similar fields:
The inputs Redeem rewards - Recovery phrase and Redeem rewards - Password  show no red border when the data is invalid/incomplete. The tooltip is displayed when hovering, so it might be unclear for the user until then. Here are a recording and a screenshot.
4 - On Storybook, screen Staking - Stake Pool list this error is displayed,

Hi @DominikGuzei, hope you are well. Here are the issues on build 15115. Thank you:
New
1 - When attempted to delegate a wallet to a pool, the old style error message was displayed instead of the new tooltip style. See here
Pending
1 - On the input Wallet - Transaction - Filter - Date/Amount to: when the value in "to" is smaller than in "from" an empty tooltip is displayed. Check screenshot for "Date to" and "Amount to"
2 - For the input Recovery Phrase  (On Wallet-Create/Restore and Settings - Verify wallet recovery phrase) the tooltip is not displayed until hovering the field. Check the recording here.
3 - This is a suggestion and needs confirmation from @nikolaglumac, as the behavior is similar in production, but is inconsistent with similar fields:
The inputs Redeem rewards - Recovery phrase and Redeem rewards - Password  show no red border when the data is invalid/incomplete. The tooltip is displayed when hovering, so it might be unclear for the user until then. Here are a recording and a screenshot.
4 - On Storybook, screen Staking - Stake Pool list this error is displayed,

3 - This is a suggestion and needs confirmation from @nikolaglumac, as the behavior is similar in production, but is inconsistent with similar fields:
The inputs Redeem rewards - Recovery phrase and Redeem rewards - Password  show no red border when the data is invalid/incomplete. The tooltip is displayed when hovering, so it might be unclear for the user until then. Here are a recording and a screenshot.

@gnpf @DominikGuzei the correct behavior would be that all fields in error state have red border - tooltip is shown on hover or on focus on the field.
cc @daniloprates @a-rukin

@DominikGuzei For the build 15115, here's a new summary:
New
1 - The Password inputs in Add Wallet - Restore look smaller than before. I checked this and couldn't reproduce it in production.
Pending
1 - When attempted to delegate a wallet to a pool, during confirm delegation, the old style error message was displayed instead of the new tooltip style. See here
2 - On the input Wallet - Transaction - Filter - Date/Amount to: when the value in "to" is smaller than in "from" an empty tooltip is displayed. Check screenshot for "Date to" and "Amount to"
3 - For the input Recovery Phrase  (On Wallet-Create/Restore and Settings - Verify wallet recovery phrase) the tooltip is not displayed until hovering the field. Check the recording here.
4 - This is a suggestion and needs confirmation from @nikolaglumac, as the behavior is similar in production, but is inconsistent with similar fields:
The inputs Redeem rewards - Recovery phrase and Redeem rewards - Password  show no red border when the data is invalid/incomplete. The tooltip is displayed when hovering, so it might be unclear for the user until then. Here are a recording and a screenshot.
5 - On Storybook, screen Staking - Stake Pool list this error is displayed,

@nikolaglumac @darko-mijic @a-rukin please check issue 2 reported by @gnpf ☝ is that OK? This PR is only concerned about updating to the improved FormField component, it doesn't handle high-level errors that are not related to a specific form field.

@gnpf regarding PENDING 2: how did you enter the invalid dates? The date pickers didn't let me pick the invalid combination

@nikolaglumac @darko-mijic @a-rukin please check issue PENDING 1 reported by @gnpf ☝ is that OK?

hm... it looks like error connected to the password field, no?

@gnpf regarding PENDING 2: how did you enter the invalid dates? The date pickers didn't let me pick the invalid combination

@DominikGuzei To reproduce this issue, follow these steps:
1 - Select "All transactions"
2 - Select on "to" any date allowed
3 - Select on "from" a posterior date
Check this recording (it's an unrelated build)

@a-rukin yes and no … it is related to password input but it's not a regression in the scope of this PR, since this error is simply not passed to the password input form field itself but displayed as an "server error". But i will check how easy a fix to this issue would be 👍

1 - When attempted to delegate a wallet to a pool, during confirm delegation, the old style error message was displayed instead of the new tooltip style. See here

☝ this is a server side error and it looks as expected. We do not expect this error to be shown in a form of a tooltip on the field at this moment. We will handle this in a separate card.
cc @DominikGuzei @gnpf

@DominikGuzei Great job, most of the issues are fixed, but there is one that I can still reproduce. For the build 15115, here's a new summary:
Reincident
1 - On the input Wallet - Transaction - Filter - Date/Amount to: when the value in "to" is smaller than in "from" an empty tooltip is displayed. Check screenshot for "Date to" and "Amount to"
New screenshot here.
Fixed
1 - The Password inputs in Add Wallet - Restore look smaller than before. I checked this and couldn't reproduce it in production. Check screenshot.
2 - For the input Recovery Phrase  (On Wallet-Create/Restore and Settings - Verify wallet recovery phrase) the tooltip is not displayed until hovering the field. Check the recording here.
3 - This is a suggestion and needs confirmation from @nikolaglumac, as the behavior is similar in production, but is inconsistent with similar fields:
The inputs Redeem rewards - Recovery phrase and Redeem rewards - Password  show no red border when the data is invalid/incomplete. The tooltip is displayed when hovering, so it might be unclear for the user until then. Here are a recording and a screenshot.

@gnpf the last issue with the tx filter should be fixed now 👍

Hi @DominikGuzei, as discussed on Slack
For build 15197:
New issue
On the tooltip for "Paper Wallet" in "More" tab.

The width of the tooltip extends nearly the same width as the app. 2) The text is not nicely aligned. 3) The tooltip position doesn't originate from the hovered element as it should. See screenshot here

@mioriohk the paper wallet tooltip should look better now 👍

@gnpf great catches! 👍
1 - yeah the form field always delays the error state to 1 second after the last change of the error message (so I guess in this case the final error message returns after calculating the fees and then it waits another 1 second before displaying it) … which is not optimal in this very case but required to make the typing UX better (e.g: that the error is only shown after a short delay while typing) - but now that im thinking of it - the problem might be better solved by using the last input change as the start of the delay (then it would work for the typing case but would show immediately in the calculation case)

@nikolaglumac @gnpf I removed the form field error delay as I figured that it's not the right place to make this decision - the error delay should be provided by the form component (by debouncing the input change before passing on the error). The form field component is not really in the position of handling this kind of UX automatically. This means the UX will be more similar to what we already had in Daedalus (but with pop overs which fade-in to display the errors)

@a-rukin please review this one 🙏

@a-rukin none of these points are related to this PR:
1: I don't know why it shows this pending tx error, but it surely is not an issue introduced in this PR (can you try to reproduce on develop?)
2 + 3: Yes, that's expected as it is a server error which is not passed to the password form field
4: No agreement yet, although I wouldn't say this is a blocker for this PR
5: I am pretty sure that this is not related (can you try to reproduce on develop?)

2 + 3: Yes, that's expected as it is a server error which is not passed to the password form field

would it be possible to handle them in the same tooltip way? (maybe in not this PR, but in future)

@a-rukin i'm not sure, we need to check that - but i guess it will be possible 👍


Pause playback on queue empty, free buffers on close.

Fixes an issue on mac os that audio stops playing after closing the first time. (open browser, play something, close, reopen -> no more sound)

@mfleisz
@akallabeth
Can you both please take care to get this into tcvier ASAP and make a new dmg for testing.
But please first test that this fix does not brake anything on Linux and Windows

@mgibson2 the changes are in some mac specific code, so no need to worry.

@mgibson2 The changes are in files only compiled when the target is iOS or MacOS, so no chance it breaks something on other platforms.

@akallabeth
OK, thx


0x spike

Added the ZeroXTradeToken. This is the contract that will fulfill signed 0x orders for Augur.
Also removed the code to change on chain order price and to support ignoring shares since they both add complexity that we don't really want.

Gonna keep the other 0x code here for now as its sort of a separate use case


Adding private urls in routes.yaml for eric

Short description outlining key changes/additions
Adding private urls in routes.yaml for eric
JIRA Ticket Number
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Infrastructure change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[ ] I have added/updated functional tests where appropriate
[ ] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: No security warnings found


Virtual Network module fails when deploying to a network that has existing workloads in it

If the virtual network already contains workloads in it, attempting to redeploy the vnet results in failure.
Description
The reason is that we are defining the subnet resources outside of the virtual network resource, and that tries to delete all the subnets in the virtual network, which fails. Although we are defining the subnets as a child resource. This doesn't work with this type of resource as all the subnets need to be in the VNET resource.
This was discovered when running the dependency pipeline (in a fork) and had the following error:
     | 3:53:28 PM - The deployment 'virtualNetworks-20220309T1503008054Z' failed with error(s). Showing 1 out of 1 error(s).
Status Message: Subnet crawl-az-subnet-x-001 is in use by /subscriptions/20d6fbfe-b049-471c-95af-1369d14d0d45/resourceGroups/validation-rg/providers/Microsoft.Network/networkInterfaces/adp-crawl-vm-01-nic-01/ipConfigurations/ipconfig01 and cannot be deleted. In order to delete the subnet, delete all the resources within the subnet. See aka.ms/deletesubnet. (Code: InUseSubnetCannotBeDeleted)
CorrelationId: b833c292-0cba-4699-91b1-3213358bbb78

Additional references.
Looking up this issue, I can see it already raised here https://github.com/Azure/bicep/issues/4653 with the recommendation to have it in the single vnet resource https://github.com/Azure/bicep/issues/4653#issuecomment-930420476 and this is also still an open item here https://github.com/Azure/azure-quickstart-templates/issues/2786
Steps to reproduce

Create a VNET using the module
Create a workload in that VNET
Redeploy the VNET module

Screenshots
During a deployment, this is what happens inside the VNET (when it doesn't have resources)

However, this does solve it (AS A WORKAROUND) and a roll back to the PR https://github.com/Azure/ResourceModules/pull/1081

We need to discuss on:

Removing the child resource subnet
Align the subnet properties to the ARM documentation https://docs.microsoft.com/en-us/azure/templates/microsoft.network/virtualnetworks/subnets?tabs=bicep#subnetpropertiesformat
What are we forgoing from user experience and flexibility if we do that

Hey @ahmadabdalla, we should definitely not roll back 1:1 as I removed it one purpose due to an issue that was caused by keeping it (most notably e.g. that the original implementation would clash with ALZ policies). I'd suggest we either find a way to reference 'existing' subnets and pass them in (e.g. with an existing reference if that doesn't throw an exception if empty), or we must duplicate the child resource's property (which would be the worst case scenario).

@MrMCake what is the clash you're referring to? The subnet being embedded in the vnet resource?

Hey @ahmadabdalla, the issue was that the subnets would be deployed without the NSG property and hence remove it. The choice was to either add all subnets properties (and duplicate them), or, remove the subnet property alltogether. I did the later as it seemed to logical choice at time time (not knowing it would remove the child templates).
Let's have a call about this some time.


supercharged-dhbw:1.3.1

I am submitting

[ ] a new package
[x] an update for a package

Description:

don't display list of tables when empty
don't display code snippets list when empty
improve spacing for many authors (>4)
improve paragraph spacing

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Thanks :)


Using a field named query as GraphQL parameters breaks the generated code

When using a query as parameter in a graphQL query, it gets overriden by the code generation query field. As a consequence, all graphQL queries which allow for a query parameter do not work.
I propose to rename your variable to __query (double underscore ) as of the GraphQL Spec (https://spec.graphql.org/October2021/):

Any Name within a GraphQL type system must not start with two underscores "__" unless it is part of the introspection system as defined by this specification.

I think this would be a safe choice.
See an illustrative example below, where the argument gets directly overridden and as a consequence, the payload has syntax errors
    async def devices(
        self,
        query: Union[Optional[str], UnsetType] = UNSET,
        page: Union[Optional[int], UnsetType] = UNSET,
        page_size: Union[Optional[int], UnsetType] = UNSET,
        id: Union[Optional[str], UnsetType] = UNSET,
        ordering: Union[Optional[str], UnsetType] = UNSET,
        scope: Union[Optional[Any], UnsetType] = UNSET,
        **kwargs: Any
    ) -> Devices:
        query = gql(
            """
            ...
            ...
            ...

I understand now. The problem is generated methods shadowing arguments names with internal variables.

Yes, precisely! Now to not impose a breaking change (by e.g. introduce an Args Object like other code generators), I think the renaming as described above could be a good option

Thanks a lot for your efforts @rafalp and @Minister944. Everything is working as expected! Cheers


Override note names with an alias or another format

With my Daily Notes workflow it works great now. But I still have a request for an improvement:
For an overview of when I talked to whom on the phone or that I did a task last Thursday, the output of the weekday is useful.
For this I think 2 alternativ possibilities:
(1)
additional entry in the settings:
"Show first alias if available".
My daily Notes look like this by example :
---
aliases:
- "2023-05-08 Mo"
week: [[2023-w19]]
month: [[2023-05]]
---

CONTENT...

Then this alias is shown in the side pane instead of the filename.
(2) alternatively
additional entry in the settings:
"Date Formatstring for showing in Sidepane".
Then the custom format will be shown in the sidepane instead of the file name of the daily note.
Examples:

Is there a possibility to add one of these variants?
(I would prefer variant (2))
Originally posted by @benpla in https://github.com/iiz00/obsidian-daily-note-outline/issues/9#issuecomment-1538059210

I think both of these are technically possible, but I doubt that there is demand for (2), since I think that many users will customize the daily note titles themselves as they wish.
Regarding (1), I haven't looked into getting frontmatter yet, so it will take some time.
However, I would like to use frontmatter for other functions, so I may be able to implement it eventually.
In the meantime, as an easily implementable alternative, I would like to add the day of the week, week number, etc. to the information that can be displayed next to the file name (in the next version, this will be easily toggled from right-clicking on the settings icon).

In v1.1.0, the day of the week, etc. can be displayed with the note title. You can toggle it by right clicking on the settings icon. Hope this helps.


[SPARK-50068][SQL] Refactor TypeCoercion and AnsiTypeCoercion to separate single node transformations

What changes were proposed in this pull request?

This PR proposed a refactor to TypeCoercion rule in order to separate logic for transformation of a single node into separate files. Refactor is doing the following:

Split the interface TypeCoercionBase into TypeCoercionBase and TypeCoercionHelper in separate abstract classes
TypeCoercionHelper contains declarations of all utility virtual methods  that are later overriden in TypeCoercion and AnsiTypeCoercion
transform methods that rely on these virtual methods are refactored so that the check whether children have been resolved remains as is while other match cases are refactored and moved into separate objects inside TypeCoercionHelper
transform methods that don't depend on these virtual methods are refactored to separate files in a similar manner to previous point
In cases where check whether the children are resolved is wrapped into another case, that case is split into 2 cases: one that checks children and one that does the other check
All type coercion rules shared between TypeCoercion and AnsiTypeCoercion  remain in TypeCoercionBase.
TypeCoercionBase inherits TypeCoercionHelper
TypeCoercion and AnsiTypeCoercion inherit TypeCoercionBase

This PR doesn't refactor type coercion rules that don't have a separate transform method but traverse the tree from their apply method. This will be done in a separate PRs.
Why are the changes needed?

Refactoring to support Analyzer++ effort
Does this PR introduce any user-facing change?

How was this patch tested?

Existing tests
Was this patch authored or co-authored using generative AI tooling?

yeah

Reverted renaming changes

thanks, merging to master!


Failed to write access log entry: kafka: Failed to produce message to topic test: dial tcp: lookup iZj4vv43r7jo5rwvxbq48yZ: no such host

Hello，I have a problem but I can't find a solution in google or bing.
I want to try this package, but I have a problem when I using it.
func init() {
	config := sarama.NewConfig()
	config.Metadata.Full = true
	config.Producer.RequiredAcks = sarama.WaitForAll
	config.Producer.Compression = sarama.CompressionSnappy   // Compress messages
	config.Producer.Flush.Frequency = 500 * time.Millisecond // Flush batches every 500ms
	config.Producer.Partitioner = sarama.NewRandomPartitioner
	config.Producer.Return.Successes = true
	config.Producer.Return.Errors = true
	config.Version = sarama.V2_0_0_0

	producer, err = sarama.NewAsyncProducer(brokerList, config)
	if err != nil {
		log.Fatalln("Failed to start Sarama producer:", err)
	}

	go func() {
		for err := range producer.Errors() {
			log.Println("Failed to write access log entry:", err)
		}
	}()
}

func Tinput() {
	if producer == nil {
		log.Println("producer is nil.")
		return
	}
	producer.Input() <- &sarama.ProducerMessage{Topic: "test", Key: nil, Value: sarama.StringEncoder("test content")}
}

It will return Failed to write access log entry: kafka: Failed to produce message to topic test: dial tcp: lookup iZj4vv43r7jo5rwvxbq48yZ: no such host when I call Tinput after init.
What should I do to solve this problem?

check the advertised.host.name configuration item of your Kafka server


add PO option to A6.1 question

 [QAE18IMP] As an applicant, I want two new questions in section A asking if I have applied before, so that Assessors can easily access this information (6)


Performance Analysis

How this is slower than standard streams?
How this is slower than HTTP?
We just need some numbers, and maybe some optimization tricks.

Agreed.

would you like to give it a spin? Send a PR with your bench scripts! :)
Il giorno gio 8 gen 2015 alle 12:30 heri16<EMAIL_ADDRESS>ha
scritto:

Agreed.
—
Reply to this email directly or view it on GitHub
https://github.com/GraftJS/jschan/issues/17#issuecomment-69167776.


merge package template from arlac77/npm-package-template

package.json

chore(scripts): update prepare@rollup -c from template
chore(engines): update<EMAIL_ADDRESS>from template

.travis.yml

chore(travis): merge from template .travis.yml

Coverage remained the same at 73.077% when pulling 2f3d320e609b2cc32cf6816ade4c11b30848c32d on template-sync-1 into 316adff2837f88b13de73dd8f2838e84b72b0192 on master.

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   68.18%   68.18%
=======================================
  Files           1        1
  Lines          22       22
=======================================
  Hits           15       15
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316adff...2f3d320. Read the comment docs.


all: Add CI job to check docs

Summary

The first commit should cause the CI to fail, it is just a test to verify that the current version fails to build

Checklist

[x] cargo fmt
[x] cargo clippy
[x] cargo test
[x] updated CHANGES.md

Also, disable nightly checks because apparently nightly clippy tends to be very pedantic and even throws errors on our dependencies. I think, we should disable nightly permanently now, it's just to tedious to handle.

@pentamassiv this PR fixes the dox feature of libpanel. If you want you can review it. Also, you might want to join the Relm4 organization so I can request reviews from you :)

Sure, I believe you have to invite me to it, right?


Smoke Test: Localization tests are broken

Localization tests are broken since installing a localization extension doesn't render the Reload button any more.

The fix is to wait for the uninstall button instead.
Fixed by https://github.com/Microsoft/vscode/commit/c49207f9a3ad7fd77d0398f96b5b0348fd2d1221


[Enhancement] still use cte rewrite  when count distinct with limit

Fixes #issue
support use cte rewrite  when count distinct with limit, we add a session variable prefer_cte_reuse_rewrite, when it set to true, will use cte reuse to rewrite multi count distinct even with limit.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/RewriteMultiDistinctByCTERule.java
1
1
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/RewriteMultiDistinctByCTERule.java
1
1
100.00%
[]

@Mergifyio backport branch-3.1


Check type of a return value in unit test for each function

Some functions return numpy.ndarray of float64, which is not supported now. We need to check return values and fix functions when they return float64.

close #133 via #135


missing space in a pip install

small thing, but between install and --break there is a missing space in the Dockerfile. the deployment works wonderfully otherwise!
RUN echo "==> Adding pyvis ..."
&& pip install --break-system-packages pyvis

hey thanks!


main.py: error: argument -t/--tunnel: expected one argument

I simply cannot get it to work on colab using cloudflare, and if i use localtunnel, it gives me "not found" error

It happens, it doesn't always create a tunnel, try running it a few times with Cloudflare


Breakpoint on first line is not hit

New Python application
print('hello world')
print('hello world')

Put breakpoint on line 1 and start debugging.
Result: no break
Put breakpoint on line 2 and start debugging.
Result: break on line 2
~9 tests in DebugProjectUITests are failing due to this.

The behavior above is when you have "Enable debugging of the Python standard library" enabled.
When you disable debugging standard library, it will break, but not on the first line, it's in the "Break Mode" page instead of the breakpoint line. You can press F5 to continue but it never gets to execute the first print statement, it's just frozen there.

Bug was introduced in https://github.com/Microsoft/PTVS/pull/3255/commits/9a27fb8f144e39c1be74d0da8034072c5616b679


Change TPMS_QUOTE_INFO to quoted field and add device-side auth failure test

Reference PRs for context: https://github.com/openconfig/attestz/pull/21 and https://github.com/openconfig/attestz/pull/10.

Pull Request Functional Test Report for #2651 / d702cdb79ee11368c07a00ef9fbbc1c6594e0468
No tests identified for validation.
Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.281%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1673

Relevant Lines:
3200

💛  - Coveralls


Add fancier barrel explosion

also fix layer of soda cans so they are affected by explosions too!
and this updates the look of the energy cannon projectile, but the explosion should look different so I haven't done anything with that

Looks so much nicer! I really enjoy the new toony look

Thanks! I'm thinking of iterating on it later but I'll squeeze it in now


Add MASS

Microsoft's MASS  is a pre-training/fine-tuning approach to language generation tasks including MT. As such, it seems like a great candidate for inclusion in fairseq.
This is made easier because MASS's repo contains a fairseq implementation and has a permissible license for inclusion in fairseq proper.

I'm not sure I see the benefit of moving this in to fairseq proper.  What's wrong with just using MASS-fairseq?  If fairseq is a dependency, you should have everything you need, no?

Closing due to inactivity.


Maestro version 1.35.0 - Request for viewHierarchy failed

Describe the bug
App crashes randomly.
Error: Request for viewHierarchy failed, because of unknown reason, body: {"errorMessage":"Application com.app.id is not running","code":"internal"}
To Reproduce
This is random bug.
Expected behavior
No crash.
Environment information (please complete the following information):

Maestro version: 1.35.0
Platform: iOS 17
Framework: React Native
Device model and OS version: iPhone 15 Pro simulator
Host: MacOS Virtual Env

Bugreport output (if applicable)
[INFO ] m.cli.runner.TestSuiteInteractor - Launch app "${APP_ID}" RUNNING
[INFO ] util.CommandLineUtils - Running command line operation: [/Users/admin/.maestro/deps/applesimutils, --byId, 9B082E80-F33F-4B7C-9C6A-093D24E1AB90, --bundle, com.app.id, --setPermissions, calendar=YES,camera=YES,contacts=YES,faceid=YES,homekit=YES,medialibrary=YES,microphone=YES,motion=YES,photos=YES,reminders=YES,siri=YES,speech=YES,userTracking=YES]
[INFO ] util.CommandLineUtils - Running command line operation: [xcrun, simctl, privacy, 9B082E80-F33F-4B7C-9C6A-093D24E1AB90, grant, location-always, com.app.id]
[INFO ] maestro.Maestro - Launching app com.app.id
[INFO ] util.CommandLineUtils - Running command line operation: [xcrun, simctl, spawn, 9B082E80-F33F-4B7C-9C6A-093D24E1AB90, launchctl, setenv, MAESTRO_SESSION_ID, c27d1372-0020-4eba-8f08-78ce8a69fd2f]
[INFO ] util.CommandLineUtils - Running command line operation: [xcrun, simctl, launch, 9B082E80-F33F-4B7C-9C6A-093D24E1AB90, com.app.id]
[INFO ] m.cli.runner.TestSuiteInteractor - Launch app "${APP_ID}" COMPLETED
[INFO ] m.cli.runner.TestSuiteInteractor - Start recording ./e2e/logout RUNNING
[INFO ] maestro.Maestro - Starting screen recording
[INFO ] m.cli.runner.TestSuiteInteractor - Start recording ./e2e/logout COMPLETED
[INFO ] m.cli.runner.TestSuiteInteractor - Tap on "Button" RUNNING
[INFO ] ios.IOSDevice - Requesting view hierarchy of the screen
[ERROR] xcuitest.XCTestDriverClient - Request for viewHierarchy failed, because of unknown reason, body: {"errorMessage":"Application com.app.id is not running","code":"internal"}
[INFO ] m.cli.runner.TestSuiteInteractor - Tap on "Button" FAILED
[INFO ] maestro.Maestro - Taking screenshot: /var/folders/2f/3sd99gzd12g01qxs44n328qc0000gn/T/screenshot-170610987578817891252654129277383.png
[INFO ] maestro.utils.ScreenshotUtils - Taking screenshot to output sink
[INFO ] maestro.Maestro - Stopping screen recording

I too faced this issue very recently when introducing maestro to our project here -> https://github.com/status-im/status-mobile/pull/18712
This was fixed for me after I restarted my iOS simulator.
I don't have any other useful logs to share at the moment.

@siddarthkay It happens randomly. It's a shame that this tool doesn't support retries. I had to manually implement the retry in the test step and now it's almost stable.


Missmatch translational allowedDeviation between order topic documentation and schema

The documentation states that a nodePosition may specify an optional property allowedDeviationXY

whereas the order schema refers to allowedDeviationXy
https://github.com/VDA5050/VDA5050/blob/main/json_schemas/order.schema
Since the schema permits additional properties, the schema check succeeds on receiving an order containing a node with allowedDeviationXY, but this value is not associated with  allowedDeviationXy in the subsequent operations, i.e.,  json.contains("allowedDeviationXy") will fail as if no deviation was provided by the order.
This may lead to Fleet Management Sytems that follow either the documentation or schema specification and thus inconsistencies within the communication.

Yes, differences between the document and the schemas are not nice. Normally the PDF document defines the truth and with the version 2.1 it is additional mentioned inside the document: "If there are differences between the JSON schemas and this document, the variant in this document applies."


Error Handling

As it stands, when the system runs into an error it just crashes. We need some decent crash reporting at least to the user so that when an error is encountered it can be reported here or elsewhere.

Closing for now. There's some more work to be done here but the major errors are handled.


Add Prettier with Git pre-commit hook

We should Add Prettier with a Git pre-commit hook to force consistency in the repo.

merged


Support allow_paths in foundry.toml

This issue was raised on discord: https://discord.com/channels/750408878008827925/951537942239797338/1101880603701420083
A cli run of forge gives no errors but it fails in the vscode extension with the following setup:

I suspect this is that the Foundry adapter is not reading and using allow_paths.

The issue here was our processing of remappings rather than allow_paths, we now deal better with absolute paths in this case.


chore: add support for islcapenables api

There are multiple problems with this with this PR:

Removing an API ('getParameter') is a Breaking Change (Major Version) not a minor version change.

https://github.com/SAP/app-studio-toolkit/pull/90/files#diff-99210edf83ca3c5dffc806ab8d5329433ef0faf703ec68d4cc59f000f6e82091R3

The usage of 'getParameter' was not removed from the example, thus it currently fails compilation.

https://github.com/SAP/app-studio-toolkit/blob/6027b6e65a0f953bd9d1d2de91e1e94c5086f3cb/sample-action-client/src/extension.ts#L73

Commenting out a line of code is not a valid manner in which to remove a function from a public API.

https://github.com/SAP/app-studio-toolkit/blob/6027b6e65a0f953bd9d1d2de91e1e94c5086f3cb/types/api.d.ts#L28-L37

This PR is a feat not a chore and the commit message includes redundant dev process info

See:

I am in the middle of a large unrelated refactor in this repo to a mono-repo, please do not push any new commits
to resolve these issues, I will handle it after the refactor.


[Bug]: processes aren't killed after exiting recording

Describe the bug
Upon exiting recording:
/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 32 leaked semaphore objects to clean up at shutdown

To Reproduce
python -m openadapt.record
...
<ctrl>+c
TODO: figure out more precise steps to reproduce

@abrichr
When you have a moment, please share additional info on how to reproduce.

I was unable to fix this bug, however, I did notice a couple things

event_q is the only queue that is not empty at the end of the record function
as noted in queue.py's docstrings for qsize and empty, race conditions may cause those functions to be inaccurate so we could use Queue.join() to ensure the queue is empty

Queue.join() blocks until all items in the Queue have been gotten and processed and requires Queue.task_done() to be called after getting each item in the queue

even after ensuring event_q is empty, there were still the same number of leaked semaphores (40 in my case)
changing the maxsize of the queues to 1, 3, 1000, and 100 also didn't help

CI is succeeding but pytest locally fails (M2):
E         2024-11-11 20:46:30.326 | INFO     | openadapt.error_reporting:configure_error_reporting:28 - is_reporting_branch=True
E         INFO  [alembic.runtime.migration] Context impl SQLiteImpl.
E         INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
E         /opt/homebrew/Cellar/python@3.10/3.10.14_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 20 leaked semaphore objects to clean up at shutdown
E           warnings.warn('resource_tracker: There appear to be %d 'wn
E
E       assert -1 == 0