Can refute_graph() check independences that are not conditional?

Seems like refute_graph() can only detect conditional independences, but can it also check independencies without variables to condition on? If not, is there a method call that can automatically check these independent relationships accurately and without having to check them for manually?
I've tried to test refute_graph() with a sample DAG that should check for one implied independence relationship. I've drawn two variables, node a and node b, that act as confounders between node T and node O. These confounders are also independent of each other. The same implied independent relationship can be found through daggity by changing digraph to dag in causal_graph variable
import pandas as pd
import dowhy
import random

z=[i for i in range(50,60)]
random.shuffle(z)
df = pd.DataFrame(data={'a':z,
                        'b':z,
                        'T':  [random.randint(0,1) for i in range(10)],
                        'O':  [random.randint(0,1) for i in range(10)]

})

causal_graph = """digraph {
a
b
T [exposure]
O [outcome]
T -> O
a -> O
a -> T
b -> O
b -> T
}

model= dowhy.CausalModel(
        data = df,
        graph=causal_graph,
        treatment="T",
        outcome='O')

refuter_object = model.refute_graph(k=1, independence_test = {'test_for_continuous': 'partial_correlation',
'test_for_discrete' : 'conditional_mutual_information'})
print(refuter_object)`

The output from above shows that the refute_graph() does not test any relationships, which is not correct as it should detect the independent relationship between node a and node b. (I would like to also plug another issue where this only works if the variables are single letters, otherwise it results in the error in issue #949)
Method name for discrete data:conditional_mutual_information
Method name for continuous data:partial_correlation
Number of conditional independencies entailed by model:0
Number of independences satisfied by data:0
Test passed:True

However, when I explicitly check for this relationship, it does test the one relationship but it should not pass the test since I've made both node a and node b perfectly correlated.
refuter_object = model.refute_graph(k=4, independence_constraints=[('a','b', ())],
                   independence_test = {'test_for_continuous': 'partial_correlation', 'test_for_discrete' : 'conditional_mutual_information'})
print(refuter_object)

Method name for discrete data:conditional_mutual_information
Method name for continuous data:partial_correlation
Number of conditional independencies entailed by model:1
Number of independences satisfied by data:1
Test passed:True

Version information:

DoWhy version 0.9.1

Hey, you might want to check out: https://www.pywhy.org/dowhy/main/example_notebooks/gcm_falsify_dag.html
It was just recently added, i.e., you would need to install the mainline version. But it will be part of the next release.

thanks @bloebp this looks very interesting

@bloebp looks promising. Can this feature be used without using gcm()? what about with econML estimators?

It is based on performing multiple independence tests, i.e., you don't really need an estimator, just the graph structure and data. You would need the gcm module, but only the part for this algorithm (so, no need to define it as an SCM etc.).


[BUG]: Authorization doesn't provide a CLI to list RoleBindings

Bug Description
After assigning a role to a tenant using karavictl, there is no other CLI to list the role bindings. A CLI to list all role bindings or list by tenant or role should be available.
Logs
n/a
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce

Create rolebinding using karavictl
No other CLI available to list the rolebindings

Expected Behavior
There should be a CLI to list rolebindings
CSM Driver(s)
n/a
Installation Type
No response
Container Storage Modules Enabled
Authorization
Container Orchestrator
n/a
Operating System
RHEL 7.9

Thank you for your submission @tdawe. The team will triage and update with next steps.

After review, the karavictl tenant get CLI will also display any roles that are associated with the given tenant.


remove go get for bindata and rely on Makefile bootstrap target used …

…in generate
Fixes #3032
The bootstrap target of the Makefile already contains a get for go-bindata, we do not need to add anything there.  However, it is fetching github.com/jteeuwen/go-bindata which appears to be unmaintained.  Issue #3072
ifndef HAS_GOBINDATA
	go get github.com/jteeuwen/go-bindata/...
endif

@jim-minter

/cc @kargakis

/label orchestrator/openshift

need to change pkg/openshift/certgen/release39/templates/templates.go as well

dang it, had that in my search window and forgot to do it.  Thanks for catching.  Updated

/assign @jim-minter

/approve

/lgtm

/label orchestrator/openshift


main.js isn't linked?

Hi - love the boilerplate.  I'm just having one issue -  I've downloaded the boilerplate and put this code in main.js, but when I fire up the server and go to the home page, nothing console.log's.  Why is this?  I'd like to use main.js if possible, but it seems like it's not linked correctly.
$(document).ready(function() {

	console.log("HOLLA!");

});

Quick question, where are you looking for the output of the console.log and it is missing?  main.js is for the client side JavaScript.

i've also put code in that location and nothing fires. Infact I notice that the file downloaded from the server does not have the new code in it.

The issue might be that your browser is loading the file from cache, try Shift + F5 or right-click the reload icon with Dev Tools open and do a hard reload with cache clear.


Content - Add a section about "migrating your product to Carbon"

Based on feedback from the last playback with Phil.
He suggested that we have a clearly defined section in our navigation, calling out specifically the journey of a non-Carbon product moving to a Carbon UI.
Broadly this seems like a good idea - there are multiple legacy products that have existing interfaces and back-ends that are not "greenfield" development when looking to adopt Carbon. Can we speak directly to that journey?

The upcoming case studies will offer insights into how products can migrate.


feat: Create SCC WP Agent DA

Description
Create SCC Workload Protection Agent DA

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ X] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

closing this one, we have new PR for it https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/pull/91


Nick: Watch snapcopy.app

Nick requests the watch of the watch_keyword snapcopy\.app. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

snapcopy\.app has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


[#14] Fix publishing branch from master to main

Closes #14

What happened

Update publishing branch from master to main

// For testing copilot:poem
copilot:poem
Insight
N/A
// For testing copilot:walkthrough
copilot:walkthrough
Proof Of Work
N/A

The Insight and POW seems weird 🤔

The Insight and POW seem weird 🤔

We're configured copilot4pr, but we are still on the waiting list. Please update the PR @lydiasama  👍

The issue is not from the publishing branch, as discussed in this thread.


Permissions required

Hi! I set this up today after having trouble comparing backup versions.
Looks nice, but it requires a admin user. Can this be changed? Read permissions should be enough, since I restore the file myself right?

Hello @enduring78 for the user being able to view/compare/download and take instant backups, the required user level is Backup operator (just one level higher than view only).
This user level cannot change any other configuration.

Ah ok, now I understand.
If the routeros requires admin privilege, there's not much that I can do here.
Routerfleet needs to connect using ssh and execute the scp for fetching the files.
The user that you are creating, need to be able to execute those steps on the router.
I will be closing this issue, since it's not an issue on routerfleet side.


use static JSON caches from CRIC

By default use static JSON caches from CRIC instead of dynamic query for PandaQueues and DDMEndpoints.
unless custom urls are explicitly specified in the pilot config file
updates: few optimization applied to retrieve only corresponding JSON data for required PQ in case of single PQ request by pilot.info

Thanks


taler-depolymerization: init at 0-unstable-2024-06-17

Description of changes
Taler depolymerization is an implementation of the Taler wire gateway over the Bitcoin and Ethereum blockchains.
Packaged under the Summer of Nix effort.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 342595 run on x86_64-linux 1

2 packages built:

taler-depolymerization
taler-depolymerization.doc


Creating assignment model and specs

The goal of this PR is to create the assignment model with its corresponding tests.

Coverage increased (+0.04%) to 94.393% when pulling 84984c72df94c74702ce49666d03d23028674be4 on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

Coverage decreased (-1.5%) to 92.901% when pulling a1d214f785027983e1c1fab0e6b08d56f96117d6 on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

Coverage increased (+0.1%) to 94.462% when pulling f467181090d09626fca67184f0b43a0fd24dca1a on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

Coverage increased (+0.1%) to 94.462% when pulling 90df097e7d6f1a4457d3ce3fb39ffc733a40fe72 on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

@sergio-ocon  Ready to review

Coverage increased (+0.1%) to 94.479% when pulling dc38f104815464e710316aadcabf873997e2e581 on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

Coverage increased (+0.1%) to 94.479% when pulling fc93c017b4ca0c48a02ceb4614cd6f11f94b1f41 on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

@sergio-ocon Ready to review

Coverage increased (+0.1%) to 94.479% when pulling 600ba757539c43f8abfcf1ed96b2633c4bc652de on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

@sergio-ocon Ready to review

Coverage increased (+0.2%) to 94.512% when pulling b83f2529764321f773dec82d80875d04c6db0192 on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.

@sergio-ocon Ready to review

Coverage increased (+0.1%) to 94.479% when pulling b578d5e7717bd293936a76c2625a3ac47c10d575 on sebjimenez:add_offs_shifts into c844a2bfc33c406aae06ba770563d82995fe6eaf on propedeutica:master.


How should we accept our program arguments?

Spawned from https://github.com/fusor/cpma/pull/128#issuecomment-491564445
Reading up some more about cobra, I think I was wrong regarding the above comment, where I stated that we shouldn't have multiple cmd files. It makes sense to me for each command, we should have a different cmd/X file (if we have a tool with different commands, ex: cpma report, cpma transform).
Firstly, do we prefer to accept the output passed as a command vs. an option? Ex:

Command: cpma report X
Argument: cpma --output-type={report,transform}, defaulting to transform?

The first would result in a bunch of cmd/COMMAND.go files, and they would also share command line args, like output directory. So does that really make sense over the argument approach?
For maintainability reasons, I like the argument approach. It means we have a single entrypoint. If we think the UX of a command approach is the right choice, then multiple files totally make sense under cmd/COMMAND.go.
On top of all this, if we choose to go the command route, what does just cpma $OPTIONS do? Just list the help? Default to transform?
@jwmatthews curious about your thoughts on this because you stated you liked the command approach. If I had to choose, I like the argument approach because of its maintainability. Admittedly, the command approach is much closer to what oc and kubectl do today, so I could see that as a point in its favor.

I think it depends on the number of "commands" you will need and whether they have a complex list of options to override their functionality.
cpma --output-type=report is easy enough but if it needs like 5 options to be useful, I'd start looking at making them subcommands instead of options.
If you only have 2 I'd say options only. If you plan on growing more than 2 or 3 you might want to go the sub command route with their own options. You really need to decide that early because that could totally dictate your direction.

I also read afterward @jmontleon pointers to cobra recommendations, so it makes sense.
From that I agree with @jmrodri, too many options would be too heavy in which case the command approach would be better so the question is where do we place the "critical mass" of the number of  options?

Spawned from #128 (comment)
Reading up some more about cobra, I think I was wrong regarding the above comment, where I stated that we shouldn't have multiple cmd files. It makes sense to me for each command, we should have a different cmd/X file (if we have a tool with different commands, ex: cpma report, cpma transform).
Firstly, do we prefer to accept the output passed as a command vs. an option? Ex:

Command: cpma report X
Argument: cpma --output-type={report,transform}, defaulting to transform?

I prefer 'cpma report' and 'cpma transform'
-1 on cpma --output-type={report,transform}

The first would result in a bunch of cmd/COMMAND.go files, and they would also share command line args, like output directory. So does that really make sense over the argument approach?
For maintainability reasons, I like the argument approach. It means we have a single entrypoint. If we think the UX of a command approach is the right choice, then multiple files totally make sense under cmd/COMMAND.go.
On top of all this, if we choose to go the command route, what does just cpma $OPTIONS do? Just list the help? Default to transform?

Default to help

@jwmatthews curious about your thoughts on this because you stated you liked the command approach. If I had to choose, I like the argument approach because of its maintainability. Admittedly, the command approach is much closer to what oc and kubectl do today, so I could see that as a point in its favor.

I think we can close this one based on recent progress with app.Start and https://github.com/fusor/cpma/issues/114.
The thing I was concerned about was having N different entrypoints that had significant logic in them. I think that is addressed with the push to consolidate the major initial logic to app.Start, and to call that from each cmd/X.go file. These files should be concerned with dealing with the specifics of that particular command, and handing off those details to app.Start.


Preload/scrolling fixes

@soutarm :eyes:
can you please look over the changes to get us up to date!

LGTM


signed int segmentation

Are signed ints supported for segmentation?  I do not see any errors when I try to load them, but they are not visualizing properly.  The data loads, but the display is simply a grey box.  If I mouse over the pixels, the values do appear.  Is there some extra setting I might need?
As a positive controls, I used a small 2x2x2 volume and I verified that uint64, uint32, uint16 all work.
I have verified that int32 and int16 show these symptoms.  I am using the current HEAD of the repo for my viewer, and tried both Chrome 91 and Firefox 89 on MacOS 11.4.

Assuming there are no negative values, you can also just change the n5 or zarr data type to uint32 in the metadata file --- no need to actually rewrite the data.

I'm using precomputed format.  Would a metadata switch work for it as well?

Yes, that will work for precomputed format as well.

Just encountered this issue as well - while it's trivial workaround, debugging can take a while, as there is no error message provided, and the values are identical to those in segmentations that work.
I assume it would be rather trivial to add either an error message, or convert to unsigned integers (especially since changing the data type works)? If so, I can't think of a good reason not to add this.


Hide NFC button if device does not support NFC

This PR resolves issue #907 . We want to hide the NFC button if the device does not support NFC in the lnurlp, lnurlw, and tpos extensions.

Disable and a "This device does not support NFC" tooltip is better as people then still now its possible

We had a big long discussion with some merchants and decided its better to have the nfc button present, so it helps guide people to a browser that does work


Tune Shark V3 Extension (Sound Extension with Audio Effects (poggers))

Tune Shark V3 The most Powerful Audio Extension out there!
-Play Sounds
-Apply Effects
-Get Loudness Output
-And More!!!

Note to Garbo Keep the Name as Tune Shark V2 (Legacy) Is Still Public for Support Reasons, Avoid Confusion :)

ERROR:
When I try to use the block , an error is displayed in the console:

ERROR:
When I try to use the block , an error is displayed in the console:

Weird. Scratch default sounds just do not like being added

@DDen4ik-12  Fixed. Its a problem with scratch, the only fix is to edit the scratch sound in some way before importing. Example: changing the pitch back and forth

can you also add blocks that can detect the loudness of the sound? that would been great for music visualizers

can you also add blocks that can detect the loudness of the sound? that would been great for music visualizers

already exists:

Added 2 New Effects

New Audio Effect

new update:

New Audio Effect


 This is a just a special coordinator, you use it in your layouts as any other view. Put this inside another CoordinatorLayout, and it will act as a bottom sheet.
<CoordinatorLayout>

    <!-- Main content... -->

    <!-- Bottom sheet -->
    <BottomSheetCoordinatorLayout>
        <!-- Bottom sheet content, including AppBarLayouts or whatever -->
    </BottomSheetCoordinatorLayout>
</CoordinatorLayout>

I want Gif to run above Demo ,  But I downloaded only layout.

The gif you see in the main page uses external components for altering positions, pinning views etc. that are not part of the library right now. I will consider adding these in the future.

Ok,Thank you for your reply

hello mate, can you post your example of the demo here
i mean the layout behavior params and etc.

@JenyaKirmiza sorry, I will remove that gif since it shows things that are not supported by the library yet. I’ll work on a sample app and update this issue

i've created a pull request #7 for a demo with latest androidx migration


local exllamav2 (TabbyAPI) KeyError: 'stop'

Thanks for sharing the project! The interrupt feature is really impressive! :)
I'm getting an error on Ubuntu 22.04 when trying a different backend, with a fresh install of tabbyAPI:
whisper_init_state: compute buffer (decode) =   98.31 MB
2024-05-15 21:25:31.326 | SUCCESS  | __main__:__init__:139 - TTS text: All neural network modules are now loaded. No network access detected. How very annoying. System Operational.
2024-05-15 21:25:31.344 | SUCCESS  | __main__:start_listen_event_loop:191 - Audio Modules Operational
2024-05-15 21:25:31.344 | SUCCESS  | __main__:start_listen_event_loop:192 - Listening...
2024-05-15 21:25:55.877 | SUCCESS  | __main__:_process_detected_audio:291 - ASR text: 'Please tell me a joke.'
Exception in thread Thread-1 (process_LLM):
Traceback (most recent call last):
  File "/home/user/miniconda3/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
    self.run()
  File "/home/user/miniconda3/lib/python3.11/threading.py", line 975, in run
    self._target(*self._args, **self._kwargs)
  File "/home/user/projects/GlaDOS/glados.py", line 486, in process_LLM
    next_token = self._process_line(line)
                 ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/projects/GlaDOS/glados.py", line 523, in _process_line
    if not line["stop"]:
           ~~~~^^^^^^^^
KeyError: 'stop'

Hmmm, I'll try using tabbyAPI to replicate the bug.

I am getting the same thing with LM Studio running locally however I wonder if it has to do with the template.

Same here with LM Studio, Problem is that it uses "finish_reason":null and "finish_reason":"stop" instead of "stop":false

I had to modify process_LLM to the following to get it to work (mind you I added debug statements and I am pretty sure you can remove a lot of if statements in there for the next_token haha:
`    def process_LLM(self):
"""
Processes the detected text using the LLM model.
    """
    while not self.shutdown_event.is_set():
        try:
            detected_text = self.llm_queue.get(timeout=0.1)

            self.messages.append({"role": "user", "content": detected_text})
            filtered_msg = [msg for msg in self.messages if msg['content'].strip()]
            prompt = self.template.render(
                messages=filtered_msg,
                bos_token="<|begin_of_text|>",
                add_generation_prompt=True,
            )

            logger.debug(f"{prompt=}")
            filtered_msg = [msg for msg in self.messages if msg['content'].strip()]
            data = {
                "model": "QuantFactory/Meta-Llama-3-70B-Instruct-GGUF",
                "stream": True,
                "messages": filtered_msg,
                "temperature": 0.7,
                "max_tokens": -1
            }
            logger.debug(f"starting request on {filtered_msg=}")
            logger.debug("Performing request to LLM server...")

            # Perform the request and process the stream
            completion = client.chat.completions.create(
                model="QuantFactory/Meta-Llama-3-70B-Instruct-GGUF",
                messages=filtered_msg,
                temperature=0.7,
                stream=True,
            )
            sentence = []
            for chunk in completion:
                if self.processing is False:
                    break # If the stop flag is set from new voice input, halt processing
                if chunk.choices[0].delta.content:
                    line = chunk.choices[0].delta.content
                    if line:  # Filter out empty keep-alive new lines
                        #line = self._clean_raw_bytes(line)
                        next_token = line
                        if next_token:
                            sentence.append(next_token)
                            # If there is a pause token, send the sentence to the TTS queue
                            if next_token in [
                                ".",
                                "!",
                                "?",
                                ":",
                                ";",
                                "?!",
                                "\n",
                                "\n\n",
                            ]:
                                self._process_sentence(sentence)
                                sentence = []
                            #if self.processing:
                            #    if sentence:
                                #       self._process_sentence(sentence)
                            self.tts_queue.put("<EOS>")  # Add end of stream token to the queue

        except queue.Empty:
            time.sleep(PAUSE_TIME)`

chat_output (2).txt
used claude to fix my issue.
def _process_line(self, line):
    """
    Processes a single line of text from the LLM server.

    Args:
        line (dict): The line of text from the LLM server.
    """

    if 'choices' in line and line['choices']:
        token = line['choices'][0]['text']
        return token
    return None


Check for missing pointers in generated resources structure for aws provider

Description
Missing pointer on generated resource field can lead to a crash, like this: #375
Possible Solution
Add pointers to every field of generated resource who need this, to avoid crash

Those generated resource will be removed in v0.8.0 and is not essential for the v0.7.1


API Response Error: text is expected to be rich_text

Hello,
I just started using both Notion and notero.
I am having an API Response Error: title is expected to be rich_text. How can I fix this error?
Thanks in advance.

Hi @ESCirit, were you able to figure out the issue?

I duplicated the “Basic Example Notion Database” again and followed setup steps from beginning. This way the problem solved.
But I still don’t know what is the problem in the beginning actually :)

@ESCirit, to be honest, I'm not sure what the problem was either. I don't think I've seen that specific error message before.
I'm glad you were able to resolve it!


Nov 2nd 2021 - Regulation Innovation SIG Meeting Minutes

Regulation Innovation SIG
Date
Nov 2nd 2021 - 12pm EST / 4pm GMT
Untracked attendees

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[x] Convene & roll call (5mins)
[x] Display FINOS Antitrust Policy summary slide
[x] Review Meeting Notices (see above)
[x] Approve October 12th meeting minutes
[x] FINOS Open Source Strategy Forum New York, November 10th

Keynote session, Sultan Meghji, Chief Innovation Officer, FDIC & Jo Ann Barefoot, CEO & Cofounder, Alliance for Innovative Regulation

[x] https://github.com/finos/open-source-readiness/discussions/9 - Jane Gavronsky, FINOS
[ ] Collaboration opportunities to address policies and regulations around the software development lifecycle (SDLC). (Presented at a FINOS DevOps Mutualization Special Interest Group (SIG)) - Amol Shukla (@ashukla13), Morgan Stanley - 15 minutes

Many banks are investigating or implementing hands-free change deployment while still demonstrating conformance with regulatory controls and internal policies. The Automated Change Deployment working group has been setup to document how different FINOS member banks are enabling automated change deployment.
The FINOS DevOps Mutualization Special Interest Group welcomes the opportunity to collaborate with the Regulation Innovation SIG in opening a dialogue with the regulators during the creation and once the document has taken shape.

[ ] Morphir as a tool to enable machine-readable regulation (Attila Mihaly, Morgan Stanley; Stephen Goldbaum, Morgan Stanley; Francois-Xavier Houard, SUSE; Richard Wagener, Codethink) - 15 minutes
[ ] Reg Taxonomy project update (James Nicholls, Braithwate) - 5 minutes

Invitation to join the November 16th ad-hoc meeting to discuss the Reg Taxonomy project proposal. Meeting details available at https://github.com/finos/open-regtech-sig/issues/37

[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

WebEx info

Meeting link: https://finos.webex.com/finos/j.php?MTID=m6be3cd5cdc56622e15e74fbd30e7253c
Meeting number:<PHONE_NUMBER>
Password: d9kKJPdX5C9
More ways to join:

Join by video system: Dial<EMAIL_ADDRESS>You can also dial <IP_ADDRESS> and enter your meeting number.
Join by phone: +1-415-655-0003 US Toll | +44-20319-88141 UK Toll | Access code:<PHONE_NUMBER>

Hello 👋🏻

Richard Wagener / Codethink

Jane Gavronsky / FINOS

Ashley Nelle-Davis / Data Foundation

Matt Van Buskirk - Hummingbird

Stephen Goldbaum - Morgan Stanley

Amol Shukla - Morgan Stanley

David Ehrich - AIR (Alliance for Innovative Regulation)


Update of Shared Services for R24.5 (DiscoveryFinder, Portal Services, EDC DiscoveryService )

As product
I want update to shared services to version aligned with R24.5
so that irs product dependencies to shared services aligned with R24.5
Link

child of https://github.com/eclipse-tractusx/sig-release/issues/446

Hints / Details

...

Acceptance Criteria

[ ] IRS uses latest stable version of DiscoveryFinder in R24.5 https://github.com/eclipse-tractusx/sldt-discovery-finder/releases/tag/discoveryfinder-0.2.4-RC1
[ ] IRS uses latest stable version of Portal Services in R24.5 https://github.com/eclipse-tractusx/portal/releases/tag/portal-1.8.0
[ ] IRS uses latest stable version of Semantic Hub in R24.5 https://github.com/eclipse-tractusx/sldt-semantic-hub/releases/tag/semantic-hub-0.2.1-RC3
[ ] IRS uses latest stable version of EDC DiscoveryService in R24.5 https://github.com/eclipse-tractusx/portal-assets/releases/tag/v1.8.0
[ ] Check the wiremocks are compatible to the new api changes
[ ] Update the COMPATIBILITY matrix

Out of Scope

...

@jzbmw  BLOCKED was removed as the updates are available now.

Planning 2:

Check the changelogs of the services for changes which would introduce incompatibility
Verify that the DEV wiremock for the discovery Services are still up-to-date


make ontology work with any kind of parental relationships

makes it much slower if one chooses something like "part_of" for certain kinds of ontologies (90mns for "part_of" on all tissues)

Thank you for this PR @jkobject ! Just that it won't have an effect yet for users who want customized parsing, since we pull the reference parquet files from the s3.
To enable user to define their own relationship types, we need to either enable a local mode for the reference files (the risk is that users won't be able to get new references automatically when it's updated); or we figure something out specifically for lamindb.
@Zethson @falexwolf how do you think we should go about this?

I am not sure I understand what you mean but on my end doing: bt.Tissue.public().pronto().to_df(include_rel ="part_of") seems to work

I am not sure I understand what you mean but on my end doing: bt.Tissue.public().pronto().to_df(include_rel ="part_of") seems to work

Yes, this works, but it won't work for canonical accessors such as .from_public() or .from_values() or public.df().
Does accessing the df with pronto().to_df(...) alone already meet what you need?

I might be able to rewrite my code but right now it is true that I am using bt.Tissue.filter().df(include=["parents__ontology_id"]) and it wouldn't work for this..

@jkobject thank you for the PR and sorry for chipping in so late. I think I accidentally deleted the Github notification email.
So we could of course upload monstrous .parquet files to our S3 that include all relationships, but this will probably greatly increase the download and parsing times.  Maybe there'd be a way to provide partial reading support for a subset of columns of the parquet file then if we store things appropriately.
I'd probably suggest a solution that involves lamindb?


Final changes

#87
#66

Codecov Report

Merging #92 (3f69335) into master (1edf2ce) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3f69335 differs from pull request most recent head 11fd02f. Consider uploading reports for the commit 11fd02f to get more accurate results

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   59.38%   59.38%
=======================================
  Files          16       16
  Lines         522      522
  Branches       55       55
=======================================
  Hits          310      310
  Misses        196      196
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1edf2ce...11fd02f. Read the comment docs.


[Feature request]Add Bookmark feature to the milvus login modal

Describe the feature:
Add Bookmark feature to the Milvus login modal, so users need not go elsewhere and paste their IP every time they get logged out.
Describe a specific use case for the feature:
Refactor this login UI and enable users to click just one button to log in to their bookmarked Milvus IP.

Actually , with attu v2.2.2, when you log out, your ip will be kept in the address bar.  Please try it.


Add -hack-undef: Use OpConstantNull instead of OpUndef

Work around drive bug documented in https://github.com/google/clspv/issues/95

Tested on Release and Debug builds.
LGTM


repro: speedup bisection for flaky crashes

Limit the amount of bisection chunks to 8. Going over this value probably
means that we are bisection a flaky crash, and continuing bisection would
just take a lot of time and likely produce no result.

Codecov Report

Merging #1131 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage    67.1%   67.09%   -0.02%
==========================================
  Files         120      120
  Lines       20705    20719      +14
==========================================
+ Hits        13895    13902       +7
- Misses       6148     6155       +7
  Partials      662      662

Impacted Files
Coverage Δ

pkg/repro/repro.go
25.45% <100%> (+0.4%)
:arrow_up:

pkg/build/freebsd.go
0% <0%> (ø)
:arrow_up:

pkg/report/linux.go
79.21% <0%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e8efc...f851b95. Read the comment docs.


[Add a Play]: Tenzies Game

What's the Play about?
Tenzies Game using React.Js
What ReactJS concept will be used to create this play?
react
react-confetti
Image:

Are you willing to take it up for implementation?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@AbhiPatel10 Super!!
Get started. If you need any help, ping us on Discord #needs-help channel

Thanks a lot sir, this is my first contribution to reactplay I will give my 100%.


[Tracker] PT Run - System integration like control panel, settings or commands

This is the master tracking issue for system integration related ideas.
The tracker should collect ides on integrating control panel items, settings app items and commands.
Control Panel items / Settings App items

Issue #
Title

#3386
Add control panel applets to Powertoys run

#4133
Show windows settings in the search as well

System commands

Issue #
Title

#2408
[Launcher] Ability to execute system/OS commands like shutdown

#4037
PT Run does not find mmc

#3434
[Run] Support .msc file

For reference on #4133, this is what shows up when searching for some settings that'd be great to see also in PT Run:

closing this as a dup of others.  We already have one tracker.  I don't want to add complexity


Pass settings as parameters only in one of update/view

I'm not sure why we need to pass the settings in both the update and the view, this makes using the datepicker in different files annoying (files dealing with update and views all must import settings).

Right now I think it's just that the lib happens to group behavioral settings into one type! A quick scan of the code says most of the fields on Settings are really only used in one of update or view. I think that means we could split them into different types and pass them separately? Is that a good pattern for Elm widget libs that accept behavioral parameters?


Device Naming

Trying to keep this to one issue per post.
I have the prefix set in the folder and the unattend is set to the default:
<?xml version="1.0" encoding="utf-8"?>
<unattend xmlns="urn:schemas-microsoft-com:unattend">
  <settings pass="specialize">
    <component name="Microsoft-Windows-Shell-Setup" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS" xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
      <ComputerName>MyComputer</ComputerName>
    </component>
  </settings>
</unattend>

However, if I jump into audit mode from OOBE, it's giving me DESKTOP-%RANDOM% as the computer name. Did I miss a step? I rewatched the pertinent portion of your deep dive video and re-read the document and haven't been able to nail it down.

If you just let it boot like normal and at the OOBE screen hit shift+f10 and type hostname, is the name right?

No, it's still following the DESKTOP-%RANDOM% naming convention.

It forces me to specify a computer name, but I go into advanced once I have the wizard completed and remove the naming convention before finalizing the PPKG. Plus, I'm never actually making it to the point of the PPKG being processed.

Do you have more then one Prefix in your Prefixes.txt file?

It forces me to specify a computer name, but I go into advanced once I have the wizard completed and remove the naming convention before finalizing the PPKG.

Ok, this is what I was getting at. I do the same. Start the Wizard and then switch to Advanced to Delete the Computer name section.

Negative, just the one. We use just a single prefix in our environment (used to be 2 to reflect laptop vs desktop but simplified when we began trying to make Autopilot work).

Negative, just the one. We use just a single prefix in our environment (used to be 2 to reflect laptop vs desktop but simplified when we began trying to make Autopilot work).

To trouble shoot more, I'd either remove the prefixes.txt file all together or add more prefixes just for testing. It should either ask you to manually name the Device if no prefix found or you can select from a list.
The device Name should be written inside Unattend.xml.

I'll remove the prefixes folder and rebuild the iso and see what happens. In Unattend_x64.xml inside C:\FFUDeployment\unattend, the computer name is listed as MyComputer, as shown in Richard Balsley's deep dive video. If that should be changed, please advise, as I have changed the behavior of the PS1 script as he recommended on a previous issue. Here's the block from ApplyFFU.ps1:
    elseif ($UnattendPrefixCount -eq 1) {
    WriteLog "Found $UnattendPrefixCount Prefix"
    $PrefixToUse = $UnattendPrefixes[0]
    WriteLog "Will use $PrefixToUse as device name prefix"
    }
    #Get serial number to append. This can make names longer than 15 characters. Trim any leading or trailing whitespace
    $serial = (Get-CimInstance -ClassName win32_bios).SerialNumber.Trim().Substring(0, 8)
    #Combine prefix with serial
    $computername = ($PrefixToUse + $serial) -replace "\s","" # Remove spaces because windows does not support spaces in the computer names
    #If computername is longer than 15 characters, reduce to 15. Sysprep/unattend doesn't like ComputerName being longer than 15 characters even though Windows accepts it
    If ($computername.Length -gt 15){
       $computername = $computername.substring(0,15)

$serial = (Get-CimInstance -ClassName win32_bios).SerialNumber.Trim().Substring(0, 8)

I see you changed it 8 from the 7 you wanted. I do believe that Lenovo is already 8 for Serials , so it not needed. I use Lenovo exclusively now and we don't need to trim the serial number. We simply keep the Prefix, including the "-" to 7 characters so we come in under the required 15 limit for Hybrid Joined devices.
Also , the Unattend_x64.xml contects will be copied and renamed to "Unattend.xml" and placed in the folder for your Deploy media automatically.
The tricky thing with the XML is to have the correct Order and components listed correctly and not duplicated.
Heres an example of the
<unattend xmlns="urn:schemas-microsoft-com:unattend" xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State">
  <settings pass="specialize">
    <!--ComputerName must be in the first Component Element  -->
    <component name="Microsoft-Windows-Shell-Setup" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS" xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
      <ComputerName>MYCOMPUTER</ComputerName>
      <TimeZone>Eastern Standard Time</TimeZone>
    </component>
    <!-- Place additional Settings or Component Elements below here: -->
    <component name="Microsoft-Windows-Deployment" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS" xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
      <RunASynchronous>
        <RunASynchronousCommand wcm:action="add">
          <Order>1</Order>
          <Path>cmd.exe /c date 09-07-2024</Path>
          <Description>Set system date to a specific date</Description>
        </RunASynchronousCommand>
      </RunASynchronous>
    </component>
  </settings>
  <settings pass="oobeSystem">
    <component name="Microsoft-Windows-International-Core" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS">
      <InputLocale>0409:00000809</InputLocale>
      <SystemLocale>en-US</SystemLocale>
      <UILanguage>en-US</UILanguage>
      <UserLocale>en-US</UserLocale>
    </component>
    <component name="Microsoft-Windows-Shell-Setup" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS">
      <OOBE>
        <ProtectYourPC>3</ProtectYourPC>
        <HideEULAPage>true</HideEULAPage>
        <HideWirelessSetupInOOBE>false</HideWirelessSetupInOOBE>
      </OOBE>
    </component>
  </settings>
</unattend>

I ended up changing it to 8 to accommodate M$ Surfaces (they unfortunately do have long serial numbers), not Lenovo's as I previously thought. Thanks for sharing your unattend.

Thanks for sharing your unattend.

No problem, had done alot of trial and error on the xmls to get it working well . I am going to make a pull request to add a sample to share with others if it can help them.

I don't understand the need to set a substring after the Trim that's already done. Since Unattend doesn't support names being longer than 15 (even though Windows supports longer names), the script already truncates to 15 characters (the prefix + the serial).
So if I have a prefix of ABCD- and my serial is<PHONE_NUMBER>0111213, the name should be ABCD-1234567891. That's the whole point of the If statement.
If that's not happening, then there's a bug. Shouldn't be a need to adjust the number of characters taken from the serial number.

The way our environment is setup, they prefer a specific character length for the computer names for uniformity.
This is working now btw. Am closing the issue, thanks for all the help @HedgeComp @rbalsleyMSFT


std.uri: Add unittests for 100% code coverage.

squash and lets go.

@wilzbach sweet didn't know that. thanks


A way to ignore indexes on Prisma Schema

Problem
I need to add a foreign key referencing a table in another schema (MySQL). As Prisma doesn't support this natively I thought it would be simple to do it by creating an empty migration file and adding the DDL for FK creation. Turns out Prisma will try to drop the index after I run prisma migrate
Suggested solution
A directive to ignore already existing indexes on a model so Prisma doesn't try to drop them
Alternatives
I don't think there is a alternative for this

Keep a separated SQL migration for the production indexe's, views, etc.
The command that you run in prod to run the migrations prisma deploy will not look at database schema, only get an lock and load/update the _prisma_migration table

Sorry but this is not a good advice, maintenance nightmare.

You can use https://sqitch.org/ to manage the releases of the extra migrations.
I think you may be adding an unique index with a partial condition, or a custom op (eg: func(column_name)).
Prisma do not support the sintax to add this on the schema file, so they so far did implemented this feature. If a sintax is added for this, for example, I think they would add an new sintax to cover cases like table.findUnique() that would have this new index over.
Anyway, there's just a bunch of this requests already, they span diffrent years, so I just gave the way dealing with that.
--
Make it possible in Prisma Schema to mark an index as manually maintained, so Migrate doesn't try to drop/create it - https://github.com/prisma/prisma/issues/16658
Conditional uniqueness constraints; Partial/Filtered (Unique) Indexes - https://github.com/prisma/prisma/issues/6974
Support sparse unique indexes - https://github.com/prisma/prisma/issues/3419

In my case, it would be solved by implementing multischema for mysql too


Deactivate Business Entity codes

This is the technical implementation of the delete/deactivate feature.
Content updates may need a separate PR when terminology is agreed.
Replaces #561

Looks fine

A few small things, but overall it's nicely build on the previous PRs :+1:


chore: bump version to rc.3

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

post-merge utACK
(shall we tag and build?)


Flag --incompatible_config_setting_private_default_visibility will break Envoy in Bazel 7.0

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking Envoy. Please migrate to fix this and unblock the flip of this flag.
The flag is documented here: https://github.com/bazelbuild/bazel/issues/12933.
Please check the following CI builds for build and test results:

Ubuntu 20.04, OpenJDK 11
Ubuntu 20.04, OpenJDK 11

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

Hi, @keith could you take a look for this when you have free time? Thanks.

WIP here https://github.com/envoyproxy/envoy/pull/24237

The fix didn't get into downstream because https://buildkite.com/bazel/envoy/builds/2118#01849d85-5a46-4688-9dc4-2e30d6659b1b is failing and prevented the update of last green commit for Envoy.

https://github.com/envoyproxy/envoy/pull/24270

looking at the build failure, interesting that it's hit there but not on our CI, maybe a compiler version difference

the actual build failure is https://github.com/envoyproxy/envoy/issues/23891

We can keep track of this issue here: https://github.com/google/tcmalloc/issues/148

bumping the clang version for bazel CI here https://github.com/bazelbuild/continuous-integration/pull/1502

fixed by https://github.com/envoyproxy/envoy/pull/24296


no way to read heartbeat details from DescribeWorkflowExecution

if pending activity has heartbeat, the result from DescribeWorkflowExecution will include that heartbeat as blob. There is no way to decode that blob into actual object type.

client.NewValue() and NewValues() can be used to read this.
NewValue creates a new encoded.Value which can be used to decode binary data returned by Cadence.  For example:
User had Activity.RecordHeartbeat(ctx, "my-heartbeat") and then got response from calling Client.DescribeWorkflowExecution.
The response contains binary field PendingActivityInfo.HeartbeatDetails,
which can be decoded by using:
var result string // This need to be same type as the one passed to RecordHeartbeat
NewValue(data).Get(&result)


Crash in _glfwRefreshContextAttribs

Information:

Build version is from 2015/08/25
Tested with Power VR SDK and Google Angle
Window with EGL

I'm trying to make a version that use GLES 2.0 on Windows.
After tracing, context and a surface is ok.
But its crashing in _glfwRefreshContextAttribs.
The reason is that glfwGetProcAddress for glGetIntegerv/glGetString/glClear return NULL
I don't know why.
Sylvain.

On the latest : ba4504a9c7e053e688d201a22e4d37fcf93f9bca

This shouldn't have worked before either. GLFW only uses eglGetProcAddress, which does not return the addresses of core functions.
I've been working on a patch for this, as a companion to 7e13a4909e9ac0b4ae82b94cc31dcff93464b748. It'd be very helpful to know all the various file names for client libraries in the various SDKs you use, to make the dynamic loading more robust.

i'm working with PowerVR SDK 3.5
Libs used:
Path: PowerVR_SDK\SDK_3.5\Builds\Windows\x86_64\Lib
Files: libEGL.dll, libGLESv2.dll
Headers used:
Path: PowerVR_SDK\SDK_3.5\Builds\Include
Files: all files in this folders (EGL|GLES|GLES2|KHR)

Please try the dynamic-client branch.

I've tested with the sample heightmap.
i've just added this line to choose the appropriate GLES version:
glfwWindowHint(GLFW_CLIENT_API, GLFW_OPENGL_ES_API);
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 2);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 0);
and updated the shader to be compatible with GLES 2.0.
All works fine.
Thanks!

Excellent. Thank you for testing!


A gettext call containing placeholders was found ...

Morning all, could any of you please shed some light on the following?
I asked for help on the #core-coding-standard Slack channel but it looked like I had to open an issue here on GitHub.
I’m running my code against the WPCS and bumped into the following error:
A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders. (WordPress.WP.I18n.MissingTranslatorsComment)
I then added the following to my code to remove the error:
/* translators: %s: search term */
when I run WPCS the error is still there, am I missing something obvious here?
FYI I’m using Underscores and there are similar files (in the templates-parts folder) with the same comments that do not throw that error.
the code I need to comment upon is:

<?php printf( esc_html__( 'Search Results for: %s', 'hlcchl' ), '' . get_search_query() . '' ); ?>

the whole file is here https://github.com/eugelogic/HLCCHL-with-Bootstrap-Sass/blob/master/themes/hlcchl/search.php#L22
Many thanks in advance,
Eugene

You've added the comment within the inline HTML and it will display on your page now. You need to add it in PHP, i.e. <?php /* ... */ ?>

DOH 😞
schoolboy error - thanks for getting back to me @jrfnl

@eugelogic As Juliette says, try:

	<?php /* translators: %s: search term */ ?>

<?php printf( esc_html__( 'Search Results for: %s', 'hlcchl' ), '' . get_search_query() . '' ); ?>

or

<?php
	/* translators: %s: search term */
	printf( esc_html__( 'Search Results for: %s', 'hlcchl' ), '' . get_search_query() . '' );
	?>

Thanks @GaryJones, I'll settle for the first option

My own preference would be to separate out the escape + translate + string + get_search_query from the HTML as much as possible:
<?php
	/* translators: %s: search term */
	$page_title = sprintf(
		__( 'Search Results for: %s', 'hlcchl' ),
		'' . get_search_query() . ''
	);
?>

<?php echo esc_html( $page_title ); ?>

The PHP can now be moved anywhere, and the markup that's left is considerably cleaner.

Thanks @GaryJones for the extra input, very informative.

for example use this to solve your issue
<?php
												// Translators: 1 is the opening  tag, 2 is the closing  tag.//


Use CdkStepper in place of our stepper

https://material.angular.io/cdk/stepper/overview

This issue was moved to cloudfoundry-incubator/stratos#1507


fix failed test for util package

for linux:
ide@openrc-nvide:~/develop/aprilsh/util $ go test -cover . -args -test.gocoverdir=./coverage/unit
ok      github.com/ericwq/aprilsh/util  0.019s  coverage: 100.0% of statements

for mac:
qiwang@Qi15Pro util % go test -cover . -args -test.gocoverdir=./coverage/unit
ok  	github.com/ericwq/aprilsh/util	0.981s	coverage: 100.0% of statements

for linux:
ide@openrc-nvide:~/develop/aprilsh/util $ go test -cover . -args -test.gocoverdir=./coverage/unit
ok  	github.com/ericwq/aprilsh/util	0.010s	coverage: 98.6% of statements

for mac:
qiwang@gauss util % go test -cover . -args -test.gocoverdir=./coverage/unit
ok  	github.com/ericwq/aprilsh/util	1.586s	coverage: 96.4% of statements


Remove -enable-ossa-modules for Synchronization and Distributed

Synchronization and Distributed are serialized in OSSA, they import Darwin which is non-ossa. With implicit modules builds, this results in a one time recompilation of Darwin with -enable-ossa-modules.
However with Explicit Build Modules, all dependencies are treating equally and -enable-ossa-modules will be passed on only when present in the original compiler invocation.
This PR removes -enable-ossa-modules for Synchronization and Distributed and adds a diagnostic whenever we are trying to import a non-ossa module into an ossa module when Explicit Build Modules are enabled.
As a consequence one of the perf constraint tests in Synchronization started failing due to presence of copies which was previously eliminated due to being in ossa. I added @_transparent to the relevant stdlib function - Atomic.deinit to workaround this since @_transparent functions are always serialized as ossa irrespective of the presence of -enable-ossa-modules.
This is a temporary fix until ossa modules are default.
Fixes rdar://138407068

@swift-ci smoke test

Please test with following pull request:
https://github.com/swiftlang/llvm-project/pull/9492
@swift-ci Please test

Is this really easier than just adding -enable-ossa-modules to the Darwin module? Do you have an estimated timeline of when -enable-ossa-modules will be turned on by default?

@Azoy Adding -enable-ossa-modules to Darwin will also need adding it to its dependencies which are multiple in number.

Please test with following pull request:
https://github.com/swiftlang/llvm-project/pull/9492
@swift-ci Please test

@swift-ci test

@swift-ci test

Please test with following pull request:
https://github.com/swiftlang/llvm-project/pull/9492
@swift-ci Please test

Please test with following pull request:
https://github.com/swiftlang/llvm-project/pull/9492
@swift-ci Please test

Please test with following pull request:
https://github.com/swiftlang/llvm-project/pull/9492
@swift-ci Please test windows platform

Hi @meg-gupta , this PR broke the LLDB builds: https://ci.swift.org/view/LLDB/job/oss-lldb-incremental-macos-cmake/8289/console
Whenever an API in ASTContext.h changes, it is advisable to build LLDB as well, as it is one client of that API.

@shahmishal Why didn't the pre-merge CI catch this?

@adrian-prantl the llvm change it was tested with was never merged


Simple

Coverage remained the same at 78.462% when pulling 42339739abe9e7438101f44a5d0ec6fb7c23e804 on simple into d6144b43dbc67f1f94fdd92445af9f4c0c880231 on master.


Implement From for binary_tree::MatchedPair

// TODO we should have a `from` function for this with an error check, just to be extra careful

https://github.com/silversixpence-crypto/dapol/commit/9b73b6913aa54a4e701b3e48122426d9a8ff1116


underlying algorithm

Hi
Thanks for sharing this. What is the underlying algorithm for this code? Is there any formal proof?
regards

Hi usergoodvery,
Branch HP : Paper
Branch FSHW: Custom design spinlock queue
experimental-DCAS: Somebody say double compare and swap can impilement lockfree queue, but i still cannot image this one. This is an abandon branch


any support for presentations?

Support for Beamer?

this has been integrated in the latest release, see master.


Initial abs build

move sha256 to top
simplify dependencies
remove noarch
add doc_source_url

It looks like it has been superseded. Closing


WIP - Part 1: Skia Gold Testing

WIP : Do Not Review
Description
Integrating Flutter golden file testing with Skia Gold
Re-worked into a phased transition from #31630
Related Issues

#17260
#17259
#17258
#16859

Tests
WIP
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[ ] No, this is not a breaking change.

Note: #33406 will probably yield some clean-up here when it lands.

Waiting on #33880 and #33865 to land to rebase and update this PR.

This is ready for another look now @goderbauer & @tvolkert. :)

tool_test_integration-{platform} presubmit tests have been timing out. I'm going to update the branch again and see if it resolves this. Just waiting on these tests to land this change.

FYI for future reference: https://github.com/flutter/flutter/wiki/Tree-hygiene#squashing-commits
(as seen in https://github.com/flutter/flutter/commit/eb0b17902876f1a75eb7180c0b9f3571efb312b8)


[SPARK-14674][SQL] Move HiveContext.hiveconf to HiveSessionState

What changes were proposed in this pull request?
This is just cleanup. This allows us to remove HiveContext later without inflating the diff too much.
How was this patch tested?
No change in functionality.

Test build #55968 has started for PR 12431 at commit 6e47197.

Test build #55968 has finished for PR 12431 at commit 6e47197.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55968/
Test FAILed.

Test build #55980 has started for PR 12431 at commit 1436889.

Test build #55980 has finished for PR 12431 at commit 1436889.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55980/
Test PASSed.


Update component.toml, Dockerfile and cloudbuild.yaml for ortelius-ms-validate-user

Use ortelius/store-recommendationservice as reference

Added the missing files and configuration.


python310Packages.pyswitchbot: 0.18.10 -> 0.18.12

Description of changes
https://github.com/Danielhiversen/pySwitchbot/releases/tag/0.18.12

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 187548 run on x86_64-linux 1

16 packages built:

home-assistant-component-tests.bluetooth
home-assistant-component-tests.homekit_controller
home-assistant-component-tests.switchbot
home-assistant-component-tests.xiaomi_ble
python310Packages.aiohomekit
python310Packages.bleak-retry-connector
python310Packages.pymicrobot
python310Packages.pyswitchbot
python310Packages.xiaomi-ble
python310Packages.yalexs-ble
python39Packages.aiohomekit
python39Packages.bleak-retry-connector
python39Packages.pymicrobot
python39Packages.pyswitchbot
python39Packages.xiaomi-ble
python39Packages.yalexs-ble


Add 'scriptType: pscore' to Azure CLI documentation

This pull request aims to enhance the documentation for the Azure CLI task by adding scriptType: 'pscore' as a valid option. Currently, when attempting to execute a PowerShell script inline using the AzureCLI task, users encounter an error stating: "Script failed with error: Error: Input required: scriptType." This error occurs because the documentation lacks clarity on specifying the script type when using inline scripts with AzureCLI.
By adding scriptType: 'pscore' to the documentation, users will have clear guidance on how to properly configure the task for executing PowerShell scripts inline. This addition will improve the user experience by reducing confusion and ensuring smooth execution of PowerShell scripts within Azure Pipelines.
This change does not affect the functionality of the task itself but enhances the usability and clarity of the documentation, ultimately benefiting users who rely on Azure Pipelines for their continuous integration and deployment workflows.

@sunilagarwal

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@sunilagarwal
Can you review this old PR and determine whether it needs to be closed or merged?
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off


Add windows method to array

This adds a windows method to arrays, which functions just like the rust version.

Thanks!


Change StackExists behaviour

@c-knowles when we changed to using DescribeStacks instead of ListStacks it now returns an error if the stack does not exist.  This change detects if the error was caused by the stack not existing and returns false and nil error instead.
This helps prevent errors like when running validate or apply...
kube-aws validate -v
Called RenderStackTemplateAsString on network
testing whether cf stack perf1-XXXbackend-lab-secure exists
calling AWS cloudformation DescribeStacks ->
<- AWS Responded with an error: ValidationError: Stack with id perf1-XXXbackend-lab-secure does not exist
	status code: 400, request id: 2c838630-ed7a-11e8-8f78-a39daf096ab7
Error does not match 'ValidationError: Stack with id perf1-XXXbackend-lab-secure does not exist'
failed to initialize cluster driver: unable to lookup cloud formation stack perf1-XXXbackend-lab-secure: could not list cloudformation stacks: ValidationError: Stack with id perf1-XXXbackend-lab-secure does not exist
	status code: 400, request id: 2c838630-ed7a-11e8-8f78-a39daf096ab7

Codecov Report

Merging #1499 into master will increase coverage by 0.01%.
The diff coverage is 84.61%.

@@            Coverage Diff            @@
##           master   #1499      +/-   ##
=========================================
+ Coverage   25.38%   25.4%   +0.01%
=========================================
  Files          97      97
  Lines        4987    4991       +4
=========================================
+ Hits         1266    1268       +2
- Misses       3575    3577       +2
  Partials      146     146

Impacted Files
Coverage Δ

cfnstack/cfnstack.go
83.6% <84.61%> (-2.36%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8158496...e402963. Read the comment docs.

/lgtm

/approve

/check-cla


Can't lightmap CSGShapes and generated MeshInstances (cube, sphere, capsule, etc.)

Godot version:
3.2.3 stable
OS/device including version:
Zorin OS 15
Issue description:
In the case of CSGShapes wen you check "Use in baked light" in the 'GeometryInstance' section it doesn't get lightmaped.
For generated MeshInstances (cube, sphere, capsule, etc.) you can't unwrap UV2 for lightmap.

Steps to reproduce:

Create CSGShape or a generated MeshInstance
Check "Use in baked light" in the 'GeometryInstance' section
Bake Lightmap

Minimal reproduction project:

LightmapMeshes.zip

This is fixed in 4.x by https://github.com/godotengine/godot/pull/93252 and https://github.com/godotengine/godot/pull/67975.


General warnings on high utilization values

With i3 status there is a feature to change the color of a notification in case a value like CPU usage or filesystem usage exceed a threshold. This gives a pretty overview of critical system values. Is there anything similar for polybar apart from the temperature module? It would be pretty handy if colors could be adjusted based on numerical values and thresholds.

This is currently not possible. But it is on our TODO list and has already been requested in #570 and #956.


added ability to read the special content object created by feedparser

Motivation for changes:
The rss plugin fails to import the 'content' field of a rss feed (in my case the field was named content:encoded) and logs an error: Cannot grab non text field content from rss.
This is because feedparser stores content in an object rather than a string: https://pythonhosted.org/feedparser/reference-entry-content.html
Since 'content' can be particularly useful, it may be worthwile to write a workaround.
This pull request fixed the issue for me.
Detailed changes:

added 10 lines of code that properly handle the FeedParserDict object which feedparser delivers for content elements in rss feeds
since there may be more than one content element in atom feeds, the code loops over all content elements delivered by feedparser

Addressed issues:

Fixes #656 .

Implemented feature requests:

Feathub #25.

Log and/or tests output (preferably both):
WARNING  rss  Failed to decode entry `<title>` field `content`
DEBUG      rss  Field `content` set to `<content string>`  for `<title>`

To Do:

[ ] similar routines for other rss elements for which feedparser does not return a string

Any chance you'd add tests for this?

I have to admit, I have never written a test before. But given a good example, I am usually a quick study.
I just had a look at test_rss.py and rss.xml.
My approach will be:

Add two more items to rss.xml: one item that contains a single content element and another item that contains multiple content elements.
I would then add a test task and corresponding function which check whether the content elements get parsed o.k.

Two questions:

Is that approach sane?
What is the best way to locally run the tests for debugging?

I managed to add the tests. Thay do work fine. However, now the test test_all_entries_no fails.
Below, i pasted the output that is generated while running the test. Note that in the first run, 11 entries are found and on the second run 9 entries are found. I suspect that the test uses some kind of stored cache?
Could you please help me track down that issue?
conftest.py                 89 INFO     ********** Running task: test_all_entries_no **********
task.py                    580 DEBUG    executing test_all_entries_no
status.py                  110 DEBUG    Adding new task test_all_entries_no
cached_input.py            115 DEBUG    cache name: rss_2c523a27871e5b1ee076d69e707be312 (has: rss_8e714e5d68ebb6fbe9436c61001b2111, rss_7197388fdbb70c3c97c2a9189c21c279, rss_52b90f149e62bc8a50922c4fa433209c, rss_da12396e9fc646c876269a5a68bc04b6, rss_a2445ea3af21fe69a7807ed680349d0a)
rss.py                     210 DEBUG    Requesting task `test_all_entries_no` url `rss.xml`
rss.py                     327 DEBUG    encoding utf-8
rss.py                     424 DEBUG    adding 3 entries from enclosures
rss.py                     359 DEBUG    skipping entry without title
rss.py                     476 DEBUG    Saving location in rss feed.
simple_persistence.py      123 DEBUG    setting key<PHONE_NUMBER>908496614_last_entry value u'Zero sized enclosure'
cached_input.py            171 DEBUG    storing to cache rss_2c523a27871e5b1ee076d69e707be312 11 entries
backlog.py                 182 DEBUG    0 entries purged from backlog
logger.py                  133 VERBOSE  Produced 11 entries.
urlrewriting.py             29 DEBUG    Checking 0 entries
logger.py                  133 VERBOSE  Summary - Accepted: 0 (Rejected: 0 Undecided: 11 Failed: 0)
simple_persistence.py      150 DEBUG    Flushing simple persistence for task test_all_entries_no to db.
conftest.py                 89 INFO     ********** Running task: test_all_entries_no **********
task.py                    580 DEBUG    executing test_all_entries_no
cached_input.py            115 DEBUG    cache name: rss_2c523a27871e5b1ee076d69e707be312 (has: )
rss.py                     210 DEBUG    Requesting task `test_all_entries_no` url `rss.xml`
rss.py                     327 DEBUG    encoding utf-8
rss.py                     424 DEBUG    adding 3 entries from enclosures
logger.py                  133 VERBOSE  Not processing entries from last run.
rss.py                     476 DEBUG    Saving location in rss feed.
simple_persistence.py      123 DEBUG    setting key<PHONE_NUMBER>908496614_last_entry value u'Normal'
cached_input.py            171 DEBUG    storing to cache rss_2c523a27871e5b1ee076d69e707be312 9 entries
backlog.py                 182 DEBUG    0 entries purged from backlog
logger.py                  133 VERBOSE  Produced 9 entries.
urlrewriting.py             29 DEBUG    Checking 0 entries
logger.py                  133 VERBOSE  Summary - Accepted: 0 (Rejected: 0 Undecided: 9 Failed: 0)
simple_persistence.py      150 DEBUG    Flushing simple persistence for task test_all_entries_no to db.

o.k. I found the problem. Apparently, the cache has an issue if any feed item appears after an item without title. I could work around that problem by moving the two items I added to rss.xml above the item that has an empty title. It seems this is a bug (unrelated to my changes) in the caching mechanism employed by rss.py.

I opened a new bug report for the cache issue: #1885

Looks good to me

Thanks :)

thank you. anything to add to wiki?

I don't think so. The changes merely make the existing  other_fields
configuration variable work for the content field as it is already
described in the wiki. So basically we just got rid of an error message...

cool, keep'em coming 😄

Will do :-)


WIP: Datacreator restructuring

Hi!
I'm working on a larger restructuring / improvement for the data creation part.
This is mostly to try and reduce duplication and separate data and logic more cleanly.
This also tackles the TODO to wrap the entire data creation in promises which was hiding in there for quite some time 😉
This is all work in progress currently only the "challenges" part has been reworked, so if anybody has any problems with this or has any suggestions the door is still widely open 😅

With 7.x being an incompatible release anyway, I think we could already drop Node 6.x support. It will go from Active into Maintenance on 30.4.2018 (https://github.com/nodejs/Release#release-schedule) - For comparison: I threw out Node 4.x with Juice Shop 5.0.0 in September 2017 when it also was in Maintenance.

Alright thats cool!
I'm guessing this is also true for "juice-shop-ctf"?
Async / Await would allow to make the code a lot easier 😉

Yes, for juice-shop-ctf I'll do the same.

@J12934, you ping me when ready to merge this one?

Yup, will ping you then. Should be done in a few days.

@J12934 would it be much effort to have the data files in YAML instead of JSON? That way it's consistent with the config file which also contains the products data... I ran your files through https://www.json2yaml.com/ and it created reasonable conversion.

Nope shouldn't be much effort. Will do.

Alright I converted the files to yml.
The rest should also be finished.
The things that have been changed:

All function which insert models inside the datacreator now return a promise.
The datacreator runs all these function in order.
The server now waits for the datacreation before starting up.
The data from users and challenges were extracted into yml files. The remaining data was extracted to arrays inside the datacreator. It seemed excessive to me, to also extract these to yml files as they didn't contain that much data.
Checks for the validity of the active config have been moved to a separate module. (located in lib/validateConfig) This checks that the products related to challenges are all in the config and that no product is used for multiple challenges.

Awesome work! Thanks a lot! Will go right into 7.0.0! 👍


Consider Swift for the backend

e.g. Vapor https://github.com/vapor/vapor

@larribas what do you think? Swift in the backend is coming 🎉

also we could use google's protocol buffers instead of JSON, to try them out!
There is an implementation by apple already for Swift. ( @zzarcon what do you think? )

+10000 for protocol buffers 😍 but not sure about benefits of using Swift over Go to be honest.
What be can actually do it's create a different project and implement the same api with Swift since we have the api defined.
What do you think?

yep, sounds good. I would do it just to try it out... not real benefits ATM


module 'cv2' has no attribute 'CV_ITERATIVE'

python 3.6, opencv 3.4
(success, rotation_vector, translation_vector) = cv2.solvePnP(model_points, image_points, camera_matrix, dist_coeffs, flags=cv2.CV_ITERATIVE)
module 'cv2' has no attribute 'CV_ITERATIVE'

My opencv version is 2.4.9.

Came here looking for an answer to this question and eventually found it, use cv2.cv2.SOLVEPNP_ITERATIVE instead of cv2.CV_ITERATIVE

Came here looking for an answer to this question and eventually found it, use cv2.cv2.SOLVEPNP_ITERATIVE instead of cv2.CV_ITERATIVE

thank you.
I use 3.2 and in my case it should be cv2.SOLVEPNP_ITERATIVE


Make code cleaner

Make the code for building the model and making predictions cleaner by adding classes and functions.

Done!! 😄


add function to create generator to iterate over packets, and alterna…

These are very early stage changes so I don't expect this pull request to be accepted, but I would appreciate your feedback on the ideas behind the changes.
The first change is to add a generator for iterating over the packets in a savefile. That prevents loading large pcaps into memory.
The second change is an alternate way of decoding higher-layer headers, by casting the raw_packet_data to a ctypes.Struct and avoiding the struct.unpack.
If you're interested in these changes, I'll keep working on them.
Thanks,
Joe

I like the direction this is going. A few notes:

Please do run pep8 and pyflake or pylint on this: I've been using pylint, and trying to keep the score at least at 8, preferring > 9 where possible.
It looks like the fix caused a segfault in the standard python 2.7 test (see the Travis output); probably something to look into.

Thanks for working on this, and if you decide to keep going, I'm keen to see what you come up with.

Thanks for the feedback. I'll keep working on it then.


Add navigation between Questions

Features

User can now navigate between questions in an assessment
Last question will show a 'Submit' button instead of a 'Next' button, that redirects to the appropriate assessment listing
Regex handling of id-related URL parameters
Utility function to handle parsing of react-router URL parameters e.g assessmentId and parsing AssessmentCategory to the strings we use for links.

Issues fixed

#118

Pull Request Test Coverage Report for Build 53

15 of 27 (55.56%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 30.122%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/workspace/ControlBar.tsx
0
1
0.0%

src/utils/paramParseHelpers.ts
5
7
71.43%

src/components/assessment/index.tsx
2
11
18.18%

Files with Coverage Reduction
New Missed Lines
%

src/components/workspace/ControlBar.tsx
1
25.45%

src/components/assessment/index.tsx
1
23.33%

Totals

Change from base Build 49:
0.1%

Covered Lines:
1076

Relevant Lines:
3131

💛  - Coveralls

Done, thanks!


fix: adding referrer mertic into page eager call

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--icicidirect--aemsites.hlx.live/research/equity
After: https://rum--icicidirect--aemsites.hlx.live/research/equity

changes does not require merging in current scope. keeping them in branch only


How to get keypoints data ? 請問如何在MainActivity.java中取得keypoints的數值

MediaPipe Solution (you are using)
BlazePoseNcnn
Programming language
Android java
Are you willing to contribute it
None
Describe the feature and the current behaviour/state
我在Android Studio上執行了了這個項目https://github.com/FeiGeChuanShu/ncnn_Android_BlazePose.git
請問要怎麼獲得keypoints的數據來進行姿勢判斷，例如在MainActivity.java中取得右肩膀的x,y軸
I executed this project on Android Studio https://github.com/FeiGeChuanShu/ncnn_Android_BlazePose.git
How to obtain key point data for posture judgment? For example, obtain the x, y axis of the right arm in MainActivity.java.
Will this change the current API? How?
No response
Who will benefit with this feature?
No response
Please specify the use cases for this feature
我在Android Studio上執行了了這個項目https://github.com/FeiGeChuanShu/ncnn_Android_BlazePose.git
請問要怎麼獲得keypoints的數據來進行姿勢判斷，例如在MainActivity.java中取得右肩膀的x,y軸
I executed this project on Android Studio https://github.com/FeiGeChuanShu/ncnn_Android_BlazePose.git
How to obtain key point data for posture judgment? For example, obtain the x, y axis of the right arm in MainActivity.java.
Any Other info
No response

Hi @1278057578,
We are revisiting to older issues, Could you please let us know if you are still seeking a resolution for this issue, or if it has been resolved on your end?
Thank you!!


Add yarn.lock to .gitignore

Close #7765
Description
From https://github.com/facebook/create-react-app/issues/7765, yarn.lock hasn't been dealt with yet in this project.
According to the discussion in that issue, yarn.lock should be ignored in this project.
Acceptance criteria

git status should be unchanged when running yarn for the first time.
yarn.lock should be ignored in .gitignore.

Thanks!


Allow AttributeAccessInterface implementations to return a StatusIB

Problem
AttributeAccessInterface::Read/Write can't usefully return a status response to the client.
Change overview
Fix things so if we return an error that error will make its way to the wire, if possible.
Testing
New YAML tests added.

/rebase


Undefined Reference to arrow::ImportRecordBatchReader

Hello I am trying to use Arrow in one of my company projects, however I am getting an undefined reference to arrow::ImportRecordBatchReader when trying to use it.
Some context, I was previously using arrow from the following commit (c3d031250a7fdcfee5e576833bf6f39097602c30) and I could use arrow::ImportRecrodBatchReader just fine. However, when I upgraded arrow to a more recent version (13a7b605ede88ca15b053f119909c48d0919c6f8) the undefined reference showed up.
I extracted some pieces of code which might be relevant.
How Arrow is added to the project:
ExternalProject_Add(
  ArrowDownload
  GIT_REPOSITORY "https://github.com/apache/arrow"
  GIT_TAG 13a7b605ede88ca15b053f119909c48d0919c6f8
  SOURCE_DIR "${CMAKE_SOURCE_DIR}/third_party/arrow/arrow-9.0.0"
  BUILD_BYPRODUCTS
    <INSTALL_DIR>/libarrow.so

  CONFIGURE_COMMAND
    ${CMAKE_COMMAND}
    -G${CMAKE_GENERATOR}

    #
    # Compiler options
    #
    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
    -DBUILD_WARNING_LEVEL=PRODUCTION
    -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
    -DCMAKE_CXX_COMPILER_LAUNCHER=${CMAKE_CXX_COMPILER_LAUNCHER}
    -DCMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS}
    -DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}
    -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
    -DCMAKE_C_COMPILER_LAUNCHER=${CMAKE_C_COMPILER_LAUNCHER}

    #
    # Install options
    #
    -DCMAKE_INSTALL_PREFIX=${THIRD_PARTY_INSTALL_PREFIX}
    -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR}
    -DCMAKE_MODULE_PATH=${CMAKE_MODULE_PATH}
    -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}

    #
    # Apache Arrow specific options
    #
    -DARROW_ALTIVEC=OFF
    -DARROW_USE_CCACHE=ON
    -DARROW_BOOST_USE_SHARED=OFF
    -DARROW_BUILD_SHARED=ON
    -DARROW_BUILD_STATIC=OFF
    -DARROW_BUILD_UTILITIES=OFF
    -DARROW_COMPUTE=OFF
    -DARROW_DATASET=OFF
    -DARROW_FLIGHT=OFF
    -DARROW_GFLAGS_USE_SHARED=OFF
    -DARROW_HDFS=OFF
    -DARROW_IPC=ON
    -DARROW_JSON=OFF
    -DARROW_CSV=OFF
    -DARROW_JEMALLOC=OFF
    -DARROW_ORC=OFF
    -DARROW_PARQUET=OFF
    -DARROW_PROTOBUF_USE_SHARED=OFF
    -DARROW_USE_GLOG=OFF
    -DARROW_SIMD_LEVEL=NONE
    -DARROW_RUNTIME_SIMD_LEVEL=NONE
    -DARROW_WITH_BROTLI=OFF
    -DARROW_WITH_LZ4=OFF
    -DARROW_WITH_PROTOBUF=OFF
    -DARROW_WITH_RAPIDJSON=OFF
    -DARROW_WITH_SNAPPY=OFF
    -DARROW_WITH_ZLIB=OFF
    -DARROW_WITH_ZSTD=OFF
    -DBOOST_SOURCE=AUTO
    <SOURCE_DIR>/cpp
  CMAKE_ARGS -Wno-dev
  UPDATE_COMMAND "")

set(ARROW_INSTALL_DIR ${THIRD_PARTY_INSTALL_PREFIX})
set(ARROW_INCLUDE ${ARROW_INSTALL_DIR}/include CACHE INTERNAL "")

set(ARROW_LIBS ${CMAKE_INSTALL_LIBDIR})

add_library(ArrowLib SHARED IMPORTED)
set_target_properties(ArrowLib
  PROPERTIES
  IMPORTED_LOCATION
    ${ARROW_LIBS}/libarrow.so
)

Extract of the error:
undefined reference to `arrow::ImportRecordBatchReader(arrow::ArrowArrayStream*)'

If anyone have any idea on why this happens I would appreciate it.
Thanks for your time!

A little bit more debugging shows that this commit (1a00075115ed3487e36281f29c6a7911a7d2bf8d) is when this starts to break for me. Not sure why it breaks though.


implement versioning for rvc2mqtt bridge that can be found in mqtt

use https://pypi.org/project/setuptools-scm/


Select All / Deselect All fires multiple change events on multiple select [performance]

Problem description
Currently, when user clicks "Select All" or "Deselect All" buttons, following code is called:
1052   selectAll: function () {
1053       this.findLis();
1054       this.$lis.not('.divider').not('.disabled').not('.selected').filter(':visible').find('a').click();
1055   },
1056
1057   deselectAll: function () {
1058       this.findLis();
1059       this.$lis.not('.divider').not('.disabled').filter('.selected').filter(':visible').find('a').click();
1060   },

Basically, a click event is invoked multiple times and as a result, client JavaScript code receives multiple "change" events. If these change events are connected to some "slow task", such as Ajax calls to server (for example in order to fill in second select with data based on the selection in a first select), performance suffers and additional code must be written in order to better synchronize multiple Ajax calls.
Solution proposal
Adding a new option aggregateChangeEvents: true/false, default = true. If the property is set to false, the component keeps the current behavior (in case someone relies on it in code). If the property is set to true (default), only the code from the click handler is called on all items (no "virtual clicks" are invoked).
Solution affects only "multiselect" selects. However, looking at the code, this change will require some "careful surgery". I will take the issue over if required (just call "Go!" in case you cannot pull solution of the sleve:)) but will ask for a thorough code review after I submit pull request...

On friday I was using 1.5.3, if I am not mistake and the select all feature was in a flash, then I updated to this last version, and I saw the select all hangs with a lot of items.
+1

Hi,
I fixed this problem.
Add this method:
toggleElements: function ($objs, select) {
      var that = this;

      that.$element.find('option').each(function () { $(this).prop('selected', select); });
      $objs.toggleClass('selected', select);

      that.$searchbox.focus();
      that.$element.change();
    },

And modify the select/deselect so that i looks like this:
    selectAll: function () {
      this.findLis();
      var c = this.$lis.not('.divider').not('.disabled').not('.selected').filter(':visible');
      this.toggleElements(c, true);

      //this.$lis.not('.divider').not('.disabled').not('.selected').filter(':visible').find('a').click();
    },

    deselectAll: function () {
      this.findLis();
      //this.$lis.not('.divider').not('.disabled').filter('.selected').filter(':visible').find('a').click();
      var c = this.$lis.not('.divider').not('.disabled').filter('.selected').filter(':visible');
      this.toggleElements(c, false);
    },

It is much faster than triggering a click on every one of them...

... I wanted to fix this one. :( Well, first come first serve. :) Thank you very much.
Did you create a branch with the fix for a pull request, or should I do it?

OK, I spoke too fast - the code, while fast, does not work properly.
Test case:

Have a select with 10 items, use data-live-search="true" to include live search.
Open the select, make sure all items are selected.
Enter a search string to the search box, so that some items are hidden.
Click "Deselect All"
=> While some items are marked as selected, the select/options underneath are not selected and select says "Nothing selected"

Looks like this was caused by this commit: b78e9d103e5cffe086bcfa3aa09b42a9d1ba6032. The function was changed to prevent selecting hidden options.
I changed the functions from this:
    selectAll: function () {
      this.findLis();
      this.$lis.not('.divider').not('.disabled').not('.selected').filter(':visible').find('a').click();
    },

    deselectAll: function () {
      this.findLis();
      this.$lis.not('.divider').not('.disabled').filter('.selected').filter(':visible').find('a').click();
    },

back to a slightly modified version of the old code (to account for hidden options):
    selectAll: function () {
      this.findLis();
      this.$element.find('option:enabled').not('[data-divider]').not('[data-hidden]').prop('selected', true);
      this.$lis.not('.divider').not('.dropdown-header').not('.disabled').not('.hidden').addClass('selected');
      this.render(false);
    },

    deselectAll: function () {
      this.findLis();
      this.$element.find('option:enabled').not('[data-divider]').not('[data-hidden]').prop('selected', false);
      this.$lis.not('.divider').not('.dropdown-header').not('.disabled').not('.hidden').removeClass('selected');
      this.render(false);
    },

I really can't think of any scenarios where you'd want a change event fired for each new value selected if you're simply clicking select all. And if you did wan't that, I'd have to imagine you'd be in the minority, and thus you'd be better off customizing it yourself.

@caseyjhol Nice one thanks.
Although the code is repeated, just the boolean of the selected property changes. It also makes me realized that the code I pasted before could be even more factorized.
How about adding a generic method that takes the boolean as parameter to avoid redundancy ?
Cheers


osx cli issue

after npm install -g pully on osx i get
pully somelink
env: node\r: No such file or directory

when trying to run it (i'm on node 4.3.1).

did you literally run pully somelink? Or did you provide a Youtube URL instead of somelink? I don't have access to a Mac, so I might need some more information.

it was a youtube link. i cannot run any pully command without getting that error. to me it looks like a windows line-ending issue

Just looking through the code on GitHub, I think the bottom of that stack trace would be here, but I'm not sure what line-ending would be causing it. If you run the tests does it all work?

Yep tests all work and the cli works if i call it with node like this
node $(which pully) <somelink>

That's very interesting, thank you for looking in to it! Unfortunately that doesn't really give me any other ideas as to why it might be happening. Maybe something wrong with the alias, since the full path (via which) is working fine? In other words, do you think it could be an issue with the package.json bin bindings?

Having the same issue.
Node v5.11.0
OSX 10.11.4

I've confirmed this issue is due to CRLF endings. Didn't realize Node doesn't like them. Please see https://help.github.com/articles/dealing-with-line-endings/#platform-windows

Sorry, this is probably an npm publish issue from Windows. See https://github.com/npm/npm/issues/2097.
npm install -g JimmyBoh/pully works as expected.
A roundabout fix would be to have TravisCI publish the module for you. See https://docs.travis-ci.com/user/deployment/npm/
Thank you for this tool. HGPA

Thanks @hparra and everyone! I will be sure to push a new build out tonight. I've learned a lot more about npm version and such, so I will be making updates to the build chain for easier deployments (that work cross platform as well). I will close this issue out once I publish a fixed build.

As of today npm install -g pully still gives the error env: node\r: No such file or directory but npm install -g JimmyBoh/pully works fine.
$ npm install -g pully
$ pully
env: node\r: No such file or directory

$ npm install -g JimmyBoh/pully
$ pully
(works fine)

Oh my goodness, I am so sorry I did not get a chance to work on this yet. Since tomorrow is Memorial Day here in the USA, I will be able to make this fix and push out a new update (I will work on the build-chain more later).

Version 1.2.2 is now live! Please download and let me know if the line endings are correct. I will check back periodically and make any fixes necessary.

Thanks for the update, Jim. Unfortunately I just did npm install -g pully and still got the error env: node\r: No such file or directory. (npm install -g JimmyBoh/pully still working fine)

@alexbinary Damn! I followed the steps here to try and fix all files, but it didn't show me editing any files. Anybody know of a way to find the problem file, or force-fix all of them?

Has anybody been able to fix an issue like this before? I'm thinking that maybe if I make Travis CI deploy it then it should work fine. But I need to start installing ruby etc to encrypt my NPM creds. I will post here when that is done.

I just published a new build, trying to force all line endings to be LF instead of CRLF.

Yes ! Just did npm install -g pully and it worked ! Nice job Jim 👍

also works for me now! thanks a lot.

Phew, thanks for the help everyone! I deeply apologize for taking this long to resolve it!

@JimmyBoh no need to apologise. we should be thanking you for writing the module!

this issue is back again

The issue is still there... Running npm install -g JimmyBoh/pully results in an error:
ENOENT: no such file or directory, chmod '/Users/Me/.npm-packages/lib/node_modules/pully/dist/bin/pully.js'

Ok, so after some google searches I tried this and it seems to work for me:

brew install dos2unix
dos2unix /Users/Me/.npm-packages/lib/node_modules/pully/dist/bin/pully.js

Aah, a line ending issue? I thought I got rid of these. I'll try to fix it.

OK I will.

Closing since I haven't heard anything else.


force wrapping on nested cards

Cute animal pic
Because everyone likes pictures of animals.

Link to Trello card (if applicable)
If this PR relates to a Trello card, don't forget to reference this PR on the card as well.
Was a part of this story: https://trello.com/c/BegMDQLo/58-facilitate-qa-results-submission-through-metashare-and-github-commit-status but waited until after merge to fix
Description
The commit messages say what you did; this should explain why and how.

[ ] Description is in Trello card
Allowed the nested card to wrap instead of truncating the heading "Review Org"

Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally.
You can test once you, as the reviewer, has already submitted a review, then deleted the org. That is when 2 buttons will appear in the header of that Reviewer Card
Impacted areas of website
Provide URLs and/or a description of where to look.
Task detail page
Show me
Provide screenshots/animated gifs/videos if necessary.

There isn't a great way to add spacing between these two without effecting the things around it and since we can't easily edit the markup, it is probably best that for a small set of widths, we can overlook the fact that the buttons are close to the heading. The costs don't outweigh the benefit.

Reviewer tasks:

[ ] Reviewed code
[ ] Reviewed screenshots

Looks good to me once @mirisuzanne signs off. 👍


Is there a listing of known pages where this scraper works?

Is your feature request related to a problem? Please describe.
I was looking to see what job boards or webpages this scraper is known to be currently working.
Describe the solution you'd like
This scraper works on linkedin.com, monster.com, dice.com and we are having some CAPTCHA issues on indeed.com so about 20% failure rate.
Describe alternatives you've considered
I've been building a tool to pull job information out of html links and found your repo, so i'm curious what you have found that works

hey, this was designed to work with indeed and monster specifically, but as you are aware there are issues with captcha, #154
closing this as a duplicate of ^


[SPARK-11977][SQL] Support accessing a column contains "." without backticks

What changes were proposed in this pull request?

Add support for accessing a dataframe column that contains "." in its name without backticks
Add a testcase for this in DataFrameSuite

How was this patch tested?
Spark SQL unit test and manual testing

@sun-rui

Can one of the admins verify this patch?

@shivaram

I'm not sure I am good reviewer for this as I dont fully understand the consequences inside SQL for this change. cc @liancheng @rxin

@sun-rui I added more testcases for this. Please have a look. It would be great, if you could enable the Jenkins CI testing. I don't have a permission to do so.

Does this solution co-operate with the access pattern of "table.column"?

Yes.

Jenkins, ok to test

Test build #62831 has started for PR 14309 at commit 0e47cfd.

Test build #62831 has finished for PR 14309 at commit 0e47cfd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62831/
Test PASSed.

@cloud-fan, could you help to review it?

I have not got any replies on this. I presume that this is a soft reject for this PR.