Schema.pick using Schema.Class stop working when upgrading Schema to 0.64

What version of Effect is running?
2.4.7
What steps can reproduce the bug?
class Person extends Schema.Class<Person>("Person")({
  name: Schema.string,
}) {}

const eitherPersonName = Schema.decodeEither(Person.pipe(Schema.pick("name")))({
  name: "john",
});
console.log(eitherPersonName);

What is the expected behavior?
I should get an Either
What do you see instead?
./node_modules/.pnpm/@effect+schema@0.64.5_effect@2.4.7_fast-check@3.16.0/node_modules/@effect/schema/src/Schema.ts:2088
    throw new Error(`pick: cannot handle this kind of transformation`)
          ^
Error: pick: cannot handle this kind of transformation
    at self (/node_modules/.pnpm/@effect+schema@0.64.5_effect@2.4.7_fast-check@3.16.0/node_modules/@effect/schema/src/Schema.ts:2088:11)
    at pipeArguments (/node_modules/.pnpm/effect@2.4.7/node_modules/effect/src/Pipeable.ts:293:21)
    at pipe (/node_modules/.pnpm/@effect+schema@0.64.5_effect@2.4.7_fast-check@3.16.0/node_modules/@effect/schema/src/Schema.ts:6219:27)
    at Module._compile (node:internal/modules/cjs/loader:1255:14)
    at Object.S (/node_modules/.pnpm/tsx@4.7.1/node_modules/tsx/dist/cjs/index.cjs:1:1292)
    at Module.load (node:internal/modules/cjs/loader:1113:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:165:29)

Node.js v20.3.0

Additional information
I've upgraded effect/schema from 0.63.2 to 0.64.5 and Schema.pick stop working properly with Schema.Class.

I can't repro<EMAIL_ADDRESS>raises the same error.
Code:
import * as Schema from "@effect/schema/Schema"

class Person extends Schema.Class<Person>()({
  name: Schema.string
}) {}

const eitherPersonName = Schema.decodeEither(Person.pipe(Schema.pick("name")))({
  name: "john"
})
console.log(eitherPersonName)

Error:
    throw new Error(`pick: cannot handle this kind of transformation`)
          ^

Error: pick: cannot handle this kind of transformation

@gcanti before I was using:

@effect: 2.4.1
@effect/schema: 0.63.2

@steffanek yes, and I can't repro it using @effect/schema: 0.63.2. As stated above, I get the same error (pick has never worked with transformations, even before, and the Class API defines a transformation under the hood)

gosh my bad @gcanti I rollbacked I was actually transforming the Class to a struct: Person.struct and .pick'ing from that.


cryptography update

This code implements the following features:

create a crypto module to regroup all the functions
uses steem-js crypto as git submodule
stop sending user private key to server
instead create a shared secret from user memo and server memo keys
add a fix hmac derivation (this can be easily extend to have session keys)
note: users can authenticate the server (Lara) the same way they are authenticated by the server (not implemented yet)
prepare switch from memo encryption to AES-GCM encryption (this will improve the overall speed)

TODO

clean all the places we send the private key to the server
clean up the logs
move the key storage from cookie to local/session storage
add key storage encryption
use Ephemeral DH
use one crypto library instead of many

https://github.com/kingswisdom/SteemMessenger/pull/15


Allow isolates to be spawned with separate environment constants

When spawning an isolate, it would be useful to control what environment constants are available within that isolate. This would be nice for things like pub run or the test package runner, where the user may specify environment constants on the command line. It can also be looked at as a security feature; if an isolate is used to run untrusted code, the caller may not want the isolate to have access to its environment constants, which may contain secret information.

Another use case related to pub run here:

I think this is handled by Isolate.spawnUri's environment parameter. Closing for now, but please reopen if this isn't resolved.


updating helmchart

What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]
Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
[ ] This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

[ ] This PR adds tests for the new functionality or fixes.
[ ] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[ ] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[ ] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[ ] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[ ] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[ ] This is not a breaking change.
[ ] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr5.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr5.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr5.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr5.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr5.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr5.previews.kube001.services.stellar-ops.com

Something went wrong with PR preview build please check

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr5.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr5.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr5.previews.kube001.services.stellar-ops.com

Something went wrong with PR preview build please check

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr5.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr5.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr5.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr5.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr5.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr5.previews.kube001.services.stellar-ops.com


[minor] nimble test fails due to dirty nimcache, -f needed sometimes

git rev-parse HEAD
1e086d59595c24ee8ec3f1dcc02b55d97fe9e2ec
nimble installWithDeps
nimble test
Hint:  [Link]
Undefined symbols for architecture x86_64:
  "__test_call_param_", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
  "_test_call_param2", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
  "_test_call_param3", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
  "_test_call_param4", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
  "_test_call_param5", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
  "_test_call_param6", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
  "_test_call_param7", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
  "_test_call_param8", referenced from:
      _NimMainModule in nimterop_tnimterop_c.c.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error: execution of an external program failed: 'g++   -o /Users/timothee/git_clone/nim/nimterop/tests/tnimterop_c  /Users/timothee/.cache/nim/tnimterop_c_d/runtime.c.o /Users/timothee/.cache/ni...

EDIT: using -f to force rebuild worked:
nim c -r -f tests/tnimterop_c.nim

(so may be hard to reproduce...)
is that a nim bug where nim should recompile because something changed, but didn't recompile?

I've seen this happen quite a few times in many projects, I've usually deleted the nimcache and tried again. It's a Nim issue in my mind.
@Araq, can you please comment on this?

Nim caches object files from .compile via a checksum that ignore the C's file dependencies. Solution: Don't develop C code with Nim.


Update versions to 3.7

⬆

I told you about the tests bro, I warned you dog.

I ran them locally! 😥

👍


Search and Lister Component

@review @sakshi-arora1 @rismehta

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Current templates

Older designs

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Closing in favor of https://github.com/adobe/aem-core-forms-components/pull/40


Update docker-compose.yml

added personal_food_computer_v2.launch removed screen flow control options

heres that pull request, it reflect what openAg has in their docker-compose file.


Fails to parse generics without a trailing comma

const a: Foo<T,> = 1 will succeed however const a: Foo<T> = 1 will raise an unexpected token error.
Stack trace
SyntaxError: Unexpected token (1:18)
    at pp$4.raise (node_modules/.pnpm/acorn@8.8.2/node_modules/acorn/dist/acorn.mjs:3459:13)
    at A.raiseCommonCheck (node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:4216:38)
    at A.raise (node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:4223:18)
    at pp$9.unexpected (node_modules/.pnpm/acorn@8.8.2/node_modules/acorn/dist/acorn.mjs:760:8)
    at A.tsParseNonArrayType (node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:2073:11)
    at A.tsParseArrayTypeOrHigher (node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:2077:20)
    at node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:2100:18
    at A.tsInAllowConditionalTypesContext (node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:1663:14)
    at A.tsParseTypeOperatorOrHigher (node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:2099:14)
    at A.tsParseUnionOrIntersectionType (node_modules/.pnpm/acorn-typescript@1.2.10_acorn@8.8.2/node_modules/acorn-typescript/lib/index.mjs:1798:14) {
  pos: 16,
  loc: Position { line: 1, column: 16 },
  raisedAt: 17

OK, I gonna handle this issue

Thanks for another quick fix. I see that you've added an error when there is a trailing comma now, but both forms with and without the trailing comma are valid.

Thanks for another quick fix. I see that you've added an error when there is a trailing comma now, but both forms with and without the trailing comma are valid.

https://www.typescriptlang.org/play?ts=5.0.4#code/JYOwLgpgTgZghgYwgAgGIHt0B4AqA+ZAbwF8AoMATwAcUdkBeZEAVwFsAjaUhdEAZzDI4ALjSZcAGmQFGARiA
I test that case. it seems that's not valid while trailing comma an the end of generics

Oh, it seems to depend on where the generic is being used.
https://www.typescriptlang.org/play?#code/MYewdgzgLgBAhgLhgMRCAPAFQDQD4YC8MAjANwwD0FMYIscANgyAO4CmAJgLABQvAZgFcwwKAEtwMAOZswbAE5jgWbDFwAKAJQwA3pWqNm7bnx4BfXrygBPAA5sUaFfiIAlNlEHywmO22fkVDR08EysnJY8QiLikjJyisAA+vIeXmBaSKgYOPh6QbT0YcaRZkA
But I think it's a compiler error instead of a parser error,
https://ts-ast-viewer.com/#code/MYewdgzgLgBAhgLhgMRCAPAFQDQD4YC8MAjANxA
reports parseDiagnostics as empty

<EMAIL_ADDRESS>

Great, thanks.


remove logs

Related Github tickets

a list of github issues that are relevant for this PR

Background
A short paragraph on test what exactly this PR solves.
Testing completed

[ ] a list of actions that you've performed to ensure that this PR works as intended
[ ] 99% of the times you should have an item: "wrote tests"

Breaking changes

[ ] I have checked my code for breaking changes
[ ] If there are breaking changes, there is a supporting migration.

@webelf101 will you please confirm that it NOT possible to keep these logs as Debug? I'd rather keep them as that then removing them completely.

Please ensure that both logs that are mentioned in the original ticket are level debug. https://github.com/palomachain/paloma/issues/624 Thanks @webelf101

@webelf101 changes are requested. When will these be closed?


Stops displaying Password values in help text

I found this problem, by adding an option of Password type with the EnvVar attribute.
The default help text generator displays the default value with no consideration for the type
https://github.com/bilal-fazlani/commanddotnet/blob/14c8ca20ceef44db4dab3a6eb6c403dccf7c53b4/CommandDotNet/Help/HelpTextProvider.cs#L221
I verified that replacing the above line with
        : $"[{defaultValue!.ValueToString( argument.TypeInfo.Type == typeof(Password) )}]";

solves the issue.

It would be nice to have tests for this functionality

@giuliov thank you for reporting this.  We shouldn't have to check the type.  One of the main purposes of Password is to prevent this type of leak by default.  Any .ToString() call should return and empty string or "*****"  as seen in these tests.   The goal is to avoid this kind of checking if the type is Password to display the value.  I can look into this tonight.  If you get to it before me, you can create the tests by copying GeneralHelpTests, rename to something like PasswordHelpTests and add a password to the Do command.  Replace the existing tests with one that reproduces the bug.  Then we need to determine why Password is returning a value.  That indicates pwd.GetPassword() is being called and I wouldn't have expected that in this area.

@giuliov https://www.nuget.org/packages/CommandDotNet/4.1.4 should fix the issue.  Let me know if you're still seeing it.

Thanks @drewburlingame for the fast turnaround. I confirm that the problem disappeared in the new version.


Immediate death in Berzerkoids

Fixed in 0.4.6

Immediate death bug seems to be fixed now. Instead of this scrren seems badly refreshed, and game locks after leaving 2 or 3 rooms.

@mikerro I've checked it on Lynx and the problem with screen refresh is there also, so it's a bug in the game. I haven't go past first level. Have you tried it on handy of Lynx?

Tried it on Handy and reached shhoting (red) enemies. Played 2 or 3 times longer and there wasn't any lockup.

Reopen then

No death now but I will open new issue...


[Accessibility] URL Parsing issue when generating links in Issue editor

Gitea version (or commit ref): efd202f
Git version: n/a
Operating system: Stretch
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[ ] Not relevant
[x] Not sure, it's not in English at current

Log gist: n/a

Description
URLs with id query string parsed into two separate links, example here:
https://git.habd.as/comfusion/after-dark/issues/1#issue-2
See screenshot below. Notice the right hand side of the = is an internal link whereas the rest of the link is expected save for the query string value as exhibited in the above.
Screenshots

I noticed the same problem with links like: https://medium.com/liberapay-blog/the-second-year-of-liberapay-c017b73c9721
The last part is recognized as commit ID.

@davidak just saw your related bug. please let me know if I should close this or, if related, let's link them :relaxed:

@jhabdas i'm not sure which one you mean. feel free to link it when you think it's related. I would not consider my last bugreport about URL detection related. This report is fine.

https://github.com/go-gitea/gitea/issues/4496

@stale keep

@stale keep

wow. github is not changing the casing of my text. oof. try sending a message to @stale (all-lower). that can't be good.

wow. github is now changing the casing of my text. oof! try sending a message to @stale (all-lower). that can't be good.


dual publish

close #487
build for both cjs and esm.

[x] test passed
[x] web-test works
[x] polkadot.js works

Only core needs to be dual and this is not dual

Only core needs to be dual and this is not dual

@ermalkaleci could you explain a bit

my understanding of dual is when you have .cjs and .mjs file extension and node will import .cjs and if you enable esm it will choose .mjs file extension

my understanding of dual is when you have .cjs and .mjs file extension and node will import .cjs and if you enable esm it will choose .mjs file extension

Yes, this is another way to do this

I don't think we need this anyway. Bundlers will just transform the code and bun for example works with both.

another thing. Do not change current path. I'm sure it will break somewhere. Just add esm into /lib/esm. The tests are all running ok because our ts setup doesn't require any pre-build to work

assuming everything are wired correctly (the export map), everything should work

keep the current tsconfig and create new one only for esm so vscode won't give warnings

keep the current tsconfig and create new one only for esm so vscode won't give warnings

what warnings does it gove?

tools will look for tsconfig.json which doesn't have any reference. we don't need to have 3 tsconfig. Just default one for cjs and another one for esm


What is getOxygenSaturationSamples read Permission?

Guys i want to get OxygenSaturationSamples but i get
"error getting oxygen saturation:Error Domain=com.apple.healthkit Code=5 "Authorization not determined" UserInfo={NSLocalizedDescription=Authorization not determined}".
Could someone tell me which permission should i request to get Oxygen Saturation data?

Hello,
based on Apple's HealthKit documentation you need: HKQuantityTypeIdentifierOxygenSaturation, which is exposed in Permissions through RCTAppleHealthKit+TypesAndPermissions.m.
So your permissions array that you pass to initHealthKit, needs to include: AppleHealthKit.Constants.Permissions. OxygenSaturation.
If you're having any troubles with this setup, please post your code.

@fakeheal Thank You!

Facing same issue:
is there any configuration to do with info plist or somewhere else??
response I got is:

[ ]  AppleHealthKit.getSamples:::{"message":"error getting samples:Error Domain=com.apple.healthkit Code=5 "Authorization not determined" UserInfo={NSLocalizedDescription=Authorization not determined}"}

let storedLastDate = await getLastDate();     let currentDate =       moment(storedLastDate).format('YYYY-MM-DDTHH:MM:00.000') + 'Z';     let options = {       startDate: new Date(currentDate).toISOString(),       endDate: new Date().toISOString(),       type: ['Walking', 'Running'],     };     let permissions = {       permissions: {         read: [           AppleHealthKit.Constants.Permissions.StepCount,           AppleHealthKit.Constants.Permissions.Steps,           AppleHealthKit.Constants.Permissions.ActiveEnergyBurned,         ],         write: [           AppleHealthKit.Constants.Permissions.StepCount,           AppleHealthKit.Constants.Permissions.Steps,           AppleHealthKit.Constants.Permissions.ActiveEnergyBurned,         ],       },     };     await AppleHealthKit.initHealthKit(permissions, async (err, response) => {       console.log(err);       console.log('response init kit observer::' + JSON.stringify(response));       if (response == 1) {         AppleHealthKit.getAuthStatus(permissions, (err, res) => {           if (             res.permissions.read == [2, 2] &&             res.permissions.write == [2, 2]           ) {             AppleHealthKit.getSamples(options, (err, results) => {               if (err) {                 console.log(                   'AppleHealthKit.getSamples error:::' + JSON.stringify(err),                 );                 return;               }               console.log('Retrving steps live:::' + JSON.stringify(results));             });           }         });       }     });
@macelai

hey @kp72-dev, check https://github.com/agencyenterprise/react-native-health/blob/master/docs/permissions.md
Maybe, DistanceWalkingRunning and DistanceWalkingRunning


Recipe tree compatibility

I will come to the example of refined storage with which the problem is actually observed. Let's say there is a component in the craft which has a lot of "painted versions" and also includes a normal version. In the recipe tree, and in the tooltip craft no "continuation" craft, it stops at the object which has several versions, I will attach a photo. Need a function to select 1 of the options to continue the recipe for crafting

If you encounter this, you simply need to pick which of the tag you want to use, this is normal and how EMI functions.

Если вы столкнулись с этим, вам просто нужно выбрать, какой тег вы хотите использовать, это нормально и соответствует принципу работы EMI.

Is it possible to get more information on how to do this?

Click on any item in the recipe tree you want to pick a recipe for.


Improving the guide

Improving Entaldocs' opinionated guide.
@inelgnu Help welcome when you have the time =)

Docs for this PR https://entalpic-entaldocs--6.com.readthedocs.build/en/6/index.html


apply --execute: really execute

This change allows the apply command when supplied with the --execute flag to always execute the calculated commands and do a write_ring or rebalance. Before the commands are only executed when in non interactive mode after user confirmation. Rebalancing only happend with user confirmation.
Reasoning: After some months of heavy usage of the tool, the user confirmation becomes more and more obsolete because one needs anyhow check the output and do a git checkout in case of issues. The old behaviour is still the default, if --execute is not supplied.
Addiotional the possible multiline output of a rebalance command is now split into multiple log lines for better readability (go-bits/log will not allow multiline logs)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.568%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
232

Relevant Lines:
403

💛  - Coveralls


Width and height constraint inverted in android chrome

It's weird but I'm testing this library with a resized camera (wich is not working on iOS (#244)
I'm testing on an android device using chrome, and on a windows computer using also chrome, with a mobile view.
If i set the constraints:
constraints: {
         width: 100,
         height: 300
       }

In the computer I get this:

Which is the expected behaviuour, since it's height is bigger than the width.
But when I open it on the android chrome I get:

Same code for both.
Don't know what is happening, and I don't know which is the correct approach for resizing, since this doesn't work on Safari and It has this behaviour on chrome for PC and Android.

Try including WebRTC adapter.js in your project

Thanks for the response.. it's a valid workaround, but I couldn't figure out why this issue is happening.
Maybe it has something to do with the portrait mode and the init configuration when is mobile.

No, it's a known inconsistent behaviour of slightly different getUserMedia/MediaStream API implementations. Has nothing to do with Quagga JS.

Ok, thanks, I close this issue then and will try with your suggestion.

The suggested fix doesn't work for me, if I switch the constraints on landscape, Quagga won't even start.

Hey @geersch this is very old discussion but today I had exactly the same issue and I managed to solve it, so I will leave this for the potential future use. In my case changing aspectRatio helps, by default its 1:2, so I changed it to 1:100 and it looks correct now, see example configuration below:
inputStream: {
type: "LiveStream",
constraints: {
facingMode: "environment",
width: parseInt(elemWidth),
aspectRatio: {min: 1, max: 100}
},
target: elem
}

Hey @geersch this is very old discussion but today I had exactly the same issue and I managed to solve it, so I will leave this for the potential future use. In my case changing aspectRatio helps, by default its 1:2, so I changed it to 1:100 and it looks correct now, see example configuration below:
inputStream: {
type: "LiveStream",
constraints: {
facingMode: "environment",
width: parseInt(elemWidth),
aspectRatio: {min: 1, max: 100}
},
target: elem
}

FWIW, if you ask for an aspectRatio of 100 max on iOS, you'll get it, and nothing will be right. :-D

FWIW, if you ask for an aspectRatio of 100 max on iOS, you'll get it, and nothing will be right. :-D


convert powershell code generators to use go generate

See: go generate design
The powershell script is a bit of a fly in the ointment for this project as it requires any dev to know powershyell pretty well in order to update the generators. These 2 skill sets are not particularly correlated, so code generation should be done in the Golang domain
This is not really that important, but would be a good task to work on to learn another aspect of Go development.
For a code generation reference, see: go-i18n codegen

watched video: Generating code with go generate - Daniel Milde

Use the generate command in a comment. When you run go generate, it will search all the source files that contains the go generate command and run them
//go:generate <then some executable and args ....>
You can create aliases
//go:generate -command foo echo msg:
creates an alias named foo which runs echo on the parameter msg, eg
//go:generate foo hello

go generate ./...

msg: hello-world

I think we'll also need to combine templates with generate, ie the existing powershell script generate-options-validators.ps1 will be used as a reference of how to define the templates. There should also be some config too (not sure yet what it'll contain). Once we have the templates, we will also define a go based generator that will use the templates and generate the code.
Actually, one such piece of config data will be the output directory of where to generate the output. Initially, we will definitely need this to check what we generate matches the existing generated code auto files.

Can use to generate mocks (gomock)
Also ffjson, can use for generating marshalling code to improve performance as a replacement for reflection.

Actually, to implement this, we need to define a new project whose purpose is to generate the boilerplate source code and the accompanying tests. This separate program is then installed locally. We then add appropriate go:generate comments to invoke our program. So really, go:generate doesnt do that much for us other than to provide the plumbing to stich the parts together, there is no magic here! Look at stringer for an example.

A Crash Course on Go Templates

a template is essentially map[string]*Template.
🎈 To define a template:
{{ template "footer }}

my blog

	{{ template "copyright" }}

{{ define "copyright" }}
Copyright 2020. All RIghts Reserved
{{ end }}

🎯 so when you execute {{ template "footer" }}
you are performing a map[string]*Template for "footer"
map[string]*Template{
	"hello.html": &Template{
		name: "hello.html"
		Tree: /* template body*/
	},
	"footer": &Template{
		name: "footer"
		Tree: /* template body*/
	},
	copyright": &Template{
		name: "copyright"
		Tree: /* template body*/
	},
}

🎈 There are 6 keywords: define, template, block, if/else, with, range
🎯 Variables
each template has access to 1 variable known as the .
the . variable is whatever you pass into Execute/ExecuteTemplate

when . is a struct

struct{
	Params: Params{
		Author: Author{
			LastName: "John",
			LastName: "Doe",
		},
	},
}

{{ . }}
{{ .Params.Author.LastName }}

the . refers to the struct above

when dot is:
map[string]interface{}{
"Params": map[string]interface{}{
"Author": map[string]interface{}{
"FirstName": "John",
"LastName": "Doe",
}
}
}

{{ . }}
{{ .Params.Author.LastName }}

the . refers to the map above ie, if you pass in the map into the Execute function
🧿 this all works via reflection
You can define your own variable but there are all relative to .
{{ define "greet" }}
	{{ $firstName := .Params.User.FirstName }} // declaration & assignment

hello, name is {{ $firstName }}

	{{ firstName = "Joe" }} // reassignment

actually, my name is {{ $firstName }}

{{ end }}

scope of a variable extends to the matching {{ end }} of the current block
🎈  dot and dollar
. refers to the current template variable, but so does $
--> the difference is that the dot changes depending on context
the dot changes inside {{ with }} and {{ range }} bocks
the dollar always points to the toplevel template variable, it never changes, where as the
dot starts off at the top level, but can change
🎈  with
a bit like {{ if  }}
usage:
{{ with  }} {{ end }}
if  is falsy, the block is not executed
the dot '.' variable is set to  inside the block
🎈  range
loops over a variable
usage:
{{ range <var> }} {{ else }} {{ end }}

<var> must be array, slice, map or channel
if there are 0 element, the else block is executed
you can also specify an index variable in the range statement (assuming you pass in a slice/array/chan)
(for map, $i would be the key):
{{ range $i, $user := .Users }}
... template content

{{ else }}
... template content
{{ end }}

🎯 This allows our template to generate dynamic content
🎈 functions methods and pipes
example functions:

and/or/not/index/len

and
{{ if and    }} {{ end }}

len
{{ len  }} {{ end }}

(where var is string|slice|array|map|channel)

index

{{ index <slice> <num> ... }}
{{ index <map> <key> ... }}

🎈  templates can call user defined functions .Funcs(map[string]interface{})
template.
	New("t").
	Funcs(map[string]interface{}){
		"greet": func(name string) string { return "hello" + name}
	}).
	Parse(`{{ greet "bob" }}`)

funcs take either of these forms:
func() string
func(s string) string
func(args ...interface{}) interface{}

you can also return an error, when error occurs template engine will stop executing
func() (string, error)
func(s string) (string, error)
func(args ...interface{}) (string, interface{}) // !! this looks fishy, should the return be?: (error, interface{})

🎈 templates can call methods
type User struct { greeting string }

func (u User) Greet(name string) string {
	return u.greeting + " " + name
}

t, _ := template.New("t"),Parse(`{{ .User.Greet "bob" }}`)
t.Execute(os.Stdout, map[string]interface{}){
	"User": User{greeting: "hello"},
}

if a member of a struct is variable that is a func, then the template
can't invoke it directory. It has to be invoked using the 'call' keyword
---> the results of 1 function can be piped into another using |

Another potential useful reference: Go Templates - Simple and Powerful

to print a value that appears inside quotes, you can use printf go template function with %q format specifier. The %q, is a placeholder of a value that will be quoted.


Response data is not properly being logged when unsuccessful.

Feature Request
Is your feature request related to a problem? Please describe.
Please provide more information from Response when IsSuccessStatusCode = false
Describe the solution you'd like
When CompletionRequest's Response.IsSuccessStatusCode = false much of the useful information being returned from the server is lost. For example, "BadRequest" status code doesn't explain why it was a bad request which the server's response often explains in more detail.
Proposed solution:
Include the server's Response.Content in the message being bubbled up in the exception.
More context:
Using OpenAI CompletionRequest was failing for me via BadRequest errors when my prompt was growing past about 384 characters in length. After tweaking the code to provide the Response.Content I found the server was telling me the total tokens (prompt+response) were going over the max. The response also included the solution to resolve the problem, but that critical information was not being bubbled up.

Please be sure to stick to the issue template. I felt like you were yelling at me with everything big and bold 😅

Sorry! My first contribution to any open source project; learning as I go, thanks for your patience. I pushed a branch w/ proposed fix. I don't think I linked it properly to this issue or do I do that in the PR?

That's great!
I do have an idea of what I want to do here but I would love to see your pull request first.
If you forked the repository you should be able to make a pull request

Ah, that makes sense now. Forked & changes pushed, PR created. Let me know if I'm doing anything else wrong or not following proper etiquette.  Thanks so much for suggesting these changes. I agree, and I'll follow up and make these changes by the end of the weekend.


enabling students and users to filter job opportunities according to their project and skills

Using LinkedIn or other similar applications API to access the available job opportunities in the market and adding an option to filter them according to the projects and skills owned by an individual.
Collaborating and establishing partnership with interested companies and industries and creating a platform where they can sell courses or internship training to the users.

@kashishrajputt Issue has been assigned to you


Added MaxParallelism parameters on bacpac import/export

Added MaxParallelism parameters on bacpac import/export (Import-D365Bacpac & New-D365Bacpac). Added the usage of the parameter to Invoke-SQLPackage.
Added the parameters to the tests Import-D365Bacpac.Tests.ps1 and New-D365Bacpac.Tests.ps1

Thanks,
Could i get you to create the PR against the main repository?
https://github.com/d365collaborative/d365fo.tools
Could I also convince you to move the MaxParallelism just before ShowOriginalProgress in all cmdlets that you changed?
We try to keep the last 3 parameters to always be ShowOriginalProgress, OutputCommandOnly, EnableException
        [switch] $ShowOriginalProgress,

        [switch] $OutputCommandOnly,

        [switch] $EnableException

And a feedback point: We try to set the default, if we state that we have a default for a given parameter. I know that the internal assembly have a default, and if we are setting it, we don't change anything - but it makes it clearer code-wise that we pass the default all the way down.

Sure!


Update language support tests and docs

Adds python 3.6 the tox configuration and adds python 3.5 & 3.6 to
the language classifiers and travis configuration.
Resolves #164
cc @kyleknap @jamesls @dstufft @stealthycoin

Looks like I'm going to have to mess around with this a bit to get it to work beyond python 3.4

Oh, it's because you don't have the python: lines in .travis.yml.

These things: https://github.com/boto/boto3/blob/develop/.travis.yml#L2-L8, because Travis only preloads some Pythons not all of them for a variety of reasons, and they download the rest on demand when the language selector picks it. You can do something like https://github.com/pypa/pip/blob/master/.travis.yml#L4-L33 to get the TOXENV variable set along with the python version, or you need a script that will set it correctly.

Looks like that did the trick!


Updating 'Lifecycle' version from 2.0.0 to 2.2.0 (latest)

https://i.kym-cdn.com/entries/icons/mobile/000/028/021/work.jpg


add api to get team name

add list of team names for assigning the request.
team names are only determined by agents registered to wmstats. (Not sure this will cause the problem).
Otherwise we have to have the interface to add the team name like in reqmgr1
@vkuznet, @amaltaro, Please review

REST api will be (not deployed)
https://cmsweb.cern.ch/wmstatsserver/data/teams
Test vm is set
https://reqmgr2-dev.cern.ch/wmstatsserver/data/teams

Seagnchan,
how this API will work? I mean does teams change over time or depends on
request? When should I query this API, every time when somebody
click on assign link, can we cache teams?
I think you really need to clarify the behavior for that.
So far it is just REST API which as far as I can tell will return
list of teams.
Thanks,
Valentin.
On  0, ticoann<EMAIL_ADDRESS>wrote:

REST api will be (not deployed)
https://cmsweb.cern.ch/wmstatsserver/data/teams
Test vm is set
https://reqmgr2-dev.cern.ch/wmstatsserver/data/teams

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/6680#issuecomment-193436898

Hi Valentin,
In production teams are not changed, we very occasionally add teams but in general we have only a few teams and doesn't change. Although call is pretty light weight and repeated call won't have much overhead but I think caching would be fine. Are you trying to caching in browser? I think some of the browser caches ajax call automatically,  you can do manual caching if you want.
FYI. team is something that related to agent.  Basically team is used to pull down the request to certain agent.  So if a team is assigned to given request only agent belongs that team can pull that request.
We were planning to remove team concept completely, since request should run all the agent due to the not perfect priority and resource control we maintain a couple of teams for different agent.
When agent gets deployed, it registers (actually just reports) the team in wmstats so that is why I created wmstats REST api.

Seangchan,
I changed https://github.com/dmwm/WMCore/pull/6681/
with respect to discussion we had. getTeams local API now fetch teams
all the time and fall backs into using cached values.
Please review, since I didn't test it on vm.
Best,
Valentin.
On  0, ticoann<EMAIL_ADDRESS>wrote:

Hi Valentin,
In production teams are not changed, we very occasionally add teams but in general we have only a few teams and doesn't change. Although call is pretty light weight and repeated call won't have much overhead but I think caching would be fine. Are you trying to caching in browser? I think some of the browser caches ajax call automatically,  you can do manual caching if you want.
FYI. team is something that related to agent.  Basically team is used to pull down the request to certain agent.  So if a team is assigned to given request only agent belongs that team can pull that request.
We were planning to remove team concept completely, since request should run all the agent due to the not perfect priority and resource control we maintain a couple of teams for different agent.
When agent gets deployed, it registers (actually just reports) the team in wmstats so that is why I created wmstats REST api.

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/6680#issuecomment-193618016


Allow to use scroll buttons in QTabWidgets created by RViz

If you stack a lot of widgets inside RViz, the labels becomes hard to read like this:

Solutions:

Use shorter tab names (+ a tooltip)
Expand the tab so that labels becomes easy to read again:

Allow to use scroll buttons in the QTabWidget:

 (without scroll buttons)
 (with scroll buttons)

Last solution is by far the best in my opinion.
I think one solution is to subclass the tab bar and add a right click action to choose between scroll buttons, no scroll buttons.

I can't find the code that manages that part. I searched for QTabWidget but it's only returning one results which is not what I'm looking for (src/rviz/add_display_dialog.cpp).
Which part of the RViz code manages the stacking/moving of whole RViz panels?

@VictorLamoine I believe it is just done by QtMainWindow (of which VisualizationFrame inherits). Maybe what you want is https://doc.qt.io/qt-5/qmainwindow.html#DockOption-enum?

Thanks @wjwwood, it helped me a lot because I did not know the "dock widget" names.
I made a test and this is exactly what I wanted:
Default behaviour

Don't elide text in QTabBar

Now I need to find a place/signal to put this code (each time a panel is added or moved); the code itself is very straightforward:
https://github.com/ros-visualization/rviz/compare/kinetic-devel...VictorLamoine:QTabWidget_elide?expand=1

Diff without whitespace changes: https://github.com/ros-visualization/rviz/compare/kinetic-devel...VictorLamoine:QTabWidget_elide?expand=1&w=1.


I63 create sign up requests page

Change Summary
Created the sign-up page with basic javascript dummy functions. Added CSS to try and match the Figma file.
Change Form

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
Related issue

Resolve #63

All changes done! 😁


expose results

Changes

Exposed results api endpoint for service-to-service requests.

meow @hughhhh @betodealmeida

Let me try to deploy this.

Moved to https://github.com/lyft/superset-private/pull/311.


Fix: httpProtocolOptions  be reset when apply connection pool settings

Please provide a description of this PR:
There is only one strategy in idleTimeout and maxRequestsPerConnection, there is another strategy is reset.

@nicole-lihui: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4a08521f50ecd2013f4548d5a4fb2a6ce810f96d
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4a08521f50ecd2013f4548d5a4fb2a6ce810f96d
link
true
/test lint_istio

gencheck_istio
4a08521f50ecd2013f4548d5a4fb2a6ce810f96d
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Its not clear what the goal is here? Is it a refactoring or bug fix? If its a bug fix can we add a test?

@howardjohn
Thank you, this is a good idea，add test cases can more clearly.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
4a08521f50ecd2013f4548d5a4fb2a6ce810f96d
link
true
/test gencheck_istio

lint_istio
ba8c3572f51fe5f34bf0326283b96917763ecea2
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
ba8c3572f51fe5f34bf0326283b96917763ecea2
link
true
/test lint_istio

gencheck_istio
f171654bad702af00a413ed6bcb31566b9bf8754
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
f18cbc4f60348e18f1cba3a55453337a3ea77019
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@nicole-lihui: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
f18cbc4f60348e18f1cba3a55453337a3ea77019
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster-tests_istio
51a49528a90adffb088720db6023e68110b8a5f1
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster-tests_istio
51a49528a90adffb088720db6023e68110b8a5f1
link
true
/test integ-pilot-multicluster-tests_istio

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster-tests_istio
51a49528a90adffb088720db6023e68110b8a5f1
link
true
/test integ-pilot-multicluster-tests_istio

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

release-notes_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

release-notes_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-notes_istio

lint_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

release-notes_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-notes_istio

lint_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test lint_istio

release-test_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

release-notes_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-notes_istio

lint_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test lint_istio

release-test_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-test_istio

integ-pilot-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

release-notes_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-notes_istio

lint_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test lint_istio

release-test_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-test_istio

integ-pilot-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-k8s-tests_istio

integ-telemetry-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-istiodremote-tests_istio

integ-security-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test unit-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-pilot-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-helm-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-helm-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test analyze-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

gencheck_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test gencheck_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

release-notes_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-notes_istio

lint_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test lint_istio

release-test_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test release-test_istio

integ-pilot-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-k8s-tests_istio

integ-telemetry-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-istiodremote-tests_istio

integ-security-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-istiodremote-tests_istio

integ-ipv6-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicole-lihui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-cni-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-pilot-k8s-tests_istio

integ-telemetry-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-telemetry-istiodremote-tests_istio

integ-security-istiodremote-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-security-istiodremote-tests_istio

integ-ipv6-k8s-tests_istio
1bcc40132091d23c7a2a9bd00ae8cbf5322bda77
link
true
/test integ-ipv6-k8s-tests_istio

integ-pilot-istiodremote-tests_istio
d465fa0cc77d7a2b67ed03507205d873ac6b5b91
link
true
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote-tests_istio


Writes to emptyDir is much slower as compared to writes within container root fs

Describe the bug
We have been doing perf testing as complains arose around slower writes when writing to emptyDir. Based on the experiments, we can see that it's definitely slower especially with large sets of small files (like cloning a repo for example).
To Reproduce
Those tests were ran on GKE clusters, but the results will be identical to OSS clusters with GCE provider. We've looked into the perf. of backing managed boot-disk, and there wasn't any overhead or throttling happening. the tests were made on regular disks as well as using higher perf disks (pd-ssd), and the slowness still remains as compared to writes within container FS.
Expected behavior
We expect a similar performance with the writes to emptyDir.
Example for a test container:
apiVersion: v1
kind: Pod
metadata:
  name: pod-with-empty-dir
spec:
 containers:
 - args:
   - netexec
   image: k8s.gcr.io/e2e-test-images/agnhost:2.20
   name: agnhost
   imagePullPolicy: IfNotPresent
   ports:
   - containerPort: 8080
   volumeMounts:
    - mountPath: "C:\\test-ssd"
      name: "test-ssd-empty-dir"
    - mountPath: "C:\\anotherdir_mount"
      name: another-dir
      readOnly: false
 nodeSelector:
  kubernetes.io/os: windows
 volumes:
  - name: test-ssd-empty-dir
    emptyDir: {}
  - name: another-dir
    hostPath:
      path: "C:\\anotherdir"

Test 1: emtyDir vs container fs (high perf  disk - cloning a repo - 300% slower):
C:/test-ssd $ powershell
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

PS C:\test-ssd> Measure-Command {git clone https://github.com/openjdk/jdk}
Cloning into 'jdk'...
remote: Enumerating objects: 1346798, done.
remote: Counting objects: 100% (478/478), done.
remote: Compressing objects: 100% (309/309), done.
Receiving objects: 100% (1346798/1346798), 1.06 GiB | 17.64 MiB/s, done.346320

Resolving deltas: 100% (1000847/1000847), done.
Updating files: 100% (66565/66565), done.

Days              : 0
Hours             : 0
Minutes           : 15
Seconds           : 53
Milliseconds      : 518
Ticks             :<PHONE_NUMBER>
TotalDays         : 0.0110360934363426
TotalHours        : 0.264866242472222
TotalMinutes      : 15.8919745483333
TotalSeconds      :<PHONE_NUMBER>
TotalMilliseconds :<PHONE_NUMBER>

PS C:\> Measure-Command {git clone https://github.com/openjdk/jdk}
Cloning into 'jdk'...
remote: Enumerating objects: 1346813, done.
remote: Counting objects: 100% (528/528), done.
remote: Compressing objects: 100% (332/332), done.
Receiving objects: 100% (1346813/1346813), 1.06 GiB | 17.66 MiB/s, done.346285

Resolving deltas: 100% (1000206/1000206), done.
Updating files: 100% (66565/66565), done.

Days              : 0
Hours             : 0
Minutes           : 3
Seconds           : 56
Milliseconds      : 546
Ticks             :<PHONE_NUMBER>
TotalDays         : 0.0027378068900463
TotalHours        : 0.0657073653611111
TotalMinutes      : 3.94244192166667
TotalSeconds      :<PHONE_NUMBER>
TotalMilliseconds :<PHONE_NUMBER>

Test 2: emtyDir vs container fs (high perf  disk - cloning a repo - ~57% slower):
PS C:\test-ssd> Measure-Command {1..10000 | %{ ($_ * (Get-Random -Max ([int]::maxvalue))) > "file$_.txt"}}

Days              : 0
Hours             : 0
Minutes           : 1
Seconds           : 57
Milliseconds      : 174
Ticks             :<PHONE_NUMBER>
TotalDays         : 0.00135618224074074
TotalHours        : 0.0325483737777778
TotalMinutes      : 1.95290242666667
TotalSeconds      :<PHONE_NUMBER>
TotalMilliseconds :<PHONE_NUMBER>

PS C:\> Measure-Command {1..10000 | %{ ($_ * (Get-Random -Max ([int]::maxvalue))) > "file$_.txt"}}

Days              : 0
Hours             : 0
Minutes           : 1
Seconds           : 15
Milliseconds      : 466
Ticks             : 754661779
TotalDays         : 0.000873451133101852
TotalHours        : 0.0209628271944444
TotalMinutes      : 1.25776963166667
TotalSeconds      : 75.4661779
TotalMilliseconds : 75466.1779

Test 3 : container fs with symlink vs emptyDir (this was to check if symlink overhead could be the cause - still ~46% slower):
PS C:\test> mkdir src
PS C:\test> New-Item -Path C:\test\sym -ItemType SymbolicLink -Value C:\test\src
PS C:\test> cd sym
PS C:\test\sym> Measure-Command {1..10000 | %{ ($_ * (Get-Random -Max ([int]::maxvalue))) > "file$_.txt"}}

Days              : 0
Hours             : 0
Minutes           : 1
Seconds           : 32
Milliseconds      : 173
Ticks             : 921737106
TotalDays         : 0.00106682535416667
TotalHours        : 0.0256038085
TotalMinutes      : 1.53622851
TotalSeconds      : 92.1737106
TotalMilliseconds : 92173.7106

PS C:\emptydir> Measure-Command {1..10000 | %{ ($_ * (Get-Random -Max ([int]::maxvalue))) > "file$_.txt"}}

Days              : 0
Hours             : 0
Minutes           : 2
Seconds           : 13
Milliseconds      : 681
Ticks             :<PHONE_NUMBER>
TotalDays         : 0.0015472373900463
TotalHours        : 0.0371336973611111
TotalMinutes      : 2.22802184166667
TotalSeconds      :<PHONE_NUMBER>
TotalMilliseconds :<PHONE_NUMBER>

Configuration:

Edition: Windows Server 2019 LTSC
Base Image being used: Windows Server Core
Container engine: containerd
Container Engine version: 1.6.13

Additional context
Add any other context about the problem here.

@Howard-Haiyang-Hao fyi

Thank you James for bringing this to my attention. @ibabou, I was able to reproduce this issue with the performance traces that we needed. The issue is related to the different defender behaviors of scanning a local volume vs scanning a bind folder. We are in the process of addressing the issue.

Thanks @jsturtevant / @Howard-Haiyang-Hao ! Howard, does defender still have this problematic effect even if exclusion is set on the container-runtime process (we do so to avoid the bad-effect on image unpacking)? or, the live detection will still take effect for the containers shims/processes?
We set those settings on the VMs for example:
Set-MpPreference -SubmitSamplesConsent NeverSend
Set-MpPreference -MAPSReporting Disabled
Add-MpPreference -ExclusionProcess "$NODE_DIR\containerd.exe"

Is there a workaround/suggetion to disable completely?

No, I don't think we should disable the defender completely. This is an issue that we need to address at system level. Let me ask the defender team to see if there is a temporary workaround about this issue.
We are trying to understand is that why fileio on Emptydir was reissued from cache manager as wirte operations. We will keep you posted.

Hi @Howard-Haiyang-Hao,  is there any update on this issue?

@Howard-Haiyang-Hao is there any updates? Are there a workaround? Is turning off the defender the only option?

I am also looking for a temp workaround, is turning off the defender an option? ibabou, did you solve the issue with commands above?

Hey @SergeyKanzhelev  @martinelli-francesco, the defender team is working on a solution but it may take some time. For now you can use the command Set-MpPreference -DisableRealtimeMonitoring $true to disable the scanning.

The fix has been checked in and should be rolled out with Windows Update soon.

@martinelli-francesco The commands above won't solve the issue, it seems the only way is to disable live monitoring completely.

The fix has been checked in and should be rolled out with Windows Update soon.

Thanks @Howard-Haiyang-Hao for the update! can you please share on what monthly release this is expected (and if the fix will require any opt-in configuration)? Also, will it be for both 2019 & 2022 on same cadence?

@Howard-Haiyang-Hao gentle ping on this. Any pointers on when the fix will be available?
Also, what is the best way to disable it completely as per @ibabou 's comment above?

The fix has successfully passed most release rings and will be available to the public within 2-3 weeks through the Windows Update channel. Thank you for your patience!

@Howard-Haiyang-Hao - does this have a kb number or something?
How can we see whether the fix is present or not?

Is this the relevant Defender update @Howard-Haiyang-Hao ?

Exciting update! We've released the fix for the defender issue. To confirm if your system now has the fix, please execute the following command:
(Get-MpComputerStatus).AMProductVersion
4.18.23070.1004

Thanks @Howard-Haiyang-Hao for the update!

It is still incredibly slow...
copy (cp -R) 250mb in about 20000 files with defender on: 271 sec
copy (cp -R) 250mb in about 20000 files with defender exclude c:\var folder in host: 81 sec
copy (cp -R) 250mb in about 20000 files with defender off in host: 61 sec
linux on SAME machine, same files: 6 seconds

It is still incredibly slow...
psychical machine Windows: 4.18.23070.1004 | -- Hyper-V Windows VM k8s: 4.18.23070.1004 | -- Hyper-V linux VM k8s: debian 12
Testing
copy (cp -R) 250mb in about 20000 files
Windows k8s
from emptyDir to same emptyDir,
with defender on : 271 sec with defender exclude c:\var folder in host: 81 sec with defender off in host: 61 sec
from emptyDir to container c:\ with defender off
with defender off in host: 31 sec
from container c:\ to container c:\ with defender off
with defender off in host: 31 sec
Windows VM (ie host)
from host c:\var\lib\kubelet\pods...\ to host c:\ with defender off
with defender off in host: 26 sec
from host c:\ to host c:\ with defender off
with defender off in host: 24 sec
linux k8s
emptydir to same emptydir
6 seconds

@davhdavh have you checked the defender version?
(Get-MpComputerStatus).AMProductVersion
4.18.23070.1004

@abe

It is still incredibly slow...
psychical machine Windows: 4.18.23070.1004 | -- Hyper-V Windows VM k8s: 4.18.23070.1004 | -- Hyper-V linux VM k8s: debian 12

@davhdavh have you checked the defender version?
(Get-MpComputerStatus).AMProductVersion 4.18.23070.1004

It was already in the post. Same version for both hardware host and k8s node host.

I've conducted a comparative study by following these steps within an AKS container:

git.exe clone https://github.com/microsoft/hcsshim.git C:\osdisk
git.exe clone https://github.com/microsoft/hcsshim.git C:\tmp\temp

In this scenario, c:\tmp serves as a bind folder. Here are the findings:

The disparity between a regular folder and a bind folder has diminished from 3.5x to 32%. Please do let me know if you've observed any differing results.

@Howard-Haiyang-Hao Like I wrote above, we are still seeing a ~800% difference between defender off and defender on using version 4.18.23070.1004, and ~95% in bind vs regular.

git clone is one of the worst ways to test this issue because it involves network traffic, while reporter complains about storage I/O.

Agree. And that is why my testing was to copy an already checked out repo.

@Howard-Haiyang-Hao how to send the files to you? They are 80mb zipped

@davhdavh, An efficient method for sharing sizable files involves the use of Azcopy. Should you kindly share me with the Azure storage file link accompanied by the access token, I would be capable of downloading the file. It's worth noting that Azcopy boasts exceptional performance.

@Howard-Haiyang-Hao you are not sharing your email on github, so how to send to you?

Hey @SergeyKanzhelev @martinelli-francesco, the defender team is working on a solution but it may take some time. For now you can use the command Set-MpPreference -DisableRealtimeMonitoring $true to disable the scanning.

@brasmith-ms, I just used docker on windows server 2022 and used mcr.microsoft.com/windows/server:ltsc2022 image. And when I tried that command you mentioned, it reports error:

And I see that the 'Defender' module is NOT included in the image. Could you tell me how to install it? It is strange since windows server 2022 or windows 11 have that module by default.


angular.d.ts errors

Hi,
There is a lot of errors in the definition file. I guess it's the one generated:
line 94:
token: void;
line 254:
selector: void;
line 363:
 length: void;

 first: void;

 last: void;

etc.
Jean

Wrong Angular-seed project...


Added side menu for mobile

Added collapsible side menu that activates for devices with a screen width less than 1024px. Also minorly changed formatting (removing video overflow on about page, centering headings, resizing buttons with overflow).

Thanks for working on this! If we could indicate what the current page is (maybe change other text to gray or add an outline around the current page text) that would be nice to add.

Also its a little hard to see but on the sponsors page it looks like the footer has a large top padding and starts right below the button.


Enhance Airfoil 5.5.2 with zap stanza

Add a zap stanza to the existing Airfoil 5.5.2 cask to allow full uninstall.
Note: is uninstall quit meant to be handled before apps are removed? I wanted to split logic between uninstall (e.g. quit, login_item, clear Caches) and zap (e.g. remove user settings), but found that when the app was running during an uninstall, that it warned that its .app package had been removed before it was sent the quit instruction via osascript. Is this expected behaviour? I couldn't find an open issue.
After making these changes to the cask:

[x] brew cask audit --download airfoil is error-free.
[x] brew cask style --fix airfoil reports no offenses.
[x] The commit message includes the cask’s name and version.

Note: is uninstall quit meant to be handled before apps are removed? I wanted to split logic between uninstall (e.g. quit, login_item, clear Caches) and zap (e.g. remove user settings), but found that when the app was running during an uninstall, that it warned that its .app package had been removed before it was sent the quit instruction via osascript. Is this expected behaviour? I couldn't find an open issue.

Ping @reitermarkus who will be able to answer this better than I can.

is uninstall quit meant to be handled before apps are removed?

It is now. The code to do this has been merged just a few hours ago, so you won’t yet see it live.

Thank you for your contribution.


Topic incorrect

I installed v.2.3 and changed the "MQTT zone text topic" which for the "Zone" works regularly, but when I used it with the topic "intensity" it doesn't do anything, I had to reset the "MQTT device prefix" by default. For the rest, great work.

Should be fixed in v2.6 Please check it: https://github.com/widapro/wledPixel/releases/tag/v2.6

Fine


Career Goals website

Description 📜
A frontend project, for students to find resources in accordance to their needs.
Fixes #159

This would be great if you provide any of this   📝

[x] Other
I have added the deployed link below.

Domain of Contribution 📊

[ ] Navbar design
[ ] Footer
[x] Single page website
[ ] Animation design
[ ] parallax effect design
[ ] Others

Checklist ✅
]

[x] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[x] I'm Hacktoberfest contributor

Screenshots / Gif (Compulsory) 📸
https://prachi070.github.io/Career-Goals/

@prachi070 please work on responsiveness , mobile view is not up to date


Raise error for duplicate application names

Signed-off-by: John Pitman<EMAIL_ADDRESS>Fixes #68

LGTM


Add multiple addresses

We need to allow users to add multiple addresses to their accounts. We can do this through creating a new addresses table and have a userid field to connect to the users table.

Isa next time when closing an issue can you reference the commit that fixes it? For example for this one:
Implemented in 334654c

ok
Sent from my iPhone

On Apr 4, 2016, at 20:37, Ben Zhang<EMAIL_ADDRESS>wrote:
Isa next time when closing an issue can you reference the commit that fixes it? For example for this one:
Implemented in 334654c
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub


Ghost flight

Not sure if this has been reported it before but I'll report it just in case someone hasn't
If you are a decent distance away from the piloting seat it can let you control the ship without putting you in the ship.  If you need a vid or something let me know.
forge-<IP_ADDRESS>49
valkyrien warfare-0.9_prerelease_5

Old issue, closed. This is a feature not a bug (unironically).