Problems with rule

Hello,
at this website
https://www.heise.de/newsticker/meldung/Lohnangleichung-bei-Google-Maenner-staerker-unterbezahlt-4326808.html?wt_mc=rss.ho.beitrag.atom
i am having trouble blocking this part:

my code:
{     "type": "xpath",     "xpath": [         "article[contains(@class,'article-layout')]"     ],     "multipage": {         "xpath": "a[@rel='nofollow' and @class='pagination-all-on-one-page__link']",         "append": false     },     "cleanup": [         "div[contains(@class,'article-header__publish-info')]",         "div[contains(@class,'article-actions')]",         "aside[contains(@class,'top-ad-container')]",         "aside[contains(@class,'akwa-ad-container')]",         "section[contains(@class,'article-sidebar')]"     ] }
Why doesnt my  "section[contains(@class,'article-sidebar')]" not work?
I really appreciate any help you can provide.

It does look like it isn't cleaned up but in fact it is. There are two instances of the same content for responsive design reasons. Just add "a-collapse" to your cleanup.

as @de-es has pointed out it's caused by responsive design issues using a catch-all contains xpath looks to be your best bet "*[contains(@class,'collapse-box')]"
{
    "type": "xpath",
    "xpath": [
        "article[contains(@class,'article-layout')]"
    ],
    "multipage": {
        "xpath": "a[@rel='nofollow' and @class='pagination-all-on-one-page__link']",
        "append": false
    },
    "cleanup": [
        "div[contains(@class,'article-header__publish-info')]",
        "div[contains(@class,'article-actions')]",
        "aside[contains(@class,'top-ad-container')]",
        "aside[contains(@class,'akwa-ad-container')]",
        "section[contains(@class,'article-sidebar')]",
        "*[contains(@class,'collapse-box')]",
        "footer"
    ]
}


feat: Multiple admin support

Purpose for this PR
Splits admins into four types:

DAO: role for all other admin roles
SysAdmin: allowed to upgrade contracts
Bond Aggregator: allowed to add bonds to the manager
Bond: ever previous Owner function.

Closes https://github.com/windranger-io/windranger-treasury/issues/162

Still have the UT to test out the permission transferring.
Additional script to change the Bond Admin, Bond Aggregator and SysAdmin from the deployer to specific accounts would be useful (discrete scripts).


Check copyright of files where possible:

This serves as an example for the EXCLUDE option of
ament_lint_auto_find_test_dependencies, allowing to
exclude the default ament_copyright configuration and
running with a custom configuration
See https://github.com/ament/ament_lint/pull/133 and https://github.com/ament/ament_cmake/pull/165

Linux
Linux-aarch64
macOS
Windows


How to achieve lazy loading in an Angular Hybrid Application?

Here is how i am routing my angular 1 controllers:
myApp.config(function($stateProvider, $urlRouterProvider) {
$urlRouterProvider.otherwise('/');
$stateProvider.state('main', {
url: '/',
views: {
mainContainer: {
controller: 'mainController',
templateUrl: 'app/angular1/main/main.html'
}
},
resolve:{
loadMyCtrl: ['$ocLazyLoad', function($ocLazyLoad) {
return $ocLazyLoad.load('app/angular1/main/main.ctrl.js');
}]
}
})..state('calculator', {
url: '/calc',
views: {
mainContainer: {
controller: 'CalculatorController',
templateUrl: 'app/angular1/calculator/calculator.html'
}
},
resolve:{
loadMyCtrl: ['$ocLazyLoad', function($ocLazyLoad) {
return $ocLazyLoad.load('app/angular1/service/service.js').then(function(){
$ocLazyLoad.load('app/angular1/calculator/calculator.ctrl.js');
});
}]
}
})
});
The above part works perfectly. But I now want to lazy load an Angular 2 component with a new state, and also i have to downgradeNg2Component while i am lazy loading that component. Also i am using systemjs. Please let me know if there is anything that can be done.

Here is my demo repo for the same: https://github.com/trafalgarDWaterLaw/Angular-Hybrid/tree/master
can anyone please look into this.  Even though i have tried loading hello.js via oclazyload but it gets loaded during bootstrap itself since the component needs to be downgraded before use. So i trying to find a way to downgradeNg2component while routing to it and not before that. Also in the present scenario whenever i route to angular 2 component Hello(which is already loaded before ) gives Uncaught TypeError: Unexpected anonymous System.register call.  Error even though its get loaded properly. If anybody has any idea on bootstraping the app which can give some kind of solution towards my main problem in a different way, would be most welcome.

@ocombe  can you please guide me, where i am going wrong.

any updates on this?

I am also very interesting in it. We have hybrid application (AngularJS + Angular 4.1.0 + CLI 1.0.1) and we would like to use lazy loading for NG2 part. According to the provided documentation how to bootstrap hybrid application we need to downgrade NG2 components in bootstrap time; but in fact it means that everything should be available in this bootstrap time and lazy loading will not work. Probably there are some advanced techniques how to bootstrap hybrid application if we would like to use lazy loading?

I am also facing the same issue with my hybrid application. Since loading NG2 components at the bootstrap is not a good idea i suppose. @KhalipskiSiarhei do you have a demo repo for the same since i have also used systemjs. would like to see it work in CLI. @ocombe is there a way to downgrade and lazyload NG2 components at the time of routing ?

Hi  @KhalipskiSiarhei can you please share a demo repository for your hybrid app(AngularJS + Angular 4.1.0 + CLI 1.0.1) as upgradeAdapter is deprecated in Angular 4 so I am struggling in bootstraping of the application . Can you please let me know your bootstraping method(i guess upgradeModule needs to be used) or demo repository would be a huge favor. Thanks.

Hi @trafalgarDWaterLaw. Below is an example of main.ts with running hybrid. Nothing special is here, everything is according to the official documentation.
`import { enableProdMode, FactoryProvider } from '@angular/core';
import { UpgradeModule } from '@angular/upgrade/static';
import { downgradeComponent } from '@angular/upgrade/static';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { environment } from './environments/environment';
import { WebAppModule } from './app/webapp.module';
import { WebAppComponent } from './app/webapp.component';
declare var angular: any;
if (environment.production) {
enableProdMode();
}
angular.module('sport.core')
.directive('webappComponentsDir', downgradeComponent({ component: WebAppComponent }) as angular.IDirectiveFactory);
platformBrowserDynamic().bootstrapModule(WebAppModule).then(platformRef => {
const upgrade = platformRef.injector.get(UpgradeModule) as UpgradeModule;
upgrade.bootstrap(document.documentElement, ['sportWebApp'], { strictDi: true });
});`

Thanks a lot @KhalipskiSiarhei  i will try this out.

Here is a set of articles how to do it https://blog.nrwl.io/using-ngupgrade-like-a-pro-lazy-loading-angularjs-applications-469819f5c86
We are still considering it.


Release @google-cloud/firestore v0.17.0

This pull request was generated using releasetool.

Although not bundled in this release, I'd like to make a (breaking) release later to modify the call signature of the library later:
Before:
const firestore = require('@google-cloud/firestore');
const client = new firestore.v1beta1(); // this is in fact FirestoreClient as exported from v1beta1/firestore_client.js

After:
const vision = require('@google-cloud/vision');
const client = new firestore.v1beta1.ImageAnnotatorClient();

Release is at https://github.com/googleapis/nodejs-firestore/releases/tag/v0.17.0


Getting OidcUser out of Authentication object

Im am using the following code to get the OidcUser out of the Authentication object:
Assert.isTrue(authentication.getPrincipal() instanceof OidcUser, "Principal in authentication must be instance of OidcUser but was '" + authentication.getPrincipal().getClass().getName() + "'!");
OidcUser oidcUser = (OidcUser) authentication.getPrincipal();
From time to time I get an assert-exception that authentication.getPrincipal() is of type java.lang.String. Is there a better way to get the current OidcUser?
BTW, I am using spring-security 5.0.8.RELEASE that comes with spring-boot 2.0.5.RELEASE.
...
org.springframework.security:spring-security-config:jar:5.0.8.RELEASE:compile
org.springframework.security:spring-security-core:jar:5.0.8.RELEASE:compile
org.springframework.security:spring-security-oauth2-client:jar:5.0.8.RELEASE:compile
org.springframework.security:spring-security-oauth2-core:jar:5.0.8.RELEASE:compile

@igler You can obtain the Principal using @AuthenticationPrincipal.
@GetMapping("/user")
public String userInfo(@AuthenticationPrincipal OAuth2User oauth2User) {
    ...

or if the oauth2Login() client is configure with an OIDC provider than:
@GetMapping("/user")
public String userInfo(@AuthenticationPrincipal OidcUser oidcUser) {
    ...

I'm going to close this issue as I feel I have answered your question. For future reference, please log this issue with the Spring Security repo. Thanks!

Getting a org.springframework.web.util.NestedServletException: Request processing failed; nested exception is java.lang.IllegalStateException: No primary or default constructor found for interface org.springframework.security.oauth2.core.oidc.user.OidcUser  on one of my tests. The rest is working.

@igler It is quite difficult for me to troubleshoot if I cannot reproduce the issue on my end. To help me, please provide me a link to a repo with the relevant test that fails so I can reproduce and than resolve for you.

Have sent you an invitation.

I checked out that branch and tried running ./mvnw clean test but I get a failure with goal pl.allegro:grunt-maven-plugin:1.5.1:grunt.
What I was really looking for is a scaled down version of the app with detailed steps on how to reproduce the issue (or failed test). The shared repo has too many artifacts. Please provide a scaled down version.

There is a new branch called 'reduced'. A ./mvnw clean test should work and cause the exception.

What is working is @AuthenticationPrincipal OAuth2AuthenticationToken authToken as parameter in controller-method and resolve OidcUser  by manually doing OidcUser oidcUser = (OidcUser) authToken.getPrincipal();

@igler Can you please resend the invite?

Have send the invite again. New project, branch is master now. A ./mvnw clean test should work and cause the exception.

@igler ./mvnw clean test produces the error in ReservationRestTest.createReservationAsNL14User(). However, when I try to debug in the IDE that same test method, it does not run because testFetchingLocations() fails before and createReservationAsNL14User() is dependent on it.
Again, to make things easier for me, I need a very slim app that reproduces the issue. Even if you have to re-create another isolated test on it's own. The current setup has way too much code that really is not efficient for me to help you troubleshoot.
I'm 99% sure your issue is with Spring Web MVC setup and Spring Security integration. To confirm this put a break-point in
org.springframework.security.config.annotation.web.configuration.WebMvcSecurityConfiguration.addArgumentResolvers()
This method should get called which initializes AuthenticationPrincipalArgumentResolver. This is the resolver that resolves @AuthenticationPrincipal controller arguments.
If the WebMvcSecurityConfiguration.addArgumentResolvers() method is not called, which I suspect, that is the reason you are getting that error. I've seen this before and this is the root cause.
FYI, @EnableWebSecurity will @Import SpringWebMvcImportSelector which will load WebMvcSecurityConfiguration.

Have debugged things and WebMvcSecurityConfiguration.addArgumentResolvers() is called. At the end of the method a AuthenticationPrincipalArgumentResolver is added (see attached screenshot).

Putting a breakpoint in AuthenticationPrincipalArgumentResolver.resolveArgument then this is never called during tests. I was thinking that this method is called when one of the parameters @AuthenticationPrincipal OidcUser oidcUser is resolved in one of the controllers.


Add more cascading heat pump models

Description of task
The model data base already contains a lot of single cycle heat pump processes. The task in this issue is to create more true two cycle (that is "cascading") heat pump model classes. The variants of the single cycle heat pumps could be used as orientation.
Necessary steps

Create child class of HeatPumpBase that implements all relevant methods
Create corresponding input parameter file
Create topologie flow sheet as .svg file for light and dark mode
Add the class to the hp_models dictionairy of variables.py

We use the free and open source software inkscape for creating and working with .svg and .pdf files.


Deployment error

Seen in prod:
07-31T00:08:18.676689404Z [INFO]  dshop.utils.deployShop: Shop 114: Preparing data for deploy...
2020-07-31T00:08:20.380949333Z [INFO]  dshop.utils.deployShop: Pinata configured. Adding to the list of pinners.
2020-07-31T00:08:20.381899834Z [INFO]  dshop.utils.deployShop: 📦  Calculating size of /data/dshop-cache/mainnet/celyn/public…
2020-07-31T00:08:20.405855423Z [INFO]  dshop.utils.deployShop: 🚚  Directory /data/dshop-cache/mainnet/celyn/public weighs 10.4 MiB.
2020-07-31T00:08:20.406436513Z [INFO]  dshop.utils.deployShop: 📠  Uploading and pinning to Pinata…
... unrelated logs
2020-07-31T00:09:21.532294637Z This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
2020-07-31T00:09:21.532395281Z Error: Request failed with status code 504
2020-07-31T00:09:21.532416039Z     at createError (/app/node_modules/axios/lib/core/createError.js:16:15)
2020-07-31T00:09:21.532425391Z     at settle (/app/node_modules/axios/lib/core/settle.js:17:12)
2020-07-31T00:09:21.532432322Z     at IncomingMessage.handleStreamEnd (/app/node_modules/axios/lib/adapters/http.js:236:11)
2020-07-31T00:09:21.532449452Z     at IncomingMessage.emit (events.js:203:15)
2020-07-31T00:09:21.532456849Z     at IncomingMessage.EventEmitter.emit (domain.js:466:23)
... unrelated logs
2020-07-31T00:16:12.415287781Z [INFO]  dshop.routes.shops: Shop 114 - Saving config
2020-07-31T00:16:12.430397393Z [INFO]  dshop.routes.shops: Shop 114 - Saving config in the DB.
2020-07-31T00:16:18.197890493Z [DEBUG] dshop.listener: WS ping.
2020-07-31T00:16:28.416067802Z [DEBUG] dshop.listener: New block 10564071 timestamp:<PHONE_NUMBER>
2020-07-31T00:16:36.835389927Z [DEBUG] dshop.listener: New block 10564072 timestamp:<PHONE_NUMBER>
2020-07-31T00:16:37.753991935Z [ERROR] dshop.utils.deployShop: Shop 114: concurrent deployment running. Can not start a new deploy.

See associated row in the shop_deployments table, id 276

This is bound to occur on occasion.  For now, the user is alerted and they can redeploy.  Not sure this warrants being a P1.  Though I do think it's another +1 in favor of async deployments.

My guess is that this exception comes from calling this method:
https://github.com/OriginProtocol/dshop/blob/master/backend/utils/deployShop.js#L233
It's part of the ipfs-deploy package and that uses axios to call Pinata.
See this code.
Sadly it does not seem that package has great error handling/logging so it's hard to tell why the API call to Pinata is timing out... Based on the logs timestamp, it does appear to be a 60sec timeout on the Pinata side.
Looking at the initial small dataset from the DB, it's a pretty high failure rate though. 2 failures out of 29 deploy = 7%.
select count(*), status from shop_deployments where id > 271 group by status;

It's a 504 from Pinata.  There's nothing we can do to look behind that.  There's nothing ipfs-deploy could add to make this any more informative.
If we see a lot of these, we should bring it up with Pinata but I'm not sure this warrants any more attention right now.  The numbers are now 2 of 79.

Just checked and we are not at 2 failures out of 104 since public launch.
dshop=> select count(*), status from shop_deployments where created_at > '2020-07-30 23:00+00' group by status;
 count | status
-------+---------
     2 | Failure
   104 | Success

This is still happening at a rate of about 1% of deploys. For example in the last 14 days:
dshop=> select count(*), status from shop_deployments where created_at > '2020-09-11' group by status;
 count | status
-------+---------
     5 | Failure
   346 | Success

The specific error for this issue hasn't been seen in recent history.  I'm gonna close this and open #810 for general investigation into deployment errors.


Structural Genomics - PATRIC is soliciting community structure requests for proteins that already have a structure

For example, see http://csgid.org/space_tree/view/IDP04376 for a structure that exists and its PATRIC feature page https://www.patricbrc.org/portal/portal/patric/Feature?cId=PATRIC.195103.10.NC_008261.CDS.2820518.2821972.rev&cType=feature telling users to submit a request for a structure.

Checked and verified that no list for submitting structure request are displayed where theer are already structures available.


Fixed the bug #72

The text under "Sign Up with Google" button was changed to "Already have a Space2Study account? Log In!"

Why is this PR not linked to issue?


Show ALL buffers in bufferlist when there are multiple tabs

So I had originally opened issue #639 for this feature, but unfortunately my request was misinterpreted and the functionality that ended up being implemented was not what I originally intended.
Actual Behaviour
Currently the behaviour is such that the airline will show the names of just the buffers that are currently showing in a window in the current tab.
Expected Behaviour
What I desire is an option so that a list of ALL buffers (hidden or not) would be visible. The use-case for this is that I use :bnext and :bprevious nearly exclusively to navigate buffers and I rely on seeing them listed in order on the top bar to know where I'm at, and whether I need to run :bnext or :bprevious to get where I want to go.
Here's how my bar looks without any tabs open, note that even though only two.txt is in a window I can still see one.txt and three.txt listed in the proper order so I know what :bnext will display.

When I open a new tab the list disappears and now all I know is that I've got buffer three.txt open, I no longer know what :bnext will open for me.

I apologize for being late to the party with #639, but I'd still love to see this implemented, let me know if there's anything I can do (though I'm not great at VimL TBH). As it is, I avoid tabs like the plague because it shatters my normal workflow.
Cheers! Have a great day!

I can understand the request, but I think this will get very fast unreadable, since we are probably running out of screen space if you open many buffers.

You can force always showing buffers as follows:
let g:airline#extensions#tabline#show_tabs = 0

But then there won't be an indication of open tabs. How can I achieve what is being show here, but without hiding any buffers on the left?

I just realized this was changed in #1043 to show tabs on the left instead :)
That's really interesting, if you're used to buffers it's much more natural to have tabs on the right, since that way you know which of the "layouts" you're working on, but have the choice to navigate around your open buffers at will...
Anyway, I pretty much reverted e6ab7bdf6d2 and added a tab_nr_type == 3 check to show tab <number> instead of the buffer title. Works for me :tm:


Returning 403 does not redirect to AccessDeniedPath

Returning new HttpStatusCodeResult(StatusCodes.Status403Forbidden) from an action does not redirect to a "forbidden" url. I am using cookie authentication in beta7.

@HaoK can you log a bug in MVC to create a forbidden result that sends a forbid response + 403?

https://github.com/aspnet/Mvc/issues/3242

Is this still an issue for RC1 @HaoK ?
Given the following middleware configuration:
app.UseCookieAuthentication(options =>
{
	options.AutomaticAuthenticate = true;
	options.AutomaticChallenge = true;
});
app.UseOpenIdConnectAuthentication(options =>
{
	options.Authority = Configuration.Get<string>("AzureAd:Authority");
	options.ClientId = Configuration.Get<string>("AzureAd:ClientId");
	options.AutomaticAuthenticate = true;
	options.AutomaticChallenge = true;
	options.SignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
});

//MVC

When the MVC returns a 403 this is "caught" and made into a 302 redirect to the login page (causing endless redirects). My assumption was it would use the default AccessDeniedPath but it seems to ignore it.

@Tratcher any idea on this?

That's odd, we don't intercept 403s, only 401s.
https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication/AuthenticationHandler.cs#L150

I've made the most simple gisthttps://gist.github.com/herecydev/b729403448943f3df5229767e4981c12 I could to demonstrate this.
Given an end user that does not have the claim there, I'm seeing endless redirects.

Oh, MVC isn't setting a 403 anywhere in your gist. It's failing to authorize which triggers another login flow. I think you're hitting this issue: https://github.com/aspnet/Security/issues/667

Ah okay, perhaps I made some assumptions about this, so sorry about that. How exactly does the Authorize attribute work if it doesn't return a 403?

It invokes HttpContext.Authentication.Challenge. For authenticated but not authorized Cookies or Bearer this can produce a 403, but for most of the other auth middleware this causes an infinite loop.

Thanks, I'll keep tabs on the related issue. Hoping this will go into RC2!

No, it's scheduled for post RC2. We're out of time for RC2 features.


Fix build on windows

See stackoverflow for why this is required, related to the gradle daemon.
https://stackoverflow.com/a/34717160/1542667

windows-1252

Typical errors


fix(wallet): ucfirst error strings

Description:
Capitalize payment/transaction error strings
Motivation and Context:

How Has This Been Tested?
Manually - make failed payment / transaction.
Types of changes:
Enhancement
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage increased (+0.02%) to 19.328% when pulling 641f007882a29aadd730f2cf3962da501a900320 on mrfelton:fix/error-case into 59fe33ae310c3a3fe53ffc3719745997fa60b38d on LN-Zap:master.


Polymer needs to be shimmed for use with periodic

Normally, one installs polymer by way of bower. Since we're replacing bower's role in web component management, we need to also build a periodic-friendly version of polymer. We can leave webcomponentsjs as a bower install but polymer itself needs to be shimmed for use.
Since it's not as easy as forking the project and supplementing the repo with a periodic.json, we will probably want to write some custom logic in the tool that downloads a very custom periodic-ready polymer component.
A few things come to mind while thinking about this particular issue but the big one is that we will probably need to extend the tool to allow for any number of different component assets. There will most likely need to be a list of component assets inside the periodic.json used as the registry config in a components repo. That way when periodic finds a component repos periodic.json it has a very clear understanding of assets that need to be downloaded.
I will give this some more thought and create a separate issue if I feel that's the best approach. For now, a polymer shim of some nature is absolutely required for this tool to be considered even remotely useful. High priority.

A really shitty shim has been written and merged; I don't like the code duplication but for now it works.


Mirror from Gitea Instance --> Github

Github doesn't seem to have the ability to mirror repository from elsewhere. But,other Git instances can sync the code with github if implemented,thanks to git. Currently only Gitlab can do it afaik.
Gitlab can automatically sync with github repo,thus setting up mirror repo in github.
https://stackoverflow.com/a/56466021

bublicate of #2280 ... @varsbhat sadly nobody is working on this at the moment ...

If you'd like to push from gitea->github using githooks, here is a guide: https://blog.spacebear.ee/post/mirror-gitea-repos-to-github-via-githook/
Closing as a dupe of the ticket listed above.


Make prober pass through request options

Make the prober adapter pass through the request options, extending with request.

lgtm.


Fresh install fails

Hi,
The component looks awesome, I did encounter some issues when I initially tried to use it.
If there's an easy fix for it, I'd love to hear it, otherwise, I'll have a look at a PR in the weekend.
Two of the attributes a null instead of an object, which causes indefinite load.
 Nova.request().get('/nova-vendor/nova-stripe/stripe/charges', { params: params }).then(function (response) {
                _this.charges = response.data.charges.data; // Fails here because response.data.charges is null
                _this.hasMore = response.data.charges.has_more;
                _this.initialLoading = false;
                _this.loading = false;
            });

_vm._l(_vm.balance.available, function(available) {  // Fails here because vm.balance is null

Nvm, I had completely missed that i needed to add the stripe config to config/services.php


[lib/cereal] Temporarily pause processing of wayward workflows

The processWorkflow event loop has a number of places where errors can
occur. In many cases, the most likely cause of the error is some
transient network problem. In these cases, logging the error, and
retrying may make sense.
Unfortunately, for the case of an unknown workflow event, no amount of
retrying will help. The event types are part of our source code, if we
don't know the event now, we won't know it 10 milliseconds from now
either.
This is especially problematic because it is likely that we'll
continue to select this same workflow event, stopping work on all
other workflows.
This PR attempts to address the problem by temporarily marking such
workflows as "wayward" and removing them from the list of workflows to
select. After some timeout, we start processing them again, in the
hope that the problematic event might have been processed by someone
else.
An alternative would be to drop the event completely. I think that
might make it problematic to add new workflow events in the future.
If a new workflow client is connected and uses some newly introduced
event, we likely want that client to be able to process the event.
Signed-off-by: Steven Danna<EMAIL_ADDRESS>

Added the log line.  Good point on this skipping all workflows of a given type.  Since I think that the cases this accounts for are going to be VERY, I'm OK with that for now.  If we expand its use, we should look into whether we .can improve it to be instances only.


Add wgsmetrics clean

PR checklist

[x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!
branch on the nf-core/test-datasets repository.
[x] Make sure your code lints (nf-core lint).
[x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR> -stub).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

Description of changes
This PR adds an additional QC: computation of coverage statistics for the entire genome and for chromosome Y. This can be used to estimate the sex of the sample (note that calculating the ratio is not included in the PR, but the metrics files can be used to do that).
The coverage is computed with Sentieon WgsMetricsAlgo alternatively Picard's CollectWgsMetrics and is integrated to the qc_bam subworkflow. Since Sentieon WgsMetricsAlgo is a local module, the qc_bam subworkflow was moved to local subworkflows.
The interval list files for Picard's CollectWgsMetrics are provided as assets.
Comment: the subworkflow was not tested for Sentieon yet.

I think in the file qc_bam, we can remove line 54 and in line 55 simply use bam_bai instead of mosdepth_input_bams. Looks they're the same.

@ramprasadn Do you validate @sima-r 's suggestion?

@Gwennid Yupe, I agree with @sima 😄
But it should not be an issue anymore as I had already fixed it my other PR (#277), and I just merged that PR into dev.


Rust support

First of all thanks for this amazing package. I've been using it for a while now and I feel like it upped my production quite a bit. I wondered if you could also add support for Rust now that it's part of the Core Atom package. Thanks :blush:

The core Rust grammar is a tree-sitter grammar, so this will come for free once we get Tree-Sitter support. (Need a resolution to atom/atom#19151)

I see. Then I'll watch that thread instead and close this one. Thanks again :)


Connection loss fix main.py

Any way you can easily add a period after (admin only) in line 91?

Done: https://github.com/bsoyka/brainbot/commit/702be9de9386f954a457801bc6a19a10e325bf6b


[Feature] Consider changing Records endpoints from GETs to POSTs and adding CORS.

🚀 Feature

Change the record related endpoints to post requests.
Add CORS support.
Change testnet3/records/ to a valid json array

Motivation
The record related endpoints from the snarkVM/rest/src/routes.rs files are these ones:

GET /testnet3/records/all
GET /testnet3/records/spent
GET /testnet3/records/unspent

They also receive a viewkey on the request’s body. Although this works when using curl, this prevents any browser from being able to call said endpoints as Javascript does not accept a body in a GET request. Like in this example, when trying to get records from the snarkOS-beacon:

let records_url = "http://<IP_ADDRESS>/testnet3/records/unspent"
fetch(new Request(records_url), {method: 'GET', body: '"MyViewKey'})
// -> Uncaught (in promise) TypeError: Window.fetch: HEAD or GET Request cannot have a body.

Locally changing the endpoints to POSTs solves this.
Furthermore, when locally modifying said endpoints to POSTs, the browser returns CORS errors when doing requests.

Closing as endpoints are now deprecated.


Add a batch_mode flag to VCF scalable queries

Add a batch_mode arg to allow VCF scalable queries to run in batch mode instead of realtime mode.

Would batch_mode=True break the resource_class arg?

Good question. A quick test shows resource_class works for both batch and realtime UDFs.


Some key impl classes have package private constructors without alternatives or ways to construct them (that I can see).

DirectoryStoreFile and DirectoryStoreImpl seem to be perfectly sensible default implementations of the classes. They don't have public constructors (is there some other way to get TorClient up by constructing these indirectly ?).

This is how I am constructing the TorClient (in OSGi).
import com.subgraph.orchid.*;
import org.apache.felix.dm.annotation.api.Component;
import org.apache.felix.dm.annotation.api.Inject;
import org.apache.felix.dm.annotation.api.Start;
import org.apache.felix.dm.annotation.api.Stop;
import org.osgi.framework.BundleContext;
import org.osgi.framework.ServiceRegistration;

import java.io.File;

@Component
public class TorClientComponent {
    @Inject
    private BundleContext bundleContext;

    private ServiceRegistration<TorClient> serviceRegistration = null;
    private TorConfig torConfig;
    private DirectoryStore directoryStore;
    private TorClient torClient;

    @Start
    public void start() throws Exception {
        torConfig = Tor.createConfig();

        File torData = bundleContext.getDataFile("torData");

        if(torData.exists()) {
            if(!torData.isDirectory()) {
                throw new Exception("the tor directory should not be a file");
            }
        }
        else {
            torData.mkdir();
        }

        torConfig.setDataDirectory(torData);

        directoryStore = new DirectoryStoreImpl(torConfig);

        torClient = new TorClient(directoryStore);

        torClient.start();
        torClient.waitUntilReady(10000);

         serviceRegistration = bundleContext.registerService(TorClient.class, torClient, null);
    }

    @Stop
    public void stop() {
        torClient.stop();
        if(serviceRegistration != null) {
            serviceRegistration.unregister();
            serviceRegistration = null;
        }
    }
}

Why not just mimic what is done in TorClient.main(null);
https://github.com/subgraph/Orchid/blob/develop/src/com/subgraph/orchid/TorClient.java#L183
Here is what I did to create a singleton class to wrap the TorClient:
package com.anonyread.util.http;

import com.subgraph.orchid.TorClient;
import com.subgraph.orchid.TorInitializationListener;
import java.net.InetSocketAddress;
import java.net.Proxy;

public class TorClientFactory {
    private static final int PROXY_PORT = 9150;
    private static final String PROXY_HOST = "localhost";
    private static TorClient client;
    private static boolean isStarting = false;
    private static boolean isRunning = false;

    public static TorClient getTorClient(){
        return client;
    }

    public static boolean hasOpenTorTunnel(){
        return isStarting || isRunning;
    }

    public static void openTunnel(){
        if(!isRunning){
            isStarting = true;
            client = new TorClient();
            client.enableSocksListener(PROXY_PORT);
            client.addInitializationListener(createInitalizationListner());
            client.start();
            client.enableSocksListener();
        }
        while(!isRunning){
            try{
                Thread.sleep(1000l);
            } catch(Exception e){
                //swallow
            }
        }
    }

    public static Proxy getProxy(){
        return new Proxy(Proxy.Type.SOCKS, new InetSocketAddress(PROXY_HOST, PROXY_PORT));
    }

    public static void closeTunnel(){
        while(isStarting){
            try{
                Thread.sleep(100l);
            } catch(Exception e){
                //swallow
            }
        }
        client.stop();
        client = null;
        isRunning = false;
        isStarting = false;
    }

    private static TorInitializationListener createInitalizationListner() {
        return new TorInitializationListener() {
            @Override
            public void initializationProgress(String message, int percent) {
                System.out.println(">>> [ " + percent + "% ]: " + message);
            }

            @Override
            public void initializationCompleted() {
                System.out.println("Tor is ready to go!");
                isRunning = true;
                isStarting = false;
            }
        };
    }
}


add Nick Trujillo to Contributors list

following the live twitch stream

This is the error that comes up on the Hacktoberfest website:
"Ineligible Repository
Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR."


New 404 error from Oriely

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

C:\Users\George\Downloads\CISSP>%ytdl% -v
[debug] System config: []
[debug] User config: ['-u', 'PRIVATE', '-i', '--ignore-errors', '-c', '--no-warnings', '--console-title', '--batch-file=batch-file.txt', '--cookies', 'cookies.txt', '-o', '%(playlist_title)s/%(playlist_index)s-%(title)s.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: ['-v']
[debug] Batch file urls: ['https://learning.oreilly.com/videos/owasp-top-10/150320BCRV']
Type account password and press [Return]:
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: none
[debug] Proxy map: {}
[safari:course] Downloading login page
[safari:course] 150320BCRV: Downloading course JSON
[download] Downloading playlist: OWASP Top 10 Security Fundamentals
[safari:course] playlist OWASP Top 10 Security Fundamentals: Collected 33 video ids (downloading 33 of them)
[download] Downloading video 1 of 33
[safari:api] Downloading login page
[safari:api] 150320BCRV/video000: Downloading part JSON
[safari] Downloading login page
[safari] 150320BCRV-video000: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 2288, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

[download] Downloading video 2 of 33
[safari:api] 150320BCRV/video001: Downloading part JSON
[safari] 150320BCRV-video001: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 2288, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

[download] Downloading video 3 of 33
[safari:api] 150320BCRV/video002: Downloading part JSON

ERROR: Interrupted by user

C:\Users\George\Downloads\CISSP>

Description

Downloading from Oreily was never a problem until i came across this. I had downloaded several other videos none had any problems. I use cookies to authenticate as my sign-on is SSO method.

hey @anishkgt could you help me up with setting the cookies for SSO? I tried looking around and can't seem to get it working.


stalking behavior changes on review screen not reflected on forms

Initially I chose. "following me or appearing"
form displayed appropriately. Then changed to approaching/confronting, and the form did not update.

(nondomestic, Chippewa, adults)


Making desktop power switch

Hi, I’m creating a desktop power switch with Homebridge-RPI. I’ve connected a cable from the desktop main board to the Raspberry Pi GPIO for controlling PC power. However, when I use the switch option turned on in HomeKit, the PC starts but shuts down after 3 seconds. I believe the issue is with the duration of power provided. How can I create a toggle(tick) switch in this case? Thank you.

See the Wiki.

I found that if I want to turn on or turn off computer and then I need relay module or extra circuit, not just with gpio pin.

The GPIO pins are 3.3V.  If the computer uses a different voltage for signalling, you would indeed need a relay.

maybe use a levelshifter 74HTC125 to rise the 3.3V raspi output to 5V.

There’s 2 cable from motherboard, + and -. When I make them connect, it gives signal to computer. But not too long, because the computer will turn off forcely. At my experiment, rpi gpio could not do this role(make +, - connect).

You need a relay to close contacts of pc mainboard power on, in homebridge-rpi plugin you can add a device "lock" so you can set the pulse duration for example 1000ms and you get the turn on. It is a good choice to use a relay to keep the PC ground reference separate and avoid ground loops that could damage the PC or RPI.

Thank you, everyone, for the advice. I found a great tutorial video on this topic (https://youtu.be/4o3cGVgE2gI?si=nJJiAWaC1o9vGif6). This method made it possible for me to create a computer power switch without buying a relay or other circuits, and it worked wonderfully!


Plugins ordering: fix plugin should be run after warn plugin

May be we can even find some performance enhancements

Actually, with our current approach they are completely independent: they create their own copies of the files and operate on them. If we are talking about the combined mode (first - fix, then check unfixed warnings) - it's quite a large issue, that we haven't thoroughly considered yet.

@akuleshov7 I think this could be closed


Kernel Selection UI work

Remote jupyter server/Kernel status/Kernel Name component UI - 1 day
Update status based on different events (#8079) - 1 day
On click of server/local show quickpick with server list and ability to type in new one - 1 day
When clicking on kernel, show quick pick with kernel list (including run time etc) - 1 day
Telemetry - 1/2 day
Option to stop kernel (not spec'd, but in this bug #7926) - 1/2 day

Validated. This will ship in our next release.


Edit Wallet Name: The app crashes when we press the 'Next' button of the keyboard.

(next button on iphon's keyboard)

When we go to edit the name of the wallet, the app crashes on pressing the 'Next' button on the keyboard.
It is happening on both ios and android device dev app v2.0.68(412)

Verified this issue on dev app v2.0.68(414)


[DO NOT MERGE] Disable contacts-admin cron job for migration

Disables cron job which triggers the organisations:import rake task.

These changes will automatically update the deploy user crontab when the application is deployed using Jenkins.

organisations:import rake task runs nightly at 3AM and imports a list of organisations from /government/organisations/ API.

Note: this cron job is configured using the whenever gem and not Puppet.

I see the commit has failed the continuous-integration/jenkins/branch check. I will investigate.

Oh no, yet another app that I forgot was an app when we fixed linting everywhere... except here. I'll deal with it shortly and then you can rebase. Sorry!

Thank you @issyl0 👍 !

I don't think we need this anymore as the migration is complete.


Abiyer/skip precheck for akshci

This PR fixes a reference error in the connectedk8s extension.

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)

Thank you for your contribution! We will review the pull request and get back to you soon.


Add support for copying labels from original PR

Summary
Currently the backport config options support defining a list of labels to add to the backport PRs. It would be great to add the ability to define labels that should be copied from the original PR to the backport as well. For example, copying labels that start with Team: from the original PR to the backport. A wildcard-like capability would be important here so we can define that any Team:* labels get copied over but other labels don't, such as the version labels, since they may not all apply to the backport PR.
Motivation
The additional labels would enable us to create reminders in slack with the Github bot if backports for our team are remaining open due to build failures. The email reminders from Github when backports don't get merged are helpful for this already, but it's easier for the emails to get lost/ignored in inboxes so we'd like to enable slack reminders as well.

The additional labels would enable us to create reminders in slack with the Github bot if backports for our team are remaining open due to build failures.

This makes a lot of sense. Your suggested implementation would send reminders for the unmerged backport PRs. While this can be useful, this will miss backports that were never created in the first place. This is often the case when a backport has conflicts.
One example I found for the Security team is this PR. It was supposed to be backported to 8.0, 7.17 and 7.16 but 7.17 and 7.16 failed due to conflicts. The 7.16 label was removed but it looks like it was still intended to be backported to 7.17. This never happened.
You can already find out all of this with existing functionality:
backport --pr-filter 'Team: Detection Alerts' --all --only-missing -n 50 --json --ls | jq

(assumes that you have jq installed). If you want to do this programatically you are better off using the API instead of the cli above.
Let me know if that makes sense and works for you. Will gladly make changes and improvements where needed.

Hi @marshallmain
I'm revisiting this issue again.

A wildcard-like capability would be important here so we can define that any Team:* labels get copied over but other labels don't

Where do you imagine this to be defined? In the .backportrc.json or somewhere else?

Closing due to inactivity. Feel free to comment if this comes up again.


[Bug] useSiteData is broken in v7.0.0-beta.5

Reporting a bug?
useSiteData fails with error asking for <Suspense fallback="..."></Suspense> wrapper, but react-static manual does not mention the requirement.
Environment
$ npx envinfo --system --npmPackages react* --binaries --npmGlobalPackages react* --browsers
npx: установлен 1 в 1.975s

  System:
    OS: Windows 10
    CPU: (8) x64 Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
    Memory: 10.89 GB / 15.94 GB
  Binaries:
    Node: 10.15.1 - C:\Program Files\nodejs\node.EXE
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 42.17134.1.0
    Internet Explorer: 11.0.17134.1

Steps to Reproduce the problem
I am using v7.0.0-beta.5

Choose blank template when running react-static create.

2. Add getSiteData to static.config.js
export default {
  maxThreads: 1, // Remove this when you start doing any static generation
  getSiteData: () => ({
    title: 'MySite!'
  })
}

3. Add useSiteData to src/App.js component (this will require converting it to functional component)
import React, { Component } from 'react'
import { useSiteData } from 'react-static'

import './App.css'
import logo from './logo.png'

const App = () => {
  const { title } = useSiteData()
  return (

          Edit src/App.js and save to reload.

          Learn{' '}

            React
          {' '}
          and{' '}

            React Static

  )
}

export default App

Run your react-static application and open Developer tools. You should see following errors in console:

The above error occurred in the <App> component:
    in App (at src/index.js:19)

Consider adding an error boundary to your tree to customize error handling behavior.

Add a <Suspense fallback=...> component higher in the tree to provide a loading indicator or placeholder to display.
    in App (at src/index.js:19)
    at throwException (react-dom.development.js:19210)
    at renderRoot (react-dom.development.js:20464)
    at performWorkOnRoot (react-dom.development.js:21367)
    at performWork (react-dom.development.js:21277)
    at performSyncWork (react-dom.development.js:21251)
    at requestWork (react-dom.development.js:21106)
    at scheduleWork (react-dom.development.js:20919)
    at scheduleRootUpdate (react-dom.development.js:21614)
    at updateContainerAtExpirationTime (react-dom.development.js:21640)
    at updateContainer (react-dom.development.js:21708)

Expected Behavior
Wrapping App component with <Suspense fallback="Loading, please wait..."></Suspense> fixes the issue.
It seems that react-static/src/bootstrapApp.js tries to do pretty the same, but for some reason it does not.

The bootstrap code only patches the suspense component for SSR. It does not provide a default suspense boundary. The docs may need to state this, but that's intended.
On Apr 2, 2019, 1:08 AM -0600, Vladimir Klimov<EMAIL_ADDRESS>wrote:

Reporting a bug?
useSiteData fails with error asking for  wrapper, but react-static manual does not mention the requirement.
Environment
$ npx envinfo --system --npmPackages react* --binaries --npmGlobalPackages react* --browsers
npx: установлен 1 в 1.975s
System:
OS: Windows 10
CPU: (8) x64 Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
Memory: 10.89 GB / 15.94 GB
Binaries:
Node: 10.15.1 - C:\Program Files\nodejs\node.EXE
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 42.17134.1.0
Internet Explorer: 11.0.17134.1
Steps to Reproduce the problem
I am using v7.0.0-beta.5

Choose blank template when running react-static create.

Add getSiteData to static.config.js
export default {

maxThreads: 1, // Remove this when you start doing any static generation
getSiteData: () => ({
title: 'MySite!'
})
}
3. Add useSiteData to src/App.js component (this will require converting it to functional component)
import React, { Component } from 'react'
import { useSiteData } from 'react-static'
import './App.css'
import logo from './logo.png'
const App = () => {
const { title } = useSiteData()
return (

     Edit src/App.js and save to reload.

     Learn{' '}

       React

     {' '}

     and{' '}

       React Static

)
}
export default App

Run your react-static application and open Developer tools. You should see following errors in console:

The above error occurred in the  component:
in App (at src/index.js:19)
Consider adding an error boundary to your tree to customize error handling behavior.

Add a  component higher in the tree to provide a loading indicator or placeholder to display.
in App (at src/index.js:19)
at throwException (react-dom.development.js:19210)
at renderRoot (react-dom.development.js:20464)
at performWorkOnRoot (react-dom.development.js:21367)
at performWork (react-dom.development.js:21277)
at performSyncWork (react-dom.development.js:21251)
at requestWork (react-dom.development.js:21106)
at scheduleWork (react-dom.development.js:20919)
at scheduleRootUpdate (react-dom.development.js:21614)
at updateContainerAtExpirationTime (react-dom.development.js:21640)
at updateContainer (react-dom.development.js:21708)
Expected Behavior
Wrapping App component with  fixes the issue.
It seems that react-static/src/bootstrapApp.js tries to do pretty the same, but for some reason it does not.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok, I'am closing the issue than.


Async AzureAppConfigurationClient context manager aiohttp.client warnings

Package Name: azure.appconfiguration.aio
Package Version: 1.6.0
Operating System: macOS Sanoma 14.6.1
Python Version: 3.11.9
aiohttp Version: 3.10.5

Describe the bug
This might be similar to the issue 28527, but instead error message I'm getting warning.
I'm trying to get list of configuration settings from AppConfig by using async AzureAppConfigurationClient (context manger) with DefaultAzureCredentials. As a result I'm getting warning message of unclosed aiohttp client session.
Here is the code I'm trying to execute
import asyncio

from azure.appconfiguration.aio import AzureAppConfigurationClient
from azure.identity.aio import DefaultAzureCredential

async def get_configuration_settings():
    credential = DefaultAzureCredential()
    async with AzureAppConfigurationClient(
        base_url="https://***********.azconfig.io", credential=credential
    ) as client:
        conf_settings = await client.get_configuration_setting(
            key="/existing/test/key/1"
        )
        print(f"Single config settings: {conf_settings}")

async def list_configuration_settings():
    credential = DefaultAzureCredential()
    async with AzureAppConfigurationClient(
        base_url="https://**********.azconfig.io", credential=credential
    ) as client:
        conf_settings = client.list_configuration_settings(
            key_filter="/existing/test/*"
        )
        print("List config settings: ")
        async for item in conf_settings:
            print(item)

async def main():
    await get_configuration_settings()
    await list_configuration_settings()

if __name__ == "__main__":
    asyncio.run(main())

Here is the output:
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x1062de7d0>
Single config settings: {'additional_properties': {}, 'key': '/existing/test/key/1, 'label': None, ......}
List config settings:
{'additional_properties': {}, 'key': '/existing/test/key/1', 'label': None, .....}
{'additional_properties': {}, 'key': '/existing/test/key-new/1', 'label': None, ....}
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x1062dc9d0>

To Reproduce
Steps to reproduce the behavior:

Initialise default credential
Initilise async AzureAppConfigurationClient using context manager
Try to list app config settings using filter with existing keys
Try to get configuration settings for an existing key
az login
execute commands async

Expected behavior
Adequate configs returned without warning message.
Properly closing all underlying aiohttp client sessions

Hi @gorun2git , the unclosed session is from credential, you should manually close it or using with keyword. Please follow the examples in this doc: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/identity/azure-identity/README.md#async-credentials

Hi @YalinLi0312, thank you for your quick reply.
It makes sense, I've missed this fact somehow 🤦
With closing session, everything is working as charm. Thank you for checking this and for your help 🙏
Closing the issue.


Added missing Base_Url variable

As is, the code will not work without setting the base url for the subscription. Updated per the Python Face API SDK docs.

@heatherbshapiro,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@heatherbshapiro : Thanks for your contribution to the Azure documentation! The author, @v-royhar, has been notified to review your proposed change.

#sign-off

@JennieHubbard  - I'm not sure if the API changed since I made the PR but the base_uri requires a specific call to  "/detect?", which the SDK used to append on it's own. Apologies for this. Should I make a new PR?
BASE_URL = 'https://westcentralus.api.cognitive.microsoft.com/face/v1.0/detect?'

Hi @heatherbshapiro that is probably best. Can you @mention me in your new pr? That way I will be notified of it and can handle it quickly. :)


On-chain permissioning nodes can't peer when using a non-validator bootnode

Nodes are not able to peer to each other when using on-chain permissioning with a bootnode that is not a validator. In this configuration the bootnode is not a validator and all the validator nodes in the POA network have on-chain node permissioning enabled.
Hypothesis
What appears to be happening is that all the validator nodes are able to connect to the bootnode but not to each other. This appears to be happening because the network is never in sync. When the network is not in sync on-chain permissioning is only able to connect to the bootnodes and so we are not able to connect the bootnodes neighbours or peers.
In the SyncStatusNodePermissioningProvider the hasReachedSync flag defaults to false and will toggle to true when we get an in sync event. We never get a sync status change event because the network state never changes and is stalled because none of the validators are able to connect to each other.
When a validator node is used as a bootnode that node has peer connections to all the other nodes same as in the other case but because it is an IBFT validator it also gossiping IBFT messages. So the same issue with peers still occurs in this case but the network is able to function because all IBFT messages are going via the bootnode using gossip.
Defect Prioritisation
Probability: Frequent. This will always happen in a scenario where IBFT2.0 is used along with a bootnode that is not a validator
Severity: Critical. The network stalls and is unable to produce blocks.

Refer to https://jira.hyperledger.org/browse/BESU-181 for more information

timebox this to 3 days

when this is fixed, need to add a CHANGELOG entry and remove from known issues


Structure public API for ngrx actions for state module

See master ticket: #3318
Depends on #3330

PR: #3359


Run terminates prematurely without error message

Description of the bug
Run stops without results generated or indication of why it didn't finish.
Command used and terminal output
nextflow run nf-core/rnaseq --input pisumSRRs/samplesheet/samplesheet.csv --outdir pisum_NFrnaseqRETRY --bam_csi_index --fasta GCA_024323335.1_CAAS_Psat_ZW6_1.0_genomic.fna --gff GCA_024323335.1_CAAS_Psat_ZW6_1.0_genomic.gff -profile singularity

final lines of output:
[-        ] process > NFCORE_RNASEQ:RNASEQ:DESEQ2_QC_STAR_SALMON    -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MULTIQC_TSV_FAIL_MAPPED  -
[-        ] process > NFCORE_RNASEQ:RNASEQ:PRESEQ_LCEXTRAP          -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MARK_DUPLICATES_PICAR... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MARK_DUPLICATES_PICAR... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MARK_DUPLICATES_PICAR... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MARK_DUPLICATES_PICAR... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MARK_DUPLICATES_PICAR... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:STRINGTIE_STRINGTIE      -
[-        ] process > NFCORE_RNASEQ:RNASEQ:SUBREAD_FEATURECOUNTS    -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MULTIQC_CUSTOM_BIOTYPE   -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDTOOLS_GENOMECOV       -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_TO_BIGWIG_FO... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_TO_BIGWIG_FO... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_TO_BIGWIG_RE... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_TO_BIGWIG_RE... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:QUALIMAP_RNASEQ          -
[-        ] process > NFCORE_RNASEQ:RNASEQ:DUPRADAR                 -
[-        ] process > NFCORE_RNASEQ:RNASEQ:RSEQC:RSEQC_BAMSTAT      -
[-        ] process > NFCORE_RNASEQ:RNASEQ:RSEQC:RSEQC_INFEREXPE... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:RSEQC:RSEQC_JUNCTIONA... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:RSEQC:RSEQC_JUNCTIONS... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:RSEQC:RSEQC_READDUPLI... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MULTIQC_TSV_STRAND_CHECK -
[-        ] process > NFCORE_RNASEQ:RNASEQ:CUSTOM_DUMPSOFTWAREVE... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MULTIQC                  -

Relevant files
execution_trace_2022-07-28_17-06-31.txt
System information
Linux HPC
N E X T F L O W version 22.04.4 build 5706
nf-core/rnaseq v3.8.1

Hi @el239 ! Did you manage to figure out what is going on here?
Be great if you can upload the .nextflow.log (redacted if required) too please

Will close this for now but please re-open if the problem persists.
Please feel free to reach out to us in the #rnaseq channel on the nf-core Slack for pipeline related issues in the future for more real-time help. Thanks!

@el239 How did you solve this issue? I got the same issue.
$ nextflow run /path/to/download/nf-core-rnaseq-3.10.1/workflow/ --input samplesheet.csv --outdir results -profile singularity --genome GRCh38

[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_MARKDUPLICATES_PICARD:SAMTOOLS_INDEX                    -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_MARKDUPLICATES_PICARD:BAM_STATS_SAMTOOLS:SAMTOOLS_STATS -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_MARKDUPLICATES_PICARD:BAM_STATS_SAMTOOLS:SAMTOOLS_FL... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_MARKDUPLICATES_PICARD:BAM_STATS_SAMTOOLS:SAMTOOLS_ID... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:STRINGTIE_STRINGTIE                                         -
[-        ] process > NFCORE_RNASEQ:RNASEQ:SUBREAD_FEATURECOUNTS                                       -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MULTIQC_CUSTOM_BIOTYPE                                      -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDTOOLS_GENOMECOV                                          -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_BEDCLIP_BEDGRAPHTOBIGWIG_FORWARD:UCSC_BEDCLIP      -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_BEDCLIP_BEDGRAPHTOBIGWIG_FORWARD:UCSC_BEDGRAPHT... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_BEDCLIP_BEDGRAPHTOBIGWIG_REVERSE:UCSC_BEDCLIP      -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BEDGRAPH_BEDCLIP_BEDGRAPHTOBIGWIG_REVERSE:UCSC_BEDGRAPHT... -
[-        ] process > NFCORE_RNASEQ:RNASEQ:QUALIMAP_RNASEQ                                             -
[-        ] process > NFCORE_RNASEQ:RNASEQ:DUPRADAR                                                    -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_BAMSTAT                                     -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_INNERDISTANCE                               -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_INFEREXPERIMENT                             -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_JUNCTIONANNOTATION                          -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_JUNCTIONSATURATION                          -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_READDISTRIBUTION                            -
[-        ] process > NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_READDUPLICATION                             -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MULTIQC_TSV_STRAND_CHECK                                    -
[-        ] process > NFCORE_RNASEQ:RNASEQ:CUSTOM_DUMPSOFTWAREVERSIONS                                 -
[-        ] process > NFCORE_RNASEQ:RNASEQ:MULTIQC                                                     -

Test run worked well.
System information
N E X T F L O W
version 22.10.4 build 5836
nf-core/rnaseq-3.10.1


Can't put custom cops into rubocop_todo.yml

No matter what order you put the inherit_from and require in your .rubocop.yml, you still get the warning:
Warning: unrecognized cop MyCop found in .rubocop_todo.yml

Expected behavior
No warning.
Actual behavior
Warning.
Steps to reproduce the problem
$ cat .rubocop.yml
inherit_from:
  - .rubocop-todo.yml
require: custom.rb
$ cat .rubocop-todo.yml
MyCop:
  Exclude:
    - whatever.rb
$ cat custom.rb
class MyCop < RuboCop::Cop::Cop
end
$ rubocop
Warning: unrecognized cop MyCop found in /private/tmp/foo/.rubocop-todo.yml

$ cat .rubocop2.yml
require: custom.rb
inherit_from:
  - .rubocop-todo.yml
$ rubocop -c .rubocop2.yml
Warning: unrecognized cop MyCop found in /private/tmp/foo/.rubocop-todo.yml
$

RuboCop version
$ rubocop -V
0.38.0 (using Parser <IP_ADDRESS>, running on ruby 2.1.2 x86_64-darwin15.0)

Perhaps some issue with the load path or something? Haven't used this in quite a while...

@bbatsov I think it is the fact that the order is "Do all inherit_from and then do all require" regardless of ordering in the rubocop.yml.

My workaround here is just to put the same requires in my rubocop_todo.yml

I just ran into the same issue.

I think it is the fact that the order is "Do all inherit_from and then do all require" regardless of ordering in the rubocop.yml.

I think this is exactly the problem. Would it be possible to do the requires first, and then do all the inherit_froms?

My workaround here is just to put the same requires in my rubocop_todo.yml

That was my immediate reaction too. And it works. But it’s really nice to be able to regenerate the todo file without having to manually add these few lines to the top every time.

This problem was fixed in #3914.


Added restart-verbose option

Added --restart-verbose / -RV option to log the file that causes the
server to restart. This is useful when the server is restarting at
random times (say a hidden file is being created or modified in the
background). It also could allow you to check to see if you set up the
proper watch and ignore directories. This option is separate from full verbose.

Thx! Will check it out as soon as I find some time!

Great! A couple of things to note here, I added this feature based of what was on npm and then realized that this feature was already implemented in verbose mode in the GitHub repo. Since I worked on it already I figured I'd put it up and see if you still wanted it (it could be redundant). If you still want this feature I think it could be simplified by also checking for the restartVerbose flag in this if statement
if (verbose) {
  log("change detected" + (filename ? ": " + filename : ""));
}

So instead of having 2 If statements like this
if (shouldCrash) {
      if (verbose) {
        log("change detected" + (filename ? ": " + filename : ""));
      }

      if (restartVerbose) {
        log("File(s) that caused the restart: " + filename);
      }
}

It would just look like this
if (verbose || restartVerbose) {
  log("change detected" + (filename ? ": " + filename : ""));
}

If you don't want to include this feature too I totally understand too.

I will update this. Thx!


App does not show up on watch

Updated to watchOS 7 and had to re-pair my watch. App does not show up on watch / download even though already purchased.

You closed the issue. Does that mean you got it to work?

Yeah I was dumb. I had to re-add from the watch App Store icon. Not the iPhone AppStore.
Sent from my iPhone

On Sep 22, 2020, at 9:58 PM, Rexios80<EMAIL_ADDRESS>wrote:

You closed the issue. Does that mean you got it to work?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


Audio loops for 3-4 times before playing a song

ℹ Computer information

Spotify version: <IP_ADDRESS>8.g8b7b66c7 (this issue appeared in the previous version, before that everything was fine)
Windows version: 11 Beta Channel (22000.588)
PowerShell version: 5.1.22000.588

📝 Description of the problem

When I play a new song on spotify (patched), it loops around a time frame (usually in the beginning) of the song before playing the rest of the song.
This issue appeared in the previous build but it still exists and wasn't patched in the latest build released hours ago.
Please refer to the attached recording for further clarification.

📷 Screen Recording
https://drive.google.com/file/d/1iTiEOjUDCIq14RQunxO-fpOCtiLntM7o/view?usp=sharing

The problem exists, but this does not apply to the mod, leave your feedback here so that the Spotify developers can fix it faster.

oh alright, upvoted the issue.

This has been fixed in version 1.83.954
Upgrade.


⚠ Bofrost.be has degraded performance

In 1b14f8c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2418 ms

Resolved: Bofrost.be performance has improved in 0cac3d7.


Follow up on 11.4 symbols

This adds testing for error codes and marpa_g_symbol_is_terminal_set() (hence on 11.4 symbols), which required some refactoring that will also help testing subsequent methods.
2 tests fail because marpa_g_error() returns 0 rather than MARPA_ERR_NO_START_SYMBOL after calls to marpa_g_symbol_is_start() and marpa_g_start_symbol() before marpa_g_start_symbol_set():
# wanted: 43
#   seen: 0
not ok 2 - marpa_g_symbol_is_start() error code
# wanted: 43
#   seen: 0
not ok 4 - marpa_g_start_symbol() error code

Thanks!

@rns -- In the above referenced commit I fixed marpa_g_symbol_is_start() and marpa_g_start_symbol().  One is a doc fix, and other a code fix.  I tried to update trivial1.c to run clean for the doc fix, but apparently I don't understand how your calls work, so I gave up.

marpa_g_start_symbol() works ok now.
As for marpa_g_symbol_is_start():
The doc:

Failure values: If sym_id is well-formed, but there is no such symbol, -1. On other failure, -2.

The test:
  is_failure(g, MARPA_ERR_INVALID_SYMBOL_ID, -2, marpa_g_symbol_is_start (g, -1), "marpa_g_symbol_is_start",
    "symbol is not well-formed");
  is_failure(g, MARPA_ERR_NO_SUCH_SYMBOL_ID, -1, marpa_g_symbol_is_start (g, 150), "marpa_g_symbol_is_start",
    "symbol is well-formed, but doesn't exist");

The above works as expected, it's here just to help understanding my test calls (BTW, I'd appreciate your input on how to make them more straightforward, if you have time).
However, when I try to test against this doc passage:

Returns 0 if sym_id is not the start symbol, either because the start symbol is different from sym_id, or because the start symbol has not been set yet.

with
is_success(g, 0, marpa_g_symbol_is_start (g, S_top),
  "marpa_g_symbol_is_start");

before marpa_g_start_symbol_set(g, S_top), the results is:
# wanted: 0
#   seen: -1
not ok 5 - marpa_g_symbol_is_start
marpa_g_symbol_is_start returned 0

which (-1) seems to be incorrect, because S_top is a symbol, which is both well-formed and existing.


trade in levigo (c++/cgo) for goleveldb (pure go)

My only comment was libldbrest/endpoints.go#L204, might want to check the error return value instead of ignoring. Otherwise, :shipit:


fix threadpool_linux open to initialize variables

                            LogError("Failure creating semi_init");

Uuuu, semi!

Refers to: linux/src/threadpool_linux.c:376 in 23581b7. [](commit_id = 23581b7a2485b1db44f0862c8716c1dfa81793c1, deletion_comment = False)

    } while (interlocked_add(&threadpool->state, 0) != 1);

Based on in person discussion this seems to be needing some poetry.

Refers to: linux/src/threadpool_linux.c:194 in 02346a6. [](commit_id = 02346a6b70ab0ae4a1376fc5415225b2e90ed01d, deletion_comment = False)


How do i set up a local webserver?

I really want to play this game. I downloaded the files, but... How do i set up a local webserver?

Nevermind. I figured it out in a Google Search. If you have the same problem as me, use a program called XAMPP.

Hello,
Seems like you figured it out moments before I was going to respond.
I'm going to leave this link here anyways.
How to Set Up a Local Web Server on Windows, Mac, and Linux


OCM-5958 | chore: Move release scripts from Wiki to Git repository

This PR moves the scripts used to manage parts of the ROSA release from our Wiki into the Git repository for the project. Once merged, I will update the wiki to reference these scripts instead.
All scripts have been named (or renamed) to follow the pattern release-<function>.sh
Legacy scripts that are no longer required have been removed.

i'm +1 on this but at least an initial note in hack's README.md would be good imo

i'm +1 on this but at least an initial note in hack's README.md would be good imo

@thomasmckay Good catch. I had completely missed that.

/lgtm

/lgtm


Replaced the dynamic styling in listing.js with class-based CSS approach

Fixes

Fixes #303 by @Murdock9803

Description
This PR uses classList.toggle to replace the JavaScript code's dynamic styling method with a CSS-based method. This handles the visibility of elements based on filters through class toggling and resolves the issue of applying dynamic styles inline.
Technical details

Replaced the dynamic creation of

@SisiVero Why did you close the PR ?


[PDI-19049] - v8.3 : Job/Transformation with .KTR/.KJB extension fails to open from Parent Job reference.

@ssamora
@smmribeiro

:white_check_mark: Build finished in 35m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,engine,plugins/pur/core

:ok_hand: All tests passed!
Tests run: 5053, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 38m 31s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,engine,plugins/pur/core

:ok_hand: All tests passed!
Tests run: 5053, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 36m 1s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,engine,plugins/pur/core

:ok_hand: All tests passed!
Tests run: 5053, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


add codecov.yml

LGTM. However, I'd prefer to rename codecov.yml to .codecov.yml to reduce visual clutter in the main directory. But if you're against that, you can also just merge as it is.


Redux toolkit tree view

name: :book: New/Updated Documentation Content
about: Adding a new docs page, or updating content in an existing docs page
PR Type
This updates the example/tree-view to using Redux Toolkit.
However enzyme testing files are removed.
I wasn't sure how to update the enzyme testing files, and also reading discussion https://github.com/reduxjs/redux/pull/3708 lead me to the conclusion that testing with enzyme with redux is tricky.
What docs page is being added or updated?

Section: https://redux.js.org/introduction/examples#tree-view

Thanks!  Will take a look through this and leave some comments

@markerikson any updates? :)

:'(


FAQ - When should I open registration for my local Coderetreat?

In the answer there's "It’s recommended that you open registration on Thursday, September 22nd..." and then talk why opening registration 1 month before the event is good. I guess the above date was referring to some retreat happened in the past as with this year Sept 22nd - Nov 18th it's almost 2 months.
Should the text be rephrased to something like "It’s recommended that you open registration one month before the event:"?
Or maybe put the date of the GDCR in a config yml in _data and then use it in hero.html (all other places referring to GDCR date if any) and do some magic with Jekyll in order to calculate the date to suggest for opening registrations?

Hi @dlondero!
You're right, any of the options you suggested are viable.
Pull requests are welcome! :smile:

Ok I'll send a PR.

Thank  you, @dlondero!


Update new-azureps-module-az.md

Fixed typo for ADFS

Docs Build status updates of commit 3cb4bda:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-5.1.0/new-azureps-module-az.md
:white_check_mark:Succeeded
View (azps-5.1.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Wrong copyright in assets_generate.go?

https://github.com/kinvolk/lokomotive/blob/8e9c9943b54db5a29cf55167e0c12e30af205afc/pkg/assets/assets_generate.go#L1
If the code in this file was taken from another project (e.g. Prometheus), I believe the copyright notice should mention both that project and Lokomotive. If this is a mistake, we should fix it.

Yes, this code comes from prometheus project. We should add Lokomotive license too then.

on it

So I have a doubt, as both are Apache License, Version 2.0, should we add the whole license again or add like this
Copyright 2018 The Prometheus Authors, Copyright 2020 The Lokomotive Authors and rest of the remaining para?


Add Windows installation

Retarget of #451 to sdf9 for Citadel via cherry-pick.
Copy of description:
Partially addresses https://github.com/ignitionrobotics/docs/issues/117
Is ignition-tools an optional dependency? I saw a warning in CMake but didn’t see it in CMakeLists.txt.
@JShep1

Codecov Report

Merging #463 (35de9b9) into sdf9 (938b541) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             sdf9     #463   +/-   ##
=======================================
  Coverage   86.68%   86.68%
=======================================
  Files          61       61
  Lines        9516     9516
=======================================
  Hits         8249     8249
  Misses       1267     1267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938b541...35de9b9. Read the comment docs.

Codecov Report

Merging #463 (35de9b9) into sdf9 (938b541) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             sdf9     #463   +/-   ##
=======================================
  Coverage   86.68%   86.68%
=======================================
  Files          61       61
  Lines        9516     9516
=======================================
  Hits         8249     8249
  Misses       1267     1267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938b541...35de9b9. Read the comment docs.

Is ignition-tools an optional dependency? I saw a warning in CMake but didn’t see it in CMakeLists.txt.

Yes I believe it's an optional dependency.
Also, my approval doesn't have the permissions to approve merging, perhaps @chapulina or @scpeters can help here?

Is ignition-tools an optional dependency? I saw a warning in CMake but didn’t see it in CMakeLists.txt.

Yes I believe it's an optional dependency.
Also, my approval doesn't have the permissions to approve merging, perhaps @chapulina or @scpeters can help here?

Just fixed typo. Yeah I don't have write access here to merge either.

Just fixed typo. Yeah I don't have write access here to merge either.


WATCH-ONLY WALLET

I want to creat a watch-only wallet with only bitcoin address, is this possible?I think this feature is very important.But I didn't find a way to create a wallet just with address.

That is not possible - only HD wallets are supported. You can however sweep funds from a single key into an HD wallet with the Tools menu.


Fix the CI format issues.

Signed-off-by: youngman<EMAIL_ADDRESS>
Description

This PR fixes #971 #902
Notes to reviewers:
Checklist

[x] DCO signed.
[] Title of the PR starts with area name, e.g. meshery:, mesheryctl:, ui:.

@leecalcote Please take a look

So, cool to see a PR from @spring-bu. 😄

@spring-bu Great work! I had doubt rather calling cache actions multiple times, can we remove the duplications ?

It seems that each job repeats the setup of Go and the setup of Cache. I assume that these tasks do not persist from job to job, is that right?

We have this issue of repetition in each of the jobs as they are defined today, and so I don't think we're compounding the issue.
It would be good to investigate any streamlining that can be done here, @Saim-Safdar @rav121

Thanks for your contribution to the Layer5 community!

Nice

@spring-bu Great work! I had doubt rather calling cache actions multiple times, can we remove the duplications ?

Hi, @kushthedude
The CI configuration contains multiple jobs, and each job is built separately. so, I think that adding a cache to each job will not actually affect it.


:memo: Fix: Generate rest of package reference docs

Description
Bug with calling plugins vite-plugin instead of vite, webpack-plugin instead of webpack, etc.
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #857

PR #858   👈

This stack of pull requests is managed by Graphite.


[proposal] Elegant update and offline of GameServers

Background
Game servers, due to their strong stateful characteristics, have a high demand for graceful shutdown operations. A game server typically needs to wait until data is fully persisted to disk and ensured to be safe before it can be thoroughly removed. Although Kubernetes natively provides the preStop hook, which allows containers to execute specific actions before they are about to shut down, there is a limitation: once the preset time limit is exceeded, the container will have to be forcibly terminated, regardless of whether the data processing is complete or not. In some cases, this approach lacks real gracefulness. We need a more flexible mechanism to ensure that game servers can exit smoothly while protecting all critical states.
OpenKruise has introduced the Lifecycle Hook feature, which provides precise control and waiting mechanisms for game servers at critical lifecycle moments. This allows servers to execute the actual deletion or update operations only after meeting specific conditions. By providing a configurable Lifecycle field, combined with the ability to customize service quality, OKG ensures that the game server's shutdown process is both graceful and reliable. With this advanced feature, maintainers can ensure that all necessary data persistence and internal state synchronization are safely and correctly completed before the server is smoothly removed or updated.
游戏服务器强状态的关键特性使它们对于优雅的下线操作有很高的需求。一个游戏服务器通常需要等待数据被完全持久化到磁盘上并确保安全后，才能进行彻底的移除。虽然Kubernetes原生提供了preStop钩子，允许容器在即将关闭前执行特定操作，但存在一个局限性：一旦超出了预设的时间限制，容器将不得不被强制终止，不管数据处理是否完成。在某些情况下，这种方法缺乏真正的优雅性。我们需要一个更灵活的机制来确保游戏服务器能够在保护了所有关键状态的前提下平滑地退出。
OpenKruise 引入了 Lifecycle Hook 功能，为游戏服务器提供了在关键生命周期节点上的精确控制和等待机制。这使得服务器能失在满足特定条件后，方才执行真正的删除或更新操作。通过提供可配置的 Lifecycle 字段，并结合自定义服务质量的能力，OKG 能够确保游戏服务器的下线过程既优雅又可靠。借助这一进阶特性，维护者可以确保所有必要的数据持久化和内部状态同步在安全无误地完成后，服务器才会被平稳地移除或更新。
Example
(This example will not be runt successfully, because lifecycle has not be exposed yet.)
apiVersion: game.kruise.io/v1alpha1
kind: GameServerSet
metadata:
  name: minecraft
  namespace: default
spec:
  replicas: 3
  lifecycle:
    preDelete:
      labelsHandler:
        gs-sync/delete-block: "true"
  gameServerTemplate:
    metadata:
      labels:
        gs-sync/delete-block: "true"
    spec:
      containers:
        - image: registry.cn-beijing.aliyuncs.com/chrisliu95/minecraft-demo:probe-v0
          name: minecraft
          volumeMounts:
            - name: gsState
              mountPath: /etc/gsinfo
      volumes:
        - name: gsinfo
          downwardAPI:
            items:
              - path: "state"
                fieldRef:
                  fieldPath: metadata.labels['game.kruise.io/gs-state']
  serviceQualities:
    - name: healthy
      containerName: minecraft
      permanent: false
      exec:
        command: ["bash", "./probe.sh"]
      serviceQualityAction:
        - state: true
          result: done
          labels:
            gs-sync/delete-block: "false"
        - state: true
          result: WaitToBeDeleted
          opsState: WaitToBeDeleted
        - state: false
          opsState: None

The corresponding script is as follows. The script performs the following actions:

Acquires the current state of gs from /etc/gsinfo/state and determines whether it is "PreDelete"

If it is PreDelete, it indicates that the current gs should be in the offline phase. It checks whether the data flushing has been completed (in this example, the presence of a file indicates data flushing completion)

If the data flushing is not completed, it executes the data flushing action (in this example, it creates a file)
If the data flushing is completed, it outputs "done" and exits with 1.

If it is not PreDelete, it indicates that the gs has not entered the offline stage. It uses the number of people in the game server to determine whether it should now go offline.

If the number of people on the game server equals 0, it outputs "WaitToBeDeleted" and exits with 1.
If the number of people on the game server is not 0, it exits with 0.

对应的脚本如下。该脚本做了以下动作：

从 /etc/gsinfo/state 中拿到当前gs的状态，并判断其是否为“PreDelete”

若是PreDelete，则说明当前gs应处于下线阶段。判断数据落盘是否完成（这个示例中通过判断文件以文件存在表示数据落盘完成）

若数据落盘未完成，则执行落盘动作（这个示例是创建一个文件）
若数据落盘完成，则输出“done”，并以1退出。

若不是PreDelete，则说明该gs没有未进入下线阶段。以游戏服人数判断当前是否应该下线。

若游戏服人数等于0，则输出“WaitToBeDeleted”，以1退出。
若游戏服人数不为0，则以0退出。

#!/bin/bash

file_path="/etc/gsinfo/state"
data_flushed_file="/etc/gsinfo/data_flushed"

if [[ ! -f "$file_path" ]]; then
    exit 0
fi

state_content=$(cat "$file_path")

if [[ "$state_content" == "PreDelete" ]]; then
    if [[ -f "$data_flushed_file" ]]; then
        echo "done"
        exit 1
    else
        touch "$data_flushed_file"
        echo "WaitToBeDeleted"
        exit 1
    fi
else
    people_count_file="/etc/gsinfo/people_count"

    people_count=$(cat "$people_count_file")

    if [[ "$people_count" -eq 0 ]]; then
        echo "WaitToBeDeleted"
        exit 1
    else
        exit 0
    fi
fi

The process of elegant delete as follow:

The game server is running normally, and the number of players is not 0.
When the number of players drops to 0, set the opsState to WaitToBeDeleted using custom service quality settings.
Through the automatic scaling policy, OKG deletes the GameServer with WaitToBeDeleted opsState. Since the lifecycle hook is configured and the delete-block label wil be set to true, the gs is not truly deleted but enters the PreDelete state, and the data flushing process is triggered by custom service quality.
Once data flushing is complete, set the delete-block label to false using custom service quality to release the checkpoint.
After the checkpoint is released, the PreDelete phase moves into the Delete phase. The gs is then truly deleted.

优雅下线的过程如下：

游戏服正常运行，玩家数量不为0
当玩家数量为0，通过自定义服务质量设置opsState为WaitToBeDeleted
通过自动缩容策略，OKG将该GameServer删除。由于配置了lifecycle hook，delete-block 标签为 true，gs不会真正被删除，而进入PreDelete状态，并通过自定义服务质量触发数据落盘过程。
当数据完成落盘，通过自定义服质量将delete-block标签设为false，卡点解除。
卡点解除后，PreDelete阶段将进入Delete阶段。gs真正被删除。

TODO

Expose the Lifecycle field in GameServerSert.Spec.
Ad "PreDelete" / "PreUpdate" runtime states for GameServer.

so we need to add lifecycle field in CRDs too ?

@chrisliu1995  can i work on this ?

@chrisliu1995  @ringtail 我应该使用 ConfigMap 来存储这个脚本吗？或者我还有其他一些选择
Wǒ yīnggāi shǐyòng ConfigMap lái cúnchú zhège jiǎoběn ma? Huòzhě wǒ hái yǒu qítā yīxiē xuǎnzé

@chrisliu1995 @ringtail 我应该使用 ConfigMap 来存储这个脚本吗？或者我还有其他一些选择

The shell script is a file in container. OKG will be call it periodically. You can check this function in https://openkruise.io/kruisegame/user-manuals/service-qualities/

@chrisliu1995 @ringtail 我应该使用 ConfigMap 来存储这个脚本吗？或者我还有其他一些选择

The shell script is a file in container. OKG will be call it periodically. You can check this function in https://openkruise.io/kruisegame/user-manuals/service-qualities/

@chrisliu1995 So is this proposal complete? Is this resolved? I can make a Pr for this.

@chrisliu1995 @ringtail 我应该使用 ConfigMap 来存储这个脚本吗？或者我还有其他一些选择

The shell script is a file in container. OKG will be call it periodically. You can check this function in https://openkruise.io/kruisegame/user-manuals/service-qualities/

@chrisliu1995 So is this proposal complete? Is this resolved? I can make a Pr for this.

It is completed, you can see the PR: https://github.com/openkruise/kruise-game/pull/162
I can see that you have a willing to contribute to our project. If there are new feats/enhancements to be done, I'll invite you to join. How about it?

@chrisliu1995 @ringtail 我应该使用 ConfigMap 来存储这个脚本吗？或者我还有其他一些选择

The shell script is a file in container. OKG will be call it periodically. You can check this function in https://openkruise.io/kruisegame/user-manuals/service-qualities/

@chrisliu1995 So is this proposal complete? Is this resolved? I can make a Pr for this.

It is completed, you can see the PR: https://github.com/openkruise/kruise-game/pull/162
I can see that you have a willing to contribute to our project. If there are new feats/enhancements to be done, I'll invite you to join. How about it?

Thanks, yeah I wanted to contribute ...  But I was a configMap to store the script, thanks you clarified,I was about to make a Pr.
Would be happy to contribute in any future issues.


Validate specific property with IValidator

In my WPF application, I have a base class with this:
public IValidator<T> Validator;

Validator.Validate(this, propertyName);

It's saying that Validate does not accept 2 parameters, even though intellisense is telling me otherwise.
How would I use a generic IValidator, which will be assigned at runtime to my base class and can validate specific properties?

The methods for validating individual properties are defined in an extension method, so you need to have the 'FluentValidation' namespace imported in order for the compiler to find them.

Yes, I have the import FluentValidation;
I may be SOL... there doesn't appear to be a way (to my knowledge) to utilize a generic IValidator that plays nice with INotifyPropertyChanged in a generic base class for my models. Here's what I have:
using FluentValidation;
using Prism.Mvvm;
using System;
using System.Collections;
using System.ComponentModel;
using System.Runtime.CompilerServices;

namespace SO.Models
{
    public abstract class ValidatableBindableBase<T> : BindableBase, INotifyDataErrorInfo
    {
        public IValidator<T> Validator;

        public event EventHandler<DataErrorsChangedEventArgs> ErrorsChanged;

        public bool HasErrors
        {
            get
            {
                throw new NotImplementedException();
            }
        }

        protected override bool SetProperty<T>(ref T storage, T value, [CallerMemberName] string propertyName = null)
        {
            var result = base.SetProperty(ref storage, value, propertyName);

            if (Validator != null && result && !string.IsNullOrEmpty(propertyName))
            {
                Validator.Validate(this, propertyName);
            }
            return result;
        }

        public IEnumerable GetErrors(string propertyName)
        {
            throw new NotImplementedException();
        }

        public void AttachValidator(IValidator<T> validate)
        {
            if (Validator != null)
                throw new InvalidOperationException("Validator already set");

            Validator = validate;
        }
    }
}

Be nice if I could use the non-generic IValidator, but I recall reading something on codeplex that it wasn't a direction FluentValidation wanted to go.
I'm trying to create a base class so that I don't have to customize each one of my models to get validation with IDataErrorInfo

So this is because of the generics. Your validator is defined as IValidator<T>, meaning it'll only accept a "T" to validate. However, in your SetProperty call, your're passing in "this" to the validator, which isn't an instance of T, but a ValidatableBindableClass<T>. The compiler won't like this.
I'm guessing your classes are defined as class Foo : ValidatableBindableClass<Foo> ?
If so, then you can probably just do a cast and it'll all be fine: validator.Validate((T)this)

Also, regarding the non-generic IValidator, you can do property validation with this. The extension methods aren't available on IValidator, because it's not part of the 'public' API, but you can still do it by passing in an IValidatorSelector. The extensions for property validation are just a wrapper around this. Check out the code for those extensions and it'll show you how:
https://github.com/JeremySkinner/FluentValidation/blob/master/src/FluentValidation/DefaultValidatorExtensions.cs#L814

Yes, that's exactly how I wanted to do it.
I've tried Validator.Validate((T)this, propertyName);
Says it can't convert ValidatableBindableBase to T ... so I tried modifying the class with
... ok stopping mid sentence... I may have it working
    public abstract class ValidatableBindableBase<T> : BindableBase, INotifyDataErrorInfo
        where T :ValidatableBindableBase<T>

Validator.Validate((T)this, propertyName);
Going to look into the extensions you linked to. Thanks!

For anyone coming across this thread, this is the extension method I created:
    public static class IValidatorExtensions
    {
        public static ValidationResult Validate<T>(this IValidator validator, T instance, params string[] properties)
        {
            var context = new ValidationContext<T>(instance, new PropertyChain(), ValidatorOptions.ValidatorSelectors.MemberNameValidatorSelectorFactory(properties));
            return validator.Validate(context);
        }
    }

Maintenance / cleanup: closing this as the question appears to be resolved.


Alternative location for config

Handle the case where the solution is auto-generated - cmake, premake, Genie, etc.
Feels like I've had the .suo options disappear on me a few times, when I've never had time to investigate? - well, even if I'm imagining this, it would be nice for the options to stick even if you decide to delete your auto-generated folder and regenerate things.
Simple idea: hash the normalized path, stick the config in Appdata\Local\P4EditVS\<<sln name>>_<<hash>>.xml, or whatever.  Then put the actual path in the xml somehow. Now you have a fighting chance of finding the xml of interest, if you need to delete it.
Auto-upgrade from .suo somehow.

See also, https://github.com/MBulli/SmartCommandlineArgs/issues/88, perhaps. Fiddling with msbuild stuff sounds a bit involved though.

See also, https://github.com/MBulli/SmartCommandlineArgs/issues/88, perhaps. Fiddling with msbuild stuff sounds a bit involved though.


DragDropContext crashes on drop/setState

This isn't a bug, hoping someone could help me with this. I'm having an crash after I drop my dragSource, in the browser (error in DragDropContext). It's crashing after I'm setting state on the drop, which will populate the dragSource component.
Here is the code : CodeSandbox.io
Still new to React, so I'm unsure what in the  docs I'm missing or if it's a general React mistake.
Any direction or input would be greatly appreciated.
Thanks!

If you take a look at file "Main.js", method "handleDropQuestion".
handleDropQuestion = id => {
    const { templateQuestions } = this.state;
    const question = templateQuestions.find(_q => _q.id === id);
    this.setState(
     prevState => (
        { addedQuestions: prevState.addedQuestion.concat([question]) },  //<-- There's a typo here. You forgot the "s" of "prevState.addedQuestions"
        () => console.log("addedQuestions", this.state.addedQuestions)  //<-- Remove this callback
      )
    );
   ...
};

If we add the "s" and remove the console.log, it should fix the problems and make our app work as expected.
In short:
this.setState(
  prevState => ({ addedQuestions: prevState.addedQuestions.concat([question]) })
);

That'll make it work.
However, it's always good that we make our code more readable, especially when we try to update multiple values in our state.
For example, the code above can be written as the following:
handleDropQuestion = id => {
    const { templateQuestions, addedQuestions } = this.state;
    const question = templateQuestions.find(_q => _q.id === id);
    const updatedQuestions = addedQuestions.concat(question);
    this.setState({ addedQuestions: updatedQuestions });
    ...
};

@SuperChocoman7  Thank you so much for looking this over.


"Unknown ETA" and "Unknown speed" when using local fragments

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.09.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log
(Removed) - would NOT help here, if required can be added
Description
While youtube-dl is using local fragments it says "Unknown ETA" and "Unknown speed" - this is ofc because it is not actively downloading but merely rushing through local fragments (stored via --keep-fragments - it would be better if it could say something like "loading local segments..." to accurately report what's actually happening (which replaces both "Unknown ETA" and "Unknown speed" in that case)
Just an idea.... maybe more of a feature request but it not saying what it's doing (parsing local segments) is kindof a bug... well maybe not... but still sth that should be thought about
alternatively it could say "LocalLoading" or sth similar where it says "download" (at the beginning of the progress/current stage line)

youtube-dl is not using local fragments reassembly for a long time.

Okay that's weird... it definetly is on my end... on both Linux and Windows - or how do you explain the speeding from 0 to 90% when almost all fragments are downloaded... it could only happen if youtube-dl is using fragments stored on the local hard drive....

Again: youtube-dl is not using this approach for more than two years now. Such behavior is only possible if you manually remove main partially downloaded file and .ytdl metafile along with --keep-fragments but you must not do so.


Automated cherry pick of #5353: feature(notify): Add query and return value for contact UPDATE interface

Cherry pick of #5353 on release/2.12.
#5353: feature(notify): Add query and return value for contact UPDATE interface

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@fe2eeaf). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #5354   +/-   ##
==============================================
  Coverage                ?   6.83%
==============================================
  Files                   ?     506
  Lines                   ?   86300
  Branches                ?       0
==============================================
  Hits                    ?    5896
  Misses                  ?   79908
  Partials                ?     496

Flag
Coverage Δ

#aFlag
6.83% <0%> (?)

Impacted Files
Coverage Δ

pkg/cloudcommon/db/usercache.go
4.39% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2eeaf...f4b7e4c. Read the comment docs.

/lgtm

/approve