window.open() should not use InAppBrowser

When including chrome.identity, it pulls in InAppBrowser plugin. IAB clobbers window.open() with its own function. For Chrome Apps, we want the default behviour to always just open in external browser, and not IAB.
This somewhat trades one problem for another, since if someone does want to use IAB, then us reversing it's symbol mapping will prevent them from doing so. So, maybe we should instead do:
window.iabOpen = window.open;
delete window.open

Then at least there is an easy work-around. Note that this will have to be done in mobile.js's bgInit as well, since we map modules into both foreground and background windows.
Will also need to change chrome.identity to use IAB via require(), rather than window.open().

InAppBrowser is useful for authentication flows (OpenID-Connect, SAML, etc) in Cordova apps without needing custom protocols.
I understand the clobbering-issue (and I would actually prefer if this Cordova plugin didn't clobber window.open). Just wanted to chime in and say that I'd prefer if your solution leaves some way of accessing the iab-plugin.
I've opened an issue in Cordova's issue tracker on changing the api:
https://issues.apache.org/jira/browse/CB-8444

The Chrome Apps for Mobile framework has been changed to check for the InAppBrowser plugin, and undo the clobber for window.open.  This change does not copy/preserve the InAppBrowser implementation anywhere.  Instead, CB-8444 has been addressed to provide a uniquely-named API for InAppBrowser as cordova.InAppBrowser.open.  See the plugin docs for more details:
https://github.com/apache/cordova-plugin-inappbrowser
The fix for CB-8444 is not yet released.  Until then, the workaround is to explicitly require the InAppBrowser.  See the chrome.identity plugin as an example.


Added Java-serialization integration test

Added a functional integration test for custom class using Java-based serialization

Looks good. Once last comment left, fix it and ship it.
👍


.gitignore is not being respected

Hello
after running python update_plugins.py the git index seems to want to pick up the files under sources_non_forked and prevents me from doing any git pulls
the index might need a git rm -rf . && git add -A to refresh the tracked files

Facing the same issue for me, below is the output of git status after running python update_plugins.py:
HEAD detached at a7a471a
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   sources_non_forked/ale/ale_linters/r/lintr.vim
	modified:   sources_non_forked/ale/ale_linters/terraform/tflint.vim
	modified:   sources_non_forked/ale/ale_linters/tex/texlab.vim
	modified:   sources_non_forked/ale/autoload/ale/fixers/cmakeformat.vim
	modified:   sources_non_forked/ale/autoload/ale/sign.vim
	modified:   sources_non_forked/lightline.vim/doc/lightline.txt
	modified:   sources_non_forked/vim-fugitive/autoload/fugitive.vim
	modified:   sources_non_forked/vim-fugitive/syntax/fugitive.vim
	modified:   sources_non_forked/vim-gitgutter/doc/gitgutter.txt
	modified:   sources_non_forked/vim-javascript/syntax/javascript.vim
	deleted:    sources_non_forked/vim-snipmate/doc/snipMate.txt

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	sources_non_forked/vim-snipmate/doc/SnipMate.txt

You can also use git stash; git pull; git stash pop 👍


Persists replay data and stats after it finishes [#1575]

How:
(edited after e9efc6c commit)
When a task replay finishes running, the task's stats are stored in the replay.
The user interface for requesting replay data does not change. However, if the user sets the URL query parameter "finished" as true, the finished replay is returned even if the task replay is not running anymore. Assume a replay REPLAY1 has finished:
GET /kapacitor/v1/replays/REPLAY1
{
  "link": {...},
  "id": "REPLAY1",
  "task": "...",
  "recording": "...",
  "recording-time": false,
  "clock": "fast",
  "date": "2017-10-21T23:41:41.933535592+03:00",
  "error": "",
  "status": "finished",
  "progress": 1
}

GET /kapacitor/v1/replays/<replay-id>?finished=true
{
  "link": {...},
  "id": "REPLAY1",
  "task": "...",
  "recording": "...",
  "recording-time": false,
  "clock": "fast",
  "date": "2017-10-21T23:41:41.933535592+03:00",
  "error": "",
  "status": "finished",
  "progress": 1,
  "stats": {
    "task-stats": {...},
    "node-stats": {...}
  }
}

Breaking changes:
None, since the replay user interface remains the as it is now.
Todo:

[ ] confirm if design/idea is good
[ ] documentation
[ ] tests

Required for all non-trivial PRs

[ ] CHANGELOG.md updated
[ ] Sign CLA (if not already signed)

@gpestana The description of how you plan to implement this looks good. The PR needs rebasing so that the diff is of only your changes. Once that's fixed I'll take a look at the code. Thanks!

@nathanielc good call, it should look better now. Added a couple of comments already, so let me know what you think. Thanks!

@nathanielc thanks for the review and suggestions. Updated the code accordingly, as well as the initial commit comment.
The biggest change is that the execution stats of the replay's task are now stored in the Replay KV instead of having a dedicated KV for finished replays. Also the interface for checking the execution stats when the replay is finished has changed to ´GET /kapacitor/v1/replays/?finished=true´.

@gpestana I don't see the changes, you mention. Did you push them up already?

@nathanielc haven't pushed them upstream yet, sorry for the confusion. I've been using the comments as personal Todo points for tracking and to give visibility on what I'm working on. I'm also adding a couple of tests now and updating the docs in addition to the changes mentioned.
I'll try to push the changes tomorrow or during the weekend he latest.

@gpestana Ok, great. Thanks again.

@nathanielc I can get these changes in by tomorrow at around 11am UTC+2. If this is too late, please go ahead with the merge and make the necessary changes. Otherwise I can try to finish it up.
Thanks again for the comments!

That should be fine. Thanks!

@nathanielc I reverted the previous changes and removed the trailing commas from the jsons in the API.md.
I tried to implement the latest suggestions but I couldn't make it work properly. Maybe I didn't understand exactly your suggestion.
I believe the idea is to remove the code that gets the finished replay task's execution stats and stores it from doReplay. Apart from the previous commit approach, I tried to add that code to each and every runReplay functions. But all the values of the finished replay execution stats would always 0 no matter what data would be replayed.
I could use some some suggestions at this point 😄 Thanks!!

@gpestana Attached is a quick patch based of your current PR, it compiles but I haven't tested it. Give it a try and see if it works :)
1614-0.patch.txt

@nathanielc did the changes based on your path code, it does seem clearer this way. Does it look enough to merge? Thanks for the help!!

@gpestana Can you add a CHANGELOG entry? Once that is done I'll merge.

CHANGELOG entry added!
Looking forward helping on another bug/feature or review. Any suggestion? 😄

ok, gotta resolve the conflict. 1sec

Looking forward helping on another bug/feature or review. Any suggestion? 😄

Likewise, there are a few issues that have the label help-wanted, but really any issue is free game. If your unit test framework needs any other features that would also be a good place to start.
Thanks again.


Fail as intended for to short lists

In recent pyiron_contrib dependabot PRs (e.g. https://github.com/pyiron/pyiron_contrib/pull/696), the number of arguments was wrong (different issue) and the action failed (as intended). However, not with the nice massage we intended (see below). This hopefully fixes this.
Run pyiron/actions/update-env-files@main
  with:
    conda-yml: .ci_support/environment.yml
Run pip install pyyaml
  pip install pyyaml
  shell: /usr/bin/bash -l {0}
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: pyyaml in /usr/lib/python[3](https://github.com/pyiron/pyiron_contrib/actions/runs/5111616226/jobs/9188774199#step:3:3)/dist-packages (5.[4](https://github.com/pyiron/pyiron_contrib/actions/runs/5111616226/jobs/9188774199#step:3:5).1)
Run python $GITHUB_ACTION_PATH/../.support/update_environment.py Bump pyiron-base from 0.[5](https://github.com/pyiron/pyiron_contrib/actions/runs/5111616226/jobs/9188774199#step:3:6).3[8](https://github.com/pyiron/pyiron_contrib/actions/runs/5111616226/jobs/9188774199#step:3:10) to 0.5.3[9](https://github.com/pyiron/pyiron_contrib/actions/runs/5111616226/jobs/9188774199#step:3:11)  $GITHUB_ACTION_PATH/../.support/pypi_vs_conda_names.json
  python $GITHUB_ACTION_PATH/../.support/update_environment.py Bump pyiron-base from 0.5.38 to 0.5.39  $GITHUB_ACTION_PATH/../.support/pypi_vs_conda_names.json
  shell: /usr/bin/bash -l {0}
Traceback (most recent call last):
  File "/home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/update_environment.py", line [10](https://github.com/pyiron/pyiron_contrib/actions/runs/5111616226/jobs/9188774199#step:3:12)3, in <module>
    if not matches_dependabot_pattern_for_yaml_update(sys.argv):
  File "/home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/update_environment.py", line 100, in matches_dependabot_pattern_for_yaml_update
    return pattern_is_bump_from_to(list_) or pattern_is_update_requirement_from_to(list_)
  File "/home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/update_environment.py", line 94, in pattern_is_update_requirement_from_to
    ends_in_yml(list_[8])
IndexError: list index out of range
Error: Process completed with exit code 1.

Looks fine, but do we want to double down and raise an error with a custom and extremely descriptive message in the false case?

I am not sure, does it not already raise the descriptive error now? I mean we only know that the input was not as expected and that is what the other massage says as well?

Sure. It's some sort of string parsing here though, right? We could be like "we expected a string formatted like blah blah but got the string {string}" is more detail that might be helpful? I don't feel strongly here though

Sure. It's some sort of string parsing here though, right? We could be like "we expected a string formatted like blah blah but got the string {string}" is more detail that might be helpful? I don't feel strongly here though

This is exactly what you did if these tests fail 😄 I just modified the tests for special patterns and if the len does not fit, a False is the expected answer for a check function.


Cannot install trunk due to sass.rs and common.rs

As the title states, I have just tried installing trunk, so I could test my yew application, and it just does not want to install.
The command I used was cargo install --force trunk, followed by cargo install trunk, both of which come up with the same error. The error is the following:
   Compiling trunk v0.15.0
error: there is no argument named `name`
   --> /home/mircea/.cargo/registry/src/github.com-1ecc6299db9ec823/trunk-0.15.0/src/common.rs:135:29
    |
135 |     tracing::debug!(?args, "{name} args");
    |                             ^^^^^^

error: there is no argument named `file`
   --> /home/mircea/.cargo/registry/src/github.com-1ecc6299db9ec823/trunk-0.15.0/src/pipelines/sass.rs:146:59
    |
146 |                     r#"<link rel="stylesheet" href="{base}{file}"/>"#,
    |                                                           ^^^^^^

error: failed to compile `trunk v0.15.0`, intermediate artifacts can be found at `/tmp/cargo-install7853EH`

Caused by:
  could not compile `trunk` due to 2 previous errors

Is there something I need to update, or run again? It feels like something is wrong, but I don't know exactly what. This is a clean install of cargo, on WSL2.

Fixed the issue by uninstalling rustc, and reinstalling rust through rustup.


about training with multi GPU

hi, i encounter one problem. When i run the code with multiple GPUs distributed on the different nodes on the slurm. I find that I can not execute GPUS on different nodes. I wonder does the code support the distribution on different nodes?

Hi @boxuLibrary, ideally, this project should support multiple-node training since it is built on top of pytorch_lightning. However, I don't have an environment to test that, I can only confirm that this project works fine with multiple GPUs on the same node.
As previously mentioned, have you checked here to ensure all related parameters are correctly set? For example, in your sbatch script, make sure that
#SBATCH --nodes=4             # This needs to match Trainer(num_nodes=...)
#SBATCH --ntasks-per-node=8   # This needs to match Trainer(devices=...)

Besides, make sure that you run this project with srun, as detailed here.

Oh, thank you for your reply. It is real helpful for me.

No worries @boxuLibrary. If you manage to make it work on multiple nodes, feel free to make a pull request (if some codes need to be modified) or leave some notes on this issue (I will pin it so that others can easily refer to it).

Hi @boxuLibrary, on another project I work on, I find it easy to train on multiple nodes with pytorch-lighting; just ensure that num_nodes and devices are correctly set, as indicated in my above response.
Besides, make sure that nodes can 'ping' each other. In my case, I need to set in the sbatch script with export NCCL_SOCKET_IFNAME=XXX, where XXX is the interface name that can be obtained from ifconfig. You will encounter errors like NCCL WARN socketStartConnect: Connect to x.x.x.x failed : Software caused connection abort if the interface is not properly set.
I will find time to test the multiple-node training on this project shortly.


[HxAutosuggest] differentiate between search icon and clear icon using CSS classes

I would like to be able to write CSS selectors that change colors of the icons based on whether the search icon is shown or the clear icon is shown. I don't want to target CSS classes of the icons themselves because they can be changed using the SearchIcon and ClearIcon parameters.

This is more a work-around than a solution, but you can use the :placeholder-shown pseudo selector https://developer.mozilla.org/en-US/docs/Web/CSS/:placeholder-shown
So it would be:
.hx-autosuggest-input-icon {
// styles for clear icon
}
.hx-autosuggest-input:placehoder-shown + .hx-autosuggest-input-icon {
// styles for search icon
}


Update licensing-apps-outside-mxcloud.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


wip - recreate stack overflow error

I have seen a StackOverflowError a couple times in production and was able to recreate it in this unit test. You have to run this test with -XX:MaxJavaStackTraceDepth=100000 to get full stack trace but the important part is below. The issue seems related to garbage collection because it doesn't always happen at same place and if I set breakpoint at debug statement after the first 10000 iterations and then step through debugger (F8) it will get error on next iteration (possibly because garbage collection is disabled during debugging?). Outside of debugger (still running from intellij) it happens for me during the fourth major iteration through 25K users. I tried to recreate this in person-directory since most of the code is from there but it didn't happen. I suspect Caffeine cache used when creating the cachingAttributeRepository might be the difference and I am wondering if they are using weak references or something that builds up but then "can" be garbage collected. There are various reports on-line of stack overflows in Collections$UnmodifiableList.get() and one cause may be continually wrapping an already unmodifiable collection but I haven't found where that is happening in this code. I am still looking into this and hopefully this PR will turn into a fix and this unit test will go away.
	at java.util.Collections$UnmodifiableList.get(Collections.java:1308) ~[?:?]
	at java.util.Collections$UnmodifiableList.get(Collections.java:1308) ~[?:?]
	at java.util.Collections$UnmodifiableList.get(Collections.java:1308) ~[?:?]
	at java.util.Collections$UnmodifiableList.get(Collections.java:1308) ~[?:?]
	at java.util.Collections$UnmodifiableList.get(Collections.java:1308) ~[?:?]
	at java.util.Collections$UnmodifiableList.get(Collections.java:1308) ~[?:?]
	at java.util.Collections$UnmodifiableList.get(Collections.java:1308) ~[?:?]
	at org.apereo.services.persondir.support.BasePersonImpl.buildImmutableAttributeMap(BasePersonImpl.java:75) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.BasePersonImpl.<init>(BasePersonImpl.java:50) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.AttributeNamedPersonImpl.<init>(AttributeNamedPersonImpl.java:38) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.StubPersonAttributeDao.setBackingMap(StubPersonAttributeDao.java:130) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.NamedStubPersonAttributeDao.getPeopleWithMultivaluedAttributes(NamedStubPersonAttributeDao.java:58) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.MergingPersonAttributeDaoImpl.getAttributesFromDao(MergingPersonAttributeDaoImpl.java:53) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.AbstractAggregatingDefaultQueryPersonAttributeDao.getPeopleWithMultivaluedAttributes(AbstractAggregatingDefaultQueryPersonAttributeDao.java:154) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.CachingPersonAttributeDaoImpl.getPeopleWithMultivaluedAttributes(CachingPersonAttributeDaoImpl.java:354) ~[person-directory-impl-1.8.13.jar:?]
	at org.apereo.services.persondir.support.AbstractDefaultAttributePersonAttributeDao.getPerson(AbstractDefaultAttributePersonAttributeDao.java:86) ~[person-directory-impl-1.8.13.jar:?]

Just to rule out a variable, one test would be be compiling and building against a version of person directory that does not use UnmodifiableList; build a version of person-directory locally that swaps out all references of UnmodifiableList to a mutable list to see if that might be the difference.

Yeah I can try that, I will probably also add Caffeine to person-directory and try again to re-create the issue in that project which will make it a little easier to test fixes. In this test I get back a person no matter what person name I pass in but that wasn't happening in person-directory and I want to understand what allows that to happen (possibly the Caffeine cache).

@mmoayyed Take a look at https://github.com/apereo/person-directory/pull/51 when you get a chance. It should fix this issue. This pull request doesn't need to be merged.


Restrict SCO *_ref/s properties by type

Previously we had this in the README as something the schemas can't enforce:

Some Cyber Observable objects' *_ref and *_refs properties must point to specific types of objects (eg. process:image_ref must point to an object of type 'file').

With the 2.0 way of references other observables we couldn't enforce this, but with 2.1 since SCOs are top level objects and have ids that include their type, we can and should enforce these now.

No, we can't enforce these until the deprecated observed-data.objects goes away.


add cart button in rtl theme

i found a problem in products grids for add cart button and review raiting stars in the rtl theme
i change the .actions-primary right to 0 and fixed please check

Thanks. This issue will be fixed in the upcoming release.

please fix contact us css in next update thank you

.footer-top .form.contact .field.name {     margin-left: 3%;   }

I can't reproduce this issue. For me, everything looks correct:

another one in mobile view from left side we have blank area

I came across something
i edited the Breeze Evolution Homepage then save after that i have blank area in left of the screen in mobile view
is yours have this problem ?

Can you inspect this element with browser dev tools and check where it comes from?

i inspect but doesn't find any element i think this is for navigation-wrapper


compliance: worker count default based on CPU count

The default of 10 workers can easily overwhelm a system with a small
number of CPUs. This sets the default the numCPUs + 2, clamped to [2,
10].
Signed-off-by: Steven Danna<EMAIL_ADDRESS>

We might want to factor memory into this calculation as well, but this is a start.


fixed code to adhere to the phpdoc'ed description

@rdlowrey should be ready to land

sorry for slow merge -- E_WEEKEND


bug: decrementing 0 should fail, but it's getting successful transaction

Bug Report
Kakarot version:
when decrementing 0 it normally should get a failed transaction, but actually it is getting a successful transaction.
Current behavior:
while testing that decrement function with a count state 0:
    // Function to decrement count by 1
    function dec() public {
        // This function will fail if count = 0
        count -= 1;
    }

when trying to decrementing from the 0 value, although the state value still remains 0, it is getting a successful transaction, it should fail.
Expected behavior:
when trying to decrementing from the 0 value, the txn should revert with an error like that:
transact to Counter.dec errored: VM error: revert.

revert
	The transaction has been reverted to the initial state.
Note: The called function should be payable if you send value and the value you send should be less than your current balance.
Debug the transaction to get more information.

Steps to reproduce:
I used that contract:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.17;

contract Counter {
    uint public count;

    // Function to get the current count
    function get() public view returns (uint) {
        return count;
    }

    // Function to increment count by 1
    function inc() public {
        count += 1;
    }

    // Function to decrement count by 1
    function dec() public {
        // This function will fail if count = 0
        count -= 1;
    }
}

at the initial state, with count at 0, I tried to call dec(), it got a successful transaction.
Other information:
EVM environment: Kakarot ZKEVM blockchain (Testnet)
Solidity version: 0.8.17
No balance was sent to the contract upon deployment.

why does the note talk about value and payable?
did you try to reproduce on the normal remix evm?

@Eikix I am testing from the "Solidity-by-example" contracts examples, the comments/notes in the contract are from there.
Yes, I tried to reproduce on normal remix, the "Expected behavior" mentioned is from the normal remix evm.

also, the "payable" note from remix I guess it's a default note in some errors, just in case.

I remember that we once used safe_uint256 that was actually raising, but we found out that it was normally the solidity compiler that adds the safe checks and revert and not the SUB opcode.
Actually, running in the playground I do see that it's reverting, but after GT on the result of SUB, not sure exactly what happens for us though. We could add a test into test_counter

just tried rn adding a test to test_counter.py and it doesn't REVERT.
See https://github.com/kkrt-labs/kakarot/pull/767


Fix the logic for the dontneed_reasons variables

Hello @nmdefries, sorry for the delayed update.
Description

Fix the logic for the COVID Symptom Survey dontneed_reason variables.
Define the wave of a given dataset based on the latest wave in the data; without this, the contingency tables wouldn't run.

Changelog
In facebook/delphiFacebook/R/contingency_variables.R:

Fix the logic for the dontneed_reason variables, which should depend only on respondents to V5a, V5b, and V5c. Previously, these variables also included respondents to V5d.
Use the latest wave in the data to determine whether to generate old or new variables. I am not sure how you want to treat these. Without this, create_derivative_columns did not work for me. In this function there is some code to generate variables based on wave, which is not created or passed in anywhere.

😛


Solaris support

Pull Request (PR) description
Fixes for permission startup when running as root user.
Removal of net-tools due to this incorrectly being specified for SunOS.
This Pull Request (PR) fixes the following issues
Fixes #310 - it appears the default user for splunk has changed from root to splunk at some point. The default being root meant not explicitly specifying the user still worked. The resulted in the module config having root, file ownership having root, but the service starting as splunk due to it not being explicitly specified.
Partially fixes #272 - Net-tools removed. On the other issue reported, using the .pkg file, it appears Splunk no longer ship a .pkg format installer. Only .p5p and .Z. I had issues getting .p5p support working because I'm using Solaris zones, and this is incompatible with the way the installer works (Solaris zones need a pkg provider defined in the global zone, and cant install .p5p files without this).
My workaround for the missing .pkg download was to build a .pkg file myself using pkgbuild. Due to licensing I dont think I'm able to distribute the build package but I've put pkgbuild spec file and some instructions in this git repo:
https://github.com/davemcdonnell/splunk-solarispkg
With all of the above I've got splunk forwarder running on Solaris 11.4.45 with splunkforwarder 9.0.0.

Test failing, i'll review, and separate out the fixes in separate commits and make sure tests are passing

I believe I've fixed the tests but unable to 100% verify locally due to some issues getting tests to run (the relevant test to this pull req are passing now).
I've run out of time to get the commits separated out for each individual issue. I wanted to reopen this PR to see if tests pass, and maybe someone can finish it up.

Replaced by:
#334
#335
#336


istioctl experimental describe does not display all weights for weighted routes

Bug Description
I created a virtualservice with multiple weighted routes and found that istioctl x describe service ... only prints out the weights for the first route.
foo.yaml
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: prism
spec:
  hosts:
  - lab20.classroom.superorbital.io
  gateways:
  - prism-gateway
  http:
  - match:
    - uri:
        prefix: /red
    rewrite:
      uri: "/"
    route:
    - destination:
        host: red
      weight: 5
    - destination:
        host: red-v2
      weight: 5
    - destination:
        host: red-v1
      weight: 90

$ istioctl x describe svc red
Service: red
   Port: http 80/HTTP targets pod port 80

Exposed on Ingress Gateway http://<IP_ADDRESS>
VirtualService: prism
   Weight 5%
   /red*

$ istioctl x describe svc red-v1
Service: red-v1
   Port: http 80/HTTP targets pod port 80

$ istioctl x describe svc red-v2
Service: red-v2
   Port: http 80/HTTP targets pod port 80

Sanity check, the envoy config on my ingress gateway seems right, and manual testing seems to distribute the load correctly.
"virtual_hosts": [
              {
                "name": "lab20.classroom.superorbital.io:80",
                "domains": [
                  "lab20.classroom.superorbital.io"
                ],
                "routes": [
                  {
                    "match": {
                      "prefix": "/red",
                      "case_sensitive": true
                    },
                    "route": {
                      "weighted_clusters": {
                        "clusters": [
                          {
                            "name": "outbound|80||red.default.svc.cluster.local",
                            "weight": 5
                          },
                          {
                            "name": "outbound|80||red-v2.default.svc.cluster.local",
                            "weight": 5
                          },
                          {
                            "name": "outbound|80||red-v1.default.svc.cluster.local",
                            "weight": 90
                          }
                        ],
                        "total_weight": 100
                      },

Version
istioctl version
client version: 1.17.0
control plane version: 1.17.0
data plane version: 1.17.0 (5 proxies)

kubectl version --short
Client Version: v1.26.0
Kustomize Version: v4.5.7
Server Version: v1.23.16-gke.200

Additional Information
No response

I'll check it


Instance creation post

Connect instance creation to backend.

post to create instance ( teachers and starting/endingPeriod currently filled with fake values)
expanded instanceCreationRoute to include startingPeriod and endingPeriod to match server requirements
posts to create attainments if instance creation is successfull
refactor to simplify using the SnackPack alerts with custom hook
small UI layout fix in course view (thanks @viivi-uhari)
tests (an example of how to mock a one function from service while keeping the rest normal)

Great Job! Everything seems to work! During the review I also started to think that should we do a refactor branch for changing the components (and file names) from Assignment to Attainment in the end of the sprint or leave this for summer? Also realised that the component CustomAccordion is exported from a file named Accordion.js but it should be CustomAccordion.js instead.

I changed the Accordion file name in this branch. I think we should leave the assignment --> attainment changes to the summer. Refactoring the filenames takes more care with imports and since the sprint is over, better not break anything.


MusicXML Support - Ability to generate MusicXML

It would be cool to be able to import MusicXML files and convert them to MIDI.

Or maybe add option to create MusicXML file as well?

I think if I do this I'll probably make it a separate module/repo.


Cards, Primary Interactive Content Containers, and Nav Bars need dimension effects applied

There is a lot of inconsistency with these effects being applied to cards and containers across the app. Every interactive card and container that contains the primary interactive content on a screen should have the raised dimension effect applied to create consistent visual indicator to user that something is interactive vs passive.

Card components should also have the hover and active effects applied to them consistently, as documented here:

Link to dimension state designs here

This more than likely needs to get broken down into many issues to hit parts of the app at a time, but I wanted to throw this up to get the process started.
In addition, we are going to add a page to the design system to better document these effect styles in one place next week.


Second Torque layer applies even though it shouldn't

Even though you get a message saying that only one torque layer is allowed per map, a second torque layer is applied over the previous one.
To reproduce this problem:

Create a map with a torque layer and set the color to something else than default (not blue)
Create a new dataset from filter
Add new dataset as layer and select torque
Wait for the animation to restart and you should see a new blue torque layer

Duplicated from #3107


Cache repeated MAST search queries using lru_cache

Work is ongoing within astroquery to ensure MAST search queries can be cached in a persistent way (e.g. https://github.com/astropy/astroquery/pull/1634).  The changes needed are non-trivial and may take a bit more time to complete.
In meanwhile, this PR proposes to add a quick & easy improvement by adding the @lru_cache decorator to the search functions.  This is a Python 3 standard library feature which automatically caches the 128 most-recent calls to a function within the lifetime of the kernel (i.e. the cache resets whenever the Python session ends).
It allows repeated search queries to be sped up from seconds to microseconds! See example below...
Before this PR:
In [1]: import lightkurve as lk

In [2]: %time result = lk.search_lightcurve("Proxima Cen")
CPU times: user 476 ms, sys: 69.8 ms, total: 546 ms
Wall time: 2.69 s

In [3]: %time result = lk.search_lightcurve("Proxima Cen")
CPU times: user 156 ms, sys: 4.94 ms, total: 161 ms
Wall time: 1.47 s

After this PR:
In [1]: import lightkurve as lk

In [2]: %time result = lk.search_lightcurve("Proxima Cen")
CPU times: user 486 ms, sys: 69.9 ms, total: 556 ms
Wall time: 2.85 s

In [3]: %time result = lk.search_lightcurve("Proxima Cen")
CPU times: user 6 µs, sys: 1 µs, total: 7 µs
Wall time: 9.06 µs

Oops, tests are failing, in part because we accept unhashable SkyCoord objects as input.
lru_cache only supports hashable types, so the options are:

Abandon this PR.
Re-implement using the memoization package which does support unhashable types.

I'm closing this PR because lru_cache is clearly not the right solution, and I need to learn more about memoization to understand whether it is worth adding this as a dependency.


Need to check for Null cookies in HubIntRestService

In the loop for (final CookieSetting ck : cookieSettings) { we do not check for null entries, so we get an NPE

Fixed in commit


filename with errors, parse & encode problem characters?

When working with 20 or more files it would really halve if svgmin could tell us what file has the issue. Even a line number if possible!
Warning: Error parsing SVG: FILENAME.svg : line :12
Its mostly getting stuck on SVGs from illustrator. Is there a way it could correct the issues before processing it and failing due to errors. The biggest issue seems to be & but when converted to & it works fine.

Added filename to errors. As for line number, that needs to be fixed upstream: https://github.com/svg/svgo/issues/482


Zarinpal sandbox has SOAP-ERROR

Detailed description
Zarinpal sandbox has SOAP-ERROR
Error
SoapFault
SOAP-ERROR: Parsing WSDL: Couldn't load from 'https://sandbox.zarinpal.com/pg/services/WebGate/wsdl' : failed to load external entity "https://sandbox.zarinpal.com/pg/services/WebGate/wsdl"
Environment

PHP 7.3.5
Arch Linux
Laravel 7

#10

does the bug exists only in sandbox mode? please check your network again.
do you use any VPN then sending request to Zarinpal?

I just tested on localhost and my VPN is turned off

I just tested on sandbox mood and my VPN is turned off

my zarinpal sandbox mode  worked true
but get this error in Saman and behpardakht gateway

I think it depends on php version! the php soap works differently in each version.

@aminmohammadmazreali please check if php_openssl is enabled or not? check the php.ini file please.

@ssshojaei please check if php_openssl is enabled or not? check the php.ini file please.

have a same problem ...

@Obka we have not recognized the reason of this problem yet. pull requests will we accepted. please fix it and send pull request.

@khanzadimahdi I did not understand the reason for this problem.
Have you corresponded with ZarrinPal Company?

@Obka No! could you talk about this problem with Zarinpal company and report them this issue?

@khanzadimahdi I reported the problem to them a week ago, but they have not responded yet.  They probably won't answer !!

hmm, take a look at below codes. if you recognize any error please share it with me to resolve the problem.
https://github.com/shetabit/multipay/blob/master/src/Drivers/Zarinpal/Zarinpal.php

i close this issue, if you found any bug, please fork the package and fix the bug, then create a pull request. i will merge it.


set-env is no longer supported

I'm giving this action a try, but set-env now appears to be disabled, so it breaks (https://github.com/actions/toolkit/issues/641).  Any plans to update this action to eliminate reference?

@Joseph-Duty-VA - I am not setting any environment variables in this action. Can be please explain what this issue is, possibly with a screenshot?

sorry, i realized this is against the wrong action- i meant to post this to the extract solution, not the deploy solution.  I'll comment over there


cargo publish can fail after --dry-run succeeded

Problem
In my case, I failed to write a description in my Cargo.toml.  This caused crates.io to reject my upload.
Steps

Make a package with no description
cargo publish --dry-run, observe success
cargo publish, observe failure

Possible Solution(s)
There are many reasons things might go wrong, and the local cargo doesn't know the policy of the remote site.  I think the solution has to be:

cargo publish --dry-run should actually send the package to the repository, to an endpoint which checks rather than ingests
cargo publish --dry-run --offline should not do this.

Notes
No response
Version
cargo 1.65.0-beta.1 (082503982 2022-09-13)
release: 1.65.0-beta.1
commit-hash: 082503982ea0fb7a8fd72210427d43a2e2128a63
commit-date: 2022-09-13
host: x86_64-unknown-linux-gnu
libgit2: 1.5.0 (sys:0.15.0 vendored)
libcurl: 7.83.1-DEV (sys:0.4.55+curl-7.83.1 vendored ssl:OpenSSL/1.1.1q)
os: Debian 10 (buster) [64-bit]

See https://github.com/rust-lang/crates-io-cargo-teams/issues/82

I am going to close this in favour of #5941, as more discussions happened there. If you think they are inherently different, we can re-open this.


GeoJSON layer - this context for option callbacks

Following option callbacks can access GeoJSON layer
instance through this keyword.

pointToLayer
onEachFeature
filter
coordsToLatLng

There are some lack about this pull request. I didn't see geometryToLayer is static function and i'm going to change this. Please ignore first commit of this pull request.

I cannot see why this is needed. Can you illustrate with a use case?

@IvanSanchez use case https://gist.github.com/tugrul/851ed5fa3e435cf9b940

I don't think this is necessary, since you can just use bind to set the context whatever you need.

@mourner using bind can be workaround but not solution. Also i can set option in initializer and access in this scope. Basic principle: Every callback should have context own instance.


AttributeError: type object 'NmtBin' has no attribute 'from_nside_linear'

When trying the first simple example (simple pseudo-Cl computation) given in:
https://namaster.readthedocs.io/en/latest/sample_simple.html
I get the following error:
AttributeError: type object 'NmtBin' has no attribute 'from_nside_linear'
Coming from:
Initialize binning scheme with 4 ells per bandpower
b = nmt.NmtBin.from_nside_linear(nside, 4)
Is this attribute no longer valid?
Thanks in advance for your reply.

Thanks @cscoccola
Could you check that you're using the latest version of the code?
See this issue we closed a couple of months ago: https://github.com/LSSTDESC/NaMaster/issues/88

@cscoccola can I check if you managed to fix this?

@damonge
Hola David,
Actually, I haven't solved it. The problem remains when running the examples in the tutorial:
----> 2 b = nmt.NmtBin.from_nside_linear(nside, 4)
AttributeError: type object 'NmtBin' has no attribute 'from_nside_linear'
I have just installed again the pymaster package with conda:
conda install -c conda-forge namaster
Previously, I had updated the conda manager:
conda update -n base -c defaults conda
I have decided to change the sentence:
b = nmt.NmtBin.from_nside_linear(nside, 4)
by:
b= nmt.NmtBin(nside,nlb=4)
But I would like to know if 'from_nside_linear' should work, and why it's not working in my laptop.
Thanks for your efforts,
Claudia

I had the same issue and reinstalling the latest version solve it.

@yuhants thanks a lot for confirming this.
@cscoccola can you make sure you have no lingering installations of namaster before re-installing the very latest version? Essentially, don't reinstall it until you check that python hasn't found some remaining old version.

I'm gonna close this, but let me know if it persists

Sorry for not replying before. Recently, I've made a new installation of the conda environment, and of all of the packages including namaster, and now it's working. I don't know what the problem exactly was, but now it's solved. Thanks David.

OK, perfect. thanks for letting me know!


Android and iOS support

On the site i can see only angular code and it is written that it is supported on Android and iOS. My question is how it works on Android and iOS.and do we have option of exporting the data of chat. How and where chat will be stored?

We've been building iOS-Swift (private-beta) and Java-Android (private-beta) for ChatEngine


Android Bionic support

Some initial work has been done and #31 will be the rest of it for this repository. It requires a modified Bionic repository too.


Make sure the UI code is sourced from a menu.py file

This makes sure that the UI code happens after Nuke has initialized its own plugins.
This mostly prevents the Cryptomatte icon to go at the top of the left bar, and moves it to the bottom.

Hi Benoit, thank you for this. It undoes some minor changes I just made though, so I'll put this in as soon as that's resolved and I've tested it. Thanks!

The only thing is that for single user setups, it's slightly more complicated to edit 2 files rather than one.
But for studios I think it's better to have a menu.py and a init.py.


domain and subdomain

hello I'm wondering if you can update the root domain and sub domain records at the same time?
Now as far as I know I type porkbun-ddns configfile domain.com and porkbun-ddns configfile domain.com '*'
to update the records for my root domain and then the wildcard one.  Or am I doing something wrong?

No not without a loop / multiple cron jobs, @LunarEclipse363 has a forked were they implemented updating multiple subdomains via python CLI (https://github.com/LunarEclipse363/porkbun-ddns/tree/main).
I wanted to merge the changes back, but I need to adjust some stuff. I opened a draft PR https://github.com/mietzen/porkbun-ddns/pull/20 you can track the progress there.


Unresponsive authentication dialog when trying to install extentions

VSCode Version: 1.49.0-insider
OS Version: macOS 10.14.6 (Mojave)

Steps to Reproduce:

Open VS Code
Go to extension sidebar (extensions are visible)
Choose an extension (e.g. Python), click on green "Install" button
A dialog appears popping down from top of vs code window asking for username and password, with no details on what for. There is a curious amount of whitespace, making me think text is missing. Comparing with similar dialog I've seen at this point on Windows, I'm guessing its a proxy authentication request
"OK" and "cancel" buttons animate when clicked (turn blue), but nothing happens. I'm forced to quit out of VSCode, as I can't get rid of dialog box.

The dialog looks the same as in the closed issue #97199. Similar symptoms also. But, I assume this should have been fixed in the latest insider's build?
Not sure what "environment" vscode pulls proxy information from, but I tried a few things. I've tried with and without setting http_proxy and https_proxy in shell environment before launching code from terminal. I've also tried hand-setting it in the proxy settings. Nothing prevents this problem.

Does this issue occur when all extensions are disabled?: Yes/No

Sounds like a duplicate of #104603, which offers a workaround.

Okay, thanks, installing the old version there seems to have worked. I assume the missing script is installed in the old version, and should stay through upgrades.


etcd level logging

https://github.com/coreos/etcd/pull/2367#commitcomment-9963091
Current etcd logs all things to Stderr. Separate logs into several levels(e.g., warning, info, debug) can make log file easier to read, and give users the control of log verbosity.
For example, when the remote is disconnected, local keeps attempting to build the connection. The details of each attempt can help debug, but the fact that we are attempting to connect to the remote is enough for users to know what is happening.
/cc @barakmich

we are going to use https://github.com/coreos/pkg/tree/master/capnslog

@yichengq Can you please expand the description to provide an example of how this would work?

@philips More description is given.
We will move to https://github.com/coreos/pkg/tree/master/capnslog, and it provides level logging natively.

I would like to see this include HTTP client request logs so I can debug simple things like is etcd seeing a request from my client. Essentially dump the path, verb and client IP.

I think this should be done in etcd 2.1.0. It is rather frustrating to not be able to debug the request logs.

followed up by #2707


Control plane [nodes <- to be removed] provide the core Kubernetes services and orchestration of application workloads.

Control plane nodes provide the core Kubernetes services and orchestration of application workloads.
should read
Control plane provides the core Kubernetes services and orchestration of application workloads.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a445f8cc-6581-ad43-1dba-719a94eda81a
Version Independent ID: 31280746-d8de-91b4-d430-91693c2e869d
Content: Concepts - Kubernetes basics for Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/concepts-clusters-workloads.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@akhassanov
Thanks for the feedback! We are will check and update the document accordingly.

Fixed in PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/140232

@rbschneider Thanks for updating the document, changes will go live once the PR is approved.


vike-react-query withFallback error prop does not include error properties

Using vike-react-query (v0.0.4), I've noticed that no errors caught by withFallback's error boundary seem to have any of their standard properties, other than message.
For example:
withFallback(
    () => {
        useSuspenseQuery({
            queryKey: ["test"],
            queryFn() {
                throw new Error("Test error!", {
                    cause: new Error("Another one!")
                });
            }
        });
        return null;
    },
    {
        Error({error}) {
            console.log("ERROR LOG:", error);
            return null;
        }
    }
);

I would have expected this code to log an object with name, message, cause, and stack properties, but it only has message.
As far as I can tell, the cause of this is because Error keys are not enumerable, so they are ignored in the Object.assign call that creates the error prop. Trying this directly in the console does the same thing - Object.assign({message: "test"}, new Error("Test!")) returns {message: "test"}.

Thank you for reporting the issue!
Fix pre-relased as 0.0.4-commit-7a99687

Thank you for fixing that so quick! Though, it seems the prerelease hasn't gone out to npm?

My mistake, published it now.


Cannot distribute an Archive to App store

I'm getting this message:
Asset validation failed
This bundle is invalid. The value for key CFBundleShortVersionString '0.1.0-dev' in the Info.plist file at 'Payload/POC Demo.app/Frameworks/AzureMapsControl.framework' must be a period-separated list of at most three non-negative integers. Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring (ID: 0ba080a4-0427-455e-b981-0642f6a32dea)

I'm relatively new to XCode development and just need to deploy the iOS app to Testflight. Is this something I can fix? (can't find the package's info.plist anywhere) or this package is not working in the newer XCode 15.4?
Thanks and appreciate any help

This is probably not the best way but solved the issue by finding the info.plist and manually editing it. For anyone with the same problem, this is what I did: after building an Archive file, open Archives, right click your archive file then "Show in Finder". Right click on file "Show Package Contents". Open folder Products, open Applications, right click on the app file and again  "Show Package Contents". Go to folders Frameworks > AzureMapsControl.framework and edit the info.plist there (i changed the 0.1.0-dev value to 0.1.0)

I really think this needs to be fixed from this library itself as it's preventing Codemagic from automatically deploying to App store and forcing us to manually modifying the archive file. The only thing that needs to be done is to change "CFBundleShortVersionString" value from "0.1.0-dev" to "0.1.0" which is a validation requirement from the App store connect.


Returning template variable names

Hi! This is a rather weird request but is there anyway to return the list of of input variables as an array of string or as an object? For a code generation function in my code, I need to map a series of inputs into
a mustache-templated string. The input variables are named exactly the same as the templating variables and will shadow/map to them perfectly and because this needs to be done automatically hence the strange request. Here's an example of what I mean:
Assuming a function Mustache.getTemplateVariablesListAsObject
var pycode = <see below>
Blockly.JavaScript['math_foo'] = function(block) {
  var value_name = Blockly.JavaScript.valueToCode(block, 'NAME', Blockly.JavaScript.ORDER_ATOMIC);
// result would be something like: {value_name: value_name}
var inputList =  Mustache.getTemplateVariablesListAsObject(pycode)

  var code = Mustache.render(pycode,  inputList)
  return code;
};

def hello(foo):
  print foo
hello({{value_name}})

I have been thinking over this for more than an hour and I still can't find a better way to do this. Would be really grateful if you can offer some alternative methods etc.

If I'm understanding you correctly you want something like this
var myTemplate = "{{foo}} is {{bar}}";
var variableNames = Mustache.VariableNames(myTemplate) // ['foo', 'bar']

That's assuming VariableNames went and returned all the variable names from the template. If that's what you want then you could probably hack an implementation using the exposed parse function on the mustache writer.
Here's some code to get you started:
var results = Mustache.parse('{{foo}} is {{bar}}')
                       .filter(function(v) { return v[0] === 'name' })
                       .map(function(v) { return v[1]; });

console.log(results) // ["foo", "bar"]

Note that while it's possible to implement a naive version of this, there is no way to unambiguously extract all tag names, because things like this:
{{# foo }}
  * {{ bar }}
{{/ foo }}

… could mean either {foo: {bar: 'baz'}} or {foo: true, bar: 'baz'}}.

@bobthecow is entirely right in this circumstance. The example i gave would only pull out all the identifier nodes, it would also remove all structure effectively flattening the tree.

@Romanx @bobthecow thanks for your help!

No problem. Good luck :)

I had a similar request, but needed to traverse the tree to find all variable names. Thought I'd share the solution I used if anyone needs a reference.
var parseTree = Mustache.parse('{{#foo}}{{bar}}{{/foo}} {{baz}}');
var variableList = parseTree.reduce(function flattenVariablesFromParseTree(acc, v){
                    if(v[0] === 'name'){
                      return acc.concat([v]);
                    } else if (v[0] === '#') {
                      return acc.concat(v[4].reduce(flattenVariablesFromParseTree, []));
                    } else {
                      return acc;
                    }
                  }, [])
                  .map(function(v){ return v[1]; });
//variableList: ["bar", "baz"]

@nicluo does this also suffer from the ambiguity problem?

Yep. It's inherent in the language spec.

The ambiguity problem is interesting, the docs mention that it would try to find the value in this context and then search the parent's context if no values are found. A bit of investigation got me into this:
{{bar}}
{{#foo}}
  {{bar}}
  {{#foo}}
    {{bar}}
    {{#baz}}
      {{no}}
      {{yes}}
    {{/baz}}
  {{/foo}}
{{/foo}}

var renderString = '{{bar}} {{#foo}}{{bar}} {{#foo}}{{bar}} {{#baz}}{{no}} {{yes}}{{/baz}}{{/foo}}{{/foo}}';
var renderContext = new Mustache.Context({
  bar: 'bar',
  baz: {
    no: 'no'
  },
  foo: {
    bar: 'y',
    foo: {
      bar: 'z',
      yes: 'yes'
    }
  }});

var parseTree = Mustache.parse(renderString);
var variableRefList = [];
var variableNameList = parseTree.reduce(function flattenVariablesFromParseTree(acc, v){
                    // Skip non-name or non-# tags
                    if(v[0] !== 'name' && v[0] !== '#'){
                      return acc;
                    }

                    var paths = [v[1]].concat(this.parents.slice(0).map(function(e){
                      return [e, v[1]].join('.');
                    }));

                    // Pops available context until a value is found
                    var path;
                    while(path = paths.pop()){
                      if(renderContext.lookup(path)){
                        //push to advanced list
                        variableRefList.push(path);
                        contextFound = true;
                        break;
                      }
                    }

                    if(v[0] === 'name'){
                      return acc.concat([v]);
                    } else if (v[0] === '#')  {
                      if(typeof renderContext.lookup(path) === 'object'){
                        this.parents = this.parents.concat([path]);
                      }

                      return acc.concat(v[4].reduce(
                        flattenVariablesFromParseTree.bind({
                          parents: this.parents
                        }), []));
                    }
                  }.bind({parents: []}), [])
                  .map(function(v){ return v[1]; });

//variableNameList: ["bar", "bar", "bar", "no", "yes"]
//variableRefList: ["bar", "foo", "foo.bar", "foo.foo", "foo.foo.bar", "baz", "baz.no", "foo.foo.yes"]
//Mustache.render(renderString, renderContext): bar y z no yes

The example is very contrived, and there are many tricks used to stay concise, but it should show how difficult I find it is to reinvent the wheel. Cheers

@Immortalin Can you elaborate / provide a better definition of the problem? What happens with properties nested in objects? Can you provide a more complete input and output?

@dasilvacontin the project that requires thus feature is currently on hiatus so I am going to close this for the time being

Simple solution to get just the top level:
Mustache.parse(template).filter(function(v) {  return v[0] === 'name' ||  v[0] === '#' ||  v[0] === '&' }).map(function(v) { return v[1]; });


System space is not loaded

from a clean install of the portal using cuisine, trying to login:
<IP_ADDRESS> - - [2016-06-10 09:17:17] "GET /system/.files/css/flatTheme.css HTTP/1.1" 500 161 0.008934
path:system/.files/img/favicon.png
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/gevent/pywsgi.py", line 884, in handle_one_response
    self.run_application()
  File "/usr/local/lib/python3.5/dist-packages/gevent/pywsgi.py", line 870, in run_application
    self.result = self.application(self.environ, self.start_response)
  File "/usr/local/lib/python3.5/dist-packages/werkzeug/wsgi.py", line 648, in __call__
    return app(environ, start_response)
  File "/usr/local/lib/python3.5/dist-packages/beaker/middleware.py", line 155, in __call__
    return self.wrap_app(environ, session_start_response)
  File "/usr/local/lib/python3.5/dist-packages/JumpScale/portal/portal/auth.py", line 38, in __call__
    result = self.app(env, my_response)
  File "/usr/local/lib/python3.5/dist-packages/JumpScale/portal/portal/PortalServer.py", line 47, in wrapper
    result = func(self, env, start_response)
  File "/usr/local/lib/python3.5/dist-packages/JumpScale/portal/portal/PortalServer.py", line 661, in router
    sploader = self.spacesloader.getSpaceFromId(space)
  File "/opt/jumpscale8/lib/JumpScale/portal/portalloaders/LoaderBase.py", line 21, in getLoaderFromId
    raise RuntimeError("Could not find loader with id %s" % id)
RuntimeError: Could not find loader with id system

core8 at : c4b02e4812374b5acc12150a41058869218bec3c
portal8 at : 08702b1dde90e3d36f2053837ab87f05aa8a648a

Was this at the time splitexit was broken and wiki != .wiki ?

Looks that way.


merge

Seems empty: https://github.com/bergie/VIE/pull/54/files

Indeed, that's what I meant in my mail.. there were no conflicting files
between your and my repository.. I could try to merge with the liip repo
but I thought you did that already..
On 14 November 2011 15:58, Henri Bergius <
<EMAIL_ADDRESS>
wrote:

Seems empty: https://github.com/bergie/VIE/pull/54/files

Reply to this email directly or view it on GitHub:
https://github.com/bergie/VIE/pull/54#issuecomment-2731302

On Mon, Nov 14, 2011 at 5:09 PM, Szaby Grünwald
<EMAIL_ADDRESS>wrote:

Indeed, that's what I meant in my mail.. there were no conflicting files
between your and my repository.. I could try to merge with the liip repo
but I thought you did that already..

Ah, sorry. I meant Sebastians repo, not yours.
--
Henri Bergius
Motorcycle Adventures and Free Software
http://bergie.iki.fi/
Jabber<EMAIL_ADDRESS>Microblogs: @bergie

Closing as empty


Multiple Y axis, domain changing,

Hello !
I'm currently using react-stockcharts for a big professional projet to display data sent via WebSocket. I particulary need LineSeries, and I am working with DataSeries. I'm fairly new to Javascript (and thus D3JS,  React) programming, and i have some questions:

Is it possible to fix the maximum / minimum ticks values for an axis? I currently have a dirty workaround, which is to return undefined when the value exceeds my limit. It isn't great because if I don't get a value thas is close to the limit, my Y axis won't display this limit (except if I construct a fake point to reach this limit).

Here I want my Y axis to be limited to the value 10 :
yAccessor={(d) => d["value"] > 10? undefined : d["value"]}

Is there a clean way to display several Y axis ? I know that you can put one on each side, and I also tried to specify a number a pixels, for example YAxis axisAt=40 orient="right" ticks={2}, but the problem is that it overlaps the Chart and its curves.

I can have Time based data that are related to each other, (for example, displaying the tweets per minutes about individuals), but I want several X axis (so I can compare the TPM about Justin Bieber during the 25th December, and the TPM about Celine Dion during the 3rd May). Unfortunately, I have an xAccessor on the Chart with multiple DataSeries to specify yAccessor but not the other way around. I had some ideas to bypass this problem by making one Chart per X axis, repeating the Y axis for each Chart, and hiding all of them except one. Is there an other way to proceed?

I hope I was not confusing, English is not my native language.
Thanks.

RE:

Is it possible to fix the maximum / minimum ticks values for an axis? ...

when you say

Y axis to be limited to the value 10 :

what do you want to see on the chart when there is an item which has a larger value?
RE:

Is there a clean way to display several Y axis ?...

I am not following why the axisAt is not good, you could set it at different pixel values, here is an example with multiple yaxis all on the right side. does this help?
RE:

I can have Time based data that are related to each other...

So I understand what you are asking, you want to be able to see the yValue of 3rd May and 25th Dec for 2 different yAccessor, sort of like shifting the xAxis of one series so you can match up with another series?

Wow thanks for the fast reply

what do you want to see on the chart when there is an item which has a larger value?

I want the user to guess there are higher value items (the curve increases up to the limit) to eventually  decrease back to a visible item.

I am not following why the axisAt is not good, you could set it at different pixel values, here is an >example with multiple yaxis all on the right side. does this help?

Yes exactly, I don't know why I must have messed it up, thanks. I tried to put them on the left side, maybe it is related? I need to test that again

So I understand what you are asking, you want to be able to see the yValue of 3rd May and 25th >Dec for 2 different yAccessor, sort of like shifting the xAxis of one series so you can match up with >another series?

Exactly ! To see the variations between 2 set of datas that occured at different times.

RE:

Is it possible to fix the maximum / minimum ticks values for an axis? ...

That should be possible by creating a custom indicator, and provide a domain with the min and max value that you need. A little bit more of coding, needed to override the default behavior which will fit the max and min values of all the yAccessors in that Chart. An example would be the RSI series, where the domain always has to be between 0 and 100.
https://github.com/rrag/react-stockcharts/blob/master/src/lib/indicator/RSIIndicator.js#L71-L73
there is some documentation on how to create custom indicators. If you still have trouble with this, I will be happy to help.
RE:

I can have Time based data that are related to each other...

That is not possible, but I wonder how what you say will be helpful?
I can understand if say you want to compare the number of houses sold by month, over 5 years, and you want each year to be a different series, you will compare
Jan 2010 with Jan 2011 and Jan 2012 ...
Feb 2010 with Feb 2011 ...
what you explain is different, I have not seen any charts which does that. any examples in the wild, so I can better understand how that visualization will be helpful.
Though not what you are asking, have you considered using the CompareSeries instead? it would give you a % increase over time.

what you explain is different, I have not seen any charts which does that. any examples in the wild, so I can better understand how that visualization will be helpful.

Yep, I havn't seen such examples either, but the users will need that. For example, being able to compare sales in December between any other month that don't include Christmas.
I have tested to put 2 X axis, one on the top and one at the bottom, but after enabling Zoom with:

the others X axis seem to be copies of the X axis of the mainChart, when focusing the graph. I have reproduced this problem [here] (http://plnkr.co/edit/P917KwQImKxVAyWnAy8x?p=preview) .
When focusing the graph, the problem occurs.
I had an other trouble that I could'nt reproduce with this plunker, it's that when I focus the graph, the graph disappears (and there are no console errors, unfortunately). I suspect that's because my array of data can be incomplete (I can have a different number of points for each curves, so the points at the end of the array can be undefined), do you have any idea ? I don't think I messed up with the mainChart Id.
An other question, I don't understand why, when removing the following line from here
dataTransform={[ { transform: StockscaleTransformer } ]}
The ChartCanvas disappears. Why is the transformation needed here?
Thanks.

the others X axis seem to be copies of the X axis of the mainChart, when focusing the graph. I have reproduced this problem here .

each Chart has a pair of scales xScale & yScale currently all the Charts will share copies of the same xScale and these scales are calculated on zoom, pan, and a few other actions. So when you zoom or pan here, the scales are recomputed and both Charts get the same xScales this is expected behavior. However I am looking to create a different type of chart where the xScale can be computed for each chart, for something like volume profile, but even that wont fit your need of shifting the same data

I had an other trouble that I could'nt reproduce with this plunker, it's that when I focus the graph, the graph disappears

onmousedown => panStart is triggered
onmouseup => panEnd is triggered
onpanend recalculates the scales for the data you are currently seeing on screen, I am not sure what the problem is, without seeing it on a plunker. I am happy to help if you provide a plunker or point me to a public repo with the issue.

An other question, I don't understand why, when removing the following line from here

stockscale is explained here if you remove the stockscale each Chart needs an xAccessor, Stockscale provides the xAccessor implicitly, to all its children, if you see your AreaChart example earlier, that does not have stockscale but has an xAccessor on each Chart.
This needs a better error message to be logged on console.

it's that when I focus the graph, the graph disappears

stockscale is explained here if you remove the stockscale each Chart needs an xAccessor,

Well, silly me, thanks.
Is there somewhere you explain how to "build" your git repo? Because I have no idea how to do it, "npm install" just seem to download all source code & dependency, but I wonder how to "build" the sources (under /lib) once I modify them into dist/react-stockchart.js ... Because what i'm doing now is modifying react-stockchart.js, but it feels really bad (especially when I want to do an other Indicator...)
One question I should have asked earlier : how do I use stockcharts to display asynchronous data? I managed to kind of do it, but it feels clumsy to me.

I want 3 curves, one for each type of Y (ep1value, ep2value ep3value).
As you can see, I have "valueX" as my timestamp and "ep1value", "ep2value", "ep3value" my Ys for my 3 yAccessors. to each valueX there are at least one "epXvalue".
The first problem I have with that, it's I have to tell, for each yAccessor, wether or not it has an Y:
For example, here would be the accessor for my curve representing ep1value :
yAccessor = {"ep1Value" in d? d["ep1Value"] : undefined}
The second problem, Is that when a point undefined, the "pencil is lifted", the curve is "cut". I just had to modify Line.js drawOnCanvas to avoid interrupting the drawing :
if (yAccessor(d) === undefined) { 			return ; }
I am not sure it is the proper way to do, is there a way to assign to each yAccessor its own array?
The third problem, is if I want each epXValue to have their own Y axis, I didn't manage to it any other way than giving each yAccessor its own Chart, but it poses multiple problems, such as zoom, X axis not being the same...

Based the way you have structured the data, can you confirm if this is true?

index
valueX
ep1ValueY
ep2ValueY
ep3ValueY

rawData[0]
Jan 01 1970 00:00:00

0

rawData[1]
Jan 01 1970 00:00:30
somevalue

rawData[2]
Jan 01 1970 00:01:00

somevalue

rawData[3]
Jan 01 1970 00:01:30

0.008

rawData[4]
Jan 01 1970 00:02:00
somevalue

rawData[5]
Jan 01 1970 00:02:30

somevalue

rawData[6]
Jan 01 1970 00:03:00

somevalue

in other words, is your data for say ep3ValueY not continuous? but has gaps?

Is there somewhere you explain how to "build" your git repo?

refer to CONTRIBUTING.md
Also for creating a custom series, you don't need to start from the stockcharts codebase, you could create then as part of your app and then include it.
Closing this issue as these are not issues I see with the library, but general questions, I am happy to continue the discussion here or even better in the gitter chatroom.

in other words, is your data for say ep3ValueY not continuous? but has gaps?

Yes. this is due to the fact that datas have milliseconds precision, and different gaps between 2 values (one data can have one value every 20 milliseconds, an other data will have a value every 10 seconds, etc. ). Ideally, I would have done one array of arrays, with each array representing all the values (x,y) of one curve, because there is a low probability that I will know the Y of more than one curve for an X.

open http://localhost:8090 in a browser

That's probably what I missed, I suppose the javascript builds itself inside /dist only if i do this step. I'm not used to this kind of thing :)

Also for creating a custom series

Yes, I did just that for the custom indicator for fixing the domain, it works perfectly, thanks !

the gitter chatroom.

Well I'm a github newbie too, couldn't find a link to your chatroom, I would be interested !

https://gitter.im/rrag/react-stockcharts


added getters for renderer and scene

Thank you very much for this addition, makes perfect sense!
I will release 1.3.0 with this in a few minutes

Landed in 1.3.0 - thank you very much, again!


Issue/3076 fix memory leak introduced by using rlu cache

Description
Problem:
lru-cache keeps strong references to cached items.
Solution:
Use a dictionary as a cache in each instance so that the memory is freed when this instance gets garbage collected.
Part of #3076 [ISO5, master]
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in e034212a3583b3f40f0123510d19dba1b82fa45b

This branch was not deleted as it seems to still be in use.

Processing #4198.


[Container Apps] Fix issue in Cloud Build when code relies on UTF-8 logs

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[x] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Container Apps

Closing as tracked as another PR


MWPW-160940-sort dialog popup overlaid fix

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.53%. Comparing base (98af49c) to head (c72b00e).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #110   +/-   ##
=======================================
  Coverage   83.53%   83.53%
=======================================
  Files          10       10
  Lines        3212     3212
=======================================
  Hits         2683     2683
  Misses        529      529

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: making keys fresh oracles complete

To re-enable the constraints of authwit and public key I first needed to clean up the key lib.

#6171  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite


Axona fixes

Corresponding issue: https://github.com/catalystneuro/nwb-conversion-tools/issues/165
Motivation
The Hussaini lab would like to be able to convert data from Axona to nwb, which can reasonably be done in several ways. The Axona format can be split into two major categories:

Raw mode = A single .bin file and a .set file.
Unit mode = Tetrode files (.X), eeg files (.eegX or .egfX), position data files (.pos).

All files in unit mode are derivatives of the .bin file in raw mode.
The lab already has tools to convert raw data to unit mode.
To keep things relatively simple, but to also allow for flexibility in what data to convert to NWB there are a few NWBConverters in this PR that convert various combinations of spiking data, lfp data and position data.
How to test the behavior?
See Axona_to_nwb_conversion.ipynb in tutorials folder.
Checklist

[x] Have you checked our Contributing document?
[x] Have you ensured the PR description clearly describes the problem and solutions?
[x] Is your contribution compliant with our coding style? Read about PEP8 and black.
[x] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
[x] Have you included the relevant issue number using #XXX notation where XXX is the issue number?

Thanks @bendichter , I implemented your suggested changes and think this made it better! I checked it locally, and it seems to still work fine.

Thanks @bendichter. I removed all changes related to other interfaces, because I agree they do not belong here. They must have crept in from merging with other branches, though I only recall merging with master right now.


Missing Docs: Clips

I've mentioned it as much as the other primitives. They probably all need their own sections.

I've mentioned it as much as the other primitives. They probably all need their own sections.


Netapp OnTap Data Scheme Issue

Hello,
This may be a possible bug. We are unable to ingest any data from Netapp. I have attached the pcap which shows the packets are being received in syslog format. However, the data is not appearing within Splunk. We have done all of the proper configuration required as well. Can you please review the pcap file?
Netapp OnTap Version 9.10.1p5
NetApp.zip

We will review and update.

Hello,
Any updates regarding this ticket?

Hi, this has been fixed in https://github.com/splunk/splunk-connect-for-syslog/pull/1759. I will close this ticket.


Use 'CopyConst' to Visitors over both const and non-const IR

From #609
An addition to #598 to support mutating and non-mutating IRVisitors.

Hit the wrong branch. One more try


Fix Image Shape Test

This change adds an image drawer to the container so we will no longer throw Cannot read property *** of undefined whenever the image shape is chosen in the test.

I also fixed the position test that failed in your last merge to dev. The private method Particle.calcPosition shifts the position whenever it lies near the edge of the canvas, which I hadn't counted on. I added functionality to ensure the position never lies in this region for this test.


Feature Request: Improve GetAttestations query (GetMostRecentAttestations)

I would like to have some options in what regards to querying attestations (/gravity.v1.Query/GetAttestations):

ASC/DESC ordering by nonce (currently is ASC)
observed true/false
get by specific event nonce
get by claim type
get by height

This is especially helpful when tracking the state of a transaction (and also to watch the state of the network's relayers)

I can tackle this if there's no opposition @jkilpatr?


Let the container control its own heartbeats

This removes the use of ClientHeartbeat for containers, which now have their own heartbeat loop in _container_entrypoint.py
It will make it possible to clean up some of the global state where we set the current input id etc – I'll do it in a subsequent PR just to keep it simple and focused.
The other use of client heartbeats is for apps, so that will be its own PR as well.

I have been testing this against prod using MODAL_SYNC_ENTRYPOINT=1 and it's working with the examples. I can see ContainerHeartbeat requests on the server side (actually – just found a bug while doing this. Fixing it!)


'make' command failed

><EMAIL_ADDRESS>start
> npx tsx src/index.ts

[Nodejs-whisper]  Transcribing file: F:\Projects\Whisper\karasmsk.25.mp4

[Nodejs-whisper]  Converting audio to wav File Type...

[Nodejs-whisper] whisper.cpp not initialized. F:\Projects\Whisper\node_modules\nodejs-whisper\dist
[Nodejs-whisper] Attempting to run 'make' command in /whisper directory...
process_begin: CreateProcess(NULL, uname -s, ...) failed.
Makefile:4: pipe: No error
process_begin: CreateProcess(NULL, uname -p, ...) failed.
Makefile:8: pipe: No error
process_begin: CreateProcess(NULL, uname -m, ...) failed.
Makefile:12: pipe: No error
process_begin: CreateProcess(NULL, which nvcc, ...) failed.
Makefile:16: pipe: No error
'cc' is not recognized as an internal or external command,
operable program or batch file.
'g++' is not recognized as an internal or external command,
operable program or batch file.
I whisper.cpp build info:
I UNAME_S:
I UNAME_P:
I UNAME_M:
I CFLAGS:   -I.              -O3 -DNDEBUG -std=c11   -fPIC -mfma -mf16c -mavx -mavx2
I CXXFLAGS: -I. -I./examples -O3 -DNDEBUG -std=c++11 -fPIC
I LDFLAGS:
I CC:
I CXX:

cc  -I.              -O3 -DNDEBUG -std=c11   -fPIC -mfma -mf16c -mavx -mavx2   -c ggml.c -o ggml.o
process_begin: CreateProcess(NULL, cc -I. -O3 -DNDEBUG -std=c11 -fPIC -mfma -mf16c -mavx -mavx2 -c ggml.c -o ggml.o, ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [Makefile:259: ggml.o] Error 2
 [Nodejs-whisper] 'make' command failed. Please run 'make' command in /whisper.cpp directory. Current shelljs directory:  F:\Projects\Whisper\node_modules\nodejs-whisper\dist
PS F:\Projects\Whisper>

can you please show me your code , before trying to convert transcript  you have to use this command to download model  npx nodejs-whisper download
and if you are windows user then you also need to download make tool

Literally the whole code is
import { nodewhisper } from "nodejs-whisper";

async function main() {
    let result = await nodewhisper("F:\\Projects\\Whisper\\karasmsk.25.mp4", {
        modelName: "large",
        autoDownloadModelName: "large",
        whisperOptions: {
            outputInText: true
        }
    });
    console.log(result);
}

main().then();

and I did download make tool, I think using WinGet or Chocolatey

can you once refer to this and install g++ , code use this to compile some files to run modal
https://www3.cs.stonybrook.edu/~alee/g++/g++.html


Extending the code to support image + vector observations

Hi, thank you so much for developing this repository.
I am looking forward to applying the code to my custom environment which takes in a dict observation (following gym specifications) containing a vector observation and an RGB observation.
I was wondering if i modify the code and append the vector representation to the image embeddings produced by CNN feature extractor and make relevant changes to the buffer, would it be enough to support an environment with image+vector observations?
I would appreciate any insights you might have on this.
Cheers!

Hi @arehman1806
you basically got it right. Every obs in your dict is processed by a distinct encoder. The results from these encoders are then concatenated. Here is an example https://github.com/MarcoMeter/neroRL/blob/master/neroRL/trainers/PPO/otc_model.py#L151

Awesome!


[Fixes #3867] Abstracting Cache tag helper storage

:watch:

:up::date:

I'm having a little trouble understanding how this will be used. Can you provide some usage examples please?

:watch: just for doc comment fixes.

:up::date:

:shipit:

Deprecated


[FLINK-4370] Add an IntelliJ Inspections Profile

This adds an IntelliJ inspections profile for Flink in the .idea folder.
When the code is imported into IntelliJ, it should automatically pick up and use that inspection profile.
The profile adds some extra warnings and errors that I found useful in the past.
We should gradually activate more inspections (or deactivate some) as we feel it helps the development.

Should this be part of the repository? I think that IDE specific settings should be configured by the individual developers themselves and should remain local. However, I think that adding this profile to the flink website as a recommendation for IntelliJ is a good idea.

Agree with @tillrohrmann . And I'm confused that can it work? As .idea folder is in .gitignore list.

This is only a suggestion. I thought it would be great to have a more unified set of warnings and errors, because it would encourage a more unified code style.
With this change, most IDE specific settings are still up to the user. This only sets a project-default set of inspections/warnings to display in the editor.
Changes to .idea are generally ignored - these files are an exception (they were "force added").

Try to pull this patch and the following error occurred
$ git pull https://github.com/StephanEwen/incubator-flink inspections
From https://github.com/StephanEwen/incubator-flink
 * branch            inspections -> FETCH_HEAD
error: The following untracked working tree files would be overwritten by merge:
        .idea/inspectionProfiles/Project_Default.xml
        .idea/inspectionProfiles/profiles_settings.xml
Please move or remove them before you can merge.
Aborting

Okay, I see, it is not that easy with ignored files ;-)
Let me close this pull request and see if I can find another way to share these inspections automatically.

@StephanEwen can these be shared under tools/idea/...? If they are installed by default then any user modifications will be noted by git. Conversely, most contributors won't notice these files or synchronize as additional inspections are enabled, but as of now developers are on their own.

@greghogan That could definitely be done.
I was initially trying to do a trick: Check in the inspection profile that we want (in terms of what qualifies as a warning) but also add it to .gitignore so that any customization on a developer's end is not committed back.
That way we would set up everyone with the common base and still allow for customization.


ivf_pq range search on glove is 100% lower than expectation

ivf_pq range search latency is lower especially when nprobe is 512.
m=8, nbits=8
in ref_log it is 4.8s when nrpbe=512, so a reasonable latency in ci shall be <6s
ivf_pq range search on glove latency: [0.1639, 0.22, 0.1808, 0.3279, 0.4638, 0.8545, 1.6019, 3.0346, 5.8834, 11.6323]

[59.149 s] glove-200-angular-range | IVF_PQ | nlist=1024, radius=0.520
nprobe =    1, nq = 10000, elapse =  0.137s, R@ = 0.2880, A@ = 0.3964
nprobe =    2, nq = 10000, elapse =  0.125s, R@ = 0.4277, A@ = 0.4041
nprobe =    4, nq = 10000, elapse =  0.154s, R@ = 0.5652, A@ = 0.4143
nprobe =    8, nq = 10000, elapse =  0.170s, R@ = 0.6417, A@ = 0.4181
nprobe =   16, nq = 10000, elapse =  0.243s, R@ = 0.6695, A@ = 0.4203
nprobe =   32, nq = 10000, elapse =  0.414s, R@ = 0.6749, A@ = 0.4212
nprobe =   64, nq = 10000, elapse =  0.684s, R@ = 0.6766, A@ = 0.4217
nprobe =  128, nq = 10000, elapse =  1.380s, R@ = 0.6770, A@ = 0.4218
nprobe =  256, nq = 10000, elapse =  2.608s, R@ = 0.6772, A@ = 0.4218
nprobe =  512, nq = 10000, elapse =  4.785s, R@ = 0.6772, A@ = 0.4218
@yanliang567
I see all of your runtime is about 2 times of the runtime in my ref_logs
nprobe = 128, 1.380s VS. 3.0346
nprobe = 256, 2.608s VS. 5.8834
nprobe = 512, 4.785s VS. 11.6323
and when 'nprobe' doubled, runtime also doubled.
So I think the runtime difference is caused by hardware, it's acceptable.

okay, close and update the test baseline accordingly.


Disable anti-amplification limit by address validation token

Fixes #3319.

@marten-seemann please check again

@birneee Are you still working on this? Would love to get this merged!

@marten-seemann i just worked on it :)

@marten-seemann you are right, because the AcceptToken can be configured. The defaultAcceptToken function however checks the validity. So we could either use a function similar to defaultAcceptToken by calling it directly or add a new config ValidateToken, where by default AcceptToken = ValidateToken. But I am not sure if ValidateToken should be configurable.

@marten-seemann please check
I think, configuring token validity is another issue.

@birneee We just completely rewrote the Retry API in #3501 (see #3494 for design considerations). As the token validation logic now lives inside quic-go, this should make it possible to disable the anti-amplification limit when we successfully validated a token.
Do you want to rebase and modify your PR to take advantage of this? Fixing #3319 would be a super valuable contribution for everyone who actually wants to take full advantage of 0-RTT.

@marten-seemann it is rebased now


Database.ExecuteStoredProcedure() does not exist

I tried using EntityFrameworkExtras to execute a StoredProcedure using User-Defined Table Types. I followed the steps on this Github page, but in the last step I am supposed to use context.Database.ExecuteStoredProcedure() which does not exist for me. :(

Perharp you are missing the using directive:
using EntityFrameworkExtras;

We will probably remove the need for this in a future release.
Best Regards,
Jon

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function


Close icon to Popover & typo fix

Part of #1137

I was thinking of this @gabrielliweran, unfortunately Popover already passes through classes prop down to MuiPopover. Trying to sneak another class for close button into this classes breaks things.
In short, I didn't found a way to do it. Any help appreciated.

Hi @gabrielliwerant I hope you are well.
Did some work in making close icon more customizable with a class.
Please review, and merge if okay. Thanks.

Ah, I wish I mentioned this couple of hours earlier. I am still using MUI v3(planning to move to v4, but not yet). Please merge to 2.15.0 if not much of a hassle. Also, will mui-datatables v3 will work with MUI v3? If not, consider releasing mui-datatables v4 to be in sync with MUI.

@Dragomir-Ivanov Even though the focus is on getting it in-line with Material v4, it should be backward compatible with MUI v3 - in fact, there are only a few small things needed for Material v4.
I've released a beta of v3 which you can install here:
npm install mui-datatables@beta
Let me know if that works for you. If not, it's still possible for me to do another 2.x release with these changes (though I'd want to avoid that if possible).
The v3 release still isn't complete, as I want to incorporate a lot more of the outstanding PRs. The only current breaking change is the removal of fixedHeaderOptions (it's being replaced by fixedHeader and fixedSelectColumn options). There will be a few other small breaking changes, but I'll have everything written up when the release comes out.

Thanks @patorjk ! I will try that in next couple of days, and let you know if anything breaks.


Animal Feeder does not feed Horses or Llamas

Industrial Foregoing Version:
industrial-foregoing-1.15.2-2.3.3-e356e61
Story: (you can skip)
Okay. My buddy and I are using the Mob Feeder, Animal Baby Separator, and Mob Slaughter Factory, to kill mobs and get liquid meat. We've been using Cows. But now that I'm learning how the Mechanical Dirt works, it needs to be filled up with liquid meat, so I'm looking for ways to increase our liquid meat production. So I look through the source code and I see that the amount of meat produced depends on how much health the mob has. So for instance we're using cows which have 5 hearts. We were thinking about mobs that have the most health that can also produce babies so of course we thought of Horses which have anywhere from 7 to 15 hearts.
The Issue:
But then we come to find out that the Mob Feeder doesn't feed Horses. (You can feed them Hay Bales to breed them by the way.)
The Fix:
So I took another look at the source code. The machine finds mobs which derive from AnimalEntity and then calls the entity's getFeedingItem(ItemStack) method, which for most animals would return Wheat or Seeds. However, Horses and Llamas derive from the AbstractHorse class which overrides the getFeedingItem() method and just returns false. So the fix is simple. Just add more checks to see if the entity is a Horse or Llama, then check if the input ItemStack is a Hay Bale. You have to directly check for the Horse and Llama mobs because the Donkey, Mule, Skeleton Horse, and Zombie Horse also derive from AbstractHorse, but they cannot be bred with Hay Bales.

Note:
shortly after we thought of using horses a Wondering Trader appeared in our base, with 2 Llamas! So we quickly did what was necessary to tame the llamas and confirmed they can be fed Hay Bales to make a baby llama. We swapped our cows with the llamas and that's how we discovered the Mob Feeder doesn't feed llamas. But an additional note, after a while the llamas started to despawn. I'm not that familiar with Horse and llama behaviour myself, so I suspect that Horses don't check to see if they're in an enclosed space like the other animals and will despawn naturally, but WILL stay if they are tied down with a Lead. I couldn't find any information on the Minecraft wiki page about horses that mention their despawning behaviour.

Note:
shortly after we thought of using horses a Wondering Trader appeared in our base, with 2 Llamas! So we quickly did what was necessary to tame the llamas and confirmed they can be fed Hay Bales to make a baby llama. We swapped our cows with the llamas and that's how we discovered the Mob Feeder doesn't feed llamas. But an additional note, after a while the llamas started to despawn. I'm not that familiar with Horse and llama behaviour myself, so I suspect that Horses don't check to see if they're in an enclosed space like the other animals and will despawn naturally, but WILL stay if they are tied down with a Lead. I couldn't find any information on the Minecraft wiki page about horses that mention their despawning behaviour.

Trader Llamas will despawn with the trader after a certain amount of time, no other passive mobs despawn IIRC

Horses need to be tamed and eat Golden Carrots or Golden Apples. Llamas need to be tamed and eat hay bales.

Horses need to be tamed and eat Golden Carrots or Golden Apples. Llamas need to be tamed and eat hay bales.