Restarted KEB didn't resume unfinished update operation

Description
When testing https://github.com/kyma-project/control-plane/pull/920, I stumbled upon a situation, where KEB was restarted in the middle of processing an update operation. It never picked up the operation and I had to delete it manually from operations DB to unblock changing the instance. Provisioner and gardener have finished their processing successfully.
provisioner=> select id, type, state, message, cluster_id, stage from operation where cluster_id = '9bbe4b6e-944f-44c5-993a-5da9b6f3a59d';
                  id                  |     type      |   state   |       message       |              cluster_id              |  stage
--------------------------------------+---------------+-----------+---------------------+--------------------------------------+----------
 50e3ea98-568b-41e7-9d9a-6d3e0f70d40a | PROVISION     | SUCCEEDED | Operation succeeded | 9bbe4b6e-944f-44c5-993a-5da9b6f3a59d | Finished
 d143215d-6c6a-4564-ae6c-f5faf00336f2 | UPGRADE_SHOOT | SUCCEEDED | Operation succeeded | 9bbe4b6e-944f-44c5-993a-5da9b6f3a59d | Finished

broker=> select instance_id, type, state from operations where instance_id='739C5BC4-27F0-4008-9786-0EF469D4FC0C';
             instance_id              |   type    |    state
--------------------------------------+-----------+-------------
 739C5BC4-27F0-4008-9786-0EF469D4FC0C | update    | in progress
 739C5BC4-27F0-4008-9786-0EF469D4FC0C | provision | succeeded

There also seems to be slightly larger delay in KEB to pick up state from provisioner and gardener even for standard scenarios. Updating autoscaler params in gardener and provisioner takes seconds at most, but KEB takes frequently few minutes to propagate the status.
Expected result
Restarted KEB should always resume processing all unfinished operations
Actual result
KEB didn't resume one unfinished update operation
Steps to reproduce
Restart KEB when there is an update operation in progress
Troubleshooting

related to https://github.tools.sap/kyma/backlog/issues/2032

https://github.com/kyma-project/control-plane/pull/1109/files


Expose Kafka connectivity details to filters

As discussed on slack there are a variety of filter use cases where the filter needs to make connections back to Kafka clusters. Injecting the details during config generation is of course possible but adds complication and potential for miss configuration. The runtime already know which virtual cluster its creating the filter for (we already provide the name) so we could also include the bootstrap connection details.
One thing we should give some thought to is the implications for filters being able to form Kafka connections back through the proxy, what are the failure modes (even if its just for documentation purposes).

We could also consider to add client IP into the detailed information.

Please note that we hope this can be completed as earlier as possible, but just set a deadline to 0.8.0 milestone.


Details about ANP

When I looked at the ANP code, I found that the input perturbation_budget seems to be limiting the range of parameters for the batch normalization layer. For example, if perturbation_budget=4, the range of parameters before the limit is not greater than -4 to 4. How does the absolute size of perturbation described in the paper manifest?

Thank you for your comment. As described in equation 13, we restrict the $\bar{\delta}{k}^{(l)}$ and $\bar{\zeta}{k}^{(l)}$ to control the injected perturbation in the model weight, which is the absolute size of perturbation.


Async drop validator does not work properly

Hello,
When using an async function with dropValidator, dropValidator doesn't work properly.
const onBeforeItemDropped = async (droppedItem: TreeViewItem, dropHost: any) => {
  if (!dropHost || !droppedItem) return false;
  if (dropHost.meta?.type !== 'Folder' || droppedItem.meta?.type === 'Folder')
    return false;

  await apiClient.someMethod();

  return true;
};
</script>

<template>
  <Vue3TreeVue
    :items="treeViewItems"
    @drop-validator="onBeforeItemDropped"
    @on-check="onItemChecked"
    @on-select="onItemSelected"
  >
    <template #item-prepend-icon="treeViewItem">
      <template v-if="treeViewItem.meta?.type === 'Folder'">
        <VIcon>{{ mdiFolder }}</VIcon>
      </template>
    </template>
  </Vue3TreeVue>
</template>

I can confirm that correcting the line below fixes the bug.
// use-tree-mouse-actions.ts

      if (!isDropValid || !(await isDropValid(droppedNode, dropHost))) return;

https://github.com/geekhybrid/vue3-tree-vue/blob/e75a80aa88fc311ae63296610b0fe915e7fe48f9/src/composables/use-tree-mouse-actions.ts#L46

Nice.
Thanks for looking into the code.
I think the original design did not consider an async drop validator function.
Feel free to contribute a fix with a PR. Otherwise, i will do that over the weekend.

Is there any plan to apply this feature? I also need this functionality.


Vulnerabilities in latest release (v0.12.2).  Please release a new version

https://quay.io/repository/argoprojlabs/argocd-image-updater?tab=tags
v0.12.2 has 8 critical vulnerabilities and numerous others.  It was released 10 months ago.  latest was tagged only a month ago and has a single critical vulnerability (libcurl, so probably already patched by the OS).  Can we run a new build and get an updated release out please?
If there's anything I can do to help, please let me know.

Looks like there have been a couple releases since this was opened.  The most recent release (v0.14.0) still has a couple vulnerabilities showing but "latest" doesn't.  In any case, it's much better than before and there's activity in the project again, so I'm closing this.


[v2.6] KDM Update for K8s November patch release

TO BE RELEASED: Rancher v2.6.3

New Kubernetes Version
Min Rancher Version
Min RKE Version

1.21.7-rancher1-1
n/a
n/a

1.20.13-rancher1-1
2.5.11-rc0
1.2.14-rc0

Rancher System Images & Add-ons
Note: Please update system images and add-ons in the template as needed.
TBD
Developer Changelog

Add templates for new K8s versions. If a template that hasn't been released yet already exists, update it in place.
Update the default K8s version, and add or update the version information (MinRancherVersion and MinRKEVersion) in k8s_version_info.go for new K8s versions if needed (Use table from above).
Confirm versions for system images, add-on templates are correct using versioning reference table from below (expand details to view the table). Update the table if new versions are introduced.
Confirm add-on template version constraints in template.go are correct using versioning reference table from below (expand details to view the table). Update the table if needed.

Versioning Reference

Expand for system images & add-on templates versioning table

Note: Truncated repository names with a * indicates there are multiple images with that prefix. All repository names that match a truncated prefix should be checked for the same version stated in the table.
For example: rancher/weave-* matches weaveworks/weave-kube and weaveworks/weave-npc, and they should both have the same version.
v1.21.7-rancher1-1

Repository
Tag

rancher/mirrored-coreos-etcd
v3.4.16-rancher1

rancher/hyperkube
v1.21.7-rancher1

rancher/rke-tools
v0.1.78

rancher/mirrored-k8s-dns-*
1.17.4

rancher/mirrored-cluster-proportional-autoscaler
1.8.3

rancher/mirrored-coreos-flannel
v0.14.0

rancher/flannel-cni
v0.3.0-rancher6

rancher/mirrored-calico-*
v3.19.1

weaveworks/weave-*
2.8.1

noiro/* (All ACI images)
<IP_ADDRESS>.1ae238a

rancher/mirrored-pause
3.4.1

rancher/nginx-ingress-controller
nginx-0.49.3-rancher1

rancher/mirrored-nginx-ingress-controller-defaultbackend
1.5-rancher1

rancher/mirrored-jettech-kube-webhook-certgen
v1.5.1

rancher/mirrored-metrics-server
v0.5.0

rancher/mirrored-coredns-coredns
1.8.4

rancher/mirrored-cluster-proportional-autoscaler
1.8.3

rancher/kubelet-pause
v0.1.6

rancher/mirrored-k8s-dns-node-cache
1.18.0

Add-on Name
Add-on Template Version Constraint

Calico
calicov319

Canal
canalv319

Flannel
flannelv0140

CoreDNS
coreDnsv183

KubeDNS
kubeDnsv116

MetricsServer
metricsServerv050

Weave
weavev120

Aci
aciv500

NginxIngress
nginxIngressv0493

Nodelocal
nodelocalv121

v1.20.13-rancher1-1

Repository
Tag

rancher/mirrored-coreos-etcd
v3.4.15-rancher1

rancher/hyperkube
v1.20.13-rancher1

rancher/rke-tools
v0.1.78

rancher/mirrored-k8s-dns-*
1.15.10

rancher/mirrored-cluster-proportional-autoscaler
1.8.1

rancher/coreos-flannel
v0.13.0-rancher1

rancher/flannel-cni
v0.3.0-rancher6

rancher/mirrored-calico-*
v3.17.2

rancher/mirrored-coreos-flannel
v0.13.0

rancher/mirrored-calico-pod2daemon-flexvol
v3.17.2

weaveworks/weave-kube
2.8.1

weaveworks/weave-npc
2.8.1

noiro/* (All ACI images)
<IP_ADDRESS>.1ae238a

rancher/mirrored-pause
3.2

rancher/nginx-ingress-controller
nginx-0.49.3-rancher1

rancher/mirrored-nginx-ingress-controller-defaultbackend
1.5-rancher1

rancher/mirrored-jettech-kube-webhook-certgen
v1.5.1

rancher/mirrored-metrics-server
v0.4.1

rancher/mirrored-coredns-coredns
1.8.0

rancher/mirrored-cluster-proportional-autoscaler
1.8.1

rancher/kubelet-pause
v0.1.6

rancher/mirrored-k8s-dns-node-cache
1.15.13

Add-on Name
Add-on Template Version Constraint

Calico
calicov3171

Canal
canalv3171

Flannel
flannelv116

CoreDNS
coreDnsv117

KubeDNS
kubeDnsv116

MetricsServer
metricsServerv120

Weave
weavev120

Aci
aciv500

NginxIngress
nginxIngressv0493

Nodelocal
nodelocalv115

Verified on rancher v2.6.3-rc4:
Fresh install checks - on 2.6.3-rc4, KDM pointing to dev-v2.6

Deployed clusters with k8s version v1.20.13-rancher1-1 and v1.21.7-rancher1-1 on all network providers - weave/flannel/calico/canal
Validations of Network checks on all clusters looks good
Validation tests on Canal clusters looks good

Upgrade checks - on v2.6.2, KDM pointing to release-v2.6

Deployed cluster with k8s v1.20.12-rancher1-2 and v1.21.6-rancher1-2 version on all network providers weave/flannel/calico/canal.
Pre-upgrade checks look good
Upgraded rancher from v2.6.2 to v2.6.3-rc4
Post upgrade checks look good
Upgraded K8s versions to new versions - v1.20.13-rancher1-1 and v1.21.7-rancher1-1
Post upgrade checks look good.

RKE checks using 1.3.3-rc4 passed for v1.20.13-rancher1-1 and v1.21.7-rancher1-1 k8s version.

KDM checks for k8s 1.22.4-rancher1-1 on rancher v2.6-head
Fresh install checks - on 2.6-head, KDM pointing to dev-v2.6

Deployed clusters with k8s version v1.22.4-rancher1-1 on all network providers - weave/flannel/calico/canal
Calico cluster is not coming up. It remains in Waiting state with msg : Waiting for API to be available . Also tried creating the cluster using node driver with calico, same issue is occurring. Flannel/cannel/weave clusters came up Active. (attached ss).

Error in rancher server logs for calico cluster :
[ERROR] error syncing 'c-4sfkq/m-e12baa26eee3': handler rke-worker-upgrader: getNodePlan error for node [m-e12baa26eee3]: failed to find plan for <IP_ADDRESS>, requeuing

Upgrade checks - on v2.6.2, KDM pointing to release-v2.6

Successfully Deployed cluster with k8s v1.21.6-rancher1-2 version on all network providers weave/flannel/calico/canal.
Pre-upgrade checks look good
Upgraded rancher from v2.6.2 to v2.6-head. Clusters came into active state.
Upgraded K8s versions to new version - v1.22.4-rancher1-1 successfully.
During post-upgrade checks multiple errors coming up related to ingress:
Validated some of the ingress error manually by going to sslip.io urls but getting default backend - 404. Also checked in the clusters, ingress is present and pointing to correct service and the pods are also up and running:
ingress controller logs:

I1209 10:32:37.316611       7 store.go:420] "Ignoring ingress because of error while validating ingress class" ingress="mystep2-ns1/mystep2-testingress1" error="ingress does not contain a valid IngressClass"
I1209 10:32:37.316627       7 store.go:420] "Ignoring ingress because of error while validating ingress class" ingress="mystep2-ns1/mystep2-testingress2" error="ingress does not contain a valid IngressClass"
I1209 10:32:37.410830       7 nginx.go:297] "Starting NGINX process"

Verified on rancher v2.6.3-head (9295d4f):
Fresh install checks - on 2.6-head, KDM pointing to dev-v2.6:

Deployed clusters with k8s version v1.22.4-rancher1-1 on all network providers - weave/flannel/calico/canal
Validations of Network checks on all clusters looks good
Validation tests on Canal clusters looks good

Upgrade checks - on v2.6.2, KDM pointing to release-v2.6:

Successfully Deployed cluster with k8s v1.21.6-rancher1-2 version on all network providers weave/flannel/calico/canal.
Pre-upgrade checks look good
Upgraded rancher from v2.6.2 to v2.6-head. Clusters came into active state.
Upgraded K8s versions to new version - v1.22.4-rancher1-1 successfully.
During post-upgrade checks ingress related error still persisting :

I1210 07:59:30.251809       8 store.go:420] "Ignoring ingress because of error while validating ingress class" ingress="mystep1-ns1/mystep1-testingress1" error="ingress does not contain a valid IngressClass"
I1210 07:59:30.251843       8 store.go:420] "Ignoring ingress because of error while validating ingress class" ingress="mystep1-ns1/mystep1-testingress2" error="ingress does not contain a valid IngressClass"
I1210 07:59:30.252086       8 store.go:420] "Ignoring ingress because of error while validating ingress class" ingress="mystep2-ns1/mystep2-testingress1" error="ingress does not contain a valid IngressClass"

Verified on rancher v2.6-head (04520c0):
Fresh install checks - on 2.6-head, KDM pointing to dev-v2.6:

Deployed clusters with k8s version v1.22.4-rancher1-1 on all network providers - weave/flannel/calico/canal
Validations of Network checks on all clusters looks good
Validation tests on Canal cluster looks good.

Upgrade checks - on v2.6.2, KDM pointing to release-v2.6:

Successfully Deployed cluster with k8s v1.21.6-rancher1-2 version on all network providers weave/flannel/calico/canal.
Pre-upgrade checks look good
Upgraded rancher from v2.6.2 to v2.6-head. Clusters came into active state.
Post upgrade checks look good
Upgraded K8s versions to new versions - v1.22.4-rancher1-1
Post upgrade checks look good.

RKE Checks failed with rke v1.3.3-rc6 for k8s v1.22.4-rancher1-1.

Closing this issue. Tracking a separate issue for this


[BACKLOG-14992] Fix to NPE when converting a String to Date

@pentaho/millenniumfalcon please review.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/test-src/org/pentaho/di/core/row/value/ValueMetaBaseTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.row.value.ValueMetaBase

Branch Change:  + .42%
Complexity Change:  + .41%
Instruction Change:  + .63%
Line Change:  + .76%
Method Change:  + .05%

org.pentaho.di.core.row.value.ValueMetaBigNumber

Complexity Change:  + 4.17%
Instruction Change:  + 5.33%
Line Change:  + 6.35%
Method Change: -16.67%:small_red_triangle_down:

org.pentaho.di.core.row.value.ValueMetaDate

Complexity Change: -13.89%:small_red_triangle_down:
Instruction Change: -10.83%:small_red_triangle_down:
Line Change: -10.00%:small_red_triangle_down:
Method Change: -12.50%:small_red_triangle_down:

org.pentaho.di.core.row.value.ValueMetaInteger

Complexity Change: -13.33%:small_red_triangle_down:
Instruction Change: -19.14%:small_red_triangle_down:
Line Change: -13.13%:small_red_triangle_down:
Method Change: -16.67%:small_red_triangle_down:

org.pentaho.di.core.row.value.ValueMetaNumber

Complexity Change: -8.33%:small_red_triangle_down:
Instruction Change: -10.05%:small_red_triangle_down:
Line Change: -7.94%:small_red_triangle_down:
Method Change: -16.67%:small_red_triangle_down:

org.pentaho.di.core.row.value.ValueMetaTimestamp

Branch Change: -.38%:small_red_triangle_down:
Instruction Change: -.31%:small_red_triangle_down:
Line Change: -.93%:small_red_triangle_down:
Method Change: -1.51%:small_red_triangle_down:


[Choose Your Fighter] Suggestion: Use fuzzy searching for blueprints

Qud’s wishing capability has a facility to find approximate matches for solely blueprints (XRL.WishSearcher.SearchForBlueprint()). Perhaps that would be useful for people who don’t know how to get blueprint names.

Added for Choose Your Fighter v0.5.0.


[meta] Document environment variables in Sampling

I think we should also document setting the environment variable in a top-level section in this guide. That can be especially helpful for development since you can just use the default, but then have production do something different.
Originally posted by @cartermp in https://github.com/open-telemetry/opentelemetry.io/pull/3318#pullrequestreview-1647152522
Also https://github.com/open-telemetry/opentelemetry.io/pull/3318#discussion_r1338917095

(edit by @svrnm)
Tracking:

[ ] C++
[ ] .NET
[ ] Erlang/Elixir
[ ] Java
[ ] JavaScript
[ ] PHP
[ ] Python
[ ] Ruby
[ ] Rust
[ ] Swift

Resource: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md
We should also probably call out that using trace.WithSampler overrides the env vars.

is this only a go thing?

IMO not only Go. I think that the default value is wrongly defined in other languages. And also I think the clarification is needed for all languages.

Ok. I removed the "Go" from the title :)

@pellared turning this into a meta issue since it is relevant for all languages

Hi @svrnm, I would like to start working on this. Will start from Java first.
Do we have any ideal format that we need to follow for this ? Any example from existing one's ?

Hi @svrnm, I would like to start working on this. Will start from Java first. Do we have any ideal format that we need to follow for this ? Any example from existing one's ?

Apologies for the late reply, I was out of office. We currently have https://github.com/open-telemetry/opentelemetry.io/pull/4199 open, so it might need that to be closed before we can add some words about variables. You can review that PR if you like and create a follow up when merged.


:test_tube: Chore: Update all tests to use alchemy rather than optimism public endpoint

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1049  👈
#1047
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


Display System Tray icons on secondary/all monitors

Is your feature request related to a problem? Please describe.
There isn't a real problem, but the feature would simply be adding value to the application. It would be very nice to be able to see the system tray icons on my secondary monitor in addition to my primary monitor.
Describe the solution you'd like
The solution would be to be able to show my system tray icons on the secondary monitor, to be able to e.g. view the CPU/GPU temperature icons that I have there (due to using HwInfo). It would also be nice to easily bring up the volume "widget" and be able to lower the volume of specific applications without bringing up the taskbar on my primary monitor (while playing a game, or something).

I know the clock is automatically visible on the secondary screen (and I know that you can easily hide it with TaskbarX).
Describe alternatives you've considered
Similar solutions are implemented in DisplayFusion   and ActualMultipleMonitors, but both of those application are paid, and also include a huge amount of features which are completely uninteresting to me.
Additional context
I understand that this might be a big feature to add (as there doesn't seem to be anyone else who has made a utility application with that kind of feature for free.

up


Scroll collection view cell in all row on scrolling anyone

Is there a way ,where i scroll the collection view on first row and make all the collection view cells of other row to scroll at that position?

Hmm, hard to say. I don't know if I quite understand what you're looking for – could you describe it in more detail?

What i want to do is when user scrolls The cell in one row..I want all the the cells to scroll that position..Well i have been able to acheive what i want.But not as expected..
   func scrollViewDidScroll(scrollView: UIScrollView) {

        if scrollView.isKindOfClass(UICollectionView){
            tempContentOffSet = scrollView.contentOffset
        }
    }
  func collectionView(collectionView: UICollectionView, cellForItemAtIndexPath indexPath: NSIndexPath) -> UICollectionViewCell {

            if collectionView.contentOffset.x != tempContentOffSet.x {
                collectionView.contentOffset.x = tempContentOffSet.x
            }
    }


lua[cpp]:x64-uwp build failure

Host Environment

OS: Windows 10 20H2
Compiler: 19.29.30040

To Reproduce
Steps to reproduce the behavior:
./vcpkg install lua[cpp]:x64-uwp
Failure logs
    lparser.c
     4>C:\dev\vcpkg\buildtrees\lua\src\lua-5-60afff5bd1.clean\src\lgc.c(720,19): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\dev\vcpkg\buildtrees\lua\x64-uwp-dbg\lua.vcxproj]
     4>C:\dev\vcpkg\buildtrees\lua\src\lua-5-60afff5bd1.clean\src\lgc.c(739,23): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\dev\vcpkg\buildtrees\lua\x64-uwp-dbg\lua.vcxproj]
     4>C:\dev\vcpkg\buildtrees\lua\src\lua-5-60afff5bd1.clean\src\liolib.c(286,29): error C3861: '_pclose': identifier not found [C:\dev\vcpkg\buildtrees\lua\x64-uwp-dbg\lua.vcxproj]
         lstate.c
         lstring.c
     4>C:\dev\vcpkg\buildtrees\lua\src\lua-5-60afff5bd1.clean\src\liolib.c(295,10): error C3861: '_popen': identifier not found [C:\dev\vcpkg\buildtrees\lua\x64-uwp-dbg\lua.vcxproj]

According to msdn docs, _popen and _pclose does not support uwp application, so it's by design.

Shouldn't the the lack of support for UWP be flagged at a higher level though, rather than generating a build error?

@trojanfoe No, since the upstream uses some uwp-unsupported functions, we can only report error message here.
If you need to use this feature on UWP build, please report this to the upstream.
Thanks.

Please keep this issue open until #19510 merge.


how to setup path-style requests with custom endpoint?

I'm trying to upload data to a custom s3 bucket (currently s3ninja hosted on a custom server) using AWSS3TransferUtility.s3TransferUtility(), but the requests are being done using virtual-hosted–style (where the bucket name is a subdomain of the endpoint domain) instead of simple path-style.
Is there a way to force it to use path-style requests?

should this be on aws-sdk-ios instead of here?

You're right - closing this in lieu of https://github.com/aws-amplify/aws-sdk-ios/issues/5023


Lily/ClonesPlus: re-re fix performance for "when I start as w/ set to ..." block

Now it should work. It waits for variables to initialize

Fails on this project
https://static.muffin.ink/extensions-1763.sb3

production:

this pull request:

Anything that isn't an edge-activated hat will differ at least a little bit. That could break projects. But maybe worth doing since this is probably rare and that it's not running right after the vanilla block is arguably a bug. Though in this project it doesn't even run at all so that's a pretty bad failure case.
Here is where the vanilla event gets fired. You could do it in the same spot.
https://github.com/TurboWarp/scratch-vm/blob/b900a375fa1c4a9574835c308baf5f8f16fd6cd9/src/sprites/rendered-target.js#L177

Anything that isn't an edge-activated hat will differ at least a little bit. That could break projects. But maybe worth doing since this is probably rare and that it's not running right after the vanilla block is arguably a bug. (if you follow this logic expected output would be when i start as clone then when i started as clone with then when timer then forever then end).
Here is where the vanilla event gets fired. You could do it somewhere around. Might not be able to do this spot exactly since the variable won't be set yet.
https://github.com/TurboWarp/scratch-vm/blob/b900a375fa1c4a9574835c308baf5f8f16fd6cd9/src/sprites/rendered-target.js#L177

fixed

btw the unrelated changes like Scratch.vm.runtime -> runtime probably didn't really need to be included

!format

btw the unrelated changes like Scratch.vm.runtime -> runtime probably didn't really need to be included

eh, ever so slightly faster + simpler

at the cost of making the diffs bigger  for no reason and  increasing change of a typo  causing a regression

ok will use this pr to test more things related to the formatting workflow being broken

!format


Add timed stand functionallity

I added the functionality I asked for in #1, Don't know swift all that well, but it seems to be working.

@DWilliames I would love to see this functionality implemented.

@DWilliames @meck How do you change the time from the app? It doesn't seem to have an option to change the time. Are you sure you included the latest build into the release?

@ohkimur – Sorry, I think the actual exported Desk Controller.app file didn't properly have the updates.
Can you try now. Can download from here: https://github.com/DWilliames/idasen-controller/releases/latest/download/Desk.Controller.app.zip
The new preferences should look something like this:


KAFKA-17526: make ConfigCommandIntegrationTest.java test use correct arguments in testing alias

JIRA: KAFKA-17526
This PR reviews existing tests and refactors the validation to ensure the command is generated correctly.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@frankvicky Could you please rebase code to include recent fix?

@frankvicky please fix the conflicts

Hi @chia7712
I have rebased and fixed the conflicts, PTAL 😺


Fix for the new version of onering

The api for onering got changed. It also got quite a few performance optimizations

@kellabyte sorry for this, it's just sending just numbers is not really practical, so i had to move it to a pointer api instead. on the plus side it's really fast now though :)

mm, i think i fatfingered something. cancel that


Mockup user page

First few screens. Working on Permissions now

Version without the tfa management part which is currently not possible:

Closing these out for this iteration.


Sending interface address when connecting to local OR IPv6 nodes

Fixing the problem #2555 was trying to fix without breaking NAT.
cc: @lukechampine

Fornax helped test this and the results are satisfactory. The only problem right now is that if siad is being run on a dual stack machine then http://myexternalip.com/raw always returns the IPv6 and that is set as the public IP and is sent indiscriminately to both IPv6 and IPv4 peers. This is only a problem for outgoing connections.
Detecting both IPv6 and IPv4 addresses of the host is certainly possible and I could add that later to the DNS resolver so the host can communicate on both stacks.

@dNetGuru your PR has a conflict. Probably because of PR#2739. We changed the code to use the announced port but the IP from the connection object because of #2735.

Cool!


Not enough men/cpu when running Kafka (with zookeeper), kSQLDB, Kafka connect, HDFS and Spark

Multiple groups are having issues running their workload. They report issues when deploying spark orchestrators and runners.
Make sure the next year's exercises are running:

Kafka without zookeeper
limit the amount of instances used in Kafka connect
adjust the number of runners for spark jobs.

No complaints occurred using the new setup.


mjpage.js: fix typo in usage

Thanks for the PR. The file is actually called that so I'm not sure what you are after.

If you install it through npm the name is just mjpage, not mjpage.js.
Alternatively, may be it can intelligently return the name called from the command line.

If you install it through npm the name is just mjpage, not mjpage.js.

Ah! Thanks for pointing out the discrepancy between package.json and mjpage.js. I'll think about it.

I think it would be best to rename mjpage.js to mjpage. @ickc could you update the PR? Otherwise, I can make a fresh one.

I deleted the old fork so I forked it again and made the pull request at #23.


chore: update nuxt to v3.8.2

Version 3.3.2 came out almost a year ago. I've updated it to v3.8.2, which is more recent and very stable in my experience.
I've skimmed through the docs, and haven't found any issues caused by the update.

Hi, thank you for your PR, but we had some issues with loading times. Our PrimeVue team will be testing the versions soon. We will update it after the tests, and we also have some other changes tied to Nuxt's version.👍


Add ability to "freeze" an account such that it can no longer be credited/debited

https://github.com/digital-asset/daml-finance/pull/869


Support Hive managed Transactional/ACID tables

Presto fails to run queries against Hive managed tables. In Hive 3.x these tables are defaulted to transactional/insert-only as per https://docs.hortonworks.com/HDPDocuments/HDP3/HDP-3.1.0/hive-overview/content/hive_upgrade_changes.html . Given that this is the default table type in Hive 3.x for all hive managed table, can Presto be enhanced to handle them?
Any one upgrading to Hive 3.x will have diminished use for Presto without this support, as Presto can only handle ‘external’ tables in Hive 3.x
Error Message, when trying to access a ‘transactions/insert-only’ table:
Query 20190402_173707_00215_qkyph failed: Your client does not appear to support insert-only tables.
               To skip capability checks, please set metastore.client.capability.check to false. This setting can be
               set globally, or on the client for the current metastore session. Note that this may lead to incorrect results,
               data loss, undefined behavior, etc. if your client is actually incompatible. You can also specify custom client
               capabilities via get_table_req API.
        at io.prestosql.plugin.hive.metastore.thrift.ThriftHiveMetastore.getTable(ThriftHiveMetastore.java:252)
        at io.prestosql.plugin.hive.metastore.thrift.BridgingHiveMetastore.getTable(BridgingHiveMetastore.java:81)
        at io.prestosql.plugin.hive.metastore.CachingHiveMetastore.loadTable(CachingHiveMetastore.java:274)
        at com.google.common.cache.CacheLoader$FunctionToCacheLoader.load(CacheLoader.java:165)
        at com.google.common.cache.CacheLoader$1.load(CacheLoader.java:188)
        at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3528)
        at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2277)
        at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2154)
        at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2044)

Proposal for supporting Insert Only Transactional Hive tables: https://docs.google.com/document/d/1GwSNc_6jSP8N1SyJIHnaMeWvh7JzhGPZ7QKm1DHJqEw/edit?usp=sharing
@electrum @martint @dain please review. I have a wip implementation of this which is able to read Insert Only Transactional tables from Hive3

@electrum what do you think about create a high level issue to track this stuff?  I would say the proposal above is part of the Hive 3.0 support project, and a sub item of supporting new table organizations. The proposal only covers reading of insert only tables and not write or full acid tables.

I read the proposal and it seems reasonable. One question is that it mentions deltas, which to my understanding are only for full ACID, not insert-only.
From an implementation perspective, table layouts are deprecated. I’m working on a PR to remove them from the Hive connector. I suggest waiting for that, which should be complete and merged sometime next week, then send a PR on top. I’m happy to review and work with you on it.

@electrum I remembered there were discussion around removing table layouts but saw them in master hence went ahead with it, we can wait till your changes land and replace table layout dependency with whatever gets used to fetch partitions.
About the deltas for insert-only tables, they are created for every insert. Difference with full ACID tables is that for deletes in full ACID tables delete_deltas are additionally created.

@electrum I have a question whether presto will provide the support for ACID of Hive in the future.Because when I used Hive to develop the data warehouse of my company, I found that some dim tables(scd) and some fact table(accumulator snapshot table) need to update.For that, I opened the transaction support of Hive but it made presto work wrong for the reason that Presto can't read HIVE's tables which support row update or delete.

@Jedda1314Jessie we are adding the read support for ACID tables. Review has been opened for the first part to support reading INSERT ONLY ACID tables.  I will be adding docs and reviews for full ACID support too soon.

Proposal for Full ACID table reads: https://docs.google.com/document/d/1VrF48kqr_paTtF5iSwryRhZvMwL_ovtbjcAedQd7hyk/edit?usp=sharing
I have this implemented and it works fine. There are some performance optimizations possible over this which can be picked once we finalize this solution.
@dain @electrum @martint please have a look.

@stagraqubole are there any latest update or schedule? thanks!

@heocaf This is in progress. The PRs are out and under review. I cant comment on the timelines but atleast the PR for Insert Only Tables can go in fast once @electrum does the final review.
Full ACID Tables PR is just started.

@stagraqubole got it, thanks for your reply!
Looks like I need to roll back to an earlier version of HDP :(

Presto 331 (pending release) can read from Hive transactional/ORC ACID tables.
The outstanding things are:

Support ORC ACID with base in raw format (#2292)
Support reading ACID/Transactional tables with "original files" (#2293)
Writes to ACID/Transactional tables (#1956)

All the above is tracked by the Hive 3 umbrella issue https://github.com/prestosql/presto/issues/1218

I am using Presto version  0.232, and Hive version 3.1.0. Is this integration supports managed tables of Hive3.1.0 Transactional/ACID tables.
I am also facing same error
Query 20200320_145603_00018_rsdg9 failed: Your client does not appear to support                                                                                insert-only tables. To skip capability checks, please set metastore.client.capa                                                                                bility.check to false. This setting can be set globally, or on the client for th                                                                                e current metastore session. Note that this may lead to incorrect results, data                                                                                loss, undefined behavior, etc. if your client is actually incompatible. You can                                                                                also specify custom client capabilities via get_table_req API.

@MohammedLayeeq please try with Presto 331 -- https://prestosql.io/download.html


Pod often restart,  Back-off restarting failed container

could you provide more context?

which Pod is restarts?
what is your kubernetes setup?
did you run
kubectl describe
and look at status ?

do you have enough memory in your kubernetes nodes?

could you provide more context?

which Pod is restarting?
what is your kubernetes setup?
did you run
kubectl describe --namespace your_namespace your_pod
and look at status?
do you have enough memory in your kubernetes nodes?

always oomkilled

how much free RAM do you have in your kubernetes worker nodes?

the problem is running to oom，we don‘t write any data or any operation
| |
ThanosWei
<EMAIL_ADDRESS>|
签名由 网易邮箱大师 定制
On 05/27/2020 17:36, Eugene Klimov wrote:
how much free RAM do you have in your kubernetes worker nodes?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

could you answer to my question?

how much free RAM do you have in your kubernetes worker nodes?
which pod killed by OOM? it's a clickhouse-operator pod or clickhouse-server pod?

i dont see the free ram，clickhouse sever pod！
| |
ThanosWei
<EMAIL_ADDRESS>|
签名由 网易邮箱大师 定制
On 05/27/2020 21:37, Eugene Klimov wrote:
could you answer to my question?
how much free RAM do you have in your kubernetes worker nodes?
which pod killed by OOM? it's a clickhouse-operator pod or clickhouse-server pod?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

which kubernetes provider doyou use?
AliCloud? AWS? Azure? Google Cloud?
or you run clickhouse-operator inside local kubernetes cluster?

jdcloud
| |
ThanosWei
<EMAIL_ADDRESS>|
签名由 网易邮箱大师 定制
On 05/27/2020 21:51, Eugene Klimov wrote:
which kubernetes provider doyou use?
AliCloud? AWS? Azure?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@SalleryWang could you run
kubectl top nodes ?

@SalleryWang , are you restricting memory settings for ClickHouse? Not a pod memory, but ClickHouse itself. It is configured in profile settings, usually in default. E.g. these are typical settings for pod with 100Gi RAM:
    profiles:
      default/max_bytes_before_external_group_by: '51539607552'
      default/max_bytes_before_external_sort: '51539607552'
      default/max_memory_usage: '92771293593'
      default/max_memory_usage_for_all_queries: '92771293593'
      default/max_memory_usage_for_user: '92771293593'

thx
| |
ThanosWei
<EMAIL_ADDRESS>|
签名由 网易邮箱大师 定制
On 05/29/2020 15:11, alex-zaitsev wrote:
@SalleryWang , are you restricting memory settings for ClickHouse? Not a pod memory, but ClickHouse itself. It is configured in profile settings, usually in default. E.g. these are typical settings for pod with 100Gi RAM:
profiles:
  default/max_bytes_before_external_group_by: '51539607552'
  default/max_bytes_before_external_sort: '51539607552'
  default/max_memory_usage: '92771293593'
  default/max_memory_usage_for_all_queries: '92771293593'
  default/max_memory_usage_for_user: '92771293593'

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

closed cause don't provide additional context for reproducing, feel free to reopen


HPX_INCLUDE_DIRS contains non-existent directory

Working on Kokkos+HPX. In HPXConfig.cmake, the following appears in the list of HPX_INCLUDE_DIRS, but it doesn't actually get installed or created.
/Users/jjwilke/Programs/install/hpx/include/hpx/external

from
set(HPX_INCLUDE_DIRS "/Users/jjwilke/Programs/install/hpx/include;/Users/jjwilke/Programs/install/hpx/include/hpx/external;/opt/local/include;/Users/jjwilke/Programs/spack/opt/spack/darwin-highsierra-x86_64/clang-10.0.0-apple/hwloc-2.0.2-jwtizf4qjcn7gh2p2eho5vbrldqg6mbj/include")

This actually doesn't cause errors (well, warnings) until I build a kokkos-dependent project.
  Imported target "kokkos" includes non-existent path

    "/Users/jjwilke/Programs/install/hpx/include/hpx/external"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

Configure still succeeds, but it would be better not to have the warning

Thanks for the report! The external directory is only installed for Xeon Phi, but the list of include directories always contain it. We should easily be able to conditionally excludeit from the list.

Okay, I sort of lied. Configure succeeds, but the build fails. CMake quits adding include directories when it encounters a bad directory (apparently). This causes kokkos-dependent builds to fail because only a subset of the directories get added.  Pretty strange behavior from cmake, actually.


[CARBONDATA-1856][PARTITION] Support insert/load data for partition table

This PR depends on PR https://github.com/apache/carbondata/pull/1642
Changed carbonrelation to HadoopFSRelation during load in case of the partition table.
Implement sparks Fileformat interface for carbon and use carbonoutputformat inside.
Create partition.map file inside each segment for mapping between partition and index file.
The following syntax is supported now.
CREATE TABLE partitiontwo (empno int, designation String,
  workgroupcategory int, workgroupcategoryname String, deptno int, deptname String,
  projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int,
  utilization int,salary int)
 PARTITIONED BY (doj Timestamp, empname String)
 STORED BY 'org.apache.carbondata.format'

LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE partitiontwo OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')

insert into insertpartitionthree select empno,doj,workgroupcategoryname,deptno,deptname,projectcode,projectjoindate,projectenddate,attendance,utilization,salary,workgroupcategory,empname,designation from originTable

LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE singlepasspartitionone OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"', 'SINGLE_PASS'='true')

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/700/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1929/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2262/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1939/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/713/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2268/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/731/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1960/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2282/

@ravipesala This PR implements Hive dynamic partition. Load into static partition is still pending?

@jackylk This PR implements both static and dynamic partition, but the syntax for static partition through LOAD command is not done yet. We can INSERT INTO sql for static partition. Test case also added for it please check.

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/808/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2039/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2352/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/831/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2058/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/836/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2367/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2062/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/841/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2067/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2372/

retest this please

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/854/

retest this please

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/855/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2080/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2082/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/857/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2380/

LGTM

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/866/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2091/

retest this please

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2389/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/874/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2099/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/877/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2102/


Add DT_PARENT()

A few prep work commits to gen_defines.py, followed by a new DT_PARENT() API in devicetree.h.

The _PARENT node should be defined for each node, so that it would be possible to traverse back from child note, for example from:
DT_N_S_soc_S_uart_40002000_P_interrupts
it would be nice to get
DT_N_S_soc_S_uart_40002000.
This way it may be possible, for example to get DT entry for flash that is holding given partition, e.g.:
DT_PARENT(boot0_partition)
would return partitions node, that contains boot0_partition) of some flash device, but
DT_PARENT(DT_PARENT(boot0_partition)) would give flash node.

The _PARENT node should be defined for each node,

It is defined for each node. That's what this PR is doing.

so that it would be possible to traverse back from child note, for example from:
DT_N_S_soc_S_uart_40002000_P_interrupts

That's a property value, not a node identifier. I'm confused. Why do you need to go from a property value to the node?

it would be nice to get
DT_N_S_soc_S_uart_40002000.

I'm not sure what you mean, but it doesn't work this way. Property macros expand to C rvalues, unlike node identifiers, which are not values.

What I mean is that having this:
#define DT_N_NODELABEL_boot_partition DT_N_S_soc_S_flash_controller_4001e000_S_flash_0_S_partitions_S_partition_0
I want to traverse back to this identifier:
DT_N_S_soc_S_flash_controller_4001e000_S_flash_0
So that I could use it to get properties from it, for example use the DT_LABEL to get the dev name.

So that I could use it to get properties from it, for example use the DT_LABEL to get the dev name.

D'oh. That was my goal, and I failed. Fixed now, thank you.

D'oh. That was my goal, and I failed. Fixed now, thank you.

Now it works as expected, thanks!


Replication Status is always rendered as NOT_ACTIVATED when downloading the Report as CSV

Required Information

[X] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM 6.5.12
[X] ACS AEM Commons Version: 5.0.14
[X] Reproducible on Latest? yes, tested also in 5.2.0

Expected Behavior
When downloading a report as CSV the "Replication Status Column" (documentation) must show the same value than in the HTML rendered report.
Actual Behavior
When downloading a report as CSV the "Replication Status Column" always shows the status "NOT_ACTIVATED"

After debugging the code this is what I found:

PageReplicationStatusModel -> getReplicationStatus() ignores the Resource that is passed as a parameter: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/reports/models/PageReplicationStatusModel.java#L104
Instead it uses the resource that represents the Replication Status Column (the column definition).
ReplicationStatus is null and the default value "Status.NOT_ACTIVATED" is used.

Steps to Reproduce

Navigate to ACS Commons Reports: /apps/acs-commons/content/reports.html
Open the sample Page Report: /editor.html/var/acs-commons/reports/sample-page-report.html
Select the "Path" of a known site, for instance: /content/we-retail (make sure that there are published pages)
Click on "Execute Report.
Click on "Download Report"
Compare the Replication Status Column.

Links

Report Builder, Replication Status Column documentation: https://adobe-consulting-services.github.io/acs-aem-commons/features/report-builder/configuring.html
ReportCSVExportServlet code: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/reports/internal/ReportCSVExportServlet.java#L165
PageReplicationStatusModel code: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/reports/models/PageReplicationStatusModel.java#L104

Fixed with https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2820

Fixed with #2820

Thank you!

Fixed in 5.3.0

This issue still exists with version 5.3.0 - Can this task be re-opened ?

Sure - can you PR a fix when you have a moment? Might be helpful to post your AEM version and ACS Commons version as well - since this was fixed before and now seems to have broken again; will be interesting to understand the cause a bit more.


Fedora 27

Would you mind enabling builds in F27?
Thanks a lot!

It's enabled now.  Looks like I forget to check the box for "Follow Fedora branching", which I believe will handle this automatically in the future.
The F27 build is queued up and should finish soon.

I think something went wrong? The only F27 package I can see is 4 months old. There are some fresh ones for F28.

On a test F27 system I can add the repo and install the package successfully.  Here is the build.    You may be confused because the version in that build says 0.7.1-1.fc28, but that is just the version-release string from the source RPM.  At the bottom of the page you can see that it was built for the fedora-27-x86_64 chroot.


Wrong report position on path-excludes-patterns rule

Describe the bug
Rule path-excludes-patterns reports on PathItem value instead of a key when referencing the PathItem value.
To Reproduce
Steps to reproduce the behavior:

Given this .redocly.yaml file:

styleguide:
  extends: []
  rules:
    path-excludes-patterns:
      severity: error
      patterns:
        - \/WRONG

And this OpenAPI file(s)

# openapi.yaml
openapi: 3.0.0
paths:
  '/WRONG':
    $ref: value.yaml

# value.yaml
get:
  summary: wrong get

Run this command with these arguments... redocly lint openapi.yaml
See error

Expected behavior
It should report on the PathItem key (e. g. /WRONG:) as it does for not referenced paths items.
Redocly Version(s)
1.0.0-beta.105
Node.js Version(s)
v16.14.0

I wonder if we could deprecate this rule in favour of a custom rule. This will work even better:
rules:
  rule/path-exclude:
    subject:
      type: Paths
    assertions:
      notPattern: \/WRONG

The configurable rule looks like a better solution to me. How do we deprecate  rule though? How about publishing this as a cookbook recipe and linking to it from the changelog, adding a deprecation notice to the config linting if someone is using this rule?

Added the docs: https://github.com/Redocly/redocly-cli-cookbook/pull/21.


[bug] WebView Fixed Runtime not found in development

Describe the bug
I need to develop an application for Windows that ships with a fixed version of the WebView2 runtime.
I followed the instructions provided in the docs: downloaded the latest version, unzipped it, and updated the tauri.conf.json file accordingly.
The production application (generated with npm run tauri build) works flawlessly.
However, in development (npm run tauri dev) the application crashes during bootstrap due to the following error:
thread 'main' panicked at 'error while running application: Runtime(CreateWebview(WebView2Error(WindowsError(Error { code: 0x80070002, message: The system cannot find the file specified. }))))'

This is really strange. It looks like, during development, Tauri is unable to find the correct directory (maybe a working directory issue?) where the runtime is located.
If I change the configuration to not use a Fixed runtime, the application starts without any problem.
Reproduction
https://github.com/carlocorradini/tauri-webview
Expected behavior
Tauri should find the WebView runtime and start without any error.
Platform and versions
[✔] Environment
    - OS: Windows 10.0.19045 X64
    ✔ WebView2: 114.0.1823.67
    ✔ MSVC:
        - Visual Studio Build Tools 2019
        - Visual Studio Community 2022
    ✔ rustc: 1.70.0 (90c541806 2023-05-31)
    ✔ Cargo: 1.70.0 (ec8a8a0ca 2023-04-25)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 18.16.0
    - npm: 9.5.1

[-] Packages
    - tauri [RUST]: 1.4.0 (no manifest)
    - tauri-build [RUST]: 1.4.0 (no manifest)
    - wry [RUST]: 0.24.3 (no manifest)
    - tao [RUST]: 0.16.2 (no manifest)
    - @tauri-apps/api [NPM]: 1.4.0
    - @tauri-apps/cli [NPM]: 1.4.0

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../build
    - devPath: http://localhost:5173/
    - framework: Svelte
    - bundler: Vite

Stack trace
No response
Additional context
Maybe: Windows only related

Same here

Hmm, i'm having trouble reproducing this issue. What i tried:

create-tauri-app then follow the docs. No matter if i have evergreen installed or not, the webview starts fine.
 No matter if i have evergreen installed or not, the webview starts fine.

fwiw here's the tauri info output from your repro repo:
[✘] Environment
    - OS: Windows 10.0.19045 X64
    ✘ Webview2: not installed!
      Visit https://developer.microsoft.com/en-us/microsoft-edge/webview2/
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.70.0 (90c541806 2023-05-31)
    ✔ Cargo: 1.70.0 (ec8a8a0ca 2023-04-25)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 18.16.0
    - pnpm: 8.6.7
    - yarn: 1.22.19
    - npm: 9.5.1

[-] Packages
    - tauri [RUST]: 1.4.1
    - tauri-build [RUST]: 1.4.0
    - wry [RUST]: 0.24.3
    - tao [RUST]: 0.16.2
    - @tauri-apps/api [NPM]: 1.4.0
    - @tauri-apps/cli [NPM]: 1.4.0

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist
    - devPath: http://localhost:1420/
    - bundler: Vite

Gonna try on a new windows installation later.

Note that in my Windows (dev machine) the Runtime is installed. It may cause some conflicts?

That's what i meant with evergreen. I tried it with the runtime being installed and uninstalled and both worked 🤔

The strange thing is that every other type of WebView2 works as a charm when developing. But with the fixed version it panics :/

@jeffshadap Can you try the example repo with your setup?
Does it work or still panic?

Gonna try on a new windows installation later.

well, good news i guess. Your repro crashes for me too after re-installing Windows.

""Good News"" 😰😂

^ Fixed in the next release: https://github.com/tauri-apps/tauri/pull/7419 (forgot that merging into v1 branch doesn't close issues anymore without manually linking them)

Awesome thanks 😎


warehouse_ros_mongo: 2.0.1-2 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository warehouse_ros_mongo to 2.0.1-2:

upstream repository: https://github.com/ros-planning/warehouse_ros_mongo.git
release repository: https://github.com/moveit/warehouse_ros_mongo-release.git
distro file: foxy/distribution.yaml
bloom version: 0.10.7
previous version for package: 2.0.1-1

warehouse_ros_mongo
* Fix installation path for FindMONGODB.cmake (#42 <https://github.com/ros-planning/warehouse_ros_mongo/issues/42>)
* Fix cmake export of MONGODB dependency (#41 <https://github.com/ros-planning/warehouse_ros_mongo/issues/41>)
* Contributors: Jafar Abdi, Robert Haschke, Tyler Weaver

@henningkayser FYI this is only a debian increment did you change content in the release repo for the rebuild?

@henningkayser FYI this is only a debian increment did you change content in the release repo for the rebuild?

Right, this increment is redundant. There aren't any changes that require a new release. The next one will be a patch, so feel free to skip this.


RFC for trait bounds on generic parameters of const fns

Rendered
cc @Centril @RalfJung @eddyb
Once we have gone through the process here, I'll post the final result on the regular RFC repo
Previous discussion: https://github.com/rust-rfcs/const-eval/issues/1
Glossary:

RPIT (return position impl trait)
const context

From all options proposed, this appears to be the most minimal one that gets the problem solved, and it also appears to be forward compatible with all others (supporting traits with const methods, an effect system, etc.).
Its a bit of a shame that all methods of an implementation must be const, but one has to start somewhere, and even if we were to relax this in the future, we might still want "sugar" for the cases in which the user wants to implement all methods as const anyways.
So thumbs up from me.

Would it make sense to make it obvious in the bound that the impl must be const ? For example using T: const impl Foo ? We might want to allow requiring const impls in non-const functions in the future:
trait Bar { fn bar(&self) -> usize; }
/*not const*/ fn foo<T: const impl Bar>(x: T) {
      const X: usize = x.bar();
}

Ah I have no thought about this use-case. It probably is more sensible to stay forward compatible by using the explicit annotation alternative instead of punting to an opt out in the future. I'll adjust the RFC accordingly

Very glad to see an RFC for this finally! Looks like a good path forward to me. Effect systems (for const and other things) would be great in the future, but yes, that involves significant technical investment... this is a good compromise for now.

I like most of it, but I think I'd prefer this alternative:

One could require no const on the bounds (e.g. T: Trait) and assume constness for all bounds. An opt-out via T: ?const Trait would then allow declaring bounds that cannot be used for calling methods. This design causes discrepancies with const fn pointers as arguments (where the constness would be needed, as normal function pointers already exist as the type of constants). Also it is not forward compatible to allowing const trait bounds on non-const functions

The thing is, you already kind-of have all the complexity of this alternative in your proposal when you say

The const requirement is propagated to all bounds of the impl or its methods,

I find it rather inconsistent to do automatic propagation on const bounds on const impl but not on const fn.
Moreover, I assume that your triple_add is callable at run-time even with a non-const impl, right? So the bound is also somewhat misleading.

I find it rather inconsistent to do automatic propagation on const bounds on const impl but not on const fn.

True. We could require manually annotating everything inside const impls for now to stay consistent and forward compatible.

I don't think this provides a workable solution for deriving (short of #[derive(const Clone)] - which I don't hate, but I don't know if it fits in with everything - cc @petrochenkov @alexcrichton).
But also, I think it should be stated more clearly what the difference is between const fn callers versus runtime fn callers, and how supertraits and implied bounds interact with this proposal.

Another drawback to keep in mind is the syntactic similarity to const X: T params.

I don't think this provides a workable solution for deriving (short of #[derive(const Clone)] - which I don't hate, but I don't know if it fits in with everything

There's no way around this. Imagine the following situation:
struct Foo;
const impl Clone for Foo {
    fn clone(&self) -> Self { Foo }
}
#[derive(Clone)]
pub struct Bar(Foo);

If we automagically made the derived Clone impl for Bar const, and internally changed the const impl Clone for Foo to impl Clone for Foo, we'd be breaking users of the crate that used Bar::clone in const contexts. This is exactly why we have const fn instead of inferring the constness from the body: semver compatibility.

@centril I think this is ready for opening a full RFC in the RFC repo. Do you want to do a review before I do this?

@scottmcm brought up a point on discord:
We have unsafe impl Foo for Bar {}, which means that it's an impl for an unsafe trait Foo, not that all methods being implemented are unsafe.
In contrast to that, unsafe fn means the function can only be called in unsafe blocks and const fn means the function can be called in const contexts.
So const impl Foo for Bar {} gives a new meaning to a modifier in a place where another modifier has a different meaning.
I am changing this RFC to use impl const Foo for Bar {}, which has the nice symmetry of having the const infront of the trait name like in bounds (T: const Trait).

This looks pretty good; the one additional thing I'd like to see is a plan for how to write generic impls  when a generic type has a impl for a const trait.  For example, how do we have std::cmp::rev impl Ord or const Ord appropriately and without breaking anyone?

In this design, how would I go about annotating specific functions within a trait as const? Is there some way to do the following?
trait Foo {
    const fn do_stuff(a: usize) -> usize;
}

const fn bar<T: Foo>(a: usize) -> usize {
    T::do_stuff(a)
}

No, that is orthogonal to this RFC. Marking a function as const fn in a trait means that all impls of the trait will need to provide a const fn. While interesting, I have yet to see a case where this would be useful. This RFC does allow you to define
trait Bar {
    fn do_stuff(a: usize) -> usize;
}

const fn do_stuff<T: const Bar>(a: usize) -> usize {
    Bar::do_stuff(a)
}

which amounts to the same thing, but it's not an associated constant function.

Thanks for the clarification. The motivation for this is a scenario where you want some items in a trait to be const, but not necessarily others, and all reasonable impls of the trait would be able to satisfy const-ness for the relevant items. I have some code that could benefit from this sort of fine-grained const-ness.
The RFC does actually enable something like this, but in a slightly hacky way:
trait _Foo {
    fn do_stuff(a: usize) -> usize;
}

trait Foo: const _Foo {
    fn other_fn();
}

const fn bar<T: Foo>(a: usize) -> usize {
    T::do_stuff(a)
}

Would the above work? Note the lack of a const bound in T: Foo.

That would not really work with just this RFC, since const bounds on trait declarations are not something discussed at all. You can still get that split by only adding a const bound for the trait where you actually need the bounds:
trait FooA {
    fn do_stuff(a: usize) -> usize;
}

trait FooB: FooA {
    fn other_fn();
}

const fn bar<T: FooB + const FooA>(a: usize) -> usize {
    T::do_stuff(a)
}

Thanks everyone for the critical reviews and constructive commentary. I believe this RFC is ready now and I'll open a regular rust RFC some time today


Version v0.11

Updated draw_state dependency and bumped all the versions.
Also closes #838

Thanks! Looks like the CI is happy, so we can merge and publish, at last.
@homu r+

:pushpin: Commit 0b24992 has been approved by kvark

:zap: Test exempted - status


Choose a logo!

First one is a river (becuase the Seine)

Second one is more techy and futuristic

Please vote!

Vote for 1

Vote for 1. Great job!

Vote for 1, love it. Thanks @chenemii


test java client

[ ] add tests
[ ] verify tls support.

@lburgazzoli would you be interested this one. Once you verify TLS support. You can close this one.

tested tls https://github.com/coreos/jetcd/issues/162


Enhancements for groups

Hello @tonyofrancis
It would be nice to have things like:

Callback that a group has been enqueued
Callback with a group download progress which would be for instance the sum of progresses of all group's downloads with Status.DOWNLOADING divided by the count of downloads with status DOWNLOADING and QUEUED.
Callback that group download has finished

It would be useful for example when the group has downloads for all playlist songs and you want to track playlist download progress, etc.
Btw I was missing method like
fetch.getDownloadsInGroupWithStatus()  that accepts a list of statuses instead of single status.
What do you think?

@tonyofrancis Yeah, I query fetch database every two seconds either way so there wouldn't be  performance difference to me. Anyways having in on other thread won't make it problematic.
It may be also a good idea to create a method like setGroupProgressReportingInterval.
BTW I've just made a PR for querying groups with multiple query. Please have a look in free time.

Still working on this. Have been very busy lately. Hoping to get some time soon.

@marcin-adamczewski This enhancement has been added in the next release. will report back once released.

@marcin-adamczewski  Fetch version 3.0.0 has been released with FetchGroupListener. Please have a look and let me know what you think. Thanks for your contribution.


digitemp: init at 3.7.2

Motivation for this change
Fixes #116667. Seems to work on production machine (currently a single-user Nix install on top of Gentoo, but I intend to replace the Gentoo with NixOS once this is added to nixpkgs).
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)

initial: adds ~0.7 MiB (derivation) + ~31 MiB (result)

[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Thanks @zseri


After adding resolution of hosts dynamically the maven repository was not updated

Hello,
Post bee6eec11bb896ef8b47dba4eb26ae4802da35c7 commit, the build was not uploaded on maven repository.Hence, facing issue with using the library.
Kindly upload the latest build on maven repositoy.
Thanks a lot.

@seekprateek I've forked the library due to a pressing need for Cassandra driver 3.x support. Feel free to have a try and let me know if you find any issues.
Link: https://github.com/builtamont-oss/cassandra-migration


HBASE-26625 ExportSnapshot tool failed to copy data files for tables …

…with merge region

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 24s
master passed

+1 :green_heart:
compile
4m 27s
master passed

+1 :green_heart:
checkstyle
1m 31s
master passed

+1 :green_heart:
spotbugs
3m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
4m 26s
the patch passed

+1 :green_heart:
javac
4m 26s
the patch passed

-0 :warning:
checkstyle
0m 21s
hbase-mapreduce: The patch generated 1 new + 14 unchanged - 1 fixed = 15 total (was 15)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 40s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
3m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

58m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3981

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux d9a44a6ac78e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3f59f21be0

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
master passed

+1 :green_heart:
compile
1m 29s
master passed

+1 :green_heart:
shadedjars
8m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
1m 29s
the patch passed

+1 :green_heart:
javac
1m 29s
the patch passed

+1 :green_heart:
shadedjars
8m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
148m  3s
hbase-server in the patch passed.

+1 :green_heart:
unit
11m 16s
hbase-mapreduce in the patch passed.

192m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3981

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 53c9debba01d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3f59f21be0

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/testReport/

Max. process+thread count
4491 (vs. ulimit of 30000)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 20s
master passed

+1 :green_heart:
compile
1m 51s
master passed

+1 :green_heart:
shadedjars
9m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  4s
the patch passed

+1 :green_heart:
compile
1m 49s
the patch passed

+1 :green_heart:
javac
1m 49s
the patch passed

+1 :green_heart:
shadedjars
9m 12s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
204m 13s
hbase-server in the patch passed.

+1 :green_heart:
unit
15m  7s
hbase-mapreduce in the patch passed.

257m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3981

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 645b0d6ac1a9 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3f59f21be0

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/testReport/

Max. process+thread count
3450 (vs. ulimit of 30000)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3981/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Bind mount /dev/null

Fix #49

Upon further investigation, the issue seems to be caused by /tmp/ being mounted with "nodev,noexec" flags. It has nothing to do with Ubuntu version.


Node Exporter broken link

What did you do?
https://prometheus.io/docs/guides/node-exporter/
In the first code block is this line:
wget https://github.com/prometheus/node_exporter/releases/download/v*/node_exporter-*.*-amd64.tar.gz
Which generates:

2022-12-25 04:57:23 ERROR 404: Not Found.

What did you expect to see?
A download.
What did you see instead? Under which circumstances?
System information
No response
Prometheus version
No response
Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Hi there. I think it's implied that you're supposed to replace * with the version number you want to download.


[FUSION] exr trouble

Hi,
I encounter problems related to my rendering done under Vray (3dsmax).
Under Vray (3.6) 3dsmax I have no choice to go through the frame buffer to get the cryptoMatte.
To output an exr "cleanly" under vray 3dsmax it is necessary to use the aov's Vray (VrayOptionRE).
In this VrayOptionRE there are two options "exr auto data windows" and "exr multipart".
More information here :
https://docs.chaosgroup.com/display/VRAY3MAX/V-Ray+Render+Options+|+VRayOptionRE
When i check "exr auto data windows" cryptoMatte won't display properly and crash after test it on another layer.
When i check "exr multipart" cryptoMatte won't work and find nothing.
Because is a openExr 2 features ?
note :
I can not get out of this project because it is confidential.
But I will try to find some time to reproduce these problems

So,
I did a test next to it and I have exactly the same problems. (Fusion 9.0.2 build 15 studio)
I bring three exr file from 3dsmax 2017, vray 3.60.03 (i've made zip, can't attach .exr on gitHub)

exr_auto_data_window.exr

exr_multipart.exr

exr_normal.exr
bug_cryptomatte.zip

The first (exr_multipart.exr) > Fusion console :

...ion\Reactor\Deploy\Modules\Lua\cryptomatte_utilities.lua:335: attempt to index a nil value
stack traceback:
	...ion\Reactor\Deploy\Modules\Lua\cryptomatte_utilities.lua:335: in function 'get_manifest_string'
	...ion\Reactor\Deploy\Modules\Lua\cryptomatte_utilities.lua:362: in function 'parse_manifest'
	...esign\Fusion\Reactor\Deploy\Fuses\Matte\cryptomatte.fuse:461: in function <...esign\Fusion\Reactor\Deploy\Fuses\Matte\cryptomatte.fuse:449>
Cryptomatte1 failed at time 0

The second (exr_auto_data_window.exr) :
I can't get anything, Fusion crash, and suddenly disappears.

The third works.

++

I forgot to mention that it was dedicated to fusion.
under Nuke it works perfectly

Hi @jeremybepoix
Just tried, here are my results/findings.
Same Fusion version (9.0.2 b15) but I'm on free.
exr_normal

Everything looks good here.
exr_auto_data_window

Everything looks good here too. Tried with proxy modes, auto proxy modes, all stable.
exr_multipart

In the console I'm seeing the following error pop up for every action by frame with Cryptomatte.
[string` "FFI Script"]:19579: attempt to index local 'img' (a nil value)
This error is not verbose at all, but from what I understand it usually means an image is being constructed out of invalid information. I followed my gut and started evaluating the layers and channels of the exr_multipart source image. Here are all the layers.

The default layer is the beauty, looks fine. The non-indexed one and the 00 are fine as well.
The remaining layers do not contain any information.  Cryptomatte needs at least the 00 and 01 to be valid. (@jonahf correct me if I'm wrong.)
Could you check your VRay setup for that?
Cheers
Cedric

hi,
bizarre, i try "exr_auto_data_window" here at work and it won't...
for "exr_multipart" I think it's openExr2 under fusion, because under nuke it work well.
Cryptomatte was install via reactor,
Hardxware :
xeon e5-2623 v3
gtx 1080ti
i'm not admin logged.

After several attempts, I give up, I do not understand why it works for you, not me ??
while the only difference is Fu studio/free. Werid isn't it?
And i reapeat, all exr work well under nuke.

@cedricduriau It only needs to 00 layer to be valid. That will give it two ID/coverage pairs.

I believe to have rammed into the same issue here, though my source files come from Blender Cycles. I have modified the lua code a bit to get some debug output in the console of Fusion, here is the end of said log and the error message:
SHELL.196
SHELL.196
4377306624

M1711531000
M1711531000
-1.8126756762271e-09

57305016100_4.052
57305016100_4.052
-3.8591812767663e-07

SHELL.096
SHELL.096
nan

SHELL.096 is nan!!
...agic Design\Fusion\Modules\Lua\cryptomatte_utilities.lua:889: table index is NaN
stack traceback:
	...agic Design\Fusion\Modules\Lua\cryptomatte_utilities.lua:889: in function 'parse_manifest'
	...agic Design\Fusion\Modules\Lua\cryptomatte_utilities.lua:732: in function 'initialize'
	...agic Design\Fusion\Modules\Lua\cryptomatte_utilities.lua:921: in function 'create_cryptomatte_info'
	...ng/Blackmagic Design/Fusion/Fuses/Matte/cryptomatte.fuse:583: in function <...ng/Blackmagic Design/Fusion/Fuses/Matte/cryptomatte.fuse:568>
Cryptomatte1 failed at time 1

now, this is the code I used to get the debug output:
function CryptomatteInfo:parse_manifest(manifest)
    --[[
    Parse the manifest to store matte id and name information for fast lookup.

    :param manifest: manifest to parse
    :type manifest: table
    --]]
    local from_names = {}
    local from_ids = {}
    local all_names = {}
    local all_ids = {}

    for name, hex in pairs(manifest) do
        -- decode hash to int
        int_flt.i = tonumber(hex, 16)
        -- decode int to float
        local id_float = int_flt.f
        local name_str = tostring(name)
        print(name)
        print(name_str)
        print(id_float)
        print()

        if (id_float ~= id_float) then
            print(string.format("%s is nan!!", name_str))
        end

        -- store name by id float
        from_names[name_str] = id_float
        -- store id float by name
        from_ids[id_float] = name_str
        -- store name in set
        all_names[name_str] = true
        -- store id float in set
        all_ids[id_float] = true
    end

    -- create name to id from hexadecimal value of names
    self.cryptomattes[self.selection]["name_to_id"] = from_names
    self.cryptomattes[self.selection]["id_to_name"] = from_ids
    self.cryptomattes[self.selection]["names"] = all_names
    self.cryptomattes[self.selection]["ids"] = all_ids
end

So what you can see is that one if the id_float values indeed becomes nan causing the script to crash at that point. Then, I tried refactoring the code to only proceed if said id_float is not nan:
function CryptomatteInfo:parse_manifest(manifest)
    --[[
    Parse the manifest to store matte id and name information for fast lookup.

    :param manifest: manifest to parse
    :type manifest: table
    --]]
    local from_names = {}
    local from_ids = {}
    local all_names = {}
    local all_ids = {}

    for name, hex in pairs(manifest) do
        -- decode hash to int
        int_flt.i = tonumber(hex, 16)
        -- decode int to float
        local id_float = int_flt.f
        local name_str = tostring(name)

        if (id_float ~= id_float) then
            print(string.format("%s is nan!!", name_str))
        else
            -- store name by id float
            from_names[name_str] = id_float
            -- store id float by name
            from_ids[id_float] = name_str
            -- store name in set
            all_names[name_str] = true
            -- store id float in set
            all_ids[id_float] = true
        end
    end

    -- create name to id from hexadecimal value of names
    self.cryptomattes[self.selection]["name_to_id"] = from_names
    self.cryptomattes[self.selection]["id_to_name"] = from_ids
    self.cryptomattes[self.selection]["names"] = all_names
    self.cryptomattes[self.selection]["ids"] = all_ids
end

But no luck: there are a few more nan values detected, but before the image processing is completed Fusion simply crashes. I don't have this in every file, only in more complex ones with a high number of object IDs (in the thousands).

Same error here:
...ion/Reactor/Deploy/Modules/Lua/cryptomatte_utilities.lua:880: table index is NaN
stack traceback:
	...ion/Reactor/Deploy/Modules/Lua/cryptomatte_utilities.lua:880: in function 'parse_manifest'
	...ion/Reactor/Deploy/Modules/Lua/cryptomatte_utilities.lua:732: in function 'initialize'
	...ion/Reactor/Deploy/Modules/Lua/cryptomatte_utilities.lua:912: in function 'create_cryptomatte_info'
	...esign/Fusion/Reactor/Deploy/Fuses/Matte/cryptomatte.fuse:583: in function <...esign/Fusion/Reactor/Deploy/Fuses/Matte/cryptomatte.fuse:568>

Ubuntu 20.04; Blender 2.91 + Fusion 9.02b15. Cryptomatte installed via Reactor.
2,560 objects in the Blender file... I also tried "dialing things down to just Assets + 2 Levels. No go.

@garyritchie and @aliasguru I believe you are experiencing the issue that PR https://github.com/Psyop/Cryptomatte/pull/120 is designed to fix.

Updates the Fusion implementation to deal with the exponent properly when converting the hash to float
This fixes the issue where the fuse can't load the manifest because the hash to float conversion may create NaNs in some cases.

This is a different issue than the one @jeremybepoix is reporting.

Fixed with cedricduriau#11, cedricduriau#14 and cedricduriau#43


Handle case in which a sub shell connection dies while parent shell is still alive

Right now, this confuses the shell handling logic and will lead to commands that are intended for the sub shell being sent to the parent shell.

Implemented


Different service for notifications possible?

Hello!
I am switching to a different notifications platform...I was wondering if it's possible for Keymaster-basic to support ntfy.  I'm not sharp enough to be able to modify the .yaml myself...I was hoping to ask for your help!
Here's the page from Ntfy for supporting Home Assistant.  Specifically, there's this section:
notify:
  - name: ntfy
    platform: rest
    method: POST_JSON
    data:
      topic: YOUR_NTFY_TOPIC
    title_param_name: title
    message_param_name: message
    resource: https://ntfy.sh

Thank you for taking the time to look at this.  Please let me know if I can do any testing or anything to help.

It should be notify agnostic. Once you setup a notify service you can add it in notify group.  I am assuming that ntfy is using the standard notification setup for home assistant. https://www.home-assistant.io/integrations/notify/


Conflict with photoshop hotkeys

Hello,
I am using karabiner at the moment to map esc to cap locks. When I am running karabiner and using photoshop however I can no longer press space pan. When I quit karabiner it works fine.

#222

Duplicate issue, see ticked listed above.


Assign PAR SNPs before deduplicating XY chroms

PAR SNPs should be assigned to X or Y before deduplicating alleles.

Codecov Report

Merging #78 into develop will increase coverage by 1.34%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop      #78      +/-   ##
===========================================
+ Coverage    91.49%   92.83%   +1.34%
===========================================
  Files            9        9
  Lines         1352     1312      -40
  Branches       244      244
===========================================
- Hits          1237     1218      -19
+ Misses          70       49      -21
  Partials        45       45

Impacted Files
Coverage Δ

src/snps/snps.py
93.04% <33.33%> (+1.40%)
:arrow_up:

src/snps/snps_collection.py
92.17% <0.00%> (-0.33%)
:arrow_down:

src/snps/io/reader.py
97.02% <0.00%> (-0.04%)
:arrow_down:

src/snps/resources.py
94.73% <0.00%> (+0.03%)
:arrow_up:

src/snps/ensembl.py
65.85% <0.00%> (+34.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60f46c...981185a. Read the comment docs.


how to enforce "this interface A should be a descendent of an empty interface B"?

I'm trying to enforce "IContext should be a descendent of IContextBase", even though IContextBase is empty.
With current set-up, I can only do:
interface IContextBase {
  __EXTENDS_ICONTEXT_BASE: null;
}
interface IPropsBase {
  __EXTENDS_IPROPS_BASE: null;
}
interface ITestContext extends IContextBase { ... }
class Test1<
   IContext extends IContextBase
   , IProps extends IPropsBase
> { ... }

but this method is quite cumbersome because I have to keep making variables with '__EXTENDS_IPROPS_BASE' in it:
const textContext: ITestContext = {
   __EXTENDS_CONTEXT_BASE: null,
   // ...other fields for ITestContext
}

Is there a better way?
ps: my question on stackoverflow might be relevant: https://stackoverflow.com/questions/44455020/tricking-typescript-compiler-to-assign-wrong-interface-to-a-variable

Related: #202

also see https://github.com/Microsoft/TypeScript/issues/4895

@andy-ms are you refering to https://github.com/Microsoft/TypeScript/issues/202#issuecomment-302402671 ?
In that case, the following snippet fails :(
@aleksey-bykov but that doesn't work for interfaces / etc:
declare class As<S extends string> {
   private as: S;
}
type Basket = {
   a?: number
} & As<'basket'>

const testBasket: Basket = {} // error: no 'as' in {}

#202 is the issue for nominal types, which seems to be what you want. I don't think there's any solution that would allow you to use an object literal as a nominal type without a cast.
#4895 is related to nominal types since it would allow you to have additional information about an object without actually adding any additional properties to that object.
If you want to enforce that you only accept objects explicitly declared as an IPropsBase, you could always use a function like function createProps<T>(props: T): T & IPropsBase { return props as T & IPropsBase; }, but you would have to call it everywhere you use props.
You could also just use an abstract base class for PropsBase with an unused private member and have everything else inherit from it.

@devdoomari - as @aleksey-bykov pointed out in https://github.com/Microsoft/TypeScript/issues/202#issuecomment-308387009, but in case you didn't see it, all you need is a cast:
declare class As<S extends string> {
   private as: S;
}
type Basket = {
   a?: number
} & As<'basket'>

// Casts are always necessary
const testBasket: Basket = {} as Basket

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Failed to update GitLab project error appears when enforced CLA

Steps :

Login Admin portal
Navigate to easyCla GitLab : https://feature-cla-gitlab.pcc-fb.dev.platform.linuxfoundation.org/project/a09410000182dD2AAI/tools/easycla/repositories/a092M00001If9v8QAB#40af3652-e8bf-489d-a917-cb2214a89640
Now enforced CLA

Actual Results : Failed to update GitLab project error appears
`Time: August 27, 2021 at 5:20:13 PM GMT+5

Error: {"headers":{"normalizedNames":{},"lazyUpdate":null},"status":400,"statusText":"OK","url":"https://pcc-bff.dev.platform.linuxfoundation.org/development/api/cla-services/project/a09410000182dD2AAI/gitlab/repositories","ok":false,"name":"HttpErrorResponse","message":"Http failure response for https://pcc-bff.dev.platform.linuxfoundation.org/development/api/cla-services/project/a09410000182dD2AAI/gitlab/repositories: 400 OK","error":{"status":400,"stack":"","details":null,"message":"EasyCLA - 400 Bad Request - problem fetching GitLab repositories for projectSFID: a09410000182dD2AAI - error: GitLab repository not found - project SFID: a09410000182dD2AAI","code":"400","requestId":"ee0197c0-072c-11ec-ae36-a9d16a83182d"}}

Additional Information: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36`

https://images.zenhubusercontent.com/194341141/d84011b1-0e3c-4071-b2e6-c517290c497f/failed_to_update_gitlab_project.mp4

Hi @dealako ,
Issue is tested with the project & GitLab group mentioned in descriptions & now I am getting 422 error
Error on support link :
Time: October 13, 2021 at 10:55:30 AM GMT+5

Error: {"headers":{"normalizedNames":{},"lazyUpdate":null},"status":422,"statusText":"OK","url":"https://pcc-bff.dev.platform.linuxfoundation.org/development/api/cla-services/project/a092M00001If9v8QAB/gitlab/repositories","ok":false,"name":"HttpErrorResponse","message":"Http failure response for https://pcc-bff.dev.platform.linuxfoundation.org/development/api/cla-services/project/a092M00001If9v8QAB/gitlab/repositories: 422 OK","error":{"status":422,"stack":"","details":null,"message":"cla_group_id in body should match '^[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?4[a-fA-F0-9]{3}-?[89ab][a-fA-F0-9]{3}-?[a-fA-F0-9]{12}$'","code":605,"requestId":""}}

Additional Information: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36

API Request :
Request URL: https://pcc-bff.dev.platform.linuxfoundation.org/development/api/cla-services/project/a092M00001If9v8QAB/gitlab/repositories
Request Method: PUT
Status Code: 422

Request payload:
{cla_group_id: "40af3652-e8bf-489d-a917-cb2214a89640 Now enforced CLA",…}
cla_group_id: "40af3652-e8bf-489d-a917-cb2214a89640 Now enforced CLA"
enroll: [30108147, 30108164, 30108177]
0: 30108147
1: 30108164
2: 30108177
unenroll: []

API Response :
{status: 422, stack: "", details: null,…}
code: 605
details: null
message: "cla_group_id in body should match '^[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?4[a-fA-F0-9]{3}-?[89ab][a-fA-F0-9]{3}-?[a-fA-F0-9]{12}$'"
requestId: ""
stack: ""
status: 422

Project details :

OPENCOLORIO

GitLab Group :

gitlab.com/groups/linuxfoundation/product/easycla/demo581

Refer Video clip :
https://images.zenhubusercontent.com/194341141/66495f7e-66a8-4bc3-8039-009f29395beb/3207.mp4

Tested issue on reported project & found that it is not reproducible, So making issue status QA-Done


Bottom tab bar is not hiding under keyboard / only taking the props of tabBarActiveBackgroundColor

i installed the library it is working fine but tab bar is not hiding under keyboard modal . i set the  "tabBarHideOnKeyboard: true" in the screenOption. kindly let me the if there is any work around  or solution whatever it is Thanks

Hi,
Thank you for the feedback,
I see the problem, I don't have a workaround right now, i'll give it a check by tomorrow morning :)

Hi,
I think i've to do something for this case, at the moment you could wrap the tabBar component with a component that handle this.
Something like :
`const HideOnKeyboard: React.FC = (props) => {
const [hidden, setHidden] = React.useState(false);
React.useEffect(() => {
const keyboardDidShowListener = Keyboard.addListener(
'keyboardDidShow',
keyboardDidShow,
);
const keyboardDidHideListener = Keyboard.addListener(
'keyboardDidHide',
keyboardDidHide,
);
return () => {
keyboardDidShowListener.remove();
keyboardDidHideListener.remove();
};
});
const keyboardDidShow = () => {
setHidden(true);
};
const keyboardDidHide = () => {
setHidden(false);
};
return !hidden && props.children;
};`


Roll engine 2db327657369..7a05fcbdbe52 (38 commits)

https://github.com/flutter/engine/compare/2db327657369...7a05fcbdbe52
git log 2db327657369..7a05fcbdbe52 --first-parent --oneline
2020-05-01<EMAIL_ADDRESS>Revert "Remove Samsung workarounds (#17612)" (flutter/engine#18081)
2020-05-01<EMAIL_ADDRESS>Don't depend on an implicit transaction when presenting drawables on the raster thread. (flutter/engine#18076)
2020-05-01<EMAIL_ADDRESS>Roll src/third_party/skia 5ba50afeed4c..e55e56038cf4 (26 commits) (flutter/engine#18088)
2020-05-01<EMAIL_ADDRESS>Introduce TaskRunnerChecker, TaskRunnerAffineWeakPtr (flutter/engine#17649)
2020-05-01<EMAIL_ADDRESS>Introduce runtime check that it is root isolate that makes UI native calls. (flutter/engine#18050)
2020-05-01<EMAIL_ADDRESS>[fuchsia] set vsync_offset based on config file (flutter/engine#18006)
2020-05-01<EMAIL_ADDRESS>Add an API for resyncing output streams (flutter/engine#18070)
2020-05-01<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from KcV-O... to cIjMH... (flutter/engine#18083)
2020-05-01<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from rxvhs... to 2VquQ... (flutter/engine#18079)
2020-04-30<EMAIL_ADDRESS>[web] Add TargetPlatform tests (flutter/engine#18065)
2020-04-30<EMAIL_ADDRESS>Bundle the validation layers and enable them if --enable-vulkan-validation-layers is specified to gn (flutter/engine#17854)
2020-04-30<EMAIL_ADDRESS>[fuchsia] Log unregistered platform channels only once (flutter/engine#18064)
2020-04-30<EMAIL_ADDRESS>[fuchsia] Use dart::ComponentContext() (flutter/engine#17876)
2020-04-30<EMAIL_ADDRESS>[web] First batch of unit tests for line breaker (flutter/engine#18034)
2020-04-30<EMAIL_ADDRESS>RendererContextManager (flutter/engine#17941)
2020-04-30<EMAIL_ADDRESS>make "flutter run --trace-systrace" work. (flutter/engine#18052)
2020-04-30<EMAIL_ADDRESS>Roll src/third_party/skia 21d1720203f4..5ba50afeed4c (1 commits) (flutter/engine#18056)
2020-04-30<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from WqvOR... to rxvhs... (flutter/engine#18055)
2020-04-30<EMAIL_ADDRESS>Roll src/third_party/skia 8a6f2ed4ffd4..21d1720203f4 (24 commits) (flutter/engine#18053)
2020-04-30<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from sKCYL... to KcV-O... (flutter/engine#18051)
2020-04-30<EMAIL_ADDRESS>soften shadows even more; fix shadow alpha (flutter/engine#18029)
2020-04-30<EMAIL_ADDRESS>Fix method handler control flow in Windows and Linux text input plugins (flutter/engine#17964)
2020-04-30<EMAIL_ADDRESS>Populate window.locale in Dart (flutter/engine#18043)
2020-04-30<EMAIL_ADDRESS>[web] Use correct shell operator to compare file limits (flutter/engine#18032)
2020-04-29<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 6VJ1C... to WqvOR... (flutter/engine#18038)
2020-04-29<EMAIL_ADDRESS>remove linux-chrome unit tests from cirrus CI (flutter/engine#18035)
2020-04-29<EMAIL_ADDRESS>[Metal] On context loss with a paused texture source, preserve external pixel buffer. (flutter/engine#18022)
2020-04-29<EMAIL_ADDRESS>Replace usage of NULL with nullptr to match coding style (flutter/engine#18023)
2020-04-29<EMAIL_ADDRESS>Roll src/third_party/dart 05b7f49c7267..53601ecc18e5 (15 commits) (flutter/engine#18036)
2020-04-29<EMAIL_ADDRESS>Revert all build changes made to test the Dart NNBD unfork CL. (flutter/engine#18033)
2020-04-29<EMAIL_ADDRESS>use clang on Windows (flutter/engine#17407)
2020-04-29<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from NeQ_8... to sKCYL... (flutter/engine#18026)
2020-04-29<EMAIL_ADDRESS>Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commits) (flutter/engine#18025)
2020-04-29<EMAIL_ADDRESS>Roll src/third_party/skia a50ce3c98357..8a6f2ed4ffd4 (3 commits) (flutter/engine#18024)
2020-04-29<EMAIL_ADDRESS>Use g_warning instead of stderr (flutter/engine#17994)
2020-04-29<EMAIL_ADDRESS>Roll src/third_party/dart 726d3c772554..207953f367e6 (79 commits) (flutter/engine#18021)
2020-04-29<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from arZdZ... to 6VJ1C... (flutter/engine#18018)
2020-04-29<EMAIL_ADDRESS>Roll src/third_party/skia 4baa7326ccfb..a50ce3c98357 (18 commits) (flutter/engine#18017)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
...

Gold has detected one or more untriaged digests on patchset 10.
Please triage them at https://flutter-gold.skia.org/search?issue=56148.

Commit queue failed; closing this roll.