Allow copying resources.

Sometimes if we are going to be doing operations on a resource, we want multiple copies of the resource. If all of the places it's being used are just references, editing it will change them all. This is not desirable for things like lights whose colors can be changed, because it is not possible to load the same light twice since the filename is the same; ResourceManager just gives us the first copy from the cache which has already been operated on. This is why caching was disabled for lights. Instead, we should be able to spawn a copy of any resource, especially FileType resources.

With font files, we need to load the file once for each pt size. We internally append a colon and a pt size number to the end of the filename in the cache to differentiate them. We could use this for copies as well, or we could give all resources Resource IDs by which they can be referenced, which is probably cleaner.

Makes sense for images.
Haven't heard of sound effects being copied before, though. Can you describe this? I'm asking because maybe we can skip it (for now?).

Editing images can be an expensive operation depending on how we support it.
What type of API do we want to support? The more flexible we are (the more control we give to game authors), the slower it'll be due to the hardware architecture of modern graphics processors.

Giving control over setting the color of every individual pixel is slow since this is done on the CPU & requires an upload to the GPU. Maybe we can get away with this, but maybe not. We can investigate.
SDL has built-in commands for multiplying a color in to a RenderCopy(). See SDL_SetTextureColorMod. We can change the color mod every frame & doesn't require copying a texture at all so can use the original image instance. This does not involve the CPU.
We might also be able to do slightly more complex image modifications by creating a texture, setting it as the SDL render target and drawing to it. This will keep all the drawing on the GPU & won't require a texture transfer.

Just noticed we already use SDL's color mod.
If that's all we need at this point I think it might be possible to use it without copying textures... Not sure though.

For sound files, whether it's playing or not and other settings are a property of SDL's handle on the sound file. Asking to play the same sound effect multiple times concurrently will give us a reference to the same place, so you can't limit operations to just one instance of it.

Asking the same sound chunk to play multiple times concurrently seems to work correctly.

In that case I may be mistaken. Since you've self-assigned it, try to break it.

Can't break it.
If it turns out broken later because of something I didn't catch open an issue.
I'm going to make color mods work. I believe after that we can resolve this issue!

Looks like SDL_mixer can only play 8 sounds at once.

Did you solve copying images? Currently, the user can only change an image by putting images, widgets, or lights on top of it. I don't think we support any advanced image editing features except the little we do with lights. If the user wants to do more complex stuff currently, we might want to give them a way to request the next frame from the framemanager so they can import PySDL2 in their script and do something with it.

Here's an idea to support copying of textures:
When we copy a texture, it is inserted into a LifetimeManager with a unique, randomly generated key. LifetimeManager is like CacheManager but doesn't use a TTL and just destroys objects as soon as they are not used anymore.

Actually LifetimeManager can use a list and doesn't need a key.

I think you can just merge that functionality into CacheManager.

Hey @seisatsu do you think it would be better for Driftwood to work with SDL Surfaces instead of Textures? I just read http://sdl.5483.n7.nabble.com/Proper-way-to-duplicate-a-SDL-Texture-td37434.html.
What they say in that thread also jibes with my own mental model of graphics programming. I'm not 100% certain since I don't know what your plans are for the graphics architecture, but IMO it sounds like you are thinking about images as SDL Surfaces.

BTW working on texture duplication. Will post a PR for it maybe tomorrow.
My previous comment is about the future of Driftwood graphics & your vision for it.

It's possible that I originally misunderstood in what cases there is benefit to using textures. I'll look over it.

I will post more info for this discussion & try to give my viewpoint on surfaces/textures tomorrow.

Both Surfaces and Textures are a 2D raster grid of pixels, but Surfaces are kept in system RAM while Textures are kept in video RAM.
On modern computers, the CPU can only read & write to system RAM and the GPU can only read & write to video RAM. Historically, this restriction came about because GPUs were mounted on a video card that often came with its own RAM chips. That was the video RAM, and it wasn't exposed to the CPU. Today, a growing number of systems use integrated GPUs that bundle the CPU and GPU on the same silicon die. It is technically possible, therefore, for the CPU on these systems to access video memory and for the GPU to access system memory. But to remain compatible with systems that use actual video cards & have dedicated, separate video RAM, programmers are not allows to take advantage of this technicality.
It is always possible to transfer the contents of a Surface to a Texture. That's how GPUs get all their data in the first place. But it's not always possible to transfer the contents of a Texture to a Surface. Whether you can or not actually depends on which hardware and which driver you're using. This is done for optimization reasons: graphics processors can be designed faster & more efficient if programmers follow the convention of never transferring Textures to Surfaces. And people like speed & low power usage so much, the designers of the hardware just didn't built the capability to even perform this transfer for every type of Texture. (That way you can prevent those pesky programmers from messing up the performance of your processor. Also, it's probably cheaper.)
Okay, so if the CPU isn't allowed to access & modify a Texture, how can we, the programmers, modify textures? We have to use the GPU. And the way that modern GPUs are designed is they have tens (Imagination Technologies & Intel) to hundreds or thousands (AMD & Nvidia) of cores. Shaders are how we program those cores, and as the power and efficiency of those cores increases year after year, the importance of using shaders increases as well.
Before GPUs were created, all graphics were done on the CPU, so all you had were (pre-SDL) Surfaces. Up until the mid-90s, all games were written using Surfaces. SDL 1.2 was behind the times when it came out because it only supported Surfaces & didn't support Textures.
With the use of Surfaces comes a particular way of thinking about graphics. You can pass around a Surface to anybody and they can write whatever they want to it. You have absolute freedom and control since, when you program, you control the CPU and the CPU controls Surfaces.
But when you use Textures you are limited by what your graphics API allows you to ask your GPU to do.
With Surfaces, you can't have very many pixels (hense the pixelated nature of old games) and you can't have a lot of complicated special effects because CPUs don't have enough processing power. The rise of shaders is what has allowed games to reach 720p, 1080p, and 4K resolutions, or to achieve modern lighting.
With Driftwood we have a choice.
Driftwood renders very low resolution frames, so its drawing can be done on the CPU. That is, we can do everything in Surfaces. This will be slow and power-hungry but will be the easiest to program. It also will allow a game author to develop their own special effects using just Python and no shaders.
Our other choice will be to use Textures. We'll have to learn how to talk to the graphics card & might need to learn OpenGL. But Textures will be faster, allowing the Raspberry Pi to achieve higher frame rates, and this will use less power on laptops.
A third option would be to combine Surfaces and Textures to try to get some of the advantages of both. But we have to be mindful of the one-way nature of the Surface to Texture transfer.

Oh, this whole time I was thinking that with textures we couldn't present the final composed frame to game authors so they can draw special effects on it. I was thinking only Surfaces could do that. That's actually where I was coming from when I was asking whether we should use Surfaces throughout the whole program, hahah.
But I just realized that if we create the back buffer with SDL_TEXTUREACCESS_TARGET then it will work, and it looks like we already do that.

It's possible the Surface / Texture discussion might come up again later but I think we can stick with Textures for now.

I had been using textures because I read that they were hardware accelerated while surfaces were not. Back then I didn't really understand what that meant. It's probably fine for now.
Eventually we will need textures anyway for things like shaders and environment-aware lighting.

Ok, so I looked over it, and basically what I'm doing is performing all graphical copy operations or other built-in operations such as changing alpha or color mod using textures. Operations with textures are accelerated by the GPU, while surfaces are not. Surfaces are only used where needed, but may eventually be needed for less trivial graphical operations that can't be accelerated.
If you can find a place where using textures actually makes us slower, it should be switched over to use surfaces.

We should find that all graphical operations can be accelerated but some may require the use of OpenGL, which neither of us know much about.
AFAICT textures will never make us slower than surfaces.


Make library work with Clang on Windows

This PR makes the library work with Clang on Windows:

Add a GitHub Action with Clang 9 and Clang 10 on Windows.
Replace all alternative operators and, or, not with &&, ||, !, respectively.
Remove a test case where Clang is choking on.

Closes #1818.
Closes #1119.
Closes #1898.

@nlohmann I guess include/nlohmann/detail/boolean_operators.hpp can then go as well?

@nlohmann I guess include/nlohmann/detail/boolean_operators.hpp can then go as well?

Good catch!

Coverage remained the same at 100.0% when pulling 6477b9b20a471c96c33b97347dc5a667d0d06e2d on clang_windows into cbafed349493dd8b072b5c1c5ac7f7c0ef0ed7df on develop.

🔖 Release item
This issue/PR will be part of the next release of the library. This template helps preparing the release notes.
Type

[ ] ✨ New Feature
[ ] 🐛 Bug Fix
[x] ⚡ Improvement
[ ] 🔨 Further Change
[ ] 🔥 Deprecated function

Description

The library can be compiled with Clang on Windows. #1818 #1119 #1898 #2259


Where is freed dtlsSession ?

An object of type session_t is allocated in the examples/shared/dtlsconnection.c file on line 428
connP->dtlsSession = (session_t *)malloc(sizeof(session_t));
I was wondering where is this object deallocated?
I am porting Wakaama to a non-posix platform, trying to keep as close as possible to the examples, but I could not find the point where I should deallocate this object.

Not sure, how that is done in wakaama, tinydtls offers some functions for that.
session.h
Tinydtls also keeps the "session" in the peer, and doesn't use the pointer after returning from functions.
Many examples don't shutdown/free the resources, especially, if the example consider that this is done on exit anyway.

It's just an example so, I will not be totally surprised if this was not done.


OpenBSD make

I wonder if there's something wrong about these patches or time and patience alone would cut it?

Merged, thanks 60d54772f19199c8888876df1194b75eb72c6c53


Create a user programmatically documentation - change example to return things.

Background
I spent some time in my project trying to inspect the responses from this method in my integration tests. After longer than I would like to admin while I worked out it wasn't returning anything. Obviously this is my bad but I thought this example might make more sense if it returned something, as that is how it would typically work.
Changes
Just made the method return the user or raise an exception
Thank you
If this is just closed, that makes sense to me too.
Thanks for the hard work on this project.
Mark

Great, thanks 🙏
@all-contributors add @mdonnellyli for docs


(minor) Fix typo: Flazk -> Flask

Nothing fancy. Just fixing a typo.

Thanks for the PR! If you can believe it, this is intentional :)  We have a tendency of replacing "s" with "z" routinely to illustrate the sample is "ziti"-fied.
So, I'm sorry but I'll close this as "as intended" :) Thanks again


feature/test-sign-in

Context
As an Engineer I want a basic test for sign in so that I have confidence that this is working
Changes proposed in this pull request

sign-in view now uses a form
a basic test for the sign-in has been written
a django specific README has been written

Guidance to review

Relevant links
Things to check

[ ] I have added any new ENV vars in all deployed environments
[x] I have tested any code added or changed
[ ] I have run integration tests

There's a build failure for some reason - might be transient. Otherwise, LGTM.

looks like poetry update required 🤞


About Evaluation.metric

What are the indicators or results in metric?
and different models support different metric?
metric中的指标有哪些？
不同模型支持的metric是否不同？

about 1st question i can refer to https://github.com/open-mmlab/mmdetection/issues/2705
but 2nd still

Firstly, VOC dataset often uses mAP as eval metric, which is a detection metric. For the coco dataset, often use bbox as detection eval metric and segm as for instance segmentation metric.
The metric is based on datasets but not models. Also, please note that  mAP metric is roughly similar to the AP50 of 'bbox'.


Literals as variables

In the code that @GeorgeR227 presented today, it looked like there was var"1.4" = 1.4 in the generated output. We should probably just propagate the constant into the generated AST everywhere.

Fair enough. I think it made some loop inside of compile_var easier to write initially. But this can be changed of course.
Part of the reason for why this change has not been high priority is that these literals are always tiny in terms of memory footprint. There is also some small amount of value extracted from having only lvalues in the main body of the function, although this is dubious.
I wonder whether this impacts anyone looking to re-implement compile. I don't imagine that any bugs will be introduced by mixing lvalues and rvalues inside that block.

Luckily the literals we're working with are primitives and so they should be pushed on the stack. This means no extra allocations and minimum access time.
When we do go to implement this, I imagine that we can just strip the var"..." encapsulation and just leave the contents in the gensim block. Calling eval then should just leave them as literals.

Oh yeah we would then do 1.4 = 1.4 in the closure and then the hot loop would use 1.4 instead of var"1.4". My problem was mostly aesthetic, but it makes sense that it shouldn't affect performance the way it is written. Because the compile can constant prop them.
A benefit of writing a compiler that targets Julia is that a lot of the critical stuff in getting performance out of the compiled code is going get done by Julia when we eval our generated code.

I looked into this and I see the problem. The variable names of a decapode are required to be symbols, not Julia Any. So that is an upstream problem of this.

Ok. Is this now a DiagrammaticEquations issue regarding the acset type?

Yeah, is there a way to mass migrate issues?


[feat][WIP]: OpenAI Like and Ollama UI change

From issue: https://github.com/coleam00/bolt.new-any-llm/issues/461
When selecting OpenAI Like I would like to have a a textbox for the url and textbox for model name. Since this will not be retrieved automatically. Then The Ollama provider could extend from that with a populated url but editable, and a model dropdown for the model name as it is now.

awesome.. I was thinking about this.


feat: patch patient temperature observation

This patches patient's temperature entries

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 82.956%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
5831

Relevant Lines:
7029

💛  - Coveralls


[BKR-358] Add acceptance tests for host helpers

BKR-358

This squashed commit adds acceptance tests, along with a configuration file suitable for running these tests in our jenkins instance, for the Beaker host helpers.
These tests are in part characterization tests, as they expose a number of behavior and documentation bugs in the host helpers as they currently exist.
This commit also temporarily disables the "reboot" host acceptance test, which has been intermittently failing, and will be re-enabled via closure of QENG-3063.
/cc @puppetlabs/beaker
/cc https://github.com/puppetlabs/beaker/pull/930 (non-squashed version)

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1764/
Test PASSed.

:white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::rocket::rocket:
:white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::rocket::rocket::rocket::rocket:
:white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::rocket::rocket::rocket::rocket::rocket::white_large_square:
:white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::rocket::rocket::large_orange_diamond::large_orange_diamond::rocket::rocket::white_large_square:
:white_large_square::white_large_square::100::100::rocket::rocket::rocket::large_orange_diamond::large_orange_diamond::rocket::white_large_square::white_large_square:
:white_large_square::100::100::rocket::rocket::rocket::rocket::rocket::rocket::rocket::white_large_square::white_large_square:
:100::100::100::rocket::rocket::100::rocket::rocket::rocket::white_large_square::white_large_square::white_large_square:
:white_large_square::white_large_square::star2::rocket::100::100::rocket::rocket::rocket::white_large_square::white_large_square::white_large_square:
:white_large_square::star2::star2::100::100::rocket::rocket::100::white_large_square::white_large_square::white_large_square::white_large_square:
:white_large_square::star2::100::100::star2::100::100::100::white_large_square::white_large_square::white_large_square::white_large_square:
:star2::star2::star2::star2::white_large_square::white_large_square::100::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square:
:star2::star2::white_large_square::white_large_square::white_large_square::100::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square::white_large_square:


With slidesPerView 'auto', last slide doesn't get the active class

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 4.2.2

Platform/Target and Browser Versions: Windows 10, Chrome 65

Live Link or JSFiddle/Codepen or website with isssue: http://idangero.us/swiper/demos/120-slides-per-view-auto.html

What you did
I have just had a look at the "Auto Slides Per View / Carousel Mode" demo
Expected Behavior
The "swiper-slide-active" is correctly added to each slide as you drag the slider or click on the pagination bullets. The last slide should get the active class too.
Actual Behavior
When the slider reach the last slide, either by dragging or clicking on the pagination bullets, the last slide doesn't get the "swiper-slide-active" class.

This is by design, because active class depends on position

Hi, thanks for your answer. I know that technically it depends on position, but logically shouldn't it get the class?
Please have a look at this fiddle: https://jsfiddle.net/h8yp6ss7/5/
Since the last slide never gets the active class, you can't read the text underneath the black overlay.

Hi, any fix for this bug? I can't resolve it --'

Hi, any fix for this bug? I can't resolve it --'

There is a better way to do it guys!
By setting the snapGrid settings as same as the slidesGrid settings after the swiper initialized.
And then the swiper will work as what you expected.
const swiper = new Swiper(
    '.awesome-swiper',
    {
        init: false,
        direction: 'horizontal',
        speed: 700,
        slidesPerView: 'auto',
        spaceBetween: 80,
    }
);

swiper.init();
swiper.snapGrid[swiper.snapGrid.length - 1] = swiper.slidesGrid[swiper.slidesGrid.length - 1];

There is a better way to do it guys!
By setting the snapGrid settings as same as the slidesGrid settings after the swiper initialized.
And then the swiper will work as what you expected.
const swiper = new Swiper(
    '.awesome-swiper',
    {
        init: false,
        direction: 'horizontal',
        speed: 700,
        slidesPerView: 'auto',
        spaceBetween: 80,
    }
);

swiper.init();
swiper.snapGrid[swiper.snapGrid.length - 1] = swiper.slidesGrid[swiper.slidesGrid.length - 1];

There is a better way to do it guys!
By setting the snapGrid settings as same as the slidesGrid settings after the swiper initialized.
And then the swiper will work as what you expected.
const swiper = new Swiper(
    '.awesome-swiper',
    {
        init: false,
        direction: 'horizontal',
        speed: 700,
        slidesPerView: 'auto',
        spaceBetween: 80,
    }
);

swiper.init();
swiper.snapGrid[swiper.snapGrid.length - 1] = swiper.slidesGrid[swiper.slidesGrid.length - 1];


Update azure-portal-sql-db-create-07.md

Aligning the Resource Group name with the name used in Create app service step 3.
See also: similar PR 90070.

@gt-ctc-msexp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off


update zshrc: open tab in current directory

I added a fix to zshrc to open tab in current directory. The  version vte-2.91.sh is specific to my Ubuntu dist. Should we make it more general?

@MNegassi I don't think it needs to be more general - this seems to be a bug that occurs only on some specific distributions (and even there: only on some machines?). I will merge this now, thanks for your contribution :)


Static Rendering Error: Metro has encountered an error: While trying to resolve module normalize-svg-path from file

I can't get the library to run, unfortunately.
ich getting following error:
Static Rendering Error (Node.js)
Metro has encountered an error: While trying to resolve module normalize-svg-path from file node_modules\react-native-redash\lib\module\Paths.js, the package \node_modules\normalize-svg-path\package.json was successfully found. However, this package itself specifies a main module field that could not be resolved (\node_modules\normalize-svg-path\index.mjs. Indeed, none of these files exist:
I tried this
https://github.com/gorhom/react-native-bottom-sheet/issues/1020
after that im getting this error:
Metro has encountered an error: While trying to resolve module normalize-svg-path from file \node_modules\react-native-redash\lib\module\Paths.js,
Does anyone have a tip for this?
Here is my current package.json
{   "name": "appreact",   "main": "expo-router/entry",   "version": "1.0.0",   "scripts": {     "start": "expo start",     "android": "expo run:android",     "ios": "expo run:ios",     "web": "expo start --web",     "test": "jest --watchAll"   },   "jest": {     "preset": "jest-expo"   },   "dependencies": {     "@expo/vector-icons": "^13.0.0",     "@microsoft/signalr": "^7.0.9",     "@react-native-community/cli": "^11.3.6",     "@react-navigation/native": "^6.1.7",     "@react-navigation/native-stack": "^6.9.13",     "@rneui/base": "^4.0.0-rc.7",     "@rneui/themed": "^4.0.0-rc.8",     "axios": "^1.4.0",     "date-fns": "^2.30.0",     "easy-peasy": "^6.0.2",     "expo": "~49.0.5",     "expo-blur": "^12.4.1",     "expo-font": "~11.4.0",     "expo-linking": "~5.0.2",     "expo-router": "2.0.0",     "expo-splash-screen": "~0.20.4",     "expo-status-bar": "~1.6.0",     "expo-system-ui": "~2.4.0",     "expo-web-browser": "~12.3.2",     "lightweight-charts": "^4.0.1",     "memoizerific": "^1.11.3",     "react": "18.2.0",     "react-dom": "^18.2.0",     "react-native": "0.72.3",     "react-native-chart-kit": "^6.12.0",     "react-native-eject": "^0.2.0",     "react-native-gesture-handler": "~2.12.0",     "react-native-haptic-feedback": "^2.0.3",     "react-native-image-viewing": "^0.2.2",     "react-native-react-bridge": "^0.11.0",     "react-native-reanimated": "~3.3.0",     "react-native-render-html": "^6.3.4",     "react-native-safe-area-context": "^4.6.3",     "react-native-screens": "~3.22.0",     "react-native-super-grid": "^5.0.0",     "react-native-touchable-scale": "^2.2.0",     "react-native-wagmi-charts": "^2.3.0",     "react-native-web": "~0.19.6",     "react-native-webview": "13.2.2"   },   "devDependencies": {     "@babel/core": "^7.20.0",     "@types/react": "~18.2.14",     "babel-plugin-transform-remove-console": "^6.9.4",     "jest": "^29.2.1",     "jest-expo": "~49.0.0",     "react-test-renderer": "18.2.0",     "typescript": "^5.1.3"   },   "overrides": {     "react-refresh": "~0.14.0"   },   "resolutions": {     "react-refresh": "~0.14.0"   },   "private": true }

did you figure it out

Hi @katche70.
I tried using the same package.json file that you have, but was unable to reproduce the error. This is the project that I tried: charttest.tar.gz


Improve codecoverage and fix error in editcommand

Coverage increased (+0.5%) to 90.871% when pulling a535dfc22326f0abb8eb4c32293d3d6cb4dc29e2 on Li-Shicheng:master into 011906e78a6fa1d3395bfa3cee46fd5693e968ea on CS2103JUN2017-T4:master.


Set DID posture to posted when assigned as the public DID

Fixes #1307
Also avoids a potential failure when two agent processes try to perform the public DID upgrade process simultaneously.

Codecov Report

Merging #1314 (7fe475c) into main (0566a07) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   95.44%   95.43%   -0.01%
==========================================
  Files         476      476
  Lines       28925    28948      +23
==========================================
+ Hits        27607    27627      +20
- Misses       1318     1321       +3


fix: support yarn 1.4.2+ workspaces format

Yarn 1.4.2+ allow to use following format:
"workspaces": {
  "packages": ["packages/*"],
}

nohoist in Workspaces | Yarn Blog

Thanks!


More images

Hi, I really love your photoshere viewer and I'm adding it as a link on my app.
Is it possible that you can add all of the photos to the little viewer? Perhaps in a 3 x 3 layout?
I'm simulating touches on the screen to bring up the menu using the magnet button, not using the spacebar by the way.

Thanks for the comment!
I am planning to add a "scroll link" to it, so you can go down and up in the list. I believe showing 3 thumbnail images at a time is good, a 3 x 3 layout puts some unnecessary strain to the person I think.
The component is listening for touch events as well: view-source:https://www.ideaspacevr.org/examples/aframe/aframe-360-degree-photosphere/js/components/isvr_photosphere_menu.js - a-frame is not cardboard compatible yet, it doesn't work on a Nexus 5. How do you simulate touch events?

Sorry I didn't reply, it looks like I still had a github filter active from my last job!
I simulate touch events by using a touchdown or touchstart and touchup or touchend.
a-frame is not cardboard compatible but my browser is!
https://play.google.com/store/apps/details?id=com.vrambling.vrambling

a-frame is Cardboard compatible, I use it with Chrome on my Nexus phone.


Create session manager for collaboration service

Receive params at collaboration/rooms/ (partnerid, questionid, language)
"Setting up your session..." splashscreen -> Frontend
create a session (encode both user's ids), generate session id and store it inside Redis cache
Once session ends, we can send the data from Redis cache into database table

Navigating to collab service.

When both parties are ready, the owner will choose to start.
on start, owner will be in loading view, partner will remain with a loading status.
The owner contacts the problem service for a question.
Once a question is selected, the owner will fire a notify_start event with the problem id.

The issue now is that once the notify event is fired, both client will leave and enter collab service together. So who will be setting up the room and how to notify the partner once the room is ready?
Currently i could think of 3 approaches:

matching service will generate the room id, so both client can contact the collab service at the same time. Collab service can join the client socket to the room id immediately.
owner's matching lobby will contact collab service to create room, collab service returns the room id, owner then notify partner through matching service again to redirect to collab page together.
the owner navigate to collab page first, collab loading page to setup the room. once the room is ready, the owner (in collab page) notifies partner through matching service again, and will need to disconnect the matching service after that.

@weidak @tryyang2001 what you guys think?

matching service will generate the room id, so both client can contact the collab service at the same time. Collab service can join the client socket to the room id immediately.

I think this approach sounds the best in terms of separating the microservices as well as performing the room creation service inside collab because it is quicker and much less coupled with your matching service as compared to the other 2. There will also be little implementation changes in this case and you can still discard the room id after firing it to notify_start event because the roomId is then cached on our side along with the two user's ids. Once we cache them, we will let the users join the room.
I feel that the collaboration workspace/session will open even if one of them drops/disconnect/doesn't join at all, because they can always just reconnect with the same user id so long as it can be found in the cache. Our UI currently tells the user whether they are connected to the service, and who is our partner (with the DP) but we can also add in features to tell the other party that his partner is disconnected.
Anyways i think having an owner that decides the creation of room has more error handling to be done because if he creates a room and he drops, we will assign the partner the new owner, and this brings in another level of management of inheriting the session rights. Do let me know if im missing out on any concepts though

Agreed, I also feel that this approach is most clear in terms of separating the services, plus since i have some encoding function in matching service alr.
So to confirm, the matching lobby will now redirect both to /collab/room with a unique roomid, partnerid, problemid and language.

Ok can

On second thought, partnerId seems to be redundant since both will enter the room with the unique room id.
this is sufficient?
/collaboration/?q=&l=

No, partnerId is important for collaboration so that the page knows which user avatar it should render for the partner. Therefore we definitely need the partner id. Unless you provide an API which I can query the participants by room id, but I doubt you want to create database for matching service right?

the issue is that if we supply a partner in the param, will collab fetch other users' data if someone modifies it manually? changing the questionId and language is fine as it makes sense to be modifiable.

will collab fetch other users' data if someone modifies it manually? changing the questionId and language is fine as it makes sense to be modifiable.

So you are saying the user might modify the url parameters right? We need a way to prevent this, although I currently have no idea how to do that haha. But I don't think that even make sense for a user to be able to modify the question/language/partner even before the collaboration workspace has been created.

will it be more secure for the partner to broadcast who they are once they join a room?

How do u think the broadcast can be done? Through sending a message in the socket?

@c0j0s you make a valid point with the changing of variables userId actually (and I was gonna comment that I could handle the broadcasting of userId in the socket) but @tryyang2001 also makes another valid point cos if a user can change the other variables it will also inevitably break something (ie they can be coding in different languages/questions)
Will it be most secure if our services communicate through redis then...

Our TA for our tutorial did say that his group focused too much on security and it was just not very significant in the whole package so they ditched it.. (the ones who demoed in lecture) I would say let's not worry too much and decide on a relatively nonsecure way so this does not impede our development

how abt this, ill pass this over
/collaboration/room/<roomId>?p=<partnerId>&q=<questionId>&l=<language>
but the roomId is a checksum of ownerId, partnerId, questionId and language,
then collab page just needs to compute the checksum to see if they match before creating the room.
since the roomId will get discarded after the collab session, issues with id collision are not significant.
what you guys think?

Ok that sounds like a good idea! Lmk the checksum u used

So instead of passing to a non-existing /collaboration page, you will directly pass to the dynamic /collaboration/room/:roomId page with the proper params right? By the way I know that you are just illustrating the idea, but I will encourage we used full name for query parameters for clarity, like questioId=<questionId>, language=<language>, what do you think? Meanwhile to prevent the path is too obvious for the user to change, we can hash the params.

Hmm, like sometimes we see the path name is like /collaboration/room/aHjnfdapkNKpskan4jLNF (ok this is just an example of a random string). I am not sure if we can hash the details of roomId, partner, question, and language?

I dont think we can hash the params, as hashing is unidirectional, we won't have a way to dehash it. unless u meant encryption... which is another level of complication 😅.

I think there is a library called bcrypt that can help us restore the hash easily, as long as we agree to a salt? Not sure if I remembered this correctly, might want to ask @xingjie99 or @tlyi as they are more familiar with that package haha.

So if that is doable, I am more prone to we compute a checksum + hashing, what do you think?

...i don't think its a common practice to hash parameters

Closed this issue as the related PR  has been merged to master.


Refactor: AudioData Memory Management for Improved RAII Compliance

Describe the issue (if no issue has been made)
In the existing codebase, the memory allocations for AudioData are externally handled. This setup poses the risk of memory leaks, especially when dealing with the external allocation and subsequent release of memory for AudioData::Data within the Sound destructor. To enhance RAII compliance and mitigate potential memory issues, this pull request proposes a transition to utilizing std::vector for managing AudioData memory. This adjustment ensures that memory deallocation responsibilities are intrinsic to the AudioData class itself, thereby addressing the current shortcomings and promoting a more robust and leak-resistant code structure.
Testing
Limited coverage for this PR. Minimal expected impact, seeking guidance from @jmorton06 on implementing appropriate tests.

Looks good. Don't think it requires any testing


Some ReCAP locations are not showing up with the remote_storage flag

I have noted that recap$pf and recap$pj do not have the remote storage flag.  Can this data be refreshed from Alma once alma has been updated.  I believe @pdiskin and @pmgreen  are working on the updates to Alma

@carolyncole we are working on this now.

ok so I should wait and not update them in bibdata until you tell me.

@christinach PF and PJ have been added as Remote Storage Locations.

Thank you!

closed by #1386


no build instructions in readme

Can you add basic build and execute instructions for those that don't know go?
I try to do this for my nodejs-based libraries.

Is this update acceptable?

Yes it's great, thanks. I'll test it tomorrow.
On Thu, Mar 14, 2024, 10:08 p.m. Scot Bontrager @.***>
wrote:

Is this update acceptable?
—
Reply to this email directly, view it on GitHub
https://github.com/cloudkucooland/go-kasa/issues/6#issuecomment-1998901766,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABFWQCLQ2ZMF4HICLCRYETYYJX2PAVCNFSM6AAAAABEXBXR7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYHEYDCNZWGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Upgrade jQuery

A security scanner tool reports jQuery vulnerabilities in Robot Framework 3.2.2, CVE-2020-11022 and CVE-2020-11023. These are patched in jQuery 3.5.0. Could the jQuery version be upgraded?

We are currently using jQuery 3.4.1 and upgrading to 3.5 ought to be safe. I'll test that locally and if there are no problems the new version will be included in RF 4.0 beta 2.

We are currently using jQuery 3.4.1 and upgrading to 3.5 ought to be safe. I'll test that locally and if there are no problems the new version will be included in RF 4.0 beta 2.


Raw results issues

Hi, thanks for your work.
Since your raw results on datasets are on your homepage, I download them for research.
But I found some issues in your raw results, which NL initializes.
The raw result of the first frame of each sequence is the same as that of the first frame of groundtruth. That differs from how to get the result of the first frame you mentioned in your paper, which is obtained by grounding.
I hope to receive some answers about this. Thank you! @lizhou-cs

Hello, thank you for your attention to our work. First of all, it should be noted that for the target state of the first frame, we predicted it rather than using ground truth. You can refer to this section of the code for details. Code Link
            self.template_dict = [template_src, template_mask]
            with torch.no_grad():
                out_dict = self.network.forward_test(self.text_dict, self.template_dict, grounding_patch, None)
                scale_box = self._get_templates_and_anno(image, out_dict['pred_boxes'], image_top_coords,
                                                         self.params.grounding_size)
                # return shape: (b,4)
                scale_box = scale_box.squeeze()
            self.template_roi_feature = out_dict['roi_feature'].flatten(2)  # (B, C, H', W') -> (B, C, H'W')
            z_patch_arr, _, z_amask_arr = sample_target(image, scale_box, self.params.template_factor,
                                                        output_sz=self.params.template_size)
            self.template_img, _, _ = sample_target(image, scale_box, 1.0,
                                                    output_sz=144)
            template = self.preprocessor.process(z_patch_arr).cuda()
            self.state = scale_box.tolist()

As for the Raw Result being the same as GT, it is because according to the original code paradigm, the results are saved starting from the second frame, and we have not modified this part. Thank you for pointing it out, and we will make changes to this part of the code in the future.


SIGSEGV: register_results_notification_cb(realm_results*, _jobject*)

How frequently does the bug occur?
Sometimes
Description
We are seeing following crashes reported on our Android App (distributed via playstore)
[split_config.arm64_v8a.apk!librealmc.so] register_results_notification_cb(realm_results*, _jobject*)
Only Samsung devices are inflicted like:

samsung m32
samsung b5q
samsung beyond2
samsung a32x

Stacktrace & log output
[split_config.arm64_v8a.apk!librealmc.so] register_results_notification_cb(realm_results*, _jobject*)

*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
pid: 0, tid: 10238 >>> com.subconscious.thrive <<<

backtrace:
  #00  pc 0x0000000000460ba0  /apex/com.android.art/lib64/libart.so (art::FindMethodJNI(art::ScopedObjectAccess const&, _jclass*, char const*, char const*, bool)+80)
  #01  pc 0x000000000046cf78  /apex/com.android.art/lib64/libart.so (art::JNI<false>::GetMethodID(_JNIEnv*, _jclass*, char const*, char const*)+616)
  #02  pc 0x00000000002fc338  /data/app/~~RmIHjfJYizSUN8-Lh1EESw==/com.subconscious.thrive-NBb_Gunk0DIJ7S4GEKb0bg==/split_config.arm64_v8a.apk!librealmc.so (register_results_notification_cb(realm_results*, _jobject*)+380) (BuildId: 533e53c62871f9d2818ed137fd0c02c6241c7609)
  #03  pc 0x00000000002f9b34  /data/app/~~RmIHjfJYizSUN8-Lh1EESw==/com.subconscious.thrive-NBb_Gunk0DIJ7S4GEKb0bg==/split_config.arm64_v8a.apk!librealmc.so (Java_io_realm_kotlin_internal_interop_realmcJNI_register_1results_1notification_1cb+24) (BuildId: 533e53c62871f9d2818ed137fd0c02c6241c7609)
  #04  pc 0x0000000000394cc4  /data/app/~~RmIHjfJYizSUN8-Lh1EESw==/com.subconscious.thrive-NBb_Gunk0DIJ7S4GEKb0bg==/oat/arm64/base.odex (art_jni_trampoline+116)
  #05  pc 0x00000000010a6004  /data/app/~~RmIHjfJYizSUN8-Lh1EESw==/com.subconscious.thrive-NBb_Gunk0DIJ7S4GEKb0bg==/oat/arm64/base.odex (io.realm.kotlin.internal.RealmResultsImpl.q+356)
  #06  pc 0x000000000116c3a0  /data/app/~~RmIHjfJYizSUN8-Lh1EESw==/com.subconscious.thrive-NBb_Gunk0DIJ7S4GEKb0bg==/oat/arm64/base.odex (io.realm.kotlin.internal.SuspendableNotifier$registerObserver$1$1.invokeSuspend+1072)
  #07  pc 0x00000000010072d4  /data/app/~~RmIHjfJYizSUN8-Lh1EESw==/com.subconscious.thrive-NBb_Gunk0DIJ7S4GEKb0bg==/oat/arm64/base.odex (kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith+180)
  #08  pc 0x000000000130b3dc  /data/app/~~RmIHjfJYizSUN8-Lh1EESw==/com.subconscious.thrive-NBb_Gunk0DIJ7S4GEKb0bg==/oat/arm64/base.odex (kotlinx.coroutines.DispatchedTask.run+1052)
  #09  pc 0x000000000037b5ec  /apex/com.android.art/javalib/arm64/boot.oat (java.util.concurrent.ThreadPoolExecutor.runWorker+988)
  #10  pc 0x0000000000374e14  /apex/com.android.art/javalib/arm64/boot.oat (java.util.concurrent.ThreadPoolExecutor$Worker.run+68)
  #11  pc 0x00000000001bf2ec  /apex/com.android.art/javalib/arm64/boot.oat (java.lang.Thread.run+76)
  #12  pc 0x0000000000218964  /apex/com.android.art/lib64/libart.so (art_quick_invoke_stub+548)
  #13  pc 0x00000000002851f0  /apex/com.android.art/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+184)
  #14  pc 0x0000000000628a24  /apex/com.android.art/lib64/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithJValues<art::ArtMethod*>(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, art::ArtMethod*, jvalue const*)+460)
  #15  pc 0x0000000000678488  /apex/com.android.art/lib64/libart.so (art::Thread::CreateCallback(void*)+1184)
  #16  pc 0x00000000000b4b38  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+264)
  #17  pc 0x0000000000052c60  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64)

Can you reproduce the bug?
No
Reproduction Steps
No response
Version
1.10.0
What Atlas App Services are you using?
Local Database only
Are you using encryption?
No
Platform OS and version(s)
Android 13 and 12
Build environment
Android Studio version: Iguana
Gradle version: 8.0.2

Hi @Shabinder. Seems like there is an issue looking up a JNI method from out native code. It looks like you have enabled abi-splitting. I am not fully on top of how this works, but could be that the JVM symbols are not included because they are not referenced from JVM code, so an possible quick fix could be to disable splitting.
Might be that there are other issues in play so maybe try to elaborate on the details about your project:

Size
ABIs
Proguard/R8
Or any other non-default project configurations.

Proguard rules are pretty standard ones.
if they weren't, and would be the cause, then release builds would always consistently crash and not only sometimes.

ABI splitting: we could turn this off, but that would result in a significant spike in the size of the app which is unwarranted.

We specifically provide proguard-consumer files to preserve the classes that we require to keep around. I don't know how the abi-splitting is done and if you can get it to honor these definitions. Are you able to provoke this with local testing of split test apps? And/or do you have any indications of if the apps are somehow sideloaded with nonstandard post processing of the apks?

proguard-consumer files are being honored.

And/or do you have any indications of if the apps are somehow sideloaded with nonstandard post processing of the apks?

I suspect this only as well, since not reproducible and not all are affected, there is no clear indication if above is the case, is there something I can do to have certainity on that ?

To my knowledge the only way is to access the information through the PackageManager APIs. It has varied a bit throughout Android versions. Maybe you can report it as a custom key along with the crashes in Android vitals/crashlytics.

We shall see what we can do, also pointing out these crashes don't get reported in crashlytics and are reported in Play Console Android Vitals, I am suspecting because these are ABRT signals from Native Code.

Revisiting this, it came up that we have seen some similar for callbacks on non-attached threads. I can't really see a way to achieve this, but the JNI references should anyway be resolved and cached on library load time. Could still be that there is an issue with on the splits (or repackaging), but would be interesting to see if the issue persists after #1598 is merged.


Plex doesn't seem to be connecting

Threadfin and Plex were working this morning, came back home, now it was no longer working!!
Rant to the side for a second, thread fun seems to be working and shows up on plex, nothing has changed, it's just seems like the connection has been lost and when I click on a channel to play, nothing shows up in the threadfin log, and I get a connection error on plex. I've checked the ports and everything seems to be fine.
I am running threadfin in a docker container and plex in another container.

This is why you dont use Plex for Live TV. They have killed it. Kernel Media Server update is coming soon!


Update liquidity script for new command formats

The old liquidity command was used for creating, amending and cancelling a liquidity provision. That has changed now as we have a separate command for each action. This ticket is to update the existing scripts to only create a new LP and to add 2 more sets of scripts for performing amending and cancelling.

Since pegged orders are undergoing similar changes, this would be a good issue/PR to also incorporate those changes (as discussed with @peterbarrow)

Since pegged orders are undergoing similar changes, this would be a good issue/PR to also incorporate those changes (as discussed with @peterbarrow)


Fix: AudioFormatType for g711 u-law and 6711 a-law

Per the OpenAI Docs here, and errors returned from the websockets API, g711-ulaw and g711-alaw are not valid Audio format types. The expected value is g711_ulaw and g711_alaw.
Closes #8
cc @khorwood-openai

Hey! Have fixed separately due to other issue. Thank you. :)


Make use of the new features of TypeScript 2.1

Adds a few changes to stryker in order to support extra checks and new features in typescript including:

noUnusedLocals
noImplicitReturns
Async Await functionality

For more information see issue #190

Closed PR as this branch is already merged in #236


Cannot seem to upload asset, error message not helping

When trying to post an asset onto Github I am being met with this response
POST https://uploads.github.com/repos/ianks/octodown/releases/v1.0.4/assets?name=octodown-1.0.4-linux-x86.tar.gz: 404 Not Found (Github::Error::NotFound)

I can confirm that the release tag does indeed exists, and the files that I am giving it exist as well.
Here is the code I am using to upload.
github.repos.releases.assets.upload(
  'ianks',       # Owner
  'octodown',    # Repo
  "v#{version}", # ID
  file,          # Filepath (this is the full filepath from system root)
  name: Pathname.new(file).basename
)

Any idea what is going sour here?

Just a guess, but it looks like your id is wrong. The Github api expects a call to POST https://<upload_url>/repos/:owner/:repo/releases/:id/assets?name=foo.zip where id is the id of the release, not the tag name. Notice that when you get the details of the release back from github, you get data like this:
"upload_url": "https://uploads.github.com/repos/octocat/Hello-World/releases/1/assets{?name}",
"id": 1,
"tag_name": "v1.0.0",

and that the id in the given upload_url is the actual id of the release, not the tag_name.


Access Request] Page 344 Navigate - ExtDocNo and ContactType

Would you please make the global variables ExtDocNo and ContactType protected? That way we can access them in our extension.
    protected var
        ExtDocNo: Code[250];
        ContactType: Enum "Navigate Contact Type";

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


added puṣpacāpa, error in suvadanā

could you checked these two?

Done. The error was just a missing hyphen.


Test push / fetch

No worries, happy to fix any nits
What are you working on next? I was thinking of looking at the IPNS part

I want to get coreapi in go-ipfs(-api) to a workable state first so I won't have to rewrite this as much. The tracking issue is https://github.com/ipfs/go-ipfs/issues/4498, go-ipfs-api pr here: https://github.com/ipfs/go-ipfs-api/pull/76. After that is done the ipns helper and the other git work can take off.


Make use of bsp_peripherals macro in metro_m4

Summary
Make use of bsp_peripherals macro.
See https://github.com/atsamd-rs/atsamd/pull/515.
Checklist

[x] CHANGELOG.md for the BSP or HAL updated
[x] All new or modified code is well documented, especially public items
[x] No new warnings or clippy suggestions have been introduced (see CI or check locally)

Thanks!


Unnecessary rendering on data re-fetching

Describe the bug
I was using why-did-you-render in local and noticed a bunch of unnecessary re-renders happening because of something related to react-query that goes beyond my power as a lib consumer.
To Reproduce

Go to https://next-auth-1b8mmpq6w.vercel.app/
Check console.
Switch tab back and forth to regain window focus.
Check console again to see unnecessary re-renders happening.

Expected behavior
It should not re-render if data is the same.
Additional context

It's a Next.js based demo, here's the codebase.
If you go to https://next-auth-1b8mmpq6w.vercel.app/swr you are going to see the same thing but handled by SWR. There are not re-renders on stale re-fetching that returns the same data.

This seems relatively new. @boschni, @Ephem any ideas here?

I just ran into the same thing on a React Native app that is causing our iOS refresh control to "flicker" when we call refetch. I think the bug may have been introduced in 2.7.x as upgrading from 2.6.0->2.7.0 the issue appears and before 2.7.0 the issue wasn't present.

I’m not able to test this specific issue right now, but when refetching, the isFetching and updatedAt properties change. This will trigger at least two renders. I created a flag in https://github.com/tannerlinsley/react-query/pull/840 which will allow you to prevent these additional renders.

I am facing a similar issue too, I have few components on a page - Select Dropdown being one. If I click that dropdown the query is trying to fetch the data again. I don't know why.
Even on this demo, if you click somewhere post request is firing and re-render happens. Check the GIF below.

Hi @ankursehdev! Yes in both cases the additional renders are because the query is being revalidated on window focus. You can either disable this behaviour with refetchOnWindowFocus or wait for https://github.com/tannerlinsley/react-query/pull/840 to be merged which will allow you to keep the revalidation, but prevent additional renders.


RFC for Strobe Generator

Rendered

@galibert It is conventional to add a "rendered" link in the description of your RFC. You can get it by going to your branch and finding the file on GitHub: https://github.com/galibert/amaranth-rfcs/blob/strobegen/text/0026-strobegen.md

My personal view on this is that I don't think patterns that take less than 5 lines of Amaranth code normally should be added in the standard library. You can just write them out in your code.
In fact I'd like to see these removed from the standard library in the cases where they are added, e.g. the accepted RFC 18: https://amaranth-lang.org/rfcs/0019-remove-scheduler.html

It's five lines of code, and 70 lines of explanation for why it works.  This is the kind of reason why I think best practices have a place in the lib.

Reopened as requested by the author.

We have discussed this RFC on the 2024-01-08 weekly meeting. We did not reach a consensus.

We have discussed this RFC on the 2024-02-19 weekly meeting. The disposition was to close, with one abstention (@Fatsie). The following reasoning was provided:
@whitequark:

my vote on RFC 26 is: close, for the following reasons:

it is not difficult to implement this functionality in-place and in my view this will usually be worth it because it will be integrated with some wider reset or clocking scheme
having three new classes for this purpose does not have a high enough utility for the increase in our API surface
the functionality could be implemented in an external library and later pulled in if we find that it was widely useful

and the following note:

if we add EnableSignal and platform.unsafe_add_multicycle_constraint, we can add something like FixedStrobeGenerator as it will provide a clear safety benefit

In addition we have noted that:

discoverability of Amaranth libraries should be improved (@galibert, @cr1901)
lib.coding would not have made it to the standard library if it was proposed as an RFC and should probably be removed

Thank you for this proposal, @galibert.

BTW, it was @jfng who abstained; I voted for closure.

I misread the message. Thanks, I've updated the resolution.


Test 1

The Copyright Check has failed!
The files listed below do not have a valid copyright statement:

debian/changelog


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: D33NO sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Output different on CPU and GPU

# Classification CPU
time ./mdtwObj -t CLASSIFICATION -i CPU 3 1 \
    -f data/classification/rm_1/X_MAT data/classification/rm_1/Y_MAT data/classification/rm_1/Z_MAT \
    -k 10 -o 1000 152 -m 0 DTW 2>&1 | tee classification_CPU.txt

# Classification GPU
time ./mdtwObj -t CLASSIFICATION -i GPU 3 512 1 \
    -f data/classification/rm_1/X_MAT data/classification/rm_1/Y_MAT data/classification/rm_1/Z_MAT \
    -k 10 -o 1000 152 -m 0 DTW -d 0 2>&1 | tee classification_GPU.txt

These examples from the readme don't have the same results.
Results:
classification_CPU.txt
classification_GPU.txt
For some reason the results for the CPU and GPU versions do not match. I did not look why this is the case. If there is some random component please allow the users to set the initial state of the RNG to get reproducible results.
Part of a review at: https://github.com/openjournals/joss-reviews/issues/1049

As you said, a component of the software(the K-Fold Cross Validation) includes a random component which causes the GPU and CPU versions to get different results on the same initial dataset. I've identified the function who triggers that behavior and i'll fix it by adding a shuffle_flag on the command line( e.g., -k 10 <0,1>) which will allow the user to get reproducible results.

Great. You don't need to close issues manually - you can just include closes #6 in a commit message to master and the issue will be closed with a reference to the commit fixing it - that way it is easier to follow. The same works with pull requests if you prefer that workflow.

@krischer I've just read it. Thank you for the advice ;)

Well I do not (see attached files). You maybe compiled the sources with WS parameter different than 152. Anyway I will add a check on both parameters to make sure they are identical.
repoducibility_CPU.txt
repoducibility_GPU.txt

fixed


Ability to Debug RUST code that uses STDIN inputs on vscode on Windows 10

Presently, there appears to be no way to debug a RUST program in vscode on windows, if the program requires stdin input.
Considering that the second example in the rust book tutorial:
https://doc.rust-lang.org/book/ch02-00-guessing-game-tutorial.html,
is in fact such a program, a newcomer to RUST that is looking for fully functional IDE on windows would not be able to use vscode.
This feature request is to enhance the msvc debugging integration for RUST, so that the example code above can be debugged interactively.

Please file this feature request against the Rust extension. VS Code provides API to run the debuggee in the integrated terminal or a regular external terminal. Both support that the debuggee can read from stdin. I do not know whether the Rust extension already supports this...


dont add document with key have id

meilisearch v1.0
in bellow sample dont work
[
    'id'=>1,
    'cat_id'=>2
]

because have 'cat_id'  It has been commented that the word id is sensitive
If we change cat_id to cat_idd, it will be correct

Hello @vahidalvandi ,
This is true, and it is the expected behavior. There was a revamp of the primary key inference in v1.0, which means that If multiple attributes ending with id are detected, Meilisearch will ask you to specify the primary key instead of choosing the first found one. It was mentioned as a breaking change, and you can find more information about it in the release note here.

how i can solve this ? and do i can set 'id' for primary key ?

Hello @vahidalvandi.  Yes, you need to specify the primary key manually using the primaryKey query parameter. For example, if you want id as the primary key your request request can be like this: -X POST 'http://localhost:7700/indexes/books/documents?primaryKey=id'

I close this issue then. Feel free to ask to re-open if needed 😊


Reading converter executed for 'countBy' method

Situation
While using Reading Converter for converting data, I found some query method which works in 3.2.1 but throws error in 3.2.2.
You can compare 3.2.1 and 3.2.2 in example code.
Error Description
Codes added at R2dbcEntityTemplate.java in 3.2.2 handle 'count query method' differently compared to 3.2.1.
You can see changes below or Comparing changes
// 3.2.1
if(simpleType) {
    rowMapper = dataAccessStrategy.getRowMapper(resultType);
} else {
... // else logic
}

// 3.2.2
if(converter instanceof AbstractRelationalConverter relationalConverter
    && relationalConverter.getConversions().hasCustomReadTarget(Row.class,  entityType)) {

    ConversionService conversionService = relationalConverter.getConversionService();
    rowMapper = (row, rowMetadata) -> (T) conversionService.convert(row, entityType);
} else if(simpleType) {
    rowMapper = dataAccessStrategy.getRowMapper(resultType);
} else {
... // same as 3.2.1
}

We have countByCategory(category: Category): Long for example.
In 3.2.1, R2dbcEntityTemplate checks whether return type is simple type or not at first. So query result doesn't enter ReadingConverter.
In 3.2.2 however, it checks whether custom converter exists or not before checking simple type. In this time, query result enters ReadingConverter. Query result have only one column, and error occurs.
How to test
Use example code.
Suggestion
I think switching first and second statement may solve this problem.
if(simpleType) {
    rowMapper = dataAccessStrategy.getRowMapper(resultType);
} else if(converter instanceof AbstractRelationalConverter relationalConverter
    && relationalConverter.getConversions().hasCustomReadTarget(Row.class, entityType)) {

    ConversionService conversionService = relationalConverter.getConversionService();
    rowMapper = (row, rowMetadata) -> (T) conversionService.convert(row, entityType);
} else {
... // same as 3.2.1
}

ETC
Sorry for my poor English. I hope you understand what I want to say.

This should be fixed via #1723, care to retest against the latest 3.2.x snapshots?

It works at 3.2.3-snapshot. Thank you!


Dark Mode?

Not sure where to post this so I am sorry if this is not the right place but I kind of find the documentation to be borderline unreadable because of the lack of dark mode or something similar.
A minor issue of course since there are browser addons for this sort of thing and it seems to be a theme among reverse proxy/api gateway sites to generally blind their visitors. But I have been looking around for an api gateway solution all day now and if any one of the options would have had a readable colour palette then I would have picked that one.

Hello @Natr1x , thanks for your feedback.

Hi @Natr1x, I'm just letting you know that we are actively working on offering a dark version of the website. As you might guess, this is not a two-hour job but is being worked right now.
Thanks

Hi @Natr1x,
It took some time, but we’ve just launched our new website redesign today, which includes the long-awaited dark mode for the documentation. This feature was inspired by suggestions like yours, so thanks for your contribution! We hope you'll enjoy the new dark mode as well as other visual improvements we made along the way.
Feel free to check it out and let us know what you think!
Best regards,


RUMM-2568: Remove DataReader v1 usages

What does this PR do?
Remove the remaining usages of DataReader used in v1, because we are now using Storage for reading raw data and de-serialization is not needed anyway.
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[x] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1071 (4051a19) into nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature (86e2a3f) will decrease coverage by 0.00%.
The diff coverage is 92.86%.

@@                                              Coverage Diff                                              @@
##           nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature    #1071      +/-   ##
=============================================================================================================
- Coverage                                                                      83.16%   83.15%   -0.00%
=============================================================================================================
  Files                                                                            306      306
  Lines                                                                          10176    10173       -3
  Branches                                                                        1649     1649
=============================================================================================================
- Hits                                                                            8462     8459       -3
+ Misses                                                                          1213     1211       -2
- Partials                                                                         501      503       +2

Impacted Files
Coverage Δ

...istence/file/batch/BatchFilePersistenceStrategy.kt
100.00% <ø> (ø)

...ror/internal/CrashReportFilePersistenceStrategy.kt
100.00% <ø> (ø)

.../log/internal/domain/LogFilePersistenceStrategy.kt
100.00% <ø> (ø)

.../rum/internal/domain/RumFilePersistenceStrategy.kt
100.00% <ø> (ø)

...g/internal/domain/TracesFilePersistenceStrategy.kt
100.00% <ø> (ø)

...atadog/android/v2/core/internal/storage/Storage.kt
0.00% <ø> (ø)

.../internal/log/WebViewLogFilePersistenceStrategy.kt
100.00% <ø> (ø)

.../internal/rum/WebViewRumFilePersistenceStrategy.kt
64.29% <ø> (-1.23%)
:arrow_down:

...id/v2/core/internal/storage/ConsentAwareStorage.kt
97.09% <92.31%> (+0.31%)
:arrow_up:

...in/com/datadog/android/core/internal/SdkFeature.kt
91.23% <100.00%> (ø)

... and 7 more


[Bug]: Is there any serious test on xquic?

What happened?
I found many memory leak bugs, it seems xquic is not tested in extreme scenarios (e.g. high loss rate).
Steps To Reproduce
See my issues.
Relevant log output
No response

Actually we have tested in extreme scenarios (e.g 20 percent loss ratio).
I think the problem you found is that the packet memory is cached in the queue under xqc_connection, which is reused many times but not released until the connection resource is freed. It's a lazy release mechanism considering performance. By the way, we limited the maximum packet queue length per connection.


Should we reduce the number of sites we run on for now?

To balance effectiveness against shipping buggy data (heuristic + bug label search results), ease of running crawler, ability to run crawler daily, size of seed database. We could always increase size of seed db later as we fix bugs (and multi-process/parallelize the crawler). Just want to start easier.

Closed with ab37153


Switch: Implemented forwardRef (BREAKING CHANGE)

Adds ref forwarding to Switch

Added ref example to Docs

Added test for ref

Added Label prop to Switch. The Docs example was demoing how to add a Label for accessibility. Implemented Label prop following CheckBox/RadioButton pattern.

Why?
Without forwardedRefs, refs are set on the component's instance, not the actual input. So in each of those cases, people drill down to get the input.
That is pretty hacky, so let's add a way for them to get it in a cleaner way.
Why is this a breaking change?
https://reactjs.org/docs/forwarding-refs.html#note-for-component-library-maintainers

When you start using forwardRef in a component library, you should treat it as a breaking change and release a new major version of your library. This is because your library likely has an observably different behavior (such as what refs get assigned to, and what types are exported), and this can break apps and other libraries that depend on the old behavior.

Can I get more documentation around this feature?
https://reactjs.org/docs/forwarding-refs.html#forwarding-refs-to-dom-components

Test Plan

Closing this out for now since we don't have a use for it yet in the pinterest codebase.


Some menu items of a tab are missing when right click on tab name

Description
Menu item "Open Folder in Explorer" is missing for sql-scripts, opened by drag & drop of existing file (or menu File -> Open).
Some other menu items are also missing but they are not of a high priority for me.
Please fix  "Open Folder in Explorer" first instead of two other items.

https://github.com/dbeaver/dbeaver/assets/33929221/3d3deb35-3277-4e90-be2b-07db7738a502
DBeaver Version
Community Edition 24.1.0
Operating System
Windows 10
Database and driver
PostgreSQL 16
PostgreSQL JDBC Driver 42.7.2
Steps to reproduce

drag & drop existing sql-file from any folder to main window
right click its tab name

Expected: there is a menu item "Open Folder in Explorer"
Actual: there is no menu item "Open Folder in Explorer"
Additional context
If you open a new script pressing button "SQL" on a main panel - this item exists.

thanks for your report. I reproduced it.


Update all to 18.3

Update all apps to the 18.3 release of Business Central.

Build fails due to missing platform update, but that will resolve itself in 2 days.


[BE]:Add Gateway API plugin

Signed-off-by: PhilippPlotnikov<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


login window won't pop up

I'm using Ubuntu 20.4 and runnig web-greeter as a greeter-session ( so greeter-session = web-greeter on the lightdm.conf)
I downloaded litarvan from source, and put in the themes folder of web-greeter at /usr/share/web-greeter. When I try to log in, i get 2 problems. 1, I've change the Os png to the ubuntu one but it isn't show up, 2, the login popup window won't show up and i'm left with a blurry screen. Help
I ran "web-greeter 2>log.txt" to give you guys more info in case it helps
log.txt
This is how the no pop-up

This is the no-Logo

'web-greeter' is actually a rewrite of 'lightdm-webkit2-greeter' with a completely different engine, which was never truly finished iirc.
To make the theme work, you need to use the stable version which you can find here https://github.com/Antergos/web-greeter/tree/stable


Provide API to set focus on element

Are you requesting a feature or reporting a bug?
Feature: focus
What is the current behavior?
Can't set focus on element.
What is the expected behavior?
await t.focus('.my element');

Hello William Lin. Thank you for your interest in TestCafe. Here is how you can focus an element using ClientFunction.
var focus = ClientFunction(() => {
    document.getElementById('element').focus();
});

await focus();

Earlier we've decided not to create a separate action for focus.
Let's discuss it again @DevExpress/testcafe

@helen-dikareva
Thanks a lot, it works.


misspelled 'adddress' on user manage page

login and go to your user page '/manage'
See one more d than you should

I'll get this one


win10 系统更新后，vcode一打开就崩溃

Do you have a question? Please ask it on Stack Overflow with vscode tag
(Use Help > Report Issues to prefill these)

VSCode Version:
OS Version:

Steps to Reproduce:

win10
打开就崩溃

@senmeng Are you saying that vs code is crashing after the win10 update?


QRCode app constantly flashes focus assist light

It seems there is no way to prevent the focusAsync method from using the focus assist flash (on my Lumi 925), is there?
The phone does not support the continuous focus feature it says. The nokia camera app however seems to be able to continuously focus. Does it use the same "trick" as you  here with refocusing every other second?

My guess: the Nokia Camera app has access to proprietary driver controls that the QRCode app does not have access to. Disabling the flash in MediaCapture might prevent the focus assist flash (haven't tried).


Bug 2074337: Missing docker:// prefix in vm creation from registry

Signed-off-by: Matan Schatzman<EMAIL_ADDRESS>
📝 Description
Missing docker:// prefix in image registry URL was causing VM creation to fail.
🎥 Demo

/retest

/lgtm

/lgtm

/bugzilla refresh


Requested module doesn't provide required data

Issue
Setup:

Deno Version: 1.23.3 (release, x86_64-unknown-linux-gnu)
v8 Version: <IP_ADDRESS>
Typescript Version: 4.7.4
Opine Version: 0.21.2

Details
When importing the module, I'm getting the following error:
error: Uncaught SyntaxError: The requested module './FactorizeEvt.ts' does not provide an export named 'FactorizeEvt'
export { FactorizeEvt } from "./FactorizeEvt.ts";
         ^
    at <anonymous> (https://deno.land/x/evt@v1.8.7/lib/types/helper/index.ts:1:10)

Hi @TigerbyteDev :wave:
The latest version of Opine is 2.2.0, 0.21.2 is quite old and the evt package has long since been taken out of the dependencies. Try importing<EMAIL_ADDRESS>instead.


DataGrid - Make SelectedItems bindable

Is your feature request related to a problem? Please describe.
Enhancement
Describe the solution you'd like
Make SelectedItems bindable. Not a lot to say about it. It should be bindable.
Describe alternatives you've considered
Additional context

dupicate https://github.com/AvaloniaUI/Avalonia/issues/2890


Project license

Add one.

nvm there is one.

or update the existing one. (doesn't have correct dates etc)


Is this still working?

I am having problems with login.
Everytime i try, i get this exception: "Two Factor Code MUST be 6 digits long WebApp."
Can someone help?

Did you received the EA code and typed in?

No, can you help me?

did you try the solution from #401
for me it worked.

Yeah, my method is like this:
protected async Task SetTwoFactorTypeAsync(HttpResponseMessage mainPageResponseMessage)
{
var loginResponseMessage = new HttpResponseMessage();
var contentData = string.Empty;
        if (_authType == AuthenticationType.Email)
        {
            loginResponseMessage = await HttpClient.PostAsync(mainPageResponseMessage.RequestMessage.RequestUri, new FormUrlEncodedContent(
                                                                                new[]
                                                                                {
                                                                                new KeyValuePair<string, string>("codeType", "EMAIL"),
                                                                                new KeyValuePair<string, string>("_eventId", "submit"),
                                                                                }));
        }
        else
        {
            loginResponseMessage = await HttpClient.PostAsync(mainPageResponseMessage.RequestMessage.RequestUri, new FormUrlEncodedContent(
                                                                                new[]
                                                                                {
                                                                                new KeyValuePair<string, string>("_eventId", "submit"),
                                                                                new KeyValuePair<string, string>("codeType", "EMAIL"),
                                                                                // new KeyValuePair<string, string>("codeType", "APP"),
                                                                                }));
        }

        return loginResponseMessage;
    }

but still didnt work properly =/

Ok, its working now.. but i get this error atm
Could not find member 'onlineAccess' on object of type 'Persona'. Path 'userAccountInfo.personas[0].onlineAccess', line 1, position 115
do you know how to fix it?

See https://github.com/trydis/FIFA-Ultimate-Team-Toolkit/issues/394#issuecomment-415378139


Improve the snupkg documentation

This change recommends setting the IncludeSymbols and SymbolPackageFormat properties through your project's properties instead of CLI arguments.
I've also opened https://github.com/dotnet/docs/pull/10410 to document the SymbolPackageFormat property. We should consider referring to that documentation in the future.

OPS Build status updates of commit 12acc11:
:clock10: Preparing: average preparing time is 40 sec(s)

OPS Build status updates of commit 12acc11:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit 12acc11:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Symbol-Packages-snupkg.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit af33497:
:clock10: Preparing: average preparing time is 40 sec(s)

OPS Build status updates of commit af33497:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit af33497:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Symbol-Packages-snupkg.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit a1c3849:
:clock10: Preparing: average preparing time is 40 sec(s)

OPS Build status updates of commit a1c3849:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit a1c3849:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Symbol-Packages-snupkg.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 3c05d9b:
:clock10: Preparing: average preparing time is 40 sec(s)

OPS Build status updates of commit 3c05d9b:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit 3c05d9b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Symbol-Packages-snupkg.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2f0b064:
:clock10: Preparing: average preparing time is 40 sec(s)

OPS Build status updates of commit 2f0b064:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit 2f0b064:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Symbol-Packages-snupkg.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 38a29cf:
:clock10: Preparing: average preparing time is 40 sec(s)

OPS Build status updates of commit 38a29cf:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit 38a29cf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Symbol-Packages-snupkg.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Bug] [tidb cdc]can't delete the record

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
I test tidb cdc function.
After I delete the data from source db, the data can't  sycn from target db.
at the same time ,the deleted data was been duplicated and inserted into the target db .
SeaTunnel Version
2.3.8
tidb vesrion
7.1.0
SeaTunnel Config
env {
                    job.mode = "STREAMING"
                    job.name="SeaTunnel_Job"
                }
                source {
                    TiDB-CDC {
                        base-url="jdbc:mysql://********/**********?"
                        driver="com.mysql.cj.jdbc.Driver"
                        username="*****"
                        password="********"
                        pd-addresses = "********:2379,*********:2379"
                        tikv.grpc.timeout_in_ms = 20000
                        tikv.grpc.scan_timeout_in_ms=20000
                        database-name = "*********"
                        table-name ="**********"
	        	startup.mode="initial"
                    }
                }
                transform {
                }
                sink {
                    Doris {
                            fenodes = "*********"
                            table="*************"
                            database="*****"
                            password="*******"
                            username="**********"
                            data_save_mode="DROP_DATA"
                            schema_save_mode="ERROR_WHEN_SCHEMA_NOT_EXIST"
                            doris.batch.size=100000
                            doris.config {
                                format = "json"
                                read_json_by_line = "true"
                            }
                        }
                }

Running Command
sh ./seatunnel.sh --config ./test.config

Error Exception
no

Zeta or Flink or Spark Version
zeta
Java or Scala Version
1.8
Screenshots
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@RaymondFishWang you can try to set doris sink ： "sink.enable-delete = "true""
reference：https://seatunnel.apache.org/zh-CN/docs/2.3.8/connector-v2/sink/Doris#data_save_modeenum


Merge with origin repo

Merge with origin repo to update my forked repo

@Doddox-UV your URLs are broken. Closing again


Identical heading styling for different headings

Current Behavior
/docs/install/local age has nested headings in the "Mosquitto" section that look like new sections, but are in fact children elements.
Here, Mosquitto is a parent heading of Manual

Expected Behavior
CSS should differentiate between H3/H4/H5
Steps To Reproduce
Navigate to https://flowforge.com/docs/install/local/#mosquitto
Environment

FlowForge version:
Node.js version:
npm version:
Platform/OS:
Browser:

Issue caused by the Tailwind prose only providing default styling for h1 > h4. Will redefine styles for our headings to prevent a requirement to restructure docs.

Verified on prod (though not tied to release)


refactor: remove CJS ssr output format

Description
We're gathering feedback about the future removal of CJS SSR Format here:

https://github.com/vitejs/vite/discussions/13816

This PR implements the removal to show the complexity that we'll be eliminating.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Vue projects are failing because of this conditional in vite-plugin-vue.
Qwik has a conditional on ssr.format here.

/ecosystem-ci run

/ecosystem-ci run

/ecosystem-ci run

Added back the types temporarily so we can test ecosystem CI, see results here (same errors as in main). The change is reverted and only the legacy empty object is kept.

Oops the fix foo comment closed this PR 😅

/ecosystem-ci run

It seems laravel is failing with an error that could be a bug.
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/6195012334/job/16820400780#step:8:390

@dominikg, did you say the laravel fail happens in main too after updating vite-ecosystem-ci? I see it working here though: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/6194105986/job/16816620515

laravel/vite-plugin uses vitest ^0.25.2 (0.25.8) and that might be the problem.

I removed some more unused codes.

I ran ecosystem-ci locally and the fail reproduced. After upgrading Vitest, the tests passed, so I created a PR: https://github.com/laravel/vite-plugin/pull/246
I guess Vitest was relying on CJS ssr output format in old versions.


E2E performance

Thanks for your great repetition. Could you provide some configuration of E2E to get good performance?
Besides, is there much difference between single fc and multi fc?
Thank you again!

I can not run E2E with this code.
In e2e.py:
"
for i, ((_, idxes), inputs, targets) in enumerate(train_loader, start=1):
"
it seems the "train_loader" only have "inputs" and "targets".
I'd appreciate it if you could help me.

Indeed the code for e2e was not adapted since I changed data.py.
I don't store anymore indexes (to log previous predictions) as it was prone to bugs, but simply call the old model in ram.
Look at iCaRL for pointers: https://github.com/arthurdouillard/incremental_learning.pytorch/blob/master/inclearn/models/icarl.py#L135
My local git is more advanced that this repo, but I won't release right now. It needs cleaning, and I am doing some experiments that are not ready to be shared. Sorry.
Anyway I was not able to reach paper performance with E2E. Their data aug scheme + their regularization is quite tricky. Their gradient noise destroys my performances for examples.
I would advise you to look for easier & better paper. See Large Scale Incremental Learning from this year CVPR for example.

Thank you so much.

Thank you for your advice.
In Figure 4 of "Large Scale Incremental Learning",  "Classifier without bias removal" gets [85%, 72%, 59%, 51%, 40%]. However, I can only get [86%, 62%, 47%, 35%, 24%] in my experiments.  Implementation Details are the same as the section 6.2. in the paper, except I implemented it with pytorch.
"Bias Correction Layer" does bring great improvement. However, I still can not get the performance presented in the paper.
I think there may be some important points that I have not noticed.
Could you reproduce the results of the paper? Could you give me some help?
Many thanks!

@rumusan  can you provide an implementation of large scale incremental learning?
Thanks in advanced.


Files have to be uploaded again when an error occurs

When you upload a file, submit the resource and miss a required field, you are required to upload the resource again. It doesn't persist.

Monika will check.

no longer an issue, closing


cucumberOpts incompatible type

Hi there,
I'm using protractor 4.0.13, typescript 2.1.4 and cucumber 1.3.1.
In my config.ts I've got such config in cucumberOpts:
    cucumberOpts: {         require: [             '../steps/**/*Steps.js',             '../support/hooks.js'         ],         format: [             'pretty',             'json:report.json'         ]     },
Every time when I run tests I got such error:
config/config.ts(3,12): error TS2322: Type '{ seleniumAddress: string; baseUrl: string; capabilities: { browserName: string; chromeOptions: {...' is not assignable to type 'Config'.   Types of property 'cucumberOpts' are incompatible.     Type '{ require: string[]; format: string[]; }' is not assignable to type '{ [key: string]: any; require?: string; tags?: string; format?: string; coffee?: any; noSnippets?...'.       Types of property 'require' are incompatible.         Type 'string[]' is not assignable to type 'string'.
The clue is in config.ts file. In lib/config.ts:563 and lib/config.ts:572 you've got
    require?: string;
Could you please change them into:
    require?: Array<string>;
Regards,
Kacper

@kacpe-r,
See https://github.com/angular/protractor/pull/3817. I think it will solve your problem

@wswebcreation  So for it fixes only 'require'. I've been writing about 'require' and 'format'.

Ok, clear, missed that, sorry

Should we have cucumberOpts in the config at all? Can we allow arbitrary other properties on the config instead?

I don't think this hurts as long as it is kept up to date. We also recently merged a docs for cucumber: #3674. Probably we should make the config more flexible with something like:
export interface Config {
  [key: string]: any;

Also, at least this issue has been fixed with: https://github.com/angular/protractor/blob/master/lib/config.ts#L558
Leaving it open to discuss the above comment.

Per discussion offline with Julie:

should leave the documentation for Cucumber
should remove the cucumber options in the Config and add the [key:string]: any;


Copy-DbaDatabase, pssa fixes (do Copy)

Type of Change

[x] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Removed an unused var and silenced the warning about AzureCredential

thanks so much for all of these enhancements 🏆


Remove hard-coded postgres login role from the queries.

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Cannot login to GUI, but can access files under /keybase/(public, private)

I'm on mac os x (El Capitan!).  I appear to be able to use "keybase" commands and can access files under /keybase/(public, private), however, I can't seem to "login" to keybase.  When I click on the tray icon I see "You're logged out of Keybase!" and a button to "Log In".  When I press that button, I'm prompted for my userid/email address, and then a passphrase.  When I do that, the dialog displays "There was an error provisioning. Unknown error. Error: Device already provisioned for current user".  I'm unable to use any of the tray functionality.
Keybase GUI Version: 1.0.16-20160715110019+f0caa34
Log id:  238ea6c9919820b62611f21c

Turns out that if I just type "keybase login" from a shell, the tray application (GUI) now thinks I'm logged in and I can use the tray functionality. So it just appears that you cannot logout and then re-login via the GUI application (on Mac OS X).


Project name with in a user space needs to be unique

Unique constraint is already applied, validations needs to be updated in the submission pipeline
Move the create new project to the action instead of doing it with in the controller

It is not possible to create two projects with the same name, but the error message might look scary to the user

https://github.com/NFDI4Chem/nmrxiv/issues/227

Currently, using "new project" button doesn't allow duplication of names and shows a clear message

But trying to create a project using "upload" button and giving the same name makes the process gets stuck, and it keeps "processing"


av stack adopt TUI is unusable when there are more branches than will fit on the screen

Just end up with a screen that looks like this with no scrolling

This is still in backlog at the moment, meanwhile we recommend using av stack adopt --parent <parent_branch> to adopt a single branch.


Migration Support

Can you implement the migration integration with camunda engine.

You could try this ad hoc version of mine:
https://github.com/gaensebluemchenritter/Camunda.Api.Client/tree/AddMissingServiceEndpoints
Please be aware that this version makes use of Refit 5.0.23, so if you are using Refit additionally to Camunda.Api.Client you could run into some version conflicts.
If you run into any problems, let me know.

Migrations and CaseInstances are in PR #56 merged from
https://github.com/gaensebluemchenritter/Camunda.Api.Client/tree/AddMissingServiceEndpoints


Extend local validation to detect issues with Build tasks

It would be lovely if:

[ ] tfx would detect missing task.json files for single and multi-version build tasks in the vsix
[ ] tfx would detect missing execution targets in the task.json

These validations seem to be present in the server/marketplace but cause task validation to fail on the server, instead of locally.

I wonder if it would make sense to add "build task" as a new target. This would allow us to add extra validations and even change the behavior for --rev-version without polluting the tfx core with details about various services.

Not entirely sure I'm following this. Do you mean as a dependency plugin
type solution? Something like that would make sense and could be used to
implement all kinds of additional local validation and piggy-back features.
Given the way the version number in the build tasks are structured that
would also simplify that.
A similar json patcher extension could then be added and plugged into
rev-version. Heck, we could build a yaml and a xml one too if we wanted.
On Tue, 20 Mar 2018, 20:34 Trevor Gau<EMAIL_ADDRESS>wrote:

I wonder if it would make sense to add "build task" as a new target. This
would allow us to add extra validations and even change the behavior for
--rev-version without polluting the tfx core with details about various
services.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/tfs-cli/issues/261#issuecomment-374728573,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD-uS4N7LhQCjL2iogVVm0dMh1N-vkAPks5tgVm8gaJpZM4Sttus
.

Essentially, yes. Originally I wrote TFX to be extensible since VSCode was going to use it to package their extensions (that didn't happen, obviously!) The installation target(s) tell TFX how to package and validate the extension - you can see the existing ones here: https://github.com/Microsoft/tfs-cli/tree/master/app/exec/extension/_lib/targets. "Microsoft.VisualStudio.Services" is the most common, used for packaging regular VSTS extensions. In theory, however, I could extend that for Build Task extensions to add special considerations for tasks.

Sounds like the way to go then.
On Tue, 20 Mar 2018, 23:14 Trevor Gau<EMAIL_ADDRESS>wrote:

Essentially, yes. Originally I wrote TFX to be extensible since VSCode was
going to use it to package their extensions (that didn't happen,
obviously!) The installation target(s) tell TFX how to package and validate
the extension - you can see the existing ones here:
https://github.com/Microsoft/tfs-cli/tree/master/app/exec/extension/_lib/targets.
"Microsoft.VisualStudio.Services" is the most common, used for packaging
regular VSTS extensions. In theory, however, I could extend that for Build
Task extensions to add special considerations for tasks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/tfs-cli/issues/261#issuecomment-374775231,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD-uS-JEjuXdNzML8GIngQsCNs4mZ-OAks5tgX8ogaJpZM4Sttus
.


Circle failure

I've done many circlifications and now 3 have 'gone wrong':

Is a grassed area with a kerb round it. While the grass area joints the points up in order, the kerb line hasn't - creating the effect in the image.
I'm not sure why it's doing this, but circleised grassed areas with a kerb are common but only some go like this.
Interestingly, at the bottom end of the same kerbed grassed area, the right side had the kerb points connected in the wrong order but on the left side it was the grassed area connected in the wrong order!

Can you send me location of where that feature is?

I've fixed it now - so generated another example here:
https://www.openstreetmap.org/edit#map=17/21.01822/-9.18929
In generating the example, I carefully noted the construction and manipulation.

draw 'square' area with six nodes clockwise - with the 2 extra nodes very top and very bottom.
Draw barrier kerb the very same way, clockwise, starting from the upper left node.
Now to make curvaceous
Imagine the upper three nodes are the top three of a diamond. Draw a line starting from the imaginary 4th node at the bottom - then work clockwise round the existing three nodes to form the diamond. Using this line, click circle function. It, the grass and kerb are made 'circular'.
Deleting the complete circle (I've not done for illustration) would leave a nice curved to pend to the area and barrier.
Repeat at the bottom end - forming the diamond from the imaginary upper point - BUT THIS TIME go anticlockwise joining up the other three points and back to the fourth.

I have done this and left it at this state.
Select that diamond and choose 'circle' button. Fingers crossed, the barrier's new nodes will not be connected in the correct order ! (It didn't with me!)