Add trainer argument for detect_anomaly.

What does this PR do?

Fixes #8313
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

2 questions regarding the difference between terminate_on_nan and detect_anomaly:

Does anomaly detection raise an error on +- inf? terminate_on_nan does:
https://github.com/PyTorchLightning/pytorch-lightning/blob/46b00a7de44d226a3da22b258c74cc2b3cd92bec/pytorch_lightning/loops/utilities.py#L35
Will we keep the loss value check when terminate_on_nan is removed?
https://github.com/PyTorchLightning/pytorch-lightning/blob/46b00a7de44d226a3da22b258c74cc2b3cd92bec/pytorch_lightning/loops/batch/training_batch_loop.py#L279-L281

Anomaly detection doesn't raise an error for infs. Also, since detect_anomaly doesn't check the loss I think the loss check should be kept after terminate_on_nan is removed.

Anomaly detection doesn't raise an error for infs. Also, since detect_anomaly doesn't check the loss I think the loss check should be kept after terminate_on_nan is removed.

In that case, I don't think we should deprecate terminate_on_nan but instead add the anomaly detection functionality to the existing flag.

Anomaly detection doesn't raise an error for infs. Also, since detect_anomaly doesn't check the loss I think the loss check should be kept after terminate_on_nan is removed.

From the documentation:

This does two things:
Running the forward pass with detection enabled will allow the backward pass to print the traceback of the forward operation > that created the failing backward function.
Any backward computation that generate “nan” value will raise an error.

It does not say anything about +- inf values, which led me to assume that it won't raise an error in that case. However, upon trying it out, I verified that it raises an error for both infs and nans. It also returns errors for nan or inf loss values, so we won't need to keep the  loss value check either.
Sorry for the earlier miscommunication.

In addition, we should probably increase visibility and update the docs source file debugging.rst with a section for anomaly detection. @yopknopixx would you be willing to make this update in a follow up PR?

In addition, we should probably increase visibility and update the docs source file debugging.rst with a section for anomaly detection. @yopknopixx would you be willing to make this update in a follow up PR?

Yes, for sure. Please let me know the relevant details for the same.

@Borda I can see that there is 1 change requested by you (that is blocking the merge) even though I have made all the requested changes. Can you please review it?

Per https://github.com/PyTorchLightning/pytorch-lightning/issues/9799 we only want to turn on detect_anomaly after the scaler value converges to a stable value:

At the beginning of training, in the first few iterations it can happen that the grads become inf or nan. AMP will skip the optimizer.step() in that case and adjust the scale factor iteratively until it converges to a point where that doesn't happen.

@yopknopixx After #9848 got merged, I am repurposing your PR here for the deprecation of the old terminate_on_nan argument so we can include your contribution. Thanks for your patience!


ClientError: An error occurred (ResourceInUse) when calling the DeleteTags operation: Tags are currently being modified for this account. Please try again later.

Try a couple of things:

Building a retrying mechanism on the caller side with backoff on errors
Splitting the API call to multiple calls each containing only one group

fixed in #316


Update vendored dependencies to work towards kubernetes 1.6 compatibility

Currently trying to run this with a kops 1.6.0-beta.1 deployed kubernetes 1.6.0 cluster and getting quite a bit of odd behavior.  This is my work towards fixing that
Some of the things seen

Ingresses being updated but the ALB ingress controller not having it's OnUpdate event fire.
Weirdness in syncing the rules (Some rules appear, some don't. Some point to the wrong service. All targets exist)

Hope is to update the vendored library to hopefully fix the update issues (The kubernetes/ingress repo changed the kubernetes go client version), and then work on the issues around syncing rules.

@joshrosso this should be ready to go / shouldn't break existing things while slightly improving kubernetes 1.6 readiness

Thanks @cmaloney, will review this week.

@cmaloney haven't had a ton of time to dig in, but I seem to be unable to build even after killing of my glide cache and vendor folder.
$ make clean && make && make push
rm -f server
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GOARM=6 go build -a -installsuffix cgo -ldflags '-w' -o server ./main.go
# github.com/coreos/alb-ingress-controller/vendor/k8s.io/ingress/core/pkg/ingress/annotations/authreq
vendor/k8s.io/ingress/core/pkg/ingress/annotations/authreq/main.go:134: ur.Hostname undefined (type *url.URL has no field or method Hostname)
make: *** [Makefile:28: server] Error 2

I did do a rebase, so perhaps I borked something. Going to dig in further when I have a moment, let me know if the build works ok for you.

Ah, it's coming from the net pkg, might just be go version differences.

Yup, https://golang.org/doc/go1.8#net_url.
Need to refine the build process soon. Anyways, testing now.

@cmaloney, passes in my 1.6.1 cluster. Thanks for the contribution!


Upgrade AWS SDK (v1) dep to latest (v1.47.3)

Need to upgrade to test SNS:PublishBatch as not available at time of v1.34.0 release
ref https://github.com/Admiral-Piett/goaws/issues/270
so may as well upgrade to latest (v1)

First made available in v1.42.7


when autoplay is true，the video will be lagging

the debug console like these:

the event progress trigger unusual.How can I deal with it?

Progress is the video loading. This is not a bug. Cheers 👍


Not able to make the html - Theme error

Hi,
I have included the path to the theme and the theme in my conf.py, just the way it is supposed to be included. Still I keep getting this error:
writing output... [  1%] auto_examples/index
Theme error:
An error happened in rendering the page auto_examples/index.
Reason: TemplateNotFound('navbar-logo.html')
What could the issue be?

could you provide more information on your issue ? like the version of the lib or a link to repository you are working on (if public). It sounds like an installation issue.

I'll close this one as I don't believe we have enough information to recommend a next action.


⚖ Register Validator:

Network Choice
nemeton-1
Who are you?
noderunner OFC
https://github.com/gbuchukuri
gentx
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"geonodes","identity":"","website":"https://github.com/gbuchukuri","security_contact":"info@geonodes.ge","details":"in Cosmos we trust"},"commission":{"rate":"0.050000000000000000","max_rate":"0.100000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"okp41e5da9hxyv5zkdrl2s34p0yl95s6d08zc58pyj5","validator_address":"okp4valoper1e5da9hxyv5zkdrl2s34p0yl95s6d08zcpq3dv4","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"ysufT4LHveylGualIM2K28Q8JDqp42S3yaAwJP86Eas="},"value":{"denom":"uknow","amount":"10000000000"}}],"memo":"363876a472599e169a0099c091c1f948278f85e1@<IP_ADDRESS>:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"Ar94Q+hKOHCoxD/EfIZYMGtTF8lKEFUGCQ9p+CQFVNs4"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["+Gyqs+6VXHqFoodyuWgJOJ2kTdnXGfT0yRhxYfHmBxEKIC7VkIJqG2zReFTtn/hp0EpSJaujGVrg4rzGCECSxg=="]}

😢 I couldn't process your request: Register process is closed for this network.


TYPE_LINEAR_ACCELERATION Exclude gravity from acceleration

What is the purpose of this sensor?
Because some times you want to exclude gravity from calculations, it would be nice to have it there.
Is it supported on both iOS and Android?
Yes
Is there a way to test this sensor without a real device?
Yes
Would you be willing to respond to issues / PRs for this sensor?
Yes

What this package represents right now is ( Gravity  + device acceleration ) = acceleration
this week I will pull a request to add two more types
acceleration , gravity excluded = linearAcceleration
and "gravity" stand alone
1-acceleration
2-linearAcceleration
3-gravity
for android is ready and I'm working for ios to make it work so the package will be promising for both!
stay tuned ;)

Sounds great, this is the most requested feature! Thanks a ton!

@DanielMSchmidt still working on it
some phones does not support linearAcceleration natively but gravity is supported on all of them
so I will only add gravity to package so users can easily get
linearAcceleration = acceleration - gravity

gravity property added for both ios and android to the package and I'm waiting for you @DanielMSchmidt  to merge my pull request
you can even update the API doc
and add the gravity to it
It's just like accelerometer outputs

This seems to be solved now :)

Hey, I have a maybe more general question, but how do you subtract the gravity from the acceleration synchronous?
Im pulling both once per second but it seems that gravity starts a bit later than Accelerator so when I calculate the linear Acceleration it's slightly off

Hey, nice question unfortunately site document is not updated yet and I will make an update for it,
but document inside the source code in updated by me:
here's the new gravity API added to it:
https://github.com/react-native-sensors/react-native-sensors/blob/master/docs/API.md#gravity-observablex-number-y-number-z-number-timestamp-string
and here I have explained exactly how it can be excluded by RxJS synchronous
https://github.com/react-native-sensors/react-native-sensors/blob/master/docs/Usage.md#raw-device-acceleration
if there is more question about it let me know ;)

Hey, I have a maybe more general question, but how do you subtract the gravity from the acceleration synchronous?
Im pulling both once per second but it seems that gravity starts a bit later than Accelerator so when I calculate the linear Acceleration it's slightly off

Hey, nice question unfortunately site document is not updated yet and I will make an update for it,
but document inside the source code in updated by me:
here's the new gravity API added to it:
https://github.com/react-native-sensors/react-native-sensors/blob/master/docs/API.md#gravity-observablex-number-y-number-z-number-timestamp-string
and here I have explained exactly how it can be excluded by RxJS synchronous
https://github.com/react-native-sensors/react-native-sensors/blob/master/docs/Usage.md#raw-device-acceleration
if there is more question about it let me know ;)

Hey, I have a maybe more general question, but how do you subtract the gravity from the acceleration synchronous?
Im pulling both once per second but it seems that gravity starts a bit later than Accelerator so when I calculate the linear Acceleration it's slightly off

Hey, nice question unfortunately the site document is not update based document attached to source code so I will refer you to it
Here's the new API gravity:
API-DOC
And here I have explained exactly how you can exclude it by RxJS
USAGE-DOC
if there is anything else you need, let me know ;)

And here I have explained exactly how you can exclude it by RxJS
USAGE-DOC

Nice solution but sadly when one Sensor updates before the other it will generate a new Output, I get two values in the same interval, the solution can be to just take one of the two calculated values per interval, but I guess there is no way to really clock both sensors to the same millisecond?

And here I have explained exactly how you can exclude it by RxJS
USAGE-DOC

Nice solution but sadly when one Sensor updates before the other it will generate a new Output, I get two values in the same interval, the solution can be to just take one of the two calculated values per interval, but I guess there is no way to really clock both sensors to the same millisecond?

I know what you mean,
to clarify there are three APIs for dealing with acceleration
1-Total Acceleration which is (device acceleration + gravity acceleration )
2-Gravity acceleration standalone
3-linear acceleration which is (Total acceleration - Gravity acceleration)
based on an issue which linear acceleration API is not supported by a few old android devices I decided not to include it into package and instead found a way by RxJS to combine streams for sure you will lose a few milliseconds and it's not a definite solution to problem but based on my  project was practical enough to cover my needs
if you don't mind device support range , let me know to make an update in a few days and add this API as well!

I'm building an app for collecting sensor data from my phone to run them against an AI.
I don't know if I really need the acceleration in the first place but I want to collect one data point per interval, so its hard to decide which of the two from combine_latest is more relevant.
But overall I guess a lot of people don't mind the few old android devices :)
It also seems that this package is the most complete and user-friendliest sensor API so I guess it wouldn't be bad to add this feature!
I would do it myself but I'm sadly not into contributing to open source software, so thanks for taking your time to help me out with this one ❤

I'm building an app for collecting sensor data from my phone to run them against an AI. I don't know if I really need the acceleration in the first place but I want to collect one data point per interval, so its hard to decide which of the two from combine_latest is more relevant.
But overall I guess a lot of people don't mind the few old android devices :)
It also seems that this package is the most complete and user-friendliest sensor API so I guess it wouldn't be bad to add this feature!
I would do it myself but I'm sadly not into contributing to open source software, so thanks for taking your time to help me out with this one ❤

it seems interesting,
I will add this feature in a few days and will let you know here
stay tuned ;)

@DanielMSchmidt @Ehsan0Hejazi
Thanks for all the work that you have done on this library.
It would be great if you could add linearAcceleration as well.
Right now I'm subtracting gravity values from the raw accelerometer, however, there is a time difference between data returned by both of the sensors, sometimes upto 1 second which is affecting calculations in the app I'm working on.

calculations

Your welcome,
does this calculations make a meaningful effect on your application logic?!
as I have mentioned before linearAcceleration might not be accessible on some devices but for sure we can add it to the package,  so you need to check to make sure It responses to you with correct data otherwise the only alternative would be the same dummy calculations!

Yes. We're working on an app that identifies driving behaviour. We use the accelerometer values as one of the parameters.
Having even a 100ms delay in the accelerometer and gravity values is adding a huge margin of error.
Agreed that linearAcceleration might not be available in older / budget android devices, but it does make sense to add it to the library for majority of the devices that do support this feature.
Hope this is added in a future release.

Yes. We're working on an app that identifies driving behaviour. We use the accelerometer values as one of the parameters. Having even a 100ms delay in the accelerometer and gravity values is adding a huge margin of error.
Agreed that linearAcceleration might not be available in older / budget android devices, but it does make sense to add it to the library for majority of the devices that do support this feature.
Hope this is added in a future release.

Ok , I will make a pr for upcoming week with the requested feature!

Thanks. Would be great if you could do that.
On Sun, Apr 24, 2022 at 1:48 AM Ehsan Hejazi @.***>
wrote:

Yes. We're working on an app that identifies driving behaviour. We use the
accelerometer values as one of the parameters. Having even a 100ms delay in
the accelerometer and gravity values is adding a huge margin of error.
Agreed that linearAcceleration might not be available in older / budget
android devices, but it does make sense to add it to the library for
majority of the devices that do support this feature.
Hope this is added in a future release.
Ok , I will make a pr for upcoming week with the requested feature!
—
Reply to this email directly, view it on GitHub
https://github.com/react-native-sensors/react-native-sensors/issues/391#issuecomment-1107642715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEIUMWHAAY3KMLJEIWAIBJDVGRLJLANCNFSM46ISRBZQ
.
You are receiving this because you commented.Message ID:
@.***
com>


odd interaction table behavior on record pages

the interaction tables on individual drug/record pages has some odd behavior that should be fixed:
[] the table should be converted to a MUI table instead of ant (this might fix the issues below. Try this first!!!!)
[] paging through the table will change the width of some cells, changing the entire width of the table, and therefore, the pagination buttons may shift position. this should not happen - the user should not have to re-position their mouse upon paging through the table
[] the records per page dropdown is nonfunctional

this has been addressed (fixed with the antd -> mui refactor)


No need for wireshark sources to compile

I was inspired by this project and was able to make so that at most you need the header files.
But as long as you have the .dll/.so file you can compile a plugin from the start with rust.
Rust will also produce the full lib to be use by Wireshark, and it can be really easy to set up a dissector.
Example: https://github.com/jose-pr/libwireshark-rs/blob/master/foo_dissector/src/lib.rs

Very cool, I'll check it out.


Add TLS to gRPC

As part of the first milestone to launch a basic go website, we should add TLS.
Some useful links:

https://github.com/philips/grpc-gateway-example -- philips example has TLS:
https://letsencrypt.org/ -- we should probably use Let's Encrypt to create real Certs.

I'd like to rephrase this bug to just be about adding the gRPC plumbing for TLS. https://github.com/philips/grpc-gateway-example/blob/master/cmd/serve.go is a good example of using TLS + gRPC.


Require $packages to compile

While ensure_packages() is called within install.pp, this doesn't seem to
actually guarantee that the dependencies are installed before trying to compile.
This adds the 'require' metaparameter to ensure that the packages are actually
installed before attempting to run make.

:+1: :shaved_ice: :ship:


TCP Client code

TCP Client code that tries to connect to the server, and start sending image if connection is successfully made.
DoD:

[x] Able to connect to server(RPi 2) using its IP address and verify connection;

[x] Send the image file in 320x240 .ppm format over to server every 3 second(actually even better, I can do about every 0.5 sec);

[x] if disconnected, it should try to reconnect to server and report on disconnection;

Able to do 320x240 .ppm format

Verify aesd-client application on RPi aesd-client code with a string send to aesd-serveraesd-server on my ubuntu laptop

Verify aesd-cam-client application on my ubuntu laptop with an captured image send to aesd-server on my ubuntu laptop.
aesd-cam-client code

Verify aesd-cam-client RPi on my ubuntu laptop with an captured image send to aesd-server on my ubuntu laptop.
aesd-cam-client code

Verify aesd-cam-client application on RPi with an captured image send to Sam's server Application on his RPi2
aesd-cam-client code
Sam's server code

Performance tuning for frequency of message sending. Fix various bugs.

Chutao, Dhruva, Sam integration test done


Add Dockerfile

closes #234

Add Dockerfile
Add docker-compose.yml
Add shell script to read plugin's Gemfile

because COPYing Gemfile before installing gems are efficient when building Docker image

Update README

Thank you for your commit. Looks good.


myrica: init at 2.011.20160403

Motivation for this change
Myrica is high-quality Japanese font for programming.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


Support authorization

Support to add role-based, policy-based authorization.

Hello,
What exactly do you mean by "support for authorization"?
Because EasyQuery already includes basic auth support via standard RequireAuthorization extension function:
endpoints.MapEasyData(...).RequireAuthorization("AuthPolicyName");


Errors since latest patch on chamans

Hello
Since latest patch (11.0.2 56110), addons throws error with chamans. Most likely due to their hearstone spell.
I don’t have this error on other class.
Message: Interface/AddOns/HearthRoulette/Addon.lua:75: attempt to call global 'GetSpellInfo' (a nil value)
Time: Thu Aug 15 11:58:11 2024
Count: 1
Stack: Interface/AddOns/HearthRoulette/Addon.lua:75: attempt to call global 'GetSpellInfo' (a nil value)
[string "@Interface/AddOns/HearthRoulette/Addon.lua"]:75: in function `ChooseHearth'
[string "@Interface/AddOns/HearthRoulette/Addon.lua"]:112: in function `UpdateAll'
[string "@Interface/AddOns/HearthRoulette/Events.lua"]:48: in function `?'
[string "@Interface/AddOns/HearthRoulette/Events.lua"]:8: in function <Interface/AddOns/HearthRoulette/Events.lua:6>

Locals: self = <table> {
 COVENANT_HEARTHSTONE_TOY_ID = <table> {
 }
 eligibleToys = <table> {
 }
 eligibleItems = <table> {
 }
 eligibleSpells = <table> {
 }
 MACRO_ICON_PATH = "Interface/icons/achievement_guildperk_hastyhearth.blp"
 events = HearthRouletteEvents {
 }
 HEARTHSTONE_SPELL_ID = <table> {
 }
 HEARTHSTONE_TOY_ID = <table> {
 }
 MACRO_ICON_ID = 413582
 HEARTHSTONE_ITEM_ID = <table> {
 }
}
name = nil
cooldown = nil
spellId = 556
(*temporary) = 1
(*temporary) = nil
(*temporary) = 556
(*temporary) = "attempt to call global 'GetSpellInfo' (a nil value)"

Looks like it was renamed https://warcraft.wiki.gg/wiki/API_C_Spell.GetSpellInfo

This should be resolved in release v19.

Thanks


Request for Paper Implementation

Title
Request for Implementation of Mnemosyne: Learning to Train Transformers with Transformers in PyTorch
Description
I would like to request the implementation of the "Mnemosyne: Learning to Train Transformers with Transformers" paper in PyTorch. This paper proposes a new method for training Transformers using Transformers, which has shown promising results in several benchmark datasets. The authors of the paper and the link to the paper are listed as below:

Paper name: Mnemosyne: Learning to Train Transformers with Transformers.
Author: Deepali Jain, Krzysztof Marcin Choromanski, 2 Sumeet Singh, Vikas Sindhwani,
Tingnan Zhang, Jie Tan, Avinava Dubey.
Paper link: https://arxiv.org/abs/2302.01128.

I believe that having the implementation of this paper in PyTorch would be highly beneficial for the community, as it would allow researchers and practitioners to experiment with this new method and potentially improve the performance of their Transformer models. Additionally, this implementation would demonstrate PyTorch's commitment to staying up-to-date with the latest research in the field.
I have attached a copy of the paper and some additional resources that could be helpful for the implementation. Thank you for your consideration, and I look forward to hearing your response.
Best regards,
Nguyen Truong Nhan

Examine Pleasure


JSS as css-loader replacement

Rolled a JSS-loader + plugin for webpack to treat JSS includes as an object literal mapping of declaration to generated classname, with a counterpart plugin to extract the generated stylesheet as a separate css bundle.
Have to clean up documentation, but can integrate into this project after.. if this matches your vision of "killing css".
Let me know!

@dmitrif Thanks to your post, I've just looked into JSS. It looks very promising, but the proof will be using it in a project. Can you make your repo available for testing?
I didn't see any mention of JSS at https://github.com/dmitrif/react-redux-universal-hot-example

@gihrig Just finished rolling the libs and integrating them into an internal project here, will integrate with my branch of react-redux-universal-hot-example and add a comment here when done.
Thank you!


Parse real genre to show in list

Parse real genre to show in list, it is now set to unknown by default

https://github.com/markzhai/LyricHere/commit/14cdd573fbe01390e69d25fda3e56ab5f3abeee6
done


Prettier organizes imports

This is a plugin that makes prettier reformat the import sections of
source code files. Its goal is:

Make sure that your import statements stay consistent no matter who
writes them and what their preferences are.

Its readme says it uses the organizeImports feature of the typescript
language api, which is the same thing as the "Organize Imports" code
action in VS Code.
In a way, it extends prettier's philosophy of "let's agree on a coding
style that is enforced by tooling" to imports.
NOTE:

if you run prettier when a file is saved, some unfinished imports will
be destructively removed using this plugin - use the "undo" feature of
your IDE to get them back in this case.
if you also have an "automatically add imports" feature working, you
can pretty much not worry about imports at all 99% of the time. In my
experience this sort of developer experience is excellent.
adding this plugin will affect each phase where prettier itself is
used - namely:

during development, meaning in the IDE or on the command line
as a git pre-commit hook via lint-staged
every time prettier is used in CI

https://www.npmjs.com/package/prettier-plugin-organize-imports

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-12 of 139 (91.37%)  changed or added relevant lines in 33 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 92.194%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/lib/combinators.ts
21
22
95.45%

src/lib/internal/index.ts
25
28
89.29%

src/lib/index.ts
24
28
85.71%

src/lib/internal/parsers/index.ts
12
16
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1139

Relevant Lines:
1216

💛  - Coveralls

Just resolved the conflicts by:

dropped the formatting commit temporarily
rebased to the latest master
reran prettier with yarn prettier:fix, which reformatted everything agin.

I will merge this in after the build passes.


"defaultSource" on Android is not supported on release.

React Native version: 0.61.4

Steps To Reproduce

"defaultSource" on Android is not supported on release.

Describe what you expected to happen:
Snack, code example, screenshot, or link to a repository:
"defaultSource" on Android is not supported on release.

defaultSource works only on release build, because it requires a resource to be on a device. So during development it's no shown, because resources are requested from metro or bundler over the network.


Key differences

Dear Franco,
Could you be so kind to lay out key differences between your version and the original
either on the front page or in the wiki section, so users could easily grasp your mission?

I made a distinct file
https://github.com/fcorbelli/zpaqfranz/blob/main/differences715.txt
that I will update


filecontent filter + rename action = multiple renames

I have the following rule running on a current version of organize (installed via pip):
  # try to extract the first date from the file and rename it accordingly
  - name: date_rename
    locations: /scan/ocr
    filters:
      - name
      - extension: pdf
      - filecontent: '(?P<m>[0123]\d)\.(?P<d>[01]\d)\.(?P<y>[12][09]\d\d)'
    actions:
      - rename: "{filecontent.y}-{filecontent.m}-{filecontent.d}_{name}.pdf"

Unfortunately after "rename", the filter triggers on the renamed file again and starts the action over and over... it seems to run 5 times and then proceeds with the next rule:
scan/ocr
  20220401_173738.pdf
    - (rename) Rename to /scan/ocr/2022-23-03_20220401_173738.pdf
  2022-23-03_20220401_173738.pdf
    - (rename) Rename to /scan/ocr/2022-23-03_2022-23-03_20220401_173738.pdf
  2022-23-03_2022-23-03_20220401_173738.pdf
    - (rename) Rename to /scan/ocr/2022-23-03_2022-23-03_2022-23-03_20220401_173738.pdf
  2022-23-03_2022-23-03_2022-23-03_20220401_173738.pdf
    - (rename) Rename to /scan/ocr/2022-23-03_2022-23-03_2022-23-03_2022-23-03_20220401_173738.pdf
  2022-23-03_2022-23-03_2022-23-03_2022-23-03_20220401_173738.pdf
    - (rename) Rename to /scan/ocr/2022-23-03_2022-23-03_2022-23-03_2022-23-03_2022-23-03_20220401_173738.pdf

Is there a way to stop the rule from targeting the renamed file again?

This is a bug and shouldn't happen.

I'm experiencing the same issue with the following:
rules:
  - name: "Renaming DVD folders"
    locations:
      - path: "/mnt/backups/DVDs"
        max_depth: null
    targets: dirs
    subfolders: true
    filters:
      - name:
          contains: "DVD"
    actions:
      - echo: "{path}"
      - rename:
          name: "{name.replace('[DVD] ','')}-{name.replace(' ', '_')}-{name.replace(' [1080p]','')}"
          on_conflict: "overwrite"

@drgrandios Your issue seems like a bug where files are handled multiple times where they shouldn't. It's on my todo.
@telometto I replicated your issue and found this is more like a documentation issue 😅
What you're trying to do is this:
    actions:
      - echo: "{path}"
      - rename:
          name: "{name | replace('[DVD] ','') | replace(' [1080p]','') | replace(' ', '_')}"
          on_conflict: "overwrite"

{name.replace(sth, other) takes the name and replaces sth with other but works from the full name every time. By using pipes as in the example above you can chain multiple renames.

Worked a charm! Appreciate it 😀

@drgrandios Thanks for reporting and sorry for the late reply. I kind of forgot about the first problem in this issue! This should be fixed in organize v3 because now all generated files are excluded for the rest of the rule.


show default values

Coverage increased (+1.8%) to 92.562% when pulling b9f7ca10d8a7fd0ff816499aeeafa25111df8151 on default-values into e82b8fa33a572fee9b712e7b95f5325dc2af2d0d on master.


How to aggregate the metrics for single test which runs parallelly

Hi All,
I need help how to aggregate the metrics for single test which runs parallelly in K8. I want to fail the jenkins pipeline if threshold failed. I know we cannot do this straight forward so I am thinking to push all the metrics into influxdb then aggregate the metrics and call hook in jenkins pipeline to pass the job or fail based on the threshold. Can we add any custom id field in K6 response to influxdb which can tell multiple metrics are part of single test?
Or any similar kind of approach if somebody has used?
Regards,
Amit

I believe this was answered in the community forum question. Please close the issue if so :slightly_smiling_face:


Can't be used with STL model

STL model doesn't have UV mapping. When apply CSG operation to loaded STL object, It will throw an error.

Hello! What error is thrown? It's important for each of the brushes to have the same vertex attributes but perhaps that can be communicated more effectively in the docs and errors.

Sorry just answering now. After reading the source, it appears UV attributes must exists in operated geometry. So I decided to generate UV for my STL model.

Hm looks like uv's are assumed. I had an issue where one model has a uv attribute and another doesn't. I called deleteAttribute('uv') on the model that has is, but then ran in to an error because the evaluator does assume there is a uv attribute:
https://github.com/gkjohnson/three-bvh-csg/blob/7ec1b6f839bfb0eb95d43cadbf6d56f1eacee4f6/src/core/Evaluator.js#L129

I confirmed locally that simply removing the uv property there allows everything to work


Lists over 9 items long break with indented content

Sandbox reproduction:

Live StackBlitz sandbox
PDF

The following html

I came in like a wrecking ball

I never hit so hard in love

Should be converted to:
 9. **I came in like a wrecking ball**

    ![](https://upload.wikimedia.org/wikipedia/commons/b/bd/Test.svg)

10. **I never hit so hard in love**

    ![](https://upload.wikimedia.org/wikipedia/commons/b/bd/Test.svg)

But instead it's converted to this non-commonmark compliant code:
9.  **I came in like a wrecking ball**

    ![](https://upload.wikimedia.org/wikipedia/commons/b/bd/Test.svg)

10.  **I never hit so hard in love**

    ![](https://upload.wikimedia.org/wikipedia/commons/b/bd/Test.svg)

Which creates a code_block instead of regular text and images because of the following CommonMark spec:

https://github.com/commonmark/commonmark-spec/blob/499ebbad90163881f51498c4c620652d0c66fb2e/spec.txt#L103-L117
Discussion: https://github.com/markdown-it/markdown-it/issues/800#issuecomment-889079213

Proposed solution
Remove whatever is adding the unwanted indentation between the list number and the list title. If this is intentional indentation, then move it to the beginning of the line, not between the list item.
That currently breaks 14 tests:
not ok 103 should be equal
not ok 104 should be equal
not ok 105 should be equal
not ok 106 should be equal
not ok 107 should be equal
not ok 108 should be equal
not ok 115 should be equal
not ok 116 should be equal
not ok 119 should be equal
not ok 120 should be equal
not ok 127 should be equal
not ok 128 should be equal
not ok 139 should be equal
not ok 140 should be equal

Additional notes:

The strong emphasis ** is not needed to reproduce the problem.
A space before the 9 looks nice, but isn't absolutely necessary in my testing
Offending code: https://github.com/mixmark-io/turndown/blob/ef41a54852afefb9383a5aa0668e1054bda3cc9b/src/commonmark-rules.js#L74

I've just encountered the same issue. This bug seems to be a fairly common problem, as it appears to affect all lists with more than 9 elements.


Add more consistent query integration tests

Coverage decreased (-0.09%) to 66.766% when pulling 247f3f7e01943fcdbc4613bc35406249645f717c on andrewjdawson2016:QueryIntTest into b86a313f9a5c5f9c9aa595e04cfc28d42f94177f on uber:master.


Use optimized vector format

I'm reverting this as there didn't seem that there was any benefit (on the web) when images are preloaded.
If you require this or want to compare here is the compiled svg branch   and here is the normal one
Both using a preloading mechanism. I did not find any difference (manual testing) so I'll merge the one that does not use precompiled picture.

I'm fine with a revert.

Do you recall how were those images generated ? Looking at them right now I see those are square images while the original are circles.

@cedvdb The optimised .vec files are generated by running dart tool/compile_svgs.dart.

I see those are square images while the original are circles.

What do you mean exactly? I see the .svg are square. And they both (.svg & .vec) render as circle because of the ClipOval widget.

What do you mean exactly?

The repository from which the svg are taken has circle flags. I was wondering if the fact that svgs are now squared flags is due to the optimization process that somehow shows information that was hidden or if you changed those files yourself.

tool wasn't part of main for some reason and it's been a long time.

I think actually this PR was reverted entirely.

The repository from which the svg are taken has circle flags

I think the flags turned square with this previous PR: https://github.com/cedvdb/flutter_circle_flags/pull/11


[AVM Module Issue]:

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
(Optional) Module Version
0.4.0
(Optional) Correlation Id
No response
Description
There's a requirement about the azapi version:
azapi (>= 0.1.0, < 1.14.0)
1.14.0 is limiting me to use some other AVM's, for example this one:
Azure/avm-res-operationalinsights-workspace/azurerm
Most modules require you to have at lease some version, but don't limit you on having a too new version.
Please adjust so there's no conflicts when using up to date versions.

Hello @pieter-jangoeman :
Will take a look into this shortly 👍

@pieter-jangoeman :
Please see the latest release v0.4.1 and let me know if these has been resolved.

Speaking about a quick fix, this seems to do the trick, thanks a lot
Donovan!
Kind regards,
Pieter-Jan
Op ma 4 nov 2024 om 18:06 schreef Donovan McCoy @.***>:

@pieter-jangoeman https://github.com/pieter-jangoeman :
Please see the latest release v0.4.1 and let me know if these has been
resolved.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/terraform-azurerm-avm-res-web-staticsite/issues/70#issuecomment-2455251671,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACFG76F4CZ5BBTSTRFHZNVLZ66LRVAVCNFSM6AAAAABREIUUX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGI2TCNRXGE
.
You are receiving this because you were mentioned.Message ID:
<Azure/terraform-azurerm-avm-res-web-staticsite/issues/70/2455251671@
github.com>


Add new OpenGL ES driver type

Introduce the OpenGL ES driver type and use it in the
EGL replay code path. Also propagate the GLES mode info
into the OpenGL driver class.

Manually merged in.


data_forward_vel.pt

hello !
may i have a look? The data_forward_vel.pt;
and would there be any trouble if i use HalfCheetah-v4 instead of halfcheetah-expert-v2?
thanks a lot!

btw do you have any reference papers for the code

I don't have the trained model anymore. It should work the same regardless of which version of the halfcheetah you use.
Unfortunately, I don't have a reference paper for this code. After experimentation without substantially successful results this project was abandoned.

thank you！and thank you for informing me the experiment result. that helps a lot. also i found the .pt files and vae model in another repository so i will give it a shot despite the not very successful result. thanks btw.


install errors on windows

Hi,
can you give me some info about the python versions you are using? I tried to get it to work on my Win10 x64 native installing python 2.7 and 3.9, and also using python 2 and 3 in cygwin without luck (the installation always got stuck at a certain point).
Actually I wanted to get it running on Unix or Mac, but it seems to heavily use Windows specific libraries...
Best

Hi @belveder79, apologies for the late reply to this. This library was developed using Python 3 (I don't remember which version specifically, however it was likely an early version such as 3.4) on Windows 10. Unfortunately I am no longer maintaining this library. All the best, Tom


Demseyk license updates

Adds license to Flipped Chamfer & Flipped fillet cases
License from https://github.com/sqfmi/watchy-cases/issues/23#issuecomment-1375895197
Would resolve https://github.com/sqfmi/watchy-cases/issues/23 & https://github.com/sqfmi/watchy-cases/issues/24 issues if merged
Thanks to @demseyk for the cases & clarification on the licenses

@sqfmi do you need anything else to merge this pull request?


getDefaultOpts is not defined

I'm attempting to import this library into a VueJS component and running into an unexpected error.  Perhaps I'm doing this wrong?
My VueJS component contains import showdown from 'showdown/src/showdown alongside other imports that are loaded correctly.  When I run my component I get the error:
showdown.js?25ac:9 Uncaught ReferenceError: getDefaultOpts is not defined
    at eval (showdown.js?25ac:9)
    at Object../node_modules/showdown/src/showdown.js (app.js?id=3655585264ebf1a5f704:1956)
    at __webpack_require__ (app.js?id=3655585264ebf1a5f704:20)

I'm attempting to use showdown like:
                converter: (function () {
                    return new showdown.Converter({
                        openLinksInNewWindow: true,
                    });
                })()

Then to use that dependency...
console.log(this.converter.makeHtml(this.body), this.body); // throws the error

I'm no expert in modern JS practices.  What am I doing wrong when using this library to trigger this error?

The error is here:

at Object../node_modules/showdown/src/showdown.js

You cannot import directly from the src directory. You need to import from the dist directory, where all library files are concatenated.

Yep, thanks!


Unsure of method to un-assign initiative/policy

What process is recommended / intended to un-assign a policy?
Removal of the assign.*.json file from the repo results in no error and no change via the GitHub Action.
Removal of the scope entry in the assignment JSON results in notification of successful update with "Assignment updated successfully" via GitHub Action but no change to the actual assignment. Currently, it appears that the only way to remove an assignment is via a direct API call or portal.

@farroar The actions does not support a method to un-assign a policy. Removal of scope entry leads to call to azure which sends back a success response but does not remove the scope.
As of now an assignment can only be removed via portal or an api call.

Could this be turned into a feature request? Is this connector being actively developed?

Re: @farroar:

Could this be turned into a feature request? Is this connector being actively developed?

The following sequence of operations is described in /lib/azure/forceUpdateHelper.js, in case it helps to formulate a feature request to support a new "force update" option with the desired effect.
/* APPROACH
1. Get all assignments and definition from Azure. We will need it in case we need to revert later.
2. For all definitions, check if their assignments are present in the code. If all assignments are not present in code we will abandon force update.
3. Create duplicate definitions and assignments.
4. Delete original assignments and definitions from Azure.
5. Create definitions and assignments from code. In case of any failure we will revert back to original definitions and assignments.
6. Delete duplicate assignments and definitions.
*/
function handleForceUpdate(definitionRequests, policyResponses, assignmentRequests, policyResults) {

Currently, the force update stops at Step 2 if there are Assignments in AZ that are not present in the code.
An enhancement might be to have a nuclear option which deletes all theAssignments, Initiatives, and Definitions in AZ before the deploy... possibly with a scope argument to limit the blast radius.


fix(errors): overridable title for HTTPNotAcceptable

and HTTPUnsupportedMediaType

Please don't close it, i'll fix it once i'll have time.

I guess requested changes are addressed. Not sure, though.


Add a game status cache

When getting the GameStatus property, it always recalculates. That is not necessary if we're sure that the status didn't change.

GameStatus has been replaced for a while already, and all the replacements have caching.


incorrect result on iPhone

Just ran a quick test app on the iPhone simulator and it seems to measure time differently.
I was getting the diff of two moments and on a desktop browser the result was 1 hour, on iPhone it was 1 year

here's the code i'm running, excuse the mess, it's just a quick prototype
<!doctype html>

<meta charset=utf-8>

<title>What's next?</title>

<meta name=description content="See what's next up on your agenda">
<meta name=author content="Wayne Ashley Berry">

<meta name="HandheldFriendly" content="True">
<meta name="MobileOptimized" content="320">
<meta name="viewport" content="width=device-width, initial-scale=1.0">

<link rel=stylesheet href=css/style.css>

Possibly a string parsing issue.
var next = moment(nextString); // change to the following
var next = moment(nextString, 'YYYY-MM-DD HH:mm'); // manually specify format

Although it's probably better to not use formatting and parsing, as its slower than direct manipulation.
var tasks = [
    {time: '05:00', hour:5, minute:0, task: 'Wake Up'},
    {time: '06:00', hour:6, minute:0, task: 'Play Minecraft'},
    {time: '13:00', hour:13, minute:0, task: 'Play Minecraft'},
    {time: '18:00', hour:18, minute:0, task: 'Play Minecraft'},
    {time: '19:00', hour:19, minute:0, task: 'Play Minecraft'},
    {time: '21:00', hour:21, minute:0, task: 'Play Minecraft'}
];
var taskly = function () {
    var task = tasks[0];
    // change to using manip methods instead of format and parse
    var next = moment().hours(task.hour).minutes(task.minute);
    var diff = next.fromNow(true);
    // fix grammar
    diff = diff.replace('an hour', 'an hours');
    diff = diff.replace('a minute', 'a minutes');
    renderTask(task.task, diff);
};

Also, I fixed your tasks list :D

Could this issue be iOS4 dependent? Seems like a few things are improved and fixed in iOS5.

Any update @knnktr ?

Closing, issue, let me know if there are still problems.


Git clone in-existent repository

Easy fix, just thought it worth to bring to authors attention that the git clone command for the set-up points to an nonexistent repository. I'm assuming it should point to this repo?

Thank you so much for pointing this out!
Fixed.


Cannot include vcpkg library in VSCode and CMake under Windows

Describe the bug
I am using VSCode with CMake under Windows and I installed the C ++ library boolinq via vcpkg install boolinq. But when I wanted to use boolinq, I got the error that VSCode can't find the header, and the build didn't work either.
Environment

OS: Windows 10
Compiler: MSVC v. 16.8.4

To Reproduce
Steps to reproduce the behavior:

vcpkg install boolinq
Create a CMake project in VSCode
Follow the instructions at github.com/Microsoft/vcpkg and the last time vcpkg was called
Look at the bug in VSCode or build the project
Repro code when

Expected behavior
No errors.
Failure logs
no
Additional context
I don't know if this question belongs here.
Also, if allowed, I would like to refer to my question on StackOverflow: https://stackoverflow.com/questions/66060463/vscode-c-the-file-source-cannot-be-opened-boolinq-boolinq-h

@DennisPodbicanin ,Thanks for posting this issue,Can you provide your CMakeLists and your error log?

@DennisPodbicanin  Can you please provide a sample project to reproduce this issue?
Thanks.

Hi, I have solved my problem.
Thanks for your help.

I have the same issue can you tell me how to fix this problem?

@Heming9  Since our VS Code plugin is not done, please add vcpkg tool-chain to the cmake configration in VS Code.

@Heming9 Since our VS Code plugin is not done, please add vcpkg tool-chain to the cmake configration in VS Code.

Thanks for your reply, I had tried adding vcpkg.make to the CMake configuration or the CMakeLists but it still occurs headers not found. For now, I‘m using third packages from vcpkg by including manually in CMakeLists and it compiles successfully. Looking forward to your VS Code plugin :D

@Heming9  Did you install the ports using static triplet?

@Heming9 Please pass -DVCPKG_TARGET_TRIPLET=x86-windows or -DVCPKG_TARGET_TRIPLET=x86-windows-static to the cmake parameters.


[WIP] readability experiment

Codecov Report

Merging #1321 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1321      +/-   ##
=========================================
- Coverage   65.65%   65.6%   -0.06%
=========================================
  Files          74      74
  Lines        5786    5786
  Branches      884     884
=========================================
- Hits         3799    3796       -3
- Misses       1723    1725       +2
- Partials      264     265       +1

Impacted Files
Coverage Δ

torchvision/transforms/transforms.py
80.94% <0%> (-0.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddda3a...fd36e82. Read the comment docs.


chore: only publish production packages to Bintray

The devel channels will be completely deprecated. The deb/rpm snapshot
builds will still be accessible through GitHub Releases as part of Resin
CI builds.
Change-Type: patch
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

I will delete the Bintray devel apps as soon as this is merged.


[ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths

What is this PR for?
The bin/zeppelin.sh startup script doesn't fully load the Hadoop classpaths in the same way that bin/zeppelin-daemon.sh does. As a result, anything that depends on the Hadoop classpaths being loaded (e.g. Shiro's KnoxJwtRealm) will fail.
What type of PR is it?
Bug Fix/Improvement
How should this be tested?

Verify that hadoop classpath values are added to Zeppelin's java process's classpath.
Verify that Shiro's KnoxJwtRealm loads correctly when running USE_HADOOP=true HADOOP_CONF_DIR=/path/to/conf bin/zeppelin.sh
Verify that the Zeppelin Docker image still works as expected.

Notes:

The classpath loading logic was copied directly from bin/zeppelin-daemon.sh.
The Zeppelin Docker image uses bin/zeppelin.sh as its startup script.  This PR will make it easier for users to extend the Docker image by adding Hadoop to it.  Currently, adding Hadoop requires extensive modifications to get the classpath to load correctly.

Questions:

bin/zeppelin-daemon.sh makes loading HADOOP_CONF_DIR conditional on USE_HADOOP but bin/zeppelin.sh previously didn't.  Should zeppelin.sh be made to work the same as zeppelin-daemon.sh or should it retain loading HADOOP_CONF_DIR without checking USE_HADOOP for backwards compatibility?
If this PR looks good, could you kindly apply the 'hacktoberfest-accepted' label? 😅

@llamasoft Could you please let me know your jira id?


[FEATURE] Add API endpoint to retrieve versions/builds

If I'm not mistaken there is no way to retrieve the available version numbers without usage of webhooks.
For automation purposes we are interested in retrieving the versions of a module.
This can be achieved by allowing to list builds per module.
Suggested API endpoint: GET /modules/:name/builds
I consider to implement this myself.

Thanks for the fast response!
Is there any issue I can subscribe to or give feedback at?

Not at the moment, but there will be an announcement when it is made public.
This isn't actionable, so closing.


Elaborate docs on TaskRunner interface

We have the TaskRunner interface is scarcely described in docs, adding details would make it more transparent for users. Specifically, I received questions regarding FL task methods signatures.

Closing as a duplicate of https://github.com/securefederatedai/openfl/issues/521


Update settings.js

fix typo in a comment

Coverage increased (+0.08%) to 86.108% when pulling 373547d75fbe6c5591f4ec8b4c83687557c28d27 on richlv:patch-1 into a42e99c4aa19c2aa981558e78d61554f73ae39bf on node-red:master.

Good spot - thanks!


Change keybindings

Just a small question: how can I change keybindings? I would like to remap things but I cannot find how. Thanks.

For vim, it's impossible for now, I have not came up with a good solution. If you want to hack it, see popup_filter and https://github.com/liuchengxu/vim-clap/blob/bee98419ccdc53222a14191e6731f89d827d7d77/autoload/clap/popup.vim#L399-L419 .
For neovim, take a look at https://github.com/liuchengxu/vim-clap/blob/master/ftplugin/clap_input.vim .
" For example, use <C-n>/<C-p> instead of <C-j>/<C-k>.
autocmd FileType clap_input inoremap <silent> <buffer> <C-n> <C-R>=clap#handler#navigate_result('down')<CR>
autocmd FileType clap_input inoremap <silent> <buffer> <C-p> <C-R>=clap#handler#navigate_result('up')<CR>

Aoutch.


why only bytes-read-rate has value in hot command

Please answer these questions before submitting your issue. Thanks!

What did you do?

run sysbench update_non_index with just only 1 table and 1m rows
» hot store
{
  "bytes-write-rate": {
    "1": 0,
    "4": 0,
    "5": 0
  },
  "bytes-read-rate": {
    "1": 2472,
    "4": 36933,
    "5": 193
  },
  "keys-write-rate": {
    "1": 0,
    "4": 0,
    "5": 0
  },
  "keys-read-rate": {
    "1": 0,
    "4": 0,
    "5": 0
  }
}

What did you expect to see?

I think bytes-write-rate should also have value.
Btw, maybe keys-read-rate and keys-write-rate have value too.

What did you see instead?

Only bytes-read-rate has value, I am confused about this result.

What version of PD are you using (pd-server -V)?

./bin/pd-server -V
Release Version: v3.0.0-beta.1
Git Commit Hash:<PHONE_NUMBER>1130d7d39759efb9f9677aebfc03db
Git Branch: master
UTC Build Time:  2019-03-27 01:51:58

Fixed via #1487 and tikv/tikv#4436.


Issues when editing features other than military symbology

When you have configured Military Tools and you start using the Symbol Editor you constantly get an alert that this is not a military symbol.

Can you provide some more repro info (and maybe screenshot that includes map+addin) like is this with a particular template/dataset? Is there something selected on the map that is not a military symbol when the editor modify tab is active? Dataset with both standards in the project?
(Unless bug) you should only get this message if (1) you are on the selection/modify tab and (2) you select a non-military feature.

Here are the steps to replicate the issue:

Start ArcGIS Pro
Create a New Project
Insert New Map
Click on the Military Symbol Editor from the Military Tools Add-in
Add the schema for either of the associated standards
Add Dark Map notes by clicking he add button on the  the Insert Ribbon
From the Edit Ribbon click Create Features
From the Create Features pane attempt to add a non military feature from the Dark Map Notes and you will get the error

@csmoore I think what could be done here to resolve this issue is for the symbol editor to somehow ignore all features that are using a renderer other than the dictionary renderer. Is that possible in the SDK?

@Dbarnes1 That's a great idea (and was even a TODO but probably should have done that to begin with )

@csmoore glad we're thinking similarly. Lets advocate for this enhancement to be made at planning tomorrow.

I do not categorize this as an enhancement. I am adding the bug tag based on the user experince. I find it very challenging to do any other type of work that involves editing if I get this popup every time I edit a feature. @nfeuerstein @lfunkhouser

Removed this pop-up in #155 - this was actually a bug, this pop-up was only supposed to happen once per session, but sounds like the warning could be removed altogether

@csmoore great work!
I have verified that this bug is fixed. Here is a screen shot that shows what I have been able to add:


Close connection when connecting to server fails

I was fixing a bug with the HA integration when I was pointed to this ticket: https://github.com/home-assistant/core/issues/67954
A brief look at the code says that the websockets are managed entirely within this package. If that's true, this is the only place where I see a leak of connections could be possible.

Thanks @raman325. Did you test this?

I was not able to see this issue on my system so I wasn't able to test that it fixed the issue. Perhaps we could ask someone from one of those old threads to check?

Yeah, I think that would be best


Improve the relations tab content entry and display

Add source and Add relation buttons on the Related Resources tab should allow user the option to pick a HydroShare resource or enter the information for an external resource (similar to the way the add author button gives users an option).
When information from an external resource is entered there needs to be more structure, such as Title, URL, Owner.
The listing of relationships should be more informative.  Extending what @horsburgh suggested in #1444
"isDerivedFrom" --> "This resource was derived from the following sources:"
"isPartOf" --> "This resources is part of the following resources:"
"isHostedBy" --> "This resource is hosted by the following system or organization:"
"isCopiedFrom" --> "This resource was copied from the following resource or source:"
"isExecutedBy" --> "This resource can be executed by the following resources:"
"isDataFor" --> "This resource is the data for the following publication:"
These headings should be followed by a formatted readable list of Title, URL (that is clickable) and owner.
These were unfinished items from #1444 that I am closing.

The drop down list in the "Add Relation" dialog has been modified to use the more descriptive labels of the relationship types.

They have also been modified for display on the landing page:

Note that "Derived from" is not a descriptive label and will be fixed as part of a more comprehensive modification to relations as part of #3261. I'm going to close this issue as it is mostly live on www and instead address with the remaining issues related to relations in #3261.


Request: Getting tx product fees in advance

It would be extremely useful for the name reseller to have a direct way to know the price in IOV Tokens of a tx, like register or renew or transfer.
Suggestion: Since the rules can be complex (depends on how many account for renew, multiplier for open domain, etc), the simplest would probably be to have a query and provide the exact tx to be performed as parameter, and get back the product fee that it will cost.
If in addition, it returns the gas fees minimum required, then the user has the full picture of the total cost of the domain tx that they are about to do.
This is going to be a very sensitive topic as soon as the price of the token is changing and since costs are not disclosed, it could generate very unhappy clients if they buy a 4 letter name without knowing it was super expensive and their account is deducted.
B

(this topic already came up with current name seller who thought the price was only the --fees 2000000iov in the command line, this is a dangerous user experience at the moment)


Fix typo (there not their) in Guide to Your Equity

yes, I actually read it to the end ;)

thanks!


Some refs disappear when generating in Hugging Face

Try this one in Hugging Face , it will generate an empty output.
@inproceedings{LocalAlgorithmFinding2013zhu,
title = {A Local Algorithm for Finding Well-Connected Clusters},
booktitle = {International {{Conference}} on {{Machine Learning}}},
author = {Zhu, Zeyuan Allen and Lattanzi, Silvio and Mirrokni, Vahab},
year = {2013},
pages = {396--404},
publisher = {{PMLR}}
}

Hi,
Thanks a lot for reporting this. Would you please try and see if you could help debug this with the current codebase? That would be super helpful! (I'll be quite busy this month).
Best,
Yuchen

No problem


Add alternative IKEA Symfonisk Gen1 signature

Proposed change
Adds an alternative signature for the IKEA Symfonisk Gen1 device.
This is a signature from 24.x firmware when newly paired.
It also cleans up the comments a bit and changes from the copying the device triggers to having all alternative classes inherit from IkeaSYMFONISK1 (device_automation_triggers is still the same for all then).
Since 24.x firmware no longer requires power doubling, this quirk does not double the power. It uses the PowerConfig1CRCluster cluster class to provide some information about battery quantity, size, and voltage.
Additional information
Device diagnostics with signature originally provided in: https://github.com/zigpy/zha-device-handlers/pull/2773#issuecomment-1826910690
Note: We still need a proper long-term solution for quirks with the older signatures (that could still match this device if updated and not re-paired) regarding battery percentage doubling. Related:

https://github.com/zigpy/zha-device-handlers/issues/2203
https://github.com/zigpy/zha-device-handlers/pull/2773 (discussion)

Checklist

[ ] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

Looks great and i trying getting time in the afternoon testing it !!!


Flow-Typed Support?

I noticed that you're using Flow but I was wondering if there were any plans to contribute your definitions to Flow Typed?

I was wondering the same :) and thanks for the project, what a pleasure!

I'm using this limited library definition, it's incomplete but it can be a nice start for making a complete one :)
declare module 'redux-little-router' {
  declare type HistoryLocation = {
    pathname: string,
    search?: string,
    hash?: string,
    state?: Object,
    key?: string
  };

  declare type Location = HistoryLocation & {
    basename?: string,
    options?: LocationOptions,
    params?: Params,
    previous?: Location,
    query?: Query,
    result?: Object
  };

  declare type BrowserRouterArgs = {
    routes: Object,
    basename?: string,
    getLocation?: () => Location,
    passRouterStateToReducer?: bool
  };

  declare type LocationAction = {
    type: 'ROUTER_LOCATION_CHANGED' | 'ROUTER_PUSH' | 'ROUTER_REPLACE',
    payload: Location
  };

  declare function Reducer(Location, LocationAction): Location;
  declare function ReducerGen(Location): Reducer;

  declare export function routerForBrowser(BrowserRouterArgs): {
    reducer: ReducerGen,
    middleware: any,
    enhancer: any,
  };
//  declare export function routerForExpress(any): any;
//  declare export function routerForHapi(any): any;
  declare export function initializeCurrentLocation(any): any;
//
//  declare export function provideRouter(any): any;
  declare export function RouterProvider(any): any;
//  declare export function Link(any): any;
//  declare export PersistentQueryLink: any;
//  declare export Fragment: any;
//
  declare export function push(any): any;
//  declare export replace: any;
//  declare export go: any;
//  declare export goBack: any;
//  declare export goForward: any;
//
//  declare export LOCATION_CHANGED: any;
//  declare export PUSH: any;
//  declare export REPLACE: any;
//  declare export GO: any;
//  declare export GO_FORWARD: any;
//  declare export GO_BACK: any;
}

Hey all! Definitely want to make this happen. Will keep you posted!


Add logic to speaking time management component

Draft version of the inner logic of speaking time management component

@reiterl can this PR be closed?

The speakers time management component is replaced by the speaking times component.
So this pr is no longer needed. I close it here.


Enable Spotbugs: NP_STORE_INTO_NONNULL_FIELD

Added required @Nullable annotations and converted some functions to Java8+ lambda.
This PR has:

[x] been self-reviewed.

[x] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the
items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary,
but it would be very helpful if you at least self-review the PR.

For reviewers: the key changed/added classes in this PR are MyFoo, OurBar, and TheirBaz.
(Add this section in big PRs to ease navigation in them for reviewers.)

@clintropolis This is the first step into fixing the annotations, could we move this forward?

@clintropolis This is the first step into fixing the annotations, could we move this forward?

Apologies, I've been very busy, I'll try to get to this sometime this week 😅

Thanks. There are no functional changes to the code, so it should be pretty straightforward.


[Backport v1.14-branch] Bluetooth: controller: Fix regression in ctrl tx queue handling

Fix control Tx buffer leak into data Tx pool that happens
after a cross-over control procedure response was paused due
to currently active encryption setup procedure, and a new
control Tx PDU in addition to the paused one is enqueued
thereafter.
When the control tx PDUs is resumed but not yet enqueued
towards the radio, if there is a new control Tx PDU enqueued
then the paused control Tx PDU is not set as the head of the
control PDUs in the Tx queue. This caused the paused control
Tx PDU to be associated with data Tx pool, hence causing the
incorrect release into data Tx pool.

Fixes #32898.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

Can you rebase now that the doc building is fixed.


Svt oppet arkiv

Checklist

[ x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.05.11
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE
```[05/11/19 18:42:38] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[05/11/19 18:42:38] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[05/11/19 18:42:39] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[05/11/19 18:42:40] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

## Description
When i try to download from SVT oppet arkiv i get error. It have been working perfect Before. But since some weeks it dosent work at all with any files. But it works on SVT play now  again. But not on SVT oppet arkiv.
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->

WRITE DESCRIPTION HERE

Checklist

[ x] I'm reporting a broken site support issue
[x]  I've verified that I'm running youtube-dl version 2019.05.11
[x]  I've checked that all provided URLs are alive and playable in a browser
[x]  I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar bug reports including closed ones
[x]  I've read bugs section in FAQ

Verbose log
PASTE VERBOSE LOG HERE
```[05/11/19 18:42:38] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[05/11/19 18:42:38] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[05/11/19 18:42:39] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[05/11/19 18:42:40] ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

## Description
When i try to download from SVT oppet arkiv i get error. It have been working perfect Before. But since some weeks it dosent work at all with any files. But it works on SVT play now  again. But not on SVT oppet arkiv.
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->

WRITE DESCRIPTION HERE


DV: width/height/chroma when stype is 1

Suggestion for https://github.com/mipops/dvrescue/issues/290, while finding a better way.

could you confirm the output for
test.dv.zip

I'd also like to test this against http://samples.ffmpeg.org/ffmpeg-bugs/roundup/issue1407/dv_dsf_1_stype_1.dv, but I suggest we merge and I'll test in the daily build.

Thanks, can you bump an update at https://mediaarea.net/download/snapshots/binary/dvrescue/.

Latest build should be fine.Sent from my smartphone.
-------- Message d'origine --------De : Dave Rice @.> Date : 18/06/2021  17:57  (GMT+01:00) À : MediaArea/MediaInfoLib @.> Cc : Jérôme Martinez @.>, State change @.> Objet : Re: [MediaArea/MediaInfoLib] DV: width/height/chroma when stype is 1 (#1394)
Thanks, can you bump an update at https://mediaarea.net/download/snapshots/binary/dvrescue/.
—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or unsubscribe.


[FLINK-2136] Adding DataStream tests for Scala API

Added tests for scala DataStream
Added tests for setting parallelism
Added tests for operators
Fixed some small bugs in scala API
Added exception throwing to streaming functions

Thanks, this is definitely a must have.

Please fix the scala style issues. :)

Fixed the style issues and added more tests.

General questions: Are type hints implemented already in the streaming API?

@StephanEwen: The SingleOutpustStreamOperator has the returns method, similar to the batch API.

Let me merge this for the release now.

The iteration test sometimes fails on travis, so  removed that.
https://travis-ci.org/mbalassi/flink/jobs/65594738

Thanks for merging. I removed the line that failed the test (I mistakenly checked a non-deterministic id).
https://github.com/gaborhermann/flink/commits/FLINK-2136

Please open a PR with it. Could you give FLINK-2180 a try in the meantime please? It looks similar on paper. You can add then to the same pull request of course. :)

Of course. I took up the JIRA issue.


[WIP]  graph tile splitting

At this point, I think I've reached "feature parity" and am focused on testing it and trying to break it at the moment.
The last couple things I implemented included the margin/padding although, I may have changed the behavior slightly. The existing nog implementation combines margin & padding but I wrote them up to be separate. I'm still testing that piece out a bit;  there are some setups where windows get shifted slightly.
I also added a component for my sanity so I can tell what my next split is or if I'm in fullscreen.
Still planning on adding more unit tests, code documentation, and updating relevant parts of the main documentation and then I guess working on refactoring based on feedback. I'd say it's definitely in a usable state though.

The existing nog implementation combines margin & padding but I wrote them up to be separate.

I had it like this before, but I remember that sometimes you could have rounding issues, which results in uneven padding.
I have very little free time this month, so I might take some time to respond to something. I'll look at the PR this Sunday.

I feel like the cross-platform branch should be merged before we merge this.  Could you help me make the cross-platform branch compile so that I can finally try to merge this into development? Sorry, I really overdid it with the refactoring.
On another note I think once this PR and the other one are merged we'll have a lot more possiblities in the future.

Yeah I took a peak at the cross platform branch and saw the overlap. I agree it makes sense to handle that one first and then I can rebase this on top.

Could you help me make the cross-platform branch compile so that I can finally try to merge this into development?

Yeah, I'll take a look. No worries

Have you started with the refactor yet?

Have you started with the refactor yet?

Yeah, started the rebase. I'll probably have more time this week to get it done. I don't think it'll be too bad so far.

Small update: still chipping away at this.. I have to just merge some of the rendering differences and then I can get to actually running it regularly to re-test everything. Aiming for an updated pull request by the weekend hopefully of something usable and then going to push more commits on top as I find and fix issues/change to address feedback.

I'm in the early-testing phase at this point, just ironing out bugs/differences that I need to update.
I have been pulling in the changes you've been pushing to the cross-platform branch, haven't gotten to 01bb20e136e2adc1f74060b2640e5d5174a9c333 yet.
However, one issue I'm running into that's slowing me down a bit has to do with modes.. I haven't needed to change any of the keybinding stuff really so I'm not clear why it's happening, but when I enter a mode the keybinding to exit the mode isn't registering. Like.. it does get registered but it's like nog doesn't pick up the keybinding at all, it doesn't get to the point where it even logs that a keybinding was entered.
Are you having any problems switching out of modes? @TimUntersberger
This is what my mode config for resize looks like
mode "resize" "Alt+Shift+R" {

bind "H" resize("Left", 2);
bind "Shift+H" resize("Left", -2);

bind "J" resize("Down", 2);
bind "Shift+J" resize("Down", -2);

bind "K" resize("Up", 2);
bind "Shift+K" resize("Up", -2);

bind "L" resize("Right", 2);
bind "Shift+L" resize("Right", -2);

bind "A" focus("Left");
bind "W" focus("Up");
bind "D" focus("Right");
bind "S" focus("Down");
}

I fixed it in the latest commit.

Ok, so I updated the pull request.
There's still going back and adding docs/tests and more comments, but I think it's at a state where it's usable and rebased on latest development branch. I'll continue updating it if I find issues.
If you want to test out the tiling, this is the "mode" file I use
mode "move" "Alt+M" {
    bind "W" focus("Up");
    bind "A" focus("Left");
    bind "S" focus("Down");
    bind "D" focus("Right");

    bind "H" swap("Left");
    bind "J" swap("Down");
    bind "K" swap("Up");
    bind "L" swap("Right");

    bind "Alt+H" move_in("Left");
    bind "Alt+J" move_in("Down");
    bind "Alt+K" move_in("Up");
    bind "Alt+L" move_in("Right");

    bind "Alt+Shift+H" move_out("Left");
    bind "Alt+Shift+J" move_out("Down");
    bind "Alt+Shift+K" move_out("Up");
    bind "Alt+Shift+L" move_out("Right");
}

Ok just a quick recap
Before:

After:

Swap up/down moves a tile up or down within its column.
Swap left/right moves a tile left and right within its row.
(I'm considering adding a bubbling up feature to the swap so that applies the swap to the next parent node that makes sense if the current tile can't complete the operation)
MoveIn/MoveOut behaves as follows..
Starting from this layout (notepad | cmd | vim) with the vim tile focused

Move_In Left moves the focused vim tile into a row node with the cmd tile

Move_Out Up creates a parent row node with the focused vim tile as the first child and the column node (with the notepad and cmd tiles as children)  as the second child

I did notice I need to update a couple key bindings changes that are causing the grids to lose their focused tile. I would say at this point pulling it down and compiling it is only worth it to check out the tiling on the latest code but otherwise it might be worth waiting until I update with fixes for the focusing issues I noticed.

Rebased on latest and did a smoke test + running unit tests, seems to all be working well.
Current TODO list

[ ]  replace Panics with SystemResult usage
[ ]  add more unit tests and code comments for generated docs
[ ]  update doc pages with binding information/examples

I did notice that the current version of nog allows the user to use all keybindings while a tile is fullscreened. I had added checks in several functions that I thought would be confusing if the user accidentally triggered them while fullscreened like swapping tiles or moving in/moving out.
@TimUntersberger Would you prefer if those checks were removed? Another thought I had was to leave the checks in place but allow the user to focus left/right/up/down while fullscreened to switch applications but have the focus behavior ignore the grid layout and instead move forward/backward iterating across the tiles in the grid. That way it ignores the complexity of remembering whether a tile is above or 3 columns over but still allows you to iterate through the whole grid.

I quite like the idea of being able to use all of the keybindings when a window is fullscreened. Maybe we could introduce a setting for that?

I quite like the idea of being able to use all of the keybindings when a window is fullscreened. Maybe we could introduce a setting for that?

Sure, I can default it to allow keybindings while fullscreened.

I added a config "ignore_fullscreen_actions" that defaults to false but am still a little unsure on how it should behave when doing different things while the grid has a tile fullscreened. For example, focusing to the right would set focus to a tile that is to the right of the one currently fullscreened... should that change what is currently fullscreened as well?
That aside, have you had a chance to check out some of the other changes?

For example, focusing to the right would set focus to a tile that is to the right of the one currently fullscreened... should that change what is currently fullscreened as well

fullscreen mode only displays the focused tile right now, so that means if you change the focused tile the displayed tile should also change.

That aside, have you had a chance to check out some of the other changes?

I thought you are still working on this PR. If you feel like the PR is ready please change the title from [WIP] to [RDY].

Cool, yeah. I think it's in a good state to start reviewing and I can make changes as needed. Let me know if you'd prefer it as one squashed commit vs how it is currently.

I played with your PR and I don't notice any problems. One thing I am happily surprised by is the speed gain this PR adds. Switching workspaces feels a lot more smooth and fast now.
If you don't have anything else you want to do then please rebase ontop of the latest development commit.

I also added you as a collaborator to this repo as you showed that you truly care about this project and your code looks really professional.

If you don't have anything else you want to do then please rebase ontop of the latest development commit.

Cool, yeah. I added one small fix for the current_window component just needed to sync it with where the window title comes from now. The pull request is now a set of commits on top of the latest development commit. It should be good to go, but let me know if you're prefer it squashed into one commit instead of separate ones.

I also added you as a collaborator to this repo as you showed that you truly care about this project and your code looks really professional.

Thank you, I really appreciate that. This project has made my work days a lot more productive and fun and it's cool to be a part of it. I'm excited to see where it goes.


Refactor SendAmount screen and add support for cEUR to it

Description
This PR does a big refactor of the SendAmount screen. It's been split up into 4 files:

SendAmount -> The base screen, stripped of many parts
SendAmountValue -> Render the amount to send
AmountPadInput -> Numeric pad that can be used to change the amount
useTransactionCallbacks -> A hook that returns two functions, onSend and onRequest that should be called when the user pressed the button to continue.

This PR is part of a bigger effort to add cEUR support to Valora and more specifically to the Send/Request/Invite flows. Those three flows will be able to be implemented in future PRs based on this one.
https://user-images.githubusercontent.com/6062888/117740821-a177cc80-b1d7-11eb-8ef2-394f70a68e22.mov
Other changes

The SendAmount screen uses a custom header now instead of using the react-navigation one. This is because it was preventing the CurrencyPicker to show up over the header. Having a custom one gives us more flexibility when designing the UI.
Moved the cUSD and cEUR balance selectors to a selectors file (they were in reducers) and added a balancesSelector that fetches the balance of all tokens.
Changed some analytics events to support multiple currencies and not just dollars.
Added a bunch of helpful hooks to convert between currencies.

Tested
Manually
How others should test
This should be tested as a part of the whole send cEUR experience. It's not completed yet, so we should probably wait until it's completely done before testing, but the way to test is:

When you have both a cUSD and a cEUR balance, the title of the SendAmountScreen has a dropdown button that opens a currency picker when pressed.
When you don't, there's no such button and your currency is automatically chosen for you.

Related issues

Part of #214

Backwards compatibility
N/A

https://valora.testquality.com requirement R42.

https://valora.testquality.com requirement R56.

https://valora.testquality.com requirement R57.


Added Animated icons to the Navbar

Is your feature request related to a problem? Please describe.
No there is no problem in this features
Describe the solution you'd like
This features gives new good look to the page
Additional context
Add any other context or screenshots about the feature request here.
https://github.com/Priyaaa1/StartConnect-Hub/assets/137484958/b56fbab2-22f0-4e1c-80e2-1b359d8206a1

Hii @Priyaaa1
Can you please assign me this issue?


Migrate to Glide

Remove the hardcoded use of Android Universal Image Library, and generalize to an interface that can be injected.   Implement an implementation of this interface that uses Glide.

Removed the Android Universal Image Loader library, it served us well.  Long live Glide until something better comes along.


Bad performance on ObjectNet

I run your code and got a similar result with the paper except ObjectNet. The top-1 acc on ObjectNet is only 54.7%. I found the images in my ObjectNet is 50273 but not 50000. I downloaded the ObjectNet from the official url https://www.dropbox.com/s/raw/cxeztdtm16nzvuw/objectnet-1.0.zip and unzip it. Do you have any idea why this happened?

Really glad receive your reply! Another question I found is that when I evaluate on ObjectNet, not all images but only 18574 images of 113 classes are utilized. Is there something wrong with the code in ObjectNet?

The code uses ImageNet data loader from folders (https://pytorch.org/vision/stable/generated/torchvision.datasets.ImageFolder.html). Can you check how many class folders are there in the local data path?

There are 50273 images of 313 class folders in the local data path. Hope to see your revised results in your paper! Thanks!

Hi, @SachinG007
I also have the same problem. If you already have any scores related to this, would you mind sharing them here? Thank you so much.

Hi @BierOne ,
I haven't yet got a chance to rerun the numbers. I can try though getting numbers by late next week.

Glad to hear that! Thanks :)

Have you rerun the objectnet experiments yet? I got an acc of 55.4% for ZSL and 54.7% for FLYP. I can't match the performance of other methods (i.e. FT, LP, LP-FT), too.

@LixDemon May I know if you could share your trained weight on ImageNet? It seems this repository does not provide it. Thank you!

@LixDemon , I didn't yet get a chance to rerun the ImageNet experiments. I will get back on this. @Simon4Yan , I can upload the model once I rerun it.
Thanks

Hi @LixDemon and @Simon4Yan ,
I am uploading a FLYP finetuned (on ImageNet) checkpoint of CLIP (ViT-B-16) here.
The updated FLYP and Zeroshot numbers for ObjectNet:
Zeroshot:
Evaluating on ObjectNet
ObjectNet Top-1 accuracy: 0.5333
Finetuned:
Evaluating on ObjectNet
ObjectNet Top-1 accuracy: 0.5499
I will also update the paper once I get the numbers for the baselines as well.
Thanks.

Hi @SachinG007,
Really glad to hear that! Can't wait to see the revised paper.
Thanks for your detailed reply!

@SachinG007 Thank you for sharing the model weights. Also, I am interested in the revised version. Kind Regards!


[SR-13458] Allow more flexible and strict line break configurations

Previous ID
SR-13458

Radar
None

Original Reporter
@klanchman

Type
Improvement

Additional Detail from JIRA

Votes
0

Component/s
swift-format

Labels
Improvement

Assignee
None

Priority
Medium

md5: d43456d18f7712a96680bbb98f0e91ff

Issue Description:
I'd like to see swift-format include additional configuration for line break formatting that allows for some additional flexibility and strictness in where line breaks are inserted/removed.
Right now swift-format includes the respectsExistingLineBreaks option, but setting it to false doesn't do what I expect, nor what I'd like.
Suppose I had unformatted code that looked like this:
class MyClass {

  var foo: String?
  var bar: String? {
    didSet {
      print("foo set")
    }
  }

  func doStuff() {

    guard let foo = foo else {
      return
    }

    doOtherStuff(foo)

  }

}

Setting respectsExistingLineBreaks to false yields the following:
class MyClass {

  var foo: String?
  var bar: String? { didSet { print("foo set") } }

  func doStuff() {

    guard let foo = foo else { return }

    doOtherStuff(foo)

  }

}

Given the documentation's description, "only inserting line breaks where absolutely necessary and removing any others", what I expected would be more like this:
class MyClass {
  var foo: String?
  var bar: String? { didSet { print("foo set") } }
  func doStuff() {
    guard let foo = foo else { return }
    doOtherStuff(foo)
  }
}

However, my goal would be to have swift-format output the following:
class MyClass {
  var foo: String?
  var bar: String? {
    didSet {
      print("foo set")
    }
  }

  func doStuff() {
    guard let foo = foo else {
      return
    }

    doOtherStuff(foo)
  }
}

This is more in line with the output of other code formatters I use, such as Prettier.
Notably, in the desired output:

blank lines are removed following open and close braces (e.g. within the class declaration, and within doStuff() function)

line breaks within braces for short statements are preserved (e.g. the entire didSet block, and the return in the guard)

line breaks (or lack of) between consecutive declarations are preserved (e.g. no break between the two var declarations, but break between the last var and the func)

The second bullet point has some caveats, mainly that you'd probably want the line breaks to be consistent on each side of the block. For example, I would not want swift-format to keep this:
var bar: String? { didSet {
  print("foo set")
}}

Setting respectsExistingLineBreaks to true and formatting the code above already results in what I'd expect / want in my "ideal" output:
var bar: String? {
  didSet {
    print("foo set")
  }
}

I might go as far as to say that the rule I'd want for the second bullet point is basically "require a line break after opening curly braces and before closing curly braces".

As far as I can tell, with the options that swift-format has, currently it is not possible to enforce the desired output.

Tracked in Apple’s issue tracker as rdar://126948279