Operator can manage apps domains and their TLS certs without modifying "system" resources

Looking at the workflow here I'm realizing that it works, but isn't optimal.  The operator has to modify a gateway in the istio-system namespace, which was laid-down by cf-for-k8s itself.
A better workflow would be that the operator creates and manages their own Gateway resources, possibly in cf-system or cf-workloads namespaces.  They don't need to change anything in the istio-system namespace.  That is easier for them to manage via declarative config + GitOps.  It is also safer for upgrades: their changes are at less risk of being blown away by a redeploy of cf-for-k8s.
Thoughts?

We now have one gateway object that we want to be the source of truth, the one in cf-system here
Using one gateway allows us to support app and system domains being the same, without having conflicting domains in two gateways. Because the gateway has to manage both app and system domains, we think it makes sense that it belongs in cf-system. What do you think @rosenhouse?
We also plan to update the referenced doc to reflect the single gateway.
That being said, we realized that there is one more gateway object created in istio-system which has:
- hosts:
  - '*'

and we're not sure if that's necessary. We're writing a story to see if we can not include the gateway in istio-system.
-- Nitya and @christianang

Sounds good to me.  I think it would be cleaner if we didn't create the istio-ingressgateway in istio-system.  that's part of the default install, but we don't use it, so I'd remove it.
If other software on the cluster wants to piggyback on the cf-provided istio, they're breaking the rules, and should at the very least have to bring their own gateway.

Great, we've captured this information in this story where we'll delete that gateway and document that decision.
Closing this issue :)


Links not working from intercom messenger

Hi there, we use the branch plugin with the intercom plugin (https://github.com/intercom/intercom-cordova) - Both are on the latest version and there are no errors but when we click on a valid branch link sent via intercom into the intercom messenger window (built into our app), the link doesn't trigger the branch action - it closes the messenger and goes through branch.init() as our app resumes, but the link doesn't get recognised.
The same branch link works perfectly from Slack/SMS or any other external app, but fails when launched within intercom in our app.
I'm not sure why this is happening, I hope you can help - thanks in advance

Hello,
When looking at the Intercom plugin, I am not seeing anything that should interfere with the Branch Cordova SDK. Their plugin focuses on push notifications while Branch focuses on deep linking. Additionally, the Intercom app is not included in our regression testing for supported platforms, so there could be an edge case we are missing.
When testing the Intercom app, I am able to get deep link data successfully on iOS, Android, background, and foreground. So I'm not too sure where the problem can be.

My apologies if this is a bit confusing. Links work fine from Intercom's public app (and all other external apps) - However Intercom also offer a plugin (https://github.com/intercom/intercom-cordova) which allows us to include their intercom messenger inside our app (to chat with our customers). Links from that plugin's window do not work, even though the same link works fine from outside the app.
I hope this makes more sense, thank you.

I wonder is this issue similar to #394? Is it possible branch links do not work when clicked inside the app? I would really appreciate your feedback on this. Thanks.

Hi, @Coolcat13 !
I'm working with @YaroslavG on #394, we've contacted the Branch support regarding this issue, but no solution so far. Branch links inside the app don't work for us too, but seem to work fine when opened from another app.
I'll try to post a solution here, if we come to any.

@Coolcat13 @dbek
I'm facing the same problem right now, did u guys find any work around on this?
Thanks

hi @rodrigoreal we ended up using the cordova "custom URL plugin" as well as branch and letting it handle the links within the app. So far so good, still in testing.


Download speed isn't fast as it could be while downloading consecutive files

Say, I run a command to download a video. It downloads on full speed till the first file(.mp4 w/o audio) is downloaded. But when it proceeds to download the audio file(.m4a), the speed lowers significantly (from ~250KBps, my full bandwidth, to ~10KBps).
But if I cancel the download and run the command again, it resumes the download with full speed.
It's not just for .m4a files. For ex.it happens also when proceeding to .mp4 file of next video after finishing .m4a files of prev. video from the same playlist.
It's a minor annoyance really to having to enter commands each mins or so. But I am automating it as I run shell from within emacs.
Any help would be nice.
It happens on both of my ubuntu and linux mint machine. I'm using the version of 2015.08.09.
(Also I don't know if it's a right place to report this.)

There is nothing youtube-dl can do about that - that's how it's served by YouTube.


Spray all linear shaft mounting hardware with Fluid Film

To keep them from corroding. Fluid Film is in aerosol can on control platform shelf.

Have done some of this already. Looks pretty good.


⚠ Samsung has degraded performance

In 30ac138, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2678 ms

Resolved: Samsung performance has improved in c9a0fb6.


feat: add type as first class attribute in relationship definition

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

@leecalcote As this gets merged we should make a release with v1beta1 tag?

@MUzairS15 yes, please.

There's an open PR that deletes the failing (and inappropriate) eslint-check / runner / eslint (pull_request) workflow.

That's merged.

LGTM


reworked translation and added missing string

reworked translation to more official german and added no_cleanup-string

Hello MrBrax,
have you seen this pull request? I Changes a lot of strings to more official german and added the one that was missing.
Greetings
Matze

must have forgotten it due to the weird merging of the master file


Fix panic within set due to a bug causing it to fail to expand the storage

Hi! Are there any plans to review this?


Driver not work

Describe the problem
During the initial installation on the beta version of Venus OS 3.20 ~ 16, everything went fine, except that the BMSs kept connecting and disconnecting via Bluetooth, so I uninstalled the installation according to the instructions. Now, I wanted to reinstall the driver again, and since then, it hasn't been working. During the installation, it reports an error with a non-existent folder /service/gui/, and in the BT log, it throws 'ERROR:SerialBattery:Unexpected err=ModuleNotFoundError("No module named 'dbus_fast._private.constants'"), type(err)=<class 'ModuleNotFoundError'>.
Driver version
latest
Venus OS device type
Cerbo GX
Venus OS version
3.20 ~ 26
BMS type
JKBMS / Heltec BMS
Cell count
15
Connection type
Bluetooth
Config file
[DEFAULT]

; If you want to add custom values/settings, then check the values/settings you want to change in "config.def>
; and insert them below to persist future driver updates.

; Example (remove the semicolon ";" to uncomment and activate the value/setting):
; MAX_BATTERY_CHARGE_CURRENT = 50.0
; MAX_BATTERY_DISCHARGE_CURRENT = 60.0

BLUETOOTH_BMS = Jkbms_Ble C8:47:80:01:92:CE

Relevant log output
@400000006557892532a723e4 Missing device address argument
@400000006557892719630bdc INFO:SerialBattery:Starting dbus-serialbattery
@40000000655789271a74c22c INFO:SerialBattery:dbus-serialbattery v1.0.20230531
@400000006557892804c68e9c INFO:SerialBattery:Init of Jkbms_Ble at C8:47:80:01:92:CE
@400000006557892805746e54 INFO:SerialBattery:Test of Jkbms_Ble at C8:47:80:01:92:CE
@400000006557892814b070ac ERROR:SerialBattery:Unexpected err=ModuleNotFoundError("No module named 'dbus_fast.>
@400000006557892814bdc2d4 ERROR:SerialBattery:ERROR >>> No battery connection at Jkbms_Ble
@400000006557892814c2aca4
@40000000655789282c8d72ec Missing device address argument
@400000006557892a1276f39c INFO:SerialBattery:Starting dbus-serialbattery
@400000006557892a129d9e0c INFO:SerialBattery:dbus-serialbattery v1.0.20230531
@400000006557892a358b736c INFO:SerialBattery:Init of Jkbms_Ble at C8:47:80:01:92:CE
@400000006557892a359677bc INFO:SerialBattery:Test of Jkbms_Ble at C8:47:80:01:92:CE
@400000006557892b02b8a5cc ERROR:SerialBattery:Unexpected err=ModuleNotFoundError("No module named 'dbus_fast.>
@400000006557892b02c3d12c ERROR:SerialBattery:ERROR >>> No battery connection at Jkbms_Ble
@400000006557892b02c8268c
@400000006557892b15004a14 Missing device address argument
@400000006557892d04e65f24 INFO:SerialBattery:Starting dbus-serialbattery
@400000006557892d04fb5654 INFO:SerialBattery:dbus-serialbattery v1.0.20230531
@400000006557892e0771f7bc INFO:SerialBattery:Init of Jkbms_Ble at C8:47:80:01:92:CE
@400000006557892e077ec8fc INFO:SerialBattery:Test of Jkbms_Ble at C8:47:80:01:92:CE
@400000006557892e107e8e9c ERROR:SerialBattery:Unexpected err=ModuleNotFoundError("No module named 'dbus_fast.>

Any other information that may be helpful
No response

But at least we can see it in the logs... Please install the latest nightly from the dev branch. There the error is fixed. Else see https://github.com/Louisvdw/dbus-serialbattery/issues/785

Oh, I apologize, I overlooked this.. I installed the latest nightly dev, and now the log looks like this:
==> /data/log/dbus-blebattery.0/current <==
2023-11-17 17:35:53.043652500 ERROR:SerialBattery:No BMS found at C8:47:80:01:92:CE
2023-11-17 17:35:53.043662500 ERROR:SerialBattery:ERROR >>> No battery connection at Jkbms_Ble
2023-11-17 17:35:53.431146500
2023-11-17 17:35:53.431569500 INFO:Bluetooth details
2023-11-17 17:35:53.552588500 [CHG] Device C8:47:80:01:92:CE RSSI: -73
2023-11-17 17:35:53.552598500 [CHG] Device C8:47:80:01:92:CE RSSI: -62
2023-11-17 17:35:53.552601500 [CHG] Device C8:47:80:01:92:CE RSSI: -70
2023-11-17 17:35:53.552604500 [CHG] Device C8:47:80:01:92:CE RSSI: -61
2023-11-17 17:35:53.552606500 [CHG] Device C8:47:80:01:92:CE RSSI: -73
2023-11-17 17:35:53.552609500 [CHG] Device C8:47:80:01:92:CE RSSI: -63
2023-11-17 17:35:53.552612500 [CHG] Device C8:47:80:01:92:CE RSSI: -73
2023-11-17 17:35:53.552776500 [CHG] Device C8:47:80:01:92:CE RSSI: -63
2023-11-17 17:35:53.552779500 [CHG] Device C8:47:80:01:92:CE RSSI: -73
2023-11-17 17:35:53.552782500 [CHG] Device C8:47:80:01:92:CE RSSI: -63
2023-11-17 17:35:53.552785500 [CHG] Device C8:47:80:01:92:CE RSSI: -72
2023-11-17 17:35:53.552787500 [CHG] Device C8:47:80:01:92:CE RSSI: -63
2023-11-17 17:35:53.552790500 [CHG] Device C8:47:80:01:92:CE RSSI: -62
2023-11-17 17:35:53.552819500 [CHG] Device C8:47:80:01:92:CE RSSI: -70
2023-11-17 17:35:53.552822500 [CHG] Device C8:47:80:01:92:CE RSSI: -62
2023-11-17 17:35:53.552825500 [CHG] Device C8:47:80:01:92:CE RSSI: -73
2023-11-17 17:35:53.552828500 [CHG] Device C8:47:80:01:92:CE RSSI: -62
2023-11-17 17:35:53.552830500 [CHG] Device C8:47:80:01:92:CE RSSI: -73
2023-11-17 17:35:53.552833500 [CHG] Device C8:47:80:01:92:CE RSSI: -63
2023-11-17 17:35:53.552961500 [CHG] Device C8:47:80:01:92:CE RSSI: -71
2023-11-17 17:35:53.552964500 [CHG] Device C8:47:80:01:92:CE RSSI: -61
2023-11-17 17:35:53.706221500 Attempting to disconnect from C8:47:80:01:92:CE
2023-11-17 17:35:53.706230500 [CHG] Device B0:D2:78:4E:98:E7 RSSI is nil
2023-11-17 17:35:53.706233500 [CHG] Device D7:38:33:47:F9:6D RSSI is nil
2023-11-17 17:35:53.706236500 [CHG] Device D4:9D:C0:55:D7:F1 RSSI is nil
2023-11-17 17:35:53.706238500 [CHG] Device C8:47:80:01:92:6B RSSI is nil
2023-11-17 17:35:53.706241500 [CHG] Device C8:47:80:01:92:CE RSSI is nil
2023-11-17 17:35:53.706244500 [CHG] Controller 00:1A:7D:DA:71:15 Discovering: no
2023-11-17 17:35:53.706405500 Successful disconnected
2023-11-17 17:35:58.798148500 Device C8:47:80:01:92:CE (public)
2023-11-17 17:35:58.798157500   Alias: Battery 1
2023-11-17 17:35:58.798159500   Paired: no
2023-11-17 17:35:58.798160500   Trusted: no
2023-11-17 17:35:58.798161500   Blocked: no
2023-11-17 17:35:58.798163500   Connected: no
2023-11-17 17:35:58.798164500   LegacyPairing: no
2023-11-17 17:35:58.798166500   RSSI: -62
2023-11-17 17:35:58.799077500
2023-11-17 17:36:01.050505500 INFO:SerialBattery:
2023-11-17 17:36:01.051716500 INFO:SerialBattery:Starting dbus-serialbattery
2023-11-17 17:36:01.053745500 INFO:SerialBattery:dbus-serialbattery v1.0.20231103dev
2023-11-17 17:36:02.237230500 INFO:SerialBattery:Init of Jkbms_Ble at C8:47:80:01:92:CE
2023-11-17 17:36:02.238195500 INFO:SerialBattery:Test of Jkbms_Ble at C8:47:80:01:92:CE
2023-11-17 17:36:02.459013500 Exception in thread Thread-1:
2023-11-17 17:36:02.459022500 Traceback (most recent call last):
2023-11-17 17:36:02.459024500   File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
2023-11-17 17:36:02.459028500     self.run()
2023-11-17 17:36:02.459029500   File "/usr/lib/python3.8/threading.py", line 870, in run
2023-11-17 17:36:02.459032500     self._target(*self._args, **self._kwargs)
2023-11-17 17:36:02.459034500   File "/opt/victronenergy/dbus-serialbattery/bms/jkbms_brn.py", line 433, in connect_and_scrape
2023-11-17 17:36:02.459209500     asyncio.run(self.asy_connect_and_scrape())
2023-11-17 17:36:02.459214500   File "/usr/lib/python3.8/asyncio/runners.py", line 44, in run
2023-11-17 17:36:02.459217500     return loop.run_until_complete(main)
2023-11-17 17:36:02.459219500   File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
2023-11-17 17:36:02.459223500     return future.result()
2023-11-17 17:36:02.459255500   File "/opt/victronenergy/dbus-serialbattery/bms/jkbms_brn.py", line 443, in asy_connect_and_scrape
2023-11-17 17:36:02.459260500     client = BleakClient(self.address)
2023-11-17 17:36:02.459262500   File "/usr/lib/python3.8/site-packages/bleak/init.py", line 518, in init
2023-11-17 17:36:02.459265500     get_platform_client_backend_type() if backend is None else backend
2023-11-17 17:36:02.459269500   File "/usr/lib/python3.8/site-packages/bleak/backends/client.py", line 260, in get_platform_client_backend_type
2023-11-17 17:36:02.459327500     from bleak.backends.bluezdbus.client import BleakClientBlueZDBus
2023-11-17 17:36:02.459331500   File "/usr/lib/python3.8/site-packages/bleak/backends/bluezdbus/client.py", line 23, in
2023-11-17 17:36:02.459335500     from dbus_fast.aio import MessageBus
2023-11-17 17:36:02.459337500   File "/usr/lib/python3.8/site-packages/dbus_fast/init.py", line 1, in
2023-11-17 17:36:02.459380500     from . import introspection, message_bus, proxy_object, service
2023-11-17 17:36:02.459384500   File "/usr/lib/python3.8/site-packages/dbus_fast/introspection.py", line 5, in
2023-11-17 17:36:02.459388500     from .errors import InvalidIntrospectionError
2023-11-17 17:36:02.459391500   File "/usr/lib/python3.8/site-packages/dbus_fast/errors.py", line 57, in
2023-11-17 17:36:02.459394500     from .message import Message
2023-11-17 17:36:02.459508500   File "src/dbus_fast/message.py", line 3, in init dbus_fast.message
2023-11-17 17:36:02.459511500 ModuleNotFoundError: No module named 'dbus_fast._private.constants'
2023-11-17 17:36:11.759862500 ERROR:SerialBattery:No BMS found at C8:47:80:01:92:CE
2023-11-17 17:36:11.760646500 ERROR:SerialBattery:ERROR >>> No battery connection at Jkbms_Ble

Did you reboot after install, right?
Seems that dbus-fast is still missing. Try to install it manually and see if it throws an error.
export SKIP_CYTHON=false
pip3 install dbus-fast

Yeah, rebooted after every install and uninstall previously.
Last login: Fri Nov 17 17:46:24 2023 from <IP_ADDRESS>
root@einstein:~# export SKIP_CYTHON=false
root@einstein:~# pip3 install dbus-fast
Requirement already satisfied: dbus-fast in /usr/lib/python3.8/site-packages (2.14.0)
And still same errors on log.

export SKIP_CYTHON=false
pip3 install dbus-fast==1.91.3

Perfect! Now it works! Thank you very much!

This is very strange. Sometimes it works, sometimes it does not work with the current dbus-fast version...

Let me get back to the topic; I had to reinstall the new DBUS 2.14.0 because I found that ESS stopped functioning, not responding to commands like 'keep the battery charged' Hopefully, the RS485 - USB converters will arrive tomorrow, so I'll try connecting via cable to the new DBUS.
There was also an issue where one of the two BMS froze and stopped updating; Cerbo restarted twice overnight, I'm not sure why. Since I paused the driver, everything has been fine.

The cerbo most likely restarts because of overload, then the watchdog triggers a reboot.

Yes, I think so too because during Bluetooth communication between two BMSs, even the remote console was quite sluggish. Once the converters arrive, I'll try to set it up again, hoping it'll work better than the Bluetooth connection. I'll be connecting a total of 4 BMS.

So the converters arrived, I have it set up now in the classic way: BMS -> JK 485 adapter -> 485 to USB converter into the USB hub. After connecting and reinstalling the drivers on dbus-fast 2.14.0, nothing happened. I installed dbus-fast 1.91.3, reinstalled the driver again, and the BMS systems logged in. Then I installed dbus-fast 2.14.0, and the BMS systems are still connected. It looks like it's working. Rebooted after every install.

dbus-fast is not needed for the serial connection.

So I'm not sure why the BMS systems didn't log in right after installation and restart, but only after reinstalling to dbus-fast 1.91.3, but I don't have to worry about that now. The main thing is that it's working now. The rest of the cells should arrive within a month, so then I'll set up the driver to aggregate the batteries into one. Thanks for the support!

You're welcome.


Updated bottom section css

Updated services and aside div for better looks...
Review the above changes.

Thank you, I will try it out :) Sorry for the late response; been working on other projects lately.


Animation preveiw and edit in edit mode

How can I preview animations in edit mode? I have attached Simple Animation to game object and also have attached animation in this component. Unity Animation window not showing me any data.

For the moment, Unity itself doesn't offer any way to feed animation clips to the Animation Window other than putting them in a built-in component (Animation Component for Legacy clips, AnimatorController in an Animator), or putting them in a Timeline.
It's pretty unfortunate, but the simplest way to preview your clips is to drag them on the GO, but you'll need to discard the AnimatorController when you're done.
If you want to make it less error-prone, you can add call to
GetComponent<Animator>().runtimeAnimatorController = null;
in the Initialize() method of the component.
The possibility to feed clips in the Animation Window is on the list of customizability improvements we want to address in the near future.

While I understand the internal technical limitation, this kind of ruins the elegance of the SimpleAnimation component for me. The provided solution not only requires me to remember to set the AnimatorController back to "None", it also creates an AnimatorController object in my project that I need to delete—all to simply preview an animation.
It'd be great if we can give this more priority.

We rencently added an API to be able to feed clips to the Animation Window (IAnimationClipSource in 2018.3.0b1), so we just need to upgrade Simple Animation to implement this interface, and you'll be able to preview your clips properly.

That's fantastic news, thanks David!

@davidg-unity Is this repository actually likely to be updated again in the future? Because I have a bunch of bug reports from developing Animancer that are relevant to Simple Animation as well, I just hadn't posted anything here because the project seemed dead. The last commit was over 6 months ago now.

I think there's a huge need for something like this. If Unity aren't accepted PRs then someone should fork it.

I don't think forking it is necessarily the way to go, but rather starting from scratch with it as a reference and trying to actually make a better system instead of trying to replicate the old one and calling it good enough. From that perspective, this repo was doomed to stagnate right from the start. That's why I stopped posting issues here and made Animancer as a totally separate system to call my own. I'm more than happy to share my experiences with issues in the Playables API that will affect this system too, but there's no point if it's going to stay as dead as it has been.

@SilentSin It's not dead. I just have to balance putting time on this vs putting time on the main product (Unity). Since bugs in Unity can't really be addressed by anyone but us, they tend to take priority.
We've also been making changes to Unity to make Playables more convivial/efficient (IAnimationClipSource, performance improvements in Playables), which, while they were not made exclusively for SimpleAnimation, will directly benefit it.
Of course, I encourage you to make your own thing out of it, in any way, shape or form that you prefer. It was half of the reason why I've made this.
As for PlayablesAPI feedback/bugs, you should post them on the Unity forums, as there are more people to give you support there. There are multiple people working on/with Playables, but I am the only one on SimpleAnimation.


Remove esbuild from devDeps but keep testing in CI, fix #139

fix https://github.com/nuejs/nue/pull/139#issuecomment-1874938793
Below is output from  [[ git diff 16334eaa2250eb0f821319539d718436736e5164 4e0cb43b3abb83d09c6a92ab862a66fcb166b14d -- bun.lockb ]], ref: https://bun.sh/docs/install/lockfile
I can't prevent the unrelated version change (marked@^9.1.6), if you guys know how to improve pls tell me ;)
diff --git a/bun.lockb b/bun.lockb
index 3fce62c..38f7e48 100755
--- a/bun.lockb
+++ b/bun.lockb
@@ -1,123 +1,8 @@
 # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
 # yarn lockfile v1
-# bun ./bun.lockb --hash: 2CEF5A6DE7AD60F9-17c3d339555f4a51-36D751B931BC340D-779e4c6050698b75
+# bun ./bun.lockb --hash: DEEABC817505CDA6-f41a17c91aabae47-E5034553CF1C77BA-d5d19ed64226cf44

-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-FnzU0LyE3ySQk7UntJO4+qIiQgI7KoODnZg5xzXIrFJlKd2P2gwHsHY4927xj9y5PJmJSzULiUCWmv7iWnNa7g==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-5OVapq0ClabvKvQ58Bws8+wkLCV+Rxg7tUVbo9xu034Nm536QTII4YzhaFriQ7rMrorfnFKUsArD2lqKbFY4vw==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-aiu7K/5JnLj//KOnOfEZ0D90obUkRzDMyqd/wNAUQ34m4YUPVhRZpnqKV9uqDGxT7cToSDnIHsGooyIczu9T+Q==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-eccxjlfGw43WYoY9QgB82SgGgDbibcqyDTlk3l3C0jOVHKxrjdc9CTwDUQd0vkvYg5um0OH+GpxYvp39r+IPOg==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-ETp87DRWuSt9KdDVkqSoKoLFHYTrkyz2+65fj9nfXsaV3bMhTCjtQfw3y+um88vGRKRiF7erPrh/ZuIdLUIVxQ==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-fkFUiS6IUK9WYUO/+22omwetaSNl5/A8giXvQlcinLIjVkxwTLSktbF5f/kJMftM2MJp9+fXqZ5ezS7+SALp4g==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-lhoSp5K6bxKRNdXUtHoNc5HhbXVCS8V0iZmDvyWvYq9S5WSfTIHU2UGjcGt7UeS6iEYp9eeymIl5mJBn0yiuxA==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-JkUqn44AffGXitVI6/AbQdoYAq0TEullFdqcMY/PCUZ36xJ9ZJRtQabzMA+Vi7r78+25ZIBosLTOKnUXBSi1Kw==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-3CRkr9+vCV2XJbjwgzjPtO8T0SZUmRZla+UL1jw+XqHZPkPgZiyWvbDvl9rqAN8Zl7qJF0O/9ycMtjU67HN9/Q==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-LneLg3ypEeveBSMuoa0kwMpCGmpu8XQUh+mL8XXwoYZ6Be2qBnVtcDI5azSvh7vioMDhoJFZzp9GWp9IWpYoUg==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-caHy++CsD8Bgq2V5CodbJjFPEiDPq8JJmBdeyZ8GWVQMjRD0sU548nNdwPNvKjVpamYYVL40AORekgfIubwHoA==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-ppZSSLVpPrwHccvC6nQVZaSHlFsvCQyjnvirnVjbKSHuE5N24Yl8F3UwYUUR1UEPaFObGD2tSvVKbvR+uT1Nrg==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-B5x9j0OgjG+v1dF2DkH34lr+7Gmv0kzX6/V0afF41FkPMMqaQ77pH7CrhWeR22aEeHKaeZVtZ6yFwlxOKPVFyg==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-MHrZYLeCG8vXblMetWyttkdVRjQlQUb/oMgBNurVEnhj4YWOr4G5lmBfZjHYQHHN0g6yDmCAQRR8MUHldvvRDA==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-f3DY++t94uVg141dozDu4CCUkYW+09rWtaWfnb3bqe4w5NqmZd6nPVBm+qbz7WaHZCoqXqHz5p6CM6qv3qnSSQ==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-A5xdUoyWJHMMlcSMcPGVLzYzpcY8QP1RtYzX5/bS4dvjBGVxdhuiYyFwp7z74ocV7WDc0n1harxmpq2ePOjI0Q==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-grbyMlVCvJSfxFQUndw5mCtWs5LO1gUlwP4CDi4iJBbVpZcqLVT29FxgGuBJGSzyOxotFG4LoO5X+M1350zmPA==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-13jvrQZJc3P230OhU8xgwUnDeuC/9egsjTkXN49b3GcS5BKvJqZn86aGM8W9pd14Kd+u7HuFBMVtrNGhh6fHEQ==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-ysyOGZuTp6SNKPE11INDUeFVVQFrhcNDVUgSQVDzqsqX38DjhPEPATpid04LCoUr2WXhQTEZ8ct/EgJCUDpyNw==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-Hf+Sad9nVwvtxy4DXCZQqLpgmRTQqyFyhT3bZ4F2XlJCjxGmRFF0Shwn9rzhOYRB61w9VMXUkxlBy56dk9JJiQ==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-0P58Sbi0LctOMOQbpEOvOL44Ne0sqbS0XWHMvvrg6NE5jQ1xguCSSw9jQeUk2lfrXYsKDdOe6K+oZiwKPilYPQ==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-6YOrWS+sDJDmshdBIQU+Uoyh7pQKrdykdefC1avn76ss5c+RN6gut3LZA4E2cH5xUEp5/cA0+YxRaVtRAb0xBg==
-
-"<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-vfkhltrjCAb603XaFhqhAF4LGDi2M4OrCRrFusyQ+iTLQ/o60QQXxc9cZC/FFpihBI9N1Grn6SMKVJ4KP7Fuiw==
-
<EMAIL_ADDRESS>   version "2.0.1"
   resolved "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz"
@@ -163,35 +48,6<EMAIL_ADDRESS><EMAIL_ADDRESS>   resolved "https://registry.npmjs.org/entities/-/entities-4.5.0.tgz"
   integrity sha512-V0hjH4dGPh9Ao5p0MoRY6BVqtwCjhz6vI5LT8AJ55H+4g9/4vbHx1I54fS0XuclLhDHArPQCiMjDxjaL8fPxhw==

<EMAIL_ADDRESS>-  version "0.19.11"
-  resolved "https://registry.npmjs.org/esbuild/-/esbuild-0.19.11.tgz"
-  integrity sha512-HJ96Hev2hX/6i5cDVwcqiJBBtuo9+FeIJOtZ9W1kA5M6AMJRHUZlpYZ1/SbEwtO0ioNAW8rUooVpC/WehY2SfA==
-  optionalDependencies:
-    "@esbuild/aix-ppc64" "0.19.11"
-    "@esbuild/android-arm" "0.19.11"
-    "@esbuild/android-arm64" "0.19.11"
-    "@esbuild/android-x64" "0.19.11"
-    "@esbuild/darwin-arm64" "0.19.11"
-    "@esbuild/darwin-x64" "0.19.11"
-    "@esbuild/freebsd-arm64" "0.19.11"
-    "@esbuild/freebsd-x64" "0.19.11"
-    "@esbuild/linux-arm" "0.19.11"
-    "@esbuild/linux-arm64" "0.19.11"
-    "@esbuild/linux-ia32" "0.19.11"
-    "@esbuild/linux-loong64" "0.19.11"
-    "@esbuild/linux-mips64el" "0.19.11"
-    "@esbuild/linux-ppc64" "0.19.11"
-    "@esbuild/linux-riscv64" "0.19.11"
-    "@esbuild/linux-s390x" "0.19.11"
-    "@esbuild/linux-x64" "0.19.11"
-    "@esbuild/netbsd-x64" "0.19.11"
-    "@esbuild/openbsd-x64" "0.19.11"
-    "@esbuild/sunos-x64" "0.19.11"
-    "@esbuild/win32-arm64" "0.19.11"
-    "@esbuild/win32-ia32" "0.19.11"
-    "@esbuild/win32-x64" "0.19.11"
-
<EMAIL_ADDRESS>   version "9.0.0"
   resolved "https://registry.npmjs.org/htmlparser2/-/htmlparser2-9.0.0.tgz"
@@ -209,31 +65,13<EMAIL_ADDRESS>   dependencies:
     argparse "^2.0.1"

<EMAIL_ADDRESS><EMAIL_ADDRESS>   version "9.1.6"
   resolved "https://registry.npmjs.org/marked/-/marked-9.1.6.tgz"
   integrity sha512-jcByLnIFkd5gSXZmjNvS1TlmRhCXZjIzHYlaGkPlLIekG55JDR2Z4va9tZwCiP+/RDERiNhMOFu01xd6O5ct1Q==

<EMAIL_ADDRESS>-  version "0.3.0"
-  resolved "https://registry.npmjs.org/nuejs-core/-/nuejs-core-0.3.0.tgz"
-  integrity sha512-8RTa3Hz+tE9dfeBe01+oT6kKhknMmETTPc3Ap1tURCmzNdvXamUFbt2FNaHi1OBmGWk0i8FYKFvhj6ZtCSpO9Q==
-  dependencies:
-    htmlparser2 "^9.0.0"
-
-"nuejs-core@packages/nuejs":
+"nuejs-core@nuejs-core":
   version "workspace:packages/nuejs"
   resolved "workspace:packages/nuejs"
   dependencies:
     htmlparser2 "^9.0.0"
-
-"nuekit@packages/nuekit":
-  version "workspace:packages/nuekit"
-  resolved "workspace:packages/nuekit"
-  devDependencies:
-    esbuild "^0.19.11"
-  dependencies:
-    diff-dom "^5.0.6"
-    js-yaml "^4.1.0"
-    marked "^9.1.2"
-    nuejs-core "^0.3.0"

Great job!
Btw: I just noticed the "Checks" tabs on this commit. I haven't used this kind of CI- flow in the past. Looks solid. Is .github/workflows/test.yaml enough to enable continuous integration?
Also, I'm not familiar with these pnpm/bun lock files. Can you explain them to me (like I was 10 years old) and what should I do about them?

Btw: I just noticed the "Checks" tabs on this commit. I haven't used this kind of CI- flow in the past. Looks solid. Is .github/workflows/test.yaml enough to enable continuous integration?

The CI / CD can include many things, for example:

Testing on different OS and platforms
Testing coverage and SVG badge
Releasing and npm-publish
Deploying to gh-pages

But according to nuejs CONTRIBUTING.md , I'm not sure which of them you want for it, for keeping its simplicity (I love simplicity too 😂 )

We might need to circle back and decide on a policy  for bun.locb file. I've not used bun before but the fact that it's binary creates some obvious issues. For the short term perhaps just add it to .gitignore and at a later stage include a human friendly version as well, or ... discuss the options for doing so. So that if something breaks the builds due to transitive dependancy we're equipped to identify the specific package and manually add a specific frozen version to to package.json, if and when that ever happens.

Configure git to show the diff & other details like clear text lock-files:
https://bun.sh/docs/install/lockfile (details, git, etc.)
https://bun.sh/guides/install/yarnlock (additional human-readable file (also included above to some extent))

Also see this comments here:
https://github.com/nuejs/nue/pull/150#issuecomment-1875224333 (general comment)
https://github.com/nuejs/nue/pull/150#issuecomment-1875262328 (concerns)
https://github.com/nuejs/nue/pull/150#issuecomment-1919982493 (fast installs)

But I can also see your concerns regarding new developers and binary lock-files in general.
Maybe we could add to the developer guidelines, that the lock file should be used for installation (, also in tests on this end)? The lock-file would have to be updated now and then in this case.
bun install --frozen-lockfile`
Just thinking aloud...

@nobkd To solve the problem of "least suprise" it would also be quite ok to simply also check in the lock file, assuming that if I run a build bun would generate the same deterministic binary lockfile. easy enough to test; if that works that also makes the scary "why am i suddenly seeing a changed file that should be under source control" warning.
i.e. I should have mentioned above another simple solution is also to just check the file in to source control.
Thanks for the links to #150 those were quite helpful. Bun looks quite smart, and I can totally understand why the build is so much faster, makes sense when you read the explanations.

@goblinfactory let's talk about this tomorrow!


Tweaked toggleActive a bit

applied yeoman template
removed listener (no need to use both context & listener at the same time?)
events are now live within context (support dynamically added toggles - for ex. report form toggle in profile lightbox in Community)

Looks good, I'll definitely give it a test in a few apps first though.

Mobile primary nav: :-1:
Mobile secondary nav: :+1:
TTD filters dropdown: :+1:
TTD gallery expand: :+1:

Mobile primary nav :+1:


surface() causes kernel to die

In exercise 6, the plotting exercise suggests running surface(). This causes the kernel to die on my laptop without a good error message.
I should investigate this.

for what is worth, it works for me (julia 1.6.0) with both gr and plotlyjs backend.

Also works for me after updating to 1.6.0. Closing this now but I need to keep this in mind.


Review miden::sat::internal::* modules and procedures

We should review procedures in miden::sat::interal::* modules to asses if we should transfer procedures from internal scope to the public facing interface (midne::sat::*).

Closing this as obsolete.


Retire the docker.io/istionightly images

These haven't been updated in 4+ months, and we have a much better
process for releasing images now. As such, we don't need istionightly.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-simpleTests-distroless_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test e2e-simpleTests-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-simpleTests-distroless_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test e2e-simpleTests-distroless_istio

pilot-multicluster-e2e_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-simpleTests-distroless_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test e2e-simpleTests-distroless_istio

pilot-multicluster-e2e_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-multicluster-e2e_istio

integ-new-install-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-simpleTests-distroless_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test e2e-simpleTests-distroless_istio

pilot-multicluster-e2e_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-multicluster-e2e_istio

integ-new-install-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test gencheck_istio

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-simpleTests-distroless_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test e2e-simpleTests-distroless_istio

pilot-multicluster-e2e_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-multicluster-e2e_istio

integ-new-install-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Loads of work needs to be done with the test cases as they compile docker files.  This is lower priority then 1.4, so I will park this PR for now and return to it later.
Cheers
-steve

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

release-test_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test release-test_istio

integ-security-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-local-tests_istio

integ-pilot-local-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-local-tests_istio

pilot-multicluster-e2e_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test pilot-multicluster-e2e_istio

integ-new-install-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-pilot-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
ac1c782e78e98b55e98d5b2cefb5ba623c8c9da8
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
1c157c39f779c1b62c7d59b88566fbf4c767c3e3
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
ac1c782e78e98b55e98d5b2cefb5ba623c8c9da8
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
ac1c782e78e98b55e98d5b2cefb5ba623c8c9da8
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
ac1c782e78e98b55e98d5b2cefb5ba623c8c9da8
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
ac1c782e78e98b55e98d5b2cefb5ba623c8c9da8
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
ac1c782e78e98b55e98d5b2cefb5ba623c8c9da8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


APEXMALHAR-2330 JdbcPOJOPollInputOperator fails with NullPointerExcep…

Problem:
JdbcPOJOPollInputOperator fails with NullPointerException using PostgreSQL driver.
Problem Description:

When JdbcPOJOPollInputOperator tries to populateColumnDataTypes, column names retrieved from resultmetadata from database ( this case : Postgres) are all lowercase.
Whereas columnDatatypes specified in fieldinfos might be in same case.
Internally hashmap ( nameToType) is used which mismatches if column name and fieldinfo are not in same case. Hence columnDataTypes is empty which causes null exception in activate call.

Solution:
Using similar case for hashmap and column names irrespective of any database used for JdbcPOJOPollInputOperator.
Testing:
Tested with Database-to-hdfs app also with instrumented logs.

@devtagare and @DT-Priyanka , As I could't find the embedded PostgreSQL driver. Hence cannot add on to same test cases. Will try Priyanka's suggestion using Mock.

APEXMALHAR-2349 is opened to track the Mocking entire PostgreSQL database connection. As embedded drivers so far are unavailable.

I am okay to go ahead with merge as you have created new JIRA to create tests.

can you please rebase so that I can merge it?

Done with rebase.


global metrics should be ot-rounded before computing deltas in order to match fontmake

take https://github.com/SorkinType/Gelasio/tree/main/sources/Gelasio.glyphspackage and run through ttx_diff.py
You'll notice MVAR has one delta related to "stro" tag (strikeout offset or position) which differs by 1 unit when compared with fontmake's
--- /Users/clupo/oss/fontc/build/default/fontc.MVAR.ttx	2024-10-16 12:21:15
+++ /Users/clupo/oss/fontc/build/default/fontmake.MVAR.ttx	2024-10-16 12:21:15
@@ -22,7 +22,7 @@
         <NumShorts value="0"/>
         <!-- VarRegionCount=1 -->
         <VarRegionIndex index="0" value="0"/>
-        <Item index="0" value="[5]"/>
+        <Item index="0" value="[4]"/>
         <Item index="1" value="[8]"/>
       </VarData>
     </VarStore>
\ No newline at end of file

The reason for this is that fontmake builds TTFs for each master and then uses varLib to build MVAR among other tables, and the global metrics values as stored in the master TTFs are already rounded to integers (using otRound) so the input to varLib are ot-rounded integers, not floats.
Whereas fontc keeps the global metrics value as floats (the sources allow to store these as floats even though basically all these metrics are going to end up being rounded to int16 or uint16 when serialised to OpenType) and then it generates the deltas from these float metrics, and only at the end it ot-rounds the deltas themselves.
In this particular case, Gelasio doesn't actually contain floats for strikeout offset; in fact it doesn't specify any strikeout offset, so it is the GlobalMetrics::populate_defaults() method that is introducing the floats, here:
https://github.com/googlefonts/fontc/blob/37143a0c39535aaf8eaa42be53fa028bd6746cc3/fontir/src/ir.rs#L698-L701
Now, in order to match fontmake we could either

change ir::GlobalMetrics so that it stores integer values instead of f64, and do an ot_round() for all incoming values (from any frontends, not just glyphs or ufo) as soon as they get set, eg

- HashMap<GlobalMetric, HashMap<NormalizedLocation, OrderedFloat<f64>>>
+ HashMap<GlobalMetric, HashMap<NormalizedLocation, i32>>

keep f64 in GlobalMetrics and only perform to ot_round() only for the global metrics values that come from glyphs and ufo sources (not any frontends), be them user-defined or those introduced by the populate_defaults() method; this way we would match fontmake for .glyphs and DS+ufo sources, but not also force other frontends to round global metrics sources before deltas get computed.

Ok so, I tried to see if I could instead make so that ufo2ft and fonttools did not round the global metrics master values before computing the deltas, but nothing actually changed, I was still seeing the same diff.
it turns out the issue was not that fontc doesn't round before computing deltas... but rather that fonttools does the rounding within the delta computation itself, see https://github.com/fonttools/fonttools/issues/2213

This allows for rounding error from one set of deltas to be accounted for when computing subsequent deltas, reducing the total error from accumulating unbounded as number of masters grows, to always being limited to 0.5.

So this is the same as https://github.com/googlefonts/fontc/issues/235
If I apply the following patch, then ttx_diff.py for Gelasio.glyphspackage yields identical outputs for MVAR.
diff --git a/fontir/src/variations.rs b/fontir/src/variations.rs
index ff43b3a5..49b94046 100644
--- a/fontir/src/variations.rs
+++ b/fontir/src/variations.rs
@@ -21,6 +21,24 @@ use write_fonts::{

 use crate::error::VariationModelError;

+trait BankerRound<U, T = Self> {
+    fn banker_round(self) -> U;
+}
+
+impl BankerRound<f64> for f64 {
+    #[inline]
+    fn banker_round(self) -> f64 {
+        self.round_ties_even()
+    }
+}
+
+impl BankerRound<kurbo::Vec2> for kurbo::Vec2 {
+    #[inline]
+    fn banker_round(self) -> kurbo::Vec2 {
+        kurbo::Vec2::new(self.x.round_ties_even(), self.y.round_ties_even())
+    }
+}
+
 const ZERO: OrderedFloat<f32> = OrderedFloat(0.0);
 const ONE: OrderedFloat<f32> = OrderedFloat(1.0);

@@ -171,7 +189,7 @@ impl VariationModel {
     ) -> Result<Vec<(VariationRegion, Vec<V>)>, DeltaError>
     where
         P: Copy + Default + Sub<P, Output = V>,
-        V: Copy + Mul<f64, Output = V> + Sub<V, Output = V>,
+        V: Copy + Mul<f64, Output = V> + Sub<V, Output = V> + BankerRound<V>,
     {
         if point_seqs.is_empty() {
             return Ok(Vec::new());
@@ -234,7 +252,8 @@ impl VariationModel {
                         })
                         .fold(initial_vector, |acc, (other, other_weight)| {
                             acc - *other * other_weight.into()
-                        }),
+                        })
+                        .banker_round(),
                 );
             }
             model_idx_to_result_idx.insert(model_idx, result.len());

Fixed by #1070

PR #1070 only really fixed #235 as we are now correctly rounding deltas as they get computed. However that hasn't technically also fixed this issue, because fontc still passes float master values to VariationModel for some stuff for which fontmake instead passes already-rounded integers.
It's not just global font metrics (e.g. stroke offset in Gelasio MVAR). I am now noticing seeing other off-by-one diffs elsewhere which I think are related and haven't been fixed by #1070 (some have surfaced after that).
For example, fontc_crater reports that after #1070 got merged, the GDEF table diff in https://github.com/chankfonts/Teachers-fonts got -26.929% worse off.

I tracked this down to the fact that there's a composite glyph "ordfeminine" which contains a transformed component "a" scaled by 0.75. The composite inherits anchors from the component via propagate_anchors.rs, and the anchors (x,y) positions are passed on as floats by fontc to its VariationModel, whereas fontmake (ufo2ft's markFeatureWriter) is rounding them off (via otRound) before computing the deltas.
I subsetted the source file to only contain the minimal reproducer, three glyphs "a", "ordfeminine" (and "acutecomb" to trigger mark feature), here's the test file: Teachers-Italic.glyphs.zip
This is how the propagated "top" base anchor appear in fontc' build/anchor_ir/ordfeminine.yml (note how the values are un-rounded floats):
glyph_name: ordfeminine
anchors:
- kind: !Base top
  positions:
    ? - - wght
        - 0.0
    : x: 282.75
      y: 691.25
    ? - - wght
        - 1.0
    : x: 291.75
      y: 689.5
    ? - - wght
        - 0.75
    : x: 289.5
      y: 689.5

... whereas this is the ufo2ft-generated build/default/debug.fea where you can see the same anchor's master values rounded off (this become the input to feaLib to build the variable GPOS/GDEF):
feature mark {
    lookup mark2base {
        pos base ordfeminine
            <anchor (wght=400:283 wght=700:290 wght=800:292) (wght=400:691 wght=700:690 wght=800:690)> mark @MC_top;
    } mark2base;
} mark;

The rounding (otRound) appears to be performed in ufo2ft markFeatureWriter (not in glypshLib propagate_anchors.py) when the anchors are serialized to FEA ast:
https://github.com/googlefonts/ufo2ft/blob/d15ef8f6f235804733c6e2ea5f01f39aafb92f45/Lib/ufo2ft/featureWriters/markFeatureWriter.py#L37-L38
If I apply the following patch to fontbe/src/features/marks.rs so that the anchors get rounded before being sent to the VariationModel for computing deltas, then I get back to zero diff in Teachers-Italic's GPOS/GDEF (not just the subsetted test font but the whole source as well):
diff --git a/fontbe/src/features/marks.rs b/fontbe/src/features/marks.rs
index cc5d4bd3..b49ae3d4 100644
--- a/fontbe/src/features/marks.rs
+++ b/fontbe/src/features/marks.rs
@@ -600,9 +600,11 @@ fn resolve_anchor_once(
         .positions
         .iter()
         .map(|(loc, pt)| {
+            let x: i16 = pt.x.ot_round();
+            let y: i16 = pt.y.ot_round();
             (
-                (loc.clone(), OrderedFloat::from(pt.x as f32)),
-                (loc.clone(), OrderedFloat::from(pt.y as f32)),
+                (loc.clone(), OrderedFloat::from(x as f32)),
+                (loc.clone(), OrderedFloat::from(y as f32)),
             )
         })
         .unzip();

oh, it looks like also master glyph coordinates get otRounded in fonttools before being sent off to VariationModel, see:
https://github.com/fonttools/fonttools/blob/7a0062a718e33cf4900e1a5b005c9b649ea6d964/Lib/fontTools/varLib/__init__.py#L319-L322
https://github.com/fonttools/fonttools/blob/7a0062a718e33cf4900e1a5b005c9b649ea6d964/Lib/fontTools/ttLib/tables/_g_l_y_f.py#L389
Whereas fontc is not doing the same as far as I can tell:
https://github.com/googlefonts/fontc/blob/fd1fc6ab8e3a724d24b4672364a87129e85c3250/fontbe/src/glyphs.rs#L226
That may account for additional diffs in gvar..

Same thing for HVAR: fontc is not rounding the advance widths before passing them on to VariationModel to compute the deltas, whereas fonttools always works with rounded values (the master TTFs' hmtx tables).
This probably surfaces less often because, although source formats allow witdhs to be either integers or floats, font developers don't actually set the glyph widths to floats. Maybe only when a master was in turn an interpolated instance re-inserted as a master.

it looks like also master glyph coordinates get otRounded in fonttools ... Whereas fontc is not doing the same as far as I can tell

self-correction. fontc is already rounding the glyph coordinates before computing deltas, because it first converts the IR's BezPaths into interpolatable write_fonts::SimpleGlyphs (which internally use i16 for x and y coordinates, otRounded) and then it extracts lists of kurbo::Points, which internally use f64, to send off to VariationModel for delta computation. So we're good as far as rounding for the glyph outlines and the respective variations.

for reference, this is where master values for anchor positions get otRounded in ufo2ft featureWriters, when the VariableScalar is constructed:
https://github.com/googlefonts/ufo2ft/blob/d15ef8f6f235804733c6e2ea5f01f39aafb92f45/Lib/ufo2ft/featureWriters/baseFeatureWriter.py#L431-L432
kerning values are "quantized" to 1 by default (which simply means otRound'ed) here:
https://github.com/googlefonts/ufo2ft/blob/d15ef8f6f235804733c6e2ea5f01f39aafb92f45/Lib/ufo2ft/featureWriters/kernFeatureWriter.py#L515
https://github.com/googlefonts/ufo2ft/blob/d15ef8f6f235804733c6e2ea5f01f39aafb92f45/Lib/ufo2ft/util.py#L573


Card Settings - Rename PaymentsPage to WalletPage

Details

Part of Card Settings Project (Wave 8) we are renaming the Payments pages to Wallet
Fixed Issues

$ https://github.com/Expensify/App/issues/22870
Tests

[ ] Verify that no errors appear in the JS console

[ ] Open the settings page /settings/

[ ] Note "Wallet" Menu Item.
[ ] Ensure clicking on "Wallet" opens  /settings/wallet
[ ] Ensure that title of page at /settings/wallet is "Wallet"

[ ] Open the wallet page /settings/wallet

[ ] Click on the Add Payment Method button

[ ] Click on Bank Account, ensure that route is settings/wallet/add-bank-account
[ ] Click on Debit Card, ensure that route is settings/wallet/add-debit-card
[ ] Click on Paypal.me, ensure that route is settings/wallet/add-paypal-me

Alternatively, open each of the following routes and ensure that page properly loads:

[ ] http://localhost:8082/settings/wallet
[ ] http://localhost:8082/settings/wallet/add-bank-account
[ ] http://localhost:8082/settings/wallet/add-bank-account
[ ] http://localhost:8082/settings/wallet/add-paypal-me
[ ] http://localhost:8082/settings/wallet/enable-payments
[ ] http://localhost:8082/settings/wallet/transfer-balance
[ ] http://localhost:8082/settings/wallet/choose-transfer-account

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

Open each of the following routes:

[ ] https://staging.new.expensify.com/settings/

[ ]  Ensure that there is a "Wallet" option

[ ] https://staging.new.expensify.com/settings/wallet

[ ]   Ensure that the title of the page is "Wallet"

Ensure each of these routes loads:

[ ] https://staging.new.expensify.com/settings/wallet/add-bank-account
[ ] https://staging.new.expensify.com/settings/wallet/add-bank-account
[ ] https://staging.new.expensify.com/settings/wallet/add-paypal-me
[ ] https://staging.new.expensify.com/settings/wallet/enable-payments
[ ] https://staging.new.expensify.com/settings/wallet/transfer-balance
[ ] https://staging.new.expensify.com/settings/wallet/choose-transfer-account

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/38015950/6bfd4803-e444-4759-82c1-f7d284b093b1

Mobile Web - Chrome

Chrome emulator won't connect to wifi

Mobile Web - Safari

https://github.com/Expensify/App/assets/38015950/5064f2a1-ad3e-4f75-a909-f4a595c3d735

Desktop

https://github.com/Expensify/App/assets/38015950/e99f0612-fa8d-40bb-8db7-908ef2597b83

iOS

https://github.com/Expensify/App/assets/38015950/7f9ce0c8-4024-4be9-80cd-ee68106153fd

Android

https://github.com/Expensify/App/assets/38015950/8d400052-e088-45b3-807a-666a94c15862

Alright new PR is up if you can prioritize this one today to prevent merge conflicts, that would be great @allroundexperts ! If not let me know so I can have an internal engineer do the review

Also heads up, I noticed that for the add bank account page, http://localhost:8082/settings/wallet/add-bank-account   the plaid modal  is loading very slowly on main too

@allroundexperts any updates on review?

@allroundexperts I apologize, I was working on an urgent issue this morning. Looking now

The transfer page works fine for me, I think you need a specific beta for wallet transfers? I'll update that copy now

pushed copy changes @allroundexperts

what in the world keeps getting updated in these files

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.56-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@grgia @allroundexperts
Hello
Should a Debit card be present in a gmail account?


[Bug]: Add responsiveness to whole website

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
make the website responsive to mobile view
(You can raise pr for every page ex: listing view page, home page, login/signup page)
Expected behavior
make whole website responsive
Add ScreenShots
No response
On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[ ] I'm a GSSOC'24 contributor
[X] I have starred the repository

I’m already working on adding customized pages to the footer quick links. Could you please assign this issue to me?


the css styling for welcome page and questions has been updated

merging new CSS updates into feature answer picking


possible memory leak in async c++ client.

What version of gRPC and what language are you using?
grpc 1.21.x     c++
What operating system (Linux, Windows,...) and version?
Windows 10pro 1903
What runtime / compiler are you using (e.g. python version or version of gcc)
Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24215.1 for x86
What did you do?
I build a broadcasting model where A is the proxy server(asynchronous) accepting requests from clients, and broadcast requests to B & C where B & C are simple ping-pong server:
              Client
                  |
                 A
               /    \
             /       \
            B        C

What did you expect to see?
Memory usage of A is reasonable.
What did you see instead?
Memory usage of A keeps increasing about 5m~9m for each 40k requests.
The A 's code is here.
Anything else we should know about your project / environment?
If I comment out the broadcasting logic, it recovers to normal level. So there must be something wrong with the broadcasting logic, but I cannot find anything abnormal.

Do you have a memory profile or something to show what is being used?
I think there is an error in https://gist.github.com/ppLorins/942874631457a7f982411ea0f2b60048#file-proxy_adventurer-cc-L238 as well, since at this point the server call data may have already been destroyed.

I did the experiment again and got some snapshots, visual studio cannot export the result as excels or something, so there is only snapshots...
This is the memory gain after did sending 40k requests to the serverA:

This is the memory gain details in vs diagnostic tool which is informative :

This is the result of expanding "ucrtbased.dll!_CrtMemBolckHeader":

Yes. There is the problem that call data may have already been destroyed, I'll fix it later.  But it rarely happened and has no effect on our problem.

Forget the grpc_1.8.x_svr.... , it's actually 1.21.x.

I am not sure there is a problem here.
I can imagine this is caused by some memory allocator implementation details like holding the released memory in a pool rather than returning back to the system.
Also grpc may have some global cache of commonly used strings etc which may be the source of last picture. (Note it is from registering a call on a channel).
A better way to test the memory usage might be either giving it a larger flow of traffic and compare the peak memory usage and after the peak. Or you can give the server a constant flow of traffic to see the memory does not go up unbounded.

I'll try it later.

@yang-g
I've tried both the methods, here are the result:
Method1
I gave a large flow to the server, and the memory usage is like this:

4.9MB (before receiving large flow requests)
187.7MB(peak)
17.4MB(after memory stable)
Method2
I continuously give a moderate traffic flow to the server, observed it's memory usage continue increasing, finally hit the 2GB memory usage limit for a 32-bit program on window.  I think this can demonstrate that it'll go up unbounded, and it's still unreasonable to use 2GB memory even if it's not.
Anyone who even report this before?  If this is a bug, I can hardly believe that I'm the first one who encountered this.

I have the same issue with async client on linux, the memory go up until 16 GB RAM.

I have the same issue with async client on linux, but not issue with sync client on linux.

I think what you are interested in here is the ResourceQuota which allows you to set the amount of memory gRPC uses for a channel or a server.
Please look at SetResourceQuota() https://github.com/grpc/grpc/blob/cc4017255d3e1685344e6ef853f38ed7a733b3e1/include/grpcpp/support/channel_arguments_impl.h#L90
Also, the nature of the issue seems to be a question that the wider community would have probably answered faster. Please redirect questions to https://groups.google.com/g/grpc-io


[TASK] Release v1.1.2

What's the task? Please describe.
Action items for releasing v1.1.2
Describe the items of the task (DoD, definition of done) you'd like.

[x] release GA draft w/ all images built, repo tags, chart PR - @innobead
[x] verify GA draft

[x] run automatic e2e regression @meldafrawi
[x] some mandatory manual regression: longhorn/chart PR install, upgrade) - @khushboo-rancher

[x] release (longhorn/longhorn, longhorn/chart, longhorn/website) and make sure doc links correctly in the release note - @innobead
[x] merge the release branch to master (longhorn/longhorn, longhorn/website) - @innobead
[x] have rancher chart PRs (cluster explorer 2.5, 2.6, and cluster manager) and image mirror @shuo-wu

[x] rancher/image-mirrors update - @shuo-wu  (ex: https://github.com/rancher/image-mirror/pull/95)
[x] rancher/charts master branch for cluster manager - @shuo-wu (ex: https://github.com/rancher/charts/pull/1143)
[x] rancher/charts dev-* branches for cluster explorer - @shuo-wu   (ex: https://github.com/rancher/charts/pull/1144)
[x] verify the chart being able to install & upgrade - @khushboo-rancher

Additional context
N/A
cc @khushboo-rancher @meldafrawi @kaxing

To make sure the draft chart ready before release, we need to do a quick sanity check for auto and manual.

@meldafrawi please help run the core test for https://github.com/longhorn/longhorn/tree/v1.1.2 (using v1.1.2).
@khushboo-rancher please help do the manual regression (sanity test) against https://github.com/longhorn/charts/pull/14 to see if the installation and upgrade working fine.

After finishing, please :heavy_check_mark:  the checkbox in the ticket description. Thanks.
cc @kaxing

@shuo-wu Please help rancher/charts and image mirrors tasks after 1.1.2 release out.

All PRs ready, just wait for merging.

Do you have an estimate of wehn this will make it to v2.5 for use via clsuter explorer? I am itching to use 1.1.2.

Do you have an estimate of wehn this will make it to v2.5 for use via clsuter explorer? I am itching to use 1.1.2.

ref: https://github.com/rancher/charts/issues/1352#issuecomment-887999551
For the chart released in cluster explorer, as per the reference, it will be released together with the next release of Rancher. It should be 2.6.0 and 2.5.10 soon or later.

@innobead Thank you. I was wondering how the charts mapped to rancher releases. That is very helpful to know.


Python Documentation

Expected Behavior

Python documentation in the style of https://www.quantconnect.com/lean/docs.
Actual Behavior

Documentation only exists for general usage (https://www.quantconnect.com/docs/home/home) as opposed to outlining individual module elements/classes and their members like in the C# documentation.
Potential Solution

With Lean/Algorithm.Python/stubs/QuantConnect now added, docstrings already used there can be used as a starting point for Sphinx styled documentation (of course, "styled" given that the stubs are not the source - nonetheless, having a searchable documentation for the module element names and their docstrings would help). Should your namespace work properly (e.g., with no import errors due to a non-sane pythonnet install), following https://matplotlib.org/sampledoc/ should quickly produce a sample.
Reproducing the Problem

System Information

Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

@aarjaneiro, QuantConnect has a repo for Documentation (and, by the way, Tutorials). Please contact support  or QuantConnect at Slack before openning issues in this repo if you are not sure it belongs here.
That said, we have been working on new documentation: https://github.com/QuantConnect/Documentation/pull/335.


/QuestLore

Add sand must flow to quest lore.

also should be in agni

Going to close this in the hope it was fixed, since it has been 7 months.


Can't use Lilygo T4-S3

I just bought a LilyGO T4-S3 and I've followed all the steps described to make it work. I tried on two computers and reinstalled Arduino IDE, but it still doesn't work. Once I complete the installation, I run the examples (lvgl get started, adjust brightness, etc.), but the screen is black. I've also tried to run the code "T4AMOLEDui-main" and it doesn't work. The screen is still black and it says ESP32TIME.h doesn't exist. So I tried to do a factory reset by installing the firmware, and then the factory program works fine. Can someone help me?
Thanks

ESP32TIME.h ? This library does not depend on this library file. Which example did you write? Adjust Core Debug Level to Debug and provide me with the log output.

I ran the TFT_eSPI_Sprite_graphicstest_small.ino example. it says "The current arduino version of TFT_eSPI does not support arduino 3.0, please change the version to below 3.0". how can i do that?

Please refer to step 4 in README. This library has requirements for esp32 version.

 Anyway thank you for your help.


Questions about noise budget

Hi,
First of all, thanks for building and sharing the awesome project!
I used the following code to set up the SEAL context. IIUC from the tutorials, the fresh ciphertext should have roughly 218-40=178 bit noise budget. But turned out there's only 127 bits. The gap was a bit larger than I expected. Is this totally normal or am I doing anything wrong?
Thanks,
Aaron
`
size_t poly_modulus_degree = 8192;
uint64_t plain_modulus =<PHONE_NUMBER>49;

EncryptionParameters parms(scheme_type::BFV);
parms.set_poly_modulus_degree(poly_modulus_degree);
parms.set_coeff_modulus(CoeffModulus::BFVDefault(poly_modulus_degree)); // 127
parms.set_plain_modulus(plain_modulus);

auto context = SEALContext::Create(parms);
KeyGenerator keygen(context);
auto public_key = keygen.public_key();
auto secret_key = keygen.secret_key();
auto relin_keys = keygen.relin_keys_local();

Encryptor encryptor(context, public_key);
Decryptor decryptor(context, secret_key);
BatchEncoder batchEncoder(context);
Evaluator evaluator(context);

vector<size_t> data {5, 3};
Plaintext temp;
batchEncoder.encode(data, temp);
Ciphertext dataE;
encryptor.encrypt(temp, dataE);

`

I tested the same setting in SEAL version 3.2.1 for comparison and the budget was 167. What could contribute to the difference, the underlying encryption scheme implementation or just how the budget was calculated?
/ Encryption parameters:
| scheme: BFV
| poly_modulus_degree: 8192
| coeff_modulus size: 218 bits
| plain_modulus:<PHONE_NUMBER>49
\ noise_standard_deviation: 3.2

Encoded 5 as polynomial 1x^2 + 1 (plain1)
Encoded -7 as polynomial 800080C000x^2 + 800080C000x^1 + 800080C000 (plain2)
Encrypting plain1: Done (encrypted1)
Encrypting plain2: Done (encrypted2)
Noise budget in encrypted1: 167 bits
Noise budget in encrypted2: 167 bits
Noise budget in -encrypted1: 167 bits

Since version 3.3, we introduced a new noise reduction mechanism to key switching where the last element/prime in EncryptionParameters::coeff_modulus() is dedicated for this purpose (excluded from noise budget). When poly_modulus_degree is 8192 and BFV default coeff_modulus is used, the last element/prime is 44-bit. Since you choose the plain_modulus to be 40-bit. The maximum noise budget you can get is 218 - 44 - 40 = 134 bits.
Then you need to consider the noise in a fresh encryption. We applied a method that uses the last prime to reduce the noise in a fresh encryption. The noise used to be 10-20 bits but now less than 10 bits. So substracting this noise from the 134-bit maximum budget, 127 seems right.

This is great information to have. A few questions:

Can I turn off the use of the last moduli as key switching resource?

Explicitly, say for 12, 13, 14 and 16 bit values of N in x^N+1 how much saving is there for rotations and relinearization? Because, I might be willing to pay that cost if my circuit depth gives me more budget than the current default setup.

Thanks for the great explanation, @WeiDaiWD ! It makes much sense.
I used the following code to test the depth for both version.
The results for 3.2.1 version is
[ RUN      ] SealBenchmark.CiphetextMultNoiseBudget 167 113 60 5 0 [       OK ] SealBenchmark.CiphetextMultNoiseBudget (1215 ms)
The results for 3.5.6 version is
[ RUN      ] SealBenchmark.CiphetextMultNoiseBudget 127 76 24 0 0 [       OK ] SealBenchmark.CiphetextMultNoiseBudget (286 ms)
Based on that, it seems a pair of ciphertext multiplication and relinearization consumes roughly the same amount noise budget between two versions. And due to the different initial budget, it seems the 3.2.1 implementation can support deeper circuits with the same set of params. On the flip side, the 3.5 impl is roughly 3 times more efficient than 3.2.1. Would appreciate your insights on this tradeoff.
`
size_t poly_modulus_degree = 8192;
uint64_t plain_modulus =<PHONE_NUMBER>49;
EncryptionParameters parms(scheme_type::BFV);
parms.set_poly_modulus_degree(poly_modulus_degree);
parms.set_coeff_modulus(DefaultParams::coeff_modulus_128(poly_modulus_degree));
// parms.set_coeff_modulus(CoeffModulus::BFVDefault(poly_modulus_degree));
parms.set_plain_modulus(plain_modulus);

auto context = SEALContext::Create(parms);
KeyGenerator keygen(context);
auto public_key = keygen.public_key();
auto secret_key = keygen.secret_key();
auto relin_keys = keygen.relin_keys(60);
// auto relin_keys = keygen.relin_keys_local();

Encryptor encryptor(context, public_key);
Decryptor decryptor(context, secret_key);
BatchEncoder batchEncoder(context);
Evaluator evaluator(context);
IntegerEncoder encoder(context);

vector<uint64_t> data(8192, 2);
Plaintext temp;
batchEncoder.encode(data, temp);
Ciphertext dataE;
encryptor.encrypt(temp, dataE);
cout << decryptor.invariant_noise_budget(dataE) << endl;

evaluator.square_inplace(dataE);
evaluator.relinearize_inplace(dataE, relin_keys);
cout << decryptor.invariant_noise_budget(dataE) << endl;

evaluator.square_inplace(dataE);
evaluator.relinearize_inplace(dataE, relin_keys);
cout << decryptor.invariant_noise_budget(dataE) << endl;

evaluator.square_inplace(dataE);
evaluator.relinearize_inplace(dataE, relin_keys);
cout << decryptor.invariant_noise_budget(dataE) << endl;

evaluator.square_inplace(dataE);
evaluator.relinearize_inplace(dataE, relin_keys);
cout << decryptor.invariant_noise_budget(dataE) << endl;

`

In version 3.2.1, the first relinearization should have very large impact on noise growth, which is not obvious because plain_modulus is very large. I ran your program with plain_modulus = 1032193 and here are the noise budget sequences.
[3.2.1] 186 132  94  57  17
[3.5.6] 146 114  81  48  16

The size of plain_modulus contributes to the noise growth of ciphertext multiplication. The larger noise growth of ciphertext multiplication and relinearization dominates. You can see the noise budgets after 4 squares are almost the same in both versions. The first squaring and relinearization has very different noise growth. This pattern also applies to rotation.
You might also want to use degree 16384 with one more prime than BFVDefault(8192) in 3.5.0 if a 40-bit plain_modulus is truly necessary. The performance won't be too much worse than 3.2.1.

@ReverseControl

Can I turn off the use of the last moduli as key switching resource?

It requires a lot of modification to do that. We might add a on/off switch in a future release.

Explicitly, say for 12, 13, 14 and 16 bit values of N in x^N+1 how much saving is there for rotations and relinearization? Because, I might be willing to pay that cost if my circuit depth gives me more budget than the current default setup.

With a reasonable choice of parameters, the difference of supported depth is less than 1. The saving is more significant to the first rotation or relinearization. You can perform relinearization and rotation whenever you want without worrying about noise growth in 3.5.x, while you want to delay those operations if you use 3.2.1.

Thanks a lot @WeiDaiWD ! Your comments are truly helpful.
As all the questions are addressed, close the issue.


Don't use Dagger to provide TransactionManager

This change is

Closing pull request -- we don't think this actually addresses any real issue.


[EASI-2521] Discussion and Discussion Reply return user info full stack

EASI-2521
Changes and Description

Added UserInfo to Discussion
Added UserInfo to DiscussionReply

How to test this change

Create a Discussion, observe that CreatedByUserInfo populates appropriately and ModifiedByUserInfo is nil
Update a Discussion, observe that CreatedByUserInfo populates without change and ModifiedByUserInfo populates appropriately
Create a DiscussionReply, observe that CreatedByUserInfo populates appropriately and ModifiedByUserInfo is nil
Update a DiscussionReply, observe that CreatedByUserInfo populatese without change and ModifiedByUserInfo populates appropriately

PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

PR is being closed in favor of https://github.com/CMSgov/mint-app/pull/397


Remove the cloudflare requirement

This line causes an aws configuration to fail

The following code causes the forward to occur if you aren't using cloud flare and you can now forward from a list of email addresses instead of just one


Dots in field names break the structure for multipart/form-data

Package version
v10.0.1
Describe the bug
For 'application/x-www-form-urlencoded', we have an option to pass queryString: { allowDots: false } but there is no such option for 'multipart/form-data' and the fields are parsed using dot for nesting.
We have a form that allows users to submit a URL along with other inputs and files. We need to store some meta related to the submitted URL in an input field like this
<input type='hidden' name={`meta[${url}][some_key]`} value={'some value'} />

The URL will obviously contain dots.
Reproduction repo
No response

Can you share some sample field names for the same?

e.g.
<input type='hidden' name={`meta[https://dns.mysite.com][ttl]`} value={'some value'} />

Yeah, seems like it needs a fix. For now (as a workaround), you can wrap the domain inside single quotes and it will work.
<input type="hidden" name="meta['https://dns.mysite.com'][ttl]" value="some value" />

Yeah, seems like it needs a fix. For now (as a workaround), you can wrap the domain inside single quotes and it will work.
<input type="hidden" name="meta['https://dns.mysite.com'][ttl]" value="some value" />

Yeah, that works. Thanks


test: enable React.StrictMode

https://reactjs.org/docs/strict-mode.html
Introduced in<EMAIL_ADDRESS>which is minimal version that is supported
https://reactjs.org/blog/2018/03/29/react-v-16-3.html
Enzyme api uses findDOMNode which is a deprecated API by react
And in tests appears findDOMNode warning
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Button which is inside StrictMode. Instead, add a ref directly to the element you
want to reference.

and
Warning: Legacy context API has been detected within a strict-mode tree

An alternative for render testing, is to use the basic react advice
https://reactjs.org/docs/testing-recipes.html#rendering

[x] Chore
[x] I have read the CONTRIBUTING document.
[x] My commits follow the Git Commit Guidelines
[x] My code follows the code style of this project.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@TheSharpieOne what are your thoughts on this?

@TheSharpieOne


rectified issue #35-DSA-Bootcamp-content Video frame is shrunk

rectified the issue DSA-Bootcamp-content Video frame is shrunk in safari browser

After rectifying


Ensure buttons colours are correct in standalone mode

#200 fixed button colours in the bridge, but they also look wrong in standalone.
They look like this:

But should look like this:

Fixed by #213


docs(aws-lambda) Add is_proxy_integration (#3427)

Summary
Adds documentation related to changes in Kong/kong#3427
Full changelog

Add option is_proxy_integration to aws-lambda plugins
Edit example to add steps if user wants to use proxy lamdba integration

Checklist:

[x] Commit message & atomicity checked
[ ] Documentation  N/A
[x] Spellchecked my updates
[ ] Ready to be merged

Kong staff: Please discuss with me before merging.

Thanks @RomainDeSaJardim  - we've just made Kong Hub https://docs.konghq.com/hub/ live, which has caused some changes to the files you edited in this PR. Please reapply your changes to the new files you will now find at https://github.com/Kong/docs.konghq.com/tree/master/app/_hub/kong-inc

Merged in the proper place with slight rewording.


Add native misk web tab build task into CI

This will fail if the tab has a regression and cannot be built. It's split up as a separate build so does not get in the way of the misk kotlin build.

builds are actually green, merging