Improved types, README documentation, simplify and extend unit tests

Remove obsolete deps target from Makefile.
Use a single unified eunit test generator for each module's tests, to reduce repetition.
Leverage the setup/0 function for storing common test parameters.
Add tests of invalid tokens in pot:valid_hotp and pot:valid_totp to achieve full line coverage in unit tests.
Extend hotp_generation_tests to reason about 0 and negative/very large interval (counter) values.
Improve type specifications for module parameters, particularly options.
Rename time() to interval() for clarity.
Export types for clients to reference as-needed.
Remove invalid casefold option in hotp function (this parameter is not set correctly and is unsupported by underlying base32 decoder, which is already case-insensitive).
Re-order library functions to group token generation and token validation.
Update README with TOC, cross-references, links table at the bottom, and function references.

Pull Request Test Coverage Report for Build 45

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 100.0%

Totals

Change from base Build 43:
1.4%

Covered Lines:
414

Relevant Lines:
414

💛  - Coveralls

Pull Request Test Coverage Report for Build 45

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 100.0%

Totals

Change from base Build 43:
1.4%

Covered Lines:
414

Relevant Lines:
414

💛  - Coveralls

Thanks @va17, the spelling error should be fixed now.

@nalundgaard  Wow, this PR is great, thanks! Do you mind if I add you as a collaborator to the project so you can merge PRs, etc.?

@yuce Thanks! I'm happy to contribute back—we've really appreciated this project at my company. I hope more accessible docs will encourage further adoption. :)
I'd be happy to work with you on the project as a collaborator, too.

Fantastic, thanks! I've added you as a collaborator. Looking forward to more of your contributions! :)


instructing Net::HTTP not to verify SSL when verify_ssl is false

addresses #30, tests included.

This looks great. I just need to verify it before cutting a new release.

:shipit:


Unknown measurement units

There is absolutely no documentation anywhere on which measurement unit this simulator uses.  I pasted in code designed for inch measurements, but the toolpath looks completely wrong.

After poking around some more, it seems that your simulator is simulating the workpiece by diameter, but the turning movements by radius.  This leads to the toolpaths being offset from the workpiece by half the workpiece's diameter.  Most CNC lathes use diameter-based coordinates, so for example if my workpiece was half an inch in diameter and I told the machine to move to X 0.31, it would in fact move to 0.155, thus bringing the diameter of the workpiece to 0.31".  Your simulator, on the other hand, goes to the absolute position of 0.31, meaning that there is no engagement with my half inch workpiece due to the actual workable radius of the part being only a quarter inch, or 0.25".

@Carnaxus the lathe simulator is supposed to work on a didatic CNC FANUC 21i-T lathe. To define which unit you want to use, you need to set G20 (for mm, maybe already inferred) or G21 (for inches, maybe not implemented). G90 code is probably inferred too and defines the absolute coordinates programming, and that's why you get unexpected toolpath behaviour (it's not wrong, just different than what you expected).
Please refer to this table and choose the correct configuration codes to the simulator behave the way you expect.

Now I'm having a whole new issue: The simulator straight up doesn't work anymore in Chrome, and doesn't render anything in Firefox.
Arg.


WSL still mounts /mnt/wslg/run/user at /run/user even when guiApplications=false

Windows Version
Microsoft Windows [Version 10.0.22631.4037]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps
Set guiApplications=false - it doesn't matter if you do this via %USERPROFILE%.wslconfig or /etc/wsl.conf
Start WSL afresh
Check what mounts exist with findmnt
Expected Behavior
Since WSLg is switched off, no mounts related to it should exist
Actual Behavior
Near the end of findmnt output:
│ └─/run/user                   none        tmpfs       rw,nosuid,nodev,noexec,noatime,mode=755
│   └─/run/user                 /dev/sdc[/mnt/wslg/run/user]
│                                           ext4        rw,relatime,discard,errors=remount-ro,data=ordered
│     └─/run/user/1000          tmpfs       tmpfs       rw,nosuid,nodev,relatime,size=795240k,nr_inodes=198810,mode=700,uid=1000,gid=1000

it can be seen (the middle two lines above) that /mnt/wslg/run/user has been mounted over /run/user even though WSLg is otherwise turned off.
Diagnostic Logs
No response

WslLogs-2024-08-18_14-59-30.zip
Frustrating to be made to jump through hoops attaching logs when I've already given a thorough reproduction recipe...

I also have the same issue. guiApplications=false cause a lot of program to crash when accessing /run/user/1000.


#5934 - add fetch option to AssociationOverride in order to override fetch strategy for subclasses of entities

adds the fetch option to the association-override sequence.
see #5934

ok, fixed the tests now...

Looks good to me! LGTM!

Sad that this didn't make the release. Anything else to do for this one @Ocramius?

Patch releases don't get new features, folks!
On 11 Sep 2016 5:05 a.m., "Patrick McDougle"<EMAIL_ADDRESS>wrote:
Sad that this didn't make the release. Anything else to do for this one
@Ocramius https://github.com/Ocramius?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/pull/5938#issuecomment-246158899,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakJo4yXGsBgmhgwM87OAaoksnct0bks5qo2_6gaJpZM4JN-7o
.

http://semver.org/ - the release yesterday was a release which shouldn't contain anything which is a new feature (and this one is definitly a new feature)

Can we get this in 3.0?

@patrick-mcdougle we'll see, 2.6 hopefully :-)

Any news on this?

ok, thank you @lcobucci :-)
On Tue, May 30, 2017 at 6:29 PM, Luís Cobucci<EMAIL_ADDRESS>wrote:

@lcobucci approved this pull request.
I've rebased it to sync with master and made a tiny change (to use ::class
syntax) and it LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/pull/5938#pullrequestreview-41003343,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFvwBHfXWf57NDx3vdjcShelzcSXqfnVks5r_EP7gaJpZM4JN-7o
.

thanks for the review, hope I'll find some time tonight to address your comments :-)

On 31. May 2017, at 11:39 AM, Marco Pivetta<EMAIL_ADDRESS>wrote:
@Ocramius requested changes on this pull request.
In lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php:

@@ -621,6 +621,11 @@ public function loadMetadataForClass($className, ClassMetadata $metadata)
$override['inversedBy'] = (string) $overrideElement->{'inversed-by'}['name'];
}

           // Check for `fetch`

           if (isset($overrideElement['fetch'])) {

               $override['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . (string) $overrideElement['fetch']);

Can we use ::class for the first bit of the string?
In lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php:

@@ -470,6 +470,11 @@ public function loadMetadataForClass($className, ClassMetadata $metadata)
$override['inversedBy'] = $associationOverride->inversedBy;
}

           // Check for `fetch`

           if ($associationOverride->fetch) {

               $override['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . $associationOverride->fetch);

Can we use ::class for the first bit of the string?
In lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php:

@@ -622,6 +622,11 @@ public function loadMetadataForClass($className, ClassMetadata $metadata)
$override['inversedBy'] = (string) $associationOverrideElement['inversedBy'];
}

           // Check for `fetch`

           if (isset($associationOverrideElement['fetch'])) {

               $override['fetch'] = constant('Doctrine\ORM\Mapping\ClassMetadata::FETCH_' . $associationOverrideElement['fetch']);

Can we use ::class for the first bit of the string?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@lcobucci as travis-ci seems to not run on this PR, I just executed the corresponding tests on my machine:
→ ./vendor/bin/phpunit --group DDC-5934
PHPUnit 6.2-g3e3c42c32 by Sebastian Bergmann and contributors.

......                                                              6 / 6 (100%)

Time: 1.01 seconds, Memory: 36.00MB

OK (6 tests, 12 assertions)

@Ma27 travis passed! :+1:


HTTPS is required for full functionality

Hey, i am trying to use this under Unraid, but somehow i dont get it to work.
After clicking "Verbinden" i see the following:

and trying to start obs via right-click->docker-custom->OBS Screencast i see this:

Bump.
I have the same issue here.  Is there a workaround?


about command line length limit in windows

Command Line:
G:\project\vsf\example\template\project\cmake\aic8800\build>E:\Software\armllvm\bin\clang.exe -mcpu=cortex-m4 -mthumb --config armv6m_soft_nofp_rdimon -Ofast -std=gnu11 -Wall -fno-builtin -fno-strict-aliasing -fdata-sections -fms-extensions -ffunction-sections -fms-extensions -fdiagnostics-color=always -Xlinker -TG:/project/vsf/example/template/project/cmake/aic8800/linker.ld -Xlinker -Map=output.map -mabi=aapcs -march=armv7e-m @CMakeFiles\vsf_template.rsp -o vsf_template.elf -Wl,--out-implib,libvsf_template.dll.a -Wl,--major-image-version,0,--minor-image-version,0
clang: error: unable to execute command: Couldn't execute program 'E:/Software/armllvm/bin/ld.lld.exe': 文件名或扩展名太长。  (0xCE)
clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)
the compiler version is 14.0.0.
It seems that the problem is because of the command line length limit in win10, is it possible to fix this?
There are 700 .c files in the project, so it will make the link command too long in windows.

Hello,
Thank you for trying the toolchain and reporting the issue!
The recommended way to overcome the command line length limitation is to use Response files.

Hello,
Thank you for trying the toolchain and reporting the issue!
The recommended way to overcome the command line length limitation is to use Response files.

Thanks


Add Power Platform logo files

Required items, please complete
Change(s):

New logo files

Reason for Change(s):

Preparation for new solution

Version Updated:

N/A

Testing Completed:

N/A

Checked that the validations are passing and have addressed any issues that are present:

N/A

Hi @kingwil, A logo image should have a file size of less than 5kb, but the below mentioned image exceeds that size. Please resize it. Logos/PowerPlatform.svg

Hi @v-atulyadav  the image was successfully downsized


Scale method up to work efficiently on HSC images

19/MAY/22

in the absence of other appropriate data at the moment working with a student from Oulu on a large dataset to investigate the performance of the algorithm
other datasets are being considered to help with the performance investigation

09/JUN/22

99% of the solution is expected to be simple to implement
Determined that there is only one circumstance where a 2nd co-add is needed.  This will be explained in the paper.
no updates from the Oulu student
will continue with refinements and tests

01/JUL/22

meeting with DM
DM started their own experiments with some other ideas
no longer convinced that novel method is the way to go so now considering going with what the DM are experimenting
looking at three options, one is simple and easy to implement, the others require WP3.7 to develop
method 1 solves 90% of the problems
need to discuss with others in the DM team, not just Lee,
will still complete the novel method since likely to be useful even if not included in the pipeline. This could fix some of the worse frames in the dataset.
will instigate a more regular meeting schedule with the DM team

28/JUL/22

@aemerywatkins preparing for August'22 PCW where will discuss the 3 options with DM team.  Need input from DM before progressing

19/.AUG

spoke to Susrya at PCW who showed Aaron the software.  It appears that some of the routines required for LSB is already available in the pipeline.  Expect to be able to scale up to HSC.
will now confirm the routines do as expected
will tackle this after completing the other task

23/SEP/22

in progress, expect to have prelimiary results  by end of year

04/NOV/22

working with DM to determine algorithm to use and implementing this will in tandem with the scaling
will start in December '22
this task will extend into Phase C since requires iteration and pipeline is still changing

19/DEC/22

@aemerywatkins visited DM team in December
wanted to confirm with DM team how to converge on strategy and scaling up
will access HSC track direct from DM server. will also lookat other datasets if available eg AuxTel.
Not sure ho much scaling uyp can be completed before Phase C starts

discussed method when Aaron at Princeton
best option is to use existing pipeline but to change parameters eg bin size, spline, ...
plan for scaling up to HSC is to use exsiting software but perform tests to esatcblish approporuate paramters for LSB


add l3-router sensu check

added bits for l3 router check: https://github.com/blueboxgroup/ursula-monitoring/pull/25

Looks good. We'll want this PRd to RELEASE-1.3.x too.


Add support for EIP-2930 transactions in eth_call request resolution

Currently, eth_call can only resolve requests to EIP-155 or EIP-1559 transactions to match Hardhat's behaviour. It should however also support EIP-2930 transactions.
Definition of Done
Add support for resolution of an eth_call request to an EIP-2930 transaction

I believe those should only be used in two cases:

When you are running Berlin and an access list is provided.
When running >= London and an access list and gasPrice is provided.

Resolved by https://github.com/NomicFoundation/hardhat/pull/4746


[dxgi] Implement support for more formats in GetMonitorFormatBpp

Reduces log spam in 3dmark fire strike
I don't know if it is any more useful than that lol

What is Firestrike doing exactly? None of this should be necessary since we already handle all legal swap chain formats.

Actually we're missing the RGB10A2 ones, but would still be good to know what the benchmark needs.

What is Firestrike doing exactly? None of this should be necessary since we already handle all legal swap chain formats.

Not sure, it just seems to be calling this function for the hell of it, it doesn't change anything related to how it runs or performs

can you post a log?

without patch:
steam-231350.log
with patch:
steam-231350.log

@doitsujin I posted the logs, could you look at them?

I did look at them, for some reason it's querying everything somehow. Need to think about a more elegant way to improve this.


udunits 4.5.5

Type: Missing
Summary:
udunits 4.5.5
Details:
ClearlyDefined pom no license info
Maven pom no license info
Maven license link is BSD-3-Clause: https://www.unidata.ucar.edu/software/netcdf/copyright.html
Resolution:
BSD-3-Clause
Affected definitions:

udunits 4.5.5

Same as #16767 and #16769. Updated to NetCDF.


[mac] enable broadcast message retransmission in MAC layer

@zhanglongxia, thanks for this update.  Handling duplicate MLE messages at the MLE layer is a much better approach than attempting to do the same at the MAC layer.

@jwhui, thanks for abtink's suggestion. Current method is much easier and better. I have updated the code for your comments. Please review it again.


Global Variables Assignment

I'm submitting a ...

[ ] bug report
[ ] feature request
[x] support request
[ ] other (Please specify)

Better description I am trying to achieve something like this
so i can call the settings from any controller or view
App.factory('settings', ['$rootScope', function($rootScope) {     // supported languages     var settings = {         layout: {             pageSidebarClosed: false, // sidebar menu state             pageContentWhite: true, // set page content layout             pageBodySolid: false, // solid body color state             pageAutoScrollOnLoad: 1000 // auto scroll to top on page load         },         assetsPath: '../assets',         globalPath: '../assets/global',         layoutPath: '../assets/layouts/layout2',     };     $rootScope.settings = settings;     return settings; }]);

Laravel & Angular version: 3.3.0

@jadjoubran

First of all that would never work. Are you new to angular or coding in general? have you work with classes before? are you familiar with POO?
You have 2 classes there, the AppViewController and the LoginFormController each class has it's own scope, wich means they don't share variables, i mean just think about it, it's like you have to refrigerators, each one has it's own fruits, of course you can change their fruits inside the fridge but theres no way one fridge know what inside another fridge...
That said, if you don't want to show the header or footer in one view just in your angular\config\ routes.config.js look for the app.login state and just delete the header and footer view so you end up having something like:
.state('app.login', {
    url: '/login',
    views: {
        'main@': {
	    templateUrl: getView('login')
	}
    }
})

@flick36  Yeah , I am really new here thanks for your advice but you answer will not fix the problem I have I can override the header to be empty template HTML , but I am  looking to initialize global settings which could be changed from any controller are you familiar with that !!!

That wasn't what your original post said, i did solve what you asked first ¬¬
Create a service https://github.com/jadjoubran/laravel5-angular-material-starter/issues/331#issuecomment-224471442

@flick36 you didn't solve it as i need but anyway i found the way to do it.
Thanks for nothing :) lol

I'm submitting a ...
 bug report
 feature request
 support request
 other (Please specify)
I am just new to Angluar JS and had rough time to do what i am thinking to do in this way.
I want to hide the Header on Specific Page through ng-show and variables to be assigned in AppComponet and cahnge those values in the LoginFormComponent
here is the code

`class AppViewController {
constructor($mdToast, ToastService, $window) {
'ngInject';

    this.$window = $window;
    this.$mdToast = $mdToast;
    this.ToastService = ToastService;
    this.headerShow = true;
    this.footerShow = true;

}`
"class LoginFormController {
constructor($auth, ToastService) {
'ngInject';

    this.$auth = $auth;
    this.ToastService = ToastService;
    this.headerShow = false;
    this.footerShow = false;
}"
`div ui-view="header" ng-show="vm.headerShow">

div ui-view="footer" ng-show="vm.footerShow">`

Laravel & Angular version: 3.3.0
@jadjoubran

I did solve what you asked, you should elaborate better next time if you want people to solve your problems as you 'need them' to be solved
You're welcome (:

@flick36  Just Personal Advice Take or Ignore it , If you want to be appreciated for helping anybody Don't be offensive :) Always remember experience come from mistakes , Wish you best luck


Readme instructions are not OK for AWS EKS deployment using Secret Manager

The documentation does not provide accurate instructions for the case of a deployment using the AWS Secret Manager, instead of Vault.
The documentation should instruct to se the following variables in the main.tf file:
Delete "vault_user" parameter
Set "use_vault" to false
Set   "use_asm"   to true
Set  "create_asm_role" to true

https://jenkins-x.io/v3/admin/platforms/eks/ -> This links to the section that talks abt asm.


[Leadspace] Create or build skeleton component for leadspace

When Target is used to perform or create experiments in Target on AEM components, the Target team noticed unresponsiveness and delays in load time.  Upon more investigation, the teams found out that we need to add animation to cover the component while Target is personalizing the component for relevant components.
How? The team intends to use a skeleton on a component. Link is https://the-carbon-components.netlify.app/?nav=skeleton.
Scope? The request is to add on any component and also at the page level for CMS. We will need to enable this for all components used in all components.
Web components with element name for example is

We will do a bit of investigation to see what's the ideal solution to the problem. From Slack conversation, the problem we are trying to solve really is:
Target takes a few seconds to serve up customized content.
Benefits of skeleton state is it helps to avoid page jump. But skeleton state is typically used in products where performance is challenging depending on data queries. This is not usually a challenge in marketing pages, so we have not considered adding skeleton states.
Skeleton state is also less effective in preventing page jump when content is unknown, for example the content can be 3 lines wrap on that breakpoint, and causing a jump anyway.

Hey @sbah1 The design team had a huddle on it and we agreed it’s best to find alternative solutions to lead space skeleton state. Because load time shouldn’t be an issue for majority of our usage cases, and it’s relatively easy to achieve the gray box on your end or hiding content until Target is ready. When some load time is an issue, it’s usually happening in productive experiences, for which the Carbon components skeleton states are available already. If there are more use cases that could need skeleton states in the context of expressive experiences (marketing content, editorial content), please bring it to our attention and we will evaluate again. Thanks!

The skeleton was identified by Shawn Hoglund as a desired UI that was already available in Carbon that should be used as a default loading animation for the Leadspace.  This would be implemented to make all pages have a consistent load in animation for the leadspace so it would be more difficult for end user's to identify if something was altering the page, like Adobe Target.
Other places in the site use other animations like fade in's or the loading spinner but Shawn identified skeleton as the desired state.

8/30 Engineering meeting summary:

This fix should not be implemented as a DDS component
It should be a CSS class with some styles applied on the application side because there is additional work to be done to manage the space.
DDS dev to provide a code sandbox example (Need a dev issue) Priority - High (no release for this work)
Lee scheduled time in the 9/1 Engineering Office hours.  This approach will be discussed in that meeting.


IBM Block CSI update upstream to v1.2.0

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

@oriyarde can you check on your side?
message: name:ibm-block-csi-operator status:Present version:v1]]]Logs for container ibm-block-csi-operator in pod ibm-block-csi-operator:
Error from server (BadRequest): container "ibm-block-csi-operator" in pod "ibm-block-csi-operator-56fbfc6dbb-dm2h6" is waiting to start: trying and failing to pull image
    Checking if CSV passes                        [  FAILED  ]
make: *** [Makefile:80: operator.install] Error 1
Makefile:46: recipe for target 'operator.install' failed
make: *** [operator.install] Error 2

@oriyarde can you check on your side?
message: name:ibm-block-csi-operator status:Present version:v1]]]Logs for container ibm-block-csi-operator in pod ibm-block-csi-operator:
Error from server (BadRequest): container "ibm-block-csi-operator" in pod "ibm-block-csi-operator-56fbfc6dbb-dm2h6" is waiting to start: trying and failing to pull image
    Checking if CSV passes                        [  FAILED  ]
make: *** [Makefile:80: operator.install] Error 1
Makefile:46: recipe for target 'operator.install' failed
make: *** [operator.install] Error 2

@mvalahtv I am able to pull the image on my side. not sure why it fails here.
is there a way to see more logs/debug it?

/retest

/recheck

This is what we see

Logs are following.
clusterserviceversion phase for "ibm-block-csi-operator.v1.2.0": "Installing"

clusterserviceversion phase for "ibm-block-csi-operator.v1.2.0": "Installing"

failed to reach Succeeded clusterserviceversion status for "ibm-block-csi-operator.v1.2.0"

map[conditions:[map[lastTransitionTime:2020-06-29T21:19:14Z lastUpdateTime:2020-06-29T21:19:14Z message:requirements not yet checked phase:Pending reason:RequirementsUnknown] map[lastTransitionTime:2020-06-29T21:19:14Z lastUpdateTime:2020-06-29T21:19:14Z message:one or more requirements couldn't be found phase:Pending reason:RequirementsNotMet] map[lastTransitionTime:2020-06-29T21:19:14Z lastUpdateTime:2020-06-29T21:19:14Z message:all requirements found, attempting install phase:InstallReady reason:AllRequirementsMet] map[lastTransitionTime:2020-06-29T21:19:15Z lastUpdateTime:2020-06-29T21:19:15Z message:waiting for install components to report healthy phase:Installing reason:InstallSucceeded] map[lastTransitionTime:2020-06-29T21:19:15Z lastUpdateTime:2020-06-29T21:19:16Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...

 phase:Installing reason:InstallWaiting] map[lastTransitionTime:2020-06-29T21:24:14Z lastUpdateTime:2020-06-29T21:24:14Z message:install timeout phase:Failed reason:InstallCheckFailed] map[lastTransitionTime:2020-06-29T21:24:16Z lastUpdateTime:2020-06-29T21:24:16Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...

 phase:Pending reason:NeedsReinstall] map[lastTransitionTime:2020-06-29T21:24:16Z lastUpdateTime:2020-06-29T21:24:16Z message:all requirements found, attempting install phase:InstallReady reason:AllRequirementsMet] map[lastTransitionTime:2020-06-29T21:24:17Z lastUpdateTime:2020-06-29T21:24:17Z message:waiting for install components to report healthy phase:Installing reason:InstallSucceeded] map[lastTransitionTime:2020-06-29T21:24:17Z lastUpdateTime:2020-06-29T21:24:19Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...

 phase:Installing reason:InstallWaiting]] lastTransitionTime:2020-06-29T21:24:17Z lastUpdateTime:2020-06-29T21:24:19Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...

 phase:Installing reason:InstallWaiting requirementStatus:[map[group:operators.coreos.com kind:ClusterServiceVersion message:CSV minKubeVersion (1.16.0) less than server version (v1.17.0) name:ibm-block-csi-operator.v1.2.0 status:Present version:v1alpha1] map[group:apiextensions.k8s.io kind:CustomResourceDefinition message:CRD is present and Established condition is true name:ibmblockcsis.csi.ibm.com status:Present uuid:37b1202a-16bf-478f-a8b6-fede704c7196 version:v1beta1] map[dependents:[map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get"],"apiGroups":[""],"resources":["pods"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","create","delete"],"apiGroups":[""],"resources":["configmaps"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list"],"apiGroups":[""],"resources":["secrets"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update"],"apiGroups":[""],"resources":["persistentvolumeclaims"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update","create","delete","patch"],"apiGroups":[""],"resources":["persistentvolumes"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["*"],"apiGroups":[""],"resources":["events"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch"],"apiGroups":[""],"resources":["nodes"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update","create","delete"],"apiGroups":["apps"],"resources":["deployments","daemonsets","statefulsets"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","delete","get","watch","list"],"apiGroups":[""],"resources":["serviceaccounts"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","delete","get","watch","list"],"apiGroups":["rbac.authorization.k8s.io"],"resources":["clusterroles","clusterrolebindings"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update","patch"],"apiGroups":["storage.k8s.io"],"resources":["volumeattachments"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch"],"apiGroups":["storage.k8s.io"],"resources":["storageclasses"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","create"],"apiGroups":["monitoring.coreos.com"],"resources":["servicemonitors"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["update"],"apiGroups":["apps"],"resources":["deployments/finalizers"],"resourceNames":["ibm-block-csi-operator"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","delete","get","watch","list"],"apiGroups":["storage.k8s.io"],"resources":["csidrivers"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch"],"apiGroups":["storage.k8s.io"],"resources":["csinodes"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["use"],"apiGroups":["security.openshift.io"],"resources":["securitycontextconstraints"],"resourceNames":["anyuid","privileged"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","list","watch","delete"],"apiGroups":["apiextensions.k8s.io"],"resources":["customresourcedefinitions"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["*"],"apiGroups":["csi.ibm.com"],"resources":["*"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","watch","list"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshotclasses"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","watch","list","create","update","delete"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshotcontents"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["update"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshotcontents/status"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","watch","list","update"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshots"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["update"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshots/status"]} status:Satisfied version:v1beta1]] group: kind:ServiceAccount message: name:ibm-block-csi-operator status:Present version:v1]]]Logs for container ibm-block-csi-operator in pod ibm-block-csi-operator:

Error from server (BadRequest): container "ibm-block-csi-operator" in pod "ibm-block-csi-operator-56fbfc6dbb-dm2h6" is waiting to start: trying and failing to pull image

    Checking if CSV passes                        [  FAILED  ]

make: *** [Makefile:80: operator.install] Error 1

Makefile:46: recipe for target 'operator.install' failed

make: *** [operator.install] Error 2

Tomorrow i will also check localy

We get this error message
clusterserviceversion phase for "ibm-block-csi-operator.v1.2.0": "Installing"
clusterserviceversion phase for "ibm-block-csi-operator.v1.2.0": "Installing"
failed to reach Succeeded clusterserviceversion status for "ibm-block-csi-operator.v1.2.0"
map[conditions:[map[lastTransitionTime:2020-06-29T21:19:14Z lastUpdateTime:2020-06-29T21:19:14Z message:requirements not yet checked phase:Pending reason:RequirementsUnknown] map[lastTransitionTime:2020-06-29T21:19:14Z lastUpdateTime:2020-06-29T21:19:14Z message:one or more requirements couldn't be found phase:Pending reason:RequirementsNotMet] map[lastTransitionTime:2020-06-29T21:19:14Z lastUpdateTime:2020-06-29T21:19:14Z message:all requirements found, attempting install phase:InstallReady reason:AllRequirementsMet] map[lastTransitionTime:2020-06-29T21:19:15Z lastUpdateTime:2020-06-29T21:19:15Z message:waiting for install components to report healthy phase:Installing reason:InstallSucceeded] map[lastTransitionTime:2020-06-29T21:19:15Z lastUpdateTime:2020-06-29T21:19:16Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...
 phase:Installing reason:InstallWaiting] map[lastTransitionTime:2020-06-29T21:24:14Z lastUpdateTime:2020-06-29T21:24:14Z message:install timeout phase:Failed reason:InstallCheckFailed] map[lastTransitionTime:2020-06-29T21:24:16Z lastUpdateTime:2020-06-29T21:24:16Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...
 phase:Pending reason:NeedsReinstall] map[lastTransitionTime:2020-06-29T21:24:16Z lastUpdateTime:2020-06-29T21:24:16Z message:all requirements found, attempting install phase:InstallReady reason:AllRequirementsMet] map[lastTransitionTime:2020-06-29T21:24:17Z lastUpdateTime:2020-06-29T21:24:17Z message:waiting for install components to report healthy phase:Installing reason:InstallSucceeded] map[lastTransitionTime:2020-06-29T21:24:17Z lastUpdateTime:2020-06-29T21:24:19Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...
 phase:Installing reason:InstallWaiting]] lastTransitionTime:2020-06-29T21:24:17Z lastUpdateTime:2020-06-29T21:24:19Z message:installing: Waiting: waiting for deployment ibm-block-csi-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...
 phase:Installing reason:InstallWaiting requirementStatus:[map[group:operators.coreos.com kind:ClusterServiceVersion message:CSV minKubeVersion (1.16.0) less than server version (v1.17.0) name:ibm-block-csi-operator.v1.2.0 status:Present version:v1alpha1] map[group:apiextensions.k8s.io kind:CustomResourceDefinition message:CRD is present and Established condition is true name:ibmblockcsis.csi.ibm.com status:Present uuid:37b1202a-16bf-478f-a8b6-fede704c7196 version:v1beta1] map[dependents:[map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get"],"apiGroups":[""],"resources":["pods"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","create","delete"],"apiGroups":[""],"resources":["configmaps"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list"],"apiGroups":[""],"resources":["secrets"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update"],"apiGroups":[""],"resources":["persistentvolumeclaims"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update","create","delete","patch"],"apiGroups":[""],"resources":["persistentvolumes"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["*"],"apiGroups":[""],"resources":["events"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch"],"apiGroups":[""],"resources":["nodes"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update","create","delete"],"apiGroups":["apps"],"resources":["deployments","daemonsets","statefulsets"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","delete","get","watch","list"],"apiGroups":[""],"resources":["serviceaccounts"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","delete","get","watch","list"],"apiGroups":["rbac.authorization.k8s.io"],"resources":["clusterroles","clusterrolebindings"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch","update","patch"],"apiGroups":["storage.k8s.io"],"resources":["volumeattachments"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch"],"apiGroups":["storage.k8s.io"],"resources":["storageclasses"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","create"],"apiGroups":["monitoring.coreos.com"],"resources":["servicemonitors"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["update"],"apiGroups":["apps"],"resources":["deployments/finalizers"],"resourceNames":["ibm-block-csi-operator"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","delete","get","watch","list"],"apiGroups":["storage.k8s.io"],"resources":["csidrivers"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","list","watch"],"apiGroups":["storage.k8s.io"],"resources":["csinodes"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["use"],"apiGroups":["security.openshift.io"],"resources":["securitycontextconstraints"],"resourceNames":["anyuid","privileged"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["create","list","watch","delete"],"apiGroups":["apiextensions.k8s.io"],"resources":["customresourcedefinitions"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["*"],"apiGroups":["csi.ibm.com"],"resources":["*"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","watch","list"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshotclasses"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","watch","list","create","update","delete"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshotcontents"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["update"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshotcontents/status"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["get","watch","list","update"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshots"]} status:Satisfied version:v1beta1] map[group:rbac.authorization.k8s.io kind:PolicyRule message:cluster rule:{"verbs":["update"],"apiGroups":["snapshot.storage.k8s.io"],"resources":["volumesnapshots/status"]} status:Satisfied version:v1beta1]] group: kind:ServiceAccount message: name:ibm-block-csi-operator status:Present version:v1]]]Logs for container ibm-block-csi-operator in pod ibm-block-csi-operator:
Error from server (BadRequest): container "ibm-block-csi-operator" in pod "ibm-block-csi-operator-56fbfc6dbb-dm2h6" is waiting to start: trying and failing to pull image
    Checking if CSV passes                        [  FAILED  ]
make: *** [Makefile:80: operator.install] Error 1
Makefile:46: recipe for target 'operator.install' failed
make: *** [operator.install] Error 2

Tomorrow i will also check localy

Yes, I have access to this error too.
I meant that it lacks the image pull failure details.
Any luck with the local check?

This error might be related to invalid local cache: https://github.com/containerd/containerd/issues/2306
Is there a way to do some clean up there? or a re-run that might be executed on a different machine?

@oriyarde i tried after cleanup and also on other machine and result is the same

@oriyarde i tried after cleanup and also on other machine and result is the same

@mvalahtv it still works on my side:
  Normal   Scheduled         <unknown>          default-scheduler   Successfully assigned default/ibm-block-csi-operator-688898cbc5-vdkjg to my-worker
  Normal   Pulling           20s                kubelet, my-worker  Pulling image "ibmcom/ibm-block-csi-operator:1.2.0"
  Normal   Pulled            12s                kubelet, my-worker  Successfully pulled image "ibmcom/ibm-block-csi-operator:1.2.0"
  Normal   Created           12s                kubelet, my-worker  Created container ibm-block-csi-operator
  Normal   Started           12s                kubelet, my-worker  Started container ibm-block-csi-operator

maybe if you try the installation with current master (without this PR change) on the same environment, it could help isolate the root cause?

I've tested 1.1.0 from master and it is working fine. Only 1.2.0 doesn't work from your repo

I've tested 1.1.0 from master and it is working fine. Only 1.2.0 doesn't work from your repo

@mvalahtv I rebuilt and pushed the image using a newer docker.
could you /retest?

Retesting

@oriyarde Can you please rebase current master? We are already using kubernetes 1.18 for testing. Maybe this will help. Thanks

@oriyarde Can you please rebase current master? We are already using kubernetes 1.18 for testing. Maybe this will help. Thanks

I rebased and followed the DCO instructions, but I think it messed up the PR.
Should I just open a new PR? I don't have any additional commits to add after my first one.

@oriyarde yes please make new PR. I think this will be the cleanest way.

@oriyarde yes please make new PR. I think this will be the cleanest way.

I opened: https://github.com/operator-framework/community-operators/pull/2017


Publish new NPM version 3.0.0

The latest NPM version is 2.1.0 (published 3 years ago), the version specified in package.json in latest commits is 1.x.y (for some values of x, y I forgot). That version mismatch is particularly confusing.
What do you think about bumping the version in package.json to 3.0.0 and releasing a new NPM package version?

Thanks so much for digging into this and for the updates, Comfreek!
Good idea to bump the version in package.json!   I need to look up how to
release a new NPM package version - I will get onto that early next week -
this weekend is a bit hectic!
Best regards,
Paul
On Sat, Jul 6, 2019 at 4:01 AM ComFreek<EMAIL_ADDRESS>wrote:

The latest NPM version is 2.1.0 (published 3 years ago), the version
specified in package.json in latest commits is 1.x.y (for some values of
x, y I forgot). That version mismatch is particularly confusing.
What do you think about bumping the version in package.json to 3.0.0 and
releasing a new NPM package version?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jpaulm/jsfbp/issues/85?email_source=notifications&email_token=AACMMJ2J34O7BSQ5HKI2KBDP6BGMZA5CNFSM4H6S3DJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5UXWXQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACMMJ7R2ME4MY4HYVKALBDP6BGMZANCNFSM4H6S3DJQ
.

I assume you are talking about the version no. in package.json line 2?  I am not sure how this ties in with the version no. of NPM - everything in that file has a different version no.!  Also do I just create a new npm package, or update the old one?  Thanks

Yes, exactly, that line 2.

everything in that file has a different version no.!

Precisely! That's why it's confusing :smile: I think the procedure would be

Bump that version number in package.json, line 2 to, say, 3.0.0.
Run npm install (to update package-lock.json as well)
Follow the usual publishing procedure for NPM packages. I don't know that by heart, sorry, would need to look it up as well.

Thanks!  It's been so long that I've forgotten everything!
I recently transferred to Win 10, and it looks like everything has to be
rebuilt!
Now it's saying something about needing V141 build tools!  Someone
suggested installing Visual Studio 2017, but I have that!
I noticed that I don't have a node-modules/fibers directory, so I trid npm
install fibers, and I get the same message about v141!
C:\Program Files
(x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.Cpp.Platform.targets(57,5):
error MSB8020: The build t
ools for v141 (Platform Toolset = 'v141') cannot be found. To build using
the v141 build tools, please install v141 bui
ld tools.  Alternatively, you may upgrade to the current Visual Studio
tools by selecting the Project menu or right-cli
ck the solution, and then selecting "Retarget solution".
[C:\Users\Paul\Documents\GitHub\jsfbp\node_modules\fibers\buil
d\fibers.vcxproj]
Looks like I have to create a Visual Studio project, but what should it be
called...?
Can you get me started...?!
TIA,
Paul
On Mon, Jul 8, 2019 at 2:37 AM ComFreek<EMAIL_ADDRESS>wrote:

Yes, exactly, that line 2.
everything in that file has a different version no.!
Precisely! That's why it's confusing 😄 I think the procedure would be

Bump that version number in package.json, line 2 to, say, 3.0.0.
Run npm install (to update package-lock.json as well)
Follow the usual publishing procedure for NPM packages. I don't
know that by heart, sorry, would need to look it up as well.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jpaulm/jsfbp/issues/85?email_source=notifications&email_token=AACMMJ5Q7OFW7OX2RVRED43P6LODNA5CNFSM4H6S3DJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZMDTMA#issuecomment-509098416,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACMMJ45I5RJ6JNQKN7DAELP6LODNANCNFSM4H6S3DJQ
.


get-ec2imagebyname does not return the 2019 windows servers

The ImageUtilities class does not reference Windows Server 2019 :
https://github.com/aws/aws-sdk-net/blob/b691e46e57a3e24477e6a5fa2e849da44db7002f/sdk/src/Services/EC2/Custom/_bcl%2Bcoreclr/Util/ImageUtilities.cs#L44
This is not showing Windows server 2019 amis when calling the get-ec2imagebyname cmdlet.

Any updates on this issue? It's been a year, and you still cannot use Get-EC2ImageByName -Name WINDOWS_2019_BASE


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing fd10179...2222324:
  > 2222324 Update actions (# 6323)
  > e7459cb upgrade to latest dependencies (# 6324)
  > e874b89 upgrade to latest dependencies (# 6321)
bumping knative.dev/pkg 75629c8...00c122e:
  > 00c122e Add genreconcile for ConfigMap (# 2489)
  > 6bb6518 Update actions (# 2488)
  > 5b0e728 drop deprecated eventing repos (# 2463)

/lgtm
/approve


Tag/TagList: Add onBeforeRemove prop

It'd be really nice if we could add an optional onBeforeRemove to the Tag and TagList components so we could only make the tag dissappear when/if the request to remove the tag actually resolves. With a feature like this we could sync up the tag being removed from different parts of the UI at the same time.
It would also be great to have an "out of the box" loading state where the delete cross icon is replaced by a spinner :)

@Charca OooOoo! Great ideas :D!!


With an image, the remote containers option doesn't work

So this only works for codespaces.

Readme fixed by pull request #4


:book: Dependabot config file link

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[X] PR title follows the guidelines defined in  https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#pr-process

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)
It seems like dependabot.com is gone

What is the new behavior (if this is a feature change)?
Link to dependabot config file now points to https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Thanks for the PR @hholi. The checks.md file is auto-generated. You'll need to make your updates to docs/checks/internal/checks.yaml and then run make generate-docs. Let me know if you have any issues.

More on this https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#updating-docs

Codecov Report

Merging #1498 (5093d75) into main (0d76dea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   50.43%   50.43%
=======================================
  Files          68       68
  Lines        6069     6069
=======================================
  Hits         3061     3061
  Misses       2807     2807
  Partials      201      201


Merge in main branch from redis/rueidis

Merge in main branch from the original repo

Closing to more easily resolve conflicts in a different attempt


Customizable VA Name and Gender

I think it would be a good idea to allow an option in the profile.json to customize the name and gender (the voice) of the VA.

What do you think of this guys? @neilnelson @aniketk21

Fixed here: https://github.com/Melissa-AI/Melissa-Core/commit/c625c23e383fcd01fd5385821dabb9c80f0f7495.


Gas estimation issue on contract deployment

Datura is reporting an issue with gas estimation when they are deploying ERC-20 contracts (just as an example). The only difference from our e2e tests is probably the bytecode size. First, we need another contract deployment test that deploys a standard ERC-20 to reproduce it locally.
They are saying that this fails:
const contract = await contractFactory.deploy();

but this succeeds:
const contract = await contractFactory.deploy(...parameters, {
        gasLimit: gasLimit
    })

i.e. they have to explicitly specify gas limit.

The deployment of erc20 contract is fine in both devnet-ready and devnet branch in subtensor. The https://github.com/opentensor/subtensor-js-tests/blob/main/src/evm/eth.erc20.deploy.test.js is added. Both deploy with gas_limit and without gas_limit are passed.


test ReferenceOperations implementations

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@havardpe please take a quick look

@havardpe please take another look


Ability to disable import load error cache

Clear and concise description of the problem
When we load some modules with dynamic import, and it fails due to network, we want to refetch the resource on clicking retry button, but I find that the loaded status is cached and no new request will be sent and retry will never work.
And I tried something like await import(`./pages/${page}/index.tsx?_=${Date.now()}`) but it seems not working, vite does not recognize this expression.
Suggested solution
As title, I want an ability to disable import load error cache
Alternative
N/A
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I'm not sure.
I don't know what exactly blocks this feature. PR's welcome.

Hello,
Any update on this?
Thanks.

Closing as this is blocked by the spec. A Vite plugin could be created to auto-inject a timestamp query if needed to bust the cache.


change default Nothing Selected to All Variants on Send Notification dialog AGPUSH-1449

http://issues.jboss.org/browse/AGPUSH-1449
The Send Push Notification dialog should say "All Variants" by default and when checked some variants and then uncheck them, it should still say "All Variants".

thanks!


Add support for writing output in minc-style .xfm  files

Added support for writing .xfm files to ANTS and  antsRegistration binaries.
antsRegistration will have --minc option to make it produce .xfm files as output.

hi @vfonov  --- obviously, we'd like to merge this but we would also like to check it first ... but our travis builds are failing.  will get back to this once we get the core ants build working.

got builds working so let's see how this goes on travis

it's because latest version of libminc has niftiio library inside of it , with ZLIB somehow disabled. So, when ITK is built with MINC library it recieves two versions of niftiio , one with support for .gz and another one without. I recently fixed it in libminc: https://github.com/BIC-MNI/libminc/commit/dcb93a5f50d2038fbe723874bb1407ef86363cdb , but it didn't make it into ITK yet.


asconfig suggestion

Wouldn't it make sense to move the asconfig.json file to the .vscode folder to have all settings in one place? Just looked for this file in a large project and it gets listed at the end while the .vscode folder is on top.

Your idea is coming from the right place, but there are reasons this file gets special treatment. TypeScript's tsconfig.json does not go into the .vscode/ directory either. These files are also used by compilers, and they aren't considered specific to VSCode. However, tasks.json, launch.json, and settings.json are only intended for VSCode and nothing else. Additionally, a developer might omit the .vscode/ directory from their repo because it contains settings specific to their local machine, but asconfig.json contains compiler options that will be the same everywhere.


How to build a custom plugin

How do I build a custom plugin?
I had modified copies of the template plugin building and running per the docs and the wiki. It seems the plugin directory has been removed and the makefile changed. How does one build a plugin with the new makefile?

@Lifto Docs: http://emqtt.io/docs/v2/plugins.html#build-and-release-the-plugin


Round ui corners

There is a problem in new style phones which they have rounded displays
so android material design that aves uses right now is looks reallt good on old phones with sharp corners
current roundness is about 4dip if you add ability to set custom values (not any values) like 8 12 16 18 20 24 26 32 ...
that would be awsome !!!!

I understand that modern screens have rounded corners (mine is like that), but I don't understand your request.
What would your requested setting do? Could you provide screenshots, samples or mockups?

I would prefer to have an option which is like the screenshot above make me able to set a custom value for the corners, but that option should not have any range of roundness
In old material design guide we used 4.0dip but now we do more rounded corners
So the option has to have scales of usual valuees like 4dip(which is default), 8dip ,12dip, 16, 20, 22, 24 and may more

There are different rounded corners everywhere in the app. Your requested setting would apply to which ones?

That would be awesome if you make separate option for each section plus album box

"thick borders have meaning"

Thick borders indicate filters, whether they have a cover image or not, multiline or not, coloured or not.

PS. I do love first logo from https://github.com/deckerst/aves/issues/798#issuecomment-1771185509 <3

Haha, I'm so glad I moved on from that design!

PSS. I don't understand current trend to make everything more and more round.

Some time ago, Microsoft was getting very squarish and colourful. I liked that they were trying their own thing, but I don't know if they kept that design... Anyway, in my app I try to use roundedness and other visual cues as hints for identity and behaviour. Here for example to distinguish a media item thumbnails (square) from filters with a cover image (rounded).


x/tools/go/analysis/passes/shadow/cmd/shadow: shadow inconsistent failures when var in code shadows a var in a test file

What version of Go are you using (go version)?

$ go version
go version go1.13 linux/amd64

The docker image that was in use was: circleci/golang:1.13-stretch and with digest sha256:728d4283948f6f2666c6dbdcb56648a5db9056431265d296175449463a82c072.
You can get that specific version of the image with:
$ docker pull circleci/golang@sha256:728d4283948f6f2666c6dbdcb56648a5db9056431265d296175449463a82c072

Does this issue reproduce with the latest release?
I was not able to reproduce locally with go1.13 or go1.13.1.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/circleci/.cache/go-build"
GOENV="/home/circleci/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build650242782=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Ran shadow ./... in the root repository of this revision of stellar/go@c638a262494bddb19368254a8beb75e21ff77f1f.
I first installed shadow using go modules in a tmp directory, then changed back to the project and run shadow ./....
What did you expect to see?
Consistently either report no errors, or consistently report an error.
What did you see instead?
Some runs pass the shadow checker, some runs fail.
An example of a failing run:
/tmp/tmp.AztFEDruDz /go/src/github.com/stellar/go
go: creating new go.mod: module tool
go: finding golang.org/x/tools latest
go: downloading golang.org/x/tools v0.0.0-20190925230517-ea99b82c7b93
go: extracting golang.org/x/tools v0.0.0-20190925230517-ea99b82c7b93
/go/src/github.com/stellar/go
/go/src/github.com/stellar/go/keypair/main.go:95:2: declaration of "seed" shadows declaration at line 19

See https://app.circleci.com/jobs/github/stellar/go/8686.
The version of shadow being used is from commit golang/tools@ea99b82c7b93.
Line 95 of main.go defines seed in a function:
$ sed '94,95!d' keypair/main.go
func FromRawSeed(rawSeed [32]byte) (*Full, error) {
        seed, err := strkey.Encode(strkey.VersionByteSeed, rawSeed[:])

Line 19 of main.go is a comment:
$ sed '19!d' keypair/main.go
        // through malformation or if it does not verify the message against the

However as @bartekn points out in https://github.com/stellar/go/pull/1778#issuecomment-535569232, seed is defined in main_test.go.
$ sed '17,19!d' keypair/main_test.go
var (
        address   = "GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H"
        seed      = "SDHOAMBNLGCE2MV5ZKIVZAQD3VCLGP53P3OBSBI6UN5L5XZI5TKHFQL4"

Issues here:

The output of the message is confusing because it doesn't mention that the shadowed variable is in another file, i.e. main_test.go.
The failure is inconsistent. Most of the time there is no failure, then sometimes there is.

CC @ianthehat @matloob

@ianthehat @matloob @bcmills Is this intended behavior of the shadow analyzer? Is the analyzer still intended for use or no longer maintained? Thanks!

Inconsistent failures definitely don't sound like intended behavior, so my guess is that it's not intended. However, the analyzer isn't part of the go vet suite or gopls, so it's probably not very well-maintained. We've been considering adding it as an opt-in analyzer for gopls, so perhaps we can take a look at this then.

The shadow analyzer is marked experimental. My guess is that the problem is that running shadow on the test variant of a package produces different results than running shadow on the 'production' variant of the package. Adding the test files produces a shadowing.
In any case I don't think we can enable shadow as is: it's hard to detect when a shadowing is intended and we certainly don't want to trigger for all shadowings.


Create initial repos and teams for SAP CoP

Type of repository request
This initial repository will be initialized with the content of the following repo: https://github.com/miminar/sdh-helpers
Requested name for the repository
sap-datahub
Repository Description
Utilities and helpers for SAP Data Hub deployment in OpenShift
Admin Access
sdh-admins
Write Access
sdh-mergers
Read Access
NONE
Additional details
Additionally create the following team structure under redhat-cop Org:

sap-cop

sdh

sdh-admins (makentenza, miminar)
sdh-mergers (makentenza, miminar)

ansible

ansible-admins (makentenza, rhmk)
ansible-mergers (makentenza, rhmk)

Review request:
cc: @redhat-cop/container-cop-core

@makentenza repo has been created (imported from the other repo you provided) and permissions are being processed. Give it a bit of time and you should be good to go.
https://github.com/redhat-cop/sap-datahub


Explorer - Moving between File Explorer and Open Editors with Keyboard

Keybindings for navigation in lists/trees were introduced recently.
While this is a big help in achieving good vim keybindings, it immediately breaks down in the explorer.
The explorer is almost like a tree with two top level items, Open Files and File Explorer, but you can not navigate between them or expand/collapse them with the intuitive keys (up/down, left/right).
While most users use the mouse anyway, this is quite crucial for having good vim keybindings, since I really hate switching to the mouse for something like this.
I have no clue about the internal structure, but could the Explorer be made to implement a List and enable the new list.* commands?

@theduke the explorer is 1 tree widget and another tree widget to the top, it is not just one widget for numerous reasons (e.g. both scroll independently).
Looks like what you are asking for is having commands to jump from files explorer to opened editors and vice versa as if they where both in a single list widget.

Unless I'm missing something, commands already exist.
user can decide "when" scope
I use these all the time...
    "command": "workbench.files.action.focusFilesExplorer",
    "command": "workbench.files.action.focusOpenEditors",

I doubt that there is a when scope for checking if you are in the first entry of file explorer or the last entry of Open Editors, which means you'd have to remember a specific key to jump between those two, which seems far from ideal to me.


Communication: Add Profile Picture Support

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
[x] I strictly followed the principle of data economy for all database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
[x] I strictly followed the principle of data economy for all client-server REST calls.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

Currently, the readability of the communication module is lacking in terms of being able to distinguish who wrote a message. This is due to the only visual que being the username, which are hard to differentiate from another without close inspection.
Description

I added support for profile pictures in the communication module. This was done by adding a possibility to upload a picture in the user settings. The uploaded picture will be displayed when you write a message or answer in a thread. As a default picture, a user will be assigned a random color hue, which will be taken as the background of the default picture, and their initials will be displayed in white bold text. For example "Tom Martin Muster" will be "TM". This change also required slight rework in the displaying of the post headers. The user role is not displayed as a colorful badge anymore, but simply put below the username to not overload the colors.
Steps for Testing

Prerequisites:

1 Course with communication enabled
1 Student/Tutor/Instructor

Log in to Artemis
Go to the course
Go to the communication tab
Switch to any channel the user can write in
Post a new message
Verify the displaying of the default picture
On the top right, click the username and go to settings
Press the "Add a profile picture" button
Select a picture and crop accordingly
Revisit the communication tab and verify if the image is shown in the messages

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Performance Tests

[ ] Test 1
[ ] Test 2

Screenshots

Summary by CodeRabbit

New Features

Users can now upload, display, and delete their profile pictures.
New API endpoints for managing user profile images have been added.
Enhanced user interface for managing profile pictures in account settings.

Bug Fixes

Fixed issues with displaying default profile pictures when none are set.

Documentation

Updated localization files for user settings to include profile picture management.

Tests

Added tests for updating and deleting user profile pictures to ensure functionality works as expected.

Just tested it and it worked as expected :)
One question: Is a gravatar integration possible/planned? I think it would be nice if we could make the user's gravatar picture the default (instead of none), just like Slack or Zulip do

Gravatar should definitely be implemented, ig. in a follow-up

Just tested it and it worked as expected :) One question: Is a gravatar integration possible/planned? I think it would be nice if we could make the user's gravatar picture the default (instead of none), just like Slack or Zulip do

Good idea! I think we can add this in a standalone PR afterwards.

Two suggestions:

I think it would be nice if you could click on your own profile picture in a conversation to have an option to change it there. Users might not know to go to settings to do that.
And should we maybe also display the profile picture here?

I added the picture to the profile and added an option to navigate to settings by clicking the user icon of your own messages. 😊

Please ensure that the max size of the images is very low. Keep in mind that multiple 1000 Students are registered to artemis. Also the images shall not remain if a user gets deleted (-> GDPR)

Good call! I added functionality to remove the image on user deletion and adressed the image size with a max upload size restriction as well as a change of upload format to jpeg (when using the cropper). The cropper itself already is configured to scale the images to a max of 200x200. These changes should guarantee smaller filesizes in general, as well as prevent massive filesizes if anyone uploads an image to the api directly, without using the client.

Thanks for the changes! Works as expected :)
One more thing I noticed: Sometimes I get this weird black square appearing at the top left corner after/while using the photo cropper. Especially switching between light and dark mode causes this. Is this related to this PR or a general issue with the Photo Cropper?

I noticed a similar issue one time but just discarded it. I think it‘s related to the canvas that gets created by the cropper. I don‘t think its related to the changes in the PR, but I have an idea to fix it. As soon as I manage to reproduce it consistently I can create another PR to address this.


Widget docs a bit thin

I setup netlify cms for the first time yesterday and had / still have some trouble getting the widgets to do what I want(ed). There is a lot here, but I thought it better to be cohesive than 6 issues. Here was my discovery process after having known what a widget was for < 5 minutes.
First I went to the quick start, and setup my config. There is a section of the widgets in the collections section, and the table indicates some widgets. Initially I thought that those were all the widgets that were supported. I admittedly didnt see the Widgets link on the left sidebar. A link to the widgets page would have been nice right after the table e.g. 'here are all the widgets we support'.
I wanted an enum widget or something like it, so I searched google for enum widget, to no avail. I finally found the widgets link in the sidebar, and saw that there is a select and a list widget.
The list widget seemed like a candidate, but was a little complicated to grok at first. I think an image of the what each of the examples produces would be helpful.
The object widget seems like I could probably use it and there are probably many options, but there is no example section, so I am not sure what it is for.
The select widget has no example or usage instructions, but seemed like the best candidate. So I searched for it (https://www.google.com/search?q=netlify+select+widget) but didnt come up with anything specific, so I wasnt sure.
The top result was https://github.com/netlify/netlify-cms/blob/master/example/config.yml, which was huge. Yay, examples. IMO, this should be linked to in the Widgets docs page.
But there is a lot there that is not covered in any docs. e.g. File and folder collections. Nested collections
The settings.author situation seems really interesting, and it seems like I could reference the authors in a relation widget. But none of the relation examples show how to work with a nested collection.  What goes in the collection field? authors? settings.authors? Something else? I couldnt get anything to work (Cannot read property 'get' of undefined on the post page). I also tried a top level collection:
collections:
  - name: "authors"
    label: "Authors"
    file: "_data/authors.yml"
    description: "Author descriptions"
    fields:
      - name: authors
        label: Authors
        ...

But that gave me an error about collections being a file or folder. There is a file specified, I thought, but it seems there needs to be files or folder.
Overall, I felt like I was constantly guessing and checking when setting up the config. There are other more complicated things I want to do like have a list of categories we can pick in the post UI, get the authors relation to work, etc.
It would be nice to have a some really complete examples that show all the things that are possible linked to from the widget docs page. Or complete for common usecases. The example authors case would be amazing if a relation widget handled it in the example config. I assume a categories or tags case could be handled similarly.
I see there is https://github.com/netlify/netlify-cms/issues/598 so maybe these things are slated in that work. Hopefully this account is helpful. I've written my share of docs, and it is always hard to know where people get stuck.

Thanks a lot for the issue. I already knew our docs needed some work, but it's great to have reports of particularly sparse areas that are tripping people up.

Thanks for the detailed report! I'm using this issue to track improvements to the widget docs as I break up the outline from #598. Here's the Widgets section:

Built-in widgets

Intro to widgets, link to config
Reference listing for every type of widget, with the following:

UI sample (screenshot, gif, or working demo)
required/optional fields, defaults
sample config for more complex widgets (like list)

Custom widgets

Adapt, update, improve extending.md
Include advanced validation info from validation.md

The UI sample part may wait until the new UI is in place, but the rest can start now, and would definitely be an improvement.

Just noticed that #486 is related to this work as well.

Take me hours to understand the widget parts, I'm pretty new in static CMS and finally found this issue posted! pheew thanks @benogle for pointing it out.

@benogle you pretty much described my journey as well, a lot of hours were spent with browsersync and a trial and error process with the config.yml file!
I'm nowhere proficiente as I'd like to be, so that's why I've set myself the task to help redesigning the widgets page, and the first step, in my opinion, is changing the widgets table. I explored this into further detail on #486 but I'd love to have your contribution to it as well 😄

I don't have time this red hot second, but we should make a list of the specific issues outlined in @benogle's OP and check them off before closing. Even after @verythorough's extensive reboot of our documentation, a number of them still need to be addressed, such as images of how the widget looks to aid in grokability.
@hcavalieri's PR will help a ton :)

Here's what I've pulled from the OP:

[x] Link to Widgets doc from Quick Start (now "Add to your site")
[x] Link to the example config from the Widget doc
[x] Add code examples for each widget type
[x] Add docs about file/folder collection types
[ ] Add working demos for doc code snippets into example config (including a working relation widget)
[ ] Add demo UI screenshot for each code snippet
[ ] Document limitations of the relation widget, specifically that it searches whole files, not fields within a single file, so it requires a multi-file collection (i.e. files or folder) with a file for each "item" (which is good for a multi-field item like an author, but can feel clunky for a single-field item like a tag).
[ ] Add a note that the select widget is good for enum use cases? (Is this a mobile app dev thing? I've never encountered that term in web dev, so I'm not positive about the accuracy of that suggestion.)
[ ] Add information about nested collections? (I think this specifically refers to file collections nested under a files collection. Specifically, how to refer to a collection configured like this in, for example, a relation widget)

I can file an issue for adding the widget code samples to the example config and then screenshotting them for the Widget doc.
For the relation widget limitation, I can add that note about as quickly as I can write an issue for it, so I'll just make a PR.
For the last two items (enum widgets and nested collections), @benogle could you confirm that I've characterized your issue properly?

@verythorough an enum is just a programming term for a variable type that is a member of a given list of constants - so if your enum had "a", "b", and "c", "a" would be a valid member of the enum, but "d" wouldn't. It's usually used in statically-typed languages, so it doesn't show up in JS programming much. That suggestion about enum therefore sounds like good advice to me - not sure how else you'd model that to be honest outside of an arbitrary string input + validation.

@benogle could you confirm that I've characterized your issue properly?

Yep, this list seems great, and the docs look better already. ❤ ❤  for taking my rambling account super seriously :)

@verythorough Hi, I'm trying to wrap my head around this: so if I just like to have a relation field in a blog post called "tags", and it's a pretty much preset list (and a tag only has a name prop) … In order to build a usable relation field I then need to create a folder "tags" as a collection where each tag must have its own file?
I've seen plenty of examples having an authors.yml file where all authors are listed, but that won't work as a relation field?
If I'd still prefer to have the list of tags in a single file, would that require building a custom widget?

Yep, the relation widget works only at the entry level - it can select an entire entry and utilize a field within that entry. What you need is to search within a specific file in files type collection, and select multiple items from an iterable field within that entry. This isn't currently possible.
I would expect that this functionality could be patched onto the existing relation widget, and you'd provide a file property instead of a collection property:
- label: Tags
  name: tags
  widget: relation
  file: "_data/tags.yml"
  multiselect: true

searchFields would be optional, and assume the file is an array of values by default, and valueFields would also be optional, defaulting to the entire array value. This would make adding a displayField property, as attempted in https://github.com/netlify/netlify-cms/pull/594, even more crucial (so you can configure which field to display if your file is an array of objects).

Thanks for the pointers @erquhart! I'll take a closer look at the relation widget. Both PRs you mentioned seems to be inactive, but still functionality you'd like to see added to the project right?
Also, seems like there's a few other related WIPs: https://github.com/netlify/netlify-cms/pull/922 (multiselect for fixed values that can be set in the config.yml) and https://github.com/netlify/netlify-cms/pull/1100

@bjrn good point. The author of #1100 is very open to help, and I've added comments based on what was discussed here, let's move this conversation to that PR.

I'm going to close this as it has generally been fixed or covered in other ways. Looking at he unchecked items in the list in my comment above:

Demos and screenshots are requested in issue #910 .
Improved docs for select and list widgets should make it easier to identify them as good candidates for enum-style data.
"Nested" collections are now correctly described as files collections.
The relation widget restrictions are clearer now that the non-existent single-file collection is no longer erroneously included in the collection types doc.
Existing PRs may soon provide relation-widget functionality for fields in a single file (like an authors.yml).

I appreciate you all doing something with this. So many projects would just let a rambly issue like this languish.


Update index.js

Adds order ID to the FB purchase event

One nit and missing tests but looks ok otherwise. Let me know when you've made the changes!
cc @wcjohnson11 to verify this should be added!


Path resolution for APIGW with custom domain and base mapping using proxy Lambda integration

I am pretty positive that the bug is on APIGW side of things, but I feel like this needs to be documented somehow.
Setup

APIGW proxy-integrated with Lambda via ANY method
Custom domain api.some-domain.com is defined on top of APIGW(using APIGW console and not manually via Route53)
Lambda exposes a  GET /healthz endpoint that returns a 'OK' string
APIGW is deployed to v1 stage, so that the URL to invoke the /healthz endpoint above is https://randomstring-execute-api-<region>.amazonaws.com/v1/healthz

Explanation
When custom domain api.some-domain.com is defined using the default base path mapping (which is /) to v1 stage, then both the random and custom domain URLs work:

https://api.some-domain.com/healthz
https://randomstring-execute-api-<region>.amazonaws.com/v1/healthz

which is the expected result.
However, when a non-default base path mapping is used (for example /custom), then:
https://randomstring-execute-api-<region>.amazonaws.com/v1/healthz
continues to work (as it should), while neither of the following works (the first one should have worked):

https://api.some-domain.com/healthz
https://api.some-domain.com/online/healthz
https://api.some-domain.com/online/v1/healthz

Any other combination of the above doesn't work either.
Reason
After contacting AWS support and doing some testing, the reason is a difference in path resolution in two cases.

When a default / base path mapping is used, the Lambda handler is passed the following event structure (abridged to contain only relevant parts for clarity):

{
    resource: '/{proxy+}',
    path: '/healthz',
    httpMethod: 'GET',
    ...
    pathParameters: { proxy: 'healthz' },
    stageVariables: { alias: 'v1' },
    ...
}

When a non-default /custom base path mapping is used, the following event structure is passed:

{
    resource: '/{proxy+}',
    path: '/custom/healthz',
    httpMethod: 'GET',
    ...
    pathParameters: { proxy: 'healthz' },
    stageVariables: { alias: 'v1' },
    ...
}

In aws-serverless-express code there is event handling:
function getPathWithQueryStringParams (event) {
  return url.format({ pathname: event.path, query: event.queryStringParameters })
}

that refers to event.path, as it should, of course.
Of course, in the above case the following code would result in Lambda timeout, as there is no /custom/healthz endpoint defined (if only accidentally).
(Non)Resolution
Based on a suggestion from AWS support, we should use event.pathParameters.proxy instead of event.path, which is consistent in all cases.
This is, of course, absolutely incorrect and constitutes a bug in AWS APIGW resolution mechanism that breaks the Lambda encapsulation. The /custom path should have never been propagated beyond APIGW.
Suggestions and such
On a practical level, this issue means that we can't use custom base path mapping, as aws-serverless-express doesn't provide any means (since the function in question is in closure and as such can't be overridden) to "hack" around this, without altering the Lambda's code.
It is also clear that AWS APIGE won't fix this any time soon or ever.
What can you guys suggest?

Please see #86 for workarounds. We will fix this in the library in the future.

@dnutels Thank you so much for this write up. I've been pulling my hair out over this for a week and finally found this post.
🙏 thank you

@kwhitejr
We eventually abandoned the idea (which was to have a single consolidating APIGW for a set of similar deployment/scale-wise services, implemented as lambdas).
Right now we have an APIGW per Lambda, basically, with aliases (v1, v2, v3) pointing to different lambda aliases (alias-v1, alias-v2.2. etc.).
It wasn't an operational overhead for us, since it's in Terraform anyway, but you know... less moving parts, less money -- would have been nice.
Alas.


807: Authentication for UI in production mode

Description
Adds auth to the UI, in production mode.
When running the UI in dev mode (npm run dev) you shouldn't see the login.
When running in preview mode (npm run build && npm run preview) you should see the login.
Resolves #807
Screenshots
Normal Zoom:

150% Zoom:

200% Zoom:

Notes

A couple of accessibility weaknesses were identified, but unfortunately we don't have access to the Amplify components to correct them. The password show/hide button seems to work fine with NVDA, but it's not great with Narrator. Such is life.

Checklist
Have you done the following?

[x] Linked the relevant Issue
[ ] Added tests
[x] Ensured the workflow steps are passing

FYI @pmarsh-scottlogic, @dhinrichs-scottlogic


chore: keep track of the fail rate for each question

Proposal author: @Mattysal
It would be nice to have some stats on the most failed questions, in order to better focus on those topics.

Regarding this one, do we already have some sort of database to store such informations?
My idea is to add two counters for each question (using id reference), one storing how many times is shown and the other one storing how many times is answered wrong, so that we can calculate the error percentage.

Nope. Or not a real RDBMS, so far.
Please also take a look at the attached proposal, which is an extension of your nice idea.
These informations could be used to set the Project Team's priorities regarding development of freshman support materials.
I can assure you that we will discuss this improvement action in the near future ;)

Your proposal is great.
Our IT team should discuss on which DB to choose and how to run it.
The frontend part is just a call to the DB at the end, so it would not need much time.
I also thought to set a test score threshold (like 20%) to identify correctly done tests and avoid false positives in our data; in this way we also avoid dirtying the stats during our tests.


Clarify hosted vs self-hosted in twitter bio etc

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1964
Originally created by @DouweM on 2020-04-21 22:20:34

View 4 previous comments from the original issue on GitLab


Minimal support for downcasting to a custom transport type

This PR is an alternative to the approach in
https://github.com/trillium-rs/trillium/pull/432 , based on the comment at
https://github.com/trillium-rs/trillium/pull/432#discussion_r1379128491 .
I added methods on trillium_http::Conn to get a &Transport or &mut Transport.
I then added methods on BoxedTransport to downcast to a specific type
implementing Transport. I went with downcast methods on BoxedTransport
rather than exposing as_any() and as_mut_any() directly, because the latter
would have been the same amount of code and with a more complex interface.
With both of these changes, given a trillium::Conn, you can call
conn.inner().transport().downcast_ref() or
conn.inner().transport_mut().downcast_mut() to get your custom transport
type.
I think this is the minimal amount of support needed to make this possible.

This looks great, thanks!

@jbr CI is no longer failing. (Failure looked spurious, I rebased which also re-ran CI and it passes now.)

Unfortunately the failure wasn't spurious, but it is fixed!


Error "Could not load file or assembly Microsoft.TeamFoundation.Common"

I clicked "Finish" button in Pack/Deploy window and got the error "Could not load file or assembly 'Microsoft.TeamFoundation.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=<...>".
I use Visual Studio 2017.

I faced same issue.

Sorry,the dll was missing in my previous nuget package and fixed in V1.6.


ssr build / use client / broken global CSS import from package

Problem:
The imported CSS from a package or normal CSS file is in the production build but not loaded in the browser.
Example:
'use client';
import<EMAIL_ADDRESS>
or
'use client';
import "./puck.css";

pnpm waku dev 👍 - CSS is loaded
pnpm waku dev --with-ssr 👍  - CSS is loaded
pnpm waku build --with-ssr 👍
pnpm waku start --with-ssr 👎  - imported CSS is missing

No problem, if the import is in a server component above the client component in the tree!

Thanks for reporting!
This is probably hard, and we probably need to mix hoistable elements and vite css bundling. (Or, I'm not sure. 🤔 Why is dev working...
Can you try pnpm waku build and pnpm waku start? Should it fail too?

Can you try pnpm waku build and pnpm waku start? Should it fail too?
without SSR I get the same result

same result - CSS not loaded in the browser
I checked the files in the dist/public/assets folder (build with and without SSR) - the dist/public/assets/rsc4-6d73ab79e-KsjFJjAL.css does contain the needed CSS.
The CSS is not loaded in the browser.
I would not give this problem a high priority as there is currently a simple fix by loading global CSS in a server component in the tree above the client side component.

I would not give this problem a high priority as there is currently a simple fix by loading global CSS in a server component in the tree above the client side component.

Thanks for the note.

Why is dev working...

Ah, because Vite sends the css module through WebSocket.
I think I'd leave this issue for @Aslemammad.

Could you please assign me?

@aheissenberger #549 should fix this.

@aheissenberger #549 should fix this.

@Aslemammad yes this fixed it!

Thank you so much for the update!

#658 fixes this and it will be in v0.20.1!

Closing this as resolved. Let us know if it's not.


Agent should failed on SocketNotFoundException #280

If there are no matching candidate because a configuration mistake then the agent should failed.

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Jenkins please test this

@jitsi-jenkins I sign CLA now.

Do you have receive the CLA? Or do you need other information to continue with this PR?

Confirmed the CLA, thanks. I need to understand the change and make sure it doesn't break other cases, and I haven't had the time to do it yet. I'll try to get to it this week.

Any update on when this pull request will be merged? We ran into the same problem.

Hi, can someone please review this PR?

You are right. A listener should call ever outside of a synchronized.

Jenkins test this please


Linkfix: Adaptive cards (2021-05)

This PR is the result of running a Link Repair script on the included content. This script is primarily being run to cleanup links to function correctly in Air Gapped Clouds (AGC). Here's a breakdown of what the script that generated the changes in this PR fixes:

docs.microsoft.com Fully Qualified Domain Name (FQDN) Links to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not
azure.microsoft.com/documentation/articles that reflect to Docs to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not
All known flavors of MSDN/TechNet domains (we know of 8 or 9 now) that reflect to Docs to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not

This also includes cleanup of the appended query string for MSDN (redirectedfrom=MSDN).

Fixes articles that are redirected in .openpublishing.redirection.json and updates the link to the current final location (this has a lot of customer usability fixes).

Please note the Contributor Guide: Links has been updated with the following link-type preference order:
By order of preference, links hosted on Docs should be Relative if they are in the same repository and docset. If they are in a different docset, even if in the same repository, they should be Site Relative. Links to content hosted on Docs shouldn't use a complete URL, otherwise known as Fully Qualified Domain Names (FQDN). Using a complete URL from Docs to other content on Docs will cause that link to be non-functional in air-gap environments.

Microsoft Reviewers: Open in CodeFlow

Docs Build status updates of commit 0a16428:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9bd17bf:
:warning: Validation status: warnings

File
Status
Preview URL
Details

AdaptiveCards/getting-started/windows.md
:warning:Warning

Details

AdaptiveCards/getting-started/bots.md
:bulb:Suggestion

Details

AdaptiveCards/getting-started/windows.md

Line 15, Column 1: [Warning-alt-text-bad-value] Alt text 'Timeline' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

AdaptiveCards/getting-started/bots.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7af2063:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/getting-started/bots.md
:white_check_mark:Succeeded

AdaptiveCards/getting-started/windows.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off (bulk updates to links)

closing, will attempt again in next round of scans