Macbook heats up extremely fast when opening godot 4 beta 4

Bugsquad note: This issue has been confirmed several times already. No need to confirm it further.

Godot version
Godot 4 beta 4
System information
Mac os 13 2.3 GHz Dual-Core Intel Core i5 Intel Iris Plus Graphics 640 1536 MB
Issue description
HI,
I have a good macbook pro that can run pretty much anything without making too much of an effort. Running godot 3.5.1 is completely smooth and effortless in any circumstance.
But now with Godot4 beta 4, I just open a new empty Forward+ project, and a few seconds later the fan starts turning like crazy, the CPU and the GPU's temperature climbs up to 90ºC in a minute! I never experienced such a struggle from my computer and it is undoubtedly linked to Godot 4 running, since it happens even when nothing else is running in the background...
Steps to reproduce
Run Godot beta 4 on a macbook pro, I guess?
Minimal reproduction project
No response

Do you have the same issue with earlier 4.0 betas?

Can you enable Show Update Spinner in the editor settings and see if the spinner in the top-right corner spins continuously? This should not occur in an empty project.

The update spinner doesn't spin when nothing is moving. Also it is pretty much the same with the beta3. It seems though that with beta1 it isn't as bad, but still it doesn't have this "lightweight" feeling that the stable version has. Also I forgot to mention it occurs with the mono version.

@thomasdorone: Stable version is OpenGL, beta is Vulkan. Maybe your graphics drivers are bad for Vulkan?

I don't know, but even if so, I don't think my computer should start struggling on a completely empty project.

@Calinou : Currently i switched all of the project's rendering method to "gl_compatibility", this way my mac doesn't sweat after 2 minutes. But there must be some other way... it doesn't seem right that my mac works at full power on an empty project

I got same feeling or issue when using beta4, the editor will be lagy after some time, don't know what cause this issue

@snougo This is about heating up, not lag. I get lag in beta4 too, but without heating up

I recommend looking into compiling a debug build and running a profiler on it.

I have the same issue on a MacBook Pro (13-inch 2019, 2.4 GHz Intel Core i5, 16 GB RAM, Iris Plus Graphics 655 1536MB), running macOS 12.8 (Monterey).
Using beta4, as soon as I create an empty project (Forward+ or Mobile renderer, does not matter), the laptop gets incredibly hot within minutes.

There could be something new in macOS 13 contributing to this as well. I've been using 4.0.beta4 for a while now on macOS 12.6.1. The Godot editor started up quickly and I got a steady 120 fps framerate when running the project.
Today I upgraded to macOS 13.0.1 and now there's a couple of seconds spinning beachball-cursor both when opening the Godot editor and if I run a forward_plus project. If I use the mobile renderer the project is still fast to start. But regardless of renderer I now get just 60 fps in the same project, on the same hardware and Godot build.

Sorry, the framerate change actually seem to be a different issue. Turns out VSync was turned on in the project settings. I had assumed it was off since on macOS 12 it for some reason ran at 120fps on the same 60Hz monitor even though VSync was on? But now it's apparently correctly capping the framerate at 60fps on macOS 13.

Sorry, the framerate change actually seem to be a different issue. Turns out VSync was turned on in the project settings. I had assumed it was off since on macOS 12 it for some reason ran at 120fps on the same 60Hz monitor even though VSync was on? But now it's apparently correctly capping the framerate at 60fps on macOS 13.

See https://github.com/godotengine/godot/issues/64475.

Still the same in beta 5

Still the same in beta 6.
I'm using a macbook pro, and it's on Mac OSX 12.6.
RAM: 16GB
CPU: 2 GHz Quad-Core Intel Core i5
Graphics Card: Intel Iris Plus Graphics 1536 MB
Additionally, I don't know if anyone else is having these issues, but everything else on my laptop slows down as well. I use Firefox as to watch youtube and twitch streams while I work, and if I have Godot open, the video streams freeze and the sound jitters. Switching between windows also gets slower.
In general my laptop also freezes very often, almost every 30 seconds it hangs for 2-15 seconds if I'm not on Godot. While focusing on Godot, there isn't as much hanging.
In Activity Monitor, Godot doesn't use more than 10% CPU and usually it stays around 2%. In terms of memory, Godot uses about 1GB, and I usually have an additional 6GB free.
I tried to build and run a profilier on the editor but I got these error when I tried to open the build through command line:
ERROR: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
	vkCreateInstance: Found drivers that contain devices which support the portability subset, but the portability enumeration bit was not set!. Applications that wish to enumerate portability drivers must set the VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR bit in the VkInstanceCreateInfo flags andenable the VK_KHR_portability_enumeration instance extension.
	Objects - 1
		Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle<PHONE_NUMBER>58560
   at: _debug_messenger_callback (drivers/vulkan/vulkan_context.cpp:159)
ERROR: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
	vkCreateInstance: Found no drivers!
	Objects - 1
		Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle<PHONE_NUMBER>58560
   at: _debug_messenger_callback (drivers/vulkan/vulkan_context.cpp:159)
ERROR: Cannot find a compatible Vulkan installable client driver (ICD).

vkCreateInstance Failure
   at: _create_instance (drivers/vulkan/vulkan_context.cpp:710)
ERROR: Could not initialize Vulkan
   at: DisplayServerOSX (platform/osx/display_server_osx.mm:3236)

If anyone helps me figure out how I can fix this, lmk so I can profile this.
I used this command to build, let me know if it's incorrect:
scons platform=osx target=editor dev_build=yes use_lto=yes

(This is probably worth another issue, but the latest documentation pages linked by above by Calinou do not reflect the new buildsystem options, so I had to spend some time looking for the PR that updated them).

I can't reproduce this issue. I tried both with beta 6 and with latest from yesterday. In testing I had the update spinner showing and I tried both with and without constant movement to keep the update spinner spinning. I also tried disabling vsync and it had no impact. In all cases the temperature of the laptop did not rise and it did not appear to be working hard
MacOS 12.6.1 MacBook Pro Early 2015,  2.7 GHz dual core i5, 8 gb ram, intel iris 6100 graphics

Running v4.1.1.stable.mono on Ventura causes my Macbook Air fans to go crazy after a couple of minutes.
Activity monitor doesn’t show anything much though.

Activity monitor doesn’t show anything much though.

Try enabling Show Update Spinner in the Editor Settings, and look at the top-right corner of the editor. If the spinner is rotating continuously, then something is forcing the editor to redraw every frame, causing increased CPU/GPU utilization. This is usually caused by active AnimationPlayers, shaders using TIME, etc.

Hi,
I enabled the spinner and it is not rotating. This also happens when the app is minimised.
I made a new project with the renderer set as compatibility and its seems to be better (except I see this on the command line):
godot % Godot Engine v4.1.1.stable.custom_build.bd6af8e0e - https://godotengine.org
OpenGL API 4.1 INTEL-20.6.4 - Compatibility - Using Device: Intel Inc. - Intel(R) UHD Graphics 617
ERROR: Condition "!texture_allocs_cache.has(p_id)" is true.
at: texture_free_data (drivers/gles3/storage/utilities.h:111)
ERROR: Cubemap Arrays are not supported in the GL Compatibility backend.
at: texture_2d_layered_initialize (drivers/gles3/storage/texture_storage.cpp:763)
ERROR: Attempting to use an uninitialized RID
at: get_or_null (./core/templates/rid_owner.h:199)
ERROR: Condition "!t" is true.
at: texture_free (drivers/gles3/storage/texture_storage.cpp:705)
WARNING: Blend file import is enabled in the project settings, but no Blender path is configured in the editor settings. Blend files will not be imported.
at: _editor_init (modules/gltf/register_types.cpp:73)
I built the engine and attached the Xcode Time Profiler to it.

I have the same problem with a macbook pro 2019 using godot 4.1.1

Start temperature: 55°
Opening godot stopping at the project selection, temperature stays still
Opening a new empty project, after 2 minutes the temperature reached 90°
After closing it, the temp instantly starts decreasing back to 55°

Remember that Intel Macs are a few years old by now, and haven't aged very well from a performance standpoint. Thermals may also be affected by their thermal paste drying over time.
You should check with other demanding applications (such as modern 3D games) to see if you encounter similar issues.

Godot 4.1.1 Universal
Macbook Pro 13-Inch, 2019, Four Thunderbot 3 ports (2.45 Ghz Quad-core Intel Core i5, Intel Iris Plus Graphis 655 1536MB, 8GB ram), running Ventura 13.5.2. This machine will be supported with MacOS14, so the 'lifespan' is likely another year or more.
The issue starts on the Project Management screen for me! As soon as I open it!
Between coreaudiod and WindowsServer using somewhere between 10%-40% of the CPU cycles.
@Calinou Regarding that workaround, you need to extend it to include the project as when opening a project, opens another instance of Godot? But the issue is present for me even on the Project Manage screen.
In saying that, during development, you can go in to the Project and set the Audio driver to "Dummy" as soon as I do that WindowServer then runs about 10-15%.
Just realised most of the above is in this issue: #38154, and is/was in the 4.0 milestone?
I can't recall where, and it might be placebo, but then changing the Editor -> Editor Settings.. Interface->Editor-> Low Processor Mode Sleep (usec) to 27600 (defaults to 6900), Window Server seems to user much less CPU.
This is my first posting of an issue on Github, and just speculation.. I'm wondering if maybe the editor is running at an uncapped, or very high fps and that's maybe causing the high WindowServer issue?

Remember that the last Intel Macs are about 4 years old by now, and haven't aged very well from a performance standpoint compared to their Apple Silicon counterparts. (Intel was also in their dark times of pre-12th gen CPUs when Apple made their last Intel models.)
Intel MacBook thermals that were already problematic on release day may also have become worse due to their thermal paste drying over time. You should check with other demanding applications (such as modern 3D games) to see if you encounter similar issues.

With other programs like unity3d or blender I don't have this problem. I mean yes, the mac becomes a bit hot but after an hour or so of usage. With Godot 4.1.1 it goes from 55° to 90° as soon as I open it and goes down as soon as I close it.
The temperature doesn't go down even if I minimize it or even close the lid

You can also try running the Godot editor with the --audio-driver Dummy command line argument, which will reduce CPU usage a bit and allow the Mac to sleep as there won't be an audio server running in the background even when no audio is playing. This will prevent audio playback from working though.

I will try today what has been proposed and let you know. Meanwhile I can try some other test if you have some clue of how I can catch what's causing this

I'm not sure if it's better to edit or add a new comment for an update, forgive me if I'm wrong :)
I've set the audio driver to dummy and also changed the low usage sleep value with no luck.
But I also enabled the update spinner and it is always going on, even in an empty new project. I guess this is the cause of the heat up, let me know if I can do something to understand why it's happening!

If I use
Vulkan API 1.2.261 - Forward Mobile - Using Vulkan Device #0: Intel - Intel(R) UHD Graphics 617
my fans go crazy even after I minimise and suspend the process. This is with the audio driver set to Dummy.
Another project using:
OpenGL API 4.1 INTEL-20.6.4 - Compatibility - Using Device: Intel Inc. - Intel(R) UHD Graphics 617
is fine.
This laptop has been running Unity/Xcode/Visual Studio quite happily.
I attached ktrace to the process and could not see anything much- particularly after I suspended the process :-)
I'll take a look at what Godot does when it initialises the Vulcan API.

I just put Godot 4.1.1 stable mono on my old 12inch 2017 MacBook (1.2 GHz Intel with Intel HD Graphics 615) running
Monterey (12.6.5) and it seems to be happy with a mobile/vulkan project.
However vkcube on my newer Ventura 13.5.2 MacBook immediately starts heating the CPUs.

Additional testing similar to @HarrisonFor . Temperature shoots up if the Renderer is set to Forward+ or Mobile. If it is set to Compatibility, temperature is as 'normal'.
If I can provide any additional information, please let me know.

Additional testing similar to @HarrisonFor . Temperature shoots up if the Renderer is set to Forward+ or Mobile. If it is set to Compatibility, temperature is as 'normal'. If I can provide any additional information, please let me know.

Just to add another voice, I also tried and I confirm the heat up does not happen in compability mode!

If it doesn't heat up in compatibility mode (which doesn't have Vulkan AFAIK), and if vkcube does cause heat issues as well, maybe this is a macOS-specific Vulkan issue.

This is my first posting of an issue on Github, and just speculation.. I'm wondering if maybe the editor is running at an uncapped, or very high fps and that's maybe causing the high WindowServer issue?

Editor FPS is capped by V-Sync, but also a 145 FPS cap if your monitor refresh rate happens to be greater than 144 Hz.

I think I also have this issue on my 2016 macbook and none of the solutions described above work for me. It's very annoying.
I however found a workaround: if I stay in the compatibility mode and keep the editor in some little scenes without AnimationPlayer/AnimationTree then the CPU usage stays low. Without this workaround it's almost unusable since my mac literally burns me and loose its battery in less than 1h.

Godot 4.1.2 stable: the bug is still present and it is a bad one. I don't want to have continuous stress on my MacBook Air electronic with the fan always at 100%, even with an empty project. I usuall never hear the fan on my mac.
Has anybody from Godot dev team been able to at least replicate the issue? Must be pretty easy: it happens 100% of the time you just fire up the app and wait 5 minutes or less without even opening a project.

Has anybody from Godot dev team been able to at least replicate the issue? Must be pretty easy: it happens 100% of the time you just fire up the app and wait 5 minutes or less without even opening a project.

Most core contributors don't have an Intel-based MacBook. I'm not sure if @bruvzg has one available.

I have a very old Intel Macbookpro 13 2013 late, but I didn't have this issue, OS version is 13.7.10 and I use Godot 4.2 beta 2

I'm not sure if @bruvzg has one available.

No, I do not have any Intel Mac with functional GPU anymore. But from my personal experience, most of the Intel Macs constantly overheat for no reason. Apple's default fan curves are absolutely inadequate, and constant 70-80℃ is usual.
On M1 Mac, idle Godot editor use ~2% CPU (+2% of extra usage from CoreAudio), and I do not see any impact on WindowServer usage (it's constantly using ~20% regardless of Godot, most likely due to DisplayLink adapter in use).

Can anyone else test this? As far as I'm aware there's no way to disable the DPI scaling in the editor, but it would be useful to have.

Right-click the Godot application in Finder and choose Get Information. There should be a checkbox to disable hiDPI support (this works on any application).

That checkbox doesn't seem to exist anymore on the latest versions of MacOS but there's a workaround by going into Godot_mono.app/Contents/Info.plist and changing the key NSHighResolutionCapable from true to false (which seems to have the weird side effect of breaking where it finds dotnet? At least on my configuration. A fix to that is to start the editor directly from command line: '/Applications/Godot_mono.app/Contents/MacOS/Godot  -e --path path_to_project')
This does seem to have fixed it for me. The fans do come on, but it remains cool as opposed to molten-lava hot.

Can confirm this is still an issue in 4.3.dev5
The effect is strong even if the computer is asleep: if I put my MBP in sleep mode with godot opened, it will either kill the battery if unplugged, or get the computer heating up quite a bit.
@dbampersand I tried your workaround (changing that key) in non-mono godot, and it will open with the adjusted scale but wont be able to find any projects. Is that something you also encountered?

Maybe it would be helpful to compile Godot yourself and link the MoltenVK dynamically with the one that is working on your system ?

I'm not sure if more anecdotal reports are helpful, but here is my observation
2017 MBP (CPU: Intel Core i7, GPU: Intel Iris 640)
MacOS Ventura 13.6.6
Godot Engine v4.2.1.stable.mono.official [b09f793f5]
I was getting the same high temps and maximum fan speeds until I changed the rendering from Mobile to gl_compatibility
No other changes, my temps and fan are completely normal again

CPU: 2 GHz 四核Intel Core i5
GPU: Intel Iris Plus Graphics 1536 MB
MacOS: 14.4.1 (23E224)
Godot: 4.2.2.stable
has this issue like @kenny-adam

As made clear in the original post no new confirmation of this bug is needed, please only comment if you have new information that might help

Maybe it would be helpful to compile Godot yourself and link the MoltenVK dynamically with the one that is working on your system ?

Did that myself, but didn't make a difference.  So effectively I can't use my 2016 Macbook Pro (iGPU) to test my game on Forward+ (which my game is based on).
What helped me with the heating was that I had Display scaling enabled. Reset it to default, now it is at least a bit better...

I've had this issue for months, and it seems like it's finally gone away. I think I updated MacOS recently, so that might have been it. Here's my specs:
MacOS Version 15.0 (24A335)
Godot v4.4.dev2.official [97ef3c837]
2020 13 in Macbook Air
1.2 GHz Quad-Core Intel Core i7
Intel Iris Plus Graphics 1536 MB
16 GB 3733 MHz LPDDR4X


타이포그래피 Detail 추가

🤔 해결하려는 문제가 무엇인가요?
타이포그래피 Detail 추가

🎉 변경 사항

typo.ts 수정

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (761b41d) 95.90% compared to head (9130c49) 95.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   95.90%   95.91%   +0.01%
==========================================
  Files          39       39
  Lines         244      245       +1
  Branches       41       41
==========================================
+ Hits          234      235       +1
  Misses         10       10

Impacted Files
Coverage Δ

src/styles/typo.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Individual file names in the zipped file always show numbers

Hi Team,
We found a bug in the code causing index numbers (0, 1, 2... ), rather than the actual names, to be written as the file name inside the zip.
We've reviewed the code here: https://github.com/vertigis/workflow-activities-zip/blob/main/src/activities/Zip.ts
At line 35, the 'path' variable is the index number in the files. At line 37, the number is written to the zip as the file name.
The fix should be easy. Should be good if we just change line 37 to the following:

zip.file(content.name, content);

Would like to get this issue fixed sooner than later.
Thanks,
Johnny

What are you providing as the files input to the activity? The activity accepts an object whose keys are the desired paths in the zip file, and whose values are the file content.
Something like this:
={
 "file1.txt": "content1",
 "folder1/file2.txt": "content2"
}

From what you've described it sounds like you are providing an array of File objects.

Yes correct the input was an array of File Objects created by the Create File activity. e.g.
= [$file1.result, $file2.result, $file3.result]
I've tried adding the files to this activity using the following syntax, but it's not accepted.
={
$file1.result.name: $file1.result,
$file2.result.name: $file2.result,
$file3.result.name: $file3.result
}
The following does work however and produces the desired output.
={
"file1": $file1.result,
"file2": $file2.result,
"file3": $file3.result
}
Is there a reason the syntax $file1.result.name is not valid for the path?

You can't use something like $file1.result.name in the left-hand side of a JavaScript expression. You'd need to wrap it in [] like [$file1.result.name] to make it legal JS. However, Workflow doesn't accept that syntax.
You'll need to assemble the object a little more manually. You could use a Create Value and For Each with an Add Item to do this.
Or, you could use an expression like this to do it all in a single input:
=((files) => {
    var obj = {};
    for (let file of files) {
        obj[file.name] = file;
    }
    return obj;
})([$file1.result, $file2.result, $file3.result])


Make DnsNameResolverGroup non-final and overridable

Motivation:
There's no way to override the default settings of the DnsNameResolvers
created by DnsNameResolverGroup because DnsNameResolverGroup is final.
Modifications:

Make DnsNameResolverGroup non-final
Add a new overridable protected method 'newResolver()' so that a user
can override it to create an alternative DnsNameResolver instance or
set the non-default properties

Result:
A user can configure the DnsNameResolver.

@normanmaurer PTAL once you are back from vacation.

@trustin LGTM ... Please cherry-pick

Cherry-picked: 2fefb2f (4.1) and 86b8efa (master)


Pulse docs code no longer works

URL to the relevant documentation
https://docs.quantum.ibm.com/api/qiskit/pulse
Select all that apply

[ ] typo
[ ] code bug
[X] out-of-date content
[ ] broken link
[ ] other

Describe the fix.
One needs to change to the fake backends from Runtime, but if you do it complains about needing V2 fake backends due to deprecation, but then the drawer is looking for a configuration which V2 fake backends do not have (but should)

I would like to take a look at this!

Hey, Is this issue still open ? I can work on this if needed....
Also saw #12582

@divshacker assigned it to you


[Unity][il2cpp]'class' is not registered in this resolver,resolver.StandardResolver

if I use il2cpp to build my app,the app throw this exception when i used msgpack

i changed mono ,it is ok

Sorry for delay. But StandardResolver is the type of message pack for C#, its repository is here.


Fix docstring of config.py to use correct versionadded

Follow-up to #6414
The versionadded field of set_config should be 1.4.0, since global configuration won't be part of the upcoming 1.3.0 release.

Codecov Report

Merging #6458 (0e1b9aa) into master (fb56da5) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6458      +/-   ##
==========================================
- Coverage   80.15%   80.06%   -0.09%
==========================================
  Files          13       13
  Lines        3512     3512
==========================================
- Hits         2815     2812       -3
- Misses        697      700       +3

Impacted Files
Coverage Δ

python-package/xgboost/config.py
100.00% <ø> (ø)

python-package/xgboost/tracker.py
93.97% <0.00%> (-1.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb56da5...0e1b9aa. Read the comment docs.


Consider updating Spotless to 3.0.0+.

durian is using a very old version of the eclipse formatter.  Upgrade might cause format changes, old versions still works fine.  Codebase is tiny too, so perf improvements from 3.x don't mean much in this context.


Allow flexible SMASH selection without restarting the wallet

Context
Currently the wallet needs to be restarted when selecting a SMASH server via cli:
wallet serve --smash-url URL

Daedalus developers would like to have an endpoint to change the smash server while the wallet is running.
Decision
1 implement the following endpoint: curl -X PUT --data '{ "settings": { "pool_metadata_source": "my.smash.uri" } }' http://localhost:8090/v2/settings/ ... possible values are direct, none and an actual url
2. The settings will be stored in the database in a separate table as a single row with one column per setting (as text or json).
3. The sync thread will poll the database for the setting.
4. On PUT, the metadata table will be dropped, forcing it to re-sync automatically with the new setting.
5. When selecting SMASH server on wallet start, compare against database setting and drop the metadata table if they diverge.
Rationale

simple and extendable
Alternative would be ephemeral state, but that's more complicated implementation-wise and would require daedalus to have a persistent state about the smash setting.
Simplicity of implementation. Otherwise we need a way to restart the sync thread, which also requires mutable ephemeral state.
see AC
see AC

Acceptance Criteria

The user can select the SMASH server at wallet start
The user can select the SMASH server after wallet start without restarting the wallet
Changing the SMASH server causes a re-sync of the metadata

Development
https://github.com/input-output-hk/cardano-wallet/pull/2156
QA

integration test for Settings change: https://github.com/input-output-hk/cardano-wallet/pull/2214/files#diff-ee9ceec3a14de991a6d049756e4830a4
json roundtrip test for SettingsPutData: https://github.com/input-output-hk/cardano-wallet/pull/2214/files#diff-aa8e2781f330251ae7904f42941b1de2
updated swagger definition: https://github.com/input-output-hk/cardano-wallet/pull/2214/files#diff-6816a7fbd0d7c7e715b8225b1709c612

@piotr-iohk I updated QA section

LGTM.
Additional integration test added in #2225. (Hopefully can be merged some day...)


js-debug debugger terminal discoverability

We want to explore ways to increase the discoverability of the debugger terminal. The entrypoints we have today are:

Command palette: undiscoverable
Debug welcome view: good discoverability, but only if you don't have a launch config
Scripts in package.json: this isn't the terminal itself, but is a common use case, good indirect discoverability.

Thing we can improve:

[x] Contribute the debugger terminal into the Run and Debug dynamic configurations. Good discoverability, easy and no overhead.

[ ] Kai suggested contributing a button to the debug terminal toolbar, in this area

We would be careful to only do this if the workspace contains javascript files. @Tyriar thoughts?

👍 to adding a new button to the terminal toolbar. Or even a debug button or something to turn a regular terminal into a debug one (if that is possible).

Hmm, it's already fairly busy up there with the dropdown and 5 buttons. Looking ahead a little bit, how would this interact with a future shell selector/tabs that I'm hoping to have similar to Windows Terminal:

Would debug terminal be a shell entry in the dropdown, using your default shell by default? Allowing you to enable it on any shell in a custom profile (similar to this](https://github.com/Tyriar/vscode-shell-launcher#settings))?

Something like that could work well. The debug terminal is a little 'weird' because it's a mode that can apply to any terminal, but we could just say it uses your default terminal and can be configured differently as desired.
I'm not sure if it's a pattern we use anywhere, but photoshop has these little arrows in the lower right of buttons to indicate you can click it or expand it. We could do something like that to avoid needing a separate button.

@connor4312 do you know if theres a shortcut to cycle between Debug, Terminal, Output and problems?
Sometimes i need to go back and forth between Terminal and Debug.
I know ctrl + ` gets you to Terminal, but doesn't look like its possible to get back

@jasonwilliams you can add keybindings for workbench.action.nextPanelView and workbench.action.previousPanelView

One alternative Kai and I talked about last week is using the dropdown

In addition to "select default shell", "Create new terminal" could be one of the actions and/or extensions could contribute other actions to the area.

@connor4312 sounds like a good solution until we gets the tabs/new terminal dropdown separation 👍

One more suggestion. Kai and I talked about having some button in this area

This is a natural place for discoverability. I have two questions for this area:

There's already a button for the debug console which is a nice bug + terminal icon, which is also a very natural icon for the debug terminal. Is there a way we can differentiate the debug terminal enough from those existing icons?

This area gets crowded with a small sidebar. We should make sure it doesn't get too crowded.

The "run" title is standard on all views but probably irrelevant for the non-welcome debug view, since people's launch configs will already often say something like "Run app" or "Attach to extension host"
We could hide the debug console icon while a session is not currently in progress. It's always read-only then.
Some limit on how extensions can show a button there? For js-debug I would only show this when debugStartLanguage is js or ts.

cc @isidorn

@connor4312 makes sense to make the js-debug terminal more discoverable. Please note that we are adding ... button in all views to make hidden views more discoverable. More details here https://github.com/microsoft/vscode/issues/98614
Due to that I see two good options:

We make the ... contributable such that js-debug can contribute a js-debug terminal action there
We make the behavior of the click on console contributable, so in the js-debug case this would open the js-debug terminal. I would dislike to have both of these actions as I think it can be quite confusing for users what is what.

Also for considerations look into a case the debug toolbar is docked via a setting in that area. Then we do not show these actions.

We make the behavior of the click on console contributable, so in the js-debug case this would open the js-debug terminal

I don't like the idea of installing an extension changing the behavior of an existing button in the UI.
A ... menu contribution would work 🙂

@connor4312 ok for this I have created
https://github.com/microsoft/vscode/issues/100771
Unfortunetly I will probably not have time for this this week, and from end of next week I am on a long vacation. So let me know if you need it before so I provide some code pointers so you can also maybe look into it.
If it is ok to do it in August then I can also jump on it.

Sounds good. Closing this out as everything else is completed.


[Feature] Option to add different port number instead of default port 80

Is your feature request related to a problem? Please describe.
I have set my OMV default admin port number to 5001. I tried adding the url with the port number in OMV like: <IP_ADDRESS>:5001. I get most of my devices. So it sees the installation and retrieves the info. However, I see a lot of error logs with "No response".
For some reason the port number is not always used.
Describe the solution you'd like
I would like to see an extra field for the port number during the setup. Default value would be 80. The default value should be adjustable.
Describe alternatives you've considered
Add the port number in the url. Like described above. Like: <IP_ADDRESS>:5001. However, an extra field would be more clear to users.

Port definition works fine within host field, additional field dedicated to port is not necessary. Port is always used, so that is not the issue.
You will need to debug the integration to find more information.

https://github.com/tomaae/homeassistant-openmediavault#enabling-debug

Logs don't show anything extra except for what I posted above here.

It seems that the problem as resolved itself. The errors suddenly don't show anymore. I assume it has to do with a reboot of the system.


The player only works. 2 time out of 3

hmmm i will belive that´s a javascript thing..
Error one
The player stops and just say DOWNLOADING.. nothing more
WHY ?
Error Two
The subtitles rutine fucks up with danish it not showing ÅÆØ
Will guess that it is the source
The Red lock ? what does it ?
I doing this like that

I have the same error one.
Did you solve it???


Check tests and tutorials against terra master

[ ] community/ignis
[ ] community/aer
[ ] qiskit/ignis
[ ] qiskit/aer
[ ] Ignis tests
[ ] Aer tests

community/ignis/gate_errors.ipynb: ok with Terra; I noticed that the only code is an import section.

After #159, the only Ignis test that has warnings is:
test_bell_2_qubits (test.tomography.test_process_tomography.TestProcessTomography) ... /opt/anaconda3/envs/YaelEnv/lib/python3.6/site-packages/numpy/matrixlib/defmatrix.py:71: PendingDeprecationWarning: the matrix subclass is not the recommended way to represent matrices or deal with linear algebra (see https://docs.scipy.org/doc/numpy/user/numpy-for-matlab-users.html). Please adjust your code to use regular ndarray.
  return matrix(data, dtype=dtype, copy=False)
ok

I think owners of the tomography module should fix this one, as I don't want to create any damage.
@gadial @chriseclectic

I've updated https://github.com/Qiskit/qiskit-ignis/issues/154#issuecomment-483953944 with the current status

Due to https://github.com/Qiskit/qiskit-ignis/pull/161 we need to fix the process_tomography notebook

Done in Qiskit/qiskit-tutorials#589


Adding MongoDB infrastructure

This is using statefulset and not through the enterprise operator.

@ekuric can you please review this work, and point out anything that I might be missing. You've more experience with running ycsb against mongodb so adding you here.

/rerun all

/rerun all

/rerun dev-scripts

@dustinblack implemented the finalizer here, because repeated mongo tests would fail as the pvs aren't deleted

/rerun minishift

/rerun minikube

/rerun minishift

/rerun minishift

/rerun all

closing this out following #122 merge

closing this re: #121 and this made its way into https://github.com/cloud-bulldozer/cloud-builder


Authenticating proxy based on target URL

I've got my proxy working, but there are some URLs that I know the backend will return 403 unauthorized for depending on the API path and the properties of the current user - which is available in my existing session.
I'm trying to figure out where the best place to put such logic would be, I can write a function shouldBeAllowed(apiPath, userSession), but I can't find a spot where this would work.
If I pass it as the context argument, then I get the path before re-writes - which isn't the end of the world but seems a bit untidy.
If I use this function instead onProxyReq, I have all the information I need but I can't see how to abort the proxy request.
Any ideas?
Setup

http-proxy-middleware: 0.17.3
server: express 4.14.0

proxy middleware configuration
  app.use("/api", proxy({
    target: config.apiServer,
    pathRewrite: {"^/api": ""},
    xfwd: true,
    secure: true,
    changeOrigin: true,
    logLevel: "silent",
    headers: {
      cookie: ""
    },
    onProxyReq: (proxyReq, req) => {
      const user: User = req.session.user;
      // Convert session authentication into API authentication
      proxyReq.setHeader("Authorization", buildAPIAuth(user));
      req.log.info(
        {method: proxyReq.method, path: proxyReq.path},
        "proxying request"
      );
    }
  }));

Sorry for the late reply @glenjamin .
Did you try using multiple middleware to achieve the result?
Basically use/write a different middleware to add the authentication, before proxying the request.


Intra-doc links getting borked with a sufficiently complicated workspace

Problem
There are doc links that sometimes refuse to work, I found a reproducible way of witnessing it.
Steps
Make sure rust-analyzer is not running for reproducibility. clone doc-bug, run cargo clean and cargo doc --open at the root of the workspace. Click on the awint_macros crate in the "Crates" list and scroll all the way to the bottom of the lib docs (I can't reduce further because it causes the problem to go away). There is a broken doc link with the literal text [awint_macro_internals::awint_macro_inlawi] towards the bottom.
Then, go to the source code awint/awint_macros/src/lib.rs and make some dummy change like adding a "// hello" comment somewhere. Run just cargo doc and refresh, now the doc link is no longer broken.
Possible Solution(s)
No response
Notes
It probably has to do with cargo-doc getting confused when there are multiple transitive dependencies and multiple reexports of items. Recompiling sometimes breaks or fixes it strangely.
Version
cargo 1.69.0-nightly (985d561f0 2023-01-20)
release: 1.69.0-nightly
commit-hash: 985d561f0bb9b76ec043a2b12511790ec7a2b954
commit-date: 2023-01-20
host: x86_64-pc-windows-msvc
libgit2: 1.5.1 (sys:0.16.1 vendored)
libcurl: 7.86.0-DEV (sys:0.4.59+curl-7.86.0 vendored ssl:Schannel)
os: Windows 10.0.19045 (Windows 10 Home) [64-bit]

Thanks for the report! I'm closing as a duplicate of #8487. The problem is that Cargo is not tracking the dependencies between rustdoc invocations. It allows them to run concurrently, which causes a race condition.

Ok, I feel like I have been encountering this sporadically for a while, I hope it is fixed sometime

I'm going to reopen since further investigation looks like this is a different issue. The following is a test for this scenario:
#[cargo_test]
fn virtual_ws_proc_macro() {
    // A workspace with a proc-macro with a dependency into the workspace.
    // This creates a situation where some units are "for host" and some are
    // "for target". The unit sharing code should combine them, so the doc
    // deduplication system should only end up with a single copy, and it
    // should have its dependencies wired up correctly so that intra-doc links
    // work.
    let p = project()
        .file(
            "Cargo.toml",
            r#"
                [workspace]
                members = ["pm", "bar"]
            "#,
        )
        .file(
            "pm/Cargo.toml",
            r#"
                [package]
                name = "pm"
                version = "0.1.0"
                edition = "2021"

                [lib]
                proc-macro = true

                [dependencies]
                bar = {path = "../bar"}
            "#,
        )
        .file(
            "pm/src/lib.rs",
            r#"
                use proc_macro::TokenStream;
                /// See [bar::example]
                #[proc_macro]
                pub fn links_to(input: TokenStream) -> TokenStream {
                    "".parse().unwrap()
                }
            "#,
        )
        .file("bar/Cargo.toml", &basic_manifest("bar", "0.1.0"))
        .file(
            "bar/src/lib.rs",
            r#"
                /// Example docs.
                pub fn example() {}
            "#,
        )
        .build();
    // Run check first to emphasize the chance of a race condition if things
    // aren't working correctly.
    p.cargo("check").run();
    p.cargo("doc").with_stderr("").run();
    let contents = p.read_file("target/doc/pm/macro.links_to.html");
    assert!(contents.contains(r#"<a href="../bar/fn.example.html""#));
}

The problem is that Cargo generates a build graph with a duplicate for the pm package. When the deduplication code here removes those duplicates, it deletes the edges without replacing them to the version of pm that gets documented. In detail:
The initial unit graph looks like:
bar doc target
bar check host
pm doc host
    -> bar check host
    -> bar doc host
bar doc host

After doc deduplication, it looks like:
bar doc target
bar check host
pm doc host
    -> bar check host

Here the edge from pm doc to bar doc has been removed.
This particular case can be resolved by doing doc deduplication after unit sharing and removing the "prefer target over host" code. However, that breaks situations where either the units differ by profiles (illustrated in collision_doc_profile_split), or they differ by features (illustrated in decouple_proc_macro).
The profile distinction could possibly be solved by using a dummy profile for doc units. rustdoc doesn't use profiles, so the distinction is not useful.
The feature distinction is harder. I think one solution is to prefer the target doc units over the host doc units, but instead of removing the host doc unit edges here, they need to instead be replaced by the host doc units, but only if --target was not specified (with --target, this isn't an issue since the doc directories are separate).
That's starting to get quite complicated, and I'm concerned about trying to be too clever will introduce more problems.  https://github.com/rust-lang/cargo/issues/10241#issuecomment-1003761078 contains some thoughts on a longer-term solution, though some of the changes suggested here (such as using a common profile) might still be worth adding.


feat: support loading eetq quantized model

What does this PR do?

Fixes #391
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
to it if that's the case.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@tgaddair thanks

will revisit again after the #399 resolved.

@SidaZh is that possible help have a check this integration?


Difficult to read explanations in UI

When using shap to understand in which parts of the text the model its putting attention on, the following happens:

As the probabilities of some transformers are heavily located on the extremes (or really close to 0 or to 1), the colours on the shap representation are very dark and it's difficult to read the words inside to make an analysis. Just by changing the intensity of this colours would be enough.

Hi @saraesteveznewtral, there is definitely a reading and usability problem, we will improve it as soon as possible. thank you for reporting


Update two dependencies

This updates

xmldom from v0.3.0 to v0.4.0
node-pre-gyp from v0.15.0 to v0.17.0

npm test still passes for me.

Thanks for the review.


Create NU5501.md

Ref: https://github.com/NuGet/NuGet.Client/pull/3692#discussion_r497879048

Docs Build status updates of commit f879b7d:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit f879b7d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/errors-and-warnings/NU5501.md
:warning:Warning
View
Details

docs/reference/errors-and-warnings/NU5501.md

Line 5, Column 12: [Warning-ms-author-invalid] Invalid value for 'ms.author', 'zkat' is not a valid Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 08ec231:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 08ec231:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/errors-and-warnings/NU5501.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 68843ad:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/Errors-and-Warnings.md
:warning:Warning
View
Details

docs/reference/errors-and-warnings/NU5501.md
:white_check_mark:Succeeded
View

docs/reference/Errors-and-Warnings.md

Line 5, Column 12: [Warning-ms-author-invalid] Invalid value for 'ms.author', 'karann' is not a valid Microsoft alias.
Line 2, Column 8: [Suggestion-duplicate-titles] Title 'NuGet Errors and Warnings Reference' is duplicated in: 'reference/Errors-and-Warnings.md(2,8), reference/errors-and-warnings/NU1102.md(2,8), reference/errors-and-warnings/NU1106.md(2,8), reference/errors-and-warnings/NU1108.md(2,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8955168:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/Errors-and-Warnings.md
:warning:Warning
View
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU5501.md
:white_check_mark:Succeeded
View

docs/reference/Errors-and-Warnings.md

Line 5, Column 12: [Warning-ms-author-invalid] Invalid value for 'ms.author', 'karann' is not a valid Microsoft alias.
Line 2, Column 8: [Suggestion-duplicate-titles] Title 'NuGet Errors and Warnings Reference' is duplicated in: 'reference/Errors-and-Warnings.md(2,8), reference/errors-and-warnings/NU1102.md(2,8), reference/errors-and-warnings/NU1106.md(2,8), reference/errors-and-warnings/NU1108.md(2,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 164e3be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/Errors-and-Warnings.md
:bulb:Suggestion
View
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU5501.md
:white_check_mark:Succeeded
View

docs/reference/Errors-and-Warnings.md

Line 2, Column 8: [Suggestion-duplicate-titles] Title 'NuGet Errors and Warnings Reference' is duplicated in: 'reference/Errors-and-Warnings.md(2,8), reference/errors-and-warnings/NU1102.md(2,8), reference/errors-and-warnings/NU1106.md(2,8), reference/errors-and-warnings/NU1108.md(2,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Converting to draft until https://github.com/NuGet/NuGet.Client/pull/3692#discussion_r497879048 is finalized.

@zkat Should we re-review this PR now that https://github.com/NuGet/NuGet.Client/pull/3692#discussion_r497879048 is merged?

I made the changes here, can someone else approve @NuGet/nuget-pm @NuGet/nuget-client

Docs Build status updates of commit c504ac0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:bulb:Suggestion
View
Details

docs/reference/Errors-and-Warnings.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU5501.md
:white_check_mark:Succeeded
View

docs/TOC.md

Line 67, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /azure/devops/artifacts/nuget/publish?view=azure-devops. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Significant load-time improvements for startup & order book

This branch has optimizations for the portfolio and orderbooks, with the goal of the near-instant opening of those pages.
Changes:

Optimized the loop inside the loadWalletSnapshot
Db.getCurrentWallet() is now passed into loadWalletSnapshot, instead of querying it inside
loadWalletSnapshot is called a lot earlier at launch, for faster portfolio initialization
Optimized getWalletSnapshot DB query
Add Coin buttons on the Portfolio page now hides the loading spinner until the user taps on them
All Orderbooks of the enabled coins with portfolio balance are prefetched for instant access later on
Bulk-fetching Orderbook requests complete a lot faster, as they running asynchronously now
Orderbooks are prefetched at launch, and every minute
OrderbookDepths are not fetched anymore. Instead, they are calculated from the Orderbooks
Added functionality to save and load Orderbook Snapshots. Currently not in use since they are being fetched anyways

Needs deep testing.

@kivqa Could you please test these changes? Very critical stuff.


Add a quicker Rem

Right now all implementations of Rem return a BigUint and are somewhat slow.
Due to the fact that a % b < b is always true, we might want to change Rem to return a value of type b instead of a.
I have implemented a somewhat faster version of Rem and ran some benchmarks:

xbits
old
new
old (bigger is better)

4
51,257 ns/iter (+/- 22,916)
10,864 ns/iter (+/- 9,191)
4.72

6
67,351 ns/iter (+/- 44,639)
23,170 ns/iter (+/- 19,247)
2.91

8
132,859 ns/iter (+/- 54,852)
75,033 ns/iter (+/- 6,360)
1.77

10
399,424 ns/iter (+/- 75,839)
346,401 ns/iter (+/- 2,146)
1.153

14
5,957,626 ns/iter (+/- 394,632)
5,986,485 ns/iter (+/- 1,919,245)
1.00

18
96,009,267 ns/iter (+/- 12,585,847)
94,161,577 ns/iter (+/- 15,044,440)
1.02

Relevant because of this test for truncatable primes which is three times faster when using quick_reminstead of the current implementation.

Before adding a new separate method, I think we can improve on the normal operator.

Right now all implementations of Rem return a BigUint and are somewhat slow.

The output is one consideration, but I think the bigger issue for performance is that we're always computing the quotient and remainder together, just to return the latter.
https://github.com/rust-num/num-bigint/blob/eb003cc41b604658c885c052583ea9f453f9c910/src/biguint.rs#L1010-L1018
Currently we always need self by value (requiring a clone if we start with LHS as a reference), because div_rem_digit will write the quotient in place. I think we could change this to a simpler rem_digit which takes the LHS by reference, and doesn't need to build the quotient at all.

Due to the fact that a % b < b is always true, we might want to change Rem to return a value of type b instead of a.

That's a reasonable possibility, but it would be a breaking change.

will do


StorageSample harvest tests failing in old distributions

The following storage metrics are not available in some old Linux distributions:
TotalUtilizationPercent, ReadBytesPerSec, WriteBytesPerSec, ReadWriteBytesPerSecond, ReadsPerSec, WritesPerSec, ReadWriteBytesPerSecond
Harvest tests code: https://github.com/newrelic/infrastructure-agent/blob/master/test/harvest/storage_sampler_linux_test.go#L64
Canaries distributions that are failing:

debian-jessie
debian-bullseye
Amazon Linux 2022 (check if latest released AMI solves the problem)

The affected metrics are generated from /proc/diskstats information.

Failing canaries:
amd64:al-2022              : ok=3    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0
amd64:sles-15.2            : ok=3    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0
arm64:al-2022              : ok=3    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0
arm64:debian-bullseye      : ok=3    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0
arm64:sles-15.2            : ok=3    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0
arm64:ubuntu21.04          : ok=3    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

For sles-15.2:
--- FAIL: TestRpmPlugin (30.01s)
    rpm_test.go:48:
        	Error Trace:	rpm_test.go:48
        	Error:      	timeout while waiting for a response
        	Test:       	TestRpmPlugin

Ubuntu 21.04:
--- FAIL: TestStorageSample (0.00s)
    storage_sampler_linux_test.go:64:
        	Error Trace:	storage_sampler_linux_test.go:64
        	Error:      	Expected value not to be nil.
        	Test:       	TestStorageSample


Logo is not displayed from site peviitor.ro

URL: https://peviitor.ro/
browser: Microsoft Edge
device: Computer
OS: windows

Steps to reproduce

1.Open peviitor URL
2.Put the name "Nolimits" in the search field
3.Press the button "Caută"
4.You will saw that the logo not appeared

Expected results

Logo to appear on the "peviitor.ro" site

Actual results

Logo not appear on the "peviitor.ro" site

Fixed!


Build fails with: build.native: [ERROR] key -r: Unknown key.

On current master the build is failing.
$ make build
Read 0 sample input sentences and 0 error messages.
The auto-generated comments in src/reason_parser.messages have been re-generated. The old messages file has been backed up at src/reason_parser.messages.bak
cp pkg/META.in pkg/META
ocamlbuild -use-ocamlfind -package topkg pkg/build.native
Finished, 1 target (0 cached) in 00:00:00.
Finished, 4 targets (0 cached) in 00:00:00.
./build.native build -r src/reason_parser.ml -r src/menhir_error_processor.native
build.native: [ERROR] key -r: Unknown key.
make: *** [Makefile:21: preprocess] Error 1

It seems that the use of -r was introduced in https://github.com/facebook/reason/commit/0532c87b7fab9e07af238e980736a51bb26d15e8.
I'm on Linux, x86_64.

I had to do the following to get dependencies to properly update:
opam pin remove reason
opam pin add -y reason .

The -r flag was added in latest topkg.


Shutter/cover rts my

Did you read the instructions?

[X] I have read the README, including the advanced debugging section.

The problem
Hello.
i have a shutter rts somfy in home assistant via  this integration. I can open/close or stop the shutter. It is seen as a cover. But « my » position is not available.
I see no button to add or else in my device. I only have up down stop controls.
In tahoma application, « my » is available for my shutter. So is it a bug, or a new feature?
What version of this integration (ha-tahoma) has the issue?
2.12.1
What version of Home Assistant Core has the issue?
Core-2021-12-10
Which gateway / hub do you use?
DynamicShutter
Device model
No response
Home Assistant log
Logs
Copy/paste any log here, between the starting and ending backticks

Additional information
No response

Can you add some screenshots of the device page? And please turn on debug mode and add your log here.
If your device supports the 'my' command, a button should be visible.

for the logs, where can I turn them on and also find them?
Thank for your help.

Attributs for the entity are:
assumed_state: true
device_class: blind
friendly_name: Volet cuisine
supported_features: 11

@Vanntag did this ever work for you in ha-tahoma? Your device doesn't have a my command, thus we don't add a button.
Commands
[CommandDefinition(command_name='close', nparams=0),
CommandDefinition(command_name='goToAlias', nparams=1),
CommandDefinition(command_name='identify', nparams=0),
CommandDefinition(command_name='open', nparams=0),
CommandDefinition(command_name='saveAlias', nparams=1),
CommandDefinition(command_name='setName', nparams=1),
CommandDefinition(command_name='setNodeDefinition', nparams=3),
CommandDefinition(command_name='stop', nparams=0)]),
What you could do is execute the command via tahoma app, and run tahoma.get_execution_history() in Home Assistant. Now share your log. (see readme for more details).

No I have install the integration today, so it s never work. But in tahoma application it’s working.
for the history there is a problem:
2022-01-27 20:19:16 DEBUG (MainThread) [custom_components.tahoma] Finished fetching device events data in 0.135 seconds (success: True) 2022-01-27 20:19:19 INFO (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Running websocket_api script 2022-01-27 20:19:19 INFO (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Executing step call service 2022-01-27 20:19:19 ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Unexpected error for call_service at pos 1: '-' is not a valid ExecutionSubType Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 381, in _async_step     await getattr(self, handler)()   File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 584, in _async_call_service_step     await service_task   File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call     task.result()   File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service     await handler.job.target(service_call)   File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 733, in admin_handler     await result   File "/config/custom_components/tahoma/__init__.py", line 175, in handle_get_execution_history     await write_execution_history_to_log(coordinator.client)   File "/config/custom_components/tahoma/__init__.py", line 202, in write_execution_history_to_log     history = await client.get_execution_history()   File "/usr/local/lib/python3.9/site-packages/backoff/_async.py", line 133, in retry     ret = await target(*args, **kwargs)   File "/usr/local/lib/python3.9/site-packages/pyoverkiz/client.py", line 450, in get_execution_history     execution_history = [HistoryExecution(**h) for h in humps.decamelize(response)]   File "/usr/local/lib/python3.9/site-packages/pyoverkiz/client.py", line 450, in <listcomp>     execution_history = [HistoryExecution(**h) for h in humps.decamelize(response)]   File "/usr/local/lib/python3.9/site-packages/pyoverkiz/models.py", line 612, in __init__     self.execution_sub_type = ExecutionSubType(execution_sub_type)   File "/usr/local/lib/python3.9/enum.py", line 384, in __call__     return cls.__new__(cls, value)   File "/usr/local/lib/python3.9/enum.py", line 702, in __new__     raise ve_exc ValueError: '-' is not a valid ExecutionSubType 2022-01-27 20:19:19 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [548015218496] Error handling message: Unknown error Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 27, in _handle_async_response     await func(hass, connection, msg)   File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 527, in handle_execute_script     await script_obj.async_run(msg.get("variables"), context=context)   File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 1260, in async_run     await asyncio.shield(run.async_run())   File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 363, in async_run     await self._async_step(log_exceptions=False)   File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 381, in _async_step     await getattr(self, handler)()   File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 584, in _async_call_service_step     await service_task   File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call     task.result()   File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service     await handler.job.target(service_call)   File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 733, in admin_handler     await result   File "/config/custom_components/tahoma/__init__.py", line 175, in handle_get_execution_history     await write_execution_history_to_log(coordinator.client)   File "/config/custom_components/tahoma/__init__.py", line 202, in write_execution_history_to_log     history = await client.get_execution_history()   File "/usr/local/lib/python3.9/site-packages/backoff/_async.py", line 133, in retry     ret = await target(*args, **kwargs)   File "/usr/local/lib/python3.9/site-packages/pyoverkiz/client.py", line 450, in get_execution_history     execution_history = [HistoryExecution(**h) for h in humps.decamelize(response)]   File "/usr/local/lib/python3.9/site-packages/pyoverkiz/client.py", line 450, in <listcomp>     execution_history = [HistoryExecution(**h) for h in humps.decamelize(response)]   File "/usr/local/lib/python3.9/site-packages/pyoverkiz/models.py", line 612, in __init__     self.execution_sub_type = ExecutionSubType(execution_sub_type)   File "/usr/local/lib/python3.9/enum.py", line 384, in __call__     return cls.__new__(cls, value)   File "/usr/local/lib/python3.9/enum.py", line 702, in __new__     raise ve_exc ValueError: '-' is not a valid ExecutionSubType

Sorry, I edited my previous message just before you replied.

It seems that your device is quite special and I am not sure if we can support this on short-term. Do you use this feature a lot?

What if you press the stop button, will that do the same?

 If i press stop button, it just stop. And if I press again, nothing happen. So it’s a new feature? So I have to create a new feature request? I understand if you don’t implement it tomorrow :-)

@Vanntag Sorry to jump in this topic, but I see you are using an hub we didn’t know. Can you please restart HA, and look for a log: 'xxxx' is not a valid Gateway? I will add it to our list.
About your question, we already support My feature, but your case is not usual, so we have to understand how it works.

@tetienne I restart HA, but all I've found is:
2022-01-27 21:25:58 WARNING (MainThread) [pyoverkiz.enums.gateway] Unsupported value 99 has been returned for <enum 'GatewayType'>
Is it what you are looking for?
Or otherwise I have this:
2022-01-27 21:25:59 DEBUG (MainThread) [custom_components.tahoma] Added gateway (Gateway(partners=[], functions='', sub_type=<GatewaySubType.TAHOMA_BASIC_PLUS: 2>, id=****-****-1038, gateway_id=****-****-1038, alive=True, mode='ACTIVE', place_oid='622cb1d9-046d-4124-97f2-3fd9d1b105cf', time_reliable=True, connectivity=Connectivity(status='OK', protocol_version='1'), up_to_date=True, update_status=<UpdateBoxStatus.UP_TO_DATE: 'UP_TO_DATE'>, sync_in_progress=False, type=<GatewayType.UNKNOWN: -1>))
But that 's all.

@Vanntag Thx it’s well what I was looking for.

@Vanntag Which gateway / hub do you use?

I’m using the new « kit de connexion » from Somfy. It only have rts and io protocols.

I just realize where maybe the problem came from. My shutter is from the brand « simu ». They are using rts protocol from somfy. Maybe this is why « my » is not enable? Even if it is in tahoma application.
I hope it will help you. Thanks again for your help and your time.

@Vanntag we need to implement this in a different way, and will do in the coming weeks! Currently active development is paused until we port everything from core, but we at least know where to look now.
CommandDefinition(command_name='goToAlias', nparams=1)

State(name='core:SupportedAliases', type=<DataType.JSON_ARRAY: 10>, value=[{'id': '1', 'type': 'favorite1', 'features': ['openClose']}])

@Vanntag this is now merged into core and will hopefully ship this or next version.


Getting error     'An unknown error occurred.' while executing code , Looks like zerostep API is not getting hit.

Code used :
import { test } from '@playwright/test';
import { ai } from '@zerostep/playwright';
test('zerostep example', async ({ page }) => {
await page.goto('https://zerostep.com/');
// An object with page and test must be passed into every call
const aiArgs = { page, test };
const headerText = await ai('Get the header text', aiArgs);
await page.goto('https://www.google.com/');
await ai(Type "${headerText}" in the search box, aiArgs);
await ai('Press enter', aiArgs);
})
Zerostep api key is used in environment variable and its returning after doing echo in dev IDE(Visual studio code)
Error:
Running 1 test using 1 worker
✘  1 ai_test.spec.ts:4:5 › zerostep example (3.1s)

ai_test.spec.ts:4:5 › zerostep example › zerostep.ai 'Get the header text' ────────────────────

'An unknown error occurred.'

1 failed
ai_test.spec.ts:4:5 › zerostep example ─────────────────────────────────────────────────────────

@naveencha seems you are getting 401 - try disconnecting from VPN /disable firewall that is blocking your token


Actually send the error

oops the undefined was actually caused by this... 🤦

Haven't tested, lmk if i should revert!


step definition files should be watched

Currently, this framework is supported feature files only.
it also should have to watch change of step definition files.

@elasim feel free to propose a PR

@elasim
What do you exactly mean with

Currently, this framework is supported feature files only.
it also should have to watch change of step definition files.

hmm, ok,
According to the docs the watch mode in webdriver.io only watches spec files, which are the feature files in case of using CucumberJS. If you also want to watch on the step files config.cucumberOpts.require needs to be watched to. As far as my knowledge of webdriver.io and wdio-cucumber-framework now reaches it needs to be a change and thus a PR on both modules.


Which ubuntu system do you use to run the entire project？

20.04 or 18.04 or other？

Thanks
在 2023-12-08 17:31:10，"Yi Wei" @.***> 写道：
Red Hat 4.8.5-44
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

thanks!!!
在 2023-12-08 17:31:10，"Yi Wei" @.***> 写道：
Red Hat 4.8.5-44
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Could we make the behavior of vue jsx further imitate template

Clear and concise description of the problem
Jsx is a popular  grammar,  I know. But the difference of jsx between template is annoying. How about make vue jsx further imitate template? Like:

Use directive in jsx, which has been achieved.
Use "" instead of {}. Like <> <div v-if="!isHidden" /> <>
... And other stuff I haven't thought about it yet.

If the differences between jsx and template syntax can be eliminated, perhaps the problem of template reuse within SFC can be solved directly. I use h() instead of jsx because the difference between them is annoying. Make light code with h() is good but too long code with h() also brings negative experience.
Suggested solution
Could we use vue/compiler-sfc directly?
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Inspired by Vue Vine, we will also introduce similar template syntax in the future.


Training code usage

Hello,
Can you provide the details regarding the environment setup which is required to run the training code?
I am trying to run it on A10 with 2 GPU's. Will I have to make any changes to run the code?
Thank you in advance!!

I use the basic Anaconda3 python environment, and then install PyTorch and cupy. Python 3.6/3.7 and PyTorch 1.3.0-1.9.1 are verified to be OK. This code does not rely on extra uncommon python packages.
To prepare the training environment, for example:

Download Anaconda3-5.3.1-Linux-x86_64.sh and install it on Ubuntu 20.04.
Run conda install pytorch==1.9.1 torchvision==0.10.1 torchaudio==0.9.1 cudatoolkit=10.2 -c pytorch to install PyTorch 1.9.1 with CUDA 10.2.
Run pip install cupy-cuda102 to install cupy with CUDA 10.2.

You can do some adjustment according to your Python, PyTorch and CUDA requirements. I think there is no need to make any changes to run the code after you have set up above environment .


Move Helm chart to new jaegertracing/helm-charts

Requirement - what kind of business use case are you trying to solve?
Keeping Jaeger Helm charts accessible for end users, and also improving maintainability of the chart(s) moving forward.
Problem - what in Jaeger blocks you from solving the requirement?
The stable and incubator Helm chart repositories, currently listed on the Helm Hub, have begun a 1 year deprecation timeline. After 6 months they will be de-listed from the Hub. See helm/charts > Status of the Project and Deprecation Timeline.
The impact for end users is in 6 months the incubator/jaeger and stable/jaeger-operator will no longer be listed on the Helm Hub, as they are now: https://hub.helm.sh/charts?q=jaeger. Additionally, since Helm 3 was released, new versions of helm do not even include the stable repo by default. This means after 6 months, if the Jaeger charts are not moved to a new home and listed on the Hub, new users will not have a direct way to discover or install them.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Move Jaeger Helm charts to prepare for stable and incubator charts repo deprecation timeline.

Create a jaegertracing Helm charts gitpub project, such as https://github.com/jaegertracing/helm-charts, to be used as a Helm repository for Jaeger-related charts.
Move incubator/jaeger and stable/jaeger-operator from https://github.com/helm/charts to a new GitHub project. Note that retaining git history from the beginning is much easier than trying to splice it in later (see https://github.com/goharbor/harbor-helm/issues/48)
Include disclaimer README similar to https://github.com/elastic/helm-charts#elastic-stack-kubernetes-helm-chart. Also note these charts are community maintained, and add a basic statement about how to get involved (because it will be your own GitHub repo, you no longer need to rely on the helm/charts OWNERS file, but can add collaborators directly to the repo, if per-chart access is desired use GitHub native CODEOWNERS, etc). This all helps keep the burden low for the Jaeger team, and and shows support for Jaeger Helm Charts without adding additional liability
Add automation for chart linting, testing, and releasing chart versions to the Helm Repository using GitHub pages
Add new Jaeger Charts repository to the Helm Hub. See https://github.com/helm/hub#how-to-add-your-helm-charts
Deprecate the incubator/jaeger and stable/jaeger-operator charts in helm/charts. See https://github.com/helm/charts/blob/master/PROCESSES.md#deprecating-a-chart

See today's Jaeger Project Bi-Weekly Call Meeting Notes: 2019-12-13 for more context. I was asked by @naseemkullah to join the meeting and help give some context for this proposal. @jpkrohling asked for this issue to be created.
Any open questions to address

Would it be useful to have assistance with items 2, 4, 5 and 6 above? If so I'm happy to help
Are you interested in trying out the new Helm GitHub actions for item 4 above? These are very new, but do work - and are easier to set up than other previous methods (see https://github.com/helm/charts-repo-actions-demo). Again I'm happy to assist with this
Would you want to invite the current maintainers of these charts to the new GitHub repo, per item 3 above? Currently listed owners:

stable/jaeger-operator OWNERS: @cpanato @batazor
incubator/jaeger OWNERS: @dvonthenen @mikelorant @naseemkullah @pavelnikolov

I support this change 👍

@scottrigby repository created https://github.com/jaegertracing/helm-charts. I made you an admin for now, created a team @jaegertracing/helm-charts-maintainers , and invited the people you mentioned to this team. Please do the remaining setup, ping here if you need other setup functions.

@yurishkuro I have pushed the changes I can to a branch on that repo, and am just blocked (on actions administration, github token/user creation, and master branch protection) due to the admin role not being a full admin of that repo. I added more details in Jaeger Gitter - please let me know there which of the options you prefer. Will update status here once we have it up and running 😄

@scottrigby you're listed as admin, but that you have not accepted the invitation. Please visit the following link if you did not get an email: https://github.com/jaegertracing/helm-charts/invitations

OK, the repo itself should be all set up ✅
Master branch is pushed. The Helm repo automated releaser is working. Someone may want to test this.
I have also opened two PRs (just README updates), after the existing versions of the Jaeger charts from github.com/helm/charts (untouched) had been added to the new jaegertracing/helm-charts chart repo. These are actually necessary PRs (pointing readmes to the new jaegertracing charts repo), but I did this after CI was all set up so you can additionally see the CI working on them.

https://github.com/jaegertracing/helm-charts/pull/1 passed CI
https://github.com/jaegertracing/helm-charts/pull/2 - I initially purposely provided no version bump in order to fail the test. I then bumped the version to make the test succeed, however it looks like this uncovered an issue with our chart-testing action that I haven't seen - will work on his as part of that PR. But ultimately, this is looking good 👍

I also added more branch protection rules for master:

Required DCO status check
Required lint-test status check
Required signed commits

Is there some additional setup missing?  I did this per README, but nothing useful was shown:
$ helm repo add jaegertracing https://jaegertracing.github.io/helm-charts
"jaegertracing" has been added to your repositories

$ helm search jaegertracing

If using helm 3, try helm search repo jaegertracing

Thanks. I fixed the README.

@scottrigby How should we handle PRs currently open in the original repos?

I'd tell the authors to send them to this repo.

yep, I'm waiting for the deprecation get merged then i will go for all PRs in helm for jaeger* and point to here

OK also please hang tight – the CI needs to be fixed. I mentioned in the call you'll be an early adopter of the new Helm GH actions 😄 I see now we had not fully sorted out the actions for charts with dependencies - working with @unguiculus on fixing those now. Can we please hold off on merging PRs in that new charts repo for just a short time while this gets fixed?

OK I believe we are up and running. Thanks for patience!


Model property deletion on reset

Issue
When a model is resynchronized, and the new version of the model is missing properties that existed in the cached version, those properties are not deleted as expected.

Resolved in #46


SAM Serverless Function - Authorization: 'NONE' not setting API Gateway Auth to None

Description
I have a SAM Template that has definition for API Gateway where Authorization is defined using a Cognito User Pool. Within my Serverless Functions in the same template I am referencing that Auth in the Event/API section of the template. However when I use "Authorizer: 'NONE'" as defined in the SAM Docs, the API Gateway endpoint is still utilizing Auth.
Important to note that I am using a swagger doc to define API Gateway, perhaps this could be the cause. However I'm unsure how as I'm not defining auth anywhere in the swagger doc.
Steps to reproduce

Create SAM Template with API Gateway definition that has Auth defined.
Add two lambda functions with API Event type.
Define one Function to use the Authorizer defined in the API Gateway section.
Define the other to use Authorizer: 'NONE'

Observed result
API Gateway endpoints are created with Auth defined on both endpoints.
--debug on the Deploy command resulted in the below
2019-08-31 14:14:14 deploy command successful
2019-08-31 14:14:14 Sending Telemetry: {'metrics': [{'commandRun': {'awsProfileProvided': False, 'debugFlagProvided': True, 'region': '', 'commandName': 'sam deploy', 'duration': 62536, 'exitReason': 'success', 'exitCode': 0, 'requestId': '085405a8-6e78-465e-a1c1-b75b9a266513', 'installationId': '0ee285a1-3136-4448-a7ce-6d85fabb007e', 'sessionId': '871f0ad7-3a34-442b-a14d-ef6b62e7e1cf', 'executionEnvironment': 'CLI', 'pyversion': '3.7.4', 'samcliVersion': '0.19.0'}}]}
2019-08-31 14:14:14 Starting new HTTPS connection (1): aws-serverless-tools-telemetry.us-west-2.amazonaws.com:443
2019-08-31 14:14:14 HTTPSConnectionPool(host='aws-serverless-tools-telemetry.us-west-2.amazonaws.com', port=443): Read timed out. (read timeout=0.1)

Expected result
The 'NONE' flag should allow the endpoint to not have Auth defined as specified in the Docs.
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

OS: Linux Ubuntu Desktop 18.04 (what SAM CLI is running on)
sam --version: 0.19.0

The issue was that my Swagger spec was overriding the authorization settings that I notated in the SAM file for each Lambda function.
By adding:
      security:
        - NONE: []

To the swagger spec under the method type (get, post, etc), I was able to override the default Auth on specific Lambdas. Full example below of the correct Swagger spec for future reference.
    get:
      responses:
        200:
          description: 200 response
          headers:
            Access-Control-Allow-Origin:
              type: string
      security:
        - NONE: []


Explicitly make fulfillment app reg single tenant

Is your feature request related to a problem? Please describe.
By default, the app reg is created as single tenant. In case of changes in CLI, this could change.
Describe the solution you'd like
Create single tenant app reg regardless of cli behavior

I am trying to understand the deployment parameter IsAdminPortalMultiTenant
Which lead me to this ticket. It might be obvious for internal discussions, but this sentence in the docs does say much of what is achieved or what is the use-case for that:
Set to true if you want to enable multi-tenant support for the admin portal. Default: false
Multi-tenant in which context?
Furthermore, in this ticket it seems that it is preferred to ignore that parameter?
Create single tenant app reg regardless of cli behavior


implements InverseReal

implements InverseReal and closes https://github.com/swharden/FftSharp/issues/71

@swharden are you gonna have time soon to review  and merge this PR?

Hi @gsgou,
Yes! I plan to catch up on issues and PRs for this repository today or tomorrow 👍


Inlude pulsar_analysis recipe

Hi all,
Here is the pulsar analysis recipe that @MRegeard ,@jalu98 and I have created for gammapy. The code should be there but it is still not the final version and we will probably need to add more explanations. Things that could be problematic:

We need the ephemeris (txt external file) for the analysis. We should use the public ones, so maybe the Fermi-LAT ephemeris, even outdated, could be valid. Should we include them in the same directory as the notebook +environment?

We need to use PINT package but it seems that it is not available in conda-forge amr64. We should install it via pip. I have included this option in the environment file. Is it right or should be just inside the tutorial notebook?

Thanks @alvmas et al!
This should be a very useful addition indeed.
I would propose that you add the ephemeris to this repo, and have a commented line showing how and where Fermi-LAT ephemeris can be downloaded (eg: https://docs.gammapy.org/1.0/tutorials/data/cta.html#cta-performance-files)
Do you think it will be useful to have a phasogram and an H-test to compute the significance of the pulsed emission? @bkhelifi @adonath @registerrier ?

Thanks a lot @alvmas!

We need to use PINT package but it seems that it is not available in conda-forge amr64. We should install it via pip. I have included this option in the environment file. Is it right or should be just inside the tutorial notebook?

This option is just fine!

he h-test it is not yet implemented in gammapy stats, but I think it would be a good thing to add it.

If you use PINT, it would seem simpler and safer to use the H-test implementation that already exists there : https://nanograv-pint.readthedocs.io/en/latest/_modules/pint/eventstats.html#hm

Well, I meant this recipe can show a complete pulsar analysis, with h-test and everything.
In the long run, this will likely reside in tutorials, but since we are still planning the meta handling etc, this can be a solution for the most commonly asked questions for pulsars.

Hi all,
I added a small explanation on how to download and I included the .par file in the repository as well.

I agree with @MRegeard. Maybe it is not very clear why we should put the H-test in the recipe, especially if it is not directly related to gammapy, but PINT. So our first idea was to do this recipe as a tool to 'be able to use gammapy for pulsar analysis'. And then we wanted to do another pulsar tutorial similar to the one already available but more complete and updated. We can actually include how to compute the H-test, but you don't need gammapy for this.

At then end, users will do what they want. And I think that the most important in this recipes is to show which 'tools' are available for most of the use cases.
Here, I think that we show

how to store at a random place the new event files,
how to modify the hdu file accordingly,
how to store the modified hdu file (within the same or in a new),
how to read the modified hdu file to access to the new event files for an analysis
The absolute directory containing the new event files can be changed by default in an other place (a dedicated variable could be used)...

The other approach mentioned by Regis was to make a full copy of the data for a selection of obs. This is made with the current gammapy tools. I mentioned to @MRegeard that is was a bit easy because copying the IRFs take a lot of space. But of course, this approach is also viable for a user. Should we mentioned this 2nd method or use only this one?

Hi all,
We think we have implemented the most relevant comments from your previous feedback and it could be ready to be merge. Maybe you can check the recipe and see if there is something left we should add.

Thanks a lot for this updated version... I have posted some suggestions.

Thanks a lot for this updated version... I have posted some suggestions.

Thanks Bruno for these comments, we are going to make the changes !

I think I have fixed all your comments @bkhelifi.

Thanks a lot @alvmas and @MRegeard ! This looks very useful now. I left a number of comments inline, mostly minor. The only issue I have is using observation._events to set the event list.

Thanks a lot @AtreyeeS and @bkhelifi  for the feedback! We have implemented some changes regarding your comments. Others maybe we should still discuss them.

Hi all,
I am wondering if the associated HowTo in the Gammapy doc should not be completed by adding a link towards this recipies...

Hi @bkhelifi, I think it would be a good idea !
However, can I do It in this branch/pull request ? Because we are in gammapy-recipes and the howto file is in the gammapy directory.

Do you understand the CI fail @adonath? Seems related to GitHub workflow not working on forks, but I am not sure.

Will merge now and try to solve issues later.


Avoid infinite loop in CreateOffer

Related to #1656.

🔥 LGTM!
I will cherry-pick and include a test. Would also like to figure out the root cause

Would also like to figure out the root cause

Absolutely.  With this patch, Galène no longer hangs, but it still fails streams when AddSender races with SetRemoteDescription.

Merged with 16407672bde2f1dbc7f4e9f196473ce9d09d95cd
I also added a test


Modify guild description

TODO: Rebase after #365 is merged. Merge #365 first

Like the other PR, going to wait until #365 is in to review this one


Readme adblocker note

Adds a note to the Readme about adblockers preventing comments. Also adds an issue template asking for expected/observed behaviour, steps to reproduce, and any additional info.
If the content is ok, I can create similar PRs for the other public repos.

Go for it! 😄


Please resolve this error as soon as possible

Environment data

VS Code version: XXX
Jupyter Extension version (available under the Extensions sidebar): XXX
Python Extension version (available under the Extensions sidebar): XXX
OS (Windows | Mac | Linux distro) and version: XXX
Python and/or Anaconda version: XXX
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Jupyter server running: Local | Remote | N/A

Expected behaviour
XXX
Actual behaviour
XXX
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

XXX

Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

XXX

Hi @Naimuddinsiddiqui, sorry to hear you're having trouble. We'd really like to help you. To do so, please fill the bug template.


Eyes too small on Pixel 2 XL

Description:
On the Pixel 2 XL, the polyfill area for the eyes only takes up a smaller part of the screen, causing it to not appear correctly in VR headsets.
Additional Information:

webvr-polyfill version:
Browser name/version/release channel: Chrome 69.0.3497.86
Operating System: Android 8.0.0

@hdunn thanks for filing, a colleague was able to reproduce this


Eth1 follow distance not respected

@mpetrunic has noted that ETH1_FOLLOW_DISTANCE is not being respected during genesis.
His observation seems valid to me, we should look into this and ensure it is respected.

Is this the case when ETH1_FOLLOW_DISTANCE * SECONDS_PER_ETH1_BLOCK is greater than 2*MIN_GENESIS_TIME?

If so, seems like should define min_vote_time as the current eth1_data in the state

@djrtwo where is 2 * MIN_GENESIS_TIME come from?

Oh god, this is on the wrong repo. I'm so sorry!


Implemented ManagedIdentityCredential with composition (#9302)

Implemented ManagedIdentityCredential using composistion to hold an instance of ImdsCredential or MsiCredential. #9302

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: HankiGreed sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I can't  figure out why the tests are failing !

I'll fix these things and let you know, Thanks  A lot  !

I pushed the changes for async ManagedIdentityCredential, I left the aexit of it empty as done in async EnvironmentCredential and called the __aexit__ of credential in close() routine. Please have a look and let me know


FOLIO-3994 Trigger Workflow on any branch with matched paths

The on:push:paths is not sufficient, must also have on:push:branches

Why were we able to delete docker.yml and go.yml? Or were they only ever temporary files?

Yes, they were old Workflows from when this repository was at indexdata. They are not used. The new Workflow is "do-go.yml". See the Actions runs in this mod-reporting repository for "Go central workflow" for the past few weeks.

Perfect, thank you!


fix syntax for supervisor install check

I happened to come upon this, but didn't end up running it again with this fix. This seems to be the preferred way to check for empty stdout, looking at the docs, and the current way was failing (though I can't say whether it's for this reason).

It was apparently not for this reason. Closing.


Consider responsive options

Currently, as you shrink the window, the flatpickr will get cut off by the window, but I would like to propose that, if it gets cut off, the flatpickr will move to the other side of the input or something, to allow still seeing the whole thing. Definitely open to discussion and suggestions for this.

Already said in #22

Already said in #22


Full name attribute is missing in detail view screen of VC

Describe the bug
Full name attribute is missing in detail view screen of VC
To Reproduce

Open app and head to home page
click on add ID and download VC
Go back to home
Open the downloaded VC

Current behavior
Full name attribute is missing in detail view screen of VC
Expected behavior
Detail view of VC screen should contain Full Name details.
Screenshots

Smartphone (please complete the following information):

Device: iPhone7 & iPhone XR
OS: 15.4.1
Inji app version: 0.4.0 (16) in test flight
MOSIP Version: 1.2.1
MOSIP server: qa-121.mosip.net

Additional context
Issue in Android is registered https://github.com/mosip/inji/issues/199

Missing full name label element in the VcDetails.tsx, fixed in the android platform by [PR] (https://github.com/mosip/inji/pull/239) #239 and merged.

Verified on:
Device: iPhone 8 & iPhone 11
OS: 16.0.2 (20A380), 15.6.1
Inji app version: 0.4.1 (7) -> Testflight
MOSIP Version: <IP_ADDRESS>
MOSIP server: qa5.mosip.net
Able to get Full name in detail view screen


Profile tabs item count

Let's add an item count to the tabs only in the profile

it's just a 16px text in K-grey
it will replace the check - since we have 2+ items, its clear which one is selected
when there are 1000+ items, it will display like 1k, 1.1k etc.
updated in figma handoff file https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=2116%3A13786&mode=design&t=FNBC5umTPMg0BFe5-1

after:

#6745

hi @exezbcz is this available for a first-time contributor? I'd like to pick it up

@peoray
Yes I think it's fine for first time contributor
just wait for

#6745

to be merged first

Goodluck @peoray , welcome!

To implement this should I move the queries up to <ProfileDetails /> and pass the data through props or keep it as it is now and emit the values from up the components?

That's up to you to decide
Whichever way that will result in cleaner, better maintainable code

up for grab 👀

👋


Vulkan Color Attachments show as completely black after every draw call on Windows

Description
I am currently helping to develop the Vulkan backend for FNA3D. When capturing output from the game Wizorb, the color attachment displays black on every draw command. I tested this with Renderdoc v1.8 on Windows and Linux on the same hardware, and it only happens on Windows.
Steps to reproduce

Build FNA.dll and FNA3D.dll from source
Download the Linux depot of Wizorb (the assemblies are portable, so the executable will work on windows)
Place the dlls into the Wizorb directory
Launch the game through Renderdoc
All color attachments will display completely black

RDC: https://send.firefox.com/download/1afbe6be4d42ce43/#I-Jm9wcuAoLdd9m70Ke4OA
Environment

RenderDoc version: 1.8

Operating System: Windows 10 64-bit

Graphics API: Vulkan

Graphics card: NVIDIA GTX 970

Vulkan Driver: NVIDIA 445.75

Vulkan Conformance Version: 1.1.0

RenderDoc is only intended for capturing your own programs. Capturing copyrighted programs that you do not have the rights to is not endorsed and I will provide absolutely no support for it.

The FNA3D Vulkan renderer is being developed under my supervision, and I am the Linux/macOS developer for Wizorb:
http://www.flibitijibibo.com/index.php?page=Portfolio/Ports#28_wizorb.txt
All of the Vulkan work is being done in FNA or FNA3D, same as the overall rendering and GL work that currently ships in the Steam depot. The Steam version just happens to be the most convenient way to pull down a stable version.

The rules are clear and not up for discussion.


Improvements to multi-node editing

Closes https://github.com/godotengine/godot/issues/62192
This PR makes several improvements to multi-node editing. The general idea here is to remove all visible references to MultiNodeEdit so that multi-node editing is done behind-the-scenes.

Show the revert button for properties that are not default for all selected nodes

Hide metadata on MultiNodeEdit and AnimationMultiTrackKeyEdit
Show documentation in property tooltips.
When all selected nodes have a property that is not from the same class, it's treated the same way it was before this PR with no documentation tooltips or revert button. This is because documentation and default values can be different between the different classes.
e.g. if you select a Control and a Node2D, both have rotation and scale even though CanvasItem doesn't.

Hide the "MultiNodeEdit" category header

I had to hardcode this into EditorInspector because it appears that _validate_property(), which is used to dynamically hide properties, doesn't run for categories (PROPERTY_HINT_CATEGORY). I tried to enable this but I looked all over and couldn't figure out how to. I'm still not a C++ wizard yet :(

MultiNodeEdit: Show the most common class name and icon and the number of selected nodes at the top of the inspector.
The "most common" class is determined by finding the highest level class that all of the selected nodes have in common.

Ok, it should be ready for review now! I've fixed several bugs and updated the OP with a better description and screenshots.

Groupless properties looks a bit weird:

Maybe there should be "Common Properties" group?
This still appears (from MultiNodeEdit):

Ok, I'll rebase and make the changes needed soon.

@fire-forge Poking 🙃

Thanks!