Flag (and explain?) honest-but-curious (and contrib?) in API docs

Right now, there is no indication in the generated docs that that a particular method requires contrib or honest-but-curious. The semantics on contrib are clear enough, but for honest-but-curious an explanation of why might be useful.
Without making things too complicated, we would like any additional info to be in both the R and Python docs.
Not sure right now what the implementation looks like, but it might be a convention we'll hold ourselves too, plus a test on the content of the docstrings.
Originally posted by @mccalluc in https://github.com/opendp/opendp/pull/1602#discussion_r1626445775

Closed in #1850

Reopening:

#1850 -> #1931

are something a little different in my view. For this issue, I was hoping we could check every method and make sure the features required for use are expressed in the docs.

Users shouldn't need to run their code and see errors to know what features need to be enabled: Should be documented.
I think this also ties to the larger conversation about proof writing. Right now if a proof is contributed, it isn't really obvious for the docs that a given method is extra solid.
Implementation: Probably inject into the docstring, based on the feature flags?


Inconsistent naming convention in API JSON responses

Summary
The naming convention in the API JSON responses are inconsistent. For example there are cases when it's lowerCamelCase
https://github.com/ethersphere/bee/blob/b44ed2eb3c60de775f063ed58d15891dccd8ce37/pkg/api/pin_chunks.go#L111
There are cases when it's lowercase
https://github.com/ethersphere/bee/blob/b44ed2eb3c60de775f063ed58d15891dccd8ce37/pkg/debugapi/chequebook.go#L40
There are cases when it's kebab-case
https://github.com/ethersphere/bee/blob/b44ed2eb3c60de775f063ed58d15891dccd8ce37/pkg/debugapi/p2p.go#L22
I think the best would be to stick to one naming convention and use that everywhere. Assuming these are all equal from the perspective of the Go code, I would suggest using lowerCamelCase because that's the easiest to use from Javascript.

@paxthemax , this could be something

Even after #1613 there are still some inconsistencies. For example https://github.com/ethersphere/bee/blob/master/openapi/SwarmCommon.yaml#L108


Print urls as hyperlink

Hi Nitin,
Thanks a lot for releasing this package, it is really neat!
I've played around with the Terminal component and implemented a HackerNews reader. I thought it could be nice to display url as a clickable hyperlink when calling print. It's not something already implemented right?

Many Thanks 👨💻

+1, would also like to see this functionality!

:+1:  for this.
Implementation thoughts:
Since all that content is just a string, one approach would be to regex replace urls with hyperlinks.
Those regexes can get pretty hairy, though, and usually don't cover every use case. We could likely save a few different ones as consts, and allow the user to override/add to them.
Anyway, just take that string and replace with it with a component that renders the text, but adds the links as well.


{"httpStatus":403,"messages":[{"errorCode":"paas-feature-1","message":"feature is not enabled for the contract"}]}

Description
Up to version '6.4.19' - ionos-cloud/terraform-provider-ionoscloud - it works as expected. From version 6.5.0 and higher I receive the following error in connection with the creation (resource "ionoscloud_certificate" ...) and retrieval (data "ionoscloud_certificate" ...) of certificates (Certificate Manager):
{"httpStatus":403,"messages":[{"errorCode":"paas-feature-1","message":"feature is not enabled for the contract"}]}
Expected behavior
Retrieving and creating certificates using the Certificate Manager.
Environment
Terraform version:
1.9.5
Provider version:
6.5.0 and higher
OS:
windows_amd64
Configuration Files
...
How to Reproduce
...
Error and Debug Output
{"httpStatus":403,"messages":[{"errorCode":"paas-feature-1","message":"feature is not enabled for the contract"}]}
Additional Notes
...
References
...

Closing this since the problem was related to the API, not to the Terraform provider.


2.3.0-rc2: Check failed: ret == 0 (11 vs. 0) Thread creation via pthread_create() failed. Aborted

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Red Hat Enterprise Linux Server release 7.6 (Maipo)
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.3.0-rc1-15-gbb3c460114 2.3.0-rc2
Python version: 3.7.5
CUDA/cuDNN version: 10.1.1/<IP_ADDRESS>
GPU model and memory: Tesla V100-PCIE-16GB

Describe the current behavior
TensorFlow crashes:
2020-07-18 21:29:32.310794: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1716] Found device 0 with properties:
pciBusID: 0000:41:00.0 name: Tesla V100-PCIE-16GB computeCapability: 7.0
coreClock: 1.38GHz coreCount: 80 deviceMemorySize: 15.78GiB deviceMemoryBandwidth: 836.37GiB/s
2020-07-18 21:29:32.310851: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
2020-07-18 21:29:32.310887: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcublas.so.10
2020-07-18 21:29:32.310898: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcufft.so.10
2020-07-18 21:29:32.310908: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcurand.so.10
2020-07-18 21:29:32.310918: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusolver.so.10
2020-07-18 21:29:32.310929: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusparse.so.10
2020-07-18 21:29:32.310943: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudnn.so.7
2020-07-18 21:29:32.311936: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1858] Adding visible gpu devices: 0
2020-07-18 21:29:32.311989: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
2020-07-18 21:29:33.680712: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1257] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-07-18 21:29:33.680781: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1263]      0
2020-07-18 21:29:33.680813: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1276] 0:   N
2020-07-18 21:29:33.682225: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1402] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 14757 MB memory) -> physical GPU (device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:41:00.0, compute capability: 7.0)
2020-07-18 21:29:33.694136: F tensorflow/core/platform/default/env.cc:72] Check failed: ret == 0 (11 vs. 0)Thread creation via pthread_create() failed.
Aborted

Standalone code to reproduce the issue
Just this:
import tensorflow as tf
x = tf.constant([1, 2])

@netw0rkf10w
I ran the above shared code on nightly and on tf 2.2 and do not face any such issues, please find the gist here.

Please refer to this issue with similar error

@Saduf2019 Yes it seems related to that issue. What should I do then? It seems to have something to do with the hardware... Thanks.

Did you try using a virtual environment ?

@ymodak Thanks. The issue seems to come from the server I'm using.

in my case, it occurs during training.  I have trained my model hundreds of epochs, this issue occurs

@netw0rkf10w
Which problem was that? I faced same issue, and every time I try tensorflow function same error message is shown.
(Check failed: ret == 0 (11 vs. 0)Thread creation via pthread_create() failed..)
Is it related to the version of library? Or is it a problem of virtual environment?

Hi @linaria-7726, @cl886699
according to my own research, this error is generated by the pthread library, particularly its status code is 11 and its name is EAGAIN [1];
Insufficient resources to create another thread, or a system-imposed limit on the number of threads was encountered. The latter case may occur in two ways: the RLIMIT_NPROC soft resource limit (set via setrlimit(2)), which limits the number of process for a real user ID, was reached; or the kernel's system-wide limit on the number of threads, /proc/sys/kernel/threads-max, was reached.
So if you are not running out of RAM, then it is likely that you need to increase the max number of threads of your system.
Note that I am assuming that the problem is not related with the library version.
[1] https://linux.die.net/man/3/pthread_create

Hi @linaria-7726, @cl886699
according to my own research, this error is generated by the pthread library, particularly its status code is 11 and its name is EAGAIN [1];
Insufficient resources to create another thread, or a system-imposed limit on the number of threads was encountered. The latter case may occur in two ways: the RLIMIT_NPROC soft resource limit (set via setrlimit(2)), which limits the number of process for a real user ID, was reached; or the kernel's system-wide limit on the number of threads, /proc/sys/kernel/threads-max, was reached.
So if you are not running out of RAM, then it is likely that you need to increase the max number of threads of your system.
Note that I am assuming that the problem is not related with the library version.
[1] https://linux.die.net/man/3/pthread_create

@xehartnort
I am experiencing the same problem.
I checked my system-imposed limit: RLIMIT_NPROC from /etc/security/limits.conf and number of threads from /proc/sys/kernel/threads-max. The former is 300 while the latter is 512198. I'm not 100% sure but at first thought both of them are large enough to create a new thread. The RAM quota is 4GB and the memory on GPU is 24GB.
So please someone let me know what the minimum required number of these things are. If my configuration all exceeds the minimum, I have to assume that the problem is related to GPU driver version and CUDA version.

did anyone solve this?

Hi I had the same issue, eventually it was simply due to out of memory. I requested a machine with more RAM and the error disappeared. To confirm this, we can try
dataset = build_dataset(...)
data_iter = iter(dataset)
batch = next(data_iter)

When there's not enough memory next() fails and putting segmentation error.


[Bug Report] Searchable Select Component have some question in android pad.

Element UI version
2.8.2
OS/Browsers version
Android 8.0.0 / Chrome 74.0.3729.136
Vue version
2.6.10
Reproduction Link
https://codepen.io/anon/pen/GarWJq
Steps to reproduce

Click and focus on the select component.
Click the component again to close the drop-down box.

What is Expected?

Click the select component but not focus automatically. And appear the drop-down box.
Click the select component again and focus on the input. And appear the virtual keyboard.
Click the component again to select or close the drop-down box.

What is actually happening?

Click and focus on the select component. Now the virtual keyboard doesn't appear.
Click the component again to close the drop-down box. Then the virtual keyboard flash suddenly and disappear.

element是pc端ui框架啊，你在m端使用了？

嗯。目前在pc端又有适配平板的需求，导致部分问题。orz

嗯。目前在pc端又有适配平板的需求，导致部分问题。orz

嗯。目前在pc端又有适配平板的需求，导致部分问题。orz

m端平板pc三端切换很烦，好像没有完美的兼容方案，你这等于是做自适应了，试试vue-bootstrop

嗯。目前项目已经定型，这一块只能自己手动做一下适配了，感谢~
vue-bootstrap等下个项目的时候我会去试试看看


getDocuments using dapi-grpc Python client regularly fails with InactiveRpcError

Several attempts to getDocuments using dapi-grpc Python client failed with InactiveRpcError
Expected Behavior

Return documents
Current Behavior

Throws error:
Exception:
<_InactiveRpcError of RPC that terminated with:
    status = StatusCode.DEADLINE_EXCEEDED
    details = "Deadline Exceeded"
    debug_error_string = "{"created":"@1651832078.957738000","description":"Deadline Exceeded","file":"src/core/ext/filters/deadline/deadline_filter.cc","file_line":81,"grpc_status":4}"
>

Steps to Reproduce (for bugs)

    def getDocuments(stub, params, options):
        #print(params)

        document_request = platform_pb2.GetDocumentsRequest()
        document_request.data_contract_id = params['data_contract_id']
        document_request.document_type =  params['document_type']
        document_request.where = params['where']
        document_request.order_by = params['order_by']
        document_request.limit =  params['limit']
        document_request.start_at =  params['start_at']
        document_request.start_after = params['start_after']

        response = stub.getDocuments(document_request, options['timeout'])

        documents = []
        for doc in response.documents:
             docBytes = doc[4 : len(doc)]
             documents.append(cbor2.loads(docBytes))

        return documents

platform_pb2 imported from here: https://github.com/dashevo/platform/blob/v0.23-dev/packages/dapi-grpc/clients/platform/v0/python/platform_pb2.py
Your Environment

Version used: @dashevo/dapi-grpc v0.23.0-dev.1
Environment name and version: Python 3.9.10
Operating System and version: darwin arm64

@mayoreee can you please provide a link to the project you are running?

Please reopen if this issue still reproducting.


Update project create and ps to use lookup by name

Problem:
Specifying a cluster on project create and a project using ps required
an ID
Solution:
Use the lookup by name
Update the description of the ps command
Issue: https://github.com/rancher/rancher/issues/11469

LGTM


External links to repository not working

The link of the anchor tag in the github info page is in the "url" attribute instead of "href".
From the chakra-ui Link component for externallinks the href prop should be set.

Hello @ruhag thank you much, it was a bug indeed, related to changes released yesterday #127
I've just released a fix: https://github.com/bestofjs/bestofjs-webui/commit/88a8a453cf2048a5bfccffb50b9b42a518e356bc
Could you check again?


[YUNIKORN-2969] fix inconsistent layout in REST documentation

What is this PR for?
The REST scheduler page is really inconsistent when you look at the side bar that is generated by the system.

Some calls have a subheader without text, like Nodes and Node as an example
User and group tracker seem to have part of the description in the side bar
Application and queue side bar has multiple issues with duplicate descriptions and sub grouping that does not seem correct.

What type of PR is it?

[ ] - Bug Fix
[ ] - Improvement
[ ] - Feature
[x] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2969
How should this be tested?
Screenshots (if appropriate)

Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

@wilfred-s Thanks for your review. It looks a lot cleaner now!


Revert "Bump k8s.io/kubectl from 0.24.4 to 0.25.0"

Reverts rh-ecosystem-edge/kernel-module-management#28
OCP 4.12 is using k8s 1.24 so keep 0.24.4 seems as a better fit here.

As @qbarrand has pointed out, this bump is going further in versions than what OCP 4.12 delivers (at least in nightlies) so it seems better to keep the 0.24.4 versions.

/lgtm


Clean is case-sensitive

On a case-sensitive filesystem (ie.: the default), the clean command leaves paths pointing to the same folder but with different cases.
Eg.:
C:\WINDOWS
C:\Windows

Oh yeah the clean definitely should be case-insensitive, as on Windows there is no difference in C:\mypath  and C:\MyPATH. Do you want to send a PR?


http: adding CONNECT example configs and improving docs

Risk Level: n/a
Testing: n/a
Docs Changes: connect docs improved
Release Notes: n/a
Part of #1451 and #1630

Any other requests?


Support Dashboard Data Consumption

As of now, everything infrastructure-wise is set up to run SecNetPerf and produce throughput data. That data gets checked in to the --deploy branch. Saved as a JSON https://microsoft.github.io/netperf/data/secnetperf/2023-12-01-20-25-09._.67ee09354f52d014ad4e9ec85fcb6b9260890134.json/test_result.json
Ideally, we should have an automation that also aggregates all the performance runs from the last ~20 commits / runs, and produce 1 data.json (secnetperf.json?) for each project (XDP, eBPF...).
The dashboard will just use this single file. We can add more features to the dashboard to query any number of commits in the past, but thats a future thing.

Added in https://github.com/microsoft/netperf/commit/c4fa0f036478b6aab144fa0320cb25eccd72e7bb
and https://github.com/microsoft/netperf/commit/630ae4e9210c7aeaceb2e68be4b1f661a991c0d2


R03B7 global

ICON External Parameter Request
Instructions

Give this issue a meaningful title.
Replace PASTE_YOUR_REQUEST_HERE with your request that you copied to clipboard:

{
  "extpar": {
      "igrid_type": 1,
      "iaot_type": 1,
      "ilu_type": 2,
      "ialb_type": 1,
      "isoil_type": 1,
      "itopo_type": 1,
      "lsgsl": false,
      "lfilter_oro": false,
      "lurban": false
  },
  "icontools": {
    "grid_level": 7,
    "grid_root": 3,
    "centre": 1,
    "subcentre": 2,
    "lspring_dynamics": true,
    "maxit": 1000,
    "beta_spring": 0.95,
    "outfile": "global_grid",
    "domains": [
      {
        "region_type": 1
      }
    ]
  }
}

Click on "Preview" to verify that the JSON format of your request is correctly formatted and displayed within a code block.
Click on "Submit new issue".

Extpar Data Request will now process your data based on the request you provided here. Once the processing is successful, it will post a link in this issue.
The processed data will be available under that link for up to 7 days.
If you encounter any problems, please add the label  to the issue. Make sure you post all relevant information from the logfiles in the issue directly.
Status Labels
Labels reflect the current state of your request:
 - Your request is currently under processing. Please wait for further updates.
 - Your request has been successfully processed. You can download your data using the provided link.
 - Unfortunately, your request could not be processed. Please refer to the log files in the zip file at the download link for more details.
 - Your request was aborted. This might be due to a timeout. Please try again or contact support if the problem persists.

Your data is ready for up to 7 days under this link.


Broken links

Hi, I found some broken hyperlinks:

[ ] https://crystalshards.org (file: README.md, error: ECONNRESET)
[ ] https://www.w3.org/TR/2009/WD-eventsource-20090421 (file: README.md, status code: 404)
[ ] https://faastruby.io (file: README.md, error: CERT_HAS_EXPIRED)
[ ] https://crystalshards.herokuapp.com/ (file: README.md, status code: 404)
[ ] http://www.crystular.org (file: README.md, status code: 503)

Thanks for reporting. Would you like to create a PR to remove those?


Cannot generate listview using ignite-ir-next boilerplate commands

I have just installed ignite 2 with the boilerplate ir-next then i wanted to generate a listview but i couldn't, here is the screenshot of ignite generate command (see the command badfile description):

ignite doctor results:
Alis-MacBook-Pro:Textables leolani$ ignite doctor
System
  platform           darwin
  arch               x64
  cpu                8 cores                                               Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
  directory          /Users/leolani/code/reactnative-workspace/Textables

JavaScript
  node               7.9.0        /usr/local/bin/node
  npm                4.6.1        /usr/local/bin/npm
  yarn               0.23.2       /usr/local/bin/yarn

React Native
  react-native-cli   2.0.1
  app rn version     0.42.0

Ignite
  ignite             2.0.0-beta.8   /usr/local/bin/ignite

Android
  java               1.8.0_101    /usr/bin/java
  android home       -            /Users/leolani/Library/Android/sdk

iOS
  xcode              8.2.1

I have realised that each generator file that has the line of code below doesn't work:
const patterns = require('../lib/patterns');
There is no such directory with this name.

Thanks for the heads up @ali-hellani.  This is now fixed in<EMAIL_ADDRESS> Bumping your devDependency in your package.json will pick up this fix.

it worked, thanks :)


improve the output format for RESTler bugs

The following improvements should be made to the RESTler results format so results are more easily consumed by tools in a CI/CD test pipeline (e.g. for automatic bug filing):
A single json file that includes the following:

full bug details: the current contents of bug_buckets.txt and full payloads (similar to the 'request_sample' in speccov.json including the sequence information).  The endpoint and method should correspond to the ones from the specification, so they can be shown in a results UI consistent with the spec (these are available as the request IDs in the grammar).
any global settings that should be re-used for the repro.  For example, 'use_ssl' can be specified on the command line or in the engine settings - this setting needs to be included in the results.
The name and description of each checker that found the bug (so these can be directly included when a bug is auto-filed).

I might suggest directly generating a SARIF file as the result instead of adjusting what you already have, assuming that was your eventual plan (no need to change the format if others are taking dependencies on the current format). I think it solves most of these notes, especially for consumption by CI/CD Pipeline tools.

There are other use cases for which we need the above results file, to be parsed by other tools which are not SARIF-aware, and it will be faster to implement.  We'll definitely consider adding the ability for RESTler to also have an option to generate a result report in SARIF (I'll open up a separate issue for this).

Fair enough. What you've written above would fix what we were working around in my project. Thank you!


Emphasizing versions

Encouraging users to stick to release versions.

@mathfac -- do you know why the CI is failing on hd5? I will merge the README in because they are (should be?) unrelated.


ignore image file

when in directory for build sitemap not only have a html file, the directory have a image file jpg or png, how to ignore that?

Hi, thanks for the interesting question.
We are working to add a parameter to ignore files with regex pattern

Hey, @derit you can check out the latest version. That version includes ignore files by extension...is not using a regex pattern because is not necessary add extra work to compare file types.
😄


Local build for VSH Menu crashed on PS3 HEN

I locally built the VSH Menu on branch https://github.com/TheRouletteBoi/RouLetteVshMenu/tree/standalone-fps-counter-v2 but it crashes on my tester's PS3 HEN. works on custom firmware both using your built version and mine but on HEN, it doesn't work with my build.
Do you have any ideas? I have SDK 4.75 + VS 2013 if that matters. I tried to fix it but it didn't work.
VshFpsCounter (2).zip

Maybe related to #47

To be more specific, the local build I posted crashes when user press L3+R3 to load it from webman, will edit this post with more info

Hm, no idea why but my local build is 89k vs the release page of 36k

Nothing else changed yet the built sprx is a lot larger.

It seems the sprx is compressed?

For the record I used the release binary from Release-PS3. It works on cfw but not hen.

I locally built the VSH Menu on branch https://github.com/TheRouletteBoi/RouLetteVshMenu/tree/standalone-fps-counter-v2 but it crashes on my tester's PS3 HEN. works on custom firmware both using your built version and mine but on HEN, it doesn't work with my build.
Do you have any ideas? I have SDK 4.75 + VS 2013 if that matters. I tried to fix it but it didn't work.
VshFpsCounter (2).zip

you need to sign the pre using 3.55 keys for the sprx to work on hen. Use TrueAncestor SELF Resigner

Thanks, Output Method: [3.XX ALT] works. Will open a PR to add it to the readme

Fixed in #50


Added Rolemaster_2E folder

Changes / Comments
version 1.0

Added 25 most used skills as default skills
https://i.imgur.com/NZMSfb0.png

Removed spell sheet

Auto calculate total bonus based on ranks with differential rank bonus support

Auto calculate level bonus based on current level

The repeater (custom skills) supports 2 stat skills

Auto calculate total bonus based on ranks with differential rank bonus support in the repeater (custom skills)

Auto calculate level bonus based on current level in the repeater (custom skills)

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ x ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ x ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ x ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

I think i need help with git


Add support for adjusting image brightness to brightness automations

Currently, Oyasumi only supports display brightness control, which is only supported on the Valve Index. This dims the LCD backlight. However, if it's possible to adjust the brightness of the image, more headsets could be supported. Image brightness would function absolutely identically on OLED headsets, and is still a fine fallback for others.
There are a few angles I've considered:

VRChat itself already has a brightness slider, but I could not find a way to control this externally. This would be an option if they ever made this controllable over OSC.
Oyasumi could leverage a popular overlay like OVR Advanced Settings (OVRAS). OVRAS has image brightness control, but they currently do not offer an API to adjust this externally. There is a general issue open for this functionality.
Oyasumi could add its own overlay to dim the image brightness like OVRAS does. The way to do this is something I've not been able to figure out yet.

If you have any other insights or ideas for other options, they would be greatly appreciated!

It's not available outside of VRC, but I think it's a good way for now.
As a side note, I'm currently learning about the OpenVR API to create an overlay for brightness control. But I can't test it yet because there is no VR at my school, I think it will be a while.

 (Avatar Expressions)

Aside from UI elements that would still render over it, I think that would work. However, I'm mostly trying to avoid adding functionality that requires people to modify their avatars for it to work. The expression menu being the main exception, but it's an extra that adds nothing you can't already do without it. It's why the sleep animations offer presets for existing locomotion prefabs rather than me shipping Oyasumi with its own. Not everyone uploads their own avatars or knows how to use Unity, so I'd hate to lock functionality away for them.

I'm currently learning about the OpenVR API to create an overlay for brightness control

I think this is the way to go, and how I think OVRAS does it as well. It's not limited to any game or headset, and aside from the steamvr dashboard itself, it affects everything it needs to.
I've got absolutely 0 experience with writing overlays though, and when looking into it in the past documentation seemed really sparse. In general I'd love to have an overlay to bring some Oyasumi controls into VR, but how there isn't an example project out there for showing how to build an overlay with simple a point and click ui is absolutely beyond me.
I did however see your project yesterday! If you want I can help you test it and see if we can get it to work. If doing it that way turns out to be functional, I think I could have a look at porting it to Rust.

However, I'm mostly trying to avoid adding functionality that requires people to modify their avatars for it to work.

Obviously, using Unity can be a big challenge for beginners in VRChat. I'll let you know if I come up with any other way.

If you want I can help you test it and see if we can get it to work.

If you can help me test it, I'd really appreciate it! However, I've never worked with overlays in OpenVR, so it's unlikely that it will work.
Still, if your code works and you're planning on porting it to Rust code, I think it might be a good idea to take a look at the ovr_overlay project (https://github.com/TheButlah/ovr_overlay).

Still, if your code works and you're planning on porting it to Rust code, I think it might be a good idea to take a look at the ovr_overlay project (https://github.com/TheButlah/ovr_overlay).

Using this I've managed to get this to work with an overlay! I'll be picking this up soon.

This has been added op develop. It'll ship with the next release. Closing.


npm failed

I'm trying to reinstall gremlin-client in a new location, but getting errors. Anything obvious I'm doing wrong (there has been an upgrade of node and npm versions)?
vagrant@vagrant-ubuntu-precise-64:/isdb/src/isdb-serverless/gremlin$ sudo npm install gremlin --save
npm ERR! Linux 3.2.0-89-virtual
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "gremlin" "--save"
npm ERR! node v4.0.0
npm ERR! npm  v3.7.2
npm ERR! path /isdb/src/isdb-serverless/gremlin/node_modules/node-uuid/bin/uuid
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod
npm ERR! enoent ENOENT: no such file or directory, chmod '/isdb/src/isdb-serverless/gremlin/node_modules/node-uuid/bin/uuid'
npm ERR! enoent ENOENT: no such file or directory, chmod '/isdb/src/isdb-serverless/gremlin/node_modules/node-uuid/bin/uuid'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR!     /isdb/src/isdb-serverless/gremlin/npm-debug.log
Regards,
Dean

I believe there was some odd issue with my vagrant box. Seems to be solved now. Thx.


rocketmq process exits inexplicably

Recently, it was found that the rocketmq nameserver / broker process exited, but no obvious error was found in the log. The environment information is as follows:
System environment: Linux centos 7
rocketmq version: 4.5.2
Number of hosts: 2 (master and slave each other)
The startup method is as follows:
Nameserver and broker jvm settings (both dev is 1G): bin / runserver.sh bin / runbroker.sh
--2 nodes are operating
/ opt / rocketmq / bin / mqnamesrv &
--1 node operation
/ opt / rocketmq / bin / mqbroker -c /opt/rocketmq/conf/2m-2s-sync/broker-a.properties &
/ opt / rocketmq / bin / mqbroker -c /opt/rocketmq/conf/2m-2s-sync/broker-b-s.properties &
--2 node operation
/ opt / rocketmq / bin / mqbroker -c /opt/rocketmq/conf/2m-2s-sync/broker-b.properties &
/ opt / rocketmq / bin / mqbroker -c /opt/rocketmq/conf/2m-2s-sync/broker-a-s.properties &
Running for about 4-5 hours, I found that the broker process has exited, and even the broker && nameserver has exited. When I query the log and configure the log level to DEBUG, no obvious error is _found?

nameserver logs

2020-03-04 14:49:30 INFO NettyServerCodecThread_5 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:40144]
2020-03-04 14:49:34 DEBUG RemotingExecutorThread_8 - receive request, 105 <IP_ADDRESS>:46706 RemotingCommand [code=105, language=JAVA, version=317, opaque=872, flag(B)=0, remark=null, extFields={topic=TBW102}, serializeTypeCurrentRPC=JSON]
2020-03-04 14:49:34 DEBUG RemotingExecutorThread_8 - pickupTopicRouteData TBW102 TopicRouteData [orderTopicConf=null, queueDatas=[QueueData [brokerName=broker-a, readQueueNums=8, writeQueueNums=8, perm=7, topicSynFlag=0], QueueData [brokerName=broker-b, readQueueNums=8, writeQueueNums=8, perm=7, topicSynFlag=0]], brokerDatas=[BrokerData [brokerName=broker-b, brokerAddrs={0=<IP_ADDRESS>:10911, 1=<IP_ADDRESS>:10921}], BrokerData [brokerName=broker-a, brokerAddrs={0=<IP_ADDRESS>:10911, 1=<IP_ADDRESS>:10921}]], filterServerTable={<IP_ADDRESS>:10911=null, <IP_ADDRESS>:10911=null, <IP_ADDRESS>:10921=null, <IP_ADDRESS>:10921=null}]
2020-03-04 14:49:37 INFO ShutdownHook - shutdown hook was invoked, 1 times.
2020-03-04 14:49:37 INFO ShutdownHook - shutdown thread NettyEventExecutor interrupt false
2020-03-04 14:49:37 INFO NettyServerCodecThread_8 - NETTY SERVER PIPELINE: channelInactive, the channel[<IP_ADDRESS>:52376]
2020-03-04 14:49:37 INFO NettyServerCodecThread_8 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:52376]
2020-03-04 14:49:37 INFO NettyServerCodecThread_8 - NETTY SERVER PIPELINE: channelInactive, the channel[<IP_ADDRESS>:53834]
2020-03-04 14:49:37 INFO NettyServerCodecThread_8 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:53834]
2020-03-04 14:49:37 INFO NettyServerCodecThread_8 - NETTY SERVER PIPELINE: channelInactive, the channel[<IP_ADDRESS>:46706]
2020-03-04 14:49:37 INFO NettyServerCodecThread_8 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:46706]
2020-03-04 14:49:37 INFO NettyServerCodecThread_7 - NETTY SERVER PIPELINE: channelInactive, the channel[<IP_ADDRESS>:53794]
2020-03-04 14:49:37 INFO NettyServerCodecThread_7 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:53794]
2020-03-04 14:49:37 INFO NettyServerCodecThread_5 - NETTY SERVER PIPELINE: channelInactive, the channel[<IP_ADDRESS>:45330]
2020-03-04 14:49:37 INFO NettyServerCodecThread_5 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:45330]
2020-03-04 14:49:37 INFO NettyServerCodecThread_2 - NETTY SERVER PIPELINE: channelInactive, the channel[<IP_ADDRESS>:52404]
2020-03-04 14:49:37 INFO NettyServerCodecThread_2 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:52404]
2020-03-04 14:49:37 INFO NettyEventExecutor - NettyEventExecutor service end
2020-03-04 14:49:37 INFO NettyServerCodecThread_4 - NETTY SERVER PIPELINE: channelInactive, the channel[<IP_ADDRESS>:45286]
2020-03-04 14:49:37 INFO NettyServerCodecThread_4 - NETTY SERVER PIPELINE: channelUnregistered, the channel[<IP_ADDRESS>:45286]
2020-03-04 14:49:37 INFO ShutdownHook - join thread NettyEventExecutor elapsed time(ms) 1 90000
2020-03-04 14:49:37 INFO ShutdownHook - Try to shutdown service thread:FileWatchService started:true lastThread:Thread[FileWatchService,5,main]
2020-03-04 14:49:37 INFO ShutdownHook - shutdown thread FileWatchService interrupt false
2020-03-04 14:49:37 INFO FileWatchService - FileWatchService service end
2020-03-04 14:49:37 INFO ShutdownHook - join thread FileWatchService elapsed time(ms) 2 90000
2020-03-04 14:49:37 INFO ShutdownHook - shutdown hook done, consuming time total(ms): 3

I have solved it, it is nohup problem, I want to know why it is necessary to nohup?

@superfenv nohup is necessary to avoid program stop when leave the term.

Generally, the process in the Linux system with "&" after the process
indicates that it runs in the background, and it is rarely interrupted. Why
does rocketmq use nohup? Of course, I'm just curious.
Heng Du<EMAIL_ADDRESS>于2020年3月9日周一 上午11:11写道：

Closed #1819 https://github.com/apache/rocketmq/issues/1819.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/rocketmq/issues/1819?email_source=notifications&email_token=AHKEPYMVZUY7N5SQXDK52JDRGRM5NA5CNFSM4LA5HOIKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOXFIADGA#event-3109028248,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHKEPYJGIDRVOH2QGYJ42ELRGRM5NANCNFSM4LA5HOIA
.

I'm sorry to bother you again, the rocketmq_exporter startup log reports
the error as follows:
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
[2020-04-24 11: 26: 15.631] INFO error is CODE: 1 DESC: The stats
<TOPIC_PUT_NUMS> <SELF_TEST_TOPIC> not exist
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
[2020-04-24 11: 26: 15.633] INFO error is CODE: 1 DESC: The stats
<TOPIC_PUT_SIZE> <SELF_TEST_TOPIC> not exist
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
[2020-04-24 11: 26: 15.634] INFO error is CODE: 1 DESC: The stats
<TOPIC_PUT_NUMS> <SELF_TEST_TOPIC> not exist
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
[2020-04-24 11: 26: 15.634] INFO error is CODE: 1 DESC: The stats
<TOPIC_PUT_SIZE> <SELF_TEST_TOPIC> not exist
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
[2020-04-24 11: 26: 15.637] INFO error is CODE: 1 DESC: The stats
<TOPIC_PUT_NUMS> <TOPIC_PUT_NUMS> not exist
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
[2020-04-24 11: 26: 15.638] INFO error is CODE: 1 DESC: The stats
<TOPIC_PUT_SIZE> <TOPIC_PUT_NUMS> not exist
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
[2020-04-24 11: 26: 15.639] INFO closeChannel: close the connection to
remote address [<IP_ADDRESS>:9876] result: true
[2020-04-24 11: 26: 15.644] INFO closeChannel: close the connection to
remote address [<IP_ADDRESS>:10909] result: true
[2020-04-24 11: 26: 15.644] INFO closeChannel: close the connection to
remote address [<IP_ADDRESS>:10909] result: true
feng wang<EMAIL_ADDRESS>于2020年3月9日周一 上午11:33写道：

Generally, the process in the Linux system with "&" after the process
indicates that it runs in the background, and it is rarely interrupted. Why
does rocketmq use nohup? Of course, I'm just curious.
Heng Du<EMAIL_ADDRESS>于2020年3月9日周一 上午11:11写道：

Closed #1819 https://github.com/apache/rocketmq/issues/1819.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/rocketmq/issues/1819?email_source=notifications&email_token=AHKEPYMVZUY7N5SQXDK52JDRGRM5NA5CNFSM4LA5HOIKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOXFIADGA#event-3109028248,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHKEPYJGIDRVOH2QGYJ42ELRGRM5NANCNFSM4LA5HOIA
.


Add Backstage to the CNCF Project Summary Table

🔖 Feature description
Dear maintainers,
The CNCF Business Value Subcommittee has developed a project summary table to supplement the CNCF Landscape and includes further information about CNCF projects for the broader cloud native community. We would like to request your project to submit a PR to the CNCF Landscape repository with additional details that will help further inform the community about your project and its use cases through the popular landscape and this new addition.
The table is located here: https://landscape.cncf.io/summary
There are directions located here: https://github.com/cncf/landscape/blob/master/readme_summary.md
Many thanks for this - we hope it will help further get the word out about your project.
🎤 Context
Sorry, not the right issue template, but there is nothing for this type of request.
✌ Possible Implementation
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

Added them here https://github.com/cncf/landscape/pull/3214/files


Signed binaries

Is it possible to sign binaries in the NuGet package?  That would make it easier to use the binary from another project that will be signed (and, therefore, strong-named).

Yes, this should be added. There's a discussion going on about this here: https://github.com/fsprojects/FSharp.Compiler.CodeDom/pull/6#issuecomment-94792936, please assist :)


@parcel/core: Failed to resolve '@libp2p/logger'

I know little about Parcel nor libp2p, so my apologies for not giving more info than the error:
@parcel/core: Failed to resolve '@libp2p/logger' from './node_modules/ipfs-core/src/components/index.js'
What other info can I provide to help troubleshoot this?

Paste your code snippet here or detail the steps to reproduce the error.

This is because parcel does not support the exports map - please see https://github.com/parcel-bundler/parcel/issues/4155
A possible solution is to switch to a different bundler that does support the exports map like vite or similar.


IOS [Phonegap 4]

When I follow the install instructions, I get the following error and it doesn't seem to build
I used the Phonegap add plugin method to install and followed instructions on readme for IOS
Error:
duplicate symbol OBJC_IVAR$_SocialSharing._popover in:
/Users/xxxxxx/Library/Developer/Xcode/DerivedData/xxxxxxx-adjzxbjffkjntocufdaqzngxajmm/Build/Intermediates/xxxxxx.build/Debug-iphonesimulator/xxxxx.build/Objects-normal/x86_64/SocialSharing-11C14F351B616FB1.o

Just installed using plugman worked
Other steps not necessary.


CB-7858 CB should provide a link to CM command UI in case of timeout …

…or failure

removing redundant cm command listener task classes
generalize success message of cm command listener tasks
generalize timeout handling of cm command listener tasks
extracting CM server fqdn and knox based CM basepath and provide link to the failed command, if possible
sending command link with a notification, thus user can use it to check the command on CM UI

See detailed description in the commit message.


missing styling for banner below shedule

its in the branch "banner" in the file schedule.html

Adjusted padding and background a bit, looks like in the screenshot below now.
Tried a full-width green background, but didn't look good. Maybe they can provide a plain color version of the banner, without the grass texture?
Anyway I think this is fine for now!


Redesigning of testimonial page

Description:
The current testimonial page may not fully leverage modern design practices. A redesign will make the page more visually appealing and user-friendly, ultimately leading to better user engagement and satisfaction.
kindly assign it to me under gssoc'24 ext

@somyadipghosh Raised PR. Kindly check it


[Bug]: The LN transaction does not appear anywhere

Describe the bug
I scanned an LN invoice. After 30 seconds I got a Time Out error message.
However, the beneficiary has received the money.
The amount has been debited from my total amount.
The transaction does not appear in the payment history.
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
GrapheneOS
Bitkit version
v94
Log o
bitkit_ldk_logs_1705161528782.zip
utput
No response

fixed


add longload spinners to when modlog matrix is fetching

populating the matrix can take a bit, so let's let the user know things are happening

fixed in cee931cf0d260b1fb2ef75d74ea926db8b4b5643


Migrate to investor-yearn

Overview
Placeholder
References and additional details
Placeholder
Acceptance Criteria
Placeholder
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

blocked by single sided staking interface


[Bug]: .as_query_engine(streaming=True, similarity_top_k=1) returns "Response" type instead of "StreamingResponse"

Bug Description
.as_query_engine(streaming=True, similarity_top_k=1) returns "Response" type instead of "StreamingResponse"
Version
0.8.69.post2
Steps to Reproduce
Create vector store index, then:
query_engine = index.as_query_engine(streaming = True, similarity_top_k=1)
streming_response = query._engine.query(prompt)

return response.response_gen

Relevant Logs/Tracbacks
File "C:\Projects\chatbot\llm.py", line 107, in generate_llama_response
    return response_iter.response_gen
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Response' object has no attribute 'response_gen'

Are you using a specific LLM? Not every LLM supports streaming

Are you using a specific LLM? Not every LLM supports streaming

I am using Llama2-7B and Llama2-13B .gguf versions from  with LlamaCPP.  I've created working prototype app on my PC, and then cloned it to my workstation in the office. The only diffrence between those two is llama-index version, because I downloaded all required packeges through requirements.txt without specific tags. I'll try to fix it with solution provided by bot, and get back to you tomorrow.

yea a chat engine is a little different than a query engine
Are you using our llama.cpp LLM? Or the one from langchain?

I use yours:
def setup_llm_model(model_name, temperature=0.1, max_length=3900):
    if model_name == "Llama2-13B":
        model_path = "C:\\Users\\Jakub\\Desktop\\projects\\chatbot\\llms\\llama2-13B-chat\\llama-2-13b-chat.Q5_K_M.gguf"
    elif model_name == "Llama2-7B":
        model_path = "C:\\Users\\Jakub\\Desktop\\projects\\chatbot\\llms\\llama2-7B-chat\\llama-2-7b-chat.Q5_K_M.gguf"

    """LAMACPP SETUP"""
    llm = LlamaCPP(
        model_path=model_path,
        temperature=temperature,
        max_new_tokens=max_length,
        context_window=3900,
        generate_kwargs={},
        model_kwargs={"n_gpu_layers": 1},
        messages_to_prompt=messages_to_prompt,
        completion_to_prompt=completion_to_prompt,
        verbose=True,

       return llm
    )

I don't use LangChain at all.

Okey, so that was obviously my problem. I create a vector store using one function (because user can upload documents and create embeddings for them):
def generate_vector_store(context: str):

    # set context window size
    context_window = 2048
    # set number of output tokens
    num_output = 256

    llm = setup_llm_model(model_name="Llama2-7B")

    embed_model = HuggingFaceEmbedding(model_name="BAAI/bge-small-en-v1.5")
    documents = SimpleDirectoryReader('.\\instance\\uploads').load_data()

    db = chromadb.PersistentClient(path=".\\chroma_db")
    chroma_collection = db.get_or_create_collection(context)
    vector_store = ChromaVectorStore(chroma_collection=chroma_collection)
    storage_context = StorageContext.from_defaults(vector_store=vector_store)
    service_context = ServiceContext.from_defaults(
        llm=llm,
        embed_model=embed_model,
        context_window=context_window,
        num_output=num_output
    )
    VectorStoreIndex.from_documents(
        documents, storage_context=storage_context, service_context=service_context
    )

And then I use different function to load that vector store and generate response:
def generate_llama_response(prompt: str, context: str, model_name: str):

    # set context window size
    context_window = 2048
    # set number of output tokens
    num_output = 256

    llm = setup_llm_model(model_name=model_name)

    embed_model = HuggingFaceEmbedding(model_name="BAAI/bge-small-en-v1.5")

    service_context = ServiceContext.from_defaults(
        llm=llm,
        embed_model=embed_model,
        context_window=context_window,
        num_output=num_output
    )

    db2 = chromadb.PersistentClient(path=".\\chroma_db")
    chroma_collection = db2.get_or_create_collection(context)
    vector_store = ChromaVectorStore(chroma_collection=chroma_collection)
    storage_context = StorageContext.from_defaults(vector_store=vector_store)
    index = VectorStoreIndex.from_vector_store(
        vector_store,
        storage_context=storage_context,
        service_context=service_context
    )

    query_engine = index.as_query_engine(streaming=True, similarity_top_k=1)
    response_iter = query_engine.query(prompt)

    return response_iter.response_gen

All I needed to do, to fix that problem, was to add storage context.
Maybe that is something worth adding to documentation? Because I was following llama-index docs, where quering an engine does not include storing_context variable.

ah good catch :)
So the issue is resolved then?

ah good catch :)
So the issue is resolved then?

Yep! Thank you for your response! :)

ah good catch :)
So the issue is resolved then?

Yep! Thank you for your response! :)


feat(TDI-39297): upgrade snowflake driver to latest version on master

What is the current behavior? (You can also link to an open issue here)
Upgrade version from 3.2.2
What is the new behavior?
to 3.3.2 (latest)
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: failure :x:

Pull request test result: success :star:
Sonar results


Lables from Instance Metada

Description
What problem are you trying to solve?
Have instance metadata values as labels
How important is this feature to you?
My internal observability tools make use of the AMI_ID and INSTANCE_ID, which we set to the lables LABEL_AMI_ID and LABEL_INSTANCE_ID respectively.
Currently we are setting these labels in the userData, however, doing this way we cannot make use of the AL2/AL2023 AMIs.
We need theses labels being set by Karpenter so that we can use auto-generated userdata.

Are the values for AMI_ID and INSTANCE_ID being fetched from IMDS? Then propagating that to labels in their userData. I'm not sure how we would do this, as this would require parsing IMDS's internally structured data into labels that they can use, which can really only be done without a structured userData (not bottlerocket or AL2023 iiuc).
The way to do this in Karpenter would be to add these as first class labels, where they're either propagated after the result of the cloudprovider.Create() call or reconciled onto the node after the fact.
Are these labels used for anything like scheduling constraints? Or is it purely for monitoring purposes? What are the full set of labels you pull from IMDS? Also this should probably live in github.com/aws/karpenter

Are the values for AMI_ID and INSTANCE_ID being fetched from IMDS?
Yes, today the values are fetched from IMDS


Add CloudApp v3.30

You need to follow the token reference must be followed, to avoid duplicates. This is a duplicate of cloud.rb.


[Function Expose] Table 5900 Service Header - Function ServLineExists

Can you please make function ServLineExists() in Table 5900 Service Header External/Global please?

Hi @bleisibach,
We have gone ahead with your request. These types of changes are typically included in the next minor release, so look for it there.


Add support for UHSUB

No tests for UHSUBv8i8, UHSUBv16i8, UHSUBv4i16, UHSUBv8i16, UHSUBv2i32, and UHSUBv4i32

2a68c4f67aa4d59ef7b3b278cfa1eb3dbed9c45f


[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully ran brew tests with your changes locally?

Following up on #110, this brings in more non-Ruby backport patches from Tigerbrew. Changes include:

Adds support for CFLAGS for more CPU types, and OS-specific CFLAGS
Adds an :expat special dependency
Skip using system APR and autotools on older OS Xs
Fix Java detection if java_home is missing (should also help Linux)
Don't call xcrun when it's not installed
Improve some messaging for specific OS versions
Update tar flags to work with older tars
Add a new helper to Formula to locate the path to make depending on OS version and install options
Prioritize picking gcc-4.2 over gcc-4.0, regardless of what /usr/bin/cc is

The Leopard 64-bit handling is pretty hairy, but that's only going to come up for Tigerbrew users so including the weird workarounds shouldn't affect Homebrew's maintenance burden.

Really cool to see these getting merged. I have a dream that eventually we can have Tigerbrew and Linuxbrew all using an unmodified Homebrew/brew. A few comments here that may help other versions but don't let the higher work ones block this PR being included.

I have a dream that eventually we can have Tigerbrew and Linuxbrew all using an unmodified Homebrew/brew.

I'd really like that!
Dealing with upgraded Ruby is going to be the tough part; Tigerbrew's going to be bundling its own Ruby, so the brew launcher needs to be able to:

Know the current version of the vendored Ruby
Be able to check it's installed
Be able to fetch and install new releases of it
Shebangs should be able to run that Ruby instead of the system one

Dealing with upgraded Ruby is going to be the tough part; Tigerbrew's going to be bundling its own Ruby, so the brew launcher needs to be able to:
Know the current version of the vendored Ruby
Be able to check it's installed
Be able to fetch and install new releases of it
Shebangs should be able to run that Ruby instead of the system one

Sounds doable; that's all stuff we can do relatively easily from Bash rather than Ruby land.

Shebangs should be able to run that Ruby instead of the system one

FYI, this is already happening in the SCM and cc wrappers, thanks to the magic of Ruby's -x flag, as can be seen in these lines from Library/ENV/4.3/cc.

Know the current version of the vendored Ruby
Be able to check it's installed

This can be achieved by following file structure.
Library/Vendor/Ruby
  |- Current # a symlink pointed to current version
  |- <version>/bin/ruby

As result, to update Ruby, all we need to do is to update the symlink.

This can be achieved by following file structure.

This sounds good. 👍

I think the Java changes suggested are a good idea, but I'd like to leave more changes like those to a followup PR.

I think the Java changes suggested are a good idea, but I'd like to leave more changes like those to a followup PR.

👍 🚢


Changelog and upgrade path for 3.x to 4.x

Hi, where can I find the changelog or upgrade path from 3.0.2 to 4.x?
The current CHANGELOG.md only covers changes from 4.x to 5.x.
An example, upgrading from 3.0.2 to 4.0.4
These properties no longer exists and I can't seem to find equivalent ones with intellisense:
new System.IdentityModel.Tokens.TokenValidationParameters
 {
     AudienceUriMode = AudienceUriMode.Always,
     SaveBootstrapContext = true,
}

Before:
// Assembly: System.IdentityModel.Tokens.Jwt, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35
// Assembly location: ....\System.IdentityModel.Tokens.Jwt.3.0.2\lib\net45\System.IdentityModel.Tokens.Jwt.dll

After:
// Assembly: System.IdentityModel.Tokens.Jwt, Version=4.0.40306.1554, Culture=neutral, PublicKeyToken=31bf3856ad364e35`
// Assembly location: ....\System.IdentityModel.Tokens.Jwt.<IP_ADDRESS>3061554\lib\net45\System.IdentityModel.Tokens.Jwt.dll

@angularsen can you move to 5.x?

I am not entirely sure yet, until I have tried it. Would it be an easier transition to 5.x than to 4.x?
From what I have read previously there has been a lot of issues with upgrading to 5.x for people on the OWIN and Katana stack, and we are also running that. That is, we are not running ASP.NET Core.
From what I can read on the issues list here, it seems that 5.2.0 addresses that, but it's all very fresh and I'd rather not run into issues that are hard to google and figure out.

@angularsen the majority of the BIG changes are in the SAML / WsFed support. If you are using OIDC / JWT / OAuth most changes are at the bug fix level.

Ok thanks, I'm closing this until I get more progress on the project and know whether I'll be going for 4.x or 5.x.


fixed #6

This commit fixes #6

Pull Request Test Coverage Report for Build 37

12 of 15 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.2%) to 96.311%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Mapper/RecursiveFieldTrait.php
12
15
80.0%

Totals

Change from base Build 33:
2.2%

Covered Lines:
496

Relevant Lines:
515

💛  - Coveralls


#4 - background bugs

background color of the blue stage isn't same all the time

Fixed. The gradient was wrong


Complete hl -> ll arithmetic lowering

BinLAndOp and BinLOrOp lowering is still WIP and does not have any tests

Before merging we want to rework high-level logic operations:
to have lhs and rhs as ValueRegions that use ValueYieldOp as final operand.


Keep cg-busy visible with error responses

Hi there!
I'd like to in istruct cg-busy to stay visible (maybe showing an error message instead of the loading one) in case of request error, in order to block user interaction with not-ready content.
Is there any way way to achieve this result with cg-busy at the moment? If not, could this feature be easily added to the existing code?
Thank you in advance

You might use an http interceptor, but this is totally not related to cg-busy

It's quite releate, imho... Cg-busy already take care of loading status and success status... why not adding a little support for error status? It's a pretty common scenario the need of blocking stuff if something goes wrong

@LeleDev  i suggest you can use ng-if inside your template to disable UI.
But I totally support your suggestion.

@Mart-Bogdan It wouldn't be the same, because in that case the controls would be completely removed... instead I just want to lock them while keeping them visible under the cg-busy semi-transparent backdrop.
I'm using cg-busy everywhere in my app, so I'd need an huge effort to achieve the same result with a non-native solution...

+1

:+1:


Fix autofill for a protected PDF file in Safari

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/19721
PROPOSAL: https://github.com/Expensify/App/issues/19721#issuecomment-1597364559
Tests

Add a new password for a secured PDF file in Settings -> Passwords (Apple devices).
Open any chat screen.
Upload or open any secured PDF file within the chat.
Click on "Enter the password" button, once "Password protected PDF" modal has been opened.
Use autofill to paste the password that you added before.
Close the preview modal, once the app has showed it.
Check the main/edit input on the chat screen. It must be empty or has text that was written before.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Add a new password for a secured PDF file in Settings -> Passwords (Apple devices).
Open any chat screen.
Upload or open any secured PDF file within the chat.
Click on "Enter the password" button, once "Password protected PDF" modal has been opened.
Use autofill to paste the password that you added before.
Close the preview modal, once the app has showed it.
Check the main/edit input on the chat screen. It must be empty or has text that was written before.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/57314631/68300607-415f-4120-a2e0-6ed6ac048499
https://github.com/Expensify/App/assets/57314631/484552fb-813a-4a20-a483-e25370658d27

Mobile Web - Chrome

https://github.com/Expensify/App/assets/57314631/7c233b04-f61d-4ba2-87d0-6a56736c4179
https://github.com/Expensify/App/assets/57314631/31d05e21-98fc-45ec-a50f-4ed4f940203f

Mobile Web - Safari

https://github.com/Expensify/App/assets/57314631/97bfa027-b69e-48dc-b9b2-32a7ad295365
https://github.com/Expensify/App/assets/57314631/6aa3e0f4-bc04-4cd4-ad97-34e9cf1af9bd

Desktop

https://github.com/Expensify/App/assets/57314631/60f648cc-9c8e-4568-9faa-245231f7909e

iOS

https://github.com/Expensify/App/assets/57314631/ae9a5256-a886-4619-8dcc-d008ba54c0bc

Android

https://github.com/Expensify/App/assets/57314631/c7f8c781-bed5-4c0d-9829-79062fc841eb

I have read the CLA Document and I hereby sign the CLA

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/16493223/58397d0b-0236-4fe9-8ffe-b6f66e963aca

Mobile Web - Chrome

https://github.com/Expensify/App/assets/16493223/9e8f5260-eb35-4d53-a5f2-323565114679

Mobile Web - Safari

https://github.com/Expensify/App/assets/16493223/bea12844-7535-41d2-a20e-dae13c4ceea7

Desktop

https://github.com/Expensify/App/assets/16493223/1383b5e7-34be-4668-9f62-b2e6ce438c83

iOS

https://github.com/Expensify/App/assets/16493223/ea66d322-351c-48e3-b946-61d552f1ef87

Android

https://github.com/Expensify/App/assets/16493223/049782d2-1db4-402a-9b28-b67963c3c2ca

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


can't open the software normally on win7

I can't open the software normally on win7, is it not supporting win7? Where can I get the version that supports win7? In other words, how can I use it on win7?

Yes win7 is not supported. We do the releases thru Github Action and they do not provide option to build for win7.


How to make tv4play’s plugin work ?

If tv4play is supposed to stream live channels, then how should this link/ path look, be altered:
livestreamer.exe tv4play.se/kanaler/sjuan best
if it’s adapted for VOD:
livestreamer.exe tv4play.se/program/solsidan?video_id=2480802 best
or any other of its VOD streams.
What I most often get is “error: No plugin can handle URL: tv4play.se/kanaler/tv4
C:\Users\Ordval>livestreamer.exe httpstream://http://www.tv4play.se/program/solsida
n?video_id=2480802 best
[cli][info] Found matching plugin stream for URL httpstream://http://www.tv4play
.se/program/solsidan?video_id=2480802
[cli][info] Available streams: live (worst, best)
[cli][info] Opening stream: live (http)
[cli][info] Starting player: "C:\Program Files (x86)\VideoLAN\VLC\vlc.exe"
[cli][info] Stream ended
I’ve put tv4play.py in [%AppData%\Roaming\livestreamer].
I’ve tried every “variant” or other I could find, also followed the advice on [https://github.com/chrippa/livestreamer/issues/177] (extra plugin-folder, made two copies of py named them .py and pyc., replaced the .pyc with a copy of the .pyc from [C:\Program Files\VLC\Livestreamer\livestreamer-1.9.0-py2.7.egg\livestreamer\plugins]).
I’m no wiz with computers so I need very clear cut advice on how to make it work.
Windows 7.   And I’m in Sweden.

This is a news report, it should work:
[http://www.tv4.se/nyheterna/klipp/upplagerekord-efter-terrorattacken-3044661]
but doesn't.


What's the license?

I'd like to use this code in my project, but I can't unless it's licensed under an open source license (i.e., MIT).

Sorry I just saw this question 😢 I haven't been monitoring my GitHub for ages. Let me attach one license to this repo...


[http-client-csharp] fix: generate deserialization switch for nested discriminators

fixes: https://github.com/microsoft/typespec/issues/4979

API change check
API changes are not detected in this pull request.


fargate-profile: restrict role access based on SourceArn (or custom assume_role_policy)

Is your request related to a problem? Please describe.
Per AWS docs:

To avoid a confused deputy security problem, it's important that the role restricts access based on SourceArn.

Describe the solution you'd like.
Add a condition to the current assume_role_policy:
data "aws_region" "current" {}

data "aws_iam_policy_document" "assume_role_policy" {
  count = local.create_iam_role ? 1 : 0

  statement {
    effect  = "Allow"
    actions = ["sts:AssumeRole"]

    principals {
      type        = "Service"
      identifiers = ["eks-fargate-pods.amazonaws.com"]
    }

    condition {
      test     = "ArnLike"
      variable = "aws:SourceArn"

      values = [
        "arn:${data.aws_partition.current.partition}:eks:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:fargateprofile/${var.cluster_name}/*",
      ]
    }
  }
}

Describe alternatives you've considered.
Allow users to specify a custom condition block for assume_role_policy.
Additional context

This issue has been resolved in version 20.11.0 :tada:


Fix Senegal Flag

I made some errors in my changes to add the senegal flag. This should resolve those errors.
The filename had a PNG extension instead of png and the readme had the wrong name for the hyperlink for the author.

@Death259 Sure, thank you for fixing them. :)


Title Page

Though the automatic chapter styling is glorious, I can't for the life of me get a decent title page. \maketitle does what I want, but I'd like to keep the nice background.
I spent several hours attempting to make a title using the paper image and simply couldn't get it. I don't know enough about LaTex, but is a \makedndtitle possible?
Edit: Immediately after posting this, it occurred that someone else might have had the same problem, and I found the example at https://github.com/Vladar4/DND-5e-LaTeX-Template-Module-Example/blob/master/module.tex - unfortunately I have no real idea what I'm doing and I can't get it to do what I want.
To clarify; when \maketitle is added, I get a blank white page with the title, date and author. I want that, except with the paper background.

I was looking and playing around with Vladar4's example as well and I found that I can get the paper background to show up if you just remove the \begin{titlepage} and \end{titlepage} from his code.  It doesn't appear to mess with the format of his title page as well.
TitlePageFix.txt
^That is actually a tex file, for some reason github won't let me upload a file ending with tex.

You can get the image on the title page by adding the same code as is responsible for the inclusion of the image on the other pages.
\begin{titlepage}
	\iftoggle{bool-bg}{
		\begin{tikzpicture}[remember picture,overlay]
			\node[inner sep=0pt] at (current page.center) {\includegraphics[width=\paperwidth,height=\paperheight]{img/paper}};
		\end{tikzpicture}
	}{}
…
\end{titlepage}

@ColdAnkles, did these responses answer your question sufficiently?
You can modify \maketitle with the titling package, but I have not delved into that solution yet.


Provide a way to limit push sizes and spread jobs over multiple pushes

push_bulk! is like push_bulk, except if the number of items exceeds a threshold, the process of enqueuing is spread across multiple pushes.
For example, push_bulk!([1, 2, 3, 4, 5], limit: 3) will limit each push to at most 3 items.
push_bulk!([1, 2, 3, 4, 5], limit: 3) { ... }

is thus equivalent to
push_bulk([1, 2, 3]) { ... }
push_bulk([4, 5]) { ... }

The justification here is to prevent trying to send a Significantly Large Number of jobs to Redis in a single push_bulk.
A question worth asking is: what happens if you do try something like push_bulk((1..10**7).to_a) and it takes a while to get to Redis? What benefits are there to spreading it across multiple calls like push_bulk! in this PR?

Should the implementation of push_bulk and push_bulk! be reversed, even?

I'm gonna say that push_bulk should be the one that accepts limit:, and push_bulk! should push all jobs over in one go. If you were to throw several million jobs at Sidekiq::Client.push_bulk, you'd likely see some intense latency.

Mike Perham also pointed out that LPUSH is O(n). :)