Test suite frozen

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I am having a problem where Jest loads a test suite which never ends.
To reproduce my setup:
npm init -y
npm i -S mongodb jest

Create this test file (./demo.spec.js):
var MongoClient = require('mongodb').MongoClient;

test('mongo query', () => {
  MongoClient.connect('mongodb://localhost:27017/test', function(err, db) {
    if (err) throw new Error('No connection')

    console.log('OK !!');
  });
});

Executing the test with jest demo.spec.js will print the OK message but freezes the execution of the suite by never returning to the command line
What is the expected behavior?
I am not sure if I am using Jest the wrong way, but I would expect third party code to not block Jest execution if it runs just fine outside a test context
Run Jest again with --debug and provide the full configuration it prints. Please mention your node and npm version and operating system.
https://gist.github.com/fgarcia/c232f12da4e7e99899a72d78982938ce

You should tear down your connection in afterEach or afterAll. Jest doesn't tear down the connections for you.

I did not expect Jest to be aware of an open connection and stay running until it was properly closed. That got me by surprise because my previous test suite runner just ignored them and returned to the command line.
@cpojer Do you have any reference to Jest documentation where this behavior is explained? Is it just watching http sockets? I would like to find out if there are similar features that will complicate the transition I was planing to do.

No, this is just normal node behavior. If you spawn async work, node will not quit until that is finished. The test framework you previously used probably just killed the process.
We could do that but we don't really want to – it could mask bugs in your code where you don't clean up resources in your code.


RTMP is not supported by firefox

Browser: Firefox Version 47.0
OS: Ubuntu 16.04
Clappr Version: 0.2.47

Removed the source intentionally.
RTMP is working fine on chrome but not working on firefox. Which versions of clappr and rtmp support both firefox and chrome?

The error you're seeing is very often related to the lack of flash installed, @sarat1669 can you see the flash animation in this page http://www.adobe.com/software/flash/about/ while using FF47?
Also, did you notice any error on console? last but least if this bug is confirmed it should be open at its original repo https://github.com/flavioribeiro/clappr-rtmp-plugin

Installing flash solved the issue. Thank you. I need some info. I am porting an application from hls.js to Clappr as I need to use rtmp streams along with hls. I used the following in my application
hls.abrController.lastfetchduration
hls.abrController.lastbw
Hls.Events.FRAG_CHANGED
Hls.Events.FRAG_LOADED
Hls.Events.ERROR
How can i access these through Clappr?

Yes @sarat1669 although this is more of a work around,
player.core.getCurrentContainer().getCurrentPlayback()._hls.on(HLSJS.Events.LEVEL_LOADED, (evt, data) => this._updatePlaybackType(evt, data))

So will Clappr always require Flash? Flash support is going away in most browsers...

@funkytaco : Clappr does not require Flash by default. It is only required if you intend to use RTMP external plugin in order to play a RTMP source.

Ah ok, thanks. I've noticed VXG player works without flash, but they use a Chrome plugin.
https://github.com/videoexpertsgroup
https://www.videoexpertsgroup.com/chrome-media-player-plug-in/
Is there any way to do this with Clappr?

Maybe if we use a library / playback that provides that !
http://blog.videojs.com/Video-js-4-2-0-released-RTMP-CSS-designer-and-stability/
https://github.com/yurydelendik/rtmp.js

Okay, thank you. I guess I will wait and see if RTMP will work without flash someday!


Create schema documentation

Document how a schema is supposed to be constructed.

documentation added in new help directory


Bug 2073006: Add all shipped architectures to CSV labels

We build & ship the operator + driver on all architectures, therefore announce them in the CSV. There are automatic jobs that watch if the images in registry match announced architectures.
cc @openshift/storage

Nack.  This operator, being specific to AWS, is only supported on AWS arches, namely x86 and arm.
/hold

thanks for the info!


Configurable ACL

Current this is set to ACL: "public-read". Would it be possible to make this configurable so that it can be omitted for deployments which do not need public-read to be set? (For example, websites that should only be accessible over HTTPS via CloudFront but not directly from S3.)

Hmm. 🤔
It’s been awhile since I pored over the AWS docs to figure out how to wire all this together, but my vague memory is that setting it to public-read was necessary in order for CloudFront to work? I could totally be wrong though! Can you point me to the docs on this that say it doesn’t need to be set to public-read?
Assuming I'm wrong, then we should probably dynamically decide what ACL to set. I have an aversion to having any more configuration options than are absolutely necessary. So for example without a CDN we use public-read and with a CDN we use private (or whatever the correct value is). I can imagine how this would actually be a lot more complicated to implement than it appears. Mainly because locking down the S3 bucket is something that can really only be done after you’ve properly configured everything. For example, if you deploy your site without a CDN, then come back weeks later and decide you want to turn it on, we could set the bucket to private after enabling the CDN, but that would actually break your site, because you hadn't updated your DNS to point to CloudFront instead of S3 yet. I think there are a few scenarios where if we attempted to lock down the bucket for you it might result in a situation you don't expect. Which makes it seem like it does need to be a configuration option.
If it has to be configured manually then I would want it to be something that is really necessary. Do you think it is? That is, when using CloudFront, is setting the bucket to private just more technically correct, or does it actually serve a real, necessary purpose? Is it a security concern? I can actually imagine how you might want it to be public even with a CDN. I've occasionally run into issues where the CDN didn't appear to bust the cache and being able to check S3 to make sure it was updated was helpful.
Let me know your thoughts!

I tried looking for documentation that explcitly confirms or denies that public-read is necessary/unnecessary for CloudFront but haven't been able to find any. The closest that I've come across that alludes that it isn't needed is this page which recomemnds using an Origin Access Identity.
My CloudFront distribution is set up in this manner, with "Restrict Bucket Access" turned on, and the distribution's Origin Access Identity being used by S3 to grant access to the bucket.
I've validated that this setup works by uploading a new/uncached .html file to S3 manually:

Ensure that "Read object" for "Group: Everyone" is not "Yes" under the object's "Permissions" tab > "Public access"
Access the file directly from the S3 bucket URL, which returns "403 Forbidden" with a "Code: AccessDenied" error
Access the file from the CloudFront URL, which returns the file content successfully

I believe the permission in (1) is set to "Yes" when Discharge uploads files with the ACL: "public-read" option, causing the file to be accessible from the S3 bucket URL directly, while not affecting CloudFront access.
It seems that an object's ACL is given a higher priority, and would override the bucket's policy.
You're right that there are many scenarios where locking down the S3 bucket isn't ideal, so setting it dynamically would cause problems. Also, some deployments may not be sensitive to preventing users from accessing the site via a S3 URL, but others may want to prevent that due to more sensitive content since S3 website URLs are guessable.
Thinking along the lines of granularity, using object ACLs to lock down a bucket may be a little too granular, and would cause further issues downstream when new objects are uploaded to S3 with different ACLs, making the entire deployment difficult to manage. According to AWS's guidelines, object ACLs would make sense when "permissions vary by object and you need to manage permissions at the object level". (Unfortunately, the section about "bucket ACL" says that a bucket ACL is only recommended for logging purposes. Befuddling!)
If controlling access to an entire bucket should be done at the bucket level, supporting what CloudFront automates during the setup process with the "Restrict Bucket Access" option (like in the tutorial linked above) would be a good way to go, and we'll need to prevent ACL: "public-read" from being set on the individual objects and overriding the policies set up during the process.
Other ways I've come across would be to use a WAF to restrict by IPs or to get S3 to check a HTTP header sent by CloudFront, both of which would require extra work to set up.

For hosting an internal website that should be seen only by people who are authorized to. There doesn't seem to be an easy way to limit access to a S3-hosted website. With CloudFront, there are many ways to do it, like:

Origin Access Identity
Lambda@Edge to add any form of authentication (e.g. basic HTTP auth)

Unfortunately, I've only used Discharge to deploy to S3, while CloudFront is manually configured due to some custom domain requirements, so I haven't had enough experience with the CDN portion of Discharge.
Just a suggestion, thinking along the lines of providing an easy way to configure this: Perhaps a setting like restrictBucketAccess, which sets this up for users across both the S3 & CDN features of Discharge, would be more in line with the spirit of the project than one that overrides just the ACL param during S3 upload?
(I've tested the HTTP header check method I suggested earlier, but unfortunately it didn't work. public-read at the object level is too powerful to override.)

@clarencesong Sorry, I missed the notification for your comment!
Ah, yeah, I think what you want to do is probably outside the scope of this project. As I understand it, if it’s even possible to do this in a way that works with the various permutations of how someone should be able to use discharge, I think it would add too much programatic and conceptual complexity for a feature that doesn’t seem like it would be used very much.
That said, this is admittedly difficult to talk about and imagine in the abstract, so if you think I’m wrong or misunderstanding please explain it to me! Or if you think a PR would be clearer that works too! But I want to be upfront that I’m pretty judicious about adding complexity to projects. Thanks!

Sure, thanks for considering! I'll close this issue.


[EPIC] Donation for Category

Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)
Campaigns
Describe the feature you'd like to request
As a donor I would like to donate regularly on the whole category of campaigns (for example social campaigns) I trust that Podkrepi.bg has done their due diligence I would like regularly from my account to support their effort on larger scale as category.
Acceptance criteria:

donate to become dropdown menu with 2 option
campaign donation
category donation
user will select from a drop down menu under category donations.
monthly donation will split equally between all campaign in category. For example if we have 5 campaigns in a category a donation for 50lv will be split equally - 10lv each
category with just one campaigns will be given all to that one campaign for now u
Donation are only valid with stripe/card for now
If the user hasn't signed in he will be asked for email only ( we can perform a "soft registration" - once the user decide to look for more information or stop his regular donation he will be asked to create password and register
We need an email reminder before each of the  regular payment
when user clicks on the "pay" button he will be redirected to stripe
Button pay  will be inactive until user select category, sum, and email  - an error can appear after if the user hasn't selected any of the 3 mandatory fields

@igoychev @Juicebgs @milena
Describe the solution you'd like

Describe alternatives you've considered
No response

@swolf86 Do we have a mobile design for this screen? Could you please attach it?

Put on hold from dev perspective @milenasp  let's work on simplified donation with the current flow of donation

We are testing the feature with real user

@ani-kalpachka Ticket is updated please have it as priority.  We have mobile and desktop version in the figma


remove debug console on windows

When opening windows wallet 1.4 a console pops out and if you close it the wallet dies.
Can you please remove it?

Fixed on master. Will be released with the V2 binaries.


Apparrent Conflict

In the  excerpt below,  I see guidance that conditional access policies both do & do not apply to external users.
Conditional Access policies only apply to guest access in Teams because there is a corresponding Azure AD B2B account.
See Policy recommendations for securing Teams chats, groups, and files for more information about securing identity and device access policies for Teams.
Require MFA always for guest and external users
This policy prompts guests to register for MFA in your tenant, regardless of whether they're registered for MFA in their home tenant. When accessing resources in your tenant, guest and external users are required to use MFA for every request.
Please clarify
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a4806dd-a0d0-966c-8130-e752676090a5
Version Independent ID: 6403c614-26bc-f037-262a-1ec33fc7d385
Content: Identity and device access policies for allowing guest and external B2B access - Microsoft 365 for enterprise - Office 365
Content Source: microsoft-365/security/office-365-security/identity-access-policies-guest-access.md
Product: microsoft-365-enterprise
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@gkens Thank you for your feedback. The new Policy does require MFA always for guest and external users. I have made changes to the document accordingly. This can be tracked via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/3708
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @gkens Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


GIS integration

Dear authors,
thanks for sharing this great toolkit! I'm very interested in using it for city simulations, and for that I would need a sort of GIS integration like loading (and visualizing) shapefiles and fast spatial index (for collisions).
In my past experience with mesa and mesa-gis this would not scale well.
I was wondering if you could advice on that
Thanks and regards

Dear,
We are pleased to hear of your interest in our toolkit!
Integrating krABMaga with GIS data is a feature we are working on and is the next priority in our plans.
If you want to see some work in Rust regarding GIS, there are some crates like earthwyrm and geojson.
Regarding the implementation, since krABMaga is based on the Bevy engine that does not support the shape required for the GIS data, we are developing a solution from scratch that may require a bit. But we are optimistic about that.

Yes!
Feel free to write us if we can support you in experimenting with GIS and our tool.
Thank you

Thanks a lot Giuseppe and Carmine, for your fast reply! Indeed I would be very interested into experimenting with that (it would be a perfect excuse to learn rust :) )
There is a very nice example from mesa that I would like to recreate with krABMaga:
https://github.com/wang-boyu/agents-and-networks-in-python
I tried here to scale up a little using a better rtree implementation:
https://github.com/wang-boyu/agents-and-networks-in-python/pull/2
Let me know if you have any idea/suggestions on how to start reimplementing it with krabm


Add a reminder about the breaking change of temp folder renaming on Linux in release notes

Fix: https://github.com/NuGet/Home/issues/12655
There is a breaking change, "The temp folder where NuGet stores temporary files during its various operations is changed from /tmp/NuGetScratch to /tmp/NuGetScratch<username> on Linux.".
We'd better remind people in release notes.

I'll merge it now.
Hi @JonDouglas, pls let me know if I missed anything. Thanks!


cdc changefeed error，the ticdc_processor_exit_with_error_count value equal 0

What did you do?

tidb version ： 6.5.11
create changefeed :task-test
drop a table  on the downstream tidb cluster
view the changefeed,changefeed error is found 。
view granfana  ticdc->changefeed->exit error ，no changefeed found

What did you expect to see?
ticdc.ticdc_processor_exit_with_error_count alert is found.
What did you see instead?
none
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
| Release Version: v7.5.0
Edition: Community
Git Commit Hash: 069631e2ecfedc000ffb92c67207bea81380f020
Git Branch: heads/refs/tags/v7.5.0
UTC Build Time: 2023-11-24 08:50:14
GoVersion: go1.21.3
Race Enabled: false
Check Table Before Drop: false
Store: tikv |

Upstream TiKV version (execute tikv-server --version):
6.5.11

TiCDC version (execute cdc version):
6.5.11

This also on the master branch

This can be reproduced by the following steps:
1. create one mysql sink changefeed
2. sync some data to the downstream database
3. drop the table on the downstream database

You can observe that the changefeed report error since the table cannot be found, and trigger processor exit logic, at this step, the metrics ticdc_processor_exit_with_error_count is deleted, and then rebuild the processor with new metrics, so that the metrics panel is always 0.

At the moment, processor level metrics are deleted with the processor exit, we can fix the issue by don't delete such metric, but here comes another question, when to delete the metric ?


Detect and allow connection with an existing JWT token inside header

We should allow the okdp-spark-auth-filter to rely on an existing JWT token provided inside a header instead of asking the user to authenticate again.
It will allow authenticating reverse-proxy or gateway to authenticate the users and proxy the HTTP request to the spark UI with identity propagation.
Consider this use case :

We need to have inside the JWT token all information needed (sub,email,groups claim, ...).
This Gateway could also avoid setting individual redirect URL for all SparkUI. Instead the Gateway will host the only redirect URL for all SparkUI
What do you think ?
I may help if we all agree on the scope.

Hello @lioneloh,
Thank you for the proposal, it will be a nice feature to have natively in the filter. So, please go ahead if you have time.
For information, we have planned to develop the gateway part (UI + Rest API) authenticated with OIDC. The gateway will discover automatically all the spark jobs running or completed in the cluster and list them in the UI (links, status, start/end time, etc). There will be one single URL for all spark jobs listed in the UI (Gateway URL). When the user clicks the url, the gateway renders the live spark UI if the job is still running or renders/redirects to spark history when the job was completed (failed, terminated). The gateway will also come with other features like monitoring, logging, optimisations, etc.
Your feature brings flexibility in the usage of the filter through a reverse proxy or an own existing gateway.

v1.3.0


x/playground: tzdata not present on playground

The ParseInLocation example panics when run on the website:
2012-07-09 05:02:00 +0000 CEST
panic: time: missing Location in call to Date

goroutine 1 [running]:
time.Date(0x7dc, 0x7, 0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/usr/local/go-faketime/src/time/time.go:1371 +0x630
time.parse(0x4d0251, 0xb, 0x4d025c, 0xb, 0x0, 0x0, 0x0, 0x0, 0xc000052180, 0x0, ...)
	/usr/local/go-faketime/src/time/format.go:1187 +0x2f0d
time.ParseInLocation(...)
	/usr/local/go-faketime/src/time/format.go:824
main.main()
	/tmp/sandbox338262955/prog.go:18 +0x1a7

time.LoadLocation is returning an error: unknown time zone Europe/Berlin

Many of the time examples are not functioning: https://golang.org/pkg/time/#example_ParseInLocation
@toothrot

@toothrot let me know if I can help with this at all.

Looks like we're missing zoneinfo:
UTC unknown time zone Europe/Berlin

Fixed, deployed sandbox, and cleared cache.
Thanks for reporting!

For what it's worth, once the playground uses 1.15 you could just compile the program with -tags timetzdata.


Trying to cache a world manually or automatically errors out with "VRChat can't be located"

I'm not sure why this is happening. I've both the Steam and Oculus version of VRC installed.

Try download https://github.com/ZettaiVR/AssetBundleCacher/releases/download/v1.1/AssetBundleCacherBuild_1.1.zip and overwrite the AssetBundleCacher folder in VRCX, it only needs to locate the game to fetch UnityPlayer.dll but you can put it there manually instead.

Ok thanks, that fixed it! Seems some files were missing.


teamHelper mapTeams issue

Map Teams is failing in 1.0.0.
Line 17: destinationObj[key] = _.isobj[key];
Should be:
destinationObj[key] = _.isObject[key];
:)

It's so weird that when I tested the function it was working, but I probably ran an undo or something and didn't check close enough when I merged.
I'm at work now, I will fix this tonight when I get home. Sorry about that!

No problem, glad to help. This module is still seriously helping me by taking care of all that OAuth business and wacky yahoo data structure.
But looking at the code further, I think you really meant just obj[key] to map the property, not the _.isObject(key) to see if its an object, right?

You're correct and the fix has been pushed to NPM!
Thanks!


Linker Error when building to ios device

Hello! I'm just getting to the point where I'm needing to get this on my device for further testing and I ran into this error when building:

I wasn't sure if this should be something that is built into the package itself and taken care of at react-native link or if I should do what the error suggested and disable the bitcode. Is this something that can be looked into and see if it may be an easy fix for the package?

This was my bad, the error was referencing a different crypto package I had tried before yours! Closing the issue, thanks!


added cloudconsole docs in playground

as an answer to issue #182
added cloud console docs in playground
the content is based on the information from the issue discussion itself and this documentation

@ramezsaeed well that's a strong argument right there!
I did this to answer issue #182
But since it's not relevant anymore, I will close this PR and close the issue too. Thanks.


Add GCM register module

@tkchin @chuckhays

@juberti PTAL

Moved to:
https://github.com/GoogleChrome/webrtc/pull/406


Add support to use os shipped package for CentOS7 or fedora 19

Create a new recipe to use os natively shipped packages for mariadb
Add a helper function to determine which platforms has shipped
mariadb.
Fix an issue running mariadb_grants with remote access allowed.

Oops, operation error, falsely delete this branch. New pull request be submitted in #53


Hotfix/update readme gif

Description

Updates README's .gif file to demo the current version of the ENDRSD iOS app.
Removes the 'Installation' section of the README, per @Miikis' request.

Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

Change Status

[X] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[X] Test A: Locally
[ ] Test B

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] There are no merge conflicts

The changes in this PR are only for the README. I have already increased the semver tag and merged the "hotfix/update-readme-gif" branch into "development". Thanks!


incorrect result of gemm_residual

Hi, thank you for you works. I created a pytorch cuda extension based on this project, but I found that the result of gemm_residual is incorrect (group quant). It seems that the kernel read the scales incorrectly.
I compared the code of gemm_with_residual and gemm_without_redisual, and found that gemm_with_residual didn't use ld_scale_zero and didn't  set the value of params_scale in fpA_intB_gemm_with_broadcast.h.

import torch
# my_cutlass_gemm_kernel is the extension I created
import my_cutlass_gemm_kernel

m = 4096
n = 4096
k = 4096
group_size = 64
# use identity matrix
ins = torch.eye(m, device="cuda", dtype=torch.half)
outs = torch.randn((m, m), device="cuda", dtype=torch.half) / 10
weight = torch.randn((k, n), device="cuda", dtype=torch.half)
weight2 = weight.view(weight.size(0) // group_size, group_size, weight.size(1))
scales = weight2.abs().max(1)[0] / 127
qweight = (weight2 / scales[:, None, :]).round().to(torch.int8).clone()
qweight = qweight.view(-1, qweight.size(-1))

def preprocess_qweight_int8(qweight):
    assert qweight.dtype == torch.int8

    qweight_tmp = qweight.view(qweight.size(0) // 16, 16, qweight.size(1))
    qweight_tmp = qweight_tmp[:, [ 0,  1,  8,  9,  2,  3, 10, 11,  4,  5, 12, 13,  6,  7, 14, 15]]
    qweight = qweight_tmp.view(qweight.shape).T.contiguous()

    qweight = qweight.view(
        qweight.size(0) // 2, 2,
        qweight.size(1) // 64, 64
    ).permute(0, 2, 1, 3).reshape(qweight.shape)

    qweight = qweight + 128
    qweight_tmp = qweight.view(-1, 4)
    qweight_tmp[:, [1, 2]] = qweight_tmp[:, [2, 1]]
    qweight = qweight_tmp.view(qweight.shape[::-1])
    return qweight

# gemm with residual
outs1 = outs.zero_().clone()
my_cutlass_gemm_kernel.quant_gemm(
    ins, outs1, preprocess_qweight_int8(qweight), scales,
    None, m, k, n, group_size, "int8", "group", "identity", "plus"
)

print("\n", "==" * 10, "quant_gemm use this scales", "==" * 10)
print(outs1 / qweight)

print("\n", "==" * 10, "expected scales", "==" * 10)
print(scales.repeat_interleave(group_size, 0))

 ==================== quant_gemm use this scales ====================
tensor([[0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        [0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        [0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        ...,
        [0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        [0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        [0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195]],
       device='cuda:0', dtype=torch.float16)

 ==================== expected scales ====================
tensor([[0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        [0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        [0.0185, 0.0210, 0.0202,  ..., 0.0157, 0.0239, 0.0195],
        ...,
        [0.0200, 0.0182, 0.0171,  ..., 0.0176, 0.0174, 0.0202],
        [0.0200, 0.0182, 0.0171,  ..., 0.0176, 0.0174, 0.0202],
        [0.0200, 0.0182, 0.0171,  ..., 0.0176, 0.0174, 0.0202]],
       device='cuda:0', dtype=torch.float16)

I found another bug, activation == is missing here, so it would use silu activation always when activation != "identity".
https://github.com/tlc-pack/cutlass_fpA_intB_gemm/blob/6f05dd40763ceb62019c8eda16375974fd938a1a/cutlass_kernels/fpA_intB_gemm/fpA_intB_gemm_template.h#L632-L650

oh, can you send a PR to fix this?


Fix typos in issue template

CI failures are fixed in #379

Thanks @johnthagen, the documentation review is something missing in KiCost.


Invalid nested parameter format (3)

The JSON code
{
   "ara"   : "ara",
   "param" : 123,
   "val1"  : ${p${ara}m}
}

causes the following error message:
'Invalid nested parameter format: ${p${ara}m}, - The double quotes are missing!!!'
Now I am thinking about. Because my first idea was was to get a parameter with name 'val1' and value 123 (int!).
Because I want to keep the data type, I did not encapsulate the expression in quotes. This expression ${p${ara}m} is not a composite string (that really would require quotes), it's a name of a single parameter, realized by nested other parameters.
When I read the error message, it seems to me, that the ${} substitution inside expressions only works if the expression is encapsulated in quotes.
But when I do it in this way:
"val1"  : "${p${ara}m}"
I get a string value '123'. This is not what I want. I want an integer.
Could you please clarify: Is this format (nested parameters without quotes)
"val1"  : ${p${ara}m}
really invalid or is it possible to enable this format to have a chance to work also with other data types like strings?

Hello Thomas,
Could you please give your comment regarding Holger's request?
Thank you,
Son

Hi Son,
puh... this is really difficult.
My feeling is that we should behave like a linux bash shell, whatever it is doing in this case.
String replacement proposed by Holger without quotes is also strange. What to do if key "ara" holds an integer?
Let us discuss this with Holger.
Thank you,
Thomas

Hello Holger,
As our discussion in the meeting, we temporary keep the behavior as it is, trying to find and follow a standard.
Thank you,
Son

Again thinking about I would agree to keep the current behavior.
Retest:
"ara"   : "ara",
"param" : 123,
"val1"  : ${p${ara}m}

causes:
Error: 'Invalid nested parameter format: ${p${ara}m} - The double quotes are missing!!!'!
And we have to communicate the rule, that without quotes around the expression, a concatenation of strings based on parameters is not possible.
And with quotes:
"ara"   : "ara",
"param" : 123,
"val1"  : "${p${ara}m}"

it works fine.
{'ara': 'ara', 'param': 123, 'val1': '123'}
In my opinion the issue can be closed.

merged to develop branch

solved with version 0.10.0


[WIP] Redwood noisy depth

Motivation and Context
Adds the noise model from here: http://redwood-data.org/indoor/dataset.html
There are 2 implementations:

A numba based python implementation that runs at ~400 FPS at 256x256
A CUDA implementation that runs at ~5k FPS at 256x256 or ~200k FPS at 256x256 when using the GPU->GPU transfer from #114 !  I am gonna call ~200k FPS as "fast enough".

@msavva @bigbike @mosra What are your thoughts on how I am currently providing arguments to the sensor noise models?  I just added a py::dict to the python binding of the sensor spec so that people can pass arbitrary arguments in it.
TODO

[ ] Doc strings
[ ] License headers
[ ] Add citations
[ ] Figure out how to get the args for constructing noise models
[ ] Switch to a proper registry pattern in a different PR and use that here
[ ] Remove the tmp.py file.  That has just been useful for testing :)

How Has This Been Tested
Via the tests and visually!

Types of changes

New feature (non-breaking change which adds functionality)

A CUDA implementation that runs at ~5k FPS at 256x256 or ~200k FPS at 256x256 when using the GPU->GPU transfer from #114 !

200k?!! Damn.
Are those two images w/ and w/o noise?
Request -- is it easy to show images with varying levels of noise? (Or is that not feasible for this noise type?)

Are those two images w/ and w/o noise?

Yes they are :)

Request -- is it easy to show images with varying levels of noise? (Or is that not feasible for this noise type?)

We could make that doable with this noise model.  There are two different Gaussian that are sampled from and I could make the variance on those changeable.

I add a simple multiplier parameter which I just multiply both the standard deviations by.  Above is 2x, 3x, 4x, 5x.  Seems to fairly smoothly make things worse.

This is ready for review.


CB-974 - Place Knox security files in proper location for CM to read

This cannot be merged until Knox CSD is merged.

Can one of the admins verify this patch?

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-checkstyle-main/12/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-checkstyle-test/13/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-checkstyle-test/20/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-checkstyle-main/19/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-spotbugs-test/12/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-unit-test/12/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-spotbugs-main/13/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-integration-test/12/

Refer to this link for build results (access rights to CI server needed):
ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-integration-test/12/

Thank you Chuck.


Drop down arrow opens empty content box

Environment

Nautobot version (Docker tag too if applicable): 2.3.2
Reproducible on demo.nautobot.com

Steps to Reproduce

Open the list view for any Data Model Extensibility views
Click on the arrow to the right of the blue  + Add button

The arrow should probably only exist if there is actually something to display in the dropdown menu

An empty box appears that contains no additional buttons

Thanks for the report. From a read of object_list.html this looks like it'll be an issue whenever a list view has an add button but neither import nor export features in its action_buttons. As you noted, this is mostly the case for views in the extras app.


componentWillMount is deprecated and will be removed in the next major version.

Hi,
Thanks for your library, now there is a warning message in the console, the blog address

Me too 🗡

Use this library, everything will be fine: https://github.com/jshanson7/react-native-swipeable

Check out solution for this issue : https://www.skptricks.com/2018/10/warning-componentwillmount-is-deprecated-in-react-native.html


how to set timeout on resource create, plugin fails if clone takes more than default value

Hello,
Do this plugin provide option to set timeout in resource create, as clone in one cluster taking more time and job is failing that Plugin did not respond.
Best regards

Possibly related to #355
On Sat, May 22, 2021, 2:39 PM golgotow @.***> wrote:

Hello,
Do this plugin provide option to set timeout in resource create, as clone
in one cluster taking more time and job is failing that Plugin did not
respond.
Best regards
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Telmate/terraform-provider-proxmox/issues/358, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AASFVZI6ARDXK4OXMXZ2ZFTTO727TANCNFSM45K4N4BQ
.

Hello,
Not sure if related, when storage is in good shape this problem do not exist, only during long clone time
Best regards

According to terraform docs, the plugin should implement support for it this way:
  timeouts {
    create = "60m"
    delete = "2h"
  }

https://www.terraform.io/docs/language/resources/syntax.html
However, I checked the code and this is not supported. Instead, it supports a generic pm_timeout:
            "pm_timeout": {
                Type:     schema.TypeInt,
                Optional: true,
                Default:  300,
            },

The default 300 seconds (5 minutes) seems to be around the timing I've been seeing in my tests (#355). So I increased it to 1800 (30 minutes) but it crashed the same way after 7 minutes.
But this time, the problem arrived from proxmox:
{"data":{"id":"104","pid":11109,"type":"qmclone","starttime":1621756783,"status":"stopped","upid":"UPID:labprox04221:00002B65:02CA13F6:60AA0B6F:qmclone:104:root@pam:","pstart":46797814,"user":"root@pam","node":"labprox04221","exitstatus":"clone failed: command '/sbin/lvs --separator : --noheadings --units b --unbuffered --nosuffix --options lv_size /dev/pve/vm-104-disk-0' failed: got timeout"}}
2021/05/23 17:52:23 <<<<<<<<<< RESULT:

But the cloning of the VMs was successful based on ProxMox Web Interface.
Based on this old thread:
https://forum.proxmox.com/threads/proxmox-api-timeout.41939/
the proxmox API timeout is hard-coded, so even if you use a timeout in the plugin, you would still need to change proxmox code and rebuild it.


Implement conversion from Yuv422 to RGB and BGR

Implemented the trait ConvertSlice for Yuv422 to allow conversions from Yuv422 packed images to RGB and BGR images. The colorspace conversions are delegated to the existing code in the Yuv implementation.
I tested the conversion from YUYV to RGB with data from a Basler camera.

Hi, could you please rebase this against the latest master branch? I just merged the next branch into it which should have happened a long time ago.

Hi, could you please rebase this against the latest master branch? I just merged the next branch into it which should have happened a long time ago.

Done.

Hmm, it shows 13 commits and 19 changed files now. Did you merge the master branch into your local one?
This makes it hard to review the change, thus I'd propose a git rebase .. against the master branch of this repo.
Alternatively, you can checkout the master branch and git cherry-pick <your_commit> on top, that should yield the same (clean) result.

Alternatively, you can checkout the master branch and git cherry-pick <your_commit> on top, that should yield the same (clean) result.

I'm going to do this today, maybe tomorrow.

Finally I had time to clean it up. Now there is only one changed file with just my additions.


Use armv8 .quad instead of .dword

Fixes https://github.com/openssl/openssl/issues/18454.

Amends https://github.com/openssl/openssl/pull/17951.

FTR I couldn't run any tests. I hope it is covered by CI.

This has only been labelled for master branch. Shouldn't we be backporting this to 3.1?

This has only been labelled for master branch. Shouldn't we be backporting this to 3.1?

Wrong label? This PR is for branch openssl-3.1. #21939 is for master.

Wrong label? This PR is for branch openssl-3.1. https://github.com/openssl/openssl/pull/21939 is for master.

Right. Actually that's how I noticed the incorrect label (the label says master but the PR targets 3.1).
Changing the label now. @paulidale, @t8m - please reconfirm

+1

Yeah, OK for 3.1 of course.

Merged to 3.1 branch. Thank you for your contribution.


Unit('0') prints NULL factor argument and NULL unit argument

🐛 Bug Report

While reading lots of large netCDF files with iris, I noticed that my entire stderr is cluttered with the following prints:
ut_scale(): NULL factor argument
ut_are_convertible(): NULL unit argument

These come from the use of  cf_units.Unit('0') for variables with the unit '0'.
How to Reproduce
Steps to reproduce the behaviour:
Using
from cf_units import Unit
Unit('0')

correctly raises an error, but also prints the messages mentioned above:
ut_scale(): NULL factor argument
ut_are_convertible(): NULL unit argument
Traceback (most recent call last):
  File "/home/b/b309141/tmp/iris_warning.py", line 3, in <module>
    Unit('0')
  File "/work/bd0854/b309141/mambaforge/envs/esm/lib/python3.10/site-packages/cf_units/__init__.py", line 839, in __init__
    raise value_error from None
ValueError: [UT_SUCCESS] Failed to parse unit "0"

These warnings cannot be suppressed using python -W ignore or by using warnings.filterwarnings.
Expected Behaviour

These warnings should not be printed or be issued using the warnings module so they can be handled properly.
Environment

OS & Version: Red Hat Enterprise Linux 8.4
cf-units Version: 3.0.1

Looks like there are a few undocumented yet public functions in there (e.g. is_vertical, is_time).  Maybe we just need to add a new section to the docs?

The current default behaviour of printing to stderr if something goes wrong seems odd for a library, because there is no standard way in which users of the library can do something with that information. I agree with @schlunma that it would be better to use the warnigns module for that (or a logger).

Looks like there are a few undocumented yet public functions in there (e.g. is_vertical, is_time). Maybe we just need to add a new section to the docs?

#453 FTW, I think.

Hi @bouweandela @schlunma
Sorry for the usual slow response !
I've been looking into this and discovered some things (details to follow).
So, I have some opinions to share, but I'm currently unsure what to do about it.
Which sadly means, I don't think we're ready to fix this in time for a v3.3 release.
Is that going to be a problem, or can we proceed to v3.3. without a fix for this ?

Thanks for taking care of this @pp-mo! No, not a problem at all. We are happy with out current solution (that uses suppress_errors)!

I've been looking into this and discovered some things

I've inspected the main module, the Cython code and the published C interface spec, in particular the section on error handling.
And I just played around a bit.
So definitely there are other things you can do which result in the same sort of arbitrary error messages printed directly to the console.
For example :
>>> u = Unit("m").root(2)
productRoot(): It's meaningless to take the 2nd root of "m"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/net/home/h05/itpp/git/cf_units/cf_units/__init__.py", line 1329, in root
    raise value_error from None
ValueError: [UT_MEANINGLESS] Failed to take the root of Unit('m')
>>>

-- here, the line beginning "productRoot()" is a printed error message.
If the existing code logic is all correct, then presumably :

any library function which can error will return a result value which can indicate a problem
.. and those functions all also call ut_set_status
.. and any call to those functions in the Cython code also invokes raise_error to produce a Python Exception.
( N.B. most functions, but not all,  call _raise_error via one of wrap_system, wrap_converter or wrap_unit, which check for specific types of return value )

( Note: there definitely are functions which do not have identifiable error return values, such as ut_encode_time.
Presumably, we can trust that these never call ut_set_status, and thus won't emit any error messages
)
So ... assuming all that is correct in the existing code, then any operation which prints an error message should also already be calling _raise_errorto raise a Python Exception.
A better general solution ?
So, I think a better way of handling this would be to permanently set the library error handler to a C function  which records the error message somewhere global, and then include the error message text within the raised exception.
( I think you can see from the above example, that this may in some cases add useful interpretation )
Does that sound like an acceptable solution ?
Some odd notes + thoughts :

I think that a handler-type solution is required to log the messages, since AFAICT there is no other way of capturing additional arguments passed to the error handler.
we may have to handle arbitrary-length output strings, which is awkward, but perhaps calling ut_handle_error_message twice, first with a NUL stream, will be possible.  The approach taken in the format wrapper unfortunately doesn't work here, I think, as the handler function interface is less sophisticated.
i guess in this case we will have to make suppress_errors a do-nothing.  I don't like to remove it, since it is a public function (though it's another one not in the published docs, as previously noted !)


[BUG] [Terms of service] missing 'Terms of service' page, incorrect URL name

Description
'Terms of service' info is missing.
Steps to reproduce

Go to 'https://virtual-galaxy.netlify.app/faq/faq#'
Scroll down to the bottom of the page
Under 'Useful Links' - click on 'Terms of service' in the footer
Observe: 404NotFound error && URL name is the same as for 'Privacy Policy' and should be adjusted

Expected Results
Terms of service page should be displayed.
Actual Results
Instead of Terms of service info, there is a 404 "not found" error displayed:

Could you provide more information about the 'Terms of service' page? What would you like the page to include?
And please assign me to this issue, so I can fix this :)

@bugITwhisperer Do according to your choice. If you need any help regarding rules @RAHUL956777 can help you.

@RAHUL956777 : can you advise on the rules that should be included on the page please?:)

                                                          Privacy Policy

@bugITwhisperer here is a demo ...feel free to change it according to you
04-10-2023
Introduction
Welcome to virtual galaxy . We are committed to protecting your privacy. This Privacy Policy explains how we collect, use, disclose, and safeguard your personal information when you use our website . By accessing or using the Service, you consent to the practices described in this Privacy Policy.
Information We Collect
We may collect the following types of information:
Personal Information: we can use your personal information like your name and email for our further services.
Device Information: we cannot use your device information like ip..or other device informarion
Usage Data:
How We Use Your Information
We may use your information for the following purposes:
[List the specific purposes, such as providing services, improving user experience, sending newsletters, etc.]
Data Sharing
We may share your information with the following third parties:
[List third-party services or partners you share data with, and explain why and how.]
Cookies and Tracking Technologies
We use cookies and similar tracking technologies. By using the Service, you consent to the use of cookies.
User Rights
You have the right to:
Access your personal information.
Correct inaccuracies in your personal information.
Delete your personal information.
Object to the processing of your personal information.
Security
We implement reasonable security measures to protect your information from unauthorized access or breaches.
Data Retention
We retain your information for as long as necessary for the purposes outlined in this Privacy Policy.
Legal Basis
[Explain the legal basis for processing user data, if applicable.]
International Data Transfers
[Explain how international data transfers are handled, if applicable.]
Updates to the Policy
We may update this Privacy Policy periodically. Changes will be posted on this page, and the date of the latest revision will be indicated.
Contact Information
If you have any questions or concerns about this Privacy Policy, please contact us at [contact email].

@RAHUL956777 : Thanks so much for the details, Rahul! I'm on it! :)

One more question @RAHUL956777 - do you want me to remove the 'Terms of service' from the footer? And just leave out 'Privacy Policy' page to avoid content's duplication?
Or do you prefer to split the contents into 2 separate pages:

'Privacy Policy'
'Terms of service'
as we currently can see in the footer:

@bugITwhisperer ok remove it ..

@Git21221: I believe this issue can be marked as completed since the PR has been already merged.


Question: Forward to two Ports for the same Hostname?

What is troubling you?
Is it possible to forward to two Ports for the same Hostname?
Screenshot:

I am trying to use the proxy in front of ESXI server.
It works fine when uses (443) as the screenshot above, however when I connect to a virtual machine, it fails, which I assume because it's looking for the second port (902)
KB from VMWare:
https://docs.vmware.com/en/VMware-vSphere/6.0/com.vmware.vsphere.upgrade.doc/GUID-5071C86E-FF1E-4E54-A424-A20917401160.html

Note: everything works fine when I bypass the Proxy Manager, and connect directly to the internet or locally.
Please advise.

would like to know this too

would like to know this too

I have the web console and vmrc working through an different nginx reverse proxy container/project (which I believe is a little more vanilla) using some config files I found on a vmware forum a while back. The important bits seem to be adding the below code to your nginx.conf file:
#vmrc passthru

stream {

        upstream bninetwo {
                server sub.yourdomain.com:902;
        }

        upstream bninethree {
                server sub.yourdomain.com:903;
        }

        #upstream bfourtwoseven {
        #       server [internal IP of your ESXi host]:427;
        #}

        server {
                listen 902;
                proxy_pass bninetwo;
        }

        server {
                listen 902 udp;
                proxy_pass bninetwo;
        }

        server {
                listen 903;
                proxy_pass bninethree;
        }
        #server {
        #       listen 427 udp;
        #       proxy_pass bfourtwoseven;
        #}
}

As you can see I have things for 427 commented out. I wish I could tell you why exactly. Perhaps I was never able to get it to work, or it's not important to my setup, or both.
A couple of things about my environment: 1) I'm connecting to a vCenter server, not an individual host, and 2) I installed my vCenter deployment to use an IP address and not an fqdn internally.
I've only recently started to poke at this project and move my sites over, so I'm not exactly sure where this custom config would go. I assumed it would fall under the Advanced > Custom Nginx Configuration section for your host. However in my quick testing, it looks like applying the snippet above causes a failure where the "'stream' directive is not allowed here". I'm sure there's a proper method of modifying the nginx.conf file within the confines of this project, but I haven't gone searching for that quite yet. Regardless, I hope the configs above help!

Any further updates on this. Thsi also affects uploading files to the esxi data store. Pasting the above code into the Advanced page of the Proxy host services puts the server offline. Is there a way to add the custom config via the GUI.
Thanks

Quick update. I was able to get the above working by adding the following code snippet:
I'm sure this goes without saying but replace HostIP with the IP of your host
`location /sdk/ {
proxy_pass https://HostIP/sdk/;
proxy_redirect default;
}
location /ticket/ {
proxy_pass https://HostIP/ticket/;
proxy_redirect default;
proxy_http_version 1.1;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $http_connection;
}
location /screen {
proxy_pass https://HostIP/screen;
proxy_redirect default;
}`

Can confirm that the configs from @binarymime do the trick.
If anyone else continues to have issues with their setup, I will note that these settings didn't initially work for me. My vCenter appliance (v6.7) had been deployed with a static IP and the hostname was left at the default photon-machine. I had to change hostname in the VAMI console to use the fqdn (same as the proxy host/cert address). I had even tried adding some other locations such as /ui, /websso, but no matter what I would get redirected to the internal IP address somewhere between /ui and /websso (which would break completely externally and cause an incorrect redirect internally). Anyway, once the hostname was updated it was pretty smooth sailing from there. Thanks again to @binarymime !

I have the web console and vmrc working through a different nginx reverse proxy container/project (which I believe is a little more vanilla) using some config files I found on a vmware forum a while back. The important bits seem to be adding the below code to your nginx.conf file:
#vmrc passthru

stream {

        upstream bninetwo {
                server sub.yourdomain.com:902;
        }

        upstream bninethree {
                server sub.yourdomain.com:903;
        }

        #upstream bfourtwoseven {
        #       server [internal IP of your ESXi host]:427;
        #}

        server {
                listen 902;
                proxy_pass bninetwo;
        }

        server {
                listen 902 udp;
                proxy_pass bninetwo;
        }

        server {
                listen 903;
                proxy_pass bninethree;
        }
        #server {
        #       listen 427 udp;
        #       proxy_pass bfourtwoseven;
        #}
}

As you can see I have things for 427 commented out. I wish I could tell you why exactly. Perhaps I was never able to get it to work, or it's not important to my setup, or both.
A couple of things about my environment: 1) I'm connecting to a vCenter server, not an individual host, and 2) I installed my vCenter deployment to use an IP address and not an fqdn internally.
I've only recently started to poke at this project and move my sites over, so I'm not exactly sure where this custom config would go (in the UI, obviously it can go into the nginx.conf file... I'm just not sure if that messes with any automations/checks this project employs). I assumed it would fall under the Advanced > Custom Nginx Configuration section for your host. However in my quick testing, it looks like applying the snippet above causes a failure where the "'stream' directive is not allowed here". I'm sure there's a proper method of modifying the nginx.conf file within the confines of this project, but I haven't gone searching for that quite yet. Regardless, I hope the configs above help!

I know this is SUPER old but I am running into the same issue where I can view the web console just fine in ESXI and I have the exact config that you posted in my nginx.conf but if I try to run VMRC I get "could not negotiate SSL" and the VMRC logs contain:
2023-03-13T16:50:09.725Z| mks| W003: SSL: Unknown SSL Error
2023-03-13T16:50:09.725Z| mks| I005: SSL Error: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed
2023-03-13T16:50:09.725Z| mks| W003: SOCKET 2 (1756) Could not negotiate SSL
2023-03-13T16:50:09.725Z| mks| W003+ The remote host certificate has these problems:
2023-03-13T16:50:09.725Z| mks| W003+
2023-03-13T16:50:09.725Z| mks| W003+ * unable to get local issuer certificate
2023-03-13T16:50:09.725Z| mks| W003: SOCKET 2 (1756) Expected thumbprint doesn't match actual thumbprint.
2023-03-13T16:50:09.725Z| mks| W003: Expected thumbprint is: FA:D6:05:91:B8:C6:F5:98:9D:73:27:89:A9:0B:70:B3:FF:A3:BC:7B
2023-03-13T16:50:09.725Z| mks| W003+   Actual thumbprint is: A1:3B:BD:54:2C:9A:92:42:E3:CF:B1:5B:48:C7:D4:86:D4:9E:BC:B3
2023-03-13T16:50:09.725Z| mks| W003: SOCKET 2 (1756) Cannot verify target host.
2023-03-13T16:50:09.725Z| mks| W003: MVNCClient: received socket error 13: Connection error: could not negotiate SSL
2023-03-13T16:50:09.725Z| mks| I005: MVNCClient: Setting vncClient.mksConnectionError, previous error is 0, new error is 1
2023-03-13T16:50:09.725Z| mks| I005: MVNCClient: Destroying VNC Client socket.

Meanwhile the access error logs for the proxy don't report anything wrong other than some caching warnings:
2023/03/13 16:46:55 [warn] 342#342: *50264 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/5/01/0000000015 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/bower_components/vui-bootstrap/css/vui-bootstrap.min.css HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/bower_components/vui-bootstrap/css/vui-bootstrap.min.css", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:46:55 [warn] 342#342: *50264 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/6/01/0000000016 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/styles/main.css HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/styles/main.css", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:46:55 [warn] 342#342: *50264 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/7/01/0000000017 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/bower_components/es6-shim/es6-shim.min.js HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/bower_components/es6-shim/es6-shim.min.js", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:46:55 [warn] 342#342: *50264 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/8/01/0000000018 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/bower_components/requirejs/require.js HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/bower_components/requirejs/require.js", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:46:55 [warn] 342#342: *50264 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/9/01/0000000019 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/scripts/main.js HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/scripts/main.js", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:49:23 [warn] 328#328: *8 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/1/00/0000000001 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/bower_components/vui-bootstrap/css/vui-bootstrap.min.css HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/bower_components/vui-bootstrap/css/vui-bootstrap.min.css", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:49:23 [warn] 328#328: *8 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/2/00/0000000002 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/bower_components/requirejs/require.js HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/bower_components/requirejs/require.js", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:49:23 [warn] 328#328: *8 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/3/00/0000000003 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /ui/scripts/main.js HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/ui/scripts/main.js", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:49:25 [warn] 328#328: *109 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/4/00/0000000004 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /sdk/vim.wsdl HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/sdk/vim.wsdl", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:49:25 [warn] 328#328: *109 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/5/00/0000000005 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "GET /sdk/vim-types.xsd HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/sdk/vim-types.xsd", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:50:04 [warn] 327#327: *212 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/6/00/0000000006 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "POST /sdk/ HTTP/2.0", upstream: "https://<IP_ADDRESS>:443/sdk/", host: "esxi.mydomain.io", referrer: "https://esxi.mydomain.io/ui/"
2023/03/13 16:50:09 [warn] 328#328: *305 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/7/00/0000000007 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "POST /sdk HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/sdk", host: "esxi.mydomain.io"
2023/03/13 16:50:09 [warn] 327#327: *311 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/8/00/0000000008 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "POST /sdk HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/sdk", host: "esxi.mydomain.io"
2023/03/13 16:50:09 [warn] 327#327: *310 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/9/00/0000000009 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "POST /sdk HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/sdk", host: "esxi.mydomain.io"
2023/03/13 16:50:09 [warn] 327#327: *310 an upstream response is buffered to a temporary file /var/cache/nginx/proxy_temp/0/01/0000000010 while reading upstream, client: <IP_ADDRESS>, server: esxi.mydomain.io, request: "POST /sdk HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/sdk", host: "esxi.mydomain.io"

Are you still able to access your VMs via VMRC and if so did you have to import your letsencrypt cert that you can download from NRPM into the esxi web interface? I tried that as well and whenever I swapped the default certs for the ones provided by LE via NRPM I would be unable to access the web interface anymore.

I'm sorry to say that I don't use this nginx/proxymgr for vmrc access anymore. Moved away from it about a year ago when my lab developed some other criteria that took me elsewhere.
I do remember parts of the setup though and am almost certain that I never had to copy any LE certs around. I also remember that the conf file didn't change and I took it out of commission right around vCenter 6.7 U2 or U3.
Wish I could be of more help! 🤞🏻 that @binarymime is still roaming the halls and might have something to add. Best of luck either way.

Thanks for the quick reply anyway, what are you using now?

Thanks for the quick reply anyway, what are you using now?

A tunneling/access solution from a company that rhymes with Schmoudflare ;). Which actually looks like it has challenges and limitations supporting vmrc as well but because I moved away from my vCenter server altogether I was able to let this one go at the same time.

I also tried copying the LE certs from NPM to the ESXI host but that just caused the ESXI host to throw "connection refused" errors when I would try to connect afterwards.

I noticed that you specified ESXi and host  again in your follow up so I want to make sure I clarify on something else from above. I could be incredibly wrong here, but I have memory of this config not working with ESXi hosts directly. I want to say that the only time I had success with it was with a vCenter server instance (the photon based virtual appliance from VMware if that matters). I hope I’m misremembering this for the sake of your troubleshooting, but if you have a vCenter trial and a little bit of time to burn through it might be worth a spin. And many apologies in advance if that doesn’t pan out to be true.

Success! I finally figured out what the issue was. After banging my head against the wall because I could not find anyone out there who is trying to do this with ESXI 7.0 without VCenter, I started to dig into the innards of LetsEncrypt and Certbot and the various errors I was getting in my hostd log in Esxi. It turns out that by default LetsEncrypt will generate certificates with a key type of ECDSA. If you modify your letsencrypt.ini file and change the type back to RSA (what it used to be a long time ago) and generate the cert yourself via the command line within the running NPM container and then copy those certs to your ESXI instance then the cert will work with ESXI and VMRC without issues.
I have not yet attempted this via NPM exclusively (changing the config to use RSA keys and then just using the reverse proxy to pass the SSL connection to ESXI/VMRC). Right now my setup is that every internal service I have running is DNS'd to NPM except for ESXI which has its own DNS entry pointing towards its actual IP address and domain name (which matches the cert).
Posting this here in case anyone else stumbles across this issue.


Update PULL_REQUEST_TEMPLATE.md

Improve pull request template:

remove 2.x label
convert checklist into a standard list
suggest to use a label in the title when merging in a branch other than develop

Replaces #5576

Merged in the wrong branch, created a new one for develop: https://github.com/aws/aws-parallelcluster/pull/5588


Training Graph-Transformer

Kindly explain these text files in the Training Graph-Transformer and their format, from where i get these text files?
Split training, validation, and testing dataset and store them in text files as:
sample1 \t label1
sample2 \t label2
LUAD/C3N-00293-23 \t luad
...

The text files mentioned are used to store the data samples and their corresponding labels in a tab-separated format. Each line in the file represents a single sample, where:

sample1: Refers to the identifier or path to a sample (e.g., file name, image ID, or dataset ID).
label1: Indicates the label assigned to that sample (e.g., cancer, normal, or specific classes like luad for lung adenocarcinoma).

The format is as follows:
sample1 \t label1
sample2 \t label2
LUAD/C3N-00293-23 \t luad
...
How to Create These Text Files:

Source the Data: Labels such as cancer or normal can often be obtained from public datasets like the GDC Data Portal or other datasets appropriate for your task.

Split the Dataset:

Training Set: Used to train the model.
Validation Set: Used to monitor model performance during training and prevent overfitting.
Test Set: Used to evaluate the final model's performance on unseen data.
Ensure that these splits are mutually exclusive to maintain the integrity of the evaluation.

Prepare the Files:
For each split (training, validation, and testing), create a text file where each line contains a sample and its label, separated by a tab (\t).

Example Workflow:

Download the dataset from a public source (e.g., GDC).
Parse the dataset to extract the sample identifiers and labels.
Randomly split the dataset into training, validation, and testing sets.
Write the splits into separate text files (e.g., train.txt, val.txt, test.txt) in the format specified.

Example:
For a dataset with samples categorized into cancer and normal, the files might look like:
train.txt:
sample1 \t cancer
sample2 \t normal
sample3 \t cancer
val.txt:
sample4 \t normal
sample5 \t cancer
test.txt:
sample6 \t normal
sample7 \t cancer
These files can then be fed into a Graph-Transformer training pipeline, where the model uses the training set to learn, the validation set to tune hyperparameters, and the test set to evaluate its performance.


Recipe error message when updating to 5.1.51

Issue Description:
Previously working user recipe file is now throwing an error message when updating to 5.1.51
Recipe file:   https://pastebin.com/PZPwp62A

What happens:
Previously working user recipe file is now throwing an error message when updating to 5.1.51
What you expected to happen:
For the previously working user recipe file not to cause an error message after updating to 5.1.51
Steps to reproduce:

Have previously working user recipe XML
Update to EnderIO version 5.1.51
Get error message when launching modpack.
Regret yet again having issues with the XML file configs.
...

Affected Versions (Do not use "latest"):
EnderIO: 1.12.2-5.1.51
EnderCore: 1.12.2-0.5.69
Minecraft: 1.12.2
Forge: forge-<IP_ADDRESS>38
SpongeForge? no
Optifine? no
Single Player and/or Server? both
Your most recent log file where the issue was present:
https://pastebin.com/m6yrJfeX

The "<?xml " at line 166 is invalid XML. This must have created an error also in the previous version.

Actually, the old versions ignored everything after the </recipes>. There should be a bug report about that around somewhere...


Angular Strict Template for /app/exam/participate/summary/

Motivation and Context

Angular strict template fixes
Steps for Testing

Create an exam, then participate this exam with student credentials
Finish and submit the exam, go to exam summary page
Should behave as usual

The client tests fail. Please fix them.


Items found in review of Python version of CDK Workshop

Let me know if you'd like me to break these up into separate issues. It was easier to just track them in one place while doing the review. A couple of these aren't issues with the Workshop but rather things in the cdk tool.

Why don’t the code snippets have a light/dark toggle like in the Dev Guide?  :-)
On Windows, the output of cdk init is full of terminal codes that would produce color and boldface on a linux system, but here make the output almost unreadable. Screen shot attached.

Not a problem in the Workshop per se of course. The color works fine when doing other things with the CDK, oddly.
Missing prerequisite: On Windows, Python needs to be installed so it’s on the PATH. Unfortunately, this is not the default! (It’s a checkbox on the first page of the Windows installer.) Without Python on the PATH, cdk init won’t create a virtualenv, which then throws off a lot of things...
I noticed that the cdk init output says that the CDK expects a Python executable named python3. The Windows Python installer does not install such an executable. Fortunately cdk init seems to work regardless as long as Python's on the path; however, this text should probably be changed. On Windows there’s a launcher called py that gets installed in C:\Windows so it’s guaranteed to be on the PATH. It is responsible for reading shebang lines from executed scripts (since Windows doesn’t do that natively) and launching the specified Python executable, among other things. So on Windows maybe just use that. Then you don’t have to worry about the interpreter being on the PATH.
The command given to activate the virtualenv on Windows uses the wrong slashes. Normally Windows is happy to use forward slashes in paths; however, when specifying an executable, it looks like you must use backslashes. .env\scripts\activate.bat will work.
I’m noticing that a lot of the cdk screenshots are a lot less colorful than the cdk actually is. Haas the cdk tool been upgraded recently to be more colorful? Maybe update the screen shots.  :-) Whoops, those aren't screen shots. The syntax coloring should be turned off for those snippets, or else screen shots should be used if the color is important.
The API Gateway topic tells you to put some code in, but it doesn’t say which file it goes in. hello_stack.py is the last file you were working on in the previous topic and it does indeed go in there, but it would be nice to mention that.
In the Hit Counter Handler topic, the highlighted code (that indicates the lines you need to add to hitcounter.py) does not include the function definition for the handler() method (and its @property decorator), which does need to be added.
The Use The Hit Counter topic instructs you to open lib/cdk-workshop-stack.ts, which doesn’t exist in this Python project. It should be hello/hello_stack.py.
Also, the imports in the new version of this code are in a different order than the original code you’re modifying. They work fine but it may throw readers off if their file is even slightly different from the one you think they have.
In the Cloudwatch Logs topic, users are instructed to click View On CloudWatch Logs, but the actual name of the button is View Logs in CloudWatch (it’s shown in the screen shot).
In Granting Permissions, you’re told to add the “highlighted lines” to hitcounter.py. There’s only one line highlighted. (Only one line is in fact needed; the plural in the text is wrong.)
At the end of the Test the Hit Counter topic, we’re told we’ll next consume a construct library published in npm. That's for Node.js; this should say PyPI.
In the Installing the Library topic, output is given for pip install command. There’s actually a lot more output; it should indicate that these are only the last two lines of the output (e.g. with an ellipsis).
In Add the Table Viewer to Your App topic, you’re told to edit lib/cdk-workshop-stack.ts. This should be hello/hello_stack.py.
In the Exposing Our Hit Counter Table topic, you’re told to edit hitcounter.ts. This should be hello/hitcounter.py.
The code in this topic changes table = ddb.Table( to self._table. Similarly, the ‘HITS_TABLE_NAME’ definition should be changed to self.table.table_name, and.table.grant_read_write_data needs to be changed to self.table. These changes are in the code but aren’t highlighted as changes. They should be highlighted so users know to make them.
The tip in the topic suggests holding down the Control or Command key and clicking on TableViewer to see the source code for its definition. This will depend on the editor you’re using, probably? Maybe say “in many editors (we use VS Code)” or something similar.
I noticed that when selecting text in the code blocks, the selection is invisible in Firefox. This is annoying. Also, selection works fine in dark mode in the CDK Dev Guide, so not sure why it doesn't work right here. (Works OK in Chrome and Edge, though.)

@Jerry-AWS FYI I have raised some Pull Requests to fix a few of the changes you have listed above. Specifically the references to TypeScript files and the additional lines that needed highlighting in your point 16.
There are a lot of points here, I would encourage you to also raise some PRs if you want to suggest a change to anything else in the docs. The simplest way is to do this via the Github website by just pressing the pencil icon to edit the file in question. It's the best way to demonstrate a specific change to the maintainer as it will show the diff.

@stevenbryen I'll put together some PRs for some of these.

I've crossed out some of the items in my original report. Some of them because they're cosmetic, others because they are not bugs in the Workshop (I've reported them against the CDK), and of course the ones you already submitted PRs for them. I'm going to work on PRs for the rest.

@stevenbryen I've put together PRs for most of the items I found. Please let me know when these get merged and posted and I'll run through the workshop again.


Retroactive Charging Cost Disappears

When I go to edit my existing Geofence to add retroactive charging costs, the popup box briefly appears and fades away quickly. There are many charges that are linked to the fence and have no cost reported. I don't see anything in the browser console that indicates an error. Any ideas? v1.18

Are there any errors in the logs? (The bug report template describes how to view the logs)

I walked through the steps again and checked the docker log, nothing but standard get/sent requests/responses for the geofence.  I've tried another browser and experienced the same issue.  Is there a reason it would show and then disappear?  It shouldn't show at all unless there are other charging sessions, correct?

I deleted and re-added the geofence and it prompted me to update all the charging sessions with the new rate.


Fix inlining on subtypes - test cases, minor fixes

This PR contains a test case and adds some minor fixes for PR #763, which contains the fix for issues #614 and #740 .

Hi @mpetruska, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@mpetruska, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

@mpetruska  we will likely get to look at this in the new year but it sure was a great present, thank you.

@mpetruska in your opinion is this PR ready to pull?

Marking WIP until the questions above are answered

I think we can close this since there's been no action for quite a while.  I'm not sure what additional cases are being covered here


Flutters app name in launcher and name in recent apps tray is different

heres my app in launcher
and in the recent apps the name is different

How do I change it to app name

You change the title property on your MaterialApp widget. See this answer here: https://stackoverflow.com/questions/50615006/where-does-the-title-of-material-app-used-in-flutter

You change the title property on your MaterialApp widget. See this answer here: https://stackoverflow.com/questions/50615006/where-does-the-title-of-material-app-used-in-flutter

thanks this perfetly answers my question I am closing the issue

The Flutter documentation points out where you can change the display name of your application for both Android and iOS. This may be what you are looking for:
Preparing an Android App for Release
Preparing an iOS App for Release
For Android
It seems you have already found this in the AndroidManifest.xml as the application entry.
Review the default App Manifest file AndroidManifest.xml located in /android/app/src/main/ and verify the values are correct, especially:
application: Edit the application tag to reflect the final name of the app.
Find More Here


Privatekey

hi
thanks for this repo
would mind please telling me how to achieve private key?
i could run your script and the only thing that misses is Private key
best

Ah, the private key that goes on that line is the one you used when generating the public key the script asks for.

the thing is i don't have the privatekey at all.
the script asks for uesrname,password and a pubkey ( wich i don't have this one)

At least on Linux, you use the wg tool to generate both. The Wireguard site has info on all that stuff. The surfshark script kind of assumes some level of familiarity with setting up Wireguard in general.
https://www.wireguard.com/quickstart/

thank you for sharing the link
best

No problem :)


Not working on Windows with latest nvim-treesitter version

I recently updated nvim-treesitter to lates and I getting this error:

NeoVim version:

NVIM v0.9.0-dev-1175+g89a525de9
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Nvim-TreeSitter version:

commit cfa9b70ee85f9ead92c691cbc0b134a441864080 (HEAD -> master, origin/update-readme-pr, origin/master, origin/HEAD)
Author: GitHub<EMAIL_ADDRESS>Date:   Fri Mar 10 08:32:38 2023 +0000
Update parsers: query, sql

Sorry about that, I downgraded NVim to latest stable-release and the trouble dissapears.
I will close this Issue. Ty!


Client immediately disconnects

Describe the bug
Client logs in, automatically gets disconnected without ever seeing the world and stacktrace is thrown into the console.
To Reproduce
Steps to reproduce the behavior:

Install mod on Bloomhost
See error

Expected behavior
The client should not get disconnected.
Runtime info (please complete the following information):

OS: Probably Linux
Minecraft version: 1.19.2
Mod version: vmp-0.2.0+beta.7.0

Crash reports / logs
latest.log
Other mods

Checklist

[x] I am using the official version of the mod.
[ ] I tried the latest development version but the issue persists.
[x] I searched for similar open issues and could not find an existing bug report on this.

Additional context
The server runs on Bloomhost.

It still bugs with only vmp installed.

Updated to beta.7.11 and changed use_multiple_netty_event_loops to false in the config. Now it works.
use_multiple_netty_event_loops=false


refactor: update default value $hashCost to 12

Description
Explain what you have changed, and why.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Explain what you have changed, and why.

Please write it. We know what you did from git commits, but it is difficult to know why.

Update PR Description.

We could probably do this internally so the user doesn't have to think about it. I did it that way as a test in the forums because they were running soooooo slowly and there wasn't any real need to.
It might be possible to find another way where we can do away with hash costs altogether in testing, but I'm afraid that might be challenging and (maybe?) limit some other's testing abilities. Unsure exactly how that would work at the moment.

It might be possible to find another way where we can do away with hash costs altogether in testing, but I'm afraid that might be challenging and (maybe?)

How about the change phpunit.xml.dist?
<env name="auth.hashCost" value="4"/>

doh! That's perfect for Shield. That wouldn't take for user's apps, but we could add a note to the testing section of the docs about that change for their apps.

All thanks, I sent #1041.


made warden dev ready for ruby 1.9.x

hi,
i wanted to understand wardens implementation and ran into two problems when setting the project up on my mac. i noticed two problems that are related to the changes from ruby 1.8 to 1.9
firstly, it complaint when sending strip! to warden's version string in the gemspec because it was freezed. looking at device's way to do it i changed line 7 in warden's gemspec to dup the string
s.version = Warden::VERSION.dup
secondly, the specs did complain about wrong number of arguments for some methods and failed. turned out that the single argument that is passed to a rack application's call method gets also applied to a nested block that was created with lambda{} in ruby 1.9. so i changed
blk = opts[:configurator] || lambda{}
to
blk = opts[:configurator] || proc{}
which works fine and passes all test in 1.9 now. nevertheless, i don't know whether the change breaks anything i might not understand at the moment. but since it's just a test helper method it shouldn't be much of a problem if it did.
sincerely,
linki

blk = opts[:configurator] || lambda{} is used in setup_rack in spec/helpers/request_helper.rb line 18


network docs cleanup

This fixes some Markup and formatting issues in the network documentation;

wrap text to 80 chars
add missing language hints for code examples
add missing line continuations ()
update USAGE output for Cobra

retest this please

LGTM :+1:


Set 'abbr' to empty string if not set

While setting up the new combine matcher (which is great, thanks!) for vimtex, I noticed that ncm2 initializes the abbr field to word in https://github.com/ncm2/ncm2/blob/master/pythonx/ncm2.py#L85. Is there a specific reason for this? This prevents me from matching word more strictly than abbr; for this purpose,
 if 'abbr' not in e or type(e['abbr']) != str:
            e['abbr'] = ''

would be needed. (This would also be more consistent with the other fields.)

Ah, so for ncm2 abbr is more fundamental than word -- from :h complete-items, it seemed the other way arround:

  abbr            abbreviation of "word"; when not empty it is used in
                  the menu instead of "word"

This sounded like an empty abbr is the default, and in my test the change I mentioned above does work exactly as I need, but of course I always only have a single (omnifunc) source.
Unless I misunderstand, your suggestion doesn't really help here, since I want to remove something from the results, which ncm2 will then re-add anyway? Is there any way to match on abbr only when it is different from word?

Unless I misunderstand, your suggestion doesn't really help here, since I want to remove something from the results, which ncm2 will then re-add anyway?

You could wrap the omnifunc and create extra fields,
item.orig_abbr = get(item, 'abbr', '')

And then you could use a matcher to filter on orig_abbr.
There're ways to do this. You could even wrap ncm2_core.match_formalize, just like how ncm2-match-highlith does. Though this is not recommended, since the undocumented part is more likely to change.

I see, yes, this makes sense. Actually, I think I see now how to do this with multiple ncm2 sources that call omnifunc with different matchers based on the context.
Sorry for spamming so many issues and comments -- I do appreciate your time answering them, which has been quite helpful!

Hmm, no, that doesn't quite seem to work. I might have gotten the regexp wrong, but in principle I should be able to register two different sources that complete depending on the regexp, e.g., the first one triggers on matching (for simplicity) \\[A-Za-z]*[^{]$ (so for \cit but not \cite{) and the other one on matching \\cite{* (so vice versa)?

There's no need to use $ in complete_pattern.
NCM2 cache completion results based on word_pattern.  which means \cite{sometext| will also trigger completion for { if there's no cache for the source.
See https://github.com/ncm2/ncm2/blob/master/pythonx/ncm2_core.py#L412 for how complete_pattern actually works

Right, I see (sorry for the off-the cuff regexp). Using word_pattern kind of works, but I have problems with the wrong regexp triggering when it shouldn't -- but only if it's in a list ('word_pattern': 'regexp' works correctly, but 'word_pattern': ['regexp'] doesn't). Is this a bug for which I should open an issue, or am I doing something wrong?

word_pattern is not a list.
There's a few examples in the doc. (:help ncm2#register_source) They might help you understand how thoes patterns work.
        complete_length: 3
        complete_pattern: ['\.']
        word_pattern: '\w+'

            typing            : foo_service.request()
            complete trigger  :   ^        ^
            startccol         : x           x
            base              : [.........] [.....]

            typing            : fd.read()
            complete trigger  :   ^
            complete trigger  :    x
            base              :    [..]

        complete_length: -1
        complete_pattern: ['/']
        word_pattern: '\S+'

            typing           : first/second/third
            complete trigger :      ^      ^
            startccol        : x
            base             : [................]

Oh, I see, then I misunderstood this. So if I want to trigger a certain source based on a (list of) regexp patterns, that's currently not possible?

Ah, now I get it! It's the complete_length that was the problem -- this controls completion independently of the complete_pattern. So if I set it to 1 (which I did based on https://www.reddit.com/r/vim/comments/8ws2kl/nvimcompletionmanager_is_now_ncm2/e27nt9k), it overrode the regexp.  Setting it to -1 instead (or leaving it completely -- or does that have other side effects?) makes everything behave as I want.
Thank you so much for your help and patience! (And sorry for not reading the documentation in more detail; now that I know what the issue is, I can see that it's already explained there...)

Set complete_length to -1 if you want to control the completion trigger explicitly by complete_pattern.
Leaving it empty will be defaulted by the framework using :help g:ncm2#complete_length

Understood. Last question, while we're at it, since I'll be adding this to the vimtex documentation: What would you recommend for the priorities here?

I'm not familiar with latex. But in general, If vimtex is the smartest completion engine available for latex files, it should be 9. If you have better options for latex files, set it to lower priority.

It will be until someone creates ncm2-tex and ncm2-bibtex 😄  I'll set it to 8 for now. Thank you for all your help! I'm really happy with ncm2 so far!

FWIW, I've replace the boring pure text explanation with a more interactive script example. https://github.com/ncm2/ncm2/commit/0bf906b76636dc6ac5635660e884229138b8608d
It should be way more helpful for debugging and understand how ncm2 works.

I've replaced the boring pure text explanation

Could you please leave both? I actually liked it, and it helped me understand the difference between complete_pattern and word_pattern...

Ok, now both versions are available.


Question: What are sain defaults for lightSettings?

At the moment, the lighting module seems very scene specific and takes a good bit of understanding light design in order to use.
To speed up prototyping, I've been thinking about how to abstract away lightSettings prop for the solid polygon layers (or any layer that might use it). In other words, I've been wondering what a "sain default" value for this prop might look like.
My current idea isn't super straightforward, and I was wondering if anyone has a better idea than this:

calculate bbox of data
create 4 lights, positioned higher than and outside of any data vertex, pointed at each corner of the bbox
hard code other light settings to something that will generally work. Perhaps a wide cone, that is medium strength?

If I knew a way to pick these values based on distance between lights, or size of object, etc.. I would do that instead

Is there a more general way of setting up my lights?
If not, any recommendations on how to learn light design?

Our light system is rather rudimentary. For natural outdoors look, you probably want a directional light (rather than point lights) representing the sun and some ambient light.

What are the settings for that kind of light?

Our current lighting system is pretty premature, which only supports point lighting, so requires setting light positions. Ideally we need support directional lighting as default which could rotate along with user's eye position, don't need a light position at all.


new security rule: detect-child-process

https://github.com/nodesecurity/eslint-plugin-security/blob/master/rules/detect-child-process.js

I'd like to help, how can I contribute @JoshuaKGoldberg ?
I assume it's an implementation of an ESLint functionality to TSLint?

Heya @jasperdanan, glad to have you contribute!
Correct. The eslint-plugin-security rule looks good and we'd like to have an equivalent in tslint-microsoft-contrib so that TSLint users can get the same rule benefits.
This isn't quite a copy & paste job, since the ASTs for ESLint and TSLint are different, but the functionality should be about the same.
Is that enough info to go off of?

Yep!
I'll try figuring out the code first.
Is there other things to do like updating the ReadMe with the new rule?

if this https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/src/nonLiteralRequireRule.ts is an implimentatiion of https://github.com/nodesecurity/eslint-plugin-security/blob/master/rules/detect-non-literal-require.js

Yup, that's correct. It looks like ours is checking for arrays passed to require, but otherwise they're roughly the same.

Where should I put the new rule? Under/src/ ?

Yup! https://github.com/Microsoft/tslint-microsoft-contrib/pull/543 is a good example of what you'll want to add:

New rule under src/
Corresponding new test file under src/tests
New entry in README.md describing the rule
New line in tslint.json enabling the rule locally

The recommended_ruleset.js and tslint-warnings.csv should be auto-generated by some tasks within grunt all once you have a passing build.
Let me know if that's not the right or not enough information to go off of!


Absurd flickering above 15 FPS

Godot version:
3.1
OS/device including version:
Windows 10 x64
NVIDIA GeForce GTX 1060 6GB
Issue description:
I made this by code. Then I  saw that it was very flickering.

Each tile is a KinematicBody (parent) with two children (MeshInstance and CollisionShape)
I reduced it to 30 fps (Project Settings -> Debug -> Settings -> Force Fps) and it did not change:

Reducing to 15 fps, it has improved a lot

I also tried switching from GLES3 to GLES2 but the problem continues.
What's going on?
Minimal reproduction project:
esteira.zip

Forget it.
The problem was that I had a lot of print() in my code to debugging...
Removing those print(), it's ok now.


Fix race condition @ P2P client

This was a cheeky race condition. For each of its endpoints, the P2P client first attempts to send request to a request worker immediately. If it can not be handled immediately, it checks if its allowed to block for this request and if so, sends the request again and blocks until the request is eventually picked up by a request worker.
The issue, as it turns out, is that the code meant to sent the request a second time in a blocking fashion, also executes if the request was able to be handled synchronously, therefore handling it twice.
Not only would this bug cause the app to perform double work, it even effectively could make requests that were handled synchronously, to block as part of the erroneous second execution.
As a result, this fix should significantly increase how consistent the P2P client responds to requests.

Nice find!


[sil] Change SILResultInfo::getOwnershipKind to always take a CanGenericSignature.

[sil] Change SILResultInfo::getOwnershipKind to always take a CanGenericSignature.
This caused a crasher when running the ownership verifier. I don't have a test
case right now, since it happened several weeks ago.
The bug can not happen again since I eliminated the nullptr default argument.
rdar://29791263

@swift-ci Please smoke test and merge


Update Armor and Item Names to have new Super Store items.

Lacking Item Descriptions

I'm seeing overlap with #41, won't this cause issues?

I'm seeing overlap with #41, won't this cause issues?

Hm... I thought I avoided putting the super store stuff in the other pull request :(

I'm seeing overlap with #41, won't this cause issues?

Fixed, Super Store items removed from #41


Properly quote injection template labels

Fixes https://github.com/istio/istio/issues/30667

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7c4308259aa84cf17b85e55c235c96505f3d67f0
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #30677


invalid syntax error while importing tensorflow and keras

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):windows 10
TensorFlow installed from (source or binary):source
TensorFlow version:1.8.0
Python version:3.8.5
Installed using virtualenv? pip? conda?:virtualenv

Provide the exact sequence of commands / steps that you executed before running into the problem
Traceback (most recent call last):
File "c:/Users/win10/Desktop/python projects/try.py", line 5, in
import keras
File "C:\Users\win10\tensor\lib\site-packages\keras_init_.py", line 3, in
from tensorflow.keras.layers.experimental.preprocessing import RandomRotation
File "C:\Users\win10\tensor\lib\site-packages\tensorflow_init_.py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "C:\Users\win10\tensor\lib\site-packages\tensorflow\python_init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\win10\tensor\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\win10\tensor\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 124
def TFE_ContextOptionsSetAsync(arg1, async):
^
SyntaxError: invalid syntax

Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@mjvithesh
Is there any particular reason for using such an old tf version when there are latest available, we have support for tf 1.15 and 2.x.
I see you are using python 3.8 which is compatible from tf 2.2 version only.
need be you may follow installation at this link..

I couldn't install the latest version

ERROR: Could not find a version that satisfies the requirement tensorflow (from versions: none)
ERROR: No matching distribution found for tensorflow

@mjvithesh
Please refer to this comment and let us know.
you may also refer to: #42977 #43244 [can you please verify if your python/cpu is 64 bits] #33838 , also please upgrade your pip version if you are unable to upgrade to 2.2, or try to down grade your python 64 bit and tf to 2.x version or 1.15

Let me add some activity here. Before 2.3.1, keras used to autodetect backends and play nicely. Now this explicit badly importing line in 2.4.x onwards adds this:
    from tensorflow.keras.layers.experimental.preprocessing import RandomRotation

What is that supposed to even mean? That keras always requires this variable? This is terrible, and import guards must be added, this library is hardly useful anymore with this sort of tight coupling.