Improve Performance/StringReplacement cop

Description
Don’t use String#gsub in scenarios in which you can use a faster and more specialized alternative.
https://rubystyle.guide/#dont-abuse-gsub
https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancestringreplacement
https://github.com/fastruby/fast-ruby/blob/main/code/string/gsub-vs-sub.rb
Behavior
url = 'http://example.com'

# bad
url.gsub('http://', 'https://')

# good
url.sub('http://', 'https://')

I've benchmarked it.
I created the Dockerfile:
FROM ruby:3.2.2
COPY . /var/www/ruby
WORKDIR /var/www/ruby
RUN gem install benchmark-ips
RUN ruby -v
CMD ["ruby", "file.rb"]

and used file.rb:
Ruby 3.2.2
ydakuka@yauhenid:~/ruby-docker-app$  docker run ruby-app
Warming up --------------------------------------
         String#gsub   107.704k i/100ms
          String#sub   134.474k i/100ms
Calculating -------------------------------------
         String#gsub    833.673k (±18.1%) i/s -      4.093M in   5.107144s
          String#sub      1.247M (± 6.7%) i/s -      6.320M in   5.097910s

Comparison:
          String#sub:  1247070.7 i/s
         String#gsub:   833673.0 i/s - 1.50x  slower

Ruby 2.7.8
ydakuka@yauhenid:~/ruby-docker-app$ docker run ruby-app
Warming up --------------------------------------
         String#gsub   117.163k i/100ms
          String#sub   127.644k i/100ms
Calculating -------------------------------------
         String#gsub      1.177M (± 4.4%) i/s -      5.975M in   5.088399s
          String#sub      1.575M (± 8.9%) i/s -      7.914M in   5.076289s

Comparison:
          String#sub:  1575366.7 i/s
         String#gsub:  1176824.3 i/s - 1.34x  slower

And the second case (https://github.com/fastruby/fast-ruby/blob/main/code/string/gsub-vs-tr-vs-delete.rb).
https://github.com/shopify/ruby-style-guide#strings
https://github.com/fastruby/fast-ruby/blob/main/code/string/gsub-vs-tr-vs-delete.rb (similar to this)
Behavior
str = 'lisp-case-rules'

# bad
str.gsub(/[aeiou]/, '')

# good
str.delete('aeiou')

I've benchmarked it with file.rb:
require 'benchmark/ips'

URL = 'lisp-case-rules'

def slow
  URL.gsub(/[aeiou]/, '')
end

def fast
  URL.delete('aeiou')
end

Benchmark.ips do |x|
  x.report('String#gsub')   { slow }
  x.report('String#delete') { fast }
  x.compare!
end

Ruby 3.2.2
ydakuka@yauhenid:~/ruby-docker-app$  docker run ruby-app
Warming up --------------------------------------
         String#gsub    42.166k i/100ms
       String#delete   315.027k i/100ms
Calculating -------------------------------------
         String#gsub    425.557k (± 2.5%) i/s -      2.150M in   5.056820s
       String#delete      3.161M (± 3.4%) i/s -     16.066M in   5.090150s

Comparison:
       String#delete:  3160821.4 i/s
         String#gsub:   425556.6 i/s - 7.43x  slower

Ruby 2.7.8
ydakuka@yauhenid:~/ruby-docker-app$ docker run ruby-app
Warming up --------------------------------------
         String#gsub    40.106k i/100ms
       String#delete   243.927k i/100ms
Calculating -------------------------------------
         String#gsub    554.460k (± 9.0%) i/s -      2.767M in   5.052299s
       String#delete      2.326M (± 4.7%) i/s -     11.708M in   5.046484s

Comparison:
       String#delete:  2325724.6 i/s
         String#gsub:   554459.7 i/s - 4.19x  slower

sub and gsub aren't interchangeable; one can't be safely recommended over the other
'aaa'.sub('a', 'x')  # "xaa"
'aaa'.gsub('a', 'x') # "xxx"

I know, that's why my examples are given for unambiguous cases.

How rubocop can guess if you need to replace all occurrences or just one?

How rubocop can guess if you need to replace all occurrences or just one?

I meant that the args passed to #gsub is always 'http://' and 'https://'.
I agree I chose the very edge case for the first case.


investigate github CI-CD capabilities for mobile applications

check ios and android runner capabilities

need to investigate how to setup the runner because it is multi-platform repo
useful links found so far

https://docs.github.com/en/actions/about-github-actions/understanding-github-actions
https://docs.github.com/en/actions


Ch 11.3 MyRegistration view issue

The code provided for modifying the registration view appears to be incorrect. The first block is what is in the book.
class MyRegistrationView(RegistrationView):
    def get_success_url(self, request, user):
        return '/rango/'

But if you follow the class inheritance down to RegistrationView in registration/views.py the get_success_url signature is the following.
def get_success_url(self, user=None):
    """
    Use the new user when constructing success_url.

    """
    return super(RegistrationView, self).get_success_url()

And thus I believe this is the correct definition and doesn't cause any errors to be thrown.
class MyRegistrationView(RegistrationView):
    def get_success_url(self, user):
        return '/rango/'

Spot on - thanks for the spot. I think were still using an older version of django-registration-redux there. Corrected and updated. Many thanks.


Feature Request: Reliability diagram based on S-Scale

SWPC has test UMASEP by checking "if the model predicts and S3, do you measure an S3?" Implement this in SPHINX.

Sounds like a generalized MxN contingency table.  People have worked out metrics that deal with these.

Yes, there are definitely prescribed ways to do the analysis and we can implement something from the literature. I haven't yet identified a source to derive the approach though.
We will also need this because REleASE will issue a three-tiered Quiet, Warning, and Alert state. I think we can validate according to the same analysis, although we will have to put some thought into exactly which observed conditions should be associated with the different states.


Request for Ideas to Enhance an Existing Paper in Open Source

Request for Ideas
Hello open-source community & DeepCS233,
I hope this message finds you well. I am reaching out to seek your input and ideas regarding an exciting project I am planning.
My intention is to use this paper as a baseline and work on top of it to contribute valuable enhancements and additions. However, I would greatly appreciate your insights, ideas, and suggestions on what specific aspects or directions I could explore to make this project truly beneficial for the open-source community.
What I'm Seeking
I am interested in any ideas, recommendations, or potential features that you believe would complement the existing paper and contribute to the open-source community. These ideas could include:

Improvements: Suggestions for improving existing methods or algorithms.
Extensions: Ideas for extending the paper's concepts into new areas.
Other Ideas: Any other creative thoughts you may have to enhance the project.

Your insights, whether big or small, can help shape the direction of this initiative and contribute to the open-source community's growth.
How to Contribute
If you have any ideas or suggestions, please share them by commenting on this issue. I am open to engaging in discussions, collaborating, or even creating sub-projects if there are specific aspects that require dedicated attention.
Thank you for taking the time to read this request. Your contributions will be highly valued, and I look forward to working together to expand and improve upon the foundation provided by the paper.
Best regards,
Naren

Hello Naren,
Thank you for reaching out. For the project you mentioned, I suggest exploring the temporal direction, specifically tackling long-sequence decision-making problems such as overtaking. This could offer valuable enhancements and extensions to your initiative.
Looking forward to potential collaboration and witnessing the progress of your project.
Best regards,
Hao

Hi Dr. Hao,
I am currently continuing your project, and I am exploring aspects of the temporal direction. Here, I am finding it difficult to show the results of my work, like Driving Score, Route Completion, and Infraction penalty. As, I have to showcase results at the end of my project.
I ran the model several times and got several checkpoints under "/interfuser/output/*", and the last checkpoint seems to drive the car well, but I am unsure how to calculate the parameters. I know about the instructions given here, https://leaderboard.carla.org/. But I am here to ask how to let the model spit out the results automatically.
Another less priority help, is there any documentation you suggest or which files to change under this repository to accomplish this temporal logic performing long-term decisions? I am new to AI or research; you can view my profile. I will make use of any help/ documentation you throw at me! I am open to connecting through social media and building a network.
Thanks,
Naren
Portfolio: https://naren200.github.io

Hi!
After finishing the model training, you still need to evaluate it in a closed-loop manner to get the final results, such as the driving score, and route completion. For your reference: https://github.com/opendilab/InterFuser?tab=readme-ov-file#evaluation
For the second question, I have some suggestions:

model definition: https://github.com/opendilab/InterFuser/blob/main/interfuser/timm/models/interfuser.py
training dataset: https://github.com/opendilab/InterFuser/blob/main/interfuser/timm/data/carla_dataset.py
agent definition: https://github.com/opendilab/InterFuser/blob/main/leaderboard/team_code/interfuser_agent.py


Add Kind constraint

@plbt5 , this is ready for review and merge.

I can only review; I seem to be limited in write access to this repo, hence cannot do no merging.

I can only review; I seem to be limited in write access to this repo, hence cannot do no merging.

Sorry, try now.


There should be a way to re-hydrate an instance of BlobSASPermissions from JSON

Is your feature request related to a problem? Please describe.
Our current solution stores an instance of BlobSasPermissions to CosmosDB in the form of JSON. See an example below:
{
    "read": true,
    "add": false,
    "create": false,
    "write": true,
    "delete": false
}

The reason this happens is because we store it as part of an object hierarchy that looks like this:
MainRequestObject:
    - BlobSasPermissionsObject

We run into an issue when calling generateBlobSASQueryParameters with a re-hydrated version of BlobSasPermissions from this JSON format as it loses it's toString() implementation in the process (and there is no way to instantiate BlobSasPermission from anything other than the simple permission string format eg. 'rwx'). So passing our re-hydrated BlobSasPermissions causes generateBlobSASQueryParameters to throw an Invalid Permissions exception.
Describe the solution you'd like
It would be ideal for us to be able to call generateBlobSASQueryParameters with the following:
const permission = JSON.parse("{
    "read": true,
    "add": false,
    "create": false,
    "write": true,
    "delete": false
}") as BlobSasPermission;

Or even:
BlobSasPermission.parse(jsonString);

Describe alternatives you've considered
Since we want to retain our database structure (for backwards compatibility), it is not desirable to change how we serialize BlobSasPermission. Right now we just recreate the BlobSasPermission.toString method in our codebase to work with an external object (remember that obj below does not have toString() since it was re-hydrated from JSON):
private getSasPermissionsString (obj: BlobSASPermissions): string {
        const permissions: string[] = [];
        if (obj.read) {
            permissions.push('r');
        }
        if (obj.add) {
            permissions.push('a');
        }
        if (obj.create) {
            permissions.push('c');
        }
        if (obj.write) {
            permissions.push('w');
        }
        if (obj.delete) {
            permissions.push('d');
        }
        return permissions.join('');
    }

Additional context
None.

Thanks for feedback. Mark this as feature request and will be triaged in following release schedule.

Probably we should have made the toString() function static.
https://github.com/Azure/azure-sdk-for-js/blob/a5ba0748cc248d1ab724ad76cea5bd65bbd5474d/sdk/storage/storage-blob/src/sas/BlobSASPermissions.ts#L145
Then you would be able to call BlobSASPermissions.toString(permissionLikeObject) to get the permission string, and then call BlobSASPermissions.parse(permissionString) to get an instance of BlobSASPermissions.

from(PermissionLikeObject): BlobSASPermissions


Show training errors of Rasa models in Rasa X

Rasa version: 1.1.4
Rasa X version: 0.20.0
Issue:
If the user clicks on the Train button and the training fails, there is no indication that the training failed nor any error message to help the user track down what went wrong. The only indication that there was a problem is that the model doesn't show up.
Running under the docker setup, I spent some time trying to determine what went wrong and found the error in browser network tab.
There's also no indication with the training has completed. A progress bar would be nice.
The Rasa X user interface needs to display training error status messages. It would also be nice to have a log page to view the Rasa X and underlying docker logs if the user is running under a docker setup.

Thanks for raising this issue, @gausie will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Same issue here.
It would be great to have access to the training logs in a specific page. It could give details on the current status (when training) and clues it the training fail.

@abhilasharoy do we already have this as part of any design?

@tmbo In the past, we designed toast options for each of the stages of training.
A lot of this was moved out of priority, and we have only implemented toasts for the "training in progress" and "training complete" scenarios. cc @Saladdin
Here are some of the options:

This is meant to be tackled by our websockets implementation but we've deprioritised it for other things at the moment. But we do have firm plans for this

I've encountered this same issue in the Stories UI where an API error response is not reported. I add a new story, click Save and nothing happens.  The Save & Cancel options are still available.
I open the network tab in the browser and see that the /api/stories endpoint returned an error 500.
I then go to the server log and find this message:
rasa.core.domain.InvalidDomain: Duplicate actions in domain. These actions occur more than once in the domain: 'dynamic_form'

There are really two issues going on here. One is the UI not reporting the error but there's also an issue with the API and the 500 error. To troubleshoot this error, the user needs the error message that can be found only in the server side log. The API needs to return that error message.

Hi @rgstephens ,
I am also facing the same issue while doing training from Rasa X UI.
version: "0.21.5", status: "failure", message: "Failed to train a Rasa model.",…}
code: 500
details: {args: [], message: null}
args: []
message: null
help: null
message: "Failed to train a Rasa model."
reason: "StackTrainingFailed"
status: "failure"
version: "0.21.5"
Have you got the solution of this?
Thanks and Regards
Harsh

Even I am getting this error:
{"version":"0.21.5","status":"failure","message":"Failed to train a Rasa model.","reason":"StackTrainingFailed","details":{"args":[104,"Connection reset by peer"],"errno":104,"filename":null,"filename2":null,"strerror":"Connection reset by peer"},"help":null,"code":500}

@kapoorh Have you looked at the Rasa log for your worker to determine the root cause of the training failure.
docker-compose logs rasa-worker

@Saladdin can you update the issue / test

@Saladdin Can you please check if this is still a thing or if it can be closed?

This continues to be reported as an issue on the forum:

Mar 25
Mar 21
Mar 17

@Saladdin May be we should include this one with the Global UI issues?

Let's do it 👍

Is this still an issue? As far as I know, it should be fixed by https://github.com/RasaHQ/rasa-x/pull/2998

Yes, thanks. Failed training is now reported. Will open a separate enhancement request to provide failure details.

{version: "0.31.0", status: "failure", message: "Failed to train a Rasa model.",…}
code: 500
details: {}
help: null
message: "Failed to train a Rasa model."
reason: "StackTrainingFailed"
status: "failure"
version: "0.31.0"
And worker container logs:
/opt/venv/lib/python3.7/site-packages/rasa/core/brokers/pika.py:294: FutureWarning: Your Pika event broker config contains the deprecated queuekey. Please use thequeues key instead.  self.queues = self._get_queues_from_args(queues, kwargs)2020-09-16 03:58:53 ERROR    pika.adapters.utils.io_services_utils  - Socket failed to connect: ; error=111 (Connection refused)2020-09-16 03:58:53 ERROR    pika.adapters.utils.connection_workflow  - TCP Connection attempt failed: ConnectionRefusedError(111, 'Connection refused'); dest=(, , 6, '', ('<IP_ADDRESS>', 5672))2020-09-16 03:58:53 ERROR    pika.adapters.utils.connection_workflow  - AMQPConnector - reporting failure: AMQPConnectorSocketConnectError: ConnectionRefusedError(111, 'Connection refused')2020-09-16 03:58:58 ERROR    pika.connection  - Connection closed while authenticating indicating a probable authentication error2020-09-16 03:58:58 WARNING  rasa.core.brokers.pika  - Connecting to 'rabbit' failed with error 'ConnectionClosedByBroker: (403) 'ACCESS_REFUSED - Login was refused using authentication mechanism PLAIN. For details see the broker logfile.''. Trying again.2020-09-16 03:58:58 ERROR    pika.adapters.utils.connection_workflow  - AMQPConnector - reporting failure: AMQPConnectorAMQPHandshakeError: ProbableAuthenticationError: Client was disconnected at a connection stage indicating a probable authentication error: ("ConnectionClosedByBroker: (403) 'ACCESS_REFUSED - Login was refused using authentication mechanism PLAIN. For details see the broker logfile.'",)2020-09-16 03:58:58 ERROR    pika.adapters.utils.connection_workflow  - AMQPConnectionWorkflow - reporting failure: AMQPConnectionWorkflowFailed: 2 exceptions in all; last exception - AMQPConnectorAMQPHandshakeError: ProbableAuthenticationError: Client was disconnected at a connection stage indicating a probable authentication error: ("ConnectionClosedByBroker: (403) 'ACCESS_REFUSED - Login was refused using authentication mechanism PLAIN. For details see the broker logfile.'",); first exception - AMQPConnectorSocketConnectError: ConnectionRefusedError(111, 'Connection refused')2020-09-16 03:58:58 ERROR    pika.adapters.base_connection  - Full-stack connection workflow failed: AMQPConnectionWorkflowFailed: 2 exceptions in all; last exception - AMQPConnectorAMQPHandshakeError: ProbableAuthenticationError: Client was disconnected at a connection stage indicating a probable authentication error: ("ConnectionClosedByBroker: (403) 'ACCESS_REFUSED - Login was refused using authentication mechanism PLAIN. For details see the broker logfile.'",); first exception - AMQPConnectorSocketConnectError: ConnectionRefusedError(111, 'Connection refused')2020-09-16 03:58:58 ERROR    pika.adapters.base_connection  - Self-initiated stack bring-up failed: AMQPConnectionWorkflowFailed: 2 exceptions in all; last exception - AMQPConnectorAMQPHandshakeError: ProbableAuthenticationError: Client was disconnected at a connection stage indicating a probable authentication error: ("ConnectionClosedByBroker: (403) 'ACCESS_REFUSED - Login was refused using authentication mechanism PLAIN. For details see the broker logfile.'",); first exception - AMQPConnectorSocketConnectError: ConnectionRefusedError(111, 'Connection refused')2020-09-16 05:28:49.051080: E tensorflow/stream_executor/cuda/cuda_driver.cc:351] failed call to cuInit: UNKNOWN ERROR (303)

0.32.2 anyone know's how to solve this?
/opt/venv/lib/python3.7/site-packages/rasa/core/brokers/pika.py:294: FutureWarning: Your Pika event broker config contains the deprecated `queu
e` key. Please use the `queues` key instead.
rasa-worker_1      |   self.queues = self._get_queues_from_args(queues, kwargs)
rasa-worker_1      | 2020-10-15 15:15:23 ERROR    pika.adapters.utils.io_services_utils  - Socket failed to connect: <socket.socket fd=21, family=AddressFamily.AF_I
NET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 58092)>; error=111 (Connection refused)
rasa-worker_1      | 2020-10-15 15:15:23 ERROR    pika.adapters.utils.connection_workflow  - TCP Connection attempt failed: ConnectionRefusedError(111, 'Connection
refused'); dest=(<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('<IP_ADDRESS>', 5672))
rasa-worker_1      | 2020-10-15 15:15:23 ERROR    pika.adapters.utils.connection_workflow  - AMQPConnector - reporting failure: AMQPConnectorSocketConnectError: Con
nectionRefusedError(111, 'Connection refused')
rasa-worker_1      | 2020-10-15 15:15:28 ERROR    pika.adapters.utils.io_services_utils  - Socket failed to connect: <socket.socket fd=25, family=AddressFamily.AF_I
NET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 58114)>; error=111 (Connection refused)
rasa-worker_1      | 2020-10-15 15:15:28 ERROR    pika.adapters.utils.connection_workflow  - TCP Connection attempt failed: ConnectionRefusedError(111, 'Connection
refused'); dest=(<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('<IP_ADDRESS>', 5672))
rasa-worker_1      | 2020-10-15 15:15:28 ERROR    pika.adapters.utils.connection_workflow  - AMQPConnector - reporting failure: AMQPConnectorSocketConnectError: Con
nectionRefusedError(111, 'Connection refused')
rasa-worker_1      | 2020-10-15 15:15:33 ERROR    pika.adapters.utils.io_services_utils  - Socket failed to connect: <socket.socket fd=25, family=AddressFamily.AF_I
NET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 58120)>; error=111 (Connection refused)
rasa-worker_1      | 2020-10-15 15:15:33 ERROR    pika.adapters.utils.connection_workflow  - TCP Connection attempt failed: ConnectionRefusedError(111, 'Connection
refused'); dest=(<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('<IP_ADDRESS>', 5672))
rasa-worker_1      | 2020-10-15 15:15:33 ERROR    pika.adapters.utils.connection_workflow  - AMQPConnector - reporting failure: AMQPConnectorSocketConnectError: Con
nectionRefusedError(111, 'Connection refused')


feat(parser): add support for constraint comprehension

Partly addressing #187 and #220

Thank you @grjte, I think maybe we should merge this PR without addressing some of your comments right now. Things left to do:

Combining Constraint and ConstraintComprehension variants for both integrity and boundary constraints.
Modifying the syntax for constraint comprehension with selectors.
The reason is that these will require quite a bit refactor of the code and will be a waste of time rebasing all the downstream branches. I'll open an issue to address your points in another PR if that's ok with you and come back to it soon after the IR work is done.


Heroku Timeout

Using pdfgenerator 0.4.0 on Heroku (heroku-16 stack), inside a Phoenix 1.4.1 app. Works fine locally.
Trying to run
view_as_string
|> PdfGenerator.generate_binary!(
         delete_temporary: true,
         shell_params: @pdf_options
     )

@pdf_options are
[
    "--print-media-type",
    "--page-size",
    "Letter",
    "--margin-top",
    "15",
    "--margin-right",
    "5",
    "--margin-bottom",
    "5",
    "--margin-left",
    "5",
    "--footer-right",
    "[page] of [toPage]",
    "--footer-font-size",
    "8",
    "--footer-left",
    "Created: [date]"
  ]

I get the following output to the logs
18:31:16 app[web.1]: [>                                                           ] 0%
18:36:01 app[web.1]: [============================================================] 100%
18:36:01 app[web.1]: [============================================================] Object 1 of 1
18:36:01 app[web.1]: [============================================================] Object 1 of 1
18:36:01 app[web.1]: Printing pages (6/6)
18:36:01 app[web.1]: [>                                                           ] Preparing
18:36:01 app[web.1]: Exit with code 1 due to network error: TimeoutError

So it errors out after a near 5 minute wait?
Interestingly if I make delete_temporary: true  I can see the generated file in the tmp directory after the error has been displayed.
I have the build packs as per the order shown on the Getting Started, and they appear to be installing correctly as per the build logs so I'm at a loss as to what might be wrong here?
Thanks.

It appears it has nothing to do with this, turns out the stylesheet being included was too much to handle. All styles now inlined and working fine.


⚠ Bofrost.at has degraded performance

In e40b08f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1977 ms

Resolved: Bofrost.at performance has improved in 22dbd6f.


Deleting object using Action menu raises KeyError: 'cl'

If user has view but not change perm, deleting using the action menu will raise a KeyError here https://github.com/ctxis/django-admin-view-permission/blob/master/admin_view_permission/admin.py#L300
Affects Django 1.11.8

HI @ciarancourtney,
I will publish a new release asap.
Thanks,
Lefteris

The fix has been released.


Article on History of Scaling and How evolution has led to Flare

Current list of doubts/questions that the article should answer:

Is Single point failure if quorum sets share a single node possible in case of Stellar FBA? I know in pure FBA this can be a problem which is why UNL with adjustable parameters are introduced in Flare.
How exactly the communication overhead is present in case of PoS? A full mechanism example would be useful as this is not completely clear to me. The example can include the entire process from a user broadcasting a transaction to the validators actually getting rewarded so that the overload of communication can be visualised by the reader.
How the rich get richer compounding effect is absent in Avalanche? Since bigger validators will have higher chance of reward?
How exactly the transactions get written after consensus in Avalanche (it is not fully clear from the whitepaper) and how reward distribution happens in Avalanche?
What is the incentive to become a validator in Flare? As most rewards goes to Agents or FTSO data providers.

Currently going through the trilemma article to see if/where it can be added.


code navigation, suggestion... Doesn't work

I feel bad for writing this ticket, but I am sincerely clueless.
vscode offers no errors, go to type definition, go to implementation, go to symbol, open symbol by name, peek etc.
Right clickining code simply yields me with following options: Change all occurences, cut, copy, paste and Command Palette - no matter what code is clicked.
I have tried installing vscode with sudo snap install --classic code and with apt, and the issues persists.
I experience these issues with old projects as well as newly created files while working in any directory. Suprisingly when editing HTML files, it auto generates the end tags.
I am using VSCode version 1.42.1
And my OS is - Ubuntu 18.04 64 bit
I am not using any extensions/plugins
settings.json
{
    // Controls if quick suggestions should show up while typing
    "editor.quickSuggestions": {
        "other": true,
        "comments": false,
        "strings": false
    },

    "editor.hover.enabled":true,

     // Controls whether suggestions should be accepted on commit characters. For example, in JavaScript, the semi-colon (`;`) can be a commit character that accepts a suggestion and types that character.
    "editor.acceptSuggestionOnCommitCharacter": true,

    // Controls if suggestions should be accepted on 'Enter' - in addition to 'Tab'. Helps to avoid ambiguity between inserting new lines or accepting suggestions. The value 'smart' means only accept a suggestion with Enter when it makes a textual change
    "editor.acceptSuggestionOnEnter": "on",

    // Controls the delay in ms after which quick suggestions will show up.
    "editor.quickSuggestionsDelay": 10,

    // Controls if suggestions should automatically show up when typing trigger characters
    "editor.suggestOnTriggerCharacters": true,

    // Controls if pressing tab inserts the best suggestion and if tab cycles through other suggestions
    "editor.tabCompletion": "on",

    // Controls whether sorting favours words that appear close to the cursor
    "editor.suggest.localityBonus": true,

    // Controls how suggestions are pre-selected when showing the suggest list
    "editor.suggestSelection": "recentlyUsed",

    // Enable word based suggestions
    "editor.wordBasedSuggestions": true,

    // Enable parameter hints
    "editor.parameterHints.enabled": true,
}

Can you please share what language you are working on

Closing the issue due to lack of information.


nerdctl compose does not support tty: true?

When running 'nerdctl compose up -d' with a compose-file including 'tty: true' that parameter is ignored causing the container to exit immediately after creation as the entrypoint is an interactive shell...
bur@lima-default:/Users/bur/coding/automationbase$ nerdctl compose up -d
WARN[0000] The "AUTOMATIONBASE_CODE" variable is not set. Defaulting to a blank string.
WARN[0000] The "AUTOMATIONBASE_WINGPY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AUTOMATIONBASE_WINGMENCHAINS" variable is not set. Defaulting to a blank string.
WARN[0000] The "AUTOMATIONBASE_NTC_TEMPLATES" variable is not set. Defaulting to a blank string.
INFO[0000] Creating network automationbase_default
WARN[0000] Ignoring: service base: [Tty]
WARN[0000] Ignoring: volume: Bind: [CreateHostPath]
INFO[0000] Ensuring image devnet.wingmen.dk/automationbase:latest
INFO[0000] Creating container wingmen_automationbase
bur@lima-default:/Users/bur/coding/automationbase$
bur@lima-default:/Users/bur/coding/automationbase$ nerdctl compose ps
NAME                      COMMAND        SERVICE    STATUS                      PORTS
wingmen_automationbase    "/bin/bash"    base       Exited (0) 3 seconds ago
bur@lima-default:/Users/bur/coding/automationbase$
Running the same container with 'nerdctl run -it ' works fine and I get an interactive shell as expected...
Are the 'tty: true' keyword not supported in nerdctl compose?
Thank you in advance

I think I'm seeing the same thing looking at the compose file for https://github.com/igorauad/gnuradio-docker-env .

This is not specific to compose, we don't even have nerdctl -t -d yet.
Help wanted from TTY professionals.


switch or select error elements inside tabs

i'm trying this code
	<ps-tab label="test"  id="tab_base" icon="icon-AdminParentModules" img="../img/t/AdminBackup.gif" fa="cogs"> 		<ps-switch name="switch" label="Switch" yes="Yes" no="No" active="false"></ps-switch> 		<ps-select label="Select input" name="ps_select" chosen='true'>         <option value="test">test</option>         <option value="test2">test2</option>     </ps-select> 	    </ps-tab>
and don't render well

switch: never show  correct status
select: dont show options

there is some thing wrong in my code?
thanks

maybe its related with panel attribute?
i just put
<ps-tab label="test" id="tab_base" icon="icon-AdminParentModules" img="../img/t/AdminBackup.gif" fa="cogs" panel="false">
and swtich works
but select not work

Hi @oldlastman,
The panel attribute is just here to wrap the content into a panel. Are you sure that you content is in a form (like specified in the doc)?

hi! thanks for your answer
yes i'm using form tag
this is an full example
`

<ps-tab label="Tab 1" active="true" id="tab1" icon="icon-AdminParentModules" img="../img/t/AdminBackup.gif" fa="cogs">
		<ps-switch name="switch" label="Switch" yes="Yes" no="No" active="true"></ps-switch>
		<ps-select label="Select input" name="ps_select" chosen='true'>
				<option value="testito">testito</option>
				<option value="test2">test2</option>
		</ps-select>
</ps-tab>

<ps-tab label="Tab 2" id="tab2" icon="icon-AdminParentModules" img="../img/t/AdminBackup.gif">
		<ps-switch name="switch2" label="Switch2" yes="Yes" no="No" active="false"></ps-switch>
		<ps-select label="Select input2" name="ps_select2" chosen='true'>
				<option value="testito3">testito3</option>
				<option value="test4">test4</option>
		</ps-select>
</ps-tab>

<ps-tab label="Tab 3" id="tab3">
    // content 3
</ps-tab>

`
if i put:

tab "panel" attribute to false
just one select "chosen" attribute and others as false
it looks all work well,
i'm mess up all tags.. or some behavior it's not fine tuned?

thanks

Sorry for the delay. Do you still have the issue? I will try to keep a look at this asap.
Also, I just made a PR with Riot 3 support, if you want to give it a try. It took me longer than expected but it's finally here.

I found the issues @oldlastman!
It was not your code and fixed both on the riot3 PR if you want to take a look at it.

I merged the PR, and will release a new version asap. Please use this new version, with Riot3.


docs-fr(glossary & i18n) Add i18n and glossary in french doc

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[ ] tests are included
[x] documentation is changed or added
[ ] message properties have been updated with new phrases
[ ] view conforms with WCAG 2.0 AA

Description of change

Provide the french translation of the glossary and i18n docs.

/cc @jgribonvald

Cool!


Enable schema registry

Add schema registry in kafka cluster

@devshawn Please review & let me know if anything missing

@devshawn Please review & let me know if anything missing


Docker host not reachable on "nanobox start"

With nanobox start (as prerequisite for nanobox dev run) I often get the following error:
+ (nanobox start) :
  + Starting Nanobox :
    √ Downloading docker-machine
    ! Launching VM
      Running pre-create checks...
      Creating machine...
      (nanobox) Copying C:\Users\mbrodala\.docker\machine\cache\boot2docker.iso to C:\Users\mbrodala\.docker\machine\machines\nanobox\boot2docker.iso...
      (nanobox) Creating VirtualBox VM...
      (nanobox) Creating SSH key...
      (nanobox) Starting the VM...
      (nanobox) Check network to re-create if needed...
      (nanobox) Waiting for an IP...
      Waiting for machine to be running, this may take a few minutes...
      Detecting operating system of created instance...
      Waiting for SSH to be available...
      Detecting the provisioner...
      Provisioning with boot2docker...
      Copying certs to the local machine directory...
      Copying certs to the remote machine...
      Setting Docker configuration on the remote daemon...

      This machine has been allocated an IP address, but Docker Machine could not
      reach it successfully.

      SSH for the machine should still work, but connecting to exposed ports, such as
      the Docker daemon port (usually <ip>:2376), may not work properly.

      You may need to add the route manually, or use another related workaround.

      This could be due to a VPN, proxy, or host file configuration issue.

      You also might want to clear any VirtualBox host only interfaces you are not using.
      Checking connection to Docker...
      Error creating machine: Error checking the host: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": dial tcp <IP_ADDRESS>:2376: i/o timeout
      You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
      Be advised that this will trigger a Docker daemon restart which will stop running containers.

      You can further specify your shell with either 'cmd' or 'powershell' with the --shell flag.

Error   : exit status 1
Context : failed to create the provider

Enter to continue:

@lyondhill This seems like a candidate for retry functionality in the dockermachine provider for trying to start. I think this is a windows delay condition.


How do we handle places that aren't in search?

Do we have people email us? Email search? WOF?

Needs @dianashk and @straup input.

Just my 2 cents, but having a zoomed out map and scrolling/zooming to the location and then drawing a box seems like a reasonable solution to me.
When I did user testing I looked for that behavior assuming it was possible.
I realize it'd be non-trivial to make that integrate nicely with the current app.

It would be great if there was a way for a user to say what I searched for isn't there so I'm going to make a custom box and give it a custom name. Then behind the scenes an email could go out to<EMAIL_ADDRESS>with what they searched for and didn't find, as well as the bbox and custom name they ended up using for their extract. Then we can evaluate those on a case by case basis. Does that sound reasonable?

We are going to provide this information for admin users via a recent-downloads linked, see also https://github.com/mapzen/data-pages/pull/177.


Gradle Sync Error

When I clone the repo I get this Gradle Sync error its doesn't compile.
Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'anggrayudi_maven_username' for Credentials [username: null] of type org.gradle.internal.credentials.DefaultPasswordCredentials_Decorated.
Android Studio - 4.1.2
OS - macOS Catalina

Use random strings in gradle.properties:
anggrayudi_maven_username=abc
anggrayudi_maven_password=xyz

Thank you.
On Fri, Aug 20, 2021 at 7:22 PM Anggrayudi H @.***>
wrote:

Closed #50 https://github.com/anggrayudi/SimpleStorage/issues/50.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/anggrayudi/SimpleStorage/issues/50#event-5186958464,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHZ6N62VYY5RYLIEKFLPY7DT5ZM3RANCNFSM5CQIIO5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


No way to specify temporary folder in 5.0 (develop)

Where did the -t flag go?
The temp files used to grow quite large... I want to be able to specify where to store them.

Found it, sorry:
  --cache-file string
    	Path the the cache file (default "~/.plexdrive/cache.bolt")

V5 doesn’t use the temp folder anymore, that’s just the cache file for the changes, in this version, everything get save on the RAM


Re-enable some v2x DSP tests

This pull request fixed a number of the tests for v2x. This includes;

[x] fig41-full-adder
[x] fig42-dff
[x] dsp_inout_registered
[x] dsp_inout_registered_dualclk

All primitives are marked with (* blackbox *) and all flipflops are explicitly instantiated. The multiple includes also appear to be working correctly. Output interconnect has also been fixed.
There is still some issues with ports being incorrectly being marked as clocked which affect;

[ ] dsp_in_registered
[ ] dsp_partial_registered
[ ] dsp_out_registered
[x] (parts of) dsp_modes

This change need a rebase to be able to land.

done

I have cherry picked https://github.com/SymbiFlow/symbiflow-arch-defs/pull/664/commits/0349a652be87a5b5b08c3ce2d38b545c7c94b9d2 from #664. This seems to solve a lot of issues here.
All the tests should now pass, but I'm unsure about two things:

clock association is now added to every signal which impacts a registered signal. Seehttps://github.com/SymbiFlow/symbiflow-arch-defs/blob/206a8a969b21910248cbba0f3130c224d6f17a70/utils/vlog/tests/dsp_partial_registered/golden.model.xml. The m signal has a clk clock associated because it impacts the registered output out. The m itself is not registered though. I'm unsure if this is correct. (CC @mithro)

Implicit cells are resolved correctly, but there is no pb_type, or model definition of them. We should somehow include tech mapping definitions here. (CC @mithro @litghost)

Implicit cells are resolved correctly, but there is no pb_type, or model definition of them. We should somehow include tech mapping definitions here. (CC @mithro @litghost)

I haven't been following the v2x work, what is an implicit cell and what does it represent?  Under what circumstance would an implicit cell be acceptable over an explicit blackbox definition?

Implicit cells are resolved correctly, but there is no pb_type, or model definition of them. We should somehow include tech mapping definitions here. (CC @mithro @litghost)

I haven't been following the v2x work, what is an implicit cell and what does it represent? Under what circumstance would an implicit cell be acceptable over an explicit blackbox definition?

Implicit cells are e.g. $dffs not instantiated directly, but inferred by Yosys from e.g.:
always @ (posedge clk) begin
    q <= d
end

This applies also to muxes, logic gates etc

Implicit cells are resolved correctly, but there is no pb_type, or model definition of them. We should somehow include tech mapping definitions here. (CC @mithro @litghost)

I haven't been following the v2x work, what is an implicit cell and what does it represent? Under what circumstance would an implicit cell be acceptable over an explicit blackbox definition?

Implicit cells are e.g. $dffs not instantiated directly, but inferred by Yosys from e.g.:
always @ (posedge clk) begin
    q <= d
end

This applies also to muxes, logic gates etc

There is never a reason to ever use process blocks outside of blackbox module definitions.    If a process appear in a module that is not a blackbox, that is an illegal v2x model.  Can you provide a valid example of a process block in a module that is not a blackbox?

Implicit cells are resolved correctly, but there is no pb_type, or model definition of them. We should somehow include tech mapping definitions here. (CC @mithro @litghost)

I haven't been following the v2x work, what is an implicit cell and what does it represent? Under what circumstance would an implicit cell be acceptable over an explicit blackbox definition?

Implicit cells are e.g. $dffs not instantiated directly, but inferred by Yosys from e.g.:
always @ (posedge clk) begin
    q <= d
end

This applies also to muxes, logic gates etc

There is never a reason to use process blocks outside of blackbox module definitions. If a process appear in a module that is not a blackbox, that is an illegal v2x model. Can you provide a valid example of a process block in a module that is not a blackbox?

I haven't seen those in a regular flow, but a lot of tests added in #316 include such files e.g. https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/utils/vlog/tests/dsp_in_registered/dsp_in_registered.sim.v

Implicit cells are resolved correctly, but there is no pb_type, or model definition of them. We should somehow include tech mapping definitions here. (CC @mithro @litghost)

I haven't been following the v2x work, what is an implicit cell and what does it represent? Under what circumstance would an implicit cell be acceptable over an explicit blackbox definition?

Implicit cells are e.g. $dffs not instantiated directly, but inferred by Yosys from e.g.:
always @ (posedge clk) begin
    q <= d
end

This applies also to muxes, logic gates etc

There is never a reason to use process blocks outside of blackbox module definitions. If a process appear in a module that is not a blackbox, that is an illegal v2x model. Can you provide a valid example of a process block in a module that is not a blackbox?

I haven't seen those in a regular flow, but a lot of tests added in #316 include such files e.g. https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/utils/vlog/tests/dsp_in_registered/dsp_in_registered.sim.v

 GitHub**SymbiFlow/symbiflow-arch-defs**FOSS architecture definitions of FPGA hardware useful for doing PnR device generation. - SymbiFlow/symbiflow-arch-defs

IMO, that represents some form of blackbox.  In 7-series, output registration is part of the blackbox.  For example, the BRAM blackbox (e.g. RAMB18E1_VPR) supports optional registered output.  If the plan to is to fracture the original BRAM blackbox for any reason, these new implicit processes must become new blackboxs from VPR's perspective.
I recommend for now that we make it illegal to describe processes outside of blackbox modules, and so in that case, the "registered" part of the DSP should be pushed into a new module with the(* blackbox *) comment, rather than doing it implicitly.  This enables names and timing annotations to be added in the method we already have, rather than performing a potentially complicited inference, and defining naming rules.  Not to mention the mess that would be dealing with implicit include statements.
I guess I'm suggesting that an explicit approach feels more consistent and less techinically challenging here.
@mithro, do you have an design to solve the implicit process problem?  Otherwise, I'm strongly inclined to stick with explicit blackbox only.

To add color to my suggestion, in the example https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/utils/vlog/tests/dsp_in_registered/dsp_in_registered.sim.v, there are at least 2 possible interpretations, and it's not clear how v2x could possible distiguish.

Those $dff's should become some part common FF (e.g. FDRE or FDSE).  This actually happens in 7-series with the input or output registration in the ILOGIC or OLOGIC site.
Those $dff's are part of an existing blackbox that is being fractured, and so needs a specific blackbox that can only be instanced for that part (e.g. BRAM output registration FF's).  It is worth noting that Vivado will absorb output registration into the BRAM.  So this may be a special case of 1, but I think of it differently.

In this PR I suggested changing this particular test to https://github.com/SymbiFlow/symbiflow-arch-defs/blob/3c29bbe5cde36112a8ad47c79129e3df3056eb11/utils/vlog/tests/dsp_in_registered/dsp_in_registered.sim.v (adding explicit dffs)
@litghost As I understood you correctly, this is what you'd like to do for all of them. Is that correct?

In this PR I suggested changing this particular test to https://github.com/SymbiFlow/symbiflow-arch-defs/blob/3c29bbe5cde36112a8ad47c79129e3df3056eb11/utils/vlog/tests/dsp_in_registered/dsp_in_registered.sim.v (adding explicit dffs)
@litghost As I understood you correctly, this is what you'd like to do for all of them. Is that correct?

 GitHub**SymbiFlow/symbiflow-arch-defs**FOSS architecture definitions of FPGA hardware useful for doing PnR device generation. - SymbiFlow/symbiflow-arch-defs

I believe that is the superior technical solution because:

It correctly defines the include relationship, so dependencies are computed accurately
It allows fine grained control of the blackbox instancing.

I believe there are real unsolved technical issues with an approach that supports implicit processes, and I don't see a path forward to solve them without significant work.

@kgugala I'm rebasing this change...

I've updated the description of this pull request to be;

This pull request fixed a number of the tests for v2x. This includes;

[x]  fig41-full-adder
[x]  fig42-dff
[x]  dsp_inout_registered
[x]  dsp_inout_registered_dualclk

All primitives are marked with (* blackbox *) and all flipflops are explicitly instantiated. The multiple includes also appear to be working correctly. Output interconnect has also been fixed.
There is still some issues with ports being incorrectly being marked as clocked which affect;

[ ]  dsp_in_registered
[ ]  dsp_partial_registered
[ ]  dsp_out_registered
[x]  (parts of) dsp_modes

If it goes green, then I'll merge it.

The last failure seems to have been;
Traceback (most recent call last):
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/utils/report_block_usage.py", line 51, in <module>
    main()
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/utils/report_block_usage.py", line 46, in main
    block, usage[block]
AssertionError: Expect usage of block BLK-TL-SLICEM = 0, found 1


Update adding-software-components-with-an-inf-file.md

Adding Win10S exception to software components.

@NabilFates,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Implement synchronisation to Silvasoft

Tartarus is switching its administration from Tantalus to Silvasoft. We should therefor provide support for synchronising Shifts and BorrelReservations to Silvasoft. We should also remove the synchronisation to Tantalus.
Details for the Silvasoft API can be located here.

@dhoekstra2000 Could you provide us with a plan as to how you would want to switch to Silvasoft? E.g. when do we need to switch over the Tantalus synchronisation to Silvasoft synchronisation? How would you want to see it implemented (I assume just in the same way as we did with Tantalus)?

So in short the transition will be tomorrow... This is for administrative purposes, since tomorrow the next VAT-quarter starts.
However, before the synchronisation could be implemented, the data has to be transferred from Tantalus and Conscribo to Silvasoft I suppose, which will be done from tomorrow onwards, and is hopefully done during the next week.
I will look if it is possible to have a test account development purposes.
Finally, how I would like to see it implemented, is basically the following:

Every borrel is pushed as an invoice to Silvasoft.
Every tostishift is pushed as an invoice to Silvasoft.
It would be nice if a "cost center" could be set for this ("Borrel" for borrels and "Tosti" for the tosti's themselves, "Kantine" for the candy and soda cans)

About a test account, Silvasoft indicated this:

Hiervoor kunnen de ontwikkelaars het beste een nieuwe proefaccount aanvragen via onze site, dan kunnen ze daarna de koppeling testen.

So you can make a trial account to test the synchronisation.


License site down

Hello,
community site and licensing are not responding. I can not send a message by contact form on meteorite.bi web, error says:
Notice: Undefined index: field_map_address in include() (line 1 of /var/www/html/sites/all/themes/Porto/templates/node/node--contact.tpl.php).
Warning: stream_socket_enable_crypto(): SSL: Success in SMTP->StartTLS() (line 202 of /var/www/html/sites/all/modules/smtp/smtp.transport.inc).
Unable to send e-mail. Contact the site administrator if the problem persists.

Try again @ruria https://licensing.meteorite.bi/login


[$500] both bank accounts are labeled as default after adding another BA for a moment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: need to have real bank data
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @getusha
**Slack conversation:**https://expensify.slack.com/archives/C049HHMV9SM/p1708419649536799
Action Performed:
Account Settings > Wallet > Add Bank account
Add the first BA (checking)
Add the second BA (saving)
Expected result:
Only one of the accounts should be labeled as default
Actual result:
Both accounts are labeled as default
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/59841f74-46cd-47c1-a952-fbddac9a090a

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f8029498cae4b95a
Upwork Job ID:<PHONE_NUMBER>618905088
Last Price Increase: 2024-02-27

Proposal
Problem Statement
We are currently experiencing an issue where both bank accounts are momentarily labeled as default after a user adds a second bank account in the Expensify app. This behavior is unexpected and can lead to confusion for the user, as only one bank account should be labeled as default at any given time.
Root Cause
I have reviewed the provided files and believe that the root cause of this issue is a bug in the state management within the components that interact with the bank account addition process. Specifically, the logic responsible for updating the default status of bank accounts is not handling the addition of new bank accounts correctly.
Proposed Solution
To address this issue, I propose that we combine the following two solutions:

Revise the state management logic in the components responsible for adding bank accounts.  This includes ensuring that when a new bank account is added, the default status is only assigned to the newly added account if no other default exists, or it is explicitly set by the user.
Add proper checks and balances to prevent multiple accounts from being labeled as default simultaneously.

Here is an example of how this could be implemented in the  AddPersonalBankAccountPage.tsx  file:
const handleSetDefaultAccount = (bankAccountID) => {
  const bankAccounts = getBankAccounts();
  const defaultBankAccountID = getDefaultBankAccountID();

  // Check if the account being set as default is already the default account.
  if (bankAccountID === defaultBankAccountID) {
    return;
  }

  // Check if there is already a default account.
  if (defaultBankAccountID) {
    // If there is already a default account, unset it.
    set({
      defaultBankAccountID: null,
    });
  }

  // Set the new account as the default account.
  set({
    defaultBankAccountID: bankAccountID,
  });
};

Benefits
The proposed solution is relatively straightforward to implement and maintain. It also aligns with the existing logic for managing default bank accounts in the app.
Conclusion
I believe that the proposed solution is the best approach to resolving this issue. It is simple to implement, aligns with the existing codebase, and effectively addresses the root cause of the problem.

I believe this issue has the same cause as #34774 and https://github.com/Expensify/App/issues/35788. @stitesExpensify is dealing with a backend solution that will resolve them.

I'm trying to reproduce this issue locally, but I can't add and log-in the personal bank account in local expensify app (https://dev.new.expensify.com:8082/) with Fidelity Bank method (it shows invalid credentials message when I tried to log-in), I can only log-in the Fidelity Bank account successfully in the staging. Is there a way to add and log-in the personal bank account in local dev environment?

I believe this issue has the same cause as #34774 and #35788. @stitesExpensify is dealing with a backend solution that will resolve them.

@miljakljajic Seems to be a duplicate issue. We can close this.

I believe this issue has the same cause as #34774 and #35788. stitesExpensify is dealing with a backend solution that will resolve them.

@miljakljajic Seems to be a duplicate issue. We can close this.

@miljakljajic gentle ping

Apologies for missing this - closing!


Video quality selection

First of all, thank you for the great utility especially in this time of distance education.
I wanted to ask about a feature of selecting video quality because the script is downloading a low quality for now?

I'm looking into it, hopefully I'll be able to push a new branch in a couple of days

It is not, please see this -
https://github.com/snobu/destreamer/issues/88#issuecomment-619438989
It defaults to the best available HLS bitrate. If it doesn't, make sure you're using a recent ffmpeg build (year 2020-ish).

It is not, please see this -
#88 (comment)
It defaults to the best available HLS bitrate. If you're seeing low quality results and the video in your browser looks in fact much better, make sure you're using a recent ffmpeg build (year 2020-ish).

I already using the latest FFmpeg, but still, the video quality is not good at all.


Bracket stop completion in use

I try racer completer with
use core::ops::{Index, IndexMut};
I found that bracket will stop completion. So I cannot complete Index and IndexMut automatically.
Any hint where can I fix this problem?

Does not work for me in Windows

Not sure these two issue is related or not. Since they use different function call. I think @jaxx you can open another issue


Qr code

Description
@kaustubhgupta @antrikshmisri
I have to complete my QR code generator project. also, I completed my "requirment.txt" file.
Old pull Request #760
Fixes #703
Replace #703 with the issue number which is fixed in this PR
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] My documentation follows Template for README.md
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

I can't be adding this updated file in old PR. that's why I made new PR.

can you explain to me what is "LGTM.."?

can you explain to me what is "LGTM.."?
@avinashkranjan and thank you for merged my PR.

Looks good to me :)


toMatchObject passes with non-matching RegExp objects

🐛 Bug Report
When using toMatchObject with a RegExp object as a value, the test passes with any RegExp object.  It behaves as though the matching object used expect.any(RegExp) instead of an instance.
To Reproduce
test('toMatchObject RegExp', () => {
  const x = {
    regexObject: new RegExp('foo'),
    regexLiteral: /bar/
  };

  expect(x).toMatchObject({
    regexObject: new RegExp('fizz'),
    regexLiteral: /buzz/
  });
});

Expected behavior
Test to fail because objects are different instances or because a serialized representation check failed.
Link to repl or repo (highly encouraged)
https://repl.it/talk/share/toMatchObject-with-RegExp-Objects/124058

This still looks valid.


chore(deps): Update dependencies

Updates

Dependencies, plugins and annotation processors
Maven 3.9.7 and Wrapper 3.3.2
GitHub Actions
Let Dependabot update Maven files and GitHub Actions

Improvements

Use dependencyManagement where it makes life easier 😅

Hi @reneleonhardt I missed your PR, could you please rebase with main (for the pending changes)?

Hi @reneleonhardt I missed your PR, could you please rebase with main (for the pending changes)?

It happens, done 🙂

Thank you!

You're welcome! 🙂


iPhone doesn't display ephemeral attachment

Summary
iPhone doesn't display ephemeral attachment, the iphonex 12.2 emulator does.  Apologies If I am reporting something that is already fixed in the repo, but not yet in appstore.
Environment Information

Device Name: iPhoneX
OS Version: 12.2
Mattermost App Version: 1.18.1
Mattermost Server Version: 5.10.0

Steps to reproduce
Running the above device, not as an emulator, ephemeral post attachments do not appear.
Expected behavior
Ephemeral post attachments appear.
Observed behavior
Showing the view from the webapp.

And the view from the emulator

The view from my phone shows no ephemeral attachment.

Fixed by #2710 and will be available in 1.19.0

Thank you much.  :)


[fix] updated deprecated goreleaser tap setup

Fixed according to this link: https://goreleaser.com/deprecations#brewsgithub
Haven't tested it yet

Codecov Report

Merging #76 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   55.38%   55.38%
=======================================
  Files          14       14
  Lines         780      780
=======================================
  Hits          432      432
  Misses        304      304
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c961d...3adb9f6. Read the comment docs.


Add a bxl for generating a unified compile_commands.

This adds a simple bxl for generating a global compilation database for all targets in a build.  It is very fast, able to generate a database for around 4,000 files in under 4 seconds.
This opens the door for external users being able to integrate with traditional LSPs like clangd.
This addresses several outstanding issues for external users, including #194, #307, and #452.

@Overhatted

A fix for the CI issue landed on master, you should pick it up if you rebase.
I have to say I don't quite understand the need for aquery here. The obvious thing to me would have been to run analysis on the whole world to gather all the compilation DBs, and then just merge them. How does that approach go wrong?

When I tried that (maybe I did it wrong) it was extremely slow.  It was an early attempt, so my memory is rusty, but I recall that generation of all the compilation dubs was very slow, because the sub target to generate the compilation db in the first place had dependencies on other targets (didn’t investigate what) and it would build things before it was able to generate the compilation db.  I don’t know what actions that “build things” step ran (didn’t investigate), I just remember that it was slow.  This method generates a universe compilation db very fast.

because the sub target to generate the compilation db in the first place had dependencies on other targets

The only action that's run by compilation DB generation does argsfile expansion. I could maybe imagine this forcing targets in the srcs attribute or something of that sort to get built, but we should fix that if so. But if you don't need argsfile expansion, which seems to be the case here, then I think just having adding a compilation-database-unexpanded subtarget, and combining that across the entire repo, would be the right thing to do

So the context here is that when you generate a compilation database, you basically have two choices:

Generate the database with zero dependencies. That basically ends up looking like the aquery solution.
Generate the database with lots of dependencies - this ensures that things like generated code are produced properly. It also means that you can literally run the command lines produced and they work.

I believe our [compilation-database] target goes for lots of dependencies. I originally worked on a version with zero dependencies, but then our IDE teams wanted them added to support their use cases.
@JakobDegen is suggesting we have [compilation-database-unexpanded]. We probably should, but I don't think this solution is harmful, so suggest we merge it anyway?

@zjturner Did you plan on finishing this PR and getting it merged? If not, would you be ok with someone picking it up? It seems that @ndmitchell only had minor comments about this version and was otherwise ready to merge it.

Sorry for the lack of response, I've been gone for some time.  Please feel free to take it over.

I have a question about this bxl script, and would be happy to help out if possible. Bear in mind I'm only just getting started with buck2 and have no buck1 experience yet.
The issues I am currently facing is with how the targets are passed to this script, namely:

I somehow can't manage to pass multiple targets to the script
a) e.g. I'd like for the compdb to be built for //:main and //:test, but I can't figure out the command-line syntax for it
If I try to build the compdb for all targets, ctx.configured_targets(target_filter) fails for my demo project that uses thirdparty dependencies that have BUCK files. Details on this below.

I put together a very simple demo project, with which I am trying to get acquainted with the build system. I have integrated googletest and range-v3 at the moment, as a way to understand how to integrate thirdparty dependencies. I am considering git submodules or vendoring, where I will add BUCK files for projects that don't have them, or modify them for projects that have them but some issues arise (e.g. not supporting buck2).
The problem that I have stumbled across is with range-v3. This library does have BUCK files, and provides them also for examples contained in the repository. If I run the bxl script, I get the following error:
buck2 bxl //compile_commands.bxl:gen_compilation_database --

Traceback (most recent call last):
  File <builtin>, in <module>
  * compile_commands.bxl:68, in _gen_compilation_database_impl
      targets = ctx.configured_targets(target_filter)
error: Error in configured node dependency, dependency chain follows (-> indicates depends on, ^ indicates same configuration as previous):
       root//thirdparty/range-v3/example:accumulate_ints (prelude//platforms:default#904931f735703749)
    -> root//:range-v3 (^)

  --> compile_commands.bxl:68:15
   |
68 |     targets = ctx.configured_targets(target_filter)
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |

Caused by:
    0: looking up unconfigured target node `root//:range-v3`
    1: Unknown target `range-v3` from package `root//`.
       Did you mean one of the 2 targets in root//:BUCK?

What I found is that these examples refer to parts of the library, expecting them to be in the root folder, which is not the case for my setup (and presumably not for most). My project is not building these example project, but it seems like they are still picked up by  configured_targets for some reason, and failing.
Any help on these two issues would be greatly appreciated. I'd be happy to contribute the solution back, if something can be :slightly_smiling_face:

If we merge https://github.com/facebook/buck2/pull/810, do we still want this version?

@cjhopman I'm obviously biased, but I don't think that the version in this PR is very useful, because it is fast at the cost of correctness: dependencies are not materialized, code generation is not run, etc. This completely breaks tooling like clang-tidy in all but the most trivial cases, and more permissive tools like clangd are useable, but not with flawless integration.
My version is slower but more correct. When running on a mid-sized monorepo (a few millions of lines of C++, but not dozens), what actually takes time is building our code generator from source. The actual generation of the compilation database is very quick. Note that my version is not perfect because it builds the compilation database for a single platform, and BXL doesn't seem to "follow" transitions, but the result remains very usable, even in a heavily (split) transitioned codebase.


Add Dependabot Config

Running the steps on the readme to install the dependencies shows 5 vulnerabilities in packages.
If possible, enable Dependabot and keep things up to date (especially on security alerts).
I forked the repo and enabled Dependabot:

Letting Dependabot fix all the errors with PR's and the alerts are fixed.
Either add Dependabot (best option IMO), or I can create a PR with the version updates: compare my fork.

Thanks for the note!
We've enabled dependabot on this side and we will hopefully have these issues fixed soon.


Set Table Body Class

Same as https://github.com/spatie/vue-table-component/pull/61 but now for the tbody element.

Thanks!


PF-1383: add a ssh_key_pair table to the ecm database and its associated DAO

shouldn't be confused with the api change now.

It is confusing to have these changes co-mingled with the api changes

It's not mingled with the api changes any more. Could you please take a look again?


Update Fabric Bot Rules for sdk/Monitor

Library name
Azure.Monitor.OpenTelemetry.Exporter
Please describe the feature.
PRs for Azure.Monitor.OpenTelemetry.Exporter are not getting automatically labeled, although codeowners are correctly assigned.
Example PR: https://github.com/Azure/azure-sdk-for-net/pull/34270
Note that I had to manually assign the label after the PR was created.
I reviewed this with Jim Suplizio and Jesse Squire and found some missing rules for FabricBot.

Rule 12. Pull request auto label - file paths doesn't have entries for sdk/monitor.
Rule 14. Issue Routing - @Mention does have entries (11 of them) for the various monitor areas and apparently people are getting correctly added for that.

We already have entries in CODEOWNERS
https://github.com/Azure/azure-sdk-for-net/blob/403647170755aa26ca3f55891c17ef3ed9787af6/.github/CODEOWNERS#L497-L499

This should now be complete.

It works!!! Thank you @jsquire!!!!!


Error during the first run

Hello, I have a trouble during the first run:
python3 main_pipeline.py
I get :
"alpha_net_c4.py", line 14, in __init__     self.X = dataset[:,0] IndexError: too many indices for array
Someone can help me ?
Thanks for your time

can you post the full error traceback please? Meanwhile, try updating numpy and see if the problem persists.

Hi, I also encountered the same issue as @yaniferhaoui had. I tried updating numpy to version 1.19.1 but the issue still persists. Here is my full error traceback.
Traceback (most recent call last):
  File "main_pipeline.py", line 36, in <module>
    train_connectnet(args, iteration=i, new_optim_state=True)
  File "/Users/daisukeadachi/Documents/GitHub/AlphaZero_Connect4/src/train_c4.py", line 153, in train_connectnet
    train(net, datasets, optimizer, scheduler, start_epoch, 0, args, iteration)
  File "/Users/daisukeadachi/Documents/GitHub/AlphaZero_Connect4/src/train_c4.py", line 67, in train
    train_set = board_data(dataset)
  File "/Users/daisukeadachi/Documents/GitHub/AlphaZero_Connect4/src/alpha_net_c4.py", line 14, in __init__
    self.X = dataset[:,0]
IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

Thank you.

Hi, I encountered the same issue and tried upgrading numpy but it didn't solve the issue. I have the exact same error traceback as @daisukeadachi. Did someone find a way to solve this ?
Thanks.

Hi, may I know whether you have the solution to this error. I am also getting the same error.
Thanks

No, I doubt this repo is active, unfortunately :(

I printed the dataset shape, it is (0,). This is an empty dataset. Note that the code in the main pipeline is as follows:
run_MCTS(args, start_idx=0, iteration=i)
train_connectnet(args, iteration=i, new_optim_state=True)

the error in train_connectnet() originates from the empty results of run_MCTS(). Apparently, the MCTS is not working.

I printed the dataset shape, it is (0,). This is an empty dataset. Note that the code in the main pipeline is as follows:
run_MCTS(args, start_idx=0, iteration=i)
train_connectnet(args, iteration=i, new_optim_state=True)

the error in train_connectnet() originates from the empty results of run_MCTS(). Apparently, the MCTS is not working.

The above phenomenon happened because I actually had a mismatch problem of NVIDIA NVML:
THCudaCheck FAIL file=/opt/conda/conda-bld/pytorch_1579022060824/work/aten/src/THC/THCGeneral.cpp line=50 error=804 : forward compatibility was attempted on non supported HW

Solved it by rebooting. The code now works like a magic.
Solving the torch cuda error804 by rebooting:
https://github.com/pytorch/pytorch/issues/40671
https://stackoverflow.com/questions/43022843/nvidia-nvml-driver-library-version-mismatch/45319156#45319156


Make library created with cargo new clippy happy

close https://github.com/rust-lang/cargo/issues/9759

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

I think this is OK, though I guess I don't really care too much since I always just delete everything.  However, since this is a pretty visible change, I'm going to check with the team for approval.
@rfcbot fcp merge

Personally I'm not too too happy about clippy making design decisions for us, but I don't really mind one way or another on this specific issue.

@bors r+

:pushpin: Commit 7d4b5dfdb175a9ef6ab8c6db8039be9dc5855c7c has been approved by ehuss

:hourglass: Testing commit 7d4b5dfdb175a9ef6ab8c6db8039be9dc5855c7c with merge dd474f8d588d12442821a000dc4d98a7c890df1d...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing dd474f8d588d12442821a000dc4d98a7c890df1d to master...


Adjusting margins, width and height of details modal.

@ammendonca Would you be able to review please?

LGTM, but .modal-xl is already defined at https://github.com/hawkular/hawkular-apm/blob/c81bcad3dc31af7148a2a3557f3b6ea1e9d3c50a/ui/src/main/scripts/plugins/btm/less/btm.less#L50-L52. It's likely a good idea to keep it in a single place.
hawkular.less was intended to be a copy of the same file at main Hawkular UI to keep integration smooth. The main file for APM custom styles used to be btm.less so it's likely a good idea to make these modifications there ?

@ammendonca , definitely, I'll move the apm styles to the proper file. Thanks!

@ammendonca , removed the APM specific styles that I had written in hawkular.less to btm.less and filter-sidebar.less. Please check.

LGTM.

@cardosogabriel @ammendonca  Thanks!

Thank you all!


Converting from nuget creates dependencies with @s

I converted a sln from nuget using the VS extension, don't remember what version.
The result looks like this:
source C:\Tfs\Common\GuGet
source http://nuget.org/api/v2

nuget StyleCop.Analyzers -prerelease
nuget Gu.Reactive @= <IP_ADDRESS>
nuget Gu.SerializationAsserts @= <IP_ADDRESS> framework: >= net451
nuget Gu.Wpf.Reactive @= <IP_ADDRESS>
nuget Gu.Wpf.ToolTips @= <IP_ADDRESS>
nuget Gu.Xml
nuget JetBrains.Annotations @= 10.0.0
nuget Microsoft.Bcl.Immutable @= 1.0.34 framework: >= net451
nuget Microsoft.Net.Compilers @= 1.0.0
nuget Moq @= 4.2.1510.2205 framework: >= net451
nuget NUnit @= 2.6.4 framework: >= net451
nuget Rx-Core @= 2.2.5
nuget Rx-Interfaces @= 2.2.5
nuget Rx-Linq @= 2.2.5
nuget Rx-Main @= 2.2.5
nuget Rx-PlatformServices @= 2.2.5
nuget Rx-Testing @= 2.2.5 framework: >= net451
nuget Rx-WPF @= 2.2.5
nuget Rx-XAML @= 2.2.5

This is clear a bug. Thanks for reporting

mhm I can't reproduce with latest paket. I don't get @= qualifiers. Can you please try again with latest addin?


Yolo V5 conversion problem: How can I properly make weight replacement file

Hello. First, I want to thank you for this awesome repository.
I am trying to convert yolov5 model from onnx (coming from .pt format) to .tflite (with int8 quantized). The problem can be narrowed down to the fact that our model has a 5D Reshape layer, which -as per mentioned in readme.md- is reported to have problems currently.
Your solution is "writing weights replacement file". Unfortunately, this parts lacks detailed documentation. Going straight to my question, I want to know how can write a replacement file for the layer(s) causing problems.
it is clear that the replacement json needs values, and I am not sure how can I get those values to put inside my own replacement file.
I have pt model, onnx model and OpenVino model. How can get the replacement fields from (any) of those?
Thanks in advance, Regards.

Also, is there any plan to fix this without any workarounds?

I have added a large amount of explanation of the procedure without any leaks.
https://github.com/PINTO0309/openvino2tensorflow#6-7-replace-weights-or-constant-values-in-const-op

Also, is there any plan to fix this without any workarounds?

It's not that I'm too busy to implement it. It is impossible to convert mechanically. This is why neither Google, Microsoft, nor Facebook provide an official tool that can cleanly convert NCHW to NHWC. If you think it's too much trouble, just don't use this tool. There are some tools that are very useful, but produce not-so-beautiful models, so I'll introduce them here just in case.
https://github.com/onnx/onnx-tensorflow


Can not convert to fp16 using llama.cpp

I use llama.cpp to convert pytorch model to fp16.
Follow is the error.
python3 convert.py ../PhoGPT-4B-Chat --outtype f16 --outfile ../phogpt-4b-chat.fp16.bin
Loading model file ../PhoGPT-4B-Chat/pytorch_model.bin
Traceback (most recent call last):
  File "/Users/***/temp/llama.cpp/convert.py", line 1479, in <module>
    main()
  File "/Users/***/temp/llama.cpp/convert.py", line 1426, in main
    params = Params.load(model_plus)
  File "/Users/***/temp/llama.cpp/convert.py", line 317, in load
    params = Params.loadHFTransformerJson(model_plus.model, hf_config_path)
  File "/Users/***/temp/llama.cpp/convert.py", line 236, in loadHFTransformerJson
    raise Exception("failed to guess 'n_ctx'. This model is unknown or unsupported.\n"
Exception: failed to guess 'n_ctx'. This model is unknown or unsupported.
Suggestion: provide 'config.json' of the model in the same directory containing model files.

Use this instead
python3 convert-hf-to-gguf.py ~/.models/PhoGPT-4B-Chat --outfile ~/.models/pho.gguf


quartus: expose CLI executables + increase device support

Motivation for this change
A user (I think @hpfr, apologies if I have the wrong person) requested support for Cyclone IV chipsets in quartus for remote lessons. This is addressed in f30f3bd
On the previous PR, @doronbehar requested exposing the CLI components of quartus rather than just the main GUI. That was a bit tricky in the context of buildFHSUserEnv but I have it working to my satisfaction now. This feature is added in e9075dd
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Most of the files seem to be OK - of the ones you posted, only QuartusLiteSetup doesn't have the correct hash. Does the original file have an md5 hash of 068DECCE4E35984AB8B49410FD47405B ? This is what mine has, and what is listed on Intel's download page (for me at least).

only QuartusLiteSetup doesn't have the correct hash. Does the original file have an md5 hash of 068DECCE4E35984AB8B49410FD47405B ? This is what mine has, and what is listed on Intel's download page (for me at least).

You were right, my Quartus .run file had a wrong md5 hash as well. Do you think it might be possible to put this as an extra advice (check the md5 hash to correspond to the one on the website) to this error message:
***
Unfortunately, we cannot download file QuartusLiteSetup-<IP_ADDRESS>0-linux.run automatically.
Please go to https://fpgasoftware.intel.com/19.1/?edition=lite&platform=linux to download it yourself, and add it to the Nix store
using either
  nix-store --add-fixed sha256 QuartusLiteSetup-<IP_ADDRESS>0-linux.run
or
  nix-prefetch-url --type sha256 file:///path/to/QuartusLiteSetup-<IP_ADDRESS>0-linux.run

***

Perhaps:
***
Unfortunately, we cannot download file QuartusLiteSetup-<IP_ADDRESS>0-linux.run automatically.
Please go to https://fpgasoftware.intel.com/19.1/?edition=lite&platform=linux to download it yourself, and add it to the Nix store
using either
  nix-store --add-fixed sha256 QuartusLiteSetup-<IP_ADDRESS>0-linux.run
or
  nix-prefetch-url --type sha256 file:///path/to/QuartusLiteSetup-<IP_ADDRESS>0-linux.run

If this doesn't work please check that you download the files from the "Individual Files" tab.
You can also verify that the upstream md5 hashes correspond the files you downloaded.
Use the command `md5sum` to check this.
***

I'm a bit wary of custom messages here (last time we had issues with nix-store --add-fixed vs nix-prefetch-url). Most packages have no custom message. Of those that do, eight use nix-prefetch-url but Mathematica uses nix-store --add-fixed.
Unfortunately, I don't think it is possible to just add extra things to the end of the standard message, you have to replace it entirely, and copy/pasting the bulk of the message from trivial-builders.nix strikes me as a bit of a smell.

Unfortunately, I don't think it is possible to just add extra things to the end of the standard message, you have to replace it entirely, and copy/pasting the bulk of the message from trivial-builders.nix strikes me as a bit of a smell.

I see. Perhaps then it'd be nice to document that in the packages' notes, as in here: https://nixos.org/nixpkgs/manual/#sec-weechat and here: https://github.com/NixOS/nixpkgs/pull/77347/files#diff-f03a8f501d730eba83102a6be17115cb .. But don't feel I'm pressing you on this @kwohlfahrt - Nixpkgs has never been the best distro in terms of documentation :).
As for the rest of the improvements here @kwohlfahrt, I have some comments but overall, it seems you've done spectacular job :clap:. I have 1 question though before I'll give a full review:
Where does the file $out/bin/quartus-prime-lite which has this content:
#! /nix/store/8gy2bmpz3qawxr3g8hqhfgkf32wb0wfl-bash-4.4-p23/bin/bash
exec /nix/store/aj1k6hxh2pkcp785kaa088a5sf2j4i42-chrootenv/bin/chrootenv /nix/store/d8444db34caddd5vw93z4rm306bkrlvy-quartus-prime-lite-init "$(pwd)" "$@"

Comes from?
On a different topic, as for the modelsim executables, there are many:

drill           mc2_util        qhmake          sccom           vcom            verror          vmap            wlf2vcd
dumplog64       qhcvt           qhmap           scgenmod        vcover          vgencomp        vopt            wlfman
hm_entity       qhdel           qhsim           sdfcom          vdbg            vhencrypt       vovl            wlfrecover
jobspy          qhdir           qverilog        sm_entity       vdel            vlib            vrun            xml2ucdb
mc2com          qhgencomp       qvhcom          triage          vdir            vlog            vsim
mc2perfanalyze  qhlib           qvlcom          vcd2wlf         vencrypt        vmake           wlf2log

There are so many of them... Anyway, I've managed to find only this reference documenting them: https://www.intel.com/content/www/us/en/programmable/documentation/jeb1529967983176.html#mwh1410471006061 .

That file comes from buildFHSUserEnv. It creates $out/bin/${name} with the content
#! /nix/store/8gy2bmpz3qawxr3g8hqhfgkf32wb0wfl-bash-4.4-p23/bin/bash
exec /nix/store/aj1k6hxh2pkcp785kaa088a5sf2j4i42-chrootenv/bin/chrootenv ${runScript} "$(pwd)" "$@"

Besides the small nitpicks above, I've had a few more ideas that should simplify the wrapping IMO. They are too broad to write in a review so allow me @kwohlfahrt to suggest a full patch here that includes some changes from already mentioned in the review. Don't feel you have to apply / commit all of these changes, it's just my diff but it is tested.

diff --git c/pkgs/applications/editors/quartus-prime/default.nix w/pkgs/applications/editors/quartus-prime/default.nix
index a222b63287d..ab7d0356736 100644
--- c/pkgs/applications/editors/quartus-prime/default.nix
+++ w/pkgs/applications/editors/quartus-prime/default.nix
@@ -25,7 +25,7 @@ let

   quartus = stdenv.mkDerivation rec {
     version = "<IP_ADDRESS>0";
-    pname = "quartus-prime-lite";
+    pname = "quartus-prime-lite-unwrapped";

     src = let
       require = {name, sha256}: requireFile {
@@ -68,6 +68,7 @@ let
       copyComponent = component: "cp ${component} $TEMP/${component.name}";
       # leaves enabled: quartus, modelsim_ase, devinfo
       disabledComponents = [
+        # WHY?
         "quartus_help"
         "quartus_update"
         # not modelsim_ase
@@ -97,17 +98,17 @@ let
   };

   desktopItem = makeDesktopItem {
-    name = quartus.name;
+    name = "quartus-prime-lite";
     exec = "quartus";
     icon = "quartus";
     desktopName = "Quartus";
-    genericName = "Quartus FPGA IDE";
+    genericName = "Quartus Prime";
     categories = "Development;";
   };

 # I think modelsim_ase/linux/vlm checksums itself, so use FHSUserEnv instead of `patchelf`
 in buildFHSUserEnv rec {
-  name = "quartus-prime-lite";
+  name = "quartus-prime-lite"; # wrapped

   targetPkgs = pkgs: with pkgs; [
     # quartus requirements
@@ -139,40 +140,58 @@ in buildFHSUserEnv rec {
   ];

   passthru = {
-    inherit quartus;
+    unwrapped = quartus;
   };

   extraInstallCommands = let
-    quartusExecutables = (map (c: "quartus/bin/quartus_${c}") [
+    quartusExecutables = (map (c: "quartus_${c}") [
       "asm" "cdb" "cpf" "drc" "eda" "fit" "jbcc" "jli" "map" "pgm" "pow"
       "sh" "si" "sim" "sta" "stp" "tan"
-    ]) ++ [ "quartus/bin/quartus" ];
+    ]) ++ [ "quartus" ];

-    qsysExecutables = (map (c: "quartus/sopc_builder/bin/qsys-${c}") [
+    qsysExecutables = (map (c: "qsys-${c}") [
       "generate" "edit" "script"
     ]);
+    # Should we install all executables ?
+    modelsimExecutables = (map (c: c) [
+      "vsim" "vlog" "vlib"
+    ]);
   in ''
     mkdir -p $out/share/applications
-    cp ${desktopItem}/share/applications/* $out/share/applications
-
-    mkdir -p $out/quartus/bin
-    mkdir -p $out/quartus/sopc_builder/bin
+    ln -s ${desktopItem}/share/applications/* $out/share/applications
+    # handle icon - the size chosen here is roughly the size of the real
+    mkdir -p $out/share/icons/128x128
+    ln -s ${quartus}/licenses/images/dc_quartus_panel_logo.png $out/share/icons/128x128/quartus.png

+    mkdir -p $out/bin
+    # What's gonna come out of the runScript attribute
     WRAPPER=$out/bin/${name}
-    EXECUTABLES="${lib.concatStringsSep " " (quartusExecutables ++ qsysExecutables)}"
+    echo using wrapper script $WRAPPER

-    for executable in $EXECUTABLES; do
-        echo "#!${stdenv.shell}" >> $out/$executable
-        echo "$WRAPPER ${quartus}/$executable \$@" >> $out/$executable
-    done
+    # Every group of executables is located in a different path inside $quartus

-    cd $out
-    chmod +x $EXECUTABLES
-    # link into $out/bin so executables become available on $PATH
-    ln --symbolic --relative --target-directory ./bin $EXECUTABLES
+    for executable in ${lib.concatStringsSep " " (quartusExecutables)}; do
+        echo wrapping ${quartus}/quartus/bin/$executable
+        echo "#!${stdenv.shell}" >> $out/bin/$executable
+        echo "$WRAPPER ${quartus}/quartus/bin/$executable \$@" >> $out/bin/$executable
+        chmod +x $out/bin/$executable
+    done
+    for executable in ${lib.concatStringsSep " " (qsysExecutables)}; do
+        echo wrapping ${quartus}/quartus/sopc_builder/bin/$executable
+        echo "#!${stdenv.shell}" >> $out/bin/$executable
+        echo "$WRAPPER ${quartus}/quartus/sopc_builder/bin/$executable \$@" >> $out/bin/$executable
+        chmod +x $out/bin/$executable
+    done
+    for executable in ${lib.concatStringsSep " " (modelsimExecutables)}; do
+        echo wrapping ${quartus}/modelsim_ase/bin/$executable
+        echo "#!${stdenv.shell}" >> $out/bin/$executable
+        echo "$WRAPPER ${quartus}/quartus/sopc_builder/bin/$executable \$@" >> $out/bin/$executable
+        chmod +x $out/bin/$executable
+    done
   '';

+  # This is the real wrapper
   runScript = writeScript "${name}-wrapper" ''
-    exec $@
+    exec -a "$1" $@
   '';
 }

BTW for reference, as for my original idea regarding implementing this idea of wrapping via symlinking $out/bin/${name} to the executables named as in ${quartus}/quartus/bin/ (https://github.com/NixOS/nixpkgs/pull/75561#issuecomment-565758484), I've managed to realize it's not possible yet due to how buildFHSUserEnv calls what's in runScript. See https://github.com/NixOS/nixpkgs/pull/83296 .

quartus_help was disabled because it requires another download, so I felt it should be optional and I hadn't gone through the trouble of setting it up, no more reason than that.
The logo is a nice find, I'll include that. The ModelSim executables look reasonable, I will add them. However, I don't like having multiple loops with redundant elements. In this case, there is a bug here from copy/paste, specifically:
+    for executable in ${lib.concatStringsSep " " (modelsimExecutables)}; do
+        echo wrapping ${quartus}/modelsim_ase/bin/$executable
+        echo "#!${stdenv.shell}" >> $out/bin/$executable
+        echo "$WRAPPER ${quartus}/quartus/sopc_builder/bin/$executable \$@" >> $out/bin/$executable
+        chmod +x $out/bin/$executable
+    done

should be ${quartus}/modelsim_ase instead of ${quartus}/quartus/sopc_builder.
in my original version I had two copies of each executable, with the following reasoning:

the original paths ($out/quartus/bin/*, $out/quartus/sopc_builder/bin/*, $out/modelsim_ase/bin/*) in case people had scripted against a standard quartus install dir
links in $out/bin/* for a better user experience with nix run.

so I think it's useful to keep both.
Is the -a $1 in exec $@ necessary? Since the first item of $@ is passed as the command name anyway? In the change you proposed to buildFHSUserEnv it makes sense (since it's -a $0) but for -a $1 I think it's redundant.

I've pushed some of the changes, mostly adding the ModelSim executables. I think I explained above why I didn't merge any of the others, but let me know what you think.

should be ${quartus}/modelsim_ase instead of ${quartus}/quartus/sopc_builder.

That is correct :grimacing: I've edited the comment almost right after I've sent it hoping you won't notice.

Is the -a $1 in exec $@ necessary? Since the first item of $@ is passed as the command name anyway? In the change you proposed to buildFHSUserEnv it makes sense (since it's -a $0) but for -a $1 I think it's redundant.

You were right, that was a mistake.

An extremely belated thanks to you two for your work on this! I was indeed the user you mentioned and it did work very well for my purposes.

An extremely belated thanks to you two for your work on this! I was indeed the user you mentioned and it did work very well for my purposes.


[match] Add digest as parameter to match

port of https://github.com/hjanuschka/fastlane-plugin-cryptex/pull/10 to match.
to not break BC - default to md5
@nickgsc explained it very well:
Quote (https://github.com/hjanuschka/fastlane-plugin-cryptex/pull/10#issuecomment-384307855):
OpenSSL 1.1.0f (on Debian Jessie):
Message Digest commands (see the `dgst' command for more details)
blake2b512        blake2s256        gost              md4
md5               rmd160            sha1              sha224
sha256            sha384            sha512

LibreSSL 2.2.7 (MacOS High Sierra):
Message Digest commands (see the `dgst' command for more details)
gost-mac          md4               md5               md_gost94
ripemd160         sha               sha1              sha224
sha256            sha384            sha512            streebog256
streebog512       whirlpool

OpenSSL 1.0.2o (MacOS via Brew):
Message Digest commands (see the `dgst' command for more details)
md4               md5               mdc2              rmd160
sha               sha1

ohhh forgot to pull - seems to be fixed already, damn!


Add comment and handle intersection types in gotoType

Follow up on #4632

Can you port this into master @mhegazy?

Ping

Ping

He's in Egypt :wink: Does someone else need to handle this? I don't see a bug on it

this is fairly stale by now. closing.


Missing react@* in peerDependencies

Using Yarn 2.0 release candidate I get the following error:
➤ YN0002: │ react-color@npm:2.17.3 doesn't provide react@* requested by @icons/material@npm:0.2.4

Seeing as react-color has a dependency on @icons/material, it is also responsible for in some way providing it's peer dependencies, in this case react. This is strictly enforced in Yarn Plug'n'Play which will be default in Yarn 2.0.

Seems like I was a little quick to throw blame, the missing peerDep was only a warning. And the error is unrelated.
This should still probably be addressed before Yarn 2.0 is released.

any news?


Access to the path '\AppData' is denied.

I am using SQL Storage for my web api. I set the MS_SqlStoreConnectionString connection string in the web.config file. It's working as expected on my dev machine. But when deployed to IIS, I got this exception when register a new web hook.
Access to the path '<user>\AppData' is denied.
I tried setting write permission for NETWORK SERVICE but it didn't work.
Please help.

I got a different exception when I set write permission for IIS_IUSER:
General error during 'Insert' operation: 'The system cannot find the file specified.
Not sure what file it's trying to access during insert when I am using sql storage.


[3.0] Axis invisible when light is too bright

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot 3.0
Issue description:
If you set the brightness of a light to 16, the movement axis for an object get drowned out by the glare
http://i.imgur.com/WuD7H7T.png
The expected behavior would be that the axis are layered on top at full brightness. So the only circumstance you couldn't see them would be if the object underneath was the same color
Steps to reproduce:
Create an object (such as a cylinder)
Create a directional light
Set the energy to 16
Select the object
Turn the camera so you are looking at the illuminated face
The axis will disappear behind the glare.

Still relevant in master

Still happening in 84abf5a
I wonder if it's just a matter of making gizmos unshaded (if they aren't already).

@KoBeWi I think they're already unshaded, but since they're translucent, the overbright colors of the lit material will cause the translucent gizmos to be invisible.
I'll close this as a duplicate of #16154, since it's almost the same issue.


DCP error for LP with one parameter, which passes is_dcp(dpp=True))

I have constructed a minimal breaking example for an issue I have been running into trying to use parameters. In fact, I will just use the example from the cxvpy website section on parameters
import cvxpy as cp
x = cp.Variable()
y = cp.Variable()
gamma = cp.Parameter(nonneg=True)
problem = cp.Problem(cp.Minimize(gamma * y), [y == gamma * x])
print("Is DPP? ", problem.is_dcp(dpp=True))
print("Is DCP? ", problem.is_dcp(dpp=False))

As stated on the website, this prints "True" and "True". However, if I instantiate the problem by setting the gamma parameter to have value 1, and then solve,
gamma.value=1
problem.solve()

I get a DCP error:

.

@ericlux what version of cvxpy are you using? I actually don't get any error when I run this.

This was running 1.1.13. It looks like with 1.1.18 it goes away. Sorry, I didn't even realize I was on an out of date installation!

No problem, glad it's fixed!


[Improvement](segment iterator) remove range in first read to save time

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

could we provide any performance result?

LGTM

run buildall

run buildall

could we provide any performance result?

updated


remove ec2 instance suffixes

fixes #793

@dobbymoodge @jim-minter ptal
[test]

Won't this bring up two different instances with the same name?  Doesn't sound like a good idea to me.  "Name" => "rhel_#{ENV['USER']}" is hacky but would it do instead?

huh, looks like the info isn't exactly redundant - this creates two VMs, blahblah-buildnum-rhel and blahblah-buildnum-windows. It looks like the code will need to be a little more complex; it might be best to put the additional info between the image name and the buildnum, which means splitting and reconstructing that string...

@jim-minter That also breaks the prune script, which is looking for something like /origin_.*(\d+)/

s/^(.+)_(\d+)$/\1_rhel_\2/

When running locally, it's improbable that the name will be of the form blahblah-buildnum - suggest that if it ends _\d+, then insert the text before the final _\d+, otherwise append as is currently.  Plus comment/link to this issue.

Maybe change the job definition to build $USER without the buildnum, and then do something like:
"Name" => "#{ENV['USER']}_rhel#{ENV['BUILDNUM'] ? "_#{ENV['BUILDNUM']}" : ""}"

or maybe construct that string beforehand so it doesn't look like code vomit.

rhel_user = "#{ENV['USER']}_rhel"
rhel_user += "_#{ENV['BUILDNUM']}" if ENV['BUILDNUM']
...

I was going off @dobbymoodge's issue report which indicated that the ec2 instance name already includes the job name anyway:

This line yields instances named like "origin_test_pull_requests_s2i_windows_258-windows".

(and presumably anyone running locally would run rhel OR windows as separate invocations, again passing a unique name to each)

@bparees looks like vagrant up with this vagrantfile will always bring up both kinds of VMs.

yeah i see that now.  Not really convinced it's a problem, though.  You get two instances w/ the same name, but that doesn't bother ec2 and once is clearly a rhel machine and the other is clearly a windows machine. [/shrug]

i guess it might cause the job some confusion when it goes to terminate things.